Data Preview Fails for Selected Tables

Expected results
Data preview should show all tables in the same database without problems.
Actual results
Table not loading for this particular table.

Error message in debug mode:
Triggering query_id: 6
INFO:superset.views.core:Triggering query_id: 6
timeout can't be used in the current context
WARNING:superset.utils.core:timeout can't be used in the current context
signal only works in main thread
Traceback (most recent call last):
File "/amundsen/amundsen/amundsendatabuilder/venv/lib/python3.6/site-packages/superset/utils/core.py", line 584, in enter
signal.signal(signal.SIGALRM, self.handle_timeout)
File "/usr/lib/python3.6/signal.py", line 47, in signal
handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread
ERROR:superset.utils.core:signal only works in main thread
Traceback (most recent call last):
File "/amundsen/amundsen/amundsendatabuilder/venv/lib/python3.6/site-packages/superset/utils/core.py", line 584, in enter
signal.signal(signal.SIGALRM, self.handle_timeout)
File "/usr/lib/python3.6/signal.py", line 47, in signal
handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread
Query 6: Executing 1 statement(s)
INFO:superset.sql_lab:Query 6: Executing 1 statement(s)
Query 6: Set query to 'running'
INFO:superset.sql_lab:Query 6: Set query to 'running'
Query 6: Running statement 1 out of 1
INFO:superset.sql_lab:Query 6: Running statement 1 out of 1
Query 6: <class 'pyodbc.ProgrammingError'>
ERROR:superset.sql_lab:Query 6: <class 'pyodbc.ProgrammingError'>
INFO:werkzeug:<IP_ADDRESS> - - [14/Aug/2020 09:15:10] "POST /superset/sql_json/ HTTP/1.1" 500 -
How to reproduce the bug

start docker-compose
start superset
navigate to tables under localhost:5000
certain tables will be able to allow users to preview, some others will fail... (I'm not sure but I'm guessing it might have to do with the data types of the tables?)

Environment

Amunsen version used: latest version I believe

Ubuntu 18.04 LTS

Firefox v79

superset version: 0.36.0

python version: 3.6.9

the commands to check versioning didn't work so I looked up on the docs at https://github.com/amundsen-io/amundsenfrontendlibrary

node.js version: v10 or v12
npm version: >- 6.x.x

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@debbielee1996 any success on this?

@debbielee1996 any success on this?

unfortunately no...

unfortunately no...

@debbielee1996 can you test against a newer version of Superset? If this persists I can help figure out what needs to be changed either on Superset or Amundsen to make this work.

@debbielee1996 can you test against a newer version of Superset? If this persists I can help figure out what needs to be changed either on Superset or Amundsen to make this work.

@villebro i have tried with superset 0.38. In my case the POST request from amundsen end is not reaching the superset end.
//post req from superset client in amundsen//
requests.post(self.url, data=request_data, headers=headers)
Above returns with HTTPStatus.INTERNAL_SERVER_ERROR
I am using a superset with no authentication. (Public access)

@villebro i have tried with superset 0.38. In my case the POST request from amundsen end is not reaching the superset end.
//post req from superset client in amundsen//
requests.post(self.url, data=request_data, headers=headers)
Above returns with HTTPStatus.INTERNAL_SERVER_ERROR
I am using a superset with no authentication. (Public access)


Fix sysbench's Dockerfile

Description
The Dockerfile for sysbench was missing benchmark-wrapper and wouldn't build for AARCH64.
Fixes

Install benchmark-wrapper in sysbench's Dockerfile
Update pip3 inside the container so it will build on a Raspberry PI4

Can one of the admins verify this patch?

Thanks for taking the time to do this! Can you move the snafu install steps after the sysbench install steps? Will help speed up builds in the future as we start to take advantage of layer caching.

Done. I was thinking that eventually benchmark-wrapper could have its own Dockerfile and that could be the base image. Would get rid of a lot of repetitions in the other Dockerfiles and speed up the builds.

Looks great, thank you! On the base images, that's definitely something that we have in the works. We recently did a review of benchmark-wrapper and am right now going through a "modernization" period of changes.


Fixed space and icon display issues before and after the input box

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev-1.2.1@b3418c8). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             dev-1.2.1    #1798   +/-   ##
============================================
  Coverage             ?   13.36%
============================================
  Files                ?      282
  Lines                ?    13960
  Branches             ?     2259
============================================
  Hits                 ?     1866
  Misses               ?    11888
  Partials             ?      206

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3418c8...b455fe5. Read the comment docs.

+1


Feature: Implement TryAsRef<ForwardToLeader<..>> for RaftError

Easing client implementation

This change is

There are some compile error. It looks like the PR is not based on the latest main branch

I'll merge it and squash the commits into one.


Add Support for Parsing AIS Messages with Tag Block

Added optional removal of tag block during parsing
Implemented tests to ensure proper functionality

The command nc <IP_ADDRESS> 5631 | cargo run can be used to test AIS messages from AIS Norway

Hi @jkr78, thanks for the PR, and sorry it took me so long to have a look.
Seems like this would help make messages readable without preprocessing, which is helpful. Ultimately, I'd love to actually parse the tag, too. Looks easy enough.
But this is a good start for the moment, and the backwards compatibility is a plus.
There's an issue #15 for tag parsing, for the future.


Re-enable streaming

In Build Monitoring List, we can set streaming or not streaming depends
on the needs.
Resolve: #174
Signed-off-by: lanxia<EMAIL_ADDRESS>


Set default view when creating new projects

What would you like to be added?
I use Projects right now almost exclusively with Board views.
It would be great if, in the Create new project modal, I could choose the default view for that project, which is then created immediately with the project.
Alternatively, allowing us to set the default views to create for every new project in the general plugin settings window would also be great.
It makes me dream of being able to define project templates for new projects to use with all the different views and their statuses, predefined fields, etc all set up already...
Why is this needed?
Every time I create a new project, it creates the Table view and I have to add a Board view, drag that to the left, etc. It would be great if I could just choose the Board view als default view and have it be created immediately at project creation. Thanks!

Related to #146


Getting an error for tensors with partial shape information with tf.contrib.staging.StagingArea

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.7.0
Python version: 3.5.2
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 9.0/7.0.5
GPU model and memory: TitanX 12Gb
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
When using tf.contrib.staging.StagingArea to prefetch data to the GPU from a tf.data pipeline. I get the following output:
Traceback (most recent call last):
  File "trainer.py", line 387, in <module>
    main(ARGS)
  File "trainer.py", line 49, in main
    thread_count=args.thread_count, use_nccl=args.use_nccl
  File "trainer.py", line 161, in train
    features = stage([features])
  File "trainer.py", line 112, in stage
    get_tensors = [tf.reshape(gt, t.get_shape()) for (gt,t) in zip(get_tensors, tensors)]
  File "trainer.py", line 112, in <listcomp>
    get_tensors = [tf.reshape(gt, t.get_shape()) for (gt,t) in zip(get_tensors, tensors)]
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_array_ops.py", line 6113, in reshape
    "Reshape", tensor=tensor, shape=shape, name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 528, in _apply_op_helper
    (input_name, err))
ValueError: Tried to convert 'shape' to a tensor and failed. Error: Cannot convert a partially known TensorShape to a Tensor: (1, ?)

Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
def stage(tensors):

    staging_area = tf.contrib.staging.StagingArea(
        dtypes=[tensor.dtype for tensor in tensors],
        shapes=[tensor.get_shape() for tensor in tensors]
    )
    put_op = staging_area.put(tensors)
    get_tensors = staging_area.get()

    get_tensors = [tf.reshape(gt, t.get_shape()) for (gt,t) in zip(get_tensors, tensors)]

    return put_op, get_tensors

dataset = tf.data.TFRecordDataset([source])
dataset = dataset.map(parse, num_parallel_calls=thread_count)
dataset = dataset.apply(tf.contrib.data.padded_batch_and_drop_remainder(
    batch_size, ([None], [], [None])
))
if shuffle:
    dataset = dataset.apply(tf.contrib.data.shuffle_and_repeat(shuffle_buffer_size, 1))
dataset.prefetch(2 * gpu_count)
iterator = dataset.make_initializable_iterator()

for gpu in range(gpu_count):
    with tf.device('/device:CPU:0'):
        features, timesteps, labels = iterator.get_next()
        labels = tf.deserialize_many_sparse(labels, dtype=tf.int32)

        device = '/device:GPU:{}'.format(gpu)
        with tf.device(device):
            scope_name = 'clone_{}'.format(gpu)
            with tf.variable_scope(scope_name) as scope, tf.name_scope(scope_name):
                features = stage([features])

Does it work if you replace tf.reshape(gt, t.get_shape()) with tf.reshape(gt, tf.shape(t))?

@mrry dude you are freaking awesome! If you are ever in S. FL I owe you lots of :beers:. That worked but I'm getting this weird error:
Traceback (most recent call last):
  File "trainer.py", line 404, in <module>
    main(ARGS)
  File "trainer.py", line 48, in main
    thread_count=args.thread_count, use_nccl=args.use_nccl
  File "trainer.py", line 182, in train
    mixed_mode=mixed_mode, use_gpu=True)
  File "/home/thomas/projects/thomas/deepspeech2/deepspeech2/models/asr.py", line 21, in asr_logits
    data_format=data_format, is_training=is_training, mixed_mode=mixed_mode, padding='SAME'
  File "/home/thomas/projects/thomas/deepspeech2/deepspeech2/layers/convolution.py", line 52, in convolution_layer
    z = tf.nn.conv2d(x, W, strides, padding, data_format=data_format, dilations=dilations)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_nn_ops.py", line 956, in conv2d
    data_format=data_format, dilations=dilations, name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 513, in _apply_op_helper
    raise err
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 510, in _apply_op_helper
    preferred_dtype=default_dtype)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1104, in internal_convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py", line 235, in _constant_tensor_conversion_function
    return constant(v, dtype=dtype, name=name)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py", line 214, in constant
    value, dtype=dtype, shape=shape, verify_shape=verify_shape))
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/tensor_util.py", line 532, in make_tensor_proto
    append_fn(tensor_proto, proto_values)
  File "tensorflow/python/framework/fast_tensor_util.pyx", line 108, in tensorflow.python.framework.fast_tensor_util.AppendObjectArrayToTensorProto
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/util/compat.py", line 68, in as_bytes
    (bytes_or_text,))
TypeError: Expected binary or unicode string, got <tf.Tensor 'clone_0/clone_0/truediv:0' shape=(2, 1, 1, ?) dtype=float16>

Actually I think this issue is on my end. I will update the issue shortly. Thanks again!

@mrry Once again, thx a bunch! The issue was resolved.

Thanks for confirming!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/98798

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/100815

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/100965

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/101433

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/102198

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105972

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/107701

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110127

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/113125


libs: Add aio.api.nist

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>

@htuch as discussed offline this is the CVE scanner package separated out
i have not included the integration tests for now (cf #311 )
there are still a couple more steps before we can land this in envoy

@phlax works with me, thanks.


Add Netron 4.2.7

Microsoft Reviewers: Open in CodeFlow

"We can confirm that the application "Netron-Setup-4.2.7" (sha256 – “63adfd8e52604ed7638a677678a4e52d798ef27926859728f1bbc33c6a447f24”) has since established reputation and attempting to download or run the application should no longer show any warnings.


Update samples to use UI Library

Purpose
We want to provide samples that customers can use that use what we would suggest they build with. Before they were using React components built up specifically for the hero sample and now we would be using the UI Library. All of the code is going to be replaced in main.
Pull Request Type
What kind of change does this Pull Request introduce?

Remove dist file committed:

Comment for Chat/public/favicon.ico
Update to be the ACS favicon used in aka.ms/acsstorybook instead of the react one?


Add eslint prettier plugin

I imagine with the recent rise in popularity of prettier, this eslint plugin might be a good addition for hound (at least we would like to use it :smile:).

I don't see a reason to not to support it. Opened #111 to address this.


Convert the provider to a Provider Family

What problem are you facing?
As the provider grows to cover more of the Equinix API surface area, the number of CRDs will expand.
Crossplane has adopted a concept called Provider Families, which improves the performance on K8s clusters in the presence of many CRDs.
This provider is in an early enough stage to adopt families now ahead of changes to add more resources. Because this provider is generated, these changes should be minimal.

https://blog.crossplane.io/crd-scaling-provider-families/?utm_campaign=2023_Q2_EVER_GBL_CT_New-Provider-Families&utm_medium=slack&utm_source=crossplane&utm_term=blog&utm_content=new-provider-families-release
https://github.com/crossplane/crossplane/blob/7fa9184/design/design-doc-smaller-providers.md

How could Equinix Provider help solve your problem?
Split the provider into families that align to the current API Groups:

metal
ne
fabric

In the future, this could extend to other APIs (per https://developer.equinix.com/catalog):

Customer Portal
SmartView
Internet Access
Customer Resource Hierarchy
Accounts and Authentication
Digital LOA

Also see:

Migration guide
crossplane-community/#sig-provider-families

/assign @aayushrangwala

An upstream PR related to provider families and groups is the split into separate pacakges, each with their own cmd/X/ main.go generated from a main.go.tmpl dependent on  internal/controller
https://github.com/crossplane-contrib/provider-upjet-aws/pull/680/commits/5bb4816957340b4f5a17ca2d3b8b12efd946273a


feature - per language configuration, and default tick to js/ts/md

Problem
As of now, there is only one quote sequence " -> ' -> ` which is not suitable for all language (especially the tick)
Solution

Default the Tick to JavaScript, Typescript, and Markdown only.
Allow customization with togglequotes.chars For example.

"configurationDefaults": {
  "[csharp]": {
    "togglequotes.chars": ["\"","'","`"]
  }
}

Done and published as 0.2.0


cargo-tarpaulin: 0.18.5 -> 0.19.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/xd009642/tarpaulin/releases.
meta.description for cargo-tarpaulin is: "A code coverage tool for Rust projects"
meta.homepage for cargo-tarpaulin is: "https://github.com/xd009642/tarpaulin"
meta.changelog for cargo-tarpaulin is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1/bin/cargo-tarpaulin had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.19.1 with grep in /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1
found 0.19.1 in filename of file in /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
cargo-tarpaulin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-tarpaulin https://github.com/r-ryantm/nixpkgs/archive/e00f4d62b2d489bdaf4adecc88cc1e87c871b72a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1
ls -la /nix/store/x2i3n33qb44931ccqx0wcdd0ff1wy9j8-cargo-tarpaulin-0.19.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-tarpaulin

Maintainer pings
cc @hugoreeves for testing.

@ofborg eval

@ofborg eval

Result of nixpkgs-review pr 156386 run on x86_64-linux 1

1 package built:

cargo-tarpaulin


Description of smoothing parameter does not reflect the actual implementation

The current description says that smoothing, which is the factor in (smoothing_factor * maximum_radius_of_isochrone) / 10, takes values in the range of (0.0, 1.0). However, this is different from how this parameter actually works in two ways:

It is allowed to take values in the range of (0.0, 100.0) rather than (0.0, 1.0).

The dividing factor in the equation used to compute the threshold value is 100 rather than 10.

@rabidllama @TheGreatRefrigerator is this resolved?

doesn't seem to have been yet. Need to look at it to see if changes are needed in both the docs and the code


PTRENG-4872 federated import test

Added import tests to federated repos and webhooks, fixed typos, added a link to GutHub Wiki.

No info in a CHANGELOG.md is needed, we will release it next time.


Feature request: Adding sharing widgets

Is your feature request related to a problem? Please describe.
Not related to a problem
Describe the solution you'd like
There should be a feature to share bloggit on other social media by clicking on icons
Describe alternatives you've considered
Adding icons in footer.
Approach to be followed (optional)
Go to index.html
Add sharing buttons for social media icons.
Make required changes in HTML and css file.
Additional context (optional)
Give context or upload screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
Not related to a problem
Describe the solution you'd like
There should be a feature to share bloggit on other social media by clicking on icons
Describe alternatives you've considered
Adding icons in footer.
Approach to be followed (optional)
Go to index.html
Add sharing buttons for social media icons.
Make required changes in HTML and css file.
Additional context (optional)
Give context or upload screenshots about the feature request here.

What social media platforms do you want to add?

Is your feature request related to a problem? Please describe.
Not related to a problem
Describe the solution you'd like
There should be a feature to share bloggit on other social media by clicking on icons
Describe alternatives you've considered
Adding icons in footer.
Approach to be followed (optional)
Go to index.html
Add sharing buttons for social media icons.
Make required changes in HTML and css file.
Additional context (optional)
Give context or upload screenshots about the feature request here.

Hey @KerinPithawala , which social media platforms do you want to add?

Is your feature request related to a problem? Please describe.
Not related to a problem
Describe the solution you'd like
There should be a feature to share bloggit on other social media by clicking on icons
Describe alternatives you've considered
Adding icons in footer.
Approach to be followed (optional)
Go to index.html
Add sharing buttons for social media icons.
Make required changes in HTML and css file.
Additional context (optional)
Give context or upload screenshots about the feature request here.

Hey @KerinPithawala , which social media platforms do you want to add?

Twitter, Linkedin, Pininterest

Twitter, Linkedin, Pininterest

Twitter, Linkedin, Facebook and Pinterest as they would suitable for sharing blog.

Remove Pinterest from the list. You can start working on rest of them, also today is the last day for NWoC.

Twitter, Linkedin, Facebook and Pinterest as they would suitable for sharing blog.

Remove Pinterest from the list. You can start working on rest of them, also today is the last day for NWoC.


Add the index.html file1

Add the index.html file1

review1

"github error"
Pull request authors cannot approve their own pull requests.
Review required.
-Resolved review errors by:
-Steps done to fix:
in Github Settings --->
Branch protection rules settings -->
tick-Require review from Code Owners;


Can't use flit on Windows because UnicodeEncodeError

I try flit build on Windows, and got this result.
%PYTHON%\python.exe -m flit build
Traceback (most recent call last):
  File "C:\Python34\lib\runpy.py", line 170, in _run_module_as_main
    "__main__", mod_spec)
  File "C:\Python34\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Python34\lib\site-packages\flit\__main__.py", line 5, in <module>
    main()
  File "C:\Python34\lib\site-packages\flit\__init__.py", line 120, in main
    main(args.ini_file, formats=set(args.format or []))
  File "C:\Python34\lib\site-packages\flit\build.py", line 21, in main
    wheel_info = wheel_main(ini_file)
  File "C:\Python34\lib\site-packages\flit\wheel.py", line 203, in wheel_main
    wb = WheelBuilder(ini_path, fp)
  File "C:\Python34\lib\site-packages\flit\wheel.py", line 44, in __init__
    self.ini_info = inifile.read_pkg_ini(ini_path)
  File "C:\Python34\lib\site-packages\flit\inifile.py", line 114, in read_pkg_ini
    return _validate_config(cp, path)
  File "C:\Python34\lib\site-packages\flit\inifile.py", line 150, in _validate_config
    raw_desc =  f.read()
  File "C:\Python34\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 669: character maps to <undefined>

Thanks for the report!

@takluyver My pleasure. Thanks for your great project, it saves my life.

:-)


Add altair.app v1.5.1

After making all changes to the cask:

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[X] Named the cask according to the token reference.
[X] brew cask install {{cask_file}} worked successfully.
[X] brew cask uninstall {{cask_file}} worked successfully.
[X] Checked there are no open pull requests for the same cask.
[X] Checked the cask was not already refused in closed issues. - Corrections made.
[X] Checked the cask is submitted to the correct repo.

This was previously submitted in #35443 by the project author, but was rejected for various reasons. I hope to have remedied those in this new PR.
CC @imolorhe


ring: remove struct field npeers and peerlist from mod

The Mod ring is pretty simple, so, while there were questions around it earlier, this is fine.


chore: upgrade to latest React 18 experimental version

Description
This migrates from the deprecated pipeToNodeWritable to the new renderToPipeableStream in the latest React 18 ~beta~ experimental version.
Closes #20

Before submitting the PR, please make sure you do the following:

[x] Add your change under the Unreleased heading in the package's CHANGELOG.md
[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository for your change, if needed

Looks like the testing library throws error with the new React version.
@cartogram Are you familiar with @shopify/react-testing? I've tried to update it from ReactDOM.render to ReactDOM.createRoot but then it complains about The current testing environment is not configured to support act(...).
Another error thrown is Unable to find node on an unmounted component. when calling mount(...) 🤯

I've reported the issue in https://github.com/Shopify/quilt/issues/2095 . I've tried debugging it but couldn't find a way to fix it :/

@cartogram I mean, should we merge this so we can start using React experimental in other PRs? Or try to fix the skipped test before that?

Sorry, I meant merge this so we can start using React experimental in other PRs.

Sorry, I meant merge this so we can start using React experimental in other PRs.


Upgrade to InkScape 1.0 /1.1dev

I'm not going to merge this as is for the following reasons.

You have deleted the jpeg images, why?
You have added the files from Inkscape_helper. Why not add them as a submodule?
You have checked in the __pycache__ folder.


Push potentially blocking bits of Fetch() off onto a thread pool.

Also, the Travis failure looks like it's related:
https://travis-ci.org/google/certificate-transparency/builds/66559727#L1832


Red screen when file download fails

React Native red screen appears. An error message should be shown instead.
Error message:
May 15 10:37:46 CampusGuide[19267]: 'Failed to update configuration.', { [Error: Download of file /transit.json failed. Status code: 404]
	  line: 66369,
	  column: 36,
	  sourceURL: 'http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false' }

Fixed with commit a0100c1ac828795b7423e6fbf50feed28a3e6a75


Fix process bundle one shot test to avoid long timeouts

What does this PR do?
Fixes a test which takes a minute to timeout trying to reach the core-agent to retrieve a hostname before falling back on the local hostname.
https://github.com/DataDog/datadog-agent/blob/3030ec2d30f9080f490fcc1e69d88101ba43d6ef/pkg/process/checks/host_info.go#L87
This sets a static hostname to bypass the core-agent check completely.

Before the change

After the change

Motivation
Test speed and hygiene
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Reviewer's Checklist

[x] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[x] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[x] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


OCSP Stapling Support

Ansible bigip_ssl_certificate task doesn't appear to have an option to enable OCSP based cert status monitoring yet.
Ansible bigip_profile_client_ssl additionally doesn't appear to have the option to enable OCSP stapling in the client SSL profile.

Fixed via commit 3debdb6


Improve deleting messages, finished message and remove prune command.

title

Hey Laaru, thank you for sharing! The reason I have my current implementation with the /prune command is because actually sending that command in the channel counts as another message sent by your user, so you are essentially getting double the number of messages sent as opposed to the normal amount if the messages are deleted behind the scenes as in your implementation.
For the purposes of this repository, I am going to stick with what I currently have, but if that method works well for you then more power to you :) hope you had a happy Fourth, cheers!

Hey Laaru, thank you for sharing! The reason I have my current implementation with the /prune command is because actually sending that command in the channel counts as another message sent by your user, so you are essentially getting double the number of messages sent as opposed to the normal amount if the messages are deleted behind the scenes as in your implementation.
For the purposes of this repository, I am going to stick with what I currently have, but if that method works well for you then more power to you :) hope you had a happy Fourth, cheers!

I doubt any bot will have like 1 or 2 second delay.


Excellent Document That Applies to Real-World Situations

This was the ideal document, free of code defects, and most applicable to my situation, and probably most applicable to others who have to build VMs in an IaaS situation.
Thanks for a job well done.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 675c83b0-1d6e-ca23-5434-0618c49d07b8
Version Independent ID: 7bf9e30b-9e45-5941-b3a3-ae3bfc46c0b5
Content: Create a Linux virtual machine by using PowerShell in Azure Stack
Content Source: articles/azure-stack/user/azure-stack-quick-create-vm-linux-powershell.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

@hankwojteczko Thank your note! :)
@please-close

@hankwojteczko We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add docker image labels and version env variables

Description
This PR includes the following proposed change(s):

Adds docker labels to final built images to link to the source git version
Adds environment variables

APP_VERSION - Should contain the git tag built from
GIT_SHA - The full git SHA of the version built

These values come from build args that are passed in when building the images. If build args are not supplied, these values will be set to not-set.  The build pipelines are being updated as well.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Does the change impact or break the Docker build?

[x] Yes
[ ] No

If Yes: Has Docker been updated accordingly?

[x] Yes
[ ] No

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

Looks good, but can you add a README or batch script or something to the image-streams folder so we know how to push a new image?

Added, see infrastructure/openshift/README.md


Switching from rocko to master on rpi-0w breaks wifi

Description
Changing from latest on rocko to latest on master makes it so that the wlan0 interface doesn't show up anymore.
Steps to reproduce the issue:

pull latest master
build rpi-hwup-image
run ip link or anything that lists the interfaces, only l0 shows up

Describe the results you received:
wlan0 isn't connected
Describe the results you expected:
wlan0 should be present.
Additional information you deem important (e.g. issue happens only occasionally):
Switching back to rocko without changing anything makes it work again.
Additional details (revisions used, host distro, etc.):
I also tried updating poky to master and it didn't improve anything.
The reason I'm updating to master is to make use of #183

Hi guys,
I can confirm that wifi does not come up in the master branch and it does in rocko. The problem is that the file brcmfmac43430-sdio.bin is not copied into the /lib/firmware directory in the built image and only the brcmfmac43430-sdio.txt file is copied. If you manually copy the binary file to the built image, the rpi0w brings the Wifi interface just fine.
In rocko this works fine. I suspect the fail-safe conditional done in the recipe is not working anymore (maybe an upstream change of the firmware binary?). There are no warnings raised during the build. Seems @agherzan was working on recent commits of the recipe and maybe can spot the problem faster than me.
I will try to debug it anyway and provide feedback or a PR accordingly.
@keeslinp :  if you want your image built using master to work, no need to rebuild. Just copy the binary file (.bin) alongside the txt file (.txt) in the built image's /lib/firmware/brcm folder and it will work.

Hi all again.
I think I pin-pointed the problem now. The commit 61c2a96 introduced an rpi-specific condition for the linux-firmware. However, this block:
FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Is not adding the brcmfmac43430-sdio.bin file in the final package. If I remove the condition _rpi it works fine again. Also, if I keep the condition but I add the binary file explicitly, like this:
FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.bin \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

it works too. I'm not sure what would be the correct solution. The _rpi condition should be kept as this is a customisation only necessary for rpi devices. But FILES_${PN}-bcm43430 should contain the binary file already as it has without the _rpi conditional.
Perhaps BitBake is parsing this in a way we are not considering?
Also, if we mirror this block:
SRC_URI_append_rpi = " \
    file://brcmfmac43430-sdio.bin \
    file://brcmfmac43430-sdio.txt \
"

We perhaps should keep both files in FILES_${PN}-bcm43430 as well.
What do you suggest @kraj , @agherzan , @mirzak ?  I can create a PR according to your comments and we can merge it. This will fix bringing up Wifi (and potentially bluetooth) in master.

FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.bin \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

seems to be correct.

@hhromic could you post the output of bitbake -e linux-firmware ? We can check SRC_URI and the _rpi logic. Perhaps _rpi isn't set for rpi0-wifi?
If you can't run bitbake because of the base_conditional issue, it's a known bug fixed by commit 99aa19ff53922b61dee0c8b63ee7f664f90e9a91 in meta-openembedded (which is in master now).

hi @martingkelly, I already sorted out the base_conditional issue, as you say I just pulled the latest commits and all is fine, thanks for the suggestion!.
Regarding the firmware issue, after your comments I did the following tests:
(1) Recipe as-is from the master branch.
In Recipe:
FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Output:
$ bitbake -e linux-firmware | grep ^FILES_linux-firmware-bcm43430
FILES_linux-firmware-bcm43430="      /lib/firmware/brcm/brcmfmac43430-sdio.txt "
FILES_linux-firmware-bcm43430_rpi="      /lib/firmware/brcm/brcmfmac43430-sdio.txt "

(2) Recipe modified to include the binary file.
FILES_${PN}-bcm43430_rpi += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.bin \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Output:
$ bitbake -e linux-firmware | grep ^FILES_linux-firmware-bcm43430
FILES_linux-firmware-bcm43430="      /lib/firmware/brcm/brcmfmac43430-sdio.bin     /lib/firmware/brcm/brcmfmac43430-sdio.txt "
FILES_linux-firmware-bcm43430_rpi="      /lib/firmware/brcm/brcmfmac43430-sdio.bin     /lib/firmware/brcm/brcmfmac43430-sdio.txt "

(3) Recipe modified to not add _rpi conditional.
In Recipe:
FILES_${PN}-bcm43430 += " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Output:
$ bitbake -e linux-firmware | grep ^FILES_linux-firmware-bcm43430
FILES_linux-firmware-bcm43430="   /lib/firmware/brcm/brcmfmac43430-sdio.bin       /lib/firmware/brcm/brcmfmac43430-sdio.txt "

(4) Recipe modified to use _append instead of +=, like is done for SRC_URI.
In Recipe:
FILES_${PN}-bcm43430_append_rpi = " \
    ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.txt \
"

Output:
FILES_linux-firmware-bcm43430="   /lib/firmware/brcm/brcmfmac43430-sdio.bin      /lib/firmware/brcm/brcmfmac43430-sdio.txt "

This last result is what I think is the expected outcome. The first and second tests create an additional FILES_linux-firmware-bcm43430_rpi that I don't think should be there, as that should be a conditional assignment. However the fourth test correctly append the extra NVRAM text file to the existing binary firmware, conditioned to _rpi, very similar to SRC_URI is handled.
If you agree with this behaviour and solution, I can create a PR to fix it. Thanks a million for your help!

I see your test results and am fine with your proposal if it works. I am, however, confused. The linux-firmware recipe already includes:
FILES_${PN}-bcm43430 = " \
  ${nonarch_base_libdir}/firmware/brcm/brcmfmac43430-sdio.bin \
"

I'm not sure why adding the bin file is required since it should already be present.

Is should be _append_rpi instead of _rpi +=
Since he latter overwrites any prior value that’s what you are seeing

@kraj why does += overwrite any prior value? Doesn't that break its purpose?

Its the override that’s causing it with append that gets addresses

@hhromic Your option 4 worked like a charm for me :). I had looked into that commit but I couldn't make heads or tails of it, yocto configs are witchcraft 80% of the time for me, I'm glad you could figure it out!

Maybe I spoke too soon, my bluetooth isn't working anymore. hciconfig isn't returning anything. Also, I'm getting an error in journalctl for hciattach:
Can't open serial port: No such file or directory
Can't initialize device: No such file or directory

Is this related to this issue or should I make a different ticket?

@martingkelly: in my last proposal (test 4) I'm not adding anymore the binary file because using _append properly appends the text NVRAM file to the list keeping the binary file from the orginal recipe.
@kraj : thanks for the confirmation that using _append is the correct solution. I will prepare a PR with this fix so it can be merged.
@keeslinp : I'm happy the solution number four worked for you. This is the correct solution for the firmware missing problem.
Regarding your new bluetooth problem, it might or might not be related. I can help you debug this in the coming days.
The First question I have: did the bluetooth come up fine before applying option 4? in other words, when the firmware was not included bluetooth was working?
Let first make sure Wifi is fixed and close this issue, then we can open a new issue to diagnose the bluetooth radio. I haven't tried it on my own so I'm not sure (yet) what could be wrong.
Cheers!

@hhromic yes, when I tried master the first time the bluetooth worked fine but the wifi did not. Now, the opposite is true after applying option 4

@keeslinp , that is very weird indeed. Adding the firmware shouldn't nullify bluetooth.
I was checking my image and by default it doesn't come with hciattach. This means you are adding it into your local config. Can you share your current local.conf file? Perhaps there is something else that is interfering.
Before making the PR for the linux-firmware I would like to confirm it doesn't interfere with bluetooth as you suggest.
I'm going to build another test image for this purpose, that will take a while as you know.

I posted it a little further up in this thread. When I get back to work on
Monday I'll check again to make such I'm doing everything right.
On Sat, Feb 3, 2018, 4:24 AM Hugo Hromic<EMAIL_ADDRESS>wrote:

@keeslinp https://github.com/keeslinp , that is very weird indeed.
Adding the firmware shouldn't nullify bluetooth.
I was checking my image and by default it doesn't come with hciattach.
This means you are adding it into your local config. Can you share your
current local.conf file? Perhaps there is something else that is
interfering.
Before making the PR for the linux-firmware I would like to confirm it
doesn't interfere with bluetooth as you suggest.
I'm going to build another test image for this purpose, that will take a
while as you know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/agherzan/meta-raspberrypi/issues/184#issuecomment-362799240,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC6-bIVZSVbI_EJPRPqJLeHyOb58CRxGks5tREHlgaJpZM4RuYXr
.

Hi @keeslinp ,  try to add udev-rules-rpi into your IMAGE_INSTALL_append and see if it works.
This package adds rules for udev to create the serial0 and serial1 devices that hciattach is trying to use. I checked and, similar to the firmware, this package is not installed by default.
Let me know if this works (together with working Wifi too).

Hi again @keeslinp , I just tested an image using:
MACHINE = "raspberrypi0-wifi"
IMAGE_INSTALL_append = " bluez5 udev-rules-rpi linux-firmware-bcm43430 wpa-supplicant"

And I can confirm I get bluetooth and Wifi working fine. Of course this image is minimal, so you need to attach the HCI manually:
hciattach /dev/ttyAMA0 bcm43xx 921600 noflow -

In your systemd configuration, the bluez package comes with a service to do this operation automatically. After that, the BT device is correctly initialised and you can discover devices:
bluetoothctl
[bluetooth]# power on
[bluetooth]# scan on

So BT is not affected by the Wifi firmware fix. I'm going to issue a PR soon.
@keeslinp : let us know if you could get it working !

I'm OK in starting to include the firmware as part of machine essential - sounds like there are many people confused by the current behavior. If anyone is interested, please push a patch.

I agree @agherzan for rpi3 especially, where wifi/bt is on board

Yes. For RPI3 and RPI0wifi.

@hhromic That did the trick :).
Can anyone think of a reason that my bluetooth mac address would change between branches? That seems to be what I am experiencing. I mean, it's definitely not the end of the world as long as it is consistent between reboots, but just seems a little odd.

Hi all,
I know I advocated for the inclusion of the firmware as default, however after thinking more about it (and learning more about Yocto too), I now think that the way it is done currently is actually the more correct approach.

According to Yocto documentation, the MACHINE_EXTRA_RRECOMMENDS variable (current method) is for packages that are not required for the machine to boot (but desired on a more complete image), and the MACHINE_ESSENTIAL_EXTRA_* variables (proposed method) are for packages that are strictly necessary to boot. In the case of the RPI, this firmware is not strictly necessary to boot.
For the case of Bluetooth, the dependency package is bluez5 which in turn carries a lot of other packages, enlarging the basic image. Again, packages that are not strictly necessary to boot.
Yocto is designed for users to extend base images with their own more complete images. In this paradigm, the current approach of using MACHINE_EXTRA_RRECOMMENDS would include the firmware for those users, as expected.

We should always take the position of "providing the bare minimum functional building block" and then users to extend the image/layer with their own requirements. For example, Wifi/BT are not always wanted by every user. I believe is best to ask users to add what they want than to ask users to remove what they don't.
With all that, I strongly believe that the correct thing to do is to better document these things (enable Wifi, enable BT) instead of bloating the base image by default. I can volunteer to update the current documentation to add sections to clarify how to enable those extra machine features.
If you agree, please let me know if modifying the documentation folder in this repository is all is needed to update the ReadTheDocs documentation.

@keeslinp : it might be that the firmware for BT (the .hcd file) is different. Or the way the MAC address is initialised is different. I don't see any harm on this and should be consistent across reboots of the same branch.

I know this. The problem is that many new users get into this and not knowing this nuance they will obviously think of it as an issue. If we want to stick to the rule, what we can do is include MACHINE_EXTRA_RRECOMMENDS in our images. That would keep everyone happy.

Exactly, hence we need to inform/document better to the new users.
But I got confused with your message. Using MACHINE_EXTRA_RRECOMMENDS is already the way is done in the layer:
https://github.com/agherzan/meta-raspberrypi/blob/a2ba56f74ed7d1a794c3d92a0c10039c2b6e0cc6/conf/machine/raspberrypi0-wifi.conf#L9
And this is not including the firmware in the basic hwup images (as desired).
Then, we shouldn't touch the current image config (keeping the behaviour as it is) and just document that users must include the firmware (and BT packages) explicitly in their conf/local.conf by appending to IMAGE_INSTALL ?

No. What I mean is having hwup include it by default. See https://github.com/agherzan/meta-raspberrypi/blob/master/recipes-core/images/rpi-hwup-image.bb#L5.

Then, we shouldn't touch the current image config (keeping the behaviour as it is) and just document that users must include the firmware (and BT packages) explicitly in their conf/local.conf by appending to IMAGE_INSTALL ?

If they are using the rpi-hwup-image.
Other images will probably include the firmware, e.g. core-image-base which has a pretty good description.
"SUMMARY = "A console-only image that fully supports the target device
hardware.""
And I would agree that we should instead just document:

rpi-hwup-image - just for booting
core-image-base - full hardware support (or create a image based on core-image-base )

Also the problem we have today is that all the "rpi" images inherit from rpi-hwup-image, so none of them install the firmware for WiFi.
Suggestion:

Remove all the images we have today, beside rpi-test-image
Move "kernel-modules to MACHINE_EXTRA_RRECOMMENDS
Change rpi-test-image to inherit from core-image-base, and set SPLASH to raspberrypi (this could also include a SSH server)

If someone wants a "hwup" image they can use core-image-minimal

Hi all.
I've been reading more about all this and I completely agree with @mirzak here. Definitively we should be using the standard Poky images (core-image-minimal, core-image-base, etc.) instead of custom images made for the same purpose.
The whole idea of Yocto is that the same recipes adapt depending on the layers being used. So a core-image-minimal should produce a suitable image for your board depending on if we use meta-raspberrypi or meta-otheroboard.
I just tried using those standard images and indeed core-image-base successfully adds the Wifi firmware and the BT components out of the box, while core-image-minimal just produces a small image to boot, as documented. If a user wishes for absolute control, he/she can start with the minimal image and cherry-pick components such as the Wifi firmware.
I totally support the proposal of @mirzak to clean-up the redundant images (such as rpi-hwup-image  and use the standard Yocto ones. With this, we should leave the current machine configurations intact.
Question: it is possible for a time to leave rpi-hwup-image available but gracefully failing to build with a message that this image is deprecated? This would help with migrating users to the correct workflow.
If everyone agrees on this, how can we implement this change? I can help but I'm not an expert on Yocto, hence there could be things I might not be considering.

you could turn rpi-hwup-image.bb to have just
require meta/recipes-core/images/core-image-base.bb

True, but that would not instruct users that this is not the correct way and that they should be using core-image-base/minimal directly instead.
Also vanishing the image without notice would leave users puzzled why they images no longer build.
I noticed that kernel-modules is already in MACHINE_EXTRA_RRECOMMENDS and SPLASH is already set in conf/machine/include/rpi-base.inc, so the transition should be very smooth :).


Error TS18003 - 22.4.6 upgrade to 23.0.0

Since ts-jest 23.0.0
Version 22.4.6 still working.
error TS18003: No inputs were found in config file 'tsconfig.json'.Specified 'include' paths were '["src/**/*"]' and 'exclude' paths were '["./dist"]'

Delete includes: [...] in tsconfig.json can fix this but these is no option.
Older Issue:
#536

I am seeing a similar issue which might be related.  It looks like all of the paths in the tsconfig file are relative to the current working process not the current directory.  I noticed this because my tests are failing because it cannot find the file from my extends property.  I was able to reproduce this here https://github.com/plee-nm/ts-jest .  Please let me know if you need any more information.

Any updates on this?  It seems like any relative path file reading is broken from 23 release.  Please let me know if you need more information.

The latest version addressed some issues related to relative paths. Also <rootDir> can now be used in tsConfigFile as in other jest options.
Feel free to re-open this issue, providing the link to a minimal repo where we can reproduce the issue, in case the problem persist.


[Firefox addon] While a document is still loading, trigger downloading immediately to prevent the "Download" button from appearing unresponsive (issue 6660, bug 920702)

This is a tentative patch, based on the findings in https://github.com/mozilla/pdf.js/issues/6660#issuecomment-199234593, and I'm submitting it to get feedback on the implementation.
Fixes #6660.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=920702.

/botio-linux preview


Create dns CNAME for metrics load balancer

/kind enhancement
Create dns CNAME for metrics load balancer.  The address of this load balancer will be set in the CNAME metrics.prow-workloads.ci.kubevirt.io.  The CNCF manages the kubevirt.io domain since the project is a CNCF sandbox project.  Please work with them to have the CNAME created.
Prerequisite: an A record must be created first for load balancer.  Tagging @fgimenez to provide this info.

@mazzystr the load balancer is already provisioned, the CNAME metrics.prow-workloads.ci.kubevirt.io should point to prow-workloads-2007274-dal09.clb.appdomain.cloud
@rmohr FYI

@mazzystr any news?

Working on it.  The CNCF/Matrix has me.

/remove-lifecycle stale


Create getters and setters for ORtypes and ANDtypes

Per @cbayly13 's request there are now four new methods for Atoms and Bond objects
getORtypes
setORtypes
getANDtypes
setANDtypes
That allows the user to get, change, and set  OR or AND types for atoms and bonds.
@davidlmobley These methods are pretty basic, but it would let us change the underlying structure and still let users interact with it in the same/similar way.

Add a basic test of these, @bannanc ?

Merging now, adding test later.


organize skinchanger

make the skinchanger so it shows just skins for the selected weapon. its takes a lot of time to setup skins.

Duplicate #728

Daniel will not do that. I don`t know why, ask him

I found a old thread about this which might help. #296

Daniel will not do that... he does not want it. :)

@cojo1989 he got his own business going on here and idt he owe u anything. This source is completely free and opened, what's the point of begging danial for doing things that u wanted to without urself even trying to make it.  This source is completely free and opened, what's the point of begging danial for doing things that u wanted to without urself even trying to make it.

Do you saw me begging? Did you saw me ask Daniel for something beside old issues? I was just answer to the owner ticket. So please be carefull to who you reply. Thank you bro.

Now you can search skins for certain weapon.


Fix metanetkan install path

GameData is removed from latest download.

Thanks, @HebaruSan .  First time I've made a release in this repo, didn't realize it had a slightly different folder structure.


cluster lock should only protect cluster data access

Cluster lock should protec cluster data only, not be locked during engine operations.
Signed-off-by: Dong Chen<EMAIL_ADDRESS>

Need to run some tests to validate there is no dependence on this.

@wsong ran some tests for this PR.
Cluster shouldn't be locked during engine operations. The lock should be used to protect cluster data only. While each engine operation may fail, they should fail gracefully.
Ping @docker/core-swarm-maintainers.


Rename min_gpus to min_cuda_gpus

What does this PR do?
Renames the argument of the test-helper RunIf from min_gpus to min_cuda_gpus
Part of https://github.com/PyTorchLightning/pytorch-lightning/issues/13102#issuecomment-1130278238 (Renaming the accelerator will be done separately).
Split out from #13123
Does your PR introduce any breaking changes? If yes, please list them.
None in the user-code, in the test code
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

I didn't do a changelog item here as this does not affect the user-code at all
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @justusschock @awaelchli @rohitgr7 @akihironitta

Would also be fine, but I wanted it to be as close as possible to the original name to make it easier recognisable as the same thing.

Would also be fine, but I wanted it to be as close as possible to the original name to make it easier recognisable as the same thing.

well it's part of testing.... so mainly core-dev uses it the mostt and we are renaming GPU->CUDA and devices is now generic.

we are renaming GPU->CUDA and devices is now generic
That's not true. The accelerator will be renamed like that but still be discoverable with 'gpu'.

@justusschock is this to generalize to amd and other types of GPUs?

@williamFalcon Later-on this is also for AMD GPUs yes, currently this for the MPS (Mac M1 GPU) as described by @carmocca here


Cannot read property 'nickname' of undefined

Good afternoon
When starting MM on ios, an error appears:

MM version: 7.9.2
MM mobile: 2.3.0
IOS: 16.4.1

Opened https://mattermost.atlassian.net/browse/MM-52598.

Teammate Name Display a
Teammate Name Display:

Users have not been deleted from the database before.
I noticed that this error began to appear in the general channels. And it helps to go to another channel and come back. Then the chat is loaded.

Does this happen when moving to a channel and when going to the profile? I have heard of a similar issue, and may be related with the currentUser (or currentUserId) not being available in the database for some unknown reason.
The app should load fine, but moving to a channel where you have written or the profile should break. Could you confirm this is the behaviour you are seeing?

Today there was another error.

The actions were like this. Were talking in a thread. When the notification came, the application was reopened and everything worked fine. But once it gave such an error in the same thread where it had not been before. The users in the thread did not change.

This is a different issue we are also tracking down. @enahum take a look here, in case this give you more data points on this issue.

Thanks, the last one about the null query is being investigated at the moment with similar repro steps if not the same


[SPARK-14243][CORE]update task metrics when removing blocks

What changes were proposed in this pull request?
This PR try to use incUpdatedBlockStatuses  to update the updatedBlockStatuses  when removing blocks, making sure BlockManager correctly updates updatedBlockStatuses
How was this patch tested?
test("updated block statuses") in BlockManagerSuite.scala

cc @andrewor14

Test build #54641 has started for PR 12091 at commit a97d220.

Test build #54641 has finished for PR 12091 at commit a97d220.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54641/
Test PASSed.

Merged build finished. Test PASSed.

LGTM merging into master thanks for fixing.

@jeanlyn can you submit a patch for 1.6?

@andrewor14 Sorry for the late reply, I had submitted a patch for 1.6 #12150


V2 examples editorial

Changes made:

Modified the following field names in examples:

type_of_work --> types_of_work
road_num --> road_number
worker_present --> workers_present

Made sure that the raw geojson example file and the sample info shown in the markdown tables match up.
Removed some extra brackets.
Reran JSON through prettify tool.
*** It'd be best for all Boolean type data to be represented in the same way (all 1/0 or all true/false). Right now, some fields are represented by 1/0 (e.g. is_architectural_change) and some are represented by true/false (e.g. workers_present). I've changed all boolean fields in the example files to true/false for the time being, but am okay with changing them to 1/0.

true/false is the semantic choice for JSON and I'm for using this throughout 👍

Thanks! I also noticed that all data fields in the examples are stringified regardless of data type (e.g. true/false booleans are represented by "true"/"false", number 15.4 represented by "15.4").
Do we want to change the examples to use non-stringified true/false and number values? Or should we keep all fields stringified since the datetime field would remain a string? I'm okay with either option as long as we are consistent.

Do we want to change the examples to use non-stringified true/false and number values? Or should we keep all fields stringified since the datetime field would remain a string? I'm okay with either option as long as we are consistent.

We should change these to be the correct/semantic JSON data types--not strings. I had done this in previous cleanup/PRs but perhaps it was overwritten. The JSON types should reflect the data type for the field.

Do we want to change the examples to use non-stringified true/false and number values? Or should we keep all fields stringified since the datetime field would remain a string? I'm okay with either option as long as we are consistent.

We should change these to be the correct/semantic JSON data types--not strings. I had done this in previous cleanup/PRs but perhaps it was overwritten. The JSON types should reflect the data type for the field.

Agree with @j-d-b; GeoJSON is an extension of JSON so it should be compliant with the JSON spec.

Thanks @j-d-b & @DeraldDudley ! Will make these changes in the examples.

@DeraldDudley @j-d-b Are the DateTime fields supposed to be always in local time (e.g. 2018-11-13T20:20:39+01:00) or in UTC (e.g. 2018-11-13T20:20:39Z)? Sorry if I missed this in the documentation.

Are the DateTime fields supposed to be always in local time (e.g. 2018-11-13T20:20:39+01:00) or in UTC (e.g. 2018-11-13T20:20:39Z, which I'd recommend)? Sorry if I missed this in the documentation.

I'm not sure this is specified anywhere--it isn't in the data tables field description at least. Clarifying this in the field descriptions is definitely a good idea. I'm also for using UTC, especially since this is how the data should be stored in the database and the relational model is intended to facilitate that.

Are the DateTime fields supposed to be always in local time (e.g. 2018-11-13T20:20:39+01:00) or in UTC (e.g. 2018-11-13T20:20:39Z, which I'd recommend)? Sorry if I missed this in the documentation.

I'm not sure this is specified anywhere--it isn't in the data tables field description (for start_date and end_date at least. Clarifying this in these descriptions is definitely a good idea. I'm also for using UTC, especially since this is how the data should be stored in the database and the relational model is intended to facilitate that.

In the road events table we say in the notes: All date/time formats shall use ISO 8601 Data elements and interchange formats – Information interchange
This doesn't require UTC but that is how we are providing the data currently in Iowa.

Are the DateTime fields supposed to be always in local time (e.g. 2018-11-13T20:20:39+01:00) or in UTC (e.g. 2018-11-13T20:20:39Z, which I'd recommend)? Sorry if I missed this in the documentation.

I'm not sure this is specified anywhere--it isn't in the data tables field description (for start_date and end_date at least. Clarifying this in these descriptions is definitely a good idea. I'm also for using UTC, especially since this is how the data should be stored in the database and the relational model is intended to facilitate that.

In the road events table we say in the notes: All date/time formats shall use ISO 8601 Data elements and interchange formats – Information interchange
This doesn't require UTC but that is how we are providing the data currently in Iowa.

Thanks @j-d-b @sknick-iastate - let's explicitly require UTC for all datetime fields for consistency, unless there are objections. I can add that to the field description.

As long as UTC allows for seamless differentiation for daylight savings adoption across jurisdictions (i.e., Arizona, which doesn't do daylight savings and so is "off" from similar jurisdictions half the year), I think it's the way to go.


All kube-prometheus-exporter-node pods crashing

What did you do?
Installing charts:

helm install --name prometheus-operator --namespace monitoring coreos/prometheus-operator -f coreos-prometheus-operator-values.yaml --debug

helm install --name kube-prometheus --namespace monitoring coreos/kube-prometheus -f coreos-kube-prometheus-values.yaml --debug

What did you expect to see?
All resources up and running
What did you see instead? Under which circumstances?
All pods for kube-prometheus-exporter-node are crashing
Environment
Kops 1.8
I have 3 masters and 2 worker nodes
Cluster:
NAME                                             STATUS    ROLES     AGE       VERSION   EXTERNAL-IP   OS-IMAGE                                       KERNEL-VERSION   CONTAINER-RUNTIME
ip-xxx.ap-southeast-2.compute.internal   Ready     master    2h        v1.8.6    <none>        Container Linux by CoreOS 1632.3.0 (Ladybug)   4.14.19-coreos   docker://17.9.1
ip-xxx.ap-southeast-2.compute.internal     Ready     node      2h        v1.8.6    <none>        Container Linux by CoreOS 1632.3.0 (Ladybug)   4.14.19-coreos   docker://17.9.1
ip-xxx.ap-southeast-2.compute.internal    Ready     master    2h        v1.8.6    <none>        Container Linux by CoreOS 1632.3.0 (Ladybug)   4.14.19-coreos   docker://17.9.1
ip-xxx.ap-southeast-2.compute.internal   Ready     master    2h        v1.8.6    <none>        Container Linux by CoreOS 1632.3.0 (Ladybug)   4.14.19-coreos   docker://17.9.1
ip-xxx.ap-southeast-2.compute.internal    Ready     node      2h        v1.8.6    <none>        Container Linux by CoreOS 1632.3.0 (Ladybug)   4.14.19-coreos   docker://17.9.1

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.1", GitCommit:"f38e43b221d08850172a9a4ea785a86a3ffa3b3a", GitTreeState:"clean", BuildDate:"2017-10-11T23:27:35Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:23:29Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
insert how you created your cluster: kops,

Manifests:

insert manifests relevant to the issue

Prometheus Operator Logs:

NAME                                                       READY     STATUS             RESTARTS   AGE         IP                NODE
alertmanager-kube-prometheus-0                             2/2       Running            0          2s          <IP_ADDRESS>    ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-kube-state-6d95bf48bd-ffr6k       2/2       Running            0          <invalid>   <IP_ADDRESS>    ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-6fdrv                        0/1       CrashLoopBackOff   7          2s          <IP_ADDRESS>       ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-gkbdg                        0/1       CrashLoopBackOff   7          2s          <IP_ADDRESS>       ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-kscs5                        0/1       CrashLoopBackOff   7          2s          <IP_ADDRESS>         ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-nxf8b                        0/1       CrashLoopBackOff   7          2s          <IP_ADDRESS>        ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-xm7qb                        0/1       CrashLoopBackOff   7          2s          <IP_ADDRESS>        ip-xxx.ap-southeast-2.compute.internal
prometheus-kube-prometheus-0                               2/2       Running            0          2s          <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal
prometheus-operator-prometheus-operator-75454cd67d-kvqft   1/1       Running            0          25m         <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal

Logs for the pod are:
kubectl logs -f kube-prometheus-exporter-node-kscs5 -n monitoring
flag provided but not defined: -path.procfs
Usage of /bin/node_exporter:
  -collector.diskstats.ignored-devices string
    	Regexp of devices to ignore for diskstats. (default "^(ram|loop|fd|(h|s|v|xv)d[a-z]|nvme\\d+n\\d+p)\\d+$")
  -collector.filesystem.ignored-fs-types string
    	Regexp of filesystem types to ignore for filesystem collector. (default "^(sys|proc|auto)fs$")
  -collector.filesystem.ignored-mount-points string
    	Regexp of mount points to ignore for filesystem collector. (default "^/(sys|proc|dev)($|/)")
  -collector.megacli.command string
    	Command to run megacli. (default "megacli")
  -collector.netdev.ignored-devices string
    	Regexp of net devices to ignore for netdev collector. (default "^$")
  -collector.ntp.protocol-version int
    	NTP protocol version (default 4)
  -collector.ntp.server string
    	NTP server to use for ntp collector.
  -collector.procfs string
    	procfs mountpoint. (default "/proc")
  -collector.runit.servicedir string
    	Path to runit service directory. (default "/etc/service")
  -collector.supervisord.url string
    	XML RPC endpoint (default "http://localhost:9001/RPC2")
  -collector.sysfs string
    	sysfs mountpoint. (default "/sys")
  -collector.systemd.private
    	Establish a private, direct connection to systemd without dbus.
  -collector.systemd.unit-blacklist string
    	Regexp of systemd units to blacklist. Units must both match whitelist and not match blacklist to be included.
  -collector.systemd.unit-whitelist string
    	Regexp of systemd units to whitelist. Units must both match whitelist and not match blacklist to be included. (default ".+")
  -collector.textfile.directory string
    	Directory to read text files with metrics from.
  -collector.wifi string
    	test fixtures to use for wifi collector metrics
  -collectors.enabled string
    	Comma-separated list of collectors to use. (default "conntrack,diskstats,entropy,edac,filefd,filesystem,hwmon,infiniband,loadavg,mdadm,meminfo,netdev,netstat,sockstat,stat,textfile,time,uname,vmstat,wifi,zfs")
  -collectors.print
    	If true, print available collectors and exit.
  -log.format value
    	Set the log target and format. Example: "logger:syslog?appname=bob&local=7" or "logger:stdout?json=true" (default "logger:stderr")
  -log.level value
    	Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal] (default "info")
  -version
    	Print version information.
  -web.listen-address string
    	Address on which to expose metrics and web interface. (default ":9100")
  -web.telemetry-path string
    	Path under which to expose metrics. (default "/metrics")

When i describe the pod
 kubectl describe pod kube-prometheus-exporter-node-kscs5 -n monitoring
Name:           kube-prometheus-exporter-node-kscs5
Namespace:      monitoring
Node:           ip-xxx.ap-southeast-2.compute.internal/xxx
Start Time:     Thu, 15 Mar 2018 11:07:05 +1100
Labels:         app=kube-prometheus-exporter-node
                component=node-exporter
                controller-revision-hash=204858866
                pod-template-generation=1
                release=kube-prometheus
Annotations:    kubernetes.io/created-by={"kind":"SerializedReference","apiVersion":"v1","reference":{"kind":"DaemonSet","namespace":"monitoring","name":"kube-prometheus-exporter-node","uid":"cbf16edc-27e4-11e8-91bd-...
Status:         Running
IP:             xxxx
Created By:     DaemonSet/kube-prometheus-exporter-node
Controlled By:  DaemonSet/kube-prometheus-exporter-node
Containers:
  node-exporter:
    Container ID:  docker://c97fbcf9281bda76049686fb5eb43b2ad354e501f8cabb1c7ffa561af0a816d9
    Image:         quay.io/prometheus/node-exporter:v0.14.0
    Image ID:      docker-pullable://quay.io/prometheus/node-exporter@sha256:b376a1b4f6734ed610b448603bc0560106c2e601471b49f72dda5bd40da095dd
    Port:          9100/TCP
    Args:
      --path.procfs=/host/proc
      --path.sysfs=/host/sys
      --web.listen-address=<IP_ADDRESS>:9100
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       Error
      Exit Code:    2
      Started:      Thu, 15 Mar 2018 11:22:58 +1100
      Finished:     Thu, 15 Mar 2018 11:22:58 +1100
    Ready:          False
    Restart Count:  8
    Limits:
      cpu:     200m
      memory:  50Mi
    Requests:
      cpu:        100m
      memory:     30Mi
    Environment:  <none>
    Mounts:
      /host/proc from proc (ro)
      /host/sys from sys (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-tkvvz (ro)
Conditions:
  Type           Status
  Initialized    True
  Ready          False
  PodScheduled   True
Volumes:
  proc:
    Type:  HostPath (bare host directory volume)
    Path:  /proc
  sys:
    Type:  HostPath (bare host directory volume)
    Path:  /sys
  default-token-tkvvz:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-tkvvz
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     :NoSchedule
                 node.alpha.kubernetes.io/notReady:NoExecute
                 node.alpha.kubernetes.io/unreachable:NoExecute
                 node.kubernetes.io/disk-pressure:NoSchedule
                 node.kubernetes.io/memory-pressure:NoSchedule
Events:
  Type     Reason                 Age                      From                                                   Message
  ----     ------                 ----                     ----                                                   -------
  Normal   SuccessfulMountVolume  6m                       kubelet, ip-xxx.ap-southeast-2.compute.internal  MountVolume.SetUp succeeded for volume "sys"
  Normal   SuccessfulMountVolume  6m                       kubelet, ip-xxx.ap-southeast-2.compute.internal  MountVolume.SetUp succeeded for volume "proc"
  Normal   SuccessfulMountVolume  6m                       kubelet, ip-xxx.ap-southeast-2.compute.internal  MountVolume.SetUp succeeded for volume "default-token-tkvvz"
  Normal   Pulling                6m                       kubelet, ip-xxx.ap-southeast-2.compute.internal  pulling image "quay.io/prometheus/node-exporter:v0.14.0"
  Normal   Pulled                 6m                       kubelet, ip-xxx.ap-southeast-2.compute.internal  Successfully pulled image "quay.io/prometheus/node-exporter:v0.14.0"
  Warning  BackOff                5m (x4 over 6m)          kubelet, ip-xxx.ap-southeast-2.compute.internal  Back-off restarting failed container
  Normal   Created                5m (x4 over 6m)          kubelet, ip-xxx.ap-southeast-2.compute.internal  Created container
  Normal   Started                5m (x4 over 6m)          kubelet, ip-xxx.ap-southeast-2.compute.internal  Started container
  Normal   Pulled                 5m (x3 over 6m)          kubelet, ip-xxx.ap-southeast-2.compute.internal  Container image "quay.io/prometheus/node-exporter:v0.14.0" already present on machine
  Warning  FailedSync             <invalid> (x68 over 6m)  kubelet, ip-xxx.ap-southeast-2.compute.internal  Error syncing pod

Unfortunately, this is a showstopper for me right now. :-(

Seem like you are running an outdated version of the helm charts, the  node-exporter version is 15.2 since 3 months ago.
What version of the charts are you running (helm list) ?
Did you run helm repo update before installing this charts?

You could be right! Maybe the chart is already cached.. @gianrubio I'll verify tomorrow morning in work.

No problem! Feel free to reopen the issue if it was not the case

fantastic! all good @gianrubio
NAME                                                   READY     STATUS    RESTARTS   AGE         IP               NODE
alertmanager-kube-prometheus-0                         2/2       Running   0          <invalid>   <IP_ADDRESS>    ip-xxx.ap-southeast-2.compute.internal
grafana-grafana-85b65494f-57n2v                        2/2       Running   0          <invalid>   <IP_ADDRESS>    ip-xxx-ap-southeast-2.compute.internal
kube-prometheus-exporter-kube-state-576ccb4db7-hh4fq   2/2       Running   0          <invalid>   <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-cwf9f                    1/1       Running   0          <invalid>   <IP_ADDRESS>      ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-htv66                    1/1       Running   0          <invalid>   <IP_ADDRESS>      ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-lw7lf                    1/1       Running   0          <invalid>   <IP_ADDRESS>      ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-nfk5b                    1/1       Running   0          <invalid>   <IP_ADDRESS>       ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-exporter-node-v5nww                    1/1       Running   0          <invalid>   <IP_ADDRESS>      ip-xxx.ap-southeast-2.compute.internal
kube-prometheus-grafana-8577867f8-ckxjx                2/2       Running   0          <invalid>   <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal
prometheus-kube-prometheus-0                           2/2       Running   0          <invalid>   <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal
prometheus-operator-75c7447666-t966d                   1/1       Running   0          11m         <IP_ADDRESS>   ip-xxx.ap-southeast-2.compute.internal

Note to self always update the charts! ;-)

Hi
Please can some one help me with kube-prometheus-exporter-kube-state. It keeps restarting with failed readiness probe.
Readiness probe failed: Get http://IP:8080/: dial tcp IP:8080: connect: connection refused
NAME                                                   READY   STATUS      RESTARTS   AGE
kube-prometheus-exporter-kube-state-689f8f9bd6-nnfkj   1/2     CrashLoopBackOff   13         54m
kube-prometheus-exporter-node-6qkr9                    1/1     Running     4          148d
kube-prometheus-exporter-node-b9lt8                    1/1     Running     6          148d
kube-prometheus-exporter-node-dptjb                    1/1     Running     4          148d
kube-prometheus-exporter-node-hl5mm                    1/1     Running     4          118d
kube-prometheus-exporter-node-n2vjz                    1/1     Running     0          49d
kube-prometheus-exporter-node-p47cq                    1/1     Running     11         118d
kube-prometheus-exporter-node-qlvj6                    1/1     Running     6          148d
kube-prometheus-exporter-node-qvgnz                    1/1     Running     3          148d
kube-prometheus-exporter-node-rh7kg                    1/1     Running     2          148d
kube-prometheus-exporter-node-tt8dq                    1/1     Running     5          148d
kube-prometheus-exporter-node-tvlwt                    1/1     Running     4          148d
kube-prometheus-exporter-node-x7cm7                    1/1     Running     6          118d
kube-prometheus-exporter-node-zf9jf                    1/1     Running     3          148d
kube-prometheus-grafana-f869c754-2rz82                 2/2     Running     0          19d
prometheus-kube-prometheus-0                           3/3     Running     1          19d
prometheus-operator-87779759-gccn2                     1/1     Running     0          58m
tiller-deploy-546cc58545-jlm8z                         1/1     Running     0          19d


.NET bindings (through C-FFI)

Just started experimenting with C and .NET bindings, would enjoy any feedback or help.
Tantivy.Net
tantivy_c
I feel it would be great to have an official C ABI in future.

That's awesome!
If tantivy_c matures -if you are ok with it- it might be a good idea to move it into tantivy-search. (as was done for tantivy-py) recently.
Have you joined the gitter chat? I don't know anything about .NET but other devs might get excited and want to contribute.

I am confused a bit about LeasedItem. It is defined in a private module but used in public interface (IndexReader::searcher).
I can't name the return type inorder to put in a Box to pass through FFI.
And since it implemnents Deref and Searcher is not Clone the .NET part can't own instance of it.

@nazar554  We encounterred the same issue with tantivy-py and It is fixed in master.
Before the next release, you can still rely on depending on the current rev of the master branch by specifiy a git path in your Cargo.toml.


Remove Typescript errors from Navigation.astro

The code worked and still works, but now there are fewer Typescript errors highlighted. There is still one left, but I'm not yet sure how to fix it.

Thanks for this contribution @shawninder! I know TypeScript is a big part of Astro and it's on my todolist. Your PR here is a great step towards that goal, I appreciate it!


chore: Set up for release

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.

Setting up release-please and setup.py.
Fixes internally files issue

Closing this as Bu Sun already made changes in #2 D:


1.12.3 with fix for #295

Hi,
Please consider creating a 1.12.3 version which contains the fix for #295.
What I've done:

Created a new branch called 1.12 based on the 1.0 branch (git checkout -b 1.12 origin/1.0)
Merged all changes up to the 1.12.2 commit (from master) (git merge 89fda6a)
Cherry-picked the commit that fixes #295 (git cherry-pick e92bed7b7c75c656dc1d037228683095db40303f)
Changed version in package.json from 1.12.2 to 1.12.3.

I hope this would work for you, otherwise feel free to let me know how to improve.  :)

Hmm, looks like I did something wrong, since it says:

"MPV wants to merge 2 commits into webpack:master from MPV:1.12".

I didn't necessarily want to you merge this into master, but rather establish a new 1.12 branch (similar to your existing 1.0 branch) for fixes to the latest 1.x version.  :smile:

Done


feat: enable loading alternative driver via system properties

This patch adds a logic to enable the loading of an alternative driver which can be set via the system property 'playwright.driver.impl'. If the property is not set, the default driver implementation will be loaded.
Fixes #856.

I closed this PR as the tests are broken.

Thanks for your contribution!


Veron Castle missing Title

Description
Veron Castle and its villages currently have no titles assigned and do not show up in the demesne hierarchy
Mod Version

applies both to Banner Kings <IP_ADDRESS> and BKCE 1.0.2

Evidence

"castle_EW5" is missing from titles.xml
adding line    "barony settlement="castle_EW5" deJure="lord_1_11" /"
fixes the issiue for new saves, (lord_1_11 is a placeholder, not sure what the appropriate one would be)
not sure if you can get a fix for old saves

hope this helps, keep up the good work

I would like to add that the Vlandian Fief of Sargot and its attached villages, are also missing in the demesne hierarchy and has no data as the owner.


UI Improvements for Next Gen

[ ] Rework on the staking page making changes to the color used to represent each ticket and the information contained in it.
[ ] Rework on the wallet selector list by adding the sync indicator, back up indicator, and ability to witch from wallet view to a DEX view and App settings view.
[ ] Work on market, wallet, notification, profile and settings for the DEX.
[ ] Rework on the create and restore wallet feature adding seed word and HEX.

This task from my POV is too bulky…
I already started work on the V2 layout design. When this is done, we intend to break it further into smaller task.

@Blackdot-designer is this intended for the developers or the designers?

The designers are currently working on this. But i believe it would be up for implementation by the developers when the designers are done. @dreacot

This task from my POV is too bulky…
I already started work on the V2 layout design. When this is done, we intend to break it further into smaller task.

All these are V2 layout designs

This no longer applies


rbd: Add timeout for cryptsetup commands

Describe what this PR does
This PR modifies the execCryptSetupCommand so that the process is killed in an event of lock timeout.
Useful in cases where the volume lock is released but the command is still running.

This looks reasonable to me. Did you manage to test this somehow, and see how everything gets corrected by a different container?

we need to ensure that the CLI command we start is killed and doesn't continue to execute, please test it the changes to ensure that it works as expected and also provide some test results on how this is tested

This looks reasonable to me. Did you manage to test this somehow, and see how everything gets corrected by a different container?

Trying but not able to yet. I am thinking of having a wrapper to cryptsetup that sleeps for some time and then tries to execute the intended command. The key is to kill the process in midst of operations.
I will test it and report.

Trying but not able to yet. I am thinking of having a wrapper to cryptsetup that sleeps for some time and then tries to execute the intended command. The key is to kill the process in midst of operations.

I also think the only way reproduce this, is by adding a wrapper for the command. It helps  to make the command do something that can be verified after aborting, maybe something like this (untested):
#!/bin/sh
#
# Assume a 1GB block-device, write unencrypted data at 500MB offset.
#

# run normal crypsetup, it will be quick and exits cleanly
cryptsetup $@

# run dd in a loop, small I/O with sync to make it slower
# only runs the loop if /tmp/testing exists
while [ -e /tmp/testing ]
do
    # set correct device and verify parameters
    dd if=/dev/urandom of=/dev/rbd... bs=1 count=100m offset=500m
done

Hey @black-dragon74 , I'll mark this as a draft for now, otherwise I keep checking it for updates. Please move it back as ready for review once you have tested it. Thanks!

@mergifyio queue


Add examples of different types of checklists

This updates the example template and PDF to give examples of the three main layouts of checklists:

full width, full page
full width, partial page
single column, partial page

@liantze - there is a small issue here that when I go with the last of these, I get an asterisk immediately preceding the checklist in the resulting PDF. Can you check the class for this case? Specifically see image below:

Indeed looks like a bug when patching the starred environments; I've just created a PR that fixes this.


$Diff is not compatible with $Keys

Example:
type A = $Diff<{a: number}, {}>;
type B = $Keys<A>;

const x: B = 'a';

This works now.


Network Security Group Tag(s): Azure Datacenter / Azure Storage for region

This may not be the place to ask but was wondering if there is or will be tags for the ip ranges of azure storage or azure data-centers by region. There is no class for these tags, but values such as AzureLoadBalancer and VirtualNetwork, work in the SDK for NSGs the same way they work in the GUI. There does not appear to be any way to know the ip ranges to allow outbound traffic to (by region) for these services (which are required for VM extensions). Azure does publish the Ip ranges of their datacenters which can then be correlated, but this does not work for regions such as us gov virginia etc.

no such feature on the service side is exposed


Provide constants for standard http values

It would be handy to have constants for standard http values like header names, status codes, content types, etc.
Play exposes these via https://github.com/playframework/playframework/blob/master/framework/src/play/src/main/scala/play/api/http/StandardValues.scala
Have you considered providing these?

@jsw Yes, that's a good question - there's a handful of methods for specifying the content type, checking if the response is 2xx, 3xx etc., but that's about it. The akka-http model that @ktoso mentioned is tempting, but:
(a) working with the fully typed model and having to separately specify the MediaType & ContentType is sometimes a bit hard to work with
(b) I wouldn't want to copy-paste all that code, on the other making core dependent on akka-http isn't possible as well
so I'm on the fence here - not sure what would be the best way to go. I'm open to suggestions though :)

I agree that sttp should not depend on akka-http-core, especially as it brings in other dependencies. (@ktoso Thanks for linking to the model and informing that Play is moving towards it - good to know).
I also agree the akka-http model looks a bit heavy for sttp purpose.
What do you think of the Play approach? It is essentially a simple set of traits with constant Strings and Ints that are easy to stack together. This approach means the API doesn't have to change. Then it's easy to do
class TwitterClient extends Headers with ContentTypes {
   def getFeed() = sttp.header(Accept, Json)...
}

The only alternatives I see for users are

Magic strings
Building up their own set of constants
Finding some library that contains these definitions (both Play and akka-http would be overkill to add to an app that doesn't otherwise contain them).

Many users might already be in the context of a Play or akka-http framework and can leverage that, but I'm thinking that the code that use sttp could be more portable and independent if they have their own definitions.

@jsw Yes, I suppose we could go with a hybrid approach. That is, keep methods that accept strings (if people would like to specify special custom headers) and provide a typed variant as well. Opaque types would be nice here ;)
I like the idea of grouping these in traits, but maybe we could modify this a little, and have objects inside of the sttp package, Headers and ContentTypes? Then you you would do:
sttp.header(Headers.Accept, ContentTypes.Json)
sttp.contentType(ContentTypes.Json)

The Header trait (implemented e.g. by Headers.Accept) could have a type parameter specifying the allowed values (Strings or ContentTypes, for example), hence restricting what could be the second parameter of the .header method. What do you think?

Ah yes, a trait+object will definitely work.
You're right that while the hybrid approach would work for the create side (creating the request), it wouldn't for the read side (reading the response headers), so let's stick to Strings

@adamw Sounds good. Would you like me to submit a PR or do you want to take this one? If I were to do it, it would look similar to the Play approach, though with TitleCase instead of ALL_CAPS, which I think is more idiomatic for scala constants.

@jsw if you could create a PR, that would be great! Of course, using CamelCase :)


Add multiple dc repair tests

For CASSANDRA-9521 and part of CASSANDRA-9109.

Thanks for the review. I converted to unittest's assert for whole repair_test, not just for the new ones.

I'm still concerned about the set_configuration_options comment/behavior, but other than that, +1.

Merged. Only the comment is wrong, not the behavior. I'll fix that in a separate commit.


gtk-wave-cleaner: init at 0.22-01

Motivation for this change
This PR adds gtk-wave-cleaner, an old but still viable piece of software for cleaning sounds.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ x Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

If you have other prs please consider these styling suggestions there.

Thank you very much for spending your time, I am going to apply those suggestions to other PR's.

@worldofpeace  I believe I have fixed all of those problems, if you see more, please correct me! I'm a new contributor, so showing where I'm wrong is the best possible way to learn.

@worldofpeace I believe I have fixed all of those problems, if you see more, please correct me! I'm a new contributor, so showing where I'm wrong is the best possible way to learn.

Totally, though please note I don't believe in mistakes. Only learning opportunities :+1: .
You've responded well, and I'm now going to test using this application.

Hmm I couldn't test this with audio produced with any version of ffmpeg in nixpkgs
 ffmpeg -f lavfi -i "sine=frequency=1000:duration=5" -ac 2 output.wav

https://github.com/AlisterH/gwc/issues/5
Guess it could be still useful.

@GrahamcOfBorg build gtk-wave-cleaner

@GrahamcOfBorg build gtk-wave-cleaner

@balsoft Are you still interested in finishing this?

@veprbl it was a package I made for someone else, so no, not really. It would be nice to have it in nixpkgs, but said person is fine using it from an overlay.

@balsoft Getting this merged will probably involve addressing comments raised by @jtojnar and a possible further review of this PR. If you don't want to finish this, let's close.

Let's close.