http2 support for rest apis in community kong api gateway

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Hi, Currently from our golang based client application is calling rest apis to server app. server app is using kong proxy for routing external APIs.  when we enabled http2 in golang ,but in response header we are still seeing http 1.1. is there any open issue with http2 in kong api? is this because upstream service?
Expected Behavior
we want http 2 in response header , to ensure communication indeed is happening over http2.
Steps To Reproduce
No response
Kong Ingress Controller version
2.8.9

Kubernetes version
1.23

Anything else?
No response

Hi @ankitec98 👋
Can you be a bit more specific? I believe you're talking about the Kong Gateway itself (not sure what aspect of it though).
If that's the case I suggest you file an issue at https://github.com/Kong/kong. I'll leave this issue open so that you can respond.

Sure, i thought it is issue with controller, as Kong document refers it supports http 2.0. if thats case i will open an issue with Kong,.thanks.

No problem. Please note that you've specified the version of KIC as 2.8.9 which does not exist. Additionally, Gateway didn't release such a version either: https://github.com/Kong/kong/releases. 🤔

i will open an issue with Kong,.thanks.

I'm going to close this issue for now. Feel free to reach out if you need any help.


SYS-579 python dependency updates

Summary of Changes

Update Pipfile and bump version.
Why is this change being made?

Vulnerabilities CVE-2022-23651 and CVE-2022-23651 in b2sdk, CVE-2022-24761 in waitress.
How was this tested? How can the reviewer verify your testing?

Unit tests, manual tests.
Completion checklist

[ ] The pull request is linked to all related issues
[x] This change has unit test coverage
[x] Documentation has been updated
[x] Dependencies have been updated and verified

CI pipeline run for this branch - 547189386.


[firebase_messaging] onLaunch triggered with previously received data, when freshly rerunning the app

Steps to reproduce
Actual behaviour

Make some code-changes and re-run app from VSCode
onLaunch is triggered with previously received data

expected behaviour

Make code changes and re-run app
onLaunch should not be triggered

Same issue facing. It is call onLaunch method on re run app.

Hi @ad-on-is  @kttailor
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, v1.17.4, on Microsoft Windows [Version 10.0.20152.1000], locale en-AT)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.46.1)
[!] Connected device
    ! No devices available

! Doctor found issues in 1 category.

This is my code
firebaseMessaging.configure(
      onMessage: (Map<String, dynamic> message) async {
        _notifyBasedOnFCM(message);
      },
      onLaunch: (Map<String, dynamic> message) async {
        _notifyBasedOnFCM(message, showBanner: false);
        _navigateBasedOnFCM(message);
      },
      onResume: (Map<String, dynamic> message) async {
        _notifyBasedOnFCM(message, showBanner: false);
        _navigateBasedOnFCM(message);
      },
    );

void _navigateBasedOnFCM(Map<String, dynamic> message) {
    print(message);
    Map<dynamic, dynamic> data = message['data'] ?? message;
    if (data['event'] == 'new_message') {
      setPage(4);
    }
  }

So basically what happens is, that each time I rerun the app, it sets the page to 4, and print(message) returns the payload which it received before the app is rerun.

firebase_messaging: ^6.0.16 I can reproduce.

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-2.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-2.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 15a28159bc (9 days ago), 2020-06-23 04:52:58 -0700
    • Engine revision 91a63d6a44
    • Dart version 2.9.0 (build 2.9.0-19.0.dev 7e72c9ae7e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS desktop • macos                     • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Closing in favour of trying the latest messaging version which has since this issue was created been heavily reworked to improve it along with detailed documentation: https://firebase.flutter.dev/docs/messaging/overview
If you still have a problem please raise a new GitHub issue with up to date information and code snippets if possible. Thanks.


Test with different cmake versions

We should be able to test with different cmake versions to confirm that the examples work on them. This would also allow showing newer features like those raised in #5

I've added dockerfiles which can build images that include cmake <IP_ADDRESS> or 3.4.3. This allows for easy testing between different CMake versions


Copier udpate & dependency update

essreduce now hosts the JsonGroup so beamlime needs it in the dependency.

Do we need to add pooch as a test dependency in conda/meta.yaml? In essreflectometry the release build failed because the conda release action didn't have access to pooch. See scipp/essreflectometry#69 (review)

I did forget to update conda/meta.yml...! Thank you : D


operator infoscale-dr-manager (8.0.310)

New operator bundle
Name: infoscale-dr-manager
Version: 8.0.310
Certification project: 62925cf2ca9c2698bf2add8b
Test result URL: https://catalog.redhat.com/api/containers/v1/projects/certification/test-results/id/65b8e95094f529fbeaffc307
Test logs URL: https://catalog.redhat.com/api/containers/v1/projects/certification/artifacts/id/65b8e94d267dc426b3aad2df

Trying out PR creation.


Question: Content negotiation / multiple deserializers

Hello,
Is this supported?
E.g. I have a service which can return response in Json, XML and binary format (depending on Accept header value).

There's no built-in support for content negotiation. You can set the Accept header yourself , or you can accept multiple response content-types.

Awesome, thanks for quick response!


Client crashes when scanning the experience focus

http://pastebin.com/YMy1BYgC
Tried several times, same crash :) Also it seems like even though the focus says it should only use ordo and perdito, it actually uses every primal aspect from the staff. And lastly you can use the focus on grass for no cost at all and still get xp :P Love your work on the mod so far, I hope you keep it up :)

Not a TB issue - some mod creates a recursion at TC's aspect registry. This has already been reported to Azanor a several times. I guess I will make a patch so TB will not trigger that, but just so you know - not a problem of the actual mod.


Use advective form momentum equation in diagnostic edmf

Purpose

Closes #1775.
I will add the equations to ClimaAtmos doc once I make sure the equation on overleaf is correct with Tapio. The documentation is now in PR #1787
To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


[BUG] Fix reference documentation issues in 'Microsoft.Azure.KeyVault*'

Describe the bug
Enabling ref documentation for these libraries gives errors on build.

'Microsoft.Azure.KeyVault'
'Microsoft.Azure.KeyVault.Core'
'Microsoft.Azure.KeyVault.Cryptography'
'Microsoft.Azure.KeyVault.Extensions'
'Microsoft.Azure.KeyVault.WebKey'

Expected behavior
We should be able to generated ref documentation with build.
To Reproduce

Enable generation of ref docs by removing the exclusion of the libraries from 'eng\Directory.Build.Common.props'
Build the SDK directory.

All those packages are officially deprecated. Since they are also already documented, what would be the reason to generate new documentation for them now? I'd rather not do anything new with them if we can avoid it.

Users still using the track1 SDK packages complain when they don't find reference documentation for them.
See https://github.com/Azure/azure-sdk-for-net/issues/11798 as an example.
We have made a change to generate docs for all libraries, whereas earlier it was only enabled for track2 libraries.
Some libraries have doc errors during build, and they are kept disabled for now. These bugs are tracking those instances.
Individual library owners can either -

Ignore this issue because there isn't enough interest in the track1 packages.
Fix the errors and enable generation of ref docs. Then, release an update if/when there is customer demand.

Closing for now since we have no plans to generate new packages, but should we, we can resolve this then.


Private path in dist file

In dist/vue-tabs.js there is one line with private path:
i.options.__file="C:\\work\\Github\\vue-tabs\\src\\components\\TabContent.vue"
I think it's confusing when you install npm package in different path and than you get Vue message with such path.

Thanks for pointing out. This is indeed not good. Is this warning shown during npm install ?

From browser console:

Can you describe the situation from which this error resulted?

I think this always happens when you are getting such warning like in my screenshot on tab child component. And that warning happens I think always when programatically props before mounted event are modified.

This was fixed along with the new release which contains a totally different way of bundling the component


JSONAPI.org Errors Spec

The JSONAPI Spec documents define how errors should be handled, but I don't see helpers in this module. Should I create a pull request, or is it already handled and I missed it?
I know that additional keys are optional, but it might be nice to bake in a couple of conventions.

@nicholaswyoung That would be awesome!

@jeregrine What portion of the spec recommendations do you think are the most important? Or should we just roll with all of the "MAY" recommendations as we can?

@nicholaswyoung I focus on should but may is nice to have :)

Working on this here: https://github.com/doomspork/jsonapi/tree/feature/errors


nostr client creation: improve error handling, catch and handle exception

Exception raised by an invalid key to nostr client will give an error message citing the invalid key.

LGTM, thank you for this contribution! Please join our R&D channel and say hi if you haven't already: https://t.me/CashuBTC

Can you run make format? I just pushed the Makefile to main but if you don't want to rebase/merge, you can use this short Makefile:
isort:
	poetry run isort --profile black . --skip cashu/nostr

black:
	poetry run black . --exclude cashu/nostr

mypy:
	poetry run mypy cashu --ignore-missing

format:
	make isort
	make black
	make mypy


Provide an interface method to get the current number

How can I Know My current badge number,sometimes I need to deal with it.
what about provide an interface method ?

Hello, this interface has not been opened for the time being. You can change the source code and expose the property of PPBadgeLabel. @baoshanf


testnet network support - cekw0i20vn312r - validator,rpc,api

@stan-bl , Your Moniker and validator addresses are required, please update the PR with those details

@stan-bl , Your Moniker and validator addresses are required, please update the PR with those details

Hello,
This is my validator details :

Moniker: stanBl
validator address: akashvaloper1wz28k3lfdkk5xh06xeak0l7g6vmdlc266yacml

You can find it on explorer here: https://testnet.akash.aneka.io/validators/akashvaloper1wz28k3lfdkk5xh06xeak0l7g6vmdlc266yacml

Hello,
This is my validator details :

Moniker: stanBl
validator address: akashvaloper1wz28k3lfdkk5xh06xeak0l7g6vmdlc266yacml

You can find it on explorer here: https://testnet.akash.aneka.io/validators/akashvaloper1wz28k3lfdkk5xh06xeak0l7g6vmdlc266yacml


Don't forget the version number :)

When you upgrade the pool table package to 1.1.2, i am looking weird at the version number scoreboard: it still shows v1.1.1
I did import package again, and it's still v1.1.1. It was not my mistake with Prefab Variant.
So, next time, if you want publish new update: don't forget change also the version number on the score board. :-)

With release of 1.1.4, i thought i still see 1.1.3 on scoreboard?
Did you forget it, or is it indeed changed to 1.1.4?

1.1.5 has the correct version number. An editor script will be needed to help with this in the future.


chore: remove patch and unpatch diag from instrumentations

This PR implements https://github.com/open-telemetry/opentelemetry-js/pull/4641 to the contrib instrumentations, so once the core repo PR is merged, we can quickly rebase this PR and apply the changes in contrib so we can release them together.

Thanks for the thorough review.

can you confirm I have this right? For example, mongoose has a patchAggregateExec that includes this._diag.debug('patched mongoose Aggregate exec function');. I think this will at the top level use the shared diag from the main instrumentation package for patching the module itself, and there was just nothing to remove from there because it didn't have a general patch log... and then it will still have additional diag logging for those specific types of patches when it comes up, which seems to be by design already within that instrumentation. Does that sound accurate? A similar situation seems to exist for fastify and a couple others, though there were main patch logs to remove here that you took care of.

That is correct, the intention was to address only the patch and unpatch of the module (or module file) itself, and not the specific function patchs from the module exports which I intend to cleanup in a different PR.
Not sure how much value we get from reporting specific function patches like mongoose and hapi does. I think we should either:

clean this up from all existing instrumentations.
hoist it to the base instrumentation and apply to all instrumentations from the base class _wrap and _unwrap functions.
Understand when it is needed and when not, and align the existing prints to a documented practice.

and koa is missing an update because its syntax is a bit different api.diag.debug('Patching Koa');

Thanks! I updated the koa and also few other places. I think now it is removed from all relevant places. please share if you spot one that I missed

As a follow-up after this, I think we could get these instrumentations consistently using this._diag.debug for their remaining debug statements 🤔 Those could be done separately in small individual PRs though to limit the scope of this.

Absolutely, I intend to align everything to this._diag in a followup PR, which isn't always trivial as some diag useages are coming from utils.ts and are lacking the instrumentation this, but this will be handled in a different PR after some diag usages are removed

Not sure how much value we get from reporting specific function patches like mongoose and hapi does. I think we should either:

clean this up from all existing instrumentations.
hoist it to the base instrumentation and apply to all instrumentations from the base class _wrap and _unwrap functions.
Understand when it is needed and when not, and align the existing prints to a documented practice.

With the function patches I suppose it may be helpful when debugging to see if something specific is not getting patched as expected, similar to the purpose here for the module itself, but it's maybe more helpful for some instrumentations vs others.. It is something to consider whether we can get a more consistent practice there too, but I don't see it being quite as impactful as this change for the whole module log, or for general usage of this._diag.debug.

Compile error in instr-mongodb:
 ><EMAIL_ADDRESS>compile
> tsc -p .

src/instrumentation.ts:18:3 - error TS6133: 'diag' is declared but its value is never read.

18   diag,
     ~~~~

Not sure how much value we get from reporting specific function patches like mongoose and hapi does. I think we should either:
1. clean this up from all existing instrumentations.

Speaking from a little experience with instr-hapi, I think those extra diag.debug messages are not useful for debugging at all. +1 for doing option 1 here.

Thanks @JamieDanielson and @trentm I support addressing the individual diag prints as well, mainly I think we should remove them unless there is some non-standard patching logic which can aid debugging?
As this PR already introduces quite some changes, I want to address the remaining patch diag prints in a followup PR.
I rebased this branch from main after merging #2091 and fixed all the conflicts. Thanks again for helping iterate this and the great suggestions.


[Bug]: iOS - Balance 0 is displayed during IBAN request

Preconditions
Received SORA Card Approve status
Steps to reproduce

Check SORA Card status
Tap on SORA Card banner

Actual behavior

Balance 0 is loaded for a split second on the SORA CARD details at the moment when the request for IBAN is sent.

Balance 0 is displayed during IBAN request on the SORA CARD banner

Expected behavior
We must show the loader or text "show info" if we have not yet received a response to the IBAN request.

Environment
{"label"=>"Development"}
OS version
16.2
Additional context
(259) develop version

Verified on 3.8.3 (9) Soralution version.
The first point is not fixed yet.
Balance 0 is loaded for a split second on the SORA CARD details.
https://github.com/sora-xor/sora-card-ios/assets/51509139/2b4fc9ea-72e6-4074-82c7-e56d29a75a5e

Verified on 3.8.4(7) Soralution version.


Add pagination so that there is only the upcoming council meeting on top and the last 10

Completed without pagination in commit b7cdb8182cbeefd5a571ff3d479a685d2268a108


Cleanup/imports parsing

fix: Improvements to yaml.Unmarshal for types.Imports and add some go tests
Improvements here:

Drop duplicate code blocks from getImportFromInterface
There were 2 identical codeblocks, one with a type convert to
map[string]interface{} and one with type convert to
map[interface{}]interface{}.  I cannot find any reason for the
former
Add some golang tests to for unmarshalling.
Type check the values of all string Import fields, rather than just
converting them to a string with 'fmt.Sprintf("%v")'

cleanup: Add contsants UidEmpty and GidEmpty and FileCopyNoPerms function.
Instead of using '-1' to indicate "do not change userid" (or groupid)
to FileCopy, provide constants UidEmpty and GidEmpty.
Also add simplified FileCopyNoPerms to call FileCopy without mode
or uid/gid.

@mikemccracken @hallyn pls review.


aws-sam-cli: update requests dependency to 2.22.0

Motivation for this change
pythonPackages.requests was updated to v2.22.0 on July 21.
aws-sam-cli is hard-coded to set the requests version to 2.21.0, so aws-sam-cli currently fails to build.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @andreabedini @dhl

@grahamcofborg build aws-sam-cli


Bug transacting with capacity should not require tokens to cover transaction cost

Goal
The goal of this PR is to fix a frequency-tx-payment bug to allow capacity holders to transact when their free balance is less than the minimum balance, or Existential Deposit (ED).
Closes #1850
Discussion

[x] withdraw_fee check updated to use total_balance instead of balance, which ensures that if an account has capacity (frozen > 0) but has no available balance (free == frozen) transactions are still successful
[x] Ensures that additional provider keys that have no ED cannot transact successfully.
[x] Add e2e-test that successfully claims a handle with 0 available balance

How to Test

Ensure that e2e-tests complete successfully

Checklist

[ ] Chain spec updated
[ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
[ ] Design doc(s) updated
[x] Tests added
[ ] Benchmarks added
[ ] Weights updated

Only need to increase spec version


Log CRUD operations on post-data and post-content in micropub endpoint

I think that adding even a single log statement for each CRUD operation would aid troubleshooting and improve debuggability.

This is great, thank-you! I will add corresponding debug statements within the endpoint-media plugin, too.


Questions about TF hub

Hello!
I read docs and source code of TF hub and have questions:

https://github.com/tensorflow/hub/blob/master/docs/hosting.md protocol is very small. Is it intended, or do you plan to extend it? I would like to see API to get module specs without downloading the tarball, and some module discovery mechanism.
Do you have plans about versioning mechanism? Looks like version is just part of a module URL and it could be missing if module is deployed differently.
Is there a docker image or maybe an instruction on how to do a local deployment of TF hub?

Thank you in advance.

The protocol was created as a way to host both the documentation and module from the same URL. Although there are no planned features that required it, it seem better to leave the extensible option on the table rather than closed. Please file specific feature requests and :+1: accordingly.

At the moment, it is unclear if the version will be part of the protocol, or is left as something that exists at a layer above. For now it is a "recommended best practice".

Do you mean a local deployment of "tfhub.dev"? No. The hosting.md is all there is at the moment.

Thank you for the answer.

Do you mean a local deployment of "tfhub.dev"? No. The hosting.md is all there is at the moment.
I want to deploy a TF module registry for playground and was wondering if there is a solution to quickly create a TF hub compatible server, so I could access modules from internal network with x.x.x.x/modules/ssd/1 URL.

Seems like I need to develop a custom module registry server.

@akhorlin thanks for the solution. But I don't want to use cloud storages (all the work is done in LAN, and isolated) and the solution doesn't provide standardised docs for modules. (like https://www.tensorflow.org/hub/modules/google/imagenet/inception_v1/feature_vector/1)

Is there a docker image or maybe an instruction on how to do a local deployment of TF hub?

This is not exactly what you might have asked, but is related to TF-Hub and Docker.  Namely, if you want to run TF Hub inside a docker container and run some of Colabs in that environment you can easily build a docker image that extents the Jupyter TensorFlow docker stack as follows:

Create a Dockerfile with:# Start from a TensorFlow-compatible Docker image
FROM jupyter/tensorflow-notebook
# Add the extra dependencies for TF-hub
RUN pip install --upgrade pip
RUN pip install --upgrade "tensorflow>=1.7.0"
RUN pip install --upgrade tensorflow-hub
RUN pip install --upgrade seaborn

Build the image:docker build --rm -t jupyter/tensorflow-with-tfhub-notebook .

Start the image:docker run -p 8888:8888 jupyter/tensorflow-with-tfhub-notebook

Log into the Jupyter notebook in http://localhost:8888
Download the ipynp files and upload them to the local notebook --- they should run verbatim (although you might need to move any pip install from the ipynp cells to the Dockerfile config).

Any module you run will be locally cached in the TF-hub cache dir and will be part of your image. So, in theory, you could run all modules and they will be locally cached and part of the image.


manual install and kustomize docs are wrong

deploy/ directory has nothing but operator yaml in it now.

@iam-veeramalla I don't believe I see any instructions that reference the /deploy directory any longer. Looks to have been replaced with make deploy and make deploy IMG=quay.io/my-org/argocd-operator:latest. So I believe this can be closed?

@tylerauerbeck .. Yes, docs are updated by @jopit . Thanks for noticing this.


remove synchronized in NewInstanceServiceLoader

Pull Request Test Coverage Report for Build 5268

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 63.189%

Totals

Change from base Build 5267:
0.008%

Covered Lines:
7927

Relevant Lines:
12545

💛  - Coveralls


Is it possiable to hide cursor in tigerVNC or change tigerVNC to X11VNC

I want to use novnc in --nocursor mode,but tigerVNC doesnot support it ,is it possiable to hide cursor in tigerVNC or change tigerVNC to X11VNC

Hello @dandelions ,
thank you for you feedback. However, I'm not sure, what actual effect should the option --nocursor have. Should it hide the mouse cursor or the cursor during text editing?
Maybe the view-only mode  would help? You can switch it on by setting the environment variable VNC_VIEW_ONLY. It's described on this page in the User Guide.
Regards,
accetto

Closing the issue because I cannot really answer the question. Sorry.


Allow propagtion seconds to be configurable

--dns-cloudflare-propagation-seconds
Currently using:
certbot_dns_credentials_file: "/etc/letsencrypt/dns-{{ certbot_dns_plugin }}-credentials --dns-cloudflare-propagation-seconds 60" # hack to add propagtion seconds

as workaround

What about creating a new var certbot_create_command_extra_args that you can put anything you want on "create command" ?
You can enable it with certbot_enable_extra_args = true.
i am currently unable to change it and test it atm but you could change it to:
certbot_create_command: >-
{{ certbot_script }} certonly
{{ '--hsts' if certbot_hsts else '' }}
{{ '--test-cert' if certbot_testmode else '' }}
{{ certbot_create_command_extra_args if certbot_enable_extra_args else '' }}
--noninteractive --agree-tos
--dns-{{ certbot_dns_plugin }} --dns-{{ certbot_dns_plugin }}-credentials {{ certbot_dns_credentials_file }}
--email {{ cert_item.email | default(certbot_admin_email) }}
-d {{ cert_item.domains | join(',') }}
{{ '--deploy-hook /etc/letsencrypt/renewal-hooks/deploy/reload_services.sh'
if certbot_create_reload_services
else '' }}
let me know if it works and solve your issue.

It actually makes more sense! :)

Changed the variable to certbot_create_command_extra_options.
There is no need to set true/false anymore. Made it easier.
certbot_create_command_extra_options defaults to empty.
CI/CD changed a bit from those years. Once i fix everything i will publish on Galaxy a new version.


Handling docker stop on base WLS images

(Ref @mriccell & @Djelibeybi)
Hi Monica,
Avi asked me to create this trackable issue for you. Here is the issue, as being discussed here:
https://github.com/oracle/docker-images/pull/401/files/27aede9ce9a19b938d187612ca04d966328bac62#diff-6f66197890c7328aa441744e5a168c03
docker stop isn't converted to a forceShutdown request for WLS server. Here is what I tried:
docker pull container-registry.oracle.com/middleware/weblogic:<IP_ADDRESS>
docker run container-registry.oracle.com/middleware/weblogic:<IP_ADDRESS>

And then on the side I issued a docker stop request using a generated container name
docker stop epic_meitner

I can see that shutdown hook is not invoked, and the container stopped after 10 seconds (the default difference between the time SIGTERM and SIGKILL are sent to the container process)
Had it worked, I would have expected to see something like the following on stdout of the container:
<Jun 5, 2017 3:18:30,533 PM PDT>
<Jun 5, 2017 3:18:30,534 PM PDT> <Server shutdown has been requested by .>
<Jun 5, 2017 3:18:30,538 PM PDT>
<Jun 5, 2017 3:18:30,549 PM PDT>
<Jun 5, 2017 3:18:30,549 PM PDT>
<Jun 5, 2017 3:18:30,561 PM PDT>
<Jun 5, 2017 3:18:30,601 PM PDT> <JMX Connector Server stopped at service:jmx:iiop://<IP_ADDRESS>:7001/jndi/weblogic.management.mbeanservers.edit.>
<Jun 5, 2017 3:18:30,602 PM PDT> <JMX Connector Server stopped at service:jmx:iiop://<IP_ADDRESS>:7001/jndi/weblogic.management.mbeanservers.domainruntime.>
<Jun 5, 2017 3:18:30,666 PM PDT> <JMX Connector Server stopped at service:jmx:iiop://<IP_ADDRESS>:7001/jndi/weblogic.management.mbeanservers.runtime.>
Stopping Derby server...
Derby server stopped.

There are SIGTERM and SIGKILL handlers but they're not working, so this is a bug not an enhancement.

@mriccell @aseembajaj any update on this?

Hi @brunoborges,
@mriccell and I had initially discussed some refactoring in base image so that such signal trap can be re-used in derived image. The initial plan was for me to make the change. But @mriccell said that she/someone else will make the change now. So I have simply removed my implementation of signal trap in this image.

Should I close this issue then?

@mriccell said that she will take care of that issue. Perhaps we can wait for her to respond when she is back. Or is that too long a wait?

We can wait :-)

I am on vacation starting tonight, it will have to wait ;-)
Monica
Sent from my iPhone

On Jul 18, 2017, at 6:01 PM, Bruno Borges<EMAIL_ADDRESS>wrote:
We can wait :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Any update on this?

@mriccell can you take a look please?


Key Actor plot does not display actor name or color

The Key Actor plot is displaying a number for a label rather than the name of the actor. The color is not being displayed either.

Fixed by ensuring the "actor" column was included as the dataframe was passed on in the calculate.keyactors function.


Organize package selection GUI (Quality of Life)

Details
The current package selection interface in the GUI is starting to more difficult to sift through as more packages get added.
It would be nice to be able to have the ability to start typing a package name and have the package list filter down to that for easier searching. The alphabetical ordering right now is fine, just tedious.
Another possible addition might be to have drop down menus or branches for the categories we use for our packages. This way people know what each tool is used for at a glance without having to know what a tool is or look up what a tool does.

Closing as this is a duplicate of https://github.com/mandiant/flare-vm/issues/432
Will add this discussion there.


The Bubbles Animation not looking Good

Describe the bug
The bubbles animation in the whole website is not looking good
Expected behavior
A clear and Minimal UI that goes with your Website's theme will be Good
Screenshots (Mandatory)

Additional Context (Mandatory )
The website Loading time gets longer due to the bubbles animation
Are you contributing under any open-source program ?
Please Assign to me Under GSSoC'24

Hello I am Gargi from IIT Kharagpur! I work with html,css,js,react.js and so on and am eager to learn more. I'd appreciate being assigned this task for GSSoC 24.

@nishantharkut Thanks for raising the issue. But as per the rule of this repo . You can get assigned 1 issue at a time. As you are already assigned I can't assign you this issue

@nishantharkut As this is a really good issue . So I am assigning you this issue this time.. start working on both of the issues.
But from next time please don't raise more than 1 issue at a time so that everyone can get a chance to contribute


Draw* methods lack a stroke thickness parameter

So it's not possible to draw, for example, a rectangle with a border whose thickness is more than 1 pixel

This is not an issue but a question. ;)
You could simply draw multiple rectangles.

here is a quick extension method that handles thickness for DrawRectangle, could easily be adapted to the other Draw* methods.
public static class WritableBitmapExtensions
    {
        public static void DrawRectangle(this WriteableBitmap bmp, int x1, int y1, int x2, int y2, Color color, int thickness)
        {
            for (var i = 0; i < thickness; i++)
            {
                bmp.DrawRectangle(x1+i, y1+i, x2-i, y2-i, color);
            }
        }
    }


Access to video recap

Within the the daily scores (https://api-web.nhle.com/v1/score/now) there is a three minutes recap video for each game. Any idea on how I could get access to that video?

https://www.nhl.com/video/recap-panthers-at-red-wings-3-2-24-6348106021112
Something like that.
You're going to have problems downloading it though but you can link to it.

Not sure I totally follow. I'll try my best to answer.
In this example entry:
threeMinRecap:  "/video/recap-panthers-at-rangers-3-4-24-6348243525112"
You would access the three minute recap by just putting that string at the end of "https://www.nhl.com"
So: "https://www.nhl.com/video/recap-panthers-at-rangers-3-4-24-6348243525112"


CI: Upload cross-compiled artifacts as well

Currently only the result of the alpine linux 64 bit build is uploaded as a build artifact, in action runs as well as releases. Especially for the releases, I think we should provide the cross-compiled builds as well.
(Unfortunately it doesn't solve cross-compiling for my board since my yocto linux glibc is too old. But I'm not sure, if we want to support legacy systems as well.)
This PR also fixes an issue with the version number that's automatically included in the build and displayed in the log messages during startup. Since the git tags are used for this version number, a shallow clone as it's done by default just gets us the commit hash and no "nice" version number.

Are these uploads useful at all? We are building dynamic binaries and uploading them which doesn't feel good. I think we should either get it packaged for/by some distros or use a better approach like a appimage, minimized docker container, flatpak etc

You're probably right, that proper packaging is the better way, if we want to provide binaries. I just saw, that one binary is uploaded to the workflow result (which will only be kept 90 days or so) and also tagged releases (indefinitely).

It was @patrickelectric  who added that I think. @patrickelectric  are you using these binaries? Are they useful?

Yep, they are pretty hand for anyone that depends of specific versions and wants to download is easily.
+1 also for the static musl binaries.

well... I guess we can merge this and when we have something else that is better, we can replace it.


Open VSX

Would it be possible to publish the extension also to Open VSX? That way it can also be used with Gitpod and Theia. This would be really great :-)

Published: https://open-vsx.org/extension/PeggyJS/peggy-language
I am leaving this ticket open until I get verified, via https://github.com/EclipseFdn/open-vsx.org/issues/686

Thanks for publishing it there. Unfortunately, I am not able to install it in Gitpod (Can't install 'peggyjs.peggy-language' extension because it is not compatible with the current version of VS Code (version 1.59.0).), but I have no problem with installing a downloaded vsix file of Peggy (PeggyJS.peggy-language-2.2.0.vsix). So maybe there is some unneeded version constraint (not sure about that).

I am not sure how often they update. We could leave the issue open and I will test it sometimes, see if it works anytime soon, and finally close the issue. In the meantime, I will use the downloaded vsix file. Ok?

That works for me.  Let's see what happens and then formulate a plan later in the week.

It seems Gitpod upgraded their VS Code and your extension now works in Gitpod correctly. Thanks a lot! Closing this issue now.

I want to leave this open until I'm the verified owner of the PegJS namespace on VSX.


getting 'Unreachable hosts - your application id may be incorrect. If the error persists, contact<EMAIL_ADDRESS>but data getting ingested

Hi,
I'm getting the error 'Unreachable hosts - your application id may be incorrect. If the error persists, contact<EMAIL_ADDRESS>the console even though all records have been added to the index successfully it seems (the record count is same as in the .json data file). The .json file is not even 200KB with 220 records. I'm also sending data in small batches (30 records/batch).
I'm using "algoliasearch": "^4.11.0" .
Any idea what's causing this?
Thanks.

This error means that the servers could not be contacted, and usually is caused by a network problem. If you can reproduce that consistently, please contact<EMAIL_ADDRESS>

I'm getting the same issue if I create my own algoliasearch client with a different requester (request-http-node) and I can't understand why
const algoliasearch = algoliasearch(    'YourApplicationID',    'YourSearchOnlyAPIKey', {    requester: createBrowserXhrRequester() });

Same issue here. We started receiving this error after updating from version 3.32.0 to 4.14.2
The error message has an extra number suffixed to the application id - example below:
{
            "message": "Opening request to https://{app_id}-1.algolianet.com/1/indexes/{index}/query",
}
{
            "message": "Opening request to https://{app_id}-2.algolianet.com/1/indexes/{index}/query",
}

Unreachable hosts error is related to your network not the client itself
please see this ticket for resolution https://support.algolia.com/hc/en-us/articles/5473401113745

@eagor
I got the same issue, it's not Algolia's Issue but Next.js's issue.
We need to add NEXT_PUBLIC_ when using environment-variables from browser
https://nextjs.org/docs/basic-features/environment-variables#exposing-environment-variables-to-the-browser

import algoliasearch from 'algoliasearch';
import {getMongoDb, mongoDb} from "../../config/mongoDb";
import {Promise} from "q";

const MongoClient = require('mongodb').MongoClient;

const _ = require('underscore')

const client = algoliasearch('...', '...');
const index = client.initIndex('products');

MongoClient.connect(mongoDb.url.production, {
    promiseLibrary: Promise,
    poolSize: 100,
    useNewUrlParser: true,
    useUnifiedTopology: true
}, async (err, db) => {
    if (err)
        throw err
    const oDb = db.db('backend');

    // Products
    let products = await oDb.collection("products").aggregate([
        {
            $match: {
                'status': true
            }
        }
    ]).toArray();

    console.log("Product ", products.length)

    let chunks = [];
    Promise.all(await products.map(p => {
        chunks.push(p);
        if (chunks.length > 500) {
            index.saveObjects(chunks, {autoGenerateObjectIDIfNotExist: true}).wait().then(i => {
                console.log("batch done")
            }).catch(reason => {
                console.log(reason)
            })
            chunks = [];
        }
    }))

    // last batch
    if (chunks.length > 0) {
        index.saveObjects(chunks, {autoGenerateObjectIDIfNotExist: true}).wait().then(x => {
            console.log("Done")
        }).catch(reason => {
            console.log(reason)
        })
    }
});

Please note that app_id and admin_api_key are correct and not interchanged.
The fact that I can connect and query my production server means the network certainly doesn't have any issues. Are we still labelling this as client side issue?
Here's my console output

Response from support

You might want to check if your Content Security Policy is blocking algolia - That's what caused this issue for me.

you saved my day!!!


Move scripts/code to github for collaborative development?

I have a few suggestions for how to improve the scripts, which I'll send as a separate issue, but on the high level it's hard to send a PR to improve the code if the scripts are part of a separate zip that's downloaded. Maybe we could make the scripts directory part of the repo. If this makes sense I'll send a PR.

Should be fixed by #12


Clean iter mut pattern

This is not a bug fix, and criterion saw no performance change. I saw this pattern in some code the other day and thought it was more clear. Maybe subjective!

Coverage decreased (-0.0001%) to 92.873% when pulling d548a17fb4a967a30280b1c3c565fc4178f3266e on clean-iter-mut into d37b4c2bbd46afdf278883975d74063c4bf6e25b on main.

This is cool! Totally thinkin on where else I can apply the same pattern now too 🤩
Weird new clippy stuff from these "Unchanged files with check annotations" reports. If you feel like tackling those sometime I'd be glad for it but we could also make an issue w the help wanted / good first issue tag to knock out clippy stuff like this


heredocs-<IP_ADDRESS> test suite failure

Citing from http://hydra.cryp.to/build/1952633/nixlog/3/raw:
running tests
Running 1 test suites...
Test suite doctest: RUNNING...

<no location info>: error: can't find file: test/Test.hs
Test suite doctest: FAIL

Hmm. i look this just now.
I've been using ghc 8.0.1.
And I fail to cabal test.

fix it. #ae57e27.
I'd like to close this issue, after confirm hackage server build reports passed


just a new dark skin for IDA Pro 7.2

Hi @uniskz,
thank you for the PR! Unfortunately, as noted in the README, IDASkins is now deprecated and we only continue to do basic maintenance for a while. New themes should target IDA 7.3's theming mechanic directly.


Prevent bolding/enlargment on cell selection

Is there a way to prevent bolding/enlarging on cell selection without using the cellSection: false which doesnt allow the person to select at all?
Sample fiddle:
https://jsfiddle.net/zaslam/k5bdh7o3/

@zebaslam I think you can use the  foregroundSelectionFont property for the hypergrid
e.g. '12px Tahoma, Geneva, sans-serif',

@noahtaylor That definitely helped with the bold issue! Thanks!
However, Im still seeing the columns being enlarged
Updated fiddle: https://jsfiddle.net/zaslam/k5bdh7o3/4/

@zebaslam We can take at your issue tomorrow

@zebaslam more font issues.  check out:
https://jsfiddle.net/k5bdh7o3/5/
You need to set all the fonts consistently, otherwise columns will auto resize based on the fonts changing to bold e.g.
columnHeaderFont:'12px Tahoma, Geneva, sans-serif',
font:'12px Tahoma, Geneva, sans-serif',
columnHeaderForegroundSelectionFont:'12px Tahoma, Geneva, sans-serif'

This is way better! Thanks @noahtaylor


Head merged back

Hi Andreas
I was wondering why do you keep doing this kind of pull requests between doctrine:master and your own master branch. I've compared theirs and yours and they seem identical. It will be easier for you to move your master branch pointer to the same commit of doctrine:master (http://stackoverflow.com/questions/5471174/git-move-branch-pointer-to-different-commit-without-checkout). This will allow you to just do fast-forward merges from that point on.
Hope this helps you.


Show time remaining

Hi!
Thank you for your work.
If possible, can you add the feature to show time remaining, when time is active?
Best Regards.

Too custom to be in scope of this plugin.


fix: fix C4715 warning

Fixes not all control paths return a value Compiler Warning (level 1)
C4715.
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715
You may want to just squash this to get rid of my extraneous history.

Thanks for the fix, I haven't been testing DKUtil with SKSE environment lately. This was a side effect introduced when I split the logging level into ERROR and FATAL, the prior one doesn't force exit. For handling C4715 I recently changed ERROR to
FATAL(...);
std::unreachable();

What do you think?

Seems reasonable.


Make Collapse/Expand All button of Search tree initialize correctly (fix #204316)

This PR fixes #204316

Hmm, seems to make sense. I can't repro the issue so I don't know if this fixes it, but we can give it a try. Thanks for looking into this!


Offchain attestation reference

I think since there are offchain attestations. We should be able to reference it. These lines prevent offchain attestations referencing.
https://github.com/ethereum-attestation-service/eas-contracts/blob/48e31ceb5e38e133d246ca26da8ab13e170000c2/contracts/EAS.sol#L495-L500

The rationale behind reference UIDs was to allow building a graph of onchain attestations, so indeed, referencing an offchain attestation won't work here. You can consider attesting to an offchain attestation as part of the scheme, or using the timestamping feature.

But the timestamp also doesn't work? Since isAttestationValid is not checking for _timestamps[uid] != 0

Oh, sorry for not being clear. I've meant that you can reference an offchain attestation by either timestamping it (thus proving in the future that the attestation existed at this time) or by attesting to it via a custom schema. In any case, supporting referencing to offchain attestations explicitly would be definitely something to consider for the next version.

Sadly, because of this problem, I spent 2 days checking the contract(a little complicated) implementation problem. After setting the off-chain reference, a custom error will occur in make on-chain attest, but the specific reason will not be prompted, because it is an exception thrown by revert. You'll never know what went wrong, it's a very, very bad design.
The Offchain attestation reference issue should be clearly told to developers in the documentation, otherwise it will be very confusing when the issue occurs.


Advanced Coke Oven issue

The reinforced coke bricks don't seem to be recognized by the morphing tool for swapping to the IE hammer, and even when properly built, the multiblock refuses to form.

The advanced coke oven no longer exists in Immersive Tech

Interesting, I wonder why the advanced coke bricks are still craftable then.
Though I'm having the same issue with the Distilling tower not forming as well
Sent from my Galaxy
-------- Original message --------
From: Filostorm @.>
Date: 2022-05-22 4:05 p.m. (GMT-08:00)
To: Filostorm/Multiblock-Madness @.>
Cc: Kyuuragi @.>, Author @.>
Subject: Re: [Filostorm/Multiblock-Madness] Advanced Coke Oven issue (Issue #127)
The advanced coke oven no longer exists in Immersive Tech
—
Reply to this email directly, view it on GitHubhttps://github.com/Filostorm/Multiblock-Madness/issues/127#issuecomment-1134011343, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZI7PCP4STP5DU2JPCYC6YTVLK4R5ANCNFSM5WT343RQ.
You are receiving this because you authored the thread.Message ID: @.***>

Structure is built as shown in the IE manual, so seemingly no issues on that front, but the multi block won't assemble.
Tried using the capsule from the quest reward as well, but strangely - though the capsule icon changes to loaded -, attempting to use the capsule neither consumes the items from my inventory, nor comes up with a preview for the tower in the world.
The blue outlines marking the area of the structure appear, but nothing for the structure itself.
-------- Original message --------
From: Filostorm @.>
Date: 2022-05-22 6:19 p.m. (GMT-08:00)
To: Filostorm/Multiblock-Madness @.>
Cc: Kyuuragi @.>, Author @.>
Subject: Re: [Filostorm/Multiblock-Madness] Advanced Coke Oven issue (Issue #127)
That's a good point, I'll consider removing them.
The Tower has no issues I know of, can you double check the structure?
—
Reply to this email directly, view it on GitHubhttps://github.com/Filostorm/Multiblock-Madness/issues/127#issuecomment-1134059312, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZI7PCMGLGR7WPZRFU2LAATVLLMJ7ANCNFSM5WT343RQ.
You are receiving this because you authored the thread.Message ID: @.***>

In case it matters, I just updated the pack to 3.1.0, uncertain if that may be aa part of the issue

Crafted a new Engineer's Hammer to test, no change.

Is that the only multiblock that's  not forming?

I've tested out forming the distillation tower on the latest version of the modpack and it works fine. Try right clicking the redstone engineering block with the engineer's hammer.

Seems to be working now, not sure what the issue ended up being in the end


Split reactive into its own module

Merged via https://github.com/spring-projects-experimental/spring-pulsar/commit/a8d65ec168ed74d9c2307e2cb44f10f203c7b05b


Can't drag notes between columns in board view

What happened?
When I try to drag a note from one column to another, it tries to move/reorder the entire column instead.
What did you expect to happen?
Dragging a single note to another column should change that note's status value so that the note moves to the column it was dropped on.
How can we reproduce it (as minimally and precisely as possible)?
Create a board view and put notes in more than one column. Try to drag an individual note from one column to another.
Anything else we need to know?
No response
Plugin version
1.3.0
Obsidian version
1.0.3
OS
Windows

You're right! I limited drag and drop to when the priority field is set, but you should still be able to change the status even if you can change the priority.

I'm confused. My priority field IS set. Both the status and priority fields have values. What am I doing wrong?

Hm. That is indeed a bug then. You should definitely be able to sort cards with a priority field set. Is there anyway you could create a screen recording of what you're seeing?

Here's a Loom link. The audio is messed up for some reason, but I just created a new project, threw five notes in it with different statuses, set the status and priority drop-downs and then tried to drag a task from one column to another. This is in Edge if that makes a difference.
https://www.loom.com/share/443d796e198745f3b7506a4deb7173d7

I don't have a Windows machine unfortunately, so I don't know when I'll be able to reproduce this. If anyone else is seeing this on a different OS, I'll prioritize this. If any Windows devs are seeing this, I'd love help debugging this 🙏

I tested it. The problem occurs when the priority drop-down is sorted by an date field. When using number field to sort, the drag and drop works well. FYI
Windows OS, plugin 1.3.0

Ah, a drug interaction between two separate things I need. Nice.

Oh yeah, date fields can't be reprioritized. Mostly because the plugin has no way of telling what date to set on the card that was moved. Can I ask what how you'd expect it to work?

Maybe we can make date field invisible in the priority drop-down.

This was introduced in #172. Though thinking more about it, maybe it was added a little prematurely. For date fields, it simply becomes a matter of sorting cards rather than prioritizing them. For example, we could enable string fields to sort cards alphabetically, which isn't quite what the feature is about.

Date fields WERE invisible in the priority drop-down. That was another issue I had entered.
I would say that when the priority drop-down is set to a date field, you simply disable the ability to drag and drop within a column. I should still be able to drag and drop between columns, just not within a column.

I use due date mainly to prioritize so I'm voting also to add ability to move cards between sections even when priority is set to date. So to move cards between sections even if no need to move them withing section itself.


NAVY Patrol mission dialog confirmations

No start of mission confirmation dialog.

Added launch dialog to patrol missions
cleaned up NATC characters in patrol and rescue missions


Reach limit of External Networks

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Not sure if this is a Dockge or a Docker limit (I wasn't experiencing it running my containers with regular docker compose though).  It looks like there is a limit of 30 x containers that have their own 'External Networks' automatically get created.  After which trying to start any additional containers generates an error:
Error: failed to create network xyz_default: Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network
👟 Reproduction steps
Create 30+ containers
👀 Expected behavior
Container #31+ should deploy as normal without issue
😓 Actual Behavior
Docker generates error as per description.
Dockge Version
1.3.1
💻 Operating System and Arch
AlmaLinux 9.3
🌐 Browser
n/a
🐋 Docker Version
24.0.7
🟩 NodeJS Version
No response
📝 Relevant log output
No response

it should be a docker issue, dockge  is just running docker compose up -d for you. Nothing we can do.


Youtube playlist downloading is broken

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2019.11.22
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

> youtube-dl -vi --yes-playlist --no-check-certificate  --extract-audio --audio-format m4a -o "<redacted>\%(track)s - %(artist)s.%(ext)s"  "https://www.youtube.com/playlist?list=PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-vi', '--yes-playlist', '--no-check-certificate', '--extract-audio', '--audio-format', 'm4a', '-o', '<redacted>\\%(track)s - %(artist)s.%(ext)s', 'https://www.youtube.com/playlist?list=PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2019.11.22
[debug] Python version 3.8.0 (CPython) - Windows-10-10.0.18922-SP0
[debug] exe versions: ffmpeg N-87353-g183fd30, ffprobe N-87353-g183fd30, phantomjs 2.1.1
[debug] Proxy map: {}
[youtube:playlist] PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq: Downloading webpage
[download] Downloading playlist: PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq
[youtube:playlist] playlist PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq: Downloading 0 videos
[download] Finished downloading playlist: PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq

Description

Playlist has 31 videos in it
youtube-dl detects and downloads 0

youtube-dl https://www.youtube.com/playlist?list=PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq
[youtube:playlist] PLhuV-wp3Q6ITvdGi-8PMMQQUxgWviiOcq: Downloading webpage
[download] Downloading playlist: playlist no 1
[youtube:playlist] playlist playlist no 1: Downloading 31 videos
[download] Downloading video 1 of 31
[youtube] iX-QaNzd-0Y: Downloading webpage
[youtube] iX-QaNzd-0Y: Downloading video info webpage
[download] Destination: Milky Chance - Stolen Dance (Album Version)-iX-QaNzd-0Y.mp4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0


No Validation examples

No Validation examples are available

Required
Numeric
Regular expression
how to write custom validation fuction if need then.

Do you want see validation examples for the datepicker or some other part of the library?


about the improvements over the results in the paper

Hi, thanks for releasing the code of the excellent work (DINO).
It seems that the released code achieves better results than the ones in the DINO paper (49.0 mAP vs. 47.9 mAP for 12 epochs with DINO-4scale). Are there some further improvements provided in this repo?
It will be much appreciated if more details about the improvements are provided. Thanks in advance.

Thanks for your quick response.
For the initialization of the parameters in deformable attention, do you mean the code in L232-L234 are not included in the initial version?

yes

Got it. Thanks a lot!


Merging real data with Mirage data.

Feature request
Is it currently or could it be possible to use fake/seeded data in combination with real data being requested via Mirage's passthrough feature? In my case, I'd like to create records via Mirage which are tied to a real user in our system. I can't, however, figure out how to delay Mirage initialization until after the user has been loaded. My hope would be able to use the afterCreate hook to tie a newly created record back to that existing user. Seems like this feature might be related to:  #1416.

Hm can you list out the actual steps in the flow? Will your app be hitting the actual network for one set of endpoints and Mirage for another? I think if I see the steps and where and what you want Mirage to do I could help.

Thanks for getting back to me Sam. Yes, the idea would be to mix actual network requests with Mirage requests. Right now the main network request is to retrieve the current user/session.
The steps are as follows:

Seed Mirage with project data. These projects belong to a user. When I seed Mirage, I don't yet have a real user.

In my default scenario:
import { Server } from 'ember-cli-mirage'

export default function(server: Server) {
  /*
    Seed your development database using your factories.
    This data will not be loaded in your tests.
  */
  server.createList('project', 3)
}

In app/routes/application.ts, authenticate the user. Right now I'm adding this user to a dev only window.mirage object so I can access it when retrieving projects.

if (this.sessionService.isAuthenticated) {
      const currentUser = await this.store.findRecord('arcgis/user', this.sessionService.credential.userId)
      if (window.mirage) window.mirage.currentUser = currentUser
      return currentUser
    }

I'm using window here because I couldn't figure out a way to get a handle on the store or `services from within the mirage config.

In mirage/config.js project route handler update the fake Mirage projects with the real user.

this.get('/ArcGIS/rest/services/collector/projects', schema => {
    const projects = schema.projects.all()
    projects.update('ownerId', window.mirage.currentUser.portalId)
    return projects
  })

My thought is it would nice to have control over when seeding Mirage takes place. That way, I could use my authenticated user during data creation rather than having to modify the data as it's being retrieved. Is there a better/more miragey way to accomplish my goal? Thanks so much for your help! Also, please let me know if I can provide you with more code/context around my setup.

Very interesting.
I haven't hit this situation before but I wonder... Mirage route handlers can be promises so what if you did something like this:
this.get('/auth', (schema, projects) => {
  return fetch('http://localhost:3000/real-auth-endpoint', { some: data })
    .then(res => res.json())
    .then(json => {
      schema.projects.all().update({ ownerId: json.portalId })

      return json;
    })
})

Then at least you could update your Mirage seeds once, on auth.
Another question: why not mock out the auth route too, and keep all data in Mirage?
Another idea: seeds could become async. (Then you could fetch data before initializing). This would be interesting for many possibilities.
Another idea: you could use an initializer that defers application readiness, fetches the user, updates Mirage and then proceeds with the application boot.


Remove viewURI argument from HUBContentOperationActionObserver API.

🚚  Delivers: https://github.com/spotify/HubFramework/issues/112
We can remove viewURI argument because HUBActionContext already contains it.

Current coverage is 92.62% (diff: 100%)

Merging #116 into master will decrease coverage by <.01%

@@             master       #116   diff @@
==========================================
  Files            58         58
  Lines          4121       4120     -1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3817       3816     -1
  Misses          304        304
  Partials          0          0

Powered by Codecov. Last update 8751813...9d24978


[Dubbo-fix]: polish LFUCache

What is the purpose of the change
review #5734
Brief changelog

Rename constants to represent what it means:
DEFAULT_LOAD_FACTOR -> DEFAULT_CAPACITY
DEFAULT_EVICTION_CAPACITY -> DEFAULT_EVICTION_FACTOR
Refactor codes:

if (map.containsKey(key)) {
         node = map.get(key);
         if (node != null) {
               CacheNode.withdrawNode(node);
         }
         node.value = value;
         freqTable[0].addLastNode(node);
         map.put(key, node);
 }

Add test case org.apache.dubbo.common.utils.LRUCacheTest#testErrorConstructArguments.

Verifying this change
Run test case org.apache.dubbo.common.utils.LRUCacheTest
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[x] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5994 into master will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #5994      +/-   ##
============================================
- Coverage     61.21%   61.13%   -0.08%
+ Complexity      494      492       -2
============================================
  Files           989      989
  Lines         39300    39299       -1
  Branches       5649     5648       -1
============================================
- Hits          24058    24026      -32
- Misses        12597    12619      +22
- Partials       2645     2654       +9

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/common/utils/LFUCache.java
84.31% <50.00%> (+4.70%)
0.00 <0.00> (ø)

...he/dubbo/common/threadpool/ThreadlessExecutor.java
52.17% <0.00%> (-10.87%)
0.00% <0.00%> (ø%)

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
72.41% <0.00%> (-10.35%)
0.00% <0.00%> (ø%)

...dubbo/remoting/exchange/support/DefaultFuture.java
81.89% <0.00%> (-6.90%)
0.00% <0.00%> (ø%)

...mmon/threadpool/support/AbortPolicyWithReport.java
85.00% <0.00%> (-5.00%)
0.00% <0.00%> (ø%)

...e/dubbo/remoting/transport/netty/NettyChannel.java
55.68% <0.00%> (-4.55%)
20.00% <0.00%> (-1.00%)

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
8.00% <0.00%> (-1.00%)

...c/main/java/org/apache/dubbo/rpc/RpcException.java
80.00% <0.00%> (-3.34%)
0.00% <0.00%> (ø%)

...pache/dubbo/registry/support/AbstractRegistry.java
78.06% <0.00%> (-2.98%)
0.00% <0.00%> (ø%)

.../remoting/transport/netty4/NettyServerHandler.java
56.81% <0.00%> (-2.28%)
0.00% <0.00%> (ø%)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317e62f...a0d0519. Read the comment docs.

@chickenlj
PTAL, Fell free to close it if it has be included in other PRs or It is not expected to change. Thanks.

@tangcent hi, thanks for your contribution
pls resolve confilcts with the latest master branch

@AlbumenJ  done.


Support website nowvideo.club

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl --verbose "http://nowvideo.club/videos/n1nlo6r87pnv"
[debug] System config: []
[debug] User config: ['-r', '1M']
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'http://nowvideo.club/videos/n1nlo6r87pnv']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.02.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg N-93016-gb8ebce4f84, ffprobe N-93016-gb8ebce4f84
[debug] Proxy map: {}
[generic] n1nlo6r87pnv: Requesting header
[redirect] Following redirect to http://nowvideo.club/play/n1nlo6r87pnv
[generic] n1nlo6r87pnv: Requesting header
WARNING: Falling back on generic information extractor.
[generic] n1nlo6r87pnv: Downloading webpage
[generic] n1nlo6r87pnv: Extracting information
ERROR: Unsupported URL: http://nowvideo.club/play/n1nlo6r87pnv
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6w61832c\build\youtube_dl\YoutubeDL.py", line 794, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6w61832c\build\youtube_dl\extractor\common.py", line 508, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6w61832c\build\youtube_dl\extractor\generic.py", line 3320, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://nowvideo.club/play/n1nlo6r87pnv

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: http://nowvideo.club/videos/n1nlo6r87pnv

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
I checked the supported websites on youtube-dl webpage and NowVideo is reported as supported but I'm still having troubles downloading from it. I think this is caused by a possible nowvideo mirror that isn't recognized by youtube-dl. Regarding the video itself I'm trying to download, it's a video previously hosted on my national tv web streaming website and later vanished from it. Since the website itself is supported by youtube-dl there should be no problem whatsoever with this website support request or so I think. Just wanted to make the source of the video clear here in the description of the issue.
Regarding the website itself I think it's kind of sketchy and full of ads (I'm using an adblock and I think you should do the same in case you are going to visit the url when checking it out. I also tried registering but it fails to redirect to a proper registration prompt. I don't know if this is an issue with mirrored websites or if the website itself is just using nowvideo name to get web traffic but the video itself works.

Video is not available.


Added placeholder for isDate

I use the ignore placeholder a lot but for timestamp fields, it'd be useful to check that the value is a valid date instead of ignoring it

Many thanks @MilkyWare
in some way this overlaps a bit with https://github.com/xmlunit/xmlunit/pull/178 which adds optional arguments to placeholders and https://github.com/xmlunit/xmlunit/issues/174 which asks for date matching placeholders and could benefit from optional patterns - which would also be a nice enhancement to your work here.
I intend to somehow merge the efforts but may need a while until I can find some spare time to actually do it.

many thanks @MilkyWare I'll merge this as is and will later extend it to accept an optional pattern.
I wonder whether isDateTime would be a better name than isDate as this confers the fact that dates and timestamps are accept better.

I've just pushed the 2.8.0 packages to nuget.


Missing dependencie

import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
@NgModule({
  ...
  export: [
    ...
    BrowserAnimationsModule
  ],
  ...
})

Sorry, I don't get what's the problem. Would you mind elaborating the issue a bit better? Thanks!


reset root navigation while nested navigation is presented

Hello!  Here is my app's navigation structure

RootModalStack // mode: 'modal', headerMode: 'none'

AppStack
AuthStack

AuthStack

AuthPage1
AuthPage2

AppStack

Splash
MainPage

I'd like the app to behave like this -
User sees the splash page first while things load
If the user is logged in, push to MainPage and make it impossible to go back (*I am mostly there with this, although I am using a NavigationActions.reset to achieve it and there is no animation push, which is jarring)
If the user is not logged in, present the login screen as a modal. (* this is working too because RootModalStack has mode 'modal' on it)
now, after login is successful, like on AuthPage2, I want the entire AuthStack to animate back down (aka modal animation) and I want the view underneath that it reveals to be MainPage.
I am almost achieving this by doing the following in AuthPage2.
// 1)
let {dispatch} = this.props.navigation
dispatch(NavigationActions.back())

// 2)
let resetAction = NavigationActions.reset({
        index: 0,
        actions: [ NavigationActions.navigate({ routeName: 'MainPage'})  ]
})
this.props.navigation.dispatch(resetAction)

But this isn't working 100% the way I want - The AuthStack modal begins to pop, but it is showing Splash underneath it, then the resetAction happens and flings the user to MainPage, no animation again.
I have tried putting 2) before 1) but what happens is a nasty red-screen telling me that 'MainPage' isn't a route I can choose, it only offers me choices from RootModalStack.
Thanks, I look forward to your advice & thanks for taking time to read this.

Hi @DogsForArms ! It looks like this is not a bug of the library nor a feature request, so I'll close it: I suggest next time you use Stack Overflow which is better suited for answering these types of questions. I also encourage you to join the Reactiflux community on Discord. There are React Native and React Navigation channels with helpful people who might be able to answer your question. I would also like to mention that there is a collection of helpful links and tutorials for React Navigation in the README which might be helpful for you.
That said, the easy way to do what you need is to create two separate navigators and when the user opens the app decide which one to load up next, something along the lines of this pseudo code:
          if (userIsLogged) {
            store.dispatch(NavigationActions.navigate({ routeName: 'LoggedNavigation' }));
          } else {
            store.dispatch(NavigationActions.navigate({ routeName: 'LoginNavigation' }));
          }

If you believe that you are experiencing a bug or have a feature request, please open a new Issue following the dedicated template or submit a PR.

Awesome, thanks for the support & I will head to those outlets next time.


import Config object

Hi I want to report mistake in /src/config/README.md
if you load module with let config = require('config'); then you have to use default property let currentAppEnv = config.default.appEnv; and not just let currentAppEnv = config.appEnv;
But if you will import confi module with import config from 'config'; everything is fine

@GryfonN: Thanks for pointing this out. This is true because we export the default property and it will not be available directly when using webpack requires. I would recommend using the import syntax, but your milage may vary.
However I will have a look at this.

No problem, thanks for quick response.

I am certainly late to this issue 😄 . This is certainly a regression after updating from Babel 5 to 6 (a quite common one). We could either path our setup with babel-plugin-add-module-exports (+11k downloads in the last day) or let it be a like that for that awkward transitioning phase towards ES2015. In that case I would update the README in src/config/README.md.

To avoid the extra dependency mentioned above, I've just updated the README in the master and 2.x branch of the template repository (however, anyone using Common JS will be likely installing babel-plugin-add-moudle-exports on their own sooner or later and then being able to drop the .default).
Closing this for now. Feel free to re-open it if there are issues.


HF-Reference LLM mode + Update test result to match latest Turbine.

change this

Not sure what this is pointing to lol

change this

I think I know what you mean now, It's probably the error message isn't? :)


fetch a TFS branch with --parents results in a NO-OP or I am using it wrong

Situation: I try to port a TFS repo to Git (Without intention to write to TFS, even get rid of it after migration)
To also have the complete history of source code archived in a separate Git repo, I intend to just migrate the development branch and ignore the rest (however if changes are merged from those branches, they should end up as a squash merge and not init the branch it came from and not ignore/skip them, but that is off topic)
At the start of the TFS history, there were no branches. The dev branch was created at a certain point. If I clone the dev branch, it does not pull the changesets from before the fork point. From the docs, I understand the --parents option should take care of that, but if I add it as an option, nothing is fetched at all. (not even the specified branch, (with -i))
As a workaround, I first clone the changesets up to the fork point, and then try and fetch the ones that are on the dev branch.
Am I misunderstanding or misusing what this option is for?

I intend to just migrate the development branch and ignore the rest (however if changes are merged from those branches, they should end up as a squash merge and not init the branch it came from and not ignore/skip them, but that is off topic)

Reading that, I think you want to do something like (pseudo-command) git tfs clone --branches=none $/dev
But it will ignore the rest and so also the parent branches.

If I clone the dev branch, it does not pull the changesets from before the fork point.

If you want to have this behavior, you need to use  --branches=auto (default behavior but it will initialize all the branches merged and you won't have "squash merges" anymore.
--parents option it's when you used   --branches=auto and git tfs fetched parent branches only until merge changesets and after you want to finish fetching history of all these parent branches (but the tfs remote must be already initialized --which has been done during the clone processing--)
So, in git-tfs, there is at the moment no way to have the kind of middle behavior you are expecting.
If you really want this behavior, you could:

code a new option for  --branches like  --branches=direct-parent that has the auto behavior but switch to none behavior once the 1 commit of dev branch is fetched. Don't forget to do a PR to contribute the behavior 😉
create a hard coded dirty custom build for you having this behavior or changing the value while running in debug in Visual Studio.
use --ignore-branches-regex= to ignore all the branches except the parents ones. Highly recommended to test the regex before with https://regex101.com/

Thank you for explanation.  As the oldest history in TFS only had a 'root' branch before the dev branch was created directly from it (they are basically the branch if it were Git, but in TFS it's handled as a kind of folder internally, so the branch creation in TFS was followed by a 'rename source' changeset, moving all files in that folder. As i said I cloned all changesets up to the fork point, then initialized the dev branch and fetched its first changeset , rebased it onto the so-far-latest root branch and made sure the keep the committer and date the same as the author. Then fetched the rest of dev branch. with branches=auto. When I'm done I can full rebase and make sure to keep the committer the same as the author on the entire dev branch to get rid of the merge commits, but keep the merged changes and also get rid of the empty commits resulting from ignored files or changesets that had no changes on this branch. (I have no intention to have Git changes go back to TFS anyway and it's a one-time action, so no hurry for me. Maybe just other people like this behavior too?)


$beforeDelete hook not getting called

Hi There,
I'm running into issues getting the $beforeDelete hook to fire on an instance of my models. I've followed the guides making sure to call the instance and am also using the document here as a reference.
in my controller, I have the following:
// controllers/user-cards-controller.js
let card = await Card.query().findById(req.params.id)
await card.$query().delete()
res.status(200).send({})

Then in my model...
// models/card.js
  async $beforeDelete(context) {
    await super.$beforeDelete(context);
    await this.destroyStripeCard();
    this.id ? this.scheduleWorkers('deleted') : null;
  }

I haven't had any difficulty with the other hooks nor objection otherwise. I'm also currently using Objection 2.1.3. Any help would be appreciated!

Based on the info you provided, I can't really help you. Please provide the relevant models and other code that may be causing this.

Ok, thanks for the reply. That helps actually.. It looks like this was related to the objection-soft-delete library being used on the corresponding model. Apologize for the confusion!


Prevent folder name conflicts in label() call

This PR appends a timestamp of when label() was called to the output folder label name if the provided folder name already exists and contains images.
This PR prevents the scenario where label() labels a dataset (which could be hundreds or thousands of images) then returns an error after labeling because the existing folder already contains an image with the same name as one in the newly-labeled dataset.

NB: This PR fixes #53.


refactor: fresh new look for receive screen

TL;DR

Refactored the underlying Payment Request objects towards a fresher more readable interface
Added Paycode (LNURL) as a way of receiving funds
Revamped the UI for a more cleaner look

Payment Requests
According to the Bitcoin Design guide, the domain terminology for the object holding details of how to receive funds is called "Payment Request". Thereby, this PR very clearly has two different objects:

PaymentRequestCreationData
PaymentRequest

Using the Creation Data, you can create a Payment Request (which is the layer that calls the GraphQL mutations). The benefit of segregation of these layers is that they can be separately tested.
Interface
Here's how the three Invoice types (Lightning, Onchain and Paycode) look like in the app with this PR:

Lightning
PayCode
Onchain

The UI would open with a Lightning Invoice by default with the user's default wallet preselected as the receiving account. Here are the states the view could also be in depending on the situation:

Lightning Invoice Loadin
Lightning Invoice Expired
Invoice Paid
Username unset - no Paycode

Tasks

[x] Delete two separate screens for usd and btc receive
[x] Payment Requests
[x] Expires In
[x] Paycode
[x] User Interface
[x] QR View and states
[x] Onchain Receive Fees
[x] Storybooks for new components
[x] Unit Tests for Payment Request objects
[x] End to End Test for Receive Screen
[x] Fix Bug: Username setting doesn't trigger paycode update from page

Supersedes #2442
Fixes https://github.com/GaloyMoney/galoy-mobile/issues/2463

TL;DR

Refactored the underlying Payment Request objects towards a fresher more readable interface
Added Paycode (LNURL) as a way of receiving funds
Revamped the UI for a more cleaner look

Payment Requests
According to the Bitcoin Design guide, the domain terminology for the object holding details of how to receive funds is called "Payment Request". Thereby, this PR very clearly has two different objects:

PaymentRequestCreationData
PaymentRequest

Using the Creation Data, you can create a Payment Request (which is the layer that calls the GraphQL mutations). The benefit of segregation of these layers is that they can be separately tested.
Interface
Here's how the three Invoice types (Lightning, Onchain and Paycode) look like in the app with this PR:
Lightning	PayCode	Onchain

The UI would open with a Lightning Invoice by default with the user's default wallet preselected as the receiving account. Here are the states the view could also be in depending on the situation:
Lightning Invoice Loadin	Lightning Invoice Expired	Invoice Paid	Username unset - no Paycode

Tasks

[x]  Delete two separate screens for usd and btc receive
[x]  Payment Requests
[x]  Expires In
[x]  Paycode
[x]  User Interface
[x]  QR View and states
[x]  Onchain Receive Fees
[x]  Storybooks for new components
[x]  Unit Tests for Payment Request objects
[x]  End to End Test for Receive Screen
[x]  Fix Bug: Username setting doesn't trigger paycode update from page

Supersedes #2442 Fixes #2463

some feedback looking at the screenshots:
I don't like the fact the tap to set amount / memo height is higher than the bitcoin/stablesats and lightning/paycode/onchain are

I think it makes more sense to have Lightning | Paycode | Onchain instead of Invoice | Paycode | Onchain. We also have On-chain in the button and Onchain in the title.

Going list some small follow up items:

"Tap to set amount" has smaller font than "Add note" and the payment request types
Why is the icon for set amount orange but the icon for "Add Note" grey?
"Add Note" should be "Add note" to stay consistent in capitalization patterns with "Tap to set amount"

To me this looks like bitcoin is selected (even though it is actually Stablesats selected) because your eyes naturally draw to the brighter button. Any thoughts @agbegin @nicolasburtey on color of the active button?

The note icon needs some padding

The text gets broken when font size is enlarged

Sounds good to me to merge and get feedback on the live internal app


Problem when using the "File" Method

Where is the file created? I cannot find it :(

It should be in the same folder, right next to the index.js, package.json, etc

damn that was fast wow, found it thank you


Error while installing with Node 4.2.2

I got some errors while trying to install this plugin with Node 4.x as mentioned in Error while installing 3.0.0-rc8 with Node 4.2.2.
I'm using the latest version of this plugin; 0.9.4. Any help would be appreciated.

Please try with 1.0.0


add script to propagate written release notes to the changelog

arguably fixes #754
also ran parts of it to get links to releases (as far as they went) in there.

Codecov Report

Merging #814 (0a91881) into master (0d0ec15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #814   +/-   ##
=======================================
  Coverage   70.02%   70.02%
=======================================
  Files          57       57
  Lines        3906     3906
=======================================
  Hits         2735     2735
  Misses       1171     1171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0ec15...0a91881. Read the comment docs.


2-nd lvl menu closes unexpectedly if null passed instead MenuItem. (0.20.0 - broken, 0.19.4 - works).

2-nd lvl menu closes unexpectedly if null passed instead MenuItem. (0.20.0 - broken, 0.19.4 - works).

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
2-nd lvl menu is not automatically closed
Current Behavior

Steps to Reproduce (for bugs)
<div>
        <Paper>
          <Menu desktop width={320}>
            {null}
            <MenuItem primaryText="Single" insetChildren />
            <MenuItem primaryText="1.15" insetChildren />
            <MenuItem primaryText="Double" insetChildren />
            <MenuItem
              primaryText="Custom: 1.2"
              checked
              rightIcon={<ArrowDropRight />}
              menuItems={[
                <MenuItem
                  primaryText="Show"
                  rightIcon={<ArrowDropRight />}
                  menuItems={[
                    <MenuItem primaryText="Show Level 2" />,
                    <MenuItem primaryText="Grid lines" checked />,
                    <MenuItem primaryText="Page breaks" insetChildren />,
                    <MenuItem primaryText="Rules" checked />
                  ]}
                />,
                <MenuItem primaryText="Grid lines" checked />,
                <MenuItem primaryText="Page breaks" insetChildren />,
                <MenuItem primaryText="Rules" checked />
              ]}
            />
            <Divider />
            <MenuItem primaryText="Add space before paragraph" />
            <MenuItem primaryText="Add space after paragraph" />
            <Divider />
            <MenuItem primaryText="Custom spacing..." />
          </Menu>
        </Paper>
      </div>

Click "Custom 1.2"
Click "Show"
Expected - 2nd lvl menu is still open, but it's not.

Your Environment

Tech
Version

Material-UI
0.20.0

React
16.2

browser
Safari / Chrome

etc

Maybe something is missing in #9058?

I discovered origin of this behavior.
0.19.4, Menu.js:
if (focusedItem.props.menuItems && focusedItem.props.menuItems.length > 0) {

this just throws error, because  focusedItem is null, and 2nd level menu is not closed.

0.20.4, Menu.js (same string):
if (!!focusedItem && focusedItem.props.menuItems && focusedItem.props.menuItems.length > 0) {

this check works now, but code fails later.

so both versions buggy in their own way, but generally it looks like this.getFilteredChildren() is not checking for null values passed as menuItems.
https://github.com/mui-org/material-ui/compare/v0.19.4...v0.20.0#diff-5b3a473e732de83aae9872a510887a2aR245

@neemah We have been porting the component on the v1-beta branch. We have reimplemented it from the ground-up.
We encourage people starting with Material-UI to go with v1-beta. The master branch is in a low maintenance mode. We don't plan any work on it. However, we still do our best to review and merge pull requests that fix bugs on this branch.


Modified exception import for heat backend

The placement of exceptions in the library has changes
goo.gl/hUnWM8.
Signed-off-by: Micu Matei-Marius<EMAIL_ADDRESS>

Tested. Works fine :)
LGTM


Refactor reqs

About this change - What it does
Create requests, response classes for different api calls
KwClusterModel , Response
UserInfoModel , Response
KafkaConnectorModel, Response
RegisterUserInfoModel, Response
few classes moved to requests/responses packages
Resolves: #1004
Why this way
With this, unused attributes are now deleted in request calls

Should the requestBody for saveConnectorDocumentation also be updated? It's currently still "#/components/schemas/KafkaConnectorModel" and as far as I can see also the only one still setting a ref to KafkaConnectorModel


Add support for perspective config

Adds support for configuring the client with optional perspective parameter.
https://www.sanity.io/blog/introducing-perspectives-sanity-previews
Allows controlling of whether or not draft content is returned in queries.
If the configuration parameter is not specified, then no perspective is set on the query and the behavior defaults to the same as raw.
Fixes #77

Thanks for submitting this and I apologize for taking so long to respond. Currently, perspectives are already fully supported via the query function like this:
Sanity.query("*", %{}, perspective: "published")
|> Sanity.request(request_opts)

The approach taken in this PR doesn't seem right to me because it involves passing the :perspective option to the request function instead of the query function. Since perspective only applies to queries I think it makes more sense to pass the option to the query function.
In retrospect, I wish I would have made the query function accept a single keyword list argument like:
Sanity.query(query: "*", variables: %{ ... }, perspective: "published")
|> Sanity.request(request_opts)

Perhaps this is the way to go. query/1 would take a single keyword list argument. query/1 with a string like Sanity.query("*") would be equivalent to Sanity.query(query: "*") for backwards compatibility. query/2 and query/3 would be kept for backwards compatibility but would be deprecated.
Please let me know if you have any thoughts about this.
Thanks again!

That's fine. I can pass the perspective as a query param 👍
Thanks for putting this library together. I'm using it as part of another library I'm writing to add support for Sanity to Ash: https://github.com/sbennett33/ash_sanity


ROX-17252: Attempt at temporary fixing data inconsistencies with Image / Image CVE search

Description
Not proud of this approach. It is just something to patch the leaks until we have a better solution.
image_cve_edges table joins images and image_cves tables. However, there is another way to join images and image_cves : images - image_component_edges - image_components - image_component_cve_edges - image_cves. Now whenever a search query includes fields from both image_cve_edges table and one of the component tables, the BFS based SQL query builder ends up building a query where image_cve_edges table is joined only on one of ImageId or ImageCveId but not the other field. This ends up in a situation where cves get mapped to wrong images.
Example:
Consider following data
images
-------
sha-1
sha-2

image_cves
------------
cve-1
cve-2

image_cve_edges
------------------
sha-1  |  cve-1  |  observed
sha-1  |  cve-2  |  deferred
sha-2  |  cve-1  |  observed
sha-2  |  cve-2  |  observed

image_components
--------------------
comp-1
comp-2

image_component_edges
--------------------------
sha-1   |   comp-1
sha-2   |   comp-2

image_component_cve_edges
-------------------------------
comp-1   |   cve-1   |  fixable
comp-1   |   cve-2  |  fixable
comp-2  |   cve-1   |  fixable
comp-2  |   cve-2  |  non-fixable

Now if we try to search for image_cves where image : sha-2 + Fixable : true + State: Observed, the query should return cve-1 . The search framework creates the following query
select distinct(image_cves.Id) as CVE_ID from
image_cves
inner join image_component_cve_edges on image_cves.Id = image_component_cve_edges.ImageCveId
inner join image_cve_edges on image_cves.Id = image_cve_edges.ImageCveId
inner join images on image_cve_edges.ImageId = images.Id
where (image_component_cve_edges.IsFixable = 't' and images.Id = 'sha-2' and (image_cve_edges.State = 'observed'))

Inner joined data before where clause is applied would look like below
------------------------------------------------
image_cves   |  image_component_cve_edges       |  image_cve_edges                     |  images
--------------|-----------------------------------|--------------------------------|------------
cve-1              |     comp-1  |  cve-1  |  fixable            |    sha-1  |  cve-1  |  observed      |   sha-1
cve-1              |     comp-1  |  cve-1  |  fixable            |    sha-2  |  cve-1  |  observed     |   sha-2
cve-1              |     comp-2  |  cve-1  |  fixable            |   sha-1  |  cve-1  |  observed      |   sha-1
cve-1              |     comp-2  |  cve-1  |  fixable            |   sha-2  |  cve-1  |  observed     |   sha-2
cve-2             |    comp-1  |  cve-2  |  fixable             |    sha-1  |  cve-2  |  deferred       |   sha-1
cve-2             |    comp-1  |  cve-2  |  fixable             |    sha-2  |  cve-2  |  observed     |   sha-2
cve-2             |    comp-2  |  cve-2  |  non-fixable     |    sha-1  |  cve-2  |  deferred      |   sha-1
cve-2             |    comp-2  |  cve-2  |  non-fixable     |    sha-2  |  cve-2  |  observed     |   sha-2

After applying the distinct(image_cves.Id)  and where clauses to this, we get both cve-1 and cve-2 . This happens because the query joined comp-1 with images sha-1 and sha-2 even though comp-1 is part of sha-1 only. Same for comp-2.
To avoid this type of issues, this PR changes the query builder to avoid using image_cve_edges table as long as possible. If the query must join image_cve_edges table, then we ensure that it is joined at last and joined on both ImageId and ImageCveId from the other joins. This will ensure that we do not have any unintended mapping. After the temporary fix in this PR, the SQL query looks like below
select distinct(image_cves.Id) as CVE_ID from
image_cves
inner join image_component_cve_edges on image_cves.Id = image_component_cve_edges.ImageCveId
inner join image_component_edges on image_component_cve_edges.ImageComponentId = image_component_edges.ImageComponentId
inner join images on image_component_edges.ImageId = images.Id
inner join image_cve_edges on(image_component_edges.ImageId = image_cve_edges.ImageId and image_cves.Id = image_cve_edges.ImageCveId)
where (image_component_cve_edges.IsFixable = 't' and images.Id = 'sha-2' and (image_cve_edges.State = 'observed'))

This query correctly returns cve-1
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Added unit tests
Manually tested to make sure everything looks good in UI
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

In essence the query framework just was not built for normalized data which makes sense as our data was not normalized at all prior to moving to Postgres.  I think it would need an overhaul to favor joins on multiple columns if possible instead of the first one it sees.  I had similar issues with compliance on the cluster_id since it is everywhere.  I was able to get around that by creating a deterministic ID specifically for joining.  That worked because compliance data was not normalized.  Such a scheme would be more difficult in this case.
All that said, some denormalizing to a certain extent may still be the correct long term solution to this specific problem.

...
where (image_component_cve_edges.IsFixable = 't' and images.Id = 'sha-2' and (image_cve_edges.State = 'observed'))

This query correctly returns `cve-2`

Did you mean to write "This query correctly returns only cve-1, because that was where the example started?

...
where (image_component_cve_edges.IsFixable = 't' and images.Id = 'sha-2' and (image_cve_edges.State = 'observed'))

This query correctly returns `cve-2`

Did you mean to write "This query correctly returns only cve-1, because that was where the example started?

Ah yes, good catch. I meant to write cve-1 there. Updated the description.

@charmik-redhat What do you think about putting this behind an env var so we can turn it off if we encounter problems with it later?

@charmik-redhat What do you think about putting this behind an env var so we can turn it off if we encounter problems with it later?

Good call. I put the changes behind an env var.

/test ocp-4-12-qa-e2e-tests


blankspace one

Clean up is being done here -> https://github.com/cloudflare/cloudflare-docs/pull/457


Assortment of fixes

Adds an additional program type 4 necessary for the washer-dryer (apparently identical to 3).
Handles 0 as program ID for dishwashers (similar to program phases).
Improves consistency of the German translation.
Marks the programTypesensor as diagnostic – there's not much information in there (as opposed to the programID).

We should have unified handling of tabs/indents or we will get lots of unnecessary changes.
I use vscode with Prettier installed. It does some basic reformatting when saving files.
My defaults are tab=4 spaces in python code, and tab=2 spaces in json files. Your editor seems to use tab characters in json files.
I don't know when all tabs sneaked in but they should be removed IMHO.

I am using Atom but I haven't really set up a additional defaults, so it should stick to what the file already was. There was an issue with the original commit for the JSON files I couldn't find at 3 in the morning, so I just used the pretty printer. I didn't realise it had changed the spaces to tabs, but I saw that there were whitespace changes. I'll change the JSON files back to tabs in this branch.

How about adding a prettier (and what other linters are useful for other file types) configuration to the repo?