Discrepancy between our XRD and vesta

For the same input
(base) qiangzhu@Qiangs-MacBook-Pro-2 XRD (master) $ python scripts/pxrd.py -c dataset/Acmm-POSCAR
  2theta     d_hkl     hkl       Intensity  Multi
  14.124     6.271   [ 0  0  2]    10.96        2
  15.486     5.722   [ 1  0  0]     4.73        2
  21.018     4.227   [ 1  0  2]     0.08        4
  23.089     3.852   [ 1  1  1]    50.54        8
  28.469     3.135   [ 0  0  4]    13.68        2
  30.747     2.908   [ 1  1  3]   100.00        8
  31.237     2.863   [ 0  2  0]    23.83        2
  31.264     2.861   [ 2  0  0]    20.41        2
  32.566     2.750   [ 1  0  4]     0.98        4

While the vesta output is

The intensity for [002] is very different.
@sayred1  please check what happened.

Thanks for the extra insight, I will begin looking into this.
On Mon, Feb 10, 2020 at 9:24 PM Qiang Zhu<EMAIL_ADDRESS>wrote:

For the same input
(base) qiangzhu@Qiangs-MacBook-Pro-2 XRD (master) $ python scripts/pxrd.py -c dataset/Acmm-POSCAR
2theta     d_hkl     hkl       Intensity  Multi
14.124     6.271   [ 0  0  2]    10.96        2
15.486     5.722   [ 1  0  0]     4.73        2
21.018     4.227   [ 1  0  2]     0.08        4
23.089     3.852   [ 1  1  1]    50.54        8
28.469     3.135   [ 0  0  4]    13.68        2
30.747     2.908   [ 1  1  3]   100.00        8
31.237     2.863   [ 0  2  0]    23.83        2
31.264     2.861   [ 2  0  0]    20.41        2
32.566     2.750   [ 1  0  4]     0.98        4
While the vesta output is
[image: image]
https://user-images.githubusercontent.com/29445366/74212894-6e98fe80-4c4b-11ea-9f3f-83ea96e04698.png
The intensity for [002] is very different.
@sayred1 https://github.com/sayred1 please check what happened.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/qzhu2017/XRD/issues/25?email_source=notifications&email_token=AIPGLD5VN2JCDGO6RXG4PTDRCIZANA5CNFSM4KS2RML2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMOPDGQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPGLD3OVLD2NQ4B3AXZW2LRCIZANANCNFSM4KS2RMLQ
.

@sayred1 I have fixed this issue. I don't know why you create a 3D array for hkl_index [26,1,3]. Now I did it with [26, 3]. The results are consistent now.
        hkl_index = np.array([[[-1,-1,-1]],[[-1,-1,0]],[[-1,-1,1]],[[-1,0,-1]],[[-1,0,0]],[[-1,0,1]],[[-1,1,-1]],[[-1,1,0]],[[-1,1,1]],
                     [[0,-1,-1]],[[0,-1,0]],[[0,-1,1]],[[0,0,-1]],[[0,0,1]],[[0,1,-1]],[[0,1,0]],[[0,1,1]],
                     [[1,-1,-1]],[[1,-1,0]],[[1,-1,1]],[[1,0,-1]],[[1,0,0]],[[1,0,1]],[[1,1,-1]],[[1,1,0]],[[1,1,1]]])

        for index in hkl_index:
            d = float(np.linalg.norm( np.dot(index, crystal.rec_matrix),axis = 1))

[[{'hkl': (1, 1, 1), 'multiplicity': 8}],
[{'hkl': (2, 0, 0), 'multiplicity': 6}],
[{'hkl': (2, 2, 0), 'multiplicity': 12}],
[{'hkl': (3, 1, 1), 'multiplicity': 24}],
[{'hkl': (2, 2, 2), 'multiplicity': 8}],
[{'hkl': (4, 0, 0), 'multiplicity': 6}],
[{'hkl': (3, 3, 1), 'multiplicity': 24}],
[{'hkl': (4, 2, 0), 'multiplicity': 24}],
[{'hkl': (4, 2, 2), 'multiplicity': 24}],
[{'hkl': (5, 1, 1), 'multiplicity': 24},
{'hkl': (3, 3, 3), 'multiplicity': 8}]]

@qzhu2017 There are several differences between our XRD calculations and VESTA, seen in the calculation of the structure factor.

Atomic scattering parameters
Scattering factor formula
Lorentz factor formula

The parameters and formulas above can be easily changed to match theirs, however changing these isn't sufficient enough to obtain the same structure factor as VESTA. I think we must also include the following, which they include:

Occupancies in structure factor
Debye-Waller factor

There's a bit of information here to show you, I'll stop by your office after I grab lunch.

So before using VESTA's functionality (with our original functions and atomic scattering parameters), here are the results (for NaCl):

compared to VESTA:

Now if I code in VESTA's functionality + the atomic scattering parameters + debye-waller factors (discussed https://tkawaguchi.com/debye-waller-factor/), our code gives:

It seems that the debye factor is working since the intensity and structure factor match better for higher angles. According to VESTA's manual (https://tkawaguchi.com/debye-waller-factor/ pg 111), the debye, lorentz, and occupancy factors are the only correction factors included, but I still seem to be missing something.

I figured out why we were getting weird results yesterday with changing 2theta values, this was due to the file we were using. The NaCl.cif and NaCl-POSCAR files in my repo had different unit cell parameters, and after testing the cif file, I get the original 2theta values we saw in the previous tables. Now, I am able to get very close to vesta's results.. So, for the NaCl.cif file with:
_cell_length_a                   5.64167
_cell_length_b                   5.64167
_cell_length_c                   5.64167

It's hard to tell if I'm still missing something with their structure factor calculation, since our formalism is exactly the same:
coeffs = [ [[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
        [[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
        [[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
        [[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
        [[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
        [[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
        [[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
        [[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]]
         ]

f0 = np.sum(coeffs[:, :5, 0] * np.exp(-coeffs[:, :5, 1] * s2), axis = 1) +  coeffs[:, 5, 0]
f1 = coeffs[:, 6, 0]
f2 = coeffs[:, 6, 1]
f_NT = coeffs[:, 7, 0]
sf =  f0 + f1 + 1j*f2 +f_NT

How about the other structure?
On Fri, Feb 14, 2020 at 6:14 PM Dean Lewis Sayre Jr. <
<EMAIL_ADDRESS>wrote:

I figured out why we were getting weird results yesterday with changing
2theta values, this was due to the file we were using. The NaCl.cif and
NaCl-POSCAR files in my repo had different unit cell parameters, and after
testing the cif file, I get the original 2theta values we saw in the
previous tables. Now, I am able to get very close to vesta's results.. So,
for the NaCl.cif file with:
_cell_length_a                   5.64167
_cell_length_b                   5.64167
_cell_length_c                   5.64167
[image: Screen Shot 2020-02-14 at 5 57 00 PM]
https://user-images.githubusercontent.com/35546511/74579908-6db9e280-4f53-11ea-9004-089530eb9271.png
It's hard to tell if I'm still missing something with their structure
factor calculation, since our formalism is exactly the same:
coeffs = [ [[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
[[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
[[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
[[4.910127, 3.281434],[3.081783, 9.119178],[1.262067, 0.102763],[1.098938,132.013942] ,[0.560991, 0.405878], [0.079712,0.0], [1.33491E-01,   1.23565E-01],[-2.88730E-03, 0]],
[[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
[[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
[[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]],
[[1.446071, 0.052357],[6.870609, 1.193165],[6.151801  ,18.343416],[1.750347,46.398394],[0.634168 ,0.401005],[0.146773,0.0], [3.56753E-01,   7.00107E-01], [-4.47180E-03, 0]]
]
f0 = np.sum(coeffs[:, :5, 0] * np.exp(-coeffs[:, :5, 1] * s2), axis = 1) +  coeffs[:, 5, 0]
f1 = coeffs[:, 6, 0]
f2 = coeffs[:, 6, 1]
f_NT = coeffs[:, 7, 0]
sf =  f0 + f1 + 1j*f2 +f_NT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/qzhu2017/XRD/issues/25?email_source=notifications&email_token=AHAUZ5ST4BQNXS46V2GLWJ3RC5FW5A5CNFSM4KS2RML2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL27DEQ#issuecomment-586543506,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHAUZ5VKE7C3X3TZPAZ7QPLRC5FW5ANCNFSM4KS2RMLQ
.

--
*Qiang Zhu, *Assistant Professor
4505 S. Maryland Parkway,
Room 232, Department of Physics and Astronomy,
University of Nevada Las Vegas
NV 89154-4002
Phone:<PHONE_NUMBER>
Fax:<PHONE_NUMBER>
Webpage: http://www.physics.unlv.edu/~qzhu
http://uspex.stonybrook.edu/qzhu.html

For the Acmm.cif structure, VESTA doesn't specify a  debye-waller parameter (U) for Pb, which denotes the mean-squared displacement of the atom. So, I just set this to 1.
I've attached the vesta file for comparison. I think that an assumption of 1 may be the reason why some of the values of |F| are off, but there is still close agreement.
Acmm.txt
(hkl)      2-theta        d        I      |F|     m
(0, 0, 2)   14.113   6.2705   100000  81.4859     2
(1, 0, 0)   15.473   5.7221    38799  55.5787     2
(1, 0, 2)   21.001  4.22674      798   7.6022     4
(1, 1, 1)    23.07  3.85215      364   3.9792     8
(0, 0, 4)   28.445  3.13525    21313  74.3586     2
(1, 1, 3)   30.721  2.90796    66860   70.811     8
(0, 2, 0)   31.211  2.86345     1317  20.1762     2
(2, 0, 0)   31.238  2.86105      807    15.81     2
(1, 0, 4)   32.539  2.74957       28   2.1779     4
(0, 2, 2)   34.403  2.60472    46630  92.9302     4
(2, 0, 2)   34.427  2.60291    44009   90.341     4
(1, 2, 0)   35.013  2.56072      911  13.2041     4
(2, 1, 1)   35.777  2.50774     1933  13.8724     8
(1, 2, 2)   37.923  2.37066      143   3.9847     8
(2, 1, 3)   41.329   2.1828     1696  14.8015     8
(1, 1, 5)   42.359  2.13207    12430  40.9511     8
(0, 2, 4)   42.732  2.11434       25   2.6656     4
(2, 0, 4)   42.752  2.11337       71   4.4289     4
(0, 0, 6)    43.25  2.09017        9   2.3481     2
(2, 2, 0)   44.741  2.02392    20626  78.2618     4
(1, 2, 4)   45.709  1.98328      595   9.5796     8
(1, 0, 6)   46.202  1.96329      296   9.6526     4
(2, 2, 2)   47.148  1.92607       59    3.098     8
(3, 0, 0)   47.639  1.90737      715   21.752     2
(3, 0, 2)   49.937  1.82481      656   15.327     4
(1, 3, 1)   50.908  1.79227     6843  35.5693     8
(2, 1, 5)   50.935   1.7914      800  12.1667     8
(3, 1, 1)   50.944  1.79109     5330  31.4089     8
(2, 2, 4)   53.874   1.7004    21569  66.1357     8
(0, 2, 6)   54.293  1.68824    11171  67.7331     4
(2, 0, 6)   54.311  1.68775    10508  65.7087     4
(1, 3, 3)   55.236  1.66165     5302   33.452     8
(3, 1, 3)    55.27  1.66071     4129  29.5381     8
(1, 1, 7)   56.093  1.63828     5033  32.9926     8
(3, 0, 4)   56.422  1.62951      803  18.7228     4
(1, 2, 6)   56.812  1.61924       51   3.3707     8
(3, 2, 0)   58.057  1.58743      418  13.8273     4
(2, 3, 1)   58.545  1.57537      512   10.884     8
(0, 0, 8)   58.862  1.56762     4219  62.7249     2
(3, 2, 2)   60.073  1.53889     1301  17.6877     8
(1, 0, 8)   61.259  1.51191       22   3.3026     4
(2, 3, 3)   62.518  1.48445      416  10.3121     8
(1, 3, 5)    63.29  1.46819     3441  29.8962     8
(2, 1, 7)   63.313  1.46772      400  10.2022     8
(3, 1, 5)   63.321  1.46755     2681  26.4011     8
(2, 2, 6)   63.982  1.45398       14   1.9307     8
(0, 4, 0)   65.098  1.43172     2974   56.728     2
(4, 0, 0)   65.159  1.43052     2305  49.9771     2
(3, 2, 4)   65.899  1.41625      585  12.6891     8
(3, 0, 6)   66.286  1.40891      287  12.6407     4
(0, 4, 2)    66.99   1.3958       19   3.2852     4
(4, 0, 2)   67.051  1.39469       30    4.131     4
(1, 4, 0)   67.367  1.38891       18   3.2547     4
(4, 1, 1)   67.891  1.37946     1144  18.1123     8
(0, 2, 8)   68.139  1.37505       19   3.3833     4
(2, 0, 8)   68.154  1.37478        7   2.1271     4
(1, 4, 2)   69.228  1.35604      137   6.3515     8
(2, 3, 5)   70.078  1.34167      292   9.3576     8
(3, 3, 1)   70.086  1.34154     1959  24.2139     8
(1, 2, 8)   70.359  1.33699      128   6.2214     8
(1, 1, 9)   71.555  1.31756     2357  26.9188     8
(4, 1, 3)   71.578  1.31718      973  17.3033     8
(0, 4, 4)   72.522  1.30236     4104  50.6615     4
(4, 0, 4)    72.58  1.30145     3165  44.5156     4
(3, 3, 3)   73.725  1.28405     1681  23.1673     8
(2, 4, 0)   73.973  1.28036        9   2.5197     4
(4, 2, 0)   74.016  1.27971       13   2.9609     4
(1, 3, 7)   74.432  1.27359     2094  26.0036     8
(3, 1, 7)   74.461  1.27317     1632  22.9653     8
(1, 4, 4)   74.687  1.26988       32   3.2362     8
(3, 2, 6)   75.082  1.26417      611  14.1244     8
(2, 4, 2)   75.764  1.25447     6645  46.8177     8
(0, 0, 10)   75.791   1.2541       11   3.9717     2
(4, 2, 2)   75.807  1.25387     5453  42.4284     8
(2, 2, 8)   76.857  1.23934     6333  46.0909     8
(1, 0, 10)   77.924  1.22502       43   5.4147     4
(2, 1, 9)   78.014  1.22382      212   8.5131     8
(4, 1, 5)   78.739  1.21437      733  15.9013     8
(3, 0, 8)   78.995  1.21108      257  13.3546     4
(2, 3, 7)   80.813  1.18835      191    8.246     8
(3, 3, 5)   80.821  1.18826     1283   21.338     8
(2, 4, 4)   81.062  1.18533       25   2.9835     8
(4, 2, 4)   81.104  1.18482       12   2.0839     8
(0, 4, 6)   81.406  1.18119       25   4.3018     4
(4, 0, 6)   81.462  1.18051        5   2.0481     4
(1, 4, 6)   83.501   1.1568       65    4.887     8
(0, 2, 10)   84.219  1.14876     2503  43.0237     4
(2, 0, 10)   84.233   1.1486     2344  41.6414     4
(3, 4, 0)   84.556  1.14503      205  12.3532     4
(5, 0, 0)   84.612  1.14442      194  16.9976     2
(4, 3, 1)   85.015  1.14003      589  14.8236     8
(3, 4, 2)   86.291  1.12641      300   10.653     8
(1, 2, 10)   86.303  1.12628       27   3.2346     8
(5, 0, 2)   86.347  1.12582      434  18.1433     4
(1, 5, 1)    87.04  1.11862     1334  22.5531     8
(5, 1, 1)   87.124  1.11777      586  14.9608     8
(3, 2, 8)   87.354  1.11542      292  10.5681     8
(1, 3, 9)   88.457  1.10434     1276  22.2129     8
(4, 3, 3)   88.479  1.10411      527   14.279     8
(3, 1, 9)   88.485  1.10406      995  19.6184     8
(1, 1, 11)   89.165  1.09739     1249  22.0461     8
(4, 1, 7)   89.187  1.09718      516  14.1718     8
(2, 4, 6)   89.744   1.0918     3845  38.7773     8
(4, 2, 6)   89.786   1.0914     3136  35.0246     8
(1, 5, 3)     90.5  1.08464     1200  21.7366     8
(5, 1, 3)   90.584  1.08386      527  14.4195     8
(3, 3, 7)   91.236   1.0778      916  19.0555     8
(3, 4, 4)   91.481  1.07555      318  11.2416     8
(5, 0, 4)   91.537  1.07504      322  16.0107     4
(2, 2, 10)   92.536  1.06603       30   3.4748     8
(5, 2, 0)   92.914  1.06269      348  16.7104     4
(2, 5, 1)   93.273  1.05953      129   7.2087     8
(0, 4, 8)   93.545  1.05717     1814  38.2451     4
(4, 0, 8)   93.601  1.05669     1382  33.3892     4
(3, 0, 10)   94.631  1.04788      123  10.0216     4
(5, 2, 2)   94.647  1.04775      599  15.6015     8
(2, 3, 9)   94.692  1.04737      124   7.1041     8
(0, 0, 12)   94.964  1.04508      868  37.6016     2
(2, 1, 11)   95.402  1.04144      121   7.0527     8
(4, 3, 5)   95.404  1.04142      432  13.2831     8
(1, 4, 8)   95.629  1.03958       25   3.2259     8
(2, 5, 3)   96.746  1.03052      117    6.957     8
(1, 0, 12)   97.053  1.02808       12   3.2231     4
(1, 5, 5)   97.438  1.02503      991  20.2371     8
(5, 1, 5)   97.522  1.02437      436  13.4252     8
(4, 4, 0)   99.139  1.01196     1172   31.255     4
(5, 2, 4)   99.878  1.00645      564  15.3645     8
(3, 4, 6)  100.181  1.00422      222   9.6402     8
(5, 0, 6)  100.238  1.00381      279  15.2995     4
(4, 4, 2)  100.895  0.99903        3   1.1565     8
(2, 4, 8)  101.936  0.99164       31   3.6257     8
(4, 2, 8)  101.978  0.99134        3   1.1488     8
(3, 2, 10)   103.03  0.98406      221   9.6757     8
(4, 1, 9)  103.136  0.98334      357     12.3     8
(0, 2, 12)  103.372  0.98174       26   4.7187     4
(2, 0, 12)  103.386  0.98164       15   3.6325     4
(2, 5, 5)   103.78  0.97899       99   6.4901     8
(3, 5, 1)  103.787  0.97894      665  16.7943     8
(5, 3, 1)  103.845  0.97856      375  12.6147     8
(3, 3, 9)  105.249  0.96932      645  16.5607     8
(1, 2, 12)  105.516   0.9676       25   3.2801     8
(1, 3, 11)  105.955   0.9648      814    18.62     8
(4, 3, 7)  105.978  0.96465      336  11.9696     8
(3, 1, 11)  105.984  0.96462      635  16.4454     8
(4, 4, 4)  106.234  0.96304     1960  28.8856     8
(3, 5, 3)  107.379  0.95592      618  16.2307     8
(5, 3, 3)  107.437  0.95556      348  12.1914     8
(0, 6, 0)  107.613  0.95448       12    4.678     2
(6, 0, 0)  107.745  0.95368       12   4.5809     2
(1, 5, 7)  108.092  0.95158      781  18.2496     8
(5, 1, 7)   108.18  0.95105      343  12.1071     8
(5, 2, 6)  108.812  0.94729      456  13.9591     8
(0, 6, 2)  109.437  0.94361     1205  32.0714     4
(0, 4, 10)  109.479  0.94337       25   4.6523     4
(4, 0, 10)  109.539  0.94303        1   1.1316     4
(6, 0, 2)   109.57  0.94284      629  23.1838     4
(1, 6, 0)  109.806  0.94148       10   3.0431     4
(1, 1, 13)   110.34  0.93841      749  17.8747     8
(6, 1, 1)  110.396  0.93809      565  15.5367     8
(1, 6, 2)  111.655  0.93104       23   3.1724     8
(1, 4, 10)  111.698   0.9308       20   2.9455     8
(2, 2, 12)  112.101  0.92859     2140  30.1931     8
(2, 3, 11)  112.558  0.92612       84   5.9808     8
(3, 4, 8)  112.832  0.92464      173   8.5908     8
(5, 0, 8)  112.892  0.92432      215  13.5475     4
(6, 1, 3)  114.134  0.91778      531  15.0232     8
(3, 0, 12)  114.376  0.91652       83   8.4382     4
(2, 5, 7)  114.789  0.91441       81   5.8635     8
(3, 5, 5)  114.797  0.91436      543   15.173     8
(5, 3, 5)  114.859  0.91405      306   11.397     8
(0, 6, 4)  115.044  0.91311       24   4.5535     4
(6, 0, 4)  115.183  0.91241       19   4.1061     4
(4, 4, 6)  115.497  0.91082        3   1.1311     8
(2, 6, 0)  116.588  0.90543      992  28.9297     4
(6, 2, 0)  116.712  0.90482      553  21.5959     4
(2, 1, 13)   117.15   0.9027       78   5.7446     8
(1, 6, 4)  117.359   0.9017       17   2.6768     8
(2, 6, 2)  118.539  0.89613       29   3.5261     8
(2, 4, 10)  118.584  0.89592     1928   28.408     8
(0, 0, 14)  118.613  0.89579       11   4.4771     2
(4, 2, 10)  118.631   0.8957     1562  25.5642     8
(6, 2, 2)  118.665  0.89554       36   3.9274     8
(5, 4, 0)  119.014  0.89393      201  12.9789     4
(4, 5, 1)  119.474  0.89184      270  10.6089     8

I'm going to check another structure from the web-site for more validation.

@sayred1 The output intensity for 002 is 45.0527 from VESTA, |F|=159.33.
Why did you say the agreement is close?
Also, please try to focus on one thing at a time from now on! I don't quite understand why this simple task takes such long time. And it seems that you are not quite clear what you are supposed to do. Please consider this is your own project, but not an assignment from someone else.

I apologize, I should've been more specific here. In regards to the close agreement, I meant to link the output file as opposed to the input file:
Allow me to restart on another footing here. Previously as I mentioned, U for Pb was set to 1 since VESTA's output file didn't show a value. The following results were what you saw, disagreement between our output and theirs. However, in the VESTA console where we obtain the values for f', f'', and f_NT, VESTA gives a value for U = 1.349. Using this, instead of 1, we see better agreement.
With some exceptions (like a few of the first ten planes listed in the output file) there is pretty good agreement between our computed and Vesta's computed |F| values.
Acmm copy.txt
Then I wanted to check another structure for further validation, but didn't see much agreement.
The structure I checked now (space group Abmm), has a value U which is the same for all atomic species, which doesn't make sense to me according to here.
For our simulations, here are the results, compared to Abmm copy.txt
:
(0, 0, 2)     15.438    5.735    37742  50.6843     2
(1, 0, 0)     22.319     3.98    46190  80.3926     2
(0, 2, 0)     23.485    3.785   100000 124.2542     2
(1, 1, 1)     26.446  3.36753    40728  44.4369     8
(1, 0, 2)     27.252  3.26976    49739  71.4643     4
(0, 2, 2)     28.227  3.15902    55727  78.2136     4
(0, 0, 4)     31.166   2.8675     1724  21.3623     2
(1, 2, 0)     32.622  2.74275    87733  112.443     4
(1, 1, 3)     34.594  2.59073    35017   53.041     8
(1, 2, 2)     36.277  2.47434     9526  28.8982     8
(1, 0, 4)      38.67  2.32655     3697  26.9836     4
(0, 2, 4)      39.39  2.28564    17583  59.8289     4
(1, 3, 1)      43.14  2.09526    15611  43.2175     8
(2, 0, 0)     45.546     1.99      496   16.155     2
(1, 2, 4)     45.739  1.98205      241   5.6573     8
(1, 1, 5)     47.245  1.92234    33773  68.7695     8
(0, 0, 6)     47.525  1.91167      106   7.7671     2
(2, 1, 1)     47.886  1.89808    10290  38.3976     8
(0, 4, 0)     48.036   1.8925    26795 124.2501     2
(2, 0, 2)     48.375  1.88003      428  11.1825     4
(1, 3, 3)     48.889  1.86147    11681  41.6331     8
(0, 4, 2)     50.759  1.79718     2764  29.5569     4
(2, 2, 0)     51.866  1.76139      255   9.1523     4
(1, 0, 6)     53.105   1.7232     2090  26.6684     4
(2, 1, 3)     53.242  1.71909    16885  53.7115     8
(1, 4, 0)     53.577  1.70912    11252  62.3233     4
(0, 2, 6)      53.67  1.70638      670  15.2292     4
(2, 2, 2)      54.45  1.68377     7778  37.1207     8
(1, 4, 2)     56.106  1.63793    12868  48.8951     8
(2, 0, 4)      56.22  1.63488    10237  61.7744     4
(0, 4, 4)     58.376  1.57951     1774  26.4805     4
(1, 2, 6)     58.834  1.56831       58   3.4349     8
(1, 3, 5)     59.123  1.56134    16993  58.5187     8
(2, 3, 1)     59.673  1.54825     5193  32.5802     8
(2, 2, 4)      61.76  1.50086     6925  38.6041     8
(1, 1, 7)     62.459  1.48572      275   7.7608     8
(2, 1, 5)     62.992  1.47443    23207  71.7012     8
(1, 4, 4)     63.294  1.46812     1421  17.8051     8
(2, 3, 3)     64.356  1.44642    10845  49.7806     8
(0, 0, 8)     64.995  1.43375    10126  96.8842     2
(1, 5, 1)     66.525  1.40443     4547  32.9984     8
(2, 0, 6)     67.938  1.37861     1119  23.4925     4
(2, 4, 0)     68.347  1.37137      329  12.7987     4
(1, 0, 8)     69.648  1.34889     4653  48.6994     4
(0, 4, 6)     69.883  1.34492      110   7.5077     4
(0, 2, 8)     70.131  1.34078    10257   72.631     4
(2, 4, 2)     70.554  1.33377      654  13.0259     8
(1, 5, 3)     70.963  1.32709     4731  35.1516     8
(3, 0, 0)     70.989  1.32667     2303  49.0595     2
(1, 3, 7)      72.74  1.29899      281   8.7173     8
(3, 1, 1)     72.781  1.29835      205   7.4494     8
(2, 2, 6)     72.976  1.29536     6248  41.1192     8
(3, 0, 2)     73.162  1.29253      778  20.5549     4
(2, 3, 5)     73.235  1.29143    16343  66.6508     8
(1, 4, 6)     74.394  1.27414     1578  20.9134     8
(1, 2, 8)     74.636  1.27062    14857  64.2924     8
(0, 6, 0)     75.257  1.26167     5645  79.6605     2
(3, 2, 0)     75.941  1.25199     1731  31.3669     4
(2, 1, 7)     76.253  1.24764       49   3.7495     8
(2, 4, 4)     77.017  1.23717     9168  51.4514     8
(3, 1, 3)     77.064  1.23652     2505  26.9052     8
(0, 6, 2)     77.385   1.2322     3221  43.2484     4
(3, 2, 2)     78.063  1.22318       22   2.5418     8
(1, 5, 5)     79.522  1.20437     8369  50.0509     8
(3, 0, 4)     79.547  1.20405     7173  65.5444     4
(1, 6, 0)     79.655  1.20268     7307  66.2001     4
(1, 1, 9)     79.995  1.19843     5323  40.0464     8
(2, 5, 1)     80.003  1.19833     2643  28.2226     8
(1, 6, 2)      81.75  1.17708     1478  21.3495     8
(3, 3, 1)      82.51  1.16815      173   7.3405     8
(2, 0, 8)     82.933  1.16327      230   12.006     4
(0, 6, 4)     83.675  1.15483     2133  36.6963     4
(2, 5, 3)     84.178   1.1492     5478  41.6966     8
(3, 2, 4)     84.342  1.14739    18806  77.3274     8
(0, 0, 10)     84.377    1.147     2311  54.2309     2
(0, 4, 8)     84.758  1.14282     9888  79.4834     4
(3, 1, 5)     85.438  1.13545     2847  30.2725     8
(2, 3, 7)     85.873  1.13081       26   2.9372     8
(3, 3, 3)     86.664  1.12251     1976  25.3883     8
(2, 4, 6)     87.463   1.1143     1469  21.9788     8
(2, 2, 8)     87.696  1.11194       19   2.5385     8
(1, 6, 4)      87.98  1.10908        5   1.3146     8
(1, 0, 10)     88.679  1.10214     3750  49.9421     4
(1, 4, 8)     89.058  1.09843     5535  42.9779     8
(0, 2, 10)     89.133   1.0977     6436  65.5665     4
(1, 3, 9)     89.538  1.09378     4404  38.4203     8
(3, 0, 6)     89.942  1.08992     3043  45.2455     4
(3, 4, 0)      90.32  1.08633     2761   43.173     4
(1, 5, 7)     91.984  1.07098      148   7.1284     8
(3, 4, 2)     92.388  1.06735      697  15.4716     8
(2, 5, 5)     92.458  1.06673     9539  57.2296     8
(2, 6, 0)      92.59  1.06556       42   5.4138     4
(2, 1, 9)     92.924   1.0626     4187  37.9849     8
(1, 2, 10)     93.427  1.05819     3559   35.087     8
(0, 6, 6)     94.028  1.05301      105   8.5492     4
(2, 6, 2)     94.661  1.04763     1583  23.5002     8
(3, 2, 6)     94.693  1.04736     2574  29.9657     8
(3, 3, 5)     94.941  1.04528     2334  28.5593     8
(1, 7, 1)     95.662   1.0393     1934  26.0606     8
(3, 1, 7)     97.872  1.02165      389  11.7725     8
(1, 6, 6)     98.347  1.01798       30   3.3116     8
(3, 4, 4)     98.622  1.01587     9037  56.7851     8
(1, 7, 3)     99.836  1.00676     2346  29.0178     8
(1, 1, 11)    100.782  0.99985      134   6.9675     8
(2, 6, 4)    100.924  0.99883     2375   29.256     8
(4, 0, 0)    101.459    0.995      329  21.8314     2
(3, 5, 1)    101.595  0.99404       90   5.7291     8
(2, 0, 10)    101.636  0.99375        3   1.5198     4
(2, 4, 8)    102.023  0.99103      284  10.1509     8
(2, 3, 9)    102.515  0.98761     3497  35.6017     8
(4, 1, 1)    103.203  0.98289     5147  43.2353     8
(0, 4, 10)    103.495   0.9809     3012  46.7904     4
(4, 0, 2)    103.577  0.98035        1   0.9127     4
(3, 0, 8)    104.569  0.97375     1380  31.7222     4
(2, 5, 7)    105.033  0.97072       29   3.2736     8
(3, 5, 3)    105.852  0.96546     1296  21.7589     8
(4, 2, 0)     106.35   0.9623     1504  33.1647     4
(2, 2, 10)    106.531  0.96117      462  13.0041     8
(0, 0, 12)    107.393  0.95583       28   6.4823     2
(4, 1, 3)    107.491  0.95523        4   1.3456     8
(3, 3, 7)    107.615  0.95447      337  11.1129     8
(1, 4, 10)    107.956  0.95241     5159   43.466     8
(1, 7, 5)     108.37  0.94992     4774  41.8162     8
(4, 2, 2)    108.517  0.94904      309  10.6547     8
(0, 6, 8)    108.833  0.94716     4317  56.2434     4
(1, 5, 9)    108.861  0.94699     3172  34.0921     8
(2, 7, 1)     108.87  0.94694     1624  24.3985     8
(0, 8, 0)    108.987  0.94625     3820  74.8235     2
(3, 4, 6)    109.288  0.94448     4054  38.5428     8
(3, 2, 8)    109.535  0.94305     1096  20.0463     8
(4, 0, 4)    110.059  0.94002     3557  51.0545     4
(1, 3, 11)    110.655  0.93662       96   5.9459     8
(0, 8, 2)    111.189  0.93363      618  21.2762     4
(2, 6, 6)     111.71  0.93074     2343  29.2828     8
(1, 0, 12)    111.952  0.92941       35    5.098     4
(0, 2, 12)    112.442  0.92674      445  18.0558     4
(4, 3, 1)    113.208  0.92264     4393  40.0555     8
(2, 7, 3)    113.302  0.92214     3179  34.0702     8
(1, 6, 8)    113.436  0.92143     6191  47.5425     8
(1, 8, 0)    113.596  0.92059     2254  40.5674     4
(2, 1, 11)     114.32  0.91682      322  10.8388     8
(3, 5, 5)    114.675  0.91499     1688  24.7922     8
(3, 6, 0)     114.82  0.91425      952  26.3372     4
(3, 1, 9)    115.189  0.91238       11   2.0654     8
(4, 2, 4)    115.203   0.9123     4110  38.6576     8
(1, 8, 2)    115.872  0.90895     2113  27.6923     8
(4, 1, 5)    116.416  0.90627      305  10.5174     8
(3, 6, 2)     117.12  0.90285       13   2.2002     8
(1, 2, 12)    117.172  0.90259       97   5.9298     8
(4, 3, 3)     117.79  0.89965        3   1.0429     8
(0, 8, 4)    118.014  0.89859      565  20.1913     4

The unfortunate thing about Abmm is that VESTA doesn't list values for U in the vesta console as it was listed for Acmm.
We are using the exact same atomic-scattering factor function and scattering parameters, debye-waller correction function, and the same lorentz polarization factor function. I believe that the only possible difference is the value U, I don't think that VESTA uses the values reported in their output file, just because of the oddity I observed in the Acmm structure. To restate it, VESTA's output file does not list a value U for one of the atoms, but the VESTA console does list a value that gives us okay agreement.


JSON editor too complicated?

Methods to simplify:
Hide fields, ...

How was this resolved?

I hid the fields (asides uuid). Mostly: I think this issue isn't specific enough. More created for documentation purposes

Until this is resolved, I think this should remain open.  Perhaps it can act as a common point to link to issues that implement features that aim to address this overarching issue.


hello_sdl demo minor fixes

Minor fixes around hello_sdl demo.

Sorry, I think i mixed this pull request with my previous ones... dummy here!. Trying to see how can I do it correctly.

It's OK, it will be fine once I merge the other ones. Worst case I can cherry-pick I'm sure.

After applied all the commits inside this PR, a new segfault issue could appears randomly. To replicate it, it's enough modify hello_sdl source demo in the following way:
init() ->
ok = sdl:start([video]),
ok = sdl:stop_on_exit(),
{ok, Window} = sdl_window:create("Hello SDL", 10, 10, 500, 500, []),
{ok, Renderer} = sdl_renderer:create(Window, -1, [accelerated, present_vsync]),
loop(#{window=>Window}).
loop(State) ->
events_loop(),
loop(State).
In OSX it segfaults most of the times in dtor_Renderer function, when invoking enif_release_resource(...); in Windows it's more difficult to replicate, although it happens if you retry it enough times. With some printf debugging it seems that resource pointer to Renderer gets corrupted randomly, most of the times after SDL_DestroyRenderer call, but less frequently call to NIF_GET_RES before SDL_DestroyRenderer already shows an invalid pointer.
Funny thing, is that if we avoid invoking loop(#{XXXX}) inside init() function in hello_sdl, this doesn't happens. In some way sdl_events:poll or loop seems to be causing this issue.
I'll open a new issue if commits are finally merged due to the differences how dtor_XXX works in current master brach (although i'll bet it should be suffering the same issue).


avoidOptionals doesnt seem to work propperly

After upgrading from version 0.12.5 to 0.14.1 I have some issues with optional properties on fragments.
According to the documentation the config option avoidOptionals is set to false by default, and iv also tried to set it to both true and false explicitly to view the difference. The example in the docs shows this.
type A { myField: String } will output myField: string | null instead of myField?: string | null.
But it doesn't for me...
This is the current fragment that is generated
export namespace ClientFragment {
  export type Fragment = {
    __typename?: "Client";
    id: string;
    name: string;
    description: string | null;
    documentIdCounter: number;
    createdDate: DateTimeOffset | null;
    updatedDate: DateTimeOffset | null;
  };
}

This is how it used to be before upgrading to the new version with new config file etc.
export namespace ClientFragment {
  export type Fragment = {
    __typename?: "Client";
    id: string;
    name: string;
    description?: string | null;
    documentIdCounter: number;
    createdDate?: DateTimeOffset | null;
    updatedDate?: DateTimeOffset | null;
  };
}

here is the definition from schema.json and it looks exactly the same for both generated code fragments.
{
        "kind": "OBJECT",
        "name": "Client",
        "description": null,
        "fields": [
          {
            "name": "createdById",
            "description": "The User who made the API request resulting in the creation of the entity",
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "ID",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "createdDate",
            "description": "When the entity was created",
            "args": [],
            "type": {
              "kind": "SCALAR",
              "name": "DateTimeOffset",
              "ofType": null
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "description",
            "description": null,
            "args": [],
            "type": {
              "kind": "SCALAR",
              "name": "String",
              "ofType": null
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "documentIdCounter",
            "description": null,
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "Int",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "id",
            "description": "This is the primary key",
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "ID",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "isPrimaryClient",
            "description": "Identifies the client as a tenant's primary client. Only one client may be primary client per tenant.",
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "Boolean",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "name",
            "description": null,
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "String",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "updatedById",
            "description": "The User who made the API request resulting in the update of the entity",
            "args": [],
            "type": {
              "kind": "NON_NULL",
              "name": null,
              "ofType": {
                "kind": "SCALAR",
                "name": "ID",
                "ofType": null
              }
            },
            "isDeprecated": false,
            "deprecationReason": null
          },
          {
            "name": "updatedDate",
            "description": "When the entity was last updated",
            "args": [],
            "type": {
              "kind": "SCALAR",
              "name": "DateTimeOffset",
              "ofType": null
            },
            "isDeprecated": false,
            "deprecationReason": null
          }
        ],
        "inputFields": null,
        "interfaces": [],
        "enumValues": null,
        "possibleTypes": null
}

Hi @furier
We changed the behavior, and now on typescript-client it will always generate non-optional. The reason is - if you ask for a specific field in a query or a fragment, the graphql engine will return this fill always, so there is no way it will optional.
Currently, avoidOptionals effects only typescript-server and they way it generates type fields.
Does this effect you in a way?

It just means I need to fix a bunch of code to have the no longer optional fields. :P But I thought it might be a bug since It didn't use to be like that and got confused when reading the docs thinking it should behave as I expected.

Sorry for the breaking changes :D we really try to avoid it :)


Error on transitioning issue: TypeError: opts.fields.forEach is not a function

Hi,
Trying to transition an issue to be resolved as invalid.
This is my testcode where issue is the issue key:
ID 5 is "Resolve"
function resolve_invalid(issue) {
    jira.issue.transitionIssue({
        issueKey:   issue,
        transition: {id: '5'},
        fields: {resolution: {name: 'Invalid'}}
    }, function (error, data) {
        console.log(error);
        console.log(data);
    });
}

Error without the fields is 'Missing 'transition' identifier'
According to the Jira REST API, the fields object is supported.
Example:
{
    "update": {
        "comment": [
            {
                "add": {
                    "body": "Bug has been fixed."
                }
            }
        ]
    },
    "fields": {
        "assignee": {
            "name": "bob"
        },
        "resolution": {
            "name": "Fixed"
        }
    },
    "transition": {
        "id": "5"
    },
    "historyMetadata": {
        "type": "myplugin:type",
        "description": "text description",
        "descriptionKey": "plugin.changereason.i18.key",
        "activityDescription": "text description",
        "activityDescriptionKey": "plugin.activity.i18.key",
        "actor": {
            "id": "tony",
            "displayName": "Tony",
            "type": "mysystem-user",
            "avatarUrl": "http://mysystem/avatar/tony.jpg",
            "url": "http://mysystem/users/tony"
        },
        "generator": {
            "id": "mysystem-1",
            "type": "mysystem-application"
        },
        "cause": {
            "id": "myevent",
            "type": "mysystem-event"
        },
        "extraData": {
            "keyvalue": "extra data",
            "goes": "here"
        }
    }
}

Stacktrace:
TypeError: opts.fields.forEach is not a function
    at IssueClient.buildRequestOptions (c:\Users\muste\WebstormProjects\arise\node_modules\jira-connector\api\issue.js:981:25)
    at IssueClient.transitionIssue (c:\Users\muste\WebstormProjects\arise\node_modules\jira-connector\api\issue.js:580:28)

Added stacktrace to the bottom.

Seems like that's actually for the fields filter (used in search).
This fixed it:
'''
function resolve_invalid(issue) {
jira.issue.transitionIssue({
issueKey:   issue,
transition: {
transition: {id: 5},
fields: {resolution: {name: 'Invalid'}},
update: {comment:[ { add: {body: "Comment."}}]}
}
}, function (error, data) {
console.log(error);
console.log(data);
});
}
'''


Echart's height is not responsive. PLZ HELP ASAP

What problem does this feature solve?
I need my charts height to be responsive:
Hello, I need help the heights in the charts is not responsive, while the width is responsive. PLZ IS NEED HELP ASAP
This is my chart options:
this.options = {
xAxis: {
type: 'category',
data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
},
yAxis: {
type: 'value'
},
series: [{
data: [150, 230, 224, 218, 135, 147, 260],
type: 'line'
}]
};
and this is my html code:

What does the proposed API look like?
I really dont know how to fix it plz i need it to be fixed asap

I can not because I am using angular so I am using typescript not javascript

Can I know what layout are you using in ECharts' container? flex or grid?

@plainheart I am not using any layout I uploaded my code.
I guess it is using the default one. If I specify display flex the chart does not load.

Is it possible to provide some screenshots to let us know the unexpected result and expected result?

@plainheart
this is the unexpected result:

this is the expected result:

I need it to be responsive

I guess the grid option may work for you. Just to set grid.left, grid.right, grid.top and grid.bottom.

@plainheart what values should I give for grid.left, grid.right, grid.top, grid.bottom? and should I set the display grid ? display: grid?

what values should I give for grid.left, grid.right, grid.top, grid.bottom?

Try to set them as 0.

should I set the display grid ? display: grid?

No.

@plainheart Should i change them in the scss file or where?

No. They are options of ECharts.

Just like this,
this.options = {
    grid: {
        top: 0,
        bottom: 0,
        left: 0,
        right: 0,
        containLabel: true
    },
    xAxis: {
        type: 'category',
        data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
    },
    yAxis: {
        type: 'value'
    },
    series: [{
        data: [150, 230, 224, 218, 135, 147, 260],
        type: 'line'
    }]
};

@plainheart I tried it it did not work :(
horizontally it is responsive but vertically it is not it is taking the default height

I'm afraid I have to try your demo to provide further help for you.

Does chart.resize() work for you?

where should i place chart.resize ?

This is up to your code.
There is a hint we can read from the document,

Please check if you are in this case.

So, is there any latest progress? I encountered the same problem.


create slash help command

this will instruct the user on how to input time in order for it to be translated

created first version of slash command.
please make revisions or recommend revisions to be made

REMEMBER to add slash command to api.slack.com when merging to production

added /kronos help command


Another big upstream merge

Closes
Code Changes

[x] merge in ctl BE changes
[x] merge in ctl FE changes
[x] alembic migration merge for ctl
[ ] merge in ops BE changes
[ ] merge in ops FE changes
[ ] alembic migration merge for ops
[x] default redis and worker enabled to False

Steps to Confirm

[ ] all automated checks pass

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

Description Of Changes
Another upstream merge of ops/ctl into unified-fides

running into a weird error with an import during npm run build that isn't happening for me locally. Trying to troubleshoot what might be going on

as of this commit, the webserver is working again albeit with weird "redis unreachable" error logs, even though I've disabled redis

I've definitely discovered intermittent failures with the mongo tests for ops as well

all safe pytest checks passing 👍


refactor bilevel planner to use search utilities functions

note: this is bad for several reasons, see #1019


fix #107

fixes #107

I've grant you write access on the project:  https://github.com/garronej/tss-react/invitations


✨ Create Content-Development Page HTML file #12

Description
Added content to page.
Reference the issue related to this PR as shown below.
(https://github.com/italanta/elewa-website-html/issues/79).
Fixes #12
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Closing pr as issue is closed


snakebite.errors.RequestError: javax.security.sasl.SaslException Client mechanism is malformed

Related-To: https://github.com/spotify/snakebite/issues/175
I am trying to get snakebite to work (for Airflow) in a container environment and having a few issues.  I removed Airflow (target client) from the picture and created this basic script to test things out
$ cat check_snakebite.py
from snakebite.client import Client, AutoConfigClient, HAClient, Namenode

c = HAClient([Namenode('host1', 8020), Namenode('host2', 8020)],
<EMAIL_ADDRESS><EMAIL_ADDRESS>        use_sasl=True)

for x in c.ls(['/']):
  print x

I have two clusters I am testing out; a hadoop cluster I created, and one created by CDH.  When I run the above script on a physical node (host portion of principle matches hostname), it works just fine against my test cluster.  When I move the script into a docker container and call the CDH cluster, I get the below exception.  Since this is in Docker, the hostname doesn't match principle (nor do I have permissions to fix the hostname).
From the same host, using the hadoop libraries work fine, and so does code we have written in java. Its only when I try to use snakebite that this fails.
Thanks for your time reading this issue
bash-4.3$ python check_snakebite.py
Traceback (most recent call last):
  File "check_snakebite.py", line 8, in <module>
    for x in c.ls(['/']):
  File "/python/lib/python2.7/site-packages/snakebite/client.py", line 1542, in wrapped
    self.__handle_request_error(e)
  File "/python/lib/python2.7/site-packages/snakebite/client.py", line 1540, in wrapped
    yield results.next()
  File "/python/lib/python2.7/site-packages/snakebite/client.py", line 168, in ls
    recurse=recurse):
  File "/python/lib/python2.7/site-packages/snakebite/client.py", line 1214, in _find_items
    fileinfo = self._get_file_info(path)
  File "/python/lib/python2.7/site-packages/snakebite/client.py", line 1342, in _get_file_info
    return self.service.getFileInfo(request)
  File "/python/lib/python2.7/site-packages/snakebite/service.py", line 40, in <lambda>
    rpc = lambda request, service=self, method=method.name: service.call(service_stub_class.__dict__[method], request)
  File "/python/lib/python2.7/site-packages/snakebite/service.py", line 46, in call
    return method(self.service, controller, request)
  File "/python/lib/python2.7/site-packages/google/protobuf/service_reflection.py", line 267, in <lambda>
    self._StubMethod(inst, method, rpc_controller, request, callback))
  File "/python/lib/python2.7/site-packages/google/protobuf/service_reflection.py", line 284, in _StubMethod
    method_descriptor.output_type._concrete_class, callback)
  File "/python/lib/python2.7/site-packages/snakebite/channel.py", line 442, in CallMethod
    self.get_connection(self.host, self.port)
  File "/python/lib/python2.7/site-packages/snakebite/channel.py", line 248, in get_connection
    sasl_connected = sasl.connect()
  File "/python/lib/python2.7/site-packages/snakebite/rpc_sasl.py", line 98, in connect
    res = self._recv_sasl_message()
  File "/python/lib/python2.7/site-packages/snakebite/rpc_sasl.py", line 79, in _recv_sasl_message
    sasl_response = self._trans.parse_response(bytestream, RpcSaslProto)
  File "/python/lib/python2.7/site-packages/snakebite/channel.py", line 418, in parse_response
    self.handle_error(header)
  File "/python/lib/python2.7/site-packages/snakebite/channel.py", line 421, in handle_error
    raise RequestError("\n".join([header.exceptionClassName, header.errorMsg]))
snakebite.errors.RequestError: javax.security.sasl.SaslException
Client mechanism is malformed

$ pip freeze | grep python-krbV
python-krbV==1.0.90
$ pip freeze | grep snake
snakebite==2.11.0

Run snakebite in debug mode:
DEBUG:snakebite.rpc_sasl:Available mechs: DIGEST-MD5,GSSAPI
DEBUG:snakebite.rpc_sasl:Chosen mech:
Empty "Chosen mech".
https://github.com/spotify/snakebite/issues/175#issuecomment-237251283

I was having the same problem as in the OP and for me the actual problem turned out to be missing the cyrus-sasl-md5 and(/or?) cyrus-sasl-gssapi packages. Installing these packages solved it.


Shapes outside popupmenubutton

I would like to draw the shapers inside a container and not in a popupmenu. Would it be possible to do this, do you have an example?
Thanks

You mean the buttons for drawing? Of course you can, the PopupMenu is just to trigger this method:
https://github.com/omarhurani/flutter_painter/blob/8405829f6a33dd607e520b94f18ce817fcfcd262/example/lib/main.dart#L564-L566
You can implement the UI however you wish.

I could understand now and add the controllers in a Row.
Row(             children: [               IconButton(                 icon: Icon(                   PhosphorIcons.line_segment,                                 ),                 onPressed: () async {                   setShapeFactory(LineFactory());                },               ),               IconButton(                 icon: Icon(                   PhosphorIcons.arrow_up_right,                                  ),                 onPressed: () async {                   setShapeFactory(ArrowFactory());                 },               ), ], ),
There's one thing I couldn't do. I'll open another issue to facilitate the search for other users.
Thanks! It's amazing!


How do I exclude use of any aggregators.  I'm doing the count in my sql server to reduce the number of rows.

Can you please provide more details?


Add configurable expire times for tokens

Right now Tokens have the following expire times:

Bearer: 1 Hour
Refresh: 1 Day

This force any app to request tokens every hour, which is not the most desired behavior in many cases.
The idea is to be able to override these values through a configuration file and assume a default value in case said configuration file is not present or doesn't have the overrided key

I keep planning to implement it as more configurable, and should do this when working with Drupal module development (which is now WIP)
BTW, no solid timeline schedule for this yet... Please feel free to provide a pull request and I will review it on time ;-)

I have found a work around by overriding the expire date in AccessTokenManagerInterface::createModel


How to manage credentials in Guest Configuration / DSC v3?

Unless I entirely have missed some information, it looks like there is a change in how dsc v3 allows us to handle credentials...
The DSC v1 way of handling them was to encrypt the credentials inside the MOF using a certificate and configure LCM on target servers to use that same certificate to decrypt the (as documented here : https://learn.microsoft.com/en-us/powershell/dsc/managing-nodes/metaconfig?view=dsc-1.1#basic-settings ), but that doesn't seem possible in dsc v3 since there is no CertificateId property available in Guest Configuration's LCM settings ( https://learn.microsoft.com/en-us/rest/api/guestconfiguration/guest-configuration-assignments/create-or-update?tabs=HTTP#configurationsetting )
Azure Automation State Configuration / DSC v2 uses a special cmdlet ( Get-AutomationPSCredential ) to retrieve credentials from Azure Automation credentials before compiling and encrypting the mof, but that's not possible in dsc v3 because the mof is compiled on the authoring workstation.
So, what's the recommended way of managing credentials in dsc v3? I would very much like to see System Managed Identities used here as well, in conjunction with Key vaults; but I haven't seen anything pointing towards that capability.
I've actually implemented a quick&dirty proof of concept of how to implement this at the resource level ( https://github.com/Cyr-Az/ActiveDirectoryDsc/commit/32ed2fe51d75a6e4f604faff7ec0e4c35d1e6574 ), but surely there is a better way of achieving this than modifying every single existing resource that needs credentials...
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4b833aa1-931a-8b2e-dcd8-d2abda6e2401
Version Independent ID: 2abb22c6-a677-0715-6875-b017f50c6ea3
Content: Changes to behavior in PowerShell Desired State Configuration for machine configuration
Content Source: articles/governance/machine-configuration/machine-configuration-custom.md
Service: machine-configuration
GitHub Login: @timwarner-msft
Microsoft Alias: timwarner

@Cyr-Az
Thank you for bringing this to our attention.
I've delegated this to content author @timwarner-msft, who will review it and offer their insightful opinions.

Hi @Cyr-Az. This is a response from my machine config/guest config program manager:

We don’t currently support the configuration of credentials. We flag this as a limitation in our documentation here: How to create custom machine configuration package artifacts | Microsoft Learn

Don't use secrets or confidential information in custom content packages.

We will be building out support for storing secrets within the next semester, as when we look at the migration journey from AADSC to machine config, this is considered a regression.

Thanks for asking the question! Kindest regards, Tim

Well that was easy to the miss, to say the least. At least I now have a clear answer, thanks :)


dnu restore fails at OSX yosemite

I followed the instruction in the following link
https://code.visualstudio.com/Docs/ASPnet5
and executed
yo aspnet

then
dnu restore

It ran for a while and ended with the following failure
Could not find Zip file Directory at the end of the file. File may be corrupted

Looks like this SO question will help : http://stackoverflow.com/questions/29996556/dnu-restore-fails-on-mac/30016197#30016197

Unfortunately no.
dnu restore --no-cache.

simply generates another set of error
Argument cannot be null
Parameter name: stream

This is also the first time installation of dnvm.

I only have one dnvm
1.0.0-beta4 mono

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


⚠ Slack has degraded performance

In 127f1bc, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: Slack performance has improved in 294a1c1.


Please add any refference about how it works with misskey (and pages)

It is hard to know how it works with complex data structures or objects like Canvas for instance.
How to draw anything using AiScript? Is it possible?
How does it work with other Content/Input and such thing.
Is there any way to check/lookup for what an AiScripts interpreter supports?

我もAiScriptでcanvasにお繪描きしたい身。AiScriptでcanvas.getContext('2d');とか出徠るのかな？（やり方がわからない）

Misskey Hubマターだわね


Feature Request: Sub Menus

Hi!  I think it's really cool what you've done here and will be using your theme extension!  One thing I could really use is the ability to have sub menus in the main left menu.  For example, I have several Form components with their own mdx page and I'd like to have them all in a menu under "Forms".  So the folder structure would look like Components/Forms/Checkbox.

Hi,
This is something I was already looking into but did not get around it.
But I saw there are people asking for it so will put it on top of my TODO list.
Cheers

I had some fixes to do on the theme so I also implemented this feature.

That was so fast!  Thanks!


Add some TimetableScreenTest tests for 9/11, 9/12, 9/13 and switch Grid timetable

The test would be like when the current date is [day name] **and switch to grid timetable** it should show timetable items for [tabName]
https://github.com/DroidKaigi/conference-app-2024/blob/main/feature/sessions/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/sessions/TimetableScreenTest.kt#L140C31-L140C55
We can run the test by clicking the "Run" button on the left side of Android Studio.

:raised_hand_with_fingers_splayed:

Thanks! Assigned 👍


[5.2] Allow any arrayable item in Collection::whereIn

Currently whereIn and whereInLoose only accept arrays. This change allows anything arrayable to be passed in, which keeps it consistent with the query builder method and removes the need for toArray calls when working with collections.
The array typehint in the method is gone, but I don't think that's considered breaking. If it is, I'll create a new PR for 5.3.
Would this need it's own unit test, or should I keep those as is?

Removing those typehints is breaking, so this should go to 5.3 IMO.

Created a new one: https://github.com/laravel/framework/pull/13793


MGDCTRS-1553 chore: bump msw

This moves to a version of msw that doesn't use a vulnerable xmldom

This should also sort this failing pr -> https://github.com/bf2fc6cc711aee1a0c2a/cos-ui/pull/603


Add GraalVM builds as test

On PR's it should list all files changes (not per commit)

Hi @jeroenvandijk
can you please put a note in the description so that it is clear what you wish to achieve with this PR?
thx

@BrunoBonacci I was trying to trigger a Github Actions build and see if I could get a GraalVM build for only the relevant changes. It didn't directly work, I might try some other time again. Apologies for the noise. Will close it now.


UIScrollViewPanGestureRecognizer was deallocated while key value observers were still registered with it

Thanks! Sorry! Delete

@John-Lluch Hi, awesome work, how @balkarov fix it that?

I think he had remove an observer.

@iDevelopper Hi, yes you're right i remove an observer of one of the uitableviews thanks!


Godocs

Would be sublime if godocs were generated and linked :D

any instructions i can follow to get that setup? :)

@otan See https://pkg.go.dev/about#:~:text=packages and modules.-,Adding a package,-Data for the

https://go.dev/blog/godoc for generation but I assume they are already there for the most part if they are pulled from the main repo

https://pkg.go.dev/github.com/cockroachdb/cockroachdb-parser is bland at the top level, but I can navigate down into the sub packages already

<EMAIL_ADDRESS>is a bit messy but more what we are looking for :D

i think i added it, sorry for the slow follow up


Switching page won't scroll-to / start-from top of the page

If you scroll to the bottom of a page and then switch the page from navigation panel, the view will get updated but it display the bottom of the new page. You should manually scroll to top of the page.

:tada: This issue has been resolved in version 0.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


youtube block start time options

Thought I'd try to help out while posting an issue of my own :) My IDE has made a few tabbing changes, hope that's ok.
YouTube block changes for https://github.com/concrete5/concrete5/issues/6452
The block will respect the t parameter in the url.
I've also added a way of doing this through the block settings, which will take priority over what's in the url. Works with formats 1:20:30 (h:m:s) and 1h20m30s (or just 20m30s, or 30s)

This will work now with both https://www.youtube.com/watch?v=PiT-PvRwQJU&t=1m5s and https://youtu.be/PiT-PvRwQJU?t=1m5s urls.

Thanks! I added a migration to ensure the YouTube block is refreshed in the upgrade to add the schema change.


Add way to style identifiers (i.e. schema, table, and column names)

As seen from the ‘getSegments’ tests, identifiers with backticks are classified as “string”,
it('complex query', () => {
  expect(getSegments("SELECT COUNT(id), `id`, `username` FROM `users` WHERE `email` =<EMAIL_ADDRESS>AND `foo` = 'BAR' OR 1=1"))
    .toStrictEqual([
      ...
      { name: 'string', content: '`email`' },
      ...
      { name: 'string', content<EMAIL_ADDRESS>},

That means that you can’t set a specific style for backticked identifiers, they just appear in the same color as strings.  In the example above, `email` and<EMAIL_ADDRESS>end up with the same styling.
Furthermore, identifiers without backticks are lumped together with whitespace and identified as “default”.:
it('test how default works', () => {
  expect(getSegments('SELECT * FROM hr.emp'))
    .toStrictEqual([
      { name: 'keyword', content: 'SELECT' },
      { name: 'default', content: ' ' },
      { name: 'special', content: '*' },
      { name: 'default', content: ' ' },
      { name: 'keyword', content: 'FROM' },
      { name: 'default', content: ' hr.emp' }
    ])
})

That means that (for example) you can’t set a background-color for identifiers like “hr.emp”, because then the background-color would apply to the whitespace before “hr.emp” too, in addition to the whitespace before and after the * character.

Conversation in #148 to avoid multiple threads.

This should stay open, see #148.


split pull requests created by Renovate

https://github.com/suzuki-shunsuke/test-renovate/blob/1c7cc3351c150d0ab2243d29b2ee2a5bd770fecf/renovate.json
https://github.com/suzuki-shunsuke/test-renovate/pull/19
https://github.com/suzuki-shunsuke/test-renovate/pull/18
https://docs.renovatebot.com/configuration-options/#groupname
https://github.com/renovatebot/config-help/issues/922

additionalBranchPrefix
https://docs.renovatebot.com/configuration-options/#additionalbranchprefix


Able to throw some items through blocks at just the right angle

Not a particularly high priority as it is hard to reproduce and easy to work around if you for some reason didn't mean to stick some item a couple blocks into the ground :-)
Grab a small item like the dynamite or railgun or blueberries from JS or so on. Throw it with q with some force into the horizontal split between two blocks where one is ground level and the other sticks up one block. With enough attempts/practice you can make the item squeeze between the blocks somehow and get stuck one or even two blocks deep before it loses momentum and does the little vibrating thing from being stuck between solid objects (can see by ghosting through the world)
Probably has something to do with items more or less being 2D sprites, but not quite since they do have some minimal depth? Maybe they only look like they have depth in the world and are treated like flat 2D objects by the physics, so if hitting edge on between blocks they can squeeze through? Thus the need to throw it into a corner between blocks so the item will bounce and arrange itself in just the right direction as it hits.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30033939-able-to-throw-some-items-through-blocks-at-just-the-right-angle?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

New scenario: you can throw "light" items (like the tools you start with in Core) through blocks quite some distance in some cases now. Seems distinct from the other case as it only works for some things, will go through the face of blocks with no need for cracks, and is affected more by q powering to max before letting go
The existing scenario still exists as well. Tested in a branch with changes from both #2172 and #2175 merged in.

I'm looking into this. I started from trying out stuff in the game and got annoyed that the throwing power "bar" gets stuck (stays on the screen) if you die before you throw. Found out Items were going in the ground as I tried to deal with that.
About a fix though, I was thinking we could consider it a point until we deal with all the collisions (raycasts were on my mind), and when it reaches a minimum velocity or stays still, we just push it slowly out of the block (like Minecraft does when placing blocks over an area that has items in it)

... it's called quantum tunneling.

I was about to create a new issue for this. Additionally, I have a gif that shows off this issue.  Throwing torches in the ground and they disappear in default mode


⚠ Bofrost.at has degraded performance

In e31cf92, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.at performance has improved in 39ea643.


Reduce the number of parallel running e2e tests

How to categorize this PR?

/area testing
/kind flake
What this PR does / why we need it:
We run lots of e2e tests in parallel. Thus, many kubelets, pods etc. using use the same cgroup filesystem which could lead to very high loads (~750).
This could cause inaccessible nodes in our prow cluster and flaking tests.
This PR reduces the number of parallel running e2e tests to reduce the load on the prow nodes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm not sure about the best value for the number of parallel tests yet, so I'm planning to test it with this PR.
Release note:

NONE

/test all

/retitle Reduce the number of parallel running e2e tests
As discussed, the effect of this setting would be visible only when we apply it for all the tests. Thus, let us test this setting for two weeks and see how it affects the stability of the prow nodes.

/approve

/cherry-pick release-v1.78

/cherry-pick release-v1.79

/cherry-pick release-v1.80

/cherry-pick release-v1.81


VK_NV_* required for Vulkan backend in VR sample when using Radeon GPU

requiredInstanceExtensions erroneously include the following device extensions on Radeon RX480 GPU:
VK_NV_external_memory,
VK_NV_dedicated_allocation,
VK_NV_external_memory_win32,
VK_NV_win32_keyed_mutex,
commenting out VRGraphicsDevice 732-737 fixes the problem allowing the VR sample to run on my setup without any apparent problems - but obviously that's not a solution - so perhaps there should be a setting which checks for non NV cards and adjusts?
Or if this is something I'm supposed to implement myself, I'd appreciate if anyone could point me in the right direction.
Thanks

Sorry, I should mention that it's for OpenVR that I have this issue

This looks like it's an OpenVR problem, not a veldrid problem.
for reference: https://steamcommunity.com/app/250820/discussions/8/2448217320137020268/


Required var 'username' not found in config.

Describe the bug
I defined vars in dbt_project.yml and I then try to access them inside profiles.yml.
This is how I'm doing it:
{{ var("username") }}
but it complains:
 ERROR Runtime Error
  Compilation Error
    Could not render {{ var("user") }}: Required var 'user' not found in config:
    Vars supplied to <Configuration> = {}

Steps To Reproduce
in dbt_project.yml add this var:
vars:
    username: 'my_user_name`

Then in profiles.yml call the var this way:
user: '{{ var("username") }}'

System information
installed version: 0.18.1
   latest version: 0.18.1

Up to date!

Plugins:
  - bigquery: 0.18.1
  - snowflake: 0.18.1
  - redshift: 0.18.1
  - postgres: 0.18.1

OS: MacOS
Python: 3.7.9

@RoniFinTech check out the docs on what's available in profiles.yml:

Available context variables:

env_var
vars (Note: only variables defined with --vars are available)

Default values of vars that you set in dbt_project.yml will not work for profiles.yml. Instead, you can set a default value inline:
user: '{{ var("username", "my_user_name") }}'

Or pass a value every time from the CLI:
dbt run --vars 'username: my_user_name'

In general, I recommend using environment variables for values in profiles.yml, since they tend to reflect the details of deployment environments.

@jtcohen6 how would one use environment variables with the dbt command?


ofp example applications are missing from instalation

Note: the issue was created automatically with bugzilla2github tool
Bugzilla Bug ID: 84
Date: 2016-04-19 14:46:44 +0200
From: Razvan<EMAIL_ADDRESS>To:   Sorin Vultureanu<EMAIL_ADDRESS>Last updated: 2016-04-19 14:46:44 +0200
Bugzilla Comment ID: 167
Date: 2016-04-19 14:46:44 +0200
From: Razvan<EMAIL_ADDRESS>scripts and example applications (fpm) are not automatically installed along with the libs and binaries when using --prefix option

This is the desired behavior introduced by change 924fff1906335cbd7a7a3ae0348d70e5e0df331b. Do you see any reasons why the example applications should be installed?

odp or dpdk are installing the example applications?

it makes sense to have applications in the install directory as ODP and DPDK does.
Maybe we can have a configure switch to enable/disable this behaviour.


Add account_file touch to determine current logged in account by modified date

This addition is for helping determine the currently logged in account by touching the account_file after an account has been set. We can use this information to have a command line prompt to show which account is logged in by use of modified date.

I've also added a convenience method to display just the current account with heroku accounts:current. This is based off the modified times of the accounts files so as to not ping Heroku.

Rather than have separate files for each account, wouldn't it be better to have this as a property in the netrc file?

Hi @dickeyxxx multiple files is how it currently works, I'm just touching the currently logged in one.
This was an alternative suggestion after you commented on my netrc suggestion here - https://github.com/heroku/heroku-cli/issues/218
Which way would you prefer?
Cheers,
Rikki

I would definitely prefer for it to be in the netrc file


Why do I test according to this example? QPS is very low. Where is it not configured

Why is QPS very low according to this example? Is there a problem with my configuration

php7.4
roadrunner: 2.7

config

test

Hi @pretty66! How can I reproduce described behavior? Could you please make a repository with a demonstration?

Hi @pretty66! How can I reproduce described behavior? Could you please make a repository with a demonstration?

Yes, this is my test code：test code

diff --git a/.env.example b/.env.example
index b7becba..ba43d82 100644
--- a/.env.example
+++ b/.env.example
@@ -19,7 +19,7 @@ BROADCAST_DRIVER=log
 CACHE_DRIVER=file
 FILESYSTEM_DRIVER=local
 QUEUE_CONNECTION=sync
-SESSION_DRIVER=file
+SESSION_DRIVER=array
 SESSION_LIFETIME=120

 MEMCACHED_HOST=<IP_ADDRESS>

Before:
$ wrk -d 5 http://<IP_ADDRESS>:1876/info
Running 5s test @ http://<IP_ADDRESS>:1876/info
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   105.46ms  158.05ms 598.22ms   80.95%
    Req/Sec   322.81    246.03     1.08k    67.74%
  3071 requests in 5.00s, 3.08MB read
Requests/sec:    613.66
Transfer/sec:    630.44KB

After:
$ wrk -d 5 http://<IP_ADDRESS>:1876/info
Running 5s test @ http://<IP_ADDRESS>:1876/info
  2 threads and 10 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     3.95ms    1.23ms  28.91ms   94.04%
    Req/Sec     1.29k    76.95     1.43k    74.00%
  12811 requests in 5.00s, 12.85MB read
Requests/sec:   2561.09
Transfer/sec:      2.57MB

Related issue: #23 (one more example)
@pretty66  This issue can be closed?

Thank you. The issue can be closed


Cant get access to webcams microphone audio stream.

Im sorry if question might be seems simple but i didnt find answer to it and i dont know what to do.
Im trying getting an audio stream from my webcams microphone. For example function open("file.mp4") returns video and audio streams, open("file.wav") returns audio stream. And string open("/dev/video0") returns only video stream. It is logical but is there any way to get audio stream from webcam? thanks for your help and understanding)

I don't have any experience with this. Maybe something like https://askubuntu.com/a/986189?
Seems like you'll have to open the audio/video separately. I don't know what the deal will be with syncing them.
I'm going to close this as it isn't a PyAV issue. Feel free to keep posting here if you want and I can try to help, or you can go over to the Gitter for a different audience.

Just i found this issue and thought that it is possible, because first part of code working, as he said. But i tried to replace "none:0" to my microphone address and it doesnt work for me.


handle custom Message types in zmq.log

closes #1834

Turns out getMessage wasn't quite right, since that's called in format, and I don't think we can call format before stripping the topic. So instead, call str explicitly, just like in getMessage, rather than calling getMessage itself.

@minrk thanks for quick fix, can we get a new release? 🙏🏻


Currency-metrics-web-app

In this PR we built, the full Currency-metrics-web-app.
Features Implemented:

built the homepage with functionalities.
built the details page with functionalities.
Loom Video

Hi, @Ghiftee please, I don't understand what you require, concerning the last comment you left. please explain, thank you


Add support for "Hide Whitespace Changs".

Add support for "Hide Whitespace Changs".

VS Code has built in support for leading/trailing whitespace hiding already:

There might be a bug, or an unknown good reason, but this option does not appear for me in some files.
In my test case, I have a .java and .adoc file that do not have the button, but a .sh and pom.xml do have it.
In all cases, the button value is respected in all diff.


invoices: ensure synchronous access to NewTestSqliteDB

Add a temporary mutex around the call to sqldb.NewTestSqliteDB in the TestInvoiceRegistry test to ensure that only a single thread can access it at a time. This is a temporary work around that can be removed once this race condition in the sqlite repo has been resolved: https://gitlab.com/cznic/sqlite/-/issues/180

OMG, so much green in the CI :star_struck:


[sw,tests] Verify sysrst_ctrl inputs can be read using CSRs

For test:
chip_sw_sysrst_ctrl_inputs
Checks that known values driven at the chip inputs by the testbench
can be read using the sysrst_ctrl CSRs in software. The values read
are verified against the expected values.
Signed-off-by: Dave Williams<EMAIL_ADDRESS>

LGTM with a few nits


Endless Loading State

Hi there! Love your content, brightly put and well made!
I am running windows 10, x64 bit system, with the latest version of TD (2022.33910)
and connecting a proper USB Logitech webcam - downloaded the latest version of the plugin Release v0.2.1.
Once launching the MediaPipre TouchDesigner.toe file, all the components shows as expected, but the loading container  of MediaPipe stays loading endlessly.
I can turn on and off the parameters, but nothing affects the input of the MediaPipe container, keeping it in loading state.
My computer has no problem recognizing the camera as a Video device Input, and it even shows in the MediaPipe Parameters as a Webcam option (so no webcam detection issues),
and tried it on the MediaPipre website to make sure it worked (even tho i would rather use it through your cool Nodes! haha).
Also, absolutely no red cross appears anywhere, so all good but still loading. Only suspicious thing i found was about the webrowser module in the MediaPipe Container - it appears pitch black. I reckon might be because the toe file has problems connecting the web page that has the tools? Camera privacy issues? Still searching haha
Thanks for your awesome contribution! Looking forward to try it!
Best of luck and your guidance is much appreciated!

Hi @EZUR11 this is an odd one for sure! It sounds like it's failing to start your webcam for some reason. The component currently only works with a 720p webcam. Can you confirm if your webcam supports that resolution and/or if the component
works with any other webcam sources if you have them?
A quick test is in a new project to drop a video device in top down, select your webcam, and see what resolution options you get.
Let us know if those things don't work, and we can think some more

Another thing to try. Could you open up the TextPort in TouchDesigner and attach a screenshot of the logs?

Ok it is all figured out! Just had to refollow the exact steps given in the install tutorial, and realized I had forgotten a crucial piece: connecting the video device input as SpoutCam. With SpoutCam downloaded and running with the right settings (aka the suiting FrameRate for my TouchDesigner version (mine was 30 fps), set the starting resolution (1280x720), and add the right "Starting Sender" input ("TDSyphonSpoutOut"), then registering these parameters). Also, made sure to have the latest release of both your MediaPipe plugin (20.2) and Touchdesigner (2022.33910). It works! Great work!
Now that I ghot to play around with the hand tracking module, I have a few other questions haha!
First, is SpoutCam the only video input that can be selected to work with mediapipe? In other words, could I use the video feed from a NDI TOP node connected to a phone camera for example across the network?
Secondly, any way to have any additional data about the hands positions relative to itself? for example, the distance between the tip of the ring finger and the thumb, or the distance between the ring finger of each hands - the output CHOP data seems to be limited to one hand and one finger at a time. Would like to create an interactive shape building from hands tracking (e.i. a rectangular shapes adjusting its dimensions in real time to the distance between fingers).
Finally, could be very interesting to combine these trained models tools with depth sensors of modern video input gadgets, such as the most modern SmartPhones.
In short, any way to use your wonderful plugin with other video inputs than SpoutCam?
Many thanks!

Glad you got it working @EZUR11!
You can absolutely use it with other sources - the only caveat is that source has to appear as a webcam. If you install NDI Tools, there are 4 virtual NDI webcams you can use. You configure which NDI source each one will have in NDI Tools, then select the relevant one in the Media Pipe component.
For your hands questions, yes as well. You get an xyz coordinate for each joint in your hand, so you can use a select chop to get the points you want to measure the distance between, then feed them into an Object CHOP and select distance. It will output the distance (or bearing or other things) between the 2 points.
If you just want the horizontal distance, you can also select just the x coordinates for the 2 points and use a math chop to figure out the distance between them.
And if you want to figure out the distance between hands, there's already a CHOP outlut for that, and you can also open up the hand tracking component and take a look at how that is calculated and modify it for your own use. Just be aware if you modify anything within the tox, you’ll have to save it individually as well as the main toe file.


Duplicates in recents list

When searching for a route multiple times it gets added to the recents screen multiple times as well, even though the query is exactly the same. This clutters up the list very quickly. I would suggest simply moving up the already existing item.

Thanks for the report. I've just verified that in some cases it creates entries when it should not.
However for some queries it's expected to create multiple entries e.g, adding/changing a via point, toggling of alternative stops, change of transport modes and or change of origin or destination.
Thanks!

It would be nice if the entered time/date would be saved as well. Maybe also shown in the list so that you can "prepare" a trip.

@ElectricCookie What you describe might fit with #50?

Yeah I suppose you would need the functionality of #50 to realize this feature

Apparently you can also add duplicate favorites. I suppose it's the same underlying cause.

Yes, the comparison is the same for both. I suppose that's where the problem for this issue is as well since it's comparing the serialised format and not the actual content.

We should change the implementation for comparison, it's just a matter of time until this will hit us again.


add delete and rename for time

delete pt[timeField] after putting the value into pt.time.
if there exists a pt.time with a separate timeField, avoid simply discarding by setting that value to key pt._time.

(also note that I will have to do a little rework on this after https://github.com/juttle/juttle/pull/248 since the function moves to a new class - but the function does not change in logic in that pr)
This PR originated from @dmajda comment here: https://github.com/juttle/juttle-sql-adapter-common/pull/16
And has to do with bringing this back: https://github.com/juttle/juttle-sql-adapter-common/pull/14

@demmer what do you thing about this solution?

@davidvgalbraith also.

Notes from @demmer:

Consider toNative + parseTime => same function.
Ensure point is dropped with error when time = foo.


fix: publish missing files

Fix https://github.com/sveltejs/kit/issues/8530
npm and pnpm includes the file in pkg.main to publish by default. Since https://github.com/sveltejs/kit/pull/8519 removed the pkg.main field, we forgot to add the index.js file to the pkg.files field, causing it to be missing after publish.
This PR updates the pkg.files field
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.


Support federation v2.3

Includes

support for the changes in federation v2.2, i.e. adding repeatable to the @shareable directive.
support for the changes in federation v2.3, i.e. adding the @interfaceObject directive
updates to the example graphs to make use of the new @interfaceObject directive

Could you please apply scalafmt?

Could you please apply scalafmt?

Sure! I thought I did it but I'll have a look!

On main there's a test that is blocked on github actions.
I've removed the test to unblock the situation: https://github.com/sangria-graphql/sangria-federated/pull/280
Could you merge the new main?

I don't know if it's a github bug but I cannot see any changes anymore.

I cleaned up the git history a bit and now it should be ready for a workflow run

I removed the example for now and see if I can come up with a better use case to put in another PR.


Improve Turn Indicator Visuals in Tic Tac Toe Game

🔴 Title : Improve Turn Indicator Visuals in Tic Tac Toe Game
🔴 Description : The aim of this enhancement is to improve the visual appeal and user experience of the turn indicator in our Tic Tac Toe game. By transitioning from a text-based indicator to a dynamic and visually engaging representation, I intend to create a more immersive gameplay environment that helps players quickly identify whose turn it is.
🔴 Changes : I replaced the text indicator with dynamic player icons (X and O) in distinct colors for each player.
🔴 Closes #892
🔴 Images/Videos:
Before:

After:
screen-capture.webm

@iamrahulmahato Please review this PR once and add appropriate levels under gsssoc and hacktoberfest.
Thankyou.


lfec expects lfe to be in the PATH

lfec now has the following script header:
#! /usr/bin/env lfe

I sometimes don't have lfe in my $PATH, in which case this fails. This is a different behaviour from lfe (necessarily, since lfec is now written in LFE).
If we are making the installation of LFE a requirement, we should document this. And put it on the project README.

Well LFE has to be there. How else could it find it? I suppose one option that may occur is if LFE is a dependency so it should search in a deps directory but even then it would have to find an lfec which can find itself or perhaps try and call the compiler directly. In either we couldn't write lfec in LFE, it would have to be a shell script or a C program.
We should document it.

This is related on a bootstrapping problem on machines that rely on the erlc and lfec make targets. In that special case I ended up tweaking the $PATH in the Makefile:
@@ -65,7 +65,7 @@ $(EBINDIR)/%.beam: $(SRCDIR)/%.erl
        $(ERLC) -o $(SRCDIR) $<

 $(EBINDIR)/%.beam: $(LSRCDIR)/%.lfe
-       $(LFEC) -I $(INCDIR) -o $(EBINDIR) $(LFECFLAGS) $<
+       PATH=$(PWD)/bin:$(PATH) $(LFEC) -I $(INCDIR) -o $(EBINDIR) $(LFECFLAGS) $<

This is needed to find lfec and compile cl.lfe. I've only seen this on FreeBSD using gmake.

Is this fixed now?

I have another fix for this which seems to work:
LFECFLAGS = -pa ../lfe
LFEC = $(BINDIR)/lfe $(BINDIR)/lfec

$(EBINDIR)/%.beam: $(LSRCDIR)/%.lfe
        $(LFEC) -I $(INCDIR) -o $(EBINDIR) $(LFECFLAGS) $<

It is in the current versions.

This has worked for me for some time now. Unless @oubiwann or @arpunk disagree, I think this can be closed.

Fixed; closing.


[BUG] integrationcli integrations create delivers a wall of JSON

Summary
when I use integrationcli integrations create to upload? import? a .json file containing an integration definition, the result of the command is a wall of JSON as large as my file.  It can be 1000 or more lines. This is not what users want from an interactive command line tool.  They want to see a "it worked" or "it didn't work" message.
Actual Experience
$ integrationcli integrations create -f ./apigee-pdu-check-bg4a11.json  -n apigee-pdu-check-1
{
        "name": "projects/14182523368/locations/us-west1/integrations/integration-name-1/versions/e1a44e8a-8f52-45f5-ae61-e4a6351ec247",
        "description": "description here.",
        "origin": "UI",
        "snapshotNumber": "1",
        "updateTime": "2024-12-20T01:27:30.722962Z",
        "lockHolder"<EMAIL_ADDRESS>        "createTime": "2024-12-20T01:27:30.722962Z",
        "lastModifierEmail"<EMAIL_ADDRESS>        "state": "DRAFT",
        "triggerConfigs": [
                {
                        "label": "Query Organization",
                        "startTasks": [
                                {
                                        "taskId": "2"
                                }
                        ],
      ....over 1000 more lines here....

Version
$ integrationcli --version
integrationcli version 0.78.0 date: 2024-12-10T17:57:38Z [commit: 9371c4e]

Expected behavior
Some smaller, human-scale response that indicates success or failure.

As with issue #328, the CLI's behavior matches that of the API. It is also not a bug, rather an enhancement.
One of the uses of integrationcli is as you say, to be used interactively and such uses don't require the entire response JSON. However, integrationcli is frequently used in automation (like Github Actions) and those use cases (when combined with tools like jq) do require access to the full response JSON (because they are likely need to access fields from the response like snapshot number). Returning a non-JSON output like "it worked" breaks automation use cases.
Proposal: Introduce a new flag (--concise) to omit triggerConfigs, taskConfigs, integrationParameters, errorCatcherConfigs, integrationConfigParameters. The rest of the fields are static and perhaps useful to see. The default behavior will continue.

Please take a look at release v0.79.0, a number of suggestions from your issue have been incorporated.


Atom doesn't respond after first character typed if ghc-mod can't be found

The plugin doesn't find ghc-mod:
Haskell-ghc-mod: ghc-mod lang failed with error message Error: spawn ghc-mod ENOENT
Steps to reproduce:

Open a new file an set language to Haskell.
Type a character.
The editor doesn't respond anymore.
I also have the autocomplete-haskell plugin installed.

Even worse if ghc-mod is configured. The editor hangs after choosing the language.
I have ghc-mod version <IP_ADDRESS> compiled by GHC 7.10.2

However it doesn't seem to be any problem with ghc-mod version <IP_ADDRESS>

FYI, ghc-mod <IP_ADDRESS> isn't supported:

Supported ghc-mod versions are from 4.1.0 to <IP_ADDRESS>, and 5.4.x. 5.3.x might work, but is not officially supported.

That said, I'm frankly baffled at your report of Atom hanging/editor not responding, this should never happen. What Atom version do you use? On what OS?

I'm using Atom 1.1.0 on Linux arch 4.2.4-1-ARCH #1 SMP PREEMPT Fri Oct 23 07:32:38 CEST 2015 x86_64 GNU/Linux

Supported ghc-mod versions are from 4.1.0 to <IP_ADDRESS>, and 5.4.x. 5.3.x might work, but is not officially > supported.
I see,  but it hangs too when it can't find ghc-mod.

Do you have ide-haskell plugin installed?

Nevermind, I was able to reproduce this. Weird. I'll look into this. Thanks for reporting.

Should be fixed in 1.1.3.


Rolemaster 2nd/Classic options and auto-calculations

Changes / Comments

Adding development points auto-calculations
Adding the BMR in the sheet
Adding the sheet color selection in the options
Adding more optional rules in the sheet and in the campaign options
Cleaning the code

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[X] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Dear @Onirim your PR has a conflict within a few different files which needs to be resolved before I can merge it. Please rebase you PR against last Master and fix these issues. If you are unsure how to do this, take a look at the Git documentation.

I've done a new pull request because I've delete and re-create my fork!


242 contributing guidelines

This adds contributing guidelines for skohub development.
I suggest that after the PR is approved, we should open a repo for the contributing guidelines and link from all skohub modules to that repo.
This makes the guidelines easier to maintain.

@katauber https://github.com/skohub-io/skohub-vocabs/pull/262/commits/02bce1cfe138711a7dac0979668497107faf8bac is something that also needs to be done in the Metafacture Contributing.md. See also https://github.com/skohub-io/skohub-vocabs/issues/242#issuecomment-1443644808

CONTRIBUTING.md should at the end be hosted here: https://github.com/skohub-io/skohub.io

@katauber FYI, 02bce1c is something that also needs to be done in the Metafacture Contributing.md. See also #242 (comment)

I would like to keep those lines for Metafacture Playground because these two things help understand the enhancement suggestion in detail. By describing which behaviour should be replaced and for which examples this behaviour is needed, the suggestion is specified in more detail.


fixing detail overflow issue 85

Closes: https://github.com/esridc/openfda/issues/85

@dmfenton I believe this was the issue you were talking about.

OK let me test this

OK confirmed I can scroll...in dev tools at least.


Crashes don't produce useful feedback

I build the app off of the latest main branch. When generating the path, the whole app crashes. However I don't have good data to provide for this bug ticket, as the crash produces no useful information.

do you have a file with the path that crashed the app?

I don't. For whatever reason, any three points followed by generating the path, would crash the app.

Would you provide your system information (os, etc)?
How were you running the app?

We're investigating a potentially related crash bug that crashes even with two points. Do you know if it required at least 3 points to crash it?

System Specs (let me know if I'm missing anything)

Windows 11
npm 10.2.0
node 21.1.0
cargo 1.73.0
rustup default stable-x86_64-pc-windows-gnu

Built it from c32aa0a0720777626b70a208bf9803d09f25c7bc, installed using nsis installer or run using npm run tauri dev -- --release
Any number of points except 1 since you can't generate with 1

Note I did not see this when I built a few weeks ago.
I am trying to add some debugging to the application, but this requires a bit of learning on my part.

This sounds like the issue that broke our Windows CI builds sometime between September 10 and October 16. From what we can tell, it's a build environment change (GH updated the Windows runner, and LLVM released major version 17, and we're not sure which change actually broke it yet). Would you try the Windows installer from the v0.3.0 release? That was built outside of the CI pipeline due to this issue, and has been tested to not crash.
Also, would you please paste the output of clang --version? We built v0.3.0 on my machine with LLVM/Clang 16.0.6, but CI uses the latest, 17.0.3.

clang version 17.0.1
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\LLVM\bin

Note that I did not have this issue a week ago, and afaik my LLVM/Clang setup has not changed in that time. Hope its not some kind of flaky issue with the compiler.

OBE by #326.


#1 Burner Wallet

@carletex here's a video overview, its ready for PR:  https://www.dropbox.com/s/f4trel929a2jeou/2022.09.30-21.07-Brave Browser Scaffod-eth App.mp4?dl=0
I'll do the config as a seperate PR i think.  better to split things up.
this is the burner config so far, please see video for details.  Let me know if anything needs improving
export type TAutoConnect = {
  /**
   * Enable the burner wallet.  If this is disabled, burner wallet is entierly disabled
   */
  enableBurnerWallet: boolean;
  /**
   * Always autoConnectToBurner to burner wallet on page load.
   */
  alwaysAutoConnectToBurnerOnLoad: boolean;
  /**
   * If user is not connected to any wallet:  On reload, connect to burner wallet
   */
  connectToBurnerIfDisconnectedOnLoad: boolean;
  /**
   * Auto connect: If the user was connected into a wallet before, on page reload reconnect automatically
   */
  allowAutoConnect: boolean;
};

Hey @ShravanSunder
Left some review comments / questions.
I also pushed a couple of commits cleaning some stuff. If you need to do some tweaks to config stuff (nextjs, lint, etc), could you add a PR comment on the given code line explaining why is it needed? If not, some changes might seem random changes / personal preferences tweaks.

I've pushed with the commit comments.   Sorry i mistook pr comments for commit comments.  can add pr comments to if you like.

@ShravanSunder thanks for the updates. Check review comments.
A couple of things more:

When ever I reload the page I get a different burner wallet address. the localstorage logic not working?
Now I'm getting this errors when loading the page:

Maybe we are making a call before some data available?

fix the issue with local storage.
The errors are because of tempContract, it needs contract to be deployed and is just for our current testing.  you have to change the address of tempContract to the deployed contract.


python312Packages.findimports: 2.4.0 -> 2.5.0

Diff: https://github.com/mgedmin/findimports/compare/refs/tags/2.4.0...2.5.0
Changelog: https://github.com/mgedmin/findimports/blob/2.5.0/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 316476 run on x86_64-linux 1

6 packages built:

circup
circup.dist
python311Packages.findimports
python311Packages.findimports.dist
python312Packages.findimports
python312Packages.findimports.dist


node: Implement graceful shutdown

Related to #82.
Reference this article for new ideas.

it's unrelated to the node's logic. Node logic implements graceful shutdown. Pls create another one if the issue still persists, but AFAIU, the new DASer logic fixes this and improves shutdown logic substantially, so I am closing this. cc @walldiss