Redesign Product Card Component

hello there so I need someone to redesign my product card component now at this moment its looking very basic so I want you to make its attractive and user friendly

Hi @Nababratadeb-NITA, I can work on some designs and you can let me know if it suits you or if any changes are required. Can you assign me to this issue?

Yeah sure @ankitk26 can you show me some designs that you'll make
Then I'll assign you

@Nababratadeb-NITA, I made some designs. Please let me know if any changes or new designs are required.

@ankitk26 how can I see the examples

Ok @ankitk26  that 2nd one looks cool to me

Ok, I will start working on this. Can you assign me?

Ok @ankitk26  that 2nd one looks cool to me
Yeah sure I'm assigning you this work

@Nababratadeb-NITA, I changed the code for the product card. It looks like this now. I also added the onAdd() function to the "Add to Cart" button on the card.

Adding one more screenshot of the screen

Great design 👍

hey @ankitk26  i have one mode request can you please redesign the product details page ?

I have redesigned the product detail page. Let me know if there are any changes to be done.

Here is an alternative for the product description

And where would be the picture

It is the same as the above image. I just changed the representation of the category


Pages don't display more than 12 products by default, and can never display more than 50

I've found that when using the Next.js Commerce integration with BigCommerce, the site never displays more than 12 products on any page or category, despite the category/page having more than 12 products assigned to it.
It would be great if this could be fixed natively, or if there was documentation added on how to increase this hard limit set by the integration for users that are planning to set up this integration for production.

Hey there! Thank you for opening this issue. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: https://github.com/vercel/commerce/pull/966


New version: Mozilla.Firefox.ESR.zh-CN version 128.4.0

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


React Native bindings when using router

Really like what mobx is offering. Thank you for sharing.
My first attempt to try the mobx is integrating it with react native app that uses react-native-router-flux.  Can't seem to have binding working, pretty sure i am missing something:
1. Router
class RootRouter extends Component {

    render() {
        return(
        	<Drawer content={<ControlPanel />}>
					<View style={layout.layout}>
			            <Router hideNavBar={true} >
			                <Schema name="default" sceneConfig={Navigator.SceneConfigs.FloatFromRight}/>

			                <Route name="inventoryList" type="replace" wrapRouter={false} component={InventoryList} title="Inventory" />
			            </Router>
		            </View>
            </Drawer>
        );
    }
}

2. Main component
 class ControlPanel extends Component {
constructor(props) {
        super(props);
        InventoryStore.httpReq();
    }
    showInventoryList() {
        Actions.inventoryList({store:InventoryStore });
    }

    render() {
        return (
            <View>
                <ScrollView>
                    <View>
                        <TouchableOpacity  onPress={this.showInventoryList}>
                            <View>
                                <Text>Inventory List</Text>
                            </View>
                        </TouchableOpacity>
                    </View>
                </ScrollView>
            </View>
        );
    }
}

3. The List component
class InventoryList extends Component {
  render() {

        if (this.props.store.isLoading === true) {
            return <View><Text>Loading ...</Text></View>;
        }

    return (
        <View>
                { this.props.store.inventoryData.map(
                (inventory, idx) => <InventoryView inventory={ inventory } key={ idx } />
                ) }
        </View>
    );
  }
}

@observer
class InventoryView extends Component {
  render() {
    const inventory = this.props.inventory;
    return (
      <View>
        <Text>{inventory.ProjectNumber}</Text>
      </View>
    );
  }
}

4. The store
const InventoryStore = observable({
  inventoryData: [],
  isLoading: true
});

InventoryStore.httpReq = function (model) {
		this.isLoading = true;
		fetch('http://www.example.com/api/GetData', {
				method: 'GET',
			})
			.then((response) => response.json())
			.then((responseData) => {

				this.isLoading = false;
				this.inventoryData = responseData

			})
			.done();

	}

Any idea?

Interesting enough, it's working now - haven't made any change, except stepping out from the computer and getting back at it soon after - and then boom to surprise it's working.
I think restarting packager might did the trick.
Thanks again!

You're welcome :)


Find by title

Summary of change
[Please briefly describe what you have changed.]
Related issue
Closes #[issue 10]
Pull request checklist
Please keep this checklist in & ensure you have done the following:

[ ] Read, understood and adhered to our contributing document.

[ ] Ensure that you were first assigned to a relevant issue before creating this pull request
[ ] Ensure code changes pass all tests

[ ] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.

[ ] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request

[ ] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

[ ] Set this pull request to 'draft' if you are still working on it

[ ] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace

Closing in favour of #47

Closing in favour of #47


Atom main window starts black, not possible to edit files

Problem description
I install Atom from the stable .deb package. Everything seems
fine, but when i start it the main window is completely black.
I try to open a file, it was shown in the window title but
the main window remains black.
I remove the package.
Then i build Atom 1.9.0 with the instructions for the linux build.
Everything seems fine, but when i start Atom the main window
is completely black. Also when i open a file.
I work down the debugging guide, but nothing changes.
Nothing changes when i start Atom in safe-mode nor when i reset it
to factory settings.
Can't find anything in the FAQ or thru google search.
Maybe someone can give me a hint.
Build Environment
Ubuntu 14.04 LTS 64bit
Linux workstation 3.13.0-92-generic #139-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux
python 2.7.6
nvm v0.31.4
npm v2.13.3
node v4.4.7
node-gyp v3.4.0
apm  v1.10.0
Atom    : 1.9.0
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

@APTHunter Is this in VirtualBox?  Can you run Atom through the terminal using atom --foreground and paste the output here?

@APTHunter can you reproduce this with the latest stable version of Atom, v1.9.6?

@50Wliu
Yes it's a Virtualbox vm, here is the output from atom --foreground:
workstation:~/.ssh$ atom --foreground
[11030:0809/054212:ERROR:browser_main_loop.cc(217)] Running without the SUID sandbox! See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md for more information on developing with the sandbox on.
App load time: 807ms
[11030:0809/054214:INFO:CONSOLE(52)] "Window load time: 595ms", source: file:///usr/share/atom/resources/app.asar/static/index.js (52)
[11030:0809/054214:INFO:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)
[11030:0809/054214:INFO:CONSOLE(0)] "::shadow pseudo-element is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source:  (0)

@50Wliu
When i use atom --disable-gpu it start normal and i can use it.

Ok, if you're using Atom in VirtualBox and disabling the GPU fixes it, then I'm closing this out.


add cli container image to release workflow

Summary

This PR publishes the cli container image in the release workflow.

Closes #328

Release Note

Publish ghcr.io/sigstore/model-transparency-cli container image

Documentation

N/A

Thank you @mihaimaruseac  and @spencerschrock for your reviews and comments. I think I addressed everything you mentioned :)


Limit popover to viewport

Is there a way to limit the popover so that it never renders outside of the viewport? For example if the child element that the popover is tracking is scrolled outside of the viewport, i'd like the popover to align at the top or bottom of the screen (or the scrollable element)

Maybe something like fixed width on class Popover-body and position left using calc? Look at my code. I avoid bug with popover resize when windows resize + bug with extending out of viewport when for example you have margin-bottom in parent container of page.
`/* popover */
.Popover {
margin-top: 20px !important;
left: calc(100% - 370px) !important;
}
.Popover-body {
width: 350px;
display: inline-flex;
flex-direction: column;
padding: 2rem 3rem;
background-color: #005A31;
color: white;
border-radius: 0.3rem;
}`


Require example of openssl generated cert for bring your own cert

In what area(s)?
I'm not able to make bring your own cert working. we use openssl to generate the cert.
Here are the steps:
openssl genrsa -out ca.key 2048
openssl req -x509 -new -nodes -key ${tmp_dir}/ca.key -sha256 -days 365 -out ca.crt -config ca.cnf -extensions v3_ca -subj /CN=Archean_CA
step certificate create cluster.local issuer.crt issuer.key --ca ca.crt --ca-key ca.key --profile intermediate-ca --not-after 8760h --no-password --insecure

/area runtime
/area operator
/area placement
/area docs
/area test-and-release

Describe the feature

Release Note

RELEASE NOTE:

After dump default dapr cert
kubectl get secret dapr-trust-bundle -n dapr-system   -o json | jq '.data | map_values(@base64d)'
openssl x509 -noout -text -in ca.crt
openssl x509 -noout -text -in issuer.crt
for cert detail .
I found default cert use Signature Algorithm: ecdsa-with-SHA256.
I checked dapr code it only support rsa and esdsa .  https://github.com/dapr/dapr/blob/master/pkg/sentry/certs/certs.go
Here is what I did but without success via openssl

Generate rootCA private key and cert via  modified openssl.cnf
generate intermediate private key cand cert
kubectl edit secret dapr-trust-bundle -n dapr-system to change ca.crt, issuer.crt and issuer.key
kubectl rollout restart deploy/dapr-sentry -n <DAPR_NAMESPACE>
kubectl rollout restart deploy/dapr-operator -n <DAPR_NAMESPACE>
kubectl rollout restart deploy/dapr-placement -n <DAPR_NAMESPACE>

kubectl rollout restart deploy/dapr-app -n <DAPR_APP_NAMESPACE>
but after that pod crash from time to time here is the error:"
time="2020-12-08T03:53:56.018308155Z" level=error msg="error from operator stream: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0"" app_id=hostnameond instance=hostname-on-79cbbc84f9-95lng scope=dapr.runtime type=log ver=0.11.3
time="2020-12-08T03:53:56.018582159Z" level=info msg="component loaded. name: kubernetes, type: secretstores.kubernetes" app_id=hostnameond instance=hostname-on-79cbbc84f9-95lng scope=dapr.runtime type=log ver=0.11.3
time="2020-12-08T03:54:01.078728859Z" level=warning msg="failed to load components: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0"" app_id=hostnameond instance=hostname-on-79cbbc84f9-95lng scope=dapr.runtime type=log ver=0.11.3

@yaron2, do we support openssl for bring your own certs?

@yaron2, do we support openssl for bring your own certs?

Yes, but the instructions need a change because of our recent SPIFFE support and a breaking change in Go 1.15 for handling certificates.

Dupe of dapr/docs#1008


Stop CI from clobbering commits on lockfile updates

🚀 Pull Request
Description

Added a step to the update lockfile workflow to first check if someone has committed to the auto-update-lockfiles branch since last run. If so, it will abort regenerating lockfiles.
This resolves #4156 (observed in #4137).
If you really want to run the workflow and potentially clobber anything on the branch, you can override this new check step by running from the actions panel and performing a manual workflow dispatch, setting the "clobber" value to YES.

Consult Iris pull request check list

@jamesp Awesome stuff. I :heart: it!


[Feature]: Add Online and Oflline sorting on the hackathons

Is your feature request related to a problem? Please describe.
I have to view if the hackathon Is online to offline it will be great to sort them direcltydirectlydirectly
Describe the solution you'd like
Add a sorted input and ask for online and offline send it to the backend and retrieve the same
Alternatives
No response
Additional Context
No response
Are you interested in contributing?

[X] I'd like to work on this issue

Code of Conduct

[X] I have used the search function to check if an issue already exists
[X] I agree to follow this project's Code of Conduct

Hey @Sahilll15, I think we're only fetching offline hackathons for now. Could you please re-check this?
Also there is another similar issue for adding filters overall like duration, date etc


[APEXMALHAR-175] KeyValPair isn't automatically sticky partitioned for key

Updated KeyValPair to override hashCode to support sticky partitioning by key.

@ilganeli : This is not required. It is intentional. For your use case you can use https://github.com/apache/incubator-apex-malhar/blob/master/library/src/main/java/com/datatorrent/lib/util/KeyHashValPair.java

@gauravgopi123 should the relevant JIRA be closed then?

@ilganeli Yes..


[VS Code] Joining collaboration session: ENOENT: no such file or directory, open '/home/kunal/.vscode/extensions/ms-vsliveshare.vsliveshare-1.0.18/modifiedInternalSettings.json'

Error:
Joining collaboration session: ENOENT: no such file or directory, open '/home/kunal/.vscode/extensions/ms-vsliveshare.vsliveshare-1.0.18/modifiedInternalSettings.json'
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
1.0.18

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.33.0

platformName
Linux

platformVersion
4.18.0-17-generic

Hey @autocrat137 , this is the first time we've seen this issue. Your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

Closing this issue due to inactivity. Please re-open it if you're continuing to encounter this problem. Thanks!


add favicon to /docs/static

Awesome work resium!
Just one small point to make it prettier, favicon is missing in /docs/static. Can we add it?
I can quickly create my first contribution if you can provide the favicon :D

Thank you. You can send a pull request if you want to do.


Feature/edit history subgraph

Fixes #282 .
Changes proposed in this PR:

fetched Subgraph data for edit history component
included EditHistory component in the asset content
removed Published and Updated sections

woah, it just works! That's already shippable although it's in draft mode
Looking at https://market-git-feature-edit-history-subgraph-oceanprotocol.vercel.app/asset/did:op:fcB47f5781F14Ed7E032BD395113b84C897aA23f

as for the ordering, instead of figuring out to sort the datatokens.updates data in js, we might want to switch to metadataUpdates query for this, since this we can sort in GraphQL then.


singleLogoutService setting for SP not used?

In the settings.json file under the sp section, you can set urls for assertionConsumerService and singleLogoutService.
In the login request, the assertionConsumerService is sent to the IDP via the AssertionConsumerServiceURL attribute and the IDP then uses that url to post the login response assertion. That works great for login.
For logout, however I don't see the SP's singleLogoutService value being sent to the IDP at all (I looked in the python-saml code and I only see the singleLogoutService value for the IDP being referenced).   My assumption is that I can specify a url in the logout request where the IDP should post a logout response similar to how I specify where it should post the login response.
Currently, the IDP is posting to the url I originally set up in the metadata file I sent to the IDP manager. I assumed I could override that location in the logout request the same way I override the AssertionConsumerServiceURL in the login request.
Am I misunderstanding how this should work?  Do I need to have something enabled on the IDP to make this work?

In SAML, the IdP an the SP entities exchange metadata (in order to set the circle of trust), So each entity knows the endpoints of the other involved entities.
Related to the "AssertionConsumerServiceURL" issue, the AuthnRequest sent by the SP to the IdP is referenced in the AssertionConsumerServiceURL value (as you noted). But notice that this value is optional. IdP must know the SP ACS endpoint (The IdP MUST ensure that the value specified is in fact associated with the SP, for example with the metadata exchanged)
Reading the SAML protocol documentation I don't see that a LogoutRequest can define the Single Logout Service endpoint in the way that you expected.
Why you want to override the endpoint location by the data of the request instead of have the correct metadata updated?

@pitbulk I wanted to override for convenience during local development, but if that's not how it's generally supposed to work, then that's fine.  Here's what I'm not understanding:

If you aren't supposed to override the callback location via request, why is the AssertionConsumerServiceURL attribute even sent in the request?  Is it just an additional way of verifying with the IDP that the request is actually coming from the SP?

If you aren't supposed to override the callback location, then why is that override actually working for me during login (ie. the AssertionConsumerServiceURL value I'm sending in the request is being used by the IDP instead of the stored metadata value)? Does that just mean the IDP is mis-configured?  ie. Is it not supposed to work that way?

I don't wrote the SAML protocol so don't know what the authors thought.
I can say that you can trust the AssertionConsumerServiceURL of an AuthnRequest if is signed, otherwise you can't trust it if it is different that the once registered as the metadata of the SP.   (An attacker can make than an IdP returns a SAML Response to an endpoint that he controls with user data).


Add test env command to Nox

Closes #1292
Closes #1417
Code Changes

[x] load the demo resources as part of the setup
[x] add a nox command for a comprehensive test environment
[x] add a docs page about the testing environment
[x] remove the secrets.py file in favor of .env
[x] update the .env file in 1Password with the current working version

Steps to Confirm

[ ] read the testing_environment.md docs page to get up and running (and note any omissions)
[ ] test some stuff:

[ ] log in to the admin UI
[ ] log in to the privacy center
[ ] export a datamap

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation Updated:

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md

Description Of Changes
This PR adds a test mode to nox that does the following:

builds all images for the application (webserver, admin UI and privacy center)
seeds data for testing
opens a shell and spins up the application + UIs
This seeds enough data to enable playing/poking around with the admin UI, privacy center, API and CLI in a realistic, user-like scenario.

There is also a proper docs page describing how to utilize this new feature

@seanpreston @sanders41 gonna need some help on the mypy issue here. I don't want to just ignore it, but I also don't know enough about what ops is doing there to fix it properly

This function is a new one for me, I haven't see it before. Looking at it here this is what I think is happening, and a fix. secrets is a postgres json field and mypy doesn't seem to understand this, so rather than using type inference the type could be specified when creating the variable. The second issue is secrets could be None so that also needs to be handled. This fix passes mypy, but I haven't run it through the test suite yet.
Starting here
        from typing import Any, Dict, Optional. # at the top of the file

        secrets: Optional[Dict[str, Any]] = connection_config.secrets

        token = jwt.encode(
            {
                "aud": "doordash",
                "iss": assign_placeholders(self.developer_id, secrets)
                if secrets
                else None,
                "kid": assign_placeholders(self.key_id, secrets) if secrets else None,
                "exp": str(math.floor(time.time() + 60)),
                "iat": str(math.floor(time.time())),
            },
            jwt.utils.base64url_decode(
                assign_placeholders(self.signing_secret, secrets)  # type: ignore
            ),
            algorithm="HS256",
            headers={"dd-ver": "DD-JWT-V1"},
        )

that makes sense to me, can you push up the change? I have short toes, don't worry about committing straight to PRs 🙂

My dirty commits are all over this branch, but I'll say that this is already very much ready to merge so that we can get some more mileage on it to aid in testing the current sprint and next, etc.
However a few polish items I'd love to ask would be:

For me, the fides server container doesn't start until I touch at least one file on /fides; it seems like the uvicorn ... --reload fides.api.main:app doesn't run until at least one file changes and forces a reload?
Can we have a test-specific fides.test_env.toml that is used for this? That helps us create distance between the fides.toml in-dev (which is way too over-configured right now) and what is used for testing
Can we have a test-specific docker configuration (e.g. docker-compose.test_env.yml?) that doesn't run all the integration test databases? It currently runs 11 containers which is an enormous amount of RAM and CPU to get this built and running... we can exclude mysql & sqlserver at least, which would free up a bit of space!

That said... I don't need us to optimize it further, yet. I just find that it takes a really long time to build and run (so if we could remove a couple containers, that helps), and I'd like it to be easier to specify the TOML file to be used when testing.

@NevilleS awesome, I'll merge then and open tickets for all of the follow-up stuff


clipping planes range fits geometry

Small question, in JSRootPainter.jquery.js I am trying to make the "focus" option available from the browser sidebar, but am having trouble finding the right context to call "focusCamera". I think it is simple but can you show me how I can access this method here?

Hi Peter,
It is not in the JSRootPainter.jquery.js.
There is function in JSRootGeoPainter.js called JSROOT.GEO.expandList().
It is used to provide items for lists with TGeo-related objects (nodes, materials,...).
Such items are displayed in the browser.
One could configure that such item get extra entries in the context menu.
Example you can find in JSROOT.GEO.expandVolume.
Probably, I provide preliminary code, which you can extend.

The "Cutting range based on geomtry size" doesn't work properly. At least on z axis with the lhcb geometry (https://bellenot.web.cern.ch/bellenot/Public/GitHub/?json=../Latest/files/lhcb.json)

@PWhiddy @bellenot
At the moment some functions in geo painter may be broken, when JSON file is used.
For the moment I do all kind of tests and developments for TGeoManager. Like
this link.
Later I will adjust code for the JSON files as well.

@PWhiddy
Now there is function JSROOT.TGeoPainter.prototype.focusOnItem.
It is dedicated to make focus for selected item.
It should appears as "Focus" command for the items from TGeoManager Nodes hierarchy (not in Volume).
For the moment I only calculate transformation matrix for the item and item dimension.
You should complete function.

@PWhiddy @bellenot
Actually, in "Cutting range based on geometry size" sign is wrong. Probably, only for Z axis.
It could be nice seen in the hades geometry:
http://jsroot.gsi.de/dev/examples.htm?more#tgeo_hades


How to use stylus in .vue style tag with lang attribute

First of all, forgive me if I'm talking nonsense 😅
Hello everyone, I'm trying to use stylus-loader just like we do with sass-loader, however I do not get the same result:
With sass-loader it runs fine, but when trying to use the stylus-loader an error is thrown:
Module build failed: Error: Can not find module 'stylus'

I tried to just install: npm i --save-dev stylus-loader, just like I did with sass .. I have not tried any configuration in nuxt.config.js since I imagine it should already be "native" since version 1.0
How can I use stylus in .vue components?

This question is available on Nuxt.js community (#c2385)

Hi,
add as dependency (or dev dependency) this packages:
yarn add stylus stylus-loader # or use npm install

In package.json
"stylus": "^0.54.5",
"stylus-loader": "^3.0.1"

Perfect @EllenFawkes, I was forgetting to install the stylus as a dependency.
Thanks for the quick response!

I had some problems with webpack 4 (nuxt-edge). But re-installing as @purrplingcat said, made it. Since 26th Feb is<EMAIL_ADDRESS>

It does not work for me in nuxt-edge. Is this the correct way?

@gianniskarmas I had to install the stylus loader manually as I was saying. Nuxt-edge is not stable yet. Can't wait to use it in production. But we have to be patient at the moment hehe. ;)


xpPackageDevel dirtyrepo, sysinfo

xpPackageDevel https://github.com/externpro/externpro/blob/24.04/cmake/xpfunmac.cmake#L1909 should append a dirty repo indicator (suffix -dr) to git describe --tags output so CPACK_PACKAGE_VERSION indicates that the package includes changes that haven't been committed (similar to what smanders/externpro does https://github.com/externpro/externpro/blob/24.04/cmake/macpro.cmake#L238-L242)
it would also be helpful for xpPackageDevel to record system information and include this in the devel package (again, similar to what smanders/externpro does https://github.com/externpro/externpro/blob/24.04/cmake/macpro.cmake#L257-L277)

completed with commits to main branch referenced above


Update to FMS geos/2019.01.02+noaff.1

This PR updates FMS to use geos/2019.01.02+noaff.1. This update adds -no-heap-arrays when compiling with Intel. Turns out this was how it was done in CVS time, but in the transition to Git it was lost. It apparently didn't matter until we started looking at moving to Intel 19.1.
Running MOM5 and MOM6 with Debug only works with this flag (or no heap-arrays at all, see https://github.com/NOAA-GFDL/MOM6/issues/1177).
I've done a bit of testing with GEOS and found no issues, but I'll do a comprehensive test suite to make sure. For now I'll block with a label.

The code seems zero-diff with Intel (and can't affect any other compilers), and it runs with and without Replay, Release and Debug.


Patch for credential presentation kli command

In credential presentation, ensure the presenter is introduced to the recipient of the presentation in the event that the presenter is not the issuer or issuee of the credential.
Signed-off-by: pfeairheller<EMAIL_ADDRESS>

Codecov Report

Merging #402 (e6bbcfb) into development (50ad895) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #402   +/-   ##
============================================
  Coverage        92.71%   92.71%
============================================
  Files              116      116
  Lines            36951    36951
============================================
  Hits             34260    34260
  Misses            2691     2691

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


MSOutput: do not fail workflow if there are containers unknown to Rucio

Fixes #10368
Status
not-tested
Description
This PR provides two changes:

bug-fix to producing/consuming workflows where not all the output datasets have been produced and published to DBS/Rucio. In the current state, MSOutput keeps trying to produce them over and over, forever!
create an alert (email + slack notification) via AlertManager Prometheus system, for each workflow with their list of missing output datasets.

Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

FYI @haozturk

test this please

test this please

Testing this on my VM will be quite time consuming. So I'm going to merge it and use testbed to run the final testing.
Review and comments are welcome at any time though.


Artist Cover

Congratulations for the wonderful project, I have one question
How can i set artists image manually?
I'm doing a personal streaming server for some music that me and my friends make, so there is no official image on discogs or similar sites. From your code I understand that artist images can be attached only via discogs.
Thanks for your time.

Sorry for the late reply. Black candy can't set artists image manually, cause it hasn't had this feature yet.  I will take some time to implement this feature. Thanks.

No rush,
I'm no expert in Ruby, but I can try to get my hands on.
Thanks


Block input?

Hi, thanks for sharing this library! I'm currently using it for implementing a mod for a game I'm playing, however I'm wondering if it's possible to block certain keys from being actually passed to any applications running on the system? For instance, if I press W it will be captured by my application, but not by the game.
Thanks in advance!

Hi @CactusPie !  You can definitely do what you're wanting.  Here's an example:
    public static class DisallowKeys {

        public static async Task Start() {
            Console.WriteLine("Disallowing the 'W' key on the keyboard for 10 seconds");

            var Keyboards = new List<IKeyboardEventSource>();
            for (int i = 0; i < 1; i++) {
                Keyboards.Add(Capture.Global.KeyboardAsync());
            }

            foreach (var item in Keyboards) {
                item.KeyEvent += Item_KeyEvent;
            }

            await Task.Delay(1000 * 10);

            foreach (var item in Keyboards) {
                item?.Dispose();
            }

        }

        private static void Item_KeyEvent(object sender, EventSourceEventArgs<KeyboardEvent> e) {
            if (e.Data.KeyDown?.Key == WindowsInput.Events.KeyCode.W || e.Data.KeyUp?.Key == WindowsInput.Events.KeyCode.W) {
                //Tell the OS to ignore this key
                e.Next_Hook_Enabled = false;
            }
        }

    }

Awesome! Thanks a lot


Exclude certain weights from weight loading

Nice Job! Seems like we can choose and load only the modules of the network we need.


Technical User (result count & load button)

Hi @oyo we need the result count and load button in the technical user page.
Can you please check and help to get the function available. I think I have a  too much or I miss a
Would be nice if you can check and fix it

Hi @oyo we need the result count and load button in the technical user page. Can you please check and help to get the function available.

@jjeroch I just raised PR for the entire technical user account functionality - please check this out https://github.com/catenax-ng/product-portal-frontend/pull/210

closing this because already implemented with the PageLoadingTable component


Starting Recording/Stopping Recording flashes on the record screen at different times

Not sure if it's the background service running but I see these labels at odd times.

I think it's primarily for debugging; Joe would probably know whether it's still needed.


Laps steps

Hi, I believe walker is mean to also show steps per lap, is this correct as a body seem to get that information.

Hi @eversonl. It doesn't measure steps per lap I'm afraid. On screen, it only shows two step-related values: the total number of steps for the day, and the total for the activity. In the metadata that it collects and inserts into the FIT file (which ends up viewable in the activity stats in Garmin Connect) it will average capture steps per KM (or steps per mile if your watch is configured to use imperial units), which is potentially the same thing as steps per lap if you are using auto-laps with a lap interval set to 1 KM (or 1 mile) - but I've never specifically put steps per lap in as a feature, and don't particularly intend to I'm afraid.


bug fix

bug fix in derivative chain client

here is wrong. Previous code is correct.
https://github.com/InjectiveLabs/sdk-python/pull/38/files#diff-937fe9385d5c0fd1e481bca925a6a031f9bbcac6bfed150f27f7ab735f4cff17L183-R188


Error when composer update

Hello,
I installed caffeinated and realized that it gives "exception 'ErrorException' with message 'array_multisort(): Argument #3 is expected to be an array or a sort flag' in /Applications/MAMP/htdocs/myproject/vendor/caffeinated/modules/src/Caffeinated/Modules/Modules.php:264" error when i try to use composer update command.
Is it a bug?
Thanks.

Same error I was getting.
I down graded to:
		"caffeinated/modules": "dev-master#0da309eb34c135bf08d270dc5c4166019934ed67",

It doesn't have the latest publish commands but ... it works.

f99dcec0524163d0bfbe48e382e44d49a1a79b42 should fix this issue; let me know if it clears things up for you two!

hmmm ...
updated to newest commit.
With and without the Modules directory (even just an empty directory) I pretty much get this error on php artisan
exception 'ErrorException' with message 'Undefined index: enabled' in /Users/.../l5/vendor/caffeinated/modules/src/Caffeinated/Modules/Modules.php:264
Stack trace:

Browser is just a white screen of death. I even have whoops enabled as per https://laracasts.com/discuss/channels/general-discussion/whoops-removed-from-laravel-5?page=4

So far so good on a clean install. Now I need to see if it works beyond "php artisan" :-)


Fix Missing Maid Headpiece in Icons (Issue #523)

This pull request addresses the missing maid headpiece from the logo in the icon images. The headpiece has been added to all relevant icons, ensuring consistency with the overall brand identity. (Issue #523)

Thanks for the fix


Shift event handling methods out of UiManager

UiManager is catching events such as JumpToListRequestEvent which then calls methods to cause the PersonListPanel to scroll to the corresponding location.
There is no need for a high-level component such as UiManager to catch these events. Rather, the individual components ought to catch these events, as they are already currently handling these events. Using the example given above, the PersonListPanel ought to catch the event instead.

The current design assumes MainWindow is a container for GUI widgets. UiManager is the guy who manages GUI-wide logic of the UI (i.e. logic that doesn't belong in one of the individual widgets), which includes handling certain events but not all. The objective was to distribute the responsibilities and prevent MainWindow getting bloated.

@damithc currently, other GUI components such as ResultDisplay and StatusBarFooter catch their own events as well. As such, there's inconsistency (in the example given in the issue message, the event that PersonListPanel is supposed to handle is being caught by UiManager), and we should perhaps standardise them.


[DOCFIX] Add a note to the quick start guide

@calvinjia

LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12931/
Test PASSed.


RTLify the right click menu of unrecognized words

Using Windows 10, Poedit 2.0.7.
STR:

Open any PO file in RTL Poedit
In the translation, start typing words that do not exist
Right click one of these words
Context menu is LTR'd

This menu is created by Windows' text control and can't be directly controlled or even modified (hence the lack of other edit items in it that you would normally see), so I don't think I can do anything about it short of rolling out my own spellchecker...

rolling out my own spellchecker…

That (i.e. using ISpellChecker services, but rendering the underlining manually) would probably solve other issues with this menu (), though, would allow merging it with the normal right-click menu, and would allow basing the spellchecker on translation language and not current keyboard (as Win10 does). So it's definitely something worth considering.


Add .editorconfig

Description
While I was reviewing code, i noticed trino has .editorconfig for coding convention.
Even if we are using Airlift style, i think we should also add editorconfig for same reason

Additional context and related issues
https://github.com/trinodb/trino/pull/2151

Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
*

LGTM

Cool.... over time we should update for markdown as well .. but that can come later


Is there a way to combine rate limits?

What is the optimal way to combine two rate limits together?
We could define:
export const ratelimit = {
    a: new Ratelimit({
      redis,
      limiter: Ratelimit.fixedWindow(1000, "60 s"),
    }),
    b: new Ratelimit({
      redis,
      limiter: Ratelimit.fixedWindow(3, "10 s"),
    })
  ]

And then await both:
await Promise.all(
ratelimit.a.blockUntilReady("a"),
ratelimit.b.blockUntilReady("b")
)

But this doesn't assures that once resolved none are blocked as one could resolve much faster than the other one.

Ended up implementing this but unsure if there is a better way:
export const rateLimit = async (domain: string, maxRetries = 3) => {
  for (let i = 0; i < maxRetries; i++) {
    try {
      const { success, pending, reset } =
        await ratelimit.handinger.blockUntilReady("api", 180_000);

      const msToReset = Math.max(0, reset - Date.now());

      const { success: successDomain, pending: pendingDomain } =
        await ratelimit.handingerDomain.blockUntilReady(domain, msToReset);

      waitUntil(Promise.all([pending, pendingDomain]));

      if (success && successDomain) {
        return;
      }
      throw new Error("Handinger Ratelimit exceeded");
    } catch (error) {
      if (i === maxRetries - 1) throw error;
      console.warn(
        `Rate limit retry ${i + 1}/${maxRetries} failed. Retrying...`,
      );
      await new Promise((resolve) => setTimeout(resolve, 10000));
    }
  }

  throw new Error("Handinger Ratelimit exceeded");
};

Hey @david8z, what is it that you're trying to achieve here? If you could provide more details about the logic/purpose, I could come up with something.

Hey @fahreddinozcan basically the idea is finding an efficient way of combining two limits.

It would be beneficial to implement multiple rate limits. There are various reasons why one might require multiple rate limits, such as:
Scenario where we provide a rate limit for the current month and another rate limit for a per-minute or per-day rate limit for abuse protection. A function that efficiently combines multiple rate limit validation would be helpful.


many updates to the interactive plot lib.

See new features in:
https://www.youtube.com/watch?v=bC409aeA8p4&ab_channel=asafrozen
first, 2D graph support: copy-paste, delete etc. convert from 2d to 1d using "l"(lines), and back using "p" (for pcolor)
added "r" (rectangle) to select data regions and copy/ delete them. useful to clean data or copy only part of 1D/2D regions.
when using rectangle and single click - will select a single line from the 2D
Fit decay sine * exp now works great.
the output of fit now properly printed in the console for pycharm support
right-click on fit line will extend it across the visible axis.
Added "t" (transpose data) for 1D or 2D
added "v" (Voronoi). to split the screen using a voronoi graph, to count populations in qubit IQ blobs.
added commands (":"), for example, type ":log" anywhere to change the colormap to log scale in a 2D image
and many other bug fixes.

I think that now I was working on the correct branch

@yomach the checks pass now (format), we've added changelog and updated the readme.
is there anything else you want to review?
thanks :)

Looks good :) Haven't checked the functionality, but as long as Asaf played around with it.


Convention mappings not supported by the configuration cache should be reported

Given a Gradle 7.4.2 project with plugin id("org.sonarqube") version "3.3" applied and the configuration block
sonarqube {
    properties {
        property("sonar.scanner.dumpToFile", layout.buildDirectory.file("sonarqube.properties").get().asFile.absolutePath)
    }
}

If you now execute ./gradlew --configuration-cache sonarqube the sonarqube.properties file is properly created.
If you now delete the file and execute the same command again, the file is not recreated, because the task quits its action eagerly with the message Skipping SonarQube analysis: no properties configured, was it skipped in all projects? as it sees no configured properties.
I guess the problem is the convention mapping usage here: https://github.com/SonarSource/sonar-scanner-gradle/blob/3.3/src/main/java/org/sonarqube/gradle/SonarQubePlugin.java#L93-L96
A fix surely has to be done in the plugin to be configuration cache compatible.
The issue here is more to eventually find a way to have a configuration cache problem raised in similar situations.

The issue is in the backlog of the relevant team and is prioritized by them.
Sorry for the late reply.


Unclear instructions for MFC walk-through

I'm reading the "Walkthrough: Using the New MFC Shell Controls" page.
https://docs.microsoft.com/en-us/cpp/mfc/walkthrough-using-the-new-mfc-shell-controls?view=msvc-160
What appears in Visual Studio does not match the directions...
Under "Prerequisites" it contains the sentence...

"Make sure the Desktop Development with C++ tile is checked. Under Optional Components, check the MFC Support button."

In my Visual Studio 2019 >Modifying>Visual Studio Community 2019>16.11.12 window there is no item labeled "Optional Components"
Do you really mean to refer me to the "Optional" heading under "Installation details"?
There is also no button labeled "MFC support"
Do you really mean that I should enable the checkbox labeled "C++ MCF for latest v142 build tools..."
See screen capture below...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e42d62b6-ccf2-e5e6-fb25-25100c70fe38
Version Independent ID: 51ede8ba-a8b3-0868-bee1-e2635309afb6
Content: Walkthrough: Using the New MFC Shell Controls
Content Source: docs/mfc/walkthrough-using-the-new-mfc-shell-controls.md
Product: visual-cpp
Technology: cpp-mfc
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

Hello @robcat2075, thank you for pointing this out.
This documentation is older and we have been prioritizing getting content out for newer technology that we've added support for, such as the standard template library.
I will add updating this tutorial to reflect the latest tools to my list of things to do, but it may be a bit until I can get to it.

But... what is the correct action to do here in this tutorial?
Are the items I pointed to indeed what is intended by the text?

@robcat2075 , yes, choose the options you have called out in your screenshot.
If you need support for MFC, consider the Developer community.
There is a MFC post on stackoverflow here that may be useful if you have more questions.

Tagging for future followup.

Closing as part of backlog grooming. We have accrued more issues than our resources can manage.
Criteria for closing include severity of the issue, how broadly applicable it is, whether the issue enough information is provide to act on the issue, etc.
If you think this issue should not have been closed, reopen it with a comment explaining why.


[tflite label_image] get output size from output tensor

get output size from the output tensor
add a command line option to specify number of results

address the issue https://github.com/tensorflow/tensorflow/issues/20485 found by @jbuisson1

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


game_handler: Use avatars instead of emails in game handler messages.

The cases I've seen & replaced the occurrence of user email with user avatar are:

when a player wins,

when a player quits the game, and

when a player joins the game.

telling a user about his turn

Please let me know if I've missed any case...

Merged!  Thanks @Rishabh570!  A good follow up would be to extract a small function to make the avatars, just because the syntax there is subject to change, and that's probably an easy detail to encapsulate.


profile_name option

To use named profiles from ~/.aws/credentials

Coverage decreased (-0.8%) to 56.818% when pulling fc9958799a92a133d1a7589b5434954171ccded4 on mialinx:master into 39100e13dafbc23dbf7407dfeab607c3d48511d4 on Miserlou:master.

This is a great idea, I'll merge now but I think I'll refactor and merge it into core


Confirm button does not close the editor

Thank you for the plugin haydenull.
I would like to point out an issue with the "Confirm" button in the editor.
It saves the changes made to the table, however, to exit the editor I need to click cancel after I have already clicked confirm (which does not let me exit the editor)
To simplify:
Expected: Confirm should save changes and close the editor
Reality: Confirm saves changes but does not close the editor
I am using the 0.9.19 Logseq version

On top of this, pressing Esc should also be mapped to saving and closing the table editor.

me too


[PAPI-336] Inject Swagger Configi

Inject swagger config within a JS file allowing for dynamic server urls when running the project vs static server urls within openapi.yml.
Now swagger environments will load correctly and openapi.yml imports default to testnet

cc @drmathias relative URLs didn't work within ReadMe docs, it defaulted https://example.com there and calls would work. Found a happy medium, swagger ui config is included within an injected JS file where we can make the changes we need at runtime.
Going to merge it but still tagged for the FYI


react 0.14.0-rc1, peerDependency issue

Hi,
I have "react": "0.14.0-rc1" in my project's package.json. When I try to install react-mdl, I get an error because of the peerDependency on react.
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>|| ^0.14.0

Thanks

See #59
If you use npm@3 there should be no problems with it.

Sergey, thanks for the quick response!
I got it to work now, after upgrading to<EMAIL_ADDRESS>The error became just a warning now:
npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^0.14.0 but none was installed.

At least it did install react-mdl!
Thanks!
Bruno


Issue Test

Test for Notion Bridge with GitHub -- Functionality test

Issue Title:Issue Test
Issue Updated Status: closed


Model.get_mutations_df() output

should have wide, and tall output options.

Closing as this is now in the #153 issue


[[FIX]] Improve tokenization of RegExp literals

Coverage remained the same at 100.0% when pulling 70842927e9fc8adf4c78d8cecb226a5a1a2310d8 on jugglinmike:improve-regexp-tokenization into 5e36b790bcafdcca9e9b01d80bc966fc2c1a0a85 on jshint:master.


2022.X HA version

The new Ha is  need to change some things (device state atr.)
WARNING (MainThread) [homeassistant.helpers.entity] Entity sensor.pollen_adatok (<class 'custom_components.pollen_hu.sensor.PollenHUSensor'>) implements device_state_attributes. Please report it to the custom component author.
if possible, please fix it.
Thanks!

i think it fix it:
https://github.com/amaximus/pollen_hu/pull/4


Raw File Output using FileChannel to write inbound/outbound traffic to session files

Hi, I have used netty to rewrite all networking in a large legacy application, and just want to say i love this project so much its made everything unit-testable etc.
But i was unable to find an approach to add to my pipeline to write inbound traffic to a inbound.dat or an outbound.dat respectively just writing the raw bytes to file.
Ideally i wanted to do this:
@Override
    protected void setupPipeline(SocketChannel socketChannel) {
        socketChannel.pipeline()
                .addLast("feedIdleStateHandler",
                         new IdleStateHandler(0, 0, 10)
                );
        socketChannel.pipeline().addLast(new IXDecoder());
        socketChannel.pipeline().addLast(new IxMessageHeartbeatingInBoundHandler((m, c) -> {
            /// some business logic
        })
        {
            // write to recovery channel
            @Override
            protected boolean sendDownstream() {
                return true;
            }
        });
        socketChannel.pipeline().addLast(new InBoundTrafficLogger("inbound.dat", append))
        socketChannel.pipeline().addLast(new OutBoundTrafficLogger("outbound.dat", append))

I am happy to try and implement something akin to the log handler implementation but the only way i was able to implement this requirement was to extend ChannelInboundHandler and in the last pipeline step do a ctx.fireRead() to then get the channelread0 callback and write to a fileoutput stream. The message object i decode has a getting for the raw bytes for reference so i didnt have to do anything there but this could be something added early on in the pipeline before any decoder or logic to avoid the decoding issue to objects.
I might have been missing something really obvious so i thought i would ask here first before attempting a patch.

@redbrain there is nothing build in into netty. Keep in mind that file IO may block so you should off-load this to another thread.


Fixed broken link to Flutter Favourite badge in device_info_plus README

Description
The path used to display the Flutter Favourite badge in the README of device_info_plus package was incorrect, this PR fixes that path and now the badge is displayed as intended in the README.

These will appear on the next releases. I will not do a release now tho.


add features

-add some logic to findout if a comment help is present, maybe display it like get-help ...
-add some logic to allow to add a comment generic comment help.  with maybe a description parameter ... or maybe with dynamic parameters based on the function parameter we want to comment
-add the possibility to extract all functions in a separate ps1 file (a reverse build sort of ... ) done in https://github.com/LxLeChat/PSFunctionExplorer/commit/c7d2b44deb808e31fef8803ef7250cfd22e87b5c

-add a function to explore a simple script and outputs all it's internal commands .. basic stuff !
-maybe add the possibility to explore a scriptblock too...

Any change this could get released? I'm using azure functions. And I would love to graph them using your module. But azure functions always run a single run.ps1 file. From there I call several ps1 files which incorporate quite some script blocks. And I use a few modules in the process.
So what you're mentioning would exactly fit my purpose.

hi @X1pheR
i'm not currently working on the module.
i made this module too : https://github.com/LxLeChat/FlowChartCore  It can graph scriptblocks. (it's mainly inteded to scripts, but you can pass scriptblocks too ) (the module is not published but i can publish it if needed )
the thing with "sub" scriptblocks is that they are quite difficult to represent on a graph ... not found any beautiful way to do it :( i dont know how to explain it cleary ... but i've tried psfunctionexplorer and flowchartcore on some big code base, and sometimes the graph are.. how to put it ... you can't see shit ! :)
but if you have ideas and want to contribute, no problemo ! you are welcom

Thank you for the quick answer! I'll look into it and will come with suggestions if any 😇


Laverna App not executing on Fedora 26

I've downloaded the linux x64 version and it isn't running or returning answer after open the executable

@vyniciuspontes Are we talking about Laverna 0.7.51 that I just updated?
Cause I tested it over 2 computer (1 fresh and 1 2 years old) and it's working :thinking:


syscalls: arm: Fix possible overflow in is_in_region function

This function is widely used by functions that validate memory
buffers. Macros used to check permissions, like Z_SYSCALL_MEMORY_READ
and Z_SYSCALL_MEMORY_WRITE, use these functions to check that a
pointers passed by user threads in a syscall.
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

@ceolin I've restarted Shippable a few times, but still keeps failing - is it because of something in this PR?

@ceolin I've restarted Shippable a few times, but still keeps failing - is it because of something in this PR?

Answering myself: seems like it is:
INFO    - /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/sanity-out/mps2_an385/tests/kernel/pipe/pipe/kernel.pipe/handler.log
ERROR   - *** Booting Zephyr OS build v2.2.0-rc3-25-g426ddd95ee73  ***
Running test suite test_pipe
===================================================================
starting test - test_pipe_on_single_elements
E: syscall z_vrfy_k_pipe_put failed check: Memory region 0x200001c1 (size 0) read access denied
E: r0/a1:  0x00000000  r1/a2:  0x00000000  r2/a3:  0x00000000
E: r3/a4:  0x00000000 r12/ip:  0x00000000 r14/lr:  0x00000000
E:  xpsr:  0x00000000
E: Faulting instruction address (r15/pc): 0x00000000
E: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
E: Current thread: 0x200005d8 (unknown)
Caught system error -- reason 3

@johan there are two issues that we need to figure out how to handle

There is one pipe tests that pass a 0 data buffer. Is it valid ? 0 data buffer was causing and underflow and magically going to implementation function. I can put a new test in the verification function to return 0 in that situation and not going to check the memory buffer

poll test is failing for the same problem, on test with 0 events. Same thing the issue above, but here is more confuse because of the expected behavior, currently with 0 elements it returns EAGAIN when timeout expires, what is not possible to do in the verification function. I could return -EINVAL (that looks the right thing), but then the test will look really weird, because when the test executes from supervisor thread it will return -EAGAIN and when it runs from user thread will return -EINVAL.

any thoughts ?

@jhedberg there are two issues that we need to figure out how to handle

There is one pipe tests that pass a 0 data buffer. Is it valid ? 0 data buffer was causing and underflow and magically going to implementation function. I can put a new test in the verification function to return 0 in that situation and not going to check the memory buffer
poll test is failing for the same problem, one test with 0 events. Same thing the issue above, but here is more confuse because of the expected behavior, currently with 0 elements it returns EAGAIN when timeout expires, what is not possible to do in the verification function. I could return -EINVAL (that looks the right thing), but then the test will look really weird, because when the test executes from supervisor thread it will return -EAGAIN and when it runs from user thread will return -EINVAL.

any thoughts ?

@andyross @andrewboie ideas ?

@ioannisg @stephanosio are you guys ok with the latest version of this PR? I'd like some more reviews than just my own before merging.

Will check this again early tomorrow morning @jhedberg

@ioannisg any update on this?

@ceolin correct me if I am wrong, but now, it seems that supplying a zero sized buffer will result in the function returning true.This is a change compared to the original behavior, so I wonder if we need that.
could this PR just fix the overflow issue?

We were wrongly accepting size 0.
if (start >= r_addr_start && (start + size - 1) <= r_addr_end)
as you can see, the second condition will always be true for size == 0
Now, at least we are not comparing and address out of the "valid" range. My initial patch was not accepting size == 0 but then it broke some tests and the behavior was different from X86. My suggestion is merge it and fix the problems and then we can decided whether or not accept 0 size buffers, this will apply to X86 and ARC as well.

Is a 0-size buffer valid inputs to these system calls? What does it mean to pass a buffer like that?

Is a 0-size buffer valid inputs to these system calls? What does it mean to pass a buffer like that?

it depends on syscall, poll for example seems to return when the timeout expires, without anything valid, pipe just return 0
IMHO these APIs shouldn't accept 0 size buffer

it depends on syscall, poll for example seems to return when the timeout expires, without anything valid, pipe just return 0

I understand the behavior, but not the semantics. Why is the test passing a 0 buffer in the first place? What is it testing?

it depends on syscall, poll for example seems to return when the timeout expires, without anything valid, pipe just return 0

I understand the behavior, but not the semantics. Why is the test passing a 0 buffer in the first place? What is it testing?

The test is testing this corner case what is valid. It is a boundary that has to be tested, the problem is if we reject 0 size buffer at memory access level we trigger an exception what the tests and APIs don't expect

The test is testing this corner case what is valid. It is a boundary that has to be tested, the problem is if we reject 0 size buffer at memory access level we trigger an exception what the tests and APIs don't expect

So is a 0 size buffer valid or not?

And what does it mean to call these APIs with a 0 size buffer?

The test is testing this corner case what is valid. It is a boundary that has to be tested, the problem is if we reject 0 size buffer at memory access level we trigger an exception what the tests and APIs don't expect

So is a 0 size buffer valid or not?

That is the trick part, currently it is, but not explicitly.  Regarding the second question, the meaning is   per basis API. Take a look in k_pipe_put
/**
 * @brief Write data to a pipe.
 *
 * This routine writes up to @a bytes_to_write bytes of data to @a pipe.
 *
 * @param pipe Address of the pipe.
 * @param data Address of data to write.
 * @param bytes_to_write Size of data (in bytes).
 * @param bytes_written Address of area to hold the number of bytes written.
 * @param min_xfer Minimum number of bytes to write.
 * @param timeout Non-negative waiting period to wait for the data to be written
 *                (in milliseconds), or one of the special values K_NO_WAIT
 *                and K_FOREVER.
 *
 * @retval 0 At least @a min_xfer bytes of data were written.
 * @retval -EIO Returned without waiting; zero data bytes were written.
 * @retval -EAGAIN Waiting period timed out; between zero and @a min_xfer
 *                 minus one data bytes were written.
 * @req K-PIPE-002
 */

According with it, if `bytes_to_write` and `min_xfer` are 0 this function should return 0, what is valid. The test is testing it. This one is easy because we can't test for this case before testing the memory access, but poll is more complicate, because it accepts 0 events and just return when the timeout is reached.

I see. Maybe for footprint/performance reasons we should leave (and document in the header) that arch_buffer_validate() on a 0-sized region is undefined behavior, and for these particular syscalls add explicit checks. What do you think? We can contemplate this for another PR. Regardless of what we decide, the API docs should be updated.

I see. Maybe for footprint/performance reasons we should leave (and document in the header) that arch_buffer_validate() on a 0-sized region is undefined behavior, and for these particular syscalls add explicit checks. What do you think? We can contemplate this for another PR. Regardless of what we decide, the API docs should be updated.

Agree. Further we can have the initial patch that invalidates 0 size buffers and properly fix APIs.
Do you want me to update this commit with that info ?

@andrewboie @ceolin I would like us to update the API and agree on the behavior when the passed size is zero before merging this PR, since this is an essential part of the patch. Ideally, I would like the test-cases and the doc-fix to come within this PR :)

Please, submit also the fix for API documentation, as well as a test that covers this corner case of zero size.

doing it.

Please, submit also the fix for API documentation, as well as a test that covers this corner case of zero size.

what exactly you want here ? I'll document that 0 size buffer is undefined behavior, we should not have test for it. That's said, pipe and poll tests are exercising this case, my opinion is that we fix  these APIs (maybe others) later.

It's not like this UB represents a security concern unless I'm missing something. Should not block this PR.

That's said, pipe and poll tests are exercising this case, my opinion is that we fix these APIs (maybe others) later.

Since we are now documenting that arch_buffer_validate cannot get a 0 size buffer, we need to open an issue for fixing the APIs related to the tests mentioned above


Fuzzy Search (Create "How To" For Users)

Currently, the full-text search is not "fuzzy" enough. It deals well with German umlauts (Händel also gets hits like handeln), but we need to think about a solution for 19th-century German spelling. If you search for "Ästhetik," for example (without the quotation marks, of course), you don't get text passages in which Hanslick spells "Ästhetik" as "Aesthetik." This is important, as Hanslick switches to modern spelling in the 8th edition, so you currently cannot get all hits on the term Ästhetik/Aesthetik in one place.

Examples are "Ästhetik / Aesthetik", "eigentümlich / eigenthümlich", "Thatsache / Tatsache", etc.

Peter Provaznik is working on a solution for ÖML. Let's get together in spring, once I have the proposals off my plate and a clear head...


allow skipping generate-release

For arm64 platform testing, we need to skip make generate-release, the same way it is done here https://github.com/openshift-knative/eventing-kafka-broker/blob/main/openshift/e2e-common.sh

/lgtm

/cherry-pick release-v1.12

/cherry-pick release-v1.14


Initial CS from MZ header does not adjust CS of entry point

The initial relative CS from the MZ header should adjust the segment of the entry point.
Steps to Reproduce

Import "test-1.exe" from test-1.zip.  This is a self-modifying DOS program that sets ERRORLEVEL 1.
Analyze.
Memory map does not have a block for segment 103e, and entry point has assume CS = 0x1000 even though the initial relative CS is 0x3e in the MZ header.
During analysis, the incorrect assumed value of CS causes incorrect references to be created.

Memory map:

Name
Start
End
Length
R
W
X
Volatile
Overlay
Type
Initialized
Byte Source
Source

CODE_0
1000:0000
1000:982f
0x9830
true
true
true
false
false
Default
true
File: test-fail.exe: 0x120
mz

CODE_1
1983:0000
1983:ab59
0xab5a
true
true
true
false
false
Default
true
File: test-fail.exe: 0x9950
mz

DATA
1983:ab5a
1983:f659
0x4b00
true
true
false
false
false
Default
false

mz

HEADER
OTHER:00000000
OTHER:0000011f
0x120
false
false
false
false
true
Default
true
File: test-fail.exe: 0x0

Entry point:
                             **************************************************************
                             *                          FUNCTION                          *
                             **************************************************************
                             undefined __cdecl16near entry()
                               assume CS = 0x1000
                               assume DS = 0x1983
                               assume SP = 0x4af4
                               assume SS = 0x2439
             undefined         AL:1           <RETURN>
                             entry                                              XREF[1]:     Entry Point(*)
      1000:03e8 ba 83 19        MOV        DX,0x1983                                       0
             assume SS = <UNKNOWN>
             assume SP = <UNKNOWN>
      1000:03eb 2e c6 06        MOV        byte ptr CS:[DAT_1000_0012],0x1                 0
                12 00 01
      1000:03f1 b8 00 4c        MOV        AX,0x4c00                                       0
      1000:03f4 cd 21           INT        0x21                                            0
      1000:03f6 c3              RET                                                      - ? -

Expected behavior
There should be a block for segment 103e in the memory map, and that segment should assume CS = 0x103e.  References should be created based on the correct CS.
Memory map:

Name
Start
End
Length
R
W
X
Volatile
Overlay
Type
Initialized
Byte Source
Source

CODE_0
1000:0000
1000:03df
0x3e0
true
true
true
false
false
Default
true
File: test-fail.exe: 0x120
mz

CODE_1
103e:0000
103e:944f
0x9450
true
true
true
false
false
Default
true
File: test-fail.exe: 0x500
mz

CODE_2
1983:0000
1983:ab59
0xab5a
true
true
true
false
false
Default
true
File: test-fail.exe: 0x9950
mz

DATA
1983:ab5a
1983:f659
0x4b00
true
true
false
false
false
Default
false

mz

HEADER
OTHER:00000000
OTHER:0000011f
0x120
false
false
false
false
true
Default
true
File: test-fail.exe: 0x0

Entry point:
                             **************************************************************
                             *                          FUNCTION                          *
                             **************************************************************
                             undefined __cdecl16near entry()
                               assume CS = 0x103e
                               assume DS = 0x1983
                               assume SP = 0x4af4
                               assume SS = 0x2439
             undefined         AL:1           <RETURN>
                             entry                                              XREF[1]:     Entry Point(*)
      103e:0008 ba 83 19        MOV        DX,0x1983                                       0
             assume SS = <UNKNOWN>
             assume SP = <UNKNOWN>
      103e:000b 2e c6 06        MOV        byte ptr CS:[LAB_103e_0011+1],0x1               0
                12 00 01
                             LAB_103e_0011+1                                    XREF[0,1]:   103e:000b(W)
      103e:0011 b8 00 4c        MOV        AX,0x4c00                                       0
      103e:0014 cd 21           INT        0x21                                            0
      103e:0016 c3              RET                                                      - ? -

Environment

OS: Windows 10
Java Version: 19.0.1
Ghidra Version: 10.3.2
Ghidra Origin: official GitHub distro

In your "Expected behavior" listing, did you manually type in
MOV        byte ptr CS:[LAB_103e_0011+1],0x1

or did you make code changes to generate that?

With some effort (split the block at 103e, set the value of CS, disassemble, clear code bytes, disassemble again, create the function, and edit the segment in the reference), I can get Ghidra to produce that exact listing.

Testing this out, I see that the segment is created in the memory map and CS now assumes the correct value.  However, the reference created by analysis is still incorrect.
                             **************************************************************
                             *                          FUNCTION                          *
                             **************************************************************
                             undefined __cdecl16near entry()
                               assume CS = 0x103e
                               assume DS = 0x1983
                               assume SP = 0x4af4
                               assume SS = 0x2439
             undefined         AL:1           <RETURN>
                             entry                                                XREF[1]:     Entry Point(*)
       103e:0008 ba 83 19        MOV        DX,0x1983                                       0
             assume SS = <UNKNOWN>
             assume SP = <UNKNOWN>
       1000:03eb 2e c6 06        MOV        byte ptr CS:[DAT_1000_0012],0x1                 0
                 12 00 01
       1000:03f1 b8 00 4c        MOV        AX,0x4c00                                       0
       1000:03f4 cd 21           INT        0x21                                            0
       103e:0016 c3              RET                                                      - ? -

(And mysteriously -- but of less importance -- the segment shows as "1000" for instruction addresses in the middle of the function.  Doing "clear code bytes" and "disassemble" causes it to show the expected segment, which then persists even if you undo.)

Yes sorry, this ticket turned into 3 separate issues being solved by 3 different people.  I'll reopen it.

We noticed the strangeness in the address displayed, which is an artifact of not handling the segment address correctly somewhere in the block creation routines.  In segmented address is keeps it separately.  However something must have pulled the offset out and used it which has the combined segment:offset in a value.
There is a change for RealMode that we've been considering that will split the CS out and not incorrectly try to compute it from the combined segment:offset value, which is what is occuring here.  It should fix the reference issue to use the correct segment.  It does mean that the CS must be set at the beginning of functions correctly.
@carlreinke, @Wall-AF, You can try it out if you'd like for RealMode programs.  There are some other issues that still need to be ironed out.  But it will allow the decompiler to know the CS value in RealMode, as well as the constant analysis.
diff --git a/Ghidra/Processors/x86/data/languages/ia.sinc b/Ghidra/Processors/x86/data/languages/ia.sinc
index 44a99bc..e02bbbf 100644
--- a/Ghidra/Processors/x86/data/languages/ia.sinc
+++ b/Ghidra/Processors/x86/data/languages/ia.sinc
@@ -753,7 +753,7 @@
 addr64: [Base64 + Index64*ss]			is mod=2 & r_m=4; Index64 & Base64 & ss; imm32=0   { local tmp=Base64+Index64*ss; export tmp; }
 @endif

-currentCS: CS is protectedMode=0 & CS { tmp:4 = (inst_next >> 4) & 0xf000; CS = tmp:2; export CS; }
+currentCS: CS is protectedMode=0 & CS { export CS; }   # can't accurately compute the 16-bit segment, rely on it being set
 currentCS: CS is protectedMode=1 & CS { tmp:4 = (inst_next >> 16) & 0xffff; CS = tmp:2; export CS; }

 segWide: is segover=0		        { export 0:$(SIZE); }
@@ -795,8 +795,24 @@
 @endif
 Mem: segWide^addr32 is $(LONGMODE_OFF) & addrsize=1 & segWide & highseg=1; addr32 	{ tmp:$(SIZE) = segWide + zext(addr32); export tmp; }

-rel8: reloc is simm8        [ reloc=inst_next+simm8; ] { export *[ram]:$(SIZE) reloc; }
-rel16: reloc is simm16      [ reloc=((inst_next >> 16) << 16) | ((inst_next + simm16) & 0xFFFF); ] { export *[ram]:$(SIZE) reloc; }
+rel8:      reloc is simm8        [ reloc=inst_next+simm8; ] { export *[ram]:$(SIZE) reloc; }
+
+@ifdef IA64
+# never use segmenting in 64-bit code
+rel16_val: reloc is simm16      [ reloc= inst_next + simm16; ]             { local target:$(SIZE) = reloc; export target; }
+@else
+rel16_val: reloc is protectedMode=0 & simm16 & currentCS [ reloc= inst_next + simm16; ] {
+	# isolate real offset, by removing shifted segment value
+	local curCS:$(SIZE) = zext(currentCS) << 4;
+	local real_off:$(SIZE) = (reloc - curCS);
+	real_off = segment(currentCS, real_off:2);
+	export real_off;
+}
+rel16_val: reloc is protectedMode=1 & simm16      [ reloc=((inst_next >> 16) << 16) | ((inst_next + simm16) & 0xFFFF); ] {
+	local target:$(SIZE) = reloc; export target;
+}
+@endif
+
 rel32: reloc is simm32      [ reloc=inst_next+simm32; ] { export *[ram]:$(SIZE) reloc; }

@@ -2089,17 +2105,17 @@
 :BTS Rmr64,imm8     is $(LONGMODE_ON) & vexMode=0 & opsize=2 & byte=0xf; byte=0xba; mod=3 & Rmr64 & reg_opcode=5; imm8   { local bit=imm8&0x3f; local val=(Rmr64>>bit)&1; Rmr64=Rmr64 | (1<<bit); CF=(val!=0); }
 @endif

-:CALL rel16     is $(LONGMODE_OFF) & vexMode=0 & addrsize=0 & opsize=0 & byte=0xe8; rel16     { push22(&:2 inst_next); call rel16; }
-:CALL rel16     is $(LONGMODE_OFF) & vexMode=0 & addrsize=1 & opsize=0 & byte=0xe8; rel16     { push42(&:2 inst_next); call rel16; }
+:CALL rel16_val     is $(LONGMODE_OFF) & vexMode=0 & addrsize=0 & opsize=0 & byte=0xe8; rel16_val     { push22(&:2 inst_next); call [rel16_val]; }
+:CALL rel16_val     is $(LONGMODE_OFF) & vexMode=0 & addrsize=1 & opsize=0 & byte=0xe8; rel16_val     { push42(&:2 inst_next); call [rel16_val]; }
 @ifdef IA64
-:CALL rel16     is $(LONGMODE_ON) & vexMode=0 & opsize=0 & byte=0xe8; rel16     { push88(&:8 inst_next); call rel16; }
+:CALL rel16_val     is $(LONGMODE_ON) & vexMode=0 & opsize=0 & byte=0xe8; rel16_val                   { push88(&:8 inst_next); call [rel16_val]; }
 @endif

 #  When is a Call a Jump, when it jumps right after.  Not always the case but...
-:CALL rel16     is $(LONGMODE_OFF) & vexMode=0 & addrsize=0 & opsize=0 & byte=0xe8; simm16=0 & rel16      { push22(&:2 inst_next); goto rel16; }
-:CALL rel16     is $(LONGMODE_OFF) & vexMode=0 & addrsize=1 & opsize=0 & byte=0xe8; simm16=0 & rel16      { push42(&:2 inst_next); goto rel16; }
+:CALL rel16_val     is $(LONGMODE_OFF) & vexMode=0 & addrsize=0 & opsize=0 & byte=0xe8; simm16=0 & rel16_val      { push22(&:2 inst_next); goto [rel16_val]; }
+:CALL rel16_val     is $(LONGMODE_OFF) & vexMode=0 & addrsize=1 & opsize=0 & byte=0xe8; simm16=0 & rel16_val      { push42(&:2 inst_next); goto [rel16_val]; }
 @ifdef IA64
-:CALL rel16     is $(LONGMODE_ON) & vexMode=0 & opsize=0 & byte=0xe8; simm16=0 & rel16      { push88(&:8 inst_next); goto rel16; }
+:CALL rel16_val     is $(LONGMODE_ON) & vexMode=0 & opsize=0 & byte=0xe8; simm16=0 & rel16_val      { push88(&:8 inst_next); goto [rel16_val]; }
 @endif

 :CALL rel32     is $(LONGMODE_OFF) & vexMode=0 & addrsize=0 & opsize=1 & byte=0xe8; rel32     { push24(&:4 inst_next); call rel32; }
@@ -2826,7 +2842,7 @@
 @endif

 :J^cc rel8      is vexMode=0 & row=7 & cc; rel8                                          { if (cc) goto rel8; }
-:J^cc rel16     is $(LONGMODE_OFF) & vexMode=0 & opsize=0 & byte=0xf; row=8 & cc; rel16  { if (cc) goto rel16; }
+:J^cc rel16_val is $(LONGMODE_OFF) & vexMode=0 & opsize=0 & byte=0xf; row=8 & cc; rel16_val  { if (!cc) goto inst_next; goto [rel16_val]; }
 :J^cc rel32     is vexMode=0 & opsize=1 & byte=0xf; row=8 & cc; rel32                    { if (cc) goto rel32; }
 :J^cc rel32     is vexMode=0 & opsize=2 & byte=0xf; row=8 & cc; rel32                    { if (cc) goto rel32; }
 # The following is vexMode=0 & picked up by the line above.  rel32 works for both 32 and 64 bit
@@ -2841,7 +2857,7 @@
 @endif

 :JMP rel8       is vexMode=0 & byte=0xeb; rel8                                  { goto rel8; }
-:JMP rel16      is vexMode=0 & opsize=0 & byte=0xe9; rel16                      { goto rel16; }
+:JMP rel16_val is vexMode=0 & opsize=0 & byte=0xe9; rel16_val                 { goto [rel16_val]; }
 :JMP rel32      is vexMode=0 & opsize=1 & byte=0xe9; rel32                      { goto rel32; }
 :JMP rel32      is vexMode=0 & opsize=2 & byte=0xe9; rel32                      { goto rel32; }

@@ -4010,7 +4026,7 @@
 define pcodeop xbegin;
 define pcodeop xend;

-:XBEGIN rel16     is vexMode=0 & opsize=0 & byte=0xc7; byte=0xf8; rel16                      { xbegin(&:$(SIZE) rel16); }
+:XBEGIN rel16_val is vexMode=0 & opsize=0 & byte=0xc7; byte=0xf8; rel16_val                  { xbegin(&:$(SIZE) rel16_val); }
 :XBEGIN rel32     is vexMode=0 & (opsize=1 | opsize=2) & byte=0xc7; byte=0xf8; rel32         { xbegin(&:$(SIZE) rel32); }

 :XEND            is vexMode=0 & byte=0x0f; byte=0x01; byte=0xd5     { xend(); }

I don't seem to have 16-bit Real-Mode apps in my suit, mine are all Protected-Mode.  Sorry.

@emteere That seems to be working quite well so far.
The only oddity is that JMP rel16 and CALL rel16 now show as JMP offset x and CALL offset x rather than JMP x and CALL x.  (Though I can't say I understand what it means when Ghidra shows offset x vs x in general.)
Shouldn't JMP rel8 also have the modified behavior?  It's also not supposed to modify CS.

Not having a constant address is the fallout from the change.  For those instruction variants the operand will be a constant display.  If analysis is run it should create a reference if the CS is known.
The offset shows up if the operand is not a Scalar/Address that matches the reference places on the operand.  Displaying offset is not ideal we could doctor the adding of "offset" for segmented addresses, if the offset matches the offset of the destination address.
We also need to add an analyzer that assumes the value of the CS at the beginning of a function.  The Java code has access to the segment value at the address.  The real issue is the information the SLEIGH has doesn't include knowledge of the CS.  It only has the merged seg:off value.
The rel8 is currently a potential issue.  I didn't want to rock the boat too much.  There are issues now with the prefix byte that could cause the segment to start showing up for rel8 in 32/64 bit, which would be bad.  As noted in #5666.  So I left it alone.  I would expect that in most normal code a JMP/CALL rel8 wouldn't be used near the end of a segment to wrap to the beginning of a segment.

I did find a case where it's still not working as expected, but I'm not sure why.  Evaluating the P-code by hand, it seems like it should do the right thing.
       103e:7419 e9 22 01        JMP        offset SUB_19b0_de1e
                                                      $U3880:4 = INT_ZEXT CS
                                                      $U3980:4 = INT_LEFT $U3880:4, 4:4
                                                      $U3a80:4 = INT_SUB 0x1791e:4, $U3980:4
                                                      $U3b00:2 = SUBPIECE $U3a80:4, 0:4
                                                      $U3a80:4 = CALLOTHER "segment", CS, $U3b00:2
                                                      CALLIND $U3a80:4
                                                      RETURN 0:8
                             -- Flow Override: CALL_RETURN (COMPUTED_CALL_TERMINATOR)

CS is set to 103e on this instruction.  The jump destination should be 103e:753e (0x1791E) but instead it ends up with 19b0:de1e (0x2791E).  (19b0 is the data segment.)


Alternate cursor movement shortcut is not applied to auto completion list

VSCode Version: 1.48
OS Version: Windows 10 2004

Steps to Reproduce:

Bind another shortcut to 'cursor up/down/left/right'.
Test new shortcut when auto-completion list is generated.

I can't move cursor focus on completion list with my alternate shortcut alt+i/j/k/l so still I must to use arrow keys.

Does this issue occur when all extensions are disabled?: Yes

You need to use list-command, e.g list.focusUp


uses bitwise operators while computing buffer size

Changes proposed in this PR

uses bitwise operators while computing buffer size

Why are we making these changes?
Introduces a micro-optimization by avoiding integer division.

Introduces a micro-optimization.

What's the specific goal? Avoiding integer division? Creating allocator-friendly power-of-2 buffers?

Introduces a micro-optimization.

What's the specific goal? Avoiding integer division? Creating allocator-friendly power-of-2 buffers?

Avoiding integer division.


Import JSON feature - in the JSON object, array of valid SNs accepts only string values but array of recalled and decomm. SNs accept both string and numbers

Release - v1.1.2
Environment - Test Automation controlled browser
Feature - Import JSON on Batches page
the import feature errors out if numbers are passed instead of string in array of valid Serial Numbers in the batch JSON object.

@adiganga2002 check to be always strings


[Op] Fix nll_loss

Description
due to low precision of fp16, accumulation will produce strange value
change to use fp32 to accumulate, it may degrade the performance
In [10]: raf.nll_loss(rb, ra.to(dtype="float32"))
Out[10]:
[9.835546]
<NDArray [1] @ cpu, dtype=float32>

In [11]: raf.nll_loss(rb, ra)
Out[11]:
[4.]
<NDArray [1] @ cpu, dtype=float16>

P.S.: I also find that the grad of nll_loss have a bigger difference about 0.0007 when use fp16
Checklist

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

@yzhliu @comaniac

Thanks @hgt312


vimPlugins.Recover-vim: init at 2018-10-22

Motivation for this change
Closes https://github.com/NixOS/nixpkgs/issues/52480
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

seems fine. Currently testing locally :)

@marsam thanks!


Unable to configure github collector

Team,
Thank you for developing such a great tool, however, we are currently unable to configure GIT and JIRA collectors.
We have an git running on our corporate server and we get the below error, Can you kindly assist.?
2016-02-23 16:31:46,032 ERROR c.c.d.collector.DefaultGitHubClient - 403 Forbidden:https://github.xx.xx.xx..com/api/v3/repos/api/v3/repos/xxxxx/depscripts/commits?sha=Eod&since=2016-02-23T16:21Z
2016-02-23 16:50:02,224 INFO  c.c.d.collector.CollectorTask - Repo Count         1        2s
2016-02-23 16:50:02,224 INFO  c.c.d.collector.CollectorTask - New Commits        0        2s
2016-02-23 16:50:02,225 INFO  c.c.d.collector.CollectorTask - Finished                    2s
Please assist. Kindly let me know if you need further info.
Thanks,

All,
Is there a way we can pass github authentication information in the application.properties file?
Kindly assist.

You should be able to.. If not its easy to modify code to accept it from properties file…
From: Sunil Tantry <notifications<EMAIL_ADDRESS>Reply-To: capitalone/Hygieia <reply<EMAIL_ADDRESS>Date: Tuesday, February 23, 2016 at 5:48 PM
To: capitalone/Hygieia <Hygieia<EMAIL_ADDRESS>Subject: [E] Re: [Hygieia] Unable to configure github collector (#362)
All,
Is there a way we can pass github authentication information in the application.properties file?
Kindly assist.
—
Reply to this email directly or view it on GitHubhttps://github.com/capitalone/Hygieia/issues/362#issuecomment-187970933.

I am using latest version of Hygieia and facing same issue of Forbidden access with GitHub private repository. Is there way to solve this??

Hi,
You need to add in your UserID and API key in application .properites file like below.
github.UserId=p710231
github.key=XXXXXXXXXXXXXXXXXXXXXXXXXXXc1
Then modify DefaultGitHubClient.java and force the response string to fetch the password from properties file
                            //ResponseEntity<String> response = makeRestCall(queryUrlPage, settings.getUserId(), decryptedPassword);
                            ResponseEntity<String> response = makeRestCall(queryUrlPage, settings.getUserId(), settings.getKey());

Thanks,

Thanks.. Its working now. Only thing I have to declare function for getUserId.


feat: extensible parallel execution

Propose simpler design for operator-level parallelization.

The parallelized plan becomes the inner plan of the exchange operator.
Modify execution to support construction of inner plan.
The parallelized operator connects with child operator and parent operator with input queue and output queue.

Visual example of new design (https://www.dropbox.com/s/nej0d7ouknpnrr2/ray-design.jpg?dl=0)

Also, have a look at https://app.circleci.com/pipelines/github/georgia-tech-db/eva/3651/workflows/f416c4c4-0a26-46ee-a7d5-60e699edb9cd/jobs/17625 to see if we can make it work with ray.

Also, have a look at https://app.circleci.com/pipelines/github/georgia-tech-db/eva/3651/workflows/f416c4c4-0a26-46ee-a7d5-60e699edb9cd/jobs/17625 to see if we can make it work with ray.

@gaurav274 I think it naturally passes (https://app.circleci.com/pipelines/github/georgia-tech-db/eva/3671/workflows/95879b2d-6a6c-4a24-9aca-295d98e92ccb/jobs/17854). However, the reuse with multiple recurrence test case fails on CI. It does pass when I test on my machine though.

Can we somehow set up the current integration tests to check the results are identical with/without ray?

Yeah, I added a test case for this as well. Ready for another review @gaurav274 @xzdandy

LGTM

PLease make the doc image part of a readme on github. We can slowly expand it moving forward. Thanks!

Please make the doc image part of a readme on github. We can slowly expand it moving forward. Thanks!

Should we have a separate readme or just add to the main readme?

Please make the doc image part of a readme on github. We can slowly expand it moving forward. Thanks!

Should we have a separate readme or just add to the main readme?

Separate readme is better

Please make the doc image part of a readme on github. We can slowly expand it moving forward. Thanks!

Should we have a separate readme or just add to the main readme?

Separate readme is better

Ok. Fixed those. I also rename ray folder to parallel to be more specific.

If bfs and dfs in abstract_plan.py are not used anymore in the new ray design, we can remove them.


Separated Bookmark and BookmarkItem

Changed the bookmark representation to make it easier to store bookmarks. There's a class BookmarkItem and objects of this class is added to the QListWidget holding the bookmarks. Within the BookmarkItem is a pointer to a Bookmark-object holding the information that can be stored.

Yes. It still works the same.


bug in readme?

there is this
    if (er) cb(er)
    cb(null, cache[arg] = data)

did you mean this instead
    if (er) return cb(er)
    cb(null, cache[arg] = data)

Ryan Dahl, God among Gods, eschewed shorthand in favor of
    if (er) {
       return cb(er)
    }
    cb(null, cache[arg] = data)

I just noticed this line has the same problem
if (cache[arg]) cb(null, cache[arg])

you need a return
if (cache[arg]) return cb(null, cache[arg])

shorthand will kill us all


Naive Bayes -Documentation

I would like to work on this issue. Pls, assign me.

I want to work on this issue. Please assign to me

Task : Create detailed documentation of the Naive Bayes ML algorithm by updating readme.md
Level-1 : 10 points

Sure @aishwaryachand  ,You have been assigned the task to create detailed documentation of Naive Bayes.
Try to submit a PR in 2 days.

@ashwani-rathee It's already 2 days .Can you please assign me this issue I have already made readme.md file for Naiye Bayes .Kindly assign me this issue .I am a Gssoc 2021 participant .I will make sure. I will make sure a PR for documentation of naive Bayes will be in the upcoming 2 Hours

I am almost done.I will make a PR by today.

@ashwani-rathee  I want to add some more  information in naive Bayes .kindky assign me the issue


Bitscope

BitScope Application Suite: DSO, Meter, Logic, Chart

Please remove the caveats, and these are good to go.

It's not a problem for me to remove the caveats, but I put them because you are invited to read the Terms and Conditions in order to downloads those applications from the BitScope site (http://my.bitscope.com/download/). Maybe I misunderstand the use of caveats, I'm going to remove them as you asked!

Please remove them, yes.
Caveats should be used only for things that pertain to the installation itself. This kind os agreement acceptance is something we’re still thinking about.

Ok, thank you very much for the explanation!

Thank you for the contribution.


PMID:7254221

increased haploidization during cellular response to UV

increased haploidization during cellular response to UV FYPO:0005164

edit file: 0f31f3a61c883d585f37ba6c581eb9e68c90b270
release: 109afb1825736d79a9dc5a7f6b323a4e71e23744


FCS-334 Skip setting user info for unauthenticated routes

https://labshare.atlassian.net/browse/FCS-334

:tada: This PR is included in version 4.9.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CASMTRIAGE-3135: Consolidate information on managing VCS passwords

Summary and Scope
Consolidates some information on managing VCS passwords to keep the information near the docs on how to access the VCS UI, and avoid duplicating information.
Issues and Related PRs

Resolves CASMTRIAGE-3135

Testing
Tested on:
NA - docs only
Test description:
NA - docs only
Risks and Mitigations
None
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

/backport release/1.0 release/1.1 release/1.2


Don't depend on the indirect base64url dependency, use Base instead

base64url is fetched via jose but is not specified in mix.exs of Joken itself. On the other hand, Joken can simply use Base.

Coverage decreased (-15.6%) to 68.817% when pulling 57ceea83d943a01c7d8917c509321b62781273d1 on PSPDFKit-labs:alco/use-base into a544038b77dfd2207fa3088b284b2fc3b98ba2ac on bryanjos:master.

Thanks!


'peers' attribute it's case sensitive, it should be not?

Hello
I've got some issues with the 'peers' attribute that broke my usage of this good cookbook.
in /recipes/server_setup.rb
...
31:  if volume_values['peers'].include?(node['fqdn']) || volume_values['peers'].include?(node['hostname'])
...
58: if volume_values['peers'].first == node['fqdn'] || volume_values['peers'].first == node['hostname']
...

We see a strict comparison of the domain name into the peers and the node domain name. But if I check the RFC 1034
3. DOMAIN NAME SPACE and RESOURCE RECORDS
3.1. Name space specifications and terminology
...
By convention, domain names can be stored with arbitrary case, but
domain name comparisons for all present domain functions are done in a
case-insensitive manner, assuming an ASCII character set, and a high
order zero bit.  This means that you are free to create a node with
label "A" or a node with label "a", but not both as brothers; you could
refer to either using "a" or "A".  When you receive a domain name or
label, you should preserve its case.  The rationale for this choice is
that we may someday need to add full binary domain names for new
services; existing services would not be changed.
...

Could you check it and fix it please?

This should probably be handled on the wrapper cookbook side or wherever the attributes are set.  Cookbooks normally don't change casing of input

Closing for now due to no response
Please reopen if you have further questions on this


Added Kotlin for Swift Developers

Added Link in Reference Section for a project about Kotlin Development for Swift Developers.
Project URL
Project URL
Description
This project focus only on Kotlin, not Android Application Development with Kotlin. I feel the need to learning Kotlin basics and building a string Kotlin foundation before jumping into Android Development.
Why it should be included to awesome-ios
It should be added in awesome-ios so that swift developers will have a hands on starting point to start development in Kotlin which will eventually lead Swift Developers to develop for both Android & iOS.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 3 link issues

Link issues by awesome_bot

Line
Status
Link

1253
301
https://github.com/hyperoslo/Keychain redirects tohttps://github.com/hyperoslo/Keychains

2584
301
http://tryobjectivec.codeschool.com/ redirects tohttps://www.codeschool.com/courses/try-objective-c

2619
Error
http://swiftsandbox.io  getaddrinfo: Name or service not known

  Generated by :no_entry_sign: Danger

What do you guys think, @vsouza @dkhamsing @naeemshaikh90?

I don't think this fits the purpose of this repository. 🤔

Agree with @victorgama .

Agree with @victorgama too.

Let's close this one, then. Thank you for the PR, @aashishtamsya!


chore: introduce ingress-types, rename ApisixTls to ApisixTLS

Please answer these questions before submitting a pull request

Why submit this pull request?

[ ] Bugfix

[ ] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues

Bugfix

Description

How to fix?

New feature or improvement

Describe the details and related test reports.

Backport patches

Why need to backport?

Source branch

Related commits and pull requests

Target branch

Codecov Report

Merging #192 (3c5b0be) into master (f5ee17f) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   47.68%   47.68%
=======================================
  Files          32       32
  Lines        1883     1883
=======================================
  Hits          898      898
  Misses        846      846
  Partials      139      139

Impacted Files
Coverage Δ

pkg/ingress/apisix/route.go
0.00% <0.00%> (ø)

pkg/ingress/apisix/service.go
0.00% <ø> (ø)

pkg/ingress/apisix/tls.go
92.00% <0.00%> (ø)

pkg/ingress/apisix/upstream.go
87.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ee17f...3c5b0be. Read the comment docs.

Codecov Report

Merging #192 (3c5b0be) into master (f5ee17f) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   47.68%   47.68%
=======================================
  Files          32       32
  Lines        1883     1883
=======================================
  Hits          898      898
  Misses        846      846
  Partials      139      139

Impacted Files
Coverage Δ

pkg/ingress/apisix/route.go
0.00% <0.00%> (ø)

pkg/ingress/apisix/service.go
0.00% <ø> (ø)

pkg/ingress/apisix/tls.go
92.00% <0.00%> (ø)

pkg/ingress/apisix/upstream.go
87.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ee17f...3c5b0be. Read the comment docs.

@gxthrj Please take a look when you have time.

@gxthrj Please take a look when you have time.

Need to update docs which contains ApisixTls.

Ok.

Need to update docs which contains ApisixTls.

Ok.

Need to update docs which contains ApisixTls.

The docs are all about CRD ApisixTls, considering the compatiblity, i didn't change the CRD name, so no doc need to be updated.

OK

Need to update docs which contains ApisixTls.

The docs are all about CRD ApisixTls, considering the compatiblity, i didn't change the CRD name, so no doc need to be updated.

OK


Need a way to handle auth

AFAICT, there is currently no way to get any kind of authentication of requests.

Are you referring to basic HTTP authentication? I could imagine building OAuth into your API with the existing functionality, but I could be missing something 😄

API Gateway supports;

API Key
IAM User signature
Custom auth

Custom Auth being a lambda function which manages OAuth or any other authentication mechanism not defined above.
I believe enabling 1) and 2) are just additional variables to pass within the API request so shouldn't be too difficult to do.

I've tried API Keys and they work fine once I set them manually (after chalice deploy)
Every time I re-deploy with chalice deploy --no-autogen-policy it overwrites my API key settings.
Is that a bug?


Bjorncs/container thread pool

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Contains the changes from #13525 (the three first commits).