OCSP client verify fails when responder requires "Host" header

Using openssl ocsp (client) to verify a certificate fails when the responder requires host header.
This is a "known" issue with startssl (startcom) responders- but it keeps tripping people up.  (It's only "known" to you once you trip over it and do the research, which is annoying.)
It is possible to work-around this with the undocumented -header switch as shown below.

-header should be documented!
ocsp (client) should send a host header with its request by default.
ocsp (client) should probably also have a -servername option

Example:
# openssl version
OpenSSL 1.0.2h  3 May 2016
# openssl ocsp -issuer root_bundle.crt -cert avh.crt -url http://ocsp.startssl.com  -CAfile /etc/pki/tls/external-roots/ca_bundle.pem   -VAfile startcom_ocsp.pem
Error querying OCSP responder
3086117020:error:27076072:OCSP routines:PARSE_HTTP_LINE1:server response error:ocsp_ht.c:314:Code=400,Reason=Bad Request
#
# # Add -header 'host' 'ocsp.startssl.com' to the command
#
# openssl ocsp -issuer root_bundle.crt -cert avh.crt -url http://ocsp.startssl.com -header 'host' 'ocsp.startssl.com' -CAfile /etc/pki/tls/external-roots/ca_bundle.pem   -VAfile startcom_ocsp.pem
WARNING: no nonce in response
Response verify OK
avh.crt: good
        This Update: Nov 23 10:23:57 2016 GMT
        Next Update: Nov 27 10:33:57 2016 GMT

This should be easy to reproduce - startcom offers free domain verified certificates (See startssl.com, "free" option).  There's nothing special about mine.
But I've attached the files used in the example.  (The -CAfile is from the Perl Mozilla::CA module).
startcom_ocsp.pem.txt
avh.crt.txt
root_bundle.crt.txt
This has been an issue since at least 2013 - see this webpage, which is where I found it documented.

Hi,
I don't think its quite correct to call this 'SNI' as this is a TLS specific handshake parameter.
I would call this 'HTTP/1.1 Host Header'.
RFC6960 specifies that OCSP over HTTP use generic RFC2616 without requiring HTTP/1.1.
It also says that other headers MAY be sent and MAY be ignored by the server.
Name-based virtual hosting the norm and for compat for modern HTTP front ends for OCSP requests
requires HTTP/1.1 with a host header.
My suggestion would be that the default behavior of the ocsp function would be to always send an HTTP host-header with HTTP/1.1; HTTP/1.0 without host header should be the switch alt behavior.

Thanks.  I agree that SNI wasn't the best description.  I fixed the original issue.
As you note, the essence is that the 'Host' header is required by OCSP responders behind name-based virtual hosts, which StartSSL's CDN (among others) uses.
I agree that sending the Host header by default is the right choice.  It should be OK to always send the Host header; HTTP 1.0 allows Host (and named VHs required it before HTTP 1.1). rfc1945 section 7.1 Unrecognized header fields should be ignored by the recipient and forwarded by proxies.  With respect to Host, HTTP/1.1 just formalized existing practice.
So OCSP could send HTTP/1.0 with a Host header as a conservative choice.  I'm not sure that an HTTP/1.1 option is required, but it wouldn't hurt.
-servername would be consistent with s_client's switch (which does imply SNI).  SNI is valid for OCSP over SSL/TLS.  Overloading it for sending a Host header over HTTP also allows for the odd case of connecting by ip address to a (non-SSL/TLS) HTTP server that requires a Host header.

What version are you using?  Can you try 1.1.0?

Rich,
As shown in the original report's example:
the original report  was generated with  OpenSSL 1.0.2h  3 May 2016  (from source)
I've also tested with OpenSSL 1.0.1k-fips 8 Jan 2015 (fedora) - using the same files (NFS)
(version -a  for both below.)
Same result: without -header host, ...  a 400 response; with -header host  I get an OCSP response.
I don't have a 1.1.0 environment (bind has problems with the API changes).
But I attached the files necessary to reproduce this to the initial report, so you ought to be able to see how 1.1.0 behaves more easily than I can setup a new machine...
Actually, it really doesn't matter what certificate you query; the failure is in the server's front end - the verify request never makes it to the OCSP responder's (name-based) virtual host.  So you can send any OCSP query to -url http://ocsp.startssl.com and should get the same results.
Based on your hint, I took a look at apps/ocsp.c here on GitHub, and there seems to be code that would add a host header (unless one was specified with -header host).  Blame shows it was introduced in commit 76e0cd12f68f0b8173bc71ee6e9ad3ca453d5a28, which git says is only in master, 1.1.0 and 1.1.0_pre.   So, assuming it works, I guess this becomes a request to backport it.
This morning, I also get a rather confusing error (both versions) that claims a bad signature, but a 'good' response.  Technically, I understand how this can be true, but the error message could be a lot clearer... I suppose that's another issue.
Response Verify Failure
3086157980:error:0407006A:rsa routines:RSA_padding_check_PKCS1_type_1:block type is not 01:rsa_pk1.c:103:
3086157980:error:04067072:rsa routines:RSA_EAY_PUBLIC_DECRYPT:padding check failed:rsa_eay.c:705:
3086157980:error:0D0C5006:asn1 encoding routines:ASN1_item_verify:EVP lib:a_verify.c:218:
3086157980:error:27069075:OCSP routines:OCSP_basic_verify:signature failure:ocsp_vfy.c:105:
avh.crt: good
        This Update: Dec  2 09:51:09 2016 GMT
        Next Update: Dec  6 10:01:09 2016 GMT
#echo $?
1

 openssl version -a
OpenSSL 1.0.1k-fips 8 Jan 2015
built on: Thu Aug 13 12:14:48 2015
platform: linux-x86_64
options:  bn(64,64) md2(int) rc4(16x,int) des(idx,cisc,16,int) idea(int) blowfish(idx)
compiler: -I. -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -DKRB5_MIT -m64 -DL_ENDIAN -DTERMIO -Wall -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -Wa,--noexecstack -DPURIFY -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM
OPENSSLDIR: "/etc/pki/tls"
engines:  dynamic

openssl version -a
OpenSSL 1.0.2h  3 May 2016
built on: reproducible build, date unspecified
platform: linux-elf
options:  bn(64,32) rc4(8x,mmx) des(ptr,risc1,16,long) idea(int) blowfish(idx)
compiler: gcc -I. -I.. -I../include  -fPIC -DOPENSSL_PIC -DZLIB_SHARED -DZLIB -DOPENSSL_THREADS -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -Wa,--noexecstack -DL_ENDIAN -O3 -fomit-frame-pointer -Wall -DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DRMD160_ASM -DAES_ASM -DVPAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM
OPENSSLDIR: "/usr/local/ssl"

So, assuming it works, I guess this becomes a request to backport it.

This would be counted as a feature. We only backport bug fixes to 1.0.2 so this would not be eligible.

I disagree with your characterization of the issue.
Failure to communicate with a major CA's responders without the use of an obscure, un-documented option seems like a bug to me.

The fact that it is undocumented should be fixed. That then provides a workable solution in 1.0.2. If you need the more user friendly feature then you should upgrade to 1.1.0.

Sure.  I'll upgrade -- when BIND can compile and run with 1.1.0; ISC reports that you and they have issues with API changes in 1.1.0.  And assuming I don't encounter other software with issues.
For a 'workable' solution: you should at least document that some OCSP responders require '-header host <the hostname from -url or -host>, and typically respond with an HTTP 400 or other error if this option is not specified.  Just saying that '-header name value' lets you add custom http headers would not be helpful for most users.
It's your team's decision; I'm just a user.  When an engineer wants to do something about an issue, it's a bug.  When he doesn't, it's a feature.  Considering the small scope of the fix (or "feature") and the customer pain that it's caused for at least the past 3 years, if it were my project, I'd make the change.
I've done my duty to report and research the issue.   I know what my fingers (and scripts) need to do for now.  Disposition is in the OpenSSL team's hands.

Sorry for the delay, @tlhackque.  You're right, there's now a PR to fix the docs.

@richsalz Thanks for working on this.  I looked at the PR; it seems that you simply documented -header, not the important usage from .-2:

For a 'workable' solution: you should at least document that some OCSP responders require '-header host <the hostname from -url or -host>, and typically respond with an HTTP 400 or other error if this option is not specified. Just saying that '-header name value' lets you add custom http headers would not be helpful for most users.

I still think that including something to the effect that -header host is a mandatory option for some OCSP responders would avoid a fair bit of customer pain.

I added a sentence and pushed an updated commit; hope that helps.

fixed with 1f234f7 on 1.0.2

Hello. It would be awesome if you ported that docs update back to 1.0.1 - the standard library for CentOS 6.

Hello. It would be awesome if you ported that docs update back to 1.0.1 - the standard library for CentOS 6.

Unfortunately 1.0.1 is no longer supported by the OpenSSL project and receives no updates from us at all.

Ping the CenOS maintainers.


[Question] Misconfigured  basic authentication?

Hi. First of all, thank you for providing thus plugin. Awesome! 👍 🚀 I do think that https://blog.gradle.org/introducing-source-dependencies should have included support for Authentication from the get-go... Anyhow... 😄
I have two private GitHub repos (let's call them app and lib). I'm trying to use a feature branch from app when building lib locally. This is my settings.gradle file for the lib project:
plugins {
    id 'me.champeau.includegit' version '0.1.3'
}

rootProject.name = 'lib'

gitRepositories {
    include('app') {

        authentication {
            basic {
                username = ***
                password = ***
            }
        }

        uri = 'https://github.com/<org>/app.git'
        branch = 'test_includegit'
    }
}

This is the result when I reload my Gradle changes:

FAILURE: Build failed with an exception.

* Where:
Settings file 'C:\Users\sehenst\IdeaProjects\lib\settings.gradle' line: 8

* What went wrong:
A problem occurred evaluating settings 'lib'.
> Branch or tag test_includegit not found

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 505ms

I've also tried using the following URI format but I still get the same error.
uri = 'git@github.com:<org>/app.git'

I'm assuming that I've misconfigured something, but I can't seem to find what. 🤔 Any ideas?

Does the branch actually exist? It doesn't seem to be an authentication problem.

Does the branch actually exist? It doesn't seem to be an authentication problem.

Yes, the branch test_includegit exists.

Hmm. The following works:
branch = 'main' // 'test_includegit'

Where can I find the log file in order to provide more info?

Before trying to use the remote branch I tried to use a local version of the app repo:
gradle.properties
local.git.app=C:\\Users\\sehenst\\IdeaProjects\\app

This worked as expected.
When I'm now trying to use the remote branch I've commented out the above line. I'm not sure if this information is relevant or not...

Aha! 😄
I removed the checkouts folder, and reloaded my Gradle project. A new checkouts folder was created including my test_includegit branch.
Could it be related to how includegit_gradle_plugin updates the referenced git repo?

By default, the plugin will clone the included Git repositories in the checkouts directory of the project. If the repository is already cloned, the plugin will automatically perform an update every 24 hours. Alternatively, you can force it to update by adding -Drefresh.git.repositories to your Gradle command line.

https://melix.github.io/includegit-gradle-plugin/latest/index.html


Correct display message

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/573fbe4f94bbfd58b53cbf4125f7f71f970d4659/

Thank you, @aermolaev! I'll validate this change soon.

LGTM. Thanks for this correction, and apologies for the delay. I'll apply this change to subsequent versions of the docs as well.


Update AudioInSample to allow users to choose the render device for a… …  …udio playback

Hi @MattGosline, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Gosline). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Added README.md for VirtualMicrophoneArrayDriver sample


Same output for all Query Builder

I'm getting same output for all the method calls from generate.js, am I missing anything?

Can you please help me to short out this?
Thanks in Advance! 👍
BTW, The code is nicely managed.

It's been awhile since I worked with SQL. I'd have to spend more time than I have to look at your first message. Sorry.  Also, the only example I had was proprietary, so I can't share it (and it was quite complex).

Thank you for answer.

got the same error, did you find out how to use it ?

Hi,
FWIW, in order to have ORDER and WHERE / SEARCH being correctly taken into account, make sure to define your columns specifying their name as well, as mentioned in https://github.com/jpravetz/node-datatable/issues/14#issuecomment-198647259.
In my version of DataTables (not sure if behaviour changed at some point), the data / requestQuery parameter passed by DataTables to the ajax function option also had columns' orderable and searchable options defined as boolean's, whereas node-datatable compares them strictly with string values:
https://github.com/jpravetz/node-datatable/blob/ca25ef76b94743ee8101320baae37615797676db/lib/builder.js#L199
https://github.com/jpravetz/node-datatable/blob/ca25ef76b94743ee8101320baae37615797676db/lib/builder.js#L152
If you are in that case, you have to convert these fields first into strings before passing the refactored requestQuery to buildQuery() method.
I had no problem at all regarding the PARTIAL / LIMIT query.
Hope this helps.

Live demo of this bug: https://plnkr.co/edit/auaYxFKq1bOVU4IhcP2T?p=preview
An example of workaround:
function formatRequestQuery(requestQuery) {
  requestQuery.columns.forEach(function(column) {
    formatColumnField(column, 'orderable');
    formatColumnField(column, 'searchable');
  });

  return requestQuery;
}

function formatColumnField(column, fieldName) {
  if (typeof column[fieldName] === 'boolean') {
    column[fieldName] = column[fieldName] ? 'true' : 'false'
  }
}

Use it to refactor the requestQuery before passing it to queryBuilder.buildQuery() method.
See it in action: https://plnkr.co/edit/PZiw9h5z0AgqSAQIfcXM?p=preview


Integrating checkout.js with AngularJS

I followed the implementation tutorial to use the checkout.js (v.4) in conjunction of AngularJS but i keep getting this:
Error: $injector:modulerr Module Error Failed to instantiate module paypal-button due to: Error: [$injector:nomod] http://errors.angularjs.org/1.5.9/$injector/nomod?p0=payp...
Any suggestions?

Now keep saying:
Error: [paypal-button] No context options available for render
Even if i added the props needed to my $scope

Yeah, I've managed to repro this. Seems to be a regression in the angular driver. Should be a straightforward fix, I'll let you know shortly.

Thanks a lot!! ;)

@marcocristalli I've pushed a fix, please make sure your browser cache is cleared and try again.
There's a working demo at https://github.com/paypal/paypal-checkout/blob/master/demo/angular.htm for reference.

Awesome! Now it works, thanks a lot! ;)

@bluepnume its working fine but one issue here when payment successful all object are undefined
mean here Router undefined
this.router.navigate(['/confirmation', this.Order.id]);

>  onAuthorize: function(data, actions) {
>                     // Optional: display a confirmation page here
>                     return actions.payment.execute().then(function() {
>                         // this.router.navigate(['/confirmation', this.Order.id]);
>                     });
>                 }

Can you please what a problem here why router object show undefined?


[GLUTEN-7868][CH] Nested column pruning for Project(Filter(Generate))

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #7868)
How was this patch tested?
(Please explain how this patch was tested.  So I added a rule in CH to improve it. I'm curious if Velox needs it?

@taiyang-li, thanks so much for letting me know your this work! I think it should be applicable to Velox backend. Maybe, you can firstly get pr merged, then try to move the proposed code to common module in another pr to see whether there is any issue reported for velox backend.
BTW, I note you introduced one dedicated config for the proposed optimization rule. Maybe, it's better to have a generic config in Gluten to allow exclude any optimization rule, like Spark's spark.sql.optimizer.excludedRules. If it makes sense to you, it's ok to do this small improvement in a separate pr. Thanks!


Home Page

I have submitted this PR to master temporarily, just to make it simpler for others. If we find this works, we might leave fa branch and use master directly.

the combination of persian and english words made this thing happen.it is not readbale. what is your idea? @sorousht

the combination of persian and english words made this thing happen.it is not readble. what is your idea? @sorousht

From now on, we won't have this sort of issues because PR #22 has been merged recently.

@zahrajoulaei Check it out https://deploy-preview-21--fa-reactjs.netlify.com/ now! :sunglasses:

cool! it's great 🎉


Add Leticia to Contributors list

Add Leticia to Contributors list

@monaLeti, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I accepted it?

It was great to have this tutorial to learn how to contribute.  I feel scared of contrbuting and this tutorial helps you to get more confidence. Thank you! :)

Awesome @monaLeti. I'd be happy to see you contributing to other projects as well. Do check out the list of projects at the end of tutorial. If you need any help from me or first contribution community, just ping us on slack. We'll be happy to help.


Make Route Go to Top of Screen When Hovered Over

For visibility

fixed here https://github.com/Gopher-X-Metro/Gopher-X-Metro/pull/113


⚠ Bofrost.be has degraded performance

In ff8abcd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1895 ms

Resolved: Bofrost.be performance has improved in e481cad after 2 hours, 49 minutes.


Move build code into rusoto_codegen sub-crate

Building on the work @adimarco started in the feature-split-crates branch, this gets us another step of the way closer to having our code generation written in Rust by turning the "codegen" directory into a sub-crate used only as a build dependency by the top-level crate. Now rusoto's build.rs just uses this other crate and invokes a generator with each service to generate as arguments. From this point we can move the Python logic piece by piece into the "rusoto_codegen" crate and the interface from build.rs won't change.

It looks like we both set out to do similar things in different ways :)
I've actually got pure Rust codegen working for dynamodb and KMS.  This necessitated creating another crate for codegen, though I have it checked into a separate git repo.
The new crate I called botocore_parser, as it uses a build script and serde to generate a parser for the botocore JSON definitions.  The rusoto crate (in the feature-rust-codegen branch) uses botocore_parser as a build dependency, and its build script generates the rusoto libraries for dynamodb, etc.
I actually have this all generating and building and working up through the integration tests in the rusoto_helpers crate.  I'll take a closer look at what you've got here and think about how to get this all merged.
@jimmycuadra  - take a look at the feature-rust-codegen branch I just pushed if you get a minute.  I did the heavy lifting of translating the python scripts to Rust.  I think we're mostly down to how this all gets packaged and working together.

Awesome! This is a great development.

Minor nitpick: That new branch introduces several whitespace errors. You can probably configure your editor to automatically remove trailing whitespace on each line and ensure the file ends in a newline whenever you save.

I actually just installed the rustfmt emacs plugin.  I'll run everything through that before I merge.

That works! If you think of it, poke me in IRC when the Rust codegen is merged in case I don't notice here. I've got some changes I need to make for serialization in the JSON protocol that I'll base on the new stuff.

Any updates on getting the feature-rust-codegen branch merged to master? I've got time to work on Rusoto but I think just about everything is waiting on Rust-based code generation so as not to create code that will be replaced soon.

I think we should make a PR for that so we can track the progress of it.  I made some minor additions of moving some S3 code in there, but there's lots of work to do still.
If we concentrate on that we can get to this PR next.

Done! Closing this issue in favor of #169.


Create router with path should prepend a slash if one is not provided

This is probably lower priority as most users should know to put a proper path, but just in case it would be nice and easier to use if inputting a path without a slash automatically prepended one for me, either shown in the UI or just sent in the request.

The fix looks like it's providing a slash even if I do provide one (typing: /v0 ends up with //v0) but works well if I don't provide a slash.
Also, if I don't provide a slash and then backspace to the slash, it adds an additional slash. (v0 ends up with /v0 --> backspace twice, ends up as //)

Validated fix.Slash is prepended properly


Feature request: WOOD (and other junk from fishing nets)

I'm living entirely underwater in my server... Wood is a problem >.> I have to go to land, or make myself a tree farm underground, both taxing propositions... I have plenty of string from fending off cave spiders, but no sticks...
So what I suggest is two fold,

some underwater plant that produces something that would be in the ore dictionary as sticks (or just sticks themselves), it should be farmable... Probably something like reeds, but entirely underwater.
That first request is so you can make a fishing net, the second request is for the fishing net to have a chance at producing driftwood! This is just a type of log that the fishnet will drop as an entity just like it does fish...

Apologies if it already does (I haven't made one yet...)
The point here is that these suggestions fit in an underwater setting, and aren't something ridiculous like underwater trees... And work within existing mechanics to create a more complete experience out of the box! Of course, if the driftwood makes fish less likely to drop from the net it would reduce the current utility of it, so there's some kind of balance to be struck here...Of course this could go with other junk items and fishing tropes such as an old boot = leather in crafting grid, tire = rubber for the couple recipes that need it in Mariculture when a mod that has rubber is installed.  soggy leaves, smelt = leaf block...  All things that are harder to get from my undersea lair, and are useful in various ways.  (I need leaf blocks or other plant material typically harvested with shears to make ethanol in RotaryCraft). Fish breeding can be used for some of these things I believe... But you need wood to make a sifter to get started with that too :p

Probably won't happen. Maybe in 2.0 but not now. Not looking to add anything, just finalising what I have.


[DOC] Haier AS07TS4HRA-M is supported

Please update the doc with supported devices - I've tested it with Haier AS07TS4HRA-M and it works well.
Many thanks for your work!

Done :) Thanks


Add empty state icons

close #53

[x] heart.is-empty
[x] star.is-empty
[x] like.is-empty

This is awesome 👍

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update variable names.

This change is

Coverage remained the same at 79.791% when pulling 2fac8ff118e383db6198de175d3eb632adfe8b67 on consistent_naming into a4aded6629d0bc37847d227b7df0550e8f257832 on master.

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


push does not send params for lightweight monitors

When pushing lightweight project monitors, it does not include the params defined in either synthetics.config.ts or from --params.  With the implementation added in https://github.com/elastic/kibana/issues/147467, that means the behaviour is different between browser monitors and lightweight monitors.
i.e. The push command should also include the params defined as they can be for browser monitors (config file, --params) when sending to Kibana.  The priority of the solution should be the same as for browser monitors (see https://www.elastic.co/guide/en/observability/master/synthetics-params-secrets.html#synthetics-basic-params), i.e.

Global params in Kibana
Then synthetics.config.ts
Then --params defined in push

Ensure the order remains consistent and as defined above with both browser and lightweight monitors after this change.

Post FF Testing
LGTM as covered in https://github.com/elastic/kibana/pull/157226#issuecomment-1548424466.


License Issue

As a proud (also) user of GNU/Linux and supporter of the Free software movement I can not condone this repository or most of the repositories currently present on Github as they all use the non Free MIT-License

I am very sorry but am currently seeing myself in the position of stopping all support I have spoken out in the past and retroactively not condoning this projects or any of its offsprings. For this reason I will from now on start work on a non proprietary fork of FNAK,
no regards at all
a sad linux user


Testing: Collect coverage

Though I figured you may have some reason for not setting coverage, I thought I'd offer the PR in case you wanted the change.
As I see it, coverage is kind of "out of sight, out of mind", so if it's not on, especially if no nyc threshholds are set in package.json to enforce an expected coverage percent, it may never get addressed.
Thanks!

Ah yeah, I had turned it off because it messes with the debugger and forgot to turn it back on :-)


Insert Delete GetRandom O(1)

Coverage remained the same at 100.0% when pulling e83f6ba02841cbd02722906a066d535e07e065f5 on insert-delete-getrandom-o1 into 4d9c0397c49824445eea210c922e13310969796d on master.


ROS_LOCALHOST_ONLY usage

Hello maintainers, thanks for your work. I've seen that ROS_LOCALHOST_ONLY support has been added in https://github.com/micro-ROS/docker/pull/69/files, (which I believe supersedes the approach suggested in https://github.com/micro-ROS/micro-ROS-Agent/issues/49 ), but what I'm observing instead that it's blocking comms. Is any extra config needed?
Context: I have a number of robots each with "desktop nodes" and a teensy connected via microros. The microros agent uses serial comms. I want to use ROS_LOCALHOST_ONLY on the desktop nodes so that the robots don't discover each other. However when I enable it on the desktop nodes, I lose connection to the microros node. (This is not surprising since I lose access to any desktop nodes not using ROS_LOCALHOST_ONLY).
I was hoping that setting ROS_LOCALHOST_ONLY in the docker launch of the micro-ros agent would allow comms again, but no such luck. How can I integrate the microros agent into a ROS graph that's using ROS_LOCALHOST_ONLY?

Hardware description: teensy, using serial
Installation type: from docker image
Version or commit hash: humble

Steps to reproduce the issue
Standard microros agent with ROS_LOCALHOST_ONLY=0...
ronnie@walle:~/vxwave$ ./src/microros_agent_launch.sh
Teensyduino device found: /dev/ttyACM0
Programming teensy was successful!
+ docker run -it --net=host --device=/dev/ttyACM0 --env ROS_LOCALHOST_ONLY=0 --env RMW_IMPLEMENTATION=rmw_fastrtps_cpp microros/micro-ros-agent:humble serial --dev /dev/ttyACM0
[1709109036.360346] info     | TermiosAgentLinux.cpp | init                     | running...             | fd: 3
[1709109036.360494] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 4
[1709109037.452976] info     | Root.cpp           | create_client            | create                 | client_key: 0x7E4CAEE3, session_id: 0x81
[1709109037.453044] info     | SessionManager.hpp | establish_session        | session established    | client_key: 0x7E4CAEE3, address: 0
[1709109037.460367] info     | ProxyClient.cpp    | create_participant       | participant created    | client_key: 0x7E4CAEE3, participant_id: 0x000(1)
[1709109037.460639] info     | ProxyClient.cpp    | create_topic             | topic created          | client_key: 0x7E4CAEE3, topic_id: 0x000(2), participant_id: 0x000(1)
[1709109037.460812] info     | ProxyClient.cpp    | create_subscriber        | subscriber created     | client_key: 0x7E4CAEE3, subscriber_id: 0x000(4), participant_id: 0x000(1)
[1709109037.461117] info     | ProxyClient.cpp    | create_datareader        | datareader created     | client_key: 0x7E4CAEE3, datareader_id: 0x000(6), subscriber_id: 0x000(4)
[1709109037.461369] info     | ProxyClient.cpp    | create_topic             | topic created          | client_key: 0x7E4CAEE3, topic_id: 0x001(2), participant_id: 0x000(1)

... connects only to desktop nodes that are also using ROS_LOCALHOST_ONLY=0:
ronnie@walle:~/vxwave$ export ROS_LOCALHOST_ONLY=0
ronnie@walle:~/vxwave$ ros2 topic echo /hardware/motor_current_pos_steps
header:
  stamp:
    sec:<PHONE_NUMBER>
    nanosec: 96169930
  frame_id: ''
pose:
  position:
    x: 0.0
    y: 0.0
    z: 0.0
  orientation:
    x: 0.0
    y: 0.0
    z: 0.0
    w: 0.0
---

... and does not connect to, but can still be discovered by, desktop nodes with ROS_LOCALHOST_ONLY=1:
ronnie@walle:~/vxwave$ export ROS_LOCALHOST_ONLY=1
ronnie@walle:~/vxwave$ ros2 topic echo /hardware/motor_current_pos_steps
ronnie@walle:~/vxwave$ ros2 topic list
/hardware/hardware_error_status
/hardware/motor_current_pos_steps
/eef_pose
/parameter_events
/rosout

Microros agent with ROS_LOCALHOST_ONLY=1:

ronnie@walle:~/vxwave$ ./src/microros_agent_launch.sh
Teensyduino device found: /dev/ttyACM0
error writing to Teensy

Programming teensy failed, trying again...
Programming teensy was successful!
+ docker run -it --net=host --device=/dev/ttyACM0 --env ROS_LOCALHOST_ONLY=1 --env RMW_IMPLEMENTATION=rmw_fastrtps_cpp microros/micro-ros-agent:humble serial --dev /dev/ttyACM0
[1709108701.442692] info     | TermiosAgentLinux.cpp | init                     | running...             | fd: 3
[1709108701.442869] info     | Root.cpp           | set_verbose_level        | logger setup           | verbose_level: 4
[1709108702.568359] info     | Root.cpp           | create_client            | create                 | client_key: 0x7E4CAEE3, session_id: 0x81
[1709108702.568495] info     | SessionManager.hpp | establish_session        | session established    | client_key: 0x7E4CAEE3, address: 0
[1709108702.583510] info     | ProxyClient.cpp    | create_participant       | participant created    | client_key: 0x7E4CAEE3, participant_id: 0x000(1)
[1709108702.584156] info     | ProxyClient.cpp    | create_topic             | topic created          | client_key: 0x7E4CAEE3, topic_id: 0x000(2), participant_id: 0x000(1)
[1709108702.584425] info     | ProxyClient.cpp    | create_subscriber        | subscriber created     | client_key: 0x7E4CAEE3, subscriber_id: 0x000(4), participant_id: 0x000(1)
[1709108702.584992] info     | ProxyClient.cpp    | create_datareader        | datareader created     | client_key: 0x7E4CAEE3, datareader_id: 0x000(6), subscriber_id: 0x000(4)
[1709108702.585523] info     | ProxyClient.cpp    | create_topic             | topic created          | client_key: 0x7E4CAEE3, topic_id: 0x001(2), participant_id: 0x000(1)

can neither talk to or be discovered by desktop nodes with or without ROS_LOCALHOST_ONLY (the nodes discovered are desktop nodes):
ronnie@walle:~/vxwave$ export ROS_LOCALHOST_ONLY=1
ronnie@walle:~/vxwave$ ros2 topic echo /hardware/motor_current_pos_steps
WARNING: topic [/hardware/motor_current_pos_steps] does not appear to be published yet
Could not determine the type for the passed topic
ronnie@walle:~/vxwave$ export ROS_LOCALHOST_ONLY=1
ronnie@walle:~/vxwave$ ros2 topic list
/eef_pose
/parameter_events
/rosout
ronnie@walle:~/vxwave$ export ROS_LOCALHOST_ONLY=0
ronnie@walle:~/vxwave$ ros2 topic echo /hardware/motor_current_pos_steps
WARNING: topic [/hardware/motor_current_pos_steps] does not appear to be published yet
Could not determine the type for the passed topic
ronnie@walle:~/vxwave$ ros2 topic list
/eef_pose
/parameter_events
/rosout

Expected behavior
Setting ROS_LOCALHOST_ONLY=1 env var on docker launch lets the microros agent talk with the rest of the rosgraph using ROS_LOCALHOST_ONLY
Actual behavior
Setting ROS_LOCALHOST_ONLY=1 env var on docker launch prevents both discovery and comms.
Additional information
Highlighting that we are using serial comms to the micro in case it's relevant.
also network info from inside docker run -it --net=host --env RMW_IMPLEMENTATION=rmw_fastrtps_cpp --entrypoint /bin/bash microros/micro-ros-agent:humble docker container:
root@dhood-t14:/uros_ws# ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: enp0s31f6: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN group default qlen 1000
    link/ether 9c:2d:cd:7b:fd:0d brd ff:ff:ff:ff:ff:ff
3: wlp0s20f3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 3c:21:9c:2a:d1:ef brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic noprefixroute wlp0s20f3
       valid_lft 3421sec preferred_lft 3421sec
    inet6 2001:818:e24a:3300:d2e7:3b51:1052:e3bb/64 scope global temporary dynamic
       valid_lft 86401sec preferred_lft 43201sec
    inet6 2001:818:e24a:3300:5b57:74f2:c69:1bb7/64 scope global dynamic mngtmpaddr noprefixroute
       valid_lft 86401sec preferred_lft 43201sec
    inet6 fe80::269b:2407:48a6:db5d/64 scope link noprefixroute
       valid_lft forever preferred_lft forever
4: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:dc:63:a5:38 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global docker0
       valid_lft forever preferred_lft forever
...

Hello @dhood ,
I have the similar issue and wonder if you have any work-around method?
My case:
A flight controller is connected to a Jetson board through GPIO ( ttyTHS0 )
When ROS_LOCALHOST_ONLY=0,
fmu topics are able to be discovered ( through ros2 topic list ).
When ROS_LOCALHOST_ONLY=1,
fmu topics are not able to be discovered.
Thank you for your precious time on this.


stats lag time?

How long should it take for edits to show up in the stats? I submitted a changeset with comment: Nepal Recovery #MissingMaps #MapGive #RedCross #hotosm-project-1540 ~36 minutes ago and the leaderboard for hotosm-project-1540 still shows "last commit: 5 hours ago" and my user profile still shows no edits for today.

Overpass seems to be lag sometimes. replication time isn't consistent. We should maybe look at a non Overpass option.
cc @kamicut

@dalekunce @danbjoseph right, this system depends on overpass Augmented Diffs and replication metadata being in sync. This isn't always the case, causing lag/inconsistencies.


Fails to parse files with aliased keywords

  (require '[clj-reload.parse])

  (defn read-str [s]
    (clj-reload.parse/read-file (java.io.PushbackReader. (java.io.StringReader. s)) nil))

  (read-str "(ns broken (:require [clojure.string :as string])) ::string/foo")
  ; (err) Execution error at clj-reload.parse/read-file$fn (parse.clj:79).
  ; (err) Invalid token: ::string/foo

When given a namespace that uses an aliased keyword read-file throws an exception "Invalid token: ::string/foo".
I can see that this uses clojure.core/read (with *read-eval* set to false) which is where the exception comes from. clojure.core/read will use *ns* and the aliases of the current namespace to resolve the aliased keyword. But as the file is read with *read-eval* set to false the namespace form is not evaluated and no aliases are created, so the keyword cannot be resolved.
I'm not sure how to fix this without using another reader (like clojure.tools.reader). It could work by creating namespaces and adding aliases into them.
  (binding [*read-eval* false
            *ns* (create-ns 'hacky)]
    (alias 'string 'clojure.string)
    (read (java.io.PushbackReader. (java.io.StringReader. "::string/foo"))))

But this obviously has an impact on the current environment which might not be ideal.

Looks like there’s a way through *reader-resolver*. Published 0.1.2


Setting golang version uniformly accross repo and updating docs

All golang version references now uniformly updated to 1.12
Adding all golang version references to development.adoc

Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>/kind code-refactoring
/kind documentation
Which issue(s) this PR fixes:
Fixes #3023

/approve

/cc @cdrage

/retest

/lgtm


Updates docs/auth links. Fixes #547

Fixes broken links on the auth docs.
See #547.

Fixes broken links on the auth docs.
See #547.


Fix crystal 0.29.0 compatability

Fixes #79
You'll also need my fix for onyx itself.

Great, thank you very much, David!


pulsar: 1.105.0 -> 1.106.0

Description of changes
Update Pulsar from 1.105.0 to 1.106.0
https://github.com/pulsar-edit/pulsar/releases/tag/v1.106.0
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239616 run on x86_64-linux 1

1 package built:

pulsar


Fix: typos

Fix: typos

Thanks for the PR @omahs !

These should be submitted upstream to https://github.com/tendermint/tendermint first, then pulled downstream.

Clarification: the README typo fix can be made directly to this repo, the code of conduct and contributing typos can be made to https://github.com/tendermint/tendermint

@adlerjohn @rootulp thanks for the feedback! I just made a PR in the tendermint repo I'll leave only the readme change in this PR


IOS Debug fails on Simulator / Device

Downloading ios tools...                                            8.1s
Downloading ios-profile tools...
Download failed.
URL: https://storage.googleapis.com/flutter_infra/flutter/3f52888b3bcf7adb9bc8d7be01f717a0c15b6618/ios-profile/artifacts.zip
Error: 404 Not Found
Exited (50)

Hi @aman7000
can you please provide your flutter doctor -v
and your flutter run --verbose?
Also, to better address the issue, would be helpful
if you could post a reproducible minimal code sample
or the steps to reproduce the problem.
Thank you

Hi @aman7000
Closing as there are not sufficient details to act upon this issue. If the problem persists, please create a new issue and provide the information required in the template.
Thank you


How do I customize verification emails (the content and the "From:" field) sent by Azure AD B2C?

This section talks about customizing from mail address, but it is mentioned that - Currently there is no way to change the "From:" field on the email. but this documentation talks about modifying the value. Looks like there is a discrepancy. Please take look into this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fc5e148d-b7cf-92e7-4cc7-a65d20d037b6
Version Independent ID: 2ba6e31b-5899-f35a-0f08-d280110ded13
Content: Frequently asked questions (FAQ) for Azure Active Directory B2C
Content Source: articles/active-directory-b2c/faq.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@anuraj Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.


Fix examples link on both READMES (/modules & /examples)

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


RequestLogger logs sensitive headers

In the 0.18.x branch of RequestLogger the deprecated apply method ignores redactHeadersWhen when calling logMessage, resulting the default value being passed and hence sensitive headers being logged.
This issue was fixed in:
d0ce8f36e196508bfc15195ba1b7412fce10fe6d
But then reintroduced in:
801b58ce8dd

Fixed by #2182, released in 0.18.20.


Make the EmbeddedServerHelper more dynamic by allowing more parameters in the constructor

Hi all,
as sent over hector-users, I extendend the EmbeddedServerHelper to take more arguements and make use of a template .yaml file which gets filled with correct values at setup(..) time.
Also take an argument for an external log4j file which gets copied along into the folder of choice.
I kept both a the EmbeddedServerHelper(String yamlFile) and EmbeddedServerHelper() constructors with correct default values to act as a drop-in replacement. I ran all the available tests, so it should work.
Felipe

What's the status of this ? Sean ?


data

<EMAIL_ADDRESS>

Hello, I am very interested in your experiment and would like to replicate your experiment. Could you please provide me with the data set? My email address is<EMAIL_ADDRESS>

Hello,
An anonymized version of the dataset is available here.
Best,


Fix invalid aiohttp import

A silly bug was introduced because of #29, for an unknown reason the test suit didn't detect that issue.
The web submodule is not automatically imported by aiohttp when we make the typical import aiohttp, we have to import it explicitly.

Just want to confirm, did you find this bug when you actually instrumenting aiohttp App? With this fix does tox still pass?

Yes, raised when I was instrumenting an Aiohttp app with the master branch, more about this discussion here [1], looks like that is intentional so we should fix it.
I've just used pytest for that for the aiohttp tests, and they are passing - as before.
[1] https://github.com/aio-libs/aiohttp/pull/2838


Handle PRs from within container

Being able to open PRs, check and create comments, check statuses and merge would be pretty awesome

hub does a fair bit of this (creating prs, checking statuses), so i'm going to close this


feat(fesm): add support for [Angular Package Format v4.0](https://goo…

….gl/AMOU5G)
Closes #32

Coverage increased (+0.3%) to 93.275% when pulling 0214057e0e2997eb4ecad52940c96f6994fd27d7 on feat_fesm into bb5c6d2a88e2d491b06eaf0278bd0aef033059d6 on dev.


Support more keyboard layouts

This patch only compiles when combined with my PR to avalonbits/vdp-gl
The keyboard layouts themselves are in vdp-gl, this file allows you to select them.
Needs a fix to MOS as MOS *set KEYBOARD n checks n<9
But we can do VDU 23,0,129,n instead.

The required vdp-gl PR has been accepted. There is no new release of vdp-gl yet, so you have to check it out from github.

The release of vdp-gl is available now: https://github.com/avalonbits/vdp-gl/releases/tag/1.0.4

@astralaster still not seeing vdp-gl 1.0.4 in the Arduino library manager.

And while you're at it, upstream vdp-gl also got the Brazilian Portuguese keyboard layout, which should also be added.

@astralaster still not seeing vdp-gl 1.0.4 in the Arduino library manager.

Now it is: https://reference.arduino.cc/reference/en/libraries/vdp-gl/


[Loc] small update to sql-database-projects

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.643%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26446

Relevant Lines:
57614

💛  - Coveralls


Merge Statement does not work on Views (Only 3+ items)

When my App inserts 1-2 items, the SQL generated uses normal INSERT statements (and everything works fine).  For 3+ it uses a merge statement and the OUTPUT clause.
The generated merge statement does not work for queries that run on a View with an INSTEAD OF INSERT trigger.  It gives the following error:

The column reference "inserted.WidgetId" is not allowed because it refers to a base table that is not being modified in this statement.

It would be nice to have a way to not use the Merge Statement.

Do a SaveChanges where you are inserting a bunch of records (has to be 3 or more)

Result: The following Error:
The column reference "inserted.WidgetId" is not allowed because it refers to a base table that is not being modified in this statement.
The following query also reproduces the error (when run after the above SQL):
DECLARE @inserted TABLE (WidgetId varchar(11) NOT null);

MERGE sales.Widget
USING (
	VALUES ('19668651', 4.75))
	AS widg (WidgetId, WidgetCost)
	ON 1=0
WHEN NOT MATCHED THEN
	INSERT (WidgetId, WidgetCost)
	VALUES (widg.WidgetId, widg.WidgetCost)
OUTPUT INSERTED.WidgetId
	INTO @inserted;
GO

Full Exception
Microsoft.EntityFrameworkCore.DbUpdateException
HResult=0x80131500
Message=An error occurred while updating the entries. See the inner exception for details.
Source=Microsoft.EntityFrameworkCore.Relational
StackTrace:
at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)
at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(DbContext _, ValueTuple2 parameters)    at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](TState state, Func3 operation, Func3 verifySucceeded)    at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(IEnumerable1 commandBatches, IRelationalConnection connection)
at Microsoft.EntityFrameworkCore.Storage.RelationalDatabase.SaveChanges(IReadOnlyList1 entries)    at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(IReadOnlyList1 entriesToSave)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(Boolean acceptAllChangesOnSuccess)
at Microsoft.EntityFrameworkCore.DbContext.SaveChanges(Boolean acceptAllChangesOnSuccess)
at Microsoft.EntityFrameworkCore.DbContext.SaveChanges()
at ShipmentTrackingDal.ShipmentTrackingEntities.SaveChanges() in C:\src\shipment-tracking\shipment-tracking-service\ShipmentTrackingDal\ShipmentTrackingEntites.cs:line 50
at Breeze.Persistence.EFCore.EFPersistenceManager`1.SaveChangesCore(SaveWorkState saveWorkState)
Inner Exception 1:
SqlException: The column reference "inserted.WidgetId" is not allowed because it refers to a base table that is not being modified in this statement.
at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)    at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)
at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)
at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()
at System.Data.SqlClient.SqlDataReader.get_MetaData()
at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)
at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary2 parameterValues)    at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteReader(IRelationalConnection connection, IReadOnlyDictionary2 parameterValues)
at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)"
Further technical details
EF Core version: 2.2
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.0
Operating system: Windows 10
IDE: Visual Studio 2019 16.3.10

Duplicate of #12064

For others that find there way here.  This is a work around to this issue:
optionsBuilder.UseSqlServer(connectionString, options =>
            {
                options.MaxBatchSize(1);
            });

It forces EF Core to treat each rows to be inserted as a batch.  That causes it to only use insert statement (instead of Merge).
NOTE: This means that all inserts for your EF Core application will be inserts for each row.  Not really performant for a large amount of inserts.


Suggest inserting using declarations in addition to inserting qualifiers for unknown/unresolved symbols

Clangd already suggests qualifying symbols e.g:
namespace ns { struct Foo {}; }
void bar() {
  Foo f; // here clangd will offer a fix for qualifting `Foo` to `ns::Foo`.
}

In addition to that, we can also offer a fix that inserts a using declaration.

Yes, I want this all the time and always do the dumb two-step version.
The trick is getting the layering right: FindUsing doesn't know about the namespace (though I guess the recovered AST has it...) and Sema doesn't know where to insert using.


Can't run in Xcode 16.1

Hello. Thank you for the open source project. But I encountered a problem of getting error prompts in Xcode 16.1 version.
Lambda Issue (Xcode): Variable 'params' cannot be implicitly captured in a lambda with no capture-default specified
/Users/victorliu/Downloads/Fllama-main/ios/Classes/FLlamaContext.mm:121:16

Lambda Issue (Xcode): Variable 'params' cannot be implicitly captured in a lambda with no capture-default specified
/Users/victorliu/Downloads/Fllama-main/ios/Classes/FLlamaContext.mm:121:50

Could not build the application for the simulator.
Error launching application on iPhone 16 Pro Max.

Flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.5, on macOS 15.2 24C101 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.96.0)
[✓] Connected device (5 available)

Upgrade to Xcode 16.2, and the problem does not recur.


Install wrangler@3 in C3

Fixes https://github.com/cloudflare/workers-sdk/issues/3243
What this PR solves / how to test:
Associated docs issue(s)/PR(s):

[insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

[ ] Tests
[ ] Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

Checked for inclusion of relevant tests
Checked for inclusion of a relevant changeset
Checked for creation of associated docs updates
Manually pulled down the changes and spot-tested

Please provide a Changeset, and any local screenshots of working workflows with Wrangler v3

@JacobMGEvans this is only specifying wrangler@3 in the templates/**/package.json files
wrangler@3 is already in use within the CLI code using npx wrangler@3 ...


Confusing (and wrong?) example in Ch11 with searchParams

The documentation shows

The replace(${pathname}?${params.toString()}); command updates the URL with the user's search data. For example, /dashboard/invoices?query=lee if the user is on page 3.

but this looks like the result of mixing an example for pagination with an example for querying maybe a username/person (lee vs page 3).

Hey @chrisb2244 👋🏼 you are right, updated the wording. Should be landing soon.


Hotfix 4.0.4

Codecov Report

Merging #13 into release-4.0.0 will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           release-4.0.0    #13   +/-   ##
============================================
  Coverage            100%   100%
============================================
  Files                  4      4
  Lines                 54     52    -2
  Branches               2      2
============================================
- Hits                  54     52    -2

Impacted Files
Coverage Δ

src/angularjs-store.ts
100% <100%> (ø)
:arrow_up:

src/models/state-holder.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0006e...2d4f337. Read the comment docs.


Make the portion describing Context more clear

This portion of the book is very confusing. There are a lot of methods named context() in this crate, and showing exactly where they come from when using this pattern makes it much more user friendly.
ResultExt::context() is the only one here that makes sense, as very few functions simply return an error. Most return results, and the way to handle those in failure should be shown.

Yeah, I did mean to delete that. Whoops! Just fixed it.

Spurious?
$ curl -sSf https://sh.rustup.rs | sh -s -- --default-toolchain=$TRAVIS_RUST_VERSION -y
info: downloading installer
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2017-12-20, rust version 1.24.0-nightly (b39c4bc12 2017-12-19)
info: downloading component 'rustc'
error: component download failed for rustc-x86_64-unknown-linux-gnu
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2017-12-20/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz' to '/home/travis/.rustup/downloads/3a2113cf883897014eacae6885c51b8b9e3b22d5d429340bcf0614cd97b7b776.partial'
info: caused by: error during download
info: caused by: [33] Requested range was not delivered by the server (HTTP server doesn't seem to support byte ranges. Cannot resume.)

I think so... I don't see how my change could've caused that.


add support for scanning pull-requests (GithubPullRequestScanner)

GithubAPIPullRequestAdapter based on GithubAPICommitAdapter but scans for pull requests that have new commits inside of the interval (since to until)


ISPN-5509 Memory based eviction doesn't work with store as binary

Added support for primitives, arrays and String size calculation
Added support for MarshalledValue when using store as binary

https://issues.jboss.org/browse/ISPN-5509

Fixed comment and ordering

Integrated, thanks @wburns


ScrapyDeprecationWarning for custom_headers

I'm getting a deprecation warning from Scrapy for the custom_headers approach in the docs.
This just started happening this week.
[py.warnings] WARNING: /usr/local/lib/python3.12/dist-packages/scrapy_playwright/handler.py:751: ScrapyDeprecationWarning: Accepting positional arguments in the function passed to the PLAYWRIGHT_PROCESS_REQUEST_HEADERS setting is deprecated. The function should accept three (3) keyword arguments instead: browser_type_name: str, playwright_request: playwright.async_api.Request, scrapy_request_data: dict

Thanks.  Is there any action I need to take then, to remove the warnings from the log?

Yes, refactor your custom_headers function to receive the three keyword arguments that are specified in the docs.

Great.  I might add, as a tip for the docs:
from typing import Dict


Add additional data fields when creating new components

There should be more fields that users can fill in when making components via the conclusions view, e.g. description, homepage URL, etc..

I suggest that the initial focus should be:
Primary Language, and
Homepage URL
We already have a Notes field in the conclusions view, so AboutCode Manager users can determine the best use of whatever values they put there to fit their general information requirements.


input magnitude for analog sticks/mobile controls

for users with a controller analog stick or mobile thumbstick, allow analog movement instead of always moving at max speed in the given input direction

what happens when some malicious user modified the magnitude on :FireServer?
it seems like there is no clamping for cmd.magnitude on the simulation side


Retry db transactions on a serialization error

Closes #435 and #434.

I think you were right to leave mutex to begin with. Lets leave the old migrations alone, the next time we add a blocking migration we can safely remove the mutex.

Ok :)

@winder LGTY?

@winder my two DBs have fully caught up but still no success in reproducing the behavior. I think we should just merge this.

I'm surprised that 'serialization error' is an ephemeral thing that goes away if we try again. Isn't that the error we got from things that PostgreSQL's version of JSON couldn't understand?
Otherwise this looks like fine retry logic that's fair to add.


Release - Remaining endpoints

This PR will add most of the remaining endpoints.
It is currently only missing one more, you can read about it in the README.

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Log zoneID as d.Get(zone) might return nil

This should fix https://github.com/cloudflare/terraform-provider-cloudflare/issues/1776 where the provider crashes when an error is encountered.

how does this address the issue? the variable you are using here is identical to the value at the start of the method.

also, given zone_id is a required attribute, I'm unsure how it is possible for the value to be nil.

also, given zone_id is a required attribute, I'm unsure how it is possible for the value to be nil.

Hi! Thanks for looking into this. I had the exact same question initially ;-)  Note that the original line referenced zone and not zone_id. I think that was the culprit.

ah! good catch. that makes more sense :)


MX-6487 Prevent stopped subscriptions from triggering additional events

Previously, if stop() was called before the subscription was ready, it would silently do nothing, leading to orphaned ghost :ghost: subscriptions that would exhibit spooky behavior in non-optimal network conditions. This patch allows stop()ping a subscription at any time, and short-circuits whenReady to avoid pretending that the subscription is ready when, in fact, it's stopped.

Per discussion, closing this PR in favor of mixmaxhq/publication-server#42 to solve the "calling stop() before the subscription is ready" problem, and a later PR to solve the "still receiving data from stopped subscriptions" issue.


Failure("Impossible: missing universe instantiation on eqtype")

assume type t (a:Type) : (n:nat) -> Type
assume T_hasEq: forall a n. hasEq a ==> hasEq (t a n)
type t2:eqtype = t bool 0
type t3:eqtype = {r:t2}

A side remark here: @aseemr why is eqtype not a refinement of Type0?

This works in master, closing and adding a testcase.


css: Style headings to be similar to webapp.

The webapp styles the <h1> through <h6> tags to be all the same size,
bold, and underlined. This commit makes them look similar on mobile,
instead of the goofy giant text from the default sytlesheet that we had
previously.
old

new

webapp

Oh, hmm, one thing I notice from the screenshots. There's this comment in the web app code:
/* Headings: We need to make sure our headings are less prominent than our sender names styling. */

On mobile, the headings now look pretty similar to the sender names styling we use. Do you think that might be an issue?

Hmmm, looks like the difference between usernames and headings in the webapp is a weight of 700 vs 600.
We haven't used numbers for font-weight in the past, but according to MDN, bold == 700, so using 600 for headings sounds good. I'll make that change.
On whether to comment the differences, my inclination is not to, unless the differences are for an explicit departure from the webapp look. In this case, the departures are all because we don't use the same units as the webapp, which I don't think needs to be commented, people reading the CSS presumably already understand that. I'll go ahead and reorder the lines though, since I don't see a reason not to do that.

I ommitted the line-height, btw, since it doesn't seem to be needed on Android. Could you take a look on iOS as well? it seems to me that the margin-bottom and font-size control the height of the entire thing, presumably a difference in the base CSS for mobile browsers and desktop ones?

Did you test with a heading that was long enough that it wrapped onto several lines? That's the case where I'd particularly expect that to make a difference.

Yes, I tested this, it doesn't make a difference. And for what it's worth, I see changes when I remove line-height on desktop even with non-wrapped headings.
In any case, I added the line height just for the sake of consistency.
Should be good to go now.

Looks good, thanks -- merged!

And then I agree that the right approach for comments is to mark differences that are surprising. In particular I think that means

places where we make a different substantive choice;
places where the reason that our different code has the same behavior is a subtle one. I think the line-height being redundant would be an example of this :wink:

Just to clarify this last bit: I meant that if we were to leave out the line-height, then we would definitely want to have a comment explaining it. (Because our code would be different there from the webapp's similar code, but for subtle reasons it would turn out to have the same behavior. At least on Chrome/Android, I guess.) Which then reinforces that it's simpler to have that line than to leave it out and end up having to think about the difference.
But I also don't mind having the comment even when we do have the line-height line, as in your revision I just merged. It is a surprising fact that might be helpful for someone making changes there in the future.


🚀 Feature Request: Detect dev/publish during custom build command

Describe the solution
Given the following, where there's a custom build flow:
[build]
command = "custom_cli build"

I'd like to be able to detect whether wrangler dev or wrangler publish has triggered the command, as to do some custom logic in the build command. As far as I can see, it is not possible to detect this at all.
I also tried defining .dev.vars but it seems this is loaded after the custom build command, so I can't use that to detect the environment.

Ah this might be what I'm looking for: https://github.com/cloudflare/miniflare/issues/116
I'll give it a try and see if it solves the issue.


can't access props inside hooks or a methods

wanted to use url prop's value to the mounted or methods to call it later ,i provide a gist link bellow: https://gist.github.com/herOwOw/172042218388f2f6942c05d1792536ef
url shown in h1 tag but not in init's hook or methods

I don't know if you've figured it out yet, but you have to use this.get("url"), everything else looks fine.


Record delay

Hi,
I am developing my app for lecturer but when i record screen in device, video will delay about
4-10s. How to fix it?
Thanks.

Delay has multiple reasons. Your connection, my library, server and player.
About my library this is bassically related with your device speed doing frame render (GPU), encoding and packetization (CPU). I haven't a big buffer queue that could produce delay.
My queue is only 80 packets (Audio and Video) that is less than 0,5s. This queue is because the connection could be bad and I discard packets in this queue if you can't send packet faster than device produce it to avoid memory problems.
Also in your case (DisplayMode) MediaProjection API has delay.
So I recommend you try with Camera example to know how much delay could produce MediaProjection API. If you get similar delay try with other server and player in local net.
I have about 1s in local net with rtsp and rtmp using this server and VLC player with camera examples:
https://github.com/iizukanao/node-rtsp-rtmp-server

i reduced the buffering using ffplay
ffplay -fflags nobuffer rtmp://xxx:1935/liveest -loglevel verbose


[Feature request] Port to WinAppSdk from UWP

Notepads UI is outdated now and doesn't blend well with Windows 11 design. Could you make a Windows 11 version for the same that works on both Win10 and Win11 using the more modern WinAppSdk?

Upgrading to WinAppSdk will break some of the exiting features related to theming so I haven't done any investments. Also, there will be zero feature improvements switching to WinAppSdk so I am not taking it as first priority.


FinalizationRegistry.unregister should return boolean instead of void

⚙ Compilation target
ES2021
⚙ Library
es2021.weakref.d.ts
Missing / Incorrect Definition
FinalizationRegistry.unregister is now defined as:
    unregister(unregisterToken: WeakKey): void;

But it should return a boolean value that is true if at least one cell was unregistered and false if no cell was unregistered.
Sample Code
const obj = {};
const registry = new FinalizationRegistry(() => {});
registry.register(obj, obj, obj);
const removed = registry.unregister(obj); // failed compilation here

Documentation Link
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry/unregister

Can I work on this issue?


Fix api-lint tool missing some well-known dependencies.

This addresses an issue introduced in #155.

This change is


Update README.md

Update README.md content_id in Application sample needs a "v=" and the youTubeVideoId to run automaticly.

Thank you so much for figuring out the way to pass params to Youtube App! :)

You are welcome, i have to say thank you for all your work!


chore: add constraints file check for python samples

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/60d94463-5a7c-4c76-829d-2ff8e6f3696f/targets

[ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: https://github.com/googleapis/synthtool/commit/0a071b3460344886297a304253bf924aa68ddb7e

Superseded by #96


Fix PyPI publisher auth

After releasing v0.2.0 there is still some issue with the trusted publisher in PyPI.

Hopefully solved by properly using a protected deployment environment in GitHub


Bug: Action failed window doesn't show up

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
PR #6179 introduced a new feature where a window will display the error and stack trace of a failed action.
This feature is not working because the wrong arguments were passed to the function. Here you can see what is displayed in the Maya script editor console.

Expected Behavior:
Expected behavior is for a window to appear and display the error like this:

Version
3.18.8-nightly.1
What platform you are running OpenPype on?
Linux / Centos
Steps To Reproduce:
Make an action fail on purpose and run it. "Action Failed" window won't show up.
Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
No response
Additional context:
No response

I'm not sure if a PR is needed in AYON.

I'm not sure if a PR is needed in AYON.

Sure does :) https://github.com/ynput/ayon-core/pull/120

Thanks :D. Now that the related PR has been merged to develop, should I close the issue or should I close it once it has been officially released?

Let's close it.


owr: Disable last-sample property on all sinks

It is just wasting memory as we don't use it at all, and it also
causes elements with a limited number of buffers to potentially work
less efficient than they could as buffers are released later.
https://github.com/EricssonResearch/openwebrtc/issues/260#issuecomment-89353530

LGTM

Looks good, merged.


Remove the declaration of a library from kdl_parser_py.

It does not install a library, so it shouldn't declare it here.
Also fix up the dependencies to be more correct, since it really
requires urdfdom_py, not urdf.  It also needs a <build_depend>
on urdfdom_py now.
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>

@dirk-thomas Does this look like what you were thinking about to fix this?


Online-868 Hide enrolment button for anonymous users

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Fixes https://github.com/mitodl/mitxonline/issues/868
What's this PR do?

Updates Course Runs API permission for anonymous users.
Anonymous users cannot see enroll now button if enrollment is not started.
Removes unused imports for the changed files.

How should this be manually tested?

Create a course with course runs having enrollment dates in the future.
Visit course detail for a logged-in user.
Enroll now is not visible.
Log out and visit the course detail again. Enroll now is still not visible.
Now update the course run so that the enrollment start date is in past.
Visit course detail for logged-in and anonymous users. Now enroll now button is there.

Screenshots (if appropriate)

Codecov Report

Merging #875 (6d66113) into main (33ca509) will increase coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   84.40%   84.46%   +0.05%
==========================================
  Files         136      136
  Lines        6266     6268       +2
  Branches     1046     1047       +1
==========================================
+ Hits         5289     5294       +5
+ Misses        811      807       -4
- Partials      166      167       +1

Impacted Files
Coverage Δ

flexiblepricing/api.py
90.32% <0.00%> (-1.99%)
:arrow_down:

courses/api.py
87.75% <100.00%> (ø)

courses/views/v1/__init__.py
94.48% <100.00%> (ø)

ecommerce/views/v0/__init__.py
87.33% <0.00%> (+0.43%)
:arrow_up:

ecommerce/discounts.py
78.94% <0.00%> (+7.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Unit test is added. Merging this one. @collinpreston


GDScript comment doesn't escape quotation mark and apostrophe

Godot version: Master
Issue description:
GDScript comment doesn't escape quotation mark and apostrophes
Steps to reproduce:
Just write # ' or # " in a GDScript

are you talking about #17983?

I don't understand this issue. Everything is working as expected so far.

@volzhs yes it's the same issue. Thanks you!


waypoint-join-our-linkedin-alumni-network

Hi,
The Finish Challenge button doesn't work when opening the OPEN LINK IN NEW TAB with the mouse cursor button (which normally opens links directly in new tabs) in stead of just clicking on the button.
Cheers!
~SteinGee

Clicking the button should open the link in a new tab for you.  We can only register a click that has been clicked - this is a limitation of your browser.
Thank you and happy coding!


When an offer is declined, the issuer agent is not notified (of the answer)

Upon receiving a credential offer, the user can accept or decline it. If he accepts it, the issuing agent is notified and he can correctly update the credential status. On the other hand, if the user refuses the credential offer, no notification (answer) is sent to the issuer agent.

Closing as this appears to have been fixed


[bug] Handle tab as enter

Since this module is made to work along with ag-grid, we should handle the 'TAB' input as 'ENTER' if an option is already selected.
It will make the input flow more convenient.

After some investigation on this, it seem that the 'KEY_ESCAPE' and 'KEY_TAB' behavior are handled globally by ag-grid. Changing it may have a lot of side effects.
The doing some testing I've discover two problems with cellEditor:

If you overwrite the 'TAB' behavior, you end-up selecting your item properly but not passing to the next cell. I've doesn't have found a easy way to do it properly. Need to dig on ag-grid side to know if there is a way to do it.
You can't watch for the 'ESCAPE' key on the cellEditor, and this one is broken since if you just show up the cellEditor with double click, then type 'ESCAPE', the cellEditor doesn't destroy. It seem like an ag-grid error, I may open an issue about it.

done in v1.1.0


Support stdin/stdout processing

Expected Behavior
We'd like to be able to use https://github.com/hallettj/git-format-staged with detekt, but it requires a stdin input format
Current Behavior
Detekt only supports file inputs
Context
See expected behavior

Thanks for the feedback and new ideas!
Would you want to use the ktlint formatting integration of detekt with this tool or the detekt native rules?
Could git-format-staged also support files as input parameter?

Some of the "detekt native rules" would not work in this case because we need type solving. Would this be ok?

I think supporting a subset is fine. For ktlint - we actually run it separately for formatting. We just also run detekt as a commit hook to catch errors early rather than on CI

Having #2936 in mind, we shouldn't support another potential input format. Static analyzers need more context than a single file or a few lines for sophisticated analysis. This creates more problems than it solves.
We have had this discussion in #2320 and in the referenced threads.
I'm not sure, why the mentioned tool doesn't support files as input.
However, one could also redirect stdin to a file and then let detekt analyze it. So fortunately there is an existing solution for that.

Closed due to the mentioned existing solution and the discussion in the linked issue, which lead to a clear decision.


Start Stream at specific point of time of mp3 ?

Hi,
is it possible to start the stream at specific point of time in the mp3/
For example we have an mp3 which is 5 hours long, but we want to start a 1 hour ?
possible ?
-> related: https://gist.github.com/dtrce/1204243

IMO this is more likely a client feature. mediaserver can stream from any point but client needs to manage and decode that.

OK


Add keywords property to interests section

What this PR does / why we need it:
Adds keywords property to interests section to allow for examples/clarification of interests.
Which issue this PR fixes:
fixes #3

@ss22ever Ready to be merged?

@dbriesz Thanks for the pr, looks good :)


[WIP] Support claim implementation

Added the Support Claim link and inline form to the view media page.
I'm still not exactly sure where total claim support should be displayed. Should it be enclosed within brackets suffixed to the button label or in the inline form?

I think it might be good to create a actions/claims.js. There should be one already, this is my fault. There's also a bunch of code in actions/content.js which really should not be there too.

@6ea86b96 I guess this means I should also move the corresponding selectors and reducers from selectors/file_actions.js and reducers/file_actions.js to selectors/claims.js and reducers/claims.js respectively?

IMO yes, the supports stuff fits into claims better than file actions.

This is in tip_and_supports branch and will come in via #391.


can't watch multiple files

I'd like to watch more than 1 file. In the instructions it is listed

--watch, -w
Watch file(s)

but I'm not able to make it working if I launch it as
json-server -w one.json two.json more.json
Could you help me, please? It is really important

Hi @Jimmy5nomana,
The description may not be very clear. You can watch db.json file and the optional routes file (that's why there is a (s)). But json-server only accepts one "database" file and one routes file.
So you need to have one.json, two.json and more.json content in a single file. Do you need to use multiple files for a particular reason?

Ok, because I'm in a hurry for a corporate test, and I need to load 4 json files in a . I've all of them in a directory.
It seems to me routes file let me read certain values of json object.
I need to load every one at request, I can't put them together in a single file.
Thanks! Help me please!

I can see another ways of doing this, but it has cons.
Create db.js:
module.exports = function() {
  return {
    one: require('./one.json')
    two: require('./two.json')
  }
}

json-server db.js

Data won't be persisted and you can't watch for changes. But if it's a test, that's fine.
Or, as suggested previously, manually copy the content of the JSON files and create a db.json file. Unlike the db.js solution, If you restart your server, changed data won't be lost.
Sorry, I know it's not really the same as json-server -w one.json two.json more.json, but I hope it will helpful nonetheless.

I said I can't make it working, I'll explain you how I'm launching it.
folder: db.js, one.json, two.json
I run json-server db.js
Am I doing something wrong?
Terminal says error at

two: require('./two.json')

Thanks for the immediate reply, but it still can't work.

Module.js:327: throw err

Do you know if this works? Is it fine how I'm running it?

It's a little hard to tell. Can you copy paste the full error?

Can't find module '/one.json'

It should be helpful if you could run it on your machine, to know if it certainly works.
I'll repeat how I'm doing: I've all in one folder, and I launch json-server db.js within that folder

Did a quick test, it works.
Regarding the previous error:

Can't find module '/one.json'.

I would check that there isn't a typo like require('/one.json') instead of require('./one.json').
For reference and in case someone else needs it, here's the full code that I used:
// db.js
module.exports = function() {
  return {
    one: require('./one.json'),
    two: require('./two.json')
  }
}

./one.json
[
  { "id": 1, "title": "foo" }
]

./two.json
[
  { "id": 1, "title": "bar" }
]

$ json-server db.js

glad it worked :smile:

@typicode wonder if we can do something like follows. in db json.
module.exports = [
    {
        urlPattern: /\/api\/v1_0\/client\/status/,
        redirect: '/mock/clients/clientstatus.json'
    },
 {
        urlPattern: /\/api\/v1_0\/client\/details/,
        redirect: '/mock/clients/clientdetails.json'
    },

@samithaf
You can't in db.json, but you can add routes:
https://github.com/typicode/json-server#add-routes
For example:
{
  "/api/v1_0/client/status": "/mock/clients/clientstatus.json"
}

And create in ./public/mock/clients/clientstatus.json.
Or even better:
{
  "/api/v1_0/client/status": "/status"
}

And add an entry status in db.json.
If it's not enough, you can use the project as a module:
https://github.com/typicode/json-server#module

the
https://github.com/typicode/json-server/issues/434
can solve your problems

@TryRaymond Specifically https://github.com/typicode/json-server/issues/434#issuecomment-273498639


Add approve/dismiss functions.

Force Merge!

Force Merge!

Self-Aprove!

Self-Aprove!

Self-Aprove!


DRAFT: Added template init and prompts for javy typescript.

DO NOT MERGE

looks ok to me with the toml updates.


Deal with line continuations in coverage code

Line continuations may be less indented.
https://github.com/quantumlib/Cirq/blob/8481f78b468c6335b1ba3b5cfeee457246d4feda/dev_tools/incremental_coverage.py#L215

Covered in #2968


Implement get started button

curl -X POST -H "Content-Type: application/json" -d '{
"get_started":{
"payload":"{"from":"ADMIN_MESSAGE","action":"GET_STARTED","nextAction":"NONE","other":{}}"
}
}' "https://graph.facebook.com/v2.6/me/messenger_profile?access_token="

  "greeting": [
    {
      "locale":"default",
      "text":"Hi {{user_full_name}}, I am an educations chatbot that helps to smart peoples like you to have access of all learning activity just on your thumb impression."
    }
  ]
}' "https://graph.facebook.com/v2.6/me/messenger_profile?access_token=EAAFQXxzh4HQBAPIIh3ZARnn4cRKN8hgHZCk9bYnLL7IV6TrpGp1ZBjgv2gUZB7AoqXbK9ZBd5NtNxh1JXzpopXc7F5Ymn3CWUnvl1rKTLQY5wt5zybFuKqxFgdj1S4KcFqEgkVKnZBPwq4JZCDUW3BAZAQ77B5E1NZCZCwstdYZC6xstSgN2ZCMna7Un"


Output of tflite is not correct

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Arch Linux
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary):   package manager
TensorFlow version (use command below): 2.3.0
Python version: 3.8.5
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
The output of tflite is not correct.
Describe the expected behavior
The output should match the result of equation.
Standalone code to reproduce the issue
# Original model definition
"""
model = tf.keras.Sequential([
  tf.keras.layers.InputLayer(input_shape=(2, 2, 1)),
  tf.keras.layers.Conv2D(filters=1, kernel_size=(2, 2), use_bias = True, name = 'EX_Conv_1')
])
"""

# Run tflite model
import tensorflow as tf
import numpy as np

img = np.array([[-2,2],
                [3,1]],dtype = np.int8)

img = np.expand_dims(img, axis = -1)

interpreter = tf.lite.Interpreter(model_path = 'xx.tflite') # you may download the file in attachment

interpreter.allocate_tensors()

img = img / 255.
input_scale, input_zero_point = interpreter.get_tensor_details()[0]["quantization"]
resized_image = img / input_scale + input_zero_point
interpreter.set_tensor(0, np.expand_dims(resized_image, axis = 0).astype(interpreter.get_tensor_details()[0]["dtype"]))

interpreter.invoke()

model.zip
Other info / logs
By using interpreter.get_tensor_details() and  interpreter.get_tensor(k), we should get following info:
Input:
array([[[[-86],
[ 84]],
[[126],
[ 41]]]], dtype=int8)
Intput scale:   x_s = 9.22722028917633e-05
Input zero point: x_zp = -1
CNN weight:
array([[[[1],
[3]],
[[5],
[7]]]], dtype=int8)
CNN weight scale: w_s = 0.0005354330642148852
CNN weight zero point: w_zp = 0
CNN bias:
array([3441], dtype=int32)
CNN bias scale: b_s = 2.906211049591434e-09
CNN bias zero point: b_zp = 0
Output scale: z_s = 2.7681662118084205e-07
Output zero point: z_zp =  -122
If I understand correctly, the quantized output should be calculated as:
output_quant =  {(x_s * w_s) *[(-86 - x_zp)*(1-w_zp) + (84-x_zp)*(3-w_zp) +(126-x_zp)*(5-w_zp) + (41-x_zp)*(7-w_zp)] + b_s*(3441-b_zp)} / z_s - z_zp
= [(x_s*w_s)*(-85*1+85*3+127*5+42*7)+b_s*(3441)] / z_s-122 =<PHONE_NUMBER>400995 ->(int)-> 110
While the actual output of tflite shows 127.

@neesetifa
Can you please share a colab gist with the error reported as we are unable to access the .zip shared.


Error :(

Hello,
I tried to use this package but i had error:
{
    "code": 130,
    "error": "image.rotate is not a function"
}

If i add await to beforeFileSave i had different error :
{
    "code": 130,
    "error": "Cannot read property 'startsWith' of null"
}

Parse.Cloud.define('deneme', async (req) => {
  try {
    const Resim = Parse.Object.extend('Resim')
    const obj = new Resim()
    const { photo } = req.params

    let uploadedFile = await new Parse.File(
      'galleryFile',
      { base64: photo },
      'image/png'
    )

    obj.set('photo', uploadedFile)

    const data = await obj.save()

    return data
  } catch (error) {
    throw error
  }
})

Parse.Cloud.beforeSaveFile(async (req) => {
  const image = ParseImage.from(req.file) //THERE IS THE FIELD WHICH I ADD AWAIT AND I HAD DIFFERENT ERROR
  return image.resize(256)
})

Thanks for help.

Hey @aytugulis!
I will check it asap and will get back to you.
It would be great if you open RP if you find that cause the issue.
Best regards,
Asen

@aytugulis similar to the Parse.File this library is trying to guess the mime type from the filename. In your case in looks this check fails. Meanwhile I do some improvements over the source code, please check if you are passing file with an extension in the file name.

Actually, parse send us a base64 and sharp doesn't support that. So first we have to change base64 to buffer if we use sharp. This is the solution:
Parse.Cloud.beforeSaveFile(async req => {
  const file = req.file;
  const fileType = file._source.type;
  const fileData = await file.getData();
  // base64 to buffer
  const imageBuffer = Buffer.from(fileData, 'base64');

  // use sharp
  const newImageBuffer = await sharp(imageBuffer)
    .resize(800)
    .toBuffer();

  // buffer to array --also we can use base64 as well
  const bytes = Array.from(newImageBuffer);

  const data = new Parse.File('image', bytes, 'image/webp');

  return data;

});


[SYSTEMML-954] PyDML can be called with two arguments

Changed argument checking in PyDmlSyntacticValidator
Added unit tests for range() with corresponding PyDML test scripts

Thanks Sandeep for fixing the range-related bug in this PR. For consistency, I would recommend keeping the logic of RangeTest  similar to  https://github.com/apache/incubator-systemml/blob/master/src/test/java/org/apache/sysml/test/integration/functions/data/SequenceTest.java and parameterizing Range1.pydml and Range2.pydml (similar to Sequence.dml and Sequence2inputs.dml), i.e.:
# license ...
A = range($1, $2, $3);
save(A, $4);

The code of RangeTest would be similar to SequenceTest except following changes to :

Test-case naming: https://github.com/apache/incubator-systemml/blob/master/src/test/java/org/apache/sysml/test/integration/functions/data/SequenceTest.java#L47

Invoking the .pydml https://github.com/apache/incubator-systemml/blob/master/src/test/java/org/apache/sysml/test/integration/functions/data/SequenceTest.java#L108

This way, you check with R for sanity testing rather than constant data. Also, other developers are free to try testing range with different parameters: https://github.com/apache/incubator-systemml/blob/master/src/test/java/org/apache/sysml/test/integration/functions/data/SequenceTest.java#L69

For other committers, I have sanity tested this PR with following code and it works as expected:
X = range(5, 2) # range(5, 2, -2), range(1, 5), ...
# Also, range(5,1,1) throws LanguageException
str = toString(X)
print(str)

@sandeep-n @nakul02 @gweidner If my comments are holding this PR, then please go ahead and merge as this fix would be important for 0.11 release. I can fix the testcases in a separate PR :)

@niketanpansare I'm working on the testcases right now. I'll update my PR in a few hours. But please feel free to merge earlier if it's urgent :)

@sandeep-n awesome ... In that case, I would recommend to wait until you add the testcases. Thanks for taking care of it :+1:

Thanks @sandeep-n for the updates!  All tests passed in PR build 701.

LGTM. Thanks @sandeep-n :)

Thanks for reviewing @niketanpansare - I will merge.


The set-output command deprecated in GitHub actions

We need to update our CI workflows.
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

Done in #2168 and #2169.


[Refactor] Refine object storage related codes

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test


Fixed overflow-x on home page

I agree your suggestion does fix the overflow issue in some screensizes but it also does not match the look I was going for.


[RFC] GraphQL support

Not for merge but for discussion.
Hi! I've been playing with flow for a couple of months trying to make it to analyze graphql queries.
But now that I got some practice with this I'd like to discuss the possibility of adding a graphql support into flow.
I can think of the following features that would be possible:

GraphiQL-like code assistance in ide

Query/fragment validation
Autocomplete
Type+doc under the cursor

Object shape from queries
Checking query variables
Finding unused fields

This functionality would probably not be as lightweight in terms of the code in flow. And it's not obvious if the benefits would outweigh the burden of maintaining additional code. Also, I briefly discussed this idea on irc with @jeffmo a while ago, and he mentioned that flow could support plugins one day.
@sampepose said that the relay team typechecks graphql-queries by using codegen for now: https://github.com/facebook/relay/issues/1297
What do you think, should flow understand graphql?

Wow! This is pretty incredible 👍
This will take a while to review and digest. I'll take a look this week and bring it up in our team meeting on Monday.
Thanks a ton for taking this on!

@samwgoldman no-no! This is not for review (if you are talking about the code). It should've been an issue actually :)
Basically, I have 3 questions:

Does graphql query/framgent analysis belong to flow? For me it' analogous to jsx.
Does the flow team have time to review PRs for graphql support? Flow team seems to be very busy. Well, it's totally understandable. If I will work on this feature, it will be many PRs created and questions asked. So I have to ask if you are ok with dealing with these PRs/questions or would rather prefer not to have this functionality for now.

Looking forward to hear from you after the meeting!

Hey, Pavel. I'm sorry for dragging my feet on this for so long. I hope you didn't close this out of frustration with the lack of communication from my end.
Let me try to answer your questions.

Does graphql query/framgent analysis belong to flow?

Flow doesn't currently provide any kind of plugin feature, so if we want to do query/fragment analysis, it has to happen in Flow at the moment. I do think the opportunity here is large enough to warrant experimentation in the Flow codebase. Maybe down the line if we build out plugin support, this could be extracted, but I don't think we need to wait for that.
Also, you've done a very nice job of isolating the code here. I don't think there's much downside to this approach, thanks to that.

Does the flow team have time to review PRs for graphql support?

I think the biggest hurdle here is that we don't have a lot of domain expertise on the team. We'd need to ramp up ourselves to really understand the implications of any work done here. Because of that, reviews may take even longer than normal (and the "normal" review interval is regrettably quite big these days...)
@mroch has been on leave, but I think he is best suited to be the point-person from the Flow team here. It would also be great if some FB GraphQL people would volunteer to help steer this effort. @leebyron, what do you think?
Again, sorry for the delay here. If you're still interested in working with us on this, I'd be delighted if you decided to re-open this. Thanks!

I've been busy lately, so I wouldn't have written any code anyway.
This sounds great. I'm definitely still interested in working on this. I'm going to have more time soon and will try to come up with small step PRs to make it easier to review. Thanks for the answers!

I'm interested in this feature too. IMO this should be implemented as collection of magic types, like $GraphQLSchema, $GraphQLQuery, that could be composed. Relay-specific functionality could be build on top of that.

Yeah. I look at this feature as a general graphql support.

Made this and issue instead of PR: #2823


Display issues - HTML to Markdown

[ ] Images
[ ] Subscripts/superscripts
[ ] ol and ul
[ ] Tables

Images
eg. https://www.kcl.ac.uk/mathsschool/weekly-maths-challenge/previouschallenges.aspx Challenge 18
Subscripts/superscripts
For example, x squared would simply be displayed as x2
Unicode superscript characters:
⁰¹²³⁴⁵⁶⁷⁸⁹
Unicode subscript characters:
₀₁₂₃₄₅₆₇₈₉
https://en.wikipedia.org/wiki/Superscripts_and_Subscripts
https://www.fileformat.info/info/unicode/block/superscripts_and_subscripts/list.htm
(harder) could check to see if subscript/superscript character exists in Unicode, rather than manually checking for certain ones. This would allow characters like +⁺₊ to be added without manually filtering, useful for recursive relations or indices problems. Kings Maths School website seems to use <sup> and <sub> currently.
ol and ul
eg. https://www.kcl.ac.uk/mathsschool/weekly-maths-challenge/challenges-81-100.aspx Challenge 81. Because the list elements are children, the code does not catch them. (since it uses .next_sibling and .contents)
Tables
eg. https://www.kcl.ac.uk/mathsschool/weekly-maths-challenge/previouschallenges.aspx Challenge 5

Could be fun to create a sub/superscript library? A general HTML -> Markdown solution would be helpful; these might be useful: https://github.com/kennethreitz/pyandoc https://github.com/Alir3z4/html2text https://github.com/gaojiuli/tomd

Images seem to be stored as relative links, not absolute links.

https://pypi.org/project/pypandoc/ Seems to be a good solution.


Created test case project

Created test case project with all test cases

retest this please

retest this please

retest this please

Added tag to non running test case. Once developer fix the failed test case, he can remove the the tag NonRunningTests on the test case.
And added profile to run integration testcase project. By default these tests don't run along with build. User needs to provide profile like mvn -Pintegration-test clean package.

Merging to master.