immediate mode RETURN=LSIZE returns wrong size for pseudovariable

Reported by andrew wittenberg on 13 Mar 2013 21:39 UTC
Ferret v6.85 incorrectly returns "1" for the size of an axis of a pseudo-variable built from the two variables, one of which is transformed and one of which isn't.
Version 6.841 behavior gets the first and third answers right.  The second answer isn't really right, but at least it reflects the compute domain:
 	NOAA/PMEL TMAP
 	FERRET v6.841
 	Linux 2.6.32-279.19.1.el6.x86_64 64-bit - 01/25/13
 	13-Mar-13 17:26

yes? use coads_climatology
yes? say `sst,r=lsize`
12
yes? say `sst[say `sst-sst[t=@ave](t=@ave],r=lsize`
12
yes?),r=lsize`
12

In v6.85, the second answer is right, but the third is definitely wrong:
 	NOAA/PMEL TMAP
 	FERRET v6.85 (beta)
 	Linux 2.6.32-279.22.1.el6.x86_64 64-bit - 02/20/13
 	13-Mar-13 17:25

yes? use coads_climatology
yes? say `sst,r=lsize`
12
yes? say `sst[say `sst-sst[t=@ave](t=@ave],r=lsize`
1
yes?),r=lsize`
1

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2051

Comment by ansley.b.manke on 7 May 2013 23:47 UTC
See ticket #1801, where we added code in interp_context.F to look at  uvar_given(idim,uvar) and if it's uvlim_need_xact, unset the context subscripts. This means that
say `sst[used to return 12 now correctly says 1.

However, for compound expressions, merge_grid sets the value of uvar_given(idim,uvar) to a different value depending on the ordering of the sub-expressions(!) So, adding to Andrew's example above,

yes? say sst[t=@ave](t=@ave],r=lsize

which)-sst,r=lsize`
 !-> MESSAGE/CONTINUE 12
12

Comment by ansley.b.manke on 8 May 2013 21:37 UTC
This is fixed, so that the internal flag for what context information the user variable has and what it needs is now consistent for expressions with multiple sub-expressions.

yes? use coads_climatology
yes? say `sst,r=lsize`
 !-> MESSAGE/CONTINUE 12
12
yes?  say `sst[!-> MESSAGE/CONTINUE 1
1
yes? say `sst-sst[t=@ave](t=@ave],r=lsize`
),r=lsize`
 !-> MESSAGE/CONTINUE 12
12

and, all of these below should return XYT.  In our beta version of Ferret v685, they were retyrning XY, YT, and XY:
yes? use coads_climatology
yes? say `sst-sst[!-> MESSAGE/CONTINUE XYT
XYT
yes? say `sst-sst[t=@ave](t=@ave],r=shape`
)+sst[,r=shape`
 !-> MESSAGE/CONTINUE XYT
XYT
yes? say `sst-sst[x=@ave](x=@ave])+sst[t=@ave] ,r=shape`
 !-> MESSAGE/CONTINUE XYT
XYT

Additional tests have been added to the benchmark suite.

This is fixed. We'll get you an updated build.
The code for RETURN= calls a set of the routines that are used as Ferret evalulates the context for the different elements of an expression.  The previous fix is just what we want for RETURN= but it changed a routine common to both paths of the code.
Set a flag so the routine knows when we're doing RETURN=and when we're doing a full evaluation.
I think this logic might be used to give better results for SHOW GRID, which currently just gives info about the axes of the grid but not their size as they'll be in the result.  I'll open a new ticket on that.


[Help] Can anyone tell me how to extract frame from Webm video files?

I just get this UnsupportedFormatException while grabbing frame from webm files, but I see some code of webm in this project. Can anyone help me how to do it? Or where is the docs is?
Exception in thread "main" org.jcodec.api.UnsupportedFormatException: Could not detect the format of the input video.
	at org.jcodec.api.FrameGrab.createFrameGrab(FrameGrab.java:55)
	at org.jcodec.api.FrameGrab.getFrameFromFile(FrameGrab.java:295)
	at Main.main(Main.java:13)

Resolved with javacv.


Support comma-delimited subnets in firewall

ceph.conf supports a comma separated list of
subnet CIDR's for the public_network and the
cluster network. ceph-ansible should support
setting up the firewall for this configuration.
Closes: #4425
Related: #4333
https://docs.ceph.com/docs/nautilus/rados/configuration/network-config-ref/#network-config-settings
Signed-off-by: Harald Jensås<EMAIL_ADDRESS>

jenkins test pipeline

unrelated CI failure


Add parameter for accepting custom argument data

Migrated from https://boxstarter.codeplex.com/workitem/79
In reference to discussion at https://boxstarter.codeplex.com/discussions/541122#post1244147 it would be great if users could passin custom data to a boxstarter package that could then be used to forward on to chocolatey custom args.

So I really need to be able to pass args.  Until this is implemented is there any way even if not preferred to pass args.  I am creating a script to setup/reinstall a service on a number of different VMs and they have different roles so Ideally I would have one package and specify the role for each VM as it will be ran over and over via TeamCity

I couple thoughts, none are particularly attractive:

Have your package maintain a dictionary of hostnames -> role name pairs.
Store the role names as environment variables on the VMs

With option #2, you could have your script that calls boxstarter, set the environment variable on the VM before the boxstarter run.
Like I say I know none of these are that elegant and there may be a better workaround than these that I'm not thinking of, but perhaps this might point you in the right direction.


BUG: Provide consistent shape on Fortran-order np.ndarray views

The itk.Image shape should be consistent for Fortran-order np.ndarray views.
Check the .base attr recursively and its .f_contiguous flag status.
This only applies to GetImageViewFromArray -- GetImageFromArray creates
a copy that is C-order.

Nice!  Looking forward to trying this with MONAI!

Merging for 5.3rc3


Unable to send https request

Hi,
Currently client can able to send "http" requests (ie. http://httpbin.org/get), but can not able to send "https" requests (ie. https://httpbin.org/get)
Is this a bug or something I missed?
Thank you

Hi,
you can look at the beauty_client_.... _ssl.cpp in the examples.
It's fine to use beauty client with https requests. It was use a lot already with https (using openssl)
Regards,


Update processor ui

#2

Pull Request Test Coverage Report for Build 15

34 of 41 (82.93%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.694%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/state/validationSubscriber.js
0
1
0.0%

src/state/processorDispatchers.js
0
2
0.0%

src/state/reducers.js
34
38
89.47%

Totals

Change from base Build 11:
0.0%

Covered Lines:
263

Relevant Lines:
334

💛  - Coveralls


use higher ports for attachment http srv

Move port range higher up to decrease change of conflicting with other programs.
cc @songgao in case you care.

cc @malgorithms too

Thanks for the heads up. I'll vendor this into KBFS once it's merged.
Curious question: We had 1001 ports to choose from. Are there programs that use all of them?

It wasn't a problem for us, but if we bound to the port before another program that uses a port in that range, then that program would get blocked. Someone reported that they couldn't start Cassandra since it uses 7000.

Actually I don't want to use ephemeral range, I'm worried the app will conflict with itself on mobile when we need to be able to get the same port back.

I see. Makes sense.


Match Data missing

Hey guys,
since 08. November i have some Problems with the Tracker.
Bevor my Decks and win/los where show on the my profile section
but on 08. + 09. November there show only
"Matches Results 16:9 (0NaNh0NaNm)"
not what decks i have played
and after 09. there are no more data tracked
Gochiller's Matches History
mtga.cc/matches/#Gochiller
the last match showing here is from
07/11/2018
21:19 — 21:27
after that day no more data, may it haves something to do with that "Matches Results 16:9 (0NaNh0NaNm)" problem
I have always the Tracker running and make all Updates
sry if you allready know about this

You should make sure that you have v.1.4.6 and try Manual Reset.
If it doesn't help, send me your token and ZIP of your game log on<EMAIL_ADDRESS>

From now on, with v.1.4.8 time should be correct.


Connecting Signal R on a vue front end to asp.net core 6 web api back end

Hi, I'm new to asp.net core 6 and have successfully setup a Signal R connection within a self contained net core 6 web app.
Now I'm trying to separate it into a back end net core 6 web api connecting with a Vue front end app coded in Nuxt with the Quasar framework.
The websocket connection is being made to the ChatHub, and it appears the message is being sent. And it appears CORS is working fine.
However I'm not receiving it when it's sent out to all connected Vue clients. It's probably something simple off in the way I'm wiring the code. Here's how it looks so far:
import { ref } from 'vue';
import axios from 'axios';
import { useSignalR } from '@dreamonkey/vue-signalr';
import { inject } from 'vue';
setup () {
const signalr = useSignalR();
let user = "John Doe";
let message = "How's it going?";

signalr.invoke('SendMessage', user, message);

signalr.on('MessageReceived', ({ user, message }) => {
  this.user = user;
  this.message = message
});

return {
  date: ref('2022/02/15'),
  slide: ref('style')
}

}
Appreciate any pointers on where the logic may be off above. Thanks.
This is the back end ChatHub.cs
using Microsoft.AspNetCore.SignalR;
namespace chat_api.Hubs;
public class ChatHub : Hub
{
public async Task SendMessage(string user, string message)
{
await Clients.All.SendAsync("ReceiveMessage", user, message);
}
}
And in program.cs
app.MapHub("/chatHub");

Hello! It looks like you have a discrepancy between your message name. You're broadcasting an event called ReceiveMessage, but listening for one called MessageReceived. The names need to match exactly.

Thank you, that worked and messages are being received by all clients :)
Now only remaining part is how do you render in the view template the data received in the ReceiveMessage?

I just noticed that your import references @dreamonkey/vue-signalr instead of @quangdao/vue-signalr. If that's the package you're using and this doesn't help, you'll want to recreate this issue at https://github.com/dreamonkey/vue-signalr instead.
With either package, you should be able to set the response to your component state. That can change depending on what "style" you're using. With the Composition API in Single File Components, one option is something like this:
<template>
 <p>{{ message }}</p>
</template>

<script>
/* import ... */

export default {
  setup() {
    const signalr = useSignalR();
    const message = ref(''); // Create a ref aka a reactive property

    signalr.invoke('SendMessage', { message });

    signalr.on('MessageReceived', (response) => {
      message.value = response.message; // Set the value of the message property to the response
    });

    return { message }; // Expose the property to the view template
  }
};
</script>

Hello why is this sample different than on Wiki. I only ask because I have a problem
const SendMessage: HubCommandToken<MyObject> = 'SendMessage';  cannot find name when trying to compile.. But here you just use the string "SendMessage" ?

Hi, sorry for the slow response. This package accepts both versions, but using a raw string value will forego type-checking on the message content (on Commands, e.g. invoke) or response (on Events, e.g. on).
Are you importing HubCommandToken in the code that's failing to compile?


'Config.MetricRegistry=nil' to mute sarama metrics

Histograms and Meters are very useful metrics to collect, but the current implemetation has two drawbacks:

They are also heavy in comparison to their Gauge and Counter peers, and the volume of data and the number of topics and brokers being addressed may warrant disabling them for throughput reasons.
Entirely disabling rcrowlee/go-metrics is an awfully big hammer to use when just setting it to nil feels a lot more idiomatic.

High level view of change is that all instances of metrics.GetOrRegister$FOO were guarded by a test for a nil registry, and if the registry was nil, return the corresponding metrics.Nil$FOO to preserve proper interface mechanics.
Seem OK:

'go test' passed
'go vet' doesn't complain about anything besides printf format strings
Have consumed a couple hundred thousand non-synthetic messages through it so far

I thought the metrics lib provided some sort of NilRegistry mock you could use for this, but I can't find it now. That seems almost more idiomatic to me, especially since it's basically what UseNilMetrics already does.

That was what I thought a NilRegistry as well, but the only traces I found were the individual nil types.
The problem with UseNilMetrics is that it is global - everything registered in all registries will be the nil types as long as it is set.  If it were the case that I could 'UseNilMetrics=true, do all the sarama setup, UseNilMetrics=false' and know that things would get handled properly then that would be an option. But if either the sarama or not-sarama code registers metrics at runtime, that won't cover things without a lock around UseNilMetrics.
This change is library-scoped version of UseNilMetrics.

oops

Found a better way to do it, will deal with the metrics load in a more general way later...

@demaagd - hey - any update? I'm not using the metrics, but it's taking up a considerable amount of CPU, so I'd like to disable it. Unfortunately, I'm also using go-metrics :)
Thanks!

@demaagd - is this still planned? Thanks :)

Hack up a nil registry and use that. I have not pursued this line of
questioning further than that as my project is moving away from Kafka as a
transport mechanism.
On Nov 28, 2018 08:49, "Blake Caldwell"<EMAIL_ADDRESS>wrote:
@demaagd https://github.com/demaagd - is this still planned? Thanks :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/sarama/pull/1059#issuecomment-442519105, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACYzw3O2K6EU0YowMggFtip2KLCOXZKmks5uzr6zgaJpZM4SRcDm
.


Package up modules for powershell gallery

Published by @RichMercer:

https://www.powershellgallery.com/packages/TelligentInstall/0.0.4
https://www.powershellgallery.com/packages/TelligentLocalInstance/0.0.4


Support eo:snow_cover as attribute

EO processors often detect snow cover percentages in addition to cloud cover. Currently these information needs to be stored in custom properties which makes them not systematically discoverable. Therefore it would be good if this can be supported by the extension as an optional property, e.g. eo:snow_cover.

I like that idea. Would you be happy to create a proposal? I think a PR would help us get started.

Yes, here it is. I kept it simple, let me know if it works for you: https://github.com/stac-extensions/eo/pull/9


WIP: Status command

I don't know what is the problem with checkout to dist-git branches.
Output after running inside packit directory itself:
$ packit status
Cloning repo: https://src.fedoraproject.org/rpms/packit.git -> /tmp/tmpqs91dr48
Downstream PRs: No open PRs.

Dist-git versions:
Branch f29 doesn't exists.
Branch f30 doesn't exists.
master: 0.2.0

GitHub upstream releases:
0.2.0
0.1.0
0.0.1

Latest builds:
f29:
 - packit-0.1.0-1.fc29
f30: No builds.

Latest bodhi updates:
Update                 Stable karma    Unstable karma  status
-------------------  --------------  ----------------  --------
packit-0.2.0-1.fc29               3                -3  testing
packit-0.2.0-1.fc30               3                -3  testing
packit-0.1.0-1.fc29               3                -3  stable

Dist-git versions:
Branch f29 doesn't exists.
Branch f30 doesn't exists.
master: 0.2.0

Hmmm, The should exist: https://src.fedoraproject.org/rpms/packit/branches
(Is there some problem with the cloning?)

Also the status method in api.py starting to be quite huge. Would do you think about new file status.py where every section of status output would be implemented in its own function? I think it would be even better for testing.

The problem with branches is that gitpython does not fetch the remote branches, but you can search the refs in the remote:
In [1]: import git

In [2]: r = git.Repo(".")

In [3]: "f30" in r.remote().refs
Out[3]: True

In [4]: r.remote().refs["f30"].checkout()
Out[4]: <git.HEAD "HEAD">

It has one downside -- we got a detached head.

Git cli does exactly the same thing:
$ fedpkg clone sen
Cloning into 'sen'...
remote: Counting objects: 79, done.
remote: Compressing objects: 100% (76/76), done.
remote: Total 79 (delta 25), reused 5 (delta 0)
Receiving objects: 100% (79/79), 9.06 KiB | 3.02 MiB/s, done.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 20f28ec [packit] 0.6.1 upstream release

I fixed the issue and (force)pushed to your branch (Jirka taught me!).
Will merge once tests pass.


Modified sample mainfests upload to redirect to study sample manifest…

…s page.

Superceeded by: https://github.com/sanger/sequencescape/pull/1318 (Additional test changes to fix travis failures)


Revert back - Transactional state store API without retry

Description
Revert back - Transactional state store API.

Note: removed retry for state because of https://github.com/dapr/dapr/issues/1861

Issue reference
Reverting back to 0.10.0.
@chinzhiweiblank
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

@chinzhiweiblank @yaron2 @amanbha Please take a look at this. I removed state option property. I will create the separate pr for https://github.com/dapr/dapr/issues/1736

/ok-to-test

IMO, before we merge this, we need to handle this #1736 to surface this api with metadata at transaction level.

IMO, before we merge this, we need to handle this #1736 to surface this api with metadata at transaction level.

oh I misunderstand #1736 I thought we need to add one state option(consistency, concurrency) for all requests instead of per state options. Do I misunderstand ?
cc/ @LMWF

The idea with #1736 is to have metadata at the TransactionalRequest level, instead of using the ones within each .Request field.

@amanbha @LMWF It requires the change of state request struct in component-contrib first. Changing this struct requires another change in actor state store. I would like to merge this one first. Then I will change component-contrib and create the pr to have metadata and stateoptions on transactional request.

actor state store. I

@youngbupark If we cant make changes for #1736 in this milestone, then we should keep this PR open and merge in next milestone with all the changes,

actor state store. I

@youngbupark If we cant make changes for #1736 in this milestone, then we should keep this PR open and merge in next milestone with all the changes, Changes for #1736 can happen in a separate PR, but should be in same milestone.

yes I will take both in the same milestone.

actor state store. I

@youngbupark If we cant make changes for #1736 in this milestone, then we should keep this PR open and merge in next milestone with all the changes, Changes for #1736 can happen in a separate PR, but should be in same milestone.

yes I will take both in the same milestone.

Sounds great, thanks!

/ok-to-test

actor state store. I

@youngbupark If we cant make changes for #1736 in this milestone, then we should keep this PR open and merge in next milestone with all the changes, Changes for #1736 can happen in a separate PR, but should be in same milestone.

yes I will take both in the same milestone.

Sounds great, thanks!

@amanbha @LMWF Please review the pr again. it includes #1736 change.

/ok-to-test

/ok-to-test

Thanks for this contribution, @chinzhiweiblank!


Add manifest.yaml to the renovate configuration

Overview
The manifest.yaml defines the build dependencies for OCB. Renovate should be able to automatically manage these dependencies as well. https://secustor.dev/blog/renovate_managing_a_ocb_distribution/
Definition of Done

Renovate manages those dependencies
Updates the file as a whole ensuring successful builds & automatic updates to the latest.

Giving this a couple more days to see if any packages are updated. Will be waiting for v0.93.0 comes out for collector contrib.

Packages have been updated accordingly. There were failures that we have to manually fix, but this is good.


Update stable version in repo from 0.0.0 to 1.0.3

Think about adding version 1.0.3 to stable repository.
Version: stable=0.0.0 (0 days old) => latest=1.0.3 (88 days old)
Installs: stable=0 (0%), latest=25 (20.33%), total=123
Click to edit

Done


Running with stderr causes exception

Description
Running with the --stderr arg causes this below exception:
> vendor/bin/phpunit --stderr

In PrinterContents.php line 56:

  Argument 1 passed to NunoMaduro\Collision\Adapters\Phpunit\Printer::__const
  ruct() must be an instance of Symfony\Component\Console\Output\ConsoleOutpu
  t or null, string given, called in /Users/<name>/PhpstormProjects/service
  s/vendor/phpunit/phpunit/src/TextUI/TestRunner.php on line 1159

Not sure if you want to do anything about it since I only encountered this after  upgrading to v4 and using the new Printer class. I have removed the --stderr  argument and it works like a charm  😄
Environment
PHP Version: 7.4
PHPUnit Version: 9.1.1
Package Version: 4.2.0

I think the collision printer don't support that issue, feel free to pull request that feature.


Update README.md

Changes
When specifying the package version, unexpected problems may occur, so it has been removed and composer has been left to decide.
Breaking changes
N/A

Could you list one?

Good evening,
Sure here I list one
There may be a conflict in the versions of the project dependencies. Example, the package nunomaduro/larastan version 2.1.0 (which is the one you choose) requires the version of illuminate/console in the range of ^9; but some other package in the project that requires a different version of illuminate/console may conflict. To resolve this conflict you would have to update the dependencies, adjust the dependency versions manually, or revise the project dependencies.
All this is solved by just letting composer install the version of nunomaduro/larastan that suits you best.

Hi,
I don't think this is needed. Thank you.


typo, remove duplicated adding the

@robstoll - thanks!
Can you please join our contributors community by signing JFrog's CLA so that we can merge this fix?

bit too much for a typo, so no thanks


Can CaffeOnSpark used for deployment?

Hi,
I have minor knowledge on spark and recently am exporing CaffeOnSpark framework.
I notice that caffeonspark read dataframe as datasource, and do some partitions on it and distribute partitions to executors. What if datasource contains single image?
I wonder if caffeonspark can read single image at a time and predict its label in a distributed manner? Namely, can I speed up predicting single image's label using caffeonspark clusters?
I have intention to use framework for DL model deployment, but this question lingered around and I'm reaching out for insights.
Many thanks!!

If a dataset contains only one image, then only one partition will have an image, the rest are empty.
You can set batch size = 1 during inference (prediction) stage. This is actually recommended. If the batch size does not divide total dataset size, the reminder will be discarded as of current implementation. This is OK in training, but not desirable in inference. So at inference, you may want to set the batch size to 1, or make sure the batch size divides the total number of images.

Thanks, this really answers my question.
However, based on your answer, if there is one partition, the inference performance will not horizontal scale with increasing of executors. Am I right?

You want to do on-line (maybe even real-time) inference. CaffeOnSpark does not quite meet your requirement.
A typical use case for CaffeOnSpark is as follows. You have a ton of images sitting on HDFS, you want to predict all of them. You launch CaffeOnSpark, say with N executors, the dataset gets cut into N partitions. Each executor work on one partition. As you can see, this is a batch operation. You don't change the number of executors during prediction. It's fixed for the entire process.

@junshi15 This finally confirmed my speculation.  It seems no available clustering-solution to do on-line inference currently. Maybe virtualization is a way to go.
Thanks! I will close this issue.

You may want to look into tensorflow serving, if serving is your goal.

@junshi15 Yes, serving/production is my goal. Seems really what I want, many thanks!!


Add Auto-Update Feature for Kodi TV Integration and Include Guide in Readme

Hi there!
I'm a big fan of your work on GitHub and I really appreciate all the effort you put into making Kodi TV a great experience. I have a suggestion for an improvement that I believe will make Kodi TV even better.
I think it would be great if you could add an auto-update feature to your repository, which would update Kodi TV every time changes are made in your repository. This way, users won't have to uninstall and reinstall Kodi TV every time there's an update, which can be a time-consuming process. Additionally, if can create a short link using bit.ly, it would be easier in your script to update latest package link (of latest zip file) automatically.
Moreover, I've created a full guide and tips channel for Kodi TV (https://t.me/JioTVKodi) , which I believe would be helpful for other users. I would appreciate it if you could add it to your readme, so others can benefit from it as well.
Lastly, I would love to talk to you more about JioTV. Could you please contact me on Telegram at https://t.me/max_parker ?
Once again, thanks a lot for your hard work and dedication. Looking forward to hearing from you soon.
Best regards,
Max Parker

i dont think auto update is possible coz its a fork project auto update will work if update ws pushed original repo which is https://github.com/botallen/ and its inactive for a year

You can fork and modify to create your own repo. Example: https://github.com/sandeep1027/repository.jioTvPlugin

You can fork and modify to create your own repo. Example: https://github.com/sandeep1027/repository.jioTvPlugin

I am sorry since I don't have coding knowledge.


feat(minify shadowroots): add rollup-plugin-minify-html-literals

Related Ticket(s)
No ticket
Description
Adds rollup-plugin-minify-html-literals to the build pipeline. This minifies the HTML resulting from each component's render() function.
Changelog
Changed
Added rollup-plugin-minify-html-literals to rollup config

There's a change needed to the table-of-contents component. See here

@marcelojcs make sure to run yarn ci-check from the project root. It's pointing out the errors in the ci-check job.
carbon-for-ibm-dotcom/packages/carbon-web-components/src/components/checkbox/checkbox-story.ts
Warning:   13:10  warning  'ifDefined' is defined but never used  @typescript-eslint/no-unused-vars

Now that the deploy preview is done, I don't actually see a difference in bundle size. Perhaps I should be checking some other way? Examples I looked at:
https://1.www.s81c.com/common/carbon-for-ibm-dotcom/version/v2.0.0/search.min.js
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/search.min.js
https://1.www.s81c.com/common/carbon-for-ibm-dotcom/version/v2.0.0/filter-panel.min.js
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/filter-panel.min.js
In both examples the bundles are the same size 🤷.

The impact of this change likely won't reflect in bundle sizes, but should appear in total node counts.
Card Group with Card-In-Card demos:

Current v2
This PR Preview

Current

This PR

Note that the above comment is only testing the rollup changes which affect the CDN assets, not the gulp changes that impact the npm packages.

Also, how is this PR a duplicate of https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/11207?

Also, is this PR a duplicate of #11207?

This PR is #11207. Do you mean #11216? #11216 is against the v1 branch, wheras this one is against main, I believe that's the only difference, but @marcelojcs and/or @bruno-amorim can correct me if I'm wrong.

Do you mean #11216? #11216 is against the v1 branch

Oops, pasted the wrong link. Yep I was referring to those other 2, but totally missed the different target branches. Got it now, thanks!

The gulp-minify-html-literals package was from here. I'm not sure why that package no longer exists, but we can remove it from this PR.
This PR is also on hold, pending the project's update to Lit v3 because that version seems to have scooped up the underlying minify-html-literals project.


iOS refresh control doesn't show up after initial pull to refresh

On iOS, the refresh control won't show if the refresh prop changes outside of a manual pull to refresh.
React Native version: 0.60.3
System:
    OS: macOS 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
    Memory: 50.39 MB / 8.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.6.0 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.1, 28.0.2, 28.0.3
      System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64
, android-28 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.1 AI-173.4907809
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.3 => 0.60.3
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Steps To Reproduce

Open this snack https://snack.expo.io/@kingdaro/scrollview-refresh-control-bug
Tap "trigger refresh", the control will show up as expected
Pull to refresh, the control shows up as expected
Tap "trigger refresh" again, the control does not show up

Describe what you expected to happen:
The refresh control should always show if refreshing is true.
Snack, code example, screenshot, or link to a repository: https://snack.expo.io/@kingdaro/scrollview-refresh-control-bug

same issue

This still occurs

The same issue occurs on my side. As far as I can see, this PR describes the same behavior and should fix it: https://github.com/facebook/react-native/pull/27397, so hopefully this will be fixed with the next release.

I ran the snack with expo 37, ran through the same steps, bug still happens. Unless 37 isn't on the latest RN version, this still happens

This appears to be fixed on expo v38! 🎉


Mbarton/remove guava from common 2

What does this change?
Not sure this is the way to do it but merging this into a feature branch so we can test it - see https://github.com/guardian/giant/pull/74 for details

does this mean you tested it successfully? what do we do with Michael's original branch then? just merge as well (presumably it's a no-op now)?

I merged Michael's change into a dev branch I created so that teamcity would build it (it doesn't build forks for security reasons). Now that it's tested I will delete the dev branch and have merged Michael's original PR


Do not realize data store when processing attach message

Currently, we realize newly created data stores when processing attach message. We should not do this and only realize data stores when they are loaded. Basically, the following piece of code should be removed:
https://github.com/microsoft/FluidFramework/blob/fb334bf715cbded0fea93e63f2d2bcb2f5000604/packages/runtime/container-runtime/src/dataStores.ts#L199
Simply looking at the code, it seems there should not be any side effects of this. However, this need some evaluation to ensure that is the case.

@vladsud @anthony-murphy FYI


Fix GoToDef (F12) for notebook documents

Starting as a Draft quick to check tests. Also for some reason I didn't get the description template. Will edit it in.

@IanMatthewHuff We don't use the PR template anymore. We have automation that handles it.

Adding skip news as the associated work item is in the Jupyter repo. This is the issue here:
https://github.com/microsoft/vscode-jupyter/issues/4972
Also Insiders tests failed, which I believe is due to the needed API changes that Don just fixed. Will merge those in to see if that fixes the tests.

Codecov Report

Merging #15640 (73a2dd2) into main (f04e60f) will increase coverage by 0%.
The diff coverage is 4%.

@@          Coverage Diff           @@
##            main   #15640   +/-   ##
======================================
  Coverage     64%      64%
======================================
  Files        557      557
  Lines      26867    26835   -32
  Branches    3911     3908    -3
======================================
- Hits       17403    17402    -1
+ Misses      8730     8699   -31
  Partials     734      734

Impacted Files
Coverage Δ

src/client/common/application/types.ts
100% <ø> (ø)

...t/jupyter/languageserver/notebookConcatDocument.ts
5% <0%> (-1%)
:arrow_down:

...client/jupyter/languageserver/notebookConverter.ts
1% <0%> (-1%)
:arrow_down:

.../jupyter/languageserver/notebookMiddlewareAddon.ts
3% <0%> (ø)

src/client/common/application/notebook.ts
20% <100%> (+12%)
:arrow_up:

@DonJayamanne Good call. Added 5125 in Jupyter for that. I can pick it up soon / today. Listed that we need both intra ipynb test and .ipynb to external .py file tests.


[DOCFIX] Add OpenSSF Scorecard for README.md

What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

alluxio-bot, merge this please

@HelloHorizon fyi see if this interests you :)


Chore/tomte linters

Proposed changes
Linter fixing for the tomte branch that involved many changes.
Most changes are migrations from old style string formatting to f-strings, done with the flynt tool.
Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[x] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
Base: 94.15% // Head: 94.14% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (5b26064) compared to base (b37fed1).
Patch coverage: 96.04% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           chore/tomte2     #365      +/-   ##
================================================
- Coverage         94.15%   94.14%   -0.01%
================================================
  Files               204      204
  Lines             18521    18520       -1
================================================
- Hits              17438    17436       -2
- Misses             1083     1084       +1

Flag
Coverage Δ

unittests
94.14% <96.04%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aea/cli/add.py
79.09% <ø> (ø)

aea/cli/check_packages.py
67.29% <ø> (ø)

aea/cli/generate_all_protocols.py
29.34% <0.00%> (ø)

aea/cli/generate_key.py
100.00% <ø> (ø)

aea/cli/generate_wealth.py
100.00% <ø> (ø)

aea/cli/ipfs_hash.py
37.60% <ø> (ø)

aea/cli/publish.py
77.84% <ø> (ø)

aea/cli/upgrade.py
28.33% <0.00%> (ø)

aea/cli/utils/config.py
94.73% <ø> (ø)

aea/cli/utils/generic.py
86.66% <0.00%> (ø)

... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Feature]: add lack datapartitions monitor

[Enhancement] add monitor for lackPartitions in datanode #1625
[Enhancement] check data partition in memory match with those in disk and report lack data partition to the metric #1641

resolved in release-3.2.1


Smaller set of IUC update

So I can make progress on workflow updates.

@galaxybot deploy this

@galaxybot deploy this


EN blog no translation - change to "German version only"

This PR resolves issue #2683 "Missing blog translations into English" by replacing promises that an English translation may come soon using the replacement text "German version only".
Also one typo regarding "*dm drogerie-märkte" is corrected.

Good morning @MikeMcC399, thanks!


Add option to not notify

I'd love to not get a notification of when the server restarts.

working on it

Sweet! Thank you!
Just so you know: https://github.com/microsoft/vscode/issues/187208#issuecomment-1643014397

Thanks for the issue,  @kentcdodds, the enhanced version had been released, pls update to v0.0.5 and let me know if it works. Thanks!
https://marketplace.visualstudio.com/items?itemName=neotan.vscode-auto-restart-typescript-eslint-servers


ClippingSubsampler: accuracy/speed tradeoff

Currently the ClippingSubsampler has 2 modes: precise and not precise. In not precise mode we use ffmpeg to cut of the video according to the passed in time ranges but with the c="copy" codec which uses existing keyframes to cut the video up into clips. This is fast because there is no re-encoding however results in inaccurate clips since there might not be a keyframe EXACTLY where you need it.
Precision is needed for things like cut detection (and clipping based on detected cuts) so with the precise=True mode we run don't set the "copy" codec and additionally we specifically reencode the video with a keyframe every 10 frames by setting constant GOP. This is very slow (up to many seconds for a short video, one example I did was like 8 seconds for a 1.5min video). I suspect there is something wrong here and we can do better.
Optimizations to look at:

only force_key_frames at cuts
something could be wrong with how this is done, when you run it with quiet=False it feels like it re-encodes EACH clip when you might just want to re-encode the whole video once and then do normal clipping?
other tools like decord or whatever to perform clipping or re-encoding when needed

It also needs to be noted that currently the ClippingSubsampler only works for non-overlapping segments. This doesn't need to be the case. Need to think about solutions for that


Update Export Pages for Company Cards to include amendments

Details
Update Export Pages for Company Cards to include amendments
Fixed Issues
$ https://github.com/Expensify/App/issues/40792
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/28352309/8e310f5f-33e5-4044-968c-257fe46092c0

MacOS: Desktop

@dukenv0307 I will review this one as it's part of QBO

ad hoc build brewing -> https://github.com/Expensify/App/actions/runs/8818710475

@Expensify/design, while we're doing the code review, can you check the design review using the ad hoc build here?

🙈 @shawnborton @dubielzyk-expensify shouldn't all those hint texts be styled like this?

Instead of being totally separated from the push input and in text color?

@dannymcclain I totally agree with you - I think the issue we run into is that we don't have this push row component in a good place where the hint text is considered part of the hoverable area. @narefyev91 does that sound right?
Otherwise I totally agree, I would love to make them look like your mocks above!

@dannymcclain I totally agree with you - I think the issue we run into is that we don't have this push row component in a good place where the hint text is considered part of the hoverable area. @narefyev91 does that sound right?
Otherwise I totally agree, I would love to make them look like your mocks above!

If that's the case, should this kind of improvement come separately for all places we have push row+hint text in the app? A little bit mindful of adding a refactor to this PR.

Asked for confirmation on Spanish translations from @Gonals & @pecanoro here.
They might suggest updates in the PR directly.

Looking at the screenshots... for this one:
If we have a RBR, wouldn't there be an error message below the row too?
Also, the RBR dot feels a bit far away from the right arrow? Is that how the standard component is styled, or something we introduced here?

Yeah - the error message should come from API side - and right now it's not in sync for that field - it will be message 100%
Regarding dot - it's our standard component - and nothing was introduced in this PR. I think i will take a look on this during follow up for error message styling @shawnborton

@dannymcclain I totally agree with you - I think the issue we run into is that we don't have this push row component in a good place where the hint text is considered part of the hoverable area. @narefyev91 does that sound right?
Otherwise I totally agree, I would love to make them look like your mocks above!

Yeah! that's right - hint text is not a part of the hoverable area. We do not have insider MenuItem standard component

Looking at the screenshots... for this one:
If we have a RBR, wouldn't there be an error message below the row too?
Also, the RBR dot feels a bit far away from the right arrow? Is that how the standard component is styled, or something we introduced here?

Yeah - the error message should come from API side - and right now it's not in sync for that field - it will be message 100% Regarding dot - it's our standard component - and nothing was introduced in this PR. I think i will take a look on this during follow up for error message styling @shawnborton

Can someone fill me in on what would cause RBR/an error on that field to choose an export method for company card spend? 🤔

Looking at the screenshots... for this one:
If we have a RBR, wouldn't there be an error message below the row too?
Also, the RBR dot feels a bit far away from the right arrow? Is that how the standard component is styled, or something we introduced here?

Yeah - the error message should come from API side - and right now it's not in sync for that field - it will be message 100% Regarding dot - it's our standard component - and nothing was introduced in this PR. I think i will take a look on this during follow up for error message styling @shawnborton

Can someone fill me in on what would cause RBR/an error on that field to choose an export method for company card spend? 🤔

Probably if API failed? 500 or something else

Cool, I agree we can look at the hint text improvements as a follow up. Ideally they are part of the hoverable area and sit closer to the push row above them.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.66-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.66-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


WIP util:  Add absl's new flat_hash_map and flat_hash_set to the build system and use it in a couple of places

Description: absl::flat_hash_map is a newly open-sourced hash-table from Google that has very good memory and performance with certain hash-table patterns. This adds the new build infrastructure needed to bring in flat_hash_map/set and uses them in places where I could quickly measure memory-usage reduction.
For more info on what makes absl::flat_hash_map efficient, see https://www.youtube.com/watch?v=ncHmEUmJZf4&t=2371s (1 hour). TL;DR:

flat_hash_(set_map) and node_hash_(set|map) are sweeping the google codebase as they are mostly better in every dimension to alternatives, particularly unordered_(set_map). Among the sources of hotness are aggressive exploitation of SSE2 instructions, and a very L1-cache-aware design.
node_hash_(set|map) is better in every dimension most of the time, and is an easy-choice for a large-scale refactor. It's a 99.9% drop-in replacement with the rare exception being code that directly cares about bucket_count. This PR changes the maps from string in thread_local_store from unordered_map to node_hash_map.
flat_hash_(set|map) is the best choice when the keys and values are small and cheap to move, as all of those are stored inline in the hash array -- there's no indirection. This means that when the table capacity is larger than its size, there will be more wasted space. This PR brings in flat_hash_(set|map) for some tables in the stats infrastructure that meet this criteria, and validates that with a memory-consumption unit test.

Note that some of the other PRs in flight to address  #4196 will make flat_hash_map a win for more cases, notably #4711.
It is very hard to understand the benefit without measuring memory usage -- at a minimum, so this #4714 should be checked in first, and this should be a pattern for switching to this library.
Risk Level: medium -- brings in a new version of absl
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a

Ping
On Sat, Oct 20, 2018, 8:08 PM stale[bot]<EMAIL_ADDRESS>wrote:

This pull request has been automatically marked as stale because it has
not had activity in the last 7 days. It will be closed in 7 days if no
further activity occurs. Please feel free to give a status update now, ping
for review, or re-open when it's ready. Thank you for your contributions!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/4715#issuecomment-431627683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2kPbRl4SiARAfXppXEyj9f0azE-5bNks5um7r_gaJpZM4Xax_S
.

I will review. Looks like it needs a master merge though.

I will probably be able to do a master merge on Wednesday.... Don't have
access to my computer now.
I was pinging just to avoid stalebot.  The benchmark PR would be good to
get in first anyway.
On Sat, Oct 20, 2018, 10:38 PM Matt Klein<EMAIL_ADDRESS>wrote:

I will review. Looks like it needs a master merge though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/4715#issuecomment-431634044,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2kPTnhCgwAk3OLv3QbVmXNPImUynBkks5um940gaJpZM4Xax_S
.

@jmarantz is this the next one? Merge master?
Also, I will watch the video, but do you mind briefly summarizing what a flat hash map is in the PR and why you think it's going to be better here? I'm just curious if flat hash map is always better or if it's not always better/

OK just ping me on whichever one you want me to review next when ready.

Leaving this a WIP as it probably would be nice to establish speed-test baseline as well. Maybe I'll switch the other thread-local-storage maps to node_hash_* so they are fast too, if not small. Once #4711 is in they can all be flat_hash_*

Bringing in the node_hash_* was easy and an immediate win, though less of a win than #4711 which is why I didn't pursue it before. But considering this PR independently it's easy enough.
I still want to add a baseline speed test though so we can see the perf impact, so leaving this a WIP

closing this for now as well in favor of #4872 , although this PR appears to be a modest unambiguous  win even on its own.  LMK if you'd prefer to get this in separately (e.g. so others could use flat_hash_map) and I can fix the CI issues (order-sensitivity in tests iterating over unordered-maps)


Requests been made returns None after a hour

Iam using people_also_ask library with 120-150 seconds delay for every request with 4g proxies. after using for a hour, it just not responding for any query i made for both question and answers.
well if i try with python requests and 4g proxies, the following code, it was working well
query = 'how do i donate my car to the dmv in Adams Morgan city?'
response = requests.get(f'https://www.google.com/search?q={query}&start=0', headers=header, proxies=proxies).text
tree = lxml.html.fromstring(response)
questions = tree.xpath('//@data-q')
print(questions)

any thing iam doing wrong, do i need set more delay for every request?

Hello @sunny9495-dev, how much the 4g proxies usually cost?


Update dependency @heroicons/react to v2

This PR contains the following updates:

Package
Type
Update
Change

@heroicons/react
devDependencies
major
^1.0.1 -> ^2.0.0

Release Notes

tailwindlabs/heroicons (@heroicons/react)
v2.1.3
Compare Source

Improve project READMEs (#1152)

v2.1.2
Compare Source

Include license file with published packages (#1151)

v2.1.1
Compare Source
Fixed

Fixed chevrons in mini set (#1106)

v2.1.0
Compare Source
Added

Added micro icon set (#1104)
Rebuilt some icons for better clarity (#1104)

v2.0.18
Compare Source
Fixed

Fix incorrect esm paths in package.json for both React and Vue (#988)

v2.0.17
Compare Source
Fixed

Fix React icon types (#966)

v2.0.16
Compare Source
Fixed

Add root-level import (#936)

v2.0.15
Compare Source
Fixed

Fix icon tree-shaking (#929)

v2.0.14
Compare Source
Fixed

Fix React ref types (#903)

Changed

Specify explicit package exports (#920)

v2.0.13
Compare Source
Fixed

Fix minus icon alignment (0a88242)

v2.0.12
Compare Source
Fixed

Add title and titleId props to the React types (#814)
Fix information-circle icon alignment (#846)

v2.0.11
Compare Source
Added

Add new icons (bug-ant, eye-dropper, pause-circle, play-circle, power, rocket-launch, square-2-stack-3d, stop-circle, trophy, tv, viewfinder-circle, window) (#809)

v2.0.10
Compare Source
v2.0.9
Compare Source
v2.0.8
Compare Source
v2.0.7
Compare Source
v2.0.6
Compare Source
v2.0.5
Compare Source
v2.0.4
Compare Source
v2.0.3
Compare Source
Added

Add missing icons from v1 (bars-arrow-down,bars-arrow-up,chevron-up-down, rss) (#758)

Fixed

Fix inconsistent naming for 'code-bracket' icons (#756)

v2.0.2
Compare Source
Fixed

Fix typo in exclamation-* icons (#735)

v2.0.1
Compare Source
Fixed

Fix incorrect esm paths in package.json for both React and Vue (#988)

v2.0.0
Compare Source
Added

Completely new icon set, checkout the release notes for more info.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-qPxE1QbwSH: Connection refused

Describe the bug
Some applications seem to depend on this socket that does not exist.
[davidak@gaming:~]$ gnome-disks

(gnome-disks:20836): dbind-WARNING **: 22:33:38.492: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-qPxE1QbwSH: Connection refused

[davidak@gaming:~]$ io.elementary.code --version
[WARNING 22:33:46.720019] [dbind] Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-qPxE1QbwSH: Connection refused
Code 3.4.1

[davidak@gaming:~]$ ll /tmp/dbus-qPxE1QbwSH
ls: cannot access '/tmp/dbus-qPxE1QbwSH': No such file or directory

[davidak@gaming:~]$ systemctl --user show-environment -l | grep DBUS
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus

The dbus deamon is running:
[root@gaming:~]# systemctl status dbus.socket
● dbus.socket - D-Bus System Message Bus Socket
     Loaded: loaded (/nix/store/f7xpkxhkn06yi09zd8a3wj1k915i4nmd-dbus-1.12.20/etc/systemd/system/dbus.socket; linked; vendor preset: enabled)
     Active: active (running) since Thu 2020-11-12 04:06:36 CET; 2 weeks 2 days ago
   Triggers: ● dbus.service
     Listen: /run/dbus/system_bus_socket (Stream)
     CGroup: /system.slice/dbus.socket

Nov 12 04:06:36 gaming systemd[1]: Listening on D-Bus System Message Bus Socket.

Reproducible with:

gnome-disks
gnome-font-viewer
gnome-mahjongg
gnome-system-monitor
gnumeric
gajim
io.elementary.calculator
io.elementary.calendar
io.elementary.camera
io.elementary.code
io.elementary.files
io.elementary.music
io.elementary.photos
io.elementary.screenshot-tool
io.elementary.switchboard
io.elementary.videos
darktable
dino
fractal
meld
mumble
com.github.philip-scott.notes-up
remmina
obs
virt-manager

It seem all GNOME/elementary desktop apps, maybe all GTK apps?
Not reproducible with

gimp
audacity
kdenlive
klavaro

To Reproduce
Steps to reproduce the behavior:

Run gnome-disks for example
Get error (warning): Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-qPxE1QbwSH: Connection refused
The application starts and is usable. Not sure which consequences the message has

Expected behavior
No errors when applications are started from terminal
Additional context
I'm using the Pantheon desktop. This is the complete config: https://codeberg.org/davidak/nixos-config/src/commit/8a839a6d03ff705c3698dc01187757b4a8f37abe/machines/gaming/configuration.nix
Notify maintainers
@worldofpeace @jtojnar do you have an idea what this is?
Metadata

system: "x86_64-linux"
host os: Linux 5.8.18, NixOS, 20.09.1721.896270d629e (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.7
channels(root): "home-manager-20.09, nixos-20.09.1721.896270d629e, nixos-hardware, nixos-unstable-21.03pre251123.b839d4a8557"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

Hi @davidak, have you managed to fix this error?
Have you experimented with dbus-run-session ?

Hi @davidak, have you managed to fix this error?

I don't had the issue in some time. I think a reboot fixes it.

Have you experimented with dbus-run-session ?

No


Unable to move a session entry to folder located upwards

i have around 200 saved sessions in various folders. If you click a session in
order to move it (drag)to different folder you can only drag it downwards
(sessions start scrolling down..) but it does not scroll sessions when going up
the selected session entry that you want to move. Therefore unable to assign it
to a folder located visually at the upper session folders..

What version of the product are you using? On what operating system?
1.4.05 on Windows Pro 8 & 8.1 64bit

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 22 Aug 2014 at 5:58

Closing this issue but all hope is not lost! We still want to help.
See: https://github.com/jimradford/superputty/wiki/Legacy-Imported-Issues on how to help us to help you!


hubstaff: 1.6.5-31be26f1 -> 1.6.6-61e2338c

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for hubstaff is: "Time tracking software"
meta.homepage for hubstaff is: "https://hubstaff.com/"
meta.changelog for hubstaff is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c/bin/HubstaffClient had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.6.6-61e2338c with grep in /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c
found 1.6.6-61e2338c in filename of file in /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
hubstaff

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hubstaff https://github.com/r-ryantm/nixpkgs/archive/b95551e70ee1308e2b6d953550fb8ae3d0da2344.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c
ls -la /nix/store/miwc06dw4zw5rn4b5hfh9i330gl91l9m-hubstaff-1.6.6-61e2338c/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

hubstaff

Maintainer pings
cc @michalrus @srghma for testing.


DetektAll failed (LongMethod 61/60) SendView/SendForm

Describe the issue
Detekt static code analyzation failed on SendForm composable method of SendView screen with LongMethod - 61/60.
The method consists of several UI elements ZEC Amount TextField, Message TextField, PrimaryButton, etc. Some of them should probably be moved to separate composable.
Actual behavior + errors
> Task :detektAll FAILED complexity - 20min debt 	LongMethod - 61/60 - [SendForm] at ./secant-android-wallet/ui-lib/src/main/java/co/electriccoin/zcash/ui/screen/send/view/SendView.kt:141:13

This will be resolved while reworking the UI accroding to the new Figma design.


Bump jest packages

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Do I have to downgrade Nwjs or node-webkit-builder in order to fix this error?

I get this error
node-webkit-builder ERROR: The version 1.0.11 does not have a corresponding build posted at http://dl.node-webkit.org/. Please choose a version from that list.
In that list I see http://dl.nwjs.io/?C=M;O=A latest version is 0.13.0, Does it mean I have to downgrade NWJS or choose another version of the builder?
I'm using windows 8.1 (virtualbox) to build an app for all platforms.

I'm seeing this issue as well (on Mac). And, this issue is because the necessary files for 0.13 are in another folder called alpha, instead of just being in the root folder. I'm not doing development on my nw.io project at the moment, so I'll wait until 0.13 comes out of alpha, but it is kinda of annoying.

@NetOperatorWibby if you ever find fix it, please let me know, I'll try the alpha soon but ain't optimistic, if it works I'll let you know too.seems we are on our own, tete a tete.
I've got more errors using nodejs in my days than haskel, perl, lisp and C combined, i wish i was born in the 50s and worked in 70s and 80s and died or retired by now, i don't like working with those new hot and cool OOP languages, I prefer perl and C any day

I solved this by just using version 0.12.2 for now.
var nw = new gulp.NwBuilder({
  version: '0.12.2',
  files: ['./package.json', './build/**/*'], // use the glob format
  platforms: ['osx32', 'osx64', 'win32', 'win64'],
  buildDir: './release'
});

PS - I don't think you really want to work on code in the 70s or 80s :P. There weren't even step-through debuggers back then! Haha

Just specify the version now until this is fixed. Closing this in favour of #222

sorry for the late reply guys, will try it tomorrow and mark it as fixed, thanks for your help

@elieobeid7 No problem... I've closed the issue. I've just pushed a fix for the problem now as well. New version coming soon.

The version 0.13.0-alpha3 does not have a corresponding build posted at http://dl.nwjs.io/.
I got this error today.

I get this error today.

It works when I do what chevex said:
By using version: '0.12.2' it built successfully.


Add a link to DSharpPlus

Lmao how could i not have linked to my own lib :^)
thanks man, merging..


Orchard Core 1.2.0

https://github.com/OrchardCMS/OrchardCore/releases/tag/v1.2.0

Thanks for the contribution!


Patch 1

auto save the name to the (Save to scene) when (Load from scene)

Can you recreate the commit and target it to the develop branch? Seems like you used the develop branch but committed to master, which creates the huge commit log you see (difference between develop and master)
Thanks:)


Bundle provider directory override

Hi,
Thanks for the great work done here so far. It will be amazingly useful in a project I'm currently working on.
I would like to know if there is any way to override https://github.com/mariusbalcytis/webpack-bundle/blob/6dce0c055ef4857a5c67e8fb48604edf86cca44f/src/Resources/config/services/providers.xml#L24 . In my project structure we have the templates next to their controllers, so it would be awesome if I could add them from there also.
Thank you once again!

You could just register another asset provider using tag like this:
<service id="my_custom_asset_provider"
                 parent="maba_webpack.asset_provider.twig_directory.base"
                 public="false">
    <tag name="maba_webpack.asset_provider"/>
    <argument type="service">
        <service class="Maba\Bundle\WebpackBundle\AssetProvider\DirectoryProvider\BundlesDirectoryProvider">
            <argument type="service" id="kernel"/>
            <argument>/Controller</argument>
            <argument>%maba_webpack.enabled_bundles%</argument>
        </service>
    </argument>
</service>

Replace /Controller with directory relative to each bundle.

Thank you very much for the fast response! Will try it out later today.


Node Debug Auto-attach

Extension Name: debug-auto-launch
Extension Version: 1.0.0
OS Version: Linux x64 4.18.7-200.fc28.x86_64
VSCode version: 1.28.0-insider

We have written the needed data into your clipboard. Please paste:```json
{
"activationTimes": {
"startup": true,
"codeLoadingTime": 8,
"activateCallTime": 1,
"activateResolvedTime": 0,
"activationEvent": "*"
}
}

Pleas follow our issue reporting guideline.

You are really helpful, octref.  Thanks.


Add support for ODBC Server Side Parameters

Description
Allow passing through Cluster Configuration parameters via profiles.yml when using the odbc connection method.
This allows configuration of values that would need to be set via SET to be run in the Spark session and take effect on DBT models.
E.g.:
spark_dbt:
  target: default
  outputs:
    default:
      type: spark
      method: odbc
      driver: /opt/simba/spark/lib/64/libsparkodbc_sb64.so
      schema: default
      host: [hostid]
      token: [token]
      cluster: [clusterid]
      port: 443
      connect_retries: 3
      connect_timeout: 20
      server_side_parameters:
          "spark.databricks.delta.schema.autoMerge.enabled": True
          "spark.sql.jsonGenerator.ignoreNullFields": True

Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Hey @jtcohen6, I have.
With this patch I've successfully used the spark.databricks.delta.schema.autoMerge.enabled setting above to use Delta Lake Automatic Schema Evolution to update a table schema with a MERGE statement from an incremental model:

Without this patch the MERGE fails because columns are added/missing between source/target table during the merge insert.
With the patch and above configuration, the MERGE succeeds, rows are inserted, and the schema evolves as expected.

I find specifying it here in profiles.yml much neater than the platform-specific instructions for adding it to your ODBC driver configuration, much easier to document for other users of the models.

That's great to hear, and you named exactly the setting for which I imagined this might prove especially useful.

Sorry for the delay, didn't see the edit. Done!


Update Composer dependencies (2024-08-04-00-18)

Visual regression test passed!
View the visual regression test report


Incorrect backlight duration in version 0.20.1

Several users and I, jump from version 0.19 to 0.20.1. Since then, backlight duration does not match with input value thanks to menu 36. It seems that backlight duration is now exactly twice input value, e.g. 10 s for 5 s input, 20 s for 10s input, etc.
Thanks for your efforts in pushing valuable firmwares to all the community.
Regards.
Jean-Roger / F6EGK

I'll take a look at it

I tested it too and the backlight is set for 5 seconds and stays on for 10 seconds.

Seems some operation causes it to turn off on time (maybe the value isn't read always when exit setting menu after adjusting the time), but in my testing it often doubled as OP described. 0.20.1/rev1.6 UVK5(8).

There's a factor of 2 that was added by me. It is indeed a bug. I'm not sure how some of you are not reproducing this issue.


fix: Set display to 0 to prevent xvfb collisions

#72  👈
no-sandbox

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mrmeku and the rest of your teammates on  Graphite


fix(rds) issue 1121 Fix restore rdsinstance passwords set

Description of your changes
[Currrently, 2023-09-27 20:15 Pacific TZ this is a strawman/draft/wip PR]
We found RDSInstance:restoreFrom snapshot isn't useful 'out of the box' if you didn't know the password of the RDS that was the source of the snapshot.     Instead you have to take an extra step to set the password after the RDS is provisioned.
When creating an RDS the provider is able to pass the password to the AWS api.   So the password is set 'out of the box'.   However the AWS restore function doesn't take a password parameter and currently the provider makes no effort to set the password in the case of restore.
This change adds a PasswordSet condition which is used to track whether the provider has managed to set the master password yet or not.    Necessary cause it generally isn't possible to set the RDS password immediately after the call to the AWS restore function.
The condition is set to False with a reason of Pending when the provider sees the password needs to be set.   This happens in

Create
Update, if a password change has been detected
The condition is set to False with a reason of Failed if an attempt to set the password was made but it failed.  This happens in
CreateOrRestore, where an attempt to set the password is made immediately after the call to the AWS restore function
Update, where an attempt to modify DB is made after changes are detected
The condition is set to True with a reason of PasswordSet if the password was successfully set.   This happens in
CreateOrRestore, after successful creation of a new RDS 'from scratch'
CreateOrRestore, where an attempt to set the password is made immediately after the call to the AWS restore function
Update, where an attempt to modify DB is made after changes are detected

The IsUpToDate function, called by Observe, now takes into account the value of the PasswordSet condition when determining if there was a password change.   If the existing checks don't indicate a password change but PasswordSet == False then IsUpTodate concludes that there was a password change and IsUpdateToDate returns false.
Update's password change check has has been updated similar to IsUpToDate.   Additionally it has been updated to use GeneratePassword like Create does.
Fixes #1121
I have:

[ x] Read and followed Crossplane's contribution process.
[ X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
After updating condition checks all existing tests pass.
I have performed manual tests.
TODO: Add unit tests specifically for the new logic that was added.

I think this solution is quite complex and I wonder if password handling for RDSInstance could be done in same way as it was done in ##1756. Instead of using the spec.writeConnectionSecretToRef to cache the initial password an internal cache secret is used. If this does not exist a password update is always performed. I think that would also fix the issue with automatic password resets after restore.

Thanks @MisterMX  for taking the time to look at this.
I'll look at that PR.
However a comment you made makes me think that perhaps you are misunderstanding what this PR does.   This PR isn't using writeConnectionSecretToRef  to cache anything.    Rather it is just

Using a condition to track whether the password needs setting or not
Changing Update to check the condition and extending the password setting code in Update to use Generate if that makes sense.

Hey @MisterMX
I disagree with the assessment that this is obscure :

It is modeled after changes that @negz  made when resolving some issues for for us ( https://github.com/crossplane-contrib/provider-aws/issues/802, https://github.com/crossplane-contrib/provider-aws/pull/825, https://github.com/crossplane/crossplane-runtime/pull/283  but I use a condition rather than an annotation ) .
Using a condition allows us to specifically watch for the password to be set.  ( Fwiw, when restoring the RDS may be Ready, Synced and Available and yet the password you need isn't available )

However I do see that the official provider is working like the PR you referenced for the type instance ( which is the replacement of the community-contrib's rdsintance ).   So I think I'll create a 2nd PR which follows the approach in the PR you referenced.
And again, thanks for taking the time to review this PR.   I'll bug the provider-aws maintainers again once that 2nd PR is ready.

Oh @MisterMX forgot...
Today rdsinstance doesn't have an autoGeneratePassword field under forProvider.   Do I need to increase the CRD version from v1beta1 to v1beta2 ?

@MisterMX
Today RDSInstance, despite the fact that it doesn't have the field AutogeneratePassword, will automatically generate a password into writeConnectionSecretToRef if nothing has been specified for masterPasswordSecretRef.
If we're going to add AutoGeneratePassword how do you see us breaking expectations for current users?  e.g.  If neither AutoGeneratePassword  nor masterPasswordSecretRef we retain the current behaviour but if AutoGeneratePassword is true  then you have to specify masterPasswordSecretRef?   And if it is explicitly set to false then we refuse to generate a password?

@MisterMX
Looking at
https://github.com/crossplane-contrib/provider-aws/blob/master/pkg/controller/rds/dbinstance/setup.go#L122
in DBInstance AutogeneratePassword won't do what people expect since it seems a password will only be generated if you are also doing restoreFrom.
Adding such behaviour to RDSInstance will be a surprise because to auto password generation happens without requiring use of restoreFrom.


Log refcount traces if tracer enabled, even if DEBUG_LOCATION is not used.

In practice, I have found that in order to debug ref-counting issues, we need to log all ref operations, regardless of whether DEBUG_LOCATION is used.
I think this should not impact performance in opt builds, but please confirm that this looks right to you.

Hmm, this seems to be causing a tsan problem in the call combiner code:
https://source.cloud.google.com/results/invocations/7ee0e6fe-7bca-47c1-83c0-6c589c9b0e81/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_full_test@hpack_size@poller%3Depoll1/log
Soheil, any idea what's up with this?  It's not obvious to me from the tsan message why this is being triggered.

@vjpai I'm also seeing some weird ASAN failures in thread_stress_test.  It seems like the RefCount is somehow being freed before the last Unref() is called, but it's not clear to me how this PR could be triggering that if it wasn't happening before.  The ASAN message points to the line accessing the tracer_ member, but there doesn't seem to be a problem accessing the value_ member on the previous line.  Any idea what might be going on here?

Known issues: #19614 #19422


Which features should be hidden for 2.0

Currently I have hidden 3 features for release 2.0 -- dpkg, rpm, and yup -- since the server support is insufficient at this time. They have been hidden on the 2.0.x stream, which is sufficient, they can remain enabled in master.
The question is, which of the remaining features and command line arguments should remain enabled for the release? Here is the current help text to help with the selection. Note that I am only removing things from the help text, I don't particularly care if the code is still accessible, just that they are not officially supported.
ANYTHING that is in dubious shape (that was not previously released) can be disabled. I would rather things be nice and stable for the release.
DevAudit <IP_ADDRESS>
Copyright © 2016 Vör Security

  nuget                    Audit NuGet packages. Use the --file option to
                           specify a particular packages.config file otherwise
                           the one in the current directory will be used.

  msi                      Audit MSI packages on Windows. Packages are scanned
                           from the registry.

  choco                    Audit Chocolatey packages on Windows. Packages are
                           scanned from C:\ProgramData\chocolatey.

  bower                    Audit Bower packages. Use the --file option to
                           specify a particular bower.json file otherwise the
                           one in the current directory will be used.

  oneget                   Audit OneGet packages on Windows. Packages are
                           scanned from the system OneGet repository.

  composer                 Audit PHP Composer packages. Use the --file option
                           to specify a particular composer.json file otherwise
                           the one in the current directory will be used.

  drupal8                  Audit a Drupal 8 application instance. Use the -r
                           option to specify the root directory of the Drupal 8
                           instance, otherwise the current directory will be
                           used.

  drupal7                  Audit a Drupal 7 application instance. Use the -r
                           option to specify the root directory of the Drupal 7
                           instance, otherwise the current directory will be
                           used.

  mysql                    Audit a MySQL application server instance. Use the
                           -r option to specify the root directory of the
                           mysqld server. Use the -b option to specify the path
                           to the mysqld server binary and the -c option to
                           specify the configuration file otherwise default
                           values will be used for these 2 parameters.

  sshd                     Audit an OpenSSH sshd-compatibile application server
                           instance. Use the -r option to specify the root
                           directory of the sshd server. Use the -b option to
                           specify the path to the sshd server binary, and the
                           -c option to specify the configuration file
                           otherwise default values will be used for these 2
                           parameters.

  httpd                    Audit an Apache httpd server instance. Use the -r
                           option to specify the root directory of the httpd
                           server. Use the -b option to specify the path to the
                           httpd server binary and the -c option to specify the
                           configuration file otherwise default values will be
                           used for these 2 parameters.

  nginx                    Audit an Nginx server instance. Use the -r option to
                           specify the root directory of the httpd server. Use
                           the -b option to specify the path to the httpd
                           server binary and the -c option to specify the
                           configuration file otherwise default values will be
                           used for these 2 parameters.

  netfx                    Audit a .NET Framework application. Use the --root
                           option to specify the root directory of the
                           application and the -b option to specify the
                           application .NET assembly.

  netfx-code               Audit a .NET Framework 4 code project. Use the
                           --root option to specify the root directory of the
                           solution, and the --project-name option to specify
                           the name of the project.

  aspnet-code              Audit an ASP.NET code project. Use the --root option
                           to specify the root directory of the solution, and
                           the --project-name option to specify the name of the
                           project.

  aspnet                   Audit an ASP.NET application or code project
                           deployed to a web server. Use the --root option to
                           specify the root directory of the application and
                           the -b option to specify the application .NET
                           assembly.

  php                      Audit a PHP code project. Use the --root option to
                           specify the root directory of the code project.

  drupal8-module           Audit a Drupal 8 module project. Use the --root
                           option to specify the root directory of the code
                           project and the --code-project option to specify the
                           Drupal 8 module name.

  d, enable-debug          Enable printing debug messages and other behavior
                           useful for debugging the program.

  n, non-interactive       Disable any interctive console output (for
                           redirecting console output to other devices.)

  o, options               Specify a set of comma delimited, key=value options
                           for an audit target. E.g for a mvc5-app audit target
                           you can specify -o
                           package_source=mypackages.config,config_file=myapp.co
                           nfig

  f, file                  For a package source, specifies the file containing
                           packages to be audited. For a code project,
                           specifies the code project file.

  s, host                  Specifies the remote host that will be audited.

  u, user                  Specifies the user name to login to the remote host.

  p, password              Specifies that a password will be entered
                           interactively for the user name or as a pass-phrase
                           for the user's private-key authentication file to
                           login to the remote host.

  password-text            Specifies the password text for the user name or
                           pass-phrase for the user's private-key
                           authentication file to login to the remote host.

  k, key                   Specifies the private-key file for the user to login
                           to the remote host. Use the -p or --password-text
                           option to specify the pass-phrase for the file if
                           needed.

  c, config-file           Specifies the configuration file for the application
                           server to be audited.

  r, root                  The root directory of the application instance to
                           audit.

  b, application-binary    The path to the application or server binary.

  i, docker                Run the audit on a Docker container with this name
                           or id.

  m, project-name          The name of the code project to audit.

  list-packages            Only list the local packages that will be audited.

  list-artifacts           Only list the artifacts corresponding to local
                           packages found on OSS Index.

  list-rules               Only list the configuration rules found for the
                           application or application server.

  list-analyzers           Only list the analyzers found for the code project.

  skip-packages-audit      Skip the package audit for applications or
                           application servers.

  only-local-rules         Only use the configuration rules for the application
                           or application server listed in YAML rules files.

  help                     Display this help screen.

No audit target specified.
D:\git.vor\DevAudit>

What sort of shape is docker support in? Should we leave that off till 2.1?

The following audit targets should also be disabled for the next release:
netfx-code
aspnet-code
php
drupal8-module
These are all the code project audit targets. The basic code analyzers work in that the ASTs are built but I don't have any rules currently for them. We should focus on the package source and applications and application servers for the next release and see what the user feedback is.
The docker support is good to go for 2.0 and should have feature parity with the other environments.

Code audit targets have been disabled in 2.0.x

All listed commands have been removed from the help


#1 Reorganize di.xml elements according to the scope

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message is descriptive of the changes within (see https://keepachangelog.com/en/1.1.0/)
[ ] Code conforms to Magento coding standards
[ ] Code is compatible with all currently supported versions of Magento and PHP

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #1
What is the new behavior?
Does this PR introduce a breaking change?
[x] Yes
[ ] No

di.xml configuration is moved around, so Developers who already customized/overridden the di.xml may encounter unexpected behavior
Other information
🙏🏻 Kindly please add information to Release Notes "Optimized by SwiftOtter.com" when the change gets merged.

Can't merge as is -- almost all of the moved DI applies to multiple scopes.

The order collection change to set the tokenbase_id extension attribute is necessary for anywhere that might use the extension attribute -- particularly APIs. I see your point about the current mechanism being a performance problem due to the load-in-loop $order->getPayment() calls. I will see about refactoring those into a plugin or observer of some nature (unless you want to do so first). tokenbase_id is directly on the payment tables (I know ...), so no extra data loading is necessary, the extension attribute can be filled in when the payment model is otherwise loaded or referenced.

The card context, observers, and plugins definitely act in multiple scopes, or not in frontend scope. Those need to stay global to avoid BC breaking changes and regressions.

You are correct that the block and controller session proxies can be moved to adminhtml/frontend scopes. If you want to remove the rest, I could merge these.

Thank you for the PR!

Replaced by cb4137c8a2133ada5e711ae164f2928a9f7a07b7. Moved only the frontend- and adminhtml-specific types to their respective scopes.
Thanks