cut_freehand problem with Cone

Hi Marco,
Thanks for the great work. My question is about FreeHandCutterPlotter.
I am trying to implement that tool to my project but I have noticed that it works wierd with the input vedo.Cone()
Is it what you expect or is it a bug?
But It works good with mesh loaded from stl
Thanks and Regards
Umut

Hi, that happens because the mesh faces are very long, if you refine the mesh by subdivision eg:
msh = vedo.Cone().subdivide(3, method=2)

then it should work better..

Hi Marco, Thanks for the reply.
I am having problem with cut_freehand.py
Sometimes it works as it expected, but sometimes it cuts or leave unwanted area. I recorded as gif and added to the issue as attachment.
I run it by loading an stl that I attached that stl to the issue.
I have only changed the code from
msh = vedo.Volume(vedo.dataurl+'embryo.tif').isosurface().color('gold', 0.25) # Mesh
to
msh = vedo.load('data/8_l_simplified10.stl').color('gold', 1.00) # Mesh
it also make the same behavior with the embriyo.tiff. Somehow, it looks like it does it when the last point of the drawn circle is in the circle area.
What would causing this and what can I do about it
Thanks in advance
Regards

8_l_simplified10.zip

Hi, just to make sure can you upgrade with
pip install -U git+https://github.com/marcomusy/vedo.git

then

from vedo import Mesh, settings
from vedo.applications import FreeHandCutPlotter

settings.use_parallel_projection = True

msh = Mesh('8_l_simplified10.stl')
msh.extract_largest_region().compute_normals()
msh.backcolor('purple8')

plt = FreeHandCutPlotter(msh).add_hover_legend()
plt.start(axes=1)
plt.close()

seems to be working fine.. (?)

Hi Marco, thanks a lot for your reply.
Now it works a lot better. But still catch some errors. I added as gif
I couldnt understand the logic in cut_with_mesh with vtk but may it be related how the first polygon's point and last point is connected so that created ribbon break the logic?

Hi,
sorry the very late reply!
this might be due to a low resolution of the straight line AND the fact that some times the last/first point make a very sharp angle so that the in/out gets confused because of the normals..
I need some time to check this and see how it can be improved.
So I dont have an immediate solution....

Hi Marco,
no problem at all! thanks a lot for this great library though. I am new bee on 3D but if I could find something I would love to contribute.


Editor is forcefully focused after using inline staging

VSCode Version: 1.27.2
OS Version: Windows 10 Pro version 1803

Steps to Reproduce:

Make some changes to a file that is set up with git
Use the inline staging feature to stage a single change
Click the "message" box in the source control panel in order to direct focus there
Start typing
Staging completes for the change
The editor focuses the next change in the file and steals focus from the source control panel

Video that more clearly shows the problem
This is not as much of an issue when git is faster than you are able to click the "message" box, but in my experience, git tends to take a few seconds on Windows. This issue then becomes quite annoying because you always have to wait it out or type faster than git stages the change.

Does this issue occur when all extensions are disabled?: Yes

We no longer focus the next change in the file since this month (you can try this behavior in Insiders).

I have tried this again in the newest insider build and the issue still persists, even though it happens a bit differently. You're right that the next change is no longer being focused, but the editor itself is still being focused. Here is a video of it in action (using the latest insider build).


Implemented Horizontal Scroll Bar.

Implements a Horizontal scroll bar as per the discussion I posted earlier. Almost identical to the vertical one in code, just needed some minor adjustments. Builds successfully and was tested in a separate windows forms application without issue.

oh wow, thank you for doing all this.
i'm very sorry that i couldn't get to your pull request quicker!


Failure to import museum data

I upload a jl file with 10 records and they don't get imported. The tmp file has data, but the corresponding directory is empty.
If the file is invalid, there should be an error message.

Attaching file I am trying to upload to myDIG
museum-10t.jl.zip

@szeke Because file validation and building catalog are asynchronous tasks, GUI can not get response of status in that file upload http connection. I am going to implement a query for fetching task status.
But for this particular dataset, "doc_id" ("_id") is missing, ACHE doesn't follow the format of CDR v3.1.

Runqi sent a fixed file


Ignored attempt to cancel a touchmove event with cancelable=false

Hi,   @davestewart @kutlugsahin @desm @alexandreDavid
I m using vue-smooth-dnd with quasar (Vue framework).
https://codesandbox.io/s/vue-quasar-latest-working-czqjt
you can see code in codesandbox here. its working perfect in desktop but on touch device like mobile or table it hung there.
its giving error like:
[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
working :  with : 0.7.0 (vue-smooth-dnd) with dependency smooth dnd 0.11.0
not working: with : 0.8.0 (vue-smooth-dnd) with dependency smooth dnd 0.12.0
not working: with : 0.8.1 (vue-smooth-dnd) with dependency smooth dnd 0.12.1

Having the same problem - is there any known fix, please???


Show all onError updates on UI

not able to get any updates of errors
example:
disconnected internet
mic off on
cam on off
etc

added toasts on reconnecting and reconnected of internet
Do we need updates on mic and cam on/off ?


travis-ci for tests.

If you can setup travis-ci account, I will configure the .travis.yml file. This will also help if you really want to add python2 support.

Yeah that sounds great.  I added a .travis.yml file but I'm having trouble.  I'm getting this error
"Can not perform a '--user' install. User site-packages are not visible in this virtualenv."
when running this command
$ pip install --user -r requirements.txt
during the install step

Ok I got it working.  What do you think is the best way to use travis-ci to add python2 support?

I sue pycharm as an editor, it has some feature for writing python2/3 code.
I have never used them but will take a look. Regarding how to use Travis in
the process. If your current tests just use the math then it would probably
be easy if they don't already work in python 2. I think testing python 2
and 3 maybe also pypy now and as tests are added make sure they pass.
On Sun, Nov 13, 2016 at 8:11 PM Ryan Riddle<EMAIL_ADDRESS>wrote:

Ok I got it working. What do you think is the best way to use travis-ci to
add python2 support?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RyanRiddle/elgamal/issues/5#issuecomment-260239178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOMdBSG_JruS68ryxwNQZ4znckvHPiHks5q99FPgaJpZM4KwmN6
.


Missing opponent in player_kill event

Not sure if this is an issue in HLU or if this is something that can be reproduced as well, so this is more like a "note" that this happened at least once.
In a game recorded with HLU, I have a palyer_kill event that does not contain information about the killed player:
"2024-09-05 19:55:53+00:00","player_kill","Λ • madeofpixels","76561198177110163","Axis","Rifleman","175","620","320","265","","","","","GEWEHR 43","","","Axis","HOW",""

Any ideas why this could've happened?

The killed player disconnected right around the same time I assume? That's a known limitation of how HLU treats player references.

This is the excerpt with some more lines before and after the player_kill event:
"2024-09-05 19:55:44+00:00","player_kill","[PKKA] D69A","76561198082012030","Axis","HeavyMachineGunner","276","280","1040","150","phx.wertzuwachs","76561198039832422","Allies","Engineer","MG42","","","Axis","NEGAT",""
"2024-09-05 19:55:45+00:00","player_change_role","[LS] Kerei","76561198335443783","Axis","HeavyMachineGunner","282","660","520","0","","","","","","Rifleman","HeavyMachineGunner","Axis","CHARLIE",""
"2024-09-05 19:55:45+00:00","player_kill","🅶 I|I Ditzel","76561198119459470","Axis","Sniper","770","720","600","0","Senpai","76561198389821261","Allies","Spotter","FG42 x4","","","Axis","ABLE",""
"2024-09-05 19:55:50+00:00","player_kill","[LS] Павел","76561198054732074","Axis","Rifleman","578","460","820","744","phx*.SpecialOfficerDoofy","76561198065215788","Allies","Rifleman","GEWEHR 43","","","Axis","CHARLIE",""
"2024-09-05 19:55:52+00:00","player_kill","℧r | Flo","76561198084137425","Allies","ArmyCommander","1006","0","1660","2325","[LS] max.ru","76561198112282228","Axis","Officer","155MM HOWITZER [M114]","","","Allies","",""
"2024-09-05 19:55:53+00:00","player_kill","Λ • madeofpixels","76561198177110163","Axis","Rifleman","175","620","320","265","","","","","GEWEHR 43","","","Axis","HOW",""
"2024-09-05 19:55:55+00:00","player_message","Autopsy","76561198379742217","Allies","Rifleman","203","200","380","60","","","","","","","","Allies","ABLE","gg"
"2024-09-05 19:55:55+00:00","player_kill","phx.tw!N","76561197970848128","Allies","Officer","643","380","740","550","🅶 I|I Ditzel","76561198119459470","Axis","Sniper","M1 GARAND","","","Allies","JIG",""
"2024-09-05 19:55:56+00:00","player_switch_team","[StDb] Dark Razor","76561198016672004","Allies","AntiTank","167","440","700","390","","","","","","Allies","","Allies","EASY",""
"2024-09-05 19:55:56+00:00","player_switch_squad","[StDb] Dark Razor","76561198016672004","Allies","AntiTank","167","440","700","390","","","","","","EASY","","Allies","EASY",""
"2024-09-05 19:55:56+00:00","player_score_update","[StDb] Dark Razor","76561198016672004","Allies","AntiTank","167","440","700","390","","","","","","","17","Allies","EASY","33"
"2024-09-05 19:55:56+00:00","player_leave_server","[StDb] Dark Razor","76561198016672004","Allies","AntiTank","167","440","700","390","","","","","","","","Allies","EASY",""

the only player leave event is only 3 seconds later, shouldn't be an issue? 🤔

Nah, that'll be him.


Support visual bell

Checklist:

[ ] Screen: adjusted relevant code parts (enable/disable bell? adjust bell audio volume?)
[ ] aeroterm: visualizes bell (at least one mode: hard start, smooth fading out)
[ ] aeroterm: also consider: glfwRequestWindowAttention(window);

Bell is implemented and configurable, i am closing this one


Auto Generate Swagger Docs

Our api docs currently use Swagger and need to be manually generated. I would be great to automate these.

I would like to working on this feature

hi @tzii, This is yours :)


Dynamicall choosing the most affordable metro to create harvester infra

Dynamically choosing the most affordable metro to create harvester infra

@rajeshkio another merge conflict needs to be addressed. We removed .drone.yml.

@rajeshkio another merge conflict needs to be addressed. We removed .drone.yml.

Removed.drone.yaml?

@rajeshkio another merge conflict needs to be addressed. We removed .drone.yml.

Removed.drone.yaml?

@rajeshkio another merge conflict needs to be addressed. We removed .drone.yml.

Removed.drone.yaml?

@rajeshkio another merge conflict needs to be addressed. We removed .drone.yml.

Done


SAS Viya naming updates

There are some SAS Viya offering name changes that require updates to names used in this project.

This issue addressed by Release 1.9.2


List of Users Page

Overview
Displays a list of all active users and allows for creation of new users as well as emailing bulk selected users.
Add User Button Section
Allows for the addition of a new user.
User List Section
Displays a list of users and allows for multi-select of users to allow for bulk emailing.
Shows 100 users per page
Allow for a “select all” option
Permissions

Permissions
Authentication Details

Private
This is a privately-viewable page, so it will be able to be accessed by only those with appropriate permissions: Site Admins

Mockups
https://wireframe.cc/pro/pp/ac3e73eb484737

#70 added this feature. The only thing left is making sure that only admins can access the user page.


Include JDK version into compiler bridge cache path

I would also prefer @wpopielarski's schema of java/scala/zinc order

PR amended. I've changed the order. Are the prefixes OK? Also, I've used full JDK version eg 1.8.0_131 this means some potentially unnecessary rebuilds, but should be more resilient against potential changes in JDK9 early access releases.


GLTF (raylib_32x32.glb) testfile problem

resources/gltf/raylib_32x32.glb
does not load when testing models_gltf_model.c
Imported  raylib_32x32.glb  to blender, exported  raylib_32x32.glb  and then it works somehow.

it would be helpful if you could detail the original source of the asset and if possible include it here for testing...

Ah my bad.
Deleted build/ dir and created projects again using cmake, now it works.


How to get group claims?

I'm trying to get group information into my FastAPI app from MSAL, but I can't see that it's supported.
Describe the solution you'd like
I want to add group claims in my token configuration and have them show up in the UserInfo model for use in authorizations in my endpoints.
Describe alternatives you've considered
I've configured my token configuration in my AZ AD App to "emit groups as role claims" for ID and Access types.
Additional context
None.

Hi @philipsd6,
Sorry for the delay, busy days.
Can you please elaborate if you are trying to use AAD B2B or AAD B2C?
From my experience they are different in the details they provide.
BTW - I have another project in work which could provide the groups via MS Graph.
I'm pretty much delayed with it but if this works for you I'll try to push that into a stable version this week.
Cheers!

I actually don't know for sure which I'm using! I just followed the quick start you linked to, and also based on running these CLI commands:
TENANT=$(az login --query "[?isDefault].tenantId|[0]" -o tsv)
CLIENT_ID=$(az ad app create --display-name "TestingApp" \
                             --reply-urls http://localhost:8000/docs/oauth2-redirect \
                             --query appId -o tsv)
CLIENT_CREDENTIAL = $(az ad app credential reset --id $CLIENT_ID \
                                                 --query password -o tsv

Which I then customized in the portal by adding group claims in varying configurations to see what/if any worked. But looking at your UserInfo model — there's no group fields in it, so wouldn't they be stripped out anyway?
I look forward to seeing your other project! Thanks for putting all this MSAL stuff together in a reusable FastAPI fashion!

Hi @philipsd6 - I wasn't around this project for a while.
If this is still relevant, I published a more complete py365 package for handling the Microsoft Graph API, including groups I believe.
You should try it out!
https://github.com/dudil/py365
I can't recall if this is the latest version I have on my computer that includes the fastapi_msal integration. If not, please let me know and I'll look into update it.

So in my case I'm using plain AAD, and the app have been setup so that the token includes the roles of the user directly in the ID token. This means that token_claims : dict in clients/async_conf_clients.py contains a roles: list[str] after decoding:
    async def validate_id_token(self, id_token: str, nonce: OptStr = None) -> IDTokenClaims:
        token_claims: OptStrsDict = await self.__execute_async__(
            self._cca.client.decode_id_token, id_token=id_token, nonce=nonce
        )
        return IDTokenClaims.model_validate(token_claims)

So in practice, since IDTokenClaims is inheriting from UserInfo, it would only be a question of adding:
class UserInfo(BaseModel):
 ...
    roles: Optional[list[str]] = Field(None)  # add this somewhere

Since then it would be automatically set right?
This would make it super easy to implement RBAC, and there's no need to query graph or anything like that..
Pretty please?

Issue is now closed with release latest of version 2.1.2 🙏


[Grid] Having a DataGrid within a Grid within a flex div does not allow for a grid layout - forces it to follow the flex direction unless otherwise specified

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
I am attempting to put my MUI datagrids in an MUI grid. However, my grid items do not seem to be going into grid format at all (ie all the DataTables are in one area, none of them are siding next to each other even though they take up less than half the space each on the page).
Expected behavior 🤔
Items in the grid should flow to fill the grid in row and column format, not stick to either row or column
Steps to reproduce 🕹
Here is my sandbox: https://codesandbox.io/s/silly-morning-gs58yh?file=/src/App.js
Context 🔦
The grid should not be affected by the css or styling of the external components of which it is a child.
Your environment 🌎
See the code pen

Hey @careignition-cps, thanks for opening up the issue. Please, check this demo out and let me know if it has solved your problem. I guess you were only missing the container prop on the parent Grid wrapper.

to be closed?


shift request endpoint and simple optimise shift button

Describe your changes
I refactor the code to call the newly created endpoint to post a new shift request with a new payload class. Also a new button in the supervisor shift page to call the optimise shifts endpoints.

Hi @BenMMcLean, the failed pipeline tests are outdated because I refactored the old code. Should I update them to align with my new code, or just try to make them pass forcefully?


periscope & pscp

[x ] I've verified and I assure that I'm running youtube-dl 2017.07.15

[x ] At least skimmed through README and most notably FAQ and BUGS sections

[x ] Searched the bugtracker for similar issues including closed ones

[x ] Bug report (encountered problems with youtube-dl)

[ ] Site support request (request for adding support for a new site)

[ ] Feature request (request for a new functionality)

[ ] Question

[ ] Other

there are only 20 latest videos while getting playlist from periscope.tv even is contains more then 20
$ youtube-dl -v
[debug] User config: [u'-o', u'%(uploader_id)s_%(id)s:%(title)s_%(upload_date)s_%(timestamp)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.pscp.tv/Natka_23_', u'--get-filename']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.07.15
[debug] Python version 2.7.13 - Linux-4.11.9-200.fc25.x86_64-x86_64-with-fedora-25-Twenty_Five
[debug] exe versions: ffmpeg 3.1.9, ffprobe 3.1.9
[debug] Proxy map: {}
...

it seems to be that youtube-dl does not send any credentials to this server

https://www.pscp.tv/Natka_23_ contains exactly 20 items all of which are processed.

sorry, but the playlist for that time contained 21 items
you can check playlist for https://www.pscp.tv/ThatsButta - it contains more then 100 items, but utility gets only 20

https://www.pscp.tv/ThatsButta

I've checked the playlist. I count 20 videos and that's exactly what periscope shows in the header: 20 Live-Videos

there are only 20 videos if user is not logged in, but there are much more when user logs in.
so, may be authentication is not working on periscope?
there are no login strings in stdout, wheater I add --username and --password


Use Oxford comma

Saw this being used elsewhere, so updating here for consistency.
What kind of change does this PR introduce?
README copy update

Thanks


fix: rate limit err

What type of PR is this? (check all applicable)

[x] 💡 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] ⏩ Revert

Description

This pr fixes the issues where users hit the second rate limit
Related Tickets & Documents

fixes #251
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Does this make use of https://github.com/octokit/plugin-throttling.js/#readme? This is the official GitHub recommended way!

Does this make use of https://github.com/octokit/plugin-throttling.js/#readme? This is the official GitHub recommended way!

Cool, I didn't know that. Will have to rewrite some part of the action. Thanks

@koppor would you like to give this a shot?
In the meantime, I will try resolving other issues in this pr before merging

The output is

⚙ Processing 0 issues:

(Link to action output: https://github.com/JabRef/jabref/actions/runs/12296140810/job/34314530086)
But I have 23 issues with the label "Assigned": https://github.com/JabRef/jabref/issues?q=sort%3Aupdated-desc is%3Aissue is%3Aopen label%3A"📍 Assigned"
I think, the number should be "23", shouldn't it?

Did not work 😢
https://github.com/JabRef/jabref/actions/runs/12315417134
You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 2402:3CBDD4:2C54AC9:57ADDC6:675C24AE. - https://docs.github.com/free-pro-team@latest/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits

Sorry for the delay, looking into it


Fixing multiple definitions errors (GCC build on GNU/Linux)

Hi,
So, I had issues building libembroidery on Debian and after a bit of reading into it I found that the issue is probably compiler specific.
I've got a patch that can make build cleanly and more memory secure in practice, but I've not submitted before so I hope this is presented correctly.
Cheers,
Robin

This looks good so far I am going to run a few checks on Windows, and Mac before accepting the full merge.

This looks good so far I am going to run a few checks on Windows, and Mac before accepting the full merge.

Oh, I'm new to GH so a whole bunch of commits have been thrown on the end here that are for different purposes. I'm not sure how to separate these out.
The CMake build replacing the QMake build for example is a change that may not be to your taste and should be it's own PR?
I could make a new branch for these changes or you can just alter the commits above?
Thanks for getting back to me.

Right, just looked it up. That should be easier to test and review. (It was my misunderstanding of git merge that dumped all my other changes on the end.)

This was fixed by #27 or some other accepted PR, so I'll close it.


Integration Test - Release - 2019/07/17 22:29:46

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


Add skip-changelog label to bot-PRs

To add this label to dependabot PRs, simply add it to the configuration file.
To add this label to pre-commit.ci PRs, a dedicated CI workflow must be created to add it after PR creation.

It is already automatically added to dependabot PRs.


Trailing headers

It seems impossible to use this library to sent
HEADERS frame
DATA frame
HEADERS frame
This is something that would be needed to implement GRPC for ocaml (https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md)

Trailer headers are still not supported, but the infrastructure to add them exists.
There's some initial work towards supporting them in https://github.com/anmonteiro/ocaml-h2/pull/72, but there hasn't been further interest so far.
Happy to kick around some ideas and design an API, even if naive at first (Ideally we would only allow sending trailer headers after we've sent a response first).


Fix the mergeback workflow

And manually mergeback v1 into main.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

There are 39 commits being mergedback. I think this is ok. These are all the commits that exist in v1, but not main. The actually changed files are correct. Future mergebacks should not have so many commits in them.


Can not set binary for portable browser (firefox)

If need to use portable browser (firefox) there is no such option until Start raise error no browser found until i updated registry to make fool Start function suggest better way to use portable browsers.
create this REG_SZ and set the value to current version 108.0.2
HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\Mozilla Firefox\CurrentVersion
after executing Start function created Capabilities and passed to OpenBrowser
after that SeleniumVBA downloaded the geckodriver at OpenBrowser passed the caps and this started
provide some way to use portable browsers only needed version number to download correct driver it can be configured

Thanks for the report @surfer-silver.
Will think about how to best solve this. Couple things that come to mind in the short-term:

You could turn off the driver auto-check-and-update feature via the SeleniumVBA.ini file if you are using SeleniumVBA v3.0 or later - that would skip the compatibility check against the browser, which is where I think it might be throwing the error.

On the development side, we could (maybe should!) handle that error so that it does not end the execution flow. In fact, that was one of the design goals of the auto-check-and-update feature, but I was not aware of your particular usage case at the time that code was written.

Of course, with both of those options, you would have to handle the driver-browser version alignment yourself, which you can do programmatically in the following way, which I do not believe involves the browser version:
Dim wdm As WebDriverManager
Dim dverInstalled As String
Dim dverLatest As String

Set wdm = New WebDriverManager

'wdm.DefaultDriverFolder = [your driver folder path here] 'defaults to Downloads dir

dverInstalled = wdm.GetInstalledDriverVersion(svbaBrowser.Firefox)
dverLatest = wdm.GetLatestDriverVersion(svbaBrowser.Firefox)

If dverLatest <> dverInstalled Then
    wdm.DownloadAndInstallDriver svbaBrowser.Firefox, dverLatest
End If

One assumption for the above logic to work is that you are keeping your browser version up to date. If the browser version falls far enough behind the latest driver version, then that could cause an incompatibility problem. So you might want to set your portable browser to auto-update mode, if you have that capability.
Would that work for you?

@surfer-silver, I committed a new version that I believe will handle your portable browser situation. To test it, delete the register key/value that you used to fake the installed browser, and also delete the installed Geckodriver.exe. Then run the script that you described in your issue report. The auto-check-and-update feature of WebDriver class will now check if the browser is registered, and if not, will download the latest driver. It should not throw a "browser is not installed error." I hope that works for you.
By the way, if you are using the SetBrowserBinary method of the WebCapabilities class to set the path to your portable browser each time, then please know that you can use the SeleniumVBA.ini file to accomplish that automatically.
Here is how:
Run a procedure like this to create and save a json capabilities file:
Sub create_caps_json_file()
    Dim driver As WebDriver
    Dim caps As WebCapabilities

    Set driver = New WebDriver

    driver.StartFirefox

    Set caps = driver.CreateCapabilities

    'set some preferred capabilities
    caps.SetBrowserBinary "[your path to the executable]"

    'can set more preferences/arguments here...

    'save capabilities to a json file
    caps.SaveToFile "[your path to preloaded caps file folder]\firefox.json"

    driver.Wait 1000
    driver.Shutdown
End Sub

Then modify the SeleniumVBA.ini file to something like this (see the section [FIREFOX] below):
# This settings file is completely optional. For it to have effect,
# it must be located in the same folder as the SeleniumVBA code library.

# If a value for an entry is not specified, then the system
# default value will be used.

# Note that all path-type entry values recognize the %[Environ]% syntax.

[GENERAL]

# The driver_location_folder system defaults to Downloads folder.
# The default_io_folder system defaults to the active vba project's
# document location - leave this blank to use default.
# Valid values for command_window_style are vbHide (default),
# vbNormalFocus, vbMinimizedFocus, vbMaximizedFocus, vbNormalNoFocus,
# and vbMinimizedNoFocus.

driver_location_folder=%USERPROFILE%\Downloads
default_io_folder=
command_window_style=vbHide

[AUTO-DRIVER-UPDATE]

# If auto_detect_and_update=True (system default) then everytime
# the WebDriver's Start* method is called, the Selenium driver's
# version is checked against the corresponding browser version.
# If the driver is not compatible with browser, it will be updated.
# min_compatibility_level determines trigger for updating an
# an out-of-date driver. System default is svbaBuildMajor.
# Use svbaMinor for less frequent updating, and svbaExactMatch
# for more frequent updating.

auto_detect_and_update=True
min_compatibility_level=svbaBuildMajor

# Below are browser-specific initializations.
# To automatically initialize a set of capabilities each time the
# OpenBrowser method of WebDriver class is invoked, set the
# preload_capabilities_file_path entry to the path of a valid json
# capabilities file. Note that if preload_capabilities_file_path is
# set to a blank value, or the entry is missing or commented out,
# then this option is ignored. Use the SaveToFile method of the
# WebCapabilities class to save a default set of capabilities
# for pre-loading.

[CHROME]

preload_capabilities_file_path=

[EDGE]

preload_capabilities_file_path=

[FIREFOX]

preload_capabilities_file_path=[your path to preloaded caps file folder]\firefox.json

[INTERNET EXPLORER]

preload_capabilities_file_path=

[PDF_DEFAULT_PRINT_SETTINGS]

# Valid units values are svbaInches (default) or svbaCentimeters.
# Valid orientation values are svbaPortrait (default) or svbaLandscape.

units=svbaInches
page_height=11
page_width=8.5
margin_bottom=.393701
margin_top=.393701
margin_right=.393701
margin_left=.393701
background=False
orientation=svbaPortrait
print_scale=1.0
shrink_to_fi

Make sure the SeleniumVBA.ini file is located in the same folder as the code library. If you do all of that, then every time you run a SeleniumVBA script the path to the portable browser will be set automatically, without you having to create and initialize the capabilities object.
Please let us know if any of this was useful and thanks again for the issue report!

@GCuser99 many thanks for your prompt response appreciate your efforts related to SeleniumVBA project.
will update the status of such changes.
thanks bro


deepstream: fix header file collisions

Leave the deepstream headers under /opt/deepstream, rather than double-installing them into ${includedir}
Update the deepstream-pyds recipe to find the headers in the correct deepstream-specific location

Fixes meta-tegra #1401

Hi,
I backported this patch to deepstream-6.2 now and hope to share it here.
deepstream-6.2-header-collision-backporting.zip


HSTracker Windows not on the correct "space"

Hi,
First thanks a lot for the awesome work here.
Unfortunately I'm not able to enjoy the cool features of stats during the game. The windows are staying on the space of my desktop. But Hearthstone launch itself on his own space...
Any clue?
I'm on El Capitan latest version, MBP Pro 15"
Thx

Unfortunately, it's not possible to "overlay" a fullscreen window. So you have to play Hearhtstone in windowed mode


latest tag being bind to the wrong Docker image

Description
The latest tag of your Docker image is often bind to the wrong Gitea version. I often notice that it's bind to some RC version, dev version, or currently to the 1.21.0-dev version, which is definitely not good.
I notice it because I'm running Watchtower daily to always keep my containers up-to-date, and right now my Gitea container has been bumped to this dev version and is no longer working because of an undocumented breaking change.
I can also think about the people attempting to casually download and run Gitea for the first time with a simple gitea/gitea and won't understand why it's not working.
So can you please make sure the :latest tag always points to the latest stable version please?
Gitea Version
1.21.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots

Git Version
No response
Operating System
Raspberry Pi OS 64bit
How are you running Gitea?
:latest Docker image
Database
SQLite

I came hear wondering if anyone else's Gitea wasn't working. This must be the reason. My container seems to be continuously trying to restart right now.

@lakoliu it's even more a pain that we not only have to manually downgrade but we also have to tweak/disable Watchtower temporarily because it's will bump Gitea again during its next run...

Yes, we know.
We've noticed this bug immediately when releasing 1.20.0-rc0 as the new container was pushed almost immediately from our CI.
However, we couldn't downgrade anymore without causing breakages.

@delvh I see. I assume it could only be fixed releasing a new version (1.19.x/1.20) ? Or is it even worse: not being able to fix it until a stable 1.21.0 version?
Have you planned some changes to not make it happen again? It's not the first time :latest is bind to an non-stable version

I came hear wondering if anyone else's Gitea wasn't working. This must be the reason. My container seems to be continuously trying to restart right now.

I assume it could only be fixed releasing a new version (1.19.x/1.20)

No, as your db will be upgraded with new versions.
You mean a stable 1.20 version, 1.21.0-dev simply means here stopped the development on 1.20 and started the development on 1.21.

@delvh so if I get it correctly it won't be fixed until 1.20.0 stable is released?

Yep

Have you planned some changes to not make it happen again? It's not the first time :latest is bind to an non-stable version

Ok, and about that @delvh?

Well… We'll try to harden our CI not to set the latest tag anymore on -dev tags, but that is a trial and error process:
The only way to know it works is by releasing something, so we can only hope it won't occur next time again.

Don't forget -nightly, -rc* and others! 😄 Thanks for your quick response


Add frontendTilesUrlTemplate to display-performance-test-app config

Added new config frontendTilesUrlTemplate to display-performance-test-app.  When used, it specifies a url template for @itwin/frontend-tiles to obtain tile trees for spatial views, served over localhost.
The url string can also include special tokens: {iModel.key} or {iModel.filename}. If present, these will get replaced by the value of iModel.key or just the model filename (no path or extension), correspondingly.
E.g.: http://localhost:8080{iModel.key}-tiles/3dft/ or http://localhost:8080/MshX/{iModel.filename}/
Note that the contents of iModel.key in DPTA is a GUID.
Began this change by using an env var, but decided this would be better in the config.  When making it work as env var, made changes so that env vars would be correct when running right after setting (no compile stage).  Left that code in for future.

One thing to bear in mind is that we cache the tileset URL for a given iModel from the time we first compute it until the iModel is closed. So if you have a configuration that opens an iModel and runs one test with tileset URL defined and another with it undefined (or different), the cache will use the URL from the first test.
If that's a problem we'll need to close the iModel when the URL config changes (I think we do the same for other settings like when TileAdmin options change), or provide a way to bypass the cache.

One thing to bear in mind is that we cache the tileset URL...
For current plan for ImageTests this would not be a problem, but for general usage it could.  So just adding a test for this config var to requiresRestart would solve this?

just adding a test for this config var to requiresRestart would solve this?

Yes.

I tried changing tileProps in config (while using but not changing frontendTilesUrlTemplate) and that hangs the same way, so this seems a separate problem.  But why does frontendTilesUrlTemplate work without changing requiresRestart?

why does frontendTilesUrlTemplate work without changing requiresRestart?

I don't have an answer for you. Cache is here.

@ben-polinsky fyi looks like BUILDMINION09A is out of disk space.
D:\vsts_a\8\s\tools\build\scripts\docs.js:22
  throw err;
  ^

Error: ENOSPC: no space left on device, write
    at Object.writeSync (node:fs:934:3)
    at Object.writeFileSync (node:fs:2255:26)
    at addPackageMetadata (D:\vsts_a\8\s\tools\build\scripts\utils\addPackageMetadata.js:44:8)
    at D:\vsts_a\8\s\tools\build\scripts\docs.js:95:3
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errno: -4055,
  syscall: 'write',
  code: 'ENOSPC'
}

@ben-polinsky fyi looks like BUILDMINION09A is out of disk space.

And 09B as well.

Okay, frontendTilesUrlTemplate works without changing requiresRestart because the imodel is already being closed and re-opened each time.  The only time it is not, is for wildcard views on the same model, in which case frontendTilesUrlTemplate cannot be changed in between.  So that is not an issue.
The hang in waitForSceneCompletion from _hasMissingTiles is still a potential issue (though not currently in ImageTests runs).  I currently suspect this is related to the same problem with front end tiles drawing black initially until the view is changed.

@pmconne - fixed some problems with detecting when IModelApp needs to restart, but that did not affect the hang in waitForSceneCompletion from _hasMissingTiles when using frontendTilesUrlTemplate.  I propose that that be handled in a separate PR, as it does not affect ImageTests usage.


Allow users to specify the size of the file on the remote HTTPS server

Following on from #123, I suggest we allow the following option:

file_size: The size of the remote file, in bytes. sbws can measure relay speeds up to file_size / target_seconds. Faster relays will all have this maximum speed. (TODO: reword?) If not specified, defaults to 1 GB. (optional)

Then we don't have to upgrade the protocol to change the file size.

Sure, though maybe it should be renamed to max_download_size or something to that effect. We don't have to require the file to be of a very specific size. We just need to make sure it is at least as large as the largest download we are willing to make. Currently that's hardcoded because sbws scanner and server need to agree. But in the switch to HTTPS, we can make it a config with a sane default, like 1 GB.

@teor2345 I'm going to restate my idea for this issue more clearly. Please let me know what you think.
First add an option limiting the maximum download size sbws is willing to do.
[scanner]
# 1 GiB
max_download_size =<PHONE_NUMBER>

Then mark a destination unusable if the file its URL points to is not large enough to handle the max_download_size

I think max_download_size and min_download_size are fine.
I can see us setting min_download_size to (498 - protocol overhead) if we wanted to make sure small requests had a full cell.
See also my update to #125.


Layout Route Contexts NOT being set on non-initial redirects in beforeLoad()

Describe the bug
Layout Route Contexts NOT being set on non-initial redirects in beforeLoad()
Repo reproduction
https://github.com/cpakken/issue-tanstack-router-layout-route-context
"@tanstack/react-router": "^1.32.13",
On non-initial loads, when a _layout route's beforeLoads() is triggered by  navigation, router.invalidate(), the route's contex returns undefined
Please run vite dev and use Auth Dev Controls to toggle auth state changes and observe the _LAYOUT/context returns undefined
Note:

the  routes of the _layout returns the context correctly
the root router's context has the returns context correctly

export const Route = createFileRoute('/_not_authed')({
  beforeLoad: ({ context: { auth } }) => {
    //If the user is already authenticated, redirect them to the main dashboard
    if (auth.get()) {
      console.log('redirecting to /')
      throw redirect({ to: '/' })
    }
  },
  component: memo(Component),
})

function Component() {
  const context = Route.useRouteContext() //this returns undefined on non-initial redirect
  const rootContext = useRouteContext({ from: '__root__' }) //this seems to resolve
  console.log('_not_authed/context:', context, rootContext)

  return (
    <div className="bg-gray-300">
    ...
    </div>
  )
}

No context in _auth

root has context

└── 📁routes
    └── 📁_authed
        └── index.lazy.tsx
        └── user-settings.lazy.tsx
    └── _authed.tsx
    └── 📁_not_authed
        └── login.lazy.tsx
        └── signup.lazy.tsx
    └── _not_authed.tsx
    └── __root.tsx

Your Example Website or App
https://github.com/cpakken/issue-tanstack-router-layout-route-context
Steps to Reproduce the Bug or Issue
See readme.
Expected behavior
Route.useRouteContext() should return the context instead of undefined on non-initial redirects
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Maybe same error as https://github.com/TanStack/router/issues/1604

Also: https://github.com/TanStack/router/issues/1531

@cpakken I tried out your setup on 1.32.16 and either the issue has been fixed or I'm simply not seeing the issue.
https://github.com/TanStack/router/assets/33615041/c40cfca2-e9d8-4aea-8920-578b6b932c72

https://stackblitz.com/edit/github-5eojgx?file=src%2Fmain.tsx
If the issue still persists, you'll need to detail the exact steps needed to be taken to recreate scenario.
Eg:

Go to ...
When on ... reload.
...

@SeanCassiere @tannerlinsley  just released v1.32.16 30 minutes ago and fixes the issue. Thanks so much! ♥


Add a switch for the firewall tasks

The principal goal of this pull request is to give the choice to the user to activate or not the installation and configuration of UFW.
The reasons that pushed me to propose this change are:

Some systems come with nftables and this is less a pain to manage than iptables, less reason to have a frontend wrapper (ufw) on top of it
Some systems come with their own preconfigured rules. Those still need to be defined on ansible to keep track of them but this might not be done on ufw.

I kept the tasks firewall.yml on by default, to keep the same behavior as this is now but added a switch to include the firewall tasks on the main.yml so there is a possibility to manage it differently.
Thanks

Makes sense, I've added a couple of comments.

Sorry for the delay.


Jit demo does "PermissionDenied"

my OS: Fedora 33,
Rust: 1.49.0
so when I do cargo run in "cranelift-jit-demo-main" it compiles but then:
thread 'main' panicked at 'unable to make memory readable+executable: SystemCall(Os { code: 13, kind: PermissionDenied, message: "Permission denied" })', /home/adsick/.cargo/registry/src/github.com-1ecc6299db9ec823/cranelift-simplejit-0.68.0/src/memory.rs:197:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

why is it so and how do I fix it (or rather it should be fixed somewhere in the actual project, I dunno)

sorry, it is for https://github.com/bytecodealliance/cranelift-jit-demo

sorry, it is for https://github.com/bytecodealliance/cranelift-jit-demo


Relationship between "time series" of the OEO and "time sampled measurement data set" of the IAO

Description of the issue
At the moment, the IAO (Information Artifact Ontology) is only partially imported into the OEO. In the definition of the entity "time series" it is indicated under "may be identical to" that "time series" may express the same as the entity "time sampled measurement data set" of the IAO. I would not see it that way. The definition of the entity "time sampled measurement data set" indicates that it is an ordered list of "time measurement data" and the associated "measurement data". The entity "time series" of the OEO on the other hand gives the possibility to add information like the resolution, the license or the start time. I would consider this as further meta information of the time series.
Ideas of solution
The entity "time sampled measurement data set" of the Information Artifact Ontology could become part of the entity "time series" via a property (maybe a new property). So then the properties "has measurement datum" and "has time stamp" of the IAO could be used to add timestamp and value.
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

time sampled measurement data set connected with time series via a property
Connecting entity „time series“ (http://openenergy-platform.org/ontology/oeo/OEO_00030034)
via property „has part“ (http://purl.obolibrary.org/obo/BFO_0000051)
with entity „time sampled measurement data set” (http://purl.obolibrary.org/obo/IAO_0000584)
for the entity „time sampled measurement data set” the following things from the IAO.

Entity "time stamped measurement datum” (http://purl.obolibrary.org/obo/IAO_0000582)
Entity “measurement datum” (http://purl.obolibrary.org/obo/IAO_0000109)
Object Property “has time stamp” (http://purl.obolibrary.org/obo/IAO_0000581)
Entity “time measurement datum” (http://purl.obolibrary.org/obo/IAO_0000416)
Object Property “has measurement datum” (http://purl.obolibrary.org/obo/IAO_0000583)
Entity “scalar measurement datum” (http://purl.obolibrary.org/obo/IAO_0000032)
Object Property “has measurement unit label” (http://purl.obolibrary.org/obo/IAO_0000039)
Data Property “has measurement value” (http://purl.obolibrary.org/obo/IAO_0000004)
Object Property “is duration of” (http://purl.obolibrary.org/obo/IAO_0000413)
Entity “mass measurement datum” (http://purl.obolibrary.org/obo/IAO_0000414)
Object Property “is quality measurement of” (http://purl.obolibrary.org/obo/IAO_0000221)
Object Property “is quality measured as” (http://purl.obolibrary.org/obo/IAO_0000417)
Entity “length measurement datum” (http://purl.obolibrary.org/obo/IAO_0000408)
Entity “physical object quality” (http://purl.obolibrary.org/obo/PATO_0001241)
Entity “morphology” (http://purl.obolibrary.org/obo/PATO_0000051)
Entity “physical quality” (http://purl.obolibrary.org/obo/PATO_0001018)
Entity “length” (http://purl.obolibrary.org/obo/PATO_0000122)
Entity “mass” (http://purl.obolibrary.org/obo/PATO_0000125)

Adding Identifier to entity “time series” / and all sub entities

Entity “identifier” (http://purl.obolibrary.org/obo/IAO_0020000) via property “has part”

It was suggested to import measurement datum which is defined as: A measurement datum is an information content entity that is a recording of the output of a measurement such as produced by a device.
We already have quantity value defined in the OEO: A quantity value is an information content entity defined by a numeral together with a unit of measurement to quantify an entity.
So there is at least some overlap between those two and what is the relation between those? Is a measurement datum a quantity value that was determined (measured) using some measuring device?

It was suggested to import measurement datum which is defined as: A measurement datum is an information content entity that is a recording of the output of a measurement such as produced by a device. We already have quantity value defined in the OEO: A quantity value is an information content entity defined by a numeral together with a unit of measurement to quantify an entity. So there is at least some overlap between those two and what is the relation between those? Is a measurement datum a quantity value that was determined (measured) using some measuring device?

A quantity value and a measurement datum are very similar, that's correct. But we need a possibility to connect a measurement_datum (or a quantity_value) to a specific Timestamp.
The time_series in OEO contains only Timestamps / Timespans, but no reference to the corresponding measured values. So a data_set / time_series / time_sampled_measurement_data_set with a Timestamp and a Measured Datum in every step is needed.


Add table class automatically

I want to add automatically a class in a table (), I try to change the parserRule file but it don't work:

"table": {
"keep_styles": {
"width": 1,
"textAlign": 1,
"float": 1
},
"check_attributes": {
"id": "any"
},
"add_class": {
"table": "table"
}
},

Can you help me ?

Will be available with next release (today). The class will be inserted when cleanup occurs (not at table insertion though currently). Cleanup can be triggered manually by editor.cleanUp()

and released

Thank you :)


Mage Training Arena helper

Would be cool to see a helper for this minigame. For example, in the telegrab room it tells you where to stand for each puzzle, alchemist room it tells you where all the items are once opened a chest + a timer that tells you when the next rotation happens. I don't thinks the other rooms need any kinda helper. Now the question is, if it is possible to create and if it would be allowed. I don't see this to be OP or so, since all the puzzle solutions are found on the wiki and alchemist room always has the same rotation in items once you know where one item is.

See #2218 for a similar suggestion, but I believe this is a gray area for how much the client would be telling the player what to do and where to stand. Just my opinion.


As a user who finds a leaf detail page from search, I should be prompted to view that leaf in the context of the timetree so that I can experience the project as intended.

Add a simple call to action / link / button from the leaf detail page to view that leaf in the context of the tree. Maybe use the small static version of the timetree svg?
(ooh, if we embed the tree svg could we highlight the leaf for that page in the context of the tree? probably complicated and not necessary!)

implemented with @gissoo ; confirmed working on develop site


Icons not rendered on prerender

Stencil version:

<EMAIL_ADDRESS>
I'm submitting a:

[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
I've initialized empty project with npm init stencil, chose first option, made little changes (added simple button), ran npm run build --prerender, opened result HTML file with a local server (Live Server extension for VS Code) and found out that ion-back-button is not rendered - it is present in the DOM but not rendered visually as it was in dev mode. Possibly this affects all ionic icons.
Expected behavior:
All icons are rendered correctly at prerender step.
Steps to reproduce:
npm init stencil
npm run build --prerender
open HTML file with a local server
go to profile page and see empty button
Other information:
I've added red pointer to make to find button that I meant.

screenshot on dev mode (npm start)

screenshot on prerender mode (npm build --prerender) and then opening with a local server

label: prepender

Thanks for the issue! This issue is being closed due to the lack of a code reproduction. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
Thank you for using Ionic!


GraphQL errors are not correctly passed to component props

With<EMAIL_ADDRESS>it appears that:
(new ApolloError()) instanceof ApolloError // false
This is causing errors to be thrown from here:
https://github.com/apollostack/react-apollo/blob/02fe991c8645c939e5d41587c76c447c7081e02f/src/graphql.tsx#L381
Here's the relevant code which changed recently in apollo-client:
https://github.com/apollostack/apollo-client/blob/master/src/errors/ApolloError.ts#L3
Version

<EMAIL_ADDRESS><EMAIL_ADDRESS>

@helfer should we be using isApolloError?

@tmeasday as you probably saw in the code I ended up adding that function because I couldn't figure out why after updating TS new ApolloError() instanceof ApolloError === false. It's not exported though, so if it should be fixed quickly, I suggest just checking for the graphqlErrors property on the error, and then changing it to isApolloError later.

@helfer it's probably because extending built-in classes cannot be properly subclassed with transpilers, see:
http://stackoverflow.com/questions/33832646/extending-built-in-natives-in-es6-with-babel
https://github.com/babel/babel/issues/1424

I think a quick fix is warranted here if someone wants to take a look.


docs: remove IdleTimeLimit until it is actually implemented

it gives users false hope and finally disappoints them.

+1
The configuration files and the manuals are not the right place for TODO lists.
Please note that there are still references to IdleTimeLimit, max_idle_time, and XRDP_SESMAN_MAX_IDLE_TIME in the code. If nobody plans to implement idle timeout, they should be removed too.

I think everything to support idle timeout is done in xrdp (as frontend). The rest part should be done in xorgxrdp/x11rdp.  We can remove such code and whenever resurrect it from git history if implementation is done in backend.

OK, let's merge

No logic change, merging immediately.


derived attributes - sort month names

Hi,
I am looking to sort month names in their proper order. I know pivottable uses natural sort and hence it is sorted alphabetically by default.
There is a solution to this too on FAQ section - that append month numbers before month names, that actually solves problem..
But, when displayed on report (pivot table), I don't want numbers.. want only month names. What's the best way to achieve this ?
Thank you.

Make sure your months have numbers so thery are sorted naturally in the correct order.
I use "01." (include the period, we'll use it later)

Now in the pivotTableRenderer function definition, declare a regex pattern.
var sortPattern = /^\d\d\./;
Example:

Now it is really simple to display month-names without numbers.
The <th> headers with the month names are populated in a loop.

Simply apply the sortPattern to the content of the <th> tag, In our case, we're stripping the numbers off the months. The original version - with numbers - will be used for sorting, but they are now displayed without the numbers.
Problem solved. No need for difficult add-on methods or anything.

In general, the pivot table sorts based on what it displays and displays the input given. If you want to sort based on one thing and display another you'll have to either override the natural sort function in the library or do some post-processing as with the solution posted above.
I'm considering making the sorting function overridable given how often this issue comes up... See #236

There is now a mechanism to override the natural sort either on a per-attribute basis or globally. See documentation for the sorters parameter and the example which shows how to sort month names without leading numbers.


inlining height

I'd like to inline height attributes the same way as width attributes. At least on <img> elements.
I'm fine writing it (I'm working on the PR now).
But is there any reason juice doesn't already do this or reason people may not want height inlined?
ie: Something I'll have to consider when implementing the defaults.

In most of my experience I was building for designs that had a specified width and would leave the heights unset so they were auto based on the widths. So, that was just the bias I had when I added the feature.
If you are adding an option applyHeightAttributes and have the default false then it shouldn't cause anyone any trouble. You likely want to use the same or similar list of elements to apply to as for width., though add another variable for the list rather than using the same one as for the width attributes.


Fixed issues "Research Page Card Modification: Fonts"

Proposed Changes
Title: Semi Bold
Authors: Medium
Conference: Regular
Issue #423
for font weight values reference : https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

Use Poppins as the font please

Use Poppins as the font please

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

Use Poppins as the font please

done 👍

Use Poppins as the font please

done 👍

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

I don't know how to rebase the commits ,could you please tell me or refer some article

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

I don't know how to rebase the commits ,could you please tell me or refer some article

An article on Rebase
Squash Commits

An article on Rebase
Squash Commits

An article on Rebase
Squash Commits

Thanks ! 👍

An article on Rebase
Squash Commits

Thanks ! 👍

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

done

While doing multiple changes that end up in a single PR, try to rebase them and squash the commits into a single commit. Makes the code more readable in long term!

done


file-location-0.4.7 can't compile its test suite

Citing from http://hydra.cryp.to/build/538169/log/raw:
Preprocessing test suite 'test' for file-location-0.4.7...

Debug/FileLocation.hs:11:8:
    Could not find module ‘Language.Haskell.TH.Instances’
    It is a member of the hidden package ‘th-orphans-0.9.0’.
    Perhaps you need to add ‘th-orphans’ to the build-depends in your .cabal file.

Thanks! This is fixed in <IP_ADDRESS>


Delete documents by query parameters (with filter)

Related to this product issue: https://github.com/meilisearch/product/issues/283
Goals
Delete some documents based on a filter query string
How it works?
When calling DELETE /indexes/:uid/documents the user should be able to pass a query parameter filter. The syntax of filter is exactly the same as we can use on the search side (with POST/GET /indexes/:uid/search), see the associated docs
⚠ for this first iteration, the fields used in filter should be set in filterableAttributes. This is something we might want to improve in another issue.
For example
curl \
  -X DELETE 'http://localhost:7700/indexes/movies/documents?filter=genre%3D%22horror%22

Which is the equivalent to filter: "genre = horror"
All the documents with "genre": "horror" will be deleted
About the deletion tasks
When calling the /tasks endpoint, the user gets information about the deletion task processed by filtering.
We need to see the following information (an example with books index)
{
            "uid": 1,
            "indexUid": "books",
            "status": "succeeded",
            "type": "documentDeletion",
            "details": {
                "deletedDocuments": 6,
                "receivedDocumentIds": 8,
                "filter": "genre = horror"
            },
            "duration": "PT0.008096800S",
            "enqueuedAt": "2022-09-22T15:11:07.7647005Z",
            "startedAt": "2022-09-22T15:11:07.770342Z",
            "finishedAt": "2022-09-22T15:11:07.7784388Z"
}

filter fields has been added and contain the filter string
receivedDocumentIds is the number of documents that matched the filter query when the request was applied
⚠ If the following issue is solved (https://github.com/meilisearch/meilisearch/issues/2799), it means receivedDocumentIds has been renamed matchedDocuments

Both of these fields should not be present if no filter were given
Errors

When sending an invalid syntax, the error sent should be the same we have when calling the /search route
If the filter does not match any document, no documents are deleted, but no error are thrown. The request still returns the task information, and when getting the task information using the /tasks route, you will have the following details:

...
"details": {
     "deletedDocuments": 0,
     "receivedDocumentIds": 0,
     ...
 }
...

TODO

[ ] Implement this in Meilisearch: only this step is available for external contributions
[ ] Release a prototype
[ ] Correct the prototype following user's feedback
[ ] Merge the final version on main
[ ] Create a new spec about the feature

Related teams
Pinging @meilisearch/integration-team and @meilisearch/docs-team FYI

Feel free to ask any questions to implement this issue. The core team is available to guide you through this contribution, even if it's your first one.
We recommend referring to the CONTRIBUTING.md guidelines, especially if it's your first contribution to this repository.
Thanks in advance for your involvement ❤

I think this issue is interesting, I'll try fixing it!

Hello @amab8901,
thanks for your involvement, looking forward to reviewing your PR ❤

I noticed that filter query string works only for POST request currently, and not GET request. When you search, you don't use GET request. You only use POST request, and you're deciding what you want to create in the search results list. GET can only give you the entire database rather than selected parts of it, as of this writing.

@amab8901 FYI even if you have found how to do it, it's currently possible with Meilisearch to do a search with GET and thus, having filter as query parameter (in the URL)

I managed to reproduce the error in my Client API, and also managed to narrow down the relevant code to a handful of files in a single folder. This is my first open-source contribution so please excuse me if it takes a while to get it done.

So cool you make your first contribution with us then! 😄
Feel free to ask any question you need

For everyone watching this issue, I've updated the issue to return the filter string in the task body!

meilisearch/meilisearch-http/tests/documents seems to be the place where I should be editing, but I'm not really sure since this belongs to the tests folder rather than src folder. Can you confirm?

let (response, code) = index.get_document(0, None).await;
I need to put Option<GetDocumentOptions> instead of None above. I'm trying to figure out how to put those options in there.

Hello @amab8901,
While trying to make suggestions about the implementation of the feature, we figured out that this would impact a lot of parts in the code, including:

the HTTP server
the task scheduler, which is currently completely rewritten by the core team that will imply painful merge conflicts
the dumps, which is a "protected" part where we avoid external contributions

Moreover, speaking with the product manager, we are not satisfied with the proposed API design and we will probably change it.
We made a mistake by classifying it as a good first issue and as a contribution accepted, for now, we prefer closing this issue to refine it later.
We are sorry for this. 🙏
Thanks a lot for the time you spent on this issue, I hope to see you on another one! 😊

poke @curquiza, @Kerollmops, and @gmourier

no worries! If you're going to implement this kind of change though, I think you should first have a ticket that instruct people to add a test for the filtering of GET requests. I couldn't find any tests for filtering GET requests, and i'm surprised at this. I think you should add this and I really don't know how it's supposed to look like because I couldn't find any examples of filter option actually being tested/used in the code.

Thanks @ManyTheFish, for the answer
And @amab8901, sorry for the confusion, indeed we were too optimistic.

@curquiza I still think that there needs to be a test for the filtering feature on the GET document requests, so I'm working on figuring it out until I got it solved. I finally overcame the primary obstacle I had where I struggled to instantiate a struct. I finally figured out how to do it. Wow. Unbelievable.

Just to be sure there is no lack of communication and no confusion: this is not a feature we want to develop now, so we won't accept any PR for this. We need to discuss it with the product team deeper. However, we don't give up on it, it's just we don't know yet HOW we want to provide the feature. So I don't recommend working on this issue because we don't expect what I described in the description for the API anymore 😊


Minor code cleanup

Encountering test failures like the following:
thread 'addr2line -a' panicked at 'Output not equivalent:

$ addr2line -a --exe /home/travis/build/gimli-rs/addr2line/target/debug/deps/output_equivalence-5b11626a4e2b33af 0x8ac9e 0x8ac7d 0x8ab92 0x8ae8b 0x8887c
0x000000000008ac9e
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:?
0x000000000008ac7d
3uo7078qw7tbfl1l:?
0x000000000008ab92
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:35
0x000000000008ae8b
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:69
0x000000000008887c
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:129

$ /home/travis/build/gimli-rs/addr2line/target/debug/examples/addr2line -a --exe /home/travis/build/gimli-rs/addr2line/target/debug/deps/output_equivalence-5b11626a4e2b33af 0x8ac9e 0x8ac7d 0x8ab92 0x8ae8b 0x8887c
0x000000000008ac9e
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:?
0x000000000008ac7d
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:?
0x000000000008ab92
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:35
0x000000000008ae8b
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:69
0x000000000008887c
/home/travis/build/gimli-rs/addr2line/tests/output_equivalence.rs:129

Not sure if this is now occuring due to a change in rustc or binutils, but either way this looks like a bug in binutils because querying one address at a time works correctly. Added a commit with this workaround.

Coverage decreased (-0.3%) to 74.041% when pulling 8dcd104f6686b7c64a31547328a243fb310774ac on philipc:fmt into 85be6c7440051b443cee310b418065c63257fe70 on gimli-rs:master.


How is this to be used?

Not having any experience with PID controlelrs I need a nudge to get this going.
I have a water heating system that has a pump to push water through a set of solar panels to heat up a large tank. I thought I could employ this controller to manage the pump speed based on the temperature of the hot tank vs the temperature of the water coming off the solar panels. My problem is that I don't really understand how I should be using the controller.
I set the ReferenceSignal  to the difference in temperature I am looking for, e.g 3.0 Celsius. Then I set the actual value to the observed difference in the two measured temperatures. I am sampling every 5 seconds.
Is this correct or am I completely missing the point?
Once I get the result by asking for the State, how should I interpret it? Should I use the ControlSignal to adjust the pump speed? Obviously it would need to be capped at 100% but should that somehow be fed back tot he controller?
Please forgive my ignorance here.

Hello @IanAber! Cool to see that you have found this repository in the hunt for what seems to be some fun home automation! Sorry about the late answer.
Thanks for a good explanation of your system. I will try to give a code example below! Don't be afraid to shoot off any follow-up questions!
Just to start with, systems control theory, including PID controllers, get complex very fast. The fun thing with PIDs is that you can quite easily try it out and try to tune it without having being a rocket scientist. To get a really well-tuned PID however (both stable and fast), some in-depth theoretical knowledge is most likely needed.
With that said, you are definitely on the right track! In code, it would look something like this when abstracting away the pump and thermometers:
type Pump interface {
	Control(value float64)
}

type Thermometer interface {
	MeasureTemperatureCelsius() float64
}

func runPumpController(
	ctx context.Context,
	pump Pump,
	tankThermometer Thermometer,
	panelThermometer Thermometer,
) {
	const referenceDifference = 3.0
	controller := pid.Controller{
		Config: pid.ControllerConfig{
			ProportionalGain: 2.0,
			IntegralGain:     1.0,
			DerivativeGain:   0, // think we should be mighty fine without a derivative part
		},
	}
	const samplingInterval = 5 * time.Second
	ticker := time.NewTicker(samplingInterval)
	for {
		select {
		case <-ctx.Done(): // to return when the above given context is Done
                        return
		case <-ticker.C:
			tankTemp := tankThermometer.MeasureTemperatureCelsius()
			panelsTemp := panelThermometer.MeasureTemperatureCelsius()
			actualDifference := tankTemp - panelsTemp
			controller.Update(pid.ControllerInput{
				ReferenceSignal:  referenceDifference,
				ActualSignal:     actualDifference,
				SamplingInterval: 5 * time.Second,
			})
			pump.Control(controller.State.ControlSignal)
		}
	}
}

This does not take into account the limitation of the pump input (as you say 100%), however I think with the integral part of the controller, it might just work well without it. If you want that, you could look at the TrackingController, which except for adding low-pass filter for the derivative term and AntiWindUp to not let the integral part sky-rocket, it adds MaxOutput and MinOutput, to take into account the limitation of the controller when calculating the ControlSignal.
A final recommendation; even if you don't want to go full systems-engineering-theoretical to guarantee a stable controller, I still think it could be worthwhile to try to model your system. By modelling your system you will be able to simulate the controller and get a feel of how the PID acts.
Hope this helped! Let me know if there are any other questions!
Best,
Erik

This is really great information. I am truly grateful for the time you have taken.
Ian Abercrombie
￼
@.*** @.***>
Phone: +1<PHONE_NUMBER>
www.CedarTechnology.com http://www.cedartechnology.com/

On Feb 28, 2023, at 5:59 AM, erikbohnsack @.***> wrote:
Hello @IanAber https://github.com/IanAber! Cool to see that you have found this repository in the hunt for what seems to be some fun home automation! Sorry about the late answer.
Thanks for a good explanation of your system. I will try to give a code example below! Don't be afraid to shoot off any follow-up questions!
Just to start with, systems control theory, including PID controllers, get complex very fast. The fun thing with PIDs is that you can quite easily try it out and try to tune it without having being a rocket scientist. To get a really well-tuned PID however (both stable and fast), some in-depth theoretical knowledge is most likely needed.
With that said, you are definitely on the right track! In code, it would look something like this when abstracting away the pump and thermometers:
type Pump interface {
Control(value float64)
}
type Thermometer interface {
MeasureTemperatureCelsius() float64
}
func runPumpController(
ctx context.Context,
pump Pump,
tankThermometer Thermometer,
panelThermometer Thermometer,
) {
const referenceDifference = 3.0
controller := pid.Controller{
Config: pid.ControllerConfig{
ProportionalGain: 2.0,
IntegralGain:     1.0,
DerivativeGain:   0, // think we should be mighty fine without a derivative part
},
}
const samplingInterval = 5 * time.Second
ticker := time.NewTicker(samplingInterval)
for {
select {
case <-ctx.Done(): // to return when the above given context is Done
return
case <-ticker.C:
tankTemp := tankThermometer.MeasureTemperatureCelsius()
panelsTemp := panelThermometer.MeasureTemperatureCelsius()
actualDifference := tankTemp - panelsTemp
controller.Update(pid.ControllerInput{
ReferenceSignal:  referenceDifference,
ActualSignal:     actualDifference,
SamplingInterval: 5 * time.Second,
})
pump.Control(controller.State.ControlSignal)
}
}
}
This does not take into account the limitation of the pump input (as you say 100%), however I think with the integral part of the controller, it might just work well without it. If you want that, you could look at the TrackingController, which except for adding low-pass filter for the derivative term and AntiWindUp to not let the integral part sky-rocket, it adds MaxOutput and MinOutput, to take into account the limitation of the controller when calculating the ControlSignal.
A final recommendation; even if you don't want to go full systems-engineering-theoretical to guarantee a stable controller, I still think it could be worthwhile to try to model your system. By modelling your system you will be able to simulate the controller and get a feel of how the PID acts.
Hope this helped! Let me know if there are any other questions!
Best,
Erik
—
Reply to this email directly, view it on GitHub https://github.com/einride/pid-go/issues/87#issuecomment-1447975423, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABANTHDDEAM5RYNIRF3ASGTWZXK7RANCNFSM6AAAAAATZVW4Q4.
You are receiving this because you were mentioned.

Glad to hear @IanAber! :)


Cannot use already existing installation of QT 5.10.1

Hello.
On thet Requirements page we can see Qt 5.10+. So I've expected to be able to use QML .NET with already existing installation of QT.
I'm on Windows 10 1903 x64. I've installed QT 5.10.1 prebuilt components for MSVC 2017 64-bit via qt-opensource-windows-x86-5.10.1.exe.
Resulting installation folder is C:\Qt\Qt_5.10.1\5.10.1\msvc2017_64 (during installation process I was able to choose only C:\Qt\Qt_5.10.1 folder - all subfolders are selected automatically).
And of course that resulting folder contains all necessary subfolders - bin, plugins and qml.
I'm trying to run QML .Net example using my existing installation:
RuntimeManager.ConfigureRuntimeDirectory(@"C:\Qt\Qt_5.10.1\5.10.1\")
But that results in error that

Plugins directory didn't exist "CC:\Qt\Qt_5.10.1\5.10.1\qt\plugins"

Looks like qt subfolder name is hardcoded inside RuntimeManager.Configure.cs
So how to deal with that situation?
How to properly use QML .NET with already existing installation of QT 5.10.1 (editing RuntimeManager.Configure.cs and recompile QML.Net.dll is not a good option)?
Thank you.

Hmm, it looks like that RuntimeManager.Configure needs to poke around a bit more.
The only thing that method does though is set some environment variables. You could set those yourself in Program.Main. Really though, in production environments, this is how it should be done, considering most published applications embed the Qt framework privately in their own folder.

Also, if you use your own Qt runtime, make sure you compile the native bits for Qml.Net yourself and put them in your PATH somewhere.

Allow me to clarify.
All Qt libs (when using private headers) must be compiled against the exact Qt version they are running against. So, you can't just use "Qml.Net.WindowsBinaries" with any Qt runtime. If you use your own Qt installation, you must only use the Qml.Net package, and compile the native libs that are in "Qml.Net.WindowsBinaries" yourself.
The build/installation is really simple. See here.
The "Qml.Net" package will find an invoke the native C-interop QmlNet.dll properly.

What I've tried (on Windows 10 1903 x64):

Installed QT 5.10.1 prebuilt components for MSVC 2017 64-bit via qt-opensource-windows-x86-5.10.1.exe. Resulting installation folder is C:\Qt\Qt_5.10.1\5.10.1\msvc2017_64.
Downloaded qmlnet repository. Inside build.bat i've changed qmake to C:\Qt\Qt_5.10.1\5.10.1\msvc2017\bin\qmake and jom to C:\Qt\Qt_5.10.1\5.10.1\msvc2017\Tools\QtCreator\bin\jom.
Started Visual Studio 2019 Developer Command Prompt v16.3.6 and started build.bat inside it. Succesfully built \output\QmlNet.dll.
Downloaded qmlnet-examples repository. Removed Nuget references to all runtimes (MacOSX, Linux and Windows). Copied QmlNet.dll to project folder.
Added RuntimeManager.Configure.cs to qmlnet-examples project (inside it I've changed namespace to Features and changed hardcoded qt subdirectory name to msvc2017_64). Changed RuntimeManager.DiscoverOrDownloadSuitableQtRuntimes(); to RuntimeManager.ConfigureRuntimeDirectory(@"C:\Qt\Qt_5.10.1\5.10.1\");.
Compiled qmlnet-examples project (restored all needed Nuget packages of course) and started debugging.
RuntimeManager.ConfigureRuntimeDirectory(@"C:\Qt\Qt_5.10.1\5.10.1\"); finished correctly. But QQuickStyle.SetStyle("Material"); results in exception:

The type initializer for 'Qml.Net.Internal.Interop' (inside Qml.Net) threw an exception: Symbol loading failed. Symol name: type_info_setPrefVariantType (inside NetNativeLibLoader)

So what I am doing wrong?

I've tried the same approach with Qt 5.11.0 on Debian 9. On Step 2 I've succesfully compiled libQmlNet.so via build.sh. But again on Step 6 I've faced the same exceptions.
Looks like I'm going the wrong way :)

Make sure you compile the native lib using the same exact version as the NuGet library. Checkout the write tag in the git repo.

Oh, that waas my mistake. I used latest version of native lib instead of release 0.10.1. Now it's working (both Windows and Linux).
Final instruction for using Qml .Net with existing QT installation (tested on Windows 10 1903 x64 with QT 5.10.1 and Debian 9 with QT 5.11.0):
What I've tried (on Windows 10 1903 x64):

Download qmlnet repository for the same exact version as the NuGet library.
On Windows: Inside build.bat change qmake to Your_QT_bin_path\qmake and jom to Your_QtCreator_bin_path\jom. Start Visual Studio 2019 Developer Command Prompt v16.3.6 x64 and run build.bat inside it.
2*. On Linux: Simply run build.sh.
On both systems Native C-interop library wil be built to \output\QmlNet.dll. Copy that library to your project folder.
Use code from RuntimeManager.Configure.cs directly in your project. Make sure that inside RuntimeManager.ConfigureRuntimeDirectory() you've changed hardcoded qt subdirectory name to msvc2017_64 or the one that you use.
Use RuntimeManager.ConfigureRuntimeDirectory(Your_QT_directory) instead of RuntimeManager.DiscoverOrDownloadSuitableQtRuntimes();
Now your code doesn't need to download Qml .Net runtimes and can run on existing QT installation.

Oh, that waas my mistake. I used latest version of native lib instead of release 0.10.1. Now it's working (both Windows and Linux).
Final instruction for using Qml .Net with existing QT installation (tested on Windows 10 1903 x64 with QT 5.10.1 and Debian 9 with QT 5.11.0):
What I've tried (on Windows 10 1903 x64):

Download qmlnet repository for the same exact version as the NuGet library.
On Windows: Inside build.bat change qmake to Your_QT_bin_path\qmake and jom to Your_QtCreator_bin_path\jom. Start Visual Studio 2019 Developer Command Prompt v16.3.6 x64 and run build.bat inside it.
2*. On Linux: Simply run build.sh.
On both systems Native C-interop library wil be built to \output\QmlNet.dll. Copy that library to your project folder.
Use code from RuntimeManager.Configure.cs directly in your project. Make sure that inside RuntimeManager.ConfigureRuntimeDirectory() you've changed hardcoded qt subdirectory name to msvc2017_64 or the one that you use.
Use RuntimeManager.ConfigureRuntimeDirectory(Your_QT_directory) instead of RuntimeManager.DiscoverOrDownloadSuitableQtRuntimes();
Now your code doesn't need to download Qml .Net runtimes and can run on existing QT installation.


CoreBotAdapter is missing EoC logic

CoreAdapterBot should include the End of Conversation handling demonstrated by sample 81
https://github.com/microsoft/BotBuilder-Samples/tree/main/samples/csharp_dotnetcore/81.skills-skilldialog

The problem @johnataylor is that you need to know if there are any active dialogs in order to automatically send an EoC activity.  That sample has an assumption that you're using our dialog system and AdapterCoreBot doesn't. Correct?
How do we know when to send EoC for core bot?

@johnataylor is this still in scope for R13?

@Stevenic Via SkillConversationReferenceKey?

Discussed with @gabog, this is not going to be delivered in R13.

See comments in linked issue.

Perhaps we should be moving error handling like this into the bot and not attempt to do it in the adapter global OnError


add ProteinsX dataset classes

Reference Issues/PRs
Adds dataloaders for the following built in datasets: #13

PROTEINS_METAL
PROTEINS_NUCLEIC
PROTEINS_LIGANDS
PROTEINS_NUCLEOTIDES

What does this implement/fix? Explain your changes
What testing did you do to verify the changes in this PR?

Local testing.

Pull Request Checklist

[ ] Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
[ ] Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
[ ] Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
[ ] Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
[ ] Checked for style issues by running black . and isort .

Codecov Report

Merging #204 (2db8ce2) into master (8123f42) will increase coverage by 6.56%.
The diff coverage is 41.53%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   40.27%   46.83%   +6.56%
==========================================
  Files          48       93      +45
  Lines        2811     5647    +2836
==========================================
+ Hits         1132     2645    +1513
- Misses       1679     3002    +1323

Impacted Files
Coverage Δ

graphein/grn/parse_trrust.py
37.77% <ø> (ø)

graphein/ml/datasets/proteins_x.py
0.00% <0.00%> (ø)

graphein/ml/diffusion.py
0.00% <0.00%> (ø)

graphein/ppi/edges.py
100.00% <ø> (ø)

graphein/ppi/graph_metadata.py
0.00% <ø> (ø)

graphein/ppi/graphs.py
54.34% <ø> (ø)

graphein/ppi/parse_biogrid.py
75.00% <ø> (ø)

graphein/ppi/visualisation.py
0.00% <0.00%> (ø)

graphein/protein/analysis.py
0.00% <0.00%> (ø)

graphein/protein/edges/intramolecular.py
22.68% <0.00%> (ø)

... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: Feedback addressed by adding more usage example on readme file

Hi guys,
As @sandygross suggested, I updated the blurring pictures and illustrate usage via pnorm and pexp. Please take a look!
Note: The picture in the sample usage will be rendered after merge to the main.

I also fix the format of the norm function. Please take a look.


Replace all GOGS_* variables

The title already says everything, there are still variables with this making schema.

PR ready to fix this: https://github.com/go-gitea/gitea/pull/103


Improve CLEAR_MODES docs

As discussed with @SukantPal , I have to clarify this once more.
Most people that write filters dont know about clamping and other tricks that are needed in case we use pow2 temporary renderTextures. Even our BlurFilter is affected, @GoodBoyDigital wrote this version for v5 :)
For them, we distinguish two clearing modes - one CLEAR that clears everything, and second BLIT that just overwrites new content over texture, and leaves right and bottom zone as it was.

@ivanpopelyshev BLIT mode doesn't not clear only the filtering area on the texture right now. If that was the intended purpose, we need to fix it.

I find this doc change not particularly useful or legible. This need some editing for clarity.

Codecov Report

Merging #7075 (53e5a2b) into dev (1127bd7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #7075   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           17        17
  Lines          699       699
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1127bd7...53e5a2b. Read the comment docs.

Thank you @SukantPal and @ivanpopelyshev for making this better.


Update stop departure logic

Summary of changes
Asana Ticket: 🚉 Stations/Stops | Departure empty state

Adds a "no schedules in 24 hours" message to route cards.
Updates logic on stop controller to be more permissive about which schedules get shown.
Updates subway and bus schedules to display as gray, so they are distinguished from predictions

Checklist

[x] New functions have typespecs, changed functions' typespecs were updated
[x] New modules and functions have documentation, changed modules/functions' documentation was updated
[x] Tests were added or updated to cover changes
[x] All tests pass on localhost:

[x] npm test (includes mix test, JS tests, and Backstop)
[x] npm run dialyzer
[x] pronto run -c origin/master

Assigned to: @meagonqz // @ingridpierre

Top is current, bottom is desired appearance.
Needs some adjustments on the "no departures message":

make link .c-call-to-action
add padding to make the text sit better inside the card.
use the route name, not the long name
"View [route number] schedule"

@ingridpierre formatting updated, ready for another look


1.0.0 doesn't work with request

See, https://github.com/request/request/pull/1837 and the Travis CI builds.

Your test uses a PEM key that lacks a trailing newline after the -----. The PEM RFC isn't totally clear on whether this is valid or not, so the behavior seems to vary a little between parsers. The OpenSSL PEM parser is fine with any combination of leading or trailing whitespace though, so I've changed the sshpk parser to match this.
The new version of sshpk with this fix is 1.4.5. http-signature's dependency is on "^1.4.0", so re-trying the build should get you a fixed version.


yotta link guide required

The docs site needs a guide to using yotta link, and yotta link-target adding. For people who don't have an npm background, these commands can be confusing.

Feature I planned on adding but havent had much time is something like yotta --dev which pulls from the repo rather than the registry. Seems like most all the data is present to do this in module.json where the dependencies version could be scanned and pull the same code, just clone from the git release tag rather than pulling from the registry
  "repository": {
    "url": "git@github.com:mbedmicro/mbed_private.git",
    "type": "git"
  }

i'm sure you wont like this so wanted to propose before putting too much effort into it.

I don't think trying to pull things from repository arguments specified in the module descriptions is a good idea:

We shouldn't encourage people to edit things inside the yotta_modules cache. If you step in there you are treading into uncharted Here Be Dragons territory, where you may be surprised to find your changes overwritten or otherwise destroyed. For example, if you edit a module.json file so that it's invalid json then try to build, yotta will treat it as if the module didn't exist, and try to download it again overwriting any existing module.

If you have to link lots of modules to make a single bugfix / whatever, then those modules are too interdependent on each other. You should never normally have to link more than one module to make a pull request to fix something. (The only exception to this is adding an mbed-hal port, which you don't want anyone else to know about until it's completely finished (which prevents you from getting your target-specific dependencies included upstream before you're done, so you have to link both the hal implementation and the module that needs modifying to pull in your hal implementation for your target)).

Even a small application will commonly have 20+ dependencies, each of which may be a git/hg repo with many MB of changes. Cloning all of those for development when you only needed one or two seems wasteful.

Repository is not a required field in module.json, and it is not validated.

The yotta_modules folder is not necessarily flat. (there may be nested yotta_modules/moda/yotta_modules/modb/yotta_modules/etc directories). So we might end up checkout out git repos inside existing git repos.

yotta link works perfectly well for this, and puts you in complete control. It's a better solution all round.

I'm not suggesting modifying the yotta module cache. Just suggesting a flag --dev that doesnt pull from the registry, rather uses metadata that exists in the module.json files to pull the development repo with history into the yotta_modules directory. This is non intrusive and the other method is adding a dev_dependencies section that only gets used when the --dev flag is passed. Lets look at the workflow proposed and I'd appreciate the steps using link to compare whats requested of the developers.
development> git clone http://github.com/armmbed/mbed-os-porting-program
development> cd mbed-os-porting-program
mbed-os-porting-program> yotta target gcc-port-target
mbed-os-porting-program>  yotta build --dev

At this point the directory yotta_modules within mbed-os-porting-program has a clone of our official documentation and shell (failing implementation of mbed hal, etc) and can start to develop and make changes. Next there would be a few options regarding commiting and uploading the changes.

User goes into yotta_modules and edits the module.json for the port and add a new remote with git to push the repo to
We use a script similar to what mbed IDE currently does and traverse the yotta_modules directory and use yotta to edit the module_json and change the remote.

mbed-os-porting-program> cd yotta_modules
yotta_modules> ls
yotta_modules> cd some_module
some_module> git commit -am "My changes"
some_module> git add remote personal http://github.com/myaccount/some_module
some_module> git push personal master <or branch etc...>

Ideally we add this flow to yotta to find all the dependencies that were created but also dont think its unreasonable to use the above git workflow since I think that equivalent when using link (but there is room for improvement

the yotta_modules folder is the yotta modules cache
a devDependencies section is something that npm has, with a different meaning (for various reasons the equivalent yotta dependencies, which get installed only when you're compiling the module directly, not indirectly as a dependency, are called testDependencies instead)

So when someone pulls dependencies with a program (guessing they always end up in yotta_modules) we're suggesting that they don't modify a dependency? I'm guessing that drivers for sensors will end up in there and if magic things can happen by the tool what type of development are people suppose to do? Sounds very scary to me. Just edit a main file? There are less that 10% (being generous) of libraries published on mbed without forks because they were written so well that no one has to modify when publishing their work based on it. Im getting nervous or hopefully misunderstand something...

This is the scary new world of modular software. Where you actually re-use code, instead of treating everything as an app note or example code from which to chisel away your own application.
The only circumstance where you modify a dependency (other than to update a new version) is to contribute a re-usable improvement or bugfix to it.

is it expected that every dependency will come with its own test harness that permits independent  checkout, test/fix, check in?

On Jun 28, 2015, at 11:12, James Crosby<EMAIL_ADDRESS>wrote:
This is the scary new world of modular software. Where you actually re-use code, instead of treating everything as an app note or example code from which to chisel away your own application.
The only circumstance where you modify a dependency (other than to update a new version) is to contribute a re-usable improvement or bugfix to it.
—
Reply to this email directly or view it on GitHub.

Yes, absolutely!

On 28 Jun 2015, at 17:31, Doug Anson<EMAIL_ADDRESS>wrote:
is it expected that every dependency will come with its own test harness that permits independent checkout, test/fix, check in?

On Jun 28, 2015, at 11:12, James Crosby<EMAIL_ADDRESS>wrote:
This is the scary new world of modular software. Where you actually re-use code, instead of treating everything as an app note or example code from which to chisel away your own application.
The only circumstance where you modify a dependency (other than to update a new version) is to contribute a re-usable improvement or bugfix to it.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

Question: would this be solved by modifying the sensor library module locally, then linking it to the executable module, also locally?

Fixed by #565


nu_scripts: init at unstable-2023-03-16

Description of changes
nu_scripts is a place to share Nushell scripts with each other. Most importantly (in my opinion) it contains completions for commonly used commands.
This package can be used in conjunction with, for example, home-manager to declaratively include the scripts:
  home-manager.users.CardboardTurkey.programs.nushell.extraConfig = ''
        use ${nu_scripts}/share/nu_scripts/git/git.nu *
        use ${nu_scripts}/share/nu_scripts/custom-completions/git/git-completions.nu *
        '';

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@Br1ght0ne would you be an appropriate person to review this?

Thank you!


Updating article to indicate that Local Cache is not supported for Azure Functions.

This is discussed in https://github.com/Azure/azure-functions-ux/issues/2215 and a work item is open to add a warning if the App Setting is enabled for Azure Functions apps.

@FinVamp1 : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

@FinVamp1 Is there any plan other than the two you specified? If not, we can just simplify the note to:
> Local cache is not supported in Function apps or containerized App Service apps, such as on [App Service on Linux](containers/app-service-linux-intro.md).

+1
I also think @cephalin 's edit makes much more sense.

That looks great, Thank you.

@FinVamp1 : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

Updated to use suggested text.

#sign-off


Feature flag

What does this PR do?
Adds Feature Flag functionality.
Creates: Feature and FeatureFlagsContext components
Wraps application in a FeatureFlagProvider in index.tsx
Loads Feature Flags via config mechanism from .env or /api/config
To use, example in app.tsx
      <Feature flag="useIQEngineOutReach">
        <h2 className="text-center py-2">
          Sign up for a once-a-month email update on IQEngine, such as new features, demos, and more!
        </h2>
      </Feature>

Setup useIQEngineOutReachin your .env as:
VITE_FEATURE_FLAGS = {"useIQEngineOutReach":true}
All Submissions:

[ x ] Have you followed the guidelines in our Contributing document?
[ x ] Have you successfully ran tests with your changes locally? Including container validation.
[ x ] Have you lint your code locally prior to submission?
[ x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ x ] Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

Changes to Core Features:

[ x ] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?

LGTM

Mind sticking that usage example in the root README, e.g. under Misc Tips, and then also have that .env part of example.env


Compile time of Event.swift#serialized & Stacktrace.swift#serialized is high

Now that I've updated to Swift 3.0 I thought I'd go through and find some of the culprits of long compile times.  It seems Sentry is the top two offenders.  They are both serialized methods.
I only wanted to bring it up in case there is some re-jiggering of the code that could be done simply to help.
7093.0ms       Pods/SentrySwift/Sources/Event.swift:145:42 @objc dynamic get {}
1070.7ms       Pods/SentrySwift/Sources/Stacktrace.swift:114:42    @objc dynamic get {}

@gabek Thanks for the letting me know 😊  I will definitely do some re-jiggering of those

I was able to improve the compile time quiet a bit ...
44.0ms       Sources/Event.swift:153:42 @objc dynamic get {}
73.0ms       Sources/Stacktrace.swift:15:23    @objc dynamic get {}

Will be added to 1.0 release, closing this ...