x/tools: rewrite git history to remove accidental merge commit

Over the holidays, I accidentally merged https://github.com/golang/tools/commit/2152f4ed8ce7d719d99bd3cbd815026c3e83646b and then tried to revert it with https://github.com/golang/tools/commit/63754364767c38e3e7b8aa74d2e3b2342e49ee76. This caused the gopls pseudoversions to start with v0.6.2 rather than v0.0.0 as before. We need to rewrite the Git history to remove these commits and restore the original pseudoversions.

/cc @golang/release

/cc @golang/release

We needed to rewrite the history of x/tools master branch so that the gopls/v0.6.1 tag would no longer be an ancestor (this is what was causing the pseudo-versions to start with v0.6.2-0.).
This is now done. The previous master commit golang/tools@e2f9c7f1fc8e3456c71ab5b45a8220d3ae8e0aef was replaced with commit golang/tools@1b1bb6453dc0267d1dc98ba64df16771c61f7f0c, which prunes the merge CL and its revert but keeping the tree content unmodified.
Here's the complete log of how the rewrite was generated, for posterity:
$ cd $(mktemp -d)
$ git clone https://go.googlesource.com/tools && cd tools
Cloning into 'tools'...
[...]
tools $ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.
tools $ git rev-parse HEAD
e2f9c7f1fc8e3456c71ab5b45a8220d3ae8e0aef
tools $ git merge-base --is-ancestor gopls/v0.6.1 HEAD && echo "problem" || echo "ok"
problem
tools $ git checkout -b rewrite-master master
Switched to a new branch 'rewrite-master'
tools $ git diff master

# Rebase (interactively) on top of the latest commit on master
# branch before the merge CL.
tools $ git rebase -i 4a19ffb6e6422ea8855acc6b07cac1c44aa814e7

    (use this rebase script)

    # Rebase 4a19ffb6..e2f9c7f1 onto 4a19ffb6 (27 commands)
    #
    # Commands:
    # x, exec <command> = run command (the rest of the line) using shell
    # ...
    #
    # These lines can be re-ordered; they are executed from top to bottom.
    #
    # If you remove a line here THAT COMMIT WILL BE LOST.

    # Drop the merge of gopls-release-branch.0.6 and its commits.
    #pick 72fbef54 internal/lsp/debug: update version number for v0.6.0
    #pick 2037813f gopls: update go.mod for v0.6.0-pre.1
    #pick c88dec5c [gopls-release-branch.0.6] internal/lsp: add titles to `go mod tidy` and update go.sum fixes
    #pick 1eed4871 gopls: update go.mod for gopls/v0.6.1-pre.1

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' ee6d6aff)" git cherry-pick ee6d6aff # internal/lsp: restructure user options (CL 278433 continued)
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 0af0626a)" git cherry-pick 0af0626a # internal/lsp: save all possible keys for analyses, codelenses

    # Drop the revert.
    #pick 63754364 Revert "[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6"

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 2dba1e4e)" git cherry-pick 2dba1e4e # go/analysis/passes/fieldalignment: add command
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 773b96fa)" git cherry-pick 773b96fa # internal/lsp: avoid panic during interface assertion
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' d8d6ddbe)" git cherry-pick d8d6ddbe # cmd/goyacc: double ACTSIZE, NSTATE and TEMPSTATE
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' b0ab187a)" git cherry-pick b0ab187a # gopls/internal/regtest: support multiple workspace folders
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 5e19fbb8)" git cherry-pick 5e19fbb8 # gopls: bump gofumpt to v0.1.0
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 79627818)" git cherry-pick 79627818 # gopls/doc: add additional information on CI in contributing.md
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a548c3f4)" git cherry-pick a548c3f4 # gopls: update link to nvim-lspconfig gopls configuration
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' c658f992)" git cherry-pick c658f992 # internal/lsp/source: return all field funcs from outgoing callhierarchy
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 9ed45478)" git cherry-pick 9ed45478 # go/packages: remove -mod, -modfile flags from build flags for go version
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 465c416c)" git cherry-pick 465c416c # all: add copyright notices to files that are missing them
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' f9b4b89a)" git cherry-pick f9b4b89a # gopls/internal/regtest: skip regtests on android-amd64-emu

    # This CL is being dropped because it's no longer needed:
    # The change it makes is already in tree. It was fixing up
    # a change that the merge introduced, which is backed out.
    #pick 63752411 internal/lsp/debug: change hardcoded version to a constant

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 113979e3)" git cherry-pick 113979e3 # internal/lsp/cache: fix module paths in nested module error messages
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a85a8cee)" git cherry-pick a85a8cee # internal/lsp/cache: fix panic in GOPATH mode
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 4ed967dd)" git cherry-pick 4ed967dd # Revert "go/analysis/passes/structtag: recognize multiple keys per tag"
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a008e46a)" git cherry-pick a008e46a # gopls: use standard command doc comment format
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 551e49d8)" git cherry-pick 551e49d8 # gopls/internal/regtest: fix TestUnimportedCompletions
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 7339b064)" git cherry-pick 7339b064 # gopls/internal/hooks: create included licenses text
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' e9a2c070)" git cherry-pick e9a2c070 # internal/lsp/cmd: add licenses command
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' e2f9c7f1)" git cherry-pick e2f9c7f1 # gopls/doc/emacs.md: describe configuration for eglot

Successfully rebased and updated refs/heads/rewrite-master.
tools $ git merge-base --is-ancestor gopls/v0.6.1 HEAD && echo "problem" || echo "ok"
ok
tools $ git diff master
tools $

Notably:

the unwanted gopls/v0.6.1 tag is no longer an ancestor of master branch
committer dates were preserved (since pseudo-versions use those)
the result is an identical tree as the original x/tools master

This issue is resolved now, and doing go get of the latest master commit (directly to VCS, bypassing module mirror for testing purposes) gives a v0.0.0 pseudo-version:
$ GO111MODULE=on GOPROXY=direct GOSUMDB=off go list -m -json golang.org/x/tools/gopls@master
{
	"Path": "golang.org/x/tools/gopls",
	"Version": "v0.0.0-20210108195828-1b1bb6453dc0",
	"Time": "2021-01-08T19:58:28Z"
}

In order to keep the previously published x/tools pseudo-versions valid, we created a new branch internal-branch.issue43628 that points to the previous x/tools master commit.
This works too:
$ GO111MODULE=on GOPROXY=direct GOSUMDB=off go list -m -json<EMAIL_ADDRESS>{
	"Path": "golang.org/x/tools",
	"Version": "v0.0.0-20210108195828-e2f9c7f1fc8e",
	"Time": "2021-01-08T19:58:28Z"
}

I'll send a mail to golang-dev@ to notify anyone working on x/tools that a rewritten history is expected. No CLs were dropped during the rewrite and force push, so nothing needs to be re-sent. Closing.

We needed to rewrite the history of x/tools master branch so that the gopls/v0.6.1 tag would no longer be an ancestor (this is what was causing the pseudo-versions to start with v0.6.2-0.).
This is now done. The previous master commit golang/tools@e2f9c7f1fc8e3456c71ab5b45a8220d3ae8e0aef was replaced with commit golang/tools@1b1bb6453dc0267d1dc98ba64df16771c61f7f0c, which prunes the merge CL and its revert but keeping the tree content unmodified.
Here's the complete log of how the rewrite was generated, for posterity:
$ cd $(mktemp -d)
$ git clone https://go.googlesource.com/tools && cd tools
Cloning into 'tools'...
[...]
tools $ git checkout master
Already on 'master'
Your branch is up to date with 'origin/master'.
tools $ git rev-parse HEAD
e2f9c7f1fc8e3456c71ab5b45a8220d3ae8e0aef
tools $ git merge-base --is-ancestor gopls/v0.6.1 HEAD && echo "problem" || echo "ok"
problem
tools $ git checkout -b rewrite-master master
Switched to a new branch 'rewrite-master'
tools $ git diff master

# Rebase (interactively) on top of the latest commit on master
# branch before the merge CL.
tools $ git rebase -i 4a19ffb6e6422ea8855acc6b07cac1c44aa814e7

    (use this rebase script)

    # Rebase 4a19ffb6..e2f9c7f1 onto 4a19ffb6 (27 commands)
    #
    # Commands:
    # x, exec <command> = run command (the rest of the line) using shell
    # ...
    #
    # These lines can be re-ordered; they are executed from top to bottom.
    #
    # If you remove a line here THAT COMMIT WILL BE LOST.

    # Drop the merge of gopls-release-branch.0.6 and its commits.
    #pick 72fbef54 internal/lsp/debug: update version number for v0.6.0
    #pick 2037813f gopls: update go.mod for v0.6.0-pre.1
    #pick c88dec5c [gopls-release-branch.0.6] internal/lsp: add titles to `go mod tidy` and update go.sum fixes
    #pick 1eed4871 gopls: update go.mod for gopls/v0.6.1-pre.1

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' ee6d6aff)" git cherry-pick ee6d6aff # internal/lsp: restructure user options (CL 278433 continued)
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 0af0626a)" git cherry-pick 0af0626a # internal/lsp: save all possible keys for analyses, codelenses

    # Drop the revert.
    #pick 63754364 Revert "[gopls-release-branch.0.6] all: merge master into gopls-release-branch.0.6"

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 2dba1e4e)" git cherry-pick 2dba1e4e # go/analysis/passes/fieldalignment: add command
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 773b96fa)" git cherry-pick 773b96fa # internal/lsp: avoid panic during interface assertion
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' d8d6ddbe)" git cherry-pick d8d6ddbe # cmd/goyacc: double ACTSIZE, NSTATE and TEMPSTATE
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' b0ab187a)" git cherry-pick b0ab187a # gopls/internal/regtest: support multiple workspace folders
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 5e19fbb8)" git cherry-pick 5e19fbb8 # gopls: bump gofumpt to v0.1.0
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 79627818)" git cherry-pick 79627818 # gopls/doc: add additional information on CI in contributing.md
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a548c3f4)" git cherry-pick a548c3f4 # gopls: update link to nvim-lspconfig gopls configuration
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' c658f992)" git cherry-pick c658f992 # internal/lsp/source: return all field funcs from outgoing callhierarchy
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 9ed45478)" git cherry-pick 9ed45478 # go/packages: remove -mod, -modfile flags from build flags for go version
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 465c416c)" git cherry-pick 465c416c # all: add copyright notices to files that are missing them
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' f9b4b89a)" git cherry-pick f9b4b89a # gopls/internal/regtest: skip regtests on android-amd64-emu

    # This CL is being dropped because it's no longer needed:
    # The change it makes is already in tree. It was fixing up
    # a change that the merge introduced, which is backed out.
    #pick 63752411 internal/lsp/debug: change hardcoded version to a constant

    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 113979e3)" git cherry-pick 113979e3 # internal/lsp/cache: fix module paths in nested module error messages
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a85a8cee)" git cherry-pick a85a8cee # internal/lsp/cache: fix panic in GOPATH mode
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 4ed967dd)" git cherry-pick 4ed967dd # Revert "go/analysis/passes/structtag: recognize multiple keys per tag"
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' a008e46a)" git cherry-pick a008e46a # gopls: use standard command doc comment format
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 551e49d8)" git cherry-pick 551e49d8 # gopls/internal/regtest: fix TestUnimportedCompletions
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' 7339b064)" git cherry-pick 7339b064 # gopls/internal/hooks: create included licenses text
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' e9a2c070)" git cherry-pick e9a2c070 # internal/lsp/cmd: add licenses command
    x GIT_COMMITTER_DATE="$(git show -s --pretty='%cd' e2f9c7f1)" git cherry-pick e2f9c7f1 # gopls/doc/emacs.md: describe configuration for eglot

Successfully rebased and updated refs/heads/rewrite-master.
tools $ git merge-base --is-ancestor gopls/v0.6.1 HEAD && echo "problem" || echo "ok"
ok
tools $ git diff master
tools $

Notably:

the unwanted gopls/v0.6.1 tag is no longer an ancestor of master branch
committer dates were preserved (since pseudo-versions use those)
the result is an identical tree as the original x/tools master

This issue is resolved now, and doing go get of the latest master commit (directly to VCS, bypassing module mirror for testing purposes) gives a v0.0.0 pseudo-version:
$ GO111MODULE=on GOPROXY=direct GOSUMDB=off go list -m -json golang.org/x/tools/gopls@master
{
	"Path": "golang.org/x/tools/gopls",
	"Version": "v0.0.0-20210108195828-1b1bb6453dc0",
	"Time": "2021-01-08T19:58:28Z"
}

In order to keep the previously published x/tools pseudo-versions valid, we created a new branch internal-branch.issue43628 that points to the previous x/tools master commit.
This works too:
$ GO111MODULE=on GOPROXY=direct GOSUMDB=off go list -m -json<EMAIL_ADDRESS>{
	"Path": "golang.org/x/tools",
	"Version": "v0.0.0-20210108195828-e2f9c7f1fc8e",
	"Time": "2021-01-08T19:58:28Z"
}

I'll send a mail to golang-dev@ to notify anyone working on x/tools that a rewritten history is expected. No CLs were dropped during the rewrite and force push, so nothing needs to be re-sent. Closing.

One more for #26201.

One more for #26201.


Bug crash report windows

case/598493 - User sent this in with
"This is a crash report taken from windows 10 event viewer. An
ArgumentOutOfRangeException,
that given the stack trace would surely help the developers to pinpoint
where in the code that happened"

Must've been fixed in scope of #2959 or #2872.


'one-time completion handler' for async image display inside a tableviewcell

I need to display an image inside a tableViewCell asynchronously, so I need to call self.tableView.reloadData() when the download is complete (because the image height is varying and the tableView height needs to be updated) and I did it inside the completion handler in kf.setimage but this create problem because the completion handler is called continuously inside tableView:cellForRowAtIndexPath: and make my project crash. Can you make an option to call the completion handler only once?

What's the problem by just using the image view extension described here? There should be no need to reload your table view.

I used that, but my project have a dynamic cell height so the cell height is dependent on the size of the image. And since I load the image asynchronously I need to call tableView.reloadData() in the completion handler. I eventually get around this issue by creating an array of bool to check if I should reload the table view for a specific cell. What would be nice is if there is an option to call the completion handler only once.

No, it is not the correct logic to call the handler only once when you set it multiple times actually.
It's more likely that you are choosing a not-so-good strategy by reloading the whole table view and set the image again. I'll choose just relayout/update the cell without reseting the cell image view by Kingfisher. Maybe it's also worth to reconsider your table view setting flow and choose a better way to update the cell.


Custom Valid Annotation/Ignore BeanParam field

So I find myself writing my own custom validators rather than using hibernate, would like this so I can exclude any Jakarta annotation dependency.
Also adds an @IgnoreBeanField annotation. (have a case where I use the bean param object constructors to initialize other useful fields that are not expected parameters)

gonna split the bean ignore into it's own thing


Hyperdeck video format not working for DNx220 MXF

Using ShuttleHD with Companion emulator:
Setting a button to action hyperdeck: File format - works for all the flavours other than DNx220, (possibly because it needs an x?)
These are the flavours that work via telnet

QuickTimeDNxHD220x QuickTimeDNxHD145 QuickTimeDNxHD45
DNxHD220x DNxHD145  DNxHD45

Not sure if this is the offending code (sorry very limited skills)

index.js:
87  			{ id: 'QuickTimeProResProxy', label: 'QuickTime ProRes Proxy', family: 'proxy' },
88: 			{ id: 'QuickTimeDNxHD45', label: 'DNxHD 45 QT', family: 'DNx' },
89: 			{ id: 'DNxHD45', label: 'DNxHD 45 MXF', family: 'DNx' },
90: 			{ id: 'QuickTimeDNxHD145', label: 'DNxHD 145 QT', family: 'DNx' },
91: 			{ id: 'DNxHD145', label: 'DNxHD 145 MXF', family: 'DNx' },
92: 			{ id: 'QuickTimeDNxHD220', label: 'DNxHD 220 QT', family: 'DNxHD220' },
93: 			{ id: 'DNxHD220', label: 'MXF DNxHD 220', family: 'DNxHD220' },
94  			{ id: 'QuickTimeDNxHR_HQX', label: 'DNxHR HQX QT', family: 'DNxHR_HQX' },

and a possible solution:

index.js:
87  			{ id: 'QuickTimeProResProxy', label: 'QuickTime ProRes Proxy', family: 'proxy' },
88: 			{ id: 'QuickTimeDNxHD45', label: 'DNxHD 45 QT', family: 'DNx' },
89: 			{ id: 'DNxHD45', label: 'DNxHD 45 MXF', family: 'DNx' },
90: 			{ id: 'QuickTimeDNxHD145', label: 'DNxHD 145 QT', family: 'DNx' },
91: 			{ id: 'DNxHD145', label: 'DNxHD 145 MXF', family: 'DNx' },
92: 			{ id: 'QuickTimeDNxHD220x', label: 'DNxHD 220x QT', family: 'DNxHD220x' },
93: 			{ id: 'DNxHD220x', label: 'DNxHD 220x MXF', family: 'DNxHD220x' },
94  			{ id: 'QuickTimeDNxHR_HQX', label: 'DNxHR HQX QT', family: 'DNxHR_HQX' },

Apologies for any faux pas I've committed...

Not sure there is an issue here.
As I have no experience with DNx please review following test results on HyperDeck Studio HD Plus.
configuration: file format: DNxHD220x
200 ok
configuration
211 configuration:
(…)
file format: DNxHR_HQX
configuration: file format: DNxHR_HQX
200 ok
configuration
211 configuration:
(…)
file format: DNxHR_HQX
In summary:

DNxHD220x returns DNxHR_HQX
DNxHR145 returns DNxHR-SQSQ MXF
DNxHD45 returns DNxHR_LB
In Companion action "hyperdeck: File format" uses for example "DNxHR LB MXF" and variable $(hyperdeck:fileFormat) is set accordingly (and tcp shows DNxHR_HQX, DNxHR-SQSQ MXF, and DNxHR_LB ).

Nico Wasmus

This appears to be a case of old models support DNxHD220, the shuttle supports DNxHD220x and the newer hd range claims to support DNxHD220x, but it is actually an alias for DNxHR_HQX.
Blackmagic do like to make these things complicated, especially as there is no way to query a particular device to find out what it supports...
Of course, this is assuming that the documentation pdf is correct and that isnt a typo

This should be fixed in the next beta build.

This works fine for me on HyperDeck Studio HD Plus. Thanks!
Op vr 6 okt 2023 om 21:10 schreef Julian Waller @.***>:

This should be fixed in the next beta build.
—
Reply to this email directly, view it on GitHub
https://github.com/bitfocus/companion-module-bmd-hyperdeck/issues/91#issuecomment-1751288979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A25NECGAWTR72TYYR73EVWDX6BJRTAVCNFSM6AAAAAAXK3R666VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGI4DQOJXHE
.
You are receiving this because you commented.Message ID:
@.***>


ssvm: continue with other secondary storages if fails to program a secondary storage

Description
This PR fixes #7244

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-6204)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54482 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7264-t6204-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_upgrade_kubernetes_cluster
Error
3944.27
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Error
4034.89
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
113.39
test_kubernetes_clusters.py

Code looks good to me, but I did not test.

@weizhouapache I've changed base branch to 4.18. Please change if it shouldn't be
@blueorangutan package

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5900

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-6417)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42287 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7264-t6417-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

is this good to merge or we need any testing @weizhouapache @DaanHoogland ?

@weizhouapache , I like the code but see no funcrtional change. Also, the issue #7244 is closed. I am fine with merging, but please advise.


Add concealment highlighting

Just added concealment highlighting using the same template as for hl-Normal highlighting. It removes the grey background for LaTeX concealment as in math equations:

I am not a vimtex user but loading a vanilla vimtex did not break the highlighting.

Superseded by #261


[WIP] Mirror changes needed to reuse code for apt-resource usage.

This is a work in progress pull request to discuss the changes I need to implement an apt resource type for Concourse.
After some understanding of the code base and a number of trial attempts, I guess I'm on the right track. I'm converting the code base to a more pipeline oriented approach using channels and goroutines.
The introduction of the strategy allows me to use a Complete update for go-apt-mirror and a custom implementation for my own work. In this custom implementation, I will only download the release files and indexes, ending with a channel containing the FileInfo structs of all packages in the release. Continuing on that, I can filter the results to the package I want to monitor for new releases.

@ymmt2005 I now bump into a limitation of your code: FileInfo only offers details of files. But I need more extensive package info like package name and package version. All files are processed alike and only return a collection of FileInfo objects.
Can I split the file handling and let the processing push the results on different channels?

Closing. It was too hard to reuse this code base for my purpose. I was able to implement it based on the smira/aptly codebase.

I see.  Anyway, thank you for once using our code base.


Add random Offer image on non-production environments

Description:
Adds random Offer image to the offers returned from OfferService if there is none image assinged and the environment is non-production. It makes the homepage outlook easier on the eyes. The images are being served from remote public placeholder image service.
New imports / dependencies:
N/A
Unit Tests:
N/A
What tests do I need to run to validate this change:
Look at the home page of Angular app. Images will load after a while :)

It should look something like this on your local machines:

@CorneeSean, nicely done! I was as well thinking of something like that on dev instances. ;-)

Codecov Report

Merging #855 into master will increase coverage by <.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage    91.2%   91.21%   +<.01%
==========================================
  Files         103      103
  Lines        2911     2913       +2
  Branches       11       12       +1
==========================================
+ Hits         2655     2657       +2
  Misses        255      255
  Partials        1        1

Impacted Files
Coverage Δ

frontend/src/environments/environment.ts
100% <ø> (ø)
:arrow_up:

frontend/src/app/homepage-offer/offers.service.ts
46.15% <27.27%> (+4.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee5734...323fad1. Read the comment docs.

In general, we need this feature, as long as a picture isn't required by adding a new offer. However, from a user perspective, when I click on a picture and then I'm redirected to an offer with other picture, I'm a little bit confused, whether I'm on the right site or not.

I generally agree with @juliaanholcer as this feel akward to see different images on homepage and on offer details page.
I understand, that this randomOfferImages variable is for testing purposes - what do You think about storing all such variables in testingEnv property of environment, that way we will have all such variables in one place?
Something like:
export const environment = {
  apiRoot: 'https://rc.volontulo.pl/api',
  djangoRoot: 'https://rc.volontulo.pl/o',
  production: true,
  sentryDSN<EMAIL_ADDRESS>  googleAnalyticsAppID: 'UA-114117196-2',
  testingEnv: {
    randomOfferImages: false,
  },
};

Second thought is to choose images per offer during creation stage, somewhere here: https://github.com/CodeForPoznan/volontulo/blob/master/backend/apps/volontulo/management/commands/populate_database.py or inside factories.py - I will try to do such thing and maybe it will be a better idea.

@magul good idea about testingEnv object, though I guess the whole pull request is rendered obsolete now by your PR. Nevertheless, it is a good idea for future usage to bear in mind.


Add GameRanger

If it auto_updates, then there has to be an appcast. Mind contacting the developer about it? Something like (feel free to use this verbatim):
Hello,
I’m currently adding your app details to homebrew-cask (a popular command-line tool to facilitate the installations of GUI apps), and if I can also add the appcast (the URL your app uses to check for updates) to it, the homebrew-cask developers will be able to better keep the details of your app (namely the current version at any given point) up to date more easily, which means users will be sure to get the latest version of your app when installing it in this manner.
Could you then please provide me with the appcast URL your app uses?
If you have further questions, please feel free to ask about it on the repo (https://github.com/caskroom/homebrew-cask) and the team will answer any doubts you might be having.
Thank you for your time. Have a nice day.

I'm vaguely familiar with GameRanger - it downloads pieces (plugins) per app, and doesn't have an appcast per se.
That being said, technically http://www.gameranger.com/games/mac/ can be used as an appcast, if one is needed for auto_updates

I'm vaguely familiar with GameRanger - it downloads pieces (plugins) per app, and doesn't have an appcast per se.

That’s fine, then. But then auto_updates isn’t really applicable, is it? auto_updates should consider the core of the app (i.e. what homebrew-cask actually gets). If the app itself then gets plugins, that’s out of our jurisdiction.

That being said, technically http://www.gameranger.com/games/mac/ can be used as an appcast, if one is needed for auto_updates

It isn’t strictly necessary (the code still works), but it’d be nice. Better not use that page though (remember the other HTML pages we tried).

I just misunderstood the idea of auto_updates. The application updates itself and requires a constant Internet connection. There is no appcast or like. I don't think the developer even provides up-to-date initial installs. I'll remove the stanza.

Thank you for the contribution. It needed some fixes, so they were made in 332125a2193320b3324d0d9b9cc7e12907001378. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Granting access to SQL for Management point connection account

Management point connection account must be added to SQL manually with smsdbrole_MP scheme.
For some reason, it's not handled by site server at least when modifying already installed MP properties

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22f80cf3-6f36-cb44-d0e5-d186164d6281
Version Independent ID: ada8a281-7d9f-e82e-e4e8-056b93e8b36d
Content: Accounts used - Configuration Manager
Content Source: sccm/core/plan-design/hierarchy/accounts.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @Yupiter2005 for the feedback. I'm checking with the engineering team. I wonder if this is a doc bug or a possible product bug.

I haven't been able to find anyone to definitely respond to this. It doesn't seem like proper behavior, so if you haven't already, please file a frown in the console, or open a support case.


Drag&Drop nodes from scene tree dock into script editor

This would be a huge time saver if implemented right.
Admit it, the most annoying part is to find nodes by their names from script, especially when scene tree is huge, and when you're moving around nodes and constantly changing layout. Current solution is node groups that are hard to keep track of, but I think there is a better way.
I'm suggesting the ability to drag and drop nodes into script  (or right click inside script editor) , but it can be split into three main problems:

basically inserting get_node("") statement into the code and filling in node path automatically.
making scripteditorplugin change all of them whenever a node is being moved or removed.
for convenience get_node("") statement that is recognized can be replaced with a button (inside of script editor of course), inside of which are node icon and node name. Pressing on it would select that particular node.

I would implement this feature myself but still figuring out how drag&drop was implemented across the editor.

i tried but it's no use, because clicking a node will bring up the right
editor. Just leave this open and will try to find an alternative way to do
it
On Fri, Jun 10, 2016 at 3:46 PM, TheoXD<EMAIL_ADDRESS>wrote:

This would be a huge time saver if implemented right.
Admit it, the most annoying part is to find nodes by their names from
script, especially when scene tree is huge, and when you're moving around
nodes and constantly changing layout. Current solution is node groups that
are hard to keep track of, but I think there is a better way.
I'm suggesting the ability to drag and drop nodes into script, but it can
be split into three main problems:

basically inserting get_node("") statement into the code and filling
in node path automatically.
making scripteditorplugin change all of them whenever a node is
being moved or removed.
for convenience get_node("") statement that is recognized can be
replaced with a button (inside of script editor of course), inside of which
are node icon and node name. Pressing on it would select that particular
node. I would implement this feature myself but still figuring out how
drag&drop was implemented across the editor.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5145, or mute the thread
https://github.com/notifications/unsubscribe/AF-Z28meRSpChhgOrSYCuufqry6pR6Niks5qKbERgaJpZM4IzOAL
.

@reduz, I'm ok if 3rd feature can't be implemented yet, still would be great if script editor kept track of all the get_node() statements and updated them when scene tree changes.

I think that dnd is not only option.
what about add get_node("node/path") at current cursor when ctrl>+click if script editor is opened?
dnd is sometimes hard when especially editing text.

@volzhs, well anything is faster than typing, I was thinking more of right-click above the script editor cursor if d&d can't be done, like "Insert selected node path".

@TheoXD both ctrl+click on scene tree and right click on node(contextual menu) would be cool I think.

A "Copy node path" function in the contextual menu would be good too.

I gave it a shot today https://www.youtube.com/watch?v=L7fCntZ9MqY&feature=youtu.be  Now I'm trying to make it work the same way autocompletion does, basically evaluating scripts in order to make commands such as get_parent().get_node() to work.

@TheoXD my main concern about this is how it would behave if the nodes are changed while the script is not opened? And what if the same script is added to multiple scenes? You are doing a great work but just keep those caveats in mind.

@vnen, for as long as script is used by any node in the tree - it will be detected. If not opened it will force-open.

I suggest the following:

Check if the scene has a dominant script (instanced scenes may have
scripts but you will not really want to work with those in most cases)
If so, when opening the context menu, you could show a "Copy path to
root script", you can omit showing this option if no root script
Feel free to add a keyboard shortcut for this, since we now have
customizable shortcuts, it can be empty or be something like shift+cmd+c

On Sat, Jun 11, 2016 at 12:05 PM, TheoXD<EMAIL_ADDRESS>wrote:

@vnen https://github.com/vnen, for as long as script is used by any
node in the tree - it will be detected. If not opened it will force-open.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/5145#issuecomment-225368291,
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z2_UL1K962ZMtw6b45gKzIWa3gb9kks5qKs7JgaJpZM4IzOAL
.

@reduz, sure I can add an option for dominant script workflow, so it will only care about root script and nothing else. Still need to figure out how to deal with node selection itself, since it will always bring contextual menu, I think we should change it to double click instead, doubleclicking should bring contextual node editor.

@TheoXD No, having contextual editing on click is a very handy workflow and great for discoverability, we shouldn't break something that works very well for a corner case like this. Just add it to the contextual menu with the other options, if you have to switch back to the script editor it can be a small annoyance but still much better than losing a great feature.

Alternatively, we could make it not open the contextual node editor if you right click to open the contextual node menu, though this can be a little difficult to implement, I could work on it later if an issue is made to fix it

@reduz, or once "Insert Node" (haven't yet decided on the name)  has been pressed you should be allowed to click in scene tree dock once, and it would insert on cursor position. This is probably way better and convenient.

@TheoXD I was thinking of something much simpler, just a "Copy path to script" on the node RMB menu, then you go back to script editor and paste it.
Alternatively, something that could be done rather easily is to use a shortcut while writing text to open a popup with the scene tree, where you select a node, press enter and the past is pasted to the script, no clipboard present.

Yeah I will probably go with the last one, seems convenient enough.

@TheoXD okay then, if it helps you can use this one as reference, just copy it to script_editor_plugin.cpp I guess:
https://github.com/godotengine/godot/blob/master/tools/editor/reparent_dialog.h

Really nice work!
I think the idea with a popup with the scene tree is the most convenient too. It is so much nicer if your hands can rest on the keyboard and you aren't forced to use the mouse!
I also would make the inserted code (String path) highlighted when it is  updated automatically.

Right click on the highlighted code should give you the option to disable automatic update.

It would be cool to also have another shortcut to add a node path without automatic update (strg + A, adding node path with auto update, shift + ctrl + A adding a node path without auto update)

This would make it flexble and fast to use.

ate)
I really love your work so far and think this is an awsome feature. The only disadvage I had with nodes so far is that I'm feared to change their order because I don't anymore remember if I acces them in a script. So this feature would help A LOT.
Thank you TheoXD

@reduz, I just accessed SceneTreeDialog, also reused the search/replace functionality provided by FindReplaceBar.
@toger5, It would probably be best to make this as seamless as possible for the user, so this shouldn't be necessary. If you have an instanced scene with a script attached to it - it won't change anything inside that scene script since everything is relative to the instanced node. Still want it to change paths that point outside of instanced scene, if it goes beyond it's root. But currently seems to work with anything but get_parent().get_node().get_node() chains like that.

@TheoXD okay i see that it is not really necessary. But is it still possible to give it highlighting just so that the user can that this is an automatically updating path.

A little late for this, but how about drag files from FileSystem to append a load("file/path") to script editor?

This has since been implemented.
Although it's very basic and lacks the advanced features discussed here (like updating the script when the dragged node was moved or renamed).
So we might  want to keep this issue open. (Maybe rename it?)

I'll close this issue since the core feature was implemented (dragging nodes to the script editor to insert node paths relative to the current script).

Although it's very basic and lacks the advanced features discussed here (like updating the script when the dragged node was moved or renamed).

This is tracked in #3163 :slightly_smiling_face:


Store index URLs in tool receipts

per https://github.com/astral-sh/uv/pull/5197#issuecomment-2248419637 we need the index urls to be able to upgrade the tool when alternative indexes are used.

Do you think we need anything else? Like no-binary, no-build, resolution-mode, etc.?

We probably need all of the ResolverInstallerSettings, right? :/

I think the index URL is the only thing that would affect whether or not the resolution succeeds (maybe no-binary and no-build in weird cases, like a package has a broken wheel or something that you want to avoid). So arguably it's in a slightly different class...

We store a subset of these in the lockfile now if and only if they differ from the defaults. Ideally we would consider this holistically with the lockfile.

The other problem with storing index URLs is that they could contain credentials, right?

Strong agree around consistency with the lockfile, which I think includes the credential problem.

Although for tool receipts, it's "okay" if we store credentials that the user handed us since it's not checked into version control.

I'll look into this today.

Done.


Allow specifying supervisor_user and supervisor_group

@jtimberman @cwjohnston @slyness for review
According to the official runit docs the accepted way of allowing a non-root user to control a runit service is to:

Change permissions of the supervise directory to 0755 so that all users may see the contents
Change the ownership / group of the 'ok, status, control' files to the desired group / user

I've added support for this via the 'supervisor_owner' and 'supervisor_group' attributes. I've also added unit tests for all cases I could think of to ensure it works as expected
A tangible use case (that affects me) is that we often want the user initiating a deploy (for example via capistrano) to be able to restart services. Rather than having to whitelist every possible service (we have lots), it makes sense to allow that user / group to just always have the privilege to manage the services.

LGTM

After testing in production, it turns out that the create action refuses to deal with pipes (https://github.com/chef/chef/blob/master/lib/chef/provider/file.rb#L246-L251), but 'touch' works fine for updating the owner/group.
I've revised the patch accordingly, and can confirm this is working in production.

@dalehamel @dwradcliffe Thank you for this excellent pull request! I really appreciate the documentation and tests that you've thoughtfully added.
Unfortunately I'm having trouble running the test-kitchen service suite from this branch. Seems like we are missing run and log templates for the new services added in test/cookbooks/runit_test/recipes/service.rb:
[2016-04-27T18:43:30+00:00] ERROR: runit_service[supervisor_owner] (runit_test::service line 227) had an error: Chef::Exceptions::FileNotFound: template[/etc/sv/supervisor_owner/run] (/tmp/kitchen/cache/cookbooks/runit/libraries/provider_runit_service.rb line 82) had an error: Chef::Exceptions::FileNotFound: Cookbook 'runit_test' (1.0.1) does not contain a file at any of these locations:

Perhaps you have some uncommitted files locally? Otherwise feel free to copy from the existing run and log templates. The majority of the run templates in the runit_test cookbook are set up for executing socat to listen on a unique port.

Sorry I missed those, I'll look into this shortly
On Wednesday, 27 April 2016, Cameron Johnston<EMAIL_ADDRESS>wrote:

@dalehamel https://github.com/dalehamel @dwradcliffe
https://github.com/dwradcliffe Thank you for this excellent pull
request! I really appreciate the documentation and tests that you've
thoughtfully added.
Unfortunately I'm having trouble running the test-kitchen service suite
from this branch. Seems like we are missing run and log templates for the
new services added in test/cookbooks/runit_test/recipes/service.rb:
[2016-04-27T18:43:30+00:00] ERROR: runit_service[supervisor_owner] (runit_test::service line 227) had an error: Chef::Exceptions::FileNotFound: template[/etc/sv/supervisor_owner/run] (/tmp/kitchen/cache/cookbooks/runit/libraries/provider_runit_service.rb line 82) had an error: Chef::Exceptions::FileNotFound: Cookbook 'runit_test' (1.0.1) does not contain a file at any of these locations:
Perhaps you have some uncommitted files locally? Otherwise feel free to
copy from the existing run and log templates. The majority of the run
templates in the runit_test cookbook are set up for executing socat to
listen on a unique port.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/hw-cookbooks/runit/pull/187#issuecomment-215190252

@cwjohnston should be good to go now, I don't use test kitchen though so I can't confirm.
On a side note, any chance we can set up travis or something to catch this sort of stuff in CI?

Thanks, I'll take another look at it.

On a side note, any chance we can set up travis or something to catch this sort of stuff in CI?

I am working on this presently. 👍

@dalehamel As you've indicated that you don't run test-kitchen, will you please apply this patch and update the PR with the result? At that point I think all tests will pass and I can avoid creating an additional PR to include the fix.
Thanks!

@cwjohnston patch has been applied and pushed!

👏 @cwjohnston awesome, how does the release cycle work? When can I expect to be able to move to 1.7.8?

@dalehamel 1.7.8 is now available via the supermarket. thanks!


External provisioner is provisioning volume for claim "default/abcd"   Warning  ProvisioningFailed    20s (x8 over 2m27s)  rbd.csi.ceph.com_csi-rbdplugin-provisioner-64598bf8f9-gbsls_efc5a55a-679e-4544-9323-7aa182540118  failed to provision volume with StorageClass "new-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists

1, using ceph-csi driver, tag is v3.4.0, found this error all the time
failed to provision volume with StorageClass "new-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
2，ceph cluster is ok
cluster:
id:     43e426d7-c323-48ad-80c7-24c2bdf2f848
health: HEALTH_OK
services:
mon: 3 daemons, quorum master01,master02,work01 (age 14h)
mgr: work01(active, since 14h), standbys: master02
mds: cephfs-demo:1 {0=master01=up:active} 1 up:standby
osd: 3 osds: 3 up (since 23m), 3 in (since 23m)
rgw: 1 daemon active (work02)
task status:
data:
pools:   11 pools, 608 pgs
objects: 409 objects, 107 MiB
usage:   3.4 GiB used, 27 GiB / 30 GiB avail
pgs:     608 active+clean
log:
csi-provisioner:
[{"AccessType":{"Mount":{"fs_type":"ext4","mount_flags":["discard"]}},"access_mode":{"mode":1}}]}
I1026 03:27:15.114673       1 connection.go:185] GRPC response: {}
I1026 03:27:15.114745       1 connection.go:186] GRPC error: rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
I1026 03:27:15.114834       1 controller.go:753] CreateVolume failed, supports topology = false, node selected false => may reschedule = false => state = Background: rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
I1026 03:27:15.114939       1 controller.go:1106] Temporary error received, adding PVC 1973d586-f6ce-43fc-aed9-4812c0f1443a to claims in progress
W1026 03:27:15.114967       1 controller.go:958] Retrying syncing claim "1973d586-f6ce-43fc-aed9-4812c0f1443a", failure 9
E1026 03:27:15.115007       1 controller.go:981] error syncing claim "1973d586-f6ce-43fc-aed9-4812c0f1443a": failed to provision volume with StorageClass "new-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
I1026 03:27:15.115054       1 event.go:282] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"default", Name:"abcd", UID:"1973d586-f6ce-43fc-aed9-4812c0f1443a", APIVersion:"v1", ResourceVersion:"20349376", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provision volume with StorageClass "new-sc": rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
I1026 03:27:19.337730       1 leaderelection.go:273] successfully renewed lease ceph-csi/rbd-csi-ceph-com
csi-rbdplugin:
I1026 03:27:15.113064       1 utils.go:176] ID: 33 Req-ID: pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a GRPC call: /csi.v1.Controller/CreateVolume
I1026 03:27:15.113421       1 utils.go:180] ID: 33 Req-ID: pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a","parameters":{"clusterID":"43e426d7-c323-48ad-80c7-24c2bdf2f848","csi.storage.k8s.io/pv/name":"pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a","csi.storage.k8s.io/pvc/name":"abcd","csi.storage.k8s.io/pvc/namespace":"default","imageFeatures":"layering","pool":"ocp"},"secrets":"stripped","volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4","mount_flags":["discard"]}},"access_mode":{"mode":1}}]}
I1026 03:27:15.114308       1 rbd_util.go:1109] ID: 33 Req-ID: pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a setting disableInUseChecks: false image features: [layering] mounter: rbd
E1026 03:27:15.114338       1 controllerserver.go:288] ID: 33 Req-ID: pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
E1026 03:27:15.114378       1 utils.go:185] ID: 33 Req-ID: pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a GRPC error: rpc error: code = Aborted desc = an operation with the given Volume ID pvc-1973d586-f6ce-43fc-aed9-4812c0f1443a already exists
I1026 03:27:33.250951       1 utils.go:176] ID: 34 GRPC call: /csi.v1.Identity/Probe

I have solved the problem, thanks.

I have the same problem. Can you describe in detail how to solve it? Thank you very much.


rust-bindgen: use a better drv name for fakeRustup

Motivation for this change
I saw a derivation called "rustup" building and was concerned why
rust-bindgen would depend on rustup.  If it had been called
"fake-rustup", I wouldn't have had to check the package source to see
what was going on. :)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Won't that change the name of the binary and defeat the point?

Result of nixpkgs-review pr 132545 at d1b639a9 run on x86_64-linux 1

1 package failed to build:

rust-bindgen

2 suggestions:

warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.
Near pkgs/build-support/rust/default.nix:141:3:
    |
141 |   configurePhase = args.configurePhase or ''
    |   ^

warning: duplicate-check-inputs
Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.
Detected duplicates:

clang-wrapper-7.1.0

Near pkgs/development/tools/rust/bindgen/default.nix:40:3:
   |
40 |   checkInputs =
   |   ^

Near pkgs/development/tools/rust/bindgen/default.nix:27:3:
   |
27 |   propagatedBuildInputs = [ clang ]; # to populate NIX_CXXSTDLIB_COMPILE
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Benjamin Saunders @.***> writes:

Won't that change the name of the binary and defeat the point?

Sorry, you're absolutely right.  I forgot how writeScriptBin works.
I've pushed a new version that sets the drv name to fake-rustup, while
keeping the executable name as rustup.  Please take another look.

@Ralith would you mind taking another look at this please?


OpenID Connect auth with external token provider

Is your feature request related to a problem? Please describe.
Our iPad devices are enrolled with Intune and we would like to use the MSAL authentication libraries to simplify auth here for our app and so are looking to use the OpenID Connect authentication option for AppSync. In here:
https://github.com/aws-amplify/amplify-ios/blob/64fcd539ecb3578220b86e8062c619035e515fbf/AmplifyPlugins/API/AWSAPICategoryPlugin/SubscriptionFactory/AWSSubscriptionConnectionFactory.swift#L59-L62
it mentions "OIDC Token Provider from somewhere else that the developer added"
This would be great if we can use the MSAL libraries as the provider for the token and implement an implementation of OIDCAuthProvider to provide this token.
So the request here is the appropriate hook points that we could implement this protocol and hook it into the configuration for the library to use
Describe the solution you'd like
Appropriate hook points so we can register an OpenID connect token provider
Describe alternatives you've considered
Looked at an AuthPlugin, but complexity is quite high it seems when most of the logic we need is external to the libraries concerns here
n.b. I'd be happy to make a PR, but some guidance on how this should work would be much appreciated

I found a section for adding a 3rd party OIDC provider here https://docs.amplify.aws/lib/graphqlapi/authz/q/platform/ios#oidc
Following the docs exactly, I hit this line with preconditionFailure
https://github.com/aws-amplify/amplify-ios/blob/64fcd539ecb3578220b86e8062c619035e515fbf/Amplify/Categories/Auth/AuthCategory.swift#L26-L28
This seems a bit odd as It's using a bunch of token and auth providers while the docs say just add an interceptor and mutate the request

Hi @damienpontifex, thanks for the details- we are investigating this and will provide an update

@lawmicha looking at Release 1.4.0 it reads that this is now possible?

@lawmicha looking at Release 1.4.0 it reads that this is now possible?
Reading the PR details - maybe this just covers the API side? Does it also cover the realtime websocket updates?

Hi @damienpontifex, yes this covers subscriptions as well! the PR https://github.com/aws-amplify/amplify-ios/pull/842 describes how to use the ODIC provider, and we'll be working on updating the documentation. Please let us know if you have any questions

@lawmicha I tried with the sample code from #842 and when configuring amplify get preconditionFailure("No plugins added to \(categoryType.displayName) category.")
My configuration is:
let apiAuthProviderFactory = MsalOidcProviderFactory()
try Amplify.add(plugin: AWSDataStorePlugin(modelRegistration: AmplifyModels()))
try Amplify.add(plugin: AWSAPIPlugin(apiAuthProviderFactory: apiAuthProviderFactory))
try Amplify.configure()

Hi @damienpontifex, what does the stack trace look like? if the auth plugin key is in your amplifyconfiguration.json then you may see that failure when you call Amplify.configure() without adding AWSCognitoAuthPlugin.

@lawmicha I tried to create a minimal reproduction but ran into so many issues setting up with amplify again I just gave up. I won't pursue this any further here and we will just live with what we've got


Start a cross platform library for controller input

This idea was suggested on IRC. The argument is that the code in SDL2 doesn't look that bad, and since controllers might need feedback it won't work as window events.

Alternative is to write an abstraction.

Another benefit with this approach is the possibility to make it work with multiple threads. This will decouple the input from the game loop and give better accuracy.

UI widgets could use the mouse/keyboard events polled from the window, while gameplay could use an independent library.

Is there an example of using gamepad input with the currently system (in a non-portable way)?

@xaviershay I've done it with sdl2_window and sdl2. I opened https://github.com/PistonDevelopers/piston-examples/issues/306

An SDL2 example: https://github.com/AngryLawyer/rust-sdl2/blob/master/examples/game_controller.rs

https://github.com/PistonDevelopers/piston/pull/978

Found this on /r/rust: http://joostdevblog.blogspot.com.br/2012/08/the-craziness-that-is-joysticks-on-pc.html

I'm possibly interested in working on this. I'm one of the authors of the W3C Gamepad API spec, and I wrote most of the Gamepad API implementation in Firefox. I've been learning Rust over the past several months and I was thinking about trying to contribute a Gamepad API implementation to Servo.
Trying to do something sensible with game controllers devolves into a giant headache, and it's different on every platform, but it's feasible.

One thing that's bothering me right now about the code in Piston is the terminology--nobody calls game controllers "Joysticks" anymore. :) When I wrote the first prototype implementation of the Gamepad API I called it the "Joystick API" (too much time spent with DirectInput years ago, I guess) and I got a ton of pushback from people telling me that was silly, everyone uses gamepads nowadays.

@luser Sure, go ahead! I opened https://github.com/PistonDevelopers/piston/issues/1047

Some people already started on this. I opened https://github.com/PistonDevelopers/piston/issues/1113 to list external projects.


Assets in public dir not served

Assets in public directory are not served when using createHtmlPlugin

This is specifically a problem with using the dev server. http://localhost:3000/favicon.ico doesn't work, but building and previewing it does.

+, this also affects not only public directory, but any other file used in project as well. I have an ng-hotrod app (angular.js+vite) but when I use this plugin I can't fetch or open any asset manually in vite serve mode, it opens the index.html of application.

Has anybody found a temporary workaround?

Had the same problem, apparently it depends on the HTTP Accept: header. When opening a path like /index.css in my browser, the browser’s request contains the header
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

and I receive the content of my /index.html.
When repeating the exact same request with cURL and omitting only the Accept: header, I receice the /index.css file.

I couldn't find a solution without creating a PR. But looking at the history of PRs I wasn't sure if the PR would be merged soon, so I found another solution.
I moved to: https://www.npmjs.com/package/vite-plugin-ejs


how to enable aria2 for Windows?

how to enable aria2c.exe for Windows? and how to download video from any website online?

Worng place to ask questions about aria2
https://aria2.github.io/

how to enable aria2c.exe for Windows? and how to download video from any website online?

Just download aria2c windows version and run it.
You should find an extension that could sniff the video URL and issue the download.


gvfs-disks2-volume-monitor and gsd-housekeeping processes can eat a lot of CPU with k3s workload

Environmental Info:
K3s Version: v1.28.4+k3s2

Node(s) CPU architecture, OS, and Version: amd64, Ubuntu 22.04.3 desktop

Cluster Configuration: standalone (everything on the same computer)

Describe the bug:
When running a workload that uses volumes (using default local-path storageClass), process gvfs-disks2-volume-monitor can take around 100% of one CPU core, and process gsd-housekeeping around 25% of one CPU core.
Even if the actual k3s workload is idle.
This is more CPU than k3s-server itself.

Steps To Reproduce:

Use or install a desktop Ubuntu 22.04.3 (with default settings)
Install K3s 1.28.4 on it (with default settings)
Deploy k8s manifests with many volumes, like https://gitlab.com/-/snippets/3634487
Check CPU consumption on the host, with top, gnome-system-monitor or anything else

Expected behavior:
Gnome desktop tools should not interfere with k3s.

Actual behavior:
Processes gvfs-disks2-volume-monitor and gsd-housekeeping consume a lot of CPU, at least at provisioning time.
Same CPU consumption if you remove the PVCs, until the PVs are deleted by k3s.
I have other k8s workloads (with data in PVs) where this CPU consumption is always there, when the workload is running.

Additional context / logs:

The symptoms are very similar to https://github.com/k3s-io/k3s/issues/522, but the workaround of comment https://github.com/k3s-io/k3s/issues/522#issuecomment-811737023 (adding a udev rule to ignore some loopback devices) does not help
Executing systemctl stop --user gvfs-udisks2-volume-monitor can be a temporary workaround

I'm not seeing how this is a defect in k3s. Have you opened an issue with Ubuntu? We could probably cover this in the docs but I don't see that there's anything we can do on our side to resolve this.

I've just opened the issue on Ubuntu side: https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/2047356

The udev configuration mentioned in https://github.com/k3s-io/k3s/issues/522#issuecomment-811737023 seemed to work a few years ago, at least for the commenter.
Did something change in the way k3s (or its sub-components) technically handles local-path volumes, that would make gvfs see them differently?
I'm hoping to find a similar workaround (that could indeed be documented), so that these volumes are ignored by gnome apps.
But, for now, I don't find them anywhere in /sys of the host.

No. The provisioner itself is a separate project, and just manages creation of core Kubernetes volumes mounted from a host path. None of this is unique to k3s.

I am going to close this, as there does not seem to be anything we can do here. Please reopen if any of the other projects involved indicate that there is something that K3s is doing incorrectly.


Cleaning up all toolchains before starting build

Now that we're trying to build the iOBC in CI, we need to clean up that toolchain, too

 Automate Kubos Linux Release for the iOBC


Example for using with the Qt library - QImage

Thank for sharing the code.
I’m using the Qt Library and QImage class. I would try to see if ImageResizer.resizeImage is better than the QImage:scaled https://doc.qt.io/qt-5/qimage.html#scaled.
I have no idea on how image format and buffers works.
I wonder if it is possible to use the library with the QImage format and if there are examples for

using an existing QImage,
creating a buffer and resizing with the ImageResizer.resizeImage
converting the result back to QImage.

Speed is not an issue.

Sorry, I'm not familiar with Qt. I'll quote this from the project page:
"AVIR works with header-less "raw" image buffers. If you are not too familiar with the low-level "packed interleaved" image storage format, the InBuf is expected to be whc elements in size, where w and h is the width and the height of the image in pixels, respectively, and c is the number of color channels in the image. In the example above, the size of the InBuf is 6404803=921600 elements. If you are working with 8-bit images, the buffer and the elements should have the uint8_t* type; if you are working with 16-bit images, they should have the uint16_t* type. Note that when processing 16-bit images, the value of 16 should be used in resizer's constructor. AVIR's algorithm does not discern between channel packing order (RGBA, ARGB, BGRA, etc.), so if the BGRA ordered elements were passed to it, the result will be also BGRA."

From the Qt documentation I see they support quite a lot of format https://doc.qt.io/qt-5/qimage.html#image-formats and that each format has their specific storage specification.
In my case it use the QImage::Format_RGB32, the image is stored using a 32-bit RGB format (0xffRRGGBB).
This 32 bit format is not supported by Avid.

You can cast it to uint8_t


Windows support for Swarm

Tracker issue for Swarm on Windows

#31348: Multi-architecture support in Swarm mode /cc @nishanttotla
#29738: Secrets support /cc @johnstep

Please let me know if we're missing other pieces.
/cc @friism @mgoelzer @vsaraswat

@dhiltgen

Both of your issues that are being tracked here are closed.  Does this mean that Swarm on Windows will work in 17.06-ce?

@caleblloyd yes, swarm-mode with Windows (and also mixed Linux/Windows swarms) have worked for a couple of months. Docker 17.06 will be the first stable release that fully supports this, but you can start experimenting with 17.03 or with the 17.06 release candidates already.
@aluzzardi @thaJeztah I think this issue can be closed.

@friism thanks.  Will routing mesh work on Windows in 17.06-ce, or are we still waiting for a Windows update on that?

@caleblloyd that'll require changes to Windows. Docker Inc. (and other vendors I'm sure) do provide ingress routing options that'll work across Linux and Windows swarms.

Okay, let me close this one 👍


You need to hook into both luastates at once.

The VR lua layer is a different lua layer than the flatscreen layer. I noticed your code will check which layer it starts with/finds first and initalizes based on that.
The game defaults to the non-VR mode then turns on the VR mode, so you'll need to hook into both states at the start.
I'd file this as an issue but I can't because no issues enabled on the repo.

When I was testing, when run in VR only the VR-specific luaL_newstate was called - unless they've changed something, I'm a bit confused about this.
Do you mean the Lua was run twice, once for flat and once for VR?
Oh, and I'll turn on comments. I think they were disabled because this is a fork.

We noticed that hook overriding lua only works on the flat, and isn't being reflected in the vr side, with stuff like weapon lock disables working in the flat but shutting off in the vr mode.

Huh, that's odd. Do you want me to make you a special version that displays a popup when one of the hooks is run?

fixed in latest iirc

See 56ec03c


Code fixes

Code fixes follow suggestions from pull request #2

I missed your changes in the tracking branch, so I merged it with my fork, so I have the same version as yours.

Merged, thanks :)

Your welcome.


Release 0.7.0 on Packagist

Please, can you publish the 0.7.0 release on Packagist?

Done, auto-sync was broken


Record default values into cassettes

Hey @mastahyeti!
Big fan of this gem and have been using it heavily with my gRPC integrations in ruby. I'm having an issue with the cassette saving invalid JSON, which then breaks when the cassette is replayed.
Replaying an invalid recording, I get an error message as such:
 Google::Protobuf::ParseError:
       Error occurred during parsing: Parse error at ',"someAttribute2":"123"...

This is because the cassette has a JSON key set but there is no value (because it's defaulting to the default value). The cassette looks something like this:
{
  "version": 2,
  "reqs": [
    [
      {"route":"/com.some.grpcService/GetObjectById","class_name":"Com::Some::Grpcservice::GetObjectByIdRequest","body":"{\"id\":[{\"value\":\"56b0c4e7-d7d3-4392-a090-679491798f83\"}]"},
      {"class_name":"Com::Some::Grpcservice::GetObjectByIdResponse","body":"{\"object\":[{\"id\":{\"value\":\"56b0c4e7-d7d3-4392-a090-679491798f83\"},\"objectProperties\":{\"id\":{\"value\":\"56b0c4e7-d7d3-4392-a090-679491798f83\"},\"someAttribute1\":,\"someAttribute2\": true}}]}"}
    ]
  ]
}

Notice that someAttribute1 does not have any value and just ends with a ,.
Solution
There was an addition the google-protobuf to emit_defaults: true to pass through so that we can save those default values and the cassettes can decode as valid JSON. PR: https://github.com/protocolbuffers/protobuf/pull/4252
Note: There are no specs added because I'm not sure how to test. The gRPC server in the gem is correctly omitting the keys, even though the Java gRPC server I'm testing against is not. It's possible that the issue really is coming from the gRPC server I'm interacting with, but this solves the edge case and is more explicit in recording so it should be a win for the community.

This change is

Thanks!

Awesome!! Let me know when you push up a new version of the gem :)

https://rubygems.org/gems/gcr/versions/1.0.2


[Suggestion] Add support for JSON_PRETTY_PRINT

While developing, I often need to check the results inside the JSON. In bigger files, it's hard to keep an overview. So, I suggest adding the option JSON_PRETTY_PRINT (by default deactivated). Any thoughts?

Hi @basteyy
I see how that could benefit the development workflow.
Currently you can query the documents to inspect/ dump their content.
That said, you are welcome to implement such a feature
Feel free to ask for help if needed :blush:

@basteyy
maybe it is a little bit late,
but it's a simple workaround, if you want to do it yourself,
open store.php
make a search and replace for this
search for
json_encode($data)
replace it with
json_encode($data, JSON_PRETTY_PRINT))
in all occurrences
hope it will help you :)


Make toggle-explain a SuggestCommand

Solves #78275
Make the toggle-explain command a SuggestCommand so that it has access to the SuggestWidget.

Thanks. Looking pretty good!

Great thanks!


Explicitly cast dimension to int to fix narrowing warning

Fixes a narrowing warning with clang and MSVC
-Wc++11-narrowing / C2397

Thanks!


TRAPI 1.4 validation issues

I'm hitting SPOKE dev and getting a couple validation errors:

In your knowledge graph edges, it looks like your resource_role has a biolink: prefix when it shouldn't
Your results.anaylses is a dict when it should be a list

Thanks @maximusunc
The resource role issue was already fixed in CI, but I'd forgotten to put it in dev as well. It's deployed in dev now as well.
I haven't been able to recreate the second issue. Could you provide the query that is causing that behavior?
Here's what I see:

Query
{
  "message": {
    "query_graph": {
      "edges": {
        "e00": {
          "subject": "n00",
          "object": "n01"
        }
      },
      "nodes": {
        "n00": {
          "ids": [
            "MONDO:0004981"
          ]
        },
        "n01": {
          "categories": [
            "biolink:SmallMolecule"
          ],
          "constraints": [
            {
              "id": "biolink:highest_FDA_approval_status",
              "name": "highest FDA approval status",
              "operator": "==",
              "value": "regular approval"
            }
          ]
        }
      }
    }
  },
  "max_results": 1,
  "workflow": [
    {
      "id": "lookup",
      "parameters": {}
    }
  ]
}

Results
{
  "biolink_version": "3.2.6",
  "description": "Success. Returning 1 results...",
  "message": {
    "knowledge_graph": {
      "edges": {
        "33074841": {
          "attributes": [
            {
              "attribute_source": "infores:chembl",
              "attribute_type_id": "biolink:has_confidence_level",
              "original_attribute_name": "phase",
              "value": 3
            }
          ],
          "object": "MONDO:0004981",
          "predicate": "biolink:treats",
          "sources": [
            {
              "resource_id": "infores:chembl",
              "resource_role": "primary_knowledge_source"
            },
            {
              "resource_id": "infores:spoke",
              "resource_role": "aggregator_knowledge_source",
              "upstream_resource_ids": [
                "infores:chembl"
              ]
            }
          ],
          "subject": "PUBCHEM.COMPOUND:30928"
        }
      },
      "nodes": {
        "MONDO:0004981": {
          "attributes": [
            {
              "attribute_type_id": "biolink:full_name",
              "original_attribute_name": "name",
              "value": "atrial fibrillation"
            },
            {
              "attribute_type_id": "biolink:source",
              "original_attribute_name": "source",
              "value": "Disease Ontology"
            },
            {
              "attribute_type_id": "biolink:mesh_terms",
              "original_attribute_name": "mesh_list",
              "value": [
                "D001281"
              ]
            }
          ],
          "categories": [
            "biolink:Disease"
          ],
          "name": "atrial fibrillation"
        },
        "PUBCHEM.COMPOUND:30928": {
          "attributes": [
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "standardized_smiles",
              "value": "CC(C)N(CCC(C(N)=O)(c1ccccc1)c1ccccn1)C(C)C"
            },
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "inchikey",
              "value": "CGDDQFMPGMYYQP-UHFFFAOYSA-N"
            },
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "inchi",
              "value": "InChI=1S/C21H29N3O.H3O4P/c1-16(2)24(17(3)4)15-13-21(20(22)25,18-10-6-5-7-11-18)19-12-8-9-14-23-19;1-5(2,3)4/h5-12,14,16-17H,13,15H2,1-4H3,(H2,22,25);(H3,1,2,3,4)"
            },
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "inchikey_prefix",
              "value": "CGDDQFMPGMYYQP"
            },
            {
              "attribute_type_id": "biolink:highest_FDA_approval_status",
              "original_attribute_name": "max_phase",
              "value": "regular approval"
            },
            {
              "attribute_type_id": "biolink:source",
              "original_attribute_name": "source",
              "value": "ChEMBL"
            },
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "canonical_smiles",
              "value": "CC(C)N(CCC(C(N)=O)(c1ccccc1)c1ccccn1)C(C)C.O=P(O)(O)O"
            },
            {
              "attribute_type_id": "biolink:id",
              "original_attribute_name": "chembl_id",
              "value": "CHEMBL1201020"
            },
            {
              "attribute_type_id": "biolink:full_name",
              "original_attribute_name": "pref_name",
              "value": "DISOPYRAMIDE PHOSPHATE"
            }
          ],
          "categories": [
            "biolink:SmallMolecule"
          ],
          "name": "DISOPYRAMIDE PHOSPHATE"
        }
      }
    },
    "query_graph": {
      "edges": {
        "e00": {
          "object": "n01",
          "subject": "n00"
        }
      },
      "nodes": {
        "n00": {
          "constraints": [],
          "ids": [
            "MONDO:0004981"
          ]
        },
        "n01": {
          "categories": [
            "biolink:SmallMolecule"
          ],
          "constraints": []
        }
      }
    },
    "results": [
      {
        "analyses": [
          {
            "edge_bindings": {
              "e00": [
                {
                  "id": "33074841"
                }
              ]
            },
            "resource_id": "infores:spoke"
          }
        ],
        "node_bindings": {
          "n00": [
            {
              "id": "MONDO:0004981"
            }
          ],
          "n01": [
            {
              "id": "PUBCHEM.COMPOUND:30928"
            }
          ]
        }
      }
    ]
  },
  "schema_version": "1.4.0-beta2",
  "workflow": [
    {
      "id": "lookup",
      "parameters": {}
    }
  ]
}

I'm not seeing the analyses issue anymore, so I guess it was fixed with this latest deployment as well. Thanks!

Thanks @maximusunc . I couldn't recreate the issue before or after the recent deployment, and I haven't changed any logic around those analyses objects since the initial implementation. Something about a query that you were sending might be a corner case that is causing that. If you are able to retrieve the query that caused the issue originally, or if you come across it again, please let us know.


Teaspoon tests fail after RSpec upgrade to 2.99

Not sure if that's really related, but our Teaspoon tests are failing after we upgraded to Rspec 2.99.
We use Teaspoon 1.1.1, Jasmine 2.3.4, and seems like something really low-level is failing for us, an example:
1) Controller: ComposeCtrl sets data on init
     Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1716)

  2) Controller: ComposeCtrl sets data on init
     Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$modules') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1787)

  3) Controller: ComposeCtrl sets data on init
     Failure/Error: Expected undefined to be Object({ my_boards_data: true }).

  4) Controller: ComposeCtrl sets data on init
     Failure/Error: Expected undefined to be Object({ top_boards_data: true }).

  5) Controller: ComposeCtrl sets data on init
     Failure/Error: Expected undefined to equal [  ].

  6) Controller: ComposeCtrl sets data on init
     Failure/Error: TypeError: 'undefined' is not a function (evaluating 'httpBackend.flush()') in http://<IP_ADDRESS>:58977/assets/pulse_angular/controllers/compose_controller_spec.js?body=1.js (line 104)

  7) Controller: ComposeCtrl sets data on init
     Failure/Error: TypeError: 'undefined' is not a function (evaluating 'httpBackend.verifyNoOutstandingExpectation()') in http://<IP_ADDRESS>:58977/assets/pulse_angular/controllers/compose_controller_spec.js?body=1.js (line 97)

  8) Controller: ComposeCtrl sets data on init
     Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1659)

  9) Controller: ComposeCtrl subscribes for updates
     Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1716)

Any ideas?

Well, I can tell you that teaspoon doesn't have a spec.$injector, so it's something about angular mocks and likely isn't teaspoon directly.

Jeremy Jackson

On Dec 8, 2015, at 7:30 AM, Udi Mosayev<EMAIL_ADDRESS>wrote:
Not sure if that's really related, but our Teaspoon tests are failing after we upgraded to Rspec 2.99.
We use Teaspoon 1.1.1, Jasmine 2.3.4, and seems like something really low-level is failing for us, an example:

Controller: ComposeCtrl sets data on init
Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1716)

Controller: ComposeCtrl sets data on init
Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$modules') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1787)

Controller: ComposeCtrl sets data on init
Failure/Error: Expected undefined to be Object({ my_boards_data: true }).

Controller: ComposeCtrl sets data on init
Failure/Error: Expected undefined to be Object({ top_boards_data: true }).

Controller: ComposeCtrl sets data on init
Failure/Error: Expected undefined to equal [  ].

Controller: ComposeCtrl sets data on init
Failure/Error: TypeError: 'undefined' is not a function (evaluating 'httpBackend.flush()') in http://<IP_ADDRESS>:58977/assets/pulse_angular/controllers/compose_controller_spec.js?body=1.js (line 104)

Controller: ComposeCtrl sets data on init
Failure/Error: TypeError: 'undefined' is not a function (evaluating 'httpBackend.verifyNoOutstandingExpectation()') in http://<IP_ADDRESS>:58977/assets/pulse_angular/controllers/compose_controller_spec.js?body=1.js (line 97)

Controller: ComposeCtrl sets data on init
Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1659)

Controller: ComposeCtrl subscribes for updates
Failure/Error: TypeError: 'undefined' is not an object (evaluating 'spec.$injector') in http://<IP_ADDRESS>:58977/assets/angular-mocks.js?body=1.js (line 1716)
Any ideas?

—
Reply to this email directly or view it on GitHub.

I see.. thanks, I'll start looking elsewhere.


Add Module support

Add module support to HPX
Any background context you want to provide?
https://github.com/STEllAR-GROUP/hpx/issues/6014
Checklist
Not all points below apply to all pull requests.

[ ] I have added a new feature and have added tests to go along with it.
[ ] I have fixed a bug and have added a regression test.
[ ] I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

Can one of the admins verify this patch?

@Johan511 Thank you for working on this. May I suggest that first of all, we should resolve the conflicts with master? I'd be happy to help with that, just let me know.

@Johan511 Make sure you reabse on top of the current master first ;) Thanks for working on that!


I have played more than 10 matches  using almost all the heroes but my stats,heroes played,expected mmr are showing as null.

OS:
Screen Resolution:
Browser/Version:
Link to page with the issue, or screenshot:

You probably don't have public match data enabled.  Do this in your Dota 2 settings and then click the refresh button on your profile.

let me know if that doesn't fix it/reopen the issue


Changed the extras_require dictionary format

I tried to install it using python 3.9.6 but ended up getting below error
"error in amundsen-databuilder setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers."

Summary of Changes

Tests

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

After a lot of troubleshooting from my end I tried changing the format of the dictionary and it worked.

I had the same issue , running in python 3.8.x on an Ubuntu 20.04 (VM).
( see also  ttps://github.com/amundsen-io/amundsen/issues/1440 )
I only needed to quote the values of the 2 entries with "list" values:
extras_require={
        'all': 'all_deps',
        'dev': 'requirements_dev',


Refactored getUserActivity and getAccountUsage to match API

Refactored .getUserActivity

Remove start and end parameters (the API endpoint doesn't have parameters)
Update unit tests to reflect the change in function signature
Update README with new usage of .getUserActivity

Refactored .getAccountUsage

Add start and end parameters (the API allows these parameters)
Update unit tests to reflect the change in function signature
Update README with new usage of .getGetAccountUsage

Hi @ericmacfa - sorry I missed this PR! I'll check this out today at some point, or maybe tomorrow depending on time :)


Logging crashes?

Hi,
I was wondering if there was any sort of log file generated for crashes? Or if there was an easy way get the error message for crashes? Would the only way be to compile and run it myself in an IDE to troubleshoot?
I'm having a crashing issue compressing a file and wanted to see where the problem lies exactly.
Thanks

https://github.com/nesrak1/UABEA/wiki/Sending-a-crashlog shows where to find .net exceptions on windows.

Great, didn't see that. Thanks


Add appveyor badge to readme

also fix test badge, and add codecov badge.

Added in https://github.com/datalad/datalad-catalog/commit/f1743ab7a4d58ae4cdb22b344b5ab30620da1d8e


Transforms

This PR roughs in the Aggregations UI but leaves the Panel in the Dev section of the app, as there are some issues in Plotly.react that will need to be resolved before it's usable.

ok, well, so this doesn't stale, I vote that we can merge it in as its in Dev panels, and continue building on this feature to finish it off, @bpostlethwaite ?

Yep looks great! :dancer:


triangulate any n-gons

Arx can only handle triangles and quads, more complex planes need to be sliced up into smaller triangles. Should be done on threejs level.
Fan triangulation is a no go, because Arx uses vertex lighting, which focuses lighting information into the tips of the triangles. Something more evenly distributed is needed.

https://lindenreidblog.com/2017/12/03/simple-mesh-tessellation-triangulation-tutorial/

ear clipping might also be viable here https://en.wikipedia.org/wiki/Polygon_triangulation#Ear_clipping_method


[BUG] AWS SES resource cant have TAG assigned, so is not scraped anymore

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
AWS SES metrics are not scraped anymore, because they do not contain any TAG, but you can't assign tags to SES
Expected Behavior
Should scrape SES anyway, even without tags
Steps To Reproduce
No response
Anything else?
v3.36.1-alpha was last that version was working
i suppose it was caused by
Return early if no tagged resources are found. by @cristiangreco in https://github.com/nerdswords/yet-another-cloudwatch-exporter/pull/606

that was merged in version v3.36.2-alpha

this is broken for us too now! looking forward for the fix to be merged!

@marekhanzlik @abualy thanks for the bug report.
Even though ses metrics are not fetched with discovery jobs, you can still use a static job, e.g.
apiVersion: v1alpha1
static:
- name: ses
  namespace: AWS/SES
  regions:
    - eu-west-3
  metrics:
    - name: Send
      statistics:
        - Sum
      period: 60
      length: 600
      nilToZero: true
    - name: Reputation.ComplaintRate
      statistics:
        - Sum
      period: 60
      length: 600
      nilToZero: true
    - name: Reputation.BounceRate
      statistics:
        - Sum
      period: 60
      length: 600
      nilToZero: true
    - name: Delivery
      statistics:
        - Sum
      period: 60
      length: 600
      nilToZero: true
    - name: Bounce
      statistics:
        - Sum
      period: 60
      length: 600
      nilToZero: true

Does this work for you?

@marekhanzlik I see you closed this bug. Running a static job did solve your issue?


Error in settings!

When I click Settings -> Apps -> Messages, it displays:
Messages:
Error in
settings!

BTN1 to go
back

with no further context.

@voloved what version of messages do you have installed? That PR was made to fix the error you're seeing (or one similar), and merged as version 0.65

@voloved what version of messages do you have installed? That PR was made to fix the error you're seeing (or one similar), and merged as version 0.65

It looks like 0.64 is the default on Bangle.js's app loader. Also I backed up the watch and saw !!settings().ignoreUnread, in messages.settings.js in the zip.

Interesting - do you see anything if you do exactly the same, but with the IDE connected? Any messages in the IDE's console?

Here's my output:
      58
Press  96 7 38
Messages settings error: SyntaxError: SyntaxError: Got ';' expected ','

Note:  I did manually modify the messages.settings.js by backup, edit the file, and restore to try to fix this issue, so that comma may be a typo?

Fixed.

in https://www.espruino.com/ide/# connect to the watch.
Access device storage and Save message.settings.js
Open the saved file in Notepad++ (VSCode gave me issues, likely due to odd saving on encoded symbols it can't read)
Delete () in settings().ignore... and save.
At the top of the same Device Storage window in the IDE that opened the file, click upload.
Upload the saved file.
Click Run File next tp the the newly added file to make sure it can be read properly.

I'll expect v0.65 to not have this issue.

It looks like 0.64 is the default on Bangle.js's app loader

Yes, there's a delay before apps go onto the app loader - the dev one has the latest versions immediately, so it's there already.
Thanks for the details too - I'll close this for now but if it reappears let us know


Improve index page of docs

Communication goals (e.g. detailed howto vs orientation)
Analytics show, unsurprisingly, that plenty of people view the front page of the docs. The page is currently not very interesting and dominated by a complete table of contents. Since the sidebar has the contents anyway, we can remove it from the index page and put more useful and enticing content there.
Just add
:hidden:

to each item on index.rst

Dupe of #404. Closing.


⚠ Bofrost.fr has degraded performance

In 23c46a5, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1010 ms

Resolved: Bofrost.fr performance has improved in 04dea7a after 9 minutes.


html5Mode support.

Open for discussion.  This pull request enables use of html5Mode.  This should also still work with html5Mode(false).

Is it merged?

@xxorax @woniesong92 @ebraminio perhaps here? https://github.com/meanjs/mean/tree/0.4.0

I have found some issue. Direct access to the routes that are 'first level' works just fine, but when I try direct access on 'second level' routes, angular (I assume it is angular from error in chrome inspector) gets into infinite loop. Example with sample app on localhost:
Type in browser:
http://localhost:3000/signin = works fine
Now change url route in /public/modules/users/config/users.client.routes.js from /signin to /signin/in and try to type in a browser:
http://localhost:3000/signin/in = gets into infinite loop
However, if I crawl to this route through homepage (not direct access) it works ok. I'm a newbie in MEAN stack so I have no idea how to fix this.

@rhutchison
I still have problem. When I refresh the page at "/articles" or "/articles/create", I am automatically signed out.
The other pages like "/settings/profile" is ok.

@monad98 this PR is pretty out dated from upstream, so not sure how reliable it would be.  I know @amoshaviv manually plucked these changes and put them in to the 0.4.0 branch (https://github.com/meanjs/mean/commit/ab81d61bd3cc629d55e0b9eeb8914f2254e191db#diff-90593c1684669b4a0cc185ec424f0a24R9) - have you had any luck there?


Invalid OAuth2 redirect_uri

When trying to authenticate, it is given (as I understand) the wrong link, which is why they write the error

Why do I think this? Well...
Normal link: https://discord.com/oauth2/authorize?client_id=1212131698779881542&response_type=code&redirect_uri=https%3A%2F%2Flocalhost%3A8000&scope=identify
Mod link: https://discord.com/oauth2/authorize?client_id=1212131698779881542&redirect_uri=http://localhost:8000/callback&response_type=code&scope=identify
Anyway
Minecraft 1.19.2
Fabric Loader 0.15.6
discordloom-2.0.0.jar
owo-lib-0.9.3+1.19.jar
Log:
2024-03-26-7.log

You need to add http://localhost:8000/callback in your discord app redirect URI

Thanks


Java Wrapper

When using the linear_solver, is it possible for Java users to add CONSTRAINTS in a more natural way similar to Python or CSharp, instead of calling solver.makeConstraint() followed by frequently setCoefficient?

No.
Java does not support operator overloading, so it has to be verbose :-(
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le lun. 22 oct. 2018 à 16:47, xuanc<EMAIL_ADDRESS>a écrit :

When using the linear_solver, is it possible for Java users to add
CONSTRAINTS in a more natural way similar to Python or CSharp, instead of
calling solver.makeConstraint() followed by frequently setCoefficient?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/898, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKj17SLvUTcpZG8ohmOkGkb6PelpyZKqks5undqAgaJpZM4XzhRu
.

operator overloading
got it and thanks

For a Java-like (and JVM-based) language which does support operator overloading, you could look at Groovy.
note: I didn't say we will support it in a foreseeable future !!!

Comparing to the "define solver -> solver.makeConstraint" way, the  "define a constraint -> add the constraint to a model/solver" way made constraints reusable?

Comparing to the "define solver -> solver.makeConstraint" way, the "define a constraint -> add the constraint to a model/solver" way made constraints reusable?

When the overall model is complex and difficult to solver directly, constraint reuse is usual by iteratively solve two decomposed models with (largely) overlapped constraints.

Comparing to the "define solver -> solver.makeConstraint" way, the "define a constraint -> add the constraint to a model/solver" way made constraints reusable?

When the overall model is complex and difficult to solver directly, constraint reuse is usual by iteratively solve two decomposed models with (largely) overlapped constraints.
Is it possible?


Can't embed files to MSI/EXE

Hi,
I recently came across the Toolkit and am having an issue creating an embeded MSI. I downloaded the latest 32bit "Broad" channel Office and configured a few different options for the configuration
"The Office source file are invalid. Please verify that all files have been downloaded"
I tried again downloading office files locally with no other configuration and still get the same error.
Source Path is set to the same location the files were downloaded too.
Any ideas?

make sure you have it pointed to the CC folder it creates when it downloads and not the parent folder you created


enviroment error about pytorch lighting

I use pytorch 1.7 and pytorch lighting 0.8.5, but there is a problem that TypeError: __init__() got an unexpected keyword argument 'every_n_train_steps'. I want to know which lighting is available？

I'm success to use pytorch-lightning==1.5.10, maybe you can try it!

@KennyChen880127  Thanks！


Antivirus detection

Issue 1:
Antivirus was not found (i.e. folder not in PATH) -> celery starts with default queue. Frontend recognizes it and schedules a scan -> timeout for scan
Issue 2:
Got not detected:
McAfee Antivirus 2014

when installing an antivirus you could check if it will be discovered by IRMA by checking the plugin source code https://github.com/quarkslab/irma-probe/blob/master/modules/antivirus/mcafee/vscl.py#L121 For Mcafee on windows it looks for a scan.exe in c:\VSCL for example


Fix scale and position for cameras with non 16:9 aspect ratio

Before:

After:

A comment in the code mentions

All this binding and transforming essentially aims to make the iframe behave like background-size: cover

Not sure if it would be better for the image/iframe to behave as contain?

Yeah, you're right


Support progress callback

Would be nice if script loading() could report about % of progress while loading (if JS is ~2 mb then it would be useful), as suggested by Mozilla, its possible with ajax..
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress

Don't know if you got your answer already, but scriptjs doesn't use xhr ("ajax") to load its scripts. It creates a script element in the DOM that loads the scripts (see: https://github.com/ded/script.js/blob/master/src/script.js#l66). This doesn't support the onprogress event that xhr supports.


How to Expand/Collapse onclick of Entire Node, not just the special button

To make it easier for users to expand or collapse a node, especially when zoomed out a bit, I was trying to make it such that when the node is clicked ANYWHERE (not just the special, designated button) it would do so - how to achieve this? Tried using chart.onNodeClick() method coupled with setExpanded(node.id).render() but nothing happens.
Would appreciate any insight on this. And thanks to the creators/maintainers for the amazing library - truly great stuff.

This is the code which is invoked after the designated button
.on("click", (event, d) => this.onButtonClick(event, d))

event is click event, d is the data. So I guess you could add your own event listener in nodeUpdate method, and the invoke this method in the handler
chart.nodeUpdate(function(){
  d3.select(this).select(`yourElementSelector`).on('click',(e)=>chart.onButtonClick(e,d))
})


[WFCORE-3810] Use the right name for the galleon pack zip

https://issues.jboss.org/browse/WFCORE-3810

Approved, thanks!


Add support for access_token in config instead of public/private keys

Done. Please correct if something is written incorrectly


Zooming on mobile is sometimes janky

To repro: Open the example app on a mobile device and try pinch zooming. You will notice that frequently the zoom effect is shaky/janky. This seems to be correlated to the speed at which you zoom and also the initial zoom level.

hi, any fix for this bug? I found the same issue, try a few ways to fix it but no luck.., sometimes works fluid others jumping.
thanks

I haven't found a fix, but also haven't dug in deeply yet. The code for determining which pointer events to use might be the issue. It assumes that the first two events are the first two touch downs. Maybe there is an issue with assuming that the order in the event array is maintained between each change in the position. Not sure.

thanks

I identified two separate issues:

I have a fix for this one coming -- The scale is not properly being changed during a pinch/zoom. Specifically, the computed change is too large which means as you zoom in, the points beneath your fingers will zoom together too quickly (and when zooming out, they zoom away too quickly).
Haven't yet fixed this -- we see a jerky zoom if you pinch up and down vertically for some reason. Sometimes the zoom will even invert such that pinching inwards will cause the scale to increase, not decrease

I may make two separate tasks for these.