Add support for server variables in Nodejs template

Fixes #182

Updates docs for creating templates in area of hooks and partials
Extends the test doc to have a server variable
Adds support for variables in the servers object to the Node.js template. An example is based on the port variable

I could test MQTT protocol as it is already in the streetlights.yml. After my changes I generated the Nodejs example and started it. It received a message sent to mqtt pub -t 'smartylighting/streetlights/1/0/event/{streetlightId}/lighting/measured' -h 'test.mosquitto.org' -p 1883 -m '{"id": 1"}'
Important notes to how the replaceVariablesWithValues filter works:

if variable is in URL but not declared, it stays
if variable is in URL and declared, it picks up default, otherwise first enum element, otherwise is stays unchanged
It is pretty generic, works on any string, not just url of course.

I need some suggestions on how to test if my changes work with other brokers. How you do it? should I just grab Kafka and others on my local and play or?
So far I made sure that in common.yml config whenever url() is grabbed and filter (that gets a string and created new URL object from it) is used, I add the variable parsing filter first to not get errors. If filters are shared among other templates, I'm afraid there might be some issues in other templates...:thinking: I ran generation for all of them and got no errors, but I don't know if it means all is fine

@fmvilas take a look at my comment. Fixes done
I can do the setup, it is fine, but if you point me to specific tools that I can use, that would be great, things that you are using when working on a template. For Kafka that should be easy to find something, but for amqp? that would be rabbitmq?
btw "supportedProtocols": ["amqp", "mqtt", "kafka", "ws"], I guess ws is not supported by this template? this is why we have Node.js-ws template?
docker-compose is a must-have long term as it will be needed for CI testing anyway. But it is not in scope of this PR imho

WebSockets is supported by Node.js template but it's not using Socket.io and it's a bit different than the other. I'll do a cleanup as soon as I find time. Support for WS in Node.js template was added after I created the nodejs-ws template. That's why both exist.

docker-compose is a must-have long term as it will be needed for CI testing anyway. But it is not in scope of this PR imho

Yup, totally out of scope. Should we create an issue not to forget about it?

@fmvilas I will create one for sure
I will not merge until I test with Kafka and RabbitMQ to make sure I did not break anything.
Do you have some sample spec I could use? I recall from one of the conferences that you for sure had a Kafka example. I never played with those, will be fun

Yeah, RabbitMQ would be ok for AMQP. As per the examples, just change the protocol and everything else should work the same way.


Name resolution does not use domain searchlist

Windows Build Number
Microsoft Windows [Version 10.0.19042.1237]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04.3
Other Software
No response
Repro Steps
Let's say ad.corp.com is the default DNS domain
Add  items in   DNS Suffix Search List
Like:
ad.corp.com
lab.ad.corp.com

Mine are provided automatically by the AD/DHCP system

In, WSL, try:
nslookup server1
nslookup server1.ad.corp.com
nslookup server2
nslookup server2.ad.corp.com

Expected Behavior
All nslookup should be successful
Actual Behavior
The third nslookup fails in WSL but works in a cmd on the Windows host.
Even nslookup server2.lab does not work.
Diagnostic Logs
No response

This looks like a duplicate of https://github.com/microsoft/WSL/issues/701 :) I see the same behaviour.


Feature Request: Option to enable/disable all animations

Browser animations and fancy effects is a big source of flakiness.  I don't know if it's possible, but it would be great if pylenium had the option and capability to enable/disable all animations.

If we can figure out how to do it with js in the browser or Selenium, then we can easily add it to Pylenium.
I'll get to this when I can, but any help on your side is always appreciated!

I've been searching quite a bit, but I wonder if I'm searching the wrong things. I found this, but I was hoping for something a little more elegant


Future of project

Hi @XertDev ,
I recently stumbled upon your project and found some time today to give it a try. It's pretty impressive what functionality already is implemented. I'm just wondering, do you plan to continue working on this project?

This project was created because I needed a more customisable browser than webview offered. Currently, my side project does not require any additional functionality, so development has stopped for the moment.
Although, in the case that someone comes forward to say that they need some additional functionality, I can see to it.

I am currently searching for a replacement for the standard WebView (flutter_inappwebview), and GeckoView looks very promising. However, it’s challenging to estimate the effort required to fully implement it for a larger user base, especially compatibility and stability wise. Are you already using it productively in your side project?
I will need additional functionalities such as in-page search, screenshots, downloads, progress callbacks, etc.
I understand that this is quite a lot to ask given the current feature set, and I'm planning to do those implementations myself. The goal of my project (GitHub: FaFre/lensai) is to develop a fully-featured browser, so it will be using GeckoView a lot.
During your development, have you encountered any unsolvable problems, or do you foresee any upcoming difficulties? I am trying to gauge how easy it will be to implement more features.


optional argument support for supported numpy functions, at the very least axis

Feature request
As stated in the docs all optional arguments are not supported for many fundamental arguments.
Further several issues:

https://github.com/numba/numba/issues/2745
https://github.com/numba/numba/issues/1269

already call for at the very least axis across a number of numpy functions.
I wouldn't mind it in np.all, np.any, etc
In addition to this, I highly encourage a new docs page or search bar specific for searching the either implemented or not implemented features in a numpy-esque doc style
e.g.
searching all would show me the function signature for np.all() and note that although optional arguments exists they are currently not supported. numba specific work-arounds should be provide to direct users how to best recreate this lost functionality in a performant manner.
I should also be able to search directly for things like np.append and see that it is not yet implemented / supported by numba and to use the related concatenate

@SumNeuron thanks for the report, we appreciate you submitting a feature request to Numba. Note that there is already an issue tracking the axis keyword for the reduction functions:
https://github.com/numba/numba/issues/1269

@esc noted as that issue was referenced in the OP. Unlike all the various other requests which are axis for various numpy functions, this is an across the board, if axis is an optional function and numba supports that numpy function, then axis is also supported


[$250] [Payment card / Subscription] No forward slash in the add-payment-card form field for expiration date

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue reported by: @blimpich
Action Performed:
Break down in numbered steps

create a new account
create a workspace on that account
go to https://staging.new.expensify.com/settings/subscription/add-payment-card
look at the expiration date field and verify that the placeholder value is MMYY
type 0424 into the field

Expected Result:
Describe what you think should've happened
The placeholder should be MM/YY and I should be able to type 0424 and have it be formatted as 04/24
Additionally, the user should not be able to type characters that aren't digits.
Actual Result:
Describe what actually happened
It shows up without the forward slash /
Screenshots/Videos

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010cf3d8d608f1cea2
Upwork Job ID:<PHONE_NUMBER>567993588
Last Price Increase: 2024-06-20

Issue OwnerCurrent Issue Owner: @mananjadhav

Not prioritizing this now because I think we can make this available to contributors, but I want to wait till the end to end flow for this is finished so that we can make sure we don't break it by updating this field.

Proposal
Modify the screen template to be MM/YY  not MMYY.  The validation for that format is exists so no other changes are needed.

@puneetlath @blimpich Is this a reported as a bug or a feature request?
We had removed / logic from the Add a debit card page in this issue. I also remember discussing this long back that we shouldn't format the user input (can't find the slack/thread). So do we really need to work on this? or :donothing:

Hmm, I assumed it was a bug because in Expensify Classic we have a / in the expiration field for when we add a card. I thought we missed it here. Maybe I'm missing context. I'll discuss internally and get back to you.

Brought discussion to slack in #wave-collect channel here

Apologies for everyone who has investigated this issue, we've decided internally that we don't want this feature at this time. Closing.


Fix bug preventing a copy by accepting cards like fits.Header

The copy() method for a header expects the same init signature as the parent. Since the current Header class in GDT does not take as first argument the cards parameters, the value are never copied, and instead you get the defaults from .keywords.

Need unit tests.


Update spark-mlcontext-programming-guide.md

added creation of sqlContext, otherwise it was not running on my Spark 1.6 jupyter notebook (datascience experience of IBM)

Can an Admin verify this patch?

Yes, just run the example and it should run without errors

Thanks, Romeo. LGTM. But please change your comment in line 2290 from "in case it does not compile ..." to something like: "For Spark version <= 1.6.0 use createDataFrame(), and for Spark version >= 1.6.1 use .toDF()"

ok, done, thanks for the suggestion, please let me know in case you want me to change something else..

@romeokienzler Welcome to SystemML! Would you mind committing these changes on the master branch rather than the gh-pages branch? The master copy of the documentation lives on the master branch, and we push the docs subtree to gh-pages for publishing on GitHub. Since gh-pages has a different base directory from the master branch, this makes merging difficult.

Ok, done

add to whitelist


Cant Obtain the Token

Did they change the way we could obtain the Bearer token?
Normally it would show that you cant play with pc and you had to login with phone,
but now its Stuck in a loading loop, any ideas?

Did they change the way we could obtain the Bearer token? Normally it would show that you cant play with pc and you had to login with phone, but now its Stuck in a loading loop, any ideas?

indeed, the page takes forever to load, but the link in the iframe is present, take the link from the iframe, change tgWebAppPlatform=web to tgWebAppPlatform=android and paste the full link with the changed platform into the browser.


Added Eslint GH Action

Signed-off-by: Adithya Krishna<EMAIL_ADDRESS>Description
This PR fixes #5954
Signed commits

[x] Yes, I signed my commits.

hey @adithyaakrishna it would be great if you'd discuss PR on the meshery dev call tomorrow.


Buggy Terminal and Console (Some features aren't working on terminal area)

VS Code Version: 1.58.0 (stable)
OS Version: Windows 10 Home

Extensions

C/C++ version --> 1.5.0
Python version --> 2021.6.944021595

1). ctrl + `   and delete buttons doesn't work in the terminal area.

2). Sometimes terminal debug output doesn't  show anything .

/duplicate https://github.com/microsoft/vscode/issues/128236


WSARecv without expected error: remote socket shutdown

Should this throw a wsarecv error for shutdown of socket? It does not; is this expected?
https://msdn.microsoft.com/en-us/library/windows/desktop/ms741688(v=vs.85).aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740668(v=vs.85).aspx#WSAESHUTDOWN
fn recv_test() {
    let mut cp = CompletionPort::new(10).unwrap();
    let server = TcpListener::bind("<IP_ADDRESS>:6000").unwrap();

    let j = thread::spawn(move || {
        let mut client = TcpStream::connect("<IP_ADDRESS>:6000").unwrap();
        thread::sleep_ms(50); // wait for server to add socket to iocp, just in case for this test
        client.shutdown(std::net::Shutdown::Both);
        drop(client);
    });

    let mut server = server.incoming().next().unwrap().unwrap(); // client and server threads are unblocked now
    cp.add_socket(99,&server);
    thread::sleep_ms(120); // sleep while the client thread shuts down
    let mut buf = [0;10];
    unsafe { server.read_overlapped(&mut buf,&mut Overlapped::zero()); }

    let r = cp.get(None).unwrap();
    println!("{:?}",r);
}

prints:
CompletionStatus(OVERLAPPED_ENTRY { lpCompletionKey: 99, lpOverlapped: 0x3dffc68, Internal: 0, dwNumberOfBytesTransferred: 0 })

I think that this is indicated through the return value of read_overlapped which returns Ok(true) indicating that the operation completed immediately, and then the completion is received later indicating that 0 bytes were transferred (e.g. it was shut down).
The WSAESHUTDOWN may not be returned in this case but perhaps when you do something like write to a closed socket?
As a side note as well you'll want to make sure that the Overlapped::zero outlives the span between read_overlapped and get, so you'll probably want to pull it into a temporary in this function.

Ah ok that makes sense, thanks for the insight and tip!


virtualbox_vm.node: exit status 1

Hey there,
I use Terraform v0.6.7 installed via brew and the latest provider on El Capitan.
My terraform looks like this:
$ cat virtualbox.tf
resource "virtualbox_vm" "node" {
    count = 1
    name = "${format("node-%02d", count.index+1)}"

    image = "/Users/kniepbert/Downloads/ubuntu-15.04.tar.xz"
    cpus = 1
    memory = "512mib"

    network_adapter {
        type = "nat"
    }

    #network_adapter {
    #    type = "bridged"
    #    host_interface = "en0"
    #}
}

#output "IPAddr" {
#    # Get the IPv4 address of the bridged adapter (the 2nd one) on 'node-02'
#    value = "${element(virtualbox_vm.node.*.network_adapter.1.ipv4_address, 1)}"
#}

I got this error:
$ terraform apply
virtualbox_vm.node: Creating...
  cpus:                                     "" => "1"
  image:                                    "" => "/Users/kniepbert/Downloads/ubuntu-15.04.tar.xz"
  memory:                                   "" => "512mib"
  name:                                     "" => "node-01"
  network_adapter.#:                        "" => "1"
  network_adapter.0.device:                 "" => "IntelPro1000MTServer"
  network_adapter.0.ipv4_address:           "" => "<computed>"
  network_adapter.0.ipv4_address_available: "" => "<computed>"
  network_adapter.0.mac_address:            "" => "<computed>"
  network_adapter.0.status:                 "" => "<computed>"
  network_adapter.0.type:                   "" => "nat"
  status:                                   "" => "running"
Error applying plan:

1 error(s) occurred:

* virtualbox_vm.node: exit status 1

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

Any idea?

Please run TF_LOG=1 terraform apply to print full error log.

@ChristianKniep Please run TF_LOG=1 terraform apply to print full error log.

@ChristianKniep Please run TF_LOG=1 terraform apply to print full error log.

My VBoxManage seems to lack an option. :/
2015/12/19 11:12:56 [DEBUG] terraform-provider-virtualbox: VBoxManage: error: Unknown option: --synthcpu
2015/12/19 11:12:56 [DEBUG] terraform-provider-virtualbox: pid-17250-resource_vm.go:215: [ERROR] Setup VM properties: exit status 1

I just updated to the latest version:
$ VBoxManage --version
5.0.12r104815

@ChristianKniep A little googling shows that 'synthcpu' option is not available in VBox 5.0 any more, and I was testing on 4.3.x, so this is the problem.
github.com/ccll/go-virtualbox is the package to interact with VBox, you can make some quick hack to it, should be easy, and the patch is welcomed.  :)


Increase accuracy for gd/imagick alpha channel

2 decimal digits accuracy for alpha channel do not cover the entire space of 255(imagick)/127(gd) values (101 values only)
fix for that
tests need be changed too (accuracy has been increased)

tests needs to be changed too (accuracy has been increased)

Now that fix ready for gd too

...and add missed check for gd tests from imagick tests

: /
Needs to check values on tests with new accuracy, not ready yet

TODO add test to binary compare original image and result of 1:1 image convert


How to skip URI validation on sign

Hi,
I have a problem trying to sign a document with an xmlns uri invalid. It's weird because the service provider only receive the signed document with that format.
lxml.etree.XMLSyntaxError: xmlns: 'http://mi.domain.com MySchema.xsd' is not a valid URI
Looking for a solution I found this:
https://stackoverflow.com/questions/18692965/how-do-i-skip-validating-the-uri-in-lxml
I had the same problem generating element tree from string and that answer solved my problem.
There is any workaround for this cases?
Thanks in the advance!

Hi, thanks for your interest. I am not aware of a workaround for this and I'm not entirely sure what specifically you're asking for. Can you provide an example of the input and code you ran, the behavior you expected, and what was produced?

Hi @kislyuk,
I trying to sign a XML but fails because in the XSD import have a invalid URI. In my case that URI is valid for the receiver entity.

Sorry, I have to close this issue due to insufficient information provided. If you want help with your issue, please follow the instructions above and open a new issue with the information needed.


Use GridFs to not concern ourselves with the size of models

Is your feature request related to a problem? Please describe.
The problem is that models can sometimes be too big to fit into memory. As such since it is an expected use case that models may be small or large that we use GridFs instead of directly handling the stored data in single documents only.
Describe the solution you'd like
Re-implementation of MongoDb handler to use GridFS
Describe alternatives you've considered
While manually handling multiple files for larger models is a plausible solution, I believe a more standard method that works off the shelf is preferable to the alternatives time investment.
Additional context
This may be crucial to larger more chained models like GANs and any future more advanced architectures that nemesyst may want to handle.

https://github.com/DreamingRaven/nemesyst/pull/85 although will also require mongo_compat to become GridFS compatible.

mongo_compat is now GridFS able but it has not integrated any of the basic functionality. This will progress in future.


Update ES mapping to index story's first captured time

This PR introduces

Adding a story's indexed_date to the ES mapping.
Using ES's index API creates/updates a document - to ensure duplicates are not indexed, we replace the indexing functionality to use create API
On indexing, we may get BadRequest errors from parsing documents during indexing, this stories are Quarantined to be monitored via 400-* status counter. Duplicate stories also monitored via incremental counter

Fixes #130
Fixes #141
Fixes #90

@kilemensi any major blocker to merging this?

@kilemensi any major blocker to merging this?

I'll have to check @thepsalmist ... You didn't re-request review.


USER STORY: Contact us page

User Story

Metadata
Description

Theme
Budget app

Epic
-

User Story
So user can contact the web admin

Story Points
-

Description
As a user**, I want** to be able to contact the site's admin, So that I can get in touch and voice my opinions or concerns about the app.
Acceptance Criteria

A page with a form to contact the page admin
The form connects to either django or email to post the content of the form

Tasks

[ ] Create a template
[ ] Create a contact model
[x] Create a contact form that post to django and/or email

Notes

Articulate this criterion collaboratively with the Agile Team.
Remember: Adding an item to the backlog doesn't guarantee delivery. It represents an option for the team.
The Product Backlog is dynamic and may change based on feedback and changes.
The purpose of Backlog Refinement is to ensure sufficient development-ready items.
Prioritizing items in the Product Backlog is the responsibility of the Scrum Master.
The Development Team is responsible for estimating user stories and allocating work for development.

The "Tasks" section will help the team break down the user story into manageable pieces of work, aiding in planning and tracking progress.

@Jikazu and @dcsndevs, I think this one is nearly done but the styling just needs to be updated to reflect the currently colour scheme and style. You can also update the issue since we're using EmailJS. That lets us avoid having to create a Django model.


Update zio, zio-test, zio-test-junit, ... to 2.0.9

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-junit
dev.zio:zio-test-magnolia
dev.zio:zio-test-sbt

from 2.0.6 to 2.0.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #125.

Superseded by #126.


Fix typo

Hi @drgarcia1986,
Thanks for making this package! It's simplified the way I manage settings in a few of my projects.
I've noticed a small gramatical error, so I've made a PR to correct it.
Cheers!
Craig

Hi @jakul , thanks a lot for the feedback, I'm very happy to know that you like "simple-settings".
I'll open a PR to main repo and merge it.
Cheers


[FLINK-1553] [streaming] Reworked Kafka connectors

I refactored the Kafka connectors. It works parallelly: output gets distributed between Kafka partitions by default, and users can also add a custom partitioning function.

LGTM at first view. Could you please update the documentation accordingly?

Well, the code does not compile: https://travis-ci.org/apache/flink/jobs/51825098

Sorry, I accidentally used a class only available in Java 8, and did not wait for the Travis build.
I fixed it. Travis still fails, but on an unrelated issue (see https://travis-ci.org/apache/flink/jobs/52101969).


add doc for mautic/mautic/10256

https://github.com/mautic/mautic/pull/10256

@RCheesley i've accepted your review + added a modification, actually i didn't use correct operator, it is including and excluding

Conflicts here too, sorry @npracht !


Eddi only works when it's the default profile

Unless I've missed some step, only if "Elite Dangerous" is the current profile do I get the responses. I see it loads, and the plugin and if I issue an eddi command I get a response. However, when I switch to one of my other profiles, none of the eddi commands work, even if I have the option set in that profile to include commands from the "elite dangerous" profile. Do you think that's eddi or Voice Attack?

EDDI is based on an event loop, so you need to ensure that when you start whichever profile you want to use EDDI's event loop is started.  You can find details on how to do this in the troubleshooting guide


[WIP] Issue DeprecationWarning regarding end of Python2 support

Issue #261

Thx, this is very important indeed.


Improve tests for Excludes

Please see the commit messages for details.

This change is

Merged, ignoring the unrelated error on AppVeyor.


Somke tests

Type of change

Enhancement / new feature

Description
Adds some initial system tests, specifically for Kafka and Zookeeper scale up/down and for OpenShift templates (that they can be used).
This is currently a WIP, so don't spend loads of time on review yet, porbably start by looking at KafkaClusterTest.java and OpenShiftTemplatesTest.java. The tests do work (at least with oc), and I think it's worth starting a conversation about the Junit runner approach. Also interested in what @asorokhtey and @serrss make of this.
The basic idea is that you write a normal Junit test, but run it with the StrimziRunner, which will create namespace according to @Namespace and create resources according to @Resources.  I'm thinking about a @KafkaCluster, etc, which would set up a Kafka cluster for you. This can't really be done using @Rule or @ClassRule because those don't have a guaranteed execution order when > 1 is used. You could achieve a similar kind of thing using a hierarchy of tests, with @Before and @After, and methods to execute resources then cleanup of those methods is a pain (cf. @Resources on a method) and you'd still need a Runner to support @OpenShiftOnly.
Still to do are:

[ ] Integration with CI
[x] Decide whether to support @KafkaCluster etc, and remove them if not

Checklist
Please go through this checklist and make sure all applicable tasks have been done

[X] Write tests
[X] Make sure all tests pass
[x] Check coding style
[x] Update documentation
[x] Check RBAC rights for Kubernetes / OpenShift roles
[X] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging

I think this is now ready for review. I will probably make some minor changes to how the CI integration works, but that's all I have planned at this point.

PS: Good job!

What I'm not sure I understand is the logic behind the structure in examples/. I get the install and openshift dirs. But shouldn't the resources dir be named kubernetes? Or what about renaming them to templates and configmaps?

What I found I needed to do was separate the installation of the cc and tc from the creation of example cms that they each consume. I could do this by saying exactly which files I wanted to use in @Resources, but it's simply a lot more convenient to just specify the directory. Likewise in docs I think it is clearer if you say "here's how we install the CC/TC" and then you can go in to "here's how we create a CM for the CC/TC to consume". I couldn't think of a better than that resources though :-(

Using the directories is fine. And we are not the first project to do this.
Really the only thing which doesn't fit for me is the resources name. I would either replace it for kubernetes, since these are essentially for Kubernetes. Or - if kubernetes would sound like it is fixed too much on the platform (since they actually work on OpenShift as well) - I would rename both of them to templates and configmaps. When I try to look at it as a user, I'm not sure I would understand what to expect in resources

In general, this is a really cool PR. The solution with annotations looks awesome! StrimziRunner realizes all necessary logic for the test configuration. Logic for before() after() looks really good. Having TestUtils class looks like the best practice which I read in the books, method waitFor() deserves respect. LGTM!


Switch to batch writing of scheduled task trigger history

Closing this as issue is resolved by https://github.com/web-scheduler/web-scheduler/pull/259 and https://github.com/web-scheduler/web-scheduler/pull/258


Update vendor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.599%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1104

Relevant Lines:
1884

💛  - Coveralls


Private invoices are not marked as private on lookup

Background
Looking up invoices that were created as "private" invoices does not reflect their private status as created.
Your environment

lnd - commit d4b042dc1946ece8b60d538ade8e912f035612fe
MacOS Mojave
btcd - commit 67e573d211ace594f1366b4ce9d39726c4b19bd0

Steps to reproduce

GRPC addInvoice - private set to `true
GRPC lookupInvoice - invoice id

Expected behaviour
Response should indicate that the invoice is a "private" invoice
Actual behaviour
Response indicates private is false

We use the exact same proto/struct for both the response and request. However, atm, we don't also include this value when printing out the response. This should definitely be made consistent, I've had a few other people bring this up in the past.

@Roasbeef Do you want me write the private setting into the invoice db bucket?
If so, we might need to add some nasty backward compatibility handling if we don't modify or delete the old invoices.
Alternatively, we could just set private to false if there are no route_hints, but that feels wrong imo.

Atm we don't store the private setting in the database. Is there a reason for not doing this?
My experimental code adds this setting to all new invoices before they are stored in the database. Because of this I'm forced to do some nasty tests to keep backward comparability when reading old invoices from the db, which would be nice to get rid of. I'm not sure how I should precede with this one.

--private is only indicating that private channels should be used as hop hints. There's no such thing as a private invoice I think.
With current lnd behavior if we want to make the lookup reflect the initial setting, we can just check if there are any routing hints in the invoice, meaning it was created with the --private option.

More clarity is needed on how exactly --private is supposed to behave.
If I have a node and it has only private channels, my invoice MUST use routing hints and lnd DOES append routing hints regardless of whether I use --private.
If I have a node and it only has public channels, my invoice doesn't need routing hints and lnd DOES NOT append routing hints regardless of whether I use --private.
If my node has both public and private channels, what should I expect the behavior of --private to be?
Testing a node with one public and one private channel to the same node, and lnd DOES append routing hints regardless of whether I use --private.
Testing a node with one public and one private channel to different nodes, and lnd DOES append routing hints regardless of whether I use --private.
The public and private channels are configured identically.
"version": "0.5.1-beta commit=v0.5.1-beta-rc2-4-gd6d833c2421f4a65c6db5190d1dcd73f549fbf70"


[CPU][RISC-V] Reenable MobileNetV2 int8 benchmarks.

It seems to be fixed by some upstream commit, and we no longer hit compilation errors.
Closes https://github.com/openxla/iree/issues/16061

That's hold this a bit, because it will need to be disabled after landing integrate. We can re-enable it soon.


AssertionError: ()

Nuitka:1.1.0
Python:3.11.0
PASS 1: 99.8%|████████████████████████▉| 536/537, abcTraceback (most recent call last):
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\__main__.py", line 138, in <module>
    main()
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\__main__.py", line 124, in main
    MainControl.main()
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\MainControl.py", line 924, in main
    main_module = _createNodeTree(filename=filename)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\MainControl.py", line 208, in _createNodeTree
    optimizeModules(main_module.getOutputFilename())
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\optimizations\Optimization.py", line 343, in optimizeModules
    finished = makeOptimizationPass()
               ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\optimizations\Optimization.py", line 333, in makeOptimizationPass
    current_module.setChild("functions", used_functions)
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\nodes\NodeBases.py", line 605, in setChild
    assert old_value is not value, value
AssertionError: ()

Can you double check the Nuitka version? or are you really using 1.1.0?

@KevinRodriguez777 this for me is a clear "invalid/delete" issue. I am not even sure 3.11 was actually supported very well in 1.1 at all.

In the template, we have made it clear, that not filling out the issue template is not acceptable. I am closing this kind of report as invalid. The main reason is that we do not want to be left guessing. For you it's easy to erase the issue template and expect us to ask you questions only as necessary, but we cannot do that. We would much rather wait for you to create a new report, fill out the template, or wait for somebody with the necessary skill to do it.
In short: No issue template, no fun. Therefore we are  likely just deleting the issue, as it serves as a bad example and detraction for searches.  And even worse, it might keep good reporters from reporting as is this "already known."

@kayhayen Could I ask you something in Chinese? I can't speak English well,because I'm a junior high school student in China.

I am no longer responding to private questions about Nuitka, because they
end up invisible to everybody else, risking repetition from my side. I am
also getting too many such questions. Therefore please raise it in the
Github issue tracker and I will probably reply. Also I cannot do better
Chinese than Google Translate anyways. There are Chinese groups using
Nuitka, search for them to help you raise a proper issue or resolve yours.
Yours, Kay
Am Sa., 17. Feb. 2024 um 13:10 Uhr schrieb Eric学编程 @.***

:

@kayhayen https://github.com/kayhayen Could I ask you something in
Chinese? I can't speak English well,because I'm a junior high school
student in China.
—
Reply to this email directly, view it on GitHub
https://github.com/Nuitka/Nuitka/issues/2715#issuecomment-1950007908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAH62DDSZD3I3OWOFZPYU3YUCMZRAVCNFSM6AAAAABDNGID5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGAYDOOJQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Multiple synaptic linkers not working

When attempting to use a synaptic mechanism containing multiple linkers, like:
@current += -IAMPAHB(X_post,w,s)
@ihb += IAMPAHB(X_post,w,s)

the linkers are not always replaced with the contents they are supposed to be replaced with. This is in part due to a small bug in Line 347 of dsGenerateModel.m. There is an additional unknown bug preventing linker replacement in the monitors of functions contained such a linker.

See https://github.com/asoplata/DynaSim/tree/iss477_syn_linkers for progress

Line 347 of dsGenerateModel.m.

note: line # has changed now

I think this issue is fixed now. @asoplata please reopen if you still can reproduce the issue


Add option to specify feature names in copod explanation plot

this adds the feature explained in issue #260:
Addition of an optional keyword argument feature_names allows to set custom labels on the x-axis of the plot.
All Submissions Basics:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

Pull Request Test Coverage Report for Build 1786

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.494%

Totals

Change from base Build 1761:
0.0%

Covered Lines:
4789

Relevant Lines:
5015

💛  - Coveralls


First steps toward Query Wrapper

** Why are these changes being introduced:

We need a query wrapper for Timdex

** Relevant ticket(s):

https://github.com/MITLibraries/timdex-ui/issues/19

** How does this address that need:

Adds http gem
Defines basic Query_Timdex_V2 model
Defines tests for the model

** Document any side effects to this change:

Oh, probably loads

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to Heroku Pipeline, Staging and Prod
[ ] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
NO
Includes new or updated dependencies?
YES

Pull Request Test Coverage Report for Build 9080cf167e988e0c8e545044dd342d4cef8cf20d-PR-23

9 of 12 (75.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-12.5%) to 87.5%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/models/query_timdex_v2.rb
9
12
75.0%

Totals

Change from base Build 8f8f2b40460ba508dcd3d4dd9e2024156a1fb4c7:
-12.5%

Covered Lines:
21

Relevant Lines:
24

💛  - Coveralls


Changelog difference displays "No changes" for old entries

Environment

Nautobot version (Docker tag too if applicable): 1.4.7
Python version: 3.10
Database platform, version: pgsql
Middleware(s):

Steps to Reproduce

Install an old (1.2.x) Nautobot version
Change some objects
Upgrade to the latest 1.4.x
Check the objects changelogs

Expected Behavior
Changelog difference is displayed

Observed Behavior
Changelog difference displays "No changes" or displays only the new version (for entries created in the latest Nautobot version)
Additional informations
This seems to be caused by https://github.com/nautobot/nautobot/commit/b44947ca5c2429f23033b810e0850c1b776fb8d5 + https://github.com/nautobot/nautobot/commit/fac90d29061825e5a14a36dffbd532ab578e37d5, where an new object_data_v2 is introduced (v1.3) and get_snapshots() (v1.4) uses this field at https://github.com/nautobot/nautobot/blob/v1.4.10/nautobot/extras/views.py#L1595 to display diff, without having fallback to object_data for older entries.

Possibly related to #1830 #1530


Error: table name must be a string or a builder

This error happened on the live environment, crashing the application. I have no further data on this. Is the table name checked before sending to sql? I.e.: can I send an API call with undefined as tablename?
/home/ubuntu/spot-server/node_modules/squel/dist/squel.js:371
            throw new Error("table name must be a string or a builder");
            ^

Error: table name must be a string or a builder
    at _class11._sanitizeTable (/home/ubuntu/spot-server/node_modules/squel/dist/squel.js:371:19)
    at _class11._table (/home/ubuntu/spot-server/node_modules/squel/dist/squel.js:1265:22)
    at _class11.from (/home/ubuntu/spot-server/node_modules/squel/dist/squel.js:1435:14)
    at _class53._this32.(anonymous function) [as from] (/home/ubuntu/spot-server/node_modules/squel/dist/squel.js:2722:27)
    at Object.getData (/home/ubuntu/spot-server/src/sql-driver.js:931:9)
    at /home/ubuntu/spot-server/src/main.js:104:36
    at Array.forEach (native)
    at child.Collection.(anonymous function) (/home/ubuntu/spot-server/node_modules/ampersand-collection/ampersand-collection.js:376:36)
    at Socket.<anonymous> (/home/ubuntu/spot-server/src/main.js:102:24)
    at emitOne (events.js:96:13)

What version of SPOT is this?
The commit id/branch you are using would help us a lot. Could you also give some information about your database?

Sorry I didn't get a notification of the comment. The commit hash is f9f5b7fa98db96d3c297f85f65dc53f3a296805f. Probably an old one, I didn't update the codebase in a while as I'm not sure the master branch is 100% stable all the time (maybe release tagging as 0.1.0 would be nice?)

Could you please try the release 0.1.0 or checkout the master branch?
It would also be easier to debug your problem if you can have a Postresql service running on your system. Please avoid using the old Docker setup.

any updates on the issue?

i managed to reproduce the issue; it is related to having no datasets enabled.
The issue is in spot-server; please update to the latest dev version


3 channel images

how can we use deep explain for 3 channel images with keras backend?

Exactly like for 1-channel images, except that attributions for the three channels should then be summed up together. See https://github.com/marcoancona/DeepExplain/blob/master/examples/mint_cnn_keras.ipynb

I was trying to use it for a dataset with only 2 classes.
I tried to run deepexplain for one single image of my datastet (The label of the image is 0)
`with DeepExplain(session=K.get_session()) as de:  # <-- init DeepExplain context
# Need to reconstruct the graph in DeepExplain context, using the same weights.
# With Keras this is very easy:
# 1. Get the input tensor to the original model
input_tensor = model3.layers[0].input
# 2. We now target the output of the last dense layer (pre-softmax)
# To do so, create a new model sharing the same layers untill the last dense (index -2)
fModel = Model(inputs=input_tensor, outputs = model3.layers[-2].output)
target_tensor = fModel(input_tensor)

xs = img_tensor
y_test= np.array([0])
ys=y_test

attributions_gradin = de.explain('grad*input', target_tensor, input_tensor, xs, ys=ys)
#attributions_sal   = de.explain('saliency', target_tensor, input_tensor, xs, ys=ys)
#attributions_ig    = de.explain('intgrad', target_tensor, input_tensor, xs, ys=ys)
#attributions_dl    = de.explain('deeplift', target_tensor, input_tensor, xs, ys=ys)
#attributions_elrp  = de.explain('elrp', target_tensor, input_tensor, xs, ys=ys)
#attributions_occ   = de.explain('occlusion', target_tensor, input_tensor, xs, ys=ys)`

but I keep getting the following error
`---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
 in ()
13     ys = y_test
14
---> 15     attributions_gradin = de.explain('grad*input', target_tensor, input_tensor, xs, ys=ys)
16     #attributions_sal   = de.explain('saliency', target_tensor, input_tensor, xs, ys=ys)
17     #attributions_ig    = de.explain('intgrad', target_tensor, input_tensor, xs, ys=ys)
/content/src/deepexplain/deepexplain/tensorflow/methods.py in explain(self, method, T, X, xs, ys, batch_size, **kwargs)
619     def explain(self, method, T, X, xs, ys=None, batch_size=None, **kwargs):
620         explainer = self.get_explainer(method, T, X, **kwargs)
--> 621         return explainer.run(xs, ys, batch_size)
622
623     @staticmethod
/content/src/deepexplain/deepexplain/tensorflow/methods.py in run(self, xs, ys, batch_size)
212     def run(self, xs, ys=None, batch_size=None):
213         self._check_input_compatibility(xs, ys, batch_size)
--> 214         results = self._session_run(self.explain_symbolic(), xs, ys, batch_size)
215         return results[0] if not self.has_multiple_inputs else results
216
/content/src/deepexplain/deepexplain/tensorflow/methods.py in _session_run(self, T, xs, ys, batch_size)
149
150         if batch_size is None or batch_size <= 0 or num_samples <= batch_size:
--> 151             return self._session_run_batch(T, xs, ys)
152         else:
153             outs = []
/content/src/deepexplain/deepexplain/tensorflow/methods.py in _session_run_batch(self, T, xs, ys)
133         if self.keras_learning_phase is not None:
134             feed_dict[self.keras_learning_phase] = 0
--> 135         return self.session.run(T, feed_dict)
136
137     def _session_run(self, T, xs, ys=None, batch_size=None):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py in run(self, fetches, feed_dict, options, run_metadata)
927     try:
928       result = self._run(None, fetches, feed_dict, options_ptr,
--> 929                          run_metadata_ptr)
930       if run_metadata:
931         proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)
/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py in _run(self, handle, fetches, feed_dict, options, run_metadata)
1126                              'which has shape %r' %
1127                              (np_val.shape, subfeed_t.name,
-> 1128                               str(subfeed_t.get_shape())))
1129           if not self.graph.is_feedable(subfeed_t):
1130             raise ValueError('Tensor %s may not be fed.' % subfeed_t)
ValueError: Cannot feed value of shape (1, ) for Tensor 'Placeholder_31:0', which has shape '(?, 512)'`


Made assembly so that we can get parts.

Add get_part and get_part_by_no to assembly. This allow one to get a part by name or parts by type after you have added it to the assembly. Add get_name to CycadPart, to generate the part_name.
The get_name code started off as part of assembly but I thought one might have a need to customize it, a small positive side effect of hosting the name generation in the Part is that one can now customize part names per part type, and its not the assemblies problem.
I would have like to add a bom() method to assembly or a flag to the save method save(*,bom=False) to generate the Bill Of Material. But Id like it to be generated some standardized format and I have not research how such a format would look.

Will a bill of materials give an estimate as to how much sheetmetal and plastic is necessary to build the chasis or is it more how many conncubes and drive holders are needed?

Will a bill of materials give an estimate as to how much sheetmetal and plastic is necessary to build the chassis or is it more how many conncubes and drive holders are needed?
The BOM could give both.  There are two stages design (CAD) and manufacture (CAM).
For CyCAD it will just be quantities. So we know how much to manufactured.
For CyCAM it will be duration of print, filament length, volume of plastic, weight, cost ratio.  What is the cost of Manufacture (for 3D printing the slicer gives us most of the results), for laser cutting and milling we will figure it out.


KAFKA-10572 mirror-maker config changes for KIP-629

This change implements the KIP-629 changes for mirror maker configuration with backwards compatibility.
cc @rhauch

thanks for fixing the formatting @rhauch, feel free to merge

Rebased to get recent changes to fix the PR builds. Previous build was green prior to my minor indentation changes, but I'll give this build a chance before merging.


Improve "Item avail by." extensibility

Move variables to "protected var"

page 99000902 "Item Availability Line List":

    var
        ItemLedgerEntry: Record "Item Ledger Entry";
        SalesLine: Record "Sales Line";
        ServLine: Record "Service Line";
        JobPlanningLine: Record "Job Planning Line";
        PurchLine: Record "Purchase Line";
        TransLine: Record "Transfer Line";
        ReqLine: Record "Requisition Line";
        ProdOrderLine: Record "Prod. Order Line";
        ProdOrderComp: Record "Prod. Order Component";
        PlanningComponent: Record "Planning Component";
        AssemblyHeader: Record "Assembly Header";
        AssemblyLine: Record "Assembly Line";
        AvailType: Option "Gross Requirement","Planned Order Receipt","Scheduled Order Receipt","Planned Order Release",All;
        Sign: Integer;
        QtyByUnitOfMeasure: Decimal;

        Text000: Label '%1 Receipt';
        Text001: Label '%1 Release';
        Text002: Label 'Firm planned %1';
        Text003: Label 'Released %1';

    protected var
        Item: Record Item;

page 353 "Item Availability Lines":

    var
        DateRec: Record Date;
        ItemAvailFormsMgt: Codeunit "Item Availability Forms Mgt";
        PeriodFormLinesMgt: Codeunit "Period Form Lines Mgt.";

    protected var
        Item: Record Item;
        PeriodType: Enum "Analysis Period Type";
        AmountType: Enum "Analysis Amount Type";

Additional context
Explain why you need this request to be fulfilled. This will help Microsoft assess, if your request could get solved in other ways.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 12965.


App Getting Crash with phoneNumber verification function After adding phone number in FirebasePlugin.verifyPhoneNumber() with 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'

App Getting Crash with phoneNumber verification function , After Adding phone number in FirebasePlugin.verifyPhoneNumber function getting below error:
[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0
2020-12-22 14:41:23.809805+0530 2MIL[63531:1837469] * Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'

First throw call stack:
(
0   CoreFoundation                      0x00007fff2041daf2 __exceptionPreprocess + 242
1   libobjc.A.dylib                     0x00007fff20177e78 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff2042c6f7 +[NSObject(NSObject) instanceMethodSignatureForSelector:] + 0
3   CoreFoundation                      0x00007fff20422032 forwarding + 1489
4   CoreFoundation                      0x00007fff20424068 _CF_forwarding_prep_0 + 120
5   2MIL                                0x000000010a2e6876 -[FIRPhoneAuthProvider internalVerifyPhoneNumber:UIDelegate:completion:] + 118
6   2MIL                                0x000000010a2e5c68 __64-[FIRPhoneAuthProvider verifyPhoneNumber:UIDelegate:completion:]_block_invoke + 280
7   libdispatch.dylib                   0x000000010bcae7ec _dispatch_call_block_and_release + 12
8   libdispatch.dylib                   0x000000010bcaf9c8 _dispatch_client_callout + 8
9   libdispatch.dylib                   0x000000010bcb6296 _dispatch_lane_serial_drain + 796
10  libdispatch.dylib                   0x000000010bcb6f67 _dispatch_lane_invoke + 439
11  libdispatch.dylib                   0x000000010bcc2de2 _dispatch_workloop_worker_thread + 882
12  libsystem_pthread.dylib             0x00007fff5e739a3d _pthread_wqthread + 290
13  libsystem_pthread.dylib             0x00007fff5e738b77 start_wqthread + 15
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'
terminating with uncaught exception of type NSException
CoreSimulator 7<IP_ADDRESS> - Device: iPhone 12

Plugin versions:
<EMAIL_ADDRESS>Installed platforms:
Ios 5.1.0
cli packages: (/usr/local/lib/node_modules)
@ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2

global packages:
Cordova CLI : 9.0.0<EMAIL_ADDRESS>

local packages:
@ionic/app-scripts : 3.1.11
Cordova Platforms  : ios 5.1.0
Ionic Framework    : ionic-angular 3.9.2

System:
ios-deploy : 1.11.3
Node       : v8.9.3
npm        : 5.5.1
OS         : macOS
Xcode      : Xcode 12.2 Build version 12B45b

Also Tried to use different version of plugin<EMAIL_ADDRESS><EMAIL_ADDRESS>but getting same error

App Getting Crash with phoneNumber verification function , After Adding phone number in FirebasePlugin.verifyPhoneNumber function getting below error:
[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0
2020-12-22 14:41:23.809805+0530 2MIL[63531:1837469] * Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'

First throw call stack:
(
0   CoreFoundation                      0x00007fff2041daf2 __exceptionPreprocess + 242
1   libobjc.A.dylib                     0x00007fff20177e78 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff2042c6f7 +[NSObject(NSObject) instanceMethodSignatureForSelector:] + 0
3   CoreFoundation                      0x00007fff20422032 forwarding + 1489
4   CoreFoundation                      0x00007fff20424068 _CF_forwarding_prep_0 + 120
5   2MIL                                0x000000010a2e6876 -[FIRPhoneAuthProvider internalVerifyPhoneNumber:UIDelegate:completion:] + 118
6   2MIL                                0x000000010a2e5c68 __64-[FIRPhoneAuthProvider verifyPhoneNumber:UIDelegate:completion:]_block_invoke + 280
7   libdispatch.dylib                   0x000000010bcae7ec _dispatch_call_block_and_release + 12
8   libdispatch.dylib                   0x000000010bcaf9c8 _dispatch_client_callout + 8
9   libdispatch.dylib                   0x000000010bcb6296 _dispatch_lane_serial_drain + 796
10  libdispatch.dylib                   0x000000010bcb6f67 _dispatch_lane_invoke + 439
11  libdispatch.dylib                   0x000000010bcc2de2 _dispatch_workloop_worker_thread + 882
12  libsystem_pthread.dylib             0x00007fff5e739a3d _pthread_wqthread + 290
13  libsystem_pthread.dylib             0x00007fff5e738b77 start_wqthread + 15
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'
terminating with uncaught exception of type NSException
CoreSimulator 7<IP_ADDRESS> - Device: iPhone 12

Plugin versions:
<EMAIL_ADDRESS>Installed platforms:
Ios 5.1.0
cli packages: (/usr/local/lib/node_modules)
@ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2

global packages:
Cordova CLI : 9.0.0<EMAIL_ADDRESS>

local packages:
@ionic/app-scripts : 3.1.11
Cordova Platforms  : ios 5.1.0
Ionic Framework    : ionic-angular 3.9.2

System:
ios-deploy : 1.11.3
Node       : v8.9.3
npm        : 5.5.1
OS         : macOS
Xcode      : Xcode 12.2 Build version 12B45b

Also Tried to use different version of plugin<EMAIL_ADDRESS><EMAIL_ADDRESS>but getting same error

Is it always crashing or random crashing?

App Getting Crash with phoneNumber verification function , After Adding phone number in FirebasePlugin.verifyPhoneNumber function getting below error:
[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0
2020-12-22 14:41:23.809805+0530 2MIL[63531:1837469] * Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'

First throw call stack:
(
0   CoreFoundation                      0x00007fff2041daf2 __exceptionPreprocess + 242
1   libobjc.A.dylib                     0x00007fff20177e78 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff2042c6f7 +[NSObject(NSObject) instanceMethodSignatureForSelector:] + 0
3   CoreFoundation                      0x00007fff20422032 forwarding + 1489
4   CoreFoundation                      0x00007fff20424068 _CF_forwarding_prep_0 + 120
5   2MIL                                0x000000010a2e6876 -[FIRPhoneAuthProvider internalVerifyPhoneNumber:UIDelegate:completion:] + 118
6   2MIL                                0x000000010a2e5c68 __64-[FIRPhoneAuthProvider verifyPhoneNumber:UIDelegate:completion:]_block_invoke + 280
7   libdispatch.dylib                   0x000000010bcae7ec _dispatch_call_block_and_release + 12
8   libdispatch.dylib                   0x000000010bcaf9c8 _dispatch_client_callout + 8
9   libdispatch.dylib                   0x000000010bcb6296 _dispatch_lane_serial_drain + 796
10  libdispatch.dylib                   0x000000010bcb6f67 _dispatch_lane_invoke + 439
11  libdispatch.dylib                   0x000000010bcc2de2 _dispatch_workloop_worker_thread + 882
12  libsystem_pthread.dylib             0x00007fff5e739a3d _pthread_wqthread + 290
13  libsystem_pthread.dylib             0x00007fff5e738b77 start_wqthread + 15
)
libc++abi.dylib: terminating with uncaught exception of type NSException
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull length]: unrecognized selector sent to instance 0x7fff8002ebb0'
terminating with uncaught exception of type NSException
CoreSimulator 7<IP_ADDRESS> - Device: iPhone 12

Plugin versions:
<EMAIL_ADDRESS>Installed platforms:
Ios 5.1.0
cli packages: (/usr/local/lib/node_modules)
@ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2

global packages:
Cordova CLI : 9.0.0<EMAIL_ADDRESS>

local packages:
@ionic/app-scripts : 3.1.11
Cordova Platforms  : ios 5.1.0
Ionic Framework    : ionic-angular 3.9.2

System:
ios-deploy : 1.11.3
Node       : v8.9.3
npm        : 5.5.1
OS         : macOS
Xcode      : Xcode 12.2 Build version 12B45b

Also Tried to use different version of plugin<EMAIL_ADDRESS><EMAIL_ADDRESS>but getting same error

Is it always crashing or random crashing?

it crashes every time when try to login with FirebasePlugin.verifyPhoneNumber function

it crashes every time when try to login with FirebasePlugin.verifyPhoneNumber function

it crashes every time when try to login with FirebasePlugin.verifyPhoneNumber function

Check with the gradle dependencies implementation "com.google.firebase:firebase-auth: version_number"

it crashes every time when try to login with FirebasePlugin.verifyPhoneNumber function

Check with the gradle dependencies implementation "com.google.firebase:firebase-auth: version_number"

FirebasePlugin.verifyPhoneNumber function running perfectly for Android , i am facing issue for ios only

Hello,
I am getting exactly the same error. I checked push certificates on Firebase Console. They are properly configured and app receives push notifications. But VerifyPhoneNumber() causes this error and the app terminates.
Are you willing to solve this issue any time soon?

I was having the same issue but in 8.0.0 there was a breaking change to FirebasePlugin.verifyPhoneNumber. Not sure if the function call changed there however it did change at some point.
So I was calling the function like that give me your exact error
 window.FirebasePlugin.verifyPhoneNumber(phoneNumber, timeoutDuration, function (credential) { }, function (error) { });

but nowdays it should be called like:
 window.FirebasePlugin.verifyPhoneNumber(function (credential) { }, function (error) { }, phoneNumber, timeoutDuration);

I had the same problem. Worked perfectly on android but not on ios.
In my case the reason was that credential.code was set as integer instead of string.
After changing credential.code to string it worked.


test_import_export: Add test coverage for OnboardingUserMessage.

https://github.com/zulip/zulip/pull/30922#issuecomment-2231367963

We generally do try to add test coverage when adding to the export tool; maybe you can do a quick follow-up that adds to the base data for the data import/export

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @prakhar1144!


Correction for raw affiliation Ecole d’urbanisme de Paris, France

Correction needed for raw affiliation Ecole d’urbanisme de Paris, France
raw_affiliation_name: Ecole d’urbanisme de Paris, France
new_rors:
previous_rors: 03mwypp50
works_examples: W4389616018
contact: cb6b7badc9b40434531acd1ea3cd82bf:ec14562117b11951a4162d69149ebc @ recherche.gouv.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


TechZone Website Down

The TechZone landing page and links to TechZone collections are down.

Hi @DimSumDev our TechZone Status website didn't capture that yesterday. Have you tried again recently?


All: IOS and Chrome can see each other when setting to H264/VP8

Description
All: IOS and Chrome can see each other when setting to H264/VP8
Biz: Fix panic bug
Reference issue
Fixes #89

LGTM!


update repos example to use RateLimits

The RateLimit() func is deprecated, and should not appear in the
official example.
Ref: http://godoc.org/github.com/google/go-github/github#Client.RateLimit

thanks!  rebased onto master and merged as 3ec5f1a72fe1c26a8a7abeefcabbd2e9f6153d99


Add title/author for custom blockquote

hello,
Thank you for your great project. I want to add feature on custom flexmark-java blockquote, but i d'ont know i can't do this.
I want to add meta informations on many blocks. My first try concern blockquote. For this mardown code :
> I'll be back
source : **Arnold Schwarzenegger**

i want this html code :

I'll be back

Arnold Schwarzenegger

Can't you give me some advice for do this ?
I i try to parse any source: xxx on Parser, it hit also source: xxx in text without > blockquote marker .
Than you.

@firm1, one way to handle this, is as a paragraph pre-processor.
Paragraph pre-processor is invoked after the document is parsed to allow "special" processing of leading paragraph lines.
Table extension does its processing as a paragraph processor, so is the Definition extension.
All you would need to do is check if the previous sibling to the paragraph is a block quote. One thing to keep in mind for block quotes, is that they can continue to the next line as a lazy continuation even if the next line does not have the block quote marker. Check the options parser starting with BLOCK_QUOTE_.
I would recommend to either ensure that block quotes do not do lazy continuation or change your syntax to include a blank line after the block quote and the source marker line. Or alternately, allow the last line in the block quote that starts with source: to be used as the source line.
You can also consider other similar syntax variations:

As is, most complicated because of variability
> asdfsadfsadfdsadfs
source: author

Always next paragraph
> asdfa fdlasdfjlasdfdsf

source: author

Always last paragraph of block quote
> asdfa sfdasdf sa df dfsa
> source: author

Option 3 is easier to manipulate because the marker node is always part of the block quote. It only needs to be split from the end of the last paragraph into its own paragraph and given an attribute. All this can be done as part of a node post processor on block quote nodes.
Option 1 without lazy continuation and option 2 always, require moving the marked text, inside the block quote and adjusting the block quote text span to include these nodes (call node.setCharsFromContent() on the block quote after manipulation).
You will also need to either add a custom node and your own node renderer to handle the special paragraph, or an attribute provider and return the special attribute when passed the node of paragraph with the source marker.
All depends on what syntax options you settle on.
The most robust way, and probably the most complicated way is to disable the core block quote parser and add your own that will handle the extra line after the block quote as a special line.
General overview of parsing phases and extension writing: https://github.com/vsch/flexmark-java/wiki/Writing-Extensions


Update XinputAPI to allow support for more than 4 controllers

I am working on a game that has 8 player local functionality but unfortunately, I keep running into a barrier due to the current XInput API being used in glfw.
The XInput API only supports up to four controllers connected at any time.
XInput API Documentation stating only 4 controllers supported
A way around it is using the new Microsoft GameInput API, which is supported on Windows 7 and up.
GameInput porting guide

There is also the OpenXinput project.
OpenXinput Github
But is still on it's early stages.
It's lead by Nemirtingas someone who has good experience in reverse engineering.
Thank you.

GameInput support definitely needs to be added. Thank you for creating an issue for it!

GameInput support definitely needs to be added. Thank you for creating an issue for it!

No problem!


chore(sdk): add helper trait to node API to simplify type definition

Ref https://github.com/paradigmxyz/reth/issues/9555
Building unit tests for any type that inherits from FullNodeComponents is too costly. Replacing the trait bound N: FullNodeComponents with N: NodeCore in type definitions, enables testing without importing a massive framework of unused mock node components. This, without scarfing the aggregate generic N for a long list of generics and with it DevX.

Adds helper traits reth_node_api::NodeCore and reth_node_api::NodeTy, with blanket implementation for all types that impl reth_node_api::FullNodeComponents and reth_node_api::NodeTypes respectively.
Replaces reth_optimism_rpc::OpEthApi<N: FullNodeComponents> with OpEthApi<N: NodeCore>

it's not possible to move the helper traits NodeCore and NodeTy into rpc crates because it creates a cyclical dependency in blanket impl of helper traits for all types that impl reth-node-api traits @mattsse

it's not possible to move the helper traits NodeCore and NodeTy into ~rpc crates~ reth-rpc-eth-api because it creates a cyclical dependency in blanket impl of helper traits for all types that impl reth-node-api traits @mattsse . which crate do you want it moved to?

removed re-export from reth-rpc-eth-api and reth-rpc-api from reth-node-core and reth-node-api, in order to move RpcNodeCore trait into reth-rpc-eth-api @mattsse
not sure what's the root of the cargo hack check bug @Rjected

pub enum JwtError {
       | ----------------- doesn't satisfy `_: Into<Box<dyn Error + Send + Sync>>`

ah I think the alloy-rpc-types-engine dep in node-core just lacks the "std" feature, imo this is actually an alloy issue


Missing context validation

A rule matching the behaviour of prop-types, but for context, would be useful. It could probably work exactly the same.

I hacked (and I mean hacked) this by taking eslint-plugin-react's prop-types rule and replacing a bunch of strings in it. If you're in a rush: https://github.com/eteeselink/eslint-plugin-react-context
@yannickcr I'd be happy to contribute this back. My idea is to make prop-types.js parameterized, i.e. remame it to prop-or-context-types.js and wrap the existing code in a function. Two new files just call the function a la
module.exports = require('./prop-or-context-types')('props','propTypes',/^props\s*(\.|\[)/);

Do you like this approach?

@eteeselink Every effort to avoid code-duplication is helpful :)
I did not get a look at your code (yet) but I'll try look at it very shortly.

@eteeselink Not sure if you're interested in bug reports on the react-context plugin at this point, but in my testing is is mis-reporting props for functional stateless components as missing in context validation. Otherwise it seems to be working fine for classes and createClass.

@ahutchings Thanks for getting in touch! In fact, i've found react-context to be pretty bad in practice, and I totally forgot to notify you guys here - sorry! That's not very nice of me.
Besides functional stateless components, there were a whole bunch of problems it wouldn't catch, and creating a more useful plugin than the search/replace hack I made turned out to cost time I didn't have at the time.
My recommendation: ignore my fork. If we're going to do contextTypes validation with eslint, we need a better approach.

Hi guys, any news about this?

I'd love to review a PR for it

Hmm, this should almost be trivial now by parameterizing prop types detection with the names for props -> context, propTypes -> contextTypes? Assuming old context lives long enough for this rule to pay for itself 😄

It will; there’s plenty of people still on React 15 even.


Update debezium-ui.adoc

Change documentation to reflect code

Good catch, thx! This already got fixed on main (i.e. nightly docs) in more extended way, so I have just cherry-picked that change to 1.8, it will be live in a bit. Thus closing this one.


Script.resource_name always contains blank string

Operating system or device, Godot version, GPU Model and driver (if graphics related):
a26b36bec2e99a128b7a61ff9fa1e2e46148f547
Issue description:
Whenever you try to .get_script().resource_name, the variable only contains blank string. However resource_path always return valid path.
Steps to reproduce:

Attach script with this line code
print(get_script().resource_name)
See on the console, doesn't print anything

Run this demo, resouce_name will not print anything, but resource_path is print the right path
Demo : resource_name_blank_string.zip

Is resource name used at all internally? Otherwise the field should just be removed

If you look at the script on the Inspector, you'll see that the resource name is empty. Since GDScript files contain only code, not metadata, it'll never save the resource name even if you set it. This is not the same for other types of resources, so it may be useful for those.
I don't know what you are expecting to get from the resource_name property of a script.

Hmmm, If I remember correctly. I want to get the resource_name of the script to know if the node is Player or Enemy. So basically I have Script character_controller and Player and Enemy inherit from it. But I found a solution, I can set_meta() to know what is the node type exactly.

get_script() returns only the current script, which knows nothing about the node it's attached to (because the same script can be attached to multiple nodes).

I can't check right now, but I think built-in scripts do use resource_name.

@vnen Should we just document this then and close this and https://github.com/godotengine/godot/pull/14774 as not a bug?

@mhilbrunner I'm not sure. #14774 uncomments a line that would fix this, but I'm not sure why it was commented out in the first place.

The plan for 3.2 is to outright get rid of resource_name.

So are we still getting rid of it for 3.2 or moved to 4.0?

4.0 I guess, there is little need to break compat in 3.2 for it as it's only cosmetic.

I would actually prefer that resource_name be kept, since it serves a purpose in the inspector for local resources:

If it's removed, these resources would instead wind up looking like this:

As you can see, it's considerably more difficult to remember which resource is which, as I'm just memorizing some index on some array (which I'm probably not going to do and instead I'll wind up opening each resource one by one to get an idea of that resource's contents.)  I could just save each resource to disk to give them a name but the idea here is to not clutter the file system with these little resources (as there's going to be hundreds of them in this game, and all they really do is provide some name and description.)
I think it would be better to make it clear in resource_name's tooltip that it's meant for editor-use only, rather than removing it all together.  Better yet is to re-enable resource_name's functionality so I don't have to write export var display_name := "" in all my resources, and just exempt those resources which don't store resource_name, like .gd and .cs files, perhaps with a warning or error when attempting to get it.

I use resource_name in my custom editor and resource_name displays in inspector, when I call inspect_object(my_resource)

I make use of resource_name to figure out what Material I am looking at. If you remove this I would have to parse resource_path to try and infer the material name and if no resource_path then I would need to get shader_param texture path and parse that and extract the name from there.  I would actually prefer the ability to set (optionally) set resource_name on any game resource.

Looks like exporting a script with export var script2 :Script currently (3.2) results in this editor display:

As noted in the bug, setting the resource_name of the script doesn't get saved. (It may show for a bit, till you restart the editor to clear the cache.)
If I'm not mistaken, the main issue is that the actual on-disk representation of the script is not a toml file, but just the script itself. Scripts have a custom importer that just uses the script itself. If I'm right, that would mean the resource_name would need to be saved somewhere in the script itself. Using class_name as the resource_name is a fairly obvious candidate. As a side note: Changing 'resource_name' in the editor would still be problematic, as it would be way to hard to parse/edit reliably (due to comments and \, etc.)
TLDR;  Loading class_name into resource_name seems like a decent way to go.

As a side note, I'm surprised that the class_name is not available anywhere on the GDScript object. I would have expected it to be a field on the GDScript. I imagine if it isn't added as the resource_name, we may wanna make a feature request to add it. (Not sure it could be added to Script itself, as other scripting languages may not quite fit in that way.)


Fixes RHOARDOC-1104. Added link to booster for example project. Updat…

…ed procedure to make it more correct

@inoxx03 @tradej @huntley @Ladicek let me know what you think

I think it looks good, a couple of small nits:

An existing Spring Boot application can simply be A Spring Boot application (remove 'existing')
Step 1 refers to 'your pom.xml' and step 2 refers to 'in the pom.xml of your project'. Assuming we only taking about one, I would the wording for step 2 first and thereafter refer to 'the pom.xml' for this procedure.

@huntley good point on the wording changes:) I'd personally be a little more explicit and say something like:

... in the pom.xml file of your project
the first time  and then say
...the pom.xml file
or even
the POM file
for each subsequent reference to the same file.

WDYT?
Otherwise, LGTM

thank you for the feedback @huntley @inoxx03
updated per feedback
let me know what you think

@tradej @inoxx03 updated per feedback.
If it looks good, feel free to merge.

merged.


Update contract model & fix typo

This adds a Rust model checker that is better suited to describing epoch collection than TLA+.

No need to review the Rust code I've added here. Just including it along with the TLA+ stuff since it was used to debug the algorithm.


Add Distributed Tracing semantics

Add Distributed Tracing semantics to the following APIs:

ISemanticContext - allows to set (optional) Distributed Tracing context on all events emitted by ILogger
ability to use env_dt aliases to customize TraceContext of individual events running in a given scope. That allows manual nesting of a child span to a parent span.
semantic context projection for C++/CL/CX apps on Windows
add test that emits two events with DT semantics

PR adds "common" fields:

env_dt_traceId
env_dt_spanId
env_dt_traceFlags
Part B parentId

And the set of corresponding high-level API setters at context-level:

SetTraceId
SetSpanId
SetTraceFlags
SetParentId

which are styled in the same way as other common context setters are presently styled, in uniform fashion.
How to use it:

events land in Aria-Kusto (Aria schema) or Custom Kusto (common schema), and could be subsequently routed to Geneva via 1DS-Interchange (Geneva schema).
events landing in Geneva have the required ext.dt extension semantics, just enough for the Trace Explorer view to work.. Less duration semantics: since 1DS in principle does not require client events to have "duration", start / end / scope. Events are timepoints that carry timestamp and name. How exactly to remap these, i.e. what would/could/should be considered duration - is out-of-scope of this PR. A separate routing example would be provided elsewhere, out-of-scope for Client Telemetry repo.

How this could be improved further:

There's no helper for formatting individual W3C TraceContext fields here. Users may use whatever standard formatter of their choice, e.g. taking a dependency on OpenTelemetry API for well-formed context of trace parent header values. In our org scenario we don't need it - since we are utilizing existing .NET APIs that already give us the access to values in the proper format. So we're only calling into 1DS C++ SDK via projection to set and send the well-formed values we need. We do not require manual formatting of these values in C++ land at all.
Should someone need to learn how to do this formatting in C++ - please refer to the OpenTelemetry C++ code here, that illustrates how to format TraceId and SpanId to hexadecimal string values.

Example showing how events look when traced from client to service in one Kusto table:

APITest verifies the basic functionality. More complex usage examples are not presently a priority for our team, since in our case we use the higher-level .NET StartActivity API while interacting with remote service instrumented with OpenTelemetry, and supplement the existing client telemetry events with correlation identifiers that follow Common Schema naming, specifically Common Schema -to- Geneva mapping.
Separate additional work could be done later - to add Span and Log semantics, allowing to use 1DS SDK as a lower-level transport channel / exporter for OpenTelemetry SDK. Presently this additional work is out-of-scope.

Most of the attributes/fields defined in the ISemanticContext interface are not going to change after bootstrapping of SDK.  Does Distributed Tracing attributes fit in this category - as trace_id/ span_id could change based on the context where Logger::LogEvent() is called.
Should we instead have an overloaded Logger::LogEvent method which accepts trace context. Something similar to how it is done in OpenTelemetry logging api - https://github.com/open-telemetry/opentelemetry-cpp/blob/389b84f4303f728c97dcf8194f76277488e18cf4/api/include/opentelemetry/logs/logger.h#LL59C3-L59C3

@maxgolov - Do you plan to address the concerns raised in this PR, and make it ready for merge. Thanks.

@lalitb
I'd like to address some comments from reviewers, i.e.

adding a method that allows to set both TraceId+SpanId at once
possibly exposing a method like this to higher-level apps (I need it to work via C API too)

Apologies for keeping it open for so long. It's coming soon.


provided gateway dataplane show as type: standard in the gateway type

What happened?
This should like be provided or something like this.

Doesn't seem to be a problem anymore


Added seperate blog page

Related Issue
#463
Description
I created a separate blog page and added two other blogs to the page, check below ss.
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

on clicking ..moreblogs user can go to blog page

below are blogs on Smart Farming and AI in farming.(created using HTML and CSS).

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]
@Suchitra-Sahoo
Please merge it.
Thank YOU!

@Hemav009 currently i don't want you to add new blogs. Write blogs for already existing topics in blog section. Also you have created seperate pages which opens when the user goes to blogs section and click on any particular card. But i wanted you to make a separate blog page which gets activated when user clicks on blog option of navbar. Then the user should click on the desired topic card which opens the page in which you will write your own blog.

YES all the 12

https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/109607812/9423a0a2-f55c-4e98-ad3a-81276453d14d
is this ok?

Raise another PR with fresh changes.


Include correct list of discriminator information

Fixes https://github.com/microsoft/OpenAPI.NET.OData/issues/219
Retrieve list of derived types for structured types and adds it to the mapping property of the discriminator object.

@irvinesunday @millicentachieng FYI I just approved the CD, the nuget should be available in 10 minutes

@irvinesunday @millicentachieng FYI I just approved the CD, the nuget should be available in 10 minutes

@baywet, we weren't intending to get 1.0.11-preview1 out yet with just this fix. There were a couple of other fixes that were meant to go out 1st before we do the release.

ah... sorry


Network Requirements: User would like to know why each domain is required/how it's used.

moved from balena-io/balena-site as a fix to the OS docs: https://github.com/balena-io/balena-site/issues/966
They were also asking what's the minimal requirement to just have the devices to work and what would stop working if they blocked one of the ones that we list.
See: https://www.balena.io/docs/reference/OS/network/2.x/#network-requirements

Thanks for making the issue, https://www.balena.io/docs/reference/OS/network/2.x/#network-requirements
This has been documented with each port mentioning what it supports.


Typescript errors: cannot read property 'length' of undefined for spread operator, incompatibility from 3.5.1 to 3.6.3

Upgraded TypeScript library to the latest recently. Found an incompatibility issue going from 3.5.1 to 3.6.3 .
https://www.typescriptlang.org/play/index.html?target=1#code/GYVwdgxgLglg9mABAGTgcwBQFMBuWxQAqAngA5YBciAzlAE4xhoA0iu+UAkgCJUCGYYqzB8AtpRr1GLRMDh0IWAGIAbENQAWiAPxUARnDgqsA1gDoLAayzEAanzVYACnxh1qVWgyYBtALoAlIhUOHAwACaIAN4AUIjxiBAI1EZYZiroGABEABJYKhmIAOryKuFZAQDcMQC+MTFJYLSIGWho0tx8UHz8gogAvIjg4VjAjFjh1aiYAOQAwiowEJYzrDM5TquIWdQmChpK8qJZrPQgWGtgcCMAcmJYWzt7EBpydMdrpHx0HDfXWHdxI8AMrPDQGAAeJ0QMwgi2WAH0oGQHms3qIthZ0uh2kxOt0qkA
Make sure Target is ES5.
For 3.6.3 and up we get :
Uncaught TypeError: Cannot read property 'length' of undefined
at __spreadArrays (tsWorker.js:21)
at eval (eval at  (main-3.js:1239), :17:19)
at main-3.js:1239
For 3.5.1 and lower it passes without error.
SpreadArray function was introduced here, which triggers this exception: https://github.com/Microsoft/TypeScript/pull/31166
To be fair spread operator on undefined should fail! As undefined is not iterable.
Just reporting this issue for awareness, as originally did not check for undefined when using the spread operator as older versions of TypeScript did not catch this.
Not sure if this should be marked as a "bug"

To compare, running a simplified version of your code compiled to target esnext on Firefox and Node (both supporting spread operator):
function Log(...keyValuePairs: string[]) : void {
    console.log("Hello World");
}

const loggingData: any = undefined;
Log(...loggingData);

Playground
Firefox 76.0.1: TypeError: loggingData is undefined
Node 12.16.3: Uncaught TypeError: Log is not iterable (cannot read property Symbol(Symbol.iterator))
So typescript generated have a similar behavior as native support.


I wanna contribute to Trapping Rain Water Problem

Is your feature request related to a problem? Please describe.
Yes when ever I see the code samples being submitted and take a large time and space complexity.
Describe the solution you'd like
I considered using bubble sort for this problem and it reduced the complexity

Assigned!


Bluetooth: host stack is broken without CONFIG_ASSERT

The Bluetooth host stack doesn't implement enough error handling.
A lot of parameter and state checking happens using __ASSERT() macros.
This is a good thing, as it reduces the mental load of parsing error handling. That "error handling" usually results in a broken state somewhere else, leaks, etc..
So we need some sort of ASSERT() macro that is always enabled.
Two solutions:

convert all __ASSERT() macros to BT_ASSERT()
do a select ASSERT when Bluetooth is enabled

NB: in the future, that macro could be redirected to allow graceful shutdown of the Bluetooth thread, if running in userspace. That way an error condition in the stack will no longer bring down the entire kernel.

Would you please add steps to reproduce it?

Would you please add steps to reproduce it?

I believe this refers to cases like bt_conn_unref(NULL) evaluating to undefined behavior (UB) when asserts are off. The question is whether it's harmful to allow UB as a result of API misuse when asserts are off, in public API, or even internal API.
The argument is that developer time saved by catching these errors is well worth the extra bytes and cycles many times over. I agree. My opinion is that simple asserts should be on-by-default globally in Zephyr, and we maintainers should make sure assert expressions are not too expensive. Disabling asserts should be a this-train-needs-no-brakes move by those who are forced into that particular requirement and are ready to bear the cost of harder debugging.

Just some comments to take along:

Assertions in most languages are no-ops when disabled, and crash/abort if a predicate is false, so we shouldn't depend on it in production code.
If a public API has documented assumptions, developers should adhere to them, and add checks before calling the functions, assertions in the callee code are there to help developers point out invalid calls.
There is also CHECKIF that can be used as an assertion check or a runtime check (enabled by default with USERSPACE).

Just some comments to take along:
* [Assertions](https://en.wikipedia.org/wiki/Assertion_(software_development)) in most languages are no-ops when disabled, and crash/abort if a predicate is false, so we shouldn't depend on it in production code.

* If a public API has documented assumptions, developers should adhere to them, and add checks before calling the functions, assertions in the callee code are there to help developers point out invalid calls.

* There is also `CHECKIF` that can be used as an assertion check or a runtime check (enabled by default with `USERSPACE`).

I agree with you on all points. I think the issue here is: What should we recommend to our users? Asserts always on? Or asserts off in production? A default config is a pretty strong recommendation, so we should give it some consideration.
I'm of the opinion that asserts enabled in production is a good thing by default. And those who have special needs can make the choice for themselves. So I wish we could turn the tide and enable asserts by default for all of Zephyr.

Some data for @Thalley . I was expecting more asserts than that 😅
The point is, maybe we should have a IF_RETURN(condition, message, retval) macro for the common pattern of checking parameters/state, logging an error and returning some value. Would de-clutter the host a bit I think.
null de-references:
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/gatt.c#L3469-L3486
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/ecc.c#L63-L66
Broken logic:
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/att.c#L350-L352
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/conn.c#L1506-L1511
ACL Control flow broken
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/hci_core.c#L574-L579
Bonding that falls on the floor if there's an error
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/smp.c#L3863-L3866

Bonding that falls on the floor if there's an error
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/smp.c#L3863-L3866

This is an actual assertion. I assert that it's impossible for it to fail.

Some data for @Thalley . I was expecting more asserts than that 😅
The point is, maybe we should have a IF_RETURN(condition, message, retval) macro for the common pattern of checking parameters/state, logging an error and returning some value. Would de-clutter the host a bit I think.
null de-references:
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/gatt.c#L3469-L3486
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/ecc.c#L63-L66
Broken logic:
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/att.c#L350-L352
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/conn.c#L1506-L1511
ACL Control flow broken
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/hci_core.c#L574-L579
Bonding that falls on the floor if there's an error
https://github.com/zephyrproject-rtos/zephyr/blob/243783243cbde53b5353d645c2099eaf48cf8083/subsys/bluetooth/host/smp.c#L3863-L3866

Some data for @Thalley . I was expecting more asserts than that 😅
The point is, maybe we should have a IF_RETURN(condition, message, retval) macro for the common pattern of checking parameters/state, logging an error and returning some value. Would de-clutter the host a bit I think.

Hmm, we could possibly do that. However in https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style we state

In general, follow the Linux kernel coding style

Which in return in https://www.kernel.org/doc/html/v4.10/process/coding-style.html#macros-enums-and-rtl states

Things to avoid when using macros:
macros that affect control flow:

#define FOO(x)
do {
if (blah(x) < 0)
return -EBUGGERED;
} while (0)

And I generally agree with that. Implicit return statements (via macros or other ways) really messes with the readers flow.
So if you want to propose a macro with a return, be prepared for some pushback on that (and not just from me ;) )

DTS macrobatics are kosher though, definitely don't mess with people's heads, writing a driver is E-Z.
I would also argue that an ifdef soup like we seem to love qualifies as a "macro that messes with the control flow".
Sigh.. sorry for the deranged stream of thought, I'm just frustrated we're stuck with this language :|
In principle, I also agree that macros shouldn't mess with control flow.
Doing it correctly will end up with having to scroll through one page of error checking prologue for each API, all with the same if (bad) { log-something; return -EFIGURETHISOUT } copy-pasted all over. When I'll get to the fn logic, I'm sure I will already have forgotten why I was looking at that fn in the first place..
I really don't know what to do.

Sigh.. sorry for the deranged stream of thought, I'm just frustrated we're stuck with this language :|

It was going so well until you and @alwa-nordic started coming here with all your rationale and logic. It was so much easier when no-one questioned why we do what we do ;)

To add some perspective, we tried to write an H4 HCI packet decoder in rust with @alwa-nordic and it was even more verbose than the C version :sweat_smile: . So not sure the grass is greener on that side either.

To add some perspective, we tried to write an H4 HCI packet decoder in rust with @alwa-nordic and it was even more verbose than the C version 😅 . So not sure the grass is greener on that side either.

This does not represent my opinion. /disclaimer :slightly_smiling_face:

Doing it correctly will end up with having to scroll through one page of error checking prologue for each API, all with the same if (bad) { log-something; return -EFIGURETHISOUT } copy-pasted all over. When I'll get to the fn logic, I'm sure I will already have forgotten why I was looking at that fn in the first place..

Maybe this could be solved be adding folding marks around the obvious stuff. :thinking:


Nowcast Aggregation support and Ingest Consolidation

Support nowcast aggregations on the model run level. Changes the model run aggregation names to contain either forecast or nowcast based on model run type
Moves all NOS OFS ingest to one pipeline, since they all have the exact same ingest methodology. Aggregations can be a separate pipeline most likely
Adds initial aggregation support for SELFE models

Alright @jonmjoyce this is good now. The aggregation stuff can def be abstracted further by configuration, but for now this is all the NOS OFS models so want to get it going before we move repos


HLS Opencast integration mimetype fix

HLS uses the mimetype application/x-mpegURL instead of video/*.  The annotation tool when is integrated with opencast makes a check of the mimetypes.
This patch allows the AT to load this type of media when comes from the mediapackage

Please put the label on-hold, I have to rebase this first.

Just let me know when you're ready. :slightly_smiling_face:

@JulianKniephoff Ready to review 😉


[Draft] Allow export full schedule or single record to Google calendar

Probably better and easier to generate iCalendar .ics file
https://en.wikipedia.org/wiki/ICalendar


234 refactor dia implementation

This PR creates a re-usable definition for the DIA oracle mock, which is just moving the implementation from pallets/oracle/src/mock.rs to pallets/oracle/src/oracle_mock.rs and adding some other trait definitions that make it re-usable.
The duplicated definitions are then removed from the other pallets.
Closes #234.

Turning this into a draft again because apparently there are some more severe conflicts I need to solve.
Also sorry for actually putting you guys as 'assignees' and not as 'reviewers' haha @b-yap @adelarja.

I now figured out why the vault registry tests were suddenly failing. The reason is that I replaced the thread_local() implementation with a lazy_static() initialization. I didn't realize though that this introduces a problem because this lazy_static reference of the COINS is now shared across all tests, which then introduces race conditions because the exchange rates are cleared  before each test run. Since the tests are running in parallel by default, I had to introduce the #[serial] macro to make sure that the clearing of before one test does not clear the values that were prepared for the execution of another test, etc.
I find this #[serial] annotation but I don't know of a better way to fix this right now. I had to make the code in the oracle_mock free of any std references so that it can be shared among all pallets without introducing compilation errors. Thus thread_local is not available.
Does anyone have some ideas how to approach this without the #[serial] macro, @b-yap @adelarja @gianfra-t ?

I now figured out why the vault registry tests were suddenly failing. The reason is that I replaced the thread_local() implementation with a lazy_static() initialization. I didn't realize though that this introduces a problem because this lazy_static reference of the COINS is now shared across all tests, which then introduces race conditions because the exchange rates are cleared  before each test run. Since the tests are running in parallel by default, I had to introduce the #[serial] macro to make sure that the clearing of before one test does not clear the values that were prepared for the execution of another test, etc.
I find this #[serial] annotation but I don't know of a better way to fix this right now. I had to make the code in the oracle_mock free of any std references so that it can be shared among all pallets without introducing compilation errors. Thus thread_local is not available.
Does anyone have some ideas how to approach this without the #[serial] macro, @b-yap @adelarja @gianfra-t ?

If I understand correctly, the problem is that one test is clearing, then setting COINS to a test value and then in the middle comes another test and clears COINS.  If that is the case, I can think of some naive lock where you wrap COINS around a struct struct NewCoins {actual_coins: COINS, using: bool, cvar: Condvar} and then have the mock wait until it gets notified via cvar that using is false. Something like here: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html

Thanks for your comment @gianfra-t. I decided not to use condvar but your suggestion led me to implement a locking mechanism that works similarly to the #[serial] macro.

I ran the tests and clippy locally and it worked fine so I'll merge this before waiting for CI to finish.