Mixin classes don't allow constructors of generic 'object' types

TypeScript Version:  2.3.4, 2.4.0-dev.20170609
Code:
type Constructor<T> = new (...args: any[]) => T;

const Timestamped = <I extends object, CT extends Constructor<I>>(Base: CT) => {
  return class extends Base {
    timestamp = new Date();
  };
};

Expected behavior:
Should be able to use the generic I as an argument to Constructor.
Actual behavior:
Compiling this yields the following error:
error TS2509: Base constructor return type 'I' is not a class or interface type.

Note:
This is a variation on https://github.com/Microsoft/TypeScript/issues/13805 where the following compiles successfully:
type Constructor<T> = new (...args: any[]) => T;

const Timestamped = <CT extends Constructor<object>>(Base: CT) => {
  return class extends Base {
    timestamp = new Date();
  };
};

I've also run into this. This is my workaround:
type Constructor<T> = new (...args: any[]) => T;

const Timestamped = <CT extends Constructor<object>>(Base: CT) =>
    <T extends Object>() =>
        class extends Base {
            timestamp = new Date;
        };

class Base {
    foo = 5;
}

class Sub extends Timestamped(Base)<Base>() {
    bar = 'ok';
}

let s = new Sub;
console.log(s.foo, s.bar, s.timestamp);

I've haven't been able to find a way to avoid the double function call.

I wonder if it possible to return generic class from mixin, like this:
type Constructor<T> = new (...args: any[]) => T;

const List = <T extends Constructor<{}>>(Base: T) => class <T> extends Base {
    values: T[];

    constructor(...args: any[]) {
        super(...args);
    }

    add(value: T) {
        this.values.push(value);
    }
};

class Item {
    render() { }
}

class ItemList extends List(Item)<Item> {
    render() {
        this.values.forEach((item) => {
            item.render();
        });
    }
}

const list = new ItemList();
console.log(list.values);
list.render();

For now it's produces error: error TS2545: A mixin class must have a constructor with a single rest parameter of type 'any[]'., but all vscode hints are ok (list.values are type of Item, its have prototype of Item and so on).

lets fix the problem "is not a class or interface type"
i use TypeScript version 2.9.2/3.0.1 but think it sould work with older ones to
Basic requirement

define in your projets global.d.ts
    interface ClassType<InstanceType extends {} = {}> extends Function {
      new(...args: any[]): InstanceType
      prototype: InstanceType
    }

defined in lib.es5.d.ts
    type InstanceType<T extends new (...args: any[]) => any> = T extends new (...args: any[]) => infer R ? R : any;

@athasach

TypeScript infers all types correctly if you change the resolution direction
    const Timestamped = <BaseClass extends ClassType<{}>, BaseInstance extends InstanceType<BaseClass>>(base: BaseClass) =>
      class extends base {
        someTimeAgoIWasA!: BaseInstance
        constructedFrom!: BaseClass
        timestamp = new Date();
      }

To limit the accepted classe/instance type you can change the {} as in this examples:

BaseClass extends ClassType<Object>
BaseClass extends ClassType<Parent>
BaseClass extends ClassType<...>

example only allow to mixin to child/sub classes of the class Parent
    class Parent {
      talkToLuke() {
        console.log('I am your father!')
      }
    }

    const Timestamped = <BaseClass extends ClassType<Parent>, BaseInstance extends InstanceType<BaseClass>>(base: BaseClass) =>
      class extends base {
        someTimeAgoIWasA!: BaseInstance
        constructedFrom!: BaseClass
        timestamp = new Date();
      }

@zamb3zi

Just as above the InstanceType can be infered as folloing
example Timestamped
    const Timestamped = <BaseClass extends ClassType<{}>, BaseInstance extends InstanceType<BaseClass>>(base: BaseClass) =>
      class extends base {
        someTimeAgoIWasA!: BaseInstance
        constructedFrom!: BaseClass
        timestamp = new Date();
      }

    class Base {
      foo: number = 5
    }
    class Sub extends Timestamped(Base) {
      bar = 'ok'
    }
    const s = new Sub()
    console.log(s.foo, s.bar, s.timestamp)

@evg656e

Just as above the InstanceType can be infered as folloing
example ItemList
    const List = <BaseClass extends ClassType<{}>, BaseInstance extends InstanceType<BaseClass>>(base: BaseClass) =>
      class extends base {
        values!: BaseInstance[]
        add(value: BaseInstance) {
          this.values.push(value)
        }
      }

    class Item {
      render() { }
    }
    class ItemList extends List(Item) {
      render() {
        this.values.forEach((item) => item.render())
      }
    }
    const list = new ItemList()
    console.log(list.values)
    list.render()

@lupuscaoticus Hi, I'm trying to give the type of a mixin, like this
type Mixin = <S extends ClassType, I extends InstanceType<S>, M extends I> (B: S) => ClassType<M>

However tsc says Timestamped can't be a Mixin, how can I fix it?
Thank you very much!

I am experiencing the same issue and no idea how to fix it. Currently I am ignoring the error using // @ts-expect-error. Any help would be appreciated XD
https://stackoverflow.com/questions/75030861

FWIW this looks like a duplicate of https://github.com/microsoft/TypeScript/issues/13807


Connector list miss some

Hi, to install COE core component you request to create some prior connection, i think those are missing because i had to create it after importing COE starter kit core component
Coe Core - Dataverse Legacy
CoE Core - Dataverse (Env Request)
CoE BYODL - Power Query

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9fe69498-a485-5379-97ff-53fbe029f11a
Version Independent ID: 5b3f9705-9e49-1575-4ae7-0293d12b739c
Content: Set up inventory components - Power Platform
Content Source: power-platform/guidance/coe/setup-core-components.md
Service: power-platform
Sub-service: guidance
GitHub Login: @manuelap-msft
Microsoft Alias: mapichle

Hello,
all the connections to connectors that the CoE needs are called out here in this list:
https://learn.microsoft.com/en-gb/power-platform/guidance/coe/setup-core-components#create-connections

When you import the solution, you'll fill out connection references with the established connections - the names you shared are connection references. We don't maintain a list of connection references in our docs as they change all the time, and once you have established the connections they will all be populated correctly on import anyway.
Hope this helps
Manuela

Thanks for your comment, @jeffangama. This issue has been assigned to the doc author for review.

No further action required here, the connector list is up to date.


Add ability to specify the memory size for data passing

It is now possible to specify the memory to allocate for data passing per pipeline.
Specifying the size can be done through the settings of a pipeline in the UI or by adding  "data_passing_memory_size" (together with a value) to the "settings" property in the pipeline definition.

LGTM!


Typings in VS Code

Can you give me any hint, why the Typings in VS Code might not show up?
Using const { $jsonApi } = useNuxtApp() the IDE thinks that const $jsonApi: unknown.
Thanks a a lot for your great plugin :)

@riddla unfortunately I don't. When I open the repo in VSCode I get the correct typing.

Do you have the Volar and TypeScript Vue Plugin (Volar) extensions installed and setup?
Is there a repo with the issue you can share?

@patrickcate, never mind – I found out that the project in question currently has no typing at all via useNuxtApp. So there must be another problem.
(I'll keep you posted when I find the underlying issue.)

Did you ever figure out why the project has no typings?  I'm running into the same issue (though I'm using Webstorm), and would love to have the proper types exposed to work with!

I opened a new issue about this, since it still seems to be relevant, along with a workaround that I'm using for now.


Support for proc-macro crates

I tried running cargo-mutants on a proc-macro crate and was surprised to see it found no mutants. When I turned log level to tracing I saw this in the logs:
DEBUG package{name=despatma-dependency-container}: skipping target "despatma_dependency_container" of kinds ["proc-macro"]

Is there a reason proc-macros are skipped that I might be missing?

I don't think there's any positive reason, it's just not something that we recognize yet.
It looks like this is from https://github.com/chesedo/despatma
Looking at the code, it does seem to have tests that cargo-mutants could run, and code that it would understand. So this might be as simple as just changing the code in cargo.rs that decides which cargo targets will be mutated, where this trace line comes from.

@chesedo it looks like the tests fail at head in despatma:
test tests/fail/missing_types.rs ... mismatch

EXPECTED:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0405]: cannot find trait `Circle` in this scope
 --> tests/fail/missing_types.rs:6:14
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |              ^^^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Circle;
  |

error[E0412]: cannot find type `Rectangle` in this scope
 --> tests/fail/missing_types.rs:6:22
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                      ^^^^^^^^^ not found in this scope
  |
help: consider importing this struct
  |
4 + use crate::library::shapes::Rectangle;
  |

error[E0405]: cannot find trait `Sphere` in this scope
 --> tests/fail/missing_types.rs:6:37
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                     ^^^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Sphere;
  |

error[E0412]: cannot find type `Arc` in this scope
 --> tests/fail/missing_types.rs:6:45
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                             ^^^ not found in this scope
  |
help: consider importing one of these items
  |
4 + use crate::library::shapes::Arc;
  |
4 + use std::sync::Arc;
  |

error[E0405]: cannot find trait `Cube` in this scope
 --> tests/fail/missing_types.rs:6:54
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                                      ^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Cube;
  |
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

ACTUAL OUTPUT:
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0405]: cannot find trait `Circle` in this scope
 --> tests/fail/missing_types.rs:6:14
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |              ^^^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Circle;
  |

error[E0412]: cannot find type `Rectangle` in this scope
 --> tests/fail/missing_types.rs:6:22
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                      ^^^^^^^^^ not found in this scope
  |
help: consider importing this struct
  |
4 + use crate::library::shapes::Rectangle;
  |

error[E0405]: cannot find trait `Sphere` in this scope
 --> tests/fail/missing_types.rs:6:37
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                     ^^^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Sphere;
  |

error[E0412]: cannot find type `Arc` in this scope
 --> tests/fail/missing_types.rs:6:45
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                             ^^^ not found in this scope
  |
help: consider importing one of these structs
  |
4 + use crate::library::shapes::Arc;
  |
4 + use std::sync::Arc;
  |

error[E0405]: cannot find trait `Cube` in this scope
 --> tests/fail/missing_types.rs:6:54
  |
6 | visitor!(dyn Circle, Rectangle, dyn Sphere, Arc, dyn Cube);
  |                                                      ^^^^ not found in this scope
  |
help: consider importing this trait
  |
4 + use crate::library::shapes::Cube;
  |
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
note: If the actual output is the correct output you can bless it by rerunning
      your test with the environment variable TRYBUILD=overwrite

test fail ... FAILED
tests/expand/compound_name.rs - ok
tests/expand/helper_tmpl.rs - ok
tests/expand/multiple.rs - ok
tests/expand/no_default.rs - ok
tests/expand/simple.rs - ok
tests/expand/visitor_mut.rs - ok
test expand ... ok

failures:

---- fail stdout ----
thread 'fail' panicked at /Users/mbp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/trybuild-1.0.99/src/run.rs:101:13:
1 of 4 tests failed
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@chesedo it looks like the tests fail at head in despatma:

A newer Rust version recently changed some of the error messages. Can't quite remember if I updated the repo yet.
I assume you are trying to test if cargo-mutants can run against a proc-macro crate?

I don't think there's any positive reason

If there is no solid, known reason then I can make a fork to test locally. And can make a PR if it works

The linked branch here has a change to enable it, it just needs some manual
tests, and a test added to the tree!
On Thu, Sep 12, 2024, 15:51 Pieter @.***> wrote:

I don't think there's any positive reason
If there is no solid, known reason then I can make a fork to test locally.
And can make a PR if it works
—
Reply to this email directly, view it on GitHub
https://github.com/sourcefrog/cargo-mutants/issues/406#issuecomment-2347115720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACUR4YHZ3ABAONINXSGDDLZWHWCTAVCNFSM6AAAAABOCPMJDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGEYTKNZSGA
.
You are receiving this because you commented.Message ID:
@.***>

The linked branch here has a change to enable it, it just needs some manual tests, and a test added to the tree!

Okay, I was able to manually test the linked branch and the mutants went from 16 to 49. I also fixed the repo if you also wanted to perform a manual test.

OK yep this seems to work well on your crate:
; c r mutants -d ../despatma/
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
     Running `target/debug/cargo-mutants mutants -d ../despatma/`
Found 72 mutants to test
ok       Unmutated baseline in 7.7s build + 26.7s test
 INFO Auto-set test timeout to 2m 14s
MISSED   despatma-lib/src/key_value.rs:51:31: replace && with || in <impl PartialEq for KeyValue>::eq in 0.4s build + 0.2s test
MISSED   despatma-lib/src/key_value.rs:51:9: replace <impl PartialEq for KeyValue>::eq -> bool with true in 0.3s build + 0.2s test
MISSED   despatma-dependency-container/src/processing/visitor/extract_async.rs:20:33: replace |= with ^= in <impl VisitorMut for ExtractAsync>::visit_dependency_mut in 0.9s build + 8.7s test
MISSED   despatma-dependency-container/src/processing/mod.rs:54:9: replace <impl PartialEq for Lifetime>::eq -> bool with true in 0.8s build + 9.4s test
72 mutants tested in 3m 20s: 4 missed, 55 caught, 13 unviable

Awesome! :partying_face:  Thanks for the update!


Trailing Comma in JSON File Error

Failed to parse json
npm ERR! Trailing comma in object at 23:3
npm ERR!   },
npm ERR!   ^
npm ERR! File: /Users/jessierichardson/Desktop/new_proj/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

I'm not sure which version you're on but we don't have any trailing commas in our package.json.


core: fix NameError

Description: In the chat_models module of the language model, the import statement for BaseModel has been moved from the conditionally imported section to the main import area, fixing NameError .
Issue: fix NameError

Thank you!


Should only text-entry frames be tabbable?

Also, reconsider, do text entry frames need to be frames? Would it be clearer to call them Fields?
(Longer-term, need to consider how to permit newlines to be entered in (literal) strings, lists/dictionaries, if-then-else expressions, etc)

A: No. Anything that is capable of being selected, must be tab-able.


Nationbuilder subscription endpoint

Front-end js will need to post emails to an endpoint to subscribe users to Nationbuilder emails.

[Completed by #24]


pyarrow 0.13

Fixes #194

Biggest concern here is that cudf pins at 0.12.1, so we might not be able to update and have cudf in the same environment


[FEATURE] Adding a grid view on profile

Description
I want to add a grid view on profile page for feed like instagram.
Screenshots

Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

right, it's not functional right now! ;-;


Fixes https://github.com/SAP/openui5/issues/439

I hereby declare to agree to the OpenUI5 Individual Contributor License Agreement.
This fix allows to keep the selected rows of a table selected after a sort or filter operation.
The idea is to restore the selected indices in the selection model by comparing how the indices of the ClientListBinding changed.
The new behaviour can be turned on using the boolean property "selectionRestoration".

Thanks for your contribution!
@SebastianRied @petermuessig @loginger could you please have a look into this?
The failing Travis build is not caused by your change. I will have a look and update you once it's fixed.

a363be1c929cc2049934eba2a977236d7a82445d should fix the issues in travis.
I also re-triggered the build before this change which gave some ESLint issues, so you can already have a look and fix them: https://travis-ci.org/SAP/openui5/builds/69198676

Tracked internally as<PHONE_NUMBER>

Closing as this won't be merged.


Printer options that is not key=value pair

Hello there,
I've been using CUPS in a project and I am running into a few issues that couldn't figure it out yet.
How can I send the option '-o landscape' to the printer using the 'print_file' method?
In the documentation it only refers to examples that are key, value pairs ({'InputSlot' => 'Upper', 'PageSize' => 'A4'}).
I tried many different ways but I always get an error.
I know the printer supports it because my files prints correctly when I use 'lpr' command line.
Thanks,
Helio

I am also trying to figure out landscape :(

see #22 the value for landscape is "yes" but the key is probably blocked, you need to manually whitelist it.

Closing, thanks to #22 from Justin.


Documentation of error codes and exceptions

This is one of the best code examples I've seen incorporating specific exception types and error codes. I don't need any changes. This page is amazing. Show it to to your peers, and encourage them to document this well in their pages in the future!
Thanks for making one dev smile today.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 48a14460-d8c3-d8ed-7932-a9a234955e22
Version Independent ID: c456b1ef-af80-1b8d-0c15-5f50c016663f
Content: Acquire a token to call a web API using integrated Windows authentication (desktop app) - Microsoft identity platform
Content Source: articles/active-directory/develop/scenario-desktop-acquire-token-integrated-windows-authentication.md
Service: active-directory
Sub-service: develop
GitHub Login: @maliksahil
Microsoft Alias: sahmalik

Thanks @jeremysimmons 👍

Thanks for the feedback, @jeremysimmons ! I have assigned this to the content author, @maliksahil


feat(range): Custom knob values

Feature Request
Ionic version:

[x] 4.x
Describe the Feature Request

Currently it is only possible to display numbers on the range knobs.
It would be great to allow custom formatting of knob/pin values.
Describe Preferred Solution

It could work similarly to how Angular Material's slider works by allowing the user to specify a function:
displayWith: (value: number) => string | number
It could be used as follows:
letters = ["A", "B", "C", "D"];
convertToLetter = (value: number) => letters[value];

<ion-item>
  <ion-range pin="true" min="0" max="3" [displayWith]="convertToLetter"></ion-range>
</ion-item>

Additional Context
Could look like this:

Thanks for the issue. I am going to close this as a duplicate of https://github.com/ionic-team/ionic/issues/18767.


Common Lisp support

This adds Common Lisp support - library, generator, cross-tests, tutorial code, etc. Currently only SBCL is supported.
The minimal requirements are fulfilled. Cross-tests pass against most languages that I've tried.

Some initial thoughts, before I review all of the files individually:

Please squash.
Please add [THRIFT-82] at the beginning of the commit description and the pull request description.
Please review https://thrift.apache.org/docs/HowToContribute.

I resurrected https://issues.apache.org/jira/browse/THRIFT-82 upon seeing this.  I'll start going through the files.

@jfarrell for some reason there is no recorded Travis CI build for this pull request.  When the author squashes and resubmits hopefully this will kick off a proper build?

Thank you for taking your time for the review

So about removing the bundled dependencies (lib/cl/externals).
There is a nifty package manager for CL (Quicklisp) that works a bit like, say, Cargo for Rust. It's commonly used, but the problem is it isn't available in PATH or anything - it's installed in the user's dir normally. There's no good way to detect its presence while building Thrift.
What if we included the Quicklisp installer (literally a single .lisp file), installed it locally during the build, and then used it to pull in other dependencies? Would that be fine?

I think it would be better to make a shell script that downloads quicklisp and runs it to install the dependencies, and make the local build in lib/cl depend on successful execution of the shell script.  This makes it similar to the nodejs build which runs npm to do something similar, however the only difference is that npm is installed as part of the docker build.
.

Hey, removed all externals and added ensure-externals.sh script. Also squashed all commits.

Without a linux build, won't be able to do any merges...

Travis requests show an error with "Abuse detected". I've emailed Travis support asking them to look into the issue

@jfarrell: What's your opinion re the (c) things above?

@dkochmanski Travis support responded saying that no one from TurtleWarePL has logged into https://travis-ci.org/ ever and this is the reason this PR is not getting run within travis.
From Travis support:

do you think one of their members could try to log into Travis CI at least once at https://travis-ci.org/ and try closing and reopen one of the rejected Pull Requests?

Why don't we close this PR and open a new one free of any copyright issues or inclusion of third party code.  That should resolve the issue?

@jfarrell logged into travis a moment ago for the first time.
@jeking3 I'm waiting for a response from @lisp if we can remove his copyright strings (we've removed ours). Should I close the PR and issue a new one before I receive a reply?

Let's follow @jfarrell 's lead.  Whatever he says, he's managing the travis interaction.

closing, will reopen with squashed commits.

see https://github.com/apache/thrift/pull/1412

good evening; this popped up in my mail due to  mr kochmanski's reference.
what are you waiting for from me?

Hello, I've send you an email a few hours ago with a question, if we can remove your "copyright" headers from the code found in de.setf.thrift, because that is what is required by Thrift team (I have included details in the email). Plese see: https://github.com/apache/thrift/pull/1410#discussion_r149655532 .


Change Tag Sort order

Tags are currently ordered by the numeric ID of the tag.
I propose a new sorting order, which I'm not ashamed to say is the one I use in MCEdit 2.0:

Compounds
Lists
All non-array types, ordered by tag name
Array types

This will put collection types first, which makes it easier to drill down into nested collections (e.g. level.dat/Data/Player). Plain data types are grouped together, ignoring the exact data type, making it easier to find a tag by name. Arrays are infrequently edited and are listed last.
If you know offhand which .NET classes are responsible for tree views and sort ordering, any implementation tips would be appreciated. I might use it as an excuse to get into .NET development.

https://msdn.microsoft.com/en-us/library/system.windows.forms.treeview.treeviewnodesorter.aspx
Implement your own IComparer. See the example.

Thanks! That was fun.

I agree, that looks like a more useful sort order.  Thanks for the implementation.
I changed the string compares to natural compares (had to pull in a little third party code), so numbers will sort in a human-friendly manner.  Should make a marked difference on the region and chunk listings.

Great! One last thing... the NaturalComparer doesn't respect negative numbers. I'll push a fix shortly.


VS 2019 compatibility

Hello. There is a really easy way, to make its extension compatible with visuals studio 2019. Please look at:
https://github.com/odalet/VSWebBrowserExtension/commit/d0ed4000d0518b920b74d5519439594a7cb7f691

Sure, except I don't intend to support VS 2019 as it already provides its own browser window.


fix: configure crypto-action for internal consumer independently cryptoReader

Motivation
Right now, MultiTopicConsumer doesn't configure CryptoFailureAction for internal consumer-configuration if CryptoReader is null which causes unexpected behavior.
Modifications
Set CryptoFailureAction correctly for internal-consumer.

We could also add a simple test case for multi topic subscribe in the encryption tests, to ensure we don't break it later.

Sure, let me add it.

retest this please


Fixes the path issues with data/sumary.psk

Hey @Aniseto,
I've fixed the path issues with data/sumary.psk.
I've added:
#include <filesystem>
namespace fs = std::filesystem;

and made some adjustments with the type of container for the path. From wxString to std::string which is what current_path() returns, I think...

Side Note:
The program is creating the data folder with permissiion drw-r--r--, when it should be drwxrwxr-x.
This is a Linux only issue and I need to confer with @Azazorro to find a way to avoid/fix this.

Cheers,
Gus

Testing this PR, std::current_path() is not identified as a valid member for std.

Hey @Aniseto,

std::current_path() is not identified as a valid member for std.

You are completely correct, current_path() does not belong on the std namespace.
If you look closely at the message on the PR, the one at the top there :arrow_up:, you'll notice that is belongs to std::filesystem to which I created an alias called fs.
Son in order to use it you just have to do  something like this:
std::string filename = fs::current_path() / "data" / "sumario.psk";

And then use that variable to send to the reader function.
Hope that helps!
Cheers,
Gus

The issue is that compiler says:
About this line: std::string outputDir = fs::current_path() / "";
Error (active)	E0312	no suitable user-defined conversion from "std::filesystem::path" to "std::string" exists	NosoWalletCPP
std::string outputDir = fs::current_path().string() / "";

Hey @Aniseto,
Wow, that's quite odd!!
I tested that on my Linux box with g++ and it worked.
But I did wonder why because the docs did say that current_path() returned path.
I was a bit in a hurry and forgot that it std::filesystem::path so I tried std::string and it worked on my end.
Let me update the PR to reflect this change.
Cheers,
Gus

Hey @Aniseto,
Looks like fs::path has a function that returns a string.
I made the necessary changes to always have a path return a string.
Please review them and see if it works on your side now.
Cheers,
Gus

Solved path issue, changing from wxString to std::String. Not needed to merge.


WIP: Modify bundle parsing role to not slice the ocp versions label

Modify bundle parsing role to not slice the com.redhat.openshift.versions label
Remove the sanity tests for operator bundle's ocp_versions

/retest

/retest

/retest

/retest

The CI has passed for this PR, but the reporting seems to be having an issue. Merging.


Randomness for select players?

Hello everyone, hope your projects are coming along nicely. I was wondering if it is possible to set that randomness feature to True for only a select group of players? From the documentation, it appears that you can turn off the randomness for players but you would have to manually go through and assign no randomness to almost all the other players. Any insight would be great, thanks.

I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.

I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.

I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.

ah that makes sense, thank you. Do you by chance know if it matters where the columns are located? In excel, I have min and max deviation in column indexes 15 and 16 but the optimizer doesn't seem to pick them up.

I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.

ah that makes sense, thank you. Do you by chance know if it matters where the columns are located? In excel, I have min and max deviation in column indexes 15 and 16 but the optimizer doesn't seem to pick them up.

Are you using an excel spreadsheet or the salary csv file?  You need a csv file in the same format as the one downloaded from DK, FD etc.
What I do is download the salaries sheet, vlookup projections and add a Min Deviation and Max Deviation columns.
Get Outlook for iOShttps://aka.ms/o0ukef

From: McCampy<EMAIL_ADDRESS>Sent: Friday, January 29, 2021 11:51:48 PM
To: DimaKudosh/pydfs-lineup-optimizer<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [DimaKudosh/pydfs-lineup-optimizer] Randomness for select players? (#242)
I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.
ah that makes sense, thank you. Do you by chance know if it matters where the columns are located? In excel, I have min and max deviation in column indexes 15 and 16 but the optimizer doesn't seem to pick them up.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/242#issuecomment-770151397, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAEVPRVQUMLCPMBSDSP54LS4N65JANCNFSM4WZ2MVLQ.

Are you using an excel spreadsheet or the salary csv file?  You need a csv file in the same format as the one downloaded from DK, FD etc.
What I do is download the salaries sheet, vlookup projections and add a Min Deviation and Max Deviation columns.
Get Outlook for iOShttps://aka.ms/o0ukef

From: McCampy<EMAIL_ADDRESS>Sent: Friday, January 29, 2021 11:51:48 PM
To: DimaKudosh/pydfs-lineup-optimizer<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [DimaKudosh/pydfs-lineup-optimizer] Randomness for select players? (#242)
I think you can just set min deviation and max deviation to zero in your excel sheet and only changes the players you want.
ah that makes sense, thank you. Do you by chance know if it matters where the columns are located? In excel, I have min and max deviation in column indexes 15 and 16 but the optimizer doesn't seem to pick them up.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/242#issuecomment-770151397, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAEVPRVQUMLCPMBSDSP54LS4N65JANCNFSM4WZ2MVLQ.

Thanks, Eric. Yes, i'm doing something similar, I'm grabbing the csv from fd and importing it into excel to edit the columns. It works when I set up some of the extra columns that the optimizer can read, just not min and max deviation for some odd reason. It's good to hear that it's working on your end though, leads me to think I just have some little error somewhere.

Thanks, Eric. Yes, i'm doing something similar, I'm grabbing the csv from fd and importing it into excel to edit the columns. It works when I set up some of the extra columns that the optimizer can read, just not min and max deviation for some odd reason. It's good to hear that it's working on your end though, leads me to think I just have some little error somewhere.

FYI, you don't need your spreadsheet to match a particular format. There are helper functions that will load those particular files, but it is not a requirement.
You can create Player objects however you want and then load them into the optimizer with load_players.
All of the parameters for the Player object are below. You can create Player objects from any csv file or dataframe just by mapping your field/column names to the init signature.
    def __init__(self,
                 player_id: str,
                 first_name: str,
                 last_name: str,
                 positions: List[str],
                 team: str,
                 salary: float,
                 fppg: float,
                 is_injured: bool = False,
                 max_exposure: Optional[float] = None,
                 min_exposure: Optional[float] = None,
                 projected_ownership: Optional[float] = None,
                 game_info: Optional[GameInfo] = None,
                 roster_order: Optional[int] = None,
                 min_deviation: Optional[float] = None,
                 max_deviation: Optional[float] = None,
                 is_confirmed_starter: Optional[bool] = None,
                 fppg_floor: Optional[float] = None,
                 fppg_ceil: Optional[float] = None,
                 original_positions: Optional[List[str]] = None,
                 ):

For example, this is how I load players from rows of a pandas dataframe
from pydfs_lineup_optimizer import Player

def _row_to_player(self, row):
    """Converts dataframe row to Player object
    Args:
        row (namedtuple): dataframe row
    Returns:
        Player
    """
    valid_kwargs = (
            'is_injured', 'max_exposure', 'min_exposure',
            'projected_ownership', 'game_info', 'roster_order',
            'min_deviation', 'max_deviation', 'is_confirmed_starter',
            'fppg_floor', 'fppg_ceil'
    )

    kwargs = {field: getattr(row, field) for field in row._fields
                     if field in valid_kwargs}

    return Player (
            player_id=row.player,
            first_name=self._first_name(row.player),
            last_name=self._last_name(row.player),
            positions=[row.pos],
            team=row.team,
            salary=row.salary,
            fppg=row.proj,
            **kwargs
    )

Okay gotcha, thanks for the tip sansbacon. Appreciate ya throwing in your code, i'll see if I can get something similar going.

If you want more detail about Player objects and how to load them in the optimizer, I've created a series of notebooks relating to lineup optimization that covers this, among other topics.

@sansbacon This is great stuff, thank you.


[Feature] flink cluster failure alarm&failover

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
a. If cluster shutdown or lost is detected, an alarm will be sent.
b. If the job is running on the cluster, the job will alarm in batches. At this time, it is necessary to prevent the job from alarming.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello everyone, after discussion, our solution for this issue is as follows:
Requirement:

When Flink Cluster encounters an exception and is unable to run, alert the user and block the job alert notification running in the Flink Cluster

Detailed logic:

Flink Cluster implements mentality detection and status updates, as detailed in: https://github.com/apache/incubator-streampark/pull/2675
When an exception occurs in a job, it is necessary to determine whether the job deployment mode is remote, yarn session or k8s session：If not, send the job alarm directly. If so, obtain the flink cluster status through the Flink Cluster ID of the job:If the flink cluster status is STOP or LOST,  block the job alarm and wait for the flink cluster alarm.If the status of flink cluster is RUNNING, actively trigger a flink cluster status update request to update the relevant status of flink cluster. If flink cluster is updated to STOP or LOST status in the latest update, the job alarm will be blocked; If the flink cluster status is still RUNNING, send an alarm notification for the job.
Flink cluster alarm template uses job alarm template and adds information: number of affected jobs.
Abstract the alarm template code to avoid code redundancy issues.


Periodic adv. syncing takes longer and bt_le_per_adv_sync_delete returns error after commit ecf761b4e9

Describe the bug
There is a change in behaviour in my DF test application that I'm not sure is expected. Using git bisect I tracked it down to commit ecf761b4e9.
What my application does is to start a timeout after calling bt_le_per_adv_sync_create that is 2 seconds. Before this commit I almost never hit that timeout (it's cancelled when sync is done), but after it every other sync hits it. What I also noticed is that when I try to cancel the sync using bt_le_per_adv_sync_delete after my timeout hits I get error back (BT_HCI_ERR_CMD_DISALLOWED (-5)) checking the code it seems as this is the reason for the ERROR:
scan->per_scan.sync is NULL here in ull_sync.c hence it fails
Looking at the log when this happens:
*** Booting Zephyr OS build v2.7.99-403-gecf761b4e986  ***
Starting Connectionless Locator Demo
Bluetooth initialization...success
Scan callbacks register...success.
Periodic Advertising callbacks register...success.
Start scanning...success
Waiting for periodic advertising...
Scan is running...
Found device sending per adv: 0A:76:7A:EB:55:33 (random)
(2900) Creating Periodic Advertising Sync...
success.
Sync index: 0
(4906) sync_create_timeout for 0A:76:7A:EB:55:33 (random)
Failed cancel sync: -5
(5186) PER_ADV_SYNC[0]: [DEVICE]: 0A:76:7A:EB:55:33 (random) synced, Interval 0x0780 (2400 ms), PHY LE 2M
Enable receiving of CTE...
success. CTE receive enabled.
(5201) PER_ADV_SYNC[0]:
(5203) PER_ADV_SYNC[0]:
(5206) PER_ADV_SYNC[0]:
(5208) PER_ADV_SYNC[0]:
(5210) PER_ADV_SYNC[0]:
(5213) PER_ADV_SYNC[0]:
(5215) PER_ADV_SYNC[0]:
(5218) PER_ADV_SYNC[0]:
(5220) PER_ADV_SYNC[0]:
(5222) PER_ADV_SYNC[0]:
(7587) PER_ADV_SYNC[0]:
(7589) CTE[0]: samples count 45
(7592) PER_ADV_SYNC[0]:
(7595) CTE[0]: samples count 45
...

We can see that sync is created at 2900 (ms)
At 4906 (ms) the timeout hits and I call bt_le_per_adv_sync_delete, here I expect the cancel to not return failure.
At 5186 (ms), 280ms later I get the synced callback. I don't expect this.

To Reproduce
Steps to reproduce the behavior:

Use latest Zephyr direction_finding_connectionless_tx on one device (latest as time of writing 9e97b3b0f0913a46b90555e797e979dd7344ce3b)
Run the modfied direction_finding_connectionless_rx attached to this ticket.
You just need two devices, have the tag always transmitting and only reset the direction_finding_connectionless_rx device.
Reset the direction_finding_connectionless_rx device until you get the error in the log

Expected behavior
I expect no error response from bt_le_per_adv_sync_delete
Impact
Application ends up in a state I'm not sure how to handle.
Logs and console output
Logs for different scenarios and commits.
log_bad_9e97b3b0f0.txt
log_bad_9e97b3b0f0_no_sync_timeout.txt
log_bad_ecf761b4e9_breaking_commit.txt
log_good_9b66a8b47d.txt
Environment (please complete the following information):

OS: Windows
Toolchain (e.g Zephyr SDK, ...): Zephyr SDK
Commit SHA or Version used: 9e97b3b0f0

Additional context
Application to reproduce:
direction_finding_connectionless_rx.zip

The periodic advertising interval is 2.4 seconds, periodic sync is established on the first successful reception of AUX_SYNC_IND, i.e. there can be upto 2.4 seconds until sync is established, 2 second timeout is short. Please close this issue, if a timeout > 2.4 seconds solves your issue.

Hi @cvinayak, I bumped the timeout as promised and as expected It's not getting hit anymore, since it got more time, however the issue is still there. For example in the log below I reset the transmitter as soon as I see the Creating Periodic Advertising Sync...success. in the log. This simulates for example a tag going out of range just after we initialize the sync or similar. As you can see expected behaviour happend once first, and then next time I got -5 error code. I also added in to retry to call bt_le_per_adv_sync_delete if it failed but it just keeps reporting error. The controller don't allow any new sync to be created as it's syncing with some device (which I cannot stop), to recover I need to reset the module.

*** Booting Zephyr OS build v2.7.99-571-gecf6e22b3ab4  ***
Starting Connectionless Locator Demo
Bluetooth initialization...success
Scan callbacks register...success.
Periodic Advertising callbacks register...success.
Start scanning...success
Waiting for perioScan is running...
dic advertising...
(1216) Found device sending per adv: 1F:63:2C:36:35:FF (random)
(1221) Creating Periodic Advertising Sync...
success.
Sync index: 0 <---- Here I reset the tag
(5227) sync_create_timeout for 1F:63:2C:36:35:FF (random)
Sync deleted
Scan is running...
(11684) Found device sending per adv: 05:CD:F4:2C:5E:E8 (random)
(11690) Creating Periodic Advertising Sync...
success.
Sync index: 0 <---- Here I reset the tag
(15697) sync_create_timeout for 05:CD:F4:2C:5E:E8 (random)
Failed cancel sync: -5
Scan is running...
(21582) Found device sending per adv: 18:4A:2C:71:E0:42 (random)
(21588) Creating Periodic Advertising Sync...
Sync for some device already in progress.
failed (err -16)
(22348) Found device sending per adv: 18:4A:2C:71:E0:42 (random)
(22354) Creating Periodic Advertising Sync...
Sync for some device already in progress.
failed (err -16)
(23004) Found device sending per adv: 18:4A:2C:71:E0:42 (random)
(23010) Creating Periodic Advertising Sync...
Sync for some device already in progress.
failed (err -16)
...
continues forever to fail
...

Maybe there was a bug before ecf761b that sent the synced callback too early maybe?

Yes, it was a bug, to send Sync Established before the reception of first AUX_SYNC_IND.

> 2.4s

This needs investigation, probably there wasn't a periodic adverting event every 2.4 seconds.

Yes, it was a bug, to send Sync Established before the reception of first AUX_SYNC_IND.

This fixed in upstream/main  and latest periodic adv/sync changes are available in #41091


⚠ Bofrost.de has degraded performance

In 7b557a1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1308 ms

Resolved: Bofrost.de performance has improved in 5342175 after 28 minutes.


Remove the legacy osc_compat mode

This provides compatibility with Chef Server 11. It's time to remove
this.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Fixes https://github.com/chef/chef/issues/8116

looking over test failures, they're unrelated... but there's a lot, someone should double-check before merging they're not related.

We have the deprecation which is enough for now


Cannot install sentry-laravel on fresh Laravel project

I created a fresh Laravel project on my computer
then run composer require sentry/sentry-laravel
but got the following error.
❯ composer require sentry/sentry-laravel
Using version ^2.7 for sentry/sentry-laravel
./composer.json has been updated
Running composer update sentry/sentry-laravel
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - sentry/sentry-laravel[dev-master, 2.7.0] require sentry/sentry ^3.3 -> satisfiable by sentry/sentry[3.3.0, 3.3.1, 3.3.x-dev (alias of dev-master)].
    - sentry/sentry 3.3.x-dev is an alias of sentry/sentry dev-master and thus requires it to be installed too.
    - sentry/sentry[dev-master, 3.3.0, ..., 3.3.1] require guzzlehttp/psr7 ^1.7 -> found guzzlehttp/psr7[1.7.0, ..., 1.x-dev] but the package is fixed to 2.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - sentry/sentry-laravel 2.x-dev is an alias of sentry/sentry-laravel dev-master and thus requires it to be installed too.
    - Root composer.json requires sentry/sentry-laravel ^2.7 -> satisfiable by sentry/sentry-laravel[2.7.0, 2.x-dev (alias of dev-master)].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

It seems to a problem with guzzlehttp/psr7 which I use the latest version.
How do I fix this?
Here is my composer.json

{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The Laravel Framework.",
    "keywords": ["framework", "laravel"],
    "license": "MIT",
    "require": {
        "php": "^7.3|^8.0",
        "fideloper/proxy": "^4.4",
        "fruitcake/laravel-cors": "^2.0",
        "guzzlehttp/guzzle": "^7.0.1",
        "inertiajs/inertia-laravel": "^0.4.1",
        "laravel/framework": "^8.40",
        "laravel/sanctum": "^2.6",
        "laravel/tinker": "^2.5",
        "tightenco/ziggy": "^1.0"
    },
    "require-dev": {
        "facade/ignition": "^2.5",
        "fakerphp/faker": "^1.9.1",
        "laravel/breeze": "^1.3",
        "laravel/sail": "^1.0.1",
        "mockery/mockery": "^1.4.2",
        "nunomaduro/collision": "^5.0",
        "phpunit/phpunit": "^9.3.3"
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/",
            "Database\\Factories\\": "database/factories/",
            "Database\\Seeders\\": "database/seeders/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi"
        ],
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "@php artisan key:generate --ansi"
        ]
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true
    },
    "minimum-stability": "dev",
    "prefer-stable": true
}

found a solution on #500

Your solution does not work.


arrow function as module.exports leads to wrong generation

(I don't know if it's really a bug or if we're not supposed to do this, but it works fine when using jsx)
When using the arrow function as a module exports, the generated code is wrong.
The following (useless but minimal) example
module.exports = () => arguments;

will lead to the generated code
var _arguments = arguments;
module.exports = function () {
  return _arguments;
};

while
module.exports = function () { return arguments; };

leads to the correct version.

Also, note that it duplicates the "use strict" statement like so:
"use strict";

var _arguments = arguments;
"use strict";

module.exports = function () {
  return _arguments;
};

What exactly is incorrect about the generated code?

@dieppe arguments doesn't make sense in a top-level arrow function, it works like this. see https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions-runtime-semantics-evaluation

This is part of the spec.

Any reference to arguments, super, or this within an ArrowFunction are resolved to their bindings in the lexically enclosing function.

See: https://github.com/6to5/6to5/issues/236#issuecomment-65302855

All right, thanks for the quick and insightful answer. Seems I need to
learn a bit more about arrow functions ;)
2015-01-09 20:25 GMT+01:00 James Kyle<EMAIL_ADDRESS>
This is part of the spec.
Any reference to arguments, super, or this within an ArrowFunction are
resolved to their bindings in the lexically enclosing function.
See: #236 (comment)
https://github.com/6to5/6to5/issues/236#issuecomment-65302855
--
Reply to this email directly or view it on GitHub
https://github.com/6to5/6to5/issues/437#issuecomment-69384870.


add ARD + CRDs + tests (tests are incomplete)

this ready to merge?

this ready to merge?
the code for this is moved to the Credential Request MR


How to use jdbc Driver to connect to dolphindb

HI, tableau teams:
I am trying to use jdbc Driver to connect to dolphindb and follow the document(JDBC), still there are some problems.

Could you give me some help?

Hi,
This is the wrong place to get support on the Other Databases (JDBC) feature. This github page is for the Connector SDK for Tableau. Asking on the community forums would be a better bet for this issue, or you can reach out to DolphinDB for specific details on connecting using their driver.
Closing since this is not an SDK question.


Thank you for your service

Hi, this is not a bug, nor a feature request, just an issue to thank you and tell you that I did mention your work in my latest linkedIn article
I think that it's an original use of your service that I really appreciate.
Thanks a lot, have a great week-end 🙏 👍

You can close this ticket when and as you want 👏

Appreciate it! And thanks for sharing that – It's a neat project!


Make AWS calls timeout if they take too long

Updates the makePromiseApi function to produce promises that timeout after five minutes.
Also modifies the non-server debug call such that it actually works.  This fix is kind of hacky but in previous attempts at fixing the debug call "correctly" i have failed and we could benefit from debug logs at the moment.

This is already running and builds have deployed on it, and it's needed to debug an ongoing problem.  Breaking the rules and self :shipit:


Editable: False is not working!

It is pretty self explanatory. I have no idea why but passing in the following configuration does not disable tiptap from being editable.
constructor() {
    this.editor = new Editor({
      editable: false,
      editorProps: {
        attributes: {
          class: 'focus:outline-none',
        },
      },
      extensions: [StarterKit],
    });
  }

Currently its handled to directly use the angular forms api, so you can set the disabled state directly like you would do on an input element, probably that overrides this.
See https://github.com/sibiraj-s/ngx-tiptap/blob/master/projects/ngx-tiptap/src/lib/editor.directive.ts#L51

Thanks! I figured that out yesterday so apologies for this issue.


MQTT

The integration should be quite straightforward to implement using PubSubClient.
Maybe it is a bit trickier to integrate the MQTT without strictly requiring this library to be downloaded everytime (in other term, make it an optional dependancy).

Closed in #18


[SPARK-50473][SQL] Simplify classic Column handling

What changes were proposed in this pull request?
We added a couple of helper functions that make it easier to work Columns in the Classic API. This covers functionality that creates a Column from an Expression, and creating (named) Expressions from a Column. There are currently multiple ways of doing the same thing and this is confusing. This PR attempts to simplify this a bit, by making the following changes:

ExpressionUtils is moved to the background. ClassicConversions/ColumnConversion are now predominantly used. The benefit of this is that most code now looks like pre-Spark 4 code.
ExpressionUtils.expression(..) and ExpressionUtils.column(..) are not implicit anymore. This was confusing.
testImplicits now supports both Expression -> Column and Column -> Expression conversions.

Why are the changes needed?
Easier to understand code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No

Merging to master.


Conditional Loops for LLMs

Is your feature request related to a problem? Please describe.
I am trying to rerun the LLM model if the generation is hallucinated, but I am getting a circular dependency error. Is there a way to implement this logic in Prompt Flow?
Describe the solution you'd like
I would like to have a loop mechanism with max_retries if the output is not sufficient.
Describe alternatives you've considered
I was thinking of a secondary LLM to be used in case of hallucination, but then I need as many LLMs as the max retries I want to have.
Additional context
Here is my current flow:

here is the error I am getting:
"variant_0 Run failed:
Invalid node definitions found in the flow graph. Node circular dependency has been detected among the nodes in your flow. Kindly review the reference relationships for the nodes ['answer_the_question_with_context', 'hallucination_grader', 'hallucination_pass', 'output_show'] and resolve the circular reference issue in the flow. "

Hi, I also had similar struggle as yours. After researching, I realize that since it's a DAG flow, you are not supposed to implemented any loop. To achieve that logic, you should change to use Flex flow instead.


Implement new designs for editing fields

What is the context of this PR?
https://trello.com/c/LZEU2hA8/431-editing-fields-design-changes-7
Implements new designs for editing section/question/answers:

all inputs are labelled properly
placeholders only used to give user content hints
removed id/htmlFor prop association from Field

How to review

review each answer type to check they work

@hamishtaplin Looks good visually, but I noticed when you press enter on checkbox Option it adds 2 options instead of 1 on this branch.


Use Freeroam UI/controls when started in beamngpy

When starting the simulation through a python script, not the complete UI/controls are available.
Switching cars with [TAB] or resetting the Car with [INSERT] is not possible.
We plan to have multiple  scripts connected to one main simulation and for overview and demonstration purposes would like to be able to switch/reset cars.
It would also be nice to be able to spawn cars in the GUI, that can then be controlled by beamngpy "agents" using the ID.
I could not find if this is already possible. I could imagine a flag like "completeGUI=true" or similar.

Hi,
you can enable the complete UI/controls in scenarios in in-game options: Options -> Gameplay -> General -> Competitive scenario conditions (uncheck it).
For your second issue:
Cars spawned in GUI can be controlled by BeamNGpy agents. You can see the way how in the multi_client.ipynb example; when you spawn a vehicle through GUI, you will see it in the list of vehicles returned by client.get_current_vehicles().
A snippet:

Create the scenario.

bng = BeamNGpy('localhost', 64256)
bng.open()

scenario = Scenario('smallgrid', 'test')
av = Vehicle('vehicle', model='etk800')
scenario.add_vehicle(av, pos=(0, -10, 0))
scenario.make(bng)
bng.load_scenario(scenario)
bng.start_scenario()

Spawn the vehicle through GUI.
Find the spawned vehicle in the list of current vehicles, connect to it and switch to it (this can be done from any client connected).

active_vehicles = bng.get_current_vehicles()
print(active_vehicles)

active_vehicles['clone'].connect(bng)
bng.switch_vehicle(active_vehicles['clone'])


octoprint: 1.9.1 -> 1.9.2

Description of changes
Small update. See https://github.com/OctoPrint/OctoPrint/releases/tag/1.9.2
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.
[x] Tested in a VM

I guess they must have updated the tag.

@lopsided98 thanks for the catch. I updated the hash :+1:


request for deployment to privately configured Kubernates Clusters

Hello @pennuel
I think for a privately configured cluster outside of AWS/Azure you can use the playground or set the helm charts to provider: local https://github.com/Consensys/quorum-kubernetes/tree/master/helm#helm-charts Essentially you are treating it no different to that of minikube or the like and you can customise anything to suit your custom configuration
Cheers
Josh


Refactor Lint cops to use expect_offense

Part of #8127
Use the newer expect_offense API to specify expected offense locations and messages.
Also fixed the offense location for Lint/LiteralAsCondition cop in a case ... when condition.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fantastic work! :bowing_man:

Thanks @bbatsov


Renaming pongo-ui to cebus

Description of changes
This pull request renames pongo-ui to cebus (the scientific name of a capuchin monkey).

Codecov Report

Merging #80 (1544ec0) into master (cc08173) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 1544ec0 differs from pull request most recent head 7b0cdfb. Consider uploading reports for the commit 7b0cdfb to get more accurate results

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   95.53%   95.53%
=======================================
  Files         353      353
  Lines        2329     2329
  Branches      266      266
=======================================
  Hits         2225     2225
  Misses        102      102
  Partials        2        2

Impacted Files
Coverage Δ

...ackages/react-accordion/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-avatar/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-button/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-card/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-carousel/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-checkbox/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-dialog/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-divider/src/common/isConformant.ts
100.00% <ø> (ø)

packages/react-form/src/common/isConformant.ts
100.00% <ø> (ø)

...kages/react-icon/src/cebus-icons/BackArrowIcon.tsx
100.00% <ø> (ø)

... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2180e...7b0cdfb. Read the comment docs.


update Crescendo field

This involves three files:

JSON for AprilTags
FieldConstants.java (from 6328)
FieldRegionConstants.java

We probably want to address the first two ASAP and then define our regions. Do this work in the 2024-field branch.

We may need to rework how we handle field mirroring based on the behavior of PathPlanner, which reportedly will be similar to Choreo. We may need to undo some changes to vision pose estimation based on how PathPlanner handles everything and how we choose to treat the field origin.

JSON for April Tags added to the branch.
We definitely need to undo some of the mirroring code and update our PathPlanner code when it is released.

With keeping the origin at blue always, we need to think how this impacts field-relative driving....

Need to add the boolean supplier to AutoBuilder.configureHolonomic

The #87 handles everything mentioned above except for the FieldConstants and FieldRegionConstants files.

Fixed with back port from frc-software-2024.


How does eff implement delimited control?

I am reading eff's source code and I saw that in the control operation, it throws a captured frame up to the handler to deal with, instead of resuming it in place. To me (who probably does not have enough context), this seems like extra indirection. What is the motivation for this design?

There are several subtleties here:

First of all, we want to efficiently support both control and control0.

In computations that repeatedly capture and resume the continuation, it’s inefficient to eagerly resume every chunk of the captured continuation every time. That would result in large amounts of memory being copied back and forth between the heap and the stack. Instead, eff restores continuation chunks lazily: once a continuation chunk has been captured, eff leaves it in the heap until it’s actually returned to. This means a portion of the stack may effectively be “compressed”—instead of having the continuation frames on the stack directly, there’s a pointer to a heap-allocated continuation containing the frames.

Eventually, I want to implement something like Scheme’s dynamic-wind in eff, which means I can’t just use distinct PromptTag#s to capture the continuation all at once (since that would skip over any intermediate dynamic-wind frames).

When implementing the above two things, eff must not leak stack space. It is critical that the strategy we use for unwinding and rewinding the continuation does not introduce any additional continuation frames that were not in the original program, as that would create problems for programs like this one:
naturals :: Coroutine i Natural :< effs => Eff effs a
naturals = go 0 where
  go n = yield n *> go (succ n)

This definition of go is tail-recursive, so it should use constant stack space (all other things being equal), but this is pretty easy to mess up unless we are very, very careful.

These requirements inform the “calling convention” used by EVM when capturing and restoring the continuation. This is all intimately related to the following comment:
https://github.com/lexi-lambda/eff/blob/8c4df4bf54faf22456354be18095b14825be5e85/eff/src/Control/Effect/Internal.hs#L283-L286
I still need to write up the appropriate Note to explain the full subtleties, but I’ll try to give a brief, high-level explanation here:

In order to implement our custom calling convention that supports dynamic-wind and lazy continuation restores, we need some way to communicate to enclosing handlers what they should do when control returns to them. This suggests that we should just have a type like this:
data ReturnToHandler
  = ReturnNormal Any
  | ReturnAborting PromptId Any
  | ReturnCapturing (Capture Any)

Then, when promptVM installs the prompt, it can do something like this:
result <- prompt# (ReturnNormal <$> m)
case result of
  ...

But this does not work! The use of ReturnNormal <$> m grows the captured continuation every time promptVM is called, so it will leak stack space if handleVM is used in a tail-recursive loop.

This means we have to somehow implement our calling convention without growing the continuation inside the use of prompt#. But we need to be able to distinguish normal returns from aborts/captures, since we need to apply the onReturn handler when a normal return occurs. RTS exceptions give us a way to do this. When promptVM installs the prompt, it adds a call to onReturn outside of the prompt, so that path will get taken if the computation returns normally.

When there’s a non-normal return, we have to somehow skip that onReturn handler, since in those situations it must not be called. The easiest way to do that is to throw an exception, which will unwind over the onReturn stack frame and get caught by our handler, which can then do whatever special behavior we need to do.

Another way of putting this is that we’re effectively using RTS exceptions as a way to determine whether or not a use of prompt# returned normally or not without growing the captured continuation. This works because RTS exceptions are a first-class mechanism that allow a computation to signal a non-normal return. Yes, this is all outrageously subtle, but that is why it is so important that this stuff is abstracted away in a library, not exposed directly to the user: getting this stuff right is too hard to make it possible to accidentally get it wrong.

Thanks for the writeup! The point about tail calls is indeed very subtle and helps me understand why onReturn exists. I have some other (perhaps stupid) questions:

What is the significance of dynamic-wind in an effect system like eff?
What does "restore the continuation lazily" mean in this context, is it "calling the continuation out of control0#"? Apart from that, in both scenarios it seems like the continuation is called almost immediately (either directly in control0#, or called right away when it is thrown to the corresponding prompt).


PolyMC

This modpack is  supported by polymc

Fabulously Optimized considers PolyMC a compromised abandonware. See https://github.com/Fabulously-Optimized/fabulously-optimized/issues/496


fix should open/alloc_resource in sink operator instead of source

Proposed changes
The sink operator processes the data before the source operator, therefore the expressions need to be opened in the sink operator.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.09 seconds
stream load tsv:          537 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>4 Bytes

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.07 seconds
stream load tsv:          548 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>9 Bytes

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.76 seconds
stream load tsv:          547 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>7 Bytes


Can I use like MIT control method in gazebo ros2 control?

In source code I found control methods are   {
NONE      = 0,
POSITION  = (1 << 0),
VELOCITY  = (1 << 1),
EFFORT    = (1 << 2),
VELOCITY_PID    = (1 << 3),
POSITION_PID    = (1 << 4),
};
How can I use control method like with kp kd postion velocity and effort

Please have a look at the documentation

But I cannot use position, velocity, effort, kp and kd simultaneous

I don't know what the MIT control method is. If you want to apply any learning method - based control strategy (why would one use that in this simulator?): Write your own plugin.


[DC-621] Rate limit exceeded on Achilles test and Achilles heel test

Creates randomized tables so that achilles tests do not hit rate limits.
Also makes the following improvements:

Initialize table achilles_analysis by loading from csv instead of bq VALUES
Update queries in achilles_dml.sql and achilles_heel_dml.sql so that the output fields conform to table fields (name and type)
Use select * instead of bq insert into, which still count towards the table load quota, but highlights issues which could hit table schema/metadata update quota. (This is probably the limit we keep hitting, which is 5 updates every 10 seconds)

I also wanted to note that even though we avoid some of the rate limits in this pull request, we might hit at least one limit, which can cause the test to fail at times when multiple devs are running tests at the same time.
@mark-velez and I believe it could be the Concurrent rate limit for interactive queries — 10 concurrent queries (though it is listed as 100 in https://cloud.google.com/bigquery/quotas, it is set to 10 internally in the project API limit settings) or the Maximum requests per second per project: 10 limit.
This makes at least one query fail due to rate limits, but it is reset almost immediately so subsequent queries run. However, this can result in a failed test.


chore(deps): bump ratatui to 0.26.1

Also updated imports and simplified the dependency definition in Cargo.toml 🐻

Looks like there are some layout changes:
--- STDERR:              heh::bin/heh screen::tests::test_calculate_dimensions_no_popup ---
thread 'screen::tests::test_calculate_dimensions_no_popup' panicked at src/screen.rs:495:9:
assertion `left == right` failed
  left: 22
 right: 24
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Is that an issue? Should I just update the test?

I tested and it seems like the Rect dimensions were slightly different, so the last character of each line was not being shown in the ASCII portion of the screen; I just changed that and I'm gonna merge this! Thanks!


feat(auto dimensions): resize observer to resolve node and port dimen…

…sions automatically

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update "Who likes Kedro?" section on README.md

As presented at Big Data Technology Warsaw Summit
Description

Development notes

Checklist

[X] Read the contributing guidelines
[X] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[X] Updated the documentation to reflect the code changes
[X] Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
[X] Added tests to cover my changes

Notice

[X] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@lorenabalan Iirc there was a mention in the popmon presentation from last year. (A kedro-popmon plugin was created).
Rebased to master


Firebase authentication in serverpod?

Is firebase authentication working in serverpod?
Just tried using the example(flutter) app. I get a weird error and the app does not build at all.

Did you read the section on setting up Sign in with Firebase?
https://docs.serverpod.dev/concepts/authentication#setting-up-sign-in-with-firebase

@vlidholt
It is a bit unclear the statement from docs
Server-side, you need to create a set of authentication keys in the [Firebase console](https://console.firebase.google.com/), download the JSON file, rename it to firebase_service_account_key.json and place it in the config folder.

I think Link should be update to https://console.firebase.google.com/u/0/project/_/settings/serviceaccounts/adminsdk

There now exists a secion in our documentation for Firebase authentication: https://docs.serverpod.dev/concepts/authentication/providers/firebase


Small Correction

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Hi @Rick-Anderson Plz merge the PR.

@AftabAnsari10662  Thanks!


(Enyo) InputHeader: it needs to add exception from 'Input' pre-fix

Issue
InputHeader is cut off because Input height was changed.
Fix
InputHeader shouldn't be applied changed height from Input.
So, I added hegiht: inherit; to Header.less to maintain original height size.
ENYO-4862 (Enyo) InputHeader: it needs to add exception from 'Input' pre-fix
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee<EMAIL_ADDRESS>

I can't make a reliable estimate of what height: inherit will do on an <input> field within a non-statically sized element. :\ This will need to be tested to verify the consequences. The consequences should be localizable to the single component though. Just make sure that it doesn't alter the height of Header with titleBelow and subTitleBelow present.

@Djspaceg  Thanks for review. We can test it in http://<IP_ADDRESS>/~sangwook/InputHeaderSample/dist/.

I'd need more information or testing to provide alternative ideas.

@Djspaceg ,
Or, I think we can set "height" and "line-height" when parent is NOT "headerInput".
Input.less
&:not(.moon-input-header-input-decorator) > .moon-input { 	line-height: 57px; 	height: 57px; }


Delegates with out parameter not generated correctly

Hi again :)
Input:
public delegate void ExpandConstantDelegate(string input, out string output);
public static void RegisterExpandConstantCallback(ExpandConstantDelegate callback)
{
}

Generated test
 [Test]
        public static void CanCallRegisterExpandConstantCallback()
        {
            // Arrange
            Exports.ExpandConstantDelegate callback = (x, y) => { };
                                                          ^ Should have out keyword
            // Act
            Exports.RegisterExpandConstantCallback(callback);

            // Assert
            Assert.Fail("Create or modify test");
        }

Easy to manually fix, just thought I would report it

Fixed in 0.99 - have added a bunch of those sorts of cases to the delegate example (https://unitverse.readthedocs.io/en/latest/examples/DelegateGeneration/)
FWIW, It may be an easy fix - but one of the main goals with Unitverse is to make it emit code that compiles for the vast majority of tests. So even though it's small, please do feel free to open issues for this sort of stuff.
Thanks for the report 👍


Type definition error: [simple type, class org.ehrbase.response.ehrscape.query.ResultHolder]

Configuration information

EHRbase version: 0.17.2 (docker next tag)
openEHR_SDK version: 321ef09
Archie version: 1.0.3
PostgreSQL version: PostgreSQL 14.0 (Debian 14.0-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit
Java Runtime version: Oracle Corporation 11.0.13+8
Operating System version: Linux amd64 5.14.13-200.fc34.x86_64

Steps to reproduce

Upload a template (E.g. body_temperature.opt.txt)
Create an EHR
Create a composition from the template via the ecis API.
Make a POST request to the ecis query API at http://localhost:8453/ehrbase/rest/ecis/v1/query
Simple examples:{
  "aql": "SELECT c FROM EHR e CONTAINS COMPOSITION c[openEHR-EHR-COMPOSITION.encounter.v1]"
}

{
  "aql": "SELECT c/archetype_details/template_id/value FROM EHR e CONTAINS COMPOSITION c[openEHR-EHR-COMPOSITION.encounter.v1]"
}

etc...

Actual result
{
  "action": "EXECUTE",
  "executedAQL": "SELECT c FROM EHR e CONTAINS COMPOSITION c[openEHR-EHR-COMPOSITION.encounter.v1]",
  "resultSet": []
}{
  "error": "Type definition error: [simple type, class org.ehrbase.response.ehrscape.query.ResultHolder]; nested exception is com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer found for class org.ehrbase.response.ehrscape.query.ResultHolder and no properties discovered to create BeanSerializer (to avoid exception, disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain: org.ehrbase.rest.ehrscape.responsedata.QueryResponseData[\"resultSet\"]->java.util.ArrayList[0])",
  "status": "Internal Server Error"
}

Important notes:

When running a query that returns no results (e.g. for a non-existent composition), the error does not occur.

The same queries also run successfully via the openEHR query API at http://localhost:8453/ehrbase/rest/openehr/v1/query/aql however I'm interested in the flat format.

This has also been confirmed on a separate machine running macOS and by compiling and running the latest develop branch rather than the next docker image.

Expected result (Acceptance Criteria)
The results of the query in the flat format.
Definition of Done

[ ] The defect is checked by an unit or an integration test (Robot)
[ ] Merge Request approved
[ ] Unit tests passed
[ ] Build without errors
[ ] Release notes prepared
[ ] No additional runtime warnings

@jessarcher
I'am not sure abut that issue but you will not get beak a query in FLAT format any way. That's not something supported in ehrbase.

Yeah fair point, I can see how that would be hard/impossible when dealing with substructures.
I don't intend for this to be a support issue, but just for clarity I'm trying to retrieve a flat composition when I don't know its ID (i.e. based on EHR ID and the template ID) so I'm assuming I need to run an AQL query to get the composition ID I'm interested in, and then I can hit the ecis/v1/composition/{id} endpoint to get the flat composition by its ID.
I do think this issue is still valid though, as I can't seem to get any results from the ecis query endpoint due to the serialization issue above. In my case I can just use the openehr/v1/query/aql though.

Hello @jessarcher,
Based on comments provided by:

@stefanspiska, it is not possible to get back the result of the query in FLAT format;
@birgerhaarbrandt, ecis aql endpoint will be deprecated. See the comments here: https://discourse.openehr.org/t/software-development-kit-for-app-development/790/44
Considering above two comments, I can assign this ticket back to you and in case you have any other questions/concerns/issue details, just let me know, otherwise, it will be closed correspondingly.
Happy to support you!

Hi @vladislavploaia, Thanks for your response. I've changed jobs so I'm not working with this anymore. All the best!


Bug with minor lifesteal

Mod and Game up to date.
The temp life from minor lifesteal fades the moment i click end turn unless the battle ends from killing all the mobs.

Fixed on DEV branch.


Add IMU Output

The VESC has an internal IMU. Assuming the data are published on the serial bus (which the VescTool seems to indicate), we should be able to read the data and publish a sensor_msgs/Imu.

Hi,
I was wondering if you have made some progress on this package, extracting IMU packets from VESC for use in ROS.
I would like to do this as well, but im not that great on coding in C++, and therefore cant really figure out how to start working on this. But if you or anyone wants more hands to make this package happen faster im willing to volunteer and help out on some aspects, provided I can understand what I need to do.  ;)

I don't know if this will be helpful, but I suggest looking for a component that is -9.81 or +9.81 etc. See https://github.com/f1tenth/vesc/blob/main/vesc_driver/src/vesc_packet.cpp line 127. Seems like mostly they just have one giant packet and specific values are by position?

Hi all.
@JWhitleyWork , i see, and this is something I also got in response from Benjamin vedder and some other people on the VESC github link, ive added that below for reference. There, I asked them about the ros implementation for IMU.
https://github.com/vedderb/bldc/issues/253
I will also go through the code for the VESC and see if I can find the packet, if i do ill let you know.
@travelbureau  I dont think the ROS implementation even mentions that packet, those are new packets added I guess after the package for vesc driver ros package was made. ANd so the packets in vesc driver code have packets which you already get on the topic /vesc/sensors/core and /vesc/sensors/servo.
I think we will need to go to the main vesc code on: https://github.com/vedderb/bldc
and then find the packet from here or reuse their code which is used to transfer stuff to the VESC app made by Benjamin vedder.

@SAA1995 The “ROS implementation” you mentioned IS this repo. Josh has done the CI work so it gets published as a ROS package.

Oh apologies for that. I didnt notice that. I will have a look again then I guess.

Closed with #19


fix(remix-react): Form's method shouldn't be ignored

Fixes #4412

I'm aware of the <form> default and spec. But Remix documentation clearly states that Remix <Form> supports DELETE, PATCH etc. in addition to GET& POST: https://remix.run/docs/en/v1/api/remix#form-method

We definitely shouldn't break existing behavior, so limiting <Form> to GET and POST would need to be considered in a future major release. Probably worth opening a discussion for that if that's something you feel strongly about, as we have no plans for that at the moment. This is an intentional deviation from the basic <form> as noted in the docs. The no-JS tests should reflect those differences for now.

As for other methods, those are great points on the docs and breaking changes. I wonder if we should more strongly discourage their usage (e.g. in dev mode do a console.warn)? One of Remix' big selling points is that it works before/without JavaScript, and this violates that.

Would you like to start a new discussion on that? I think there's merit and I'd be happy to run it up the flag pole (aka get @ryanflorence to weigh in since his GH notifications are a tire fire 😂)

Sure thing, will do 👍
On Tue, Oct 25, 2022 at 12:52 PM Chance Strickland @.***>
wrote:

As for other methods, those are great points on the docs and breaking
changes. I wonder if we should more strongly discourage their usage (e.g.
in dev mode do a console.warn)? One of Remix' big selling points is that it
works before/without JavaScript, and this violates that.
Would you like to start a new discussion on that? I think there's merit
and I'd be happy to run it up the flag pole (aka get @ryanflorence
https://github.com/ryanflorence to weigh in since his GH notifications
are a tire fire 😂)
—
Reply to this email directly, view it on GitHub
https://github.com/remix-run/remix/pull/4413#issuecomment-1291000963,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2XMKOBUT24MVM5XQ6LS3WFAT7JANCNFSM6AAAAAARNVVQIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Opened a discussion here

Should be fixed in 1.7.4-pre.0. We'll get a stable release out tomorrow.


Routine handler refactoring

Codecov Report
Attention: Patch coverage is 37.93103% with 36 lines in your changes missing coverage. Please review.

Project coverage is 29.23%. Comparing base (a09a171) to head (aae3cf8).

Files with missing lines
Patch %
Lines

pkg/service/cluster_config_writer.go
0.00%
20 Missing :warning:

pkg/service/paths.go
51.51%
14 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #251      +/-   ##
==========================================
+ Coverage   27.79%   29.23%   +1.43%
==========================================
  Files          39       40       +1
  Lines        2245     2275      +30
==========================================
+ Hits          624      665      +41
+ Misses       1529     1515      -14
- Partials       92       95       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


failed: (404)[localhost could not be found or is considered invalid

I have the following code to get an ST from my CAS server hosted on my localhost.
So the method requestTicketGrantingTicket in the CasRestAuthenticator.class is retrieving as locationHeader = https://localhost:6443/cas/v1/tickets/TGT-12-Qc3BgeIJASAHldSMKdoFEJZNL3-SpxF4OkE-mqrNhttps://localhost
and them do....
 var9 = locationHeader.substring(locationHeader.lastIndexOf("/") + 1);
and only get "localhost" who is an invalid ticket instead of  TGT-12-Qc3BgeIJASAHldSMKdoFEJZNL3-SpxF4OkE-mqrNhttps://localhost
        final MockHttpServletResponse response = new MockHttpServletResponse();
        final WebContext webContext = new J2EContext(request, response);

        UsernamePasswordCredentials usernamePasswordCredentials = new UsernamePasswordCredentials(user.getUsername() , user.getPassword());

        CasConfiguration casConfiguration = config.getClients().findClient(CasClient.class).getConfiguration();
        final CasRestAuthenticator casRestAuthenticator = new CasRestAuthenticator(casConfiguration);

        // authenticate with credentials (validate credentials)
        casRestAuthenticator.validate(usernamePasswordCredentials, webContext);

        // get user profile
        final CasRestProfile userProfile = (CasRestProfile) usernamePasswordCredentials.getUserProfile();```

Pleas use the mailing list for questions: https://groups.google.com/forum/?fromgroups#!forum/pac4j-users


Add support for explicit loader chains in extracted files

Hi @jhnns and @meaku 🙂
I have a problem with the extract-loader when it comes to explicit loader strings inside your extrated files.
For example this <script src="${require('!!file?name=err.js!./error.js')}"></script> in a file that is extracted with extract-loader leads to the following error:
Module build failed: Error: Cannot find module '/Users/xyz/workspace/repos/github/extract-loader/test/modules/!!file?name=err.js!./error.js'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at /Users/xyz/workspace/repos/github/extract-loader/lib/extractLoader.js:74:24
    at require (/Users/xyz/workspace/repos/github/extract-loader/lib/extractLoader.js:56:33)

This is caused by calling the native node.js require() on all .js-files without checking if they are only referencing a file path or a whole loader chain. This PR adds a simple check for this. Let me know what you think 👍
See you!
Ben
P.S.: I added tests for you to reproduce the behavior.

Coverage remained the same at 98.039% when pulling 999c06c73d083805afbe3d9bdf66a6d4f29597f0 on sueddeutsche:hotfix/loader-string into da2e227ecf0f100f79f6484b9ed60e6f16e12d3b on peerigon:master.

Coverage remained the same at 98.039% when pulling 999c06c73d083805afbe3d9bdf66a6d4f29597f0 on sueddeutsche:hotfix/loader-string into da2e227ecf0f100f79f6484b9ed60e6f16e12d3b on peerigon:master.

Test failure seems to be caused by a incompatibility of loader-utils with node.js 0.12. Should this still be supported? Otherwise #19 could be merged.

Awesome 👍
I've already merged #7 which makes the regexp more specific to the css-loader. Could you rebase your PR and keep the regexp as it was provided by #7? Your tests should still work with that regexp.
I will refactor the regexp again to only match css-loader specific files because css-base is still too loose.
Also merged #19, so node 0.12 support should be no problem anymore.

Sure thing 👍 Done!

Coverage remained the same at 98.039% when pulling e7e361e5c5a841db105396bc663090fc495a4ca8 on sueddeutsche:hotfix/loader-string into a753af0fde2c21071e3063cc17ca7dc4fd234028 on peerigon:master.

Nice, thx!


feature: compact file tree view

Did you check the docs?

[X] I have read all the docs

Is your feature request related to a problem? Please describe.
Hello,
The folder architecture of java projects favors the creation of folders with only one folder inside.
Here is a typical example of file tree inside fugit2 with a java project :

src

main

java

fr

epicanard

myproject

folderA

fileA.java

folderB

fileB.java

test

Describe the solution you'd like
The idea behind this feature is to have a compact view where a folder with a single folder child can be compacted into one line.
Maybe you can add a feature toggle in the config to be able to choose between normal view and compact view ?
Example :

src

main/java/fr/epicanard/myproject

folderA

fileA.java

folderB

fileV.java

test

Describe alternatives you've considered
no other alternatives
Additional context
No response

Hello @SuperBo,
It works wells when the preview is closed, I can stage / unstage a compact folder
But when the preview is open I have the error [Fugit2] Failed to get unstage patch  when I try to stage / unstage a folder

sorry @EpiCanard, https://github.com/SuperBo/fugit2.nvim/commit/00ab1fc7e77db15ce884dd195e876c0f7f759a37 this should fix that issue.
Could you help me verify this solve the new bug when patch view is on?

Your fix works, I can stage / unstaged a folder with the preview open.
I can't discard a folder, but it doesn't seem to work with the commit before the compact folder feature.

Can you create new issue with the discard problem for directory @EpiCanard :D. That maybe not related to new compact view.
I will close this issue for better issue tracking.
Thank you for your suggestion and testing new feature @EpiCanard .

New issue created https://github.com/SuperBo/fugit2.nvim/issues/93
Thanks for adding this compact folder feature, it will be pleasant to use :)


fix bug in tpcc benchmark.

this PR fixed a double-free bug in hard-coded tpcc benchmark.

Coverage decreased (-0.2%) to 53.17% when pulling 40fe45bb2f66cb81bd7216745a09807f548bc73c on yingjunwu:master into 8ac66eee14f4e91e800edd7d9b74f6951c8dbc0b on cmu-db:master.


How to build a dataset navigator

Hi,
I'm stuck on figuring out the best way to achieve a simple thing.
Part of my app needs to allow the user to step through records in a database using Next/Previous buttons

I thought one way to do this would be to have a FutureProvider for the Record that makes async calls to web api.
The query it sends to the API depends on which button was pressed (Next or Previous), so I thought I could make it watch another provider that encodes the command:
enum Cmd {
  none,
  next,
  previous
}
gProvCmdProvider = StateProvider<Cmd>((ref)=>Cmd.none)

gProvRecordProvider = FutureProvider.autodispose<Record>((ref) async {

  final cmd = ref.watch(gProvCmdProvider);

  // web api query depends on the command
  final qry = buildQry(cmd);
  final data = await fetch(qry);

  return Record(data);
})

onPressed handlers in the UI could then do
ref.watch(gProvCmd).state = Cmd.next
or
ref.watch(gProvCmd).state = Cmd.prev
Questions:

Once gProvRecordProvider  has consumed the command, I want to set gProvCmdProvider back to Cmd.none. But I cant do that in gProvRecordProvider because circular reference type issue. I would like gProvCmdProvider to be a "one-shot" that auto-resets itself to "none"
Pressing next or prev buttons might cause the server to return "no more records" error, in which case I want gProvRecordProvider to return the same Record it returned last time. Does Riverpod store that info anywhere?
I also want to implement a Goto button which prompts the user for a record Id to jump to. I could encode that either in another provider like gProvCmdProvider, or in its own provider - but once again, it needs the ability to cope with resetting itself or handling the case where record not found

Many thanks

Hello!
That's not the correct architecture. You probably don't want that Cmd enum. Instead use an int for the page index
final page = StateProvider<int>((ref) => 0);

which you increment/decrement on prev/next tap


Editor: Excess or missing arguments in a function call highlight the whole call in red, including all anonymous function bodies

As a follow-up to #7703, I'm trying to investigate more scenarios where excessive editor error highlighting interferes with editing or renders it less convenient. Seems like many of these have to do with anonymous functions, as in many cases they are passed as function arguments, which are usually expected to be quite short. However in callback or promise heavy code they may end up to be very long and span multiple lines or even pages.
Another case I've found is when there are excess or missing arguments in a function call, though here it would highlight the whole function call expression, which would include all the bodies of all the anonymous functions passed as arguments, and may span as many lines or pages as the call would.
Edit: removed an incorrect example!
Reduced test cases
This one happens with the function() syntax as well:
Excess arguments:
function func(f: () => void) {
}

func(() => {
    let x = 1;
    return;
}, 42);

func(function () {
    let x = 1;
    return;
}, 42);

Missing arguments:
function func(f: () => void, n: number) {
}

func(() => {
    let x = 1;
    return;
});

func(function () {
    let x = 1;
    return;
});

Perhaps this could be alleviated if we could accurately determine if a semantic error falls within a non-completed node. We have some logic for this.

@DanielRosenwasser
I rechecked, my first example was wrong. The whole thing was marked in red only when the call expression was closed with a parentheses, but I would still say it looks a bit excessive.

@DanielRosenwasser
I take it back. I rechecked again and it did happen without it (was it some strangeness in VS code perhaps?)
function func(onSuccess: () => void, onError: () => void) {
}

func(() => {
    let x = ... // User has begun typing the first callback, but regardless of how error-free
                // it is, it would still be highlighted in red unless there is at least some
                // placeholder for the second callback
}

First example was wrong, sorry about that (I removed it). I'll try to find better ones.
In any case if anyone knows of more these "wall-of-red' scenarios then please mention. I feel the editing experience (which is already pretty good, but not as good as say, C#) would improve significantly without them.

@DanielRosenwasser
In the case missing arguments there is a simple alternative, perhaps only highlight the closing parenthesis or the last line of the call expression?
function func(f: () => void, n: number) {}

func(() => {
    let x = 1;
    return;
}); <--- only the parenthesis or line highlighted

The case of excessive arguments is less "obvious", since it would seem natural to simply highlight the excessive arguments, but in case they are anonymous functions, they could span many lines or even several pages! Highlighting only the comma, after the last argument that is not excessive seems like a viable option, though somewhat "mild" (I'm personally OK with mild highlighting though :) ):
function func(f: () => void) {
}

func(() => {
    let x = 1;
    return;
}, 42); <-- only the comma highlighted here

The excess arguments case got improved over the years - the missing argument case still highlights the whole call expression but perhaps it could only highlight the callee.


Change feathers-client to npmcdn.com with version range

This switches the docs to use feathers-client from npmcdn.com. This is a great change because it supports SemVer version ranges (like<EMAIL_ADDRESS>and we don't need to check in the distributables anymore.
@ekryski Can we change this on the homepage Gists as well?
Closes #120

Done! :shipit:

I think you forgot the ^ (needs to be <script type="text/javascript" src="//npmcdn.com/feathers-client@^1.1.0/dist/feathers.js"></script>). That way we don't have to update it with every release.

Fixed. Thanks @daffl