Configuration of root CA file is inconsistent across services...

While working on a recent update to the snap packaging (issue #2051), I noticed a few inconsistencies involving the configuration keys, and and sometimes the value of the root CA path across the various configuration files used by core-, security-, and support-* services.
One inconsistency is that some services use the top-level configuration key SecretStore (core-, and support- services), whereas some use SecretService.
The next inconsistency is the name of the root CA file path. Some use CaFilePath (security-secretstore-setup), some use CACertPath (security-proxy-setup), and some use RootCaCertPath (core-, and support- services).
The final issue is that the values used in the various configuration files differ as well, and thus most of them need to be overridden in the docker-compose files (and the snap). For instance, security-secretstore-setup uses /tmp/edgex/secrets/ca/ca.pem, whereas security-proxy-setup uses res/EdgeXFoundryCA/EdgeXFoundryCA.pem (the latter is overridden by a service-specific env var override in docker-compose-nexus-mongo.yml).
Also note, in the snap, due to a misconfiguration of security-secrets-setup, the directory $SNAP_DATA/pki/EdgeXFoundryCA, isn't properly cleaned up, which means there are two identical root certificates, one named ca.pem and one named EdgeXFoundryCA.pem that get created (see issue #2547 for details).
At minimum, we should make sure all the default values are correct in the configuration.toml files, and if possible at least fix the security-proxy-setup to use CaFilePath instead of CAFilePath so that the security services are aligned.
This bug is being reported against the master branch.

For instance, security-secretstore-setup uses /tmp/edgex/secrets/ca/ca.pem, whereas security-proxy-setup uses res/EdgeXFoundryCA/EdgeXFoundryCA.pem (the latter is overridden by a service-specific env var override in docker-compose-nexus-mongo.yml). I've always wondered why we have two identical root certificates, one named ca.pem and one named EdgeXFoundryCA.pem that get created?

I've always wondered why we are compiling the configurations files into the containers, instead of injecting the configuration at runtime.  IMO the configuration.toml files don't even belong in the codebase.

There is value to having a configuration.toml in the code base as a sample (all the knobs one can set) and default. Through injection or environment variable settings some of the settings may be modified.

@mkbhanda I agree that documentation of what each service needs for configuration is important, but  we are also overly dependent on what the actual values for these settings are, such that inconsistencies among the reference values are causing confusion.

For future documentation [SecretStore]  is the configuration used by go-mod-secrets to find the secretstore.  '[SecretService]' is supposed to be the private configuration used by security-secretstore-setup to do its initialization thing with Vault.  Ideally, SecretService should inherit the same configuration keys as SecretStore so that is less confusing.

Related issue: #2200, where it was decided in this release to keep using [SecretService] keys in this release for proxy-setup.

Would it make sense to use Viper https://blog.gopheracademy.com/advent-2014/configuration-with-fangs/ to bring together all our ways of configuration, use a standard precedence order, facilitate 12 factor apps etc? Viper supports aliases, so different projects could continue to use old names without breaking things.

Viper looks very promising.

So the SecretService vs. SecretStore difference was explained by @bnevis-i, thanks.
Regarding the config keys used for the root CA file path, @tingyuz said we couldn't fix this because it would break compatibility:

Some use CaFilePath (security-secretstore-setup), some use CACertPath (security-proxy-setup),

I questioned the statement that this would break compatibility because we made some other changes to config keys as part of Geneva. In fact see the following commit 4ecacc7 where all of the keys under SecretService were changed from lowercase to CamelCase.
And finally, do we still need to copies of the rootCA certificate with different names per:

I've always wondered why we have two identical root certificates, one named ca.pem and one named EdgeXFoundryCA.pem that get created?

I've always wondered why we have two identical root certificates, one named ca.pem and one named EdgeXFoundryCA.pem that get created?

It's technical debt.  I believe the original tool was called PKI-init, which did the named certs.  Then Jim and I wrote pkisetup to ride on top of it and do a bunch of file copies to stash the certs in the appropriate places.   This was our first contribution, and the feedback was to combine the two utilities into one -- security-secrets-setup -- because we were so late for Edinburgh(?) release we did it quick and dirty by smashing the two code bases together -- pkiinit is still in there even though it is a single executable now.

I've always wondered why we have two identical root certificates, one named ca.pem and one named EdgeXFoundryCA.pem that get created?

It's technical debt. I believe the original tool was called PKI-init, which did the named certs. Then Jim and I wrote pkisetup to ride on top of it and do a bunch of file copies to stash the certs in the appropriate places. This was our first contribution, and the feedback was to combine the two utilities into one -- security-secrets-setup -- because we were so late for Edinburgh(?) release we did it quick and dirty by smashing the two code bases together -- pkiinit is still in there even though it is a single executable now.

Are they both used, or could we remove one of them?

@jim-wang-intel Can you make a recommendation to Tony on how to get EdgeXFoundryCA.pem thrown away at the end of security-secrets-setup?

@bnevis-i  the generated file EdgeXFoundryCA.pem should already be deleted at the end of generate command from security-secrets-setup: see this: https://github.com/edgexfoundry/edgex-go/blob/master/internal/security/secrets/command/generate/generate.go#L69-L70 line of code.
Not sure why there is a left-over there...

@tonyespy what is left for this one.  Do we need to scrub EdgeXFoundryCA.pem from the configuration.toml scripts?

@bnevis-i @hutchic I reviewed my original issue and here's an updated status of the issue which actually had four components:

use of SecretStore [core-, support-] vs. SecretService [proxy/secretstore-setup] -- this is still an issue, but was punted from Geneva due to the concern that it would be break backwards compatibility with Fuji. This still applies to Hanoi as well as the planned version is 1.3. Also see related issue #2200 where a decision was reached to not update proxy-setup to use go-mod-secrets. I think this could probably be split out into a separate issue and targeted for Ireland, which in theory is supposed to be a 2.0 release.

CaFilePath (secretstore-setup), CACertPath (proxy-setup), and RootCaCertPath (everything else) -- this issue still exists, but for the same reasons as above, these can't be aligned until Ireland.

actual values of cert paths differ across services (eg. /tmp/edgex/secrets/ca.pem vs. res/EdgeXFoundryCA/EdgeXFoundryCA.pem) -- this issue still exists, and could be cleaned up as most of these values are overridden using environment variables in docker-compose and the snap.

$SNAP_DATA/pki/EdgeXFoundryCA directory isn't properly cleaned up -- this was fixed in the Genava release, so is no longer an issue.

Proposal is to change the lines marked with an ❌ from the ca.pem path to the EdgeXFoundryCA.pem path.
$ grep -ri /EdgeXFoundryCA.pem .
./cmd/security-secrets-setup/res/local-tls.hcl:  tls_client_ca_file ="/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem"
./cmd/support-logging/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./cmd/core-command/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./cmd/support-notifications/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./cmd/core-metadata/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./cmd/security-proxy-setup/res/configuration.toml:CACertPath = "res/EdgeXFoundryCA/EdgeXFoundryCA.pem"
./cmd/support-scheduler/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./cmd/core-data/res/configuration.toml:RootCaCertPath = '/vault/config/pki/EdgeXFoundryCA/EdgeXFoundryCA.pem'
./internal/security/proxy/testdata/configuration.toml:CACertPath = "res/EdgeXFoundryCA/EdgeXFoundryCA.pem"

$ grep -ri /ca.pem .
❌./openapi/v2/core-data.yaml:                    RootCaCertPath: "/tmp/edgex/secrets/ca/ca.pem"
✔./snap/local/runtime-helpers/config/security-secret-store/vault-config.hcl.in:  tls_client_ca_file ="$SNAP_DATA/secrets/ca/ca.pem"
✔./snap/snapcraft.yaml:  SecretStore_RootCaCertPath: $SNAP_DATA/secrets/ca/ca.pem
✔./snap/snapcraft.yaml:      SecretService_CaFilePath: $SNAP_DATA/secrets/ca/ca.pem
✔./snap/snapcraft.yaml:      SecretService_CACertPath: $SNAP_DATA/secrets/ca/ca.pem
✔./snap/snapcraft.yaml:      SecretService_CACertPath: $SNAP_DATA/secrets/ca/ca.pem
❌./snap/snapcraft.yaml:                  sed -e "s@\"/tmp/edgex/secrets/ca/ca.pem\"@\"\$SNAP_DATA/secrets/ca/ca.pem\"@" \
❌./cmd/security-secretstore-setup/res/configuration.toml:CaFilePath = "/tmp/edgex/secrets/ca/ca.pem"
❌./cmd/security-secretstore-setup/res-file-token-provider/configuration.toml:CaFilePath = '/tmp/edgex/secrets/ca/ca.pem'
✔./cmd/security-secrets-setup/start_vault.sh:              tls_client_ca_file ="'${VAULT_TLS_PATH}'/ca.pem"
✔./cmd/security-secrets-setup/README.md:sudo diff -r /etc/edgex/pki/ca/ca.pem /run/edgex/secrets/ca/ca.pem
❌./cmd/security-secretstore-read/res/configuration.toml:  RootCaCertPath = "/tmp/edgex/secrets/ca/ca.pem"

@hutchic @tonyespy do yo have feedback on the proposal or should we punt the whole thing to Ireland release?

I'm not positive on the scope of work but given the time frame available I think it would be acceptable to allow this to slip to Ireland

See issue #2873 for yet another example of inconsistent security configuration.

@lenny-intel verify if recent cleanup activities addressed this issue.

This was address by #3181 and #3189


Collective picker: apply latest design

:art:  See latest design on figma
Remove custom icons, use ( + ) icons and use new labels
Today

Expected

Add lines next to type labels
Today

Expected

Update font-sizes
See design on Figma

:gift: :money_with_wings: A $200 bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with $200 when the Pull Request is reviewed, accepted and merged.
:arrow_right: More info

@Betree Taking this on

:trophy: This issue has been completed by @flickz
To claim the $200 bounty, you can either:

Submit an invoice to https://opencollective.com/engineering/expenses/new (please mention the issue number in the expense's title)
Or ask for an Open Collective gift card of the same value (to donate to other collectives)


Empty commit for cross-PR testing

As the title says - do not merge please.

Resolves SR-NNNN.

apple/llvm-project#5039
@swift-ci Please ASAN test macOS platform

apple/llvm-project#5039
@swift-ci please asan test

@swift-ci smoke test

https://github.com/apple/llvm-project/pull/5039
@swift-ci please asan test

https://github.com/apple/llvm-project/pull/5039
preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,single-thread
@swift-ci Please test with preset macOS

https://github.com/apple/llvm-project/pull/5039
@swift-ci please test macOS platform

https://github.com/apple/llvm-project/pull/5039
preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,single-thread
@swift-ci Please test with preset macOS


Fix application manager addon deploy name on the managed cluster

Signed-off-by: Mike Ng<EMAIL_ADDRESS>

/lgtm


feat(CallExpression): add $event to scope, use call args

Fixes #46

@EisenbergEffect is this related:  https://github.com/aurelia/templating-binding/issues/9 ?  Do we need the equivalent of knockout's $data added to the scope in the same fashion as $event ?


tap: Support tls labeling

The proxy's metrics are instrumented with a tls label that describes
the state of TLS for each connection and associated messges.
This same level of detail is useful to get in tap output as well.
This change updates Tap in the following ways:

TapEvent

Added source_meta field including source labels
proxy_direction enum indicates which proxy server was used.

The proxy adds a tls label to both source and destination meta indicating the state of each peer's connection
The CLI uses the proxy_direction field to determine which tls label should be rendered.

I think this isn't quite right -- should have a follow-on today

@olix0r

I think this isn't quite right -- should have a follow-on today

Is this branch currently ready for review?

yes

published to docker as git-c29c52e9


[deliver] Add option to allow listed folders to pass unsupported languages check

In #9351 a check for unsupported languages in fastlane/metadata was added.
In #10122 an additional option to ignore this check was added because the feature broke custom file and folder structures.
For all people using non-standard directory and file structures, this option, of course, makes usage of deliver possible again, but they lose the very useful unsupported languages check.
I suggest a new option exclude_from_language_directory_validation (or similar) that accepts a list of folder names that should not be checked and allowed to pass the check. This way people can supply their screenshots folder they keep in metadata and still benefit from the language validation.
(The real fix would be to not mix language folders with other folders but group them in a subfolder. But as this won't change anytime soon, this could be handled right now in this way)

Sorry @fastlane-bot, I still want to work on this one day.


Node.js v18 Compatibility Test for [dashboards-maps]

Introduction
As part of our continued efforts to improve OpenSearch Dashboards, we are planning to upgrade the underlying Node.js version from v14 to v18. This change will enhance performance, add new features, and bolster security. However, such major version changes might also affect the compatibility of existing plugins. Here is more introduction: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3601.
Therefore, we kindly request assistance in testing this plugin the compatibility of with this new version of Node.js. We've prepared a branch with the Node.js v18 upgrade, which you can find here:
https://github.com/AMoo-Miki/OpenSearch-Dashboards/tree/node-18-webpack-4
Steps to Proceed

If you think your plugin won't be affected by OpenSearch Dashboards Node.js upgrade. Pls ignore the rest steps and close the issue directly.
Pull the provided branch that includes the Node.js v18 upgrade and OpenSearch 3.0.0.
Hook up your plugin with the updated OpenSearch Dashboards.
Run your existing test suites and perform manual testing as necessary.
If no issues are encountered, feel free to close this issue.
If there are any problems, report them in this issue thread and also link them in the overall OpenSearch Dashboards Node.js upgrade issue thread https://github.com/opensearch-project/OpenSearch-Dashboards/issues/4058
The purpose of linking any questions or issues back to the main issue is to maintain visibility and transparency among all plugin owners. A problem encountered by one plugin might also affect others. This shared knowledge base will foster collaborative problem-solving and prevent duplication of effort.

We appreciate your support and cooperation in ensuring a smooth transition to Node.js v18 for the entire OpenSearch Dashboards community.

The official Node.js 18 PR raised in OSD: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4071

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4071 support node 14, 16 and 18. Pls test on node 18.
nvm install 18.16.0
nvm use 18.16.0

Tested at OSD node-18-webpack-4 branch and dashboard-maps main branch with node 18.16.0, works good on my local development env.


startDayOfYear and endDayOfYear, year, month, day

Why has Darwin Core got startDayOfYear and endDayOfYear terms when these can be derived from eventDate? It is difficult to know how to determine these terms when eventDate is a range and spans more than a year.
Also, I can understand that Darwin Core needs month and day, because sometimes these data are available when the year is not. Apparently, ISO8601 does not support an unknown year (https://en.wikipedia.org/wiki/ISO_8601).
However, this means the dwc:year is redundant, it can always be derived from dwc:eventDate.
What is the argument for keeping dwc:startDayOfYear,  dwc:endDayOfYear and dwc:year?

These two terms derive from a term that was in the original release of Darwin Core as far back as 1999. At the point the term was (incorrectly) named JulianDay. One of the principles behind the first release of Darwin Core as a standard in 2009 was to not lose any concepts that were already in use. Since the original year, month, day were deemed insufficient to express events, the concept of JulianDay turned into the two terms we have today. That's the history justification. The utility justification is that these can be very interesting to use as search terms when it comes to questions such as phenology. Just because they can be derived from eventDate doesn't mean they aren't useful concepts to define, and Darwin Core is made for defining concepts.
As for populating them in the case you present, it is no different from any other case. use the day of year for the earliest date (not smallest day of year, necessarily) for the startDayOfYear and the day of year for the most recent date (not largest day of year, necessarily) for the endDayOfYear. If the eventDate spans a single day, use the same value for both startDayOfYear and endDayOfYear.
Similar arguments hold for dwc:year, which has also been with us (DwC) since the beginning.
Recent attempts to suggest the removal of the utterly redundant dwc:individualCount (https://github.com/tdwg/dwc/issues/185) and the inability to reach a consensus on the removal of ANY Darwin Core term in the Kill Your Darwin Core Darlings Initiative (https://docs.google.com/forms/d/e/1FAIpQLScgQn291GufuaJB6bsbNhqOhWBpFXaqDtXMjmq2WqEQBe1_mA/viewform) suggest that removal of terms is an immense challenge once they come into practice. This is particularly true of those that are entrenched.
Of 1,213,409,995 Occurrence records in GBIF as of 2019-04-15, 869,895,712 (71.6%) include dwc:year in the original data. The percentage for dwc:startDayOfYear and dwc:endDayOfYear are 9.1% and 8.2% respectively.

Certainly, year is a useful term to search on, though most, if not all, databases will do this on-the-fly from a date. I have certainly populated dwc:year in some of my datasets, just because I felt I was being more complete. However, it is redundant and potentially a source of error and confusion.  Obviously, year is not much use for search if dwc:eventDate is consistently populated.
I'm sympathetic to the difficulties of getting rid of fields such as dwc:individualCount. However, in that case people are using it to fulfill a need not currently accommodated. That is, documenting the number of individuals that makes up a specimen, rather than the count of the number of individuals in a population/observation. In the case of dwc:startDayOfYear, dwc:endDayOfYear and dwc:year they can all be calculated from dwc:eventDate or used to populate dwc:eventDate if it is empty. We don't have a separate year for all the other dates in DwC, only the event date.
Even if something is deprecated it doesn't stop people using it, it just doesn't encourage people to use it.

It is true that dwc:year, dwc:startDayOfYear and dwc:endDayOfYear may be derivable from a dwc:eventDate, but it is not necessarily trivial to do so in everyone's everyday working environment. I think it is a service to added provide these.
The number of individuals that make up a specimen can be accommodated with a dwc:organismQuantity and dwc:organismQuanityType="individuals in specimen".  to me dwc:individualCount is utterly redundant aside from the fact that it was there first.

dwc:individualCount is far from redundant given that you would like to express more than one dimension of organism abundance in a simple dwc format. e.g. dwc:individualCount="1", dwc:organismQuantity="129", organismQuantityType="biomassG". For applications of the data, it is often extremely useful or even necessary to know how many individuals that the measure of biomass is based upon.
That being said, and sticking to the topic of the tread: Terms describing temporal dimensions that technically can be captured in dwc:eventDate (e.g. dwc:year) are in my opinion technically redundant, but serves practical purposes as long as data aggregators such as GBIF does not recognize interval expressions in temporal dimensions, a common case, due to either uncertainty in underlying data source or sampling conducted with gear that samples over periods of time such as malaise traps (the inability of dwc to distinguish between such cases in expressing temporal intervals is a different but still an annoying issue). A hack to this is to publish data with dwc:eventDate representing the correct interval and including dwc:year and other time measures to let the data aggregator ingest temporal information from this.

Yes, GBIF is still not handling valid ISO8601 date ranges, though your workaround only works if the data range is shorter than a year and all of mine are longer than a year. They are also automatically  populating the dwc:year, dwc:month & dwc:day with the information from the first date in the date range.
This is an issue for GBIF. I don't think the standard should have to support these errors.
Also, there is nothing stopping any database manager implementing a year field if they think is will be more efficient, but that is different from having it in the standard.
Correct me if I'm wrong, but Darwin Core is an exchange standard to improve the interoperability of data. The addition of date derivatives and the lack of proper support for ISO8601 actually reduces interoperability.

Fully supporting ISO8601 date ranges would be a significant change to our API.  We're working towards that.  There's some older discussion on https://github.com/gbif/gbif-api/issues/4 and https://github.com/gbif/gbif-api/issues/2, but the final implementation hasn't been decided.
As you say, we now automatically populate year/month/day using the start of a date range.  This was only introduced in October.

A hack to this is to publish data with dwc:eventDate representing the correct interval and including dwc:year and other time measures to let the data aggregator ingest temporal information from this.

The ideal for GBIF now is having only dwc:eventDate. We can then derive the other fields from that. It's more complicated to decide what should happen when dwc:eventDate conflicts with one or more of dwc:year, dwc:month and dwc:day.
We don't do much at all with startDayOfYear or endDayOfYear; neither interpretation nor allowing searching on the field.
I think I would recommend people publishing data to GBIF not to populate year, month, day,  startDayOfYear or endDayOfYear, but instead rely on GBIF to derive them for searching and analysis.

Hi @MattBlissett you don't say it explicitly, but it seems from what you say that you would support the deprecation of dwc:year, startDayOfYear & endDayOfYear. It looks like that is the direction GBIF is going in. If you recommend people not to complete these fields the deprecation is a mechanism to do this.
Perhaps the best move is to do this once 8601 date ranges have been implemented properly on GBIF.

However, they're useful as search terms and we've no intention to change that. They're probably also useful for users who can do basic analysis without needing to parse all the dates.

This is exactly why they were adopted in the first place. It is useful to have solid definitions for them, but probably less useful to expect a data publisher to produce them when they can be derived rigorously from other primary data. Given their value as search terms, I would not recommend trying to deprecate them.

This issue was proposed as a set of questions, which seem to have been answered.


Making other portals above than the others

If I call <Portal> on multiple components, there's a tendency for some components to be above than the other components, but what if I want to be able to order them, like <Portal priority={1}> the higher the number provided the higher it is on the stack, so that priority={10} is on top of priority={9}.

hi @aprilmintacpineda , may I ask if you have fixed or any solution regarding this? thanks

Hi, sorry but I didn't have any.

Hi @calz10 @aprilmintacpineda @Mursivic
Any solution for this?

Staking Host it self works for me
<Host>  // <-------- H1
<Stack
  screenOptions={{
    headerShown: false,
  }}
/>
</Host>
<Host style={{ position: 'absolute' }}>    / /<-------- H2
<Portal key={1}>
  <Toast config={toastConfig} position="top" />
</Portal>
</Host>

Sad to see that until today this still hasn't been attended to, maybe there's just not enough requests for it.

I also encountered the same need. There are too many issues with react native, which is very frustrating. It's really not a mature framework.


Compile errors on UE 5.1.1

Hey there, we just upgraded from v1.1.3-RedTechArtTools-win64 to main @ d42c52ed693de0ddb81e68cd3678babcf4a77c98 / 2023-03-01 for to prep for our 5.2 upgrade.
Here's a summary of the changes I had to make:
--- RedMultiLineEditableTextBox.cpp
@@ -38,13 +38,13 @@
 	MyEditableTextBlock = SNew(SMultiLineEditableTextBox)
 	.AllowContextMenu(AllowContextMenu)
 	.Style(&WidgetStyle)
 #if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION <= 1 && ENGINE_PATCH_VERSION < 1
 	.TextStyle(&TextStyle);
 #endif
-#if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION > 1
+#if ENGINE_MAJOR_VERSION >= 5 && ENGINE_MINOR_VERSION >= 1
 	.IsReadOnly(GetIsReadOnly())
 #else
 	.IsReadOnly(bIsReadOnly)
 #endif
 //		.MinDesiredWidth(MinimumDesiredWidth)
 //		.Padding(Padding)

--- RedEditorIconWidget.cpp
@@ -21,13 +21,14 @@
 // SOFTWARE.

 #include "RedEditorIconWidget.h"

 #include "Brushes/SlateImageBrush.h"
 #include "Components/Image.h"
-
+#include "HAL/FileManager.h"
+#include "Launch/Resources/Version.h"

 void URedEditorIconWidget::SynchronizeProperties()
 {
 	Super::SynchronizeProperties();

 #if ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION > 1

I suspect there's a bunch more places where #include "Launch/Resources/Version.h" is necessary due to unity builds.

Thanks for these. A pull request would also be appreciated, otherwise i will attempt to merge them when i get the chance. Be aware that if you are on 5.1, you will need to be on the 5.1 branch's content.

7e927cf


DOC: Improve docs for jax.numpy: remainder, mod and fmod

Part of #21461

Thanks! Squashed

We've had some trouble pulling this in for some reason (maybe related to the jax-ml org migration?)
Could you please rebase on the updated main branch so we can try again? Thanks!

It was automatically closed because I have pushed before committing while squashing the commits by mistake. Sorry for the inconvenience caused.

If you re-push the changes we should be able to re-open the PR

I pushed it again.

OK, reopening

Thank you.


The position id for q

Hello,
I wonder if the position id of query is the same with key or is the actual generated context length (this comment is confusing me)?
For example, as mentioned in the toy example, the position id for key of M is 9.  What's the position id for q of M? 9 or 12 here? And more , why make this choice?
Looking forward to your response. Thank you.

@Guangxuan-Xiao, thanks for replying here. However, the code seems to be different here. I see that query_states is encoded with position_ids while key_states is encoded with key_position_ids, which is the position in cache. Could you please elaborate more? Thank you!


Implement CI/CD workflows and integrate OpenAI API

User description

Closes #
📑 Description

✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[X] I have updated the documentation as required
[X] All the tests have passed

☢ Does this introduce a breaking change?

[X] Yes
[ ] No

ℹ Additional Information

Description

Introduced CI/CD scripts and workflows for automated builds and tests.
Added a pre-commit hook to enforce branch naming conventions.
Integrated OpenAI API for enhanced message handling in the application.
Configured Dependabot for automatic dependency updates.
Established various workflows for CI, code quality checks, and security scanning.

Changes walkthrough 📝
Relevant filesEnhancement
2 files

Constants.csIntroduced Constants class for system messages

Src/AiCommitMessage/Constants.cs
Added a new Constants class.  Defined a constant SystemMessage.

+6/-0

Program.csRefactored main program logic and integrated OpenAI

Src/AiCommitMessage/Program.cs
Refactored the Main method for better clarity.  Integrated OpenAI API for message handling.

+33/-62

Configuration changes
9 files

pre-commitImplemented pre-commit hook for branch validation

.githooks/pre-commit
Added a pre-commit hook to enforce branch naming conventions.  Added checks for dotnet tool restoration and formatting.

+16/-0

dependabot.ymlAdded Dependabot configuration for dependency updates

.github/dependabot.yml
Configured Dependabot for NuGet and GitHub Actions.  Set weekly update schedules for dependencies.

+34/-0

build.ymlAdded build workflow for CI/CD process

.github/workflows/build.yml
Created a build workflow for CI/CD.  Included steps for checkout, setup, build, and test.

+34/-0

ci.ymlSet up continuous integration workflow

.github/workflows/ci.yml
Established a continuous integration workflow.  Added steps for versioning, building, and testing.

+70/-0

codeql.ymlIntroduced CodeQL analysis for security checks

.github/workflows/codeql.yml
Added CodeQL analysis workflow for security scanning.  Configured to run on pushes and pull requests to main.

+82/-0

deep-source.ymlAdded DeepSource coverage reporting workflow

.github/workflows/deep-source.yml
Created a workflow for DeepSource coverage reports.  Configured to run on pushes and pull requests.

+33/-0

infisical-secrets-check.ymlAdded secrets check workflow for security

.github/workflows/infisical-secrets-check.yml
Implemented a secrets check workflow using Infisical.  Configured to run on pull requests and manually.

+26/-0

linter.ymlCreated linter check workflow for code quality

.github/workflows/linter.yml
Established a linter check workflow.  Included steps for setup and formatting checks.

+28/-0

size-label.ymlImplemented size labeling for pull requests

.github/workflows/size-label.yml
Added a workflow to label pull requests based on size.  Configured to run on pull requests and manually.

+21/-0

Miscellaneous
1 files

.wakatime-projectAdded Wakatime project file

.wakatime-project

Created a Wakatime project file for tracking.

+1/-0

Dependencies
1 files

AiCommitMessage.csprojUpdated project file with OpenAI dependency

Src/AiCommitMessage/AiCommitMessage.csproj

Added OpenAI package reference for API integration.

+1/-0

Summary by CodeRabbit

New Features

Introduced a pre-commit hook to enforce branch naming conventions.
Added automated workflows for CI/CD, including build, testing, and release processes.
Implemented a tool for generating AI-assisted commit messages.
Integrated DeepSource for static analysis and test coverage reporting.
Added a workflow for checking secrets in the codebase.

Bug Fixes

Enhanced code formatting checks to maintain consistency.

Documentation

Updated workflows to include clear naming and categorization for better management.

@gstraccini csharpier


"The provided training data is very small for code verification purpose only"

Is this mean the pre-trained model given is kind of overfitted model trained on small dataset?

no

Then is it possible to convert the voices of our own data with your pre-trained model? will it perform well?

no, the pretrained model only works for speakers in the training set

no, the pretrained model only works for speakers in the training set

How can I test my own speech data with your pre-trained model?
Lets say how can I train a model for the voice of trump and apply it to my speech?

no, the pretrained model only works for speakers in the training set

How can I test my own speech data with your pre-trained model?
Lets say how can I train a model for the voice of trump and apply it to my speech?

@sbkim052  can you check my problem? did you pass these steps?
https://github.com/auspicious3000/SpeechSplit/issues/28

@sbkim052  can you check my problem? did you pass these steps?
https://github.com/auspicious3000/SpeechSplit/issues/28

no, the pretrained model only works for speakers in the training set

Can I use it to train a model like Conan's Bow?
Anyone's voice will be converted to the model's voice.

Or this can only use the data in the training set, and can't convert the voice of a new speaker into the pre-trained model's voice.

@leijue222 yes you can, but you need to re-train the model.

@leijue222 yes you can, but you need to re-train the model.

That's wonderful.
Actually, I want to use the baker's voice as Conan's bow-knot, with your SpeechSplit to do voice conversion.
Then, the SpeechSplit can convert my voice or your voice or anyone else voice to baker's voice.


Bedtools intersect raises warnings and works slowly

Possible similar to #814:
When I try to use bedtools intersect for any bed files compressed with bgzip, it raises warnings
[W::sam_read1] Parse error at line 1.
Also, I don't think bedtools uses tabix index, because it takes 12 seconds to find regions from the first file that intersect a single basepair region from the second file.
I have the following versions of bedtools and samtools:
> bedtools --version
bedtools v2.27.1
> samtools --version
samtools 1.10
Using htslib 1.10.2

Thanks for reporting, I think this has to do with recent integration of htslib.
As for the Tabix index piece, no bedtools does not use tabix indices. If you are looking to do intersections on a handful of intervals, Tabix is a better choice. Things flip in favor of bedtools when intersecting ~10,000 intervals or more.

Okay, thank you!

These warnings are no suppressed in the master branch on Github.


c.render with jsxRenderer has type errors for 2 arguments

What version of Hono are you using?
4.2.7
What runtime/platform is your app running on?
Workers
What steps can reproduce the bug?
export const Layout: FC = ({ children, c, title }) => {
app.get("*", jsxRenderer(Layout));
return c.render(index(c), { c, title: "Home", search: true });
Expected 1 arguments, but got 2
What is the expected behavior?
No response
What do you see instead?
No response
Additional information
No response

Argument of type '({ children, title }: PropsWithChildren<{ Layout: FC; }>) => string' is not assignable to parameter of type 'ComponentWithChildren'.
Type 'string' is not assignable to type 'HtmlEscapedString | Promise'
If just using the example from hono docs

Hi @janat08
Please share the minimal project to reproduce it.

https://github.com/honojs/starter
https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-template-repository

https://github.com/janat08/reproduction-hono

@janat08
Thanks! Please add the following to src/index.ts or global.d.ts.
declare module 'hono' {
  interface ContextRenderer {
    (content: string | Promise<string>, props: { title: string }): Response
  }
}

what type is layout function then?

@janat08
How about using PropsWithChildren?
import type { PropsWithChildren } from 'hono/jsx'

export const Layout = ({ children, title }: PropsWithChildren<{ title: string }>) => {
  return (
    <html>
      <head>
        <meta charset="utf-8" />
        <link rel="manifest" href="/static/manifest.json" />
        <meta name="viewport" content="width=device-width, initial-scale=1" />
        <title>{title}</title>
      </head>
      <body>
        <main class="responsive" role="main">
          {children}
        </main>
      </body>
    </html>
  )
}

The reproduction went back to breaking.

https://hono.dev/middleware/builtin/jsx-renderer#extending-contextrenderer

@janat08
I can't understand where the error occurs. Could you provide a minimal project to reproduce it again?

https://github.com/janat08/reproduction-hono

@janat08 Thanks!
Try to use this code:
import { Hono } from 'hono'
import { jsxRenderer } from 'hono/jsx-renderer'
import { Layout } from './layoutBeercss'

const app = new Hono()

app.get('*', jsxRenderer(Layout))

declare module 'hono' {
  interface ContextRenderer {
    (content: string | Promise<string>, props: { title: string }): Response
  }
}

// ...

That was eslint changing the name over a ruleset for abbreviations.


Readthedocs - broken link (Striplog_object.ipynb)

The userguide page refers to a striplog object example which no longer esists.
Possibly that example has been superceded by this one?

Fixed in #141.


Calculate read frame

We need to count reads mapping to frames 0/1/2 on an ORF. This should happen in the same level as functions in generate_stats_figs.R and can be coded in R.
This is an essential QC step. Also an enhancement needed for @ewallace's immediate work on another project.

Working to do this in branch read-frame-89. Commit 8563f8d has tidyverse approach code that runs but is not much tested.
@FlicAnderson can we discuss? This introduces a new tidyverse package dependency, purrr. And I need your help to check for style.
Makes some progress also on #32

@ewallace needs to fix so that the option
                                                          asite_disp=c(12,12,12))```
is defined, and check the vignette runs.

Commit 81c1c23 ensures that the vignette runs:

defines config option asite_disp_length_file
if no asite_disp_length_file supplied, generate_stats_figs.R treats as NA and skips the code block
if asite_disp_length_file defined, counts read frame for every CDS defined in the gff file.
runs on vignette data and (informal check) the majority of reads are in frame 0 on high-expression genes YAL038W, YAL005C, etc.

Still needs

check that the 12nt A-site disp is adequate
check for R style
check for python style
update vignette documentation
test on full-size data

And enhancements

graphic output, maybe boxplot of prop. in frame for all above-threshold genes?
statistical test, maybe the wilcoxon-type test implemented in RiboCode?

Should take @ewallace another 1-3 weeks; then to seek help for writing the tests.

@ewallace implemented wilcoxon test.
we realized that existing asite_disp_length_file works and corrected W-Sc_2016 data.
@FlicAnderson ran on G-Sc-2014 (pre-wilcoxon test) and looked good.

Next steps:

After reviewing #58, @FlicAnderson to merge use-umi-tools-dedup-58 into read-frame-89
Test-run on W-Sc_2016.

Aim to review and close issue by week commencing 11th Nov.

@FlicAnderson reran this with G-Sc-2014 including wilcoxon test; looking good.
@FlicAnderson to:

double-check the output;
augment regression test;
review the doc to ensure it covers things;
run on W-Sc_2016 to validate;

to validate, plot distribution of p-values against TPMs or read-counts

issue pull-request;
and close.

The validation method will likely feed into #56.

Update:
Pushed commits with documentation edits and augmented regression test, though workflow.pdf still to edit.
Still need to run on W-Sc_2016 dataset to validate (after merging in UMI capabilities from branch use-umi-tools-58 / develop if pull request #98 has gone through), and then plot p-values vs TPMs and read-counts from outputs of that run.

This should be the focus this week.

P-values of frames vs tpms and read counts plotted from outputs of W-Sc_2016 dataset run with branch read-frame-89.  I've put it here for now. @ewallace can you check if this was what you needed and whether it seems to give what you'd expected?
Made last change to read-frame-89 documentation (updated workflow.pdf) in commit 997bfef7.
If the p-values plots have worked out well, then this branch is ready for pull request.
I can create this PR as soon as @ewallace is happy with verification of outputs.

Created pull request, ready to review and merge with develop: https://github.com/riboviz/RiboViz/pull/103

We noticed that yeast_standard_asite_disp_length.txt is incorrect, should have 15 in as the a-site displacement.
read_length	asite_disp
28	15
29	15
30	15

@ewallace's error, he will fix and update. Might require updating regression tests. @FlicAnderson, should we revoke pr to do this or not?

Moved back to In progress pending bug fix.

I updated the numbers to 15. Request @mikej888 to update regression tests and then update pr #103.

Regression test values differ for WTnone_3ntframe_bygene.tsv and WT3AT_3ntframe_bygene.tsv.  Regression test code needs no updates. I'll create a new regression test data bundle once this, use-umi-tools-deplex-84 and docs-80 branches have been merged,


Updates to ReadMe DBW description & DBW comments

I have added the DBW description to ReadMe.md. I have also added additional comments to dbw_node.py and twist_controller.py.

Wilson and Arjun took care of these changes.


Update to check illegal characters

Use the available method extension

Hi @ZeBobo5, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks. Will process this PR


Show warning on dev mode

On a development environment, there will most likely be a path repository added to composer.json, in this case the path will require it be changed to an absolute one for the composer commands to work.

might be able to fix this by defining a --working-dir option on all commands.

might be able to fix this by defining a --working-dir option on all commands.

If that fixes the issue I'm all for it.


Publishing registered point clouds causes extrapolation exceptions

[ WARN] [1464806618.218487179]: TF2 exception:
Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.315158598 but the latest data is at time<PHONE_NUMBER>.239545601, when looking up transform from frame [camera_depth_optical_frame] to frame [camera_rgb_optical_frame]

This is a static transform so should be easy to work around.
The data gets through occasionally.

I'm having this problem. Is this solved?

@lcluz  could you tell me detailes steps for this problem and OS version ,  hardware Platform ?

@ob-tim-liu I'm using a Robot from the project I work in: it uses Ubuntu 14.04 and ROS Indigo. The pointcloud data is good, rgb data is good. Depth registered is getting this extrapolation error and maybe every minute there is some data available.


Unit tests seem to depend on specific system properties

When checking out the code, doing a clean build and running the unit tests, the "CanIdentifyIdListLength" test is failing, expecting 2 instead of 4. I think this could be platform specific (I am currently running Win 10 Pro / en-US). Also, there is a suspicious test "CanBouncePidl" that expects the display name to be "Documents", which I am not sure works on other language editions of Windows.
Not a serious issue, but it got me thinking that I broke something when compiling the code.

Closing stale issues, please re-open if needed.


<IP_ADDRESS> Issues

We upgraded to latest version but have 2 errors

SQL error when setting product list options like this:
http://my.jetscreenshot.com/demo/20160812-ppdz-70kb.jpg

When trying to add a product getting this error:
ReflectionException
…/vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping/RuntimeReflectionService.php line 80
Concrete\Package\CommunityStore\Src\CommunityStore\Product\ProductVariation\ProductVariation::$pvColor does not exist

What's the sql error you get for number 1?
With number 2, this looks like it just didn't upgrade cleanly. Try clearing
your cache first, then forcing the package to re-check the ORM objects
through a minor upgrade - just increment the package number a bit and run
the upgrade.
On 12 Aug 2016 3:01 PM, "madesimplemedia"<EMAIL_ADDRESS>wrote:

We upgraded to latest version but have 2 errors

SQL error when setting product list options like this:
http://my.jetscreenshot.com/demo/20160812-ppdz-70kb.jpg

When trying to add a product getting this error:
ReflectionException
…/vendor/doctrine/common/lib/Doctrine/Common/Persistence/Mapping/RuntimeReflectionService.php
line 80
Concrete\Package\CommunityStore\Src\CommunityStore\Product
ProductVariation\ProductVariation::$pvColor does not exist

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/concrete5-community-store/community_store/issues/87,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABB5MGMqTrIV_a5kpAG1zo4WNwgyLZ2Bks5qfG7FgaJpZM4JjD-d
.

Managed to get it working, we can remove this.


Compare/save publickey hash in Type 61/70 and fix issue in max_serviceinfo_sz.bin

Create the hash of the received public key in Type 61 and compare it
against the stored hash from DI.
Replace the hash in the DeviceCredential at Type 70, if resale has
been selected by the Owner.
Fix an issue with file max_serviceinfo_sz.bin to handle integer
overflow/underflow.

Signed-off-by: Chandrakar, Prateek<EMAIL_ADDRESS>

Validated the PR with Resale scenarios (Normal resale, changing owner key, and a size 2 voucher ) and Reuse scenarios with CSDK and TPM devices.

Validated the PR for integer overflow and underflow scenarios in max_serviceinfo_sz.bin file


[FR] add a Ctrl+Esc shortcut key to pause the use of the plugin

You should add a Ctrl+Esc shortcut key to pause the use of the plugin.
Even if you restart Obsidian, it won’t change until you press the shortcut key again to resume use.
I only use this plugin when embedding code blocks in Obsidian. I don’t want to use it at other times.
Although pressing Esc can return to normal now, it’s not permanent.
When I enter text again, the pop-up window will appear again, which greatly affects my writing experience.
Thank you for your help!!!!!

Hi, @TheGodOfKing :)
I think you should use the following option.
https://tadashi-aikawa.github.io/docs-obsidian-various-complements-plugin/3. Commands/🎮 Toggle Complement automatically/

Hi, @TheGodOfKing :)
I think you should use the following command.
https://tadashi-aikawa.github.io/docs-obsidian-various-complements-plugin/3. Commands/🎮 Toggle Complement automatically/

Yes, I found this option and set the shortcut.

Now the plugin is working very well.

Thank you for your help !!!

I’m glad to hear that!


Rotate always around pc center

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Fixes problem that point clouds were rotated around point 0.0 , and it is not helpful in most situations.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Codecov Report

Merging #24 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   72.87%   73.01%   +0.13%
==========================================
  Files           8        8
  Lines         601      604       +3
  Branches       86       86
==========================================
+ Hits          438      441       +3
  Misses        139      139
  Partials       24       24

Impacted Files
Coverage Δ

src/volumentations/augmentations/functional.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8241d...b64c246. Read the comment docs.


GS1 Data Matrix

In order to be GS1 compliant the data matrix must adhere to some guidelines.

The Function 1 Symbol Character (FNC1) needs to be encoded as codeword 232.
ASCII encoding is mandatory.
Data Matrix ECC 200

This patch should fix the first two points in the list.
For debugging (and testing?) dmtx-utils were helpful to me.

See also https://github.com/dmtx/libdmtx/commit/e4c0a748f8f4af5ad833c955a6f8a81fa2ac5301

Thank you for the PR. I refactored it a bit and moved the GS1 logic to a separate encoding:
Dmtx::DataMatrix.new("\x1d...", encoding: :gs1)


[WIP] docs/sphinx: Manually resolve sphinx deps

sphinx dependencies are currently ~broken (https://github.com/sphinx-doc/sphinx/issues/11567)
this resolves the deps manually to allow upgrade

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

https://github.com/sphinx-doc/sphinx/issues/11567#issuecomment-1691276250

waiting on https://github.com/sphinx-doc/sphinx/issues/11567#issuecomment-1691878871


Add comments into Comparator code

[ ] Explain magic numbers where applicable
[ ] Map code pieces to protocol
[ ] Document implementation for Themis docs, add references to actual code (https://github.com/cossacklabs/themis/wiki/Secure-Comparator-cryptosystem)

done


create object metadata summary and best use guideline

This has been addressed via the object dictionary/dataset description, and the vignettes.


Notes Summary

I created two new documents, Questions & Insights/Observations. Questions has all of the questions Benjamin raised in his notes. If I saw any answers regarding those questions later in the notes I tried to pair them, but that didn't happen often. The second document Insights/observations is a catch all for all of the other insights I saw in his notes that weren't directly answering the questions from the other document.  Some notable things I left out of both were items such as, created X document or started reading X book. I didn't think these would be very useful since all of the documents and books mentioned already had files in the repository. If you think a file containing those would be useful let me know and I'll add it.

These look like a good start. We may want to do more later, but this works for now.
The one thing to think about regarding the notes on when files were created, etc. is that I don't think there's a text document that explains what all the files are, what's in them, how they relate to each other, etc. So we should create such a documentation file at some point soon, at which point we should set a standard way to name the book summaries.


Missing maintainers file

We've been conforming to have one of these in every repository, primarily for internal purposes ('which team?').
e.g. per this one.
┆Issue is synchronized with this Jira Task by Unito

which team?

This falls under the Integrations team, although it hasn't been staffed yet.

https://github.com/ably/kafka-connect-ably/commit/05d9bb542c65111fcf11e699d7d954e4a402f88f


Add ASP.NET Core Library and Framework Support

Add link to ASP.NET Core (and .NET Core) Library and Framework Support GitHub repository and ANCLAFS.com.

Cool! Thanks @jpsingleton.


Big datasets and mzTab

Description of feature
In big datasets like PXD016999 does not matter How much memory do you put into the PROTEINQUANTIFIER TMT step, the export to mzTab will fail. Then, I suggest two things:

[x] Allow to run PROTEINQUANTIFIER TMT without exporting to mzTab. By default, the tool will allow exporting to mzTab but we can take a parameter to disable that functionality. If that functionality is disabled pmultiqc should be also disable because it is based on mzTab (nor now).

[x] Work with @timosachsenberg and @jpfeuffer for a better exported of mzTab.  One possible idea is to export into three different files:
- out_protein.mzTab
- out_peptide.mzTab
- out_psms.mzTab
The three files will share the metadata and the sections will be split depending on the file.

[ ] Work with @timosachsenberg and @jpfeuffer to be able to export in ProteinQuantifier the consesusXML file.

This has been solve in recent PRs


Exporting to pdf doesn't work anymore.

I've been using your app for the past couple of months and it has been very useful. Over the past few days when I tried updating my resume and exporting the updated one to pdf, it would just say loading, and nothing gets downloaded. I tried different devices, and different accounts, and still doesn't work. This website is really good and I would hate to lose all my data on it.
Thank you very much.

Same Problem

Should be fixed in the latest update v2.2.0 :)
You can check the version you're on at the footer of the right sidebar.


Gradio demo crops/zooms in on face

Regarding the latest commit which includes a gradio demo, when using vid2vid I noticed that with the gradio demo it is cropping/zooming in on the face in the output, it also modifies the source photo to be cropped/zoomed in on the face. Whereas, in huggingface demo the output retained the body from the source image and scaled instead of cropping.
Is there a parameter or config where this can be switched back to scaling instead of cropping?
Thanks for your amazing work!

I think it could be something to do with this
164 # pose_tensor_list = []
# pose_transform = transforms.Compose(
#     [transforms.Resize((height, width)), transforms.ToTensor()]

168  # )
pose_image_pil = Image.fromarray(cv2.cvtColor(pose_image_np, cv2.COLOR_BGR2RGB))
    # pose_tensor_list.append(pose_transform(pose_image_pil))

pose_transform = transforms.Compose(
[transforms.Resize((height, width)), transforms.ToTensor()]
)

It doesnt crop it if the ref image is close to the dimensions of the ref video
https://github.com/Zejun-Yang/AniPortrait/assets/114336644/d9220971-7cbb-4059-b30c-176cab05ae17

but will seemingly go too far when it isnt
https://github.com/Zejun-Yang/AniPortrait/assets/114336644/463e6e20-7af9-48b0-b869-464a83523fcd

when I changed expand in crop_single to 1.1 it resulted in this, even more zoomed in
https://github.com/Zejun-Yang/AniPortrait/assets/114336644/45c52bb6-9aff-44e9-827b-a6764b856c0e

Our purpose in cropping the image is to ensure that the face occupies a larger proportion in the image. You can delete this line of code to disable cropping.
https://github.com/Zejun-Yang/AniPortrait/blob/90f1b67554135b5afcb922b1f3d6d23ecd8f06da/scripts/app.py#L263


consider including bibtool?

I'd like to call bibtool inside my build scripts to generate a clean bibliography file before compiling.
Now, it seems that this is not part of texlive (I thought it was), so it requires an extra installation.
On Debian, apt install bibtool does the trick, but although this docker image is based on debian, this command seems to fail:
.gitlab-ci.yml:
default:
  image: danteev/texlive
  before_script:
    - apt install bibtool

build:
  script:
    - cd src
    - bibtool -r bib/bibtoolrc content/references.bib > content/references-clean.bib
    - latexmk -f -outdir=.. -pdf main.tex
  artifacts:
    paths:
      - "main.pdf"

log:
Skipping Git submodules setup
$ apt install bibtool

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package bibtool
ERROR: Job failed: exit code 1

You should do sth. like https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments. And also build your own custom Docker image based on this one. Otherwise it will install the package every time your Pipeline runs.

You should do sth. like https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#sort-multi-line-arguments. And also build your own custom Docker image based on this one. Otherwise it will install the package every time your Pipeline runs.

Sure, I could do that, but the main attraction of this project for me is that it maintains a complete texlive image that I can simply use in my CI tasks. I solved this particular case simply by checking in the outputs of bibtools..

Sure, I could do that, but the main attraction of this project for me is that it maintains a complete texlive image that I can simply use in my CI tasks. I solved this particular case simply by checking in the outputs of bibtools..

Yeah you are right on that point :). But adding every tool from the enourmus TeX world would make this image even bigger. So the extension via an own Docker file is very straight forward way. And GitLab and GitHub have build in Registries thus it is even faster then pulling the image from Docker Hub. Which has rate limits now.

Yeah you are right on that point :). But adding every tool from the enourmus TeX world would make this image even bigger. So the extension via an own Docker file is very straight forward way. And GitLab and GitHub have build in Registries thus it is even faster then pulling the image from Docker Hub. Which has rate limits now.

Alright then, I will close the issue. Thanks for the pointer about build registries. I will have a look at this.
Happy new year :)

Alright then, I will close the issue. Thanks for the pointer about build registries. I will have a look at this.
Happy new year :)

Nice discussion. I think, this image should be a ready-to-go image for most use cases. Therefore, a JRE is included and some other tools. Making the image very large. This is sort of documented in ADR-001 and ADR-002. Need to write it down better.
Customized images should IMHO base on https://github.com/reitzig/texlive-docker. Alternatively, we should work on flavours for ourselves. Maybe, we could also write a Dockerfile generator generating the right commands based on the .tex source code to compile.
Regarding bibtool, I am a bit biased as I am the core developer of JabRef, which can also be used on the command line. I know that its startup time is slower.
The reason why the installation fails is that there is no information available on packakges any more in the image: https://github.com/dante-ev/docker-texlive/blob/8488ace545d96290293980c7df8f795516fb5f3a/Dockerfile#L94
I think, bibtool is a small tool. Thus, the image size should not be significantly increased. Thus, I am trying to add it at https://github.com/dante-ev/docker-texlive/pull/17.
The hint on the other registries was given at https://github.com/dante-ev/docker-texlive/issues/10#issuecomment-753590874. Hopefully, I'll find the time to do so.

Nice discussion. I think, this image should be a ready-to-go image for most use cases. Therefore, a JRE is included and some other tools. Making the image very large. This is sort of documented in ADR-001 and ADR-002. Need to write it down better.
Customized images should IMHO base on https://github.com/reitzig/texlive-docker. Alternatively, we should work on flavours for ourselves. Maybe, we could also write a Dockerfile generator generating the right commands based on the .tex source code to compile.
Regarding bibtool, I am a bit biased as I am the core developer of JabRef, which can also be used on the command line. I know that its startup time is slower.
The reason why the installation fails is that there is no information available on packakges any more in the image: https://github.com/dante-ev/docker-texlive/blob/8488ace545d96290293980c7df8f795516fb5f3a/Dockerfile#L94
I think, bibtool is a small tool. Thus, the image size should not be significantly increased. Thus, I am trying to add it at https://github.com/dante-ev/docker-texlive/pull/17.
The hint on the other registries was given at https://github.com/dante-ev/docker-texlive/issues/10#issuecomment-753590874. Hopefully, I'll find the time to do so.


Showing "![Screenshot showing banner notification guest users](media/guest-experience-image2.png"

https://docs.microsoft.com/en-us/microsoftteams/guest-experience

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 048930a4-fdf2-9a90-3b47-46af66db3db4
Version Independent ID: 8d6a2c84-94e9-b17e-f5c1-91191187ce4e
Content: What the guest experience is like
Content Source: Teams/guest-experience.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@hyoshioka0128 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

en-us:https://docs.microsoft.com/en-us/microsoftteams/guest-experience

ja-jp:https://docs.microsoft.com/ja-jp/microsoftteams/guest-experience

Hi @hyoshioka0128
Thank you for reaching out! We appreciate your time!!
Yes, these banner notifications on the screenshot to highlight the text related to guest addition to the room. Kindly help us to understand if you find something wrong with the notifications.
Please correct me if my understanding about the issue is wrong. Looking forward to your response. Thank you.

@sowjanya365 : Thank you. (I'm poor English.)
I thought at that time that the code was being displayed without the "media/guest-experience-image2.png" image being displayed.
Now that the code is not displayed and fixed, please close it.
en-us:https://docs.microsoft.com/en-us/microsoftteams/guest-experience

ja-jp:https://docs.microsoft.com/ja-jp/microsoftteams/guest-experience

Hi @scanum
Kindly close this issue. Thank you.

@hyoshioka0128 Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


added GSP Configuration for Grails 3.3+

If you use GSP views with the Grails Mail plugin in Grails 3.3 or higher, you need to configure the GSP plugin for the views to render properly. See also: https://stackoverflow.com/questions/69993899/grails-4-mail-plugin-illegalargumentexception-could-not-locate-mail-body/69993900

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Unable to deploy the initial version

The main branch build is currently failing at the Semantic Release of jenkinsciinfra/geoipupdate stage:
12:19:00  + git config user.name 977017
12:19:00  + git config user.email<EMAIL_ADDRESS>12:19:00  + git tag -a 0.0.1 -m jenkinsciinfra/geoipupdate
12:19:00  + git push origin --tags
12:19:00  warning: invalid credential line: get
12:19:00  remote: Permission to jenkins-infra/docker-geoipupdate.git denied to <redacted>.
12:19:00  fatal: unable to access 'https://github.com/jenkins-infra/docker-geoipupdate.git/': The requested URL returned error: 403
script returned exit code 128

=> It's because the GH app with the AppID 977017 is not allowed to write to this repository.
For the record, this app is specified in the shared pipeline library: https://github.com/jenkins-infra/pipeline-library/blob/e6b87f357b25159eb6161d1d168656312119d2f0/vars/buildDockerAndPublishImage.groovy#L48C22-L48C66 and https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildDockerAndPublishImage.groovy#L246

Update:

Added this repository in the scope of the GH app
Triggered a new build (number 7) on the main branch

https://hub.docker.com/layers/jenkinsciinfra/geoipupdate/0.0.1/images/sha256-5b4f8ebc2ef3e0def489adbcf0f2c05427961744a1aa47bc93218e32a873532a?context=explore
https://github.com/jenkins-infra/docker-geoipupdate/releases/tag/0.0.1


Mobile: Slots on homepage not properly displayed with calydon enabled

Environment Details
Spartacus: develop
Browser: Chrome
Device: mac
Happens on: http://localhost:4200/electronics-spa/en/USD
Steps to Reproduce

Enable calydon by uncommenting line 4 in this file: projects/storefrontapp/src/styles.scss
Run a yarn
Start your app
Load the storefront on a mobile view

Actual Result
Some slots are not aligned properly.

Looks fixed. Unable to reproduce in latest develop.

Tested on dev3. Ok now.


Reduce Fabrics memory consumption; provisions for UpdateNOC

(This is the last big PR in my series (forthcoming ones are much smaller), so please bear with me one more time.)
The PR builds upon the previous two (in-place-init and tlv-rework) and implements the following changes, in order of importance and magnitude:
Matter object memory reduced by ~ 16 sessions x 480B = 7KB
Reason: Session::noc_data (= Option<NocData>) is now removed. The fabric initial/updated key-pair as well as the Root CA are now stored in the Failsafe.
(In all fairness, before the project became no_std, storing the NocData inside the session was OK, because it was Option<Arc<NocData>> and as such did not occupy space until allocated. And usually, there was just one session with allocated NocData.)
This is possible because of the observation that - at any point in time - only ONE fabric can be in the process of being created (AddNOC) or updated (UpdateNOC). This is so because NOC updates do require the Failsafe to be locked first.
@kedars Would appreciate if you could confirm that my understanding ^^^ is correct.
Hence, the "in-transit" data preceding AddNOC / UpdateNOC is in the failsafe now. It is automatically invalidated when the failsafe timeout expires/it is disarmed/commissioning is complete.
AclMgr is gone
All AclEntrys belonging to a fabric are now simply kept in their corresponding Fabric object. ACL tests are updated to work with FabricMgr instead of AclMgr.
While not strictly necessary, it makes dealing with these entries a tad easier. Including their persistence to NVS. If a Fabric object is persisted, so are its ACLs as they are contained inside it.
Also, this change is symmetric to the removal of ExchangeMgr one year ago, where I merged all Exchanges into their corresponding Session object.
Failsafe reworked
It resembles the Matter C++ logic much more closely now, and I hope it would be relatively easy to add UpdateNOC now, which - while not part of this PR, is already handled in Failsafe.
Smaller items

Maybe had a bug where its destructor was not called. Now fixed and covered with unit tests

Still in Draft as I noticed I have the tests in access_control.rs commented out. Will restore them shortly.

Ready.

@kedars Would appreciate if you could confirm that my understanding ^^^ is correct.

Yes, that understanding is aligned with mine 👍


jekyll: add jekyll-polyglot

Motivation for this change
Needed to build https://salsa.debian.org/reproducible-builds/reproducible-website
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Not sure why this is not triggering rebuilds.

Not sure why this is not triggering rebuilds.

Not sure why this is not triggering rebuilds.

Because the plugin is not enabled by default. You can get a jekyll with this plugin enabled with nix-shell -p "(pkgs.jekyll.override { withOptionalDependencies = true; })

Not sure why this is not triggering rebuilds.

Because the plugin is not enabled by default. You can get a jekyll with this plugin enabled with nix-shell -p "(pkgs.jekyll.override { withOptionalDependencies = true; })

I can confirm this builds for me.

I can confirm this builds for me.


Install command in README doesn't work

Install-Module VSSetup -Scope CurrentUser

Install-Module : A parameter cannot be found that matches parameter name 'Scope'.
At line:1 char:24
+ Install-Module VSSetup -Scope CurrentUser
+                        ~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Install-Module], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Install-Module

Further, I'm very curious how Powershell would know where to resolve VSSetup from.
I am on Windows 10 build 14393.rs1_release.161220-1747

PowerShellGet has a list of default repositories including http://powershellgallery.com where this module is published. Run Get-PSRepository for a list.
The Scope parameter is correct. I use it all the time, and is documented at https://msdn.microsoft.com/en-us/powershell/reference/5.1/powershellget/install-module. Please run get-module -list PowerShellGet | select * | clip and paste the output.

Also, does gcm install-module tell you its from the PowerShellGet module (see "Source" column in default output). If multiple results are returned, the first one listed is what Install-Module invokes, which could be wrong. IIRC, the Scope parameter has always been supported (I was a beta tester for OneGet/PackageManagement and PowerShellGet, so have been using them for a while).

As discussed offline, I had a stale version of PsGet in my Documents\WindowsPowershell\modules directory. Once I removed it, it worked.


KAFKA-2812: improve consumer integration tests

@granders Ping for initial review.

LGTM, leave to @granders to take a look.

@guozhangwang Thanks for taking a look. I've also got some bounce tests that I'll probably add later today. They helped to find the deadlock error.

@hachikuji A few very minor comments. Otherwise looks good

@granders, @guozhangwang: I added some bounce tests and addressed Geoff's comments. Unless there are any concerns, this is probably ready to merge whenever there is a good opportunity.


Automate Docker image builds

Incorporate the building and pushing of Docker images into release automation.
Options:

Utilize Docker Hub's automated build process to initiate tag builds
Build and push images from CircleCI (may require a new Drud Docker Hub user to complete docker login before pushing)

I seem to remember that Dockerhub fundamentally can't do our builds; However that may have been back in the day when we also did go builds of binaries that were installed inside the docker image. So give it a try. I guess the one reservation is that with our current build system we've gone through the testing process before pushing. But who knows, maybe there's some value there.

I've been playing around with their build system and it looks like we may be playing more nicely with it these days, I have our four (for now) images building successfully:
https://hub.docker.com/u/andrewfrench
https://hub.docker.com/r/andrewfrench/ddev-webserver/builds/
Although these images haven't been extensively tested yet. I think there are very real concerns surrounding orchestration (having correctly tagged images exist before testing, etc), but I think there might be some reasonable solutions to that problem.

Just a note on this one: build, push/ test. If we're building on dockerhub, we need to have a test after that to validate behavior.

Closing in favor of #2617


catch CRITICAL:root:twint.run:Twint:Feed:noData'items_html' error

Issue Template
Please use this template!
Initial Check

If the issue is a request please specify that it is a request in the title (Example: [REQUEST] more features). If this is a question regarding 'twint' please specify that it's a question in the title (Example: [QUESTION] What is x?). Please only submit issues related to 'twint'. Thanks.

Make sure you've checked the following:

[] Python version is 3.6;
[] Updated Twint with pip3 install --user --upgrade -e git+https://github.com/twintproject/twint.git@origin/master#egg=twint;
[] I have searched the issues and there are no duplicates of this issue/question/request.

Command Ran
twint.run.Search(c)
Description of Issue
when the library throws this error:
CRITICAL:root:twint.run:Twint:Feed:noData'items_html'
how can i catch this error_?
    ```
        try:

            twint.run.Search(c)
            break

        except Exception as e:
            print(e)

### Environment Details
UBUNTU 18.04

Hi, I stumbled upon this too. There was an error in my cfg definition, wrong property name for query (should be c.Search).
Can you share the code where config is created?


Upgrade LSP4J to 0.7.2

https://github.com/eclipse/lsp4j/releases/tag/v0.7.2

verified with master branch


log to review BUNDLE_INVALID_SIGNATURE bundle status

code to review invalid bundle status

This should probably be a debug log, else a log flood can be triggered
maliciously?
On Sun, 10 Mar 2019, 16:55 Tsvi Sabo<EMAIL_ADDRESS>wrote:

@tsvisabo approved this pull request.
Thanks @ed2k https://github.com/ed2k
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/entangled/pull/942#pullrequestreview-212593028,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB5FLxrfHJSA5T1K5F2vbZ57lmxU8mIks5vVMh1gaJpZM4bmfPQ
.


Update ReSharper issue definitions to 2019.1.3

Thank's for your PR! We're currently reviewing the rule changes and get back to you as soon as we're done.


Misaligned subject cards height when one had disabled skills and one does not

Misaligned subject cards height when one had disabled skills and one does not

PR: #1251


[webapi] Add sub tests config for all-in-one package

BUG=https://crosswalk-project.org/jira/browse/XWALK-4043

@jennycao is this OK to you?
No UT, @haoxli ?

Verified the sub apps can be packed in all-in-one.

@Honry are you taking care of BDD tests?

Better to run the tests to avoid any resource missing.

@jennycao  @Honry We does not support to run BDD tests in all-in-one package, my fix PR just add sub app to all-in-one package, but it still cannot run successfully, there are some special config for them which [~yunfei] use his own workaround. We need have a talk how to pack BDD resources in all-in-one package.

I am curious why BDD cannot run in all-in-one?

there are some special config for them which @haoyunfeix use his own workaround.

What is the workaround? And why?

@zqzhang  The workaround is copy bdd resources by manual when packing, i will update the PR to pack them automatically.

Please waiting for UT

Thanks, @haoxli  LGTM


Failed assertion: 'sizeAccessAllowed'

when scroll it gives me this error:
RenderBox.size accessed beyond the scope of resize, layout, or permitted parent access. RenderBox can always access its own size, otherwise, the only object that is allowed to read RenderBox.size is its parent, if they have said they will. It you hit this assert trying to access a child's size, pass "parentUsesSize: true" to that child's layout() in RenderFractionalTranslation.performLayout.
Failed assertion: 'sizeAccessAllowed'
what's that?

@WeighingDog could you please provide a reproducible sample code so I can better understand and address the problem?


Feature requests: Deletion, media resizing, S3 directory creation based on current working directory of upload

Hey! First off, I love this plugin and if anything it works too well. It's sort of changed my life - the ability to express not only what I'm working on but easily upload images to my blog that fluently describes it in the IRL terms of photos and videos has allowed me to blog approaching much closer to the speed of thought and experience than I thought possible. I've been uploading media like crazy. So far still paying 5 cents a month for my S3, but I can see this going up a bunch.
The main concerns I see are around

The deletion of unused media - if I upload an image and then realize it was wrong, or needs to be resized or updated etc. then I will delete that link, and it will just be hanging in my S3, unreferenced and unused. I don't see anything built in that automatically deletes media from the bucket that are not being used - which doesn't surprise me, as automatically deleting things probably comes with at least a few decisions to make. I mean for one, what if an image is referenced twice in a vault? Then a listener would need to be created that checks to see if a reference to media was removed, and if that reference exists anywhere else, and only delete the file from S3 if both of those conditions are met

Media resizing - this is related, as this is probably why I've deleted and replaced media most often so far. It would be nice to just have a catchall media upload configuration that would resize images that are too large, or even just prevent them from being uploaded.

S3 directory creation / metadata - this is a floating idea, but I wonder if some metadata could be added to S3 files that shows the path of the file that originally uploaded them.

This is a lot, but I am interested in extending the functionality of this plugin in these ways in the future and wondered if anyone had thought about these features.

Hi,  glad you are getting good use from the plugin.
You have brought up a number of points here, so let's discuss how you think it should work, and then I'll see if it's something I think I can support.

Deletion:  You are right that the plugin just uploads - it doesn't take "ownership" of the content once it is uploaded, and has no ability to delete it.  A poor man's solution could be to run a bucket policy that deletes automatically after some time, but I'm guessing this might not be desirable.  In order to support this, you are right, it seems like I'd have to build an index of uploaded content, and then manage it via reference counting.  Not everyone would want that behavior - I don't for one. For me, it would seem too easy to delete things accidentally.  If the link getting deleted, meant the content was deleted, it could result in accidental deletions.  This is a bigger risk than excess storage space usage.  Often, I paste screen shots, and once they are gone, they are gone.  there's not any copy on my machine - it was only briefly in the clipboard.  What would be your strategy to mitigate this?
Resizing:  currently we don't touch the media - but the filenames are the md5 hash value of the content.  This means that when the same content is uploaded multiple times, it doesn't sit on the server (s3 bucket) twice.  If the media will be processed, I would need a comprehensive set of settings to deal with it, what file types should be resized, what the maximum file size is, what the target quality should be, etc.  It's taking on a lot of new scope that was not originally intended.  You know the original idea here is that s3 space is cheap, and I would like to offload that from the machine.  Can you tell me more about your use case?  Why do you resize?
not sure about this - seems like the source location could change.

Thanks for engaging with these ideas so quickly!

Deletion: I think that long story short, this is quite complicated to implement, and for my use case, the simplest solution is to handle this type of S3 “pruning” inside of my deploy script, rather than trying to get it into the plugin. Your examples and concerns about improper deletion over storage overuse make a lot of sense, and for the masses I think your priorities are absolutely correct. However, I do think that an “archive” folder on S3 could mitigate some of these concerns, and a virtual directory structure could allow the plugin to potentially handle archiving.
I've found that default image size of many of my pictures are much larger than I need them to be. A little bit of compression allows them to load a lot faster, with the bonus of adding less space, at very low cost to quality. I have been manually compressing some of my images from 2MB to about 150KB. Sometimes I will forget to do this to begin with, leading to duplicate images that aren’t used, which is why I decided to file this issue - not entirely necessity, but more a feeling that maybe this would creep up and get me eventually. But maybe I’ll just get better at remembering!
You’re definitely right that source location of images could not only change, but there could be multiple locations of images, making a directory structure sort of impossible. I think some sort of virtual directory structure, with references to URL in JSON or something, would be the best way to do this. This would allow the same file to be referenced by multiple document objects.

So that said, this is what I’m thinking in terms of action:

I’m intereseted in scrappily coming up with my own tool to scan my S3 and compare it to my repo, see what unused media there is, and possible move it to an archival S3 directory that is easier to handle. If that goes well, maybe I could fork your plugin and see if I can incorporate it into the file upload process itself, but my hunch is it might be better for this to be a separate tool anyway, since it could be helpful outside of obsidian.
I do think that some automatic compression settings could be helpful for the plugin, but if I’m the only one interested it might not really be necessary. I can just batch compress things before dropping them into obsidian. Using the tool above, if I do this sloppily I can eventually audit it and clean up. That said, what I envision is some optional settings in the plugin settings menu that just allow the user to turn on compression on a per-file basis - JPGs, PNGs, etc. And then maybe specify a target file size - the image compression libraries I’ve used in javascript allow you to target a certain file size for compression.

For compression, how would it work?  Should every image be compressed, or just those over a certain size?  How much should they be compressed?  Which file types should be compressed?  Should we convert file types, ie. PNG to JPG?  Should there be a way to disable/enable compression at the note level (I have been pretty careful to enable frontmatter versions of all the settings, since people use their vaults for all kinds of different things, and one size doesn't necessarily fit all.

What do you mean by "the note level"? I would really like to appreciate you being careful to enable frontmatter versions of all types but might need your help understanding what this means, as I don't know the full range of how Obsidian is used - I'd imagine it's quite broad!
These are great questions. For "how would it work", I think I was thinking a per-file-setting that could be turned off by default where the user specifies a file size in, to start with, just PNG and JPG, and if an uploaded file is above that size, it is compressed before upload. I was thinking something like this:
JPEG Compression: On
Compress after JPEGs are above this file size: 2MB

PNG Compression: On
Compress after PNGs are above this file size: 2MB

by "the note level" I mean a setting which is set specifically for one particular note, where it is different than the settings that apply generally.  For example, I have some notes where I upload the media to a different bucket, because they are for work.  The point is that for every setting, there is often a use case where it needs to be set different at the note level, and then the settings need to supported by setting it in the frontmatter (which exists in every note individually) rather than in the global settings (which would be used for all notes by default.)


indexOf: fromIndex

I feel like indexOf's optional second parameter: fromIndex, is an unsung hero.
It has saved me many times from having to slice an array before calling indexOf.
Would you consider a PR with an example using fromIndex?

absolutely! it would be great if you could explain/show it in a way that didn't cloud newcomers understanding of indexOf.
The other thing is updating the languages. We could either drop it into google translate or just leave it different, I'm open to either.
I look forward to it!

Indexof ? I can't understand!! plaese somebody elobrate this.


Error in execution “ python3 main.py --load_config=unet_vgg16_train.yaml train Train VGG16UNET”

testc@testc2018:~/TFSegmentation$ python3 main.py --load_config=unet_vgg16_train.yaml train Train VGG16UNET
Parsing Arguments..
Using this arguments check it
batch_size -- 3 --
batchnorm_enabled -- True --
bias -- 0.0 --
config_path -- unet_vgg16_train.yaml --
data_dir -- data/full_cityscapes_res --
data_mode -- experiment --
exp_dir -- unet_vgg16 --
freeze_encoder -- False --
img_height -- 512 --
img_width -- 1024 --
learning_decay -- 1e-07 --
learning_decay_every -- 100 --
learning_rate -- 0.0001 --
max_to_keep -- 2 --
mode -- train --
model -- VGG16UNET --
momentum -- 0.9 --
num_channels -- 3 --
num_classes -- 20 --
num_epochs -- 200 --
num_groups -- 3 --
operator -- Train --
out_dir -- unet_vgg16 --
pretrained_path -- pretrained_weights/vgg16.npy --
random_cropping -- False --
save_every -- 5 --
shuffle -- True --
test_every -- 5 --
verbose -- False --
weight_decay -- 4e-05 --
weighted_loss -- True --
Traceback (most recent call last):
File "main.py", line 19, in
main()
File "main.py", line 14, in main
agent = Agent(args)
File "/home/testc/TFSegmentation/agent.py", line 36, in init
self.model = globals()[args.model]
KeyError: 'VGG16UNET'

You should go to models/[model_name.py]. Then, you should get the model class name. In your case, it's UNetVGG16 not VGG16UNET. Maybe you're using an old name of the class.

thank you help  me
I re  updated TFSegmentation, and now I report this mistake again
testc@testc2018:~/TFSegmentation$ python3 main.py --load_config=unet_vgg16_train.yaml train Train UNetVGG16
Parsing Arguments..
Using this arguments check it
batch_size -- 3 --
batchnorm_enabled -- True --
bias -- 0.0 --
config_path -- unet_vgg16_train.yaml --
data_dir -- full_cityscapes_res --
data_mode -- experiment --
exp_dir -- unet_vgg16 --
freeze_encoder -- False --
img_height -- 512 --
img_width -- 1024 --
learning_decay -- 1e-07 --
learning_decay_every -- 100 --
learning_rate -- 0.0001 --
max_to_keep -- 2 --
mode -- train --
model -- UNetVGG16 --
momentum -- 0.9 --
num_channels -- 3 --
num_classes -- 20 --
num_epochs -- 200 --
num_groups -- 3 --
operator -- Train --
out_dir -- unet_vgg16 --
pretrained_path -- pretrained_weights/vgg16.npy --
random_cropping -- False --
save_every -- 5 --
shuffle -- True --
test_every -- 5 --
verbose -- False --
weight_decay -- 4e-05 --
weighted_loss -- True --
Agent is running now...
2018-03-15 10:10:24.255299: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2018-03-15 10:10:24.255329: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2018-03-15 10:10:24.255345: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2018-03-15 10:10:24.255349: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2018-03-15 10:10:24.255354: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
Traceback (most recent call last):
File "main.py", line 19, in
main()
File "main.py", line 15, in main
agent.run()
File "/home/testc/TFSegmentation/utils/misc.py", line 18, in timed
result = f(*args, **kwargs)
File "/home/testc/TFSegmentation/agent.py", line 85, in run
self.build_model()
File "/home/testc/TFSegmentation/utils/misc.py", line 18, in timed
result = f(*args, **kwargs)
File "/home/testc/TFSegmentation/agent.py", line 46, in build_model
self.model = self.model(self.args)
File "/home/testc/TFSegmentation/models/unet_vgg16.py", line 11, in init
super().init(args, phase=phase)
TypeError: init() got an unexpected keyword argument 'phase'

I fixed the issue you should be able to run it now.

File "main.py", line 19, in
main()
File "main.py", line 15, in main
agent.run()
File "/home/testc/TFSegmentation/utils/misc.py", line 18, in timed
result = f(*args, **kwargs)
File "/home/testc/TFSegmentation/agent.py", line 85, in run
self.build_model()
File "/home/testc/TFSegmentation/utils/misc.py", line 18, in timed
result = f(*args, **kwargs)
File "/home/testc/TFSegmentation/agent.py", line 46, in build_model
self.model = self.model(self.args)
File "/home/testc/TFSegmentation/models/unet_vgg16.py", line 11, in init
super().init(args)
File "/home/testc/TFSegmentation/models/basic/basic_model.py", line 37, in init
self.params.class_weights= np.load(self.args.data_dir+'weights.npy')
File "/usr/local/lib/python3.5/dist-packages/numpy/lib/npyio.py", line 370, in load
fid = open(file, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '/home/testc/TFSegmentation/data/full_cityscapes_res/weights.npy


Examples fail mypy-checks in unexpected ways

What you are doing looks very cool and could be helpful to me and a lot of people.
However, the examples from the readme do not work for me (I have tried mypy with python3.10 and python3.11)
For example, with this one:
from typing import Any

import numpy as np

from phantom_tensors import parse
from phantom_tensors.numpy import NDArray
from phantom_tensors.alphabet import A, B  # these are just NewType(..., int) types

def func_on_2d(x: NDArray[Any, Any]): ...
def func_on_3d(x: NDArray[Any, Any, Any]): ...
def func_on_any_arr(x: np.ndarray): ...

# runtime: ensures shape of arr_3d matches (A, B, A) patterns
arr_3d = parse(np.ones((3, 5, 3)), NDArray[A, B, A])

func_on_2d(arr_3d)  # static type checker: Error!  # expects 2D arr, got 3D

func_on_3d(arr_3d)  # static type checker: OK
func_on_any_arr(arr_3d)  # static type checker: OK

I get the following errors:
phan_tensor_test.py:11: error: "NDArray" expects no type arguments, but 2 given  [type-arg]
phan_tensor_test.py:12: error: "NDArray" expects no type arguments, but 3 given  [type-arg]
phan_tensor_test.py:15: error: The type "Type[NDArray]" is not generic and not indexable  [misc]

I am not deep enough into python-typing to understand how this issue could be related to a misconfiguration. I know variadic generics are a very recent feature, which is why I tried to run it with python 3.11 but it still showed this error.
I am using the latest pypi-version of your library (I did not clone your repo)

(edited the title because the example is supposed to fail mypy, but on another line)

Thanks!
mypy is working on support: https://github.com/python/mypy/issues/12280
I wont switch typechecker to use phantom_tensors, but I expect to start using it once mypy catches up.


Kill serde_json dependency

bindgen currently pulls in serde_json (and with it a whole host of dependencies). The only reason we do this is because target_build_utils (a dependency of libloading) has a mode where you can give it a path to a json target spec.
It would be nice if this mode was made optional using cargo features, specifically an on-by-default feature. It could be threaded through Cargo features and turned off when used in bindgen.
https://github.com/nagisa/target_build_utils.rs/blob/a05415e6dd366a869f030e4e2dd6a5b4fe8963df/src/lib.rs#L137 is where the json ge
cc @nagisa
(Filing the bug here instead of on target_build_utils so that someone might pick it up as an easy bug)

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.
If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. :smile:

I can take this. I have wrote a patch for target_build_utils (I'll soon create the PR for it). But I'm not sure how to reflect this change in rust-bindgen though. We would need to also update libloading (to use the no-default-feature flag) right ?

Yes, or to adda feature in the same fashion, depending on whether
libloading uses it or not.
On Thu, Feb 09, 2017 at 05:41:16AM -0800, Matthias Devlamynck wrote:

I can take this. I have wrote a patch for target_build_utils (I'll soon create the PR for it). But I'm not sure how to reflect this change in rust-bindgen though. We would need to also update libloading (to use the no-default-feature flag) right ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/servo/rust-bindgen/issues/499#issuecomment-278643343

Ok, thx. I'll get working on the PRs for target_build_utils and libloading then.

If there's any PRs I'll look at them on a weekend.
On Feb 9, 2017 4:10 PM, "Matthias Devlamynck"<EMAIL_ADDRESS>wrote:

Ok, thx. I'll get working on the PRs for target_build_utils and libloading
then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/servo/rust-bindgen/issues/499#issuecomment-278651229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApc0pUSz-inC-kDo4PadVUVq8Kdlw4Dks5rax5ogaJpZM4L7bH4
.

Note that such a PR on target_build_utils would be a breaking change, and thus we will also need a correspond libloading bump.

@Manishearth Even as a default feature, someone could be depending on it with default-features = false.

I generally find it weird somebody would rather get rid of a dependency than just support people who use custom target specs.
That being said, there’s a nifty feature in nightly cargo which exposes the necessary data through environment variables, so eventually I’ll be able to both drop the dependency and keep the support for custom target specs.
In the meantime, knock yourselves out with the 0.3.2 release (I hadn’t considered breaking change aspect on bumping the version number yesterday, so its a minor version bump)

Thanks!

What's the next step here since https://github.com/nagisa/target_build_utils.rs/issues/3 merged?

Hello? The issue is marked easy and assigned, and I can't figure out what its status actually is.

Unassigned since it's been a month. Feel free to ping and ask for assignment.
The next step is to add this default feature to libloading.

Not sure libloading needs any changes.

Don't we need to be able to pass through the feature flag?

@highfive assign me

Hey @TannerRogalsky! Thanks for your interest in working on this issue. It's now assigned to you!

@TannerRogalsky how are things going? Anything I can help with? Any questions I can answer for you?

@fitzgen I got stuck trying to figure out how to disable default features on a dependency of a dependency.
The relevant piece of documentation for reexporting features that I could find was here.
# Features can be used to reexport features of other packages. The `session`
# feature of package `awesome` will ensure that the `session` feature of the
# package `cookie` is also enabled.
session = ["cookie/session"]

But I'm not sure how this idiom extends to default-features = false.

@fitzgen I got stuck trying to figure out how to disable default features on a dependency of a dependency.

If you want to disable the default features of A, which is depended upon by B in C, you need to disable them in B.

libloading 0.4.0 does not depend on target_build_utils anymore.

@nagisa Fantastic. That should simplify things, I think. I've updated clang-sys to point at your new version. After that is merged and bumped, I should be able to update rust-bindgen's dependency on clang-sys which should close this issue.

This issue should be resolved with #685.

Thanks!


Files matched with glob pattern end with wrong order in the concatenated file

As title says.
For further information please, look at:
http://stackoverflow.com/questions/30402972/grunt-concat-angularjs

https://github.com/gruntjs/grunt/issues/1338

Maybe this issue is similar:
http://stackoverflow.com/questions/30888486/angular-state-already-defined-error-after-running-concat-uglify

@gruberb Yes, it is the same issue but the final solution should be found in grunt core itself and not in Angular nor in the contrib-concat libraries.
I will close this issue since I already opened a discussion at the grunt-core repo.
https://github.com/gruntjs/grunt/issues/1338
It seems that a possible solution to this could be to let specify grunt users  in the tasks options object the algorithm to organize file paths.


feat(ios): adopt facebook-ios-sdk 17.1.0

update example to use current-reactive and fuzz-bust through all the issues related

new react-native init items like git init
yarn2 is the default now, so converted module and example
new syntax for yarn2 git adds

Investigate the diff between facebook-ios-sdk 17.0.x and 17.1.x, appears fine, and appears to work fine in testing
Note: there is a 17.2.0 apparently already cooking per their changelog but it isn't on cocoapods yet so I couldn't fetch it
I allow the facebook-ios-sdk version to slip for patch versions now but they have a warning about Swift/Obj-C compat on their repo indicating that minor versions may break compiles, so I couldn't let the semver range slip minors. They have broken us before 🤷
Fixes #555

Fixed the various deprecation and lint things I saw while examining the CI output
Note that one was not fixable as it appears to be an upstream issue, logged here https://github.com/facebook/facebook-ios-sdk/issues/2476


Switch order of commands to ensure uninstall is successfull

I might be missing something - but this looks exactly the same ... what has changed?

@ncbaratta the steps are reordered, i.e. the delete project/namespace step is moved to the end instead of as the 2nd step.