IndexError: list index out of range

Traceback (most recent call last):
  File "./eval.py", line 101, in <module>
    eval(args.out_file, args.src_file, args.tgt_file)
  File "./eval.py", line 72, in eval
    pair['prediction'] = output[idx]
IndexError: list index out of range

How do i fix this when iam running eval.py with an output file

Please check the source file, predicted text, output file you are passing as arguments.
It might happen that you are passing the pred.txt file generated using src-dev.txt but the default source file for eval.py is src-test.txt. This might be the reason for index mismatch.
Also, check where you saved the pred.txt generated using the previous command and pass the correct path.
I ran the command as follows:
python2 eval.py -out ../sentence/pred.txt -src ../data/processed/src-dev.txt -tgt ../data/processed/tgt-dev.txt

I met the same error when I run preprocess_embedding.sh, how can I fix it


How to use OnConstraint correctly with Gorm

Your Question

How do we use OnConstraint correctly? The SQL statement that gorm generated with OnConstraint has syntax error
	result := t.DB.Orm.
		WithContext(ctx).Table(total.TableName()).Clauses(clause.OnConflict{
		OnConstraint: "totals_date",
		UpdateAll:    true,
	}).Create(&total)
	if err := db.HandlePgResult(result, "total repository create total"); err != nil {
		return nil, err
	}

{"elapsed":4807583,"error":"ERROR: syntax error at or near \"ON\" (SQLSTATE 42601)","message":"error executing sql","rowsAffected":0,"severity":"error","sql":"INSERT INTO \"totals\" (\"id\",\"created_at\",\"updated_at\",\"shop_id\",\"date\",\"cash\",\"credit\",\"gift_card\",\"custom\") VALUES ('dadeb539-eae2-4f4e-9bc5-9ebd67c83132','2023-07-20 22:48:41.869','2023-07-20 22:48:41.869','6f460f46-9683-4caa-9d93-e6acd104a646','2023-07-20 00:00:00',5,4,45,64) ON CONFLICT (\"id\") ON CONSTRAINT totals_date DO UPDATE SET \"updated_at\"='2023-07-20 22:48:41.869',\"shop_id\"=\"excluded\".\"shop_id\",\"date\"=\"excluded\".\"date\",\"cash\"=\"excluded\".\"cash\",\"credit\"=\"excluded\".\"credit\",\"gift_card\"=\"excluded\".\"gift_card\",\"custom\"=\"excluded\".\"custom\"","tag":"nails_backend","timestamp":"2023-07-20T15:48:41.872911-07:00"}

This is what gorm generated in SQL
INSERT INTO "totals" ("id","created_at","updated_at","shop_id","date","cash","credit","gift_card","custom")
VALUES ('dadeb539-eae2-4f4e-9bc5-9ebd67c83132','2023-07-20 22:48:41.869','2023-07-20 22:48:41.869','6f460f46-9683-4caa-9d93-e6acd104a646','2023-07-20 00:00:00',5,4,45,64)
ON CONFLICT ("id") ON CONSTRAINT totals_date
DO UPDATE SET "updated_at"='2023-07-20 22:48:41.869',
"shop_id"="excluded"."shop_id","date"="excluded"."date",
"cash"="excluded"."cash","credit"="excluded"."credit",
"gift_card"="excluded"."gift_card","custom"="excluded"."custom"

Is there a way to get rid of the ("id") so that ON CONFLICT ("id") ON CONSTRAINT totals_date  turns into ON CONFLICT ON CONSTRAINT totals_date

This might be a little different from what you ask, but it you're sure about the SQL you're giving, you can send the Raw SQL
https://gorm.io/docs/sql_builder.html

Are you using MySQL? it doesn't this kind of SQL

@jinzhu I am using postgres. Would this  ON CONSTRAINT only work with mysql?


Gradle task assembleDebug failed with exit code 1

I was an error like this when I tried to debug my app.
`FAILURE: Build failed with an exception.

What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.

Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
Could not resolve io.flutter:flutter_embedding_debug:1.0.0-e7b69ced2e2408da86261227a04f09e0c0fe905d.
Required by:
project :app
project :app > project :firebase_auth
project :app > project :cloud_firestore
project :app > project :google_sign_in
project :app > project :firebase_core
project :app > project :firebase_storage`

and so on...
my pubspec.yaml dependencies-
 cupertino_icons: ^0.1.2
firebase_auth: ^0.14.0+5
firebase_core: 0.4.2+1
cloud_firestore: ^0.12.9+4
provider: ^3.1.0+1
flutter_spinkit: "^4.0.0"
google_sign_in: ^4.0.14
firebase_storage: ^3.0.8/
and flutter doctor -v

[√] Flutter (Channel master, v1.13.1-pre.59, on Microsoft Windows [Version 10.0.18363.476], locale en-IN)
• Flutter version 1.13.1-pre.59 at C:\Users\acer\flutter
• Framework revision e58dc16d7b (35 hours ago), 2019-12-06 18:21:52 -0800
• Engine revision e7b69ced2e
• Dart version 2.7.0 (build 2.7.0-dev.2.1 a9c77229c2)`

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\acer\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.

[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 41.1.2
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.40.2)
• VS Code at C:\Users\acer\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.7.0

[√] Connected device (1 available)
• AOSP on IA Emulator • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)`

The issue occurred because firebase_analytics: ^5.0.2 wasn't enabled.
After updating it, the issue was resolved.


Feat:Add Blog Section

Describe the feature
The blog on our platform is a go-to resource for camping enthusiasts, offering expert tips, destination spotlights, gear reviews, and community stories. Discover everything from beginner guides to eco-friendly camping practices, and get inspired by real adventure stories from fellow campers. Whether you're planning your next trip or seeking advice, our blog is here to help you make the most of your outdoor experiences.
@VigneshDevHub please assign me this issue.
GSSoC'24 Extd Contributor 🌟
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hey @falak412, We don't need this feature right now, but thanks for the suggestion.


Support for basis blades that are non-canonical

I'd like for Clifford to have the ability to store MV's in basis blades that are out of order.
For example, 2D PGA has the bases blades in this order
e0 e1 e2 e01 e20 e12 e012

The e20 blade is out of order.
So I'd like to write something like the following
ids = BasisVectorIds.ordered_integers(3, first_index=0)
order = ids.order_from_tuples((), (0,), (1,), (2,), (0,1), (2,0), (1,2), (0,1,2))
...

This throws an error saying that The blade (2, 0) is not canonical and sign flips in storage are not supported.

I'm kind of new to this kind of algebra btw. Was learning about it from Bivector's channel.


fix(ui): update misleading wallet unlock description

Description:
Update misleading wallet unlock description.
Change from:
Set a password to encrypt your wallet. This password will be needed to unlock Zap in the future.
To:
Set a password to encrypt your wallet. This password will be needed to unlock the wallet in the future.
NOTE: I've also updated other text for other languages that have provided translations. Whilst doing so I noticed that some of the other translations still included the phrase looks like you are new here!at the start of the text, which was removed from the english translation a while ago so I removed it from those translations too.
Motivation and Context:
We now have a app-wide password feature which currently operates in addition to the wallet level password. The language on the password setup screen as part of wallet onboarding should be more clear that the password relates to the wallet and not Zap as a whole.
How Has This Been Tested?
Manualy
Types of changes:
Language change
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 22.725% when pulling 9625116d6a47616907e842bffd215f410a7da0bb on mrfelton:fix/wallet-unlock-language into 27e665d5114559a0a638646fb5beb00ba1794943 on LN-Zap:next.


Point workflows to diem/actions instead of libra/actions

More things to change from the Libra -> Diem rename.

/land priority=low


[crash]ClassCastException Error Causing Raid Crash

While using the Goety mod, a ClassCastException error occurs when triggering a raid event, resulting in the server crashing and when I set specialIllagerRaid = false in the config, the crash still occurs
Minecraft Version:  1.20.1
Goety Version: goety-<IP_ADDRESS>
Server Type: running on Arclight core and forge 47.3.11
crashlog:
crash-2024-11-02_17.49.20-server.txt

Crash log has no indication that Goety is responsible for the crash. Have you tried making a Raid without Goety installed?

Crash log has no indication that Goety is responsible for the crash. Have you tried making a Raid without Goety installed?

Sure I tried rebuilding Arclight in another folder and the mods only have goety and curious-api and the crash still happened

Might be caused by Arclight raid mixin conflicting with Goety: https://github.com/Polarice3/Goety-2/blob/1.20/src/main/java/com/Polarice3/Goety/mixin/RaidMixin.java
In which case, try disabling armoredRavagerRaid on config

I disabled armoredRavagerRaid as suggested, but the crash still happens. I really enjoy this mod, so as a temporary solution, I turned off the raid on server and created a datapack to obtain the Hero of the Village buff . Hopefully, we can find a better solution in the future. Thanks a lot for your help: )


Separate tax from product price

Issue Addressed ("Issue ID"): #93

Short recap of the issue
Thawani-hosted payment does not contain a tax feature

Description:

Summary of what was added, changed or fixed. For example File and/or Function names alongside their purposes.
Why were these changes necessary.

In this PR we gave the user visibility to the tax prices when purchasing the products

Testing:

Describe what was done to test and ensure the functionality of the pervious version
The Unit testing implemented to allow future testing of newly added functionallity (If applicable)

Checklist

[ ] I have commented the newly added code
[ ] I update the Readme.md file to include the new changes to the project
[ ] All the previously included Unit Tests passed in all the cases

Hey @mariamalbalushi I wouldn't recommend going with this .. I've already implemented this feature in #25 and then I faced an issue where if you are going to buy any product that cost 1 OMR , the vat will be 50 bisa which will break the creation of generating checkout link ...
The fix was on #28

@w7shdev @Ma7eer I will close this PR with no action as we can't have a product less than 100 baisa (Thawani does not accept that).


Can this be a problem when choosing the same token id for both mask token and unknown residues?

Hi, Jason,
Thanks for providing the code. I have a question over your choice of MASK_TOKEN_INDEX, where you resort to MASK_TOKEN_INDEX = residue_constants.restypes_with_x.index('X'). That is, the mask token index is equivalent to the X amino acid.
However, this may cause some errors when calculating the loss. From my point of view, you forced the predicted probabilities of unknown residue (X) to be close to 0.

However, when you processed the data, any unknown residues were indexed using X's index.

Therefore, it seems weird to me that the GT for those unknown residues is X' index but their predicted prob. of X is tuned to 0.
Though no loss imposed in this case (so it is acceptable?).

P.S. why do not use another independent token index (i.e. 22) for the mask token?

Hi,
Thanks for the question. it makes sense to include another token to be the mask token. There wasn't a benefit for our tasks so we didn't do it.
We don't want to impose a loss on unknown residues because we don't want the model to ever sample unknown residues. That is why we set unknown residues to be the mask token.

Closing due to inactivity.


fix: validate notification link when posting

Hey, I just made a Pull Request!
fixes an issue that allows posting notifications containing links with cross-site scripting attack
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Not stale, waiting for merge


Use spin lock for insertBlockIntoMapsTypeCase

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-build-arm64

/run-build-arm64

/run-build-release

/run-build-arm64 (test arm64 build pipeline)

/run-build-arm64-release comment=true

/run-build-arm64

performance regression

/run-build-arm64

/run-build-arm64

/run-build-arm64-release comment=true

/run-all-tests

/rebuild

/run-integration-test

/run-integration-test

/run-unit-test

/run-all-tests

/hold

/hold cancel

/run-all-tests

/run-all-tests

/run-unit-test

/run-unit-test


Why is unsupported Python 2 required for installation

What is wrong?
Python 2 died 1,132 days ago on 1/1/2020 with no security updates since then and there is no Python code in this repository.
Why is unsupported software a requirement for installation?

https://github.com/BrainJS/brain.js#system-dependencies
https://devguide.python.org/versions

Where does it happen?

How do we replicate the issue?

Step 1
Step 2
Step 3

Expected behavior (i.e. solution)

Version information
Nodejs:
Browser:
Brain.js:
How important is this (1-5)?

Other Comments

I don't think that Python 2 is really a requirement, I'm building using Python 3, the README text is probably just outdated. Now why Python is required at all, I believe is because of headless-gl.

I believe this to be correct.  Python is a requirement of node.

I don't think that Python 2 is really a requirement, I'm building using Python 3, the README text is probably just outdated. Now why Python is required at all, I believe is because of headless-gl.

Did you have to change the installation process in any way to accomodate Python 3 instead of Python 2?

Fixed in #880


Disable Keyboard manager by default on Games (Full screen apps)

Description of the new feature / enhancement
based on reddit posts, we're seeing KBM causing a input delays on games.
i propose we have an option that is turned on by default to "Ignore / Disable KBM on full screen mode"
Scenario when this would be used?
Gamers and not causing an input delay
Supporting information
No response

fyi to @dedavis6797

We added some changes to make this better. Is this still on 0.47?

I was seeing comments via Reddit which is why i flagged this

Could couple this with ignore app list. There is a tracked feature for this.

Xref #8809

I use KBM for NFS heat since I have no num-pad on my keyboard, will this is toggle-able?


Need support Oracle

Dear ADS team:
I have been using Sql Server and its tools for almost 10 years. This is a pleasant experience. These tools have made my job easier.
But, but, sadly, recently my boss decided to replace ERP, It is based on oracle. After several searching and trying, I found that oracle has almost no any good tool, any!
I miss the days of writing code in SSMS and ADS (mainly the former, I will also ask them). So I sincerely ask you to help me this poor DBA, let your tools support oracle.
THANK YOU!

Hello @ahdung - thank you for the feedback, I'm glad our tools are useful to you! Currently for database support we're collecting all requests into single issues to reduce duplication - for Oracle support that's https://github.com/microsoft/azuredatastudio/issues/6724
I'm going to close this one but I encourage you to go upvote that issue and leave any other feedback/suggestions related to supporting that there. Thanks!


Prepending the commands with '$'

I don't really mind whether commands are with or without $, but the current page is inconsistent. Four cases are without a dollar, one is with.
The front-page README of the project uses the dollar, so I'm suggesting going that way, but this is merely just a heads-up for the author.
Note: The PR contains #1144

Thanks for this. Please rebase the PR.


Fix title clipping

The example title text descents are being clipped. This PR removes that.
Before

After

Indeed that line did not make sense, thank you!


debug_toolbar not loading at all when profiling is selected

I tried to setup the line_profiler panel in debug_toolbar.
When I add it to DEBUG_TOOLBAR_PANELS, the panel loads but does not show the line_profiler entry.
When the regular profiling option is checked, the panel does not load at all.
I am on Django 3.2.11 and debug_toolbar 3.2.4

Can replicate - django 4.0 and debug toolbar 3.5.0


[Storage] BREAKING CHANGE: az storage account create: Change default storage account kind to StorageV2

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.

Description:
The feature is required for a long time. Given there is more and more feature only available in StorageV2 Kind, we need to switch the defualt kind to StoargeV2, which will be align with Powershell, two.
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S165.


[Request] PNASNet-5-Mobile

PNASNet-5-Large is already in the repo. Would it be possible to include PNASNet-5-Mobile?
Thanks!

I will try to do this soon.


Research Clock Sync

The nodes clock is expected to be sync'd every hour using an NTP server (pool.ntp.org recommended). More research is required into how we can do this.
http://localhost:1313/#clock-requirements (e9b36c7)

For the foreseeable future, we won't be doing this as it isn't an explicit part of the protocol.
Currently up to users to handle clock sync through ntp or otherwise, and system time will be used within the client.


模型参数缺失

作者您好！在使用您提供的模型参数（https://drive.google.com/file/d/1tKIib7qRN5IdNXhVB_8v1EBYiWdU12v8/view?usp=share_link）运行gen.py时，出现下图报错

请问您是否方便提供正确的.pt文件？

Thanks for your reminder! I checked the file and found that I forgot to replace the new version of parameters. Now the link has been changed, hope you can benefit from it. I recognize that it may contain several bugs since the model has been updated, which is different from its original version (Jan-2022). So feel free to contact if you have any problems!


make parseCookies parse cookies as rawCookies

replaces #1336
fixes #1228

Okay, should pass now. Merging.

:dancers: thanks


Fixes #11. Upgraded wrapper script and added version to build config

Old wrapper script packaged with the repo was unable to handle the model block as shown in issue #11. Explicitly specified the version of the new wrapper script that is packaged with the repo in the build.gradle file so another user can regenerate wrappers using gradle wrapper

mm true that i think i messed up with the wrapper, thanks!

@Guppster can you provide me with your Ark address?

@boldninja Sent on slack


colour property Not working properly with nested elements

I have two nested elements. both have different data-cursor-color prop. when cursor gets into parent, it works fine.

when i put cursor into the child element, it also works fine.

but the problem happens when i get the cursor out of the child element, the cursor does not change color for the parent element

am i doing something wrong? or it's an expected behaviour?

Hi! It doesn't work with nested elements.


Antialiasing has no effect when ClearColor is transparent

Description of the bug
I've tried with both (SMAA and FXAA), but any looks correct effect when the renderer ClearColor is transparent.
To Reproduce
renderer.setClearColor(0xffffff, 0)
...
const fxaaEffect = new FXAAEffect()
fxaaEffect.subpixelQuality = 0.1

...
const smaaEffect = new SMAAEffect()
smaaEffect.preset = SMAAPreset.ULTRA
smaaEffect.edgeDetectionMode = EdgeDetectionMode.COLOR

Expected behavior
Antialiasing have the same effect when ClearColor have non-transparent value.
Screenshots
No-transparent ClearColor.

Transparent ClearColor.

NOW, if I use lower values in alpha at clearColor the thing gets better.
renderer.setClearColor(0xffffff, 0.1)

But the background is annoying for the application that I needed.
Library versions used

Three:  "^0.132.2"
Post Processing: "^6.28.4",

Desktop

OS: [e.g. Windows]
Browser [e.g. Chrome X.X.X.X]
Graphics hardware: [e.g. NVIDIA]

Mobile

Device: [e.g. iPhone]
OS: [e.g. Android]
Browser [e.g. Firefox X.X.X]

Repro: https://codesandbox.io/s/affectionate-johnson-0lu79i?file=/src/App.js
The problem is that the edge detection logic in FXAA and SMAA ignores the alpha channel. I'm not sure yet how this should be handled.. maybe multiplying the color samples with the respective alpha values could work. I'll look into it.

Unfortunately, I was unable to get FXAA/SMAA to work with a transparent canvas. Anti-aliasing works by blending pixels with neighboring pixels, but when the canvas is transparent, the AA won't have access to the pixels that are "behind" the canvas. The result is an incomplete AA-blend that doesn't remove the jaggies.
I tried using MSAA with a transparent canvas as well, and found that it has the same problem:

Closing this as I don't think this can be solved. Feel free to reopen/comment if you or someone else knows a solution.


Windows support rework + Initial Windows Espressif support

This commit includes a rework of Windows support for xs-dev + initial Windows support for the ESP8266 and ESP32. In the spirit of always throwing away the first draft of a project, this PR replaces the work in #44.
The differences between this PR and #44 are:

No longer modify the User's permanent environment variables / registry

Instead, manage environment setup through a batch file that must be invoked in new Command Prompt instances (Moddable.bat) which is created by xs-dev setup
Moddable.bat runs the VS 2022 environment setup batch file, the ESP-IDF environment setup batch file (if needed), sets Moddable environment variables, etc.
xs-dev setup also creates a Windows Shortcut that opens a Command Prompt and automatically invokes Moddable.bat. This "Moddable Command Prompt" should be used for all xs-dev/Moddable SDK sessions after setup

Added initial support for ESP8266 and ESP32 on Windows

xs-dev setup and xs-dev run work with  --device=esp8266 and device=esp32
There seems to be an issue at the moment with the certificate used by moddable.com that is causing some issues with the download of ESP8266 pieces

Improvements pushed thanks to @HipsterBrown's review:

Automatically open the Moddable Command Prompt when possible instead of just scolding the user
Automate installs of Git and VS 2022 via winget
Tidying

The most recent commit incorporates fixes for issues discovered while testing on a clean VM. It turns out that the VS 2022 Community installation flow sometimes requires interaction at the command prompt. That took some doing to get right. Plus, it turns out that interactive command prompts do not play nicely with the spinner, so the spinning needs to be deferred until after that step...
There's still one manual step in here that in theory could be semi-automated. That is installing the "Desktop development for C++" workload in Visual Studio 2022. I haven't had any luck even kicking that off automatically yet, but I'll keep looking into it if I get a chance down the road.

Hi @HipsterBrown! How would you like to see this move forward? I think I've tested everything about as far as I can with my one machine. I'd love to get more eyes on this, but that may be challenging until it is incorporated into a release.
I propose that I sort out the new merge conflict here, bundle this up into a single feature commit, and get it submitted as a new PR. I think I could do that on Friday. Then perhaps we could get it out to the world as a sort of beta release for Windows?

@andycarle I'll test this branch on my Windows machine as well, but I agree that we should get it out there and gather feedback. One of the reasons xs-dev has stayed pre-1.0 is due to the missing Windows support, so we can release what you have here under the main branch of the CLI with the expectation that we might need to make breaking changes in the future until it is stable at 1.0.
Let me know if you run into any issue resolving merge conflicts 🙏

I was able to run the features of this branch as expected on my test machine 🙌
A great fast follow up after this work is released will be using the prebuilt Moddable tooling to match the Mac and Linux default behavior.

supplanted by #63


Add plugin to remove window size minimum

Can we get the ability to make the client smaller? Right now there's a default minimum value on the size of the client/window, I'd like to be able to remove that limit, or at least make it a smaller minimum

Duplicate of #3937

Duplicate of #3937

Oops sorry, this didn't come up with the title search thing, thank you.

To be fair, I only found it because I knew that it existed. It wasn't easy to find for me either.


SublimeLinter error for package.json without name attribute

SublimeLinter gave crashes with an error (see below) if there is no "name" attribute in the package.json. This is of course a bad package.json if it has no name. However this shouldn't stop the linter from running. The error happens in
Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 89
is_dep = True if self.npm_name == pkg['name'] else False
I don't know python but there should be a check for existance of the attribute "name" before accessing it. In javascript it would be something like typeof pkg.name !== "undefined"
Regards,
Thorsten
SublimeLinter: error in SublimeLinter daemon:
SublimeLinter: --------------------
SublimeLinter: Traceback (most recent call last):
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/queue.py", line 58, in loop
    item = self.q.get(block=True, timeout=self.MIN_DELAY)
  File "./queue.py", line 175, in get
queue.Empty

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/queue.py", line 66, in loop
    self.lint(view_id, timestamp)
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/queue.py", line 112, in lint
    self.callback(view_id, timestamp)
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/sublimelinter.py", line 123, in lint
    Linter.lint_view(view, filename, code, hit_time, callback)
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/linter.py", line 917, in lint_view
    linter.lint(hit_time)
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 64, in lint
    is_dep = self.is_dependency()
  File "/Users/xxx/Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/node_linter.py", line 89, in is_dependency
    is_dep = True if self.npm_name == pkg['name'] else False
KeyError: 'name'

Fixed and released with #215


Sort explore-ndcs/-lts table data on load

This small PR fixes the problem with the initial sorting of the data table on explore-ndcs/ -lts pages.
PIVOTAL
The sorting feature works well on the Table component, the thing is that there is no initial sorting after data the fetch.
The data is sorted by iso on the backend, so maybe that would be something we could change in the future @simaob? Like to sort by the data name of the country?
Test: Go to ndc-explore and lts-explore pages, and check if the rows are sorted by country column after first load. Also, check if manual sorting works ok.

What's the endpoint being used here? /ndcs ?


Server ingress not setting ingressClassName once ArgoCD instance gets updated with the field

Describe the bug
We are using Red Hat OpenShift GitOps operator on stable channel,with automatic updates, exactly openshift-gitops-operator.v1.7.4.
Our ArgoCD instance uses the Ingress object in the spec.server config to publish the server.
We have just upgraded to OCP 4.12.33, and obtained a prometheus alert called IngressWithoutClassName, and the reason is that the ingress created by the openshift-gitops-operator was not setting the ingressClassName.
To resolve the alert, we have updated our ArgoCD instance to include the missing ingressClassName field:
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: argocd
spec:
  server:
    host: gitops.example.net
    ingress:
      annotations:
        cert-manager.io/cluster-issuer: letsencrypt-production
        external-dns.alpha.kubernetes.io/target: gitops.apps.example-cluster.example.net
      enabled: true
      ingressClassName: openshift-default  ## THIS
      tls:
        - hosts:
            - gitops.example.net
          secretName: gitops.example.net-cert
...

However, the ingress created by openshift-gitops-operator is not updated on the next operator reconcile:
kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    external-dns.alpha.kubernetes.io/target: gitops.apps.example-cluster.example.net
  name: argocd-server
spec:
  tls:
    - hosts:
        - gitops.example.net
      secretName: gitops.example.net-cert
  rules:
    - host: gitops.example.net
      http:
        paths:
          - path: /
            pathType: ImplementationSpecific
            backend:
              service:
                name: argocd-server
                port:
                  name: http

Expected behavior
I would expect, that after adding the field  spec.server.ingress.ingressClassName to the ArgoCD instance, openshift-gitops-operator would reconcile the Ingress and add the ingressClassName field to the Ingress resource:
kind: Ingress
apiVersion: networking.k8s.io/v1
metadata:
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt-production
    external-dns.alpha.kubernetes.io/target: gitops.apps.example-cluster.example.net
  name: argocd-server
spec:
  ingressClassName: openshift-default   ## THIS
  tls:
    - hosts:
        - gitops.example.net
      secretName: gitops.example.net-cert
  rules:
    - host: gitops.example.net
      http:
        paths:
          - path: /
            pathType: ImplementationSpecific
            backend:
              service:
                name: argocd-server
                port:
                  name: http

Screenshots

Additional context
N/A

Was able to reproduce this, made corresponding jira for this here: https://issues.redhat.com/browse/GITOPS-3412


Docker daemon crashes/logs full of network not found

BUG REPORT INFORMATION (may be related to #19988)
Output of docker version:
Docker version 1.9.0, build 76d6bc9
# and also
Docker version 1.10.2, build c3959b1

Output of docker info:
# none, I can't reanimate the daemon anymore and all my 230+ containers are basically down

Provide additional environment details (AWS, VirtualBox, physical, etc.):
OpenStack VM, 4 cores, 8 GB mem, Ubuntu 14.04.4 LTS, Linux 2b320682-1875-4548-a1e2-29d15b11b5a8 3.19.0-49-generic #55~14.04.1hf1533043v20160201b1-Ubuntu SMP Mon Feb 1 20:41:00 UT x86_64 x86_64 x86_64 GNU/Linux.
List the steps to reproduce the issue:
Started by script since months without problems, but now failing. Also fails after Docker update and OS update. Here the launch command we use (230+ containers all started with restart policy = always):
docker daemon --api-cors-header=false --debug=false --disable-legacy-registry=false --group vcap --graph /var/vcap/store/docker/docker --host unix:///var/vcap/sys/run/docker/docker.sock --icc=true --ip-forward=true --ip-masq=true --iptables=true --ipv6=false --log-level=info --pidfile /var/vcap/sys/run/docker/docker.pid --selinux-enabled=false --host tcp://<IP_ADDRESS>:4243 --tls=false --userland-proxy=true

Describe the results you received:
INFO[0000] API listen on /var/vcap/sys/run/docker/docker.sock
INFO[0000] API listen on [::]:4243
INFO[0000] [graphdriver] using prior storage driver "aufs"
ERRO[0000] getNetworkFromStore for nid d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 failed while trying to build sandbox for cleanup: network d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 not found
ERRO[0000] getEndpointFromStore for eid 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf191e1663f failed while trying to build sandbox for cleanup: could not find endpoint 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf191e1663f: Key not found in store
WARN[0000] Failed detaching sandbox 569c2a0eefb84fb14b3e3c6cbb554163b480331b996e2ef9f7b2fa9a4e033672 from endpoint c71f3a95931e93968f28f0ab27bef203d10aa1d48b2c18b36ca56eaf023fcc10: failed to get network from store during leave: network d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 not found

WARN[0000] Failed deleting endpoint c71f3a95931e93968f28f0ab27bef203d10aa1d48b2c18b36ca56eaf023fcc10: failed to get network during Delete: network d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 not found

WARN[0000] Failed detaching sandbox 569c2a0eefb84fb14b3e3c6cbb554163b480331b996e2ef9f7b2fa9a4e033672 from endpoint 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf191e1663f: failed to get endpoint from store during leave: could not find endpoint 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf19
1e1663f: Key not found in store

WARN[0000] Failed deleting endpoint 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf191e1663f: failed to get endpoint from store during Delete: could not find endpoint 8fc41dcb6bf31938e79b193d01ce84acd7f660d8ae82afb6f31c8bf191e1663f: Key not found in store

ERRO[0000] failed to delete sandbox 569c2a0eefb84fb14b3e3c6cbb554163b480331b996e2ef9f7b2fa9a4e033672 while trying to cleanup: could not cleanup all the endpoints in container 27f42f1c8f2792639d4c96f621408b1551a9121c184f2721b6aa17444c96177f / sandbox 569c2a0eefb84fb14b3e3c6cbb554163b480331b996e2ef9f7b2fa9a4e03
3672

...
ERRO[0025] getNetworkFromStore for nid d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 failed while trying to build sandbox for cleanup: network d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 not found                                                                 [18/6605]
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x168 pc=0x87f3d9]

goroutine 1 [running]:
github.com/docker/libnetwork.epHeap.Less(0xc20864d570, 0x2, 0x2, 0x1, 0x0, 0xc208033a70)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/sandbox.go:968 +0x159
github.com/docker/libnetwork.(*epHeap).Less(0xc208854630, 0x1, 0x0, 0x2)
        <autogenerated>:50 +0xb5
container/heap.up(0x7f835b7a4438, 0xc208854630, 0x1)
        /usr/local/go/src/container/heap/heap.go:93 +0x5f
container/heap.Push(0x7f835b7a4438, 0xc208854630, 0x13ce9e0, 0xc208033a70)
        /usr/local/go/src/container/heap/heap.go:54 +0x7e
github.com/docker/libnetwork.(*controller).sandboxCleanup(0xc2080a0370)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/sandbox_store.go:226 +0xc06
github.com/docker/libnetwork.New(0xc208765bc0, 0x5, 0x8, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/controller.go:200 +0x6cb
github.com/docker/docker/daemon.(*Daemon).initNetworkController(0xc208071040, 0xc2080eb180, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/daemon_unix.go:364 +0xfd
github.com/docker/docker/daemon.NewDaemon(0xc2080eb180, 0xc20803a430, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/daemon.go:770 +0x2149
main.(*DaemonCli).CmdDaemon(0xc2084f5240, 0xc20800a020, 0x16, 0x16, 0x0, 0x0)
        /go/src/github.com/docker/docker/docker/daemon.go:269 +0x1722
reflect.callMethod(0xc2084d7f50, 0xc2084dbce8)
        /usr/local/go/src/reflect/value.go:605 +0x179
reflect.methodValueCall(0xc20800a020, 0x16, 0x16, 0x1, 0xc2084d7f50, 0x0, 0x0, 0xc2084d7f50, 0x0, 0x4dcb9f, ...)
        /usr/local/go/src/reflect/asm_amd64.s:29 +0x36
github.com/docker/docker/cli.(*Cli).Run(0xc2084d7e90, 0xc20800a010, 0x17, 0x17, 0x0, 0x0)
        /go/src/github.com/docker/docker/cli/cli.go:89 +0x38e
main.main()
        /go/src/github.com/docker/docker/docker/docker.go:65 +0x418

goroutine 5 [syscall]:
os/signal.loop()
        /usr/local/go/src/os/signal/signal_unix.go:21 +0x1f
created by os/signal.init·1
        /usr/local/go/src/os/signal/signal_unix.go:27 +0x35

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /usr/local/go/src/runtime/asm_amd64.s:2232 +0x1

goroutine 12 [chan receive]:
github.com/docker/docker/pkg/listenbuffer.(*defaultListener).Accept(0xc208504380, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/pkg/listenbuffer/buffer.go:73 +0xb6
net/http.(*Server).Serve(0xc2080428a0, 0x7f835b79a568, 0xc208504380, 0x0, 0x0)
        /usr/local/go/src/net/http/server.go:1728 +0x92
github.com/docker/docker/api/server.(*HTTPServer).Serve(0xc208504460, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:113 +0x4d
github.com/docker/docker/api/server.func·006(0xc208504460)
        /go/src/github.com/docker/docker/api/server/server.go:86 +0x163
created by github.com/docker/docker/api/server.(*Server).ServeAPI
        /go/src/github.com/docker/docker/api/server/server.go:90 +0x144

goroutine 10 [chan receive]:
github.com/docker/docker/api/server.(*Server).ServeAPI(0xc208037900, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:94 +0x1b6
main.func·007()
        /go/src/github.com/docker/docker/docker/daemon.go:255 +0x3b
created by main.(*DaemonCli).CmdDaemon
        /go/src/github.com/docker/docker/docker/daemon.go:261 +0x1571

goroutine 11 [chan receive]:
github.com/docker/docker/daemon.func·030()
        /go/src/github.com/docker/docker/daemon/debugtrap_unix.go:17 +0x5c
created by github.com/docker/docker/daemon.setupDumpStackTrap
        /go/src/github.com/docker/docker/daemon/debugtrap_unix.go:20 +0x18e

goroutine 13 [chan receive]:
github.com/docker/docker/pkg/listenbuffer.(*defaultListener).Accept(0xc2085044a0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/pkg/listenbuffer/buffer.go:73 +0xb6
net/http.(*Server).Serve(0xc208042a20, 0x7f835b79a568, 0xc2085044a0, 0x0, 0x0)
        /usr/local/go/src/net/http/server.go:1728 +0x92
github.com/docker/docker/api/server.(*HTTPServer).Serve(0xc208504580, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:113 +0x4d
github.com/docker/docker/api/server.func·006(0xc208504580)
        /go/src/github.com/docker/docker/api/server/server.go:86 +0x163
created by github.com/docker/docker/api/server.(*Server).ServeAPI
        /go/src/github.com/docker/docker/api/server/server.go:90 +0x144

goroutine 14 [select]:
github.com/docker/libnetwork.(*controller).watchLoop(0xc2080a0370)
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/store.go:399 +0x13f
created by github.com/docker/libnetwork.(*controller).startWatch
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/store.go:413 +0xf0

goroutine 39 [select]:
github.com/docker/libnetwork/osl.removeUnusedPaths()
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/osl/namespace_linux.go:73 +0x48b
created by github.com/docker/libnetwork/osl.createBasePath
        /go/src/github.com/docker/docker/vendor/src/github.com/docker/libnetwork/osl/namespace_linux.go:58 +0xb1

Describe the results you expected:
Daemon starts, all containers start.
Provide additional info you think is important:
We haven't restarted the Docker daemon for two weeks. Maybe there are too many containers deployed now? But we had already daemons with 300+ containers running.
Maybe something went wrong during shutdown/the VM was terminated? The VM gets automatically recreated/reprovisioned and the former volume gets reattached. Could there by some issues with a hard kill?
In any case, the crash when relaunching the daemon doesn't look too good/like a real issue.
Do you have short term remedy proposals? Is there a way to force a cleanup? Or some way to start the daemon, but not all the containers (all were started with restart policy = always)?
In short, we see tons of:
* getNetworkFromStore for nid failed while trying to build sandbox for cleanup: network not found
* failed getting network for ep during sandbox delete: network not found
* failed to delete sandbox while trying to cleanup: could not cleanup all the endpoints in container / sandbox

... and then it crashes in:

github.com/docker/libnetwork.epHeap.Less (Docker v1.9) or
github.com/docker/libnetwork.(*sandbox).clearNetworkResources (Docker 1.10)

@vlerenc it seems like the local db (/var/lib/docker/network/files/local-kv.db) is corrupted. Could you pls take a backup of that file (and share it with us ?). once its backed up, pls remove this file and restart the daemon.
We have to identify how and when the file is corrupted.

Yes, it seems so. After removing the file, I could restart the daemon again.
You don't know how much you saved my day. Thank you very much!
What's the consequences of the removed file? Does it impact anything?
The second question is why it happened out of the sudden? The VMs were regularly updated, i.e. the daemon was shutdown every couple of weeks. Usually, with that many containers, the daemon kills most of the containers,right? Most likely, the VM updater even killed the daemon itself. Docker was (for the past couple of months) on the same 1.9 release, so no change there.
Besides the question on the impact of the now deleted network DB file, how can I make the corrupted file available to you?
And thank you again for your prompt help!

What's the consequences of the removed file? Does it impact anything?

If you are using custom bridge networks (other than the default docker0 network), those needs to be recreated manually. But it seems in your case, that is not the case. So, you wont see any functionality issues. Other than that, this file holds the resources to be cleaned up if it was not cleaned up properly when the daemon is brought down ungracefully (which seems to be your case).

The second question is why it happened out of the sudden?

Its a file corruption due to some event (could be timing related). The best way to know that would be to look at the daemon logs (preferably with debugs enabled with -D flag) Thanks to the config reload feature in 1.10, one can enable the daemon debug flags for a running daemon. PTAL : https://github.com/docker/docker/blob/master/docs/reference/commandline/daemon.md#configuration-reloading & https://github.com/docker/docker/blob/master/docs/reference/commandline/daemon.md#daemon-configuration-file

You don't know how much you saved my day. Thank you very much!

You don't know how much you are helping us by reporting the issue so that we can resolve it in next release. Thank you very much. OSS FTW !

@mavenugo @vlerenc shall we close this issue, or do you want to keep this opened for tracking? (I think it's already on your radar, but just to be sure)

@vlerenc

how can I make the corrupted file available to you?

Easiest would be to put it in dropbox/box or other file sharing site and share the link here (or) send the link to my email<EMAIL_ADDRESS>

@thaJeztah this is already in the radar yes. but we don't have a solid use-case to reproduce it yet. We can close this but lets dupe to the other open issue appropriately.

@mavenugo I sent you the link to your e-mail address. Thank you for looking into it!

@vlerenc can you pls answer this question as well

Also, can you please confirm if you have created a custom docker network using docker network create and using it in your containers ?

No, we haven't.

@vlerenc thanks for sharing the corrupted local-kv.db. I analyzed it and found that there are/were bunch of containers run in overlay network. Now that you have replaced the local-kv.db, you may not see that. But, I see a bunch of sandboxes attached to an overlay network and a corresponding KV-Store.
All the network d48a6206205146ee2e1ca9ae0ce6f5ea1c6b2b1a64d739f771bccfd0ac5970e1 not found
errors are expected if the daemon doesnt have connectivity to external KVStore you might have once used. The panic is a different story though.
Atleast, it helps answer my question :
Also, can you please confirm if you have created a custom docker network using docker network create and using it in your containers ?
and the answer is yes. Can you please confirm if there is a disconnect ?

@vlerenc can you pls attach the traceback for
github.com/docker/libnetwork.(*sandbox).clearNetworkResources (Docker 1.10) ?
Easiest thing to do is to

stop the daemon.
take a backup of your /var/lib/docker/network/files/local-kv.db.
Replace it with the corrupted one that you sent me
restart the daemon & capture the tracelog.
replace the backed up local-kv.db
restart the daemon.

@vlerenc never mind. found the issue and am fixing it now.
For confirmation, this is not a file corruption issue. But, this is one such scenario of using a global kv-store to try out multi-host networking followed by an unclean daemon shutdown and restarting the daemon with the kv-store down/not configured.
Thanks for reporting and sharing all the requested information.

@mavenugo Glad you found it! As for your question, I am sorry. We are using https://github.com/cloudfoundry-community/cf-containers-broker which is using https://github.com/swipely/docker-api and when checking I didn't see any "special network" code in https://github.com/cloudfoundry-community/cf-containers-broker/blob/master/app/models/docker_manager.rb. So I am actually puzzled by your finding. Anyhow, we have hundreds of users and containers and after deletion of the DB and restart, nobody complained/the existing and now restarted containers run just fine. They all run on their own reached only through the exposed port by the applications that use them.

@vlerenc not related to this issue, but could you send me an e-mail at<EMAIL_ADDRESS>? Wondering if you'd be interested to be added to our "testers" mailinglist


Package of Pulsar using docker-compose

Can you update your latest state on this?

if you "force push" all commit, can you squash fixup commit to easier follow?

CI error:

09:39:33,719 [ERROR] Failed to execute goal com.github.ekryd.sortpom:sortpom-maven-plugin:3.2.1:verify (strict-pom-ordering) on project james-server-distributed-app: The file /home/jenkins/jenkins-agent/workspace/james_ApacheJames_PR-1651/server/apps/distributed-app/pom.xml is not sorted -> [Help 1]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.ekryd.sortpom:sortpom-maven-plugin:3.2.1:verify (strict-pom-ordering) on project james-server-distributed-app: The file /home/jenkins/jenkins-agent/workspace/james_ApacheJames_PR-1651/server/apps/distributed-app/pom.xml is not sorted

Unlucky, the CI worker seems down.

CI
(?) – org.apache.james.CassandraPulsarJamesServerTest
<1s
Error
org/apache/james/backends/pulsar/DockerPulsarExtension
Stacktrace
java.lang.NoClassDefFoundError: org/apache/james/backends/pulsar/DockerPulsarExtension

Missing maven import?

Needs a rebase

Needs an other rebase :)

Next time I would advice you to just squash everything up, as your PR is globally approved and it's just a question of getting a green build. It would be easier to rebase at least if necessary :)

actually looks related to me : https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1651/25/testReport/junit/org.apache.james/CassandraPulsarJamesServerTest/___/

actually looks related to me : https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1651/25/testReport/junit/org.apache.james/CassandraPulsarJamesServerTest/___/

@thanhbv200585 any plan to fix this?

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1651/27/testReport/junit/org.apache.james.blob.objectstorage.aws/S3HealthCheckTest/checkShouldReturnUnhealthyWhenS3IsNotRunning_DockerAwsS3Container_/
related or not?

https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1651/27/testReport/junit/org.apache.james.blob.objectstorage.aws/S3HealthCheckTest/checkShouldReturnUnhealthyWhenS3IsNotRunning_DockerAwsS3Container_/
related or not?

No. Moreover, when I run org.apache.james.blob.objectstorage.aws.S3HealthCheckTest.checkShouldReturnUnhealthyWhenS3IsNotRunning(DockerAwsS3Container) in my local, It still passes


Running script file assume use of boot command

According to commandline documentation it should be possible to have a file called uuu.auto in a directory and run
uuu.exe [directory]. However this leads to trying to run the uuu.auto file with the boot -f command instead of executing it's commands.
C:\work\uuu.exe update
uuu (Universal Update Utility) for nxp imx chips -- libuuu_1.4.165-0-ge10b026

Success 0    Failure 1

1:4      1/ 2 [Cannot find valid IVT header          ] SDP: boot -f "update/uuu.auto"

# First boot up SPL
SDP: boot -f sdp/SPL-mfgtool

You can work around it by assuming you are a built in command. But then you must be in the same directory as the update script.
cd update
..\uuu.exe -b uuu.auto

your update(uuu script file)'s first line must be
uuu_version 1.2.39
version number is minimize uuu version to run your script.


Modified code Largest Sum Contiguous Subarray [C, Java]

Fixes #420
By submitting this pull request I confirm I've read and complied with the below declarations.

[X] I have read the Contribution guidelines and I am confident that my PR reflects them.
[X] I have followed the coding guidelines for this project.
[X] My code follows the skeleton code structure.
[X] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[X] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

@jsroyal: Please reopen if you wish to continue.


Recaptcha V2 suddlenly is not being shown on Firefox

Since 10 AM this morning Google recaptcha v2 is not showing on firefox browser
Same page shows OK on Chrome/Cromium browser
Example: https://www.coinstake.in/

Google's recaptcha demos whow ok, though

Repo is just for PHP client issues. This is about the reCAPTCHA service.


Create timeouts WeakMap for each debounced method

If class have multiple debounced methods, and they will be called at the same time, only last one will be executed. For example:
class A {
  @debounce(100)
  foo() {
    console.log('foo')
  }

  @debounce(100)
  bar() {
    console.log('bar')
  }
}

let a = new A();
a.foo();
a.bar();

will print only:
bar

To fix this issue, each debounced method should have its own timeouts WeakMap.

Thanks!


feature(json-schema-form) Add a replaceable Schema Validator

Add a replaceable Schema Validator that can be shared across the application. To share the schema validator create a new SchemaValidatorFactory and provide that instance instead of the default validator instance.

Still the same issue. I can't see commited by jpkolind


(docs) Update docs for grammar and punctuation

Update docs in 3 places for grammar or punctuation.
Update network.md
now: "One of React Native's goals is to be a playground where we can experiment with different architectures and crazy ideas. Since browsers are not flexible enough, we had no choice but to reimplement the entire stack. In the places that we did not intend to change anything, we tried to be as faithful as possible to the browser APIs. The networking stack is a great example."
Update image.md
now: "Displaying images is a fascinating subject; React Native uses some cool tricks to make it a better experience."
Update Testing.md
Changed title on line 18 from "Integration Tests." to "Integration Tests", the same format as the other titles in Testing.md

I'm sorry we didn't get to it earlier, it doesn't merge cleanly anymore :( Can you rebase and we'll get this in!

Sure! Fixing git things, making a new pull request.


[Ubuntu] pin az-cli to v2.52.0

Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run ubuntu2004,ubuntu2204

/azp run ubuntu2004,ubuntu2204


Improve safe chunk validation

This PR fix the error reported on #9557,  it was an issue with the way that I tried to detect if the region was covering the last chunk

[#5511, #9072, #7812, #9557]
[test_zarr_safe_chunk_region ] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[x] New functions/methods are listed in api.rst

Thank you for the very fast fix @josephnowak !

Thanks Joseph! I've confirmed that this has fixd the Xarray-Beam issue.


respect more given mailData

1. Why is this change necessary?
When using the MailService of MailTemplate in plugin, it'll be great, if there is a possibility to specify some more mailData with parameter.
2. What does this change do, exactly?
This PR introduced using recipientsCc, recipientsBcc, replyTo, returnPath in given parameters.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello @tinect ,
we're screening for stale/old pull requests.
Sorry that we took so long to respond.
Could you rebase your branch onto 6.2 or master? We'll process this PR soon.
Best regards, Patrick

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 7 committers have signed the CLA.:white_check_mark: jochenmanz:white_check_mark: tinect:x: trandangtri:x: mitelg:x: tobiasberge:x: pweyck:x: OliverSkroblinYou have signed the CLA already but the status is still pending? Let us recheck it.

Hey @pweyck
ready :-)

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9621
Please use this issue to track the state of your pull request.

Thanks again @tinect :)


UserAgent

Add Toolkit UserAgent

I changed the toolkit user agent to "Kenna Toolkit" so tracking it should be spot on.  If someone with more ruby skills than me could figure out how to pass the task variable to, that would be the end goal of this PR.  For now, it will help with data collection and tracking.


Decompress compressed responses before emitting fetchcomplete

By default, responses that are gzipped or deflated are now
decompressed before they're emitted in the fetchcomplete event.
Previously they have only been decompressed before resource
discovery (and they are still always), but now the
crawler.decompressResponses setting (true by default) determines
whether the fetchcomplete response should be decompressed as well.
In theory this could boost performance, since we're doing the same
amount of computation as previously, but with less network
traffic.
Fixes #260

Have you had a chance to have a look at the diff here, @cgiffard? :)

Don't sweat it too much :) I might work on some other issues tomorrow, but once we've settled on this one, we can cut a 0.7.0 release, would be cool if we could do that this weekend!

Inclined to merge this today and release 0.7.0. Objections, @cgiffard?

@fredrikekelund Sorry for the delay. Left a couple of comments. Let's address them and then I think we're good to go!

Was there anything here that needed to be addressed in the code before merging, or mostly just things related to how we deal with decompression of responses in future versions?

Hi,
Any news on the 0.7 release ?

@robinparisi It's released! :)


xlisp #26: setup xlisp-test and cl-travis

setup bin/xlisp-test
setup tests with xlisp-test feature
setup .travis.yml
extensive testing
move robot print-object for specs
allow problem builds failures on non-SBCL implementations for the time being

What is meant by "allow problem builds for the time being"?

It should probably read "allow failures on non-SBCL implementations for the time being".

Would it be possible to merge this in with only those implementations that work fine and open issues to fix those that don't? And have the build fail if anything is wrong?

You mean remove the other implementations from ".travis.yml" entirely? We'd just add them back, and have to fix whatever the issues are, under the issue of "support clisp" or whatever. If you would prefer this procedurally, that's fine by me, I just want to clarify my next action and hear your rationale.

I'm probably misunderstanding something.
If the build will not fail for known broken implementations (e.g. clisp) - will it fail if SBCL has a problem?
My rational is that if we are going to include an automated build with a test suite I want it to fail when there is a problem with known good environments. I would not like a build that is always failing because of known bad implementations or always passes even if there are problems.

Ah. Check out the build page: https://travis-ci.org/exercism/xlisp
There's two SBCL environments (one's 32 bit) and the tests all pass on them.
You can see an example of failing tests on SBCL back in the build history here. I spent some time trying to build with deliberately introduced bugs to cause the tests to fail, which they do. Here's the first build where they fail as expected:
https://travis-ci.org/wobh/xlisp/jobs/64213987
Here's the build after I removed the bugs:
https://travis-ci.org/wobh/xlisp/builds/64214537
You can see that SBCL passes while all others fail. Only thing I've done since is catch up with the recently added exercises and added the failing implementations to the "allowed failures" list. Once merged we can file the issues to fix Clisp, CCL and the others.

Ah! OK, thanks for clearing up my confusion. I've got no problems with this now.

(As an aside: I just scanned the CCL & ECL failures (looks the same) and for some reason 'bottles' is capitalized?! Looking at the example code I don't see anything that might prompt an implementation to do that... weird.)

I've been observing a protocol where I don't merge my own pull requests. That seems slightly silly now that I type it out, but if you're ready to move on with it, either merge or let me know and I'll do it. Maybe it would be a good idea to work out some kind of signal.

That seems like a fine protocol.
Pull Request signal? http://publicsafety.tufts.edu/police/files/pubsafe_up__16.jpg
(I was hoping for something more entertaining to appear from a google image search of 'pull request signal' but sigh no such luck).

Thanks! I'll file some new issues for getting the other implementations working. We should be able to check off a number of items on your checklist. Exciting times!

Thanks. See my notes above about what I've debugged of CCL & ECL problems - I think if the example code did not rely upon ~(~) it would be portable to those two implementations (and their bugs). The CLisp problem appeared easy to fix as well - at worst we remove the offending, but unused, method.


API-M 4.3.0 Migration Effort

This issue is created to track the tasks for APIM 4.3.0 migration.

[ ] Creating migration data population script.
[ ] Manual Migration Testing with the populated data.
[ ] Creating initial DB script for migration based on the new changes to the product from features and dependency upgrades.
[ ] Fixing the code to support the migration based on the new changes introduced to the product.
[ ] Creating automation for migration testing.
[ ] Fixing issues encountered during migration testing.
[ ] Creating migration documentation.

Test the 4.0.0 -> 4.3.0 migration for https://github.com/wso2/api-manager/issues/1970 while doing the migration testings as well


fp16 support for NCCL ops

fp16 dispatch for NCCL

This looks great to me, cc'ing @pietern for a final look and approval.

Looks great to me as well.
Minor nit: AllInputsAreFloat is a perfect use case for template AllInputsAre ;)
Good to merge as is though.

@pietern Good point :) give me a couple of minutes to fix it

@pietern Done.

Awesome, thanks @slayton58!


Add an option to prevent copying an empty selection

Like the title says, when nothing is selected, copying shouldn't copy a blank character.

@alexandrudima @ivancuric
As of now, cmd+c without any selection, copies the entire line. Sublime also does the same.
Are we suggesting to change this behavior as part of this issue? I really like the current functionality.
Or are we suggesting one more option/flag which user can enable to have the new functionality?

@ramamurthynagaraj Yes, it would be behind an option

Can we have the option for this behavior or disable it?   I don't like the auto copy of a blank line and would like to disable that feature.    I agree it can be annoying especially in the type of coding I do (debugging).

Was a setting added for this?

@soljohnston777 it is editor.emptySelectionClipboard

"editor.emptySelectionClipboard": false disables the line copying entirely. Is there a way to have line copying enabled, while simultaneously ignoring the empty lines?

This doesn't disable the copying within my VS Code at all - anyone else had any luck? :)


[Snyk] Security upgrade org.apache.maven:maven-core from 3.8.6 to 3.9.7

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):

pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue
Score
Upgrade

Directory Traversal SNYK-JAVA-COMMONSIO-1277109
  535
org.apache.maven:maven-core:  3.8.6 -> 3.9.7  No Path Found Mature

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Directory Traversal

This isn't a dependency change we intend to make in 3.20.1, would likely change the support matrix


Webview autofill for payment methods

Background:
Electron version: 9.2
Mac OS 10.13
If a Chrome user is logged into Google and autofill for passwords, payment methods and addresses are turned on,  when Electron triggers a webview, I would like to have autofill populate these fields in the Electron webview.
I've looked over the docs and prior issues but nothing seems to be coming up.   For in-app purchases, this is a vital feature since it reduces friction for a sale.

Hey @OrganicChem, this repository is dedicated to the electronjs.org website. If you have a feature request for the core Electron framework, please open an issue in the electron/electron issue tracker!


Pasting large text displays text behind loading in search

Details
Currently, when a very long text is placed in the search field the spinner is noticeable above the text. Tests were performed and this only occurs in web browsers, not in native applications. For this reason, this change should only apply to those platforms.
The origin of the bug is that when we use Flexbox to align an input with any other object, if the input exceeds the maximum size it is not updated until a second iteration with the user even though with the devtool the container is updated, this behavior was verified by disabling JS and testing only the CSS.
Below is a video with more details:

Please check when we remove the spinner the input continues on the original size even flexbox should do the work of keeping the spinner separated.
Please check when we are writing (and maintaining any key pressed forcing the spinner to be visible) flexbox do the job, this was tested with javascript disabled and enabled:

https://github.com/Expensify/App/assets/5216036/0767e6c0-6062-4bec-9949-7aeea3b0caa3
The solution was oriented to maintain the ActivityIndicator as his natural use using the parameter animate to show/hide the spinner, using this way flexbox works as intended for browsers.
Fixed Issues
$  https://github.com/Expensify/App/issues/30180
PROPOSAL: https://github.com/Expensify/App/issues/30180#issuecomment-1775410569
Tests

Open the app (in Chrome, safari, desktop) and login
Click on the search button at the top
Paste a long text in the search
Verify the loading is over the text

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps
Please verify the next in all platforms:

Open the app and login
Click on the search button at the top
Paste a long text in the search
Verify the loading is over the text

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/5216036/6f5a9739-4f47-4438-9834-b08c4bd59f19

Android: mWeb Chrome
https://github.com/Expensify/App/assets/5216036/6223adcf-e60b-4303-b768-bebeee692453

iOS: Native
https://github.com/Expensify/App/assets/5216036/851fe72f-a39f-4a23-820f-2f66ac433cec

iOS: mWeb Safari
https://github.com/Expensify/App/assets/5216036/14e8b25d-36ef-424d-bc2f-ccbbc9446b52

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/5216036/7d92323a-6d20-4dfd-97ba-c3acbe50e50f

MacOS: Desktop
https://github.com/Expensify/App/assets/5216036/a28b2f94-8c04-4150-9bb4-3b7d26d94380

@cristipaval Hey can you please update videos (just add space between video and header here)

Also can you please checklist and sign CLA agreement

Hello, the videos were updated, thank you.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

recheck

I have read the CLA Document and I hereby sign the CLA

recheck

@samilabud As i mentioned earlier - when loader is not shown - we should occupy the whole available space of the input. You can see on the image below - that we have a free empty space in the last example input

Hey @narefyev91 regarding the space left in browsers I made an explanation above, this is something that you have to test in your local to believe 😅, but if you need more details I can share anything you want.

Reviewer Checklist

[ ]  I have verified the author checklist is complete (all boxes are checked off).

[ ]  I verified the correct issue is linked in the ### Fixed Issues section above

[ ]  I verified testing steps are clear and they cover the changes made in this PR

[ ]  I verified the steps for local testing are in the Tests section
[ ]  I verified the steps for Staging and/or Production testing are in the QA steps section
[ ]  I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ]  I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ]  I checked that screenshots or videos are included for tests on all platforms

[ ]  I included screenshots or videos for tests on all platforms

[ ]  I verified tests pass on all platforms & I tested again on:

[ ]  Android: Native
[ ]  Android: mWeb Chrome
[ ]  iOS: Native
[ ]  iOS: mWeb Safari
[ ]  MacOS: Chrome / Safari
[ ]  MacOS: Desktop

[ ]  If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack

[ ]  I verified proper code patterns were followed (see Reviewing the code)

[ ]  I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ]  I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ]  I verified that comments were added to code that is not self explanatory
[ ]  I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ]  I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ]  I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ]  I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ]  I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ]  I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ]  If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[ ]  I verified that this PR follows the guidelines as stated in the Review Guidelines

[ ]  I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)

[ ]  I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[ ]  I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[ ]  If a new component is created I verified that:

[ ]  A similar component doesn't exist in the codebase
[ ]  All props are defined accurately and each prop has a /** comment above it */
[ ]  The file is named correctly
[ ]  The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ]  The only data being stored in the state is data necessary for rendering and nothing else
[ ]  For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ]  Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ]  All JSX used for rendering exists in the render method
[ ]  The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ]  If any new file was added I verified that:

[ ]  The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ]  If a new CSS style is added I verified that:

[ ]  A similar style doesn't already exist
[ ]  The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ]  If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

[ ]  If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[ ]  If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[ ]  If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

[ ]  If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.

[ ]  If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

[ ]  I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@samilabud please remove this comment

recheck

recheck

Hm, maybe let's raise it again to see if we could get more opinions. I like the idea of We can add ‘X’ button instead of loading indicator (when user is not searching)- that would simply clear the field, correct?

Hi @robertjchen, do you mean something like this?:
https://github.com/Expensify/App/assets/5216036/dda7ae11-667b-48cd-8b7c-7722e5f029cc

Yep, that would make sense to me! Though in that case, I would like to see what @Expensify/design thinks about the ❌ button 👍

Does this issue only happen when text is pasted into a search bar?
I'm not opposed to an x icon to clear the field, but if we did that I think we'd need to do it everywhere there's a search field, and I'm not totally sure what the implications of that update would be. If this issue only happens when pasting a long string in a search field, I'm not sure how big of an issue I actually think it is.
If we do want to move forward with the x icon, I'd like to update it to be one of our actual icons from our icon library. (I can help with making mockups for what that would look like.) cc @Expensify/design

The issue happen when the text reach the right side, when pasting or writing (when writing pause and resume).

My 5 cents here - not sure why we really need to have loading indicator inside search input. In most cases such construction should be used in autocomplete inputs - when you will have some options pop-ups during typing - in that case yup - nice to have loading indicator and close button (clean up) inside input to indicate user that options are loading.
In our case we are searching list under the input - and easier and correct from architectural stand point to move loading under the input

@shawnborton @dubielzyk-expensify Curious for your thoughts here. This feels like a decision that has farther-reaching consequences than just this specific situation, so it'd be nice to align on what we think is best.
I'm not against either option really—I just want us to pick one pattern and stick with it.
The options as I see it are:

Do nothing (always an option)
Move the loading spinner below the input where the results show up (I believe this can get weird with cached/offline search results and results that we're fetching—I think that was the whole reason we put it in the input to begin with)
Keep the loading spinner in the input and add a "clear" icon to the input that will quickly clear the field (nothing wrong with this pattern, but if we implement it here I think we need to implement it everywhere we have a search)

Hmm I am not super up to speed on this issue, but it feels weird that we're optimizing for such long text strings in this particular input. I feel like it's an edge case and we should just take the simplest approach possible. That being said, I feel like we probably don't need an "x" or anything fancy like that.

@shawnborton yeah I'm with you. Doing some more local investigating, I kinda feel like this works how I would expect it to and I'm not sure I really even see an issue? So many more characters fit in the input than a regular name, email address, or phone number that doing nothing here seems fine to me.
Typing:
https://github.com/Expensify/App/assets/7516624/b05e746f-d5ba-48e3-b47c-c772548a5535
Pasting:
https://github.com/Expensify/App/assets/7516624/795d1f2b-794b-433b-88ea-7966cb167109

Totally agree with you. That being said, I would vote to just close this PR and close the issue out, as I don't see this being a bug either.

Thanks for the discussion and decision here! 🙇


touch: cannot touch '/opt/osbs/hub-init': Permission denied

$ docker-compose ps
             Name                           Command               State     Ports
-----------------------------------------------------------------------------------
osbsboxupstream_koji-builder_1   /usr/local/bin/entrypoint. ...   Up
osbsboxupstream_koji-client_1    /usr/local/bin/entrypoint. ...   Up
osbsboxupstream_koji-db_1        docker-entrypoint.sh postgres    Up       5432/tcp
osbsboxupstream_koji-hub_1       /usr/local/bin/entrypoint. ...   Exit 1
osbsboxupstream_registry_1       /entrypoint.sh /etc/docker ...   Exit 1
osbsboxupstream_shared-data_1    /usr/local/bin/entrypoint. ...   Exit 1

$ docker-compose logs koji-hub
Attaching to osbsboxupstream_koji-hub_1
koji-hub_1      | + '[' '!' -e /opt/osbs/hub-init ']'
koji-hub_1      | + . /usr/local/bin/setup.sh
koji-hub_1      | ++ set -xeuo pipefail
koji-hub_1      | ++ mkdir -p /root/.koji
koji-hub_1      | ++ ln -fs /opt/koji-clients/kojiadmin/config /root/.koji/config
koji-hub_1      | + touch /opt/osbs/hub-init
koji-hub_1      | touch: cannot touch '/opt/osbs/hub-init': Permission denied

@vrutkovs have you seen this?

No, it looks like a volume was not created or smth


Fix errors that occur crossing the queue boundary that cause uncaught exceptions

cc: @Raynos @jwolski @sh1mmer @kriskowal

This seems consistent with the intended semantics of an ephemeral socket. :+1:

lgtm.