Detected blocking call to open inside the event loop by custom integration 'irm_kmi'

Describe the bug
Warning s with the new HA beta
Checklist

[ ] I included debug logs or at least a screenshot of the IRM KMI official app
[ ] If I use a custom card, I checked if the stock Lovelace weather card is working

To Reproduce
Steps to reproduce the behavior:

Update HA to 2024.6 beta

Expected behavior
No warnings
Screenshots
If applicable, add screenshots to help explain your problem.
Version

Home Assistant: [e.g. 2024.6.0b]
IRM KMI integration [e.g. 0.2.14]

Additional context
Detected blocking call to open inside the event loop by custom integration 'irm_kmi' at custom_components/irm_kmi/rain_graph.py, line 96: self._dwg.embed_font(name="Roboto Medium", filename=font_file) (offender: /usr/local/lib/python3.12/site-packages/svgwrite/container.py, line 150: data = open(filename, 'rb').read()), please create a bug report at https://github.com/jdejaegh/irm-kmi-ha/issues
Detected blocking call to open inside the event loop by custom integration 'irm_kmi' at custom_components/irm_kmi/rain_graph.py, line 304: with open(bg_image_path, 'rb') as f: (offender: /config/custom_components/irm_kmi/rain_graph.py, line 304: with open(bg_image_path, 'rb') as f:), please create a bug report at https://github.com/jdejaegh/irm-kmi-ha/issues

This has been fixed in version 0.2.15
However, some async variants of the blocking calls are only available in Home Assistant 2024.6 so Home Assistant needs to be at least 2024.6 (the beta versions work as well).


[Question] Some questions in running DLRM sample

I am trying the DLRM sample in the main branch, where I face a few problems.

There is no docker "nvcr.io/nvidia/merlin/merlin-training:22.01" as listed in the README.md. To get around it, I use the lasted tag, i.e., 21.12 (https://catalog.ngc.nvidia.com/orgs/nvidia/teams/merlin/containers/merlin-training/tags) instead.
When running command dlrm_raw ./ ./   for kaggle dataset, it raises a Segmentation fault. demesg shows the message: dlrm_raw[28741]: segfault at 8 ip 00007f8efc69daaf sp 00007fff4b869960 error 4 in libcudf.so[7f8efbc6f000+1ac0000]

The GPU info is attached

Update:
It can work if using synthetic data by running python3 ../tools/data_generator/dlrm_raw_generate_train.py.

Thank you for the question! nvcr.io/nvidia/merlin/merlin-training:22.01 will be available this week on NGC.
dlrm_raw is hardcoded for Criteo 1TB dataset (https://labs.criteo.com/2013/12/download-terabyte-click-logs/). But it's a good suggestion to add kaggle too for the people who cannot download such large dataset.

Hi @HydraZeng , we can reproduce this error with nvcr.io/nvidia/merlin/merlin-training:21.12.
But with nvcr.io/nvidia/merlin/merlin-training:22.01, there is no such error any more. And the log is:
[HUGECTR][19:19:37][INFO][RANK0]: Processing Kaggle datasets
[HUGECTR][19:19:37][INFO][RANK0]: input_dir: ./
[HUGECTR][19:19:37][INFO][RANK0]: output_dir: ./
[HUGECTR][19:19:44][INFO][RANK0]: .//train.txt's total rows number = 45840617
[HUGECTR][19:19:44][INFO][RANK0]: Slot size array in .//train.txt, missing value mapped to unused key:
1459, 583, 6373320, 1977439, 305, 24, 12513, 633, 3, 92719, 5681, 5666265, 3193, 27, 14986, 4209368, 10, 5652, 2173, 4, 5058596, 18, 15, 282062, 105, 141594,
[HUGECTR][19:19:44][INFO][RANK0]: Time used to build map: 6308 milliseconds.
[HUGECTR][19:19:44][INFO][RANK0]: Total bytes read:<PHONE_NUMBER>5 Effective Read B/W: 1.645787 GB/s.
[HUGECTR][19:19:53][INFO][RANK0]: Porcessed file: .//train.txt for /train_data.bin
[HUGECTR][19:19:53][INFO][RANK0]: Size of train_data.bin:<PHONE_NUMBER> Bytes.
[HUGECTR][19:19:58][INFO][RANK0]: Size of val_data.bin: 733449920 Bytes.
[HUGECTR][19:20:03][INFO][RANK0]: Size of test_data.bin: 733449920 Bytes.
[HUGECTR][19:20:03][INFO][RANK0]: Processed file: .//train.txt for val_data.bin and test_data.bin
[HUGECTR][19:20:03][INFO][RANK0]: Time to process binaries: 18508 milliseconds.
[HUGECTR][19:20:03][INFO][RANK0]: Convert Bytes reading:<PHONE_NUMBER>5, Effective reading B/W: 1.682779 GB/s.
[HUGECTR][19:20:03][INFO][RANK0]: Convert Bytes writing:<PHONE_NUMBER>, Effective reading B/W: 0.369072 GB/s.
[HUGECTR][19:20:03][INFO][RANK0]: Convert Bytes total:<PHONE_NUMBER>5, Effective reading B/W: 2.051851 GB/s.
[HUGECTR][19:20:03][INFO][RANK0]: Application process B/W: 0.417805 GB/s.
[HUGECTR][19:20:03][INFO][RANK0]: Done.

We recommend you use this docker image, since it is available now.

Hi @HydraZeng , per @Jianbing-D 's testing kaggle dataset is applicable in the release after 22.01. Would you like to have a try?

Hi @HydraZeng , per @Jianbing-D 's testing kaggle dataset is applicable in the release after 22.01. Would you like to have a try?

Thanks for your information. I will try this image!

Hi @HydraZeng , would you like to confirm if the issue is fixed? Thanks!

Yes, sure. Thanks again for your kindly help.

Close as fixed


Encode nil query result

What was changed

If query handler returns nil it should be encoded as regular value. nil Payloads doesn't pass server validation.
Why?

Fix bug. Other SDKs already doing the right thing.

@alexshtin - thanks! I noticed you also changed the name of a couple of pretty important files here. Was that by intention? While the names may make sense, I am not sure there is any real value in changing them here.

Yeah, the file move doesn't seem related.


Remove version: CrystalDewWorld.CrystalDiskInfo.ShizukuEdition version 9.0.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://osdn.net/frs/redir.php?m=ipconnect&f=crystaldiskinfo%2F78831%2FCrystalDiskInfo9_0_1Shizuku.exe
Response Error: The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel.
(Automated message - build 923)


Firefox input styling issues

Search input elements (v2 docs) on Firefox have some styling issues.

Firefox placeholder color is incorrect (missing style?)
Too much vertical padding causes text being cut off in Firefox

This is still an issue on the version that is currently live, yes. See issue #880 for clarification.

fixed in a6cfe3e89e309f5b230e00bb361ebfc890fc57d5


ProcessPartner Messages cannot be larger than 65536 bytes.

Expected behavior
Each partner environment be processed without an error.
Actual behavior
Under certain circumstances the following exception can be thrown
Exception while executing function: ProcessPartner Messages cannot be larger than 65536 bytes.
Steps to reproduce the problem
This is a difficult issue to reproduce because it requires certain circumstances.

It is suspected that the following code from the ProcessPartnerAsync function is causing this exception
await storage.WriteToQueueAsync(
    OperationConstants.CustomersQueueName,
    new ProcessCustomerDetail(
        auditRecords.Where(
            r => r.CustomerId?.Equals(customer.Id, StringComparison.InvariantCultureIgnoreCase) ?? false))
    {
        AppEndpoint = environment.AppEndpoint,
        Customer = customer,
        PartnerCenterEndpoint = environment.PartnerCenterEndpoint,
        ProcessAzureUsage = environment.ProcessAzureUsage
    }).ConfigureAwait(false);

I will modify this logic to avoid including such a large object on the queue.

Modifying the way audit records are being handled has addressed this issue.


Refactor assertions

Codecov Report

Merging #170 into master will increase coverage by 0.34%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a4f0d...e0b1d69. Read the comment docs.


Update BERT tokenizer integration to reflect API changes in Transformers library

The latest version of the Transformers library moved the PreTrainedTokenizerFast class to a new location within the package. This change breaks our integration with that project's tokenizer.
This PR updates the import statement to use the new location of PreTrainedTokenizerFast. I have also modified dev_reqs.txt to specify version 3.0.0 or greater of transformers.
@BryanCutler @xuhdev @ZachEichen you will want to rerun env.sh or manually upgrade your local copy of the transformers Python library after this PR is merged.

merged to master, thanks @frreiss !


Top level iiif:Collection

Thread on the IIIF list suggesting this approach to manifest agggregation. We should do this. I don't know if it's the best solution, but since since someone is finally taking the lead (it's been discussed forever, but nothing has ever really happened) I suppose we should play ball.

@jpstroop Don't we have this already at http://hydra-dev.princeton.edu/collections/manifest ?

Ah, so we do!
Not sure I'm crazy about the route (/collections or /iiif/collections would be better), and the "viewingDirection" and "viewingDirection" shouldn't be there, but looks good otherwise. Want a separate issue, or just recycle this one?

@jpstroop Recycling seems best. My assumption was that route was the most guessable. I think I'd vote for /collections if we changed it, but even that's a little weird without a content type for IIIF manifests.

OK, if we're recycling then I'll keep this open for getting right of viewingHint and viewingDriection from /collections.
My only concern about the route is that we may want /collections to render as HTML, and I hate forcing anyone to rely on conneg. The solutions I see are:

Support conneg AND poor-man's conneg, i.e. /collections or /collections.html get you HTML and /collections.json[ld] gets you JSON. Practically speaking, all of the IIIFers will wind up using the poor man's .json URI (slamming the door on YAML-LD forever! :wink:), and our implementation contradicts the pattern recommended in the specs.
Put /iiif somewhere in the route and keep the URI cool.

Unless there's something I'm missing, I think I prefer #2.

@jpstroop /iiif/collections seems fine then, so long as we don't need to switch the manifest URLs to /iiif/manifests/123 or something.

I think that's fine

Closed by #432


Examples need to be kept in sync with the code.

This is an ideal feature for pyshgp_cli.py since it is more about the project of pyshgp than the library of pyshgp.
I don't think this is a good think to add to CI because it will take hours for a single check to run. I am not even sure if the free tier of Circle CI would support this. Happy to be convinced otherwise.

#127 Added a script in deploy/ that will run all examples. This makes it easy enough to confirm that no API changes have broken the examples.


Two long options can result in "specified ambiguously" error (Javascript)

When I specify --woff given the following two option definitions, I get an error saying that --woff was specified ambiguously.
--woff2=      Processing mode for woff2 fonts: data, link or omit [default: omit]
--woff=       Processing mode for woff fonts: data, link or omit [default: data]
Is this by design?

Oh, didn't notice this is JS. This issue should be moved to docopt/docopt.coffee repo. /cc @sonwell

Oh, didn't notice this is JS. This issue should be moved to docopt/docopt.coffee repo. /cc @sonwell


Change the software interrupt to syscall instruction

Summary
Currently xtensa arch porting is using software interrupt (through write intset register) to trigger context switch.
But this put a strict requirement to the chip configuration:
there must be a software interrupt, it's priority is less or equal to XCHAL_EXCM_LEVEL;
and it's priority must be greater than XCHAL_SYSCALL_LEVEL (the XCHAL_SYSCALL_LEVEL is not a cadence macro, it just means normal hardware interrupt priority).
Since the xtensa arch is very flexible, the chip designer might have not noticed above requirement in chip design phase.
And if the chip has been taped out without this requirement, there is no posibility to port nuttx to the chip.
This PR will try to change the software interrupt to syscall instruction.
The syscall instruction is a synchronous exception, and is not locked by PS.intlevel, which means it's priority is high enough.
Impact
This PR will impact context switch, interrupt handling, and protect build.
Testing
test summary
12/18: rebased to nuttx  d15a20eac85, apps   fa22f80ee.
This time all below configs ostest passed.
esp32s3-devkit:nsh ostest
esp32s3-devkit:tickless ostest
esp32s3-devkit:knsh ostest
esp32s3-devkit:smp ostest
12/02: rebased to nuttx 140b3080c5f, apps 296d5d15a.
This time only smp failed at "nested signal handler test". Other config passed.
esp32s3-devkit:nsh       ostest pass
esp32s3-devkit:tickless  ostest pass
esp32s3-devkit:knsh      ostest pass
esp32s3-devkit:smp ostest failed at "nested signal handler test"
11/18: rebased, better than last time.
rebase to version: nuttx master 637a0f5af23, apps master fee82bd3d,
plus this PR.
esp32s3-devkit:nsh       ostest pass
esp32s3-devkit:tickless  ostest pass
esp32s3-devkit:smp       ostest pass with percentage ~20%
The possibility of passing the test is higher if power off then on through plug and unplug usb.
esp32s3-devkit:knsh      ostest pass with percentage ~40%
11/13:
With https://github.com/apache/nuttx/pull/14760  esp32s3-devkit:smp ostest is more stable, but still not 100% pass.
11/05: has regression problem
base version: nuttx master 56f292fcfa9, apps  master 400a8e326,
plus this PR.
esp32s3-devkit:nsh (+CONFIG_TESTING_OSTEST)
ostest pass
esp32s3-devkit:tickless
ostest pass
esp32s3-devkit:smp
ostest failed (only "nested signal handler test" failed)
esp32s3-devkit:knsh
ostest failed (fail at random position with message "xtensa_panic: Unhandled Exception 2", 2 means double exception)
Since there is no esp32 and esp32s2 boards in hand (have placed order), so these boards have not been tested.

@tmedicci could you help review this pr?

I'm busy during these days, so I'll take a while to fully review it. For now, I'll run our internal pipeline and report its results.
But I have question: IINM, syscall was being used for context switch and it was reverted to the software interrupt. I don't recall the context of the discussion, but it'd be good to try to retrieve it in this PR.
(@Ouss4 and @gustavonihei may have some thoughts about it. If they have spare time, I'd like to hear about...).

Hi @xiaoxiang781216 , can we mark it as a draft until we fully review this PR to avoid it being merged by mistake?

For now, I'll run our internal pipeline and report its results.

The CI shows the same failed results regarding ostest for Xtensa devices.

For now, I'll run our internal pipeline and report its results.

The CI shows the same failed results regarding ostest for Xtensa devices.

Hi @chirping78 , were you able to verify why ostest fails?

Hi @chirping78 , were you able to verify why ostest fails?

@tmedicci
I'm still investigating these failing cases, and have not root caused them.
Any help or patch is welcome.

With https://github.com/apache/nuttx/pull/14760  esp32s3-devkit:smp ostest is more stable, but still not 100% pass.

With #14760 esp32s3-devkit:smp ostest is more stable, but still not 100% pass.

There were some changes recently that affect ostest behavior, can you please rebase your code?

12/02: rebased to nuttx 140b3080c5f, apps 296d5d15a.
This time only smp failed at "nested signal handler test". Other config passed.
esp32s3-devkit:nsh       ostest pass
esp32s3-devkit:tickless  ostest pass
esp32s3-devkit:knsh      ostest pass
esp32s3-devkit:smp ostest failed at "nested signal handler test"

esp32s3-devkit:smp ostest failed at "nested signal handler test"

Isn't it related to https://github.com/apache/nuttx/issues/15059?

esp32s3-devkit:smp ostest failed at "nested signal handler test"

Isn't it related to #15059?

I have downgraded my local toolchain, and then rebased to 12/15 (nuttx d15a20eac85, apps  fa22f80ee).
Now met a new problem in up_exit / xtensa_context_restore, which means some changes between nuttx(140b3080c5, d15a20eac85) is not compatiable with this PR.
This will take some time to investigate why?

12/18: rebased to nuttx  d15a20eac85, apps   fa22f80ee.
This time all below configs ostest passed.
esp32s3-devkit:nsh ostest pass
esp32s3-devkit:tickless ostest pass
esp32s3-devkit:knsh ostest pass
esp32s3-devkit:smp ostest pass

@tmedicci please review and verify the change work with your internal test.

@tmedicci please review and verify the change work with your internal test.

Triggering the internal CI. I'll share the results soon. Please don't merge it yet.

@tmedicci please review and verify the change work with your internal test.

Triggering the internal CI. I'll share the results soon. Please don't merge it yet.

It isn't building any of the ESP32-S2's defconfig. I tried locally and found the same issue:
make -j distclean && ./tools/configure.sh esp32s2-saola-1:ostest && make olddefconfig && make flash ESPTOOL_PORT=/dev/ttyUSB0 EXTRAFLAGS="-Wno-cpp -Werror" ESPTOOL_BINDIR=./ -s -j$(nproc) &&  xtensa-esp32s2-elf-objdump -D nuttx  > objdump.flat && minicom -D /dev/ttyUSB0
  Copy files
  Select CONFIG_HOST_LINUX=y
  Refreshing...
CP: arch/dummy/Kconfig to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/dummy/dummy_kconfig
CP: boards/dummy/Kconfig to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/dummy/dummy_kconfig
LN: platform/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/platform/dummy
LN: include/arch to arch/xtensa/include
LN: include/arch/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/include
LN: drivers/platform to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/drivers/dummy
LN: include/arch/chip to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/include/esp32s2
LN: arch/xtensa/src/chip to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/esp32s2
LN: arch/xtensa/src/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common
LN: arch/xtensa/src/board/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/src
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/audioutils
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/benchmarks
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/boot
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/canutils
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/crypto
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/database
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/examples/mcuboot
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/examples/module
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/examples/sotest
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/examples
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/esp-nuttx-apps/examples
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/esp-nuttx-apps/testing
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/esp-nuttx-apps
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/fsutils
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/games
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/graphics
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/industry
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/inertial
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/interpreters/luamodules
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/interpreters
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/logging
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/lte
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/math
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/mlearning
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/netutils
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/sdr
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/system
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/testing
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/videoutils
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/wireless/bluetooth
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/wireless/ieee802154
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/wireless
mkkconfig in /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps
Loaded configuration '.config'
Configuration saved to '.config'
CP: arch/dummy/Kconfig to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/dummy/dummy_kconfig
CP: boards/dummy/Kconfig to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/dummy/dummy_kconfig
LN: platform/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/platform/dummy
LN: include/arch to arch/xtensa/include
LN: include/arch/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/include
LN: drivers/platform to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/drivers/dummy
LN: include/arch/chip to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/include/esp32s2
LN: arch/xtensa/src/chip to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/esp32s2
LN: arch/xtensa/src/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common
LN: arch/xtensa/src/board/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/src
Loaded configuration '.config'
No change to configuration in '.config'
Create version.h
Cloning Espressif HAL for 3rd Party Platforms
Clone: chip/esp-hal-3rdparty LN: platform/board to /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/apps/platform/dummy
Register: nsh
Register: sh
Register: ostest
Espressif HAL for 3rd Party Platforms: e3899a2324c8e326db20f99f208e890fdd7a5b92
CPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common/scripts/esp32s2_aliases.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boardCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common/scripts/esp32s2_peripherals.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/bCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common/scripts/flat_memory.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/boards/xtensa/esp32s2/esp32s2-saola-1/../common/scripts/simple_boot_sections.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/CPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.api.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_betaCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nutCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.libgcc.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_bCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.newlib-data.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.newlib-funcs.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxsCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s2/ld/esp32s2.rom.spiflash.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspaceCPP:  /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_beta/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/soc/esp32s2/ld/esp32s2.peripherals.ld-> /home/tiago/Documents/work/espressif/projects/nuttx/nuttxspace_betaLD: nuttx
CP: nuttx.hex
MKIMAGE: ESP32-S2 binary
esptool.py v4.8.dev4
Creating esp32s2 image...
Image has only RAM segments visible. ROM segments are hidden and SHA256 digest is not appended.
Merged 1 ELF section
Successfully created esp32s2 image.
Generated: nuttx.bin
esptool.py v4.8.dev4
Serial port /dev/ttyUSB0
Connecting......
Chip is ESP32-S2 (revision v0.0)
Features: WiFi, No Embedded Flash, No Embedded PSRAM, ADC and temperature sensor calibration in BLK2 of efuse V2
Crystal is 40MHz
MAC: 60:55:f9:ed:a2:92
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 921600
Changed.
Configuring flash size...
Auto-detected Flash size: 4MB
Flash will be erased from 0x00001000 to 0x00038fff...
Compressed 229064 bytes to 99972...
Wrote 229064 bytes (99972 compressed) at 0x00001000 in 3.4 seconds (effective 541.7 kbit/s)...
Hash of data verified.

Leaving...
Hard resetting via RTS pin...

Welcome to minicom 2.9

OPTIONS: I18n
Compiled on May  3 2024, 16:19:02.

As been defined by Xtensa Architecture, the level1 interrupt is different from other interrupt levels:

the level1 interrupt has no it's own EPS_X register to save PS.
There are only EPS2..7 for interrupt above level1. This means the REG_PS saved in the task stack is not PS value before interrupt.

the instruction to return from level1 interrupt is RFE, while RFI for other interrupt levels.
RFE sets PS.EXCM back to 0, while RFI restores the PS from EPS_X.

Taking into consideration the above two facts, the level1 interrupt needs special handling:

after _xtensa_context_save, EXCM bit needs be cleard from REG_PS, since we don't know the interruptee task will be resumed by RFE or RFI
before _xtensa_context_restore, EXCM bit needs be set to REG_PS, or there will be risky to interrupt nested in exception_exit/ps_excp_write

Actually I found these points during the evolution of this PR. You can see from the test history there are many asserts and panics in the history version.
You can try to remove these two snippets, then you will meet the errors that  I have met.

Will try locally on ESP32-S2 to see whether can reproduce the issue @tmedicci
Update: have found the reason. ESP32-S2 is not like ESP32 and ESP32-S3, the former has XCHAL_HAVE_LOOPS=0 in it's chip configuration, while the later have XCHAL_HAVE_LOOPS=1.
This difference triggered an error in a code path that have not been tested. Will fix it and update the patch.

Thanks, I'll trigger the CI again...

I removed the clearing of the PS.EXCM in the stack and the results of the CI were the same!

I have added two /* Overwrite the PS saved by the exception entry. */,
one in _xtensa_level1_handler, and another in _xtensa_syscall_handler.
Which one are you in doubt? Or both?
I will try today to remove them to see whether there are any issue.

Here is my test results today:
if removed the clearing of the REG_PS.EXCM from level1 handler, and from syscall handler (yes, both removed),
the ostest on esp32-devkitc, esp32s2-saola-1, esp32s3-devkit all passed.
But I have also tested on a hifi4 dsp, the result is:
removed the clearing of the REG_PS.EXCM from
(1) level1 yes, syscall no, passed
(2) level1 yes, syscall yes, failed. Unhandled Exception 2
(3) level1 no, syscall no,  passed
(4) level1 no, syscall yes, failed. Unhandled Exception 2
Please note that both removed looks right for esp32, but not for hifi4.
The failed scenario for hifi4, in case (2) and (4), is:
a task was interrupted by syscall, then later was resumed by RFI. This is the reason clearing of the REG_PS.EXCM can't be removed from syscall handler.
For the same reason, clearing of the REG_PS.EXCM can't be removed from level1 handler. Consider this scenario:
a task was interrupted by level1 interrupt, then later was resumed by RFI.
This scenario did not appear in the tests, but it does not mean that it will not happen in the future.
So the conclusion is clearing of the REG_PS.EXCM can not be removed from level1 and syscall handler.

if removed the clearing of the REG_PS.EXCM from level1 handler, and from syscall handler (yes, both removed), the ostest on esp32-devkitc, esp32s2-saola-1, esp32s3-devkit all passed.

I forget to mention that I have removed it from level1 handler.

The failed scenario for hifi4, in case (2) and (4), is: a task was interrupted by syscall, then later was resumed by RFI. This is the reason clearing of the REG_PS.EXCM can't be removed from syscall handler.

For the same reason, clearing of the REG_PS.EXCM can't be removed from level1 handler. Consider this scenario: a task was interrupted by level1 interrupt, then later was resumed by RFI. This scenario did not appear in the tests, but it does not mean that it will not happen in the future. So the conclusion is clearing of the REG_PS.EXCM can not be removed from level1 and syscall handler.

This is the point that I'm not convinced: in which situation a level-1 handler (or syscall handler) would be resumed by RFI instead of RFE? Isn't that an error (by design)?

Take the task sleeping scenario as an example:

task A call sleep(), this will finally trigger syscall handler;
but when the syscall handler return, it will very likely return to idle task;
With idle task being the active task, system will go through several timer interrupts, then task A sleep time expired, the timer interrupt will return to task A.

In above scenario, task A is interrrupted by syscall (a level1 interrupt), and if timer interrupt level in the system is 2 or 3, task A will be resumed by RFI
I think this is a common sense that in RTOS, the interrupt handle will not determinately return to the currently being interrupted task, isn't it?
https://github.com/apache/nuttx/blob/master/arch/xtensa/src/common/xtensa_user_handler.S#L289
https://github.com/apache/nuttx/blob/master/arch/xtensa/src/common/xtensa_int_handlers.S#L149

@tmedicci any more comments?

@tmedicci any more comments?

Hi @chirping78 , I'm sorry for the delayed answer, I was on leave...

Above information is enough to convince you

Yes, this is fine. Thanks and congratulations for the work. We will keep monitoring it with our internal CI.


🌱 bump to the latest kube level

Summary
picks up https://github.com/kcp-dev/kubernetes/pull/107 and https://github.com/kcp-dev/kubernetes/pull/106
Related issue(s)
Fixes #

/lgtm
/approve


feat: general constraints

This PR adds all* the necessary bits and pieces for implementing general constraints.
* Actually, I keep finding new places I missed every time I look through the crate, so I'm pretty sure some are still missing. But I think I've got a lot of them already
TODOs

[ ] Model::feas_relax may require further changes?

References

Gurobi documentation

Oops, it looks like a lot of tests broke. I'll take a look

So there are 2 reasons for the failures:

predictably, attribute_names in src/attribute.rs
There's already a TODO there -- basically, there aren't any general constraints actually implemented, so I can't create one and test it against a corresponding attribute.

integrations tests iis, heuristic_soln and phases
For each of these, gzip that complains about the files:

tests/data/neos859080.mps.gz
tests/data/traininstance2.mps.gz
and tests/data/sing44.mps.gz, respectively
I'm not sure if it's because of my gzip that's broken somehow, but it's almost certainly not caused by the changes

Well, I've added the FFI functions, but now I'm kind of stuck. Implementing the methods is not as straightforward, since they will be a part of the public API. Also the c!() macro obviously won't work with these new constraint types, for which I see roughly 3 possible solutions:

leave it as is, requiring the users to use the methods instead

this would also work as a temporary solution

extend its capabilities to also parse all the general constraints
make a new macro specifically for all the general constraints

I've started implementing the second subcategory of general constraints, namely function constraints, and have noticed something:
As described in https://www.gurobi.com/documentation/11.0/refman/general_constraints.html#subsubsection:GenConstrFunction, all function constraints get transformed into PWL function constraints. This transformation can be configured (on a constraint basis), and for that, all function constraints take the last argument called options. It has a form of string consisting of a space-separated list of name-value pairs, e.g. "FuncPieces=-1 FuncPieceError=0.001", which is kind of ugly IMO.
Do you think it would make sense to use some kind of a builder pattern to construct the string instead? (Though this will be a kind of futile effort, since the string will need to be reparsed on the other side anyway). I will go with a plain string for now.


test(modelql): increase the factor for acceptable performance in flowBasedFilterPerformance

The largest observed factor in CI was about 300.
Because of the currently lower allowed factor, test often fail in CI.
See https://github.com/modelix/modelix.core/runs/33472460674
To be verified by reviewers

[ ] Relevant public API members have been documented
[ ] Documentation related to this PR is complete

[ ] Boundary conditions are documented
[ ] Exceptions are documented
[ ] Nullability is documented if used

[ ] Touched existing code has been extended with documentation if missing
[ ] Code is readable
[ ] New features and fixed bugs are covered by tests

Removed the whole test as it's irrelevant. There is much more overhead at other places.

:tada: This PR is included in version 10.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hangup cause

This PR allows to specify the hangup cause.

Hi @thomasvargiu!
Could you fix the build before merging?
Thank you!

Coverage decreased (-5.05%) to 91.748% when pulling 5858eb033f28f153b2926d3ed3276d4101627178 on thomasvargiu:feature/hangup-cause into 31b052e0bc1fefe2853a2024bc3b2e4a0e7b3d9f on marcelog:master.

Thanks @thomasvargiu!


Error

Since Version 2.6.1 (1220) on Glyphs App this doesn't work, when I try to "Get" the left and right list, and have no seperator, then save string:
I get this error
Traceback (most recent call last):

  File "/Library/Python/2.7/site-packages/vanilla-0.1-py2.7.egg/vanilla/vanillaBase.py", line 218, in action_
    self.callback(sender)

  File "StringSmash.py", line 241, in button_saveString
    theString = self.generateString(self.delimL, self.delimR, self.listL, self.listR, self.flip, self.trio, False)

  File "StringSmash.py", line 372, in generateString
    return self.makePairString(listL, listR, delimL, delimR)

  File "StringSmash.py", line 302, in makePairString
    pairList = [aString + '/' + a + '/' + b + bString for b in bList for a in aList]

TypeError: cannot concatenate 'str' and 'NoneType' objects

@schriftgestalt What changed in the API, it worked just one (?) version ago.

Oh wait I see it's because the new line glyph is handled differently now...


[bug]: chown in docker entrypoint causes mounting of config to no longer be possible

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
Nvidia (CUDA)
GPU model
P40
GPU VRAM
24GB
Version number
4.1.0
Browser
n/a
Python dependencies
No response
What happened
Looks as though during startup, within the docker entrypoint, a chown is now ran to ensure permissions are setup correctly for the runtime directory. This occurred in this commit:
https://github.com/invoke-ai/InvokeAI/commit/b00e27b02275465fc4fafc6344dfacd48ee1fc95
For those who run InvokeAI with a read-only mounted configuration file (Docker, Kubernetes -- in my case, Kubernetes), this will cause the container to crash and exit early, as chown isn't able to change the permissions. Example error:
chown: changing ownership of '/invokeai/invokeai.yaml': Read-only file system

What you expected to happen
I would hope that this pattern could continue to work, as it makes deploying InvokeAI outside of my desktop and into a cluster more predictable. Would be convenient to have an environment variable, something like FIX_PERMISSIONS=false, that would skip that portion, for those who know their permissions are setup correctly.
How to reproduce the problem
Use Docker or Kubernetes to mount /invokeai/invokeai.yaml as read-only, and do a standard startup inside of the docker container.
Additional context
No response
Discord username
No response

This is my temporary solution for now -- before building and pushing the image to a container registry, I just revert the patch in question:
git apply -R https://github.com/invoke-ai/InvokeAI/commit/b00e27b02275465fc4fafc6344dfacd48ee1fc95.patch

Thanks - good catch. This docker setup is more tailored to desktop use, where this chown is needed to prevent permission unpleasantries. However, we could ignore the failure to change permissions in the entrypoint, e.g. with chown ... || true. Would that work for you?
FWIW, in your case it might be easiest to set  ....containers.command: ["invokeai-web"] and this way bypass the entrypoint altogether. Just as an option.

FWIW, in your case it might be easiest to set ....containers.command: ["invokeai-web"] and this way bypass the entrypoint altogether. Just as an option.

I attempted this before (though this was last major version, and before some of the more recent configuration changes), and with the previous entrypoint it didn't initialize as expected. Given all of the initialization/configure calls have been removed from the entrypoint, I think for my case, this should now work.
Do still think the chown could be problematic for others though.


Support French language in CiviForm

Is your feature request related to a problem? Please describe.
Charlotte has gotten requirements to add French as a language in CiviForm. This means we'll need to get French translations for the general CiviForm content.
Describe the solution you'd like.
French language is supported in CiviForm
What priority is this?
P1
Associated civic entity
Charlotte

Sent out a translation request for all content in French.

https://github.com/civiform/civiform/pull/8777/files


Unexpected behaveour of class variables in children classes

class A
  @@bla = [1, 2, 3]

  def self.bla
    @@bla
  end
end

class B < A
end

p A.bla
p B.bla

A.bla << 4

p A.bla
p B.bla

crystal 1.cr
[1, 2, 3]
[1, 2, 3]
[1, 2, 3, 4]
[1, 2, 3]

ruby 1.cr
[1, 2, 3]
[1, 2, 3]
[1, 2, 3, 4]
[1, 2, 3, 4]

This behavior is documented here https://crystal-lang.org/reference/syntax_and_semantics/class_variables.html

Class variables are inherited by subclasses with this meaning: their type is the same, but each class has a different runtime value.

I mean the bahavior of class variables is coherent with behavior of instance variables in Crystal:
class A
  @bla = [1, 2, 3]

  def bla
    @bla
  end
end

class B < A
end

a = A.new
b = B.new

p a.bla
p b.bla

a.bla << 4

p a.bla
p b.bla

crystal 1.cr
[1, 2, 3]
[1, 2, 3]
[1, 2, 3, 4]
[1, 2, 3]

Yes this is intentionally different from Ruby, whose behavior is the more surprising one generally and a common pitfall there.

Having different class variables for inherited classes have no sense. I think possibility of share @@ variables was the main goal why they was invented in ruby.

Having different class variables for inherited classes have no sense.

Yet having different instance variables for "inherited instances" has perfect sense?
Why?

Official Ruby FAQ warns about possible problems when using class variables in Ruby:
https://www.ruby-lang.org/en/documentation/faq/8/
What is the difference between class variables and class instance variables?
The main difference is the behavior concerning inheritance: class variables are shared between a class and all its subclasses, while class instance variables only belong to one specific class.
Class variables in some way can be seen as global variables within the context of an inheritance hierarchy, with all the problems that come with global variables. For instance, a class variable might (accidentally) be reassigned by any of its subclasses, affecting all other classes:
class Woof

  @@sound = "woof"

  def self.sound
    @@sound
  end
end

Woof.sound  # => "woof"

class LoudWoof < Woof
  @@sound = "WOOF"
end

LoudWoof.sound  # => "WOOF"
Woof.sound      # => "WOOF" (!)

Or, an ancestor class might later be reopened and changed, with possibly surprising effects:
class Foo

  @@var = "foo"

  def self.var
    @@var
  end
end

Foo.var  # => "foo" (as expected)

class Object
  @@var = "object"
end

Foo.var  # => "object" (!)

So, unless you exactly know what you are doing and explicitly need this kind of behavior, you better should use class instance variables.

@asterite Sorry to ping you, but was the following behavior also intentional?
On the interesting side note class variables in Crystal ARE NOT semantically equivalent to class instance variables in Ruby either. E.g. each class instance does not seem to have a separate variable like in this Ruby example from Official Ruby FAQ:
class Entity

  @instances = 0

  class << self
    attr_accessor :instances  # provide class methods for reading/writing
  end

  def initialize
    self.class.instances += 1
    @number = self.class.instances
  end

  def who_am_i
   "I'm #{@number} of #{self.class.instances}"
  end

  def self.total
    @instances
  end
end

entities = Array.new(9) { Entity.new }

p entities[6].who_am_i  # => "I'm 7 of 9"
p Entity.instances      # => 9
p Entity.total          # => 9

In Crytsal the equivalent code would print this instead
p entities[6].who_am_i  # => "I'm 9 of 9"  # NOTICE 9, not 7
p Entity.instances      # => 9
p Entity.total          # => 9

There are no eigenclasses in Crystal. I think thats related but I'm not sure.

@vlazar What do you consider equivalent code in Crystal?
I've got this and it has the same output:
class Entity
  class_property instances = 0

  @number : Int32

  def initialize
    self.class.instances += 1
    @number = self.class.instances
  end

  def who_am_i
   "I'm #{@number} of #{self.class.instances}"
  end

  def self.total
    @@instances
  end
end

entities = Array.new(9) { Entity.new }

p! entities[6].who_am_i  # => "I'm 7 of 9"
p! Entity.instances      # => 9
p! Entity.total          # => 9

@straight-shoota Thank you for checking this, you are right! I've messed things up apparently.


fix(memory): allow composite chains to use sub-chains memory.

Hello, I want to express my gratitude for this amazing project and for your efforts in bringing AI closer to Javascript.
Issue
The issue was related to the incorrect handling of memory in sub-chains within the sequential chain. This caused memory-based chains to be unable to operate as sub-chains of the sequential chain.
Fix
With this PR, sequential chains can now effectively utilise sub-chain memory. In the past, there was an issue where using memory in sub-chains of a sequential chain was problematic. The chain validation phase did not take into account the variables present in the memory of sub-chains, which resulted in memory-based chains being unable to function as sub-chains of the sequential chain. This pull request (PR) tackles and resolves this issue.
Twitter:  @bhavinkamani_

Interesting - thank you for finding this!


Task titles do not quite match CIS rule texts for v2.0.0

Describe the Issue
In branch benchmark_v2.0.0
the task titles do not 100% match the rule texts of the CIS Benchmark v2.0
Here is an overview over all differences: the - difference is the text of the CIS Benchmark,
the + difference is what is currently found in the Ansible role.
- id: R1.5.1
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure address space layout randomization is enabled
    -
    +Ensure address space layout randomization (ASLR) is enabled
    ```
- id: R1.6.4
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure access to /etc/motd is configured
    -
    +Ensure permissions on /etc/motd are configured
    ```
- id: R1.6.5
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure access to /etc/issue is configured
    -
    +Ensure permissions on /etc/issue are configured
    ```
- id: R1.6.6
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure access to /etc/issue.net is configured
    -
    +Ensure permissions on /etc/issue.net are configured
    ```
- id: R1.7.1
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure GDM is removed
    -
    +Ensure GNOME Display Manager is removed
    ```
- id: R1.7.3
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure GDM disable-user-list option is enabled
    -
    +Ensure disable-user-list option is enabled
    ```
- id: R2.1.5
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure dnsmasq services are not in use
    -
    +Ensure dnsmasq server services are not in use
    ```
- id: R2.1.21
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure mail transfer agent is configured for local-only mode
    -
    +Ensure mail transfer agents are configured for local-only mode
    ```
- id: R2.2.6
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure ftp client is not installed
    -
    +Ensure ftp is not installed
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure chrony is running as user \_chrony
    -
    +Ensure chrony is running as user _chrony
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure cron daemon is enabled and active
    -
    +Ensure cron daemon is enabled and running
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure crontab is restricted to authorized users
    -
    +Ensure cron is restricted to authorized users
    ```
- id: R4.1.4
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure ufw loopback traffic is configured
    -
    +Ensure loopback traffic is configured
    ```
- id: R5.1.6
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd Ciphers are configured
    -
    +Ensure only strong Ciphers are used
    ```
- id: R5.1.9
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd GSSAPIAuthentication is disabled
    -
    +Ensure sshd GSSAPIAuthentication is is disabled
    ```
- id: R5.1.10
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd HostbasedAuthentication is disabled
    -
    +Ensure SSH HostbasedAuthentication is disabled
    ```
- id: R5.1.11
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd IgnoreRhosts is enabled
    -
    +Ensure SSH IgnoreRhosts is enabled
    ```
- id: R5.1.12
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd KexAlgorithms is configured
    -
    +Ensure only strong Key Exchange algorithms are used
    ```
- id: R5.1.13
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd LoginGraceTime is configured
    -
    +Ensure SSH LoginGraceTime is configured
    ```
- id: R5.1.14
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd LogLevel is configured
    -
    +Ensure SSH LogLevel is configured
    ```
- id: R5.1.15
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd MACs are configured
    -
    +Ensure only strong MAC algorithms are used
    ```
- id: R5.1.16
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd MaxAuthTries is configured
    -
    +Ensure SSH MaxAuthTries is set to 4 or less
    ```
- id: R5.1.18
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd MaxStartups is configured
    -
    +Ensure SSH MaxStartups is configured
    ```
- id: R5.1.19
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd PermitEmptyPasswords is disabled
    -
    +Ensure SSH PermitEmptyPasswords is disabled
    ```
- id: R5.1.21
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure sshd PermitUserEnvironment is disabled
    -
    +Ensure SSH PermitUserEnvironment is disabled
    ```
- id: R5.2.4
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure users must provide password for privilege escalation
    -
    +Ensure users must provide password for escalation
    ```
- id: R<IP_ADDRESS>.5
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure password maximum sequential characters is configured
    -
    +Ensure password maximum sequential characters is is configured
    ```
- id: R6.1.3
    - id: R<IP_ADDRESS>.3
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure systemd-journal-upload is enabled and active
    -
    +Ensure systemd-journal-remote is enabled and active
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure use of privileged commands are collected
    -
    +Ensure use of privileged commands is collected
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure unsuccessful file access attempts are collected
    -
    +Ensure unsuccessful unauthorized file access attempts are collected
    ```
- id: R<IP_ADDRESS>
  diff: |-
    **root['rule']**:

    ``` diff
    ---
    +++
    @@ -1,3 +1 @@
    -
    -Ensure kernel module loading unloading and modification is collected
    -
    +Ensure kernel module loading and unloading is collected
    ```

Expected Behavior
Ideally, the task titles should exactly match the CIS rule content (as is already the case for 95% of all rules/tasks)
Actual Behavior
n/a
Control(s) Affected
n/a
Environment (please complete the following information):

branch being used: benchmark_v2.0.0]
Ansible Version:  n/a
Host Python Version: n/a
Ansible Server Python Version: n/a
Additional Details: n/a

Additional Notes
Anything additional goes here
Possible Solution
Enter a suggested fix here

hi @bgro
Thank you for the issue, items like this really help, I have now updated the branch accordingly well spotted.
Many thanks
uk-bolly

Very welcome, thank you for the lightning-fast fix!


Add lint testing framework

You can now test plugins by using // expect-lint comments inside your examples/tests
See https://github.com/invertase/dart_custom_lint#testing-your-plugins-using-expect_lint


Any idea why payment & shipping method forms in checkout are greyed out?

My cart modifiers looks like below but the forms on the checkout page for both payment and shipping are greyed out.. any idea what the problem is? I'm using v0.10.2
SHOP_CART_MODIFIERS = (
    # provides the default cart lines
    'myproducts.modifiers.CurrencyCartModifier',
    # bulk order discounts
    'myproducts.modifiers.QuantityDiscountModifier',
    # unit prices are gross so it calculates VAT already applied
    'shop.modifiers.taxes.CartExcludedTaxModifier',
    # basic shipping provider for £5
    'myproducts.modifiers.PostalShippingModifier',
    # customer can pick up the goods
    'shop.modifiers.defaults.SelfCollectionModifier',
    # payment is out-of-band
    'shop.modifiers.defaults.PayInAdvanceModifier',
    # stripe payment
    'myproducts.modifiers.StripePaymentModifier'
)

How does the HTML markup look like?

For just the two form elements:
<form shop-dialog-form="" name="payment_method_form" novalidate="" class="ng-invalid ng-invalid-required ng-valid-parse ng-pristine cms-plugin cms-plugin-471">

Payment Method

<input id="id_payment_modifier_0_0" name="payment_modifier" ng-change="upload()" ng-model="data.payment_method['payment_modifier']" type="radio" value="pay-in-advance" required="" class="ng-pristine ng-untouched ng-empty ng-invalid ng-invalid-required"> Pay in advance

<input id="id_payment_modifier_1_1" name="payment_modifier" ng-change="upload()" ng-model="data.payment_method['payment_modifier']" type="radio" value="stripe-payment" required="" class="ng-pristine ng-untouched ng-empty ng-invalid ng-invalid-required"> Credit Card

<input id="id_payment_modifier_2_2" name="payment_modifier" ng-change="upload()" ng-model="data.payment_method['payment_modifier']" type="radio" value="stripe-payment" required="" class="ng-pristine ng-untouched ng-invalid ng-invalid-required ng-empty"> Credit Card

This field is required.

<input class="form-control ng-untouched ng-valid ng-not-empty ng-valid-parse ng-pristine" id="id_plugin_id" name="plugin_id" ng-model="data.payment_method['plugin_id']" type="hidden" value="471" autocomplete="off"><input class="form-control ng-untouched ng-valid ng-not-empty ng-valid-parse ng-pristine" id="id_plugin_order" name="plugin_order" ng-model="data.payment_method['plugin_order']" type="hidden" value="5" autocomplete="off">
</form>
<form shop-dialog-form="" name="shipping_method_form" novalidate="" class="ng-invalid ng-invalid-required ng-valid-parse ng-pristine cms-plugin cms-plugin-272">

Shipping Method

<input id="id_shipping_modifier_0_0" name="shipping_modifier" ng-change="upload()" ng-model="data.shipping_method['shipping_modifier']" type="radio" value="postal-shipping" required="" class="ng-pristine ng-untouched ng-empty ng-invalid ng-invalid-required"> Postal shipping

<input id="id_shipping_modifier_1_1" name="shipping_modifier" ng-change="upload()" ng-model="data.shipping_method['shipping_modifier']" type="radio" value="self-collection" required="" class="ng-pristine ng-untouched ng-invalid ng-invalid-required ng-empty"> Self collection

This field is required.

<input class="form-control ng-untouched ng-valid ng-not-empty ng-valid-parse ng-pristine" id="id_plugin_id" name="plugin_id" ng-model="data.shipping_method['plugin_id']" type="hidden" value="272" autocomplete="off"><input class="form-control ng-untouched ng-valid ng-not-empty ng-valid-parse ng-pristine" id="id_plugin_order" name="plugin_order" ng-model="data.shipping_method['plugin_order']" type="hidden" value="6" autocomplete="off">
</form>

Could it be something I've missed in the configuration since I've upgraded from 0.9.2?

Did you use the example shop as a base?
Any Javascript errors?

I used 0.9.2 as a base a long time ago and have recently been through fixing all the changes to 0.10.2. So I have fixed all of the Javascript errors..
My next plan was to get a fresh example shop going to see if that works and try to figure out what the differences are. I just thought there might be something obvious that I've missed..

always difficult to tell, if you can't reproduce it.

It seems I'm missing something out of shop/css/_django-shop.scss. Is there a guide to the styling? I can't seem to find what the minimum scss required to make all the CMS plugins and forms work is.
Thanks for the input!

It looks like I'm also overriding something important. I'll figure it out, thanks.


[BUG] Github Workflow to publish Method Documentions is Broken

Fix https://github.com/opensearch-project/opensearch-ruby/actions/runs/4610255732

@VachaShah Let's work on this together since I don't have Admin access

Actually let's hold off on this one till we resolve this: https://github.com/opensearch-project/opensearch-ruby/issues/133


[SPARK-35694][INFRA][TEST-JAVA11] Increase JVM stack size to 128M for Maven

What changes were proposed in this pull request?

Increase JVM stack size to 128M for Maven
Why are the changes needed?

The jenkins job for JDK 11 build https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-maven-hadoop-3.2-jdk-11/ keep failing with stack overflow error.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Jenkins test

cc @HyukjinKwon @LuciferYang

Test build #139976 has started for PR 32961 at commit 575fcc8.

retest this please

128 is very big .. are we sure this fixes the problem? I tried 256 to fix up AppVeyor CI but it didn't work: https://github.com/apache/spark/pull/32901
We can merge it for now and see if it works but let's probably investigate deeper next time if the issue persists.

Test build #139976 has finished for PR 32961 at commit 575fcc8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@HyukjinKwon I think we can trigger the java 11 test with the tag [TEST-JAVA11] and see how it goes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139976/

Test build #139978 has started for PR 32961 at commit 2517adf.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44502/

Test build #139978 has finished for PR 32961 at commit 2517adf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139978/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44505/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44502/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44505/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44502/

Could you generalize the PR description, @gengliangwang ? It seems that java.lang.StackOverflowError happens at Java 8 with Hadoop 2.7, too.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/2274/consoleFull

@dongjoon-hyun Thanks. I have updated the PR description.
Also, I decided to increase the heap size as well since the current 1G is soft of low. So, I created a new jira for this and updated the PR title.

Test build #140019 has started for PR 32961 at commit a2c3f84.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44545/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44545/

Test build #140019 has finished for PR 32961 at commit a2c3f84.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44545/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140019/

For the UT failure, I made a PR.

https://github.com/apache/spark/pull/32976

I'm still monitoring this and unfortunately it seems to exist still.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-maven-hadoop-2.7/2278/console

At this time, I saw it in SBT build at the latest commit.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-master-test-sbt-hadoop-3.2/2647/consoleFull

@dongjoon-hyun Yes it's bad..

Could this be a problem with Scala 2.12.x itself?  Have we ever seen the same problem with Scala 2.13.x ? I'm just guessing

@dongjoon-hyun It seems that the problem still exists,
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140787/consoleFull


Feedback

Very well-designed readme file.
The report was perfect, and you have successfully done all the sections (More than what is needed!).
Very well comparison in parts 3 and 4.
Final “Challenges and Difficulties Faced” part was great!

Thanks for the feedback, Ali!!


Migrated from the javax to the jakarta namespace

Hello,
First of all, thanks for providing and maintaining rescu!
In relation to #142 here's a pull request to use jakarta.ws.rs. The changes should be quite straightforward however this means that going forward rescu will not support javax.ws.rs anymore.
Maybe a javax maintenance branch could be created to keep publishing fix versions (e.g. if a security vulnerability is fixed)?

I'm on vacation, I'll have a look next week.

I guess I can release this as a new major version 3.0.0 as it is backwards-incompatible. How does that sound?

I agree that it should be a new major version, that's how most projects seem to be handling the javax/jakarta switch

Merged and released in rescu 3.0. @gtoison , thanks for the PR.

I noticed the new release is not compatible with Java 8 due to dependency upgrades, among others jakarta.ws.rs-api 3.1.0.
I see two options:

Keep using the newest versions of dependencies and stop supporting Java 8,
Downgrade some dependencies, e.g. jakarta.ws.rs-api to 3.0.0, and keep support for Java 8.

Any opinions?

Here are all the version changes necessary to support Java 8:

jakarta.ws.rs-api : from 3.1.0  to 3.0.0 (November 2020)
testng: from 7.7.1 to 7.5  (January 2022)
mockito-core: from 5.1.1. to 4.11.0 (December 2022)

Jakarta 10 requires Java 11 or above, so the intersection of projects looking to migrate to Jakarta while also remaining on Java 8 should rather small

Thanks. I'll drop support for Java 8.

I've also created a branch with latest dependency versions that support java 8:
https://github.com/mmazi/rescu/tree/java-8-support


Allow users to create their own tasks

Rationale / Begründung
For when a user might want to create a task on their data management which is not represented by a question in the catalog.
Affected
Users
Minimal functionality

add a create task button for the user

Nice-to-have functionality

allow this task to be referred to a certain question

When we discussed tasks the last time, we said that the discussion should be rather be happening outside of RDMO, so maybe the better solution would be to have a button to create a thread about a questionset in another system (GitLab, JIRA, etc.).
This is also pretty close to the comment feature we talked about but never implemented, see https://github.com/rdmorganiser/rdmo/issues/439


Change error message when no matching point in area

Description
New wording and action for the error message when there is no matching point in the area for a "category" result.
Screenshots

Before
After

@xem
Ah, yes we could. In theory it's just a matter of passing the right fitContent property to the Panel component in CategoryPanel, and make sure its reset when there is no more error to ensure the normal behavior is kept.
This dynamic panel sizing is one of the fragile parts of the app, which used to give a lot of bugs, so there may be some traps :) You could make a dedicated PR for that if you want.


Best practices for splitting large document

Location: no idea, hence this issue
Importance: everyone should split their work :)
Discussion from a conversation on discord, I'v learned that

#include is the current best way to include sub-files like chapter
There are not preprocessing directives so using custom variables must be put in a template.typ

Snippet:
main.typ
#include "ch01-00-intro.typ"
#include "ch01-01-part1.typ"

ch01-00-intro.typ
#import "template.typ": *
#lorem(100)

template.typ
#let pcite =cite.with(form: "prose")

I feel that this should be expanded to best practices in general but this is the only thing I've found so far :)

This is a good note, I will certainly write about include. However, I have no ideas what else should I write about "best practices" with include and import.
Maybe also something about project structure or file naming?

Project structure would be nice. I feel it’s important to separate page layout (“set” rule) in a global configuration file for the project and local files that should be imported for each chapter. What’s that I struggled with when setting up a project.  Le dim. 18 févr. 2024 à 07:42, sitandr @.***> a écrit :
This is a good note, I will certainly write about include. However, I have no ideas what else should I write about "best practices" with include and import.
Maybe also something about project structure or file naming?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Add a Recently Changed Products screen (for power users Android feature parity, increases usage in user's idle time)

What

Add a Recently Changed Products screen (for power users Android feature parity, increases usage in user's idle time)
These are the latest non complete products in real time (nocache=true)

Recently changed by whom? The end-user? The community?
Products the end-user already knows?

I've added precisions, and a screenshot of V1. It used to be called: "Products to be completed". It offered ideas on how to spend idle time (You'd click on the grey scores, and answer the Robotoff prediction)

I understand better. I prefer "Products to be completed", more explicit.
Where would this screen appear? From the standard "Lists" page in settings, where that would be a meta-list?
I think we're a bit stuck with the current 3 tab bottom-bar.
To get the list from the server we need something like that with searchProducts.

The "Votre profil" section is good for that. Next to the "Products from the user that need to be completed".
It's just excuses to spend time completing Open Food Facts products

Fixed


Method to look up description and units for signals/controls

PlatformIO could let a user ask for a human readable description of a signal or control.  The description ultimately would have to be provided by the IOGroup that provided the signal/control.  This method could later be used to extend geopmread to have more information about signals/controls.

This change could add a default implementation in the IOGroup base class that returns an empty string.


Add a 'caption' field

This feature will be useful because it allows leaving a description of the inserted HTML fragments.

This feature will be useful because it allows leaving a description of the inserted HTML fragments.

But this block is supposed for embedding HTML code, it should not be a fit having a caption on it.


Data discrepancies: Roles and Permissions View vs. Database

When you access roles table: https://function-adminportal-test.shesha.dev/dynamic/shesha/roles, there are no data displayed onto the table and the endpoint brings back 0 results, however when you access the roles on the ShaRole table within the datasase, the roles does show

Data from Database: Function-SheshaTest

Related Item
#1338


Setup grizzly to run our CAPA e2e tests

e2e tests are working again on CAPA. They use the grizzly MC and create public WCs.


Issue-207 allow second parameter of expect to satisfy documentation rule

(first PR... hopefully did it right). Hopefully this fixes this issue:
https://github.com/Microsoft/tslint-microsoft-contrib/issues/207

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: pburrows sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Awesome, thanks!


FEATURE: First Clinic - Assisted

We are going to prototype the First Clinic - Assisted process as a simple application in Flask. There are no plans to build user accounts at this point, but rather prototyping the CREATE functionality of a "patient" in the database. We'd also like to start exploring the document upload process. Some goals for this feature pathway:

[x] Create new client (row in clients table)
[x] Enter client information (name, birthday, income, etc.)
[x] Add new document
[x] simple UI design - start thinking about a framework for front-end testing (i.e. Gulp)

Our intention with this process is to start the discussion on our database schema and to give ourselves a framework to begin the UI design process.
@esmithayer is taking the lead and putting together the first two goals with a single table, sqlite Flask install and we'll go from there.

We have all of these things!

:+1:


Wrapping shaka-player in AngularJS directive fails with this.target.addEventListener is not a function

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.1.0
Can you reproduce the issue with our latest release version?
Already latest.
Can you reproduce the issue with the latest code from master?
Didn't try
Are you using the demo app or your own custom app?
Custom App.
If custom app, can you reproduce the issue using our demo app?
No.
What browser and OS are you using?
Chrome, Safari, and Firefox on MacOS 10.12
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd

What configuration are you using?  What is the output of player.getConfiguration()?
"{"drm":{"retryParameters":{"maxAttempts":2,"baseDelay":1000,"backoffFactor":2,"fuzzFactor":0.5,"timeout":30000,"stallTimeout":5000,"connectionTimeout":10000},"servers":{},"clearKeys":{},"advanced":{},"delayLicenseRequestUntilPlayed":false,"logLicenseExchange":false,"updateExpirationTime":1},"manifest":{"retryParameters":{"maxAttempts":2,"baseDelay":1000,"backoffFactor":2,"fuzzFactor":0.5,"timeout":30000,"stallTimeout":5000,"connectionTimeout":10000},"availabilityWindowOverride":null,"disableAudio":false,"disableVideo":false,"disableText":false,"disableThumbnails":false,"defaultPresentationDelay":0,"dash":{"clockSyncUri":"","ignoreDrmInfo":false,"disableXlinkProcessing":false,"xlinkFailGracefully":false,"ignoreMinBufferTime":false,"autoCorrectDrift":true,"initialSegmentLimit":1000,"ignoreSuggestedPresentationDelay":false,"ignoreEmptyAdaptationSet":false,"ignoreMaxSegmentDuration":false,"keySystemsByURI":{"urn:uuid:1077efec-c0b2-4d02-ace3-3c1e52e2fb4b":"org.w3.clearkey","urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed":"com.widevine.alpha","urn:uuid:9a04f079-9840-4286-ab92-e65be0885f95":"com.microsoft.playready","urn:uuid:79f0049a-4098-8642-ab92-e65be0885f95":"com.microsoft.playready","urn:uuid:f239e769-efa3-4850-9c16-a903c6932efb":"com.adobe.primetime"}},"hls":{"ignoreTextStreamFailures":false,"useFullSegmentsForStartTime":false}},"streaming":{"retryParameters":{"maxAttempts":2,"baseDelay":1000,"backoffFactor":2,"fuzzFactor":0.5,"timeout":30000,"stallTimeout":5000,"connectionTimeout":10000},"rebufferingGoal":2,"bufferingGoal":10,"bufferBehind":30,"ignoreTextStreamFailures":false,"alwaysStreamText":false,"startAtSegmentBoundary":false,"gapDetectionThreshold":0.1,"smallGapLimit":0.5,"jumpLargeGaps":false,"durationBackoff":1,"forceTransmuxTS":false,"safeSeekOffset":5,"stallEnabled":true,"stallThreshold":1,"stallSkip":0.1,"useNativeHlsOnSafari":true,"inaccurateManifestTolerance":2,"lowLatencyMode":false,"autoLowLatencyMode":false,"forceHTTPS":false,"preferNativeHls":false},"offline":{"usePersistentLicense":true},"abr":{"enabled":true,"useNetworkInformation":true,"defaultBandwidthEstimate":1000000,"switchInterval":8,"bandwidthUpgradeTarget":0.85,"bandwidthDowngradeTarget":0.95,"restrictions":{"minWidth":0,"maxWidth":null,"minHeight":0,"maxHeight":null,"minPixels":0,"maxPixels":null,"minFrameRate":0,"maxFrameRate":null,"minBandwidth":0,"maxBandwidth":null}},"preferredAudioLanguage":"","preferredTextLanguage":"","preferredVariantRole":"","preferredTextRole":"","preferredAudioChannelCount":2,"preferForcedSubs":false,"restrictions":{"minWidth":0,"maxWidth":null,"minHeight":0,"maxHeight":null,"minPixels":0,"maxPixels":null,"minFrameRate":0,"maxFrameRate":null,"minBandwidth":0,"maxBandwidth":null},"playRangeStart":0,"playRangeEnd":null,"useMediaCapabilities":false}"
What did you do?

Load the page
What did you expect to happen?
Page to load without error
What actually happened?
See attached "console log" picture"

The AngularJS directive is nearly copy-paste from the sample code.  I've also tried alternatives to resolving the promise to player.load() but all approaches have the same two errors...
Source files attached.  See tqVideoPlayer.js for directive source
shakaFiles.zip
See also: https://stackoverflow.com/questions/67634048/wrap-shaka-player-in-angularjs-directive-not-working-this-target-addeventlisten
Appreciate any help on this.  Thanks.

The problem is solved.  My mistake.
Shaka player constructor expects a DOM element but angularjs found a jQuery object.  Works by converting the jquery object to a DOM object.


Better timeout handling

The issue I'm trying to address here is that if you have different tests written using different frameworks (eg. we have a bit of testify) then passing a CLI flag (goblin.timeout) is not a viable option.
Re: SetDefaultTimeout - this gives you the ability to set per test (rather than test-case) timeout rather than using the global flag. Hence the indirection, plus the ability to hijack the intermediate step (defaultTimeout).
Hope that makes sense?

then passing a CLI flag (goblin.timeout) is not a viable option.

Interesting.. is go test complaining if you pass that arugment?

Hope that makes sense?

Kind of ... there's something that I'm not seeing here. You basically added a new defaultTimeout vs currentTimeout which are a bit hard for me to reason about.
We basically have:

goblin.timeout arg
GOBLIN_TIMEOUT env var
SetDefaultTimeout function

Besides this PR needing docs and tests, it's hard to have a mental model about what happens if I set one or many of these variables.

Interesting.. is go test complaining if you pass that arugment?

Correct:

hard for me to reason about

Yeah, I see what you mean. TBH the main thing I care about is the ability to set the global timeout using an environment variable. Would you be open to accepting a PR with just that, obviously including tests?

TBH the main thing I care about is the ability to set the global timeout using an environment variable. Would you be open to accepting a PR with just that, obviously including tests?

yes, that's ok. Out of curiosity, do you have a simple example to reproduce this case you have where you need goblin but sending the argument doesn't cut it? Seems like you ran into a particular case that might have a proper fix instead of adding a new feature.

@marcosnils The problem is with using the flag package, which barfs at anything it does not recognize (default strategy for flag.Parse being ExitOnError). Not a great idea if different libraries need different flags. Anyway, even if Goblin does not use this package, stretchr/testify/suite does. So there isn't really a good fix on Goblin's end, though removing the dependency on the flag package would make it a better citizen of the ecosystem.

In that case then maybe we can make Globin have it's own flagset through https://pkg.go.dev/flag#NewFlagSet and set the error handling to be ContinueOnError instead of adding the env variable? WDYT?

Sure, good idea in general, but that still does not make it possible to use Goblin with flags with other frameworks using the flag package. In principle, using custom flags isn't particularly good design.

, but that still does not make it possible to use Goblin with flags with other frameworks using the flag package.

agree here

In principle, using custom flags isn't particularly good design.

I don't agree here. It really depends on the use-case. In any case, I don't want this to become a debate a of when and how to use flags. Adding the support to the env variable SGTM so we can support this use-case

OK let's not get into philosophical debates. I'll rewrite this PR into something that only covers the envvar, plus tests.


Suggestion: Holy Grail Item Tracker - Sort by qLvl for cLvl gambling

Is it possible to get the q columns to sort ascending/descending?
Wanting to sort by qlvl to know which items to gamble at each level.
Adding an additional qlvl column so that sets and uniques sort off it might be easiest.
Or perhaps a new section for gambling with the above?

That's a good idea. I've added it to my mental TODO list.


GridFunction::AccumulateAndCountZones bug fix

This PR closes #1322. Thanks to @v-dobrev  for helping me out on this one. The fixes are fairly minor and make sure within these GridFunction::AccumulateAndCount* functions that the data is on the host. I've tested these fixes in debug mode with my app without any warnings/asserts being thrown in relation to these parts of code. It also fixed the minimal example shown in #1322 as well.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1327
@rcarson3
@tzanio
@v-dobrev + @camierjs
02/28/20
⌛due 03/03/20
⌛due 03/05/20

There are some other places where we use this or data, but not sure we want to go through all of them now.

Merged in next for testing...


Created package.json files

Fixes #33

Created package.json file for root chapters
Added steam-totp to Chapter 1.2 - Prerequisites/README.md

The package.json files now look like the following example.
"name": "project1",
"version": "1.0.0",
"license": "CC-BY-4.0",
"dependencies": {


fix(utils): remove redundant column in train_test_split()

remove redundant column in train_test_split()
add tests for columns

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.94%. Comparing base (f0263b9) to head (3ef8ef8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   84.93%   84.94%   +0.01%
==========================================
  Files          26       26
  Lines        1918     1920       +2
==========================================
+ Hits         1629     1631       +2
  Misses        289      289

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

the quartodoc error is an upstream issue: https://github.com/machow/quartodoc/issues/357


High memory usage in Gnosis

Tracking ticket for https://github.com/dappnode/DAppNode/issues/559

Not yet clear whether this is a web3signer issue or a dappnode one. Waiting for more details on the linked issue.

Closing issue. Create a new issue or reopen if issue resurfaces.


Issue on Android 9 AFTER succesfull copy on device

Hello There,
I think i've found an issue (at least on Android 9).
After the db is copied successfully from /www directory to app_storage/databases/ directory and trying to use cordova-sqlite-ext to read data from database the db seems to be locked and any select return error.
In other threads in stackoverflow i've found that in Android 9 the function:
this.getReadableDatabase();
Must be followed by:
this.close();
After adding this.close(); on line 36 of DatabaseHelper.java the issue is resolved.
The strange thing is in some case the database was copied and readed correctly (1/10 of the tries....)
Hope can help Bye
Rob

sorry just checked latest version and the issue is already resolved!
thanks


replay: add support for dcecompressing ZST log files

@deanlee we're getting this merged soon, is this good to go?

Yes, I've tested it and it's ready to go. However, there is still an issue with the selfdrive/PR comments. It can't find #include <zstd.h>. It seems we need to update the Docker image to include the zstd library. Do you have any ideas on how to resolve this?

Looks like it's building the docker image from the base branch, which is expected to fail here. Hopefully we can clean up this job very soon, but I wouldn't make it a blocker for this PR. It should pass once we merge.

The PR is ready, suggested changes have been applied.

ty!


Auth no user create

I'd like to thank my family, the production crew, craft services, my agent, and all those people along the way who didn't think i could ever get this build green.  You inspired me to work harder.  Looks who laughing now.

+1


Add Action to add label to PR on merge conflict

Adds a GitHub Action that auto-adds a label to a PR in case there are merge conflicts.
Action in use is https://github.com/marketplace/actions/auto-label-merge-conflicts
I'm not sure if the label also gets auto-removed again but I guess we'll find out :P

For obvious reasons there isn't anything to test or code review here, so instead just react to the PR with a :+1: or :-1: if you want it or not.

I'm not sure if the label also gets auto-removed again but I guess we'll find out :P

https://github.com/mschilde/auto-label-merge-conflicts/blob/591722e97f3c4142df3eca156ed0dcf2bcd362bd/lib/main.ts#L145-L150 should do


added react-native-viewpager-carousel & react-native-mirror

I like your libraries Tobias! Thanks for adding them 👍


Main classes: Widget and Control

This PR adds the primary main classes that define the baseline structure of the Widget and Control classes.

The main discussion related to the structure is located in this issue.

This is ready fo review. I have simplified the earlier draft PR by just pulling out the main class definitions for Widget and Control. I have not included any widget examples here but the draft PR includes several that will eventually each have their own PR.
Main objective of this review is to get feedback on the class definitions and whether these two classes have the right structure to accommodate an assortment of future graphical widgets, including those with touch response.
Some lingering questions to spur discussion:

In the absence of using interrupts, we will rely on a main loop to handle touch events and call the appropriate widgets. In my current widgets, and widget actions are blocking (such as animation of a switch moving).  Do we instead want “non-blocking” widget response functions and then a separate “redraw” widget function?  If so, the main loop will need to call the “redraw” function on each widget in case any redrawing is required (such as during animation) while the main loop can still watch for touch inputs.
Should each widget have a built-in option for a label?  Currently I kept a place holder name for this.
- Benefits: new users could use one command to add a widget and also label it.
- Cons: Not all widgets have an obvious place to put a label, and a separate Widget_Label could do the same job.
Are there other class variables or response functions that should be added to cover a broader set of use cases?

Thanks for your input!

I made major updates to the documentation and was able to build them on my machine.
However, the checks failed here due to Pylint.  It's complaining about repeated code use in the examples folder.  Strange.  I suspect this is due to some unknown changes in the pylint settings.  @kattni will look into this and see if there is a way around it.

Update on Q1 above.
There are asynchronous (async) features that have been added recently:

https://github.com/WarriorOfWire/tasko
https://github.com/adafruit/circuitpython/pull/3540

This can come in handy for the widget redraw functions and the touch response handler.
But for now let’s keep the redraw code as blocking, and explore this async capability in the future.

Thanks to the recent pylint fixes, this is now passing.
@FoamyGuy I'd appreciate if you would take a quick look to verify I addressed your comments.


updated-examples and readme

What does this PR do?

Updated examples and added version to libraries for requirements.txt

Fixes # (issue)
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Did you enjoy working on this PR.

Codecov Report

Merging #155 (96b8c57) into main (20f255a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   89.52%   89.46%   -0.06%
==========================================
  Files          54       54
  Lines        1737     1737
==========================================
- Hits         1555     1554       -1
- Misses        182      183       +1

Impacted Files
Coverage Δ

torchflare/callbacks/progress_bar.py
93.06% <0.00%> (-1.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f255a...96b8c57. Read the comment docs.


Help with Prebid Timing

Type of issue
It seems my page pushes banners befor Prebid ended, but no timeout.
Description
I'm using professor prebid to check the bids, but I get banners before prof displays the bids, even if the system is not in timeout.
Is there a way to understand the status od the bids and check if the result has been sent to the system?
Steps to reproduce
just connect to https://www.tiscali.it/services/vee.html and check when banners are displayed while checking bids sith professor prebid
Test page
(https://www.tiscali.it/services/vee.html)
Expected results
Banners displays after bidding is over or after timeout
Actual results
It seems banners are displayed before the bids are sent
Platform details
Any browser.
We are using prebid8.51.0
Other information

Thank you guys!

Hi @simplo ,
could you please check if vesion 0.2.73 (published 24th of June '24) fixes your issue?
Many thanks in advance!

Hi, I'm trying it since 2 days, it seems fixed.
Thank you!


polarmap.js version for leaflet 1.x?

Your readme file mentions under compatibility that there are two versions of polarmap.js and that v2 is compatible with leaflet 1.x but I only see versions that work with leaflet 0.7. Can you please point me to the refactored polarmap so that I can test it with the new version of leaflet? I have new plugins that I would like to try incorporating but they only work on Leaflet 1.x.

Hi!
Unfortunately that text is unclear and it was intended to be a roadmap of how PolarMap.js versions will match to Leaflet versions in the future. There is no Leaflet 1.x tested release of PolarMap yet. I expect there to be some significant changes in how projections are handled in Leaflet, so testing and development might take awhile and I am unable to dedicate time to it this month.

@openfirmware Thanks for the response! That's too bad, I was hoping you had already tackled it as I expect it to be a fair amount of work to adapt to the new version of leaflet as well. As I am very interested in using polarmap.js please let me know if you'd like to collaborate on this when you have time to work on it in the future and I will hope to have time to help how I can.

+1 on this.
This library looks very good and I am on Leaflet 1.x. I followed the using instruction and was getting errors.
Any updates of support on high Leaflet versions?

Sorry.  The project ends and it will slow down our pace to update the library.  Any contribution from the community will be highly welcome.

I ran into a bug with Leaflet's handling of polar projections, but I haven't investigated since I found that problem.
We have an example here: http://tile.gbif.org/ui/3575/leaflet.html though it's not directly compatible with the polarmap tile schema.  I think all you'd need to change is var extent.


Google Cast iOS MediaStatus object missing property

Hello,
According to the google cast sdk for ios docs[1], MediaStatus object on ios should have ActiveTrackIDs property available.
MediaStatus on android has getActiveTrackIds method[2], which can be used to obtain active tracks from cast device.
I've looked into source code and the property is available in native sdk but I guess because it's marked with [Internal] attribute, in the ApiDefinition.cs, it can't be accessed.[3]
Could you make this property accessible?
[1] https://developers.google.com/cast/docs/reference/ios/interface_g_c_k_media_status.html#a56b43ac0a3e971eb16ffe71dbb431182
[2] https://developers.google.com/android/reference/com/google/android/gms/cast/MediaStatus.html#getActiveTrackIds()
[3]
https://github.com/xamarin/GoogleApisForiOSComponents/blob/master/source/Google/Cast/ApiDefinition.cs

Hi @szymonkalista! The ApiDefinition's ActiveTrackIDs was marked internal in favor of Extensions' ActiveTrackIDs file, this to provide a better bind of the property.
We forgot to add the public scope, we will fix it soon. Thanks for reporting this!


Remove JUnit 4 dependency

Testcontainers does not run if JUnit 4 is not present on classpath because GenericContainer implements JUnit 4 TestRule.
Spring Boot 2.4 will remove JUnit 4 from classpath. Having both versions of JUnit on classpath is inconvenient for authoring tests, as developer is constantly forced to choose a proper import when typing @Test etc.
I think Testcontainers should have a roadmap for releasing a version without JUnit 4 dependency.

Duplicate of #970