Validate bond slaves have no mac duplicates

This PR ensures that bond creation does not fail when slaves with duplicate macs are to be assigned to the bond.
Such a situation can arise when balance-alb bonds are created multiple times over. When such a bond is removed, the slaves are given back to the pool of free interfaces (for example vf's in case of sriov). If such interfaces with duplicate macs are used for another bond in balance-alb mode, the bond creation will fail due to duplicate macs.
In this PR we are detecting such a situation, and reset the duplicate mac to a random one on one of the conflicting interfaces.

@mmirecki will review today, can you look into the failed unit test?

@mmirecki will review today, can you look into the failed unit test?

Looks like a random failure so set the mac address, with the error being:
Failed to attached links to bond, error: Failed to handle duplicated macs on link slaves, error: cannot assign requested address
I modified the PR to attempt to change the mac a few times (10) before acknowledging that an error has actually occurred.

@mmirecki can you run a go mod tidy?
ran locally and there was a diff:
golang.org/x/sys v0.0.0-20210809222454-d867a43fc93e // indirect

LGTM.
@eoghanlawless can you review?

LGTM after those comment above are resolved. @eoghanlawless can you review?

Fixed

@Eoghan1232 @eoghanlawless could you please merge? Thanks


Implement Celery into UI to run ancillary and ad hoc scripts autonomously in place of cron jobs

💡 Summary
Create persistent docker to house rabbitMQ messaging queue to work alongside of Celery to track, monitor and carryout tasks. The Celery framework must be added to Flask application to be able to create task that might otherwise be executed by a cron job.
This would be useful to replace cron jobs and to run processing in multiprocessing environment.
Implementation notes
Please provide details for implementation, such as:

Some of our data gathering scripts need to run before the reports can be run. By implementing this our time to completion of data gathering tasks will become more reliable and could help in spotting where in efficient data gathering processes might be.
Configure flask to handle Celery tasks, create persistant RabbitMQ to carryout the task queue.

Acceptance criteria
How do we know when this work is done?

[ ] Tasks are placed in a queue to execute when programmed
[ ] The availability of current data falls inline with reports schedules
[ ] No stoppage of data gathering
[ ] Monitoring of the tasks that have to take place in order for reports to be cosistently filled with relevant data as laid out by the gathering scripts
[ ] Setup RabbitMQ

Celery has be integrated to the code that is currently running. There is a docker associated with a docker-compose at the Accessor that houses rabbitMQ. The celeryd and celerybeat services are running. See the service config files at /etc/systemd/system for celeryd and /etc/default for celerybeat config. The last remaining task is to place tasks in tasks.py to run data gathering scripts.

Required to enable stress testing.

@cduhn17 Do we have performance data collected from Celery yet?


Updates required for functions V3 and linuxFxVersion

This documentation needs a refresh for V3 and has out of date information about linuxFxVersion.

The instructions for linuxfxversion are incorrect. Specifically the information in the reference table for linuxFxVersion is out of date. If the user is deploying code, then linuxFxVersion should be set in the format of "python|3.7" or "dotnet|3.1", rather than "DOCKER|etc" as currently documented.

Some of the ARM templates need to be updated accordingly for the above. For example one of the templates has "linuxFxVersion": "DOCKER|microsoft/azure-functions-node8:2.0"

A number of the ARM templates are for V2 (e.g. FUNCTIONS_EXTENSION_VERSION ~2) and to be moved up to V3.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1ba8817-3e01-7e84-6c71-b98b131f2927
Version Independent ID: a7703386-9e83-1075-72ef-f9e63f3dc4de
Content: Automate function app resource deployment to Azure
Content Source: articles/azure-functions/functions-infrastructure-as-code.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

I also suggest putting the table with the valid values for linuxFxVersion under some type of heading so that it can be directly linkable from other documentation.

Information provided in the description is accurate. If user is deploying code to linux function app, across all skus, linuxFxVersion  siteConfig property should follow the format : runtime|runtimeVersion for example for a node 12 function app , linuxFxVersion  should be set to node|12
It might be more clear to add different sections for deploying code and using a custom container.
Note: Functions runtime version is determined via App setting FUNCTIONS_EXTENSION_VERSION
@ggailey777 - please reach out if you need more details.

@paulbatum and @pragnagopa Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#assign: @stefanushinardi

#assign: @stefanushinardi

@BryanTrach-MSFT I merged the PR for this issue, I think it can be closed. Thanks

@BryanTrach-MSFT I merged the PR for this issue, I think it can be closed. Thanks

Thanks @stefanushinardi for fixing this! #please-close

Thanks @stefanushinardi for fixing this! #please-close


Question about ResourceQuota objects

Question from Frank on<EMAIL_ADDRESS>Hi all,
Consider the file below, I feel confused about the 'resourcequotas' filed in resource-quota.json file.
{
"id": "quota",
"kind": "ResourceQuota",
"apiVersion": "v1beta1",
"spec": {
"hard": {
"memory": "1073741824",
"cpu": "20",
"pods": "10",
"services": "5",
"replicationcontrollers":"20",
"resourcequotas":"1",
},
}
}
I think the use case of resourcequotas is here,
list, err := q.client.ResourceQuotas(a.GetNamespace()).List(labels.Everything())
for i := range list.Items {
quota := list.Items[i]
If resourcequotas > 1, then there will be multiple ResourceQuotas objects. Then how should we edit the resource-quota.json file? Just modify resourcequotas to n(n > 1)?
In fact, I am not very clear about the usage of 'resourcequotas' field in resource-quota.json file. It indicates the number of ResourceQuota objects? However, how can the one who write the resource-quota.json file know how many ResourceQuota objects exist in the specified namespace? I am not sure whether it's necessary for the existence of 'resourcequotas' field.
--
Regards,
Frank

For some background on this, see the design document here:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/design/admission_control_resource_quota.md
I will pull the pertinent piece here for review:

To optimize system performance, it is encouraged that all resource quotas are tracked on the same ResourceQuota document. As a result, its encouraged to actually impose a cap on the total number of individual quotas that are tracked in the Namespace to 1 by explicitly capping it in ResourceQuota document.

A ResourceQuota is intended to support the ability to cap the total amount of compute resources (cpu/memory) that is consumed by pods in a Namespace.  In addition, it is also intended to cap the total number of any given kinds of objects that can exist in that Namespace in order to restrict usage in a scenario where you may want to limit the number of items that can exist in a dev namespace so it does not compete with prod namespace.  In practice, this means if a Kind of object can be in a Namespace, it's fair game for a ResourceQuota to apply a restriction on the num(Kind).  Naturally, this includes the number of ResourceQuota objects that can exist in a Namespace.
Every create/update operation in a Namespace is evaluated against each ResourceQuota when the pertinent admission controller is enabled.  In order to maintain system performance, it's recommended that you cap the number of active quota documents.  A simple mechanism to do that is to make the first quota you add to a Namespace prevent anymore ResourceQuota objects from being added.

Hi Derek,
Thanks for your explanation, I have got my answers. However, why kubectl describe quota doesn't show the Used and Hard information of resourcequota like pods below?
$ kubectl namespace myspace
$ kubectl create -f examples/resourcequota/resource-quota.json
$ kubectl get quota
NAME
myquota
$ kubectl describe quota myquota
Name: myquota
Resource  Used  Hard
--------  ----  ----
cpu 100m  20
memory  0 1.5Gb
pods  1 10
replicationControllers  1 10
services  2 3
[lack of resourcequota information?]

--
Frank

Which provider are you using?

kubernetes version 0.9
In fact, you can see kubectl does not provide info about 'resourcequota' here

Hello,
Sorry for the delay in responding.  Those objects are not present in kubernetetes version 0.9


Consider rename of config.scala file

By default, mac os filesystem is case insensitive so files like Config.scala and config.scala are treated as the same file.
Of course, this issue can be solved on user side - they need to create another partition which will be case sensitive but it can be a bit of ceremony for users which use company provided macbooks.

Ok, I've fixed it in the direct commit. Fell into the same trap on a new MacBook.


Hey guys i am lost here!

I am new to flutter and there is a lot of flutter content out there for connecting flutter with Firebase and doing the firestore CRUD, unfortunately there is no one provides how to do the CRUD for a specific user.uid!!! so if someone could help! please direct me to the right way i am still learning.

You can do something along the lines of:
var userStore = Firestore.instance.collection('users').document(user.uid);
Then something like this for your Firebase Database rule (apologies can't get new lines working):
service cloud.firestore {     match /databases/{database}/documents {         match /users/{userId} {             allow read, update, delete: if request.auth.uid == userId;             allow create: if request.auth.uid != null;         }     } }
While this question is probably more suitable for Stack Overflow, it may highlight a gap in the documentation, more so for Cloud Firestore. This might help you a bit: https://firebase.google.com/docs/firestore/solutions/role-based-access

Follow Jeff Delany's Youtube channel or Fireship. He teaches like no other. Huge fan.


wp tutorial has wrong equation for wp(rp)

The tutorial for wp(rp) computation has the wrong equation for wp(rp).
https://github.com/astropy/halotools/blob/master/docs/quickstart_and_tutorials/tutorials/catalog_analysis/galcat_analysis/basic_examples/clustering_examples/galaxy_catalog_analysis_tutorial4.rst
The equation as written gives a dimensionless number and has an erroneous multiplication factor of 2 \pi_{max} compared to the commonly used definition.
It is easily fixable, but it also requires the associated figures to be updated.

Yes, agreed. Such are the consequences of hurrying. I'll fix this soon, thanks again.


Working on PR501

Keep backward compatibility
Updating docs
Adding tests for https://github.com/sensu/sensu-puppet/pull/501

@Phil-Friderici Looks good. Could you please update the README to show that hashes are also allowed. BTW, when referring to an issue, use (GH-###) in the commit where ### is the issue number (GH is for GitHub).
You can see previous commits here - https://github.com/sensu/sensu-puppet/commits/master

@ghoneycutt README is updated. I didn't found a matching issue for this new feature. Did I miss it ?

Maybe we shouldn't propagate the usage of strings for plugins in the docs explicitly?
I guess on the long run arrays and hashes should keep supported only.

Released in v2.11.0


fix(IAM Policy Management): update incorrect example operation id comments to match API definition

PR summary

Fixed commented operation id so example generator script will correctly. See operation ids: https://github.ibm.com/cloud-api-docs/iam-access-management/blob/test/iam-policy-management.yaml#L447
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features) - N/A
[x] Docs have been added / updated (for bug fixes / features) - Helps to update docs for accuracy!

Current vs new behavior

No change in behavior, simply will allow generation of sdk examples in api docs.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ALL Images need to be rebuilt with latest version of homebrew

Raising here, as it seems more appropriate than cirruslabs/cirrus-ci-docs#878.
Bintray has been shut down Homebrew/discussions#691, forcing dependencies to be built from source or fail.  In our case, this adds more than 30 minutes to the CI times unless brew update-reset is ran first (which still adds ~5 minutes compared to baseline).
Upstream Homebrew migrated all packages to GitHub packages in April, but Cirrus's images have not yet been rebuilt with this bundled.

big-sur-base image got update to the latest macOS 11.6 and all the up-to-date packages. Please give it a try.

big-sur-base image got update to the latest macOS 11.6 and all the up-to-date packages. Please give it a try.

I think that just tells me this issue still isn't fixed if only half the images have been rebuilt (there's still catalina-base which is broken).

Agreeing with @ibuclaw here, big-sur-base seems to work now, but e.g., catalina-base is still broken.
I also see that the default user on big-sure-base changed, so something else in addition to a rebuild seems to have happened, but I do not see any new commits in this repo. Given that it doesn't seem to be possible to run these macos images with the Cirrus CLI I really wish there was a better way to see what is going on inside them (other than: inspect in CI with terminal).

Put ALL in capitals. ;-)

Images still not updated and as a result all OSX pipelines broke yesterday due to  Homebrew/brew#12170.
Could have been avoided completely @fkorotkov.

Is it possible for you to use Big Sur? What's your use case for supporting such an old version.
macOS CI infrastructure is a huge pain mainly thanks to Apple. There are many restriction and not much support from them. Plus the bitbucket situation really messed up the things for Brew.


<EMAIL_ADDRESS>download via aria2 failed

When downloading standard:
PS C:\Users\mark> scoop install bulk-crap-uninstaller
Scoop was updated successfully!
Installing 'bulk-crap-uninstaller' (4.16) [64bit]
Invalid URI: The URI is empty.
URL https://www.fosshub.com/Bulk-Crap-Uninstaller.html/BCUninstaller_4.16_portable.zip is not valid

When downloading with aria2:
PS C:\Users\mark> scoop install bulk-crap-uninstaller
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
Installing 'bulk-crap-uninstaller' (4.16) [64bit]
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 708398|ERR |        n/a|C:/Users/mark/scoop/cache/bulk-crap-uninstaller#4.16#https_www.fosshub.com_Bulk-Crap-Uninstaller.html_BCUninstaller_4.16_portable.zip
Download: Status Legend:
Download: (ERR):error occurred.
Download: aria2 will resume download if the transfer is restarted.
Download: If there are any errors, then see the log file. See '-l' option in help/man page for details.
ERROR Download failed! (Error 1) An unknown error occurred
ERROR
    referer=https://www.fosshub.com/Bulk-Crap-Uninstaller.html/
    dir=C:\Users\mark\scoop\cache
    out=bulk-crap-uninstaller#4.16#https_www.fosshub.com_Bulk-Crap-Uninstaller.html_BCUninstaller_4.16_portable.zip

ERROR & 'C:\Users\mark\scoop\apps\aria2\current\aria2c.exe' --input-file='C:\Users\mark\scoop\cache\bulk-crap-uninstaller.txt' --user-agent='Scoop/1.0 (+http://scoop.sh/) PowerShell/7.0 (Windows NT 10.0; Win64; x64; Core)' --allow-overwrite=true --auto-file-renaming=false --retry-wait=2 --split=5 --max-connection-per-server=5 --min-split-size=5M --console-log-level=warn --enable-color=false --no-conf=true --follow-metalink=true --metalink-preferred-protocol=https --min-tls-version=TLSv1.2 --stop-with-process=8568 --continue

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop-extras/issues/new?title=bulk-crap-uninstaller%404.16%3a+download+via+aria2+failed

Based on chocolatey updater code -- we could use the software package's github repo
https://github.com/Klocman/Bulk-Crap-Uninstaller/releases


Feature request: Improve handling of (FFox?) location bar.

Something notable in VimFx (which I know isn't what you want to hear at the start of a feature request, but bare with me) was the handling of the location bar: the location bar could be brought to focus with a keybinding, and this focus could be dismissed by hitting ESC (which I don't think was actually customisable). Indeed, swapping the focus away from the location bar doesn't seem to be possible with saka-key.

For the unfocus with Esc, I think that this changed with FF57; I'm struggling with it now after the upgrade.
I found a related Bugzilla issue at Pressing ESCAPE in location bar should return focus to main pane. Not much in work, but there is a mention of using F6 to get out. According to Mozilla's Keyboard shortcuts support page, F6 triggers "Select Location Bar" and "Move to Next Frame". Maybe there's some hope that this is triggerable.

It's not FF57, I'm running FF 56.0.2.
I should probably have mentioned that, actually. Darn.

Actually, this might be related to #112.

It should be noted that, furthermore, the bugzilla mention of F6 isn't quite feature-parity with hitting escape -- if this is something that VimFx is specifically doing, they're actually doing more than just that, as ESC doesn't result in the main frame explicitly selected (there's no marching ants around the window).
Which, I know, is the smallest complaint to have, but still. There's some distinction in behaviour at some level, though, which might be relevant.

Unfortunately, it's no possible with available webextension APIs. See #85.

In case this becomes possible in the future, I'd also like to request a command to focus the location bar and move the caret to the end instead of selecting everything. I used this frequently in VimFx.


openstreetmaps and opentopomaps not loading on device and simulator in 1.9.2

Hi! I have noticed that this fantastic app (thanks a lot!) no longer loads the openstreetmap and opentopomap tiles both in the KaiOS simulator and physical devices. The only tiles that work are those from the satellite map. I have tried two devices: Nokia 8000 4G and E242s. Could it be that the URLs have changed? Strangely enough, I can load the tiles already cached on the installed older version 1.8.0. is it possible that the URL has changed for those two map sources? Kind regards, JH.

when I make a request, I get a 418 status, which unfortunately means that the app was blocked -> https://www.paulnorman.ca/blog/2021/07/standard-layer-2/

As an alternative, I have put together a few layers for you that work. create a file: omap_maps.json and copy the content into it and then copy the file to your sdcard of your phone. The next time you load you will have new cards to choose from in the menu. for the trace map you have to add an api key in the url, you can get the key here https://console.tracestrack.com/
omap_maps.json
[
  {
    "name": "Hiking",
    "type": "overlayer",
    "url": "http://tile.waymarkedtrails.org/hiking/{z}/{x}/{y}.png",
    "attribution": "hiking.waymarkedtrails.org",
    "maxzoom": 18
  },

  {
    "name": "Google Satelite",
    "type": "map",
    "url": "http://mt0.google.com/vt/lyrs=r&hl=en&x={x}&y={y}&z={z}",
    "attribution": "Google",
    "maxzoom": 18
  },

  {
    "name": "trace",
    "type": "map",
    "url": "https://tile.tracestrack.com/topo__/{z}/{x}/{y}.png?key=1234",
    "attribution": "tracestack",
    "maxzoom": 18
  },

  {
    "name": "Google Hybrid",
    "type": "map",
    "url": "http://mt1.google.com/vt/lyrs=y&x={x}&y={y}&z={z}",
    "attribution": "google.com",
    "maxzoom": 18
  },

{
    "name": "Cycling",
    "type": "overlayer",
    "url": "https://tile.waymarkedtrails.org/cycling/{z}/{x}/{y}.png",
    "attribution": "waymarkedtrails.org",
    "maxzoom": 18
  },

  {
    "name": "climbing",
    "type": "overpass",
    "url": "sport=climbing",
    "attribution": "Overpass",
    "maxzoom": 18
  },

  {
    "name": "water",
    "type": "overpass",
    "url": "amenity=drinking_water",
    "attribution": "Overpass",
    "maxzoom": 18
  }
]

Thank you so much for this! I was just about to try creating something like this. I will report back a.s.a.p. Fantastic piece of software.

It works! Thank you so much! I did not even need to move the file from the downloads directory. Confirmed to work on the E242S.

I am closing this issue now.

Closing this issue.

looks like opentopomap is working again.


SCP-2409 - Apply format info to simulator

This PR applies information about choice formatting to simulator (both in inputs and rendering of values).
As part of this PR, I have implemented a custom input component for decimal numbers, and I have also added it to other things that are not choices, because it seems to work much better than the default one.
Deployed to http://pablo.marlowe.iohkdev.io/

Just realised I need to add formatting to constant parameters too, but I will do that in a separate PR (SCP-2438)
Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[x] Commits have useful messages
[ ] Review clarifications made it into the code
[x] History is moderately tidy; or going to squash-merge

I think for the dashboard we'll want to edit the InputField subcomponent so that it handles the choice format: https://github.com/input-output-hk/plutus/tree/master/marlowe-dashboard-client/src/InputField. And then, when we've got the playground/simulation redesigns, that code can go in web-common and be used in both places. In which case this PR would be a temporary solution.
If it is temporary, I don't much mind. But if it isn't, I think we should do it as a stateful Halogen component (or Kris/David-style subcomponent, like we're mostly using elsewhere). Also my first stab would be to try this as two number inputs (styled to look like one) with a decimal point in between, before trying it as a string. Ultimately it might work better as a string, but it would be a shame to lose the native number input support.

I think even if we use two inputs we wouldn't be able to use "number" inputs because the right input would delete the leading zeroes. For example, if you try to input 1.0001, it would delete the leading zeroes and it would write 1.1

I have added px-1 to the input, because otherwise the text was way too close to the border


VMAlertmanager: possibility to customize default matcher labels

Hey folks
I have my Alert Manager running in a cluster, and it's reading VMAlertmanagerConfig from different namespaces. I could add the namespace label through VMAlert, but the metrics are coming from another cluster, and the namespace would be overwritten even though it's needed in the rule.
Would it be possible to customize the default label matcher by configuring the VMAlertmanager operator? We could change it here.
I'd be happy to implement this change if you're okay with it.

Hello,
I don't think, that changing default matcher is a good idea. First of all, it was designed for SaaS like metrics stack deployment. When scraping, alerting and notification configurations created at the same namespace. In this case namespace label enforced at scraping and notification configurations.
I'd suggest to disable namespace matcher and add needed matchers manually at VMAlertmanagerConfigs.
Maybe we could add some sort of globalVMAlertmanagerConfigMatchers array at VMAlertmanager side.
Like:
kind: VMAlertmanager
spec:
  globalVMAlertmanagerConfigMatchers:
   - {namespace != ""}

But it doesn't look like good solution to me.

The solution you propose seems to be a good one.
It would allow for better control over the default matchers.
To provide context, I have no control over the VMAlertmanagerConfigs, which are configurable by the user.
I do have control over the VMAlert, where I can set up static labels, and the VMAlertmanager (knowing the alert manager is shared among multiple users).
This feature would help me significantly to avoid alert collisions between users and undesired label overrides.

Feature added  at v0.48.3 release.
With new setting spec.enforcedTopRouteMatchers it's possible to enforce matchers for all VMAlertmanagerConfig for particular `VMAlertmanager.
kind: VMAlertmanager
spec:
  enforcedTopRouteMatchers:
  - {namespace!=""}

Must enforce namespace label to present at alert to be able routed into VMAlertmanagerConfig.


[BUG] fastAPI not compatible with starlette's router

I've got a classic starlette's app...
and want to mount a fastapi app, on a subpath, with starlette's router
myapp = Router([
    Mount('/api', app=fapi),  #a simple fastapi app
    Mount('/', app=app),      #classic starlette app
])

Everything works like a charm ...
BUT ... if I want to access to /api/docs (ex: http://localhost:8080/api/docs or http://localhost:8080/api/redoc)
it looks like the frontend try to search the swagger on "http://localhost:8080/openapi.json" (404)
but the swagger is really here : http://localhost:8080/api/openapi.json, under its subpath
latest python3, fastapi, swagger & uvicorn

@manatlan
In your FastAPI application can you add openapi_prefix= in the constructor to the FastAPI app?
fapi = FastAPI(openapi_prefix="/api")

This appears to work for me.

Thanks perfect : it works for me too !
And now, I can exetute request thru docs or redoc too.

Thanks for the help here @nwalsh1995 ! :clap: :bow:
Thanks for reporting back and closing the issue @manatlan  :+1:


pip install --user flake8

flake8 is a great way to find issues in Python code.  It will help us to find issues and changes so that code will run in both Python 2 and Python 3.

@cclauss shouldn't max. line length be according to PEP8; otherwise, it will not considered Pythonic by Python developers?  See https://www.python.org/dev/peps/pep-0008/#maximum-line-length

79 characters is fewer characters than we used to get on punch cards ;-)
Let's start off lenient and then turn the screws later on.  Right now if you click on the before script twisty in https://travis-ci.org/openwhisk/openwhisk/builds/208265761 you will see that flake8 currently kicks out 438 errors and 34 of those are lines longer than 127 characters!  Once we bring those numbers down, we could consider lowering maximum-line-length to the punch card range.

@cclauss I agree. When being exposed to the serious Python world, I was not pleased with most of PEP8 and especially the 79 char limitation/convention.  Again, please read my concession.

@cclauss is this ready?

Yes, please.

OK - one q: is the change to core/actionProxy/Dockerfile necessary in this pr?
(will decide if I should run trigger a Jenkins build)

Also note you don't need to rebase/merge to master when out of date - will take care of that for you ;)

We can pull the Docker mods out for now.
Thanks for the tip on the rebase/merge.

Here's the commit as I will merge it: https://github.com/openwhisk/openwhisk/compare/master...rabbah:pr-1954?expand=1.

Merged as https://github.com/openwhisk/openwhisk/commit/2358c0977ff03afee123468cb513dea3706a4d1f.


More mv hardlink improvement

as it is based on https://github.com/uutils/coreutils/pull/4831, review after :)

let's do it in https://github.com/uutils/coreutils/pull/4831


Fix Vector's const iterator constructor

For my polyphony PR (which is coming along well so far!) I'd like to iterate through a Vector<Ref<AudioStreamPlayback>> using a range based for, inside of a const getter function. I noticed that this currently isn't possible. The compiler says that the construction of a ConstIterator on line 251 of vector.h discards the const qualifier, so I switched the ConstIterator constructor to take a pointer to a const T. The semantics of const pointers vs pointers to consts are endlessly confusing to me but I think this is right. It lets my range-based for loop compile, at least.

This change was already submitted in https://github.com/godotengine/godot/pull/52026. Thanks for the contribution nonetheless 🙂


Problem with setup.py

While setting up the program, I got an error at step 4, which stopped the work. Looking at the setup.py file, I noticed that a , is missing at lines 6 and 13. By adding a , the problem was resolved, and then I was able to proceed.
I just wanted to let you know so that the authors can solve it or for further users who would have the same problem.

Thanks for letting us know! This has been fixed.


push! and append! of GeoTable

This package will be more useful when GeoTable support writing features.
Tables.jl provides a manual of implementation: https://tables.juliadata.org/stable/#Tables.isrowtable

Can you please clarify? The link points to the isrowtable trait in Tables.jl
Em seg., 30 de out. de 2023 03:01, Lee, Dohyeon @.***>
escreveu:

This package will be more useful when GeoTable support writing features.
Tables.jl provides a manual of implementation:
https://tables.juliadata.org/stable/#Tables.isrowtable
—
Reply to this email directly, view it on GitHub
https://github.com/JuliaEarth/GeoTables.jl/issues/72, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZQW3OXE2J5GNKAA4ETPQLYB47FPAVCNFSM6AAAAAA6VOX5HOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DONJXGM3DMNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


nordlicht: init at 0.4.5

Motivation for this change
Because... why not? :-)
Build and manual test seems to work for me.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

I'm closing as OP seems not intent to respond to review requests.


What is the Group Search Base?

User Search Base is "ou=people,dc=planetexpress,dc=com", but what is the one for Groups? It doesn't seem to be indicated in the readme file. Thanks!

The same like for users. They share the same ou.

Missed this issue. @SpiGAndromeda is right. You can do a "group search" with a filter.


Building reusable FormField is either painful or badly documented

Forms often contain subset of fields that are one unit. One example of this is an Address field, it contains a street field, box, country, etc.
I believe the API of FormField makes it hard to reason about such fields. That, or there is another way to do it than the following and it's not documented.
Here is an example of making an address field (which is not even complete):

minimal code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Home(),
      ),
    );
  }
}

class Home extends StatefulWidget {
  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  late final ValueNotifier<Address?> controller;

  @override
  void initState() {
    super.initState();
    controller = ValueNotifier(null);
    controller.addListener(() => setState(() {}));
  }

  @override
  void dispose() {
    super.dispose();
    controller.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.all(8.0),
      child: Column(
        children: [
          AddressFormField(controller: controller),
          const SizedBox(height: 8),
          const Text('value:'),
          Text(controller.value.toString()),
          const SizedBox(height: 8),
          ElevatedButton(
              onPressed: () => controller.value = null,
              child: const Text('reset')),
        ],
      ),
    );
  }
}

class Address {
  final String street;
  final String box;
  const Address({
    required this.street,
    required this.box,
  });

  @override
  String toString() => 'Address(street: $street, box: $box)';
}

class AddressFormField extends FormField<Address> {
  @override
  final Address? initialValue;
  final ValueNotifier<Address?>? controller;

  AddressFormField({
    this.initialValue,
    this.controller,
  }) : super(builder: (field) {
          final state = field as AddressFormFieldState;
          return state.builder();
        });

  @override
  AddressFormFieldState createState() => AddressFormFieldState();
}

class AddressFormFieldState extends FormFieldState<Address> {
  late final TextEditingController streetController;
  late final TextEditingController boxController;
  late final ValueNotifier<Address?> controller;

  @override
  AddressFormField get widget => super.widget as AddressFormField;

  @override
  void initState() {
    super.initState();
    streetController = TextEditingController(text: widget.initialValue?.street);
    boxController = TextEditingController(text: widget.initialValue?.box);
    controller =
        widget.controller ?? ValueNotifier<Address?>(widget.initialValue);
    // those two listeners are here so we can reflect the changes from the
    // child inputs (text) to the parent (address).
    streetController.addListener(_reflectChangesOnParent);
    boxController.addListener(_reflectChangesOnParent);

    // this listener is here to reflect the change from the parent to the children
    controller.addListener(_reflectChangesOnChildren);
    // this listener is here to reflect the change on the FormField
    controller.addListener(_onChange);
  }

  @override
  void dispose() {
    super.dispose();
    streetController.dispose();
    boxController.dispose();
    controller.dispose();
  }

  _reflectChangesOnParent() {
    final street = streetController.text;
    final box = boxController.text;
    if (controller.value?.street != street || controller.value?.box != box) {
      controller.value = Address(street: street, box: box);
    }
  }

  _reflectChangesOnChildren() {
    final street = controller.value?.street;
    final box = controller.value?.box;
    if (street != streetController.text) {
      streetController.text = street ?? '';
    }
    if (box != boxController.text) {
      boxController.text = box ?? '';
    }
  }

  _onChange() {
    if (controller.value != value) {
      didChange(controller.value);
    }
  }

  Widget builder() {
    return Column(
      children: [
        TextFormField(
          controller: streetController,
        ),
        TextFormField(
          controller: boxController,
        ),
      ],
    );
  }
}

The chit chat between the controllers makes it a bit hard to follow, here there is 2 fields so that's allright, but it quickly becomes annoying.

Hi @cedvdb

The chit chat between the controllers makes it a bit hard to follow, here there is 2 fields so that's allright, but it quickly becomes annoying.

Can you please provide some examples of this? Please explain in detail

It's in my example, the methods _reflectChangesOnParent and _reflectChangesOnChildren.


Smart select not work inside popup

Pls help me!
Smart select not work inside popup with framework7 ver 4.4.7
Error: Smart Select requires initialized View
https://jsfiddle.net/kunshop/e9fw1jc8/11/

https://forum.framework7.io/


Enable pycln i pre-commit

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

!verified


Revert "Update API to expose/filter IdpProfiles instead of ExternalAccounts."

Reverts mozilla/mozillians#1917

@akatsoulas r?

Coverage remained the same at 90.659% when pulling ad958cff93b70eab21d3f991aeb66644d6094a76 on revert-1917-api-expose-filter-idps into cfd72c96e9584f3231ac42d096d0029bb41a2a45 on master.


[Feature] SageMaker Notebook Instances support

Hi, will this package work to connect VS Code to a standard SM notebook? I'm currently using an EC2 bastion to ssh through, so would be really nice if this simplified the process.

Did you mean SageMaker Notebook Instance? it's currently not supported.
Instructions for SageMaker Studio Notebooks is here.

@gilinachum Hi, yes, SageMaker Notebook Instance. Thanks for your suggestion; I tried that code-server solution, but found that the lack of extensions was too big of a con for me personally. Unfortunately I also can't use Studio Notebooks because they're not available in all regions and don't support Local Mode.
Is there already an existing feature request for SageMaker Notebook Instance support?

Hi, Austin,
Let's keep this issue open as a feature request.
In a meantime I suggest taking an alternative approach, as described in the section Remote code execution with PyCharm / VSCode over SSH.

As a result, you get a real training container with all environment variables set by SageMaker, so there's less need in local mode in this case. Moreover, if you need GPU, you can select any instance type you need instead of keeping a single large GPU notebook instance running all the time. This is how you can easily switch instances and reduce costs. Even more, you can choose to start a cluster of multiple instances for iterating faster on distributed training jobs.
Regards,
Ivan

Notebook instances support now has been added.


Workaround the Linux + Release issue for PointerOffset

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.04%. Comparing base (4dfc1b9) to head (bcde3c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   25.04%   25.04%
=======================================
  Files          50       50
  Lines        1238     1238
=======================================
  Hits          310      310
  Misses        928      928

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Using "go test" flags causes multiconfig to exit with a non-zero status

The issue appears to be caused by "go test" passing its flags (with some reformatting, like -v turning into -test.v) to the test code and multiconfig is concerned because it is unaware of those flags.
I've pushed a branch with code that demonstrates the issue: https://github.com/four2five/gotest_multiconfig_example

Actually, an even easier reproduction case is to simply run "go test -v" on master.

hi @four2five thanks for opening the issue, would you like to help us on resolving the issue?

@cihangir Sure thing. I'd be happy to pitch in as we would like to use a version of viper with this issue resolved. What would you  like me to do?

@cihangir I'm doubt that I'll be able to find time in the near term as I've sorted out an alternative solution for our pressing need. Best Regards.

Since this is not an problem for us closing this issue

Huge problem for me doh because the Jenkins not in my control uses go test -v so the solution to flag.Set("test.v", "true") will still cause the Jenkins test to fail. Kan there maybe be a few lines of code added to discard everything starting with test.*?


Registration for June meeting

Add luma link to front page and event page

See https://github.com/uk-tre/website/pull/50 instead


Tailwindcss doesn't load in prod.

When developing in dev mode with Leptos and tailwindcss, using the right settings and link attributes works, but when shipping it to prod, it doesn't load. The problem is in the dist folder the type is unknown. It doesn't know from which type is it: text/css, so it doesn't parse. The solution is to create in the index.html a href to a custom created tailwind.css from the tailwind attributes the 3 also listed on the website and put it in dist. As long as the path in dist match the path from the css there it doesn't matter if in main the index.html path doesn't work, because you can safely rely on data-trunk for it.
Its just something I got fixed this way. Hopefully you can fix it for features releases!

I am not sure I understand. Is there a simple reproducer? With some expected vs actual index.html that you could provide.

With npx you can put the input to the dist folder and compile that. Then you call in index.html the link to this, but trunk doesn't do this

The dist folder should only contain the build output. There's an intermediate build folder. But I understand too little about it to be able to help.
Maybe it makes sense to create a reproducer, as an example in trunk, showing how it works, and figuring out what needs to be done. A PR might help.


Prevent sending lesson notifications prematurely

Apparently hound doesn't clean up existing comments. But I did get a green hound checkbox ^^.

+1


y axis precision should not be exponent

4e+06 is not a simple to grok as 6,000,000
Unintended consequences of y axis precision change

Fixed


v0.0.1

@isomarcte how would you feel about publishing a v0.0.1 (or v0.1.0) with what's currently on main? So we can use your Punycode implementation just as a holdover for Scala Native in https://github.com/Comcast/ip4s/pull/427. Since both the Native stuff and this library are pretty new I wouldn't worry about it forcing us to lock down the binary API prematurely; we can just break if we need to.
Thanks!

@armanbilge I'm fine with that. The interface will change, but hopefully not too much.
FYI, I'm driving cross country for the next few days, so my responses will have higher latency.

Thanks. Have a safe drive!

https://github.com/typelevel/idna4s/releases/tag/v0.0.1


Very small maximum total size of all files uploaded during multipart (set at ~260 MB)

Describe the bug
I am pushing this issue and the pull request associated because the current maximum total size of all files uploaded during a multipart file drop from a local directory is set to only ~260 MB which is extremely low for modern datasets which used PNG, JPG, PDF or any high quality data file format.
To Reproduce
Steps to reproduce the behavior:

Go to your fresh label-studio install (for example, using Docker)
Create a project without adding data
Click on your project
Click on the "Import" button in the top right corner and drop 500 MB of JPG files
See error

Expected behavior
It will be much simpler for beginners and non IT users to have either a very high limit such as 15 GB or to be able to change this value through a dropdown menu.
Screenshots

Environment (please complete the following information):

OS: W10 using WSL 1
Label Studio Version : 1.5.0post0 (master)

Additional context
See the following pull-request

PR https://github.com/heartexlabs/label-studio/pull/2679

You can override this var by setting environment variable DATA_UPLOAD_MAX_MEMORY_SIZE

As you can see here you can change the value directly on the code or by increasing the environment variable.


if marker provided is just a dataset name - expand to full folder name

The following should just work if you did a phyling download fungi_odb10
phyling align -I pep -o aln -m fungi_odb10

instead of having to do
phyling align -I pep -o aln -m HMM/fungi_odb10/hmms

Resolved


Unable to log into Microsoft Account in Code

Issue Type: Bug
Reinstalled Code after a Windows reinstall.  There is nowhere to sing in to my Microsoft account.
VS Code version: Code 1.47.2 (17299e413d5590b14ab0340ea477cdd86ff13daf, 2020-07-15T18:22:06.216Z)
OS version: Windows_NT x64 10.0.18362

Are you looking for log in for settings sync?
If yes - it's still in Insiders builds only.
[Docs] (https://code.visualstudio.com/docs/editor/settings-sync)


Missing info in WSL configuration advanced options

Version
10.0.22000.675
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps

run ubuntu2204.exe config
click Setup and go to next screen
under Auto-Mount observe hint for the 2nd option

Expected Behavior
valid hint
Actual Behavior

Diagnostic Logs
No response

Thanks for reporting this @elsaco.
This setting page is not part of WSL, so I'd recommend creating an issue on launchpad  instead


[Question] Any plans to backport at least the swimming mechanic back to 1.7.10?

Smart Moving glitches custom armor, so I can't use it

A swimming backport is not planned at the moment. 1.7.10 handles player positioning and movement quite differently from 1.8+ so the mod would need some substantial changes. I don't have the time for that currently.
Backporting the water color is possible in the future but it would likely be contributed to Et Futurum Requiem.


Travis builds on Linux fail due to dependency issues

https://travis-ci.org/aspnet/WebSockets/jobs/278439693. This appears to have been caused by a change in Travis images rather than within this repo.

This issue was moved to aspnet/Home#2463


[Installation] Allow lower versions of FastAPI to maintain Ray 2.9 compatibility

FIX https://github.com/vllm-project/vllm/issues/8212#issuecomment-2370349099
cc @darthhexx

@darthhexx can you try installing the new requirements in this PR and see if they work for your #8767?

Works perfectly, thanks for the quick fix @DarkLight1337

Hmmm we might actually need some minimal requirements because if someone has an old version it would not upgrade and likely to break.

Originally, we didn't have any lower bound for fastapi. Honestly, I have no idea what is the actual minimum version required for it to work with vLLM.

@darthhexx perhaps you can suggest a minimum version for FastAPI to use?

With the premise of maintaining support for Ray 2.9, it makes sense for us to pin to the same version that it has set, fastapi<=0.108.0.

I ran pip install -r requirements-common.txt and it works.

Excellent, thank you @DarkLight1337 and @simon-mo


upload-release: Only copy full releases to zulip-server-latest.tar.gz.

zulip-server-6.0-pre0.tar.gz should not be copied to
zulip-server-latest.tar.gz.
Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @alexmv!
Do we need to backport this commit? I can imagine running the upload tool while on the 5.x branch.

Yup, I think it makes sense to backport.

Backported to 5.x as 2aa3695d411f6b335562677c9b75fba8ec0cecc2.


Add an event-state diagram for containers

In the course of a pull request a contributor provided an event-state diagram to illustrate his technical point: (https://github.com/docker/docker/pull/11827#issuecomment-90760920)
The example he produced looks like this:

The diagram includes proposed states but eliminating those would produce a pretty sweet diagram for the docs.  We could use the diagram in a container states page.

Oh thanks for opening an issue for this. While the other issue proposes a new "exit" event, I didn't include that in this diagram (in the current proposal, it would be following the "die" event at the bottom middle).
You can make a copy of the original Google Drawings doc if you'd like to make some changes.
This should cover the events as of API 1.17, except "exec_create", "exec_start", "export" and "import". Since those are out-of-band from the container's lifecycle, they didn't seem to fit here.
I'd love to see something like this included in the API docs, so let me know if I can help.

@mgood  It is a great diagram thank you for putting it together. (We will definitely shout out to you in the docs for this diagram).  I was thinking of using it to have an article on container state.  Do you have a suggestion for where you see it in the API docs?

Ah, I see that under "Container State" it refers to the state as "exited" which I called "stopped".
I think it would also be useful with the docs for the "events" API and events CLI, though they could just link to the Container State documentation. I was referring to those docs for how to use the events API, but they currently only include the event names without further description (the CLI docs also seem to be missing a couple events).

Oh, that's looking great! Think this will be very useful, also for example when teaching colleagues.
Count me in :smile:
Out of interest; is it in SVG (because that would even allow making the diagram interactive in future)

Supernice. Thank you!

Thanks, this diagram was part of a post I was working on for the @gliderlabs blog, which is now live here: http://gliderlabs.com/blog/2015/04/14/docker-events-explained/
@thaJeztah the original is on Google Drawings which has an SVG export option.

@mgood thanks for the link, will read it straight on!
Are you willing to contribute the image (and possibly the docs changes)?

@thaJeztah well it sounded like @moxiegirl may have already started on the docs changes.
@moxiegirl let me know if you do want any more help or feedback.
Do you need something for copyright / licensing on the diagram?

@mgood to follow the procedure properly, I think you'll have to create a PR and sign off your commit. That'll make sure that Docker has legal permission to use your work.
If the graphic has to be incorporated with docs changes written by @moxiegirl, I can see two options;

Wait for the docs changes she's writing, and create a PR to add the image to that document
Create a PR with just the image, then she can send you the text to add to the PR

It's quite busy at this moment because of the pending 1.6 release, so it'll probably have to wait a few days.

@thaJeztah I don't think that's necessary. To satisfy the DCO it's fine under item (b) for @moxiegirl or anyone to submit a change "based upon previous work ... covered under an appropriate open source license". So, I was trying to figure out how best to indicate this.
I'm in no rush, I just wanted to make sure it didn't get held up on anything from my end :smiley:

@mgood shows how much I know about that legal mumbo jumbo :smile:

Hi folks,  I've got the diagram done now. I've got to talk to the engine folks about placement --- so I expect to have full review later tomorrow once it appears in text. Here, for now, is the diagram:

@moxiegirl oh that looks great. Though, the arrow from "die" to "kill" stops a little short, and I'm assuming it was meant to connect. Thanks for the nice visual upgrade :)

Oh that's looking awesome. Only "nit" I can come with is that some text is a bit close to the boxes, perhaps centering them on the connection-line could improve that.
I looked at the actual states/events, I think they're correct, but someone should check, to be sure.
Great work!

OK, I've tweaked based on your suggestions.

I'll get some time later this week to drop it into the API material.  Email me if you want to do that yourself<EMAIL_ADDRESS>and I'll send the files.


Added: Cleaning up industry_ml example.

Modified industry_ml test framework.
Changed the readme to account for tearing down volumes.

Partial fix for #279

I had already done that but looks like I forgot to commit these files. Should the components in examples/industry_ml_components.py be moved to examples/industry_components.py?

Yeah on further thought I think it will be better to put it in the same file until we create a components subdirectory in examples/ (can do in anonher PR). What do you think?

I will put it in a single file; we can figure it out later when we split it into different subdirectories.


https ssl certificate attachment unknown error

I was  trying to attach a certificate for  HTTPS in my app. I got an unnown error
F:\abcd>flynn -a appname route update http/ip1005075-d853bac7-ceee-4c9c-ac70-0dfc149a6ae1 -k abcd.com.crt -c abcd.com.chain.crt unknown_error: Something went wrong

What is the output of flynn -a router log -n 100?

Ah, the issue is that you are using the wrong route ID. Use the ID from flynn route.


/data/init.py 54 MASK = color.rgb2gray(MASK)

the shape of mask is 2D, why do color.rgb2gray(MASK)

Just to guarantee the MASK is in the correct form.
because RGB can also be a black and white image, I used to have this issue on other tasks.
It won't affect anything if you remove it.

thanks for you reply, l find that the most of  masks in DUTS dataset are 2D, but there are also some 3D masks in it.


throwing an error if I disable source map in uglifyjs plugin

I think this is a more appropriate location to file this issue:
https://github.com/webpack/extract-text-webpack-plugin/issues/98
I disabled extract text plugin and it still gives an error.  Its probably in webpack.
So just re posting this:
I get an error if I turn off source map in
new webpack.optimize.UglifyJsPlugin({
    compress: {
        warnings: false
    }
    , sourceMap: false
  })

I'm trying to disable source map since my build takes 5 minutes long.  Removing it yields 1 minute 40 seconds.
Here's part of my stack trace
ERROR in bundle.js from UglifyJs
TypeError: Cannot read property 'sections' of null
    at new SourceMapConsumer (/var/www/project/node_modules/webpack/node_modules/webpack-core/node_modules/source-map/lib/source-map/source-map-consumer.js:24:21)
    at /var/www/project/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:62:23
    at Array.forEach (native)
    at Tapable.<anonymous> (/var/www/project/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:44:10)
    at Tapable.next (/var/www/project/node_modules/webpack/node_modules/tapable/lib/Tapable.js:69:14)
    at Tapable.<anonymous> (/var/www/project/node_modules/webpack/lib/optimize/UglifyJsPlugin.js:136:4)
    at Tapable.applyPluginsAsync (/var/www/project/node_modules/webpack/node_modules/tapable/lib/Tapable.js:71:13)
    at Tapable.<anonymous> (/var/www/project/node_modules/webpack/lib/Compilation.js:564:9)
    at Tapable.next (/var/www/project/node_modules/webpack/node_modules/tapable/lib/Tapable.js:67:11)
    at ExtractTextPlugin.<anonymous> (/var/www/project/node_modules/extract-text-webpack-plugin/index.js:303:4)
    at Tapable.applyPluginsAsync (/var/www/project/node_modules/webpack/node_modules/tapable/lib/Tapable.js:71:13)
    at Tapable.<anonymous> (/var/www/project/node_modules/webpack/lib/Compilation.js:560:8)
    at Tapable.next (/var/www/project/node_modules/webpack/node_modules/tapable/lib/Tapable.js:67:11)
    at ExtractTextPlugin.<anonymous> (/var/www/project/node_modules/extract-text-webpack-plugin/index.js:279:5)
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:52:16
    at done (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:248:21)
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:44:16
    at /var/www/project/node_modules/extract-text-webpack-plugin/index.js:270:6
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:52:16
    at done (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:248:21)
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:44:16
    at /var/www/project/node_modules/extract-text-webpack-plugin/index.js:267:13
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:187:20
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:239:13
    at _arrayEach (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:91:13)
    at _each (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:82:13)
    at Object.async.forEachOf.async.eachOf (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:238:9)
    at Object.async.forEach.async.each (/var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:215:22)
    at /var/www/project/node_modules/extract-text-webpack-plugin/index.js:241:11
    at /var/www/project/node_modules/extract-text-webpack-plugin/node_modules/async/lib/async.js:187:20

What's your devtool?

I don't have it on my webpack config since this is for production.

try to reinstall all dependencies.

@sokra just tried reinstalling dependencies.  Still getting the same error on build:
ERROR in bundle.js from UglifyJs
TypeError: Cannot read property 'sections' of null
    at new SourceMapConsumer

@sokra I've setup a sample repo to reproduce the bug:
https://github.com/deezahyn/webpack-production-test

I am getting the same error here when using sourcemap false and --optimize-minimize (if I leave the optimize out it works).

same error

+1

+1

when using new UglifyJsPlugin and --opimize-minimize (or -p) you are adding the UglifyJsPlugin twice. Omit the CLI option.

Thanks so much @sokra, This helped me!

+1

Thanks @sokra it also fixed it for me

Have similar issue, but i don't specify sourceMap: false. Only when i declare this, build pass.

Thanks @sokra, you fixed this bug for me too :)

Thanks @sokra it also fixed it for me as well

you can also try this:
  plugins: [
    new webpack.SourceMapDevToolPlugin({
      filename: null,
      lineToLine: true,
      module: false,
      test: /\.(ts|map|js)($|\?)/i
    }),

@sokra removing -p does indeed fixes it for me.  Is this intended behavior though? if a flag in cli doe the same thing in config, it will just apply it twice?
I'll gladly make a PR if you can just give me pointers where to look.  Let me know if we don't plan to fix this, and I'll have this close.

Thanks @sokra!

thanks @sokra , fixed this bug

+1
fix by remove -p

+1
fix by remove -p

@sokra thank you vey much :D

Is there a fix coming for this? In my opinion Webpack should be smart enough to omit one or the other f both are present.

when using yarn, you could add this to your package.json file:
"resolutions": {
    "webpack/uglifyjs-webpack-plugin": "^1.1.8"
  },

this will replace webpack original dependency with a more recent one, so you could still use -p switch.

With Webpack 4, mode: 'production' will automatically add optimizations plugins.
If you get the following warning/error message when building with  mode: 'production', try fixing by below instruction.
TypeError: Cannot read property 'sections' of null 👉 Remove `new UglifyJsPlugin` from config
schema id ignored LoaderOptionsPlugin              👉 Remove `new LoaderOptionsPlugin` plugin from config
schema id ignored SourceMapDevToolPlugin           👉 Remove `devtool` config

@ReeganExE if I remove new UglifyJsPlugin from config then how can I customize uglify options? (webpack@4)

do not remove UglifyJsPlugin, just add sourceMap: true to its config

@ashtrie thanks but I don't get it: where do I define uglify-es configuration?
All I have are package.json and webpack.config.js to configure my project.
Plus sourcemaps seems to link to transpiled code and not original source: not sure whether uglify or webpack issue (https://github.com/webpack/webpack/issues/6567#issuecomment-368487038)

@damianobarbati, you might pass it as minimizer option rather than push it as plugin part.
const configs = {
  mode: "production",
  entry: "./index",
  output: {
    filename: "bundle.js"
  },
  optimization: {
    minimize: true,
    minimizer: [
      new UglifyJsPlugin({
        sourceMap: true,
        uglifyOptions: {
          // ...
        }
      })
    ]
  }
};

Thanks @ReeganExE, I made it.

None of the fixes above have worked for me. Here are my configs and error. Any idea why it wouldn't work
`
const path = require('path');
const webpack = require('webpack');
const CopyWebpackPlugin = require('copy-webpack-plugin');
const uglify = require('uglify-js');
const env = process.env.NODE_ENV;
const root = 'src';
/**

@param {Boolean} tranformCopy - boolean to signal if build should minify copied js
*/
module.exports = (tranformCopy) => {
return {
mode: 'production',
resolve: {
modules: ['node_modules', 'bower_components', (path.resolve(__dirname, './src/app'))],
alias: { 'chart.js': 'Chart.js/Chart.js' }
},
entry: {
app: [
'babel-polyfill',
path.join(__dirname, root, 'clutch.js')
],
vendorjs: path.join(__dirname, root, 'vendor.js'),
vendorstyle: path.join(__dirname, root, 'style.js'),
templates: path.join(__dirname, root, 'templates.js')
},
output: {
filename: '[name].[chunkhash].js',
publicPath: '/',
path: path.resolve(__dirname, 'build'),
chunkFilename: '[name].[chunkhash].js'
},
module: {
rules: [
{
test: /.js$/,
exclude: /(node_modules|bower_components)/,
use: [
'ng-annotate-loader',
{
loader: 'babel-loader',
options: {
cacheDirectory: true
}
}
],
parser: {
amd: false
}
},
{
test: /.html$/,
include: path.resolve(__dirname, 'src', 'app'),
use: [
{
loader: ngtemplate-loader?relativeTo=${path.resolve(__dirname, 'src', 'app')}
},
{
loader: 'html-loader'
}
]
},
{
test: /.(scss|sass)$/,
exclude: /(node_modules|bower_components)/,
use: ['style-loader',
{
loader: 'css-loader'
},
'sass-loader']
},
{
test: /.css$/,
use: ['style-loader',
{
loader: 'css-loader'
}
]
},
{
test: /.(eot|ttf|woff|woff2)$/,
use: [
{
loader: 'file-loader',
options: {
name: '[name].[ext]',
outputPath: 'fonts/'
}
}
]
},
{
test: /.(svg|png|jpg|jpeg|ico)$/,
use: [
{
loader: 'file-loader',
options: {
name: '[name].[ext]',
outputPath: 'img/'
}
}
]
}
]
},
plugins: [
// Injects bundles in your index.html instead of wiring all manually.
new HtmlWebpackPlugin({
template: 'src/index.html',
inject: 'body',
minify: {
caseSensitive: true,
collapseInlineTagWhitespace: true,
collapseWhitespace: true,
minifyJS: true,
keepClosingSlash: true,
collapseBooleanAttributes: true,
preserveLineBreaks: false
}
}),
// copies moment locales into public folder.
new CopyWebpackPlugin([
{
from: 'node_modules/moment/locale/*.js',
to: 'locale/moment'
},
]),
     // copies angular-i18n locales into public folder.
     new CopyWebpackPlugin([
         {
             from: 'node_modules/angular-i18n/*.js',
             to: 'locale/angular-local',
             flatten: true
         },
     ]),

     // copies language files to into public folder.
     new CopyWebpackPlugin([
         {
             from: 'src/locale/*.js',
             to: 'locale/dashride'
         },
     ]),

     // ensures only english locale loaded from moment.
     new webpack.ContextReplacementPlugin(/moment[\/\\]locale$/, /en/),

     // injects modules by alias into each file.
     new webpack.ProvidePlugin({
         $: 'jquery',
         _: 'lodash',
         Chart: 'Chart.js/Chart.js',
         'chart.js': 'Chart.js/Chart.js',
         moment: 'moment',
         jQuery: 'jquery',
         'window.jQuery': 'jquery'
     })
 ]

};
};

`
The error is
TypeError: Cannot read property 'sections' of null     at new SourceMapConsumer (/home/paul/Documents/dashride-dispatch/node_modules/source-map/lib/source-map-consumer.js:20:19)     at /home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/index.js:141:27     at Array.forEach (native)     at UglifyJsPlugin.optimizeFn (/home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/index.js:122:142)     at _err0 (eval at create (/home/paul/Documents/dashride-dispatch/node_modules/tapable/lib/HookCodeFactory.js:1:0), <anonymous>:12:1)     at /home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/index.js:262:11     at step (/home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/uglify/index.js:90:11)     at done (/home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/uglify/index.js:99:22)     at /home/paul/Documents/dashride-dispatch/node_modules/uglifyjs-webpack-plugin/dist/uglify/index.js:105:15     at /home/paul/Documents/dashride-dispatch/node_modules/worker-farm/lib/farm.js:191:19     at _combinedTickCallback (internal/process/next_tick.js:73:7)     at process._tickCallback (internal/process/next_tick.js:104:9)

new HtmlWebpackPlugin({
    template: 'src/index.html',
    inject: 'body',
    minify: {
        // ...
        minifyJS: true,
        // ...
    }
})

@pbrain19, try removing  minifyJS: true from your HtmlWebpackPlugin config.

Closing due original problem was solved. If you have problem please create new issue or use stackoverflow or slack. Thanks everyone :+1:

Another way I was able to get rid of this issue was by removing devtool: 'source-map' from webpack config.


IMDB Review Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : IMDB Review Analysis
:red_circle: Aim : Perform Sentiment analysis on the data to see the statistics of what type of movie do users like. Sentiment analysis is the process of analysing the textual data and identifying the emotion of the user, Positive or Negative.
:red_circle: Dataset : http://ai.stanford.edu/~amaas/data/sentiment/
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.
A Demo Project has been created to guide you about the whole structure of presenting the Project in this repository. Here's the link of the Demo Project - https://github.com/abhisheks008/ML-Crate/tree/main/Project-Demo-Folder

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
Are you a participant of SWOC 2.0?

[ ] YES
[ ]  No

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

I want to work on this!
Full name : Yagyesh Bobde
GitHub Profile Link : https://github.com/yagyesh-bobde
Participant ID : 1131
Approach for this Project : First do an EDA then find which models are best for email spam classification
Are you a participant of SWOC 2.0?
YES

Issue assigned @yagyesh-bobde

@yagyesh-bobde It's been 27 days. What's the update here. Reply ASAP.

@abhisheks008 Can I start over this, I am interested
Full name : Shrikrushna Bhagwat
GitHub Profile Link : https://github.com/krishna-NIT
Participant ID : 930
Approach for this Project : EDA First and then some good plotting and finally presentation with conclusions
Are you a participant of SWOC 2.0?
YES

Yeah you can work on it @krishna-NIT

What's the update here @krishna-NIT

I did one analysis but I am not satisfied with it, will be completing it in 2 days at a max

Okay complete that. Because the program is going to end in 25 days, hurry up! @krishna-NIT

What's the update here @krishna-NIT. You've asked for 2 days max, now what's the status here?


Support Add Custom Network and Derivation Path for Polkadot/Substrate networks.

Enkrypt is the only Polkadot extension that supports Safari, and it has been my main wallet, but I am struggling with the lack of these two important features. Does Encrypt have any plan to add them?

Thank you for your response. In Talisman for example, we can add any substrate custom network.

This allows for correct decoding of transaction information and estimate fees from the metadata, which is not currently possible in Enkrypt. The custom network only work for Ethereum networks iiuc

Additionally, Talisman supports adding a derivation path during substrate account creation or import.

Yeah I mean the custom derivation path: https://wiki.polkadot.network/docs/learn-account-advanced#derivation-paths

got it! thank you for the feature request with examples. Let me look into it

Did I do it wright?


disableMidScale() added to IPhotoView.

In some cases, we do not want middle scale level on double tapping.
However, there's no way to disable it.
So I added a member function to do so.

@eunjae-lee @smarek - was this ever resubmitted? I was thinking of submitting it myself, but if it was turned down for some reason, it would help to know.

@Jawnnypoo now that dev branch seems to be gone, any chance this could still be merged in? Would be super useful instead of having to override the tap listener everytime

IPhotoView doesn't exist anymore, so the PR would have to be updated and resubmitted.


Fix Label position height may not be correctly updated when its HeightReference is relative.

Description
Hi,
I noticed Label position height doesn't work anymore when its HeightReference is relative since the commit 8e271f10e549854e9c1aec27098dec0bc3160094 (diff).
This bug might be caused by a premature assignment to owner._clampedPosition [1].  As the _clampedPosition setter of Label clones the inputted value, the following modification for the owner_clampedPosition won't be applied to the Label glyph billboard [2], which causes the user-specified height not to work as expected. So I moved the assignment to the last line to fix this issue.
[1] https://github.com/CesiumGS/cesium/blob/1.116/packages/engine/Source/Scene/Billboard.js#L1141-L1145
[2] https://github.com/CesiumGS/cesium/tree/1.116/packages/engine/Source/Scene/Label.js#L1155-L1172

Stage
Initial
After Update

Before

After

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[x] I have update the inline documentation, and included code examples where relevant
[x] I have performed a self-review of my code

Code snippet for reproduction (Sandcastle)
const labels = new Cesium.LabelCollection({ scene: viewer.scene })
const label = labels.add({
    show: true,
    position: Cesium.Cartesian3.fromDegrees(113.563889, 34.646389, 50),
    text: 'LABEL HEIGHT: 50',
    font: '32px Arial',
    horizontalOrigin: Cesium.HorizontalOrigin.CENTER,
    heightReference: Cesium.HeightReference.RELATIVE_TO_GROUND,
    disableDepthTestDistance: Number.POSITIVE_INFINITY
})
viewer.scene.primitives.add(labels)

setTimeout(() => {
   label.text = 'LABEL HEIGHT: 200'
   label.position = Cesium.Cartesian3.fromDegrees(113.563889, 34.646389, 200)
}, 2000)

Thanks for the fix @plainheart! We'll take a look at this shortly.

Thanks @plainheart for the fix, and for the testing Sandcastle example making this PR easy to review! I can confirm this addresses the behavior.


using docusaurus - problem with css from using it

Hello! I'm working on a project using the source code of docusaurus (last version), I can add for example DocSidebar into my project, and use it, but the styles are missing. tried creating a rule css on webpack on the node_modules folder but is not taking css from it. I can see each component has new css classes like "styles-module___abcd" abcd changes every time. I assume it is infima that are generating those, but how can I use the css generated inside the docusaurus package in my project? Thanks!

Please see https://docusaurus.io/docs/styling-layout#global-styles

Infima class names. These class names are found in the classic theme and usually follow the BEM convention of block__element--modifier. They are usually stable but are still considered implementation details, so you should generally avoid targeting them. However, you can modify Infima CSS variables.
CSS module class names. These class names have a hash in production (codeBlockContainer_RIuc) and are appended with a long file path in development. They are considered implementation details and you should almost always avoid targeting them in your custom CSS. If you must, you can use an attribute selector ([class*='codeBlockContainer']) that ignores the hash.

"styles-module___abcd" is a CSS module class name and it's generated by the theme components' module CSS, not by Infima. Infima always generates stable BEM class names. If you are to target CSS module class names (you are strongly advised not to), you need to use [class*=...].
I hope that answers your question; but I'm still going to close this as a question. We can continue to discuss on the Docusaurus Discord, or Docusaurus' Discord discussions. Issues here have very low visibility and don't help others with the same question.


Implement our own packets?

I think this is yet another way™ to avoid valence_generated while at the same time not having to rewrite azalea.

this is not worth our time imo


Error ShopChest when deleted shops from other plugin

Hello! I will report you a bug and if you want make a feature, i have in my server some shops removed by other plugin but in the database of shopchest the shops still appears. When this appen my console spam a lot of errors and when a player place a chest in the same position of the database of removed shops it still appear

can you make a command or a feature for remove "removed" shopchest or delete old shops?

Currently, I can't code. So it will stay like that for the moment. But the easiest fix probably is to remove every shop the proper way.  I don't know how you manage to remove the chest without the plugin noticing it, but it should not happen.

The plugin's configuration file config.yml already contains this option:
# Set whether shops should automatically be removed from the database if
# an error occurred while loading.
# (e.g. no chest, no space above chest, or unknown world)
remove-shop-on-error: true

Did not know about that but it's actually quite a good fix. Nonetheless it might also delete the shop not loaded because of a sql error. Idk


Adds more supported chains and update API endpoint URLs

Adds three more networks

Avax
Evmos (gnosis fork)
Aurora

Also updates existing URLs to the new domains according to the migration post.
https://forum.gnosis-safe.io/t/transaction-service-migration-october-2022/1550
Replaces deprecated API paths with current ones.
https://safe-transaction-mainnet.safe.global/

Thanks for the PR~

Nice to see people using this project and keeping it alive.

This is a must dapp for multisig security imo not sure why devs are still making themselves a signer when it's not necessary. More people should use delegator + apesafe combo.


Question/Proposal for defaultRouter or defaultMiddlewares for Service Discovery Providers

Do you want to request a feature or report a bug?
Feature
Where I see a gap in functionality
I'm trying out Traefik 2.1 now that the Consul Catalog provider has been merged in #5395.
I can pull in Services defined in my Consul Catalog, and the defaultRule template works well to map a named service from a Host header. Easy stuff is easy so far.
What I want to do now is define a set of common Middlewares for thinks like CORS headers, HTTPS redirects, IP whitelist/blacklist. It seems like I can do this inside a Traefik config file with Routers and Middlewares but only for Services that are defined inside the Traefik config file.
I do not want to duplicate my middleware configs into hundreds of services' tags in Docker or Consul, so I think maybe I'm missing something here, but... is it the case that I cannot connect a Middleware defined in a traefik.yml config file to a Service that is created from a Service Discovery mechanism?
What I'd like to see to close the gap
I would like to have something like defaultRouter: [specific router from http section] or defaultMiddlewares: [list of middlewares defined in http section] ala defaultRule that already exists for service discovery providers.
One issue that comes to mind with defaultRouter is how that would mix with defaultRule because each Service needs its own rules, such as a Host header match. Adding defaultMiddlewares first seems like less work for this reason?

Example of what I have in mind:
## traefik.yml

providers:
  consulCatalog:
    endpoint:
      address: http://localhost:8500
    constraints: "Tag(`public`)"
    defaultRule: "Host(`{{ .Name }}.example.com`)"
    defaultRouter: myrouter

http:
  routers:
    myrouter:
      middlewares:
        - usefuldefaults
  middlewares:
    usefuldefaults:
      chain:
        middlewares:
          - cors
          - retries
    retries:
      retry:
       attempts: 4
    cors:
      headers:
        accessControlAllowMethods:
          - GET
          - OPTIONS
          - PUT
        accessControlAllowOrigin: "origin-list-or-null"
        accessControlMaxAge: 100
        addVaryHeader: true
        sslRedirect: true
        customFrameOptionsValue: SAME-ORIGIN

Duplicate of #5630

I don’t quite agree that this is a duplicate of that, and also the hostility on that other ticket made it impossible for me to have discovered what you think is a duplicate in the first place.
Can you explain a) if you plan to implement anything that would resolve the other ticket, and b) if I embark on developing this feature what guidance would you give so I don’t waste time developing something you won’t accept?
Would you accept my proposed defaultRouter or defaultMiddlewares on a provider section if I posted a PR?

Thank you for your proposal.
We will work on that, it's in the v2.2 scope.

The more I think about this, defaultRule could be completely replaced by defaultRouter, since a Router has a rule parameter in it.
I would also suggest that a provider section be able to restrict against accepting label configs from a given provider. There are cases where I need to forcibly set certain baseline requirements that a developer cannot opt-out of when deploying their own service; think of IP address restrictions and mTLS with a CDN provider, for example.


Add user to space with role "user" does not display correctly.

Given an existing user with no roles belonging to an org. When adding the "developer" role for an existing space,  this user shows only under the org. summary, but not on the space summary. Clicking through to the space user details shows the user in the list correctly. This is resolved on Stratos logout/login again.
Possibly related to #3764

I've created another issue, #3974, which I think is different but not sure. If it's the same I'll bring details here, if not could you expand on this issue?


gnome-terminal: refactor wrapping variables in binaries

Things done:

[x] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

More
Currently running gnome-terminal with a specific profile outside of the GNOME desktop fails because not all relevant environment variables are not wrapped in binaries.
$ gnome-terminal --window-with-profile=mutt
(gnome-terminal:6019): GLib-GIO-ERROR **: No GSettings schemas are installed on the system
Trace/breakpoint trap

This PR fixes that by automating variable wrapping with wrapGAppsHook instead of explicitly using wrapProgram.

Looks fine thanks.


Feature Request: sign in with Ethereum

Use case
As a user of web applications using omniauth, I would like to be able to sign in with Ethereum.
More details
For more details, see login.xyz and https://github.com/openstreetmap/openstreetmap-website/issues/3582

I won't implement this, specific login implementations are handled in provider specific strategies coded in separate gems/repos.

Hey @BobbyMcWho please re-open this. Perhaps someone else can make it as a contribution to this project?
There's even an existing implementation in Ruby: https://github.com/spruceid/siwe-ruby which is perhaps the "providers specific strategy"?

@chrishobcroft this repo's issues are not a place to request new strategies.
If one of the existing strategies doesn't suit your needs, then you need to either write one yourself, or contract a developer to do it for you.
What you're asking is not an insignificant amount of work, and I've already stated that this repo is not the proper place to add that sort of functionality to.


No warnings for trailing commas

It seems like jshint doesn't warn you about trailling commas inside hashes.
Like the following:
position: {
  my: 'bottom center',
  at: 'top center',
  viewport: true,
  adjust: { method: 'flip' }, //<----- Like this one here
}

This breaks in IE10 and IE11, so it would be a good thing to check these things.

@valueof I just don't want trailing commas in my personal code, so it doesn't really matter to me personally, if ES5 allows them or not. That's why a lot of people have been asking for this feature I guess in other issues here.

@valueof Oh - I see here the note about how Jshint doesn't want to be a style enforcer and to just use JSCS. So, that's what I shall do!


collection total

Display the sum of all collections

why?

https://canary.discord.com/channels/738971489411399761/738990231348314123/922407229129359380

https://canary.discord.com/channels/738971489411399761/738990231348314123/922407229129359380

link broken for me

same issue with link, post screenshot please 🙏


STORM-3477 switch HDFS blobstore isRemoteBlobExists to use file exist…

…s for lower overhead

@Ethanlm - see if this matches what you expect.  Thanks.

Yeah that's what I was thinking about.  Based on this, I am thinking it's probably better to check KeyNotFoundException inside the blobExists function and if it happens, returns false.   Then isRemoteBlobExists can simply invoke blobExists function.
Do we want to add a  blobExists function to LocalFsBlobStore too? So they can have the same functionality?

blobexists() is added strictly for isRemoteBlobExists(), which LocalFsBlobStore does not need.  I think we can forgo adding it.
I agree with your first comment about KeyNotFoundException.  Will rework it.

@Ethanlm - please check again.


Setup a GithubActions worker on ECP or ECN (Nue)

The free workers provided by GitHub actions have the following problems:

Their performance varies a lot. Sometimes tests run in 15 minutes, some other times it takes almost an hour.
We can't use warmed up clusters for Acceptance tests because we always get a new worker.
We can't use many clusters to parallelize tests because of limited resources:

Supported runners and hardware resources
Hardware specification for Windows and Linux virtual machines:

    2-core CPU
    7 GB of RAM memory
    14 GB of SSD disk space

Acceptance Criteria

There is an easy and documented way to provision a GitHub Actions worker on any machine including ECP.
A worker is created for Carrier using the above procedure.

This story will allow us to use multiple warmed up clusters when this one is also implemented: https://github.com/SUSE/carrier/issues/197

There doesn't seem to be a safe way to use self hosted workers with public repositories on Github. There is no way to use self-hosted workers only for branches on our repository (non-forks) and there is no way to completely disable workflows on forks but keep running them on our repository (there is such an option for private repositories but not for public ones).
Until GitHub implements a way to achieve one of the above we only have the following options:

Use another CI (which one wouldn't have these problems though?)
We make the pipeline fast and reliable and stick to the provided workers

Given we can't afford working on 1 above, we will keel working on 2 and make the CI step optional for merging. If tests fail on a PR, we run them locally (which should be fast after #197) and if they pass, we merge.


Update VirtualHostX Cask

Hardcode Version (e21ca03)
Switch to Commercial License (78e9b0a)
Use HTTPS for URLs (67add66)

Could you please squash your commits?


Homebridge Rpi - cant connect with accessories

Hi,
I've installed Homebridge on the Raspberry Pi 3 model B. I have installed 2 plugins (tv & thermostat) and created a config.json. So far so good.. When i start up homebridge it shows the code, says it's running and succesfully connects to my thermostat. However, after i succesfully connected homebridge to the ios home app, the devices itself dont work. Both of the devices give an error (see attached image)
Does anyone have an idea to fix this ?
Thnx

SOLVED: In my case, my accessories were using dynamic ip adresses. So setting up static ones did the trick :)


3D mesh coordinate accuracy?

Hello,
Thank you very much for sharing great project!
Using the img (skates.png) provided as an example by the author as an input, 3D mesh data was obtained with the demo.py code.
The generated 3D mesh data was properly overlapped with the original image, and also matched with high accuracy for each person.

However, there was a problem when merging or concatenating them into the same 3D space.

(The code to combine multiple meshes in the same 3D coordinate system is as follows.)
merged_meshed = all_meshes[0]
for i in range(1, len(all_meshes)):
merged_meshed = trimesh.util.concatenate(merged_meshed, all_meshes[i])
merged_meshed.export(os.path.join(args.out_folder, f'all.obj'))
In my opinion, this problem seems to be caused by poor accuracy on the z-axis.
Are there any parameters (like focal length of camera) that I need to adjust to improve this?
Or should this be recognized as a limitation of this project?
I have one more question, is there any way to make the created obj file like animation?

Here, we use a large focal length value (f=5000), which approximates orthographic projection. You could try a smaller value to avoid these extremes you observe now. For example, for f = 250, you can get something more meaningful (although some inaccuracies are still there):

With that being said, it is important to remember that each person is considered independently during the reconstruction phase, so it is more challenging to place multiple people in the same coordinate frame in a way that is globally consistent.


Circle CI (for mobile)

Copy of circle from client, with tiny change to swap repo names

This is temporary until we do jenkins, but will let you know if any KBFS changes will break mobile build
@strib ?

Looks good to me, thanks!


Wrong Information

This is useless information:

Once your app is ready for submission, you use the Partner Center to submit your app to be listed on Microsoft AppSource. Access to the Partner Center and related documentation is available only to Microsoft Partner Network members.

That is not the case.  I am a member of Parnter center but there is no option to  submit to Microsoft AppSource.  Please advise and help us!

Please explain how to do it?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 70abf16d-ef73-cdfc-1f92-d01dd8f265e5
Version Independent ID: 70abf16d-ef73-cdfc-1f92-d01dd8f265e5
Content: Step 2: Create a managed solution for your app (Microsoft Dataverse) - Power Platform
Content Source: power-platform/developer/appsource/create-solution-app.md
Service: power-platform
Sub-service: developer
GitHub Login: @mikkelsen2000
Microsoft Alias: pemikkel

Thanks for your comment, @cookston. This issue has been assigned to the doc author for review.


Remove version: Wesnoth.BattleForWesnoth version 1.15.14

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: URL works;


Update to bcc 0.5.0

Note that bpf_prog_load as in bcc 0.5.0 prints the log buf to stderr in any case, even when successful, i.e. there's no way currently to suppress output as far as I have seen. In master this was already changed to only print when ret < 0: https://github.com/iovisor/bcc/commit/c669257c1f16eae4c695866bea147f57a9092b80 Ideally, we would be able to disable output entirely.

Thanks @dongsupark


Atom extension plans?

You have ever considered or had in mind Glean for atom? That would be great because I have what I love in Atom already and not looking to move to vscode(tried it though).
@labria ("cc-ing" just one of the team members to not spam all of them)

Hey @valentynv. I've received several requests of that. Unfortunate I've never used atom. However, almost all of the extension is completely decoupled from vscode. You can see all of it in this adapter:
https://github.com/wix/vscode-glean/blob/master/src/editor.ts
If you would like to create the atom version, I would be glad to provide assistance. Basically, ill extract the logic into a separate component, and you'll basically need to implement the functions you see here https://github.com/wix/vscode-glean/blob/master/src/editor.ts
Interested?

@borislit nor very familiar with making plugins, but I'll tell you this. Will start looking into it, play with it, and after that, I am sure we can start doing that.
How does that sound?

@vrinceanuv  sound like a plan! Keep me posted in your research and ill do my best to assist!

Haven't forgotten about this. Just had a lot of things to do, will try to find some time.


NOTICE - show only once after close

— cookies (per session) via front end + suggest back end too

I managed to add this functionality by adding document.cookie = "outdatedclosed=true; expires=Fri, 31 Dec 9999 23:59:59 GMT; path=/"; after line 145 and changing line 103 to if ( !supports(''+ cssProp +'') && document.cookie.replace(/(?:(?:^|.*;\s*)outdatedclosed\s*\=\s*([^;]*).*$)|^.*$/, "$1") !== "true") {

Nice, did you test IE6 ?

:+1: this would be neat

Does it work on old browsers? The purpose of the plugin is to be shown on older browser, so it has to be tested.
Will do asap.

Hi @alexandre-works,
any news regarding this feature?
Thank you!

@tyrann0ussorry man had no time to test in older browsers. You can do it and give us a feedback?
cheers


yapf hook not working for .toml projects

Hello,
I have a .toml project and when I run nbQA with yapf it tells me that I need to install the toml package. I have tried to added the additional dependency in the hook as:
- repo: https://github.com/nbQA-dev/nbQA
  rev: 1.3.1
  hooks:
  - id: nbqa-yapf
    additional_dependencies: [toml]

But I get:
Traceback (most recent call last):
  File "/home/miguel/.cache/pre-commit/repoo4r23pnd/py_env-python3.10/lib/python3.10/site-packages/nbqa/__main__.py", line 673, in _check_command_is_installed
    command_version = metadata.version(python_module)
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 984, in version
    return distribution(distribution_name).version
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 957, in distribution
    return Distribution.from_name(distribution_name)
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 548, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for yapf

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/miguel/.cache/pre-commit/repoo4r23pnd/py_env-python3.10/lib/python3.10/site-packages/nbqa/__main__.py", line 676, in _check_command_is_installed
    import_module(python_module)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'yapf'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/miguel/.cache/pre-commit/repoo4r23pnd/py_env-python3.10/bin/nbqa", line 8, in <module>
    sys.exit(main())
  File "/home/miguel/.cache/pre-commit/repoo4r23pnd/py_env-python3.10/lib/python3.10/site-packages/nbqa/__main__.py", line 704, in main
    _check_command_is_installed(cli_args.command)
  File "/home/miguel/.cache/pre-commit/repoo4r23pnd/py_env-python3.10/lib/python3.10/site-packages/nbqa/__main__.py", line 683, in _check_command_is_installed
    raise ModuleNotFoundError(_get_command_not_found_msg(command)) from exc
ModuleNotFoundError: Command `yapf` not found by nbqa.

Please make sure you have it installed in the same Python environment as nbqa. See
e.g. https://realpython.com/python-virtual-environments-a-primer/ for how to set up
a virtual environment in Python, and run:

    `python -m pip install yapf`.

Hi @miguelcarcamov
you'll need
additional_dependencies: [toml, yapf]

(better still to pin them)


left sidebar: Unread counts are vertically a few pixels off.

Seems like a regression from the last few weeks, if someone wants to git bisect it.

@brockwhittaker

Not sure it's a recent regression. The commit in which it was done was 97733995, however this was just moving the left sidebar components to left-sidebar.css. Am submitting a fix for this now however.


Feature Request: associated_extra_files for non_xcode_targets's

Right now it's not possible to add associated_extra_files to objc_library without sources (headers only). If you try you will get an error:
 Are you using `alias`? For ``associated_extra_files`` it requires real target labels

It's sorta expected, since those targets can never become Xcode targets, so they are excluded from most logic paths, but it would be handy to be able to add non-compilable files associated with this target to the project.

I'll probably start by making header-only library targets into Xcode targets. That will cover your main use case. It will be tricky to easily support other non_xcode_targets, like custom rules or codegen, so I'll have to think about that one.

After #1494, is this still needed?

It's been resolved by https://github.com/buildbuddy-io/rules_xcodeproj/pull/1494 . Thanks!


Add Selection Sort program in DSA Fundamentals

Implement Selection Sort under the DSA Fundamentals folder.
Add a short multiline comment describing the pseudocode as well

I don't really know how to write pseudocode but I think I can figure out the algorithm though.
Can I work on this issue?

I don't really know how to write pseudocode but I think I can figure out the algorithm though.
Can I work on this issue?

Thanks for working on this

Thanks for working on this


Getting AccessDeniedException when using hasRole in WebSecurityConfigurerAdapter#configure

When I use
http
     .antMatchers("/admin/**")
     .hasRole("ADMIN")

inside WebSecurityConfigurerAdapter#configure() to prepare SwitchUserFilter#setSwitchUserUrl()
@Bean
public SwitchUserFilter switchUserFilter() {
    SwitchUserFilter filter = new SwitchUserFilter();
    filter.setUserDetailsService(customUserDetailsService);
    filter.setUsernameParameter("username");
    filter.setSwitchUserUrl("/admin/login_as");
    filter.setTargetUrl("/");
    return filter;
}

then I always got access denied with following log

AuditEvent [timestamp=Thu Feb 22 10:35:42 ICT 2018, principal=_6ce0649c21a30ff021ab25b78ae57b8462f2b3bd75, type=AUTHORIZATION_FAILURE, data={details=com.github.ulisesbocchio.spring.boot.security.saml.user.SAMLUserDetails@9875dcb, type=org.springframework.security.access.AccessDeniedException, message=Access is denied}]

So I think I miss to implement SAMLUserDetails and want to know how the http...hasRole() uses SAMLUserDetails. For now I am trying to read the sample but still unsure how to implement that.
Could you please see and guide me ? Many thanks.

you'd have to implement your own SAMLUserDetailsService. There's a section of the readme that shows how to add your own.
For inspiration, you can look at the vanilla implementations of SAMLUserDetailsServiceImpl and SAMLUserDetails that come with this plugin.

Yes, this time I follow to implement SAMLUserDetailsService as bean but the debug attempt fails to show loadUserBySAML being loaded. Hence I still frustrate don't sure how the bean being called. Can you please guide me a little further? Thanks.


Border instead of fill?

Is there any way to do borders instead of fill color?

You can try to fill with clearColor and add a border manually on the view's layer


Wallet page major redesign

https://www.figma.com/file/XTQwnQ8SZGGDYo2w5nFqH9/Chainsfr_v1.3?node-id=828%3A1487

https://www.figma.com/proto/XTQwnQ8SZGGDYo2w5nFqH9/Chainsfr_v1.3?node-id=936%3A25&viewport=94%2C-589%2C0.3575584888458252&scaling=min-zoom