[Fixes #163] Don't propose "default" format when provided with an Object as fmt

Changing default usage of the "default" format, which is deprecated to suggest using the "combined" format.
This fixes this case morgan({})
It was proposing you to use morgan('default') which is deprecated. Now it says
morgan deprecated morgan(options): use morgan(format, options) instead

Testing
I've added a new kind of test (/test/deprecations.js) because /test/morgan.js was suppressing all deprecation message.
There was no other test trying to capture and assert deprecations.
Also, I believe that this new kind of test could help this other PR https://github.com/expressjs/morgan/pull/153 that was criticized because it was not asserting about the deprecation message.
Note
Notice also that this doesn't actually handle the problem of trying to use morgan in a wrong way, using it directly as a middleware instead of calling it as a function to get the middleware.
That can be done (with one of this new kind of test :P) introducing a new check here
  if (format && typeof format === 'object') {
    opts = format
    fmt = opts.format || 'combined'

    // smart deprecation message
    if (format.baseUrl) {
       deprecate('morgan(options): instead of "app.use(morgan)", you must use morgan like this "app.use(morgan(\'combined\')"')
    } else {
      deprecate('morgan(options): use morgan(' + (typeof fmt === 'string' ? JSON.stringify(fmt) : 'format') + ', options) instead')
  }

Note that format.baseUrl is basically just a way to try to recognize that the first arg is express "request" object, which means that you have used morgan fn directly as a middleware. Maybe there is a better way to check that :)
I'll leave that to you or another PR, since I'm not sure about the deprecation message.
And actually I'm not sure that case should be handle as a deprecation warning message. I think that in that case the whole thing should blow up with an exception, because it won't probably work at all. Right ??
Cheers !!

And actually I'm not sure that case should be handle as a deprecation warning message. I think that in that case the whole thing should blow up with an exception, because it won't probably work at all. Right ??

Yes, though this is a fundamental issue you can do to any middleware module out there. Perhaps there is a change you can make to Express on this to catch the mistake instead of needing to change every single middleware that exists with whatever the check they should use is. That would be the biggest win for everyone :+1:

(couldn't reply to the comment inlined)
Yes, though this is a fundamental issue you can do to any middleware module out there. Perhaps there is a change you can make to Express on this to catch the mistake instead of needing to change every single middleware that exists with whatever the check they should use is. That would be the biggest win for everyone

That is not possible unless you are in a typed language. Express app.use() expects a function, and morgan is a function as well as the return value from morgan().
There is no way express can check that. Not even checking cardinality because I that would restrict you from doing something like app.use( (...args) => )

Then if it's not possible to fix, then I think it's best left to the README to show the proper usage. Like I said this issue can happen to any middleware, and if the solution is to go and pull request every single middleware out there, then I am a big :-1: on that and won't take a change in this module for that. If the solution is to used a typed langauge, then you can use typescript which would have caught this.


browser reporter suite unhide is broken

Found out exactly what's going on in #2754: the HTMLCollection returned by document.getElementsByClassName, at least in some browsers, actually drops elements that get their className changed such that they no longer match the criteria on which the collection was based; thus, Mocha will only unhide the first half of the hidden suites.
#2754 attempted to fix this by converting the collection to an array. Currently Mocha runs in some pretty old environments. If we have a shim for the array slice method we should use that rather than assuming the native [].slice. If we don't have such a shim, we should simply reverse the for loop: start at .length - 1 and decrement while >= 0 instead of starting at 0 and incrementing while < .length.
(We should also get a test for the unhiding of more than one suite. I will incorporate this into my work on testing the HTML reporter and mark it as .skip until a fix can also be PR'd.)
I'd like to thank @zerobinbin for bringing this to our attention, and apologize for taking so long to get around to digging into it.

This could probably be fixed with array methods now that Mocha 4 supports only newer environments? In any case, it's mostly waiting on #2900, which I need to be able to devote some undivided time to per https://github.com/mochajs/mocha/issues/2947#issuecomment-338714711


[rl-license_file-1] License could not be found!

This issue was generated by the SAP Repository Linter. It checks repositories for their compliance with the SAP open source project guidelines. As an SAP employee you can see further details at https://wiki.wdf.sap.corp/wiki/display/ospodocs/Repository+Linter+Findings#RepositoryLinterFindings-License(rl-license_file-XX)

each and every file needs to be "tagged" with the licence.


Individual data

Adds the data about the individual to its activity. Not sure how we're meant to receive the ID of the elephant in question, and as with #36 need to pull this code into a designated individual_view activity.
Also need confirmation that the coordinates textview contents are acceptable

Blocked by #36

Unblocked by #36 pending review


Add H5 and H6 bold variants

The second commit includes changes from #79 that got lost along the way


Player Counters?

is it possible to add a counter for amount of players near you?
Something similar to the following, but accurate?
https://imgur.com/SWsOqvN

is it possible to add a counter for amount of players near you?
Something similar to the following, but accurate?
https://imgur.com/SWsOqvN

Which plugin is this for? Guest Indicators?

I don't see how that feature is very useful. Also it could be used in special circumstances that would violate a rule: "gives summary information about a group of players, such as how many players are attackable and not in your own CC, what prayers they are mostly using, etc"
You could join an opposing clan as a guest for instance and see how many there are near you. If you can get check it with the runelite team first and get pre-approval I can look into it.
Is the image you provided from an existing plugin? If so which one?

Nvm I'll look into it, it's already a feature for clans/friends chat. Probably will be ok to add.

Oh, that makes sense! I splash sometimes in ardy knights and thought it
would be cool to know how many people are near me. What if we didn’t do it
based by clans?
Also, yes. But it’s highly inaccurate. I’d have to find out which one. It
was from an old screenshot.
Also, doesn’t Runelite tell you if there are X amount of people with a team
cape near you? Darn PvP has to ruin everything haha 😆
On Mon, Aug 1, 2022 at 5:20 PM Patrick Watts @.***>
wrote:

I don't see how that feature is very useful. Also it could be used in
special circumstances that would violate a rule: "gives summary information
about a group of players, such as how many players are attackable and not
in your own CC, what prayers they are mostly using, etc"
You could join an opposing clan as a guest for instance and see how many
there are near you. If you can get check it with the runelite team first
and get pre-approval I can look into it.
Is the image you provided from an existing plugin? If so which one?
—
Reply to this email directly, view it on GitHub
https://github.com/pwatts6060/runelite-plugins/issues/3#issuecomment-1201832046,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMBCWFTSKXW4CATKMDQVJVDVXBLTVANCNFSM55I7ETZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Mr. Kyle T. Hillman
Email: @.***
Mobile:<PHONE_NUMBER>

Oh, awesome!! will keep a look out
On Mon, Aug 1, 2022 at 5:29 PM Patrick Watts @.***>
wrote:

Nvm I'll look into it, it's already a feature for clans/friends chat.
Probably will be ok to add.
—
Reply to this email directly, view it on GitHub
https://github.com/pwatts6060/runelite-plugins/issues/3#issuecomment-1201837801,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMBCWFTHNVLUEKTQTVXKJ33VXBMVNANCNFSM55I7ETZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Mr. Kyle T. Hillman
Email: @.***
Mobile:<PHONE_NUMBER>

I'm still not exactly sure what you want and which plugin this is for btw. Can you explain exactly what you'd like the plugin to do and what type of players it is counting? This feature doesn't seem relevant to the plugins I have so far. Maybe Guest Indicators but that's a bit of a stretch unless it's just showing how many people are in the guest clan nearby.

Yeah so something like this: (think standing in GE)
Friends Chat Nearby Counter: 12
Clan Chat Nearby Counter: 2
Guest Clan Nearby Counter: 0
Nearby Players: 179
And of course with toggle buttons for each, it it would expectedly create
an overlay in the top left. I’ll see if I can find which plugin that photo
was from :)
On Tue, Aug 2, 2022 at 3:53 AM Patrick Watts @.***>
wrote:

I'm still not exactly sure what you want and which plugin this is for btw.
Can you explain exactly what you'd like the plugin to do and what type of
players it is counting? This feature doesn't seem relevant to the plugins I
have so far. Maybe Guest Indicators but that's a bit of a stretch unless
it's just showing how many people are in the guest clan nearby.
—
Reply to this email directly, view it on GitHub
https://github.com/pwatts6060/runelite-plugins/issues/3#issuecomment-1202270537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMBCWFWOOZ6WIGL4BUTQLGDVXDVY5ANCNFSM55I7ETZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Mr. Kyle T. Hillman
Email: @.***
Mobile:<PHONE_NUMBER>


Mobile content switcher is missing information

Description

The mobile content switcher doesn't show the beta status of audio, for example. It does not have design room to show additional sources either.
Mobile users should get the same context as desktop users.
This might require some design work from @panchovm; without any design suggestions, I would offer that we make the list a horizontally scrollable one and create a smaller label to indicate that audio is in beta, something like this:

This issue is not present anymore; the design of the mobile content switcher has changed.


Reorg codebase

Description
Basically reorgs the whole codebase.
Changes:

TODO

How can this be tested?
DO NOT LOOK AT IT IN THE BROWSER, because it will be SLOOOW.
Check it out locally and test it / look at it there/
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report

Merging #2187 (fd3ba37) into main (d418d15) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 78.76%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main    #2187   +/-   ##
=======================================
  Coverage   64.33%   64.34%
=======================================
  Files         242      242
  Lines       15341    15340    -1
=======================================
  Hits         9870     9870
+ Misses       4742     4741    -1
  Partials      729      729

Files
Coverage Δ

cmd/config/config.go
40.00% <ø> (ø)

cmd/config/mock.go
100.00% <ø> (ø)

cmd/csi/provisioner/builder.go
69.33% <ø> (ø)

cmd/csi/provisioner/manager.go
71.42% <ø> (ø)

cmd/csi/server/builder.go
68.35% <ø> (ø)

cmd/csi/server/manager.go
72.97% <ø> (ø)

cmd/manager/mock.go
33.33% <ø> (ø)

cmd/manager/test.go
70.00% <ø> (ø)

cmd/operator/manager.go
78.78% <ø> (ø)

cmd/support_archive/archiver.go
44.18% <ø> (ø)

... and 119 more

... and 224 files with indirect coverage changes

lgtm.
ran the unit-tests; looked at your structure and the reasoning 👍


bump kafka-server version to 3.3.1

Signed-off-by: wrongerror<EMAIL_ADDRESS>

@wrongerror merge it for now. We'd better to replace the prereq in samples with the one in https://openfunction.dev/docs/getting-started/quickstarts/prerequisites/


Post-sccan cluster thresholding removed all voxels

Hello,
I have been trying to perform SCCAN using dataset of 83 unilateral thalamic lesions, either with aphasia or without aphasia. I am trying to find out which thalamic site is specifically involved in aphasia.
I segmented the DWI-lesions manually (using MRICron) and standardized them into MNI space (using FSL).
After the SCCAN analysis is done I get the following warning:
WARNING: Post-sccan cluster thresholding removed all voxels.
Here is a complete output in the console:
13:08:32 Running LESYMAP <IP_ADDRESS>21
13:08:32 Checking a few things...
13:08:32 Filenames as input, checking lesion values on 1st image...
13:08:32 SCCAN method: ignoring patch, nperm, and multiple comparison...
13:08:32 Searching voxels lesioned in >= 10% subjects... 97 found
13:08:48 noPatch true - Patches will not be used...
13:08:48 Computing lesion matrix...  83x97
13:08:49 Checking matrix values are binary 0/1...
13:08:49 Running analysis: sccan ...
Searching for optimal sparseness:
lower/upper bound:	  -0.9 / 0.9
cvRepetitions:		  3
nFolds:		  4
sparsenessPenalty:	  0.03
optim tolerance:	  0.03
13:08:49         Checking sparseness -0.212  . . .  CV correlation 0.295 (0.423) (cost=0.711)
13:15:38         Checking sparseness 0.212  . . .  CV correlation 0.298 (0.423) (cost=0.709)
13:22:31         Checking sparseness 0.475  . . .  CV correlation 0.325 (0.410) (cost=0.690)
13:28:59         Checking sparseness 0.637  . . .  CV correlation 0.338 (0.415) (cost=0.681)
13:41:56         Checking sparseness 0.738  . . .  CV correlation 0.344 (0.413) (cost=0.678)
13:46:01         Checking sparseness 0.8  . . .  CV correlation 0.344 (0.417) (cost=0.680)
13:51:54         Checking sparseness 0.728  . . .  CV correlation 0.343 (0.413) (cost=0.679)
13:55:55         Checking sparseness 0.76  . . .  CV correlation 0.346 (0.416) (cost=0.677)
14:00:57         Checking sparseness 0.775  . . .  CV correlation 0.343 (0.417) (cost=0.681)
14:06:31         Checking sparseness 0.75  . . .  CV correlation 0.345 (0.416) (cost=0.678)
14:11:10         Checking sparseness 0.76  . . .  CV correlation 0.346 (0.416) (cost=0.677)
Found optimal sparsenes 0.76 (CV corr=0.346 p=0.00136)
Calling SCCAN with:
Components:		 1
Use ranks:		 1
Sparseness:		 0.76
Cluster threshold:	 150
Smooth sigma:	 0.4
Iterations:		 20
maxBased:		 FALSE
directionalSCCAN:	 TRUE
optimizeSparseness:	 TRUE
validateSparseness:	 FALSE
WARNING: Post-sccan cluster thresholding removed all voxels.
14:16:20 Preparing images...
14:16:20 Logging call details...
14:16:20 Done! 1.1 hours
Lesymap Summary:
Version             :<IP_ADDRESS>21
Subjects            :83
Method              :sccan
Voxels in mask      :97
Multiple comparison :none
P-threshold         :0.05
Statistic range     :0 0
Significant voxels  :0
Runtime             :1.1 hours
... save the output for more info ...
I was wondering what is the reason that my analysis fails. I have seen some published Lesion-Symptom-Mapping analyses using thalamic lesions with way less cases (n=20 or so), so I suppose it is not about the sample size ..? When I performed a simple subtraction analysis (aphasia-causing lesions minus lesions without aphasia) there was a significant overlap in each group, so I was surprised that this does not seem to be the case with SCCAN.
Any suggestions on how to approach this problem would be much appreciated.
Best regards,
Ida

What seems to be killing your results is the default cluster threshold of SCCAN. This is a parameter that was simply borrowed from ANTsR in the sparseDecom2, the SCCAN implementation lesymap uses. The parameter cthresh is used in the SCCAN iterations to remove tiny clusters that do not have much practical meaning (the original function helper is here). That threshold makes sense in the cortical regions where 150 voxels are just 150mm3 = 0.15ml, which is very small to likely constitute a relevant finding.
In your case, your area of interest is very small, and you are interested in the tiny outcomes. So, you can decrease cthresh to the minimum cluster you think makes sense in the thalamus. And while you are at it, you may want to check the smoothing applied by SCCAN. The default sigma (argument smooth) is 0.4. This corresponds to about 2.355 * sigma = 0.942mm FWHM gaussian smoothing approximately.  It is not a lot but check it yourself if that amount of smoothing is appropriate given that your region is very small. Smoothing happens in the SCCAN iterations while seeking for a pattern of voxel weights. It is done to avoid single voxels popping out alone as relevant; we are interested in a region that collectively informs us (so smoothing does some regularization by melting individual values within the surrounding region). This is also the reason why SCCAN results look a bit smoothed.
Two more comments:
Rather than trying the subtraction method you mentioned, consider running the good old standard VLSM by switching the method from 'sccan' to a mass-univariate one. There will be no smoothing there, and no cluster threshold (check the arguments), so you can see if mass-univariate analysis gives you similar results. SCCAN and mass univariate will agree most of the time. But of course, avoid running the analysis 100 times until they look good to you. Fixing the above cthresh and smooth should give you what you need, and another single run of VLSM should give you more confidence on results.
Second, SCCAN is honestly a misnomer myself and others keep using. Canonical correlations need multiple variables on each side, but in lesymap one side of the equation has only a single vector of behavioral scores. So, SCCAN is more simply used as a sparse regression. Keep this present when describing the method in the paper to avoid describing it as a standard canonical correlation, which the original algorithm is designed for but we are not using at full capacity in lesymap.

Thank you very much for your advice, this helped a lot!


Change Logging in remoting modules to SLF4J

Currently Java base logging is used at most places.

All modules under https://github.com/canoo/dolphin-platform/tree/master/remoting

FINEST, FINER, FINE -> trace
CONFIG -> debug
INFO -> info
WARNING -> warn
SEVERE -> error


Composer install

@tynor: You might want to tag a semver release (ie. 1.0.1) so you can install via composer create-project -d ~/.terminus/plugins/ lockr/lockr-terminus:~1.  Right now, you need to install via composer create-project --stability=dev -d ~/.terminus/plugins/ lockr/lockr-terminus which installs from master.  If you tag a release, you can have a stable working version while you continue working on master for bug fixes and feature enhancements.

Looks like it was just a web hook setup I forgot to do to auto-update the Packagist information—just tried a 'composer require lockr/lockr-terminus:~1' and it worked.

Hey @tynor: I don't believe we should install terminus plugins via composer require.  I know it's confusing because that is the installation method suggested on the packagist page.  The problem with composer require is it buries everything in the vendor directory.  Instead, we should install via composer create-project -d ~/.terminus/plugins/ lockr/lockr-terminus:~1.  You might want to put the Composer installation instructions in your README.md also.

For sure—I just used it to test the versioning.
I agree, I'll put Composer instructions above the raw Git clone since it definitely seems cleaner.


Specify guideline for integration tests in terms of what to mock and what should not be mocked

Issue description
The documentation on Integration tests does not provide a guideline as to what can be mocked and what should not be mocked.
For example: while doing integration tests, can i mock the dependencies (i.e. business logic, repository etc..) I think mocks are useful for unit tests. There should be some guideline that states what can be mocked and what should not be mocked
Software versions
Check the .NET target framework(s) being used, and include the version number(s).

[X] .NET Core specifically ASP.Net Core
[ ] .NET Framework
[ ] .NET Standard

Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough  👍 responses, we’ll reconsider.


CAMEL-10401: Support chmod for ftp/ftps

@davsclaus Thanks for the review. I've changed them accordingly.

Thanks for the PR it has been merged. Do you mind closing this?


Animate the trees

Scope:
We need to animate all the trees in each unity scene (Forest, Dark Forest and Town). The goal is to make animations for the leaves of the trees as if the wind were hitting them.
How trees are currently implemented?
We have two types of trees with different colors, we need to animate both types:

All trees is located inside the "trees" object inside the "Grid" object for each scene.
Each tree inside the map is an object composed of two objects called "trunk" that refers to the trunk and "foliage" that refers to the leaves.
Object "BorderTrees" refers to the trees on the map border.
In the inspector panel you can see the characteristics and components of each tree.
Don't touch the order and sorting layers
Don't remove or change the asset of any tree, just make them animated

How to apply?

Please follow the contribution guidelines in the readme file

@jimenezz22 I have read all the guidelines to contribute to this project when OD Hacks I would love to work on this issue

@jimenezz22 I have read all the guidelines to contribute to this project when OD Hacks I would love to work on this issue

Hi @Jemiiah, thank you for your interests to contribute to ByteBeats, we will start assigning issues when the ODHack 9 starts on October 24 and issues will be assigned through OnlyDust

alrifht sureee

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am an advanced computer science student with experience in Java, JavaScript, and Unity. I am currently part of SunsetLabs, where I am responsible for the frontend development of the game Citizen of Arcanis, which we are working on in Unity 3D. This role has provided me with practical experience in asset management, animations, and UI systems in Unity. Given my experience in Unity 3D, I am confident in my ability to tackle issues in Unity 2D and implement solutions efficiently, such as character animations and UI enhancements.
How I plan on tackling this issue
Hello,
I am interested in animating the flowers in the Forest and Town scenes to simulate the effect of wind. I propose the following:
Animator: I will set up an Animator for each type of flower, using different animation cycles that simulate the smooth and natural movement of the flowers in the wind. This will include animations that reflect the tilting and swaying of the flowers in various directions.
Effect Adjustments: I will adjust the speed and frequency parameters of the animations to ensure they are consistent with the environment, making sure the movement feels realistic and not forced.
Scene Testing: I will conduct tests in both scenes to ensure the animations integrate well and display correctly within the game's context.
I am ready to start and contribute to the project. Thank you for considering my proposal.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have development experience in Unity, where I have worked on various tasks such as setting up character animations, configuring camera systems and implementing interactive elements in scenes. My previous experience with similar tasks on the Sunset Labs project has prepared me well to address this issue effectively and deliver high quality results.
How I plan on tackling this issue
I would like to contribute to this issue. I am currently working on the Sunset Labs project with Unity and have already completed several tasks, such as setting up animations and the character camera. I have some experience with the tool, and I’m ready to take on the challenge of animating the chimneys. I plan to implement a particle system to simulate smoke coming out of the chimneys, with appropriate settings to ensure the effect integrates seamlessly with the environment.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
hello @ i'm an experienced frontend developer and a blockchain developer i would love to work on this issue
Pleasee kindly assign :)

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, I'm Collins a frontend and blockchain developer, and an active contributor on OnlyDust. You can check out my profile here: https://app.onlydust.com/u/0xdevcollins. This is my first time contributing to this repository, and I’m excited about the opportunity to contribute. Looking forward to collaborating!
How I plan on tackling this issue
I’ll animate the trees in each Unity scene by creating leaf animations to simulate wind movement. I’ll focus on both tree types found under the "trees" object in the "Grid." The animations will be applied to the "foliage" objects while keeping everything else intact, including the "BorderTrees." I’ll make sure to follow the contribution guidelines in the readme for my updates.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
i have experience in game dev previously as personal projects and hoping to make use of them here and mark my first contribution in odhack
How I plan on tackling this issue
I'll have the animation of trees by instancing a field of wind formed using perlin noise animating natural, propagating waves of motion across groups of trees so that tightly packed trees move in a fashion similar to that of more sparsely distributed trees. The foliage animation I will generate combines subtle pulsing of scale with sway rotation; intensity depends on position in the wind field, and done in a lightweight TreeAnimator component respectful of any existing hierarchy or sorting layers.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
Hi, please can I be assigned this please? This would be my first time contributing to this project and I would love to be the given the opportunity to contribute. I have experience in html, css, JavaScript,TypeScript and solidity, and Cairo.
How I plan on tackling this issue
To solve this issue, I’ll take the following steps:

I’ll locate the "trees" GameObject inside the "Grid" for each scene. I’ll also identify the "trunk" and "foliage" GameObjects for each tree.

After that, I’ll use the Animation window to create a new animation clip (like TreeFoliage_Sway) for the "foliage" object. I’ll then add keyframes for ‘Position’ or ‘Rotation’ to simulate wind, creating a looping sway effect.

Then I’ll create an animator controller and assign the animation clip. I’ll make sure to attach the animator component to each tree's foliage in the inspector. I’ll reuse the same animation for all foliage objects across scenes, including "BorderTrees”. I can also add ‘Wind Zone’ for enhanced wind effects, if you want.

Lastly, I’ll test to ensure smooth animations and adjust as needed.

Please assign me, I’m ready to start work immediately.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 31 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.
How I plan on tackling this issue
To animate the trees in the Unity scenes (Forest, Dark Forest, and Town), we will create wind effects for the leaves of two tree types without altering their structure.
I'll analyze the tree organization under the “trees” object within the “Grid” and develop a wind animation script targeting the foliage. Using Unity’s animation tools, I’ll simulate leaf movement with variations to mimic natural wind. This will also apply to the “BorderTrees” object.
Throughout, I'll maintain existing order and sorting layers, ensure seamless integration through testing, and document our process. This approach will enhance scene dynamics while preserving structure.

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
I have a solid background in game development and animation, particularly in Unity. My experience includes implementing animations, optimizing game performance, and understanding the principles of 3D modeling and scene management. This expertise enables me to effectively animate tree foliage while maintaining the integrity of the existing scene structure and assets.
How I plan on tackling this issue
Identify Tree Structures: Locate the "trees" object within each scene's "Grid" object, ensuring I understand the hierarchy of "trunk" and "foliage" objects.
Animation Creation: Use Unity’s animation tools to create subtle leaf movements that mimic wind effects. This can be achieved by:
Applying simple oscillation to the foliage's rotation or scale.
Utilizing Unity’s Animation or Animator components to manage these animations.
Testing and Iteration: Playtest the animations in each scene (Forest, Dark Forest, and Town) to ensure they appear natural and enhance the visual experience without distracting from the gameplay.
Documentation and Guidelines: Follow the project’s contribution guidelines to maintain consistency and ensure the animations integrate seamlessly with existing assets.

gm @sebas11042 here a resource that can help you to resolve this issue, as you can see in the video, this project has some animated trees that could be a good reference
https://learn.unity.com/project/creator-kit-rpg
https://youtu.be/l-sRhhjIvIw?si=VcLnZrh3Y0VjVfvl

gm @jimenezz22 thanks for the assignment, now let's get to work!


Document release process

I'm about to do a release, and document the steps needed at https://github.com/brainglobe/bg-gitbook/blob/master/development.md

Info is now in a central doc:
https://github.com/brainglobe/.github/pull/2


France Map

Hi everyone,
Is it possible to add a French map also ?
Thanks

Done, published in 0.0.16;


Update example in documentation to be more informative

For example,  use an example that that highlight that matrices are row major.

Added in #40


jqgrid_for_rails and Rails 3.1?

Hi,
I have tried to emulate the jqgrid_for_rails_example in Rails 3.1.1, using the "will_paginate" gem version 3.0.2. When I try to access "localhost:3000/invoices", I get
Routing Error
uninitialized constant InvoicesHelper::JqgridsHelper
Is there a way to get this to work under Rails 3.1?
Many thanks for any hints
Stefan

Hi Stefan,
I updated the sample application to make it work with Rails 3.2.0.
I think you shouldn't have any problem with rails 3.1, just change the verision in the Gemfile and run bundle install.
Please, git it a try.

Hi Juan,
Thanks for the reply. I just installed the sample application under Rails 3.2.0. The grid shows up, I can sort and navigate in the grid (great!!), but when I try to modify (edit) the amount for any selected, I get the following error message:
error Status: 'Not Found '. Error code: 404
The same message comes when I try to add a new record or to delete one.
I also tried to get the thing to work under Rails 3.1.1 (as you suggested), by changing the Rails version in the Gemfile. However, there are dependencies with
gem 'sass-rails',   '~> 3.2.3'
gem 'coffee-rails', '~> 3.2.1'
which require railties, and I don't really understand these dependencies enough to get the thing to work under Rails 3.1.1, so an additional hint would be nice.
Under Rails 3.0.9, however, everything appears to work well.
If there should be an additional newbie-compatitble documentation somewhere (apart from the Readme file), I would be grateful for a hint.
Thanks a lot!
Stefan

Stefan, I updated the application to support editing the values. But there are some things you have to consider.
Rails is based on RESTful routes but jqgrid doesn't, i.e, all the methods that jqgrid requests to the controller are GET or POST. Methods such as PUT or DELETE are never used (at least at the moment I started with jqgrid, maybe now that has changed). So you will have to adapt your controller to support delete or create operations based on the 'oper' param that jqgrid sends.
About Rails 3.1, it should work if you change your Gemfile to something like:
group :assets do
  gem 'sass-rails',   '~> 3.1.5'
  gem 'coffee-rails', '~> 3.1.1'
  gem 'uglifier', '>= 1.0.3'
end

Sorry, but there is no documentation other than the README. Also take into account that I wrote the plugin a while ago, and there are things that could have been done better.

Thanks Juan, that helped. Using "bundle update" I was also able to get it to run under Rails 3.1.1. Again, thanks a lot!
Kind regards
Stefan

Hi Juan
Great Job!!  thank you, I got the sample working well, but the seach is not working, how do you implement search and filters? Thank you for your help

Hi Hugo,
I'll be on holiday for a few days, I'll back to you next week.

Thank you Juan, I will really appreciate any idea just a bit piece of code will help thx


Add script to configure application builds

Why:
When we are getting ready to release a new build of the applications we need to update certain characteristics of them. Like the display name and the bundle identifier. Since this depends of each particular HA we would like this process to be automated based on the environment.
This Commit:

Refactor plist reading and writing
Refactor read and write from xml
Add replace string in file helper
Reset android application name to default BT
Update applicationId on build.gradle
Update bundleid on COVIDSafePaths.xcodeproj/project.pbxproj

How to test:

Run the ./bin/set_ha.sh {HA_ABBREVIATION} command and verify that the display names and the bundle identifiers and application id have been updated accordingly.

Co-Authored-By: Devin Jameson<EMAIL_ADDRESS>

Just tested, great work!


Use Throng for Probot Concurrency

We sometimes have huge spikes in request queuing, we only have 5 workers, that may be part of the cause, let's use throng like we did in slack to add more workers on the same nodes to better utilize our resources.
Env Vars
Heroku will calculate WEB_CONCURRENCY for us based on Dyno Ram Size / WEB_MEMORY == WEB_CONCURRENCY. We can also set it manually (which we will do at first to ensure a no-change rollout at first, see below).
Preflight Checklist

[x] Do we have enough redis connections available
[ ] Do we have enough postgres connections available
[ ] Set the WEB_CONCURRENCY env var in heroku to 1 before deploying (this ensures we don't spin up more than 1 worker to start with)
[ ]  Set the WEB_MEMORY env var in heroku to 768 before deploying (this ensures that we have enough memory once we remove the WEB_CONCURRENCY variable.

Redis is a premium-3 like slack, we have enough available connections.

Postgres is a standard-0, which has 120 max connections. The pool size is 5, this means we can support 24 instances (between web and workers).
Queue Workers
We currently have 3 dynos hard-configured (no autoscaling), on 1x dynos (can only support 1 instance per dyno) this means at most we'll use 15 database connections.
Web Workers
We support up to 10 Performance-M Dynos which have 2.5Gb of ram. At 768mb of RAM per instance, this is a max of 3 workers per dyno.
10 dynos * 3 workers * 5 pool size == 150 connections. We will need to decrease the max scaling of the dynos.
Total Budget
Workers: 5 * 3 == 15 connections (budget now at 105 connections)
Web: 105 / 5 == 21 instances / 3 per dyno == 7 dynos max.
New Dyno settings
Worker: Stays the same at 3
Web: Decrease max autoscaling from 10 to 5 (gives us buffer for postgres follower, ad-hoc queries, deploys, etc)


Copy feature

It would be great to have a feature that allows users to copy the results from RunJS directly. For example, a "Copy" button could be added to easily copy the real-time output.

https://github.com/meain/logseq-plugin-runjs/pull/3


Add support for CRISPR homology-directed repair (WIP)

This integrates the frontend changes to allow CRISPR (see PR in backend). The guide RNA is currently submitted as a primer.
TODOs:

Fix the same issue as in #124 for homologous recombination
Add frontend tests

I will merge this. The tests are still missing, but so they are for all sources that take inputs. I will do this next hopefully.

Merging even if tests fail on the cloud. They pass locally. As usual, a problem with NCBI


The evaluation index C(comfort) and the average performance score Γ(score) ?

In the source code, I don't see the evaluation index C(comfort) and the average performance score Γ(score) in the paper. Could you add them?

Hi OcianRvier
We have added these evaluation metrics in test.py.
Good Luck


Contracts: "Invalid Character"

0x042bf805eb946855cc55b1321a86cd4ece9904b2d15f50c47439af3166c7c5e2

No idea what it means or what causes it.

can you reproduce this?

I keep getting the error with these transactions scheduled

I should have enough resources. I assume it's one of the transactions.

With just the military buildings, I don't get the error.

Oh wait, never mind. I do get the same error after clicking approve. It changed to give me that error again.
Maybe something with one of the military buildings?

@ponderingdemocritus Okay, I think I found it. I think it must be something to do with resupplying the storehouse:

The transaction gives me the same error, even just asking to resupply fish and wheat on one realm. I used the "half" button to choose the amount (in case that is relevant).

could it be that the issue is that I was trying to add half a what?

Rounding down the number fixed the issue actually.

yes this looks like it parsing a wrong character for the food - @r0man1337


Cant use POPE

The following error comes out when I try to eval POPE dataset with official LLaVA-v1.5-7B model.

The problem solved after redownloading the dataset.


Lindsey testing

Testing how to submit issues

It worked @LTransue1, thanks. I will close the issue. Let me know if you have any question about entering issues and features requests


Add missing dep to fusion interface

gml_st_ops.cc includes gml_st_ops.h which which includes
fusion_interface.h which includes fusion_interface.h.inc. This is
part of the MLIRGmlStFusionInterfaceIncGen CMake target to which the
dependecy was missing.

@sherhut I would appreciate if you could review.


Scheduler

There's a lot of repeated code for various tasks we run in the background, e.g. the audit log reader, the message_tracker fetcher, etc. Could discord.ext.tasks be adapted for this? If yes -- use that, if not factor out the repeated code into our own module.

Solved in 20c32a96e3ac1ec8245963cbdd3402dc356565f9


Add k8s runAsNonRoot privilege

Describe the bug
Add securityContext.runAsNonRoot of container  cause pod get stuck.
To Reproduce
apiVersion: apps/v1
kind: Deployment
metadata:
  name: opal-server
spec:
  template:
    ... omitted ...
    spec:
      containers:
      - name: opal-server
        image: permitio/opal-server:0.1.21
        securityContext:
            allowPrivilegeEscalation: false
            runAsNonRoot: true

container log:
Failed to load logs: container "opal-server-sandbox" in pod "opal-server-847df9c964-bccr4" is waiting to start: CreateContainerConfigError
according to this Dockerfile: Make opal images use non-root user
I check the docker file and it has USER opal, should I add runAsUser:
if so, what is the opal user Id?
OPAL version

Version: 0.1.21

Hi @WellyHong, the docker images should indeed run as non-root, if i am not mistaken you can refer to the user as opal in any posix compatible system. @roekatz maybe you can take a look?

Hi @asafc ,
I use id to get uid & gid, they are 100 & 101.
Then I add runAsUser: 100 and the container launched well.
Since we use terrascan to detect  security violations, above setting was not conformed to Containers Should Run as a High UID to Avoid Host Conflict policy. ☹
According to this issue, any suggestions would be greatly appreciated.

Hi @WellyHong,
Version 0.1.21 is actually pretty old (latest version is (0.7.1).
On later versions, uid of opal is 1000.
AFAIU runAsNonRoot won't work because it chooses a random UID, and the opal image has some files with opal as owner.
But I believe runAsUser: 1000 should work.
Closing for now... Let us know if you're still having an issue and we'll reopen.

Hi @roekatz, @asafc
thanks for your suggestions, I appreciate it.
now run container with opal-server:0.7.1 and it works normally.
but I face another issue,
the.env file of opal-client-standalone:0.7.1 cannot be loaded correctly.
With 0.1.21, I mount /opal volume and put .env under it,
0.7.1 seems not working properly.
I searched the document and found this topic, it doesn't instruct the .env path.
Could you give me guidance how to mount .env correctly?


Lot's of rate limited requests

I see lots of rate limited requests in the logs of this controller like the ones attached.
I know this has to do with the k8s/client-go discovery cache. I know @negz is working on this and have seen tickets in kubernetes/kubernetes and kubernetes/kubectl.
Does this mean we have to not only solve the discovery cache problem for kubectl, but also for controllers like this one?
I1115 16:57:11.131312       1 request.go:655] Throttling request took 1.040355092s, request: GET:https://<CLUSTER_IP>>:443/apis/cloud.google.com/v1?timeout=32s
I1206 21:42:01.320703       1 request.go:655] Throttling request took 1.197162562s, request: GET:https://<CLUSTER_IP>>:443/apis/microsoft.resources.azure.com/v1alpha1api20200601?timeout=32s
I1206 21:42:11.514747       1 request.go:655] Throttling request took 11.391711778s, request: GET:https://<CLUSTER_IP>>:443/apis/networking.internal.knative.dev/v1alpha1?timeout=32s
I1206 21:42:21.624922       1 request.go:655] Throttling request took 5.194396672s, request: GET:https://<CLUSTER_IP>>:443/apis/database.azure.crossplane.io/v1alpha3?timeout=32s
I1206 21:42:31.682872       1 request.go:655] Throttling request took 1.795218693s, request: GET:https://<CLUSTER_IP>>:443/apis/container.cnrm.cloud.google.com/v1beta1?timeout=32s
I1206 21:42:41.881957       1 request.go:655] Throttling request took 11.993478748s, request: GET:https://<CLUSTER_IP>>:443/apis/crd.projectcalico.org/v1?timeout=32s
I1206 21:42:51.899638       1 request.go:655] Throttling request took 8.589133901s, request: GET:https://<CLUSTER_IP>>:443/apis/security.istio.io/v1beta1?timeout=32s
I1206 21:43:44.499915       1 request.go:655] Throttling request took 1.194056856s, request: GET:https://<CLUSTER_IP>>:443/apis/dataflow.cnrm.cloud.google.com/v1beta1?timeout=32s
I1206 21:43:54.696859       1 request.go:655] Throttling request took 11.391668377s, request: GET:https://<CLUSTER_IP>>:443/apis/microsoft.storage.azure.com/v1alpha1api20210401storage?timeout=32s

I am also running into this issue on OpenShift where the provider is run with an arbitrary UID that can't create the .kube/cache directory. I will attempt to resolve with an emptydir mount for .kube, but I will likely run into https://github.com/crossplane/crossplane/issues/2535

I have same problem which stops this provider completely from working
0927 08:30:05.047549       1 request.go:665] Waited for 14.996834844s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/getambassador.io/v1?timeout=32s
I0927 08:30:15.171452       1 request.go:665] Waited for 1.992119487s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/iam.aws.crossplane.io/v1beta1?timeout=32s
I0927 08:30:25.171700       1 request.go:665] Waited for 11.992086193s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/prometheusservice.aws.crossplane.io/v1alpha1?timeout=32s
I0927 08:30:35.209915       1 request.go:665] Waited for 6.197310081s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/batch/v1beta1?timeout=32s
I0927 08:30:46.031319       1 request.go:665] Waited for 1.197156308s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/prometheusservice.aws.crossplane.io/v1alpha1?timeout=32s
I0927 08:30:56.034724       1 request.go:665] Waited for 11.200484673s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/iot.aws.crossplane.io/v1alpha1?timeout=32s

Would it be possible to provide qps & burst parameters for golang kubernetes client via container arguments (e.g. https://kyverno.io/docs/installation/)?

@negz  - would it make sense to configure the QOS and Burst settings  for the API client here - https://github.com/crossplane-contrib/provider-kubernetes/blob/main/internal/clients/client.go#L60 ?

Actually I think the fix is to upgrade controller-runtime and client-go to the latest versions - I'll push a PR

Thank you all! Are we targeting 0.6.0 for this? Any notional timeline?


Add Signal.Connected

http://wiki.roblox.com/index.php?title=RBXScriptConnection#Connected

Coverage increased (+0.003%) to 97.431% when pulling f7fdae1e70ae847977e2887e4a7477de902804f0 on Kampfkarren:connected into 6d3dd8269bd59fa6b19bd1041870ba085af47804 on LPGhatguy:master.

Huh. I had no idea this API existed.


Msg Icons

This is to partially address #2986

adds SVG version of "smiles" to the message icons
uses the SVG version on topic listings like recent and standard message index.  It will use these as long as the admin has not enabled custom message icons.  Once custom icons are set it will revert to the old .PNG way
does not work (nor did it) for SVG on the display template since that icon is JS linked to allow quick selection and it is simply to much work to fix it for a single icon display
while doing this I noticed that the  MessageTopicIcons.class.php was wired to assume the custom icons were those defined in the topic_listing, however there are some potential problems, such as a custom icon was allowed on a board and then removed from that board, current behavior was that it will still render ... other similar issues that resulted in no icons (missing image).  As such I made several changes to that class as follows:

it loads the custom icons for the given board so it will only render the allowed ones and set the default for wrong/missing/changed ones.  This is a cached call so not much additional overhead.
you can still pass it a custom array to maintain old behavior, although the array index has changed, sooooo
added two get classes, one for url and one for name.  The name is really for svg icons, so again say you enabled custom icons, added some, they were used, then you went back to standard behavior.  Well it would have shown an empty icon but it now shows the default one.
not really about this class but I moved the fetch board message icons to the message icon subs where it seemed like it should live (vs inside editor.subs)
updated the various calls to use the getters vs magic __get

OK thats enough for now @emanuele45 if you could take a look I'd appreciate it!

Looks good to me


Ut/input parser

Unit test for InputParser class.

Codecov Report

Merging #82 (2ca4956) into main (7fee8c0) will increase coverage by 24.18%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##            main      #82       +/-   ##
==========================================
+ Coverage   7.14%   31.32%   +24.18%
==========================================
  Files         16       17        +1
  Lines        448      498       +50
  Branches     208      239       +31
==========================================
+ Hits          32      156      +124
+ Misses       398      227      -171
- Partials      18      115       +97

Impacted Files
Coverage Δ

tests/unit_tests/Parser/InputParser_test.cpp
22.22% <22.22%> (ø)

src/Logger/Exception.hpp
14.28% <0.00%> (+14.28%)
:arrow_up:

src/Logger/Logger.cpp
15.51% <0.00%> (+15.51%)
:arrow_up:

src/Parser/AParser.cpp
50.00% <0.00%> (+50.00%)
:arrow_up:

src/Logger/Exception.cpp
57.14% <0.00%> (+57.14%)
:arrow_up:

src/Parser/InputParser/InputParser.cpp
58.55% <0.00%> (+58.55%)
:arrow_up:

src/Parser/AParser.hpp
100.00% <0.00%> (+100.00%)
:arrow_up:

src/Parser/InputParser/InputParser.hpp
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fee8c0...2ca4956. Read the comment docs.


Question about effects of previous campaigns.

when we are creating the test control, how do we capture and/or exclude the impact of past campaigns(not geo tests) that might have run in some of the markets.

@niramay447  I tried to tag you in my original Issue POST here https://github.com/facebookincubator/GeoLift/issues/199 but i dont think it worked, so I tried through an old/closed post. I hope you can help me, thanks!


build-tests.js

I'm submitting a ...
[ ] bug report
[ ] feature request
[x] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Thank you for sharing this! Do you mind explaining the rationale and need for build-tests.js

Hey @tomdavidson – thanks for opening this issue!
I added a note with some additional explanation in: https://github.com/bitjson/typescript-starter/pull/38/commits/f78fa8abc4a89c41645fc1d54a0307e11c974bf6

Testing
By convention, tests in typescript-starter are co-located with the files they test. The project is configured to allow tests to be written in Typescript and your library to be imported as if it were being used by another project. (E.g. import { double, power } from 'typescript-starter'.) This makes tests both intuitive to write and easy to read as another form of documentation.
Note, tests are compiled and performed on the final builds in the standard Node.js runtime (rather than an alternative like ts-node) to ensure tests pass in that environment. If you are using ts-node in production, you can modify this project to skip test compilation.

Does that answer your question?

Thanks @bitjson . It does and I appreciate your response and the project's help getting me started with TS. I did end up deviating quite abit, including on the testing - https://gitlab.com/td7x/s6

Hey @tomdavidson that looks like a fantastic project, thanks for sharing!
Mind if I link to your project from the readme? https://github.com/bitjson/typescript-starter/commit/f0d349ae70cc15da4aaaf98476094a2bda1e2d92
I've been hoping to add a section of projects using parts from this starter, and yours has some great examples of alternative configurations!

not a problem at all and thanks again for helping me get up and running


Update readme to reflect dropping of NIO?

Hi
Im new to Soto and the ecosystem, so bear with me if I get this wrong!
Since Soto 7 dropped NIO and is using structured concurrency features of Swift, it seems like this repo's readme may need some updating?
If not, feel free to ignore!

Fair comment. We haven't dropped NIO though, it just an implementation detail now and futures no longer appear in our public API


await throws an exception

Await doesn't work, it always thows the same exception (it doesn't matter what I await).
Exception:
MonoPlatform.ts:167
WASM: WASM doesn't support threading
WASM: Unhandled Exception:
WASM: System.TypeInitializationException: The type initializer for 'System.Threading.Timer' threw an exception. ---> System.TypeInitializationException: The type initializer for 'Scheduler' threw an exception. ---> System.SystemException: Thread creation failed.
MonoPlatform.ts:167 WASM:   at System.Threading.Thread.StartInternal (System.Security.Principal.IPrincipal principal, System.Threading.StackCrawlMark& stackMark) <0x19838a0 + 0x00028> in <1463ae4ffad443ad96b6f1e233743309>:0
WASM:   at System.Threading.Thread.Start (System.Threading.StackCrawlMark& stackMark) <0x1982db8 + 0x00052> in <1463ae4ffad443ad96b6f1e233743309>:0
Sample code:
@using System.Threading.Tasks
@(Layout<StandaloneApp.Shared.MainLayout>())
Hello, world!
Run
Result: @result
@functions
{
    string result;
    public async void GetData()
    {
        await Task.Delay(1000);
        result = "ahoj";
    }
}

Yes, its a known issue as stated in #140

We'll track this with #140.

Note that async/await itself does work. You can use them with TaskCompletionSource, for example. What doesn't yet work on Mono for WASM is any task whose implementation involves a timer (which is most of the useful ones).

Thank for the response.
Any idea how to download data as string over http in the current state?
@SteveSandersonMS

Any idea how to download data as string over http in the current state?

Yes, it's possible to implement your own HttpClient-equivalent, using a combination of TaskCompletionSource and the existing JS interop APIs. Until you're used to the existing low-level JS interop APIs this is very tricky so we wouldn't expect people to figure this out on their own. Here's an example of how it can be done: https://gist.github.com/SteveSandersonMS/ba34011dd4ee8bb3021c8837ff68ef28
Notes:

There isn't yet a public JSON-parsing API in the Blazor .NET package. There is an internal one that we will make public later as part of implementing built-in HttpClient support. So for now, you're limited to fetching plain strings. Some third-party JSON parsing packages might just plug in and work, but I doubt that Json.NET will do because it has such sophisticated dependencies on low-level reflection.emit features (and even if it does work, it will be slow because of that).
You might want to put a try/catch around any calls to GetStringAsync (and log any exception to the console) because otherwise if there's an exception, it will just silently do nothing. There isn't yet a built-in global event handler for async code.

This might be a good json parsing library to use in Blazor.
https://github.com/facebook-csharp-sdk/simple-json


Improve DataFrameIngestor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (63081fd) to head (5e38aae).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines          820       819    -1
  Branches        89        89
=========================================
- Hits           820       819    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


macvlan subinterface documentation does not work on Ubuntu 16.04

File: engine/userguide/networking/get-started-macvlan.md, CC @mistyhacks
I have been using the macvlan adapter with great success for awhile now on Ubuntu 16.04 with Kernel 4.4.0. Today however, I needed my host and my container able to communicate.
Underneath "Communication with the Docker host over macvlan", it says:

A macvlan subinterface can be added to the Docker host, to allow traffic between the Docker host and containers. The IP address needs to be set on this subinterface and removed from the parent address.

This sounds like exactly what I need, but the command ip link add mac0 link $PARENTDEV type macvlan mode bridge is not enough for my system (Ubuntu 16.04). I still need commands for moving the IP address to the subinterface.
This blogpost and https://github.com/docker/libnetwork/issues/2008 and this question had more commands than the official docs, but I was still unable to ping after running them:
sudo ip link add mac0 link $PARENTDEV type macvlan mode bridge
sudo ip addr add $PARENTIP/24 dev mac0
sudo ifconfig mac0 up

This blogpost looks the most complete with some route flushes, but it also failed to work for me.
What am I missing? ip route flush and ip route add maybe?
For now I am just going to edit /etc/network/interfaces like the docs suggest and see how that goes.
Also, there is a minor typo at the end of that section. "For more on Docker networking commands, see Working with Docker network commands](/engine/userguide/networking/work-with-networks/)." -> "For more on Docker networking commands, see Working with Docker network commands."

Awesome thanks. I've got my system working after that slight modification to /etc/network/interfaces. Using pre-up/pre-down is a much better pattern then the other blogposts were using.

We should also add a note about IPv6. It needs to be disabled on the parent interface.
I added this to /etc/sysctl.d/99-local.conf:
net.ipv6.conf.eno2.disable_ipv6=1
net.ipv6.conf.mac0.disable_ipv6=0
net.ipv6.conf.mac0.accept_ra = 2

The following ifcfg network interface adapter configurations has worked well concerning macvlans on RHEL variants and should work on Ubuntu as well.
Macvlan 802.1q Trunk Bridge Mode example usage
https://docs.docker.com/engine/userguide/networking/get-started-macvlan/#macvlan-8021q-trunk-bridge-mode-example-usage
You'll need to create child/slave interfaces specific to each vlan ontop of eth0 or whatever your network adapter is named. Something to the effect of eth0.1, eth0.2 where eth0.1 is vlan 1 and eth0.2 is vlan 2 which should resolve this issue. You would also need to ensure the gateway lives on both vlan networks as well. Ensure to replace XXX.XXX.XXX.XXX fields with your specific values.
Example configuration:
# cat ifcfg-eth0

BOOTPROTO=none
DEFROUTE=no
PEERDNS=no
PEERROUTES=no
NAME=bond0
ONBOOT=yes
DNS1=<DNS1>
DNS2=<DNS2>
USERCTL=no
NM_CONTROLLED=no

# cat ifcfg-eth0.1

TYPE=Ethernet
BOOTPROTO=none
DEFROUTE=no
PEERDNS=no
NAME=eth0.1
DEVICE=eth0.1
ONBOOT=yes
IPADDR=XXX.XXX.XXX.XXX
NETWORK=XXX.XXX.XXX.XXX
NETMASK=XXX.XXX.XXX.XXX
GATEWAY=XXX.XXX.XXX.XXX
USERCTL=no
NM_CONTROLLED=no
VLAN=yes

# cat ifcfg-eth00.2

TYPE=Ethernet
BOOTPROTO=none
DEFROUTE=no
PEERDNS=no
NAME=eth0.2
DEVICE=eth0.2
ONBOOT=yes
IPADDR=XXX.XXX.XXX.XXX
NETWORK=XXX.XXX.XXX.XXX
NETMASK=XXX.XXX.XXX.XXX
GATEWAY=XXX.XXX.XXX.XXX
USERCTL=no
NM_CONTROLLED=no
VLAN=yes

Hmm. Not surly about environment that you facing problem. But normally if you running macvlan feature on public cloud provider that will denied this communicate as baseline. And also if you running on your on-premise farm (Such as ESXi, OpenStack etc). You also need to set "promiscuous mode" before you operate on Host (Docker Host) inside

Macvlan docs were written in #5936 so take a look. Also, yes, if you are on a cloud provider you probably can't use Macvlan. If you are still running into trouble, consider asking on https://forums.docker.com/. Thanks!

Thank you!

On Feb 7, 2018, at 11:36 AM, Misty Stanley-Jones<EMAIL_ADDRESS>wrote:
Macvlan docs were written in #5936 so take a look. Also, yes, if you are on a cloud provider you probably can't use Macvlan. If you are still running into trouble, consider asking on https://forums.docker.com/. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[rancher-compose] Error when building image from URL on RancherOS hosts

@djiit filed in the rancher-compose repo:
I don't know if it's related to rancher or rancherOS... Sorry if I'm in the wrong repo.
I tried to use rancher-compose with a build: instruction set to a HTTP URL (ending with .git).
My only declared host is running RancherOS and I got this error when using rancher-compose up:
66a33137-c63a-4931-b839-c7a1ab46ee3e : 404 Client Error: Not Found ("Error trying to use git: exec: "git": executable file not found in $PATH ()")

Did I miss something ? Should I install git in RancherOS ?

@ibuildthecloud commented that
Unfortunately git based builds don't work on Rancher v0.3.x. This will be addressed in RancherOS v0.4, but we have yet to release v0.4.

Verified in v0.47.0 of Rancher using v0.4.1 of RancherOS that this is no longer an issue.

I have same problem using Rancher v0.51.0 and RancherOS v0.4.2, is this problem still not fix?

Yes, I verified it in v0.47.0 and RancherOS v0.4.2. This has been fixed. What error are you getting?
Can you provide your git URL? Are you sure it's a proper dockerfile?
This is the URL that I used and my docker-compose.yml file.
testurl:
  build: https://gist.githubusercontent.com/deniseschannon/3276610b006382da655b/raw/11690eefe15de38e82d40d559f0db641722afb6c/buildtest

In the URL, this is what it shows
FROM nginx

CMD ["nginx", "-g", "daemon off;"]

I test this feature using my customize nginx, 'git@github.com:elct9620/nginx-pagespeed.git'
I am sure when I using ubuntu as host and install fit on host, it can build correctly. But if I using rancheros, I got this error.

I think you need to point it directly to the Dockerfile so the build would need to be pointing at
https://github.com/elct9620/nginx-pagespeed/blob/master/Dockerfile

Direct point Docket can work, but if I specify some repo need add some file from filesystem, I need to point fit repo and let rancher clone it to build correctly image. This is my expected feature when I reading document says " support fit repo"

Per the docs, your URL needs to be to a git that is compatible with the Docker Remote API. Have you tried doing a build pointing to your git for docker-compose? If it works in docker-compose, it will work to build for rancher-compose/
http://docs.rancher.com/rancher/rancher-compose/build/

I didn't tested on docker-compose, but if I using Ubuntu instead RancherOS, it is working.
I will test it using docker-compose when I can use my computer, and report it worked or not.

This is broken on rancheros v1.1.0:

$ git
-bash: git: command not found

and in Rancher:

(Expected state running but got error: Error response from daemon: failed to init repo at /var/lib/docker/tmp/docker-build-git508179416: : exec: "git": executable file not found in $PATH)

docker-compose file for reference:
version: '2'
services:
  kibana-wazuh:
    build: https://github.com/someone1/kibana-wazuh-xpack.git
    environment:
      ELASTICSEARCH_HOST: elasticsearch
      TZ: America/New_York
    external_links:
    - ESCluster/es-tribe:elasticsearch
    ports:
    - 5601:5601/tcp
    labels:
      io.rancher.container.pull_image: always
      io.rancher.container.hostname_override: container_name


feat: emphasis on the database engine error message

RFC
when bubbling up error messages surfaced by the datbase, we prefix with
"{engine} error:". In this PR we make the error message capitalized and
bold. To make it bold we introduce the ability to use markdown in error
messages. This also fixes issues where "{error_msg}"
shows up inside the error message. We've seen Presto and transport layer
generate 50* pages that have html. The react-markdown component here
removes all tags.

I've considered similar fixes before, but have punted because instead of overloading the single string error message with metadata/styling, I think it'd be a better path forward to make the error message a structured payload, something like:
{
  title: "error title",
  message: "message",
  link: "optional link",
  stacktrace: "optional stacktrace",
}

Then we could always render it appropriately on the front end.
Note that we could still store the error in the db as a string, but just pass a structured error back to the frontend

Yeah, I agree markdown might be overkill here, but it'd be nice to squeeze inline links and lightweight formatting somehow. Also unclear how to handle stripping the html tags. Maybe that just needs to be handled upstream...

We could pass down html and use Interweave to render it (like John did in his SIP-15 work) but i'm not sure if that's a great path forward too... Perhaps the backend sends back unique error codes and the frontend can render specific errors with inline links/styles based on the code


Add Year type

... similar to Year from Java 8.

Issue moved to SpineEventEngine/time #11 via ZenHub


require is not defined when importing a node_module that imports a CSS file

Describe the bug
When importing a react component that imports a CSS file, vite fails with the message:

Uncaught ReferenceError: require is not defined

If you dig into the stack trace, you'll see that the require statement is from an imported .css file (line 8 in this image):

This issue:

Does not occur when running with create-react-app or storybook
Occurs with any NPM dependency that imports a .css file. We discovered this issue with an internal component library, originally, but were able to reproduce it with react-date-picker, which also imports a .css file.

I expected this to work, as the documentation references being able to manage imported static assets like this: https://vitejs.dev/guide/features.html#css. But, perhaps there's an issue when the CSS import occurs in a vendor/node_module.
Reproduction
https://github.com/blimmer/show-vite-issue
git clone https://github.com/blimmer/show-vite-issue.git
cd show-vite-issue
npm ci
npm run dev

You'll observe the error in the console when you visit localhost:3000:

System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
  System:
    OS: macOS 11.3.1
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 32.71 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.1.0 - ~/.asdf/installs/nodejs/16.1.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.11.2 - ~/.asdf/installs/nodejs/16.1.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Firefox: 89.0
  npmPackages:
    vite: ^2.3.0 => 2.3.2

Used package manager:  npm
Logs

 vite build --debug
  vite:config bundled config file loaded in 84ms +0ms
  vite:config using resolved config: {
  vite:config   plugins: [
  vite:config     'alias',
  vite:config     'react-refresh',
  vite:config     'vite:dynamic-import-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'rollup-plugin-dynamic-import-variables',
  vite:config     'vite:import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     minify: 'terser',
  vite:config     terserOptions: {},
  vite:config     cleanCssOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     brotliSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null
  vite:config   },
  vite:config   configFile: '/private/tmp/show-vite-issue/vite.config.ts',
  vite:config   configFileDependencies: [ 'vite.config.ts' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/private/tmp/show-vite-issue',
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object] ] },
  vite:config   publicDir: '/private/tmp/show-vite-issue/public',
  vite:config   cacheDir: '/private/tmp/show-vite-issue/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   isProduction: true,
  vite:config   server: { fsServe: { root: '/private/tmp/show-vite-issue', strict: false } },
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   optimizeDeps: { esbuildOptions: { keepNames: undefined } }
  vite:config } +5ms
vite v2.3.2 building for production...
✓ 121 modules transformed.
dist/assets/favicon.17e50649.svg   1.49kb
dist/assets/logo.ecc203fb.svg      2.61kb
dist/index.html                    0.57kb
dist/assets/index.0673ce28.css     0.76kb / brotli: 0.40kb
dist/assets/index.2146aa06.js      0.94kb / brotli: 0.38kb
dist/assets/vendor.d4d14e00.css    4.08kb / brotli: 0.91kb
dist/assets/vendor.771a2d12.js     228.14kb / brotli: 53.29kb

Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Vite doesn't use require, did you try import instead?

@Shinigami92 the upstream project (react-date-picker) is a dependency we don't control, and is still shipping CommonJS/require based code/output.
So we expected vitejs to be able to (while ESM-ifying this dependency) rewrite the require-a-css-file statement just like it is rewriting the require-a-JS file statements.
Is this possible? As far as we understand, vite is capable of bundling/importing CSS directly within our application code, with an import just like you gave, but we need to have the import (and rewrite) happen in this node_modules/react-date-picker dependency.

as a workaround, you can disable the require call in react-date-picker and try import the css file in your code:
index.html
<head>
<script>window.require = () => {}</script>
<script type="module" src="src/main.js"></script>
</head>

src/main.js
import 'react-calendar/dist/Calendar.css'

// ...

@hronro yeah, we're using patch-package to do basically that for now (deleting that line and importing the css ourselves). Thanks for the input!

@Shinigami92 you'd added the bug: upstream label; this is not a bug in the upstream library. This bug is that vitejs doesn't support dependencies that import css files.

You can try this plugin https://github.com/originjs/vite-plugins/tree/main/packages/vite-plugin-commonjs
import { defineConfig } from 'vite'
import reactRefresh from '@vitejs/plugin-react-refresh'
import { esbuildCommonjs } from '@originjs/vite-plugin-commonjs'

export default defineConfig({
  plugins: [reactRefresh()],
  optimizeDeps:{
    esbuildOptions:{
      plugins:[
        esbuildCommonjs(['react-calendar','react-date-picker'])
      ]
    }
  }
})

@ygj6 thanks for the link to that plugin! I have a naive question, but I thought that vitejs did "automatic ESM-ification" of all of my dependencies automatically (via esbuild)? Or is that not right?
Just wondering why I'd have to configure the vite-plugin-commonjs plugin for these specific dependencies.
Thanks!

Vite use esbuild for pre-bundling. However, esbuild will not transform require https://github.com/evanw/esbuild/issues/506.
The vite-plugin-commonjs plugin will replace require to import, which can solve most scenarios (NOT All).

Can someone clarify that we must configure vite-plugin-commonjs for all packages that use require?  I have a dependency (okta-auth-js) with a sub dependency (js-cookie) that uses require.
My dev build works fine, but I get this error in the production build.

vite-plugin-commonjs only works in vite dev mode, theoretically vite can support require in build mode.
Refer to this issue https://github.com/originjs/vite-plugins/issues/9

@ChuckJonas do you found any fix?  I have same problem
vendor.53605c38.js:7 Uncaught ReferenceError: require is not defined

@gonzalojpv nope, I went back to react-scripts for the time being.  It sounds like it's something that the library itself might need to address and I can't afford to get blocked by unsupported dependencies.

@ygj6 Hey i want use require in middle of file but import only support at top of file. so how do we handle this things.
https://prnt.sc/QicqzCw7GWX7

Looks like the error comes up because esbuild pre-bundles react-date-picker into:
// node_modules/.pnpm/react-date-picker@8.4.0_react-dom<EMAIL_ADDRESS>var require_entry = __commonJS({
  "node_modules/.pnpm/react-date-picker@8.4.0_react-dom@17.0.2+react@17.0.2/node_modules/react-date-picker/dist/entry.js"(exports) {
    "use strict";
    Object.defineProperty(exports, "__esModule", {
      value: true
    });
    exports["default"] = void 0;
    __require("/Users/bjorn/Work/repros/show-vite-issue/node_modules/.pnpm/react-calendar@3.7.0_react-dom@17.0.2+react@17.0.2/node_modules/react-calendar/dist/Calendar.css");
    var _DatePicker = _interopRequireDefault(require_DatePicker());
    __require("/Users/bjorn/Work/repros/show-vite-issue/node_modules/.pnpm/react-date-picker@8.4.0_react-dom@17.0.2+react@17.0.2/node_modules/react-date-picker/dist/DatePicker.css");
    function _interopRequireDefault(obj) {
      return obj && obj.__esModule ? obj : { "default": obj };
    }
    var _default = _DatePicker["default"];
    exports["default"] = _default;
  }
});

Where __require is the normal CJS require. Ideally, this should be an import (top-level) so that it goes through Vite's asset pipeline. Not really sure how to fix this though.

@ChuckJonas did you try opening an issue on okta or js-cookie side? I have exactly the same issue with the same set of libs

Hi! I have the same problem with the "flickity" library

The solution I've used for okta has been to use `patch-package` to patch the package with the following change:

@ygj6 thanks for the link to that plugin! I have a naive question, but I thought that vitejs did "automatic ESM-ification" of all of my dependencies automatically (via esbuild)? Or is that not right?
Just wondering why I'd have to configure the vite-plugin-commonjs plugin for these specific dependencies.
Thanks!

Same issue! Resolved by vite configuration instead of configure any third party dependency! Include dep which you intend to be auto transformed like below:
export default defineConfig({
  optimizeDeps: {
    include: ['linked-dep']
  },
}

Referenced document: monorepos-and-linked-dependencies
My understanding : vite "automatic ESM-ification" happened during dep-pre-bundling, and vite could not understand all dep senario (eg: mono or linked dep etc), so it provide a manual channel for us to config which to pre-bundle

same issue for package https://github.com/asabaylus/react-command-palette

happens to classnames also
Any updates?

This happens not only for css files but also for js files wich are loaded by require.
In an ideal world we would rewrite this. In real world this is a big problem wich needs to be solved by the tool...

I'm using Vue/Vite with Electron, and require('path') does not work in the render process with Electron window contextIsolation: false and nodeIntegration: true set.

add transformMixedEsModules to vite.config
build: {
    commonjsOptions: {
      transformMixedEsModules: true
    }
  }

@ChuckJonas do you found any fix? I have same problem
vendor.53605c38.js:7 Uncaught ReferenceError: require is not defined

I solved these error on my project doing the insertion above on your index.html :
`

`


Ability to delete folders

It would be nice if we would be able to delete folders from UI. In a multi user environment it gets messy after some time :)
cc @vidma @andypetrella

same as #928
P.S. beware currently it'd allow anybody to delete any folder.


[Feature Request] Custom default value for extracted keys

Hi, is it already possible to have some kind of default value for all extracted keys? Some kind of placeholder so that I spot values in the template that are missing.

It is not possible at the moment. For now I would suggest using a custom Missing Translation Handler: https://github.com/ngx-translate/core#how-to-handle-missing-translations

I am already using a custom handler for missing translations. The use case is a different one tho. That handler only sees strings that are not yet extracted. What I need is a default value for strings that already have been extracted. It's not high priority but I guess would be useful for some ppl like me.

Ah, I don't experience this because I use a custom loader for po-files, and I don't load/add strings with empty translations.
https://github.com/biesbjerg/ngx-translate-po-http-loader/blob/master/src/index.ts#L49

+1

For my use case it also makes a lot more sense to have a default value of null (which results in keeping the original string when a translation is missing), rather than "" (which results in the whole string being omitted). Then again, it's one find and replace every time I update the translation files.

Replacing empty strings with null can be done with a simple node script:
const fs = require('fs');
const path = require('path');

const config = {
  dir: './src/assets/i18n' // <-- your json translations directory
};

fs.readdirSync(config.dir).forEach(file => {
  if (path.extname(file) === '.json') {

    const filePath = `${config.dir}/${file}`;
    const json = fs.readFileSync(filePath, 'utf-8');
    const obj = JSON.parse(json);

    Object.keys(obj).forEach(key => {
      if (obj[key] === '') {
        obj[key] = null;
      }
    });

    const str = JSON.stringify(obj, null, '\t');
    fs.writeFileSync(filePath, str, 'utf-8');

  }
});


The new icon sacks (on my blue desktop) - revert to the old one

VSCode Version: Code 1.17.0 (be377c0faf7574a59f84940f593a6849f12e4de7, 2017-10-04T23:45:46.804Z)
OS Version: Windows_NT x64 10.0.10586
Extensions:

Extension
Author (truncated)
Version

Bookmarks
ale
0.16.0

vscode-firefox-debug
hbe
0.16.1

debugger-for-chrome
msj
3.3.1

Steps to Reproduce:

Reproduces without extensions: Yes/No

Dup of https://github.com/Microsoft/vscode/issues/35783


profile nickname should be unlinked from username@hostname:port

Profile nickname shouldn't change when username hostname or port is changed.
I can't count how many times I've made a minor change to username@hostname:port and end up having to rewrite the nickname all over again.

Yes, I've found that annoying enough I've just cloned the repository to attempt a fix.
I think if the nickname was the same as the original username@hostname[:port] then it should be updated, otherwise not.

Alternative viewpoint:  Completely changing the new nickname, when the user@hostname is modified, makes it less likely that someone can quickly (or even inadvertently) change the user@hostname without it being noticed.

Like a date modified time stamp on files? It should take up a different data field that isn't user modifiable through the interface. When using send intents, you wouldn't want the nicknames changing.

Hmm, in the original design for this component, after a nickname was changed by the user, any change to the hostname, port, or username would not change the nickname. It seems that this is not what was implemented.


Underlying input width

Hey, first off thank you so much for the library - I appreciate how much effort has gone into the a11y complexities of this design pattern.
Currently the underlying <input> has an inline style with width: 200% - and this is not overridable with the inputStyle class as it's defined after the spread of inputStyle.
I noticed that when using a password manager like 1Password, it causes the little 1Password icon to appear quite far off where the dummy input appears visually:

I can override the input width by smacking a !important on my own defined class e.g. width: 120% !important, but before I commit to this solution do I risk breaking something that I'm not aware of? It seems okay so far, but just want to double check.
Cheers!

Yep I don't think 200% is necessarily required, but the width needs to be larger for the inputs to line up
Maybe text-indent:0 is a solution??
https://twitter.com/drwpow/status/1496896451041021971?s=21&t=C6vuw4E1yZo4CkV2v4BvzA

It'd be great to find a solution that makes this less obvious / unneeded though

Would it work to just set it to something like 120% so it's less wacky?


Ring+nightly issue

Crate name
solana-client, but other crates also affected.
Build failure link
https://docs.rs/crate/solana-client/1.10.4, https://docs.rs/crate/solana-client/1.9.14
Additional details
Solana monorepo v1.9.14 and v1.10.4 docs were affected by this issue: https://github.com/briansmith/ring/issues/1469
Is there a way we can go through and queue the failures for rebuild?

@CriesofCarrots I just queued both releases, see https://docs.rs/releases/queue .
@Nemo157 was scraping the logs for failures ( see https://github.com/rust-lang/docs.rs/issues/1703#issuecomment-1082887581 ) and somehow this slipped through.

Great, thank you, @syphar and @Nemo157 !
I think some of the other solana- crates may be affected, but I haven't audited yet. May I comment them here as I find them?

May I comment them here as I find them?

Yeah, that I can definitely do

It looks like most of the crates in our v1.9.14 and v1.10.4 releases were affected, but here are the ones I'm most interested in having rebuilt, if possible:
solana-cli
solana-core
solana-geyser-plugin-interface
solana-geyser-plugin-manager
solana-gossip
solana-ledger
solana-program-test
solana-rpc
solana-test-validator
solana-validator
It looks like there's a different docs build issue with the v1.9.15 and v1.10.7+ versions of most of those crates; I assume it's our bug.
Anyway, thank you!

@CriesofCarrots I just queued both versions for all these crates, see https://docs.rs/releases/queue

I assume the builds are fine now.
Feel free to reopen this issue if not.


Vickel: Watch exactnetworthe.com

Vickel requests the watch of the watch_keyword exactnetworthe\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

exactnetworthe\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


Carousel with autoplay and without snap, it's possible?

Description
Hey team,
I have a Figma design that I need to move to Nuxt. This design has a carousel that slowly moves to show the other images, but without snap. I didn't see this config on docs either on demos.
It's possible?

Sure, the snap is actually defined in the CSS config of the carousel: https://ui.nuxt.com/components/carousel#config
You can remove it by defining the counter-value of the snap property on this property


Support API versioning

Candidate for 0.9.0
(breaks backward compatibility, because properties.modules.validator should now be the actual express middleware and not just a validator to be passed as `custom_validators' option)

Coverage decreased (-1.3%) to 19.072% when pulling af2b3a0469fb84256d392374ec28d26e0dd0a924 on error_management into 214c522f013521811cb26406edeca363e1e3f3a8 on master.

Looks nice, needs to update minor.


What should I do？Critical libmamba [json.exception.type_error.302] type must be string, but is null

command:mamba install RepeatMasker
https://mirrors.bfsu.edu.cn/anaconda/pkgs/main/n..            No change
anaconda/pkgs/r/noarch                                        No change
https://mirrors.bfsu.edu.cn/anaconda/pkgs/free/n..            No change
https://mirrors.bfsu.edu.cn/anaconda/pkgs/free/l..            No change
anaconda/cloud/bioconda/noarch                                No change
anaconda/cloud/bioconda/noarch                                No change
anaconda/cloud/bioconda/linux-64                              No change
https://mirrors.bfsu.edu.cn/anaconda/pkgs/main/l..   7.6MB @ 388.9kB/s 19.8s
anaconda/pkgs/r/linux-64                                      No change
anaconda/cloud/bioconda/linux-64                              No change
anaconda/cloud/conda-forge/noarch                   18.2MB @ 550.7kB/s 33.2s
anaconda/cloud/conda-forge/noarch                   18.2MB @ 401.6kB/s 44.2s
anaconda/cloud/conda-forge/linux-64                 43.7MB @ 738.8kB/s 60.0s
anaconda/cloud/conda-forge/linux-64                 43.7MB @ 728.8kB/s 1m:0.7s
critical libmamba [json.exception.type_error.302] type must be string, but is null

Like I say, you are opening issue on a wrong repository. You should close this issue since your problem is not related to this deep learning model's repository.
And maybe you can open issue on the repo links that i provide


[Identity] Disable live service principal tests

https://github.com/Azure/azure-sdk-for-python/issues/35957

API change check
API changes are not detected in this pull request.


Why the separate call to hasRelated?

I just read through resource.js (which was a real pleasure - such nice code). It wasn't clear to me why there needs to be a separate call to hasRelated to register the relationships (instead of having hasOne and hasMany do that). I suspect I'm missing a consideration in your design. Would you mind explaining?

@barelyknown at first I didn't use the hasRelated method only a relationships object. later I found a need to setup the object so I added this method to setup the relationships object. but I'm open to changing that, it came it mostly to make things work. I still like the idea of declaring the relationships object in the resource prototype. A JSON API resource has props for id, type, links, relationships, attributes. The hasOne and hasMany setup the computed properties using a promise proxy to fetch the related objects. Perhaps hasRelated() should just become relationships() that would be more inline with the definition of a resource that is represented by the JSON API.  I considered avoiding it altogether and using the hasOne and hasMany to setup the relationships' (links) objects with { links: {}, data: null }, see https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/addon/models/resource.js#L160-L170

It felt to me like it should just be relationships() and that hasOne() and hasMany() should setup the relationships object using newRelation(). Otherwise, users might be confused about why they have to declare the relationship twice.

@barelyknown the computed properties don't access the model (this) until a get is called so I was concerned that I needed to setup the relationships straight away so if the resource is serialized the relationships part of the resource would be accurate. At first it seem odd to declare the releationships then also the related proxies to those related resources but essentially they are two things once is for the structure of the resource's relationships objects and the other (hasOne/hasMany) is for actual proxied (related) resources.

It seems like there should be something above hasOne()/hasMany() and hasRelationships() that sets up the proxy and adds to the relationships. Maybe that's too much "magic" and doesn't matter much, but it seems like now is the time to talk about the API. I also wanted to make sure that I understood why you made the choice (and I do).

@barelyknown I'll put the change in the next release to use only hasOne() hasMany() and setup the reltationships object during init.


New API version

TV-Headend offers a new API version. The actual release does not support this version. Until I've checked the dependencies you habe to wait to update to the latest tvh.

Latest API version is 18. If someone can confirm that this release works with 18 without any changes I can update it asap.

To my knowledge, the latest is v22, and I think 4.0 requires minimum v20 support, but i could be wrong.
https://tvheadend.org/projects/tvheadend/wiki/Htsp

@Daegalus that looks to be the HTSP API which is the new and preferred method of interacting with TVH but this channel uses the HTTP API which apparently was updated from version 15 to version 18 recently. At least that's my understanding of it. I'm not sure if Plex supports HTSP streams.

I've added a detection for ">=" version 15... That's ok for the moment.


cmorize_obs satellite-lai-fapar

Making a start on:
https://cds.climate.copernicus.eu/cdsapp#!/dataset/satellite-lai-fapar

For info. @BenMGeo I'm working on this, should be finished this week.

@valeriupredoi : I do some regridding (I have to write to disk) in the CMORization script. Is there a way to access the ESMValTool workdir from this CMOR script? It is not included in the cfg dictionary passed to the cmorization function.
def cmorization(in_dir, out_dir, cfg):

yes, we can make _run_pyt_script() in cmorize_obs.py accept an extra argument as the user configuration file from where you can extract cfg['work_dir']. You can do that yourself, or you want me do it? :beer:

but then again, that work_dir may not exist unless there was a proper run of the esmvaltool executable so that optional argument needs a check on os.path.isdir(work_dir)

Thanks @valeriupredoi !  I think it is best to maybe do this in a separate branch? I will create a separate issue, like that others can comment on it before we proceed further. I continue the CMORization, and for now, will just write the files in the rawobsdir which is fine for now.

sounds like a plan Batman :bat:

Merged, so can be closed :)


A more descriptive error message for remote HHVM

Show a more descriptive error message if the connection to the remote ssh/docker HHVM server fails.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bug with norm

The norm function is giving an error because  norm_sqr is returning a negative value. Here is the case:
cl    = CliffordAlgebra(:CGA2D)
mv  = -4.0×e1e₊-4.0×e2e₊-4.0×e1e₋+4.0×e₋e2-2.0×e₊e₋
norm_sqr(mv) # returns -2

That's not really a bug. I am using the most commonly used definition of a norm in Clifford algebras, and for this definition there is no real norm for all vectors if the underlying quadratic form of the algebra has negative eigenvalues. You could modify the definition by adding an abs() in norm_sqr(), which would still give you a proper norm, but you'd make the norm less useful in a number of situations.
If you really want an imaginary result, then you can use the commit I've just made which enables a special case treatment for algebras with negative eigenvalues. In this case norm() will return a complex number instead of a real one. But it will always do that, even if the actual result is real.
I hope this solves your problem.

Perfect! Thanks a lot for all the answers!


git ignoring direnv files to support per folder vars like IMG_DISABLE_EMBEDDED_RUNC

Signed-off-by: Noel Georgi<EMAIL_ADDRESS>

Hmm that would cause to whitelist files like .dockerignore, .travis.yml? What do you say?

Can you not make this part of your global gitignore?

.??*
!.dockerignore
!.gitignore
!.travis.yml

But probably global gitignore is better

Yup sure, https://github.com/genuinetools/img/pull/112#issuecomment-394156890 . Most of my projects use direnv , thought it might be a god option to push upstream


Render metadata entityattribute

Will require rebase after merge of #13 before this is merged.

Derp - this should be against develop


Add verifiable signature

Secp contains two classes of signatures: recoverable and unrecoverable.
Prior to this commit, only the recoverable variant was used. However,
the consensus will require signature verification, so the introduction
of the two classes of signatures is required.

I am currios what is difference bitween recoverable and unrecoverable signatures is it only on parity V bytes?
Second thing, could we do signature verification as recovery of public key and and comparison if that public key matches some of the validator? Wouldn't that mean we could only use one type of signature format.

Seconding that I'm not sure why unrecoverable signatures are needed.

Recoverable signatures encodes the recovery id bits whereas unrecoverable doesn't.
We need 2 bits for the recovery id. If we happen to have a spare bit in the encoding scheme, then we might have a single type.
Need to review that in the lazyledger specs.

You only need 1 bit for v. See: https://github.com/FuelLabs/fuel-specs/blob/937190e10396c15e750e0e8b57eb877d9c1767e4/specs/protocol/cryptographic_primitives.md#public-key-cryptography

@adlerjohn that is correct! secp256k1 uses 2 bits but then its negligible the we actually need the second one.
https://github.com/rust-bitcoin/rust-secp256k1/blob/7a3736a0f9d3481aeaaf8295f72995199f301464/src/ecdsa/recovery.rs#L41
I'll convert to a single signature object and always truncate that bit + perform a more comprehensive test.

@adlerjohn @rakita structure simplified here: https://github.com/FuelLabs/fuel-crypto/pull/2/commits/7e84db509b678d91db5357ee9142063ca1eb1729
I also added the release flag to the CI tests because now they are quite heavy. We perform ~1k sign/recover/verify

TBH I'm divided if we should PublicKey::verify(self, Signature) or Signature::verify(self, PublicKey). I wouldn't like to provide the method in both because this would lead to divergent library usage
secp256k1, for instance, uses a wrapper. Thoughts?

Second thing, could we do signature verification as recovery of public key and and comparison if that public key matches some of the validator? Wouldn't that mean we could only use one type of signature format.

I will need some clarification. We have Signature::recover that will return PublicKey, and this is the public key of the validator. We test that here: https://github.com/FuelLabs/fuel-crypto/blob/47c5bba7e7c7882cd1b2b94299e0fe80b0971559/tests/signature.rs#L19-L21
By some you mean a set of validator public keys given a single signature?

One alternative is to move both sign and verify to the Signature

Personally prefer that.

I will need some clarification.

@rakita (please correct me if I'm wrong) was just saying that we only need one type of signature, the recoverable signature.

I will need some clarification. We have Signature::recover that will return PublicKey, and this is the public key of the validator. We test that here:
https://github.com/FuelLabs/fuel-crypto/blob/47c5bba7e7c7882cd1b2b94299e0fe80b0971559/tests/signature.rs#L19-L21
By some you mean a set of validator public keys given a single signature?

Was litlle bit confused with two types, this is what i was pointing to ^^. Validating again is redundent.