Visualize task graphs using ipycytoscape

This adds a new graph visualization engine based on ipycytoscape. Right now it's pretty much a re-implementation of the graphviz visualizer, but with zooming and panning. However, there are a few things that this could be more useful for in the near future.

The ability to run in pyodide without compiling graphviz to WASM (cf. #9053)
More interactivity, especially with different coloring schemes and layouts.
The possibility to add richer tooltips/popups (cf. #9069)

[x] Closes #7301
[x] Tests added / passed
[x] Passes pre-commit run --all-files

This is really cool! 🤩 Thanks for working on this Ian 🙏

are there other packages we should be considering?

Perhaps there are. I chose cytoscape for this primarily because (1) it is a well-supported JS library, (2) python bindings for it already exist through ipycytoscape, and (3) it already works in pyodide. But I wouldn't be averse to investigating others if they had additional benefits.

The only alternative that stood out to me from reading that issue was ipyelk. Did we evaluate that one? If so, what conclusion did we draw?
Martin also mentioned a Google doc with other alternatives, but the link appears to be broken. Asked if there was a more up-to-date link

The only alternative that stood out to me from reading that issue was ipyelk. Did we evaluate that one? If so, what conclusions did we draw?

I didn't really evaluate it -- I looked at the screenshots and they looked less like the final result I wanted than the cytoscape ones.

That was my impression as well, but didn't know if that was just a perception gotten from those screenshots or if that is really representative of all pyelk visualizations

The only thing I would say this PR needs is some docs.

Good point, thanks @jacobtomlinson. I've added some docs.

That was my impression as well, but didn't know if that was just a perception gotten from those screenshots or if that is really representative of all ipyelk visualizations

I took a look at ipyelk for a few minutes and had a bit of a hard time getting it working (it has also not seen much activity recently). I feel comfortable moving forward with cytoscape for the time being. I also think that the plumbing work done to make the visualization engine configurable should make adding new visualizers easier in the future.

Wow, this is incredibly awesome! @ian-r-rose  🚀


Autodetect only CircuitPython serial ports when serial is not specified

PR for issue #5
One thought occurred to me, does the Adafruit Board Toolkit detect other manufacturers boards?

I've tested this PR on macOS and verified that the piku serial command works correctly. Tested with a Circuit Playground Bluefruit, and with a Feather RP2040, which are the boards I have handy at the moment.


Sensor calibration issues

Internal mag calibration x/y/z scales are all 1.0
Are the IDs for MAG0, MAG1 handled correctly? if the external mag is disconnected after calibration it seems that MAG1 is then identified as MAG0

That's correct, but it gets a different ID, which is used to look up the calibration parameters.

but it gets a different ID, which is used to look up the calibration parameters.

Only if you re-calibrate? This is disconnect without re-calibrating.

different = unique, my bad. So you don't need to calibrate again.

@LorenzMeier How do you suggest that one validate the calibration for both mags? If I disconnect the external mag, prearm checks fail, and I can't fly to test the internal mag. This testing may not be necessary for the normal user, but how else do we prove that the internal mag is working correctly?

@kd0aij That's intentional. While the assignment of calibration parameters is done correctly based on the sensor's unique ID, the prearm check confirms wether what used to be MAG0 is still MAG0 and fails if its not.
The rationale is that you should not be flying a system that has changed configuration since you calibrated it. Either because you've added an external GPS and really should be using the external mag now, or worse, because the wiring to the external GPS might have come off.
As you showed yourself falling back to the internal mag is not quite ensuring a reasonable or even safe flight performance.
Presuming that this all works as designed, I'm closing this now. Please re-open if I missed something.

Did you mean to imply that fallback to the internal mag is not allowed at any time, hence there is no need to test its calibration?

Also, the internal magnetometer scaling question has not been addressed.

@kd0aij Fallback to the internal mag is possible in-flight, but it will prevent arming. The scaling of 1.0 is ok / nominal for the LSM303D.

I conclude that flight testing with the internal mag is therefore not
supported.
Is the scaling intentionally forced to 1.0 for the LSM303D?
On Tue, May 5, 2015 at 2:52 PM, Lorenz Meier<EMAIL_ADDRESS>wrote:

Closed #2125 https://github.com/PX4/Firmware/issues/2125.
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2125#event-297636261.

--
Mark Whitehorn
<EMAIL_ADDRESS>

No, that conclusion is not correct. Just calibrate the mag with the external mag disconnected and you will be allowed to use the internal one.
The scaling is not "forced" to 1.0, rather, the LSM303D does an automatic internal scale correction, so its scale is in fact always right / at 1.0.


Android doze and Newtifry

I intend to use Newtifry for various private messages. I understand that messages may be delayed in the system.  However I suspect that Newtifry messages are received by my mobile, but are sometimes not announced until I move the phone.  My understanding is that this is a feature of Android 6.0.1 Marshmallow's 'doze' state.  The GCM documentation for Marshmallow indicates that messages can have a 'high' or 'normal' priority, but Newtifry has priorities 0 - 3.  Messages with a 'high' priority should wake Marshmallow from doze.  How can I send a GCM message via Newtifry with a 'high' priority?

Thanks, I look forward to it!
Thanks for the quick response too!
Best wishes
Mike
On 29/08/2016 16:05, thunder wrote:

Newtifry priorities (0 to 3) are only internals priority, not GCM ones.
I will modify the server code. After code change, all Newtifry messages with Newtifry Priority 3
will be sent with GCM priority of High.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thunderace/newtifry/issues/10#issuecomment-243151639, or mute the thread
https://github.com/notifications/unsubscribe-auth/AUR9VJYzek3-dfcUZDm9_Yj1-W7jtU8Vks5qkvUhgaJpZM4JuRs9.

Done. You can test (i have no android M).

Hi,
I've done a quick test and it still works.
But really I need to get the phone to doze, and then see if it still works.
I send myself a message via newtifry every morning, and the phone is normally dozing then (and so am
I).  So tomorrow morning I'll have a good idea if it's worked. And I'll let you know.
Thanks again.
Mike
On 29/08/2016 18:59, thunder wrote:

Done. You can test (i have no android M).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thunderace/newtifry/issues/10#issuecomment-243202538, or mute the thread
https://github.com/notifications/unsubscribe-auth/AUR9VN6TEuEfs3ntI2zVxjELE1wLQlMeks5qkx4KgaJpZM4JuRs9.

Hi. Well, it seems to work. I get notifications within 5 minutes when the phone is dozing. This
compares with 30 to 40 minutes or longer before you changed it.  So thanks again.
Mike
On 29/08/2016 18:59, thunder wrote:

Done. You can test (i have no android M).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thunderace/newtifry/issues/10#issuecomment-243202538, or mute the thread
https://github.com/notifications/unsubscribe-auth/AUR9VN6TEuEfs3ntI2zVxjELE1wLQlMeks5qkx4KgaJpZM4JuRs9.

Good.


Please use the iam roles attached to the machine

@runningman84 wrote:
Today it is recommended not to save AWS secrets on a machine. These credentials should be provided by an iam role:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html
Is the secret and key mandatory?

Hey @runningman84, I've just release v1.0.2 which now supports IAM roles. Simply omit the key and secret config parameter and you should be good.


Set CAA records

https://blog.qualys.com/ssllabs/2017/03/13/caa-mandated-by-cabrowser-forum

Certification Authority Authorization (CAA), specified in RFC 6844 in 2013, is a proposal to improve the strength of the PKI ecosystem with a new control to restrict which CAs can issue certificates for a particular domain name. Although CAA had been in the proposed-standard state for more than 4 years, there was little obvious happening until very recently, with only a hundred or two hundred sites adopting it. But that’s going to change, because the CA/Browser Forum recently voted to mandate CAA support as part of its certificate issuance standard Baseline Requirements. The changes will become effective in September 2017.

tl;dr we'd set CAA headers on our DNS zones, similar to this:
example.org. CAA 128 issue "letsencrypt.org"

DNSimple supports these, so it should be pretty easy. We only need to migrate DNS for ipfs.io and ipfs.team from DigitalOcean to DNSimple first.

This is live.
$ dig +short CAA ipfs.io
0 issue "letsencrypt.org"
0 issue "pki.goog"
0 issuewild "letsencrypt.org"


Can't add request that contains "/" in name

When I add requests, I sometimes want to name them after the url, e.g. localhost:3000/foo.
This creates an error message
Error invoking remote method 'renderer:new-request': Error: ENOENT: no such file or directory, open '/Users/path/to/collection.bru'.

The request name is also the file name und / is not allowed as a file name.
We already have a PR open to fix this #349 but not sure when this gets merged.


Python client

We are in the process of selecting a database to handle financial transactions for our new project and are considering using TigerBeetle. However, we've noticed that there is currently no official Python client available.
Do you have any plans to create an official Python client? This would significantly help us and potentially other users in integrating your project into Python applications.

+1

There are plans for sure, but we haven't started the work on the Python client ourselves currently!

Is there any plans for creating a similar client for Go? Would love to be a part of that

We went with creating simple HTTP API server in Go using official client and wrote simple HTTP client in Python with asyncio and aiohttp. This works for now.


Improved the docs

Adding please everywhere does not sound like instructions...I would request others to review this PR too..


Actions lost when referencing Microsoft.AspNetCore.Mvc in dependency

When you have some library that references Microsoft.AspNetCore.Mvc such as in the following project.json
ClassLibrary1 project.json
{
  "version": "1.0.0-*",

  "dependencies": {
    "Microsoft.AspNetCore.Mvc": "1.0.0-rc2-final",
    "NETStandard.Library": "1.5.0-rc2-24027"
  },

  "frameworks": {
    "netstandard1.5": {
      "imports": "dnxcore50"
    }
  }
}

and you have an application that depends on MVC by referencing this library, it causes actions to not be added to the ActionDescriptorCollectionProvider.
This can be reproduced by the following steps:
1. Create an ASP.NET Core Web Application with the default web application template

2. Add a class library as a project

3. Change project.json of the class library to the content listed above in ClassLibrary1 project.json
4. Remove reference to Microsoft.AspNetCore.Mvc in web application project.json
{
  "userSecretsId": "{REMOVED}",

  "dependencies": {
    "Microsoft.NETCore.App": {
      "version": "1.0.0-rc2-3002702",
      "type": "platform"
    },
    "Microsoft.ApplicationInsights.AspNetCore": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Authentication.Cookies": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Diagnostics": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.0.0-rc2-final",
    //"Microsoft.AspNetCore.Mvc": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-preview1-final",
      "type": "build"
    },
    "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.Server.Kestrel": "1.0.0-rc2-final",
    "Microsoft.AspNetCore.StaticFiles": "1.0.0-rc2-final",
    "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0-rc2-final",
    "Microsoft.EntityFrameworkCore.Tools": {
      "version": "1.0.0-preview1-final",
      "type": "build"
    },
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0-rc2-final",
    "Microsoft.Extensions.Configuration.Json": "1.0.0-rc2-final",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.0.0-rc2-final",
    "Microsoft.Extensions.Logging": "1.0.0-rc2-final",
    "Microsoft.Extensions.Logging.Console": "1.0.0-rc2-final",
    "Microsoft.Extensions.Logging.Debug": "1.0.0-rc2-final",
    "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.0.0-rc2-final",
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
      "version": "1.0.0-preview1-final",
      "type": "build"
    },
    "Microsoft.VisualStudio.Web.CodeGenerators.Mvc": {
      "version": "1.0.0-preview1-final",
      "type": "build"
    }
  },

  "tools": {
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.EntityFrameworkCore.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": [
        "portable-net45+win8+dnxcore50",
        "portable-net45+win8"
      ]
    },
    "Microsoft.Extensions.SecretManager.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
      "version": "1.0.0-preview1-final",
      "imports": [
        "portable-net45+win8+dnxcore50",
        "portable-net45+win8"
      ]
    }
  },

  "frameworks": {
    "netcoreapp1.0": {
      "imports": [
        "dotnet5.6",
        "dnxcore50",
        "portable-net45+win8"
      ]
    }
  },

  "buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true
  },

  "runtimeOptions": {
    "gcServer": true
  },

  "publishOptions": {
    "include": [
      "wwwroot",
      "Views",
      "appsettings.json",
      "web.config"
    ]
  },

  "scripts": {
    "prepublish": [ "npm install", "bower install", "gulp clean", "gulp min" ],
    "postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%" ]
  }
}

5. Add reference from web application to the class library.
The following can be used to verify there are no actions being found

app.UseMvc(routes =>
{
    routes.MapRoute(
        name: "default",
        template: "{controller=Home}/{action=Index}/{id?}");
});

if (app.ApplicationServices.GetRequiredService<IActionDescriptorCollectionProvider>().ActionDescriptors.Items.Count == 0) {
    throw new Exception("No actions found.");
}

/cc @javiercn

I believe this is a dupe of https://github.com/aspnet/Mvc/issues/4555
The workaround for the moment is to just reference Microsoft.AspNetCore.Mvc directly in your web app or in any class library that contains things like controllers and so on.

Yup, dup of https://github.com/aspnet/Mvc/issues/4555.

I have a similar issue with a Web Api project created from the "Asp.Net Core Web Application (.Net Framework)" template which references a .Net 4.6.1 class library (.csproj) that uses the Microsoft.AspNetCore.MVC nuget package.  Controllers defined in the class library are not picked up by the web project.  The workaround mentioned by javiercn does not work in this case as  Microsoft.AspNetCore.Mvc is already referenced in the web project and it still doesn't work.
I'm not sure if this scenario should be supported right now, however it is something I would like to use as the tooling around xproj projects is not yet mature enough to easily fit into our development environment (source control, code analysis and unit testing all have problems).  Whilst this is the case, the more code I can keep in .csproj the better!
To reproduce in VS2015 (update 3):

Create a new project from the "Asp.Net Core Web Application (.Net Framework)" template
Select "Web API" from the "Asp.Net Core Templates" Dialog
Confirm this will run by hitting F5 - a browser will load and navigate to api/values
In the same solution create a new .Net 4.6.1 class library (csproj)
apply the Microsoft.AspNetCore.MVC nuget package to the class library (v1.0.0)
Copy the ValuesController.cs from your web project into your class library.
Delete ValuesController.cs from your web project.
Add a reference to the new class library from your web project
Hit F5 to Debug the web project again
api/values
You get 404 Not found

@BillDines, you should be able to workaround this by explicitly registering your ClassLibrary as an application part:
In your startup:
services
  .AddMvc()
  .AddApplicationPart(typeof(ValuesControllerFromClassLib).Assembly)

I suspect this is an issue with how DependencyContext computes references for csproj based class libraries.

@pranavkm - thanks, that fixes it!  Sorry, I deleted my comment already and started a new  #issue:4983

That's alright. It'll help us to keep track of the underlying issue so that it works out of the box.


Organization profile - Front end

[ ] frontend organisation profile

Here is the Requirement for Create Org Profile UI
https://www.notion.so/fightpandemics/Create-Org-Profile-UI-d1438cad0cdb4ca09a9684366009fc8f

@indirabhowmick I believe this isn't the latest. We have changed some of the things, didn't we?

Please refer to the updated UI design from FIGMA:
https://www.figma.com/file/4cV84H1jyMo0rJEAl3HNnJ/FightPandemics-landing-page?node-id=775%3A538

@YehualashetGit isn't responsive so I'm putting this back to New.

https://www.figma.com/file/4cV84H1jyMo0rJEAl3HNnJ/FightPandemics-landing-page?node-id=1806%3A13250

@alexjmcm do you have any update?

@MohamedEl1 - Can you please look into this? This is part of MVP. Back end has already been completed by @mannykary

@MohamedEl1 @alexjmcm @indirabhowmick - can you confirm the pages on the front-end that would be created via this issue? I'm trying to figure out what this encompasses so I can determine if/what new issues need to be created. Thanks!
Pages to "Create Profile:

Pages to Edit/Complete Profile

There's also requirements around interactivity- e.g., clicking the pencil icon from the profile should open up a modal to either "Edit Account Information" or "Edit Profile".

@alexjmcm or @anniegiang , could you tell me which screens we are enabling with the PR #399? I'm happy to test as well once the PR has been merged. I'm trying to figure out which other tickets I need to create for mobile based on what's in the Figma

@vikjoshi With the PR #399  we are working on the create-profile screen similar to this:

Thanks @alexjmcm . I also want to call out how an organizational user would access this page so we have the right paths built in. Organizational user would access this page:

By clicking on "Edit Account Information" from the View Profile page-

When submitting a post as an organization-


The server_log4j_opts variable is not declared to be used

SUMMARY

Another comment, I found that the server_log4j_opts variable is not declared to be used for the service task. I mean, I don't see how to identify a value for that variable.
ISSUE TYPE

Bug Report

ANSIBLE VERSION

COLLECTION VERSION

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

Fixed by #58


Parse emoji reactions

This is fantastic! Thanks for adding this parsing and updating the tests :)

This is fantastic! Thanks for adding this parsing and updating the tests :)

;)
Happy to get this done and given back to the community !
And I am happy the actual tests failed and now cover the feature 😄
I have html to markdown to make a PR for, just not sure how I could add an ENV for that


Add failure case to secp256k1_generator_generate_interal

The implementation of shallue_van_de_woestijne currently returns an off-curve point when given a value of t.
While this is cryptographically impossible to occur, none-the-less we should fail in this case rather than simply return a garbage value.

This fixes issue #279 using method (B) by having secp2561_generator_generate_internal return 0 in case one of the hashes results in the all 0 value (this is cryptographically impossible).
No however this "fix" still results in computations proceeding with off-curve points, which is somewhere between "strongly discouraged" and "a violation of the preconditions of the secp256k1 operations".
For an alternative solution see #284.

Merged alternative fix #286.


rt: init RT

INSPIR-2457

Signed-off-by: Harris Tzovanakis<EMAIL_ADDRESS>

Good point actually totally forgot about that, will update it!


About this query

Currently crashes on freecen.  We need to make this app-aware.

Not an app-aware issue, just a bug. Fixed.


Fix unicode character in kubectl-hnc tree

I had used the regular pipe character ("|", U+007C) but this wasn't
lining up correctly. The correct character appears to be "Box Drawings
Light Vertical" ("│", U+2502).
Tested: ran tree and confirmed it was more visually appealing.

/assign @rjbez17

/ok-to-test
/lgtm
/approve


How much video memory is required for the stage==nformer

When I train to the nformer stage, I will be prompted that the video memory is not enough. My video card is 12g video memory. Is there any way for me to train normally in the nformer stage.For example, which parameters can be modified to reduce the use of video memory during training

When I train to the nformer stage, I will be prompted that the video memory is not enough. My video card is 12g video memory. Is there any way for me to train normally in the nformer stage.For example, which parameters can be modified to reduce the use of video memory during training

Did you notice a memory overflow during image training in the nformer stage?

Hello, I have also encountered a similar problem. In the first stage of training the resnet50 with the batch_ Size=64, GPU takes up about 7 GB（my GPU capacity is 24G）, and during the second stage of training the Nformer, it always reports an error of out of memory. I also cannot see the training process of the Nformer during debugging, and I hope to receive your guidance


test mr

Can you rebase this on top of master to fix the conflicts? Can you provide a little more context around the issues this PR is fixing? Is it possible to split this PR into a few smaller cherry-picks to make reviewing easier (and parallelizable)?


Driver protocol should implement PEP 249

Hello there!
First of all, I'd like to thank you for the amazing work you've been doing here!
I'm experimenting using this package with psycopg and found an issue when executing the consumer. See its code below, which is similar to the example provided:
from psycopg import AsyncConnection
from pgqueuer import PgQueuer, AsyncpgDriver, Job

async def consume() -> PgQueuer:
    pgq = PgQueuer(
        AsyncpgDriver(
            await AsyncConnection.connect(...)
        )
    )

    @pgq.entrypoint('entrypoint')
    async def _entrypoint(job: Job) -> None:
        if job.payload is None:
            return

        await process(job.payload.decode())

    return pgq

I executed this code the following way:
$ pgq run module.consume

Traceback (most recent call last):
  File ".../python3.12/site-packages/pgqueuer/sm.py", line 138, in run
    if not (await self.queries.has_table(self.queries.qbe.settings.schedules_table)):
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../python3.12/site-packages/pgqueuer/queries.py", line 126, in has_table
    rows = await self.driver.fetch(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../python3.12/site-packages/pgqueuer/db.py", line 174, in fetch
    return [dict(x) for x in await self._connection.fetch(query, *args)]
                                   ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'AsyncConnection' object has no attribute 'fetch'

I believe pgqueuer shouldn't expect the driver to have a fetch method, because PEP 249 (Python Database API Specification v2.0) doesn't specify one.
I checked the documentation of psycopg, asyncpg, sqlite3, and it seems only asyncpg implements a fetch method.
Cheers!

Thanks for sharing your feedback and detailed example!
The intent behind the driver abstraction is to normalize database connections from pgqueuer’s perspective, ensuring it can interact seamlessly regardless of the underlying library. For instance, the PsycopgDriver wraps psycopg’s functionality into the expected interface (fetch, execute, etc.).
The code you provided looks great, and from my tests, it should work as intended. Could you confirm which version of psycopg and pgqueuer you’re using?

@pdmtt
Aren't you supposed to use the PsycopgDriver class since you're using psycopg instead of the AsyncpgDriver?

Hey, thanks for the reply.
I failed to notice that AsyncpgDriver was not a wrapper for all async postgres DBAPIs. The error was gone after changing to PsycopgDriver. My bad!
FYI, psycopg.AsyncConnection.connect(...) returns a connection with autocommit off by default. This caused an AssertionError at pgqueuer.db.py:362:
assert self._connection.autocommit

It was an easy fix after a quick code inspection, but it isn't mentioned in the documentation that autocommit is needed.
If you use an psycopg.AsyncConnection with the default configuration (autocommit off) to enqueue tasks, they won't be commited by pgqueuer. This is worse than before because this problem is quiet, which makes debugging harder.
Since that's not the scope of this issue, I'm closing it.
Thanks again.

@pdmtt Thanks the feedback, i will improve the exception message as well as update the docs. to mention that the connections must be in 'autocommit mode'.


Generate report.tex with all interaction history with fakehub

Let's generate report.tex file that will contain all the history of interaction with our tool during the particular run session. We can even render a nice PDF document from that tex file if user pass --report flag within start command.

@l3r8yJ WDYT?

@h1alexbel i think report might be in different formats, for example these args can be supported

--xml
--tex
--txt

wdyt?

@l3r8yJ yes, good idea. We can combine these options with --report flag

@h1alexbel let's do it in form of fakehub start --report <FORMAT> i.e. with tex it will be look like this: fakehub start --report tex, wdyt?

@l3r8yJ looks good, let's do this

@h1alexbel 4 puzzles #52, #53, #54, #55 are still not solved.

@h1alexbel 3 puzzles #52, #53, #55 are still not solved; solved: #54.


stacking context issue, bootstrap dropdown zindex not working properly

I am using bootstrap dropdown inside a div of limited height, I want to keep the height of this div fixed so that my footer is always visible even if the content of the div keeps on increasing.
to do that i have added overflow:auto to div, now whenever i click on dropdown it adds scrollbar to the div and dropdown list is cutting off.

  <form>

        <button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown">Dropdown Example
      </button>

HTML

CSS

JavaScript

Attached Plunkr demo:
https://plnkr.co/edit/yeSqTMLyjn36g1VrFNC7?p=info
Note: I want to keep the height of container fixed, and i want the dropdown list to be on top (stack context high in dom).
Thanks.

Change overflow: auto to overflow: none. The dropdown needs to overflow any containing element.

Do you want your footer to stick to the bottom of the page? If so do the following:
Remove overflow: auto and add the fixed-bottom class on the footer.
If you want the footer to stay under your fixed height div, then remove overflow: auto and use sticky-bottom class on the footer instead.

No way around this unless you change your HTML or your CSS. Make the overflow: visible or try a different approach, I'm afraid.


fix: change forwardRef to ref

Change forwardRef to ref to fix docs
_It's my first PR into another repo, sorry if its not permitted _  👀

Looks great, good catch


The README still could be ambiguous.

When I follow the README, after pasting the code into Elm's Online Editor the next logical step is to try this code locally.  So, completely naively, I would:

install elm
create a .elm file (startapp.elm?)
call elm make startapp.elm --output index.html

It does not explain that the dependencies for Html and for start-app must be satisfied.

I recommend a comment that a call to elm-package install evancz/elm-html and elm-package install start-app is required if you want to use this sample code once you have installed Elm locally.

agreed, ideally, start-app should run out of the box without any need for configuration. I'm still unclear on naming conventions for packages, so even friendly error messages like the following don't help me much.
Simply including the appropriate dependencies in the elm-package.json by default would alleviate some of these difficulties by allowing someone to simply run elm-package install. I only say some because I'm running El Capitan and also had to build from source to install packages :)
Error when searching for modules imported by module 'StartApp':
    Could not find module 'Effects'

Potential problems could be:
  * Misspelled the module name
  * Need to add a source directory or new dependency to elm-package.json

To add to this issue, the example code does not seem to actually do anything and I'm having trouble differentiating StartApp.elm and Simple.elm. The comments on each seem to indicate that they are different versions of the same functionality, but since neither seem to produce anything as output, it's difficult to figure out where I should actually start. Something that seems to be missing from Elm's overall documentation is a strong correlation between code and output, with helpful feedback along the way.
I've yet to find clear workflow documentation, and have had to piece together bits and pieces from each package of the Elm Platform's individual (and limited) documentation.
I definitely understand that this is a small community and you are likely spread fairly thin, just thought I would share the feedback. I'm hoping that once I get this pieced together and have a better grasp of how it all works together I'll be able to share what works for me.

@JHKennedy4, what does "the example code does not seem to actually do anything" mean exactly? Is this a problem for you in the online editor or locally? What happens on screen (in browser) when you run the example?
About "clear workflow documentation", do you mind checking out the text from here to here and commenting on whether that would have helped you to find your way more easily?

Working locally and not seeing anything on the screen.
Both of those docs are extremely helpful for providing context. If you are
looking for an example of extremely good intro documentation, I highly
recommend the Phoenix Framework docs.
My main struggle thus far has been finding a clear path to basic production
style use where I can either incorporate elm into an existing project or
start a new project with a server side component.
For example, I'm still not clear what options are available on elm make and
what the difference between them is.
On Mon, Sep 14, 2015 at 2:37 AM Janis Voigtländer<EMAIL_ADDRESS>wrote:

@JHKennedy4 https://github.com/JHKennedy4, what does "the example code
does not seem to actually do anything" mean exactly? Is this a problem for
you in the online editor or locally? What happens on screen (in browser)
when you run the example?
About "clear workflow documentation", do you mind checking out the text
from here
https://github.com/elm-lang/elm-lang.org/pull/370/files#diff-015471f8a6a2652b9ce3365cfb826b4fR21
to here
https://github.com/elm-lang/elm-lang.org/pull/370/files#diff-015471f8a6a2652b9ce3365cfb826b4fR149
and commenting on whether that would have helped you to find your way more
easily?
—
Reply to this email directly or view it on GitHub
https://github.com/evancz/start-app/issues/23#issuecomment-140018161.

Sorry, I'm afraid there is still not enough information to see what is the problem at your end. The example itself is correct. So, what did you do locally? Compiled to .html? Running in elm-reactor? Maybe you can post a sequence of commands you have run, starting in an empty directory, and what you clicked in elm-reactor (if you did use it).
About "workflow leading to production use", the mailing list may be the best forum to get suggestions.

I used elm make to output a JavaScript file which failed to load for
unknown reasons (could have nothing to do with elm) and then tried elm
reactor where I navigated to each elm file in turn. Neither resulted in
output to the screen. Reading the code, it's not clear how they would, but
that might be my own ignorance.
What I would prefer is for the README to contain a clear set of commands I
should run to get started using this project.
On Mon, Sep 14, 2015 at 12:28 PM Janis Voigtländer<EMAIL_ADDRESS>wrote:

Sorry, I'm afraid there is still not enough information to see what is the
problem at your end. The example itself is correct. So, what did you do
locally? Compiled to .html? Running in elm-reactor? Maybe you can post a
sequence of commands you have run, starting in an empty directory, and what
you clicked in elm-reactor (if you did use it).
About "workflow leading to production use", the mailing list
https://groups.google.com/forum/#!forum/elm-discuss may be the best
forum to get suggestions.
—
Reply to this email directly or view it on GitHub
https://github.com/evancz/start-app/issues/23#issuecomment-140183457.

Let's try the following commands (if they work for you, this info could be some that is fit for the README):

make a new directory
change into that directory
create a file called Example.elm, and into it put the code block from the current README
on the command line, run elm-package install evancz/start-app --yes
now either:

on the command line, run elm-make Example.elm --output=Example.html, then open Example.html in a browser, or
on the command line, run elm-reactor, then open http://localhost:8000/Example.elm in a browser

Sorry for the delay, haven't had time to play around for a few days. Those instructions did the trick, and are not something that would have ever occurred to to me to do having read the docs.
If you merge https://github.com/evancz/start-app/pull/27 someone already put together a PR with the instructions included.

Have you seen the following page newly added to the Elm website?
http://elm-lang.org/get-started
Would the "Tools" section of that page have helped you here?
Let's assume that section becomes "required reading" for everyone having installed Elm. (It is already pointed to by the Windows/Mac/npm installers. And https://github.com/elm-lang/elm-lang.org/pull/326 and https://github.com/elm-lang/elm-platform/pull/84 intend to make it even more visible.)
Would you still have needed my instructions above?
It might still make sense to merge something like #27 in this specific repository here, given that start-app might be a frequent entry point to Elm other than the website. But in general, I think it makes more sense to have people read http://elm-lang.org/get-started once instead of adding specific Elm tool usage instructions to every package on http://package.elm-lang.org/.

@jvoigtlaender Your instructions seems not work for me. I get this:
Error when searching for modules imported by module 'Main':
    Could not find module 'Html'

Potential problems could be:
  * Misspelled the module name
  * Need to add a source directory or new dependency to elm-package.json

I'm sure elm-html has been installed, I can find it in elm-stuff/packages/evancz/elm-html. My platform is Win10 and Elm 0.15.1.
By the way, I feel Elm is hard for me to get started, I can't find the direct link to get-started page on the index page or the docs page, it's confusing. And I finally get http://elm-lang.org/get-started from here.

Yeah, I also wish http://elm-lang.org/get-started were pointed out more prominently from the website. I have more than one pull request open to that effect.
About the Edit to your comment: Good that you got it working. The fact that you have to explicitly declare evancz/elm-html as a dependency (if you are going to use stuff from it directly), even though it is already installed as a transitive dependency of start-app, shouldn't be that surprising. It seems to be a common property of package managers and build tools in many languages. For example, it's the same for cabal in Haskell: If your project uses packages A and B, and A also uses B internally, you cannot simply only declare A as a dependency of your project. Among various reasons, this would not lead to a maintainable situation. For example, what if the implementation of A later changes and does not anymore depend on B? Then B would "disappear" even though your project still depends on it.

@jvoigtlaender You do make more sense. I commonly use npm, and the directory hierarchy of denpendencies of those two have some distinctions, I think I figured it out, thx. :smile:

What I did was to go to the Elm home page and then follow the HTML app link. The README has a sample program which is kind of informative in a way, but not a single instruction as to how I can actually build it and run it.
It'd be really cool if this repository contained all the bits needed to do this -- the .elm file, whatever configuration is needed in elm-package.json (I'm getting an error about the Html import that I'm now going to have to try to find docs for) and a sample build command.

@evancz
Definitly should be added to README, spent half an hour to understand how to make things work
Let's try the following commands (if they work for you, this info could be some that is fit for the README):

make a new directory
change into that directory
create a file called Example.elm, and into it put the code block from the current README
on the command line, run elm-package install evancz/start-app --yes
now either:
on the command line, run elm-make Example.elm --output=Example.html, then open Example.html in a browser, or
on the command line, run elm-reactor, then open http://localhost:8000/Example.elm in a browser

@fellz, would #27 have addressed your case?

http://elm-lang.org/get-started ? and what to do with README for StartApp leave for confusion ? i can create pull request if you can't add this for some reasons...

I can't, because I have no write access to this repository. I do think that adding http://elm-lang.org/get-started (or the information contained in its first half) to the README here would be useful. Whether that be via https://github.com/evancz/start-app/pull/27 or via a new pull request. But it's @evancz who needs to make a decision about merging.

#27 seems like it'd be a great start. A link to the get-started page also wouldn't go amiss.
Why not convert this into a seed project so it can be cloned and used as a starting point for simple apps?

This package is not continuing into 0.17


Typegen

@xenova this is only the utils.js file. It will take some time lol.
I also think we might add a prettier and linter so people won't override all file like me 😝.

I just resolved a conflict coming from main. Let me know when you want me to review and test fully 👍

I just resolved a conflict coming from main. Let me know when you want me to review and test fully 👍

@xenova I have left only 3 files. Hopefully in two days.

Sweet! No rush :)

@xenova The PR is ready, all files have JSdoc now :)

Nice! 🎉 I'm almost done adding a few more models/tasks to main, then I'll review, merge, and finally add any missing docs.

Just a general question for you @xenova, do you prefer to keep the source in JavaScript vs. moving some things over to TypeScript?

Not too sure 👀 ... JS has been easier (and faster) to develop in since I don't have much experience with TS.
But I'm pretty sure that eventually, the project will transition to TS.

But I'm pretty sure that eventually, the project will transition to TS.

I hope not. TS is useful powering a language server, but actually writing TS is ugly once the types become a bit more complicated. And you lose the ability to load code directly as ES6 modules in the browser via <script type="module">.
I would urge caution with regards to those who seem overly enthusiastic about TS, as their enthusiasm is often just following "that shiny new thing", while being disconnected from pragmatism.
Simple job for you, @biw, to make things clear, translate this to TypeScript:
/**
 * @example
 * forInMap({a: 11, b: 22}, (k, v) => v); // [11, 22]
 * @param {Record<KEY, VAL>} o - The object.
 * @param {(key: string, value: VAL) => RET} lambda - The function that operates on the key/value pairs.
 * @template {string | number | symbol} KEY  - The key.
 * @template VAL - Type of the value given to `lambda`.
 * @template RET - Type of the return value of `lambda`.
 * @returns {RET[]}
 */
function forInMap(o, lambda) {
  return Object.keys(o).map(key => lambda(key, o[key]));
}

@xenova The PR is ready, all files have JSdoc now :)

Great work :+1:
I looked over it and src/utils.js received way more changes than necessary. I see the value of a linter, but maybe we have to keep it separate? It looks like it moved methods up and down etc.

@kungfooman thanks for the feedback. The linter is turned off. I think it happened when resolving conflicts. I will have a look and fix :)

@xenova just checking what is missing to merge this :)

I hope not. TS is useful powering a language server, but actually writing TS is ugly once the types become a bit more complicated. And you lose the ability to load code directly as ES6 modules in the browser via <script type="module">.

Since there's already a build pipeline with webpack, this isn't an issue. 😄

I would urge caution with regards to those who seem overly enthusiastic about TS, as their enthusiasm is often just following "that shiny new thing", while being disconnected from pragmatism.

As someone who's been shipping typescript code in production for over four years, my intentions are not to chase the new shiny thing. Just trying to help out if the need is there. Not trying to force anyone to use anything 😄

Simple job for you, @biw, to make things clear, translate this to TypeScript:
/**
 * @example
 * forInMap({a: 11, b: 22}, (k, v) => v); // [11, 22]
 * @param {Record<KEY, VAL>} o - The object.
 * @param {(key: string, value: VAL) => RET} lambda - The function that operates on the key/value pairs.
 * @template {string | number | symbol} KEY  - The key.
 * @template VAL - Type of the value given to `lambda`.
 * @template RET - Type of the return value of `lambda`.
 * @returns {RET[]}
 */
function forInMap(o, lambda) {
  return Object.keys(o).map(key => lambda(key, o[key]));
}

Here you go!
function forInMap2<V, K extends Record<string | number | symbol, V>, Ret>(
  o: K,
  lambda: (key: keyof K, value: K[typeof key]) => Ret,
) {
  return Object.keys(o).map((key) => lambda(key, o[key as keyof K]))
}

Not trying to start a flame war, I just wanted to be helpful if @xenova had an interest in using TypeScript.

@xenova just checking what is missing to merge this :)

Hi! No need to do anything on your side - I will get to fully reviewing (and merging) by the end of the week (hopefully lol).

Not trying to start a flame war, I just wanted to be helpful if @xenova had an interest in using TypeScript.

Haha no worries! 🤣 I'm definitely open to learning new tech, so, we shall see ;) For now, as you'd expect, I'll continue developing in JS, otherwise, I'd probably not be able to keep up with all the craziness in the AI space right now 😄

Fixed the conflicts :+1: VSCode is displaying quite a few warnings/errors, and it will probably be good to get those (mostly) resolved before merging. There are also some methods/classes which were added recently that aren't fully documented. If one of you wants to maybe help with these 2 things, that would be great!
Some other exciting news: I've been talking to some HF staff, and they are willing to host the docs on https://huggingface.co/docs/ 🤯 , and then listing Transformers.js as a community-driven open-source project! 🔥

Mentioning it here; I used this as a base for a full .ts conversion (well, not full full, but getting there! 😉) in https://github.com/jcbhmr/transformers.js/pull/13
https://github.com/chelouche9/transformers.js/compare/typegen...jcbhmr:transformers.js:use-ts

Some other exciting news: I've been talking to some HF staff, and they proposed hosting the docs on https://huggingface.co/docs/ 🤯 , and then listing Transformers.js as a community-driven open-source project! 🔥 Super exciting!

Wow great news! Good job @xenova. Your hard work will reach much more people.

Fixed the conflicts 👍 VSCode is displaying quite a few warnings/errors, and it will probably be good to get those (mostly) resolved before merging. There are also some methods/classes which were added recently that aren't fully documented. If one of you wants to maybe help with these 2 things, that would be great!

I was off the last couple of days. I will start tomorrow to try and fix some conflicts. Do you have any leads what is the most important part need fixing?

I was off the last couple of days. I will start tomorrow to try and fix some conflicts. Do you have any leads what is the most important part need fixing?

Sounds good! 🔥 Other than some missing JSDocs (after merging main into the PR), it is just some warnings. The tests run successfully, so, there's nothing "fatally" wrong...
The main thing that pops up is a "Property not defined" error, which is understandable since not all models share the same instance variables (and because of the way I'm doing inheritance to reduce code duplication). For example, encoder-decoder must define some extra properties such as num_decoder_layers, num_decoder_heads, decoder_dim_kv, num_encoder_layers, num_encoder_heads, and encoder_dim_kv. Of course, these don't exist on the base class, so, it is giving a warning saying that we are accessing/setting a property that doesn't exist. Not too sure how to hide/fix that though. If there is a way to globally disable those problems, that could work.
So, other than just adding the missing JSDocs, you could maybe just try fix/reduce some of the warnings (no real particular order tbh). If you use VSCode, you should be able to see the "Problems" (there are quite a lot haha).

@xenova I rebased over main and there were many conflicts. I hope nothing breaks.
Merging this PR as soon as possible will help us avoid doing those time-consuming rebase.
However, we don't want to add all the errors. Since adding types to the code requires a deep understanding of its usage, I suggest that I will change it to any anywhere it breaks and we will incrementally change it over time.
What do you think?

Merging this PR as soon as possible will help us avoid doing those time-consuming rebase.

Agreed! I'm trying to get to all open PRs now (with this one being the number 1 priority).

However, we don't want to add all the errors. Since adding types to the code requires a deep understanding of its usage, I suggest that I will change it to any anywhere it breaks and we will incrementally change it over time.
What do you think?

Sounds good 👌

@xenova I have fixed everything that is "type" related. Some errors are due to different js versions (like not using the spread operator below ecma2015), and some are about the _call method on objects. To fix them we need to make some code changes. We can do that on dedicated PRs later.
There were a lot of conflicts, I made sure everything is correct but I would recommend you test it and give an additional look :)

Awesome! 💪 Once again, it is kind of difficult to see where you made the changes, so, could you fix the formatting like you did before? Thanks :)
I'll try get it merged tonight if I can 🥳

Awesome! 💪 Once again, it is kind of difficult to see where you made the changes, so, could you fix the formatting like you did before? Thanks :)

@xenova done

@xenova I made another go. Now all the files are clean from the formatting and the weird code changes.

Great work, I looked through the PR once more and it just looks like minor issues, which can make it just a bit easier to read/maintain/code 👍
I am impressed by all the work, I hope it doesn't feel too nitpicky 😅 🙈

@xenova @kungfooman committed all changes. Thank you for the detailed review :)
Let me know if we need something else.

@xenova @kungfooman committed all changes. Thank you for the detailed review :)
Let me know if we need something else.

I think that is it then!!! 😍
I'm currently fixing a bug introduced by the latest version of optimum, which is quite important since it means no one can use their new models 👀
I will get to merging this in the second that is fixed! Super excited! 🔥 Thanks to everyone for their hard work 🙏

@chelouche9 I'm almost done with my pass over everything (it's taking so long haha). I tried to push, but I apparently don't have write access to your branch. Could you add me as a collaborator?

@xenova now you have permissions.

@xenova now you have permissions.

Thanks! I've pushed my changes. You and @kungfooman can do a quick skim over everything if you'd like... and then I'll merge into main 🔥

Thanks! I've pushed my changes. You and @kungfooman can do a quick skim over everything if you'd like... and then I'll merge into main 🔥

I see you added some changes to the code except for jsdoc. For the annotation part looks good to me :)

Also, I assume we have to run the build command each time before release? If so, then you're probably right that it's a good idea to remove dist from the repo. Perhaps @kungfooman can give some advice in that regard.

The only reason I like to commit build artifacts is to be able to see potential regressions, e.g. while rewriting a documentation system to keep track of the changes in the generated documentation files.
In such cases I just create a throw-away repo and commit as many files I want.
But I don't like all these artifact files in the "main repo", since I don't like large repositories. Cloning just takes longer and longer and it will probably also decrease the amount of contributors over time.
It's likely to result in merge conflicts aswell and I prefer not to spend time resolving merge conflicts in build artifacts.
I also like to use the file-search in VSCode and I don't want to put "dist" in "Exclude dirs" all the time, to filter for the SSOF (single source of truth) e.g. finding some specific types to improve.
TLDR: my suggestion is to remove /dist/ from repo


Android: Speech Recognition is not available

window.plugins.speechRecognition.isRecognitionAvailable(function(available){
	if(!available){
		alert("Sorry, not available");
	}
});

I tested it on Android 5.0, Phonegap cli-6.5.0 and cordova-plugin-speechrecognition 1.2.0 but i always get the error message: "Sorry, not available".
I added all necessary things:
<config-file target="AndroidManifest.xml" parent="/*">
      <uses-permission android:name="android.permission.RECORD_AUDIO" />
</config-file>

and
<preference name="AndroidLaunchMode" value="standard" />
Its not working. What could be the reason?

Still hanging on this? Common mistake (for Beginners) is to call a COrdova plugin BEFORE the Device is ready. So do not forget to only call a Plugin AFTER deviceready event was fired:
document.addEventListener("deviceready", function() {
window.plugins.speechRecognition.isRecognitionAvailable(function(available){
console.log('available -> ' + available);
if(!available){
alert("Sorry, not available");
}
});
}, false);
And, what i really do till i publish or ship software, logging, logging, logging.


Group pages load too slowly

Group page loading is too slow.
Needs async loading for artifacts

added async loading of artifacts and a loading notification


Sort the Programming Languages section

Wouldn't it be better?

Duplicate of https://github.com/sindresorhus/awesome/issues/216


[WIP] Matrix-based  build

Closes #39
Instead of using a Linux docker container on Windows for our Linux builds, use an Ubuntu image in AppVeyor.

Depending on how much fiddling this takes we'll probably want to squash before merging :smile:

Looks like the Ubuntu build  is reporting itself as succeeding even if the powershell build script fails.

Could work around the need for multi-platform support in a single build for NuGet by copying the way we do it in JSON Archive: using Rust's linker. We should also statically link the C runtime here like we do over there


Deployment

Initial stages of a few deployment file examples for Docker (& Docker Compose) behind an nginx proxy.
Let me know if you see any need for updates at this point.

This looks excellent @tomkersten. Can't wait to try it out. Thanks!

I would like to contribute to the dockrizing effort but i am not sure where to start.
so far i did this:
git remote add tomkersten git@github.com:tomkersten/connect.git
git pull tomkersten deployment

what should be my next step? do i need to run the bin/nv init somewhere so it will create a new project structure with the new Dockerfile and docker-compose.yml files?
Cheers!


chore: add 30 fps cap in settings

WHY?
We observed that by keeping the rendering usage of the CPU "at bay" by capping the FPS to 30, more CPU is freed and thus the performance improves in several situations.
Profiling info done with 30FPS cap (the old way, Application.targetFrameRate = 30, causing Unity to use setTimeout instead of the better RequestAnimationFrame()):
https://docs.google.com/document/d/12Fb3jwPv6-dv1rpCz2s2IkQ5uOQc6rWeBDfpYKxHPCY/edit#heading=h.qisid6wm6xt0
WHAT?
We implemented

A tick scheduling algorithm for controlling the framerate of the RequestAnimationFrame().
A toggle in the quality settings panel for this new 30 FPS cap (medium and low quality profiles set it to true)

TEST
You can test by toggling the 30 FPS cap toggle in the quality settings pannel
https://explorer.decentraland.zone/branch/test/fps-capped-30/index.html?ENV=org&LOCAL_COMMS

Are we losing the functionality of RAF executing in background? Could we check that doesn't produce a regression?
We can test if DCL loads in background which is the most important reason to have background RAF.

We have to check again if the background raf is working correctly


Add component guide and create date filter component

Add first component, styles, partial and tests
Move date facet into date filter component
Enable aria-controls dynamically for component flexibility

In finder

Component guide

https://finder-frontend-pr-312.herokuapp.com/component-guide/date-filter 😀

@MatMoore Yes. If the JS is disabled or fails for whatever reason, the inputs won't be controlling another element, so the attributes would be invalid.


Saagie Monitoring Tool - Saagie 3.0

Saagie Monitoring Tool doesn't work with Saagie 3.0.

Trello card: [#157] Saagie Monitoring Tool - Saagie 3.0


Render tablet's path

A path should be displayed to identify tablet table or domain
On node tablets table:

On tablet page:

@adameat is it possible to have table for every table and domain for system tables?

@adameat is it possible to have table for every table and domain for system tables?

wat? table for every table?
to have path for every tablet is an interesting but rather complicated feature at the moment.

Every tablet has a path. It may be rather a table (for DataShard) or some path for system tablets.


[core] next - add flowtype

Solves #4515, seed flow type on the next branch.
Highlights:

run with npm run flow

reusable type declarations can be added to src/flow directory

all current components converted and flow succeeds

added babel-plugin-flow-react-proptypes which adds in runtime prop checks

re-merged latest

[x] PR has tests / docs demo, and is linted.

[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".

[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

cc: @nathanmarks - you may want to check this out/merge quickly - I just had to re-merge and it can be a bit painstaking.

I'll check on the tests, we have 118 passing on next, but not on this PR.

Ok, this is ready for review again.  Tests pass - I had misunderstood how flowtype wanted to have defaultProps specified.

Why you prefer to use Object for children instead of Element everywhere in this pull?

@dmfilipenko - made changes to children?: Element, this is just a habit, Element seems like a better choice.

@rosskevin what's the deal with changes that were made from string | function to string | Object? (component prop)

@nathanmarks - should have been string | Function, those would be conversion errors.

@dmfilipenko @nathanmarks - more updates, open item is proper typing of primary and secondary - ListItemText.

@mbrookes @oliviertassinari @alitaheri
What are your thoughts on this PR and flowtype in general?

Silence seems like acceptance.  LGTM

@rosskevin This sort of change needs all the collaborators to have the chance to consider it, and then @hai-cea as well who the repo belongs to.

What are your thoughts on this PR as it relates to the library and flowtype in general?

@nathanmarks I'm not much familiar with the flow type syntax (I'm only using the weak mode at the office), but adding a type checker like Flow sounds like a very good idea.

you may want to check this out/merge quickly - I just had to re-merge and it can be a bit painstaking.

@rosskevin I still think that it would have been much simpler to start with the weak mode 😁 .
Have you considered making flow run on the CI tool?

I just updated to Flow 0.28.  Fixed new errors with Element and interpret new errors/required props.
Slide has a defaultProp problem that I need to solve, but I need to look at it in a few hours.
Since we are starting pretty fresh and building up on next, I would prefer to be strict.  I can add this to travis, I just haven't yet.

@rosskevin did you test to see what happens if you try build the markdown API docs? I think there's a command in the npm run scripts

@nathanmarks build isn't currently succeeding, build:docs also has a problem.  I have verified Flow type support in react-docgen

@rosskevin https://github.com/alienfast/material-ui/pull/1

@nathanmarks - better, only TouchRipple MuiThemeProvider have a problem (both the same):
Error generating markdown for TouchRipple
TypeError: Cannot read property 'name' of undefined
    at generatePropDescription (generate-docs-markdown.js:91:7)

But API docs are building and picking up comments on props.

@rosskevin It's because those 2 haven't got the flow type definitions yet so it's trying to access something that isn't there.
Outside of that, there's some other improvements that need to be made in general to the markdown generation (for example, 'union') which are also problems we have now anyways. All in due time! 👍

@alitaheri @hai-cea
Would love your guys' thoughts on this

It's probably going to be more work if we do this later as opposed to now but I'm really wondering if we should save this change for later. We really still need to make sure we get styles and adjusted component APIs right and I don't want this to be a distraction if we run into odd edge cases or quirks that need their own time working through.

@newoga if there is a file with a problem, simply remove // @flow from the top and put in a TODO:, that way flow succeeds until we figure it out.  I think that solves your concern.
Delaying this until later becomes a big liability that probably won't be overcome.  We are starting fresh on next and this initial work has already been completed and works well.

simply remove // @flow from the top and put in a // TODO:, that way flow succeeds until we figure it out. I think that solves your concern.

Personally, I'm not a fan of this approach. Leaving TODOs all over the place.

Delaying this until later becomes a big liability that probably won't be overcome.

Liability? How so? The same way you suggested you can remove // @flow tags file by file, we can add them file by file. I think everyone agrees we should explore this but once again, I don't think we should lose site on what we're actually trying to accomplish for 0.16.0.

This is not a hindrance, it is an advantage. I addressed your specific concern about an edge case holding up development.

BTW, the to-do comment was a suggestion, not a flow requirement. Flow by default is incremental, you have to add the tag for code to be checked, in this manner, and given the existing up front work and known advantages, I do not agree that there is cause to wait or that this loses sight of any present goal. Indeed, this furthers code quality at an almost zero expense.

@rosskevin Thanks for paving the way toward FlowType. We are now using the weak mode on 90%+ of the code base.
I'm sorry that we didin't merged this PR. I think that you were just too greedy.
Regarding using the annotated mode flow, I'm not sure it's ready yet. I had to skipped some files because of various issues. We have noticed the same thing at @doctolib.

@oliviertassinari -
I am extremely disappointed.  I had almost every file working without opting for weak mode, and the flow errors present appeared to be legitimate coding errors.  My approach was cleaner, stronger, and still had all the runtime checking.  How is this "greedy" when I went through all the effort to make it work?
The peer review portion was awesome and made this PR really good.  Then came 17 days of silence only for you to follow that up with something like using flow weak, which took very little effort compared to this PR and call it "flow has been implemented" (just check the changed files in #4813 vs this one).
I'm really put-off.  There was a lot of support for this, I went through the effort (and @nathanmarks helped), only to have you close it and take the path you did with no discussion.  This doesn't make me want to engage in more contribution, which I don't think is your goal, but nonetheless how would I better gauge that I should go through any other significant effort?

Hi @rosskevin, I'm sorry you feel this way. Let me explain what I mean by greedy.
Basically, you were expecting too much from us.
Migrating to flow, with annotation, is a big thing. It can't be taken lightly, we need to make sure it's going to worth the effort. Rule #1 of open-source: no is temporary, yes is forever.
Advantages:

Is it solving issues we are facing? (I'm pretty sure, that it does)

Risks:

Is it production ready yet?
Is the community adoption rate enough so that we don't deter new contributors?

Making sure of all of this takes time. Besides, the maintainers of Material-UI work on it during their free time, we don't have as much as we wish.
In the meantime, we are working on it from various time zones, with low coordination.
I know that you have put a great amount of effort to reach this point.
But this PR is blocking, we just can't block new commits for days waiting it to be finished.
(I should have seen it earlier)
To sum-up, starting this PR was a great idea 👍 ! I wanted to take advantages of flow with low effort and risk, hence my PR using flow weak.
Regarding what's ahead of us, I still think that we should be doing a proof of concept with flow annotation, migrating one component, not the all codebase 😁 .

I still don't understand.  I did the hard work, it was simply iterative after that point.  New code didn't even have to start off with @flow, it could have been refactored as it was hardened for use.  This doesn't impact production code, it only impacts pre-transpiled code, so it is production ready.
Here's a summary of the history:

This PR was finished
@nathanmarks added more code (which I warned about and he offered to help with a future rebase upon acceptance of this idea)
I rebased once to try to keep this PR in good standing (and it showed a some legitimate coding errors)
@nathanmarks asked for feedback from key maintainers
This sat for 17 days - dead silence
You closed it and used weak mode, throwing out all the work (@flow weak uses virtually none of this PR)

I did the work to get it here (in conjunction with @nathanmarks), and I would have done the work to get it integrated (which would take 2 hours to rebase, not days), but instead, no issues raised about it, dead silence for 17 days, then it gets closed even though there seemed to be strong support for it.
So, I don't think I was greedy and asking too much.  I had a strong showing of support, I did the hard work to get full flow type integrated, and it was simply thrown out with no discussion.
Without a doubt, I'm turned off from making any large contributions to this project.

@rosskevin The decision to not merge this PR had nothing to do with how complete this PR was and whether or not there were any outstanding issues. We just weren't ready at this moment to commit fully to flowtype in the manner this PR implemented it.
While mostly everyone generally supported implementing flowtype, I'm not sure it's fair to say everyone gave a "strong showing of support" with the approach presented in this PR. @oliviertassinari suggested that you make this contribution with weak mode on two different occasions: https://github.com/callemall/material-ui/issues/4515#issuecomment-229094570, https://github.com/callemall/material-ui/pull/4630#issuecomment-231177755. I also attempted to pump the break on this PR so that we could discuss in more depth and focus on other areas: https://github.com/callemall/material-ui/pull/4630#issuecomment-231488618. Nathan also reminded you that this is something everyone should discuss and agree on before moving forward: https://github.com/callemall/material-ui/pull/4630#issuecomment-231084990.
Nevertheless, no one on our side is saying this was a wasted effort. Trust me, everyone here that has stuck around has started something that we ultimately decided to hold off on. Also, pretty much every great thing I have seen happen to this project was because someone championed something they were passionate about improving. The reality is this project now has basic flowtype support and that wouldn't be the case if it wasn't for your contribution (original issue and this PR). 🎉
That being said, we're all busy, we're all volunteers, and many of us are in different timezones. Big changes like these take time. In addition, we rely very heavily on collaboration and teamwork here. We all work to make material-ui better for ourselves and the community, and share responsibility in its successes and failures.

I'm turned off from making any large contributions to this project.

That's unfortunate and I hope you'll reconsider. I personally apologize that I was not more explicit with my feedback. That being said, as a general rule for all projects, I think it's good practice to start with smaller contributions until you get a sense of the project climate and direction. Thank you for giving us the benefit of the doubt that it is not our intention to discourage contributions.


HOL46 #11132: Deploy a Microservice App Connected to Oracle Base Database Service

adding the updated lab guide for the HOL 46

Thanks! @arabellayao did a merge and removed the config.yml change


Motion events not registering in mqtt

I have an AD110 (working perfectly) and some other cameras. I can see in the docker logs that motion is detected, for example.
amcrest2mqtt-patio       | 2021-05-15T00:41:57.435637534Z 15/05/2021 00:41:57 [INFO] Fetching camera details...
amcrest2mqtt-patio       | 2021-05-15T00:41:57.700560756Z 15/05/2021 00:41:57 [INFO] Device type: IP8M-T2599E
amcrest2mqtt-patio       | 2021-05-15T00:41:57.700589185Z 15/05/2021 00:41:57 [INFO] Serial number: AMC0636AF1B5805A55
amcrest2mqtt-patio       | 2021-05-15T00:41:57.700597661Z 15/05/2021 00:41:57 [INFO] Software version: 2.800.00AC000.0.R
amcrest2mqtt-patio       | 2021-05-15T00:41:57.700602234Z 15/05/2021 00:41:57 [INFO] Device name: cam-bdoor
amcrest2mqtt-patio       | 2021-05-15T00:41:57.701789070Z 15/05/2021 00:41:57 [INFO] Writing Home Assistant discovery config...
amcrest2mqtt-patio       | 2021-05-15T00:41:57.702758883Z 15/05/2021 00:41:57 [INFO] Fetching storage sensors...
<clipped>
amcrest2mqtt-patio       | 2021-05-15T00:44:53.414712795Z 15/05/2021 00:44:53 [INFO] {'Code': 'VideoMotionInfo', 'action': 'State'}
amcrest2mqtt-patio       | 2021-05-15T00:44:53.551512079Z 15/05/2021 00:44:53 [INFO] {'Code': 'VideoMotion', 'action': 'Start', 'index': '0', 'data': {'Id': '[', 'RegionName': '['}}
amcrest2mqtt-patio       | 2021-05-15T00:44:53.992132885Z 15/05/2021 00:44:53 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'Data': '{', 'Id': '[', 'RegionName': '[', 'Event': 'VideoMotion', 'File': '\\/var\\/tmp\\/jpg\\/0\\/20210514204453922ch01.jpg', 'Index': '0,', 'Size': '558585,', 'StoragePoint': 'Temporary'}}
amcrest2mqtt-patio       | 2021-05-15T00:44:54.134519062Z 15/05/2021 00:44:54 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'File'<EMAIL_ADDRESS>'Size': '558545,', 'StoragePoint': 'NULL'}}
amcrest2mqtt-patio       | 2021-05-15T00:44:54.986224999Z 15/05/2021 00:44:54 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'Data': '{', 'Id': '[', 'RegionName': '[', 'Event': 'VideoMotion', 'File': '\\/var\\/tmp\\/jpg\\/0\\/20210514204454921ch01.jpg', 'Index': '0,', 'Size': '548193,', 'StoragePoint': 'Temporary'}}
amcrest2mqtt-patio       | 2021-05-15T00:44:55.108112320Z 15/05/2021 00:44:55 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'File'<EMAIL_ADDRESS>'Size': '548153,', 'StoragePoint': 'NULL'}}
amcrest2mqtt-patio       | 2021-05-15T00:44:55.990669974Z 15/05/2021 00:44:55 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'Data': '{', 'Id': '[', 'RegionName': '[', 'Event': 'VideoMotion', 'File': '\\/var\\/tmp\\/jpg\\/0\\/20210514204455921ch01.jpg', 'Index': '0,', 'Size': '560899,', 'StoragePoint': 'Temporary'}}
amcrest2mqtt-patio       | 2021-05-15T00:44:56.109361724Z 15/05/2021 00:44:56 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '0', 'data': {'File'<EMAIL_ADDRESS>'Size': '560859,', 'StoragePoint': 'NULL'}}

however, when i watch the messages that are published to mqtt, for the ad110, in the amcrest2mqtt topic, i see
status = online
storage
event = {"Code": "NTPAdjustTime", "action": "Pulse", "index": "0", "data": {"Address": "ntp.domain.com", "Before": "2021-05-14 07:53:46", "result": "true"}}
motion = off
doorbell = off

When motion is detected on the AD110, this motion topic changes from 0 to 1 accordingly, but with other cameras, I do not see this motion tag. If i look at the actual binary_sensor topics for _motion, there's actually no changing data here, for the ad110 or other cameras. Without the motion topic other cameras seem to not work, even though the container itself reports the motion.
I'm happy to provide additional information and/or logs as needed if that would be helpful.
here is an example of what i see from the ad110 (though i imagine you're familiar with this since you mention testing with an ad110
amcrest2mqtt-doorbell    | 2021-05-15T00:48:47.910596434Z 15/05/2021 00:48:47 [INFO] {'Code': 'VideoMotion', 'action': 'Start'}
amcrest2mqtt-doorbell    | 2021-05-15T00:48:48.343862751Z 15/05/2021 00:48:48 [INFO] {'Code': 'TimeChange', 'action': 'Pulse', 'index': '0', 'data': {'BeforeModifyTime': '2021-05-14 07:48:48', 'ModifiedTime': '2021-05-14 07:48:47'}}
amcrest2mqtt-doorbell    | 2021-05-15T00:48:48.606789318Z 15/05/2021 00:48:48 [INFO] {'Code': 'NTPAdjustTime', 'action': 'Pulse', 'index': '0', 'data': {'Address': '<IP_ADDRESS>', 'Before': '2021-05-14 07:48:46', 'result': 'true'}}
amcrest2mqtt-doorbell    | 2021-05-15T00:48:57.933003984Z 15/05/2021 00:48:57 [INFO] {'Code': 'VideoMotion', 'action': 'Stop'}
amcrest2mqtt-doorbell    | 2021-05-15T00:49:29.637682138Z 15/05/2021 00:49:29 [INFO] Fetching storage sensors...
amcrest2mqtt-doorbell    | 2021-05-15T00:50:29.637986985Z 15/05/2021 00:50:29 [INFO] Fetching storage sensors...
amcrest2mqtt-doorbell    | 2021-05-15T00:51:06.704531251Z 15/05/2021 00:51:06 [INFO] {'Code': 'VideoMotion', 'action': 'Start'}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:07.025653615Z 15/05/2021 00:51:07 [INFO] {'Code': 'AlarmLocal', 'action': 'Start'}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:08.263024721Z 15/05/2021 00:51:08 [INFO] {'Code': 'AlarmLocal', 'action': 'Start'}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:10.220181852Z 15/05/2021 00:51:10 [INFO] {'Code': 'ProfileAlarmTransmit', 'action': 'Start', 'index': '0', 'data': {'SenseMethod': 'PassiveInfrared', 'UTC': '1621021870'}}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:10.560296891Z 15/05/2021 00:51:10 [INFO] {'Code': 'UpdateFile', 'action': 'Pulse'}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:10.591809227Z 15/05/2021 00:51:10 [INFO] {'Code': 'NewFile', 'action': 'Pulse', 'index': '36425423', 'data': {'File': '\\/mnt\\/sd\\/SnapShot\\/2021-05-14\\/19\\/19-51-10[0].jpg', 'Size': '115122'}}
amcrest2mqtt-doorbell    | 2021-05-15T00:51:27.954298687Z 15/05/2021 00:51:27 [INFO] {'Code': 'ProfileAlarmTransmit', 'action': 'Stop', 'index': '0', 'data': {'SenseMethod': 'PassiveInfrared', 'UTC': '1621021886'}}

Just for additional info, since I know you mentioned only testing with ad110 and looking for feedback. I tested with the T2599E (not on the supported list but works) and the ip3m-941 (on the supported list)  Both show the VideoMotion trigger events, but neither update mqtt which means HA doesnt reflect the motion event.  I did use the mqtt auto discovery feature, so I will try to manually configure the mqtt later to test further, this may simply be something with the auto discover.

Thanks for the detailed report. I think the issue is that the cameras send different events to the AD110. The AD110 sends VideoMotion events when it detects any motion (even if it's outside the motion zones) and then also a ProfileAlarmTransmit event for motion events which are inside the motion zones and thus recorded in the app. Wheresas it looks like the cameras just send a VideoMotion event.
The app was listening just for the ProfileAlarmTransmit event but I've added an update to also listen for VideoMotion events for any non-doorbells. This should hopefully fix your issue 🙂


Netlify access request for v1.24 release

I'm requesting Netlify access for myself, @PI-Victor , and @jlbutler for the v1.24 release.
I’m asking for Jesse and Victor to also be added as I will be travelling on release day, and want to make sure that we’re still able to run release day activities even if my hotel wifi is terrible. Both Jesse and Victor have been docs leads previously (and are currently participating in v1.24).
My Netlify account is nate-double-u (same as I use on GitHub), and I believe I already have read access to v1.16 (or something like that), so I should already be in the Netlify userlist.
@PI-Victor, @jlbutler, please respond to this issue with your Netlify accounts to let the Chairs know who to give access to.
/assign @divya-mohan0209 @jimangel @natalisucks @reylejano
/milestone 1.24

/sig release
/sig docs

@nate-double-u for ease of reference, could you link to the part of the release docs guide that explains who should have Netlify access?

Sorry, didn't see your question till now Tim
https://github.com/kubernetes/sig-release/blob/master/release-team/role-handbooks/docs/Release-Timeline.md#update-netlify
Says "A SIG Docs chair can assist you with access", which suggests that the docs lead could do the work.

/triage accepted

/priority critical-urgent
(I assume)

@reylejano and @jimangel have been running the Netlify portion of the release.

Closing as @reylejano and @jimangel are on it this time around. Thank you both, your being on hand has made my travel-release much less stressful than it could have been. 🙂
/close


Stress test for HmacAuthenticationPolicy

HmacAuthenticationPolicyTest is designed to verify the correctness of the calculation of the request signature header in the HmacAuthenticationPolicy in a race condition.
Created performance test for  HmacAuthenticationPolicy using the template explained here and were created the following classes within azure-communication-common-perf module:

App -> main class, which runs all performance test classes
HmacAuthenticationPolicyTest -> performance test class, for testing process function of HmacAuthenticationPolicy. For HmacAuthenticationPolicyTest used default PerfStressOptions class (specifies the options bundle which can be passed via command-line arguments) as we will only change the parallelization values, which is already defined in PerfStressOptions.

Could not directly run against process function of HmacAuthenticationPolicy, which requires HttpPipelineCallContext and HttpPipelineNextPolicy parameters. The constructor modifier of HttpPipelineNextPolicy, HttpPipelineCallContext classes is package private, so cannot be initialized outside  azure-core package, that’s why the best option was testing it via HttpPipeline, by providing policy HmacAuthenticationPolicy.
During the initialization of HmacAuthenticationPolicy and HttpRequest, provided mock values as we will focus only on the performance of process function of HmacAuthenticationPolicy.
The test checks if the same signature is calculated for the request with the exact same signed headers values in parallel threads, otherwise an exception is thrown.

How often does it happen that you generate a request with the exact same x-ms-date? I'm concerned about wasting resources...

x-ms-date is epoch-based, so it should be fine

HmacAuthenticationPolicyTest would deserve some comments for future generations to understand what's going on :)...what the test is trying to achieve and how.

thx for adding the comments

/azp run java - azure-communication-identity - ci

/azp run java - communication - ci

/azp run java - azure-communication-identity - ci

/azp run java - communication - ci

/check-enforcer reset

/check-enforcer override

/azp run java - communication - ci

/check-enforcer evaluate

/azp run java - communication - ci

/check-enforcer override


PHOENIX-6277 upsert into data error after HBASE-24850,HBASE-24754 merged

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
14m 14s
master passed

+1 :green_heart:
compile
0m 53s
master passed

+1 :green_heart:
checkstyle
1m 41s
master passed

+1 :green_heart:
javadoc
0m 47s
master passed

+0 :ok:
spotbugs
2m 59s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 34s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

-1 :x:
checkstyle
1m 42s
phoenix-core: The patch generated 54 new + 2931 unchanged - 122 fixed = 2985 total (was 3053)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
spotbugs
3m  5s
the patch passed

_ Other Tests _

-1 :x:
unit
108m  7s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

146m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1039

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 93260006e8d6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 2bd02d4

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/2/testReport/

Max. process+thread count
6806 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Left few comments.
HBASE-24850 is not yet released, fixed version: 2.5.0, 2.4.1, 2.3.4 (in progress releases) and HBASE-24754 is still open.
However, as long as this patch stays with Phoenix 5.x, we are good since KVComparator is anyways deprecated. +1(non-binding) once comments are addressed. Thanks @wangchao316

thanks @virajjasani . change KVComparator reason have two :
1.KVComparator have deprecated, and hbase 2.x do not recommend using.
2.once hbase-24850 fixed 2.x version, phoenix base-function is impect.

Agree, this change is worth doing for 2.x support.

once hbase-24850 fixed 2.x version, phoenix base-function is impect.

Got it, so you are preparing in advance, nice!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
14m  0s
master passed

+1 :green_heart:
compile
0m 52s
master passed

+1 :green_heart:
checkstyle
1m 40s
master passed

+1 :green_heart:
javadoc
0m 45s
master passed

+0 :ok:
spotbugs
2m 55s
phoenix-core in master has 973 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 43s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

-1 :x:
checkstyle
1m 36s
phoenix-core: The patch generated 55 new + 2930 unchanged - 123 fixed = 2985 total (was 3053)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

+1 :green_heart:
spotbugs
3m 16s
the patch passed

_ Other Tests _

-1 :x:
unit
107m 41s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

146m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1039

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 8da1782754db 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 2adee98

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/3/testReport/

Max. process+thread count
6930 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/phoenix/pull/1039 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/phoenix/pull/1039

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/4/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wangchao316 can you once rebase with upstream? Dummy.java is already removed now, commit: https://github.com/apache/phoenix/commit/260520d5c1d2d38d27808fed59c1e4792b2c6942

@wangchao316 can you once rebase with upstream? Dummy.java is already removed now, commit: 260520d

Thanks @virajjasani ， I has rebased.

@wangchao316 looks like this PR still needs to be rebased (not merged) against the master branch

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
14m 15s
master passed

+1 :green_heart:
compile
0m 54s
master passed

+1 :green_heart:
checkstyle
1m 39s
master passed

+1 :green_heart:
javadoc
0m 46s
master passed

+0 :ok:
spotbugs
2m 51s
phoenix-core in master has 973 extant spotbugs warnings.

-0 :warning:
patch
2m 58s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 31s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

-1 :x:
checkstyle
1m 42s
phoenix-core: The patch generated 57 new + 2931 unchanged - 123 fixed = 2988 total (was 3054)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
spotbugs
3m  6s
the patch passed

_ Other Tests _

-1 :x:
unit
111m  9s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

149m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1039

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux f16c047871c0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / d097857

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/5/testReport/

Max. process+thread count
6734 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1039/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wangchao316 looks like this PR still needs to be rebased (not merged) against the master branch

@gjacoby126 hi, have passed


Zkevm comp

Motivation
As part of https://github.com/snarkify/sirius/milestone/4
Overview
Make less strict deps of some crates & impl From<Halo2Error> for `sirius::SynthesisError~

https://github.com/scroll-tech/poseidon-circuit/compare/main...snarkify:scroll-poseidon-circuit:main


PPC Trigger: Blank Story

Description
When a user creates a new story it is blank and we should not display any messages or warnings on the pre publish checklist.
Implementation Suggestions

We should create an isEmpty property on story data before tackling these triggers (#7145). This will allow us to trigger the PPC when we need it while keeping the logic for what an "empty" story is out of the checklist and in the story itself. An empty story is any story with just a background color set.

Acceptance Criteria

When a user creates a new story don't trigger any PPC suggestions. No more icon next to checklist title in panel tab, no icon on publish button. Both high priority and recommended tabs of ppc are disabled. Accordion arrows are gone.
Should also include updated unit tests

https://www.figma.com/file/1YM3jA9h4QGc4xLdyaXIJS/Stories-Sprint-1.7?node-id=7045%3A7520

I feel like this would mostly get taken care of in this PR with the proof of concept being firing an event onDirty for the story here:
https://github.com/google/web-stories-wp/pull/7259
Then the rest by tying in Brittany's state machine for PPC PR here:
https://github.com/google/web-stories-wp/pull/7241#discussion_r616026968

@littlemilkstudio  - agree, this ticket feels like the natural test case for the implementation.

@csossi - next time you do QA for pea pod please do this one first, we need it to unblock 2 other tickets.

Added an element and now seeing the "Recommended" messages
Deleted the element to return to a story with no content. Messages remained - shouldn't they be removed at this point?

@csossi - the enabling will not revert. Once a section is enabled it should stay enabled.

Verified in QA


FWUV-201 - Extend prefixed attribute mapper with RegEx

I'll create us a ticket to discuss if we need/should some protection against bad configured regexes. But think that we can trust the few users who have the permission to config that regex, to not enter harmful regexes.


warning in BatchSQLClient.create_and_wait_for_completion seems too severe

Another type of message (or even no message at all) seems more appropriate.
https://github.com/CartoDB/carto-python/blob/867337a9160f220f87e45b68356665ffe3a6d09f/carto/sql.py#L229
The current behavior results in lots of pink warning messages in cartoframes whenever a users uses CartoContext.execute:

cc @alrocar

We can close this one because we have removed those warnings :)


Probable invalid name in property added from Studio; can not connect to database

Can not connect to database anymore
Hello, after creation of a database using studio (http://localhost:2480/studio/), I can not connect to the database anymore. I used Orientdb 2.1.1 community.
I would like to fix the issue and be able to export and use again the database we have created. How could we proceed?
When I try to connect, the situation is the following:

shell
"orientdb> connect remote:localhost/NameOfDatabase root mypassword
Connecting to database [remote:localhost/NameOfDatabase] with user 'root'...
Error: com.orientechnologies.common.exception.OException: Error on creation of shared resource
Error: com.orientechnologies.orient.core.exception.OSchemaException: Cannot add base class 'FF_DocumentVersion', because of parameter conflict: creationDate (type=DATETIME) vs creationDate (type=DATETIME)"

My boss at work downloaded the community version from Github, commented the control and recompiled; now we can connect to the database and export the database.

Probably a command line parameter could be introduced, to skip that kind of checks and retrieve the database in case a similar thing happens

@AndreaPravato I have the same issue. it is possible to publish your solution?

fixed long time ago, is a duplicate, closing


Can't install node-sass on Windows

Followed this troubleshooting steps
Here are the logs:
https://gist.github.com/emzero/57802b5e1d293fbc1514e9a413cfe2c5

NPM version (npm -v):
5.3.0
Node version (node -v):
8.6.0
Node Process (node -p process.versions):

{ http_parser: '2.7.0',
  node: '8.6.0',
  v8: '6.0.287.53',
  uv: '1.14.1',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '57',
  nghttp2: '1.25.0',
  openssl: '1.0.2l',
  icu: '59.1',
  unicode: '9.0',
  cldr: '31.0.1',
  tz: '2017b' }

Node Platform (node -p process.platform):
win32

Node architecture (node -p process.arch):
x64

node-sass version (node -p "require('node-sass').info"):
Error: Cannot find module 'node-sass'

npm node-sass versions (npm ls node-sass):
-- (empty)

You're trying to install 3.13.1 with Node 8, there are many issues that explain this isn't supported

So which versions are actually supported...?


Roll Packages from 26e123a6ce03 to b9ac917daeb0 (5 revisions)

https://github.com/flutter/packages/compare/26e123a6ce03...b9ac917daeb0
2024-11-13<EMAIL_ADDRESS>[in_app_purchase_storekit] Fixes manual invocation of finishTransaction() triggering fatal crash (flutter/packages#8071)
2024-11-13<EMAIL_ADDRESS>[webview]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7988)
2024-11-13<EMAIL_ADDRESS>[in_app_purchase_storekit] Remove unneeded platform annotations  (flutter/packages#7914)
2024-11-13<EMAIL_ADDRESS>[tool] Improve Swift lint error message (flutter/packages#8074)
2024-11-13<EMAIL_ADDRESS>Roll Flutter from c8510f29ccc2 to ed553d10cf63 (48 revisions) (flutter/packages#8076)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[LO_W4.11d][T10-3]Russell Ong Ren Yih

Work in progress

This PR/issue should be against a repo in the org nus-cs2103-AY1819S1 not against the repo in se-edu org :-)
Closing...

Furthermore, the PR should contain only the code related to the LO. This PR seems to contain a quite a lot more than a JUnit test.


Localization TinyMCE

Is it possible to locate TinyMCE with the language setting of Camaleon CMS ? When I change the language of the CMS, the language of TinyMCE doesn't change

Done!
please bundle update to update the version.

Ok, thank you very much!
Il 03/09/2015 11:29, Owen Peredo Diaz
      ha scritto:

Done!
please bundle update to update the version.
—
Reply to this email directly or  view
          it on GitHub .
--
Stefano Pau
Soc. Coop. welaika
http://dev.welaika.com/


not reading published config file

Hi,
for some reason, the copied config file is not being read. I spent a long time trying to find what I was doing wrong, without any success. I was getting an error message on the console saying: missing site key. So I put the site key string directly on the config file inside the vendor folder, since then I didn't get the error message anymore. Am I doing something wrong or there is indeed a bug?
Thanks.

Have you tried php artisan config:cache?

If you still had no success, I will take a look tonight. We will sort it out.

Hi RyanDaDeng, I tried, no success. Any ideia?

@henriquepalazzo I tried to install a fresh package on a new project, it doesn't have issues for me.
my laravel version: 5.8

run publish to have a config in your local

adding secret and site key

Adding two routes:
  Route::get('echo', 'EchoController@echo');      Route::post('echo2', 'EchoController@echo2');

Adding blade:
<form method="POST" action="/api/echo2">                  @csrf                  {!!  GoogleReCaptchaV3::renderField('contact_us_id','contact_us_action') !!}                  <input type="submit" value="submit">              </form>  {!!  GoogleReCaptchaV3::init() !!}

Create a controller:
`class EchoController extends Controller
{
public function echo(Request $request)
{
return view('welcome');
}
public function echo2(Request $request)
{
dd(GoogleReCaptchaV3::verifyResponse($request->input('g-recaptcha-response')));
}
}`

The problem in your case is that the config file is not being picked up. It's usually caused by cache issues. What's the Laravel version are you using at the moment?


t.typeText() not triggering onChange function in textbox

What is your Test Scenario?

I have a text field and a disabled button inside the shadow dom. Once text is typed into the text field the button should become enabled
What is the Current behavior?

.typeText() types the text correctly into the text field and can test that this is correct but the onChange event in the text field to enable the button is never called
What is the Expected behavior?

once the .typeText() starts typing the onChange event in the text field should be called which will change the button from enabled to disabled.
What is your web application and your TestCafe test code?

Execute this command...
See the error...

Your Environment details:

testcafe version: 1.3.3
node.js version: 11.6.0
command-line arguments: testcafe chrome ./testcafe.js
browser name and version: chrome 75
platform and version: Windows 10

Hello @andym0457,

The сhange event fires for <input type="text"> only after the input element loses focus (documentation). So if you change the mutual order of the assertion and the click as follows:
.click(button1)
.expect(button1.hasAttribute('disabled')).notOk()

the test should pass.