Feature or solution to stop Leaflet from processing unnecessary markers?

My Leaflet map is receiving data asynchronously from Django from a DB of millions of entries and it appears Leaflet continues to process all markers unnecessarily until the browser lags out. The issue seems caused by two things:

Leaflet processes markers outside of its boundary box
I think my code might be allowing Leaflet to inappropriately process duplicate entries.

I've asked this over on StackOverflow and didn't get a response, which suggests I'm out of luck.
My code, adapted from @pauloxnet's great tutorial:
async function load_markers() {
const markers_url = `/api/markers/?in_bbox=${map.getBounds().toBBoxString()}`
const response = await fetch(markers_url)
const geojson = await response.json()
return geojson
}

async function render_markers() {
const markers = await load_markers();
L.geoJSON(markers)
    .bindPopup((layer) => layer.feature.properties.address)
    .addTo(map);
}

map.on("moveend", render_markers);

Is there a way to make Leaflet stop processing markers furthest away from its bbox if > n entries or similar?
And might .addTo(map) be allowing duplicate entries? Is there a way to elaborate on this so that only new markers are added if they don't already exist?
I'm new to JS and programming so I'm sorry for the stupid questions. These questions seem conceptually simple so I'm thinking perhaps I've overlooked some basic feature. Please feel free to tell me to go away or ask elsewhere. Thank you so much for any help!

Leaflet can't do that automatically, but you can track duplicate markers with a JS Map object with marker location (or id if provided by server) as key, and marker object as value. Hope this helps and sorry for not elaborating further — we have limited resources for JS questions here.


Storer Interface time.Now() for Created and Updated fields return unsupported time formats

Introduction:
Using the REST Layer to build a large scale API for commercial product, we have reached a point to build our own Storer interface for PostgreSQL, heavily inspired by the SQLite and MongoDB implementations we have been able to succesfuly produce the following storage "add-on" (for PostgreSQL, but it can be easily ported to any SQL-based database) and are happily to opensource it for the community:
https://github.com/SAFAD/rest-layer-pgsql
Issue :
We have faced an issue with the Storer interface where using the pointer to resource.Item struct to pull the created/updated fields we receive wrong time.Time format as following:
2018-02-27 23:07:44.4179416 +0100 CET m=+7.679574500
where  m=+7.679574500 is additional string that is appearing from nowhere, and causing the entire API to panic when trying to format it/use it in database queries
Reproduction:
Use the storage handler mentioned above, and add a logger or simply print the resource.Item data
Results:
Mis-formatted time.Time data
Expected results:
Correct time.Time data that is able to be parsed and formatted with time.Parse/time.Format
Conclusion:
We have been able to workaround this bug for now using a hack but it is not good for code quality or maintainability.
We would also love to hear your input on the library provided above and if anything missing or needs to be fixed.
Best Regards

where m=+7.679574500 is additional string that is appearing from nowhere, and causing the entire API to panic when trying to format it/use it in database queries

It's not appearing from nowhere, it's to Go monotonic time component added in Go 1.9 https://golang.org/doc/go1.9#monotonic-time.
It can be stripped away by calling Truncate(0) on the time object before serializing it and/or by setting intial values to time.Now().Truncate(0) instead of time.Now().
I suppose in rest-layer we should update schema.Now to call Truncate(0):
https://github.com/rs/rest-layer/blob/a468556f73fd817100bf3b2a2d07dcf4ee19d1df/schema/time.go#L13

https://github.com/rs/rest-layer/blob/a468556f73fd817100bf3b2a2d07dcf4ee19d1df/schema/time.go#L13

Awesome 😃

I have tracked down the issue till time.Now() in time.go schema and went on to even go around golang's time source but haven't checked down to monotonic feature as of go 1.9 (which I use by default now).
I guess this can be filed as a "bug" ?
Also, I will create a new Issue suggesting using unixtime as default time field in REST Layer, it is easier to manipulate both server and client side and is more carefully standardized than other time formats.

Also, I will create a new Issue suggesting using unixtime as default time field in REST Layer, it is easier to manipulate both server and client side and is more carefully standardized than other time formats.

I am not quite sure I understand what you mean by that in this context. Most used in C and Go are probably int64 seconds since the epoch(limited precision), and int64 nanoseconds (limited range) since the epoch. In many databases, e.g. PostgreSQL TIMESTAMP, time stamps are typically stored in microseconds since the epoch, which again give different range and precision properties. The most popular JavaScript libraries use millisecond precision (to the best of my limited knowledge).
I believe the best thing rest-later can do by default is to use the built-in Go time.Time struct together with the well defined test formats it defines. This also makes it easy for a storage backend to tell a time fields apparat from a an integer.
It could be I don’t fully understand what you ask for.

I don’t think REST layer should truncate the time. What if other storers want to use this to mesure timing for instance?

@smyrman see this: https://play.golang.org/p/kiijB0T3agv it is not unix timestamp by default in golang, its formatted.
@rs Definitely shouldn't truncate the time that comes by default from Go however this exposes us to two main issues:

As seen, changes between versions (of Go) can cause issues, for example you can not use time.Parse to parse this new time specification.
There is no standardized way for timestamps in REST Layer, which means that any changes (like pointed in the first issue) can cause the API more harm than good.

Thus, I suggest using UNIX timestamp as default for REST Layer.

With UNIX timestamp we loose definition (second instead of nano) and ability to store dates before 1970. It would be also less efficient as most storers would have to convert them back to time.Time to reformat it.

SQL Based Storers already convert and parse the time.Time format to use it already (check the outdated SQLite 3 implementation) which raised this issue in the first place (the introduction of monotonic time in Go 1.9).
Now if we agree that it is OK to use the default time.Time format as is, we should consider the issue raised by Go 1.9 as it can not be parsed with time.Parse (See example here)[https://play.golang.org/p/R9oxdfeD5Ap] which seems to be a problem with Go itself.
Other than the default time.Time format should be taken into consideration.

Regarding the pgsql module, it's awesome! Thanks fort the contrib. Feel free to send a PR to add its reference to the README.
Some feedback:

There are some SQL injections opportunity:

utils.go#L157
pgsql.go#L262 (Etag is opaque and not sanitized by REST layer IIRC).
pgsql.go#L296
pgsql.go#L297

Using LIKE on equality (see utils.go#L83) is breaking the REST Layer API. Pattern matching should only be enabled when $regex is used.
At utils.go#L52, it would be more efficient to store substrings in a slice and use strings.Join (or to use a bytes.Buffer).
Same remark for most of string concats in the rest of the function.
Same remark in valueToString and valuesToString.
At pgsql.go#L58, rowVals and rowValsPtr could be reused for each lines to avoid allocation.
At pgsql.go#L279, do a[:len(a)-1] = ")" (same for next line) to avoid two allocations.

Regarding time, as explained in the doc for String:

The returned string is meant for debugging; for a stable serialized representation, use t.MarshalText, t.MarshalBinary, or t.Format with an explicit format string.

A JSON serialization would use MarshalText on the time. String on types in Go is most of the time not meant for serialization.

I don’t think REST layer should truncate the time. What if other storers want to use this to mesure timing for instance?

I thought about it, but storing the monotonic time? It's as far as I know process specific, is it not? I do agree we should not truncate any precision on the non-monothonic component. That said, I suppose if we use the correct MarshalText method, it should be a non-issue.

@rs Thank you for taking time to check our library, the current implementation is more of a Proof of Concept rather than a true implementation, it will be entirely overhauled later (as it is hard to read and maintain).
@rs @smyrman regarding the time issue, I will try and use MarshalText later and see the results, however for the current project we are working on it is a requirement to use UNIX timestamp for time, thus I will implement in my fork and use it for this project and continue maintaining the fork as the project needs and issue suggestions and PRs here for features we implement.
One final note: have anyone tested the library with MongoDB/ES/Google Datastore with Go 1.9 to see if there is an issue with the newly appended Monotonic time?

@smyrman you're right, ok to truncate it then.
@SAFAD why do you need to fork to use UNIX time? I'm not sure to understand.

@rs @smyrman regarding the time issue, I will try and use MarshalText later and see the results, however for the current project we are working on it is a requirement to use UNIX timestamp for time, thus I will implement in my fork and use it for this project and continue maintaining the fork as the project needs and issue suggestions and PRs here for features we implement.

Rather than a fork, you could just implement your own FieldValidators and ready  Fields for your particular application.

One final note: have anyone tested the library with MongoDB/ES/Google Datastore with Go 1.9 to see if there is an issue with the newly appended Monotonic time?

@SAFAD, we have been using the MongoDB backend built with Go 1.8, 1.9 and 1.10 for a while without any issues related to Monotonic time. We are using the rest-layer schema.UpdatedField and schema.CreatedField.
btw, feel free to join us at #rest-layer on gophers.slack.com for any general questions you may have, not related to any particular issue.

At utils.go#L52, it would be more efficient to store substrings in a slice and use strings.Join (or to use a bytes.Buffer).

Not necessarily true :-P I think if you use a slice the data will probably escape to heap (rather than being generated in the stack), while for simple string arithmetic operations, most likely all the variables will be allocated on the stack, which means the memory will be automatically cleared when the function goes out of scope. In addition, if e.g. adding together mulitple strings on one line, the compiler may be smart about it.
Not worth pre-optimizing in other words. Make it work safely an correctly, and then benchmark to make it faster later on;-)

I had similar problems when writing the first POC of https://github.com/apuigsech/rest-layer-sql.
The reasons were incompatibilities on time formats between different parties that happens because I was building the full query on my own.
Switching it to prepared statements allowed the SQL driver to handle it properly and the issue was fixed. In addition, it is best practices and safe to SQL injection attacks by design.
The Storer Handler I did should be valid for pgsql too, so I encourage you to try it.

I am going to close this issue; one is supposed to use the Time's Format method, and not it's Stringer interface for getting a value that's not for debugging purposes.
Still,  PR #219 is slightly related, as it will remove the monotonic time component when validating times.


[4.2] Fix crash during code editor folding and LSP

Chery pick of #92301

I usually do cherry-picks myself in batches, in a way that preserves the relation with the original master PR so that it's easy to trace back from the changelog: https://godotengine.github.io/godot-interactive-changelog/
A dedicated PR is only needed if the change isn't trivial to cherry-pick and warrants some more work from the original author who understands the context of the fix, and can adapted to a slightly older codebase. But here it does seem trivially cherry-pickable.

@akien-mga got it sorry for the noise closing this!


When flex is used as a display value it should be autoprefixed

Right now, the display function takes three supported values: auto, none, and block. It would be great if Velocity would take a flex option as well and autoprefix it to support older browsers.

+1 for this just working


Documentation for version 0.15.0

Hello Guys ... where can I access the documentation for version 0.15.0 ? Thanks

https://github.com/jacklam718/react-native-popup-dialog/tree/f76849c152098924cfb6c81ff53df0ed61f1c3b3


Lookup: Missing space between note title and vault name

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[x] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
In the lookup, in a multi-vault setup, there is no space at all between the note title and the vault name.
To Reproduce

Have a multi-vault setup
Have some notes
Open lookup

Expected behavior
It would look better if there was some space between the note title and the vault name.
Screenshots

Desktop (please complete the following information)

OS: Windows 11
Browser (if with published websites; include version): Edge
Versions (all that apply to bug):

Dendron Extension: 0.82.0
VS Code version: 1.64.2

Thank you for the suggestion. I'll see if I can sneak this in for next week's release 😄

Is this still an issue that needs work? I'd like to give it a shot if so :)

Is this still an issue that needs work? I'd like to give it a shot if so :)

@saifahn
Sure. we always welcome contributions 😄
This should be a one-line fix in DNodeUtils.enhancePropForQuickInput
I apologize for folks who are waiting for this. I meant to pick this up but must have slipped my mind.

has been fixed as of 0.107


podalize only processes via CPU

Hey there,
i finally made podalize running with Windows 10. The only issue that remains, that every single process of podalize is happening over the CPU. CUDA toolkit and pytorch cuda is installed. Does podalize automatically detects if CUDA is available?
Best,
Marcel

@naturian Nice making it work  on Windows. You can share the how as a pull request.
On Ubuntu, it automatically detects my GPU.
Try to see if PyTorch can detect your GPU in a separate script:
>>> import torch
>>> torch.cuda.is_available()
True
>>> torch.cuda.current_device()
0
>>> torch.cuda.get_device_name()
'NVIDIA GeForce GTX TITAN X'

I think i've installed the cpu only repos. got to figure it out. i'll do a pull request when i fixed the problem. nice script btw!

Any idea how to get it running on mps with mac m1? Was very impressed with the quality and accuracy of the output, but it took about 12 hours to get it to output one transcript

Hey, @donzthefonz! any progress with M1?


Cannot recover for error

gulp.src('./src/js/**/*.js')
  .pipe(ngFilesort())
  .on('error', function(er) {console.error(er);} );

Prints the error and recovers from it, as expected.
However, wrapping up in streamqueue prevents the script from recovering from the error.
Both:
streamqueue({ objectMode: true },
  gulp.src('./src/js/**/*.js')
    .pipe(ngFilesort())
    .on('error', function(er) {console.error(er);} )
);

and
streamqueue({ objectMode: true },
  gulp.src('./src/js/**/*.js')
    .pipe(ngFilesort())
).on('error', function(er) {console.error(er);} );

fail with
events.js:72
        throw er; // Unhandled 'error' event

You need https://www.npmjs.com/package/gulp-plumber ;)

That's the first thing I tried, but it didn't work :pensive:

Won't be able to help more without stack trace but except if there really is a bug in streamqueue, i assume the error come from the gulp.src stream so it is normal that it isn't cought up in the above examples.
It it isn't the case, please create a failing test/project setup in order for me to investigate and reopen the issue.

@nfroidure thank you for your follow up with this
The error comes from ngFilesort() when there is a file with a syntax error.
Could you please point me how I should properly catch the error? I will create a failing test with it

Since StreamQueue reemits errors whenever you already listen to them on the streams you provide to him, the following still throws and it is normal:
streamqueue({ objectMode: true },
  gulp.src('./src/js/**/*.js')
    .pipe(ngFilesort())
    .on('error', function(er) {console.error(er);} );
);

We could however allow to avoid reemiting with such an option https://github.com/nfroidure/plexer#optionsreemiterrors .
In the other hand, the following should not throw since streamqueue listen to errors on the given stream https://github.com/nfroidure/StreamQueue/blob/master/src/index.js#L92 :
streamqueue({ objectMode: true },
  gulp.src('./src/js/**/*.js')
    .pipe(ngFilesort())
).on('error', function(er) {console.error(er);} );

So if you have a use case when the above fails (and the error doesn't come from the gulp.src stream and ngFileSort doesn't fire error events synchronously), just add it the and PR the repo https://github.com/nfroidure/StreamQueue/blob/master/tests/index.mocha.js.

The last example does not catch the error for me.
When I have some time I will investigate ngFileSort error fire and add the test if appropriate.

Also, check your StreamQueue version, provide your NodeJS version and just paste the full stack trace of the error in the meanwhile.

$ npm list streamqueue
└──<EMAIL_ADDRESS>
$ node -v
v0.10.38

console.log(error) output:
{ [Error: Error in parsing: "test.js", Line 1: Unexpected identifier]
  message: 'Error in parsing: "test.js", Line 1: Unexpected identifier',
  showStack: true,
  showProperties: true,
  plugin: 'gulp-angular-filesort',
  __safety: { toString: [Function] } }

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: Error in parsing: "test.js", Line 1: Unexpected identifier

console.log(error.stack) output:
undefined


Fix stdenv-native and fix rebasing on cygwin

Motivation for this change
As described in issue #38825, stdenv-native is broken on master and release-18.03 because the mandatory bintools parameter is not propagated. This pull requests fixes this.
Furthermore, on Cygwin rebasing is also broken. When I try to build any package on Cygwin, it will show:
rebase: Invalid Baseaddress 0x200000000, must be > 0x200000000

It appears that increasing the base offset by 1 seems to do the trick.
In addition to merging this to master, you probably want to cherry pick and apply this to release-18.03 as well -- it has exactly the same problem.
Things done
Compose a bintools package, change the base offset

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@vcunat @Ericson2314 What do you think about these changes? From the commit history I see that you both are involved in these areas.
I have the rights to merge this myself, but since this affects stdenv, and stdenv affects pretty much everything else, I don't just want to push this without anyone else reviewing.
As far as I can see, it will not trigger a mass rebuild, since only the native stdenv and cygwin areas are affected. Linux and darwin are untouched.

Thanks for pinging me! No idea what this rebase thing is, but whatever. The nix changes definitely look good, so thanks so much!
CC @thoughtpolice you wanted this, now you have it :).

Haha -- thanks a lot Sander, and thanks John for the ping on this! I'll get around to seeing how this works sometime this week I hope...


Images too wide (much wider than 3x2) can mess up layout

Here's an example:

This should only apply to the wide-window view, probably.

We probably want to force a specific aspect ratio, like Facebook does. This probably means incorporating an image cropper into the upload page.

Ratios narrower than 3x2 are fine, though.


changelog: re-order entry after recent merges in master

Summary
As the title says. Just a minor thing to keep the changelog in order so it's correct for the next release and can be copy pasted.

The style fix is unrelated, guess there was an update to php-cs-fixer or whatever => it's "good" IMHO.

The style fix is unrelated, guess there was an update to php-cs-fixer or whatever => it's "good" IMHO.

Hmm test is failing still

Hmm test is failing still

Hmm test is failing still

See https://github.com/barryvdh/laravel-ide-helper/pull/1139 , it's unrelated to changelog/php-cs-fixer but a result of the macro merge recently (probably had an outdated php-cs-fixer I guess

Hmm test is failing still

See https://github.com/barryvdh/laravel-ide-helper/pull/1139 , it's unrelated to changelog/php-cs-fixer but a result of the macro merge recently (probably had an outdated php-cs-fixer I guess


Outdated docs for Cascade Delete

Hello, According to EF Core 3.x we have 7 key-value pair in DeleteBehavior Enum,
and this page just covered 4 of them.
please Edit and Update documents of Cascade Delete.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ed1b8a1-fa32-e147-ae0f-76b3620473f9
Version Independent ID: 10ce2d9f-8284-a509-5fed-669abfb9d8ae
Content: Cascade Delete - EF Core
Content Source: entity-framework/core/saving/cascade-delete.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: avickers

This is being tracked by #473


Clarify the docs for partitioned(by:)

As currently written, the summary for partitioned(by:) heavily implies the return value is (trueValues, falseValues). In fact, it’s the opposite. I rephrased this summary to clarify that (1) the order is (falseValues, trueValues) and (2) the elements of the two returned arrays are in the order they were in the original sequence/collection.
Checklist

(N/A) I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci please test

@swift-ci please test

@swift-ci please test


Bug: Fix the thumbnail image aspect ratio in the 'new comment' notification

The thumbnail image in the 'new comment' notification is stretched. The aspect ratio of the image is ignored. It looks a little bit strange.
This patch will cover the image like it is in the 'react to comment' comment.

Hi, this is already fixed and merged in #226

Hi @Arcus92 , indeed and sorry, we should add a remark on cloning from the develop branch. Thanks for the contribution anyway!

Sorry. I should've checked the branches first.


Add strict mode option

sax-js offers a strict mode option that can be off or on. When in strict mode, non-standard XML entities (for example, –) cause sax to error and even return duplicated text.
This option will allow users to turn of strict mode if they wish to forgo strict XML parsing.

Sorry, what entity does not work? I think GitHub broke that part of your message.
(And sorry for not responding earlier, somehow I missed the notification)

Any entity not in this list breaks it: http://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references#Predefined_entities_in_XML
The one I was trying to use as an example is —
This is a major problem for parsing RSS feeds, because many include HTML entities.

Ok, that's indeed a problem. Could you add some documentation and unit tests? Then I'll be happy to include it.

Sure, I will add those sometime soon


How to add s3 bucket manually after project creation?

Do I just manually type it in here in the makefile? : BUCKET = {{ cookiecutter.s3_bucket }}

Yes, this is the only place it is used:
https://github.com/drivendata/cookiecutter-data-science/blob/master/{{ cookiecutter.repo_name }}/Makefile#L8


docs(infrastructure): Update README and dev docs for v2

Update README, CONTRIBUTING, and docs/DEVELOPER with relevant v2 info
Add support for commitizen for easy commit messages

Resolves #4464
[Delivers #126818909]

All LGTM, thank you!


Site Analytics

User Story: Site Analytics
URL: https://github.com/suwebdev/mingled-worlds/wiki/User-Story:-Site-Analytics
Sizing: Small
Priority: Low
Reasoning:
While not imperative to the overall site, setting up the goals and data tracking will provide the team with valuable information to help guide our future sprints.

Created user-tracking branch

Added Google Analytics Global Site tag to head.

    <script async src="https://www.googletagmanager.com/gtag/js?id=UA-122925590-1"></script>
    <script>
      window.dataLayer = window.dataLayer || [];
      function gtag(){dataLayer.push(arguments);}
      gtag('js', new Date());
      gtag('config', 'UA-122925590-1');
    </script>


Project Application Process Doc section

Documentation Section for Adding New Projects:
What Nivenly Provides
Transparency around what we can assist a project with. Will need to dive into both the succinct and significantly-less-succinct descriptions of this. Some things to include:

Governance
Trademarks
Networking to augment devs

Esp important for new and/or solo-maintainer projects

Mechanics of How to Apply

They contact us via email to express interest and some initial information about the project, where they're at with it. This should be no different than any other intro-type email.

Alternatively, we can also make a simple form for users to reach us to express interest and we respond?

We generate a Google Doc that they complete

Documentation page should include the expectations for what that doc will request.

Once ready, we can include a couple of projects with applications that we've liked for people to see what "good" looks like in terms of how much detail and what kind to include.

They let us know when the doc is complete (and ask clarifying questions to get it into a good state)

How Nivenly Processes Applications
Transparency in how projects are evaluated and accepted as a Nivenly project.

First year the board is making individual decisions. Later years will involve more collaboration.
Part of being an early project will be helping ironing out processes to make them more beneficial and streamlined for future years.

As relates to governance that interfaces with Nivenly.

The Projects Themselves

Each project should have a page on the wiki that has a minimum of one paragraph and a maximum of ~500 words (~1 printed page) of description.
Each project page should include a link to the GitHub repo or org and individual website (if there is one).
Project header information will look something like:

Project Name: NAME
Project Maintainers: NAME, LIST, LINK (to page and/or GitHub contribs) - will need some consistency but also a way that the info isn't impossible to maintain over time.
Project Data: LIST OF LINKS (not to be confused with a linked list 😉 ) -> GitHub, web page, etc. all here.
Project Description: This is the 1 ¶ - 1 page description of the project.
Will need consistent placement of project logos if/when present.

When writing the above what the project chooses to include should be actionable so that it is possible to see how / where / when the project followed through with their promised intent.


Document Browser support matrix for Blazor

We don't have a formal Prerequisites section any longer. If you let me know where you'd like this, I can take care of it.

SignalR has a Supported platforms doc that has their browser support matrix. How about we add a similar doc for Blazor?


BREAKING CHANGE(web-twig): Remove Twig boolprop filter and its extension

Description
We do not use it anywhere and we don't recommend it, why not remove it?
Additional context
This wasn't mentioned in the issue, so I created a separate PR and we can decide if we want to do it or not.
Issue reference
#DS-798

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the PR Title/Commit Message Convention.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

coverage: 96.46% (-0.09%) from 96.552% when pulling 7fe96ffe3ead7bf9856bc437a8d9e582533e36b3 on bc/boolprop-filter into 4e32893672a7fa68354c1a01d58853b6ed508c68 on bc/boolprop-components.


keep node_env if provided from upstream

Hello, this is tiny configuration that would allow the  use of react-script start for browser e2e tests.
  "scripts": {
    "start": "react-scripts start",
    "start:test": "NODE_ENV=test react-scripts start",
...

So then inside index.js I could decide wether it is a dev build or integration test build.

if (process.env.NODE_ENV === 'test') {
  Enzyme.configure({ adapter: new Adapter() });

  const wrap = (<Provider store={store}><App />< /Provider>);

  const el = Enzyme.mount(wrap,
    { attachTo: document.getElementById('root') }
  );
  iTest(el);
} else {
  ReactDOM.render(
    <Provider store={store}>
      <App />
    </Provider>,
    document.getElementById('root')
  );
}

More details here:
https://github.com/DianaSuvorova/Demo-project/blob/master/frontend/package.json
https://github.com/DianaSuvorova/Demo-project/blob/master/frontend/src/index.js
Thanks,
Diana

Hey, thanks for the PR!
I don't think we'll take it as is. Unfortunately people often don't understand that NODE_ENV has a special meaning for React, and set it to custom values for production. So if we allowed this, people would misuse it and end up with development builds of React in production.
What do you think about using a special variable for this? e.g. REACT_APP_IS_E2E_TEST. Would that not work for you?

@gaearon , thanks for suggestion, this will work just fine. Didn't realize I could set an arbitrary variable on process.env. Will close PR.

As long as it starts with REACT_APP, you can read it from the app. The limitation is intentional to avoid accidentally leaking sensitive data in the bundle.


MS-MPI uninstaller doesn't delete msmpi.dll

Installing MS-MPI using the official installer (msmpisetup.exe, tested with version 10.1.12498.18) brings msmpi.dll:

Uninstalling that package however doesn't seem to remove that library...

The following was an answer I got from Anh Vo back in August 2016, on this topic:

Unfortunately dll’s that are installed to c:\windows\system32 are considered permanent and do not get removed.

The additional information I was given back then was that we can distribute the MS-MPI DLLs with our packages and place them in the same folder as the executables that need them. This way we don't need to install MS-MPI at the system level.


Saves exception context on rethrow in processExpectedInfo

Conn.processExpectedInfo loses the stack trace via throw e, switched to a bare throw to rethrow with the correct context.

LGTM.  Thank you for the contribution!


Time of Levenshtein distance calculation

Sorry, but it looks like problem again. I tried to calculate levenshtein distance. I waited around 40 minutes but nothing happened.

Yeah, I know about this problem. Work in progress in this branch:
https://github.com/orsinium/textdistance/tree/optional-dependencies
This release will be use optional dependencies, like Jellifish, and Damerau-Levenstein will be very fast, I promise :)
Remains to implement:

Right algorithm selecting
Moooore tests. Some tests already done, and all works fine.

If you urgently want this feature, you can temporally use project from this branch:
pip install -e git+https://github.com/orsinium/textdistance.git@optional-dependencies#egg=textdistance

I plan released it asap. Please be patient :)

look forward for it :)

It's released! And also TextDistance's native Levenshtein realization so many faster :)


Fix #3, total character count incorrect for multiple pages within a round

Fixes #3
Signed-off-by: efmmoncada<EMAIL_ADDRESS>

Nice! Thanks for taking this one!


$ not supported by stringToUnits()

I tried to get '$100' to be some Money units using stringToUnits() but got "The value could not be parsed as money".

FYI http://stackoverflow.com/questions/14169820/regular-expression-to-match-all-currency-symbols

$string = preg_replace('@\p{Sc}*@', '', $string);

https://github.com/mathiasverraes/money/pull/101

While #101 has been merged. It might be an idea to also create a MoneyParser interface with a IntlMoneyParser implementation. By using ext/intl the support for different notations will be - I guess - much larger.
@sagikazarmark What do you think?

The current stringToUnit method might become StringToUnitParser.

Should be fixed in #148.

Fixed in #148


Fix checkbox selector for mark files as viewed

This morning when approving a PR I spotted a problem with the ”mark all files as viewed” feature I added in #2218. The selector I used to find ”Viewed” checkboxes did not take into the account that some of them might have already been checked.

I forgot to ask in the original PR, does this feature work for ajaxed file diffs?

@notlmn I’ve just checked and in fact, it will not work with ajaxed file diffs. :( I will add a bug ticket since I won’t have time for the next 1,5 weeks to take a closer look at it. Perhaps someone else could take care of it. :)


Adding New Profile.

Adding new profile named as (Rohan Dol)

hello @oyepriyansh
I would like to work on this same issue
could you plz assign me this task?

under HACKTOBERFEST 2023

hello @oyepriyansh I would like to work on this same issue could you plz assign me this task?

You can create a new issue


UDP Socket timer is too long

The 5 minute timer for UDP sockets to expire seems too long in some scenarios, especially when used for operations like DNS.  At scale, this means that thousands of ports can be tied up for a significant amount of time for no useful reason.  Understanding this is not true of all cases, perhaps the timer should be made configurable?

https://github.com/openziti/ziti/blob/main/tunnel/udp_vconn/policy.go#L61

I only see it documented in the release notes, but https://github.com/openziti/edge/pull/1504 made it possible to se the udp timeout in the router config file:
listeners:
  - binding: tunnel
    options:
      mode: tproxy
      udpIdleTimeout: 30s
      udpCheckInterval: 30s

I think this capability addresses this issue exactly as written.


[BUG] UI Warning on world load like: "magicitems | Your controlled Actor does not have a spell/feat named Disguise Self"

Module Version: v4.1.3
Before open any issue

Enable the module setting "Enable debugging"
Click F12 go to the console tab
make the test you want and replicate the error
Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save' or send a screenshot of the exception on the console.
Attach the text file on the github issue with all the logs related tot he module, or send a screenshot of the messages on the console.

Describe the bug
Getting two yellow warning banners on world load that says my controlled actor doesn't have a spell/feat named Disguise Self
To Reproduce
Steps to reproduce the behavior:

enable magic items
reload world
See warning

Expected behavior
No warning presented
Screenshots

Browser:
Chrome 123.0.6312.106
Foundry Version:
11.315
Game System:
DnD5e 3.1.2
Additional context
Add any other context (like other modules installed) about the problem here.

I have tested this with no modules other than Magic Items, libwrapper, socketlib and module management+... I have even deleted an item with Disguise Self from the tokens on the grid. and still get the issue.

Yes, it's this module's issue, I'll try and have it fixed asap.

What happens if you remake the items in the compendiums?

I'm getting the same issue

I am getting the exact same yellow banners for a multitude of spells, and even when the implicated magic items and spells are deleted it still occurs. I hope this can get resolved soon, but if not, I will need to deactivate the module (which I really do not wish to do!).

Should no longer be present in 4.1.4

Hello there,
I'm still getting this error sometimes in 4.1.4:

Could you look into it?
Thanks in advance!

Hello there,
I'm still getting this error sometimes in 4.1.4:

Could you look into it?
Thanks in advance!

Not sure if it helps, but for me it wasn't working when i was dropping spell from "omnisearch" popup. When i imported spell and then added it to item it started to work fine.


#381 - Fix possible false positive delegate inbox detection

This looks reasonable to me.
Could you update the CHANGELOG to contain a description of your fix?

Hey there and thanks for the patch!
This change alone looks absolutely reasonable to me, and I'd be happy to merge it.
But before we do that, I'd like you to do two things:

Could you update the CHANGELOG to contain a description of your fix? Add it under a new version (0.6.14).
Could you amend this PR with your other change (and then close it), so that they can be reviewed and tested together?

I close this one as it should no longer be necessary if we fix api.helper.get.is_delegated_inbox as described in #447


first stab at a new scholarphi db schema

Draft PR to explore new designs for the ScholarPhi DB schema.
The schema uses a main entity table to assign IDs to all paper entities from the same ID space (one ID to look up any entity, regardless of type). For most purposes outside of the DB layer, this ID is the one we should use when referencing entity data. Values that are common to all entities are kept in this table, and then there are foreign key columns to link out to specific tables for each subtype of entity (e.g. citation, symbol, sentence, etc.).
There are some additional relations to note:

Symbols can contain other symbols, hence the self-reference in the symbol table. One way this is exposed in the reader is users being able to click on a symbol and drill into its constituent parts (if any) and see their definitions as well.
Symbols appear within Equations and contain a reference back to that equation
"Terms" and "Symbols" can both have "Definitions"
"Terms" and "Symbols" both appear within "Sentences"
All entity types have bounding boxes

Lines and boxes to help paint the picture:

For reference, this is the current data model. Courtesy of Michael.

@mjlangan for my curiosity, can you point out (in the current code if possible) where the biggest inefficiencies are? I heard something about symbols containing duplicate information.

For reference, this is the current data model. Courtesy of Michael.

That's the ERD that informed the new schema design, actually. The current schema looks like this:

Regarding the data duplication, it appears in a few places. The API responses are currently very verbose and contain redundant information when serving up the non-citation entities. For example, if a symbol appears in a sentence, there is an entity for that sentence, and the symbol also contains that sentence as a textual reference (or something of this nature, @andrewhead or @cmwilhelm can probably correct me here). In addition to that, the entitydata key-value table allows the same key-value to be written multiple times for a particular entity. An extreme case I found is an entity with 19,520 rows in entitydata (this is, 19,520 rows with the same entity_id) which actually encoded only about 330 distinct key-value pairs.

documenting here:  per discussion I had with @mjlangan on 3/30, we settled on these changes to the above proposal:

consider migrating "text" and "latex" as columns in the entity table, which removes need for separate tables for entities of type sentence or definition.  pretty much every entity can be assumed to have a "text" and "latex" form.
adding "normalized_mathml" as a field to the equation table.  this is because we need to be able to render these in the application in addition to symbols.
augmenting the symbol table to have not just a parent lookup, but also a way to lookup all immediate children (not children from deeper layers of parse tree). same thing applies to equation table, though they dont need parents because they are all root nodes.  this is because for the symbol selection feature on the application, when we double-click on a symbol, we want to select the boxes of subsymbols.
a entity_cluster table that enables mapping between entity_ids of the exact same string form (e.g. same term or same symbol).  this is for fast behavior on declutter & usages features, where we want to find all other entities to a query entity based on exact string match.   though it's possible that this is no longer needed if all of this is being resolved quickly given the recent API changes.  @mjlangan @cmwilhelm  ?

@andrewhead  can you confirm?

I'd like to come to any design review meeting on this. Also happy to give feedback before the review.

@kyleclo, I am following up on this, hopefully better late than never. Thank you for having this discussion with Michael, and identifying open questions that need to be resolved with regards to the schema design.
Most of these details look good to me. The only place where I was not entirely following is:

augmenting the symbol table to have not just a parent lookup, but also a way to lookup all immediate children (not children from deeper layers of parse tree).

Why would parent -> child relations be necessary if child -> parent relations are available?

Got it!


improvementSupport external table show table stats, modify column stats and drop stats.

Issue Number: close #xxx
Support external table show table stats, modify column stats and drop stats.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Need to add some regression tests

run buildall


Warning to exclude message from battery optimization shown even though it is excluded already

:lady_beetle: Describe the bug

This is shown when starting:

Note when you click to fix the big, it does show the app as already optimized:

:computer: Components impacted

Android
:bulb: Screenshots and/or logs

:crystal_ball: Additional context

Note when filtering ntfy is not shown as "unrestricted" but as "optimized".
Device: Fairphone 4 (FP4)
OS: Android 14, CalyxOS 5.14.0
source: F-Droid
version: v 1.16.0
io.heckel.ntfy
Build-ID: AP2A.240905.003.24514000

Click on the left side of that configuration option (click on the text, not the toggle switch). It will give you the option to make ntfy "unrestricted"

Ah, of course, I am stupid…
But yeah it's also (dark?) pattern-designed to be hard to find, apparently :sweat_smile:
Maybe you can give some more (direct) hints or dunno? (I once saw some apps showing a toast notification at the bottom to direct people somewhere– dunno whether Android really calls them like that but AFAIK it's that)
This would be the only idea I have.


Enabling DynamoDB endpoint URL

Issue #, if available:
#881
Description of changes:
Add DynamoDB endpoint URL and apply configuration to all public methods in DynamoDB module
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 316e6b829392da6d5a17426fbd2dfe9f704d8de6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
Commit ID: 446815ee93146e410d86fe68baf121292256988e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


added an example for the groupBy method

I've noticed that people new to functional style programming are usually not familiar with the API of groupBy. Therefore, added an example to demonstrate it.
I was hoping to add a few more examples to the docs. Would it be better to submit them as one PR or should each be a separate PR?

Either one big PR or separate PRs is ok. Maybe separate PRs are nicer because it's easier to just merge more things in then.

Oh and thanks for improving this documentation!


Instance: SlicerMorph 101, Aaron Hardgrave - Newt project

Cloud Computing Instance Flavor
g3.xl - GPU instance (32 CPUs, 125 GB RAM and A100 GPU)
Description
I am a PhD candidate at East Tennessee State University working on 3D geometric morphometrics of eastern newt osteology across ontogenetic life stages. I currently focus on the limbs and have hundreds of 3D models (.ply) that are ready to be run through the ALPACA pipeline. My personal computer is not capable of this task, and I will require greater computational power to landmark my dataset.
ORCID
0009-0005-0178-1173
Email
U2FsdGVkX1+APbUCJPuNvmbSSR5zF3CGYT3LnD6dFwM1vD5N8C+jthqpo6mDoSuk
Confirm Email
U2FsdGVkX1+APbUCJPuNvmbSSR5zF3CGYT3LnD6dFwM1vD5N8C+jthqpo6mDoSuk

/create

/unshelve

/unshelve

/delete_instance

/create

/delete_all

/create

/unshelve

/shelve

/unshelve

/unshelve

/shelve

/unshelve

/unshelve

/shelve

/unshelve

/shelve

/unshelve

/shelve

/unshelve

/shelve

/unshelve

/shelve


Passing grunt-prompt config to load-grunt-config

Hi, i am now using the load-grunt-config with grunt-prompt to distribute to developers to work on some front-end tasks especially components based development, it's great for every tasks i can slice using load-grunt-config.
However i would like have a command-line based interface for developer to select their components to develop, so i chose grunt-prompt to achieve that but i got some problem to pass the developer selected component options to the data object in load-grunt-config.
This is the Gruntfile.js, I have defined a component field in the data object.
module.exports = function(grunt) {

    var path = require('path');

    require('load-grunt-config')(grunt, {
        configPath: path.join(process.cwd(), 'tasks'),
        data: {
		component: ''
	}
    });

};

Here is the tree of tasks.
tasks/
├── aliases.js
├── execute.js
├── prompt.js
├── pug.js

This will run prompt then execute tasks.
aliases.js
module.exports = function (grunt) {

	return {
		default: [
			'prompt',
			'execute'
		],
...

Developer selected a component and store to grunt.config.
prompt.js
return {
	default: {
		options: {
			questions: [
				{
					// Top Menu Options
					config: 'component',
...

The execute.js is able to print the selected component option after running prompt.js.
execute.js
module.exports = function (grunt) {

	grunt.registerTask('execute', '', function () {

		console.log(grunt.config('component')); // able to print the selected component option

		console.log('Executing procedure...');
...

I am trying to get the grunt.template work in pug.js, i noticed that load-grunt-config have a data object for this case, but it's already initiated before running prompt.js, so the following <%= component %> is undefined, any suggestion to solve this case?
pug.js
module.exports = function (grunt) {

	return {
		dev_component: {
			files: [{
				expand: true,
				cwd: 'src/component/<%= component %>/',
...

Hi @yuepywu, not quite sure that it would be easy to implement such scenario. The only visible option for me right now is to perform prompting before grunt execution, in this case you will have everything that you need before load-grunt-config initialisation.


Dns blackholes

Added a "Troubleshooting" section to the README, specifically with instructions on DNS Assist / Blackhole workarounds.
Inspired by conversations in Slack circa 2017-09-28: https://gsa-tts.slack.com/archives/C4VG8LCKU/p1506655012000104

:+1: from me


Question for mobile meeting add-in

If I installed several custom add-in, just like the screenshot.
Which add-in will be chosen as default when I create a calendar event?
Sometimes it seems that Outlook will set the add-in which was last-time option as default, but sometimes it's not.
Is there any rules or reference of mobile meeting add-ins sequences and default option?
And I want to confirm that if there is only one admin-installed add-in, will it replace the default Teams or Skype option?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52a55fe4-0fe1-858c-26a4-dddc3ee128ea
Version Independent ID: 0a643291-936f-b374-37fd-7db497c73cce
Content: Create an Outlook mobile add-in for an online-meeting provider - Office Add-ins
Content Source: docs/outlook/online-meeting.md
Product: outlook
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

@ElizabethSamuel-MSFT Can you take a look. Might not be a doc issue.

any updates?

@jean-wujingyi Thanks for asking about this. At present, we don't have any Office.js API that allows you to set the default provider. As such, the behavior depends on Outlook itself. It's possible that Microsoft Graph has an option you can use but you'd need to check if that's the case.
Adding @exextoc in case they have any idea of Outlook behavior for this feature.
Thanks.

Thank you~

Any add-ins which are installed by Admins as Online Meeting add-ins will be shown first to the user. However, once a user selects any other meeting provider, that meeting provider is selected by default for the user for that device.


OpaqueToken error with Angular 4.0.0

I am testing to see if Nativescript works with Angular 4.0.0
getting folloing OpaqueToken  error.  looking forward for workaround solution.
WARNING in ../~/nativescript-angular/router/ns-module-factory-loader.js
23:15-40 Critical dependency: the request of a dependency is an expression

ERROR in Error encountered resolving symbol values statically. Calling function 'makeDecorator',
function calls are not supported. Consider replacing the function or lambda with a reference to an
exported function, resolving symbol Injectable in
/Developer/Work/mobile/nativescript/apps/TestApp/node_modules/nativescript-
<EMAIL_ADDRESS>resolving symbol OpaqueToken in
/Developer/Work/mobile/nativescript/apps/TestApp/node_modules/nativescript-
<EMAIL_ADDRESS>resolving symbol OpaqueToken in
/Developer/Work/mobile/nativescript/apps/TestApp/node_modules/nativescript-
<EMAIL_ADDRESS>

ERROR in ./main.aot.ts
Module not found: Error: Can't resolve './app.module.ngfactory' in '/...../app'
 @ ./main.aot.ts 3:0-60

Angular 4 isn't supported yet. We'll likely release support for that when the official version comes out.


Updated github-gist styles

I have updated the styles for github-gist.css to match the current syntax highlighting of gist.github.com. Resolves this ticket as well https://github.com/highlightjs/highlight.js/issues/1548

When shall this PR be merged to master?

Thanks for the reminder. Merging now and will release in next few days.

Great! Many thanks. 😊


Create TypeDoc site?

This is a feature request. You can close this as "Not planned" and I won't feel bad, don't worry ❤
I think that the current setup with an examples/ folder and a bunch of docs that feel very shallow. They're also somewhat duplicated across the hover in-IDE intellisense (the .d.ts files) and the readme would be better consolidated into a single place: a documentation website. There's enough content that I think it's worth the effort (and the effort isn't much 😊)
// package.json
{
  "scripts": {
    "build:docs": "typedoc"
  },
  "typedoc": {
    "entryPoints": ["src/index.ts"]
    "out": "sitedocsdistplacefolder/name/here",
    "skipErrorChecking": true
  }
}

And then you can use GitHub Actions to deploy it to GitHub Pages in about 5 minutes of typey-types

Workaround for now: https://typeapi.barelyhuman.dev/pkg/tinybench


Update dependencies

Short description

Update dependencies, mainly to fix upstream issues in django-linkcheck
Resolved issues

Fixes (sadly not): #2274

Pull Request Review Guidelines

Hmm yeah, I guess this error was the same that @david-venhoff encountered, right?
× Building wheel for django-linkcheck (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [22 lines of output]
      Compile translation files
      Traceback (most recent call last):
        File "/home/circleci/project/.venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/circleci/project/.venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/circleci/project/.venv/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
          return _build_backend().build_wheel(wheel_directory, config_settings,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-install-081adp34/django-linkcheck_237135e8202c4cadbffc666331a4d27f/linkcheck/build_meta.py", line 18, in build_wheel
          compile_translation_files()
        File "/tmp/pip-install-081adp34/django-linkcheck_237135e8202c4cadbffc666331a4d27f/linkcheck/build_meta.py", line 9, in compile_translation_files
          subprocess.run(["django-admin", "compilemessages"], cwd="linkcheck")
        File "/home/circleci/.pyenv/versions/3.11.7/lib/python3.11/subprocess.py", line 548, in run
          with Popen(*popenargs, **kwargs) as process:
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/circleci/.pyenv/versions/3.11.7/lib/python3.11/subprocess.py", line 1026, in __init__
          self._execute_child(args, executable, preexec_fn, close_fds,
        File "/home/circleci/.pyenv/versions/3.11.7/lib/python3.11/subprocess.py", line 1950, in _execute_child
          raise child_exception_type(errno_num, err_msg, err_filename)
      FileNotFoundError: [Errno 2] No such file or directory: 'django-admin'
      [end of output]

Ah, I forgot we already opened an upstream issue for this: #200

Thankfully, the upstream installation problem has been resolved, so this is now ready for review.
The sad thing is that I just tried it with the bafög URL and the problem still persists that the link is recognized as invalid. Apparently, not only the library had a problem, but our CMS as well: Tinymce (or the form cleaning method) replace the valid URL https://www.bafög.de/bafoeg/de/home/home_node.html with https://www.baf%C3%B6g.de/bafoeg/de/home/home_node.html which is very stupid because urlencoding is not valid for domain names, punycode is the correct way to translate utf-8 domains into ascii.
So I believe we also have to fix our internal URL handling in the CMS.


docs: clearer tone for non-native speakers

If this is OK - I will update the reply template as well.

i dont want any codecamp notification on gmail pls \


remove mixed model from config and constant data

Codecov Report

Merging #393 into master will increase coverage by 1.2%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #393     +/-   ##
=========================================
+ Coverage   42.71%   43.92%   +1.2%
=========================================
  Files          21       21
  Lines       10764    10759      -5
=========================================
+ Hits         4598     4726    +128
+ Misses       4966     4827    -139
- Partials     1200     1206      +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2f53a...eb94cc3. Read the comment docs.

LGTM


'withUnsafeBytes' is deprecated:

Error
Version 10.2 beta 4 (10P107d)
'withUnsafeBytes' is deprecated: use withUnsafeBytes<R>(_: (UnsafeRawBufferPointer) throws -> R) rethrows -> R instead
in file
//  String+MD5.swift
Fix
extension Kingfisher where Base == String {
    public var md5: String {
        if let data = base.data(using: .utf8, allowLossyConversion: true) {

            var byteBuffer: [UInt8] = []
            data.withUnsafeBytes {
                byteBuffer.append(contentsOf: $0)
            }

            let MD5Calculator = MD5(byteBuffer)
            let MD5Data = MD5Calculator.calculate()

            var MD5String = String()
            for c in MD5Data {
                MD5String += String(format: "%02x", c)
            }
            return MD5String

        } else {
            return base
        }
    }
}

I guess it was already fixed almost a month ago here? https://github.com/onevcat/Kingfisher/pull/1098/files#diff-83528e464139a7490373fe498f77c544


Update README.md

Description
Fixed typos and grammatical errors

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

happy, hacktember(?) fest!


Create new instance btn and go to next prompt

The design outlined below addresses the navigation (Create new instance button and the go to next prompt button) issues in the ODK-Survey form .
The colors, font size, type, and spacing used adhere to the ODK-X Design guidelines
Any feedback or additional information would be greatly appreciated. Thank you.
On the first grid, image one  compares the old instance button to the new one.

On the second grid, image one compares the go to next prompt button to the new one

@juayuohcarineneng19 Great work!

Can you provide a better screenshot like before and after the changes were made? side by side comparison would be better. It'll make it easier to review your PR by letting us know what was there before and what wasn't there without having to run the app

This PR title  "Create new instance btn"  seems vague, you did modifications not only on the Create new instance btn

Thank you . PR updated @Redeem-Grimm-Satoshi

@juayuohcarineneng19 I noticed you are adding grunt-shell to our environment is there a reason for that? why was it necessary? we try to minimize the number of packages needed for app-designer since users often have limited connectivity. Is there something that that grunt-cli could not do that you needed? @r0ssing

@juayuohcarineneng19 I noticed you are adding grunt-shell to our environment is there a reason for that? why was it necessary? we try to minimize the number of packages needed for app-designer since users often have limited connectivity. Is there something that that grunt-cli could not do that you needed? @r0ssing

Please I did not notice I was adding the grunt-shell to our  environment.  I will remove this. Thank You

@juayuohcarineneng19 Sorry for the delay reviewing.
Button is in line with the style guide, and it looks good. I'm ok with the changes.

@Redeem-Grimm-Satoshi I have reviewed design - can you review code and merge if ok?

@Redeem-Grimm-Satoshi I have reviewed design - can you review code and merge if ok?

@maprehensive Yes sure

Looks good!

@r0ssing This issue is ready to be merged :)

I just noticed this branch have some conflicts, @juayuohcarineneng19 try resolving them first

Conflicts resolved @Redeem-Grimm-Satoshi

@Chinex-Boroja Please check this out for any testing related issues @r0ssing This issue is ready to be merged :)

Hi @Redeem-Grimm-Satoshi, I am not really sure what I am meant to do here or how to go about this regarding writing tests, if that is what you mean. If you could explain, it will be quite helpful. Thank you

@Chinex-Boroja Please check this out for any testing related issues
@r0ssing This issue is ready to be merged :)

Hi @Redeem-Grimm-Satoshi , please it was  mentioned in our meeting that @Chinex-Boroja can only write test for table app and not app designer as he isn't familiar with app designer .

@r0ssing Please go ahead and merge this, looks good


HHH-11166 - JPA & JTA - java.lang.IllegalStateException: Session/EntityManager is closed when EntityManaer is closed with an active Transaction

https://hibernate.atlassian.net/browse/HHH-11166

Applied upstream.


EXPERIMENTAL: Api, ZIP dags

This is an experimental branch. Just to test out a couple of ideas.

API: for submitting dag files, loading them from the api for distribution, obtaining connection info for a dag
Fix for the webserver not reloading the dag folder
Allow ZIP dag files (can also be used for future dependency management by adding a zip to sys.modules) (superseded by #1352)
some fixes in refreshing files,
Let the scheduler download dag files if missing or new
Some kerberos stuff

@bolkedebruin should we close this? it seems to me that most points have made it to other PRs


Remeberable: Use has_changes_to_save? instead of changed?

Created pull request for this issue: https://github.com/heartcombo/devise/issues/5421

Please see https://github.com/heartcombo/devise/issues/5421#issuecomment-1451094724, changed? is not really deprecated, just the confusing behavior of it was, but it is interchangeable with has_changes_to_save? in that context. Thanks!


[FLINK-2775] [CLEANUP] Cleanup code as part of theme to be more consistent on Utils classes

As part of continuing theme and effort to help make the code more consistent, adding cleanup to Utils classes:
-) Add final class modifier to the XXXUtils and XXXUtil classes to make sure can not be extended.
-) Add missing Javadoc header classs to some public classes.
-) Add private constructor to Utils classes to avoid instantiation.
-) Remove unused test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class

Looks like fail on unrelated Kafka partition error

Looks good. @zentol's comments are nice-to-address issues.
+1 to merge with addressing the comments

Thanks guys,  updated based comments. Will merge end of day if no more comments.

Build passes, will squash commits and merge ...


fix(popup): Fixed globals being overidden on popup demo page

Closes #249

Sorry,, but seem I can't understand how to test it


Fixes build errors with --features serde-serialize

Fixes this issue: https://github.com/dimforge/parry/issues/21

Thanks!


Fix quickstart with verilator

Just a small change to make sure that following the quick start does not end in error with Verilator.

By the way, thanks @Risto97 for the contribution!

Well I tried with the -Wfuture flag, but honestly I couldn't get it to work. Couldn't also find any information how to use it ( I tried -Wfuture-IMPLICITSTATIC -Wno-IMPLICITSTATIC ,  also other variations).
At 4.228 it just fails because of -Wno-IMPLICITSTATIC, and on 5.006 it works.
Anyway I changed functions in dasm.svi from function to function static as that is how verilator interprets it anyways. Now I am not sure if it is has the same behaviour on all the other simulators I only tested verilator 4.228 and 5.006
https://github.com/chipsalliance/Cores-VeeR-EL2/pull/80/commits/84f50e4dc0f12486c86f0974ce59f78a4c54007f#diff-fefbad5c2354fb9b50844374ff2a36b9dc7fbb65480ad6312521063a482117ffL26

Hmm, alright. It's even better to fix the problem at the source rather than suppressing warnings. Looks good to me then.


Fix overspecification of parameter definitions

CC @jzrapp
For example, "porosity" applies to more than just soil (sediment, sea ice). We should relabel or remove overspecified parameters on detection.
Copy of GenomicsStandardsConsortium/mixs-ng#8 originally filed by @pbuttigieg

Replaced by #39

In fact, this is not a duplication to issue #39. Instead, this issue has to do with having terms in different checklists that have different labels, but should possibly be merged into a singe term.
I have copied @jzrapp 's comment from #34 here for clarification:
Some of the packages contain terms for which very specific definitions have been provided. However, the term itself may also be applicable to a different environment, but the specificity of the definition encourages duplication of terms, with slight modifications to the definition. A more coherent solution could be the establishment of overarching packages for e.g. physical characteristics of sample, or biological description of sample
Examples of such terms include:
"permeability" from hydrocarbon resources-cores package
"bacterial production" from water package
"bacterial respiration" from water package
"horizon" from soil package

I went through the list of terms in the packages (the v6 working version), and found these ones that could be defined more broadly (with a suggested new definition):
This list is probably not exhaustive
term = permeability
termID = MIXS:0000404
definition = Measure of the ability of material (such as a hydrocarbon resource or a membrane) to allow fluids to pass through it.
term = bac_prod
termID = MIXS:0000683
definition = A measure of microbial production in a sample or environment (e.g. measured by isotope uptake)
note: for the term bad_prod[MIXS:0000683], should the term name maybe be changed to microbial production or just production? Because the production of Archaea and eukaryote algae can also be measured. Or do we add new terms, such as Archaea production and Eukaryote production?
term = bac_resp
termID = MIXS:0000684
definition = A measure of microbial respiration in a sample or environment
note: same remark as bad_prod: what about other microbial groups?
term = horizon
termID = MIXS:0001082
definition = Specific layer in the soil or sediment that possesses physical characteristics which differ from the layers above and beneath
term = host_taxid
termID = MIXS:0000250
definition = the taxon id of the host according to a taxonomic backbone, for example NCBI (e.g. NCBI:txid2004416), WoRMS (urn:lsid:marinespecies.org:taxname:387241),... Note that the ID number also needs to mention the name of the taxonomic backbone.
term = lithology
termID = MIXS:0000990
definition = the main rock type. This differs from env_medium[MIXS:0000014] as it does not need be in direct contact with the sample.
note: what is the difference between lithology[MIXS: 0000990] and sr_lithology[MIXS: 0000995]?
term = samp_transport_cond
termID = MIXS:0000410
definition = Explain the conditions of the sample transport, such as the duration of the transport (in days or hrs), the temperature the sample was exposed to (degrees Celsius), light exposure,...

@msweetlove , Thanks for the list these are really useful.
I'm going to create individual tickets for each of the terms you list and close this ticket. I may also suggest we leave some of the terms for review in v7 as we're rapidly running out of time for this v6 release.

all individual terms given their own tickets, except "horizon" as I feel the current definition is suitable for use in any of the packages.


Add CWE to the SARIF report

What problem are you trying to solve?
When we write the SARIF report, we also add the CWE in

the violation object (as a property)
the rule (as a property)

What is your solution?
Add the CWE in both the violation object and the rule. The report looks like the JSON below. We also filter when the CWE is an empty string and fix it to be null.
{
  "runs": [
    {
      "results": [
        {
          "fixes": [
            {
              "artifactChanges": [
                {
                  "artifactLocation": {
                    "uri": "myfile"
                  },
                  "replacements": [
                    {
                      "deletedRegion": {
                        "endColumn": 6,
                        "endLine": 6,
                        "startColumn": 6,
                        "startLine": 6
                      },
                      "insertedContent": {
                        "text": "newcontent"
                      }
                    }
                  ]
                }
              ],
              "description": {
                "text": "myfix"
              }
            }
          ],
          "level": "error",
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "myfile"
                },
                "region": {
                  "endColumn": 4,
                  "endLine": 3,
                  "startColumn": 2,
                  "startLine": 1
                }
              }
            }
          ],
          "message": {
            "text": "violation message"
          },
          "partialFingerprints": {},
          "properties": {
            "tags": [
              "DATADOG_CATEGORY:BEST_PRACTICES",
              "CWE:1234"
            ]
          },
          "ruleId": "my-rule",
          "ruleIndex": 0
        }
      ],
      "tool": {
        "driver": {
          "informationUri": "https://www.datadoghq.com",
          "name": "datadog-static-analyzer",
          "rules": [
            {
              "fullDescription": {
                "text": "awesome rule"
              },
              "helpUri": "https://docs.datadoghq.com/continuous_integration/static_analysis/rules/my-rule",
              "id": "my-rule",
              "properties": {
                "tags": [
                  "CWE:1234"
                ]
              },
              "shortDescription": {
                "text": "short description"
              }
            }
          ]
        }
      }
    }
  ],
  "version": "2.1.0"
}

Why are we putting the CWE in the violation object too?

Why are we putting the CWE in the violation object too?

Just easier to access for you. If you do not want it, let me know, happy to remove it.

Just easier to access for you. If you do not want it, let me know, happy to remove it.

😬 if you could remove it


Remove sha256 hash from storage internal code

closes https://github.com/Azure/azure-sdk-for-cpp/issues/2513
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[x] C++ Guidelines
[x] Doxygen docs
[x] Unit tests
[x] No unwanted commits/changes
[x] Descriptive title/description

[x] PR is single purpose
[x] Related issue listed

[x] Comments in source
[x] No typos
[x] Update changelog
[x] Not work-in-progress
[x] External references or docs updated
[x] Self review of PR done
[x] Any breaking changes?

/azp run cpp - storage


WIP: add spec for Array can be sliced with Enumerator::ArithmeticSequence

Hello 👋
Today I'll try to cover this from #823 :

(Array) Can be sliced with Enumerator::ArithmeticSequence

Thank you for your feedback.

https://rubyreferences.github.io/rubychanges/3.0.html#array-slicing-with-enumeratorarithmeticsequence might be useful

@zverok @mrkn Could you take a look at the cases marked with ??? and see if they make sense to you or if they are bugs?

Hi @eregon
As you suggested, I moved the specs that were marked with ??? to another branch and removed them from this branch.
Letme know if you want any more changes, thank you!


Unable to retrieve volumes: Portainer 1.23.2

Hi,
I'm troubleshooting with the following issue by which is not possible to find volumes in portainer.

More in depth, we are currently using [Docker version 19.03.8, build afacb8b7f0] and portainer 1.23.2
We deployed in docker swarm some stacks, each of which has a cifs volume, but no entry will be shown in portainer volume interface. The error reported above is what we are getting.
Could you help me to solve that issue?
Thanks a lot.

What is the OS/Verof your Docker Host and what storage driver are you using to map to the CIFS shares?
We have never tested with CIFS so will need to recreate this environment if is simple enough to build.

@amedeopalopoli if you can inspect the failing request in your browser via developer tools, you might be able to get more information out of the request response.

What is the OS/Verof your Docker Host and what storage driver are you using to map to the CIFS shares? We have never tested with CIFS so will need to recreate this environment if is simple enough to build.

@ncresswell: the version of the operating system is Ubuntu 18.04.4 LTS bionic and the driver which I'm using is the local type. I created the stack using the docker cli, also by using volume mounts to cifs share with local driver type, but I'm not able to see the volumes in Portainer

@amedeopalopoli if you can inspect the failing request in your browser via developer tools, you might be able to get more information out of the request response.

@deviantony: below you can find the inspection of the HTTP requests.

When the error happens I'm getting a canceled  request with no response in the body

OK, i have tested this and it works perfectly... let me explain how..
Ubuntu 18.04 Host
apt-get install cifs-utils
Windows Server <IP_ADDRESS>
user: docker
password: secretvol
share: DockerVol
In Portainer, click on Volumes, and then create new volume, and fill in the details as below:

Then create a container and map it to this volume.

Works

the Portainer "Volumes" page is expecting to find volumes in /var/lib/docker/volumes ONLY.. if you have remapped your Docker data root elsewhere, then you need to "hide" that when deploying Portainer by mapping the revised host path to /var/lib/docker/volumes in portainer.

the Portainer "Volumes" page is expecting to find volumes in /var/lib/docker/volumes ONLY.. if you have remapped your Docker data root elsewhere, then you need to "hide" that when deploying Portainer by mapping the revised host path to /var/lib/docker/volumes in portainer.

@ncresswell I have the volumes in /var/lib/docker/volumes. However, I created that outside of portainer and using docker cli. Is that wrong?

Oh not sure then..
Try using my way to create the volume within Portainer to see if it can see self-created volumes.

Oh not sure then.. Try using my way to create the volume within Portainer to see if it can see self-created volumes.

Just tried but does not work. Also creating volumes from portainer shows me the same error message, even if the volume will be created as local.

I just ran the following command on the CLI:
docker volume create --driver local --opt type=cifs --opt device=//<IP_ADDRESS>/DockerVol --opt o=username=docker,password=secretvol,vers=2.0 clivol
it created the volume..
I then went into Portainer, and am able to see the volume in our volumes list.
So, how exactly did you deploy Portainer?

I deployed portainer using docker stack deploy with the following yaml
version: '3.2'
services:
agent:
image: portainer/agent
environment:
# REQUIRED: Should be equal to the service name prefixed by "tasks." when
# deployed inside an overlay network
AGENT_CLUSTER_ADDR: tasks.agent
# AGENT_PORT: 9001
# LOG_LEVEL: debug
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- /var/lib/docker/volumes:/var/lib/docker/volumes
networks:
- traefik-public
deploy:
mode: global
placement:
constraints: [node.platform.os == linux]
portainer:
image: portainer/portainer
command: -H tcp://tasks.agent:9001 --tlsskipverify
ports:
- "9000:9000"
- "8000:8000"
volumes:
- portainer_data:/data
networks:
- traefik-public
networks:
- traefik-public
deploy:
replicas: 1
placement:
constraints: [node.role == manager]
labels:
- "traefik.enable=true"
- "traefik.http.routers.portainer.rule=Host(orchestrator.welance.com)"
- "traefik.http.routers.portainer.tls.certresolver=le"
- "traefik.http.services.portainer.loadbalancer.passhostheader=true"
- "traefik.http.services.portainer.loadbalancer.server.port=9000"
networks:
traefik-public:
external: true
volumes:
portainer_data:
driver: local
driver_opts:
type: cifs
device: "//addressIp/backup/portainer"
o: "username=username,password=password,rw"

OK, i think i see the issue.
You will need to redeploy Portainer after making a change to this file..
volumes:
portainer_data:
driver: local
driver_opts:
type: cifs
device: "//addressIp/backup/portainer"
o: "username=username,password=password,rw,vers=2.0"
you need to add the vers=2.0 option flag to set the correct SMB version.

OK, i think i see the issue.
You will need to redeploy Portainer after making change to this file as i have shown below..
volumes:
portainer_data:
driver: local
driver_opts:
type: cifs
device: "//addressIp/backup/portainer"
o: username=username,password=password,rw,vers=2.0
you need to add the vers=2.0 option flag to set the correct SMB version, and also there are no speech marks on the o: setting.
I just tested a sample stack file configured as follows:, which deploys perfectly, so my revised syntax for you is correct.
version: '3'
services:
ldap:
image : sealeo/openldap
volumes:

ldap:/var/lib/ldap
ports:
389:389
8001:80
environment:
LDAP_PASSWORD=password
LDAP_ORGANISATION="Portainer.io"
LDAP_DOMAIN=mydomain.com
LDAP_SERVERNAME=MyLDAP
volumes:
ldap:
driver: local
driver_opts:
type: cifs
device: "//<IP_ADDRESS>/DockerVol/ldap"
o: username=docker,password=secretvol,rw,vers=2.0

super, that worked!!!
This solved my issue.
Thanks a lot.


unicode-character-database: 13.0.0 -> 14.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/unicode-character-database/versions.
meta.description for unicode-character-database is: "Unicode Character Database"
meta.homepage for unicode-character-database is: "https://www.unicode.org/"
meta.changelog for unicode-character-database is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 14.0.0 with grep in /nix/store/sl6nfa6x7zn6gdi1mxgc4phmwvc5wbh8-unicode-character-database-14.0.0

found 14.0.0 in filename of file in /nix/store/sl6nfa6x7zn6gdi1mxgc4phmwvc5wbh8-unicode-character-database-14.0.0

directory tree listing: https://gist.github.com/ed82c5b20a3e4d9c592c5143eedc53d6

du listing: https://gist.github.com/425f47a9a32257852c10754ee0cc49bb

Rebuild report (if merged into master) (click to expand)

220 total rebuild path(s)

75 package rebuild(s)

75 x86_64-linux rebuild(s)
70 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
70 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
bluefish
chrome-gnome-shell
enlightenment.econnman
enlightenment.efl
enlightenment.enlightenment
enlightenment.ephoto
enlightenment.evisum
enlightenment.rage
enlightenment.terminology
gnome.gnome-applets
gnome.gnome-control-center
gnome.gnome-flashback
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-terminal
gnome.gnome-tweak-tool
gnome.gnome-tweaks
gnome.gnome_control_center
gnome.gnome_session
gnome.gnome_shell
gnome.gnome_terminal
gnome.gucharmap
gnome.pomodoro
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
gucharmap
haskellPackages.gi-ibus
ibus
ibus-engines.anthy
ibus-engines.hangul
ibus-engines.kkc
ibus-engines.libpinyin
ibus-engines.libthai
ibus-engines.m17n
ibus-engines.mozc
ibus-engines.rime
ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others
ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped
ibus-engines.uniemoji
ibus-qt
ibus-with-plugins
libsForQt5.kdeplasma-addons
libsForQt5.plasma-desktop
libsForQt512.kdeplasma-addons
libsForQt512.plasma-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sl6nfa6x7zn6gdi1mxgc4phmwvc5wbh8-unicode-character-database-14.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unicode-character-database https://github.com/r-ryantm/nixpkgs/archive/38e9788680edbbdfbe8c54a34fb24855c21df3a2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sl6nfa6x7zn6gdi1mxgc4phmwvc5wbh8-unicode-character-database-14.0.0
ls -la /nix/store/sl6nfa6x7zn6gdi1mxgc4phmwvc5wbh8-unicode-character-database-14.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages marked as broken and skipped:

libsForQt512.kdeplasma-addons
libsForQt512.plasma-desktop
libsForQt514.kdeplasma-addons
libsForQt514.plasma-desktop
octavePackages.vrml

5 packages failed to build:

bluefish
gnome.gnome-applets
gnome.gucharmap
mate.mate-applets
mate.mate-tweak

54 packages built:

adapta-gtk-theme
chrome-gnome-shell
enlightenment.econnman
enlightenment.efl
enlightenment.enlightenment
enlightenment.ephoto
enlightenment.evisum
enlightenment.rage
enlightenment.terminology
gnome.gnome-control-center
gnome.gnome-flashback
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.pomodoro
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
ibus
ibus-engines.anthy
ibus-engines.hangul
ibus-engines.kkc
ibus-engines.libpinyin
ibus-engines.libthai
ibus-engines.m17n
ibus-engines.mozc
ibus-engines.rime
ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others
ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped
ibus-engines.uniemoji
ibus-qt
ibus-with-plugins
libsForQt5.kdeplasma-addons
libsForQt5.plasma-desktop
mlterm
octavePackages.miscellaneous
pantheon.elementary-greeter
pantheon.elementary-session-settings
pantheon.switchboard-plug-keyboard
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-keyboard
pantheon.wingpanel-with-indicators
phosh
python38Packages.pythonefl
python39Packages.pythonefl
snippetpixie
unicode-character-database
vimix-gtk-themes
whitesur-gtk-theme

Maintainer pings

Result of nixpkgs-review pr 138892 run on x86_64-linux 1

1 package built:

unicode-character-database

[nix-shell:~/.cache/nixpkgs-review/pr-138892-1]$ cat ./results/unicode-character-database/share/unicode/ReadMe.txt
# Unicode Character Database
# Date: 2021-09-10, 17:22:00 GMT [KW]
# © 2021 Unicode®, Inc.
# Unicode and the Unicode Logo are registered trademarks of Unicode, Inc. in the U.S. and other countries.
# For terms of use, see https://www.unicode.org/terms_of_use.html
#
# For documentation, see the following:
# NamesList.html
# UAX #38, "Unicode Han Database (Unihan)"
# UAX #44, "Unicode Character Database"
# UTS #51, "Unicode Emoji"
#
# The UAXes and UTS #51 can be accessed at https://www.unicode.org/versions/Unicode14.0.0/

This directory contains the final data files
for the Unicode Character Database, for Version 14.0.0 of the Unicode Standard.

Change looks good to me

Result of nixpkgs-review pr 138892 run on x86_64-linux 1

5 packages marked as broken and skipped:

libsForQt512.kdeplasma-addons
libsForQt512.plasma-desktop
libsForQt514.kdeplasma-addons
libsForQt514.plasma-desktop
octavePackages.vrml

58 packages built:

adapta-gtk-theme
bluefish
chrome-gnome-shell
enlightenment.econnman
enlightenment.efl
enlightenment.enlightenment
enlightenment.ephoto
enlightenment.evisum
enlightenment.rage
enlightenment.terminology
gnome.gnome-applets
gnome.gnome-control-center
gnome.gnome-flashback
gnome.gnome-session
gnome.gnome-shell
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.gucharmap
gnomeExtensions.easyScreenCast
gnomeExtensions.gsconnect
gnomeExtensions.night-theme-switcher
ibus
ibus-engines.anthy
ibus-engines.hangul
ibus-engines.kkc
ibus-engines.libpinyin
ibus-engines.libthai
ibus-engines.m17n
ibus-engines.mozc
ibus-engines.rime
ibus-engines.table
ibus-engines.table-chinese
ibus-engines.table-others
ibus-engines.typing-booster
ibus-engines.typing-booster-unwrapped
ibus-engines.uniemoji
ibus-qt
ibus-with-plugins
libsForQt5.kdeplasma-addons
libsForQt5.plasma-desktop
mate.mate-applets
mate.mate-tweak
mlterm
octavePackages.miscellaneous
pantheon.elementary-greeter
pantheon.elementary-session-settings
pantheon.switchboard-plug-keyboard
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-keyboard
pantheon.wingpanel-with-indicators
phosh
python38Packages.pythonefl
python39Packages.pythonefl
snippetpixie
unicode-character-database
vimix-gtk-themes
whitesur-gtk-theme

Weired it failed after building agda packages... it now builds..

@GrahamcOfBorg eval

@GrahamcOfBorg eval

@GrahamcOfBorg build unicode-character-database ibus gnome.gucharmap


Integrate erik-s auth cwl-tes changes with michael's ones

Apply AAI authorization changes to Michaels CWL-TES changes

Complete https://github.com/common-workflow-language/cwl-tes/pull/27


need update  currentTarget InputFramebuffer

Because outputFramebuffer  got a new value, we need update  currentTarget InputFramebuffer.

Because outputFramebuffer got a new value, we need update currentTarget InputFramebuffer.

stange error


Is it possible to use  as 'actUp' for 'colemak' keyboard layout? :)

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[ ] zsh
[x] fish

Problem / Steps to reproduce
My boy is using colemak keyboard layout and he is studying neovim.
Of course, by using fzf and fzf.vim plugin:)
The problem is that the default keybinding is <c-j><c-k>/<c-n><c-p> to move the cursor up and down
in the preview window. But for colemak layout, it should be handle with <c-n><c-e> for moving up and down.
I have no idea how to set keybinding for that part, as it seems set in the source code:
# Defined in `src/terminal.go`
add(tui.CtrlE, actEndOfLine)
add(tui.CtrlK, actUp)

He's already tried the mapping below, none of working:
nmap <c-e> <c-p>
imap <c-e> <c-p>
nmap <c-e> <c-k>
imap <c-e> <c-k>

Any work around without changing the source code? :)

Have you read through the manual page? (man fzf)

Have you read through the manual page? (man fzf)

Oh, thanks for the tips, fixed already with the below settings:
let $FZF_DEFAULT_OPTS="--reverse --bind=ctrl-e:up"

Thank you so much:)


feat:Integrating Register CLI with registrar v3 API - NEW

This PR has been created to track changes from https://github.com/atsign-foundation/at_java/pull/32 which got mixed up.
- What I did

Integrating register cli with registrar v3
New design for the register cli
Tests for config_reader class
Minor error corrections in documentation

I pushed some changes to the branch, see latest commit. Please re-run your manual tests to verify I haven't broken anything.
One additional question - picocli latest version is 4.6.3 - any particular reason you are using version 4.5.2 ?

No specific reason for using that version. The have updated the version to 4.6.3

Great let me know when you've re-run tests and we can merge this PR

I think version 3 of the registrar has not been released to prod yet. Do we still want this code out there ?

Ok let's wait until next week. Thank you!

Sure, Gary. I'm sorry this task turned into a huge mess.

Nothing to apologize for! This stuff is important and takes time to get right.

Great let me know when you've re-run tests and we can merge this PR

I have re-run the tests and checked all use cases. They seem to hold. It's ready to merge.


Post says undefined with MySQL database and Digitalocean storage driver

Issue Summary
Ghost posts which are saved show "undefined" after you navigate to the page, see: https://accountgram.com/c/what-are-the-best-ocr-apps-for-scanning-receipts/
Draft posts when previewed, shows 404.
All the posts are saved in the (MySQL) database, even draft posts.
To Reproduce
Cannot reproduce, only on my database AFTER a ghost restart
Technical details:

Ghost Version:

2.19.1

Node Version:

$ node -v
v10.15.2

Browser/OS:

Verified on both MacOSX and Ubuntu 14.04

Database:
MySQL

@nubela I'm finding it rather difficult to follow your issue. The URL which you've supplied doesn't show "undefined" and I'm unable to reproduce draft posts showing 404s.

Cannot reproduce, only on my database AFTER a ghost restart

What exactly do you mean by this? You started seeing problems after a restart, or?

Sorry, I have exported the posts into json, deleted and recreatedthe database, and reimported, and fixed the issue.


CS finds a JVM in a folder that doesn't exit

On my Mac, when I run:
$ cs setup
Checking if a JVM is installed
Found a JVM installed under<EMAIL_ADDRESS>

But that folder doesn't exist:
$ ls<EMAIL_ADDRESS>ls<EMAIL_ADDRESS>No such file or directory

Despite installing the JVM with the setup command, there is no JVM:
$ java -version
No Java runtime present, requesting install.

I can select and install another JVM and manually configure it.
$ cs java --available | grep -e 11
$ cs java --jvm 11
$ cs java --jvm 11 --env >> .zshrc
$ source .zshrc
$ java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)

But it seems that the initial "cs setup" command said that it did its job but didn't.  And it reports that a JVM is installed that isn't.

It seems that cs setup uses the PATH along with JAVA_HOME environment variable to check if a JVM is installed.
In case it finds the JAVA_HOME environment variable in the shell profile, it seems to assume that a JVM is installed without actually checking for one or see if the one specified in the path can actually be run.
Removing the environment variables set by coursier from the shell profile seems to fix the issue.

I am on Windows 11 and struck this exact problem. The solution given by @thedataenginerd works perfectly here as well, thank you for saving me hours!
Be sure to check all environment variables, my computer had the path defined in multiple places.

I have no idea where cs writes to, is there some documentation on where this is?


Review project structure

Right now we have subprojects for each interepreter: zio, alpakka, cats-effect, etc. plus a few additional ones for refined types, joda time, java time, and ... scanamo-formats which contains DynamoFormat.
A few things come to mind:

scanamo: the core project holds interpreters, they should be factored out into *-v1 and *-v2 subprojects. Also I think we should rename it scanamo-core and perhaps keep the scanamo project for bundling a default set of choices?
-refined, -joda-time, -java-time: let's bundle that into a single scanamo-types subproject
scanamo-format should not be published anymore, it is just a subproject shared across all others. In fact, it may be necessary to remove it entirely since conversion from DynamoValue to AttributeValue will depend on which version of the SDK is being used, hence some concrete code will lie in -v1 and -v2 subprojects
finally there's a package per "concrete IO". Now I'd like to avoid having separate v1 and v2 projects for each implementation, but I'm not quite sure how to pull that off. Also we should rename scanamo-scalaz-zio as just scanamo-zio.

The goal is that people who want to be selective will have to add three dependencies: -core, -v<X> and -<IO>.

I think it make sense apart -refined, -joda-time, -java-time: let's bundle that into a single scanamo-types subproject I think ability to not depend on joda-time or refined is important to keep.

Yeah that makes sense 👍


Email communication strategy for interacting with PIs

Current thinking on this issue lives here
Workflow:

pull .csv of NSF awards from NSF award site
compare with ADC submissions per award
communicate with PIs according to their relationship with ADC (have submitted in the past, have never submitted before, etc) and the status of their award (recently awarded, ongoing, nearing completion, past)

Questions needing answer:

What is our desired system for emailing PIs and managing a volume of emails?
How does that system interact with RT for handing off PI questions seamlessly to Support team?
Is tone of the Email PI document (link at top of this comment) acceptable to ADC PIs and co-PIs?

Needed:
-[] greenlight to start this communication process from AB, MJ.

@irene has built some tools to get new NSF awards and look for NSF awards on ADC.
Also we have gotten some recent feedback from Arctic researchers that they are not aware of the ADC which may push the importance of this communication.
Two strategies may be needed

Set up a continous email strategy for new NSF awardees with information as well as potentially set up a skeleton submission for them to access on ADC
Retroactively email existing NSF awardees that have not yet submitted to ADC as of now with helpful information

Also related (from https://github.com/NCEAS/datamgmt/issues/135)
Link get_awards to arcticbot/email updates: provide option for new awardees to populate (some fields) of an EML template of sorts, to get an idea early-on about what’s expected (at least Project level - avoid PI’s copying and pasting NSF abstract to dataset)

Talked with @kameyer
@kameyer will draft two emails

An initial email from ADC for new NSF ARC awardees
An email when NSF ARC awards begin their final year

Data team will draft building the system to collect NSF awards and send emails systematically.
Will get permissions before implementing

KM to draft language for tickets - text to edit in awardBotADC repo


fix: respect CFLAGS for JIT compiling

subprocess.check_call throws on failure instead of returning non-zero.
The setuptools fallback would normally be required in conda environments, since CFLAGS is how the system headers are setup (eg, CFLAGS=... -I $CONDA_PREFIX/include). In particular, python <3.9 has a #include <crypt.h> line in Python.h: https://github.com/python/cpython/commit/9626ac8b7421aa5fc04a30359521d24f40105141
Since https://github.com/openai/triton/pull/3219 was revertted, the only option is to allow CFLAGS to inject the include headers, as required, during JIT.

ping on this

it's an environmental error that only occurred on AMD:
   File "/github/home/.cache/pre-commit/repou6k5itw1/py_env-python3/lib/python3.10/site-packages/yapf_third_party/_ylib2to3/pgen2/driver.py", line 248, in load_grammar
    g.load(gp)
  File "/github/home/.cache/pre-commit/repou6k5itw1/py_env-python3/lib/python3.10/site-packages/yapf_third_party/_ylib2to3/pgen2/grammar.py", line 95, in load
    d = pickle.load(f)

as to the other test errors, not sure what's going on with /usr/bin/ld not being found.

it's an environmental error that only occurred on AMD:
   File "/github/home/.cache/pre-commit/repou6k5itw1/py_env-python3/lib/python3.10/site-packages/yapf_third_party/_ylib2to3/pgen2/driver.py", line 248, in load_grammar
    g.load(gp)
  File "/github/home/.cache/pre-commit/repou6k5itw1/py_env-python3/lib/python3.10/site-packages/yapf_third_party/_ylib2to3/pgen2/grammar.py", line 95, in load
    d = pickle.load(f)

as to the other test errors, not sure what's going on with /usr/bin/ld not being found.

Those look like issues related to the patch

closing this as there hasn't been updates for a while. Feel free to reopen it if needed.


resource-locker-operator new version

New Submissions

[ ] Has you operator nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here

@J0zi can you please take a look at this? The csv is correct as far as I can tell, but the test fails to parse it correctly.

@raffaelespazzoli, forwarded to responsible team, bear with us.

@J0zi got it, thanks for letting me know.

it is not your issue @raffaelespazzoli , confiremed.

@raffaelespazzoli, Openshift is not possible to test due to some temporary outage, out of our scope, thanks for understanding.

/test CVP

@J0zi it doesn't look like the test where restarted.

asked CVP team

CVP team has a bug, contacted

/test CVP

@J0zi still does't look like it worked.

/test CVP

@raffaelespazzoli, CVP team reverted some change, so we will see. Don\t mention robot, he is just talking, but test are running:D

/test CVP

CVP is down, we cannot test. Once they fix it, we can continue. Thanks for understanding.