the font of code in notebook-markdown

Does this issue occur when all extensions are disabled?: Yes/No

版本: 1.60.0-insider (system setup)
提交: 7c25c174726ab969db3f99058cdf24bcfae1cfbe
日期: 2021-08-11T05:15:24.598Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.14393

text

view

please render it like markdown preview

markdown preview

@mjbvz Hello, I would like to work on this issue. This is my first time contributing, could you give any pointers? Where should I start looking to fix this?

@danila-grobov The css used for markdown is defined here: https://github.com/microsoft/vscode/blob/d3ceb35bece3f8ab658fb9006c9161e7a65d36c4/extensions/markdown-language-features/notebook/index.ts#L23
To test changes to this file:

Build VS Code normally
cd extensions/markdown-language-features
 yarn run build-notebook

Closing as this has been superseded by #136693 which adds syntax highlighting to these code blocks and also uses the editor font-family
Other tweaks the the rendering are welcome, although I don' think we want to add a background. Jupyter lab doesn't have one and it stands out too much imo in notebooks


Service to announce aggregate bonded transactions

Over time, I have noticed that newcomers have issues to work with AggregateBondedTransaction. Announcing them require to acknowledge well some concepts first, and when working with them always requires writing a considerable number lines of code.
Currently, announcing an AggregateBondedTransaction consists of:

Define the AggregateBondedTransaction
Sign the AggregateBondedTransaction
Define a HashLockTransaction
Sign the HashLock
Open a listener.
Announce (4).
When (4) is confirmed, announce (2).

To make the announcement more developer-friendly, we could define a service to summarize steps 5 to 6, which are the most challenging.
You can find here a possible first implementation without methods nor classes.

When listening to a transaction, the observable should be filtered out by transaction hash.
https://github.com/nemtech/nem2-docs/blob/master/source/resources/examples/typescript/aggregate/CreatingAnEscrowContractWithAggregateBondedTransaction.ts#L111
In a concurrent environment, one resued listener (one web socket) may be desired and another transaction for the same account may have been intercepted. Something similar could happen with errors, another transaction may fail and the error could be propagated to the wrong transaction listener.  We may need to add the transaction hash to the error status message coming in the web socket.

What about the status error message in case the transaction is incorrect?

I see, we could check as well in the same Service if the HashLockTransaction announcement presented an error and throw an error if so. However, I wouldn't care much in the service if the aggregate transaction reached the partial channel or not. This could be done at a later point by polling or with listeners.

I would even go with a service that permits 1 to 6 making HashLock something automatic that the user does not really need to do himself (but can change the fee for example).
class AggregateTransactionService {
    /**
     * Create an aggregate bonded transaction object that
     * needs signatures from given `cosigs` cosignatories.
     *
     * @return {AggregateTransaction}
     **/
    public createBonded(transactions, cosigs, networkType): AggregateTransaction {}

    /**
     * Sign an aggregate bonded transaction object with
     * given `cosigs` cosignatories.
     *
     * @return {AggregateTransaction}
     **/
    public signBonded(aggregate, cosigs): AggregateTransaction {}

    /**
     * Announce an aggregate bonded transaction object
     * with a hash lock of `spamFee` amount.
     *
     * :warning: The aggregate bonded transaction is only
     *                  when the hash lock transaction is confirmed.
     *
     * @return {Observable<Result>}
     **/
    public announceBonded(aggregate, lockFee?): Observable<Result> {}

    /**
     * Create a hash lock transaction with `lockFee` amount
     * and `aggregateHash` aggregate transaction hash.
     *
     * @return {HashLockTransaction}
     **/
    public createLock(lockFee, aggregateHash): HashLockTransaction {}
}

Not sure about the Observable<Result> or what should be returned by announceBonded, I guess you may want BlockInfo for the hash lock to be returned there in combination with aggregate transaction hash/hash lock transaction hash?
@dgarcia360 @fboucquez @rg911 from experience with usage of aggregate bonded, announcing is definitely the hurdle. Cosignatures handling is easy when the partial tx was announced (just need to fetch "unsigned tx" from partial endpoint). Thankful for feedback on the service approach

I would be more than happy to have a simplified service that does the following:
   /**
     * Announce an aggregate bonded transaction object
     * with a hash lock of `spamFee` amount.
     *
     * :warning: The aggregate bonded transaction is only
     *                  when the hash lock transaction is confirmed.
     *
     * @return {Observable<Result>}
     **/
    public announceBonded(signedAggregate:SignedTransaction, signedHashLock:SignedTransaction): Observable<TransactionAnnounceResponse> {}

By defining the HashLockTransaction outside the service, devs will be able to configure them completely (duration, deadline, mosaic, amount).

Treating transaction signatures outside, we avoid passing the Account object to the service, which contains the private key of the account.

Hey @rg911 @dgarcia360 @evias ,
This is my POC branch for the Java SDK. The idea and implementation can be easily ported to TS if you like it.  It's not a PR yet as I need to validate it with you first.
My plan is having a TransasctionService that knows how to announce a transaction, "wait" to be completed/added or fail if there is a status error (All is async by piping/merging observables). This can work for normal transactions, aggregate bonded and the hash lock "mix and match". The implementation uses low-level repositories and listeners (one implementation for both vertx and okhttp). It just a layer on top of them that makes clients' life easier.
https://github.com/NEMStudios/nem2-sdk-java/tree/JAVA-81-TransactionService
Use case (David's example using the TransactionService)
https://github.com/NEMStudios/nem2-sdk-java/blob/JAVA-81-TransactionService/integration-tests/src/test/java/io/nem/sdk/infrastructure/CreatingAnEscrowContractWithAggregateBondedTransactionIntegrationTest.java#L98
The proposed transaction service
https://github.com/NEMStudios/nem2-sdk-java/blob/JAVA-81-TransactionService/sdk-core/src/main/java/io/nem/sdk/api/TransactionService.java
The implementation:
https://github.com/NEMStudios/nem2-sdk-java/blob/JAVA-81-TransactionService/sdk-core/src/main/java/io/nem/sdk/infrastructure/TransactionServiceImpl.java
What do you think? By using this service, users won't need to know how to put the announce, completed listing and error handling pieces together.  Once the method finishes, the transaction is fully completed.

The solution looks really elegant and definitely will help to have a better development experience. Willing to see the service merged :)

+1 great implementation

Thanks! I'll formalize the Java PR and then I can jump over TS to implement this one. @rg911 ?

@fboucquez Just one comment, I agree in moving listener related functions (confirmed, aggregateBondedAdded) to the Listener repository.


A way to deal with UP1 via command line?!

I mean something like:

<command> | curl -F c=@- https://ptpb.pw
or http://ix.io

@perpi take a look at https://github.com/Upload/upclient - is this what you want?

Cool. It seems more than enough!

Glad to help.


Bump to v1.0.10

Hi,
with release 1.0.10 (see Release page) the version number in setup.py was not updated.
So e.g. pip can't find the latest version:
pip install --upgrade "tensor2tensor==1.0.10"
Collecting tensor2tensor==1.0.10
  Could not find a version that satisfies the requirement tensor2tensor==1.0.10 (from versions: 1.0, 1.0.1.dev1, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.0.9)
No matching distribution found for tensor2tensor==1.0.10

This PR fixes it :)

Thanks!


OTG Test - gNMI-1.11: Telemetry: Interface Packet Counters

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.423%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1050

Relevant Lines:
1491

💛  - Coveralls


Document profunctor-lens usage?

https://pursuit.purescript.org/packages/purescript-profunctor-lenses/

To support profunctor-lenses, what we would want to do is to code-generate a lens for each field name.
https://thomashoneyman.com/articles/practical-profunctor-lenses-optics/#lenses
-- This lens focuses on the "name" field of a record; we have to construct
-- this one ourselves.
_name :: forall a r. Lens' { name :: a | r } a
_name = prop (SProxy :: SProxy "name")


added converter for the ImagingStudy resource

As discussed on the mailing list [0], I started to work on some improvements for the HAPI FHIR Converter project. I am planning to submit pull requests for all changes, but I would like to get some feedback first for a small change before doing this for all changes. Therefore, this pull request contains the addition of a converter for the ImagingStudy resource. I used the available R3/R4 conversion maps [1] for guidance of this implementation. However, I would welcome any input for further improvements.
James mentioned on the mailing list, that I should submit pull requests against https://github.com/hapifhir/org.hl7.fhir.core , but it seems that the major part of the development is done in this repository. Therefore, I am submitting the pull request here. If this is not desired, I can of course also create pull requests against the other repository, but in this case it would be helpful to get some information about the relationship of these repositories.
[0] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/hapi-fhir/pNNaEqfDl7E/MdiXthdxAgAJ
[1] http://hl7.org/fhir/R4/imagingstudy-version-maps.html

Hi Tobias- If you could submit this against the org.hl7.fhir.core project, that would definitely be appreciated.
The copy of the converter in this repo is just a clone of the one there- we're in the middle of an effort to depend on the org.hl7.fhir.core project as a dependency actually to avoid having that copy in our repo shortly actually.

https://github.com/hapifhir/org.hl7.fhir.core/pull/19


Find a better way to pull a random S3 key.

Getting all keys and choosing a random one takes too long, and the delay is noticeable. Figure out some alternate method of getting a random S3 key.
Maybe gather the keys at the beginning, and add keys whenever an image gets added, and choose randomly that way? Deleted images would be a problem, so we'd have to have a check for that.
Maybe prepare the next random image in advance, so that it takes a long time but is immediate when someone calls it?
Maybe do more research into boto3 and S3 and see if you can cheat and get a random key server-side.

fukin DONE.


feat: table: add on row hover event

SUMMARY:
feat: table: add on row hover event
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:

[ ] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[ ] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@30de7c1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage        ?   84.63%
=======================================
  Files           ?      725
  Lines           ?    15758
  Branches        ?     5522
=======================================
  Hits            ?    13337
  Misses          ?     2353
  Partials        ?       68

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Bug]:  Context/CondensePlusContext Chat Engines do not include context in prompts to OpenAILike / OpenAI api

Bug Description
I'm attempting to create either a Context or a CondensePlusContext chat engine. I've ran two separate scenarios with the attached code, with two separate results. Running this engine with an active HuggingFaceLLM successfully embeds context in an LLM call and returns an accurate response. Running it against an OpenAILike / OpenAI API accessible via local API such as text-generation-webui does not include context or return accurate results.

Submitting queries with the attached code to a HuggingFaceLLM model successfully incorporates the index / context in generating an accurate response.
Submitting queries with the attached code to an OpenAILike / OpenAI (with base_url set to a local LLM accessible via Text-Generation-WebUI / TabbyAPI API's) does not incorporate the context in the prompt sent to the LLM's API. I do see context added to the stdout of the chat_engine.chat call, but it isn't actually added to the prompt received by the API.

Could this be a template issue somewhere?
Query Engines work fine with the OpenAILike API.
Version
0.10.18
Steps to Reproduce
I've attached the relevant snippets of code. The overall project uses Settings.llm to set the LLM / Embed models in the **self.engine_defaults variable.
def messages_to_prompt(messages):
    prompt_str = "\n".join([str(x) for x in messages])
    return f"<s>[INST] {prompt_str} [/INST] </s>\n"

def completion_to_prompt(completion):
    return f"<s>[INST] {completion} [/INST] </s>\n"

api_llm = OpenAILike(
            api_base=api_url,
            timeout=600,  # secs
            api_key=api_key,
            is_chat_model=True,
            context_window=4096,
            messages_to_prompt= messages_to_prompt,
            completion_to_prompt= completion_to_prompt,
            additional_kwargs= {
                "top_p": 0.5,
                #"top_k": 40,
            },
)

hf_llm = HuggingFaceLLM(
            context_window=4096,
            max_new_tokens=512,
            query_wrapper_prompt=query_wrapper_prompt,
            tokenizer_name="/home/directory/Tools/models/TheBloke_Mistral-7B-Instruct-v0.2-GPTQ",
            model_name="/home/directory/Tools/models/TheBloke_Mistral-7B-Instruct-v0.2-GPTQ",
            device_map="auto",
            tokenizer_kwargs={"max_length": 2048},
            messages_to_prompt= messages_to_prompt,
            completion_to_prompt= completion_to_prompt,
            generate_kwargs={"temperature": 0.3, "do_sample": False},
)

query_engine = self.ds.active_index.as_query_engine(similarity_top_k=4, **self.engine_defaults, streaming=True)
chat_engine = self.ds.active_index.as_chat_engine(
      query_engine = query_engine,
      chat_mode="condense_plus_context",
      similarity_top_k=4,
      streaming=True,
      chat_history=custom_chat_history,
      **self.engine_defaults
)

Relevant Logs/Tracbacks
No response

testing with both is_chat_model=True and is_chat_model=False, we can very clearly see the retrieved context being included when sending to the llm
the "simple" handler I used in the notebook just prints every llm input and output
https://colab.research.google.com/drive/1AuATkiCYq87aEQwuikhh1gXyA--Z6SL8?usp=sharing

testing with both is_chat_model=True and is_c

So, at least on my end, disabling is_chat_model in OpenAILike results in sending the context to my LLM. However, the response is truncated down to about a sentence. The same occurs with a query engine when is_chat_model is disabled. In both cases it sends the API a "max_new_tokens" of 16.
When is_chat_model is enabled query engines function as intended, with context sent to the LLM and an accurate, full response is returned. But the LLM does not receive the context when using Chat Engine with is_chat_model enabled. The context is however shown in sources (chat_engine.chat().sources).

I... don't know what that second part means.
How can I replicate this?

I can put a break point right before the api request is made, and see that everything is sent properly

Max new tokens of 16 will indeed stop at after a small sentence. That makes sense (16 tokens to generate isn't a lot)
I can also set a break point before the api request is sent, and observe that the full data is being sent in the request.
This seems like an issue with the server you are using not handling system prompts (which is where all the context is)

Max new tokens of 16 will indeed stop at after a small sentence. That makes sense (16 tokens to generate isn't a lot)
I can also set a break point before the api request is sent, and observe that the full data is being sent in the request.
This seems like an issue with the server you are using not handling system prompts (which is where all the context is)

Why would it send a max_new_tokens of 16 when is_chat_model is disabled, but 2000+ when it is enabled?

It seems the OpenAI Completions API at some point (and may still) default to 16 max_tokens for the completions endpoint. I can manually set a max_tokens parameter in OpenAILike to force longer responses, but it does not seem to automatically calculate this parameter as it did with is_chat_model=True. Is that expected behavior?

It depends on your server. By default, it's not set. For oepenai, this means generate as much as you can. For other servers, it may fallback to some server default

I’m thinking it’s LlamaIndex sending it as an argument to the API. If I set it manually in OpenAILike parameters and is_chat_model=False it respects this setting and the max_new_tokens returned matches the OpenAILike parameter. If I remove the parameter, it defaults to 16.
I tried manually setting max_new_tokens and enabled auto generation of max_new_tokens on the API server itself, but the server reports receiving an argument of max_new_tokens 16 or whatever parameter I set in OpenAILike.
Setting is_chat_model=True results in LlamaIndex sending a variable max_new_tokens to the server, but I lose context in Chat Engines (but not Query Engines).

It depends on your server. By default, it's not set. For oepenai, this means generate as much as you can. For other servers, it may fallback to some server default

Yeah it's either the model or template applied to said models, so not in the realm of responsibility for run-llama. I set a packet capture on my API to see what is actually coming through. With is_chat_model=True messages are submitted to the /chat/completions endpoint, but with different templates depending upon query / chat engine. I'm guessing this is intended behavior.
Chat tosses the context in the system prompt and Query tosses it in a user prompt. Model / template combo I was using for whatever reason didn't care about context in the system prompt, this second model acknowledges it.


There are some errors after converting it from swift 2.3 to swift 3.0

Hello,
I developed this pod when the iOS version 9.3 and I need it to upgrade into latest iOS version.
But After converting SMIconLabel, there are many errors.
Could you upgrade your repository works well for latest iOS version?
Thanks

Can you tell me what exact error do you see?


Basic Working example

Hi 👋,
First thing first, thank you for this awesome Casl integration initiative.
I followed your "Getting Started", but it does not work.
hooks in authentication.hooks.js file seem never called, maybe because authentication service (and hooks) is not registered in authentication.js generated file.
Do you have any basic working example repository ?
Thank you and have a nice day !

hey,
I've got no working example. Which version of feathers do you use? Is it generated by @feathersjs/cli or how do you organize it? If you like, share your authentication.js or just some parts.

Thank you for your reply (it's my first issue request on Github).
I use Feathers 4.5.11, I tried to set Feathers-casl up on a stock and fresh CLI generated app (with NeDB).
So the basic authentication.js file is
const { AuthenticationService, JWTStrategy } = require('@feathersjs/authentication');
const { LocalStrategy } = require('@feathersjs/authentication-local');
const { expressOauth } = require('@feathersjs/authentication-oauth');

module.exports = app => {
  const authentication = new AuthenticationService(app);

  authentication.register('jwt', new JWTStrategy());
  authentication.register('local', new LocalStrategy());

  app.use('/authentication', authentication);
  app.configure(expressOauth());
};

If, in the same file, I register "authentication" service and hooks that lets trig authentication.hooks.js
const { AuthenticationService, JWTStrategy } = require('@feathersjs/authentication');
const { LocalStrategy } = require('@feathersjs/authentication-local');
const { expressOauth } = require('@feathersjs/authentication-oauth');
const hooks = require('./services/authentication/authentication.hooks'); // require authentication.hooks

module.exports = app => {
  const authentication = new AuthenticationService(app);

  authentication.register('jwt', new JWTStrategy());
  authentication.register('local', new LocalStrategy());

  app.use('/authentication', authentication);
  app.service('authentication').hooks(hooks); //register authentication service and hooks
  app.configure(expressOauth());
};

is that the good way to do it ?

Yep, that's definitely a way.
You should have at least a folder with src/services/users containing users.service.js and users.hooks.js. Since the authentication is just another service (like all the other services), I handle it the exact same way.
Your authentication.js file is pretty much the same as users.service.js, so I renamed the authentication.js file in authentication.service.js and followed the same way as in users.service.js to register the hooks.
After this setup your after:create hook in authentication.hooks.js does not get called? If so, what does your authentication.hooks.js look like?

So, I renamed (just to follow your logic) ./src/authentication.js in authentication.service.js and move it to ./src/services/authentication/
Authentication service hooks are now called. ability and rules props are present in POST authentication response.
authentication.abilities.js and authentication.hooks.js are exactly de same as your example (copy/past) in your "Getting Started" section.
the only last thing I did is to add authorize() hook to tasks.hooks.js
const { authenticate } = require('@feathersjs/authentication').hooks;
const { authorize } = require('feathers-casl').hooks;

module.exports = {
  before: {
    all: [authenticate('jwt')],
    find: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ],
    get: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ],
    create: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ],
    update: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ],
    patch: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ],
    remove: [
      authorize({ checkAbilityForInternal: true }) // make sure this hook runs always last
    ]
  },

  after: {
    all: [
      authorize({ checkAbilityForInternal: true }), // make sure this hook runs always first
    ],
    find: [],
    get: [],
    create: [],
    update: [],
    patch: [],
    remove: []
  },

  error: {
    all: [],
    find: [],
    get: [],
    create: [],
    update: [],
    patch: [],
    remove: []
  }
};

So is there anything left?^^

If not, you could close the issue then. I won't add an example for now, but will keep it in my mind for later.
Do you know of the feathers slack group? It's a better place for general questions. http://slack.feathersjs.com/ :)

Maybe it's a misunderstanding  of CASL, but if I do a GET/READ (find) request on tasks service, I still have all tasks. not only tasks owned by the current authenticated user (use id : 75RYYlBKLp2HyAeF) .
{
    "total": 2,
    "limit": 10,
    "skip": 0,
    "data": [
        {
            "text": "my task 4",
            "userId": "75RYYlBKLp2HyAeF",
            "_id": "3ZLQN4eiLCQzsPjk"
        },
        {
            "text": "my task 4",
            "userId": "foobar",
            "_id": "fwracLtabKpi2GX2"
        }
    ]
}

Should it not be "filtered" by
can('manage', 'tasks', { userId: user.id });

PS: Thank you for the feathers slack channel.

Please post all your rules and what is the output of console.log(user.id)?
In a hook right before the authorize()-hook, what is the output of console.log(context.params.user)?

Here is the authentication.abilites.js
const { AbilityBuilder, createAliasResolver, makeAbilityFromRules } = require('feathers-casl');

// don't forget this, as `read` is used internally
const resolveAction = createAliasResolver({
	update: 'patch',       // define the same rules for update & patch
	read: ['get', 'find'], // use 'read' as a equivalent for 'get' & 'find'
	delete: 'remove'       // use 'delete' or 'remove'
});

const defineRulesFor = (user) => {
	// also see https://casl.js.org/v5/en/guide/define-rules
	const { can, cannot, rules } = new AbilityBuilder();

	console.log(user.id) //debug purpose

	if (user.role && user.role.name === 'SuperAdmin') {
		// SuperAdmin can do evil
		can('manage', 'all');
		return rules;
	}

	if (user.role && user.role.name === 'Admin') {
		can('create', 'users');
	}

	can('read', 'users');
	can('update', 'users', { id: user.id });
	cannot('update', 'users', ['roleId'], { id: user.id });
	cannot('delete', 'users', { id: user.id });

	can('manage', 'tasks', { userId: user.id });
	can('create-multi', 'posts', { userId: user.id })

	return rules;
};

const defineAbilitiesFor = (user) => {
	const rules = defineRulesFor(user);

	return makeAbilityFromRules(rules, { resolveAction });
};

module.exports = {
	defineRulesFor,
	defineAbilitiesFor
};

console.log(user.id) returned undefined
and in tasks.hooks.js
const { authenticate } = require('@feathersjs/authentication').hooks;
const { authorize } = require('feathers-casl').hooks;

module.exports = {
  before: {
    all: [authenticate('jwt')],
    find: [
      (context) => {
        console.log(context.params.user) //debug purpose
        console.log(context.params.ability) //debug purpose
      },
      authorize({
        checkAbilityForInternal: true,
      }) // make sure this hook runs always last
    ],
//[...]

context.params.user returned
{
  email<EMAIL_ADDRESS>  password: '$2a$10$tTeAjaao60c0f7n1zIrlOubu6pNpRnckYFI37drSOmjYebVmfkrte',
  firstname: 'Alex',
  lastname: 'Auss',
  active: true,
  _id: '75RYYlBKLp2HyAeF'
}

and context.params.user returned   undefined
I just publish a repo with my files :
https://github.com/alxblog/feathers-casl-example

multiple problems here:

you use _id, not id
if context.params.ability is undefined, so authorize() will be skipped at all
Please set some breakpoints here and there and see how it goes. First of all check the hook in authentication.hooks.js, then your authentication.abilities.js.

did you find the error? What was the problem?
If there's anything left, let me know.

Alright, thanks for clarifying, I hadn't looked at the Vue integration yet at all. Very nice!


Clicking "How to cite PATRIC" leads to an error page

A user pointed this out,  Here is a screenshot of what it looks like when you click on the citation link.

Specifically, the citation link at the bottom of the page.
https://patricbrc.org/content/CitePATRIC
The one in the hamburger icon works.
https://patricbrc.org/webpage/website/cite_patric.html
Ron
On Sun, Dec 17, 2017 at 1:51 PM, ARWattam<EMAIL_ADDRESS>wrote:

A user pointed this out, Here is a screenshot of what it looks like when
you click on the citation link.
[image: screen shot 2017-12-17 at 1 49 58 pm]
https://user-images.githubusercontent.com/11475316/34082721-57f2c236-e331-11e7-99a2-d080ecc734d3.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PATRIC3/patric3_website/issues/1826, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADCnWic_2HJMjpkAAHOk2iXfWYb9Db-2ks5tBWKkgaJpZM4REwRT
.[image: Web Bug from
https://github.com/notifications/beacon/ADCnWiEr9RGmZEoXVZE3OM8qeMjEp6CQks5tBWKkgaJpZM4REwRT.gif]

--
Note: My email has changed to<EMAIL_ADDRESS>Ron Kenyon, Project Director
Biocomplexity Institute of Virginia Tech
PATRIC Project Manager www.patricbrc.org
<EMAIL_ADDRESS>

Ah, okay, i will update the footer. and will check whether we still have link to /content/

will be deployed by Dec release


windows install error

(superglue_3.8) D:\code\gitload\g2opy-master>python setup.py build --force develop
running build
running develop
C:\app\Anaconda3\envs\superglue_3.8\lib\site-packages\setuptools\command\easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
C:\app\Anaconda3\envs\superglue_3.8\lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running egg_info
writing UNKNOWN.egg-info\PKG-INFO
writing dependency_links to UNKNOWN.egg-info\dependency_links.txt
writing top-level names to UNKNOWN.egg-info\top_level.txt
reading manifest file 'UNKNOWN.egg-info\SOURCES.txt'
writing manifest file 'UNKNOWN.egg-info\SOURCES.txt'
running build_ext
Creating c:\app\anaconda3\envs\superglue_3.8\lib\site-packages\UNKNOWN.egg-link (link to .)
UNKNOWN 0.0.0 is already the active version in easy-install.pth
Installed d:\code\gitload\g2opy-master
Processing dependencies for UNKNOWN==0.0.0
Finished processing dependencies for UNKNOWN==0.0.0

i have installed g2o sucessfully, but still erro exsits: ModuleNotFoundError: No module named 'g2o.contrib'

Hi @July0928
I am not sure your issue is related to this package. You can install it using pip as in the README.md:
pip install -U g2o-python

Hi @July0928
I am not sure your issue is related to this package. You can install it using pip as in the README.md:
pip install -U g2o-python

Could you please let me know:
* OS version

* Python version (`python --version`)

* Any other details that you think might be relevant

OS version windows10  22H2 19045.3570， python 3.8.13 ，

@miquelmassot

@miquelmassot And  only the "from .g2opy import *  # noqa: F401" in g2o.


MM-31674 Cloud app/product notices for ext dependecies

Documentation for: mattermost/mattermost-server#16871
Updated:

Cloud Admin Guide > Configuration > Site Configuration > In-Product Notices > Administrator Notices

Updated description to include deprecation of external dependencies

@wiersgallak - Please confirm that Admin Notices will inform Cloud System Admins of the following:

when a new server version is available
when external dependencies are being deprecated
when a server upgrade is recommended due to ending support life cycles
when recommended server configuration options can optimize the user experience of their deployment

I suspect that not all of these are true for Cloud System Admins; I can update the product documentation accordingly.

@cwarnermm We will not use in-product notices for Cloud for these use cases as they are on-premise only:

when a new server version is available
when external dependencies are being deprecated
when a server upgrade is recommended due to ending support life cycles

This one may still be applicable as long as the configuration option is available in the System Console for Cloud instances:

when recommended server configuration options can optimize the user experience of their deployment

Thanks, @wiersgallak!


Fill out the Mordecai user survey!

I'm embarking on an overhaul of Mordecai to improve performance and address many of the issue here. If you use the library, please help out by answering 2 minutes of questions about how you use it and what you'd like to see in the next version: https://z0l4ihmu0ud.typeform.com/to/b8FmCfMt

Smart...
===================================
Philip A. Schrodt
Parus Analytics LLC
Charlottesville, VA 22901
Phone: +1-785-550-3553
Home page: philipschrodt.org
Parus Analytics: parusanalytics.com
Open Event Data Alliance: openeventdata.org
Event Data Project: eventdata.parusanalytics.com
Blog: asecondmouse.org http://asecondmouse.wordpress.com
===================================
On Mon, Feb 1, 2021 at 9:41 AM Andy Halterman<EMAIL_ADDRESS>wrote:

I'm embarking on an overhaul of Mordecai to improve performance and
address many of the issue here. If you use the library, please help out by
answering 2 minutes of questions about how you use it and what you'd like
to see in the next version: https://z0l4ihmu0ud.typeform.com/to/b8FmCfMt
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openeventdata/mordecai/issues/93, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDGYAYAKT2OZHFKSRHXF7DS424QNANCNFSM4W445FPA
.

Thanks to everyone who has already filled out the survey. I'm hoping to release Mordecai v3 sometime in July. It's based on spaCy v3/transformers and pytorch and is much more accurate than v2. Responses to the survey are available here and more responses are welcome!


Multiple, custom line number gutters

To complete atom/github#1512, I need to be able to add multiple Gutters to an editor, each of which has a custom labelling function. I'm emulating this effect:

I did make a bit of an effort to do this with the existing Gutter API. I was able to get the root DOM element of an added Gutter with getElement() and render a React portal into it, but I ran into problems duplicating the logic from LineNumberGutterComponent because I couldn't find a way to trigger re-renders of the React component when the parent Etch component re-rendered, so the two would quickly get out of sync.

This adds a type property to the options object accepted by TextEditor::addGutter(). If set to 'line-number', a LineNumberGutterComponent is created instead of a CustomGutterComponent, and a labelFn option may be supplied to customize the created line number labels.

Remaining

[x] Decorations added with TextEditor::decorateMarker(marker, {type: 'line-number', ...}) should only decorate the One True line-number gutter.
[x] Support a className option in TextEditor::addGutter(). Add the provided CSS class to the gutter's root element. This will make it easier to style line-number gutters.
[x] Support onMouseDown and onMouseMove callbacks in TextEditor::addGutter().
[x] Tests green.

Progress:
atom.commands.add('atom-workspace', 'me:add-line-number-gutters', () => {
  const editor = atom.workspace.getActiveTextEditor()
  if (!editor) {
    return;
  }

  editor.addGutter({
    name: 'custom-1',
    type: 'line-number',
    priority: 2,
    labelFn: ({bufferRow}) => `1.${bufferRow}`
  })

  editor.addGutter({
    name: 'custom-2',
    type: 'line-number',
    priority: 3,
    labelFn: ({screenRow}) => `2.${screenRow}`
  })
})

The custom gutters scroll correctly and everything, too 🚀
One interesting side-effect is that the line-number decorations from the git-diff package show up on every line-number gutter. That's a bit odd, so I'll fix those to target the One True line-number gutter by default; you should still be able to go through Gutter::decorateMarker() to add line-number decorations to other line-number gutters.

I'm a bit leery about touching code in TextEditorElement and friends on my own without an extra set of eyes for safety. Reviewers, when you get a moment, could you look for any obvious red flags for performance or correctness? API change feedback is welcome as well if you have any. 🙇

Would it be worth adding a test for the rendering side of things in text-editor-component-spec.js, where you add a gutter with a custom labelFn, and assert that the right labels show up, and that the line numbers and line tiles have the right widths?

👍 I'll get this in place, then merge.
Thanks for the eyes 🙇


agent(netpol): Explicitly enable IPv4 when necessary

Before this change, kube-router was always assuming that IPv4 is
enabled, which is not the case in IPv6-only clusters. To enable network
policies in IPv6-only, we need to explicitly let kube-router know when
to disable IPv4.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

It's just an OR condition. I think it makes sense to explicitly set bot enableIPv4 and enableIPv6 to true when there is dual node/service/cluster.
Having only iPv4 address will be enough for enableIPv4 to be true - because of last serviceIPv4 || clusterIPv4 conditions. So I think we are fine.

But feel free to propose your exact conditions if you have some better set in mind.

@brandond This is mostly for kube-router, which needs to be explicitly aware of which family addresses it should enable. kube-router config has EnableIPv4 and EnableIPv6 to specify, our mistake (before this PR) was just setting the first one to true.

It's just an OR condition. I think it makes sense to explicitly set both enableIPv4 and enableIPv6 to true when there is dual node/service/cluster.
Having only iPv4 address will be enough for enableIPv4 to be true - because of last serviceIPv4 || clusterIPv4 conditions. So I think we are fine.

You are right. I wonder what would happen if the user, incorrectly, defines an ipv4 service-cidr but an ipv6-cluster-cidr. Or any other combination.... but this should be outside of the scope of this PR

@vadorovsky note that we are in code freeze period

Converting into draft again, @manuelbuil found a bug

It should work now - I managed to fix the iptables: Index of insertion too big error

Works but I noticed that after deleting the networkPolicy, the ipsets are not deleted. When you create another networkPolicy and delete it again, all ipsets stay. Not sure if this is caused by this PR or was already there before

When using k3s v1.22.7+k3s1 and ipv4 policies, I can see ipsets getting deleted

When using v1.23.6-rc4+k3s1 and ipv4/ipv6 policies, I can see ipsets getting deleted after removing the network policies. Let me retry with this PR to confirm

Can't reproduce it anymore, strange

Huh, this PR being the cause would be really weird - I finally didn't make any changes in kube-router code. The problem causing the iptables error was fixed here:
https://github.com/k3s-io/k3s/pull/5470/files#diff-fb0d3f04de1f9a3d8d8b026f36eb524da428f8d380bc844fe5ca61e5c4b4914bR83-R94
And it was about wrong way of initializing iptablesHandlers - before this PR, we were creating IPv4 handler even for IPv6-only clusters, so then we were failing there:
https://github.com/k3s-io/kube-router/blob/v1.3.2%2Bk3s/pkg/controllers/netpol/network_policy_controller.go#L416-L434
because:

We have only primaryServiceClusterIPRange where the CIDR is IPv6, so we create a rule in ip6tables at position 1. Here we don't iterate over iptablesHandlers, but we pick the correct one based on CIDR family
We don't have secondaryServiceClusterIPRange.
When creating whitelistTCPNodeports ruile, we iterate over iptablesHandlers, so we try to create IPv4 iptables rule at position 2, so we crash, because iptables IPv4 has no previous rules.

Can't reproduce it anymore, strange

Glad to hear that. :sweat_smile:


Visit(QueryExpression)': not all code paths return a value

Method Visit in a sample code Sample: Generic virtual entity data provider plug-in cannot be compiled correctly because of an error
Visit(QueryExpression)': not all code paths return a value
there's no else branch for clause if (filter.Conditions.Count > 0)

Refers to this article: https://docs.microsoft.com/dynamics365/customer-engagement/developer/org-service/build-queries-with-queryexpression

Looks like the issue is related to this code snippet: Sample: Generic virtual entity data provider plug-in. It's not a full-fledged sample but just a code snippet. Please contact support of you need further help with this sample.


remove duplicate example about overriding an exception

:pushpin: Commit a7fa00c has been approved by japaric

@homunkulus r+

:hourglass: Testing commit a7fa00c with merge a7fa00c...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing a7fa00cdc07d06b46dfccc6478e2a28defe9faa0 to master...


Custom domains should be supported by experimental ingress

deis domains isn't yet working with the new experimental native ingress feature.

This issue was moved to teamhephy/controller#26


Tests for CASSANDRA-5174

These are the tests for CASSANDRA-5174.
As I am a python novice, please don't shy away from style comments in the code review.
Thanks!

Looks excellent, +1. Could you squash the commits a bit though? At least the most recent two.
We'll merge when CASSANDRA-5174 is committed

Rebased and squashed, thank you.


Project cannot build

Running npm run build results in error:
Invalid switch - "dist".

Hi, did you run npm run install before?

Hi, did you run npm run install before?


Jenkins returns the queue location of newly-created builds; we should too.

https://issues.jenkins-ci.org/browse/JENKINS-12827?focusedCommentId=201381#comment-201381
This request also contains a lot of whitespace fixes.

Are there further problems with this pull request?

@ifreecarve sorry for the delay! This is looking good, thanks for the PR :) :+1:


rg-autocomplete should extends rg-select

Hi,
first of all: great job!
I think that to adhere to a modular style the component rg-autocomplete should extends the rg-select, or at least they should extends a more basic component.
Another good technic could be tu use composition for common functions such sharing a mixin module.
I didn't inspect all components but this should be the way for all modules.

Yes you are correct. I started following the pattern when I did rg-timepicker...
And have been thinking about mixins recently for things like overlays etc. bits that people could use outside of components but that the components could use themselves

As part of v2 (not released yet)
https://github.com/RiotGear/rg/blob/master/components/select/rg-select.tag#L4
rg-autocomplete is removed and is simply an option on rg-select


⚠ API Next - load whole book has degraded performance

In 3a25c79, API Next - load whole book (https://h-edu.cz/content.api/book/book-a/chaptersContent) experienced degraded performance:

HTTP code: 200
Response time: 15973 ms

Resolved: API Next - load whole book performance has improved in 00e96a3 after 18 minutes.


Separate data model related operations

Please review the updates. Suggestions are most welcomed.
Thanks,

@ihemantd PR looks good. but i think you need to link "ConferenceDatastore" to rubyraven target.
We have two target "ConferecneApp" and "rubyraven"

Nope. Right now we are not using ConferenceApp target inside app or apple store.

@arunagw Thanks for the clarification !

Thanks for work and PR you are doing for this project.

Pleasure is mine, I am learning new things and very happy to work !


Feature/convolution workspace

@homu r+

:pushpin: Commit dad281f has been approved by hobofan

:hourglass: Testing commit dad281f with merge 47a6a00...

:sunny: Test successful - status


Expand collect-debug-info capabilities

Currently, collect-debug-info truncates logs in an (often failed, resulting in a 405) attempt to fit them into a Gist.
There is a --tarball option for dumping locally. It would be nice if an --all or similar option for that to collect all necessary info, so that a second collection pass isn't required.
It would also be super awesome if there were an --s3 option that could attempt an S3 upload to a passed-in path, rather than a Gist.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


[2022.3.2] bug/enhancement: when handling kytos/topology.link_up an active dynamic EVC shouldn't redeploy

when https://github.com/kytos-ng/mef_eline/issues/468 gets fixed, let's release a new patch as 2022.3.2

This landed on https://github.com/kytos-ng/mef_eline/pull/472


Console warnings in browser : The value provided to Autocomplete is invalid. None of the options match with ""

Getting the below message in browser console-
Material-UI: The value provided to Autocomplete is invalid.
None of the options match with ""
getOptionSelected and filterOptionSelected has been provided. Still the warning message pops up in browser.

@oliviertassinari So currently there's no way to fix the warnings as it needs additional support yet?

''" is very likely not a valide value


docs: Improved LightGBM docs

What changes are proposed in this pull request?
More thorough LightGBM docs

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
82
100
82
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
92
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
95
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

/azp run

Codecov Report

Merging #2003 (51c9221) into master (1209fa2) will decrease coverage by 69.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2003       +/-   ##
===========================================
- Coverage   87.08%   18.01%   -69.08%
===========================================
  Files         306      306
  Lines       16062    16062
  Branches      827      827
===========================================
- Hits        13988     2893    -11095
- Misses       2074    13169    +11095

Impacted Files
Coverage Δ

...oft/azure/synapse/ml/lightgbm/NetworkManager.scala
0.00% <ø> (-92.23%)
:arrow_down:

... and 267 files with indirect coverage changes

LightGBM not working properly under an auto-scaled environment itself is reason enough to implement GPU support as it will speed up the training time, thereby reducing the chances of task failures

LightGBM not working properly under an auto-scaled environment itself is reason enough to implement GPU support as it will speed up the training time, thereby reducing the chances of task failures

Ilya will look into using GPU build, but it's not as simple as having a build with CUDA enabled.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
95
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
95
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

/azp run

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
95
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

/azp run

/azp run

/azp run

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/features/lightgbm/about.md
95
100
92
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx


Create new function app infrastructure

[x] Confirm if event target / subscription has to be in same RG as the event grid sources
[x] Create base infrastructure

[x] Resource group name for function app
[x] Storage container for function app
[x] Storage container for processing configurations
[x] App service plan and application deployment

[x] Create subscription to events from the ETL layer

[x] Subscription to the storage system provider for the input data storage
[x] Subscription to the new custom topic in the ETL layer for processing

The subscriptions are created within this layer, which makes perfect sense, against the event grid providers in the other resource groups. Therefore we can start straight away working with a subscription against the input storage container.

The azurerm_eventgrid_system_topic_event_subscription cannot cross the resource groups to focus on the precreated system topic in the ETL layer. Therefore we need to create either a domain topic or an output service bus we can hook into
For the moment I've create a manual sub as this is taking a bit long and I need to test it. Will raise an issue to replace the above, which is currently commented out.


Add explicit dependencies between resources using dependsOn

This looks fine, but a small style note - There are two different things going on in this PR from what I can tell - you are improving documentation of dependencies, and you are removing reference to certain fields in the API. If there are two different things happening, either separate them into different PRs, different commits, or at the very least add some explanation to the PR description so that a reviewer (or a person working on this code in the future) can understand the context of these changes. Lately, I have signed on to Jason's convention which is to have commit messages that explain thoroughly what the changes are. I usually squash all my changes into a single commit, unless there are distinctly different changes I am making that wouldn't make sense to put into one commit and I didn't feel the need to spin off into its own PR.

Thanks Gil. Will keep that in mind.


Fix #274: Include subdirectories when processing images

I'm not sure if subfolders were deliberately excluded but here's a PR anyway

Huh. Surprised no one's caught that in all this time. Not intentional. Thanks!


Remove cp1252-encoded files from Git control

Having all the source files in UTF-8 simplifies maintenance (e.g. release scripts where newlines are processed)
The relevant files can be created on-demand (in a temp directory) if needed.

Codecov Report

Merging #503 into master will increase coverage by <.01%.
The diff coverage is 60%.

@@             Coverage Diff              @@
##             master     #503      +/-   ##
============================================
+ Coverage     54.68%   54.68%   +<.01%
- Complexity     9767     9768       +1
============================================
  Files          1016     1016
  Lines         62821    62827       +6
  Branches       7085     7086       +1
============================================
+ Hits          34351    34359       +8
+ Misses        26038    26036       -2
  Partials       2432     2432

Impacted Files
Coverage Δ
Complexity Δ

...ocol/jms/sampler/render/BinaryMessageRenderer.java
100% <100%> (+12.5%)
6 <0> (ø)
:arrow_down:

...ava/org/apache/jmeter/testkit/ResourceLocator.java
62.5% <50%> (ø)
4 <0> (?)

.../src/main/java/org/apache/jorphan/io/TextFile.java
51.16% <0%> (+6.97%)
7% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb66808...c16e50c. Read the comment docs.


Fix OOB in printk.c

Fixing OOB for issue https://github.com/zephyrproject-rtos/zephyr/issues/80263

If I am following things correctly, the issue you are trying to prevent only arises when both CONFIG_USERSPACE is enabled and char CONFIG_PRINTK_BUFFER_SIZE is 0.
I think a simpler solution is to ensure that CONFIG_PRINTK_BUFFER_SIZE is at least 1. This can be done with a BUILD_ASSERT() when CONFIG_USERSPACE is enabled and forcing it to 1 instead of 0 when not defined.

Indeed that's a better solution to this.

Indeed that's a better solution to this.

do you want to update your patch accordingly? Thank you!


riot compiler don't work

MacBook-Pro$ riot
module.js:340
throw err;
^
Error: Cannot find module './compiler'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/usr/local/lib/node_modules/riot/compiler/index.js:55:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)

After  「npm install -g riot 」
file 'compiler/compiler .js'  missing

under
mac osx 10.10.1
node v0.10.34
npm 1.4.28

same here
ubuntu 14.04, node 0.10.25, npm 1.3.10

I got the same error,
ubuntu 14.04, node 0.10.25, npm 1.3.24

<EMAIL_ADDRESS>is not included compiler/compile.js<EMAIL_ADDRESS>still include this file.
Temporary solution:
npm install [-g]<EMAIL_ADDRESS>

Temporary solution worked for me.
Thanks @e-jigwas

Looking into this now.

in compiler/index.js the line
compiler = require('./compiler')
is useless, it should be removed (is this is the compiler).
Then things seem to work fine.

This is fixed now. Please install v2.0.5.

@ecraven
the compiler is used in index.js +116

This is fixed now. Please update to v2.0.5.

@aurri :+1:

its work. :)

That was pretty silly issue actually. We renamed the compiler in the last minute before releasing and forgot to include it in npm package. The solution turned out to be 1 character fix: https://github.com/muut/riotjs/commit/91e296e68c4c5d67eb5e7c7d9d74a758294cd6de
Thanks everyone for such a prompt feedback!

That was fast :) Thank you!


Add Pixel 9 to readme

I have the Pixel 9 Pro XL. Can confirm it works.

Thank you, forgot to add it yet


chore: remove superfest

Nice! Much better already but let´s also come back and reduce number of "QuestCards" (currently used in "Quests" and "ProfilePage" folders) or maybe rename such components. The same with QuestCardSkeleton.

We already discussed, this is just a note.

Nice! Much better already but let´s also come back and reduce number of "QuestCards" (currently used in "Quests" and "ProfilePage" folders) or maybe rename such components. The same with QuestCardSkeleton.
We already discussed, this is just a note.

A bit different from what we discussed. But yes agree with you, let's clean the naming or remove one of them, good call.


Interactive GUI should not be interactive when covered

If a button is covered by another piece of gui, such as a panel or textlabel, then the button should no longer be clickable as the user has no real way of knowing if they're clicking on a button or not. This is not the case, which needs to be rectified.

Finally fixed in a very elegant manner in commit 744b77c8f38ed0e4009173fa7fdb0cf0872e06c6. Really happy with it!


Fixes doc typo and highlighting type (#257 and #258)

Fixes #257 and #258

:shipit: I'm breaking protocol and self approving this PR since it's very small and non functional


"×" should be "×"

I ran into an issue where the "×" symbol to close the lightbox was being misinterpreted by the browser as "Ã–" (Safari) so I propose changing it to the HTML entity "×" in the JavaScript.

Thanks for the report, care to file a PR?

I like lity, thanks for that jsor.
Made a pull for this minor issue;
https://github.com/jsor/lity/pull/32

Released in v1.6.5.

Love Lity buddy, thanks! Just a heads up, this issue still seem to appear. Had to change 'x' to × myself.


Upgrade Docker images and fixes digest

Upgrade main modules Docker images.
Fixes images to specific digest.
Switches from openjdk images to temurin images.

temurin images are baked by Eclipse and provide long-term support. openjdk doesn't provide LTS.

I haven't tested my solution. Hopefully, the CI will do.
TODOs

[ ] Tests
[ ] Documentation

Hmm, there's no CI?

Hello @Naramsim, First of all thank you for the submission. Back then, when we moved from Travis to Eclipse CI, the Eclipse CI was not able to build container images. I will need to check whether this is possible by now...


Added assertRequiredPluginsPresent to Shopware\Components\Plugin ...

… like in legacy Shopware_Components_Plugin_Bootstrap

1. Why is this change necessary?
2. What does this change do, exactly?
The same like in legacy Shopware_Components_Plugin_Bootstrap
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
Added in Upgrade-5.4.md
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I am not sure if this function is needed, since it can be easily implemented but if, it should get implemented, I think the the container parameter active_plugins should be used to check if the required plugins are active, to avoid database queries:
protected function assertRequiredPluginsPresent(array $plugins)
{
    return !(bool) array_diff(
        $plugins,
        array_keys($this->container->getParameter('active_plugins'))
    );
}

Maybe if such a function is implemented there are still some more things to be considered, the first to things which came into my mind are:

Check for the correct versions of each plugin
Maybe it would be better not to return a Boolean value, but an array containing all the missing plugins

hey @Mardl
thanks for your first PR!
In the new plugin system the required plugins should be declared in the plugin.xml file of your plugin.
See the XSD file https://github.com/shopware/shopware/blob/5.4/engine/Shopware/Components/Plugin/schema/plugin.xsd#L17
You can find an example here: https://developers.shopware.com/developers-guide/plugin-quick-start/#require-other-plugins


Error when creating 2 different service that use the same template name from 2 different AWX

How to reproduce:

Create 2 AWX/Tower instance
Create a service that use the "Demo job template" from AWX A
Create another service that use the "Demo job template" from AWX B

Traceback:
Traceback (most recent call last):
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/home/nico/Documents/squest/service_catalog/views/admin/catalog.py", line 20, in add_service
    if form.is_valid():
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 177, in is_valid
    return self.is_bound and not self.errors
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 172, in errors
    self.full_clean()
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 374, in full_clean
    self._clean_fields()
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 392, in _clean_fields
    value = field.clean(value)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/fields.py", line 149, in clean
    value = self.to_python(value)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/models.py", line 1274, in to_python
    value = self.queryset.get(**{key: value})
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/db/models/query.py", line 433, in get
    raise self.model.MultipleObjectsReturned(
service_catalog.models.job_templates.JobTemplate.MultipleObjectsReturned: get() returned more than one JobTemplate -- it returned 2!
ERROR 2021-07-13 13:00:37,743 log Internal Server Error: /settings/catalog/service/add_service/
Traceback (most recent call last):
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/contrib/auth/decorators.py", line 21, in _wrapped_view
    return view_func(request, *args, **kwargs)
  File "/home/nico/Documents/squest/service_catalog/views/admin/catalog.py", line 20, in add_service
    if form.is_valid():
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 177, in is_valid
    return self.is_bound and not self.errors
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 172, in errors
    self.full_clean()
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 374, in full_clean
    self._clean_fields()
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/forms.py", line 392, in _clean_fields
    value = field.clean(value)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/fields.py", line 149, in clean
    value = self.to_python(value)
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/forms/models.py", line 1274, in to_python
    value = self.queryset.get(**{key: value})
  File "/home/nico/.cache/pypoetry/virtualenvs/tower-service-catalog-X_7Nmek_-py3.8/lib/python3.8/site-packages/django/db/models/query.py", line 433, in get
    raise self.model.MultipleObjectsReturned(
service_catalog.models.job_templates.JobTemplate.MultipleObjectsReturned: get() returned more than one JobTemplate -- it returned 2!
[13/Jul/2021 13:00:37] "POST /settings/catalog/service/add_service/ HTTP/1.1" 500 109972

Fixed in resource tracker branch


Garbage collection

Fixes #1

lmao... closing this joke, thanks for being my friend @bertonha, love trolling you my brother :D

But @rochacon where is the new patch?


Yi Outdoor - 9FUSY26

I have a newer Yi Outdoor Camera 1080p, which starts with 9FUSY26.
Tried the YI Hack V5 which worked for my older Yi Outdoor cameras, but no luck on this one.
Any plans to support this model @roleoroleo?

I need to know the fw version, you can read it inside the app.

After some digging, I did see there was an attempt some time ago to create a firmware hack for this model, but it was abandoned due to what I can only imagine was the complexity to get it working. roleoroleo/yi-hack-MStar#220 has the discussion.

If the model is the same discussed above, I can't support it. Too different than other platforms.

Thank you, thought as much.


missing table message_source

I tried to install yii2-yee-cms, but not successful. I think the problem is missing table message_source.
Please help.
thx.

Hi! Please install yeesoft/yii2-yee-translation module and apply @yeesoft/yii2-yee-translation/migrations migration


Use sortText to choose preselected CompletionItem if there are multiple CompletionItems with preselect=true

According to the vscode api doc, if there are multiple CompletionItem with preselect=true, vscode will choose the first item of those that match best.
I think it's better to use sortText as a backup comparator in this case, there are two reasons:

The definition of match best is not clear to extension developers, this may cause unexpected behavior and it's really difficult to debug
Generally, better CompletionItem costs longer to compute. Just use the first CompletionItem as preselect item might lower the quality of the whole completion result.

Here is an example:

The first two completion items are provided by my extension. The preselected item will be always the last one, even though the first item matches better and I set the preselect=true for the first item.

It is done like that. The editor uses sortText and prefix-match quality to determine a set of top scorer and when in that set multiple items have preselet set then the first is selected. I am not sure what the issue here is. Is this unclear doc or what is this?

IMO, if there are multiple items having preselect=true, I think it's better to take sortText into consider, rather than just choose the first item.
For example, if there are three completionItems:
const item1 = {
  label = "item1",
  preselect = true,
  sortText = "000"
}
const item2 = {
  label = "item1",
  preselect = true,
  sortText = "001"
}
const item3 = {
  label = "item1",
  preselect = true,
  sortText = "002"
}

Then vscode should choose item1 because this item has a better sortText, rather than just choose whichever comes first.

rather than just choose whichever comes first.

sortText does determine which "comes first".

It's strange. In this case, vscode chooses to preselect the last item, even though this item is sorted at the bottom(which means it has a lower sortText score, right?)

what's your config for editor.suggestSelection

It's first.

ok, then (while suggestion show), hit cmd+? (or ctrl+?) . the details widget will show internals, like sortText, prefix, score etc. That should explain the order

I tried, but it shows nothing.. Do I have to do something like key binding?

Make sure the details widget shows, usually via ctrl+space when suggestion already show

The info doesn't explain the preselect behavior as well.
In the previous example, the info for first write is:
score:-100(no prefix)
distance:0
index:0, based on sortText:"0"

The info for last flush(); is:
score:-100(no prefix)
distance:0
index:8, based on sortText:"0"

I haven't figure out why the last flush(); is preselected, but I found another bug in vscode here:
https://github.com/microsoft/vscode/blob/7f49bf19401168d97be72ffa7c842ab5de4775fa/src/vs/editor/contrib/suggest/suggestMemory.ts#L24-L41
at line29, the index starts from 1, which means the preselected item will NEVER be the first item if there are multiple items having preselect=true.
You can easily reproduce this using the following code:

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	let sel:vscode.DocumentSelector = { scheme: 'file' };
	let LanguageServerProvider = vscode.languages.registerCompletionItemProvider(sel, {
		provideCompletionItems(document: vscode.TextDocument, position: vscode.Position) {
			let completionResult: vscode.CompletionItem[] = []
			let a = new vscode.CompletionItem("a");
			a.preselect = true;
			a.filterText = "a"
			a.sortText = "0";
			let b = new vscode.CompletionItem("b");
			b.preselect = true;
			b.filterText = "b"
			b.sortText = "00";
			let c = new vscode.CompletionItem("c");
			c.preselect = true;
			c.filterText = "c"
			b.sortText = "000";
			completionResult.push(a, b, c);
			return completionResult
		}
	}, " ", ".");
	context.subscriptions.push(LanguageServerProvider);
}

export function deactivate() {}

If you trigger completion, vscode would always choose b as the preselected item:

I think it's definitely a bug

Yes - but its a different issue, right? How about filing a new issue

Okay, I'll open another issue about that. Thanks for your patience.
Let's concentrate on what's discussed in this issue - do you have any idea about why vscode prefers the last item with preselect=true, rather than the first completion item which has preselect=true and best sortText?

Yes - but its a different issue, right? How about filing a new issue

This strange behavior is caused by that bug: write is the first item having preselect=true, while flush(); is the second. I'll close this one and move to #98102


Step 2 reward model finetuning: how is the loss computed?

Hi there,
I notice that in step 2, the reported scores (i.e. chosen_mean_scores and reject_mean_scores) are the same as the description:

... either the end token of the sequence or the first padding token ...

But in the loss computation, the implementation count on the mean log_sigmoid score among all divergence tokens, not the last ones. Is this an intended feature? In Anthropic's paper "A General Language Assistant as a Laboratory for Alignment", they only use the last token to compute reward, which seems like a more standard approach.

This mean() is batch-wise, not token-wise


Workspace symbol provider

https://code.visualstudio.com/docs/editor/editingevolved#_open-symbol-by-name
The api exists in vscode but not monaco https://github.com/Microsoft/vscode/blob/478365bce508cc391e4cfc5c9e1eeee7c87c39c9/src/vs/vscode.d.ts#L2034
We have all the data to implement this.

We can do this the same way we do for searching for filenames. I would restrict the symbols to global class/object/trait kinds.

Here's a quick mock-up for creating an "omnibar" to search/complete file and symbol names.

input#omnibar {
    background-color: rgba(255,255,255,0.1);
    border: none;
    position: absolute;
    top: 10px;
    left: 59px;
    color: inherit;
    font-size: inherit;
    height: 36px;
    padding-left: 10px;
    width: 79%;
}

If I can get that to work (or find a library that allows to easily create a search box with pluggable completion) we should be able to implement this.

@jonas have you tried to see if we can access the same APIs as QuickOutlineAction for the document symbol provider? https://github.com/Microsoft/vscode/blob/d5b94eb3a7f1fe165590bbd0e685516400050a8f/src/vs/editor/standalone/browser/quickOpen/quickOutline.ts#L115-L151

When looking at switching to the Monaco Webpack plugin (#106) I noticed that it uses the JS sources directly, so it might be possible to access some of that, however, since it is not exposed via the Monaco API I don't know if it is possible.


Feature Request: Thresholding

Are there any plans to add thresholding to this library?
I'm completely new to this field, but would be interested in helping out if we can discuss what the API would look like. Any thoughts?

There are no plans, but thresholding can be done relatively easy using the ColorFunc filter. See if it fits your use-case.
For example:
g := gift.New(
	gift.ColorFunc(func(r, g, b, a float32) (rr, gg, bb, aa float32) {
		y := 0.299*r + 0.587*g + 0.114*b
		if y > 0.5 {
			return 1, 1, 1, a
		}
		return 0, 0, 0, a
	}),
)

Or for the red channel only:
g := gift.New(
	gift.ColorFunc(func(r, g, b, a float32) (rr, gg, bb, aa float32) {
		if r > 0.5 {
			return 1, g, b, a
		}
		return 0, g, b, a
	}),
)

As for adding this feature to gift, we could provide a user-friendly function, e.g.:
func Threshold(percentage float32) Filter

So it can be used this way:
g := gift.New(Threshold(50))

Not sure about incorporating more options (channel, black- and white-thresholding).

Implemented: https://github.com/disintegration/gift/commit/be798eb6d9ae04252e124a4a658dbedcae961797


Add GUI to Home Assistant

Hi. Good feature will be add GUI to Home Assistant to setup integration.

I agree it's nice to have but you normally configure it just once and forget about it.
Unless you have some other use-cases where the GUI could be really a game changer?

Yes you are right, but more integration setup once and forgot, and many integration get GUI in Home Assistant.

Home Assistant config flows seem to be quite limited. It only supports forms with flat list of entries. No multiple fields in a row. No fancy features. And satel has lots of inputs/outputs which makes it a bit tricky.
One solution would be to split in multiple very long forms like these below. Non-empty names would enable items. Items with empty names would be disabled. Other attributes (like icons) would have to be modified via normal entity customizations.

Main settings

host
port

Partitions names

partition 1
partition 2
....
partition 31
partition 32

Inputs names

input 1
input 2
....
input 255
input 256

Outputs names

output 1
output 2
...
output 255
output 256

Switchable outputs names

output 1
output 2
...
output 255
output 256

Temperature sensors names

sensor 1 name
sensor 2 name
...
sensor 255
sensor 256

Any feedbacks or suggestions to improve this idea are welcome.


Command error

Everything was working fine with the paperclip-ffmpeg version 1.0.1 but when I switch to version paperclip-ffmpeg 1.2.0 OR 'paperclip-av-transcoder', "0.6.2" I get this stack:
Command :: PATH=/usr/local/bin/ffmpeg:$PATH file -b --mime '/var/folders/43/t8s11k6d145c4wtwfpnbxh640000gn/T/6c84cbd30cf9350a990bad2bcc1bec5f20150205-9953-enmm0q.MOV'
[AV] Running command: if command -v avprobe 2>/dev/null; then echo "true"; else echo "false"; fi
sh: -c: line 0: syntax error near unexpected token `then'
sh: -c: line 0: `PATH=/usr/local/bin/ffmpeg:$PATH if command -v avprobe 2>/dev/null; then echo "true"; else echo "false"; fi'
Could not log "process_action.action_controller" event. Encoding::UndefinedConversionError: "\xEA" from ASCII-8BIT to UTF-8 ["...'"]

Av::CommandError - error while running command if command -v avprobe 2>/dev/null; then echo "true"; else echo "false"; fi: Command 'PATH=/usr/local/bin/ffmpeg:$PATH if command -v avprobe 2>/dev/null; then echo "true"; else echo "false"; fi' returned 2. Expected 0
Here is the command output:

:
  av (0.8.0) lib/av.rb:32:in `rescue in run'
  av (0.8.0) lib/av.rb:29:in `run'
  av (0.8.0) lib/av/cli.rb:24:in `detect_command'
  av (0.8.0) lib/av/cli.rb:7:in `initialize'
  av (0.8.0) lib/av.rb:24:in `cli'
  paperclip-av-transcoder (0.6.2) lib/paperclip/paperclip_processors/transcoder.rb:14:in `initialize'
  paperclip (4.2.1) lib/paperclip/processor.rb:33:in `make'

```
If i try to execute the command in my terminal:

$ PATH=/usr/local/bin/ffmpeg:$PATH if command -v avprobe 2>/dev/null; then echo "true"; else echo "false"; fi
-bash: syntax error near unexpected token `then'

Forcing the cocaine version to 0.5.3 solved this issue  but I do not think this should be the final solution.
I reported the bug to the cocaine gem.
Maybe it the the command send to cocaine by paperclip-av-transcoder that needs to be changed to work on mac?

I think upgrading cocaine to 0.5.3 is not a bad idea at all.

Please confirm the fix for av gem master branch.

Hey owahab,
I am trying to use paperclip-av-transcoder and it is working, except it is not generating the correct size for my thumbnails. I believe I have spotted the issue on line 37 of paperclip/paperclip_processors/transcoder.rb. There is a typo in the geometry variable:
@convert_options[:output][:s] = format_geometry(@geometry) if @gemotry.present?
The conversion works if I set convert_options directly.
Thanks,
Chris

Actually setting covert_options does not work either.

@cdub32k this was fixed in #11

Ok thanks, I saw there was already an issue for this after I posted my comments.
However I am still seeing the "gemotry" typo when I install the gem directly from github using
gem 'paperclip-av-transcoder', github: 'ruby-av/paperclip-av-transcoder'
If I modify the gem code to fix this typo, I can resize my thumbnails.

Just released 0.6.3 with this fix. Please test and update.


Add a Vote tracking event for the frontend

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.798%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
434

Relevant Lines:
491

💛  - Coveralls


[#131] Annotate reserved vocabularies when importing into workspace

This PR tackles with the use case when the user tries to import a vocabulary that is already being used in another workspace.
What changed in the Import vocabulary dialog:

vocabularies that are already used in another workspace have a warning icon attached
if such vocabulary is clicked, the user sees in which workspace is the vocabulary edited and there is a button to go to that workspace

We still need to change the dialog so that it is not possible to import vocabularies for read only, but AFAIK that cannot be done just yet because of other technical dependencies.
Feedback welcome!
Resolves #131.

To increase usability we should be able to quickly point the user to the 'last editor' of the workspace - either putting it in the message, or having the label of the conflicting workspace clickable.

There is the big "Go to workspace" button that you can click to do just that - it opens the blocking workspace with the vocabulary that the user wants to edit.  But maybe it would be better to have the info message / workspace name clickable instead.

To increase usability we should be able to quickly point the user to the 'last editor' of the workspace - either putting it in the message, or having the label of the conflicting workspace clickable.

There is the big "Go to workspace" button that you can click to do just that - it opens the blocking workspace with the vocabulary that the user wants to edit. But maybe it would be better to have the info message / workspace name clickable instead.

Ah, I see, I missed it ... :-)
Anyway, a clickable link would be better IMO (The less on the screen the better).

Anyway, a clickable link would be better IMO (The less on the screen the better).

Done! Thanks for the feedback.


NE-1802: Bump Golang, k8s.io, OpenShift API, and controller-runtime

Bump Golang to 1.22:

Update go.mod
Update Dockerfiles
Add CGO_ENABLED=1 to go test -race (https://github.com/golang/go/issues/51235).

Bump k8s.io/* modules to 0.30.3 and OpenShift API to the latest.
Bump Controller runtime bumped to 0.18.5:

Controller's Watch function now has a single generic source parameter
(https://github.com/kubernetes-sigs/controller-runtime/pull/2783).
Manager's CertDir option removed, now using the dedicated webhook server option
(https://github.com/kubernetes-sigs/controller-runtime/pull/2422).
Cache's Namespaces option replaced by DefaultNamespaces
(https://github.com/kubernetes-sigs/controller-runtime/pull/2421).

Bump kustomize to v5 to fix a conflict caused by k8s.io bumps:

kyaml unable to use the bumped github.com/google/gnostic-models/openapiv2 package.

Regenerate CRD and bundle manifests:

ExternalDNS API uses metav1.LabelSelector for the label filtering.
It was updated with +listType=atomic marker which resulted in
the addition of x-kubernetes-list-type: atomic to CRD.

 Bumped golangci-lint to the latest version.
kustomize was having a conflict with the k8s.io bumps.  I get v0.31.0 K8S packages now, logr v1.4.1, and I also get this error:
go: github.com/openshift/external-dns-operator/tools imports
	sigs.k8s.io/kustomize/kustomize/v4 imports
	sigs.k8s.io/kustomize/kustomize/v4/commands imports
	sigs.k8s.io/kustomize/kustomize/v4/commands/create imports
	sigs.k8s.io/kustomize/api/loader: module sigs.k8s.io/kustomize/api@latest found (v0.17.3), but does not contain package sigs.k8s.io/kustomize/api/loader

Sorry, I am one of those people that like to reproduce the bump as a sanity check :smile: I think you need to pin your versions.

@gcs278 : Pinned the go get commands to concrete versions. Indeed, 1.31 Kube was released at the same time as I posted the PR.

e2e TestExternalDNSRecordLifecycle is failing.   I saw in Loki that the GCP CCM took 5 minutes to provision the LB. That's quite long, probably an anomaly with the GCP API being slow. It's a flake to keep an eye on.

@gcs278 : 3 minutes may be too short indeed. Some time ago, I decreased it from 15 minutes to reduce the elapsed time needed for a failed run. I'll try to do the happy medium and will increase it to 7 minutes.

Increased the golangci-lint timeout to 10m.

/retest

Looks like the PR is getting to its finale, I squashed the module bump and vendor commits into a single one as discussed in this thread.

/retest

I had one nit, but it's not really that important.
/lgtm

Tested the pr using cluster bot, basic functionality is working. Hence approving from QE side.
/label qe-approved

/jira refresh

/approve

/label px-approved
No TE is needed for this feature, only release notes.

/label docs-approved

/label px-approved
No TE is needed for this feature, only release notes.

No release note for this specific change as we do not make release notes for bumping kubernetes dependencies.

All Azure tests failed to get DNS records, not much can be found in Loki. Let's see whether it's a reproducible issue.
/retest

Rebump the operand image after the RHEL9 migration PR was merged.

/lgtm


Revert "Added logic to extract both baseName and qualifiedName from marked source extractor." [phab:D2088]

Created by craigbarber at 2017-12-08 00:50:32:
This reverts commit 6a782c9fbc99d2c1e23cf3a982d92cdfe92b6d43.
After an offline discussion with zarko we came to the realization that the baseName logic here is not correct. Will re-submit this change with the corrected logic.

zarko accepted this revision at 2017-12-08 00:55:30

craigbarber closed via commit 460d81ddb9530ece9a5a28c19598d64995506073 at 2017-12-08 00:58:20


Packaging fix: Needed to check for presence of namespace

Critical Changes
Changes
Issues Closed

@ceiroa here is a fix to address the beta upload failures.


I can't solve this problem

Describe your bug here.
I'm using psych engine 0.6.3
Command Prompt/Terminal logs (if existing)
source/PlayState.hx:75: characters 8-22 : Type not found : vlc.MP4Handler
source/PlayState.hx:1624: characters 13-23 : Type not found : MP4Handler

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
yeah

ok

didn't solve

Use hxCodex 2.6.1 and change the import from vlc.MP4Handler; to hxcodec.VideoHandler as MP4Handler;


Add calc-size css funcionality

Hi,
if you could add to caniuse this feature: https://drafts.csswg.org/css-values-5/#calc-size
Thanks :)

The design of this feature is still being debated fwiw: https://github.com/w3ctag/design-reviews/issues/955

It's already shipping in Chrome 129. 🤣🤣
https://chromestatus.com/feature/5196713071738880

I'm aware, there's still recent comments from Google on that issue however.

Available via BCD: https://caniuse.com/mdn-css_types_calc-size


[Feature Request] Some Components Feature Suggestions

Is your feature request related to a problem? Please describe.
Our project is preparing to migrate to nextUI, but these components are not included here. Therefore, I have compiled some common components, hoping to extend them to the nextUI component library for more people to choose and use. Here are some feature suggestions and screenshots:
Describe the solution you'd like

DatePicker and TimePicker. such as:

Reference link: https://ant.design/components/date-picker
Mentions,When you need to mention someone or something. such as:

Reference link: https://ant.design/components/mentions
Transfer,It is a select control essentially which can be use for selecting multiple items. such as:

Reference link: https://ant.design/components/transfer
Layout, Expand layout usage scenarios. such as:

Reference link: https://ant.design/components/layout
Timeline, such as:

Drawer, such as:

Tree, such as:

Upload, Image or File Upload feats. such as:

Describe alternatives you've considered
I'm sorry for raising so many component functional requirements, but I was mainly conquered by the beauty of nextUI, so I hope it becomes more perfect and convenient. Finally, I suggest that the nextUI team add a roadmap so that everyone can see the development path of nextUI. Thank you to the nextUI team!
Screenshots or Videos
No response

I don't think some of these components should belong in the core library. Like timeline, for example

toasts should be implemented

Awesome!
I think drawer should be implemented. Reference https://ui.shadcn.com/docs/components/drawer
ShadCn ui is also a great component library based on radix-ui

Hey guys, is there any documentation where I can get specifications for developing components? I currently have time to contribute something.
At present, I have completed the development of the Drawer component locally.


What is times in the Fibonacci problem?

I have written a function that gets in the index and returns the nth fibonacci number, but I've not used the times parameter, and my code is failing.
What is times?
Some sample output:
[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13].forEach((index) => {
  console.log(`fibonacci(${index}) => ${fibonacci(index)}`);
});
///
fibonacci(1) => 1
fibonacci(2) => 1
fibonacci(3) => 2
fibonacci(4) => 3
fibonacci(5) => 5
fibonacci(6) => 8
fibonacci(7) => 13
fibonacci(8) => 21
fibonacci(9) => 34
fibonacci(10) => 55
fibonacci(11) => 89
fibonacci(12) => 144

Times is the amount of times you have to run the sequence, for example:
times = 10
[1, 1, 2, 3, 5, 8, 13, 21], and so on until the amount of times we've done it reaches 10.
Im definitely going to document this step more once I'll be free, it seems it's too confusing

Oh, that makes sense, thanks! So is index the starting index? Should fibonacci(3, 2) be [2, 3]?

While checking your function, index is always 2