rollup:options in hooks throw error when options.plugins = [ options.plugins ]

Environment
node: v20.9.0
pnpm: 8.15.4
"typescript": "^5.4.2",
Reproduction
github repo
pnpm i
pnpm build
It will throw error.
Describe the bug
See build.config.ts in the mini-repo above.
The option of defineBuildConfig will throw error:
export default defineBuildConfig({
  // ...
  hooks: {
    'rollup:options': (_, options) => {
      options.plugins = [
        options.plugins,
      ]
    },
  },
})

Cannot read properties of undefined (reading '_options')

// Locate this line of code
shebangPlugin2._options.preserve = false;

But Vitejs use code like it, refer to Vite Repo
And the type also looks it should work:
type InputPluginOption = MaybePromise<Plugin | NullValue | false | InputPluginOption[]>

Additional context
No response
Logs
ERROR  Error building D:/Code/test/unbuildErrTest: TypeError: Cannot read properties of undefined (reading '_options')                  23:25:55

 ERROR  Cannot read properties of undefined (reading '_options')                                                                         23:25:55

  at rollupBuild (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/unbuild@2.0.0_typescript@5.4.2/node_modules/unbuild/dist/index.mjs:696:20)
  at async _build (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/unbuild@2.0.0_typescript@5.4.2/node_modules/unbuild/dist/index.mjs:1087:3)
  at async build (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/unbuild@2.0.0_typescript@5.4.2/node_modules/unbuild/dist/index.mjs:945:5)
  at async Object.run (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/unbuild@2.0.0_typescript@5.4.2/node_modules/unbuild/dist/cli.mjs:63:5)
  at async runCommand (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/citty@0.1.6/node_modules/citty/dist/index.mjs:316:16)
  at async runMain (/D:/Code/test/unbuildErrTest/node_modules/.pnpm/citty@0.1.6/node_modules/citty/dist/index.mjs:445:7)

options.plugins = [
  ...options.plugins,
]

Can work but it will throw a type error, because options.plugins could be undefined. However, it seems it could not be undefined refered.
So I have to use it like:
options.plugins = [
  ...(options.plugins as any[] ),
  OtherPlugin()
]

I read the code and found out the issues happened in HERE.
Raw code:
// source code refer to above link.

rollupOptions.plugins = [
  rollupOptions.plugins,
  dts(ctx.options.rollup.dts),
  removeShebangPlugin(),
];

was transformed to
// dist/index.mjs

rollupOptions.plugins = rollupOptions.plugins || [];
// Panic here!
const shebangPlugin2 = rollupOptions.plugins.find(
  (p) => p && p.name === "unbuild-shebang"
);
shebangPlugin2._options.preserve = false;
rollupOptions.plugins.push(dts(ctx.options.rollup.dts));

rollupOptions.plugins can be nested, but it just use find here will cause issues. So shebangPlugin2 will be undefined and shebangPlugin2._options.preserve = false try to get a attr of undefined will throw error.

I just found out that the code in this main branch is not the source code for v2.0.0 (I'm even confused about how it got compiled like this lol). I think maybe this issue won't exist in the new version, so I will test it.

To fix the issue temporarily, change code here:  (unbuild/dist/index.mjs:692)
https://github.com/unjs/unbuild/blob/ff3eaa864b837060d93cffadb30e38e11db761cc/src/builder/rollup.ts#L181
to:
rollupOptions.plugins = rollupOptions.plugins?.flat(Infinity) || []

Fixed in v3.0.0-rc.1.


Changed licence from "ISC" to "MIT". Issue #198

Changed licence from "ISC" to "MIT". Issue #198

Hi @jonathan-hamilton

There should only be a change in a single file, and there is no need to upload anything.
Please follow the instructions in the original task #198

Thanks for your patience. I'm following the 198 instructions EXACTLY. Here's a screenshot of an error I get in GitBash.
I get the error when I try and clone a copy on my machine. In the spirit of trying, I modify the code so changing the "license" to MIT. When I try to use "git push -u origin master" I get the second error in the image I provided. What's wrong? Please advise.
On Sep 13, 2018, at 01:12 AM, Tal Ater<EMAIL_ADDRESS>wrote:
Hi @jonathan-hamilton
There should only be a change in a single file, and there is no need to upload anything.
Please follow the instructions in the original task #198
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Documentation request: add examples for carrying out "ncecat" in xarray

In climate science, a very common task involves concatenating NetCDF files with identical variables, dimensions, and coordinates along a brand new "ensemble member" or "record" dimension. With the NetCDF Operators, this is accomplished using ncecat.
MCVE Code Sample
Currently, it seems the correct way to do this in xarray is with xarray.combine_nested as follows:
import xarray as xr
files = ['member1.nc', 'member2.nc', ...]
ds = xr.open_mfdataset(
    files,
    combine='nested',
    concat_dim='record',
)

Problem Description
While this works, there does not seem to be any mention of this use case in the combine_nested or open_mfdataset docs... and using combine='nested' to concatenate along a brand new dimension feels quite unintuitive to me.
It would be nice if you guys could add examples to combine_nested and/or open_mfdataset with this special usage and/or mention the possibility of creating brand new dimensions with concat_dim. For example:
In [1]: import xarray as xr
   ...: datasets = [
   ...:     xr.Dataset({'temp': (('x', 'y'), np.random.rand(10, 20))})
   ...:     for i in range(3)
   ...: ]
   ...: xr.combine_nested(datasets, concat_dim='record')
Out[1]:
<xarray.Dataset>
Dimensions:  (record: 3, x: 10, y: 20)
Dimensions without coordinates: record, x, y
Data variables:
    temp     (record, x, y) float64 0.32 0.4897 0.2659 ... 0.3485 0.0251 0.399

Output of xr.show_versions()
n/a

Thanks @lukelbd for pointing this, this is certainly a common operation, and there should be a clear example in the docs.
The method you suggest (open_mfdataset(files, combine='nested', concat_dim='record')) is the intended way to do it.
We have a section in the docs on combining data, but it seems to go straight to the multi-dimensional "nested" case before showing the simpler case you're asking about. (FWIW the "nested" name was motivated by these more complex use cases, but I agree it's not the most intuitive name when in 1D.) That page also doesn't go into much detail about how everything combine_nested and combine_by_coords can do open_mfdataset can also do.
I suggest there should be another section "combining data from files" at the end of that page, which has a few examples but on files instead of dataset objects. Then we link to that from the open_mfdataset docstring? Do you think that would be sufficiently clear/accessible?
It would also be nice if at some point one of the examples demonstrated this.
@lukelbd would you be interested in submitting a PR for this?

@TomNicholas Sounds good to me. Sure I'd be happy to contribute -- will submit a PR sometime in the next couple weeks or so.

@lukelbd great! Tag me when you do and I'll review :)


new release process / CI actions / checks

We want to move to a more formal release process characterized by the following points:

all PRs merge into main
PRs don't get merged until they are finney-ready
permissioned GitHub Action / CI checkboxes will exist to check off that the PR has been tested on devnet and testnet respectively (might use labels)
any issues uncovered during testing can then be discussed and tracked on the PR, reducing issue/PR bloat and making it easy to see the full life-cycle of a feature from development to deployment on finney
we will cut releases off of main using the github releases feature, so every once in a while we cut a new release and deploy everything new in main to finney, and then that gets a semver version number + tag

AC:

[x] CI check system for devnet / testnet stages (possibly using labels)
[ ] set up releases
[ ] PRs default to main
[ ] update docs / instructions / PR templates
[ ] test that non-team-members can't fake the checklist items

PRs don't get merged until they are finney-ready
It needs a formal definition, i.e. what tests need to pass. E.g. does it imply testing on a full live data in Finney?

we will cut releases off of main using the github releases feature, so every once in a while we cut a new release and deploy everything new in main to finney, and then that gets a semver version number + tag
What if the main branch goes forward from the commit that we want to release? How do we update version in the release? How do we apply hot fixes if we don't want further commits (already present in main branch) to be included in this release? Does it mean merging of PRs is blocked until the release is finished? What happens to the on-going feature branches if they need to merge upstream commits that are not included in this release during the release process?

It needs a formal definition, i.e. what tests need to pass. E.g. does it imply testing on a full live data in Finney?

So right now this is defined based on the label rules which means it has to have the devnet-pass and testnet-pass labels which means:

has been deployed to devnet successfully
has been manually tested on devnet
has been deployed to testnet successfully
has been manually tested on testnet

I can also add other required labels if necessary

What if the main branch goes forward from the commit that we want to release?

This will regularly happen, the tip of main will normally be ahead of our current release which will usually be a few commits back in main. Releases will be tagged and uploaded as a GH release using an action automation

How do we update version in the release?

I'll be doing this manually with each release. One thing that might help this process is if we add labels or something to indicate on PRs what level of semver change they necessitate, so I'll definitely add something about this to the PR templates and/or docs

How do we apply hot fixes if we don't want further commits (already present in main branch) to be included in this release?

When you cut a release it can be based on any tag you like, so that's how we would do that. If there is a hotfix we merge it into main and cut a release. Everything already in main that hasn't been deployed to finney will already be, by definition, ready to go on finney, so that will be fine.

related Q: how do we feel about semver with respect to this stuff -- what sorts of things constitute a patch, minor, and major version change when it comes to subtensor?

Thanks for details, @sam0x17 ! I have just one concern that this pipeline may become a bottleneck if we have too many pending PRs waiting for approval. If features depend on each other, it will be tempting to cross-merge without waiting until the PR is accepted in the main branch. Would be great if we have some rules about cross-merging to prevent mess.

Thanks for details, @sam0x17 ! I have just one concern that this pipeline may become a bottleneck if we have too many pending PRs waiting for approval. If features depend on each other, it will be tempting to cross-merge without waiting until the PR is accepted in the main branch. Would be great if we have some rules about cross-merging to prevent mess.

I agree this is a potential issue, but so is the churn created by everyone being rebased off of a development branch that then needs changes because not everything is checked.
My hope is that we can do more frequent releases and that that will be the answer to this concern


Fix dev environment deployment

During the reprovisioning of a a development box I encountered some
quircks that needed to be fixed to be able to update my dev box.

the webauthn component was missing in the environment.conf
composer 2.0 broke SSP installation due to invalid composer.json
bootstrap was removed from GW but was still being installed
Keyserver master uses older symfony (app/console vs bin/console)

@phavekes I think it will be better to revert my keyserver changes and merge the changes from dev back into master in the Keyserver repository. Is that fine with you?

@phavekes I've reverted keyserver app/console path cahnges and merged the keyserver changes back in master.


runtime: Suddenly started getting error roundupsize redeclared in this block

Go version
go version go1.22.0 linux/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/vscode/.cache/go-build'
GOENV='/home/vscode/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build100524131=/tmp/go-build -gno-record-gcc-switches'

What did you do?
After rebooting my ubuntu machine and loaded my MS Devcontainers.  I can't compile my api project anymore.
I haven't change any code so I'm not sure I've introduced any errors.
Things I've tried in an attempt to fix this error:

Uninstall go version 1.21 and upgraded 1.22
Rebuild the Devcontainer
Researched online with no success.

I have other Devcontainers set up the same way and they build as usual but this api is using some additional crypto packages.
go 1.22
require github.com/gorilla/mux v1.8.0
require (
github.com/go-redis/redis v6.15.9+incompatible
github.com/google/uuid v1.3.0
github.com/joho/godotenv v1.5.1
github.com/lib/pq v1.10.9
github.com/microcosm-cc/bluemonday v1.0.25
github.com/swaggo/swag v1.8.1
golang.org/x/crypto v0.14.0
)
require (
github.com/KyleBanks/depth v1.2.1 // indirect
github.com/aymerick/douceur v0.2.0 // indirect
github.com/go-openapi/jsonpointer v0.19.5 // indirect
github.com/go-openapi/jsonreference v0.20.0 // indirect
github.com/go-openapi/spec v0.20.6 // indirect
github.com/go-openapi/swag v0.19.15 // indirect
github.com/gorilla/css v1.0.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/mailru/easyjson v0.7.6 // indirect
github.com/onsi/ginkgo v1.16.5 // indirect
github.com/onsi/gomega v1.27.10 // indirect
golang.org/x/net v0.14.0 // indirect
golang.org/x/sys v0.13.0 // indirect
golang.org/x/tools v0.9.3 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
What did you see happen?
runtime
/usr/local/go/src/runtime/msize_allocheaders.go:16:6: roundupsize redeclared in this block
/usr/local/go/src/runtime/msize.go:13:6: other declaration of roundupsize
/usr/local/go/src/runtime/map.go:357:25: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/slice.go:191:41: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/slice.go:197:56: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/slice.go:210:48: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/slice.go:218:32: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/string.go:273:36: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
/usr/local/go/src/runtime/string.go:288:38: too many arguments in call to roundupsize
have (uintptr, bool)
want (uintptr)
What did you expect to see?
No errors

sounds like a corrupt installation.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

I had this problem when I built a new instance of go over a previous version/.


tascCODA to analyse compositional changes in scRNAseq between case and control (taking in account covariates as age and sex)

Hi, Good day, thank you for the nice package.
I have some questions on how to use tascCODA to regress covariants as age and sex in addressing the compositional changes between case and control in scRNAseq.
In your paper you state:
"More generally, however, tascCODA enables to determine how host phenotype, such as disease status, host covariates such as age, gender, or an individual’s demographics, or environmental factors jointly influence the compositional counts"
Shall the formula be written like this:
tree_mod= ana.CompositionalAnalysisTree(
datax.copy(),
reference_cell_type="automatic",
formula="PATH+age+sex",
reg="scaled_3",
pen_args={"phi": 0, "lambda_1": 1.7}
)

"PATH" is the metadata with "Case" vs "Control" labels.
Would making the formula "PATH+age+sex" regress out age/sex in the case vs control comparison?
I also wanted to ask what the following arguments mean?
"reg="scaled_3"
pen_args={"phi": 0, "lambda_1": 1.7}

Thank you very much in advance.
Best
Moheb

Hi @mohebg,
thanks for your interest in tascCODA!
The "formula" parameter determines, like in R's lm function, which covariates are considered for modeling. Currently, tascCODA performs model selection for all covariates in the formula, meaning that we look whether effects are significant for all covariate/tree node pairs. It's not possible at the moment to just adjust for a covariate without running model selection on it, although this might be possible in a future update.
Regarding the other arguments, you can ignore the reg parameter. This is only needed for switching between earlier versions of the tree-aggregated penalization scheme. The one described in the paper is "reg_3", which is also the default.
With the pen_args parameter, you can set the phi (aggregation bias) and lambda_1 (regularization strength) values, like they are described in the paper.
I hope that this answers your questions!

Yes, just add the covariate to the model. That's what I would do as well. As I said earlier, this does not "regress out" age/sex, but tascCODA will try to find significant impacts of age/sex and adjust for them accordingly. If age/sex don't have a significant impact on the composition, they also won't be adjusted for.
In that regard, it's not a standard adjustment for the covariates.

Also, please make sure that all covariates are scaled to the same range (i.e. [0-1]), as the selection of significant associations will otherwise be biased

@johannesostner , thanks alot for your reply, I appreciate.
I am not sure if I fully understand the sentence "covariates are scaled to the same range (i.e. [0-1])".
I have there levels of covariants:

pathology vs control - which is a categorical covariate
male vs female - which is a categorical covariate
age is a numeric continuous covariate

Just make sure that age is also scaled to a range between 0 and 1 (i.e. via min-max scaling like we did in the microbiome application of our paper). Otherwise the effects for age (since its range is so much bigger than for the categorical covariates, which will be encoded as 0/1) will be very small numerically and thus never selected to be significantly different from 0.


Add 520 subfield $c to description

Some 520 fields from Sierra contain a subfield $c, which notes the source of the description (eg the publisher).
We should append this to description to ensure that it's not truncated.
Example:
https://wellcomecollection.org/works/fheczbpz
https://catalogue.wellcomelibrary.org/record=b3303885~S12

I've got a transformer patch up, and I've found a list of all the affected IDs, so we can reindex just those without a full-on pipeline reindex: 520_subfield_c.txt

I've kicked off a reindex for the affected records.

This should be backfilled on existing records, e.g. the example in the original ticket now has "Provided by publisher" from 520 subfield $c.
I’m going to close this as done; if we want to tweak it later we can create new tickets.


Update (almost) all the things

For this ticket: https://trello.com/c/dck7VGe3/1152-update-insecure-dependencies
This updates all our requirements other than Selenium to the latest versions (Selenium is pinned to the last version known to work on Heroku, and the last time I checked the latest version hasn't fixed the problem).
I've been having some odd intermittent failures of the functional tests locally against this branch, so it would be good if people can pull this down and try it out (also, let's see what CI makes of it now).

There are few minor test and code changes here to get things working with these updated packages:

Latest Black formatting (looks like they don't like empty lines at the top of files nay more)
Fixtures being called directly now emit a warning (some interesting discussion about the reasoning behind this here: https://github.com/pytest-dev/pytest/issues/3950 - basically, everyone does it wrong so they are stopping people from doing it!)

Also what I think is a larger genuine bug-fix that has been masked up until now by an issue in ealier version of WTForms:

Don't pass the Page object in to the measure page form when request is a POSTed form

@samuelhwilliams @frankieroberto I have had a pretty thorough click round the review app for this as I was a bit worried about bumping so many versions at once, but everything loks good as far as I can tell.


[infra] Can't request review from docs-pt-approvers / maintainers

Originally posted by @chalin in https://github.com/open-telemetry/opentelemetry.io/issues/5035#issuecomment-2305441637

@open-telemetry/docs-maintainers - any idea why @open-telemetry/docs-pt-approvers / maintainers isn't a choice in the Reviewers request dropdown?

Reference:

https://github.com/open-telemetry/community/issues/2232#issuecomment-2305474873

Resolved. Thanks @lmolkova!


Service fabric e2e Identity tests

Running Identity e2e tests for Service Fabric

We'd like to keep this PR open till we get some more time to start working on this again.


rkt: 1.14.0 -> 1.15.0

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Too late. :smile: See faf14cbcee739b3d16f0afa56b1b8355c1288992.

Whops, this one's superfluous!


NDRS-1114: Step Information should be present on the event stream

REF: https://casperlabs.atlassian.net/browse/NDRS-1114
CHANGELOG:

Added a new ContractRuntimeAnnouncement that raises an event when a step has been committed
Added a new SSE Event that puts the committed ExecutionEffect to the event stream
Additional wire up to generate this event

Sample output attached
ndrs1114.txt

bors merge


[PowerToys Run] Does not open files from search, or containing folder correctly

Environment
Windows build number: 10.0.19041.264
PowerToys version: 0.18
PowerToy module for which you are reporting the bug (if applicable): Run

Steps to reproduce

Summon PTR with keyboard shortcut
Start typing the name of a file I want to open (e.g. "my-other-computer.vnc")
Either click the item, or use arrow keys to select the item and  to open it

Alternately, after PTR has found a file

Click the folder icon in the highlighted row

Expected behavior
File should open, or correct folder should open
Actual behavior
Nothing happens (when clicking the file), or Explorer opens to its default window, not the path containing the file (when clicking the folder icon

Does the file path contains localized strings? (Example: user shown as Benutzer)

having the same problem. When doing a search for a folder o a file, pressing enter o clicking on the file/folder with the mouse it does not take me to the file.

My file path does not contain localized strings, but I do have my OneDrive documents folder pointed at a non-standard location (Documents going to "C:\Users<username>\OneDrive\Dox" because I thought that was clever, /sigh).
My file is located at:
C:\Users<username>\OneDrive\Dox\Config\remote<my-other-computer>.vnc
And PTR generates this path instead (in the window, and by clicking the "copy" button):
C:\Users<username>\OneDrive\Documents\Config\remote<my-other-computer>.vnc

@joshtransient
German os language?

No, this is locale 1033 (en-US)

It seems to be a problem where Dox will be translated into Documents.
Maybe @ricardosantos9521 can look at this?

@joshtransient can you send me a screenshot with the file path in powertoys run?

Looks like the 0.18.1 release fixed this, closing.


0.9.3 Documentation

since we now have a dedicated technical writer, let's slowly accumulate examples and ideas for further enhancing Themis documentation for better understandability in comments.

https://simperium.com/docs/python/
these guys seem to follow similar pattern to ours, but so much simplier than we do.

Finalize remixing of documentation:

remove numbering from URLS for ease of linkage
experiment with subfolders
reconstruct sidebar into better blocks (not all subiterms need to be on sidebar, f.i. cryptosystems)
mechanically add "Read related items" into documents

mechanically add "Read related items" into documents

only this is left

after careful consideration and remembering our discussions, I think we'll refrain from this for now.


[Feature] User Registration event

Hey,
I did not find this in the framework files, nor in the docs. I think it could be very useful to add an event when a new user registers. This could for example be used to send a welcome email.
I guess it would simply be auth.register.

You can add this event in your app easily, not sure if that's something to add to the framework.
Closing this since it's not a bug report, for suggestions and feature requests please use the https://github.com/laravel/internals repo.

Okay, I will move it to internals, sorry, did not no about this.


Revert rgba4 fix

Revert d539f3425fda519d16863890b807382d4febaf68 and e1b3fe6d756817846609c37c384be45d20ca7285 until a larger fix.

I already did revert.

Ok, thanks!


Slow Hessian

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): I have written custom code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 4.4.0-47-generic #68-Ubuntu and Also macOS Sierra 10.12.3 (CPU only)
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 1
Python version: 3.6
Bazel version (if compiling from source):
CUDA/cuDNN version: cuda/8.0 and cudnn/5.1
GPU model and memory: 12GB, memory:100GB
Exact command to reproduce: tf.hessians(ys,xs)

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
The command tf.hessians(ys, xs) is used to add nodes to the graph in order to compute hessians of ys with respect to xs where both ys and xs are list of tensors. Currently computing hessian with respect to a vector is not possible. The trick is to unstack the input tensor (x) into a list of one dimensional tensors (xs) and compute hessian with respect to each of them separately then stack them together. Tensorflow gets stuck in the phase of graph construction even when the dimension of x (length of list xs) is about one hundred. In the implementation of Hessian in gradients_impl.py the second derivative is implemented as the derivative of partial derivative with respect to each member of xs. I guess the slowness of graph construction is due to this line:
_hess = [gradients(_gradient, x, **kwargs)[0] for _gradient in _gradients]
which may add several unnecessary intermediate nodes with overlapping functionality to the graph due to the for loop. Is there any way other than looping over input dimensions that efficiently constructs the graph in a reasonable time?
Source code / logs
This source code can simulate the problem:
import tensorflow as tf
import numpy as np
in_dimension = 256
x = tf.placeholder(tf.float32, shape=(1, in_dimension))
x_list = tf.unstack(x, axis=1)
xx= tf.stack(x_list, axis=1)
y = tf.pow(xx,3)
hess = tf.hessians(y, x_list)
sess = tf.Session()
print(sess.run(hess, feed_dict={x : np.random.normal(0, 1, size=(1, in_dimension))}))

@alextp, it seems like slowness is inherent with the current approach to computing Hessians of non-scalars. I don't know of anything else to do. Could eager mode help with this at all?

@amehrjou one issue is that currenttf.gradients implementation is quite slow. The runtime grows linearly with size of the graph even when size of the subgraph to differentiate or the output stays constant. https://github.com/tensorflow/tensorflow/issues/9901

@yaroslavvb Exactly. I also realized that the size of the graph becomes very large when tf.gradients is applied for the second time. For example the first tf.gradients added around 100 nodes to a graph with 80 nodes. But the second derivative surprisingly adds 1000 nodes to the graph for each dimension of the vector with respect to which derivates are computed. Is there any chance to compute Hessian diagonal in a feasible way?

Oh you want just the diagonal of Hessian? For piecewise linear neural network (ie, ReLU activations) computing diagonal can be done cheaply (ie, for square loss it's the product of corresponding activation and backprop variances). In a general network, there's no fast way (http://www.cs.utoronto.ca/~ilya/pubs/2012/CurvProp.pdf)

@yaroslavvb I want the diagonal of Hessian but specifically for a smooth network and I want it with respect to inputs not parameters. Second derivative of a piecewise linear function with respect to its input is trivially zero and just for the record Tensorflow returns None even though it must return zero.

None result in tf.gradients means there's no path between input and output in the computation graph

@yaroslavvb Yes. I replace None values with zero. Thank you for the pointer to the Curve Propagation paper too.

It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.


performance, look into performance for object EXISTS checks

performance, look into performance for object EXISTS checks
should be simple selects, but I guess  some call API functionality which makes it slower
exists called in
    lt_tadir = lcl_tadir=>read(
      iv_package            = get_package( )
      iv_ignore_subpackages = ignore_subpackages( )
      io_dot                = get_dot_abapgit( ) ).

SMIM

merged https://github.com/larshp/abapGit/pull/847


warnings hide errors

Errors should hide warnings in the error, not the other way round, like it is right now.

Fixed.


[C#] Add decompression support for Record Batches

C# Implementation does not support reading batches written in other implementations of Arrow when the compression is specified in IPC Write options.
e.g. Reading this batch from pyarrow in C# will fail:
pyarrow.ipc.RecordStreamBatchWriter(sink, schema, options=pyarrow,ipcWriteOptions(compression="lz4"))

This is to support decompression (lz4 & zstd) in the C# implementation.
Reporter: Rishabh Rana / @rishabh-rana
Related issues:

[C#] Support compression in IPC format (is duplicated by)

Note: This issue was originally created as ARROW-16921. Please see the migration documentation for further details.

I went ahead and tidied up my code and used the reflection approach suggested by @westonpace to implement a default compression provider. I've created a PR for this at #33603
I'm still not sure the reflection approach is the best way to go, it's pretty verbose and not very discoverable by users. I've included some comments in that PR about alternative approaches but maybe it's better to discuss them here rather than on the PR, so I'll copy them below:

An alternative approach that could be considered instead of reflection is to use these extra dependencies as build time dependencies but not make them dependencies of the NuGet package. I tested this out in https://github.com/adamreeve/arrow/commit/4544afde6fef12337c7b188cc497da0bc1bf829d and it seems to work reasonably well too but required bumping the version of System.Runtime.CompilerServices.Unsafe under the netstandard2.0 and netcoreapp3.1 targets. This reduces all the reflection boilerplate but seems pretty hacky as now Apache.Arrow.dll depends on these extra dlls and we rely on the dotnet runtime behaviour of not trying to load them until they're used. So I think the reflection approach is better.
Another alternative would be to move decompression support into a separate NuGet package (eg.  Apache.Arrow.Compression) that depends on Apache.Arrow and has an implementation of ICompressionProvider that users can pass in to the ArrowFileReader constructor, or maybe has a way to register itself with the Apache.Arrow package so it only needs to be configured once. That would seem cleaner to me but I'm not sure how much work it would be to set up a whole new package.

PS. It wasn't very obvious that this issue had been migrated to GitHub, maybe comments should be added to open Jira issues to explain that comments are disabled and point to the migrated issue on GitHub?

Another alternative would be to move decompression support into a separate NuGet package (eg. Apache.Arrow.Compression) that depends on Apache.Arrow and has an implementation of ICompressionProvider that users can pass in to the ArrowFileReader constructor, or maybe has a way to register itself with the Apache.Arrow package so it only needs to be configured once. That would seem cleaner to me but I'm not sure how much work it would be to set up a whole new package.

This sounds like a good approach to me.  I think having a standard package that just picks some common compression libs is going to be sufficient for 80% of use cases.

Cool okay, @lidavidm mentioned on the PR that the Java library works that way too so I'll take a look at the API used there to see if I can make the dotnet API consistent with the way the Java API works, and pare the PR back to remove the reflection based implementation for now. It might make sense to add the new package in a separate PR.

It might make sense to add the new package in a separate PR.

That seems reasonable to me.


e2e tests - Add debugger to firefox test

Fix #111
First step:

try to reproduce it manually
check how to debug cypress test and do it https://docs.cypress.io/api/events/catalog-of-events#Uncaught-Exceptions

So far, no more issue with debugger enabled...

Maybe this can help:
If you are running long runs on Docker, you need to set the ipc to host mode.
https://docs.cypress.io/guides/continuous-integration/introduction#In-Docker

Last 10 runs went well, I think we are good now but at some point, we will have to replace all of cy.wait calls by something more robust. Maybe wait for an API call return, I will to do some research about this.


Refactor Codebase; rudimentary add command

I've commented out the unit tests for now. We can fix on Thursday.

Will merge to add functionality and fix unit tests thereafter


Change oval on community of focus key/legend

The color key in the "Draft community of focus" legend is showing up as an oval and has border that doesn't match the legend color.
https://screeningtool.geoplatform.gov/en/cejst#3/32.47/-86.5

[ ] Make the color key appear as a circle
[ ] Remove the border color

Done:

[ ] Color key appears as a circle with no border

Looks good to me!

Looks good. @vim-usds I'll take a look at it again after it's on screeningtool.geoplatform.gov.

Thank you! Pushing to our main site now

@vim-usds checked screeningtool.geoplatform.gov and it looks the same. could it be a caching issue on my part or some other issue?

cool beans! thanks!
On Wed, Sep 22, 2021 at 12:45 PM Vim @.***> wrote:

@glennettec https://github.com/glennettec Thanks for checking this. I
waiting for a PR review on this. Just made the request on the main channel.
Will update when it's on our main site.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/usds/justice40-tool/issues/717#issuecomment-925101781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALRUXGYBF4IL4RCNMZMOCNLUDIBZRANCNFSM5EOZ4XWQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Glennette Clark
Design Researcher
U.S. Digital Service @ DHS
202-689-4817
@.***


[Bug] Encountered core dump issue when quantifying the model

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.

Describe the bug
在量化internlm2-chat-20B的时候遇到core dumped的情况
Reproduction
lmdeploy lite auto_awq internlm/internlm2-chat-20b --calib-dataset 'ptb'   --calib-samples 128   --calib-seqlen 1024   --w-bits 4   --w-group-size 128   --work-dir ~/internlm2-20b-chat-W4A16

Environment
sys.platform: linux
Python: 3.10.11 (main, May 16 2023, 00:28:57) [GCC 11.2.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0: NVIDIA GeForce RTX 3090
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 11.8, V11.8.89
GCC: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
PyTorch: 2.2.2+cu118
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 11.8
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.7
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.8, CUDNN_VERSION=8.7.0, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,

TorchVision: 0.17.2+cu118
LMDeploy: 0.4.2+
transformers: 4.30.2
gradio: 3.41.2
fastapi: 0.111.0
pydantic: 2.7.2
triton: 2.2.0
(sd) linjl@bme-serv

Error traceback
(sd) linjl@bme-server:~$ lmdeploy lite auto_awq internlm/internlm2-chat-20b --calib-dataset 'ptb'   --calib-samples 128   --calib-seqlen 1024   --w-bits 4   --w-group-size 128   --work-dir ~/internlm2-20b-chat-W4A16
can't find model from local_path internlm/internlm2-chat-20b, try to download from remote
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
Loading checkpoint shards:  19%|█████████████████████████████▋                                                                                | 4/21 [00:01<00:05,  2.96it/s]Bus error (core dumped)

Bus error (core dumped)

This is probably not LMDeploy's issue.
Can you perform the inference with transformers?

Thank you, I tried using transformer but couldn't load it. It's not an issue with lmdeploy. I'll try downloading this model again or changing the model
>>> model = AutoModelForCausalLM.from_pretrained("internlm/internlm2-chat-20b", device_map="cpu")
The repository for internlm/internlm2-chat-20b contains custom code which must be executed to correctly load the model. You can inspect the repository content at https://hf.co/internlm/internlm2-chat-20b.
You can avoid this prompt in future by passing the argument `trust_remote_code=True`.

Do you wish to run the custom code? [y/N] y
The repository for internlm/internlm2-chat-20b contains custom code which must be executed to correctly load the model. You can inspect the repository content at https://hf.co/internlm/internlm2-chat-20b.
You can avoid this prompt in future by passing the argument `trust_remote_code=True`.

Do you wish to run the custom code? [y/N] y
/home/linjl/anaconda3/lib/python3.10/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
  warnings.warn(
Loading checkpoint shards:  19%|█████████████████████████████▋                                                                                | 4/21 [00:01<00:06,  2.48it/s]Bus error (core dumped)


fix: simplify Html component

What

Enable jsx runtime
Simplify logic in <Html> (remove babel generated code + move React root creation inside effect)

Everything seems to work the exact same way in the example app, not sure if there are more things to test

Awesome, thank you!
Also, the build demo was breaking because it needed React in the imports. Not sure how babel handles that 😄

Update:
Vite actually needed @vitejs/plugin-react in order to work properly. So that you very much for jsx runtime 👍

Alright, yeah with the jsx runtime you shouldn't need to import React anymore


Miscellaneous in GUI and translation

1. A short field for the text, as you can see there is a lot of space there
2. Not translated

Regarding point 1, hang up. It was a jamb in translation.

Thanks! I just fixed that.
An update will be available in a few hours.


fix return empty if there is no commit implemented

Proposed changes
Return empty set when there is no commit implemented, instead of throwing error:
HoodieException("No instants to incrementally pull")

run buildall


[CI][Packaging] dev/release/utils-create-release-tarball.sh should not include the release candidate number in the name of the tarball's top-level directory.

Describe the bug, including details regarding any error messages, version, and platform.
dev/release/util-create-release-tarball.sh should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See https://github.com/apache/arrow/pull/43188#issuecomment-2215002552.
Component(s)
Continuous Integration, Packaging, Release

Issue resolved by pull request 43200
https://github.com/apache/arrow/pull/43200


selecting search coords by touching map

Search by coords would be a much better live-map replacement if you could search from coords by pointing in a map.
Rather than entering coords by hand

A click on map where you could select search for nearby caches?
If anyone can do it in release branch I can put it to Market.

Duplicate of #745.

Implementation-wise it shouldn't be hard. What I am thinking about is if we want to go that route and if it would block other useful map interactions the future (compass to point, create waypoint here and such things come to mind).
From the perspective of @Bananeweizen 's suggestion it seems useful even if we get back a live map.
I still have hopes for the live map in one way or the other and I would not like to put too much effort into intermediate solutions.
So I will meditate a little bit about it.

Since the functionality I suggested would only be meaningful in the
context of "search by coordinate", I don't see how it could interfere
with other uses of "point-at-map".
Another way to do it might be to have a menu item when looking at the
"live" map, "search around center of currently displayed map",  which
would be just as useful and maybe even more intuitive.
And which I would probably prefer to the somewhat confusing "live map"
functionality.
What would need to be thought thru would be how to deal with storing the
caches found: selecting a list AFTER having searched and pruned would
seem better than "save to whatever list is active".
Also what to do about caches already stored on the device.
On 2012-02-18 16:04, rsudev wrote:

Implementation-wise it shouldn't be hard. What I am thinking about is if we want to go that route and if it would block other useful map interactions the future (compass to point, create waypoint here and such things come to mind).

From the perspective of @Bananeweizen 's suggestion it seems useful even if we get back a live map.
I still have hopes for the live map in one way or the other and I would not like to put too much effort into intermediate solutions.
So I will meditate a little bit about it.

Reply to this email directly or view it on GitHub:
https://github.com/cgeo/c-geo-opensource/issues/1141#issuecomment-4034618

Selecting a point on the map could, as I said, be put to many uses, but there a popup menu could serve as a selection tool and confirmation possibility even if we have only on option to start with.
So perhaps a 'Caches around here' menu on long press if the map is not 'live'?
Regarding the other functionality - this is somewhat available already
You can start selecting and then you have the option to store selected. And it is not an arbitrary 'active' list but always the first 'standard' list.
Regarding the 'confusing live-map functionality': I would be interested to hear what you find confusing/dislike there (as it was before the geocaching.com change.

Re live map: it is fickle, since it is so far from fast, and with google maps being slow in itself at times...
I quite often just give up. Also, I would like to have a "just a map" mode, not showing any stored caches either.
As a starting point for searching from map positions.
I'm not sure what you're saying about saving to a list.
I'd really love some way of saving a pruned search result to a newly created offline list, like you can do in the groundspeak app.
I'm not too pleased with their app, but it does do one or two things more intuitively.
And I often realise I want to save a list after having searched idly at random.
Skickat från min Android-telefon med K-9 E-post. Ursäkta min fåordighet.
rsudev<EMAIL_ADDRESS>skrev:
Selecting a point on the map could, as I said, be put to many uses, but there a popup menu could serve as a selection tool and confirmation possibility even if we have only on option to start with.
So perhaps a 'Caches around here' menu on long press if the map is not 'live'?
Regarding the other functionality - this is somewhat available already
You can start selecting and then you have the option to store selected. And it is not an arbitrary 'active' list but always the first 'standard' list.
Regarding the 'confusing live-map functionality': I would be interested to hear what you find confusing/dislike there (as it was before the geocaching.com change.

Reply to this email directly or view it on GitHub:
https://github.com/cgeo/c-geo-opensource/issues/1141#issuecomment-4037728

@HansJA As I said, you can save a selection of your current search result list already with current functionality, albeit not to a new or selected list, only to the standard one.
While discussing and thinking about this several ideas come to mind for improving the functionality and usability of the (live) map. I'll try to list them here as a starting point to gather feedback and decide directions.

As @Bananeweizen already noted, 'Caches around here' would be a good thing on non-live maps on long press somewhere on the map
Perhaps it should be possible to turn maps on stored lists/caches into live mode (at the same time selecting the respective list as target if a cache is then stored from the map)
To enhance the usability I think a status-icon (live on/off) in a corner of the map would be good, at the same time acting as a toggle for this function
As I have seen the 'current direction' up instead of north-up functionality of locus I think we could give this a spin as well.

Comments?

The only real concern I could voice would be the lack of list selection/creation when one decides to save a set viewed on a map. A list pruning function on the map view would also be nice.
But, I want to defend the natural way of playing around and then suddenly deciding one wants to save some part of caches-on-view...
Being so horribly structured as all you guys seem to be just isn't natural for most people.
Skickat från min Android-telefon med K-9 E-post. Ursäkta min fåordighet.
rsudev<EMAIL_ADDRESS>skrev:
@HansJA As I said, you can save a selection of your current search result list already with current functionality, albeit not to a new or selected list, only to the standard one.
While discussing and thinking about this several ideas come to mind for improving the functionality and usability of the (live) map. I'll try to list them here as a starting point to gather feedback and decide directions.

As @Bananeweizen already noted, 'Caches around here' would be a good thing on non-live maps on long press somewhere on the map
Perhaps it should be possible to turn maps on stored lists/caches into live mode (at the same time selecting the respective list as target if a cache is then stored from the map)
To enhance the usability I think a status-icon (live on/off) in a corner of the map would be good, at the same time acting as a toggle for this function
As I have seen the 'current direction' up instead of north-up functionality of locus I think we could give this a spin as well.

Comments?

Reply to this email directly or view it on GitHub:
https://github.com/cgeo/c-geo-opensource/issues/1141#issuecomment-4043875

@HansJA What I understand from your comment is, that besides the suggested functionality to select/create a list to store caches to when viewing a search result or live list you suggest to introduce a map-based selection functionality for this function as well.
While it sounds not bad to me, I currently can not really envision how the user interaction could work here, as the tap action is already associated with showing the cache popup (where you already can store a cache if you want)

What do you mean by map-based?
I just wanted the menues for storing/selecting lists to be available when looking at a map with caches on it.
A pruning mechanism would have to be map-based, i suppose, but the rest?
Skickat från min Android-telefon med K-9 E-post. Ursäkta min fåordighet.

@rsudev
Try Locus and it's user interface. Short press, long press, cursor in the middle and options menu.

As far as I can see, that would do (most of) the trick, without too many overloaded actions.
And most of is as good as we need.
Skickat från min Android-telefon med K-9 E-post. Ursäkta min fåordighet.

At Locus I have looked some times and found the semi-transparent toolbar at the bottom quite useful from a UI perspective.
Perhaps I should create some mockups to get it clear for me how this can be done in a useful and intuitive way.
I can think of two interaction concepts:
Select target list first and then tap on caches and store via popup to the selected list. Relatively easy to implement, easy selection model for the user, but the it would be necessary to put the list selection someplace where it can be found and the current selection should be displayed somehow or easy visible.
or
Select caches (either directly in map or in the temporary list created from the map) and then store them with the additional step of selecting the target list with the option to create a new one in this step
or
Could we perhaps display a diskette-like 'storage' icon in some corner and drag and drop the cache onto it (with long-press, like on the home screen), tapping the icon to see current selected list and select/create a new one?

I definitely prefer:

Select caches (either directly in map or in the temporary list created
from the map) and then store them with the additional step of
selecting the target list with the option to create a new one in this
step

Have you tried anything yet?
Skickat från min Android-telefon med K-9 E-post. Ursäkta min fåordighet.

The new GS map implementation and the recent new feature of opening the live map for a searched location  makes this kind of obsolete.


Added RateLimitMode.SmallBurst as middle ground option

RateLimitMode.Pace seems like it causes a lot of unneeded delays for most cases, but RateLimitMode.Burst option can cause a very long lockout to the user / program as well. I think having a nice middle ground of 5 requests every 10 seconds would be nice and it has no negative impact.

:tada:

I'm going to recommend that this area be refactored out into a strategy
interface. Having three modes is starting to make that code more messy then
it needs to be. Can use dependency injection and all that jazz.
On Mon, Jul 13, 2015 at 6:39 PM, Drew DeVault<EMAIL_ADDRESS>wrote:

[image: :tada:]
—
Reply to this email directly or view it on GitHub
https://github.com/SirCmpwn/RedditSharp/pull/171#issuecomment-121091870.

Let's keep it simple. The moment we introduce dependency injection we are pretty damn far from simple.

Previous discussion: https://github.com/SirCmpwn/RedditSharp/pull/118


Add Deezer Logo

Closes #281

Please follow the guidelines at https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md

@edent If the problem was the whitespace that is fixed. Otherwise just tell me what's wrong cause I was following the guidelines.

All icons must be under 1,024 bytes. Look at all the others - they're square icons.
Your submitted icon is too large and the wrong dimensions.

@edent that's impossible for Deezer considering their logo has a lot of gradient. Should I replace by the black and white version instead?

Take a look at all the other logos in this repo for inspiration. I'm confident you can get the icon down to that size.

@edent I've tried many different ways and even using the symbol version only that's the minimum I can get. Any suggestions?

Closed by #301


How to avoid Pluralsight account blocking

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

I use this command for downloading videos from Pluralsight:

youtube-dl --cookies cookies.txt -o "C:/MyVideos/%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s" URL --write-sub --sub-lang en,es

But after a few times my account is blocked. Do I do something wrong ? Or how can I avoid blocking as much as possible ?

--sleep-interval SECONDS         Number of seconds to sleep before each
                                 download when used alone or a lower bound
                                 of a range for randomized sleep before each
                                 download (minimum possible number of
                                 seconds to sleep) when used along with
                                 --max-sleep-interval.
--max-sleep-interval SECONDS     Upper bound of a range for randomized sleep
                                 before each download (maximum possible
                                 number of seconds to sleep). Must only be
                                 used along with --min-sleep-interval.

Yes. You violated their terms of us


Remove MarkAsPush feature (ASC)

Per MessageBus ADR the MarkAsPush feature will be removed dues to potential concurrency issues when DS use MessageBus to send Events.
Remove MarkAsPush configuration from all profiles.

On hold until ADR is TCS approved


Sending MMS

Is it possible to send media Images, Documents?

Hello!
The app is primarily designed to work with SMS, and it doesn't support sending or receiving MMS content such as images or documents.
While I appreciate your suggestion, my current focus is on maintaining a streamlined, efficient SMS service. I follow the philosophy of "Do one thing and do it well".
I've added your feature request to the backlog for consideration. However, please note that implementing MMS support is not currently on my immediate roadmap.


[xmlns] fixed setting xmlns attribute

Pull Request Test Coverage Report for Build 874

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0002%) to 99.755%

Totals

Change from base Build 866:
0.0002%

Covered Lines:
882

Relevant Lines:
882

💛  - Coveralls


fixed: leap year mixup

Hi,
I think I found another little bug (and fixed it already ).
Thanks

I quite honestly can't believe I did that. Oops!

0.3.1 is up. Thanks again :+1:


Release v1.4.1 fails test

Having upgraded from using version 1.4.0 in our code I'm now seeing tests timing out.
I then installed/run the code using node v14.18.3 and am seeing one of your test cases fail  too:

Test failure : should decrement hits with closed response and skipFailedRequests

The problem appears to have been caused by a https://github.com/nfriedly/express-slow-down/blob/459f2d532246c263356137dde6b840f522b6bf1d/lib/express-slow-down.js#L123 which is the only significant change since the previous revision at 1.4.0. I have no idea what fix is needed.

So, that test passed in CI on node v14.20.0 - https://github.com/nfriedly/express-slow-down/actions/runs/3011334117/jobs/4838331160
What OS are you on? I've observed some flakeyness in testing on Windows and especially MacOS, but I believe it's due to how the test suite is implemented, not an issue with the library. (It's been on my todo list to improve this.)
That clearTimeout fix should only affect requests where the connection timed out or otherwise closed before the slowdown ended.
Can you share what your test looks like?

I'm on the latest version of MacOS. Will see if I can do a bit more detective work to see what's going on in my test cases and will share if I can track down what's needed to get them working. Hopefully I can work out a minimal test case that can be shared.

Ok, it sounds like you're not the only one with this issue, #32 seems like it's probably the same thing.
I'd like to get an automated test that recreates the issue so that we can then fix it for good. To that end, I spent some time this weekend stabilizing the existing tests so that they now appear to pass reliably on windows, mac, and linux.
The one thing I want to add, that I haven't gotten to yet, is a "real world" integration test that spins up a server and makes actual HTTP requests. I have a feeling that that will be necessary to narrow this down.
Anything you can do to get me a reproducible test case would be appreciated.

Thankyou for looking into this. Unfortunately I've not yet got a minimal test case..

You're welcome!
@ouraios figured out on #32 that if the request body is consumed before express-slow-down runs (e.g. by using body-parser), that will lead to the hanging bug. v1.4.2 fixes this.
However, I should mention that it would make more sense to have express-slow-down run before something like body-parser because it can't provide any protection against a malicious user sending tons of uploads if it runs after.

Awesome - Works in our case too. Much appreciated.


[Module Proposal]: Azure App Service Plan

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

[X] I have checked for that this module doesn't already exist in CARML or TFVM

Terraform or Bicep?
Bicep
Module Classification?
Resource Module
Module Name
avm-res-web-serverfarm
Module Details
A resource module for an ASP (Microsoft.web/serverfarm). Put name on original index spreadsheet of carml modules back in may, so happy to own and refactor to avm specs.
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username
tsc-buddy

Hi @tsc-buddy,
Thanks for the proposal.
However, it seems these modules already exist in CARML and therefore are being migrated by the CARML team to AVM already in a bigger bang style approach. As we have documented here: https://azure.github.io/Azure-Verified-Modules/faq/#carmltfvm-to-avm-evolution-details
You can see this here in the indexes: https://azure.github.io/Azure-Verified-Modules/indexes/bicep/bicep-resource-modules/
Also an app service is made up of many different resources from an API perspective and there's not just a single "app service" module. As you can see in the above index for all the avm-res-web-xxxxx modules we will be migrating from CARML.
Therefore could you let us know whether you'd like to be the owner of one or all of these avm-res-web-xxxxx modules or do you wish to actually create a pattern module that wraps all of these resources into one, optionally you can await us to migrate them from CARML to build the resource modules as per this shared pattern module requirement https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-pmnfr2---category-composition---use-resource-modules-to-build-a-pattern-module
Let us know

Hey @jtracey93 - Understood on the Bicep CARML side of things. Prior to the github issues being the place to pick up modules, I put my name down in the spreadsheet following some discussions in early august with Pankaj and Charlie for Microsoft.Web/serverfarms & Microsoft.Web/sites as there were no names against them.
My thinking on App services resource module was as sites cannot be deployed without serverfarms (unless you ref an existing one) and serverfarms with no sites are kind of useless it would make sense to have a resource module deploys the site and its required resource.
A pattern module for app service environments may be appropriate though, given that would be three separate resource types under the web RP.

details of module updated based on discussions with @jtracey93 - hopefully that proposal aligns better.

@jeanchg or @matebarabas can we validate the module names and if we have a current owner of the CARML equivalent, if it exists?
If not lets send the confirmation to @tsc-buddy to confirm ownership statement 👍

@tsc-buddy, I'll reach out to you internally to discuss the right strategy for this work.

Hi @tsc-buddy
Thanks for requesting/proposing to be an AVM module owner.
We just want to confirm you agree to the below pages that define what module ownership means:

https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
https://azure.github.io/Azure-Verified-Modules/specs/shared
https://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed let us know.
If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks
The AVM Core Team

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@matebarabas - I also have a colleague who is happy to co-own these. So when we sync next, let me know the process to onboard them.

@matebarabas i will handle this together with other conversion request. @tsc-buddy i will share with you upgrade checklist that you can use to continuo your work.

@tsc-buddy, thanks for opening this request and volunteering!
Also, @prjelesi is going to reach out to you separately and help with the next steps, given this is a migrate from CARML scenario.

@matebarabas - I also have a colleague who is happy to co-own these. So, when we sync next, let me know the process to onboard them.

Please let me know who the other person would be; we can capture him/her as a secondary owner.
Thank you!

Hi @tsc-buddy ,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities.
We just want to ask you to double check a few important things before you start the development.
Please visit the module index page of your module and use the following values explicitly as provided there:

ModuleName
TelemetryIdPrefix
ModuleOwnersGHTeam and ModuleContributorsGHTeam
Repository name and folder path defined in RepoURL

You can now start the development of this module! Happy coding! 🎉
Please respond to this comment, once your module is ready to be published!
Any further questions or clarifications needed, let us know.
Thanks,
The AVM Core Team

@tsc-buddy,
Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.
The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!
Please see the new naming convention in:

RMNFR1 for resource modules
PMNFR1 for pattern modules

Please note that the Telemetry ID and name of GitHub Teams haven't changed.
If you feel uncertain about any details, please check the Bicep modules indexes.

To be migrated from CARML: https://github.com/Azure/ResourceModules/tree/main/modules/web/serverfarm
Requested by the AZD team: #261
CC: @jongio

[x] Module published: #700
[x] GitHub teams are available and assigned to their parents.
[x] CODEOWNERS file updated.

Thank you for your work @tsc-buddy! I'm closing this issue now.


camera_link child frames are not static

Hi!
Based on results from rqt_tf_tree, it seems that child frames of camera_link such as camera_rgb_frame and camera_depth_frame are not based on static transforms but rather are being published at 10Hz which is causing some problems in my system.
Is it correct that they are not static transforms?

I found the code in  astra_frames.launch and changed the period from 100 to 1. That works better in my use case.
I would recommend publishing the tf frame at atleast 30 Hz to match the camera FPS.

Actually I found that using the tf2 static publisher works much better and at a much higher rate.
I would recommend updating the astra_frames.launch nodes to tf2 as well:
    args="0 -0.02  0 0 0 0 $(arg tf_prefix)/$(arg camera)_link $(arg tf_prefix)/$(arg camera)_depth_frame" />

  <node pkg="tf2_ros" type="static_transform_publisher" name="$(arg camera)_base_link1"
    args="0 -0.045 0 0 0 0 $(arg tf_prefix)/$(arg camera)_link $(arg tf_prefix)/$(arg camera)_rgb_frame" />

  <node pkg="tf2_ros" type="static_transform_publisher" name="$(arg camera)_base_link2"
    args="$(arg optical_rotate) $(arg tf_prefix)/$(arg camera)_depth_frame $(arg tf_prefix)/$(arg camera)_depth_optical_frame" />

  <node pkg="tf2_ros" type="static_transform_publisher" name="$(arg camera)_base_link3"
    args="$(arg optical_rotate) $(arg tf_prefix)/$(arg camera)_rgb_frame $(arg tf_prefix)/$(arg camera)_rgb_optical_frame" />  ```

@faizan-m Thank you for your recommendation. I've updated this.

Thanks!


Improve typings by allowing JSONSchema6 objects

I've found no restriction which only applies to JSONSchema4 objects.
Also @types/node have been added to dev-dependencies since Buffer can't be found without them.

Coverage remained the same at 95.238% when pulling 5a6fbedc3278ce7e71357cd7891460dc17b04c74 on krenor:improve-typings into cc40cb57cf660ca793d52780ab49cc41921d0644 on BigstickCarpet:master.

Coverage remained the same at 95.238% when pulling 5a6fbedc3278ce7e71357cd7891460dc17b04c74 on krenor:improve-typings into cc40cb57cf660ca793d52780ab49cc41921d0644 on BigstickCarpet:master.

@BigstickCarpet This seems like an Issue with Travis setup regarding yarn.. should I remove the yarn.lock file?

This PR has been released in v4.1.1 🙌


Flow server fails silently when inotify limit is reached

When the limit of inotify watches is reached, Flow server obviously does not recheck source files when they have changed. It will emit the same diagnostics every time, despite source file changes. It took me a long time to figure out this was due to the inotify limit being reached, though, because Flow server silently fails. I think it should tell me when it reaches the inotify limit, instead of failing silently.
I use Flow 0.22.1 on Gentoo Linux 4.1.12.

Yikes. Thanks for letting us know.

As an aside to this, I find that a couple of flow instances running at the same time saturates the default inotify watch limit pretty quickly. Would you like me to report that as a separate issue/concern?

This bug has just bitten my teammate (who also was new to Flow, so this was doubly inconvenient!)
He is on Ubuntu, and we solved it by upping the inotify limit from 8192 to 65536:
sudo sysctl fs.inotify.max_user_watches=65536
Not failing silently would be a good thing, needless to say :)

@tempname11 that solves the problem for Xubuntu 18.04 w/ flow-bin 0.78.0. Thanks!

I had the same issue and took a while to realise what was going wrong. Thanks to tail it warned me about the inotify limit being reached !!


Add feed tests

I initially didn't write any as I wasn't sure if the interface is there
to stay. For now I don't forsee any changes to it so it is time to add
those tests.
I also made sure that some extra checks were covered and used the
existing function AppendMessage to append created messages for extra
safety.

Waiting for #30.


gslc_ElemSetVisible() does not work

It appears that calling gslc_ElemSetVisible(&m_gui, _A_BUTTON_, false); on a button, only disables the button, but does not hide it when the display is refreshed.
I found this comment in XKeyPad.c  but I'm not sure if this is specific to that component or it really refers to gslc_ElemSetVisible not yet working at all:
  // FIXME: Need to fix dynamic visibility change
  // gslc_ElemSetVisible(pGui, pElemRefTmp, bVisible);
Platform:
MoteinoM0 (CortexM0+ SAMD21G18A 48Mhz)
ILI9341 2.4" + Touchscreen
#define GUISLICE_VER "0.12.1"
#include "../configs/ard-adagfx-ili9341-xpt2046.h"
Arduino 1.8.7

Hi @LowPowerLab -- you're right! Thanks for reporting this and providing the helpful supporting details.
I have now checked in a fix to support hiding of elements via ElemSetVisible().
Please try the latest GitHub master and let me know if the functionality works correctly for you now.

That works, thanks for the quick resolution!

Great - thank you for the followup


[Core] Fix code style issues

@minmingzhu Pls help to fix code style issues after PR #183 is merged. You can check the failed checks to do code changes.

@minmingzhu Pls submit PR to close this issue.


New Profile Page

The Task
Create a mockup profile HTML page. English or German (language doesn't matter for this mockup). To solve this issue no Elixir code has to be written. Just plain old HTML and CSS (probably embedded in the HTML). If you need data use dummy data. Please store the file(s) in misc/mockups/ or a subdirectory of it. The HTML file should contain the form. Later on someone will convert this mockup into a Phoenix template. But that will be a separate issue.
Here is an example of the v1.1 version of that profile page: https://www.vutuv.de/users/stefan.wintermeyer
Please create a pull request to submit your work (master branch).
New Features
Version 2.0 will offer features which will have to become part of the profile page:

Points. A user gets points for specific tasks. Think https://stackoverflow.com reputations but for vutuv stuff.
Badges. Depending on their point status users get specific badges.
Posts. Think of it as a Blogpost. For new users it will be limited to 140 characters. Once a user gets through a specific level of points he/she can post 280 characters and 512 characters. As a bonus users can use Markdown once they achieved a specific point level. See #577
Votes. Users can up and down vote posts (like stack overflow.com)
Share. Like a retweet in Twitter.
Message. Think DM of Twitter. I can send a message to everybody who follows me and vice versa.

Alert Area
It would be very useful to have an area where system messages or warnings can be displayed.
General Thoughts about the Profile Page
The biggest problem is that we don't have the resources to build custom made CSS for all the sub resources (e.g. https://www.vutuv.de/users/stefan.wintermeyer/work_experiences or https://www.vutuv.de/users/stefan.wintermeyer/links). So we need some sort of generic approach.
I think (but please tell me if this is a wrong assumption) that we need to stand on some frameworks shoulder (Bootstrap comes to mind) so that Phoenix developer can create sub resource pages by themself.
Bottom line: We need one nice looking profile page with all the information and a generic set for all the sub resource pages.
@MarioRicalde and @xamiam: Please share your thoughts about this.

All these sub-resource pages are really needed? Are they showing some information that is not visible in other places? I'm asking because:
https://www.vutuv.de/users/stefan.wintermeyer/work_experiences/freelancer.wintermeyer.consulting
Doesn't really show anything new that is not visible on a previous page.

All these sub-resource pages are really needed?

Very good question. I have never thought about this this way.
The only reason for this view is that sometimes there are too many elements to be shown on the profile page. If somebody has a long work history or 20 urls you can’t show them all on the profile and would therefore link to the sub resource index page.
I’m open for alternatives.

Realistically speaking you want to plan for the 99% of the users and not for the 1% of the users. If someone goes above and beyond to have so many, then we should just show them and keep a super long page. Because from what I understand, that's what they want anyway. Your average Joe is not going to be putting 100 job history places, just the bigger ones that make them look good. I reckon.
There's also a concern with SEO ( if this is even crawlable ) with a lot of the content coming up as pretty much duplicate content.

Realistically speaking you want to plan for the 99% of the users and not for the 1% of the users. If someone goes above and beyond to have so many, then we should just show them and keep a super long page.

I see your point. Your right. No more sub resource pages for show information.

But what are we going to do with the posts? Everyone who’s using that new feature will accumulate more post than being possible to display on the profile page.

Posts are understandable a thing which we should HOPE to get a lot of. Those are paginated, and they should have their own child design. These, however, shouldn't be too generic and look like everything else, needs to be special. I think.

@wintermeyer I'm jumping to work on this one, I have a couple of questions about the implementation of this particular section. Do we intend to keep that idea of inline styling? Or here we're using normal CSS, will we have access to JS here?

Do we intend to keep that idea of inline styling?

I don't know yet. Currently most visitors of vutuv.de come via Google or via direct link to a profile. Speed is key for all those potential new users. They don't have the CSS in their local cache yet. So for them I'm thinking: Let's try to inline it.
For already existing users (who would have a cookie set) a separate CSS file makes more sense because their browser can cache it.
Bottom line: Let's inline it for the version 2.0 and let's tackle the proper - if has cookie - rule in version 2.1.

will we have access to JS here?

That is a tricky one too and we have the same situation as with the above question.
For users who already have a vutuv account and the set cookie JavaScript is fine (but not an over the board amount of JavaScript because it does slow down the WebPerformance). For all potential new users who don't have a cookie: I'm thinking that they don't need JavaScript. They can not interact with the page anyway without having an account. So a non JavaScript page would be super fast for them.
BUT: I'm open for other solutions for both questions. Speed is just super important for vutuv. Right now we can not compete feature wise with LinkedIn. But we can compete speed wise and for many - especially mobile - users this is a big plus and I often get positiv feedback about vutuv's speed.

Understood, I have one extra question:
Do we intend to let users customize the looks of their profile? Think Twitter cover image or Facebook cover image.

Do we intend to let users customize the looks of their profile? Think Twitter cover image or Facebook cover image.

Not in v2.0. We have enough other stuff on our hands.

We need to have some sort of “Member since mm/yy” text on the profile.

@wintermeyer roger that.
I'm struggling a bit trying to figure out what we want to show as the centerpiece of the design. My understanding is that we want to focus on showing information about the User Experience. But in the old design, we have Followers & Following as somewhat of a centerpiece.
Could you provide me with a list of things in order of importance for that page? So that I can figure out how to arrange it in a clean way. That'd help me a lot.

The problem: When people use the post feature then those posts are important. But there will be plenty of people who don’t post and use it just to be found by human resource departments.
In v1 we didn’t have posts. Followers seemed to be the most interesting thing to display because it is a business network.
Long story short: I see your point but I don’t have the one-size-fits-all answer.

hmmm... if I don’t know you but for some reason land on your profile page what would help me to figure out if I like/need you?

The tags and their ratings (e.g. CSS or Origami)
How many points you have. On stackoverflow.com one always checks how many points an account has.
Your posts.
Your avatar. We are humans.

Help me understand the Points functionality, what gives you points? What happens when you click points, do you go to a view where you show what give you what points?

A user gets points for interactions.

He logs in: 1 point
She writes a post: 5 points
The post gets shared by other users: 2 points per share
etc

Points can be redeemed (e.g. buying ads). But points age. They lose 20% of their value every 12 months.
A specific amount of points grants special privileges. E.g. being able to write longer posts.

What needs to be done with this issue? Can we close it?


Sass version

hey @krisztianpuska, Good work on this.
I've played around with ideas like this myself.
Would you be open to having the css generated from sass so it can be included in a more modular format?

Thanks for the feedback, @jackmcpickle!
The goal of a sass/less version would only be that you can include modules separately, right?
I'm giving it some more thought.

Yes exactly. And could help output variables in the users preferred units.
--
Cheers
Jack

m: 0438 585 696
e<EMAIL_ADDRESS>w: https://jack.mcpickle.com.au
On 11 Jul 2017, 16:23 +0930, Krisztian Puska<EMAIL_ADDRESS>wrote:

Thanks for the feedback, @jackmcpickle!
The goal of a sass/less version would only be that you can include modules separately, right?
I'm giving it some more thought.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Keep unscaled value(startTime, stopTime, PTO).

For presentationTimeOffset is non-zero. We'll keep it as unscaled value.

#1

@TobbeEdgeware , @duynguyen-ew , It's OK when I tested it on the latest google/shaka-player (all tests passed and not 404 response from VCP origin).

About testing, I need more time to understand and write test for it. Could I investigate or give up?

You'll need to describe your changes much better in the commit message. If I were shaka player maintainer I would reject this PR. See https://chris.beams.io/posts/git-commit/ (as basic guideline, not rules)

@PhamCongDuc
Regarding commit messages, it is listed as point 5 in https://github.com/google/shaka-player/blob/master/CONTRIBUTING.md with a link to a "guide". You can modify your commit with a more explanatory, but still relatively short message.
I think you have spent enough time on trying to write a test. Let's skip it. I may give it a try before submitting the patch.
My plan is to merge your PR here into our fork, and then submit it tomorrow. lf I don't manage to make a test, I'll simply tell that in the PR towards Shaka.

Hi @duynguyen-ew , I just changed commit's subject. Please let me know if it's OK. I copied your commit's body which is the best description for it.
Hi @TobbeEdgeware I removed unscaledEnd.

I've moved this commit to another branch. Will try to do some more work on it before submitting it to shaka player.

I submitted a PR today.

https://github.com/google/shaka-player/pull/702

We need to redo this, since the author did @PhamCongDuc is using aa Github account which does not have an edgeware email address.

Or just sign the CLA.

We have signed a CLA for Edgeware, and that is what we should use. We should not have personal contributions and CLAs.


Adding ciT Leipzig

Trying to add my School to your Database.

@gtskhadadze83 Pull request merged. Thank you!


Separate out package code from paper code

Currently, the package has a lot of fluff which is not really needed. I will branch it out to paper which contains the scripts and everything needed to reproduce the results from the paper.
Stuff that need to be removed:

[x] experiments directory -- Maybe convert that into usage examples.
[x] scripts directory -- Has some scripts for distributed training using MPI (will move them to FluxMPI which seems to be an appropriate place for their usage)
[ ] Inside src

[ ] solve.jl -- See #33
[x] logger.jl -- Time to place it somewhere appropriate. Have been copy-pasting that file in all my projects :sweat:
[x] datasets.jl -- Again not relevant to DEQs

Stuff to be added:

[ ] Some documentation would be good (even I forget how to use a few of those functions :sweat_smile: )

See ap/release

See #38


Support certificates stored as Kubernetes secrets

Hi!
At Giant Swarm, we're developing a platform for managing and running Kubernetes clusters. We run our control plane on Kubernetes, and use that to spin up Kubernetes clusters.
I'd like to use Prometheus to scrape these 'guest' Kubernetes clusters (api server, kubelet, node exporters, to begin with). As a customer requirement, we need to use https for the scrape itself.
Our operators provide a Kubernetes Service in the host cluster that points to the masters / workers of the guest cluster.
The certificates for these guest clusters are stored as Kubernetes Secrets in the 'host' cluster. Configuring Prometheus to use these certificates is currently not possible OOB.
Adding support to Prometheus to read certificates from kubernetes secrets doesn't make a lot of sense (as it's very focused on Kubernetes / our use case, see https://github.com/prometheus/prometheus/issues/3218) - does adding support to prometheus-operator to use certificates stored as secrets for the scrape make sense to you?
If it doesn't, we're going to write our own tool to manage the configuration / certificates, but it made sense to me to reach out, as there could be some overlapping work here.
Writing this to start a discussion, happy to start on a PR if it makes sense.

I'm not sure how much sense automatically discovering secrets would work or make sense, but we do allow a list of secrets to be mounted into Prometheus pods. This however will always trigger a re-deploy of the Prometheus instance on a new secret (which I imagine should not be very often, but still possible).

Yeah, that wouldn't work for us, we'd be restarting prometheus very frequently.

Sounds like your best bet would be to have a sidecar that retrieves the certs from the Kubernetes API and writes them and reloads Prometheus.

Cool, we'll go with our own approach. Thanks for your time!


Use by default on every hosts

Hello.
Tell me, please, can I use forp profiler without modify code ? I'am talking about log file with full trace/
Maybe some settings in php.ini ?

@dmitryskachkov auto_prepend_file in php.ini should do it


Disable notebook execution for book content

Description
This PR turns off automatic notebook execution for notebooks on builds for docs. After this change I expect the notebooks to render as-is, with the expectation that they are processed before being added to the seedbank or elsewhere. I also added a convenience task through poe which allows for quickly testing package-focused work.
Closes #103
What is the nature of your change?

[ ] Content additions or updates (adds or updates content)
[ ] Bug fix (fixes an issue).
[x] Enhancement (adds functionality).
[ ] Breaking change (these changes would cause existing functionality to not work as expected).

Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.

[x] I have read the CONTRIBUTING.md guidelines.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own contributions.
[x] I have commented my content, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to related documentation (outside of book content).
[x] My changes generate no new warnings.
[ ] New and existing tests pass locally with my changes.
[ ] I have added tests that prove my additions are effective or that my feature works.
[x] I have deleted all non-relevant text in this pull request template.

Thanks @gwaybio for the review! Merging this in.


Update JS docs for examples and typos

I was working on adding a gauge to an example app and realized these docs had a mis-typed variable name. In my drive-by I updated a few other typos as well. Changes made:

Update two variable names used in the JS metrics docs
Fix a few typos I came across in the process

@JamieDanielson - as it says in the build log, could you execute npm run prettier:write and commit the changes?

@JamieDanielson - I rebased and ran the formatter, which fixed the build. We have all the necessary approvals so I'll merge now. Thanks again, this gives me fuel for the following 😄:

#948

@JamieDanielson - I rebased and ran the formatter, which fixed the build. We have all the necessary approvals so I'll merge now. Thanks again, this gives me fuel for the following 😄:

CI: run spelling checker #948

Thank you! Beat me to it.
FWIW, I came across some of those spelling fixes because of my cspell plugin. I can throw a comment on that other issue as well. Biggest thing usually is building up a dictionary of words to ignore.

I/we've been using cSpell informally (with the current dictionary, under .vscode, being committed), ... just haven't set it up as part of CI checks yet. Right, setting up the dictionary, and progressively applying it to pages.

In the meantime, we appreciate PRs with spelling fixes. Keep'em coming, and thanks again! 😄


Etcher-cli: list of flashable devices

Hi
I want to use etcher-cli on linux mac and windows and I'm looking for a way to detect flashable devices on all platforms.
Is etcher-cli able to return available flashable devices?
Thank you for your answer ;)

Not at the moment, but https://github.com/resin-io-modules/drivelist is able to do that :)

See also https://github.com/resin-io/etcher/issues/1420#issuecomment-301581820

@tangb Is drivelist able to provide you the info you're looking for (in which case can this issue be closed?), or is there something more specific you're looking for from etcher-cli?

@lurch I think the intention is to list the available drives from the CLI, to see which one to flash. But that's also already available; if you omit the --drive option you'll be presented with a list of devices to select from, i.e.:
$ etcher ~/Downloads/something.img
? Select drive (Use arrow keys)
❯ /dev/disk2 (31.9 GB) - SD Card Reader

Closing, as this feature is already available

@jhermsmeier  My first intention was to list available drives from python. So i was looking for if etcher-cli was able to return me that list.
Finally I find another way to do the job, looking how it was done in drivelist.
Anyway the "feature" can be closed
Thank you

Sorry that I misunderstood; in that case you're really looking for drivelist 😄


Add serialize helper function that performs our string serialization

We do not want the case where individual fetchers are serializing values
themselves, so create this function to do that in a consistent way.
Also relates to TD-149

This shouldn't affect any of your work so we can pull it in after - rather this PR just moves the serialisation function we currently have in pomelo into thingfulx so it can be used from individual parsers.

👍  LGTM

as a result of this, will we use it like this?
thingfulx.Channel{
    Type: thingfulx.Serialize(123.456),
}

@dotmancando - yes well almost. we have some error handling and the value lives on the observation level, so it would be something like:
serializedValue, err := schema.Serialize(123.456, schema.DoubleType)
if err != nil {
  // return the error or skip to next record depending
}

obvs: = thingfulx.Observation{
  Value: serializedValue,
}

and actually in TransportAPI I've just noticed that funky time array/list thing we have so just adding a serializer for that too


Lower resolution option

For users who want images as fast as possible, this adds a megapixels option to flux-dev and flux-schnell. Defaults to 1 megapixel, but users can also select 0.25 megapixels to generate lower resolution images very very quickly.
Also refactored our common preprocessing code into a preprocessing function.

Sweet!
cc @replicate/community


Add IHP to server-side web dev

Hey :) This adds IHP to the list of web frameworks. IHP is likely the most active web development community in the haskell space at the moment. You can find some usage numbers in our Telemetry here: https://ihp-telemetry.digitallyinduced.com/admin/Events
I also added IHP Casts and IHP Cloud because I think they're very helpful for people to get started with doing web development with haskell.

@mpscholten: Thank you! 🙂

@mpscholten: Thank you! 🙂


Remove redundant variables

This AtomicInteger variable is meaningless, there is no thread safety issue here, and the variable does not return

Codecov Report

Merging #6740 (1e5f8f9) into develop (9d411cf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #6740      +/-   ##
=============================================
- Coverage      42.85%   42.84%   -0.02%
  Complexity      9002     9002
=============================================
  Files           1113     1113
  Lines          78615    78614       -1
  Branches       10229    10229
=============================================
- Hits           33692    33683       -9
+ Misses         40701    40699       -2
- Partials        4222     4232      +10

Impacted Files
Coverage Δ

...client/consumer/store/RemoteBrokerOffsetStore.java
68.75% <100.00%> (-0.28%)
:arrow_down:

... and 23 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @haiyanghan Pleas link to issue.

ok

@mxsm PTAL


Inventory Items causing errors...

This is just a quick sample of an error that occurs with some particular metadata attached to items on our server. This maybe unique, but I am looking for a solution. Players seem to have inventories intact, except in some cases where they cross worlds, and permissions are not the same.
http://hastebin.com/woyomuzaka.avrasm
Noting this particular line:

[02:48:30 WARN]: [Multiverse-Inventories] Could not parse item: ItemStack{LEATHER_BOOTS x 1, LEATHER_ARMOR_META:{meta-type=LEATHER_ARMOR, display-name=DELTA Boots, lore=[Offical Armor of DELTA], enchants={PROTECTION_ENVIRONMENTAL=4, PROTECTION_FIRE=4, DURABILITY=3, PROTECTION_FALL=4, PROTECTION_EXPLOSIONS=4, PROTECTION_PROJECTILE=4, THORNS=3}, color=Color:[rgb0x282850]}}

This is not a Multiverse-Core issue. It's with Multiverse-Inventories. I'd recommend giving PWI a look as we're not supporting Multiverse-Inventories at this time due to time constraints of the developers and it has several known issues.
PWI supports importing your Multiverse-Inventories settings.
I would only suggest using another plugin if it was open source, and PWI is.


Destroying atom by launching Setup again

I successfully installed Atom a few weeks ago.
Today I accidently started the AtomSetup.exe (the installer) again. As expected, it failed. But after that nothing worked no more. I tried uninstalling, it just happend, but the uninstaller misses a lot (remove registry entries etc.).
Additionaly, the log shows stuff that is not right, I know which folders I deleted( Install path C:\Users\inetphantom\AppData\Local\atom already exists, burning it to the ground )
After that, Atom (out of \AppData\Local\atom\app-1.4.0\lib\net45) worked, but not the Update.exe from Squirrel.
SquirrelSetup.log (Uninstall)
SquirrelSetup.log(AtomSetup.exe)
SquirrelSetup.log (Update.exe)
I would wish me a Atom-remover beside the uninstaller, and that the installer should not break the working installation

Both the install and uninstall logs show access denied errors to the installation folder which is strange as it is a user folder chosen to ensure you always have rights to it.
Are you running any anti-virus product?

No response, closing issue. Please re-open if you are still experiencing this issue.


Notebook for playing matches

PR since this notebook won't work until my latest PR on axelrod is merged.

:+1: (on my phone so can't set a label)


Aframe particles system component does not work with MindAR?

I'm having issues getting any sort of particle system to be incorporated with MindAR, the particle do not seem to visible no matter the values I incorporate. Anyone else also getting this issue?
This is the particle system I am using to get particle to appear:
https://www.npmjs.com/package/aframe-particle-system-component

If you're using aframe 1.2.0, the latest release of https://www.npmjs.com/package/aframe-particle-system-component is not compatible with the THREE version included in aframe 1.2.0.
An update was merged in October 2021 in the master branch https://github.com/IdeaSpaceVR/aframe-particle-system-component that is compatible with aframe 1.2.0, but is not yet released. You can use the master build like this:
<script<EMAIL_ADDRESS>

@vincentfretin thank you for the clarification
I've added
<script<EMAIL_ADDRESS>and also incorporated the preset
       <a-entity position="0 2.25 -15" particle-system="preset: snow"></a-entity>
However I'm still unable to see any particles being emitted within my marker scene. I've changed the position, size and texture. Have you incorporated particles before? If so do you have a basic example of this with MindAR marker?
<a-scene mindar-image="uiScanning: #example-scanning-overlay; imageTargetSrc:businesscard_qrmarker_5.mind"     vr-mode-ui="enabled: false" device-orientation-permission-ui="enabled: false" loading-screen="enabled: false">     <!--Asset Management-->     <a-assets>     </a-assets>     <!--Camera-->     <a-camera position="0 0 0" look-controls="enabled: false" cursor="fuse: false; rayOrigin: mouse;"       raycaster="far: 10000;objects: .clickable"></a-camera>     <!--Main Scene Area-->     <a-entity id="marker-target" mindar-image-target="targetIndex: 0">       <a-entity position="0 2.25 -15" particle-system="preset: snow"></a-entity>     </a-entity>   </a-scene>
Thank you for the help regardless!

We have the snow particles on the networked-aframe examples
https://github.com/networked-aframe/networked-aframe
Does this work directly in  ?
If you don't see the snow only when you put the particle-system as a child of a marker, then I can't help you further, I never used mind-ar-js.

 I put the the particle entity outside on of the marker section and it started working!

Ok, I'm glad it works for you. I thought you wanted the snow only after having scanned the marker or something like that. If you want such thing, if there is an event emitted when a marker is scanned (I don't know the lib, so I don't know if there is one), you can probably add the particule-system dynamically with javascript.
You can close the issue and mark as answered the discussion if it's ok for you.


Move implementation of each case in SyntaxRewriter.doVisit to separate function

In debug builds the compiler lays the stack space for each case
statement out next to each other. This causes a call to doVisit(::) to
use ~50KB of stack space, quickly resulting in a stack overflow. Moving
each implementation into its own function causes the each case to not
use any stack space, circumventing the issue.
Fixes SR-11170

Based on some rough measurements, this also appears to give us a ~15% performance increase in release and ~35% performance increase in debug builds for the SyntaxVisitor.

@swift-ci Please test


Create a PR, with understanding from partnerships & product, on when to use fancy-profiles vs binderhub-UI

Main content (and updates) in https://github.com/yuvipanda/jupyterhub-fancy-profiles/issues/37. This issue is split to track the size difference between the two tasks listed in the original issue, and put them in sprints appropriately.

[ ] Create a PR

Closed per https://github.com/yuvipanda/jupyterhub-fancy-profiles/issues/47#issuecomment-2177262689


allow old overrides again

To help with https://github.com/conda-forge/allennlp-feedstock/pull/31

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Update mruby.

It seems a good time to update mruby. Version 1.4.0 was recently released, and we've had very few bug reports recently.

Was thinking we could fix #14 as part of the next update to mruby…
Or are they other implications I'm missing of using https rather that git for these?

@alexsnaps I've already pin a PR for #14 see #30