test module fails when using modules inside modules

tfaction version
1.2.1
Overview
when creating a new module that uses modules, we need to run terraform init before
- uses: suzuki-shunsuke/tfaction/test-module@72536e0b22961437dbca58cb4f3ea20a6b50b58f # v1.2.1
        with:
          github_token: ${{steps.generate_token.outputs.token}}
        env:
          AQUA_GITHUB_TOKEN: ${{github.token}}

step
How to reproduce
tfaction-root.yaml
---
plan_workflow_name: pull_request_target # Mandatory
label_prefixes:
  tfmigrate: "migrate:"
# skip_create_pr: true

# drift_detection:
#   # issue_repo_owner:
#   # issue_repo_name:
#   minimum_detection_interval: 5 # 5 days. By default 7 days.
#   num_of_issues: 3 # 3 working directories are checked per workflow run. By default 1 working directory is checked.

# tflint:
#   enabled: true
# tfsec:
#   enabled: false
# trivy:
#   enabled: true

# scaffold_working_directory:
#   skip_adding_aqua_packages: true

aqua:
  update_checksum:
    # Update aqua-checksums.json in `setup` action
    enabled: true # default is false
    skip_push: false # default is false
    prune: true # default is false

target_groups:
  - working_directory: aws/
    target: aws/
    aws_region: ap-northeast-1
    s3_bucket_name_tfmigrate_history: '<S3 Bucket Name for tfmigrate history files>'
    template_dir: templates/aws

    # terraform_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_AWS_terraform_plan
    # tfmigrate_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_AWS_tfmigrate_plan
    # terraform_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_AWS_terraform_apply
    # tfmigrate_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_AWS_tfmigrate_apply

  - working_directory: for-test/
    target: for-test/
    # aws_region: ap-northeast-1 # CHANGEME Fix the region if necessary
    # s3_bucket_name_tfmigrate_history: '<S3 Bucket Name for tfmigrate history files>' # CHANGEME
    template_dir: templates/for-test
    # terraform_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_terraform_plan # CHANGEME
    # tfmigrate_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_tfmigrate_plan # CHANGEME
    # terraform_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_terraform_apply # CHANGEME
    # tfmigrate_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_tfmigrate_apply # CHANGEME

  - working_directory: github/services/
    target: github/
    aws_region: ap-northeast-1 # CHANGEME Fix the region if necessary
    s3_bucket_name_tfmigrate_history: '<S3 Bucket Name for tfmigrate history files>' # CHANGEME
    template_dir: templates/github
    # terraform_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_terraform_plan # CHANGEME
    # tfmigrate_plan_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_tfmigrate_plan # CHANGEME
    # terraform_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_terraform_apply # CHANGEME
    # tfmigrate_apply_config:
    #   aws_assume_role_arn: arn:aws:iam::000000000000:role/GitHubActions_Terraform_github_tfmigrate_apply # CHANGEME

  - working_directory: gcp/
    target: gcp/
    gcs_bucket_name_tfmigrate_history: '<GCS Bucket Name for tfmigrate history files>'
    template_dir: templates/gcp
    # terraform_plan_config:
    #   gcp_service_account<EMAIL_ADDRESS>    #   gcp_workload_identity_provider: projects/000000000000/locations/global/workloadIdentityPools/github/providers/tfaction
    # tfmigrate_plan_config:
    #   gcp_service_account<EMAIL_ADDRESS>    #   gcp_workload_identity_provider: projects/000000000000/locations/global/workloadIdentityPools/github/providers/tfaction
    # terraform_apply_config:
    #   gcp_service_account<EMAIL_ADDRESS>    #   gcp_workload_identity_provider: projects/000000000000/locations/global/workloadIdentityPools/github/providers/tfaction
    # tfmigrate_apply_config:
    #   gcp_service_account<EMAIL_ADDRESS>    #   gcp_workload_identity_provider: projects/000000000000/locations/global/workloadIdentityPools/github/providers/t

tfaction.yaml

GitHub Actions Workflow
---
name: Test Modules
on:
  workflow_call:
    inputs:
      modules:
        required: true
        type: string
      ref:
        required: true
        type: string
    secrets:
      gh_app_id:
        required: true
      gh_app_private_key:
        required: true
jobs:
  test-module:
    name: "test-module (${{matrix.target}})"
    runs-on: ubuntu-latest
    permissions:
      contents: read
    env:
      TFACTION_TARGET: ${{matrix.target}}
      TFACTION_JOB_TYPE: "terraform"
      GH_COMMENT_SHA1: ${{inputs.ref}}
      TFCMT_SHA: ${{inputs.ref}}
    strategy:
      fail-fast: true
      matrix:
        target: ${{fromJSON(inputs.modules)}}
    steps:
      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
        with:
          ref: ${{inputs.ref}}

      - name: Generate token
        id: generate_token
        uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2.1.0
        with:
          app_id: ${{secrets.gh_app_id}}
          private_key: ${{secrets.gh_app_private_key}}
          # pull_requests:write - Post comments
          # contents:write - Push commits
          permissions: >-
            {
              "pull_requests": "write",
              "contents": "write"
            }
          repositories: >-
            ["${{github.event.repository.name}}"]

      - uses: aquaproj/aqua-installer@7c7338067bdb97d5bea2acc82b5870afca470d18 # v2.3.0
        with:
          aqua_version: v2.24.0
          aqua_opts: -l -a
          working_directory: ${{matrix.target}}
        env:
          AQUA_GITHUB_TOKEN: ${{github.token}}
      - uses: suzuki-shunsuke/tfaction/test-module@72536e0b22961437dbca58cb4f3ea20a6b50b58f # v1.2.1
        with:
          github_token: ${{steps.generate_token.outputs.token}}
        env:
          AQUA_GITHUB_TOKEN: ${{github.token}}

Other related code such as local Registry
main.tf
module "service_accounts" {
  source  = "terraform-google-modules/service-accounts/google"
  version = "4.2.2"

  for_each = local.service_accounts

  project_id    = var.project_id
  names         = [each.value.unique_name]
  project_roles = each.value.roles
  display_name  = "${each.value.name} for ${each.value.repo}"
  description   = "${each.value.description} for ${each.value.repo}"
}

GitHub Actions' log
 /home/runner/.local/share/aquaproj-aqua/bin/reviewdog -f rdjson -name tflint -filter-mode nofilter -reporter github-check -level warning -fail-on-error 1
reviewdog: Reporting results for "tflint"
Error: [tflint] reported by reviewdog 🐶

Raw Output:
location:{path:"main.tf" range:{start:{line:26} end:{line:26}}} severity:ERROR source:{name:"tflint" url:"https://github.com/terraform-linters/tflint"} code:{}
Error: "tflint failed"

this error is not properly logged in the job. i had to run the tflint cmd locally to find the issue
tflint --format json --modules
{"issues":[],"errors":[{"summary":"\"service_accounts\" module is not found. Did you run \"terraform init\"?","message":"","severity":"error","range":{"filename":"main.tf","start":{"line":26,"column":1},"end":{"line":26,"column":26}}}]}

Expected behaviour
should test the module without error
Actual behaviour
getting an error in tflint step
Important Factoids
No response
Note
added

      - name: terraform init
        run: terraform init --upgrade
        working-directory: ${{matrix.target}}

to fix the issue

Thank you for your report!
https://github.com/terraform-linters/tflint/blob/66c7be71b6b18bbd4cd93ce843098acd5dc74642/terraform/loader.go#L126-L141
As you said, we have to run terraform init before running tflint.

@rochana-atapattu
Could you try the prerelease version v1.2.2-1?

https://github.com/suzuki-shunsuke/tfaction/pull/1578

If there is no problem, I'll merge the pull request and release v1.2.2.

tested with the patch and the pipeline was successful. thank you for the quick response.

📝
test-module ran terraform init at tfaction v0.7.1 or older, but at v1.0.0 we changed test-module not running terraform init.
I forgot the reason of the change, so I checked the change log.

https://github.com/suzuki-shunsuke/tfaction/pull/1291

https://github.com/suzuki-shunsuke/tfaction/commit/d45bc33abd2cc06dac778c7a4544b2763810f0b3#diff-28f39e848ef8e864686c1149256dcf52c6cc7d3c7538d07c36148e0228f0790b
https://github.com/suzuki-shunsuke/tfaction/pull/1341

Unfortunately, I couldn't see the description about this change, but
I don't think we have the strong reason.
Probably we thought we don't have to run terraform init to test a Module.
I don't think there is any problem to run terraform init in test-module, so we can accept the change.

v1.2.2 is out 🎉
https://github.com/suzuki-shunsuke/tfaction/releases/tag/v1.2.2


Add deploy

Let's rename node app.js to node index.js  in server/package.json

Small suggestions after review:

Rename Server with client-side hot-reload → Server with client-side watcher in README.md. We haven't hot-reload with page refresh
Later we will arrange to rename scripts build:region → prebuild:region . I wrote it in issue https://github.com/browserslist/browsersl.ist/issues/353#issuecomment-1213701632

We can test NODE_ENV=production by running pnpm ssdeploy run.
This will be enough?

Thanks for the PR!
P.S. I thought the CI code would be much harder to read. But everything is clear.

build:region → prebuild:region

npm scripts have special logic for all scripts with pre prefix.
If you run a script, prea will be runned before.


Possible enhancement: Deepspeech runtime

I would like to ask for your opinion on the following deepspeech runtime for deepspeech related actions.
I tried to be consistent with Python AI Action. You can follow "Python 3 DS Action" into the links and the example.
https://github.com/5g-media/incubator-openwhisk-runtime-python/tree/deepspeech
Perhaps it can be contributed aside of Python 3 AI Action or as part of it?
Thanks.

Link is not active.


I think these should use occurs_in. See: https://github.com/geneontology/termgenie/issues/71
[Term]
id: GO:0021864
name: radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic division of radial glial cells in the developing forebrain." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0051301 ! cell division
relationship: occurs_in CL:0000681 ! radial glial cell
relationship: part_of GO:0021846 ! cell proliferation in forebrain

[Term]
id: GO:0021865
name: symmetric radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic division of a radial glial cell giving rise to two new radial glial cells in the forebrain." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021864 ! radial glial cell division in forebrain

[Term]
id: GO:0021866
name: asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic cell division of a radial glial cell giving rise to a radial glial cell and another cell type." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021864 ! radial glial cell division in forebrain

[Term]
id: GO:0021867
name: neuron-producing asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The unequal mitotic division of a radial glial cell in the forebrain that gives rise to a radial glial cell and a post-mitotic neuronal progenitor." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021866 ! asymmetric radial glial cell division in forebrain

[Term]
id: GO:0021868
name: ventricular zone cell-producing asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The unequal mitotic division of a forebrain radial glial cell that gives rise to a radial glial cell and a ventricular zone cell." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021866 ! asymmetric radial glial cell division in forebrain

[Term]
id: GO:0021869
name: forebrain ventricular zone progenitor cell division
namespace: biological_process
def: "The mitotic division of a basal progenitor giving rise to two neurons." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0051301 ! cell division
relationship: part_of GO:0021846 ! cell proliferation in forebrain

[Term]
id: GO:0021870
name: Cajal-Retzius cell differentiation
namespace: biological_process
def: "The process in which a neuroblast acquires specialized structural and/or functional features of a Cajal-Retzius cell, one of a transient population of pioneering neurons in the cerebral cortex. These cells are slender bipolar cells of the developing marginal zone. One feature of these cells in mammals is that they express the Reelin gene." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021895 ! cerebral cortex neuron differentiation
intersection_of: GO:0030154 ! cell differentiation
intersection_of: results_in_acquisition_of_features_of CL:0000695 ! Cajal-Retzius cell

[Term]
id: GO:0021871
name: forebrain regionalization
namespace: biological_process
def: "The regionalization process resulting in the creation of areas within the forebrain that will direct the behavior of cell migration in differentiation as the forebrain develops." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:isa_complete, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0003002 ! regionalization
relationship: part_of GO:0030900 ! forebrain development

[Term]
id: GO:0021872
name: forebrain generation of neurons
namespace: biological_process
def: "The process in which nerve cells are generated in the forebrain. This includes the production of neuroblasts from and their differentiation into neurons." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06]
comment: This term was added by GO_REF:0000021.
synonym: "generation of neurons in forebrain" EXACT [GOC:curators]
is_a: GO:0048699 ! generation of neurons
relationship: part_of GO:0030900 ! forebrain development

[Term]
id: GO:0021873
name: forebrain neuroblast division
namespace: biological_process
def: "The division of a neuroblast located in the forebrain. Neuroblast division gives rise to at least another neuroblast." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06]
comment: This term was added by GO_REF:0000021.
is_a: GO:0055057 ! neuroblast division
relationship: part_of GO:0021872 ! forebrain generation of neurons

Reported by: cmungall
Original Ticket: geneontology/ontology-requests/11756

The first set of terms could probably be GO-CAM models, and be obsoleted. ZFIN has 1 annotation to each of the first two terms; other terms are not used:
[Term]
id: GO:0021864
name: radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic division of radial glial cells in the developing forebrain." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0051301 ! cell division
relationship: occurs_in CL:0000681 ! radial glial cell
relationship: part_of GO:0021846 ! cell proliferation in forebrain
[Term]
id: GO:0021865
name: symmetric radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic division of a radial glial cell giving rise to two new radial glial cells in the forebrain." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021864 ! radial glial cell division in forebrain
[Term]
id: GO:0021866
name: asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The mitotic cell division of a radial glial cell giving rise to a radial glial cell and another cell type." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021864 ! radial glial cell division in forebrain
[Term]
id: GO:0021867
name: neuron-producing asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The unequal mitotic division of a radial glial cell in the forebrain that gives rise to a radial glial cell and a post-mitotic neuronal progenitor." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021866 ! asymmetric radial glial cell division in forebrain
[Term]
id: GO:0021868
name: ventricular zone cell-producing asymmetric radial glial cell division in forebrain
namespace: biological_process
def: "The unequal mitotic division of a forebrain radial glial cell that gives rise to a radial glial cell and a ventricular zone cell." [GO_REF:0000021, GOC:cls, GOC:dgh, GOC:dph, GOC:jid, GOC:mtg_15jun06, PMID:16226447]
comment: This term was added by GO_REF:0000021.
is_a: GO:0021866 ! asymmetric radial glial cell division in forebrain

The other terms seem OK to me - @sabrinatoro (+ anyone else) what do you think ?
Thanks, Pascale

@pgaudet
It looks like I can re-house this annotation using a GO-CAM model using the GO term "symmetric cell division: (GO:0098725) and creating relationship to "radial glial cell" and forebrain.
I will assign this case to me so it is on my radar of things to do. I'll let you know when it is done (probably tomorrow)

@pgaudet : done! these terms can be obsoleted.

Obsoletion notice sent.

GO:0022014


update vep examples mouse strains prf103

update VEP examples for mouse strains

I tested these strains with rsIDs input, both VEP and instant VEP failed because of no variation database. So I did the same to remove VEP_ID from my PR https://github.com/Ensembl/public-plugins/pull/423

When the ini files for mouse strains were first created the VEP input data was just copied from mouse. I now ran the generate_vep_examples script for the mouse strains. Mouse strains don't have variation databases and hence no rsIDs. And we don't support pileup format anymore, at least it isn't an option on the tools interface.

Thank you @at7 and @aparton


fix: remove redundant slash in path

Details

Remove redundant slash in path to avoid app crash in mobile browser
Fixed Issues

$ https://github.com/Expensify/App/issues/41806
PROPOSAL: https://github.com/Expensify/App/issues/41806#issuecomment-2112144415
Tests

Access the root domain with extra slash, e.g https://staging.new.expensify.com//, https://<IP_ADDRESS>:8082//
Expected: Web app shouldn't crash, user can login

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
N/A

Android: mWeb Chrome

https://github.com/Expensify/App/assets/165644294/8d1415e0-7713-4e89-b2e2-6d8f0ebc3f57

iOS: Native

N/A

iOS: mWeb Safari

https://github.com/Expensify/App/assets/165644294/00ace80f-e668-4fe6-8525-3496de775300

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/165644294/d7be99f7-f683-4465-818d-9be64afd4608

MacOS: Desktop

N/A

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[change] Reduce logs volume

Summary
Currently, we're printing way too many debug logs. Those logs are hardly useful to anyone unless they're developing redis-memo.
We can simply remove those Redis logs and display an overall query latency.

add time elapsed
:mag_right: Click to see changes since last update.

fix spec
:mag_right: Click to see changes since last update.

adjust duration fp format
:mag_right: Click to see changes since last update.

update
:mag_right: Click to see changes since last update.

fix rubocop
:mag_right: Click to see changes since last update.


🌐 Language request: Swedish

🌐 Language name (native)
svenska
🌐 Language code
sv-SE

Added. Thanks for your contribution :)


[CI] Pin libomp to 11.1.0

Works around #7039 by using libomp 11.1.0 in CI.

@trivialfis This should fix the problem where OpenMP runtime hangs or crashes.


[LLC] refactor 'WritePageableLongRunningOperationMethod' method

The 'WritePageableLongRunningOperationMethod' in src/AutoRest.CSharp/LowLevel/Generation/LowLevelClientWriter.cs is a long method and have some duplicate code comparing with normal LRO operation method 'WriteLongRunningOperationMethod'.
Need to refactor this method to divide it and resolve duplicatation.

Close since:

It's covered by #2552
It has been cleaned up recently, so the codes are not as bad as before.


x/build: add playground to build.golang.org

Currently running trybots for x/playground produces this:
https://storage.googleapis.com/go-build-log/2d26a65f/linux-amd64_e35969e6.log
Add Playground to build.golang.org.
Make builders be able to test Playground in the its docker container.

You should also add it to build.golang.org :smile:

@andybons, is there any good doc describing how trybots work besides https://go.googlesource.com/build/ ?

Good question. @bradfitz ?

Something is not clear. We have to test Playground via it's docker container. But where should we run that? I think it does not make much sense to run it on many platforms. Also I fail to find repos tests in similar fashion, but running not a go test ./... but rather docker container which will take more than 10 minutes to build from scratch. I will dig further a bit later...

Yes, we have no way to do this right now. That's why it's not a good starter project. This will be a lot of work and require a number of changes across our build system.

Rough outline, though:

make a new misc-playground builder (similar to misc-compile-*).
make a new host type in x/build/dashboard/builders.go etc that's VM-based, not container-based. Probably can resurrect docker2boot, which we used to use before Kubernetes. (we don't want to use Kubernetes here because docker build on Kubernetes remains a mess: https://github.com/kubernetes/kubernetes/issues/1806 etc)
make a "go test" friendly test that runsexec.Command("docker", "build") etc if `os.Getenv("GO_BUILDER_NAME") == "misc-playground"
add some special cases for which tests to run in dashboard/builders.go and cmd/coordinator, like some of the others clarifying which repos run on which builders.

We just open sourced a tool today to make docker build on kubernetes less of a mess: github.com/GoogleCloudPlatform/kaniko

Resolving this issue should be easier now compared to 2018 for at least one reason: thanks to module mirror, additional non-golang.org/x dependencies will no longer be a problem to fetch.
I'm not if something Docker-related also needs to be done, but @toothrot may have more context.
/cc @toothrot @findleyr

The integration tests changed in #25224 to require two docker containers running in a docker network, and also require the ability to run runsc, which requires root. I have a few ideas on how we can get good coverage, but the current state the TryBots and the Playground's test setup will require a little work.

Post-submit builders for x/playground have been added in LUCI, for example:
https://ci.chromium.org/p/golang/g/x-playground-gotip/console
(There are more dashboards for release branches and with different commit order if you search for "x/playground" in the https://ci.chromium.org/p/golang list.)
I filed #66002 for getting additional tests to run,
and #66001 to opt-in x/playground for automated golang.org/x updates.


Data not processing

Whenever i try and process data on the train tab there is always an error and nothing would appear in the output box.

Are there any fixes to this? so far I have found nothing to fix the problem.

My Computer
no space


Clarify GPU driver copy for nvidia docker images

user:
@dwhitena Hi Daniel  pachctl version 1.5.3. Yes, that's right, the process is running and producing output as it should ( a model) but it's just not making use of the gpu
[9:34]
and yes, it is running on the correct node
[9:37]
No idea if the problem is actually the docker image since running:
docker run -it dwhitena/pix2pix /bin/bash
to enter the container and then running:
python pix2pix.py --mode train --output_dir ./out --max_epochs 5 --input_dir /shared/ --which_direction BtoA
results in the error:
E tensorflow/stream_executor/cuda/cuda_driver.cc:509] failed call to cuInit: CUDA_ERROR_NO_DEVICE
user:
what base docker image are you uusing? (edited)
Daniel Whitenack [10:22 AM]
it uses this image: https://github.com/affinelayer/pix2pix-tensorflow/blob/master/docker/Dockerfile, which uses nvidia/cuda:8.0-cudnn5-devel-ubuntu16.04 as a base image.
GitHub
affinelayer/pix2pix-tensorflow
pix2pix-tensorflow - Tensorflow port of Image-to-Image Translation with Conditional Adversarial Nets https://phillipi.github.io/pix2pix/
[10:22]
checking some previous messages related to nvidia images.
user:
ok, we use the same one
Daniel Whitenack
[10:22 AM]
Ah, and it works ok?
user:
you need to copy over the cuda drivers
Daniel Whitenack
[10:22 AM]
Gotcha, yeah, I figured it might be something like that.
user:
    "stdin":[
        "cp -d /rootfs/usr/lib/x86_64-linux-gnu/libcuda.* /usr/lib/x86_64-linux-gnu/ && cp -d /rootfs/usr/lib/x86_64-linux-gnu/libnvidia* /usr/lib/x86_64-linux-gnu/",
            "python ..."

(edited)
Daniel Whitenack
[10:23 AM]
Perfect! Thank you so much!
user:
aah, thanks!
user:
ya, took us a while to figure that out

It should be easier to add the paths and add them onto LD_LIBRARY_PATH colon delimited ... e.g.
LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/rootfs/usr/lib/..."

Instead of actually copying the files.

Yes, I agree with @sjezewski here.  But maybe we should make this clearer in our docs.

adding paths to LD_LIBRARY_PATH doesn't work

Yea I remember you mentioning that when we were debugging this.
I believe you, but I don't see why that should be true. If we're going to recommend a change, first we should try and reproduce and understand why that is. We went to a considerable amount of effort to make this work in a way so that users don't have to copy drivers over.
If that is required in this case for some reason, I'd like to understand why.
Our goal here was to make this easy for users. I'd like your use case to be handled just as easily.

It sounds like this is more than a docs issue and actually that we need to do more testing with GPU resources and getting the drivers to work for various setups

I believe our recommended method of using GPUs has changed, so I'm calling this stale and closing the issue.


Always blocked

Hi,
First of all, thanks for this amazing code.
I'm trying to use it with a proxy but 100% of times it says that the IP is blacklisted.
It happens also to you?
My code:
import requests
from pylinkedin.scraper import LinkedinItem
from pylinkedin.utils import CustomRequest

while True:
    url = "http://gimmeproxy.com/api/getProxy"
    querystring = {"get":"true","supportsHttps":"true","anonymityLevel":"1", "protocol":"http"}
    r = requests.request("GET", url,  params=querystring)
    res = r.json()
    proxy = res['curl']
    c = CustomRequest(list_proxies=[{'https':proxy}])
    try:
        LinkedinItem(url = 'https://www.linkedin.com/in/kennethreitz')
    except:
        pass

Thanks for your comments
Indeed Linkedin has a really agressive anti scraping policy. I think LinkedIn is blacklisting the block of ips of cloud providers (Aws, DigitalOcean ...). Even for residential ips it seems that after 2 or 3 requests you ip will be banned.
Just try a simple requests.get('https://www.linkedin.com/in/kennethreitz') and look at the response and status code with the proxy. LinkedIn has a custom 999 status code for scraping.

It's curious, using different proxies always I get a 999 error.
Getting a cookie from a web browser and adding it to your code it works with the proxies used before. So Linkedin probably detects that the request don't come from a web browser...

Interesting !  did you pass your own session cookie (the one linked to your linkedin profile) ? I know LinkedIn can deactivate if you scrape while being connected (using selenium, phantomjs ...)
I also didn't test the code with proxies but it doesn't seem the issue comes from the code but likeley from Linkedin itself.

I used an anonymous session cookie and I could scrape ~50 profiles with this session.
Maybe they're detecting if it's a browser or not who make the request with javascript.

I am having the same problem. But I worry that it is on Linkedin's side.
If I just open firefox (no linkedin cookies) and go to the test profile (https://www.linkedin.com/in/kennethreitz) it requests my credentials. I do not pass the request any login cookies (maybe if I did it would work?) But I think there is a limit to that. As soon as Linkedin detects a user viewing even 50 profiles/hour they may blacklist you as a user.
Any thoughts on this?

@ericfourrier I've had similar problems and linkedin authwalls were persistent, I find your work very helpful. I currently use it over proxycrawl API to avoid blocks, so instead of making a get request to linkedin directly, I make a request to that API which gives me the data. That is the only way I could do it right now. Thanks for the tool.


[WIP] Parallel Bayesian Optimization

Implementation of the parallel Bayesian optimization algorithm proposed by:

Snoek et al. 2012, Practical Bayesian Optimization for Machine Learning

Project Tracking:

[x] Locate positions to add new functions
[ ] Add fantasizing procedures before calculating EI
[ ] |— 1. Edit gaussian_ei
[ ] |— 2. Edit fant_predict
[ ] |— 3. ...
[ ] Test fantasizing behavior
[ ] Build/check connections to other base_estimators
[ ] Edit docstrings
[ ] Connect to external sampler
[ ] (?) Add internal sampler file
[ ] Test overall behavior
[ ] Edit docstrings

Codecov Report

Merging #445 into master will decrease coverage by 0.76%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   86.39%   85.63%   -0.77%
==========================================
  Files          22       23       +1
  Lines        1558     1573      +15
==========================================
+ Hits         1346     1347       +1
- Misses        212      226      +14

Impacted Files
Coverage Δ

skopt/optimizer/base.py
94.82% <ø> (ø)
:arrow_up:

skopt/optimizer/pgp.py
0% <0%> (ø)

skopt/optimizer/optimizer.py
93.71% <100%> (ø)
:arrow_up:

skopt/acquisition.py
95.87% <75%> (-0.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b0ac1...970e36b. Read the comment docs.

The computation of the acquisition function in this algorithm is quite different from existing constant liar. Therefore the original prediction function inside the gp file has to change in order to meet this need.
My first question is: is it ok to write a new function inside the gp class (I'm naming it fant_predict) or it's better if we just write a separate function in the Optimizer?
Second: is it better if we still add this feature to the original gaussian_ei function or create a new maybe gaussian_ei_fant function?

Never mind the previous questions. Just realized the right places to implement should be:

Add fantasizing behavior inside the ask function instead of gaussian_ei or predict
Then go on reset y_opt and X to new values

I have a doubt in the prediction function within the GaussianProcessRegressor class.
The original Snoek et al. 2012 paper searches for the global optimal vector (x_n+1, x_n+2, x_n+3, ...) as a whole: stack all pending evaluation points on top of all the evaluated points, calculate Cholesky decomposition and variance based on the new stacked data, truncate the new variance for further fantasizing behaviors...
As our ask-and-tell API, we take a "pseudo-sequential greedy" strategy (as stated in the Kriging is well-suited... paper), which sequentially lie and tell over all points. This makes it less intensive in the case where we have large q compared to the approach where we compute it as a whole. However, in the prediction we restrict n_samples to 1. I think to implement this new feature, we have to add support for n_samples > 1.
So I'm just wondering if there're some other concerns about implementing support for multi-points when writing this restriction, since I could not track the development of this function down from closed PRs. :)

Close to fix the branching issue. Will open a new one soon.


Remove menu

Fixed #745
After Changes:

The simulation menu does not show up anymore, but you deleted the "edit" menu on the far left by accident :)

Thanks for the effort, but I'll close this as there has been no more activity. Please reopen if you plan to continue working on this.


Documentation pages C# examples referencing the wrong (old?) assembly

Hi,
When trying to set Fontwheight in codebehind on a RichTextBlock, I noticed that the c# examples in your documentation are referencing a non-existent assembly. For someone that has not been working with the Windows App SDK for long, this is confusing and slows down development pace.
I noticed this on two of the pages, but I suspect there are more.
https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.richtextblock?view=windows-app-sdk-1.1
https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.text.fontweights?view=windows-app-sdk-1.1
Although the correct namespace is listed several places on the page, the example uses a wrong (old) one:
textBlock1.FontWeight = Windows.UI.Text.FontWeights.ExtraBlack;
should be:
textBlock1.FontWeight = Microsoft.UI.Text.FontWeights.ExtraBlack;
Best regards,
Torgeir

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e750e3d0-fe2d-30c2-a8a3-b8a1f99cbd07
Version Independent ID: e750e3d0-fe2d-30c2-a8a3-b8a1f99cbd07
Content: FontWeights Class (Microsoft.UI.Text) - Windows App SDK
Content Source: winapps-winrt-build/xml/Microsoft.UI.Text/FontWeights.xml
Product: reunion
Technology: reunion-reference
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks for letting us know about this error. A PR has been submitted to update these docs, and we'll check for this issue in other docs.


Feature/examples/grpc bridge in 3 steps

Description

Simplified gRPC bridge example into a fully-dockerized solution in 3 steps.
Upgraded Go to 1.13
Using simpler Docker images
Split into 4 containers for newcomers

The step-by-step now is on the REDME.md
Risk Level
None
Testing

Build Protos

docker-compose -f docker-compose-protos.yaml

Build Client and Server Containers

docker-compose up --build

Execute tests

$ docker exec grpc-bridge_grpc-client_1 /client/grpc-kv-client.py set foo bar
setf foo to bar

$ docker exec grpc-bridge_grpc-client_1 /client/grpc-kv-client.py get foo
bar

Docs Changes

Only README on the repo with detailed information

Release Notes
gRPC bridge example simplified with a Dockerized solution executed in 3 steps

Thank you so much for adding an example!!!

@mattklein123 no problem! I hope it helps others learning Envoy! This is my day 3 :)

@snowp Thank you for reviewing it!!!

@snowp @mattklein123 let me know if you guys need anything else on this!

Can you look into the CI failures? I think at least the format one is due to this change

@snowp yeah I can see there's an error the docs format check does... It just doesn't say what the format error is :) I will dig into all the build errors and get back to you tonight (PST)

@snowp I'm guessing those are tab related changes on the format...

CI seems to be failing due to
ERROR: missing input file '//examples:grpc-bridge/config/s2s-grpc-envoy.yaml'
ERROR: missing input file '//examples:grpc-bridge/config/s2s-python-envoy.yaml'

@snowp Those configs were the ones renamed to the new dir... I couldn't see that error about the files... Thanks for pointing me to them

@snowp I fixed all the test cases, finally!!! Ready to go!!! ✌

@mattklein123 Thank you for Enovy :) It would be cool to get a PR merged during the kubecon 👍

@snowp awesome! Thank you! I can talk more about what we are building at Intuit 👍 specifically on gRPC... I'm at the Envoy summit... My computer is about to die :P


Open Street View

I can see that there is a way to add the pegman to the control, but is there a way to open streetview by default instead of the map?

You could use onGoogleApiLoaded to load StreetView by default. In your react component write a method to call:
`
initStreetView({map, maps}) {
var sv = new maps.StreetViewService();
var panorama = new maps.StreetViewPanorama(document.getElementById('map'));
sv.getPanorama({location: {lat: 37.869, lng: -122.254}, radius: 50}, processSVData);
    function processSVData(data, status) {
        var marker = new maps.Marker({
            position: data.location.latLng,
            map: map,
            title: data.location.description
        });
        panorama.setPano(data.location.pano)
        panorama.setPov({
            heading: 270,
            pitch: 0
        });
        panorama.setVisible(true);
    }
}

`
Which you can call after Google API loads:
<GoogleMap bootstrapURLKeys={{key: APIKEY}} onGoogleApiLoaded={this.initStreetView} />

Implementing this solution works but we got this console error log :
js?callback=_$_google_map_initialize_$_&key=:42 Uncaught TypeError: Cannot read property 'style' of null     at new _.hw (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/common.js:186:165)     at x3 (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/streetview.js:81:497)     at Object._.k.cn (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/streetview.js:148:133)     at https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:115:2696     at Object._.F (https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:48:454)     at rf.visible_changed (https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:115:2648)     at Ab (https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:40:342)     at rf._.k.set (https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:99:735)     at rf.setVisible (https://maps.googleapis.com/maps/api/js?callback=_$_google_map_initialize_$_&key=:50:342)     at processSVData (eval at <anonymous> (http://<IP_ADDRESS>:8050/static/build/dev/main.js:3886:2), <anonymous>:318:26)     at rm.T2 (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/streetview.js:55:251)     at rm.Cn (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/common.js:26:185)     at Object.c [as _xeisu0] (https://maps.googleapis.com/maps-api-v3/api/js/27/4/intl/fr_ALL/common.js:44:404)     at https://maps.googleapis.com/maps/api/js/GeoPhotoService.SingleImageSearch?p…2!4m10!1e1!1e2!1e3!1e4!1e8!1e6!5m1!1e2!6m1!1e2&callback=_xdc_._xeisu0:1:28_.hw @ common.js:186x3 @ streetview.js:81_.k.cn @ streetview.js:148(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:115_.F @ js?callback=_$_google_map_initialize_$_&key=:48rf.visible_changed @ js?callback=_$_google_map_initialize_$_&key=:115Ab @ js?callback=_$_google_map_initialize_$_&key=:40_.k.set @ js?callback=_$_google_map_initialize_$_&key=:99(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:50processSVData @ OverviewPage.jsx?28f6:277T2 @ streetview.js:55(anonymous function) @ common.js:26c @ common.js:44(anonymous function) @ GeoPhotoService.SingleImageSearch?pb=!1m5!1sapiv3!5sUS!11m2!1m1!1b0!2m4!1m2!3d37.869!4d-122.2547000…:1 util.js:211 Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keysWA.j @ util.js:211(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:129(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:49(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:46(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:49_.F @ js?callback=_$_google_map_initialize_$_&key=:48(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:49_.v @ js?callback=_$_google_map_initialize_$_&key=:34mc @ js?callback=_$_google_map_initialize_$_&key=:49(anonymous function) @ js?callback=_$_google_map_initialize_$_&key=:129
This problem seems to be due to the map div not being rendered before the javascript runs that needs to access it.

up ?

Any answer for this? I'm just getting started with the package and need this functionality.

It is not the intent of this library to support every part of google map API, my life is to short for this ;-)
Please read first sentences in READMe.
So just check the proposed solution from above or use google map api directly if it does not work for some reason.

may I know where did u get this.refs.panorama?
I tried
<GoogleMap
        ref={'panorama'}
        {...others}
/>

but not working


truncate versions with humen names when setting the ios version string

I like giving versions a humen readable/memorable name like '1.0.1-pizza-train'
iOS does not like anything except numbers and 3 periods.
Can you make this package truncate the version name after and including the dash before setting it inside the ios specific file? so that the version name is preserved for android (and web) but is corrected for iOS?

Related to #41
We might be able to include your "pizza train" into the CFBundleVersion, which accepts more than CFBundleShortVersionString.

That would be a nice to have, for sure.

Any progress?


Google pack html5lib version set

Google
Status

bugfix

Description
Updating Google pack to include html5lib
Checklist (tick everything that applies)

[x] Metadata: pack.yaml, icon, structure (required for new packs)
[x] Version bump (required for changed packs)
[x] Code linting (required, can be done after the PR checks)
[x] Tests (not required but really recommended)

Fixes #525

LGTM :+1:


addtwoints_server: correct node name

Happened to notice it.
Perhaps copy-paste from the client implementation?

@mergify backport humble rolling


Microsoft Edge Sidebar and copilot doesn't work

Describe the bug
The sidebar and its part copilot don't work. The copilot button is unclickable. In general, it should be related problems.
Steps To Reproduce
Steps to reproduce the behavior:

Instal Microsoft Edge
Run Edge

Expected behavior
When I run edge I want to get to the right panel and copilot access.
Screenshots

Notify maintainers
@zanculmarktum
@kuwii
@rhysmdnz

Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.52, NixOS, 24.11 (Vicuna), 24.11pre686457.4471f9f67fe0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

I've tested on stable and unstable fresh installs. It doesn't work from the box.

+1, but on Fedora. I think this is an issue with the application rather than the packaging.

I cannot reproduce this. Perhaps there's a unique environment setup that's causing this issue.
I use Sway and I do not have any trouble selecting either Copilot or any of the other side-bar buttons at all.

Arch linux, the same issue.

This seems to widely appear across multiple Linux distributions. I can reproduce this even using the official deb package in Ubuntu.
So I think this should be an issue of Edge itself.

I have same isue on Linux mint

I can reproduce it on Ubuntu 22.04

I'm having problems with both the SideBar, and even going to chat.bing.com - the latter simply displays a blank window saying "To use CoPilot, please go to Microsoft 365 App". This is in Microsoft Edge for Linux (on both Ubuntu 20.04 and 22.04). Problem started on 1st October 2024. Think there was an update to CoPilot at the end of September 2024 which may be causing the problems.

I can open, and use the Copilot sidebar on Edge Version 129.0.2792.79 (Official build) (64-bit) on RHEL 8.9.
Logged in with an MS work account.
Hope that helps the triage

I am on Arch Linux, and I have tried both beta, and dev version of edge. The copilot and sidebar apps doesn't work.

any update on this issue ?

I had the same issue as well, The solution for me was to downrade to 129.0. -> open the app and try to add a webiste (It might be helpful to mention that it took some time to load the default sidebar websites) then I upgraded back to the latest release after some testing with 130.0.
I suggest, if that didn't work to downgrade to an even older release or try using the flatpak version.
(It worked on the microsoft-edge dev version from flatpak)

I had the same issue as well, The solution for me was to downgrade to 129.0. -> Open the app and try to add a website (It might be helpful to mention that it took some time to load the default sidebar websites) then I upgraded back to the latest release after some testing with 130.0.
I suggest, if that didn't work to downgrade to an even older release or try using the flatpak version.
(It worked on the Microsoft-edge dev version from flatpak)
Edit: hope I helped

Would share the download link for that version ?

The problem is the Office 365 Business version; I can use the Personal version of CoPilot, but the one integrated into Microsoft 365 Business fails with the message "To use Copilot, please go to Microsoft 365 app" with links to iPhone or PlayStore downloads. Everything else in Office 365 Business functions normally. The problem persists with Firefox and Chrome.
The only solution I've found is to run Microsoft Edge inside a WINE container (I'm using CrossOver) - CoPilot then functions normally.

Same on Opensuse Tumbleweed through the official RPM build.
But working as expected on Kubuntu and Arch Linux for me.

Rather weirdly, copilot has suddenly started working normally today on my Ubuntu 20.04 box on both Edge and Chrome.  Given no changes to any locally installed software,  I'm starting to suspect it's a Microsoft issue.

it still doesn't work for me :disappointed:

Running latest version of MS Edige (Version 130.0.2849.52 (Official build) (64-bit)) on
Debian GNU/Linux 12 (bookworm)
Gnome 43.9 on X11
When I click the Copilot button nothing happens.
But, if you opent the Browser-Essentials -- it'll open in the "sidebar"
now, click the Copilot button (upper right corner) and Browser Essentials disappears.
Found this odd setting that is related:

Originally that was set to [Off] but turning it still does not fix it.
However, if you now click the [+] (Plus button in the sidebar) you'll see a "Customize" panel.
Now, if you click the Copilot button while the Customize panel is displayed, then clicking the Copilot button will close the Customize panel.
The point is that clicking the Copilot button does indeed do something (fires some functionality), but not the right thing.

I figured it out. The HubApps file is missing in ~/.config/microsoft-edge/Default. I copied the file from another computer running windows; C:\Users[USER]\AppData\Local\Microsoft\Edge\User_Data\Default ;  and that fixed the side-bar and Co-Pilot. I can use Drop, co-pilot and everything again. I am not sure why that file is missing on all the Linux installs now. Hope this helps.

@AppleSeedTrees that works on mine too, Arch Linux 6.11.5-arch1-1 with local/microsoft-edge-stable-bin 130.0.2849.56-1,
the HubApps file is missing from the new profile, but it will survive microsoft-edge upgrade, I downgrade to 126 (which works fine, then upgrade to 130, and still fine, but when i create new profile in 130, the sidebar didnt works)

I think all the hubapps file is the same ? (i attach HubApps file, just remove the .txt, github doesnt support uploading it)
HubApps.txt

Thank you! It works for me! Did you report to microsoft?

@AppleSeedTrees that works on mine too, Arch Linux 6.11.5-arch1-1 with local/microsoft-edge-stable-bin 130.0.2849.56-1,
the HubApps file is missing from the new profile, but it will survive microsoft-edge upgrade, I downgrade to 126 (which works fine, then upgrade to 130, and still fine, but when i create new profile in 130, the sidebar didnt works)

I think all the hubapps file is the same ? (i attach HubApps file, just remove the .txt, github doesnt support uploading it)
HubApps.txt

This is working on Ubuntu 24.04

It works for me too (Ubuntu 24.04) :pray:
So I recap for those who may be confused:

Right click on the HubApps.txt file > Save link as
save the file in Home/.config/microsoft edge/Default
rename (remove) the .txt extension at the end of the file
restart microsoft edge

this issue is from Edge itself, please go to the right forum, maybe this link can help:
https://techcommunity.microsoft.com/discussions/EdgeInsiderDiscussions/ms-edge---sidebar-and-copilot-not-working-on-linux-ubuntu-v24-lts/4271812

Thanks to you all, but copying HubApps file in Home/.config/microsoft edge/Defaultit does NOT work for me...

@AppleSeedTrees that works on mine too, Arch Linux 6.11.5-arch1-1 with local/microsoft-edge-stable-bin 130.0.2849.56-1,
the HubApps file is missing from the new profile, but it will survive microsoft-edge upgrade, I downgrade to 126 (which works fine, then upgrade to 130, and still fine, but when i create new profile in 130, the sidebar didnt works)

I think all the hubapps file is the same ? (i attach HubApps file, just remove the .txt, github doesnt support uploading it)
HubApps.txt

Thanks, that works well for me in Fedora 41 running KDE

/.config/microsoft-edge/Default

thank you so much for this, it worked and solved my problem :)

I figured it out. The HubApps file is missing in ~/.config/microsoft-edge/Default. I copied the file from another computer running windows; C:\Users[USER]\AppData\Local\Microsoft\Edge\User_Data\Default ; and that fixed the side-bar and Co-Pilot. I can use Drop, co-pilot and everything again. I am not sure why that file is missing on all the Linux installs now. Hope this helps.

Thanks, it worked on Ubuntu 24.04

Issue still persists on my win11,

@AppleSeedTrees that works on mine too, Arch Linux 6.11.5-arch1-1 with local/microsoft-edge-stable-bin 130.0.2849.56-1,
the HubApps file is missing from the new profile, but it will survive microsoft-edge upgrade, I downgrade to 126 (which works fine, then upgrade to 130, and still fine, but when i create new profile in 130, the sidebar didnt works)

I think all the hubapps file is the same ? (i attach HubApps file, just remove the .txt, github doesnt support uploading it)
HubApps.txt

I don't know how should I thank you !!! thank you soooo much ! I was really curious why it isn't working and this file was the cause .

@AppleSeedTrees that works on mine too, Arch Linux 6.11.5-arch1-1 with local/microsoft-edge-stable-bin 130.0.2849.56-1,
the HubApps file is missing from the new profile, but it will survive microsoft-edge upgrade, I downgrade to 126 (which works fine, then upgrade to 130, and still fine, but when i create new profile in 130, the sidebar didnt works)

I think all the hubapps file is the same ? (i attach HubApps file, just remove the .txt, github doesnt support uploading it)
HubApps.txt

Yes, this works. The HubApps is missing and I think its edge problem not the packaging.


fails the build if java coverage is <80%

fixes #63

java 11 error is fixed in https://github.com/adobe/adobe-dx/pull/62, let's just wait for it to get in


Spark - schema registry integration - Initial version

Spark - schema registry integration and examples to illustrate the different usages.

cc @dongjoon-hyun

@dongjoon-hyun thanks for the review and feedback. I will add unit tests as a separate patch. I am figuring out how to run a test instance of schema registry and add tests based on that.


Priority setting has no effect

Describe the bug
It seams that the priority option has currently no effect? Is this a bug or a known issue?
For the case that i am just stupid, i got a Flux Plug connected to my energy generation. And multiple flux points, Flux point A with priority 0 draws all available power but i needed some power at point B where i set the priority to 1, which should provide power to that point first. But it doesn't.
To Reproduce
Build the above setup.
Expected behavior
Power being delivered to Point B first

You're right, it's a bug.


selftest hangs on flow.coffee

fails when I try to run coffeescript files
running Ubuntu 13.10 and coffeescript 1.7.1

Are you using phantomjs 2 ? If so, please see commmit b592a6434dcef24633b40c7688c667b8ea466cc7 concerning PR to n1k0#1137

@wefarrell, @Yurko-Fedoriv please include the engine type and version you are using (e.g. phantomjs -v or slimerjs -v) to clarify this issue. Thanks.

Closing due to insufficient information to be able to reproduce.


GRIP

Project Proposal Here

Alyona will still be on leave for this meeting, and we are still sorting out the charter and naming. Let's put this on hold.


The Schema covers the root elements of the value sets but ignores the structure of the records

Green: Are covered
Yellow: Are ignored (no rules for them)

In the current situation any json structure (object) is accepted as value for the valueSetValues property.
The structure of the actual values is well defined and the way it is consumed by all the application is already defined. An improved schema that will describe this in more details will prevent errors and ensure the quality.
References / Samples

Schema: https://github.com/ehn-dcc-development/ehn-dcc-valuesets/blob/release/2.1.0/valueset.json
Value set: https://github.com/ehn-dcc-development/ehn-dcc-valuesets/blob/release/2.1.0/test-result.json

Improve Schema

https://www.jsonschemavalidator.net/s/4OVqD3Bx

(Going through the issues.)
Seems like a good idea. Put that into 2.4.0?

Could we split that PR into two: 1. implement the validating Action, 2. improve the schema ?

Could we split that PR into two: 1. implement the validating Action, 2. improve the schema ?

@dslmeinte the PR #23 is updated. It introduces changes related just to the schema.
For the rest a new ticket and branch are prepared. A separate PR will follow

https://github.com/ehn-dcc-development/ehn-dcc-valuesets/issues/35

Hi @skounis, this is not my field of expertise (I am not an expert in json schema), so difficult to comment. Your approach seems to be logical, just please keep in mind that version string might be empty in some cases.
Hynek

Captured: https://github.com/ehn-dcc-development/ehn-dcc-valuesets/pull/23/files#r752373854

@kruzikh The schema required the existence of the property. The value could be just an empty string "" .


Error Handling Example

Is your feature request related to a problem? Please describe.
I'm trying to use this wonderful library in one of my project, but I'm not sure how to handle processor errors correctly.
At the moment if an errors occurs the processor.Cancel method is called, but how is it intended by the library to actually
handle these errors by the caller?
Describe the solution you'd like
There should be a simple way to return an error channel from the processor.
Describe alternatives you've considered
Alternatively we have to pass an error channel to all the processor we use in the pipeline and send an error to that channel in the process.Cancel method.
Additional context
At the moment I've created a special Result type to be used by all the processors. It has an Err and a Value fields.
But the code is very verbose:
type Result struct {
    Err error
    Value interface{}
}

func (p *SomeProcessor) Process(ctx context.Context, ins interface{}) (interface{}, error) {
	insSlice, err := toSliceOfInterfaces(ins)
	if err != nil {
		return nil, merry.Wrap(ErrCannotProcessDepositTxInput, merry.WithCause(err))
	}

	result := make([]interface{}, 0, len(insSlice))

	for _, in := range insSlice {
		res, err := ToResult(in)
		if err != nil {
			result = append(result, Result{
				Err:   errors.Wrap(ErrCannotConvertInterfaceToResult),
				Value: nil,
			})

			continue
		}

		foo, err := foo(res.Value)
		if err != nil {
			result = append(result, Result{
				Err:   errors.Wrap(ErrCannotRunFoo),
				Value: nil,
			})

			continue
		}

		bar, err := bar(ctx, foo)
		if err != nil {
			result = append(result, Result{
				Err:   errors.Wrap(ErrCannotRunBar),
				Value: nil,
			})

			continue
		}

		result = append(result, Result{Err: nil, Value: bar})
	}

	return result, nil
}

Any help or advice is appreciated.

Is this a similar issue to the one in #4?

Closed in favor of #4


Executable file missing from copied framework

This is an awesome project, thanks so much!
When using Xcode 9.2 to build, I'm seeing an issue where the executable file is missing from TwitterX framework after Xcode copies it into LauncherX/Contents/Resources, even though the executable is present in the framework built product.
I was able to fix this myself by copying the framework into LauncherX/Contents/Frameworks instead, and changing the twitterXFrameworkURL to point there.

Hi @lapcat 👋
Thanks for reporting. Could you please post the logs of that build?

I discovered that it only happens with the Debug build configuration, not Release configuration.
By trial and error, I found that the SWIFT_OPTIMIZATION_LEVEL build setting is what makes the difference, which is very bizarre. This may be an Xcode bug.


fix: Raise custom exception instead of ErrorStatus

Raise custom exception ExporterError instead of failing with ops.model.ModelError when restart_exporter fails.
Couple of points to note:

The exporter class doesn't need a pass statement as it's not needed. This was something I learned after hitting this lint error
This does NOT resolve issue #190. The config hook still fails in that situation but it's a better error message. Will be raising another PR for the actual fix to that issue.

The new error after this patch would look something like
unit-hardware-observer-5: 12:16:57 ERROR unit.hardware-observer/5.juju-log Failed to restart the exporter.
unit-hardware-observer-5: 12:16:57 ERROR unit.hardware-observer/5.juju-log Uncaught exception while in cha
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/./src/charm.py", line 344, in <module>
    ops.main(HardwareObserverCharm)  # type: ignore
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/main.py", line 451, in __call__
    return main(charm_class, use_juju_for_storage=use_juju_for_storage)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/main.py", line 436, in main
    _emit_charm_event(charm, dispatcher.event_name)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/main.py", line 144, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/framework.py", line 351, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/framework.py", line 853, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/venv/ops/framework.py", line 942, in _reemit
    custom_handler(event)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/./src/charm.py", line 224, in _on_config_changed
    self._on_update_status(event)
  File "/var/lib/juju/agents/unit-hardware-observer-5/charm/./src/charm.py", line 148, in _on_update_status
    raise ExporterError(restart_msg)
service.ExporterError: Exporter crashed unexpectedly, please refer to systemd logs...
unit-hardware-observer-5: 12:16:58 ERROR juju.worker.uniter.operation hook "config-changed" (via hook dispatching script: dispatch) failed: exit status 1

I would also like to hear about any other ways to handle this sort of issue where BlockedStatus wouldn't work since the user can't fix the exporter crash.

Didn't realize this change breaks a couple of unit tests. Will push the required changes to fix the unit tests soon.


⚠ St. Lawrence Global Observatory CKAN has degraded performance

In e0d5e00, St. Lawrence Global Observatory CKAN (https://catalogue.ogsl.ca/en/) experienced degraded performance:

HTTP code: 200
Response time: 7364 ms

Resolved: St. Lawrence Global Observatory CKAN performance has improved in 3478d0e after 5 minutes.


Be stricter about checking the deposited amount.

Specifically, rather than demanding that the deposited amount is at
least what is expected, demand that it is exactly what is expected.
The rationale for this is that, when we move to multiplexing
interactions on a single contract:

The interaction balance will have to be part of the merkelized state,
since we can't query the VM for it.
Therefore, participants will have to supply the correct value when
restoring that state.
So, if we allow participants to over-deposit, they could potentially
throw off that value from what is expected, introducing a possible DoS
vulnerability for the other participant unless we introduce some
fiddly logic to deal with the possibility. It seems simpler to catch
this up front.

I have confirmed that the downstream tests for glow still pass with this
change, in addition to the tests in this repo.

My rationale is that, as the contract operator, I always welcome free donations from clients---and that the overdepositing might be the mechanism by which the standard client pays fees.
"- But what if someone starts hacking a client not to pay fees?"
"- Well then, we could modify contracts to enforce the payment of fees"
"- But what if they then fork the entire codebase to avoid fees?"
"- Well, maybe we can keep avoid the enforcement costs and bank on people's general good will and laziness for now"

Looking at this again, I think my original reasoning isn't right -- this is just used to verify that the funds are actually there, but if the participant over-deposits, the balance as recorded in the merkelized state will still be as expected, so it isn't a problem.
That said, counterargument: if a participant is over-depositing, it is likely due to a bug in the compiler or runtime. We'd like to know about bugs, so it should fail loudly. Furthermore, while it's perhaps nice for the contract owner, if users are losing money because there's a bug in glow that's causing them to pay more than they're supposed to, they will most likely be unhappy when they find out.
I'll defer to your opinion on this.

Yes, but honest participants are presumably using our software that is correct by construction.
A contract cannot possibly protect a participant against the participant's own software being malicious or buggy, and trying to pretend otherwise can only lead to disappointment and/or higher GAS fees.
I'd vote not changing the check, but instead documenting this line of reasoning somewhere.

our software that is correct by construction.

It is absolutely possible for our software to have a bug; we'll do our best not to, but we're not writing this in Coq. (I've hit at least two since I've started working on glow). My argument is that this change will make it more likely that we catch such a bug early should that happen. The reasoning is the same as for this patch that we merged in glow:
https://gitlab.com/mukn/glow/-/commit/4ad3524fda0639e0517835a7ba09beaeefca4753
From the commit message:

...by using hash-ref instead of hash-get. Previously, this would just
return #f, which I discovered by step debugging through a contract and
noticing a bogus zero address on the stack -- let's make this fail
sooner and louder!

Had that patch already been in place, the bug I found would have been caught before I joined the team (since it would have thrown during codegen for our existing tests), and would have been very easy to track down.
I might feel differently if the check was more expensive than what we had before, or this introduced significant complexity.
That said, I won't die on this hill; my original reasoing for doing this doesn't actually apply, though I think it still makes sense for the reasons stated above. But if you feel strongly about this, feel free to close.

Yeah, the "finding bug in our own code" is a weak but valid argument. And if we want to mandate fees, it doesn't actually cost much to add them in our code in maybe a few tens of extra GAS max per transaction. But that also means we must burn the fee schedule in the contract, rather than make it something that we can tweak purely on the client side.

But that also means we must burn the fee schedule in the contract, rather than make it something that we can tweak purely on the client side.

Presumably if we want to demand fees for using a shared contract, that has to be enforced by the contract, no?

No, the contract doesn't have to enforce fees, especially since fees can easily be avoided by forking the code base. We'd rather people don't fork our contracts and make them uninteroperable, even if they decide to fork the clients to skimp on fees.

Although a dual point of view is that by requiring incompatibility to skimp on fees, we raise the bar on fee skimping.

Although a dual point of view is that by requiring incompatibility to skimp on fees, we raise the bar on fee skimping.

Furthermore, skimping on fees would require paying gas to start a separate instance of the contract, which would defeat the point (for small numbers of invocations anyway) -- which I thought was the value proposition.
That said, given that my original reasoning no longer applies, this doesn't seem worth spending this much time on debate -- it's a trivial patch that we can reproduce later if we find we do need it. So I'm going to go ahead and close.


Getting an error for the reason command

When I ban/Unban someone, It tells me to use the reason command.
I use !reason 2 Test for example and it says:
TypeError: Cannot read property '0' of undefined
Around the
        modLog.fetchMessages(caseLog.id).then(logMsg => {
            const embed = logMsg.embeds[0];
            embedSan(embed);

section
If anyone could help me get this working I'll be super delighted!
Thanks, DieselJS

Closing this issue due to no reply.

Yes I did btw.

Yea I used the dashboard, default config, set command. Still doesn't work, console shows no error but the bot replies with "Unable to find that case number", which is about line 10-25.


ScriptedPlugin: Add support for paginated tests (scripted foo/*1of3)

This is another issue like https://github.com/sbt/sbt/issues/2601 where ScriptedPlugin is less powerful than the internal Scripted used by sbt, which supports paginated tests which are very useful when running on a CI: https://github.com/sbt/sbt/commit/5d5d7a6c0551beaeefffce61638ac0c8c29e57ec

sure. Would you like to send in a PR?

On my way!


Uses AppendVecId in AccountsFIle::file_name()

Problem
Creating an AccountsFile file name takes in the ID as anything display-able. This is... strange... Since we know this should be an append vec id, we should use that type directly.
Summary of Changes
Use AppendVecId in file_name().

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.9%. Comparing base (8b66a67) to head (6ce1063).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage    81.8%    81.9%
=======================================
  Files         838      838
  Lines      227363   227363
=======================================
+ Hits       186187   186221   +34
+ Misses      41176    41142   -34

I think we should probably consider renaming AppendVecId to AccountsFileId.

Yep, definitely agree!

Created https://github.com/anza-xyz/agave/pull/383


Update cloudknox-howto-create-role-policy.md

Minor updates to make the doc consistent to the current UX, plus additional updates to the "Create a role for GCP" section.

@marcelodiiorio : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Rework plugin config system

Just an idea I had, can be merged if good and wanted, but can also be closed.
The advantage of this system is that updating the config is possible. New values can be added and user configs that already exist get the new values. Furthermore, this system would also allow removing values if they are no longer needed, if that ever happens.

Maybe Configurate could work, though I haven't used it before, only heard of it.
https://github.com/SpongePowered/Configurate


fix terminal tab selection not work porperly

Close #199927

@Tyriar Could you please take a moment to review this PR?


Can't send messages

Hey, thank you for your awesome work with this tool. I'm trying to implement this into the Qml version of FluffyChat for Ubuntu Touch. I can login, sync and decrypt messages but something is wrong with sending messages.
When sending messages in an encrypted room (in unencrypted its working fine) I send for example this:
[PUT]
/client/r0/rooms/!MlSuBbJLzKITNqowdb:tchncs.de/send/m.room.message/1592559364500
{"body":"7","msgtype":"m.text"}

With headers:
'Content-Type', 'application/json'
'Authorization', 'Bearer ' + token

But on Pantalaimon log-level debug side there is nothing and I never get a response.
Maybe you have an idea what I'm doing wrong here?

I think that's because the room contains unverified devices.
In the default configuration Pantalaimon won't let you send messages to a room unless all devices are verified, you can switch off verification in the config or you can verify the devices using Pantalaimon.

Yes that was it!
IgnoreVerification = True
And it works. Thank you very much :-)
Next step will be to implement a GUI for the verification step.


Notify

#652
ONLY TESTED ON ANDROID
Before
PhotoManager.addChangeCallback(changeNotify);
PhotoManager.startChangeNotify();

PhotoManager.removeChangeCallback(changeNotify);
PhotoManager.stopChangeNotify();

Now
PhotoManager.onChangeNotify.listen((NotifyChangeInfo info) {
  print(info);
});

@AlexV525 I don't have a macos to test if it'd go well. Any suggestions?

Drafting it, and I'll see if there is any chance to follow this up.

P.S. It'll be more acceptable if we hold the inner type as MethodCall, instead of some unverified abstraction, which allows the main idea of this PR to land first, then tweak them by covering all contents. Also, I would be pleased if new content is well explained and documented, making it easy to review.


Use the composite renderer

This makes ol/Map use the composite renderer.

[x] make min/max zoom work for sources (TS)
[x] make vector tile layer renderer return two canvases (TS)
[x] make unmanaged empty vector layers work (AH) (also fixes #8514)
[x] rotation for image layers (TS)
[x] make vector image layers work
[x] implement forEachLayerAtPixel for all canvas layer renderers
[x] make rotation work for text
[x] remove intermediate canvas layer renderer
[x] make graticule a vector layer (OG)
[x] fix the overview map (OG)
[x] add function to create vector context from render event (AH)
[x] rework examples that rely on pre/post compose
[x] get all tests passing
[x] document breaking changes

Thanks for the collective effort!

Very nice work everyone! Thanks!


Special numbering of theorems.

From James Haines email on 7/17/15, issue 11.
How does one get a special theorem-numbering system? We assume we should be able to do this completely automatically, but if we want theorems numbered within sections and examples numbered singly in a separate sequence (we regularly see papers that do things like this) we don’t see how to get it. This doesn’t work:
\documentclass[final,leqno]{siamart}
\numberwithin{theorem}{section}
\newsiamremark{example}{Example} %I want this to be single-numbered
\begin{document}
\setcounter{section}{1}
\begin{theorem}\label{thm1.1}
A short theorem.
\end{theorem}
\begin{example}\label{ex1} %comes out "Example 1.2", not "Example 1"
A short example.
\end{example}
\end{document}
Looking at how the .cls file sets up the theorem-making commands, would it be a problem to change them so you can do this in the preamble:
\siamthmstylenormal %subsequent new theorem-like items will be created with caps-small-caps head and italic body; this will be on by default
\newtheorem{claim}{Claim}
\siamthmstyledefn %subsequent new theorems will be created with caps-small-caps head and roman body
\newtheorem{assumption}{Assumption}
\siamthmstyleremark %subsequent new theorems will be created with italic head and roman body
\newtheorem{example}{Example}
i.e., sort of like how the amsthm package does it.

Explained how to do it in an appendix on the documentation. Let me know if that is sufficient.