Tuning help for home-made robot with home-made LIDAR

Hello Guys,
I am trying to improve cartographer result for my home-made LIDAR.
Here is a link that I recently asked in roswiki.

rosbag validate result:
E0424 20:04:08.134719 25812 rosbag_validate_main.cc:350] frame_id "odom" on topic /odom has serialization time<PHONE_NUMBER>.908083810 but sensor time<PHONE_NUMBER>.416547069 differing by -7727.49 s. E0424 20:04:08.135022 25812 rosbag_validate_main.cc:350] frame_id "odom" on topic /odom has serialization time<PHONE_NUMBER>.952052829 but sensor time<PHONE_NUMBER>.466559309 differing by -7727.49 s. E0424 20:04:08.135043 25812 rosbag_validate_main.cc:350] frame_id "odom" on topic /odom has serialization time<PHONE_NUMBER>.001106965 but sensor time<PHONE_NUMBER>.516543580 differing by -7727.48 s. E0424 20:04:08.135164 25812 rosbag_validate_main.cc:131] Input contains transform message from frame_id "map" to child_frame_id "odom". This is almost always output published by cartographer and should not appear as input. (Unless you have some complex remove_frames configuration, this is will not work. Simplest solution is to record input without cartographer running.) W0424 20:04:08.141655 25812 rosbag_validate_main.cc:166] Sensor with frame_id "base_scan" measurements overlap in time. Previous range message, ending at time stamp<PHONE_NUMBER>05857072, must finish before current range message, which ranges from<PHONE_NUMBER>96746061 to<PHONE_NUMBER>06589811 W0424 20:04:08.141710 25812 rosbag_validate_main.cc:166] Sensor with frame_id "base_scan" measurements overlap in time. Previous range message, ending at time stamp<PHONE_NUMBER>06589811, must finish before current range message, which ranges from<PHONE_NUMBER>97370137 to<PHONE_NUMBER>07213887 W0424 20:04:08.141748 25812 rosbag_validate_main.cc:166] Sensor with frame_id "base_scan" measurements overlap in time. Previous range message, ending at time stamp<PHONE_NUMBER>07213887, must finish before current range message, which ranges from<PHONE_NUMBER>98114108 to<PHONE_NUMBER>07957858 W0424 20:04:08.193042 25812 rosbag_validate_main.cc:203] Sensor with frame_id "base_scan" range measurements have longest overlap of 0.921967 s E0424 20:04:08.193071 25812 rosbag_validate_main.cc:382] Point data (frame_id: "base_scan") has a large gap, largest is 0.875337 s, recommended is [0.0005, 0.05] s with no jitter. I0424 20:04:08.193133 25812 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/scan" (frame_id: "base_scan"): Count: 228  Min: 0.062408  Max: 0.875337  Mean: 0.745079 [0.062408, 0.143701)	                   #	Count: 17 (7.456141%)	Total: 17 (7.456141%) [0.143701, 0.224994)	                    	Count: 0 (0.000000%)	Total: 17 (7.456141%) [0.224994, 0.306287)	                    	Count: 0 (0.000000%)	Total: 17 (7.456141%) [0.306287, 0.387579)	                    	Count: 1 (0.438596%)	Total: 18 (7.894737%) [0.387579, 0.468872)	                    	Count: 0 (0.000000%)	Total: 18 (7.894737%) [0.468872, 0.550165)	                    	Count: 0 (0.000000%)	Total: 18 (7.894737%) [0.550165, 0.631458)	                    	Count: 0 (0.000000%)	Total: 18 (7.894737%) [0.631458, 0.712751)	                    	Count: 0 (0.000000%)	Total: 18 (7.894737%) [0.712751, 0.794044)	              ######	Count: 70 (30.701754%)	Total: 88 (38.596493%) [0.794044, 0.875337]	        ############	Count: 140 (61.403507%)	Total: 228 (100.000000%) I0424 20:04:08.193343 25812 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/odom" (frame_id: "odom"): Count: 4470  Min: 0.044489  Max: 0.055512  Mean: 0.050000 [0.044489, 0.045592)	                    	Count: 2 (0.044743%)	Total: 2 (0.044743%) [0.045592, 0.046694)	                    	Count: 1 (0.022371%)	Total: 3 (0.067114%) [0.046694, 0.047796)	                    	Count: 1 (0.022371%)	Total: 4 (0.089485%) [0.047796, 0.048898)	                    	Count: 1 (0.022371%)	Total: 5 (0.111857%) [0.048898, 0.050001)	         ###########	Count: 2421 (54.161076%)	Total: 2426 (54.272930%) [0.050001, 0.051103)	           #########	Count: 2039 (45.615211%)	Total: 4465 (99.888145%) [0.051103, 0.052205)	                    	Count: 1 (0.022371%)	Total: 4466 (99.910515%) [0.052205, 0.053308)	                    	Count: 1 (0.022371%)	Total: 4467 (99.932884%) [0.053308, 0.054410)	                    	Count: 1 (0.022371%)	Total: 4468 (99.955254%) [0.054410, 0.055512]	                    	Count: 2 (0.044743%)	Total: 4470 (100.000000%)
My launch file:

<launch>
  <param name="/use_sim_time" value="true" />

  <node name="cartographer_node" pkg="cartographer_ros"
      type="cartographer_node" args="
          -configuration_directory $(find cartographer_ros)/configuration_files
          -configuration_basename kamu_robotu.lua"
      output="screen">
  </node>

  <node name="cartographer_occupancy_grid_node" pkg="cartographer_ros"
      type="cartographer_occupancy_grid_node" args="-resolution 0.05" />
</launch>

My Lua file:
include "map_builder.lua"
include "trajectory_builder.lua"

options = {
  map_builder = MAP_BUILDER,
  trajectory_builder = TRAJECTORY_BUILDER,
  map_frame = "map",
  tracking_frame = "base_link",
  published_frame = "base_link",
  odom_frame = "odom",
  provide_odom_frame = true,
  publish_frame_projected_to_2d = false,
  use_odometry = true,
  use_nav_sat = false,
  use_landmarks = false,
  num_laser_scans = 1,
  num_multi_echo_laser_scans = 0,
  num_subdivisions_per_laser_scan = 1,
  num_point_clouds = 0,
  lookup_transform_timeout_sec = 1.2,
  submap_publish_period_sec = 0.3,
  pose_publish_period_sec = 5e-3,
  trajectory_publish_period_sec = 30e-3,
  rangefinder_sampling_ratio = 1.,
  odometry_sampling_ratio = 1.,
  fixed_frame_pose_sampling_ratio = 1.,
  imu_sampling_ratio = 1.,
  landmarks_sampling_ratio = 1.,
}

MAP_BUILDER.use_trajectory_builder_2d = true

TRAJECTORY_BUILDER_2D.use_online_correlative_scan_matching = true
TRAJECTORY_BUILDER_2D.use_imu_data = false
TRAJECTORY_BUILDER_2D.real_time_correlative_scan_matcher.linear_search_window = 0.1
TRAJECTORY_BUILDER_2D.real_time_correlative_scan_matcher.angular_search_window = math.rad(35.)

-- Parameters added later
--TRAJECTORY_BUILDER_2D.min_range = 0.001
TRAJECTORY_BUILDER_2D.max_range = 1.0

POSE_GRAPH.optimization_problem.huber_scale = 1e2

return options

Two bag files that I use:
real_data1.bag 64 point  1 Hz LIDAR
real_data2.bag 64 point 4 Hz LIDAR (I increased rotation speed of the LIDAR)

Here is the link for the cartographer result for real_data1.bag

I really appreciate for your help!

@MichaelGrupp  @esteve @SirVer @damienrg @damonkohler

hi:) is there any issues here? i have the same problem

@clement2449, no improvement unfortunately :(

@samialperen do you want my files maybe it can help

oh i forgot sorry dont put the sim time to true if you have a hardware device. i did that before and i didn't work

While we can't help much with debugging this custom setup, I recommend to read the output of the validate tool. There are multiple issues with timestamps, TF etc. in your data.


Fixes references to FEATHER#allocateBuffer

Replaced all references to FEATHER#allocateBuffer with ByteBuffer#allocateDirect

Man, how embarrassing. This is what I get for having two implementations of Feather on different desktops. I should really design a testing suite already.


(BKR-1032) Switched from using STDERR to $stderr

Hilariously, this is the only change needed since QENG-4019 has went in 👍

@ferglor I'm not against this change but I want to make sure you're not calling genconfig2 in Beaker.  You shouldn't need to change this.

@nwolfe sorry dude, I forgot to comment on the other PR - you're right, I'm not calling genconfig2, I just thought I'd make this change since it's nicer to use $stderr over STDERR


MKHC-fcc-s < MKC-fcc-Daniel

Pre-Submission Checklist

[ ] Your pull request targets the staging branch of freeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

MKHC-fcc-s < MKC-fcc-Daniel


Example/tutorial for WMS and TMS

Part of #4239

After some proof-reading from @jieter, I've created better templates for the iframed examples - this allows to develop small examples and change the Leaflet version in all framed examples at once.

Templates look good!


Missing docker image for 1.10.0 release

The workflow Publish Docker image was not triggered on release PR https://github.com/apache/kyuubi-docker/pull/14 merge, so the image was not built and published to Docker Hub:
docker pull apache/kyuubi:1.10.0

Error response from daemon: manifest for apache/kyuubi:1.10.0 not found: manifest unknown: manifest unknown

@bowenliang123 Could you please have a look at it?

Thank you for the reminder. It seems that the v1.10.0 tag was missed in the push. Let me retrigger it.

It's now ready on Dockerhub with v1.10.0 tags.
https://hub.docker.com/layers/apache/kyuubi/1.10.0


add customer ci and config pom

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
see 3 files with indirect coverage changes


Push As Installation not working?

I'm referencing the Push As Installation instructions: https://github.com/tidbyt/pixlet#push-as-an-installation
Just got my Tidbyt today, and I'm trying to write some code that shows my current lifetime solar power production, etc. When I add an Installation ID to my push command, it never shows up in the app on my phone as that Install ID or anything added by API as the instructions show should happen.
Here's the commands I'm running in a .sh file that I plan to have update daily from a Raspberry Pi and then I'd like it to show up in my rotation.
pixlet render solarlife.star

pixlet push --api-token <API TOKEN> <DEVICE ID> solarlife.webp Solar

Also tried it in quotes ("Solar") to no avail.
Is this a known issue?
Thanks!

Hello,
I am having a similar issue and would love help. I am able to push the .webp file and it shows up on the Tidbyt for about 30 seconds and then is gone. It never shows up on the Tidbyt app on my iPhone. I attempted giving it an installation ID in quotes and without quotes. Neither worked.
Any help would be great, thank you!

I had to quit the app on my iPhone and open it back up in order for the Tidbyt app to display within the iPhone app; however, it does display for me, when an installationID is passed.

I had this issue also; but I was able to work around it by quitting the iPhone app, and then opening it back up. The Tidbyt app will then display within the iPhone app.
(Make sure you're passing the installationID as noted above.)

Thank you for the quick reply. I did kill my iPhone app and it still did not show up. I added "installationID" and then the name of the file, still does not save. It does successfully push one time.

Yeah same here, even tried rebooting my phone and the Tidbyt with no luck.
@joeyhoer when you say passing the installation I'd "as noted" what format do you mean? I checked out the code and it should work as long as it's the third argument (after the api key). But maybe I misunderstood

The installationID argument was added in 3588131f8a72aea17d00c0e4a3dee5597c082766, which is after the 0.7.0 release. You'll need to build the project yourself for it to work.

Ah, that makes sense. I did have to build from source, as the homebrew cask isn’t currently working on M1 macs.

The installationID argument was added in 3588131, which is after the 0.7.0 release. You'll need to build the project yourself for it to work, or wait until they publish another release.

Gotcha. I should have noticed that when I was looking at the code! Thanks!

Building from latest source worked! Thanks, @magicmq!


Crash on startup

I had a custom modpack with this issue and I removed the mods one by one until there was only Create Fabric and Fabric API in it, but it's still crashing when I start Minecraft. No one else seems to have this problem and I also tried removing Create and adding it back. Can anyone help me?
Crash report: https://pastebin.com/7MbDbvvJ
Mods:

Create Fabric 0.5.1c
Fabric API 0.77.0

Minecraft and Modloader version:

Minecraft 1.19.2
Fabric loader 0.15.6

try downgrading to 0.76

That worked! Thanks!


100% coverage is not 100% #203

fixes #203, connected to #203

@mriehl ready for review

Isn't there a mininum version of coverage we need to be able to do this?
If so, it would be great to :

depend on at lest the minimum version in the @init code
ensure that the coverage found at runtime has this function (or maybe a duck-typed check if it works like we want). That would be preferable to an AttributeError if someone still has an old coverage installed.

No minimum version - works on both 3.7 and 4 (I'll recheck). This API has been there forever.

Actually, scratch that, patch targets in UTs use newer classes, I need to fix that.

Right, this is the Analysis.numbers thing Ned was writing about in #28 . I always feared it would go private or change due to the announced overhaul but it seems to be stable so that's ok.


Adding LSS functionality

As mentioned here (https://sourceforge.net/p/canopennode/discussion/387151/thread/397f3912/) I'm in the process of implementing LSS.
I've pushed a first version to my local repo in lss branch (https://github.com/martinwag/CANopenNode/tree/add-lss). Feel free to have a look, but be aware that this is still experimental. If you find errors or have other hints, please let me know :-)
Current features

LSS slave

Current limitations:

needs #define CO_NO_LSS_SERVER 1 in CO_OD.h. This will need a change in the OD editor.
no Fastscan support yet
bitrate setting API untested. I've implemented this for the sake of completeness, I don't need it in my application.
https://github.com/CANopenNode/CANopenNode/issues/46 (driver stuff)
changed some of the other stack files, tried my best to remain compatible with standard non LSS CANopenNode
there is a bit of a mess about server/slave and master/client. But this is a mess in the other parts of the stack too :-(

This is very serious contribution to CANopenNode. I will review driver interface and add LSS to the stack.

Please do not merge the stuff yet. I'm still in the middle of implementing myself :-).

I've pushed LSS master and LSS fastscan, so LSS should be complete now. This is the updated list:
Current features

LSS slave
LSS master
Fastscan support

Current limitations:

needs testing.
needs #define CO_NO_LSS_SERVER 1 or  #define CO_NO_LSS_CLIENT 1 in CO_OD.h. This will need a change in the OD editor. Only one can be active at a time.
bitrate setting API untested. I've implemented this for the sake of completeness, I don't need it in my application.
#46 (driver stuff)
changed some of the other stack files, tried my best to remain compatible with standard non LSS CANopenNode
there is a bit of a mess about server/slave and master/client. But this is a mess in the other parts of the stack too :-(

Hi,
I recently started checking out this piece of work and I gotta say it works great and it's really well written and documented!
It just took me a little while to figure out the whole LSS state machine (i.e. come up with some meaningful test cases) but that's probably my fault.
I have one question though: is there a particular reason why the 3 callbacks are called in interrupt context? This forces me to add an extra level of queuing, whereas it would've probably been easier to just store a flag and have the callbacks invoked from CO_LSSslave_process() at the next call.
But perhaps I'm missing something.
Thanks again!

Yes, there is a simple reason :-). It was easier for me. I have an RTOS, so outside of CANopenNode I can just use ready-made functions for synchronisation.
The LSS state machine is quite tricky to get right, especially if you want to have LSS fastscan. Follow the examples in the specification really carefully.

You're right that state machine is tricky. What I'm not quite following is the logic of the Node-ID assignment. By looking at the example code within the comments of CO_LSSslave.h, it appears like setting it for the first time on an unconfigured node just activates it immediately (so you should immediately get NMT running), whereas if you do it a second time, you shall first issue a RESET_COMM in order to activate it. Is my understanding correct? Was this done on purpose?
Quite frankly, I'm not quite happy with the extra start_canopen() loop for an unconfigured node. Even when unconfigured, a bare metal implementation should also do some other stuff as well (e.g. poll other communication interfaces, drive LEDs, re-arm the watchdog and so on). So I'd rather have everything in a single main loop, which initializes NMT only when a valid NodeID is found.

The start_canopen() function has two use cases.

Start after boot
Start after RESET_COMM

After boot, you either get a valid node ID from NVM or fastscan mode is started (the loop). In this mode, only the LSS slave is active. This implements the functionallity required in CiA305 Figure 48.
On RESET_COMM, the same functionallity is used, except that a node ID is already known, so the loop is always skipped. Which node ID is used in this case is explained in Figure 4.
After start-up LSS is serviced like NMT.
I'm not really happy with the startup code either. I think you have two options here:

Split the two start-up modes into two functions
Implement a start up state machine

I've tried to keep the example code short and in a -more or less easy- to understand order...
Ref: CiA® 305 Draft Standard Proposal Version: 3.0.0 08 May 2013

Hey @martinwag ,
i am trying your LSS Fork and it looks very promising. Would be cool to see that in the main repo.
I have one thing that my middleage compiler doesn't support, the unnamed struct CO_LSS_address_t.
Could we consider something like:
typedef union {
    uint32_t addr[4];
    struct {
        uint32_t vendorID;
        uint32_t productCode;
        uint32_t revisionNumber;
        uint32_t serialNumber;
    } identity;
} CO_LSS_address_t;

best regards.

just create a pull request onto my branch. We're still in testing, when this is done I will create a request for the main repo.

implemented in 8b01062eb6568721304164db9f0fea1fde546e76


fix: add OperationOutcome entry to ExtractionErrorMessage bundle

RIght; looks good. I like the reuse of reference management across the common utility space.
It's low priority but fullUrls don't have to be ids on entries. They could be hosted as well; and implementors MAY (probably not) want to assign urls; and I believe the fullUrl field is only allowed to be set once; so be careful assigning fullurl from a constructor like this.

It must be because there's a helper function to add resources to a bundle I wrote which sets up the url for it. That's not part of this error handling workflow.
The base hapi fhir structure of BundleEntryComponent accepts any object of type Resource of which OperationOutcome and others are a member of. So the problem isn't with the hapi fhir library it's with the usage in VRDR somewhere.


Scope is lost in IResolver inside scope because of singleton

Hello!
Assumption: We have service singleton and service transient. Both of them have service A which has IResolver.
We've found that if service singleton is resolved before scope, scope context is lost for IResolver inside scope.
We assumed that if service A is registered as a transient then there is no issue to inject it to singleton then to scope.
We are getting following error:
DryIoc.ContainerException: 'code: Error.NoCurrentScope;
message: No current scope is available - probably you are registering to or resolving from outside of the scope.
It also may be because of the scoped dependency has singletons in its parent chain so the dependency is resolved from the root container resolver.
Current resolver context is: container without scope.'
Could you eleborate why this error occur ?
Code to repeat this error:
public class ServiceInjecting
    {
        [Fact]
        public void TestDryIoc()
        {
            var container = new Container();

            container.Register<ServiceSingleton>(reuse: Reuse.Singleton);
            container.Register<ServiceTransient>(reuse: Reuse.Transient);
            container.Register<ServiceResolver>(reuse: Reuse.Transient);
            container.Register<ServiceScoped>(reuse: Reuse.Scoped);

            var singleton = container.Resolve<ServiceSingleton>();

            var scope = container.OpenScope();

            var transient = scope.Resolve<ServiceTransient>();
            transient.Do();

            scope.Dispose();
        }

        public class ServiceSingleton
        {
            private readonly ServiceResolver _serviceResolver;

            public ServiceSingleton(ServiceResolver serviceResolver)
            {
                _serviceResolver = serviceResolver;
            }
        }

        public class ServiceTransient
        {
            private readonly ServiceResolver _serviceResolver;

            public ServiceTransient(ServiceResolver serviceResolver)
            {
                _serviceResolver = serviceResolver;
            }

            public void Do()
            {
                _ = _serviceResolver.GetService<ServiceScoped>();
            }
        }

        public class ServiceResolver
        {
            private readonly IResolver _resolver;

            public ServiceResolver(IResolver resolver)
            {
                _resolver = resolver;
            }

            public TService GetService<TService>()
            {
                return _resolver.Resolve<TService>();
            }
        }

        public class ServiceScoped
        {

        }
    }

@Ditriksss Thanks for the test, will check a bit later.

@Ditriksss Yeah, something strange - probably a bug.
When you omit the var singleton = container.Resolve<ServiceSingleton>();, everything working as it should.
But when the ServiceResolver is injected into the singleton first, for some reason it is cached as bound to the root container,
messing up the resolution in the transient.
I will look for the fix.

@Ditriksss Sorry for the late answer, but the problem is the cache in this case, and I believe it's hard to solve in the current version.
But for now you may use the workaround registering the ServiceResolver as:
container.Register<ServiceResolver>(setup: Setup.With(useParentReuse: true));

Basically, it means that ServiceResolver reuse will be dependent on the parent service and so it won't be cached.
I'll keep the issue opened to see if there is any better solution in v6.0.


Academia of Zamoyski

Added Academy of Zamoyski (Akademia Zamojska)

@Celiek I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host upz.Zamosc.pl not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


v3: multi-container actions 'clear' button is ambiguous

Some feedback I've received is that the 'clear' button is ambiguous -- it's not clear that it clears your selection.

Is this still the case or can we close this?


Fix heading formatting on Migrate to virtual private cloud page

What's wrong?
Headings on the Migrate to a virtual private cloud Have a #. next to them.
Remediation
Remove the #. on these headings and use Proper RST heading syntax instead.
URL of affected page, and any other information
https://docs.aiven.io/docs/platform/howto/migrate-services-vpc

This was fixed in #1810.

This was fixed in #1810.


Provide initial ListNVMfRemoteNamespaces implementation.

Sorry, missed the comment.
My understanding is that ListNVMfRemoteNamespaces is needed for a client to get all discovered namespaces after a remote controller is connected, so we could assign them to middleend/frontend. It is also why we can only list them, but not create/delete.
@benlwalker could you please clarify?

Sorry, missed the comment. My understanding is that ListNVMfRemoteNamespaces is needed for a client to get all discovered namespaces after a remote controller is connected, so we could assign them to middleend/frontend. It is also why we can only list them, but not create/delete. @benlwalker could you please clarify?

what I mean is we already call bdev_get_bdevs in several places... not sure I understand why we need yet another one... maybe if we show how to create those first, then list will make more sense... ?


Streak Issue

I just noticed my streak was not updating properly I was updating everyday and should have been past a 10 point streak.

I had 3 contributions on April 30, as per GitHub contribution graph. But streak didn't include it. Not sure why!
https://github.com/laxmariappan

It all depends on timezones and I am not able to control which timezone the contributions are returned for
@laxmariappan For example, for me it also shows no contributions on April 30

Either the contributions are private or they were counted for a different day.
https://github.com/DenverCoder1/github-readme-streak-stats/blob/main/docs/faq.md#why-doesnt-my-streak-stats-match-my-contribution-graph

makes sense, thanks Jonah

I made a commit in my private repo and it did not track. My streak was reset from 17 to 1 now. I even made that repo public and it still isn't updated.

Hello,
I am having the same issue. I am on a 448 day streak, but somehow on my profile it reset at January first. This must have changed somewhere last week.
https://streak-stats.demolab.com/?user=bram1903
Shows 448 days ^^

Shows 140 days on my profile page ^^
Kind regards,
Bram

Yeah I think the time-zone is an issue, around 10 pm PST everyday the git shows the day has changed to me and streaks never reflect.


west.yml: Update hal_stm32 with recent cube packages

    STM32Cube updates:
stm32cube: update stm32l5 to version V1.4.0
stm32cube: update stm32l4 to version V1.17.0
stm32cube: update stm32g4 to version V1.4.0
stm32cube: update stm32f7 to version V1.16.1
stm32cube: update stm32f4 to version V1.26.0
stm32cube: update stm32g0 to version V1.4.1
stm32cube: update stm32h7 to version V1.9.1
stm32cubeMP1: not updated due to compilation issue with verison 1.3.0,  (cf zephyrproject-rtos/hal_stm32#91 comment)

update stm32cube/common_ll

Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

compilation ok with :
  west build -p auto -b nucleo_g071rb samples/hello_world/
  west build -p auto -b nucleo_f746zg samples/hello_world/
  west build -p auto -b nucleo_h743zi samples/hello_world/
  west build -p auto -b nucleo_f446re samples/hello_world/
  west build -p auto -b nucleo_g474re samples/hello_world/
  west build -p auto -b nucleo_l4r5zi samples/hello_world/
  west build -p auto -b nucleo_l552ze_q samples/hello_world/

rebase

@FRASTM https://github.com/zephyrproject-rtos/hal_stm32/pull/93 has been merged. You can update this PR.

rebase and update as the  zephyrproject-rtos /hal_stm32 is now merged with latest versions of the STM32Cube


feat(system): creates a dev runner container

This should make it easier to start with this project, by enclosing everything in a docker container.
Resolves PP-184

closing due to diverged development


Static Linking Library?

Is it possible to be able to use clangsharp/llvmsharp to use static libraries (.lib) to generate p/invoke bindings for C++ code or is that not feasible and clangsharp is only usable for C projects? I apologize for opening this issue but I did not know any other way to ask this way or contact the developers.

You need the C headers to generate the bindings, once you have the bindings you can configure NativeAOT to statically link your libs and resolve the generated P/Invokes.


Missing Introduction section

Getting a missing Introdiction section first paragraphs for some strange reason ?
http://lampwww.epfl.ch/~amin/dot/fool.pdf
Text picks up on second column text "well as its mixture of nominal ..."

@AaronNGray I have observed the same issue on medical articles.
As part of EHF2-6-1105.pdf, I have observed that the whole "Epidemiology" section in page one (defined across 2 columns) is missing in the TEI XML after conversion. This behaviour was observed with docker version (i.e. lfoppiano/grobid:0.7.0).

@AaronNGray @qhreul I've been revising the open issues with error cases, and both your problems seems to be solved in version 0.8.1.


make demo fails to build

The command make demo fails in the  Development branch, commit 8b7e11cbc485eaf998d665d1e2ed68c0d4f41be0.
Relevant log:
`
docker compose exec -T drupal with-contenv bash -lc "drush si -y islandora_install_profile_demo --account-pass 'PASS'"
You are about to:

DROP all tables in your 'drupal_default' database.

// Do you want to continue?: yes.
[notice] Starting Drupal installation. This takes a while.
[notice] Performed install task: install_select_language
[notice] Performed install task: install_select_profile
[notice] Performed install task: install_load_profile
[error]  Error importing/updating configuration
[error]  Error importing/updating configuration
[notice] Performed install task: install_verify_requirements
[notice] Performed install task: install_verify_database_ready
[notice] Performed install task: install_base_system
[notice] Performed install task: install_bootstrap_full
[error]  The Flysystem driver is missing.
[warning] Could not find required jsonld.settings to add default RDF namespaces.
[warning] The "views_block:members-block_1" was not found
[notice] Performed install task: install_profile_modules
`

Thank you @joshdentremont .


Fix invalid token in Parsian driver

It fixes #20

thanks for your contributing.

i have released new version (install v1.0.7)


Chore: Add questions object to store questions and options all in one place

central questions file to build off of

can we give the questions object a name? for example, the name of the question section?

Section names are there. Do you want to name the object itself for export?

can we give the questions object a name? for example, the name of the question section?

Section names are there. Do you want to name the object itself for export?

yeah exactly the object itself, since there will be different ones for each section @mmnoo


ThroughputControl-Global

This is the second PR of the throughput control.
Compared to local control mode, the throughput control group is shared among different clients.


Add swipe down to reload balance on tokens screen & update web runner 1.1.27

Describe the task
Add swipe down to reload balance on tokens screen
Update web runner 1.1.27
Features & Update:

Sort the Current account on top in the Account selector
Update API staking for Astar
Add Azero Domains is default pool
Update chain-list

Some update for 3DPass (addd new RPC, update logo, update explorer, update price)
Add support Energy Web X

Bugs fixed:

Fixed bug dApp detection when connect wallet
Fixed UI bug show balance in the Token details screen
Fixed bug show EVM transaction history
Fixed bug show transfer NFT history details
Fixed bug phishing detection

Version test: PR #1279 11:15 22/12/2023
Device test: IP 11
Validation passed in case:

Update API staking for Astar
Add Azero domains is default pool
Update chain-list


Add info that @zillowgroup/react-slider is now react-slider

Hey,
I think it's worth to publish new version on https://www.npmjs.com/package/@zillowgroup/react-slider and updating readme and also adding specific package.json properties to inform people that package has moved from @zillowgroup/react-slider to react-slider.

Good point! I'll make sure to do that, thanks!

Done!


[Feature request] Deploy test resources close to Mac Agent location

Since we introduced Mac Agents I can see test run deterioration with Mac Agents being the tail.
Here are some thoughts:

We deploy storage test resources in certain region due to feature availability, but I think we can workaround this by testing N-1 service version on Macs, so that latest features tests just don't run
We should detect where Mac agents we got is located and pick Azure DC that's nearby

Here's some evidence from .NET and Java pipelines:

The region that Macs get deployed in will probably be fairly static so you could potentially push your test resources over to that region. @benbp how much effort would it be to pass in a matrix value to overrides the location for test resource creation for just macOS legs?
Ideally we can do a quick test just to validate whether the changed region does indeed help performance as there are potentially other contributing factors that we should rule out (e.g. optimization issues for macOS). I believe that the underlying Mac provider has points of presence in Silicon Valley, Vegas and Atlanta. I think we are probably using agents in the valley, so perhaps deploying the resources in West US 2?

If that were true I'd expect lower variance, i.e. these locations all seem far away from Canada Central region.
For example here https://dev.azure.com/azure-sdk/internal/_build/results?buildId=872600&view=results

Might be worth injecting some script into pipelines to collect data that can be used to determine where Macs are and what's the latency to test resources.

These Mac's aren't on the Azure infrastructure, so the network performance could vary quite a bit from what you might expect say from a VM running inside West US.


feat(playground): use Starlight

Summary
This PR is part of https://github.com/biomejs/biome/issues/881  and focus on migrate the Playground page to Starlight including reuse its color scheme.
Additionally, it includes some cleanup of old files from Rome website.
Test Plan
I've done manually:

[x] Responsive test
[x] Accessibility test
[x] Test playground's core features

This is such a significant improvement! One thing: we should remove the dropdown for selecting the language because we don't plan to translate the playground, and choosing another language will cause a 404.

we should remove the dropdown for selecting the language

I'll be working on it as a separate PR we can merge before/after this one, will also do some extra work to ensure we avoid 404s in these pages if you're coming from another language.

Selecting an option shows some weird contrast (it also happens inside the current playground)

@SuperchupuDev Thank you for testing it on windows, can you see if it's ok now?

works now, thanks for fixing! there is a small white bar at the bottom now though

works now, thanks for fixing! there is a small white bar at the bottom now though

Is that MS Edge browser?

With firefox it seems good

@ematipico i'm using chrome beta

@SuperchupuDev I couldn't reproduce it using browserling.com (Windows 11 and latest Chrome version).
If you think it's a very annoying problem, Let's work on this in another PR

works now, thanks for fixing! there is a small white bar at the bottom now though

I also could not reproduce this one in Chrome 120, it might be a regression in Chrome's beta.

it's okay, it's just a very small detail, i don't think it matters that much. it looks really good regardless


Add command to allow toggling and/or setting of triggerTaskOnSave.on

Rather than going to File, Preferences, Settings and searching for  "triggerTaskOnSave.on" and changing, could you add a command that can be accessed through the command palette. This would allow quick changing of this setting and could be bound to a key.

Seems sensible - I'll add it in for the next release.

Added to 0.1.2

Just confirmed that it works.


Configuration invalid: Invalid config for [evohome]: required key not provided

Using the Web UI, Configuration -> General -> CHECK CONFIG results in an error message:
Configuration invalid.  The detailed error message is:  Invalid config for [evohome]: required key not provided @ data['platform']. Got None. (See ?, line ?).
This error occurs despite the correct configuration in configuration.yaml:
evohome:
  username: !secret honeywell_username
  password: !secret honeywell_password

However, the code appears to run OK, and the TCC credentials are used correctly.

Fixed sometime in the past...


coprocessor/*:implement for json_remove

Hi,
This PR implement function json_remove in coprocessor, the related source code in tidb is
(https://github.com/pingcap/tidb/blob/master/expression/builtin_json.go#L207) , (https://github.com/pingcap/tidb/blob/master/util/types/json/functions.go#L329)
The related mysql document is https://dev.mysql.com/doc/refman/5.7/en/json-modification-functions.html#function_json-remove
@hicqu @andelf @BusyJay PTAL

LGTM

LGTM.

@BusyJay  PTAL agin, THX


TypeError: Failed to execute 'text' on 'Response': body stream already read

Hi, first of all, congrats making this really good library !
I'm using ts-rest inside an NX Monorepo with NextJS & NestJS.
I got my two apps (generated form @nrwl/nest & @nrwl/next) and a lib for the contracts.
Here are my definitions :
// index.ts in shared/contracts/src (my library)
import { initContract } from '@ts-rest/core';

const c = initContract();

export const healthCheckContract = c.router({
  getHealthcheck: {
    method: 'GET',
    path: '/',
    responses: {
      200: c.response<string>(),
    },
    summary: 'Healthcheck API to check if the service is up and running',
  },
});

// app.controller.ts in NestJS app
import { Controller } from '@nestjs/common';
import {Api, initNestServer} from "@ts-rest/nest";
import {healthCheckContract} from "@ecommerce/contracts";

const s = initNestServer(healthCheckContract);
type ControllerShape = typeof s.controllerShape;
type ResponseShapes = typeof s.responseShapes;

@Controller()
export class AppController implements ControllerShape {
  @Api(s.route.getHealthcheck)
  async getHealthcheck(): Promise<ResponseShapes['getHealthcheck']> {
    return  {
      status: 200,
      body: 'Hello World!'
    };
  }
}

// _app.tsx in NextJS app (init queryClientProvider)
import { AppProps } from 'next/app';
import Head from 'next/head';
import {QueryClient, QueryClientProvider} from "@tanstack/react-query";
import {useState} from "react";

export default function CustomApp({ Component, pageProps }: AppProps) {
  const [queryClient] = useState(() => new QueryClient());

  return (
    <>

        <title>Welcome to web!</title>

        <QueryClientProvider client={queryClient}>
            <Component {...pageProps} />
        </QueryClientProvider>

    </>
  );
}

// index.tsx in NextJS app (fetching data)
import {initQueryClient} from "@ts-rest/react-query";
import {healthCheckContract} from "@test/contracts";
import {useEffect} from "react";

export default function Index() {
  const client = initQueryClient(healthCheckContract, {
    baseUrl: 'http://localhost:3333/api',
    baseHeaders: {},
  });
  const {data} = client.getHealthcheck.useQuery(['healthcheck'])

  useEffect(() => {
    console.log('data', data)
  }, [data])

  return (

Welcome to web!

  );
}

I can watch the query response, and from there, all good :

The console.log pops one time, and says "undefined"
Then this error appears in the console :

Coming from this part of code :

And, as I can see, in network tab, the query repeats itself again and again.
No type errors so I presume my code is correct but maybe there is something I miss ?
Thank you for your help.

Looks like a bug in the library when handling non-JSON responses. Will look into it. Thanks for reporting!

@Gabrola begs the question of why this works...


px4_reload uses wrong folder structure

Hello,
I think I found a hard coded folder structure while I was playing around with the emdbg tool. Most likely nothing major to fix, but since I am unfamiliar with the project I report it first.

Regards,
Kevin

Ooops, that's also broken for me now, since I moved the project around. This path should probably be determined with __file__ instead.


Updated the ::pipe() system calls to pipe2 in lib_journald.

This is the followup fix for potential FD leak issue after https://issues.apache.org/jira/browse/MESOS-9151 was fixed in DC/OS.

We need to land this PR and backport the fix to DC/OS 1.12, 1.11 and 1.10 branches.


When will COCO model be released?

Hi! Thanks for the great codebase!
Do you have any timeframe for the release of the COCO object detection model?

In one week. Let me finish it this weekend.

Super thank you!!!

Released. Sorry for the delay.


Removing namespace references from full-secret-store.yaml

Fixes #897
Signed-off-by: Gustavo Carvalho<EMAIL_ADDRESS>

/approve

/merge


What is the reason for this?

Traceback (most recent call last):
File "main.py", line 15, in
from robot import Robot
File "E:\AAAAAAAAAAAA\visual-pushing-grasping-master\robot.py", line 8, in
from simulation import vrep
File "E:\AAAAAAAAAAAA\visual-pushing-grasping-master\simulation\vrep.py", line 59, in
c_GetJointPosition          = ct.CFUNCTYPE(ct.c_int32,ct.c_int32, ct.c_int32, ct.POINTER(ct.c_float), ct.c_int32)(("simxGetJointPosition", libsimx))
AttributeError: 'NoneType' object has no attribute '_handle'

print:
----------------------------------------------------
The remoteApi library could not be loaded. Make sure
it is located in the same folder as "vrep.py", or
appropriately adjust the file "vrep.py"
----------------------------------------------------
But they locate in the same fiolder.

I have solved this problem. I think the operating system you have used is windows and the python file in it needs a remote API file to run. So I recommend you copy the remoteApi.dll file to the simulation folder.

I have solved this problem. I think the operating system you have used is windows and the python file in it needs a remote API file to run. So I recommend you copy the remoteApi.dll file to the simulation folder.

Where can I get these two files which you mentioned?
Thanks in advance :)

These two files are contained in the location where the software CoppeliaSim is installed. Exactly, CoppeliaSim/programming/remoteApiBindings/lib/lib/. I can not guarantee the difference between the PC.
Hope this will help you.


Skill did not execute within the time limit - NOT transient

I have an indexer using the built-in OCR skill running on a 2 hr schedule, and it is failing on the first document every time it runs with the error "Skill did not execute within the time limit".  The documentation suggests this error should be a transient issue, but in my case it's been thrown on every run for almost 24 hours.  What can I do to get past this error?  I don't think the issue is the size of the document, as it is only about 100KB.  I am logging this issue on the documentation page, as it seems like the documentation should provide some information on this scenario (the error is not transient).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 192bd317-bc43-86a8-347f-796358a8e5b6
Version Independent ID: 370cebf6-cb88-7cef-5bd9-b02524e289ae
Content: Common Errors and Warnings - Azure Cognitive Search
Content Source: articles/search/cognitive-search-common-errors-warnings.md
Service: cognitive-search
GitHub Login: @amotley
Microsoft Alias: abmotley

Hello,
Please reach out to support if you see this error continuously for one document as it's not expected. I'll make sure we update our documentation to provide guidance in this case as well.
This issue is expected to be transient, but very rarely there are properties about specific documents that can be problematic for the Cognitive Services OCR API which the OCR skill is backed by. In these cases, we will work the Cognitive Services team and the customer to understand the issue and improve the model. In the short term, to get your indexer to run past this document you can configure your 'maxFailedItems' count on your indexer: https://docs.microsoft.com/en-us/azure/search/cognitive-search-concept-troubleshooting#tip-3-see-what-works-even-if-there-are-some-failures

Hi @danobri,  are you still seeing this error? are you able to open a support ticket?  If no, you can email me at<EMAIL_ADDRESS>and provide me with your SubscriptionID, and link to this thread. I can enable your subscription to be able to create one.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


backend/drm: handle per-connector hotplug events

When the kernel specifies a connector in the hotplug events, only update that connector. This should speed up hotplug event handling.
Kernel patch: https://lists.freedesktop.org/archives/dri-devel/2021-June/310398.html

wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to:
https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/2959


Enable CI on Python 3.10

Summary
Since we just disabled 3.6, it seems logical to enable the most recent release, 3.10.

How to test

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Looks like TensorFlow doesn't support Python 3.10 yet. I'll close this for now.

Do you have any idea on when 3.10 is going to be used as a system-default in Ubuntu and other systems?


Jest error: not exiting properly

Overview
After installing the latest version of jest there appears to be a problem with how the async tests are implemented that are preventing jest from exiting correctly. Please see the output below.
As a temporary measure, the cli command --forceExit was added to the npm test command. This is a patch and should be removed as part of solving the issue.
To demonstrate jest working correctly:
npm checkout releases/v1
rm -rf node_modules
npm install
npm run all

To see the error:
npm checkout main
rm -rf node_modules
npm install
npm run all

Error output
> jest

 PASS  __tests__/github.test.ts
  ✓ runs git commands (46 ms)

::debug::Output from git config is:
::debug::Error response from git config is:
::debug::Rendering test1.wsq
::debug::Full path of file is /Users/michael/git/trepp/actions-render-wsq/__tests__/test1.wsq
::debug::Error adding png files: fatal: pathspec '*png' did not match any files%0A
::debug::Rendering test1.wsq
::debug::Full path of file is __tests__/test1.wsq
 PASS  __tests__/main.test.ts
  ✓ renders a diagram (391 ms)
  ✓ renders files using local path (325 ms)
  ✓ throws unknown style (14 ms)

::debug::Rendering test1.wsq
::debug::Full path of file is /Users/michael/git/trepp/actions-render-wsq/__tests__/test1.wsq
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks.
Test Suites: 2 passed, 2 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        2.426 s, estimated 3 s
Ran all test suites.

@k1ch  This is a super minor issue to look at whenever you have some downtime between tasks. I think the issue is related to the async / await handling within the newer version of jest.

@mikelax I looked in to it and realized that the issue is not only bounded to async tests! I created a simple test, not async, and got the same behavior from jest.
Suspecting of dependencies, I updated package-lock.json file and that resolves this issue. Should I move ahead and create a PR for it?

Thanks @k1ch yeah please do create the PR.
Nice job researching.
I have noticed this in the usher repo as well, after a period of time meeting in dependbot PRs eventually the lock file needs to be synced again.

Resolved in #80


Test Realtime

How do I test it realtime?

First you should choose the closest domain from the environments (foliage, weather, season, etc.) of CMU Seasons dataset (see CMU-Seasons readme.md for details) for your own database and query images. Then use the pre-trained model of the corresponding domain to test it. Note that make sure the sequential correspondences of the domains for your own images folders and the pre-trained models are correct.
For the real-time loop closure for long-term SLAM, maybe the database images are the keyframes of the map and some efficient matching strategy should be implemented instead of the brute-force retrieval for every query image.

@HanjiangHu  thank you! could you please tell me how i can prepare my own dataset?

@Zumbalamambo Once the database images (with poses) and query images (take 3 different query conditions for example) are collected, the database folder is named as test00 for reference condition while query folders are named as test01, test02, test03. Then the pre-models on CMU Seasons database are chosen and renamed based on the most similar environmental conditions for all the database and query conditions, e.g. the condition of Overcast + Foliage on CMU is chosen for your own folder test01 under similar overcast with foliage condition, then the pre-trained model should be renamed from 600_net_G11.pth to 600_net_G01.pth, from 600_net_D11.pth to 600_net_D01.pth, and from 600_net_G23.pth to 600_net_G05.pth. Similarly, for test00, test02, test03, the pre-trained models are chosen and renamed, resulting in 3 pre-trained models for every test condition from test00 to test03, i.e. 600_net_G00.pth, 600_net_G01.pth, 600_net_G02.pth, 600_net_G03.pth, 600_net_D00.pth, 600_net_D01.pth, 600_net_D02.pth, 600_net_D03.pth, 600_net_G04.pth, 600_net_G05.pth, 600_net_G06.pth, 600_net_G07.pth. Note that the option in the test command --n_domains should be 4 since there are 4 different domains including database in the example. Also, maybe some necessary changes are expected in the code but I believe it’s not hard to fix these obvious bugs. Good luck with your own test and feel free to contact me if there’s any problem. BTW I have tested these pre-trained models on the RobotCar dataset in the above way and it works well.


custom templates

First, "great job" for this project !
Then, I don't understand how to add custom template
I created color_template.html.erb but  I don't see how to apply it. Do I need to code in ruby ?
In my Scss code :
/*doc
---
title: Colors
name: brand
category: Colors
---
``html_example_color
#3a65c4
``
*/

Is html_example_color correct ?

You need to add some ruby code as well. You should have to create a html_color_renderer.rb in the code_example_renderers folder. See the example here: https://github.com/trulia/hologram#custom-code-example-renderers
In addition, in your scss file, the example should be an html_color_example, not html_example_color.

1/ I created color_renderer.rb :
Hologram::CodeExampleRenderer::Factory.define('color') do
  example_template 'color_template'
end

Is it correct ?
2/ color_template.html.erb
3/ Added comment In SASS :
/*doc
---
title: Colors
name: brand
category: Colors
---
``html_color_example
#3a65c4
``
*/

Where do you think I'm wrong ?

Ok it's color_example
/*doc
title: Colors
name: brand
category: Colors
color_example #3a65c4
*/


babelOptions ignored in esm compiler

babelOptions defined in jspm.conf.js or by direct calling SystemJS.conf() or System.conf() are not passed to the babel transpiler in https://github.com/systemjs/builder/blob/master/compilers/esm.js#L59. Isn't it needed at this place? This causes warnings of the babel transpiler for large files, because compact mode can't be enabled  : https://github.com/babel/babel/blob/master/packages/babel-generator/src/index.js#L81.

This is a different transpilation which only converts ES modules into System.register, separate to the other Babel transforms.
An option to pass compact here could be worth providing though.

Why is Babel called twice? Babel could do all transpilation in one step for a file or I am wrong!? Please, could you shortly explain in which steps the builder transpiles the source code files?
Why is it hard to achieve to set the compact option for the transform operation? The options object is present on the builder instance or isn't it?
Thanks for answering in advance

Are you trying to turn compact on or off?

Yes, by setting in jspm.conf.js and by .babelrc, but the call at line esm.js#59 doesn't pass the compact option. I have debugged it by creating a gulp task and call the Builder directly.

Specifically I was wondering what value you wanted for the compact option, to understand the use case better.

Sorry, I want to disable the warning by using compact=true, which is logged for compact="auto" (default value) in line index.js#L81 for large files.

I'd be open to setting a hard default of compact: false if you think that could work.

Yes, this should work.
For understanding systemjs and systemjs/builder in more detail, do you have a short description, documentation for the internal architecture? It would be helpful for using systemjs in the correct intended way. Especially for Babel. I saw you are working on docs, could it be part of it?
Thanks

I'd be open to setting a hard default of compact: false if you think that could work.

I'd love to have a compact: false hard default as well. Not only to remove the annoying [BABEL] Note: The code generator has deoptimised the styling of "..." as it exceeds the max of "100KB". warnings, but also because it makes debugging such modules such harder due to the deoptimised styling.

Sure, added in https://github.com/systemjs/builder/commit/8a73596a26a63343bb9d1ff3893e9577914fb9ec.

Released in 0.15.33.


Knowledge: Red Hat CLI Guidelines

Guidelines for creating a consistent, user-friendly Command-Line Interface (CLI) experience, covering naming conventions, error messaging, interactive prompts, and more.

I am just testing the UI


Change start date of tlbc-spec to 17:00 11/11 berlin time

Codecov Report

Merging #564 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #564   +/-   ##
=====================================
  Coverage      76%    76%
=====================================
  Files          18     18
  Lines         925    925
=====================================
  Hits          703    703
  Misses        222    222

Flag
Coverage Δ

#bridge_end2end
0% <ø> (ø)
:arrow_up:

#bridge_unit
76% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e605a8f...df7359d. Read the comment docs.


[Startube] Startube Hitchhiker UI 2014 (2013 too) video offset

Alec is supposed to be at the center of the screen.

Breaks V3

Issue doesn't persist on V3 default settings


Upped the test coverage to 86.05%

I've made the code more organized and managed to get the test coverage up to 86.05%, if the pull request gets merged successfully I will hopefully work towards 100% test coverage for the package <3

Codecov Report

Merging #2 into master will increase coverage by 1.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   84.61%   86.04%   +1.43%
==========================================
  Files           4        4
  Lines          39       43       +4
  Branches        2        3       +1
==========================================
+ Hits           33       37       +4
  Misses          6        6

Impacted Files
Coverage Δ

src/lib/components/MobileTable/MobileTable.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28726b5...25f92b0. Read the comment docs.

I meant to merge into develop...


name collision on pylab

http://depsy.org/package/python/pylab which is https://pypi.python.org/pypi/pylab / https://github.com/javipalanca/pylab which is a stub package which is squating on a package on pypi that is shipped by matplotlib.

pylab has been removed from pypi (https://github.com/javipalanca/scibag/issues/1)


Fix statistics cards accessibility announcements (EXPOSUREAPP-10650)

Addresses EXPOSUREAPP-10650

Brings the content description for screen readers for the statistic cards up to date
Fixes wrong announcements
Adds missing announcements

I guess this one needs to me moved to 2.15?


ENS config use the actual network ID

Overview
TL;DR
Instead of relying on the name of network.
Fetch the real network id and configure ENS
based on that value
The configuration is now done when web3 is ready
Cool Spaceship Picture

Please wait for #845 before merging this.


Serialization issue with elasticsearch and mongo connector

When I try to use the mongo-connector to send a field that is a UUID that isn't the _id field it throws a serialization error:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/mongo_connector/oplog_manager.py", line 439, in dump_collection
dm.bulk_upsert(docs_to_dump())
File "/usr/local/lib/python2.7/dist-packages/mongo_connector/doc_managers/elastic_doc_manager.py", line 41, in wrap
return func(_args, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/mongo_connector/doc_managers/elastic_doc_manager.py", line 122, in bulk_upsert
chunk_size=self.chunk_size)
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/helpers/init.py", line 145, in bulk
for ok, item in streaming_bulk(client, actions, *_kwargs):
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/helpers/init.py", line 104, in streaming_bulk
resp = client.bulk(bulk_actions, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/client/utils.py", line 68, in _wrapped
return func(_args, params=params, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/client/init.py", line 646, in bulk
params=params, body=self._bulk_body(body))
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/client/init.py", line 135, in _bulk_body
body = '\n'.join(map(self.transport.serializer.dumps, body))
File "/usr/local/lib/python2.7/dist-packages/elasticsearch/serializer.py", line 47, in dumps
raise SerializationError(data, e)
SerializationError: ({u'ProjectId': UUID('45251a04-7e63-be43-a848-a2377ba87f12'), u'_id': '0003bcd2-240c-1f44-8d0f-a0acae5714b3', 'ns': 'files.filemain', '_ts':<PHONE_NUMBER>115158529}, TypeError())

I know this issue is closed, but I had a related question. The connector uses uuid.hex to convert mongo UUIDs to string, to be stored in Elasticsearch. My code is in scala, and the standard API expects a UUID in the hyphenated string format that is returned by str(uuid) in python. Since converting these to my expected format in the scala code isn't very palatable for a few reasons, I was thinking of forking the repo and overriding just that part. That is, use str(uuid) instead of uuid.hex. Would that be a bad idea?


Fix errors when closing floating docks

Fixes 2 errors that could get thrown when closing docks. Also makes floating docks restore to their correct ordering when redocking as a result.
dock->get_index() on line 4463 was not behaving as expected due to dock having an internal sibling, so now we just get the index excluding internal nodes.
line 4742 would also throw an error if you made multiple docks floating then redocked the end docks first.

Thanks!

Cherry-picked for 4.0.1.


Workaround for having 2 IPs on an interface at start

Problem is with VirtualBox and its default DCHP server
Fixes #729

I was able to reproduce this problem by:

destroying all my vagrant machines
removing all the vboxnet[0-9] interfaces that ip a reported
doing vagrant up with the unchanged Vagrantfile and cloud configs
Check ip a for each VM once vagrant up returned.

See multiple ip addresses reported for the eth1 interface

With the changes in the PR, doing the same steps as above the eth1 interface only had the expected IP address as set in the Vagrantfile.

I still can't get this to work.  I wasn't hitting the problem with the docker coreOS demo, but I was with the rkt demo.  I added the same incantation to the rkt demo to no avail.
ifconfig down and up on didn't seem to do anything when I was ssh'd into calico-01
core@calico-01 ~ $ sudo ifconfig  eth1 down
core@calico-01 ~ $ sudo ifconfig  eth1 up
core@calico-01 ~ $ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 08:00:27:2f:c5:52 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic eth0
       valid_lft 86015sec preferred_lft 86015sec
    inet6 fe80::a00:27ff:fe2f:c552/64 scope link
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 08:00:27:62:bd:e9 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic eth1
       valid_lft 809sec preferred_lft 809sec
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth1
       valid_lft forever preferred_lft forever
    inet6 fe80::a00:27ff:fe62:bde9/64 scope link
       valid_lft forever preferred_lft forever

output from host:
vboxnet0: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500
	ether 0a:00:27:00:00:00
	inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
vboxnet1: flags=8842<BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	ether 0a:00:27:00:00:01
vboxnet2: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	ether 0a:00:27:00:00:02
	inet <IP_ADDRESS> netmask 0xffffff00 broadcast <IP_ADDRESS>
vboxnet3: flags=8842<BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	ether 0a:00:27:00:00:03
vboxnet4: flags=8842<BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	ether 0a:00:27:00:00:04

With the docker coreOS demo, it uses a different 172 subnet:
core@calico-01 ~ $ ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 08:00:27:2f:c5:52 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic eth0
       valid_lft 86256sec preferred_lft 86256sec
    inet6 fe80::a00:27ff:fe2f:c552/64 scope link
       valid_lft forever preferred_lft forever
3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
    link/ether 08:00:27:6b:12:db brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global eth1
       valid_lft forever preferred_lft forever
    inet6 fe80::a00:27ff:fe6b:12db/64 scope link
       valid_lft forever preferred_lft forever
4: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:49:0f:87:0d brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 scope global docker0
       valid_lft forever preferred_lft forever

As suggested by @tmjd, I tried adding the following to the vagrant files:
      host.vm.provision :shell, :inline => "sudo /usr/bin/ip addr flush dev eth1"
      host.vm.provision :shell, :inline => "sudo /usr/bin/ip addr add #{ip}/24 dev eth1"

which seems to do the trick nicely.

LGTM.
@tmjd Are you needing me to test this before merge (which may not happen until later)

@robbrockbank I just brought up each of those Vagrant environments and checked that the eth1 devices had the one expected IP address.


[CS] Add PHPStan rule that makes sure that constant expression are defined in __construct or setUp() method

:no_entry:
This is always the same, so should be defined once in the __construct method instead

@TomasVotruba do you meant assignment against constant must be in __construct() or setUp() ?

Yes, basically whole last line.
It's never changed, but it's in a variable. So it's looks like something that does change, which is not true

Should be refactored too:
public funciton __construct()
{
    // A
   	$this->sonartConfigFilePath = ...

    // B - never changed
	self::SONAR_CONFIG_FILE_PATH = ...
}


Add album art to notifications

Displays the currently playing song's album art in the notification.

I think if we work together we can add some cool features. Thank you for creating this project.

Merged in 2633f925a1e1eba317d23eb090a68b718090c0fb. Apologies for not updating here...
Thanks for contributing @kinglime! 🥂

@salomvary you're welcome mate, will work on touchbar support now.


custom training dataset, ChatDataset - understanding parameter train_on_input

I have followed the tutorial https://pytorch.org/torchtune/main/tutorials/chat.html, using it as reference and managed to fine tune both LLama2, and LLama3 with a custom dataset. (Lora single device)
The tutorial has proven very helpful but there is one part where I am confused.  In the tutorial (which I followed), a message_converter function is provided which takes the parameter train_on_input (below).
def message_converter(sample: Mapping[str, Any], train_on_input: bool) -> List[Message]:
    input_msg = sample["input"]
    output_msg = sample["output"]

    user_message = Message(
        role="user",
        content=input_msg,
        masked=not train_on_input,  # Mask if not training on prompt
    )
    assistant_message = Message(
        role="assistant",
        content=output_msg,
        masked=False,
    )
    # A single turn conversation
    messages = [user_message, assistant_message]

    return messages

The code from the tutorial which references the message_converter, custom_datset, instantiates and returns a ChatDataset object, where no value is passed for train_on_input.  Looking into the source for ChatDataset, the parameter train_on_input is false by default.
Based on this, and reviewing the message_converter, is the behaviour intended by the tutorial:

when the role of message is user, set the 'masked' parameter to true (the negative of train_on_input, which is default false)
when the role of message is assistant, always set the 'masked' parameter to false.

It would be great if this can be clarified, as I found it fairly confusing

I was having the similar confusions as well,
It's mentioned in
    - If ``train_on_input`` is True, the prompt is used during training and
    contributes to the loss.
    - If ``train_on_input`` is False, the prompt is masked out (tokens replaced with -100)

My understanding is the following:

Fine-tuning is always based on text-completion, though there are other fancy types like "chatDataset" etc, they are ultimately using text-completion with extra steps. e.g. concatenate your system & user & assistant messages and add some tags in between, etc.
Thus, for example if your training data looks like  "user: write xxx algorithm in Python. assistant: ". If you set train_on_input to True, and after training if your inference prompt looks like "user: write xxx algorithm in", the model will more likely continue by writing "Python" , rather than Java, c++, etc.

@JinchuLi2002, thanks for the response, and sharing the understanding. It has helped make my understanding of train_on_input much clearer.  The same pattern looks to apply to Axolotl too Axolotl Config Options.
As an aside, you might be interested in the paper, Instruction Tuning With Loss Over Instructions, it highlights - use case dependent - it can be of benefit to have the loss applied to the instruction and output, over output alone.


Use reportName for invoice reports

Explanation of Change

The PR unifies the name of the report the app uses for invoice reports. reportName will be used as a primary everywhere.
Fixed Issues

$ https://github.com/Expensify/App/issues/53914
$ https://github.com/Expensify/App/issues/53694
PROPOSAL: N/A
Tests

Precondition:
Invoices are enabled.

Go to FAB > Send invoice.
Send an invoice to anyone.
In invoice room, click on the invoice preview.
Click on the report title.
Click on the invoice title.
Rename and save it.
Verify that the invoice title should be changed.
Verify that the invoice titles are the same across the app in header, RHP and Search page.

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests.
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/92870789-beb0-4511-96b5-49ff00775a4d

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/d389acb0-1321-4f0a-a982-3f91e3970a9b

MacOS: Desktop

https://github.com/user-attachments/assets/21195fc7-cc10-4f9e-971e-df0a3149190c

If we create wa orkspace offline and request an invoice, when clicking the invoice header, the sender is empty:
Here's an example on staging:
https://github.com/user-attachments/assets/271ebc6c-4ead-4a65-a82c-c78f59119dcc
Here's an example in our PR:
https://github.com/user-attachments/assets/90fb8394-8c91-44b2-ba8f-98ac5f719d4a
Here's the steps:

Enable offline mode.
Create a new workspace and enable Invoice.
Request an invoice with a brand new email.
Click on that invoice and observe the header.

@hungvu193, I've understood why we have the issue. The app does not generate the reportName for invoice reports. Let me fix it.

To clarify: the app optimistically generates the reportName, but it was the legacy format. I've updated to use the modern way like "Invoice 2024-12-16". Commit - e5a3a45.
Video

https://github.com/user-attachments/assets/4accba02-6d66-438a-9fd3-ed5cc37ca979

cc @hungvu193 @cristipaval

I've updated to use the modern way like "Invoice 2024-12-16".

I think it looks good to me 👍

@cristipaval, it means for Invoices sent via NewDot we still use different names to preview and to edit.

This seems to modify the invoice rep...

@cristipaval, I've fixed - 95e6276.
Video

https://github.com/user-attachments/assets/b6fc0f66-669c-4aa0-b981-9dadd4e6125c

This seems to modify the invoice rep...

@cristipaval, I've fixed - 95e6276.
Video

Thanks a lot, @rezkiy37! 🙏
Could you please update the test steps to make sure we test both OldDot and NewDot invoices? Also, @hungvu193 could you please retest?

I can confirmed it's fixed 🎉
https://github.com/user-attachments/assets/3b80b3ac-e18a-4d56-9a33-07c965eff0f4

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Load all modules

Make sure to load all modules, both console and web, to prevent false negative because custom functions are not loaded

Fixed in 0.2.0

Fixed in 0.2.0


Isolate User Devices

Looking for a feature to block devices from each user from communicating with other user devices. I tried creating rules in the Egress Rules but I couldn't get what I had in mind working. Thank you.

Thanks for the suggestion!  Tracking this in https://github.com/firezone/firezone/issues/833


Unable to mount Ceph buckets

Hi,
I'm unable to mount any buckets with a Ceph RGW storage backend.
goofys --debug_s3 --debug_fuse -f --endpoint https://s3.example.com swap .ceph/swap
2018/08/07 12:55:36.082087 s3.DEBUG HEAD https://s3.example.com/swap = 404 []
2018/08/07 12:55:36.082279 s3.DEBUG Content-Type = [application/xml]
2018/08/07 12:55:36.082295 s3.DEBUG Date = [Tue, 07 Aug 2018 10:55:36 GMT]
2018/08/07 12:55:36.082306 s3.DEBUG Content-Length = [203]
2018/08/07 12:55:36.082316 s3.DEBUG X-Amz-Request-Id = [tx0000000000000000077f1-005b697aa8-a32dd9-ix]
2018/08/07 12:55:36.082343 s3.DEBUG Accept-Ranges = [bytes]
2018/08/07 12:55:36.082357 main.ERROR bucket swap does not exist
2018/08/07 12:55:36.082370 main.FATAL Mounting file system: Mount: initialization failed
I can use any other client to browser at least without any sort of issue. For this matter I'm using mc and s3cmd, and to mount I'm using s3fs.

With mc:
mc ls ceph
[2018-07-30 22:25:13 CEST]     0B swap/

WIth s3cmd:
s3cmd ls
2018-07-30 20:25  s3://swap

go version go1.10.3 darwin/amd64
goofys version 0.19.0-943e017724ea820eb4185419ef3c41d6f921a324
Do you have any clue about this issue?
Is it related with this: https://github.com/aws/aws-sdk-go/issues/400
Thanks,
G.

goofys has its own copy of s3 v2 signing so the reference issue is not the problem. I don't have access to ceph however so I can't debug this myself. If you can expose this somewhere and email me a key (email on my profile page) I can take a look.


MINOR: cleanTest ought to remove output of unitTest task and integrat…

The command used by our private CI is ./gradlew cleanTest xxx:test. It does not re-run test when we use unitTest and integrationTest to replace test. The root cause is that we don't offer test output (unitTest and integrationTest) to cleanTest task and so it does not delete related test output.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

BTW, this patch fixes the commands in readme (https://github.com/apache/kafka/blob/trunk/README.md#force-re-running-tests-without-code-change)


No print output in IP console when running print code from editory reffering to issue #12090

Issue Report Checklist
[x ] Searched the issues page for similar reports
[x ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
Could not reproduce inside jupyter qtconsole (if console-related)
[x ] Tried basic troubleshooting (if a bug/error)
[x ] Restarted Spyder
[x ] Reset preferences with spyder --reset
x[ ] Reinstalled the latest version of Anaconda
Tried the other applicable steps from the Troubleshooting Guide
[x ] Completed the Problem Description, Steps to Reproduce and Version sections below
Problem Description
When running a file or cell with print functions in them, they produce no output (for example hello world gives no output.
What steps reproduce the problem?
Open or write simple print("Hello World") function
Run cell or file
No print output in the IP console
What is the expected output? What do you see instead?
Expected:
In [1]: runfile('C:/.../HelloWorld.py', wdir='C:/...)
Hello world
Instead:
In [1]: runfile('C:/.../HelloWorld.py', wdir='C:/...)
Versions
Spyder version: 4.1.1
Python version: 3.7.7
Qt version: 5.9.7
PyQt version: 5.9.2
Operating System name/version: Windows 10.0 Build 18362
Dependencies
Mandatory:
atomicwrites >=1.2.0           :  1.3.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.3.0 (OK)
diff_match_patch >=20181111    :  20181111 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.13.0 (OK)
jedi =0.15.2                   :  0.15.2 (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  0.9.2 (OK)
paramiko >=2.4.0               :  2.7.1 (OK)
parso =0.5.2                   :  0.5.2 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.0 (OK)
pygments >=2.0                 :  2.6.1 (OK)
pylint >=0.25                  :  2.4.4 (OK)
pyls >=0.31.9;<0.32.0          :  0.31.9 (OK)
qdarkstyle >=2.8               :  2.8 (OK)
qtawesome >=0.5.7              :  0.7.0 (OK)
qtconsole >=4.6.0              :  4.7.2 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
rtree >=0.8.3                  :  0.9.3 (OK)
sphinx >=0.6.6                 :  2.4.4 (OK)
spyder_kernels >=1.9.0;<1.10.0 :  1.9.0 (OK)
watchdog                       :  None (OK)
zmq >=17                       :  18.1.1 (OK)
Optional:
cython >=0.21                  :  0.29.15 (OK)
matplotlib >=2.0.0             :  3.1.3 (OK)
numpy >=1.7                    :  1.18.1 (OK)
pandas >=0.13.1                :  1.0.3 (OK)
scipy >=0.17.0                 :  1.4.1 (OK)
sympy >=0.7.3                  :  1.5.1 (OK)

Please open the Anaconda Prompt and run there
jupyter qtconsole

Then run
print('Hello world')

and see if it works or not.

#%%
def hello():
print("Hello, world!")
Thats the cell

In the qtconsole i get a output

I also get an output when i tipe the print function directly in the ip console

When i write the function in the editor and run it i get no output

This could be an issue with your firewall or antivirus. Please deactivate them and try again.

Thank you for the suggestion
With everything (Firewall and Antivirus) deactivated still same results :/

Sorry, I have no more ideas. This has been reported by only one more person before, so we don't know what's causing it.

In the meantime, you can to the menu:
Tools > Preferences > Editor > Run code

and activate the option called
Copy full cell contents to the console when running code cells

and run the file with Shift+Enter or Ctrl+Enter. That should work.

Thanks anyways for the help!
Copying full cell contents still gives no outputs :/

Could you a screenshot of what you're seeing? Copying cell contents is equivalent to writing your code in the console and pressing Enter to evaluate it.

You're still using runcell in your first command, meaning that it seems you haven't activated the option I told you about.

oh sorry, i had it and deactivated it again. Mom

@uncrushedIce
The error is that your code doesn't do anything but define functions.
Python doesn't run a function when it is defined only when it called.
At the bottom of your file write:
%##
hello()

And run the cell to see hello world


Allow log-level names to be case-insensitive

My fingers keep typing haas --log-level=WARNING. This PR allows the argument of the --log-level command-line option to be case-insensitive.

Thanks!


Bump versions, fix old info

This prepares for a release of 0.3.0, removes old info and improves the Helm chart.
This also adds a "image-push" target to help with releases. It's not ideal, but it works and doesn't leave us releasing from a dirty checkout.

/test pull-cert-manager-csi-driver-spiffe-verify
Flake, no code changes in this PR


When I run demo.m, I came into the error of "mpolar function undefined".

I recompiled the utility/mpolar.cpp with mex using VS2015 and opencv3.4.3, and I came into the following error
错误使用 mex mpolar.cpp d:\jiangshan\open_source\ldes\utility\opencv_matlab.hpp(233): warning C4244: “=”: 从“double”转换到“float”，可能丢失数据 D:\JiangShan\open_source\LDES\utility\mpolar.cpp(28): error C2440: “初始化”: 无法从“const size_t *”转换为“const int *” D:\JiangShan\open_source\LDES\utility\mpolar.cpp(28): note: 与指向的类型无关；转换要求 reinterpret_cast、C 样式转换或函数样式转换 D:\JiangShan\open_source\LDES\utility\mpolar.cpp(29): warning C4267: “初始化”: 从“size_t”转换到“int”，可能丢失数据 D:\JiangShan\open_source\LDES\utility\mpolar.cpp(29): warning C4267: “初始化”: 从“size_t”转换到“const int”，可能丢失数据
Then I modified line 28 of mpolar.cpp like this:
const int *dimsA    = (const int*)mxGetDimensions(prhs[0]);
I successfully compiled mpolar.cpp, but when I ran demo.m again, it threw the following exception:
`
MEX 文件出现意外的标准异常。
What() 是: OpenCV(3.4.3) C:\build\3_4_winpack-build-win64-vc14\opencv\modules\core\src\matrix_c.cpp:181: error: (-5:Bad argument) Unknown array type
in function 'cv::cvarrToMat'
。.
`
There are no problem with other mex files.

Thanks for your comment @soldatjiang . I have updated the files and tested the code with OpenCV 2.4 in Windows. I upload the mpolar.mexw64. Would you please try again and let me know whether it works with OpenCV 3?

I tested the code and put opencv_core2413.dll and opencv_imgproc2413.dll in the root directory and it works. You can include these two dlls in your repository so that others can run your code without any configuration. I will test it with OpenCV 3 soon.

I tested the code and put opencv_core2413.dll and opencv_imgproc2413.dll in the root directory and it works. You can include these two dlls in your repository so that others can run your code without any configuration. I will test it with OpenCV 3 soon.

Thanks, @soldatjiang . The dll files should be in the environment path when OpenCV is installed properly. I will keep it without dll since it is platform-specific.

I recomiled it with OpenCV 3 and it works properly. Here is my compile script on my windows 7 x64 machine.
include_path = ['-I','D:\Program Files\opencv343\build\include'];
link_lib = fullfile('D:\Program Files\opencv343\build\x64\vc14\lib','opencv_world343.lib');
mex('-v',include_path,'mexResize.cpp','MxArray.cpp',link_lib)
mex('-v',include_path, 'mpolar.cpp', link_lib)
mex('-v',include_path, 'getColorSpace.cpp', link_lib)
mex('-v',include_path, 'getColorSpaceHist.cpp', link_lib)

@Adhders Have you solved this problem?

@Adhders Have you solved this problem?

No!
I have MEX files successfully ,but it can't run normally  in windows;
The error message shows that:
Invalid MEX-file 'C:\Users\junbo\Desktop\LDES-master\utility\mexfiles\mpolar.mexw64': The specified module could not be found..
Error in logupdate (line 37)
patchL = mpolar(double(patchL),p.mag);
Error in tracker (line 55)
p = logupdate(1,im, pos, tmp_sc,tmp_rot,p);
Error in demo (line 22)
[~,rects,~,~,~, time] = tracker(video_path, img_files, pos, target_sz, rot, show_visualization);

@Adhders Recompile the mex files and try again

Have you solved this problem?
my configuration is Win10, Matlab2016b, VS2017 ,opencv2.4.11,

@Adhders Have you recompiled the mex file? What problem did you meet? You can try to compile the mex files using my compiling script. Note that you should modify the path according to your configuration.

@Adhders Have you recompiled the mex file? What problem did you meet? You can try to compile the mex files using my compiling script. Note that you should modify the path according to your configuration.
I have mex files successfully

@Adhders Have you recompiled the mex file? What problem did you meet? You can try to compile the mex files using my compiling script. Note that you should modify the path according to your configuration.

how and where to modify the path, I am new to Matlab. what does compile.m file used for?

Hi, if you can compile the mpolar.cpp, it should be okay for running the code.

@Adhders Have you solved this problem?

No!
I have MEX files successfully ,but it can't run normally in windows;
The error message shows that:
Invalid MEX-file 'C:\Users\junbo\Desktop\LDES-master\utility\mexfiles\mpolar.mexw64': The specified module could not be found..
Error in logupdate (line 37)
patchL = mpolar(double(patchL),p.mag);
Error in tracker (line 55)
p = logupdate(1,im, pos, tmp_sc,tmp_rot,p);
Error in demo (line 22)
[,rects,,,, time] = tracker(video_path, img_files, pos, target_sz, rot, show_visualization);

Hi, it seems like you did not install your OpenCV correctly. Have you included the OpenCV path in your environment?

@Adhders Have you solved this problem?

No!
I have MEX files successfully ,but it can't run normally in windows;
The error message shows that:
Invalid MEX-file 'C:\Users\junbo\Desktop\LDES-master\utility\mexfiles\mpolar.mexw64': The specified module could not be found..
Error in logupdate (line 37)
patchL = mpolar(double(patchL),p.mag);
Error in tracker (line 55)
p = logupdate(1,im, pos, tmp_sc,tmp_rot,p);
Error in demo (line 22)
[,rects,,,, time] = tracker(video_path, img_files, pos, target_sz, rot, show_visualization);

Hi, if you can compile the mpolar.cpp, it should be okay for running the code. It seems like you did not install your OpenCV correctly. Have you included the OpenCV path in your environment?

you are right!, I make it in windows with opencv 3.3.0, Thansk very much!

I recompiled all mex files with OpenCV 3 and it works properly. Here is my compile script on my windows 7 x64 machine.
include_path = ['-I','D:\Program Files\opencv343\build\include'];
link_lib = fullfile('D:\Program Files\opencv343\build\x64\vc14\lib','opencv_world343.lib');
mex('-v',include_path,'mexResize.cpp','MxArray.cpp',link_lib)
mex('-v',include_path, 'mpolar.cpp', link_lib)
mex('-v',include_path, 'getColorSpace.cpp', link_lib)
mex('-v',include_path, 'getColorSpaceHist.cpp', link_lib)

Thanks for your script @soldatjiang

I am getting this issue. Could you help me solve this, please?

mex mpolar.cpp
Building with 'Microsoft Visual C++ 2017'.
Error using mex
mpolar.cpp
G:\Documents\LDES-master - Copy\utility\mexfiles\mpolar.cpp(3): fatal error C1083: Cannot open include file: 'opencv2/opencv.hpp': No such file
or directory

include_path = ['-I','D:\Program Files\opencv343\build\include']; link_lib = fullfile('D:\Program Files\opencv343\build\x64\vc14\lib','opencv_world343.lib'); mex('-v',include_path,'mexResize.cpp','MxArray.cpp',link_lib) mex('-v',include_path, 'mpolar.cpp', link_lib) mex('-v',include_path, 'getColorSpace.cpp', link_lib) mex('-v',include_path, 'getColorSpaceHist.cpp', link_lib)
You can complile mpolar with this script, modify include_path and link_path according to your configuration.