[release-1.10] Fix Kubernetes Ingress and Gateway prefix match

Manual cherrypick required.
#34295 failed to apply on top of branch "release-1.10":
Applying: Fix Kubernetes Ingress prefix match
Using index info to reconstruct a base tree...
M	tests/integration/pilot/ingress_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/ingress_test.go
CONFLICT (content): Merge conflict in tests/integration/pilot/ingress_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Kubernetes Ingress prefix match
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

dupe


Inaccuracy with total_rounds_played

I'm not sure if it's bug with parser or something wrong with demos, but I noticed some inaccuracy with total_rounds_played. Sometimes it shows event in wrong round.
Example. Frag at 110006 should be in previous round.
const events = parseEvent(
	"./demos/vitality-vs-faze-m3-nuke.dem",
	"player_death",
	["is_warmup_period", "team_name", "team_clan_name", "team_rounds_total"],
	["total_rounds_played"]
);

(index)
attacker_name
tick
total_rounds_played
user_name

6
'ropz'
80026
11
'flameZ'

7
'ropz'
102804
14
'ZywOo'

8
'ropz'
109736
15
'Magisk'

9
'ropz'
109814
15
'flameZ'

10
'ropz'
109859
15
'Spinx'

11
'ropz'
109897
15
'ZywOo'

12
'ropz'
110006
16
'apEX'

13
'ropz'
114951
16
'flameZ'

14
'ropz'
115508
16
'Spinx'

Demo:
https://www.hltv.org/matches/2367247/vitality-vs-faze-iem-sydney-2023
Clip:
https://clips.twitch.tv/SilkyRespectfulMallardMVGame-DK4ADev1iF-YlZgN

Likely because it's last kill of round and it counts it as next round. Again, not sure if it's bug or feature 😄
Workaround to fix it:
Parse with extra prop round_win_status, then check for it and adjust
const fixed = events.map((frag) => {
	if (frag.round_win_status != 0) {
		return {
			...frag,
			total_rounds_played: frag.total_rounds_played - 1,
		};
	}
	return frag;
});

Thanks for the detailed example. Was able to reproduce and also fix (but this will be tricky).
The problem is: should game events be parsed before entity updates during a tick. Here the parser updates entities (including the total_rounds_played prop) before the game event is emitted.
Not so long ago I implemented it so that entities are always parsed before game events. But looking at this I might have to revert it. Will likely revert in next release

This should now be fixed in 0.13.0. The parser now chooses the packet order based on the game event.

Assume this is fixed, re-open if problems appear


[hi] localize stateful-apps.md to Hindi

content: https://github.com/cncf/glossary/blob/main/content/en/stateful-apps.md

@Garima-Negi mam I want work on this, can you please assign this issue to me.

Hello @Garima-Negi, I've already localized one topic. It'd be great if you assign this to me. I'll open a PR as soon as possible.

Assigning @VaibhavJangid in order of commenting.
Please start a PR for this issue in 2 weeks.
I shall reassign if there's no activity for this issue. Thanks you guys!

is anyone currently working on it

Hey @Garima-Negi, I've been asking you to assign this issue to me. I've already translated one page. It'd be great if you let me do this page too.

Go further @AniketNS

Hey @kumarankit999, I've created the PR. Will you please check and let me know is there any corrections I should do?

@Garima-Negi nobody is working so if you don't mind I can do this, once you will assign me

Hey, @AniketNS are you working on this???

I have also asked above for assign

@Garima-Negi , @kumarankit999  can you please assign this issue to me. I asked around 1 month ago to assign. I didn't find anyone who is working on it

Hey @AniketNS Reminder that you are working on this Issue!

@kumarankit999 Please check if @AniketNS  is working on this issue or not

@bishal7679 Please check if @AniketNS is working on this issue or not

Hey @AniketNS Can you refer the PR Which you have created for this Issue!!

Hey @kumarankit999, I've worked on this already. I'll be making the PR shortly after correcting some issues.

Ok, Go Ahead!

Hey @kumarankit999, I've made the PR  with suggested changes. Can you please check once and tell me, if any changes still have to be made?


Missing sitemap

Although there is only a single page, I'd like to see a sitemap to improve SEO.

This enhancement has been made and is now live in production.
It's also worth noting that a robots.txt has also been added to improve SEO. I aim to create a PR for the express-sitemap module that's been used to get the sitemap linked to from robots.txt. For example;
User-agent: *
Disallow:
Sitemap: http://www.thebroonline.com/sitemap.xml


Add a after_batch hook on the each_message method

This is not a bug, is more of a feature request, that if accepted I am glad to work on a PR to implement it.
My use case
I am using each_message in a lot of different consumer processors. However, I have a few that needs to do something after a batch is processed. Today, I could use the each_batch for those. However, using each_message gives me the heartbeat trigger after each message, so it is safer, as we can have lower session timeouts.
Proposal
Add an after_batch hook to the each_message method. So we can still use it, but have a place to execute code after each batch is done.

Have you started by trying to call the heartbeat method manually within each_batch to get your desired behavior?

Yes, however that would raise an issue if a rebalance is happening.


adding exception handling for transforms creation

Why are these changes needed?
Without this we can get into infinite loop of errors, which overwhelms the logger
Related issue number (if any).

Oh, there is an interesting thing with Ray, actor init exception is not propagated, as it is a separate process. Hopefully it is fixed now


Bump Fluent Bit to 2.2.1

Description
FluentBit 2.2.1 got released with important library updates. The rollout of FluentBit 2.2.0 was stopped as an important metric on the tail input was zeroed, that should be fixed as well.
Also, we should take the chance and finally get rid of the sequential_http plugin, please wipe it out as it is not in use anymore.
Criterias

Fluentbit is updated to 2.2.1 (or update is topped because of serious findings which are documented here)
All metrics are working as expected
No performance degredations
Integration tests are working

The issue with the input metric https://github.com/fluent/fluent-bit/issues/8287 is indeed fixed in 2.2.1

No significant difference in resource consumption was found compared to 2.10.1

⚠ Since we do not build sequential_http custom plugin anymore, the dryrun command had to be adapted


sheetTabContextMenu not respected

Describe the bug
sheetTabContextMenu properties seem to be ignored.
To Reproduce
Steps to reproduce the behavior:

Add custom menu as array of string values
Right mouse click a sheet tab

Expected behavior
The context menu should appear
Screenshots

Additional context
cellContextMenu works partially (updating props changes the items) but also here I see that there no 1 - 1 correspondence, and the contextMenu even shows empty cells at the bottom of the contextMenu when propagating the changed array.

Right-clicking the menu will only bring up the functionality already done in the sheetTabContextMenu and cellContextMenu properties, and the display whitespace issue will be resolved.


User location

I have a problem. Where I must add message.location.latitude command to get the user's location after getting message with location. Can you add simple example of getting user's latitude and longitude from message. I need this two parameters to build weather bot. Thanks for advice. :) 👍

You mean getting it as some kind of button inputs or just user sending you location?

User sends me location bu a button and i have to get this location in numerical variables, not a map on chat.

Is it still a problem? Ready to help but was on holidays :)

Yeah, I have same problem for a month. I couldn't solve it. Tried everything. That's link to my code on stackoverflow: https://stackoverflow.com/questions/52017058/cant-get-longitude-and-latitude-in-telegram-bot-ruby
I think i may be a API bug. Thanks for help

I don't know what to do.

Have the answer from SO worked?

Yup, everything Is working fine.
Thanks for advice 👍


Add state.extend

Is your feature request related to a problem? Please describe.
Append is easy, extend requires either a set, or multiple in a loop.
Describe the solution you'd like
state = State({"a" : [1,2,3]}) # initialize
state = state.extend(a=[4,5,6]) # update
state

{"a" : [1,2,3,4,5,6]}

Describe alternatives you've considered
just setting the list. Or calling in a loop.
Additional context
From discord

to add more: I work with actions that emit one or more chat items to the chat history. In the decorator-func syntax, it is easy to handle it. I simply update the state within the body of the func and can append as many as items to the same container in the state machine. or chain append methods in the return statement.
state=state.append(chat_history=chat_item1)
if cond:
    state=state.append(chat_history=chat_item2)

return state.append(
    chat_history=chat_item3
).append(
    chat_history=chat_item4)

Now working with class based syntax for actions, I find it difficult to do it as the main logic happens in the run method where I update the result dict rather than the state object. Since I cannot repeat the keys in the dict, I have to collect all the chat items in the result dict in some form and then update the state in the update method.
I can create a container with the same name as in the state machine and append all the chat items to the container in the run method, and when it comes to the update method, I can iterate and do as I did in the above example:
# run method
result = {"chat_history": []}

result["chat_history"].append(chat_item1)
if cond:
    result["chat_history"].append(chat_item2)

# update method
for key, value in results.items():
    if key="chat_history":
        for item in value:
            state = state.append(chat_history=item)

Works.
This is the example I testes:
from burr.core import action, State, ApplicationBuilder
from burr.core import Action

@action(reads=[], writes=["chat_history"])
def human_input(state: State, prompt: str) -> State:
    # your code -- write what you want here!
    return state.append(chat_history=prompt)

# @action(reads=["chat_history"], writes=["response", "chat_history"])
# def ai_response(state: State) -> State:
#     # response = _llm_query.query(state["chat_history"]) # Burr doesn't care how you use LLMs!
#     return state.update(response="content").append(chat_history="content1", chat_history="content2")

class AIResponse(Action):
    def __init__(self):
        super().__init__()

    def run(self, state: State, **run_kwargs) -> dict:
        result = {"chat_history": ["first_item", "second_item"]}
        return result

    def update(self, result: dict, state: State) -> State:
        for key, value in result.items():
            if key.startswith("_"):
                continue
            elif key == "chat_history":
                state = state.extend(chat_history=value)
            else:
                raise ValueError(f"Key {key} is not valid")
        return state

    @property
    def reads(self) -> list[str]:
        return ["chat_history"]

    @property
    def writes(self) -> list[str]:
        return ["chat_history"]

app = (
    ApplicationBuilder()
    .with_actions(
        human_input=human_input,
        ai_response=AIResponse()
    ).with_transitions(
        ("human_input", "ai_response"),
        ("ai_response", "human_input")
    ).with_state(chat_history=[])
    .with_entrypoint("human_input")
    .build()
)
*_, state = app.run(halt_after=["ai_response"], inputs={"prompt": "Who was Aaron Burr, sir?"})
print("answer:", app.state["chat_history"])

and the output is:
answer: ['Who was Aaron Burr, sir?', 'first_item', 'second_item']

Works.
This is the example I testes:
from burr.core import action, State, ApplicationBuilder
from burr.core import Action

@action(reads=[], writes=["chat_history"])
def human_input(state: State, prompt: str) -> State:
    # your code -- write what you want here!
    return state.append(chat_history=prompt)

# @action(reads=["chat_history"], writes=["response", "chat_history"])
# def ai_response(state: State) -> State:
#     # response = _llm_query.query(state["chat_history"]) # Burr doesn't care how you use LLMs!
#     return state.update(response="content").append(chat_history=["first_item", "second_item"]) # fails

class AIResponse(Action):
    def __init__(self):
        super().__init__()

    def run(self, state: State, **run_kwargs) -> dict:
        result = {"chat_history": ["first_item", "second_item"]}
        return result

    def update(self, result: dict, state: State) -> State:
        for key, value in result.items():
            if key.startswith("_"):
                continue
            elif key == "chat_history":
                state = state.extend(chat_history=value)
            else:
                raise ValueError(f"Key {key} is not valid")
        return state

    @property
    def reads(self) -> list[str]:
        return ["chat_history"]

    @property
    def writes(self) -> list[str]:
        return ["chat_history"]

app = (
    ApplicationBuilder()
    .with_actions(
        human_input=human_input,
        ai_response=AIResponse()
    ).with_transitions(
        ("human_input", "ai_response"),
        ("ai_response", "human_input")
    ).with_state(chat_history=[])
    .with_entrypoint("human_input")
    .build()
)
*_, state = app.run(halt_after=["ai_response"], inputs={"prompt": "Who was Aaron Burr, sir?"})
print("answer:", app.state["chat_history"])

and the output is:
answer: ['Who was Aaron Burr, sir?', 'first_item', 'second_item']

Works.
This is the example I testes:
from burr.core import action, State, ApplicationBuilder
from burr.core import Action

@action(reads=[], writes=["chat_history"])
def human_input(state: State, prompt: str) -> State:
    # your code -- write what you want here!
    return state.append(chat_history=prompt)

# @action(reads=["chat_history"], writes=["response", "chat_history"])
# def ai_response(state: State) -> State:
#     # response = _llm_query.query(state["chat_history"]) # Burr doesn't care how you use LLMs!
#     return state.update(response="content").append(chat_history=["first_item", "second_item"]) # fails

class AIResponse(Action):
    def __init__(self):
        super().__init__()

    def run(self, state: State, **run_kwargs) -> dict:
        result = {"chat_history": ["first_item", "second_item"]}
        return result

    def update(self, result: dict, state: State) -> State:
        for key, value in result.items():
            if key.startswith("_"):
                continue
            elif key == "chat_history":
                state = state.extend(chat_history=value)
            else:
                raise ValueError(f"Key {key} is not valid")
        return state

    @property
    def reads(self) -> list[str]:
        return ["chat_history"]

    @property
    def writes(self) -> list[str]:
        return ["chat_history"]

app = (
    ApplicationBuilder()
    .with_actions(
        human_input=human_input,
        ai_response=AIResponse()
    ).with_transitions(
        ("human_input", "ai_response"),
        ("ai_response", "human_input")
    ).with_state(chat_history=[])
    .with_entrypoint("human_input")
    .build()
)
*_, state = app.run(halt_after=["ai_response"], inputs={"prompt": "Who was Aaron Burr, sir?"})
print("answer:", app.state["chat_history"])

and the output is:
answer: ['Who was Aaron Burr, sir?', 'first_item', 'second_item']

Great! We're shipping in the next release, appreciate you testing it out.

This is complete!


Improve the readability of tutorial 2.2.

Preview of the formulas:

Cool, thanks!
A side note since I see that this PR comes from the main branch of your fork of Trixi.jl: It's usually better to work in a new branch. This helps keeping the commit history clean. For example, there are a lot of commits updating compressible Euler stuff in this PR (which are already merged into the main branch of Trixi.jl). Thus, the recommended workflow would be to

git checkout -b YOUR_NEW_BRANCH_NAME
Make some changes
git add and git commit them with a clear commit message
git checkout main and git pull to update your local main
git merge main from your new branch to include updates from our main

I'm modifying the source code in the web page. But I think I understand what you mean. Will create PR in this manner next time.

I'm modifying the source code in the web page. But I think I understand what you mean. Will create PR in this manner next time.

Ah, okay, that works, too. You should get the option to create a new branch (or something called like this) in the web interface of GitHub, too.

@xzczd Documenter.jl seems not to be able to process your modified LaTeX equation correctly, see the image below (taken from our dev docs at https://trixi-framework.github.io/Trixi.jl/dev/tutorials/adding_new_equations/nonconservative_advection/#nonconservative_advection). Any ideas how to fix this?

Oh… seems that Documenter.jl doesn't like blank \end{}. It's necessary to write it as \end{aligned}. I've created a new PR, now it should have been fixed. (Checked with Documenter.jl. )


Implement current_timezone()

@svm1 : Please can you collapse your commit to a single one and remove all the commented code. Would be helpful to review.

This PR was not ready for review, hence it was left in draft state with all the commented code. Will open a new one once issues are resolved.

Opened new PR due to squash & rebase issues on this branch - https://github.com/facebookincubator/velox/pull/6075


Raw RNN string output?

First, thank you for sharing this project.
I want to be able to see the raw RNN string output that isn't checked against a lexicon. For example, "L-EE-A-RR-N-I-NN-G" instead of "LEARNING".
What part of the architecture would I change to allow this to happen?
Thank you.

@dsandii How did you do that?


chart fails if the dex cluster role is already set

Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "chainloop-dex" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-namespace" must equal "chainloop": current value is "default"

Do we need to have a custom role? Wouldn't a role in the installation namespace be enough?
cc/ @javirln

Hmm first time seeing this. How did you manage to ge the error?
I would have to check but I believe there is an option to avoid the creation of the role if needed.

Hmm first time seeing this. How did you manage to ge the error?
I would have to check but I believe there is an option to avoid the creation of the role if needed.

I think I deployed it twice with the same name, maybe in different namespaces.
I've seen somewhere that we also create one for dex, maybe you can see how they do it, it might contain the option you mentioned.

I think I deployed it twice with the same name, maybe in different namespaces.

Just asking because all tests I've done were basically helm install and helm uninstall on the same namespace.
The have indeed this option: https://github.com/dexidp/helm-charts/blob/008b13f380042af430dddf970daba0138ff02809/charts/dex/values.yaml#L104
That is used on: https://github.com/dexidp/helm-charts/blob/008b13f380042af430dddf970daba0138ff02809/charts/dex/templates/rbac.yaml#L1

I ran again into this issue, I think it can be reproduced if you deploy Chainloop in two different namespaces. As you can see, the cluster-role has references to the namespace and this is potentially wrong.
  Error: Failed to render chart: exit status 1: Error: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "chainloop-dex" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-namespace" must equal "miguel-test": current value is "test-chainloop"

cc/ @javirln

We need to make sure that the clusterolebinding and clusterole do not have namespace references.
To reproduce, deploy the chart with the same release name in two different namespaces in development mode


Disable nginx provider entirely

Hi,
I'm running Kubernetes on GCE, and since I'm not using nginx at all, I thought specifying LEGO_SUPPORTED_INGRESS_CLASS=gce and LEGO_DEFAULT_INGRESS_CLASS=gce would disable any nginx logic entirely.
Apparently, that's not the case, I still get messages about RBAC not letting get services kube-lego-nginx go through or do not delete service '/' as it has no kubernetes.io/kube-lego-managed annotation" context=provider provider=nginx.
That's not a real problem, but it does clutter the logs (some of those message appear as errors.
Is this the proper way to disable nginx? Is it a bug?
Thanks.

This comes about because right now there's no conditional logic to actually not call the providers New function if the provider is not 'supported' (see: https://github.com/jetstack/kube-lego/blob/master/pkg/kubelego/kubelego.go#L110)
There's a number of PRs right now that touch this bit of logic (eg. https://github.com/jetstack/kube-lego/pull/194 and https://github.com/jetstack/kube-lego/pull/202).
Once one of these is merged, it'd be great if you can test this again!

This should now be fixed as #202 has been merged - can you confirm that the messages no longer appear when using the :canary release? Please re-open if the issue is not resolved!


Liveness and Readiness probe errors for ShinyProxy deployment

Deployed ShinyProxy Operator as is and noticed that ShinyProxy pod going into CrashLoopBackOff status due to liveness and readiness probe errors. I don't see mention of these probes anywhere either in the crd.yaml or shinyproxy.yaml, so not sure where these are configured. Is there a way to configure or disable these probes?
Note that I did not run any YAML files related Skipper-Ingress since we want to use our own Ingress Controller. I don't think it's related to that but making a note of that.
Warning  Unhealthy  36s (x6 over 44s)  kubelet, mynode04  Liveness probe failed: Get http://<IP_ADDRESS>:8080/actuator/health/liveness: dial tcp <IP_ADDRESS>:8080: connect: connection refused
Warning  Unhealthy  36s (x5 over 43s)  kubelet, mynode04  Readiness probe failed: Get http://<IP_ADDRESS>:8080/actuator/health/readiness: dial tcp <IP_ADDRESS>:8080: connect: connection refused
Normal   Killing    36s (x2 over 42s)  kubelet, mynode04  Container shinyproxy failed liveness probe, will be restarted

Tried to replace or change but none of the attempts have worked, so added below YAML under kubernetesPodTemplateSpecPatches section, to temporarily disable the probes, until a root cause is found.
- op: remove
   path: /spec/containers/0/readinessProbe
- op: remove
   path: /spec/containers/0/livenessProbe

In our configurations, the liveness and readiness probes are working correctly, but only if you are using a Kubernetes version which supports StartupProbes, otherwise you will see similar behavior as you pointed out.
For deployments running older Kubernetes version (e.g. 1.17) we use the following configuration with success:
  kubernetesPodTemplateSpecPatches: |
    - op: replace
      path: /spec/containers/0/livenessProbe
      value:
        failureThreshold: 2
        httpGet:
          path: /actuator/health/liveness
          port: 8080
          scheme: HTTP
        periodSeconds: 1
        initialDelaySeconds: 140
        successThreshold: 1
        timeoutSeconds: 1
    - op: replace
      path: /spec/containers/0/readinessProbe
      value:
        failureThreshold: 2
        httpGet:
          path: /actuator/health/readiness
          port: 8080
          scheme: HTTP
        periodSeconds: 1
        initialDelaySeconds: 140
        successThreshold: 1
        timeoutSeconds: 1

Improving the configuration of readiness and liveness probes is on our TODO list.

@LEDfan , thank you very much for the update. We're on older Kubernetes version*1.1.4.x) due to other dependencies. I would leave the probes disabled for now as we will be upgrading to either 1.18 or 1.19 sometime soon. Please add a note about the version dependency if possible.

Hi @cnukwas  in the latest version of the operator, we now have added two options that can tune the readiness and liveness probes so that you can more easily use it on older kube versions.
I also added some notes about version requirements to the README.

Hi @cnukwas  in the latest version of the operator, we now have added two options that can tune the readiness and liveness probes so that you can more easily use it on older kube versions.
I also added some notes about version requirements to the README.

@LEDfan , thank you very much for the update. Will get the latest version as we're starting to get back to this work.

Hi @cnukwas in the latest version of the operator, we now have added two options that can tune the readiness and liveness probes so that you can more easily use it on older kube versions.
I also added some notes about version requirements to the README.

@LEDfan , thank you very much for the update. Will get the latest version as we're starting to get back to this work.

Hi @cnukwas in the latest version of the operator, we now have added two options that can tune the readiness and liveness probes so that you can more easily use it on older kube versions.
I also added some notes about version requirements to the README.


dbg_req_i & irq_req_ctrl_i both are high

Following assertion in zeroriscy_controller (Line 515) is failing in 12 cycles after reset in formal. I've turned on the PULP_FPGA_EMUL to not use clock gating for now to check this. Can send the VCD but not allowed to attach here.
assert property (
@(posedge clk) (~(dbg_req_i & irq_req_ctrl_i)) ) else $warning("Both dbg_req_i and irq_req_ctrl_i are active");

stall_cs is in HALT_REQ mode causing dbg_o to become high (line 375 in zeroriscy_debug_unit module), while at the same time, exec_ctrl_cs is in RQ_PENDING state, causing irq_req_ctrl_o (line 52 in zeroriscy_int_controller module ) to go high in the same clock cycle. Looks like an RTL bug to me!

Thanks for underlining this situation.
I don't think it is a bug but rather an deprecated assertion statement. If both are high, the interrupts have priorities. In single step the debugger would see the first instruction of the ISR as next instruction.
best regards
Davide

	Hi Davide

Thank you for getting back, so I’ll disable this assertion for now and will look at checking priority for this. I do have other assertion failures in the LSU (other than the last one all three fail towards the very end of the lsu module). Could these be obsolete assertions as well? As I said I’m happy to share screen and show the waves.
Thanks Ashish
	Get Outlook for iOS

From: Pasquale Davide Schiavone<EMAIL_ADDRESS>Sent: Friday, March 8, 2019 1:52 pm
To: pulp-platform/zero-riscy
Cc: darbaria; Author
Subject: Re: [pulp-platform/zero-riscy] dbg_req_i & irq_req_ctrl_i both are high (#18)
Thanks for underlining this situation.
I don't think it is a bug but rather an deprecated assertion statement. If both are high, the interrupts have priorities. In single step the debugger would see the first instruction of the ISR as next instruction.
best regards
Davide
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello Ashish,
Thank a lot, yes they may be bugs even though they are more or less or related to inputs signals no?
Thanks for sharing :) very kind of you
Best
Davide

Hi Davide
So yes not sure why the following is an assertion, as it does need to be a constraint as data_rvalid_i is a top-level input.
assert property (
@(posedge clk) (CS == IDLE) |-> (data_rvalid_i == 1'b0) );
However, the following assertion doesn't seem to reflect what the intent (in the comment) is. The comment says that it should not be possible to get a grant without an rvalid for the last request but the assertion doesn't reflect that. In any case this assertion fails, and I believe this should also be an assumption as data_gnt_i is an input. I'll fix this but I've a question:
Is it true that without a pending data_rvalid_i we cannot have a data_gnt_i; and that these are precisely paired; as in once a new data_rvalid_i has been serviced by a corresponding data_gnt_i then you cannot have a new data_gnt_i without a new data_rvalid_i?
A

Hello Ashish,
I see your point indeed. In practice once you send a request, you can receive the grant from that cycle on, no matters how many cycles later. But the valid signal must come at least 1 cycle after the grant. So if you receive the grant, you can send the next request but the next grant must come together or after the valid related to the previous transaction.
I think this was the intent of the assertion.
Does it make sense for you?
Davide

These signals/interfaces and the controller have been reworked. The assertion has been removed. Ibex is now using an external debug module following the RISC-V Debug Spec version 0.13. I am thus closing this issue.


take some lessons for stockholm ws

was thinking first to take jupyter, then thought that it would leave to little for Anne, but now taking it again because the load balancing does seem good


ESP Broken

Hi, this mod is a life-saver. I recently made a ton of changes to my save and for some reason the CheatUtils are a bit broken; the in-game controls from setting custom scripts just are generic ('reserved 00'; 'reserved 01' instead of what I named them) and my list of blocks I had added to the ESP vision setting is blank and I cannot add new ones (typing in 'minecraft:chest', 'chest', or anything really just shows a blank list). I tried deleting the zergatulcheatutils.json, deleting the mod, then reinstalled it but it didn't fix the issue.
Thanks!

Maybe you installed some new mod and it caused problems?

There is no limits on how much entities or blocks can be displayed.
What do you see when you try to open these URLs:

http://localhost:5005/api/block-info
http://localhost:5005/api/entity-info

When I go to http://localhost:5005/api/entity-info:

When i go to http://localhost:5005/api/block-info:

Can you pinpoint exact mod that causes block-info to return error?


Silly question

What did you folks use to make the diagram at the top of your readme? It looks fantastic!
https://github.com/refinedev/refine#readme

Hey @Zenahr ,
Thank you!


Produce block: ignore old attestations

Motivation
Failed to produce attestations, this happens if the produceBlock function try to include an old attestation (which rarely happens), for the scenario in #4743:

Lodestar call produceBlock for slot 5099734
We try to include an attestation of an old slot (suppose it < 5099712)
It tried to get dependent root at 5099647
But finalized slot is at 5099648

Description

For v1.1.x, findAttesterDependentRoot() returns null in this case
For v1.2.0, due to #4555, the new function getDependentRoot() throws error instead
The fix is to catch the error and simply ignore that attestation data
Also add a new metric to track number of aggregated attestations in lodestar blocks

Closes #4555

there are some failed tests that not related to this PR


Improper Rendering of State on InteriorLeftNav: Only previously selected item appears as selected

Improper Rendering of State: Only previously selected item appears as selected
Detailed description

Describe in detail the issue you're having.

The left interior nav is only rendering the previously selected item as selected.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

InteriorLeftNav

What did you expect to happen? What happened instead? What would you like to see changed?

Expected: The most recently clicked list item to appear as selected. The state of the top level component (InteriorLeftNav) changes, but the clicked list item does not attain the classname active until the another list item is selected.
What Happened Instead: The component renders the second most recently clicked item as selected

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

carbon-components: 8.16.8
carbon-components-react: 5.31.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Nothing particularly pressing
Steps to reproduce the issue
Step 1: Define a component file like so:
// src/components/SideNav.tsx
import { InteriorLeftNav, InteriorLeftNavItem, InteriorLeftNavList } from 'carbon-components-react';
import 'carbon-components/scss/components/interior-left-nav/interior-left-nav.scss';
import * as React from 'react';

class SideNav extends React.Component<{}, {}> {
  constructor(props: {}) {
    super(props);
  }
  render() {
    return (

        <InteriorLeftNav>
          <InteriorLeftNavItem>
             Item 1
          </InteriorLeftNavItem>
          <InteriorLeftNavItem>
             Item 2
          </InteriorLeftNavItem>
          <InteriorLeftNavItem>
             Item 3
          </InteriorLeftNavItem>
          <InteriorLeftNavList title="Item 4">
            <InteriorLeftNavItem>
               Sub Item 1
            </InteriorLeftNavItem>
          </InteriorLeftNavList>
        </InteriorLeftNav>

    );
  }
}

export default SideNav;

Step 2: include the component in the root div
Step 3: Click items and notice that they are broken
Additional information

Screenshots or code
Notes

cc @asudoh since I think you were tackling some ILN items?

Seems that this is caused by a race condition of location.hash being set vs. React rendering. @marijohannessen Do you have a test case for https://github.com/carbon-design-system/carbon-components-react/pull/447 concerning https://github.com/carbon-design-system/carbon-components-react/issues/279? I have a fix in hand, but it's a minor breaking change and wanted to make sure our major use cases are not broken at least. Thanks!

Refs: https://github.com/carbon-design-system/carbon-components-react/issues/698

Hi @joshblack we can proceed with the change as long as @marijohannessen is comfortable with it - Just wanted to make sure her earlier code concerning location.hash won’t be broken. Thanks!

Issue moved to carbon-design-system/carbon-addons-cloud-react #16 via ZenHub


Error when starting docker container inside another docker container

My setup: Windows Ubuntu subsystem -> Docker container Ubuntu 18.04 -> Skeema --workspace=DOCKER --flavor=percona:5.7
When running skeema diff i get the following error:
2019-07-26 12:48:02 [INFO]  Using container skeema-percona-5.7 (image=percona:5.7) for workspace operations
2019-07-26 12:48:02 [WARN]  Skipping /home: Get http://unix.sock/containers/skeema-percona-5.7/json: dial unix /var/run/docker.sock: connect: no such file or directory

2019-07-26 12:48:02 [ERROR] Skipped 1 operation due to error

For my build server i need to be able to run Skeema inside a Docker container, that's why this setup looks so weird.

Okay so i may have found a "fix".
Reading https://stackoverflow.com/questions/27879713/is-it-ok-to-run-docker-from-inside-docker
I changed my docker command to the following:
docker run -it -v /var/run/docker.sock:/var/run/docker.sock ubuntu:18.04 /bin/bash

It still failed, but with a different error:
2019-07-26 13:54:09 [INFO]  Using container skeema-percona-5.7 (image=percona:5.7) for workspace operations
2019-07-26 13:54:39 [WARN]  Skipping /home: dial tcp <IP_ADDRESS>:32768: getsockopt: connection refused

2019-07-26 13:54:39 [ERROR] Skipped 1 operation due to error

After reading https://stackoverflow.com/questions/24319662/from-inside-of-a-docker-container-how-do-i-connect-to-the-localhost-of-the-mach
I again changed my docker command:
docker run -it -v /var/run/docker.sock:/var/run/docker.sock --network="host" ubuntu:18.04 /bin/bash

Which made it work.
Now i don't know if this is a proper fix or if i might get into some trouble in the future, but for now it looks like it works.

Yes, exactly, this is a limitation of Docker itself. If you need to run Skeema inside of a Docker container, you basically have 3 options, all of which have different trade-offs:
a) Stay with the default of workspace=temp-schema, so that Skeema does not need to interact with additional Docker containers.
b) Bind-mount the Docker socket into Skeema's container (the solution you've described above). Functionally, this should generally work fine. Operationally, it may be problematic in container orchestration systems like Kubernetes. It can also be a theoretical security concern, however in that respect it should be no different than running Skeema outside of a container.
c) Run a separate Docker daemon inside Skeema's container. In theory this should be possible if running Skeema in a privileged image that inherits from a Docker-in-Docker (dind) image, such as the official one at https://hub.docker.com/_/docker/.
I'll update the docs for Skeema's workspace option to mention this situation. Sorry this wasn't documented previously!

In case anyone is still watching this issue: if you use workspace=docker combined with running Skeema itself from a container, the proposal in #186 may affect you. Feedback on that issue would be greatly appreciated -- thanks!


wont save settings on reboot

im using a : WeMos D1 mini
i have tried flashing it with the  /bin/flash.bat, and esphome flasher, easy esp.
all tries result in the same result, if i change any settings, and click on the yellow bar in the bottom, it reboots, and resets all settings to default.

hey @ZeppDK not sure if you are still interested in this, but are you trying to compile the dev branch or the stable? I would recommend you trying the dev and possibly with the debug target as it will print more info on the serial port and I can try helping you troublshooting!

Same issue, i have version 1.3.7, is that stable of dev? Do you have a dev download link?
This is where i download it, https://github.com/esprfid/esp-rfid/releases

Thanks! Good news. Looks like a nice project.

@marktn try getting the binaries from here: https://github.com/esprfid/esp-rfid/suites/5709560102/artifacts/188342329
We'll soon release a new version with all the fixes! I hope in a month or so :)
@matjack1 It works!

Yes! Thank you for the feedback!!


Xcode 9 Error - Associated type 'Element' references itself

While I try to build the app in Xcode 9, it build fail with this error.

Can we resolve this issue? It's pretty annoying now...

You can resolve this issue by deleting the offending line. this is because In Swift 4, the protocol Sequence already defines Element.
`public protocol Sequence {
/// A type representing the sequence's elements.
associatedtype Element where Self.Element == Self.Iterator.Element`

I created a PR.  You can do pod 'AlecrimCoreData', :git => "https://github.com/btelintelo/AlecrimCoreData.git", :branch => 'master' until it gets merged/fixed

@btelintelo thank you so much for taking a look at this!
Using your branch I get the following error now:
Initializer for conditional binding must have Optional type, not 'NSManagedObjectModel'

Do you have any idea on how to fix this?
I get this in the same file in line 107 where it is saying:
if let model = NSManagedObjectModel(contentsOf: modelURL) {

what version of Alecrim were you using before?  I branched of alecrim master.

@btelintelo thanks for your fast reply, I was using the latest version from the master branch before.

Hi @vmartinelli Do you have any update on if this can get fixed for swift 4?


spawn pidof ENOENT error #43128a

Regarding error 43128 -
Per suggestions,

Git Path was checked and it is a valid path
I ran VS code with all extensions disabled .Problem did not resurfaced under this condition.
When I re-enable the extensions the error code reappears.

Issue always occurs whenever I change the color theme.

Since there is an existing issue for this, I'm going to close this and reopen the old one.


[Snyk] Upgrade org.codehaus.mojo:sonar-maven-plugin from <IP_ADDRESS>94 to <IP_ADDRESS>22

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.codehaus.mojo:sonar-maven-plugin from <IP_ADDRESS>94 to <IP_ADDRESS>22.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2024-03-13.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Will be done in a global PR (synk_fix_dependencies_outdated_issues


Dapr extension pub/sub error: no pubsub is configured

When running Type with the Dapr extension using pub/sub, I got an exception with daprClient.PublishEventAsync("pubsub", "weather", weather):
Message=Publish operation failed: the Dapr endpoint indicated a failure.
Source=Dapr.Client
Inner Exception: RpcException: Status(StatusCode="FailedPrecondition", Detail="no pubsub is configured")

I do not get the exception when running dapr directly: dapr run --app-id publisher -- dotnet run
I can verify in the Components tab of the Dapr Dashboard that pubsub is configured properly.
Originally posted by @tonysneed in https://github.com/dotnet/tye/issues/984#issuecomment-800631405

Hm, I'm not seeing this repro locally.
What version of tye and dapr are you using?

Versions
Tye version: 0.6.0-alpha.21070.5+a42e4463943e3136dbd1de38474d8d62b802797c
Dapr version: CLI version: 1.0.1 Runtime version: 1.0.1
OS: macOS Big Sur 11.2.3
Steps to Reproduce

Clone the demo repo: https://github.com/tonysneed/Demo.DaprPubSub
From the solution root run: tye run --debug *.
Open the solution in Visual Studio (Rider on the Mac).
Set a breakpoint on line 30 of Worker.cs in the Publisher project: await _daprClient.PublishEventAsync(Constants.PubSubName, "weather", weather);
In Exception Settings, break on all CLR exceptions.
Attach the debugger to Subscriber.
Attach the debugger to Publisher.
When the breakpoint is hit, press F5 to continue.

The following exception takes place:
Dapr.DaprException: Publish operation failed: the Dapr endpoint indicated a failure. See InnerException for details.
 ---> Grpc.Core.RpcException: Status(StatusCode="FailedPrecondition", Detail="no pubsub is configured")
   at Dapr.Client.DaprClientGrpc.MakePublishRequest(String pubsubName, String topicName, ByteString content, Dictionary`2 metadata, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at Dapr.Client.DaprClientGrpc.MakePublishRequest(String pubsubName, String topicName, ByteString content, Dictionary`2 metadata, CancellationToken cancellationToken)
   at Publisher.Worker.ExecuteAsync(CancellationToken stoppingToken) in /Users/anthonysneed/Source/Demo.DaprPubSub/Publisher/Worker.cs:line 30

I have been able to reproduce this behavior on both macOS and Windows 10.

@jkotalik Are you able to reproduce the error using the steps I provided? This is preventing me from using Tye to debug Dapr pub/sub using Visual Studio. Thanks.

I solved it by mounting the components folder from the host to the dapr container

@hafiz-personal Do you have a sample or snippet I could use?

I figured it out. Simply add components-path to the dapr extension section of tye.yaml.
extensions:
- name: dapr
  log-level: debug
  components-path: "./dapr/components"

This will resolve the no pubsub is configured error.
@jkotalik This looks like a bug in tye. It should use the default Dapr components path. @rynowak Would you agree?

Closing.  Please reopen if the current behavior is insufficient.

I solved it by mounting the components folder from the host to the dapr container

what do you mean host ?


migrate kmlocales to scbd

we do not have typescript enabled for this project. please use .js for now.


[Mobile] Copy/Paste/SelectAll tooltip doesn't work in readOnly mode

My issue is about [Mobile]
Copy/Paste tooltip doesn't appear after Select All pressing in readOnly = true mode on real device. However it works as expected on iOS simulators. It happens basically because of _keyboardVisible variable.

test environment:
Flutter 3.0.2
iOS 15.2
iPhone 11

How do you dispatch select all on mobile?

long tap

How do you dispatch select all on mobile?

long tap

Strage, the emulator iPhone SE does not show this behavior. Also afaik, the long tap gesture is not triggering the floating cursor behavior.

Strage, the emulator iPhone SE does not show this behavior. Also afaik, the long tap gesture is now triggering the floating cursor behavior. Maybe you are using an older version, before floating cursor was implemented.

first time it appears after double click to a QuillEditor's empty area, then it appears also by long press on an empty area or even on the text
I use flutter_quill v5.0.3
https://user-images.githubusercontent.com/64897662/175276450-e01deb0d-f9c5-4f18-a1f3-a5966143a037.mov

Oh, now it makes sense. I see what you mean.

Oh, now it makes sense. I see what you mean. After toying a bit more with the emulator I noticed that actually the copy option is there. However it goes offscreen. I guess it needs a condition to reposition differently if the entire doc is selected. Or some extra padding at the bottom could do it.

but on real device Copy doesn't appear at all


Deno Third Party Module

I've been experimenting with deno for typescript and importing djot would be simpler if it was submitted as a third party module. The process seems simple enough, with no real cost as far as I can tell.
Would there be interest in doing this?

Actually I think I was too hasty here.
I assumed you could just add a typescript repo directly as described here:

Public Source Code + ESM + No Node APIs

If an existing project is already written with ES Modules (and preferably TypeScript) and has no dependencies on Node APIs, either in it's code or it's sub-dependencies, then you're in luck! You should be able to import these modules directly by using any URL that returns the raw code.
For example, if the code is hosted on GitHub you can use:

The a raw GitHub content URL (click the Raw button on a file in GitHub)
A GitHub CDN such as GitHack
The Deno Land Third Party module registry using the experimental GitHub syntax (e.g. https://deno.land/x/gh:asos-craigmorten:superdeno/mod.ts)

But after a quick look around the djot repo it seems node won't be so easily separated, and so a more involved port would be required. I'll leave this issue up for discussion for now, but we can close it if this isn't a priority any time soon. I might also make a port fork for self-learning deno anyway.

Closing for now as I don't have too much time to work on this at the moment!


Label property/matching: Derive from child-views

UPDATE: This is in fact the reincarnation of #3119
Describe your idea
As reported via an internal support case by @bunkib, we could do better in terms of Android equivalence (to iOS) by aligning accessibility-label based matching logic:
On iOS, the label property of a view is defined not only by the accessibility label associated with view itself, but rather by recursively concatenating the label values of all children. This is not because this is how we decided to introduce that behavior on iOS, but because this is how React Native sees it. On Android, label is associated with a view's contentDescription (accessibility label equivalent) in flat way, inspecting only the view itself.
Why does it matter?
Because in some implementation of various text-component wrappers in React, the test ID is associated with the wrapper rather than the text component itself.
Change details
This is relevant on 2 levels:

.toHaveLabel() matching logic: Look up the label based on the view's children, recursively.
label attribute: Assign based on the children's texts, similarly.

Mind that for the time being, the by.label() API remains out of the game here, because bringing it into the game would only benefit cases where the concatenation outcome is matched-against explicitly, which we consider extremely rare.

We need to address both API's (based on the same shared text-concatenation helper), so as to make the two platforms even more seamless.

TODO Reiterate this thread


Line 12 in ServerWeaponSetup preventing script from functioning

Line 12 is erroring out the script every time I try to playtest the game.
(Line 12, ServerWeaponSetup, located in ServerScriptService)
local ProjectileReplication = require(ReplicatedStorage:WaitForChild("ProjectileReplication")) :: any

What error are you getting?

This is what I'm getting in Output.

Did you make sure to clone the submodules as well (git submodule update --init --recursive)?


Language tests required for generic methods

We need more language tests to cover generic method static and dynamic behavior.

From https://github.com/dart-lang/sdk/issues/29360 , we should test this kind of behavior:
typedef Foo = T Function<T>(T x);
typedef Bar<S> = S Function<T>(T x);

void test() {
  Object b;
  (b as Foo)<int>(3);
  if (b is Foo) {
    b<int>(3);
  }
  (b as Bar)<int>(3);
  if (b is Bar) {
    b<int>(3);
  }
  (b as Bar<String>)<int>(3);
  if (b is Bar<String>) {
    b<int>(3);
  }
}


Future?

Do you plan to add any bigger warehouse? Cuz I keep running into the issue of building huge setup of warehouses to store all my crap.

I think our absolute hard limit on any potential size increase would be roughly entity area × steel chest capacity stacks per Warehousing entity.
@Anoyomouse, any thoughts? I don't think bigger is necessarily better, but there are some variants that actually store less in a given space than the equivalent are filled with vanilla 1x1 steel chests…

Hmmm Good to know I guess, Idk I would love to see a warehouse the size of the larger Factorissimo building. That would be amazing! I know that probably a little too extreme. But nevertheless, figured I would ask. See if you guys were even consider anything larger.

At present, nothing is planned to change as a result of this brief discussion, so I'll close the issue to get it out of the "Open" list. Nothing says it can't be reopened later. :smile_cat:


it looks like full node modules are bundled, rather than just the distribution files

Looking at the 43Mb Windows download, it appears that a full node_modules directory is zipped in, rather than just the files necessary for running the code. This makes the download much, much bigger than it needs to be. Especially if people already have Node installed on their machine, it feels like these dependencies could be left out and downloaded as needed, instead.

We should not assume end users will ever have node installed. The main use case I have for this kind of front-end interface is to get non-developers started with a ready-to-use single purpose GUI.
If there are things being bundled that are not used at all, of course it could be trimmed down to just what is required to run, but the bundle should be self contained and ready to roll without further downloading.

As @alerque said, the app should work in non-developer's environment. Just download and extract it.
If I could, of course I want to shrink its bundled size. However I'm not good at this topic. Would you tell me whether there is any way?

yeah removing them entirely is probably a bad idea, but most node_modules don't need all the files they come with for the code to work (you don't need the tests and docs and all that if you're using them as actual code dependencies).
I would recommend using something like webpack, which despite having "web" in the name also comes with the ability to bundle "for node", so you can point it at your application code, and it'll generate a full bundle that can as node app.js with all the dependencies bundled in and minified.
You basically run webpack and tell it to generate [a library, rather than client bundle], and the result is going to be a lot smaller than adding in the node_modules dir.

Thanks, I'll check.

I tried webpack at 174988a4efae59ab223bf8485bfb329d167e129f.
Most of app's size is occupied by Electron itself. So the size won't be reduced by webpack.
However, the number of files decreases much. This is effective when extracting the archive.

interesting finding, how little of a difference does it make in terms of size?

On Windows 64bit:

version
zip
extracted
files
folders
resources/app

v1.0.3
52.6MB
133MB
3476
270
12.2MB

174988a
48.8MB
125MB
105
13
4.06MB

interesting. Yeah that's not too much space saved (although 4mb on 52/48 is still considerable), but that's an amazing reduction in files.

v1.0.4 is released. It uses webpack.

you are a hero

btw, perhaps interesting to know, using 7z rather than plain zip for compression gives me a 31MB archive for 1.0.4 (set to best compression, since it's a release pack), rather than 51MB, so that's a drastic savings, too. Might be worth using 7z for future releases.

I know 7z can compress better than zip, however, it's not supported by os. So I will use only plain zip. Thanks.


Add new devices to existing glusterfs cluster

Hi there!
I have successfully created GlusterFS as a hyper-converged service on my Kubernetes nodes. In my kubernetes cluster, i have 1 master and 4 worker nodes. GlusterFS are on 3 of the 4 nodes. This is all working fine and well.
Now, i wish to create more storage space using glusterfs on the same cluster. What is the best way to go about doing this? Should I add more Kubernetes nodes (say 3 more new nodes) with glusterfs running before running the gk-deploy option?
Please advise.
Thanks!

Hi! Sorry for the delay, we've been rather busy as of late.
There are several ways to expand your storage, depending on your configuration. One way would be to add more storage devices to your existing nodes. You could also add more nodes as well. We recommend having the same amount and type of storage per node. This is not a strict requirement, but it makes the allocation behavior more predictable. In both cases you can add new items to the topology using the respective heketi-cli command (e.g. heketi-cli node add or heketi-cli device add) or re-running heketi-cli topology load using a modified version of your original topology file that includes the new information.

@jonathan-goh , @jarrpa - i am facing similar issue wherein when i try device add getting "500 internal error "
[root@heketi-7495cdc5fd-xswtg var]# heketi-cli device add --name=/dev/sdg --node=7e7f87a0f60e4ccaaf0c9afa52db1f20
Error: server did not provide a message (status 500: Internal Server Error)
any idea what is happening? Thanks for your support and help.
heketi version - 8
glusterfs - 4.1.7
k8s - 1.13


Convert attribute and relationship names to symbols

Fixes issues when strings are provided #1019 & #1032

Thanks - LGTM now.


GROOVY-10561: @NamedVariant self referential default values are not c…

…orrectly resolved

The PR works for the simple case of the initial value being a reference to a previously defined parameter, as in the provided example, but should really be a visitor so that it could handle expressions involving such parameters. I'll do that next.

Is this the same way Verifier handles it for normal methods?


Update externals

TODO:

[ ] Mysql workbench is failing.
[ ] Home Manager patch over unstable breaks 19.03.

Merge strategy: Rebase merge

Is this still useful ?

No, I will have to remake it.


Copying of molecule objects loaded from custom xyz files fails

When loading a molecule using TCutility.molecule.load we capture information about the molecule and the atoms in their respective flags attribute. Because flags is a TCutility.results.result.Result object there will be issues whenever you call the copy method of the molecule. This method is very often used (for example in workflows) and we therefore should fix this. One way of fixing it is to overload the __reduce__ method of the TCutility.results.result.Result class. This method should return a single string specifying the name and namespace of the class. This then tells copy.deepcopy (which plams uses) what the class is supposed to be.

I have added a test-case. You can see that it will pass if we define the __reduce__ method, but will fail if we do not define it. There seems to be some weird stuff going on under the hood of copy.deepcopy, but I don't know enough about the deeper parts of Python to fully understand it. Documentation is also a bit complicated a scarce about this topic.


ci: run miri on main

Summary

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

PR description please ⚠


Turning

I tried turning and I just doesnt work no matter what i try to do

@Jjoiner729 Can you tell me how you even got it to work? I get nothing what so ever. Just I new device under Other Devices called Xbox Virtual Game Controller. Any help would be nice

sorry i had to type fast but when i try steering it just doesnt work like if i move it even an inch either way it just thinks the wheel did a full rotations also the break peddal just doesnt work

sorry i had to type fast but when i try steering it just doesnt work like if i move it even an inch either way it just thinks the wheel did a full rotations also the break peddal just doesnt work

Do you happen to have the Xbox 360 gamepad drivers installed? (the ones featured in the linus tech tips forum, if you came from there)

yes I do

whenever i run the xboxwheelcompatability.exe it just says i have raw imput controllers and no active wheeles is that my issue?

yes I do

Try uninstalling those and trying to start the software again.

im not gonna lie to you ive done that like 5 times dead ass

im not gonna lie to you ive done that like 5 times dead ass

Alright, try unplugging your wheel, checking the amount of raw game controllers, and then plugging your wheel back in and checking the amount of raw game controllers, and then report the results back to me

Number stays 2 but my pc recognizes that something is plugging and unplugging

Number stays 2 but my pc recognizes that something is plugging and unplugging

Have you uninstalled the Xbox 360 drivers yet?

just did nothing changed

just did nothing changed

Have you tried plugging your wheel into a different port on your computer?

indeed i have

indeed i have

What version of Windows are you using currently? (you can find this by typing winver in your search bar and hitting enter)

windows 11 version 21H2

Alright, I'm going to see if I can set up a virtual machine to try and emulate the problem and debug it. Both occurrences of this problem that I've seen have occurred on Windows 11 21H2, so it might be as simple as upgrading your Windows version but I'm not entirely sure yet.

how would I upgrade because I just checked for updates and i am up to date

how would I upgrade because I just checked for updates and i am up to date

The next version might be an insider version at the moment, so I wouldn't attempt upgrading (because you'd have to enroll in the insider program) until I've confirmed that it is an issue just with 21H2.

im already enrolled in the dev channel and i now see an update

im already enrolled in the dev channel and i now see an update

Oh, alright. Feel free to try the upgrade and attempt to run the software again.

alrighty will do i reply back with the results

alrighty will do i reply back with the results

Got it!

im now on 22H2 but it still says 2 raw imput controllers

im now on 22H2 but it still says 2 raw imput controllers

Hm, is it possible for me to try to remote into your system and debug the problem from there. It's hard telling what the issue is so far.

Never mind I got it who work last night I was just so excited I never put it in here but thanks a lot for your help man!

Never mind I got it who work last night I was just so excited I never put it in here but thanks a lot for your help man!

No problem! Would you mind telling me how you got it working, just in case somebody else encounters the same problem? Was it just upgrading?

So I was having the same issue. After updating windows all i had to do was uninstall the device in device manager and plug it back in. Now it works great!


AFNetworking

I installed the cocoapod version which uses AFNetworking 1.3.2.
I use ver 2.1.0 through out my whole project.
Any solution?

I won't be able to use this because of the AFNetworking version conflict.

Is there any word on this legacy dependency issue? I also won't be able to use this library due to the version conflict, as I'm using AFNetworking ~2.0.

Hey @JakeSc we definitely are planning to update to the latest version of AF networking but i cannot specify exactly when it would happen, we need to rewrite a lot of the core code we have to make it work.


RTL Update to v0.4.2

https://github.com/ShahanaFarooqui/RTL/releases/tag/v0.4.1

Updated for v1.3 release ... final testing.

One can hardly keep up: https://github.com/ShahanaFarooqui/RTL/releases/tag/v0.4.2
https://twitter.com/openoms/status/1141276758097977345

OK - updated and testet. RTL 0.4.2 is part of v1.3 release.


Builder reports PR was automatically merged when it wasn't

When my PR builds and passes unit tests, the plugin always reports this:

xxx - AUTOMATED - # 21 GitHub pull request #285 of commit xxx automatically merged.
even though 1) it does not actually merge and 2) I don't want it to merge automatically.

The verbage is going to change in the next release to clarify this.  v1.18


Question: Is there ANY way to clone the whole remote folder to local?

Expected Behavior
Clone (recursively) the full remote folder, to have a 1:1 copy.
Actual Behavior
Only downloads selected folders, but when not selecting any, it should recursively download everything inside the currently seen folder (root of the project), just like when selecting one folder and running SFTP: Download.
Steps to Reproduce the Problem

Do NOT select any folder and stay in the root of the project.
2a. Cmd+Shift+P --> SFTP: Download.
2b. Cmd+Shift+P --> SFTP: Sync remote to local.

Requisites (important to diagnose the problem!)
This is probably a feature request rather than a bug (or am I missing something?).
Extension Logs
N/A.
Specifications

Version: Latest (0.8.11)
VSCode Version: 1.18.1
Platform: macOS

Just Cmd+Shift+P --> SFTP: Download. This works with the latest version (0.8.11).

@liximomo I did that, but it didn't work. It created folders but no files were downloaded. It was the latest version downloaded directly from VSCode.
I ended up creating a ZIP file in the server and downloaded that (these were A LOT of files, 10 thousand or so).

There maybe a bug. Can you provide me the logs?  Preference -> setting -> sftp.printDebugLog to true, then reload vscode, reproduce the problem, get the logs(view -> output-> sftp)

Hello again, this is the log output:
[info]: config at /Users/dpsmac1/Sites {
    "host": "local.penquistas.cl",
    "port": 22,
    "username": "alejandroivan",
    "password": null,
    "protocol": "sftp",
    "agent": null,
    "privateKeyPath": null,
    "passphrase": null,
    "passive": false,
    "interactiveAuth": true,
    "remotePath": "/Users/alejandroivan/Sites/",
    "uploadOnSave": false,
    "syncMode": "update",
    "watcher": {
        "files": false,
        "autoUpload": false,
        "autoDelete": false
    },
    "ignore": [
        "/Users/dpsmac1/Sites/**/.vscode/**",
        "/Users/dpsmac1/Sites/**/.git/**",
        "/Users/dpsmac1/Sites/**/.DS_Store",
        "/Users/alejandroivan/Sites/**/.vscode/**",
        "/Users/alejandroivan/Sites/**/.git/**",
        "/Users/alejandroivan/Sites/**/.DS_Store"
    ],
    "configRoot": "/Users/dpsmac1/Sites"
}
[debug]: task: download /Users/dpsmac1/Sites
[debug]: conncet to remote

[debug]:
------
target: /Users/alejandroivan/Sites/
context: transmission dir
error: Error: Failure
------

It is stuck downloading /Users/alejandroivan/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C, which has one empty file. This is the output in the server's Terminal:
alejandroivan@Mac-mini-de-Alejandro:~/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C$ ls -al
total 0
drwxrwxr-x  3 alejandroivan  _www   96 Nov  5 13:10 .
drwxrwxr-x  4 alejandroivan  _www  128 Nov  5 13:10 ..
-rwxrwxr-x  1 alejandroivan  _www    0 Nov  5 13:10 abc.dat.copy
alejandroivan@Mac-mini-de-Alejandro:~/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C$ cat abc.dat.copy
alejandroivan@Mac-mini-de-Alejandro:~/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C$ du -h abc.dat.copy
  0B	abc.dat.copy
alejandroivan@Mac-mini-de-Alejandro:~/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C$ pwd
/Users/alejandroivan/Sites/blog/vendor/symfony/finder/Tests/Fixtures/copy/A/B/C

Maybe a bug with empty files?

I noticed that, with different SFTP: Download operations, it gets stuck "retrieving" different folders, not only that A/B/C structure. Anyway, a du -h . on the local side, shows these directories and sizes:
dpsmac1@dpsmac1:~/Sites$ du -h .
8.0K	./.vscode
  0B	./application/cache
  0B	./application/config
  0B	./application/controllers
  0B	./application/core
## a lot more folders ##
  0B	./system/libraries/Javascript
  0B	./system/libraries/Session/drivers
  0B	./system/libraries/Session
  0B	./system/libraries
  0B	./system
 20K	.
dpsmac1@dpsmac1:~/Sites$ pwd
/Users/dpsmac1/Sites

On the remote side, the result is:
alejandroivan@Mac-mini-de-Alejandro:~/Sites$ du -h .
8.0K	./application/cache
 96K	./application/config
 44K	./application/controllers
4.0K	./application/core
## a lot more folders ##
 32K	./system/libraries/Javascript
 52K	./system/libraries/Session/drivers
 92K	./system/libraries/Session
696K	./system/libraries
2.2M	./system
154M	.
alejandroivan@Mac-mini-de-Alejandro:~/Sites$ pwd
/Users/alejandroivan/Sites

What is your server OS? The sftp will download files in parallel. Please check the maximum number of open files of your server is greater than 512.

@liximomo it's macOS High Sierra (10.13.2). I did run the commands from the known issues (both in the server and client). I know it's weird.
That [debug]: task: download /Users/dpsmac1/Sites disturbs me, since dpsmac1 is the local environment. Is there any way to force a localPath in the config, instead of using the project root?

Is there any way to force a localPath in the config?

The upcoming version will allow you to set config-root manually.
I will make a debug-package for you to debug the download problem.

Try debug-pacakge and give me some feedbacks.

@alejandroivan You can config the localPath with sftp 0.9.0!

@liximomo thanks! Sorry for not being able to answer earlier, I've been with lots of work these two past weeks.
I unfortunately deleted some files on the remote path and then synced without issues. It must have been the number of files and several folder levels. At least it is working without that configRoot at the end of the config JSON file (which is not giving me some error messages when it is present, probably it shouldn't have been there).
Thanks for your help!

Also having issues with the same goal, but the result slightly different on my endpoint.
I'm trying to download the entire '/var/www/projectname' folder via
cmd+shift+p -> SFTP: Download.
The probem for me is, it's not downloading the entire folder. It's just downloading the subdirectories inside the root directory.
Files within the root directory, e.g. '/var/www/projectname/' aren't being downloaded.
Files within a subdirectory, e.g. '/var/www/projectname/config/' are being downloaded.

What is your root dir of workspace? What did you set to  'context' and 'remotePath'.

I am having this problem as well, W10 VS Code 1.20.1 Extension version 1.0.4
When I try to download at the root I get just folder structure. I then tried to download each folder with no luck. After enabling debug log I am able to download the sub folders however, I cant get the files in the root. I eventually found out the host we were using was denying permissions of some of the folders. as soon as SFTP ran into the permission denied error it would stop.

I have the same issue as @Chrissteven81. Spamming SFTP: Download command is kinda works, byt my project is huge (about 13k files). Again, notepad++ with barely same config works, and ftp-simple works too, so I assume it is SFTP problem. My config is:
{
    "protocol": "ftp",
    "passive": false,
    "port": 21,
    "host": "ftp",
    "username": "username",
    "password": "password",
    "remotePath": "/home/username/my_awesome_huge_project_root",
    "uploadOnSave": true,
    "ignore": [
        ".vnc",
        ".vscode",
        ".git",
        "*.o",
        "a TON of ignore items here",
        ".DS_Store"
    ]
}

I have a lot of ignore items in the list. About 100 already, I really don't need them, because it's a compile files, build scripts, etc. It downshiftes amount of files to minimum (about 5k). But can't still download them from remote.


Refactor: IUDX to DX URL

Please refer to the code of conduct : link
Please check if the PR fulfills these requirements :clipboard:

[x] The commit message follows our guidelines : link
[x] A new branch is created for the change(s) and the changes are not committed on the main or master branch
[x] No credentials or secrets are committed

What kind of change does this PR introduce? (Bug fix, feature, docs update, refactor, chore, test, config) :information_desk_person: :scroll:
refactor, docs update
Changed all the iudx-acl-apd in the GitHub repository URL pointing to ACL-APD repository to dx-acl-apd

Checklist for the current PR :page_with_curl:

[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have added reviewers to check the proposed changes

Build finished.

Build finished.


Add support for not equal (1=)

According to https://firebase.googleblog.com/2020/09/cloud-firestore-not-equal-queries.html - Firestore now supports the not equal operator, so we update Query.php to reflect that change.
This is my first PR on a public project, so let me know if there's anything wrong.

@googlebot I signed it!

Hi @frederichoule, I'm sorry you closed this. Thanks for the contribution. The proposal looked good. If you care to reopen it, I'll need to ask you to add a unit test, but otherwise I'd be glad to accept it. We can discuss specifics if you choose to reopen.


Fail to ingest a data source with WKT point type column

Describe the bug
I tried to ingest a data source that contained a WKT Point type column, but an error occurred.
To Reproduce

Attempt to load the file with the sample data below.
geo_test.zip
The GeoPoint column is specified as a Point type in the data source creation process.

Expected behavior
A data source containing geo-type must be loaded.
Additional context
Druid Log : log.txt

ingesion spec?

Not a bug


Update documentation to indicate no IAM user role needed to run the app

Context:
As per a discussion group question, we noticed it was unclear that iAm permissions were not required to start up the app.
Discussion group thread
"So actually to run the app, you do not need to create a new IAM User so we should actually update that documentation."
A/C's:

[ ] Update wording that may be misleading around when it is necessary to create a new IAM User  here)
"You will need an IAM user that can create access-keys and modify your billing settings." should not be there.

Hi @ericksod
I'd like to work on this issue

Hi @ericksod @4upz
I want to work on this issue


Install granite-kitchen instead of utils

#7

Pip install granite-kitchen instead of utils.

This looks like its failling because the new library is too fat. If that is the case, then merging this will cause all tests to always fail.

looks like this has been failing (for being too fat) since last week...

This looks like its failling because the new library is too fat.
If that's the case, I would expect other projects to fail where we import granite-kitchen as well. Eg., why isn't granite-code-cookbook failing?

@rawkintrevo could we be writing too much to the log?
System.IO.IOException: No space left on device : '/home/runner/runners/2.320.0/_diag/Worker_20241009-174642-utc.log'

possible hacks:
https://github.com/marketplace/actions/maximize-build-disk-space-only-remove-unwanted-software
I found when I was looking up how much disk space the runner has

less hacky but cc required (cc @adampingel ) https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners

Pared down example, only got rid of dotnet
https://stackoverflow.com/questions/75536771/github-runner-out-of-disk-space-after-building-docker-image

Perhaps the kicthen is too full for individual needs? That is, instead of one very large kitchen which can make all recipes, we may need several fit-for-purpose kitchens...

Yes, it was inevitable that it would have to be broken up, and we have arrived at that point.

From @rawkintrevo's link:

public shared Github runners come with around 25-29 GB of free disk

My whole virtual env is 1.5G when I run this. What else is taking up space?

We probably don't have to pull down the 20b Ollama model in Getting Started with Ollama:
Pull down Granite models:
!ollama pull granite-code:3b
!ollama pull granite-code:8b
!ollama pull granite-code:20b

Yeah, I'm guessing the ollama models are the problem here:


The input line is too long. The syntax of the command is incorrect error using kafka-security-manager.bat

I get this error "The input line is too long. The syntax of the command is incorrect" using kafka-security-manager.bat unless I put the binary at the root of my drive on windows 10.
I fixed it by shortening the classpath using a wildcard, see below.
set "APP_CLASSPATH=%APP_LIB_DIR%\com.github.simplesteph.....
to
set "APP_CLASSPATH=%APP_LIB_DIR%/*"

hmmm if there's a fix for this, happy to accept a PR. The executables are generated using a sbt plugin

here ya go, https://github.com/simplesteph/kafka-security-manager/pull/60

solved by #60


[DO NOT MERGE]fix: update test to fix pr 163

Signed-off-by: Allen Sun<EMAIL_ADDRESS>
1.Describe what this PR did
TEST for pr #163
2.Does this pull request fix one issue?

3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews

LGTM


[T4A2][T15-B1]Niveetha Nair

Ready for review
(1) Add an instance-level member int sequenceNumber and a class-level variable int nextSequenceNumber to the Person class
(2) Convert the methods of the Parser class to a class-level methods

@Niveetha
Great work!


Changed erl func representation to ex style for consistency.

Minor update to prevent any possible confusion from any readers.

@pjhampton what about the examples for Mnesia.dirty_read/1, they're using :mnesia?

Jeez, well spotted @doomspork! I think the consistency is quite important in this lesson as we are using an alternative syntax to the traditional :erlang.func/x representation in Elixir.

:+1:


Depth check prepass

Security logic is kind of confusing. But it's hard to reason about invalid JSON without actually parsing it (which is what we're trying to avoid). Here, if there will be recursion > maxDepth, there will either be a DepthError or a json.SyntaxError later before that happens.
libkb tests pass after vendoring in.

Not sure how to turn on Travis. Do I need special permissions on the github or travis sides?

Can you make the checker exportable? We might want it also in the main repo, if we ever are decoding into an interface{} there, which we might be...

Could we refactor to use go-jsonw instead of encoding/json in those places instead?

maybe. is there a reason not to export?

I thought because the precondition/postconditions are weird it would be better to keep it abstracted, since go-jsonw Unmarshal seems like a drop in replacement of encoding/json's (could be wrong about this).

Looks like there are 9 places where we do that through either json.Unmarshal or json.Decoder.Decode. Should I make a parallel PR for these to switch to use jsonw?

would it work in all 9 cases?  what happens in those cases with the interface{} once it's pulled out?

wait, I'm not sure we should move anything not using jsonw to jsonw....which places are we talking about?

@patrickxb
libkb/api.go:337
libkb/db.go:63
libkb/json.go:78,282
libkb/log_send.go:539
libkb/log_send_test.go:80
libkb/login_session_test.go:37
lru/lru.go:78kk
service/apiserver.go:118
teams/loader_chain_test.go:142

seems like in api.go, we'd want to just run the EnsureMaxDepth pass by hand

Also, it's running on a stream, so we have to change the approach...


Deploy ODA update script to run regularly on the PPI

The odaupdate.py script (currently under development in the omu_experimental branch on github.com:metno/oda2mmd) needs to be deployed to run regularly (typically as a cron job) on the PPI.
The development and testing of the PPI mechanism can be done independently of developing odaupdate.py itself, using dummy data and/or commenting out actual calls to MMS and DMCI. The "official" deployment obviously needs to await completion of the first version.

NOTE: This tasks also involves completing odaupdate.py wrt. landing pages (on thredds etc.). Currently no (correct) reference to a landing page is included in the netCDF file.


can we use pip install when running dsub?

does  this work with dsub? basically, I wonder if we can install some tools after launching image.
thanks.
--image us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.1.19
--command 'set -o errexit &&
set -o xtrace &&
pip install -U pytest &&
cp ${bam} ${bai}'
I had errors like this:
script: |-
#!/usr/bin/env bash
set -o errexit &&
set -o xtrace &&
pip install -U pytest &&
cp ${bam} ${bai}
script-name: set
start-time: '2023-05-20 00:19:11.765508'
status: FAILURE
status-detail: |
)')': /simple/pytest/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a2ea90>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a2eed0>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a36350>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
ERROR: Could not find a version that satisfies the requirement pytest (from versions: none)
ERROR: No matching distribution found for pytest
status-message: |-
Stopped running "user-command": exit status 1: )')': /simple/pytest/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a2ea90>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a2eed0>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7362f1a36350>, 'Connection to pypi.org timed out. (connect timeout=15)')': /simple/pytest/
ERROR: Could not find a version that satisfies the requirement pytest (from versions: none)
ERROR: No matching distribution found for pytest

hi Willy, thanks for the response. I tested again, and also tested without using dsub to make sure 1) pypi was not down; 2) --block-external-network was null.
my code is like this, can you spot anything wrong?
or would you mind sharing your code so I can test as well? thanks again.
aou_dsub
--image us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.1.19
--disk-size 512
--boot-disk-size 50
--logging "${WORKSPACE_BUCKET}/data/plink/logging"
--input bam="${WORKSPACE_BUCKET}/data/readme.txt"
--output bai="${WORKSPACE_BUCKET}/data/readme2.txt"
--command 'set -o errexit &&
set -o xtrace &&
pip install -U pytest &&
cp ${bam} ${bai}'

So it sounds like you're running dsub on the AoU platform which may have some restriction on accessing an external network. Please reach out to<EMAIL_ADDRESS>to help work through your dsub use case(s) on the AoU workbench. In particular, I think it'd be good to show your test without using dsub and your test in dsub.
And in case you were interested this is my exact dsub command that works (outside of Aou):
dsub \
  --provider google-cls-v2 \
  --project <MY_PROJECT> \
  --logging gs://<MY_BUCKET>/hello/ \
  --image us.gcr.io/broad-dsp-gcr-public/terra-jupyter-aou:2.1.19\
  --command 'set -o errexit && set -o xtrace && pip install -U pytest && echo hello' \
  --regions us-central1 \
  --boot-disk-size 100 \  # Because terra-jupyter-aou image is large
  --wait

I'm asking around to see who's capable of looking further into this. I will connect you once found.
Otherwise, I notice you're using the command aou_dsub. Is that a bash function? Are you able to share the code for aou_dsub?

@jqian2015 I've confirmed with other AoU folks that worker nodes in AoU do not have internet access. Can you please email me at<EMAIL_ADDRESS>so I can follow up with you on next steps?


Profile Image Obscured

Uploaded a 512x512 jpg and found only a sliver of the top of the image appears in the profile.

Hi Ryan,
I will test this out and push a fix by tomorrow at some point.
I'm seeing a lot of people copy-pasta the example forms (which are there as a guide only), and will work toward a better solution involving the native Grav forms plugin while still keeping the sweetalerts. I will try to incorporate those features in the near future.
Thanks for using the theme!
Jason


Shouldn't the README be updated about develry gem?

As per Issue #36 we have a ruby gem now and shouldn't this be the recommended way of installation?

The gem is now released as devtools, and thx to @backus the readme is also upto date closing.


Update parsing of annotation dir names in adjudication mode

Interesting. I guess it wasn't handling relative paths.


use obj mgr from ioenvironment

Codecov Report

Merging #114 (f37e000) into stable/v3.x (dee48f5) will increase coverage by 1.44%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@               Coverage Diff               @@
##           stable/v3.x     #114      +/-   ##
===============================================
+ Coverage        44.32%   45.77%   +1.44%
===============================================
  Files              136      126      -10
  Lines            17569    16148    -1421
  Branches          1978     1911      -67
===============================================
- Hits              7787     7391     -396
+ Misses            9059     8053    -1006
+ Partials           723      704      -19

Impacted Files
Coverage Δ

src/engine/homestore_base.hpp
66.66% <ø> (ø)

src/engine/homestore.hpp
68.31% <100.00%> (ø)

src/engine/homestore_base.cpp
100.00% <100.00%> (ø)

... and 259 files with indirect coverage changes


What does _downloadQueue.maxConcurrentOperationCount do?

I am developing an app which uses the SDWebImage lib. I met a strange problem. For example, I have six images to download using SDWebImageManager's downloadWithURL function. However, I only get two images displayed. No matter how I refresh the view, I cannot get more image downloaded. I found a variable named maxConcurrentOperationCount in SDWebImageDownloader and found its value is set as 2. I know this value is the capacity of the concurrent queue. Just wondering if this means the lib will only download two images at a time or it just means the lib will only deal with two downloads simultaneously and finally will still download all images (each download will call the downloadImageWithURL:options:progress:completed: once.)

@mmjuns not its not a but. the number show the max concurrent operations at any given time. check the sample code. it words just fine. i think there is an issue with your project.

@mythodeia
You are correct. I tested the latest version and it works fine. Since the project is not written by me, I just want to confirm my guess is right. Thanks.


Update language

Description
Exchanged some words for some better words.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@sanscontext going to merge this so I can get the ref updated in the dashboard.

@ashryanbeats totally agree. My understanding from the context of what you do here is that you can register one and possibly multiple callback URIs with the backend, so it knows where to point users on successful auth. Unless I'm missing some details on the implementation, that seems more like a list-list than an allowlist. :)
But also if I'm wrong, I'm wrong and happy to change it!


multiple LoadBalancers

Builds upon #2584 to provide multiple loadbalancers.
ActivationThrottler behavior is moved into LoadBalancer.check
provided impls are resolved using LoadBalancerResolver; resolver impls are currently: SingleLoadBalancerResolver (use a single LB for everything) and KindBasedLoadBalancerResolver (use typesafe config to map kind -> LoadBalancer impl)

@markusthoemmes can you take a look when you have a moment? Wondering also about delegating timeout to Loadbalancers as well. In multiple load balancer case, it will be useful to have the execution parameters (like timeout) be owned by each balancer.

@tysonnorris can you help labeling this pr?

Closing this based on some feedback from @markusthoemmes; will revisit similar functionality in the future


Micronic Window Treatment

do i just do it like this?

@greens Can we add the invite link please?

luacheck failures in case you can't see them:
Checking drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua 4 warnings

    drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua:14:7: (W211) unused variable log
    drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua:17:7: (W211) unused variable window_shade_defaults
    drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua:22:7: (W211) unused variable window_preset_defaults
    drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua:23:7: (W211) unused variable SHADE_SET_STATUS

@richardparkkorea would still like to see some tests before I sign off.

how should i show you?
may be do i need to create some test_zigbee_window_treatment_???,lua file  for tests? or if there's another way, please give the guide

Also your tests introduced more luacheck failures:
Checking drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua 2 warnings

    drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua:24:7: (W211) unused variable OnOff
    drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua:25:7: (W211) unused variable PowerConfiguration

Checking drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua 1 warning

    drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua:23:1: (W611) line contains only whitespace

Unit test failures in /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/test/test_zigbee_window_treatment_micronic.lua:
    Window Shade state closed
    Window Shade state open
    Handle invert in infochanged
    Refresh necessary attributes

i dont' know whay unit test failed... is there any way I cant test it myself. if there is , please give me a guilde

Checking drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua 1 warning

    drivers/SmartThings/zigbee-window-treatment/src/micronic/init.lua:18:7: (W211) unused variable utils

Guides for running tests locally:
https://developer.smartthings.com/docs/devices/hub-connected/set-up-dev-env
https://developer.smartthings.com/docs/devices/hub-connected/test-your-driver

the folliwing message came out during the test, what is the cause?
D:\Work\projects\2022_Smartthings_Curtain\hub-conn\lua\SmartThingsEdgeDrivers\drivers\SmartThings\zigbee-window-treatment\src>lua53 test\test_zigbee_window_treatment_micronic.lua
Running test "Window Shade state closed" (1 of 4)
WARN  || Unexpected filesystem lookup for capability switch
WARN  || Unexpected filesystem lookup for capability switchLevel
WARN  || Unexpected filesystem lookup for capability battery
WARN  || Unexpected filesystem lookup for capability illuminanceMeasurement
WARN  || Unexpected filesystem lookup for capability occupancySensor
WARN  || Unexpected filesystem lookup for capability temperatureMeasurement
WARN  || Unexpected filesystem lookup for capability relativeHumidityMeasurement
WARN  || Unexpected filesystem lookup for capability colorTemperature
WARN  || Unexpected filesystem lookup for capability colorControl
WARN  || Unexpected filesystem lookup for capability thermostatHeatingSetpoint
WARN  || Unexpected filesystem lookup for capability thermostatCoolingSetpoint
WARN  || Unexpected filesystem lookup for capability lock
WARN  || Unexpected filesystem lookup for capability powerMeter
WARN  || Unexpected filesystem lookup for capability energyMeter
WARN  || Unexpected filesystem lookup for capability contactSensor
WARN  || Unexpected filesystem lookup for capability waterSensor
WARN  || Unexpected filesystem lookup for capability motionSensor
WARN  || Unexpected filesystem lookup for capability smokeDetector
WARN  || Unexpected filesystem lookup for capability valve
WARN  || Unexpected filesystem lookup for capability powerSource
WARN  || Unexpected filesystem lookup for capability windowShade
WARN  || Unexpected filesystem lookup for capability windowShadePreset
WARN  || Unexpected filesystem lookup for capability windowShadeLevel
WARN  || Unexpected filesystem lookup for capability soundSensor
WARN  || Unexpected filesystem lookup for capability carbonMonoxideDetector
Received unexpected error: ...d\zcl_clusters\WindowCovering\server\attributes\init.lua:24: module 'st.zigbee.generated.zcl_clusters.WindowCovering.server.attributes.CurrentPositionLiftPercentage' not found:
no field package.preload['st.zigbee.generated.zcl_clusters.WindowCovering.server.attributes.CurrentPositionLiftPercentage']
no file 'D:\Work\projects\2022_Smartthings_Curtain\hub-conn\lua\SmartThingsEdgeDrivers\lua_libs-api_v3\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage.lua'
no file 'D:\Work\projects\2022_Smartthings_Curtain\hub-conn\lua\SmartThingsEdgeDrivers\lua_libs-api_v3\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage\init.lua'
no file '.\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage.lua'
no file '.\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage\init.lua'
no file 'C:\dll\lua-5.4.2_Win64_bin\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin..\lib\lua\5.3\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin\loadall.dll'
no file '.\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage53.dll'
no file '.\st\zigbee\generated\zcl_clusters\WindowCovering\server\attributes\CurrentPositionLiftPercentage53.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin\st.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin..\lib\lua\5.3\st.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin\loadall.dll'
no file '.\st.dll'
no file 'C:\dll\lua-5.4.2_Win64_bin\st53.dll'
no file '.\st53.dll'
stack traceback:
[C]: in function 'require'
...d\zcl_clusters\WindowCovering\server\attributes\init.lua:24: in metamethod '__index'
...st\zigbee\generated\zcl_clusters\WindowCovering\init.lua:148: in metamethod '__index'
.\vimar\init.lua:158: in main chunk
[C]: in function 'require'
.\init.lua:30: in main chunk
[C]: in function 'require'
[C]: in function 'xpcall'
...ngsEdgeDrivers\lua_libs-api_v3\integration_test\init.lua:226: in upvalue 'run_configured_test'
...ngsEdgeDrivers\lua_libs-api_v3\integration_test\init.lua:342: in function 'integration_test.run_registered_tests'
test\test_zigbee_window_treatment_micronic.lua:117: in main chunk
[C]: in ?
FAILED
.....

used command

lua53 test\test_zigbee_window_treatment_micronic.lua

I believe you left out some \ in your LUA_PATH around the question marks:
set LUA_PATH=(absolute path)\lua_libs-api_v3\?.lua;(absolute path)\lua_libs-api_v3\?\init.lua;.?.lua;.\?\init.lua;

what should i do for next? do i have to contact to samsung smartthings team to work on hardware authentication? or else?

Hey @richardparkkorea I will let them know you are reaching out and will have them follow up. Thank you.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This certification request has closed, if you have questions about WWST certification please reach out to<EMAIL_ADDRESS>


Consider a better format for inline color views

RGBA is not the most friendly or compact format; HSLA or hex might be better. This could also be an option in user preferences.

Inline color views now display as an Edit color button with the background color of the color.


[Redis] patch-schedule commands need improvement

[x] The redis patch-schedule group has a set command.  This should be deprecated in favor of dedicated create/update commands.
[ ] The patch-schedule create command should have strongly typed arguments and not accept a JSON string.

Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)
azure-cli (2.0.28)

acr (2.0.21)
acs (2.0.26)
advisor (0.1.2)
appservice (0.1.26)
backup (1.0.6)
batch (3.1.10)
batchai (0.1.5)
billing (0.1.7)
cdn (0.0.13)
cloud (2.0.12)
cognitiveservices (0.1.10)
configure (2.0.14)
consumption (0.2.1)
container (0.1.18)
core (2.0.28)
cosmosdb (0.1.19)
dev-tools (0.1.1)
dla (0.0.18)
dls (0.0.19)
eventgrid (0.1.10)
extension (0.0.9)
feedback (2.1.0)
find (0.2.8)
interactive (0.3.16)
iot (0.1.17)
keyvault (2.0.19)
lab (0.0.17)
monitor (0.1.2)
network (2.0.23)
nspkg (3.0.1)
profile (2.0.19)
rdbms (0.0.12)
redis (0.2.11)
reservations (0.1.1)
resource (2.0.24)
role (2.0.19)
servicefabric (0.0.10)
sql (2.0.21)
storage (2.0.25)
testsdk (0.1.0)
vm (2.0.27)

Python location '/Users/travisprescott/github/azure-cli/env/bin/python'
Extensions directory '/Users/travisprescott/.azure/cliextensions'

Python (Darwin) 2.7.12 |Continuum Analytics, Inc.| (default, Jul  2 2016, 17:43:17)
[GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)]

Patch-schedule create command needs list of schedule entries. Each schedule entry has dayOfWeek, startHourUtc, and maintenanceWindow properties. There is currently no way to make CLI accept list of schedule entries as strong typed arguments.
Option to take only one item of schedule entry at a time allows for making them strong typed. But this option will allow them to set only one schedule entry. If command is ran again with next set of schedule entry, it will override the previous entry.
@haroldrandom Given that there is no feasibility to implement list of schedule entries as strong typed arguments, can you close this issue

It's a history problem just before the decision of flatten JSON format parameter or strong typed argument has been made.
Currently we are unwilling to receive command line options of JSON format. And command line doesn't equip with power like PowerShell which is a object-oriented Script Language. We think flatten all JSON paramater values into many single individual options would be a good way for user.
However, considering that current user did't report or vote similar problem and also redis is a frequently used service of Azure, correcting this behavior would break many user's daily work which confusing them a lot and consuming them a lot of time to figure out.
So, it's fine to close.
But, If there are any new users report similar question like this, redis service should take time to fix that we insist. It's a good suggestion to make CLI more consistency.