require() doesn't load the object correctly

I am using duk_ API for embedding JavaScript in my application. I found that using 'require()' fails to load the object correctly.
The repro data is listed below:
----------------------------------------- program.cpp -------------------------------
#include <stdio.h>

#include "duktape.h"

/**
 *
 */
duk_ret_t do_loadFile(duk_context *ctx)
{
    const char *moduleName = duk_require_string(ctx, 0);
    duk_pop(ctx);
    duk_push_string_file(ctx, moduleName);

    return 1;
}

/**
 *
 */
int main(int argc, _TCHAR* argv[])
{
    duk_context *ctx = duk_create_heap_default();

    if (!ctx)
    {
        printf("Failed to create a Duktape heap.\n");
        return -1;
    }

    duk_push_global_object(ctx);
    idx = duk_push_c_function(ctx, do_loadFile, 1);
    duk_put_prop_string(ctx, -2, "loadFile");

    duk_eval_string(ctx, "Duktape.modSearch = function (id) {\n"
        "  var res = loadFile('./Scripts/' + id + '.js'); \n"
        "  if (typeof res === 'string') {\n"
        "    return res;\n"
        "  };"
        "  throw new Error('module not found: ' + id);\n"
        "};"
    );

    duk_eval_string(ctx, "var MYObject = require('MYObject');\n"
        "print(typeof(MYObject));\n"
        "for (var k in MYObject) {\n"
        "    print(i + ': ' + k.toString());\n"
        "    i++;\n"
        "}\n"
        );

    duk_destroy_heap(ctx);
    return 0;
}

------------------------------  MyObject.js  --------------------------------
var MYObject;
(function (MYObject) {
    (function (Collections) {
    })(MYObject.Collections || (MYObject.Collections = {}));
    var Collections = MYObject.Collections;
})(MYObject || (MYObject = {}));

-------------------------------------------- compile line ---------------------------------
g++ -std=c++11 program.cpp duktape.c -o program -lm

----------------------  output:
expected:
   object
   0: Collections

actual:
  object

------------------------explanation:

Basically, I am unable to call any of the class's methods or access its properties...

Unrelated, but you shouldn't duk_pop() the string argument given to do_LoadFile: once you do that, the const char * returned from duk_require_string() may no longer be valid if there's no other reference to it. In this case there are other references so it shouldn't cause an actual problem here.

@svaarala:
Something I learned the hard way. :). When I first started using Duktape, my OCD compelled me to pop stuff off the stack as soon as possible and I kept getting segfaults because it was freeing the string.  Took me a bit to figure out what happened each time, now I know better.

Hmm - your MyObject.js doesn't export any symbols? In a CommonJS module a module is expected to export symbols explicitly, e.g.:
// adder.js
exports.add = function add(x,y) { return x + y; }

Which is then used like:
var adder = require('adder');
print(adder.add(1, 2));

@fatcerberus When I have time to rework the guide I'll try to clarify that with more explicit code examples - it really is a central point that the value stack is an easy guarantee of reachability and pointers can be considered live as long they are reachable. It's discussed e.g. here:

http://duktape.org/guide.html#type-pointer-stability

@mhshami01 Any updates on this?

I don't have to use 'exports' explicitly when running the code through NodeJS...

CommonJS requires that symbols are exported explicitly through exports. You can write to globals directly as follows though, but it's not really good style in my view:
// module.js
foo = 123;  // gets assigned to global object
var bar = 234;  // this doesn't

Could you paste an short Node.js example of what you mean?

Here is what I have:
------------------------------------- MyObject.js
var MyObject;
(function (MyObject) {
(function (Collections) {
})(MyObject.Collections || (MyObject.Collections = {}));
var Collections = MyObject.Collections;
})(MyObject || (MyObject = {}));
var MyObject;
(function (MyObject) {
function logName(name) {
if (typeof console !== "undefined") {
console.log('MyObject::logName(' + name +')');
} else {
print('MyObject::logName(' + name +')');
}
}
MyObject.logName = logName;
exports = module.exports = MyObject;

})(MyObject || (MyObject = {}));
---------------------------------------- app.js
var MyObject = require('MyObject');
print(typeof(MyObject));
var i = 0;
for (var k in MyObject) {
print(i + ': ' + k.toString());
++i;
}
print('done');
MyObject.logName('Hello!');
----------------------------------- output
from node (node app.js):
object
0: Collections
1: logName
done
MyObject::logName(Hello!)

You're using module.exports in that example.
Duktape 1.2.x doesn't support that but support for module.exports was merged to master just a few days ago #201.

the branch 'master' works. thank you!

Good to hear :)


Create a Short Overview Video

A short overview video has been requested discussing how this developer mechanism is visioned to work.

This has been completed.  Please reach out for video access if required.


do not emit a huge amount of particle when mutliblocks are formed

Issue description:
Every time I teleport near my Turbine it emits a lot of particles as if it were reforming (again) and lags my FPS down to 1 for 10 seconds.
I don't know what's causing this massive amount of lag but it needs to be fixed.
Version (make sure you are on the latest version before reporting):
Minecraft: 1.12.2
Forge: 2705
Mekanism: <IP_ADDRESS>6
Other relevant version: list-alphabetical.txt

IMO, while it's initially formed is fine, but the emission of particles really should be suppressed while it's loaded.


Pin version of mdBook

Hi!
I'm not sure if this applies to this repo because I don't know if you deploy the book automatically?
We would like to issue a new release of mdBook containing some changes that could potentially break current books, the config file changed a bit for example. However we found out that a lot of projects automatically deploy using the latest available version and so any breaking update could result in books not being deployed anymore..
We would like to avoid that and recommend pinning the version of mdBook in your deployment script. Cargo supports semver ranges on cargo install (right now it issues a deprecation warning, but in the future this warning should go away thanks to rust-lang/cargo#4229)
You can thus simply change cargo install mdbook to
cargo install mdbook --vers "^0.0.22"

Next release will be 0.1.0 and we will try to adhere to semver as much as possible.
For more info, azerupi/mdBook#327 is the tracking issue on our repository.

Thanks or the heads up! I haven't worked on this in a few months, and it probably doesn't apply to this repo directly, but I really appreciate you reaching out! :+1:


Seabreeze is only available in East US

The CGS Resource Provider is only available in EAST US at the moment

WestUS and WestEurope are live :-). More to come periodically.


Unable to change a user's origin via the API

What version of UAA are you running?
4.11.0
How are you deploying the UAA?
I am deploying the UAA using cf-deployment
What did you do?
Migrate our users from UAA to a UAA IDP.
uaac user update<EMAIL_ADDRESS>--origin idp-uaa

What did you expect to see? What goal are you trying to achieve with the UAA?
I expected it to change the origin to 'idp-uaa'.
What did you see instead?
CF::UAA::NotFound: CF::UAA::NotFound

The user does exist, as confirmed by running uaac user get<EMAIL_ADDRESS>The problems
There are two problems:

I am aware the API probably has to use this to identify the user, given a 'user' is uniquely identified by an aggregation of name, origin, and zone. However, we need to change the origin of all our users and would need to do this via the API, not via database hackery. Is there any way to do this via the API? If not, could you allow the changing of the origin via the API?
The documentation for the API does not state what the origin field is actually used for.

Thanks for creating this issue. I think you are correct in that the uaa cli does not allow changing a user's origin.
I think one approach you can take to change the users origin is to the /Users API to list all the users (keep in mind this api uses pagination)
i.e. to list users with origin = uaa, and then use jq to 'map' each user to have a different origin ("new-origin")
uaac curl -k '/Users?filter=origin+eq+%22uaa%22'  | awk '/RESPONSE BODY/,0'  | grep -v 'RESPONSE BODY'  | jq '.resources[]' | jq '{
  "id" : "\(.id)",
  "userName" : "\(.userName)",
  "name" : {
    "familyName" : "\(.name.familyName)",
    "givenName" : "\(.name.givenName)"
  },
  "emails" : (.emails),
  "groups" : (.groups),
  "approvals" : (.approvals),
  "phoneNumbers" : (.phoneNumbers),
  "active" : (.active),
  "verified" : (.verified),
  "origin" : "new-origin",
  "zoneId" : "\(.zoneId)",
  "passwordLastModified" : "\(.passwordLastModified)",
  "schemas": (.schemas)
}'

You would then have to for every user mapped in the previous step, use the /Users api to update the user with the new origin
i.e. to update a single user
 uaac curl -X PUT -k '/Users/<<your user id goes here>>'  -H 'Accept: application/json'  -H 'Content-Type: application/json'  \
   -H 'If-Match: *' -d '<<your user json payload goes here>>

wrt documentation about the origin, the api docs states for the origin field: The alias of the Identity Provider that authenticated this user. The value uaa indicates a user from the UAA's internal user store.. Is this something you were aware of (is this a problem of discoverability of uaa docs)? , or does the above description about a users origin need expanding / clarification?

ping @henrytk

@DennisDenuto thanks for the detailed response which solves the problem. I made a false assumption about the API based on the CLI, so really I should have raised this issue on the CLI repository. If it still causes pain in the future I shall raise an issue there.

Is this something you were aware of (is this a problem of discoverability of uaa docs)?

No.
Closing this issue.


Add Python 3 compatibility

Now works in Python 3.x and still backwards compatible with Python 2.7.x.
I've only implemented this when using Ganglion via Wifi, so it may not work on other paths, such as via user.py, but everything should still work on Python 2.7.x. Did fix up all the print statements for Python 3 though. #56
With user.py, tested and can confirm it works until it tries to scan Bluetooth devices but did not test further as I did not have this setup.

I've now also tested using BTLE with Ganglion (via user.py) and it works for both Python 2.7 and Python 3.

Thanks so much!


Why set relative coordinate of bottom center LiDAR box is (0.5, 0.5, 0) ?

I notice that in  mmdet3d/core/bbox/structures/box_3d_mode.py, the illustration of different ways to represent a box,

 The relative coordinate of bottom center in a LiDAR box is (0.5, 0.5, 0),     and the yaw is around the z axis, thus the rotation axis=2.
I don't understand why the relative coordinate of bottom center in a LIDAR box is (0.5,0.5,0)? In CAM box and In DEPTH box are (0.5,0.5,1.0), (0.5,0.5,0), which confusing me a lot.
Hope I can know the reason with your help!
Thank open-mmlab for your extraordinary work!

We just define boxes' bottom centers as their default centers, which is consistent with the definition of KITTI. Due to the positive direction of z-axis is up in LiDAR and DEPTH while that of y-axis is down in CAM, their centers are set to (0.5, 0.5, 0) and (0.5, 1.0, 0.5) respectively.

In liDAR coordinate, the relative center shown in the picture, I just don't know what is the usage of relative coordinate of bottom center?

A Geiger, P Lenz, C Stiller, and R Urtasun. 2013. Vision meets robotics: The KITTI dataset. Int. J. Rob. Res. 32, 11 (September 2013), 1231–1237. DOI:https://doi.org/10.1177/0278364913491297
I found information about bottom center definition in LiDAR, just as you pointed out above.
Thanks again~

In liDAR coordinate, we set relative coordinate of bottom center LiDAR box is (0.5, 0.5, 0), if we set relative coordinate of bottom center LiDAR box is (0., 0., 0.), will this cause some difference?

Sorry to bother you again! @Tai-Wang  I just don't know what is the reason setting (0.5, 0.5, 0) as relative coordinate of bottom center LiDAR box, the coordinate (0., 0., 0.) could be the displacement? if not, what is the reason.

It's all about definition. If you would like to define the relative coordinate of default center with (0, 0, 0), some other things need to be modified accordingly (e.g. the way to compute corners' coordinates).
In the current implementation, you can also specify your origin with corresponding coordinates (e.g. the gravity center is the center/origin in your setting, you can set origin=(0.5, 0.5, 0.5) and tensor[:, :3] = [the coordinates of gravity center]), and the initialization of these classes will automatically change it to the default setting. Please refer to this line.

Thanks for your answer!
When we transform CameraBox3D to LiDARBox3D, we will caculate corners, refer to https://github.com/open-mmlab/mmdetection3d/blob/a1e04538295b02d42fc59bb7ed58c59c98220174/mmdet3d/core/bbox/structures/lidar_box3d.py#L81.
       if origin != (0.5, 0.5, 0):              dst = self.tensor.new_tensor((0.5, 0.5, 0))             src = self.tensor.new_tensor(origin)             self.tensor[:, :3] += self.tensor[:, 3:6] * (dst - src)  # this line code puzzles me
If we set the origin as (8,8,0), we get:
dst-src = (0.5,0.5,0)-(8,8,0) = (-7.5,-7.5,0)
self.tensor[:, 3:6] means the width, length, and height, self.tensor[:, 3:6] * (dst - src) means the new center location is nearly 8 times far away from the (0,0,0) coordinate location. So what is the origin meaning?

(8,8,0) is really a strange setting. The center transformation is usually used when the your center setting is different from the default one. For example, if your provided center is defined at (0.5, 0.5, 0.5), then this transformation will change the center coordinate to the default one (0.5, 0.5, 0) (by subtract half height along the z-axis).

Thansk for your response~ As you said:provided center is defined at (0.5, 0.5, 0.5), I just don't know why not just set center at (0.0, 0.0, 0.0), which is more easier to calculate.

@Physu I think you misunderstand the term relative coordinate. A relative origin of (0.5, 0.5, 0) means self.tensor[:, 0:3] is calculated as [(x1+x2)/2, (y1+y2)/2, z1], where x1, x2, y1, y2, z1, z2 are the max/min coordinates of the box. This is just an encoding style of boxes, where we choose to store the bottom center of a box and its width, length, height.
As for the conversion, self.tensor[:, 3:6] * (dst - src) transform the difference in relative coordinate to absolute values. For example, if src==(0.5, 0.5, 0.5), then (dst - src)==(0, 0, -0.5), and self.tensor[:, 3:6] * (dst - src) = (0, 0, -0.5 * height), so that it will transform self.tensor[:, 0:3] down by half the height.

Feel free to reopen this issue should you have any further questions :)

@Wuziyi616 Thanks for your explaination!
I interpert the relative orgin center as a LiDAR box(specification as picture below), its volume is 1(means w,h,l equal to 1), and the origin center is located at [(x1+x2)/2, (y1+y2)/2, z1]
.
we take it as a standard metric for LiDAR box, can I just think the relative origin this way?

@Physu Yes, that's it! You get the point.

It's all about definition. If you would like to define the relative coordinate of default center with (0, 0, 0), some other things need to be modified accordingly (e.g. the way to compute corners' coordinates). In the current implementation, you can also specify your origin with corresponding coordinates (e.g. the gravity center is the center/origin in your setting, you can set origin=(0.5, 0.5, 0.5) and tensor[:, :3] = [the coordinates of gravity center]), and the initialization of these classes will automatically change it to the default setting. Please refer to this line.

@Tai-Wang @Wuziyi616 Hi there! I wonder why the yaw angle is not considered here to derive the new (x,y,z) for the 3DBoxes. For example, if there is a yaw angle not equal to 0, and the origin input in the function is (0.5, 1, 0.5), it seems to me that this line of code https://github.com/open-mmlab/mmdetection3d/blob/962fc830daebad3f93fc7cbf970728057c64977b/mmdet3d/core/bbox/structures/base_box3d.py#L68 may fail to take into account the yaw of the box.
The image attached below may better illustrate my question.

Point J is src, while Point I is dst. The yaw of the box is not 0.
Hope to know where I might be wrong.
Thanks for your help!


Implement SnapshotCloneCmd() and SnapshotCloneStatusCmd() CLIs

longhorn/longhorn#1815

Sorry. This PR need more testing. I should have opened a draft instead.

@PhanLe1010 let's merge it after resolving the @joshimoo 's comment.


/bin/bash: no closing quote

When I try to execute the command "chroot debian/ ..." inside the run script, it always tells me "no closing quote", I tried inserting both single and double quotes, removing them but nothing works, I don't know how I can solve it

Same problem.
I've solved it by manually download amd64 rootfs at https://github.com/tiann/eadb/releases, by default eadb prepare will download arm64.


Run scheduler after a job has finished

Currently, if a job has dependent jobs that cannot run on the same nodes
as that job, the execution of that dependent job may be delayed by up to
two minutes.  This commit removes that delay.

Coverage increased (+0.02%) to 65.65% when pulling 76805a1285030dc388927fab365fb0f9684c65c9 on guidow:scheduler_run_after_job_finish into d8d3d8ffab773995ad3a5c7bbd9e1ee03378b681 on pyfarm:master.


Prevent form from closing if validation fails

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3427)

@davidjumani general question - if we're not handling in finally Do we want the form to stay open in case of error?

@rhtyd Yes, in case there was a network or validation error.  I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3449)

@davidjumani can you address merge conflict?
@utchoang can you help review/test this? Thanks

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3474)

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/651 (JID-3480)


CSS Not working properly for statically generated site.

I have a nuxt webpage that uses tailwind and vue2-leaflet.
Everything looks fine in development mode (npm run dev)

However, when I create a static site (npm run generate) and view the dist folder on a local server, the leaflet map doesn't look correct. The map isn't loading properly and the markers are spilling out of the map.

If I remove tailwind, and re-run npm run generate and view the dist folder (the styling doesn't look great) but the map is displayed properly.
If anyone knows how to fix this, I would appreciate your help.
PS I chose tailwind as part on the nuxt project installation process.
And I have the following value in nuxt.config.js
 devModules: [     // Doc: https://github.com/nuxt-community/nuxt-tailwindcss     '@nuxtjs/tailwindcss',   ],

Hi @richeduni
This may be due to the purgeCSS module that is cleaning some of the vue2-leaflet css I guess.
You may want to whitelist them: https://github.com/Developmint/nuxt-purgecss#append-a-value-to-the-defaults

Hi, I'm not using purgeCSS. Should I be using it?
I tried adding purgeCSS after your suggestion and it didn't make any difference?
Here is a copy of my nuxt.config.js (In this version I'm not using purgeCSS).
export default {
  mode: 'universal',
  /*
  ** Headers of the page
  */
  head: {
    title: process.env.npm_package_name || '',
    meta: [
      { charset: 'utf-8' },
      { name: 'viewport', content: 'width=device-width, initial-scale=1' },
      { hid: 'description', name: 'description', content: process.env.npm_package_description || '' }
    ],
    link: [
      { rel: 'icon', type: 'image/x-icon', href: '/favicon.ico' }
    ]
  },
  /*
  ** Customize the progress-bar color
  */
  loading: { color: '#fff' },
  /*
  ** Global CSS
  */
  css: [
      "leaflet.markercluster/dist/MarkerCluster.css",
      "leaflet.markercluster/dist/MarkerCluster.Default.css",
      "vue-slider-component/theme/default.css"
  ],
  /*
  ** Plugins to load before mounting the App
  */
  plugins: [
    {src: "~/plugins/markercluster",ssr: false},
    {src: "~/plugins/slider",ssr: false},
  ],
  /*
  ** Nuxt.js dev-modules
  */
  devModules: [
    // Doc: https://github.com/nuxt-community/nuxt-tailwindcss
    '@nuxtjs/tailwindcss',
  ],
  /*
  ** Nuxt.js modules
  */
  modules: [
      'nuxt-leaflet',
  ],
  /*
  ** Build configuration
  */
  build: {
    /*
    ** You can extend webpack config here
    */
    extend(config, ctx) {
    }
  },

}

This module includes purge-css automatically, it's written in the README:

Also written in the README:
If you want to set any (additional) purgeCSS configuration options, you can add a purgeCSS configuration object:
// nuxt.config.js
{
  purgeCSS: {
    whitelist: ['css-selector-to-whitelist'],
  },
}

See full options here: https://github.com/Developmint/nuxt-purgecss#options

After looking at the CSS and installed nuxt-leaflet, you have to set this config:
purgeCSS: {
    whitelist: ['lvml'],
    whitelistPatterns: [/leaflet-.+$/],
    whitelistPatternsChildren: [/leaflet-.+$/]
  }

You can learn more here: https://www.purgecss.com/whitelisting

Ahh, didn't realise that nuxt tailwind came with purge css.
Also, thank you very much for that config info. Everything is working now.


Where did the 2.2.4 docs go?

Some of us haven't / can't upgrade to Material UI 4.0.0 . It would be nice to still be able to view the 2.2.4 docs site the same way the material-ui site allows you to select different versions.

Thanks we will implement this feature. But right now you can use https://material-ui-pickers-v2.dmtr-kovalenko.now.sh/

BTW this is actually 2.2.4 release. I don’t know why it says 2.2.2 version


Change the data model for Acceptable Bundles

The acceptable bundles data is modeled as such:
<type>-bundles:
  <repo>:
    - digest: <digest>
      effective_on: <timestamp>
      tag: <tag

For example:
task-bundles:
  quay.io/redhat-appstudio-tekton-catalog/task-buildah:
    - digest: sha256:c37e542031de193398cd54463af146e42539b5f5c9082df56d65354494566db0
      effective_on: "2023-11-06T00:00:00Z"
      tag: "0.1"
    - digest: sha256:97f21661e237735af04b37feeeaedd328424bfa0ebd4cd0f79ac39cde17137f6
      effective_on: "2023-10-25T00:00:00Z"
      tag: "0.2"

Then there's rego that interprets this data to do the right thing.
Sometimes we use the value of tag to determine what is the latest version for that particular tag. In such cases, there are really virtual lists, one for each tag value.
The reality is that there is always a tag value, and we could make that a requirement. This issue is about changing how the data is represented, for example:
task-bundles:
  quay.io/redhat-appstudio-tekton-catalog/task-buildah:
    "0.1":
      - digest: sha256:c37e542031de193398cd54463af146e42539b5f5c9082df56d65354494566db0
        effective_on: "2023-11-06T00:00:00Z"
    "0.2":
      - digest: sha256:97f21661e237735af04b37feeeaedd328424bfa0ebd4cd0f79ac39cde17137f6
        effective_on: "2023-10-25T00:00:00Z"

This would impact ec track bundle (may need to add code to convert things on the fly to allow for an easier transition), and ec-policies (may need to support both formats for a bit).

Another possible way to do it:
task-bundles:
  quay.io/redhat-appstudio-tekton-catalog/task-buildah:0.1:
    - digest: sha256:c37e542031de193398cd54463af146e42539b5f5c9082df56d65354494566db0
      effective_on: "2023-11-06T00:00:00Z"
  quay.io/redhat-appstudio-tekton-catalog/task-buildah:0.2:
    - digest: sha256:97f21661e237735af04b37feeeaedd328424bfa0ebd4cd0f79ac39cde17137f6
      effective_on: "2023-10-25T00:00:00Z"

This was done a while back. See examples here: https://github.com/enterprise-contract/ec-policies/blob/4b661e5993178a2a3e251062c033fa2e225c4992/example/data/trusted_tekton_tasks.yml#L1200


sdk (0.31) fails to start on fresh install

The Issue
Starting daemon with a fresh install. @jackrobison said to assign to @eukreign
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\IEUser\\AppData\\Local\\lbry\\lbrynet\\lbrynet.log'
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Internal Use
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

Fixed on latest RC


Fatal error when migrating (Laravel 5.2)

Followed setup instructions, however when I attempt to migrate I get the following error:
Tables: roles, role_user, permissions, permission_role
A migration that creates 'roles', 'role_user', 'permissions', 'permission_role' tables will be created in database/migrations directory

 Proceed with the migration creation? [Yes|no] (yes/no) [yes]:
 >

Creating migration...

  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Fatal error: Class name must be a valid object or a string

Exception trace:
 () at /home/vagrant/work/laravel/vendor/zizaco/entrust/src/commands/MigrationCommand.php:86
 Zizaco\Entrust\MigrationCommand->createMigration() at /home/vagrant/work/laravel/vendor/zizaco/entrust/src/commands/MigrationCommand.php:58
 Zizaco\Entrust\MigrationCommand->fire() at n/a:n/a
 call_user_func_array() at /home/vagrant/work/laravel/vendor/laravel/framework/src/Illuminate/Container/Container.php:507
 Illuminate\Container\Container->call() at /home/vagrant/work/laravel/vendor/laravel/framework/src/Illuminate/Console/Command.php:169
 Illuminate\Console\Command->execute() at /home/vagrant/work/laravel/vendor/symfony/console/Command/Command.php:256
 Symfony\Component\Console\Command\Command->run() at /home/vagrant/work/laravel/vendor/laravel/framework/src/Illuminate/Console/Command.php:155
 Illuminate\Console\Command->run() at /home/vagrant/work/laravel/vendor/symfony/console/Application.php:791
 Symfony\Component\Console\Application->doRunCommand() at /home/vagrant/work/laravel/vendor/symfony/console/Application.php:186
 Symfony\Component\Console\Application->doRun() at /home/vagrant/work/laravel/vendor/symfony/console/Application.php:117
 Symfony\Component\Console\Application->run() at /home/vagrant/work/laravel/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:107
 Illuminate\Foundation\Console\Kernel->handle() at /home/vagrant/work/laravel/artisan:35

Add table and model values into config/auth.php like:
'table' => 'admin',
'model' => App\Admin\Admin::class,

Fix found here:
http://stackoverflow.com/questions/34529621/how-to-fix-in-laravel-5-2-zizaco-entrustmigration-class-name-validation#
Leaving this open though.

http://stackoverflow.com/questions/34529621/how-to-fix-in-laravel-5-2-zizaco-entrustmigration-class-name-validation#answer-34615993
This answer on the page works, the accepted does not :/

This is related to #531 I think. I added references and my thoughts on how/why it happened and the solution which fixed it.


Syntax highlighting broken following ES6 spread operator

From @jamietre on December 29, 2016 14:58

VSCode Version: 1.9.0-insider commit 9486b4
OS Version: Windows 10

Steps to Reproduce:

Create an ES6 class using extends and add super(...args)
Observe lack of highlighting after super(...args)
Profit

Just noticed it this morning on insider build.
Update  - affects any use of spread operator

Copied from original issue: Microsoft/vscode#17905

While it works with the above example now, it still breaks for me in the simpler case:
const a = Math.max(...x);
const b = 2;

const b = 2; (and the entire rest of the file) is not highlighted at all.

Closing this as it is little bit different from the original issue and its easier to track that way. File #397

Confused about the status here. This is still broken in today's insider build, there don't seem to be any open issues addressing it.

@jamietre To test the fix, please try installing the Latest TypeScript and Javascript Grammar extension

Beautiful, thanks! I'm a bit confused about the relationship between the VS Code insider build and dependencies such as this, e.g. why would the bug have manifested without my intervention in an insider build, but the fix did not?

VSCode insiders contains the latest build for VSCode itself . For dependencies like this, the insiders build picks up the version listed in the package.json, which may not be the latest published version. So to pick up a new version of the TS/JS grammar, we still have to update VSCode to pick up the latest release of this project.
The Latest TS Grammar extension offers an even more up to date version of the TS and JS grammar for testing. It can be installed in older, non-insiders VSCode releases as well and is updated like a normal extension.
Hope that clear things up


feat: sync theme creations based in JSON files [colors,breakpoints]

#58

:tada: This PR is included in version 1.23.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Julia code on Second order Kuramoto dynamics

I am reproducing a paper  (Topological Determinants of Perturbation Spreading in Networks,  Mark Timme et al, PDF is also attached ) on second-order Kuramoto dynamics where an internal perturbation (a sinusoidal force) is used in a single arbitrary node to understand the propagation of perturbation through the network.
Motivated by the code "kuramoto_inertial.jl" I write a small code (code is attached here, Name: ). However, I am unable to add this time-dependent perturbation in this code.
New folder.zip

You accidentally define a function D(t) that returns another function
function D(t)

 D(t)=0.1*sin(t)

end

It should be either D(t) = 0.1 * sin(t), or
function D(t)
 return 0.1*sin(t)
end

Does this fix your issue?

Sorry to disturb you again.
We got another error:
"UndefVarError: odevertex not defined"
Code attached here.
On Fri, Feb 26, 2021 at 1:14 PM Micha<EMAIL_ADDRESS>wrote:

You accidentally define a function D(t) that returns another function
function D(t)
D(t)=0.1*sin(t)
end
It should be either D(t) = 0.1 * sin(t), or
function D(t)
return 0.1*sin(t)end
Does this fix your issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FHell/NetworkDynamics.jl/issues/74#issuecomment-786472654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUT76FM37FHZZWSYHRWCADTA5GMJANCNFSM4YH3MMOQ
.

Well, it says you didn't define the variable odevertex and indeed it is not in the script. What kind of dynamic do you want the odevertex to have? If you are looking for kuramoto model with inertia you can just go back to the original example script from our repo and copy paste the code snippet..

Did you solve your issue?

No, it didn't. I am unable to solve it. The only positive thing is: now I
am able to add force to all nodal dynamics (code attached), however unable
to force a single node.
Best
Chitta
On Fri, Mar 5, 2021 at 9:40 PM Micha<EMAIL_ADDRESS>wrote:

Did this solve your issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FHell/NetworkDynamics.jl/issues/74#issuecomment-791518083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUT76FF6C7QYXRYUSB4O4DTCD67PANCNFSM4YH3MMOQ
.

I am unable to solve it. The only positive thing is: now I am able to add
force to all nodal dynamics (code attached), however unable to force a
single node.
On Wed, Mar 10, 2021 at 11:30 PM Micha<EMAIL_ADDRESS>wrote:

Hey Chitta, it appears you just replied to the github e-mail.
Unfortunately, the attached code didn't get forwarded to the issue. Could
you post it here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PIK-ICoN/NetworkDynamics.jl/issues/74#issuecomment-795829180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUT76CLYJLVWLFCGTNG5ETTC6XTFANCNFSM4YH3MMOQ
.

With "here" i meant the issue on github that sends you these notifications: https://github.com/PIK-ICoN/NetworkDynamics.jl/issues/74

Hello, unfortunately this issue went unnoticed for a while. Could you solve your problem?
One possible solution is to define two different vertices: kuramoto_vertex and perturbed_kuramoto_vertex. Then you will create a list of vertices like this:
vertex_list = Array{VertexFunction}[kuramoto_vertex for v in vertices(g)]
vertex_list[perturbation_index] = perturbed_kuramoto_vertex

You should also take a look at this example in the documentation: https://pik-icon.github.io/NetworkDynamics.jl/dev/heterogeneous_system/


tableData changes if sorted/filtered

#923 fixes the issue of data going missing when sorting etc. however it now appears to change from an array of arrays to an array of objects:
https://codesandbox.io/embed/muidatatables-custom-toolbar-txw6d
(added a couple of 'bugged' examples to give you an idea what I was achieving before)
The reason having the original index was so useful was I could enrich the table with extra data that I don't necessarily want to display in the table ie add tooltips or a link etc.
If you click sort now you will see that I have added a link but as its the data order and rowIndex don't match the link always stays on the first row. I don't expect the index to make an appearance where it was but it would be useful it it was returned somewhere.

Ok, I see that. It's happening when arrays of objects are fed to the table. It doesn't happen with arrays of arrays. I'll work on it.
You can still add all of those things by using customBodyRender and mapping your data to whatever else you need.  That's likely to cause breakage in a number of areas, and it certainly may break in the future as the data structure might change, or add things, or remove things, etc. I know it's unfortunate in that there was a loophole that appeared to be helping you out, but it's just not reliable, and it's better to catch it sooner rather than later.

Sure. Got to love a loophole ;)

Haha! It looks like I may need to go back to array of objects, but only with the index/dataindex values, as it might be the only way to have consistency here. But again, if you add other props there, you do so at your own risk! :p


No Such Module app_links

Describe the bug
A clear and concise description of what the bug is.
iOS build is failing due to "no such module app_links".
This appears to be related to this commit: https://github.com/BasedHardware/omi/commit/440c93fc355cc1f698c3dcab72e4ec28cf0dc698
which introduced app links, but doesn't appear to have added a dependency.
To Reproduce
Steps to reproduce the behavior:

Download repo
Follow docs install setup
Open xcode
Build failing

Current behavior
A clear and concise description of what is currently happening
Xcode is failing to build the iOS application due to missing app_links
Expected behavior
A clear and concise description of what you expected to happen.
build should pass

Can you please try running flutter clean && flutter pub get in the app directory before running it from the xcode? Sometimes the build cache causes issues


[feature] support check name availability request in each resource collection

Description
This is a follow-up of #1651. We decided that:

We will not provide a generic check name availability operation in ResourceManager.
For each RP, its check name availability request will be only available for specific types. So we could generate the corresponding check name availability method in the collection class.

Use directive to manually do this, need to go through all RPs

Manually rename the checkNameAvaliablity to check

SDKs require renaming check name availability:

appservice: https://github.com/Azure/azure-sdk-for-net/pull/26407
appconfiguration: https://github.com/Azure/azure-sdk-for-net/pull/26464
cdn: https://github.com/Azure/azure-sdk-for-net/pull/26404
communication: https://github.com/Azure/azure-sdk-for-net/pull/26463
deviceupdate: https://github.com/Azure/azure-sdk-for-net/pull/26410
keyvault:
servicebus: https://github.com/Azure/azure-sdk-for-net/pull/26411
storage: https://github.com/Azure/azure-sdk-for-net/pull/26412
webpubsub: https://github.com/Azure/azure-sdk-for-net/pull/26413


fix(content-type): set content-type for webjar resources

Description
Setting the Content-Type header when responding with resources from the SwaggerUI webjar.
Without explicitly setting a content-type some proxy-serveres will automagically inject Content-Type: text/plain into the response-headers. Which in turn instructs the browser to not parse css, js etc.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Copy/Pasted portions of kompendium-swagger-ui  into existing codebase, and verified that the swagger-page correctly loads after deploy the application behind a reverse proxy.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have updated the CHANGELOG in the Unreleased section
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Marked as draft since I had some issues with the build locally, and need to further investigate and check the other boxes.

Thanks for opening this and sorry it took me so long to respond!!
Unfortunately Kompendium v3 (which is the alpha version I just released to support Ktor 2) cannot support swagger at the moment because swagger does not support OpenAPI 3.1.  This module has been removed, so I'm going to close this PR.  Thank


ko-KR translation has been added.

ko-KR translation has been added.
Please review the pull request.

Thank you @anpigon for your contribution and pull request!
We will have one more update on legacy eSteem Mobile app before we roll out our new mobile application (v2). So we will make sure to include your changes. For translation parts, have you tried to use crowdin before (https://translate.esteem.app) ? It would stream line review process for translation part of the changes

Thank you for your reply.
I'm looking forward to the new mobile application (v2).
and I have not used crowdin, but I'll try it.
Have a nice day. :-)


updated setup.py to resolve metadata from project (round 2)

Same update taking into account the feedback from the previous submission.  This version parses the associated metadata from the existing extension.yaml/activationSchema.json files so that developers don't have to maintain those values in multiple locations.
It now

will not fail if extenison.yaml/activationSchema.json are missing (will just return default values instead).
does not add a dependency on PyYAML.

Thank you!

minor issues addressed.  going to dig into the multiple activationSchema.json item next.
Thanks!


[INTEL MKL] Enable DNNL BatchMatMul support with broadcast.

This PR enables new features from DNNL to perform BatchMatMul with broadcast. Current support is up to rank 12 tensors. Earlier, the BatchMatMul op was using cblas api from Intel Math Kernel Library(MKL).

Submitted from wrong email.


Free uninitialized variable-width key column in abandon partial agg mode.

Bug description
facebook::velox::HashStringAllocator::Header::isContinued() const HashStringAllocator.h:64
facebook::velox::HashStringAllocator::free(facebook::velox::HashStringAllocator::Header *) HashStringAllocator.cpp:303
facebook::velox::exec::RowContainer::freeVariableWidthFields(folly::Range<…>) RowContainer.cpp:305
facebook::velox::exec::RowContainer::eraseRows(folly::Range<…>) RowContainer.cpp:280
facebook::velox::exec::GroupingSet::toIntermediate(const std::shared_ptr<…> &, std::shared_ptr<…> &) GroupingSet.cpp:963
facebook::velox::exec::HashAggregation::getOutput() HashAggregation.cpp:505
facebook::velox::exec::Driver::runInternal(std::shared_ptr<…> &, std::shared_ptr<…> &, std::shared_ptr<…> &) Driver.cpp:421
facebook::velox::exec::Driver::run(std::shared_ptr<…>) Driver.cpp:547
$_1::operator()() const Driver.cpp:203
folly::detail::function::FunctionTraits::callSmall<…>(folly::detail::function::Data &) Function.h:346
folly::detail::function::FunctionTraits::operator()() Function.h:375
[Inlined] void folly::catch_exception<folly::Function<void ()>&, void (&)(char const*) noexcept, char const*&, void>(folly::Function<void ()>&, void (&)(char const*) noexcept, char const*&) Exception.h:285
[Inlined] folly::Executor::invokeCatchingExns<…>(const char *, folly::Function<…>) Executor.h:234
folly::ThreadPoolExecutor::runTask(const std::shared_ptr<…> &, folly::ThreadPoolExecutor::Task &&) ThreadPoolExecutor.cpp:100
folly::CPUThreadPoolExecutor::threadRun(std::shared_ptr<…>) CPUThreadPoolExecutor.cpp:326
std::__invoke[abi:v15006]<…>(void (folly::ThreadPoolExecutor::*&)(std::shared_ptr<…>), folly::ThreadPoolExecutor *&, std::shared_ptr<…> &) invoke.h:359
std::__apply_functor[abi:v15006]<…>(void (folly::ThreadPoolExecutor::*&)(std::shared_ptr<…>), std::tuple<…> &, std::__tuple_indices<…>, std::tuple<…> &&) bind.h:263
std::__bind::operator()[abi:v15006]<…>() bind.h:295
folly::detail::function::FunctionTraits::callSmall<…>(folly::detail::function::Data &) Function.h:346
folly::detail::function::FunctionTraits::operator()() Function.h:375
<lambda>::operator()() NamedThreadFactory.h:40
decltype(std::declval<folly::NamedThreadFactory::newThread(folly::Function<void ()>&&)::'lambda'()>()()) std::__1::__invoke[abi:v15006]<folly::NamedThreadFactory::newThread(folly::Function<void ()>&&)::'lambda'()>(folly::NamedThreadFactory::newThread(folly::Function<void ()>&&)::'lambda'()&&) invoke.h:394
std::__thread_execute[abi:v15006]<…>(std::tuple<…> &, std::__tuple_indices<…>) thread:290
std::__thread_proxy[abi:v15006]<…>(void *) thread:301
_pthread_start 0x00007ff81111a1d3
thread_start 0x00007ff811115bd3

The above is the crash stack. What happens is this:

Abandon partial mode is entered.
Once in this mode, HashAgg produces the "group by key" columns of output by directly copying the "group by key" columns of input vector.
An implication of above is "group by keys" of intermediateRows_ of GroupingSet are uninitialized. In contrast, in "normal" agg mode, the "group by keys" are initialized by "HashTable::storeKeys". This is not an issue if "group by keys" are POD types.
However, if "group by keys" are non-POD, like string, HashAgg blows up with the above stack when we get to the end of HashAgg::GetOutput and try to free the rows of intermediateRows_

Suggested fix:

The most elegant fix would be in how we construct intermediateRows_. It should not be constructed from "group by keys + accumulators types". Instead, it should just be the "accumulators" types because it is only used to produce intermediate accumulators. If we go with this fix, group by keys would not be in the picture at all and crash won't happen.

A short term fix would be to add a free-accumulator-only api to rowcontainer
@mbas

System information
n/a
Relevant logs
No response

cc @mbasmanova

@shiyu-bytedance Thank you for reporting this issue.

If we go with this fix, group by keys would not be in the picture at all and crash won't happen.

Would you be interested in working on this fix?

@mbasmanova sure, will do.


Enable spell checking

Actually, spellcheck seems to be running with 0.0.5, this seems redundant now and if someone else can confirm I'll close this.

Without this commit you can right-click to fix spelling, but with 6125907 it underlines them with red squigglies too.


Feature improvement

Feature Improve:

User Update Profile
Blog Cover Photo upload
Unit test improved feature

Reviewed. All ok.


Add card transactions into csv automatically

As of now, all card transactions are handled as type "None" and then get put into the other_events.json. You then have to manually convert that into a csv/excel file to properly import it somewhere else.
On download you can see it like this in the terminal:
e.g. 17:38:11 34/75: McDonald's -- None - 2024-07-11T11:48:44, which gets translated into json (shortened):
{
    "id": "xxx",
    "timestamp": "2024-06-13T07:35:11.715+0000",
    "title": "McDonald's",
    "icon": "logos/merchant-cf14fba1-08b0-422f-897b-6b334fd9dfcf/v2",
    "badge": null,
    "subtitle": null,
    "amount": {
      "currency": "EUR",
      "value": -3.99,
      "fractionDigits": 2
    },
    "subAmount": null,
    "status": "EXECUTED",
    "action": {
      "type": "timelineDetail",
      "payload": "xxx"
    },
    "eventType": "card_successful_transaction",
    "source": "timelineTransaction",
    "details": {
      "id": "xxx",
      "sections": [
        {
          "title": "Du hast 3,99 € ausgegeben",
          "data": {
            "icon": "logos/merchant-cf14fba1-08b0-422f-897b-6b334fd9dfcf/v2",
            "subtitleText": null,
            "timestamp": "2024-06-13T07:35:11.715+0000",
            "status": "executed"
          },
          "action": null,
          "type": "header"
        }

Could you implement some automatic conversion so that card transactions are placed in the account_transactions.csv or some other csv file? Technically only

currency
value
title (=notes?)
date/time
eventtype

are needed there I guess.

Adding as a byproduct in PR #100


How to close a stream using chat_engine.stream_chat

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
How to close a stream using chat_engine.stream_chat

I actually don't think there is a way besides either exhausting the stream, or never continuing the stream

Can the client connection of this chat_engine be actively disconnected, similar to httpclient.close()

Maybe? I think it really depends on the llm being used too. You'd have to do some digging into api docs there

Maybe we can add a close method to StreamingAgentChatResponse by leveraging generator.close(), for example:
class StreamingAgentChatResponse:
    ...

    def close(self) -> None:
        if self.chat_stream is not None:
            # Here we assume that self.chat_stream is a generator
            self.chat_stream.close()

Then  we also need to handle GeneratorExit in the relevant llm's stream_chat() method. Take OpenAI for example, we might update its _stream_chat() as below:
def _stream_chat(
    self, messages: Sequence[ChatMessage], **kwargs: Any
) -> ChatResponseGen:
    ...

    def gen() -> ChatResponseGen:
        ...

        stream = client.chat.completions.create(
            messages=message_dicts,
            stream=True,
            **self._get_model_kwargs(**kwargs),
        )
        for response in stream:
            try:
                ...

                yield ChatResponse(
                    message=ChatMessage(
                        role=role,
                        content=content,
                        additional_kwargs=additional_kwargs,
                    ),
                    delta=content_delta,
                    raw=response,
                    additional_kwargs=self._get_response_token_counts(response),
                )
            except GeneratorExit:
                # Interrupt the stream by closing the connection.
                # see https://github.com/openai/openai-python/issues/969#issuecomment-1857158754
                stream.response.close()

    return gen()

This would need to be implemented for every streaming llm 😅

But, makes sense

This would need to be implemented for every streaming llm 😅

Yes, both the sync and async versions need to be modified. Perhaps we can leverage some decorators, although they may not be helpful in all cases.

thanks


Moves privilege type matching from the parser to the analyzer

Privileges types are somehow arbitrary and shouldn't be defined inside the sql dialect.

Codecov Report

:exclamation: No coverage uploaded for pull request base (privileges@0bc9e96). Click here to learn what that means.
The diff coverage is 80.64%.

@@             Coverage Diff              @@
##             privileges   #5764   +/-   ##
============================================
  Coverage              ?   82.9%
  Complexity            ?   11985
============================================
  Files                 ?    1414
  Lines                 ?   46049
  Branches              ?    5713
============================================
  Hits                  ?   38179
  Misses                ?    5213
  Partials              ?    2657

Impacted Files
Coverage Δ
Complexity Δ

.../src/main/java/io/crate/sql/parser/AstBuilder.java
94.09% <100%> (ø)
241 <0> (?)

...arser/src/main/java/io/crate/sql/SqlFormatter.java
87.4% <100%> (ø)
7 <0> (?)

...c/main/java/io/crate/sql/tree/RevokePrivilege.java
72.72% <69.23%> (ø)
9 <3> (?)

...rc/main/java/io/crate/sql/tree/GrantPrivilege.java
72.72% <71.42%> (ø)
9 <3> (?)

...main/java/io/crate/analyze/PrivilegesAnalyzer.java
90.24% <80.95%> (ø)
13 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc9e96...b3c4ca5. Read the comment docs.


build only the master branch

this allows us to build both PR commits and master branch merges, without double-building each PR push.

👍


2: Thread perf - markdown

Some small changes to the markdown parser for links (which basically looks at every word)
Loading the thread storybook in production mode timing for initial render:
master:
943
677.62 (reload)
616 (reload again)
pr:
790
537 (reload)
489 (reload again)

@keybase/react-hackers

@keybase/react-hackers bump


Strict/more private guest mode

Describe the feature you'd like
My typical workflow for sharing notes with people over internet is that I use random stuff with random groups of people and am not interested that everyone sees everything. These are typically scripts for trainings or general info, not collaboration, so read-only for my guests.
It'd be great to have more strict guest access with following conditions:

login page shows only "Login" button, no search, no history of changes
guest can access direct link, which doesn't display any details pane nor books/pages with search removed and only option to login

Describe the benefits this feature would bring to BookStack users
One could share random stuff with random people without others knowing about other content.
Additional context
I'm trying to find alternative to hackmd which can share articles this way.

Hi @mahdi1234,
Thanks for your suggestion here.
I probably wouldn't look to include additional more "strict" guest permission options which alter the UI, as there's not a large amount of demand for them and that kind of addition has an impact on maintenance. You can already get fairly specific with the current permission options, by creating a role with no permissions then providing view access on particular items, although this is only available at a role-level, not a per-user level.
Sharing via a direct, unique link is a feature that would add value and be much more possible. This is already open in issue #288.
I'll therefore close this off.


Docs: Remove outdated CI section

Resolves https://github.com/robotframework/robotframework/issues/2623.
https://github.com/robotframework/robotframework/pull/2676#issuecomment-328784771 says this section is outdated. Let's remove it, it's just confusing to contributors.

@pekkaklarck Any thoughts on this PR?

I had hoped we'd have some new information about CI that could have been added here. No such info yet, so better to just remove the outdated and confusing info.


added bower support

This way you can register this package with the bower registry and people can download and use Console.js right after a simple bower install Console.js.

Sorry about the travis error, seems like opensauce is having issues?
But your changeset look's good, thanks.


README: Add pypi version badge

Description
This small badge makes it easy for people to see what the most recent version of luigi is.

@mention-bot disable

@adamchainz sorry to spam! If you happen to know any mention-bot software that's more interactive (where it suggests and the author later approves), please let me know. :)

[Current coverage][cc-pull] is 76.11%

Merging [#1757][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.69%

@@             master      #1757   diff @@
==========================================
  Files            95         95
  Lines         10348      10348
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           8155       7876   -279
- Misses         2193       2472   +279
  Partials          0          0

Powered by Codecov. Last updated by [c29e48f...6d8d7d1][cc-compare]
[cc-base-branch]: https://codecov.io/gh/spotify/luigi/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/spotify/luigi/compare/c29e48fad73dfc93c4d7aac7a708d216aaa08573...6d8d7d12f836f0d18b3ab5a94c5587d922118066?src=pr
[cc-pull]: https://codecov.io/gh/spotify/luigi/pull/1757?src=pr


Routing doesn't work

Hello,
I can't seem to make routing work. Here's the htaccess file, which does redirect every request to index.php. However, in index.php, it doesn't respond to GET request.
.htaccess:
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule . index.php [L]

index.php:
<?php
require_once __DIR__ . '/vendor/autoload.php';

$klein = new \Klein\Klein();

$klein->respond('GET', '/hello-world', function () {
    return 'Hello World!';
});

$klein->dispatch();

If I change it to
$klein->respond(function () {
    return 'Hello World!';
});

It will work, and show this on every link (that doesn't already exist).
I also found this link on stackoverflow with the same problem (from a few years ago), but with no solution specified:
http://stackoverflow.com/questions/20269954/klein-routes-dont-return-anything
Any ideas?

the index file in in the root of the project?

yes

Thats strange, i was having the same issue but it was because i was testing it in on a subfolder called api, so for every url string i just added /api on the started it worked
i'm using this .htaccess config
Options +FollowSymLinks
RewriteEngine On
RewriteRule ^(.*)$ index.php [NC,L]


vagrant: switch to using a wily image

Apparently ubuntu/vivid64 doesn't exist in some cases. Should switch to using a wily image.
https://github.com/coreos/rkt/issues/2243

$ vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Box 'ubuntu/vivid64' could not be found. Attempting to find and install...
default: Box Provider: virtualbox
default: Box Version: >= 0
The box 'ubuntu/vivid64' could not be found or
could not be accessed in the remote catalog. If this is a private
box on HashiCorp's Atlas, please verify you're logged in via
vagrant login. Also, please double-check the name. The expanded
URL and error message are shown below:
URL: ["https://atlas.hashicorp.com/ubuntu/vivid64"]
Error: The requested URL returned error: 404 Not Found


HA Integration problems

When i try to install the Bestway Smart Home App with the custom repository in HA and i check the EU square i get "user does not exists".
when i tryed to switch to the US square the integration did install.
Can it be so nice and perfect so after brexit the englishmen did also get kicked out from the Bestway App lol

Struggling to pick out any issues with the integration from this - please add more detail and reopen if I'm missing something.


[feature request] Dark theme

This tool is fantastic, but some folks out there, including me, might enjoy a dark theme.

Would it be possible to add it?

Interesting. I'll think about it.


[FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

What is the purpose of the change
Implement the SortBufferAccumulator for the tiered storage
Brief change log

Implement the SortBufferAccumulator for the tiered storage

Verifying this change
This change will add tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

@xintongsong Thanks for helping review, I addressed the comments with a fixup commit.

@flinkbot run azure

@xintongsong @reswqa Thanks for the careful review.


typos in week 1 blog

Good blog. There are a few typos in the "Open Sourcing" section: 1st paragraph: "indiviual" -> individual, 2nd paragraph: "programmars" -> programmers, "struture" -> structure. In the Jupyter Notebook section, "Jupter" -> Jupyter :)

Sorry about the late reply. Thanks for noting these topos! I will fix them in my next update.


Is there any proper way to use query builder (such as dbr) in Job?

@bgentry Hi, this is really nice work!
Is there any proper manner to use other query builders in Job? When it comes to dynamically changing condition, query builder is really useful, and it would be nice if you can point me where to look at.
I'm currently using dbr for query builder, and thinking to wrap pgx.Tx in dbr.TX.

@achiku it looks like dbr wouldn't be compatible because in addition to building queries, it's also taking over the process of making connections to the database using database/sql under the hood.


Support google_product_category field

For each category, we should be able to define the google_product_category value, that will be used in the Google product feed. We could start with the simple optional CharField, where users will type the proper value. If it's worth the effort, we could also provide a selectable input with all the possible types fetched from Google, but that would require some synchronization and writing the list to a file locally.
https://support.google.com/merchants/answer/6324436

This is probably still valid issue, but I don't know if we should implement it as a model field or a plugin. If it was a plugin it could use meta fields to store Google categories, but I don't know how would be implement the dashboard UI for that then.


Upgrade to Redwood v0.36.2

What type of PR is this? (check all applicable)

[x] ♻ Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[x] 👷 Optimization
[ ] 📝 Documentation Update
[ ] 🔖 Release
[ ] 🚩 Other

Description
This PR updates the project from Redwood v0.24.0 to v0.36.2. Over the course of these releases we saw the following changes to the framework:

Prisma Migrate went through a complete overhaul before being released to General Availability and the old database commands have been deprecated.
Prerendering was added for non-dynamic content.
API Logging is now built in by default.
Secure Services can be enabled to make the API zero trust by default instead of open by default.
TypeScript is now a thing.
Self hosted authentication is included for storing credentials and logging in users.
Apollo Server has begun the process of being officially deprecated in favor of GraphQL Helix and Envelop.

Related Tickets & Documents
Connection pooling with Supabase
In a serverless environment you need to set up connection pooling with a tool like PgBouncer because every function invocation may result in a new connection to the database. Supabase projects now support connection management using PgBouncer and are enabled by default. However, when running migrations you need to use the non pooled connection URL.
postgres://postgres:[YOUR-PASSWORD]@db.vdbnhqozmlzdsaejdxwr.supabase.co:5432/postgres

When deploying your app, you'll use the pooled connection URL and add the ?pgbouncer=true flag to the PostgreSQL connection URL.
postgres://postgres:[YOUR-PASSWORD]@db.vdbnhqozmlzdsaejdxwr.supabase.co:6543/postgres?pgbouncer=true

This is a problem for Prisma, as explained by Mahmoud Abdelwahab:

Prisma Migrate uses database transactions to check out the current state of the database and the migrations table. However, the Migration Engine is designed to use a single connection to the database, and does not support connection pooling with PgBouncer. If you attempt to run Prisma Migrate commands in any environment that uses PgBouncer for connection pooling, you might see the following error:

Error: undefined: Database error
Error querying the database: db error: ERROR: prepared statement "s0" already exists

There is an open issue for this on Prisma's GitHub and another issue explaining the problem in more detail.
Mobile & Desktop Screenshots/Recordings
Since PgBouncer was causing issues I tried disabling the Supabase client and connecting the project to a PostgreSQL database on Railway.

Added tests?
I am the one who tests.

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?
These are all internal implementation details and from the perspective of an Open Sauced user there should be no change in the behavior of the application.

[ ] 📜 readme
[ ] 📜 contributing.md
[ ] 📓 docs
[ ] 📕 storybook
[x] 🙅 no documentation needed

Are there any post-deployment tasks we need to perform?
Make sure you can connect to Supabase without any weird PgBouncer issues. See previous links for context and workarounds.
What gif best describes this PR or how it makes you feel?

Instructions for setting up and testing a Supabase database
Create .env file
touch .env

You'll need the following variables
DATABASE_URL=
SUPABASE_URL=
SUPABASE_KEY=
SUPABASE_JWT_SECRET=

If you check the API tab under settings you'll see:

Project API keys which is SUPABASE_KEY
URL which is SUPABASE_URL
JWT Secret which is SUPABASE_JWT_SECRET

The following screenshots are from a project that has been deleted and all keys are invalid

You can find a connection string under the Connection Pooling tab, and this is where I hit an error.

If you take the connection string provided you need to append ?sslmode=require&pgbouncer=true like so:
postgresql://postgres:mydb.supabase.co:6543/postgres?sslmode=require&pgbouncer=true

But that leads to the Prisma Migration errors I mentioned when I originally opened the PR. According to the Redwood docs currently being written about this, we want something like:
postgresql://postgres:mydb.supabase.co:5432/postgres?sslmode=require

Once all the variables are provided you will run the following Prisma Migrate command:
yarn rw prisma migrate dev --name i-want-pizza

Checked out on the stream. I think this is good, barring the weird dashboard error.

Netlify build error
9:43:31 AM: ────────────────────────────────────────────────────────────────
9:43:31 AM:   1. build.command from netlify.toml
9:43:31 AM: ────────────────────────────────────────────────────────────────
9:43:31 AM:
9:43:31 AM: $ yarn rw deploy netlify
9:43:31 AM: yarn run v1.22.4
9:43:31 AM: $ /opt/build/repo/node_modules/.bin/rw deploy netlify
9:43:32 AM: internal/modules/cjs/loader.js:892
9:43:32 AM:   throw err;
9:43:32 AM:   ^
9:43:32 AM: Error: Cannot find module '@ardatan/aggregate-error'
9:43:32 AM: Require stack:
9:43:32 AM: - /opt/build/repo/node_modules/<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: - /opt/build/repo/node_modules/graphql-config/index.js
9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM: -<EMAIL_ADDRESS>9:43:32 AM:     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:889:15)
9:43:32 AM:     at Function.Module._load (internal/modules/cjs/loader.js:745:27)
9:43:32 AM:     at Module.require (internal/modules/cjs/loader.js:961:19)
9:43:32 AM:     at require (internal/modules/cjs/helpers.js:92:18)
9:43:32 AM:     at Object.<anonymous> (/opt/build/repo/node_modules/@graphql-tools/schema/node_modules/@graphql-tools/utils/index.cjs.js:8:40)
9:43:32 AM:     at Module._compile (internal/modules/cjs/loader.js:1072:14)
9:43:32 AM:     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
9:43:32 AM:     at Module.load (internal/modules/cjs/loader.js:937:32)
9:43:32 AM:     at Function.Module._load (internal/modules/cjs/loader.js:778:12)
9:43:32 AM:     at Module.require (internal/modules/cjs/loader.js:961:19) {
9:43:32 AM:   code: 'MODULE_NOT_FOUND',
9:43:32 AM:   requireStack: [
9:43:32 AM:     '/opt/build/repo/node_modules/<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM:     '/opt/build/repo/node_modules/graphql-config/index.js',
9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM<EMAIL_ADDRESS>9:43:32 AM:   ]
9:43:32 AM: }
9:43:32 AM: error Command failed with exit code 1.
9:43:32 AM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
9:43:32 AM:
9:43:32 AM: ────────────────────────────────────────────────────────────────
9:43:32 AM:   "build.command" failed
9:43:32 AM: ────────────────────────────────────────────────────────────────
9:43:32 AM:
9:43:32 AM:   Error message
9:43:32 AM:   Command failed with exit code 1: yarn rw deploy netlify
9:43:32 AM:
9:43:32 AM:   Error location
9:43:32 AM:   In build.command from netlify.toml:
9:43:32 AM:   yarn rw deploy netlify
9:43:32 AM:
9:43:32 AM:   Resolved config
9:43:32 AM:   build:
9:43:32 AM:     command: yarn rw deploy netlify
9:43:32 AM:     commandOrigin: config
9:43:32 AM:     environment:
9:43:32 AM:       - DATABASE_URL
9:43:32 AM:       - REVIEW_ID
9:43:32 AM:       - SUPABASE_JWT_SECRET
9:43:32 AM:       - SUPABASE_KEY
9:43:32 AM:       - SUPABASE_URL
9:43:32 AM:     publish: /opt/build/repo/web/dist
9:43:32 AM:     publishOrigin: config
9:43:32 AM:   functionsDirectory: /opt/build/repo/api/dist/functions
9:43:32 AM:   redirects:
9:43:33 AM:     - from: /*
      status: 200
      to: /index.html
  redirectsOrigin: config
Caching artifacts

12:54:51 PM: $ /opt/build/repo/node_modules/.bin/rw prisma migrate deploy
12:54:54 PM: Running Prisma CLI...
12:54:54 PM: $ yarn prisma migrate deploy --schema "/opt/build/repo/api/db/schema.prisma"
12:54:55 PM: Prisma schema loaded from api/db/schema.prisma
12:54:55 PM: Datasource "DS": PostgreSQL database "postgres", schema "public" at "db.yndwjtnickdixvlpvjnn.supabase.co:5432"
12:54:55 PM: Error: P1000: Authentication failed against database server at `db.yndwjtnickdixvlpvjnn.supabase.co`, the provided database credentials for `postgres` are not valid.
12:54:55 PM: Please make sure to provide valid database credentials for the database server at `db.yndwjtnickdixvlpvjnn.supabase.co`.
12:54:56 PM: error Command failed with exit code 1.
12:54:56 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
12:54:56 PM: rw deploy netlify [...commands]
12:54:56 PM: Build command for Netlify deploy
12:54:56 PM: Options:
12:54:56 PM:   --help                Show help                                      [boolean]
12:54:56 PM:   --version             Show version number                            [boolean]
12:54:56 PM:   --cwd                 Working directory to use (where `redwood.toml` is
12:54:56 PM:                         located.)
12:54:56 PM:   --build               Build for production         [boolean] [default: "true"]
12:54:56 PM:   --prisma              Apply database migrations    [boolean] [default: "true"]
12:54:56 PM:   --data-migrate, --dm  Migrate the data in your database
12:54:56 PM:                                                      [boolean] [default: "true"]
12:54:56 PM: For more commands, options, and examples, see Redwood CLI Reference
12:54:56 PM: (https://redwoodjs.com/docs/cli-commands#deploy)
12:54:56 PM: Error: Command failed with exit code 1: yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up
12:54:56 PM:     at makeError (/opt/build/repo/node_modules/execa/lib/error.js:60:11)
12:54:56 PM:     at handlePromise (/opt/build/repo/node_modules/execa/index.js:118:26)
12:54:56 PM:     at processTicksAndRejections (internal/process/task_queues.js:95:5) {
12:54:56 PM:   shortMessage: 'Command failed with exit code 1: yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up',
12:54:56 PM:   command: 'yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up',
12:54:56 PM:   escapedCommand: '"yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up"',
12:54:56 PM:   exitCode: 1,
12:54:56 PM:   signal: undefined,
12:54:56 PM:   signalDescription: undefined,
12:54:56 PM:   stdout: undefined,
12:54:56 PM:   stderr: undefined,
12:54:56 PM:   failed: true,
12:54:56 PM:   timedOut: false,
12:54:56 PM:   isCanceled: false,
12:54:56 PM:   killed: false
12:54:56 PM: }
12:54:56 PM: error Command failed with exit code 1.
12:54:56 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
12:54:56 PM:
12:54:56 PM: ────────────────────────────────────────────────────────────────
12:54:56 PM:   "build.command" failed
12:54:56 PM: ────────────────────────────────────────────────────────────────
12:54:56 PM:
12:54:56 PM:   Error message
12:54:56 PM:   Command failed with exit code 1: yarn rw deploy netlify
12:54:56 PM:
12:54:56 PM:   Error location
12:54:56 PM:   In build.command from netlify.toml:
12:54:56 PM:   yarn rw deploy netlify
12:54:56 PM:
12:54:56 PM:   Resolved config
12:54:56 PM:   build:
12:54:56 PM:     command: yarn rw deploy netlify
12:54:56 PM:     commandOrigin: config
12:54:56 PM:     environment:
12:54:56 PM:       - DATABASE_URL
12:54:56 PM:       - REVIEW_ID
12:54:56 PM:       - SUPABASE_JWT_SECRET
12:54:56 PM:       - SUPABASE_KEY
12:54:56 PM:       - SUPABASE_URL
12:54:56 PM:     publish: /opt/build/repo/web/dist
12:54:56 PM:     publishOrigin: config
12:54:56 PM:   functionsDirectory: /opt/build/repo/api/dist/functions
12:54:56 PM:   redirects:
12:54:56 PM:     - from: /*
      status: 200
      to: /index.html
  redirectsOrigin: config

Supabase error this time, will want to check environment variables.

12:54:51 PM: $ /opt/build/repo/node_modules/.bin/rw prisma migrate deploy
12:54:54 PM: Running Prisma CLI...
12:54:54 PM: $ yarn prisma migrate deploy --schema "/opt/build/repo/api/db/schema.prisma"
12:54:55 PM: Prisma schema loaded from api/db/schema.prisma
12:54:55 PM: Datasource "DS": PostgreSQL database "postgres", schema "public" at "db.yndwjtnickdixvlpvjnn.supabase.co:5432"
12:54:55 PM: Error: P1000: Authentication failed against database server at `db.yndwjtnickdixvlpvjnn.supabase.co`, the provided database credentials for `postgres` are not valid.
12:54:55 PM: Please make sure to provide valid database credentials for the database server at `db.yndwjtnickdixvlpvjnn.supabase.co`.
12:54:56 PM: error Command failed with exit code 1.
12:54:56 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
12:54:56 PM: rw deploy netlify [...commands]
12:54:56 PM: Build command for Netlify deploy
12:54:56 PM: Options:
12:54:56 PM:   --help                Show help                                      [boolean]
12:54:56 PM:   --version             Show version number                            [boolean]
12:54:56 PM:   --cwd                 Working directory to use (where `redwood.toml` is
12:54:56 PM:                         located.)
12:54:56 PM:   --build               Build for production         [boolean] [default: "true"]
12:54:56 PM:   --prisma              Apply database migrations    [boolean] [default: "true"]
12:54:56 PM:   --data-migrate, --dm  Migrate the data in your database
12:54:56 PM:                                                      [boolean] [default: "true"]
12:54:56 PM: For more commands, options, and examples, see Redwood CLI Reference
12:54:56 PM: (https://redwoodjs.com/docs/cli-commands#deploy)
12:54:56 PM: Error: Command failed with exit code 1: yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up
12:54:56 PM:     at makeError (/opt/build/repo/node_modules/execa/lib/error.js:60:11)
12:54:56 PM:     at handlePromise (/opt/build/repo/node_modules/execa/index.js:118:26)
12:54:56 PM:     at processTicksAndRejections (internal/process/task_queues.js:95:5) {
12:54:56 PM:   shortMessage: 'Command failed with exit code 1: yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up',
12:54:56 PM:   command: 'yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up',
12:54:56 PM:   escapedCommand: '"yarn rw build --verbose && yarn rw prisma migrate deploy && yarn rw data-migrate up"',
12:54:56 PM:   exitCode: 1,
12:54:56 PM:   signal: undefined,
12:54:56 PM:   signalDescription: undefined,
12:54:56 PM:   stdout: undefined,
12:54:56 PM:   stderr: undefined,
12:54:56 PM:   failed: true,
12:54:56 PM:   timedOut: false,
12:54:56 PM:   isCanceled: false,
12:54:56 PM:   killed: false
12:54:56 PM: }
12:54:56 PM: error Command failed with exit code 1.
12:54:56 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
12:54:56 PM:
12:54:56 PM: ────────────────────────────────────────────────────────────────
12:54:56 PM:   "build.command" failed
12:54:56 PM: ────────────────────────────────────────────────────────────────
12:54:56 PM:
12:54:56 PM:   Error message
12:54:56 PM:   Command failed with exit code 1: yarn rw deploy netlify
12:54:56 PM:
12:54:56 PM:   Error location
12:54:56 PM:   In build.command from netlify.toml:
12:54:56 PM:   yarn rw deploy netlify
12:54:56 PM:
12:54:56 PM:   Resolved config
12:54:56 PM:   build:
12:54:56 PM:     command: yarn rw deploy netlify
12:54:56 PM:     commandOrigin: config
12:54:56 PM:     environment:
12:54:56 PM:       - DATABASE_URL
12:54:56 PM:       - REVIEW_ID
12:54:56 PM:       - SUPABASE_JWT_SECRET
12:54:56 PM:       - SUPABASE_KEY
12:54:56 PM:       - SUPABASE_URL
12:54:56 PM:     publish: /opt/build/repo/web/dist
12:54:56 PM:     publishOrigin: config
12:54:56 PM:   functionsDirectory: /opt/build/repo/api/dist/functions
12:54:56 PM:   redirects:
12:54:56 PM:     - from: /*
      status: 200
      to: /index.html
  redirectsOrigin: config

Supabase error this time, will want to check environment variables.

Had another Redwood dev reach out about this bug cause they were running into it as well. Said they figured it out in the netlify.toml:
command = "DATABASE_URL=$MIGRATE_DB_URL yarn rw deploy netlify"

$MIGRATE_DB_URL is an environment variable on netlify MIGRATE_DB_URL.

Gonna close this issue out. Redwood's up to v0.47 and it sounds like we're gonna be rethinking what we want to do with Redwood anyway. At this point it would make the most sense to create a new Redwood app in a month or two that's using v1 or if we want to start building before then we can pin to v1-rc.


Read MCS file from SAPHIRE

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Update the current MCS reader to process SAPHIRE MCS output file and close #39
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Regression tests have to complete successfully.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test.
[ ] 6. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.

Does the manual need to be updated after this changes?

Does the manual need to be updated after these changes?
We are currently just doing the unit testing here. I think it is not necessary to update the manual now. If you are fine with this PR, I will update MCSSolver and MCSImporter to have the optional input from the user to select the type of MCS file. In that case, we need to add additional tests and update the manual.

@mandd This PR is ready for your second review.


Next attempt at creating a binary tree interface.

This PR only outlines the interface in the binary_tree and blanked_tree modules. It requires quite a bit of refactoring, in various parts of the implementation. In particular, it requires that nodes are represented as Option<Node>, which requires a bit of refactoring.

Thanks for the load of great feedback! I see there's a lot to iron out. I'll put it back to draft mode until I've made some improvements.

Thanks for the load of great feedback! I see there's a lot to iron out. I'll put it back to draft mode until I've made some improvements.

As agreed out-of-band, I'm closing this until we've found a good solution for a BinaryTree interface.

As agreed out-of-band, I'm closing this until we've found a good solution for a BinaryTree interface.


Add Show location history sample

Context
This PR implements a sample to Show location history.

Not Tracking
Tracking

Info
Code

Thank you for your work on this sample. I've reviewed it and have left some feedback with some suggestions and some requested changes. Please let me know if you have any questions.

You bet! Thank you for the detailed review. I have taken all of your feedback to heart, and addressed each issue with additional commits.

One other thing. We usually scale down the screenshot, otherwise it takes up a lot of space in the README. They can also be rather large in file size, depending on what the sample is showing. I usually scale them down to a third the original size (828x1792 -> 276x597) and export it without the alpha channel in Preview. Could you please do that for the screenshot in this sample?

I initially updated this in b870661, but updated it again in 95239bd.

@philium I have pushed additional commits that address your feedback. Would you mind taking another look?

The screenshot looks great, by the way.

@philium Thanks for the additional input. I have addressed each your requests by pushing 5 additional commits. This is ready for an additional editing pass when you have a moment.

👍


feat(SWA-304): postal code for submission

This PR adds a postal code field for the submission model.
JIRA - https://artsyproduct.atlassian.net/browse/SWA-304

Also added the country code field to have a more correct way of validating/showing the postal code field instead of working with the country name.


Sync request

Is there a way to implement Synchronous request? I really need it.

Unfortunately currently we don't have this option, yet. But would be great to add it actually, I'll also need this feature. We'll do some major changes very soon and we will also add this feature.

So much thank you, Many users will be appreciate this feature, great library! Mock Rules!!

I'm happy to hear this, thanks!
I've added sync option with v1.12, will be available in 1 hour probably in maven


Tweak the setting hint for the custom editor theme setting

The custom editor theme is only visible after restarting the editor.
See https://github.com/godotengine/godot/issues/48477.

Cherry-picked for 3.4.

Cherry-picked for 3.3.1.


Update Messages.ts

BCC and CC should be string arrays

Hi @eyaleizenberg
Thank you for your input.
There are a few minor issues, please fix them and then I will merge the PR.

@olexandr-mazepa Thanks, PR updated.


doc: Introduce Rancher2 Terraform Integration Test Doc

provides baseline integration test documentation of manual test for rancher2 terraform provider w/ Rancher v2.7.X, Harvester, and the terraform provider plugin rancher2

Resolves: doc/terraform-rancher2-integration-manual-testing
Tested Locally:

@khushboo-rancher  sounds good :smile:  :+1:
I have removed them from _incoming, provided them their own section (so we can expand on in the future), and updated the pr - validating locally x-ref screengrabs:

Thanks @irishgordo,
Just one doubt why the file name is 1009_terraform_rancher2_provider_testing.md?

Updated :smile:


Inconsistent API Behavior

What is the issue?
I'm calling the generate API as follows:
url = 'http://localhost:11434/api/generate'
data = {
  "model": model_name,
  "stream": False,
  "options": {
      "temperature": 0.2,
      "top_p": 0.8,
      "seed": 42,
      "num_predict": 300,
  },
  "system": set_role()
}

response = requests.post(url, json=data).json()

Although I set the stream flag to false, sometimes I don't get the whole response in one package (done = False in the first received package).
The other problem is that sometimes, even when the package is final (done=true), I don't see all the expected additional information there, for example, prompt_eval_count is missing.
This problem also persists with the Python library. I’ve carefully checked the documentation, and I believe it might be some sort of bug.
OS
Linux
GPU
Nvidia
CPU
Intel
Ollama version
0.3.5

What is the system field supposed to be?  What model are you seeing issues with?


compile problem

When I try to compile kade engine I get this warning: "Program Files (x86)/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 10-23 : Warning : This typedef is deprecated in favor of haxe.xml.Access
Program Files (x86)/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 30-43 : Warning : This typedef is deprecated in favor of haxe.xml.Access" and the compile stops, I'm on version 1.7 and this warning only started happening today.

do you have the ASIPStuff.Hx in the source folder

Kade engine already comes with it, also, make sure theres anything over Program Files (x86)/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 10-23 : Warning : This typedef is deprecated in favor of haxe.xml.Access Program Files (x86)/haxe/lib/polymod/git/polymod/format/XMLMerge.hx:189: characters 30-43 : Warning : This typedef is deprecated in favor of haxe.xml.Access

those aren't errors


add Openshift provider: Credential validation was not successful: 503 "Service Unavailable"

Hi
I have an appliance in VMware based on jansa-2 version of MIQ. I try to add an Openshift provider.
The web UI result is "Credential validation was not successful: 503 "Service Unavailable"
Into the log, no clue about what is not ok
[----] W, [2020-11-19T05:49:24.140689 #2501:2ae08dea737c]  WARN -- : MIQ(ManageIQ::Providers::Openshift::ContainerManager#authentication_check_no_validation) type: [:bearer] for [] [api.ocp4exp.testing.local] Validation failed: error, 503 "Service Unavailable"

On the appliance I can validate that the DNS is ok (nslookup) and I can successfully reach the target port (telnet)
Everything is working fine in the all included MIQ docker container or even in an Openshift based deployment.
This issue is only appearing with the VMware based appliance.
Any thoughts?

That's interesting @Sispheor, there really shouldn't be a different between monolithic docker, podified, and the appliance when it comes to provider authentication.
Is everything the same on the three environments that you've tried?  Same MIQ version, same openshift cluster, same network, etc...?

Yes, all test have been placed on the same network. With jansa-2.
What si the module used to resolve DNS?
Do you know if /etc/hosts is considered by the module?
It looks like a DSN issue.

Yes /etc/hosts is picked up by ruby's Net::HTTP  If it were DNS I'd expect a SocketError (getaddrinfo: Name or service not known)
503 sounds like it hit a webserver successfully but there was an error on that side (possibly based on incorrect parameters supplied by MIQ, possibly an issue on the server side)

I tested that everything was ok by connecting from the appliance with oc command. All good.

I fixed it by doing a reset of the database with the appliance_console.
It works now with the same configuration.


bootutil: nrf_cc310: Bugfix for CC310 and shared crypto APIs

Fix some dependencies issues with the Kconfig for shared crypto and add
a check in the sha256 API to allow for NRF_EXTERNAL_CRYPTO. Set
NRF_CRYPTOCELL to NRF_CRYPTOCELL_S since MCUBoot is typically
running in secure-zone.
Fixes NCSDK-3413
Signed-off-by: Sigvart Hovland<EMAIL_ADDRESS>

It doesn't make sense to use cc310 form non-secure domain, right?

Depends, for MCUBoot I don't think so. For a zephyr application, it would make sense to configure and access CC310 as non-secure as you could be running some crypto intensive protocol in non-secure like TLS, etc.

I get verification failure when testing with hello world and B0 enabled. Are you getting successful bootups?

Got successful boot ups with this patch and https://github.com/NordicPlayground/fw-nrfconnect-nrf/pull/1351 but I can re-check

So why usage NRF_CRYPTOCELL versus NRF_CRYPTOCELL_S is not optional?

Seems it's only mapped to secure as you said https://infocenter.nordicsemi.com/topic/ps_nrf9160/cryptocell.html?cp=2_0_0_5_0_6#topic

Guys, this label will not work in this repo as there is no v1.1-branch. You should use backport v1.4.99-ncs1-branch

Fixed?

merge?

backported manually here: https://github.com/NordicPlayground/fw-nrfconnect-mcuboot/pull/67


Native window title bar is visible for full screen top most apps.

I have a case where app needs to be full screen, just like a video game, without min, max and close buttons, no resizing, no chrome. Following styles are applied:
<Setter Property="WindowState" Value="FullScreen"/>
<Setter Property="CanResize" Value="False"/>
<Setter Property="ExtendClientAreaToDecorationsHint" Value="True"/>
<Setter Property="ExtendClientAreaChromeHints" Value="NoChrome"/>
<Setter Property="ExtendClientAreaTitleBarHeightHint" Value="-1"/>

This gives me the results that I want. However:
If I click outside of my window, for example if I have two monitors or if I press a "Win" key on Windows machine, my app gets what looks like a "default" chrome, very ugly, something that looks like Win7 era at best:

Is there a way to preserve no title bar functionality even if window is not active, disabled etc...
This can be reproduced with Avalonia starting from x.x.13 to the latest version.

@sekulicb I can't reproduce it with latest master. It might have been fixed there.
Can you check with latest avalonia nightly builds? Like "0.10.999-cibuild0021430-beta".

Hi @maxkatz6 It works without any third party libraries, so I can confirm its not Avalonia problem. The moment I add LibVLCSharp.Avalonia problem comes back. So it must be their library not respecting the settings for window chrome?

@sekulicb it is possible, if LibVLC changes any window parameters. But unfortunately, I don't know internals of their library, so I can't say for sure.

Maybe @mfkl can help here, if VLC control changes any window parameters.

Oh, I see you already have created issue on their repository.
I will link it here https://code.videolan.org/videolan/LibVLCSharp/-/issues/568


Allow to specify signal when calling clone.

This is my suggestion on how to fix #343.

I don't have a strong opinion on this one.  Allowing for the signal to be included does seem important and I don't see any obvious problems with this approach.  @kamalmarhubi

Interesting. I'd have to read the entire man page to figure out if there are any other similar issues so we don't end up changing the signature repeatedly.

I just opened a PR with an alternative approach at #348.

:umbrella: The latest upstream changes (presumably #353) made this pull request unmergeable. Please resolve the merge conflicts.

Given discussion on #348 and #343, I think this is the most acceptable approach. If / when we add an enum for signals, we can adjust the type of the argument.
@homu r+ b06432b

:zap: Test exempted - status


Delete css-framework package

Related issue
Closes #3110
Overview
Delete css-framework.
Reason
No longer required as it is superseded by styled-components work.
Work carried out

[x] Delete

A separate ticket has been created for CSS Framework related content.


Input shape changed after converting model to tflite

1.  My topic

Image Classification to detect 7 different  weather conditions deploy on Raspberry Pi4

2. Train model .h5 on ggcolab

I'm using ResNet50 (deep learning) and 1 fully connected layer with Softmax function
Input: (244, 244, 3) image
Output: one-hot encoding 7 classes (Ex: [0 0 1 0 0 0 0 0] => Rainy)
epoch = 20 and accuracy is 90% (code below)
Then I convert model .h5 to .tflite in order to run on RaspberryPi4

3. Problem

input_details[0]['shape'] gave me input shape: " [1, 1, 1, 3] " which is wrong (correct one is [1, 244, 244, 3] )
output_details[0]['shape'] gave me output shape:  " [1, 7] " which is correct
=> model.tflite run wrong

How can I fix this bug? ( change input shape of model .tflite to exact input shape )
Link my code on github: https://github.com/VanBap/Adverse_Weather
Including:

File train model h5: Adverse_weather_detection_model.ipynb
File convert model from .h5 -> .tflite: convert.py
File run test model .tflite: run_tflite_model.py

Thank you so much!

anyone? :(

Hey friend, please wait, I believe good things will come to you.

Hi VanBap, can you upload your .h5 and .tflite file? That will help me test this faster.

Hi VanBap, can you upload your .h5 and .tflite file? That will help me test this faster.
Here they are ( model .h5 and model .tflite)
By the way when I try to run model .tflite, I just put a new line code:
" # Resize Tensor Shape
interpreter.resize_tensor_input(input_details[0]['index'], (1, 224, 224, 3)) "
then it finally ran but I dont really know (how) does it affect the way my model .tflite processing ?!

Hi VanBap, can you upload your .h5 and .tflite file? That will help me test this faster.

I cant upload model files here because they are >25MB even though I zipped those.
But they are on my Github:

model .tflite: https://github.com/VanBap/Adverse_Weather/tree/master/saved_model
training model .h5: https://github.com/VanBap/Adverse_Weather/blob/master/Detection_model_usingResNet50.ipynb
By the way when I try to run model .tflite, I just put a new line code:
" # Resize Tensor Shape
interpreter.resize_tensor_input(input_details[0]['index'], (1, 224, 224, 3)) "
then it finally ran but I dont really know (how) does it affect the way my model .tflite processing ?!

Hi @VanBap, in your notebook you do not specify a specific input_shape in the API: https://keras.io/api/applications/resnet/#resnet50-function, Resizing the converted input shape is actually expected: https://www.tensorflow.org/lite/guide/inference#run_inference_with_dynamic_shape_model, so given your parameters, I believe resizing is the correct action. Does that answer your concerns? Thanks.

Hi @VanBap, in your notebook you do not specify a specific input_shape in the API: https://keras.io/api/applications/resnet/#resnet50-function, Resizing the converted input shape is actually expected: https://www.tensorflow.org/lite/guide/inference#run_inference_with_dynamic_shape_model, so given your parameters, I believe resizing is the correct action. Does that answer your concerns? Thanks.

I really appreciate your help! I am trying your answer and will feed back when its done

Hi @VanBap, no worries, if you have no more open items, please feel free to close as completed. Thanks.


Incoming call doesn't connect properly

Description
Hello, Twilio team. I use CallKit in my app. When I make a call to my app, the call arrives properly, but when I answer that call( CallKit's provider:performAnswerCallAction), the call doesn't connect(TVOCallDelegate's callDidConnect method doesn't get called). And after nearly 30 seconds the call disconnect because of TimeOut error. It happens not always, nearly 40-50%
Steps to Reproduce

Alice calls Bob
Bob tap Answer button
Call's status still connecting

Reproduces How Often
40-50%
Logs
When doesn't connect:  twilio-income-call-no-connect-log.txt
When connects properly:  twilio-income-call-connect-log.txt
Versions
Voice iOS SDK
[e.g. 2.0.0-beta16 via CocoaPods]
Xcode
[e.g. 8.3.1]
iOS Version
[e.g. 10.3.3]
iOS Device
[e.g. iPhone 6]

Hi @talalt
I am sorry that you are experiencing failure connecting the call. The time out (408) error in the log indicates the Twilio server could not produce a response within a suitable amount of time. In this case, the call:didFailWithError: callback method should be called so that the application can handle the UI transition for the best call experience.
-bobie

Hi @bchen-twilio
But I want to know, why my call doesn't connect? I use CallKit, so I run
guard let call = self.callInvite?.accept(with: incomingCallController!) else {             action.fail()             return         }
inside of provider(_ provider: CXProvider, perform action: CXAnswerCallAction) function.

Hi @talalt
Assuming no error or time-out happening, the SDK should be able to connect the incoming call and notify the application delegate via the callDidConnect: callback method, otherwise the call:didFailWithError: callback should be raised to make sure the application receives the state termination.
Could you help us check if you are getting correct TVOCallDelegate callbacks?
Thanks.
bobie

Hi @bchen-twilio
Yes, I get TVOCallDelegate callbacks, and when I try to accept callInvite, if there time-out happens, delegate call:didFailWithError: callback raised. Thanks.

Hi @talalt
If you are seeing the timeout error too frequently, please collect the Call-SIDs (TVOCall.sid) from the Xcode debugger or from the Programmable Voice Dashboard and reach out to us, then we can try to diagnose why the network connectivity is causing the timeout.'
Thanks,
bobie


Feat/add refresh and wait

Closes #24

[x] Tested with python setup.py test

Hi @andrewvillazon, here is my PR with the updated refresh method returning the requestId + the new method refresh_and_wait as you suggested. I've also updated the corresponding unit tests !

Thanks for this. I'll take a look over the next couple days and get back to you.


How could I get the action of any time-step in one loop of simulation?

Hi Mohit! Thanks for your nice work. I am trying to replace the agent with my designed neural network for the prediction of the agent action. Here, I am confused that if I could record (obs, action) pairs at every time-step in one loop of simulation depending on a sampling rate by modifying env.step() or agent.act() function.

First, I use the PyBullet to randomly generate dataset, just like what you did in cliport/cliport/demo.py. And I can save the observation and corresponding action using 'episode.append((obs, act, reward, info))'.

I check that it seems like that only when a block has been placed correctly, an action will be output by the agent, which means that only 6 or 7 steps (observation, action) are recorded in one trajectory.

For my training dataset, I want to record the (observation, action) pairs that the agent performs along the whole simulation loop depending on a sampling rate. In your code, you have provided 'record videos' to save mp4 for one completed simulation. Therefore, observations at any time step can be sampled. I want to know that if there any way for me to record the action corresponding to the sampled observation, instead of only saving the last completed action? Specifically, in the process of putting the green block in the brown box, there is a first process of lifting the green block up to certain height, then translating the green block, and finally putting down the block in box. In this procedure, 100 observations/frames can be sampled from mp4, but the number of recorded actions from agent is only 6 or 7. Could I save the (observation, action) pair at some time-step? For instance, the green block is being raised by the robot to a certain height at an intermediate location.

Appreciate and look for your reply! :)

@MohitShridhar Okay, Thanks for your reply! I will try it.

@MohitShridhar Sorry for disturbing again. You mentioned that (1) save additional actions while saving video frames, but I am not very sure where or which I should modify to record the corresponding action with the frame. I have understood how This works, but have no idea if I can record the corresponding action in this add_video_frame()?
Thanks a lot!


Correct grammar of workflow instance change notifications

The current grammar is not quite right. Alternatively this could be worded as:
"An instance of this workflow has changed."

Thank's :+1:


why did you added  "license": "(MIT OR GPL-3.0)"

Hey,
Why did you added  "license": "(MIT OR GPL-3.0)", you can simply add  "license": "MIT". Is there something you are achieving by providing MIT or GPL-3.0 License ?

I was following a precedent i'd seen done by other OSS, particularly in JS front-end. I wanted to ensure that this software was available for any and all use, whether in a GPL product or in a commercial business use.