Dependency on System.Runtime.CompilerServices.Unsafe didn't install when using NuGetPackage.[BUG]

Description
When installing SkiaSharp.Views to a wpf application via NuGet package manager in VS 2019, I tried recreating the WPF gallary example in my project.
I got error:
System.IO.FileLoadException HResult=0x80131040 Message=Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040) Source=System.Memory StackTrace: at System.MemoryExtensions.AsSpan(String text) at SkiaSharp.SKCanvas.DrawText(String text, Single x, Single y, SKFont font, SKPaint paint) at SkiaSharp.SKCanvas.DrawText(String text, Single x, Single y, SKPaint paint) at LabMonsterToolkit.TrainingWindow.OnPaintSurface(SKCanvas canvas, Int32 width, Int32 height) in
...
SkiaSharp.Views.Desktop.SKGLControl.OnPaint(PaintEventArgs e) at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer) at System.Windows.Forms.Control.WmPaint(Message& m) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.UserControl.WndProc(Message& m) at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam) Inner Exception 1: FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
After a bit of debugging I realize I needed to install the corresponding NuGet package.
Expected Behavior
I expect the NuGet package to install all dependencies required to work with it.
Actual Behavior
The package does not work after installing because of the missing dependency.
Basic Information

Version with issue:  SkiaSharp.Views V 2.88.3
Last known good version:
IDE:   Visual Studio
Platform Target Frameworks:

Windows Classic:  10

Detailed IDE/OS information (click to expand)

Is this still happening with the latest preview?


npm version is WAY out of date

Update the npm package already! The latest version on there is 0.4.14 and the current version here is 2.1.0

I'm not sure where you're seeing this, but I released 2.1.0 to NPM a few days ago. https://www.npmjs.com/package/eventemitter2

@RangerMauve Ahh i see what happened. I added "eventemitter2":"*" into my package.json, but I didn't realize I already had an old version downloaded in my node_modules. That's why i ended up still having an old version.

Makes sense. :P


Revert "Return error when TmplText errors in sns notifier"

Reverts prometheus/alertmanager#3531

@TheMeier this did break the tests - Let's revert it for now until I have some time to figure out what's wrong?

There are two imports for error package with the same name:
package sns

import (
	"errors"
	...

	"github.com/pkg/errors"
)

`errors` redeclared in this block (typecheck)

see https://github.com/prometheus/alertmanager/commit/603a72800ed14f94cb20b5561e77df2c54e41d4f.

We should also replace errors.Wrap with fmt.Errorf 🙂 @emanlodovice

My apologies for the previous PR, it was old and needed to be rebase. I have opened a new PR to fix the issue https://github.com/prometheus/alertmanager/pull/3879/ . Please have a look. Thank you.


fix(): update cluster health after ReconcileInterval

Currently worker-operator is updating cluster CR LastUpdated field in every second.
This PR will update cluster CR LastUpdated field after reconcile interval (after 2 min).

Can you please add the existing issue that you are trying to fix ? description is just telling the change

Can you please add the existing issue that you are trying to fix ? description is just telling the change

Gourish please take a look now


[libmaxminddb] non-existent path in INTERFACE_INCLUDE_DIRECTORIES

Operating system
Windows 11
Compiler
MSVC
Steps to reproduce the behavior
Clone the minimal repro repository from https://github.com/maksis/vcpkg-maxminddb and run cmake -B build -S .
Failure logs
CMake Error in CMakeLists.txt:
  Imported target "maxminddb::maxminddb" includes non-existent path

    "C:/Projects/test/build/vcpkg_installed/x64-windows/generated"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Additional context
It will work after creating the generated directory manually

Seems to have a fix in https://github.com/maxmind/libmaxminddb/pull/354, but nobody updated the vcpkg port.

@maksis This issue has been fixed, please update vcpkg and recompile.


Headstage64 voltage setup timeout

When a hs64 is connected alone, the voltage search works as expected. If the chain contains a ConfigureNeuropixels1.0eHeadstage followed by a ConfigureHeadstage64, the np1.0e voltage will be set correctly, hs64 voltage search will start (noticeable thanks to the LEDs) but it will fail with the same message as if no headstage was plugged (cannot lock), which suggests some kind of timeout.
Setting a fixed voltage to the hs64 fixes the issue.

Just to confirm: another workaround, on this particular configuration (an hs64 a np1.0e) seems to be having the hs64 before the np1.0e on the chain.
I am not sure what the dependency is here, but voltage probing for each headstage should be independent of their positioning or of other headstages in the configuration chain.

@aacuevas There is no explicit timeout, but there are Thread.Sleep calls in the port scanning implementation for HS64 do deal with the port voltage settle behavior that were tweaked over time to be as minimal as possible without compromising the scan behavior:
https://github.com/neurogears/onix-refactor/blob/5903bfcc06960db73b8c1c55987de0fbcdc07598/OpenEphys.Onix/OpenEphys.Onix/ConfigureHeadstage64.cs#L88
In the case of a direct port voltage override the default Thread.Sleep parameter is 500 ms, which is higher than the lower 200 ms we used for incremental port scanning.
Is there any way the port scanning behavior or NP1.0e might destabilize the HS64 port voltage ever so slightly that the 200 ms is no longer enough?
What I would recommend to debug this would be to change the port scanning wait time to 500 ms instead of 200 ms and see if that changes anything. Alternatively it would also be useful to know whether this is failing during the wait period in port scanning (L89), or during the last CheckLinkState call after voltages have been set (L101).

Just to be clear on the issue, does the hs-64 voltage search go through the whole process (which takes like 30 seconds) or does it fail immediately.
FWIW, in the specific case of hs-64 with this hardware, i really think the auto voltage search should be disabled completely. Its too sketchy and too long.

In the end, I think this is a wontfix situation

We added the ability to override the voltage discovery algorithm on #105
As noted in the code comments, this is really a hardware issue that is especially prevalent on hs-64. e.g. neuropixels headstages don't have nearly as much trouble.


fix(Datagrid): expandable row add background on row hover

Contributes to #3324
Adds background color to expanded area when hovering on the expanded row.
What did you change?
packages/ibm-products/src/components/Datagrid/styles/_useExpandedRow.scss

How did you test and verify your work?
Storybook

Ah ok, I must have misread the issue. I'll change this ^

Ended up taking a similar approach to Carbon for highlighting the parent row of the expanded area, couldn't get :has(+ .expanded-class) previous sibling selector to work here.


chore: rename CamelRegistryBuildItem to a more meaningful CamelBeanBuildItem

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/193/


Add launch demo: GenList

Open-sourcing demo created for Multimodal Live API: GenList. Video to follow.

thanks Ben! excited to finally get this demo added in.


Categorization guide

This adds a first version of documentation on how to categorizein Columnflow.
The guide is not yet final, but should already be in a presentable state.
The most important TODO is probably to convert the code examples into some testable scripts.

Closes #317


feat(sql): allow open absolute sqlite path

This PR updates the sql plugin in plugins-workspace for v2. It now allows opening SQLite files from any absolute path. If the path is not absolute, it still defaults to opening files relative to the app directory.
Examples of possible connection strings:
sqlite:/absolute/path/to/file.db

sqlite:relative_to_app_dir.db

As mentioned in https://github.com/tauri-apps/plugins-workspace/pull/1441#issuecomment-2173723910 i plan to make some larger changes and the connection logic will be part of it. Are you okay with me creating a combined PR and add you as a co-author? (github should attribute you basically the same as if it's your pr)

@FabianLars
Sure 👍


Improve Memory Handling in Research Notebook

Expected Behavior
The Research Environment has a garbage-collecting feature.
Actual Behavior
The Research Environment doesn't have a garbage-collecting feature. If we use data from History requests, we can't dispose of it to free memory up and continue to run the same notebook.
import gc
import psutil

# instantiate thq quantbook
qb = QuantBook()

# load equity symbol_ids from the object store and add them to the quantbook
symbol_ids = '''AMD,NVDA,AMZN,META,GOOGL,GOOG,SHOP,OXY,
RBLX,MU,XOM,BABA,GM,PLUG,SQ,ORCL,PYPL,DVN,CVX,COIN,JPM,
SLB,AFRM,SBUX,LI,TSM,MRVL,DIS,UAL,MS,ROKU,NEE,U,APA,EQT,
CVNA,PDD,QCOM,AA,RCL,COP,FDX,BA,LVS,PENN,CRM,UPST,ABNB,
SCHW,GE,WMT,NKE,AMAT,AR,DOW,MOS,ON,RUN,DT,PG,MPC,MMM,DASH,
RTX,ASAN,DOCU,ZIM,JD,WDC,ARRY,FTNT,BTU,ENVX,AIG,OKTA,GIS,
BYND,TWLO,NET,TMUS,FISV,MET,MCHP,SE,LTHM,W,VLO,CVS,IBM,PM,
TJX,DDOG,RRC,BX,WYNN,CTVA,ZM,CZR,TTD,Z,CHWY,GME,RIO,PSX,BHP,
CTSH,MTCH,DD,EOG,PBF,ADI,OVV,APP,AXP,EXPE,CF,ADM,COF,YUMC,
LYB,OKE,FSLR,AEM,BLDR,ETSY,CNQ,DLTR,PVH,NOVA,EMR,NUE,AEP,
ICE,S,SPR,PGR,NTR,FANG,LAC,BBY,APH,MAR,STX,HLT,MP,BE,DUK,
ANET,HES,MNST,TTE,CPRI,LYV,BIDU,SPLK,CHK,PRU,SWKS,STLD,CC,SYY,RNG'''.split(',')

for symbol_id in symbol_ids:
    qb.AddEquity(symbol_id)

# define a function (closure) to perform the history request
def history_function(qb):
    df_history = qb.History(
        qb.Securities.Keys,
        datetime(2010, 1, 1),
        datetime(2022, 1, 1),
        Resolution.Daily,
    )
    print(f"Dataframe size: {df_history.memory_usage().sum() / 1e6:.1f} MB")
    del df_history

print(
    f"Memory usage before calling the function: {psutil.virtual_memory().used / 1e9:.3f} / "
    f"{psutil.virtual_memory().total / 1e9:.1f} GB "
    f"({psutil.virtual_memory().percent}%)"
)

# run the function with the history request and subsequently collect the garbage
history_function(qb)
gc.collect()

print(
    f"Memory usage after calling the function: {psutil.virtual_memory().used / 1e9:.3f} / "
    f"{psutil.virtual_memory().total / 1e9:.1f} GB "
    f"({psutil.virtual_memory().percent}%)"
)

# delete the quantbook and subsequently collect the garbage
del qb
gc.collect()

print(
    f"Memory usage after deleting the qb: {psutil.virtual_memory().used / 1e9:.3f} / "
    f"{psutil.virtual_memory().total / 1e9:.1f} GB "
    f"({psutil.virtual_memory().percent}%)"
)

Result:
Memory usage before calling the function: 37.296 / 135.0 GB (28.6%)
Dataframe size: 15.2 MB
Memory usage after calling the function: 38.463 / 135.0 GB (29.5%)
Memory usage after deleting the qb: 38.463 / 135.0 GB (29.5%)

We can see there is no significant or no drop in memory consumption.
Potential Solution
N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

From a user perspective: if one has a notebook that performs a large history request that results in ~500MB of data in the Python namespace, but the history request ends up allocating ~10GB of memory in the backend, this can leave the user with very little usable RAM to continue working in the notebook. Is there any way to get around this, @Martin-Molinero, @AlexCatarino?
It seems the only way to do so is to save the resulting data to the object store, restart the kernel, re-run all of the notebook up to history request, and then load the resulting data from the object store, which isn't very convenient.

Hey @cperotlsq!
We've been working on this, and pushed a few improvements at https://github.com/QuantConnect/Lean/pull/6700.
Another workaround to avoid having to restart the kernel is:
from System import *
for x in range(0, 40):
    GC.Collect()

Hey @Martin-Molinero, thanks for looking into this and implementing some improvements! I do start to see the memory usage decrease after running this, but it takes some time for it to do so, and not necessarily to the level it would be without restarting the kernel and loading the corresponding data from the object store. Nonetheless, this is an improvement :)
I am curious, why do we need to collect the garbage 40 times?

Hey!

thanks for looking into this and implementing some improvements!

Thanks for the report :), we will circle back to this again soon and push another improvement.

not necessarily to the level it would be without restarting the kernel

Yes, this is somewhat expected, it's created the QB, loaded 4k securities, loaded map/factor files, object store, etc.

I am curious, why do we need to collect the garbage 40 times?

Not 100% sure, it's what it takes roughly, it's a progressive operation. Think it's somewhat related to the GC settings we are using

Potentially adding a way to clear or disable the hour and daily caches.

In the static constructor of the QuantBook we can trigger a timer every 20 second to perform a GC.Collect operation


Extra closing parenthesis in aphrodite init code

In phenomic/lib/components/Html/index.js, there is this code to initialize aphrodite:
script: [{ "innerHTML": "window._aphrodite = " + JSON.stringify(aproditeResult.css.renderedClassNames) + ");" }]
There is an extra closing parenthesis but the opening one is missing.
So, in production, I have a SyntaxError: Uncaught SyntaxError: Unexpected token )

Oops. Looks like a bug.
Can you fix it? It's right here https://github.com/MoOx/phenomic/blob/e58c70872f9661b55c4fcb410a6d289910619831/src/components/Html/index.js#L71
You might have to adjust some tests.

Ok I will fix it


[WIP] Add initial Redfish unit tests

This PR adds the unit tests for the Redfish systems API. This will work with python 3 only.
I added a step in the travis configuration that detects the current Python version and disables the tests if needed.
The API for Redfish is now extended to also include the new physical server properties introduced to the GUI in CloudForms 5.0.

Lint report for commit 9c93f51f1e3eaa48588ea1ed0a17697f0b7c207c:
tests/test_redfish.py:

:bangbang: Line 1:1: E265 block comment should start with '# '
:red_circle: Line 5:1: F401 'pytest' imported but unused
:bangbang: Line 11:1: E302 expected 2 blank lines, found 1
:red_circle: Line 14:9: F841 local variable 'rf' is assigned to but never used
:red_circle: Line 18:9: F841 local variable 'rf' is assigned to but never used
:bangbang: Line 64:61: E703 statement ends with a semicolon
:heavy_exclamation_mark: Line 92:59: W291 trailing whitespace
:bangbang: Line 131:59: E251 unexpected spaces around keyword / parameter equals

:scream: You might like to check the lint of your code :point_up:
No commit flaws detected.
CFME QE Bot

@mshriver Travis is now passing in Python 3. Do you have any advice how to disable the tests that only work in Python 3 for the Python 2 version of tests?

The Travis checks are now passing. In the Python 3.7 configuration, it runs the new unit tests.
@miha-plesko please have a look.

Lint report for commit 74f7f6cbfe5c9dce7089fd948e0d4467f6c5102f:
tests/test_redfish.py:

:bangbang: Line 66:32: E231 missing whitespace after ':'
:bangbang: Line 72:101: E501 line too long (108 > 100 characters)
:bangbang: Line 91:32: E231 missing whitespace after ':'
:bangbang: Line 111:17: E123 closing bracket does not match indentation of opening bracket's line
:heavy_exclamation_mark: Line 135:15: W291 trailing whitespace
:bangbang: Line 143:32: E231 missing whitespace after ':'
:bangbang: Line 163:17: E123 closing bracket does not match indentation of opening bracket's line
:heavy_exclamation_mark: Line 187:15: W291 trailing whitespace

:scream: You might like to check the lint of your code :point_up:
No commit flaws detected.
CFME QE Bot

@matejart I'm overwhelmed with other projects, especially now that I've returned from a whole week of sick leave, so I'm passing the pleasure of the code review straight to the @mshriver .
On a quick scroll, however, I think you should really use pytest marker to conditionally skip tests when python version is not high enough, e.g. http://doc.pytest.org/en/latest/skipping.html#id1
@pytest.mark.skipif(sys.version_info < (3, 6), reason="requires python3.6 or higher")
def test_function():
    ...

Let's still review it iternally first.
I tried using @pytest.mark, but that doesn't work because pytest fails on from unittest import mock before it even gets to the (un)collection. Since unittest.mock is a Python 3 thing, and with the overall migration to Python 3.7, I was quicker and cleaner with the rm script.

CFME QE Bot

@matejart @miha-plesko let's make this even easier. I'm going to drop support for python <3.7 here, as I believe all teams using this library have migrated to py3 by now


Add support for LinearOperator to eigsh and svds in cupyx.scipy.sparse.linalg

This PR adds support for LinearOperator to cupyx.scipy.sparse.linalg.eigsh and cupyx.scipy.sparse.linalg.svds to improve compatibility with SciPy.

Jenkins, test this please.

Jenkins CI test (for commit e4be77a5d49eaab253730d992bc087e43569a207, target branch master) succeeded!

LGTM!


Missing support for Azure China (21 Vianet)

Hello,
on previous versions we used
-AzureEnvironment "AzureChinaCloud"
but now, Invoke-ARI does not accept it anymore
Invoke-ARI : Cannot validate argument on parameter 'AzureEnvironment'. The argument "AzureChinaCloud" does not belong to the set "AzureCloud,AzureUSGovernment" specified by the ValidateSet attribute. Supply an argument that is in
the set and then try the command again.
Regards,
Red.

Hello @red-erik
You are right, I just added the support for the environment "AzureChinaCloud" in the version 3.5.4
Can you update the powershell module and try again?

Hello,
the module is accepting the parameter but it's returning a lot of errors
Update-Module : A parameter cannot be found that matches parameter name 'AcceptLicense'.
At C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.4\AzureResourceInventory.psm1:177 char:60

...             Update-Module -Name AzureResourceInventory -AcceptLicense

CategoryInfo          : InvalidArgument: (:) [Update-Module], ParameterBindingException
FullyQualifiedErrorId : NamedParameterNotFound,Update-Module

DEBUG: 2024-10-01_08_29_45 - Invoking Inventory Loop for AVD Resources
Search-AzGraph : {
"error": {
"code": "BadRequest",
"message": "Please provide below info when asking for support: timestamp = 2024-10-01T08:29:45.8242902Z, correlationId = fce7f36e-5aa3-48e6-a730-71621bbaccda.",
"details": [
{
"code": "DisallowedLogicalTableName",
"message": "Table desktopvirtualizationresources is invalid, unsupported or disallowed."
}
]
}
}
At C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.4\Modules\Core\ARIInventoryLoop.psm1:71 char:36

... eryResult = Search-AzGraph -Query $GraphQuery -first 1000 -Subscripti ...

CategoryInfo          : CloseError: (:) [Search-AzGraph], ErrorResponseException
FullyQualifiedErrorId : BadRequest,Microsoft.Azure.Commands.ResourceGraph.Cmdlets.SearchAzureRmGraph

DEBUG: 8:29:46 AM - GetAzureRmAccessTokenCommand end processing.
ConvertFrom-SecureString : A parameter cannot be found that matches parameter name 'AsPlainText'.
At C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.4\Modules\Inventory\ARIAPIInv.psm1:17 char:58

$TokenData = $Token.Token | ConvertFrom-SecureString -AsPlainText

CategoryInfo          : InvalidArgument: (:) [ConvertFrom-SecureString], ParameterBindingException
FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.ConvertFromSecureStringCommand

DEBUG: 2024-10-01_08_32_14 - Checking if Should Generate Policy Sheet.
get-job : The command cannot find the job because the job name Policy was not found. Verify the value of the Name parameter, and then try the command again.
At C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.4\Modules\Core\ARIExtraJobs.psm1:261 char:12

    if(get-job -Name 'Policy')

CategoryInfo          : ObjectNotFound: (Policy:String) [Get-Job], PSArgumentException
FullyQualifiedErrorId : JobWithSpecifiedNameNotFound,Microsoft.PowerShell.Commands.GetJobCommand

DEBUG: 2024-10-01_08_33_15 - Validating if Excel is installed (Extra Customizations).
New-Object : Retrieving the COM class factory for component with CLSID {00000000-0000-0000-0000-000000000000} failed due to the following error: 80040154 Class not registered (Exception from HRESULT: 0x80040154
(REGDB_E_CLASSNOTREG)).
At C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.4\Modules\Extras\ARIReportCharts.psm1:934 char:28

        $application = New-Object -ComObject Excel.Application

CategoryInfo          : ResourceUnavailable: (:) [New-Object], COMException
FullyQualifiedErrorId : NoCOMClassIdentified,Microsoft.PowerShell.Commands.NewObjectCommand

Regards,
Red.

Hi @red-erik
there is some weird stuff going on there.
Are you using SPN?
Are you using Automation?
Can you try to uninstall the module and install it again?

Hello,
tested removing and reinstalling, with, more or less, the same result.
Regards,
Red.

Hello @red-erik
I think that should be fine, I believe that Azure Environment does not have AVD, and because of that, the Graph Table (desktopvirtualizationresources) does not exist there

Thank you very much for clarifying this topic.
Everything else is working as expected.
Regards,
Red.


fix import in main example

Thanks, @tmaziere
I will deploy this version in the next few days or so.

@tmaziere I have uploaded your changes to PyPi as farmbot 0.1.0. Could you please check that everything deployed OK? Tests pass on my local machine. https://pypi.org/project/farmbot/


refactor: move "delete old update files" logic to Updates

This PR moves the "delete old update files" logic from RunGui to Updates, and uses QtConcurrent::run instead of an std::thread
I have purposefully not added a platform-check to this yet


UST (aligned) word count accuracy

This is for aligned texts. See UST (unaligned) word count accuracy for the other case.

See src/tests/ust for tests for Titus. Steps similar to ULT tests:

get the raw Titus USFM text: tit_usfm.txt
run node --experimental-modules tit_usfm.mjs to convert to JSON: tit_usfm.txt.json. The JSON is stringified with options to make "pretty printed".
run sh word.grep.sh to produce word.grep.txt. This has all the "type word" properties found in the JSON.
The above script reports a total of 1756 words.

Inspection of pretty printed JSON shows it goes 5 levels deep on the "children" properties. After changing the code, the component is now reporting the correct number of words.


Entry not found in cache

Repro steps:

Action: azureFunctions.deploy
Error type: Error
Error Message: Entry not found in cache.
Version: 0.17.0
OS: win32
Product: Visual Studio Code
Product Version: 1.33.1
Language: en

Call Stack
a.module.exports.a.createError extension.js:1:49013
b.<anonymous> extension.js:229:176642
extension.js:229:171257extension.js:229:171257
extension.js:229:43312extension.js:229:43312
extension.js:229:41305extension.js:229:41305
extension.js:229:40927extension.js:229:40927
i.module.exports.i.find extension.js:229:75420
module.exports.find.init.then extension.js:229:22917
i extension.js:1:101710
extension.js:1:102054extension.js:1:102054

Thanks for filing - this is being tracked upstream: https://github.com/microsoft/vscode-azure-account/issues/53

As a workaround you could try signing out and signing back in to your Azure Account using the command palette


Consider removing ci access to this repo

Does this repo still use Jenkins? Pretty much all of our repos have granted write access to the ci user and I'm currently going through them and removing this access (as this is really sketchy from a security perspective). However, I left this repo as it appears to still use Jenkins.

Done. Thanks for the suggestion


console.error duplicate

VSCode Version: Code 1.10.1 (653f8733dd5a5c43d66d7168b4701f94d72b62e5, 2017-03-02T00:33:15.706Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

vscode-eslint
dbaeumer
1.2.7

vscode-icons
robertohuertasm
7.3.0

After a recent update, console.error is sending duplicate entries into the debug console.  I've tested the same code outside of the debugger, and using chrome dev tools, and the issue does not happen.  If I run the vs code debugger in legacy mode, it does not happen either.  If I use console.info, it works fine, but using console.error outputs two lines into the debug console.

What version of Node?

@roblourens 7.7.1.

Ok, weird. Can you try running with "trace": true, then upload the log file from the path it prints at the top of the debug console?

Is that supposed to go in the launch config?  It doesn't seem to do anything and is flagged as invalid option:

https://gist.github.com/Meowbeast/aa861bbd265657b3135b854141c099dd

Actually I can repro this, only on windows, not all the time. Node is supposed to produce the message "debugger attached", and sometimes it doesn't, and so long story short, I'm writing the stderr output and the error messages that come through the debug channel.

This actually happens all the time here, with Win10 x64 and 1.10. Happens with node 6.10 and 7.7.1.

What version of Node? I can't repro

@roblourens it appears it's an issue on one pc, but not the other.
I've tried reinstalling VS Code and Node, running latest on both.

This seems to have something to do with the flag below.  With the flag, console.log duplicates.  Without the flag, it works as expected.

Thanks for noticing that, I can repro it. I didn't know about that flag.


Add useJCenter settings and set it to false by default

Fixes #2217
what this changes
Adds a new setting useJCenter, which is set to false by default. When set to true, JCenter will be placed as the first external resolver to find library dependencies.
The implementation of externalResolvers is changed to incorporate the setting by calling Resolver.reorganizeAppResolvers. These changes were required because externalResolvers uses whatever that's in the launchconfig, which the build user may not upgrade.
notes
sbt 0.13.9 made JCenter the first external resolver "for faster resolution times". #1938 (9261652d41635634a5ca46fc574b90b2a1ec42ab.
From what I tested using Reactive Maps + Play 2.3.10, JCenter takes 212 ~ 251s for update to return on the proper build (excluding plugins) while Maven Central takes 71 ~ 98s for update. Basically 2 ~ 3.5 times slower. ymmv.
/review @Duhemm, @dwijnand, @jsuereth

LGTM. Thanks.

:+1:


Set linguist attributes for pixi.lock

Just stumbled on this project and figured I'd add this small nice-to-have.
This applies syntax highlighting in the GitHub web interface, and treats it as a generated file.
In the future, you might want to contribute to github-linguist so that GitHub has proper support for this filename, but, for now, a quick search shows that this file probably won't meet the popularity requirement.

Hey @spenserblack ! Thanks for your contribution!
I was wondering, would you also be able to contribute adding the .gitattributes file when running pixi init? Similar to how we generate a default gitignore.

I'll see what I can do :slightly_smiling_face:
So you're good with both attributes? Note that GitHub excludes generated files from PR diffs. So, while it might be accurate to label pixi.lock as generated, you might prefer not to. yarn.lock for example, had a PR to linguist to stop marking it as generated.

Done. Let me know if you want any more changes :slightly_smiling_face:

Ah that is a problem indeed, I wasn't aware of that detail. In that case, lets remove the generated part. I think it is very important people are aware a lock file changed in a PR.

Thanks! Much appreciated!


Timestamp with 'one hour ago' and the like not very viable

Timestamps displayed like this are not very viable imo:
Reasons is, that is pretty inaccurate, especially if more than one is present and I want to know which one is older.
Solutions:
a) make all timestamp in the regular format, i.e. 12.12. 2022 - 09:30
b) make a tooltip that shows the exact time stamp

Timestamps displayed like this are not very viable imo:
Reasons is, that is pretty inaccurate, especially if more than one is present and I want to know which one is older.
Solutions:
a) make all timestamp in the regular format, i.e. 12.12. 2022 - 09:30
b) make a tooltip that shows the exact time stamp

CC @peintnermax


Improved diagnostics

Diagnostics are currently limited to explicit parse errors reported by bmewburn/php7parser. The diagnostics provider could be improved by providing diagnostics on:

[ ] Violation of constraints specified in php/php-langspec
[ ] Incorrect argument types or number of arguments in call expressions.
[ ] Unused symbols
[ ] Static and instance members used in correct context
[ ] Deprecated warnings

Is there anything we can do to help out?

@JapSeyz thanks for the offer! You're welcome to create a PR for his or any other issue. I have been meaning to put together a contributing guideline with an overview on how it works. The diagnostics provider is pretty simple right now. It just traverses over the parse tree and creates diagnostics from the parse error nodes in the tree.
There is also 2 derived trees - a symbol (definitions) tree and a references tree. For unused variables and parameters a simple rule might even be that if there is only a single reference to a variable or parameter in a given scope then it is either unused or undefined (a reference is created for the definition/declaration too). I haven't given much thought o how this could all be structured in the diagnostics provider.

Two ideas from IntelliJ that you might consider:

highlighting unused variables
highlighting undeclared variables


Pytorch Geometric CPU only version ImportError:  <$python_path>/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/spspmm_cpu.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

📚 Installation
Hi Experts,
Actually installation is without any warning and error, it is the problem while importing torch_geometric. (details appended below) How do I solve this issue?

Error Log Importing torch_geometric

import torch
import torch_geometric
Traceback (most recent call last):
File "", line 1, in
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/init.py", line 2, in
import torch_geometric.nn
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/init.py", line 2, in
from .data_parallel import DataParallel
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/data_parallel.py", line 5, in
from torch_geometric.data import Batch
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/data/init.py", line 1, in
from .data import Data
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/data/data.py", line 7, in
from torch_sparse import coalesce
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/init.py", line 6, in
from .spspmm import spspmm
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/spspmm.py", line 4, in
import torch_sparse.spspmm_cpu
ImportError: /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/spspmm_cpu.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

Installation Log

pip install torch-geometric
Collecting torch-geometric
Requirement already satisfied: plyfile in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (0.7)
Requirement already satisfied: scipy in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (1.3.1)
Requirement already satisfied: pandas in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (0.24.2)
Requirement already satisfied: scikit-learn in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (0.21.3)
Requirement already satisfied: h5py in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (2.9.0)
Requirement already satisfied: networkx in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (2.2)
Requirement already satisfied: numpy in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (1.16.4)
Requirement already satisfied: googledrivedownloader in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (0.4)
Requirement already satisfied: rdflib in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from torch-geometric) (4.2.2)
Requirement already satisfied: pytz>=2011k in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from pandas->torch-geometric) (2018.9)
Requirement already satisfied: python-dateutil>=2.5.0 in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from pandas->torch-geometric) (2.8.0)
Requirement already satisfied: joblib>=0.11 in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from scikit-learn->torch-geometric) (0.13.2)
Requirement already satisfied: six in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from h5py->torch-geometric) (1.12.0)
Requirement already satisfied: decorator>=4.3.0 in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from networkx->torch-geometric) (4.4.0)
Requirement already satisfied: pyparsing in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from rdflib->torch-geometric) (2.3.1)
Requirement already satisfied: isodate in /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages (from rdflib->torch-geometric) (0.6.0)
Installing collected packages: torch-geometric
Successfully installed torch-geometric-1.3.1

Environment

OS: CentOS Linux release 7.6.1810 (Core)
Python version: Python 3.6.8 :: Anaconda custom (64-bit)
PyTorch version:
torch==1.2.0+cpu
torch-cluster==1.4.4
torch-geometric==1.3.1
torch-scatter==1.3.1
torch-sparse==0.4.0
torch-spline-conv==1.1.0
torchvision==0.4.0+cpu
CUDA/cuDNN version: None
GCC version: gcc-8.2.0
How did you try to install PyTorch Geometric and its extensions (pip, source):  pip install torch-geometric
Any other relevant information:

Checklist

[ V] I followed the installation guide.
[ V] I cannot find my error message in the FAQ.
[ X] I set up CUDA correctly and can compile CUDA code via nvcc.
[ X] I have cloned the repository and tried a manual installation from source.
[ X] I do have multiple CUDA versions on my machine.
[ X] I checked if the official extension example runs on my machine.
[ X] The offical extension example runs on my machine.

Additional context

Do you have multiple PyTorch versions installed? This could be an issue. If not, maybe downgrading gcc to 5.4 helps.

I uninstalled the torch_geometric and downgrade gcc to 5.4.0 then re-install torch_geometric again, it shows the same ImportError:
//======================================================

import torch
import torch_geometric
Traceback (most recent call last):
File "", line 1, in
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/init.py", line 2, in
import torch_geometric.nn
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/init.py", line 2, in
from .data_parallel import DataParallel
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/data_parallel.py", line 5, in
from torch_geometric.data import Batch
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/data/init.py", line 1, in
from .data import Data
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/data/data.py", line 7, in
from torch_sparse import coalesce
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/init.py", line 6, in
from .spspmm import spspmm
File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/spspmm.py", line 4, in
import torch_sparse.spspmm_cpu
ImportError: /home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_sparse-0.4.0-py3.6-linux-x86_64.egg/torch_sparse/spspmm_cpu.cpython-36m-x86_64-linux-gnu.so: undefined symbol: _ZN3c105ErrorC1ENS_14SourceLocationERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

Is it because I install under virtual Conda environment since I do not have superuser permission?  I've tried to create another virtual environment and install again same problem comes out.

Sudo rights should bot cause a problem in conda environments. Are you sure you do not have multiple PyTorch versions installed?

Sorry, this might be a very stupid question but how do I check if I have multiple versions installed?

I've uninstalled PyTorch and re-install again, still with the same problem.

Eventually this thread is helpful to you.

Thanks, I think I've removed a redundant version of PyTorch, now it's showing other error.
>>> import torch_geometric
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/__init__.py", line 2, in <module>
    import torch_geometric.nn
  File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/__init__.py", line 1, in <module>
    from .meta import MetaLayer
  File "/home/hliu/.conda/envs/hliuPython/lib/python3.6/site-packages/torch_geometric/nn/meta.py", line 4, in <module>
    class MetaLayer(torch.nn.Module):
AttributeError: module 'torch' has no attribute 'nn'

Your PyTorch version sounds broken to me.


App details view updates

App details view of DEMO Photos Apps, an app that has already been added to the account.
Includes:
Title
Author
Data type ("with ____ from")
Icons of the services
Link to Github code
Description
Version #
Action button

Add an app (button state changes)
App moves to top of the list in "INSTALLED APPS" section of leftnav

Here are the button states:

Not closing this yet, it's missing stuff

@merc3po I merged in the pull requests from @beaugunderson, can you confirm everything looks right and if so, close the issue?

@smurthas is this on sandbox? I don't see it there.

I don't know. It's merged into master.

This is done


Handle OSM API Timeouts

Followup on #1304
We already handle a bunch of different error conditions with the OSM API.
But when things get really bad, we don't even get a response from the capabilities or any of the other calls, just a connection timeout:

We should handle this situation too.

This relates to #1451 too where I said:

While we're at it, the AbortSignal can now have a timeout. This is a thing that all modern browsers support now - details. The default fetch timeout in Chrome is 300 seconds, but we should probably drop most requests after like 5-10sec.

The timeout should be quicker.
Some data taken during today's DDoS storm:

2.4 minutes is kinda a long time to wait for a response 😆
After a few seconds we can cancel it and display the red bar of sadness.


Document the git workflow for updating, testing, and creating PRs for a dbt package

Contributions

[ ] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/guides/legacy/building-packages#3-develop-your-package
What part(s) of the page would you like to see updated?
We should create a new page that describes the git workflow for editing a package. An example is provided on discourse.
Additional information
No response

This guide does this! https://docs.getdbt.com/guides/building-packages?step=1


fix: packageName normalization for asset names

Fixes #860. Verified the fix in my project.

Thanks for contributing! Assuming CI will be happy, could you please add a changefile like this please?

fix issue #111


Changing controllers to remove rancher dep

Overview
This PR update the adapter to remove the direct dependency on rancher, which should help with minimizing scanner CVEs. In addition, it includes bumps from several different renovate bot prs (listed below) and bumps the chart version to support k8s version 1.26 (which I also tested).
Testing
The following process was done for eks 1.23 and eks 1.26:

Deploy 2.7.5-rc1 on Target Version
Deploy the modified adapter (only 2 nodes per entitlment) using test settings (-set image.repository=mbolotsuse/test --set image.tag=csp-adapter --set image.imagePullPolicy=Always --set global.cattle.systemDefaultRegistry="docker.io" --set devMode=true)
Create a downstream rke2 cluster with 3 nodes to go over entitlement.

Confirm that the UI displays an error
Confirm the supportconfig indicates the correct number of required vs consumed nodes
Confirm the supportconfig indicates the out of compliance status

Delete the downstream rke2 clusters.

Confirm that the error is gone from the UI
Confirm the supportconfig indicates the correct number of required vs consumed nodes
Confirm the supportconfig indicates the in compliance status

In addition, manual confirmation was done through the console (after deploying a single node RKE2 console) that the license was actually checked out from license manager.
Renovate PRs
This includes the following renovate PRs:
#51
#50
#48
#46
#44
#43
#42
#41
#39
#36
#35


Feature Request: Support tags filter on nomad service discovery

Proposal
Use the same way of filtering services by tags as we can do with consul_sd_configs.
This let's us have a single job "service-metrics" that auto-detects, filters and scrapes any service which are marked with tags=prometheus,metrics .
Should also be backported to LTS version.
- job_name: service-metrics
  sample_limit: 10000
  scheme: http
  nomad_sd_configs:
    - server: 'http://<IP_ADDRESS>:4646'
      tags: ['prometheus', 'metrics']  # like with consul_sd_configs
  relabel_configs:
  - source_labels: [__meta_nomad_service_id]
    target_label: 'serviceid'
  - source_labels: [__meta_nomad_dc]
    target_label: 'dc'
  - source_labels: [__meta_nomad_service]
    target_label: 'service'
  - source_labels: [__meta_nomad_tags]
    regex: '.*?,environment=(.*?),.*'
    target_label: 'environment'
  - source_labels: [__meta_nomad_tags]
    regex: '.*?,metrics-path=(.*?),.*'
    target_label: '__metrics_path__'

Related to: #11465

2 months bump.

6 months bump. 🤔

I'm working on a different approach, this is still a WIP. The idea is to use Nomad's templating in combination with Prometheus HTTP discovery; this is my HCL:
job "prometheus-discovery" {
  datacenters = ["dc1"]

  namespace = "cluster"
  type = "service"
  update {
    max_parallel      = 1
    health_check      = "checks"
    min_healthy_time  = "10s"
    healthy_deadline  = "1m"
    progress_deadline = "2m"
    auto_revert       = true
    auto_promote      = true
    canary            = 1
    stagger           = "10s"
  }
  group "prometheus-discovery" {
    count = 2
    ephemeral_disk {
      size = 150
    }
    network {
      port "http" {
        to = 80
      }
    }

    task "nginx" {

      service {
        name = "prometheus-discovery"
        port = "http"
        provider = "nomad"

        check {
          name = "status endpoint"
          type     = "http"
          path     = "/ping"
          interval = "5s"
          timeout  = "1s"
          method   = "GET"
          header {
            User-Agent = ["Nomad"]
          }
        }
      }

      logs {
        max_files     = 10
        max_file_size = 1
      }

      driver = "docker"

      config {
        image = "nginx:stable-alpine"
        entrypoint = ["nginx", "-c", "/local/nginx.conf"]
        ports = ["http"]
        init = true
      }

      template {
        destination = "local/nginx.conf"
        env         = false
        change_mode = "restart"
        data        = <<-EOH
    daemon off;
    user nobody;
    worker_processes 1;

    events {
        use           epoll;
        worker_connections  128;
    }
    http {
        server {
            root /local/www;

            location /ping {
                default_type text/plain;
                return 200 "OK";
            }
        }
    }
EOH
      }

template {
        destination = "local/www/services.json"
        env         = false
        change_mode = "noop"
        data        = <<-EOH
{{- sprig_toPrettyJson nomadServices -}}
EOH
      }
      resources {
        cpu    = 100
        memory = 64
      }

    }

  }
}

I could run this and point prometheus to it (optionally through my load balancer).
Using the HCL template it then becomes trivial to filter using tags.
And of course I'll need to change the output to be the format prometheus expects.

No one wants to implement this? My Go-fu is at level 1 so I can't contribute.

The approach above works for me in prod

Hello from the bug scrub.
Awaiting review on the linked PR.


Cannot find gmp.h file

doing a sudo npm -g install embark-framework, I run into an issue where it can't find the gmp.h header file:
2 warnings generated.
  CXX(target) Release/obj.target/secp256k1/util.o
  CXX(target) Release/obj.target/secp256k1/secp256k1.o
  CC(target) Release/obj.target/secp256k1/secp256k1-src/src/secp256k1.o
In file included from ../secp256k1-src/src/secp256k1.c:12:
In file included from ../secp256k1-src/src/num_impl.h:14:
In file included from ../secp256k1-src/src/num.h:17:
../secp256k1-src/src/num_gmp.h:10:10: fatal error: 'gmp.h' file not found
#include <gmp.h>
         ^
1 error generated.
make: *** [Release/obj.target/secp256k1/secp256k1-src/src/secp256k1.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/opt/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Darwin 15.4.0
gyp ERR! command "/opt/local/bin/node" "/opt/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /opt/local/lib/node_modules/embark-framework/node_modules/ethersim/node_modules/ethereumjs-vm/node_modules/secp256k1
gyp ERR! node -v v4.2.6
gyp ERR! node-gyp -v v3.2.1
gyp ERR! not ok

GMP is installed; I'm using MacPorts, and it's located at /opt/local/include/gmp.h Is there a configuration file I can fix to get it to see that header file?

This seems to be an issue with the<EMAIL_ADDRESS>package specifically, which was fixed in later versions of that module (they're up to v3.0.1 now).
Embark is requiring that old version by requiring<EMAIL_ADDRESS>Upgrading to the latest<EMAIL_ADDRESS>fixes the issue for me.

fixed in ethersim 0.5.0 and embark 1.1.1


RDF Surfaces won't work

I recently updated my eye version, and found that --blogic switch is gone. I found the document. The document says adding --no-bnode-relabeling is needed for RDF Surfaces. However, even if using the example command (containing this switch), the example Socrates file doesn't work either.
Is there anything else needed?

The documentation is now updated and queries are now like
# Define what to send to the output
(_:S _:O) log:onNegativeSurface {
    _:S a _:O .
    (_:S _:O) log:onNegativeAnswerSurface {
        _:S a _:O .
    } .
} .

Thanks. That works now!


Unify boolean env vars

https://github.com/reflex-dev/reflex/pull/4168#discussion_r1799775136

For some env vars, we're checking against ["true", "1", "yes"] rather than just "true".
I think it'd be better to have an uniform method doing the check for boolean env var rather than duplicating logic everywhere.

by @Lendemor
Should we keep it simple, only allow "true"/"false" and raise a deprecation warning (and later an error) if something different is set?
Also let's move all env var constants to a SimpleNamespace class?

This is not fully done, however i can not reopen it.
is_frontend_only, is_backend_only, is_prod_mode, is_testing_env, ENV_BACKEND_ONLY_ENV_VAR, ENV_FRONTEND_ONLY_ENV_VAR, ENV_MODE_ENV_VAR, SKIP_COMPILE_ENV_VAR, ....

This is not fully done, however i can not reopen it.
is_frontend_only, is_backend_only, is_prod_mode, is_testing_env, ENV_BACKEND_ONLY_ENV_VAR, ENV_FRONTEND_ONLY_ENV_VAR, ENV_MODE_ENV_VAR, SKIP_COMPILE_ENV_VAR, ....

i must have missed these, do you want to do them in a PR or should i fix them soon?

I can maybe refactor it this evening, will keep you up2date about the progress

@adhami3310 i have done it locally and will push it this weekend


added avatar image to profile

Added an avatar to profile using cartoon-avatar dependency.

Please add screenshots and also resolve conflicts

https://user-images.githubusercontent.com/76491963/156932866-d9c02802-91bc-471d-9d77-57939c7824e1.mp4

@chehak123 Please look into the changes. I have attached screen record and screenshot.

Also add the Avatar generated on profile page

ok. I added the same. please look into attached screenshot, and suggest me if any improvement is needed.

@chehak123 I hope you have gone through the changes. If this pull request requires some improvement/changes, suggest the same.

Hello, @sahilg861907, really good job on the issue so far! However, here is a gentle reminder for you to please resolve the merge conflicts on your end so that we can merge your pr. Thanks.

Done!


Fix Blaze broken link

Fix  broken link for Blaze docs.

Thanks for catching.  It looks like http://blaze.pydata.org/ redirects to en/latest, so maybe use that, as it's even less likely to change in the future?

That's a good point. I have changed the link to http://blaze.pydata.org/


[Bug]: Redirection after clicking Save on the auto save modal, is incorrect.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
After adding a few details into Prod, when I click directly Staging, then click save on the modal, it goes to review page. It should take me to Staging tab.
Steps To Reproduce

Create any datasource.
Fill in all the details
Without clicking on Save, Click on the Staging tab
The Autosave modal comes up. Click on save here.
The user is redirected to the Review page
This is incorrect behavior.
The user should be redirected to Staging after clicking Save on the Autosave modal

Public Sample App
No response
Environment
Deploy Preview
Issue video log
https://ddpa7mfuvv.vmaker.com/record/T20eHKG7bVTIFpzj
Version
Cloud

Moving this to backlog as we will be picking this up with activation changes.

@Nikhil-Nandagopal  - had a query here - this issue still exists today on prod - any reason why you closed this out?

@btsgh feel free to re-open this with the right tags. It's currently tagged to deploy preview

Understood. Thanks @Nikhil-Nandagopal


Add numpy doc strings

Add numpy style doc strings to all functions apart from the main.py file.

Checklist

[X] gpt_engineer/ai.py

• For each function in this file, add or replace the existing docstring with a numpy-style docstring. The docstring should include a brief description of the function, a list of parameters with their types and descriptions, and a description of the return value.

[X] gpt_engineer/chat_to_files.py

• For each function in this file, add or replace the existing docstring with a numpy-style docstring. The docstring should include a brief description of the function, a list of parameters with their types and descriptions, and a description of the return value.

[X] gpt_engineer/collect.py

• For each function in this file, add or replace the existing docstring with a numpy-style docstring. The docstring should include a brief description of the function, a list of parameters with their types and descriptions, and a description of the return value.

[X] gpt_engineer/db.py

• For each function in this file, add or replace the existing docstring with a numpy-style docstring. The docstring should include a brief description of the function, a list of parameters with their types and descriptions, and a description of the return value.

[X] gpt_engineer/learning.py

• For each function in this file, add or replace the existing docstring with a numpy-style docstring. The docstring should include a brief description of the function, a list of parameters with their types and descriptions, and a description of the return value.

Looks like a small matching error we have: we'll fix it soon.

Never mind, it just looks like GPT-4's lack of common sense, even with CoT prompting, let me fix this.

sweep: Replace the old docstring if it already exists, otherwise, add new docstrings.

@AntonOsika Re-ran this and looks a lot better now. We're implementing pre-commit currently to solve all the black issues.

is this issue is solved or should i help!

Thanks @kevinlu1248 – great to have you here!


CortexUI : Connecting to service Error

Operating system: windows 10

When I open the CortexUI, I always see this message "Connecting to service". How I can solve this problem

For questions related to CortexUI, EmotivPRO and EmotivBCI, please contact the Emotiv customer support https://www.emotiv.com/contact-support/


HTML-CSS gets bounding boxes incorrect

The 2.5.1 patch introduced an error in the final bounding box used for formulas in HTML-CSS output.  See this StackExchange post for examples.  This is due to the changes made to recover some of the speed lost when measuring the final mathematics.  Two issues are present:  the exactW value should have been set to false before doing the final measuring (otherwise it will not remeasure), and the MathJax_Processed class should be removed before the remeasure, not after it (otherwise you get width 0).
This is also related to issue #1086, though that has additional reasons as well.

This is fixed in the issue1158 branch of my fork of MathJax.

==> Merged.

==> In test suite.


Drop the BB prefix

This PR renames and removes the BB prefix from folders and files in the root src dir.
It also drops the BB_ prefix for the path variables, but does keep an alias for the moment.
If the system detects an old folder, it'll display a message instructing the user to migrate any custom files to the new folder and delete it

Last commit adds this message which will be helpful for people who currently have an installation. I will do more cleanup / renames in a different PR, this one is already cluttered.

Looks good, trying to skim through the changes and can't see anything worrying, but wow that's a log of changed files 😁
Very good call on the 'error' message.

2 Merge conflicts
src/bb-modules/Orderbutton/html_client/mod_orderbutton_product_configuration.html.twig
src/bb-modules/Servicedomain/html_client/mod_servicedomain_order_form.html.twig

Just tried installing from the branch. It all seems fine to me.


Plugins can no longer create new Metrics Categories

Steps to Reproduce (Bug)

Create a new plugin, which adds its own instance of MetricCategory to the MetricsCategoryRegistry service that is provided in the BesuContext at plugin registry time. Give it a unique name.
Deploy the plugin to any instance of Besu.
Startup the instance, with your new metrics category specified in the list of --metrics-categories to collect data on.

Expected behavior: new metrics are produced under the new category.
Actual behavior: Startup fails, because there is no MetricCategoryConverter for the string provided as an option to --metrics-categories. Plugin registration happens AFTER those converters are setup and used to parse the supplied --metrics-categories options.
Frequency: always
Logs (if a bug)
Please post relevant logs from Besu (and the consensus client, if running proof of stake) from before and after the issue.
Versions (Add all that apply)

Software version: 24.10.0+
Java version: 21

still not working after retesting with this https://github.com/Consensys/besu-plugins/pull/new/metricsCategoryDemo

retested correctly, works fine.


Enable Fedora 40 builds for Aurora GTS

Describe the bug
Since bluefin is now on fedora 40 for the gts stream, aurora gts builds should now be enabled to fedora 40.
What did you expect to happen?
I expected this to be done immediately alongside bluefin (gnome) switched over to fedora 40.
Output of rpm-ostree status

Output of groups

Extra information or context
No response

Aurora doesnt have a GTS build tho. Maybe you are confusing it for the :stable builds? - They should be on F41 w/ the latest KDE

Oh ok, I thought that Aurora had a GTS build still. I know it had one at point which was disabled due to some specific issue with that fedora version.


num-to-words bugs

In numtowords.js:
'sexquinquagintacent' occurs twice (10 ** 471)
10 ** 531 is not on the list
'duattuornonagint' should probably be 'quattuornonagint'

Thank you for pointing this out.

Duplicate fixed in #10.
 It's more fun with accuracy, please feel free to submit pull request if you know how. Closing issue for now.

Duplicate fixed in PR #10 .
Other names fixed in PR #8
It's been while since I touched this project, thanks for the PR!


Improve/fix modal navigation

What changes are proposed in this pull request?
Fixes modal navigation during prolonged use
How is this patch tested? If it is not, please explain why.
Navigating all 200 quickstart samples from start to finish to start.
What areas of FiftyOne does this PR affect?

[x] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Summary by CodeRabbit

New Features

Introduced a new user prompt message: "slow down, you're clicking a lot" to enhance user experience.
Added a new class for improved data iteration through sections.
Enhanced label rendering capabilities with support for temporal detection.

Bug Fixes

Improved error handling in the Section class to prevent repeated requests when conditions are not met.

Refactor

Streamlined control flow and conditional checks in the Section class for enhanced readability and robustness.
Simplified the createScrollReader functionality to focus on essential scroll state management.

Improvements

Enhanced navigation capabilities with new methods for iterating through sections.
Adjusted default grid zoom range to allow for a broader range of zoom levels.
Improved cleanup logic in the Grid component for better resource management.

I like the addition of the Iter class, neat! It's a little hard to grok the relationship / ownership between different components - I guess an opportunity to improve spotlight's readme in the future.

Iter class worked out well, but is still a little disorganized. I can't be sure, but I believe this way Section instances will still be garbage collected because iteration is now scoped in a separate class. Would like to cleanup / move it out of Section and into Spotlight so only one instance is created per spotlight instance.


Add an option to disable the 😄 emoji

Would it be possible to add a configuration to remove the emoji from completion, or configure it?
That way users can set to either another emoji or an empty string.

It sounds like a good idea.
I will add it in the next version.
Wait.


Task: Improve physics synchronization

Non-authoritative peers should not simulate rigid bodies. Just apply transform updates as they're received.
When a peer becomes authoritative, enable simulation of rigid bodies and start broadcasting transform updates.

There are 3 steps:

There's a bug making it stutter even in ideal conditions.
Gravity can be different if orientation or scale is different between instances.
We need an explicit transfer of authoritative peer
We ought to implement distributed authority - individual users can take ownership over individual actors (when grabbed, for example).

I think this issue can be closed now.

Closed as we completed the physics sync upgrade


NativeConstantInvocationFixer - better constant detection

Some previous failing test cases:
M_PI::foo();

function foo(M_PI $a) {}

function foo(): M_PI {}

$foo instanceof M_PI;

class x implements FOO, BAR, BAZ {}

use X\Y\{FOO, BAR as BAR2, BAZ};

class Foo { use Bar, M_PI { Bar::baz insteadof M_PI; } }

M_PI: goto M_PI; // ;)

how about these as well than ;)
yield M_PI;
yield M_PI => M_PI;

@SpacePossum The check is done like this: "All T_STRING tokens are constant invocations, except those matching these conditions".
So the challenge is to find all cases where a T_STRING is not a constant invocation.
But of course it is good to have also different test cases for the actual constant invocations, so I will add your test case! 👍

:+1:

Shouldn't the new test cases also be added to the fixer's test, so refactoring TokenAnalyzer in the future will not mess up the specific fixer?

Indeed, they should be added to the fixer's test too.


openfire: bump to 4.6.7 to mitigate log4shell

this mitigates CVE-2021-44228

is there anything wrong with this PR?

oh sorry for the delay in checking, it took me a long time to look for updates for this application.
I just updated with the latest version of openfire and openjdk, so if you find any tweak to apply on these versions, let me know and we will apply it.


Should we rename the lib?

Even though we can publish erl-cbor under an mc_cbor or suchlike package name, it will still collide with an existing Elixir library, which may hinder adoption of a particular dependent of this library yet to be publicly released.
Since we now have total control over this library and have yet to publish its first release to Hex.pm, simply renaming it could make our lives easier.

I'm Okay with calling it erl_cbor, if naming collisions worries you. In any case we've used this strategy (mc_ prefix) in the past, for stuff not originally created by us...

In any case we've used this strategy (mc_ prefix) in the past, for stuff not originally created by us...

Sure, for the package name - the library name is a distinct matter, IMO.

I'm Okay as-is, in that case. It's unlikely you're going to use two lib.s in the same scope with the same name. Might happen, but unlikely. Also, I was making the comment for both the lib. name and the package name, and in that case we should also rename the Git repo., since it's kinda odd that 2 of these don't match.


[LAB] Week 2_Problem 2_Seohyun Lee

Problem
Week 2_Problem 2
Source Code
import torch
from random import random
from typing import Callable

##                         Problem 2                          ##
##                                                            ##
##            Arbitary x_train, y_train are given.            ##
##     In this problem, x_train is list of list of float.     ##
##   Suppose that x and y have linear correlation, y=wx+b.    ##
##           (In this problem, w will be a vector.)           ##
##     In function training(), you should return [w, b].      ##
##          In function predict(), you should return          ##
##            list y_test corresponding to x_test.            ##
##                  Made by @jangyoujin0917                   ##
##                                                            ##

# NOTE : Feel free to use torch.optim and tensor.

def training(x_train: list[list[float]], y_train: list[float]) -> tuple[
    list[float], float]:  # DO NOT MODIFY FUNCTION NAME
    # data normalization
    # 1. Prevents overflow when calculating MSE
    # 2. Prevents underfitting
    # Note that you need to convert [w, b] to the original scale.
    # w = w * (y_max - y_min)
    # b = b * (y_max - y_min) + y_min
    w = torch.tensor([0., 0.], requires_grad=True)
    b = torch.tensor(0., requires_grad=True)
    y_min = min(y_train)
    y_max = max(y_train)
    normalize = lambda y: (y - y_min) / (y_max - y_min)

    ### IMPLEMENT FROM HERE
    epoch = 30000
    lr = 0.007

    x = torch.tensor(x_train, requires_grad=True)
    y = torch.tensor([normalize(y) for y in y_train], requires_grad=True)

    opt = torch.optim.Adam([w, b], lr=lr)

    for _ in range(epoch):
        y_pred = torch.matmul(x, w) + b
        loss = torch.mean((y_pred - y) ** 2)
        loss.backward()
        opt.step()
        opt.zero_grad()

    w.data = w.data * (y_max - y_min)
    b.data = b.data * (y_max - y_min) + y_min
    return w.tolist(), b.item()

def predict(x_train: list[list[float]], y_train: list[float], x_test: list[list[float]]) -> list[
    float]:  # DO NOT MODIFY FUNCTION NAME
    w, b = training(x_train, y_train)
    return [(torch.dot(torch.tensor(x), torch.tensor(w)) + b).item() for x in x_test]

if __name__ == "__main__":
    x_train = [[0., 1.], [1., 0.], [2., 2.], [3., 1.], [4., 3.]]
    y_train = [3., 2., 7., 6., 11.]  # y = x_0 + 2*x_1 + 1 # Note that not all test cases give clear line.
    x_test = [[5., 3.], [10., 6.], [8., 9.]]

    w, b = training(x_train, y_train)
    y_test = predict(x_train, y_train, x_test)

    print(w, b)
    print(y_test)

Description
응슷응
Output (Optional)
No response

In the problem description, I expressed that w is a vector.
It means that we do not know the size of the w.

This issue is closed now because of the lack of progress.


Add more information to the readme file.

Maybe we could add in some background information about ourselves into the  README file

Feel free to add information about yourself and make a pull request. We can all do the same thing.

Make sure to pull from upstream first!
git pull upstream master

We could do this but how does this help  the overall code?
I don't mind it, just want to point out that we could probably be working on updating the readme with more documentation on how to use the code, etc. because that's more useful. But again, yes, feel free to do so. I don't mind doing so myself.


@rmwc/grid - node 16 build fails with ParserError: Syntax Error when mdc.layout-grid stylesheet imported

Node 16 'yarn build' is failing with the below error when I include @use "@material/layout-grid/mdc-layout-grid" in grid.scss file:
ParserError: Syntax Error at line: 1, column 52.
I am using the following env/packages:
Node v16
Webpack v4
react: "^16.11.0",
@rmwc/grid: "^5.7.0"
sass: "^1.62.1"
Here is the codesandbox: https://codesandbox.io/s/rmwc-typescript-sandbox-forked-76z0s3?file=/src/index.tsx
The application runs fine without any console error but yarn build fails with node 16.
Expected behavior: yarn build successfully completes.
Actual behavior: yarn build is failing with the error ParserError: Syntax Error at line: 1, column 52.
I need to stick on to node version 16 and React v16 for this project.
I also tried the following to troubleshoot this error but none of it worked so far.

upgrading @rmwc/grid to v6, v7 and to the latest version 8.
Added sass --load-path=node_modules/ src:build to build script in package.json
upgrading @material/layout-grid to latest version i.e, 14
Including @material/layout-grid/dist/mdc.layout-grid.css' instead of @use "@material/layout-grid/mdc-layout-grid"

Thanks for the issue! As we are currently working hard on getting material v14 support out, we will not have much time to solve issues at the moment.
Hopefully we will get back to this ticket as soon as possible and pull requests are more than welcome!

@ashrithapb Version 14 has been released, and we kindly request you to retest and verify whether the issue persists in the latest version


Clean up some specs

What was the end-user problem that led to this PR?
The problem was that some specs could be more readable and clean.
What was your diagnosis of the problem?
My diagnosis was that some stuff could be more explicit, some TODO's could be removed because they're already fixed, and there should not be typos.
What is your fix for the problem, implemented in this PR?
My fix is to make the obvious changes to fix what I diagnosed.
Why did you choose this fix out of the possible options?
I chose this fix because it makes the specs clear, in my opinion.

@bundlerbot r+


Custom pi/arduino controller

This service is fully modular but can i get pointed to exact points in code how are controllers getting connected etc, position part is on cameras but like the default angle and telling service about rotation pressed buttons etc
, Also will 1 accel/gyro board be enough ?
Also heard here about auto calibration mat that will also be possible.

Look at the header files in the subfolders here. They each implement IControllerInterface, which requires custom CommonControllerState, and PSMoveConfig.
Sorry I can't help you with the hardware.

Thanks but its hard for me to read thru so i need to create own subfolder in src/psmoveservice named like ArduinoController and edit cmakelist to include the folder in build but is there any structure lets say i have configured the bl adapter on arduino to pair via password and its hid enabled what serial data iam required to send thru connection and what can i delete if i dont need the usb pair thingy ? and ill probably need ti change something in config aswell.

You're not giving enough information for me to give you a precise answer. Is that all one string? Is that a structure instance and if so why use the :?
In any case, I don't have time to help. You'll have to learn how to take that data and transform it into a state representation. I'm sure you can find lots of examples on how to use C++ to parse strings, or parse data from arduino, etc.
Once you get your data, putting them into the system and predicting the pose can copy the PSMoveController or DS4Controller examples, substituting in code for working with your specific data.
Sorry that's as much as I can help for now.

Sorry I missed this post earlier. Hopefully I can answer a few questions here.

Also will 1 accel/gyro board be enough ?

That should be. The PSMove controller only has one accelerometer and one gyro.

Also heard here about auto calibration mat that will also be possible.

The calibration mat is used to figure out where the tracking cameras (PS3Eyes) are located relative to each other. When the locations of the cameras are know relative to each other you can triangulate a light source. Whether that light source is a PSMove controller or a custom LED doesn't matter.

Thanks but its hard for me to read thru so i need to create own subfolder in src/psmoveservice named like ArduinoController and edit cmakelist to include the folder in build

Correct. You'll want mirror PSMoveController.cpp and .h files in /src/psmoveservice/PSMoveController into their own ArduinoController. You'll want to look everywhere that PSMoveController class is being used and create a similar use case for the new ArduinoController. I can walk you through where this needs to happen if you have questions.

lets say i have configured the bl adapter on arduino to pair via password and its hid enabled what serial data iam required to send thru connection and what can i delete if i dont need the usb pair thingy

You shouldn't need to delete anything. The "Pair Controller" menu is only an option for devices that are plugged into the PC via USB when you run PSMoveConfigTool. Since your controller will already be paired via bluetooth it should just show up in the controller list once the PID/VID for your controller are registered here:
https://github.com/cboulay/PSMoveService/blob/master/src/psmoveservice/Device/Enumerator/ControllerHidDeviceEnumerator.cpp#L27-L29

Or lets say arduino will send thru bluetooth

I think you can make the same hid_read() call to read data from your bluetooth connected arduino. I don't know if hidapi (the library we use to access bluetooth and USB connected HID devices) does anything special to connect to hid serial connection or if it only works with HID Reports.

How can i process this info to get it working in psmove service?

You'll want to send the gyro(x, y, z), accelerometer(x, y, z), and button values over bluetooth. Once you have data being read from the controller we can talk about routing it through to the client API.
To get started I would see if you can copy and adapt test_psmove_controller.cpp to see if you can get the sensor and button data from your controller.
see https://github.com/cboulay/PSMoveService/blob/master/src/tests/test_psmove_controller.cpp

Ok so ill need to get known about bl hid vid a pid editor, iam not licensed usb vendor so i can just set vid to 777 and pid to 001 right?

Adapter yes but code you send want from me to identify bl clients not the adapter right.Also i looked up about hid and its too complicated (own rwport descriptors or looking to system as a joystick ) so will be better to work with bl serial connection is it possible?

Ok iam now out of my workshop but when i get home ill try it.

I think that depends on what kind of bluetooth profile is installed in the hardware you have connected to your arduino. For example, if you have this bluetooth hardware then you could use HID:
https://www.sparkfun.com/products/12574
But if your bluetooth hardware only supports serial connections then you'll have to use the serial connection.
If you have the right hardware it would probably be easier to communicate via HID since you already have an an example with the PSMoveController class.

Iam using hc-05 with rn42 firmware , only problem now is that my soldering iron get on fire so i need to wait even more time.

ok ive been busy since this ok my iron arrived i will practice and try making simple circuit for the controller.

OK i got back to it arduino is now sending signals over bluetooth but iam still not sure if to do it like HID device or COM communication. How you got data from psmove controller that are not visible in device and printers?

Littlebit OFFTOPIC How would you go about the same thing as psmoveservice but instead of colored bulbs etc, IR?

Čau povedlo se ti to? Mám v plánu udělat to samé. Vesměs arduino + gyro + akcelerometr a pár tlačítek+ psmoveservice kterej bude sledovat pozici. Napadlo mně nebylo by lepší použít ps move service na pozici arduino ovladače a pak odděleně tahat data z arduina přímo do freepie bridge?

I completely forgot about  it but I should get back to it. Iam already succesfully getting rotation and buttons onto bl terminal on android but windows doesnt like it so Iam looking for a way of custom bl hid descriptor.
In meantime i figured out how oculus did it and it looks  better  about accuracy harder about software as they blink bytes to camera about id of he led which can then be reconstructed to model.


libfyaml: 0.7.2 -> 0.7.3

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147223 run on x86_64-linux 1

1 package built:

libfyaml

The built binary works and is the version it's updated to.


haskellPackages.gi-gtk-declarative: fix build by disabling tests

Motivation for this change
gi-gtk-declarative requires an X11 display in its test suite.
X11 display is not available inside nix build sandbox, which makes tests fail.
Solution: disable tests for gi-gtk-declarative.
I'm not sure if manually changing hackage-packages.nix is acceptable in this case. If it isn't, I can regenerate it.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@balsoft Can you rebase this on haskell-updates, and remove the relevant packages from the broken list in configuration-hackage2nix.yaml?

@cdepillabout Done.

@GrahamcOfBorg build haskellPackages.gi-gtk-declarative
@GrahamcOfBorg build haskellPackages.gi-gtk-declarative-app-simple

Building on linux, LGTM!
Thanks for sending this!

@cdepillabout do you mind if in the future I merge such simple changes to haskell-updates myself?

@balsoft Yeah, I think I saw that you have the commit bit now, so you should be able to merge in stuff yourself now.
Although, I would prefer that you wait for a review from someone else before merging the next three or four PRs, just to make sure that everything is okay.
After you feel comfortable that no one will need to ask for changes on your PRs, then definitely feel free just merging stuff in.

Sure! Will do.


Made components for Tab navigation

@FredrikAugust: Gir component-molecule-atom strukturen mening for de to Tab-filene?

The Molecule/Atom structure you employed here looks good to me!

@FredrikAugust Just wanted to know if the new changes address your previous feedback. I found it very helpful.


Support mod-assign operator %=

fixes #555

All other assignment operators already appear to be supported and covered by tests in https://github.com/openrewrite/rewrite-kotlin/blob/95dcdeab77ec377524518f2df1fe7a9f70a7c3e4/src/test/java/org/openrewrite/kotlin/tree/AssignmentOperationTest.java.
See also https://kotlinlang.org/docs/reference/grammar.html#assignmentAndOperator.


Do not set the storage class to "default" by default ; Destroy Build Storage PVC on error

Resolves Issue https://github.com/Azure/brigade/issues/287
Resolves Issue https://github.com/Azure/brigade/issues/293
Do not set the storage class to "default" by default.
Do not set the kube storage class if it is not specified.
Destroy Build Storage PVC on error

@brandon-bethke-neudesic Merged. Thanks as always for your contribution 👍


Fix RSpec suite and add Travis CI configuration

:information_desk_person: These changes are twofold:

ensure that the existing test suite will run ( :smile_cat: ) and support the latest version of RSpec; and
configure the project so that it can run on Travis CI.

:memo: Note that this project will also need to be added to Travis CI. :smile_cat:

Passing build on Travis: https://travis-ci.org/sgerrand/cfn2dsl/builds/47895039

Awesome PR !! Big Thanks :beers:

:bow:


Assign task - Colon (:) added to completed/reopened task messages when copy pasting

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

login to staging new dot
Go to any chat with a task
Copy the completed or reopened task message using the copy to clipboard icon
Paste the copied content in the composer and observe that a colon is added after completed or reopend when pasting

Expected Result:
Pasted content should be identical to copied content
Actual Result:
Pasted content has colon
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/0513ebc1-23aa-474a-a8db-55016d754dcc
https://github.com/Expensify/App/assets/115492554/0270bbef-614d-41ed-9f91-5f0f521313f2
Expensify/Expensify Issue URL:
Issue reported by: @sofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692985594255829
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.

Colon (:) added to completed/reopened task messages when copy pasting

What is the root cause of that problem?

Currently, the copied text is from the originalMessage that has the colon (:): https://github.com/Expensify/App/blob/f67bf9f88c08fe2cebe16202d1244299a9640ea3/src/pages/home/report/ContextMenu/ContextMenuActions.js#L189
But the displayed task action message is from: ${taskStatusText} ${taskReportName} that does not has the colon (:):
https://github.com/Expensify/App/blob/f67bf9f88c08fe2cebe16202d1244299a9640ea3/src/components/ReportActionItem/TaskAction.js#L38-L63

What changes do you think we should make in order to solve the problem?

We can change the way to get the copied text to the same way that used to get the task action message

What alternative solutions did you explore? (Optional)

NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We use originalMessage to get the text to be copied here -
https://github.com/Expensify/App/blob/b95c1dd22474fb48929e78a102c1121c1e6e4360/src/pages/home/report/ContextMenu/ContextMenuActions.js#L190
and it looks like this

Observe it contains semicolon.
but while rendering it we display that separately(prop translation)
https://github.com/Expensify/App/blob/b95c1dd22474fb48929e78a102c1121c1e6e4360/src/components/ReportActionItem/TaskAction.js#L57-L63
What changes do you think we should make in order to solve the problem?
There are two approaches that to solve this -

We either change the TaskAction and add colon there

<Text style={[styles.chatItemMessage, styles.colorMuted]}>{`${taskStatusText}: ${taskReportName}`}</Text>

We change the logic for copy action here -
https://github.com/Expensify/App/blob/b95c1dd22474fb48929e78a102c1121c1e6e4360/src/pages/home/report/ContextMenu/ContextMenuActions.js#L190

For this we can create a new method in ReportActionUtils - getTaskActionText(actionName) it will return translated key for all the CONST.REPORT.ACTIONS.TYPE and then use it on above mentioned line while copying the text
What alternative solutions did you explore? (Optional)

Yep, reproducible here - adding external.

Agreed with C+ assessment.

@Ollyws @luacmartins The PR https://github.com/Expensify/App/pull/27119 ready for review

This got a bit chaotic, mostly because https://github.com/Expensify/App/issues/26571 was opened so reported before this one so the other one should take priority. That means that we won't be paying the reporting bonus for this one.
However, we DO need to fix all cases in one single PR. That means that either @DylanDylann, you fix all problems in your PR or the original contributor does it.

@pecanoro I will fix all cases in my PR. My current PR also fix https://github.com/Expensify/App/issues/26571

Awesome, glad to hear! I will close the other one!
@zanyrenney The original reporter is @oleksandr-pantsyr since this was a duplicate with the same root cause.

The PR is out of scope to fix some related issues. It caused the timeline extending beyond 3 days

I don't think we have sent any offers yet, we will handle after the regression period.

@Ollyws requires payment offer (Reviewer) $500
@DylanDylann requires payment $500
@oleksandr-pantsyr requires payment for reporting bonus $50

waiting on @DylanDylann and @oleksandr-pantsyr to accept job offers.

@pecanoro @Ollyws Could you help to check this comment https://github.com/Expensify/App/issues/26753#issuecomment-1728986092 ? Many thanks

Sorry @DylanDylann this doesn't qualify for the bonus, the rules are set on the days taken to merge. As with all issues, we try to be as fair as possible but are operating within the guidelines set.

All paid out!


[MSAA] Blocky artifacts with the even-odd fill rule

I added a new test scene for fill rules in #389. When I tried it with both 16xMSAA and 8xMSAA modes I observed some visual artifacts.
This is how it looks with Analytic AA:

This is with MSAA:

This is consistent with the even-odd rule just not being handled correctly in the msaa fine rasterizer, especially as it looks like the logic in coarse is doing the right thing for solid blocks. It wouldn't be hard to add a case, but the best solution is to write a specialized version that uses 1 bit per sample to accumulate winding numbers, using xor. The performance of that should be excellent, with no extra cost to using 16 bits over 8.


Multi datacenter support

Adds some extra internal variables to differentiate between lan servers and wan servers. This allows for basic multi-datacenter support.
Hosts in the same group will use the same encryption key. Defining multiple datacenters in the same group results in multiple auto joining datacenters.

I've tested this with bootstrap-expect, but I forgot something for bootstrapping with the default bootstrap option. (It still checks for max 1 bootstrap server over all servers) I'll make some modifications to fix this.

After that last commit it should work for both bootstrap options.

I've added the spaces around all pipe symbols/filters.
Also updated the bootstrap and client templates, seems I forgot those. We may want to try to combine them in a single template file to prevent this in the future.

👍 Excellent! Thanks again. Gertjan!


Beacon Filtering (Feature Enhancement)

Is it possible to add another filter with the option of not passing beacons heard to the LNS from the forwarder?
The device filtering works great for address/prefix range and join eui’s so far on testing.
I was hoping to see if it was possible to clamp it down a bit more for those who deploy via cellular in areas where data is expensive with the hope of saving some extra cellular data.
eg. Areas where you want some private coverage but helium is filling the RF with arial ping pong you don't care for.

Let me clarify and get back to you mate.
I think they are some kind of special frame, I will contact someone who can let me know and get back to you as soon as I can. They're a lora frame not really sure if they're lorawan or class b, but some kind of proprietary (type 0x7 iirc) frame I think.

Just got some clarification from a core dev. Hopefully this makes sense to you about the beacons looking to be filtered:
Helium uses proprietary frames (MType = b'111') for proof of coverage. In addition to the currently existing filters on DevAddrs and JoinEUIs it would be useful for us if we could filter certain m_type's too (https://github.com/chirpstack/chirpstack/blob/master/lrwn-filters/src/lib.rs#L33). That way we can filter m_type b'111' in certain areas with a high density of Helium hotspots.

I would say then probably a filter_proprietary=true setting makes the most sense, as it is the only type that can't be handled by ChirpStack because the format is unknown. The other MTypes can also be filtered on DevAddr prefix or DevEUI / JoinEUI prefixes.
I think this would be a great candidate for a pull-request:

First step would be to add this as a filter option to: https://github.com/chirpstack/chirpstack/blob/master/lrwn-filters/src/lib.rs
Then the option should be added to https://github.com/chirpstack/chirpstack-mqtt-forwarder/blob/master/src/config.rs#L106 + implemented in the MQTT Forwarder code

Would you like to create a PR for this?

I can try, rust and I don't usually play well together though :D
I will let you know how I go. If I fail, happy to wait or sponsor some of your time in the future to implement it.

I had a look over this for a few hours and have to admit its way above my level of rust skills, especially how to go about getting started with adding the filter on the ChirpStack side.
Also having major trouble getting nix to work correctly on the server to compile anything another hour so far on top down this rabbit hole. having trouble setting the default path so need to run nix-shell -p git every time to get a nix-shell and then there are missing C dependency errors.
I think I'll stick to my python lane and admire your work.

If I fail, happy to wait or sponsor some of your time in the future to implement it.

@ccall48 could you let me know if this issue should be kept open? I don't have an use-case for this myself, but I'm happy to implement this for you. For sponsor options, please see https://github.com/sponsors/chirpstack/.

I didn't get a response, close it for now, we can revisit in the future should the need arise again. Cheers


PyVISA keyword delay replaced by query_delay

So, since pyVISA 1.6 (quite some time ago), it seems that the delay kwarg needs to be replaced by query_delay - I think we just missed that.
https://pyvisa.readthedocs.io/en/latest/faq/migrating.html#removal-of-instrument-delay-and-added-instrument-query-delay
As we still have the delay defined as safe, we should change that to query_delay.
The only other place that I found (with Github) where we used that is in an Agilent device.
@cjermain is this something where we need to keep API consistency with other adapters beside the VISAAdapter, or do we just change those two spots and be done? I think the latter, just want to make sure.

Thanks for raising this @bilderbuchi. I agree that it is reasonable to replace the delay field with query_delay. It's not clear to me if the Agilent case requires the write delay, so query_delay is likely a good replacement. If that need does arise, we could always implement it with time.sleep in the adapter.


fix: oneof implementation

Description
Currently oneOf and anyOf are treated equally https://github.com/asyncapi/modelina/blob/7a2394956f8f82670e10859efd6b1c67c4487033/src/interpreter/Interpreter.ts#L85-L86
This PR aims to handle correctly oneOf in accordance to the OpenAPI specs https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/#anyof-vs-oneof
I needed to update one of the tests because there's no reason for oneOf to generate an array type implicitly in the datamodel definition
Test Suites: 115 passed, 115 total
Tests:       699 passed, 699 total
Snapshots:   123 passed, 123 total
Time:        40.322 s
Ran all test suites.

Related issue(s)

Fixes #367

Fixed in next here: https://github.com/asyncapi/modelina/pull/899


'expanded' props is always false

Is anyone having a problem with the expanded prop? It seems like it's always being overwritten to false.

Can you please provide a code sample? @alfredoreduarte

I encountered this today as well.  Here's a sample:
<Accordion className="example" allowMultiple>
    <AccordionItem title={'example_1'} expanded>
        Hello, bug 1.
    </AccordionItem>
    <AccordionItem title={'example_2'} expanded>
        Hello, bug 2.
    </AccordionItem>
</Accordion>

it gets set based on the activeItems prop from the Accordion here. That overrides the expanded prop
I think it's intended more for internal-use by Accordion - allowing it to be set could get a bit confusing. @alfredoreduarte did you have a use-case for wanting to set it? Otherwise might just remove it from docs

It might just be syntactic sugar, but if I've got the ability to have multiple items open simultaneously, it'd be nice to be able to specify which set of them are initially expanded in a more declarative way (as in the sample).  Though, I can see how that'd cause confusion and complicated edge cases.   ¯_(ツ)_/¯

I think ORing it with activeItems could still make sense. But it might raise further questions. example:
<Accordion className="example" allowMultiple={false} activeItems=[0]>
    <AccordionItem title={'example_1'}>
        Hello, bug 1.
    </AccordionItem>
    <AccordionItem title={'example_2'} expanded>
        Hello, bug 2.
    </AccordionItem>
</Accordion>

Same here. I'm trying to let my app remember which accordions a user had open since their last session.

Having the same issue here, I just want to set an accordionitem expanded and the prop is completely ignored.

Hi, I have the same issue.

The whole reason I went with this package was because I saw the expanded property.  Why would it not work?

Hey guys, I've just published v1.0.0-rc2 that should address this issue. Could you please test it and see if everything is ok? PR is here if you feel like reviewing it :) https://github.com/daviferreira/react-sanfona/pull/127
Please notice that I've removed the activeItems prop altogether, so active state should now be handled only via expanded prop.

@psimyn It goes back to collapsed state even when you use the activeElements tag.
Refer to #126 for my problem in detail. I tried to achieve the same thing using this following code:
<Accordion activeItems={expandedIndex}>
{SomeAccordionItem}
{SomeAccordionItem}
</Accordion>

I am using redux. The variable expandedIndex comes from redux state. So when a state change happens after I click one of the elements from the array inside AccordionItem, and the component re-renders, all go back to collapsed. Say if expandedIndex is 0 after a re-render, the first accordion item should be expanded right? It isn't. Tell me if I wasn't clear enough.

@wawhal can you test with 1.0.0-rc3? You will need to change your code to set the expanded prop on the items instead since I'm removing the activeItems prop. You can check this example: https://github.com/daviferreira/react-sanfona/blob/77d5cd01c82eb5c04984d6aacdcbe5234bdf8fc0/demo/index.js#L44

@daviferreira It works. Thanks for the help.

@daviferreira and @wawhal Thank you for fixing that, and wonderful package.

I feel like this might be related, but feel free to let me know if I should bring this up elsewhere. I am using this in conjunction with pagination (showing 10 accordionItems per page). When changing pages, if the first item of a page was open, the first item on the new page remains open. I tried setting a variable to false on page change (and use that variable for the expanded prop), but the accordion remains open upon page change. Any suggestions?


Add GH Action to run tests for diagnostics-app

Closing due to unavailability of proper build command.


text_splitter.py:126  Created a chunk of size  8892, which is longer than the specified 1000 causing context length error(?)

Describe the bug
Trying to pass https://python.langchain.com/en/latest/reference.html to the baseURLloader.
It failed. An error popped up for a second in the WEB UI but no error is found in Chrome browser console
In the python console I see
text_splitter.py:126  Created a chunk of size  8892, which is longer than the specified 1000
The langflow chat was cleared of all content. :(
Here is the error that showed up in the bottom left
Error: This model's maximum context length is 4097 tokens, however you requested 4266 tokens (3266 in your prompt; 1000
I increased the token size to 4000 and Langchain complained
Error: This model's maximum context length is 4097 tokens, however you requested 4329 tokens (329 in your prompt; 4000 f
Browser and Version
114.0.5735.110 (Official Build) (64-bit) (cohort: Stable)
To Reproduce
load the attached template and try to get langflow to read https://python.langchain.com/en/latest/reference.html
change from txt to json
Additional context
I'm trying to get LangFlow to teach me about LangFlow.
Vector Store of https___python.langchain.com_en_latest_reference.html.txt

I am facing similar issue as well.

The problem here lies in the TextSplitter. Try changing the chunk_size or using different separators to see if you get better results.


[FEATURE] Spec Templating

It's natural for some components to have customization points or other forms of dynamic configuration. A typical solution is to support environment variables (see #78) and/or some form of templating.
Components have props, which are (disjointly?) partitioned in to spec and state. Spec properties are expression-like and state properties are promise-like. That is, spec may be defined in terms of other properties and variables, where as state is asynchronous observations of resources.
Prior art here:

procfiles are interpreted by your shell, allowing arbitrary substitution.
docker-compose has variable interpolation: https://github.com/compose-spec/compose-spec/blob/master/spec.md#interpolation – this implements the safe environment variable subset of shell substitution syntax
kubernetes et al use Go templates

See also #78 regarding environment variables

Assigning this to myself as part of the manifest work. Manifests are HCL formatted and so there is an expression language.

+1, at present env CONTAINER_VERSION=dev exo apply docker-compose.yaml will produce something along the lines of Error response from daemon: no such image foo:: rather than resolving the environment as docker-compose will.


GraphQL: fixes and improves for contract details

Coverage increased (+0.02%) to 88.77% when pulling ccff1697310c30e5b61e6920ef99ff77b84c00a2 on fix-contracts into c4546baaa4057988188c7526b9e0bca9bc10baf2 on develop.