rls: fix build

fix copied from rustfmt

Motivation for this change
Fixes #93834
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

fixed


[Animated] Animated.multiply and Animated.add to combine animated values

This PR was created in response to feedback from an older PR: https://github.com/facebook/react-native/pull/2045
The .interpolate() API of Animated values is quite effective to accomplish transformations based on a single animated value, but currently there is a class of animations that is impossible: animations being driven by more than one value.
Usage would be like the following:
getInitialState: function() {
  return {
    panY: new Animated.Value(0),
    offset: new Animated.Value(0),
  };
}

var scale = Animated.add(panY, offset).interpolate({
  inputRange: [...],
  outputRange: [...],
});

I have a real use case for this, and I cannot think of any way to accomplish what I need without an API like this.
The animation I am trying to accomplish is I have a PanResponder being used to detect both x and y panning.

The problem comes in to play when we try to implement the "swipe to remove" functionality. We need to smoothly transition from a list of N elements to a list of N-1 elements. Right now the position and scale of an item in the list is determined by the panY and panX animation values. Once someone "swipes" an item off the list, I want to initialize a sequence of animations based on the index (which we will call i) of the card. Ideally, every card with index > i has it's position animate smoothly (probably using Animated.spring from it's current position to the position of the previous card. At the end of this animation, the card at index i will actually be removed from the list.
Currently, I cannot see this being implemented any other way other than having a separate Animated.Value from panY that is added to only the cards with index > i.
The implementation of this PR is to add two more subclasses that are similar to AnimatedInterpolation, one  for adding two animated values together, and the other for multiplying. I believe this is done in a way which could later still be compatible with bringing animations over to a higher-priority or native thread, which I know is a concern when adding animated APIs.
I'm also totally open to alternative implementations or thoughts on how this could be done differently/better!

Update: To see the effect that is able to be achieved with these methods added:

cc @vjeux not sure if you've seen this, but I know you have some thoughts on the Animated.Formula idea.

Anyone have any comments on this? I was hoping to get this merged so that I can open source a component that requires this...  Please let me know if I am going to have to find another way :/

That is sick! @vjeux: can you take this one?

@facebook-github-bot shipit


wasm: add filter_state support

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@PiotrSikora can you PTAL? This is need to get streaming message counts from gRPC stats filter.


[MM-47299] Migrated enterprise/permissions tests to Typescript

Summary
Converted the following spec files under /integration/enterprise/channel to Typescript

channel_groups_spec.js

Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21309
Release Note
NONE

Hello @gaston-flores,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/check-cla

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/249383

fyi, I'm merging this now to unblock others.


Fix doc line linking

Fixes #2024 and adds Error Reporting module.

@tseaver there we go. LMKWYT!

The test fix is my bad:  I introduced the test failure while merging / fixing up #2029.  I restarted Travis after pushing my fix.

LGTM


Update when directive to handle any number of cases.

We have two feature requests related to conditional rendering:

#511 - the false value should be optional
A switch directive.

We can resolve both of these requests by generalizing when to introspect it's arguments to operate in two modes:
if mode
When the second argument is a function or TemplateResult, we treat the condition as a truthy value and render either the second or third argument.
html`${when(condition,
  () => html`condition is true`,
  () => html`condition is false`
)}`

switch mode
When the second argument is an object, we treat the condition as simple value, and the second argument as a map of cases:
html`${when(value, {
  'one': () => html`value is one`,
  'two': () => html`value is two`,
  default: () => html`value is neither`,
})}`

In switch mode, cases can only be keyed by strings, number and symbols. If in the future we want to lift this restriction, we can accept arrays:
html`${when(value,
  ['one', () => html`value is one`],
  ['two': () => html`value is two`]
)}`

But this seems better to leave off for now.
One of the benefits of handling both the if and switch use cases in one directive is that we don't have to choose two new names, since we can't name a variable if, switch or case. It should also simplify choices.
Caching
Currently when caches the DOM created by the true and false cases. This should increase performance on fast/frequently changing values, but this might not always be the case, and it increases complexity, code size and overhead. To make complexity pay-for-play we should remove caching from the when directive and add a separate cachingWhen directive. cachingWhen can locally be renamed to when when imported:
import {cachingWhen as when} from 'lit-html/directives/caching-when.js';

I had the same ideas when doing the initial implementation. I could take a stab at this if you werent already planning on doing it yourself?

It is not clear above what happens in relation to #511 it is it permissible to miss off the third argument? when in If Mode? I have lots of cases where I've had to add
() => html``

to my when directives
Also in switch mode, a missing default should also default to effectively an empty render.
One thing I don't understand is why the arguments have to be
() => html`...`

I thought this was some sort of esoteric requirement related to caching (although isn't html itself effectively a function that returns a TemplateResult ?)  if caching isn't happening why

@akc42 both of those would be the case.

I don't really understand the suggestion of removing caching from this directive. Given that condition ? truthy : falsy-like methods of conditional rendering are already lazy (see appended code), the only real feature of this directive is that rendered results are cached (when switching back and forth).
Removing the caching feature effectively renders this directive mostly useless, in my opinion.
tag = (strings, values) => console.log(strings[0]);
true ? tag`truthy` : tag`falsy`;
// logs 'truthy'
false ? tag`truthy` : tag`falsy`;
// logs 'falsy'

That's fair. I think it's very reasonable to have a builtin helper to toggle between values. I like the suggested architecture of allowing both a binary toggle and a switch in the same directive.
We'll need a separate cached version as you suggested. Since the current implementation is already cached, perhaps @LarsDenBakker can look into modifying the current implementation to support the new switch mode and optional false value? I can write an implementation for a cacheless version, unless you already fixed this as well.

As a potential user of the switch form of this I am quite confused as to whether I should be using the cached or non cached version and what are the benefits of the cache v not having it.  The decision above to default to a non caching version will mean that the majority of users will select that which might not be the right choice.
The scenario I am trying to envisage is a page switch at the top level of my application.  For each page switch there will effectively at the top level only be one new element to instantiate, but as each one of those instantiates, it will trigger a rattle down a hierarchy of elements in their shadowRoot which will also have to be instantiated. This process will continue several levels deep (I think my biggest hierarchy is at least 8 levels deep and even at the bottom level I am referencing paper=* elements at the moment - soon to be replaced by mwc-* elements - which may go a level or so below that)
Does caching mean the difference between lit-html having to reparse the templates into strings and values before applying them v just applying them or am I misconstruing what the cache does.
If I am right - I would say that caching should be the default

I definitely what the lifecycle callbacks to run on the switch. I was planning on using these to initiate elements.  The microsoft access application that my web app will replace/sit alongside uses a psuedo lock (a table in the database) when a user starts editing one of the key entities, and releases it when complete.  Some database stored procedures interact with this to queue updates when changes have to be made in parallel, the unlocking then applies the queues updates.
My application has to do the same when a particular page is entered and when the user leaves it.  At the moment I detect activation by a number of means (active attribute on the selected element, a distributed route passed in to the element which has an active property).   I can replace this with a consistent use of connectedCallback and disconnectedCallback
Why would caching prevent these from running, they are taken out of the dom when held in the cache aren't they, and then replaced back again when reselected by the when?  I need to understand and I don't yet!  I suppose have to try it and single step through with the debugger - that normally helps me to understand these things.

Actually what I said isn't entirely correct. When caching, connectedCallback and disconnectedCallback are re-run but the constructor is not.
Consider this simplified example:
Non-cached:
// create and render element-a
const elementA = document.createElement('element-a');
document.body.appendChild(elementA);

// remove element-a, create and render element-b
document.body.removeChild(elementA);
const elementB = document.createElement('element-b');
document.body.appendChild(elementB);

// remove element-b, create a new instance of element -a
document.body.removeChild(elementB);
const elementA2 = document.createElement('element-a');
document.body.appendChild(elementA);

Cached:
// create and render element-a
const elementA = document.createElement('element-a');
document.body.appendChild(elementA);

// remove element-a, create and render element-b
document.body.removeChild(elementA);
const elementB = document.createElement('element-b');
document.body.appendChild(elementB);

// remove element-b, don't create a new instance of element-a
// but re-append the elementA which was created above
document.body.removeChild(elementB);
document.body.appendChild(elementA);

As you can see in the second example, we keep a reference to the elementA variable. When re-rendering elementA we just append that one to the DOM again instead of recreating the nodes. Similar logic happens inside the when and cachingWhen directives.

Yes - thats makes more sense now.  It was what I was expecting.  In my case the disconnectedCallback will reset all the properties that effect that sort of thing and then the next connectedCallback will change the properties to the new conditions so a new render will follow shortly afterwards to update the values.

So we'e been talking on the team about the right factoring to have for a number of different features that the über when() directive have:

if
switch
caching
laziness
syntax preference

It may be convenient to get all of these in one place, but when trying to figure out exactly how it should work, it all depends on why a user used then directive in the first place. It could be a user reached for a syntax they liked, and didn't know they were getting caching and it's memory overhead. It seems dangerous to tie all these together, and see the discussion here about caching by default or not.
It's useful to ask why when() is a directive at all. It's really only for the caching which needs a part reference for keying state and getting direct access to the DOM. If not for that when() could be a simple function.
So... what we're considering now is just offering a cache() directive. It would keep DOM in a cache keyed off the Part and TemplateResult.template. We can then use cache() with any control flow expressions, including ternaries, Array.find, app-logic in methods/functions, or very simple if/switch/pick utilities.
We'd probably not vend a when() function, because it's sole use would be for syntax/laziness on the JS side - ie, it'd be solving a JavaScript problem in general, not a templating problem, and thus be out of scope for lit-html. It'd also be very trivial to create.
Some examples:
// caching ternary
html`${cache(v ? html`true case` : html`false case`}`

// switch as object notation:
html`${cache({
    one: html`case one`,
    two: html`case two`
  }[v]}`

// switch as object notation:
html`${cache([
  ['one', () => html`value is one`],
  ['two': () => html`value is two`],
].find(([c]) => c === v)}`

// use a method
html`${cache(this.getPage(routeName))}`

// using lodash cond
html`${_.cond([
  [_.matches({ 'a': 1 }), () => html`matches A`],
  [_.conforms({ 'b': _.isNumber }), html`matches B`],
  [_.stubTrue, () => html`no match`]
])({ 'a': 1, 'b': 2 })}`

This generalizes better, and we can add back when(), but a much simpler version, if there's a need for it.
Thoughts?

Yes. This exactly echoes my original sentiment on caching being the only reason a when directive is needed.
It is a great idea to rename the directive to cache, since that name is more in line with its intended function. The provided examples all look very nice and clean, and I like how the cache directive itself makes no assumptions on the structure of its arguments, it simply gets passed a TemplateResult, and applies caching when passed a different one.
Thumbs up from me

I like the cache approach better as well.
I do think the uncached when is something that would be useful to offer from the lit-html library as a utility/helper function. It's a pattern that is encountered by a lot of users writing lit templates, so it will be helpful for promoting writing elegant code.

As I understand more about caching v not (thanks @rupin I watched a video of your yesterdays seminar and it help a lot) I think there are subtle differences been caching and not caching.  I think my example of doing away with the repeat directive may be flawed - in that the cache is about storing a complete hierarchy of nodes not a template result
What if that example were written like
html`
<ul>
  ${cache(myArray.map(item => html`<li>Loop using ${item.name}</li>`))}
</ul>
`

I think it important that what a cache is doing and not doing should be quite carefully documented around this particular directive as I don't think it is easily understood

Then, if the variable changes again, it can take that cached DOM and place it back. So the purpose of the cache directive is to be able to switch between different templates without having to destroy and rebuild the DOM each time.

But the template in that cache will still be evaluated / updated ... right? Otherwise that might be confusing and a source of bugs or unexpected content.
Given this example:
${ cache (userLoggedIn ?
        html`<span>${ userName }</span>` :
        html`<a href="/login">Log in</a>`
   ) }

If the userLoggedIn flag was true, so userName was rendered and then both were changed and then userLoggedIn changed back to true, the new value would be rendered ... wouldn't it?. Or does it effectively make the whole node branch static?

Yes, the template will be evaluated and updated as usual. The only difference is that instead of cloning a new section of DOM from the template, and rendering the values into that new DOM, it re-uses the old DOM that was previously rendered in that place.
Again, normally when you switch between two templates (imagine the above example without the cache directives), all existing DOM nodes are destroyed. So when you switch around and render a template that you had previously rendered, those DOM nodes no longer exist, and the Part will have to clone the template again to create new DOM, and render the values into that. The cache directive makes it so that cloning the template again is no longer necessary, because it keeps the previously rendered DOM around instead of deleting it, and uses that to render the values to.
Remember that with lit-html, updating values is really cheap, because it re-uses the static parts of the DOM, but creating the DOM in the first place is just as expensive as with other systems. So if you keep destroying and creating DOM, it's about as efficient as using innerHTML.

@ruphin As I was writing my entry above I kept getting stuck with this difference between cached and non cached nodes.  When a TemplateResult is created a dom-tree with all the Parts replaced with a comment node is created and attached to a <template> tag which is then stored in the TemplateResult  So when you switch around during re-render you say all the DOM notes are destroyed this isn't entirely true (is it)? Some (most? - certainly in our examples above most are) of the parts are themselves TemplateResults and they too will have a dom-tree attached to them.
So recreating a huge hierarchical dom-tree will involve fetching lots of partially cached existing dom-nodes and joining them together.  I don't know if that is expensive?.  Only at the very leafs of the tree is it likely there will be some parts that create dom nodes from scratch - and those are ones that are just as likely to need changing again.
In @CaptainCodeman 's example above the only node being recreated is the text node of the username and that likely will be changing anyway.
So in theory caching sounds nice but is it in practice.

That is actually not correct.
TemplateResults do not have DOM trees attached to them, they only have a reference to the Template they represent. Only a TemplateInstance actually holds a part of DOM. In the example above, without the cache directive, the entire DOM associated with the template has to be re-instantiated, including the <span>.
When rendering templates, DOM nodes are only re-used when you render the same template. If you render a different template, it destroys the old DOM, and instantiates the new DOM from the new template.
Take the following example:
html`
  <div>
    ${ condition ?
      html`<p>Hello ${ name }</p>` :
      html`<h1>Goodbye ${ name }</h1>`
    }
  </div>
`

When you render twice, and condition stays the same, the only thing that changes is the content of the TextNode that represents the name variable. When a Part renders a TemplateResult with the same Template as the previously rendered TemplateResult, it will keep the DOM and only update the values inside.
When you render twice, and condition changes, all the DOM nodes inside the <div> will be destroyed (Including the <p> or <h1> nodes), and a set of new nodes will be cloned from the Template that is being rendered. Then, the name variable will be rendered into the right TextNode. It doesn't matter how many times you switch between condition being true or false, it will always destroy the old nodes and re-clone from the template. When a Part renders a TemplateResult with a different Template as the previously rendered TemplateResult, it always destroys all currently rendered content, clones the Template from the new TemplateResult, inserts that into the tree, and updates the values into it.
The cache directive makes it so that the Part will not destroy the currently rendered content, and instead place it in a cache to be re-used if it is rendered again in the future.

Thanks - now I understand that - I must go and read the code again - I misunderstood.

For what it's worth, trying to write about this, and it is far, far harder to write about cache comprehensibly than the the caching when. Caching when is a logical extension of the ternary, and it's easy to explain that it caches the DOM for both branches.
cache is really logical... If you understand Part and TemplateResult.
Not sure if I have a conclusion here, except that I'm going to move this out of the section on conditionals and document it somewhere else.

Any updates to the cache coming soon - both #565 and #606 are causing me issues and at the moment I have to patch my version of lit to fix one and use a workaround for the other.  The when directive goes away when cache comes so almost no point in fixing the above two.


Increment version for monitor releases

Increment package version after release of Azure.Monitor.Ingestion

API change check
API changes are not detected in this pull request.


[New game]: Bubble Hit #3100

🎮 Game Request
Game logic and basic description:
The objective of the game, "Bubble Hit," is to pop as many bubbles as possible within a 60-second time limit to earn points.
Bubbles will appear randomly on the screen, and players must click or tap on them to pop them.
Point down the features
Game points:

Time Limit: Built-in 60-second timer adds urgency to gameplay.
Scoring System: Earn 10 points per bubble hit, motivating players to achieve high scores.
Responsive Design: Compatible with various devices for seamless gaming experience.
Visual Feedback: Immediate feedback enhances player engagement.

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @prachi-kurmi !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hello @prachi-kurmi, Time's up!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @prachi-kurmi ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

@kunjgit, I apologize for the delay—I had some issues that kept me from contributing on time. This was my first time contributing, and I learned a lot. Thank you for all your support and guidance. 😇
I’m looking forward to bring new ideas in future and will complete them on time. ⏰


Build default taxonomy from CSV

Is your feature request related to a specific problem?
It would be easier for to modify the default taxonomy if it was stored as CSV files and then loaded into Python objects at runtime

This has been done, yes?

It hasn't, we're still building from Python directly


client module support Multipart request body

Current light-4j http2Client module doesn't support Multipart request body.
And the request body is processed by StringWriteChannelListener which is string base only.
Undertow client ClientRequest support add attachment with request body. But  the service API maybe need call other service which need Multipart in request body, for example:
pdf name and meta data in one part of request body with Json format
pdf content as byteArray in another part of the request body.
We probably can refer to apache http client:
https://hc.apache.org/httpcomponents-client-ga/httpmime/apidocs/org/apache/http/entity/mime/MultipartEntityBuilder.html

In the current client module, it support the binary response (image, pdf ...) in the response attachment by byteBufferClientCallback (issue #625) .
But it may need add support for request body with binary as well (multipart-requests)
https://swagger.io/docs/specification/describing-request-body/multipart-requests/
requestBody:
content:
multipart/form-data: # Media type
schema:            # Request payload
type: object
properties:      # Request parts
id:            # Part 1 (string value)
type: string
format: uuid
address:       # Part2 (object)
type: object
properties:
street:
type: string
city:
type: string
profileImage:  # Part 3 (an image)
type: string
format: binary
Currently ClientCallback read request by String format only (StringWriteChannelListener). It should have option to read as byte array.

@chenyan71 Yes. We need to support the binary request body. The problem we had before is that we need to ensure that both client and server need to understand the format of the body in order to parse it gracefully. The swagger multipart-requests is a great example that we can implement so that the server has some information to parse the body. The only problem we have is that the body-parser today doesn't have the knowledge of the specification yet. Do you have any suggestions for the implementation?

@stevehu I don't think framework need know the specification definition. It is between server and client.
For example, the spec define the request need file name and pdf body, the client request need wrap the two fields and add needed header attributes based on the spec. Server side will parse request body based on the spec which it defined.
The problem is current client module only support String as request body

@chenyan71 I have migrated your pdf client demo application from 1.6.x branch to master at https://github.com/networknt/light-example-4j/tree/master/client/pdf
I tried all the test cases and they work very well. My understanding is to move the logic to the light-4j. Am I missing something?

Yes, will move the some implementation to light-4j.
The sample provided the reference for Multipart request handling by using HashMap:
HashMap<String, Object> requestMap = new HashMap<>();
requestMap.put("name", "test_sample.pdf");
requestMap.put("profileFile", IOUtils.toByteArray(resourceAsStream));
connection.sendRequest(request, createClientCallback(reference, latch,ByteBuffer.wrap(SerializationUtils.serialize(requestMap))));
But user can define their request object instead of Map if needed

 client module support Multipart request body light-4j master

 client module support Multipart request body light-4j 1.6.x


GPT Adding Comments Cause Errors When Updating Files

Usage: aider via terminal in vscode, debian
Error:
The error Malformed response #2, retrying...
InvalidEditBlock: edit failed!
 does not contain the exact sequence of HEAD lines you specified.
Try again.
DO NOT skip blank lines, comments, docstrings, etc!
The HEAD block needs to be EXACTLY the same as the lines in assets/js/output.js with nothing missing!
 does not contain these 2 exact lines in a row:
// Step 1: `
Issue: The error causes a loop where aider keeps trying to fix the issue with updating the file. This burns through tokens fast and is incredibly expensive as it keep generating the same old code, then the new code updates, etc. If it does not catch the issue on the second go around, it will keep trying.

Thanks for trying aider and reporting this issue.
Unfortunately even GPT-4 gets confused sometimes. You can always safely halt it by hitting CONTROL-C and then tell it to stop doing whatever it's doing wrong.
Another thing to try is to add fewer files to the chat, so GPT can focus more on the specific files you want it to change.

I'm going to close this issue for now, but feel free to re-open or file a new issue any time.


Drawer reference documentation could be improved

Is your feature request related to a problem? Please describe.
In general, the reference documentation isn't too useful and I end up having to either cross-reference the examples and hope it covers what I want to do, or reference the actual source code to a component. It's been rare for the reference documentation on its own to actually be enough to let me figure out how to do what I want to do with a component.
Since this is too general of an issue, I figured I'd focus on the Drawer component as it demonstrates a lot of the issues that I see, and maybe fixing that can be expanded in a general way to fix many of the other reference pages as well.
Describe the solution you'd like
Take a look at the Drawer documentation. There are several ways that important information is missing:

[ ] 1) Fixed: If true, drawer will be fixed. Well, ok, that much is clear because it's a boolean. But what does it actually mean for a drawer to be fixed?

[ ] 2) ChildContent is present as an attribute, but this is not how that particular property works in Blazor. Perhaps this can be special cased in the documentation to say that this component supports rendering child component content, and what the behavior of that is for this specific component.

[x] 3) Anchor, Color, Variant, Breakpoint, ClipMode are all enums but the possible enum values and what they do are not mentioned. Perhaps these can be clickable to visit a reference page for those enum values. If there's any special casing for what those enum values mean for this particular component, or if only particular ones are supported, then that should mentioned in the documentation.

[ ] 4) There are related child and parent components that are commonly used or even expected to be used in conjunction with the Drawer component, such as MudLayout, MudDrawerHeader, and others. Having links to those components with an idea of whether they're generally a parent, child, or sibling component would be helpful for context and easy navigation.

[ ] 5) Drawer inherits from MudComponentBase and that should be mentioned. If it inherits from a different base component there could be a link to that. If any components inherit from it, there could be a link to those as well.

[ ] 6) A link to the sourcecode of the razor and (cs)[https://github.com/Garderoben/MudBlazor/blob/master/src/MudBlazor/Components/Drawer/MudDrawer.razor.cs] file on GitHub could be useful if all else fails.

Describe alternatives you've considered
n/a

I discovered now I do not have to use MudDrawerContainer inside MudLayout

I'll be revisiting all XML documentation over the next few months, so I'm happy to take this on.  Thanks for taking the time to report this issue!


[Event Request] Codeunit 9510

I need OnBefore-Publishers in the functions "IsConfigured" and "SetProperties", for example, OnBeforeCheckIsConfigured(DocumentServiceRec) and OnBeforeSetProperties(DocumentServiceRec), so that I can set filters to DocumentServiceRec.
Thank you so much.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


badge the devices tab for new_device messages from gregor

update badge state with new_device messages from gregor (see: https://github.com/keybase/keybase/pull/2969)
use the count to badge the devices tab
dismiss those messages after going to the devices tab (this logic was copy-pasta from the git tab)

Do you think once the user goes to the device tab, they should see which devices are new?

@patrickxb maybe. i'd probably need help with that. or maybe it should be a desktop ticket. if we want to do that, i can beef this up to pass along more than just a count of the new devices. that's easy enough.

just spoke to chris. i'm going to push a list of the new devices into the badge state instead of just a count. and then either remove the UI badging and unbadging logic or see if i can get a little new label to show up.


Update Projects view filter bar

Closes RHOAIENG-10496
Description
Update the Project table Filter design pattern:

Use the attribute value filter and chip component

Allow filtering on both Name and User at same time, maximum of one of each

Allow clearing of all filters

Allow clearing of a single filter in the chip

Switching between filter type will retain the input in each field. For example, if I choose "Name" and type "admin", then switch to "User" and type "David," and then go back to "Name," I’ll still see "admin" in the search bar under the "Name" filter.

Adjust the old “No results” to the PatternFly updated no results.

How Has This Been Tested?

Tested Manually, updated e2e tests
Test Impact
Updated e2e tests
Screen shots

Request review criteria:
Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal

/lgtm
/approve


.gitsubtrees status?

Great project!  Any status update on adding the .gitsubtrees / git stree sync functionality mentioned on https://medium.com/@porteneuve/mastering-git-subtrees-943d29a798ec ?

Hey!
I'm unfortunately underwater these days with many, many regular-job
projects that need to move forward.  git stree work remains very high on
my not-regular-job list, so expect some good work between now and late
June, but unfortunately not sooner than that.
--
Christophe Porteneuve
Founder & CTO, Delicious Insights
<EMAIL_ADDRESS>+33 662 059 656

No problem, I totally understand.  Keep up the great work!


MKOB - GUI on Mac is not as clear as on Win

When running on a Mac the GUI has a lot of boxes, buttons, etc. that don't display (or are very faint) when compared the the GUI on Windows (I haven't checked yet on Linux).

Resolved by doing an installation of Python from python.org rather than using Brew. This also cleaned up errors that were occuring during launch.


Sequelize models from querys should be turned into actual ModelSafe models

Currently ModelSafe models are only being used in the context of the type system. That means if you define getters or helper functions on a decorated model class, they won't be available after using a database query because the data returned is actually a Sequelize model (with all the relevant attributes still available, however). We should use deserialization with validations disabled. See creativecuriositystudio/modelsafe#2

Part of 1.0.0-alpha.1


General improvements to Free in core

This commits brings over the general purpose improvements to core that were done in the web branch (which is currently blocked on more work that needs to be done on Free in core) so that they can be available as soon as possible for projects that depend on Quasar as a library. Also to avoid conflicts with current work on Free in master.
This commit aggregation is co-authored with @wemrysi, specifically the part on the addition of the Explain term to the QueryFile algebra.

@drostron Sorry about that, forgot to look at the results of testing it before pushing. Just addressed that, so hopefully should build cleanly.

Current coverage is 81.98%

Merging #1034 into master will decrease coverage by -0.16% as of 03ace4a

@@            master   #1034   diff @@
======================================
  Files          128     129     +1
  Stmts         8691    8756    +65
  Branches       286     286
  Methods          0       0
======================================
+ Hit           7139    7179    +40
  Partial          0       0
- Missed        1552    1577    +25

Review entire Coverage Diff as of 03ace4a

Powered by Codecov. Updated on successful CI builds.

@mossprescott Assigning you as I am currently pairing with @drostron and thus stopping him from reviewing the PR :smile:. Plus I have another PR for him to review coming soon.

@mossprescott I think I addressed your concerns.

LGTM. Sorry for the delay.

Not a problem! To be expected when you open a PR on Christmas eve! :stuck_out_tongue:


Add Sublime3 to Terra

Merged to: https://github.com/juno-fx/Terra-Official-Plugins/tree/pack-additional-software
Closing.


Talk to SIG Releng/Tinkerers about CI for go binaries

Adding the CI for helm-values-gen and schemalint is overly complicated.
We should investigate how it could be done more simple.

@mogottsch is this still relevant ?

No, I'll close it.


How about adding a webhook ?

Adding a webhook to your project can significantly enhance system.
example:
Add a new router transcribe/webhook that will accept the same data as the original, but with the addition of a URL. Also, create a task for sending a notification and set the maximum number of concurrently executing tasks in the configuration.
response :
{
    "file_name": "example_audio.mp3",
    "type": "text",
    "result": {
        "text": "transcribed text"
    }
}

{
    "file_name": "example_audio.mp3",
    "type": "json",
    "result": {
        "json" : "original response"
    }
}

{
    "file_name": "example_audio.mp3",
    "type": "verbose_json",
    "result": {
        "verbose_json" : "original response"
    }
}

{
    "file_name": "example_audio.mp3",
    "type": "vtt",
    "result": {
        "vtt" : "original response"
    }
}

{
    "file_name": "example_audio.mp3",
    "type": "str",
    "result": {
        "str" : "original response"
    }
}

{
    "file_name": "example_audio.mp3",
    "type": "error",
    "result": {
        "error": "File processing error: invalid format"
    }
}

I can see how this feature could be useful, but this isn't something I intend to add in the near future.


stan-wasm-server: proof of concept

Here's a proof of concept for a dockerized server that can compile stan programs into wasm
Instructions
Start the web UI with test=1 query parameter. For example http://<IP_ADDRESS>:5173/stan-web-demo/?test=1
Then follow the instructions on the page which will tell you to build and run the docker image listening on port 8083
Click the button to try it... and keep you eye on the terminal running the docker container.
The resulting .js and .wasm will be shown in the browser dev console to prove that it "worked".
See the source code for the hard-coded stan program used.
The results are cached on the server until you restart the docker container.
@WardBrian @jsoules

This is super cool!
Adding this code to the bottom of the handleClick callback seems to "just work" in terms of loading the module:
const js = await import(/* @vite-ignore */ downloadMainJsUrl);
const module = await StanModel.load(js.default, null);
console.log(module.stanVersion());

So this proof of concept has already answered basically all the technical questions I had in terms of doing something like this, the rest is just UI work, polishing it up, making it more robust, etc.

Adding this code to the bottom of the handleClick callback seems to "just work" in terms of loading the module:
const js = await import(/* @vite-ignore */ downloadMainJsUrl);
const module = await StanModel.load(js.default, null);
console.log(module.stanVersion());

Great! But I don't see where you are loading the wasm...
We also need to think about where/how to deploy the service. Heroku is not flexible enough to handle such a heavy container. I think the best bet is to get a VPS on something like akamai and use cloudflare for the domain and cert. I'll try to set it up later today.

I think focusing on local deployability is fine in the short term. That way a professor could run it for their students during a workshop or something.
This also lets us ignore the DDoS-ability for a little while

Oh, and I am also a bit surprised that managed to load the wasm as well. The JS bundle has some (overridable) logic in it for this, but I wasn't sure if it would naturally work in a fetch or not.
If you add -g to the CXXFLAGS in make/local, the generated JavaScript gets a bit more readable to answer questions like this

I think focusing on local deployability is fine in the short term. That way a professor could run it for their students during a workshop or something.
This also lets us ignore the DDoS-ability for a little while

I think it's quite non-trivial for a professor to host this in a way such that students will be able to access it... both within the classroom and especially remotely. I'm inclined to try to set up a public instance at least for dev purposes with a secret passcode to reduce the chances abuse. I feel like this would simplify the development of the frontend, and allow easy sharing of previews.

I think if someone was hosting their own they would really only care about the same network, not anything remote. Its very common to host something like a Stan workshop for a couple hours with everyone in the same room

Okay I'll hold off for now (although I do think this would be useful for sharing).
I pushed to dockerhub and updated the instructions in the TestComponent of the UI to be
docker run -p 8083:8000 -it magland/stan-wasm-server:latest

Not sure if you wanted to merge this in with what you have done.

Closing - for posterity, this became https://github.com/flatironinstitute/stan-playground


auth.key && dc.save

Thank you for your open source.
In the Config.java , you read two files , auth.key and  dc.save .
Need I create these two files by myself ?

No, they are automatically created by the lib :)


Add toggle command to Clear cache and Toggle fold state at once

    If I use `Inline Fold: Toggle` in VSCode Command Palette, it works fine (i.e. unfolds) on the current file. If I open another file, it goes back to folding everything...

As a feature request, I think the behavior of that Toggle action should be permanent. In lieu of that, introduce two new actions like:

Inline Fold: Disable until I turn it back on
`Inline Fold: Enable until I turn it off

Originally posted by @corysimmons in https://github.com/moalamri/vscode-inline-fold/discussions/101

@0f1

@0f1 the first solution is working, but it take you back again to per file folding state.
So I added an option to opt out from per file folding.
That way we don't have to register a command & it won't break anything since the default option is true.
@corysimmons in order to fit your use case you can use the latest update v0.2.3 and set the option inlineFold.togglePerFile: false to opt out from the default toggle action (per file).

Amazing! Thank both of you so much for the great maintenance of this very helpful extension! I'll check back in if it doesn't work.


grpc.node support for electron 1.7.x

Please rebuild grpc.node for electron 1.7.x versions, I depend on this module critically. please help

I need the grpc.node to be compiled for the electron ia32 1.7.9 please help. This is a barrier for my production.

Nice thanks for your effort, I hope will be fixing it soon

Hello,
Can we please add support for upcoming electron version 1.8. Electron releases every upgrade to chrome. How we can for upcoming versions in future.
Or is there any things can be done to try rebuilding from our end.

Thank you for your patience. I have uploaded electron 1.7 binaries for<EMAIL_ADDRESS>You should be able to install it now.
I will try to add support for new versions of Electron in a more timely manner in the future.

Thank you so much for your work @murgatroid99


Add ktor serialization feature to pre-defined dependencies

🚀 Description
Adds the Ktor serialization feature/plugin to the predefined Ktor dependenceis
🧪 How Has This Been Tested?
Not tested
📦 Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

[x] I have read the guidelines for the development process
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Hello, please run the tests and commit the changes.

I've merged your changes.
Thanks for your contribution @Kantis!


Remove unnecessary semicolons

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 56.845%

Totals

Change from base Build<PHONE_NUMBER>8:
0.02%

Covered Lines:
11880

Relevant Lines:
19869

💛  - Coveralls


same ss_summary as artifact

A recent pull request failed, but a comparison of the failed quantities showed no differences when run on my local Windows machine.  Is it possible to access the ss_summary.sso files from the github flow runs?  Or perhaps to save that file from the "simple" run as an artifact?

@Rick-Methot-NOAA how soon do you need this? I know @k-doering-NOAA in on AL the rest of this week. It looks like I can change the code to at least copy the simple ss_summary.sso file over for you if you need it immediately. Though @k-doering-NOAA is really the expert here wrt these workflow files.

Thanks Kelli.  If this is easy for you, I could use the base and test
ss_summary files from simple for the most recent pull request.  But no
rush.  It can wait til next week.
On Wed, Nov 24, 2021 at 11:22 AM Kelli Johnson @.***>
wrote:

@Rick-Methot-NOAA https://github.com/Rick-Methot-NOAA how soon do you
need this? I know @k-doering-NOAA https://github.com/k-doering-NOAA in
on AL the rest of this week. It looks like I can change the code to at
least copy the simple ss_summary.sso file over for you if you need it
immediately. Though @k-doering-NOAA https://github.com/k-doering-NOAA
is really the expert here wrt these workflow files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/ss-test-models/issues/14#issuecomment-978158516,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4ICDEQPVCW6JSGNUR2TUNU3PZANCNFSM5IWZOJ6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@Rick-Methot-NOAA I made the change that I "think" is needed. I am currently running it on the main branch to see if it works and if it successfully saved the file, then I will start it on your pull request.

@Rick-Methot-NOAA my second attempt was successful (nmfs-stock-synthesis/workflows@86606af) and the file for the main branch is available. I am running the workflow for the pull request right now. I think we should leave this issue open in case @k-doering-NOAA wants to make any changes.

Thanks Kelli.
A character - by - character comparison between this ss_summary and the ss_summary produced on my local machine showed identical parameter estimates with identical parameter variance.   This difference is in variance of the derived quantities and now  I see that variance of derived quantities is flawed on my local machine also.
Must have messed up the order of ops somewhere in equil_calcs.   :(

Thanks @kellijohnson-NOAA for modifying the workflow!
@Rick-Methot-NOAA, for the long term, we can certainly save the summary files, if they turn out to be helpful - I was just trying to keep the artifact size down, but if we need more output, I think that should work fine!

Turns out that I did not need the file, but needed it this once in order to
come to that realization.
I routinely do a character-by-character compare for at least one ss_summary
and sometimes for the report.sso to be sure nothing gets missed by the
numerical compares we do.
In that regard, I think it better to do comparisons for the last year of
the forecast, not the first year, as I see that some differences don't
creep in until forecast recruitments enter the population.
On Tue, Nov 30, 2021 at 6:35 AM Kathryn Doering @.***>
wrote:

Thanks @kellijohnson-NOAA https://github.com/kellijohnson-NOAA for
modifying the workflow!
@Rick-Methot-NOAA https://github.com/Rick-Methot-NOAA, for the long
term, we can certainly save the summary files, if they turn out to be
helpful - I was just trying to keep the artifact size down, but if we need
more output, I think that should work fine!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/ss-test-models/issues/14#issuecomment-982694921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPV4IFX67AAYJ4XKGYPNKDUOTOL3ANCNFSM5IWZOJ6Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Add order submodule

Is this PR dead?

Is this PR dead?

hopefully not
it is still required imho
but tbh, opening a new one is probably easier than fixing the conflicts 😂

new one without conflicts


API Endpoint Review and Cleanup for /credentials

Description
Cleaning up and review of the APIs at the /credentials path is required wrt the Sunbird RC Swagger docs along with an evaluation of APIs that are completely or partially unimplemented.
APIs

Obtain Credentials by Subject or Issuer
Currently implemented here.
The request body implemented differs from request body expected according to RC Swagger Docs, as such the DTO may be needed to be updated.

Obtain Credential by ID
This API (implemented here) is currently bugged and returns only an empty array.
The RC docs again stipulate additional header parameters here which are not being handled currently.

Issue a Credential
The request body currently takes in the entire credential schema when RC docs expect only a string.

Update Credential Status
This API endpoint is currently not implemented.

Derive a Credential
This API endpoint to derive a credential is currently not implemented.

Render a Credential
This API is currently bugged (returns 500 on first call, but rendered PDF on the second). The current implementation also has other issues for which I'll create a dedicated issue soon.

Tasks

[x] Review and modify request body for API to Obtain Credentials by Subject or Issuer
[x] Review and modify request body for API to Obtain Credential by ID
[x] Review and modify request body for API to Issue a Credential
[x] Fix the bug that returns an empty array for API to Obtain Credential by ID
[x] Implement or discard API to Update Credential Status
[x] Implement or discard API to Derive a Credential
[x] Review and address the bug in Render Credential API

All of these have been addressed and closed


fix: session passing

Pass the session correctly to the device

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.28%. Comparing base (768020d) to head (619f1fb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   97.28%   97.28%
=======================================
  Files          17       17
  Lines         810      810
=======================================
  Hits          788      788
  Misses         22       22

Flag
Coverage Δ

unittests
97.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Extension "ms-vscode.references-view" Request Error

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:
OS Version:

Steps to Reproduce:
"Error: Request https://marketplace.visualstudio.com/_apis/public/gallery/publishers/ms-vscode/vsextensions/references-view/0.0.30/vspackage failed with status code:404"

Find an Internet Explorer, input "https://marketplace.visualstudio.com/_apis/public/gallery/publishers/ms-vscode/vsextensions/references-view/0.0.30/vspackage";
The result: "{"$id":"1","innerException":null,"message":"Resource not found","typeName":"Microsoft.VisualStudio.Services.Gallery.WebApi.ExtensionAssetNotFoundException, Microsoft.VisualStudio.Services.Gallery.WebApi","typeKey":"ExtensionAssetNotFoundException","errorCode":0,"eventId":3000}"

@jjqk this package was recently unlisted from the marketplace because it ships inside of vscode now. Is there a reason you're doing this?

Packaging command ”yarn gulp vscode-win32-x64“ will fail upon extension "ms-vscode.references-view" request error。As for packaging， refer to https://github.com/microsoft/vscode/wiki/How-to-Contribute
log.txt

@jjqk please make sure to be on the latest commit of our main branch. the download step of the extension is there anymore

@jrieken You're right, our code change is based on an old version of vscode main branch. Days ago, it went well with packaging. All of a sudden, packaging seems impossible. Migrating our code change to the latest may take a long time. Is there any way/walkaround to finish the packaging for now (passing GitHub account to "yarn gulp vscode-linux-x64" as a parameter for example?)?  Thanks in advance.

I'd say the easiest is to copy this folder in your fork (https://github.com/microsoft/vscode/blob/main/extensions/references-view) and to remove the "download to retrieve extension" step from the build instructions

Thanks for the help


Icons don't work on msedge 96

I think I know what the problem is.

@hello-smile6 Sorry, we don't support msedge users. Please use a non garbage browser that uses modern standards.

font awesome icons aren't even used anymore...

@hello-smile6 Sorry, we don't support msedge users. Please use a non garbage browser that uses modern standards.

Um, sorry. Chromium has a large enough userbase, you should support it.

@hello-smile6 its an edge problem

@hello-smile6 also font-awesome icons aren't even used

font awesome icons aren't even used anymore...

Oh, I didn't notice. Also, it's not specific to Chromium. You used the fas class instead of fa.

fontawesome specifically says to use fas. please research before making random accusations.

also it worked for me.. soo.

fontawesome specifically says to use fas. please research before making random accusations.

That's for the solid icons. They make people pay to use them.

@hello-smile6 you know font awesome icons aren't used anymore... right?

@hello-smile6 you know font awesome icons aren't used anymore... right?

Yes, I was just telling you!

https://github.com/JaydenDev/searchocean-app

solved


That is not a valid source service worker file. Please try again with a file containing 'self.__WB_MANIFEST'.

Library Affected:
workbox-sw, workbox-cli
Browser & Platform:
Google Chrome latest
Issue or Feature Request Description:
I follow tutorial from here https://developers.google.com/web/tools/workbox/guides/precache-files/cli
directory structure:
+htdocs
.........+-- ibs-lite
..................+--index.php
..................+--manifest.json
..................+--ibslite-sw.js
..................+--workbox-v5.1.2
content of ibslite-sw.js

run workbox wizard --injectManifest

I was add to ibslite-sw.js
import {precacheAndRoute} from 'workbox-precaching'; precacheAndRoute(self.__WB_MANIFEST);
but it not recognize.
any solution for it?

how to solve it?

Does it work if you use a forward slash in the path, i.e. ibs-lite/ibslite-sw.js?

I also have the same problem. The documentation doesn't even specify what service worker I should create. Should the file have a conventional name? Also, do I need to add importScripts to the file?

Apologies, I think this is due to https://github.com/GoogleChrome/workbox/issues/2447
While you're waiting for a fix, which should make it into Workbox v5.1.3, you should be able work around it by including something in a comment that gets the assertion to pass, like
// This commented line will allow validation to pass: precacheAndRoute([])

// This is the actual code:
precacheAndRoute(self.__WB_MANIFEST);

(You can remove that extra line once the workbox wizard steps complete and you've got your configuration written out to disk.)
I'm closing this issue now in favor of tracking things in #2447.


docs: add N26 to showcase list

Hey folks 👋 ,
First of all, thanks for the amazing work with Turborepo. I've started experimenting with this tool in my current work and it works so well that we managed to get it fully integrated into our pipelines.
This little PR is including https://n26.com to the showcase list.

Light Version
Dark Version

Cheers!

🖤


Add Flight Statistic from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of DennyTX, to add Flight Statistic to CKAN.
Please direct questions about this pull request to DennyTX.

Should this go into the OLDD folder in GameData?
Need to filter Thumbs.db

Also has been removed from the main forums due to not having access to the source code. Not sure about our policy about that but I'll close this for now.


[dunfell][gatesgarth][hardknott][honister] google-benchmark: use "main" branch

Benchmark repository master branch has been renamed from "master" to "main".

Pushed to other branches as well:
84f97e001..382c22caa  dunfell -> dunfell-next
5bfd8302c..5f21f6e67  gatesgarth -> gatesgarth
5bfd8302c..5f21f6e67  gatesgarth -> gatesgarth-next
6892f5beb..a148c619a  hardknott -> hardknott
6892f5beb..a148c619a  hardknott -> hardknott-next
6892f5beb..a148c619a  master -> master
6892f5beb..a148c619a  master -> master-next
Thanks!


TestAutoregistrationLifecycle/fast_reconnect/same_instance flake

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1725460565502988288
--- FAIL: TestAutoregistrationLifecycle (1.12s)
    --- PASS: TestAutoregistrationLifecycle/initial_registration (0.00s)
    --- PASS: TestAutoregistrationLifecycle/multinetwork_same_ip (0.00s)
    --- FAIL: TestAutoregistrationLifecycle/fast_reconnect (0.08s)
        --- FAIL: TestAutoregistrationLifecycle/fast_reconnect/same_instance (0.03s)

Related to #44640 (probably the same cause)

I think it's fixed by https://github.com/istio/istio/pull/48089


fix: missing Highest

Motivation

$ grpcurl -plaintext <IP_ADDRESS>:9092 list spacemesh.v1.ActivationService.Highest
Error invoking method "spacemesh.v1.ActivationService.Highest": service "spacemesh.v1.ActivationService" does not include a method named "Highest"

spacemesh.v1.ActivationService.HighestThis method is not exported.

Changes

before
$ grpcurl -plaintext <IP_ADDRESS>:9092 list spacemesh.v1.ActivationService
spacemesh.v1.ActivationService.Get

after
$ grpcurl -plaintext <IP_ADDRESS>:9092 list spacemesh.v1.ActivationService
spacemesh.v1.ActivationService.Get
spacemesh.v1.ActivationService.Highest

Test Plan

TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

i will close pr, the comment by itself won't hurt, but it doesn't change anything

Oh, sorry, this problem exists in this commit and the latest version of the installation package. The devlop branch does work correctly.
5c2bf0f25ae837a23f18c132da58929cb70a75bd
https://storage.googleapis.com/smapp/v0.3.14/Spacemesh-0.3.14.dmg

@beck-8
The reason is that this endpoint was added to the node after the release of Smapp v0.3.14.
Newer versions include that endpoint.


Manually curated signal peptide feature not appearing

I added the residues of a signal peptide reported in  https://www.pombase.org/reference/PMID:39477503
It appears on the gene page  https://www.pombase.org/gene/SPBC1709.03
in the Protein sequence features table, but not in the feature viewer
Also here:
SO:0000418 | signal_peptide | match to sequence model evidence | 1-19 | Inagawa T et al. (2024) | 368
SO:0000418  | sequence similarity evidence used in manual assertion |   | UniProt Consortium (2023)
Once we have residues, we can suppress sources that don't supply residues

Sorry about that.  When I combined the signal peptide and transit peptides into the localisation signals track, I forgot to add the new track to the gene pages.
I've fixed that for Tuesday morning.

its there now.


[SPARK-18801][SQL][FOLLOWUP] Alias the view with its child

What changes were proposed in this pull request?
This PR is a follow-up to address the comments https://github.com/apache/spark/pull/16233/files#r95669988 and https://github.com/apache/spark/pull/16233/files#r95662299.
We try to wrap the child by:

Generate the queryOutput by:
1.1. If the query column names are defined, map the column names to attributes in the child output by name;
1.2. Else set the child output attributes to queryOutput.
Map the queryQutput to view output by index, if the corresponding attributes don't match, try to up cast and alias the attribute in queryOutput to the attribute in the view output.
Add a Project over the child, with the new output generated by the previous steps.
If the view output doesn't have the same number of columns neither with the child output, nor with the query column names, throw an AnalysisException.

How was this patch tested?
Add new test cases in SQLViewSuite.

Test build #71255 has started for PR 16561 at commit 0e82340.

Test build #71255 has finished for PR 16561 at commit 0e82340.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71255/
Test PASSed.

Test build #71400 has started for PR 16561 at commit 7e19803.

Test build #71400 has finished for PR 16561 at commit 7e19803.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71400/
Test FAILed.

Merged build finished. Test FAILed.

Test build #71415 has started for PR 16561 at commit d6537a5.

Test build #71416 has started for PR 16561 at commit 16ec310.

Test build #71415 has finished for PR 16561 at commit d6537a5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71415/
Test PASSed.

Test build #71416 has finished for PR 16561 at commit 16ec310.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71416/
Test PASSed.

Merged build finished. Test PASSed.

Test build #71426 has started for PR 16561 at commit 21e63f8.

LGTM

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71426/
Test FAILed.

Merged build finished. Test FAILed.

Test build #71434 has started for PR 16561 at commit c86ab48.

Test build #71434 has finished for PR 16561 at commit c86ab48.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71434/
Test FAILed.

Test build #71437 has started for PR 16561 at commit 06e8855.

LGTM

Test build #71437 has finished for PR 16561 at commit 06e8855.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71437/
Test PASSed.

thanks, merging to master!

hi , I have a question, why we should Eliminate View in the first of the optimizer.?
thank you.@jiangxb1987

@QQshu1 As we have mentioned in the comment, the View operator is respected till the end of analysis stage to enable us better understand the analyzed logical plan. On the Beginning of optimize stage, that operator is no longer needed, so we apply the EliminateView rule.

thanks, What effect if we don`t Eliminate View？I  means whether it effect  optimize the tree namely performance or the  correctness of results ?

the View operator doesn't have a corresponding physical operator, we have to remove it.


Breaking a bed from the bottom bed part doesn't give you the bed back

Luigi making this mod: Zzzzzzzzz...

same thing as doors

same thing as doors


Code Formatting : Is there a way to format correctly Twig or Swig tags ?

VSCode Version: 1.7 or 1.8.0 Insider
OS Version: Mac OS 10,11,4

Steps to Reproduce:

Open an HTML code with swig or twig tags

Format the code. Result is :

Tried to find extensions for Twig, no one is handling code formatting. Is there anyway to configure internal code format to handle that ?

Our approach is to let extensions provide support for specific languages. I'd suggest to open a feature request with one of the existing Twig extensions: https://marketplace.visualstudio.com/search?term=twig&target=VSCode&sortBy=Relevance

Hi guys,
There are so many people asking for this feature and all the extensions are not being maintained properly.  Could someone take over this and improve the code formatting for Twig?

Unfortunately this is outside of what we focus on in the core product. If the extensions are no longer maintained by their creators it might be best if someone from the community could step in and submit PRs to the extensions (or fork if that doesn't work well).

I have personally requested help for all Twig extension providers on this issue and no one can help. All other editors and IDEs have Twig code formatting (beautifying) support. We need some help from Microsoft Team on this one. Any way to make Twig one of the included languagesbas it is tied tightly to HTML anyway?

Have you tried changing the editor's mode to HTML and just use the HTML formatter?
If there already is a Twig formatter you could add it via an extension. There is a slightly dated post on adding formatters: https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

The HTML formatter removes the line breaks when it encounters a twig tag like {% or {{. None of the formatting extensions support twig.  It is a real shame as that is the one feature keeping a lot of us from being able to use VSC as our full-time editor.

Your best bet might be to follow HookyQR's advice in https://github.com/HookyQR/VSCodeBeautify/issues/176#issuecomment-339428822 and invest time (or money) into js-beautify because that already implements the HTML formatting and Twig formatting appears to be an increment on top of that. You'll then still need HookyQR's VSCodeBeautify extension to pick up that support from js-beautify, but that should be the smaller task.

Happy to invest some time/money on it, if I don't have to change my IDE
:-).
El mié., 8 nov. 2017 a las 2:56, Christof Marti<EMAIL_ADDRESS>escribió:

Your best bet might be to follow HookyQR's advice in HookyQR/VSCodeBeautify#176
(comment)
https://github.com/HookyQR/VSCodeBeautify/issues/176#issuecomment-339428822
and invest time (or money) into js-beautify because that already implements
the HTML formatting and Twig formatting appears to be an increment on top
of that. You'll then still need HookyQR's VSCodeBeautify extension to pick
up that support from js-beautify, but that should be the smaller task.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/16323#issuecomment-342547907,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1uAg6YzWy7lgxwUlQgZLdL6msd9C4wks5s0IucgaJpZM4LBYMu
.


fix(select): correctly handle disabled state for select component

Patch: Bug Fix
The select component shows up as disabled styling by default (ie. greyed out -- see https://baseui.netlify.com/?selectedKind=Select&selectedStory=In Select single mode&full=0&addons=1&stories=1&panelRight=0&addonPanel=REACT_STORYBOOK%2Freadme%2Fpanel).
This pull request correctly displays the enabled state as well as correctly handles the disabled state by adding a disabled prop to the top level and disabling changes if true.
Tests Added + Pass?
Yes, updated snapshot tests.
License
MIT

@schnerd @blackswanny what do you think, what should we fixed in the scope of this PR, and what should we handle separately?

@gergelyke  the way it fixes right now may introduce some new bugs. For instance, what if we forgot some styles to be changed in Input, which were previously changed by enforced "disabled=true" set? Also the fix contains more code, for the same feature, which is harder to maintain. For, instance, if !disabled is mentioned in a few places, whereas it's better to do it once for events handler for instance. So all comments are related to current fix, and I am not sure if we can split it into fix and some extra features refactoring as it's all solid.

There seems to be we have a lot of discussion on this thread - @blackswanny can you put together a list of action items we should in your opinion to fix this issue? I'd like to make sure that when tomorrow morning David gets up he has a clear set of tasks he has to do on the PR.

@gergelyke @nudge ok, here is the list:

Return disable=true to Input, but instead update styles only by overriding them for subcomponents like this:

overrides: {
        Input: InputOverride,
      },
    } = this.props;

InputOverride = Object.assign(InputOverride, {
    style: {
        //styles to override for disabled state of Input
     }
});

        <Input
          {...getOverrideProps(InputOverride)}
        >

Avoid to check in any handler for if (!disabled) {, but otherwise just capture click on very parent element and stop propagating down, like example below:

const events = option.disabled ?
                  {
                    onClickCapture: e => e.stopPropagation(),
                  }

@nudge @blackswanny do we need anything else to be changed on this PR, or is it ready to be merged?

@gergelyke disabled is still false, so I anticipate bugs due to inconsistency of styles, when Input is not disabled

if we change that to true, won't we end up with a disabled default state?

@nudge can you make that last change? we can jump on a quick call too, if that helps

Hey team, I've been out in Bangalore for the past week. Thanks for the discussion surrounding this, will make changes when I get a chance!

Thanks David! 👍

we usually rebase, not merge

should we close it in favor of https://github.com/uber-web/baseui/pull/292 @blackswanny ?

should we close it in favor of #292 @blackswanny ?

@gergelyke  I moved the code from here to that PR

cool, thanks Oleg!


'Module ' + name + ' has been loaded incorrectly.' is missing info

I see an error message from:
  if (!goog.isInModuleLoader_()) {
    throw Error('Module ' + name + ' has been loaded incorrectly.');
  }

"incorrectly" does not help me. The test goog.isInModuleLoader_() probably means something to the module loader developer.  If they shared their knowledge with the user, the user would no longer gnash teeth, curse, search SO, read source with low expectation of enlightenment. Rather they would be enlightened directly by the error message.

This seems to have been addressed.


Fixed expression dependencies issue

Manually compiling cache.ts and cache.native.ts
Converted import in EasybaseProvider to require('./cache')

Taking advantage of React Native platform-specific code.


Mark kong plugins as private

We don't want to publish these until the next version of the app has been released to production.

@develohpanda Maybe we should put a card in the top of the backlog or something to publish these after the next release, so that we don't forget?

Added https://github.com/Kong/insomnia/issues/2570


Umbraco 9

Do you have any plans to upgrade this package for Umbraco 9?

Hi @creativesuspects
I have plans to upgrade this to V9. But at the moment I can't give a time frame.
I have started my more popular packages first.
Dave

Hi @dawoe,
I totally understand. Would love to see this package ported to v9 in the (near) future. I will keep an eye on it and maybe chime in if I can find some spare time. :-/
Arjan

Thanks! I will check it out as soon as I get the chance.

@dawoe Any idea when you'll be pushing PR #33 to NuGet, maybe as an RC? I'd love to test it.


Proposal for VSTS Release Process

A proposed release process draft/idea
I envision a release process with two environments and two gates. Passing both gates gets the build to shippable status and it's at that point we make a legitimate release to the public.
First Environment: DEV
The first environment (let's call it 'DEV') is automatically triggered off of every build out of CI (that is, for every build that occurs due to a check-in to master, not for each PR). We put longer-running tests, performance tests, report generation tasks, and any 'manual' tests we want to cover in this environment.
Proposed Tasks for the DEV Environment

(re)-Build the VSIX using the internal process for doing so, to get signing accomplished.
Run performance tests (such as the one discussed above)
Run long-running tests (we can measure our tests in CI, and those that exceed some threshold can be moved here).
Run tests against the other versions of Python that are less popular. (In my head, only the most popular versions of Python are tested against in our CI build). Note: Do we do any tests across Python versions today?
Report generation: Report on the trend of performance, trend of tests & test coverage, other things that will have an impact on our team's decision making going forward. (Did you know there is also a 'twitter sentiment' task available?).
If all goes well, invoke a request to the team to do whatever manual testing is necessary.

This environment finishes by passing through a gate. This gate is only triggered when the build gets to the end of the battery of tests/packaging steps and, after a manual authorization by one of us.  (Ideally/optionally, we can just let it do this without any user intervention, but that will come later after we've learned to trust the system well).
Second Environment: PROD
Once the first gate is passed, the second environment will immediately push the VSIX package to our 'insiders' share on Azure. Once that is complete then the next thing we will do in this environment is wait for user feedback, perform more intensive manual testing (CTI?), and perhaps do some further checks against the latest insiders build, just to make sure everything still looks good.
Proposed Tasks for the PROD Environment

Upload the signed VSIX package to the insiders build share on Azure.
Manual (CTI) testing.
User sentiment tracking (manual at first, but automated once we have a bot/twitter sentiment thingy up and running).
Prepare the release itself: follow Brett's release checklist and automate all possible parts, without the
Any packaging extras that may be required prior to shipping.

Once all the tasks have completed successfully, the second gate is there to allow us to trigger an actual public release of our product. This will always have a manual component, as we will want to fine-tune this process to suit our needs as we progress. (Change the cadence, change the branches released from, other meta-tasks).

To answer "Do we do any tests across Python versions today?", the answer is we test Python 2.7 and 3.6, but ideally we should be testing 2.7, 3.4, 3.5, and 3.6 (and soon 3.7); basically any branch that is still being maintained upstream by the Python team.
And I don't know if we really need a sentiment check.
Otherwise you seem to be suggesting the following:

PRs have CI testing much like we have now
We run more thorough testing against more versions of Python and OSs per merge into master ("DEV" above)
When everything looks good we have a one-click "toss it over the wall" button which publishes the actual extension to the public ("PROD" above)

That seem right?

That seem right?

yep

Then that all seems reasonable. 😄

Seems great although I'd love our test coverage to be at the point where we can eliminate manual steps. Until then step 6 will be needed.

Closing as stale.


out of memory when using BatchNormalization on convolutional layers

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[v ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[ v] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[ ] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[v ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Hi,
I'm trying to train a small model to classify mnist on TitanX GPU.
here's the gist of the script:
data loading and preparation as in the mnist_cnn example and then :
x = Input(shape=input_shape)
layer = Conv2D(32, kernel_size=(3, 3),activation='relu')(x)
layer = BatchNormalization()(layer)
layer = Conv2D(64, kernel_size=(3, 3),activation='relu')(layer)
layer = BatchNormalization()(layer)
layer = MaxPooling2D(pool_size=(2,2))(layer)
layer = Dropout(0.25)(layer)
layer = Flatten()(layer)
layer = Dense(128,activation='relu')(layer)
layer = Dropout(0.5)(layer)
predictions = Dense(num_classes,activation='softmax')(layer)
model = Model(inputs=x,outputs=predictions)
model.compile(optimizer='Adam', loss='categorical_crossentropy', metrics=['accuracy'])
model.fit(x_train, y_train,
batch_size=batch_size,
epochs=epochs,
verbose=1,
validation_data=(x_test, y_test))
score = model.evaluate(x_test, y_test, verbose=0)
print('Test loss:', score[0])
print('Test accuracy:', score[1])
I get a message error about running out of memory (on TitanX ?! for such a small model ???)
some experiments:

when commenting out the BatchNormaliation, it works .
When using sequentioal model, same phenomenon happens - fails with Batchnorm
when adding the batchnorm right after the Dense (128,...) it also works
as expected, when using only dense layers, batchnorm works

Am I missing something ? (yes, I know, Batchnorm should allegedly come before activation, but its arguable. I'd want to see it works and not crash first).
Thanks,
Guy

I had a performance issue, too, with BN on CNN.

BatchNorm is pretty memory intensive.
Let's say you have an image 300x300x512, BN initiate 2 vectors of (512,) + keep a running mean so 4 vector of 512. Then it creates another image of 300x300x512 normalized. So basically, you more than double the memory usage. Expected.

BatchNorm is pretty memory intensive.
Let's say you have an image 300x300x512, BN initiate 2 vectors of (512,) + keep a running mean so 4 vector of 512. Then it creates another image of 300x300x512 normalized. So basically, you more than double the memory usage. Expected.

The memory you said is the memory of GPU.


Fix +1 -1 ehre command

fixed in https://github.com/glichfalls/ExtraSpicySpamBot/commit/1e64418825a479efa3f8f7c71c4f876011c3a2ad


When redeploying stack security group rules are not retained from previous install.

Webapp

OS Type: Linux
Java version:

1.8

Summary

When running the Redeploy process, the original Security Group does not retain any previous rules, but defaults instead to the original All traffic rule.
Reproduce steps

Enter any additional rules into the pacbot Security Group.  From the origin server used to create the PacBot stack, run the Redeploy steps.
git pull --rebase
cd installer
sudo python3 manager.py redeploy

Expected Results

Security Groups from original pacbot Security Group would be intact.
Actual Results

pacbot security group only has the original All traffic (from within the VPC CIDR) rule.
Aha! Link: https://t-mobile1t-mobile.aha.io/features/PM-413

@grumbis , we designed it as a security feature and this will help to keep network access only in VPC CIDR value

Adding my inputs as well. Added few accounts to monitor, redeployed pacbot and the account Ids from data collector cloudwatch rule, and pacbot_ro role got reset to default.
I had to rework this and added it manually.


Show Upgrade node.js warning when run on node.js < 4

https://github.com/typicode/please-upgrade-node
^ could be used

@jaydp17  I would like to work on this. Can you guide on how to setup the project?

Here's how to set it up
1. Clone the repo
2. npm install
3. Get the Api Key
Create an API_KEY (how to create the key) and put it in your ~/.bashrc.
echo 'export YOUTUBE_PLAYLIST_SORTER_API_KEY=AIzaxxxxxxxyyyyyyyyzzz' >> ~/.bashrc
source ~/.bashrc

4. Running it
$ npm run dev <PLAYLIST_URL>

Hope this helps!

#https://github.com/jaydp17/youtube-playlist-sorter/pull/9


json-server requires at least version 10 of Node, please upgrade

json-server requires at least version 10 of Node, please upgrade
error Command failed with exit code 1.
node -v
v8.17.0

npm --v
6.13.4

 "scripts" : {
              ....
              ....
              "serve": "json-server --watch ./mocks/api.json"
   }

The message says that you need at least NodeJS v10 and you have NodeJS v8.17.0 so you need to upgrade your version of NodeJS


Native globbing (Unix-only) is broken with respect to wildcard * in isolation

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Native globbing works with *.txt, for instance, but not with * alone:
# Note: Run on a Unix-like platform
/bin/echo *

Expected behavior
Should print a list of file and directory names in the current directory.
Actual behavior
*

That is, no globbing occurred.
Error details
No response
Environment data
PowerShell Core 7.4.0-preview.2 on macOS 13

Visuals
No response

Works fine for me in WSL (Ubuntu 20.04.5 LTS).

Thanks, @MartinGC94 - indeed it seems to affect macOS only (and there it also affects 7.3.3)  - I've updated the title and the initial post.

With PowerShell 7.3.3 on macOS 12, I can't reproduce this.
/bin/echo *

produces a list of file and directory names as expected.

Thank you all for verifying that it isn't a general problem.
My bad: I jumped to conclusions: it wasn't about the OS per se.
The presence of a file literally named foo\bar quietly breaks native globbing with *
Closing this in favor of #19460


README.md badly written

have you deliberately written the read me file in such a conversational way or is it accidental. it feels like im reading a personal thank you letter from king prince charles. do better. github deserves better. Try using ```

Fixed! Apologies I hadnt realised there was an easier way to write outputs from my program. Thank you for bringing this to my attention!


Push a UIViewController from THTinderNavigationController

Hey,
I am trying to push an UIViewController when I press a UIButton which is on one of the three main controller of THTinderNavigationController but it is not working, nothing is happening.
Did you manage to do something like this? Or am I doing something wrong?
Here some code when I press the button
AppSettingsViewController *nextVC = [[UIStoryboard storyboardWithName:@"Main" bundle:[NSBundle mainBundle]] instantiateViewControllerWithIdentifier:@"AppSettingsViewController"];
dispatch_async(dispatch_get_main_queue(), ^{
        [self.navigationController pushViewController:nextVC animated:YES];
});

However, when I present a UIViewController modally, I don't have any problems.
Cheers,
Thomas

+1 for a fix for this


Migrate cartodb.mod.odyssey to browserify

Part milestone for #699
Just bundle since there were no specific tests for this one, added an integration test case to verify the load working as expected though.
@javierarce can your review? :pray:
cc @matallo @alonsogarciapablo

Nice nice :+1:


How to modify the contents of ' locked_by ' param when i use Mysql provider?

Currently, the users on the 3 servers are all call “Ubuntu“, which results in the “ locked_by “ field in the Mysql table being the same. Is there a way to distinguish between different servers and the same user?

em ..
String sql = "INSERT INTO " + this.tableName + "(name, lock_until, locked_at, locked_by) VALUES(?, ?, ?, ?)";         return (Boolean)this.transactionTemplate.execute((status) -> {             try {                 int insertedRows = this.jdbcTemplate.update(sql, (preparedStatement) -> {                     preparedStatement.setString(1, lockConfiguration.getName());                     this.setTimestamp(preparedStatement, 2, lockConfiguration.getLockAtMostUntil());                     this.setTimestamp(preparedStatement, 3, Instant.now());                     preparedStatement.setString(4, this.getHostname());                 });                 return insertedRows > 0;             }
I see the source code，'locked_by' field only get from hostname ?

Hi, thanks for feedback. Just out of curiosity, why do you need to change locked_by? ShedLock does not use it and it's there just for debugging purposes.

Hello, thanks for the reply. When Shedlock uses the Jdbctemplate provider, it should use 'locked_by' field(mysql table field) to distinguish which instance is currently executing the scheduled task, right? I currently have 3 servers, and the hostname of each server is the same, so ca n’t I tell which server the current task was performed on, right? Can I only change the hostname on each server?

Thanks for your changes

Released as 4.1.0


Instruments and director fix

Fixes issue with director timelines loading incorrectly.
Fixes issue with instruments loading incorrectly.
Instruments now displayed in timeline blocks.
Instruments now displayed in timeline toast.

Looks good!

Nice!


SPV-807: adjust shared config

Pull Request Checklist

[x] 📖 I created my PR using provided  : CODE_STANDARDS
[x] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
[x] 🏠 I tested my changes locally.
[ ] ✅ I have provided tests for my changes.
[x] 📝 I have used conventional commits.
[x] 📗 I have updated any related documentation.
[x] 💾 PR was issued based on the Github or Jira issue.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.11%. Comparing base (7209665) to head (a41017c).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   53.07%   53.11%   +0.04%
==========================================
  Files         202      201       -1
  Lines       11215    11207       -8
==========================================
+ Hits         5952     5953       +1
+ Misses       4694     4685       -9
  Partials      569      569

Flag
Coverage Δ

unittests
53.11% <100.00%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

actions/admin/routes.go
100.00% <ø> (ø)

server/server.go
43.13% <100.00%> (+1.13%)
:arrow_up:

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7209665...a41017c. Read the comment docs.


JSON Schema in summaries #1045

Related Issue(s): #1045
Proposed Changes:

Support JSON Schema in summaries
Rename Stats Object to Range Object

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[ ] This PR has no breaking changes.
[x] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[x] This PR affects the STAC API spec, and I have NOT opened an issue/PR yet!

@jjrom Could you please have a look at this PR? I had to derive a bit from our discussion (see the issue for some context). I'm happy to discuss this again in a short call, too.

@jjrom Do you have an example at hand that fits into the examples folder? Could be an old one that we convert to the new schema.
We don't want too many/long examples in markdown to limit the length of the documents, so I'd put them somewhere in the examples folder and link to it, but the existing examples I also don't really want to touch, because I don't have a clue what values for counts etc to put in.

Perhaps we could duplicate the "collection.json" example (https://github.com/radiantearth/stac-spec/blob/master/examples/collection.json) to a "collection-extended-summaries.json" example in which we replace
"platform": [
      "cool_sat2",
      "cool_sat1"
]

with
"platform": {
      "type":"string",
      "oneOf":[
          {
              "const":"cool_sat1",
              "count": 103489
           },
          {
              "const":"cool_sat2",
              "count": 50700
          }
      ]
}

?

@jjrom I think we can only add it to the collection-only folder right now. The others are a full catalog, so the count would likely be 1 or 2 as there are not so many items and we also can't add two collections, because then the items would need to link to two of them.
Maybe we could duplicate, shorten and then convert https://github.com/radiantearth/stac-spec/blob/master/examples/collection-only/collection.json a bit and also add titles to epsg codes as you mentioned in the call?

@m-mohr Ok that makes sense. In this case we can duplicate  https://github.com/radiantearth/stac-spec/blob/master/examples/collection-only/collection.json and update the platform property. Concerning the EPSG codes, I'm fine to add titles but only if we shorten massively the property content - for instance limits it to two EPSG codes (e.g. EPSG:4326 and EPSG:3857). Otherwise it would be hard to read

Yes, agreed! Or can you export your "best" example from your implementation, which we then try to convert to the new format? Would be a good verification that the new schema works well with your data.

I plan to update my implementation to fit the new schema next week. If it's not too late I can provide a real example by the end of next week. Otherwise we stick to the existing collection.json duplication/shortening as we discussed (?)

@jjrom I thought about an example from your current implementation. That should be easy enough to migrate "manually".

+1 on 'manual migration'. I have some time today and can try to help.

@schwehr This looks very much like it could be useful for you as you have this gee:schema thing in your catalogs, right? Any thought on the PR? Could this be useful for you, too?

Some initial thoughts while reading to catch up...  I'm not familiar enough with jsonschema.  And I haven't had a chance to talk it over with simonf.

Looking at the example, it would be nice to have simple (even if contrived) examples of all of them (as much as jsonschema can support).
At least one example without a constrained set of values for string and int.
An example that used more of the capabilities of json-schema would be good.
Is there a way to specify the units?
We expected to have types of INT, DOUBLE, STRING, INT_LIST, DOUBLE_LIST, or STRING_LIST.  I looks like we are not using the DOUBLE_LIST.  The proto enum:

enum PropertyType {
  PROPERTY_TYPE_UNSPECIFIED = 0;  // Something is wrong.
  STRING = 1;
  INT = 2;
  DOUBLE = 3;
  STRING_LIST = 4;
  INT_LIST = 5;
  DOUBLE_LIST = 6;
}

The CI fails due to https://github.com/stac-extensions/scientific/pull/2

I'm wondering whether we should mark this new feature 'experimental' (with the chance of breaking in a minor release)?

Put in a suggestion for units: https://github.com/json-schema-org/json-schema-spec/issues/1094

I'm wondering whether we should mark this new feature 'experimental' (with the chance of breaking in a minor release)?

Is there a way to make the feature an extension? Happy for it to not be namespaced and even mentioned in the main spec. But that could let us evolve it without having to cut stac-spec releases.

No, it's not really extensible, I'd say. At least the extension would have the potential to break implementations and thus it's not a good extension.

Thanks, @schwehr.

Is there a way to specify the units?

Not standardized, but custom keywords are a thing.

Looking at the example, it would be nice to have simple (even if contrived) examples of all of them (as much as jsonschema can support).

Not sure what exactly you are asking for?

At least one example without a constrained set of values for string and int.

We encourage to specify what values to expect to make it more useful for users. Just specifying that the field exists (with a specific data type?) would not be a best practice IMHO. Ideally there would be more information.

An example that used more of the capabilities of json-schema would be good

I'm not sure STAC is the right place to go into JSON Schema details. Wouldn't it be better to just link to https://json-schema.org/learn/ ?

We expected to have types of INT, DOUBLE, STRING, INT_LIST, DOUBLE_LIST, or STRING_LIST.  I looks like we are not using the DOUBLE_LIST.

There's no direct type value for types arrays in JSON Schema, instead you do something like:
{ type: 'array', items: { type: 'integer' } } (INT_LIST) or { type: 'array', items: { type: 'string' } } (STRING_LIST)
The other types would be integer (INT), float (DOUBLE) and string (STRING).

Put in a suggestion for units: json-schema-org/json-schema-spec#1094

JSON Schema allows for custom keywords, so I'm not sure there's a need for another annotation in a validation language as you can simply define it on your own. But let's see what they think.

Is a custom type available within the actual schema being defined inside the STAC summary?  In the case I'm talking about,  the data isn't what's going to have the units.  The schema says what the units are going to be.

Looking at the example, it would be nice to have simple (even if contrived) examples of all of them (as much as jsonschema can support).

Not sure what exactly you are asking for?

There is little sense of the flexibility of the possibilities here.  I agree that the reader should go look at the json schema spec, but the examples here are extremely narrow.

At least one example without a constrained set of values for string and int.

We encourage to specify what values to expect to make it more useful for users. Just specifying that the field exists (with a specific data type?) would not be a best practice IMHO. Ideally, there would be more information.

Examples of non-categorical data:

string: A field with the name of the person who processed the data, or a field
int: in the range of 0..1e6.  say population in a polygon
float: A float between 0..1.  The fraction of cloudy pixels in an image

This seems good for now. We can fine-tune docs and examples later.