'Resolve in merge editor' takes forever to load simple conflict

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.82.0
OS Version: Windows 11

and merge editor behaves very strange
it does not shows the proper changes

same issue here #192556

Can you provide reproduction steps?

Well I don't have those now
But that was normal 2-3 line merge conflict

@hediet I still have this issue. it's consistently reproducible when you try to merge a remote branch into some local branch and have merge conflicts. In this case diff either does not open at all or takes ages to show. This applies to both merge changes and staged changes.
Here's the console

it's not just the merge editor. it's the whole source control  thing problem. sometimes even changes in the file fail to show. meaning I open changed file but none of the changes are highlighted. git output is empty and Source Control view shows a preloader bur that never disappears.
After restarting editor it works fine.

it's not just the merge editor. it's the whole source control thing problem. sometimes even changes in the file fail to show. meaning I open changed file but none of the changes are highlighted. git output is empty and Source Control view shows a preloader bar that never disappears. After restarting editor it works fine.

Same for me!!

I don't usually use VSC for git tooling but was dealing with an annoying conflict so wanted to see how well it worked.
Ran into this same problem.  At first I just thought it was completely broken, but sure enough give it 60-240 seconds and it will eventually load something.
It may have to do with large repos (or maybe more likely just large numbers of commits in the merge).
I was able to repro this pretty easily.  I did clear out my entire global git config to make sure it wasn't related.
To repro (while these repos may change hopefully by using point in time hashes it will still occur):
git clone https://github.com/mitchcapper/gnulib .
git remote add upstream https://github.com/coreutils/gnulib
git fetch upstream
git checkout d776a13e8b69b5d7e8b155fbc1645e7db8518b9b
git checkout -b merge_from
git checkout eb6e684c348bd3f587647aad58224f022b2f6da5
git checkout -b test_branch
git rebase merge_from

Should result in a singular merge conflict.   Open VScode point to the folder and try to open the file in conflict in the merge window (if the preference is on just double click it).
For the log the console was cleared right before double clicking on the conflict file, log level turned up to debug.
Version: 1.87.2 (user setup)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

2024-03-15 03:56:17.858 [info] Log level: Trace
2024-03-15 03:56:19.805 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z REBASE_HEAD [84ms]
2024-03-15 03:56:19.805 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z HEAD [100ms]
2024-03-15 03:56:19.967 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z HEAD [93ms]
2024-03-15 03:56:19.969 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z REBASE_HEAD [81ms]
2024-03-15 03:58:10.358 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2024-03-15 03:58:10.369 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2024-03-15 03:58:10.378 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2024-03-15 03:58:10.378 [trace] [svte] Repository for editor resource u:\gnulib\gnulib-tool already exists: u:\gnulib
2024-03-15 03:59:29.208 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 03:59:29.230 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 03:59:29.261 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 03:59:29.308 [info] > git ls-tree -l d776a13e8b69b5d7e8b155fbc1645e7db8518b9b -- u:\gnulib\gnulib-tool [100ms]
2024-03-15 03:59:29.308 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 03:59:29.324 [info] > git ls-tree -l eb6e684c348bd3f587647aad58224f022b2f6da5 -- u:\gnulib\gnulib-tool [94ms]
2024-03-15 03:59:29.325 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 03:59:29.327 [info] > git ls-tree -l :1 -- u:\gnulib\gnulib-tool [66ms]
2024-03-15 03:59:29.328 [info] fatal: Not a valid object name :1
2024-03-15 03:59:29.328 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.607 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.615 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.680 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.811 [info] > git ls-tree -l d776a13e8b69b5d7e8b155fbc1645e7db8518b9b -- u:\gnulib\gnulib-tool [205ms]
2024-03-15 04:05:01.812 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.819 [info] > git ls-tree -l eb6e684c348bd3f587647aad58224f022b2f6da5 -- u:\gnulib\gnulib-tool [204ms]
2024-03-15 04:05:01.820 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-03-15 04:05:01.820 [info] > git ls-tree -l :1 -- u:\gnulib\gnulib-tool [140ms]
2024-03-15 04:05:01.820 [info] fatal: Not a valid object name :1
2024-03-15 04:05:01.821 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)

To make this easier to reproduce I have a truncated repo setup to replicate the above.     I stripped all older history, and isolated just the one file.   The result is a repo with 11 total commits.  1 in the "ours" branch and 10 in "master" (with the origin commit as the shared base).
git clone https://github.com/mitchcapper/_git_merge_issue .
git rebase origin/master

ours should be the default branch so that should have the merge conflict occur.
Open the folder in VS will still take minutes+ to actually open the merging content on it.    The original repo was > 1 GB and this one 215kb.
I also ran code with: code --disable-extensions
Here is the log, 4+ minute to open
2024-03-16 23:36:31.163 [info] > git rev-parse --show-toplevel [86ms]
2024-03-16 23:36:31.774 [info] > git rev-parse --git-dir --git-common-dir [595ms]
2024-03-16 23:36:31.789 [info] Open repository: u:\merge_try
2024-03-16 23:36:31.955 [info] > git for-each-ref --format %(refname) %(objectname) %(*objectname) refs/tags [85ms]
2024-03-16 23:36:31.965 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z 9ba357b80b368c3ffeab8f337641723bd2953abe [81ms]
2024-03-16 23:36:32.036 [info] > git status -z -uall [64ms]
2024-03-16 23:36:32.162 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z 9ba357b80b368c3ffeab8f337641723bd2953abe [111ms]
2024-03-16 23:36:32.194 [info] > git for-each-ref --format %(refname) %(objectname) %(*objectname) refs/tags [88ms]
2024-03-16 23:36:32.281 [info] > git status -z -uall [79ms]
2024-03-16 23:36:32.398 [info] > git check-ignore -v -z --stdin [83ms]
2024-03-16 23:36:37.345 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z HEAD [82ms]
2024-03-16 23:36:37.349 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z REBASE_HEAD [62ms]
2024-03-16 23:36:37.539 [info] > git show --textconv e6d848fb9fd09a3e69b08c463d0a508a82e3e61f:gnulib-tool [121ms]
2024-03-16 23:36:37.594 [info] > git ls-tree -l :1 -- u:\merge_try\gnulib-tool [97ms]
2024-03-16 23:36:37.594 [info] fatal: Not a valid object name :1
2024-03-16 23:36:37.610 [info] > git show --textconv 9ba357b80b368c3ffeab8f337641723bd2953abe:gnulib-tool [168ms]
2024-03-16 23:36:37.612 [info] > git show --textconv :1:gnulib-tool [212ms]
2024-03-16 23:36:37.651 [info] > git ls-tree -l e6d848fb9fd09a3e69b08c463d0a508a82e3e61f -- u:\merge_try\gnulib-tool [123ms]
2024-03-16 23:36:37.657 [info] > git ls-tree -l 9ba357b80b368c3ffeab8f337641723bd2953abe -- u:\merge_try\gnulib-tool [119ms]
2024-03-16 23:36:37.665 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z HEAD [113ms]
2024-03-16 23:36:37.689 [info] > git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%D%n%B -z REBASE_HEAD [97ms]
2024-03-16 23:40:10.692 [info] > git ls-tree -l e6d848fb9fd09a3e69b08c463d0a508a82e3e61f -- u:\merge_try\gnulib-tool [128ms]
2024-03-16 23:40:10.723 [info] > git ls-tree -l 9ba357b80b368c3ffeab8f337641723bd2953abe -- u:\merge_try\gnulib-tool [144ms]
2024-03-16 23:40:10.725 [info] > git ls-tree -l :1 -- u:\merge_try\gnulib-tool [97ms]
2024-03-16 23:40:10.725 [info] fatal: Not a valid object name :1

@mitchcapper thanks for the repro!

I faced same issue and tried opening in Visual Studio , it got opened

I managed to stop this issue by removing / disabling all non-cosmetic extensions. Seems to be some issue with them.

@2004seraph happy that worked for your git but per my easy repro above and notes I ran it with

I also ran code with: code --disable-extensions

and problem persisted.


No timestamps for messages in SPM App Pod Logs

Platform : OpenShift 4.8
After a successful helm install/deployment, there doesn't seem to be any timestamp appearing in the SPM App Consumer/Producer Pod Logs, making  it very difficult to determine which messages are for which test activity. Please see the attached logs.
dev01-apps-curam-producer-66788ccb54-rxb85-apps-producer-curam.log
dev01-apps-curam-consumer-856b44855c-ld77w-apps-consumer-curam.log

@chayan88
You are correct, there is no timestamp within the raw spm logs.
Due to the nature of SPM on cloud, it is not feasible (or recommended) to access the logs on the individual pod. You will need a log management solution like logDNA for example.
the log management solution could have the following type of structure
<pod_name>
having the timestamp would result in duplicate timestamp.
Regards
Fergal


Ok, I think I fixed up the JSON

It passes validation with JSONLint

Found the problem with the empty critical files. Please pull now


Pylint added as a runtime dependency

Trying to upgrade to version 0.11.0 adds pylint (and its dependencies) to my runtime dependencies.
It seems that it got added to the pyproject.toml file in #118, specifically in commit b222100.
As far as I can tell, it does not seem relevant for the feature itself, and might have been added by mistake.
But I might be mistaken as I am not very familiar with either of poetry or pyproject.toml.
Is it possible to remove it from the dependencies?

Hi @cknv, thanks for noticing! This should be resolved in 0.12.1 https://github.com/tomasvotava/fastapi-sso/releases/tag/0.12.1


chore(simulator): initialize ACVM's SimulatedBackend separately (setup pedersen init only happens once)

Resolves https://github.com/AztecProtocol/aztec-packages/issues/1553

Converted to draft until I resolve ACVM PR feedback.

@TomAFrench agrees that it is probably fine to point Aztec to my acvm branch for now while review of that is ongoing. Speed improvements in Aztec are worth getting asap.


Do not remove node from associations when replacing it

Version
Build/Run method

[X] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

App Version 2.1.1+92d502a.92d502a
Zwavejs Version 6.6.0-fc5492f
Zwavejs-server Version 1.1.0
Describe the bug
I removed a zwave module from my already included kwikset 910 and with a zwave+ module and attempt to do a replace failed node.
Pressing the include button the lock doesn't appear to be recognized by  zwavejs.
To Reproduce
Steps to reproduce the behavior:

remove batteries from lock
remove zwave module from lock
press program button to drain system
insert zwave+ module and batteries
start a tail -f of zwavejs_1.log
choose replace failed node on the lock and say yes to secure inclusion
wait for log to state inclusion process has started
press inclusion button on lock
exclusion process stops and lock is never included

Expected behavior
Lock to be included
Additional context
18:12:27.636 SERIAL « 0x011d0013a801014e007f7f7f7f7f00010600000000420300007f7f7f7f7f51    (31 bytes)
18:12:27.637 SERIAL » [ACK]                                                                   (0x06)
18:12:27.638 DRIVER « [REQ] [SendData]
                        callback id:     168
                        transmit status: NoAck
18:12:27.644 CNTRLR   [Node 003] Node 3 did not respond after 1 attempts, it is presumed dead
18:12:27.647 CNTRLR   [Node 003] ping failed: Failed to send the command after 1 attempts (Status No
                      Ack)
18:12:27.660 SERIAL » 0x0105006303a933                                                     (7 bytes)
18:12:27.661 DRIVER » [REQ] [ReplaceFailedNode]
                        payload: 0x03a9
18:12:27.667 SERIAL « [ACK]                                                                   (0x06)
18:12:27.670 SERIAL « 0x010401630099                                                       (6 bytes)
18:12:27.670 SERIAL » [ACK]                                                                   (0x06)
18:12:27.672 DRIVER « [RES] [ReplaceFailedNode]
                        payload: 0x00
18:12:31.043 SERIAL « 0x01050063a90333                                                     (7 bytes)
18:12:31.043 SERIAL » [ACK]                                                                   (0x06)
18:12:31.045 DRIVER « [REQ] [ReplaceFailedNode]
                        payload: 0xa903
18:12:31.047 DRIVER   handling request ReplaceFailedNode (99)
18:12:31.048 DRIVER     1 handler registered!
18:12:31.048 DRIVER     invoking handler #0
18:12:31.048 CNTRLR   handling replace node request (status = FailedNodeReplace)
18:12:31.049 CNTRLR   The failed node is ready to be replaced, inclusion started...
18:12:31.059 DRIVER       the message was handled
18:14:24.211 CNTRLR   stopping inclusion process...
18:14:24.225 SERIAL » 0x0105004ac5aadf                                                     (7 bytes)
18:14:24.226 DRIVER » [REQ] [AddNodeToNetwork]
                        payload: 0xc5aa
18:14:24.233 SERIAL « [ACK]                                                                   (0x06)
18:14:24.239 SERIAL « 0x0107004aaa0615000b                                                 (9 bytes)
18:14:24.240 SERIAL » [ACK]                                                                   (0x06)
18:14:24.242 DRIVER « [REQ] [AddNodeToNetwork]
                        payload: 0xaa061500
18:14:24.244 DRIVER   handling request AddNodeToNetwork (74)
18:14:24.245 DRIVER     1 handler registered!
18:14:24.245 DRIVER     invoking handler #0
18:14:24.245 CNTRLR   handling add node request (status = Done)
18:14:24.245 CNTRLR   done called for 21
18:14:24.246 CNTRLR   the inclusion process was stopped
18:14:24.254 DRIVER       the message was handled

zwavejs2mqtt log from same time slice
2021-03-04 18:12:24.203 DEBUG SOCKET: Event ZWAVE_API emitted to 39aqHARkdf3DsT9qAAAL
2021-03-04 18:12:24.210 INFO ZWAVE: Calling api replaceFailedNode with args: [ 3, true, [length]: 2 ]
2021-03-04 18:12:31.050 INFO ZWAVE: Controller status: Secure inclusion started
2021-03-04 18:12:31.052 DEBUG MQTT: Publishing to zwavejs2mqtt/_EVENTS/ZWAVE_GATEWAY-zwavejs2mqtt/controller/inclusion_started: { data: [ true, [length]: 1 ] } with options { qos: 1, retain: false }
2021-03-04 18:12:31.061 INFO ZWAVE: Success zwave api call replaceFailedNode { success: true, message: 'Success zwave api call', result: true }
2021-03-04 18:14:18.527 DEBUG SOCKET: User disconnected 39aqHARkdf3DsT9qAAAL
2021-03-04 18:14:18.538 INFO APP: GET /control-panel 304 2.968 ms - -
2021-03-04 18:14:18.574 INFO APP: GET /static/css/app.addc55e5a7c06b2e220d.css 304 4.915 ms - -
2021-03-04 18:14:18.578 INFO APP: GET /static/js/app.7ac2d44817e089e0e76f.js 304 5.966 ms - -
2021-03-04 18:14:18.884 INFO APP: POST /api/authenticate 200 8.727 ms - 208
2021-03-04 18:14:18.891 INFO APP: GET /api/auth-enabled 304 7.997 ms - -
2021-03-04 18:14:18.905 INFO APP: GET /static/favicons/favicon-32x32.png 200 2.635 ms - 1831
2021-03-04 18:14:19.080 INFO APP: GET /static/logo.png 304 2.056 ms - -
2021-03-04 18:14:19.101 DEBUG SOCKET: New connection KQOLolOuuG-vZ2oVAAAN
2021-03-04 18:14:19.109 INFO APP: GET /static/fonts/MaterialIcons-Regular.fa3334f.woff2 304 3.535 ms - -
2021-03-04 18:14:19.121 DEBUG SOCKET: Event INITED emitted to KQOLolOuuG-vZ2oVAAAN
2021-03-04 18:14:24.247 INFO ZWAVE: Controller status: Inclusion stopped

what should i do at this point, just exclude it and then include normally?

You could build your container with the branch in #2021 and just do another replace (secure again)

will try that, i assume i have to power down the node so it 'fails' the is node alive check (i have been watching the logs careful :-) ) then when the log indicates inclusion is ready to be done power node up and press action.

You need to reset the device in order to be able to include it / replace it. Probably best if you shut down zwavejs first to avoid the case that the device sends a ResetLocally notification.

yes that fixed it, i also had to do an exclude on the device after the factory reset (i used a random aeotec key i have lying around).


Use correct "insert ignore" syntax for Sqlite.

This is a simple patch to fix issue #628.

Would you be able to test the change?


RFC0027 CLI command "update-route" to manage generic per-route options

CLI Support for Generic Per-Route Options
Introducing a new cli command 'update-route', which allows updates to route resources.
Extending the API of the Route to contain generic options map.
Detailed specification including that of for all the involved components is provided in the RFC
$ cf update-route -h
NAME:
   update-route - Update an existing route.

USAGE:
   cf update-route DOMAIN [--hostname HOSTNAME] [--path PATH] [--option OPTION=VALUE] [--remove-option OPTION]

EXAMPLES:
   cf update-route example.com -o loadbalancing=round-robin
   cf update-route example.com -o loadbalancing=least-connection
   cf update-route example.com -r loadbalancing

OPTIONS:
   --hostname, -n      Hostname for the HTTP route (required for shared domains)
   --path              Path for the HTTP route
   --option -o         Set the value of a per-route option, key-value pairs, repeat to set multiple options
   --remove-option -r  Unset a previously set option

SEE ALSO:
   create-route, map-route, routes, unmap-route

It should be possible to provide options in the create-route and map-route commands.
EXAMPLES:
  cf create-route my-space example.com -o loadbalancing=round-robin
  cf map-route my-app example.com -o loadbalancing=least-connection

Why Is This PR Valuable?
Allow users to manage per-route options via the CLI instead of having to talk to the API directly.
Applicable Issues
GitHub Issue
How Urgent Is The Change?
No urgency

Replacing by the https://github.com/cloudfoundry/cli/pull/3338 into the appropriate CF CLI version V8 branch


[Feedback]: We have a new telemetry provider for TF module

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
We have a new telemetry provider which could provide module usage telemetry data with more details.
To use this provider, all you need to do is adding such resource block in your module:
resource "modtm_telemetry" "test" {
  tags = {
    avm_git_commit           = "2724cc167e90f94ce2511c3fb803400d0a486743"
    avm_git_file             = "main.tf"
    avm_git_last_modified_at = "2023-06-05 02:21:33"
    avm_git_org              = "Azure"
    avm_git_repo             = "terraform-provider-modtel"
  }
}

The tags would be sent to our telemetry collection service (an Azure Application Insight instance), every time our user execute apply/refresh/plan/destroy command with our module, an event with these tags and CRUD type would be sent to us along with an uuid represents resource instance id. We could learn how many module instances exist now, and the module names, versions.
Now this provider is blocked by some unknown issues so we cannot use it directly from the registry, once it has been unblocked maybe we should consider use it as verified module's telemetry solution.

Hey @lonegunmanb,
We cannot wait until this is available and will certainly migrate/update our specs and contribution guides here to use this instead of the current approach, when it is available under the Azure org banner as a provider 😍

@jtracey93 just circling back on this one to check if there are any actions that could be taken at this point in time to address the feedback ?

This is something that myself & @matt-FFFFFF will need to review to understand further.
We'll also then need to engage @matebarabas & Jordi so we can work out a migration path, if possible for our telemetry dashboards.
Key question from me is do we need to deploy our our telemetry collection service endpoint as described here: https://github.com/Azure/TerraformModuleTelemetryService - @lonegunmanb can you let us know?

@lonegunmanb - We are converting this conversation to an internal one and I will ping you the link to the ADO item. I will also setup a call to discuss the next steps.


proto3 and XXX_unrecognized

I know that unknown fields have been removed from proto3, but I am trying to get an explanation about why this change was made and if there is any way to replicate that behavior in proto3.
Thanks so much.

That's a question for https://github.com/google/protobuf.


[tool_crash] ProcessException: No such file or directory Command: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome, OS error code: 2

Command
flutter run

Steps to Reproduce

...
...
...

Logs
ProcessException: No such file or directory Command: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome, OS error code: 2
#0      _ProcessImpl._start (dart:io-patch/process_patch.dart:401:33)
#1      Process.start (dart:io-patch/process_patch.dart:38:20)
#2      Chrome._startProcess (package:browser_launcher/src/chrome.dart:145:26)
#3      Chrome.start (package:browser_launcher/src/chrome.dart:137:18)
#4      FlutterResidentDevtoolsHandler._launchDevToolsForDevices (package:flutter_tools/src/resident_devtools_handler.dart:134:24)
#5      FlutterResidentDevtoolsHandler.launchDevToolsInBrowser (package:flutter_tools/src/resident_devtools_handler.dart:122:7)
#6      TerminalHandler._commonTerminalInputHandler (package:flutter_tools/src/resident_runner.dart:1662:55)
#7      TerminalHandler.processTerminalInput (package:flutter_tools/src/resident_runner.dart:1680:13)
#8      _rootRunUnary (dart:async/zone.dart:1434:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
#10     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
#11     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#12     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#13     _SyncBroadcastStreamController._sendData (dart:async/broadcast_stream_controller.dart:377:25)
#14     _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:244:5)
#15     _AsBroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:474:11)
#16     _rootRunUnary (dart:async/zone.dart:1434:47)
#17     _CustomZone.runUnary (dart:async/zone.dart:1335:19)
#18     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
#19     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#20     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#21     _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:63:11)
#22     _EventSinkWrapper.add (dart:async/stream_transformers.dart:13:11)
#23     _StringAdapterSink.add (dart:convert/string_conversion.dart:238:11)
#24     _StringAdapterSink.addSlice (dart:convert/string_conversion.dart:243:7)

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3.1 21E258 darwin-arm, locale en-IN)
    • Flutter version 2.10.4 at /Users/idrisattar/FlutterDev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (9 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[!] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/idrisattar/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11 0-b60-7772763)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
    Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11 0-b60-7772763)

[✓] IntelliJ IDEA Community Edition (version 2021.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.66.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.36.0

[✓] Connected device (1 available)
    • iPhone 13 (mobile) • 8DE1FD60-DA2C-42DD-B34B-C679C0997707 • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0 1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: c860cba910319332564e1e9d470a17074c1f2dfd

Duplicate of #95142


/api/v1/package/by-purl/{id} requires an UUID rather than a PURL

If the title of the PATH of the endpoint mentions by-url we should expect a PURL being send and not a UUID.

https://github.com/trustification/trustify/blob/3059e6f8109c4bd457a518757413f2a7afb7e43e/modules/fundamental/src/package/endpoints/mod.rs#L72-L78

Well it's the ID of a PURL. We could tweak that actually. The question is, would you have the qualified PURL to make that call?

Why do we call a path /api/v1/package/by-purl/{id} if we are not sending a purl but an id? Shouldn't /api/v1/package/by-uuid/{id} be more appropriate? It is like creating an endpoint /person/by-firstname/{passport_number}.

Well it's the ID of a PURL. We could tweak that actually. The question is, would you have the qualified PURL to make that call?

Actually this is a problem I have with the current REST endpoints. I just want to be able to fetch Package by "some key".  You can decide what "some key" is as long as that is consistent everywhere. E.g. let me expand a bit please:
GET /api/v1/package/by-purl (happy path)

(GET /api/v1/package does not exist anymore only the by-purl endpoint now)

This endpoint provides purl and uuid for each item, therefore I can do GET /api/v1/package/by-purl/{uuid}
GREAT! I am happy because I can navigate from /api/v1/package/by-purl to GET /api/v1/package/by-purl/{uuid}

{
    "items": [
        {
            "uuid": "00001093-5fb8-547a-92ba-348e9f73c2da",
            "purl"<EMAIL_ADDRESS>            "base": {
                "uuid": "82e13d43-dd26-5e4e-8328-d53cfaf0c311",
                "purl": "pkg://rpm/redhat/python-oslo-rootwrap"
            },
            "version": {
                "uuid": "00001093-5fb8-547a-92ba-348e9f73c2da",
                "purl"<EMAIL_ADDRESS>                "version": "7.1.0-0.20231218164901.0660a66.el9"
            }
        }
    ],
    "total": 31366
}

GET /api/v1/sbom/{uuid}/packages (NOT happy path)
If I fetch the packages from an SBOM using GET /api/v1/sbom/{uuid}/packages then I get a response similar to the json below.

In this case each package of an SBOM only has purl, there is no uuid.
I CAN NOT DO GET /api/v1/package/by-purl/{PURL}. So not good because I can not navigate from a package within an SBOM (the json below) to a package  details (GET /api/v1/package/by-purl/{PURL})

{
    "items": [
        {
            "id": "SPDXRef-01600a7f-7bb3-46f8-9fa1-7fdcbcc59d97",
            "name": "glibc-common",
            "version": "2.34-60.el9",
            "purl": [
                "pkg://rpm/redhat/glibc-common@2.34-60.el9?arch=ppc64le"
            ]
        }
    ],
    "total": 70
}

To summarize
All I am saying is that I have no issues using PURLs, UUIDs, or Another Field as a "Key" of a Package, but whatever is the "key" the Backend chooses, that Key must be present every single time  the REST endpoints make a reference of it.
This boils down to the same frustration I have with the current endpoints. A Package or any other Entity should have the same fields (fieldA, fieldB,FieldN) everywhere. E.g.

GET /api/v1/package/by-purl gives me back packages that contain uuid and purl. On the other hand:
GET /api/v1/sbom/{uuid}/packages  gives me packages only with purl and there is not any uuid

Both endpoints clearly mentions in their URL PATHS the term /package/ but they both clearly generate 2 different models. I believe it was mentioned that packages != package_from_sbom then we should not call them both package.
I understand that this is a bigger discussion currently tracked by https://github.com/trustification/trustify/discussions/478 so I will wait until we have some outcome/conclusion on that discussion. I am just expression a point (probably missing constraints, context, etc.), I will defer to you guys the decision of what is the best thing to do in regards of packages

Why do we call a path /api/v1/package/by-purl/{id} if we are not sending a purl but an id? Shouldn't /api/v1/package/by-uuid/{id} be more appropriate?

Because it is the UUID of a PURL. And not the UUID of a package.

Wow. So our api requires the client to send an internal identifier of an external identifier? And we're all comfortable with that?
I feel like we're exposing a lot of complexity in our api without much value justifying it.

Each Purl now contains a uuid that can be used to navigate on any other endpoint. That solves the original problem I had. I'll close this issue


[fontconfig] Build error

Host Environment

OS: centos stream 8
Compiler: gcc version 8.5.0 20210514 (Red Hat 8.5.0-13) (GCC)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install fontconfig:x64-linux
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
    Command failed: /usr/bin/python3 /home/vcpkg/installed/x64-linux/tools/meson/meson.py -Ddoc=disabled -Dcache-build=disabled -Dtests=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native /home/vcpkg/buildtrees/fontconfig/meson-native-x64-linux.log --default-library static --libdir lib --native /home/vcpkg/buildtrees/fontconfig/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/vcpkg/packages/fontconfig_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/vcpkg/installed/x64-linux/debug','/home/vcpkg/installed/x64-linux'] /home/vcpkg/buildtrees/fontconfig/src/2.14.0-523cc719dc.clean
    Working Directory: /home/vcpkg/buildtrees/fontconfig/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:470 (vcpkg_execute_required_process)
  ports/fontconfig/portfile.cmake:17 (vcpkg_configure_meson)
  scripts/ports.cmake:146 (include)

error: building fontconfig:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+fontconfig
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[fontconfig]+Build+error
Include '[fontconfig] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
    vcpkg-scripts version: a2d8a7cbb 2022-06-01 (2 hours ago)

root@localhost vcpkg]# cat /home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-err.log
Traceback (most recent call last):
  File "/home/vcpkg/installed/x64-linux/tools/meson/meson.py", line 26, in <module>
    from mesonbuild import mesonmain
  File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonmain.py", line 28, in <module>
    from . import mesonlib
  File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonlib/__init__.py", line 21, in <module>
    from .universal import *
  File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonlib/universal.py", line 17
    from __future__ import annotations
    ^
SyntaxError: future feature annotations is not defined

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

@chuckypt Can you please add vcpkg_find_acquire_program(PYTHON3) to vcpkg\ports\fontconfig.portfile.cmake and try again.

@chuckypt Can you please add vcpkg_find_acquire_program(PYTHON3) to vcpkg\ports\fontconfig.portfile.cmake and try again.

i find profile.cmake   in  vcpkg\ports\fontconfig
and  at first line  like this:
[root@localhost fontconfig]# cat portfile.cmake | more
vcpkg_find_acquire_program(PYTHON3)
set(FONTCONFIG_VERSION 2.14.0)
vcpkg_from_gitlab(
GITLAB_URL https://gitlab.freedesktop.org
OUT_SOURCE_PATH SOURCE_PATH
REPO fontconfig/fontconfig
REF ${FONTCONFIG_VERSION}
SHA512 0f36fa503c0277750ff253534f9305c9b4c86fd0d88a470e3b666080951714c51f13a69eecab382d0a7883a07494fc71730213e6086194a92aa5dfc075789e85
HEAD_REF master
PATCHES
no-etc-symlinks.patch
libgetopt.patch
)
i try again  ./vcpkg install fontconfig:x64-linux
[root@localhost vcpkg]# ./vcpkg install fontconfig
Computing installation plan...
The following packages will be built and installed:
fontconfig[core]:x64-linux -> 2.14.0#2
Detecting compiler hash for triplet x64-linux...
Restored 0 packages from /root/.cache/vcpkg/archives in 4.692 us. Use --debug to see more details.
Installing 1/1 fontconfig:x64-linux...
Building fontconfig[core]:x64-linux...
-- Using cached fontconfig-fontconfig-2.14.0.tar.gz.
-- Cleaning sources at /home/vcpkg/buildtrees/fontconfig/src/2.14.0-523cc719dc.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/vcpkg/downloads/fontconfig-fontconfig-2.14.0.tar.gz
-- Applying patch no-etc-symlinks.patch
-- Applying patch libgetopt.patch
-- Using source at /home/vcpkg/buildtrees/fontconfig/src/2.14.0-523cc719dc.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
Command failed: /usr/bin/python3 /home/vcpkg/installed/x64-linux/tools/meson/meson.py -Ddoc=disabled -Dcache-build=disabled -Dtests=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native /home/vcpkg/buildtrees/fontconfig/meson-native-x64-linux.log --default-library static --libdir lib --native /home/vcpkg/buildtrees/fontconfig/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/vcpkg/packages/fontconfig_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/vcpkg/installed/x64-linux/debug','/home/vcpkg/installed/x64-linux'] /home/vcpkg/buildtrees/fontconfig/src/2.14.0-523cc719dc.clean
Working Directory: /home/vcpkg/buildtrees/fontconfig/x64-linux-dbg
Error code: 1
See logs for more information:
/home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-err.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_meson.cmake:470 (vcpkg_execute_required_process)
ports/fontconfig/portfile.cmake:18 (vcpkg_configure_meson)
scripts/ports.cmake:146 (include)
error: building fontconfig:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+fontconfig
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[fontconfig]+Build+error
Include '[fontconfig] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
vcpkg-scripts version: a2d8a7cbb 2022-06-01 (7 hours ago)
can  you help me ~~

Sorry, I missed this. can you please provide the failure logs?
/home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-out.log

Sorry, I missed this. can you please provide the failure logs? /home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-out.log

[root@localhost vcpkg]# cat /home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-err.log
Traceback (most recent call last):
File "/home/vcpkg/installed/x64-linux/tools/meson/meson.py", line 26, in
from mesonbuild import mesonmain
File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonmain.py", line 28, in
from . import mesonlib
File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonlib/init.py", line 21, in
from .universal import *
File "/home/vcpkg/installed/x64-linux/tools/meson/mesonbuild/mesonlib/universal.py", line 17
from future import annotations
^
SyntaxError: future feature annotations is not defined
[root@localhost vcpkg]#

[root@localhost vcpkg]# cat /home/vcpkg/buildtrees/fontconfig/config-x64-linux-dbg-out.log
[root@localhost vcpkg]#
~~ it empty

Actually I want to confirm your python version.

Actually I want to confirm your python version.

[root@localhost fontconfig]# python3 -V
Python 3.6.8

Please try Python>=3.7

Please try Python>=3.7

it work~  thannk you~~~


Added Linux support (WIP)

Copied Mac OS File Browser c# and added similar behavior.
Used C and GTK to create a Dialog to select files.
WHAT DOES NOT WORK: file saving and Async.

That's awesome. Thank you very much.

when I have the time I'll complete the rest, file saving at least. :smile:

I wrote simple file save functionality by modifying your file open code, here. Please do not hesitate to do corrections, And don't worry about the async, threading is hard and not worth the effort 😄
Thanks again for your amazing contribution.
Cheers!

It's very simple and nice!
It is weird, but the last loop is what makes this all work well:
while (gtk_events_pending ())
    gtk_main_iteration ();

Yeah, gtk environment is weird.
I tried to get root GtkWindow for parent parameter. but didn't figured it out. Probably unity creates GtkApplication and GtkWindow somewhere internally, but doesn't expose them for use.
Tried to do this but no luck. It returns NULL for GApplication
GtkApplication* app = GTK_APPLICATION (g_application_get_default ();
GtkWindow* window = gtk_application_get_active_window (app);
Anyway, i have no idea how gtk works :)

Unity uses GTK on the Editor side. The Standalone doesn't use GTK internally, so we have to initialize it and deal with the loop.

Oh, i understand.


has_one doesn't allow custom foreign_key

I'm trying to implement a 1:1 relationship between two tables without duplicating data in a new column. The issue is that has_one does not allow specifying a custom foreign_key, while belongs_to does.
This means a new column is created which contains a set of ids, even though I only want a 1:1 relationship.
The only solution I came up with is to use belongs_to on both ends. Is this intended?
Example:
# models/registration
class Registration
  include Dynamoid::Document
  table name: EnvConfig.DYNAMO_REGISTRATIONS_TABLE, capacity_mode: nil, key: :attendee_id
  # does not work
  has_one :history, class: RegistrationHistory, foreign_key: :attendee_id
  # works, but is semantically incorrect
  belongs_to :history, class: RegistrationHistory, foreign_key: :attendee_id
end

# models/registration_history
class RegistrationHistory
  include Dynamoid::Document

  table name: EnvConfig.REGISTRATION_HISTORY_DYNAMO_TABLE, capacity_mode: nil, key: :attendee_id
  # works
  belongs_to :registration, foreign_key: :attendee_id
end

Yes, it makes sense to be able to reuse existing scalar attribute in a model with has_one association. Will add this to the todo list.


Export Spritesheet information as JSON

Hi,
I started to use https://github.com/DrJamgo/Godot_LPC_Spritesheet_Gen/tree/main/addons/lpc_spritesheet_gen for Godot integration. This uses the JSON input from https://sanderfrenken.github.io/Universal-LPC-Spritesheet-Character-Generator/.
If your tool would export something similar the Godot addon could be changed to support both asset sources.
regards
Andreas

Thanks for the suggestion. My tool is still in an experimental stage, there's still one or two key features that need to be completed, and until those are finished the underlying data structure of this generator may change significantly.
I can certainly see the benefit of the feature though, and I'll definitely keep it in mind for when things are more stable.


Backup widget "Item details" pane is blank when opening multiple times

SQL Operations Studio Version: master 03ea265

Steps to Reproduce:

Close Ops Studio and reopen it
Open a server dashboard
Click on the "..." for the Backup Status widget and choose "Show Details". The insights dialog will show up as expected.
Close the dialog and then open it again

Actual behavior: No details are visible in the item details pane
Expected behavior: It works the same as the first time you opened it and item details are visible

I'm having this issue as well, it's super frustrating as the only way I can fix it is by closing Azure Data Studio then re-opening it. I've tried reinstalling, running as admin, and running on a different computer. Whenever it happens, I also get either a table of blank results if I select "Run Query" or the following in Messages (no results).
Commands completed successfully.
Total execution time: 00:00:00


Author 001-b: Endpoint

As an author I want to make posts.

closing because task needs to be broken down


Is it possible to use old version's feature (WATSONCONVERSATION_URL)?

In documentation https://github.com/codeforequity-at/botium-connector-watson, I see "WATSON_APIKEY", but it's not what I want (WATSONCONVERSATION_URL). Recently I used url of our server and from our server it connected to watson. We used this approach because we used several workspaces and our server can switch from one to next one, and other fuctionality. Can you say some way, how to use old version? Or where should I define URL of our server?

See #110


Can not disable Gravatar in issue page

The Gravatar service cannot be turned off on the issue page. The Gravatar service has been modified in the configuration. The Gravatar is disabled on many pages, but the Gravatar function is not turned off after the issue function is enabled.

I cannot reproduce this. I wrote an alternative avatar provider and set it in web.avatarClass. The alternative provider was used on commit pages as well as ticket pages.
Do you have more information on the changes you made and maybe some screenshots?


added minimize_sgdx_contract

minimize contract for deploy to zilliqa

noted that I've test token contract in minimize version


Generated Markdown is not rendered correctly

Following on https://github.com/RDFLib/pyLODE/issues/33, after fixing some of these by manually copying files from the repo itself, I was able to build the markdown documentation. Unfortunately, the generated markdown tables didn't appear to render correctly in either the Sphinx + Recommonmark render nor the GitLab Markdown renderer. I think this is an issue with some markdown parsers disabling markdown parsing once HTML is detected, thus intermingled HTML and MD isn't accepted.
Lastly, I couldn't get a large majority of anchor links to work. This is observable even on GitHub's MD renderer: the Delegated link in the Classes section links to https://github.com/RDFLib/pyLODE/blob/master/src/pylode/examples/reg.md#Delegated, which does not anchor correctly.

OK, we may have to have options for pure Markdown and then Markdown + HTML or I might just have to learn how to replicate all the things that I've lazily added in to the Markdown in HTML in plain Markdown.
To be addressed after Issue #38.

Great, thanks! Glad to hear. re: #35, I think rST has its own separate systems for this as well.

OK, finally some real progress here! See these two documented versions of the AGRIF ontology in Markdown - OWL (as an ontology) & SKOS (as a taxonomy):

https://github.com/RDFLib/pyLODE/blob/master/pylode/examples/agrif.md
https://github.com/RDFLib/pyLODE/blob/master/pylode/examples/agrif.skos.md

The Markdown is much cleaner - far less HTML - but the fragment URIs still aren't working. that's the next thing to fix.

Markdown is cleaner but fragment URIs aren't completed, however there's a separate Issue for that (#86), so I'm closing this to focus on that URI Issue.


no "exports" main defined error when working with mocha

Bug description
I use mocha to test my code with the command 'mocha -r tsx test/xxx.test.ts', then it reports the error 'no "exports" main defined in xxx/package.json', however, I can find the 'exports' defined in xxx/package.json indeed.
I think it may result from the package https://www.npmjs.com/package/@lodestar/types, as when I remove it, everything works well, weird, is there any differences between this package and normal one? or I missed some configurations?
related screenshots:

Reproduction
package.json, noted: if I remove "@lodestar/types" and keep other packages, it works well.
{
  "dependencies": {
    "@lodestar/types": "^1.5.1",
    "@chainsafe/persistent-merkle-tree": "^0.4.2",
    "chai": "^4.3.7"
  }
}

common.test.ts
import * as common from '../src/common'
import chai from 'chai']
const assert = chai.assert

describe("common test cases", function() {
    this.timeout(60000);
    it("test 23.03.15", async () => {
        let rlt = common.xxx()
   })
})

Environment
System:
    OS: macOS 12.5.1
    CPU: (8) arm64 Apple M2
    Memory: 92.06 MB / 24.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.15.0 - /opt/homebrew/bin/npm

Can you work on a fix?

[ ] I’m interested in opening a pull request to address this issue.

Closing until reproduction is provided.
Also note, your error is coming from Node.js. Not tsx.

thanks @privatenumber, I don't think it's coming from Node.js, as I remove this target package, and it works well. is there any incompatibility or some configurations I missed?

mini reproduction: https://github.com/xichan-ms/mini_reproduce_mocha_tsx

tsx is missing as a dependency but it's necessary to indicate which version you're using.
Is it really minimal? I feel like the code in test and the function in common.ts are extraneous

thanks, @privatenumber I add the tsx version as use global before, and also add scripts in package.json.
you can see test2 works well, but test with mocha not work. I'm wondering is there any configurations I missed?

yes, minimal, code in test uses the function "calculateBeaconHeaderRoot" defined in common.ts to test it.

hi, @privatenumber could you help to open this issue? thanks

Thanks for updating the reproduction.
In the future, I kindly ask you provide a minimal reproduction when filing an issue as it would save both of us time and make our interactions smoother. Also, when I tried running your reproduction, the mocha dependency was missing. Please make sure things like this are working as it could be time consuming to investigate. As you know, I'm providing support for free on my personal time, so I would appreciate it if you could help me out in this way.
In your reproduction, I noticed the command that's working is tsx, but the one that's not working is mocha. Have you considered filing a bug report with mocha? It might be worth trying since it seems to be the source of the issue.
And your reproduction is not minimal because you're reporting a bug in loading modules, not the logic of your code. For example, the same error can be reproduced by reducing common.test.ts & common.ts to a one-liner: import './common'.


[Update Request]:

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
AnyDeskSoftwareGmbH.AnyDesk
Package Version
7.1.13
Please describe the changes you would like to see
There is a new release: 7.1.13

The Azure Pipelines was unstable. Are you sure you want to continue?


What tool are you adding and to what category?
We need to add free to use website where user can read their favorite comics in their chill time.
Add Tool Link
Add tool link  https://www.asurascans.com/
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] The tool is free for use

Please assign me under GSSOC'23

@JasonDsouza212 please add gssoc'23 label. Thank You.


A&R-> Issues on the Front country camping "Enter data" form

This issue was discovered when testing the ticket: https://github.com/bcgov/bcparks-ar-admin/issues/256
Scenario:

Navigate to the A&R Admin on the TEST environment
Select a Month/Year, a Park, and a Sub-area that has the facility "Frontcountry Camping".
Then select the option to edit the record and check the form to make sure nothing is missing (compared to existing PROD)

Issues:

The tooltip for the "Gross camping revenue" field is missing.
The tooltip for the "Gross 2nd car revenue" field is missing.

Please refer to the Figma here: https://www.figma.com/file/yoMhvO0KZvsM6qoqwuIjpt/Attendance-%26-Revenue?type=design&node-id=5173%3A15607&mode=design&t=tUhLWguRI8YhUrFf-1 for the expected tooltips or refer to the PROD environment.

@manuji I still can't reproduce this based on the instructions given. The 'Gross Camping Revenue' and 'Gross Second Car' Revenue both still appear as expected.
If you're certain there's a bug, I still need more information to reproduce - date, park, & subarea used, and a screen capture/recording showing the bug happening.

@cameronpettit , I am sorry, I should have used the word "Help text". This is what is missing here:

Oh, that makes more sense. Patched in https://github.com/bcgov/bcparks-ar-admin/pull/318

I will move this to QA and to this sprint. Thanks Cam.

Tested on TEST: Passed

Verified that this issue has been fixed.


i just saw that this still wasnt merged

noticed that it said the main branch was behind 3 commits so i started this pull request


Communication between webview and flutter

Hi guys,
I got a flutter app and I need to transform it to a PWA.
I am opening the Flutter app trough the webview but I got few function that need to communicate with flutter to open phone calendar for example.
I need to click a button inside the webview that fire me a listener or something like that inside the flutter code (outside of webview)
Is it possible?

Yes, there is already an example of a PWA:

code: https://github.com/pichillilorenzo/flutter_inappwebview_examples/tree/main/pwa_to_flutter_app
article: https://medium.com/better-programming/convert-a-pwa-into-a-flutter-app-using-webviews-387060548a37

Check https://inappwebview.dev/docs/webview/javascript/communication for more info about javascript communication

Ok but you're firing for example the buttoj 'Request dummy notification' from HTML.
I don't got nothing on HTML.
I need to show full flutter app inside a webview and click a button inside the webview that is showing the flutter app and fire the main code to show notification for example.
Is it possible? On docs I didn't found that

What do you mean by “Flutter App inside a WebView”? Maybe you mean the other way around, that is a WebView inside your Flutter App?
On what platform are you talking about? Web platform? If you mean that, Web platform is implemented using IFrame HTML elements, that are very limited, so in that case you probably can’t do much about it.
Instead, if you are talking about Android or iOS, then you can communicate with the web contenta of the WebView using JavaScript using what you can find on the official docs.
Flutter to WebView and WebView to Flutter, for example using JavaScript handlers, as you can see in the example code or in the docs.

I mean that I have to show a flutter app trough the web view because I need to upload it on the store.
Flutter app A need to show Flutter app B trough web view and I need to communicate from webview trough Flutter A (to show notification/calendar popup or other functions)

Then, if you are able to access JavaScript objects and method on the Web App, yes you can do that.
The docs speaks about JavaScript, but I think you do the same as Dart should have access to the JavaScript (DOM) API.
Use the official dart html library to access the same objects you would do in JavaScript code, such the window object: https://api.dart.dev/stable/3.2.4/dart-html/Window-class.html

Any hint how to do that?


example commands broken with fedora

osbs-box will run with fedora containers, assuming https://github.com/lcarva/osbs-box/pull/65
However, koji-containerbuild seems broken:
$ docker exec -it osbsbox_koji-client_1 koji-containerbuild container-build candidate   \
    git://github.com/lcarva/docker-hello-world#origin/osbs-box-demo \
    --git-branch osbs-box-demo

TypeError: activate_session() takes exactly 2 arguments (1 given)

This works fine under RHEL. I'm not sure what's changed under Fedora.

Older version of koji somewhere? Seems related to https://github.com/release-engineering/koji-containerbuild/pull/71


Implement condition with type Deleted

Description

For better understanding and visibility, of what is going on during the de-installation process, we should share information about the process of the separated condition. We can call it Deleted. The condition should inform us when de-installation started and about an error if any would happen. Right now we emit events every time the process is starting and finishing - we can re-use communications from events in the condition.
(Optional) We can think about using the Warning state in our case when de-installation is failed because there are leftovers on the cluster. ( more info )

This functionality was changed some time ago (here). We can treat this PR (it was for the serverless-manager) as an instruction on what and where to put.


Asset gov update

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6762bd4b7c9c050f11aa6e1a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6762ef556e5d9b082b853d27--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6763e7865c13e595f68973a5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6763e8895c13e597738971fc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6763f5fbbfe06e0da2e4d480--harness-developer.netlify.app


Ensure All Relevant Redux Bundles are Tested

Request: Any bundle that deals with data logic in any way has its functions tested against our sample set
Short description:

Current state:

no bundle is tested.

Desired state:

all relevant bundles are tested.

Tasks:

[ ] (Add tasks to achieve desired state)

@zachmandeville: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

specifying the label manually: /sig <group-name>
e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

added most useful tests, but we are likely moving away from redux driving as much as it is--and so tests for each bundle is lower priority.


fixes inline plots in tutorial

Describe your changes

I noticed the tracker tutorial had a lot of duplicated plots (see the link), this fixes it
this also applies a pending deprecation on ClassificationReport

Issue ticket number and link
Closes #x
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added thorough tests (when necessary).
[ ] I have added the right documentation in the docstring and changelog (when needed)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

48 of 53 (90.57%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 94.054%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sklearn_evaluation/plot/util.py
6
11
54.55%

Files with Coverage Reduction
New Missed Lines
%

src/sklearn_evaluation/telemetry.py
2
96.92%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
2974

Relevant Lines:
3162

💛  - Coveralls

Where is it documented?

what? the deprecation? It was a pending deprecation, check out the changes

No no I mean this one: no_display_plots

Nothing has changed. no_display_plots is a context manager that's only applied when it's needed outside of it, behavior remains the same, check out the implementation

Can the no_display_plots context affect the user experience when working with notebooks?

no, it won't.no_display_plots is only used when de-serializing plots from JSON stored in a database. We shouldn't display them in such cases since we're loading them to put them in a table-view.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

53 of 58 (91.38%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 94.11%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sklearn_evaluation/plot/util.py
5
10
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
2972

Relevant Lines:
3158

💛  - Coveralls


Design Uid requests to use idToken and refresh token

From auth response, using these tokens that will be handled in decorators and validators in the flask backend is better than to store locally or use auth cookies to keep track of the logged in uid. Currently working on this in the antoine-job-system-userapi branch

The system I made uses this extensively and the security of the app has thus been increased quite a bit.
Will do a PR soon, issue closed when current branch state with all my new features and security patches will have been merged to either notification branch or main branch

took way too long but will be fixed with merging PR #63


Setting CPU scaling_governor to performance mode

In MVP1, the init scripts were setting the CPUs to run in performance mode. In MVP2, we moved to systemd and removed the userspace settings, hence the CPUs defaulted to powersave mode. This change resulted in performance issues. Thus setting the default CPU scaling_governor mode to performance.

@costanic Added description.


spec details

the details of the specs for how data should be organized when ingesting (with or without the service) must be clear.
in particular, details for how to check whether the data are to spec should be included.
some of our friends have tried to follow the 'spec' we've given them, but failed, for various reasons.  if they fail, it should never be our fault.
in the not too distant future, it occurs to me that the right way to do this would be to provide a script that they run locally that cross-checks the json file with the images.
@randalburns @kunallillaney @Aeusman @j6k4m8

Now in HBP. Closed a similar issue.


Identify nodes by host id instead of IPs

As a corresponding change has been merged into Scylla itself, we should adjust as well.
Moreover, for Serverless Cloud host IDs are the only valid way of identifying nodes.
Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[ ] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[ ] I added appropriate Fixes: annotations to PR description.

How does the new behavior interact with old clusters that don't identify nodes by host ID? What about Cassandra? Is this backwards compatible?

@avelanarius Could you join in?

How does the new behavior interact with old clusters that don't identify nodes by host ID? What about Cassandra? Is this backwards compatible?

@avelanarius Could you join in?

I think that the cover letter is slightly misleading: this PR was inspired by recent changes in Scylla to unify different "node ID" mechanisms (in snitch, Raft, gossip, etc.) to use only host ID. But this PR does not require those server-side (Scylla/Cassandra) changes, but rather it is an internal driver change.
Refs https://github.com/scylladb/python-driver/pull/199 - in Python Driver now it's possible for a node to change its IP while maintaining the same host id. The driver should handle such situation correctly. Note that this might be out-of-scope of this PR, but eventually Rust Driver should support it correctly.
cc @kbr-scylla

I think that the cover letter is slightly misleading: this PR was inspired by recent changes in Scylla to unify different "node ID" mechanisms (in snitch, Raft, gossip, etc.) to use only host ID. But this PR does not require those server-side (Scylla/Cassandra) changes, but rather it is an internal driver change.

I just meant to ask whether there will be issues if you use a driver that identifies by host ID but the cluster relies on identification by IP. For example, if host ID uniqueness is not enforced then a cluster could have two nodes with the same host ID (driver would connect to only one of them), or a node could change its host ID and would be considered a different node from that point of time. Now that I think of it, even if it is possible then it doesn't sound very probable nor harmful so I guess it's fine.

What will happen if a node changes its IP? Will the connection pool for that node react and start connecting to the new address?

I'd be very surprised if a node just changes its IP all the sudden. I would assume some topology change taking place (node going down and back up, etc.) has to happen.

I'd be very surprised if a node just changes its IP all the sudden. I would assume some topology change taking place (node going down and back up, etc.) has to happen.

The driver updates topology information in a poll-based manner - it fetches full topology information with a configurable interval (1 minute by default) and sees what has changed since the last poll. If the driver is unlucky it might not observe the node going down, only observe the state before and after IP change.
That's fine, my concern is that we need to make sure that the connection pool for that node is reconfigured to use the new IP.

That's fine, my concern is that we need to make sure that the connection pool for that node is reconfigured to use the new IP.

Upon closer inspection, it looks like the PR doesn't have this problem after all. In ClusterData we are still identifying nodes by their connect address, so if the IP changes then the old connection pool will be dropped and a new Node object will be created with a new connection pool.
The ClusterData::new function should be modified to consider the case when a node with a host ID takes over an IP of another node. We should detect it and create a new Node object in that case instead of reusing the old one.

@piodul Addressed:

The ClusterData::new function should be modified to consider the case when a node with a host ID takes over an IP of another node. We should detect it and create a new Node object in that case instead of reusing the old one.

as well as the small nit above.


(-> PR #104) - Adjusments to the decorator

I had misunderstood the intent behind the operator on PR #104.
@ta-oliver , do these changes look appropriate (more in line with the original intent)?
Sorry it's taken me so long to get back to this.

@fernando-az-infertrade - this looks good.
I think actually we want both formats:

This sort of decorator - apply to a function with two arguments and it will restrict allocation to a range. You can choose to use by applying as a decorator.
The original decorator you created - transforms an existing function to take additional arguments as keyword args. We apply to the original rules and you can choose to use by adding the extra arguments.

For 1 I think the above looks great.
For 2 we could call it optional_portfolio_restrictions or similar, and it could use limit_allocation in the function.
That way we can later add other portfolio restrictions to optional_portfolio_restrictions, such as a trailing stoploss, minimum size change for adjustment, etc.
I think it is actually fine to add a optional_portfolio_restrictions decorator to all rules. I was worried about the complexity, but it is a good way to cheaply add in standardise functionality to cap min and max for all rules.

Happy to merge in as is, or we could combine into a generalise portfolio_restrictions_decorator, initially applying only this restriction.
I think we ultimately probably want a single portfolio restrictions decorator that applies a set of smaller decorators for different restrictions, like max allocation, stop loss, minimum size change. For now we could use your original formulation and nest the allocation_limitation inside to apply the actual restrictions.
i.e. you have:
@apply_portfolio_restrictions def my_first_infertrade_rule(): ...
PLUS
def apply_portfolio_restriction(func):     @apply_stoploss(max_loss=0.05)     @limit_allocation(min=-0.25, max=0.75)     def restricted_function(arg, kwargs):           return func(args, kwargs) return restricted_function

@ta-oliver I think generalizing both (types of) decorators is the better idea. I can't figure out how to make these PRs into draft PRs, so I'll close them both and re-open them as soon as I have the additional features up on the branches. Thank you.


feat: add etcd storer

resolve #7

Codecov Report

Merging #14 (4f7263f) into main (2b828f7) will increase coverage by 8.66%.
The diff coverage is 75.87%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   42.23%   50.89%   +8.66%
==========================================
  Files          12       16       +4
  Lines         663      890     +227
==========================================
+ Hits          280      453     +173
- Misses        360      403      +43
- Partials       23       34      +11

Impacted Files
Coverage Δ

internal/core/storer/etcd.go
0.00% <0.00%> (ø)

internal/core/entity/format.go
64.58% <64.58%> (ø)

internal/core/entity/entity.go
74.64% <74.64%> (ø)

internal/core/storer/store.go
80.80% <80.80%> (ø)

internal/core/storer/store_mock.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b828f7...4f7263f. Read the comment docs.


As a PPR operations manager, I need field permits every week to plan field rehabilitation and other work in my OPERATIONS district

Ops districts are on old, 8-district PPR map and not new 10-district map


Selecting "Override" and "none" for bars results in token creation error.

Also happens if you select a "character" attribute and try to create a npc.


Refactor and Optimize One-Tap Sign-In Implementation

This pull request introduces a comprehensive refactor and optimization of the One-Tap Sign-In feature. The following changes have been made:
Key Changes:
Refactor to Object-Oriented Design:

Transformed the OneTapSignInWithGoogle composable function into an object-oriented class, OneTapCompose, enhancing code organization, readability, and reusability.

Improved Coroutine Management:

Injected CoroutineScope into the OneTapCompose class to better manage the lifecycle of asynchronous operations, ensuring coroutines are appropriately canceled when the class is no longer in use.

Enhanced Exception Handling:

Simplified and centralized exception handling by introducing constants for common error messages, leading to more consistent and maintainable error reporting.

Optimized Helper Methods:

Reorganized and modularized helper methods (handleSignIn, and handleFailure) to streamline the sign-in process and improve the clarity of the code.

Improved Logging and Error Feedback:

Enhanced logging with clearer messages and consistent levels, ensuring better insights into the sign-in process and error conditions.

Code Cleanup:

Removed obsolete imports and code, resulting in a leaner, more efficient implementation.

Impact:
These changes significantly improve the maintainability, scalability, and reliability of the One-Tap Sign-In feature. The new object-oriented approach also provides a solid foundation for future enhancements and easier integration into different parts of the project.
Testing
Extensive testing has been conducted on two mobile devices, a Xiaomi 11 Lite NE 5G and a Motorola One Fusion, to ensure that all changes function as intended, with particular attention to edge cases and robust error handling.
Success:

Dialog Closed: Dialog is opened, but the user either clicks the close button or clicks outside the dialog.

Cannot Find a Matching Credential: No Google account detected on the device.

No Credentials Available: Google Cloud not configured.

Please review the changes and provide feedback. Thank you!

Hey thanks for your PR, I'll have to check it in more details in a few days when I catch some time. So far it looks promising.
In the meantime, I think you could also add deprecation annotation, just to make sure a smooth transition between versions in the future, since there are number of people that are using this library right now. :)

Hey, thanks for reviewing the PR! I'm glad to hear it looks promising. I'll go ahead and add the deprecation annotation as suggested to ensure a smooth transition for everyone using the library.


Cannot find module 'react/lib/ReactComponentTreeHook' from 'ReactDebugTool.js'

After adding and importing this lib, testing with jest shows errors for all test suites:
  ● Test suite failed to run

    Cannot find module 'react/lib/ReactComponentTreeHook' from 'ReactDebugTool.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:179:17)
      at Object.<anonymous> (node_modules/react-addons-perf/node_modules/react-dom/lib/ReactDebugTool.js:16:30)

Part of package.json:
{
  "dependencies": {
    "react": "16.0.0-alpha.12",
    "react-native": "0.46.3",
    ...
  }
  "devDependencies": {
    "jest": "^20.0.4",                               // 20.0.4
    "react-dom": "16.0.0-alpha.12",
    "react-native-mock": "^0.3.1",                   // 0.3.1
    "react-test-renderer": "16.0.0-alpha.12",
    ...
  }
}

Those errors are raised from react-addons-perf which is depended by react-native-mock. The version of react-addons-perf is 15.4.2. I'm not sure whether it is related to the version of react (16.0.0-alpha.12).

I've checked that the module<EMAIL_ADDRESS>depending on ReactComponentTreeHook in react.
// react-addons-perf/node_modules/react-dom/lib/ReactDebugTool.js:16:30
var ReactComponentTreeHook = require('react/lib/ReactComponentTreeHook');

However<EMAIL_ADDRESS>doesn't have that file.
React-Native 0.45 and 0.46 depends on<EMAIL_ADDRESS>I think the dependencies should be updated.

I've got the same problem - I'm using Mocha.  I get:
`module.js:471
throw err;
^
Error: Cannot find module 'react/lib/ReactComponentTreeHook'`
I'm using react-native 0.46.4

This issue would resolve itself if react@16 would come out of alpha. But yes I agree that fixing the dependencies should fix the issue, however i'm not sure requiring ^16 is wise for backwards compatability. Perhaps experimenting with swapping it to a peer dependency might solve it?

The hook was moved from addons to a different location for React 16 as per https://github.com/facebook/react/commit/f2fc1822501456a26b458a17851319904ffabe2a. I'm trying to get this to work with mockery by switching the loader location and will report back if I am able to get it to work

React 16 Beta is out and they have oficially said perf add-ons wont be coming back the same way it was before
https://github.com/facebook/react/issues/10294

and how to fix?

What worked for me was to downgrade to react-native 0.44.x for the time being.
react-native: 0.44.x
react: 16.0.0-alpha.6
Although I'm using create-react-native-app / expo, so I'm not sure if this will work for others.

I'm having the same issue here but my error is coming from react-apollo's react-dom, somebody had a solution? oh! I'm using Jest.

I resolved by upgrading my node to v8.3.0 (npm v5.3.0), removing all the node_modules and then installing all again. Btw, I'm using yarn.

@RealOrangeOne , what is the plan to resolve this?

Is there any valid workarounds except for downgrading react-native? I'm using the latest version of it now.

I've tried to fork this and upgrade it to depend on the latest react but I couldn't get perf tools to work (latest release seems to target 16.0.0-alpha.3).

I made a very simple fork and we can use it for the time being until an officially release.
https://github.com/shqld/react-native-mock

@shqld for a very simple fork you've committed a whole lot of unrelated stylistic changes 😞

@patrys It's like a mock of the future release of this library just for me😞 Fixing some syntax was due to console errors emitted when testing with Jest.

@shqld I'm using your fork in my package.json like this:
"react-native-mock": "https://github.com/shqld/react-native-mock/tarball/master",
but when I install everything, I'm still missing the build directory, and cant seem to build it using npm build. Can you describe how I can install your fork?

@timurridjanovic It's intended that there's no build/ and you don't have to build. To save time building, I've committed https://github.com/shqld/react-native-mock/commit/d1a224dbc3a648af72b7683953c71cee90a369c6 so that it can be directly used without building. (And if you still like to build, you have to npm install in this fork directory first.)

@RealOrangeOne you said "This issue would resolve itself if react@16 would come out of alpha" but I'm not sure if react-native-mock is fully compatible with react 16. React 16 is out of alpha now, so I tried using your package with react version 16.0.0 (and the latest version of react-native 0.48.4), but I still seem to be getting an error when running my tests using react-native-mock (although it does seem to now be a different error from the ReactComponentTreeHook error we were originally getting):

TypeError: Cannot read property 'number' of undefined
at Object. (/node_modules/react-native-mock/build/propTypes/LayoutPropTypes.js:21:31)

All prop types have to be moved from React to the prop-types package to support React 16. Also, all propTypes from react-native are now imported from the root as viewPropTypes instead of from the View object. See the commit below for examples of porting. If no one has picked it up I will try to submit a PR tomorrow
https://github.com/cjcheshire/react-native-multi-slider/commit/6f0d2cb480ccd7190ea9a16e678864f96698d3b2#diff-c71c6f99b408b5a1afd81a3839ce5d4b

@gabceb We are tomorrow :)

I found this issue today, when I tried to test my RN components with enzyme and enzyme-to-json.
I am using:

"react-native-mock": "^0.3.1"
"react-native": "^0.48.4"
"react": "16.0.0-alpha.12"
"enzyme": "^3.0.0"

If somebody has a solution for this it would be very helpful

@jcguarinpenaranda think the author mentions the package is not working with react in alpha.

@ebaynaud it seems that someone beat me to it https://github.com/RealOrangeOne/react-native-mock/pull/130 👍

What is the solution to this error - sorry, I don't understand what #130 suggests as a solution to this error: Uncaught Error: Cannot find module "react/lib/ReactComponentTreeHook"

@MincePi deprecated proptypes import are fixed in #130 (importing from prop-types package directly instead of importing from React). But #130 is not merged yet so still not possible to use react-native-mock without errors with latest react-native version...

At GitPoint, we're using @shqld's fork (https://github.com/shqld/react-native-mock) and it's working fine. I'd suggest using that until #130 is merged (hopefully soon...)

@andrewda I still get errors with @shqld 's fork.

Cannot find module 'react/lib/React' from 'ReactTestUtils.js'

With following dependencies

"react": "16.0.0-alpha.12",
"react-native": "^0.48.4",
"enzyme": "^3.1.0",
"enzyme-adapter-react-16": "^1.0.2",
"jest": "21.0.1",
"jest-enzyme": "^4.0.1",
"react-dom": "^15.6.1",
"react-native-mock": "git+https://github.com/shqld/react-native-mock.git",
"react-test-renderer": "16.0.0-alpha.12",

@fdnhkj I'm not sure but try again with<EMAIL_ADDRESS>

Did someone actually make this work ?

I'm seeing Error: Cannot find module 'react/lib/LinkedStateMixin' which I believe to be of the same cause as this, so an update would be great.

@akahd I have a similar set up to you, and my tests are running without the error. Try to update to latest version of react-dom (16.2.0) and react-native (0.49.3). I'm also using an older version of jest (18.1.0), and I don't have react-addons-perf although that shouldn't interfere with anything.

A solution I found here was: Installing compatible react-dom version as devDependency.
Some people on this thread are using React 16 and react-dom < 16. I think this is the problem.

My solution is to replace react-native-mock with react-native-mock-render
Because the dependency react-dom@15 in react-native-mock is too old for my react@16


travis: run godep restore for non-master branches

Currently, we just run go build ./... in travis. This means that go build ends up using master branches of client-go's dependecies (apimachinery, api) for building the non-master branches. This will fail almost all the time for non-master branches.
So, for non-master branches we should run godep restore && go build ./....

/assign @sttts

/lgtm
/approve


Patterns limitations

On the command pallets, all the commands of generic patterns are limited to the first 20 patterns. The 21 pattern and below are not available. Even if I try searching the name of the pattern it does not work.
Is there any way to have more patterns available?

Thank you for reaching out!
I haven't seen this behavior myself, so I especially appreciate you writing. Would you be willing to paste (or otherwise send) the contents of the plugin's data.json file for your patterns (<vault path>/.obsidian/obsidian-apply-patterns/data.json)? That could help me to diagnose the issue.

Actually, after some tests, I figured it is not actually limited to 20. But it leaves some of the bottom patterns out, in a somewhat random way.
As my data.json has some personal information, I did this one in a Sandbox vault.
As you'll see, the last 2 patterns are not shown in the commands.
data.txt
mands.

@denizido, thank you very much for your time and help creating those example data! They really have helped me to debug.
I believe I've corrected the issue in v2.1.2-beta0, which I've released just now. Would you be willing to try that release and let me know whether it seems to be working correctly?
(The issue was that the plugin automatically filters Patterns that have either no rules, or rules where the from field is blank. There are two such rules in the example data you sent. The plugin was incorrectly processing the indexes of those filtered Patterns, such that the next pattern in the line would be filtered. It's a bug that I'm happy to be correcting now!)

Yes, it did solve it! Thank you very much!
My bad, the issue was in my patterns after all.
If it's not asking too much, would you know if it's possible to change the text case?
As I understand, the plugin uses javascrip flavor, which does not support \U or \L case conversion (https://www.regular-expressions.info/refreplacecase.html).
But I was wondering if there is another way; or maybe if could become a feature in the future.
The only way I can think is to create a very long pattern (A -> a) ... (Z -> z).

Sorry, I didn't mean to close this without a response! I'm glad to hear that this worked! Thank you for raising it!

If it's not asking too much, would you know if it's possible to change the text case?

I'll think more on this. Since it's not supported by the regex parser, I'd like to spend some additional time thinking through how I'd like to implement it. I will keep it in mind!


GenerateGUID shim should more obviously be constant

GenerateGUID doesn't actually generate a GUID--it gives a constant one. This is fine, but it's deceptive and looks random. I don't see a problem in changing it to something to where developers can easily tell its a shim (like 000000-...)
https://github.com/LPGhatguy/lemur/blob/ff37c3e486a2b6dec88abdeda52e6d0f5a7c06f4/lib/instances/HttpService.lua#L26

Funny, I just bumped into this myself.
When I added this, I didn't think too much about it, but you're absolutely right about it being misleading. I think the best solution would be to actually generate something unique so that anything that depends on generated ids will actually get different values.

+1 for "actually generate something unique so that anything that depends on generated ids will actually get different values"


Import .spydata file programmatically

I am interested in a programmatic way to open up a .spydata file containing namespace variables, rather than just the button on the user interface.
Very simple request for a MATLAB-like feature that would increase the power of Spyder-- I have not found any solution on this one, but I have found a previous question related to this topic.
https://stackoverflow.com/questions/45078157/load-spydata-file
It would make things easier as I test code that does several things (i.e. one script that access an API's data, and one script that does a bunch of post processing on that data). Right now, I manually save the workspace and manually open the workspace when working with the post-processing. I would much rather have this done programmatically, as I can ensure the state of the raw API data is the same each time (my second script manipulates  it), and I can test the code on several different data sets with a loop to catch errors.

@CAM-Gerlach, what do you think about adding those functions (with more appropriate names, of course) to the builtins of our kernel?


add @ref.new, mark @ref.ref deprecated

#582
suggested by @tonyfettes

Pull Request Test Coverage Report for Build 2177
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 91.188%

Files with Coverage Reduction
New Missed Lines
%

ref/ref.mbt
1
85.71%

Totals

Change from base Build 2173:
-0.02%

Covered Lines:
3632

Relevant Lines:
3983

💛  - Coveralls


Version 0.8.0

Landed in https://github.com/metarhia/globalstorage/commit/bba6d8278d8c3f090a4d8d5a41e5e9f18b75fbab.


Add support for nested shadow roots

+1 this make ReactShadow difficult to use in prod

@bcherny it's something that's proving to be awfully difficult to implement with a simple mixin – that's why I've started the Maple.js project to bring a more robust approach to HTML Imports, Shadow DOM, and Custom Elements to React. From my point of view, ReactShadow is a precursor to Maple and the former was always meant to be an experimental project to test the water.

Use Maple instead.


updated nanoserver download

since RTM version nano server powershell 5.1 should behave like all other Windows Versions in terms of download and extraction.

Hi @rs38, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@rs38, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

DNFBOT, you're welcome!
:)

@HaoK @blowdart Can you guys take a look?

@shirhatti  please rev iew

Given that the dotnet-install.ps1 script in the CLI repo now works on Nano (thanks to them adding back Invoke-WebRequest 😄), I'd prefer using that script with the right parameters as opposed our own franken script which we have to keep up-to-date.
Also, given the rest of the article still talks about TP5, taking this change would leave the article in an inconsistent state. I'd hold back on merging till we've updated the entire article.
If @rs38 wants to give it a crack, I'd be super stoked. If not, I'm still happy letting this PR sit around if someone wants to continue working off of this as a starting point.

"franken script"  😄
I'll give it a try to update the whole article, if lending some snippets from the Microsoft/Virtualization-Documentation repo is allowed.

if lending some snippets from the Microsoft/Virtualization-Documentation repo is allowed.
That's fine

is there a certain trick to get the markdown docs in Visual Studio 2015 for editing, versioning and previewing?
I already created a custom docFx solution (empty asp.net plus docFX Nuget) but that looked not like expected.

DocFX is broken, we hope to have it fixed soon.

this PR can be closed now