cmd/go/internal/load: (Optionally) follow symlinks referenced by //go:embed

What version of Go are you using (go version)?

$ go version
go version go1.20.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
N/A, applies to any GOOS/GOARCH
What did you do?
In a Bazel build action running in a symlink-based sandbox, try to build the Go standard library or any third-party package using //go:embed.
What did you expect to see?
The build passes just as it would if the input files weren't symlinks. Tools only play nice with Bazel if they follow symlinks, as whether or not an input file to a Bazel build action is a symlink depends on the particular strategy with which Bazel chooses to execute the action (e.g. remotely or locally, in a sandbox or not, ...).
//go:embed not allowing symlinks to be embedded makes sense and I am not asking for that to be changed. However, it would be very helpful if it could be made to follow symlinks, either by default or optionally, guarded by a flag or environment variable.
What did you see instead?
external/go_sdk/src/crypto/elliptic/p256_asm.go:24:12: pattern p256_asm_table.bin: cannot embed irregular file p256_asm_table.bin

This happens because of the use of Lstat in https://github.com/golang/go/blob/3c46d8f5119475adbadb6141acd463b910c1747b/src/cmd/go/internal/load/pkg.go#L2139, which makes symlinks hit the branch at https://github.com/golang/go/blob/3c46d8f5119475adbadb6141acd463b910c1747b/src/cmd/go/internal/load/pkg.go#L2170
This issue requires rules_go to copy around the stdlib and breaks build actions that operate on generated code.

CC @thanm

@golang/tools-team

@thanm This continues to be a problem. If there is anything I can do, such as submit a PR to modify this behavior based on an environment variable, please let me know.

assign me on this task please, I face the same issue

I worked around this by excluding the symlink, e.g.:
//go:embed mydir/[^excludeme]*

And doing another embed for the underlying symlink path.


How to possibly activate footers in kaobook

Dear Mr. Marotta,
I'm currently typesetting a workbook with a lot of help from your amazing kaobook class.
However, one thing I couldn't figure myself: I need to have a logo (vector graphics) in the footer on every even page.
Could you maybe hint me on how to activate footers without changing the rest of this beautiful layout set?
Thanks in advance,
acromarmot

Dear acromarmot,
here is one possibility:
\renewpagestyle{scrheadings}{%
    {\smash{\hspace{-\headmarginparwidth}\hspace{-\headmarginparsep}\makebox[\headtotal][l]{%
        \makebox[7\hscale][r]{\thepage}%
        \makebox[3\hscale]{}\rule[-1mm]{0.5pt}{19\vscale-1mm}\makebox[3\hscale]{}%
        \makebox[\headtextwidth][l]{\leftmark}}}}%
    {\smash{\makebox[0pt][l]{\makebox[\headtotal][r]{%
        \makebox[\headtextwidth][r]{\hfill\rightmark}%
        \makebox[3\hscale]{}\rule[-1mm]{0.5pt}{19\vscale-1mm}\makebox[3\hscale]{}%
        \makebox[7\hscale][l]{\thepage}}}}}%
    {\smash{\makebox[0pt][l]{\makebox[\headtotal][r]{%
        \makebox[\headtextwidth][r]{\hfill\rightmark}%
        \makebox[3\hscale]{}\rule[-1mm]{0.5pt}{19\vscale-1mm}\makebox[3\hscale]{}%
        \makebox[7\hscale][l]{\thepage}}}}}%
}{%
    {\hfill\parbox{1cm}{\includegraphics{/path/to/your/logo}}}%
    {}%
    {}%
}

You should add this in the preamble of your main.tex. If you provide a minimal working example, I could maybe try and be more specific, but in general, for headers and footers you can refer to the KOMAScript guide, in particular page 453.


chore(Perf): Skip undef values in perf charts

Skip undefined values in perf charts. Previously those were charted as 0 which might be confusing.
Also now there is only one onNearestX handler registered as expected.
Microsoft Reviewers: Open in CodeFlow

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Navbar Content Style Update

PR Description 📜
issue number:#222
issue-Feature enhancement- Navbar styling should be changed.
Overall look of the website is very good but navbar content styling and font style is not as the theme of the website. Navbar is the very first thing a user will notice so it should be based on the theme of the website. So I use a good font and apply some CSS styling to change the font styling of the Navbar content.
I am also attaching images of the changes that I have created.

Mark the task you have completed ✅

[X ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ X] I have performed a self-review of my own code or work.
[X ] I have commented my code, particularly in hard-to-understand areas.
[X ] My changes generates no new warnings.
[ X] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ X] I have added screenshot for review.

Thank you soo much for contributing to our repository 💗

Hi @vanisharma2003,
Its a nice font but navbar responsiveness is compromised for some screens. You can fix that with media queries update them accordingly and its done.
Thank You

Okiee I will fix this 😊

I have recently made a commit update. Now, the issue is fixed. Navbar responsiveness is no more compromised.

Pls update


Add base solver mixins and PolyakSGD.

@shoyer Addressed your comments, thanks a lot!

@fabianp Addressed your comments, thanks a lot!

some more minor comments, none important. LGTM!


Arithmetic operations very slow

It looks like this package has a lot of overhead for simple math operations - about 50 times slower than normal floats and uses 20 times more memory! Not even talking about number of allocations.
using BenchmarkTools
using Measurements

a = randn(1000, 1000)
b = randn(1000, 1000)
@btime a ./ b;
#  1.791 ms (4 allocations: 7.63 MiB)
a, b = a .± b, b .± a
@btime a ./ b;
#  88.498 ms (4000004 allocations: 175.48 MiB)

For comparison, an extremely basic implementation from rosettacode has only 4x overhead, which is completely reasonable:
using Main.NumericError

a = randn(1000, 1000)
b = randn(1000, 1000)
a, b = Measure.(a, b), Measure.(b, a)
@btime a ./ b;
#  6.797 ms (4 allocations: 15.26 MiB)

Any chance that performance of Measurements.jl can be improved?

Yes, I'm aware that for large calculations the performance is not ideal.  Try computing the mean of a large vector :persevere:  However, for a large set of uncorrelated measurements there is the weightedmean functions which is much faster and probably what the user is after.
The extremely basic implementation from rosettacode is fast because it doesn't deal with correlation:
julia> x1 = Measure(100, 1.1) # from rosettacode
100.0 ± 1.1

julia> x1-x1
0.0 ± 1.5556349186104046

julia> x = measurement(100, 1.1) # from this package
100.0 ± 1.1

julia> x-x
0.0 ± 0.0

Dealing with correlation is the main source of the overhead.  I prefer something slow but correct to something fast but unreliable.

Any chance that performance of Measurements.jl can be improved?

Not from me, currently, but patches are always welcome :slightly_smiling_face:  The important thing is that functionalities are maintained, this should be an under-the-hood only change.  I've the feeling that performance can be improved, but I've never looked into this very deeply.  Thanks for opening this issue!

I see, correlations indeed can be quite important and it is far from obvious how to speed up calculations while maintaining them. However it would be useful to have another mode (or type, or something) for fast computations without tracking correlations. For even moderately-sized datasets x50 slowdown is very significant, and what is often needed is just simple uncertainty propagation with independent observations.

However it would be useful to have another mode (or type, or something) for fast computations without tracking correlations.

I see your point, and it shouldn't be too hard to implement what you ask, but in my opinion its utility would be very limited (see above message) and would greatly confuse users (which type should I use?  With correlation or not? What if I later change my mind?).
Some overhead compared to plain-bit numbers is to be expected, this type is going to do much more than adding or multiplying simple Float64 numbers.  Large overhead comes when several quantity are involved, performance of calculations involving Measurement objects currently goes as O(n^2).  It would be really great if someone could find a way to improve performance to O(n).


Allow empty issues in AuditOutputs

At the moment I can't add empty issues to a AuditOutput/AuditReport.
This leads to code like this:
  let auditOutput: AuditOutput = {
    slug: 'slug',
    score: 1,
    value: data.length,
    displayValue,
  };

  const issues = rawData.filter(ofInterest).map(mapToIssue);

  // add details if issues given
  if (issues.length) {
    auditOutput = {
      ...auditOutput,
      details: {
        issues,
      },
    };
  }

  return auditOutput;

instead of this:
  let auditOutput: AuditOutput = {
    slug: 'slug',
    score: 1,
    value: data.length,
    displayValue,
    details: {
        issues: rawData.filter(ofInterest).map(mapToIssue)
      }
  };

  return auditOutput;

Changing the typing to allow empty issues would improve DX for plugin authors

@matejchalk Is this closeable?

Is this closeable?

Yes, I don't see why this shouldn't be possible now.

closed as see above


In a split view, the view-head for the scrollable list overlays other window content

This is a little tricky to describe.
List views in a list-detail split view are scrollable divs, separated from window scrolling, which means that position--fixed yields unintended results - the view-head should remain pinned to the top of the scrollable div, but instead is pinned to the top of the window/viewport, which means it can overlay things above/outside the list view, such as the Login/Reg buttons on mweb. There's not really a clean fix that I can think of, since both the list div and the window are independently scrollable, so it's not just a matter of having a variable offset that can account for other window elements.
This might end up requiring a re-think of how split views are constructed.
intended:

actual:

p.s. apologies for the coarse language in the screenshots. that's the way i found it :)

Not sure how the code comments fix the issue? is there a branch with other changes? I'm curious what you ended up with


How to aggregate objects by regex on list

Hi,
I'm trying to extract from 2 collections, where the id of the main as part of a substring into an array inside the second collection.
To understand us, you can think about the Google Firestore refs behaviour.
Es:
First collection object: { "id": "my-uuid-string"....}
Second collection object: {... "refs": "first-collection-name/my-uuid-string"}
Now, I tried several ways to extract the second object list by regex with lookup, pipeline and regex Bson object; but nothing seems to work.
On Compass I successfully extracted the data with concatenation of unwind,match,expr and let variables, but I couldn't translate these to kmongo..
Someone can help me with some tips?
PS: At the moment , I haven't my PC under hands to copy my code, but any help will be very appreciated!

Sorry, can't help here :(


Finger Print Device is not detected

Hi Guys,
Would like to seek help on using this plugin, when i call the function

FingerprintAuth.isAvailable

it returns

Object {isAvailable: false, isHardwareDetected: false, hasEnrolledFingerprints: false}

I am using Cordova and Samsung S5, my screenlock is fingerprint enabled also, anything i missed? tia!

Samsung does not support the Android Fingerprint API on all of their devices.  Unfortunately the S5 is one that does not.


Problem with pymbar API; issues with cubic spline interpolation in TI

Hi,
I'm experiencing the following error when I try to calculate the overlap matrix:
File "/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 1226, in
main()
File "/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 1202, in main
Deltaf_ij, dDeltaf_ij = estimatewithMBAR(u_kln, N_k, P.relative_tolerance, regular_estimate=True)
File "/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 292, in estimatewithMBAR
O = MBAR.computeOverlap()[2]
IndexError: invalid index to scalar variable.
My files can be found at https://www.dropbox.com/sh/sobp5423rm0ubog/AAAmrsxBLSXQVoein7ue9lZTa?dl=0. The command I'm using is: python ~/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py -q xvg -p md -u kJ -c -t 300 -w.
This is only a prototype run to check if my lambda spacing is sufficient, hence the short simulations. The cfm.pdf looks weird as well, though I suppose that could be related to the length of the simulations. This is the first step in my simulation, ie. removing the coulombic interactions for a hydrogen atom.
Kind regards
Dries

I think you may be using an older version of pymbar. Can you check what
version you are using, or that you are using the latest version?
Pymbar changed the number of return arguments from MBAR a while back.
Thanks.
On Fri, Jan 22, 2016 at 5:38 AM, Dries VR<EMAIL_ADDRESS>wrote:

Hi,
I'm experiencing the following error when I try to calculate the overlap
matrix:
File
"/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 1226, in
main()
File
"/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 1202, in main
Deltaf_ij, dDeltaf_ij = estimatewithMBAR(u_kln, N_k, P.relative_tolerance,
regular_estimate=True)
File
"/Users/dvr/Documents/Cheminformatics_tools/alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 292, in estimatewithMBAR
O = MBAR.computeOverlap()[2]
IndexError: invalid index to scalar variable.
My files can be found at
https://www.dropbox.com/sh/sobp5423rm0ubog/AAAmrsxBLSXQVoein7ue9lZTa?dl=0.
This is only a prototype run to check if my lambda spacing is sufficient,
hence the short simulations. The cfm.pdf looks weird as well, though I
suppose that could be related to the length of the simulations. This is the
first step in my simulation, ie. removing the coulombic interactions for a
hydrogen atom.
Kind regards
Dries
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/69.

--
David Mobley
Associate Professor
Department of Pharmaceutical Sciences
Department of Chemistry
3134B Natural Sciences I
University of California, Irvine
Irvine, CA 92697
<EMAIL_ADDRESS>work<PHONE_NUMBER>
cell<PHONE_NUMBER>

I was using the version from pip - upgrading to the master fixed my problem. Thanks. It might be a decent idea to perform a quick version check to ensure that the user's version is up to date.
I'm also getting an error when I try to plot the TI figure, even with the newest pymbar version:
Plotting the TI figure...
Traceback (most recent call last):
File "../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 1226, in
main()
File "../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 1218, in main
plotdFvsLambda()
File "../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 1012, in plotdFvsLambda
plotTI()
File "../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py", line 934, in plotTI
ynew = cubspl[j].interpolate(y, xnew)
AttributeError: 'int' object has no attribute 'interpolate'
Thanks for your help.

Yes, looks like we need to add a version check for that.
I'll have to look into the 'interpolate' issue. Thanks.
On Fri, Jan 22, 2016 at 12:07 PM, Dries VR<EMAIL_ADDRESS>wrote:

I was using the version from pip - upgrading to the master fixed my
problem. Thanks. It might be a decent idea to perform a quick version check
to ensure that the user's version is up to date.
I'm also getting an error when I try to plot the TI figure, even with the
newest pymbar version:
Plotting the TI figure...
Traceback (most recent call last):
File
"../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 1226, in
main()
File
"../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 1218, in main
plotdFvsLambda()
File
"../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 1012, in plotdFvsLambda
plotTI()
File
"../alchemical-analysis-master/alchemical_analysis/alchemical_analysis.py",
line 934, in plotTI
ynew = cubspl[j].interpolate(y, xnew)
AttributeError: 'int' object has no attribute 'interpolate'
Thanks for your help.
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/69#issuecomment-174032734
.

--
David Mobley
<EMAIL_ADDRESS>949-385-2436

I added the version check but still need to deal with the cubic spline interpolation issue.

Hi David, are there other known issues related to using pymbar versions older than 3.0.0, apart from the MBAR.computerOverlap()[2] problem?
I too have been using the pip version (v2.1.0) as it seems the most straightforward way to install external packages into the Canopy environment. I changed MBAR.computerOverlap()[2] to MBAR.computeOverlap(output='matrix') in alchemical-analysis to make it compatible with the older pymbar version, but I now wonder whether there are other more fundamental issues I am not aware of that might have affected the results computed with the older pymbar version.

Matteo,
I really think you should bite the bullet and make all effort to update to
the latest Pymbar version.  Pavel and David may not have made note of all
the changes that were necessary to upgrade to the new version and what it
would mean to use an older version instead.  So you may very well be on a
track of incremental fixes and/or, worse, there could (not saying that
there are) subtle differences cropping up that simply give you wrong
results without noticing it.  It's just not worth it to hunt down any such
issues.  Safest assumption now is that the new version of the analysis tool
firmly relies on Pymbar 3.0.0.  That's also where all the testing is
happening.
Cheers,
Hannes.
On 3 February 2016 at 10:38, Matteo Aldeghi<EMAIL_ADDRESS>wrote:

Hi David, are there other known issues related to using pymbar versions
older than 3.0.0, apart from the MBAR.computerOverlap()[2] problem?
I too have been using the pip version (v2.1.0) as it seems the most
straightforward way to install external packages into the Canopy
environment. I changed MBAR.computerOverlap()[2] to
MBAR.computeOverlap(output='matrix') in alchemical-analysis to make it
compatible with the older pymbar version, but I now wonder whether there
are other more fundamental issues I am not aware of that might have
affected the results computed with the older pymbar version.
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/69#issuecomment-179158201
.

Hi Hannes, thanks for the fast reply, I will indeed update to the latest pymbar asap. I will probably double check the results match what I obtained with the older version just to be sure. I also just noticed David requested an update of the pymbar version on PyPI, which would indeed be useful. Many thanks for all your help.

You could also just switch to using conda for installing... :)
I'm not aware of other issues with older pymbar versions, but I do
recommend updating.
On Wed, Feb 3, 2016, 4:00 AM Matteo Aldeghi<EMAIL_ADDRESS>wrote:

Hi Hannes, thanks for the fast reply, I will indeed update to the latest
pymbar asap. I will probably double check the results match what I obtained
with the older version just to be sure. I also just noticed David requested
an update of the pymbar version on PyPI, which would indeed be useful. Many
thanks for all your help.
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/69#issuecomment-179187274
.

Thanks for the tip! I have been thinking about switching to conda for a while actually, but I haven't done it simply due to inertia, now it might be the time...

Ha, yes. It's sort of magical. Once you configure the omnia channel it's
basically just matter of:
conda install pymbar
Then download and install alchemical-analysis. (On the to-do list: Make
alchemical-analysis conda-installable).
DM
On Wed, Feb 3, 2016 at 6:58 AM, Matteo Aldeghi<EMAIL_ADDRESS>wrote:

Thanks for the tip! I have been thinking about switching to conda for a
while actually, but I haven't done it simply due to inertia, now it might
be the time...
—
Reply to this email directly or view it on GitHub
https://github.com/MobleyLab/alchemical-analysis/issues/69#issuecomment-179277056
.

--
David Mobley
<EMAIL_ADDRESS>949-385-2436

@driesvr - should be resolved by #76 ; can you check?

Yup, looks like everything's working here as well. Thanks!


Add support for angular-universal

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

I'm submitting a ...
[ ] bug report
[*] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

Feature
It would be great if you integrate angular-universal with this starter. I think everybody love server side rendering. If not possible in the master branch then try to create a separate branch like the material2 branch. Thank You.

Hi @sabbirrahman
Check the discussion about Angular-Universal here : #576
Cheers,


Data Science microbyte

Closes #71

Checklist:

[x] Added activities for learners
[x] Didn't give the solutions to the added activities straight away
[x] Followed a LearnByDoing approach
[x] Clean and well documented code (if source code files are involved)
[x] Added images for better understanding if deemed necessary

Hey @Kevinpaulose05
Please review this, all the necessary changes suggested by you and the team are done.
Please feel free to close the remaining PRs.

Hey @Kevinpaulose05
I do agree and understand your concern but try to understand my side of the conversation. I know this is a basic microbyte, but then when I asked in a comment about this like can I proceed with this microbyte I got a positive response from one of the Advocate so I moved for the but nevertheless I will be making more more quality micro bytes for this program where in I will include some real time working project also as I have worked hard on it, after the approval from one of the advocate, I didn't want to drop it anyway, coming up to the the spamming done by me with various pull requests I sincerely apologize for that as I have problem with my I GitHub command line I wasn't able to to make changes into the earlier PR hence I need to create a new and as far as the quality of this microbyte is concerned, I have included a good quality of contained which could help any beginner to cope up and understand basics of it but nevertheless I'll be making more. Also please elaborate on what exactly do you mean by crossing the limits of creator or learner because as far as I am concerned I have worked with the issues and the micro bytes so I dont think I have made something which is wrong.
Concluding, I would say that I will take care of all the things you have mentioned looking forward for more contributions together.
Cheers!

Hey @rutujak24!
What Kevin means by crossing the scope of a learner/creator is you reviewing this PR.
As a participant, you don't encourage you to review it as it the work of maintainers. Since our workflow involves counting of X number of approvals from Y reviews, we need to keep track of all the comments/reviews on a particular PR.
If anyone else out of the maintainer team does such a reviewing act, it makes it hard to keep the lane of our workflow clean.
I hope you understand what I am trying to convey.
Thanks

Hey @rutujak24!
What Kevin means by crossing the scope of a learner/creator is you reviewing this PR.
As a participant, you don't encourage you to review it as it the work of maintainers. Since our workflow involves counting of X number of approvals from Y reviews, we need to keep track of all the comments/reviews on a particular PR.
If anyone else out of the maintainer team does such a reviewing act, it makes it hard to keep the lane of our workflow clean.
I hope you understand what I am trying to convey.
Thanks

Hey @amoghrajesh
Thanks for notifying me about it, understanding the working flow, won't be reviewing any PR further!

Hey @rutujak24!
I just went through the content at is much better right now!
Just one issue from my end -

In the Test Yourself section, you are asking the users to do stuff like 'read some dataset from Kaggle' instead, be more specific and provide the exact one they should be doing so that evaluation of the learner from your end/our end becomes much easier. I mean this point applies to all of your questions - be specific about which two properties you want them to plot a scatterplot against.
In these scatterplots too, what do you want - legend, xaxis label, yaxis label etc. All these needs to be mentioned. (This applies to all your questions)
Provide the cell to write code right below the question as it is already a jupyter notebook file that you have used. It seems more like a notepad right now.

A great start from your end on making the earlier changes.
Do not rush, take your time, and make these.
We will be more than happy to review it.
Thanks for our effort!

All done!

Hey @rutujak24!
I just went through the content at is much better right now!
Just one issue from my end -

In the Test Yourself section, you are asking the users to do stuff like 'read some dataset from Kaggle' instead, be more specific and provide the exact one they should be doing so that evaluation of the learner from your end/our end becomes much easier. I mean this point applies to all of your questions - be specific about which two properties you want them to plot a scatterplot against.
In these scatterplots too, what do you want - legend, xaxis label, yaxis label etc. All these needs to be mentioned. (This applies to all your questions)
Provide the cell to write code right below the question as it is already a jupyter notebook file that you have used. It seems more like a notepad right now.

A great start from your end on making the earlier changes.
Do not rush, take your time, and make these.
We will be more than happy to review it.
Thanks for our effort!

All the required changes are done.

@rutujak24 Activity 2 typo in referencing.

@amoghrajesh and @Ak-Shaw will be reviewing ur PR from here. I am sticking with my earlier review. This is too basic a microbyte and I understand u trying to twitch things to make it the right way. But from this topic u shud have chosen a different approach.
Make sure ur next microbyte is not this way and that we feel a healthy complexity in ur microbyte. Also, make sure u wrap it up before 30th so that we can have a review period buffer.

@rutujak24 Activity 2 typo in referencing.

Yea, corrected.

@amoghrajesh and @Ak-Shaw will be reviewing ur PR from here. I am sticking with my earlier review. This is too basic a microbyte and I understand u trying to twitch things to make it the right way. But from this topic u shud have chosen a different approach.
Make sure ur next microbyte is not this way and that we feel a healthy complexity in ur microbyte. Also, make sure u wrap it up before 30th so that we can have a review period buffer.

Yea...looking forward to get this micro-byte merged.
Agreed with your views, will be taking up "Titanic Survival Project using ML" as a next one.
Open for suggestion!

Kindly showcase your new MicroByte in the #microbyte-showcase channel over at our slack workspace. Kindly use this template for the same.

@all-contributors kindly add @rutujak24 for:

[x] code
[x] content
[x] ideas
[x] doc


Def cannot be used inside a taskDyn

steps
Say you're implementing a dynamic task, and you want its result to be a task whose body executes a collection of tasks sequentially. An example:
    val myTask: Def.Initialize[Task[Unit]] = Def.taskDyn {
      if (foo) {
        Def.sequential(Keys.publish, Bintray.bintrayRemoteSign)
      } else Def.task(())
    }

problem
When compiling the previous task, you'll get:
[error] Illegal dynamic reference: Def
[error] Illegal dynamic reference: Def

expectation
Not getting an illegal dynamic reference.
notes
A workaround is to define your own TaskSequential:
val StableDef = new TaskSequential {}

And redefining the previous task as:
    val myTask: Def.Initialize[Task[Unit]] = Def.taskDyn {
      if (foo) {
        StableDef.sequential(Keys.publish, Bintray.bintrayRemoteSign)
      } else Def.task(())
    }

I suspect this error could be related with the implementation of Def. I think this was done to stay binary compatible.
trait DefExtra {
  private[this] val ts: TaskSequential = new TaskSequential {}
  implicit def toTaskSequential(d: Def.type): TaskSequential = ts
}

another sample:
 lazy val osgiSettings = TaskKey[Seq[Setting[_]]]("OSGi Settings Generator")
  override def projectSettings = List(
    osgiSettings := (if (name.value.nonEmpty) seq() else seq())
  )

http://scastie.org/30771

Seems you can also just introduce some bogus indirection via val Def = sbt.Def outside your task and voilà! It works! (at least for me).

@dwijnand Here is a minimal example. It reproduces only if there is .value call inside taskDyn body
val a = Def.taskDyn[Int] {
  val x = baseDirectory.value // it compiles without this line
  Def.sequential(Def.task({42}))
}


AWSConfigRole deprecation, possible LZ script update (tech debt)

Describe the issue
A message was received about an expiring component possibly used by our Landing Zones.  We need to check that the codebase will run.
Which Sprint Priority is this issue related to?
Additional context
_"As part of our continued effort to provide AWS customers with fine grained and secure permissions management solutions, AWS Config has published a new managed policy called AWS_ConfigRole that is scheduled to replace and subsequently deprecate AWSConfigRole on December 1, 2020. This new policy removes the "S3:GetObject" permission as AWS Config does not need permissions to read S3 objects.
The AWSConfigRole  managed policy will continue working for all currently attached users, groups, and roles. However, effective December 1, 2020, AWSConfigRole managed policy cannot be attached to any new users, groups, or roles. No action is needed if your account does not utilize the AWSConfigRole managed policy."_
Definition of done

Review LZ codebase for AWSConfigRole, and should it be present,
Coordinate with our developers and AWS to update LZ Code (assuming we have it in source control by that point)
Clean off LZ1 and try the code against it to ensure it still runs

No longer relevant


Create method for env var deprecation

resolves #6960
Description
Added a method of warning about deprecated environment variables and implemented it for DBT_NO_PRINT -> DBT_PRINT.
Checklist

[X] I have read the contributing guide and understand what's expected of me
[X] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[X] This PR includes tests, or tests are not required/relevant for this PR
[X] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[X] I have run changie new to create a changelog entry

@aranke That's a good idea, let me play around with that.


Convert "module loader plugin" Gradle script into a proper Gradle plugin

Description
The module_plugin_loader.gradle file is a Gradle script. It should be a Gradle plugin instead, for all reasons mentioned in #121552 and #125009.
More context
For an example of 2 similar conversions that already happened, see:

flutter/flutter#121552 (for flutter.gradle)
flutter/flutter#125009 (for app_plugin_loader.gradle)

This issue is about doing the very same thing but for module_plugin_loader.gradle (including providing backward compatibility).
See also #135392, which should be updated once this issue is fixed.

If somebody would like to work on this - feel free, currently I don't have time to work on this.


broken forge:knife tags

Can confirm. i have the same issue.

I'm having the same problem. After some searching it kinda looks like the Electrum Knife is missing and the forge tag that adds the Electrum Knife to forge:tools/knives points to the missing item. I removed the tag from the .jar file and everything seems to work again.

Can confirm heres my log about it https://mclo.gs/yXNAN6Y

This is on 1.19 right?


Lessons learned

This is sort of an open-ended question, but I am curious if you might summarize (if you haven't already somewhere) some of the key points to keep in mind for creating a VS Code extension like this.
If I were to create an extension like this for another language, what would be a good starting point? What would be some best practices to follow, or pitfalls to avoid?
Thanks for any direction you might suggest and for your work on this extension!

I haven't written anything like that but maybe I should.
Off the top of my head I don't recall many situations where I felt that I needed to go back and redesign something but here are some general observations:

prefer es6 features, enable strict null checking, etc.
use promises/async everywhere right from the start
avoid libraries that require deep integration throughout the entire extension
make each feature as self-contained as possible; keep the overall design modular
avoid premature optimization; decent algorithms are enough; latency is rarely a big problem here
given a choice between jumps in complexity versus simplicity with some duplication, choose the latter

As for where to start, if you want to have a language server I think either the OCaml one or the Agda could serve as an example if you just stripped out the features you didn't need. If you take a look at the server capabilities it shouldn't be too hard to trace down to the individual features in the code base.
That's assuming you want to have it implemented in typescript though. If you already have a tool like merlin available, I would just implement the server in typescript because it will be much easier to get to something usable quickly. If you don't have that, there's less reason to use typescript, but then the whole package (client/server) becomes a lot more work.

Thanks for the feedback. That's probably good enough for me for now. If you ever felt the motivation, I would certainly enjoy reading a write up on some more details of the work you've done on this extension and others. Thanks!

No problem. By the way, if you decide to start working on your own extension or language server I would be happy to give some tips if you run into any difficulties.


Clicking "Finish" on the Booster selection screen sometimes comes back to the same screen in the wizard

...should be seeing "Launch on OpenShift" and "Download" buttons

@edewit maybe it's a conflict with /validate and /next? Better wait for validation before proceeding.

d332658143a8d8e7287551756c0e0c2dbf38b29a

Now this issue is: you have to click "Finish" twice to get to the next screen.  Closer, but not totally there :)


Created file type not getting shared in the channel

During testing of this plugin, I found a bug which is not consistent.
When a user runs the command to create a doc/slide/sheet, and checks the checkbox to share it to the channel as well, the file type is not always shared on the channel.
Steps to reproduce:-

Run the "/drive create < desired file type >" .
Fill the mandatory fields and check the channel sharing checkbox.
Open the channel where the file was shared.

The shared file is not getting reflected in the channel
Note:- This bug is not consistent, you might not be able to reproduce it every time.

Can you share some logs or approx steps which can help me reproduce this issue? @AayushChaudhary0001

@AayushChaudhary0001 can you provide the information requested?

@darkLord19 I tried to reproduce this and I have created a video for the same, which I am attaching below, please have a look.
https://github.com/user-attachments/assets/845d125f-8028-4c79-a245-f2037cc48586
I am also adding the logs which I am receiving below.
{"timestamp":"2024-07-31 11:08:44.975 Z","level":"error","msg":"something went wrong while updating permissions for file","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 403: The user does not have sufficient permissions for this file., insufficientFilePermissions","fileID":"1pLyqJJCmAfoPWNBRo05ayLkRtDGlD6YiM-nbljbFuEw"}
{"timestamp":"2024-07-31 11:08:45.259 Z","level":"error","msg":"Owner of the file performed this action","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","pageToken":"94617"}
{"timestamp":"2024-07-31 11:08:44.976 Z","level":"error","msg":"failed to modify file permissions","caller":"app/plugin_api.go:940","plugin_id":"com.darklord.plugin-google-drive","err":"googleapi: Error 403: The user does not have sufficient permissions for this file., insufficientFilePermissions"}
Please have a look at these of they can help, also let me know if I am missing something from my end.

@AayushChaudhary0001 can you share which apis have you enabled for you gcp project? Also can you tell me if you are able to update permission of file to anyone manually for the doc using the same account you have used for mm connection?

@darkLord19 Yes I am able to update the permission type manually for the doc using the same account.

@AayushChaudhary0001 can you pull this branch https://github.com/mattermost-community/mattermost-plugin-google-drive/pull/11 and use it to test this feature again? Also clear all the data from previous plugin, disconnect and connect your account again

@AayushChaudhary0001 Can you confirm what apis were enabled when this was failing? This is difficult to reproduce.
Did the branch from @darkLord19 resolve the issue for you?

@darkLord19 @BenCookie95 This branch #11 seems to be deleted without merge, can you please let me know form where I can re-test this issue?


create entity for monitoring

We need to manage the monitoring part.
Information will have to be stored in the tosca file, but is better that when we create the customization we generate some information in the DB so that we can get info fast from there also because we need to place there the values that we get from the customization

As a result of #115 we are able to talk with elasticsearch but we need to define the query we need to execute.
Once we have the precise query we will be able to have the information needed to define the table.
At the moment there is:

a part of the query that depend on the filter on the type of logs we are looking for (the host name of the server etc)
a part that depend on the KPI (in this case a reg exp that is applyed to the path of the log)
a part that is required by the use that is the time range

Only 1 and 2 goes in the DB, a standard range is defined.

#151 implement this one


Cold & Flu: Remove test submissions in FormFlow tool

As a program area, I want to test the reporting functionality prior to launch to make sure the report is accurate.
A/C

Remove all "dummy" submissions in the form up to and including May 24

Request from Heather/admin - or can she use the delete function to remove the outdated test records?


Upgrade deprecated runtime nodejs10.x

CloudFormation templates in aws-cloud-video-editing have been found to include a soon to be deprecated Lambda function runtime (nodejs10.x). The affected templates have been updated to a supported runtime (nodejs14.x).
Please note, this pull request has been generated by a bot; please check the base branch and files changed before merging.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This request was included in v2.3.1 (nodejs v14), and nodejs v18 is in our backlog for this solution.
https://github.com/aws-solutions/edit-in-the-cloud-on-aws/releases/tag/v2.3.1


remove double quote to fix link

What changes were proposed in this pull request?
typo leading to broken link in docs
Why are the changes needed?
fix broken link in docs
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
clicked on fixed link

Hi, please change title to [MINOR][Python][ML] Remove double quote to fix link would be better.

thanks, merged to master


[Aura-Safe][Multisig Tx] Display fully text TxHash and address on transaction details

Description
Do not display fully text TxHash and address on transaction details
Environment

Browser: Chrome
Wallet: Keplr
Safe:
Environment: serenity

testnet

Steps to reproduce

Go to https://safe.serenity.aura.network/124:aura18mcggkmwcmdedrt23sh5cst5r9uflhcx878zuj/transactions/history
Check transaction details
Go to https://safe.serenity.aura.network/124:aura18mcggkmwcmdedrt23sh5cst5r9uflhcx878zuj/transactions/queue
Check transaction details

Expected result
Display fully text TxHash and address on transaction details
Obtained result
Do not display fully text TxHash and address on transaction details
Screenshots

Verified FAIL on serenity (05/08/2022)
Not display fully address of Rejected owner


Request: Update LabanEditor to use latest Python version

Currently, the LabanEditor application is dependent of Python2.7.
It would improve ease of installation and usability if it was updated to support at least Python3.7.
Multiple versions of Python can be hosted by popular development environments such as Microsoft Visual Studio 2019 or Anaconda.  However, use of these work-arounds adds complexity to setting up this software system and distracts from the primary focus of gesture analysis.
Additional context
Add any other context or screenshots about the feature request here.

Hi David,
I am very interested in developing technologies to automate the generation of LabanNotation so I forked this proyect and made LabanEditor run in Python 3.8.
I would like to make a pull request on your project if you're interested in it, but I don't know if all the features work correctly on it. Is it possible for you to test this version?
I provide you with the link of the fork I did in my account:
https://github.com/JoeNatan30/LabanotationSuite

Hi Joe,
Thank you very much for your interest in our project.
I'm going to ask you to hold off on a pull request.
We have an update in the works for release later this month with some new features and that we have been running on Python 3.7, but it appears that I should test against 3.8. From what I understand that is generally a trivial port.
If you care to share, we'd love to hear what you are doing with the project!
Cheers,
--dB
David Baumert
Applied Robotics Research
Microsoft Business Incubations Group
Tel:<PHONE_NUMBER>
CONFIDENTIALITY NOTICE: This e-mail message including attachments, if any, is intended for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message. Thank you.
From: Joe @.>
Sent: Thursday, June 2, 2022 9:14 PM
To: microsoft/LabanotationSuite @.>
Cc: David Baumert @.>; Author @.>
Subject: Re: [microsoft/LabanotationSuite] Request: Update LabanEditor to use latest Python version (#4)
Hi David,
I am very interested in developing technologies to automate the generation of LabanNotation so I forked this proyect and made LabanEditor run in Python 3.8.
I would like to make a pull request on your project if you're interested in it, but I don't know if all the features work correctly on it. Is it possible for you to test this version?
I provide you with the link of the fork I did in my account:
https://github.com/JoeNatan30/LabanotationSuite

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FLabanotationSuite%2Fissues%2F4%23issuecomment-1145567876&data=05|01|dbaum%40microsoft.com|61fd598a72bd45ecb15f08da45176be1|72f988bf86f141af91ab2d7cd011db47|1|0|637898264144616797|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Mnc4qqWpy2Z1D9l70%2F70tEdXWH4JFdrYgB4dhYlAebc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFKLXVLQHDNOTBKF6QCA3YLVNGA6ZANCNFSM45U53AKQ&data=05|01|dbaum%40microsoft.com|61fd598a72bd45ecb15f08da45176be1|72f988bf86f141af91ab2d7cd011db47|1|0|637898264144616797|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=e1%2BflwaMGaRNgqZldUafFdNcTkHOmOiC1mU%2Ba0VjG7k%3D&reserved=0.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Add validator:status command to check if a validator signer is online and producing blocks

Description
Create a validator:status command to check the registration, election, and signing status of a validator.
Tested
Manually tested against local testnet
Backwards compatibility
Will not break anything. New command will work with networks that have parent seals in the block header.

I've added a note to the running-a-validator doc to suggest using this command.


Update fs2-core, fs2-io to 2.5.0-M3

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 2.5.0-M2 to 2.5.0-M3.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-pre-release

Codecov Report

Merging #333 (219ba1b) into master (b40f215) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   84.63%   84.71%   +0.07%
==========================================
  Files         106      106
  Lines        1276     1276
  Branches       25       25
==========================================
+ Hits         1080     1081       +1
+ Misses        196      195       -1

Impacted Files
Coverage Δ

...ules/core/src/main/scala/net/BitVectorSocket.scala
88.88% <0.00%> (+11.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40f215...219ba1b. Read the comment docs.


API - always allow contracts to trigger pull payments

As of v1.11, only the recipient of funds can trigger a withdrawal in PullPayments:
function withdrawPayments() public {
  address payee = msg.sender;
  escrow.withdraw(payee);
}

The same thing happens in SplitPayment:
function claim() public {
  address payee = msg.sender;
  ...
}

This means interactions from contracts with these interfaces are limited, since a) they won't be able to receive their funds (unless the respective function call is coded into them), and most importantly b) they won't be able to trigger transactions for another recipient (e.g. have a contract schedule pull payments and another one then execute them in sequence, abstracting the whole thing away from end users).
I think all of these functions should provide an address recipient parameter, and msg.sender should never be used for this purpose (and only to determine origin, e.g. when doing access control).

This could be very error prone, because the address passed as an argument could have a typo and then the result could be catastrophic. Using msg.sender is a safety mechanism, because the user proved to have access to the account in order to send the transaction.
An idea that came to mind is that just like with tokens, this should happen with something like the allowance, that explicitly gives permission to others to send and receive.
I think we should experiment with this for 3.0, not now. Let's keep this one open for discussion.

the address passed as an argument could have a typo and then the result could be catastrophic

This is sometimes true, and I love the idea of using msg.sender as a safety mechanism, but it's not relevant for the case of SplitPayment, because the critical use of the address has already passed. I think we can use that as a heuristic. When a typo in the address does not have critical consequences, we should use address arguments for maximum flexibility; otherwise we should use msg.sender.

Assigning myself as we agreed offline that I'll be leading the signatures part of the API review.

@frangio that sounds like a great starting point - could you dig into the code and provide some examples, to better understand each case?

#1234 presents a somewhat related situation, anyone (not just the beneficiary) can trigger a release of a TokenTimelock. This allows for a contract to be a beneficiary, despite not having a public function that calls release, and for any contract to also trigger said release.

Agreed that it's the same situation. @ddbit would you mind expanding on what you think is the problem with anyone being able to release the funds?

It does not seem a great problem because funds always move to the legit owner, however allowing everyone to trigger such a transfer is against the security principle of least authority. Think of a use case where the holdings grant some dividends as long as they are locked in the contract. The user is forced to wait the timelock before withdraw, but what if he may prefer to keep holding even after the timelock expires? With the current implementation the user doesn't have this option.

@ldub The use case you presented is interesting, although I have a hard time picturing the actual implementation for such dividends. However, I think this argument is not strong enough when compared to the potential enabled by allowing anyone to release funds or trigger pending payments. It means that you can set any address as the beneficiary without imposing constraints on it (e.g. being able to call release on a specific contract), and this leads to great composability.
If someone really needs to control when a release is trigged, they can opt-in to this behavior by using a contract as the beneficiary that rejects funds unless a given condition is satisfied (such as being the originator of the release).


Implement "block system shutdown"

Closes #81.

Merging this now, but with a pretty bad limitation:

It must be running in run_same_process mode. Windows kills all other processes, so in a run with init the the app-process
will be lost. Note that this also mean that the crash handler and worker processes are also killed.

Quote from the window vars doc for system_shutdown_warn.


Blockchain

How is the blockchain integrated into federated learning?
I can only find the code for federated learning.

区块链如何融入联邦学习？ 我只能找到联邦学习的代码。

请问老哥找到了吗

I wanna know how the blockchain integrated into federated learning too!
thx


Font Awesome icons subset for increased performance

The theme would benefit from using a subset of the Font Awesome icons.  Only those icons referenced in the theme would be included.
For example, I am currently using eleven icons:
fa-calendar, fa-chain, fa-clock-o, fa-envelope-square, fa-facebook, fa-google-plus, fa-linkedin, fa-map-marker, fa-rss-square, fa-twitter, fa-twitter-square
I stripped the unused icon styles from _icons.scss, resulting in a file size of 764 bytes, down from 46,979 bytes. A 98.37% reduction.
I then stripped the unused icons from the font files.
Some figures* for one of the font files, fontawesome-webfont.woff2?v=4.6.3 :
Full font: Load time = 3730 milliseconds ; File size = 71,896 bytes
Subset font: Load time = 468 milliseconds ;	File size = 2,312 bytes
Load time and file size are reduced by 87.45% and 96.78%, respectively.
* Offline test via Google Chrome's Developer Tools, bandwidth throttled to Regular 3G.
Theme version: 3.4.8

I agree this is a good idea as far as optimizing your site. I've done this with previous incarnations of the theme and then requests start coming in to add all the icons back.
The issue is people like to use them in their posts, change the table of contents icon, put in menus, etc.
The better solution is if you're only using that limited set you pull them out yourself and trim down the CSS and font files.
Even better you don't use Font Awesome at all and instead go with a SVG icon solution (I've done this with my personal blog) to get even more performance out of your pages.

I have a question: how did You stripped font file from fonts that You are not using?

@hakeryk2 You can use something like IcoMoon. It'll let you add various font sets (eg. Font Awesome) and allow you to select which icons you want. Then it generates the font files and CSS that you could replace with what is included with the theme already.


Add support for US Core 3.1.1 and 6.1.0

Adds support for US Core 3.1.1 and 6.1.0 and makes 6.1.0 the new default. (My understanding is that since 5 is no longer relevant for certification in the US, nobody is likely to use it much but it's still there anyway) The code is starting to be kind of a mess so I started thinking about breaking all the US Core changes into a separate file, but to keep the diff here minimal I ultimately kept things all in the same file. Happy to refactor & break things out if people want that.
This chart was helpful in describing when things were added/removed from US Core: https://hl7.org/fhir/us/core/STU6.1/changes-between-versions.html
Note that just like for 4 & 5, the included documentreference-type VS for 3 and 6 was pre-loaded with the codes we actually use. (The official version uses a compose which apparently our internal ValidationSupport can't handle)
The one module change is in response to a validator error that required that "magic" code to be present.
In addition to the unit tests I used this little script to call the CLI validator to test out the different versions, see output files validate_results_uscore_${v}.txt for results:
for v in 3.1.1 4.0.0 5.0.1 6.1.0; do
  rm -rf output/
  echo Running $v
  ./run_synthea -p 10 --exporter.fhir.us_core_version=$v
  java -jar /Users/dehall/Downloads/validator_cli_6_3_4.jar -ig "hl7.fhir.us.core#${v}" -display-issues-are-warnings -disable-default-resource-fetcher -best-practice ignore -level errors -extension any output/fhir/*.json | tee validate_results_uscore_${v}.txt
done

There will still be some errors using the CLI validator like "Unknown code 'X9999-0'" (for our custom codes) and "Error from http://tx.fhir.org/r4: Unknown filter "tty = SCDG"" (Grahame says this is a VSAC problem) but there shouldn't be anything that suggests a profile error.

Cascading error with 4.0.0:
Error @ Bundle.entry[51].resource/*MedicationRequest/afd04554-8569-7b5f-29d9-17cb446a3b9a*/.medication.ofType(Reference) (line 4227, col8): Unable to find a match for profile urn:uuid:609cc372-6d0b-35f8-de3c-30171ef10a44 among choices: http://hl7.org/fhir/us/core/StructureDefinition/us-core-medication
Looks like a false positive, since the reference is indeed a us-core-medication, but which failed with the Unknown filter "tty = SCDG" message.


For some reason, RE-flex only functions as a text editor

I am on Windows 11 64-bit professional edition. RE-flex worked as intended about a month ago, but today I attempted to use it for the first time in a month. When I ran it with the following arguments (the bin/win64 folder for RE-flex is in my environmental PATH variable):
reflex.exe --header-file=xid.l --prefix=xid
It gave no output. The program continued to run, reading and writing standard input to standard output exactly as I typed it, even deleting text when I pressed backspace. I ran reflex.exe without providing any arguments, and the same situation happened. I then deleted the RE-flex folder, downloaded the latest version from this Github in the early morning hours of June 8 California time. I could not get the version number because I continued to have the same problem when I ran reflex.exe. It seems to act as just a text editor and produces no output except a copy of whatever I type. I even used the same parameters as above (in a folder where xid.l exists), and it's the same thing. The only thing it does is accept standard input, which is copied verbatim to standard output.
No idea what's going on here. I don't know if it's my operating system or something wonky about a DLL or something.

Are you sure you didn't want to actually enter the command
reflex.exe --header-file xid.l --prefix=xid

Note there is no = after --header-file in the command above. The input file is xid.l and you want to generate a header file. In your command there is no input file to parse, so reflex.exe reads standard input.
This is more clear:
reflex.exe --header-file --prefix=xid xid.l


Allow indexing on nested fields

Loki doesn't support indexing on nested fields (period-delimited). This PR adds support for it.
The main change is the addition of the Utils.getIn function which performs the deep lookup functionality. Initially, I replaced all object[path] lookups with this function, but that resulted in a 2x performance penalty due to the string.split('.') that was required for each lookup. So instead, I added a flag usingDotNotation that can be set so that the function knows whether it needs to split the path at all.
I've been testing it on https://www.gatsbyjs.org/ as a replacement for the in-memory DB and it's working great so far.

Thanks @Moocar , I have been offline for a while but I hope to look this over soon.

Thanks @obeliskos for all your great work on Loki! Excited to have this in Gatsby soon.

Great, thanks @Moocar AND @KyleAMathews!  Since this is performance rather than functional related, I will leave option of creating a unit test now or in the future up to you.

@obeliskos thanks! Funny you should mention tests, I just found a bug where nested indexed fields aren't handling the $in operator properly. Expect another PR soon :)

Is the use of this documented (preferably a walk-through)?


doas: add enablePAM option

New option "enablePAM" controls whether to build support for pluggable
authetincation modules. Default value is "true", which correspond to
existing behaviour. Futhermore, with default configuration, this change
do not cause rebuild.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@cole-h @cstrahan Can you please review and merge this change?

@cole-h Applied your suggestions.

Ofborg seems unhappy, but I don't understand why:

@ofborg eval
Master was broken a few times yesterday, causing this issue.

@cole-h Looks like everything is ready now.


Playground map hoverover broken [BUG]

Describe the bug
Hoverover on the maps in playground's Global Flight Dashboard gives error "Cannot read properties of undefined"
To Reproduce
Open playground: https://playground.opensearch.org/app/home#/
Click on hamburger menu > OpenSearch Dashboards > Dashboard
Click on [Flights] Global Flight Dashboard
Scroll down to "[Flights] Airport Connections (Hover Over Airport)"
Even without performing any actions on that map, you get the error "Cannot read properties of undefined", which starts repeating.
Same thing on the [Flights] Departures Count Map
Also, hoverover is a no-op
Expected behavior
No error message.
Hoverovers should show info.
Plugins
Please list all plugins currently enabled.
Query Workbench
Alerting
Anomaly Detection
Notifications
Observability
Security Analytics
Index Management
Snapshot Management
Search Relevance
Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):
Mac Chrome 107.0.5304.110 (Official Build) (x86_64)
Additional context
Add any other context about the problem here.

This issue comes from the official docker image of os and osd, and can be reproduced by using the following docker compose file and run docker-compose up:
services:
  opensearch:
    container_name: open-search-local
    image: opensearchproject/opensearch:2.4.0
    environment:
      - discovery.type=single-node # single node
      - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # minimum and maximum Java heap size, recommend setting both to 50% of system RAM
    volumes:
      - opensearch-data:/usr/share/opensearch/data
    ports:
      - "9200:9200"
      - "9600:9600"
    networks:
      - opensearch-net
  opensearchdashboard:
    container_name: open-search-dashboard-local
    image: opensearchproject/opensearch-dashboards:2.4.0
    environment:
      OPENSEARCH_HOSTS: "https://opensearch:9200"
    ports:
      - "5601:5601"
    networks:
      - opensearch-net

volumes:
  opensearch-data:

networks:
  opensearch-net:

Thanks @BionIT , could we try reproduce with early version 2.3, 2.2
might be regression introduced by https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2352

interestingly, tried official docker image of 2.3.0, 2.2.0, 2.2.1 and all of they failed to start OpenSearch with the following error - is it expected??
uncaught exception in thread [main]
java.lang.IllegalArgumentException: Could not load codec 'Lucene94'. Did you forget to add lucene-backward-codecs.jar?
Likely root cause: java.lang.IllegalArgumentException: An SPI class of type org.apache.lucene.codecs.Codec with name 'Lucene94' does not exist.  You need to add the corresponding JAR file supporting this SPI to your classpath.  The current classpath supports the following names: [Lucene80, Lucene84, Lucene86, Lucene87, Lucene70, Lucene90, Lucene91, Lucene92, KNN80Codec, KNN84Codec, KNN86Codec, KNN87Codec, KNN910Codec, KNN920Codec]
        at org.apache.lucene.util.NamedSPILoader.lookup(NamedSPILoader.java:113)
        at org.apache.lucene.codecs.Codec.forName(Codec.java:118)
        at org.apache.lucene.index.SegmentInfos.readCodec(SegmentInfos.java:511)
        at org.apache.lucene.index.SegmentInfos.parseSegmentInfos(SegmentInfos.java:404)
        at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:363)
        at org.apache.lucene.index.SegmentInfos.readCommit(SegmentInfos.java:299)
        at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:88)
        at org.apache.lucene.index.StandardDirectoryReader$1.doBody(StandardDirectoryReader.java:77)
        at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:809)
        at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:109)
        at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:67)
        at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:60)
        at org.opensearch.gateway.PersistedClusterStateService.nodeMetadata(PersistedClusterStateService.java:309)
        at org.opensearch.env.NodeEnvironment.loadNodeMetadata(NodeEnvironment.java:453)
        at org.opensearch.env.NodeEnvironment.<init>(NodeEnvironment.java:369)
        at org.opensearch.node.Node.<init>(Node.java:432)
        at org.opensearch.node.Node.<init>(Node.java:341)
        at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242)
        at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242)
        at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404)
        at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:180)
        at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:171)
        at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
        at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
        at org.opensearch.cli.Command.main(Command.java:101)
        at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:137)
        at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:103)

@BionIT would you the compose file used to launch 2.3.0, 2.2.0?
We could ask  @peterzhuamazon from infra team to help and confirm. if it is an issue of 2.x image, let's report an issue to https://github.com/opensearch-project/opensearch-build
cc: @dblock

Okay, sorry for the false alarm for 2.3.0. I just re-created 2.3.0 using official docker image using the following docker-compose.yaml and verified that it DOES NOT have same map issue. The issue is for 2.4.0 OS and OSD docker image
version: "3"  # optional
services:
  opensearch:
    container_name: open-search-local2
    image: opensearchproject/opensearch:2.3.0
    environment:
      - discovery.type=single-node # single node
      - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # minimum and maximum Java heap size, recommend setting both to 50% of system RAM
    volumes:
      - opensearch-data:/usr/share/opensearch/data
    ports:
      - "9200:9200"
      - "9600:9600"
    networks:
      - opensearch-net
  opensearchdashboard:
    container_name: open-search-dashboard-local2
    image: opensearchproject/opensearch-dashboards:2.3.0
    environment:
      OPENSEARCH_HOSTS: "https://opensearch:9200"
    ports:
      - "5601:5601"
    networks:
      - opensearch-net

volumes:
  opensearch-data:

networks:
  opensearch-net:

Okay, sorry for the false alarm for 2.3.0. I just re-created 2.3.0 using official docker image using the following docker-compose.yaml and verified that it DOES NOT have same map issue. The issue is for 2.4.0 OS and OSD docker image
version: "3"  # optional
services:
  opensearch:
    container_name: open-search-local2
    image: opensearchproject/opensearch:2.3.0
    environment:
      - discovery.type=single-node # single node
      - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # minimum and maximum Java heap size, recommend setting both to 50% of system RAM
    volumes:
      - opensearch-data:/usr/share/opensearch/data
    ports:
      - "9200:9200"
      - "9600:9600"
    networks:
      - opensearch-net
  opensearchdashboard:
    container_name: open-search-dashboard-local2
    image: opensearchproject/opensearch-dashboards:2.3.0
    environment:
      OPENSEARCH_HOSTS: "https://opensearch:9200"
    ports:
      - "5601:5601"
    networks:
      - opensearch-net

volumes:
  opensearch-data:

networks:
  opensearch-net:

Have seen this issue on my old machine but disappear on a new EC2 AL2.
Then I removed cache and files from my old machine with at least 30GB storage and it success again.
So I am not sure if that is because of my machine setups.
Right now I cannot reproduce this issue tho.

@peterzhuamazon

Right now I cannot reproduce this issue tho.

Can you use 2.4.0? This map issue is for 2.4.0 and we just need to change the version in the yaml file

Thanks @BionIT for quick verify
could we also verify in 1.3.6 and coming 1.3.7
@peterzhuamazon is there a release candidate for 1.3.7 we could verify.

Thanks @BionIT for quick verify
could we also verify in 1.3.6 and coming 1.3.7
@peterzhuamazon is there a release candidate for 1.3.7 we could verify.

Release candidate is this Friday by EOD.

I just tried the docker-compose file from 1.3.6 by the following steps and did NOT find map issue

go to https://opensearch.org/versions/opensearch-1-3-6.html
download docker-compose.yaml and move to desired dir
run docker-compose up -d
go to <IP_ADDRESS>:5601 and add flight sample data
map is working as expected

we have verified it is regression issue introduced after 2.3.0, and 1.3.6
@dblock @opensearch-project/transfer-request would you help to transfer to https://github.com/opensearch-project/opensearch-dashboards

I just tried the docker-compose file from 1.3.6 by the following steps and did NOT find map issue
1. go to https://opensearch.org/versions/opensearch-1-3-6.html

2. download docker-compose.yaml and move to desired dir

3. run docker-compose up -d

4. go to <IP_ADDRESS>:5601 and add flight sample data

5. map is working as expected
   ![Screen Shot 2022-12-01 at 9 56 00 AM](https://user-images.githubusercontent.com/17714150/205125775-b534012b-2023-45ea-a4b0-889ab15b4a77.png)

@BionIT could you compare the diffs between 136 compose 240 compose files?
@seraphjiang I will tranfer.
Thanks.


security: allow separate certificate and CA for Admin UI.

Part of https://github.com/cockroachdb/docs/issues/3415.


eksctl: 0.183.0 -> 0.184.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/eksctl/versions.
meta.description for eksctl is: CLI for Amazon EKS
meta.homepage for eksctl is: https://github.com/weaveworks/eksctl
Updates performed

Golang update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.184.0 with grep in /nix/store/a4466aifx5qj2xqj3bb877scg2rdk66f-eksctl-0.184.0
found 0.184.0 in filename of file in /nix/store/a4466aifx5qj2xqj3bb877scg2rdk66f-eksctl-0.184.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

eksctl
nuv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a4466aifx5qj2xqj3bb877scg2rdk66f-eksctl-0.184.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eksctl https://github.com/r-ryantm/nixpkgs/archive/d7435a3b46abe33f1dfc9a63b7ce25ba9432d463.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d7435a3b46abe33f1dfc9a63b7ce25ba9432d463#eksctl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a4466aifx5qj2xqj3bb877scg2rdk66f-eksctl-0.184.0
ls -la /nix/store/a4466aifx5qj2xqj3bb877scg2rdk66f-eksctl-0.184.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

eksctl
nuv

Maintainer pings
cc @xrelkd @Chili-Man for testing.

@NixOS/nixpkgs-merge-bot merge


STYLE: Rename tool to NiFreeze

Rename the tool to NiFreeze following the voting and the discussion.

This is WIP:

I need to rename the module folder as well.
The README will need to change a little bit so that the description fits appropriately the purpose/use cases.
The repository name will need to be changed as well. GitHub redirects the old name to the new one automatically.

I'd rather wait until early/mid January 2025 to finish this.

Agreed @oesteban. Archiving seems reasonable and less confusing. I'm closing this PR.


Patch "tuned" package to fix CVE-2024-52336 and CVE-2024-52337

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

Patch "tuned" package to fix CVE-2024-52336 and CVE-2024-52337
Change Log

CVE-2024-52336
CVE-2024-52337

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-52336
https://nvd.nist.gov/vuln/detail/CVE-2024-52337

Test Methodology

Pipeline build id: Buddy Build 693512

The failures are existing failures and the buddy build is green.

Auto cherry-pick results:

3.0-dev :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/11651

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=696649&view=results


Issue when running build.py

Hi All,
I am trying to run the build.py command but I get this error. I am on a MacBook and installed the CMake app but I don't how what I need to do in the app to get build.py to work. Here is the error I am getting.

SyntaxWarning: invalid escape sequence '\d'
  m = re.search('Snapshot v(\d+)\.(\d+)\.(\d+)(-([\w\-]+).(\d+))?', log)
sh: cmake: command not found

Thanks

Check https://github.com/lancaster-university/codal-microbit-v2/issues?q=is%3Aissue+cmake


Support when workspace root is not repo root

Support when workspace root is not repo root (old chat panel silently falls back to filename context fetching in this case, which is much lower quality)
Context files are opening in browser

@chillatom needs discovery, to work with @aramaraju


MudDataGrid Filter not working with Reference property

Bug type
Component
Component name
MudDataGrid
What happened?
Adding a column with a reference (that can be null) property then filters and sorting won't work.
<PropertyColumn Property="x => x!.Customer" Title="Customer"> <CellTemplate> @(context.Item.Customer is not null ? context.Item.Customer.Name : string.Empty) </CellTemplate> </PropertyColumn>
Can this be fixed or is it a better way to treat Reference columns in order to have both sorting and filtering workable?
Expected behavior
Filter should work on Reference columns
Reproduction link
https://try.mudblazor.com/snippet/QaGHYJHuIGawpipR
Reproduction steps

Add a reference column
Try to filter on that column

Relevant log output
No response
Version (bug)
6.3.1
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, @iColdoCatalin!
Thank you for bringing the issue. However, I found the provided reproduction to be confusing. When I attempted to reproduce the problem using the given link, I couldn't find the issue you mentioned.
It appears that the line you mentioned should be included in the reproduction:
<PropertyColumn Property="x => x!.Customer" Title="Customer"> <CellTemplate> @(context.Item.Customer is not null ? context.Item.Customer.Name : string.Empty) </CellTemplate> </PropertyColumn>

But it is missing. Furthermore, this line is not compatible with the current reproduction link, as there is no definition of the "Customer" property in the model.
When sharing a reproduction, it is crucial to include all the necessary code so that others can run it effortlessly and observe the problem. Therefore, I kindly request you to update the reproduction and ensure that it contains all the required code.
Thank you for your understanding and cooperation.

Hi I don't know why it didn't save the Reproduction link
Here it is again. LINK

Thanks. Now I see that operators are empty, thanks,

@ScarletKuro any news on this topic?
Ideas on how to treat reference columns for sorting and filtering to properly work?

Hi.
I'm afraid not. The way the filter currently works is that it looks the type of the expression, since the type is Customer it obviously has no clue how to filter it and therefore doesn't offer operators.
To solve your problem, it would require making one of the suggested implantation:

Implement an abstraction that allows users to create their own filters for the XYZ type and add it to the datagrid component.
Ignores null values in the expression chain. And instead of using expression x.Customer to use x.Customer.Name(customer can be null) directly. If I remember correctly, currently it will throw an exception.

But both are pretty big tasks to make it properly. There were attempts for the second option, but the problem is that we need to support many things including the indexers and it needs to be trim compatible.

@ScarletKuro
Ok thanks for the quick response.
I just needed to know if there is something or if it will be done in the near future.
So to be clear filters work only with basic types like int, string ecc not objects.
The next step should be not binding the column to object but instead use another property string that can be empty or has the Customer Name in it right?

So to be clear filters work only with basic types like int, string ecc not objects.

Yes,
number types: int,double,decimal,long,short,sbyte,byte,ulong,ushort,uint,float,BigInteger+ nullable ones
rest: Guid, string, bool, bool?, DateTime, DateTime?, Enum(+nullable).
This are all the types it supports currently.

The next step should be not binding the column to object but instead use another property string that can be empty or has the Customer Name in it right?

Correct, although there is currently another issue. If you have a "Name" property in your parent class, and then you have a nested object with the same "Name" property, it can cause problems. However, I have a fix for this and I'm currently waiting for it to be reviewed.
In the past, there was no PropertyColumn; instead, there was only the Column where you had to define the type and the property as a string. It didn't have support for nested properties and it wasn't compatible with trimming. This is why the PropertyColumn was introduced, but it's essentially built on top of the old Column and has the same limitation of only supporting flat objects. The support for nested properties is not yet on point.

@ScarletKuro
Yeah I saw someone saying something about putting unique names on columns or sorting won't work but I'm glad it will be fixed.
For now I'm gonna stick with CustomerName as string.
Thanks again and keep it going. I really like Mud!!


Add a 'preview' command that lets you preview your submission before a bust starts

Assuming #143 is implemented and we have support for slash commands, it would be nice to have a /preview command that everyone could use. One would use /preview to submit an audio file and submission text to the busty bot, and the bot would respond with a message that only you can read that shows what your submission will look like when it plays live during a bust.
Most importantly, users can check that their album art will be read correctly and that it looks as they expect. When they are happy with their submission, they submit their track by uploading it to busty's mailbox just as they have always done.
Proposed command syntax:
/preview audio:<audio file> <text>

an example:
/preview audio:<audio file> This is a song I made with my main man @qbert.  Vocal help from @J. Colle.

Discord should pop up a prompt to select a file from your OS for the audio file. I'm hoping it can do so automatically and users won't need to type/select audio manually.
Additionally, once #145 is implemented, it'd be nice to include those checks in the output of this command as well.

Think I'm gonna pick this one up, fellers


Added new required functions

Return the value instead of the value or undefined.
getInputRequired
getPathInputRequired
getEndpointUrlRequired
getEndpointDataParameterRequired
getEndpointAuthorizationSchemeRequired
getEndpointAuthorizationParameterRequired

Fixes #824
I also saw that #826 was opened. I can rebase after that PR is completed.
I have added unit tests for everything I added and all tests are passing.

getInputRequired and getPathInputRequired are the important ones but I did the same addition on some other similar methods. If you only want some of those I can remove some of the additions.
I can also adjust naming or anything else if there's a suggestion.

Thanks for contribution! Could you please take a look at comments?

@mmrazik could you please take a look also?

/azp run


Docs: Changed disabled to disable

Description of your changes
Changed disabled to disable

I have:

[X] Read and followed KubeVela's contribution process.
[ ] Update sidebar.js if adding a new page.
[ ] Run yarn start to ensure the changes has taken effect.

Special notes for your reviewer

@isgxr Thanks for contribution! Please sign the DCO to pass the CI.


Loading tweets...

Ticket #171 was closed and it seems to be the same issue. I couldn't find the twitter discussion linked in the ticket either, so I'm posting a new issue.
The front page example code (except #2-5), as well as the code I am using, are showing "loading tweets" and not actually loading anything or producing errors. I would assume this is a twitter API error. Does anyone have any insight?

I doubt this is the same issue as #171, but if it is, then it's not a tweet.js issue, more of a temporary issue with the Twitter API.
More likely is that you've hit the API's per-IP rate limiting of 150req/hr. In development, it's quite easy to hit that limit. There's no real workaround, other than instead using a server-side library which makes less frequent API requests, then serves a cached pre-rendered widget.
-Steve

Here's the page on the API's rate limiting: https://dev.twitter.com/docs/rate-limiting
To confirm this is what's happening, use Firebug, the Inspector in Chrome/Safari, or a debugging proxy to see what responses the API is returning.
-Steve

I completely forgot about the rate limiting in Twitter. I saw your front page sitting on "loading tweets" and thought maybe it wasn't just me.
I had to enable the "Net" tab in firebug to see the twitter response errors. Now to figure out the best way to make this work with your tweet code and 20 different feeds - probably going to have to reduce the refresh rate to nothing and maybe even cache things somehow.
On another note, would it be possible for a seaofclouds feature to show "Rate limit hit (next updated in x mins)" instead of "Loading tweets" since the docs say you get
X-RateLimit-Limit: 350
X-RateLimit-Remaining: 350
X-RateLimit-Reset:<PHONE_NUMBER>
returned.
Thanks for your help!

If it's an option, create a list which follows the 20 accounts, then configure a single widget to follow that list. That has the added advantage of making it easy to change the set of accounts later.
-steve


RFE: Zero width Tab close button.

See the following screenshot. The Tab's close buttons (x) would always take some space even if we don't use them most of time. Wondering if we can make it invisible by default and show up (floating on top of the title) when the mouse cursor is hovering over the Tab title.
For now as a workaround I hide the close button in settings and use hotkeys to close Tabs.

Another option is to reuse the Tab Index. The tab index is actually a button and when move mouse cursor to the tab index it'll dynamically become x and close the tab on click.


FF67 Content Blocking vs Extensions

With Firefox 67 there's now more options when it comes to content blocking.
I'm just wondering which options to enable/disable when I already have the recommended extensions installed.
Currently Trackers and Cookies are enabled, but doesn't uBo take better care of trackers? Or do they complement each other?

The user.js currently sets blocking all 3rd cookies. This will auto-magically put you into custom mode in Option>Privacy & Security>Content Blocking
The user js does not set what "tracking" lists to use - that's up to your or Firefox (when they turn them on for you: see https://www.ghacks.net/2019/06/04/mozilla-enables-tracking-protection-by-default-in-firefox/ ).
I certainly can't hurt to have TP (tracking protection, that's what it used to be called in the UI) on - feel free to turn on the crypto and FP ones. This is content blocking, not spoofing or limiting or blocking actual fingerprints so don't confuse the FP one with RFP.


Issue 4371 incorrect dependencies when install dev packages

The issue
I'm trying to fix https://github.com/pypa/pipenv/issues/4371. I think it's better to consider 2 cases below:

Installing from Pipfile.
Installing from provided packages (the issue itself).

The fix
Installing from Pipfile
I read through the code, and here is what it does when installing packages from Pipfile:

Resolve dev-packages dependencies. Write to lockfile as default.
Resolve packages dependencies. Write to lockfile as develop.
Overwrite duplicated develop packages by default packages.
Install default and develop packages in the lockfile.

Because, dev-packages is resolved separately, there might be a chance where dev-packages is overwritten but its dependencies are not (they aren't duplicated with packages). So I think the result dependency graph would be more accurate if packages is considered as constraint while resolving dev-packages dependencies. Luckily pip provided constraints files.
I modified the code to do the followings:

Resolve packages dependencies. Write to lockfile.
Create constraints file from packages. Skip editable and extras packages as describe in pip constraints files.
Resolve dev-packages dependencies using constraints file above. Write to lockfile as default.
Overwrite duplicated packages. Although dev-packages was resolved with constraints, this step is also important because there some cases constraints might be skipped (editable and extras packages).
Install resolved packages.

Installing from provided packages
When packages are passed as arguments, pipenv does the followings:

Install passed packages without resolving dependencies. Write to Pipfile and lockfile.
Resolving dev-packages and packages independently. Modify the lockfile.
Overwrite duplicated packages.
Install all the packages in the lockfile again. There might be a case it will uninstall the packages from step 1 before installing.

Similar to the first problem, I tried to use default packages as constraints to resolve packages dependencies. I think it is enough to just resolve dev-packages at step 1. Because default packages should be installed directly, and resolved packages at step 2 don't need to be resolved again.
The checklist

[ ] Associated issue
[ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@dqkqd I left a few more notes about areas I think we could further refine the code and reduce duplication.   I think if we can factor out the three spots we write constraint files into a common utility and some of the places we can use @cached_property to allow for simpler and more readable properties.  I think the change makes sense and could be merged, but chipping away at the some more of this type of technical debt would be good.

@dqkqd Nice work!

@matteius Thank you.


.flowconfig in a path different from the sources root

I have many projects and I'd like them to share the same .flowconfig
Is it possible to run "flow start" in a directory A but use a .flowconfig stored in a directory B?

I noticed that start, stop and status in the cli accept a ROOT after the arguments
flow status [OPTION]... [ROOT]
combining [ROOT] and --include I was able to fit in my use case
example for the project A
flow start --include projectApath flowconfgFolder
flow status flowconfgFolder


Generate base class parameters in source-generated Stubs

Generated stubs using bunit.generators do not include [Parameter]-annotated properties from their base class(es):
public class BaseComponent : ComponentBase
{
    [Parameter] public string BaseProperty { get; set; }
}

public class DerivedComponent : BaseComponent
{
    [Parameter] public string DerivedProperty { get; set; }
}

public void StubDerived()
{
    ComponentFactories.AddStub<DerivedComponent>();
}

will generate the following stub:
// <auto-generated>
//   This code was generated by bunit.generators.
//   Changes to this file may cause incorrect behavior and will be lost if
//   the code is regenerated.
// </auto-generated>
#nullable enable
namespace Blazor;

internal partial class DerivedComponentStub : global::Microsoft.AspNetCore.Components.ComponentBase
{
	[global::Microsoft.AspNetCore.Components.ParameterAttribute]
	public string DerivedProperty { get; set; } = default!;
}

I was wondering whether this was intentional or a limitation of source generators and if no, whether you would be willing to accept a PR for this! :)

That is currently a limitation of our generator and a very nice improvement!
And if you are up for the challenge, a PR is very welcome. Thanks for the helping hand @uflowie

Hey, I didn't have time to get to this on the weekend and I can see you are already working on it, thanks for the help!

Yeah - sorry that I was so quick to jump on and "fix" the issue myself.
In a few minutes a new version of the generator should be available on NuGet with the fix.


Cannot install by CocoaPods

I could not install, could you give me advice?
[!] Error installing RxDataSources
[!] /usr/local/bin/git clone https://github.com/RxSwiftCommunity/RxDataSources.git /var/folders/qv/vb8kxrlj5wj3w49fy8q4g34c0000gp/T/d20201120-32546-1qcf96l --template= --single-branch --depth 1 --branch 4.0.1

Cloning into '/var/folders/qv/vb8kxrlj5wj3w49fy8q4g34c0000gp/T/d20201120-32546-1qcf96l'...
fatal: unable to access 'https://github.com/RxSwiftCommunity/RxDataSources.git/': Failed to connect to github.com port 443: Operation timed out

Carthage also
*** Cloning RxDataSources
A shell task (/usr/bin/env git clone --bare --quiet https://github.com/RxSwiftCommunity/RxDataSources.git /Users/yosuke.nakayama/Library/Caches/org.carthage.CarthageKit/dependencies/RxDataSources) failed with exit code 128:
fatal: unable to access 'https://github.com/RxSwiftCommunity/RxDataSources.git/': Failed to connect to github.com port 443: Operation timed out

it works fine, so I close this issue


fix: define macro WITH_AWS in cmake when flag is ON

fix missing preprocessor macro when WITH_AWS is on

Closing this, moved it to DF directly


🐛Bug: Slider thumb loop issue

I have a SliderThumb.svelte component that just renders a single thumb. It receives the thumb builder through context, which is set in Slider.svelte.
<!-- SliderThumb.svelte -->
<div use:melt={$thumb()}>
    <slot />
</div>

Inside Slider.svelte, I render each thumb in an each block.
<!-- Slider.svelte -->
{#each $value as _}
    <SliderThumb />
{/each}

This causes some really strange layout shift. The reason is that, without JS, the thumbs are all positioned at the same place (the first thumb). Apparently, $thumb() just returns the same value for all thumbs.
If I move the each block inside the <SliderThumb> component itself, it works as expected.
Reproduction:
https://stackblitz.com/edit/github-y956xc?file=src%2Froutes%2F%2Bpage.svelte

Are you still able to reproduce this @abdel-17 ?

My ISP blocked Stackblitz for some reason and now I can’t access the reproduction. Can you send it to me on discord? A gh repo works too.

Is this resolved with the recent changes to the slider?


Added working example of Kotlin DSL setup

Being new to the Kotlin DSL it took me a good deal of time to figure out where to put the repo info.  This example is a basic version of what you need to use this under Kotlin dsl.

Looks good. Thanks for the contribution!