Pyramid

Hi,
This module is used to play with pyramid structure. I have never created a module and this one is not finished. But I need a reviewer to check first if it is useful and based class is compliant with opencv.

@alalek Is it possible to use this code http://www.iowahills.com/ inside opencv and this one https://www-users.cs.york.ac.uk/~fisher/software/mkfilter/Vsn1/mkfilter.c
thanks for your answer

Not sure, I can't find a normal license description on these links.

@alalek
about iowallis "Filter design was one of my specialties as an RF engineer. Now that I am retired, I work on these filter design programs when it is too cold in Iowa to ride bicycle. The programs are free." on first page and I'm waiting an answer from this site.
About mkfilter author is dead (https://www-users.cs.york.ac.uk/~fisher/)  and it's free for for non-profit making purposes only.

@alalek There is no problem with iowallis.com I have got an answer from<EMAIL_ADDRESS>If you want I can ask him to insert a license in his code.


Terraform fails to create a schema because of the order of permissions

Apply schema
Error: 003511 (23001): SQL compilation error: Privilege order violation for the future grants on stage. READ should be granted before/simultaneously with WRITE.
Workaround: It works in 2nd run

Hi @verbotenj - thanks for getting in touch.
We're aware of that problem and your WA :smiley: .
This issue will be resolved after code-refactor using snowflake_grant_privileges_to_role terraform resource that we're planning in the near future.

@verbotenj version v2.0.0+ should fix your problem.


Windows/MSVC support and on-flow ideas

Hi, love the library.
I've been playing around with porting it to windows under msvc.
The go function was fairly straight forward although I had to resort to assembly in the end. MSVC doesn't support VLAs, and things crashed if I tried alloca. I think it tries to write to the intervening memory. It ends up looking something like the following:
#if defined _M_IX86
#define mill_rax eax
#define mill_rsp esp
#elif defined _M_X64
#define mill_rax rax
#define mill_rsp rsp
#elif defined _M_ARM
#define mill_rax r0
#define mill_rsp r15
#endif
#define go(fn)
do {
void *mill_sp = mill_go_prologue();
if(mill_sp) {
__asm {mov mill_rax, mill_rsp}
__asm {mov mill_rsp, mill_sp}
__asm {push mill_rax}
fn;
__asm {pop mill_rsp}
mill_go_epilogue();
}
} while(0)
For the choose statement I've taken a different approach. The choose implementation at the moment uses goto labels which is very specific to GCC. The approach I've been playing with looks like the following:
switch (choose(IN, ch1, IN, ch2, END)) {
case 0:
    printf("coroutine 'a(%d)' has finished first!\n", ch1->value);
    break;
case 1:
    printf("coroutine 'b(%d)' has finished first!\n", ch2->value);
    break;
}

choose is then a var arg function which takes an enum (IN, OUT, END, DEFAULT) channel pairs. The value can be accessed as channel->value, which works because the channels pointers are typed (see next). This approach also seems to drastically simplify the choose logic as it doesn't have to track the labels (e.g. I've removed the clause structure and the channel just tracks the list of continuations).
I've also been playing with having the channels be typed. I've played with this concept before with a containers library. To use a channel you would first have a call to DECL_CHAN(name, type) somewhere in the header. You can then use chan(name) as the channel type. For example:
DECL_CHAN(int, int);
void worker(int count, const char *text, chan(int) ch) {
int i;
for(i = 0; i != count; ++i) {
printf("%s\n", text);
musleep(10000);
}
chs(ch, count);
chclose(ch);
}
int main() {
chan(int) ch1 = chmake(int, 0);
go(worker(4, "a", chdup(ch1)));
chan(int) ch2 = chmake(int, 0);
go(worker(2, "b", chdup(ch2)));

switch (choose(IN, ch1, IN, ch2, END)) {
case 0:
    printf("coroutine 'a(%d)' has finished first!\n", ch1->value);
    break;
case 1:
    printf("coroutine 'b(%d)' has finished first!\n", ch2->value);
    break;
}

chclose(ch2);
chclose(ch1);

return 0;

}
Thoughts?

wait what's this https://code.visualstudio.com/Docs

Nice work!
As for the go() part, why not create a pull request? Don't forget to state it's MIT licensed, please, so that I can merge it without licensing issues.
As for choose syntax and typed channels, I've deliberately tried to make the syntax as simple and golang-like as possible. After all, it's a convenience library, so the usability should be goal no.1. Having to specify the type in each command sucks, but it sucks less than having to declare a new type for each kind of channel you want to use.
As for the problem with goto labels, I can re-write the code so that it doesn't use them. It will still need COUNTER gcc-ism but that's supported by MSVC as well.
What do you think?

Interesting.
I kind of like the typed channels as it gives you a certain amount of type safety. In small examples I get your point that not having to type them is useful, but with anything larger than that things start to become a bit unwieldy making sure that you use the right types on the send and receive side.
Maybe I have a slightly different definition of usability than you. Typically I find magical constructs to be annoying and the closer you can make the API match the natural language the better. Otherwise you miss one bit and you get the craziest compile errors imaginable. My personal take would be to not try and match the go syntax correctly (and lets face it you can't), but rather to use the same concepts but in a more C like manner. That way people are less surprised by magic stuff and their effect on break, continue, compilation errors, etc. In this regard the go command isn't too magical, but the in, out, and end are supremely magical.
I'm curious: how would you remove the goto labels, but keep the current API? The reason I suggested the switch statement is that I couldn't think of a different way of moving between multiple code blocks where the setup and jump to was in the same line.

Well, why not use libtask then? It's as C-idiomatic as it can possibly get and functionally it matches mill.
As for the goto labels, the idea is something like this:
int res = -1;
while(1) {
    if (res != -1) {
       goto label1;
   }
   mill_in(...);
   if(0) {
       label1:
       if(res == 1) {
           // code from clause1
          break;
       }
       goto label2;
   }
   mill_out(...);
   if(0) {
      label2:
      if(res == 2) {
          // code from clause2
          break;
      }
   }
   res = mill_wait(...);
}

That being said, if you have an idea of how to allow for typed channels without having to invent a new name for each channel type, I'm all for it. Type-safeness <3

Thanks. I'll give the goto labels a try.
Moving the res = mill_wait up to the top would have the advantage of not needing the end macro.
Just had a look at libtask ... interesting, but the API is fairly clumsy.

Btw, do not take the example above too literally. For example, the call to mill_wait(...) should be at the top of the loop. If it is in the bottom, the values of the variables declared on stack (mill_valX vars) could be overwritten when while(1) rolls over.

Ok, the code now doesn't use goto labels. Let me know whether it helped with your MSVC work.

Thanks I'll have a look at it next weekend. I'm out of office this week.
On May 3, 2015 1:35 PM, "sustrik"<EMAIL_ADDRESS>wrote:

Ok, the code now doesn't use goto labels. Let me know whether it helped
with your MSVC work.
—
Reply to this email directly or view it on GitHub
https://github.com/sustrik/mill/issues/16#issuecomment-98529784.

any chance we can get a CMakeLists.txt for windows like nanomsg? ty :)
https://github.com/nanomsg/nanomsg/blob/master/CMakeLists.txt

Sure, why not, but it's only the tests that's built at the moment.

CMake build is in place now.

yes.. ty!!!  i've been using it. curious about the Statc vs Share lib, and the NN_EXPORTS and NN_EXPORT .. looks  like TTimos branch has different strategy for this.
also btw: sometimes "tcp_shutdown" and "timeo" do fail... not sure exactly, could be only when compiled x86 and Static lib. will put an issue if/when i can recreate

Inactive for several months. Closing it. Reopen as needed.

Doesn't build on Windows

Not supposed to.

Any plans to port this to win? It would be HUGE. We don't dev on Win and don't like it, but all of our customers run it so we have to support it. We would be happy to support it to the extent we have resources to do so. Is there a specific / known list of issues that if solved would enable porting?

You can give it a try. IIRC there's no poll() on Windows. Take poll.inc and rewrite it using select(). Fix other compilation errors. See whether it works.

will take a look thx. Also noticed that sigsetjmp is used in a couple of places. is there a straightforward port for that? I see others have tried the below but am not familiar enough with these functions to know if this will work for the way this lib uses it:
#ifdef HAVE_SIGSETJMP
#define xx_setjmp(BUF) sigsetjmp(BUF, 0)
#define xx_longjmp(BUF,VAL) siglongjmp(BUF, VAL)
#define xx_jmp_buf sigjmp_buf
#else
#define xx_setjmp(BUF) setjmp(BUF)
#define xx_longjmp(BUF,VAL) longjmp(BUF,VAL)
#define xx_jmp_buf jmp_buf
#endif

Use setjmp() instead of sigsetjmp() and longjmp() instead of siglongjmp().

ok thx. on to resource.h...

You won't need it on windows. It's used only in epoll.inc and kqueue.inc and you are going to create your own select.inc anyway.

moving to getrlimit. also, switching to your libdill, to try and solve what appears to be a smaller universe of problems first before the wider one of libmill. sound about right?

getrlimit = resource.h. Same answer as above. As for libdill, as you wish, but notice there's no networking library there.

@mewalig how's progress?

I got through the part that overlaps with libdill-- you can see what I've done in a diff file I attached to a comment to https://github.com/sustrik/libdill/issues/18. have not finished fixing the remaining parts, including incompatibilities in dns/dns.c and other networking-related parts. If anyone would like to pitch in, lmk and I will open a fork or at least send a patch of what I have so far


NH DPH.ELR has permission denied issue.  It needs further investigation and to be resolve

Receiving Org:
nh-dphs.elr
Failed at:
Sat, 6/24/2023, 2:02 AM
Action ID:
24327748
Report ID:
c25abba1-6ff8-4f91-bdd8-f0db128402b6
Report File Receiver:
nh-dphs.elr
File URI:
https://pdhprodstorageaccount.blob.core.windows.net/reports/ready%2Fnh-dphs.elr%2Fcovid-19-c25abba1-6ff8-4f91-bdd8-f0db128402b6-20230622135006.hl7
nh-dphs.elr
Results:
FAILED Sftp upload of inputReportId c25abba1-6ff8-4f91-bdd8-f0db128402b6 to SFTPTransportType(host=nhftp.nh.gov, port=22, filePath=/Home/dhhs.elr.cdc_prime.prd, credentialName=null) (orgService = nh-dphs.elr), Exception: Permission denied, All retries failed. Manual Intervention Required. Send Error report for: c25abba1-6ff8-4f91-bdd8-f0db128402b6 to nh-dphs.elr

There are 4 reports in the ready queue folder that need to resubmit.

Tried to resend to see if the issue still remains.

Tried manaully and RS upload file. All got write permission denied. Emailed Corinne Davis to report the error.

I talked to Ryan, the technical personnel, and he tried to give RS the write permission.  However, it is still unsuccess.

NH SFTP Prod feed is now fixed!!  I am closing this ticket.


Investigate Sonarqube integration with Github Actions

Summary
Some investigation is required to see if we can integrate sonarqube into our pipelines. Sonarqube is a static type checking platform which will identify potential bugs and code smells.

I stumbled on an open source alternative to Sonarqube called CodeQL (https://codeql.github.com/) as I think Sonarqube needs to be hosted somewhere to be used.

CodeQL also integrates nicely to GitHub

https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning-for-a-repository#configuring-code-scanning-automatically

We've added CodeQL which runs on every pull request, but it seems to only scan for vulnerabilities and not code smells like we expected. Our static analysis tests seem to pick up code smells, but leaving this ticket open in case we find a better way of picking them up.


01_gwms_metrics.config comments cause condor_gangliad to crash

Describe the bug
The copyright comments in 01_gwms_metrics.config are not in ClassAd format. When the condor_gangliad attempts to load the classads, it errors out and the condor_master tries to restart it to no avail.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots and/or console outputs to help explain your problem.
Info (please complete the following information):
Stakeholders and components can be a comma separated list or on multiple lines.
If you add a new stakeholder or component, not on the sample list, add it on a line by its own.

GlideinWMS version:
Python version:
OS version:
HTCondor version:
Priority: Priority level of this bug [critical, high, medium, low]
Stakeholders: Concerned stakeholder(s) [CMS, FactoryOps, Fermilab, FIFE, HEPCloud, IGWN, OSG]
Components: The affected component due to this bug [frontend, factory, glidein, documentation, CI, testing, release, factory monitoring, frontend monitoring, ...]

Additional context
Add any other context or supporting files about the problem here.

@timtheisen Is it there a way to add a comment in a ClassAd format file?


feat: add new design for subcategories page

Fixes Issue
Closes #2178
Changes proposed
I have diligently worked on addressing the issue mentioned above. The following changes have been proposed in my pull request:
Description: Modified the old Card component.

Screenshots

Note to reviewers

@rupali-codes
I don't see any major responsive issues here other than sidebar blocking the way and the tooltip description in center.
I think it's okay to merge.


VEP installation: switch to download indexed cache

Apparently something changed in VEP, and now the -u flag passed by bcbio isn't actually honored anymore. That means that the installer looks for the tarball in <vep_cache_dir>/tmp rather than the path bcbio gives.
In other words, it proceeded to redownload a 15G tarball. I found out because I had to download it separately since Ensembl throttles the ISP used by institution, and now I found (12 hours later!) that the tarball was being downloaded again.

From a cursory glance at the VEP code, it looks like it should work. But for some reason mine didn't, even though the downloaded tarball was there.

And the reason is that vep_install now gets the pre-indexed cache, hence the file is different from before, and it doesn't match what VEP expects it to be.
I guess files should be downloaded from ftp://ftp.ensembl.org/pub/release-98/variation/indexed_vep_cache/ now.

It's also a bug in VEP, which can't allow overriding the indexed cache directory:
https://github.com/Ensembl/ensembl-vep/issues/628

Note that this won't be fixed completely until the VEP bug is fixed.

Thanks Luca for being on top of this, especially for working with the folks upstream.

Hi @lbeltrame !
Has it been fixed in VEP? We did not run VEP lately.
SN


boards/rpi_5: add rpi_5_scmi.overlay

Add rpi_5_scmi.overlay which allows to build and run zephyr-dom0-xt application when ARM SCMI is enabled.
The RAM layout is changed when ARM SCMI is enabled and Xen loads zephyr-dom0-xt app at different address 0x30000000, so rpi_5_scmi.overlay allows to cover this case. Also, in the future, it can be extended with DT SCMI nodes.
The EXTRA_DTC_OVERLAY_FILE can be used to apply rpi_5_scmi.overlay.
Build:
west build -b rpi_5 -p always zephyr-dom0-xt --
-DEXTRA_DTC_OVERLAY_FILE=boards/rpi_5_scmi.overlay
The EXTRA_DTC_OVERLAY_FILE can be added in rpi5.yaml.

@oleksiimoisieiev @lorc @firscity


CreateDirectory error

After setting "OutputFile" to $(OutDir)FooBar.dll and deleting the bin folder, the following error occurs:
Error		The "MergeTask" task failed unexpectedly.
System.ArgumentException: Path cannot be the empty string or all whitespace.
   at System.IO.Directory.CreateDirectory(String path)
   at ILMerge.MsBuild.Task.MergeTask.LogConfigFile(MergerSettings settings) in D:\Dev\Github\ILMerge-MSBuild-Task\ILMerge.MSBuild.Task\ILMerge.MSBuild.Task\MergeTask.cs:line 576
   at ILMerge.MsBuild.Task.MergeTask.Execute() in D:\Dev\Github\ILMerge-MSBuild-Task\ILMerge.MSBuild.Task\ILMerge.MSBuild.Task\MergeTask.cs:line 164
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()	FooBar

The workaround is to specify $(ProjectDir)\\bin\\Debug\\FooBar.dll instead.
I also noticed another quirk where setting "OutputFile" to $(OutDir)\\FooBar.dll doesn't produce an error, but actually creates a folder called "$(OutDir)" in the project directory.

@fmerkel thanks for your feedback.
Man its been a while I don't stop by here. My delay is due to email notifications issues that I hope I fixed for good this time. My apologies.
Please take a look at the "Using Variables" section of the documentation:
https://github.com/emerbrito/ILMerge-MSBuild-Task/wiki/Config-File
If you want your target folder to be "[project_folder]\bin\Debug\" you should be using "$(TargetDir)" instead, $(OutDir) as you may have noticed is not supported.


PLCT Open Wishlist for RISC-V 2021

The PLCT Lab is inviting everyone inside the RISC-V community to write to us
the dev-tools or other softwares you wish to have in the RISC-V ecosystem.
Feel free to open an issue on plctlab.org[0] and describe the tools you want.
A few simple rules should be met:

Only open source projects are considered.
Softwares that have not been ported to RV64G are prefered.
Language VMs, Compilers, and Performance Analyzing tools are prefered.

There are some items already on the wishlist:

Enable Firefox/Spidermonkey running on RV64GCV platform[8].
Speed up more than 100x compared with OpenJDK/zero for Java applications[7].
Ensure the speed of JS/WASM on RV64GCV is on par with AArch64.
Enable DynamoRIO running on RV64GC.

Feel free to contact us and add more items on the wishlist.

A global map for RISC-V software ecosystem is needed, so that everyone can lookup and query status of a specific software easily.  Though we do have a link in GitHub https://github.com/riscv/riscv-software-list, it is not well-organized and user-friendly.

https://plctlab.github.io/PLCT-Roadmap-2021.html

https://plctlab.github.io/PLCT-Roadmap-2021.html


ui-select2 bower install command ?

https://github.com/angular-ui/ui-select/wiki/Getting-Started
TL;DR: bower install angular-ui-select

Who knows.. he asks for "ui-select2", so that should be bower install angular-ui-select2.. lol


Minimal fix for docstring check for Flask-RESTful.

Simpler fix.

The idea is that if it has a dispatch_request method and it is documented then it will use its documentation. Otherwise it will fallback to using the class method $verb's documentation. I think that was the intent anyway. I think it's better to prefer the dispatch_request docs if there are any but fallback to the verb's docs otherwise.
Previously it just checked whether dispatch_request existed and if so, it only checked the class directly, not the verb method.


Key for terrain elevations

Check it out here: http://culebron.github.io/atc/
(SBGL or KSFO)

Can you offset the key by 0.5 pixels?

Did you mean add .5px between the boxes? See at http://culebron.github.io/atc/

No, I meant offsetting x and y by 0.5px (with cc.translate(0.5, 0.5)). (On my non-HiDPI display, the edges are on a half-pixel boundary, so they're blurred and 2px wide.)

Ok, did that. The text was also blurred, I fixed it as well.
before and after:


feat: add NODE_NAME env var with spec.nodeName fieldRef

required for https://github.com/sematext/agent/pull/1068

Pfff merged to wrong branch... new PR:https://github.com/sematext/helm-charts/pull/33


Add "copy" interaction between current textbook page and sidebar

Copy code in CodeCell over to the CodeCell in the side panel
Design shown here

This is done by way of #1162


Change login from username to email

There is no longer a need to use a username to login.  Back then it was used to have multiple users for one email address. With the changeover to the email address, you only have to remember one thing in the future.

The username is still desired.
Therefore I changed the login, so that the username or email can be entered.
The feature is implemented in version 1.9.


DIDComm methods to prevent replay attacks

As far as I'm aware, the only requirement of content layer messages is that they include an @type field. I believe it may be necessary to also require the @id field or a timestamp in order to prevent replay attacks. While I'm not able to think of how it could be abused right now because the content is encrypted, I think it would be best practice for us to include something of this nature to prevent this from being combined and abused later.
@TelegramSam can you comment on the requirements of the content layer?
@mikelodder7 any thoughts on this based on what you're aware of?

Including @id would prevent replay and should be a best practice. Adding a separate nonce when you have @id is redundant and should be avoided. IMO we should not require @id because replay is not necessarily an error.  For example, if I send the same tic-tac-toe move twice, or 200 times, it shouldn't matter. The protocol is idempotent, and it doesn't depend on the @id or a nonce or anything like unto it. Thus, I think reply is a concern for the problem-domain-specific protocols, not for the lower level of DIDComm. But it would be good to add  a comment to the RFC about protocols (0003), suggesting that they require @id if they are worried about replay--and probably a section to the RFC about DIDComm best practices (0074) to the same effect.

Extra documentation about best practice with @id was added in PR #374, which is now merged. Closing issue. Please reopen if you think that's premature.


Expense Items / Overall

US04.01.01
As a claimant, I want to make one or more expense items for an expense claim, each of which has a date the expense was incurred, a category, a textual description, amount spent, and unit of currency.
US04.02.01
As a claimant, I want the category for an expense item to be one of air fare, ground transport, vehicle rental, private automobile, fuel, parking, registration, accommodation, meal, or supplies.
US04.03.01
As a claimant, I want the currency for an expense amount to be one of CAD, USD, EUR, GBP, CHF, JPY, or CNY.
US04.04.01
As a claimant, I want to manually flag an expense item with an incompleteness indicator, even if all item fields have values, so that I am reminded that the item needs further editing.
US04.05.01
As a claimant, I want to view an expense item and its details.
US04.06.01
As a claimant, I want to edit an expense item while changes are allowed.
US04.07.01
As a claimant, I want to delete an expense item while changes are allowed.
US04.08.01
As a claimant, I want the entry of an expense item to have minimal required navigation in the user interface.

I've put anything under this list in the wiki under Expense Items / Overall.


Don't remove VIPs on reload

Fixes #96
Cleanup() in Reload() was added to fix duplicate VIPs. The health check now properly detects if instance is in backup state and contains a VIP, trigger a shutdown, which will remove all VIPs so this is no longer needed.

Coverage increased (+0.02%) to 15.014% when pulling d0542a7ba7e20a001ccc3ea731699e4e22865748 on steven-sheehy:dont-cleanup-on-reload into 565d438ad128758a9fd6c8d0781c06b7ea1bd737 on aledbf:master.

@steven-sheehy thanks!


⚠ Bofrost.com has degraded performance

In 5a1f65f, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 533 ms

Resolved: Bofrost.com performance has improved in 4afe75d.


Add an conditional option to add esp-idf-svc/hal

I think most people want also esp-idf-hal / svc crate when generating an std template. This PR adds the option to generate them only when selecting the std option + gives 3 option [No, default option, all options]

JFYI neither the esp-idf-hal nor the esp-idf-svc crate require or need std. Of course, without std you can't spin a thread, but you can use unsafe freertos apis from esp-idf-sys or who knows - in future we might make the freertos-rust safe bindings working on top of esp idf... but yeah, without std the value of these crates is somewhat lower.

yeah, though it is true, before this patch, esp-idf-svc was( is) always included in the no_std arm but never in the std arm. Because i never worked with the hal in combination with  no_std i opted to build this on top of the std arm and dont touch the other things. So the option to not included it or include all features would not apply to the no_std case right?

esp-idf-svc was included in the no_std arm and not included in the std arm because with std, you can just use println! to say "Hello!" to the user. With no_std, your only other non-complicated option is ::log::info!, bit that guy happens to be implemented in esp-idf-svc hence why you needed it for that case...


Added throw error when event function name is long

Description

Added exception handling for cases where event function names are long.
The problem is that if the function name is too long, the function name is cut off and lambda cannot be called from the Event Bridge.

GitHub Issues

https://github.com/zappa/Zappa/issues/1036

Coverage decreased (-0.05%) to 74.5% when pulling 920d2ad210862350369f60e4e1ff3dd030f07a5a on feature/issue-1036-validation-event-settings into 73ee393dd48500d321d65e92aba31a5fd83e93ab on master.

Hey there folks - I was looking over this PR this evening and thinking about the issue it aims to solve and I got to wondering... is this PR actually necessary?  What problem is it actually solving?  And for whom?
I know AWS has a character limit for event function names, but should our solution to that be to throw another Exception at our users for each of their event function names that exceed that limit?  Because I believe we resolved the handling of that several years ago in a more elegant way with #1080, and I would've expected that #1080 would've been able to solve the issue referenced here (#1036) as well, since it allowed for event function names of any length to be given to Zappa's config, and it would automatically handle making sure that they ended up with nice, uniquely identifiable names that conformed to AWS limits.
Now, since #1080 was actually merged several months after #1036 was opened, the user who had the complaint in that issue may not have gotten a chance to try the new functionality out that may have solved the issue they were having.  In any case, the user has never once returned to follow up on the issue since they made it over 2 years ago (and if we were on top of our issue pruning, that issue would have been closed as stale over a year ago 😄), so it doesn't seem like it caused them too significant of a problem - perhaps they tried a release with #1080 present in it shortly afterward and that solved their problems after all.
In any case, I'm especially curious then why we felt the need to prioritize handling a 2+ year old stale issue that, in all likelihood, sounds like it may have already been fixed years ago by #1080.  And, that aside, I'm also a little confused by the approach found in this PR (#1205).  If I understand correctly, this PR seems like it would change the behavior introduced in #1080 so that now, a user including a long event function name in a Zappa config will halt the deploy/update process in its tracks, and put the onus on the user to manually rename any/all of their event function names which are too long by AWS standards.  And better still, it looks like the Exception it gives is for the first event function name it finds that is too long, even if there are hundreds.  So, are users just expected to try to run zappa deploy hundreds of times and rename the event function names called out by the Exception one-by-one until they no longer hit this new Exception?
I've worked at places where we had literally thousands of event functions with names in our Zappa config that exceeded the AWS character limit, which was one of my motivators for developing #1080 - it was literally faster to create that PR that to rename all of our event functions and find and rename them in all of the places they may have been named in other repos/documentation/wikis/trainings/etc. within my organization.  If we got an error telling us we needed to change a different event function name each time we tried to deploy 5000+ times in a row, that wouldn't exactly be a great user experience (and a great waste of a week).
So, anyway, to conclude my old man shaking fist at sky rambling, my first impression of this PR is that it might be a regression that puts work we've solved years ago for our users right back onto our users' plates. So, what is the compelling reason for why we need to now halt users' deploy processes to explicitly tell them that they need to manually shorten their event function names one-by-one rather than have Zappa continue to shorten all of their event function names for them automatically like it has been doing without incident for years?
Maybe I'm missing something obvious (wouldn't be the first time 😄), but I'm just not sure I understand the thought process that led to this PR being considered necessary to create, for numerous reasons.


typo README.doca instead of README.adoc

i was pointed to this github repository to fix it but a search in github provides no result for this typo, please redirect if needed

This issue was moved to fabric8-launcher/ngx-launcher#325


xcode build exits with error 65: Incorrect hash?

info dyld: Library not loaded: /usr/local/opt/readline/lib/libreadline.7.dylib
  Referenced from: /usr/local/bin/awk
  Reason: image not found

info Incorrect hash:

info 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc ?/Users/user/Library/Caches/com.facebook.ReactNativeBuild/glog-0.3.5.tar.gz

info Retrying...

info Failed to successfully download 'glog-0.3.5.tar.gz'. Debug info:

info -rw-r--r--  1 user  staff  532275 Jun 26 14:17 /Users/user/Library/Caches/com.facebook.ReactNativeBuild/glog-0.3.5.tar.gz

info 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc  /Users/user/Library/Caches/com.facebook.ReactNativeBuild/glog-0.3.5.tar.gz

info Command PhaseScriptExecution failed with a nonzero exit code

React Native Environment Info:
System:
OS: macOS 10.14.5
CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
Memory: 110.84 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.17.0 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
IDEs:
Android Studio: 2.3 AI-162.4069837
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.9 => 0.59.9
npmGlobalPackages:
react-native-cli: 2.0.1
Steps To Reproduce

npm install -g react-native-cli
react-native init MyProject
cd MyProject
react-native run-ios

Describe what you expected to happen:
I just got back into react-native. Was previously using expo-cli and decided I wanted to handwire a bit so I tried out react-native-cli. I expected run-ios to launch the simulator and dev environment as stated in the getting-started tutorial. Tried clearing cache to no avail. What is going on here?

+1
I tried run a totally new project and throw same info

I followed a breadcrumb trail that led here:
https://stackoverflow.com/questions/54725742/why-am-i-unable-to-use-glog-due-to-incorrect-hash
Is this something to do with the libreadline.7.dylib? not being referenced?

Following on the stack overflow advice. You could create a symlink to your version 8 readline library.
ln -s /usr/local/opt/readline/lib/libreadline.8.dylib /usr/local/opt/readline/lib/libreadline.7.dylib
I've looked at brew but getting previous of readline looks hairy. While not elegant, this looks to be the only way till this gets addressed. Again, I'm not an expert at sysadmin stuff, but at least I got the build successful for now. I think its something to do with the Mojave upgrade.

After a little digging, I found the problem to be gawk
For macOSX: brew upgrade gawk. So no need for symlinks!


Option to avoid spaces around string concatenation operator (..)

Is there config option to avoid spaces around string concatenation operator (..):
local esc_clear_line = esc.."[2K"

Now it formats like this:
local esc_clear_line = esc .. "[2K"

not yet，but you can request this feature and give this option a name

keep_spaces_around_concatenation_operator?


Let dso_loader handle variations in the name of libcuda better on Mac

Also tested on Mac GPU using experimental job (Jenkins login required to view log):
http://ci.tensorflow.org/job/experimental-cais-mac-gpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON3,label=gpu-mac/2/console

Fixes #6693

@martinwicke, does this look good to you?

It looks fantastic.


Add Telegram notifications

From user feedback we know that many foodsaving groups use Telegram groups as primary communication channel. It would be nice if karrot could send out notifications to Telegram groups. As a start, I would only enable the daily pickup notifications.
The telegram group should be set per karrot group.

https://github.com/python-telegram-bot/python-telegram-bot seems the libary to use

@nicksellen hi, do you or anyone else working on this feature?

So far I just played around with the bot library and we discussed a flow that might make sense.
There would be one bot registered per karrot deployment. Someone would invite the bot into their group and ask it to register a group. It would then give you a code you can copy and paste into the group settings page.
That just gets the registration done. The next part is working out what to send to it. That could be quite tricky.
I have a work in progress branch on my laptop which I could push at the weekend.
Are you interested to work on it?

Also this isn't a starter task so you would need to have done experience already before taking it on. What do you think?

Yes it isn't a starter task but i have been working with facebook chatbots lately with api.ai. I am interested to work on it this weekend. I will share the code with you guys and if it would make any sense, you can accept it or we can modifiy it as per suggestions if it is possible ?

How would you add telegram notifications @khalilchoudhry ? Do you think api.ai would improve this significantly?

https://github.com/yunity/karrot-backend/tree/telegram-notifications is my branch from ages ago. I can't remember the state of it. Don't expect much.

Just floating around the issues now and can't help but think that this could be an interesting candidate for Matrix open protocol bindings. All groups can use whatever chat application they want (the inevitable 'support X chat application' feature request) to send messages to the Matrix room using a bridge for their app. That would require some extra infrastructure though (a homeserver for each Karrot instance, I think).


Question: Where to find the Keycodes?

I have a TV which responds to this kind of remote control. One button I would use, though, is the one to open the source menu (to choose hdmi1-3, AV or tuner). None of the key codes in your list seem to work, though.
Google didn't really help me (I just found another github project implementing this with a different frontend), so I try it this way:
Can you tell me where you found this codes? Is there a spec or a firmware one can get these codes out of?
Thanks

Unfortunately I don't remember where I originally got them.
Most likely I sniffed the traffic of my phone while using an app but I am not sure about that.


Convert Vec to Robj

Not sure if this is useful at all or if we want to have this kind of wrappers.
It took me a while to realize it was this simple :)

This is a side effect of the List() wrapper which will convert many types, including Vec to lists.
I would like to finish the NamedList wrapper if anyone wants to give it a go. The same deal, but generate
two vectors, one for the names and the other for the data from one (&str, Into) iterator.

I'm trying to get time to document the wrappers in the book. Forgive me if I'm a bit slow.

I'll try to put a List example into the main module documentation.


Choosing regex library

Could use the main regex library or the lower level regex_automata. Looks like regex has technically no dependancies (but optionals are probably enabled) and the other has 1 normal dep and 2 optional ones that may not be used.
Probably best to use the normal regex but still up for debate.

Currently don't need any sort of regex implementation. Will reopen accordingly if needed.


Track license and credit honors upstream

Issue opened upstream as https://github.com/djinn/khhota/issues/3
Escrowed at http://web.archive.org/web/20210805100834/https://github.com/djinn/khhota/issues/3

Pull request was raised at https://github.com/djinn/khhota/pull/2


aiohttp restriction

I think this restriction is too restrict:
https://github.com/tsv1/amqp-mock/blob/575efee475677b5c0ca75deb4f27b0e7192e0a56/requirements.txt#L1
should be:
aiohttp>=3.5,<3.9

Thanks for your suggestion on aiohttp versioning. I've updated it to <4.0 and adjusted the code accordingly.


Revert "Use new jvm element for tester container JDisc memory setting"

Reverts vespa-engine/vespa#9651
@hmusum We need the old syntax until Vespa 6 is complete removed. I assume the old syntax is still supported?

It does, with 99.999% certainty :p


Intermittent spec failures

When running the Sneakers spec suite, I get random spec failures every 5 or 6 times I it. Here's a sample:
Finished in 1.378827s, 36.2627 runs/s, 34.0869 assertions/s.

  1) Failure:
Sneakers::Worker::#initialize::builds an internal queue#test_0001_should build a queue with correct configuration given defaults [/Users/norman/work/flexminder/sneakers/spec/sneakers/worker_spec.rb:170]:
--- expected
+++ actual
@@ -1 +1 @@
-{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>5, :prefetch=>10, :threads=>10, :durable=>true, :ack=>true, :amqp=>"amqp://guest:guest@localhost:5672", :vhost=>"/", :exchange=>"sneakers", :exchange_type=>:direct, :hooks=>{}, :handler=>Sneakers::Handlers::Oneshot, :heartbeat=>2}
+{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>5, :prefetch=>10, :threads=>10, :durable=>false, :ack=>true, :heartbeat=>1, :amqp=>"amqp://someuser:somepassword@somehost:5672", :vhost=>"/", :exchange=>"another_exchange", :exchange_type=>:topic, :hooks=>{}, :handler=>Sneakers::Handlers::Oneshot}

  2) Failure:
Sneakers::Worker::#initialize::builds an internal queue#test_0002_should build a queue with given configuration [/Users/norman/work/flexminder/sneakers/spec/sneakers/worker_spec.rb:177]:
--- expected
+++ actual
@@ -1 +1 @@
-{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>1, :prefetch=>40, :threads=>50, :durable=>false, :ack=>false, :amqp=>"amqp://guest:guest@localhost:5672", :vhost=>"/", :exchange=>"dummy", :exchange_type=>:direct, :hooks=>{}, :handler=>Sneakers::Handlers::Oneshot, :heartbeat=>5}
+{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>1, :prefetch=>40, :threads=>50, :durable=>false, :ack=>false, :heartbeat=>5, :amqp=>"amqp://someuser:somepassword@somehost:5672", :vhost=>"/", :exchange=>"dummy", :exchange_type=>:topic, :hooks=>{}, :handler=>Sneakers::Handlers::Oneshot}

50 runs, 47 assertions, 2 failures, 0 errors, 0 skips
Coverage report generated for RSpec to /Users/norman/work/flexminder/sneakers/coverage. 711 / 780 LOC (91.15%) covered.
rake aborted!
Command failed with status (1): [ruby -I"lib:spec" -I"/Users/norman/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib" "/Users/norman/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "spec/sneakers/cli_spec.rb" "spec/sneakers/concerns/logging_spec.rb" "spec/sneakers/concerns/metrics_spec.rb" "spec/sneakers/publisher_spec.rb" "spec/sneakers/queue_spec.rb" "spec/sneakers/sneakers_spec.rb" "spec/sneakers/support/utils_spec.rb" "spec/sneakers/worker_spec.rb" ]

I'll look into it further on my end but I wanted to log the issue to track it in case anybody else is seeing it.

Replicated:
$ SEED=38452 rake
Run options: --seed 38452

# Running:

EEE..............................................................................

Finished in 1.710113s, 47.3653 runs/s, 46.1958 assertions/s.

  1) Error:
Sneakers::Publisher::#publish#test_0001_should publish a message to an exchange:
NoMethodError: undefined method `info' for nil:NilClass
    ../sneakers/lib/sneakers/publisher.rb:14:in `publish'
    ../sneakers/spec/sneakers/publisher_spec.rb:14:in `block (3 levels) in <top (required)>'

Failure:
Sneakers::Publisher::#publish#test_0001_should publish a message to an exchange:
publish("test msg", {:routing_key=>"downloads"})
Called 0 times.
Expected 1 times.

  2) Error:
Sneakers::Publisher::#publish#test_0002_should publish with the persistence specified:
NoMethodError: undefined method `info' for nil:NilClass
    ../sneakers/lib/sneakers/publisher.rb:14:in `publish'
    ../sneakers/spec/sneakers/publisher_spec.rb:25:in `block (3 levels) in <top (required)>'

Failure:
Sneakers::Publisher::#publish#test_0002_should publish with the persistence specified:
publish("test msg", {:routing_key=>"downloads", :persistence=>true})
Called 0 times.
Expected 1 times.

  3) Error:
Sneakers::Publisher::#publish#test_0003_should publish with arbitrary metadata specified:
NoMethodError: undefined method `info' for nil:NilClass
    ../sneakers/lib/sneakers/publisher.rb:14:in `publish'
    ../sneakers/spec/sneakers/publisher_spec.rb:36:in `block (3 levels) in <top (required)>'

Somewhat related: would a PR adding Travis CI support to the project be welcome?

@rud that's an excellent idea.

Reproduced on Travis:
SEED=34780 rake
Sneakers::Worker::#initialize::builds an internal queue#test_0001_should build a queue with correct configuration given defaults [/Users/rud/Projects/furious panda/sneakers/spec/sneakers/worker_spec.rb:162]:
--- expected
+++ actual
@@ -1 +1 @@
-{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>5, :prefetch=>10, :threads=>10, :durable=>true, :ack=>true, :amqp=>"amqp://guest:guest@localhost:5672", :vhost=>"/", :exchange=>"sneakers", :exchange_type=>:direct, :hooks=>{}, :handler=>Sneakers::Handlers::Oneshot, :heartbeat=>2}
+{:runner_config_file=>nil, :metrics=>nil, :daemonize=>true, :start_worker_delay=>0.2, :workers=>4, :log=>"sneakers.log", :pid_path=>"sneakers.pid", :timeout_job_after=>5, :prefetch=>10, :threads=>10, :durable=>false, :ack=>true, :heartbeat=>1, :exchange=>"another_exchange", :exchange_type=>:topic, :hooks=>{}, :amqp=>"amqp://someuser:somepassword@somehost:5672", :vhost=>"/", :handler=>Sneakers::Handlers::Oneshot}

I believe this issue is now fixed.

Thanks @rud ! :)


Repo sync for protected CLA branch

The pull request is created from master637586821532349918 to master to fix git push error for protected CLA branch

@huypub : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Some changes in the copy for the upcoming version

To go live when the new version of the plugin goes live

@metmarkosaric I am merging this PR today so that I can prepare for a release in the next couple of days. Also, I will be excluding some issues from this release to avoid increasing release duration.


Possible issue with 2FA

Hey;
We are seeing an issue with 2FA and I'm not sure if its an Identity change or an issue with this provider.
https://github.com/aspnet/Identity/issues/1383#issuecomment-324434551
Any thoughts?

Hey,
I've not given 2FA too much attention, so it's possible. But because I mostly don't use it, it'd be great if you can provide a small repro.
But the problem itself looks simple, so in any case, I'll check if I can figure something out.

Everything worked before Identity 2.0 yep, and am using 3.0.1
I didn't actually setup the 2FA piece but I will chat with the developer who did to see if we can get a sample repo.
Thanks!

I see. For now, a stacktrace will be most helpful.

So upon first inspection, I guess IUserAuthenticatorKeyStore is a new interface in 2.0. Of course, I don't implement this anywhere so I'm guessing I'll have to implement it on UserStore. There might be other new interfaces too, so I'll take this chance to check up on the EFCore impl and match them up.

Awesome, thank you for looking into this.
If you need me to test I can pull a prerelease package and try it out.
Do you still need a stack trace? Can get you one in a few hours here once the dev is available.

Probably won't need one, as it's obvious I simply don't implement the mentioned interface.
I'll ask you to test when I finish something. Thanks.

It appears that the architectural changes in Identity 2.0 are actually big. I made a hasty decision when I released 3.0. Looks like now there are also base stores that can be used, instead of having them all in the same store project.
For later, I'm thinking about making a new repo with a matching version and better package name: "MR.AspNetCore.Identity.EntityFramework6", that will use the stores provided by Identity Core. And this one kept for aspnetcore Identity 1.0.
For now, I'll release a quick fix.
@dcarl1 can you try these ones out and let me know if it works for you?

Tried your pre-release and now I'm getting a different error:
error: The entity type IdentityUserToken is not part of the model for the current context.

@mrahhal @akonyer is the same project :)

Yes wanted to warn you about it but forgot. You'll need to do an EF migration. Since there's a new entity (IdentityUserToken) used for 2FA and other stuff.

Ah wait. Did I not add it to the context. 🤔 I'll  check.

Sure enough, I forgot to add it to the context (I don't have a handy test host for 2FA so really sorry).
I'll have to ask you to test again. Here is the new release.

Well, we're making progress I think?
{"error":"One or more validation errors were detected during model generation:
EFStorageProvider.IdentityUserToken: : EntityType 'IdentityUserToken' has no key defined. Define the key for this EntityType.
UserTokens: EntityType: EntitySet 'UserTokens' is based on type 'IdentityUserToken' that has no keys defined.
"}

Uh.. It seems an IdentityUserToken has a composite key.

Here you go.

Hahaha. Thank you. This is a bit of a rabbit hole, but another error for you.
{"error":"The number of primary key values passed must match number of primary key values defined on the entity.
Parameter name: keyValues"}

Hmm no, that's not it. Still another config I missed, probably. On it.

And here we go again.

Still getting the same error as before. The number of primary key values passed must match number of primary key values defined on the entity.

I won't be getting around this problem like this. I think I'll setup a 2FA sample and debug this myself. Thanks, will let you know here when I fix a release.

A small repro would be most helpful, since I don't really use 2FA. In my short tests I did while trying to use it no error occurred. So maybe I'm doing things differently.

Sorry for the delay in getting this to you. I got caught up with some other things.
I have created a new bare bones project that is able to reproduce this issue. You can find the project here: https://github.com/akonyer/Ef6CoreTwoFactorAuthenticationTest
To reproduce:

Register a new user
Set [TwoFactorEnabled] flag in database to true
try to login with user
You should get the error: NotSupportedException: Store does not implement IUserAuthenticatorKeyStore.

Let me know if you have any problems. Thank you

Thanks for the repro. I've been very busy lately with work. If anyone wants to try their hand at this then that'd be great. If not, I'm still willing to resolve this issue as soon as I possibly can when I get some free time.

I could reproduce this error before however after upgrading to 3.0.2 things started working correctly (except for https://github.com/mrahhal/MR.AspNet.Identity.EntityFramework6/pull/16).

@kbekkenutte are you saying 2FA completely works in 3.0.2?

@mrahhal I wouldn't want to conclude that with absolute certainty but it seems to be, yes. Switching to 3.0.2 resolves the NotSupportedException: Store does not implement IUserAuthenticatorKeyStore.  exception and https://github.com/mrahhal/MR.AspNet.Identity.EntityFramework6/pull/16 fixes the The number of primary key values passed must match number of primary key values defined on the entity. error


Dtsci 80 layout

Dtsci-80 (Jira Issue)
Description
Added basic layout with a header and a footer.
List of proposed changes:
Added a header and a footer. This is just a start as there needs to be discussion on how it integrates and where it should be placed etc.

What to test for/How to test
Additional Notes

@shewood something up with a test


Peter/loans feat fetch prices on chain

Moving price fetching from UI to lib, replacing CoinGecko and using on-chain oracle as price source for LTV, collateralization and average thresholds computation.
Added getCollateralInfo method takes parameters lendPositions, borrowPositions, and loanAssets. All of these are returned from lib methods getLendPositionsOfAccount, getBorrowPositionsOfAccount and getLoanAssets, respectively. getLoanAssets was extended with call to oracle pallet to get asset's exchange rate against bitcoin which is exposed in the LoanAsset object. Therefore getCollateralInfo method can be run synchronously. This method computes and returns LoanCollateralInfo.
LoanCollateralInfo is interface consisting of following properties and methods that can be later used on UI side:

totalLentBtc - total aggregated amount of all supplied assets in BTC value
totalCollateralBtc - total aggregated amount of all supplied assets used as collateral in BTC value
totalBorrowedBtc - total aggregated amount of all borrowed assets in BTC value
borrowLimitBtc - total amount that can be borrowed until collateral threshold is met, denominated in BTC
ltv - loan to value
collateralThresholdWeightedAverage - Average collateral threshold. Denominated in decimals.
liquidationThresholdWeightedAverage - Average liquidation threshold. Denominated in decimals.
calculateBorrowLimitBtcChange - helper function to compute values based on user's input - to replace similar helper on UI
calculateLtvAndThresholdsChange -helper function that computes new LTV and thresholds based on user's action and input. Replacement for helper on UI.

Note:
All of these properties and methods are equivalent to what is being computed on UI side and should be used to replace UI logic.
Next steps on the UI side:

Replace logic on UI side with call to getCollateralInfo which already pre-computes all the needed values.
Convert BTC values to USD using price from CoinGecko - should be only for preview purposes

@daniel-savu I edited the PR with your comments, please re-review the PR when you are back :pray:


Added some log commands

Retrieve the commit hash of the initial revision. is covered.
git --help is trivial?
Thanks for the PR.

You are welcome, but commits of a certain author and changed files are not covered! That's why I added them.

It's the same command  git rev-list --reverse HEAD | head -1


[CT-3281] [Feature] Add a --perf-info flag to write out perf_info.json for all commands that write a manifest

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Hey Core team 👋🏼
I was wondering if it would be possible to write out the perf_info.json results for more than just parse calls, maybe with a --perf-info flag.
If it wouldn't add meaningful overhead to something like a run or build command this info could be picked up by dbt cloud and logged to Datadog where we could scrape metrics from it.
I think that would be really valuable feedback, and would allow us to better see the impact of the great performance improvements you're working on!
Describe alternatives you've considered
Analysis via post processing in our internal analytics system.
The downside is that some internal parsing metrics are hidden, and the data is time-delayed by the ingestion / transformation cycle.
In addition, it also makes it impossible to prepare actual "metrics" inside datadog.
Who will this benefit?
dbt Cloud Solutions and Engineering teams.
Are you interested in contributing this feature?
no
Anything else?
Internal Slack Thread:
https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1698332747811859

Thanks for opening this @will-sargent-dbtlabs !
Currently
write_perf_info=False is the current default for all commands that include @manifest.
But for dbt parse, we override it to be write_perf_info=True here.
The net effect is that perf_info.json is written to the target-path during dbt parse, but not other commands.
Feature request
One way we could fulfill your feature request is to just switch it to always be write_perf_info=True for all relevant commands.
But assuming we want users to be able to opt-in instead, we could add a new perf_info global config that allows users to choose.
i.e. a new global config like this (from lowest precedence to highest):

perf_info (user config)
DBT_PERF_INFO (environment variable)
--perf-info (CLI flag)

The CLI flag would be relevant to all of the following commands that currently have @requires.manifest:

dbt build
dbt docs generate
dbt compile
dbt show
dbt list
dbt run
dbt retry
dbt clone
dbt run operation
dbt seed
dbt snapshot
dbt source freshness
dbt test

Alternatively, we could choose some other relevant subset.
Refinement
Labeling this as "Refinement" to make the following choices:

Make this always-on, or add a new global config?
If a global config, do we want to stick with the name perf_info? Or do we want to name it something else?
If adding a CLI flag, which commands to apply it to? All? Some subset?


FF8.Encoding doesn't support multichar bytes

A hack around this I added bytetostr dictionary to FF8String. This was in Dirtyencode and that was removed. Probably need a more permanent solution that supports codepages. These bytes are only used in kernel strings I think.

From discord:
multichar bytes are in kernel bin. where 1 byte is 2 or more characters. As far as I know it's the only file that does this. http://forums.qhimm.com/index.php?topic=8461 <- Section III refers to it as DTE

Since these characters are only used in kernel.bin maybe I should move the conversion to kernel_bin.cs or strings.cs and when it loads the strings it can expand those characters to the multiple bytes when they are read from the file.

I ended up moving where I read the strings and added a mulichar flag.  If it is set the string is expanded to one byte per character.


replace soft-serve and gitlab process when git provider is github

related #158;
When the git provider is GitHub we need to remove GitLab and soft-serve of the provisioning process.

Already happening since we migrate templates to support github, around 1 week ago.


How to change "Choose File" on file type input??

Please help me to change text "Choose File "on file type input button???
If possible, how do I change its shape ???

This is way outside the scope of the package and actually sort of a pain in the ass, see here:
https://tympanus.net/codrops/2015/09/15/styling-customizing-file-inputs-smart-way/
If you want to do this sort of customization, you'd have to do it by hand instead of relying on this package to generate it.


Add keys (indexed fields aka topics) to the EventType (abi v2)

Issue: Currently ABI v2 does not preserve the event "kind" information which is necessary for decoding event payloads structured as list of keys + list of data fields.
Introduced changes

This PR adds new key field to the EventType which contains the list of event fields marked with #[key] in Cairo code.

[ ] This PR contains breaking changes

Hi @m-kus, thanks for providing the PR :) left one small comment.


IOS Problem

Package is not running on IOS, its displayed on screen but not playing audio.

I got the same error in ios but it works fine in android

@YoussefAbdelmonem  I've sent you message on LinkedIn. contact me to give you a solution.

@YoussefAbdelmonem I've sent you a connection request on LinkedIn. contact me to give you a solution.

Can you please give me the solution too?


Version mismatch

The package.json states that this lib is v1.1.8, but the latest tag is v1.1.1. Please fix.

fixed, and also published 1.1.9 from https://github.com/dominictarr/config-chain/pull/20

fixed, and also published 1.1.9 from https://github.com/dominictarr/config-chain/pull/20


error: failed retrieving file 'mingw32.db' from downloads.sourceforge.net : Failed to connect to ufpr.dl.sourceforge.net port 80

I've newly installed MSYS2 on Windows 7, and I edited the mirrorlists on
/etc/pacman.d removing:
## Primary
Server = ftp://<IP_ADDRESS>/MINGW/x86_64
Then, after doing 'pacman -Sy' I get:
$ pacman -Sy
:: Synchronizing package databases...
error: failed retrieving file 'mingw32.db' from downloads.sourceforge.net : Failed to connect to ufpr.dl.sourceforge.net port 80: Network is unreachable
error: failed to update mingw32 (download library error)
error: failed retrieving file 'mingw64.db' from downloads.sourceforge.net : Failed to connect to ufpr.dl.sourceforge.net port 80: Network is unreachable
error: failed to update mingw64 (download library error)
error: failed retrieving file 'msys.db' from downloads.sourceforge.net : Failed to connect to ufpr.dl.sourceforge.net port 80: Network is unreachable
error: failed to update msys (download library error)
error: failed to synchronize any databases
error: failed to init transaction (download library error)

The sourceforge mirror must be down then. You'll probably have to wait until it is up again.

How long would it take until it is up again?
It's already been two days and I keep getting the same messages!

Maybe something wrong with your internet connection? It works ok.

Actually I don't have any problem with my internet connection.
Isn't there any other mirror to run this command from?
Or perhaps is it the timeout? Can I enlarge the timeout for this command?

Ufpr mirror must be down. Try contacting sourceforge, or put a different
one in the /etc/pacman.d mirror files.
On 8 Jan 2015 00:19, "andalou"<EMAIL_ADDRESS>wrote:

Actually I don't have any problem with my internet connection.
Isn't there any other mirror to run this command from?
Or perhaps is it the timeout? Can I enlarge the timeout for this command?
—
Reply to this email directly or view it on GitHub
https://github.com/Alexpux/MSYS2-packages/issues/154#issuecomment-69116815
.


Add a banner/wrapper/iframe to proxied content

How feasible is it to add a header/banner/iframe around the proxied content?
The use case would be to have a little bit of screen space above a shiny app or RStudio that is deployed via mybinder.org in which we can show the mybinder.org logo or some such.

After pondering this for a bit over lunch maybe the place to discuss this is in the binderhub repo in a more general context of "wrapping" the content of binder instances. So I think I will open an issue there and link back to this one.


Refactor rest action with tests

except for my nit, this is good to go.

Good catch. I've updated it.  Feel free to merge after tests pass


demo broken

empty example. In logs tile request crushes with
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>403 Forbidden</title>

Forbidden

origin is not allowed by this api key

https://www.mapzen.com/products/tangram/

Fixed the API key, thanks!


Custom id generation and comb guid

Added support for CombGuid. From first tests with bulk insert has CombGuid the same perf as Int32 id's now. The difference this is not spectacular and only a couple % faster as the default Guid.
I also implemented a IdentityKeyGenerator based on the current HiLo.
I will do more perf tests and post a report of the read/write perf differences when using the different ID types later this week.

In with a rebase this morning.


Add licenses for 3rd party libraries

Added references to licenses for third party libraries referenced in plugin.

I would prefer not distribute the actual licenses in the distribution. Instead, I would prefer just link to the licenses in the NOTICES file.

Changed the structure of the distribution package and moved references to third-party licenses to NOTICES file.

👍

@raducoravu if there's something I can still do to make it easier to use this in Oxygen, please let me know. Though, I assume you're already listing all libraries in Help>About>Libraries or Frameworks.

In our "About" dialog from what I remember I only mention your plugin and if people double click the plugin they are taken to the "LICENSE" file from it. But as long as you have the "NOTICES" there in the same folder it's probably OK.


getting mavsdk version

Is it the correct way to retrieve it?
print("System server version : ", mavsdk.major, " ", mavsdk.minor)
output
System server version :  3   10
https://github.com/mavlink/MAVSDK/releases
https://github.com/mavlink/MAVSDK-Python/releases

No, The Latest Mavsdk Version available is - 2.1
This might be your python version, Really Not sure about it.
You can check the mavsdk version in your MAVSdk-Python Repo, Through
cat MAVSDK_SERVER_VERSION, this will be your downloaded github repo. It sometimes differs to your installed mavsdk server version.
Check through
sudo apt search libmavsdk-dev

This might be your python version, Really Not sure about it.

Yes, that is my Python 3 version as well. maybe. Yes, I am very sure my Mavsdk-python is 2.1.0.

Ok.
Then You can close the issue if you're able to find the version.

Ok. Then You can close the issue if you're able to find the version.

No, I cannot through Python 3 code.

Ok, so we should expose this function via Python:
https://github.com/mavlink/MAVSDK/blob/10876a89b5d4097b68009fa98b30b1ff08c29488/src/mavsdk/core/include/mavsdk/mavsdk.h#L54-L61
I think we need to add it to proto here:
https://github.com/mavlink/MAVSDK-Proto/blob/main/protos/core/core.proto#L9
And then implement it here:
https://github.com/mavlink/MAVSDK/blob/10876a89b5d4097b68009fa98b30b1ff08c29488/src/mavsdk_server/src/core/core_service_impl.h
Pull requests welcome :smile:


[Ziro] Stuck on settings

spicetify 2.14.1
stuck on settings and cannot click close
very weird i change ziro theme but this Dribbblish settings

Could you paste the output of spicetify config here?

The dribblish-dynamic JS is still loaded. Try removing it by spicetify config extensions dribbblish-dynamic.js-


Router-view plus key attribute causes keepAlive to fail

Version
4.0.0-rc.1
Reproduction link
https://codesandbox.io/s/vue-router-next-beforerouteupdate-forked-od2y4?file=/index.html
Steps to reproduce
Delete :key="$route.path" and it works
I saw the (#444) problem, and added: key="$route.path". But it will cause keepAlive to fail. This is very important to me, is there any way to deal with it
What is expected?
When router-view is keyed, keepalive is used normally
What is actually happening?
When router-view is keyed, keepalive you can use it normally

What does rt mean?

Sorry I wrote it habitually。It has been modified

You need to put the key on the component if you are using v slot

@posva I modified the example because I forgot to add the transition tag. It can work before transition without adding mode="out-in". It won't work after adding

When I switch routes, the page does not render. I mentioned this question in vue-next before, but I am not sure why this problem occurred

can you help me?

There is no includes prop in keep alive, but I don't understand why it breaks with it


Support proxy per-connection rather than just environment variables

Problem
I opened this issue: https://github.com/databricks/databricks-sql-python/issues/318. My use case involves using the Databricks SQL connector in a multi-threaded web application where we may not want to set the proxy for all traffic. The current method of using environment variables would not allow that.
Solution
Proxy specification works same way as the Python requests module - it will default to whatever is set in the environment variable, but it can manually be overridden for a single request / connection if desired.

I would like to add a test for this in client tests - but seems they don't actually run in CI. Any guidance would be much appreciated! https://github.com/databricks/databricks-sql-python/issues/317

Thanks for this contribution. We have rather poor testing facilities for proxies at present (we need proper CI for this repository -- that's coming soon). Will review and perform some manual testing in the next couple weeks.

Thanks for this contribution. We have rather poor testing facilities for proxies at present (we need proper CI for this repository -- that's coming soon). Will review and perform some manual testing in the next couple weeks.

sounds good, appreciate the review!


Load scriptFile from filesystem first

If scriptFile is available on the filesystem load from there. If not, fall back to loading from the jar. This restores the original, and intended behavior of the plugin. Fixes #12

Merged, releasing.

Released 1.4.1 to oss.s.o


Build macOS app and extend the README.md regarding macOS release

The macOS app is now properly packaged as a .app file
The readme has been extended

One thing to mention here is that unsigned apps can have trouble being executed if downloaded. I described this in the README. Ultimately, if you are interested in having a distribution without these signing issues, an Apple developer account is necessary.
This one contains a couple of more changes, please let me know if you want things changed.

Using .zip instead of .tar.gz is certainly good for accessibility by people not using Linux.
However, I am not really happy with the MacOS instructions being like the longest section of the README 😆.
Maybe we can instead link to some external docs that provide this information?
Also took a brief look at how to sign the app. Look like it requires XCode, which requires MacOS (or another Apple OS). Great...

Yeah, regarding .zip, I think we can also do the same thing for the Windows build.
I can fully understand that this is a bit out of place maybe. Maybe we have a separate macOS file for that?
As for the signing the app, we could do that during the GitHub action build process. The macOS variant is already using macOS instances instead of the Ubuntu instances.
It would be up to you if you want to embark on the journey of getting a developer account. IMO, it is not required right now. It might be just awkward if the user does not know about how to open it without signature.

I can fully understand that this is a bit out of place maybe. Maybe we have a separate macOS file for that?

Or maybe even move all information on using and building locally to a separate page? It could then also be linked from the itch.io download section.

I would prefer to move the MacOS / general local usage/"installation" stuff to INSTALL.md or so. Also, it would be great if you could change to .zip for windows builds.
Besides that, this can be merged.


Train and deploy rcnn and cnn model

#115
I've updated the MTCNN face detection module to better integrate with your SPROCTOR project.
Added proper class structure:-
1- FaceDetector class for MTCNN operations
2- MTCNNDetectionProcess class that inherits from your project's Process class
Improved error handling and logging:
Configured proper logging
Added try-except blocks for robust error handling
Can you Gssoc ext level 3 to this PR...

@devxMani Not assigned created 6 hours back, so no points

@MastanSayyad please check

@tanishaness i gave him PRs details for merging but now you can merge these

@tanishaness I have messaged you on Discord and LinkedIn but aap active hi nhi the, abb to waise bhi in PRs ke points nhi milege but aap merge karlo..


Open a file using system default application

This PR fixes #92689
I added a context menu entry to open up a file using the system default application and bind a short cut Shift+Alt+O.
This functionality is implemented using Electron's openItem API.
I have tested this functionality on Windows opening PDF files, mp3 files and docx files.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: yujunqin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for this PR. However we would not like this Feature in VS Code main yet.
Idealy extensions should be able to do this. Not sure if there are node module that can help here and that extensions simply contribute commands to VS Code.
So far now will not merge this PR. In the future we might change this decision.
This PR also needs testing on Mac and Linux in case we decide to merge it later.
Thanks

As per my previous comment I am closing this PR as out of scope and outdated


Fuding fee logic completion

This is on top of #1170, i.e. to be tackled once that PR is adapted and merged.
At the moment this draft PR just outlines in TODOs where we have to touch code to get a better overview of what is missing.

Closing, will just work off #1185 to plug it in.


⚠ Bofrost.be has degraded performance

In fa970d3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 953 ms

Resolved: Bofrost.be performance has improved in fbc09a0.


Update Content.jsx

SSR Compatibility: Direct access to window in useState can break server-side rendering (SSR). Moved the window logic inside useEffect to avoid issues during SSR.

Resize Event Handling: The current window.addEventListener implementation can cause excessive re-renders during rapid resizing. A debounced handler is used to improve performance.

External Link Security: The rel="noreferrer noopener" attribute is added for external links to prevent security issues like reverse tabnabbing.

List Key Usage: Using index as a key in map is discouraged. A unique identifier (link) is now used to prevent rendering issues when items are reordered.

Image Fallback Handling: Added error handling for the image in case it fails to load, improving user experience.

Conditional Class Rendering: The conditional class names for isWide are made more consistent, ensuring proper responsive design.

Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

Fixes #(issue number)

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Tests update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] New and existing unit tests pass locally with my changes
[ ] I have maintained a clean commit history by using the necessary Git commands
[ ] I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)
Add screenshots to help explain the changes (if necessary).

Mention issue number @akshitbansal2005

Mention issue number @akshitbansal2005

@akshitbansal2005 any updates?


handling field should be used to detect if a tape is mounted (when performing an inventory)

Currently the following is done when doing an inventory of tapes and drives:
if the slot numbers of a tape and a drive are equal
and if the mount_node field of the information provided with the tape is empty
=> perform a mount of that tape on the corresponding drive

With LE version <IP_ADDRESS> the handling field should be used instead of the mount_node field according to the LTFS development team.

This issue was moved to ibm-research/LTFS-Data-Management#10


how can we be notified of a change of value (ie : after a click on the save button) ?

Hello,
I need to be notified of a value change after the user clicks on the save button in order to send the new value to the server.
How can this be done ?
I've already tried the following :

observer on the bound tableData property (changes are not notified to the parent)
listener on the documented px-data-grid events (not fired in that case)
listener on the "item-save" event (event fired but the modified row is not attached to the event detail and this event is anyway not documented in the public API)

Any other idea ?

I guess the item-save would make the most sense, maybe issue a quick PR to add the saved item to this event? The item should be available in e.model.item in here

Bonjour Benoit,
Thanks. I've just created the PR.

Fixed in v1.0.8


Various fixes for the Backblaze B2 driver

This pull request fixes an issue in the Backblaze B2 driver as reported in #1338.
While working on this, I noticed download_object_as_stream is also broken, so I fixed that as well.
It looks like both of those regressions were inadvertently introduced when we moved to the requests library.
It's likely that there are more issues similar to this one hiding in other drivers. Sadly our functional tests didn't catch those issues.
Resolves #1338.

@tonybaloney I noticed more storage drivers use response.response in download_object_as_stream method.
This attribute is an instance of HttpLibResponseProxy which is not compatible with the pre-requests migration response format so those methods will fail / throw an exception:
Traceback (most recent call last):
  File "example_storage.py", line 42, in <module>
    for chunk in iterator:
  File "/home/kami/w/lc/libcloud/libcloud/utils/files.py", line 74, in read_in_chunks
    chunk = b(get_data(*args))
  File "/home/kami/w/lc/libcloud/libcloud/utils/py3.py", line 203, in next
    return iterator.next()
AttributeError: 'HttpLibResponseProxy' object has no attribute 'next'

Or am I missing something?
If that's is indeed the issue and it's broken, one option to make it work out of the box (and also be backward compatible) is to add next() method to HttpLibResponseProxy class.
Something along the lines of:

    def next(self):
        for chunk in self._response.iter_content():
            return chunk

I confirmed that works, at least with the Backblaze driver.
It's not the most ideal thing though. Alternative would be to update all those places to use response.iter_content().

Just a heads up - I will merge those Backblaze driver fixes and work on the requests upload_object_via_stream regression (?) in a separate PR.


Rerun failed jobs

As title

For me this is fixed by changing Settings -> Actions -> General -> Workflow Permissions to allow read and write:
https://github.com/actions/first-interaction/issues/10


NetworkGraph: Add plus symbol to the connector

This changes the connector symbol slightly to indicate the function a bit clearer, as shown below. What do you think about it?
Before:

After:

Further suggestions which came up in the review process can be fount at .


move runtime-helpers into runtime-lib as utils

Description
Move runtime helpers, which is primarily a utils file within the runtime plugin, into the runtime lib, and use it as a dependency.

Related Issue
https://github.com/adobe/aio-lib-runtime/pull/1
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

take into account https://github.com/adobe/aio-cli-plugin-runtime/pull/179 (cherry pick if needed)

Closing this in favor of #182 which side-steps merge conflicts


TextBlock[1|2|3]

The C# code shows, e.g., TextBlock1 or TextBlock2 but the corresponding XAML doesn't. Might be a bit clearer to add it?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca5b65ce-7ab7-5cdc-99b1-b70ede120ee8
Version Independent ID: 91674c1b-71dd-eab4-702f-f060382591ce
Content: How to: Create a Text Decoration
Content Source: docs/framework/wpf/advanced/how-to-create-a-text-decoration.md
Product: dotnet-framework
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Hi! Thanks for filing an issue. These are actually two different ways of doing the same thing. I don't think the docs website presents the code samples in that way.
The C# example is showing how to add a decoration via code and the XAML is also showing how to do it without any code. The C# code is not talking to the XAML element that is described in the next code block.

I'm going to close this issue. If you have any other comments or thoughts, or feel I was incorrect in my assumption, feel free to reopen or comment. Thanks again!

I figured that out, that the XAML and C# are alternatives, but the 1,2,3 threw me off at first. Perhaps if they all used TextBox1? Probably not worth changing after all.

It makes more sense when you see that the examples are from an app, which demonstrates 3 different boxes: https://github.com/dotnet/samples/tree/master/snippets/csharp/VS_Snippets_Wpf/TextDecorationSnippets/CSharp


Enabling the parser plugin 'classProperties'

Bug Report
docz dev builds and works fine but docz build throws SyntaxError: This experimental syntax requires enabling the parser plugin: 'classProperties'.
I am using babel-plugin-transform-class-properties when i bundle my libraries and my doczrc.js has added the @babel/plugins-syntax-transform-properties
SyntaxError: This experimental syntax requires enabling the parser plugin: 'classProperties' (7:12)
    at _class.raise (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:3938:15)
    at _class.expectPlugin (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:5252:18)
    at _class.parseClassProperty (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:8102:12)
    at _class.pushClassProperty (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:8066:30)
    at _class.parseClassMemberWithIsStatic (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7999:14)
    at _class.parseClassMember (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7936:10)
    at _class.parseClassBody (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7891:12)
    at _class.parseClass (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7841:10)
    at _class.parseStatementContent (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7172:21)
    at _class.parseStatement (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7144:17)
    at _class.parseBlockOrModuleBlockBody (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7695:23)
    at _class.parseBlockBody (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7682:10)
    at _class.parseBlock (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:7671:10)
    at _class.parseFunctionBody (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:6924:24)
    at _class.parseArrowExpression (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:6876:10)
    at _class.parseParenAndDistinguishExpression (/Users/jcarrick/Sites/react-common-components/packages/docs/node_modules/@babel/parser/lib/index.js:6492:12)

using<EMAIL_ADDRESS>doczrc.js
const getRepoInfo = require('git-repo-info')
const tag = getRepoInfo().lastTag

export default {
  title: 'React Component Library',
  description: tag,
  dest: `public`,
  port: 9000,
  theme: 'theme/Theme',
  propsParser: false,
  modifyBabelRc: babelrc => ({
    ...babelrc,
    plugins: [
      '@babel/plugin-syntax-class-properties',
      '@babel/plugin-syntax-object-rest-spread',
      'emotion',
      ...babelrc.plugins
    ]
  })
}

This was an issue in our own code base.  Someone was defining a class in the children function of the Playground.  It might be a good idea to look for this and throw a more helpful error message because it was a tough one to track down.

This is still a valid bug, because using a class as a child of Playground is a valid option

Met this issue when using arrow functions for event binding in a class as a child of Playground

This is something related to react-live that doesn't make parsing using babel 😕

Met this issue when using arrow functions for event binding in a class as a child of Playground
I am using typescript with Docz

Have you solved the problem？ The same problem i have met when i use arrow functions in mdx files.

Any updates on how to solve this?
I do need to define a class in  children, so my users can edit them rather than some blackbox  tag.


See the schema it generates

Hi, thanks for the project!  Is it possible to see the schema it generates other than in the GraphiQL docs?

Yep, we've extracted that logic into https://github.com/marmelab/graphql-schema-from-json. We still need to make it a dependency of json-graphql-server, though.


Add SBom generation

@JasonGore Woudl you mind merging for me? I don't have permissoins to do so...


The supported languages and locals in README seems to be incorrect

There is an es-BR in there, which is a non existing thing, in Brazil it's spoken Portuguese. And on the PT list is missing pt-BR. Also I couldn't find what pt-CH is, was it supposed to be Spanish from Chile instead?

Thank you for reporting this, @lianemeth.
Language/locale codes are directly ported from CLDR repository (http://cldr.unicode.org), which is maintained by Unicode Consortium.
Used format is IETF language tag: two letter language code (as defined by ISO 639-1) followed by additional identifier (territory or script code, as defined by ISO 3166-1) where necessary.
I don't know, I myself wouldn't dare to tell the people of Spanish ancestry in Brazil (ca. 20M people) that their language doesn't exist. Of course with regards to dates the forms tend to be very close to those of the main language or the main territorial forms.
I fully agree - we should add language name field to the language data to avoid misunderstanding and a (nicely formatted) list of language/locale names to documentation.

They seem to be incorrectly ported then, because pt-BR is the standard, since it's very different from Portuguese from Portugal.
I am a Brazilian with Spanish ancestry myself, we don't speak Spanish from Brazil, we speak Portuguese and if we wish to talk in Spanish, we learn Spanish from other countries.
Also, Spanish is 6th spoken language in Brazil http://www.unicode.org/cldr/charts/latest/supplemental/territory_language_information.html
So if you put es-BR, you should just as well include English from Brazil, Japanese from Brazil, German from Brazil...

Good! Well, there is no date handling data for pt-BR in CLDR. I cannot say if the reason behind this is that all the forms and formats used in dates are exactly the same as in pt (perhaps you could advise here?). Or are there any differences?
If they are equivalent, we could list pt-BR as supported (but language detection wouldn't be able to distinguish between them). If they're not, we should add the differences before listing it.
When it comes to less used locales, I can see the issue with capitalisation which confirms your claims. Currently if there's an entry that separates the locale from the main language variant, locale is spawned (for es-BR that's the abbreviation for September: "sep", which is different from main es: "Sep"). Ignoring capitalisation (which is ignored anyway when parsing) would result in shrinking the list.
What is your suggestion then? Where would be the line between listing the language as supported and ignoring it?

The only difference between PT-BR and PT that I can remember of is capitalization. Setembro is the common form in Portugal and African Portuguese speaking countries while it is setembro in Brazil.
I would say that shrinking the list would be the best idea. It would be best to drop the regional locales in all cases where the difference is only capitalization, and ideally if technically possible, also drop them in the cases where there are only small differences in spelling. Most of the cases, you will want to be able to parse the small variations of spelling that occur between regions, even if you are parsing say a website in Brazil or Portugal. In English, you would want to "color" be considered the same as "colour" even if you are parsing a British website.


test run a plugin

https://github.com/hchiam/verse-retriever

a button shows up when certain text is recognized?

leaving plugin-demo branch for reference, but closing this issue for now


Fix test sqlite db helper

With the latest changes when we use two separate DB connections for the service and for migrations a bug was introduced. SQLite helper (CreateTestSqliteDB) didn't use proper path of SQLite DB file for migrations. This PR fixes this bug.

Codecov Report

Merging #111 into master will increase coverage by 0.18%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   85.00%   85.19%   +0.18%
==========================================
  Files          21       21
  Lines         607      608       +1
==========================================
+ Hits          516      518       +2
  Misses         56       56
+ Partials       35       34       -1

Impacted Files
Coverage Δ

database/sqlite.go
69.38% <75.00%> (+2.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7f24e...080c4c1. Read the comment docs.


Left and right switched?

Just a very minor issue, I noticed that when I select "Navigate left" for a hood button the Karoo acts as if I had pressed the right side button and vice versa.
Same for the "zoom in" and "zoom out" functions. If I set the left button long press to "zoom out" and "zoom in" to the right button long press (as it was on the original Karoo implementation) it would actually zoom in on left and zoom out on right 😆
These issues were quickly fixed during my first ride, just opened the ki2 app and changed the button actions on the fly 😉

I was unable to reproduce this issue. I suspect the issue might be caused by your di2 configuration.
The way the hood buttons work is they emit "Channel" events, the Ki2 app expects Channel 1 for Left and Channel 2 for Right. These channels are configurable in E-Tube:

If your configuration is different than Channel 1 for Left and Channel 2 for Right (like that screenshot in E-Tube) then it won't translate well in Ki2 because that's what it expects.
It could be some other problem but I wasn't able to find anything else.
Just to confirm:

Are you using Karoo 1 or Karoo 2?
What do you see in the Ki2 app, tap on the di2 device, wait for it to connect and then see what is displayed in the Left / Right Switch when you press the hood buttons - is it also flipped there?

Thanks.

 I had my hood buttons set to shift up and down after the original shifter support from the Karoo was removed. After installing ki2 I found that the hood buttons weren't working as expected and played a bit with the settings in the eTube app, and that resulted in Channel 1 being assigned to the right button and Channel 2 for the left one 🙄
You should write something about the expected channels in the README.md 😉

Thanks for checking. To be honest I didn't even consider this before, I will add it to the Readme 🙂


[FLINK-12235][hive] Support partition related operations in HiveCatalog

What is the purpose of the change
To implement partition related operations in HiveCatalogBase.
Brief change log

Introduced HiveCatalogPartition to represent a partition that can be handled by HiveCatalog.
Implemented partition-related operations in HiveCatalogBase. Although we intend to let HiveCatalog and GenericHiveMetastoreCatalog share the implementations, this PR only enables/tests these operations for HiveCatalog.
Moved partition related tests from GenericInMemoryCatalogTest to CatalogTestBase, so that GenericInMemoryCatalogTest and HiveCatalogTest can share these test cases.

Verifying this change
This PR is tested using partition related test cases in CatalogTestBase.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? JavaDocs

@xuefuz @bowenli86 please take a look. Thanks.

@bowenli86 @xuefuz thanks for your comments. Please take a look at the updated PR. Thanks.

@xuefuz  I'd rather get https://github.com/apache/flink/pull/8480 in first and rebase this PR since 8480 is a much larger change set and not easy to rebase. Same as https://github.com/apache/flink/pull/8477

Rebased.
@xuefuz @bowenli86 please take another look. Thanks.

Rebased and addressed comments.
@bowenli86 @xuefuz please take another look. Thanks.

@lirui-apache Thank you very much for the update!
I just spotted that, currently how several APIs impl work like this: 1) get a raw hive table 2) parse part of the raw table. The latter step actually duplicate with logic in instantiateHiveCatalogTable(). E.g. ensureTableAndPartitionMatch() parses FLINK_PROPERTY_IS_GENERIC, instantiateHivePartition() parses partition keys, ensurePartitionedTable() parses the raw table's partition key size, all of which we can get by just parsing the raw table to a CatalogTable thru instantiateHiveCatalogTable() in advance. The current duplication also means if we change some general logic in parsing a hive table, we need to change two places. Thus I wonder if it makes sense to just parse the raw table as whole at the beginning rather than having scattered places each parsing only part of it themselves. And we can remove util methods such as getFieldNames() which is only used to get the partition keys which is already available in CatalogTable.
For example, change
public void createPartition(...) {
  Table hiveTable = getHiveTable(tablePath);
  ensureTableAndPartitionMatch(hiveTable, partition);
  ensurePartitionedTable(tablePath, hiveTable);
  try {
    client.add_partition(instantiateHivePartition(hiveTable, partitionSpec, partition));
  } ...
}

to something like:
public void createPartition(...) {
  Table hiveTable = getHiveTable(tablePath);
  CatalogBaseTable catalogTable = instantiateHiveCatalogTable(hiveTable);
  ... check whether catalogTabe and catalogPartition type matches would be much easier here ...
  ... check whether catalogTable is partitioned would be easier here ...
  try {
    client.add_partition(
      instantiateHivePartition(catalogTable, partitionSpec, partition, hiveTable.getSd()));
  } ...
}

I'm not sure how much benefit this can bring us. It might make ensureTableAndPartitionMatch a little easier -- we can check the type of CatalogBaseTable instead of parsing a property. But I don't think we should take the same approach for ensurePartitionedTable. ensurePartitionedTable is already simple enough. And for APIs like listPartitions, creating a CatalogBaseTable just to get num of partition cols seems an overkill to me. And the same applies to getFieldNames. E.g. I think it'll be an overkill to create a CatalogBaseTable to get partition col names in dropPartition.
Maybe an alternative approach to the problem you mentioned is to have more util methods, in order to avoid duplication. For example, we should have a util method to decide whether a Hive table is generic. And all the APIs needing this logic can call the util method. What do you think?

ok, let's leave that part as it for now

Rebase and address comments.
@bowenli86 @xuefuz let me know if I missed anything. Thanks.

Made ensureTableAndPartitionMatch static. Several other methods can't be static, unless we pass the needed non-static field as parameter. @xuefuz shall we do that?

Made ensureTableAndPartitionMatch static. Several other methods can't be static, unless we pass the needed non-static field as parameter. @xuefuz shall we do that?

No. I think we only need to make what is static in nature  static in their current forms.

Thanks @lirui-apache very much for the PR. LGTM, merging


document the differences in config and requirements for running with proxy in local state vs remote state

document the differences in config and requirements for running with proxy in local state vs remote state
such as removing "remoteStateS3": from the config

@ashvds - should we write cookbook style tutorials for setting up hx-deploy-tool (this would cover this use case, and provide a bit of a flavour for #52

@jsuresh happy to start a wiki 😁

SGTM - or should we leverage github pages? I think we need a doc that steps one through getting up and running with hx-deploy-tool from scratch? I'll make an issue for this.


Integrated Live Reload

Solves the issue #1. This pull request integrates Live Reload into the server, so the changes will be shown on the page itself when any of the files are changed. It works by pinging the /version route of the server (new), which shows the current version of the boilerplate. If the version differs from the "current" one, the page will be reloaded and the new version will become current. The version number is increased after each file update.
Possible improvements
To make the code the user wrote work out-of-the-box without unnecessary changes, we can make the server "secretly" add Live Reload to the current page in a <script> tag when rendered, instead of placing it in the boilerplate for the project.

Thanks for PR I'll take a look at it on Sunday morning.

Hey @LyubomirT,
Great work on your PR! I've reviewed it and your solutions definitely hold water.
One minor adjustment, though: the current approach adds a reload script that, while functional, triggers an additional reload during project build (including the script itself).
Ideally, we'd want the live server to handle reloading itself. For reference, here's my previous implementation:
server.close();
server.listen(3000);

Let me know your thoughts on this! We can definitely brainstorm better solutions together.

Hey @LyubomirT,
Great work on your PR! I've reviewed it and your solutions definitely hold water.
One minor adjustment, though: the current approach adds a reload script that, while functional, triggers an additional reload during project build (including the script itself).
Ideally, we'd want the live server to handle reloading itself. For reference, here's my previous implementation:
server.close();
server.listen(3000);

Let me know your thoughts on this! We can definitely brainstorm better solutions together.

Hello! Thanks for reviewing the PR. Unfortunately, it's not possible to integrate Live Review without anyhow dealing with the frontend. We can, however, make the process more user-friendly by hiding / simplifying some things. Would you like me to do that?

Hello! Thanks for reviewing the PR. Unfortunately, it's not possible to integrate Live Review without anyhow dealing with the frontend. We can, however, make the process more user-friendly by hiding / simplifying some things. Would you like me to do that?

Sure, but can you also make sure this is the only way we can do this? When you have time (after your exams!) please see (MEVN-CLI)[https://github.com/madlabsinc/mevn-cli] and how they achieved the same.
I'm using chokidar to watch file changes, here is an example btw:
npm install chokidar

const chokidar = require('chokidar');

const filePath = 'my-file.txt';

const watcher = chokidar.watch(filePath, {
  // Optional: configure options like ignored files
});

watcher.on('add', (path) => {
  console.log(`File added: ${path}`);
});

watcher.on('change', (path) => {
  console.log(`File changed: ${path}`);
});

watcher.on('unlink', (path) => {
  console.log(`File deleted: ${path}`);
});

// You can define event listeners for other events like 'addDir', 'rename', etc.

(I'll be little busy until this Wednesday, university lab exams)
Thank you !

Wish you all the best with your exams. I'll take a look at MEVN and will try to figure things out, thanks for pointing me in this direction.