Adding building unit attributes to us/co/denver

Adding building unit attributes to us/co/denver.
Someone with more experience here should probably verify this worked correctly.
Closes #5838

It looks like this failed. As you can see, the unit field is Bldg 1 Bldg 1. I don't think it should have duplicates like that.
{"type":"Feature","properties":{"hash":"f36fca2341981d4d","number":"4303","street":"N Brighton Blvd","unit":"Bldg 1 Bldg 1","city":"","district":"","region":"","postcode":"","id":""},"geometry":{"type":"Point","coordinates":[-104.9715914,39.7779286]}}

It looks like what we had before was right:

But you found a case where their composite field wasn't populated properly:

So I'm going to change the fields it uses for unit to include the two building fields and the two unit fields.

Thanks for spotting this. I'm going to merge in this change and we can make further changes with other PRs if needed.

@iandees Sounds good. In order to test this on my end, I'm relying on the https://batch.openaddresses.io/api/data API endpoint to get the S3 path.
How often does that get updated?
Is there a better method to get this data earlier? It looks like the https://batch.openaddresses.io/api/job API endpoint has the job listed from this PR, but that isn't guaranteed to be stable or reviewed.

@ingalls can you give some more info on @fishcharlie's questions here?


⚠ ClamAV has degraded performance

In 54695a4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 53 ms

Resolved: ClamAV performance has improved in 09b80d9.


Navigating to last page even when row is added in the beginning

This method navigates to the last page when pagination is enabled.
var result = this.refs.table.handleAddRowAtBegin(fakeRow)

Expected behavior
Navigate to the first page

@harshjv, got it. I'll improve this in next version. Thanks

@AllenFang I've already created a fix for this. Will send a PR soon.

@harshjv, ok, PR is welcome :)

@AllenFang Done :) PR #809

@harshjv, released on v2.5.7. Thanks your PR.


geoviews can't currently be imported on travis?

Was making some website edits...

I ran the following on macos 10.12.6 and didn't get that problem. Of course, I got a different problem:
$ conda create -n geov2 python=3.6* nose numpy matplotlib bokeh pandas scipy jupyter ipython param flake8 mock filelock
$ source activate geov2
$ conda install -c conda-forge holoviews iris cartopy xarray geopandas numpy=1.13.3
$ pip install -e .
$ python -c "import geoviews"
$ nosetests --with-doctest --with-coverage --cover-package=geoviews
nose.plugins.cover: ERROR: Coverage not available: unable to import coverage module
E/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/iris/tests/__init__.py:79: UserWarning:
This call to matplotlib.use() has no effect because the backend has already
been chosen; matplotlib.use() must be called *before* pylab, matplotlib.pyplot,
or matplotlib.backends is imported for the first time.

The backend was *originally* set to 'MacOSX' by the following code:
  File "/Users/cball/Eunectes/mc3/envs/geov2/bin/nosetests", line 11, in <module>
    sys.exit(run_exit())
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/core.py", line 121, in __init__
    **extra_args)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/unittest/main.py", line 95, in __init__
    self.runTests()
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/core.py", line 207, in runTests
    result = self.testRunner.run(self.test)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/core.py", line 62, in run
    test(result)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/suite.py", line 177, in __call__
    return self.run(*arg, **kw)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/suite.py", line 224, in run
    test(orig)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/unittest/suite.py", line 84, in __call__
    return self.run(*args, **kwds)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/suite.py", line 72, in run
    for test in self._tests:
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/suite.py", line 99, in _get_tests
    for test in self.test_generator:
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/loader.py", line 191, in loadTestsFromDir
    entry_path, discovered=True)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/loader.py", line 417, in loadTestsFromName
    addr.filename, addr.module)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/imp.py", line 245, in load_module
    return load_package(name, filename)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/imp.py", line 217, in load_package
    return _load(spec)
  File "/Users/cball/code/ioam/geoviews/geoviews/__init__.py", line 15, in <module>
    from . import plotting                              # noqa (API import)
  File "/Users/cball/code/ioam/geoviews/geoviews/plotting/__init__.py", line 1, in <module>
    from . import mpl # noqa
  File "/Users/cball/code/ioam/geoviews/geoviews/plotting/mpl/__init__.py", line 17, in <module>
    from holoviews.plotting.mpl import (ElementPlot, ColorbarPlot, PointPlot,
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/holoviews/plotting/mpl/__init__.py", line 12, in <module>
    from .annotation import * # noqa (API import)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/holoviews/plotting/mpl/annotation.py", line 6, in <module>
    from .element import ElementPlot
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/holoviews/plotting/mpl/element.py", line 6, in <module>
    import matplotlib.pyplot as plt
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/matplotlib/pyplot.py", line 69, in <module>
    from matplotlib.backends import pylab_setup
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/matplotlib/backends/__init__.py", line 14, in <module>
    line for line in traceback.format_stack()

  matplotlib.use('agg')
...
======================================================================
ERROR: Failure: ImportError (dlopen(/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/fiona/ogrext.cpython-36m-darwin.so, 2): Library not loaded: @rpath/libuuid.1.dylib
  Referenced from: /Users/cball/Eunectes/mc3/envs/geov2/lib/libgdal.20.dylib
  Reason: image not found)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/failure.py", line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/loader.py", line 417, in loadTestsFromName
    addr.filename, addr.module)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 684, in _load
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/Users/cball/code/ioam/geoviews/geoviews/data/geopandas.py", line 4, in <module>
    from geopandas import GeoDataFrame
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/geopandas/__init__.py", line 4, in <module>
    from geopandas.io.file import read_file
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/geopandas/io/file.py", line 3, in <module>
    import fiona
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/fiona/__init__.py", line 69, in <module>
    from fiona.collection import Collection, BytesCollection, vsi_path
  File "/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/fiona/collection.py", line 9, in <module>
    from fiona.ogrext import Iterator, ItemsIterator, KeysIterator
ImportError: dlopen(/Users/cball/Eunectes/mc3/envs/geov2/lib/python3.6/site-packages/fiona/ogrext.cpython-36m-darwin.so, 2): Library not loaded: @rpath/libuuid.1.dylib
  Referenced from: /Users/cball/Eunectes/mc3/envs/geov2/lib/libgdal.20.dylib
  Reason: image not found
-------------------- >> begin captured logging << --------------------
shapely.geos: DEBUG: Trying `CDLL(/Users/cball/Eunectes/mc3/envs/geov2/bin/../lib/libgeos_c.dylib)`
shapely.geos: DEBUG: Library path: '/Users/cball/Eunectes/mc3/envs/geov2/bin/../lib/libgeos_c.dylib'
shapely.geos: DEBUG: DLL: <CDLL '/Users/cball/Eunectes/mc3/envs/geov2/bin/../lib/libgeos_c.dylib', handle 7f8a6f790e30 at 0x11c4f2eb8>
shapely.geos: DEBUG: Trying `CDLL(/usr/lib/libc.dylib)`
shapely.geos: DEBUG: Library path: '/usr/lib/libc.dylib'
shapely.geos: DEBUG: DLL: <CDLL '/usr/lib/libc.dylib', handle 1114a3bb0 at 0x10f2aac88>
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 4 tests in 2.731s

FAILED (errors=1)

But maybe I have other stuff on this laptop that's interfering, or I didn't follow the right instructions.

Fixed in https://github.com/ioam/geoviews/pull/113 I believe, if not please reopen.


Neat GA and FW release update

Learn Build status updates of commit bc627e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Teams/devices/teams-ip-phones.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@dstrome
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Differences in display logic online and local

The issue is best observed on this branch
I'm working on updating a LINQ tutorial to be more visual. This shows the effects of using LINQ methods to "shuffle" a deck of cards. After each shuffle, the deck is redisplayed.
There are major differences in the rendering depending on the environment:

When I run locally in Jupyter Lab, the final cell updates the same space in the page to show how the cards are re-arranged in each shuffle.
At binder.org, in lab mode, the final cell runs to completion, but does not update the space above the cell.
Locally in Jupyter notebook, the card display updates as a single column. Each shuffle is displayed.
Online in notebook mode, the card display is a single column when the deck is first displayed. However, when the final cell executes, the display locations don't update.

Please complete the following:
Which version of .NET Interactive are you using?
Version: 1.0.131602+4499f850afa38e598630719e20ae0cb6a8898472
Build date: 2020-06-17T17:37:18.5307537Z

OS

[X] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[X] Edge
[ ] Firefox
[ ] Safari

Frontend

[X] Jupyter Notebook
[X] Jupyter Lab
[ ] nteract
[ ] Visual Studio Code
[ ] Other (please specify)

Screenshots
This is the local version:

@BillWagner can you post screenshots for the other scenarios?

Here's the notebook version at mybinder.org:  (All 52 cards are in a single column. And after running the last cell, the "number of shuffles" text still shows "0" shuffles):

are online and local all same version of jupyter and jupyter lab?

Online version:

Version: 1.0.126104+2b7b465575ad2085df7dc7efea7a1e72afbbf380
Build date: 2020-05-12T00:41:54.0000000Z

Local version:

Version: 1.0.131602+4499f850afa38e598630719e20ae0cb6a8898472
Build date: 2020-06-17T17:37:18.5307537Z

How do I get the online version updated? Is that in the dockerfile?

We can update the online tool no problem but I am asking about the jupyter lab and jupyter notebook version our code emits the xml the card formatter produces and the message is the same , the integration with the front end is done on the web page by the hosting code. I am trying to narrow down the differences that lead to such different behaviours

Online version:

Version: 1.0.126104+2b7b465575ad2085df7dc7efea7a1e72afbbf380

Build date: 2020-05-12T00:41:54.0000000Z

Local version:

Version: 1.0.131602+4499f850afa38e598630719e20ae0cb6a8898472

Build date: 2020-06-17T17:37:18.5307537Z

How do I get the online version updated? Is that in the dockerfile?

Yes the online version is the one from the docket file in your repo

The local version of Jupyter lab is 1.1.4.
The local version of Jupyter notebook is 6.0.3
The online version of Jupyter lab is 2.1.3
The only version of Jupyter notebook is 6.0.3

can you se this in the docker file
FROM jupyter/base-notebook:latest

# Install .NET CLI dependencies

ARG NB_USER=jovyan
ARG NB_UID=1000
ENV USER ${NB_USER}
ENV NB_UID ${NB_UID}
ENV HOME /home/${NB_USER}

WORKDIR ${HOME}

USER root
RUN apt-get update
RUN apt-get install -y curl

ENV \
    # Enable detection of running in a container
    DOTNET_RUNNING_IN_CONTAINER=true \
    # Enable correct mode for dotnet watch (only mode supported in a container)
    DOTNET_USE_POLLING_FILE_WATCHER=true \
    # Skip extraction of XML docs - generally not useful within an image/container - helps performance
    NUGET_XMLDOC_MODE=skip \
    # Opt out of telemetry until after we install jupyter when building the image, this prevents caching of machine id
    DOTNET_TRY_CLI_TELEMETRY_OPTOUT=true

# Install .NET CLI dependencies
RUN apt-get update \
    && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
        libc6 \
        libgcc1 \
        libgssapi-krb5-2 \
        libicu66 \
        libssl1.1 \
        libstdc++6 \
        zlib1g \
    && rm -rf /var/lib/apt/lists/*

# Install .NET Core SDK
RUN dotnet_sdk_version=3.1.301 \
    && curl -SL --output dotnet.tar.gz https://dotnetcli.azureedge.net/dotnet/Sdk/$dotnet_sdk_version/dotnet-sdk-$dotnet_sdk_version-linux-x64.tar.gz \
    && dotnet_sha512='dd39931df438b8c1561f9a3bdb50f72372e29e5706d3fb4c490692f04a3d55f5acc0b46b8049bc7ea34dedba63c71b4c64c57032740cbea81eef1dce41929b4e' \
    && echo "$dotnet_sha512 dotnet.tar.gz" | sha512sum -c - \
    && mkdir -p /usr/share/dotnet \
    && tar -ozxf dotnet.tar.gz -C /usr/share/dotnet \
    && rm dotnet.tar.gz \
    && ln -s /usr/share/dotnet/dotnet /usr/bin/dotnet \
    # Trigger first run experience by running arbitrary cmd
    && dotnet help

and then you keep going on copying notebooks and all ?

made this PR

I'll give this a try.

@colombod and I worked through a solution on Friday:
The problem is that any cell must be written to using display(...) to assign a variable in the same cell before using location.Update() to update the HTML.
The updated code is now in the original branch, and will be in this repo under notebooks/LINQ/index.ipynb
I'll close this.


Google cloud storage support

Request details
It would be nice if reposilite supported google cloud next to s3.
I would prefer to use google cloud storage instead of s3 since it's a lot cheaper.
Files stored on google cloud can be accessed on the internet when the proper policy is set, an example of one of these URLs could be https://storage.googleapis.com/my-gcloud-bucket-name/com/example/project/1.0.0/project.jar
API documentation can be found on this page https://cloud.google.com/storage/docs/json_api/ and a free tier is available if you upload less than 5GB a month.

Right, probably https://github.com/googleapis/google-cloud-java might be a good candidate for client with https://www.testcontainers.org/modules/gcloud/ for integration tests.

Google Cloud Storage buckets should work just fine as they also use the s3 protocol.

Oh, good to know. If so, then it should work like you said. We're compatible with a few similar services - tests are running against Localstack and I'm also using MinIO as self-hosted solution.

Just set it up myself and can confirm that it works like a charm

Awesome :)


kavita: <IP_ADDRESS> -> <IP_ADDRESS>

Description of changes
Supersedes #242739

Add myself as maintainer.
Add updateScript
Update <IP_ADDRESS> -> <IP_ADDRESS> (changes).

Update patches to apply cleanly, also add patches & tests to find locale files.

Update nixos module to accept freeform settings.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Since last review:

Updated to latest (<IP_ADDRESS> -> <IP_ADDRESS>)
Added myself as maintainer
Added updateScript

superseded by #281236


[SUPPORT] Is hoodie.consistency.check.enabled still relevant?

Is the option https://hudi.apache.org/docs/configurations.html#withConsistencyCheckEnabled still relevant? Given the documentation in https://aws.amazon.com/s3/consistency/ it seems like no ("S3 also provides strong consistency for list operations, so after a write, you can immediately perform a listing of the objects in a bucket with any changes reflected"), but wanted to check before disabling. Thanks!

@jtmzheng That's a good point. I think this is not relevant anymore. Do you mind creating a PR to disable this check by default as well ?

I don't think its enabled by default? We should correct the docs, as
needed.
On Mon, May 24, 2021 at 4:07 PM n3nash @.***> wrote:

@jtmzheng https://github.com/jtmzheng That's a good point. I think this
is not relevant anymore. Do you mind creating a PR to disable this check by
default as well ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/hudi/issues/2983#issuecomment-847411435, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI75PEZ2MXB3DZ45H4OD33TPLL3ZANCNFSM45MJNL3A
.

We enabled for our Hudi 0.6 dataset since this pre-dated strong consistency on S3. Wanted to confirm we can safely disable this now since I think this adds overhead to ingestion.

I think this is still required as i have seen issues still persisting in emr version below 5.33

@fanaticjo what kind of issues did you see?

@jtmzheng The consistency check is disabled by default
  private static final String CONSISTENCY_CHECK_ENABLED_PROP = "hoodie.consistency.check.enabled";
  private static final String DEFAULT_CONSISTENCY_CHECK_ENABLED = "false";

Please confirm with the EMR team to ensure that the S3 flag can be disabled for your use-case. Closing this issue since the config is already false.


hyperv: add logic specific to the use of the Hyper-V hypervisor

Hyper-V exposes a set of virtual CPUID leaves, MSRs, and a set of hypercalls to assist with virtualization.  The hyperv module includes definitions that permit the use of interfaces specific to Hyper-V.

Changes look good to me. @stefano-garzarella can you please have a look as well and approve when all your comments have been addressed?

@joergroedel LGTM, just approved. @msft-jlange thanks for fixing all safety messages!


Fixing DRC rule for BJT drc table

Fixing DRC rule for BJT drc table

@atorkmabrains Could you please merge this ?


Bug: Java zulu installation failing with ZIP

Bug report
unable to install  sdk install java 19.0.2-zulu
**Error Message **
tar and/or gzip not available on this system.
Please install tar/gzip on your system using your favourite package manager.
To reproduce
sdk install java 19.0.2-zulu
System info

OS (Mac) and version : 11.7.2 (20G1020)
Shell and version : zsh 5.8 (x86_64-apple-darwin20.0)
The output of sdk version SDKMAN 5.16.0

** Additional Info**

Executed Zip command and tar command works fine with same user

Hi @ramkumar-equinix!
I've tested the installation on my Mac (albeit with Bash) and everything went well.
Do you have any aliases for tar or unzip defined? You can check the list of aliases by typing alias.

I am having a similar issue. I cannot install Java (tried Zulu and Temerium)
unzip:  cannot find or open /home/me/.sdkman/tmp/java-17.0.6-tem.zip, /home/me/.sdkman/tmp/java-17.0.6-tem.zip.zip or /home/me/.sdkman/tmp/java-17.0.6-tem.zip.ZIP.

All tools are installed and no aliases are defined. Since my default shell is Zsh, I tried it in Bash as well with the same result.


Update default CAPI version to v1alpha3

During the community meeting it was decided that default CAPI version should be switched to v1alpha3.

/assign @maelk
/cc @iranzo

/lgtm
/hold until the change is actually done in metal3-dev-env

I'm closing this PR, and reopen because of my local issues with git.
Sorry for that.


Added explanation of scheduling options

https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity provides a more full description but I felt it worthwhile to clarify that there are two major anti-affinity scheduling options that can be chosen.

Thanks, @eamonryan! Should this also be in the PKS v1.3 docs? If so, I can cherry-pick to master.

It should apply to all PKS versions @bentarnoff !

@eamonryan This branch had merge conflicts with our master and 1-2. So instead of merging the entire branch, I cherry-picked only this commit https://github.com/pivotal-cf/docs-pks/pull/484/commits/d1c0b000980a1a09c82eedb5bbe3f3522eaf75ab into the master branch. I'm closing this PR. Thanks!


Reader Bugs

Setup or portable version of the app?
Portable
Steps to reproduce
Reader Bug

Open any manga in the reader.

✔ Expected Behavior

To show all pages.
And to be able to scroll up the images even when the side list is pinned.

❌ Actual Behavior

Only shows one page.
And Cannot scroll up the images when the side list is pinned.

https://user-images.githubusercontent.com/116664905/228539543-d17d8047-2ef9-499b-8da7-4f944e64761f.mp4

I recommend that you do ctrl+= or 0 once as old app version had a related bug which caused system buttons to not scale with app.
And regarding the main issue, I tried it on both setup and portable version and couldn't find any issue, please try restarting app after  ctrl+= or 0 or send me the test folder.

Its working as expected without any bug.

Try ctrl + 0 and then restart app. Or there might be some missing information to the bug

The image counting is working as intended, but the total images is stopped at 1.

Please provide screenshots as I had not encountered such issue.

I recommend that you do ctrl + = or 0 once as old app version had a related bug which caused system buttons to not scale with app.

Hope it helps

This application does not have a digital certificate because it costs a lot and I make zero money off this app, So your anti virus might be detecting it as malware.
You can try saving settings and deleting app and reinstalling, but i think window zoom is hiding your pagenumber as i can see system button and topbar are not lined in you screenshot

If you dont mind, can you send recording if ctrl + = or - focused on system buttons.

I think I know the reason. You can also reproduce this malware behavior.

That will be helpful, please mention.
Also do note that since this app is not signed, I have to use my custom update system because i couldn't get any ither to work, which work by deleting old files and extracting new app.zip in same folder.

It never flagged the application as malware until now.

If you had ever used setup version of this app you would know, theres always a popup saying this app can be harmful then auto-updating.

It's hidden. Can briefly see the page number while scaling up.

Thanks for this, I have identified the issue and will fix soon

Steps to reproduce the malware behavior.

That is because every time app start it check theme file for changes and saves, when refreshed repeatedly saving process is interrupted and cause this error.

I dont have any knowledge about how anti-viruses work so cant say anything.

Have you found a method to stop the increasing RAM usage when chapters are changed without any time interval?

Sorry but i havent had much time to test different things,

Please check again in new version after doing ctrl + 0 when input box is not selected.


remove SSL section from docs

take out section on SSL connections since it cannot be used until curator is updated to version 3.x.x

In the current version of this doc I still don't see spring.cloud.zookeeper.client.secure, does spring-cloud-zookeeper still not support SSL?


REGENIE "ERROR: !! Uh-oh, SNP has low variance (=0.000000)" problem & solution

Hello, I would like to share an experience and a mistake I made during running the first step of REGENIE.
 Uh-oh, SNP rs142716585 has low variance (=0.000000).

(If you did not face the error, it is totally fine to go to the next step)
The error message indicated that the variant was perfectly correlated with the covariates (PC1~10 & age), which was very unlikely, or the minor allele count of the variant was zero or near zero. This variant, on chromosome X, had the MAF between 3% and 5% in the array data. After removing the variant (with --exclude option), I faced the same error with another variant on chrX.
The problem was: even though the variants had the non-rare frequencies 'in the array data of all participants,' it was still possible that these variants did not exist in a specific group, males with African ancestry in this case. REGENIE does not detect those variants beforehand, so we need to make a list of such variants and exclude them.
The solution was using plink to make a list of variants with non-zero MACs in the group and provide the list to REGENIE. (It is also explained in the FAQ page of REGENIE: see https://rgcgithub.github.io/regenie/faq/)
Below is the code:
# This code generates a plain text file of the list of variants with the non-zero counts,
# ... with each variant ID on each line
plink \
  --bfile BioVU_array_AFR \
  --keep id_males_AFR.txt \
  --mac 1 \
  --out BioVU_array_male_AFR_pass \
  --write-snplist
# Output: BioVU_array_male_AFR_pass.snplist

# Provide the list generated with plink to REGENIE
regenie \
  --step 1 \
  --bed BioVU_array_AFR \
  --covarFile covar_AFR.txt \
  --covarCol PC1,PC2,PC3,PC4,PC5,PC6,PC7,PC8,PC9,PC10,age \
  --phenoFile covar_AFR.txt \
  --phenoCol cad \
  --keep id_males_AFR.txt \
  --bsize 10000 \
  --bt \
  --lowmem \
  --lowmem-prefix tmp_rg1 \
  --out Autosome.AFR.BioVU.male.Jaehyun_Park.CAD.REGENIE.Sep232024.Step1 \
  --extract BioVU_array_male_AFR_pass.snplist  # Provide the list to REGENIE so that it can ignore the variants with zero counts

We can set the --mac option in plink not to be 1, but since the first step of REGENIE includes adjusting the sample relatedness, I would recommend including all the variants with non-zero counts in this step. Also, it is not recommended to exclude the whole chromosome (chrX in this case) causing the problem; although the predictors from Step 1 are calculated in chromosome-wise manner, the calculation includes leave-one-chromosome-out (LOCO) and cross-validation procedure, and the result can be different by the chromosomes included in the step. For accurate results, I would recommend using all variants with non-zero counts.
I hope this would be helpful to other people in this analysis. Thank you.

Update: I got a response from Dr. Joelle Mbatchou, the author of REGENIE, regarding this issue; she told me that the predictors with and without chrX should be different since a single joint model is first fitted across all chromosomes (and then zero out each chromosome to calculate LOCO predictions), but the predictions should be highly correlated.
Since the first step is to get the sample relatedness and population structure, she also said that this step can be done only with autosomes (although I personally prefer including all available chromosomes).


[SIS-063] Fix Poppins font import and linking

As a user of the Sistema Lesson Planner, I want the font to be nice and sleek kekw

Technical Information
The Poppins font family has been imported to the ./assets/fonts directory and linked into both the Android and iOS via the npx react-native-asset command. However, the font is still not appearing, and using fontFamily: "Poppins" can even break the build. This ticket is for fixing this bug. See Resources section for guides that might be helpful.
BONUS: Create a MyAppText component that can automatically apply Poppins font styling across all classes and components without having to repeatedly redefine the styling in each individual class. See React Native's documentation.

[ ] Applying fontFamily: "Poppins" styling should not break anything and should change the font on both Android and iOS builds
[ ] Using different weight and style variations should not break either i.e. fontFamily: "Poppins-Light"

Design
The fixed final product should look like the following:

Resources
Custom Fonts in React Native
React Native Text
React Native Issues

mingi has this working in his current branch!


Support Leaderelection like client-go

Hi there, I am pretty interested in this k8s client rewritten by rust, Does there exists a way to do leader election using kube-rs?
just like https://github.com/kubernetes/client-go/blob/master/tools/leaderelection/leaderelection.go

There's currently no support for that in here. It's a bit of a peripheral api, and it's also marked as alpha.
It looks a bit involved, but not beyond the scope of what we could implement at least in an example initially.
It is specific behaviour against certain kubernetes objects, and we don't do a lot of that in these crates.
In particular, it looks like it's using coordination.k8s.io/v1 leases, pods and endpoints, so not sure it should ever live in here.

On the other hand, if it does, it would be more as part of proposed utilities.

Implementing this following the same pattern as the K8s core controllers should be rather straightforward. The Go code will translate well enough to Rust (the Rust code will quite likely be a bit more simple though).
@clux @ZhiHanZ I'm going to be implementing this in my application code soon, but I can keep it well isolated enough that I could just copy/paste it over to a new PR here so that other folks can use it. Any preferences on what this should look like, organization of code, etc?

I needed some advisory locks for my web app. I needed to make sure a namespace was "locked" to avoid users from stepping on eachother.
Here's my "lease" code: https://gist.github.com/xrl/3c5727e30e78ae300539fd93defc031b

@xrl Cool! This seems like something that we ought to have in kube_runtime. Haven't had the time to go through all of it, but a few notes:

Poll for the lease then acquire it

Any reason not to watch instead?

Spawns background task for renewing the lease

This feels a bit dangerous, since renewing the lease is supposed to mean "yes I'm still here and doing useful work", which seems like something that the application ought to signal explicitly.
I'm also personally a bit wary of spawning background tasks without the user's explicit consent (see https://vorpus.org/blog/notes-on-structured-concurrency-or-go-statement-considered-harmful/).

Joining a lease will shutdown the background task and zero out lease timestamps

Looks like this happens asynchronously on Drop as well? Is there any danger in the user trying something like:
loop {
    Lease::acquire_or_create(...).await?
}

can I define a async block elsewhere than inline with tokio's spawn?

Yes, async { ... } is just a regular expression (that happens to have an unpronouncable type that implements Future).

If this code seems useful, what's the best way to contribute it?

Feel free to send a PR to kube_runtime, or publish it as an independent crate.

Any reason not to watch instead?

The lease holder could fail to update the lease (they crash, bug in lease implementation) and no updates would propagate through the listener. I could implement a watcher to see if a lease is updated before expiration (the lease holder is done and does the right thing, releasing the lease). I simplify my implementation by doing a relatively short lease duration and just checking more often.

This feels a bit dangerous, since renewing the lease is supposed to mean "yes I'm still here and doing useful work", which seems like something that the application ought to signal explicitly.

I think if you have a valid handle on the lease task (similar to a mutex guard) you are signaling "I am still here using this". Otherwise the lease holder will have to implement timing logic to periodically refresh their handle and then that's work I don't want to sprinkle throughout critical sections.

I'm also personally a bit wary of spawning background tasks without the user's explicit consent (see https://vorpus.org/blog/notes-on-structured-concurrency-or-go-statement-considered-harmful/).

Great point. I would like to move the renewal loop to an async function and perhaps just document "if you want to periodically refresh the token, tokio::spawn(lease.renewal_loop), or perhaps lease.spawn_renewal_loop. What do you think between those APIs?

Looks like this happens asynchronously on Drop as well?

This is a slightly different variant, you drop the Sender type and the Reader in the background job will see a "other end of channel closed" error type. Which to me seems like a exceptional safeguard and regular use should explicitly send a signal.

loop snippet

I believe this is fine, it will just create a lot of spawned tasks and extra kube API calls. but it should be fine.
I just shipped this to my users yesterday, I'll burn it in and then consider how to move it to a PR for kube_runtime. First get it working, then get it pretty! Thanks for the feedback!

Looking forward to this feature! Here is an example use-case: https://programmer.group/implementation-of-leader-election-in-k8s-client-go.html
@xrl Your gist example seems cool! Have you tried it on production clusters?

@Dentrax yes, I use my bit of code in a production app. we have an in-house app release tool, built on actix-web, which uses advisory locks to keep our dev team from running concurrent deploys.

As far as I understood there're already 2 PRs with 2 different implementations of this feature.
Is there any chance that one of them would be merged soon?

None of the current suggested implementations were in any condition to be merged and it's been a very difficult problem to tackle in a way that suits everyone so going to unmark this as a thing we plan on doing in the near-future.
There were actually 4 PRs trying to do this (in wildly different ways), so listing them here as they now have been closed to reduce confusion;

#791
#843
#996
#1056

I think we will re-visit this later, but this is solvable outside kube. We also have more important issues to solve at the moment, and this has been historically unfruitful for us.
Feel free to link to alternatives below, like kubert's lease impl - however this one is out of date with kube.

Given that this issue is about a client-go like impl, https://github.com/kube-rs/kube/pull/1056 is quite literally a mirror of client-go's impl (adapted to Rust/kube-rs). It focuses just on the use of the coordination.io resources, but we can easily expand it to work with other resources (though I don't think there is any reason to do so given that we have no legacy code which depends upon this).
I don't think there is any confusion. The other PRs were trying to do other, seemingly different things. #1056 literally just implements what client-go implements.
That said, I totally respect if folks would like to have #1056 moved to a separate crate for now.

Ok, moved the impl in #1056 to a dedicated crate: https://github.com/thedodd/kube-coordinate


fix(tooltip): fix aria-describedby

https://github.com/radix-vue/radix-vue/issues/733

Also, I wonder if it would be worth refactoring the code, because it looks all the components mutate their context ids. I think it would be better to initialize such things at the root, as it would avoid such behaviors.

Thanks for the PR @remonke . useId was previously generated from Root. However it is not compatible with the current useId from Nuxt, thus I moved it to component.
Let me help ammend abit ya!


Call determineDataLimits only once

determineDataLimits is a very expensive call. We call it multiple times for each scale, but really only need to calculate it once
My initial idea was that in creating the layout we should call fit most of the times and update only once, but that proved very difficult. E.g. to fit the scale you need to create the labels, which means you need the format, which in the time scale means you need the unit, which means you need to know how many ticks there are. So the way things are structured right now you can't easily get around building the ticks multiple times. but determineDataLimits is by far the most expensive part of update for both the time and linear scale that I've been testing with, so this is actually a really big win.

For horizontal axis, the available width could change dramatically between these two calls (from full chart width down to nothing, when vertical axes / legend consumes all the space). In some scales, this changes what ticks are shown and might change the range required to display proper ticks.
Its a good thought, but I think we should calculate data limits separately (only once, and by caching instead of a true/false parameter) and do a lighter "range adjustment" always.
That however might be a breaking change.

Closing in favor of https://github.com/chartjs/Chart.js/pull/6304


url helper breaks subdomains

Fixes bug where the url helper breaks subdomains of blog url in navigation
Closes #5303

I miss-type the issue number. It should be #5033.

Hi @ianlopshire, welcome and congrats on your first PR to Ghost :+1:
Could you please take a few minutes to have a read of our contributing guidelines and review your code style and commit message? This PR is currently not passing out build.
In addition, a bug fix like this needs to include tests to show that the issue has been resolved and prevent regressions in the future. The existing tests for urlFor can be found here: https://github.com/ianlopshire/Ghost/blob/master/core/test/unit/config_spec.js#L150
Thanks :+1:

I've added unit tests for the nav context of urlFor and it passed build locally.

@ErisDS  is there anything else I need to do for this PR?

No nothing really - the second code block doesn't make instant sense as to what it's doing, but otherwise I've just not found a moment to take it for a spin yet, will get to it.


[MXNET-106] [ONNX_MXNet] Change parameter names in imported model

Description
This PR fixes the names of inputs parameters in the imported model.
Previously the imported model had input parameter names like - input_0, param_0, param_1 etc.. This PR changes it to use the same names as in the ONNX model file. While the current format works fine, this change was done to remain consistent with the ONNX tool chain. So that users moving between frameworks will not have to encounter different input and parameter names in their models.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] All changes have test coverage:
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@spidyDev @sandeep-krishnamurthy @lupesko @Roshrini

@cjolivier01


fix: upgrade to version 3.1.92

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abayer
You can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign abayer
You can assign the PR to them by writing /assign @abayer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

vault
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

vault
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

vault
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test vault

gsm
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test kube

vault
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test vault

gsm
785369d6ca08a8ccc8f10e2bbdb731dce324e924
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


[WIP] Add an Elasticsearch endpoint

What
Describe what you have changed and why.
How to review
This depends on https://github.com/alphagov/paas-observability-release/pull/6.
Who can review
Describe who can review the changes. Or more importantly, list the people
that can't review, because they worked on it.

I think this was closed automatically when I edited the root commit of the repo. I can't reopen it either. Will have to make a new PR when this code is ready.


Resolve #18881: Enhance lobpcg documentation with updated examples

Added examples utilizing aslinearoperator and LinearOperator

@lobpcg

Reference issue

What does this implement/fix?

Additional information

@anudeepadi Reference https://github.com/scipy/scipy/issues/18881

Look at the docsting text above your insert for duplicates

@anudeepadi could you please add me as a collaborator so that I can also edit the file? I have a few comments, but it would be easier for me to just edit rather than explain.

I have better incorporated the new examples into the previous text. LGTM


Add support for downloading and running closure compiler locally.

This will help with running grunt check on drone.io
TBR @ussuri

LGTM

:+1:


WBEC does not connect back to Wifi Network after power outage

My Wifi Network takes a bit, but it happend a few times in the last year, and I'm tired of running arround replugging the ESP after the Outage. Any Ideas how I could fix that?
Best Regards

Hi,
there is the following parameter:
uint16_t cfgWifiConnectTimeout;       // Timeout in seconds to connect to Wifi before change to AP-Mode
Default is 10s


Add GitHooks

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#9
#8
#7  👈
#6
#5
#4
#3
#2
#1
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite


I don't think that ChangeRequestHistory should force a Counter reset if the Counter matches the latest Counter when waiting futures are resolved

Affected Version
0.22.2 (suspected code path remains unchanged in druid 23 and master)
Description
2022-08-30T14:10:38,628 INFO [HttpServerInventoryView-6] org.apache.druid.server.coordination.ChangeRequestHttpSyncer - [https://XXXXXX.XXXXXX.com:8283/_1661264760506] requested resetCounter for reason [counter[Counter{counter=94953, hash=1661868638606}] >= last counter[Counter{counter=94953, hash=1661868638606}]].

You can see here that the client request for changes on this historical provides a Counter that matches the last counter on the server. This causes the client to send a fresh request to the server with a null counter in order to get the full set of segments. I am struggling to understand why we would want to reset a server that is up to date.
It looks like this is what is causing the Counter to be reset.
It seems that the above code path is run either when the Counter does not match when the client request is made OR when the waiting futures (requests waiting for a new change) are resolved here. It is this latter case that I don't understand the reset Counter return to client? Why not send some empty response and the client comes back with the same counter looking for a new change? Resetting it feels like overkill and added work for no gain. Perhaps I'm missing something here, but as of now it feels like incorrect, albeit not destructive, behavior.
spit balling on change to the code that controls resetting the Counter
    if (counter.counter == lastCounter.counter) {
      if (counter.matches(lastCounter)) {
        // return some empty response that does not cause client to reset counter
      } else {
        // this is bad, fail with a reset due to an incorrect hash - unlikely this would happen here, but it adds safety
      }
    } else if (counter.counter > lastCounter.counter) { // This is modification of original conditional to just GT
      return ChangeRequestsSnapshot.fail(
          StringUtils.format(
              "counter[%s] > last counter[%s]",
              counter,
              lastCounter
          )
      );
    } else if ...

Upon reviewing the code further, I'm struggling to identify how we even get into a case where we need to reset because the counters match for both counter number and hash. @clintropolis You mention investigating those warning logs in your patch, #12209, do you remember if those full syncs were getting caused by this same counter reset due to the counter from the client being >= to the latest counter when the change future is being processed on the data server?

One way I could see this happening is if this was called with an empty list. The only place I can tell that this would even be possible is here... but that should only be running during bootstrap and I have confirmed in my logs that I see the is finished log for the background announcer that runs during startup.
Either way, I wonder if it makes sense to put a conditional in place to only clear the futures if that first link gets called with a list of non-zero length to prevent resolving the futures when the counter hasn't incremented

@clintropolis You mention investigating those warning logs for duplicate segments in your patch, https://github.com/apache/druid/pull/12209, do you remember if those full syncs that were triggering the logs were getting caused by this same counter reset due to the counter from the client being >= to the latest counter when the change future is being processed on the data server?

😅 I unfortunately don't remember so well, but maybe it sounds familiar? I think what you are suggesting makes sense, though obligatory disclaimer that I'm not super familiar with this part of the code myself.

I think #13010 is a safe way to solve this. There is some unnecessary no-op network traffic, but it should put a stop to wasteful counter resets


Use 'raise_for_status' in python API calls

If the response is not a success message, this would not go in the Exception block, and will raise exception when try to proceed normal try block.
I think you should call raise_for_status() method of response, to properly raise the exception.
Also, the whole try except block is repetitive, how about make this a decorator?

https://github.com/lyft/amundsenfrontendlibrary/pull/156/files/11ead489d7a46d12f986aa0d673c313d74cbb81b#r287533106

Can I work on this?

@sourvad yes, we'd gladly accept patches for this!

Thank you!


Error while creating TFRecord in prepare_data.ipynb

I am trying to run the sample file to prepare the bees dataset and have run every cell until the tfrecord conversion step without any issues. I am getting the following error when I try to run the cell

UnexpectedStatusException                 Traceback (most recent call last)
 in
22             output_name='tfrecords',
23             source=output_folder,
24             destination=f's3://{bucket}/data/bees/tfrecords'
25         )
26     ]
~/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/sagemaker/processing.py in run(self, inputs, outputs, arguments, wait, logs, job_name, experiment_config, kms_key)
170         self.jobs.append(self.latest_job)
171         if wait:
172             self.latest_job.wait(logs=logs)
173
174     def _extend_processing_args(self, inputs, outputs, **kwargs):  # pylint: disable=W0613
~/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/sagemaker/processing.py in wait(self, logs)
854         """
855         if logs:
856             self.sagemaker_session.logs_for_processing_job(self.job_name, wait=True)
857         else:
858             self.sagemaker_session.wait_for_processing_job(self.job_name)
~/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/sagemaker/session.py in logs_for_processing_job(self, job_name, wait, poll)
3453
3454         if wait:
3455             self._check_job_status(job_name, description, "ProcessingJobStatus")
3456             if dot:
3457                 print()
~/anaconda3/envs/tensorflow_p36/lib/python3.6/site-packages/sagemaker/session.py in _check_job_status(self, job, desc, status_key_name)
2955                 ),
2956                 allowed_statuses=["Completed", "Stopped"],
2957                 actual_status=status,
2958             )
2959
UnexpectedStatusException: Error for Processing job tf2-object-detection-2021-07-29-09-51-30-040: Failed. Reason: ClientError: API error (404): manifest for<PHONE_NUMBER>34.dkr.ecr.us-east-1.amazonaws.com/tfrecord-processing:20210729094117 not found: manifest unknown: Requested image not found

The issue is earlier in the document, when it builds the docker image, then pushes it to the ECR Registry. The default IAM Role, which is called something like AmazonSageMaker-ExecutionRole-xxxxxxx (with some numbers at the end) does not have permission to 'Write' to ECR, specifically the 'InitiateLayerUpload' permission.
If you check on CloudWatch you will see the attempts, and selecting one of the events will show a message with:
"errorMessage": "User: arn:aws:sts::<ACCOUNT_ID>:assumed-role/AmazonSageMaker-ExecutionRole-<RANDOM_STRING>/SageMaker is not authorized to perform: ecr:InitiateLayerUpload on resource: arn:aws:ecr:ap-southeast-2:<ACCOUNT_ID>:repository/tfrecord-processing because no identity-based policy allows the ecr:InitiateLayerUpload action"
I created a new policy all the 'Write' permissions, and attached it to the AmazonSageMaker-ExecutionRole. Then rerun the whole notebook, and the docker push to ECR should complete.

Hi @Abhishek-08, i have updated the repo with new TF version.
Can you have a try and confirm it works now?


Weird permission denies when installing hyperdock

This says it all
~/C/abc-ui ❯❯❯ brew cask install hyperdock                                                              feature/mailboxes-actions ✱
==> Tapping caskroom/cask
Cloning into '/usr/local/Library/Taps/caskroom/homebrew-cask'...
remote: Counting objects: 3708, done.
remote: Compressing objects: 100% (3656/3656), done.
remote: Total 3708 (delta 65), reused 619 (delta 32), pack-reused 0
Receiving objects: 100% (3708/3708), 6.48 MiB | 4.62 MiB/s, done.
Resolving deltas: 100% (65/65), done.
Checking connectivity... done.
Tapped 1 formula (3,676 files, 15.3M)
==> Downloading https://bahoom.com/hyperdock/<IP_ADDRESS>/HyperDock-<IP_ADDRESS>.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask hyperdock
==> Moving Preference Pane 'HyperDock.prefpane' to '/Library/PreferencePanes/HyperDock.prefpane'
Error: Permission denied - (/usr/local/Caskroom/hyperdock/<IP_ADDRESS>/HyperDock.prefpane, /Library/PreferencePanes/HyperDock.prefpane)
  Most likely, this means you have an outdated version of homebrew-cask. Please run:

      brew uninstall --force brew-cask; brew untap phinze/cask; brew update; brew cleanup; brew cask cleanup

  If this doesn’t fix the problem, please report this bug:

      https://github.com/caskroom/homebrew-cask#reporting-bugs

/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:519:in `rename'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:519:in `block in mv'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1558:in `block in fu_each_src_dest'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1574:in `fu_each_src_dest0'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1556:in `fu_each_src_dest'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:508:in `mv'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:50:in `move'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:26:in `block in install_phase'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:43:in `block in each_artifact'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:42:in `each'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:42:in `each_artifact'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/artifact/moved.rb:22:in `install_phase'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:129:in `block in install_artifacts'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:126:in `each'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:126:in `install_artifacts'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:75:in `install'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:21:in `block in install_casks'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:18:in `each'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:18:in `install_casks'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:7:in `run'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli.rb:83:in `run_command'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli.rb:121:in `process'
/usr/local/Library/Taps/caskroom/homebrew-cask/cmd/brew-cask.rb:26:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Library/brew.rb:22:in `require?'
/usr/local/Library/brew.rb:93:in `<main>'

I already did the recommendations and ran brew uninstall --force brew-cask; brew untap phinze/cask; brew update; brew cleanup; brew cask cleanup. Yet, the above error still happens. Any clues?

Use --force when installing.

Also, it should not be linking to /Library/, which means you likely set that as an option.

the --force option does not make any difference

Like I said

Also, it should not be linking to /Library/, which means you likely set that as an option.

Check your options.

hmmm, sudo worked for me


chore: promote origins-cms to version 0.0.8

chore: promote origins-cms to version 0.0.8
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign dnmahendra
You can assign the PR to them by writing /assign @dnmahendra in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


How to go back and refresh the previous page.

For example :I want to go back to page1 from page2 and refresh page1
myApp.onPageBeforeAnimation('page1', function (page){

  if (page.from === 'left') {
       page.view.router.refreshPage();
  }
});

But page1 cant`t refresh .Why? @nolimits4web

You can't do anything with router during it is animation, there is a "lock".  Or do go back with ignoreCache: true and force: true

Refresh your page first and then go back I have tried to use
page.view.router.refreshPreviousPage()

and then use a go back function,But it can only refresh and it cantt go back.Because it dontt know when it refresh completely. And when the data is refreshing,it run go back. The real reason I don`t know.
So I want to go back first and then refresh.
I can`t understand your second suggest ,can you tell me more detailedly.
I use
back

But it can`t work too. For example :
My navigation is   Page1 -> Page2 -> Page3
I want to go back to Page2, but when I use the code , it go back to Page1 from Page3.
Can you help me? @nolimits4web

Then do it in after pageAfterAnimation

Thanks.
The solution is
page.view.router.back({
                    url: redirect,
                    force: true,
                    ignoreCache: true
                })

Yes, this is what i meant in my first comment ;)

But if previous page is a dynamic page like: mypage.html?id=01 and the url is unknow???

I have the same problem as noveweb mentioned.
Page1 is a page with xhr content loaded (In pageInit function)
When the page is navigating from page2 back to page1,

using data-load-previous="true" with 'back' class does not reload the previous page
by only using data-load-previous="true" does reload the previous page and the xhr content in the previous page but the page2 still exist on the screen
data-force does reload the previous page but not including the xhr in it.
adding pageReinit to page1 does not solve the problem.

And I tried the solution above in the topic, no luck.
Do you have any idea? @nolimits4web

I have got the same issue.

        page.view.router.back({
            url: 'users/index',
            force: true,
            ignoreCache: true
        });

works ... however I don't know the URL up front.

@ionas @noveweb
To solve the dynamic previous url problem, I found the history entries can be read by
page.view.history

then, we can do something like
page.view.router.back({
  url: page.view.history[page.view.history.length - 2],
  force: true,
  ignoreCache: true
});

But I'm wondering why page.view.router.refreshPreviousPage() doesn't work in my code...

@hcw12889
Look at the code in router.js line 838. The if part cause the problem you meet. I have commit it, but I have no idea about how to fix it.

@obnijnil THANKS YOU MASTERRRRR!!!

Hi Vlad, @nolimits4web, can reload or refresh a piece of script on last back button.

Hi i'm still new in f7, i have an index page which have login screen modal written on it too and also i have a function running in index onPageInit to load some information about user in a

, problem is when i do login i want to going back to new refreshed index page from wherever page i am before, i'm using all the solution you suggest, it do works, but my user information keep disappearing i assume it happens due to opening a new layer index page so the load function js on ` can run only once, this also affect the login alert, when i log out and log in again the alert that indicate login shows multiple times and it's buggers me
here is the code i use for log in and log out routing:
mainView.router.refreshPage(); mainView.router.back({url: 'index.html', force: true, ignoreCache: true,reload: true});
i change the div id info into class info so it solved but the alert still multiplies when i do login and log out several times, what i want to know is it possible to do log in in log in screen modal and then go to refreshed index page without opening some like new layer page so the alert problem's gone? @nolimits4web thanks before

never mind i've just embedded login-screen into page and everything works smooth

I have 3 tabs in a news.html page. In each tab, there is news listing. When clicking on that news it goes its detail page. Even if I am in a third tab and go to detail page from there when returning back the first tab is selected. I want that 3rd tab selected if the detail page goes from 3rd tab.
It was working with
mainView.router.back({  ignoreCache: true});
but when I updated to below code it stopped working. The page refresh but it goes to 1st tab at any case.
mainView.router.back({url: 'news.html', force: true, ignoreCache: true,reload: true});
Any idea?

mark


ARROW-9856: [R] Add bindings for string compute functions

@github-actions crossbow submit homebrew-r-autobrew

Aside from possibly adding more tests here (arguably redundant since the functions themselves are tested in C++, but perhaps worth more assurance that they behave as an R user would expect), this is done. Other TODOs have been made into followup JIRAs.

I'm going to merge this now. We're going to be iterating on this code for a while so I don't feel compelled to make everything perfect and thorough here.


TRANSLATE String Function: #13

Implemented Translate string functions.

Thank you @Lilit0x,
We need to fix docs for stuff function it missing return type
https://github.com/AmrDeveloper/GQL/blob/9207364dc8882cb39905998733aab27f784765cb/docs/function/functions.md?plain=1#L23

Thank you @Lilit0x,
We need to fix docs for stuff function it missing return type
https://github.com/AmrDeveloper/GQL/blob/9207364dc8882cb39905998733aab27f784765cb/docs/function/functions.md?plain=1#L23

I will fix docs fast


apr22_pdbbind_gvp_pocket_radius20

Hi,
The function get_data from data.py tries to create the dataset from the folder apr22_pdbbind_gvp_pocket_radius20, which is not created by the notebook construction_PDBbind_training_and_testing.ipynb. Can you please tell me how to fix it?
Thank you.

嗨， 函数 get_data from data.py 尝试从文件夹 apr22_pdbbind_gvp_pocket_radius20 创建数据集，该文件夹不是由笔记本 construction_PDBbind_training_and_testing.ipynb 创建的。你能告诉我如何解决它吗？ 谢谢。

I have the same question. Have you solved it?

My advice to you is stop using TankBind and try other code such as FABind or DiffDock code.


failed retries exception should show all unavailable servers

JAVA-5119

Hi @faucct, thanks for your contribution. As per our contributors policy, please open an issue at https://jira.mongodb.org/projects/JAVA explaining the problem that you're trying to solve with this PR.
Thanks,
Jeff

https://jira.mongodb.org/browse/JAVA-5119

Closing as JAVA-5119 has been closed.


Adding values to override EMAIL retry

What's this PR do? Any additional context?
This will override the values of EMAIL in setting files
Where should the reviewer start?
he should deploy the fix and check the key in lms.env.json
How can this be manually tested? (brief repro steps)
This can be tested by checking the added keys in lms.env.json after deployment
What are the relevant TFS items? (list id numbers)
98998
Definition of done:

[ ] Title of the pull request is clear and informative
[ ] Add pull request hyperlink to relevant TFS items
[x] For large or complex change: schedule an in-person review session

Reminders BEFORE merging

Get at least two approvals
If you're merging into the development branch then "flatten" or "squash" commits
If merging from development into master then don't "flatten" or "squash" commits

Reminders AFTER merging

Delete the remote branch
Resolve relevant TFS items
(reverse merge) If you merged into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc)

Thanks everyone


[Bug] Check phase name before SearchRequestOperationsListener onPhaseStart

Description
The SearchRequestOperationsListener onPhaseStart() method is getting called TWICE consecutively during query phase in select cases. This occurs any time following can match phase. onPhaseStart() should only be called ONCE per search phase and must be paired with either onPhaseEnd() or onPhaseFailure().
Solution

Rename first instance of duplicate "query" phase to "none" phase as it is not yet reached SearchQueryThenFetchAsyncAction
Call onPhaseStart() only when current phase is one of 6 search phases we track

public enum SearchPhaseName {
    DFS_PRE_QUERY("dfs_pre_query"),
    QUERY("query"),
    FETCH("fetch"),
    DFS_QUERY("dfs_query"),
    EXPAND("expand"),
    CAN_MATCH("can_match");
}

Testing

existing UTs
phase_took search

% curl -XGET 'localhost:9200/_search?pretty&phase_took' -H 'X-Opaque-Id: my-id' -H 'Content-Type: application/json' -d'{
 "query": { "match_all": {} }
}'

{
  "took" : 63,
  "phase_took" : {
    "dfs_pre_query" : 0,
    "query" : 32,
    "fetch" : 17,
    "dfs_query" : 0,
    "expand" : 0,
    "can_match" : 0
  },
  "timed_out" : false,
  "_shards" : {
    "total" : 10,
    "successful" : 10,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 2,
      "relation" : "eq"
    },
    "max_score" : 1.0,
    "hits" : [
      {
        "_index" : "test2",
        "_id" : "2",
        "_score" : 1.0,
        "_source" : {
          "field2" : "value2"
        }
      },
      {
        "_index" : "test2",
        "_id" : "1",
        "_score" : 1.0,
        "_source" : {
          "field1" : "value1"
        }
      }
    ]
  }
}

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh  can you take a look at this minor bugfix?

Looks like some more tests needed for code coverage although this might not be related to your change

Is there any risk with calling onPhaseEnd without calling onPhaseStart? With this change, that would be possible, right?
Would it make sense to gate all of the listener callbacks behind this check?

With the current SearchRequestOperationsListener subscribers I don't see any risk, but it makes sense to maintain the 1:1 relation between start:end calls. I added verification to onPhaseEnd and onPhaseFailure.


Added cl_khr_fp16 extension support for test_explicit_s2v from basic

According to issue description (basic section):
https://github.com/KhronosGroup/OpenCL-CTS/issues/142
Additional remark (1): original test skips conversions between different types, in other words supported conversions were eg. char scalar->char vector, int scalar->int vector, float scalar->float vector and so on. This PR extend the scope of original test to integral scalar types->integral vector types, floating scalar types->floating vector types
Additional remark (2): test fails with my Intel device and kernel with half conversions:
ERROR: Explicit cast of scalar float to vector half2 FAILED; skipping other half vector tests
I will appreciate additional attention when it comes to testing cl_khr_fp16 with this test

Regarding
Additional remark (2): test fails with my Intel device and kernel with half conversions:
ERROR: Explicit cast of scalar float to vector half2 FAILED; skipping other half vector tests
I will appreciate additional attention when it comes to testing cl_khr_fp16 with this test

I'm also seeing this error locally:
ERROR: Output value 0:0 does not validate for size 2:2!
       Input:   0x4dbe2551
       Actual:  0x7c007c00 0x7c007c00 0x7c007c00 0x7c007c00
ERROR: Explicit cast of scalar float to vector half2 FAILED; skipping other half vector tests

0x4dbe2551 is 398764576.0f which is outside the range of half, which is why the half2 is (0x7c00, 0x7c00), i.e INF values. So think we might need to check for overflow during the verification.

@EwanC I just added missing part of convert_explicit_value to support kHalf ExplicitType. Test passes now but I will appreciate reviewing it more carefully - I am not quite sure it is 100% correct

Reviewing

We are seeing failures with the latest commit. Debugging at our end. Need some more time.
Thanks,
Balaji

Added a patch that does the NAN check.

Discussed in the October 3rd teleconference.  Will wait a week to address the comments above.


Invalid links to website

Hi,
Just a minor heads-up, but most links to your website, be it in the description for the Google Play store or in the app itself, are outdated by now.
The one in the former links to a non-existing site, the latter links to a website with an invalid certificate.

Why hasn't this been fixed yet?

Closing as the links have been fixed in code. However these changes won't be reflected in the app until v2.0.0 is released.


Fix pill

broken since commit b0fa4b78b06627cce627340878ea67cd0b3d4422

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


WIP: Import google history

Hi,
I've created a POC for importing data from google history using webview.
The flow includes:

Login (+automatic logout after completion)
Scraping and transforming data (using https://www.google.com/maps/timeline/kml endpoint)
Interpolating the Data (not sure if needed as we can add begin/end timestamp in db)
Writing historic data to the db (add functionality for bulk writing)
Minimal UI (no explanations, ugly "done" screen, navigation is from the scan header)

I've tested it with Android, the writing to the DB works but I've haven't managed to trigger a notification yet.
I've seen that there's already an issue that mentions the same approach:
https://github.com/MohGovIL/hamagen-react-native/issues/76
If this solution can be useful, let me know, otherwise, feel free to close the PR.
Thanks,
Yshay

Thanks @Yshayy ! This is truly an awesome contribution.
Our team already works on a similar solution, with a UX flow and everything. Should be out tomorrow!
I'm keeping your PR open, for the time being, just in case.

Great, looking forward to it :)

Any update?

Is there anything I can help to push this feature forward?
Obviously, time is critical for this one

Hey @Yshayy & others,
Yes you can, please see #112 . If you could please review the branch, it would help us a lot. We plan on shipping this feature early Sunday.


[Style tab] Incorrect image log

Use this issue to start collecting places where we notice style tab images to be wrong so we can fix them in the future.

[ ] Checkbox - wrong indeterminate style
https://github.com/carbon-design-system/carbon-website/issues/177

[ ] Toggle - wrong green

[ ] Accordion - chevron pointing wrong way


Hang with constantly increasing memory use when using file finder

I tried out the Oni nightly today on Linux (tar.gz  download):
Version: <IP_ADDRESS>
Date: 4/1/2020, 3:18:01 PM
Commit: 60adf3c7

If I open the repository of the product I work on and try to open a file with Ctrl-p Oni hangs and memory use climbs out of control:

In the screenshot I have typed 'test' but it hung after 'te'. On the right you can see Oni is using 9Gb of RAM.
I can navigate this repo fine in  CLion, Neovim (skim), and VS Code. The repo contains 24289 files (git ls-files | wc -l), which excludes build artefacts that are .gitignored. Including those (fd -IH | wc -l) there are 305643 files.

I've tried reproducing this on Arch with the linux repository, which has 67610 files, but am unable to. A search for "test" there completes in about 2 seconds with negligible impact on memory use.
Could you try running it from the terminal with oni2 -f --trace? That should output the number of files it's working with (along with plenty of other stuff too though). An example from searching the linux repo:
[TRACE]    +0ms Oni2.Core.Job : Detailed report: Name: FilterJob
 - Pending work: - Pending Work
 -- allItems: 67572 -- itemsToFilter: 72
 - Completed work: - Completed Work
 -- filtered: 13832 -- ranked: 250

I have a similar issue when I close Oni from the close button of the window my screens flicker and one CPU is at 100% and RAM usage starts to increase indefinitely. I need to force kill Oni2_editor process.
If I close Oni with :q everything works as expected. I'm on KDE Neon 5.18.
Version: <IP_ADDRESS>
Date: 4/1/2020, 8:33:47 PM
Commit: f2c46d0b

@glennsl Here's the tail of a trace. It hangs after that last "Starting FilterJob" message.
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob
[TRACE]    +2ms Oni2.Core.Job : FilterJob ran 3 iterations for 0.002020s
[TRACE]    +0ms Oni2.Core.Job : Detailed report: Name: FilterJob
 - Pending work: - Pending Work
 -- allItems: 24342 -- itemsToFilter: 16592
 - Completed work: - Completed Work
 -- filtered: 7536 -- ranked: 250

[INFO]     +0ms Oni2.Store.dispatch : (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.349190699203)))
[DEBUG]    +0ms Oni2.Store.dispatch : After: (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.349190699203)))
[TRACE]    +0ms Revery.UI.Render : BEGIN: Render frame
[TRACE]    +4ms Revery.UI.Render : END: Render frame
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob
[TRACE]    +2ms Oni2.Core.Job : FilterJob ran 4 iterations for 0.002475s
[TRACE]    +0ms Oni2.Core.Job : Detailed report: Name: FilterJob
 - Pending work: - Pending Work
 -- allItems: 24342 -- itemsToFilter: 15842
 - Completed work: - Completed Work
 -- filtered: 8286 -- ranked: 250

[INFO]     +0ms Oni2.Store.dispatch : (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.390271957933)))
[DEBUG]    +0ms Oni2.Store.dispatch : After: (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.390271957933)))
[TRACE]    +0ms Revery.UI.Render : BEGIN: Render frame
[TRACE]    +1ms Revery.UI.Render : END: Render frame
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob
[TRACE]    +3ms Oni2.Core.Job : FilterJob ran 4 iterations for 0.002505s
[TRACE]    +0ms Oni2.Core.Job : Detailed report: Name: FilterJob
 - Pending work: - Pending Work
 -- allItems: 24342 -- itemsToFilter: 14842
 - Completed work: - Completed Work
 -- filtered: 9286 -- ranked: 250

[INFO]     +0ms Oni2.Store.dispatch : (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.431353216663)))
[DEBUG]    +0ms Oni2.Store.dispatch : After: (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.431353216663)))
[TRACE]    +0ms Revery.UI.Render : BEGIN: Render frame
[TRACE]    +3ms Revery.UI.Render : END: Render frame
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob

I did some more testing with 0.4 this morning. It seems that memory use doesn't climb forever. It gets to about 14Gb and then stays there. I let it run for a while to see if any more trace messages are written but after a few minutes there were none. strace reports the following in a constant stream:
rt_sigprocmask(SIG_BLOCK, NULL, [], 8)  = 0
rt_sigprocmask(SIG_BLOCK, [VTALRM], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0

Interesting, but I'm not sure yet if that's actually significant.
If you're able to build from source it would be interesting to try #1566, which switches out the filtering library, to see if that changes anything. If not, or if this doesn't help any, we'll have to try to track down the memory leak. @bryphe has some experience with that I think, although I'm not sure if that's on Linux or just on Windows. But as I understand, running valgrind with --leak-check=full is a good option. But you'll have to run it on Oni2_editor directly, as Oni2 is just a launcher. I think this should be straight-forward using the .tar.gz pakage though.

I built the fyz branch and the behaviour is the same, the logs look much the same too:
[INFO]     +0ms Oni2.Store.dispatch : (KeyUp (<opaque>, <opaque>))
[DEBUG]    +0ms Oni2.Store.dispatch : After: (KeyUp (<opaque>, <opaque>))
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob
[TRACE]    +2ms Oni2.Core.Job : FilterJob ran 4 iterations for 0.002438s
[TRACE]    +0ms Oni2.Core.Job : Detailed report: Name: FilterJob
 - Pending work: - Pending Work
 -- allItems: 24339 -- itemsToFilter: 14089
 - Completed work: - Completed Work
 -- filtered: 9740 -- ranked: 250

[INFO]     +0ms Oni2.Store.dispatch : (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.462221126587)))
[DEBUG]    +0ms Oni2.Store.dispatch : After: (QuickmenuUpdateFilterProgress (<opaque>, (InProgress 0.462221126587)))
[DEBUG]    +0ms Oni2.Store.StoreThread : Running effect: Batch:
 input.immediateDispatch

[DEBUG]    +0ms Oni2.Store.StoreThread : Effect complete: Batch:
 input.immediateDispatch

[TRACE]    +0ms Revery.UI.Render : BEGIN: Render frame
[TRACE]    +2ms Revery.UI.Render : END: Render frame
[TRACE]    +0ms Oni2.Core.Job : Starting FilterJob

I also tried running that build under valgrind and it didn't report anything. I then tried ran it under gdb and interrupted when it hung. That didn't reveal much. Maybe I need to build with debug symbols or s something.
(gdb) info thread
  Id   Target Id                                             Frame
* 1    Thread 0x7ffff59919c0 (LWP 3468709) "Oni2_editor"     sweep_slice (work=20321, work@entry=737285) at major_gc.c:561
  2    Thread 0x7fffec64b700 (LWP 3468731) "Oni2_edito:cs0"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  3    Thread 0x7fffebcf5700 (LWP 3468732) "Oni2_ed:disk$0"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  4    Thread 0x7fffeb4f4700 (LWP 3468733) "Oni2_ed:disk$1"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  5    Thread 0x7fffeacf3700 (LWP 3468734) "Oni2_ed:disk$2"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  6    Thread 0x7fffea4f2700 (LWP 3468735) "Oni2_ed:disk$3"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  7    Thread 0x7fffe9cf1700 (LWP 3468736) "Oni2_edito:sh0"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  8    Thread 0x7fffe94f0700 (LWP 3468737) "Oni2_edito:sh1"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  9    Thread 0x7fffe8cef700 (LWP 3468738) "Oni2_edito:sh2"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  10   Thread 0x7fffcbfff700 (LWP 3468739) "Oni2_edito:sh3"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  11   Thread 0x7fffcb7fe700 (LWP 3468740) "Oni2_edito:sh4"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  12   Thread 0x7fffcaffd700 (LWP 3468741) "Oni2_edito:sh5"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  13   Thread 0x7fffca7fc700 (LWP 3468742) "Oni2_edito:sh6"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  14   Thread 0x7fffc9ffb700 (LWP 3468743) "Oni2_edito:sh7"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  15   Thread 0x7fffc97fa700 (LWP 3468744) "Oni2_edito:sh8"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  16   Thread 0x7fffc8ff9700 (LWP 3468745) "Oni2_edito:sh9"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  17   Thread 0x7fffa7fff700 (LWP 3468746) "Oni2_edito:sh10" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  18   Thread 0x7fffa77fe700 (LWP 3468747) "Oni2_edito:sh11" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  19   Thread 0x7fffa6ffd700 (LWP 3468748) "Oni2_edito:sh12" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  20   Thread 0x7fffa67fc700 (LWP 3468749) "Oni2_edito:sh13" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  21   Thread 0x7fffa5ffb700 (LWP 3468750) "Oni2_edito:sh14" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  22   Thread 0x7fffa57fa700 (LWP 3468751) "Oni2_edito:sh15" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  23   Thread 0x7fffa4ff9700 (LWP 3468752) "Oni2_edito:sh16" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  24   Thread 0x7fff87fff700 (LWP 3468753) "Oni2_edito:sh17" 0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  25   Thread 0x7fff877fe700 (LWP 3468754) "Oni2_edi:shlo0"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  26   Thread 0x7fff86ffd700 (LWP 3468755) "Oni2_edi:shlo1"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  27   Thread 0x7fff867fc700 (LWP 3468756) "Oni2_edi:shlo2"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  28   Thread 0x7fff85ffb700 (LWP 3468757) "Oni2_edi:shlo3"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  29   Thread 0x7fff857fa700 (LWP 3468758) "Oni2_edi:shlo4"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  30   Thread 0x7fff84ff9700 (LWP 3468759) "Oni2_edi:shlo5"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  31   Thread 0x7fff67fff700 (LWP 3468760) "Oni2_edi:shlo6"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  32   Thread 0x7fff5ffff700 (LWP 3468761) "Oni2_edi:shlo7"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  36   Thread 0x7fff677fe700 (LWP 3468765) "Oni2_edi:gdrv0"  0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  37   Thread 0x7fff66ffd700 (LWP 3468767) "Oni2_editor"     handle_signal (signum=17) at lwt_unix_stubs.c:736
  38   Thread 0x7fff667fc700 (LWP 3468768) "Oni2_editor"     0x00007ffff6564f0b in select () from /usr/lib/libc.so.6
  39   Thread 0x7fff65ffb700 (LWP 3468769) "Oni2_editor"     0x00007ffff6bbf72c in read () from /usr/lib/libpthread.so.0
  40   Thread 0x7fff657fa700 (LWP 3468771) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  41   Thread 0x7fff64ff9700 (LWP 3468772) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  42   Thread 0x7fff5f7fe700 (LWP 3468773) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  46   Thread 0x7fff5effd700 (LWP 3468784) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  47   Thread 0x7fff5dffb700 (LWP 3468785) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  48   Thread 0x7fff5d7fa700 (LWP 3468786) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  49   Thread 0x7fff5cff9700 (LWP 3468787) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  50   Thread 0x7fff37fff700 (LWP 3468788) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  51   Thread 0x7fff377fe700 (LWP 3468789) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  52   Thread 0x7fff36ffd700 (LWP 3468790) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  53   Thread 0x7fff367fc700 (LWP 3468791) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  54   Thread 0x7fff35ffb700 (LWP 3468792) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  55   Thread 0x7fff357fa700 (LWP 3468793) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  56   Thread 0x7fff34ff9700 (LWP 3468794) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  57   Thread 0x7fff13fff700 (LWP 3468795) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
  58   Thread 0x7fff137fe700 (LWP 3468796) "Oni2_editor"     0x00007ffff6bbbcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
(gdb) bt
#0  sweep_slice (work=20321, work@entry=737285) at major_gc.c:561
#1  0x000055555672edb1 in caml_major_collection_slice (howmuch=howmuch@entry=-1) at major_gc.c:802
#2  0x00005555567302c5 in caml_gc_dispatch () at minor_gc.c:471
#3  0x000055555672caeb in caml_garbage_collection () at signals_nat.c:78
#4  0x00005555567486dc in caml_call_gc ()
#5  0x3eb0000000000000 in  ()
#6  0x3f60624dd2f1a9fc in  ()
#7  0x0000000000000001 in  ()
#8  0x000001cf0ee0001a in  ()
#9  0x00000000c7000d00 in  ()
#10 0x0000000080000000 in  ()
#11 0x00000000422b08b0 in  ()
#12 0x0000000043afc000 in  ()
#13 0x00000000443f8000 in  ()
#14 0x00000000443f8000 in  ()
#15 0x0000000047000000 in  ()
#16 0x000000003f7f0000 in  ()
#17 0x0000000000000000 in  ()
(gdb)

That's unfortunate. valgrind was a bit of a long-shot though, as I think it's only likely to discover leaks in C code, while in OCaml it's probably masked by the GC. There are several memory profilers for OCaml as well, such as spacetime, memprof and there's an upcoming statistical memory profiler that will ship with the next version of the OCaml compiler I believe. But I think these all need Oni to be compiled with a special build of the compiler, and I have no idea how they work or how to interpret the results. I think @bryphe has used spacetime though.

My suspicion is - given the hang + increasing memory - that we might be hitting a bug in the way we manage our read/write threads for the ripgrep process. The code lives here: https://github.com/revery-ui/rench/blob/a976fe51b89b4943e8650f8b9d6ebc49331678b0/src/ChildProcess.re#L65
I'd like to switch to Luv for handling our child processes and reading / writing from them - it actually handles concurrency better than Rench's thread model, and is much more robust. Similar to the change to use luv pipes for the syntax process: https://github.com/onivim/oni2/pull/1621
The 'hang+eat memory' symptom as I've observed is usually because something went wrong in that code, and one of those threads is still spinning (like https://github.com/onivim/oni2/issues/1613). That Rench code is worrisome to me because the type system doesn't really help - we can get exceptions for all the various Unix system calls that we're expected to handle (whereas libuv has them typed and gives error conditions via result) - and if we don't handle it correctly, we can end up stuck spinning in a thread. Not to mention differences in Win32 behavior for some of the APIs...
libuv's implementation of child process is much more robust than what we have in that code - and the benefit is that errors tend to be easier to manage.
I'd like to replace our various hand-rolled process spawning (Ripgrep, NodeProcess, NodeTask) with libuv's child process spawning - that can help rule out that entire class of thread-spinning-hang errors for us.

This hang should be fixed now, with our move to libuv in https://github.com/onivim/oni2/pull/1621 - our previous threading strategy could getting into a hanging state (where it gets stuck spinning) - but I haven't seen it since the move to libuv.
I'll close this, but please let me know if you're still seeing or able to reproduce a hang in file finder.


Ghastwater: new fluid

Dissolving Ghast Tears using high temperature steam produces a fluid which acts a lot like water, most importantly it doesn’t evaporate passively in the nether, but does in steam boilers, and can even be drawn from by archimedes screws.  Watch out for it’s interaction with lava, it seems to take on it’s properties if it comes into contact with it, generating dangerous flows of lava.
How is it made? The Crucible doesn't make fluids

Ghast Cream item?

On Mar 28, 2017, at 7:05 PM, Eli Clemente Gordillo Foster<EMAIL_ADDRESS>wrote:
Dissolving Ghast Tears using high temperature steam produces a fluid which acts a lot like water, most importantly it doesn’t evaporate passively in the nether, but does in steam boilers, and can even be drawn from by archimedes screws.  Watch out for it’s interaction with lava, it seems to take on it’s properties if it comes into contact with it, generating dangerous flows of lava.
How is it made? The Crucible doesn't make fluids
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

What does that mean?

"How is it made?" Was thinking you'd make the item then mix it into water or so.

Whereas I was picturing a tv special on the ghastwater factory, and it ends with the whole place in flame.


Using Bigtable ReadRowsRequest instead of Scan for CloudBigtableIO.

This removes a use of HBase's ProtobufUtils which uses HBase protos under the cover, which requires old versions of protobuf to work.  Removing uses of ProtobufUtils will allow us to upgrade grpc and protobuf versions.

All comments addressed.  PTAL.

LGTM


Exception in discovery with mixed ROS1/ROS2 prefix_path

I am trying to build the ROS1/ROS2 bridge as described here on Ubuntu 20.04 with ROS1 noetic and ROS2 foxy. As part of this process, prefix_path ends up containing a mix of ROS1 and ROS2 install paths. During discovery, colcon (0.8.1) throws an exception:
[0.222s] ERROR:colcon.colcon_core.package_discovery:Exception in package discovery extension 'prefix_path': object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/colcon_core/package_discovery/init.py", line 250, in _discover_packages
descs = extension.discover(
File "/usr/lib/python3/dist-packages/colcon_installed_package_information/package_discovery/prefix_path.py", line 30, in discover
num_packages = len(packages)
TypeError: object of type 'NoneType' has no len()

A bit of debug shows that what's happening is that find_installed_packages() returns None when it hits a ROS1 install path component. discover() should likely handle this case explicitly and not assume that it can call len() on the return value.

have the same bug!