Cross-publish package and release notes to GitHub

Given we know that @bcgov/design-system is the most visible surface we have for the DS, I'd like us to explore how we can boost visibility and discoverability of releases and changelogs on the front page of the repo using GitHub's 'Releases' and 'Packages' features:

It appears that GitHub supports cross-publishing packages from npm to GitHub packages, with a couple of changes to package.json?
It would also be good if we could explore how we can sync changelogs/release notes to GitHub Releases. We don't currently have changelogs available on npm, so we should have a conversation about where the source of truth for this should be.
I don't think this is blocking to 3.0.0 release, but if we have bandwidth to investigate and discuss before release, it seems like a good bit of housekeeping to do sooner rather than later.

Based on this morning's conversation, putting this into deep freeze for the time being. We'll stick to package-level changelog.md files for now, and can potentially revisit in a better-resourced future.

I've added tags with git tag and Releases using GitHub's UI so that our existing npm versions show up in the releases section of the repo homepage:

Each release has its associated changelog details included, with a link to the package on npm:

For now, this process is completely manual. When we npm publish a new version of one of the packages, we will need to git tag using the equivalent commit, push that tag to the repo with git push --tags, and then use GitHub's UI to add a new Release. As our process matures, we can look at automating more of this in the future.
We're still not doing anything with GitHub's Packages feature, which duplicates npm's package repository function.


is.leapYear()?

Yeap, maybe.
Is this check help anyone? What do you think?

Thanks Aras for this great lib.
Here is the leap year calculation taken from K&R's "The C programming language"
// is the given year a leap year?
is.leapYear = function(year) {
return is.number(year) && ((year % 4 == 0 && year % 100 != 0) || year % 400 == 0);
};
// leapYear method does not support 'all' and 'any' interfaces
is.leapYear.api = ['not'];

what about this implementation for getting leap year:
// is the given year a leap year?
is.leapYear = function(year) {
    return is.number(year) && (new Date(year, 1, 29).getMonth() == 1);
};

Which one do you think is better ?

I found this specification about leap years:
In the Gregorian calendar 3 criteria must be taken into account to identify leap years:

The year is evenly divisible by 4;
If the year can be evenly divided by 100, it is NOT a leap year, unless;
The year is also evenly divisible by 400. Then it is a leap year.

Implementation of @hamid6 seems pretty good. Would you like to send a PR about this issue? Changing the 'is.js' file and 'tests' is good enough. I can do the rest.
Thanks.

Testing times, @hamid6 implementation is much faster. I would go for that answer too.

Thanks all, I'll make a PR.
Cheers

Added by @hamid6 on https://github.com/arasatasaygin/is.js/pull/53


Admin - Security SA-11(4) - Manual Code Review

Description
enforce peer review of code
Required for Completion

[x] Enforce code review on GitHub
[ ] Documentation

This has been implemented for the master branch. As we create branches for production environments, this will need to be added to those as well.

A good way to verify this is to go and try to change the "readme" file directly from the web interface.
https://github.com/GCTC-NTGC/TalentCloud/edit/master/README.md

Also implemented for Dev branch


Implemented feat/get_transaction_by_block_and_index & feat/get_block_transaction_count & feat/get_block_with_txs from Danilo because of dependency

Rebased and Implemented feat starknet get_transaction_by_block_and_index and feat starknet get_block_transaction_count, had to add @danilowhk's starknet feat get_block_with_txs because mine depended on his and had not been merged.
Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing
[ ] Other (please describe):

What is the current behavior?
Not implemented

Issue Number: #184 #182
What is the new behavior?
get_block_with_txs returns block with params block id
get_transaction_by_block_and_index returns a Transaction with params block id and index of Transaction in transaction vector
get_block_transaction_count returns the number of transactions in a block with params block id

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

Please add a mainnet invocation of your change here so we can test:
https://github.com/keep-starknet-strange/beerus/blob/main/crates/beerus-cli/README.md#cli-invocation


Buffer size and io_uring ring queue depth performance boost

Hi, I'm hoping to take advantage of io_uring to improve throughput for a networking i/o application. I am running the applications on Ubuntu, kernel version: 5.15.0-60-generic.
A gist with my client and server implementations can be found here.
When running with 128 threads, I am able to saturate the network, maximizing the throughput. However, I would like to maximize the throughput with fewer threads - enabling me to run the application on less beefy machines.
In order to achieve this, I reasoned that increasing the buffer size and/or the entries value in io_uring_queue_init should increase the number of bytes being sent across the network. But this is not the case. The throughput stays the same when varying either the buffer size or the queue depth in the ring (increasing the buffer size and queue depth by 2x until 64k).
I was wondering if there is some issue in client/server io_uring implementation.
Please let me know if you would like the profiling output from perf.

In order to achieve this, I reasoned that increasing the buffer size and/or the entries value in io_uring_queue_init should increase the number of bytes being sent across the network.

I think I spotted a mistake in the recv part:
	#define BUFFER_SIZE 16384

	// create a buffer
	char buffer[BUFFER_SIZE];
	struct iovec iov = {
			.iov_base = buffer,
			.iov_len = sizeof(buffer)};

	// prepare the readv operation
	io_uring_prep_recv(sqe, client_sock, &iov, 1, 0);

No matter how big your BUFFER_SIZE is, it will only read 1 byte from
the socket. recv() is not readv(). The 4-th argument here is the
number of bytes you're willing to read from the socket. Not the number
of iovec arrays.
Your comment indicates that you want to use readv(), but the code
actually uses recv().
Also, note: You don't have to use readv() for reading from the socket,
just use recv(). recv() performs better for socket operation in
io_uring. It's specialized to handle sockets. The same goes for send()
vs writev().

Thanks for the catch 👍

Thanks for the catch +1
EDIT: would it make sense to do the same for the client as well? Something like this:
io_uring_prep_writev(sqe, sock, &iov, BUFFER_SIZE, 0);

versus what I have currently:
io_uring_prep_writev(sqe, sock, &iov, 1, 0);

What you have currently with writev() is ok. But I would suggest using
send(), so it will be like this:
	io_uring_prep_send(sqe, sock, buffer, BUFFER_SIZE, 0);

You can remove your struct iovec that way.

You probably have a bad install with a mix of distro liburing packages and headers and ones you installed from source yourself. Clean that out and stick with one version where the headers and library match.

From a quick glance of your gist, you're also still using and iov with recv. It takes the buffer and length, not an iovec.

At this point, could it be the network that is the bottleneck?

Your information severely lacks detail. It is evident that you failed to adhere to the given advice regarding the usage of send() and recv(). Surprisingly, you continue to utilize writev() despite the guidance provided. Additionally, your expectation remains unclear.
I insist that you promptly present us with concrete numerical data for the purpose of comparison. And also, provide a functional test code that actually works, once you have made the necessary fixes.

Hi, sorry about the lack of details. I have updated the gist.
I am running all experiments with the following defaults: 1 thread, 2048 ring depth.
Running on Chameleon Cloud, I am able see in an increase in throughput when increasing the buffer size:
$ ./src/client2 -t 1 -q 2048 -b 1024
Total requests sent: 9435589
MB Sent: 9214
Throughput in MB/s: 614

$ ./src/client2 -t 1 -q 2048 -b 2048
Total requests sent: 6137781
MB Sent: 11986
Throughput in MB/s: 799

$ ./src/client2 -t 1 -q 2048 -b 4096
Total requests sent: 3456695
MB Sent: 13497
Throughput in MB/s: 899

$ ./src/client2 -t 1 -q 2048 -b 8192
Total requests sent: 1752411
MB Sent: 13678
Throughput in MB/s: 911

$ ./src/client2 -t 1 -q 2048 -b 16384
Total requests sent: 1008269
MB Sent: 15715
Throughput in MB/s: 1047

$ ./src/client2 -t 1 -q 2048 -b 32768
Total requests sent: 490733
MB Sent: 15256
Throughput in MB/s: 1017

$ ./src/client2 -t 1 -q 2048 -b 65536
Total requests sent: 244174
MB Sent: 15174
Throughput in MB/s: 1047

Running the same experiment on AWS, I get:

$ ./src/client2 -t 1 -q 2048 -b 1024
Total requests sent: 17545260
MB Sent: 17127
Throughput in MB/s: 550

$ ./src/client2 -t 1 -q 2048 -b 2048
Total requests sent: 8778865
MB Sent: 17128
Throughput in MB/s: 546

$ ./src/client2 -t 1 -q 2048 -b 4096
Total requests sent: 4389254
MB Sent: 17128
Throughput in MB/s: 555

$ ./src/client2 -t 1 -q 2048 -b 8192
Total requests sent: 2199115
MB Sent: 17128
Throughput in MB/s: 560

$ ./src/client2 -t 1 -q 2048 -b 16384
Total requests sent: 1102643
MB Sent: 17129
Throughput in MB/s: 552

$ ./src/client2 -t 1 -q 2048 -b 32768
Total requests sent: 551337
MB Sent: 17130
Throughput in MB/s: 550

$ ./src/client2 -t 1 -q 2048 -b 65536
Total requests sent: 275687
MB Sent: 17131
Throughput in MB/s: 559

What could be the reason that even baseline throughput is much lower on AWS, and then why does the buffer size not affect throughput in this case.
Using iperf3, here are the bitrates for the network on AWS: ~4.69 Gbps and on Chameleon cloud: ~1.81 Gbps.

Given the iperf numbers, it appears you've roughly saturated the network in the AWS case, using just one thread instead of 128. 571 MB/s = 4.56 Gbps.


Decimal DataType in Athena is not Supported

Athena has a table with datatype decimal (13,4)
Out of the box aws wrangler library is not supporting this.
raise UnsupportedType(f"Unsupported Athena type: {dtype}")
awswrangler.exceptions.UnsupportedType: Unsupported Athena type: decimal

I would add that Redshift is also missing DECIMAL and NUMERIC types.
Trying to use cast_columns with types DECIMAL and NUMERIC fails:
Unsupported Redshift type: DECIMAL

Hi @hhsurap and @danielcarletti!
Happy to say we already have decimal support implemented, will be released in the next release tomorrow.
Thanks!


Improve help feature

As a new user, I want to see usage instructions so that I can refer to instructions easily when I forget how to use the application.
This improvement has been addressed by #31. However, for a better user experience, we will evaluate at the end of milestone v1.2 if it is necessary to enhance this feature.

Closed as user guide will be sufficient


Issues with Terraform Cloud

Hello there! Thanks to the whole YugaByteDB Team for maintaining this repo.
Unfortunately, I cannot quite seem to get everything lined up. I am having trouble SSH'ing into the EC2 boxes once they get created. This leads to timeout issues while trying to provision the files necessary to run the cluster.
Any tips would be appreciated! You can see my entire setup here

Okay, I ended up getting this resolved pretty quickly once I wrote the issue up (rubber ducks ftw).
Turns out, I needed an internet gateway and a route table. For anyone who finds this issue later on, hope that helps!


Update file.blade.php

When no file uploaded for file type, viewing or editing resulted in invalid download link.
json_decode of "[]" returns false, so file.blade.php does not properly interpret the fact that there is no file.

True. Closing


initial version as extracted from the js scaffolder

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@61f8437). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master        #1   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         1
  Lines             ?         7
  Branches          ?         0
==========================================
  Hits              ?         7
  Misses            ?         0
  Partials          ?         0

Impacted Files
Coverage Δ

src/mocha.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f8437...41d8b7a. Read the comment docs.


Weapons / Tools

Create animations for such things client side and sync their logic server side.

I can create some artwork if need be. ;)


aya: import types from std::ffi rather than libc

@alessandrod FYI this now changes API but the types are identical.


Add support for archlinux

Docker now offers archlinux as an official image (https://hub.docker.com/_/archlinux) since last year. I remember having looked around for one not long before and I seem to have missed the news.
Anyway, I think that'd be really good to add it to the CI test array. https://github.com/ocaml-opam/opam-depext/pull/123 fixed the archlinux support and a new release of opam-depext is due soon. Anytime after that would be fine to merge this.

All good and tested now.
Once this is merged there'll only be 4 linux distributions supported by opam-depext / opam 2.1 that would still be missing/un-ci-tested:

oraclelinux: would be easily added as we already have everything for yum-based distributions.
mageia: same thing
amazonlinux (support added in opam 2.1 I believe): I've never tried but I'm guessing it's the same thing as well.
Gentoo: this one is a bit more tricky. There are "official" images (from gentoo's side) but it's not "official docker supported images" (as in, not in the default namespace): https://hub.docker.com/r/gentoo/stage3. There is a tiny bit more setup to do than other distributions (https://github.com/gentoo/gentoo-docker-images#using-the-portage-container-in-a-multi-stage-build) but all in all it wouldn't be too hard if we're willing to add it (I'd be up for it).

Once this is done we'll be able to test every single linux (base) distributions supported by opam-depext / opam 2.1 using a simple docker image (currently under ocurrent/opam).
opam-depext / opam 2.1 also supports:

macOS/Homebrew (test using Travis-CI or Github Actions available)
macOS/MacPorts
FreeBSD (quick test using Travis-CI or the official livecd available)
OpenBSD (quick test using FuguIta's livecd available)
NetBSD? (support removed in opam 2.1?)

cc @rjbou (this might be of interest to you, to know the state of the testable linux distributions with opam-depext / opam 2.1)

Thanks @kit-ty-kate !

opam-depext 1.1.4 is out. This is good to be merged. cc @avsm

thanks!


Remove duplicated view registration

@gurgentil Can you resolve the Psalm error?

@drewroberts the psalm error is happening because we have a computed property called activeStep and the method that computes it is named getActiveStepProperty. I can take a further look at it tomorrow

I want to add back the changes I'm trying to do with that test case branch:
https://github.com/roberts/leads/pull/26


openrct2 - Fix launch issues

New Engine Package Submissions

[ ] Have you followed the instructions in the build documentation?
[ ] Have you run the build locally and ensured the package allowed you to launch and play the Steam game?
[ ] Have you updated the packages.json file?
[ ] Have you ensured that there is not already a pull request or active engine package for the one you are adding?

Common Code Submissions

[ ] Have you verified that the changes are isolated to the features or fixes you are wanting to do?
[ ] Have you tested at least one of the engines to ensure that your changes do not break existing workflow?
[ ] Have you described what your changes are accomplishing?

It's working just fine now. Thanks.


fix #330 patch MyModel.save instead of MyModel().save

Problem
see #330 for more details, shortly:
AttributeError: Can't pickle local object 'FieldTracker.patch_save.<locals>.save'
Solution
Original code stored patched save method in instance.__dict__, breaking django cache system.
PR proposes to patch model class save instead at FieldTracker.contribute_to_class.
Commandments

[x] Write PEP8 compliant code.
[x] Cover it with tests.
[x] Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
[x] Pay attention to backward compatibility, or if it breaks it, explain why.
[x] Update documentation (if relevant).

Lots of unexpected test failures, closing pr for futher investigation


Activate (most) warnings for pickles

Compile pickles with -w +a-40..42-44 -warn-error +a -open Core_kernel.
Depends on #11897
Fix  #12057 (last of 3 PRs) and, as a consequence, #12059

!ci-build-me

!ci-build-me

How to fix send for transaction?

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me


Nuget

Description
Create a developer nuget package containing the files needed to build ebpf programs and applications.
The nuget package has includes from external/* in a different path so this PR also changes includes paths so the paths are not hard coded in other .h files.
Fixes #920
Testing
Tested manually and working on a separate PR in the L3AF project to consume the nuget package.  The demo repo should do likewise.
Documentation
Minimal README.md file only.   This will be updated in a future PR once other improvements are available and integration with L3AF and the Demo repos are done and any feedback from those experiences incorporated.

One suggestion:
Now that #994 is merged, can we include the scripts and binaries necessary to generate native images in the nuget package as well?

One suggestion: Now that #994 is merged, can we include the scripts and binaries necessary to generate native images in the nuget package as well?

It should only require (in addition to files you have already incuded):
bpf2c.exe
Convert-BpfToNative.ps1
tools\bpf2c*

One suggestion: Now that #994 is merged, can we include the scripts and binaries necessary to generate native images in the nuget package as well?

It should only require (in addition to files you have already incuded): bpf2c.exe Convert-BpfToNative.ps1 tools\bpf2c*

bpf2c.exe is already included, but I can include anything else we need in a separate PR, or this one if critical.

Not critical, I can add it in a later PR.

One suggestion: Now that #994 is merged, can we include the scripts and binaries necessary to generate native images in the nuget package as well?

It should only require (in addition to files you have already incuded): bpf2c.exe Convert-BpfToNative.ps1 tools\bpf2c*

bpf2c.exe is already included, but I can include anything else we need in a separate PR, or this one if critical.

Not critical, I can add it in a later PR.

I needed to rebase and resolve conflicts, so I at least added the ps1 script.  You will need to add whatever else in a later PR since I am not quite sure the exact set needed.


Add e2e test

skip-changelog
:scroll: Description

Adds an e2e test to iOS & Android integration tests
Opted to extend the example app after all, but with a section that is only visible when the integration test is run.
That way we don't need to keep two apps up to date and we use the same options

:bulb: Motivation and Context

Relates to #514
:green_heart: How did you test it?
Test
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

if we go down this way, let's migrate https://github.com/getsentry/sentry-dart/blob/main/flutter/example/integration_test/integration_test.dart to this example so we have a single place to test stuff.

Would there be any benefit of running E2E tests with multiple Flutter versions like we have it in RN?

Would there be any benefit of running E2E tests with multiple Flutter versions like we have it in RN?

Yes, but the overhead is quite big (CI time/maintenance), we run in the minimal supported version, the stable and beta version, which is IMO enough.


Sprite stretches when Window size isn't in 1:1 ratio

Describe the bug
The sprite appears stretched when the window's width and height are not in the ratio 1:1.
To Reproduce
Steps to reproduce the behavior:

Go to the file ./ducktape.h.
Edit the WIDTH variable to something that's not the same as HEIGHT variable.
Build and run the program.

Expected behavior
The rendered sprite should appear in the same scale the original file is.
Screenshots

I would like to help here! :)

Tested it, works.

This should be handled independently in a separate method in order to be able to correctly set the Viewport and calculate the new size to preserve the aspect ratio.

Do you mind explaining how one would do this? Perhaps by opening a new issue, thanks! :)


Recipe application

In this project, we built a recipe app that tracks recipes, ingredients, and inventory. It will allow you to save ingredients, keep track of what you have, create recipes, and generate a shopping list based on what you have and what you are missing from a recipe. Also, since sharing recipes is an important part of cooking the app should allow you to make them public so anyone can access them.
The app will have some common interfaces, but depending on your team size it will have a couple of extra ones. These are some of the interfaces and some wireframes for some of them:
A login page.
A registration page.
A food list.
A recipe list.
A general shopping list view (all missing food for all your recipes and total price).
A list of all public recipes from other users with their names and total prices.
we tested the app using the Rspec gem and capybara gem and here is a screenshot of the resultant pass tests.

and here are some screenshots of the site itself

@banzaman  could you check your slack?

thank you for your time @Reem-lab


Add min length and did select action on selection changed

This pull request adds two features:

adds minimium length as in this pull request, but moreover provides tests for this feature
adds sending action didSelect on selection changing and provides tests for this feature

I bumped into case when didSelect was useful to take care of auto-save after selection change in model relationships. Using value observer I got it executed twice and due to fact that the reletionships are not changing model.isDirty flag I couldn't find a clean solution. didSelect provides that one.

Looks good, thanks! I'll add this to the change log and check eventual edge cases manually (if any occur to me) before the next release, but thank you very much for this addition.


New keys aren’t persisted anymore for (yet) unknown reason

FreeOTP Version 1.5 (17) installed from F-Droid on a CyanogenMod 13.0-20160820.
I had 7 keys I added flashing code from various 2-factors auth services, working fine since a year or so.
Then, I wanted to add a new one. It did work: flashed the QR code, generated a first code, no error... I eventually closed FreeOTP app and went back to other activities.
The day after, I wanted to log again in that service. I launched FreeOTP. The 7 previously added keys were there, but the new one was just missing.
I tried to add new keys again with two other services, and it failed the exact same way: close the app and new keys are lost.
Might it be related to the fact I somehow recently changed my smartphone for a newer one? I had made a back up of the tokens.xml file and copied it onto my new device. It had worked fine until I tried to add a new key.
I’ve checked out access rights but everything looks fine, AFAIK. The datetime of last modification never changed, though.
What do you think @npmccallum? How can I help debugging?

I think this is a duplicate of #77

@bachp You’re right. Thus, I better close this duplicate issue.


matrix-synapse: 1.21.2 -> 1.22.0

Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.22.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 101853 1

1 package built:

matrix-synapse

Result of nixpkgs-review pr 101853 1

1 package built:

matrix-synapse

@mweinelt do you also take care of the backport? %)

Feel free to do it, I'm busy with #101968 right now.

20.03: e39c1f4ef17d36ce04fb75bd36f2e62b44ce0028, 504f993df9a5ca63317fe9c859df19daad30aa14
20.09: bf8631151e80717aa323d2b6e0ae36da175d8d25, 86777b5e659a13193312582e180093a9952eff0c


SONOS players unavailable when S1 and S2 speakers are connected to the network

What version of Music Assistant has the issue?
2.0.0b27
The problem
When SONOS speakers from the S1 and S2 app are connected at the samen time, the S2 speakers are unavaible through Music Asisstant
How to reproduce
Connect S1 and S2 speaker to your network
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2023.4.0
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Sorry the MA version you have indicated above is not valid. Please recheck and amend

Sorry the MA version you have indicated above is not valid. Please recheck and amend

Sorry, edited the original post.

You wrote

When SONOS speakers from the S1 and S2 app are connected

I don’t use SONOS but looking online it appears that S1 and S2 are different apps and only certain speakers work with those apps. If that is correct then I think you need to specify the speaker models that aren’t working instead of referring to the apps (as they won’t have anything to do with MA)

So is there a confirmed issue here?

Is there anything related in the logs ? What happens when you start playback ?
Does the app show anything ?

Been away for a while but i'm back for testing the beta with the Sonos v1 and v2 devices. It looks like the v2 devices are working good in my setup, but as soon as a v1 device connects to the network and got discovered in MA all the Sonos devices are greyed out in the speaker list.
Restarting the MA add-on works for a while. But the device with the V1 firmware is gone in the speaker list. It is still shown in settings but with the loading icon next to it. Log doesn't show anything about the speaker.

The log is complaining about a transition. Could it be that V1 speakers do not support crossfade and you have crossfade enabled ?

Try turning it off and see if those errors go away?

Any updates on this with b35?

Ok closing then. Please raise another issue if problems present in the future.


Can't call ((_: string) => T) | undefined when conditionally string extends T

Bug Report
I am trying to make a generic callback function (_: string) => T, that is allowed to be optional (undefined) only when T is string. (Specifically, I chose string extends T because TS doesn't seem to provide exact equality for conditional types, and I want the default value to be (x: string) => x.)
The initial way I wrote this was string extends T ? ((value: string) => T) | undefined : (value: string) => T, but I found I was unable to (conditionally) call the function. The error seems to stem from TS treating the type as (value: T & string) => T, which prevent me from passing in a string literal.

I found a workaround that allows me to call the function: ((value: string) => T) | (string extends T ? undefined : never) (which I believe should be exactly equivalent, though let me know if this is wrong). However, this too is broken in the latest nightly, seemingly because of how NonNullable is being distributed over |:

🔎 Search Terms
generic extends function parameter union 🤷
🕗 Version & Regression Information

This changed between versions 3.8.3 and 3.9.7, and changed again between 4.2.2 and the nightly.

⏯ Playground Link
Playground link with relevant code
💻 Code

type Transform1<T> = ((value: string) => T) | (string extends T ? undefined : never);
type Transform2<T> = string extends T ? ((value: string) => T) | undefined : (value: string) => T;

function test<T>(f1: Transform1<T>, f2: Transform2<T>) {
  f1?.("hello");  // error in nightly, no error in 4.2.2
  f2?.("hello");  // error since 3.9.7, no error in 3.8.3
}

🙁 Actual behavior
Error on the call to f1 in 4.2.2, and errors on both calls in the nightly.
🙂 Expected behavior
Both calls should succeed. The function return value is ignored, so string extends T should have no impact on the validity of the expression.

Unfortunately even with the workaround, the return type of my default function can't be treated as compatible with T.

I went ahead and ran a git bisect — this broke in 15fae38b39a370f1f597606e552dd40998a1ac49 / #43183.

This is indeed a regression caused by #43183. However, it was sort of halfway broken before because getNonNullableType doesn't properly eliminate higher-order types that are constrained to just 'undefined' or 'null'. For example:
function f1<T>(x: T | (string extends T ? undefined : never)) {
    let z = x!;  // NonNullable<T> | NonNullable<string extends T ? undefined : never>
}

function f2<T, U extends null | undefined>(x: T | U) {
    let z = x!;  // NonNullable<T> | NonNullable<U>
}

In both cases above, the type of z should just be NonNullable<T> because the other type is known to always be nullable.
Both the regression and the above issue can be solved by being a bit smarter in getNonNullableType.


python-http to 0.0.18

Promote python-http to version 0.0.18

:star: PR built and available in a preview environment francesco-beccaria-python-http-pr-12 here


No data to display when [rowHeight]="'auto'" and [scrollbarV]="true"

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
With [rowHeight]="'auto'"  [scrollbarV]="true",
the table displays "No data to display"
Expected behavior
It should display the table with the data with fluid row height and vertical scroll.
Reproduction of the problem
Reproducible 100% of the times.
Please tell us about your environment:
Mac, Atom, Angular 5

Table version: 0.8.x
11.1.7

Angular version: 2.0.x
5.2.3

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome

Language: [all | TypeScript X.X | ES6/7 | ES5]
Typescript 2.4.2

From my experience, you can't use [rowHeight]="'auto'" when you have [scrollbarV]="true", you should give some number for rowheight.

Even a number is breaking it for me.

based on here https://github.com/swimlane/ngx-datatable/issues/1292 .
i used overflow-y:visible for the rowDetail and its now working

hi bleuscyther
overflow-y:visible is ok but my case,
[rowHeight]="'auto'"
i am using every row inside column contains more means word-wrap.
[scrollbarV]="true"
i am using header fixed and pagination show in top so overflow-y:visible is not required,
below is my ngx-datatable example, Dear bleuscyther can you tell me in this case how to use [rowHeight]="'auto'" [scrollbarV]="true"
<ngx-datatable  class="material striped" style="height: 340px; "
[rows]="myData" [columnMode]="'force'" [headerHeight]="50"  [scrollbarH]="true" [footerHeight]="50"
[rowHeight]="40" [scrollbarV]="true" [sorts]="[{prop: 'name', dir: 'desc'}]">

hi bleuscyther overflow-y:visible is ok but my case, [rowHeight]="'auto'" i am using every row inside column contains more means word-wrap.
[scrollbarV]="true" i am using header fixed and pagination show in top so overflow-y:visible is not required, below is my ngx-datatable example, Dear bleuscyther can you tell me in this case how to use [rowHeight]="'auto'" [scrollbarV]="true"
<ngx-datatable class="material striped" style="height: 340px; " [rows]="myData" [columnMode]="'force'" [headerHeight]="50" [scrollbarH]="true" [footerHeight]="50" [rowHeight]="40" [scrollbarV]="true" [sorts]="[{prop: 'name', dir: 'desc'}]">

This worked for me. Thank You.

Any update or work around to this issue?
combination of rowHeight auto and scrollbarV true still does not work when we have row detail. I do not need virtual scroll capability, if that is causing the issue, can we disable it and have the scroll?


Issue

Challenge Uncomment HTML has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

Thank you for reporting your issue.
Your code is wrong.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "Help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification.
Thank you, and happy coding.


keyutils: 1.5.10 -> 1.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/keyutils/versions.
meta.description for keyutils is: '"Tools used to control the Linux kernel key management system"'.

Checks done (click to expand)

built on NixOS
/nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6/bin/keyctl passed the binary check.
/nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6/bin/key.dns_resolver passed the binary check.
/nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6/bin/request-key passed the binary check.
3 of 3 passed binary check by having a zero exit code.
0 of 3 passed binary check by having the new version present in output.
found 1.6 with grep in /nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6
directory tree listing: https://gist.github.com/59b78f0dda8ed65dea9f5ba8ddc942ee
du listing: https://gist.github.com/c41a0c40ea7c0b2ee223102593bdfc05

Rebuild report (click to expand)

28595 total rebuild path(s)
13963 package rebuild(s)
8628 x86_64-linux rebuild(s)
7548 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
12417 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
AgdaSheaves
AgdaStdlib
DisnixWebService
EBTKS
EmptyEpsilon
LASzip
Literate
MMA
NSPlist
PlistCpp
QuadProgpp
R
SDL
SDL2
SDL2_gfx
SDL2_image
SDL2_mixer
SDL2_net
SDL2_ttf
SDL_gfx
SDL_image
SDL_mixer
SDL_net
SDL_sound
SDL_stretch
SDL_ttf
SkypeExport
TotalParserCombinators
_20kly
_389-ds-base
_90secondportraits
a2jmidid
aacskeys
abc-verifier
abcde
abcl
abcm2ps
abiword
abootimg
acbuild
accountsservice
acgtk
acme-sh
acoustidFingerprinter
acsccid
adapta-gtk-theme
adobe-reader
adom
adoptopenjdk-bin
adoptopenjdk-hotspot-bin-11

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A keyutils https://github.com/r-ryantm/nixpkgs/archive/9c258ce2d3a9aed6fe732ad369d0a4fb2ea83ca8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6
ls -la /nix/store/6r46hyg6axirlmwskw84x9jkshm88nr2-keyutils-1.6/bin

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: keyutils
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: keyutils
Partial log (click to expand)
strip is /nix/store/1jprj383qnzd50vn8qq3a0id6a08a9fi-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/321y9f9blxakg17sfncpan064kv7nxvf-keyutils-1.6-lib/lib
patching script interpreter paths in /nix/store/321y9f9blxakg17sfncpan064kv7nxvf-keyutils-1.6-lib
checking for references to /build/ in /nix/store/321y9f9blxakg17sfncpan064kv7nxvf-keyutils-1.6-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/77yzf27xz1canlk5dw5qd4aal8hp9q4i-keyutils-1.6-dev
strip is /nix/store/1jprj383qnzd50vn8qq3a0id6a08a9fi-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/77yzf27xz1canlk5dw5qd4aal8hp9q4i-keyutils-1.6-dev/lib
patching script interpreter paths in /nix/store/77yzf27xz1canlk5dw5qd4aal8hp9q4i-keyutils-1.6-dev
checking for references to /build/ in /nix/store/77yzf27xz1canlk5dw5qd4aal8hp9q4i-keyutils-1.6-dev...
/nix/store/p00sqa202hcqa3whi7sgpnbq7yzspdfw-keyutils-1.6

Success on x86_64-linux (full log)
Attempted: keyutils
Partial log (click to expand)
strip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c6qhj3zs50zxsbvbcswiqh4xa953mq77-keyutils-1.6-lib/lib
patching script interpreter paths in /nix/store/c6qhj3zs50zxsbvbcswiqh4xa953mq77-keyutils-1.6-lib
checking for references to /build/ in /nix/store/c6qhj3zs50zxsbvbcswiqh4xa953mq77-keyutils-1.6-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/f97dgphbfjg0m429hxsbv94w0ny8kwfm-keyutils-1.6-dev
strip is /nix/store/j13c9z0z495wxdc97if8z451x53m1j25-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f97dgphbfjg0m429hxsbv94w0ny8kwfm-keyutils-1.6-dev/lib
patching script interpreter paths in /nix/store/f97dgphbfjg0m429hxsbv94w0ny8kwfm-keyutils-1.6-dev
checking for references to /build/ in /nix/store/f97dgphbfjg0m429hxsbv94w0ny8kwfm-keyutils-1.6-dev...
/nix/store/3lijil6bkpb8n16274yh33nglfadgr7z-keyutils-1.6


Needs E-TAG header. May serve incorrect content on server restart

Just manual testing updating the config with SIGUSR1 and it looked like it was even working. However, I found that it's actually sending 304 Not Modified for content that has been modified.
The issue is that it sends last-modified headers with the date of the file, but if the file is swapped out with an earlier file, it sees the if-modified-since header and can't tell that the file has been modified.
Instead it should send an etag which could be as simple as a sha1sum of the file attributes (created at, modified at, size, inode, permissions) or actually performing a sha1 on the file.
To reduce overhead, the sha1 could be stored in memory or a temporary file - if you want to check full contents rather than just attributes that is.

#191 is about ETag. (What does this have to do with server restart though?)

Ooops, shoulda done my homework.
It has to do with restart / SIGUSR1 because if you change the config file such that it points to a different directory, you can't tell that the config file successfully reloaded. It looks like it's reading the old config... until you examine the headers.

if you change the config file such that it points to a different directory, you can't tell that the config file successfully reloaded

Can you elaborate on this?

It looks like it's reading the old config... until you examine the headers.

Config != web page. I'm still confused.

The device starts up in a locked state, so any request to any "app" on the device is pointing to the same directory
https://coolaj86.com {
    root /srv/walnut/init.public
    proxy /api http://localhost:4080
    # ... more stuff
}

https://brysonchill.com {
    root /srv/walnut/init.public
    proxy /api http://localhost:4080
    # ... more stuff
}

Once the API gets the master passphrase from the device owner the device unlocks and the config is changed
https://coolaj86.com {
    root /srv/walnut/sites-enabled/coolaj86.com
    proxy /api http://localhost:4080
    # ... more stuff
}

https://brysonchill.com {
    root /srv/walnut/sites-enabled/brysonchill.com
    proxy /api http://localhost:4080
    # ... more stuff
}

The lock screen then issues a refresh of the page.... and it's still at the lock screen... WHAT!?
Oh, it's because the html files for the lock screen I just updated (because that's the app I'm working on) and the coolaj86.com app is "older".
So I restart the server with a new config file, and the web page I'm looking at is a completely different web page.


[Feature] S3: provide a way to allow bulk upload of files

Summary
I am using a file picker widget to upload image and store on S3
i have written a query on s3 to upload 1 image for now
how do I configure the query to upload multiple images, for now I have set the filepicker widget to a max of 5 images

@Nikhil-Nandagopal , Do we need any changes in the file picker widget for this?

Duplicate #3338

@SatishGandham These two issues are slightly different - issue 3338 talks about uploading a folder hence the Filepicker would have to allow for adding a folder instead of files and the s3 plugin would have to create a separate folder in the designated path as well. However, for this issue, a folder is not a requirement, files are individually added and when uploading to s3 they need to be present as such at the designated path and not inside a folder.


Latest docker-compose not compatible with preprod

Just checking...

[X] This is a cardano-wallet bug.
[X] I am using the latest cardano-wallet release.
[X] I am using the correct cardano-node version for that release of cardano-wallet.

Version
v2022-08-16 (git revision:<PHONE_NUMBER>000000000000000000000000000000)
Platform
linux (as defined by the dockerfile)
Installation method
IOHK Docker image
Network configuration
preprod
Context
The latest docker-compose shows compatibility with NETWORK=preprod
For example, based on the way it is written, it indicates that it will pass the correct NetworkMagic (1) and that a proper config file exists at /config/preprod/genesis-byron.json
However, not only does the config file not exist at that location, but the docker image does not recognize the value preprod as a valid value for NETWORK. Indeed, the existing docker-compose for inputoutput/cardano-wallet:2022.8.16 appears to be broken.
Description
Steps to Reproduce

NETWORK=preprod docker-compose up

...
Expected behavior

Cardano-Wallet should connect to cardano-node running the preprod configuration.
Actual behavior

If the preprod parameter is passed to NETWORK the image complains the value is not valid. If testnet is passed instead, and the configuration file is manually injected via mounting, the wrong networkmagic value will be used.

inputoutput/cardano-wallet:2022.8.16 on dockerhub has been updated with the version containing new environments (preview and preprod). Perhaps you already had previous version (also tagged 2022.8.16 but without new environments) on your system and therefore it is using the old one that doesn't have those missing configs?
In that case, in that case you may want to remove old inputoutput/cardano-wallet:2022.8.16 from your system and start docker-compose again, then new version will be downloaded. Sorry for inconvenience!

That solved this particular problem.
With respect, it is unusual to release a new image with the same tag as an old image. Most CI flows assume an image is immutable once tagged. Approaching updating your images in this way is going to cause a lot of headache for a lot of people.

sorry to bother you guys, but I ran into similar issue and I use --preprod /configs/preprod-byron-genesis.jsoncommand ininputoutput/cardano-wallet:2022.8.16docker image, but the log says: "Invalid option--preprod'"

I believe what you want to use is --testnet /configs/preprod-byron-genesis.json.


Long Out of date

I have been playing with power automate for 2 years or so. It has never worked like this in my experience. That means the info on this page (and maybe many others) is at least 2 years out of date.
The "When a new response is submitted" trigger no longer returns a "list of responses" as indicated on this page. It now returns only an individual "response Id". Because of this change, the "Get response details" action does not get wrapped in an "apply to each" as shown here.
There are lots of these github docs that have errors. Can these be edited by the community?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 73f70d16-039c-30c0-de81-63b4e214eacd
Version Independent ID: 8675cf51-aa57-33f1-0042-e2f6ec913add
Content: Common ways to use Microsoft Forms in Power Automate - Power Automate
Content Source: articles/forms/popular-scenarios.md
Service: power-automate
Sub-service: cloud-flow
GitHub Login: @Dean-Haas
Microsoft Alias: napienko

@MSUMOLL - Thanks for your feedback. We will soon look into this issue.

Harysh referred me to CAR team (Kartik). Dialog started.


It thinks tables are not part of the document, but instead a completely new document

See title. When I go to the first cell of a table, it aligns it all the way at the top, even though I have the displacement normally set to 60

Thanks for the issue. I am closing this one in favor of #61.


CNV-47229: Move the config of registry together in the add volume modal

📝 Description
Moving the registry config to be under source details sub title and below the registry URL input instead of under the destination sub-title below the namespace input.
🎥 Demo
Before:

After:

/lgtm


Add missing legends for fieldsets

This pull requests adds a <legend> element as the first element inside any <fieldset> elements which were missing them.
Where the content of the <legend> duplicates a heading which already exists on the page, it is visually hidden.
This ensures the GOV.UK elements examples follow our guidance on fieldsets

Use fieldsets to group related form controls. The first element inside a fieldset must be a legend
element which describes the group.

--
From Léonie Watson:
The fieldset/legend elements are important. The legend provides a group label that's programmatically associated with the fields contained within the fieldset. When focus reaches the first field inside the fieldset (whether by tabbing or using other screen reader shortcuts), the legend is automatically announced before the label of the field.

An h1 (or any other unassociated text) on the page isn't sufficient because there is no programmatic association between it and the form fields.

Hiding the legend offscreen is a perfectly acceptable way to handle the visual duplication problem though. Don't use display:none; to do this though because it'll hide it from screen readers too.
--
The form example page is also removed, as this is to be replaced with a "one thing per page" set of form examples.
cc. @aduggin, @tombye

Looks great to me. Is it worth @aduggin taking a look too?

This looks good. I have just become aware of a bug in VoiceOver on iOS where legends are not read out.  When we have a single question and the heading duplicates the legend this will not be an issue - but when there is not a heading duplicating the legend (due to there be multiple questions on a page) we do have an issue.  Not sure what to recommend  in this instance - have set up a test page to do some investigation: https://govuk-accessibility.herokuapp.com/tests/radio-button-group

:+1:

Another reason for 1-thing-per-page.
Would be good to record which decisions are due to bugs and dodgy support and which are just good usability.
Sent from my iPhone

On 22 Oct 2015, at 09:20, Alistair Duggin<EMAIL_ADDRESS>wrote:
This looks good. I have just become aware of a bug in VoiceOver on iOS where legends are not read out. When we have a single question and the heading duplicates the legend this will not be an issue - but when there is not a heading duplicating the legend (due to there be multiple questions on a page) we do have an issue. Not sure what to recommend in this instance - have set up a test page to do some investigation: https://govuk-accessibility.herokuapp.com/tests/radio-button-group
—
Reply to this email directly or view it on GitHub.


I was very happy to find your mod...

Until I read the description where it says you bound the tab button. The F-ing TAB. BUTTON???
1 - Brawler, 2 - Rush, 3 - Beast, Dragon Of Dojima - TAB???

not my problem.


Provide IOpenApiSchema interface

I am a supporter of MicroElements.Swashbuckle.FluentValidation project and I want to support NJsonSchema (NSwag).
Issue: https://github.com/micro-elements/MicroElements.Swashbuckle.FluentValidation/issues/63
One of the possible solutions is to adapt NJsonSchema to OpenApiSchema but it is a concrete type.
Can we extract IOpenApiSchema interface?

We will probably have to make some changes to the OpenApiSchema model as we implement OpenAPI 3.1 support and support for JSON Schema 2020-12 draft.  We can consider an interface then.
Wouldn't it just be easier to create a factory that creates an OpenAPISchema from an NJsonSchema parameter?

We will probably have to make some changes to the OpenApiSchema model as we implement OpenAPI 3.1 support and support for JSON Schema 2020-12 draft.  We can consider an interface then.
Wouldn't it just be easier to create a factory that creates an OpenAPISchema from an NJsonSchema parameter?

Wouldn't it just be easier to create a factory that creates an OpenAPISchema from an NJsonSchema parameter?

Yes it is another option. This case I need convert NJsonSchema -> OpenAPISchema and back.
At this moment I think more easy is to create some schema adapter with functionality I need. But I don't want to create Yet Another Interface That Common to other existing :)
Third option is to support two branches for OpenApi and NJsonSchema separately.

Wouldn't it just be easier to create a factory that creates an OpenAPISchema from an NJsonSchema parameter?

Yes it is another option. This case I need convert NJsonSchema -> OpenAPISchema and back.
At this moment I think more easy is to create some schema adapter with functionality I need. But I don't want to create Yet Another Interface That Common to other existing :)
Third option is to support two branches for OpenApi and NJsonSchema separately.


Disambiguate blueprints by hash instead of name

This was one thing that tripped me up, while making a custom blueprint, initially the tests weren't properly working, I soon discovered this was because of the fact that blueprints are disambiguated by name.
It's a bit of a foot gun in my opinion, so I'm proposing that the implementation instead hashes these blueprint contents, and then generates them via their hashes, so that any duplicate deployment is deduplicated by their eventual instructions and contents, instead of the name.
I'm using "hash" loosely here, but "an identifier depending on the contents" would work as well.

I had a look at the way complement constructs blueprints, and there may be a side-effect due to the absence of this; If a blueprint is edited, the changes will not immediately propagate, due to the fact it caches on the name, not the contents of the blueprint.
In other words, if someone alters a blueprint while testing, they will get bugs due to complement still using the old image, only a docker system prune will remove that named image from the cache.


[Request] Thumbnail during inactivity

If the feed is unreachable, could we have a thumnail? I'm not confident enough in my async to write a PR, but this would be a great addition that could be pretty simple to do, given your current procedure.
  - platform: ffmpeg
    name: Living Room
    input: -i rtmp://<IP_ADDRESS>/live/livingroom -q:v 5
    thumbnail: /path/to/thumbnail.jpg

Yeah I can do that


Add new features

The library currently has:

crawl_time
is_finished
item_counts
spider_arguments
is_complete
error_rate (but using File vs FileError)

As per https://kingfisher-collect.readthedocs.io/en/latest/logs.html, https://github.com/open-contracting/kingfisher-collect/issues/531, https://github.com/open-contracting/kingfisher-collect/issues/1058 and https://github.com/open-contracting/kingfisher-collect/issues/1055 I think we need to add:

drop_rate: item_dropped_count vs item_scraped_count
duplicate_request_rate: dupefilter/filtered vs downloader/request_count https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-number-of-duplicate-requests
invalid_json_rate: invalid_json_count vs item_scraped_count
finish_reason: cancelled, finished, etc as documented https://kingfisher-collect.readthedocs.io/en/latest/logs.html#check-the-reason-for-closing-the-spider
errors_count: https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-numbers-of-error-messages
errors_list: https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-numbers-of-error-messages
response_status_counts: https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-numbers-of-error-response-status-codes
exception_count: https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-numbers-of-downloader-exceptions
retry_times_reached: https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-number-of-requests-for-which-the-maximum-number-of-retries-was-reached

@jpmckinney any others? Do you agree with implementing all of them?

(1) ok
(2) I've edited the issue, but from https://kingfisher-collect.readthedocs.io/en/latest/logs.html#read-the-number-of-duplicate-requests
(4) Ok
(3) and (5-6) I'm not sure whether we can do anything automatically with this information. But, it would be useful to collect and report the messages and counts.
We should use this information to report the issues with the partners. If we use FileError for everything we would need a way to differentiate invalid JSON errors from failed requests, etc, so that we can report the issue properly to the partner.
(7)(8)(9) ok

Aha - (2) is maybe more a programming error, whereas (1) is a publisher error. It can be reported for information.
Okay, let's not change (3) to a FileError (as-is, it still gets logged in the crawl log for regular Kingfisher Collect users), but in terms of calculating error_rate, we should include invalid JSON.

Hmm for drop items, looking at Kingfisher Collect, I see we drop items in 3 different scenarios;

Sample (not relevant)
Duplicates (not a reason for rejecting a collection for the registry but good for reporting to the partner)
Invalid JSONs (good reason for rejecting a collection and already included in errors_rate)

So, the drop_rate won't be used for rejecting a collection, and the rate only, mixing duplicates and invalid JSONs, is not useful for reporting.
Should we just remove drop_rate and check item_dropped_count and invalid_json_count individually as needed in https://github.com/open-contracting/kingfisher-collect/issues/531 instead?

Yes, makes sense


Couple of errors while training

Hi,
I am seeing a crash sometimes while using thundersvm with matlab, the stack trace is as follows.
Stack Trace (from fault):
[  0] 0x00007f500d700428                    /lib/x86_64-linux-gnu/libc.so.6+00218152 gsignal+00000056
[  1] 0x00007f500d70202a                    /lib/x86_64-linux-gnu/libc.so.6+00225322 abort+00000362
[  2] 0x00007f4c0e7baac1 /home/aditya/thundersvm/build/lib/libthundersvm.so+00277185 _ZN2el4base6Writer15triggerDispatchEv+00001265
[  3] 0x00007f4c0e7ba571 /home/aditya/thundersvm/build/lib/libthundersvm.so+00275825 _ZN2el4base6Writer15processDispatchEv+00000641
[  4] 0x00007f4c0e7c44a2 /home/aditya/thundersvm/build/lib/libthundersvm.so+00316578
[  5] 0x00007f4ff7f75ab3 /home/aditya/Matlab/bin/glnxa64/../../sys/os/glnxa64/libiomp5.so+00658099 __kmp_invoke_microtask+00000147
[  6] 0x00007f4ff7f4a9d7 /home/aditya/Matlab/bin/glnxa64/../../sys/os/glnxa64/libiomp5.so+00481751
[  7] 0x00007f4ff7f4a0da /home/aditya/Matlab/bin/glnxa64/../../sys/os/glnxa64/libiomp5.so+00479450
[  8] 0x00007f4ff7f75dad /home/aditya/Matlab/bin/glnxa64/../../sys/os/glnxa64/libiomp5.so+00658861
[  9] 0x00007f500da9c6ba              /lib/x86_64-linux-gnu/libpthread.so.0+00030394
[ 10] 0x00007f500d7d241d                    /lib/x86_64-linux-gnu/libc.so.6+01078301 clone+00000109
[ 11] 0x0000000000000000                                   +00000000
Randomly, I observe that sometimes model file gets corrupted and I see 2 float values before the support vector instead of one
example:
SV
0.001 0.001 1:0.0069778599 2:0.0189685 3:0.035114001 4:0.0102248
Please let me know if you have seen these issues before.
Thanks for your time.
Regards,
Aditya

Thanks for your feedback! We haven't seen these issues before. Would you please share the training data set, the hyper-parameters, etc., such that we can reproduce the problem and fix it.

Both the issues happen randomly, but I think I am able to reproduce the first issue consistently with the attached training data and the command,
svm_train_matlab({'-c', num2str(0.01), '-t', num2str(0), 'feat.train', 'model'});
feat.train.zip

@aditya-jonnalagadda We found a bug on dataset loading and fixed it. You can update the codes and try again. If the issue still happens, please let us know. Thanks!

Hi,  It fixes the original issue, but breaks something else. Matlab crashes but nothing is present in the dump file. Attached the new feature file and below is the cross validation command used (I think it crashes for any c value, tried 2-3 values)
svm_train_matlab({'-v', '5', '-c', num2str(0.01), '-t', num2str(0), 'feat.train'});
feature file is too big to upload here, here is the google drive link

@aditya-jonnalagadda  Sorry, we did not handle the boundary well when reading the dataset. We just fixed it. Now both datasets can work on our machines. You can try again. If the issue still happens, please let us know. Thanks!


Charm sometimes gets into an error state when trying to check whether the pgBackRest TLS server is running in the primary

Steps to reproduce

Run the backup-integration tox environment.

Expected behavior
The charm mustn't get into an error state.
Actual behavior
The charm sometimes gets into an error state when trying to check whether the pgBackRest TLS server is running in the primary.
Versions
Operating system: Ubuntu 22.04.2
Juju CLI: 2.9.42
Juju agent: 2.9.42
Charm revision: not published revision
LXD: 5.14-7072c7b
Log output
https://github.com/canonical/postgresql-operator/actions/runs/5176724056/jobs/9326224369#step:6:193
Additional context
It happens only sometimes.

@marceloneppel should this be addressed in a87c52b03c91f824a439a9d11e276c667e4596eb ?

@marceloneppel should this be addressed in a87c52b ?

I think it was. I checked all the CI runs on the main after those changes were merged, and none of them raised this issue.


fix: improve OS release pattern matching for Alpine

The current pattern matching for Alpine matches any value. The proposed fix matches Alpine specifically for the asdf and pipx features. Formatted out extraneous whitespace from updated files.
Resolves #281

Thanks! cant believe Ihv missed that...


Include license bodies, license summary (xml) and third-party info

All shaded JARs now include:
/licenses.xml    - summary that lists the licenses of all dependencies used by the artefact
/licenses/*      - license body (txt/html)
/THIRD-PARTY.txt - identifies the license associated with each third party dependency

@lulf  I'll be raising a separate PR for the equivalent change to the agent module (which will use https://www.npmjs.com/package/license-reporter), however, I need to refactor agent first to avoid the use of bower.
One thing I wish to point out with this change:  The  text of the http://creativecommons.org/publicdomain/zero/1.0/ license is not downloadable by the plugin.  I guess the site is blocking the user agent.  This affects org.reactivestreams dependency and means its license text won't appear in the licenses directory.  The license will be referenced in the THIRDPRTY party file and appear in the license.xml.  I think we can live with this wrinkle.


 Is there a better way of doing this that you can think of?

I think I'd rather just pass the function in:
fromNonEmpty :: (a -> f a -> f a) -> NonEmpty f a -> f a

I thought about that, but providing the fold doesn't help too much as NonEmpty's constructor is already exported.

Although... maybe. I guess fromNonEmpty cons nel is slightly than having to do the pattern match, etc.

How about this then? One for the lazy, and one for when you want to do it properly? :wink:

Why not use Alternative and call it oneOf?

Uh, because I foolishly forgot Applicative was a superclass of Alternative. I'm not sure oneOf is quite right though, as you're getting at least one back.

Well it depends how you interpret f I guess. If you pick f as List, do you think f a represents zero or more values a or one value a in a model with multiple worlds? With Parser this view is more obvious - we think of Parser a as one a in a model supporting an ambient text buffer, but we could also think of it as a collection of as indexed by input documents :)

I did see what you were getting at, I just wonder about that naming in the context of NonEmpty?

someOf? I dunno ... :)

Actually, I guess all you need is Alt.

How would that work? You need to put a in f, so need pure:
??? (NonEmpty a fa) = pure a <|> fa

Ah right, I thought Applicative <= Alt, but it's not.

There we go.

:+1: Thanks!


Add build status for develop branch

:white_check_mark: Build psmsi 3.2.13+gc1b2f8fa73 completed (commit https://github.com/heaths/psmsi/commit/c1b2f8fa73 by @heaths)


Feature request: Minify index.html

Currently, the index.html file gets into the production destination folder "as is" (npm run build:prod).
I'd like to see it minified with removed comments, spaces, etc.
Usually, the index.html file is quite concise, but with some comments though. So removing the comments for the production version would be very useful.

and also need merge some extra js in html

We have html-webpack-plugin in place.
minify: {
removeComments: true,
removeTagWhitespace: true
}

should to the trick.


Directory structure

Hi, I want to use your system but I can't build your system. I can't find where you refer as included library directory.
Where should I put my Vimba directories?
Thanks,

Sorry for not clarifying the building process, will describe it shortly in the README.
As a quick answer to your question, the path to Vimba installation should be placed in the VIMBA_DIR environment variable, e.g.:
export VIMBA_DIR=/opt/Vimba_2_1

In addition, OpenCV should be installed in the standard location (/usr/local), so that find_package finds it.


Only check for Xcode CL 5.1 until MacOS 10.9

The MacOS 10.10 the command line tools check, used in script/bootstrap, isn't working anymore.
10.9:
pkgutil --pkg-info=com.apple.pkg.CLTools_Executables

>= 10.10
xcode-select -p

If we run this test on 10.10. and higher we get a error message like this:
No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

Since Xcode 5.1 isn't available on MacOS 10.10 and we don't have to set the ARCHFLAGS, I added a check for the OS version to get rid of the error.

I hit this during the upgrade to 10.11 - Looks to work from a fresh install :+1:


EF Core 3 Sql Server Version

With EF Core 3, SQL Server 2008 is no longer supported. I am trying to decide which development SQL Server Express version to upgrade to. My production SQL database hosting provider now provides an upgrade to SQL Server 2016. I currently have SQL Server Express 2017 running locally to support Azure DevOps.
From an EF Core 3 SqlServer perspective does it matter which SQL Server version (2016 v 2017) is used?

No, it does not matter.

Thanks @ErikEJ


Fix flipped binormal in StandardMaterial3D triplanar mapping

master version of https://github.com/godotengine/godot/pull/49950.
This made normal maps on triplanar materials use an inverted Y direction compared to non-triplanar materials.
This closes https://github.com/godotengine/godot/issues/46363.
Preview
Testing project: test_triplanar_normal.zip (master, will not work in 3.x)
Before

After

Thanks!


TileMap causes it to run slower

Godot version
4.0beta1
System information
windows10
Issue description

In the same case, 3.5 loaded for 3 seconds and 4.0 loaded for 1 minute
Steps to reproduce

In the same case, 3.5 loaded for 3 seconds and 4.0 loaded for 1 minute
Minimal reproduction project
No response

@xiaoliang6669 Please upload a minimal reproduction project to make this easier to troubleshoot.
The reason for this occurring is likely that TileMap images were saved as serialized Base64 within the .tres file instead of external PNG images.

You're right, but I usually merge images with TexturePacker, a third-party software, to reduce the size of images

This seems expected. You are not supposed to have that many atlases in you TileSet and should use the atlas merging tool to reduce the number of atlas sources. The atlas merging tool is accessible from the menu with 3 dots at the bottom.

@groud
A tile 320*240, a total of 840 pieces make up a complete large map, I need to dynamically load and unload each tile in the script to achieve the correct display of the map. There is also a problem, how to use the script implementation to set the navigation shape for each tile, 3.0 I implemented, but 4.0 everything changed.

A tile 320*240, a total of 840 pieces make up a complete large map, I need to dynamically load and unload each tile in the script to achieve the correct display of the map.

How many tile you have is not a problem, you need to move them all to a single tile atlas, not use one atlas per tile, which is really inefficient.

There is also a problem, how to use the script implementation to set the navigation shape for each tile, 3.0 I implemented, but 4.0 everything changed.

This is implemented in 4.0 too but needs to be documented I suppose.


[ISSUE #2615]Add property of benchmark`s producer that specifies how many messages to send

Make sure set the target branch to develop
What is the purpose of the change
Add property of benchmark`s producer that specifies how many messages to send, when sending a specified number of message, send over.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

should not merge into master

should not merge into master

Coverage decreased (-0.3%) to 51.584% when pulling 32881d466e1a4b379e0addc5faf7372708d48517 on xxd763795151:bench_producer_num into 39bb9386f10d5d8dfe81183c172a3a86f6d313bd on apache:master.

Coverage decreased (-0.3%) to 51.584% when pulling 32881d466e1a4b379e0addc5faf7372708d48517 on xxd763795151:bench_producer_num into 39bb9386f10d5d8dfe81183c172a3a86f6d313bd on apache:master.


⚠ ClamAV has degraded performance

In 47958d2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 242 ms

Resolved: ClamAV performance has improved in ed8fb35.


Extract binding module

Changed

Extracted  binding module.
Extracted reflectMetadata module.
Renamed ContainerBindingService to BindingService.
Updated package.json to declare pnpm@7 as package manager.

Codecov Report

Merging #99 (c9d9126) into master (7af41af) will increase coverage by 1.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   95.66%   97.52%   +1.86%
==========================================
  Files          87       29      -58
  Lines        1384      526     -858
  Branches      158       35     -123
==========================================
- Hits         1324      513     -811
+ Misses         58       13      -45
+ Partials        2        0       -2

Flag
Coverage Δ

cuaktask
92.72% <ø> (ø)

iocuak
?

porygon
98.58% <ø> (ø)

porygon-typeorm
98.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ckages/iocuak/src/binding/decorators/injectable.ts

...s/iocuak/src/binding/models/api/BindingScopeApi.ts

...es/iocuak/src/binding/models/api/BindingTypeApi.ts

...ing/models/api/bindingScopeApiToBindingScopeMap.ts

...ing/models/api/bindingScopeToBindingScopeApiMap.ts

...s/iocuak/src/binding/models/domain/BindingScope.ts

...es/iocuak/src/binding/models/domain/BindingType.ts

...ng/services/domain/BindingServiceImplementation.ts

...rc/binding/utils/api/convertBindingToBindingApi.ts

...cuak/src/binding/utils/domain/getBindingOrThrow.ts

... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eede652...c9d9126. Read the comment docs.


iOS10 background issue

Is there a problem with iOS10 notifications when app is in background?
If app is in background or closed i can see nothing, I receive notifications only when app is in foreground.

are you installing from master or 0.1.12?

yep
$ cordova plugins ls
cordova-plugin-console 1.0.4 "Console"
cordova-plugin-dialogs 1.3.0 "Notification"
cordova-plugin-firebase 0.1.12 "Google Firebase Plugin"
cordova-plugin-inappbrowser 1.5.0 "InAppBrowser"
cordova-plugin-whitelist 1.3.0 "Whitelist"

You should add this into your plist file
    <array>
      <string>remote-notification</string>
    </array>```

I added
<key>UIBackgroundModes</key>
<array>
    <string>remote-notification</string>
</array>

But nothing change

The changes for ios 10 are not yet in npm, only here on github. So please test to install from github instead until there is a new release in npm

@robertarnesson How? if i do
cordova plugin remove cordoba-plugin-firebase
cordova plugin add https://github.com/arnesson/cordova-plugin-firebase

it will receive neither notification in foreground

@voidbrain you need to remove the platform too.
remove plugin
remove platform
add plugin from github

from scratch:
cordova create hellopush com.klekoo.pushme HelloPush cd hellopush cordova plugin add https://github.com/fechanique/cordova-plugin-fcm cordova plugin add cordova-plugin-console cordova plugin add cordova-plugin-whitelist cordova plugin add cordova-plugin-inappbrowser cordova platform add ios cordova build
TypeError: undefined is not an object (evaluating 'window.FirebasePlugin.grantPermission()')
TypeError: undefined is not an object (evaluating 'window.FirebasePlugin.setBadgeNumber')
window.FirebasePlugin is null

you should wait the ready callback to be called. Just after it the window.Firebase object will available.

I can confirm this does not work with the current github version. I've tried few times (at least 5 in the last 2 hours) to install the official version, revert, and then install the Github version and then the official version...
Regarding the official version, I get the notification when the app is in the background. When the app is in the foreground, I see the notification logged in XCode console, but the notification does not appear on the Device (iPad). Basically like @voidbrain is describing. I've added also UIBackgroundMode as mentioned and checked the remote notification checkbox.
Regarding the GitHub version, just nothing work, neither foreground nor background. Maybe something interesting:
1- I create the app with the official version => notification working (at least background)
2- I remove the platform in cordova, remove the plugin, add the platform, add the github version, build ios, check the right stuff in XCode and then the new version to the device
Because I have not deleted the app on the iPad (just overwritten it), the old token (created in step 1-) is still valid. The notification that I send with this token is actually received by the application (in the logs), even so it does not appear as notification in the device.
Maybe something important. I've tested the Github version on an iPad below 10, and notification are not received there either.

@BugsBunnyBR i think i'm doing it
`
/*

Licensed to the Apache Software Foundation (ASF) under one

or more contributor license agreements.  See the NOTICE file

distributed with this work for additional information

regarding copyright ownership.  The ASF licenses this file

to you under the Apache License, Version 2.0 (the

"License"); you may not use this file except in compliance

with the License.  You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,

software distributed under the License is distributed on an

"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY

KIND, either express or implied.  See the License for the

specific language governing permissions and limitations

under the License.
*/
var app = {
this_token: "",
app_name: "PushMe",
registerPush: "https://farmacieunite.it/ajax/moduli/push/register_push",
// Application Constructor
initialize: function() {
this.bindEvents();
},
// Bind Event Listeners
//
// Bind any events that are required on startup. Common events are:
// 'load', 'deviceready', 'offline', and 'online'.
bindEvents: function() {
document.addEventListener('deviceready', this.onDeviceReady, false);
},
// deviceready Event Handler
//
// The scope of 'this' is the event. In order to call the 'receivedEvent'
// function, we must explicitly call 'app.receivedEvent(...);'
onDeviceReady: function() {
app.receivedEvent('deviceready');
app.setupPush();
 $(document).ready(function() {
     var iOS = /iPad|iPhone|iPod/.test(navigator.userAgent) && !window.MSStream;
     if(iOS){ $("#platform").val("iOS") }else{ $("#platform").val("Android") }
     categorie = "";
     $("#registra_push").on("click", function(){
         $('input[name="registra_push"]:checked').each(function(){
             categorie += $(this).val()+"; ";
         })
         token = app.this_token;
         var params = {
             categorie: categorie,
             token: token,
             platform: $("#platform").val()
         }
         $.ajax({
             url: app.registerPush,
             dataType: "json",
             type: "POST",
             data: params,
             success:function(data){
                 if(data["status"]=="ERROR"){
                     feedback ="Si è verificato un errore, riprova più tardi";
                 }else{
                     feedback = "Registrazione inviata!";
                 }
             },
             error: function(XMLHttpRequest, textStatus, errorThrown) {
                 feedback ="Si è verificato un errore, riprova più tardi";
                 console.log("Status: " + textStatus);
                 console.log("Error: " + errorThrown);
             }
         });
         categorie = "";
     });
 });

},
// Update DOM on a Received Event
receivedEvent: function(id) {
var parentElement = document.getElementById(id);
// var listeningElement = parentElement.querySelector('.listening');
// var receivedElement = parentElement.querySelector('.received');
 // listeningElement.setAttribute('style', 'display:none;');
 // receivedElement.setAttribute('style', 'display:block;');

 // console.log('Received Event: ' + id);

},
setupPush: function() {
window.FirebasePlugin.grantPermission();
window.FirebasePlugin.setBadgeNumber(0);
window.FirebasePlugin.getInstanceId(function(token) {
app.this_token = token;
// save this server-side and use it to push notifications to this device
}, function(error) {
console.error(error);
});
 window.FirebasePlugin.onNotificationOpen(function(notification) {
     window.FirebasePlugin.getBadgeNumber(function(n) {
         window.FirebasePlugin.setBadgeNumber(n+1);
     });

     navigator.notification.alert(notification.notification.body,function(){},this.app_name);
     console.log(notification)
 }, function(error) {
     console.error(error);
 });

}
};

app.initialize();`

I just realized that my iOS version is not working too. :-/
I am using the github version.

I'm actually realizing that the foreground notification is not working either on iOS 9.3 (i.e. behaving like on iOS10). Background notification working in both cases.

@Krisa , on iOS, the default behavior is to not show the notification if the app is in foreground.

I found a possible solution:
FFirstly: it is not the plugin
Second, the GoogleService-info.plist file should enter:
  "Required background modes" (s array and there are 2, one is for the watch)
and inside the Required add a "workout-processing" element
Required background modes => workout-processing
ME THIS WORKED ...
PS: do not just say that solution, always type your solution.

Encontre una solucion posible:
Pprimero: no es el plugin
Segundo: el archivo googleService-info.plist debe ingresar:
"Required background modes" (es array y hay 2, uno es para el watch)
y dentro del Required agregar un elemento " workout-processing "
Required background modes  => workout-processing
ESTO ME FUNCIONO...
PD: no solo diga que lo solucion,escriba su solucion siempre.

I am using github at version 0.1.12. The foreground notification works. Background does not.

Foreground notification comes through, but background ones doesn't notify but they show up after app is in foreground.
v0.1.13

update to 0.1.14. open a new ticket for any remaining issue

I was still having issues with v0.1.14 not handing notifications if the app is dead (not even in background).  The solution for me was to add this immediately under the iOS10 conditional directive...
`#if defined(__IPHONE_10_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0
-(void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)userInfo fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))completionHandler {
NSDictionary *mutableUserInfo = [userInfo mutableCopy];
[mutableUserInfo setValue:self.applicationInBackground forKey:@"tap"];

// Pring full message.
NSLog(@"%@", mutableUserInfo);

[FirebasePlugin.firebasePlugin sendNotification:mutableUserInfo];

}`
For whatever reason, unless the didReceiveRemoteNotification method includes the completionHandler, it will not work in iOS10

this makes very little sense. first of all this code should not be within the ios 10 block, because its not ios 10 specific.
Also the UIBackgroundFetchResult handler is supposed to be used when you need to do background work as the notification comes in. Is this what you are trying to achieve?
By design you receive the notifications on your device regardless if the app is in the background or dead. Once you click on a notification, the app should start/resume and didReceiveRemoteNotification will be called. It will not be called until you click on the notification

Fair enough, I can understand within the iOS10 block, and can certainly move it outside of that.
The issue I was having was that when pushing a message with data (i.e. Key/value pair), when tapping the message to launch the app, nothing would happened if the app was dead.  If it was in the background, didReceiveRemoteNotification would be called.
For example, if I sent a notification to the user that someone commented on their post and sent the postID as a key/value along with the notification, I would like the app to launch when the notification was tapped and go to the post to display the comment.  I was able to make this work when the app was in the background and they tapped on the notification, but could only get it to work if the app dead and they tapped the notification by adding this code, otherwise, nothing happened.

i guess it cant hurt to have both handlers anyway

After further testing, I found a solution that works every time and probably doesn't require implementation of didReceiveRemoteNotification with completionHandler.  My javascript code was look for the "tap" key in the notification object passed to "onRemoteNotificationOpen".  If the tap key existed and was true, then I knew that the app was in the background and the user tapped the notification to open the app.  The worked perfectly except when the app was dead.  When the app was dead and a user tapped a notification, no tap key existed in the notification object.
I added the following to the method swizzledDidFinishLaunchingWithOptions to detect if the user tapped the notification and the app was not running at all.
if ( [launchOptions objectForKey:@"UIApplicationLaunchOptionsRemoteNotificationKey"] != nil) {         NSLog(@"Notification");         self.applicationInBackground = @(YES);   }
Adding that code solved my problem.  Now, my javascript receives the info that the notification was tapped, causing the app to launch and allowing me to handle the notification knowing the app wasn't in the foreground.

nice. I'll take a PR with this fix

@jashick Do you have similar solution for Android? It did work for iOS 👍

@jashick it seems like it would be enough to always set self.applicationInBackground = @(YES); the app state is always in background when DidFinishLaunchingWithOptions is called. do you agree?

@robertarnesson Yes, I guess that would make more sense.


delete voice note in detailed view

If user delete the voice note from detailed view, the entry in the table Voices are not completely deleted.

Current status: 09.03 16:00
If user delete a voice note in the detail view, the connected image object is deleted from image table, but the note object still remains in the note table.

fixed


User-defined display options

Thank you very much for your work. Is there a way to enable me to open a certain pdb of my local and display it on the front end?

Hi!, sorry for the late response. I have updated the component. Please check this new example:
https://github.com/napoles-uach/streamlit_3dmol/blob/master/stmol/example.py
It uses a new function called showmol that you can use to render any py3dmol object. Use it instead of py3Dmol.show().

I am very glad that you can reply to me. My requirement is like this, I want to make a graphical molecular viewer that can open pdb or sdf files. If it is in the jupyter notebook, I can use view.addModel(benz,'sdf') to render the result, but I recklessly added it to you, it may not work because of my improper operation, the code is as follows：
benz='''
     RDKit          3D
  6  6  0  0  0  0  0  0  0  0999 V2000
   -0.9517    0.7811   -0.6622 C   0  0  0  0  0  0  0  0  0  0  0  0
    0.2847    1.3329   -0.3121 C   0  0  0  0  0  0  0  0  0  0  0  0
    1.2365    0.5518    0.3512 C   0  0  0  0  0  0  0  0  0  0  0  0
    0.9517   -0.7811    0.6644 C   0  0  0  0  0  0  0  0  0  0  0  0
   -0.2847   -1.3329    0.3144 C   0  0  0  0  0  0  0  0  0  0  0  0
   -1.2365   -0.5518   -0.3489 C   0  0  0  0  0  0  0  0  0  0  0  0
  1  2  2  0
  2  3  1  0
  3  4  2  0
  4  5  1  0
  5  6  2  0
  6  1  1  0
M  END
$$$$'''
view = py3Dmol.view()
view.addModel(benz,'sdf')

showmol(view)

Hi!, please try with the following example:
import streamlit as st
import py3Dmol
from stmol import showmol

benz='''CT1001419667

 12 12  0  1  0               999 V2000
   -0.0167    1.3781    0.0096 C   0 00  0  0  0  0  0  0  0  0  0  0
    0.0021   -0.0041    0.0020 C   0 00  0  0  0  0  0  0  0  0  0  0
    1.1709    2.0855    0.0021 C   0 00  0  0  0  0  0  0  0  0  0  0
    1.2084   -0.6789   -0.0132 C   0 00  0  0  0  0  0  0  0  0  0  0
    2.3960    0.0285   -0.0212 C   0 00  0  0  0  0  0  0  0  0  0  0
    2.3773    1.4107   -0.0131 C   0 00  0  0  0  0  0  0  0  0  0  0
   -0.9592    1.9054    0.0170 H   0  0  0  0  0  0  0  0  0  0  0  0
   -0.9258   -0.5567    0.0083 H   0  0  0  0  0  0  0  0  0  0  0  0
    1.1563    3.1654    0.0077 H   0  0  0  0  0  0  0  0  0  0  0  0
    1.2231   -1.7588   -0.0184 H   0  0  0  0  0  0  0  0  0  0  0  0
    3.3385   -0.4987   -0.0324 H   0  0  0  0  0  0  0  0  0  0  0  0
    3.3051    1.9634   -0.0197 H   0  0  0  0  0  0  0  0  0  0  0  0
  1  2 02  0  1  0  0
  1  3 01  0  1  0  0
  1  7  1  0  0  0  0
  2  4 01  0  1  0  0
  2  8  1  0  0  0  0
  3  6 02  0  1  0  0
  3  9  1  0  0  0  0
  4  5 02  0  1  0  0
  4 10  1  0  0  0  0
  5  6 01  0  1  0  0
  5 11  1  0  0  0  0
  6 12  1  0  0  0  0
M  END
$$$$
'''

xyzview = py3Dmol.view(width=400,height=400)
xyzview.addModel(benz,'sdf')
xyzview.setStyle({'stick':{}})
xyzview.setBackgroundColor('white')#('0xeeeeee')
xyzview.zoomTo()
showmol(xyzview,height=500,width=500)

That works on my side. Let me know if you have any issues. Please, don't forget to install the last version of stmol https://pypi.org/project/stmol/

Thank you so much, it is very helpful to me！！！

Glad to be of help!


Harmonize nix and nixos "binaryCache" / "substituter" options

As far as I understand, nix configuration has deprecated usage of binaryCaches and trustedBinaryCaches in favor of substituters and trustedSubstituters.
Is there a reason this hasn't been reflected in the congruent NixOS nix.* options? Someone mentioned "not yet" in IRC some weeks ago, but I don't know if it's planned/blocked/etc.
Thanks.

This change bit me since I'm not a regular user of nix so I wasn't aware of it. It would be super helpful to have some kind of warning/error if binary-caches is used and you're running with 2.0! It was very painful :sweat: :sweat_smile:

fixed in 4a9d9928dc01421b878cfe4a16961c1e4862d846


 **[Post a bounty on it!](https://www.bountysource.com/issues/26385242-db2-arel-query-building-with-offset-limit-broken?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F136963&utm_medium=issues&utm_source=github).

How do we test this?

the obvious way is rake test_db2 ... so its currently only testable with a DB2 instance, but your q is valid - it should be reproducable without a real db as well (usually each test/db/xxx sub-folder has a unit_test.rb)
trying to finish the 4.2 review (for all adapters) and leaving the left-overs as separate issues, this one seems like it could really use a new perspective - recall there has been attempts to get orders working with the current limit/offset hacks but caused regressions ... current status: https://github.com/jruby/activerecord-jdbc-adapter/commit/7ab8161b3046c60c5f8ae990e95dc90dfbd4532b

Whats the reason for not using the provided LIMIT and OFFSET  SQL commands?
Seems like a hack to get around it