WIP: Headers cleanup.

This looks mostly awesome. Just a couple concerns around ease of use.

use hyper::header::LastModified feels nicer than use hyper::header::common::LastModified.
Encoding and ConnectionOption should be importable from the same place as their headers. One should be able to do use hyper::header::{Connection, ConnectionOption} or similar. Instead of one to common and another to shared.

I agree that it minimally less convenient to have to import things from two places. But I think it is worth it, because it makes hyper::header::common very clean. It only contains headers. Since header names must be unique, there can not be collisions between different headers. Currently the struct for the Cookie header is called Cookies, not very easy to know. This is because the name Cookie already used by https://github.com/alexcrichton/cookie-rs If we only have headers in common there are no such problems and we can rename Cookies to Cookie.
The rust guide recommends to import modules and no individual items (http://doc.rust-lang.org/guide.html#standard-input "However, it's considered better practice to not import individual functions, but to import the module, and only use one level of qualification"), I think you should anyway not do use hyper::header::{Connection, ConnectionOption} but use hyper::header. (I know hyper does not yet follow this practice at most places, but I think it would be a very good thing if it did)
It may be a good idea to reexport all contents of hyper::header::shared to hyper::header. If common would be renamed to cor something else very short you could douse hyper::header::{self, c}and then doheader::ConnectionOptionandc::Connection`, which would be very easy to use, or don't you think so?

I am thinking about suffixing all headers with Header this would also make clear what structs and enums are headers and prevent collisions. This will break most existing programs and make the names longer. @seanmonstar What do you think?

I am not a fan of that idea - AccessControlAllowOrigin is long enough already :/

Me neither. No need for suffixes or prefixes when they come from a header module.


feat: remove handleEvent in favor of handleRequest

Description
This is a huge refactoring to expose a simpler handleRequest instead of handleEvent. The first commit does all the refactoring while the second one aggregates all the breaking changes. There are several reasons for this refactoring:

We were not exposing handleEvent for non-worker environments (e.g. serverless functions like Vercel). This now exposes a simpler handleRequest that removes the need for event, which means we can use it in serverless functions and also in workers with or without Modules syntax.
Currently, we are loading files in two different contexts, Vite (in entry-server.tsx) and Node (in handle-event.ts), which has led us to multiple issues. This PR moves all the handle-event.ts logic to entry-server.tsx. From here, renderHydrogen simply returns a handleRequest function that handles stream/hydrate/render. These 3 functions are not merged yet but we can now do it more easily by extracting common logic to the parent handleRequest.

It probably makes more sense to check the files directly instead of the git diff.
@jplhomer what's your feeling about this?
Additional context

Before submitting the PR, please make sure you do the following:

[ ] Add your change under the Unreleased heading in the package's CHANGELOG.md
[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository for your change, if needed

@mcvinci Woah, that's fast! It should be import {handleRequest} from '@shopify/hydrogen' and handleRequest(event.request, {. But apart from that, we also need to change the assetHandler a little bit. In any case, this is just an exploration right now and need approval first. We might change things or even revert the breaking changes 😅
I'll update you once we know how things will look like 👍
This makes me think, @jplhomer we could re-export handleRequest from @shopify/hydrogen/worker default export and accept event optionally to keep things without breaking changes for current users if we want.

@frandiox For your reference, here's the commit on the Shopify.dev side that relates to these changes (minus the diagram at the moment): https://github.com/Shopify/shopify-dev/pull/16194/commits/d7a038c5a405e6a4102e5fc8958020783b677875

@blittle Thanks!

Do we see a future where we only use ReadableStream?

I would like this but I don't know if Node.js/Vite will support responding to server requests using fetch Response to leverage ReadableStream. I guess we could pipe a ReadableStream to the Node response (Writable). Not sure what would be the performance penalty there, but perhaps not much after 16.5 since ReadableStream is also native.

Maybe one idea of simplifying things is just having a separate file for the hydrator, renderer, and streamer? I don't know if that would make it easier to parse though?

I think we can start abstracting things from render/hydrate/stream to the parent handleRequest function bit by bit. Things that are common, or perhaps adding conditionals 🤔

@frandiox I just took a first attempt at updating the diagram. Is this accurate?

@mcvinci I think that looks much closer, yes! App.jsx should be App.server.jsx if we want to use file name, though.
Another thing is that handleRequest would be exported from App.server.jsx so I'm not sure if this should also wrap handleRequest in the diagram? To be more precise, it would be something like this:
App.server.jsx / Caching
--------------
|  handleRequest[Cache API, KV API]
|    |
|    |
|    V
|   App ------------------------> Pages
--------------

But I'm not sure how to do it if we want to separate App vs Caching 😅

Thanks, @frandiox! I think you're right -- it would be worthwhile wrapping handleRequest in that diagram. Here's what it could look like. What do you think?

@mcvinci Thanks, I think that looks good and closer to the current code 👍


index and search

add a method to search metadata in the filetree to locate art objects

implemented bleve search
put index in media root
added reindex option to the about menu
Added tabbed pane for left hand nav pane
created a search widget
implemented fuzzy and exact queries for searchbox


Configuration-based filtering of (assembly) files to be scanned by WebActivator

Here's the change we discussed. A single regex with |s in it seems to suffice for a list of assemblies. See the app.config of the test project for an example.

Looks great. Thanks for your contribution! It's in 2.1.0 on NuGet. Please make sure it all works well with official build.


Startup error with Neo4j 5.17.0

Describe the bug

Which version do you use: 5.11.0
Which Lock Provider: Neo4j

With Spring bean definition as from the docs:
@Bean
Neo4jLockProvider lockProvider(org.neo4j.driver.Driver driver) {
    return new Neo4jLockProvider(driver);
}

we get the following startup error:
Error creating bean with name 'lockProvider' defined in org.apache.syncope.core.persistence.neo4j.PersistenceContext: Failed to instantiate [net.javacrumbs.shedlock.provider.neo4j.Neo4jLockProvider]: Factory method 'lockProvider' threw exception with message: Invalid constraint syntax, ON and ASSERT should not be used. Replace ON with FOR and ASSERT with REQUIRE. (line 1, column 1 (offset: 0))
"CREATE CONSTRAINT UNIQUE_shedlock_name IF NOT EXISTS ON (lock:shedlock) ASSERT lock.name IS UNIQUE"

The fix should go onto net.javacrumbs.shedlock.provider.neo4j.Neo4jStorageAccessor.createLockNameUniqueConstraint() but that method is unfortunately private.

Hi, thanks for reporting. If you send a PR, I will be happy to merge it and release it. Is it due to a new version of Neo4j or what's the cause of the issue?

Is it due to a new version of Neo4j?

@lukas-krecan exactly: the current syntax used to work with Neo4j 4.4, some small adjustments are needed to work with Neo4j 5 - see for example https://towardsdatascience.com/how-cypher-changed-in-neo4j-v5-d0f10cbb60bf#943a

Cool, I actually have the PR ready so no need to do anything from your side. Thanks

Ah even better, thank you!
Question: are SNAPSHOTs published somewhere?

No, but I usually release a new version every time there is a significant change


How to preserve request / response order with the callback version of AsyncRun?

In the image_client example, to preserve the order of requests / responses, a deprecated version of the AsyncRun method is used. There, we save the sent request objects to a queue, then wait on them one-by-one.
Since, in a future version of TRTIS, we'll only be able to use the callback version of AsyncRun, how is this order-preserving functionality intended to be implemented with it?

You can keep track of the ordering in your callback by capturing additional information. For instance, lambda capture in C++ client library, and "partial" in Python client library.

A python example that uses a queue is here: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/src/clients/python/simple_callback_client.py

Ok, but with the removal of the request-based AsyncRun method, in the case where the order of the requests is important, users are now required to do the synchronization logic on their end. Is this correct?
Also, are there any plans to update the image_client example by removing the use of the deprecated method?

Firstly, the API is just deprecated... it is not being removed. Perhaps in a future iteration of the client library it will be removed but we don't currently have any plans for that.
You always had to do your own sync logic because you needed to wait for the response (either by blocking on the API or some other method. You can still do that with the callback API, you just need to provide the callback function to collect the request IDs.


[PE-D][Tester D] Phone number

I put someone's phone number to 123 and it worked also. maybe should have a longer minimum length
Maybe phone number should have a minimum length?

Labels: type.FeatureFlaw severity.Low
original: tanveersingh10/ped#4

Duplicate


Can't connect to host

Hey, i read through the issues and already tried to reinstall the hoymiles addon and add the lib manually but this didnt solved my problem. I can ping the 800-2T successfully but cant get a connection.
Hoymiles is installed via hacs. i can also see it within the Fritzbox and S.Miles cloud.
HA is up2date
Core
2024.6.2
Supervisor
2024.06.0
Operating System
12.3
Frontend
20240610.0
any other ideas?

Gacs version is 1.34.0

@Seani08 is there anything in the logs?
Otherwise, I just pushed a new pre-release version 0.2.4-dev which adds some more logs if the DTU cannot be reached to help debugging.

Got the same issue (and pretty much the same hardware setup :)) I got 0.24dev running, there are no logs showing up.


Request: positive and negative numbers as a subtype of number

Search Terms
number, numbers, positive numbers, negative numbers, unsigned
Suggestion
Unlike the proposals requesting explicitly sized values, such as i32, I am requesting a type that differentiates between negative numbers and positive numbers.
Use Cases
This has immediate use practically everywhere.
There are a whole lot of times where numbers are intended to be positive numbers.
For example, indexing arrays should always be positive:
type Array<T> = {
    [key: positive_number]: T
};

Why the hell would you want a negative index!?
Furthermore, plenty of built-in functions just throw errors for using negatives.
Some examples:
42.0.toString(-2);

BigInt.asIntN(-2, -1n);

new Array(-37);

If anything, they can prevent using negative constants in places where there should be positives.
Granted, there are plenty of places where generic number stills fits just fine. Also, I have no clue what we do about NaN.
And lastly, it is unlikely that negative literals are ever used erroneously, but negative runtime values can make it into places where... you wouldn't want them to be.
Examples
Introduce a way to denote that a number or bigint should be positive or negative.
let x: positiveNumber = 3; // fine, constant 3 is positive
...
x = -5; // error, constant "-5" is not a subtype of positiveNumber

x = 24654.36546; // not negative, perfectly fine

x = -7 as unknown as positiveNumber; // hands off, that's on the developer

x = Infinity; // questionable, but still positive

x = -0; // ???

x = NaN; // ???

Checklist
My suggestion meets these guidelines:

[ x ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ x ] This wouldn't change the runtime behavior of existing JavaScript code
[ x ] This could be implemented without emitting different JS based on the types of the expressions
[ x ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ x ] This feature would agree with the rest of TypeScript's Design Goals.

For the same reasons that it's impractical to support an int type, I think it's impractical to support a negative type and a positive type. You'd need deeper data flow analysis to determine whether arithmetic on any two values will always continue to be a positive number, and any case where you don't is so trivial that a feature like this is probably not useful.
As another nit: the Array case is especially not a great motivation because TypeScript specifically wouldn't be able to catch that without introducing unrelated breaking changes. If you swapped the arrayLength parameter to be of type positive_number, it would just fall to the next overload. If you fix the ...items overload to type [T, T, ...T[]], then you're breaking other code.

For the same reasons that it's impractical to support an int type, I think it's impractical to support a negative type and a positive type.

That request asked for type emits for runtime performance, this does not. A division operation between ints needed a cast, here, I would just say most operations should yield a number. (It could be tedious to cast every single-use).

You'd need deeper data flow analysis to determine whether arithmetic on any two values will always continue to be a positive number, and any case where you don't is so trivial that a feature like this is probably not useful.

If anything, the developer could cast a positive/negative value themselves, allowing them to know that they are safely using the value, and TSC should help them use it correctly. If anything, one could forcefully cast to a positive via the unsigned right shift operator.

As another nit: the Array case is especially not a great motivation because TypeScript specifically wouldn't be able to catch that without introducing unrelated breaking changes.

Now, I did think about this, and it could very well break something out there. I'd suggest a flag to start with (that is if the community doesn't think that this is 100% useless).
But, for example, the basic C "for loop" would continue unchanged:
// i is deduced as positive
for (let i = 0; i < arr.length; ++i) { // ++positive = positive;
    arr[i];
}

As i would remain positive throughout the entire loop. But plenty of other cases could break.

That request asked for type emits for runtime performance, this does not.

Performance was just a side-note and the type emit an optional suggestion. The major point was to represent a subset of number to catch errors early on, the same as your issue.

I would just say most operations should yield a number.

I'd be looking forward to the frequent issues of "Why is positive 1 + positive 3 a number, and not a positive number?"

Performance was just a side-note and the type emit an optional suggestion. The major point was to represent a subset of number to catch errors early on, the same as your issue.

Guess this is out of scope then.


Hot Module Reloading does not retain state in services

With Hot Module Reloading I was expecting that only the file/component that I made a change to would be swapped out. However, if you have a service injected into the changed component that is holding some state, that state is refreshed to it's beginning state again.
Setup:
ServiceA has a data property that starts as 'foo'
ComponentA injects ServiceA as public
ComponentA.template = <h1>{{serviceA.data}}</h1><button (click)="serviceA.data = 'bar' ">Click</button>;
ComponentA button click changes 'data' to 'bar'.
Steps:
Launch app
Click button
Make an edit to ComponentA
Actual:
h1 shows 'foo'
Expected:
h1 to show 'bar'

I didn't create proxies for any of the components or service because the implementation is a simple one since there are many core changes planned I didn't want to create one only to refactor it many times over. I'm closing this for now to keep the issues down

Could you point me in the right direction how to hold state in components/services with HMR and also how not to reload whole page/state after CSS (Sass) file update ?

I this working now I just need to push it up later

if you use npm start:hmr you will have HMR with state management using a decorator


Fix for enabling spaces in filenames

Filenames were being double encoded, i.e. "foo%2520bar" instead of "foo%20bar".  Solution removes encodeURI() on line 314 and leaves line 373 to do the encoding.
Resolves https://github.com/mikedeboer/jsDAV/issues/155

why is this not merged in ? @mikedeboer any specific reason ?


Skype call bot calling webhook does not support query string parameters

I wish to be able to append query parameters to Skype Bot Calling webhook URL and to have these parameters deserialized in IncomingCallEvent. This will allow me to create a stateless bot and to control its functionality by configuration from Call URL.
I was able to workaround this with Skype Bot SDK but it seems impossible to workaround with Bot Framwork SDK v3, so since Skype Bot SDK is phasing out, I would like to have the support I requested.
I also posted this on botfamework feedback site.
I already have the fix for this issue ready waiting to be submitted as PR. Please approve this issue to get the PR, as requested by contribution terms.

Created Pull Request https://github.com/Microsoft/BotBuilder/pull/764

@mghimp , did you manage to get Skype Bot Calling to send request to your bot? i got my bot setup with the new api controller named CallingController with the following medhot
[Route("call")]
public async Task ProcessIncomingCallAsync()
I set the followings as the Calling Webhook, however they never get hit when i am making the call, any thought?
https://eddybot.azurewebsites.net/api/calling
https://eddybot.azurewebsites.net/api/calling/call

@mayuanyang , there might be several issues:

The webhook should be 'https://eddybot.azurewebsites.net/api/calling/call'. In respect to the fact that you don't see it hit, I assume that you verified the web server traffic log.
In regards to Controller, My controller is public class CallingController : ApiController, i.e. derives from System.Web.Http.ApiController. In addition, the method signature is public async Task<HttpResponseMessage> ProcessIncomingCallAsync().

I suggest to debug using ngrok and run your bot locally. This will make the debugging easier. In addition, you can use this tutorial to get started.

@mghimp i am actually doing exactly the same thing, in fact the code is copied from the bot framework simpleIVRSample project, will try ngrok to debug and see how it goes, thanks

@mayuanyang I see that @msft-shahins has replied to your CR, I'm closing this issue. Thanks!

Please reopen the issue as it has not been resolved. I opened this issue and my PR #764 is still pending.

@mghimp I commented on the PR. We can continue talking about this in the PR comment section.


Make json valid

Very simple fix but your json is invalid. More pull requests to come!

He did validate it, it does work with pangolin

Where is Figma here

what

can we merge?

verifying

yes


ICA => ISCA ? - Fix splash screen

Here:

Thank you! We are going to leave this as is since we want the conference app to appear and behave the same no matter what it is built with. :smile:


Vertical scrolling can scroll beyond the line where it exists.

Vertical scrolling can scroll beyond the line where it exists.
I would like to know how to solve this problem.
Or if it is a bug, we want to fix it.

※I want to eliminate blank spaces like image1.

※Ideally, no blank space should appear when scrolling to the bottom, as in image2.

@jingwood Will this bug be fixed in the future? This bug also make weird scroll behavior while FreezeArea is set to Bottom. Any interim support or suggestions for alternative methods to mitigate this issue would be immensely appreciated.


[feature request] sending response to a single connection

Hi, I'm working on implementing a response for the Last-Event-ID header. When a client reconnects and the last-event-id header is present it would be convenient to have a method in sse-broadcast to send a message to that single client.

Hey @araker!
I appreciate your feedback, and I accept that it would be a great extension of sse-broadcast to support the last-event-id header. However this introduces some unintended complexity; so this change requires appropriate planning.
To be able to target clients sticked to a given event id (at a specified point of the event-stream), we need to - at least temporarly - store event ids per client on the server, which requires an abstract and centralised solution for server-side client state management.
I don't have a thoroughgoing solution for this use-case, but I'm open to any suggestion to implement this in a clean, maintainable and mature way.

Hi @schwarzkopfb,
I agree that for the last-event-id to work you need to save the id's on the server, I already use redis to save the outgoing event ids and retrieve the correct range of them when getting a last-event-id. I don't see this per se as a responsibility of your module though.
So the only extra functionality I need is sending a message to a single client. I've created a hacked version of the publish function which works for my purpose.
`/**

Send a message to a single connection

@param {object} response to send the message to

@param {string|object} eventOrOptions Event name or an options object that specifies the message.

@param {string} [eventOrOptions.id]    Optional event identifier.

@param {string} [eventOrOptions.event] Event name.

@param {string} [eventOrOptions.data]  Optional event payload.

@param {string} [eventOrOptions.retry] Optional retry time for the receiver.

@param {*} [data] Optional event payload.

@param {function(Error?)} [callback]
*/
SSEBroadcaster.prototype.sendToSingle = function sendToSingle(res, eventOrOptions, data, callback) {
var self     = this,
compress = this.options.compression
assert(arguments.length >= 2, 'sendToSingle() requires at least two arguments')
assert(eventOrOptions, 'second argument must specify the event name or options')
if (typeof data === 'function') {
callback = data
data     = null
}
else if (!callback)
callback = noop
if (typeof eventOrOptions === 'object') {
assert(!data, 'only one can be provided from options and data. Use options.data instead.')
onprepared(eventOrOptions)
}
else if (typeof eventOrOptions === 'string')
try {
onprepared(prepareMessage(eventOrOptions, this.options.retry, data))
}
catch (ex) {
this.emit('error', ex)
process.nextTick(callback, ex)
return this
}
else
throw new TypeError('second argument must specify the event name or options')
function onprepared(message) {
try {
oncomposed(composeMessage(message))
}
catch (ex) {
self.emit('error', ex)
process.nextTick(callback, ex)
return this
}
}
function oncomposed(message) {
self._compress(res.req, res, function () {
// write SSE response headers if possible
if (!res._sseHeadersSent) {
res._sseHeadersSent = true
         // disable response buffering to
         // flush chunks immediately after writes
         res.socket.setNoDelay(true)

         // set SSE headers
         setHeader(res, 'connection', 'keep-alive')
         setHeader(res, 'content-type', 'text/event-stream; charset=' + this.options.encoding)
         setHeader(res, 'cache-control', 'no-cache')

         if (!res.headersSent)
             res.writeHead(200)
         else
             self.emit('warning', 'headers are already sent', res)
     }

     res.write(message, 'utf8', function done() {
           callback(null)
     })

     // force the partially-compressed response
     // to be flushed to the client
     if (compress)
         res.flush()
 });

}
return this
}
`

Hey!
I'm sorry, I only had the time now to make the requested changes, but in the latest release (0.5) I added a new method (broadcaster.send(...)) which allows you to send events to a single client. Related documentation can be found here.
Although this solution came a bit late, I honestly hope that it'll still be useful to you. Please let me know if you have any further questions, I'll be happy to answer them!

Thanks for implementing this. One question though, did you tag your release? I don't get a new version with npm update and the release history of this repository is also empty.


Is token id able to be reused if it's still not expired?

For a case, I create token id twice and they are valid time span, my question is: should the latest one be valid or both?
Is The older token id revoked?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0cace34-34bf-32f7-c857-e4d71d535a77
Version Independent ID: cdbbc4ae-5894-da21-42d7-928b3674bbd1
Content: Microsoft identity platform ID tokens - Microsoft identity platform
Content Source: articles/active-directory/develop/id-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

@NhatDuy1407 Thank you for your query . We will investigate and update the thread .

In OAuth and OIDC, bearer tokens can (and should) be used until they are expired.  Getting a new one does not imply anything about previous tokens.  If your application has a need to only accept the latest token, you can cache the "iat" time of the last-seen token and only accept tokens issued at or after that time, ratcheting forward when you see a new token.

Thanks @hpsin.
@NhatDuy1407 Closing the thread now. Feel free to tag me in your reply if you have any question.


Removed the TaskLauncherLocalSinkProperties class.

LGTM; merged as https://github.com/spring-cloud/spring-cloud-stream-app-starters/commit/4191cdc3167838dc36ae379e86cad4d3cd4eee5e


Add and translate new strings to PT-BR

Hi @creed-victor please merge this one. Thanks.

Hi @creed-victor please merge this one. Thanks.


Gpu Stable defussion dosent work

I have an intel Arc A770 and when I use the gpu option for some reason it uses 100% of my cpu and when I use the cpu option it does not use 100% of my cpu.

With or without having a model-cache and/or OpenCL configured - the first run includes compilation of the OpenCL-kernels; depending on how powerful the underlying HW is this can take several seconds or "much longer" (e.g. 30s, 60s or even longer).
When having a cache configured then only the first start is delayed by the OpenCL-kernel-compilation; consecutive runs will used the cached kernels.
Otherwise each run will require compilation.


Snakemake

Description of proposed changes
This pull request replace the bin/ingest-{database} scripts with a unified snakemake pipeline.
The rules have been written to keep the same process as before, putting emphasis on the commonalities between the treatment of gisaid and genbank data (currently the only 2 implemented database).
The slack notifications have also been pushed outside of bash scripts to make them more explicit and easy to handle from the snakefile (although for the sake of code clarity, they still employ the bin/notify-slack).
The rules DAG can be printed in image form with a command such as :
snakemake --rulegraph all_then_clean | dot -Tsvg > dag.svg

and then visualized using your favorite image viewer.
Testing
Testing through the full ingest-gisaid and ingest-genbank pipeline is advised.
Provided these change replace the actual scripts, the git actions will not do and
one should utilize the following instead to realize the pipelines :
snakemake gisaid_then_clean

snakemake genbank_then_clean

For the script to work, the environment should contain the following variables:

"S3_SRC"
"GITHUB_REF" # for instance "refs/heads/master"
"GISAID_API_ENDPOINT"
"GISAID_USERNAME_AND_PASSWORD"
"SLACK_TOKEN" # token to post on slack channel
"FETCH"  # set to 1 to trigger download of data from the database

Thanks for this work @WandrilleD!

Provided these change replace the actual scripts, the git actions will not do and
one should utilize the following instead to realize the pipelines :

I think we can stick with github actions to trigger this workflow to run on s3. The difference here is that now it's in snakemake, so we'll have to change this bit https://github.com/nextstrain/ncov-ingest/blob/master/.github/workflows/ingest-gisaid-master.yml#L37-L45 to run the snakemake workflow, something similar to:
        nextstrain build \
          --aws-batch \
          --no-download \
          --image nextstrain/ncov-ingest \
          --cpus 8 \
          --memory 15GiB \
          --exec env \
          . \
            envdir env.d snakemake gisaid_then_clean

Thanks for this work @WandrilleD  - this seems immensely useful. If we run this pipeline through locally at the same time as running the 'normal'/current ingest, would we expect all outputs to be identical? (Would that be a good way of testing?)

I think FETCH would be better as a config variable. This could be passed in a command line argument to snakemake as
snakemake gisaid_then_clean --config fetch=source
or
snakemake gisaid_then_clean --config fetch=S3
or similar.

I think I'd prefer to have a rule ingest that produces all the input for the notify and upload rules such that we can separate running the pipeline. The output of that rule could then be in the input to the notify rule.
I am not too familiar with the envar directives in snakemake. can one make them rule specific? because currently it wants you to specify a GISAID_URL if you want to do the genbank ingest.

Thank you for your reviews.
I think that with these commits I have addressed most of your comments.
@eharkins from the test that I have run the content of snakemake tokens (such as {params.slack_token} for instance) are revealed in the logs (especially with option -p) whereas the content of an environment variable would not be revealed. This is one of the reason I use a environment variable for the slack token.
regarding the github action, I defer to your judgment as I far no practical experience with these.
Taking into account the new configuration of the script, it would now look like :

nextstrain build \
          --aws-batch \
          --no-download \
          --image nextstrain/ncov-ingest \
          --cpus 8 \
          --memory 15GiB \
          --exec env \
          . \
            envdir env.d snakemake gisaid_then_clean \
               --config fetch=yes gisaid_login='${{ secrets. ... }}' gisaid_endpoint='${{ secrets. ... }}' slack_token='${{ secrets.SLACK_TOKEN }}'

@emmahodcroft you are correct! The only change would be that the standard output of transform-gisaid previously went to a temporary file names named : "flagged-annotations-XXXXXX" whereas now it goes to "data/gisaid/transform-log.txt" (the name is more indicative of what this file means, in particular across the different data-sources).
@rneher  envar cannot, AFAIK, be made rule specific. I tried something by having the used set them using --config, with an error popping up when a rule is called without the proper elements set.
Also, there is now an ingest_gisaid and ingest_genbank rule.

Thanks, Wandrille. I pushed this branch to nextstrain/ncov-ingest such that CI runs and we can do trial runs more easily:
https://github.com/nextstrain/ncov-ingest/tree/snakemake

Closing since Snakemake has been implemented in #231


On the preprocessing of the notes

Hi, love what you're doing here.
wanted to ask two questions:
1- Is there a particular reason for choosing this specific preprocessing?
https://github.com/JoakimEdin/medical-coding-reproducibility/blob/24e615b10e84ece56dd71f8be4a0811c924761ff/prepare_data/prepare_mimiciv.py#L78-L88
2- I also wanted to ask about the stratification you used, I'm working on sequential disease prediction task ( predict next visit diags from previous visits ). so the targets are the next visits ICDs, and I wanted to have your thoughts on whether the stratification you used could be adapated to what I'm doing.

We chose this pre-processing because it is what previous studies used. In the paper I'm working on, I'm not doing any pre-processing except for truncating the documents to a maximum length. I found this to work well for PLM-ICD. I chose the minimum target count of 10 because I could then create a split where all the codes were in both the training and test sets. I do not think this is necessary, though, as long as you are calculating the F1 macro score as described in the paper.
I think I would just create random splits. Stratification is nice if you want to make sure that you have a similar class distribution in your training, validation and test set. I have recently decided that this isn't that important as I originally thought, although it doesn't hurt. Do you have any specific reasons for why you want the same class distributions? If yes, I'm sure we can figure out a way to adapt the method.

Thanks a lot for the quick reponse!

Understood, I'll take that into consideration.
It is for the same reasons you've stated. The issue with simply omitting those is that we're not getting a true representation of the capabilities of the model. ( we're already doing that by setting a threshold of mimimum 10 counts).
In my task, I should perhaps give even more consideration to this, because we cannot simply ignore possible outcomes of next visits because they are rare.

Thanks again!

No problem! Looking forward to see your research!


Feat/erc4626 share price oracle automation forwarder

Yeah so LegacyCellarAdaptorForRye is a bit weird. The original test relies on blockchain state from a couple months ago. But the new Chainlink Automation V2 contracts are not deployed at said block. So in order for the new share price oracle contracts to work we need a much more recent blockchain state, but this new blockchain state already has the RYBTC, RYE integration completed, so the test state is no longer valid.
Because of this the test is commented out. In the future we might completely remove this test, but for now it has been left commented out, so that it can be referenced.


Le 0.13

Brings in knative/pkg#1142 and knative/pkg#1145:

correct behavior when leader election config doesn't exist
fix problem with invalid prometheus metrics names with some controllers

Release Note
- correct behavior when leader election config doesn't exist
- fix problem with invalid prometheus metrics names with some controller names

Wrong branch :(


Automatic offset tracking for stream queues

WHAT is this pull request doing?
Adds broker tracking of consumer offsets in streams if no x-stream-offset is provided by the consumer. Does not track if the consumer tag is generated by the broker.
✅  When to run cleanup_consumer_offsets?
✅  IndexError when trying to cleanup if msg_size => segment_size
HOW can this pull request be tested?
Run specs

What happens with consumer_offset_capacity is reached? MFile doesn't auto expand.

Fixed [here](implemented here)

@carlhoerberg Performance seems pretty similar with both solutions, maybe even slightly quicker with append-only (I increased file size to Config.instance.segment_size to make sure we don't have to constantly GC). So I think we can go with that solution 👍

Cool! Havent read all code but looks like the file is still expanded? Is that nessecary? Shouldnt a GC be issued instead? The file size should be a minimum segment size yes, but larger if there are many consumers we are tracking for, so calc the size of the file after GC and the capacity should be a multiple of that, say 1000-10000 larger or so, so that the offset of each consumer could be updated that many times without causing a new GC.

Cool! Havent read all code but looks like the file is still expanded? Is that nessecary? Shouldnt a GC be issued instead? The file size should be a minimum segment size yes, but larger if there are many consumers we are tracking for, so calc the size of the file after GC and the capacity should be a multiple of that, say 1000-10000 larger or so, so that the offset of each consumer could be updated that many times without causing a new GC.

Yeah, it will try to compact the file first (only keep the latest offset for each ctag). If the file is still full after that (i.e. there was nothing to compact) it will be expanded. Probably safer to set the capacity to a multiple of tracked ctags as you say though. Will look at that tomorrow!
        cleanup_consumer_offsets if consumer_offset_file_full?(consumer_tag)
        expand_consumer_offset_file if consumer_offset_file_full?(consumer_tag)

Cool! Havent read all code but looks like the file is still expanded? Is that nessecary? Shouldnt a GC be issued instead? The file size should be a minimum segment size yes, but larger if there are many consumers we are tracking for, so calc the size of the file after GC and the capacity should be a multiple of that, say 1000-10000 larger or so, so that the offset of each consumer could be updated that many times without causing a new GC.

@carlhoerberg Added this. Do we need to set some form of max size for the offsets file? capacity could in theory be very large if there are many consumers (and/or if ctags are long).

@carlhoerberg added some replication for the consumer offsets file. Not really sure what the best approach is for when we replace the file during compaction though. Just replace_file after we've done the replace? Or do we also want to stream writing to a temp file and then replace the current (and then deleting temp file)? We don't have support for renaming files in replication now I guess

Ah, well spotted, can implement replace file on the client side with write-to-tempfile/rename in another PR


New flag for prepare_bigquery to only include top move

run time 14s vs 55s
local json file is 28.1 MB vs 486 MB (6%)
bigquery table is 8 MB vs 1.09 GB (0.7%)
upload is 48s vs ~200s

Pros for merging this and using this data in bigquery (https://github.com/tensorflow/minigo/issues/129)

Smaller data footprint means we can upload all games today (instead of just the 5% holdout games)
Data about the top 10-15 moves isn't used by any current scripts
Runs fast enough (5 minutes every ~1.7 hours) that I can put it on my rsync

Cons

We'll have two tables (moves and top_move_only)

/retest

will merge after comment is addressed


Add python to docker container

Tickle Travis

(i'm not sure if travis has been turned on)

let's try that again :-)

A little too verbose.

Okay, here's my list of suggested changes before we merge this:

In /opt, add symlinks like /opt/2.7 -> /opt/2.7.11
As the comment above states, factor out the Python dependencies into an envvar so that the yum install and yum erase commands don't get out of sync
Make sure that the -devel packages for all the packages mentioned in the anaconda list here are installed
/opt/3.5/bin/pip install auditwheel; ln -s /opt/3.5/bin/auditwheel /usr/local/bin/

I'm sure there will be more tweaks later but with those changes I think we'll have a pretty credible image that people could start using.

Oh, I guess we should install patchelf too.

sry getting kind of behind on my other work -- if you want to take over this PR, that's fine. You should be able to get patchelf from pip install pypatchelf FWIW.

No worries, I totally hear that :-) I'll wait and see how much time I have
too...
On Mon, Jan 18, 2016 at 1:55 PM, Robert T. McGibbon <
<EMAIL_ADDRESS>wrote:

sry getting kind of behind on my other work -- if you want to take over
this PR, that's fine. You should be able to get patchelf from pip install
pypatchelf FWIW.
—
Reply to this email directly or view it on GitHub
https://github.com/manylinux/manylinux/pull/2#issuecomment-172664805.

--
Nathaniel J. Smith -- http://vorpus.org

Okay, I think this is ready to merge.

Hmm. One thing is that we have a bunch of different compilers installed. gcc 4.1, gcc 4.4, and gcc 4.8. maybe too many.

Great! Thanks for the work and for putting up with my pickiness :-)

Can you make a dockerhub or quay.io account / name for the image?

Oh yeah, good call. quay.io/manylinux/manylinux , send me your username if
you want permissions
On Wed, Jan 20, 2016 at 12:22 PM, Robert T. McGibbon <
<EMAIL_ADDRESS>wrote:

Can you make a dockerhub or quay.io account / name for the image?
—
Reply to this email directly or view it on GitHub
https://github.com/manylinux/manylinux/pull/2#issuecomment-173348673.

--
Nathaniel J. Smith -- https://vorpus.org http://vorpus.org


chained hotstuff?

hi, thanks for your wonderful work. I have a question for you guys. this is a chained hotstuff implementation? thanks.

Yes :)

cool. did you benchmark the implementation? now  it can be used for building application?

Closing this issue due to inactivity.


Allow predict() to potentially return RaggedTensor

Currently, predict() throws an error if the batches it's concatenating have variable sizes. This is a headache in NLP in particular, because batches with variable sequence length dimensions are very common. This change maintains the current behaviour when batches can be concatenated into a dense Tensor, but when they can't it attempts to return a RaggedTensor instead, while inferring as many constant inner dimensions as it can.
I discussed this with @fchollet already and he approved in principle, but please let me know if there are any issues with my implementation - I know tf.ragged.constant in particular can have a very long runtime if you're not careful with the inputs, but I believe it's efficient when the inputs are Numpy arrays.

Should be ready after tests are re-run!

Please shorten lines to be within 80 characters.

Please do this throughout the code change! Lots of very long lines still :)

Sorry! Should be fixed now.

Thanks! I'm happy for it to be merged once you're happy and the CI is green.

Unfortunately I'm seeing some failures in distributed tests, e.g. here:
"keras/distribute/distribute_strategy_test.py", [line 1227], in test_fit_eval_and_predict_with_optimizer
    model.predict(get_predict_dataset(distribution), steps=2)

The error:
"keras/engine/training.py", [line 3279], in potentially_ragged_concat
    non_batch_shapes == non_batch_shapes[:1], axis=0)
...
Invalid reduction dimension (0 for input with 0 dimension(s)

Are you able to reproduce this?

Best I can tell, it's likely just a matter of checking for empty arrays and skipping those.

I wasn't able to reproduce that running the tests locally, but that's probably my fault! I've made a change that should fix it, and I'll see if I can get the tests working too.

I've found the origin of the issue, and also why the failure didn't show up on CI: it only occurs with TF 1. We don't run TF 1 tests on CI here on GitHub. I'll fix the issue and merge.

Awesome, thank you!

That's great, thanks for your help throughout!


add environment vars that look like docker links env vars

Would it make sense to add env vars for the service discovery that look like docker links env vars?
https://docs.docker.com/userguide/dockerlinks/#environment-variables

Maybe, but I'm not sure. I never really understood why Docker puts the port number inside the variable name, making it very difficult to find out what the port number of a dependent service is, unless you use a regexp on the environment variable names?
Also, Maestro supports linking containers together already via Docker links, in which case Docker itself will add the environment variables that you need.

Well, one nice thing is the other frameworks seem to be creating compatible env vars inside their containers. It would be nice to get maestro on that train also.


Universal compatibility

When using this package with Angular Universal it will log errors on the server as document is not available server-side. Also, preloading the SVGs server-side have no advantage.
The changes to be compatible with Angular Universal are in summary:

Avoid SVG requests server-side.
Wrap code the uses or modifies the DOM to run in the browser only.

Yes, you are right.
However, the problem with loading them server-side (and keep a single codebase) is the inability to cast them to an SVG Element, .i.e., doing this code server-side.
const div = document.createElement('DIV');
div.innerHTML = svg;
return <SVGElement>div.querySelector('svg');`

The only way I found so far using a single codebase is using this.renderer.createElement('svg') to create a pristine element and perform subsequent calls to manually extract and parse the attributes and children of the SVG string to this new element, but I don't think this approach is good.
The best approach I found (given the current angular universal config) would be having two codebases with a simpler server only version. The server version would only treat the SVGs as pure strings and inject them binding to the property innerHTML as in `<element [innerHTML]="svg">".
Changing the stretch property would still need to be done by string manipulations if to be performed server-side (but I think this step is unnecessary).
Currently Angular Universal does this replacement of files with a config in the angular.json,  for example, with environment files:
"server": {
          "builder": "@angular-devkit/build-angular:server",
          "options": {
            "outputPath": "dist/server",
            "main": "src/main.server.ts",
            "tsConfig": "src/tsconfig.server.json"
          },
          "configurations": {
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts", <-
                  "with": "src/environments/environment.prod.ts" <-
                }
              ]
            }
          }
        }

The downside of this approach is that this config is for angular-cli only projects.
Those with webpack would have to perform the replacement themselves.
Do you think this is a good approach?

By two codebases do you mean literally two code bases, or do you mean two flows in the lib/src/svg-icon-registry.service.ts? So, keep the code as is in the pull request guarded by isPlatformBrowser(this.platformId) and if not, treat SVGs as pure strings and inject them into the HTML as you propose?

I mean two code bases, but for the service only.
I've been taking a look at how other libs treat the server-side rendering part, as in https://github.com/salemdar/ngx-cookie.
With Angular Universal there is an AppServerModule that can be used to provide an alternative service class, so the two implementations (service only) could stay separated. I'm still not sure how to inject the retrieved SVG string as HTML server-side while keeping the component consistent.
I will do some testing with this and get back with the results.

Good news!
I dug deeper to find a simpler way and make less changes to the code.
I changed the way the services is imported as suggested by the Angular 6 docs to define singletons: https://angular.io/guide/singleton-services.
The only caveat of the for the server is the need to provide a base url for relative request paths.
In my tests I added it in the AppServerModule:
[...]
  bootstrap: [AppComponent],
  providers: [{provide: 'SERVER_URL', useValue: 'http://localhost:4000/'}] <---
})

Please take a look at the code and give me your thoughts.

It looks like from reading over the code that the SERVER_URL would only be necessary if using Universal though, right? If so, that seems a reasonable tradeoff to be able to use the svgs, right.

Yes, the SERVER_URL is only needed server-side.
I was banging my head to find how to inject the dependencies on SVG_ICON_REGISTRY_PROVIDER.
With help from the link you posted I got it working and restored the code from the provider.

Done :+1:.

Thanks again for your work on this. v7.0.0 with your work to support Universal now should be available on npm.


Rethrow originally caught error in handleReject

see: https://github.com/pburtchaell/redux-promise-middleware/pull/101

This will prob require a new major release since the reject API has changed. @pburtchaell, let me know about your thoughts on creating the documentation for that.

Coverage remained the same at 100.0% when pulling 46075f05ec83821e29f8901f3f992ba501005a1a on ianks:rethrow-caught-errors into ee8bba717f61861b399b9df764de22439dddfd68 on pburtchaell:master.

Thanks @ianks. I will take a look this week.

Sounds good. As a note, I am currently using this branch in production and it seems to be working great! Having proper error messages is a huge win for development.

@ianks I reviewed this tonight and I think we should be able to merge. I'll do this tomorrow when I have time to write the release notes. 😄

We (or I) will also need to update the documentation and README before releasing this.

@pburtchaell Either way is fine with. It might be better if you handle the documentation since I cannot do it tomorrow; otherwise I could do it Wednesday.

Hi, is there any precise release date?
Right now, guess I can only solve this problem by copying source code to my repo :(

@Imior, instead of copying the source code, It is possible to have npm install a specific branch on a repo. Checkout the npm documentation.
As far as release date, I'd like to say possibly today, but this weekend at the latest.

hey @Imior I am using this in my package.json
"redux-promise-middleware": "https://s3-us-west-1.amazonaws.com/adhawk-random-public/redux-promise-middleware-4.0.0.tgz",

Thanks for replies~ @pburtchaell  @ianks
I've tried to use Github urls as dependencies, for example:
"redux-promise-middleware": pburtchaell/redux-promise-middleware#a68cd97136ad42fee68b15849745f34cdda4ffdd

Maybe be because of  .npmingore, there is not dist or src directories :

Do I have to install from built files served by myself?

the library has to be built, you can just use the tarball that I linked
earlier
On Thu, Aug 18, 2016 at 10:20 PM Zhuoran Li<EMAIL_ADDRESS>wrote:

Thanks for replies~ @pburtchaell https://github.com/pburtchaell @ianks
https://github.com/ianks
I've tried to use Github urls as dependencies, for example:
"redux-promise-middleware": pburtchaell/redux-promise-middleware#a68cd97136ad42fee68b15849745f34cdda4ffdd
Maybe be because of .npmingore, there is not dist or src directories :
[image: 2016-08-19 9 47 18]
https://cloud.githubusercontent.com/assets/1232693/17796301/f207e77a-65f1-11e6-9cd3-ffc0fb352af0.png
Do I have to install from built files served by myself?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pburtchaell/redux-promise-middleware/pull/105#issuecomment-240910924,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJmeL1CLE0iOwd_OgYrMK3KHf0sfUclks5qhRL3gaJpZM4Jfa-_
.

@ianks ok, thanks a lot~

This is released as<EMAIL_ADDRESS>Thanks! 😄


Scale the timeline of an animation

Is there a way to adjust the speed of an entire animation? For example, if I wanted an animation to animate at half speed, or double speed.
Something to the effect of, mySpine.currentAnimation.timeScale = .5;
Thanks!

 ;)
Perfect! Thanks!


Update readme.md with correct url for tutorial

URL for post on using Terraform with Linode currently returns 404
This PR updates URL so that it points at current link

Hi!
We now have https://github.com/terraform-providers/terraform-provider-linode as an official Linode provider which includes the original work of @btobolaski and the members of LinodeContent.


operator-sdk test local ./test/e2e has fixed the name of the files instead of looking for types

Bug Report
The command operator-sdk test local ./test/e2e --namespace $NAMESPACE is looking for an specific name of rules files names instead of looking for types.
What did you do?
When we run operator-sdk test local ./test/e2e --namespace $NAMESPACE it will look just for
deploy/service_account.yaml, deploy/role.yaml, deploy/role_binding.yaml and deploy/operator.yaml and if the operator is cluster scope for example we will have deploy/cluster_role.yaml, deploy/cluster_role_binding.yaml. Also, we could have other roles as well.
What did you expect to see?
The ./test/e2e run any *role file for example.
What did you see instead? Under which circumstances?
If we have more roles files or use other names, for example, cluster_role.yaml to make clear the scope it will not work.
 $ operator-sdk test local ./test/e2e
INFO[0000] Testing operator locally.
WARN[0000] Could not find role manifest: (open deploy/role.yaml: no such file or directory)
WARN[0000] Could not find role_binding manifest: (open deploy/role_binding.yaml: no such file or directory)

Environment

operator-sdk version:
operator-sdk version: v0.8.0, commit: 78c472461e75e6c64589cfadf577a2004b8a26b3

Possible Solution

Looking for any file with the end _role.yaml.
Here is the point: https://github.com/operator-framework/operator-sdk/blob/4564a35d12c7a9b2d9873751084c1a38879a4061/internal/util/yamlutil/manifest.go#L73

Yes because it assumes the operator to be generated with operator-sdk, we use this pattern all over the place in operator-sdk.
cc @AlexNPavel

Hi @LiliC,
Thank you for check it.  However, after use, the operator-SDK to create the project users will grow it and has many needs which may lead them to have more than one rule file and more names because of it.
Are not we suggesting for them use operator-sdk test local ./test/e2e --namespace $NAMESPACEoperator-sdk test local ./test/e2e --namespace $NAMESPACE to do the e2e test for the projects as well or just the scaffold?

The SDK test framework is designed to work based on the structure generated by the SDK, so by default we use the manifests that the SDK generates. This should work for both cluster scoped resources and namespaced resources as the filenames are supposed to stay the same (see this doc for changing a namespaced resource to a cluster scoped one: https://github.com/operator-framework/operator-sdk/blob/master/doc/operator-scope.md#operator-scope; older versions of the SDK would generate cluster scoped resources using a flag, but newer version require you to do so manually. I believe the autogenerated cluster scoped resources made by the SDK used a slightly different name, so those files may need to be renamed).
If you have a different manifest structure, you can use the --global-manifest and --namespaced-manifest flags to specify a single manifest files containing all your resources. Creating one is shown briefly in the doc: https://github.com/operator-framework/operator-sdk/blob/master/doc/test-framework/writing-e2e-tests.md#running-go-test-directly-not-recommended

Hi @AlexNPavel,
Thank you for your reply. Following few concerns and questions. Please, could you help me with?

Regards

This should work for both cluster scoped resources and namespaced resources as the filenames are supposed to stay the same (see this doc for changing a namespaced resource to a cluster scoped one: https://github.com/operator-framework/operator-sdk/blob/master/doc/operator-scope.md#operator-scope;

The doc does not say that we should not change the name the file. IMHO: it just makes clear that we need to change the type of RBCA. Should not make more sense has a cluster_rule.yaml instead of rule_yaml in order to make clear the scope used/applied on it?

User is able to have 1 to Many rules files. So, should not make sense change the e2e to apply any file in the deploy dir?

I am /remove-lifecycle stale since I think it still valid and if we are able to do it will be helpful to allow the project to be compatible with other structures/layouts as well. Hi @hasbro17 and @joelanford WDYT? should we keep this one or close it?

/remove-lifecycle


Add back method support for PersistentStateFacets

Hi there,
The changes in #105 got lost during the migration to orleans 7.0. This returns all the changes on top of main branch
Original issue: #55

This would be great to see merged into the main branch with Orleans 7 support.
Our team is currently blocked on quite a bit of Test implementation with this package due to our use of PersistentStateFacets
Would add a vote if I could.


Add engine encode

Motivation

Modifications

Checklist

[x] Format your code according to the Contributor Guide.
[x] Add unit tests as outlined in the Contributor Guide.
[] Update documentation as needed, including docstrings or example tutorials.

thanks!

Fix https://github.com/sgl-project/sglang/issues/1993#issue-2648179060


Sidebar: Different way to implement? [Feature request]

Right now, sidebar syntax looks like this:
<Sidebar.Pushable as={Segment}>
          <Sidebar as={Menu} animation='overlay' width='thin' visible={visible} icon='labeled' vertical inverted>
            <Menu.Item name='home'>
              <Icon name='home' />
              Home
            </Menu.Item>
            <Menu.Item name='gamepad'>
              <Icon name='gamepad' />
              Games
            </Menu.Item>
            <Menu.Item name='camera'>
              <Icon name='camera' />
              Channels
            </Menu.Item>
          </Sidebar>
          <Sidebar.Pusher>
            <Segment basic>
              Application Content
              <Image src='/assets/images/wireframe/paragraph.png' />
            </Segment>
          </Sidebar.Pusher>
        </Sidebar.Pushable>

Is it a possibility to add a way to implement sidebars, so that you could load them from external sources, for example, or render most of the page (the pusher content) without rendering? I would have asked the question on Gitter, but it doesn't look like anybody has answered any questions on there recently.

@nebrelbug I am not sure I understand what you are asking here. Maybe a little more context of what you are trying to achieve? I am making a guess here based on what you are asking... that most likely you'd end up making another component and wrapping the Sidebar component to feed the data and props down that you need.

I was hoping that there was a way I could do something like the following:

My Cool page!

And so on, so I wouldn't have to render the main body of my page with HTML. I could just render Sidebar to 'mySidebar'.

@nebrelbug I guess technically there's nothing stopping you from rendering another React tree this way if you really wanted to. You could do it right now. But if

 is within your main React tree, you cannot do it. That's not how React works.

My Cool page!

And so on, so I wouldn't have to render the main body of my page with HTML. I could just render Sidebar to 'mySidebar'.

Rendering separate applications into either mySidebar or app should work in the above. The example below would not. You'd be manipulating the DOM directly inside the app tree when React expects it to look a certain way. This is not a function of SUIR. It's how React works.

My Cool page!

And so on, so I wouldn't have to render the main body of my page with HTML. I could just render Sidebar to 'mySidebar'.

I guess what I was asking was if SUIR would consider creating a separate application specifically for use without the pusher, one that could just render into "mySidebar" in the first example, without having to wrap the rest of the page content. Is that a possible feature?

@nebrelbug do you want to just render the markup for the Sidebar alone? If so, you can already do that. Just include visible prop on the Sidebar component and it will be shown. The Sidebar.Pusher component is not required. Sidebar can be used independently.

I was hoping to be able to toggle the Sidebar too, and have it push page content. I just would prefer not to have the page content / pusher content wrapped in a div. Is that possible?

@nebrelbug If you want all of the same functionality but different markup, then that would require different CSS. The active styles for the Sidebar.Pusher and Sidebar come from active classes. They are not applied inline to those containing components. If that is what you want you're best writing your own JS to toggle transition styles to your off canvas sidebar and body content. Modifying the markup/styles of SUI is out of scope for this particular project.


Filter toggle for noGenreFilter & noRoleFilter views

This issue is a sort of follow-up to #147. With useUnifiedArtistsList => 0, groupArtistAlbumsByReleaseType => 0, noGenreFilter => 0, noRoleFilter => 0, I can confirm that, under All Artists → [An Artist] → [An Album] - [Another Artist], LMS's default UI shows only the tracks that [An Artist] featured in for [An Album], and under All Artists → [An Artist] → No Album - Various Artists, LMS's default UI shows only [An Artist]'s singles. In contrast, Material skin shows all tracks, highlighting the tracks the artist features in. Sometimes, there are hundreds of tracks on an album (e.g. No Album), and the highlighting isn't much help. A toggle in the browse panel to switch between filtering & just highlighting would be great.
Additionally, with groupArtistAlbumsByReleaseType => 1, the default UI offers Album Artists → [An Artist] → All Releases. While I appreciate Material skin's grouping of releases into one big list without having to navigate extra menus, a similar toggle in the browse panel to switch to & from an All Releases style ungrouped view would also be great. It sucks having to switch a global setting before & after every time you want to look chronologically at the middle of a large discography of thoroughly mixed released types.

Use Material's 'Filter album tracks' setting to change this behaviour.

FYI the next (4.6.0) release will contain an "All releases" entry in the "..." menu which will shown a combined list/grid.


Kanban board setup

The GitHub project Link
Our group consists of three persons:

Amin Alizadeh (team member 1) [Issues from 1 - 9]
Agneta Pupienyte (team member 2)  [Issues from 10 - 18]
Tanmayi Manku (team member 3) [Issues from 19 - 27]

The issue 28 is a group task and it's assigned to everyone

STATUS: APPROVED 🟢
Hi @M-AminAlizadeh, @tan12082001, and @agneta1991👋,
Your project is complete!  There is nothing else to say other than... it's time to close it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Immersive-Study-First

#01
Itens removidos:

ícones de e-mail, telefone, e time;

Itens alterados:

Estrutura HTML do arquivo index;
Estrutura CSS do arquivo style;

Itens adicionados:

Novos ícones de redes sociais, tecnologias, botões e etc.

#1
Commit:
Day-01-coding
Target: First mobile technique

[x] The initial layout is complete;
[x] Icons was positioned correctly;
[x] Apparently, there are no fails.

Next target: Desktop version and responsive behaviors
HMAP - Henrique Matheus Alves Pereira
@HenriqueMAP

Commit
Add: Desktop and Mobile Version
Responsiveness, improved layout, new icons, links inserted in the icons, Roboto font added, updated color palette.
"Styles" and "index" files have been completely modified.


FileLock racing issues

I see that you have your own implementation of FileLock instead of using the native fcntl.lockf. I believe the current implementation is racy:
    def __enter__(self):
        # no lock when entering the function, so 2 threads/process can enter at once
        if os.path.exists(self.path):
            self.wait_for_unlock()
        # another thread/process can create the file at this point, since nothing is locked yet
        with open(self.path, 'w'): # lockfile then gets overwritten here
            pass
         #at this point, two threads are running simultaneously

    def __exit__(self, type, value, traceback):
        os.remove(self.path)
        # since two threads "acquired" the lock,
        # one of them will fail trying to delete the file

fcntl.lockf will have the kernel ensure thread-safety for you, but I think it's limited to posix and I'm also not sure if it's supported in distributed filesystems like the typical GPFS's we find in clusters.

Thanks for catching this!
I will see if I can change to fcntl.lockf easily.

Ok, I had a bit closer look and I think I can do the following:
I need the pattern
with FileLock(some_lock_file) as :
    do stuff

that delays starting the code in the with stating until the lock is released.
I couldn't find __enter__ or __exit__ methods for lockf (which just wraps a system call I guess),
so I cannot use it directly.
I could use it in the FileLock implementation though. lockf throws an OSError if the lock fails. So ths should work:
while True:
      try:
            f = open(some_lock_file, 'w')
            fcntl.lockf(f, fcntl.LOCK_EX | fcntl.LOCK_NB)
            break
       except OSError
           sleep(10)

I think this should remove racyness, correct?

Interesting, look what I found :D
https://github.com/ilastik/lazyflow/blob/master/lazyflow/utility/fileLock.py

This does more or less the same thing as I did though and unlinks the lock:
https://github.com/ilastik/lazyflow/blob/master/lazyflow/utility/fileLock.py#L162
So I am not sure if it removes the racyness.
Also, lockf is only posix and doesn't work for some distributed filesystems (I actually investigated this on the c/c++ side a while ago for z5), so I don't think it's a good solution.

Aha, nice findings there! So, it's almost the same as what you're doing, but it does the create_if_there_is_no_file in a single shot, since (at least on linux)  open() is guaranteed to be atomic. I'm still not sure if this is guaranteed on GPFS, but it already looks better than lockf, indeed =)

switched to lazyflow impl, thanks for raising this!


(Suggestion) New texture?

item.zip
I redrew the textures of enchantment stones, use it freely if you like!<3

Thank you very much for sharing. 🙂 I think they look very cool and from an artistic perspective definitely better than mine. Because of that and because I appreciate you sharing them I want to add them to the mod. But I am torn, because I am not sure if I like them in the context of the mod. With mine I can imagine more easily how you would attache them to a tool... I don't know. For now I will add a link to here to the mod page and think about it again later. Either way thank you again.

What about adding a build-in resourcepack?

I didn't know you could do that.

I didn't know you could do that. 😅

resourcepack.zip


Add blurb before domains

I also added a blurb before the WG spotlights. The crates.io image comes from the rust-lang/crates.io repo (public/cargo.png). Also, I'm not familiar with the stylesheets being used, so please let me know if I am using the wrong classes or something.
EDIT: as per https://github.com/rust-lang/beta.rust-lang.org/pull/501#pullrequestreview-180441720 , I am just adding a the blurb for now...
r? @aturon

Oops... forgot to include a screenshot

but i dont think the crates.io callout works. for the sake of small PRs perhaps we can make this PR just the sentence, and figure out crates.io in another issue?

sure, perhaps we can continue discussion on #458?
I removed all but the sentence.

@aturon can you review the sentence? i think we may want some tweaks but i'm going to leave that in your court :)


Accessibility audit

Initial a11y audit

Global:

Language switch - Form elements do not have associated labels
Menu button (hamburger) does not have accessible name
Html lang attribute
Skip to the main content (grid) button
Skip to contact footer
Focus indicators - check and fix

Main page:

Check and fix alt texts
Dice image - link name (aria-label)
Double main landmarks

Blog:

Heading are not in a sequentially-descending order
Check alt texts

Study:

Heading are not in a sequentially-descending order
Link text ("Link")

Uses:

Check alt text

Books:

Check book alt texts
Possible headings

Statistics:

role-img-alt (alt text for chart images)

Projects:

Alt text

Footer:

Alt texts for icons


feat(sdk)!: change default network to mainnet

Issue being fixed or feature implemented

If network is not specified, by default JS SDK connects to testnet. Since Platform is already deployed to mainnet we should change this.
What was done?

Updated JS SDK to connect to mainnet by default.

How Has This Been Tested?

None
Breaking Changes

Now if network is not specified, JS SDK will connect to mainnet.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
[x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

This seems to cause a lot of tests to fail @shumkov

@coderabitai review


Feature request: set default line width

Would be really good to be able to set the default line width for all line graphs rather than for each item.
Even more important when adding items from the UI where it's not possible to set the line width.

You can configure line width for dynamically added entities using entityOptions. See here.

Thanks, I spent ages in the documentation and still missed that! I would still like to be able to set a default line width though, I do find the default to be too wide and I never mix widths on a graph. However, it's a nice have rather than need so I'll close this and leave the idea in the back of your mind....

In that case, you're welcome to open a feature request for that ! No guarantees on when/if it will make it into a release, but this would be a very simple addition.


No way to log metrics in MLMPretrainModule

Currently MLMPretrainModule doesn't log anything but losses. To add metrics, such as AUROC or F1Score, one has to copy & modify the mlm_loss function. There is no other way to extract this model's predictions! The same goes for MLMNSPModule.
IMHO, the class would be better off with a shared_step, like the one in ABSModule. An even better option would be to subclass ABSModule (and make ABSModule support single-argument shared_step), or maybe make a separate UnsupervisedABSModule.

Excuse me, seems I misunderstood: your implementation you have is actually quite far from ROBERTA, so no such metrics can be logged. Would be great if this was reflected in the docs. Closing this issue, my mistake.

Thanks for the question. Now I see that "ABSModule" is not a very good solution. There are a few common methods among modules that make sense to put in an abstract class. We plan to gradually remove "ABSModule".


Gradle 7.6: Dependency verification is failing for latest version of a dependency even though it should not be resolved

Expected Behavior
If a project

is using dependency verification and
it already has kotlin-compiler-embeddable:1.7.22 accounted for and
it sets up a configuration like below (with a constraint with open upper bound)

buildscript {
    repositories {
        mavenCentral()
    }
    dependencies {
        classpath("org.jetbrains.kotlin:kotlin-compiler-embeddable") {
            version {
                strictly("[1.4.0,)")
                prefer("1.7.22")
            }
        }
    }
}

it should simply resolve version 1.7.22 in the dependency tree.
Current Behavior
Dependency verification fails saying that 1.8.0-RC metadata (or whichever is the current latest) is not accounted for.
Context
I'd really want to use dependency verification. Adding the latest version is a no-go, as the build is not reproducible. The workaround it to turn off dependency metadata verification, which is not ideal either.
Steps to Reproduce
gradle-dependency-verification-bug-issue-with-latest.zip
The self-contained example can be run with ./build.sh.
Your Environment

Gradle 7.6

Thank you for providing a valid reproducer.
The issue is in the backlog of the relevant team but the existence of a workaround makes it non-critical so it might take a while before a fix is made.

Workaround is do a key base trust from Kotlin so dependency verification trusts all artifacts.
verification-metadata.xml
<trusted-key id="6f538074ccebf35f28af9b066a0975f8b1127b83" group="org.jetbrains.kotlin"/>

Another workaround is to use a non-range version.
We will be looking whether the latest 6.x or latest 7.x still reproduces the issue.

Hi @xaviarias! Thank you for providing a better workaround (the key base trust) than mine :)

Gradle versions 6.9.2 and 7.6 also fail on dependency verification.

@xaviarias Sorry for the confusion, I have absolutely no idea why I wrote Gradle 6.8. It was supposed to be 7.6. I've updated accordingly.

After some investigation, in the current implementation the behavior is expected because of the need of POM metadata files on a version range resolution.
Gradle will check variant information to make sure to only accept a version in the range that matches requested attributes (e.g. JVM  and language versions). And hence the verification failure for Kotlin v1.8 RC2 since Gradle will download the metadata for it.
There might be a possible optimization to avoid dependency verification for non-matching ranges, but for now the only workarounds are the before mentioned key base trust or use non-ranged versions.

Thank you for the investigation!
The workaround not to use non-ranged versions is less than ideal, as the use-case is a library A that has a dependency on library B (e.g. checkstyle), but is designed to work with any given version of B greater than X. It would be up to the consumer of A to provide a version of B, while at the same time respecting the constraint.
While I can use the trusted-key solution in the library A project to stabilize the builds (until the key is rotated for whatever reason), a consumer project will also have to add the trusted-key solution for the same reason, if dependency verification is used there as well.

Revisiting this ticket, I think you're onto something regarding avoiding dependency verification for non-matching ranges. If I understand you correctly, if there is a maliciously altered 1.8 RC2 POM, if it is non-matching anyway, there's no need to verify its integrity?


Remove redundant withOpenSSL

Unless it was intentional? I didn't find anything about double application in its documentation.

https://github.com/phadej/github/blob/078c0926620d80c50aa6b37ed41de0ca5e9f6292/src/GitHub/Request.hs#L110-L124

Ah sorry, double application.


Is there any reason why this kit is not using gql template tag

I was wondering if there is any specific reason why this kit is not using ggl tag from react-apollo. Their docs seem to promote using the template tag.
API DOC

@mairh This kit doesn't stop you using gql tag in any way. Please try first before opening issues.

Take a look at https://dev-blog.apollodata.com/webpacking-your-graphql-documents-bf9697ed259b

Thanks. Exactly what I needed to understand this


Update npm publish workflow

Thanks for peeking at this.  Will merge soon unless something comes up that needs doing.


Real / Fake Job Posting Prediction

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Real / Fake Job Posting Prediction
:red_circle: Aim : This project is to identify the Real/Fake job postings.
:red_circle: Dataset : https://www.kaggle.com/shivamb/real-or-fake-fake-jobposting-prediction
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

SNEGA S
https://github.com/snega16
Approach - Creating ML models after data analysis and EDA.
What is your participant role?

[x] JWOC 2022 Participant.

One issue at a time @snega16

Full Name: Sriniketh J
GitHub Profile Link: srini047
Approach for this Project: Building 2 to 3 Models like Decision Tree, SVC after Data Preprocessing and Visualisation
Participant Role: JWOC

Fix the little problem in your last PR and you are good to go with this issue @srini047

What's the update here @srini047

What's the update here @srini047

I have made 2 models and doing the third one. And just need to do the README file alone at the end. Need more 2-3 hours. Before which I will make a PR.

Good job, go ahead with your work. Thanks for the update @srini047


print in http

Can you remove the Print in http.py on line 101. I dont want that information in my console

Commit 167e4e8afbb308bdd6db98868f0d3f8bc2c6d02b fix them... but isn't released yet.
See #45

I fork and update module. Welcome https://github.com/deslum/pyrabbit2


prevent crash if not table not set align attr.

hi, will you update it for prevent error?

Thanks for this, and sorry it has taken a while to get back too you. I have fixed this in turndown-plugin-gfm: https://github.com/domchristie/turndown-plugin-gfm/blob/master/src/tables.js#L22
Hope that helps.


Add graph tests, bring coverage to 100%

Description of new feature, or changes
Increase test coverage for graph.js
Checklist

[x] Your branch is up-to-date with the base branch
[x] You've included at least one test if this is a new feature
[x] All tests are passing

Related Issues and Discussions
Made progress on #30
People to notify
@manrajgrover

🎉


Enable specs for constant on a singleton class

The comment about time out is outdated.

Disclaimer: it works on my machine, we might still trigger time outs in the CI for other setups. In that case this PR should be closed.


关于新版本pandoc中citeproc模块的处理

在较新的版本的 pandoc 上，pandoc-citeproc 这个 filter 已经被标注为 deprecated，citeproc 功能被直接整合进了 pandoc 里面，通过 extra 参数 --citeproc 启用。估建议在 README.md 的例子中注明这一点。
Reference:

https://github.com/jgm/pandoc-citeproc
https://github.com/jgm/citeproc

@huangy10 thanks for your constant feedbacks!
This might not be a fix as easy as just changing the read-me.
When pandoc-citeproc was a filter,
one can specify its position relative to other filters,
and this plugin can handle that.
With citeproc no longer a filter,
and specified as a dedicated flag --citeproc,
this says that this flag
"behaves like a filter and can be positioned relative to other filters as they appear on the command line".
I realized with our current configuration scheme we do not have the full ability to position --citeproc "relative to other filters".
Now this plugin forces --citeproc (which is specified as extra) to come after the filter specifications.
@huangy10: if we are just talking about you specifically for now, is this undesirable?
If so I guess I can also rework the plugin so instead the current configuration scheme
one can write something like
pandoc:
  - -filter
  - <filter name>
  - -citeproc
  - -M
  - <meta key>=<meta value>
  - -f
  - markdown-smart+<other extension specs>
  - -t
  - html-smart
  - --mathjax

This would give users complete freedom in specifying pandoc arguments.
Indeed this breaks backward compatibility,
but I trust for any pandoc user this is not a big issue but contrararily removes inconsistency between how arguments would be supplied to pandoc directly from command line and indirectly through this plugin.
Since, correct me if I'm wrong, this problem is not critical to you,
and I'm having a busy month ahead of me,
I'm not going to implement the changes above very soon.
@huangy10 let me know if the issue is urgent,
or better, submit your own pull request, if my proposal above makes sense to you.

Thank you for your reply.
I just wanna say that README.md  should be modified to inform other users about this change (I met some trouble about this issue when migrating to newer pandoc). Confusion may arise for new users.  Since you are busy recently, I can submit a PR to make necessary modifications.

If your concern is merely that the example given in read-me could cause confusion, then I'm more inclined to simply remove the example, since I could not find a better example. Do you know if there is any other widely used pandoc filter other than citeproc that I can use as a replace?

FYI, the following (kinda) works for recent versions of pandoc:
_config.yml
pandoc:
  filters:
  extra:
  - citeproc:
  - bibliography: "pathto.bib"
  - csl: "yourstyle.csl"
  template:
  meta:
  mathEngine:

However, the generated bibliography does not blend well with non-citation footnotes, e.g. [^1]. I'm still trying the correct recipe.

The way your _config.yml looks to me suggests that whatever you mean by "the generated bibliography does not blend well with non-citation footnotes" should not be caused by this plugin (and how it passes arguments to pandoc), since you did not specify any filters. That is just my guess though. I will take a test once I get some time in recent days.

The way your _config.yml looks to me ...

Thank you for your prompt reply. I tried removing the filters: you mentioned. And the results were still the same. I'll try to give out as much information as I can.
Rendered result

The markdown file
---
title: First post
date: 2020-06-28 16:47:33
tags: ["test"]
categories: ["Test"]
sticky: 100
---

The stuff you'll see in the front page.

<!-- more -->

Set `sticky: 100` in the frontmatter to pin this post on top.

[@Julia-2017]

Test[^2]

---

[^2]: a footnote

Config
_config.yml
# Hexo Configuration
## Docs: https://hexo.io/docs/configuration.html
## Source: https://github.com/hexojs/hexo/

# Site
title: Site title
subtitle: Site subtitle
description: Site description
keywords:
author: Your name
language: en
timezone: ''

# URL
## If your site is put in a subdirectory, set url as 'http://yoursite.com/child' and root as '/child/'
url: https://sosiristseng.github.io
root: /template-hexo-next/
permalink: :category/:title/
permalink_defaults:
pretty_urls:
  trailing_index: false # Set to false to remove trailing 'index.html' from permalinks
  trailing_html: false # Set to false to remove trailing '.html' from permalinks

# Directory
source_dir: source
public_dir: public
tag_dir: tags
archive_dir: archives
category_dir: categories
code_dir: code
i18n_dir: :lang
skip_render: ['code/**']

# Writing
new_post_name: :title.md # File name of new posts
default_layout: post
auto_spacing: true  # Similar to hexo-pangu
titlecase: false # Transform title into titlecase
external_link:
  enable: true # Open external links in new tab
  field: site # Apply to the whole site
  exclude: ''
filename_case: 0
render_drafts: false
post_asset_folder: false
relative_link: false
future: true
highlight:
  enable: true
  line_number: true
  auto_detect: false
  tab_replace: '    '
  wrap: true
  hljs: false

# Pandoc config (optional): https://github.com/wzpan/hexo-renderer-pandoc

# Home page setting
# path: Root path for your blogs index page. (default = '')
# per_page: Posts displayed per page. (0 = disable pagination)
# order_by: Posts order. (Order by date descending by default)
index_generator:
  path: ''
  per_page: 10
  order_by: -date

# Category & Tag
default_category: uncategorized
category_map:
tag_map:

# Metadata elements
## https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta
meta_generator: true

# Date / Time format
## Hexo uses Moment.js to parse and display date
## You can customize the date format as defined in
## http://momentjs.com/docs/#/displaying/format/
date_format: YYYY-MM-DD
time_format: HH:mm:ss
updated_option: mtime

# Pagination
## Set per_page to 0 to disable pagination
per_page: 10
pagination_dir: page

# Include / Exclude file(s)
## include:/exclude: options only apply to the 'source/' folder
##
include:
exclude:
ignore:

# Plugins: https://hexo.io/plugins/
## Seach data generator plugin for Hexo
## https://github.com/theme-next/hexo-generator-searchdb
search:
  path: search.json
  field: all
  content: true
  format: striptags

# Themes: https://hexo.io/themes/
# Next theme: https://theme-next.js.org/
theme: next

# markdown-renderer-pandoc config: https://github.com/wzpan/hexo-renderer-pandoc

pandoc:
  extra:
  - citeproc:
  - bibliography: "julia.bib"
  - csl: "vancouver-brackets.csl"
  template:
  meta:
  mathEngine:

BibTex
% This article is the definitive citation for Julia.
@article{Julia-2017,
    title={Julia: A fresh approach to numerical computing},
    author={Bezanson, Jeff and Edelman, Alan and Karpinski, Stefan and Shah, Viral B},
    journal={SIAM {R}eview},
    volume={59},
    number={1},
    pages={65--98},
    year={2017},
    publisher={SIAM},
    doi={10.1137/141000671},
    url={https://epubs.siam.org/doi/10.1137/141000671}
}

% For more details on research related to Julia, see https://julialang.org/research

package.json
{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "build": "hexo g",
    "clean": "hexo cl",
    "server": "hexo cl && hexo s -o --debug",
    "gzipper": "gzipper",
    "compress": "gzipper compress ./public --deflate --brotli"
  },
  "hexo": {
    "version": "5.4.0"
  },
  "dependencies": {
    "gzipper": "^5.0.0",
    "hexo": "^5.4.0",
    "hexo-generator-archive": "^1.0.0",
    "hexo-generator-category": "^1.0.0",
    "hexo-generator-index": "^2.0.0",
    "hexo-generator-searchdb": "^1.3.4",
    "hexo-generator-tag": "^1.0.0",
    "hexo-renderer-ejs": "^1.0.0",
    "hexo-renderer-pandoc": "^0.3.0",
    "hexo-renderer-stylus": "^2.0.1",
    "hexo-server": "^2.0.0",
    "hexo-theme-next": "^8.7.0",
    "hexo-word-counter": "^0.0.3"
  }
}

Style: Vancouver brackets

@ sosiristseng Are you expecting that the references generated by bib file and footnotes to be placed in the same section?

@sosiristseng Your rendered result looks completely reasonable to me. So I guess @huangy10 is right: @sosiristseng you want references and footnote texts to be placed in the same list. Looking at Pandoc's code, I  don't think this is possible. Moreover, it looks like Pandoc is suggesting bibliography items are ontologically distinctive from footnotes, which I find reasonable.
It might be possible to have bib items and footnotes in the same list, perhaps in the order of their first appeariences, by invoking a customized pandoc filter after calling citeproc (which involves my earlier discussion). However I envision that writing such a filter requires quite some consideration, for example, what if an author-year citation style is used? This could be one major reason to treat bib items and footnotes ontologically differently.
@huangy10 I just realized that I never tied up the end of our earlier discussion. Hopefully I will be able to find some time recently and quickly build a prototype.

@RichardYan314 @huangy10 Yes, I thought pandoc would generate Markdown footnotes for citations. Thank you for pointing out that was not the case.

Please see the new readme.md for a new interface for passing arguments to pandoc.


SIM108: preserve quoting style in autofixes; don't flag if/else blocks where the if-statement spans multiple lines

Fixes #9660. Instead of using the expression generator, copy and paste the source-code expression exactly as it is.

@AlexWaygood - There may be a separate fix to apply here (in addition or in lieu of this change). In the generator, we have:
fn unparse_f_string(&mut self, values: &[ast::FStringElement], is_spec: bool) {
    if is_spec {
        self.unparse_f_string_body(values);
    } else {
        self.p("f");
        let mut generator = Generator::new(
            self.indent,
            match self.quote {
                Quote::Single => Quote::Double,
                Quote::Double => Quote::Single,
            },
            self.line_ending,
        );
        generator.unparse_f_string_body(values);
        let body = &generator.buffer;
        self.p_str_repr(body);
    }
}

So, when we recurse into an f-string, we alternate the preferred quote style. If the target version is >= Python 3.12, though, we should skip this and preserve the preferred quote style.

Closing this for now -- it seems like the wrong fix, and I accidentally pushed my changes straight to the main branch on my fork (😱) which is a bit of a pain. I'll try to open a PR with the correct fix soon :)


PLNSRVCE-658: readd kcp'ed jvm-build-service but leverages a bunch of simplifications over pre-kcp integration

I butchered the branch PR merge and subsequent rebase in my original branch's local copy of https://github.com/redhat-appstudio/infra-deployments/pull/727 after merging @Michkov 's https://github.com/gabemontero/infra-deployments/pull/1 so in the end I just created a new branch and cherry-picked those 2 commits
My current intent is to merge some acceptable, though probably only partially functioning form of https://github.com/redhat-appstudio/jvm-build-service/pull/236 merged after review with @stuartwdouglas , and then I can update this branch with the correct commits for the apply -k of deploy/kcp, along with the correct sha for the controller image that corresponds to that PR.

OK I've turned off the draft bit on this PR for adding jvm build service back to infra deployments
PLNSRVCE-658 is still in progress and not fully functional on KCP, but there is certainly enough available at  https://github.com/redhat-appstudio/jvm-build-service/commit/954c86b39a12820c7910c93b1e20b9b572232816 to start vetting things here in infra-deployments and start testing here in this repo (@Michkov has wanted to start that for a bit) and sorting out issues like the permission claim identity hash stuff @Michkov has been mentioning in stand up, as jvm build service certainly needs a few things from placement service's kubernetes APIExport.
To that, @Michkov - at one point recently you had pointed me to what I think was a commit in your fork of this repo that removed the apibinding defined in the jvmbuildservice repo, as well as the singleton of our global systemconfig object.  I thought I had saved a link to that but can't find it.
Am I correct in thinking we want to update this PR with some form of that ?  If so, can you provide any relevant links / elaborate? I suspect https://github.com/redhat-appstudio/infra-deployments/pull/763/files has some bearing on that, but I have not had a chance to look at it in detail yet.  I will do that tomorrow, pending any course correction from @Michkov
Lastly, I have been able to pay enough attention to this repo to see that @MatousJobanek made some progress in setting up the HACBS service provide workspace, and per https://issues.redhat.com/browse/PLNSRVCE-727 from @ralphbean we want jvm-build-service in that.
As such, in a separate commit I've moved jvm-build-service under the component/hacbs folder in an attempt to include jvm-build-service in the hacbs service provider workspace.  That said, I would think minimally the APIBinding refactor I just asked @Michkov about here would also need further workspace path changes to conform to being in the HACBS service provider workspace.  And of course there may be additional changes that I'm just totally unaware of.
thanks everyone / look forward to the responses

OK I took an initial stab and examining the now merged #763 as well as the latest structure I see for other controllers (most notabl application service since it has a non-trivial set of permission claims like jvm-build-service) and did a refactor on that
Still "in progress" in that I minimally need to log into stable/unstable and presumably find the identity hashes for the permission claims jvm-build-service needs (assuming I've interpreted things correctly).
Hopefully some of today's fires on the jvm-build-service side of KCP integration will be sorted out soon, and I can focus on this.

@gabemontero by mistake I updated your MR to newest changes in main and also added identityHashes and few fixes in the scripts so now it's possible to deploy. (Still not working properly but good start, so I am not afraid to merge this).


Trace propagation

Awesome project, question? how can I propagate the trace between an application that is using OIDC for authentication in keycloak ?

Unfortunately, this is not in the scope of this project (traceability of Keycloak server). Please check https://opentelemetry.io/docs/instrumentation/

No I'm talking about the OpenTelemetry Context Propagation, i.e. after the authorization the can be passed to the clients or database in order to have the full observability in place. just wondering if even with the OIDC or SAML interactions this can be done


Send the current applicable rate for the interval with the octopus_energy_electricity_current_day_rates event

Describe the feature
With every octopus_energy_electricity_current_day_rates, along with min_rate and max_rate, send the current/now rate.
Expected behaviour
if the event is triggers at 13:10, payload would look like
...
    - start: "2024-06-28T12:30:00+01:00"
      end: "2024-06-28T13:00:00+01:00"
      value_inc_vat: 0.00441
      is_capped: false
    - start: "2024-06-28T13:00:00+01:00"
      end: "2024-06-28T13:30:00+01:00"
      value_inc_vat: 0.00042
      is_capped: false
    - start: "2024-06-28T13:30:00+01:00"
      end: "2024-06-28T14:00:00+01:00"
      value_inc_vat: 0
      is_capped: false
    - start: "2024-06-28T14:00:00+01:00"
      end: "2024-06-28T14:30:00+01:00"
      value_inc_vat: 0.00462
      is_capped: false
...
  min_rate: -0.02835
  max_rate: 0.291375
  now_rate: 0.00042
  average_rate: 0.07665913
`

### Use Case

Ive been displaying the rates in an apex chart and having the current applicable rate as the header would be useful. Looked at other available entities and none of them gives that information.

### Confirmation

- [X] By submitting this feature request, you agree that you have read the [documentation](https://bottlecapdave.github.io/HomeAssistant-OctopusEnergy) and confirmed it does not already exist
- [ ] I am willing/able to help contribute to the solution of this feature

Hello, sorry for the very late response.

Ive been displaying the rates in an apex chart and having the current applicable rate as the header would be useful. Looked at other available entities and none of them gives that information.

As per the docs, the current rate entity provides the data you're after either via it's state or via it's attributes.
Would this meet your needs?

Closing due to inactivity.


Not work in Intranet document

Hi,

is added to the access of config.xml.
Intranet documnet can be embedded in iframe of APP.
But any Intranet documents cannot be opened by the plugin. e.g. http://192.168.1.XXX/pork.pdf

Thanks.

Solved


Add a 32-bit UBSAN build

Should help to flag bad code in 32-bit builds (like #12931)

I don't see myself having cycles for this in the near future. Closing for bankruptcy.


add simple example of next.js

What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain: add a simple example of next.js
What changes did you make? (Give an overview)
add a simple example of next.js
Which issue (if any) does this pull request address?
no
Is there anything you'd like reviewers to focus on?
no

@all-contributors please add @wh5938316 for a demo

@all-contributors please add @wh5938316 for a code


Small bug in colab notebook

Hi there!
I was using the colab notebook SwinIR demo on Real-World Image SR.ipynb  and the ESRGAN output was not woking.
I changed the ESRGAN lines in inference to
# realESRGAN
if test_patch_wise:
  !python inference_realesrgan.py -n RealESRGAN_x4plus --input BSRGAN/testsets/RealSRSet -s 4 --output results/realESRGAN --tile 800
else:
  !python inference_realesrgan.py -n RealESRGAN_x4plus --input BSRGAN/testsets/RealSRSet -s 4 --output results/realESRGAN

...and now it works.
I'm posting this in case this is a generalized problem for anyone else.
Thanks!

Thank you very much. I have corrected it.


:comet: Bulkrax x Valkryie EPIC

Metadata only for now.
file uploads blocked by https://github.com/scientist-softserv/hykuup_knapsack/issues/34?
TASKS

[x] #102
[x] #128
[x] https://github.com/samvera/bulkrax/issues/897
[ ] test metadata only and document issues

[ ] #117
[ ] #118

[x] #125
[ ] #124
[ ] #120
[x] https://github.com/samvera/bulkrax/issues/903
[ ] #150
[ ] #149
[x] #151

Bugs found:

[ ] Gallery & Masonry view layouts are wonky (Blacklight update happened)
[ ] Content block save button color is white on white
[ ] Collection branding: Errors uploading banner or logo to collection
[ ] Add new collection as a subcollection adds the new collection but doesn't link as a subcollection
[ ] Error uploading site logo
[ ] All collections button from homepage doesn't find any - must be limiting model to search
[ ] Homepage save order doesn't work
[ ] Remove featured collection from homepage "X" icon is missing (has a small question mark instead)
[ ] Reindex after changing default images for works and collections didn't work