segfault when closing terminals with term_setkill()

Describe the bug
Under certain circumstances, vim will segfault upon closing. I have noticed this with vim 8.1 in Debian unstable and reproduced the issue with current git master. The circumstances required appear to be:

vim configured with: --without-x --enable-gui=no
autocmd TerminalOpen * call term_setkill('%', 'hup')
at least two terminals open, with at least one on an inactive tab page
terminals running bash

The segfault is not 100% reproducible; I get it about 70% of the time. My hypothesis is that there is a race condition between when vim checks to see if the terminal process has died and when the process actually does die.
To Reproduce

Compile vim (current git master): ./configure --without-x --enable-gui=no
Create ~/.vim/vimrc.segfault (or some such) with contents:

autocmd TerminalOpen * call term_setkill('%', 'hup')
terminal
tabnew
terminal

Run src/vim --clean -u ~/.vim/vimrc.segfault
Focus should be on the terminal window of the second tab page. Use CTRL-W N to get into normal mode, then quit with :qa
If vim quits with no error, then repeat; I get about 70% failure rate.
The observed problem at this point is:

E947: Job still running in buffer "!/bin/bash"
Press ENTER or type command to continue

Hit ENTER.
The parent terminal will show:

Vim: Caught deadly signal SEGV
Vim: Finished.

Segmentation fault

The segfault seems the most common, but there are some variations.
Variation 1: vim gets stuck upon hitting ENTER:
E947: Job still running in buffer "!/bin/bash"
Press ENTER or type command to continue
E316: ml_get: cannot find line 3
Press ENTER or type command to continue
E316: ml_get: cannot find line 4
Press ENTER or type command to continue
E316: ml_get: cannot find line 5
Press ENTER or type command to continue

Variation 2: ABRT instead of SEGV:
Vim: Caught deadly signal ABRT
Vim: Finished.

Aborted

Expected behavior
I expect vim to exit cleanly.
Screenshots
(see above)
Environment:
$ src/vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 20 2019 21:18:33)
Included patches: 1-2197
Compiled by bugfood@bugfood
Huge version without GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_any_white
+arabic            +file_in_path      +mouse_urxvt       -tcl
+autocmd           +find_in_path      +mouse_xterm       +termguicolors
+autochdir         +float             +multi_byte        +terminal
-autoservername    +folding           +multi_lang        +terminfo
-balloon_eval      -footer            -mzscheme          +termresponse
+balloon_eval_term +fork()            +netbeans_intg     +textobjects
-browse            +gettext           +num64             +textprop
++builtin_terms    -hangul_input      +packages          +timers
+byte_offset       +iconv             +path_extra        +title
+channel           +insert_expand     -perl              -toolbar
+cindent           +job               +persistent_undo   +user_commands
-clientserver      +jumplist          +postscript        +vartabs
-clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           -python            +visual
+cmdline_info      +libcall           -python3           +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          -ruby              +wildmenu
+cursorbind        -lua               +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con        +mksession         +smartindent       -X11
+diff              +modify_fname      +sound             -xfontset
+digraphs          +mouse             +spell             -xim
-dnd               -mouseshape        +startuptime       -xpm
-ebcdic            +mouse_dec         +statusline        -xsmp
+emacs_tags        +mouse_gpm         -sun_workshop      -xterm_clipboard
+eval              -mouse_jsbterm     +syntax            -xterm_save
+ex_extra          +mouse_netterm     +tag_binary
+extra_search      +mouse_sgr         -tag_old_static
  system vimrc file: "$VIM/vimrc"
    user vimrc file: "$HOME/.vimrc"
2nd user vimrc file: "~/.vim/vimrc"
     user exrc file: "$HOME/.exrc"
      defaults file: "$VIMRUNTIME/defaults.vim"
 fall-back for $VIM: "/usr/local/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O0 -g3 -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L/usr/local/lib -Wl,--as-needed -o vim        -lm -ltinfo -lnsl  -lselinux -lcanberra -lacl -lattr -lgpm -ldl

OS: Debian GNU/Linux bullseye/sid
Terminal: rxvt-unicode
compiler: gcc (Debian 9.2.1-8) 9.2.1 20190909

Additional context
I was able to reproduce the problem with debug CFLAGS as well:
CFLAGS='-O0 -g3' ./configure --without-x --enable-gui=no
Here's some info from gdb:
$ gdb ./vim "$(pgrep -f ^/usr/local/src/vim/vim/src/vim)"
GNU gdb (Debian 8.3-1) 8.3
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./vim...
Attaching to program: /usr/local/src/vim/vim/src/vim, process 14987
Reading symbols from /lib/x86_64-linux-gnu/libm.so.6...
Reading symbols from /usr/lib/debug/.build-id/4b/93a7cece16af81e899fb4f30ddd2d04458f130.debug...
Reading symbols from /lib/x86_64-linux-gnu/libtinfo.so.6...
(No debugging symbols found in /lib/x86_64-linux-gnu/libtinfo.so.6)
Reading symbols from /lib/x86_64-linux-gnu/libselinux.so.1...
(No debugging symbols found in /lib/x86_64-linux-gnu/libselinux.so.1)
Reading symbols from /usr/lib/x86_64-linux-gnu/libcanberra.so.0...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libcanberra.so.0)
Reading symbols from /usr/lib/x86_64-linux-gnu/libacl.so.1...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libacl.so.1)
Reading symbols from /usr/lib/x86_64-linux-gnu/libgpm.so.2...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libgpm.so.2)
Reading symbols from /lib/x86_64-linux-gnu/libdl.so.2...
Reading symbols from /usr/lib/debug/.build-id/76/4d69efdd031e82470572d1ea520f5cde34cd4c.debug...
Reading symbols from /lib/x86_64-linux-gnu/libc.so.6...
Reading symbols from /usr/lib/debug/.build-id/39/0f503de1e6c0f261c838d72f9f75197075766e.debug...
Reading symbols from /lib64/ld-linux-x86-64.so.2...
Reading symbols from /usr/lib/debug/.build-id/75/6169f4795800ea95544fb9851e16b81e0804da.debug...
Reading symbols from /usr/lib/x86_64-linux-gnu/libpcre2-8.so.0...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libpcre2-8.so.0)
Reading symbols from /usr/lib/x86_64-linux-gnu/libvorbisfile.so.3...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libvorbisfile.so.3)
--Type <RET> for more, q to quit, c to continue without paging--
Reading symbols from /usr/lib/x86_64-linux-gnu/libtdb.so.1...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libtdb.so.1)
Reading symbols from /usr/lib/x86_64-linux-gnu/libltdl.so.7...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libltdl.so.7)
Reading symbols from /lib/x86_64-linux-gnu/libpthread.so.0...
Reading symbols from /usr/lib/debug/.build-id/ba/edf15ab6d6a855a82fda229a630150fda8de9b.debug...
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Reading symbols from /usr/lib/x86_64-linux-gnu/libvorbis.so.0...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libvorbis.so.0)
Reading symbols from /usr/lib/x86_64-linux-gnu/libogg.so.0...
(No debugging symbols found in /usr/lib/x86_64-linux-gnu/libogg.so.0)
Reading symbols from /lib/x86_64-linux-gnu/libnss_files.so.2...
Reading symbols from /usr/lib/debug/.build-id/34/b57043b462c3d904c14e9c8bf7889d8c909782.debug...
0x00007f0e3f3e9187 in __GI___select (nfds=6, readfds=0x5648773799e0 <rfds>, writefds=0x564877379a60 <wfds>,
    exceptfds=0x564877379ae0 <efds>, timeout=0x0) at ../sysdeps/unix/sysv/linux/select.c:41
41	../sysdeps/unix/sysv/linux/select.c: No such file or directory.
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
0x00005648771843b4 in ml_lineadd (buf=0x5648789c1da0, count=1) at memline.c:4315
4315		if ((hp = mf_get(mfp, ip->ip_bnum, 1)) == NULL)
(gdb) bt
#0  0x00005648771843b4 in ml_lineadd (buf=0x5648789c1da0, count=1) at memline.c:4315
#1  0x0000564877183dbf in ml_find_line (buf=0x5648789c1da0, lnum=3, action=19) at memline.c:4118
#2  0x0000564877181056 in ml_get_buf (buf=0x5648789c1da0, lnum=3, will_change=0) at memline.c:2659
#3  0x00005648770d748c in win_line (wp=0x5648789f32e0, lnum=3, startrow=2, endrow=37, nochange=1, number_only=0)
    at drawline.c:691
#4  0x00005648770e1662 in win_update (wp=0x5648789f32e0) at drawscreen.c:2347
#5  0x00005648770dcde0 in update_screen (type_arg=0) at drawscreen.c:317
#6  0x00005648772d9cea in main_loop (cmdwin=0, noexmode=0) at main.c:1403
#7  0x00005648772d9386 in vim_main2 () at main.c:901
#8  0x00005648772d8bbf in main (argc=4, argv=0x7ffc6c3c1628) at main.c:444
(gdb) print ip
$1 = (infoptr_T *) 0x0
(gdb) print buf->b_ml.ml_stack[idx]
Cannot access memory at address 0x0
(gdb) print buf->b_ml.ml_stack
$2 = (infoptr_T *) 0x0
(gdb) print idx
$3 = 0
(gdb) print buf
$4 = (buf_T *) 0x5648789c1da0
(gdb) print *buf
$5 = {b_ml = {ml_line_count =<PHONE_NUMBER>54448, ml_mfp = 0x5648789ff560, ml_flags = 0, ml_stack = 0x0, ml_stack_top = 1,
    ml_stack_size = 5, ml_line_lnum = 0, ml_line_ptr = 0x5648789c8e90 "@\367\233xHV", ml_line_len = 0, ml_locked = 0x0,
    ml_locked_low = 1, ml_locked_high = 2, ml_locked_lineadd = 1, ml_chunksize = 0x0, ml_numchunks = 100,
    ml_usedchunks = 1}, b_next = 0x5648789f5cd0, b_prev = 0x564878993640, b_nwindows = 1, b_flags = 0, b_locked = 0,
  b_ffname = 0x0, b_sfname = 0x0, b_fname = 0x5648789c1d80 "`\365\237xHV", b_dev_valid = 0, b_dev = 0, b_ino = 0,
  b_fnum = 2, b_key = "2\000\000\000\000\000\000\000", b_changed = 0, b_ct_di = {di_tv = {v_type = VAR_NUMBER,
      v_lock = 0 '\000', vval = {v_number = 0, v_float = 0, v_string = 0x0, v_list = 0x0, v_dict = 0x0, v_partial = 0x0,
        v_job = 0x0, v_channel = 0x0, v_blob = 0x0}}, di_flags = 5 '\005', di_key = "changedtick\000\000\000\000\000"},
  b_last_changedtick = 2, b_last_changedtick_pum = 2, b_saving = 0, b_mod_set = 0, b_mod_top = 0, b_mod_bot = 0,
  b_mod_xlines = 0, b_wininfo = 0x564878a022a0, b_mtime = 0, b_mtime_read = 0, b_orig_size = 0, b_orig_mode = 0,
  b_last_used =<PHONE_NUMBER>, b_namedm = {{lnum = 0, col = 0, coladd = 0} <repeats 26 times>}, b_visual = {vi_start = {
      lnum = 0, col = 0, coladd = 0}, vi_end = {lnum = 0, col = 0, coladd = 0}, vi_mode = 0, vi_curswant = 0},
  b_visual_mode_eval = 0, b_last_cursor = {lnum = 1, col = 0, coladd = 0}, b_last_insert = {lnum = 0, col = 0, coladd = 0},
  b_last_change = {lnum = 0, col = 0, coladd = 0}, b_changelist = {{lnum = 0, col = 0, coladd = 0} <repeats 100 times>},
  b_changelistlen = 0, b_new_change = 0,
  b_chartab = "\000\000\000\000\000\000\377\003\376\377\377\207\376\377\377\a\000\000\000\000\000\000 \000\377\377\177\377\377\377\177\377", b_maphash = {0x0 <repeats 256 times>}, b_first_abbr = 0x0, b_ucmds = {ga_len = 0, ga_maxlen = 0,
    ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_op_start = {lnum = 0, col = 0, coladd = 0}, b_op_start_orig = {
    lnum = 0, col = 0, coladd = 0}, b_op_end = {lnum = 0, col = 0, coladd = 0}, b_marks_read = 0, b_u_oldhead = 0x0,
  b_u_newhead = 0x0, b_u_curhead = 0x0, b_u_numhead = 0, b_u_synced = 1, b_u_seq_last = 0, b_u_save_nr_last = 0,
  b_u_seq_cur = 0, b_u_time_cur = 0, b_u_save_nr_cur = 0, b_u_line_ptr = {ul_line = 0x0, ul_len = 0}, b_u_line_lnum = 0,
  b_u_line_colnr = 0, b_scanned = 0, b_p_iminsert = 0, b_p_imsearch = -1, b_kmap_state = 0, b_kmap_ga = {ga_len = 0,
    ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_p_initialized = 1, b_p_script_ctx = {{sc_sid = 0,
      sc_seq = 0, sc_lnum = 0, sc_version = 0} <repeats 83 times>}, b_p_ai = 0, b_p_ai_nopaste = 0,
  b_p_bkc = 0x56487730df86 "", b_bkc_flags = 0, b_p_ci = 0, b_p_bin = 0, b_p_bomb = 0, b_p_bh = 0x56487730df86 "",
  b_p_bt = 0x56487730df86 "", b_has_qf_entry = 0, b_p_bl = 1, b_p_cin = 0, b_p_cino = 0x5648789f87a0 "",
  b_p_cink = 0x5648789be6e0 "0{,0},0),0],:,0#,!^F,o,O,e", b_p_cinw = 0x5648789ff520 "if,else,while,do,for,switch",
  b_p_com = 0x5648789fa060 "s1:/*,mb:*,ex:*/,://,b:#,:%,:XCOMM,n:>,fb:-", b_p_cms = 0x5648789c7230 "/*%s*/",
  b_p_cpt = 0x5648789be6c0 ".,w,b,u,t,i", b_p_cfu = 0x5648789c4970 "", b_p_ofu = 0x5648789c4950 "",
  b_p_tfu = 0x5648789c4930 "", b_p_eol = 1, b_p_fixeol = 1, b_p_et = 0, b_p_et_nobin = 0, b_p_et_nopaste = 0,
  b_p_fenc = 0x56487730df86 "", b_p_ff = 0x56487730df86 "", b_p_ft = 0x56487730df86 "", b_p_fo = 0x5648789f3080 "vt",
  b_p_flp = 0x5648789fa0a0 "^\\s*\\d\\+[\\]:.)}\\t ]\\s*", b_p_inf = 0, b_p_isk = 0x56487730df86 "",
  b_p_def = 0x56487730df86 "", b_p_inc = 0x56487730df86 "", b_p_inex = 0x56487899c9b0 "", b_p_inex_flags = 0,
  b_p_inde = 0x5648789f5cb0 "", b_p_inde_flags = 0, b_p_indk = 0x5648789f89c0 "0{,0},0),0],:,0#,!^F,o,O,e",
  b_p_fp = 0x56487730df86 "", b_p_fex = 0x5648789f88e0 "", b_p_fex_flags = 0, b_p_key = 0x5648789f89f0 "",
  b_p_kp = 0x56487730df86 "", b_p_lisp = 0, b_p_menc = 0x56487730df86 "", b_p_mps = 0x56487899e710 "(:),{:},[:]",
  b_p_ml = 0, b_p_ml_nobin = 0, b_p_ma = 0, b_p_nf = 0x564878a2f8b0 "bin,octal,hex", b_p_pi = 0,
  b_p_qe = 0x5648789be710 "\\", b_p_ro = 0, b_p_sw = 8, b_p_sn = 0, b_p_si = 0, b_p_sts = 0, b_p_sts_nopaste = 0,
--Type <RET> for more, q to quit, c to continue without paging--
  b_p_sua = 0x5648789c7210 "", b_p_swf = 1, b_p_smc = 3000, b_p_syn = 0x56487730df86 "", b_p_ts = 8, b_p_tx = 0,
  b_p_tw = 0, b_p_tw_nobin = 0, b_p_tw_nopaste = 0, b_p_wm = 0, b_p_wm_nobin = 0, b_p_wm_nopaste = 0,
  b_p_vsts = 0x5648789c4910 "", b_p_vsts_array = 0x0, b_p_vsts_nopaste = 0x0, b_p_vts = 0x56487730df86 "",
  b_p_vts_array = 0x0, b_p_keymap = 0x5648789c7140 "", b_p_gp = 0x56487730df86 "", b_p_mp = 0x56487730df86 "",
  b_p_efm = 0x56487730df86 "", b_p_ep = 0x56487730df86 "", b_p_path = 0x56487730df86 "", b_p_ar = -1,
  b_p_tags = 0x56487730df86 "", b_p_tc = 0x56487730df86 "", b_tc_flags = 0, b_p_dict = 0x56487730df86 "",
  b_p_tsr = 0x56487730df86 "", b_p_ul = -123456, b_p_udf = 0, b_p_lw = 0x56487730df86 "", b_p_twsl = 10000,
  b_ind_level = 8, b_ind_open_imag = 0, b_ind_no_brace = 0, b_ind_first_open = 0, b_ind_open_extra = 0,
  b_ind_close_extra = 0, b_ind_open_left_imag = 0, b_ind_jump_label = -1, b_ind_case = 8, b_ind_case_code = 8,
  b_ind_case_break = 0, b_ind_param = 8, b_ind_func_type = 8, b_ind_comment = 0, b_ind_in_comment = 3,
  b_ind_in_comment2 = 0, b_ind_cpp_baseclass = 8, b_ind_continuation = 8, b_ind_unclosed = 16, b_ind_unclosed2 = 8,
  b_ind_unclosed_noignore = 0, b_ind_unclosed_wrapped = 0, b_ind_unclosed_whiteok = 0, b_ind_matching_paren = 0,
  b_ind_paren_prev = 0, b_ind_maxparen = 20, b_ind_maxcomment = 70, b_ind_scopedecl = 8, b_ind_scopedecl_code = 8,
  b_ind_java = 0, b_ind_js = 0, b_ind_keep_case_label = 0, b_ind_hash_comment = 0, b_ind_cpp_namespace = 0,
  b_ind_if_for_while = 0, b_ind_cpp_extern_c = 0, b_no_eol_lnum = 0, b_start_eol = 1, b_start_ffc = 117,
  b_start_fenc = 0x0, b_bad_char = 0, b_start_bomb = 0, b_bufvar = {di_tv = {v_type = VAR_DICT, v_lock = 2 '\002', vval = {
        v_number =<PHONE_NUMBER>0272, v_float = 4.6871642775750359e-310, v_string = 0x5648789c4130 "0\031\234xHV",
        v_list = 0x5648789c4130, v_dict = 0x5648789c4130, v_partial = 0x5648789c4130, v_job = 0x5648789c4130,
        v_channel = 0x5648789c4130, v_blob = 0x5648789c4130}}, di_flags = 5 '\005', di_key = ""}, b_vars = 0x5648789c4130,
  b_listener = 0x0, b_recorded_changes = 0x0, b_has_textprop = 0, b_proptypes = 0x0, b_p_bexpr = 0x56487730df86 "",
  b_p_bexpr_flags = 0, b_p_cm = 0x56487730df86 "", b_may_swap = 1, b_did_warn = 0, b_help = 0, b_spell = 0,
  b_shortname = 0, b_prompt_text = 0x0, b_prompt_callback = {cb_name = 0x0, cb_partial = 0x0, cb_free_name = 0},
  b_prompt_interrupt = {cb_name = 0x0, cb_partial = 0x0, cb_free_name = 0}, b_prompt_insert = 0, b_s = {b_keywtab = {
      ht_mask = 15, ht_used = 0, ht_filled = 0, ht_locked = 0, ht_error = 0, ht_array = 0x5648789c3c58, ht_smallarray = {{
          hi_hash = 0, hi_key = 0x0} <repeats 16 times>}}, b_keywtab_ic = {ht_mask = 15, ht_used = 0, ht_filled = 0,
      ht_locked = 0, ht_error = 0, ht_array = 0x5648789c3d80, ht_smallarray = {{hi_hash = 0,
          hi_key = 0x0} <repeats 16 times>}}, b_syn_error = 0, b_syn_slow = 0, b_syn_ic = 0, b_syn_spell = 0,
    b_syn_patterns = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_syn_clusters = {
      ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_spell_cluster_id = 0,
    b_nospell_cluster_id = 0, b_syn_containedin = 0, b_syn_sync_flags = 0, b_syn_sync_id = 0, b_syn_sync_minlines = 0,
    b_syn_sync_maxlines = 0, b_syn_sync_linebreaks = 0, b_syn_linecont_pat = 0x0, b_syn_linecont_prog = 0x0,
    b_syn_linecont_time = {total = {tv_sec = 0, tv_usec = 0}, slowest = {tv_sec = 0, tv_usec = 0}, count = 0, match = 0},
    b_syn_linecont_ic = 0, b_syn_topgrp = 0, b_syn_conceal = 0, b_syn_folditems = 0, b_sst_array = 0x0, b_sst_len = 0,
    b_sst_first = 0x0, b_sst_firstfree = 0x0, b_sst_freecount = 0, b_sst_check_lnum = 0, b_sst_lasttick = 0, b_langp = {
      ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0},
    b_spell_ismw = '\000' <repeats 255 times>, b_spell_ismw_mb = 0x0, b_p_spc = 0x5648789be600 "[.?!]\\_[\\])'\"\t ]\\+",
    b_cap_prog = 0x5648789c62d0, b_p_spf = 0x564878a02880 "", b_p_spl = 0x564878a02840 "en", b_cjk = 0,
    b_syn_chartab = '\000' <repeats 31 times>, b_syn_isk = 0x56487730df86 ""}, b_signlist = 0x0, b_has_sign_column = 0,
--Type <RET> for more, q to quit, c to continue without paging--
  b_netbeans_file = 0, b_was_netbeans_file = 0, b_write_to_channel = 0, b_cryptstate = 0x0, b_mapped_ctrl_c = 0,
  b_term = 0x0, b_diff_failed = 0}
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
0x00007f0e3f331367 in kill () at ../sysdeps/unix/syscall-template.S:78
78	../sysdeps/unix/syscall-template.S: No such file or directory.
(gdb) c
Continuing.

Program terminated with signal SIGSEGV, Segmentation fault.
The program no longer exists.
(gdb) q

If I can help by providing any more information, please let me know.
Thanks,
Corey

If I change to:
autocmd TerminalOpen * call term_setkill('%', 'kill')

Then the failure rate drops to about 30%. I hypothesize that this is because bash traps a SIGHUP and does some cleanup, thus taking longer to exit than on a SIGKILL. That's just a guess, though.
-Corey

I can reproduce it.  I uncommented out this line vim vim/src/Makefile:
ABORT_CFLAGS = -DABORT_ON_INTERNAL_ERROR

I get:
E947: Job still running in buffer "!/bin/bash"
E316: ml_get: cannot find line 2

And with gdb, vim-8.2107 crashes at:
Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f637e333801 in __GI_abort () at abort.c:79
#2  0x00000000006114e3 in siemsg (s=0x6377bd "E316: ml_get: cannot find line %ld") at message.c:820
#3  0x00000000004c4d99 in ml_get_buf (buf=0x2507d10, lnum=<optimized out>, will_change=0) at memline.c:2623
#4  0x000000000042f893 in win_line (wp=<optimized out>, lnum=<optimized out>, startrow=<optimized out>, endrow=25, nochange=1, number_only=0) at drawline.c:691
#5  0x00000000004360a4 in win_update (wp=0x251d7b0) at drawscreen.c:2347
#6  0x0000000000434f24 in update_screen (type_arg=0) at drawscreen.c:317
#7  0x000000000060d7cd in main_loop (cmdwin=0, noexmode=0) at main.c:1403
#8  0x000000000060cd10 in vim_main2 () at main.c:901
#9  0x000000000060bb13 in main (argc=<optimized out>, argv=<optimized out>) at main.c:444

In memline.c:2666:
2654│         /*
2655│          * Find the data block containing the line.
2656│          * This also fills the stack with the blocks from the root to the data
2657│          * block and releases any locked block.
2658│          */
2659│         if ((hp = ml_find_line(buf, lnum, ML_FIND)) == NULL)
2660│         {
2661│             if (recursive == 0)
2662│             {
2663│                 /* Avoid giving this message for a recursive call, may happen
2664│                  * when the GUI redraws part of the text. */
2665│                 ++recursive;
2666├>                siemsg(_("E316: ml_get: cannot find line %ld"), lnum);
2667│                 --recursive;
2668│             }
2669│             goto errorret;
2670│         }

(gdb) p lnum
$7 = 2
(gdb) p *buf
$8 = {b_ml = {ml_line_count = 41013600, ml_mfp = 0x7f203eba8350 <main_arena+1808>, ml_flags = 40914176, ml_stack = 0x2704d00, ml_stack_top = 0, ml_stack_size = 5, ml_line_lnum =
 0, ml_line_ptr = 0x270da51 "pel@pel-cirrus7:~/sb/vim/src$ ", ml_line_len = 31, ml_locked = 0x0, ml_locked_low = 1, ml_locked_high = 1, ml_locked_lineadd = 0, ml_chunksize = 0x0
, ml_numchunks = 100, ml_usedchunks = 1}, b_next = 0x2713760, b_prev = 0x26b97f0, b_nwindows = 1, b_flags = 0, b_locked = 0, b_ffname = 0x0, b_sfname = 0x0, b_fname = 0x2704cf0
"vt", b_dev_valid = 0, b_dev = 0, b_ino = 0, b_fnum = 2, b_key = "2\000\000\000\000\000\000\000", b_changed = 0, b_ct_di = {di_tv = {v_type = VAR_NUMBER, v_lock = 0 '\000', vval
 = {v_number = 0, v_float = 0, v_string = 0x0, v_list = 0x0, v_dict = 0x0, v_partial = 0x0, v_job = 0x0, v_channel = 0x0, v_blob = 0x0}}, di_flags = 5 '\005', di_key = "changedt
ick\000\000\000\000\000"}, b_last_changedtick = 2, b_last_changedtick_pum = 2, b_saving = 0, b_mod_set = 0, b_mod_top = 0, b_mod_bot = 0, b_mod_xlines = 0, b_wininfo = 0x271f660
, b_mtime = 0, b_mtime_read = 0, b_orig_size = 0, b_orig_mode = 0, b_last_used =<PHONE_NUMBER>, b_namedm = {{lnum = 0, col = 0, coladd = 0} <repeats 26 times>}, b_visual = {vi_star
t = {lnum = 0, col = 0, coladd = 0}, vi_end = {lnum = 0, col = 0, coladd = 0}, vi_mode = 0, vi_curswant = 0}, b_visual_mode_eval = 0, b_last_cursor = {lnum = 1, col = 0, coladd
= 0}, b_last_insert = {lnum = 0, col = 0, coladd = 0}, b_last_change = {lnum = 0, col = 0, coladd = 0}, b_changelist = {{lnum = 0, col = 0, coladd = 0} <repeats 100 times>}, b_c
hangelistlen = 0, b_new_change = 0, b_chartab = "\000\000\000\000\000\000\377\003\376\377\377\207\376\377\377\a\000\000\000\000\000\000 \000\377\377\177\377\377\377\177\377", b_
maphash = {0x0 <repeats 256 times>}, b_first_abbr = 0x0, b_ucmds = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_op_start = {lnum = 0, col = 0,
 coladd = 0}, b_op_start_orig = {lnum = 0, col = 0, coladd = 0}, b_op_end = {lnum = 0, col = 0, coladd = 0}, b_marks_read = 0, b_u_oldhead = 0x0, b_u_newhead = 0x0, b_u_curhead
= 0x0, b_u_numhead = 0, b_u_synced = 1, b_u_seq_last = 0, b_u_save_nr_last = 0, b_u_seq_cur = 0, b_u_time_cur = 0, b_u_save_nr_cur = 0, b_u_line_ptr = {ul_line = 0x0, ul_len = 0
}, b_u_line_lnum = 0, b_u_line_colnr = 0, b_scanned = 0, b_p_iminsert = 0, b_p_imsearch = -1, b_kmap_state = 0, b_kmap_ga = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_grows
ize = 0, ga_data = 0x0}, b_p_initialized = 1, b_p_script_ctx = {{sc_sid = 0, sc_seq = 0, sc_lnum = 0, sc_version = 0} <repeats 83 times>}, b_p_ai = 0, b_p_ai_nopaste = 0, b_p_bk
c = 0x6c10e9 "", b_bkc_flags = 0, b_p_ci = 0, b_p_bin = 0, b_p_bomb = 0, b_p_bh = 0x6c10e9 "", b_p_bt = 0x6c10e9 "", b_has_qf_entry = 0, b_p_bl = 1, b_p_cin = 0, b_p_cino = 0x27
1fea0 "", b_p_cink = 0x271d120 "0{,0},0),0],:,0#,!^F,o,O,e", b_p_cinw = 0x271fdc0 "if,else,while,do,for,switch", b_p_com = 0x2721530 "s1:/*,mb:*,ex:*/,://,b:#,:%,:XCOMM,n:>,fb:-
", b_p_cms = 0x27109a0 "/*%s*/", b_p_cpt = 0x2707970 ".,w,b,u,t,i", b_p_cfu = 0x2707950 "", b_p_ofu = 0x27163f0 "", b_p_tfu = 0x27163d0 "", b_p_eol = 1, b_p_fixeol = 1, b_p_et =
 0, b_p_et_nobin = 0, b_p_et_nopaste = 0, b_p_fenc = 0x6c10e9 "", b_p_ff = 0x6c10e9 "", b_p_ft = 0x6c10e9 "", b_p_fo = 0x271d150 "vt", b_p_flp = 0x2721570 "^\\s*\\d\\+[\\]:.)}\\
t ]\\s*", b_p_inf = 0, b_p_isk = 0x6c10e9 "", b_p_def = 0x6c10e9 "", b_p_inc = 0x6c10e9 "", b_p_inex = 0x2716390 "", b_p_inex_flags = 0, b_p_inde = 0x271ff40 "", b_p_inde_flags
= 0, b_p_indk = 0x271fe70 "0{,0},0),0],:,0#,!^F,o,O,e", b_p_fp = 0x6c10e9 "", b_p_fex = 0x2721640 "", b_p_fex_flags = 0, b_p_key = 0x271fc20 "", b_p_kp = 0x6c10e9 "", b_p_lisp =
 0, b_p_menc = 0x6c10e9 "", b_p_mps = 0x271fc40 "(:),{:},[:]", b_p_ml = 0, b_p_ml_nobin = 0, b_p_ma = 0, b_p_nf = 0x271fd20 "bin,octal,hex", b_p_pi = 0, b_p_qe = 0x27163b0 "\\",
 b_p_ro = 0, b_p_sw = 8, b_p_sn = 0, b_p_si = 0, b_p_sts = 0, b_p_sts_nopaste = 0, b_p_sua = 0x2707990 "", b_p_swf = 1, b_p_smc = 3000, b_p_syn = 0x6c10e9 "", b_p_ts = 8, b_p_tx
 = 0, b_p_tw = 0, b_p_tw_nobin = 0, b_p_tw_nopaste = 0, b_p_wm = 0, b_p_wm_nobin = 0, b_p_wm_nopaste = 0, b_p_vsts = 0x270db70 "", b_p_vsts_array = 0x0, b_p_vsts_nopaste = 0x0,
b_p_vts = 0x6c10e9 "", b_p_vts_array = 0x0, b_p_keymap = 0x27079b0 "", b_p_gp = 0x6c10e9 "", b_p_mp = 0x6c10e9 "", b_p_efm = 0x6c10e9 "", b_p_ep = 0x6c10e9 "", b_p_path = 0x6c10
e9 "", b_p_ar = -1, b_p_tags = 0x6c10e9 "", b_p_tc = 0x6c10e9 "", b_tc_flags = 0, b_p_dict = 0x6c10e9 "", b_p_tsr = 0x6c10e9 "", b_p_ul = -123456, b_p_udf = 0, b_p_lw = 0x6c10e9
 "", b_p_twsl = 10000, b_ind_level = 8, b_ind_open_imag = 0, b_ind_no_brace = 0, b_ind_first_open = 0, b_ind_open_extra = 0, b_ind_close_extra = 0, b_ind_open_left_imag = 0, b_i
nd_jump_label = -1, b_ind_case = 8, b_ind_case_code = 8, b_ind_case_break = 0, b_ind_param = 8, b_ind_func_type = 8, b_ind_comment = 0, b_ind_in_comment = 3, b_ind_in_comment2 =
 0, b_ind_cpp_baseclass = 8, b_ind_continuation = 8, b_ind_unclosed = 16, b_ind_unclosed2 = 8, b_ind_unclosed_noignore = 0, b_ind_unclosed_wrapped = 0, b_ind_unclosed_whiteok =
0, b_ind_matching_paren = 0, b_ind_paren_prev = 0, b_ind_maxparen = 20, b_ind_maxcomment = 70, b_ind_scopedecl = 8, b_ind_scopedecl_code = 8, b_ind_java = 0, b_ind_js = 0, b_ind
_keep_case_label = 0, b_ind_hash_comment = 0, b_ind_cpp_namespace = 0, b_ind_if_for_while = 0, b_ind_cpp_extern_c = 0, b_no_eol_lnum = 0, b_start_eol = 1, b_start_ffc = 117, b_s
tart_fenc = 0x0, b_bad_char = 0, b_start_bomb = 0, b_bufvar = {di_tv = {v_type = VAR_DICT, v_lock = 2 '\002', vval = {v_number = 40923296, v_float = 2.0218794668192501e-316, v_s
tring = 0x27070a0 "\200Hp\002", v_list = 0x27070a0, v_dict = 0x27070a0, v_partial = 0x27070a0, v_job = 0x27070a0, v_channel = 0x27070a0, v_blob = 0x27070a0}}, di_flags = 5 '\005
', di_key = ""}, b_vars = 0x27070a0, b_listener = 0x0, b_recorded_changes = 0x0, b_has_textprop = 0, b_proptypes = 0x0, b_p_bexpr = 0x6c10e9 "", b_p_bexpr_flags = 0, b_p_cm = 0x
6c10e9 "", b_may_swap = 1, b_did_warn = 0, b_help = 0, b_spell = 0, b_shortname = 0, b_prompt_text = 0x0, b_prompt_callback = {cb_name = 0x0, cb_partial = 0x0, cb_free_name = 0}
, b_prompt_interrupt = {cb_name = 0x0, cb_partial = 0x0, cb_free_name = 0}, b_prompt_insert = 0, b_s = {b_keywtab = {ht_mask = 15, ht_used = 0, ht_filled = 0, ht_locked = 0, ht_
error = 0, ht_array = 0x2706bc8, ht_smallarray = {{hi_hash = 0, hi_key = 0x0} <repeats 16 times>}}, b_keywtab_ic = {ht_mask = 15, ht_used = 0, ht_filled = 0, ht_locked = 0, ht_e
rror = 0, ht_array = 0x2706cf0, ht_smallarray = {{hi_hash = 0, hi_key = 0x0} <repeats 16 times>}}, b_syn_error = 0, b_syn_slow = 0, b_syn_ic = 0, b_syn_spell = 0, b_syn_patterns
 = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_syn_clusters = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b
_spell_cluster_id = 0, b_nospell_cluster_id = 0, b_syn_containedin = 0, b_syn_sync_flags = 0, b_syn_sync_id = 0, b_syn_sync_minlines = 0, b_syn_sync_maxlines = 0, b_syn_sync_lin
ebreaks = 0, b_syn_linecont_pat = 0x0, b_syn_linecont_prog = 0x0, b_syn_linecont_time = {total = {tv_sec = 0, tv_usec = 0}, slowest = {tv_sec = 0, tv_usec = 0}, count = 0, match
 = 0}, b_syn_linecont_ic = 0, b_syn_topgrp = 0, b_syn_conceal = 0, b_syn_folditems = 0, b_sst_array = 0x0, b_sst_len = 0, b_sst_first = 0x0, b_sst_firstfree = 0x0, b_sst_freecou
nt = 0, b_sst_check_lnum = 0, b_sst_lasttick = 0, b_langp = {ga_len = 0, ga_maxlen = 0, ga_itemsize = 0, ga_growsize = 0, ga_data = 0x0}, b_spell_ismw = '\000' <repeats 255 time
s>, b_spell_ismw_mb = 0x0, b_p_spc = 0x271fe50 "[.?!]\\_[\\])'\"\t ]\\+", b_cap_prog = 0x2709240, b_p_spf = 0x271ff20 "", b_p_spl = 0x271ff60 "en", b_cjk = 0, b_syn_chartab = '\
000' <repeats 31 times>, b_syn_isk = 0x6c10e9 ""}, b_signlist = 0x0, b_has_sign_column = 0, b_netbeans_file = 0, b_was_netbeans_file = 0, b_write_to_channel = 0, b_cryptstate =
0x0, b_mapped_ctrl_c = 0, b_term = 0x0, b_diff_failed = 0}

I can't reproduce it with valgrind or asan build somehow.

Dominique wrote:

I can reproduce it.  I uncommented out this line vim vim/src/Makefile:
ABORT_CFLAGS = -DABORT_ON_INTERNAL_ERROR

I get:
E947: Job still running in buffer "!/bin/bash"
E316: ml_get: cannot find line 2

And with gdb, vim-8.2107 crashes at:
Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f637e333801 in __GI_abort () at abort.c:79
#2  0x00000000006114e3 in siemsg (s=0x6377bd "E316: ml_get: cannot find line %ld") at message.c:820
#3  0x00000000004c4d99 in ml_get_buf (buf=0x2507d10, lnum=<optimized out>, will_change=0) at memline.c:2623
#4  0x000000000042f893 in win_line (wp=<optimized out>, lnum=<optimized out>, startrow=<optimized out>, endrow=25, nochange=1, number_only=0) at drawline.c:691
#5  0x00000000004360a4 in win_update (wp=0x251d7b0) at drawscreen.c:2347
#6  0x0000000000434f24 in update_screen (type_arg=0) at drawscreen.c:317
#7  0x000000000060d7cd in main_loop (cmdwin=0, noexmode=0) at main.c:1403
#8  0x000000000060cd10 in vim_main2 () at main.c:901
#9  0x000000000060bb13 in main (argc=<optimized out>, argv=<optimized out>) at main.c:444

I failed to reproduce so far.  The stack shows win_line() called from
win_update, which has a check that "lnum" is not higher than
ml_line_count (line 2082).  But it appears "buf" is invalid, since
ml_line_count is 41013600.  Looks like either the buffer became invalid
after win_update() was called or before that.

I can't reproduce it with valgrind or asan build somehow.

It's likely timing critical.  You can add ch_log() statements to try to
figure out what is happening.
--
BLACK KNIGHT: None shall pass.
ARTHUR:       I have no quarrel with you, brave Sir knight, but I must cross
this bridge.

"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thanks for looking into this. I tried some older gcc versions, and I was still able to reproduce the problem with them, so I don't think it's compiler dependent. I was able to get segfaults with all of:
$ for i in 4.9 {5..9} ; do "gcc-$i" --version | head -n 1 ; done
gcc-4.9 (Debian 4.9.4-2) 4.9.4
gcc-5 (Debian 5.5.0-12) 5.5.0 20171010
gcc-6 (Debian 6.5.0-2) 6.5.0 20181026
gcc-7 (Debian 7.4.0-14) 7.4.0
gcc-8 (Debian 8.3.0-23) 8.3.0
gcc-9 (Debian 9.2.1-8) 9.2.1 20190909

-Corey

I tried adding a sleep after killing the terminal:
diff --git a/src/terminal.c b/src/terminal.c
index 07b2e973e..4fd59fedd 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -39,6 +39,7 @@
  */

 #include "vim.h"
+#include <unistd.h>

 #if defined(FEAT_TERMINAL) || defined(PROTO)

@@ -1475,6 +1476,7 @@ term_try_stop_job(buf_T *buf)
        return FAIL;

     job_stop(buf->b_term->tl_job, NULL, how);
+    usleep(10);

     // wait for up to a second for the job to die
     for (count = 0; count < 100; ++count)

Not that I'm proposing that as a fix; just as a diagnostic.
With a 1 microsecond sleep, the segfault was still reasonably reproducible. With a 10 microsecond sleep, I got a rare segfault (maybe 1/10); with a 100 microsecond sleep, I never got a segfault (0/10).
I have not yet found a place where I can insert a delay in order to make the segfault more likely.
-Corey

Corey Hickey wrote:

I tried adding a sleep after killing the terminal:
diff --git a/src/terminal.c b/src/terminal.c
index 07b2e973e..4fd59fedd 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -39,6 +39,7 @@
  */

 #include "vim.h"
+#include <unistd.h>

 #if defined(FEAT_TERMINAL) || defined(PROTO)

@@ -1475,6 +1476,7 @@ term_try_stop_job(buf_T *buf)
        return FAIL;

     job_stop(buf->b_term->tl_job, NULL, how);
+    usleep(10);

     // wait for up to a second for the job to die
     for (count = 0; count < 100; ++count)

Not that I'm proposing that as a fix; just as a diagnostic.
With a 1 microsecond sleep, the segfault was still reasonably
reproducible. With a 10 microsecond sleep, I got a rare segfault
(maybe 1/10); with a 100 microsecond sleep, I never got a segfault
(0/10).
I have not yet found a place where I can insert a delay in order to
make the segfault more likely.

I managed to reproduce.  Stepping in a debugger doesn't help and
enabling valgrind also changes the problem.  I added a few ch_log()
statements and could see that the waiting loop term_try_stop_job()
finishes very quickly instead of waiting for a second.  Changing the
argument to ui_delay() fixes it.
I'm not 100% sure this will fix the whole problem, even when the job
doesn't die it should still not crash.
--
BLACK KNIGHT: The Black Knight always triumphs. Have at you!
ARTHUR takes his last leg off.  The BLACK KNIGHT's body lands upright.
BLACK KNIGHT: All right, we'll call it a draw.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thank you very much. I can confirm that this fixes the segfault I was seeing. If there is a remaining corner case that isn't fixed, I can't find a way to reproduce it. I tried a perl script that traps the HUP, sleeps 1 second, then quits, but that hasn't induced a segfault.


How to develop a Mass matrix, whenever it is  weighted by  a matrix?

Dear @acfisher and  @mlstowell ,
I need your help to develop a mass matrix with weight a matrix.
{(ε + 3 chi | E (t) |^² I + 2 Chi ^3 A)} ∂E(t)/∂t   for this case
chi and  ε are scalars.
I is 3 X 3 unit Matrix  (Identity unit 3x3 matrix)
A is 3X3 matrix and E(t)^T is transpose of E(t).
|E(t)|^2 = E(t). E(t)^T= E_1^2+E_2^2+E_3^2= > Inner_Product(E(t),E(t))
E(t)= (E_1, E_2 , E_3)  and E(t)^T= (E_1, E_2 , E_3)^T
The matrix A_3X3  is obtained in such a way A= E^T E.
A  is 3x3 matrix , the entries of matrix are given below
           E_1.E_1      E_1.E_2       E_1.E_3         **... first row of A**
      A =  E_1.E_2      E_2.E_2       E_2.E_3         **... second row of A**
           E_1.E_3      E_3.E_2       E_3.E_3         **... third row of A**

MatrixCoefficient *matrix:
N= new BilinearForm(&Nedelec);
N->AddDomainIntegrator(new VectorFEMassIntegrator(matrix));
N->Assemble();
N->Finalize();
N->FormSystemMatrix(ess_bdr, *Nspmat);
matrix={(ε + 3 chi | E (t) |^² I + 2 Chi ^3 A)}
How can I determine the MatrixCoefficient  at each time step?
How can I determine the mass matrix at each time step?
In case, the weight is VectorCoefficient than I am successful to developed a mass matrix at each time step. But I do not know in above case.
Thanks,
Asad Anees

Hi, @Asadanees ,
Coincidentally I just created a pull request #590 a few days ago which could implement these coefficients.  If your electric field is stored as a GridFunction, let's call it gfE, then you could define a VectorGridFunctionCoefficient called coefE.  Then you could use OuterProductCoefficient from PR #590 to represent your A matrix, the InnerProductCoefficient could be used for |E|^2, etc.
Once you have built your matrix coefficient using these pieces they will automatically use the values stored in gfE so just update this grid function and the coefficients will produce new values.  To create a new matrix at each time step you should only need to call N->Assemble(), N->Finalize() and N->FormSystemMatrix().
The relevant coefficients defined in PR #590 will probably not be available in the master branch of MFEM very soon but feel free to copy them into your application (with a comment stating where they came from if you don't mind).
Best wishes,
Mark

Hi, @Asadanees ,
I hope you're doing well.  We would like to close this issue if you have no further concerns.
Best wishes,
Mark

Hi @mlstowell
I am really grateful to you.
Best wishes.
anees


Fix dependabot incorrectly downgrading docker versions

In the edge case of Java versions, which include an extra "update_release" separated by _, and that can also include a variable number of segments, Dependabot would interpret something like 11.0.16_8-jdk as higher than <IP_ADDRESS>_1-jdk.
This is because up until now Dependabot considers all components equally for sorting, and the 4th component in the first version (8) is higher than the 4th component in the second (1), while previous components are equal.
The correct way to do this is to compare the "release segment" first, in this case, 11.0.16 vs <IP_ADDRESS>, and only if those are equal compare the "update segment".
With that logic in place, things sort as they should.

Thank you @mattt! I will merge and release this on Monday.


Update CHANGELOG.md

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   94.28%   94.28%
=======================================
  Files          16       16
  Lines         525      525
  Branches       20       20
=======================================
  Hits          495      495
  Misses         12       12
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5113e30...a2ac7b0. Read the comment docs.


x/text/unicode/collate/build: docs out of date

The docs for (* Builder).Build() say "TODO: return Weighter instead", but the method does indeed return a Weighter. The docs should be updated.

I was curious when this was introduced, so I did some code archeology.
I had to jump from x/text, through a rename, to x/exp, to main repo, and I found it in https://github.com/golang/go/commit/f38da96755cea4fde703b4601d5959150587eab4. It looks like a TODO comment that was added during development, the task was completed, and the comment was left behind by accident.


[jvm-packages] Add XGBOOST_RABIT_TRACKER_IP_FOR_TEST to set rabit tracker IP.

This fixes the CI failure due to internal IP on github action.

@CodingCat Oops, 1 second late.

Opened a revert PR in https://github.com/dmlc/xgboost/pull/6886

@wbo4958 Could you please reopen the PR and help look into https://github.com/dmlc/xgboost/pull/6869#pullrequestreview-641381474 ?  Sorry for the mess.


Question: View Month

How can the month will be shown in the template?

+1

+1

+1

On my fork of this project, everything works. I switched out bootstrap for foundation though.
Since the commit histories are different, I can't make a pull request but there ya go.
https://github.com/jonhairston/django-bootstrap-calendar


chore: unpin urlib 2

Related issue
# followed by the number of the issue
Summary
Notes
Please check if the PR fulfills these requirements

[ ] If necessary, the changelog has been updated
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] The commit message follows the conventional commit specification
For any breaking changes, companion PRs have been opened on the following repositories:

[ ] substra-tests
[ ] substrafl
[ ] substra-documentation

/e2e --tests sdk

End to end tests: :hourglass_flowing_sand: STARTING


First day for french is monday, not sunday.

Hi,
For french user, setting first day of week ( firstDayOfWeek: 0 ) is ok ( if i leave 1 for default, four june is shown as thuesday )
But monday does'nt move in first position.
Current behaviour

Expected behaviour

Thanks for the great work btw !
edit :
Strange, in the 'project homepage' your screen capture is showing monday on the left, does i miss a config ?

Please confirm which version of the card you are using?
This could be a bug with moving to dayjs in the latest version.

Hi, i confirm i am in 4.0.0 version. i did not notice this problem in 3.x version, so i agreed that it's possibly a new bug in 4.x version.
thank.

Thanks, I'll do some testing next time I get chance and see what's happening here.

Just done a quick test and can see the dates are moving correctly but the days don't change along the top, I will sort next time I'm working on the card.

@pinkfloydFR by default the card will follow the countries default start of week, for example with France it is LU for this you do not need to have any setting. However if you would like to have a different day of the week then you can change this with the setting firstDayOfWeek and set it from number 0-6 to get the desired day at the start of the week.
0 = Sunday
1 = Monday
2 = Tuesday
etc.

In my card i have :         firstDayOfWeek: 0
deleted this line : change nothing
tested with "firstDayOfWeek: 1" : change nothing ( and show wrong date ie 10 june is wednesday )

It sounds like the old version may be cached in your browser, to check:

Press F12
Go to the console tab
Check the atomic-calender-revive version shown is correct

If the version is incorrect press ctrl+shift+r a few times should force an update.
Confirm the version is correct then try again 👍
If the version is showing the latest please let me know.

You're write, console show me version 4.0.0, HACS show me version 4.2.1
I will try to install component mysel manually...

I don't understand....
copied the js file manually, clear all cache, restarting server, console always show me 4.0.0
In the atomic folder i have this now :
➜  atomic-calendar-revive git:(master) ✗ ll
total 2M
-rw-r--r--    1 root     root        1.9M Jun 10 10:24 atomic-calendar-revive.js
-rw-r--r--    1 root     root       32.7K Jun 10 10:12 atomic-calendar-revive.js.gz
-rw-r--r--    1 root     root      157.1K Jun 10 10:12 atomic-calendar-revive.js.old
old is my backup,

why there is a so huge size change ?
the old file is dated from today, so hacs do the update....

1.9mb is not right. The card is now only 157kb in size so I'm not sure why it is showing so large there.
HACS should be installing the correct version, I've just tested it via HACS and it has worked no problem.

Hum so strange, uninstalled, reinstalled, copied my code, no change, always start with DIM
Recreated an atomic card from scratch, copied my code, it's wprking, first day is LU.
the joys of computing... :D thanks for your support, and this great card !


phoebemirman/ch16952/notifications-not-being-set-to-unseen

https://app.clubhouse.io/augur/story/16952/notifications-not-being-set-to-unseen
fix for bug, changed color for dismiss all, give notification icon hover and selected color

Coverage remained the same at 63.225% when pulling f3725f2adfd782341eea779f2aa202b5c0a0148a on notifications-colors into d533d6d3600a7dde763ccd04189dbc300111b23a on master.


[TORII] Server - [tech debt] consolidate the pub/sub architecture

Some re-work had been done on that. Will close as too generic, and will be specialized in subsequent issues based on needs.


Fix model turns it white

this was after clicking the fix model button and before it loked like this

tried to use cats because it was used in a tutorial how to import a edited vroid model vrm with the colors into unity by using blender.
to figure out what the problem is I tried difrent combinations of the options and i think its the combining materials option because without it it doesn´t turn white but there are also jus empty materials exported to unty.

try exporting as a vrm 0.0 model out of vroid

I tried with vrm 0.0 but the result  is the same it still turns white after fixing the modell with cats.

Try turning off fix materials when Fixing model in cats. Mine showed up white only after I loaded a save and this fully fixed that for me

Thanks that realy helped


[1.10] Fixed bug in tag regex

Should I close this then?

Merging other PR into 1.11 line has nothing to do with it.
In other PR there were more changes, and theoretically this one can still be merged into 1.10 line.
On way or another I want to release 1.11 at weekend and then life of 1.10 will ends.

Yes, but do you actually want it merged? I'm not bothered either way, and it sounded like you thought there was no point in merging, which is fair enough.

fair enough


ENG-7827 add multiflow methods startAppFlow()

add startAppFlow()
update startSession() to fire completion and return SessionStartResult.

Test on both iOS and Android in the neuroid-reactnative-sdk-sandbox with a startAppFlow() command added in the NewApplication.tsx
iOS is updated to use the 3.3.1 SDK
Android is updated to use the 3.3.0 SDK

looking into failed tests

yeah missed that one. updated. thanks!


npm install error with RxJS peer dependency

Ionic version:
[ ] 1.x
[x] 2.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
Cannot complete npm install with rc4. Results in peerinvalid error, regardless of upgrading from rc3, or starting a new project.
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
Expected behavior:
Successfully complete npm install by installing all needed dependencies.
Steps to reproduce:
ionic start test --v2
Other information:

Ionic info:
Cordova CLI: 6.0.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.48
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v4.2.6
Xcode version: Xcode 8.2 Build version 8C38

I have the same error on Windows

It's works for me now.. You should update Node Version to the lastest stable (v6.9.2). You are using v4.2.6

@oscarvady Confirmed - it's working now!
Side note: I had no idea my Node was so out of date...

anyone knows why update node can solve this problem?


Game broken

When attempting to access this at https://GH-NonDEV-WS-0805.github.io/github-games-agutierrez689, I am getting a 404. This could be caused by a couple of things:

GitHub Pages needs to be enabled on the  branch. You can fix this in the repository settings.
The index.html file is incorrectly named inde.html. We will fix this together in class.

Can you fix the first bullet, please?

has been modified


Support applying WorkspaceEdit/editBuilder changes sequentially (and/or document current behaviour)

If you have a file like this:
ORIG 1
ORIG 2
ORIG 3

And you run this code:
const changes = new vs.WorkspaceEdit();
// Insert some text on line 1
changes.replace(document.uri, new vs.Range(new vs.Position(0, 0), new vs.Position(0, 0)), "LINE 1\n");
// Insert some text on line 2
changes.replace(document.uri, new vs.Range(new vs.Position(1, 0), new vs.Position(1, 0)), "LINE 2\n");
// Insert some text on line 3
changes.replace(document.uri, new vs.Range(new vs.Position(2, 0), new vs.Position(2, 0)), "LINE 3\n");
await vs.workspace.applyEdit(changes);

The final line inserted "LINE 3" ends up on line 5. This is (presumably) because VS Code is working out which locations to make the changes before applying any of them, then applying them all.
The Dart analysis server doesn't work this way; it provides a bunch of edits with the assumption that they'll be applied sequentially (so offsets are already adjusted for earlier changes in the list).
While it's fixable by using multiple WorkspaceEdits, you lose the "all or nothing" functionality provided by WorkspaceEdit and would have do manually roll changes back if one fails.
I think it'd be nice to support (both for WorkspaceEdit and editBuilder) allowing pre-adjusted offsets. If not, the docs should at least call out this behaviour so the it's clear to users that multiple edits inside a WorkspaceEdit will not have the same effect as multiple sequentially-applied WorkspaceEdits.

The Dart analysis server doesn't work this way; it provides a bunch of edits with the assumption that they'll be applied sequentially (so offsets are already adjusted for earlier changes in the list).

Interesting. I'd say the likelihood of us changing how edits are applied is low, not to say very, very low. Yeah, you can fire sequential edits (which isn't proper), talk to your server-folks, or do the merge math inside your extension.

@jrieken Understood (FWIW I was actually asking for an option, rather than changing the default). The chances of Dart language server changing are also kinda slim, since there are many IDEs using it as-is.
For now I'm firing sequential edits but I'll look at how hard it'd be to update the offsets - I do think it'd be nice if Code provided a helper for it though; I suspect having edits this way isn't unique to Dart so having it centralised would avoid many people re-implementing it.
Btw, can a note be added to the docs to at least mention this is how it works? Our implementation hsa been bad for a long time (though I think out of luck, none of the edits we got back had multiple edits until now).

I suspect having edits this way isn't unique to Dart so having it centralised would avoid many people re-implementing it.

TBH it's the first time I hear about such a request and it feels unnatural to me. I am not very keen on adding this because I don't want to confuse folks. Today, things are easy. You are in state A, apply n edits, end you end in state B.

I think it's easy to argue both ways make sense. If you were implementing a simple editor and someone gave you a bunch of edits, it seems like more work to figure out all the changes up-front without applying them than just looping through them and applying them to the current state each time.
Anyway, I don't feel strongly about it; I think there are few people implementing things where this's make sense so probably it's the right call not to add the complexity. I do think you should call it out in the docs though; just to help people if they do end up with a server that works how Dart's does. It took a bit of faffing for me to understand what was going on (I had edits with the same offsets that were all inserting characters and they just came through backwards! though admittedly, the server was sending the edit in a pretty bad way there).

@jrieken I tried to implement offset rewriting, but it turns out to not be possible. Let's say my changes say:

Insert a B at offset 1
Insert an A at offset 1

There's no offset I can give to Code that would insert an A at offset 1, because using offset 1 will instead insert the character at offset 2 because of the first edit. I could try re-ordering the edits; but I don't know if I could do that reliably (and also, if they overlap I'm stuck anyway).
I'm discussing the issue with the Dart server team but it does seem like having no support for atomic sequential edits is a limitation in Code. For now I'm going to just have to apply sequentially and hope they never fail; but that's far from ideal.

There's no offset I can give to Code that would insert an A at offset 1, because using offset 1 will instead insert the character at offset 2 because of the first edit.

How about merging the edits into 'Insert BA at offset 1'?


"N"-type flows don't work on GPUs

pdf = jammy_flows.pdf("e1+s2", "gggg+n", conditional_input_dim=4, hidden_mlp_dims_sub_pdfs="128-128").to("cuda")
inp = inp.to("cuda")
cond = cond.to("cuda")
pdf(inp, conditional_input=cond)

File ~/.local/lib/python3.10/site-packages/torch/nn/modules/module.py:1130, in Module._call_impl(self, *input, **kwargs)
   1126 # If we don't have any hooks, we want to skip the rest of the logic in
   1127 # this function, and just call forward.
   1128 if not (self._backward_hooks or self._forward_hooks or self._forward_pre_hooks or _global_backward_hooks
   1129         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1130     return forward_call(*input, **kwargs)
   1131 # Do not call functions when jit is used
   1132 full_backward_hooks, non_full_backward_hooks = [], []

File ~/.local/lib/python3.10/site-packages/jammy_flows/flows.py:970, in pdf.forward(self, x, conditional_input, amortization_parameters, force_embedding_coordinates, force_intrinsic_coordinates)
    966     assert(x.shape[0]==conditional_input.shape[0]), "Evaluating input x and condititional input shape must be similar!"
    968 tot_log_det = torch.zeros(x.shape[0]).type_as(x)
--> 970 base_pos, tot_log_det=self.all_layer_inverse(x, tot_log_det, conditional_input, amortization_parameters=amortization_parameters, force_embedding_coordinates=force_embedding_coordinates, force_intrinsic_coordinates=force_intrinsic_coordinates)
    972 log_pdf = torch.distributions.MultivariateNormal(
    973     torch.zeros_like(base_pos).to(x),
    974     covariance_matrix=torch.eye(self.total_base_dim).type_as(x).to(x),
...
    104     #extra_input_counter+=self.num_householder_params
    105 else:
    106     mat_pars=mat_pars.repeat(x.shape[0],1,1)

RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

Thanks, will fix this asap .. there might be some other errors like this in different flows as I have only worked on the cpu thus far ^^ - more GPU stress testing is very desired.

fixed in 725c73a330e770e19b341d44a8cafe904af31473

works!


Remove $ character from README CLI scripts

Remove $ character from readme CLI scripts to allow users to use the GitHub copy-paste button without needing to remove the $ character after paste.

@Christopher-Hayes thanks for the PR. I like the $ because it denotes that the code is run on the CLI, rather than in any other context. what do you think?

I respect that. I wish GitHub could have both.


Error installing bootstrap 5

Can u try to cd into the ramdisk directory and then run git checkout cfe0b0f63cd90ab43ba66c9bf44156f1ff766f9d, and back in the palera1n folder removing the blobs folder, then running the script again?

I fixed it with a simple reset of device ty for response

Tap "Remove" to uninstall bootstrap, relaunch the app and tap "Install" again will work.


Theme switching, custom themes

It's about time this feature was implemented

Hello again :-) So is this implemented? If so, what are the steps to implement a custom theme? I wanna try and make something that plays well with a semi transparent terminal background.

This is not currently implemented. I've redone the implementation around 3 times so far, but I'm now close to a user-friendly way of doing custom themes. Once this issue is closed as completed, it'll appear in a release.

Awesome, thanks for heads up


Simplify and explain source selection better

Seb had trouble setting things up the first time, so maybe creating a little setup tutorial mode as well as better explanations on how to setup profiles would be helpful

See https://github.com/wesen/glazed/issues/95


[Feature] Add Net Run Rate (NRR) option in Cricket Calculator

Description
Add a new option to calculate the net run rate for a match.
Pls assign me this issue.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[x] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @Ashish-1020


feat: Implement div_rem for UnsignedInteger

TITLE
Description
Implements the div_rem method for UnsignedInteger. This method is necessary to implement the api in the felt standarization crate
Type of change
Please delete options that are not relevant.

[x] New feature
[ ] Bug fix
[ ] Optimization

Checklist

[ ] Linked to Github Issue
[x] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report

Merging #473 (2e71c80) into main (d57ebb6) will increase coverage by 93.74%.
The diff coverage is 37.50%.

@@            Coverage Diff            @@
##           main     #473       +/-   ##
=========================================
+ Coverage      0   93.74%   +93.74%
=========================================
  Files         0       65       +65
  Lines         0     8600     +8600
=========================================
+ Hits          0     8062     +8062
- Misses        0      538      +538

Impacted Files
Coverage Δ

...src/field/fields/montgomery_backed_prime_fields.rs
93.37% <0.00%> (ø)

math/src/unsigned_integer/element.rs
95.47% <1.66%> (ø)

math/src/field/element.rs
95.51% <40.00%> (ø)

...field/fields/fft_friendly/stark_252_prime_field.rs
88.09% <84.78%> (ø)

... and 61 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Some more tests should be added to check Rem part is working, and even the division. It can be an easy division that's easy to check by hand


Global tasks are not triggered

According to the documentation, VSCode now supports global tasks. However, these are not automatically run by the plugin.
I can confirm I can run them manually but not via the plugin.
Steps to reproduce
Create a task in
~/Library/Application Support/Code/User/tasks.json
And configure the plugin to run them automatically.

Hello @Gruntfuggly thanks for your work in this awesome tool. Is there any way I could help with this? Maybe give more information or something

Hi - sorry it's taken a while, but I'm going to get a chance to look at this now.

I've added a fix. It looks like there is a bug in the global task implementation as the scope seems to come back as "workspace" still, but the fix should be OK.
Let me know how you get on.

Thank you so much! It seems that sometimes is working and sometimes it is not, but I'll keep debugging and add more info if needed.
thanks for your hard work!

Previously it was matching the workspace name against the task, so the fix was to ignore that test if the task scope did not have a name.
Not sure if that will help understand the problem though... 😕

Hi any updates on this, or can I close the issue?

Hello @Gruntfuggly ! I think you can close it now. It seems to be working ok now.
Thank you for your hard work man!

Glad you find it useful!


Add interfaces for star-tree V2

Codecov Report

Merging #2989 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #2989     +/-   ##
=========================================
- Coverage   69.99%   69.89%   -0.1%
=========================================
  Files         911      913      +2
  Lines       43260    43288     +28
  Branches     5915     5917      +2
=========================================
- Hits        30281    30258     -23
- Misses      10952    10995     +43
- Partials     2027     2035      +8

Impacted Files
Coverage Δ

...e/indexsegment/immutable/ImmutableSegmentImpl.java
64.28% <0%> (-1.17%)
:arrow_down:

...din/pinot/core/startree/v2/StarTreeV2Metadata.java
0% <0%> (ø)

...ore/startree/v2/AggregationFunctionColumnPair.java
0% <0%> (ø)

.../core/indexsegment/mutable/MutableSegmentImpl.java
66.86% <0%> (-0.2%)
:arrow_down:

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
:arrow_down:

...impl/dictionary/FloatOffHeapMutableDictionary.java
81.81% <0%> (-10.91%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-10.91%)
:arrow_down:

...e/operator/dociditerators/SortedDocIdIterator.java
54.05% <0%> (-10.82%)
:arrow_down:

...e/impl/dictionary/LongOnHeapMutableDictionary.java
86.66% <0%> (-8.89%)
:arrow_down:

...ng/builder/DefaultRealtimeRoutingTableBuilder.java
61.9% <0%> (-4.77%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0002137...ee9fa7e. Read the comment docs.


HAP-NodeJS stopped working in Raspberry Pi

I was running HAP-NodeJS for weeks on a Raspberry Pi 3. Suddenly, my accessories became unresponsive in Home app. I've removed them from my iPhone, then I couldn't add them back. I've reinstalled node, npm, and HAP-NodeJS.
Demo accessories included in a fresh git clone of HAP can't be added either. They doesn't show up when I try to add an accessory. It works fine when I start the server on my notebook, HAP just doesn't work on this Raspberry Pi and stopped working without any intervention. I've tried to find the accessories using other iPhones, no dice.
Here's the output from the HAP-NodeJS server running in Raspberry Pi 3
root@raspberrypi:/home/pi/HAP-NodeJS# DEBUG=* node BridgedCore.js
*** WARNING *** The program 'nodejs' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=nodejs>
*** WARNING *** The program 'nodejs' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=nodejs&f=DNSServiceRegister>
HAP-NodeJS starting...
Parsing accessory: Fan_accessory.js
Parsing accessory: GarageDoorOpener_accessory.js
Parsing accessory: Light_accessory.js
Parsing accessory: Lock_accessory.js
Parsing accessory: MotionSensor_accessory.js
Parsing accessory: Outlet_accessory.js
Parsing accessory: TemperatureSensor_accessory.js
Parsing accessory: Thermostat_accessory.js
  EventedHTTPServer Server listening on port 51826 +0ms
  EventedHTTPServer [::ffff:<IP_ADDRESS>] New connection from client +3m
  EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP server listening on port 35759 +4ms
  EventedHTTPServer [::ffff:<IP_ADDRESS>] Client connection closed +27ms
  EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP connection was closed +10ms
  EventedHTTPServer [::ffff:<IP_ADDRESS>] HTTP server was closed +6ms

All my devices are on the same wifi, and I can test from my notebook the port used by HAP in raspberry is open:
➜  HAP-NodeJS git:(master) ✗ nc -zv <IP_ADDRESS> 51826

found 0 associations
found 1 connections:
     1:	flags=82<CONNECTED,PREFERRED>
	outif en0
	src <IP_ADDRESS> port 61007
	dst <IP_ADDRESS> port 51826
	rank info not available
	TCP aux info available

Connection to <IP_ADDRESS> port 51826 [tcp/*] succeeded!

I appreciate any ideas to get this working again or how to conduct further investigation.

I've also encountered this issue lately.
The accessories parse correct but are not visible on my iPhone. No error messages or weird things are showing on de Raspberry.
Hope someone can find a solution for this :)

Hi Rodorgas
Have you tried deleting the persist file and changing the Usernames and pincodes in he accessory.js files? That has worked for me in the past.

@bluntiless
Thanks, removing the items in persist folder made is possible to add accessories again. (maybe caused by playing with accessories a lot)
But this forced me to re-add my already paired accessories and setup al my scenes containing those accessories again because the all were listed as 'non responsive'.
Is there a way to prevent this and to keep the paired accessories without adding them again and setting up all my scenes?
(sorry for highjacking the topic, but i think it's helpful for this problem. )

I've removed persist folder but it didn't fixed the problem. I even have cloned the repo again (it comes without persist folder) and also changed pins and username at the time.
But I tried again now and it's working fine without any modification, as mysteriously as when it stopped.

i've got the same issue few time ago, but at the end the problem was the memory card on the raspberry pi. I've reinstall all and until now it all ok. i've scheduled a backup of this memory one a week to another SD....

I hit this issue from time to time. Last time, Pi was shut down by a power outage and HAP didn't came back. I've spent the day digging on this problem, trying to make HAP work on my Raspberry Pi again. I found that this issue is kind of recurring: #384 #444 #261 etc.
The sintoms are weird: even running with DEBUG=* node Core.js (or BridgedCore.js), I get absolutely no error, everything seems normal. I can hit the port on another computer with nc -zv <IP_ADDRESS> 20 51826, and the HAP-NodeJS echoes a message saying it was received. But nothing shows up on iPhone when I try to add an accessory.
What I've done and didn't worked (each item was tried several times):

Rebooted Raspberry and iPhone (even try with other iPhone)
Change lock.pincode and lock.username
Removed persist/ and node_modules/, fresh npm rebuild and npm install
Fresh clone of this repo
Complete reinstall of node and npm
Tried several versions of node
Reinstall libnss-mdns and libavahi-compat-libdnssd-dev


Increment version for purview releases

Increment package version after release of Azure.ResourceManager.Purview

API change check
API changes are not detected in this pull request.

/check-enforcer override

Failure is unrelated to the change being made.  Merging.


react-native init is failing

Description
New Project creation fails due to https://github.com/CocoaPods/CocoaPods/issues/12081
React Native Version
0.72.5
Output of npx react-native info
info Fetching system and libraries information...
System:
  OS: macOS 14.0
  CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Memory: 526.26 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.12.1
    path: ~/.nvm/versions/node/v18.12.1/bin/node
  Yarn:
    version: 1.22.19
    path: ~/.nvm/versions/node/v18.12.1/bin/yarn
  npm:
    version: 8.19.2
    path: ~/.nvm/versions/node/v18.12.1/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.13.0
    path: /Users/tayyab/.gem/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10811636
  Xcode:
    version: 15.0/15A240d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: <IP_ADDRESS>
    path: /usr/bin/javac
  Ruby:
    version: 3.2.0
    path: /Users/tayyab/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.5
    wanted: 0.72.5
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Steps to reproduce
Just create new project using
npx react-native init test
Snack, screenshot, or link to a repository
https://github.com/cstayyab/react-native-issue-40737

I'm also getting the same error, and I haven't been able to solve it.

Even I'm getting the same error for the past 3 days. The bundling is not happening properly

Workaround:
When react-native init fails at cocoapods installation, do the following steps:

Go to your project directory and open Gemfile
Replace Cocoapods version with 1.13
Insert following line at the end of Gemfile :  gem 'activesupport', '~> 7.0.8'
Run bundle install in your project directory
Go to ios directory in your project
Run bundle exec pod install

Now proceed as you would if react-native init was successful

Workaround:
When react-native init fails at cocoapods installation, do the following steps:

Go to your project directory and open Gemfile
Replace Cocoapods version with 1.13
Insert following line at the end of Gemfile :  gem 'activesupport', '~> 7.0.8'
Run bundle install in your project directory
Go to ios directory in your project
Run bundle exec pod install

Now proceed as you would if react-native init was successful

It's working successfully this way, but when I create another project, I encounter the same error. Isn't there a permanent solution?

The fix has been made, it just needs to be released.

Workaround:
When react-native init fails at cocoapods installation, do the following steps:

Go to your project directory and open Gemfile
Replace Cocoapods version with 1.13
Insert following line at the end of Gemfile :  gem 'activesupport', '~> 7.0.8'
Run bundle install in your project directory
Go to ios directory in your project
Run bundle exec pod install

Now proceed as you would if react-native init was successful

I'm still facing an issue when I run bundle install
In Gemfile:   cocoapods was resolved to 1.13.0, which depends on     cocoapods-core was resolved to 1.13.0, which depends on       typhoeus was resolved to 1.4.0, which depends on         ethon was resolved to 0.16.0, which depends on           ffi

Duplicates https://github.com/facebook/react-native/issues/39832


⚠ Samsung has degraded performance

In be016cf, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2575 ms

Resolved: Samsung performance has improved in ae5e538.


updated regions to use new hurl version

Hurl has been updated, so creating a new list of AMI's with new version of Hurl. Tested and ok, also tested for AB
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$ ./bees up -l ubuntu -g bees2 -k bees_key -s 2 -z ap-northeast-1a,eu-west-1b,us-east-1b,us-west-1b,us-west-2b,ap-southeast-1a,ap-southeast-2b,sa-east-1b -i ami-eeeb258f,ami-b31362c0,ami-1b55360c,ami-8b014ceb,ami-d5be69b5,ami-b0fa22d3,ami-739cab10,ami-4cb92820
Connecting to the hive.
GroupId found: bees2
Placement: ap-northeast-1a
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: eu-west-1b
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: us-east-1b
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: us-west-1b
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: us-west-2b
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: ap-southeast-1a
Attempting to call up 2 bees.
Connecting to the hive.
GroupId found: bees2
Placement: ap-southeast-2b
Attempting to call up 2 bees.
Waiting for bees to load their machine guns...
Waiting for bees to load their machine guns...
Connecting to the hive.
GroupId found: bees2
Placement: sa-east-1b
Attempting to call up 2 bees.
Waiting for bees to load their machine guns...
.
Waiting for bees to load their machine guns...
Waiting for bees to load their machine guns...
.
.
.
.
Waiting for bees to load their machine guns...
Waiting for bees to load their machine guns...
.
.

Bee i-afd4a900 is ready for the attack.
.
.
.
Bee i-ab3f211e is ready for the attack.
.
.
.
Bee i-cbabb5c5 is ready for the attack.
Bee i-c8abb5c6 is ready for the attack.
Bee i-0e080882 is ready for the attack.
The swarm has assembled 2 bees.
.
.
Bee i-a0d4a90f is ready for the attack.
The swarm has assembled 2 bees.
Bee i-34514320 is ready for the attack.
.
.
Bee i-5dd954c9 is ready for the attack.
Bee i-5ed954ca is ready for the attack.
The swarm has assembled 2 bees.
Bee i-45e2d9da is ready for the attack.
Bee i-44e2d9db is ready for the attack.
The swarm has assembled 2 bees.
Bee i-0f080883 is ready for the attack.
The swarm has assembled 2 bees.
Bee i-dbe20f7c is ready for the attack.
Bee i-dae20f7d is ready for the attack.
The swarm has assembled 2 bees.
Bee i-35514321 is ready for the attack.
The swarm has assembled 2 bees.
Bee i-aa3f211f is ready for the attack.
The swarm has assembled 2 bees.
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$ ./bees report
Read 2 bees from the roster: eu-west-1b
Bee i-0e080882: running @ <IP_ADDRESS>
Bee i-0f080883: running @ <IP_ADDRESS>
Read 2 bees from the roster: ap-northeast-1a
Bee i-45e2d9da: running @ <IP_ADDRESS>
Bee i-44e2d9db: running @ <IP_ADDRESS>
Read 2 bees from the roster: ap-southeast-1a
Bee i-dbe20f7c: running @ <IP_ADDRESS>
Bee i-dae20f7d: running @ <IP_ADDRESS>
Read 2 bees from the roster: us-west-1b
Bee i-ab3f211e: running @ <IP_ADDRESS>
Bee i-aa3f211f: running @ <IP_ADDRESS>
Read 2 bees from the roster: us-east-1b
Bee i-cbabb5c5: running @ <IP_ADDRESS>
Bee i-c8abb5c6: running @ <IP_ADDRESS>
Read 2 bees from the roster: ap-southeast-2b
Bee i-afd4a900: running @ <IP_ADDRESS>
Bee i-a0d4a90f: running @ <IP_ADDRESS>
Read 2 bees from the roster: us-west-2b
Bee i-5dd954c9: running @ <IP_ADDRESS>
Bee i-5ed954ca: running @ <IP_ADDRESS>
Read 2 bees from the roster: sa-east-1b
Bee i-34514320: running @ <IP_ADDRESS>
Bee i-35514321: running @ <IP_ADDRESS>
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$ #allowing bees to initalize
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$ ./bees attack -j -u $testurl -f200 -H "Accept : text/html"
eu-west-1b
Read 2 bees from the roster: eu-west-1b
Connecting to the hive.
Assembling bees.
ap-northeast-1a
Read 2 bees from the roster: ap-northeast-1a
Connecting to the hive.
Assembling bees.
ap-southeast-1a
Read 2 bees from the roster: ap-southeast-1a
Connecting to the hive.
Assembling bees.
us-west-1b
Read 2 bees from the roster: us-west-1b
Connecting to the hive.
Assembling bees.
us-east-1b
Read 2 bees from the roster: us-east-1b
Connecting to the hive.
Assembling bees.
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
ap-southeast-2b
Read 2 bees from the roster: ap-southeast-2b
Connecting to the hive.
Assembling bees.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
us-west-2b
Read 2 bees from the roster: us-west-2b
Connecting to the hive.
Assembling bees.
Bee 0 is firing her machine gun. Bang bang!
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
sa-east-1b
Read 2 bees from the roster: sa-east-1b
Connecting to the hive.
Assembling bees.
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
Bee 1 is firing her machine gun. Bang bang!
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
Bee 1 is firing her machine gun. Bang bang!
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Each of 2 bees will fire 500 rounds, 50 at a time.
Stinging URL so it will be cached for the attack.
Organizing the swarm.
Bee 0 is joining the swarm.
Bee 1 is joining the swarm.
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Bee 1 is firing her machine gun. Bang bang!
Bee 0 is firing her machine gun. Bang bang!
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   0
     Connect-ms-max:            4.650000
     1st-resp-ms-max:           159.530000
     1st-resp-ms-mean:          60.534340
     Fetches/sec mean:          399.600798
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:<PHONE_NUMBER>54
     end2end-ms-min mean:       19.795500
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           0.700830

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   1
     Connect-ms-max:            129.993000
     1st-resp-ms-max:           402.685000
     1st-resp-ms-mean:          175.173178
     Fetches/sec mean:          133.333333
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            70666.666667
     end2end-ms-min mean:       122.543500
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           27.074445

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   1
     Connect-ms-max:            32.596000
     1st-resp-ms-max:           265.741000
     1st-resp-ms-mean:          107.425403
     Fetches/sec mean:          199.800200
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:<PHONE_NUMBER>94
     end2end-ms-min mean:       55.192500
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           4.779275

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   1
     Connect-ms-max:            192.349000
     1st-resp-ms-max:           541.656000
     1st-resp-ms-mean:          264.911630
     Fetches/sec mean:          133.288918
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            70643.126804
     end2end-ms-min mean:       189.245000
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           44.586382

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   1
     Connect-ms-max:            11.876000
     1st-resp-ms-max:           424.426000
     1st-resp-ms-mean:          254.749205
     Fetches/sec mean:          133.288918
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            70643.126804
     end2end-ms-min mean:       172.011500
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           2.832890

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   1
     Connect-ms-max:            179.685000
     1st-resp-ms-max:           466.853000
     1st-resp-ms-mean:          257.788017
     Fetches/sec mean:          133.244504
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            70619.586942
     end2end-ms-min mean:       183.417500
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           43.701755

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   2
     Connect-ms-max:            114.372000
     1st-resp-ms-max:           494.026000
     1st-resp-ms-mean:          260.096383
     Fetches/sec mean:          99.950025
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            52973.513243
     end2end-ms-min mean:       179.185000
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           28.387923

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.

Offensive complete.

Summarized Results
     Total bytes:               212000
     Seconds:                   2
     Connect-ms-max:            4.084000
     1st-resp-ms-max:           889.773000
     1st-resp-ms-mean:          236.832455
     Fetches/sec mean:          116.597264
     connect-ms-min:            0.000000
     Total fetches:             400
     bytes/sec mean:            61796.550093
     end2end-ms-min mean:       88.403000
     mean-bytes-per-conn:       530.000000
     connect-ms-mean:           0.665180

Response Codes:
     2xx:                       400
     3xx:                       0
     4xx:                       0
     5xx:                       0

Mission Assessment: Target crushed bee offensive.
The swarm is awaiting new orders.
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$
:~/git/beeswithmachineguns$ ./bees down
Read 2 bees from the roster: eu-west-1b
Connecting to the hive.
Calling off the swarm for eu-west-1b.
Stood down 2 bees.
Read 2 bees from the roster: ap-northeast-1a
Connecting to the hive.
Calling off the swarm for ap-northeast-1a.
Stood down 2 bees.
Read 2 bees from the roster: ap-southeast-1a
Connecting to the hive.
Calling off the swarm for ap-southeast-1a.
Stood down 2 bees.
Read 2 bees from the roster: us-west-1b
Connecting to the hive.
Calling off the swarm for us-west-1b.
Stood down 2 bees.
Read 2 bees from the roster: us-east-1b
Connecting to the hive.
Calling off the swarm for us-east-1b.
Stood down 2 bees.
Read 2 bees from the roster: ap-southeast-2b
Connecting to the hive.
Calling off the swarm for ap-southeast-2b.
Stood down 2 bees.
Read 2 bees from the roster: us-west-2b
Connecting to the hive.
Calling off the swarm for us-west-2b.
Stood down 2 bees.
Read 2 bees from the roster: sa-east-1b
Connecting to the hive.
Calling off the swarm for sa-east-1b.
Stood down 2 bees.
:~/git/beeswithmachineguns$#Testing for AB as well

voidconf@workpc:~/git/beeswithmachineguns$ ssh -i ~/.ssh/bees_key.pem<EMAIL_ADDRESS>"ab --help"
ab: wrong number of arguments
Usage: ab [options] [http[s]://]hostname[:port]/path
Options are:
    -n requests     Number of requests to perform
    -c concurrency  Number of multiple requests to make at a time
    -t timelimit    Seconds to max. to spend on benchmarking
                    This implies -n 50000
    -s timeout      Seconds to max. wait for each response
                    Default is 30 seconds
    -b windowsize   Size of TCP send/receive buffer, in bytes
    -B address      Address to bind to when making outgoing connections
    -p postfile     File containing data to POST. Remember also to set -T
    -u putfile      File containing data to PUT. Remember also to set -T
    -T content-type Content-type header to use for POST/PUT data, eg.
                    'application/x-www-form-urlencoded'
                    Default is 'text/plain'
    -v verbosity    How much troubleshooting info to print
    -w              Print out results in HTML tables
    -i              Use HEAD instead of GET
    -x attributes   String to insert as table attributes
    -y attributes   String to insert as tr attributes
    -z attributes   String to insert as td or th attributes
    -C attribute    Add cookie, eg. 'Apache=1234'. (repeatable)
    -H attribute    Add Arbitrary header line, eg. 'Accept-Encoding: gzip'
                    Inserted after all normal header lines. (repeatable)
    -A attribute    Add Basic WWW Authentication, the attributes
                    are a colon separated username and password.
    -P attribute    Add Basic Proxy Authentication, the attributes
                    are a colon separated username and password.
    -X proxy:port   Proxyserver and port number to use
    -V              Print version number and exit
    -k              Use HTTP KeepAlive feature
    -d              Do not show percentiles served table.
    -S              Do not show confidence estimators and warnings.
    -q              Do not show progress when doing more than 150 requests
    -l              Accept variable document length (use this for dynamic pages)
    -g filename     Output collected data to gnuplot format file.
    -e filename     Output CSV file with percentages served
    -r              Don't exit on socket receive errors.
    -h              Display usage information (this message)
    -Z ciphersuite  Specify SSL/TLS cipher suite (See openssl ciphers)
    -f protocol     Specify SSL/TLS protocol
                    (SSL3, TLS1, TLS1.1, TLS1.2 or ALL)
voidconf@workpc:~/git/beeswithmachineguns$

I believe this has been superseded by the latest pull request that updated the Amis


 I'm preparing a subsequent PR to update the partiql-tests and once that PR merge, I'll update the submodule in this repo, here is the current failures:
failures:
    partiql_tests::partiql_tests_data::fail::syntax::query::select::select::select_query_missing_from_test
    partiql_tests::partiql_tests_data::fail::syntax::query::select::select::select_without_comma_between_projection_items_test
    partiql_tests::partiql_tests_data::success::syntax::primitives::parameter::parameter_expression_test
    partiql_tests::partiql_tests_data::success::syntax::primitives::parameter::select_with_parameter_and_literals_test
    partiql_tests::partiql_tests_data::success::syntax::primitives::time_constructor::time_no_space_between_keyword_and_quote_test

In the above time_no_space_between_keyword_and_quote_test is wrong pending a PR for correction:
{
    name: "TIME no space between keyword and quote",
    statement: "TIME'02:30:59",
    assert: [
        {
            result: SyntaxSuccess
        },
    ]
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing this PR in favor of #163


This is not an issue

Can you please let me know how to run it Properly . And configure the dataset properly. I am new to this field ... HELP WILL BE APPRECIATED
Thank You Very Much

Hi, I just upload the conda environment to this repo. Basically, you can run the code by following steps:

Clone this repo to you local computer

git clone https://github.com/guopengf/FL-MRCM.git

Set up conda environment

cd FL-MRCM
conda env create -f conda_environment.yml
conda activate recon

Follow the instruction in README to download the preprocessed data via OneDrive or BaiduYun.

Correct the dataset path

In main_fl_mr.py Line 23-26, change the path to where you save the datasets.
Since HPKS dataset currently is not released, you may remove 'H' dataset for now.

Run the code

python main_fl_mr.py --phase train --dataset mri --model unet --epochs 50 --challenge singlecoil --local_bs 16 --num_users 3 --local_ep 2 --train_dataset BFI --test_dataset B --sequence T1  --accelerations 4 --center-fractions 0.08 --val_sample_rate 1.0 --save_dir 'Dir path for saving checkpoints' --verbose

replace the 'Dir path for saving checkpoints' to your exp folder

Monitor the traning process

tensorboard --logdir 'Dir path for saving checkpoints'

Hopefully, this can help you get started.

THANK YOU
AND WILL COMMENT HERE IF THERE ARE ANY ISSUES


requeue placement when toleration seconds expire

Ref:
https://github.com/stolostron/backlog/issues/20179
https://github.com/open-cluster-management-io/community/issues/48
This PR is based on proposal 20-taint-toleration

cover the case when the toleration has TolerationSeconds
requeue placement when toleration seconds expire

/assign @qiujian16 @elgnay

/hold

/unhold

/approve

/lgtm


Adding --head option for homebrew formula

Hello again. This PR adds 4 things:

Just some fixes for the brew audit listing checks.
A head option to allow building of the app directly from main instead of at a particular tag/version. You can do that with brew install --build-from-source --head cook.
Bumped the version of cook to 0.0.9.
Removed the make prepare step from the build process. I misunderstood what that step was for, and it isn't needed to build the app.

Thanks!

@theunraveler thank you!


Timeout property has no effect

Hello!
I noticed that the timeout option has no effect on the behavior of the widget
            "name": "bower-asset/yii2-pjax",
            "version": "v2.0.5",
            "source": {
                "type": "git",
                "url": "https://github.com/yiisoft/jquery-pjax.git",
                "reference": "6818718408086db6bdcf33649cecb86b6b4f9b67"
            },

I'm using it this way
    <?php \yii\widgets\Pjax::begin([
        'id' => 'widget',
        'timeout' => 3000,
    ]) ?>

It looks fine in the page source code
    jQuery(document).pjax("#widget a", "#widget", {"timeout":3000,"push":true,"replace":false,"scrollTo":false});

But the option has no effect unless I set it globally via $.pjax.defaults.timeout = 3000;
Could it be an issue?

Basic app template:
SiteController.php
diff --git a/controllers/SiteController.php b/controllers/SiteController.php
index 33f6227..4c497a8 100644
--- a/controllers/SiteController.php
+++ b/controllers/SiteController.php
@@ -95,6 +95,12 @@ class SiteController extends Controller
         ]);
     }

+    public function actionSleep()
+    {
+        sleep(3);
+        return $this->renderAjax('about');
+    }
+
     public function actionAbout()
     {
         return $this->render('about');

view about.php
diff --git a/views/site/about.php b/views/site/about.php
index 752342c..18220b9 100644
--- a/views/site/about.php
+++ b/views/site/about.php
@@ -17,4 +17,8 @@ $this->params['breadcrumbs'][] = $this->title;
     <?= Yii::t('app', 'ru-RU тест') ?>

     <?= __FILE__ ?>
+
+    <?php \yii\widgets\Pjax::begin(['timeout' => 3000]); ?>
+        click
+    <?php \yii\widgets\Pjax::end(); ?>

This code works as expected: clicking on link triggers PJAX request, the client side waits 3 seconds waiting for the response, then navigates to /site/sleep URL with full page reload.
When I decrease sleep time in the controller action, PJAX loads the response without page reload.
How to reproduce the problem?

Sorry. It's my fault.
I've used $.pjax.reload to reload the container. Apparently it uses the default timeout value.


Separate collection

on top of #328
to properly document and validate the collection RDF this PR moves the specification of the collection RDF into its own submodule. The format version stays synced with the general RDF.

As we are not expecting any models in any current collections at all this PR stops the special treatment of model entries in the collection that consistet only of a download_url.


[WIP] Getting rid of cross-realm bots

This depends on #17452 and #17516, so it has a bunch of initial commit from those PRs, will rebase appropriately when those get reviewed/fixed and merged. New commits begin with test_webhooks_common: Compare users by id not email.
What this does right now: Finishes the first logical part of the migration - adds the bots to every realm, makes get_system_bots take a realm (realm_id strictly speaking, to avoid fetching .realm attribute of objects just to call this function) argument and adjusts production code and all tests accordingly to make things work and the CI pass. I don't think this should be considered for merging without the follow-up parts. The main commit is bots: Put system bots in each realm. , the remaining are just follow-up adjustments to the changes this commit introduces.
What's left to be done:

Actually killing cross-realm messages - clean up all the code for handling those (and make sure they can't be sent anymore), rename/remove the various cross_realm named concepts.
Migrating existing cross-realm messages to use the in-realm bot instead of the zulipinternal bot as recipient/sender.

A good thing to note from Tim when we do final review: "I guess one other thing we'll need to figure out here is how we want administration of these bots to be once they're part of organizations -- have we decided whether administrators will be able to deactivate them (etc.)?"

Yeah, that's a good question. I think we should, at least for now, make it impossible to deactivate them (maybe we could allow changing name if that's something useful)- just like right now orgs don't have control over these bots. To allow their deactivation would mean having to take that possibility into account in every place where we try to send a message from a system bot. Conceptually,  the right way  to think of these bots is probably that they're just a built-in, native piece of the server - rather than regular bot account under org administration's control

Added a db migration that takes all cross-realm messages and "moves them" to belong (whether in the sender or recipient sense) to the corresponding in-realm bot. Tested manually by creating various cross-realm messages, running the migration and then messing around in the Django shell to verify validity of all data (Message senders/recipients, USerMessages, Subscriptions, Huddle hashes). Also by opening the webapp post-migration and verifying things look right.

If there are any more prep commits from this that we should look at for 4.0, rebase this and let me know, but I think probably there aren't?

@timabbott This should be reviewable now. Here are things that still need to be done:

Verify s3 uploads by email gateway bot work (https://chat.zulip.org/#narrow/stream/3-backend/topic/cross.20realm.20bots/near/1125101). Based on my current reading of the code it should work fine without needing upload migrations, but needs empirical verification. This is a blocker for merging.
There are still a lot of references to cross-realm bots throughout the codebase. This PR is already massive and hard to review, so perhaps those cleanups should be done as follow-ups? Basically, all the references will need to be changed to "system bots" instead - this is easier for comments, but harder for something like cross_realm_dict in people.js and all the related code which will need more thoughtful renaming of things to make sense. There'll surely also still be chunks of dead code through the codebase that was meant for handling the special cases of cross-realm bots and now will need to be removed.

For help with reviewing - main commits are:

bots: Put system bots in each realm.
... Then we have a bunch of minor steps to migrate all sorts of pieces of code ...
bots: Add migration to turn cross-realm Messages into in-realm ones.
bots: Completely disallow cross-realm messages. is not that large but is the 3rd "core" commit here.

I merged the couple commits ending with 119f1da04afba9ac3b7f3cc1287597e981955b6b, after adding an API feature level bump in that second commit.
My recommended next step is to make a separate PR on top of master for the commits that pass a realm_id to get_system_bot; we can merge those all as preparatory commits with get_system_bot ignoring the realm_id parameter, to get that refactoring in without changing any production behavior.  We can then lock that down by making the realm a required parameter to get_system_bot, and have most of the "individual feature" audit work fully integrated in master before we try to do the "big cutover" commit.

@timabbott This is now rebased and should be reviewable again. This doesn't have the removal system bot realm  or the other changes to go with it, but I think that may be best as a direct follow-up to merging the current part given how large it already is? This does leave the system bot realm in a pretty useless state, but shouldn't break anything.


Sorry.It's my fault.

I'm opening this issue because:

[x] I have found a bug

[ ] I want to request a feature

[ ] I have a question

[ ] Other

My Go version is: (paste the output of go version and remember that qr-filetransfer requires at least version 1.8 of Go)

My GOPATH is set to: (paste the output of echo $GOPATH)

Hi @littlebear333, glad to hear the issue is solved now!