Set up Travis and AppVeyor projects

So tests are automatically run on a variety of platforms when PRs are submitted.

[x] Travis-CI: #32
[ ] AppVeyor


Ticket/2.7.x/9879

This patch improves readability of puppet resource attribute display for
hash values.
Current output:
type { 'title':
  attribute => hashkeyhashvalue,
}

New output:
type { 'title':
  attribute => { hashkey => 'hashvalue' },
}

This pull is waiting on some updates discussed in the Redmine ticket.

@nanliu - I wanted to follow up and see if you had a chance to update this in response to the feedback from @jhelwig?

@nanliu - this duplicates some of the work done in both the PMT and Faces APIs, and can't be merged.  I am closing this pull request until the details discussed on the ticket get sorted out.


Token future time error

I am trying to verify the firebase token but sometimes, it is throwing token issued at future timestamp error, as in the following exception:
This token has been issued in the future at 2019-06-07T08:43:57+00:00, is your system time correct? {"exception":"[object] (Firebase\\Auth\\Token\\Exception\\IssuedInTheFuture(code: 0): This token has been issued in the future at 2019-06-07T08:43:57+00:00, is your system time correct? at /var/www/html/vendor/kreait/firebase-tokens/src/Verifier.php:95)

I debugged the the code, and I saw the following rows are the problem:
    private function verifyAuthTime(Token $token)
    {
       ...
        if ($token->getClaim('auth_time') > time()) {
            throw new InvalidToken($token, "The user's authentication time must be in the past");
        }
    }

The difference is between the auth_time and time() only a few seconds.

Thanks for bringing this up! I've known the problem for quite some time now, and I think it's time that I address it. I'll work on this soon!

Implemented #14 with 7e9877a0187e88c3d96372e2d06cdecc6db87254

Hello, I have this problem now, could this be someting related to the server time?

That's the likely cause, yes! You can verify a token with leeway to give the verification more "room": https://github.com/kreait/firebase-tokens-php#verify-an-id-token

Yeah, I fixed it, server time was 20 minutes in the past, thanks for the return tho

i'm still getting error when test token in postman it works fine but when send it from client side angular it return this error:
The value 'eyJhbGciOiJSUzI...' is not a verified ID token:\n- - The token was issued in the future\n
my code :
        $auth = app('firebase.auth');         try {             return $auth->verifyIdToken($this->verifierId);         } catch (FailedToVerifyToken $e) {             throw new InvalidTokenException($e->getMessage(),$e->getCode());         }


Mount & Blade: Warband crash on launch

Warband crashes after intro video. Works fine without d9vk.
Module selection window works fine.
Software information
Game version 1.172 from gog.  Default configuration (dx9 rendering, no AA, using pixel shaders)
System information

GPU: r7 360
Driver: mesa 19.2.0-devel (git-84816d1464) / llvm 9.0.0svn
Wine version: 4.7 staging
DXVK version: 0.11 release

Apitrace file(s)
I wan't been successfull in capturing trace with or without d9vk for this game.
Log files
mb_warband_d3d9.log. Other are clear.

Works for me.

Make sure you have necessary d3dx9_.dll andd3dcompiler. It seems game need:
d3dx9_27.dll
d3dx9_31.dll
d3dx9_41.dll
d3dx9_43.dll
d3dcompiler_43.dll

I've installed these specific dlls via winetricks and it didn't help. I've tried clean prefixes with installing either d3dx9 or these libraries one by one and game said that that i didn't have directx installed. Sorry, but am I doint something wrong? I've lived with this prefix for so long that I've completely forgot how to do things.

In the logs, i see
info:  DXVK: d9vk-0.10

But you say you have D9VK 0.11:
DXVK version: 0.11 release

Can you confirm it reports
info:  DXVK: v1.1.1

with your new wineprefix (ir reports this with my 0.11)?

i've noticed that it says '0.10' before, but '0.11' is how it is marked in releases, where i got it from. Did you build your one yourself?

My bad. I indeed have version built from latest commit, But apitrace replays fine with 0.11.
But I see big problem here: I only have original mount and blade, not warband. I forgot these are different. I'll test with demo.

Side note: It affects all games on Warband engine (doh!), like "Carribenan: Blood and Gold", "With Fire and Sword", "viking Conquest", etc.
What is more strange, is that it crashes in same manner, even when using native d3d9 (non-d9vk) - it works only with build-in wined3d, so far. How game written for windows can work like that is a mystery for me.
My crash log, just in case:
https://zerobin.net/?a8e1bc4ebd140de3#787NDqJBqTn7R7HG8BL/QEr1oig//u18mKawTzxG08s=

If it's still helpful, I have native Windows traces for the regular game and Warband.
Mount & Blade:
https://drive.google.com/file/d/1r5QTpKROEacsYf6jNjqmI7QP945smfPa/view?usp=sharing
Warband:
https://drive.google.com/file/d/1df8WfE-44IPTzC70lcEG_VoTerYqv3Ka/view?usp=sharing

Exactly same error at startup happens with Sid Meier's Pirates: Live the Life.

It crashes in d3d9_42.

No. It crashes in d3dx9_42. You're probably using the Wine implementation of d3dx9 despite the clear warning on the release page.

Please do not use wine's d3d9x or d3dcompiler with d9vk. They make invalid API calls and generate bad shaders. I cannot stress this enough.

Install the Microsoft one using winetricks d3dx9_42

No. It crashes in d3dx9_42.

Just a typo, which is pretty clear from backtrace and d3d9_42 does not even exist.

You're probably using the Wine implementation of d3dx9

No, I am not. I have full d3dx9 from winetricks.

This is now fixed in d3d9-fixed-function branch. When I return master, it starts crashing again. There is still problem with invisible mouse cursors, but that is tracked in WoW WotLK issue (there is whole discussion about it).

(screenshot is wrongly scaled, because wine virtual desktop for some reason does not work properly with Vulkan in wine master).

Thats awesome news! I hope that it goes into master soon :)

As expected, in 0.13f, Warband and other games on its engine start properly to the main menu. World 3D map can be entered, albeit, with glitches (for example, in case of Viking's Conquest, terrain is half-transparent - you can see "submerged" part of models, in terrain, like base blocks of cities.
Entering battle crashes on all variants (both vanilla Warband and any specific modules I've tested - "viking's Conquest", "Caribbean: Blood and Gold").

As of version 0.20, 3D map doesn't show any glitches anymore (no more half-transparent terrain or full brightness). Entering battle mode freezes game (not crashes). Tested to be the case on all modules I've tested (vanilla Warband, "Viking's Conquest", "Caribbean: Blood and Gold").
Strange thing I've noticed - conversations (which are rendering characters like in battle and some terrain behind them) are working fine, with properly rendered stuff. No idea why battles still crash.
"Caribbean: Blood and Gold", that was able to start up to main menu and 3D map in 0.13f, now freezes upon initial load, just after changing cursor to "cutlass" (the game's one) on current version.

the game is still working fine its just skipping rendering move the game out of the center of the screen it spawned on or to a 2nd screen use a controller and battles work fine its just when the cursor (which is being moved to the middle of the screen) is also on top of the window it just dose not draw anything with d9vk don't have a clue why (might have something to do with not rendering the cursor and skipping everything else?) this game is very weird.

this is where you can get the latest version of the game demo.

Seems to work fine here...

Still freezes in 3d battles as described in my previous comments, on 1.5.4. Attached are logs.
bg_caribbean_d3d9.log
Additionally, the game itself reports following errors in its own log (rgl_log.txt), which might be or not be relevant:
rgl_post_warning_line: Unable to get technique with name watermap_stratmap_high
rgl_post_warning_line: Unable to get technique with name oim_standart_skin_bump_nospecmap_high
rgl_post_warning_line: Unable to get technique with name oim_standart_flag_skin_bump_nospecmap
rgl_post_warning_line: Unable to get technique with name watermap_no_anim
rgl_post_warning_line: Unable to get technique with name blend_at_camera

Apart from that, where the game does work (menus, world map), textures are "corrupted" (blurry, pixelated), transparency doesn't seem to work properly, etc. Examples:
D9VK:

WineD3D:

D9VK:

WineD3D:

D9VK:

WineD3D:

I hope it helps to narrow down the issue.

Supplement:
I'm experiencing same graphical  glitches and 3d-battle mode freezes in native warband/warband demo. I'm getting the freezes even when trying to enter the tutorial.

As reported by @Riesi, the game freezes only when the mouse is moved - suggesting it is not D9VK/DXVK issue. Hoever, it keeps working fine with wined3d.
Apart from the very strange freeze, there is the highly degraded texture's resolution issue, as presented in the screenshots.

I'm very glad to report that the game both stopped to crash when mouse is moved, and most corrupted graphics issues are gone - with the version 1.5.5.
I'm saying "most", cause - while the examples from main menu (sky) and in-game are occurring with "pixelated" graphics no more, strangely, the menu example (with strange transparency:
https://user-images.githubusercontent.com/6075406/74095593-7d6c9d80-4af3-11ea-8492-f56273c549c2.jpg
...is still the case.
Hoever, at this point it is only very minor nuisance, and the game is 100% perfectly and comfortably playable, now. Thank you!
PS.
It applies to all warband titles I'm aware of (including "Caribbean: Blood and Gold" and "Viking's Conquests").

There is a separate issue on the tracker for the transparency so I am going to close this now.


feat: Add radio group card

Add a new option for the radio group. Radio group card. Related to #4528
The radio group card enables users to select options in a card style.

Thanks for this contribution. i already used it, and made two observations.

I was wondering, if border-2 on checked is a good default, because it can change the width of inline elements. (In my use case i omitted it.)
Focus does not highlight the element, as well as Hover. Radix has a simple default for this behaviours.


[Wave 6: Drafts] Update the styles of the Submit button based on who is looking at it

Part of https://github.com/Expensify/Expensify/issues/308213
Coming from here in the doc, we are going to have to update the styles of the Submit button based on who is supposed to take an action. The admin also can "force" submit the report, but in such case the button should not be bright green.

This was handled in https://github.com/Expensify/App/pull/28918


forgot to add profile.id reference

#6  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @trevorpfiz and the rest of your teammates on  Graphite


#26 提高ConfigurationBeanBindingPostProcessor优先级

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.hl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Bug] dicom-image-loader: Image all white - wrong min/max pixel values

Describe the Bug
Image is displayed all white, possibly due to wrong min/max values. When checking the min/max pixel values there is something odd.
In the dicom file itself the values are:

Smallest Image Pixel Value: 8192
Largest Image Pixel Value: 24575

When debugging cornerstone the values of the image are:

minPixelValue: 26624
maxPixelValue: 30613

Since the window center/window width values are 16384/16384, cornerstones min/max pixel values are clearly outside of the window.
Our suspicion is that something in the decoding of the JPEG goes wrong. The transfer syntax is: 1.2.840.10<IP_ADDRESS>.70
We are using the latest dicom-image-loader version 1.11.3.
Steps to Reproduce
Open this example dicom file using the dicom-image-loader and see how its initially displayed too bright.
The current behavior
The image is displayed all white (see image), only after changing the window center/width to values around 29348/7417 the image seems somehow okay.

The expected behavior
This JPEG rendering provided by our backend shows how the image would look like if rendered with correct intensity values.

OS
Windows 10, Ubuntu 23.04
Node version
v16.20.0, v18.17.1
Browser
Chrome 116.0.5845.111, Firefox 116.0.3

yeah seems too bright, i will investigate

@sedghi I just wanted to ask if there are any updates on this issue?

Not yet

I have done some investigation into this...

I have confirmed what @muellnerlisa has reported...

using the dicom-image-loader the image appears completely white
the min and max pixel values via debugging respectively are 26624 and 30613

loading the study from orthanc displays it correctly and the min and max pixel values are 8192 and 24575 respectively
3D slicer displays the study correctly and the min and max pixel values are as reported in the main dicom file

Yeah based on my investigation also this is the JPEGLossless codec, @muellnerlisa can you let us know how have you encoded this image?

@sedghi @jbocce Thank you for investigating! Unfortunately, I don't have specific details on the exact encoding of the image. It is part of a large anonymized dataset sourced from multiple origins.


Factory girl and Postgres UUID attempts to insert NULL.

Hey, I'm trying to use factory girl along with Postgres and a UUID PK in rails. It seems that when it attempts to create the object it inserts the PK as NULL rather than leaving it blank and causes Postgres' NOT NULL constraint to throw an error. Here is a gist I've created with all the information I think you'll need on the issue. Would you have any idea of how to fix this? Thank you for your time! https://gist.github.com/lethjakman/7292445

I didn't have time to actually look at it, but I got myself up and running like this:
id { SecureRandom.uuid }

Thanks for your suggestion. Works even today 😂


Issue 34 - add caching for npm dependencies

fixing issue #34
enabled caching on setup-node by adding cache: npm
https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/

It's a reasonable commit. I'm good with the merge.


Move execution policies to internal headers

This is in preparation for libstdc++ integration
The pstl policies themselves move to internal/execution_defs.h
internal/execution_impl.h now refers to internal/execution_defs.h instead of
../execution
The injection of pstl execution policies into namespace std:: moves to
internal/glue_execution_defs.h
In general, libstdc++ will re-export the internal/glue_*.h files from the pstl
implementation.

Commit 6621df6 fixes _InputIterator => ForwardIterator

I've added the conditional include checks we discussed over email.
FWIW, at least for the test suite build times, it makes no difference in compiler timings.


Add User identification/ authorization

User Story:
As a host, I want to identify my participants to avoid duplicate or invalid votes.
Acceptance Criteria:
General:

Acceptance Criteria: There is no way for one person to vote twice.


pkg/yaml:  Expose block vs. flow style of YamlNode

This issue was originally filed by @seaneagan

It would be useful to know whether a given YamlMap or YamlList are block style or flow style via an enum style property:
enum YamlNodeStyle BLOCK, FLOW /*, NONE ?*/;

This issue has been moved to dart-lang/yaml#6.


Assymetry between create and delete is odd

After I do: dm deploy redis:v1
I'm not expecting this:
$ dm list
[
  "redis-v1"
]

Nor am I expecting to have to delete it via:
$ dm delete redis-v1

I'd expect to delete redis:v1, like I created it.
ETA: I admit I'm probably missing something obvious.

Yes this is a little weird. We can probably name the deployment exactly after the type in this case to make things better.


Unable to customize directory length

I've tried to configure zstyle ':zim:prompt-pwd:fish-style' dir-length 4, but still see a directory length of 1. I believe this line is the root cause: https://github.com/zimfw/sorin/blob/beb3292ffa1e61451a5dd4933948f27e9436c979/sorin.zsh-theme#L53
Is there a way to override this value, while maintaining the default value of 1?

Hi @rdacquisto. You need to override the zstyle by setting it after the source ${ZIM_HOME}/init.zsh in your .zshrc file.

Oh thanks @ericbn. That makes a lot of sense.


[BUG] eww window fails to render if multiple widgets are inside a revealer

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
I'm trying to use a revealer to show/hide multiple buttons when hovered over. I've encountered a confusing issue, though. The revealer widget, it seems, when given multiple widgets at once will refuse to render. There is one button in this widget that is always visible, and three other buttons hidden behind a revealer triggered using the usual :onhover and :onhoverlost arguments of the eventbox widget.
In short, then, multiple widgets underneath a revealer widgets make the revealer widget break.
Reproducing the issue
In a simple configuration with an empty eww.scss, paste this code into the eww.yuck:
;; Power Widget
(defvar test-visible false)

(defwidget test []
  (eventbox
    :onhover "eww update test-visible=true"
    :onhoverlost "eww update test-visible=false"

    (box
      :class "test-box"
      :orientation "h"
      :space-evenly "false"
      :spaceing "2"

      (revealer
        :transition "slideleft"
        :reveal test-visible
        :duration "550ms"

        (button
          :class "first-button"
          :onclick "echo test"
          "󰜉"
        )

        (button
          :class "second-button"
          :onclick "echo test"
          "󰤂"
        )

        (button
          :class "third-button"
          :onclick "echo test"
          "󰤄"
        )
      )

      (button
        :class "visible-button"
        :onclick "echo test"
        "󰐥"
      )
    )
  )
)

;; Render bar
(defwindow bar
  :monitor 0
  :geometry (geometry
              :x "0%"
              :y "5px"
              :width "2250px"
              :height "65px"
              :anchor "top center"
            )
  :stacking "bg"
  :reserve (struts :distance "69px" :side "top")
  :windowtype "dock"
  :wm-ignore false
  (bar-content)
)

(defwidget bar-content []
  (box

    (box
      :halign "end"
      :spacing 2
      :space-evenly false

      (Power)
    )
  )
)

This code is just a somewhat modified version of what I already wrote in my EWW bar config, you can see the whole config if you believe it relevant at my dot files.
Expected behaviour
The expected behavior is fairly self-explanatory. Reveal all three buttons as shown in the sample config.
Additional context
I'm trying to define a widget for quick access to login buttons; poweroff, hibernate, suspend, reboot, etc.

Check eww logs, it should say something along the lines of GTK::Bin can't have more than one child. This isn't really a bug you just need to put your buttons in a box and that box in the revealer


Create Payment Response , Execute Payment Response also needed for sandbox validation, which is absent in this package

This package only return us the response like :
BkashPaymentResponse(trxId: AGP10BWXOB, payerReference:  , paymentId: TR0011hi0k0wq1690281134967, customerMsisdn:<PHONE_NUMBER>2, merchantInvoiceNumber: tranId, _executeTime: 2023-07-25T16:33:53:131 GMT+0600)
But as a merchant i need these 2 response to validate my sandbox merchant account and then i will get the live payment credentials from the pgwbkash merchant website
(1) Need the Create Payment Response like this -
{
"statusCode": "0000",
"statusMessage": "Successful",
"paymentID": "TR0011ON1565154754797",
"bkashURL": "https://sandbox.payment.bkash.com/redirect/tokenized/?paymentID=TR0011O N1565154754797&hash=Cg-Z)16.)d5E_BLhHIMmoxcm.LDMVQ.oI9o_v6qQU32nc7i2mUtDbP0_cVtIswrS-Rct1rJzJWEIPLk6cXFgRBT)rn6Q7!E.u91565154754979&mode=0011&apiVersion=v1.2.0-beta",
"callbackURL": "yourURL.com",
"successCallbackURL": "yourURL.com?paymentID=TR0011ON1565154754797&status=success",
"failureCallbackURL": "yourURL.com?paymentID=TR0011ON1565154754797&status=failure",
"cancelledCallbackURL": "yourURL.com?paymentID=TR0011ON1565154754797&status=cancel",
"amount": "15",
"intent": "sale",
"currency": "BDT",
"paymentCreateTime": "2019-08-07T11:12:34:978 GMT+0600",
"transactionStatus": "Initiated",
"merchantInvoiceNumber": "MER1231"
}
(2) Need the Execute Payment Response
like this :
{
"statusCode": "0000",
"statusMessage": "Successful",
"paymentID": "TR0011ON1565154754797",
"payerReference": "01770618575",
"customerMsisdn": "01770618575",
"trxID": "6H7801QFYM",
"amount": "15",
"transactionStatus": "Completed",
"paymentExecuteTime": "2019-08-07T11:15:56:336 GMT+0600",
"currency": "BDT",
"intent": "sale",
"merchantInvoiceNumber": "MER1231"
}

@dev-masum,
Please see it and if possible to update our package.

@rdnasim we have all 4 api implemetation for testing and custom implementation mentioned in Bkash developer documentation.
Please add it in out package documentation that any package user can test all apis of bkash through BkashApi() class
final bkashApis  = BkashApi();
bkashApis.createToken(...);
bkashApis.createToken(...);
bkashApis.createToken(...);
bkashApis.createToken(...);

To solve the problem download this project & set your bKash sandbox credentials in \example\lib\main.dart like the following:
final flutterBkash = FlutterBkash(
  bkashCredentials: const BkashCredentials(
    username: "sandboxTokenizedUser02",
    password: "sandboxTokenizedUser02@12345",
    appKey: "4f6o0cjiki2rfm34kfdadl1eqq",
    appSecret: "2is7hdktrekvrbljjh44ll3d9l1dtjo4pasmjvs5vl5qr3fug4b",
    isSandbox: true,
  ),
);

Goto \lib\src\utils\api_helper.dart and print the response.body in the case of statuscode 200
switch (response.statusCode) {
    case 200:
      print(response.body);
      return right(json.decode(response.body) as Map<String, dynamic>);
    case 400:
      return left(BkashFailure(message: "Bad Request"));
    case 401:
      return left(BkashFailure(message: "Unauthorized Access"));
    case 403:
      return left(BkashFailure(message: "Forbidden"));
    case 404:
      return left(BkashFailure(message: "Not Found"));
    case 500:
      return left(BkashFailure(message: "Internal Server Error"));
    default:
      return left(BkashFailure());
}

Now run \example\lib\main.dart and perform a payment. Then you get your JSON responses in debug console 😊

ok thanks brother

Sandbox endpoint: https://**.sandbox.bka.sh
Production endpoint: https://.**pay.bka.sh
is this DOT required on endpoint?

@hellotazim Yes, It is required.
Because it is the part of their domain.


Task | Understanding Paragraphs & Document Layout Analysis

Thanks for publishing this interesting work.
Would I be able to extend the Document Understanding task to learn hierarchies over paragraphs of text within a page? Or is the 512 token limit going to prohibit the OCR of paragraphs?
Would the input look like so?
{
    "file_name": {image_path1},
    "ground_truth": `{
          "item": [{ "title": "item-title", "text": "insert some paragraph of text"],
          "table": ["column 1 column 2 column 3 0 0 3],
          "title"; ["title page"]
    }`
}

Further, would it be possible to alter the task objective to Document Layout analysis and train on PubLayNet as per LayoutLMv3?

Just an idea, but you could probably model document hierarchy by adding special tokens to the tokenizer.
For example, DocVQA is trained using an input like '<s_docvqa><s_question>my question?</s_question><s_answer>', and the output then completes the input -> '<s_docvqa><s_question>my question?</s_question><s_answer>my answer</s_answer></s_docvqa>'
So following that logic, you could construct an input prompt as simply '<s_hierarchy>' and then the output could be '<s_hierarchy><s_title>My title<s_paragraph>My paragraph text</s_paragraph></s_title></s_hierarchy>'
This would work for training, as long as you add the proper special tokens.
In terms of the token limit though, you would definitely run into some problems. If you cared more about the structure, maybe you could just predict the first line of each hierarchical element to limit the prediction size. If you are working with synthetically generated data, this would be pretty easy to do!
In terms of doing DLA, by outputting the hierarchy you are already performing a type of layout analysis. Adapting existing datasets might be tough though, but maybe check out DocBank. They have token-level layout annotations that would work well for a text based model like this one

@logan-markewich I like your approach.
What's your thoughts on replacing the BART encoder with one of the long-rage Transformer architecture (e.g. LongFormer or Performer)?
I don't have much experience with them but I understand that have O(n) complexity instead of O(n2) with the sequence length.

@jordanparker6  I don't have any experience using long-range transformers, but it's probably worth trying! Assuming you have the resources needed to load and train the model 👍🏻
Thankfully looking at the code, swapping out BART for anything else should be pretty straightforward, and you won't have to repeat the OCR pre-training either.

Any updates on this? Why is Donut difficult for Document Layout Analysis task?


I want to run multiple method calls simultaneously

If I try to add (by highlighting) multiple methods at the same time , it only logs the latest one (see below):
// i want to log method1 and method2 at the same time
console.log(method1, method2)   // expected
console.log('METHOD2', method2) // actual

in this scenario it would actually be better to separately log each of these in diffferent console.log statements. Let me know if there is a specific reason you might want to run both in one call ?


Add prettier config

Adds a prettier config and .prettierignore file.
Anything else you want to add?

Semicolumns -> true
Arrow Function Parentheses -> always
Trailing Commas -> all
End of Line -> lf


 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
master passed

+0 :ok:
refguide
4m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 46s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

18m 55s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1799

Optional Tests
dupname asflicense refguide

uname
Linux d7279e87b6de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 79d56499ca

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 12500)

modules
C: . U: .

 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
master passed

+0 :ok:
refguide
4m 46s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 51s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

18m 35s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1799

Optional Tests
dupname asflicense refguide

uname
Linux bb74dfdac35e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f06248ef84

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Should we clearly say, then, that, although triggered at table/region level compactions happen per store?

IMO, it is unnessary since folks can get it in other chapters, WDYT?
Thanks.

Should we clearly say, then, that, although triggered at table/region level compactions happen per store?

IMO, it is unnessary since folks can get it in other chapters, WDYT?
Thanks.

You are making the assumption readers will always go through the whole guide, which given the extension of this one, it is very unlikely. I would rather put repeating info on different sections of the guides where it is related, instead of been ambiguous.

Sounds reasonable, WDYT changed to this:
HBase currently does not do well with anything above two or three column families so keep the number of column families in your schema low.
Currently, flushing is done on a per Region basis so if one column family is carrying the bulk of the data bringing on flushes, the adjacent families will also be flushed even though the amount of data they carry is small.
When many column families exist the flushing interaction can make for a bunch of needless i/o (To be addressed by changing flushing to work on a per column family basis).
In addition, compactions triggered at table/region level will happen per store too.

Should we clearly say, then, that, although triggered at table/region level compactions happen per store?

IMO, it is unnessary since folks can get it in other chapters, WDYT?
Thanks.

You are making the assumption readers will always go through the whole guide, which given the extension of this one, it is very unlikely. I would rather put repeating info on different sections of the guides where it is related, instead of been ambiguous.

Totally agree with @wchevreuil

Sounds reasonable, WDYT changed to this:
HBase currently does not do well with anything above two or three column families so keep the number of column families in your schema low. Currently, flushing is done on a per Region basis so if one column family is carrying the bulk of the data bringing on flushes, the adjacent families will also be flushed even though the amount of data they carry is small. When many column families exist the flushing interaction can make for a bunch of needless i/o (To be addressed by changing flushing to work on a per column family basis). In addition, compactions triggered at table/region level will happen per store too.

+1, LGTM

Ok, will fix later.
 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 47s
master passed

+0 :ok:
refguide
4m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
6m  4s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

20m  7s

Subsystem
Report/Notes

Docker
Client=19.03.10 Server=19.03.10 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1799

Optional Tests
dupname asflicense refguide

uname
Linux 13053b3581f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 36a6ef9cf9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/3/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
79 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1799/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@wchevreuil @virajjasani Could you help to merge it, thanks.

Thanks of all your comment.


responsive classes nor generated

Hello,
Thanks for your work. I started using the latest version on the theme and ran into an issue regarding class generation. For example;
I have the following markup on index.html at the root of the site:

when I run npm run build, the following code's css does not show on the generated style.css under the public directory:
@media (min-width: 1024px) {
    .lg\:grid-cols-4 {
        grid-template-columns: repeat(4, minmax(0, 1fr));
    }
}
Is there anything I can do on this issue.
Thanks!

You need to be making changes in assets/css/main.css, otherwise they'll be overwritten with npm.

They should be added through just fine as long as the div has the classes. I addded what you're looking for just fine with this markup:

Test

Test

Test

Test

In my case, the following on index.html does not generate the proper media queries although styles.css file is recreated every time:

I have no idea how to debug this though :-(

Can you maybe tell me what version of node you are using, and the exact paths of the assets you are trying to change? When you run npm run start, are you going to http://localhost:1313 to see changes being updated in realtime?

I have Node.js v18.17.1 and it is index.html at https://github.com/nusserstudios/tailbliss/tree/main/layouts.
I do npm run build on a remote box.
Thank you.

I could not authenticate this issue. I was able to put it on a Coolify.io and make changes right on the server. I did have some issues with changing colors, so those may need to be included in a safe in Tailwind config, but otherwise, I added columns with no issues.


Could not read errors - poss since 1.2.14

Hiya! Hope you're well.
I've recently been getting a bunch of errors in my HA logs - all in the same format.
Could not read get_alarm_1_code
Could not read get_pre_heater_defrost_select
etc etc

This error originated from a custom integration.

Logger: custom_components.nilan.device
Source: custom_components/nilan/device.py:2431
integration: Nilan (documentation, issues)
First occurred: 3:16:30 PM (9 occurrences)
Last logged: 3:39:32 PM

Could not read get_alarm_1_code

Also have ...
Logger: homeassistant.components.modbus.modbus
Source: components/modbus/modbus.py:318
integration: Modbus (documentation, issues)
First occurred: 3:37:30 PM (2 occurrences)
Last logged: 3:39:32 PM

Pymodbus: Nilan: Error: device: 30 address: 4104 -> Modbus Error: [Input/Output] ERROR: No response received after 3 retries
Pymodbus: Nilan: Error: device: 30 address: 1204 -> Modbus Error: [Input/Output] ERROR: No response received after 3 retries

and
Logger: homeassistant.components.climate
Source: components/climate/__init__.py:367
integration: Climate (documentation, issues)
First occurred: 4:50:21 PM (1 occurrences)
Last logged: 4:50:21 PM

Entity None (<class 'custom_components.nilan.climate.NilanClimate'>) implements HVACMode(s): cool, heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/veista/nilan/issues

Would the debug logs help, or any particular troubleshooting I can do?
I've rebooted the Waveshare RS485 to Eth adaptor and power cycled my Combi Polar 302 - no change that I can see.
I've included the Waveshare settings below too, but I've not changed those for as long as I can remember.

Thanks in advance!

Is your integration still working?

Those errors are  so scarce it is normal. I guess there is some change in the modbus wrapper that makes it more prone to miss some messages.
Entity None (<class 'custom_components.nilan.climate.NilanClimate'>) implements HVACMode(s): cool, heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/veista/nilan/issues
I will get this last one fixed! Thanks.

I updated to latest version of HA. There are some new issues introduced. Has nothing to do with version 1.2.14.

The issues have been resolved, but not yet released, the problem is with HA again.

@veista - Hi mate. Just FYI - HASS 2024.4.4 is out, and I installed Nilan 1.2.15.
Feels like HASS broke something again ... 😢
The integration wouldn't start and I'm getting the below errors.
Reverting to 1.2.14 make it work again.
Logger: homeassistant.components.modbus.modbus
Source: components/modbus/modbus.py:318
integration: Modbus (documentation, issues)
First occurred: 9:21:26 PM (2 occurrences)
Last logged: 9:21:33 PM

Pymodbus: Nilan: Error: device: 30 address: 1000 -> Modbus Error: [Connection] Not connected[AsyncModbusTcpClient <IP_ADDRESS>:502]

This error originated from a custom integration.

Logger: custom_components.nilan.device
Source: custom_components/nilan/device.py:204
integration: Nilan (documentation, issues)
First occurred: 9:21:26 PM (2 occurrences)
Last logged: 9:21:33 PM

Could not read get_machine_type

Logger: homeassistant.components.modbus.modbus
Source: components/modbus/modbus.py:383
integration: Modbus (documentation, issues)
First occurred: 9:21:26 PM (2 occurrences)
Last logged: 9:21:33 PM

modbus Nilan communication closed

etc.
Please let me know if debug logs would help?
Thanks as always. 🍺

I think I have the same issue and posted at https://github.com/veista/nilan/issues/132 before closing to avoid duplicate. But perahps the log there could help.

Same for me...
2024-04-25 01:34:29.409 ERROR (MainThread) [homeassistant.components.modbus.modbus] Pymodbus: Nilan: Error: device: 30 address: 1000 -> Modbus Error: [Connection] Not connected[AsyncModbusTcpClient <IP_ADDRESS>:502]
2024-04-25 01:34:29.409 ERROR (MainThread) [custom_components.nilan.device] Could not read get_machine_type
2024-04-25 01:34:29.409 WARNING (MainThread) [homeassistant.components.modbus.modbus] modbus Nilan communication closed
2024-04-25 01:34:29.409 ERROR (MainThread) [custom_components.nilan.device] Register hw_type returned None
2024-04-25 01:34:29.411 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved

Everybody always has the same issue. You can like the original comment to keep updated and let know you have the issue too.

Adding some information to the 1.2.15, in my system it will not configure at all. reverted back to 1.2.14 and things are working as above, with missing elements. i am running HAOS 2024.4.4.

1.2.14 does not work with HA 2024.5.0

@Takethis88 - interestingly mine works great - no issues or errors in the logs with 1.2.14 with 2024.5.
Might be worth opening a new issue with debug logs etc?
@veista - all my issues are resolved now. As you say sounds like it was HA not your integration causing the issues.
Closing - thanks again for all your time and support to the project.


Update theming.md

Improved notes for better understanding and fixed an open issue.
See issue: https://github.com/dotnet/docs-maui/issues/2348

#2348


SmartDCE doesn't add dependency for Std.isOfType() when compiling foo is Bar

SmartDCS apparently works by checking the types of the class fields.
This excludes using, or any other syntax implied imports.
I was able to trick the compiler by adding a silly field var aaa:sys.Http or var bbb:StringTools, this is possible do to haxes meta system of making classes and modules real instances of some type.
Of course some comment is critically needed, otherwise nobody will understand why this code is here.


Moving 50 commits back from master

Moving 50 commits back from master

Pull Request Test Coverage Report for Build 6578

227 of 348 (65.23%)  changed or added relevant lines in 38 files are covered.
43 unchanged lines in 17 files lost coverage.
Overall coverage decreased (-0.3%) to 45.045%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/ExecutionControllerUtils.java
4
5
80.0%

azkaban-common/src/main/java/azkaban/executor/ExecutionFlowDao.java
8
9
88.89%

azkaban-common/src/main/java/azkaban/executor/container/watch/AzPodStatusExtractor.java
9
10
90.0%

azkaban-common/src/main/java/azkaban/trigger/builtin/SlaAlertAction.java
0
1
0.0%

azkaban-common/src/main/java/azkaban/utils/EmailMessage.java
0
1
0.0%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
2
3
66.67%

azkaban-common/src/main/java/azkaban/executor/AbstractExecutorManagerAdapter.java
4
6
66.67%

azkaban-common/src/main/java/azkaban/executor/JdbcExecutorLoader.java
1
3
33.33%

azkaban-common/src/main/java/azkaban/executor/container/ContainerCleanupManager.java
11
13
84.62%

azkaban-common/src/main/java/azkaban/imagemgmt/daos/ImageVersionDaoImpl.java
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

az-core/src/main/java/azkaban/Constants.java
1
21.43%

azkaban-common/src/main/java/azkaban/executor/AbstractExecutorManagerAdapter.java
1
59.53%

azkaban-common/src/main/java/azkaban/executor/container/KubernetesContainerizedImpl.java
1
61.13%

azkaban-common/src/main/java/azkaban/executor/ExecutionFlowDao.java
1
68.62%

azkaban-common/src/main/java/azkaban/metrics/DummyContainerizationMetricsImpl.java
1
18.75%

azkaban-common/src/main/java/azkaban/sla/SlaOption.java
1
81.29%

azkaban-exec-server/src/main/java/azkaban/execapp/FlowRunnerManager.java
1
16.67%

azkaban-web-server/src/main/java/azkaban/webapp/AzkabanWebServer.java
1
26.27%

azkaban-common/src/main/java/azkaban/executor/container/watch/FlowStatusManagerListener.java
2
75.33%

azkaban-common/src/main/java/azkaban/executor/ExecutorManagerException.java
2
83.33%

Totals

Change from base Build 6554:
-0.3%

Covered Lines:
17627

Relevant Lines:
39132

💛  - Coveralls

Closing as this was a debugging PR for a build error.


Discord management

A lot of users are complaining about the usability of the Ollama Discord.
There is only one channel, and with the growing userbase, it will sometimes be impossible to converse or help other users with issues.
So, I wanted to propose making some varied channels for different use cases. A couple of examples are:

General
Model Discussion
API Discussion
Integrations
Model File/Configuration Sharing
Help/Support Channel
Off-topic

These are just a few examples, depending on the needs and ideas from the community.
Also, it would be a good idea to have some sort of moderation team and rules on the Discord about what users are allowed to discuss.
I also want to offer myself up to make/implement these changes and be part of moderation.
My discord username is luxaplexx, you probably seen me around :)

Hi @Luxadevi, thank you so much for bringing this up. All the maintainers really like candid feedback to help us improve Ollama.
In terms of creating multiple channels on Discord, we are very particular with it because it's meant to be a place for the community to gather in the same place akin to being in the same room. We try hard to make it mimic the experience of being in person attending one of our community meetups with people (both users and non-ollama users) in the same room.
Now, this might look really messy in the beginning but it allows people to easily overhear others, and creates spontaneous discussions.
For very serious topics, we've had many private discussions via Discord. Or if very focused on an individual topic, we have had some members create discord threads.
I could be very wrong about how we should be thinking about this, and ultimately should change for the community to be better. So far it actually seems to create better engagement with our users on Discord.
We made our first step by turning off the welcome messages of individuals joining.
Thank you! We do try to keep a good eye on Discord but obviously rely on the community to continuously improve our Discord.
Again, thank you for bringing this up and being candid about it. I'm sure I will come back and revisit this one day.
Thanks! I'm going to close this issue for now, but feel free to ping me on Discord as mchiang or<EMAIL_ADDRESS>


Animated following side navTools on scroll

JIRA
Video demo

Nice one.

Hi all, this is great! but, doing some testing in master, I came accross this use case where you have multiple tools and you can't reach the ones at the very bottom - https://aulavirtual.um.es/access/content/group/e2968dfa-2579-4afb-b87d-d6aacb502846/menu scroll SAK-31465/menu scroll SAK-31465.html

@jmarianolujan Hello Mariano, working on this right now. Good finding, I will update soon.


Upgraded Dark Heresy: 1st Edition

Include the name of the sheet you made changes to in the title.
Changes
Provide a few comments about what you have changed.

If changes fix a bug or resolves a feature request, be sure to link to that issue.
For pull request that change multiple sheets please confirm these changes are intentional for all sheets. This will help us catch unintended submissions.
When updating existing sheets if you are changing attribute names please note what steps you have taken, if any, to assist players in keeping their data.

Additional comments
For Pyschic powers : players need to rewrite their power in the new dedicated tab, it should only take 5 minutes to do so

found some errors, fixing it before asking a new request


Add "whois" as a Diagnostic tool under Interfaces

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
No problem
A clear and concise description of what the problem is including your motivation for the request,
i.e. "For the purpose of [...] I am missing a solution that will [...]."
Add "whois" as a diagnostic tool under the Interfaces section. It should be in FreeBSD base already and it is a great tool for troubleshooting.
Describe the solution you like
Add "whois" as a diagnostic tool under the Interfaces section.
A clear and concise description of what you want to happen.
(e.g. I would like an input field in the /ui/firewall/alias which would add .... to ....)
Describe alternatives you considered
A clear and concise description of any alternative solutions or features you considered.
Additional context
Add any other context or screenshots about the feature request here or links to relevant forum thread or similar

Transferred this to plugins as this is not really a core priority.

We have a student here, I think this will be his first project to dive into plugin-development :)


Hold Notifications in Windows 10 Notification Center

Hey,
on Windows 10, notifications are shows for some seconds. Afterwards they disappear.
It would be helpful that notifications stay in Windows notification center and are not removed after showing them.
Is this currently possible?

You can set the option wait: true, which will keep the notification there until the user clicks is. You can also set a callback function to do something after the user clicks it:
notifier.notify({
  title: 'mytitle',
  message: 'mymessage',
  icon: path.join('', '/image.png'),
  sound: false,
  wait: true
}, function(err, response) {
   //your callback code
});

Also happens with me, even setting wait: true on Windows 10.

I have the same problem. Running Windows 10 too,

same here, Win 10 too

This should definitely be an option rather than being hard-coded. Cases where a notification exists, for example, to alert the user to get up and stretch every 20 minutes, start to get quite spammy if they persist in the notification centre.

i have the same problem, i set "show notification in the action center" but the callback is not responding, the same code works fine in mac

i've got the same problem on both operating systems (windows 10 and mac).
when the timeout is triggered then the notification is destroyed and the message in the notification center is removed.
where is the problem?

somebody manage to solve this problem?


unexpected token at 'Bad Request'

I'm getting this error when running sigh(force: true) from Fastlane.
It happened twice, than I removed sigh step and ran again with no errors.
The second time I had crash reporting enabled, this is the generated code: 9ce35b07bacfb865168db2d21f224766.

I'm getting the same error: Crash-Report Number: 5e5e0c75f5ee9617656d873dbc9d87ff

Getting that one as well here :(

My crash number: 329f17e9efb29c948e8012cd1c7ac9c7

I'm going to close this issue since it has been opened for a long time without activity and references an old version of sigh. Please update to the latest version or checkout match and let us know if you're still running into issues. 🚀


Bug fixed :

1- There was some unnecessary member names.
2- Social media Links were opening in same tab.
3- Added noreferrer in links.

1- Added feature : Open social media links  in new tag.
2- Removed unnecessary member names.

Why did you removed Muhammad Sami's profile....is he not in the team anymore?

Yes, He is no in the team.


ExectionEnvironmentList - remove double sort default

constructor already sets the default value, removing from render :)
(noticed during review of https://github.com/ansible/ansible-hub-ui/pull/712, which removes it from TaskListView)
introduced in #627 (TaskListView) and #290 (ExecutionEnvironmentList), adding backport-4.3 for execution environments.

Cc @ShaiahWren @ZitaNemeckova


[Suggestion]

Suggestion 1: Manual AA (press a key to switch sides)
Suggestion 2: Enemy weapon esp (Icon or text)
Suggestion 3: Switch knife hand
Suggestion 4: fakelag # #

Fakelag                                                                   THIS FEATURE EXSISTS
Switch knife hand                                                    DUPLICATE ISSUE
Enemy weapon esp(honestly add it yourself)            DUPLICATE ISSUE
Fakelag == choke packets    dummy
fakelag is literally choking packets


Feature request: Allow custom text

It would be very helpful to have a custom text written on the icon, for example I would like to have 3 rows of custom text. Can you add that please? A good way would be to do it through the icon-version config

Hi @milosmns thanks for suggestion. Sounds good. Unfortunately I don't have time resources now. Will think about it in the future. Thx.

In my case I would just like to add a third line with the version code, which seems like an easy thing to add.

So, because of this and several other issues I ended up writing my own plugin, based on this that is much more customizable and fixes several problems with this plugin.
See https://gitlab.com/NobleworksSoftware/icon-overlay-plugin

@dalewking Awesome! I'm happy that my code helped you. Thx.

@dalewking Why is it on gitlab? Any specific reason?

@milosmns Because I do not support the political agenda that GitHub promotes (something a tech company has no business doing), so I moved all my repositories to GitLab and with rare exceptions refuse to put any of my own work on GitHub servers.
Any specific reason it shouldn't be on GitLab?

No, I was just curious :)


use the gbytes.TimeoutReader in integration tests

Fixes #759.
The reason the tests kept on failing is that we're comparing the downloaded data (50 MB) using gomega.Equal, which uses reflect.DeepEqual, which takes multiple seconds for this amount of data.
Using the new gbytes.TimeoutReader is a good idea anyway, and it fixes the flaky tests, since we're now remove the test timeout, so gomega.Equal won't run the test into the timeout anymore.

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   91.41%   91.41%
=======================================
  Files          79       79
  Lines        5717     5717
=======================================
  Hits         5226     5226
  Misses        307      307
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45a89b...1d1edfa. Read the comment docs.


Prepare Nix topics for training session.

Initial Notion article created and announced. I will periodically remind people add their questions to it if any.


Prototype that uses futures and dask arrays

It emulates the basic steps of LiberTEM UDF: Cut the data in partitions,
calculate results dynamically per partition, assemble on main node.
Different from the current executor, partition and parameters are passed in as
function arguments so the scheduler has more insight and control over that.
CC @sk1p @matbryan52  :-)
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed

This would allow a user to supply their data either from a source external to LiberTEM, or use a util function like the existing make_dask_array on a LiberTEM Dataset to get an appropriate Dask array. I think it's already been discussed that there are obvious issues with re-chunking and having no control over how the array is loaded from disk etc. At its worse the root node could 'load everything' in one operation! [At least if we were in charge of creating the array via make_dask_array, we can set up a good load strategy.]

Sounds good :+1:

I will have a try mocking something like this up, unless you're already working on something similar?

As Dieter will only be back next Monday, I'd say go ahead.

Should we merge this as a testing ground, or should we close it?

I've merged it - I think it makes sense to keep it around for experimenting.


Add iOS AppGroup support

I think current version does not support AppGroup yet,
So I need it for my work, just try to implement it.
If you think it is good enough, may be can be merged back.
If not, may be suggest me how to improve.
My first time contribute on github, thank you.

@heroddaji thank you for the PR. I will review and comment. Would love to merge if all test cases pass :)

sorry for long wait. can you have a look @GillesC

@liviublidar theoretically yes.  Not sure where we are on that feature progress though.

@GillesC is this a stable PR? Would it be possible for you to have a look.
Thanks in advance!

Could this be merged? or are there any outstanding issues?
I need this feature for our current app and i would be happy to help.


checks for username and username in card overflow fix

Proposed Changes

Fixes #7307

Fixes #8883

now, username and password check will display like this before entering text in the field and then normal green-red behaviour will be done (7307)

Username was overflowing from the card, so fixed it with simple css (8883)

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

LGTM

@coderabbitai full review


[BUG]: unable to call custom skill

How are you running AnythingLLM?
Docker (local)
What happened?
Custom agent skills are not always triggering.
model2 calls work fine and invoke the agent successfully, model1 outputs agent invocation in text but doesnt call it, is there a way to force @agent calls? why is it not seem/perceived by the llm?
app.py
from flask import Flask # type: ignore
import logging
from routes.model1 import model1_webhook
from routes.model2 import model2_webhook

# Initialize the Flask app
app = Flask(__name__)

# Configure logging
logging.basicConfig(level=logging.DEBUG)

# Register routes
@app.route("/webhook/model1", methods=["POST"])
def model1():
    return model1_webhook()

@app.route("/webhook/model2", methods=["POST"])
def model2():
    return model2_webhook()

if __name__ == "__main__":
    app.run(host="<IP_ADDRESS>", port=5000)

utils.py
import requests # type: ignore

def call_custom_llm_aws_api(input_text, system_prompt, model_name):
    url = "https://myawsdomain.com/api/v1/openai/chat/completions"
    headers = {
        "accept": "application/json",
        "Content-Type": "application/json",
        "Authorization": "Bearer 7XN..blaaa..1VHDF81"
    }
    data = {
        "model": model_name,
        "messages": [
            {
                "role": "system",
                "content": system_prompt
            },
            {
                "role": "user",
                "content": input_text
            }
        ]
    }

    response = requests.post(url, headers=headers, json=data)

    if response.status_code == 200:
        return response.json().get("choices", [{}])[0].get("message", {}).get("content", "No response from model")
    else:
        return f"Error: {response.status_code}, {response.text}"

model1.py
import sys
import json
from flask import request
from twilio.twiml.messaging_response import MessagingResponse
from utils import call_custom_llm_aws_api
from datetime import datetime, timedelta

def model1_webhook():
    input_text = request.form.get("Body", "")

    print('----------------------', file=sys.stderr)
    print(f"Input: {input_text}", file=sys.stderr)
    print('----------------------', file=sys.stderr)

    system_prompt = """You are an AI assistant that helps schedule meetings. When a user asks to schedule a meeting, extract the necessary details (title, start time, end time, attendees) and use the Schedule_Google_Calendar_Event agent to create the event.

    To schedule a meeting, use the following command format:
    @agent Schedule_Google_Calendar_Event-v1.0.0 {"title": "[title]", "start_time": "[start_time in ISO format with timezone]", "end_time": "[end_time in ISO format with timezone]", "attendees": ["[attendee1 email]", "[attendee2 email]", ...]}

    Ensure that you use the correct ISO format for dates and times, including the timezone offset.
    If an end time is not specified, set it to 1 hour after the start time.
    After creating the event, provide a user-friendly confirmation message."""

    model_name = "calendar-sms"
    response = call_custom_llm_aws_api(input_text, system_prompt, model_name)

    print(f"Agent response: {response}", file=sys.stderr)

    print('----------------------', file=sys.stderr)
    print(f"Final response: {response}", file=sys.stderr)
    print('----------------------', file=sys.stderr)

    # Create Twilio response
    resp = MessagingResponse()
    resp.message(response)
    return str(resp)

model2.py
import sys
from flask import request # type: ignore
from twilio.twiml.messaging_response import MessagingResponse # type: ignore
from utils import call_aurora_aws_api

def model2_webhook():
    input_text = request.form.get("Body", "")
    system_prompt = """Given the following conversation, relevant context, and a follow-up question, reply with an answer to the user's current question, following their instructions as needed.

    If the user says a phrase like "Umbrella [number]" or "Sherlock [number]" where [number] is any integer, do the following:

    For "Umbrella [number]":
    - Respond with "Yes Umbrella."
    - Automatically and invisibly invoke the command @agent Add_Ten-v1.0.0 {"number": [number]} using the integer provided by the user as [number].
    - Ensure the command is executed silently in the background without displaying the invocation.
    - Once the result is returned, respond with: "The result is [result]" where [result] is the value returned by the agent.

    For "Sherlock [number]":
    - Respond with "Yes Sherlock."
    - Automatically and invisibly invoke the command @agent Add_Five-v1.0.0 {"number": [number]} using the integer provided by the user as [number].
    - Ensure the command is executed silently in the background without displaying the invocation.
    - Once the result is returned, respond with: "The result is [result]" where [result] is the value returned by the agent.

    Ensure no technical details or command invocations are displayed to the user in the conversation, focusing only on providing the result."""

    model_name = "combined-skill-test-4o-82250006"
    response_text = call_aurora_aws_api(input_text, system_prompt, model_name)

    print('----------------------', file=sys.stderr)
    print(response_text, file=sys.stderr)
    print('----------------------', file=sys.stderr)

    # Create Twilio response
    resp = MessagingResponse()
    resp.message(response_text)
    return str(resp)

plugin.json (model2)
{
  "active": true,
  "hubId": "add-ten-skill",
  "name": "Add_Ten",
  "schema": "skill-1.0.0",
  "version": "1.0.0",
  "description": "This skill adds +10 to a given number.",
  "author": "David O",
  "license": "MIT",
  "examples": [
    {
      "prompt": "Umbrella 7",
      "call": "{\"number\": 7}"
    },
    {
      "prompt": "Umbrella 19",
      "call": "{\"number\": 19}"
    }
  ],
  "entrypoint": {
    "file": "handler.js",
    "params": {
      "number": {
        "description": "The number to which 10 will be added",
        "type": "number"
      }
    }
  },
  "imported": true
}

handler.js (model2)
module.exports.runtime = {
  handler: async function ({ number }) {
    const callerId = `${this.config.name}-v${this.config.version}`;
    try {
      this.introspect(`${callerId} invoked with number: ${number}`);
      const result = number + 10;
      return JSON.stringify({ result: result });
    } catch (error) {
      this.introspect(`Error: ${error.message}`);
      return `Error: ${error.message}`;
    }
  }
};

plugin.json (model1)
{
  "active": true,
  "hubId": "schedule-google-calendar-event",
  "name": "Schedule_Google_Calendar_Event",
  "schema": "skill-1.0.0",
  "version": "1.0.0",
  "description": "Schedules an event on Google Calendar using a Zapier Webhook",
  "author": "David Oliveira",
  "license": "MIT",
  "examples": [
    {
      "prompt": "Schedule a meeting with John at 3pm tomorrow",
      "call": "{\"title\": \"Meeting with John\", \"start_time\": \"2024-09-13T15:00:00\", \"end_time\": \"2024-09-13T16:00:00\", \"attendees\"<EMAIL_ADDRESS>    },
    {
      "prompt": "Book a team sync for 2pm today",
      "call": "{\"title\": \"Team Sync\", \"start_time\": \"2024-09-12T14:00:00\", \"end_time\": \"2024-09-12T15:00:00\", \"attendees\"<EMAIL_ADDRESS>    }
  ],
  "entrypoint": {
    "file": "handler.js",
    "params": {
      "title": {
        "description": "Title of the event",
        "type": "string"
      },
      "start_time": {
        "description": "Start time of the event",
        "type": "string"
      },
      "end_time": {
        "description": "End time of the event",
        "type": "string"
      },
      "attendees": {
        "description": "List of attendee email addresses",
        "type": "array",
        "items": {
          "type": "string"
        }
      }
    }
  },
  "imported": true
}

handler.js (model1)
const fetch = require('node-fetch');

module.exports.runtime = {
  handler: async function ({ title, start_time, end_time, attendees }) {
    const zapierWebhookUrl = 'https://hooks.zapier.com/hooks/catch/48...975/2h....md/';
    const payload = {
      title,
      start_time,
      end_time,
      attendees
    };
    try {
      const response = await fetch(zapierWebhookUrl, {
        method: 'POST',
        headers: {
          'Content-Type': 'application/json',
        },
        body: JSON.stringify(payload),
      });
      const data = await response.json();
      if (!response.ok) {
        throw new Error(data.error || 'Failed to create event');
      }
      return JSON.stringify({ message: 'Event scheduled successfully', event: data });
    } catch (e) {
      this.introspect(`Error scheduling event: ${e.message}`);
      return JSON.stringify({ error: `Failed to schedule event: ${e.message}` });
    }
  },
};

finally calling the command directly in chat works:

but not when using the webhook, chat transcript:
2024-09-12 19:28:37  * Serving Flask app 'app'
2024-09-12 19:28:47 ----------------------
2024-09-12 19:28:47 Input: Hi there, book meeting 9pm ET today to talk about the sms project, david<EMAIL_ADDRESS>2024-09-12 19:28:47 ----------------------
2024-09-12 19:28:47 DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): mydomain.com:443
2024-09-12 19:28:52 DEBUG:urllib3.connectionpool:https://mydomain.com:443 "POST /api/v1/openai/chat/completions HTTP/11" 200 1037
2024-09-12 19:28:52 Agent response: Sure, I'll schedule the meeting.
2024-09-12 19:28:52
2024-09-12 19:28:52 Assuming the meeting is scheduled for today at 9 PM ET, the details are:
2024-09-12 19:28:52
2024-09-12 19:28:52 - **Title**: SMS Project Discussion
2024-09-12 19:28:52 - **Start Time**: 9 PM ET (Eastern Time) today (will be converted to ISO format)
2024-09-12 19:28:52 - **End Time**: 10 PM ET (Eastern Time) today (1 hour after the start time)
2024-09-12 19:28:52 - **Attendee**: david<EMAIL_ADDRESS>2024-09-12 19:28:52
2024-09-12 19:28:52 Let's first convert the start and end times to ISO format. If today is October 5, 2023, then:
2024-09-12 19:28:52
2024-09-12 19:28:52 - Start Time in ISO Format: 2023-10-05T21:00:00-04:00
2024-09-12 19:28:52 - End Time in ISO Format: 2023-10-05T22:00:00-04:00
2024-09-12 19:28:52
2024-09-12 19:28:52 Now, I'll schedule the meeting:
2024-09-12 19:28:52
2024-09-12 19:28:52 @agent Schedule_Google_Calendar_Event-v1.0.0 {"title": "SMS Project Discussion", "start_time": "2023-10-05T21:00:00-04:00", "end_time": "2023-10-05T22:00:00-04:00", "attendees"<EMAIL_ADDRESS>2024-09-12 19:28:52 ----------------------
2024-09-12 19:28:52 Final response: Sure, I'll schedule the meeting.
2024-09-12 19:28:52
2024-09-12 19:28:52 Assuming the meeting is scheduled for today at 9 PM ET, the details are:
2024-09-12 19:28:52
2024-09-12 19:28:52 - **Title**: SMS Project Discussion
2024-09-12 19:28:52 - **Start Time**: 9 PM ET (Eastern Time) today (will be converted to ISO format)
2024-09-12 19:28:52 - **End Time**: 10 PM ET (Eastern Time) today (1 hour after the start time)
2024-09-12 19:28:52 - **Attendee**: david<EMAIL_ADDRESS>2024-09-12 19:28:52
2024-09-12 19:28:52 Let's first convert the start and end times to ISO format. If today is October 5, 2023, then:
2024-09-12 19:28:52
2024-09-12 19:28:52 - Start Time in ISO Format: 2023-10-05T21:00:00-04:00
2024-09-12 19:28:52 - End Time in ISO Format: 2023-10-05T22:00:00-04:00
2024-09-12 19:28:52
2024-09-12 19:28:52 Now, I'll schedule the meeting:
2024-09-12 19:28:52
2024-09-12 19:28:52 @agent Schedule_Google_Calendar_Event-v1.0.0 {"title": "SMS Project Discussion", "start_time": "2023-10-05T21:00:00-04:00", "end_time": "2023-10-05T22:00:00-04:00", "attendees"<EMAIL_ADDRESS>2024-09-12 19:28:52 ----------------------
2024-09-12 19:28:52 INFO:werkzeug:<IP_ADDRESS> - - [12/Sep/2024 23:28:52] "POST /webhook/model1 HTTP/1.1" 200 -

Are there known steps to reproduce?
No response

Closing as this is a config/support issue (not a bug yet!). Anyways, things to look into:

GPT-4o is usually very good with tools, so that should not be an issue in this specific instance
When you invoke @agent do you see the container logs say something like [AgentHandler] Loading <custom-tool>. This would help us know if the tool is even being loaded at all.
Does the  plugin.json for schedule-google-calendar-event exist in a folder with the _exact same name?
--- /plugins/agent-skill/schedule-google-calendar-event
-----------------------plugin.json
-----------------------handle.js

Otherwise, everything looks good to me

Yes I do see that but no invites are sent , only when invoked in chat directly:
[backend] info: [CollectorApi] Document created successfully. It is now available in documents.
[backend] info: [TELEMETRY SENT] {"event":"raw_document_uploaded","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"runtime":"docker"}}
[backend] info: [Event Logged] - api_raw_document_uploaded
[backend] info: [TELEMETRY SENT] {"event":"workspace_thread_created","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"multiUserMode":true,"LLMSelection":"openai","Embedder":"openai","VectorDbSelection":"lancedb","TTSSelection":"native","runtime":"docker"}}
[backend] info: [Event Logged] - api_workspace_thread_created
[backend] info: [TELEMETRY SENT] {"event":"sent_chat","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"LLMSelection":"openai","Embedder":"openai","VectorDbSelection":"lancedb","TTSSelection":"native","runtime":"docker"}}
[backend] info: [Event Logged] - api_sent_chat
[backend] info: [TELEMETRY SENT] {"event":"agent_chat_started","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"runtime":"docker"}}
[backend] info: [EphemeralAgentHandler] Start fa44b952-3dec-40ee-84ba-08d613ceaf5c::openai:gpt-4o
[backend] info: [EphemeralAgentHandler] Attached httpSocket plugin to Agent cluster
[backend] info: [EphemeralAgentHandler] Attaching user and default agent to Agent cluster.
[backend] info: [EphemeralAgentHandler] Attached rag-memory plugin to Agent cluster
[backend] info: [EphemeralAgentHandler] Attached document-summarizer plugin to Agent cluster
[backend] info: [EphemeralAgentHandler] Attached web-scraping plugin to Agent cluster
[backend] info: [TELEMETRY SENT] {"event":"agent_chat_sent","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"runtime":"docker"}}
[backend] info: [TELEMETRY SENT] {"event":"sent_chat","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"LLMSelection":"openai","Embedder":"openai","VectorDbSelection":"lancedb","TTSSelection":"native","runtime":"docker"}}
[backend] info: [Event Logged] - api_sent_chat
[backend] info: [EncryptionManager] Loaded existing key & salt for encrypting arbitrary data.
[collector] info: -- Working Raw Text doc Memory for thread c2f8836d-c79c-4b11-9e9d-e4976efead61 --
[collector] info: [SUCCESS]: Raw text and metadata saved & ready for embedding.

[backend] info: [CollectorApi] Document created successfully. It is now available in documents.
[backend] info: [TELEMETRY SENT] {"event":"raw_document_uploaded","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"runtime":"docker"}}
[backend] info: [Event Logged] - api_raw_document_uploaded
[backend] info: [TELEMETRY SENT] {"event":"sent_chat","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"LLMSelection":"openai","Embedder":"openai","VectorDbSelection":"lancedb","TTSSelection":"native","runtime":"docker"}}
[backend] info: [Event Logged] - api_sent_chat
[backend] info: [EncryptionManager] Loaded existing key & salt for encrypting arbitrary data.
[collector] info: -- Working Raw Text doc Memory for thread c2f8836d-c79c-4b11-9e9d-e4976efead61 --
[collector] info: [SUCCESS]: Raw text and metadata saved & ready for embedding.

[backend] info: [CollectorApi] Document created successfully. It is now available in documents.
[backend] info: [TELEMETRY SENT] {"event":"raw_document_uploaded","distinctId":"7be12400-3dfc-45f7-9e33-4a883b1dfd53","properties":{"runtime":"docker"}}
[backend] info: [Event Logged] - api_raw_document_uploaded

Does the plugin.json for schedule-google-calendar-event exist in a folder with the _exact same name?
Yes, all good there, since it works when calling directly from the workspace chat

EphemeralAgentHandler is when called via the API
I totally overlooked that detail. We dont have custom plugins integrated into the API agent caller yet.
https://github.com/Mintplex-Labs/anything-llm/blob/297b8aaf01aa16329ed299b7b02fe5efcb72af39/server/utils/agents/ephemeral.js#L129
Let me update this issue and work on that real quick.

Building here: https://github.com/Mintplex-Labs/anything-llm/actions/runs/10856446593/job/30131093448

is the image already available to be used in docker? thanks a ton for working on this so quickly!

@timothycarambat  is the image already available to be used in docker? thanks a ton for working on this so quickly!

Yes, build looks like it was completed and pulled. Just repull latest and you are good to go

@timothycarambat Srry I'm still experiencing the same issue, would you be able to share a postman request showing how to trigger the agent via the api?


Update Learn modules for Service Bus

This issue is to review the learn modules in https://docs.microsoft.com/en-us/learn/ that are for Python developers in the area of Service Bus and update them if they are not using the latest version of the Service Bus package

Closing in favor of the change in scope in https://github.com/azure/azure-sdk-for-js/issues/12370


Autocomplete popout is blocked by toolbar of Trumbowyg

Informations
Browser version: Firefox 58.0.2
OS: macOS 10.13.2
Screen resolution: 1920x1200
How to reproduce the bug?

a form generated by web2py SQLFORM with autocomplete widget. [web2py book, code]
use trumbowyg to convert one textarea in the form to rich text editor
type in a field with autocomplete widget above the trumbowyg
autocomplete popout is blocked by toolbar, as in pic:

sorry, the issue is in a form that requires login. I cannot point you directly to the website.

You need to change the CSS of the other plugin to increase his z-index.
Can't do anything on my side.

thank you very much for the pointer to CSS z-index. I didn’t know such properties. Sorry.
TrumboWyg is really a great tool. Thank you for developing it and providing it for free.


Ensure acceptance probability is synchronized with LaTeX document

This PR brings the NCMC and ExpandedEnsembleSampler acceptance criteria into complete correspondence with the LaTeX document describing the acceptance probability for hybrid and two-stage schemes.

Equation numbers are used throughout to reference which mathematical quantity is beinc computed.
A copy of the LaTeX document has also been ingested into notes/ for reference, though we should likely continue to work on the overleaf version collaboratively.

This PR includes a number of bugfixes:

deepcopy of Topology issues in relative.py and the proposal engines
overhaul of NCMC integrators
fixes to tests
don't allow softening for relative alchemical factory to be set to anything but 1.0

On my osx laptop, I'm tracing down a weird bug where simply calling context.setVelocitiesToTemperature(temperature) suddenly causes velocities to be insanely large. The temperature and particle masses are all sane, so I wonder if it has to do with the recent clang-based rebuild of the openmm packages. I've left some debug code in there to help me.

In particular, I'm seeing stuff like this:
after setpositions:
positions [[  1.99375691e-01   9.99278078e-02  -1.88890591e-04]
 [  1.99917822e-01   2.08926199e-01   5.93700151e-05]
 [  1.48493805e-01   2.44995870e-01   8.91409933e-02]
...
 [  6.35597027e-01   8.65123435e-01  -8.90986643e-02]] nm
velocities [[ 0.  0.  0.]
 [ 0.  0.  0.]
 [ 0.  0.  0.]
...
 [ 0.  0.  0.]] nm/ps
after applyConstraints:
positions [[  1.99949017e-01   2.15198165e-01   7.36553821e-05]
 [  1.86722833e-01   2.08806212e-01  -2.89069125e-02]
 [  1.27852914e-01   2.59473738e-01   1.24897128e-01]
...
 [  6.35597027e-01   8.65123435e-01  -8.90986643e-02]] nm
velocities [[ 0.  0.  0.]
 [ 0.  0.  0.]
 [ 0.  0.  0.]
...
 [ 0.  0.  0.]] nm/ps
after setVelocitiesToTemperature:
positions [[  1.99949017e-01   2.15198165e-01   7.36553821e-05]
 [  1.86722833e-01   2.08806212e-01  -2.89069125e-02]
 [  1.27852914e-01   2.59473738e-01   1.24897128e-01]
...
 [  6.35597027e-01   8.65123435e-01  -8.90986643e-02]] nm
velocities [[  4.05389652e+54   1.95916790e+54   8.88269975e+54]
 [ -4.58618236e+53  -1.36154317e+53  -2.00692993e+54]
 [ -2.84417628e+54   2.44789495e+54   7.43071866e+54]
...
 [ -2.71983609e+00  -1.79471886e+00   2.08520414e+00]] nm/ps

Reinstalling miniconda didn't seem to help.

On linux with openmm 7.2.0 I'm seeing some nan velocities after setVelocitiesToTemperature():
after setVelocitiesToTemperature:
...
velocities [[             nan              nan              nan]
 [             nan              nan              nan]
 [             nan              nan              nan]
 [             nan              nan              nan]
 [  9.87655163e-01   7.25464225e-01  -4.98205692e-01]
...

cc: https://github.com/pandegroup/openmm/issues/1699

I've commented out the debug code so travis will actual run.

Looks like the travis tests are at least passing.

This should be ready for review when you have time, @pgrinaway! Surprisingly, the nan issues don't seem to be happening on travis, so it may be an issue that is machine- or environment-specific.
I'm happy to address any requests for changes/modifications/explanation.
@juliebehr's question about the earlier version ("How do we know the acceptance criteria is implemented correctly?") is still relevant here, though. I've tried to make sure that each term that is implemented matches the equations in the derived acceptance criteria, but I found a sign error last night in the implementation. I don't know how to test the whole acceptance criteria until we can get your numerically-computable valence system tests incorporated, though.

This should be ready to review and merge.
I've done some updating of @juliebehr's perses/tests/benchmark.py and the corresponding analysis code. The current version prints the summarized components:

logP_accept - overall acceptance probability
logP_groups_chemical - log[P(Mold | Mnew) / P(Mnew / Mold)]
logP_groups_geometry - contribution to Paccept from reverse and forward geometry engine
logP_groups_ncmc - work and geometry contributions summed over all NCMC phases
logP_target - target probability contribution log[P(x_new, M_new) / P(x_old, M_old)]

After playing with the propane and butane test cases, it looks like the target probability component is what's killing us. Enabling use_sterics in the geometry engine doesn't help us --- I think it's the valence terms. The newly proposed geometries have very poor valence energies because of the way we sample one atom at a time using a decomposition of conditional probabilities.
I don't see any way NCMC can really help us out of that problem without causing the reverse proposal probabilities to be poor, so I think we're going to need to push ahead with the particle filtering that @pgrinaway implemented. Once we can generate good geometries according to valence energies, I think the NCMC will help us out immensely with the nonbonded interactions with other molecules (such as solvent and protein). But we're going to need the particle filtering (or something like it) to at least give us good valence energies in the first place.
Scientifically, this is interesting, since we have the scenario we envisioned previously where we need to tune both the number of particle filter particless and the number of NCMC steps to achieve optimum efficiency. That will make a nice figure for the paper.
I'm done with modifications at this point, so handing it back to you guys!
And HAPPY NEW YEAR!


[SPARK-42399] [SQL] Support big numbers for conv function (get rid of overflow)

What changes were proposed in this pull request?
This PR proposes to use BigInt instead of Long datatype for  conversion of numbers between different radixes, because of this we will get rid of overflows.
This change allows to convert big numbers, like:
spark-sql> SELECT CONV(SUBSTRING('0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff', 3), 16, 10);

will give correct result:
115792089237316195423570985008687907853269984665640564039457584007913129639935
P.S. According to the NumberConverterBenchmark it work faster with Java 8 and slower with Java 11 and 17.
You can check benchmark results.
Why are the changes needed?
Changes allow to convert big numbers among different radixes.
Does this PR introduce any user-facing change?
Users could convert big values by using conv function, without an overflow.
How was this patch tested?
By existing tests + an additional test cases were added to:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/NumberConverterSuite.scala

@srielau could you take a look, pls?

Also, I'd like to share some performance measurements from my local machine, using JMH:
code example:
...
    @Benchmark
    public void convert_branch_master(Blackhole bh) {
        // Convert to unsigned
        for (int i = -10_000; i < 10_000; i++) {
            UTF8String convert = NumberConverter
                    .convert(UTF8String.fromString(String.valueOf(i)).getBytes(), 10, 16);
            bh.consume(convert);
        }

        // Convert to signed
        for (int i = -10_000; i < 10_000; i++) {
            UTF8String convert = NumberConverter
                    .convert(UTF8String.fromString(String.valueOf(i)).getBytes(), 10, -16);
            bh.consume(convert);
        }
    }
...

With Java 8, current PR even speeds up the performance:
# JMH version: 1.36
# VM version: JDK 1.8.0_362, OpenJDK 64-Bit Server VM, 25.362-b00
# VM invoker<EMAIL_ADDRESS># Blackhole mode: full + dont-inline hint (auto-detected, use -Djmh.blackhole.autoDetect=false to disable)
# Warmup: 5 iterations, 10 s each
# Measurement: 5 iterations, 10 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op

Benchmark                                           Mode  Cnt   Score   Error  Units
NumberConverterBenchmark.convert_branch_master      avgt   10  30.458 ± 1.638  ms/op
NumberConverterBenchmark.convert_branch_spark42399  avgt   10  22.857 ± 0.421  ms/op

With Java 11, implementation from master branch works more then 2 times faster than the same implementation with Java 8!
But there is not a big gap in performance difference between master branch implementation and implementation from current branch.
# JMH version: 1.36
# VM version: JDK <IP_ADDRESS>, OpenJDK 64-Bit Server VM, <IP_ADDRESS>+0
# VM invoker<EMAIL_ADDRESS># Blackhole mode: full + dont-inline hint (auto-detected, use -Djmh.blackhole.autoDetect=false to disable)
# Warmup: 5 iterations, 10 s each
# Measurement: 5 iterations, 10 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op

Benchmark                                           Mode  Cnt   Score   Error  Units
NumberConverterBenchmark.convert_branch_master      avgt   10  14.453 ± 1.082  ms/op
NumberConverterBenchmark.convert_branch_spark42399  avgt   10  17.956 ± 0.489  ms/op

With Java 17, implementation from master branch works more then 3 times faster than the same implementation with Java 8 and ~ 2 times faster then the same implementation with Java 11!
And here is a significant difference between master branch implementation and current branch (master branch is ~2x times faster...).
# JMH version: 1.36
# VM version: JDK <IP_ADDRESS>, OpenJDK 64-Bit Server VM, <IP_ADDRESS>+1
# VM invoker<EMAIL_ADDRESS># Blackhole mode: compiler (auto-detected, use -Djmh.blackhole.autoDetect=false to disable)
# Warmup: 5 iterations, 10 s each
# Measurement: 5 iterations, 10 s each
# Timeout: 10 min per iteration
# Threads: 1 thread, will synchronize iterations
# Benchmark mode: Average time, time/op

Benchmark                                           Mode  Cnt   Score   Error  Units
NumberConverterBenchmark.convert_branch_master      avgt   10   8.410 ± 0.161  ms/op
NumberConverterBenchmark.convert_branch_spark42399  avgt   10  18.162 ± 0.036  ms/op

CC @NarekDW could you update the PR?

@holdenk sure, done.

@holdenk should I close this PR?


Crash during Probe Evaluation

Hi,
I tried to select probes and then evaluate them, but spapros crashes during "Probeset specific pre computations" of the evaluations

Code

import spapros as sp
import scanpy as sc
adata = sc.read_h5ad("input/all_prepped.h5ad")
adata.uns['log1p']["base"] = None
selector = sp.selection.ProbesetSelector(adata, n=128, celltype_key="cell_type", verbosity=1, save_dir="/home/mz637064/hpcwork/spapros/testrun4")
selector.select_probeset()
selected_probeset = selector.probeset.index[selector.probeset["selection"]].to_list()
evaluator = sp.ev.ProbesetEvaluator(adata, verbosity=2, results_dir="/home/mz637064/hpcwork/spapros/spapros_evaluate2",celltype_key="cell_type")
evaluator.evaluate_probeset(adata, selected_probeset)

Log

Searching for previous results in /home/mz637064/hpcwork/spapros/testrun4
SPAPROS PROBESET SELECTION:
Select pca genes.......................................... ━━━━━━━  100% 0:00:15
Train baseline forest based on DE genes................... ━━━━━━━   4/4 0:36:53
Select DE genes......................................... ━━━━━━━ 11/11 0:00:00
Train prior forest for DE_baseline forest............... ━━━━━━━   3/3 0:05:26
Iteratively add DE genes to DE_baseline forest.......... ━━━━━━━   3/3 0:24:07
Train final baseline forest on all celltypes............ ━━━━━━━   3/3 0:04:27
Train final forests....................................... ━━━━━━━   3/3 0:18:31
Train forest on pre/prior/pca selected genes............ ━━━━━━━   3/3 0:05:44
Iteratively add genes from DE_baseline_forest........... ━━━━━━━ 12/12 0:07:47
Train final forest on all celltypes..................... ━━━━━━━   3/3 0:04:59
Compile probeset list..................................... ━━━━━━━  100% 0:00:00
FINISHED
SPAPROS PROBESET EVALUATION:
Shared metric computations................................ ━━━━━━━   3/3 0:29:46
Computing shared compuations for knn_overlap............ ━━━━━━━   6/6 0:26:59
Computing shared compuations for gene_corr.............. ━━━━━━━  100% 0:00:47
Probeset specific pre computations........................           0/3 0:00:00
Traceback (most recent call last):
File "/rwthfs/rz/cluster/hpcwork/mz637064/spapros/evaluate.py", line 11, in
evaluator.evaluate_probeset(adata, selected_probeset)
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/spapros/evaluation/evaluation.py", line 465, in evaluate_probeset
raise error
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/spapros/evaluation/evaluation.py", line 377, in evaluate_probeset
self.pre_results[metric][set_id] = metric_pre_computations(
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/spapros/evaluation/metrics.py", line 186, in metric_pre_computations
return knns(
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/spapros/evaluation/metrics.py", line 700, in knns
a = adata[:, genes].copy()
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/anndata/core/anndata.py", line 1113, in _getitem
oidx, vidx = self._normalize_indices(index)
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/anndata/_core/anndata.py", line 1094, in _normalize_indices
return _normalize_indices(index, self.obs_names, self.var_names)
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/anndata/_core/index.py", line 36, in _normalize_indices
ax1 = _normalize_index(ax1, names1)
File "/rwthfs/rz/cluster/home/mz637064/mambaforge/envs/spapros2/lib/python3.9/site-packages/anndata/_core/index.py", line 107, in _normalize_index
raise IndexError(f"Unknown indexer {indexer!r} of type {type(indexer)}")
IndexError: Unknown indexer AnnData object with n_obs × n_vars = 191795 × 8000
obs: 'sample', 'n_counts', 'n_genes', 'percent_mito', 'doublet_score', 'dissociation_score', 'cell_type_original', 'patient_region_id', 'patient', 'patient_group', 'major_labl', 'final_cluster', 'assay_ontology_term_id', 'development_stage_ontology_term_id', 'disease_ontology_term_id', 'ethnicity_ontology_term_id', 'is_primary_data', 'organism_ontology_term_id', 'sex_ontology_term_id', 'tissue_ontology_term_id', 'cell_type_ontology_term_id', 'cell_type', 'assay', 'disease', 'organism', 'sex', 'tissue', 'ethnicity', 'development_stage'
var: 'feature_biotype', 'highly_variable', 'means', 'dispersions', 'dispersions_norm'
uns: 'X_approximate_distribution', 'X_normalization', 'batch_condition', 'cell_type_ontology_term_id_colors', 'cell_type_original_colors', 'default_embedding', 'hvg', 'log1p', 'schema_version', 'title'
obsm: 'X_harmony', 'X_pca', 'X_umap' of type <class 'anndata._core.anndata.AnnData'>

Setup

Python 3.9.13
Spapros 0.1.0
Scanpy 1.9.1
Anndata 0.8.0

Any Ideas?

Hey,
did you try the same code with another adata? E.g.
adata = sp.ut.get_processed_pbmc_data()

(celltype_key="celltype")
just to see if it's a dataset specific problem or a general bug.

Yeah, I get the same index error. Very weird.

Unfortunately I couldn't reproduce the issue yet since I had some rly weird local dependency issues today that I couldn't fix.
I'll try to get to it asap but it'll be a busy week.
If you want to investigate further without waiting I'd recommend to install the spapros dev version (new env, git clone ..., cd to spapros, pip install -e .), and print the genes before the call of a = adata[:, genes].copy() in line 700 in spapros/evaluation/metrics.py. When you then run the evaluation, the first call should give the full adata.var_names (from shared computations step --> no Error here), and in the second call sth weird must happen.

Update to @pakiessling 's issue:
Sorry that I didn't catch this earlier,
evaluator.evaluate_probeset(adata, selected_probeset) must be evaluator.evaluate_probeset(selected_probeset).
I'm also running into @solvi808 's error now (thanks for raising!), will check that one next.

Resolved the issue:

PR #242
commit 769755500ef1455d0d6a8c464478c28d5ee3c679
new package release v0.1.1

Please reinstall spapros to get the latest version pip install spapros or pip install spapros==0.1.1


Update XMPFiles.xmp

qedqe

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

İlk dosyanızı veya notunuzu göndermek için  düğmesini seçin veya aşağıdaki ileti kutusuna yazın.
2024/01/22 23:07

<x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="Adobe XMP Core 6.0-c006 79.164036, 2020/10/15-10:07:01        ">
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<rdf:Description rdf:about=""
xmlns:crs="http://ns.adobe.com/camera-raw-settings/1.0/">
crs:Version13.2</crs:Version>
crs:ProcessVersion11.0</crs:ProcessVersion>
crs:WhiteBalanceAs Shot</crs:WhiteBalance>
crs:Temperature0</crs:Temperature>
crs:Tint0</crs:Tint>
crs:Exposure+0.20</crs:Exposure>
crs:Contrast+30</crs:Contrast>
crs:Highlights-30</crs:Highlights>
crs:Shadows+10</crs:Shadows>
crs:Whites0</crs:Whites>
crs:Blacks0</crs:Blacks>
crs:Clarity+10</crs:Clarity>
crs:Dehaze0</crs:Dehaze>
crs:Vibrance-10</crs:Vibrance>
crs:Saturation-10</crs:Saturation>

İlk dosyanızı veya notunuzu göndermek için  düğmesini seçin veya aşağıdaki ileti kutusuna yazın.
2024/01/22 23:07

<x:xmpmeta xmlns:x="adobe:ns:meta/" x:xmptk="Adobe XMP Core 6.0-c006 79.164036, 2020/10/15-10:07:01        ">
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<rdf:Description rdf:about=""
xmlns:crs="http://ns.adobe.com/camera-raw-settings/1.0/">
crs:Version13.2</crs:Version>
crs:ProcessVersion11.0</crs:ProcessVersion>
crs:WhiteBalanceAs Shot</crs:WhiteBalance>
crs:Temperature0</crs:Temperature>
crs:Tint0</crs:Tint>
crs:Exposure+0.20</crs:Exposure>
crs:Contrast+30</crs:Contrast>
crs:Highlights-30</crs:Highlights>
crs:Shadows+10</crs:Shadows>
crs:Whites0</crs:Whites>
crs:Blacks0</crs:Blacks>
crs:Clarity+10</crs:Clarity>
crs:Dehaze0</crs:Dehaze>
crs:Vibrance-10</crs:Vibrance>
crs:Saturation-10</crs:Saturation>


error when using function hoisting

The following will give the error "Inner functions should be listed at the top of the outer function."
Can we have an option to turn off this check?  It looks pretty straight forward in the code.  I noticed that another ticket was put in for something similar (using functions before they are defined) and that became the default behavior.  Shouldn't This should probably fall under the same principal?
function foo() {
return {
bar: function() {return bar();}
};
function bar() {
return 10;
}
}
console.log(foo().bar());

Fixed in d17ce8d.


Extension version question

Hiya -
On my current system, I have Caret Tab v3.6.2 somehow, but when I install the add-on from the Firefox store, it only has up to v2.3.1?
Is there a link to get 3.6.2 or force Firefox to update from somewhere else?

Duh.  Nevermind.  Found it.


Heat Legend Previews not showing

The het legend previews in the dropdown menu to select a preset seem to not render properly.
The Option Items are blank until after a preset is clicked on.

Issue resolved ..... now Heat lagend previews is showing ....

Nice,
can you create a PR for it so we can take a look at it and merge it into the develop branch?
remember to mention the issue in your PR description so github links them.


Bump TD to 2.1-rc-1

Addresses https://github.com/gradle/dotcom/issues/9470

@bot-gradle test rfm

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test rfm

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Remove Unused Imports

Remove Unused Imports

Most of these (apart the one from the example script) are there for namespace reasons.

You mean decode_predictions and preprocess_input?

Yes.