Added PDF export option based on Canvas export

I submitted a feature request issue earlier today: #1800  consisting of a request to add PDF export functionality because it's sometimes easier to share PDFs with colleagues. Anyhow, I took a look at the code and realized I might be able to implement it myself. Which I did.
I based it off of the Canvas exporter already used, and I use the jsPDF library as well. Other than that, I followed the same pattern used in other exporters such as the SVG exporter to implement this feature.

https://github.com/excalidraw/excalidraw/issues/411 could be next :)

It doesn't work with tall images. It swaps height and width.

I also wonder if this use case --- "easier sharing" (which is weird. How is sharing a PDF easier than a PNG?) --- is worth adding it.

From your feedback, it seems you don't want anything that would cost you too much in terms of performance. So, I'm proposing a different alternative inspired by @lipis's comment suggesting to tackle #411  next, which is an issue about "Printing".
It's using the window.print() functionality. By instantiating an iframe and appending to the body, we can use that iframe's window object to fill it up with the data we want and then print it.

@ikteru I'd be fine if you inline the output of the pdf file instead of bringing the entire jspdf project. I believe that it's going to be a small enough addition that it's worth adding to the project.

@vjeux , honestly, I didn't quite understand what you meant with inlining the output of the pdf file instead. However, the alternative I just proposed doesn't require any library, it's just those lines of code I mentioned.

If you use your branch and export a pdf, it generates a pdf file. Open the pdf file using a text editor and it'll show you https://github.com/excalidraw/excalidraw/pull/1806#discussion_r443684801
So take the output which is mostly text, inline it inside of the js file and concatenate the two text parts with the binary version of the png file and send it to the save file.

If you're going the print way, I would call it print rather than pdf, otherwise it's super confusing.
I would love this option too to be honest. I tried to print a scene the other day and it ended up being more difficult than I originally anticipated.

@vjeux , I'll try implementing the way you mentioned. I'll also take a look and see if I can implement a "print" button as well.

Looks like there's a beforeprint/afterprint event. Maybe we can do your hackery in those events so that when people use the default print functionality it'll just work.
https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeprint_event

@vjeux , let me elaborate and correct me if I'm wrong: you mean when someone click on Ctrl+P or uses Settings -> Print, they'll be able to "print" whatever it is is selected ? Or if nothing is selected, the whole thing?

@ikteru correct. So now, your print button in export would just call window.print()

Whatever you're doing with your print thing, keep doing it, because it finally works for me :+1:. But yes, let's use the beforeprint as @vjeux suggested.

Okay, so here is the deal guys. I can make it happen for Ctrl + P , just not for Settings -> Print . It is just impossible to stop the Browser from displaying the printing interface when a user click on Settings -> Print. It happens even before the "beforeprint" event is triggered.

Okay, so looks like beforeprint/afterprint is not doing what it actually says it should. So let's drop the idea and have a print button that does it then.

@vjeux , it's your lucky day, you get the button aaand the shortcut ;)

Okay @vjeux and @dwelle, so here is the deal guys. I can make it happen for Ctrl + P , just not for Settings -> Print . It is just impossible to stop the Browser from displaying the printing interface when a user click on Settings -> Print. It happens even before the "beforeprint" event is triggered.

What browsers were you testing on? In Chrome & FF it seems to work as designed: https://jsbin.com/mamapohire/edit?html,css,js,output

@dwelle , the events work. They do get triggered. The problem is stopping the print screen from appearing. It's impossible. Because the one by the browser is the one that doesn't work properly and just prints out the viewport. To sircumvent that, I used an iframe where I control the window object. Because I shouldn't modify the regular window object because that would change the whole app.
The way I made this work is by creating an iframe, filling it up with the SVG version of the canvas then calling window.print() on it. Meaning, that if I want to make it work for the Settings -> Print , I should stop the regular one from happening and triggering my own, the same way I did with the other two solutions that worked. And stopping it is apparently impossible. Try doing that in the example you mentioned, it won't work.

I see, I didn't understand you're printing from a different window object.
One way would be to just replace the whole DOM of top-level document with the SVG on beforeprint, and on afterprint replace it back. But wouldn't play well with React (you'd have to remount and have it to end up in the exact same state as before).
So what you're doing is the right way to got, I think.

I wanted to avoid touching the UI more than I need to. However, if we go with that suggestion. When someone clicks on settings -> print, the browser printing screen will pop up, but the UI will have changed to the svg content and the user will see that. It will look like a glitch. Only after the user clicks on "Print" or "Cancel" does the "afterprint" event get triggered and we can reload the regular UI.

When someone clicks on settings -> print, the browser printing screen will pop up, but the UI will have changed to the svg content and the user will see that. It will look like a glitch. Only after the user clicks on "Print" or "Cancel" does the "afterprint" event get triggered and we can reload the regular UI.

Yes, but I reckon better that than having the print output incorrect.

@dwelle , you got what you wanted ;)

I was checking if the printing workflow can be simplified, and since I had the changes done locally already, I pushed them.

ctrl+p was still doing the iframe thing resulting in printing both containers. I removed the iframe solution altogether as there's no reason for it now.

Removed the ctrl+p from shortcut helper. It's a well-known browser default.

Removed the print container from index.html in favor of creating it in place. Keep printing logic colocated.

[ ] There's one big problem that was present even in your implem via iframe: first time around you print, the text doesn't render for me. It's likely because the print dialog doesn't wait for the SVG to load the custom font. If I switch to regular font (system font), this bug doesn't manifest. I'm not sure what we can do about it. If you don't figure anything out, you'll probably need to create a huge canvas (so it's fully visible) and render to that, instead of using SVG.

@ikteru hey, are you willing to continue on this PR?

Hack-fixed preloading fonts for print.
I'm not sure if behavior around long vertical scenes is good enough (it splits on multiple pages), and whether it warrants a button in export dialog.
/cc @lipis

Can we make it so it won't split in multiple pages for big scenes?
Also it doesn't take into the account the "Only selected" option when is unchecked and you have selected objects.
Other than that I like the idea of having the Print button there as long as it's always just one page

Closing this, due to inactivity.. if anyone wants to continue, feel free to get inspired from here.

is it possible to make a pdf export that pushes the png export into PDF and then creates PDF imagemaps items for the links. as far as i understand the board object model can provide the coordinates and project them over the rasterized copy of the board.
not sure if it's a controvertial thing WRt to PDF, since they're vector cool and all but sending vectors in the PDF but really isn't high value when PNG compression works so well on this board type content.  Most obvious use cases for PDFing a board is to take a subset or make a single page PDF.


azurermwebappdeployment.js not found on hosted build agent

Hello, sorry if this is not the proper place for issues like this but as of like an hour ago we get error like this when publishing.
2016-11-11T13:22:39.8820811Z ##[section]Starting: Deploy QueueAdapter
2016-11-11T13:22:39.8850822Z     ==============================================================================
2016-11-11T13:22:39.8850822Z Task         : Azure App Service Deploy
2016-11-11T13:22:39.8850822Z Description  : Update Azure App Service using Web Deploy / Kudu REST APIs
2016-11-11T13:22:39.8850822Z Version      : 2.1.3
2016-11-11T13:22:39.8850822Z Author       : Microsoft Corporation
2016-11-11T13:22:39.8850822Z Help         : [More Information]    (https://aka.ms/azurermwebdeployreadme)
2016-11-11T13:22:39.8850822Z     ==============================================================================
2016-11-11T13:22:40.1441151Z ##[error]File not found: 'C:\a\_tasks\AzureRmWebAppDeploy_497d490f-eea7-4f2b-ab94-48d9c1acdcb1\2.1.3\azurermwebappdeployment.js'

2016-11-11T13:22:40.1521151Z ##[section]Finishing: Deploy QueueAdapter
Is this a known issue?

It was also reported in this thread. Two lines down ... :-)    https://github.com/Microsoft/vsts-tasks/issues/3074
Where several other people are reporting it as well ..

ah, thanks, missed that
Closing this one as a duplicate


Add different types of modifiers (like GAS)

Right now we just have addition :). let's add more!

:+1: x 100, I'll get this in very soon


Step indicator is not in the reading order [Android]

The step indicator found on the “How it works” screens is not included in the reading order. The visual information it provides is not available to TalkBack users. I would suggest including it in the reading order and providing a proper text alternative (e.g., “Step 2 of 4”).

Severity: Low

@jonnyjames This has now been addressed. See https://github.com/project-vagabond/covid-green-app/issues/195

@floridemai The pagination control is now in the reading order, but it has some extraneous label text, announced as "page selector, page 1 of 4, see[?] control". I would parse the text to include just "page 1 of 4" and remove the reference to "page selector' and "see[?] control", since it isn't a selectork and isn't actionable.

@jonnyjames Done.

This is now fixed. Closing this issue.


Longest Common Subsequence in Python

Hello!
Can I work on this one?

Sure! Go ahead😄

I've added the code. Please review.
PR : #82
Thanks! 😇


Phoebemirman/ch17807/market creation categorical outcome incorrect

https://app.clubhouse.io/augur/story/17807/market-creation-categorical-outcome-incorrect-when-paging-back

Coverage remained the same at 56.237% when pulling b40de533e00e7b72fca6ec21c543a8b6150ac641 on phoebemirman/ch17807/market-creation-categorical-outcome-incorrect into f19b061f9dda5e8b377eeea08ecb8f8a69f5bca2 on master.

Coverage remained the same at 56.237% when pulling b40de533e00e7b72fca6ec21c543a8b6150ac641 on phoebemirman/ch17807/market-creation-categorical-outcome-incorrect into f19b061f9dda5e8b377eeea08ecb8f8a69f5bca2 on master.


Supports DIP4

Proposed Changes
DIP4, the significant change in Dev Protocol. By that change, some behaviors in this app should follow that.
Implementation

Remove the "Mining" button, that's no longer needed.
Replace the index of "Assets Strength" to staking share( staking on a property/staking on the total protocol ).
Replace the "Avg. Interest" to self staking amount.
Add indication of APY and Annual Supply Growth Ratio.

@abyssparanoia @k3nt0w The changes had to be made in time for the DIP4 release, and on June 29th AM, so I'll merge this at my discretion. If there's a problem, I'll work on a patch to fix it!


loading error

it spins forever.
to repo:

open the website
leave it for a while
it loads itself and two sections do not load well.

Analytics endpoint out stage due to maintenance at that moment. It's normal now.


[DOCS] [cosmetic] Add JAX favicon to sphinx docs

Add this 64px x 64px favicon to the docs:

If someone (@mattjj?) has a vector format copy of the logo it might be worth deleting the gray grid lines for the favicon to make it a bit clearer.

You mean like this?

I guess this still might be a little hard to read at favicon size, though.

Thanks! I don’t think it needs to be readable, just recognisable. I’ll try out the version you just sent and see if it looks better.

That looks a tad better in my opinion.


chore: release 2.3.0

Release notes:
https://github.com/google/node-gtoken/releases/edit/untagged-35f2d0f01382ac115d1b

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         111    111
  Branches       22     22
=====================================
  Hits          111    111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb966e...a70b6b7. Read the comment docs.


Fix up linter failures

For now we need to commend out deadcode, since I can not figure out how to stop
it looking at cGo Generated code.
I removed all of the go dead code that it was finding.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@saschagrunert Do you know how to make the linter ignore cgo generated code for deadcode check?

@mrunalp Any idea how to get the linter into OpenShift?

@saschagrunert Do you know how to make the linter ignore cgo generated code for deadcode check?

If we know the names of the files/dirs we could exlude them via the configuration:
https://github.com/golangci/golangci-lint/blob/8c1237b/.golangci.example.yml#L22-L37

@rhatdan the change has to be made in the openshift git repo as well as have them approve and merge it.  this is why i wanted to revert it so we could still be useful while that happens.

also, we could just disable the deadcode check for now by altering .golangci.yml

@baude Understood on disabling the #deadcode.  And this PR Actually does disable it, although I would love to figure out how to fix or ignore the cgo failures.

@rhatdan Do you have a run where the actual issues with the deadcode linter happens?
I would like to support here but I'm not sure how to reproduce the mentioned issue. I thought that #2863 + the availability of golangci-lint on the machine running ci/prow/lint should be enough to make the pipeline working again.

@rhatdan Do you have a run where the mentioned issues with the deadcode linter happen?
I would like to support here but I'm not sure how to reproduce it. I thought that #2863 + the availability of golangci-lint on the machine running ci/prow/lint should be enough to make the pipeline working again.

again, the availability of the the new linter on prow is not a snap of the fingers.  It would be more prudent to do that first and then do what was done.

FYI y'all control what container image is used to run the linting job (it's not a machine and nobody installs anything to it!!). Add the linter to your build_root and also to your other base image here -- @baude added the Dockerfiles for those images here. You should be able to (and feel free to) check in any OWNERS file you want into those directories so that you can your teams can control and merge into them at will, without having to ask anyone else for help. If you make sure that applying your build YAML to the cluster is part of the make postsubmit-update target in openshift/release, changes to the libpod.yaml will automatically be applied to the cluster on merge.

Assuming we can get the image we use for lint regnerated, per Steve's instructions...
LGTM.

We merged the revert to unblock work.
I'll leave this open for now, but it should include the original patches as well.

We can wait for @cevich to return, to finish the work.  I hate to go back, but this seems to be best for now.

I'm going to close this. We should handle the migration back to golangci-lint in a separate PR.


Archiving a stream in the same transaction as appending events to it leaves stream events unarchived

When a stream fetched using optimistic concurrency via FetchForWriting<T> is archived using IDocumentSession.Events.ArchiveStream() any events that have been appended in the same transaction prior to calling ArchiveStream() remain with is_archived = false in the mt_events table, even though the stream itself is marked as archived in mt_streams.
Reproduction steps:

Fetch a stream using IDocumentSession.Events.FetchForWriting<T>
Append one or more events to the stream using IEventStream<T>.AppendMany
Archive the stream using IDocumentSession.Events.ArchiveStream
Commit the transaction using IDocumentSession.SaveChangesAsync

Isn't this intended?
At least we thought so and use this behavior when we "hard-delete" something.

Append "hard delete" event to stream
Archive the same stream

this results in
"hard delete" event in unarchived state
all affected projections are run
stream itself and all previous events are archived
This allows us to rerun projection that have to delete data for the hard delete event.
But if the hard delete event is archived too, the event would be ignored during rebuilding the projection.
Once a day we cleanup archived streams from the database.

@Xzelsius There's a switch on most of the built in projections to utilize archived events in rebuilds. You shouldn't use it willy nilly, but it's there

@AtomYcX I'm going to address this by adding documentation to the effect that, yes, this is legal. @Xzelsius talked this over with me off to the side, and there is a valid use case for doing this. Maybe there could be a separate action for "archive all new events too"?
But also, what was your use case? Why did you both append and try to archive at the same time?

Hi @jeremydmiller,
Our use case aligns with what @Xzelsius described above about "hard deleting" a stream.
We have some aggregates that we want to completely remove from projections and from any future rebuilds of those projections. Hence, we were appending a "deleted" event and archiving the stream.
Think the 1st question of #3258 more accurately describes our problem. Happy to close this in favor of it.

I think the advent of the Archived event type might make this unnecessary and I just don't want to change the existing behavior if somebody is depending on it.


F# bad highlighting

This file is not highlighted properly:
https://github.com/dezelin/BitcoinZ/blob/feature_tracker/Bitcoin/TestMessageSerialization.fs

@dezelin Linguist only selects the appropriate grammar for highlighting. In the case of F#, it uses this Atom bundle. You should open an issue there ;)

You should open an issue there ;)

:+1:


Fix Windows debug information for classes

Fixes a longstanding issue where we were emitting erroneous vfptr debug entries and incorrectly mangling class names. One could only inspect things as they were statically typed in the source (so if a variable was typed as object in the sources, you wouldn't see any fields in the native debugger, no matter what was assigned to it).
It wasn't too terrible, so I sort of just lived with it, but this should work.
With this, casting to base classes in the debugger works.
Before

After

Maybe we should also just hide the m_pEEType field on System.Object...


Add weekly highlights for the week ending on 2021-11-12

Please add your input until Friday 14:00 CET

Please, @giantswarm/sig-product , don't be shy!


Refactor: Add User DTOs

As a developer, I want to have the User Entity to have a Data Transfer Objects (DTO) for updating a user.
The User Controller and User Service method addUser are redundant, the Auth module creates new users with the sign-up methods in the Auth Controller and Service with a DTO. I propose removing these methods.
This will make our coding styles the same across this project and in conjunction with NSC Events.
A update-user.dto object should be created.
This issue relates to issue #47

Yes, I agree.
addUser is redundant since we created sign-up already.


Only cache service definitions

#1300

LGTM

I kinda feel we should revisit this entirely

@SvenDowideit Sounds good.

@SvenDowideit Thinking about reopening this. I don't think we'll have time for a comprehensive refactoring of services before v0.8.0 and AFAIK this is strictly better than current caching.

I feel I'd get confused if we cache some things, and not others - perhaps the quick change we can do is to add an --invalidate-cache that removes all cached files (i'm assuming that once a service is enabled, we're storing that cfg elsewhere - like in the config?

yes, reopening for discussion

The only two things that are cached right now are service definitions and the os-services index.yml. Essentially, this PR just removes the latter from being cached. If I was a user I think I'd be more confused by this behavior than only caching service definitions.

As a user, I'm confused about how, or when I get an updated service definition.

Definitely agree the story around updating a service config is confusing. This PR shouldn't change anything around that though. The only thing this does is stop caching things that shouldn't be cached.

Changing my mind on this one again. I'd rather think about this more.


Hook up repository with Travis

Add some test commands, connect the repository with Travis and deploy to Heroku after everything has been sanitized to avoid pushing broken changes to production.

Looks good. :boom: :hospital:


HHH-13380 - bytecode enhanced entities in OneToMany relationship with…

… custom equals() in child entity throws LazyInitializationException.
The core of the fix is in PojoEntityInstantiator so that it can set the session in the LazyAttributeLoadingInterceptor.  This allows the equals method in the child entity of the OneToMany to refer to the lazily loaded Parent entity and get it initialized.  Without this change, the lazy loading of the OneToMany throws a LazyInstantiationException because it had no reference to the session in order to load the parent entity.

Hi @jay-m-paulsen - apologies for the very long delay. Found this now as I was debugging the same issue reported as https://github.com/quarkusio/quarkus/issues/11325 .
I'll review, rebase and apply your patch soon, although maybe I'll need to avoid changing the SPI.
Many thanks!

I've merged this, but using a different solution for the 5.4 and master branches so to not break the current SPI.
I like the solution proposed here better though, and have made a note to apply this idea on ORM6.
Thanks again!

@Sanne - HHH-13377 is a similar problem that I reported around the same time as HHH-13380. You may find it relevant for your work. Thanks!


Incorrect JSON for .bot file

KbId should be kbId

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2963321c-6720-be8f-aba6-225960eba1b3
Version Independent ID: bff968a7-33a8-bc53-b08b-6c17d672c3cd
Content: Use QnA Maker to answer questions - Bot Service
Content Source: articles/v4sdk/bot-builder-howto-qna.md
Service: bot-service
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

Hi Lilian,
Thanks for your feedback. I'll fix this in the article and you will see it on its next publication.

corrected article.


Client crash

I teleported to Marim from house and client crashed. Cannot reproduce it. Attached logs.
hs_err_pid70416.log

Seems like it was OSRS client issue and it was fixed in latest OSRS release, reopen if this occurs again.


Added output http header

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Razikus
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

fed14a7 Added output http header

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Welcome @Razikus! It looks like this is your first PR to falcosecurity/falco 🎉

Hey @Razikus
Thank you for your PR, but we need you to sign off your commits  before we look at this PR. Could you fix that, please?
Including a description of this change in the PR would also be nice.
Thank you!

/milestone 0.37.0

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Incorporate other optional parameters from the google api ?

This is the spec on the API site
The one I would like to use immediately is components

Perfect I jump on this also :)

I've add components and radius :)


Remove --strict option from LintPlugin so that it doesn't constantly crash.

The LintPlugin command plugin has default settings that include --strict in the arguments. This causes any lint run to exit with a 1 and report as an error.
I removed the default inclusion of --strict and added a filter to make sure that it isn't passed in a plugin run.
No tests were added because SPM Plugin targets don't currently support tests.

Would this cause problems for anyone who wanted to use LintPlugin in a CI scenario, where they use SPM to kick off the plug-in and detect success/failure based on the error code?
I don't have a lot of experience with SPM plug-ins in general (and from what I've seen, the design of the overall system is a bit limited), but I'd like to better understand the problem that this is solving and ensure that we're not harming other workflows if we do this.

The issue is that in the regular operation of the linter if it finds any issue it prints warnings. Those warnings make it exit with a non-zero and then your IDE shows a failure when the plugin finishes.
Here is an example of a successful use of the current command plugin in Xcode.

A simple change would be to not add --strict by default, but also allow it to be added. Simple to do.
I also think though that most folks on CI will just run swift-format lint rather than trying to mess with the command plugin as it is more for interactive use. Unlike a build plugin, the messages here are not in the build logs. Honestly I just run swift-lint lint via a script step in my builds for linting so that I can see the messages in Xcode's code editor.

If we're offering SPM plug-ins, I don't think we should necessarily assume that people would run swift-format manually in CI use cases. It seems like running the SPM command would be a perfectly reasonable entry point, interactive or not.
If the issue is that Xcode renders this incorrectly, we might have other options here since the Xcode plug-in interface is different than the command-line interface. What if the implementation was updated so that Xcode's plug-in used Diagnostics.warning instead of Diagnostics.error for the failure case? Would that meet your needs without removing --strict?
Longer term, I wonder if we should provide a structured output format for the lint findings (something I've considered before but never had the need to implement), and the Xcode plug-in could capture and parse those and turn each finding individually into a Diagnostics.warning call instead of printing the output to the terminal.

OK, changing that exit to Diagnostic.warning works well. I'll see what we would need to do in order to just have the Xcode plugin runs use it so that CLI users can still get a failure code when finding linter warnings.
Should I close this PR and make a new one with a more accurate title when it is ready?

Longer term for Xcode, and other IDEs, need a build plugin so that the warnings appear inline with the code.
With the command plugin you see this in Xcode.

When running swift-lint as part of the build you have far more actionable warnings like this.

I know which output I would rather use.

Based on discussion above, closing to solve a different way.


Unexpected character encountered while parsing value

I have this error pop up constantly no matter which game I am playing (steam, gog, games on emulators, you name it). Not sure what this is about, but I was told to mention this here.
extensions.log
playnite.log
Not sure if this is related, but for some games, SuccessStory does not download any RetroAchievements. Affected are e.g. Vagrant Story or Parasite Eve. But the achievements work in the emulator I use, and only some games seem to be affected.

same problem here

Problem persists after update. It seems this only happens when connecting to RetroAchievements:
07-01 21:07:46.250|ERROR|SuccessStory#Common:Error on GetMD5List()|G:\GitHub\Lacro59\playnite-successstory-plugin\source\Clients\RetroAchievements.cs|241 Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
SuccessStory_2024-01-08.zip


[Bug]: Selecting a list item where an widget is fails to select that list item

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have a list, there are a series of text widgets on that list.  I'd like my users to select a list item and then have a form populate with information about that item.
This generally works, but if the user clicks anywhere on the item where a widget exists, it does not select that list item.
This might make sense for a button or text input that the user is clearly meaning to select as opposed to the entire list item, but not for non-interactable elements such as text.  Even if it was an interactable element such as a button or text it should not be a problem to select that entire list element (and may aid in the user experience to notice what other elements are grouped with the text input).
Steps To Reproduce

Create a list
Populate the list with a large text widget, but with the text "test" occupying a small portion of that widget
Deploy the app
View the deployed app
Click on the word test
Notice that the list item is not selected
Click on the empty space that is inside the test text widget but not on the word test
Notice the list item is not selected
Click on the list item in a space that is not inside the text widget at all
Notice the list item is now selected

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

@eedwardsSGS we fixed the issue here #21409, this should be available in the next version


[SimEngine][Analytics][dapp] Sign off on altair vs. plotly

Background / motivation
As we've been migrating away from vanilla matplotlib to streamlit matplotlib, we have also been working through other packages such that we can improve the overall stack of technologies and achieve the responsiveness/simplicity of building these charts.
Altair vs. Plotly have various tradeoffs, and as a team, we should make an intentional decision as how we can move forward with this.
This ticket is meant for us to document these tradeoffs, review them, and sign off on how we'll be using the stack from this point onwards.
TODOs / DoD

[ ] Provide a detail breakdown of the tradeoffs between Altair vs. Plotly
[ ] Review and discuss these as a team so we can sign off on how to move forward with this

Related github issues

#749

After reviewing where we're at in sprint planning, altair is a bottleneck in order to move to other web frameworks. Plotly in particular doesn't use altair, and panel may also benefit from this unification.
As a result we want to port all the charts from altair to plotly, in preparation for this.


Throttle log messages

Sometimes it happens that the same message is printed out in a tight loop, filling the logs with heaps of unhelpful stuff.
If the same log record appears too often, we should throttle it.

This is treating a symptom rather than the cause. We should not have such logging in a tight loop in the first place


revision tags on dockerhub

This was discussed on https://github.com/oragono/oragono-docker/issues/18 and https://github.com/oragono/oragono-docker/issues/20 but it got lost in the shuffle --- basically, we want a tagged image corresponding to each git tag.

The docker README claims, incorrectly, that we are already doing this:
https://github.com/oragono/oragono/blame/57f2857e835cd8e559ed4e3397c13f696452a7d1/distrib/docker/README.md#L11
We should either remove this claim, or fix the issue, for 2.2.

#1196 documents this. Kicking the underlying issue over to 2.3.

I may or may not have fixed this; we won't really know until we push a new tag :-\
I had to create @oragono-role-user and an oragonoroleuser on dockerhub for this.

I wrote the rule incorrectly, so it didn't match v2.4.0-rc1; we'll try again for v2.4.0.

This appears to have worked: https://hub.docker.com/layers/oragono/oragono/v2.4.0/images/sha256-fd82b67b10cb8e9458d3036f4aab9ca0182b4dacba17f3164a45d1f4fe3a5263


TouchableWithoutFeedback inside the Swiper doesn't fire

I tried to run the PhotoView example on iOS simulator and there is no way to close the modal pressing the photo. TheTouchableWithoutFeedback doesn't fire at all.

me,too

me too, Has anyone figure out?

temporary ugly solution - setting onTap = {props.pressHandle} within PhotoView. And wait until onViewTap becomes available - https://github.com/alwx/react-native-photo-view/issues/11


More than one model

Hi everyone , i asking for solution in RAsa Nlu, now i know how to use multiple models but i wont if i send a request to rasa_nlu server i dont specify the model name I want my server to detect it ? how can make it ? and thanks all

You'll need to explain more about what you mean by detect it. Do you want it to choose the latest? Do you want it to choose the most recently used? Or you want to detect it with natural language?
It sounds like you should really just be using a single model and allowing it to parse out the correct intent.

@wrathagom thanks for your answer, i mean by detect it : i suppose that i made many models like weather, restaurant, ... and you want when i send request i dont wont to specify wish model i can use i want it to search in all models and give the best respond.

Why did you separate them in the first place?
The problem with separating and then rejoining is that the confidence scores won't be weighted the same. So choosing the right intent will not be as straightforward as it seems.

I also would like to have more then one model. My use case is a support bot that is used by several different companies. I would like to be able to send requests to rasa while specifying the model to use so that companies data can overlap.

@tmbo @amn41 @PHLF any thought on offering cross-domain or cross-agent parsing? If so I can mark as enhancement and help wanted. Otherwise I'll close.

I think it adds a lot of complexity and I wouldn't know to make this work "in general". Let's close - I think this is up to bot developers to create for their use case.


OS agnostic MOM6_GEOSPLUG Label in GEOS_OceanGridComp.F90

I am testing on a mac which does not build libMOM6_GEOSPlug.so, but instead builds: libMOM6_GEOSPlug.dylib
NOTE: difference in extensions.
On discover, no problems, but on mac, since libMOM6_GEOSPlug.dylib does not exist, following:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/blob/f2272cbb6aa7b9e163ac3c4e41a910e94a90885b/GEOSogcm_GridComp/GEOS_OceanGridComp/GEOS_OceanGridComp.F90#L123
did not work and I got an error message:

pe=00003 FAIL at line=00145    BaseProfiler.F90                         <Timer  does not match start timer >

Clearly the extension .so should not be assumed for libMOM6_GEOSPlug.
@tclune helped identify this cause, he would be able to provide details. Thanks!

@weiyuan-jiang This issue should be split into 2.   One is to make the behavior OS agnostic.   The other is figuring out why the error trapping did not work correctly.   The latter is the priority.  (And not necessarily for @weiyuan-jiang )

@tclune I changed the title to reflect your ⬆ suggestion, thank you!
I guess we can get to

The other is figuring out why the error trapping did not work correctly. The latter is the priority. (And not necessarily for @weiyuan-jiang )

later ...

I think the trap should be in MAPL_AddChild. I will trace it

I think the trap should be in MAPL_AddChild. I will trace it

Thanks!

Okay... I can think of a couple ways to do this. I'll need to discuss with @tclune

I tried to reproduce the errors by intentionally introducing a wrong shared lib like "MOM_GEOS5PLUGMOD: wrong.so".  The program correctly identified the line it crashes (line number may be different from yours).
pe=00105 FAIL at line=04947    MAPL_Generic.F90                         <status=506>
pe=00105 FAIL at line=00122    GEOS_OceanGridComp.F90                   <status=506>
pe=00105 FAIL at line=00145    BaseProfiler.F90                         <Timer  does not match start timer >
Did the first two error lines appear in your error message? @sanAkel

I tried to reproduce the errors by intentionally introducing a wrong shared lib like "MOM_GEOS5PLUGMOD: wrong.so". The program correctly identified the line it crashes (line number may be different from yours). pe=00105 FAIL at line=04947 MAPL_Generic.F90 <status=506> pe=00105 FAIL at line=00122 GEOS_OceanGridComp.F90 <status=506> pe=00105 FAIL at line=00145 BaseProfiler.F90
Did the first two error lines appear in your error message? @sanAkel

yes.

Sorry I didn't see it.  Then error tapping works fine. We need platform dependent defaults. @mathomp4 , have you come up good ideas?

@weiyuan-jiang Yes. I'm getting close. Trying to write some code for MAPL now

Sorry I didn't see it. Then error tapping works fine. We need platform dependent defaults. @mathomp4 , have you come up good ideas?

@weiyuan-jiang I don't think it does. I think @tclune was thinking that the eventual ESMF calls should be checking not only RC but also userRC ?

The use reported by @sanAkel definitely reported the wrong error.

I don't think so. The error code "506" means "ESMC_RC_ARG_BAD". In this case, the argument  sharedobj is  bad.


grpc server reflection flag

To echo https://github.com/lyft/flyteadmin/pull/34/commits/cf739c2f6209389678973c46eb79ac84f2e8709a this PR adds a config flag to enable GRPC server reflection (default to disable).

There are more changes not related to this config flag, but due to the way pflag generating files.


Missing pins in template def

The range gpio_loopback_zero[15:23] is missing in the template def file. In addition, some pins such as gpio_loopback_one[0] have two definitions. Each definition has a different location.

They are correct in the main branch which indicates that the main branch is more up-to-date.  I'll need to regenerate the DEF from the version in main.  Although there may be conflicting changes between the two branches that I need to resolve.  I will look into it.

The main branch has the pin shift issue which was reported here https://github.com/efabless/caravel/issues/470. We need to settle on which one to use and continue with

@kareefardi :  Should be fixed now.


[feature-request] Allow setting up multiple npm tokens

We have a use case that requires us to pull deps from multiple private npm repositories, each requiring a unique npm token. Will it make sense to request for this feature in this plugin?
Thanks!

I'd be open to work on this PR, but will need some guidance on how to go about it!

Hey @arthurw1! I think the first step is to determine how the config will look like.
Do you have any ideas here? e.g.
- seek-oss/private-npm#v1.2.0:
    registry:
      - path: //registry.npmjs.org/
        env: MY_ENV_VAR
      - path: //myprivatenpm.com/
        file: my_token_file

Hi @72636c
I was thinking of the following. Similar to your suggestion but without the registry nesting:
plugins:
  - seek-oss/private-npm#v1.2.0:
      - env: "TOKEN_1"
        registry: //myprivatenpm1.com/
      - env: "TOKEN_2"
        registry: //myprivatenpm2.com/

Do we need to accommodate for cases where file or token fields are provided instead?

LGTM! Let's start out with env support, and we can add the others later if there's a need.
There's an example of parsing out a string list in the Docker ECR Cache plugin: https://github.com/seek-oss/docker-ecr-cache-buildkite-plugin/blob/d2a4b4763f2fe9c01a79eab10633bddcbc8e4f4c/hooks/lib/stdlib.bash#L23-L26. The code here may be slightly more involved since we'd be accessing nested names like "BUILDKITE_PLUGIN_PRIVATE_NPM_${INDEX}_ENV" and "BUILDKITE_PLUGIN_PRIVATE_NPM_${INDEX}_REGISTRY".

I see. Will look into it!

@72636c
I ended up with a schema that is similar to your initial suggestion:
- seek-oss/private-npm#v1.2.0:
    multi-registries:
      - path: //registry.npmjs.org/
        env: MY_ENV_VAR
      - path: //myprivatenpm.com/
        file: my_token_file

The feature is added and seems to be working when running pre-command locally. But I'd also like to test if my plugin.yml is configured correctly and if the variables are mapped as expected -- what is the best way to do this?


Etcd cluster does not bring up after failure

Describe the bug
If all etcd pods were done, the etcd cluster will not work anymore
To Reproduce
Steps to reproduce the behavior:
kubectl delete -n mayastor `kubectl get pod -n mayastor -o name | grep etcd`

Expected behavior
etcd-cluster up
Screenshots
If applicable, add screenshots to help explain your problem.
** OS info (please complete the following information):**

Distro: Ubuntu 20.04
Kernel 5.4.0-54-generic
MayaStor revision 1.0.0

Additional context
Log of one of the pod:
etcd 10:21:22.14
etcd 10:21:22.14 Welcome to the Bitnami etcd container
etcd 10:21:22.14 Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-etcd
etcd 10:21:22.14 Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-etcd/issues
etcd 10:21:22.14
etcd 10:21:22.14 INFO  ==> ** Starting etcd setup **
etcd 10:21:22.16 INFO  ==> Validating settings in ETCD_* env vars..
etcd 10:21:22.16 WARN  ==> You set the environment variable ALLOW_NONE_AUTHENTICATION=yes. For safety reasons, do not use this flag in a production environment.
etcd 10:21:22.16 INFO  ==> Initializing etcd
etcd 10:21:22.16 INFO  ==> Detected data from previous deployments
etcd 10:21:37.26 WARN  ==> Cluster not responding!
etcd 10:21:37.26 WARN  ==> Disaster recovery is disabled, the cluster will try to recover on it's own
etcd 10:21:37.26 INFO  ==> ** etcd setup finished! **

etcd 10:21:37.28 INFO  ==> ** Starting etcd **
2022-01-25 10:21:37.290497 I | pkg/flags: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2379
2022-01-25 10:21:37.290545 I | pkg/flags: recognized and used environment variable ETCD_AUTO_TLS=false
2022-01-25 10:21:37.290557 I | pkg/flags: recognized and used environment variable ETCD_CLIENT_CERT_AUTH=false
2022-01-25 10:21:37.290567 I | pkg/flags: recognized and used environment variable ETCD_DATA_DIR=/bitnami/etcd/data
2022-01-25 10:21:37.290604 I | pkg/flags: recognized and used environment variable ETCD_INITIAL_ADVERTISE_PEER_URLS=http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2380
2022-01-25 10:21:37.290616 I | pkg/flags: recognized and used environment variable ETCD_INITIAL_CLUSTER=mayastor-etcd-0=http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2380,mayastor-etcd-1=http://mayastor-etcd-1.mayastor-etcd-headless.mayastor.svc.cluster.local:2380,mayastor-etcd-2=http://mayastor-etcd-2.mayastor-etcd-headless.mayastor.svc.cluster.local:2380
2022-01-25 10:21:37.290632 I | pkg/flags: recognized and used environment variable ETCD_INITIAL_CLUSTER_STATE=new
2022-01-25 10:21:37.290640 I | pkg/flags: recognized and used environment variable ETCD_INITIAL_CLUSTER_TOKEN=etcd-cluster-k8s
2022-01-25 10:21:37.290660 I | pkg/flags: recognized and used environment variable ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379
2022-01-25 10:21:37.290673 I | pkg/flags: recognized and used environment variable ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
2022-01-25 10:21:37.290681 I | pkg/flags: recognized and used environment variable ETCD_LOG_LEVEL=info
2022-01-25 10:21:37.290699 I | pkg/flags: recognized and used environment variable ETCD_NAME=mayastor-etcd-0
2022-01-25 10:21:37.290710 I | pkg/flags: recognized and used environment variable ETCD_PEER_AUTO_TLS=false
2022-01-25 10:21:37.290746 W | pkg/flags: unrecognized environment variable ETCD_TRUSTED_CA_FILE=
2022-01-25 10:21:37.290757 W | pkg/flags: unrecognized environment variable ETCD_ON_K8S=yes
2022-01-25 10:21:37.290760 W | pkg/flags: unrecognized environment variable ETCD_SNAPSHOTS_DIR=/snapshots
2022-01-25 10:21:37.290765 W | pkg/flags: unrecognized environment variable ETCD_BIN_DIR=/opt/bitnami/etcd/sbin
2022-01-25 10:21:37.290769 W | pkg/flags: unrecognized environment variable ETCD_VOLUME_DIR=/bitnami/etcd
2022-01-25 10:21:37.290774 W | pkg/flags: unrecognized environment variable ETCD_ROOT_PASSWORD=
2022-01-25 10:21:37.290780 W | pkg/flags: unrecognized environment variable ETCD_CLUSTER_DOMAIN=mayastor-etcd-headless.mayastor.svc.cluster.local
2022-01-25 10:21:37.290783 W | pkg/flags: unrecognized environment variable ETCD_DISASTER_RECOVERY=no
2022-01-25 10:21:37.290787 W | pkg/flags: unrecognized environment variable ETCD_KEY_FILE=
2022-01-25 10:21:37.290792 W | pkg/flags: unrecognized environment variable ETCD_DAEMON_GROUP=etcd
2022-01-25 10:21:37.290795 W | pkg/flags: unrecognized environment variable ETCD_START_FROM_SNAPSHOT=no
2022-01-25 10:21:37.290800 W | pkg/flags: unrecognized environment variable ETCD_INIT_SNAPSHOT_FILENAME=
2022-01-25 10:21:37.290809 W | pkg/flags: unrecognized environment variable ETCD_INIT_SNAPSHOTS_DIR=/init-snapshot
2022-01-25 10:21:37.290815 W | pkg/flags: unrecognized environment variable ETCD_BASE_DIR=/opt/bitnami/etcd
2022-01-25 10:21:37.290822 W | pkg/flags: unrecognized environment variable ETCD_CERT_FILE=
2022-01-25 10:21:37.290828 W | pkg/flags: unrecognized environment variable ETCD_NEW_MEMBERS_ENV_FILE=/bitnami/etcd/data/new_member_envs
2022-01-25 10:21:37.290831 W | pkg/flags: unrecognized environment variable ETCD_DAEMON_USER=etcd
[WARNING] Deprecated '--logger=capnslog' flag is set; use '--logger=zap' flag instead
2022-01-25 10:21:37.290864 I | etcdmain: etcd Version: 3.4.15
2022-01-25 10:21:37.290868 I | etcdmain: Git SHA: aa7126864
2022-01-25 10:21:37.290871 I | etcdmain: Go Version: go1.12.17
2022-01-25 10:21:37.290874 I | etcdmain: Go OS/Arch: linux/amd64
2022-01-25 10:21:37.290878 I | etcdmain: setting maximum number of CPUs to 24, total number of available CPUs is 24
2022-01-25 10:21:37.290924 W | etcdmain: found invalid file/dir member_id under data dir /bitnami/etcd/data (Ignore this if you are upgrading etcd)
2022-01-25 10:21:37.290929 N | etcdmain: the server is already initialized as member before, starting as etcd member...
[WARNING] Deprecated '--logger=capnslog' flag is set; use '--logger=zap' flag instead
2022-01-25 10:21:37.291127 I | embed: name = mayastor-etcd-0
2022-01-25 10:21:37.291133 I | embed: data dir = /bitnami/etcd/data
2022-01-25 10:21:37.291136 I | embed: member dir = /bitnami/etcd/data/member
2022-01-25 10:21:37.291139 I | embed: heartbeat = 100ms
2022-01-25 10:21:37.291142 I | embed: election = 1000ms
2022-01-25 10:21:37.291145 I | embed: snapshot count = 100000
2022-01-25 10:21:37.291151 I | embed: advertise client URLs = http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2379
2022-01-25 10:21:37.291155 I | embed: initial advertise peer URLs = http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2380
2022-01-25 10:21:37.291159 I | embed: initial cluster =
2022-01-25 10:21:37.317423 I | etcdserver: restarting member 482c4e3b4b340c15 in cluster ab0688bf84af917d at commit index 4817
raft2022/01/25 10:21:37 INFO: 482c4e3b4b340c15 switched to configuration voters=()
raft2022/01/25 10:21:37 INFO: 482c4e3b4b340c15 became follower at term 214
raft2022/01/25 10:21:37 INFO: newRaft 482c4e3b4b340c15 [peers: [], term: 214, commit: 4817, applied: 0, lastindex: 4817, lastterm: 214]
2022-01-25 10:21:37.319160 W | auth: simple token is not cryptographically signed
2022-01-25 10:21:37.325944 I | etcdserver: starting server... [version: 3.4.15, cluster version: to_be_decided]
raft2022/01/25 10:21:37 INFO: 482c4e3b4b340c15 switched to configuration voters=(5200617686277819413)
2022-01-25 10:21:37.326348 I | etcdserver/membership: added member 482c4e3b4b340c15 [http://mayastor-etcd-0.mayastor-etcd-headless.mayastor.svc.cluster.local:2380] to cluster ab0688bf84af917d
raft2022/01/25 10:21:37 INFO: 482c4e3b4b340c15 switched to configuration voters=(5200617686277819413<PHONE_NUMBER>874073703)
2022-01-25 10:21:37.326432 I | etcdserver/membership: added member 6b985f3365cade67 [http://mayastor-etcd-1.mayastor-etcd-headless.mayastor.svc.cluster.local:2380] to cluster ab0688bf84af917d
2022-01-25 10:21:37.326447 I | rafthttp: starting peer 6b985f3365cade67...
2022-01-25 10:21:37.326469 I | rafthttp: started HTTP pipelining with peer 6b985f3365cade67
2022-01-25 10:21:37.326727 I | rafthttp: started streaming with peer 6b985f3365cade67 (writer)
2022-01-25 10:21:37.327246 I | rafthttp: started streaming with peer 6b985f3365cade67 (writer)
2022-01-25 10:21:37.327585 I | rafthttp: started peer 6b985f3365cade67
2022-01-25 10:21:37.327632 I | rafthttp: added peer 6b985f3365cade67
2022-01-25 10:21:37.327716 I | rafthttp: started streaming with peer 6b985f3365cade67 (stream Message reader)
2022-01-25 10:21:37.327731 I | rafthttp: started streaming with peer 6b985f3365cade67 (stream MsgApp v2 reader)
raft2022/01/25 10:21:37 INFO: 482c4e3b4b340c15 switched to configuration voters=(5200617686277819413<PHONE_NUMBER>874073703<PHONE_NUMBER>6485202313)
2022-01-25 10:21:37.327877 I | etcdserver/membership: added member 946609bde8186189 [http://mayastor-etcd-2.mayastor-etcd-headless.mayastor.svc.cluster.local:2380] to cluster ab0688bf84af917d
2022-01-25 10:21:37.327927 I | rafthttp: starting peer 946609bde8186189...
2022-01-25 10:21:37.327944 I | rafthttp: started HTTP pipelining with peer 946609bde8186189
2022-01-25 10:21:37.329409 I | embed: listening for peers on [::]:2380
2022-01-25 10:21:37.329495 I | rafthttp: started streaming with peer 946609bde8186189 (writer)
2022-01-25 10:21:37.329583 I | rafthttp: started streaming with peer 946609bde8186189 (writer)
2022-01-25 10:21:37.329696 I | rafthttp: started peer 946609bde8186189
2022-01-25 10:21:37.329704 I | rafthttp: started streaming with peer 946609bde8186189 (stream MsgApp v2 reader)
2022-01-25 10:21:37.329717 I | rafthttp: added peer 946609bde8186189
2022-01-25 10:21:37.329789 I | rafthttp: started streaming with peer 946609bde8186189 (stream Message reader)
2022-01-25 10:21:37.329821 N | etcdserver/membership: set the initial cluster version to 3.0
2022-01-25 10:21:37.329850 I | etcdserver/api: enabled capabilities for version 3.0
2022-01-25 10:21:37.329887 N | etcdserver/membership: updated the cluster version from 3.0 to 3.4
2022-01-25 10:21:37.329910 I | etcdserver/api: enabled capabilities for version 3.4
2022-01-25 10:21:37.330513 E | etcdserver: the member has been permanently removed from the cluster
2022-01-25 10:21:37.330523 I | etcdserver: the data-dir used by this member must be removed.
2022-01-25 10:21:37.330539 E | etcdserver: publish error: etcdserver: request cancelled
2022-01-25 10:21:37.330552 I | etcdserver: aborting publish because server is stopped
2022-01-25 10:21:37.332749 I | rafthttp: stopping peer 6b985f3365cade67...
2022-01-25 10:21:37.332848 I | rafthttp: stopped streaming with peer 6b985f3365cade67 (writer)
2022-01-25 10:21:37.332865 I | rafthttp: stopped streaming with peer 6b985f3365cade67 (writer)
2022-01-25 10:21:37.332889 I | rafthttp: stopped HTTP pipelining with peer 6b985f3365cade67
2022-01-25 10:21:37.332906 I | rafthttp: stopped streaming with peer 6b985f3365cade67 (stream MsgApp v2 reader)
2022-01-25 10:21:37.332917 I | rafthttp: stopped streaming with peer 6b985f3365cade67 (stream Message reader)
2022-01-25 10:21:37.332930 I | rafthttp: stopped peer 6b985f3365cade67
2022-01-25 10:21:37.332936 I | rafthttp: stopping peer 946609bde8186189...
2022-01-25 10:21:37.332950 I | rafthttp: stopped streaming with peer 946609bde8186189 (writer)
2022-01-25 10:21:37.332957 I | rafthttp: stopped streaming with peer 946609bde8186189 (writer)
2022-01-25 10:21:37.332986 I | rafthttp: stopped HTTP pipelining with peer 946609bde8186189
2022-01-25 10:21:37.332999 I | rafthttp: stopped streaming with peer 946609bde8186189 (stream MsgApp v2 reader)
2022-01-25 10:21:37.333008 I | rafthttp: stopped streaming with peer 946609bde8186189 (stream Message reader)
2022-01-25 10:21:37.333018 I | rafthttp: stopped peer 946609bde8186189

Looking at the logs it looks as though the etcd cluster was being updated:
2022-01-25 10:21:37.329821 N | etcdserver/membership: set the initial cluster version to 3.0 2022-01-25 10:21:37.329850 I | etcdserver/api: enabled capabilities for version 3.0 2022-01-25 10:21:37.329887 N | etcdserver/membership: updated the cluster version from 3.0 to 3.4 2022-01-25 10:21:37.329910 I | etcdserver/api: enabled capabilities for version 3.4 2022-01-25 10:21:37.330513 E | etcdserver: the member has been permanently removed from the cluster
Which leads to an issue with the data directory:
2022-01-25 10:21:37.330523 I | etcdserver: the data-dir used by this member must be removed.
Which seems to cause the etcd server to stop:
2022-01-25 10:21:37.330552 I | etcdserver: aborting publish because server is stopped


Update hwameistor/resources/audit

Fixed #5587

see preview:
https://deploy-preview-5590--daocloud-docs.netlify.app/storage/hwameistor/resources/audit


Fix ack message expect response problem

Checklist

[x] have run AriesFrameworkTests
[x] I have run AllTests

Description
Some agents, such as aca-py, wait for a response from it's handler with holding the inbound transport when the transport decorator is received. So, when client sends ack message with transport decorator with return_route attribute, the result is that client get a connection timeout error.

Good catch. Thanks.


Allow the option to run a single Locust through the UI

I would like to be able to choose which Locust to run through the UI. This would make it very easy to support having a large corpus of tests and have the option to only run a single one when it suits the user.
The core of this feature relies on the Locust class's __name__ property. The LocustRunner holds a dict of class.__name__ to class in locust_classes_by_name and provides a method to building that dict and a way of picking one with filter_locusts_by_name.
Right now this only supports running a single Locust or all of them. The web UI has a select that defaults to "All":

And has a list of Locusts to run:

The URL /swarm accepts locust_class in the POST body but defaults it to all. all in this case will be converted to None when passed to the LocustRunner.
Let me know what you think, I'd be happy to make any changes you recommend.

Closing in favor of https://github.com/locustio/locust/pull/695 (a fork from my github rather than my employers)


🚀 - Implement a tuiTextfieldAppearance directive

Which @taiga-ui/* package(s) are relevant/releated to the feature request?
core
Description
There is one in the input-range component, but it's not public and doesn't support neither dynamic changes nor binding. I believe it should be implemented similar to tuiTextfieldSize
I'll open a PR if you okay with that

Sure, go ahead. We were planning to make it public later. However I'm not sure if it's going to be easy to be easy to make it dynamic since it's just a string you get from DI.

Probably you'll need to change type to Observable<string> | string for backward compatibility.

thanks, I'll take it into account


Not Starting

Compiled with latest.CMD windows doesnt goes away.Tried to older verison you mentioned on yesterdays issue.this time it gives MSVCR dll error.i have all c++ dependicies installed.upx is same as latest.
also how can i disable keylogger ?i dont want it.

also keylogger lags the target input.key presses comes 3-4 seconds  behind if keylogger enabled on latest git version.plus /hear command doesnt works.doesnt sends audio file.


Mana Spiral calculations at 64MC

For people who do not have enough spheres from certain High Dragon Trials (cough Jupiter cough) it would be useful to have a setting for Mana Spiral 64MC, which would cap level at 95 and ignore the extra boosts from the last few nodes to ensure the correct calculations for opening blast.

There's only a whole level value (_AddMaxHp1 & _AddMaxAtk1) in the raw chara data.
We might get that info if parse deeply into mana data, but that's too complicated for now.
PR always welcome :)

What do you mean by this? Isn't mana spiral node information publicly available on Gamepedia and the like? Or is there something I'm missing?

Gamepedia data is also parsed from the raw data from game app. That's the effort of multiple volunteers.
We can get whole level mana circle value directly from character's data (only parse one file), but if want single node, I need parse deeply from other files to fit data model.


[Bug] Weird error when ingesting Seurat object

While trying to ingest a Seurat v3 object into a soma, it kept failing due to a dependency function, from what I can tell.
Example:
> write_soma(briggs, "/home/cnawrocki/Documents/grainger-data/briggs_unintegrated_soma")
Error: ArraySchema: Error extending enumeration. Provided enumeration is not an extension of the current state of 'orig.ident'
>

briggs is the Seurat object after the standard workflow.
Versions:

TileDB-SOMA 1.6.2
R 4.3.2
Linux Ubuntu
Intel Core i9

What is interesting is that I have not encountered this issue on my M1 mac. I just got a PC and am running Ubuntu on it, so I am now encountering the issue.
Any help would be much appreciated.

Hi @ccnawrocki -- this is a something we addressed in mid-December after version 1.6.0 came out (and versions 1.6.1 and 1.6.2 contained only Python changes).
How are you installing the TileDB-SOMA package?  Could you try the 1.7.0 release candidates listed at the Releases page  ?


add support for Dell model chassis

We will track all development progress as well as bugs/features during this effort in this issue.

Included support for few Dell server models in https://github.com/Comcast/fishymetrics/pull/80.

#84

https://github.com/Comcast/fishymetrics/pull/86

This is complete. Added support and tested with below PowerEdge models
r640, r6515, r720xd, r730xd, r7515 & r7615.


sim: Restore stack alignemnt

Summary
Reapply the following commit [1], which has been reverted by
the recent change [2] with no obvious reasons.
Also, add a comment block to explain the calculation.
[1]
commit 298c2e5e4fb46f5ffa7de7bbc5a32a9da0663768
Author: YAMAMOTO Takashi<EMAIL_ADDRESS>Date:   Wed Jan 29 03:26:43 2020 +0900

    sim: Fix stack alignment

    The recent x86-64 convention requires 16-byte alignment before
    (not after) calling a function.

    This fixes snprintf crash I observed on macOS while saving XMM registers.

[2]
commit 2335b69120a3e36f1aa0cecc19c95208806cae54
Author: Xiang Xiao<EMAIL_ADDRESS>Date:   Mon Apr 12 23:44:08 2021 +0800

    arch: Allocate the space from the beginning in up_stack_frame

    arch: Allocate the space from the beginning in up_stack_frame

    and modify the affected portion:
    1.Correct the stack dump and check
    2.Allocate tls_info_s by up_stack_frame too
    3.Move the stack fork allocation from arch to sched

    Signed-off-by: Xiang Xiao<EMAIL_ADDRESS>
Impact
Testing
sim:ostest on macOS
(I stopped it in the middle of it because i had no time to run it to the end.
I guess it's enough testing because It was crashing immediately before this change.)

@yamt sorry to remove the subtraction incautiously. The change looks good, thanks again!


How to pass array of callback as argument?

How to pass array of callback as argument?
Desired usage
$callbackSharedData = [];
$callbacks = [];
$callbacks[] = function() {
    echo "sleeping callback";
    sleep(1);
};

$callbacks[] = function() use ($callbackSharedData) {
    $callbackSharedData[] = 'item';
};
example_ext_pass_array_of_callbacks($callbacks);

Rust code
#[php_function]
pub fn example_ext_pass_array_of_callables(data: HashMap<String, ZendCallable>) {
    for (key, call) in data.iter() {
        call.try_call(vec![]).expect("Failed to call function");
    }
}

Fails with:
   Compiling ext-php-rs-example v0.1.0 (/app)
error: implementation of `FromZval` is not general enough
  --> src/lib.rs:24:1
   |
24 | #[php_function]
   | ^^^^^^^^^^^^^^^ implementation of `FromZval` is not general enough
   |
   = note: `FromZval<'0>` would have to be implemented for the type `ext_php_rs::types::ZendCallable<'_>`, for any lifetime `'0`...
   = note: ...but `FromZval<'1>` is actually implemented for the type `ext_php_rs::types::ZendCallable<'1>`, for some specific lifetime `'1`
   = note: this error originates in the attribute macro `php_function` (in Nightly builds, run with -Z macro-backtrace for more info)

error: implementation of `FromZval` is not general enough
  --> src/lib.rs:58:1
   |
58 | #[php_module]
   | ^^^^^^^^^^^^^ implementation of `FromZval` is not general enough
   |
   = note: `FromZval<'0>` would have to be implemented for the type `ext_php_rs::types::ZendCallable<'_>`, for any lifetime `'0`...
   = note: ...but `FromZval<'1>` is actually implemented for the type `ext_php_rs::types::ZendCallable<'1>`, for some specific lifetime `'1`
   = note: this error originates in the attribute macro `php_module` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `ext-php-rs-example` due to 2 previous errors

So I have tried lifetimes like this:
#[php_function]
pub fn example_ext_pass_array_of_callables<'a>(data: HashMap<String, ZendCallable<'a>>) {
    for (key, call) in data.iter() {
        call.try_call(vec![]).expect("Failed to call function");
    }
}

Fails with:
   Compiling ext-php-rs-example v0.1.0 (/app)
error[E0261]: use of undeclared lifetime name `'a`
  --> src/lib.rs:24:1
   |
24 | #[php_function]
   | ^^^^^^^^^^^^^^^- lifetime `'a` is missing in item created through this procedural macro
   | |
   | undeclared lifetime
   |
   = note: this error originates in the attribute macro `php_function` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0261]: use of undeclared lifetime name `'a`
  --> src/lib.rs:58:1
   |
58 | #[php_module]
   | ^^^^^^^^^^^^^- lifetime `'a` is missing in item created through this procedural macro
   | |
   | undeclared lifetime
   |
   = note: this error originates in the attribute macro `php_module` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0261`.
error: could not compile `ext-php-rs-example` due to 2 previous errors

Any ideas?
Is this even possible?
Thanks :pray:

I changed some lifetimes in 16c456de7dd7db0b763853a538d433fd7fc0bb62, can you please try again with latest master branch? Change your Cargo.toml to ext-php-rs = { git = "https://github.com/davidcole1340/ext-php-rs" }.

Thanks for response, will try ASAP.

@davidcole1340 it works!
rust code:
#[php_function]
pub fn example_ext_pass_array_of_callbacks(data: HashMap<String, ZendCallable>) {
    for (key, call) in data.iter() {
        call.try_call(vec![]).expect("Failed to call function");
    }
}

PHP code:

$callbackSharedData = [];
$callbacks = [];
$callbacks[] = function() use (&$callbackSharedData) {
    echo "sleeping callback 1s" . \PHP_EOL;
    $callbackSharedData['2s'] = '1s value';
    sleep(1);
};
$callbacks[] = function() use (&$callbackSharedData) {
    echo "sleeping callback 2s" . \PHP_EOL;
    $callbackSharedData['2s'] = '2s value';
    sleep(2);
};
$callbacks[] = function() use (&$callbackSharedData) {
    $callbackSharedData['some'] = 'some value';
};
example_ext_pass_array_of_callbacks($callbacks);
var_dump($callbackSharedData);

Next level will be trying par_iter :D


fix: update hasNotch method reference to getModel

Fix "_this.getModel is not a function"
Description
Fixed issue #703
Compatibility

OS
Implemented

iOS
✅

Android
✅

Windows
✅

Checklist

[X] I have tested this on a device/simulator for each compatible OS
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typings files (deviceinfo.d.ts, deviceinfo.js.flow)
[ ] I updated the dummy web/test polyfill (default/index.js)
[ ] I added a sample use of the API (example/App.js)

Hmm - I don't understand.
Please explain why it works in the example, as is: https://github.com/react-native-community/react-native-device-info/blob/master/example/App.js#L61
I just tested it, fresh checkout of current master (which is equivalent to version 2.1.3 as of now), cd example && \rm -fr node_modules && npm i && react-native run-ios and separate Terminal  react-native run-android.
Can't reproduce? It works fine for me.
Closing provisionally, but I'm interested


Include external file (node_modules) in library-preload

Hi, I'm trying to include external files from my node_modules to build the library-preload.js
My actual Gruntfile.js is like this:
module.exports = function(grunt) {

	grunt.initConfig({

		dir: {
			src: 'src',
			src_thirdparty: 'node_modules/qrcode-generator',
			dest: 'dist',
		},

		copy: {

		},

		clean: {
			dist: '<%= dir.dest %>/**'
		},

		openui5_preload: {
			library: {
				options: {
					resources: [
						{
							cwd: '<%= dir.src_thirdparty %>',
							src: '**/qrcode.js'
						},
						'<%= dir.src %>'
					],
					dest: '<%= dir.dest %>',
					compatVersion: '1.44',
					compress: false
				},
				libraries: 'it/designfuture/qrcode'
			}
		}
	});

	// These publins provide necessary tasks
	grunt.loadNpmTasks('grunt-contrib-clean');
	grunt.loadNpmTasks('grunt-contrib-copy');
	grunt.loadNpmTasks('grunt-openui5');

	// Build task
	grunt.registerTask('build', ['openui5_preload']);

	// Default task
	grunt.registerTask('default', ['clean', 'build']);

};

it get aborted with this error:

Warning: No "library.js" found for pattern "it/designfuture/qrcode"! Use --force to continue.

Is there a way to do what I want to achieve?

You should be able to provide a resources configuration which maps the script in node_modules/qrcode-generator/qrcode.js to the namespace of your library:  it/designfuture/qrcode/3rdparty, like this:
openui5_preload: {
	library: {
		options: {
			resources: [
				{ cwd: '<%= dir.src %>' },
				{
					cwd: 'node_modules/qrcode-generator',
					src: 'qrcode.js',
					prefix: 'it/designfuture/qrcode/3rdparty'
				}
			],
			dest: '<%= dir.dest %>',
			compatVersion: '1.44',
			compress: false
		},
		libraries: 'it/designfuture/qrcode'
	}
}

This will include the script into your library-preload.js, as from the namespace (it/designfuture/qrcode/3rdparty/qrcode.js) it is part of it, although it's physically at a different location on your hard drive (node_modules/qrcode-generator/qrcode.js).
In your code you can load that script like any other module, by providing the namespace of it (it/designfuture/qrcode/3rdparty/qrcode). Note that currently the return value of such thirdparty module is not available in the sap.ui.define/require callback, so you need to use the global variables defined by the thirdparty scripts. In your case it would be qrcode.
Hope this helps 👍

@matz3 I solved the issue, thank you very much for your help. You can checkout the updated repo: https://github.com/StErMi/openui5-qrcode
Now as I said I've to solve other issue:

Add support to openui5_connect
Find a good way to have the same codebase to develop and build (actually I cannot test the code without building it first)
Find a way to generate -dbg version of the lib as referenced in this issue #44

@StErMi I guess this can be closed, as you switch to the UI5 Tooling.


Add checker framework nullness checker to core package.

Adding a nullness checker makes it mostly impossible for our code to throw NPE, except for some occasional suppressions. That still doesn't mean it can't ever crash based on how an app calls the functions, but it's a good check either way.
While going through all the checks, I added some general cleanups as well, most of them are IntelliJ's automatic cleanups like marking final variables as final. Also made some private constants immutable and changed a lot of null != foo to foo != null.
Vast majority is adding annotations, but there are a few places where a missing null check was added, mostly exceptional branches.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Updated to latest mockito in all projects and it works ok now. Would be nice to get in relatively soon due to the large drift surface :)


schema-registry - Templating for liveness/readiness probes

What this PR does / why we need it:
Exposes liveness and readiness probes parameters for configuration
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No
Special notes for your reviewer:
https://github.com/kubernetes/charts/pull/6220

/ok-to-test

/retest

/lgtm


pbmerge or some other way of creating a consolidated ccs report

Operating system
Which operating system and version are you using?
Package name
Which package / tool is causing the problem? Which version are you using, use tool --version. Have you updated to the latest version conda update package? Have you updated the complete env by running conda update --all? Have you ensured that your channel priorities are set up according to the bioconda recommendations at https://bioconda.github.io/#set-up-channels?
Conda environment
What is the result of conda list? (Try to paste that between triple backticks.)
Describe the bug
A clear and concise description of what the bug is.
Error message
Paste the error message / stack.
To Reproduce
Steps to reproduce the behavior. Providing a minimal test dataset on which we can reproduce the behavior will generally lead to quicker turnaround time!
Expected behavior
A clear and concise description of what you expected to happen.

Can you at least provide what you are looking for?

Hi there -- so sorry -- I think I put this out before I finished my thought.   I do the multi-threaded and I get everything in a single ccs_report -- if you chunk it you get as many chunks in the report -- now (and congratulations!) maybe it doesn't matter so much... you simply keep making it faster and faster.   But it is just the idea to have the ability to put everything back together after separating things out to permit in parallel consensus finding..... Does this make sense now?

Oh it does, question is, do we need official support for that or can you write a 20 line python/bash script do merge them on your own. The thing is, would we provide a new tool for that? Should it be part of ccs? Or would it be a simple script that we would put on the ccs github page? What is your opinion as an user?

Upcoming CCS version allows to store the ccs_reports as an additional json file. From there, it will be very easy to merge with any programming language supporting json.


Works with self signed but does not work with internal CA

Description
I ve set all up in my local machine with a self signed certificate, then I set it up in my corporate rserver with a self signed certificate, it worked again. Then I changed the certificate to a new certificate signed from our internal CA, now I can connect to Portus, and I can login in the registry, but I get SSLError when linking portus to the registry.
Steps to reproduce

Set FCDN and nginx (I used an URL that is correctly resolved on our internal DNS)
Copy all certidicates to /etc/docker/cert.d/{server url}:5000 ( rootCA.crt, intemediateCA.crt, and portus.crt)
docker-compose up
go to {server url} on the browser (from my local machine) shows as secure
create admin
set hostname to {server url}:5000
7.1. Browser :
OpenSSL::SSL::SSLError: could not stablish connection: SSL error You can skip this check by clicking on the "Skip remote checks" checkbox.
7.2 Terminal logs:

registry_1_5868aac66eee | 2018/12/06 15:41:49 http: TLS handshake error from <IP_ADDRESS>:54660: remote error: tls: unknown certificate authority
portus_1_514c193677b4 | OpenSSL::SSL::SSLError: could not stablish connection: SSL error

Expected behavior: I expected portus to conect with registry like with a self signed certificate
Actual behavior: OpenSSL::SSL::SSLError

Deployment information
I have a an ofline rootCA that signs 2 IntermediateCAs that are online, all this certificates are on the server both on the os and docker cert.d folder. I need this certificate to work otherwise I will not be able to get images from the registry on the production environment.

Ok, I fixed this by adding the certificates to the secrets folder, this should be updated int the documentation.

Hi - could you pls share your config for TLS (self signed certs are fine for now) - your docker-compose.yml, the registry/config.yml, registry/init and did you only create portus.crt and portus.key as given in the examples/compose/README.md file??
Help is much appreciated.
Thanks,
lakshmi

I am currently getting the error as
I am having similar problem when I run with SSL (self signed)
registry_1_936961e5bfcc | 2019/05/16 14:36:14 http: TLS handshake error from <IP_ADDRESS>:35312: remote error: tls: internal error
portus_1_c0ae2b982fd8 | OpenSSL::SSL::SSLError: could not stablish connection: SSL error
I am using the steps from the README.md file examples/compose

when I go to the server URL, I am able to get the login screen and I add the admin user name.
The problem happens when I try to add the registry.
Its not accepting registry:5000 or reg01.abc.com:5000
It says openssl could not establish connection

If you have a DNS server add a hostentry to the resolv.conf, else edit your docker-compose.yml by adding host entries like,
extra_hosts:
- "reg01.abc.com:"


add Data.Align.Text

Add 'text' dependency
Add 'CHANGELOG.md'
Moved common types to Data.Align.Types
Add type signatures in Data.Align.Demo
Small cosmetic refactorings in Data.Align
bump package version to 0.2

Now I'm not even too sure about duplicating align, since the only differences in the implementations are the implementations of index and length. Perhaps using a typeclass with instances for Vector, String and Text would be better?

Is the duplication driven by an actual performance need? If not, can as well keep the listy module only, and convert at callsite.
Otherwise, doing benchmarks on the real problem (against the simply-wrapping) with criterion indeed sounds good.
Not sure about the typeclass. A bit hackier, but an often employed trick (see containers IIRC) is to have a header file contain the code (with some macro placeholders), and include it with CPP from the various implementations.
Personally I never liked the trick, but the typeclass move is something to be made only if benchmark data verifies its positive effect (passing around dictionaries and whatnot).


Add sensu check for rubygems ssl cerificate verification

Name I have used for sensu_check is valid:

Validated with Ruby regex /^[\w.-]+$/.match("check-name")

Test is copied from: https://github.com/rubygems/rubygems/blob/9b1c9584ea5d9299ec28aa669de1218540a2210d/test/rubygems/test_bundled_ca.rb

Updated (still needs path to rubygems).

I've rolled this out to the server 👍


Add cmd-W cmd-Q esc to Close the Preference Window

Add cmd-W or/and cmd-Q or/and esc to close the Preference window.

Makes sense! I've implemented this small but useful change 👍


Update documentation, make groups mandatory.

With this, LB exposure becomes 'opt-in', rather than on-always (as with
the current implementation). To opt in to LB exposure, add a label to
the app definition to specify the LB.
For example, if you start one LB with --group external, and another with
--group internal, all apps which have the following label would be
exposed on both:
{
  "labels":{
    "HAPROXY_GROUP":"external,internal"
  }
}

cc @discordianfish

Actually, I see now how the groups feature works. I'll simply change it to be opt-in by default.

Am I right, that I need to put the groups label into every app now?
Until now, everything works just out of the box.
This change forces us to specify a artificial group into every marathon.json.

Add --group * to your LB config if you want the old behaviour.

@brndnmtthws lets say I have two Marathon LBs with --group internal and --group external.
Within a Marathon app.json, what does HAPROXY_{n}_STICKY refers to ?
If you wanted to have the Haproxy stickiness bits for the external LB, would you need to specify the label as HAPROXY_external_STICKY ?

Good question! the {n} refers to the service port index, starting from 0. It's not properly documented, so I'll update the docs accordingly.

Oh boy, now it makes way more sense. Thanks @brndnmtthws !


[Feature Request]: using tuned vertex models

Feature Description
Feature Description
i first tried several 'model' name options for my tuned (gemini base with vertex) model using the Vertex class. the name, id, and long name/URL (        'model': f'projects/{project}/locations/{location}/models/{id}@{version}') all gave me 'model not found' errors despite things like credentials and model identifiers working/checked
i read further and the source shows tuned/custom names will error
unless i'm missing something here, it'd be great to be able to provide the custom model name
Reason
No response
Value of Feature
No response
Reason
No response
Value of Feature
No response

probably we need something like this, but for LLMs
https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/embeddings/llama-index-embeddings-vertex-endpoint/llama_index/embeddings/vertex_endpoint/base.py
Feel free to make a PR!


Performance and possibility to split only on subset of features

Hey, I have been playing around a lot with your linear trees. Like them very much. Thanks!
Nevertheless, I am somewhat disappointed by the runtime performance. Compared to XGBoost Regressors (I know it's not a fair comparison) or linear regressions (also not fair), the linear tree is reeeeeaally slow.
50k observations, 80 features: 2s for linear regression, 27s for XGBoost, and 300s for the linear tree.
Have you seen similar runtimes or might I be using it wrong?
Another aspects that's interesting to me is the question whether is possibe to limit the features which are used for splits. I haven't found it in the code. Any change to see it in the future?

Hi, thanks for your feedback!
The computation time is higher for sure comparing it with singular linear regression or decision tree (from sklearn) due to the increase of operations complexity. For sure I don't expect it is faster than XGB or LGB lineartrees (considering only 1 tree) due to a very different implementation. To reduce the training time you can consider reducing the max_depth, max_bins, or the expected samples in the leaves.
At the moment I don't plan to introduce this feature... I'm focusing on developing a special linear boosting.
All the best

Thanks for the info.


add all deployed networks and maintainers in core/readme

Description
Re-add lost maintainers & address contracts on all networks during repo migrations.
Summary of changes
Add contracts address on all networks and maintainers
How test the changes
Check contracts on all explorers

I've also added @hrik2001 avalanche deployment related to https://github.com/humanprotocol/human-protocol/pull/158

We already have a file containing contract addresses https://github.com/humanprotocol/human-protocol/blob/main/CONTRACTS_LIST.md
Can you check and combine your file into this?

@foufrix we already have a file containing contract addresses https://github.com/humanprotocol/human-protocol/blob/main/CONTRACTS_LIST.md Can you check and combine your file into this?

@portuu3  ok will double check, where do you want to track name and github profile of maintainers now?

@foufrix we already have a file containing contract addresses https://github.com/humanprotocol/human-protocol/blob/main/CONTRACTS_LIST.md Can you check and combine your file into this?

@portuu3 ok will double check, where do you want to track name and github profile of maintainers now?

I think I would use a file CONTRIBUTORS.md in the root folder, so you dont need search inside folders to find it

Hi @portuu3, I've made the changes you requested.
I added all KVstore that are already deployed and were not ported to this file.
I updated the HMT address on Mumbai. It was not the good one (inexistent, was a copy of the moonbeam address) here is the good one


Button to increase brightness for QR certificate tab

When presenting a QR code to be scanned (e.g. during entrance control), the screen brightness might be insufficient and has to be increased for the scan to succeed.
Current Implementation
The user has to increase screen brightness from the OS settings. In #4606 an improvement was suggested and meanwhile implemented, which increases the screen brightness when the QR code is shown in full screen. While being an improvement, this requires several steps which are not quite intuitive for the user.
Suggested Enhancement
To further improve this, I propose to add a toggle action item to the toolbar in the certificates tab (as in the screenshot below) for this purpose. This will allow to quickly increase the screen brightness with only a single tap if required.
Screenshot

Expected Benefits
This has several advantages:

Intuitive to the user
Fast, speeds up the scanning process (which is especially important to reduce queuing at entrance controls)
Not disturbing, since it's not enabled by default

Also, there is enough space available.

If you want, I'd volunteer to propose an implementation and submit a PR on the matter. Please let me know for which base branche. See https://github.com/eltos/cwa-app-android/commit/e4782375ef21f55761061e95df08531f3c0005db
I am opening this as a dedicated issue as suggested in https://github.com/corona-warn-app/cwa-app-android/issues/4606#issuecomment-1068933202

Thanks for your enhancement request @eltos. We have created an internal ticket for it and will raise this topic internally.
Internal Tracking ID: EXPOSUREAPP-12360

Corona-Warn-App Open Source Team


allow use of default theme

Nice one! thanks @miguelcobain

Can you publish 0.0.4 with this change?

Ya totally.

Did it.


How to set cookies for vast?

how do we use cookies to disable Ads for 5 minutes if it was skipped
fluidPlayer(
   'my-video',
    {
    vastOptions: {
        vastAdvanced: {

            vastLoadedCallback:       (

                function getCookie() {
                    var name = cname + "=";
                     var decodedCookie = decodeURIComponent(document.cookie);
                     var ca = decodedCookie.split(';');
                     for(var i = 0; i <ca.length; i++) {
                         var c = ca[i];
                         while (c.charAt(0) == ' ') {
                             c = c.substring(1);
                          }
                          if (get the cookie value, if it's "1") {
                          **### how to disable the ad for 5 minutes if document.cookie vast = 1**
                           }
                      }
                      return "";
                      }
                     ),

            vastVideoSkippedCallback: (function() { document.cookie = "vast=1" }),
        }
    }
}
);

Hi. This does not seem to work for some reason. Any update 2.5 year later maybe?


Librato Sink

I'm interested in adding a sink for Librato Metrics but didn't want to jump the gun and start committing too soon.
Is it safe to start working on this, and do you agree this fits as a sink?
Thanks!

Closing this issue. No further action required.


check ol3-cesium integration

check if ol3-cesium http://openlayers.org/ol3-cesium/ can be integrated

seems to be worth adding; perhaps after adding BingMaps for Aerial imagery in combination with height maps in cesium

cannot be done, as Cesium uses WebGL and WebView from JavaFX has no WebGL implementation.


aws-c-common: 0.8.23 -> 0.9.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/aws-c-common/versions.
meta.description for aws-c-common is: AWS SDK for C common core
meta.homepage for aws-c-common is: https://github.com/awslabs/aws-c-common
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.9.9 in filename of file in /nix/store/1w86gsa5a27vcxv068gdb4xz96v02xrw-aws-c-common-0.9.9

Rebuild report (if merged into master) (click to expand)

862 total rebuild path(s)

862 package rebuild(s)

First fifty rebuilds by attrpath
activitywatch
adafruit-nrfutil
akkoma-frontends.admin-fe
akkoma-frontends.akkoma-fe
ansible-language-server
antennas
antora
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
appvm
ariang
arrow-cpp
arrow-glib
arrpc
assemblyscript
audiobookshelf
authelia
authy
aw-server-rust
aws-azure-login
aws-c-auth
aws-c-cal
aws-c-common
aws-c-compression
aws-c-event-stream
aws-c-http
aws-c-io
aws-c-mqtt
aws-c-s3
aws-c-sdkutils
aws-checksums
aws-crt-cpp
aws-sdk-cpp
balanceofsatoshis
balena-cli
behave
bibtex-tidy
bilibili
bitwarden
bitwarden-cli
blockbench-electron
botamusique
browsr
btc-rpc-explorer
bundix
cabal2nix
cached-nix-shell
cachix
camunda-modeler
carbon-now-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1w86gsa5a27vcxv068gdb4xz96v02xrw-aws-c-common-0.9.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-c-common https://github.com/r-ryantm/nixpkgs/archive/018947a33ecba981a312f0312566b6614730191f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/018947a33ecba981a312f0312566b6614730191f#aws-c-common

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1w86gsa5a27vcxv068gdb4xz96v02xrw-aws-c-common-0.9.9
ls -la /nix/store/1w86gsa5a27vcxv068gdb4xz96v02xrw-aws-c-common-0.9.9/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @orivej @edolstra @r-burns for testing.

Already on staging-next.


SunEditor: Setting allowMedia="false" will break images

Describe the bug
When you copy images to the SunEditor they are put into a parent
 tag.

If you set the attribute allowMedia to false on the component, this parent figure tag will be sanitized by the HtmlSanitizer and when you render the editor with a sanitized version of the html code it will throw the following Javascript error because of the missing figure tag.
Uncaught TypeError: Cannot read properties of null (reading 'style')
    at Object.cancelPercentAttr (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:66292)
    at Object.setSize (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:64258)
    at Object.resetTransform (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:446230)
    at Object.setAutoSize (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:64672)
    at Object.applySize (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:63881)
    at Object.setInfo (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:454822)
    at Object.checkInfo (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:453001)
    at Object.checkFileInfo (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:57154)
    at Object._checkComponents (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:367506)
    at Object._editorInit (suneditor.js.xhtml?ln=primefaces-extensions&v=13.0.10&e=13.0.14:3755:379844)

Current HtmlSanitizer definitions.
private static final PolicyFactory HTML_IMAGES_SANITIZER = new HtmlPolicyBuilder()
            .allowUrlProtocols("data", "http", "https")
            .allowElements("img")
            .allowAttributes("src")
            .matching(Pattern.compile("^(data:image/(gif|png|jpeg|webp|svg)[,;]|http|https|mailto|//).+", Pattern.CASE_INSENSITIVE))
            .onElements("img")
            .allowAttributes(
                        "data-rotate",
                        "data-proportion",
                        "data-rotatex",
                        "data-rotatey",
                        "data-size",
                        "data-align",
                        "data-percentage",
                        "data-index",
                        "data-file-name",
                        "data-file-size",
                        "data-origin")
            .onElements("img")
            .toFactory();

private static final PolicyFactory HTML_MEDIA_SANITIZER = new HtmlPolicyBuilder()
	            .allowUrlProtocols("data", "http", "https")
	            .allowElements("video", "audio", "source", "iframe", "figure")
	            .allowAttributes("controls", "width", "height", "origin-size", "src", "allowfullscreen", "class", "style", "data-proportion", "data-align",
	                        "data-percentage", " data-size", "data-file-name", "data-file-size", "data-origin", "data-rotate", "data-index")
	            .onElements("video", "audio", "source", "iframe", "figure")
	            .toFactory();

Reproducer
No response
Expected behavior
HtmlSanitizer should be adapted that allowMedia and allowImages are not dependant on each other.
I guess the HTML_IMAGES_SANITIZER should allow the figure element and styleattribute but I'm unsure if other attributes are required in different constellations.
PrimeFaces Extensions version
13.0.14
JSF implementation
Mojarra
JSF version
2.3
Browser(s)
No response

Can you review my PR i allow style and id on figure and img in the Allow Images

Will there be a another 13.0.x release or only 14 and 15?


LicensePanel Encoding Issue

https://stackoverflow.com/questions/14403881/izpack-how-to-show-utf-8-license-with-licensepanel

Can you please create a short JIRA issue which describes the problem?

Sure!
https://izpack.atlassian.net/browse/IZPACK-1575

Thanks and sorry for this formality - better for creating a unique changelog :-)


Test failure on Chrome 62

Chrome 62.0.3202 (Windows 10 0.0.0) HTML should prevent mXSS attacks FAILED

       Expected 'CLICKME' to be 'CLICKME'.

           at Object.<anonymous> (test/ngSanitize/sanitizeSpec.js:242:71)
```

This isn't picked up by Travis CI because SauceLabs does not currently offer Chrome v62

I think I remember why I didn't mark this as security: the string is not actually executed as javascript because of the leading IDEOGRAPHIC SPACE (　).
So I'm not actually sure what this is testing. Also note that this test runs only in Chrome. Maybe C62 is now aligned with other browsers and doesn't need special treatment? The commit is unfortunately very light on this mxss stuff.

Created a fix here: https://github.com/angular/angular.js/pull/16311
It won't be tested via Travis (and SauceLabs) though, sadly.

The fact that those tests are run in Chrome only means we wouldn't catch similar regressions in other browsers, that sounds bad. Can we enable it everywhere?

I have enabled that test across the board now.


Moves "manifests" into the index package.

Removes index.Snapshot
Creates index.IndexRef that is responsible for index metadata.

TODO:

Tests on index resurrection.
Tests on index removal.

This just better encapsulates the notion of manifests within the Index, instead of the searcher. I realized this was way cleaner when I landed that last PR. Now I'm going to focus on getting the various VCS additions landed.

Looks good @kellegous, and I like that we are starting to have tests. At some point we should probably add TravisCI - it's free for open source projects.

Oh good idea. I should have set that up earlier. We do have a number of tests buried in the index code.


[FormBuilder] Should Form.render render a form-tag?

Maybe I am not using the Formbuilder correctly, but when rendering the view with Form.render the rendered html is:
<div class="thoth-form">
   ...
</div>

I expected it to have a <form>-tag?
As far as I can tell the form-tag is required for example to get Chrome to validate an email-input in the browser. So to get that to work I have to add the form tag manually:
form [] [ Form.render myProps ]

Am I missing something or do I need to add the form-tag manually?
If this is the case maybe it could be reflected in the demos/documentation?

This is expected because a form tag will have some default behavior. For example, if you have a submit button in it, will send itself. So you will have to listen to OnSubmit and cancel the event etc.
You can wrap it in a form tag if you want this behavior.

Thanks for the explanation, that makes sense. I mostly do backend development, so I was guessing there was a reason for this behaviour. :)


Docker task - is Managed Identity supported?

I'm using MI service connection to Azure, Docker v0 task and faced with some issues during the docker push execution. Briefly checked source code of Docker v0 task and haven't understood whether MI supported or not (not sharing my findings, I'm not a prof. developer..waiting for your response instead)

Managed Identity based service connection is not supported in Docker task. The service connection needs to be based on service principal to work with Docker task.

@ajinkya599 thanks. So, I understood the code correctly :) and already switched to SP


Fix/lint

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Added or updated unit tests for my change.

not only fixed linting but also the pipeline.