Fix major typo: It is "UpdateServices", not "WSUS"

The documentation has a major typo repeated all over: The name of the module in Windows 10 and Windows Server 2016 containing the WSUS cmdlets is mistakenly written as "WSUS". The correct module name is "UpdateServices".
I am attaching screenshots that prove my point. These screenshots are taken from Windows 10, Windows Server 2016 and Windows Server 2019. As you can see, the Get-Module cmdlet is invoked on them to look for installed modules called "WSUS" and "UpdateServices". Get-Module does not find any modules named "WSUS", but the UpdateServices is always available. The last screenshot also shows all exported cmdlets of the UpdateServices module, showing that indeed all sixteen involved cmdlets are there.
Please feel free to test this yourself.

In this pull request, I have tried to fix the typo by:

Renaming the folder containing the pertinent 17 files.
Renaming WSUS.md to UpdateServices.md
Editing the content and front matter of UpdateServices.md.

I hope I haven't missed anything.

Docs Build status updates of commit f40c3ed:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/updateservices/Add-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Approve-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Deny-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusServer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Invoke-WsusServerCleanup.md
:white_check_mark:Succeeded

docset/windows/updateservices/Remove-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusServerSynchronization.md
:white_check_mark:Succeeded

docset/windows/updateservices/UpdateServices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Docs Build status updates of commit 3fb3114:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/updateservices/Add-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Approve-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Deny-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusServer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Invoke-WsusServerCleanup.md
:white_check_mark:Succeeded

docset/windows/updateservices/Remove-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusServerSynchronization.md
:white_check_mark:Succeeded

docset/windows/updateservices/UpdateServices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Huh? So, I propose renaming a group of files, and you propose proofreading their contents? Not that proofreading is anything bad, but I think these two could be performed independent of each other.

@traya1 (PubOps) Would you be able to advise concerning changing folder vs module names? Is it favorable in the face of possible side effects? Thanks.

@skycommand The PR is under investigation. Would you re-target the PR branch to master in the meantime? Thank you.

@e0i Done.

@skycommand - thank you for the detailed PR and screenshots and the work you have done on this. Your contribution and passion is very much appreciated. @get-itips shared a related issue here: https://github.com/MicrosoftDocs/windows-powershell-docs/issues/133
I have no doubt that you and everyone in this thread knows way more than me so bear with me as we get this figured out.
We will also need to add redirects so that the old paths continue to work for blog articles and other references to the cmdlets. I believe we tried this before and ran into problems with getting it to work but let's try again. Below is guidance I found on the redirects and we will try it.
How to redirect obsolete articles
To avoid broken links, you must redirect files that are removed, renamed, or moved to a new location. You can redirect by using a master redirect file in the repo, or by requesting site-level redirection.
Master redirect file
You should manage redirects in a single file at the root of your repo, .openpublishing.redirection.json. Using a single file makes it easier to track which files have been redirected, and lets you remove the redirected files from the repo.
To add a redirect to .openpublishing.redirection.json, add an entry to the redirections array:
{
    "redirections": [
        {
            "source_path": "openpublishing/docs/partnerdocs/index.md",
            "redirect_url": "/opsdocs/partnerdocs/VSTSgit-github",
            "redirect_document_id": true
        },

The source_path is the relative link to the file you want to redirect.
The redirect_url is the link to the target page. redirect_url can be a relative link to another file in the same docset, an absolute link to another article on docs.microsoft.com, or a URL to any web page.
redirect_document_id indicates whether you would like to keep the document ID from the previous file. The default is false. Use true if you want to preserve the ms.documentid attribute value from the redirected article. If you preserve the document ID, data, such as page views and rankings, will be transferred to the target article.

[!IMPORTANT]
Using this method, you can only preserve the document ID if the target file is in the same docset as the redirected file. If you redirect multiple files to the same target file, you can only set redirect_document_id to true for one of them. If you are moving existing articles from one repository to another repository, you need to file a ticket with the OPS development team - they can assist with a programmatic solution that allows you to preserve the document ID.

After you've redirected a file via the master redirect file, you must remove the original file from the repo. Otherwise, you'll get a build warning:
[Warning] 'path-to-file.md' would be overwritten by redirection rule configured in master redirection file .openpublishing.redirection.json. Please remove the original file to resolve this warning.
For interactive tutorials and Microsoft Learn content, you can redirect from the index.yml file by substituting index.md in the master redirection file.
How to generate a master redirect file based on file-level redirects
Before master redirect files were supported, we had to redirect files individually by adding the redirect_url and redirect_document_id (optional) metadata to the YML header of the Markdown file:
---
redirect_url: https://marketplace.visualstudio.com/items?itemName=docsmsft.docs-authoring-pack
redirect_document_id: false
title: Gauntlet VS Code extension
author: meganbradley
ms.author: mbradley
ms.date: 05/18/2018
ms.topic: contributor-guide
---

This approach is no longer recommended. If you have a repo that still uses file-level redirection, you can clean it up by using the Docs Markdown VS Code extension functionality to generate a master redirect file and remove the obsolete files from the repo.

Install the Docs Markdown VS Code extension, either individually or as part of the Docs Authoring Pack.
Open your cloned repo and make sure it's up-to-date.
Hit F1 to open the VS Code command palette.
Start typing "Docs: Generate master redirect file" until you see the command, then select it.
The master redirection script will run on the repo. For each Markdown file it finds with the redirect_url attribute, it will:

Add an entry for the file to .openpublishing.redirection.json. The path of the file becomes the value of source_path. The value of redirect_url in the master redirect file is the same as in the source file.
If you included the redirect_document_id attribute in your Markdown file with the value true, it will add this to the master redirect file. Otherwise, it will default to redirect_document_id equals false.
Move the redirected file to a folder under your default path, such as C:\Users\your-alias\Docs Authoring\Redirects\repo-name_deleted_redirects_date-and-time.

When the script completes, check the deleted redirects folder to make sure the files were removed as expected.
If so, submit a PR to update the repo.

You can run the script multiple times if new file-level redirects creep into the repo.
After a few runs of the script, your Redirects folder might look something like this:

Site-level redirection
Site-Level redirection works for large content sets to move in bulk, but is only available for certain scenarios.  If your redirection meets these requirements, you can request bulk redirection:
Site-level redirection requirements

Must be an MSDN and MTPS to Docs redirection scenario.
The docsets must have different Base Path values displayed in the Open Publishing Portal.
Must be a custom redirection scenario that isn't achievable in a master redirection file.

If your request meets these requirements, please file a site-Level redirection request by following these steps:

Go to https://sitehelp.microsoft.com.
Click Submit request or issue.
Select Redirections for the service, then the appropriate service category.
Follow the instructions provided.

Hello, @kenwith. 😊 That was a lot to digest but I think I've got a hang of it. Thanks for spending the time writing it.
Now, if you have a minute to spare, let's start from the top and take a look at what needs to be done together.
First, to create a redirection, I need to source URL, right? Well, here is our big problem: Of all the 17 files in my PR, none of them have their "online version" field of their front matters. UpdateServices.md, formerly WSUS.md, has a URL in somewhere else in its front matter. The URL is http://go.microsoft.com/fwlink/?linkid=390839 If you click on it, you get a 404 error.
To further test this, I did the following:

Installed "RSAT: Windows Server Update Services Tools" on my home computer
Restarted the computer
Verified that the UpdateServices module is truly installed
Updated PowerShell's help via Update-Help
Run the following script: Get-Command -Module UpdateServices | ForEach-Object {Get-Help $_.Name -Online -Verbose}

Here is the result:
VERBOSE: Help URI: http://go.microsoft.com/fwlink/?LinkId=786992
VERBOSE: Help URI: http://go.microsoft.com/fwlink/?LinkId=786996
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287825
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287826
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287827
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287828
VERBOSE: Help URI: http://go.microsoft.com/fwlink/?LinkId=789378
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287829
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287830
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287831
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287832
VERBOSE: Help URI: http://go.microsoft.com/fwlink/?LinkId=789379
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287833
VERBOSE: Help URI: http://go.microsoft.com/fwlink/?LinkId=789380
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287834
VERBOSE: Help URI: http://go.microsoft.com/fwlink/p/?linkid=287835

We can probably add these links back into the .md files, but should we? First, who removed them and why? Second, as @sdwheeler mentioned in #4553, fwlink links can only be edited by a Microsoft internal tool.
At this point, I don't know how to proceed.

@kenwith The redirection instructions you provided are for redirecting renamed or deleted documents in our website. That does not apply to the links that @skycommand is referring to.
@skycommand we could update the frontmatter in the MD files to include these links but those changes would not show up via Update-Help because there is not build pipeline to create new Help CAB files for download. This is a know issue that the docs team is working on with the PowerShell team, but we are months away from any real solution.
The best we can do at this point is to fix the frontmatter so that it will publish correctly when we fix the build pipeline. With the fixed frontmatter, you could also do a local build as I described in my blog post: https://devblogs.microsoft.com/powershell/updating-help-for-older-versions-of-powershell/
I can possibly help with the FWLinks. Can you provide a list of which link is supposed to be for which cmdlet? I will also investigate the same on my end.

@sdwheeler thanks Sean!
@get-itips  and @dariomws306 can help too. I know they were looking into this already.
Based on my limited knowledge I think we can put the Online URL as the first "related links" entry and then Online will work. Here is some details I found: https://info.sapien.com/index.php/scripting/scripting-help/helpuri-v-helpinfouri
I know that Chris does this in Exchange, here is example: https://github.com/MicrosoftDocs/office-docs-powershell/blob/master/exchange/exchange-ps/exchange/active-directory/Add-ADPermission.md
That way we can get away from fwlink dependency.

@kenwith and I talked. Putting the Online URL as the first "related link" is not recommended as it is not supported for the -Online experience and can be broken in future releases. For the MD files we need to add a link in the frontmatter. But that link should be a direct link to the article on docs.microsoft.com. The FWLinks should only be used in the cmdlet source code to bootstrap the help experience. The existing FWLinks need to be updated (internally) to fix the 404 issues.

The pattern for the online version: metadata in the frontmatter is as follows:
online version: https://docs.microsoft.com/powershell/module/<module-name>/<cmdlet-name>?view=<version-moniker>

So for the Add-WsusComputer cmdlet the new correct link will be:
online version: https://docs.microsoft.com/powershell/module/UpdateServices/Add-WsusComputer?view=win10-ps

Note that he URL does not include a locale (en-us).

Hmm... I think what we need here is to take a pragmatic approach, and I think do see a pragmatic solution here.
Currently, our bad links are as follows. (I deleted the "https://docs.microsoft.com/en-us/powershell/module" portion for brevity.)

/wsus/Add-WsusComputer?view=win10-ps
/wsus/Add-WsusDynamicCategory?view=win10-ps
/wsus/Approve-WsusUpdate?view=win10-ps
/wsus/Deny-WsusUpdate?view=win10-ps
/wsus/Get-WsusClassification?view=win10-ps
/wsus/Get-WsusComputer?view=win10-ps
/wsus/Get-WsusDynamicCategory?view=win10-ps
/wsus/Get-WsusProduct?view=win10-ps
/wsus/Get-WsusServer?view=win10-ps
/wsus/Get-WsusUpdate?view=win10-ps
/wsus/Invoke-WsusServerCleanup?view=win10-ps
/wsus/Remove-WsusDynamicCategory?view=win10-ps
/wsus/Set-WsusClassification?view=win10-ps
/wsus/Set-WsusDynamicCategory?view=win10-ps
/wsus/Set-WsusProduct?view=win10-ps
/wsus/Set-WsusServerSynchronization?view=win10-ps

We need to make them look like the following:

/updateservices/Add-WsusComputer?view=win10-ps
/updateservices/Add-WsusDynamicCategory?view=win10-ps
/updateservices/Approve-WsusUpdate?view=win10-ps
/updateservices/Deny-WsusUpdate?view=win10-ps
/updateservices/Get-WsusClassification?view=win10-ps
/updateservices/Get-WsusComputer?view=win10-ps
/updateservices/Get-WsusDynamicCategory?view=win10-ps
/updateservices/Get-WsusProduct?view=win10-ps
/updateservices/Get-WsusServer?view=win10-ps
/updateservices/Get-WsusUpdate?view=win10-ps
/updateservices/Invoke-WsusServerCleanup?view=win10-ps
/updateservices/Remove-WsusDynamicCategory?view=win10-ps
/updateservices/Set-WsusClassification?view=win10-ps
/updateservices/Set-WsusDynamicCategory?view=win10-ps
/updateservices/Set-WsusProduct?view=win10-ps
/updateservices/Set-WsusServerSynchronization?view=win10-ps

So, if we redirect all of the links in the former list to all of the links in the latter, we solve the bulk of our problem without needing to update the fwlink redirects or fix the build pipeline.
Now, please do tell me if I am being wrong here: The correct way is to make a .openpublishing.redirection.json at the root of windows-powershell-docs, whose content is:
{
    "redirections": [
        {
            "source_path": "docset/windows/updateservices/Add-WsusComputer.md",
            "redirect_url": "/powershell/module/updateservices/Add-WsusComputer",
            "redirect_document_id": true
        },

Docs Build status updates of commit 6384f5b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

.openpublishing.redirection.json
:warning:Warning

Details

[Error] Redirection info is incorrect for following documents: module/updateservices/Set-WsusServerSynchronization, module/updateservices/Set-WsusProduct, module/updateservices/Set-WsusDynamicCategory, module/updateservices/Set-WsusClassification, module/updateservices/Remove-WsusDynamicCategory, module/updateservices/Invoke-WsusServerCleanup, module/updateservices/Get-WsusUpdate, module/updateservices/Get-WsusServer, module/updateservices/Get-WsusProduct, module/updateservices/Get-WsusDynamicCategory, module/updateservices/Get-WsusComputer, module/updateservices/Get-WsusClassification, module/updateservices/Deny-WsusUpdate, module/updateservices/Approve-WsusUpdate, module/updateservices/Add-WsusDynamicCategory, module/updateservices/Add-WsusComputer

.openpublishing.redirection.json

[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Add-WsusComputer.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Add-WsusDynamicCategory.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Approve-WsusUpdate.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Deny-WsusUpdate.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusClassification.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusComputer.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusDynamicCategory.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusProduct.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusServer.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Get-WsusUpdate.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Invoke-WsusServerCleanup.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Remove-WsusDynamicCategory.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Set-WsusClassification.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Set-WsusDynamicCategory.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Set-WsusProduct.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docset/windows/updateservices/Set-WsusServerSynchronization.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 8e1818b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Approve-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Deny-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusServer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Invoke-WsusServerCleanup.md
:white_check_mark:Succeeded

docset/windows/updateservices/Remove-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusServerSynchronization.md
:white_check_mark:Succeeded

docset/windows/updateservices/UpdateServices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 344c1c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Approve-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Deny-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusServer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Invoke-WsusServerCleanup.md
:white_check_mark:Succeeded

docset/windows/updateservices/Remove-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusServerSynchronization.md
:white_check_mark:Succeeded

docset/windows/updateservices/UpdateServices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 968e436:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Add-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Approve-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Deny-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusComputer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusServer.md
:white_check_mark:Succeeded

docset/windows/updateservices/Get-WsusUpdate.md
:white_check_mark:Succeeded

docset/windows/updateservices/Invoke-WsusServerCleanup.md
:white_check_mark:Succeeded

docset/windows/updateservices/Remove-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusClassification.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusDynamicCategory.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusProduct.md
:white_check_mark:Succeeded

docset/windows/updateservices/Set-WsusServerSynchronization.md
:white_check_mark:Succeeded

docset/windows/updateservices/UpdateServices.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off

Much obliged, @sdwheeler 👍


Add "Has Changes" Github action

This action can be used to determine whether a "diff" includes changes
to files whose paths are not part of a provided exclusion list.
A "diff" is defined as:

for a PR, the diff between the base SHA and the HEAD
for a push, the diff between the last SHA that was previously pushed
to the branch and the HEAD

This action can be used to avoid running Kind tests for documentation
PRs. Unlike the "paths-ignore" option for Github workflows, we will
return a success status even when the tests are being skipped.

Codecov Report

Merging #1188 into master will decrease coverage by 14.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1188       +/-   ##
===========================================
- Coverage   56.07%   41.44%   -14.63%
===========================================
  Files         106       74       -32
  Lines       11539    10507     -1032
===========================================
- Hits         6470     4355     -2115
- Misses       4501     5798     +1297
+ Partials      568      354      -214

Flag
Coverage Δ

#integration-tests
?

#unit-tests
41.44% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


viki.com got 422 http error

Checklist

[ x] I'm reporting a broken site support issue
[x ] I've verified that I'm running youtube-dl version 2021.12.17
[x ] I've checked that all provided URLs are alive and playable in a browser
[x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x] I've searched the bugtracker for similar bug reports including closed ones
[ x] I've read bugs section in FAQ

Verbose log

c:\Users\user\Downloads\youtube>youtube-dl.exe https://www.viki.com/videos/1166283v-beautiful-reborn-flower-episode-1 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://www.viki.com/videos/1166283v-beautiful-reborn-flower-episode-1', '--verbose']
[debug] Encodings: locale cp1250, fs mbcs, out cp852, pref cp1250
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg N-99707-g2b702015d8, ffprobe N-99707-g2b702015d8
[debug] Proxy map: {}
[viki] 1166283v: Downloading video JSON
ERROR: Unable to download JSON metadata: HTTP Error 422: Unprocessable Entity (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

c:\Users\user\Downloads\youtube>455872

Description

viki.com video got a http 422 error. Don't know why, could you please help how to fix this?
May I miss anything? Site working via chrome. Youtube-dl is working with different hosts.

I've no idea what's giving 422, but as far as I know all Viki downloads are encrypted and not accessible to yt-dl as below:
$ python -m youtube_dl -F -v 'https://www.viki.com/videos/1166283v-beautiful-reborn-flower-episode-1'
[debug] System config: [u'--prefer-ffmpeg']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-F', u'-v', u'https://www.viki.com/videos/1166283v-beautiful-reborn-flower-episode-1']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Git HEAD: ef044be34
[debug] Python version 2.7.17 (CPython) - Linux-4.4.0-210-generic-i686-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 4.3, avprobe 4.3, ffmpeg 4.3, ffprobe 4.3
[debug] Proxy map: {}
[viki] 1166283v: Downloading video JSON
[viki] 1166283v: Downloading video streams JSON
[viki] 1166283v: Downloading initial MPD manifest
[viki] 1166283v: Downloading MPD manifest
WARNING: [viki] Unknown MIME type image/jpeg in DASH manifest
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "youtube_dl/extractor/viki.py", line 288, in _real_extract
    self._sort_formats(formats)
  File "youtube_dl/extractor/common.py", line 1374, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

$

Not sure if this is on topic, but this is the Widevine key for this video:
c723f9654472964cde176bd2d17d69b0

Here is a command to download the video:
ffmpeg -cenc_decryption_key c723f9654472964cde176bd2d17d69b0 `
-i 'https://manifest-viki.viki.io/v1/1166283v/limelight/main/mpd/normal/viki/high/sd/ww/dt2_dt3/manifest.mpd?tag=mpdhd%3Ahigh%3Aww%3AsourceVIKI%3Ampd%3Acached%3Adt2_dt3&app=100000a&h_country=us&h_data_center=scr-2&h_host=playback-streams-db49cd5ff-m9ktz&h_timestamp=1654804383&sig=a263f53087d273fc4448339fdd58d21021c65307' `
-c copy -map 0:0 dec.mp4

Be that as it may, yt-dl's position is that DRM files are only useful for disk stress testing, etc, and so they aren't downloaded. In case anyone wants to research a particular file, the --allow-unplayable-formats yt-dlp option may be relevant.

@dirkf the above seems pretty innocent. I think if FFmpeg allows it, then YouTube-DL should be safe, as long as its implemented in a similar manner, where the user must provide the key. YouTube-DL is already decrypting some items in a similar fashion:
https://github.com/ytdl-org/youtube-dl/blob/5208ae92fc3e2916cdccae45c6b9a516be3d5796/youtube_dl/downloader/hls.py#L187-L199
only difference would be user providing key, instead of YouTube-DL extracting the key.

I get the same error trying to download a Viki video that I was able to download last year. Viki seems to have started using DRM recently. Viki should probably be removed from the supported sites list, since it's no longer possible to download anything from it. You can use StreamFab instead, if you don't mind paying....

https://github.com/ytdl-org/youtube-dl/issues/31049


Libsoup is out of date

As title says, libsoup is out of date.
Latest release is currently 3.0.4.
You may be aware of this already, but Im making an issue for it anyway, so
perhaps others can pitch in aswell.
Right of the bat, there are some issues, you guessed it, it doesnt build.
Here's the error:
[211/235] Linking target tests/request-body-test ninja: job failed: cc  -o tests/ssl-test tests/ssl-test.p/ssl-test.c.o -Wl,--as-needed -Wl,--no-undefined -O2 -pipe -march=znver1 -mtune=znver1 '-Wl,-rpath,$ORIGIN/:XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX' -Wl,-rpath-link,/tmp/566/build/libsoup/output/tests -Wl,--start-group tests/libtest-utils.so libsoup/libsoup-3.0-static.a /usr/lib/libglib-2.0.so -Wl,--export-dynamic /usr/lib/libgmodule-2.0.so -pthread /usr/lib/libgobject-2.0.so /usr/lib/libgio-2.0.so /usr/lib/libgnutls.so /usr/lib/libsqlite3.so /usr/lib/libpsl.so /usr/lib/libz.so /usr/lib/libnghttp2.so -Wl,--end-group /usr/bin/ld: tests/ssl-test.p/ssl-test.c.o: in functionmain':
/tmp/566/build/libsoup/output/../tests/ssl-test.c:717: undefined reference to
gnutls_pkcs11_init' /usr/bin/ld: /tmp/566/build/libsoup/output/../tests/ssl-test.c:718: undefined reference to gnutls_pkcs11_add_provider'
collect2: error: ld returned 1 exit status
ninja: subcommand failed
`
Fixing this is rather trivial, as I just disabled pkcs11-tests.
As Ive been doing some testing with this, I also managed to build libsoup 3.0.4
without disabling pkcs11-tests, but to do so, I had to build gnutls with
p11-kit.
edit: I had to clean up the post abit.
I also have issues with 3.0.4 not working with webkit2gtk, but Ill create a
separate issue for it.

libsoup has been a tricky package. I've kept it on 2.74.2 since most packages don't complain about it. I've messed around with 3.0.4 and it was finicky. I have no problems with packaging libsoup 3.0.4 as libsoup3. I think carbs has done the same.
As for webkit, it's likely a configure option. From doing a basic grep of the files, I think you should be able to build with libsoup 3 just by changing -DUSE_SOUP2=ON to -DUSE_SOUP2=OFF.
I'll look into this more tomorrow.

That may be the case, and it would perhaps be wise to separate them for those
packages thats explicitly problematic with 3.x. I too noticed, that
Carbs linux did this, but its still in testing, so he's probably still
ironing out some stuff.
I wasnt aware of the config flag, as I havent really looked into that part of
webkit too much, but in any case, I added the flag, and built webkit with
-DUSE_SOUP2=OFF, and webkit built successfully.
However, now surf, vimb, and wyeb will complain about webkit2gtk-4.0 is
missing. This seems to be an issue with pkgconf not being able to find
webkit2gtk-4.1.pc and related files.
Ive tried to set PKG_CONFIG_PATH, but I havent had any luck in doing so
successfully.
I did some digging on surf's config.mk file, and changed 4.0 to 4.1, and surf
now builds. I did a quick test on vimb and wyeb aswell, and while the error
about webkit was gone, a whole lot of other errors took its place instead.
I dont currently use vimb/wyeb myself, but I wanted to test those aswell, to
see if the issue persisted across other webkit browsers too.

Would it be wise then to add a check in webkit's build script for libsoup 3 and set the flag accordingly?
Did you do testing of surf as well besides just the build? And I am a bit surprised about vimb and wyeb. Maybe it'd also be just changing a few lines in their Makfile?
Also if you want, feel free to make a PR for libsoup3, I'd be happy to merge. Otherwise I'll add it Monday.

Yeah, I belive that would be a great idea.  Atleast untill we can iron out the cruft with the browsers atleast. Im not sure what else depends on libtool, but afaik, its ony the said browsers and webkit in this repo anyway. As for other repos, Id have to check when I get back on my laptop.
Ive used surf with libsoup3 for some hours now, and I havent had any appearany issues. So Surf seems to work fine with it.
They seem to need a little more work, but I havent gotten much past chaning the webkit version, but Ill look into that aswell.
Sounds good, Ill make one when I get back to the laptop, and once you merge, we can close  this issue aswell, and Ill make a new one for the browsers/webkit :D

closing this, as #23 is now merged


Small fix for Issue #69 -- Update louvain package for compatibility with Networkx 2.0

#69

Thanks for the contribution @iamjli . Did this solve your problem?

yes

Thanks @iamjli !


SPM Restructure and Bug Fix where Font path was coming as nil

Precisely the fix for --
https://github.com/thii/FontAwesome.swift/issues/248

Any idea when this can be merged? I can confirm SPM works!

@MatrixSenpai Please create a release tag.


Start grabbing some French data

A start to #13. I've gone for the absolute simplest shell script-like approach, producing a GeoJSON file and a CSV file with a matching zone ID column. Thanks to @XioNoX for finding the data!

Can I maybe help with this ? Not sure what the end result is supposed to be.

Thanks for the offer! I think we're OK for the moment; Stuart and Andy are experimenting with using https://dagster.io/ to organize code in this repo. Once some of the dust settles there, we'll pick up the work for France

There is now some guidance on how to add a new country https://popgetter.readthedocs.io/en/latest/new_country/
However this might change a bit more in the future. For now, I am marking this PR as draft.

@XioNoX, if you'd like to pick this up, let us know! It might be lots of work if you haven't used Dagster before though

I'd be happy to, but after reviewing the doc and the existing countries, it seems like out of my skills level.
I can however provide guidance and answer questions on french specific data, or if one of you have a bit of time to walk me through the process that would be nice !


Verify PowMr POW-HVM6.2M-48V support

Basic support for EASUN SMG II and PowMr inverters that use with RS232 WiFi dongle and SmartESS app. Select inverter type "Sumry".

https://solar-assistant.io/help/updates/changelog
@flyzet-prog

Other models using the same protocol / wifi dongle version:

POW-HVM1.5H-12V
POW-HVM2.4H-24V
POW-HVM3.6M-24V
POW-HVM4.2M-24V
POW-HVM6.2M-48V

It looks like these devices are using the PI30 protocol at 2400 baud.
Powmr Pow-hvm1.5H-12v: https://github.com/Schnippsche/solarreader/blob/main/src/main/java/de/schnippsche/solarreader/backend/devices/Powmr.java

It's a PI30 device for sure and cannot be supported here.


CB-8752 Adds docs for hooks functionality

Moving hooks documentation to docs as this is general and not hello-world app specific
https://github.com/apache/cordova-app-hello-world/blob/master/hooks/README.md
Added Sample Usage section w/ end-to-end example

The following places must be updated to point to the docs after this is merged and released:
https://github.com/apache/cordova-app-hello-world/blob/master/hooks/README.md
https://github.com/apache/cordova-cli/#hooks-1


Anime: Add YouTube link

Extract "youtubeVideoId" from the API response, and add another link here.

Could I do this one, I've never contributed before and this seems like a good starting point?

I would also like to try this one, if it's ok.

Hello, I'm interested, I am a first timer and would take some time to understand the code. Is this issue still open?
I would like to help.
Can someone guide me?

Sorry sir,forgot to write the comment..
I have added a youtube link, Can you verify it??


Body tracking is almost unusable for WFOV (binned and unbinned) modes

In WFOV depth modes (WFOV_2x2BINNED and WFOV_UNBINNED) body tracking is almost unusable. It cannot correctly recognize even static T-pose (see image attached). And the quality of body index map for these modes is so poor that I have no words to describe it (body pixels are highlighted on attached screenshot).

Thanks for your feedback. Could you provide more details about the issue. The supported distance for WFOV mode is much shorter than the LTN mode. May I ask how far away you stand in front of the camera? Also, the body tracking algorithm might work worse when there is a wall closely behind you. May I ask whether it is the case for your situation?

Also, could you try to do a screenshot with the "Azure Kinect Body Tracking Viewer"?

May I ask how far away you stand in front of the camera?

Distance between sensor and face: 1.7 m

Also, the body tracking algorithm might work worse when there is a wall closely behind you. May I ask whether it is the case for your situation?

Distance to wall: 2.5 m
Also, I would say that in NFOV modes body tracking works much better exactly in the same conditions: the same room, the same sensor position, the same person on the same distance, similar movements.

Thanks for the quick response! The NFOV mode works better because the field of view is narrower. So both the pixel density and the signal strength for each pixel are stronger.
But given your condition, the WFOV should have worked correctly. I tried on our side but I couldn't repro the problem you reported. Do you mind using the k4arecorder tool to record an mkv clip and share with us? We would like to use it to further improve the algorithm before the final release. The k4arecorder is shipped with the Sensor SDK. You can find the instruction about recording here.

Is not a BUG. The space is error. U can call k4a_calibration_3d_to_2d to calibrate and pan an offset(cx,cy) to make it correct.

Do you mind using the k4arecorder tool to record an mkv clip and share with us?

Sure. Please, email me directly (bibigone (at) gmail.com) and I'll send links to MKV files as reply (I don't want to publish them here for everyone).

Is not a BUG. The space is error. U can call k4a_calibration_3d_to_2d to calibrate and pan an offset(cx,cy) to make it correct.

k4a_calibration_3d_to_2d was definitely used to project 3D coordinates of joints to depth map.
Also, as you can see, arms are not highlighted at all, which means that pixels of arms are not marked as "body pixels" on body index map. And visualization of body index map doesn't involve 3D <-> 2D conversions at all.

@bibigone
The joints in the 3d space, but the body index map is texture of 2d.
U can see...

I use the 3d_to_2d and pan an offset, and it's correct.

@bibigone
And depth mode is WFOV_2x2BINNED

@venscn
Please, send me email and I'll provide you with an example (MKV file). Because right now it sounds like "It works on my machine".
Also, the full source code I have used for screenshot can be found here:
https://github.com/bibigone/k4a.net
(see K4AdotNet.Samples.Wpf.BodyTracker project in solution).
Fragment from TrackerModel.cs:
        private Float2? ProjectJointToDepthMap(Joint joint)
            => calibration.Convert3DTo2D(joint.PositionMm, CalibrationGeometry.Depth, CalibrationGeometry.Depth);

@bibigone<EMAIL_ADDRESS>

@bibigone
See..

Maybe your arm is reflective, so....

@venscn

<EMAIL_ADDRESS>
Sent.

See..

You're subtracting optical center (cx, cy) because you're using such coordinate system (with zero in the center of an depth map), while I'm using coordinate system where zero is the top-left corner of depth map. If I apply such subtraction in may case, it just shifts the whole skeleton out of the borders of depth map. That's all.
I'll send you ready-to-use application in ZIP-archive. You can play with it in your environment and make sure that it works correctly. (It is really annoying that I have to prove it...)

@bibigone
Laugh.
I understand that something went wrong.
So the body index map need to wait for them to fix.

@venscn

And lost body pixels, maybe your arm is reflective, so...

No. Arms are good visible on depth map. See original screenshot and MKV example I've just sent to you by email.

@bibigone
Ok, but i'm in china.
I don't have any vpn to visit the dropbox.
The vpn is expensive by me.

Not related to the main viewer but I tried out the viewer app by @bibigone and it is very nice. Thank you for sharing!

@bibigone Thanks again for sharing us the recording files. We can repro this issue locally now. We will further investigate the problem and try to improve the quality in our future release.

@bibigone
Thanks for reporting this issue. Btw, does it work any better if you move  forward, away from the rear wall?

@tobysharp

Btw, does it work any better if you move forward, away from the rear wall?

I'll try it next week and come back to you with results and sample videos.

Sorry for so long delay here. It was records from our user. We cannot reproduce this issue in our rooms. And the user cannot record other MKV files in the same room because he is using Azure Kinect devices at some other installation. He promised to try to do it later.

Hi @bibigone , thanks again for sharing the test data. Our latest 0.9.3 SDK largely improves the robustness of the body detection. Please give it a try to see whether it helps mitigate this issue. It might not solve the problem completely. But we are still working on further improvements. Please stay tuned for future releases.

Hello @yijiew,
Thank you for the latest release of Body Tracking SDK. Indeed, it solves this issue and has other significant improvements.
I think you can close this issue as resolved.

Thanks @bibigone . We really appreciate your feedback and all the efforts to build the C# wrapper. Please feel free to create issues here like you did if you find anything we can improve :D


[ai-form-recognizer] Support API version 2023-02-28-preview

WIP
This PR updates @azure/ai-form-recognizer to support API version 2023-02-28-preview. It updates the SDK version to 4.1.0-beta.1.
It also removes the test recordings which have been onboarded to the asset sync tool.
The changes are described in CHANGELOG.md. All generated files (prebuilt models) have been regenerated based on the latest model schemas. The vast majority of changes are deleted recordings or regenerated models. See the api.md file for changes to the API.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-form-recognizer


Add support for module loaders + add Typescript definition file.

I added support for module loaders. It is done in the same way as in Leaflet library using Rollup.js module bundler.
In addition, I added Typescript definition file directly into library, including types property in package.json file, so that additional typescript definitions are not needed.
Used it in a project for a while now, so there were no issues. Also tested - works without modules, as before.

resolves #31

Thanks a lot for all your work on this!


Go not traversing symlinks

V 1.6.2 Darwin/AMD64
# My project lives here
cd ~/myproject

# My $GOPATH is ~/gopath
echo $GOPATH
/Users/kris/gopath

# Symlink my project into $GOPATH
ln -s ~/myproject $GOPATH/src/myproject
go install $GOPATH/src/myproject/...

#This error message
warning: "/Users/kris/gopath/myproject/..." matched no packages

I would expect go to respect and follow the symlink and traverse the path as it would with a hardlink.

The go command uses filepath.Walk to match packages, and filepath.Walk does not follow symbolic links at this time.
Changing this means either modifying filepath.Walk or creating a custom walk that resolves symbolic links.
I would not encourage the first option on due to Compatibility guidelines. I rely on filepath.Walk behavior not to follow symlinks, and on many Linux systems I use this would cause circular non-terminating traversals.
$GOROOT/src/cmd/go/main.go:560,561:        fmt.Fprintf(os.Stderr, "warning: %q matched no packages\n", pattern)
$GOROOT/src/cmd/go/main.go:565,566:        func matchPackages(pattern string) []string {
$GOROOT/src/cmd/go/main.go:590,591:            filepath.Walk(root, func(path string, fi os.FileInfo, err error) error {

go doc filepath.Walk
func Walk(root string, walkFn WalkFunc) error
    Walk walks the file tree rooted at root, calling walkFn for each file or
    directory in the tree, including root. All errors that arise visiting files
    and directories are filtered by walkFn. The files are walked in lexical
    order, which makes the output deterministic but means that for very large
    directories Walk can be inefficient. Walk does not follow symbolic links.

Ah thanks for the response @as - this makes a lot more sense now. I would say it's safe to set this is a nuisance more than anything else. But I still am curious if the issue needs to be addressed?
Is the ability to follow symlinks in this context something we would like to see in a later version of go?

There was a proposal to add this feature in May, but it was declined. The reason is that symlinks introduce too much complexity and aren't worth their trouble.
I agree with the reason. The symlinks on my Linux systems were created by the distribution builders and I personally avoid them. If you're unable to use hard links, maybe 'mount -o bind' can solve your problem by approximating a namespace in Linux.

Like in #15507, we're not going to attempt this. It creates too many other issues. You could instead symlink ~/myproject -> your GOPATH. Apologies.


jet packs vanish and appear

when wearing a outfit, jet packs vanish after using them then do not re-appear until you use the jet pack again.  I believe Bethseda did this intentionally and it drives me crazy.  if you look in comments sections of mods dealing with hiding space suits or jet packs you will see post after post of people begging someone to fix this.....its a intentional bug the devs forced on us please be the community hero's and fix this.

Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
just take off your space suit and use your pack......its despicable.....2023 and this.............no pistols display on your character........no melee display either.............WTF Devs.

You even state yourself that Bethesda did this intentionally, which clearly makes this not a bug.

Not a bug


task: Added workflow for releasing new versions from GHA

If this works, it would make the workflow the same as we have for Unleash server.
Trigger the workflow, type the desired version to release and wait.

Nice


strip trailing zero from brand name

Thanks for reporting this!
The bug is in valAsString, where the switch is on r instead of dst.
The switch should be:
		switch {
		case dst[0] == 0:
			return r[:i*4]
		case dst[1] == 0:
			return r[:i*4+1]
		case dst[2] == 0:
			return r[:i*4+2]
		case dst[3] == 0:
			return r[:i*4+3]
		}

You are welcome to change your PR, or I can submit it if you'd like.

On Wed, Jun 24, 2015 at 05:20:56AM -0700, Klaus Post wrote:

The bug is in valAsString, where the switch is on r instead of dst.

Sorry, I didn't even look at this function.
Updated.
On a second thought. Do all cpus pad the string with spaces to 47 chars?
Otherwise appending to name should probably stop after seeing the first
0. (disclaimer: I didn't read any spec in detail).

Otherwise appending to name should probably stop after seeing the first 0.

This is what 'valAsString' was intended to do.  It is a maximum 48 byte zero-terminated string.

On Wed, Jun 24, 2015 at 05:42:05AM -0700, Klaus Post wrote:

Otherwise appending to name should probably stop after seeing the first 0.

This is what 'valAsString' was intended to do.  It is a maximum 48 byte zero-terminated string.

So the loop in cpuid.go:542 should terminate early if any zero is detected.
0x41414141, 0x41414141, 0x41414141, 0x00414141 = cpuid(0x80000002)
0x42424242, 0x42424242, 0x42424242, 0x00424242 = cpuid(0x80000003)
0x43434343, 0x43434343, 0x43434343, 0x00434343 = cpuid(0x80000004)

should result in "AAAAAAAAAAAAAAA" but it would result in
"AAAAAAAAAAAAAAABBBBBBBBBBBBBBBCCCCCCCCCCCCCCC" right now.

@ebfe - you are of course right!  Thanks again!


Onboard NVWA and The Future Mobility Network

Fixes #
Proposed Changes

Onboarding Future Mobility Network B.V.
Public Network Address: 0x6F28a052eeb897d6412A8198D0DDF1FC15fe3D94
Address: Molengraaffsingel 8, 2629 JD, Delft, Netherlands
Country Code: NL-ZH
Register No. KVK: 87542633
Onboarding Netherlands Food and Consumer Product Safety Authority (NVWA) Public Network Address: 0x1504d3AE9224091990Cb2F71D0e10B8F7E84E7De
Address: Catharijnesingel 59, 3511 GG, Utrecht, Netherlands
Country Code: NL-UT
Register No. KVK: 50688049

I will make a new MR, so that this one can be closed.


[Mobile] Select team updates

UI updates to Monster Screen as well as default functionality.
Tasks Addressed:

https://github.com/rightoneducation/righton-app/issues/424
https://github.com/rightoneducation/righton-app/issues/425

Default should prevent this crash:

https://appcenter.ms/orgs/right-on-education/apps/righton-android/crashes/errors/2379820874u/overview

Updated screen:


Store-Gateway can't read historical metrics from GCP bucket

Thanos version used: v0.21.1

Object Storage Provider: GCP
What happened:
Trying to retrieve historical data from GCP bucket consistenly getting the error
level=debug ts=2021-07-26T11:49:09.243646183Z caller=bucket.go:1078 msg="stats query processed" stats="&{blocksQueried:0 postingsTouched:1638 postingsTouchedSizeSum:317601 postingsToFetch:0 postingsFetched:0 postingsFetchedSizeSum:0 postingsFetchCount:0 postingsFetchDurationSum:0 cachedPostingsCompressions:0 cachedPostingsCompressionErrors:0 cachedPostingsOriginalSizeSum:0 cachedPostingsCompressedSizeSum:0 cachedPostingsCompressionTimeSum:0 cachedPostingsDecompressions:1638 cachedPostingsDecompressionErrors:0 cachedPostingsDecompressionTimeSum:1996286 seriesTouched:0 seriesTouchedSizeSum:0 seriesFetched:0 seriesFetchedSizeSum:0 seriesFetchCount:0 seriesFetchDurationSum:0 chunksTouched:0 chunksTouchedSizeSum:0 chunksFetched:0 chunksFetchedSizeSum:0 chunksFetchCount:0 chunksFetchDurationSum:0 getAllDuration:0 mergedSeriesCount:0 mergedChunksCount:0 mergeDuration:0}" err="rpc error: code = Aborted desc = fetch series for block 01F9PN032H5717GYENM2ED767Z: expanded matching posting: get postings: read postings range: get range reader: Get \"https://storage.googleapis.com/thanos-long-term/01F9PN032H5717GYENM2ED767Z/index\": context canceled"
level=debug ts=2021-07-26T11:49:09.372648263Z caller=bucket.go:1078 msg="stats query processed" stats="&{blocksQueried:0 postingsTouched:2430 postingsTouchedSizeSum:481212 postingsToFetch:0 postingsFetched:792 postingsFetchedSizeSum:382632 postingsFetchCount:792 postingsFetchDurationSum:934286803292 cachedPostingsCompressions:792 cachedPostingsCompressionErrors:0 cachedPostingsOriginalSizeSum:382632 cachedPostingsCompressedSizeSum:50486 cachedPostingsCompressionTimeSum:5725057 cachedPostingsDecompressions:1638 cachedPostingsDecompressionErrors:0 cachedPostingsDecompressionTimeSum:1500990 seriesTouched:0 seriesTouchedSizeSum:0 seriesFetched:0 seriesFetchedSizeSum:0 seriesFetchCount:0 seriesFetchDurationSum:0 chunksTouched:0 chunksTouchedSizeSum:0 chunksFetched:0 chunksFetchedSizeSum:0 chunksFetchCount:0 chunksFetchDurationSum:0 getAllDuration:0 mergedSeriesCount:0 mergedChunksCount:0 mergeDuration:0}" err="rpc error: code = Aborted desc = fetch series for block 01FAF3RYJFM78QJJFTGEZJEDQQ: expanded matching posting: get postings: read postings range: get range reader: Get \"https://storage.googleapis.com/thanos-long-term/01FAF3RYJFM78QJJFTGEZJEDQQ/index\": dial tcp <IP_ADDRESS>:443: i/o timeout"

The same time the livenessProbe is falling too:
# while true ; do curl http://<IP_ADDRESS>:10902/-/healthy -m 1 ; sleep 1 ; echo ; done
...
OK
OK
curl: (28) Operation timed out after 1000 milliseconds with 0 bytes received

curl: (28) Operation timed out after 1000 milliseconds with 0 bytes received

curl: (28) Operation timed out after 1000 milliseconds with 0 bytes received

OK
curl: (28) Operation timed out after 1001 milliseconds with 0 bytes received

curl: (28) Operation timed out after 1001 milliseconds with 0 bytes received

OK
curl: (28) Operation timed out after 1001 milliseconds with 0 bytes received

OK
OK
...

Pod resource request
        resources:
          limits:
            memory: "120G"
            cpu: "4000m"

Pod arguments
        args:
        - store
        - --log.level=debug
        - --data-dir=/data
        - --objstore.config-file=/mnt/thanos-objstore-config/thanos-storage-conf.yaml
        - --index-cache-size=30GB
        - --chunk-pool-size=80GB
        - --ignore-deletion-marks-delay=24h

How to reproduce it:
Query metrics for last 6 months
netdata_system_cpu_percentage_average{job="netdata",hostname=~"ns-ng1"}

Seems you have many blocks in object store. you should sharding store-gateway by time and relabel with hashmod or tenant. refrence doc: https://thanos.io/tip/thanos/sharding.md/#time-partitioning

Thank you for reply. I created 12 thanos-store shards by modulus relabeling.
Store is much better now but still freezes and shows metrics incompletely.
Here is an excretion from the manifest:
spec:
  replicas: 12
  template:
    spec:
      containers:
      - name: thanos
        image: quay.io/thanos/thanos:v0.21.1
        args:
        - store
        - --log.level=debug
        - --data-dir=/data
        - --objstore.config-file=/mnt/thanos-objstore-config/thanos-storage-conf.yaml
        - --index-cache-size=7GB
        - --chunk-pool-size=20GB
        - --ignore-deletion-marks-delay=24h
        resources:
          limits:
            memory: "30G"
            cpu: "1500m"

Our bucket is huge. Can we tune the thanos-store anyhow or it has limitations?

Shard by time and external label is the key.
the query-front-end can split long time range query to multi short time range queries.

Could you provide me with example of "time-base-partitioning" please?
I can't realize how min-max time frames are related to replicas number.

@iliyahoo is thanos-long-term/01FAF3RYJFM78QJJFTGEZJEDQQ/index an insanely large file? Are you maybe getting a timeout because it is too large to load?

thanos-long-term/01FAF3RYJFM78QJJFTGEZJEDQQ/index is 40.4 Mb only


CensusContextFactory.deserialize should clarify mutabilty

CensusContextFactory.deserialize doesn't say whether it will mutate the passed in ByteBuffer.   This means that all callers will have to make a defensive copy to avoid accidentally having the underlying data, mark, position, or limit values changed.
It should be clear from the documentation that it will be treated as immutable.

That makes sense - is there a standard notation/annotation to indicate that or should I add a note in the documentation?

We've changed the interface to take a InputStream, so I believe this is a non-issue now. Feel free to reopen with any questions/comments.


Size and position of drop down list

Hi @michaelprimez
The drop down list is not as the same size and position of the spinner it self. As you see in the image, I use the spinner in an arabic application and I don't know if it's the reason of this problem.
Is there any method to set the width and the position of the drop down list?

Again, thanks for your efforts in this amazing library and for your fast response.

Did You Know how to divide the content in the spinner

Hi @PatilAbhi
Can you please post the xml in order to reproduce it. Thanks

<gr.escsoft.michaelprimez.searchablespinner.SearchableSpinner
android:id="@+id/spinner1"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:textSize="20sp"
android:gravity="center_horizontal"
app:DoneSearchTintColor="@android:color/holo_purple"
app:RevealEmptyText="   Touch to select"
app:RevealViewBackgroundColor="@android:color/holo_purple"
app:SearchViewBackgroundColor="@android:color/secondary_text_dark"
app:ShowBorders="false"
app:SpinnerExpandHeight="200dp"
app:StartSearchTintColor="@android:color/white"
app:hintText="Select Fault" />

I want to divide the items with a horizontal line ...

Hi @PatilAbhi
about the items divider you can use the version 1.0.8 which it has 2 new properties ItemsDivider and DividerHeight. About the size and position of the list, i can't reproduce it, maybe something is wrong in your adapter's item creation or somewhere in the layout a margin or padding breaks the view. It would be very helpful if you post the layout that's include the spinner and the getView code from the adapter.
Thanks.

Hi @michaelprimez
Is there any solution for the main issue?
"Is there any method to set the width and the position of the drop down list?"
Thanks in advance.

Hey @Elessawy
i saw in the picture that the arrow icon is at the left, What did you do and you mange to place it here, maybe that's causing the problem.

I changed the localization of the whole app to arabic and by default some components like spinners flips horizontally because arabic language is written from the right to the left.
For example, this is the position of back button after changing the localization

I changed the localization of the whole app to arabic and by default some components like spinners flips horizontally because arabic language is written from the right to the left.
For example, this is the position of back button after changing the localization

I changed the localization of the whole app to arabic and by default some components like spinners flips horizontally because arabic language is written from the right to the left.
For example, this is the position of back button after changing the localization

Hi @Elessawy
I know am late but i response. I think i solve the issue in version 1.0.9.
Thanks

Thanks


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_7b360d37-1628-4e52-ad9e-f10d21a4e2c6/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_7b360d37-1628-4e52-ad9e-f10d21a4e2c6.git

Docs Build status updates of commit 1fefb62:
:clock10: Pending: waiting for processors (58 builds ahead of you)
:warning: Docs Build is busy, currently there are 58 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 1fefb62:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd1, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


uncomment working tests

An mentioned in #24, the error occurs when 1) saving a multi type to GeoJSON.jl and 2) reading the saved file with GeoTables.jl. The reason for this is that the for example, a MultiRope is being saved as a Polygon, which is incorrect. For now, I am uncommenting the tests that are working so we isolate the problem.

Codecov Report

Merging #25 (9cfaf05) into master (c07dae0) will increase coverage by 4.64%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   85.60%   90.24%   +4.64%
==========================================
  Files           3        3
  Lines         125      123       -2
==========================================
+ Hits          107      111       +4
+ Misses         18       12       -6

see 2 files with indirect coverage changes


Doesn't move the cursor at the end of the link when inserting into editor

When inserting a link into the editor via shortcut, the cursor remains at the beginning of the link whereas it would make more sense to have it at the end in order to continue writing.

Hi, @tim-hilde :)
I agree with you. However, at that time, I didn't implement it that way because some problems prevented me from doing so.
I'll try it again as possible as I can👍

In addition to that, it would be nice to have the option to insert the link in background so that the modal of AQS is still present

Right. Additionally, inserting a line break after the insertion link in the background looks better.

@tim-hilde
Released in v8.6.0 🚀


🌟 Add Starry Skies cosmetic option 🌟

Adds stars to always be drawn onto the background when the sky is visible. This works on the surface, the Sky, and Skyloft. Stars are added both during the day and the night :D (yep, they appear on the title screen)

Has been tested in several races. Works as intended.
Having the star count too high can cause areas to lag. I've added a warning in the tool tip about this. For the default star count, there doesn't appear to be any(?) lag on dolphin. For console, the problem areas are Boko Base and BiT Skyloft.

Tested in another co-op seed - works fine.


Stop creating in-memory KtFile when file path is provided

Waiting on merge of:

#7235
#7237
#7238
#7240

Is the last commit related with this PR?

It is, yes. If it's not done in AutoCorrectLevelSpec.kt then the tests will fail because the same PsiFile is being reused between tests, and the modified text persists between them. This wasn't a problem before because detekt would always create a new copy of every file it analysed, but that doesn't happen after this PR.
There may be scenarios in IDE or other usages where the same PsiFile is also reused so I figured it's safest to defend against that by making a similar change in KtFileModifier.kt


Properly handle + and / replacements in state value generation

This pull request resolves issue: https://github.com/duosecurity/duo_universal_nodejs/issues/28
Description
I modified the string replacements for + and / because the current version only replaces the first instance of these characters. Additionally, I've replace the - and _ values with Z because - and _ are invalid Base64 characters.
Motivation and Context
This issue causes intermittent failures of 2FA attempts in our client code because my original state value contains plus characters... sometimes... and the resulting state returned by the Duo authentication causes those plus signs to become space characters. Then they no longer match the original state when I check to see if they match for a user.
How Has This Been Tested?
Tested in my own production code...
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Regarding your comment about - and _ being invalid base64 characters... is this causing an problem for your application?  I'm not sure why the state generation was written with base64 involved; nothing about the OIDC spec says the state needs to be base64.

You're absolutely right, the state doesn't need to be base64. Your function name is "bytesToBase64url" so I assumed that meant it's expected to return a valid base64 string. Introducing - or _ makes it not a base64 string. That's the only reason why I changed that.

I've come up with a better way to do this. I'll be submitting another PR shortly.


Make font works in shadow dom

Hello,
I would like to use shadow dom and add icons inside this shadow dom but I can't make it works.

        <ShadowDOM include={['https://maxcdn.bootstrapcdn.com/font-awesome/4.5.0/css/font-awesome.min.css']}>

                icon

        </ShadowDOM >

    , document.getElementById('root'));`

When running the code above, I have a square icon. It seems the font itself is missing.  How can I add the font ?
Thanks for the help

It actually seems to work for me @goffle 👍
Tested in Chrome and Opera.

Should work just fine with the updated version.

I can't quite figure out how to get font-awesome to import correctly into my shadow dom. I tried using the same code as above, but was unsuccessful.

You just need to import the CSS document into the shadow root: https://codesandbox.io/s/dark-voice-snrrc?file=/src/App.js

@Wildhoney Thanks for your quick response! I'm not sure if the link you sent me is working. This is what I am currently seeing when I open your link.

Do you see something different?

Hmm yep: https://imgur.com/jOjJ8vk
Anything in the console such as the fonts failing to load?

Weird @Wildhoney. I'm not seeing any requests to font-awesome. Here's my logs and network tab.

Can confirm. Had a friend open your link @Wildhoney on his machine and just a squared showed instead of the icon. Not sure whats going on.

Sorry maybe it's because I put class instead of className? Although still strange how it showed for me.
Is this any better: https://codesandbox.io/s/pedantic-colden-h6qtt

Using Chrome browser, I can see only square on this link . And I do see font downloaded successfully in network tab. But just tried in Safari and I can see the camera icon.

Is your version of Chrome somewhere around 84.0.4147.105?

Chrome is Version 84.0.4147.105 (Official Build) (64-bit). If I change root.div to div, I can see the camera icon.


Add notifier provider page to docs v2

Changes:

Add (Async)Notifier Provider page
Add Todos example with NotifierProvider.
Add remote todos example with AsyncNotifierProvider
Add freezed dependency in the website package
Use freezed for Codegen examples.
Some generated files are updated due to the dependency update.

@rrousselGit Addressed all review comments. Would you review another round?

@rrousselGit rebased for target branch update.

LGTM


hps_accel: use accelerated multiply_accumulate() in convolution

@alanvgreen do you think it's okay to limit this to padding=valid for now and ignore padding=same? I see there was a discussion where we settled on padding=valid as a temporary solution, but I guess we will need padding=same support sooner or later?
Also worth noting that this causes the model evaluation to fail because the CFU ops are not fully implemented. If you switch it to software CFU implementation (not turned on by default currently) the golden tests pass but this is a severe speed regression. Should we fix that before merging this PR?

Yes, padding=valid is good for now. There's no rush to support padding=same.

Amended this PR to load the filter only once (as suggested by Alan), and to simplify the DCHECKs for input bounds checking (since I wasn't happy with the weird arithmetic I originally wrote, when I looked it over again).


cgo MacOSX unable to load c++ standard libraries in header files

What version of Go are you using (go version)?

$ go version
go version go1.13 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/Joesonw/Library/Caches/go-build"
GOENV="/Users/Joesonw/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/Joesonw/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/Users/Joesonw/go/github.com/joesonw/js8/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b4/t4v6zpln4rb16cvg747dz3j80000gn/T/go-build124603914=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
For any CGO project, have following code (any c++ library) in header files
#include <iostream>

The exact same project compiles under Debian
What did you expect to see?
Compile smoothly
What did you see instead?
fatal error: 'iostream' file not found

Can you provide a more complete reproduction? Thanks.

This looks like a problem with your C++ compiler, not with Go.  What happens if you write a tiny x.cc file that says #include <iostream> and run g++ -c x.cc?

It was outdated clang. after upgrading clang to 11, it now compiles.

This looks like a problem with your C++ compiler, not with Go. What happens if you write a tiny x.cc file that says #include <iostream> and run g++ -c x.cc?

I tried it with g++ and clang++,  I even tried gcc. all worked fine.

If this is still a problem for you, please show us exactly how to reproduce the problem.  Please also include the output of go build -x.  Thanks.

@iamoryanmoshe https://gist.github.com/joesonw/bfd4dbd0b34b42f5f4941502633f1bb0 and you simply comple it by go build x.go, this will give ./x.h:1:10: fatal error: 'iostream' file not found error.
By referencing x.h along in a .cc file would compile thought.
I suspect It has to do with how cgo calls c/c++ compiler on macOS ?

Oh, sorry for not noticing, but <iostream> is C++.  The cgo tool only supports C.  You can't #include a C++ header file using cgo.


Implement ChangeValueEvent

SpongeAPI | SpongeCommon
This sets up the system for implementing ChangeValueEvent if only for Entities at present time. TileEntity instances are a little different to handle as there is no data sync system short of serializing the TileEntity and sending it over the wire.

I agree with @kashike here. That is hard to see what is happening.


small fixed: env.sh has been already removed.

env.sh has not been removed but moved to release/ directory.

@officer Thanks for your comment. You are right. But sbt execution does not require env.sh no longer.


docs: describe message length varint

Closes https://github.com/celestiaorg/celestia-app/issues/728

Will wait for @adlerjohn 's approval b/c he's the spec wizard

Will merge this as-is to unblock https://github.com/celestiaorg/celestia-app/pull/856. If @adlerjohn has feedback, I can create follow-up PRs.


IDs are forced to uppercase.

Every identifier is force to uppercase when it is eventually stored in the needs.json file. This creates a discontinuity between the ID in RST and what the output contains. It causes difficulties when consuming the needs.json file from external scripts. Consumers can't rely on the ID in needs.json matching what is displayed in the HTML.
I suggest removing all the .upper() calls on IDs and links that way the plugin is not modifying the original content.

Good point.
But the IDs in needs.json and HTML should be both uppercase. Only the RST file may contain lowercase IDs.
However, I understand the problem and the decision of making it uppercase was based on the idea to get a common ID look in generated docs, even if multiple authors have set IDs in different ways.
Instead of only deactivating the upper() calls, I would like to introduce a new config parameter: needs_id_regex.
This config parameter needs a regular expression and each ID gets checked against it. If it does not match, no build is possible/warning gets thrown ( not sure what would be better).
If it match, the ID is taken as it is. So no more upper().
The default regex would allow upper characters, numbers and _ only.
This would higher the pressure in authors to always use the correct ID layout.
Would this support your use case?
Am 15. März 2018 21:52:36 MEZ schrieb LeviD03<EMAIL_ADDRESS>
Every identifier is force to uppercase when it is eventually stored in
the needs.json file. This creates a discontinuity between the ID in RST
and what the output contains. It causes difficulties when consuming the
needs.json file from external scripts. Consumers can't rely on the ID
in needs.json matching what is displayed in the HTML.
I suggest removing all the .upper() calls on IDs and links that way
the plugin is not modifying the original content.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/useblocks/sphinxcontrib-needs/issues/43

--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Your proposal sounds great. To be clear, my main requirement (no pun intended) is that the IDs should appear in the needs.json output as they do in the RST, assuming they match the needs_id_regex. That seems to be the intention of your proposed changes, so I'm on board!

Ok, implemented given solution in 0.2.0 and released it today:
http://sphinxcontrib-needs.readthedocs.io/en/latest/configuration.html#needs-id-regex
Keep me informed, if you find any bugs and or the solution isn't working for you.


Events with graph_func include actual output of graph_func

resolves #4260
Description
There are a handful of event classes that use a graph_func which are not actually logging the output of the function. There was a workaround for a mypy bug, but it doesn't seem to have been actually working.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change

The log output with the mypy workaround looks like: 16:14:54 | [ debug ] | before rename: <bound method RelationsCache.dump_graph of <dbt.adapters.cache.RelationsCache object at 0x10f298850>>


Refactor code

There are no big changes. These are what I changed:

Used black for code formatting.
Changed from usr_agent to USER_AGENT because of readability.

Seems good


Downgraded ruby version in gemfile

Description
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

Downgrading the ruby version to 3.1.1 will work for now as the cache is not being utilized here, we need to confirm the solution in the subsequent PR.

Conficts...


Allow Complex Parsing of Functions

This PR will determine the nested brackets "(" ")" and configure the Parser in order to parse Complex Function Parameters like to_char( a = b) and Named Function Parameters like trim(BOTH ' ' from 'foo bar ') ONLY WHEN the level of nesting functions is below a threshold = 7. Although this is a configurable Parser Feature.
This massively speeds up the parser. The whole NestedBracketsPerformanceTest Suite takes less than 3 seconds now, with 50! iterations for the concat test.
At the same time we can parse Complex  Expression Parameters for all Functions (but only when there is no deep recursion of more than 9 levels although this detail is mood because it would not work in anyway because of the slowdown).
Fixes issues #1190 #1103
This is a CLEAN PR handcrafted against the latest Upstream MASTER, containing only the minimal changes.

LOL! The CI server is too slow for the performance test timeouts.

Coverage increased (+0.001%) to 88.488% when pulling 42abed4fe7cbffaf91f5f9dd3c77f6e32c5f923c on manticore-projects:AllowComplexParsingClean into 86b613c72428e0cbf28dd84d87b19b1fd647efa0 on JSQLParser:master.

Building an upper boundary is quite a good idea. Could you please resolve the conflicts. I already merged your case when pr. My first changes for adaption the ValuesStatement are included as well. Maybe we could skip those MultiExpressionLists, because they are handles now by SimpleExpressonLists as well.

Merged the latest Master Branch.

So could you somehow better document, how the nesting depth is calculated or modified?

BTW I check your modifications. Since complex parsing is now allowed for functions I removed FunctionWithCondParams. But now your depth of seven is not enough for multiple tests. Unfortunatly.

So could you somehow better document, how the nesting depth is calculated or modified?

It is a simple count of the maximum Open Bracket (. If there are more than 7 Open Brackets we assume deep nesting and do not allow complex parsing.

BTW I check your modifications. Since complex parsing is now allowed for functions I removed FunctionWithCondParams. But now your depth of seven is not enough for multiple tests. Unfortunately I have problems for accepting one test.

Out of my head, I foresee a situation where you have a deep nesting on a function (without complex expressions) and one complex expression somewhere else (without deep nesting). That would fail because Complex Parsing and Deep Nesting are now mutual exclusive.
However, I kept experimenting when addressing the CASE WHEN expressions.
Instead of counting the Open Brackets, we can define a Nested Expression Counter in the Grammar File and increment it when ever we enter a Primary Expression and decrement it whenever we leave a Primary Expression. If this worked we would have much better granularity on when to give up Complex Parsing.
Please let me know your particular failing test case and I will have a look at it promptly.

@wumpz: You have modified the Brackets Threshold for Complex Parsing from 7 to 10. Unfortunately, the 7 has been selected for a purpose:
old duration 1565 new duration time 6873 for SELECT concat(concat(concat(concat(concat(concat(concat(concat(concat('A','B'),'B'),'B'),'B'),'B'),'B'),'B'),'B'),'B') FROM mytbl

It is the point when the performance impact LOOKAHEAD amplifies too much. This was also the reason why I have had defined timeout for the unit tests and I would like to recommend to leave it at 2000 and not to accept any change that breaks these constraints again. (2 seconds for parsing 1 single statement is too much already).
So, can we set the Threshold back to 7 again please? I am still working on a more fine granular solution, where the nesting is determined as per expression.

Understand. The problem is, you are calculating the "complexity" of a statement via running through the parenthesis. So you are taking parenthesises into account that have nothing to do with complex expressions. Somehow we should count the deepness within the productions. I don't know, if that is even possible and limit there to a level of 7 or 10.

It is not perfect, but it solves maybe 90% of the "real life" problems.
When my PRs are merged then I would like to count the real nesting in
the Primary Expression, same as I did for the CASE statement.
Problem is really that I have so many loose ends right now because the
acceptance is a bit slow.
On Wed, 2021-06-02 at 05:05 -0700, Tobias wrote:

Understand. The problem is, you are calculating the "complexity" of a
statement via running through the parenthesis. So you are taking
parenthesises into account that have nothing to do with complex
expressions. Somehow we should count the deepness within the
productions. I don't know, if that is even possible and limit there
to a level of 7 or 10.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Critics acknowledged. I try to improve.

Does this case counting work for lookaheads as well? If I remember right, this case deepness was never checked, or am I wrong?

On Wed, 2021-06-02 at 05:22 -0700, Tobias wrote:

Does this case counting work for lookaheads as well?

Yes.

If I remember right, this case deepness was never checked, or am I
wrong?
It was not needed for the cases but you see a similar preparation:

we have a global atomic LEVEL COUNT variable (this works well,
because the parser works strictly LL)
when entering a Primary Expression we count up
when leaving the Primary Expression we count down

This will give us the true nesting level.
We will stop for looking for Complex Expressions below a certain
threshold.
I am keen to implement and test and benchmark this better logic as soon
as everything else has been tied up.
After that we can also look again if JavaCC21 can help anything. or
not.
Cheers!


Allow change of mail_max_userip_connections through variable

I found that I was exceeding the default max logins per IP (which is 10) with 4 devices logging in at once from a home.  This allows for the config setting to be changed through an environment variable.

This is already supported using the dovecot configuration file in config/dovecot.cf. In fact if you check that file your exact use case is used as an example. Simply uncomment the line:
#mail_max_userip_connections = 50
That should work. If not we need to investigate why. We can't expose all the Postfix and Dovecot options with environment variables, so where it is possible it is better to use the configuration file overrides.
If this works for you please close the PR. If not let's discuss it! Regardless thanks for taking the time to get involved.

Thank you for the kind reply.
I was trying to make it so that the container wouldn't have to be rebuilt in order to implement this config change.
It makes sense to not expose all of the postfix & dovecot config options through environment variables.

@michaeljensen you don't have to rebuild the container, you simply need to restart it. See https://github.com/tomav/docker-mailserver/wiki/Override-Default-Dovecot-Configuration. Don't get confused by the "Override configuration" section, everything you need to do for this simple change is to uncomment the existing line in config/dovecot.cf and restart (or do it before starting). That is all.
In short your change should be supported without rebuilding the container by simply editing the bundled example file which is intended for just this kind of changes.

As this is still open, to be even more clear: in the installation right after the curl commands that download files, create a directory named config in the folder where you have the other files. Check the templates in https://github.com/tomav/docker-mailserver/tree/master/config and download the files you think you need and put them in config.
In your case you only need https://github.com/tomav/docker-mailserver/blob/master/config/dovecot.cf. Edit the file. In your case all you need to do is to remove the # for the line with mail_max_userip_connections. Save the file. Restart the container:
docker-compose down && docker-compose up -d mail
You are done. If that works we can close this? If not please ask. It should work.

I finally had some time to test out the dovecot.cf file and it works as expected.  I like that way of managing this config much better than what I was proposing in this pull request.
In the process, I discovered the user-patches.sh which seems like a good "catch all" for any other custom modifications.
Thank you for the info and the help on this!


Set up pypi publish with trusted-publishing

See

https://github.com/pypa/gh-action-pypi-publish/tree/release/v1/?tab=readme-ov-file#trusted-publishing
https://docs.pypi.org/trusted-publishers/adding-a-publisher/
maintainers please check https://pypi.org/manage/project/galgebra/settings/publishing/

This should fix and update the pypi release process, will merge when all CI turn green.


Fix: Remove samples replaced by Toggle between feature request modes

Description
This PR updates Toggle between feature request modes in Features category, to add redirect URLs and remove remaining screenshots and READMEs.
See PR #1095
Linked Issue(s)
common-samples/issues/3304
How To Test
Doc only change.
Links
Below are removed samples - they still exist on the developer website because we didn't remove their READMEs at the time of #1095 .

https://developers.arcgis.com/ios/swift/sample-code/service-feature-table-cache/
https://developers.arcgis.com/ios/swift/sample-code/service-feature-table-manual-cache/
https://developers.arcgis.com/ios/swift/sample-code/service-feature-table-no-cache/

It might be a good idea to have one of the doc team member to give an approval, to ensure the redirect_from pattern is valid.
@TADraeseke do you happen know who spotted this issue in the first place?

I'd recommend asking the relevant iOS doc team member to check. Is that @sbaskaran for iOS?

@TADraeseke @yo1995 I am not familiar with this, so I checked with Thad. He hasn't done this either, though it looks right.  (Can you also add him to this repo?)
I think we can test it locally this time. We can possibly just update our local config to pull this branch for samples

IMO if @ThadT gives us an OK here, we can proceed. I agree it's tricky to test this out.
As this is the first time we do redirects since the evolution of Citra (new dev website), we shall be meticulous this time to set the tone for future occurrences of redirect links.

I just tried testing this locally. I can see the 'toggle between feature request modes' sample page but the other three links return 404. It might be that I'm incorrect to assume we can test the redirects this way ... it works for guide doc links, but the samples might work differently. Let me see if John can offer some advice.

I created a preview branch to test the redirects.
The only change I made in this branch was to edit the config.yml file to bring in the samples doc from this branch: https://github.com/ArcGIS/afd-native-apis-doc/blob/sample-redirect-preview/documentation/ios/config.yml#L25
In the preview, the redirects aren't working as expected. In my local build, I got 404 errors, but in this case, it just loads the requested sample page (?).
https://sample-redirect-preview.sites.afd.arcgis.com/ios/swift/sample-code/service-feature-table-no-cache/

Thanks Thad for testing. I'm not sure what might be the problem. Maybe we need to bring in John or Pat's help.
In 2020 I used to be able to find Gatsby's source code, and at that time I saw the redirect function is just concatenating the site's base URL and the string in the redirect_from field of metadata json. But now I lost track of in which repo the src is hosted.

@yo1995 - I think you'll find the source code for the site here: https://github.com/ArcGIS/afd-core/tree/master/site/src. I think the redirects are handled by a gatsby plugin. Here's a PR for implementing redirects: https://github.com/ArcGIS/afd-core/pull/1157
We've put this on @jf990 radar and he's been looking into it.