M5 board stops reporting when reading temp from a 2nd chiptool app

Problem
M5 board stops Reporting when reading temp from a 2nd chiptool app
SHA: 28833946df933e042257208a4947a41206ea1bf3
Steps
Initial: load instance of iOS chiptool app on same iOS device (different name & bundle ids)

Pair M5 board to Chiptool App 1 - verify able to toggle light
Enable pairing mode, pair with Chip tool App2 using the provided pin code. Verify toggle light works
In Chip tool App 1, go to temp sensor. Setup up reporting : Min 1s, Max: 2s, Delta: 1C confirm M5 board send reports & when changing temp on M5 board it reflects in Chip tool App 1
In Chip tool App 2, go to temp sensor. Perform a read using the refresh option -> verify reads current temp sensor
In Chip too App 1, go to temp sensor. Verify its still receiving updates when modifying temp on the M5 board

In step 4 & 5, Looks like M5 board stops reporting after performing read from Chip tool App 2.
//See reporting happening every 1s on M5 board:
E (261307) chip[IN]: Sending encrypted msg 0x3ffe83d4 with MessageCounter:8800578 to 0x7AE396E0F22F31BB (1) at monotonic time: 260524 msec
E (261327) chip[EM]: Flushed pending ack for MessageCounter:12870440 on exchange 52809i
E (261337) chip[DL]: Long dispatch time: 124 ms, for event type 3
E (262147) chip[DMG]: Unblock report hold after min 1 seconds
E (263147) chip[DMG]: Refresh subscribe timer sync after 1 seconds
E (263147) chip[DMG]:  Sending report (payload has 15 bytes)...
E (263147) chip[DMG]: IM RH moving to [AwaitingReportResponse]
E (263167) chip[IN]: Prepared secure message 0x3ffca0ec to 0x7AE396E0F22F31BB (1)  of type 0x5 and protocolId (0, 1) on exchange 52810i with MessageCounter:8800579.
E (263177) chip[IN]: Sending encrypted msg 0x3ffca0ec with MessageCounter:8800579 to 0x7AE396E0F22F31BB (1) at monotonic time: 262391 msec
E (263187) chip[DMG]: Refresh Subscribe Sync Timer with max 2 seconds
E (263187) chip[DMG]:  ReportsInFlight = 1 with readHandler 0, RE has no more messages
E (263257) chip[EM]: Received message of type 0x1 with protocolId (0, 1) and MessageCounter:12870441 on exchange 52810i
E (263267) chip[EM]: Found matching exchange: 52810i, Delegate: 0x3ffceac8
E (263277) chip[EM]: Rxd Ack; Removing MessageCounter:8800579 from Retrans Table on exchange 52810i
E (263287) chip[EM]: Removed CHIP MessageCounter:8800579 from RetransTable on exchange 52810i
E (263287) chip[DMG]: StatusResponseMessage =
E (263297) chip[DMG]: {
E (263297) chip[DMG]: 	Status = 0x0,
E (263297) chip[DMG]: 	InteractionModelRevision = 1
E (263317) chip[DMG]: }
E (263317) chip[IM]: Received status response, status is 0
//Receive read request:
E (264987) chip[IM]: Received Read request
E (264987) chip[DMG]: ReadRequestMessage =
E (264997) chip[DMG]: {
E (264997) chip[DMG]: 	AttributePathIBs =
E (265007) chip[DMG]: 	[
E (265007) chip[DMG]: 		AttributePathIB =
E (265017) chip[DMG]: 		{
E (265017) chip[DMG]: 			Endpoint = 0x1,
E (265017) chip[DMG]: 			Cluster = 0x402,
E (265027) chip[DMG]: 			Attribute = 0x0000_0000,
E (265027) chip[DMG]: 		}
E (265027) chip[DMG]:
E (265037) chip[DMG]: 	],
E (265037) chip[DMG]:
E (265047) chip[DMG]: 	isFabricFiltered = true,
E (265057) chip[DMG]: 	InteractionModelRevision = 1
E (265057) chip[DMG]: },
E (265057) chip[DMG]: IM RH moving to [GeneratingReports]
E (265067) chip[DMG]: RE:Run Cluster 402, Attribute 0 is dirty
E (265067) chip[DMG]: Reading attribute: Cluster=0x0000_0402 Endpoint=1 AttributeId=0x0000_0000 (expanded=0)
E (265087) chip[DMG]: AccessControl: checking f=2 a=c s=0x701FF79093BC99E0 t= c=0x0000_0402 e=1 p=
(265097) chip[DMG]:  Sending report (payload has 38 bytes)...
E (265097) chip[EM]: Piggybacking Ack for MessageCounter:10618034 on exchange: 22347r
E (265107) chip[IN]: Prepared secure message 0x3ffca0ec to 0x701FF79093BC99E0 (2)  of type 0x5 and protocolId (0, 1) on exchange 22347r with MessageCounter:12763722.
E (265127) chip[IN]: Sending encrypted msg 0x3ffca0ec with MessageCounter:12763722 to 0x701FF79093BC99E0 (2) at monotonic time: 264338 msec
E (265137) chip[DMG]:  OnReportConfirm: NumReports = 0
E (265137) chip[DMG]:  ReportsInFlight = 0 with readHandler 1, RE has no more messages
E (265147) chip[DMG]: IM RH moving to [AwaitingDestruction]
E (265197) chip[DMG]: Refresh subscribe timer sync after 1 seconds
E (265197) chip[DMG]:  Sending report (payload has 15 bytes)...
E (265197) chip[DMG]: IM RH moving to [AwaitingReportResponse]
E (265207) chip[IN]: Prepared secure message 0x3ffca104 to 0x7AE396E0F22F31BB (1)  of type 0x5 and protocolId (0, 1) on exchange 52811i with MessageCounter:8800581.
E (265227) chip[IN]: Sending encrypted msg 0x3ffca104 with MessageCounter:8800581 to 0x7AE396E0F22F31BB (1) at monotonic time: 264439 msec
E (265237) chip[DMG]: Refresh Subscribe Sync Timer with max 2 seconds
E (265237) chip[DMG]:  ReportsInFlight = 1 with readHandler 0, RE has no more messages
E (265257) chip[EM]: Received message of type 0x10 with protocolId (0, 0) and MessageCounter:10618035 on exchange 22347r
E (265267) chip[EM]: Found matching exchange: 22347r, Delegate: 0x0
E (265267) chip[EM]: Rxd Ack; Removing MessageCounter:12763722 from Retrans Table on exchange 22347r
E (265277) chip[EM]: Removed CHIP MessageCounter:12763722 from RetransTable on exchange 22347r
E (266237) chip[DMG]: Unblock report hold after min 1 seconds
E (267247) chip[DMG]: Refresh subscribe timer sync after 1 seconds
I (268047) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (268047) all-clusters-app: editing attribute as integer: 56 (+)
E (268057) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f1fe
I (268057) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (268067) app-devicecallbacks: Unhandled cluster ID: 1026
I (268087) app-devicecallbacks: Current free heap: 57976
//Seems like reporting stops now, I was changing temp on M5 board and it wasn't reflecting on ChipTool app
I (268047) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (268047) all-clusters-app: editing attribute as integer: 56 (+)
E (268057) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f1fe
I (268057) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (268067) app-devicecallbacks: Unhandled cluster ID: 1026
I (268087) app-devicecallbacks: Current free heap: 57976
I (268247) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (268497) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (268497) all-clusters-app: editing attribute as integer: 57 (+)
E (268507) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f1ff
I (268507) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (268517) app-devicecallbacks: Unhandled cluster ID: 1026
I (268537) app-devicecallbacks: Current free heap: 57976
I (268697) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269097) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269097) all-clusters-app: editing attribute as integer: 58 (+)
E (269107) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f200
I (269107) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (269117) app-devicecallbacks: Unhandled cluster ID: 1026
I (269137) app-devicecallbacks: Current free heap: 57976
I (269297) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269497) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269497) all-clusters-app: editing attribute as integer: 59 (+)
E (269507) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f201
I (269507) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (269517) app-devicecallbacks: Unhandled cluster ID: 1026
I (269537) app-devicecallbacks: Current free heap: 57976
I (269697) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269797) all-clusters-app: Display awake but will switch off automatically in 30 seconds
I (269797) all-clusters-app: editing attribute as integer: 60 (+)
E (269807) chip[DMG]: Endpoint 1, Cluster 0x0000_0402 update version to 58b5f202
I (269807) app-devicecallbacks: PostAttributeChangeCallback - Cluster ID: '0x0402', EndPoint ID: '0x01', Attribute ID: '0x0000'
I (269817) app-devicecallbacks: Unhandled cluster ID: 1026
I (269837) app-devicecallbacks: Current free heap: 57976
//some time out errors
E (270237) chip[EM]: Retransmitting MessageCounter:8800581 on exchange 52811i Send Cnt 0
E (270237) chip[IN]: Sending encrypted msg 0x3ffca104 with MessageCounter:8800581 to 0x7AE396E0F22F31BB (1) at monotonic time: 269455 msec
E (272237) chip[EM]: Retransmitting MessageCounter:8800581 on exchange 52811i Send Cnt 1
E (272247) chip[IN]: Sending encrypted msg 0x3ffca104 with MessageCounter:8800581 to 0x7AE396E0F22F31BB (1) at monotonic time: 271457 msec
E (274247) chip[EM]: Retransmitting MessageCounter:8800581 on exchange 52811i Send Cnt 2
E (274247) chip[IN]: Sending encrypted msg 0x3ffca104 with MessageCounter:8800581 to 0x7AE396E0F22F31BB (1) at monotonic time: 273460 msec
E (276247) chip[EM]: Failed to Send CHIP MessageCounter:8800581 on exchange 52811i sendCount: 3 max retries: 3
E (277207) chip[DMG]: Time out! failed to receive status response from Exchange: 52811i
E (277207) chip[DMG]:  OnReportConfirm: NumReports = 0
E (277227) chip[DMG]: IM RH moving to [AwaitingDestruction]
E (282097) chip[EM]: Received message of type 0x1 with protocolId (0, 1) and MessageCounter:12870442 on exchange 52811i
E (282107) chip[EM]: Handling via exchange: 52811i, Delegate: 0x0
E (282117) chip[EM]: CHIP MessageCounter:8800581 not in RetransTable on exchange 52811i
E (282127) chip[EM]: Sending Standalone Ack for MessageCounter:12870442 on exchange 52811i
E (282127) chip[IN]: Prepared secure message 0x3ffe8484 to 0x7AE396E0F22F31BB (1)  of type 0x10 and protocolId (0, 0) on exchange 52811i with MessageCounter:8800582.
E (282147) chip[IN]: Sending encrypted msg 0x3ffe8484 with MessageCounter:8800582 to 0x7AE396E0F22F31BB (1) at monotonic time: 281359 msec
E (282157) chip[EM]: Flushed pending ack for MessageCounter:12870442 on exchange 52811i
E (282167) chip[EM]: Dropping unexpected message of type 0x1 with protocolId (0, 1) and MessageCounter:12870442 on exchange 52811i
E (282187) chip[EM]: Received message of type 0x10 with protocolId (0, 0) and MessageCounter:12870443 on exchange 52811i
E (282187) chip[EM]: OnMessageReceived failed, err = Error CHIP:0x00000070
E (282207) chip[EM]: Received message of type 0x10 with protocolId (0, 0) and MessageCounter:12870444 on exchange 52811i
E (282217) chip[EM]: OnMessageReceived failed, err = Error CHIP:0x00000070
E (282217) chip[EM]: Received message of type 0x10 with protocolId (0, 0) and MessageCounter:12870445 on exchange 52811i
E (282227) chip[EM]: OnMessageReceived failed, err = Error CHIP:0x00000070
E (289247) chip[EM]: Received message of type 0x2 with protocolId (0, 1) and MessageCounter:12870446 on exchange 9862r
Proposed Solution
<suggested fix, suggested enhancement>
reporting-stops-when-reading-from-2nd-client-chiptool-logs.txt
reporting-stops-when-reading-read-from-2nd-client-M5-logs.txt

@kean-apple Is this still being a problem?


fix: wait for port to be available before creating a dev server

When we run wrangler dev, we start a server on a port (defaulting to 8787). We do this separately for both local and edge modes. However, when switching between the two with the l hotkey, we don't 'wait' for the previous server to stop before starting the next one. This can crash the process, and we don't want that (of course). So we introduce a helper function waitForPortToBeAvailable() that waits for a port to be available before returning. This is used in both the local and edge modes, and prevents the bug right now, where switching between edge - local - edge crashes the process.
(This isn't a complete fix, and we can still cause errors by very rapidly switching between the two modes. A proper long term fix for the future would probably be to hoist the proxy server hook above the <Remote/> and <Local/> components, and use a single instance throughout. But that requires a deeper refactor, and isn't critical at the moment.)

Would it be worth considering using a different port for local mode?

I considered using a different port for local mode, but that would make development annoying, you'd have to open a fresh tab, whereas here you can just refresh the existing tab.

I considered using a different port for local mode, but that would make development annoying, you'd have to open a fresh tab, whereas here you can just refresh the existing tab.

Yeah that makes sense.


Unable to parse empty arrays with prettier 3.3.0

After upgrading prettier 3.3.0 to I get for the following error:
Error: Found "[" but: its sibling was not an indent Doc.:
[error]     at […]/node_modules/prettier-plugin-multiline-arrays/dist/printer/insert-new-lines.js:57:23
[error]     at walkDoc ([…]/node_modules/prettier-plugin-multiline-arrays/dist/printer/child-docs.js:28:10)
[error]     at […]/node_modules/prettier-plugin-multiline-arrays/dist/printer/child-docs.js:41:20
[error]     at Array.every (<anonymous>)
[error]     at walkDoc ([…]/node_modules/prettier-plugin-multiline-arrays/dist/printer/child-docs.js:40:18)
[error]     at […]/node_modules/prettier-plugin-multiline-arrays/dist/printer/child-docs.js:41:20
[error]     at Array.every (<anonymous>)
[error]     at walkDoc ([…]/node_modules/prettier-plugin-multiline-arrays/dist/printer/child-docs.js:40:18)
[error]     at insertLinesIntoArray ([…]/node_modules/prettier-plugin-multiline-arrays/dist/printer/insert-new-lines.js:17:30)
[error]     at printWithMultilineArrays ([…]/node_modules/prettier-plugin-multiline-arrays/dist/printer/insert-new-lines.js:419:15)

Example code which triggers it:
let errorMessages = [];

Code which works around it:
let errorMessages = [
  null,
];

Works fine without using prettier-plugin-multiline-arrays (except I won't have multiline arrays anymore).

Confirming this issue on empty arrays. Staying on<EMAIL_ADDRESS>for the meantime

The fix from @richardsimko has been published to npm in v3.0.6. Thank you so much @richardsimko for the PR! 💙


Issues with lisgd patch

I am encountering issues with the lisgd patch:
cd lisgd && git apply ../patches/lisgd.patch
error: corrupt patch at line 61

Looks like lisgd received an update and the patch got out of sync.
Fixed in commit 59e2a38f63d76cbb2d261911676a550f9d04053a by downgrading lisgd.


Define the logo

Today we are using a temporary icon in the README, we should create a proposal:

Be aligned with the name Doctor env
SVG if possible

Any suggestion is welcome, minimalist, 3d or anything else.

i would love to contribute assign it to me

Ohh, sure assigned, would be a pleasure to have your contribution!


81 - Implement Non Downloadable Experiment View

Issue Number
#81
The initial commit of this PR starts at 2c5b5c2.
Purpose/Implementation Notes

Based on the design, we'll implement the non-downloadable experiment view.

Implemented the non-downloadable experiment view on search results and experiment page's the samples table

Files related to this PR

[x] UI review w/ @dvenprasad  - please visit the latest here, thank you!
(After passing the UI review, @davidsmejia will be added to the reviewers.)

To view the implementation:
On the search results page, please toggle the checkbox for the hide non-downloadable experiments:

Types of changes
New feature (non-breaking change which adds functionality)
Functional tests
List out the functional tests you've completed to verify your changes work locally.
Checklist

[x] Lint and unit tests pass locally with my changes

🗒 As mentioned in 1:1, due to the changes made in the recent PRs (API integration for search, experiments, and samples (in progress) endpoints),  I’ll be closing any PRs that are no longer relevant. Since this implementation was updated during the API integration process in the search manager, I am closing this PR as well.


OCM-4257 | fix: doesn't check /labels for HCP

Related issue: OCM-4257
A validation to /labels for HCP clusters was recently added and call needs to be refactored to skip HCP clusters

/lgtm


feat: Add a calculator

Description of Change
Added a calculator in the math folder.

Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Relevant documentation/comments is changed or added
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] Sort by alphabetical order
[x] I acknowledge that all my contributions will be made under the project's license.

Notes: Tested with Visual Studio 2019.

Please update comments in the structured format like here - #807

Please update comments

Working on it.

Please update comments

Working on it.

Should be done now. 🙂

the cpplint auto checks are still failing - please rectify them

Working on it.

conio.h is not an ISO standard

Working on to use another alternative.

@kvedala, all issues have been fixed now.
Thanks for your review and comments! 🙂

Is there anything else that needs to be addressed?

ok. 👍
@mishraabhinn could you take a look as well. Thanks.

will go out the range of int

First, the datatype is float.
Second, IMHO, using the double operator may fix this.
Also, can you please re-explain that again?

@mishraabhinn can you run the code for the test case you mentioned?
@Panquesito7  Please remove lines 190-to-197

Please remove lines 190-to-197

Done.

@mishraabhinn can you run the code for the test case you mentioned?

@Panquesito7 Please remove lines 190-to-197

In general i was asking that if two number whose sum need to be obtained are really big like greater than 10^9 which is above range of int adding both of them can lead to memory overflow.
And there is no option i can add two number and the sum obtained can be divided by third number.
There is need of more functions in the program.

I think instead of asking for "number" menu,
the code could simply ask what operation would you like? (+-*/, ESC to exit):
The user can then press that. Then it becomes more understandable.
Also, would using double instead resolve your concern, @mishraabhinn

I think instead of asking for "number" menu,
the code could simply ask what operation would you like? (+-*/, ESC to exit):
The user can then press that. Then it becomes more understandable.
Also, would using double instead resolve your concern, @mishraabhinn

I agree @kvedala

Thinking more about it, I am not sure if this program contributes to any algorithm towards solving a mathematical formulation. This adds, subtracts, multiplies and divides - are they algorithms?

@kvedala shall we close this or improve?

@kvedala shall we close this or improve?

I propose we close and not accept this pr as it simply doesn't introduce any algorithm


Analytics - Logging incomplete 'Started Level' events

Example:
{
"_id" : ObjectId("549e78f802c17db20630fc4d"),
"properties" : {
"category" : "Play Level"
},
"event" : "Started Level",
"user" : ObjectId("532e9352192f4e8954acb24e"),
"created" : ISODate("2014-12-27T09:16:40.143Z"),
"__v" : 0
}

Hasn't occurred since 12/28.


Roadmap next major release (v2.0?)

At least the following things should happen before the next release. I think having a better integration with Enrise's team ensures code quality, process management and release cycles. For now this project is mostly maintenance and making sure everything is up to date with today's standards.

[ ] Resolve current tickets
[ ] Discuss other things to do for a major release
[ ] Rewrite tests
[ ] eslint instead of jshint

[ ] Update styling
[ ] Grunt & Travis

[ ] .editorconfig file
[ ] Test coverage integration
[x] Run travis with more modern versions of node

[x] Update package.json to support newer versions
[x] Drop old legacy versions?

[x] Update labels for better integration with the team
[x] Release minor version on NPM (1.3.0)
[x] Discuss receiving more control over the project so we can manage our team internally
[x] Review the commits that I made yesterday
[x] Update (dev)dependencies
[x] Update peerDependencies for compatibility with chai 3.0+
[x] Indentation: two spaces instead of tabs
[x] Fix the tests
[x] Merge PR's
[x] Update buttons and such in README
[x] Drop support for node 0.10
[x] Update bower.json

What about switching to https://github.com/epoberezkin/ajv ?

@JrSchild I think it'd be great if all projects under the chaijs org all follow the same standards. If you have a look at https://github.com/chaijs/type-detect or https://github.com/chaijs/deep-eql or https://github.com/chaijs/pathval you can see we where we're going with this. All these projects use the same lint config (eslint-config-strict), the same release management tools (semantic-release) and the same tooling (npm scripts). My ideal would be for every project to fall in line with that. Thoughts?

@Niklv thanks for the suggestion, we'll look into it.

Hi @keithamus.
With the latest release we synchronized node support (in Travis) with chai core. There is still some maintenance to do and the tests really need a rewrite. Including eslint is definitely something that we want to integrate in the future. Ultimately synchronizing with the chaijs standards is where we would like to go.

@thabemmz there is a benchmark https://github.com/ebdrup/json-schema-benchmark

@scottux No such plans.


Writer

Should have done this sooner. :p

[x] boolean
[x] byte
[x] sbyte
[x] ushort
[x] short
[x] uint
[x] int
[x] ulong
[x] long
[x] float
[x] double
[x] decimal
[x] DateTime
[x] DateTimeOffset
[x] Guid
[x] string
[x] encoded/escaped string
[x] byte array (base 64 data)
[x] Arrays
[ ] Object Graphs

Got all the primary writers done except for the membered/graph writer.  This is going to involve the type model, so should start working on the Configuration API for this now.


LoadDefaultLanguages Error

https://raw.githubusercontent.com/TheGarrysModCoderSquad/ultimatetech-addon-translations/master/default_ultimatetech_languages.json is not valid JSON

[ERROR] addons/arclib/lua/arclib/server/admin_menus.lua:220: bad argument #1 to 'pairs' (table expected, got nil)
  1. pairs - [C]:-1
   2. AddonAddSettingMultichoice - addons/arclib/lua/arclib/server/admin_menus.lua:220
    3. callback - addons/ultimate_tech/lua/ultimatetech/server/utcore.lua:15
     4. onsuccess - addons/arclib/lua/arclib/server/arcaddon_util.lua:77
      5. unknown - lua/includes/modules/http.lua:34

[01/07/17 23:21:10] Norfair00 [loopback] connected to the server.

Json is valid, what error ?

The util.JSONToTable function returned nil. This occurs when the string given isn't valid JSON. This could be an issue with github sending some sort of error page than the actual file. I will add http status checks in the near future.

Ok, Sorry for the inconvenience


Support loading miximo animations

As per https://github.com/semperai/amica/issues/25 added ability to load fbx. Only tested with basic skinless. Works nicely.

Yeah I was thinking about that too, exteing whole emote anim situation. And possibly different voice for different sentece, if one can get samples of angry, normal, bored and whatever. I was thinking of having something like alt system prompt that given response, we ask it to annotate sentences or something like that, not sure if that would work though.


Keep Athenz user domains lookup for 1min, per identity

@mpolden please review. @bjorncs @tokle FYI.
There is already some delay on Athenz' end, so adding another minute on our side shouldn't matter much? It would, however, make access control much faster, for all requests using Athenz for authorisation, and also reduce the number of calls we do against Athenz by a great deal.

Ah, I see there are other lookups we do, as well. Let me add more of this.

I don't think it matters much. The controller JDisc isn't redeployed and reconfigured, like regular applications. Would have to make its superclass extend AbstractComponent to achieve. @bjorncs, any thoughts?


Incorrect RunCommands Permission in page

https://learn.microsoft.com/en-us/azure/virtual-machines/linux/run-command
Under the Limiting access to Run Command section, the command is incorrect.
Microsoft.Compute/virtualMachines/runCommand/write should be runCommands.
The Windows version of this page is correct.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 792f4871-0d07-624f-7daf-02de97121e13
Version Independent ID: b70d481f-b351-bb38-cb49-1cda63422968
Content: Run scripts in a Linux VM in Azure using action Run Commands - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/run-command.md
Service: virtual-machines
GitHub Login: @nikhilpatel909
Microsoft Alias: erd

@paul-hugill
Thanks for your feedback! We will investigate and update as appropriate.


[npcollector] Fix source container ID not passed to payload

What does this PR do?
[npcollector] Fix source container ID not passed to payload
Related initial PR: https://github.com/DataDog/datadog-agent/pull/26345

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


migrate expressions & statements from autorest

This PR migrates the updates to the generator's expressions and statements from autorest. It also updates the existing SCM expressions to that of autorest's which including having to update to the System.ClientModel dependency to 1.1.0-beta.2 to pull in the new types.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Generator.CSharp


Term request: Zinc in soil package

same format as elements in misc and sediment packages
New term details
For us to assess a new term request we require the following details:
Term name -
Structured comment name - [a less than 20char no spaces version of the name]
Definition - [a clear and concise description of the term including ]
Expected value - [e.g. text or EFO and/or OBI etc...]
Value syntax - [e.g. {float} {unit}|{termLabel} {[termID]}|{text}|{timestamp} etc...]
Example - [provide and example value]
Preferred unit - [if appropriate]
Package(s) - [list any packages that should include the new term]

Additional context
Add any other context about the new term here.

Term name - Zinc
Structured comment name - zinc_conc
Definition - Concentration of zinc in the sample
Expected value - measurement value
Value syntax - {float} {unit}
Example - ?
Preferred unit - ?
Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil

@StantonMartin please can you check the above and provide an Example, and the Preferred unit ?
the GSC CIG will then discuss the term and decide if it should be added to the next release. The time scale for this is likely to slow for your use-case (this is something else we are looking at streamlining), but for immediate use you may wish to consider using the term "misc_param"

Term name - Zinc
Structured comment name - zinc_conc
Definition - Concentration of zinc in the sample
Expected value - measurement value
Value syntax - {float} {unit}
Example - ?
Preferred unit - ?
Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil

@StantonMartin please can you check the above and provide an Example, and the Preferred unit ?
the GSC CIG will then discuss the term and decide if it should be added to the next release. The time scale for this is likely to slow for your use-case (this is something else we are looking at streamlining), but for immediate use you may wish to consider using the term "misc_param"

Hi Chris,
Sorry I have not updated this. Regarding your example, here it is with the parameters filled in:
Term name - Zinc
Structured comment name - zinc_conc
Definition - Concentration of zinc in the sample
Expected value - measurement value
Value syntax - 27.3 mg/kg
Example -
Preferred unit - mg/kg
Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil
However, thinking through this carefully, I am wondering if this is the smartest way to do this... Every element on earth could potentially end up as a measured value, so why not list add a general term called Element to the standard. It could be something like:
Term name - Element
Structured comment name - element
Definition - An element found in the periodic table
Expected value - May be a long name with first level capitalized, or the periodic table two letter abbreviation
( eg Zinc or ZN) Value syntax - {value}{unit}
Example - 27.3 mg/kg
Preferred unit - mg/kg (may also take ppm)
Package(s) -hydrocarbon resources-cores, hydrocarbon resources-fluids/swabs, microbial mat/biofilm, sediment, water, soil
Another closely related term may be ion which would be the same as element but would be refer to the ion.
See:
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:29105
and
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:27363
we may also want to include a way to designate the isotope number to distinguish, for instance between Carbon 12, Carbon 13, and Carbon 14.


Update core.wcm.components dependency to 2.10.0

resolves #416

i'm wondering if it is also planned to update these two folders for new/updates components with each core component update:

https://github.com/adobe/aem-project-archetype/tree/master/src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components
https://github.com/adobe/aem-project-archetype/tree/master/src/main/archetype/ui.frontend.general/src/main/webpack/components

this latter is already missing some updates from previous core component releases, e.g. new css classes for the teaser subline.

This PR has meanwhile superseded by newer PR's (#448, #450, #455) bringing core components version to the latest,  2.11.0.
@stefanseifert  the components in ui.apps should be up to date, for the default styling CSS in the ui.frontend module I will create a new issue to add the missing ones.


Suggest: append build instruction in README.md

Suggest: append build instruction in README.md

$ go version
go version go1.7.1 darwin/amd64

$ go get -v all
github.com/golang/lint/golint
github.com/jcuga/golongpoll/examples/basic
github.com/kisielk/errcheck
github.com/klauspost/asmfmt/cmd/goimports
github.com/klauspost/asmfmt/cmd/gofmt
github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio
golang.org/x/tools/cmd/goimports
sourcegraph.com/sqs/goreturns
# github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio
../../../go/src/github.com/openshift/source-to-image/vendor/github.com/Microsoft/go-winio/file.go:45: undefined: syscall.Overlapped

@harobed Could you please elaborate on the build instructions that you need?
Issuing go get github.com/knes1/elktail will fetch elktail source and you can build it with go build.
Thanks


Add first set of MIDS 2 terms

Adds the first set of MIDS 2 terms to the harmonized datamodel

Collector
DateCollected
CollectingNumber
TypeStatus

Will ignore the Sonar test as the duplication is already minimized by adding all the logic in the parent. However the functions still need to be called that is what is duplicate. Don't see another way (yet) without losing the ability to create custom functions for the retrieval.


Ask for helpful feature for compatibility, changes in package.json for developers.

hello skynet-js developer,
Sorry about the title but I had no other idea for the title.
I'm trying to extend your repo "SkynetLabs/nodejs-skynet" with functions of "SkynetLabs/skynet-js" and make them compatible.
For the integration of the functions in "nodejs-skynet", it would be very helpful if I could access the original variables and functions.
It would also be easier to handle if there are changes in "skynet-js" in the future.
Here is my idea, so that you have access to all original variables and also original functions, which are exported from "skynet-js".
To do this, I inserted a few lines in the "package.json" of "SkynetLabs/skynet-js" in the "exports" area, and I was able to convert any original variable from "skynet-js" to "nodejs-skynet" to integrate with "require".
1. "exports" before:
"exports": {
".": {
"import": "./dist/mjs/index.js",
"require": "./dist/cjs/index.js"
}
2. "exports" my new:
"exports": {
".": {
"import": "./dist/mjs/index.js",
"require": "./dist/cjs/index.js"
},
"./*": "./dist/cjs/*.js",
"./mysky/*": "./dist/cjs/mysky/*.js",
"./skylink/*": "./dist/cjs/skylink/*.js",
"./utils/*": "./dist/cjs/utils/*.js"
},
It definitely works!
Would be very, very helpful, and a cool feature too.
You could then create better apps for the command line.
I would be happy if you integrate it. But I can also create a PR for the few lines, but only if you want it.
Let me know what you think of it.

I see. Can you make a list of what you need to implement get/setJSONEncrypted, so I can consider whether it makes sense to export those things?

Backward compatibility is important. But I don't understand what the change should trigger and why it's no longer backwards compatible.

We would be committing to keeping backwards compatibility for anything we export. A lot of those things are internal implementation details, and haven't had the same rigor in API design and consistency as the things we exported. Some of the internal stuff can change or be swapped out at any time e.g. if we changed out a dependency. So we are exposing things on an as-needed basis; if there is something in the code you think would be helpful, let me know and I'll consider it.

hello m-cat
I already have two working versions of "getJSONdecrypted/setJSONencrypted" with "tweetnacl" and the keys are generated with "genKeyPairFromSeed" of "skynet-js".
For the first two versions I used "nacl.sign" and "nacl.sign.open".
On the internet someone gave me an info and tip it would be better
to use "nacl.secretbox" and "nacl.secretbox.open". So I will try to make a third version.
I saw "secretbox" and "secretbox.open" being used in "skynet-js".
I have seen that there are also "nacl.box" and "nacl.box.open". That means I could also create a fourth version.
I just have to think about it and we have to decide in which format (e.g.: base64 or other) the encrypted data should be uploaded to skynet.
And whether the data on Skynet should be decryptable with a third-party app, so that the skylink can be downloaded and then decrypted on the client pc with a third-party app. Let's see.
Oh, I didn't make the request directly because of these "getJSONdecrypted/setJSONencrypted" functions, I actually wanted to integrate "loadMySky".
I had several problems with the integration, since I saw that "mysky" has a subfolder, and thought I'd approach the problems a little differently than usual.
I then wanted to port "loadMySky" and would have needed some original variables.
But I gave up and put it back.
I don't think it's that important anymore for the time being, because I always find the backwards compatibility of apps important and because you offered me to let me know if I might need things to establish compatibility.
I'll let you know when I have a new suggestion.
Thanks.
I think you can close here.

I think you can close here.

Sure, thanks as always for the issue. 👍


automatic failover is not happening

Im using a mysql topology like below.
mysql1
|-----> mysql2
|-----> mysql3
I want to auto failover to mysql 2 or 3 if the mysql 1 went down. So on mysql1, I have stopped the mysql service. But the autofailover didn't happen. Then In the WEB UI I did force failover.
Then the failed node has been evicted from the cluster and mysql2 became the new master.
mysql2 --> mysql3.
My questions are

Auto failover didn't happen. What should I do to make it work?
If we solve the above question, how the existing slaves will start replicating from the new master.
 Affected replicas: {countSlaves}'> /tmp/recovery.log"
  ],
  "PreFailoverProcesses": [
    "echo 'Will recover from {failureType} on {failureCluster}' >  /tmp/recovery.log"
  ],
  "PostFailoverProcesses": [
    "echo '(for all types) Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' > /tmp/recovery.log"
  ],
  "PostUnsuccessfulFailoverProcesses": [],
  "PostMasterFailoverProcesses": [
    "echo 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Promoted: {successorHost}:{successorPort}' >  /tmp/recovery.log"
  ],
  "PostIntermediateMasterFailoverProcesses": [
    "echo 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' > /tmp/recovery.log"
  ],
  "CoMasterRecoveryMustPromoteOtherCoMaster": true,
  "DetachLostSlavesAfterMasterFailover": true,
  "ApplyMySQLPromotionAfterMasterFailover": true,
  "MasterFailoverDetachSlaveMasterHost": true,
  "MasterFailoverLostInstancesDowntimeMinutes": 0,
  "PostponeSlaveRecoveryOnLagMinutes": 0,
  "OSCIgnoreHostnameFilters": []
}

1. Auto failover didn't happen. What should I do to make it work?
@SqlAdmin the logs are our friends, and the web interface can also tell us a lot.
For example, the logs should tell you that a failure is detected, and they should tell you whether or not orchestrator intends to fail over and if not, why not.
According to your configuration automatic failover should kick in. But possibly your have globally disabled recoveries.
In the below example screenshot, you can see the following:

failovers globally disabled (empty heart icon in status bar)
master recoveries enabled for this cluster (blue heart on the left)
intermediate recoveries disabled for this cluster (gray empty heart on the right)

Or use command line to know if recoveries are enabled or not:
orchestrator-client -c check-global-recoveries
disabled

To get a better understanding of your cluster, instead of investing your precious time in drawing:
mysql1
|-----> mysql2
|-----> mysql3

...please do: orchestrator-client -c topology -alias <cluster-alias>, to get something like:
shlomi-oct:20192   [0s,ok,5.7.17-log,rw,ROW,>>,GTID,P-GTID]
+ shlomi-oct:20193 [0s,ok,5.7.17-log,rw,ROW,>>,GTID,P-GTID]
+ shlomi-oct:20194 [0s,ok,5.7.17-log,rw,ROW,>>,GTID,P-GTID]

which gives some more information about your cluster. Could you do that, please?
2. If we solve the above question, how the existing slaves will start replicating from the new master.
It seems like that's what happened, correct? You got mysql2 -> mysql3 so there's nothing more to be done. This is taken care of by orchestrator and is the main logic of a failover.
3. How can I prevent mysql3 perform any failover? (i don't want this to be a master at any situation).
https://github.com/github/orchestrator/blob/master/docs/deployment.md#adding-promotion-rules

Hi shlomi
Thanks for your response. Just need a clarification about my question 2.
I have manually did force failover on the web UI, do mysql2 promoted as master and mysql3 start replicating from mysql2.
Will the same thing happen if auto failover triggers?
I'll recretae the setup once again and test it.

Will the same thing happen if auto failover triggers?

Yes. It's the same flow, just that the triggering was manual in your case.

Hello Shlomi,
I have configured the complete setup from the scratch. Now I stopped the mysql1 and then mysql3 promoted as a new master. But in the Web UI, then mysql2 is trying to replicate from mysql1.
I didn't start replicating from the new master.

from /tmp/recovery.log
Detected DeadMaster on bhuvi-1:3306. Affected replicas: 2
Will recover from DeadMaster on bhuvi-1:3306
Recovered from DeadMaster on bhuvi-1:3306. Failed: bhuvi-1:3306; Promoted: bhuvi-3:3306
(for all types) Recovered from DeadMaster on bhuvi-1:3306. Failed: bhuvi-1:3306; Successor: bhuvi-3:3306

I have identified the issue, I enabled GTID but not using it.
I referred to this: Issue
Thanks a lot for your help.


Implemented pathway conditions and adjusted tests

Conditions in PathWayConditions can now get created, edited and deleted independent from LearningSpaces.
In terms of connecting objects within the whole path, conditions behave similarly to learning spaces. The only difference is that learning spaces may have only one inbound object while conditions may have any number of inbound objects.
Like dragging learning spaces, dragging conditions can be undone and redone.
In addition to learning spaces, learning pathways and pathway conditions can now also be selected in order to delete or edit them.
To see which object is currently selected, the selected object is marked by a larger border. The name of the description of the object in the view is omitted for this reason.
The hitbox of the path goes beyond the acutal shape to make it easier to click on.
New Rightclick Menu for PathWayCondition, that can be used for edit and delete.
Learning Spaces can now get opened by double click.
Double click on pathway condition changes the condition either from AND to OR or from AND to OR.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

707 of 745 (94.9%)  changed or added relevant lines in 38 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 94.623%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

Presentation/PresentationLogic/LearningWorld/LearningWorldPresenter.cs
114
115
99.13%

AuthoringTool/CachingMapper.cs
9
11
81.82%

Presentation/View/LearningPathWay/PathWay.razor
20
22
90.91%

Presentation/Components/PullablePath.razor
4
7
57.14%

Presentation/Components/RightClickMenu/RightClickMenu.razor
0
3
0.0%

Presentation/PresentationLogic/LearningSpace/LearningSpacePresenter.cs
0
3
0.0%

Presentation/View/LearningPathWay/DraggableObjectInPathWay.razor
18
21
85.71%

Presentation/View/LearningPathWay/DraggablePathWayCondition.cs
5
15
33.33%

Presentation/View/LearningPathWay/DraggableLearningSpace.cs
6
17
35.29%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
6673

Relevant Lines:
6877

💛  - Coveralls


Relicense engine to MIT/MPL/LGPL?

Right now the engine is under GPLv3, while the content repo is under MIT.
Personally, I want the possibility for closed source codebases like Goon to exist. While I would of course not wish the engine to have closed source forks (or, well, forks at all, but that's besides the point), the GPL is extremely viral when it comes to linking and honestly too dangerous. Or at least I want to rule out the possibilities of GPL-related drama in the future as peace of mind.
GNU's FAQ pretty much implies that under our current GPLv3 engine license, the GPL would be viral enough so that content also gets the terms of the GPL applied. This is obviously a problem with my desire to allow closed source codebases. For what it's worth, I checked the license text (but am not a lawyer) and can't see a direct mention of many of the requirements listed in the FAQ, but I still want to play it safe and avoid drama/headaches.
So, my suggestion is we re-relicense the engine to MIT or MPL (either is fine by me). This would apply to all future commits (and I at the very least would retroactively relicense my code). While this doesn't technically prevent us from getting drama'd because we still have the old code under GPL, this will still be a nice peace of mind for me personally, and if it comes to it we could later put in the effort to clean room and replace the GPL code with MIT.
Thoughts?
Edit: I can't believe I forgot about the LGPL. I believe LGPL might work great for our purposes too.

thog don't care

👍 Vote for MIT/MPL.

I would personally prefer the license be MIT.

I submit this proposal.
http://www.wtfpl.net/
It goes like this.

It is perfect for a game like SS13.

👍 MIT/MPL

hey calling contributor gang, are you okay with relicense?
@psykzz @volundr- @harikattar @YotaXP @spoogemonster @ComicIronic @h3half @gbasood @N3X15 @Szunti @RednoWCirabrab @BGare @wixoaGit @NickPowers43 @Centronias @Cyberboss @BobdaBiscuit @patrikturi @kalanosh @digitalic @PJBot @deathrat @tkdrg @RemieRichards @DamianX @KroshkaMu @nullarmo @Serkket @SignalWalker @avghdev @UristMcDorf @theOperand @dylanstrategie @actioninja @Pangogie @johnku1 @thatrandomcanadianguy

I'm okay with anything that's not retardedly viral like GPL and allows for closed source/commercial use.

I'm good with MIT.

New consideration: LGPL. It's fine for allowing closed source content repos, but the engine still has to be open (which is the perfect scenario).

LGPLv3 it is then.

Sounds good to me.

Whatever license you feel is appropriate.
On 2/7/2019 5:17 AM, Quantomicus wrote:

Sounds good to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/space-wizards/space-station-14/issues/732#issuecomment-461414740,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGt-WJMBo6RoeyNkwsQbsY8R2cVekGDks5vLCdzgaJpZM4alN2_.

I had only a couple of lines, which were removed since. I would be fine with your choice anyway.

I'm okay with whatever you choose
On Thu, Feb 7, 2019 at 2:20 PM Szunti<EMAIL_ADDRESS>wrote:

I had only a couple of lines, which were removed since. I would be fine
with your choice anyway.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/space-wizards/space-station-14/issues/732#issuecomment-461560663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC0G4qeikqyTrTww8c1WmTNIO1OiWZaWks5vLHxtgaJpZM4alN2_
.

Reply to this email directly, view it on GitHub
https://github.com/space-wizards/space-station-14/issues/732#issuecomment-461373575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC0G4tj9aEQdJw2zPXkgYG0e5uPDIcgAks5vLAYigaJpZM4alN2_
.

Fine for me. I have contributed on the SFML engine, which is already replaced by Godot I think.

I'm okay with whatever you choose

I think I contributed two to three lines? Feel free to relicense them as you please.

Oh lawd I'm a contributer now ? Uuuh, good for me fam

@kyrahabattoir There aren't any sane GPL incompatible licenses for software AFAIK, and I'm definitely not gonna write my myself. While yes I definitely don't want a crazed mso forking the engine as AGPL I don't think there's anything we can against that.
@psykzz We should be fine with LGPL though I can understand where you're coming from. It's basically "absolute safety but somebody can make a closed source fork", and I'm not sure which of those is better.

Something I'm reconsidering about the LGPL is the fact that it puts a distinction on static vs dynamic linking. I'm really against this because those are technical reasons that should be disconnect from the license in my opinion. While it's maybe far fetched, if we were to write all kinds of hacky inlining code manipulation for performance this could end up being problem, maybe. Again it's quite far fetched but it's an example.

@PJB3005 It also seem to brush over languages/environment that simply are not capable of providing that distinction.

@kyrahabattoir the reason for this distinction is that you should be able to provide drop-in replacements of an LGPL library even if the program is proprietary. Now, you could theoretically do this by providing object files TOO so you can re-link the static binary but yeah uh... I don't think there's any program doing that and I'd rather drop LGPL libraries than deal with that.
Now granted with C# this is mostly irrelevant because of how assemblies work, but that doesn't mean it makes me personally OK with the license.

Honestly MIT is the best case for me
https://tldrlegal.com/license/mit-license

A short, permissive software license. Basically, you can do whatever you want as long as you include the original copyright and license notice in any copy of the software/source.

I vote MIT

Since I don't want to stall this any longer, I'm just gonna go with MIT.

Done, 010d32424a1c571f54b456918c7bd9dcb33deca6


Bump default KUBE_BURNER_IMAGE for kube-burner workload

Description
Interim solution as we should try to replace the hard coded version with a stable tag.
Fixes

kube-burner bug fixes around Elasticsearch (https://github.com/cloud-bulldozer/kube-burner/releases/tag/v0.14.3)

LGTM


AKSamplePlayer crashes in the simulator

Using the Recorder iOS example I can build and run the project in both the simulator and on any iOS device with no issues. However, if I replace the AKAudioPlayer in the project with an AKSamplePlayer the project runs on iOS devices but crashes in the simulator. Even if I just initialise an AKSamplePlayer object with a valid file but do nothing else, it crashes on initialisation, pointing to a problem in ftbl.c in sp_ftbl_init
at line 18:
ft->lobits = log2(SP_FT_MAXLEN / size);
I get the error below.
Thread 1: EXC_ARITHMETIC (code=EXC_I386_DIV, subcode=0x0)
A division by zero error? Where size is 0?
This doesn't occur on an iOS device. Just the simulator. The same problem occurs in my own project, which makes extensive use of AKSamplePlayer.
Any idea why it wouldn't work in the simulator but work fine on any and all iOS devices tested?

THanks for pointing this out.  My notification of new issues was broken so I didn't see this until now, but will look into it.

Can you share your code where you replaced the player with a sampleplayer? They are pretty different so I'd like to see how they're being built etc.

Closed until further information received.

Below is the only modification I make to the Recorder iOS demo app to get a crash on the simulator. ViewController.swift line 70 onward.
// Will set the level of microphone monitoring
micBooster.gain = 0
recorder = try? AKNodeRecorder(node: micMixer)
if let file = recorder.audioFile {
// Here we're just trying to initialise a sample player object with a file
let samplePlayer = AKSamplePlayer(file: file)
// original code
player = try? AKAudioPlayer(file: file)
}
player.looping = true
Apologies for not sharing this code sooner.


adding permissions for tags.multi_add

update readme with permissions statement
Description
adding permissions and updated Readme
Issues Resolved
#141
Contribution Check List

[x ] All tests pass.
[ ] New functionality includes testing.
[ x] New functionality has been documented in the README if applicable
[ x] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add a changelog

  Generated by :no_entry_sign: Danger


fix the escaping

If input string contains one of the \ or line terminators, the result become 'undefined'

@Ridwy Thank you for your pull request.
Would you please write some tests for these characters?
After that, I'll merge this pull request :smile:


New app navigation, components and updated routing

This PR introduces new side menu navigation to the app
A side drawer has been added. It can be toggled using a menu button at the top left.
The dashboard, create members and modify members fields are currently clickable.
Everything after the login page is now inside the HomeComponent. The app structure is like so:
HOME COMPONENT => CHILD COMPONENTS { DashboardComponents, ManageTeamsComponent, AuditComponent, etc.. }
The default (empty)  route is now the home component.
As the default route was used for the signin/login page, a new 'login' route was created as a replacement
Child routes of the home component are all selectable side menu options.
The empty route redirects to the dashboard component by default.
This route still cannot be accessed unless authenticated.
Added a toolbar and made the layout responsive
I followed the guidlines for the layout from the angular docs:
https://material.angular.io/components/sidenav/overview

Thank you for addressing my comments.
Everything looks good, I will merge and we can discuss where we go from here.


docker-compose proxy returning 503 for every request

Hi I have the following docker-compose.yml file
version: '2'

services:
  nginx-proxy:
    image: jwilder/nginx-proxy
    container_name: nginx-proxy
    ports:
      - "80:80"
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
  elasticsearch:
    build: elasticsearch/
    ports:
      - "9200:9200"
      - "9300:9300"
    environment:
      ES_JAVA_OPTS: "-Xms1g -Xmx1g"
    networks:
      - docker_elk
  logstash:
    build: logstash/
    command: -f /etc/logstash/conf.d/
    volumes:
      - ./logstash/config:/etc/logstash/conf.d
    ports:
      - "5000:5000"
    networks:
      - docker_elk
    depends_on:
      - elasticsearch
  kibana:
    build: kibana/
    volumes:
      - ./kibana/config/:/etc/kibana/
    ports:
      - "5601:5601"
    networks:
      - docker_elk
    depends_on:
      - elasticsearch
    environment:
      - VIRTUAL_HOST=kibana.local
      - VIRTUAL_PORT=5601
networks:
  docker_elk:
    driver: bridge

that produces the following nginx.confg
# HTTP 1.1 support
proxy_http_version 1.1;
proxy_buffering off;
proxy_set_header Host $http_host;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $proxy_connection;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $proxy_x_forwarded_proto;
proxy_set_header X-Forwarded-Ssl $proxy_x_forwarded_ssl;
proxy_set_header X-Forwarded-Port $proxy_x_forwarded_port;
# Mitigate httpoxy attack (see README for details)
proxy_set_header Proxy "";
server {
        server_name _; # This is just an invalid value which will never trigger on a real hostname.
        listen 80;
        access_log /var/log/nginx/access.log vhost;
        return 503;
}
# kibana.local
upstream d8db1a3f45ad8b864545f522da2521974e07e8c9 {
}
server {
        server_name kibana.local;
        listen 80 ;
        access_log /var/log/nginx/access.log vhost;
        location / {
                proxy_pass http://d8db1a3f45ad8b864545f522da2521974e07e8c9;
        }
}

there is no problem with kibana as I can browse to it fine via localhost:5601.
both curl localhost and curl -H "Host: kibana.local" localhost result in a 503.
Can anybody provide an advise on how can I troubleshoot this as it pretty much follows the example. I have tried this both on docker for mac and a docker installed on ubuntu. Help greatly appreciated.
PS I have noticed that the proxy_pass is missing a port number however if that was the problem I would imagine that would result in a 502 and quite a tricky one to test without making major changes to this container.

my fault - hadn't joined the nginx proxy to the same network


Improving indexing of solar weather file based on dt in input .yaml file

This pull request improves the way that solar_pysam.py selects data from the input solar weather file. The input solar weather file contains timeseries weather data at a temporal resolution that may or may not be the same as dt in the input .yaml file. This pull request ensures that solar_pysam.py is selecting weather data at the correct timestamp. For example, if the input solar weather file contains data at every 0.5 second, but dt = 1.0 s in the .yaml file, the solar module will select data at every second after the timestamp of the first row of data.
If dt is not equal to or a multiple (>1) of the temporal resolution in the input solar weather file, a warning will print to the hercules log file.
This pull request does interpolate input data if dt is smaller than the temporal resolution in the input solar weather file. This interpolation should happen outside of hercules as part of pre-processing. An example of this pre-processing is included in example_case_folders/07_floris_standin_and_solar_pysam/read_solar_precursor_data.ipynb.
I have also improved the handling of timezones and added a warning that timezone must be included in the input solar weather file timestamps.
Also included are the input weather files from the ARM experiment and from the Flatirons campus, which were used for testing.

All tests are passing locally.

All tests are passing locally.

Thanks @brookeslawski ! See this pull request for attempts (which were ultimately unsuccessful) to get these failing tests to clear. For the time being, we'll just ensure the tests pass locally.

Per Misha's suggestion, added a verbose flag in the SolarPySAM module to toggle on and off the print statements used for debugging. Re-ran tests and they all pass locally.


Feature/laravel 9 support

Thank you for the contribution @ZeoKnight! Will look on it to merge ASAP.

Nope, just testing old versions in travis

@ZeoKnight merged, I'll add tests to GitHub Actions and make a new release

Adding tests took more time than expected:

https://github.com/cybercog/laravel-ban/pull/83

Laravel Ban v4.7 has been released! 🎉


Build a simple component direction-links/src/js/angular.js in angular

Is there any information to go with the status changes in this issue?
It went to QA then closed but there's no information on what was done or not done and it's not linked to any merged pull requests.

Thanks @rooby for noticing, this issue was related to some experimentation we were doing in angular.  I hope to have more information on this soon.


HAWQ-1396. Add more test cases for querying external table via PXF wi…

…th Ranger enable.
include:

add HDFS/Hive/HBase test cases.
add a policy_helper class for add/delete policy conveniently, don't need write policy json file manually now.
some ranger tests can be run parallelly.

@linwen @zhangh43 @stanlyxiang @wcl14 help to review, thanks.

Feature-test failed when TestHawqRanger.PXF* tests run parallelly(other ranger tests run serially). Seems they conflict with TestHawqRanger.Deny* tests.
So all ranger tests still run serially in this PR, and I will open a new Jira to parallel them in future.

Now ranger pxf tests are running parallelly, I have tested.

+1

merged.


"Failed to start API Mocking. Running cleanup tasks. 🛑 Cannot read property 'stop' of undefined" on amplify mock api when GraphQL resource does not exist

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm install -g
If applicable, what version of Node.js are you using?
v16.18.0
Amplify CLI Version
10.2.3
What operating system are you using?
Windows11
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
Not applicable
Amplify Commands
Not applicable
Describe the bug
I would like to run mock, but I don't know why the following error occurs.
Failed to start API Mocking. Running cleanup tasks.
Cannot read property 'stop' of undefined

There is no mention of "stop" in the source code.
I also checked that java is installed
openjdk version "1.8.0_342"
OpenJDK Runtime Environment Corretto-8.342.07.3 (build 1.8.0_342-b07)
OpenJDK 64-Bit Server VM Corretto-8.342.07.3 (build 25.342-b07, mixed mode)

I ran the following script and tried downgrading, but the result did not change.
 npm install -g<EMAIL_ADDRESS>Can someone please tell me how to do this?
Expected behavior
To establish mock server
Reproduction steps
amplify mock
Mock Storage endpoint is running at http://localhost:20005
Failed to start API Mocking. Running cleanup tasks.
🛑 Cannot read property 'stop' of undefined
GraphQL schema(s)

# Put schemas below this line

Project Identifier
6ea600256fcbbb34dd05176719393d18
Log output

# Put your logs below this line

Additional information
No response

Hey @maro0217 :wave: thanks for raising this! I see you're using an older version of Java (1.8.x), do you also experience this issue after updating Java to the latest version? https://jdk.java.net/19/

@josefaidt
Thank you for helping me. I tried the following step.

Installed amazon correto 19. Nothing changed
Installed amazon correto 18. It was fixed for a moment. Next time, mocking was failed(Cannot read properties 'includes' of undefined)
Downgrade amplify/cli 10.2.3 → 7.6.13 according to #5678 issue. But mocking was failed(CAnnot read properties 'stop' of undefined)
https://github.com/o-inc/coteam2/issues/5678

Does installing with zip change anything?

In my case I ran into the same error message due to a simple mistake.
In the configuration of Multiple frontends, in the frontend project that does not update (only amplify pull and do not amplify push), I got the same error when running amplify mock api.
Mocking worked for a backend project (amplify push) that built an API.
My working environment
os: macOS 12
nodejs: v16.18.0
amplify-cli: 10.3.0
java:
openjdk version "11.0.17" 2022-10-18 LTS
OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 11.0.17+8-LTS)
OpenJDK 64-Bit Server VM Corretto-<IP_ADDRESS>.1 (build 11.0.17+8-LTS, mixed mode)

Hey folks given the duplicate report here I'm going to mark this as a bug for mock to improve the messaging when attempting to run amplify mock api when the GraphQL API definition and schema do not exist.

@jjkuga Thanks for your help. It includes the backend definition and schema for the API.

Hello @maro0217, wanted to follow up on the last comment.

It includes the backend definition and schema for the API.

Was a backend GraphQL API added and you are experiencing a similar issue as well?


Missing c++ compiler requirement

Reppy is not a pure python project. It would be helpful if the readme listed the extra compiler requirements (for all relevant operating systems, and with links) in the installation section.

Could you give me examples of such build requirements for other projects? I'm not sure exactly what you are asking for in the README. Also, if you happen to know the answer already, I'm happy to take a pull request.

For examples. "Requires a fully compliant c++11" environment. I have reports it fails to properly compile on OSX (including the latest version).
unordered_map is used, which is in the c++11 spec.


Extract and expose the build Flink args logic

Hi,
The reason for this is that I want to use the Operator to manage the Flink clusters, but I have some special business logic for the jobs.
So that I need to build and manage the jobs (PodSpec) by myself.
For the purpose to reuse the code as much as possible, I start to extract some logic into separate functions and expose as public.
On the other hand, I think this should also be beneficial for unit testing.

Hi, @haoxins I would like to understand your use case better are you using the operator as a lib? what kind of logic do you want to add?

I use this operator both as lib and operator installed in the cluster.
I need add versioning logic for my jobs and without events lost.
And I still need to run multi jobs within the same session cluster to reduce the cost.
I want to use this operator to manage the session clusters but manage the jobs by my operator.


Refactor Sampling Strategies to JS (Which sentences should be sampled in BWS, before step 3)

TODO

[ ] refactor max_uncertainty_sampling
[ ] refactor max_density_sampling

[ ] NPM package for Kernel Density Est. Install https://github.com/uwdata/fast-kde-benchmarks

Python code

https://git.zdl.org/wuhn/evidence-sampling-strategies-pseudocode/src/branch/master/sampling_strategies.py

Notes

features: the input data
scores: model scores

don't add more algorithms at this point


Shellcheck fails with current ethd script

It is impossible for me to change anything in ethd as the pre-commit hooks fail due to errors in pre-existing code. The error message is the following:
Test shell scripts with shellcheck..........................................Failed
- hook id: shellcheck
- exit code: 1

In ethd line 1307:
    __path=''
    ^----^ SC2034: __path appears unused. Verify use (or export if used externally).

In ethd line 1310:
        __prysm=1
        ^-----^ SC2034: __prysm appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- __path appears unused. Verify use...

The lines in question seem to be remnants of a non-finished wagyu implementation from 19 months ago. They seem not to be needed anymore. Can I delete them?

Yeah go ahead, they serve no purpose now

#1493 should close this


provide animation example

I wanted to create this PR to ask a question and hope that I can assist on implementing a fix.
It appears as though the magic byte to clear a screen \x0c doesn't render images after clearing. I can't find any references for IMAGE or \x0c in the code base.

@googlebot I signed it!


Wrap around monitors vertically

First of all I really appreciate this app for the main unsnag option. But I also liked the wrap around function too. When I'm using the trackpad it comes in real handy that I can just go the opposite way to reduce the travel distance(trey icon to start menu for example). It;s just that my current set up is my laptop on the bottom and the secondary monitor above the laptop and I would like to wrap around the displays vertically as well. I've searched for some other freeware options but none of them supports multi monitor setup so they were kinda pointless to me. Feel free to point out if I'm wrong and this app can already do that.

You are correct, just tested (stacked my monitors in my config) just to double check and it indeed only ever wraps horizontally and not vertically.
@GrantMoyer from what you can tell, would that be easy to implement?

Is it possoble to add vertical wrapping? I have 2 4k displays and 1 FHD below, so it takes a while to jump from top of any big screens to laptop. With the vertical unsnag it'd be mor convinient.


Revert "minijail: use pid namespace"

This reverts commit efd315d1cc9287b3dd4e7755d040a97e16d143d0.
When launching multiple containers in parallel, libc can
deadlock when using pid namespaces. The root cause is still
under investigation, but all threads end up waiting on a futex.

I would expect this change to touch the minijail module only. Why are there changes at all at the tests? Those can't be related to the pid ns.

@flxo, the removal of run_as_init() in minijail changes the expected exit status of some containers in the tests. This is because now we get the exit status of the actual process instead of the fake init. For example, we should expect a Signaled with SIGABORT in the case of the crashing containers tests instead of some ExitCode.

@flxo, the removal of run_as_init() in minijail changes the expected exit status of some containers in the tests. This is because now we get the exit status of the actual process instead of the fake init. For example, we should expect a Signaled with SIGABORT in the case of the crashing containers tests instead of some ExitCode.

Ok. Got it. But shouldn't the test container then exit always with the same result? See my comment above.

@pclesr closing this pr because the main patch got its way to master by other means and what remains makes no longer sense.


CSP compliant docs

This PR addresses #12498 by updating the documentation to align with CSP compliance.

Working on the three other required changes as well, will mark ready to merge when I'm finished!

Please check at your convenience @gasman, static keyword has been made explicit and title gen docs for files and images has been merged. Need feedback if changes to methods are needed or if I should continue to keep them seperate.

Tested changes locally as well

Thank you for your patience, I'll complete all the changes and ask for a review soon. Could I ask for some guidance on what you meant by the third point of the issue @lb- ?

I've completed all the points on the issue now incorporating all the feedback, please let me know if anything else is needed.
I went and replaced mark_safe usage in the docs/reference/hooks.md with format_html since I caught them but this was not mentioned in the issue originally so let me know if it needs to be reverted.

Thanks for all your help and patience, I'll get better and make more meaningful contributions in the future!


Fix RBAC names and mounts

Signed-off-by: Adrian Chiris<EMAIL_ADDRESS>

trivial fix to yaml. no code changes. merging.


jicofo: 1.0-1062 -> 1.0-1075

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jicofo is: A server side focus component used in Jitsi Meet conferences
meta.homepage for jicofo is: https://github.com/jitsi/jicofo
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0-1066 in filename of file in /nix/store/81iw864ddfs34cyky49g96l321lv73mj-jicofo-1.0-1066

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jicofo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/81iw864ddfs34cyky49g96l321lv73mj-jicofo-1.0-1066 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jicofo https://github.com/r-ryantm/nixpkgs/archive/7be2895dbd6dc2955c4d6c83dffc4ca075e9bfb3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7be2895dbd6dc2955c4d6c83dffc4ca075e9bfb3#jicofo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/81iw864ddfs34cyky49g96l321lv73mj-jicofo-1.0-1066
ls -la /nix/store/81iw864ddfs34cyky49g96l321lv73mj-jicofo-1.0-1066/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jicofo

Maintainer pings
cc @cleeyv @ryantm @Lassulus @yayayayaka for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jicofo is: A server side focus component used in Jitsi Meet conferences
meta.homepage for jicofo is: https://github.com/jitsi/jicofo
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0-1075 in filename of file in /nix/store/87q91725w3x5m5y4xj54msq8ljxa52s7-jicofo-1.0-1075

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jicofo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/87q91725w3x5m5y4xj54msq8ljxa52s7-jicofo-1.0-1075 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jicofo https://github.com/r-ryantm/nixpkgs/archive/88375d4cb93ba6eaa2695ed8b68d025e81086232.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/88375d4cb93ba6eaa2695ed8b68d025e81086232#jicofo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/87q91725w3x5m5y4xj54msq8ljxa52s7-jicofo-1.0-1075
ls -la /nix/store/87q91725w3x5m5y4xj54msq8ljxa52s7-jicofo-1.0-1075/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

jicofo

Maintainer pings
cc @cleeyv @ryantm @Lassulus @yayayayaka for testing.


Code explanation

Hello,
First of all, great paper! I just have one question. Would you mind helping me understand why only the last feature map is used in the transformer? Aren't you losing information by discarding the others?
https://github.com/sukjunhwang/IFC/blob/fb2ee4571dba4700eab3b52f10e147225b763e2a/projects/IFC/ifc/models/ifc.py#L65

Hi @cyrilzakka ,
Thank you for your interest in our work.
As you noted, it would be better to use multiple levels of features such as res2, res3, and res4 (stride of 4, 8, 16, respectively.
However, we use only res5 sized feature (stride of 32) due to computational burden; this follows the architectural design of DETR.
If multiple levels are involved, the computations dramatically increase due to the inherent nature of transformers: quadratic increase.
Therefore, DETR only uses res5 feature in order to alleviate the issue.
Recently, there have been many approaches to both utilize and afford multiple levels, and I suggest you to refer to Mask2Former if interested.
Thank you :)

Thanks!


App crashes

Since I started using this Google admob all my console is full of crashes related to ads, am getting too many crashes report.

Hi @kizinho, Thanks for filing the issue. Could you please share the output of flutter doctor -v along with the crash reports? Also are these crashes affecting any specific set of devices or OS versions?
Thanks


Inverted port assignments

In https://github.com/plunder-app/kube-vip/blob/master/kubernetes-control-plane.md the kube-vip and kube-apiserver port assignments are inverted between the kube-vip config and the kube init params. I.e. you've swapped who is 6443 and who is 6444.

And in the kubeadm join

This is now fixed


chore: update PHP dependencies

Automated changes by create-pull-request GitHub action

adding a card to look into the float issue separately as it requires more adjustments when using number_format


App 2Extended : add HLG support

Depends on https://github.com/Netflix/photon/pull/263

Hello @cconcolato and @MarcAntoine-Arnaud ,
After your remarks, I've made the changes related to TSP-2121 on the related branch (see #263 ), and rebased and updated this one concerning the HLG support in Application 2E.
Thanks for your review.


Firefox Nighly

Firefox Nightly should be present on the list of upcoming browsers. It gets 393 HTML5 Points and 10 bonus points.
Version - 19.0a1(2012-10-15).

Nightly browsers are updated too often include. After the launch of the new version, I'll try to keep track of Firefox Aurora.


UWP compilation error "Cannot find type Windows.UI.Xaml.Controls.MediaPlayerElement"

🔙 Regression
UWP doesn't build.
Old (and correct) behavior
Up to version 0.5.6 builds correctly
Current behavior
From version 0.5.7 build fails with the following error:
Xaml Internal Error error WMC9999: Cannot find type Windows.UI.Xaml.Controls.MediaPlayerElement in module Windows.winmd.
Reproduction steps

Create a blank Xamarin.Forms app including UWP
Add Mediamanager.Forms to UWP
Build UWP
Should fail

Configuration
Version:
Xamarin.Forms <IP_ADDRESS>4984-pre10
UWP targets 17134, but it's the same with 16299
Platform:

[ X] :earth_americas: UWP

0.6.1 will be available soon and should include a fix. That said playing on UWP is still a bit buggy, so please reports other bugs for uwp as well so i can get it on par with Android and iOS.

@mikescandy can you give it a try and see if it works for you?

I'm getting this error now:
Payload contains two or more files with the same destination path 'MediaManager\MediaManager.xr.xml'. Source files:
C:\Users\michele.scandura.nuget\packages\plugin.mediamanager\0.6.1\lib\uap10.0.16299\MediaManager\MediaManager.xr.xml
C:\Users\michele.scandura.nuget\packages\plugin.mediamanager.forms\0.6.1\lib\uap10.0.16299\MediaManager\MediaManager.xr.xml
C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\VisualStudio\v16.0\AppxPackage\Microsoft.AppXPackage.Targets	1806
Am i doing something wrong here?

@mikescandy hmm interesting. I didn't test it with Forms like that. Let me give that a go.

@mikescandy can you check 0.6.2?

builds ok! thanks!
now if only collectionview worked on UWP... :)


Cargo crashes when using opt_level = 'z' with c-backed crates on linux

Steps to Reproduce
On a linux rust install with nightly installed (tested on rust version 1.22.0-nightly (ca94c75c5 2017-09-10)):

Make a new cargo bin project with the following Cargo.toml:

[package]
name = "opt_test"
version = "0.1.0"
authors = [""]

[dependencies]
openssl-sys = "0.9.17"

[profile.release]
opt-level = 'z'

cargo +nightly run --release

Cargo will crash when attempting to compile openssl-sys, complaining about passing gcc the -z flag, which it does not support.
This does not crash on macOS, I suspect because gcc on macOS is just a clang alias, which does support the -z flag.

Thanks for the report! I think this may be a bug for openssl-sys/gcc-rs rather than Cargo though?

Ah, ok. I wasn't sure where it should go. I'll post it over there then. Thanks!


Plugin causes game to hang on startup

Firstly - I will preface this by saying hello, I am the dreaded linux user every dev fears.
Am unsure why, how how I can help debug it, but while I can install your plugin and use it fine, if the plugin is installed when first launching the game, the game will hang (sometimes for 1-2mins, sometimes indefinitely) when the opening dawntrail logo begins to render.
Sound appears to still work, but graphics and the rest of the app are frozen.
Removing this plugin solves the problem upon re-launching the game.
Problem exists both with and without other plugins present.

Hello! Thank you for reaching out.
I'm Glyceri, temporary (hopefully) maintainer of Moodles.
Could you provide me with your log files?
I don't exactly know how to get to them on Linux but on windows it would be %AppData%/XIVLauncher/dalamud.log
Basically its the location where the XIVLauncher is installed.
After you launch the game and have had the hang you can close the game again. The log file should contain all the relevant information we need.
If you don't want to send the file in public over Github you can send it to me on Discord 'glyceri'.


'crash2-us-tpl.mcs' file missing

I was trying to build the savefile for "Crash Bandicoot 2", but looks like this file is missing.
crash2-us-tpl.mcs
➜  tonyhax git:(master) ✗ make crash2-us.mcs
make: *** No rule to make target 'crash2-us-tpl.mcs', needed by 'crash2-us.mcs'.  Stop.

I've been using git for years now, yet I still routinely forget "git commit -a" doesn't add new files. Solved in latest master.


Allow model to implement Writeable, ToXContent

Signed-off-by: Vijayan Balasubramanian<EMAIL_ADDRESS>Description
Refactor toXContent from GetModelResponse to Model, since it will be shared by SearchModelResponse
in future commits.
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/faiss-support@0c7f0f2). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             feature/faiss-support     #135   +/-   ##
========================================================
  Coverage                         ?   83.13%
  Complexity                       ?      773
========================================================
  Files                            ?      114
  Lines                            ?     3404
  Branches                         ?      322
========================================================
  Hits                             ?     2830
  Misses                           ?      433
  Partials                         ?      141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7f0f2...fdf65a3. Read the comment docs.

@VijayanB Can you elaborate more on why this change had to be made?

There are two reasons

IMO it is better to keep serialization or federalization of model inside Model class, so that future changes to model will not impact other classes.
In my next PR I have to use it in Search response which has same output and I have to either move to Util class or duplicate the same logic


Rename Trunk/Frunk Command usage

Thanks you @timdorr for this doc.
I hope this renaming is ok, regarding to the usage of actuating the trunks.
This PR could solve misunderstandings directly, because in the api parameters/body params differ from call to call.
Best regards.

Thanks, but this is already implied because it's a POST request.

alright, thanks for the quick response :)


Integration with HTML editors is a priority

First off: Fantastic job... there are many file managers out there, but usually written in PHP, making it unusable for other languages. elFinder has been my only option for many years until I discovered a way to use Phalanger (a PHP compiler for .NET) to get Responsive File Manager working in ASP.NET MVC. Now I'm upgrading my projects to .NET Core which Phalanger does not support and I have been looking for alternatives. Sadly the lack of good JavaScript file managers is still a problem. Yours looks like the start of something great.. It's about time there was an alternative to elFinder!  :-)
I think one of the first things you need to do next is focus on integration with HTML editors. I see that's on your "To do list" in the README.. Looking forward to it!
I'll definitely be watching this project for sure. Keep up the good work.

Thanks for your feedback !
Will try to work on this "soon" :)


Current versions of heavyai and cudf don't work together

It looks like the current version of heavyai is out of date w/ cudf's API.
After starting the heavyai Docker image, registering my license key as directed, and creating a conda environment as directed by the docs:
conda create -n heavyai-gpu -c rapidsai -c nvidia -c conda-forge -c defaults python cudf cudatoolkit heavyai
...
conda list | grep rapids
cubinlinker               0.2.2            py39h11215e4_0    rapidsai
cudf                      22.12.01        cuda_11_py39_gf700408e68_0    rapidsai
libcudf                   22.12.01        cuda11_gf700408e68_0    rapidsai
librmm                    22.12.00        cuda11_g8aae42d1_0    rapidsai
rmm                       22.12.00        cuda11_py39_g8aae42d1_0    rapidsai
...
heavyai                   1.0                pyhd8ed1ab_0    conda-forge
pyheavydb                 6.1.1              pyhb39878e_1    conda-forge

Then trying to connect
>>> from heavyai import connect
>>> con = connect(user="admin", password="HyperInteractive", host="localhost",
...               dbname="heavyai")
>>> con
Connection(heavydb://admin:***@localhost:6274/heavyai?protocol=binary)
>>> con.select_ipc_gpu("show tables")
Traceback (most recent call last):
  File "/home/nfs/rgelhausen/conda/envs/heavyai-gpu/lib/python3.9/site-packages/heavyai/connection.py", line 317, in select_ipc_gpu
    from cudf.comm.gpuarrow import GpuArrowReader  # noqa
ModuleNotFoundError: No module named 'cudf.comm.gpuarrow'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nfs/rgelhausen/conda/envs/heavyai-gpu/lib/python3.9/site-packages/heavyai/connection.py", line 320, in select_ipc_gpu
    raise ImportError(
ImportError: The 'cudf' package is required for `select_ipc_gpu`

After backing up to the cudf=22.06 release, I can get a bit further, but then hit issues querying the included demo tables:
conda create -n heavyai-gpu -c rapidsai -c nvidia -c conda-forge -c defaults python cudf=22.06 cudatoolkit heavyai

Test:
>>> con.get_tables()
['heavyai_us_states', 'heavyai_us_counties', 'heavyai_countries']
>>> con.select_ipc_gpu("select count(*) from heavyai_us_states")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nfs/rgelhausen/conda/envs/heavyai-gpu/lib/python3.9/site-packages/heavyai/connection.py", line 336, in select_ipc_gpu
    df = _parse_tdf_gpu(tdf)
  File "/home/nfs/rgelhausen/conda/envs/heavyai-gpu/lib/python3.9/site-packages/heavyai/_utils.py", line 113, in _parse_tdf_gpu
    schema_buffer, shm_ptr = load_buffer(tdf.sm_handle, tdf.sm_size)
  File "/home/nfs/rgelhausen/conda/envs/heavyai-gpu/lib/python3.9/site-packages/heavyai/ipc.py", line 48, in load_buffer
    raise ValueError("Invalid shared memory key {}".format(shmkey))
ValueError: Invalid shared memory key<PHONE_NUMBER>

https://github.com/heavyai/heavyai/pull/39 fixes this in the next heavyai release.


fix(deps): update otel core experimental to ^0.41.0

Which problem is this PR solving?
I'm using the latest version of the experimental @opentelemetry/* packages in my project. However, because the instrumentations in this repo don't use that latest version, I end up with many copies of @opentelemetry/instrumentation installed. This, in turn, results in one instance of require-in-the-middle per instrumentation, which severely slows down the loading time of my application.
Short description of the changes
I patterned this diff off of #1527. I used find/replace to actually bump all the versions.
It seems like renovate should be doing these bumps automatically, but I don't see any recent PRs from it that would have performed these updates.

Possibly related: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1434 was a recent-ish fix for renovate for updating deps to ^0.40.0.
The renovate schedule is: "before 3am on Friday"
https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/renovate.json#L31-L33
The 0.41 release (https://github.com/open-telemetry/opentelemetry-js/pull/3963) was merged last Thursday:
commit 06e919d6c909e8cc8e28b6624d9843f401d9b059 (tag: v1.15.0, tag: experimental/v0.41.0)
Date:   2023-07-06T13:06:26+02:00 (5 days ago)

    chore: prepare release 1.15 / 0.41 (#3963)

and<EMAIL_ADDRESS>was published to npm on Thursday:
$ npm info @opentelemetry/instrumentation time
...
'0.41.0': '2023-07-06T11:27:10.524Z'

I have no experience with Renovate, but I would have expected it to attempt to update on Friday morning.
(I'm here because of the linked require-in-the-middle issue. :)

The renovate schedule is: "before 3am on Friday" main/renovate.json#L31-L33
...
I have no experience with Renovate, but I would have expected it to attempt to update on Friday morning.

It should have run on friday morning, but the dependency dashbaord tells me that the PR is awaiting schedule. I think for these dependencies it may be worth to have that run daily - could'nt see any errors in the renovate job log, but they only go back one day, so something may have gone wrong somewhere - all it takes is some timeout while the bot is running, then it takes a week for it to open the PR again. :thinking:
I forced the creation of the PR now to ensure it's working. I'll also look into bumping the schedule to daily, we typically don't always release on the same day of the week so it would make sense to react more quickly to core updates. :slightly_smiling_face:


Use gpio variants

This PR upgrades to variant methods for the gpio module.
Doing this I had to extend the macro invocations significantly.
Also, I found no elegant way to apply this to the downgradable pins, as the pin register field access is determined via
"runtime".
https://github.com/rust-embedded/svd2rust/pull/400 could help with that.
Also, for the stm32f3x8 and stm32f373 series, this can not be applied right now, as they are missing a gpio documentation.
https://github.com/stm32-rs/stm32-rs/pull/321 will add these.

Now that stm32f3 v0.10 is released, this builds for all stm3f3xx targets again.
This blows up the macros in the gpio module to a large extent, but the code itself should be simplified.
I would keep it like that for now. When the field array support is released under a new svd2rust version and stm32f3 will use it in the next release, this code could be simplified a lot.
When this happens, i will open a follow up PR.

Hey @Sh3Rm4n, could you rebase to resolve the conflicts?

Looks good, thanks!


Not loading on Firestick

Side loading the version currently on play store (.101?)  to my Firestick 4k Max and it won't load?
An older version .73 (from Amazon store) loads ok but doesn't enable frame rate matching.

Where did you get the v0.101 from?

That's the version on Google play store

But there's no Google Play Store on Fire TV so I'm asking where did you get the app from / how did you install it.

Install on my phone from play store then install to Firestick with Easy Fire Tools

You shouldn't use the version from Play Store as it may not be the same architecture and configuration as your Fire TV device. Install full apk from https://github.com/moneytoo/Player/releases.

Thanks that version works and so does frame rate switching. Great stuff 😀


[SPARK-9570][Docs][YARN]Consistent recommendation for submitting spark apps to YARN, -master yarn --deploy-mode x vs -master yarn-x'

Issue link: https://issues.apache.org/jira/browse/SPARK-9570
Changes made:

Added the alternative to job submission to avoid the confusion
Moved the Master URLs section closer to the options prior to the examples

Requesting review.
Is there any other place in the documentation that could add a confusion to the user?
Need to maintain a consistent, if not clarify all the submission methods in the documentation.

Can one of the admins verify this patch?

Running on YARN (which was fixed in #6924) has simply yarn-client and yarn-cluster for master.
and does not have --deploy-mode in the page.
For Standalone (https://spark.apache.org/docs/latest/spark-standalone.html), there is no such conflict in syntax just the explanation of the "deployment modes of Spark".
For Submitting applications (https://spark.apache.org/docs/latest/submitting-applications.html), there exist both the master yarn-client and yarn-cluster along with --deploy-mode since it is a holistic document for the submission and includes local, spark, mesos and yarn. But --deploy-mode is only used or appears in the examples to illustrate supervise, the rest just point to the master-urls.

@tgravescs, @srowen, the latest commits should help alleviate any confusion

I think the best question is, which is already used more in the docs? --master yarn --deploy-mode client or --master yarn-client? I count 3 uses of the former and 26 of the latter. I suggest therefore that:

YARN docs continue to use yarn-client and yarn-cluster
Add a mention about --deploy-mode after the first example of yarn-client/yarn-cluster in the YARN docs, that it's a synonym
Don't rearrange the rest of the docs
spark-submit help args should however use --deploy-mode since it's not YARN-specific
Generic Spark submission docs should still use --deploy-mode for non-YARN modes

How does that strike people? It's much less change than eliminating yarn-client/yarn-cluster mentions, even if it highlights an inconsistency.

personally I would prefer us to change things to be consistent.  Change yarn docs to use --master yarn --deploy-mode client/cluster.   Yes it might be multiple instances of it but its only one or two document and should take little time.

Yeah I agree... though I also just now looked at the source code and many exception messages use yarn-client and yarn-cluster. It really seems that got embedded as the way to express this for YARN.
Any other feelings one way or the other? I'm pretty on the fence between consistency vs history.

So, the consensus is to have yarn-client and yarn-cluster with the deploy-mode as alternative.
I agree with @srowen, more places in the code have yarn-client and yarn-cluster.
So the change is in the submitting applications doc wrt YARN and the Running on YARN doc wrt deploy-mode.
I'll change accordingly and update the PR soon.

sorry but I thought we were going with the --master yarn --deploy-mode client/cluster.
@sryza   I think you originally added the --deploy-mode was there discussion at that point about deprecating yarn-client/yarn-cluster?

@tgravescs, I am not too sure whether to stick with consistency or history or both.
If @sryza  can weigh in, we can reach a good understanding of where to proceed on this.
The goal is to help a user and reduce the confusion (if any) in the submission methods for YARN.

Sorry all for the delay, have been in Indonesia for the week.
I'm also in favor of the standard way being --deploy-mode.  This keeps things consistent with standalone and Mesos.  I think it's probably fine if in some places in the docs we use "yarn-client" as shorthand to refer to running on YARN with the client deploy mode, but in the actual instructions on how to launch, my personal preference would be --master yarn --deploy-mode client/cluster.

@nssalian I would go with their suggestion. I suppose that means going all the way the other way, and featuring --deploy-mode in docs, comments and any log or exception messages, but then also mentioning yarn-client et al as a synonym. Both should remain supported and tested.

@srowen, @sryza , @tgravescs  thank you for the feedback.
I will get this done this weekend.

Creating a new PR.


Migrate subgraph

[x] Use staging staging-polygon-digital-carbon subgraph
[x] Remove obsolete flows (used only by legacy dashboard dashboard)
[x] Update tokens data more frequently

@Atmosfearful @cujowolf
I noticed that there are some klima retirements In the old subgraph I cannot find in the new subgraph. For instance this should return at least one retire.
Here is my query
{
klimaRetires(where: {
retire_: {
beneficiaryAddress: "0x48df71d619ed737075e8adcba16e9fe4eb84ca5e"
}
}, orderBy:  retire__timestamp, orderDirection: desc) {
retire
{
timestamp
pool {
id
}
  }

}
}

Thanks for pointing this out. I believe part of the issue is from how the retirement entity IDs were using the transaction sender and not the beneficiary. I've got an updated subgraph indexing, and will update when it's ready to verify against.


Axios: Ability to override individual configuration

Feature request
I sometimes need to do more than the given default options. For example, adding a custom config option to extend the custom axios instance's behavior.
Concrete example: File upload progress
1. Problem
A generated upload hook function with a react-query client and a custom axios instance looks like this:
export const useUploadProjectFilesHook = () => {
  const uploadProjectFiles = useCustomInstance<string[]>();

  return (projectId: string, uploadProjectFilesBody: UploadProjectFilesBody, subpath = "operations") => {
    const formData = new FormData();
    formData.append("projectFileRequest", uploadProjectFilesBody.projectFileRequest);
    uploadProjectFilesBody.files.forEach((value) => formData.append("files", value));

    return uploadProjectFiles({
      url: `/${subpath}/packet/files/upload/${projectId}`,
      method: "post",
      headers: { "Content-Type": "multipart/form-data" },
      data: formData,
    });
  };
};

It would then be used as follows in the application code:
const uploadFilesMutation = useUploadProjectFiles();

The problem here is that if I want to track the upload progress, I currently have no way of doing this.
2. Possible Solution
Achieving this is possible by potentially providing additional configuration information to the internally called hook function.
const uploadFilesMutation = useUploadProjectFiles({
  axiosConfig: {
    onDownloadProgress(progressEvent) {},
    onUploadProgress(progressEvent) {},
  }
})

export const useUploadProjectFilesHook = <T>(axiosConfig?: AxiosRequestConfig<T>) => {
  const uploadProjectFiles = useCustomInstance<string[]>();

  return (projectId: string, uploadProjectFilesBody: UploadProjectFilesBody) => {
    const formData = new FormData();
    formData.append("projectFileRequest", uploadProjectFilesBody.projectFileRequest);
    uploadProjectFilesBody.files.forEach((value) => formData.append("files", value));

    return uploadProjectFiles({
      url: `/${subpath}/packet/files/upload/${projectId}`,
      method: "post",
      headers: { "Content-Type": "multipart/form-data" },
      data: formData,
      ...axiosConfig, // notice the spread operator
    });
  };
};

Related issues

https://github.com/anymaniax/orval/issues/918
https://github.com/anymaniax/orval/issues/869
https://github.com/anymaniax/orval/issues/870

Hi, @usersina
It varies by client, so please refer to your client's reference. As a workaround, it might be possible to reference the http client directly. I checked some client references, but unfortunately it didn't seem possible to access the response headers. Also consider using the HTTP client directly as a workaround.