cc.textureCache.addImageAsync caused crash on Android, iOS, Mac

Crash happen on Android, iOS, Mac. Win32 not tested.
Crash on JSAutoCompartment ac(_cx, _obj.ref() ? _obj.ref() : global);
Tested with code below :
var imageUrlArray = ["http://www.cocos2d-x.org/s/upload/v35.jpg", "http://www.cocos2d-x.org/s/upload/testin.jpg", "http://www.cocos2d-x.org/s/upload/geometry_dash.jpg"];

for (var i = 0; i < imageUrlArray.length; i++)
{
    cc.textureCache.addImageAsync(imageUrlArray[i], this.imageLoaded, this);
}

https://github.com/cocos2d/cocos2d-js/issues/1507#issuecomment-93233190
Updated : update issues

Delayed to v3.7

@pandamicro
Is there any temporarily solution for this issue?
Thanks.

is this fixed yet? I can't get it to work on 3.6, maybe I have to rollback to 3.3 where it works.

this is a serious bug. anybody has a workaround for it while we wait for the official fix?

Yes, this is a critical bug but been delayed to fix from v3.6 to v3.7.
I hope it can be fixed ASAP and won't be delayed to v3.8.
It looks like TextureCache::addImageAsync has more issue on Cocos2d-x
https://github.com/cocos2d/cocos2d-x/issues/12021
For temporarily solution, i make the downloader become sync which has the old time app freeze issue.
void __JSDownloaderDelegator::download(JSContext *cx, JS::HandleObject obj, const std::string &url, JS::HandleValue callback)
{
//auto t = std::thread(cx, obj, url, callback {
new __JSDownloaderDelegator(cx, obj, url, callback);
//});
//t.detach();
}

Maybe I have fixed this issue. Modify the file at /frameworks/js-bindings/bindings/manual/extension/jsb_cocos2dx_extension_manual.cpp
void __JSDownloaderDelegator::downloadSync(JSContext *cx, JS::HandleObject obj, const std::string &url, JS::HandleValue callback)
{
    new __JSDownloaderDelegator(cx, obj, url, callback);
}

// jsb.loadRemoteImg(url, function(succeed, result) {})
bool js_load_remote_image(JSContext *cx, uint32_t argc, jsval *vp)
{
    if (argc == 2) {
        auto t = std::thread([cx, argc, vp]() {
            JS::CallArgs args = JS::CallArgsFromVp(argc, vp);
            JS::RootedObject obj(cx, JS_THIS_OBJECT(cx, vp));
            std::string url;
            bool ok = jsval_to_std_string(cx, args.get(0), &url);
            JS::RootedValue callback(cx, args.get(1));

            __JSDownloaderDelegator::downloadSync(cx, obj, url, callback);

            JSB_PRECONDITION2(ok, cx, false, "js_console_log : Error processing arguments");

            args.rval().setUndefined();
        });
        t.detach();
        return true;
    }

    JS_ReportError(cx, "js_load_remote_image : wrong number of arguments");
    return false;
}

Ok, it works now!

@pwang08
Does your solution have freeze issue when downloading the image?
Thanks.

@Zinitter I have start a thread to process, so the solution works well.

@pwang08
Great! I will try your solution when i have time.
Between, have you test it with this code which call addImageAsync multiple times or try to load same url?
There is a "not thread safe" issue on the textureCache which failure to cache the image.
var imageUrlArray = ["http://www.cocos2d-x.org/s/upload/v35.jpg", "http://www.cocos2d-  x.org/s/upload/testin.jpg", "http://www.cocos2d-x.org/s/upload/geometry_dash.jpg"];

for (var i = 0; i < imageUrlArray.length; i++)
{
    cc.textureCache.addImageAsync(imageUrlArray[i], this.imageLoaded, this);
}

Hi, all
I finally created a proper PR for fixing this issue. This PR have refactored __JSDownloadDelegate for multithread.
https://github.com/cocos2d/cocos2d-x/pull/12132

@pandamicro
Thanks for the fixed.
But your PR seems got errors as it failed the check.

It passed Jenkins CI now, and you can see the declaration of startDownload here:
https://github.com/cocos2d/cocos2d-x/pull/12132/files#diff-27b4510bafdc8fe56a48aeaaaac81716R44

@pandamicro
Good job!
The solution is working on Mac, iOS, Android.
Unfortunately, i can't help to test it on Windows too.
But there is still a freeze issue on Android and iOS which cause by Image::initWithImageData as we discussed before.
So I would like to request a feature which make the Image::initWithImageData become async in Android and iOS.
By then, cc.textureCache.addImageAsync will fully async across platform.
Thanks for your effort!

@Zinitter But initWithImageData is executed outside the cocos thread, I don't understand why there is a freeze.

@pandamicro
I tested the code with my project which might call cc.textureCache.addImageAsync to load image with url at the same time.
cc.textureCache.addImageAsync(imageUrl, this.downloadCompleted, this);
Using same image url would not crash the app and able to download the image and create the sprite.
But I realised that there is slightly freeze when the callback "this.downloadCompleted" is called when success.
The freeze issue is happen on Android and iOS. Mac is fine.
I tried with 2 cases on the callback and both case have the freeze issue.

simply cc.log
create a sprite with the texture

So far in my testing, the app only crashed once. The callback is called with texture = null as show in log.
downloadCompleted texture:null
Assert failed: Invalid size
Assert failed: Invalid size
Assert failed: Invalid size
Assert failed: Invalid size
Assert failed: Could not attach texture to framebuffer
I'm not very sure how that happen, but these are the steps i tested with.
Scene 1 which call cc.textureCache.addImageAsync multiple to load different image and create the sprite
Scene 2 which do the same as Scene 1
Step 1
At Scene 1, loading image, while the image not completed download, change to Scene 2 quickly by
cc.director.runScene(new cc.TransitionFade(transitionTime, new Scene2()));
Step 2
Repeat Step 1 when at Scene 2 to go back Scene 1
Hope these help.
I have another request, can we make cc.RenderTexture.saveToFile async so that when cc.textureCache.addImageAsync downloaded the image, then i can cache the image by save it to a file.
cc.RenderTexture.saveToFile(imageName, cc.IMAGE_FORMAT_JPEG);
Or do we have other way to cache the image so when we reopen the app, we don't need to download the image again.
Thanks.

Thank you very much for the test ! I will look into it

Or do we have other way to cache the image so when we reopen the app, we don't need to download the image again.

I think it's more proper to directly download the file and store them in user device. For now the implementation of JSDownloadDelegate is downloading via a buffer, but Downloader supports download files too. The reason I haven't done it in this way is because I don't know whether it's desired, and I don't know where user want to store the images.

How about implementation like this
For download and use (current implementation)
 cc.textureCache.addImageAsync

For download to file and use
 cc.textureCache.downloadImageAsync

The path to store the file by default is either
var storagePath = ((jsb.fileUtils ? jsb.fileUtils.getWritablePath() : "/"));
var storagePath = ((jsb.fileUtils ? jsb.fileUtils.getWritablePath() : "/download/"));

User can change the default storage path if they want.
Assume we downloading multiple files at the same time, i'm curious if directly download the file and store them, then straight load from the file and create a sprite, would it have the frozen issue or the time needed to process as we don't preload the resources.
Thanks.

I agree with the basic idea, but I'm afraid we won't have time to implement it very soon, because it requires an API change, we take such change very seriously
Some problem:

The path to store the file by default is either

var storagePath = ((jsb.fileUtils ? jsb.fileUtils.getWritablePath() : "/"));
var storagePath = ((jsb.fileUtils ? jsb.fileUtils.getWritablePath() : "/download/"));

That will violate end user's storage, because all cocos applications will save in the same folder by default.
So I think it should be explicitly defined by developer

Assume we downloading multiple files at the same time, i'm curious if directly download the file and store them, then straight load from the file and create a sprite, would it have the frozen issue or the time needed to process as we don't preload the resources.

I think it should be occupied by downloadImageAsync

I'm understand that Cocos team are very busy recently.
Does the Downloader supports download files is for the hotfix feature?
Can't we use the same feature as live hotfix (support image only)?
If not, do you have any temporarily solution for cc.RenderTexture.saveToFile or cc.textureCache.downloadImageAsync to avoid the frozen issue?
Cocos2d-JS is lack of multi-threading which fully utilise multi core cpu and avoid the frozen issue on coding. Cocos team should implement something to handle the multi threading issue for Cocos2d-JS.
About the storage, i don't know that will violate end user's storage. But it should not a problem to defined by developer who want to use the feature.
Thanks.

I still got crash after apply this commit #fdec552 when offline


Possible Bug: Mapping "-Persist" drives with New-PSDrive using WINRM sessions

I am trying to map persistent drives using New-PSDrive on a remote winrm session with -Persist, but when I opened a new session the mapping driver got the status of "Unavailable". I am using CREDSSP
Steps to reproduce
#Session A creating the mapping
$credentials = Get-Credential user
$session = New-PSSession -ComputerName Server1 -Credential $credentials -Authentication CredSSP
$computername = "Server2"
Invoke-Command -Session $session -ScriptBlock {
param($computername)
New-PSDrive -PSProvider FileSystem -Name "X" -Root "\\$computername\scripts" -Persist -Verbose -Scope Global
} -ArgumentList $computername

#Session B checking the mapping
$credentials = Get-Credential user
$session = New-PSSession -ComputerName Server1 -Credential $credentials -Authentication CredSSP
$computername = "Server2"

Invoke-Command -Session $session -ScriptBlock {
get-PSDrive
net use
}

Actual behavior
Session B returns:
Status Local Remote Network
Unavailable X: \Server2\scripts Microsoft Windows Network
The command completed successfully.
Expected behavior
The drive X: \Server2\scripts Microsoft Windows Network being available on Session B
Environment data
> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      4.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.42000
BuildVersion                   6.3.9600.18773
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.2

Hi, could you see this issue?
Thank you in advance!!

@miguelantonio
This appears to just be a double hop issue . . which is well known and documented.

you need to setup CredSSP (delegate to/from) correctly for this to work or else provide creds for the 2nd hop.

This workaround is likely the easiest . . pass in the cred to the session...
$cred = get-credential user
Invoke-Command -Session $session -ScriptBlock {
New-PSDrive -PSProvider FileSystem -Name "X" -Root "\$using:computername\scripts" -Persist -Verbose -Scope Global -Credential $using:Cred
dir x:
}

okay I have been able to get a similar issue...
I can connect 'only' the first time, however after that I get the following error.. I am connecting to an Azure File Share.
$cred = get-credential stagecus1
$root = '\\stagecus1.file.core.windows.net\source'
$pso = New-PSSessionOption -OpenTimeout 30000 -OperationTimeout 20000 -cancelTimeout 10000
# Test against PC 7 preview 6 . . works fine only the first time.
$psSessionEndPoint7 = "PowerShell.7-preview"
$s7 = New-PSSession -ComputerName AZC1ADFS1SQL03 -SessionOption $pso -ErrorAction SilentlyContinue -ConfigurationName $psSessionEndPoint7
$s7

icm -Session $s7 -ScriptBlock {

    function foo
    {
    param ($root,$c)
        hostname
        $PSVersionTable
        if (-not(get-psdrive -name source -ErrorAction SilentlyContinue))
        {
            New-PSDrive -name source -Root $root -PSProvider FileSystem -Credential $c
        }
        $error[0] | select *
        dir source:\ -ErrorAction SilentlyContinue
    }
    $using:root
    foo -root $using:root -c $using:cred
    get-psdrive -name source -ea 0 | remove-psdrive

}

This is the output
A specified logon session does not exist. It may already have been terminated.
    + CategoryInfo          : InvalidOperation: (source:PSDriveInfo) [New-PSDrive], Win32Exception
    + FullyQualifiedErrorId : CouldNotMapNetworkDrive,Microsoft.PowerShell.Commands.NewPSDriveCommand
    + PSComputerName        : AZC1ADFS1SQL03

PSMessageDetails      :
Exception             : System.Management.Automation.MethodInvocationException: Exception calling ".ctor" with "1" argument(s): "Drive name must be a root directory (i.e. 'C:\') or a drive letter ('C'). (Parameter 'driveName')"
                         ---> System.ArgumentException: Drive name must be a root directory (i.e. 'C:\') or a drive letter ('C'). (Parameter 'driveName')
                           at System.IO.DriveInfoInternal.NormalizeDriveName(String driveName)
                           at System.IO.DriveInfo..ctor(String driveName)
                           at CallSite.Target(Closure , CallSite , Type , Object )
                           --- End of inner exception stack trace ---
                           at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
                           at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.Interpreter.Run(InterpretedFrame frame)
                           at System.Management.Automation.Interpreter.LightLambda.RunVoid1[T0](T0 arg0)
                           at System.Management.Automation.ScriptBlock.InvokeWithPipeImpl(ScriptBlockClauseToInvoke clauseToInvoke, Boolean createLocalScope, Dictionary`2 functionsToDefine, List`1 variablesToDefine, ErrorHandlingBehavior
                        errorHandlingBehavior, Object dollarUnder, Object input, Object scriptThis, Pipe outputPipe, InvocationInfo invocationInfo, Object[] args)
                           at System.Management.Automation.ScriptBlock.InvokeWithPipe(Boolean useLocalScope, ErrorHandlingBehavior errorHandlingBehavior, Object dollarUnder, Object input, Object scriptThis, Pipe outputPipe, InvocationInfo invocationInfo,
                        Boolean propagateAllExceptionsToTop, List`1 variablesToDefine, Dictionary`2 functionsToDefine, Object[] args)
                           at System.Management.Automation.ScriptBlock.DoInvokeReturnAsIs(Boolean useLocalScope, ErrorHandlingBehavior errorHandlingBehavior, Object dollarUnder, Object input, Object scriptThis, Object[] args)
                           at System.Management.Automation.PSScriptProperty.InvokeGetter(Object scriptThis)
TargetObject          :
CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
FullyQualifiedErrorId : ArgumentException
ErrorDetails          :
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 5
                        at foo, <No file>: line 10
                        at <ScriptBlock>, <No file>: line 16
PipelineIterationInfo : {}
PSComputerName        : AZC1ADFS1SQL03
RunspaceId            : 8e662156-c259-4d30-b81a-5d9f9be698ae

I seem to be able to consistently connect by setting the psdrive scope to local.
@miguelantonio you may want to test with this as well.
New-PSDrive -name P -Root $using:root -PSProvider FileSystem -Credential $using:cred -Scope local -Persist

Close as stale issue. Feel free to continue discussion.

Close as stale issue. Feel free to continue discussion.


Fix log big size

When v8-deopt-viewer processed logs larger than ~400 mb, JSON.stringify throw error RangeError: Invalid string length. So replace JSON.stringify with use MessagePack.

@Nadya2002 This looks great! Thank you. Looks like you have some merge conflicts that need resolving. And when I'm near my computer again I'll take a look at msgpackr in more detail - I'm not super familiar with it

@andrewiggins can you look please?

Will try to take a look this week


IPv6 address support in S3

Describe the bug
The commit https://github.com/aws/aws-sdk-cpp/commit/cb67425a8ec081ad948e638baedf5cabf3e72a15 introduced IPv6 address support in AWS core but it's still failing in AWSClient.cpp and function Aws::Utils::IsValidHost()
Expected behavior
Connection to http://[::1]:8000 should work.
Current behavior
Currently, the request fails with Invalid DNS Label found in URI host error
Steps to Reproduce
Create an S3 bucket using bracketed IPv6 address with explicit port, e.g. http://[::1]:8000
Possible Solution
It appears that half-work is already done and Aws::Utils::IsValidHost needs to understand bracketed GetAuthority, or rather IPs.
AWS CPP SDK version used
1.9.185
Compiler and Version used
gcc-9
Operating System and version
Ubuntu 20.04

Hi @drake127 ,
Hmmm... So you are right about it not working, but I am pretty sure this is something we don't support for s3 yet... just a matter of syntax but I think this is a feature in the works rather than a bug.

This should now be supported in 1.11 with the rule based endpoint resolution which does understand ipv6 endpoint overrides.


Scroll wheel scrolling is not smooth

I just started learning Flutter. And I faced one big problem which is bad scrolling in complex list. Let's say we have 5 different item type in our ListView and some item type must display images and it's infinite scroll. I read a lot articles and posts about ListView for Flutter and all the things I've seen are simple list with text. How can I make smooth scroll?

Scrolling, even for a list with complex items, should be smooth by default.
It would help if you could provide the output of flutter doctor and a small self-contained app that demonstrates the scrolling problem. Note also: https://gist.github.com/ is a useful way to share the code.

It would also help to know if you're seeing this on web, desktop, mobile, or all of the above.

Shaper in the app with pictures gets slow to scroll

Hi @dimiril
can you please provide your flutter doctor -v ,
your flutter run --verbose
and if possible a reproducible minimal code sample.
Thank you

Below applies to all platforms that support a mouse / touch-pad:
No sure of this is related but I noticed that scrolling with a scroll wheel vs a touch pad is provides a different experience. If the mouse wheel has scroll break points (each partial turn of the wheel has a ridge) then Flutter will simple jump directly to that scroll position. Using the same mouse wheel on a standard web page or desktop application there is a "curve" or "animation" where the page will scroll and slowly pause at the scroll location.
Using a touch-pad Flutter feels smoother because the scrolling motion is more continuous.
See the following Flutter Web page sample and scroll very slowly with a mouse wheel vs touch-pad.
Flutter sample Page


Update setupMangaOnPC.md

Mokuro 0.2.0 has recently been merged to master: https://github.com/kha-white/mokuro/pull/91
Make it clear to download CUDA Toolkit 11.8 too instead of the newest CUDA Toolkit, of which cause PyTorch to not work properly
Use pip instead of pip3, as reported in https://stackoverflow.com/a/78253355 that people might fail when installing using pip3 vs pip only...

thanks for noticing this


[SPARK-21312][SQL] correct offsetInBytes in UnsafeRow.writeToStream

What changes were proposed in this pull request?
Corrects offsetInBytes calculation in UnsafeRow.writeToStream. Known failures include writes to some DataSources that have own SparkPlan implementations and cause EXCHANGE in writes.
How was this patch tested?
Extended UnsafeRowSuite.writeToStream to include an UnsafeRow over byte array having non-zero offset.

Can one of the admins verify this patch?

ok to test

Test build #79217 has started for PR 18535 at commit 2541615.

Test build #79217 has finished for PR 18535 at commit 2541615.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79217/
Test PASSed.

LGTM

Add to whitelist

thanks, merging to masetr/2.2/2.1!


Add "agent.useHostNetwork" and "agent.dnsPolicy" value to chart.

If agent.useHostNetwork is true, tell jaeger-agents to set hostNetwork:
true in their specs, allowing other containers on the host access to the
shared agent without having to know its name or location, just the
host's IP address.
agent.dnsPolicy will be propigated to the agents as the dnsPolicy for
the pod.  ClusterFirstWithHostNet is useful when useHostNetwork is true.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @scottrigby

lgtm

/ok-to-test

Needs a merge from master, after which the tests will probably succeed.

/lgtm

Thank you!


Host is resolving to localhost

Context

const client = makeClient({
    host: 'https://madeup-api.herokuapp.com'
});

client.authentication.getToken({
    username<EMAIL_ADDRESS>    password: 'pass',
}).then(data => (console.log('result: ', data.fail(), data.success())))

I'm seeing this error below in the chrome console:
POST http://localhost:3000/spree_oauth/token
Expected Behavior
POST https://madeup-api.herokuapp.com/spree_oauth/token

Your Environment
Create-react-app

Library version: 2.1.2
Node and yarn/npm version:  yarn 1.13 node 10.13
Browser version: latest chrome
Operating system: osx

It seems like this is not working properly
in HTTPS
this.host = process.env.SPREE_HOST || 'http://localhost:3000/'

Thanks for reporting!
Webpack freezes process.env. We'll create a fix.

Should be fixed in 2.1.4, please check.

That did fix the localhost issue, requests are looking like this now
xhr.js:173 POST http://localhost:3000/madeup-api.herokuapp.com/spree_oauth/token 404 (Not Found)

Thanks @tniezg !


Add the ability for PackedScenes and GDScripts to have import files

I added the ability for PackedScenes and GDScripts to have import files. To accomplish that I had to make two fundamental changes to Godot:

Add the concept of "read only or not" to "resource assets" (resource assets = assets with import files). Previously Godot assumed any resource asset was read only. PackedScenes and GDScripts are not read only and can be edited/saved directly. In addition on export we want to use those assets directly not their corresponding files in the .godot folder (e.g. for a texture on export Godot wouldn't use the reference resource asset "someTexture.png" file but the corresponding encoded etc2/dxt/etc texture in the .godot folder.  For packedscenes/gdscripts though we want to use the reference resource asset).

When loading assets, use the "import order" on asset loaders to pick the right one instead of picking the first one Godot finds (see ResourceLoader::_load in resource_loader.cpp). We do this because by creating importers for PackedScenes and GDScripts, we are also creating loaders for those asset types. But PackedScenes and GDScripts already have native loaders, so we need to make sure those "native loaders" get picked over our "importing loaders". We do this by setting our importing loaders with a lower import order and changing ResourceLoader to use those orders when finding the right loader to choose.

This is "step one" in my effort to add "pack file tags" to facilitate exporting many pack files (https://github.com/godotengine/godot-proposals/issues/10580).  I tested this change with various godot projects and exporting to Windows/Android platforms.

Add the concept of "read only or not" to "resource assets" (resource assets = assets with import files). Previously Godot assumed any resource asset was read only. PackedScenes and GDScripts are not read only and can be edited/saved directly.

We've been using the .escn concept for writable packed scenes. Maybe we can extend it to .eres?


JavaScript: support simple data flow through Electron IPC

This adds support for Electron inter-process communication in dataflow,
using only local flow on string literals to match calls across
processes. It is intended as a basis for future work using dataflow to
match calls between processes.

I think I've addressed all the comments on here.

I'll take another look at this as soon as possible; where are we with benchmarking on this one?

I got the VM set up but I haven't done a big test run yet, and probably won't get around to it until Thursday.

My first test run was only the security suite and only on Electron apps, with timings ranging from 1.06x to 1.48x; I think that's within reason for snapshots where adding edges across IPC makes the number of data flow nodes that are reachable from a RemoteFlowSource much bigger.
I ran out of disk space on my profiling VM during an overnight run with the default set of projects. I'll add more space to the VM and do another run over the weekend.

How is this PR looking? Is it still realistic for 1.18?

I'm going to close this for now; feel free to re-open when you get a chance to work on it again, or let us know if you'd like us to pick it up.


Review help.htm

Review the help.htm and update with new language if needed.

LK uploaded changes, now in master


UTF-16 and UTF-32 offsets

Thanks for your work!
I like crop's API and consider using crop in a LSP server, however in LSP offsets can be UTF-8, UTF-16 or UTF-32, and LSP servers must support UTF-16 offsets.
According to crop's README:

crop doesn't currently implement those APIs but adding them would be extremely easy. If you need those features in your application please open an issue describing your use case.

So I open this issue. Hoping you could add UTF-16 and UTF-32 offsets support.

Thanks and sorry for the late response!
I'm open to adding some methods on Rope and RopeSlice that allow converting byte offsets to and from UTF-16 code unit offsets. UTF-32 is rarely used and not mandatory according to the LSP spec so I don't think I'll add that.
I've started working on this in https://github.com/noib3/crop/pull/8, I'll ping you when it'll be ready to be merged.

#8 has just been merged to main, adding support for converting between UTF-16 and byte offsets by enabling the utf16-metric feature flag.
I consider this completed but feel free to re-open if you think there's something missing.


Upgrade eslint and other packages once eslint bug is fixed

Big babel-eslint issue causing false positives for the no-unused-vars rule:
https://github.com/eslint/eslint/issues/12117
This issue is a reminder/tracker to update react-scripts, eslint, and any other packages that are out-of-date or that were version locked to work-around this error.
Also, remove eslint from dependencies and peerDependencies.

eslint and babel-eslint were fixed a couple of days ago, but I was waiting on create-react-app to be updated as well because it includes those two packages in (I think) pinned versions.
But for the heck of it I tried removing the manual eslint pin from my package.json, and updating all the packages, and it doesn't throw the false positive error anymore. Either I was wrong and create-react-app specifies a non-pinned/latest version of estlint and so it was automatically a non-issue, or the newer fixed version of eslint is being specified from some other package and overriding the broken version in create-react-app.

I am dumb. I think it was my own hetio frontend-components with the eslint pin that was preventing the error. So even though I removed the eslint pin from this repo and it worked fine, I'm not considering this fixed yet.
Looks like create-react-app really needs to fix this upstream ASAP.


Charts being created with width and height 0, nothing get displayed using a web sample

I'm using the line char simple sample and i'm getting this error,this is my code:
            var ctx = this;
            var data = {
                labels: ["January", "February", "March", "April", "May", "June", "July"],
                datasets: [
                    {
                        label: "My First dataset",
                        fill: false,
                        lineTension: 0.1,
                        backgroundColor: "rgba(75,192,192,0.4)",
                        borderColor: "rgba(75,192,192,1)",
                        borderCapStyle: 'butt',
                        borderDash: [],
                        borderDashOffset: 0.0,
                        borderJoinStyle: 'miter',
                        pointBorderColor: "rgba(75,192,192,1)",
                        pointBackgroundColor: "#fff",
                        pointBorderWidth: 1,
                        pointHoverRadius: 5,
                        pointHoverBackgroundColor: "rgba(75,192,192,1)",
                        pointHoverBorderColor: "rgba(220,220,220,1)",
                        pointHoverBorderWidth: 2,
                        pointRadius: 1,
                        pointHitRadius: 10,
                        data: [65, 59, 80, 81, 56, 55, 40],
                        spanGaps: false,
                    }
                ]
            };
            //ctx.htmlItem[0].childNodes[0]
            options = {
                type: 'bar',
                data: {
                    labels: ["Red", "Blue", "Yellow", "Green", "Purple", "Orange"],
                    datasets: [{
                        label: '# of Votes',
                        data: [12, 19, 3, 5, 2, 3],
                        backgroundColor: [
                            'rgba(255, 99, 132, 0.2)',
                            'rgba(54, 162, 235, 0.2)',
                            'rgba(255, 206, 86, 0.2)',
                            'rgba(75, 192, 192, 0.2)',
                            'rgba(153, 102, 255, 0.2)',
                            'rgba(255, 159, 64, 0.2)'
                        ],
                        borderColor: [
                            'rgba(255,99,132,1)',
                            'rgba(54, 162, 235, 1)',
                            'rgba(255, 206, 86, 1)',
                            'rgba(75, 192, 192, 1)',
                            'rgba(153, 102, 255, 1)',
                            'rgba(255, 159, 64, 1)'
                        ],
                        borderWidth: 1
                    }]
                },
                options: {
                    scales: {
                        yAxes: [{
                            ticks: {
                                beginAtZero: true
                            }
                        }]
                    }
                }
            }
            var myChart = new Chart(ctx.htmlItem[0].childNodes[0], {
                type: 'line',
                data: data,
                options: {
                    scales: {
                        xAxes: [{
                            display: false
                        }]
                    }
                }
            });

This happens when the parent container has no size. Do you have a fiddle that reproduces this?

So i found that the chart doesn't fully render when the page is load so it doesn't finish and end in 0,0, i can solve it with a timeout but i don't want to implement that on my web, this is what happens to me: http://stackoverflow.com/questions/29403036/chart-js-not-showing-in-my-view , i got the canvas as the picture of theOP, any solutions? and can't give u a fiddle of this as the web is super super big,i'm working with web components

i found that my main problem is that the instruction on the plugin :
me.controller = new Chart.Controller(me);
resizes my canvas to 0 width and height, any ideas of why it does it, or how can i solve it?

I think this is fixed in v2.4.0 but there isn't a test case to confirm that

Closing since I believe this was fixed in v2.4.0


Readme Update

This PR updates the Readme and adds updates links for CI badge and Maven Central Download.

Nice. Thanks for the nice work.

Feel free to merge if you don't have anything else to update, you decide.


Fabric Crashes 1.17.1 mentioning Accessibility Plus

Hi,
Crash Log: https://bytebin.lucko.me/HpdaXITEyg
I've had a crash with Accessibility Plus. Not sure why.
Minecraft: 1.17.1
Fabric 0.12.5
Accessibility Plus: 1.4
The only thing I can think of is that since Fabric updated some mods broke

Hey sorry for that, the last update in here had a problem with campfires.
All the updates are now deployed to the Accessible Minecraft discord group run by @shoaib11120
https://discord.gg/yQjjsDqWQX

Thanks for the response!


Installed from Debian Repo and it does not work

I have installed bd from debian repo and it doesnt work
.
if I installed form debian repo, I think I didn't need to add aliases (. bd -si) and I have source the bash file and restarting my terminal, but still doesnt work.

now I am using this script form here.
cdn () { pushd .; for ((i=1; i<=$1; i++)); do cd ..; done; pwd; }
and it works fine for me.
for long dir, I use autojump.
thanks lot.


Clean up error and request handling 🧼

This pull request removes all Throw Error's because they are not neccessary and mess up typings.
Instead we will return actually something (void or null).
This pull request refactors the way axios request are implemented, they now are 2 seperate files and easier to manage

Need to test this still ⚠


Explore returning useful AzureServiceExceptions when a 4xx status is returned

It would be useful to deserialize the explanations and return them to the client callers.
For example, 4xx errors may have an explanation in the WWW-Authenticate header.

This should wait until PR #3347 moves in as it creates exceptions that would better explain the error.


Can I pull the game cover from this api?

Hey,
So, just out of curiosity am I able to pull the cover of a game title? Like for example the box art cover? How would that work if that's possible?

We have access to title icon URLs, but box art is not currently returned by PSN. Most sites are using a 3rd party service for this.
https://psn-api.achievements.app/api-docs/data-models/trophy-title


Update akka-persistence-cassandra to 1.0.4

Updates com.typesafe.akka:akka-persistence-cassandra from 1.0.3 to 1.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka", artifactId = "akka-persistence-cassandra" } ]

labels: library-update, semver-patch

Codecov Report

Merging #713 (b225b10) into master (be398cd) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   80.98%   80.90%   -0.08%
==========================================
  Files         116      116
  Lines        4023     4023
  Branches       95       95
==========================================
- Hits         3258     3255       -3
- Misses        765      768       +3

Impacted Files
Coverage Δ

...e/akka/actor/process_index/ProcessIndexProto.scala
98.01% <0.00%> (-1.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be398cd...b225b10. Read the comment docs.


[HeroSystem6eHeroic] Update to display of Perception Rolls and Modifiers with associated images.

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Added base perception value, which may make perception roll modifiers more understandable.
Updated README and preview images associated with change.

Character Sheet Info Roll20 Internal Use only.


'ng-sidebar-container' is not a known element:

Hi,
I have tried to implement ng-sidebar multiple times but with no success. read all docs.
Trying with Angular v4 and es6.
Rest of the project is working fine without ng-sidebar

any clue will be very help full.
Thank you all.

seems as I included ng-sidebar in the wrong Angular-App. Having multiple apps in the project !
import { SidebarModule } from 'ng-sidebar';

@Hassan121Cs Is it fixed then?

Yes, working good now. !!

truly an amazing package for Angular 2 - 4.
with wonderful docs and demo,
Have spend hours on evaluating different side menus but finally found the best on.
It would be more quicker to implement it with a working Plunder demo I guess.
What a great Work ! thank you for saving so many Jobs/lives 💯 🥇
Thank you @arkon and your Great Team


isle: panic when rule for non-multi internal constructor calls a multi extern

Consider the following code:
(type u64 (primitive u64))
(decl multi meow (u64) u64)
(extern extractor meow meow)
;; Note: not `multi nyaa`
(decl nyaa (u64) u64)
(rule (nyaa (meow x)) x)

This makes islec panic with the following message:
thread 'main' panicked at 'assertion failed: !block.steps.iter().any(|c| matches!(c.check, ControlFlow :: Loop { .. }))', cranelift/isle/isle/src/codegen.rs:421:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not sure if that's the standard of error messages we hold islec to.

Hah, whoops. That not only should have been caught in an earlier stage, but I left a TODO comment saying so:
https://github.com/bytecodealliance/wasmtime/blob/c9a9c2c1919858057ef51b91dc92216cf13ea477/cranelift/isle/isle/src/sema.rs#L2008


[CARBONDATA-1886] Delete stale segment folders on new load

Analysis:  segment folders are not getting deleted if corresponding entry is not available in table status file.
Solution: Delete stale segment folders if present
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
no

[x] Any backward compatibility impacted?
no

[x] Document update required?
no

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
no

Build Failed with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/666/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1895/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/668/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/1897/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2228/

LGTM


Improve Aesthetics of the read only SQL panel

When being read only (for example in an analysis layer) It doesnt look deactivated and the module on the button looks weird.
When being default the syntax coloring is weird as well

Here the visual design.

All links in this type of screen (darker) should be on white.
Info-Box with 24% opacity in black and the text inseide the box en yellow except the link is white.
The code color should be #979EA1.

How do you see this? @saleiva

Better but still weird.

Why don't we keep the coloring on the text and add opacity?
The band on the bottom is what I dislike the most.

But getting better :)
On Jul 12 2016, at 6:28 pm, Juanma<EMAIL_ADDRESS>wrote:

Here the visual design.

[![01 layers - 01-12
data](https://cloud.githubusercontent.com/assets/14546701/16774872/3ac033de-
485e-
11e6-88f2-fd3dc69abdb1.png)](https://cloud.githubusercontent.com/assets/14546701/16774872
/3ac033de-485e-11e6-88f2-fd3dc69abdb1.png)

All links in this type of screen (darker) should be on white.

Info-Box with 24% opacity in black and the text inseide the box en
yellow except the link is white.

The code color should be #979EA1.

How do you see this? @saleiva

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub,
or mute the
thread.

In this case I'll try tu put the code with the same colors but with opacity (48%) and the info-box on the original color. Is a normal info not a warning info.

But that infobox is even weirder...
On Jul 12, 2016 7:30 PM, "Juanma"<EMAIL_ADDRESS>wrote:

In this case I'll try tu put the code with the same colors but with
opacity (48%) and the info-box on the original color. Is a normal info not
a warning info.
[image: 01 layers - 01-12 data]
https://cloud.githubusercontent.com/assets/14546701/16776726/025f0a5c-4867-11e6-869d-9adb987dccd1.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/8779#issuecomment-232118866,
or mute the thread
https://github.com/notifications/unsubscribe/AAIENc-w8axHYRnjS2MahzbMORHcGr4Iks5qU888gaJpZM4JKIUB
.

I test with info-box background opacity 8% white

This approach has a info-box background color #000 (32%). Title and subtitle #979EA1 and text link #fff


Adding of Dark-Light toggle button in the navbar

Is your feature request related to a problem? Please describe.
Adding of Feature in the NavBar
Describe the solution you'd like.
We can Create a Dark-Light toggle button in the Navbar..  One can view it in dark and light mode both..
Describe alternatives you've considered.
There is no alternative of this idea
Screenshot / Screenshare

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @Bharadwajshivam28 , Thanks for opening the feature request, can you provide the meaningful title for the same?

@Sachin-chaurasiya not got your point

@Sachin-chaurasiya not got your point

No worries, I was talking about this title.

@Sachin-chaurasiya Adding of Dark-Light toggle button in the navbar

@Sachin-chaurasiya Adding of Dark-Light toggle button in the navbar

@Bharadwajshivam28 , Can you add the same in title?

ya sure  @Sachin-chaurasiya

@Sachin-chaurasiya updated it sir

@Sachin-chaurasiya updated it sir

@Bharadwajshivam28 , it should be
✨ [Feature request]: Adding of Dark-Light toggle button in the navbar

okay sir @Sachin-chaurasiya

done with it @Sachin-chaurasiya

@Bharadwajshivam28 , Can you describe more, how would be you adding support for dark and light mode?

yes i want to work on this feature..
Basically sir my idea is to implement an icon which can toggle light and dark mode when one clicks on it.. Like in night light mode is not much good so one can switch to dark mode..
Dropping two Screenshots.. One is of when user is in dark mode and other is of light mode..

@Sachin-chaurasiya

this is one button and it changes in dark and light mode // in light mode it goes with sun icon and in dark mode it goes with moon icon

@Bharadwajshivam28 , That is the UI part, I was talking about how we are gonna support the light and dark modes, basically, if you toggle the button from light to dark then how we are gonna handle the dark mode changes?
We need to have some logic and theme for both modes right?

yes we will have logic and theme both @Sachin-chaurasiya

i have did it many times so i can add it in very good way

i have did it many times so i can add it in very good way
@Sachin-chaurasiya

@Bharadwajshivam28 , it would be great if you mention the approach and consideration in the PR description.

ya sure sir i will do it when i will create the pr @Sachin-chaurasiya

@Sachin-chaurasiya I am facing issue in running the project locally can you help me with commands..
like which commands and after which

@Sachin-chaurasiya I am facing issue in running the project locally can you help me with commands..
like which commands and after which

Sure @Bharadwajshivam28 , you can refer this doc https://docs.reactplay.io//local-development

thanks @Sachin-chaurasiya

@Bharadwajshivam28 I can work on this issue if you no one is working on it.

Is anyone working on it?

Please assign me this @atapas

Can you please let me know what should be the color scheme of dark mode and light mode?

is anyone working on it ?

Can  I work on this Feature?


Performance updates

Hello,
I added support for the new CSS property "will-change" that is supported by current gen browsers and a fallback with the CSS3 3d transform hack for IE, Edge, and Opera.
I also prevented the page from repainting by changing the animations' opacity settings from 0 and 1 to .001 and .999, respectfully.

Hey @silverhawk184, thanks for working on this. However:

Additional styles seem like a bit overhead, I'd like to keep this library as clean and light as possible. And additional sheets just for translateZ hack doesn't fit nicely in this concept.
Opacity 0.001 and 0.999 are actually not a performance hack, but just the opposite (see update here: https://coderwall.com/p/gmfkaa/how-to-not-trigger-browser-repaint-when-opacity-changes).

will-change on the other hand solely seems like a good improvement though :) I'd prefer to keep only this change

Due to recent changes in 3.0.0-beta I'm closing this PR


Sample queries for Prometheus

HTTP
Azure Monitor
Generic

@yaron2 can provide some scenarios for the queries.

Hi @asavaritayal 	I think we were more talking about me taking up #171 rather than defining queries, right @yaron2 ?

Any update on this?


Added support for capture data to reference workflow + SLMS-3

Added functions and rules to the reference workflow that prepares capture spaces

Capture spaces are defined in the reference config
Intervals are padded, sorted, merged for overlaps, and the chr prefix is added/removed as necessary
A version of every capture space is generated for every genome build associated with a given genome build version (i.e. a capture space associated with GRCh37 will be built for hs37d5, hg19, GRCh37 etc)

Added a function within Strelka, Manta, MuTect, LoFreq, and SAGE that obtains the appropriate capture space for a given sample
Modified vcf2maf module to support additional reference genomes
Bugfixes

All review comments and outstanding changes have been addressed. This version was tested both on GSC and Cedar. It is ready for re-review

Does this still need more revisions?

Yes, this still need some updates. I am tracking down bugs and making sure it works consistently. Haven't pushed some recent bug fixes, but will do it today. Can focus on finalizing it this weekend and making sure it is good to go.

Happy to report this PR is ready for re-review. In addition to maintaining current functionality, I ensured this is now reproducible, works for both exomes and genomes, and regenerates all reference files if none are present upfront. In addition, the capture_space column is optional, mutect2 will run on chromosomes deemed mutated through candidate positions and will not error out if some chromosomes are missing, and can take local bed files to use for specific custom capture without downloading them from the internet.


💼 updating years on template files

Description
updated the years on the copyrights etc, also added missing adobe and year to apache license template (woops!)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks for doing this


Failing specs

All the specs have been failing since c0fa7e4d96c69319a109be39783e9e7d26d98bb8, including the commit where you released version 1.3.0.  That doesn't make me feel too confident about whether or not travis-ci-status is working as expected...

Yep! The package works, I'm just still learning how to write atom packages. If you're concerned, please feel free to revert to the previous version until I fix it (or submit a PR)


Add Records

Shows records of different areas.

Shows records of different areas.

Need more details pls.

CalculateRecords()


Unicode warning fix and updated readme.md

RuntimeWarning: Argument <type 'str'> is not an unicode object. Passing an encoded string will likely have unexpected results.

Will do that in a while


Allowing commas after methods - Issue #120

Solve #120.
When multiple methods (functions) are defined inside methods! and unsafe_methods! macros, commas after the methods is now allowed.
After this change, we can still select the case without commas, as before.
Reference:

The Rust Reference
How to allow optional trailing commas in macros? (Stack Overflow)

This is now in the master branch and Rutie crate 0.8.2


hack to reduce gpu memory usage

added a gpu warmup method that reduces GPU memory usage

I'm still working out some bugs with our github runner container.  Let me fix this compiler issue and I'll rerun the checks.

The github runner uses cuda 11.4

The issue is with environment variable: CTEST_PARALLEL_LEVEL which is begin set by either the system or spack, i.e., see here:
https://spack.readthedocs.io/en/latest/_modules/spack/build_systems/cmake.html
This is causing multiple tests to run on top of each other and the GPU cannot handle it.

It does reduce the memory usage, but it is not the mains source of the problem.


Add Support for new Intents

Add support for the CreateOrUpgrade and Adopt intents.

Closed by PR #76


add feedback section

## Feedback

[![@kamilsk](https://img.shields.io/badge/author-%40ikamilsk-blue.svg)](https://twitter.com/ikamilsk)
[![@octolab](https://img.shields.io/badge/sponsor-%40octolab-blue.svg)](https://twitter.com/octolab_inc)

## Notes

- made with ❤ by [OctoLab](https://www.octolab.org/)

already there


[New Port Request]

Library name
csv-parser
Library description
No response
Source repository URL
https://github.com/vincentlaucsb/csv-parser
Project homepage (if different from the source repository)
No response
Anything else that is useful to know when adding (such as optional features the library may have that should be included)
No response

@sangoblin Please try #32780


'Permission' is ambiguous for type lookup in this context and add Xcode 10 Support

Please update the support for xcode 10

Im facing one more issue. Im using Realm and this library. I have a naming conflict. Please look at this. There is public class called permission which is conflicting the class in this library.
This is the first time i faced this type of issue. Who has to change the class name. Is there any work around with out changing the class name. Please check the error below.

Please help. Thank you.

@perlasivakrishna for this type of issues (when multiple modules have same declared types with same name), you should use explicitly Module.TypeName scheme when using them
(your case: func permissionSet(... didRequestPermission permission: Permission.Permission) {})

I tried the same. With out importing those modules. but not working


4PX strategy and other fixes

Added 4PX strategy
Fixed bugs with CainiaoStrategy
CainiaoStrategy supports a status, when parcel hasn't been collected by post office. Added icon for that status
Fixed translations where they weren't present
Small fixes in update notifications

I remember making fire warning app for fire departmen worker once but it was for old android os version. I was there able to receive SMS contents, sadly every each one of them as a privacy issue. I was somehow using broadcast receiver and some flag telling android os that this apps wants to receive sms.

Yes, I was reading somewhere that you can't set a Broadcast Receiver in Manifest because Android doesn't allow that.

What about the rest, 4PX? Is it fine?

I need to go sleep now unfortunately so I review it tomorrow. :D obviously it will be great since your code has great all the time.

Ok, good night

So how's the review going? 😁

Haha, I am still at my full time job, review starts after 5-6 pm today.

Oh, ok. I'll wait 🙂

I tried with code found from aftership<PHONE_NUMBER>74890249338827578113 not sure does it work right

I can try in an moment

Aaa it works but cannot see events... got response:
{"result":1,"message":"操作成功","data":[{"channelTrackCode":null,"ctEndCode":"US","ctEndName":"America","ctStartCode":"CN","ctStartName":"China","duration":22.0,"queryCode":"420721289274890249338827578113","serverCode":"420721289274890249338827578113","shipperCode":"302744164149","status":1,"tracks":[{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1596587400000,"tkDesc":"Missent","tkLocation":"Bull Shoals,AR","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1596581640000,"tkDesc":"Arrival at unit","tkLocation":"Bull Shoals,AR","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1596054346000,"tkDesc":"Tendered for delivery","tkLocation":"Memphis,TN","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1596047727000,"tkDesc":"Dn received","tkLocation":"Memphis,TN","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1595909574000,"tkDesc":"Dn send","tkLocation":"Melrose Park,IL","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1595865650000,"tkDesc":"Encoded","tkLocation":"Melrose Park,IL","tkTimezone":null},{"tkCategoryCode":null,"tkCategoryName":null,"tkCode":null,"tkDate":1595865634000,"tkDesc":"Received","tkLocation":"Melrose Park,IL","tkTimezone":null},{"tkCategoryCode":"D","tkCategoryName":"","tkCode":"FPX_D_STPP","tkDate":1595692800000,"tkDesc":"In transit, it's progressing through post network","tkLocation":"ORD","tkTimezone":""},{"tkCategoryCode":"M","tkCategoryName":"","tkCode":"FPX_M_ATA","tkDate":1595587860000,"tkDesc":"Arrived at the destination airport","tkLocation":"ORD","tkTimezone":"UTC-06:00"},{"tkCategoryCode":"I","tkCategoryName":"","tkCode":"FPX_I_RCUK","tkDate":1595486280000,"tkDesc":"Released from customs: customs cleared.","tkLocation":"ORD","tkTimezone":"UTC+02:00"},{"tkCategoryCode":"M","tkCategoryName":"","tkCode":"FPX_M_DFOA","tkDate":1595445720000,"tkDesc":"Shipment departed from airport of origin country","tkLocation":"CAN","tkTimezone":"UTC+08:00"},{"tkCategoryCode":"M","tkCategoryName":"","tkCode":"FPX_M_AAHK","tkDate":1595245440000,"tkDesc":"Arrived at hong kong hub.","tkLocation":"ORD","tkTimezone":""},{"tkCategoryCode":"C","tkCategoryName":"","tkCode":"FPX_C_ADFF","tkDate":1595066029000,"tkDesc":"Depart from facility to service provider.","tkLocation":"Shenzhen,China","tkTimezone":"UTC+08:00"},{"tkCategoryCode":"C","tkCategoryName":"","tkCode":"FPX_C_SPLS","tkDate":1594797034000,"tkDesc":"4px picked up shipment.","tkLocation":"Shenzhen,China","tkTimezone":"UTC+08:00"},{"tkCategoryCode":"C","tkCategoryName":"","tkCode":"FPX_C_AAF","tkDate":1594797034000,"tkDesc":"Shipment arrived at facility and measured.","tkLocation":"Shenzhen,China","tkTimezone":"UTC+08:00"}]}],"tag":"14"}

Let me check where does that null pointer occur

Yes no problem! I go do other things, will get back soon again. I release update when all is fine.

Ok. Found out that those didn't have tkCodes. I've managed to extract what parcel's statuses mean, and now did "delivered" detection properly.
Meanwhile I also did the issue #24, commit coming shortly

And did this empty view in archive and main menu, because in my opinion, it's great user experience when you see the app telling that list is empty:

🥇 Two people here looking this "small" but really big user experience making change. I tested it out, very very nice addition. Also 4PX events are loading! 🥇 👍  super work!

nice!

Release is out.

Excited waiting the update become live in Google Play 😆

Mee too!

But why does the play store say that this app contains ads? Does it? I haven't seen so far any of them

There was ads long time ago till decided to remove them because too annoying for app like this. I updated developer console details and set it not to have ads.

Ok.

Great work! The new "empty" screens make a lot more polished look and improve user experience. :+1:

But why does the play store say that this app contains ads? Does it? I haven't seen so far any of them

There used to be this "view an ad" button on the about view (or menu). I'm too lazy to check if it's still there but if it is, I'd assume that'd cause Play Store to display the message. Or maybe it's in the XML manifest or similar? Although I'm a long time Java developer I don't have direct Android experience, only through React Native...

But why does the play store say that this app contains ads? Does it? I haven't seen so far any of them

There used to be this "view an ad" button on the about view (or menu). I'm too lazy to check if it's still there but if it is, I'd assume that'd cause Play Store to display the message. Or maybe it's in the XML manifest or similar? Although I'm a long time Java developer I don't have direct Android experience, only through React Native...

Those are deleted and soon play store should not so that because I had toggle on contains ads at play store.

That might even boost interest. Especially as Posti's own app has started displaying inline adds between tracked packages which I find quite annoying. Especially as a new ad sometimes appears when refreshing the statuses if the previous one has been cleared...

That might even boost interest. Especially as Posti's own app has started displaying inline adds between tracked packages which I find quite annoying. Especially as a new ad sometimes appears when refreshing the statuses if the previous one has been cleared...

That is good news that they first create great app and now kill it slowly with ads

Yep but it still has some advantages that I doubt can be implemented by a third party unfortunately. For example on home delivery packages they'll inform you through the app day or two before and allow selecting if you want the package delivered home or to a Posti pickup point of your choosing.
Another less important but also useful feature is that you'll see some of the tracked packages appearing automatically. Occasionally when buying something from let's say AliExpress, the tracking code might change midway without the seller knowing about it. I doubt they offer an API for this either?
These reasons are why I have the app installed although I primarily use PS for tracking (not to mention logging/archiving and support for other couriers).

"For example on home delivery packages they'll inform you through the app day or two before and allow selecting if you want the package delivered home or to a Posti pickup point of your choosing."
Is this possible to do in their website or outside their app? And does that require some kind of authorization?

Is this possible to do in their website or outside their app? And does that require some kind of authorization?

I believe there might be just a simple SMS if I wasn't registered on their app actually. Definitely there has to be another way to pick the location.
For my second point the alternative to new packages appearing automatically (strangely happens only with some deliveries) would be to wait for the paper note to arrive when the package can be picked. As we all probably know it will often delay things for one day.


Dry-run mode is broken

In the current version 2.23.2, the dry-run mode seems to be broken.
To reproduce, follow these steps:

npx create-nx-workspace --preset=core

In the folder created by create-nx-workspace:

npm install -D @jscutlery/semver
npm install -D @nrwl/react
nx g @nrwl/react:lib mylib --publishable --importPath="@myorg/mylib"
nx g @jscutlery/semver:install
echo "// some change" >> packages/mylib/src/index.ts
git add packages/mylib/src/index.ts
git commit -m "feat: some feature"
nx version mylib --dryRun --skipProjectChangelog

It produces the following error:
[mylib] � No previous version tag found, fallback to version 0.0.0.
        New version will be calculated based on all changes since first commit.
        If your project is already versioned, please tag the latest release commit with mylib-x.y.z and run this command again.
[mylib] � Calculated new version "0.1.0".
[mylib] ❌ Error
    at REDACTED\node_modules\@jscutlery\semver\src\executors\common\exec.js:10:34
    at ChildProcess.exithandler (node:child_process:406:5)
    at ChildProcess.emit (node:events:520:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Also, the package.json file of mylib is modified although it shouldn't be in dry-run mode.
Without the --dryRun flag, everything works fine.
Environment:

@jscutlery/semver 2.23.2
git version 2.35.2.windows.1
OS: Windows 10 21H2 19044.1645

Hi, thanks for the report and the reproduction steps. I will investigate.


Inno setup - automatically install language pack

Testing #205564
I might misunderstand the scope of the work here but I would have expected that if I go through the setup using a particular language, when the product launches it would make the language of the setup. I think that it would be nice to automatically install the language pack that matches the setup language.

This is not very related to the scope of this work, however, this is still a valid feature request and I wondered the same thing after running the setup scripts in the different languages. Maybe @joaomoreno or @TylerLeonhardt can clarify why we aren't doing so yet.

Might be a cool thing to explicitly call out in the setup. Streamline things.
Today, after they install VS Code and they open it for the first time, you do get a notification that says "do you wanna get the language pack" in the language that their OS is set to (if we have a language pack for that language of course)
So we do kinda have a solution for this, but it's not as nice as a checkbox in the setup.


added new languages

Not ready for review. I still need to confirm language codes with Reeza and also add po files.

@miltontony @saeedmb8 Ready for review

@saeedmb8 Please review

👍


Fix a build error on Windows

Motivation:
Yarn 1.12.1 creates a broken symlink:

https://github.com/yarnpkg/yarn/issues/6585
https://github.com/yarnpkg/yarn/issues/6615

Gradle fails the build on Windows when it encounters a broken symlimnk:

https://github.com/gradle/gradle/issues/1365

Modifications:

Delete broken symlinks after running :docs-client:yarn

Result:

Gradle is happy. Build is green.

Still fails. Will add some debug messages to learn what's happening there.

LGTM again~!


Fork choice: make sure head() have correct justified/finalized epoch like the store

Goal

Close #637

Approach
TODO

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tuyen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.


Update serde to 1.x.y

I am opening this PR to open discussion about plans to migrate to serde 1.x.y

There were the following issues with your Pull Request

Commit: f15c2fcae8a0dbd3ba763cd66198cfd14712dc14

Commits must be in the following format: %{type}(%{scope}): %{description}

Commit: 7f3054012a37ac03745c8273c7ba7ca1e9052164

Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/rustless/valico/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

@korczis I could also use a version of valico that worked with stable serde.

@korczis @camjackson @s-panferov
Hello! I'm the principal author of compose_yml and cage, two Docker-related development tools that rely on valico. We've been very happy with valico for schema validation!
Recently, I updated both tools to use serde 1.0. Unfortunately, this meant that I had to disable valico, which caused a couple of fairly major regressions in compose_yml and cage. I would love to get back valico's great validation support.
Is there anything I could do to help get this PR merged (and the corresponding changes to jsonway at https://github.com/korczis/jsonway/commit/8a142a0799d9f7afdf5ec1957c1c6791b80d8013)? I'd be happy to devote some engineering time to this.
Also, this would have the advantage of leaving valico in a stable state for the long term, because serde 1.0 is likely to stick around indefinitely. Also, it would be possible to re-export serde_json as valico::serde_json, which would allow valico to keep working even if serde 2.0 is released some day.
Thank you very much for valico, and for considering this PR! Please let me know if there's anything at all that I can to smooth the merging process.

Really interested on this also, @korczis  any progress?


Add Kubernetes section in Usage MTU doc

Someone was asking in IRC how to make their changes permanent so I thought it would be good to add info to the Usage MTU doc for k8s specifically.

lgtm.

I think a note should still be present in this doc that they should be updated in the manifest so the changes are permanent.
I think adding them to the manifests is just a nice addition but doesn't remove the need for something in this doc.  I don't think it would be confusing to have both.

PTAL

In the manifests with calico routing I'm thinking maybe the "mtu": 1500 in the cni config should be set to 1440 because IP-in-IP is enabled.  It isn't a question here if it enabled or not.

It isn't a question here if it enabled or not

Yes, but people have the option of disabling IPIP via the manifest.  I think that wording just makes it more clear that this variable only takes effect when ipip is enabled.


Use stable, not broken, version of keystone

At the moment, running npm install on keystone-demo results in a broken setup (500 when attempting to create new blog/gallery/etc).
Keystone repo README states that "Work on this has now been merged into our master branch, which is currently not stable (but which we encourage you to try out and give us feedback on!). Stable 0.3.x releases will continue to be published from the 0.3.x branch."
This PR locks the version of keystone.js to the latest stable version, 0.3.15.
Locking the version allows keystone-demo to work but unfortunately the keystone.js version will have to be updated at some point in the future.

Hi @codebling,
Thanks, and apologies for the issues running keystone on master. I'd really like to push ahead with the latest version, so I've addressed the problems and it should run correctly now (I've also updated the live demo). Please let me know if you find any other issues running the demo with the latest version!

Thanks, I'll give it another try and let you know !

It's working! Thanks!


Where is the TokenArtifact.json and contract-address.json from dapp.js ?

import TokenArtifact from "../contracts/Token.json";
import contractAddress from "../contracts/contract-address.json";
Should I compile contracts into the src folder?

problem solved

Same problem.

problem solved
Solved how ?

@castorinop
https://github.com/crapthings/hardhat-dapp-starter
https://github.com/crapthings/hardhat-dapp-starter#connect-to-your-contract-address
https://github.com/crapthings/hardhat-dapp-starter/blob/main/dapp-ui/src/stores/index.js#L8


Keep arg values on stack to prevent segfault in user-created function

I do not know a lot about Ruby garbage collection internals and the use of RB_GC_GUARD, but certainly from what I've found, keeping VALUE on the stack prevents premature collection.
I can easily cause a segfault by creating a user-defined function that itself creates Ruby objects while doing its work. This fix seems to alleviate the segfaults, and I think it's because this directly puts the VALUE pointers on the stack, where garbage collection cannot miss them.

RB_GC_GUARD should work.  Can you provide a repro that segvs?  If it's not working maybe we need to fix something upstream.

RB_GC_GUARD makes sure, that the param is stored on the stack and not GC'ed, but only for the scope of the variable. Since the scope is limited to the inner loop, only the current value is protected, not the whole array.
Variable length arrays as in the PR on the other hand are a C99 feature, which is not supported on MS-Visual C. They are also limited by the stack size of the process (typically 8MB on Linux).
Another (but slightly slower) alternative could be calling rb_gc_register_address() / rb_gc_unregister_address() on each array value or the usage of rb_ary_new() and RARRAY_PTR instead of xcalloc() .

I will put together a simple repro that segfaults. It will take a bit of time to find just the right function that fools the GC into releasing the relevant objects, but I should be able to find a simple case that does it.

RB_GC_GUARD makes sure, that the param is stored on the stack and not GC'ed, but only for the scope of the variable. Since the scope is limited to the inner loop, only the current value is protected, not the whole array.

Argh yes.  Totally makes sense.
@jimflood I think converting this to rb_ary_new rather than using xcalloc would be fine.

OK. I've been busy today, but let me find time to create a reproducible segfault, and then fix it with rb_ary_new and then update the pull request.

@jimflood I don't think we need a segv repro, just the fix.  @larskanis was kind enough to point out what I was overlooking in the code.  This is definitely a bug in sqlite3-ruby.  Thank you for fixing this.

Well, this definitely reproduces the crash, reliably:
require 'sqlite3'
require 'openssl'

db = SQLite3::Database.new("test.db");

db.create_function("bug", -1) do |func, *values|
  hmac = OpenSSL::HMAC.new("1234567890123456", OpenSSL::Digest.new('sha256'))
  values.each { |value| hmac.update(value) }
  func.result = hmac.digest
end

n = Array.new(127, File.read("setup.rb"))
markers = Array.new(n.length, "?").join(",")

m = Mutex.new
threads = []
for i in 0..100
  threads << Thread.new do
    m.synchronize { puts Thread.current }
    m.synchronize { result = db.execute("select bug(#{markers})", *n).inspect }
  end
end

threads.each { |thr| thr.join }

db.close

$ git checkout rb_gc_guard_unreliable
$ rake install_gem
$ ruby bug.rb
and it works fine, every time.
$ git checkout master
$ rake install_gem
$ ruby
and it crashes, every time:
crash_output.txt

Comment out this line:
     skip("Segfault is unsettling to see when running rake test")
in test/test_database.rb, and this line:
     rb_ary_push(guard, param);
in ext/sqlite3/database.c
and you should see the segfault that this fixes. It's probably system dependent but 30 threads and 127 params of 28,000 chars each per function call hits it every time when I run it here.
I'm assuming that Ruby GC will (properly) take care of the allocated guard array for me.

@jimflood yes, the GC should take care of the allocated array for you.

Good! Thx.


Modify the exception message when is caused by SSLHandshakeException

When is not possible to download the channel file or manifest due a certificate issue or SSL issue, the excepcion is ChannelDefinitionException with a message:
ERROR: Invalid channel manifest definition
PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

I think could be better if we can show a more related error in this case

@rdnovell, looks good, thanks.  Could you squash the commits into one and force-push your branch before I merge it?

@spyrkob Done, thanks


Volatile Messages

Hello,
Is it possible to send volatile messages?..I couldn't find anything in the documentation online....
Thanks

Hi jafar, unfortunately volatile messages is not a supported option right now.


Research for Science Museum API integration

This issue is to track @kss682's research on the issue #302, and separate that contribution from the general implementation concerns of that issue.

@mathemancer So all the works related to issue #302 should be added here.

@kss682 No, we changed our process.  Don't worry about it.


CPF-2117 Fix compliance rule history view

https://nanopay.atlassian.net/browse/CPF-2117

I signed it!


core[patch]: check all BaseModel versions

After this PR chat models will correctly handle pydantic 2 with bind_tools and with_structured_output.
import pydantic
print(pydantic.__version__)

2.8.2
from langchain_openai import ChatOpenAI
from pydantic import BaseModel, Field

class Add(BaseModel):
    x: int
    y: int

model = ChatOpenAI().bind_tools([Add])
print(model.invoke('2 + 5').tool_calls)

model = ChatOpenAI().with_structured_output(Add)
print(type(model.invoke('2 + 5')))

[{'name': 'Add', 'args': {'x': 2, 'y': 5}, 'id': 'call_PNUFa4pdfNOYXxIMHc6ps2Do', 'type': 'tool_call'}]
<class '__main__.Add'>

from langchain_openai import ChatOpenAI
from pydantic.v1 import BaseModel, Field

class Add(BaseModel):
    x: int
    y: int

model = ChatOpenAI().bind_tools([Add])
print(model.invoke('2 + 5').tool_calls)

model = ChatOpenAI().with_structured_output(Add)
print(type(model.invoke('2 + 5')))

[{'name': 'Add', 'args': {'x': 2, 'y': 5}, 'id': 'call_hhiHYP441cp14TtrHKx3Upg0', 'type': 'tool_call'}]
<class '__main__.Add'>

Addresses issues: https://github.com/langchain-ai/langchain/issues/22782

@baskaryan thank you! I'll update this tomorrow. I think we can roll this out after we also get the standard tests for chat models updated and passing. Note that this could be a breaking change for some users if they've been relying on the functinality given the bug with with_structured_output and pydantic 2

Taking over

https://github.com/langchain-ai/langchain/issues/22782


zos: allow uv_tcp_listen to be called without uv_tcp_bind

On zOS the listen call does not bind automatically if the socket
is unbound. Hence the manual binding to an arbitrary port is
required to be done manually.

We cannot use this approach because it would break the ABI. Can you instead add a new flag? Windows already uses UV_HANDLE_BOUND, Unix could do the same to keep track of the bound state. This could be added to tcp, udp and pipe handles.

LGTM with a couple of style nits. Can you please squash the commits?

Landed in f4ef897.


added indexes to measure and patients

bundle exec rake db:mongoid:create_indexes
To add indexes. This should be done before conversion.
Pull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-2101
[x] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Test fixtures updated and documented as necessary ( see internal wiki )
[x] Code coverage has not gone down and all code touched or added is covered.

In rare situations, this may not be possible or applicable to a PR. In those situations:

Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:

[x] Automated regression test(s) pass

Reviewer 1:
Name:

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

Reviewer 2:
Name:

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

Not relevant. Will fail to run due to HDS value sets having bad indexes. Run 2019-standards-update instead.


Demo it is not available

the demo link it is not working

Because we are migrating our service, so it may be unstable recent days


postfix patterns for pypolicyd-spf

Added support for pypolicyd-spf (https://launchpad.net/pypolicyd-spf/)
Added email address parsing for username and domain
Added grok pattern to find stage of postfix if not using condition of program
ex:
filter {
grok {
patterns_dir   => "/etc/logstash/patterns.d"
match          => [ "message", "%{POSTFIX_STAGE}" ]
tag_on_failure => [ "_grok_postfix_stage_nomatch" ]
add_tag        => [ "_grok_postfix_stage_success" ]
}
# grok log lines by program name (listed alpabetically)
if [postfix_stage] =~ /^postfix.*\/anvil$/ {
    grok {
        patterns_dir   => "/etc/logstash/patterns.d"
        match          => [ "message", "%{POSTFIX_ANVIL}" ]
        tag_on_failure => [ "_grok_postfix_anvil_nomatch" ]
        add_tag        => [ "_grok_postfix_success" ]
    }
}

Examples from my mail logs for the output of pypolicyd-spf
Aug 17 10:08:05 test policyd-spf[21135]: Pass; identity=helo; client-ip=<IP_ADDRESS>; helo=helo1.example.com<EMAIL_ADDRESS><EMAIL_ADDRESS>Aug 17 10:08:05 test policyd-spf[21135]: Fail; identity=mailfrom; client-ip=<IP_ADDRESS>; helo=helo1.example.com<EMAIL_ADDRESS><EMAIL_ADDRESS>Aug 17 10:08:10 test policyd-spf[21135]: Pass; identity=helo; client-ip=<IP_ADDRESS>; helo=helo2.example.com<EMAIL_ADDRESS><EMAIL_ADDRESS>Aug 17 10:08:11 test policyd-spf[21135]: Pass; identity=mailfrom; client-ip=<IP_ADDRESS>; helo=helo2.example.com<EMAIL_ADDRESS><EMAIL_ADDRESS>

While I can see the value of your work, I don't think parsing the log lines produced by a non-postfix program should be in this repository. You can easily add the grok patterns and the logstash config in separate files to your logstash setup, no need to mix things up.
Same goes for email address parsing: very useful to some people, but this is not relevant or unique to postfix.
FWIW: I have spamassassin grok patterns working together with the patterns in this repository, but I won't add them for the same reason.

Thanks for explaining the project and thanks for the work you have already
put in.  It has made my life a lot easier.
On Fri, Sep 11, 2015 at 3:13 AM, Tom Hendrikx<EMAIL_ADDRESS>wrote:

While I can see the value of your work, I don't think parsing the log
lines produced by a non-postfix program should be in this repository. You
can easily add the grok patterns and the logstash config in separate files
to your logstash setup, no need to mix things up.
Same goes for email address parsing: very useful to some people, but this
is not relevant or unique to postfix.
FWIW: I have spamassassin grok patterns working together with the patterns
in this repository, but I won't add them for the same reason.
—
Reply to this email directly or view it on GitHub
https://github.com/whyscream/postfix-grok-patterns/pull/60#issuecomment-139507177
.


fix files.Walk utility function

Description

Verification Steps

Checklist (Definition of Done)

[x] All acceptance criteria specified in JIRA have been completed
[x] Unit and integration tests added that prove the fix is effective or the feature works (tested against emulated and non-emulated OCM environment)
[x] Documentation added for the feature
[x] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer
[ ] All PR comments are resolved either by addressing them or creating follow up tasks
[x] Required metrics/dashboards/alerts have been added (or PR created).
[x] Required Standard Operating Procedure (SOP) is added.
[x] JIRA has been created for changes required on the client side

Fixes https://github.com/bf2fc6cc711aee1a0c2a/cos-fleet-manager/issues/135

@VanillaSpoon can we proceed with this one?


Selection & Scrolling is slow (laggy) if code contains i18n directives.

Describe the bug
Selection & Scrolling is slow (laggy) if code contains i18n directives.
Extension Version
i18n Ally v2.3.18
Framework/i18n package you are using
TypeScrpit/React
To Reproduce
Steps to reproduce the behavior:

Open a tsx file (this propbably can be another supported format but im on tsx)
Locate a code piece that includes i18n.t('') directive.
Try to select few lines. You will noticve that selection follows your cursor slowly. There is a delay. When this happens you also get High CPU usage.
Now locate another piece of code that does not include anything related to i18n. Try to select few lines and selection follows your cursor instantly.
See the video attached below. It is 30fps. You will see that if selection contains i18n then selection is slow. In fact I didnt recorded but also scrolling on that area is also slow. But when you go above or below the code that does not contains i18n, everything is smooth.

Device Infomation

OS: Windows 10 as host, Ubuntu 20.04 as Remote SSH / Guest
Version: See above
VS Code Version: 1.49.0

Extension Log
🈶 Activated, v2.3.18

――――――

💼 Workspace root changed to "/home/gencer/sources/nienbo/bitpaket"
📦 Packages file "package.json" found
🕳 Packages file "pubspec.yaml" not exists
🕳 Packages file "composer.json" not exists
📦 Packages file "Gemfile" found
🌞 Enabled
🧩 Enabled frameworks: React
🧬 Enabled parsers: json, yaml, json5

🚀 Initializing loader "/home/gencer/sources/nienbo/bitpaket"
📂 Directory structure: dir
🗃 Path Matcher Regex: /^(?<locale>[\w-_]+)(?:.*\/|^).*\.(?<ext>json|ya?ml|json5)$/

📂 Loading locales under /home/gencer/sources/nienbo/bitpaket/app/javascript/components/locales
	📑 Loading (en) en/translations.yml [1600231886705.433]

👀 Watching change on /home/gencer/sources/nienbo/bitpaket/app/javascript/components/locales
✅ Loading finished

――――――

Screenshots
See video on: https://www.screencast.com/t/fO9Q8Dj2Rs3

@gencer Thanks for catching this up. Just added a throttle & released in v2.3.19. Can you try it out if there are any improvements?

@antfu Thanks!. A bit better but still slow on that area.

@antfu Thanks!. A bit better but still slow on that area.
Disabling extension solves that slowness.

@antfu It seems I had to "kill" remote vscode server. Since 2 days I see no lag. Thank you for this quick fix!


[bug report] h100 attn_causal kernel

Using the same random seed, the result of tk h100 attn_causal kernel vary with each run. In some cases, the max diff between tk and pytorch result can be larger than 2.

It turns out that a wgmma fence needs to be added after wgmma async wait. I have created a PR for your reference. https://github.com/HazyResearch/ThunderKittens/pull/34

Thanks for sharing your PR @xiayuqing0622.
There should be a wgmma async_wait after the wgmma is committed. As you know, the wgmma API launches an async matrix multiply on the H100 tensor cores across the 4 warps in the warpgroup via the commit_group function exposed. In order to ensure this is completed, you need to call and async_wait on it - this was missing from the original code and has now been added to the the relevant .cu file in the main branch.
Re your PR, the wgmma fence/syncthreads() should not be necessary in order to achieve correctness. The fence is needed when on the output register tile before you launch the wgmma async instruction. Furthermore, the syncthreads() will likely unnecessarily slow performance.
Does the latest fix on main fix the randomness you were seeing?

Thanks for sharing your PR @xiayuqing0622.
There should be a wgmma async_wait after the wgmma is committed. As you know, the wgmma API launches an async matrix multiply on the H100 tensor cores across the 4 warps in the warpgroup via the commit_group function exposed. In order to ensure this is completed, you need to call and async_wait on it - this was missing from the original code and has now been added to the the relevant .cu file in the main branch.
Re your PR, the wgmma fence/syncthreads() should not be necessary in order to achieve correctness. The fence is needed when on the output register tile before you launch the wgmma async instruction. Furthermore, the syncthreads() will likely unnecessarily slow performance.
Does the latest fix on main fix the randomness you were seeing?

@Aaryan0404 Thanks for your reply. Actually, after reading the document of cuda, I also believe the wgmma fence/syncthreads() is not necessary. However, just adding async wait does not fix the randomness (I just tested it on the latest main branch). I don't know why.  Here is my test script (just add a debug function in h100_fwd_check.py):
import torch
import sys
import os
import time

current_dir = os.path.dirname(os.path.abspath(__file__))
project_root = os.path.abspath(os.path.join(current_dir, "../../"))
sys.path.insert(0, project_root)
from src.common.pyutils.test_build_utils import __eq
sys.path.append('build/lib.linux-x86_64-cpython-312')
import h100_fwd as mod

from collections import defaultdict
import matplotlib.pyplot as plt
from statistics import median
import torch
import torch.nn as nn
import torch.nn.functional as F
from einops import rearrange
torch.manual_seed(0)

def debug(name,expect, actual, atol=1e-3, rtol=1e-3):
    all_close = torch.allclose(expect, actual, atol=atol, rtol=rtol)
    print(name + "  all_close={}".format(all_close))
    if not all_close:
        diff = (expect - actual).abs()
        print("all_close={}, max={}, min={}, mean={}".format(all_close, diff.max().item(), diff.min().item(), diff.mean().item()))
        max_indices  = torch.nonzero(diff == diff.max().item())
        first_index = tuple(max_indices[0].tolist())
        print(f"Index: {first_index}, expect: {expect[first_index]}, actual: {actual[first_index]}")

def pytorch_test(Q, K, V):
    output = torch.nn.functional.scaled_dot_product_attention(Q, K, V, is_causal=True)
    return output

def h100_fwd_kernel_test(Q, K, V):
    o = torch.zeros_like(Q)
    mod.attention_forward_causal(Q, K, V, o)
    return o

def check_correctness(b, h, n, d):
    print(f"Testing with b={b}, h={h}, n={n}, d={d}")

    Q = torch.randn(b, h, n, d, dtype=torch.bfloat16, device='cuda').contiguous()
    K = torch.randn(b, h, n, d, dtype=torch.bfloat16, device='cuda').contiguous()
    V = torch.randn(b, h, n, d, dtype=torch.bfloat16, device='cuda').contiguous()

    result_pytorch = pytorch_test(Q, K, V)
    tk_result = h100_fwd_kernel_test(Q, K, V)

    diff = result_pytorch - tk_result
    avg_diff_mag = torch.mean(torch.abs(diff)).item()
    avg_diff_per = 100 * avg_diff_mag / torch.mean(torch.abs(result_pytorch)).item()

    print(f"Attention output - avg magnitude of diff: {avg_diff_mag:.6f}")
    print("-" * 40)
    debug("Attention output", result_pytorch, tk_result)

print("Correctness Tests: ")
configurations = [
    # (2,  8, 256,   64),
    # (4,  8, 512,   64),
    # (8,  8, 1024,  64),
    # (16, 8, 2048,  64),
    # (16, 8, 4096,  64),
    # (16, 8, 8192,  64),
    # (16, 8, 16384, 64),
    # (2,  8, 256,   128),
    # (4,  8, 512,   128),
    # (8,  8, 1024,  128),
    # (16, 8, 2048,  128),
    # (16, 8, 4096,  128),
    (16, 8, 8192,  128),
    # (16, 8, 16384, 128)
]
for b, h, n, d in configurations:
    check_correctness(b, h, n, d)


standalone is not working properly

when clicking on the desired emoji then text of the element get changed with that single emoji.

Please create example at jsfiddle

Please create example at jsfiddle

ok

I close this because there is no response


After renaming table back, if you try to get back to the dashboard a dialog appears

Not happening anymore


Adds rough sound support for sprites

First pass on a sound API, still lots of todos.

This is fantastic!

lgtm


Notes missing from CSVProc file generated from VLD file

Issue reported by @geoffj-FUG
issue:
I have just downloaded RG11_2348.vld as a CSVPro in order to correct an entry reported by a researcher as incorrect. The incorrect information was in the notes. However when I downloaded the file the notes are missing from the whole piece. The notes did download properly until a couple of weeks ago when the suspect deleted flag warning was included in that column. The warning is no longer there so I am wondering whether the notes got removed as well at that change? This is the first vld fil I have dowloaded as csvpro since the change.

@geoffj-FUG fix has been deployed to Test3 (as per our feedback email communications. Could you please test?

Anne
I have just downloaded RG10_2500.vld from test 3. The notes are now appearing.
However, the message 'Deleted flag set on VLD; ' is now appearing on the spreadsheet.
In addition, we still have the problem of the notes downloaded twice, the two downloads concatenated.
Geoff

This cannot be pushed to live until the Deleted flag issue and the notes field fixed. @AnneV-Learn can you ask Geoff if you need additional information is needed on what these problems are.

@geoffj-FUG Test3 has now been updated with code that I hope will fix the issue raised in your comment above. Please retest on Test3.

Anne
This looks OK now. If we can move it to production I will retry it with the file that the problemm was identified in in the first place. Coordinators have been told not to use the vld download at the moment so I will be the only one who knows it can be used. If all is OK I will put it on the coordinators board that it is working again.
Geoff

@geoffj-FUG this has now been deployed to the production environment.


fix: combining 'end' and 'strict'

This Playground illustrates the problem:

Playground

The bottom row is the one that isn't working correctly. This combination of options:
{
  path: '/user/',
  strict: true,
  end: false,
  component: ...
}

should match the location path /user/1, but it doesn't.
The reason why is the RegExp is checking for the / twice:
^/user/(?:/|$)

While I've added a lot of extra testing for end: false, only two of those assertions would have failed with the previous code. Specifically, this one of line 666:
matchParams('/home/', '/home/other', {}, options)

and this one on line 673:
matchParams('/home/:p/', '/home/a/b', { p: 'a' }, options)

In both cases they would previously have failed to resolve the route.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.90%. Comparing base (13303bd) to head (4fce5c0).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2154   +/-   ##
=======================================
  Coverage   90.90%   90.90%
=======================================
  Files          24       24
  Lines        1121     1121
  Branches      347      347
=======================================
  Hits         1019     1019
  Misses         63       63
  Partials       39       39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Inconsistency with adjustsFontSizeToFitWidth

The styler for adjustsFontSizeToFitWidth is different from UILabel to UITextField
UILabel -> adjusts_font_size
UITextField ->  adjusts_font_size_to_fit_width
aliases are needed to make this consistent.
Also, only one of these is tested, it seems - Notice here:
https://github.com/infinitered/rmq/search?utf8=✓&q=adjustsFontSizeToFitWidth

the actual method names for UILabel and UITextfield are mirrors of the RM stylers. I say we leave alone (notwithstanding the tests) since it behaves just like you'd expect based on the API documentation of those two components.

@markrickert I think you're mistaken.   Or maybe I don't understand what you're saying.
https://github.com/infinitered/rmq/blob/a7465db43196df3d5377cf43087024708d21b156/motion/ruby_motion_query/stylers/ui_label_styler.rb#L58-L59
As you can see here, the API documentation of the component is adjustsFontSizeToFitWidth but the styler is simply adjusts_font_size.   Where as on the UITextField also is calling adjustsFontSizeToFitWidth but the styler is the FULL name adjusts_font_size_to_fit_width.
https://github.com/infinitered/rmq/blob/d6b992aac9928d7577b18904451e8e60790fb82b/motion/ruby_motion_query/stylers/ui_text_field_styler.rb#L37
That is what I'm saying is inconsistent.

Aha. gotcha. Fix away!

I'll probably get to this today or tomorrow, depending :)   Issues make sure I don't forget.


Handle both debug-image and debugimage

Due to inconsistent naming, handling both debug-image and debugimage
until the issue is fixed.
Issue: https://github.com/eclipse/openj9/issues/9028 and
https://github.com/AdoptOpenJDK/openjdk-tests/issues/1696
Signed-off-by: lanxia<EMAIL_ADDRESS>

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2686/
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2692/
Grinder/6855


libiconv 1.15 and 1.16 are compatible

Fixes https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/issues/80
cc @scopatz

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Do we need to adjust the iconv run exports and pinning expression to pin only to the major version?

No, because 1.17 might not be compatible.

I see. So to summarize we'd like to have a system that does more fine-grained ABI compatibility so that we can avoid shipping a version every now and then.

I didn't understand your comment. Summary is that for packages that doesn't use semver, we have to pin strict and loosen when we know that the versions are compatible.

Right OFC. But I'd be nice to automate the loosening of the pins and if we did that, it should happen on a case-by-case basis for each new version.

Sure. It would be nice to have.
Merge?

ofc merge away!

Can we get that up as an issue though? Esp for the new spec x.x might not be very descriptive. It might be better to explicitly define the min and max compatible versions. This would cover most cases, at least until packages return to a previous ABI. In this case that would have been a change on the feedstock, when it got the version bump it would have bumped the max compatible version.

In this case that would have been a change on the feedstock, when it got the version bump it would have bumped the max compatible version.

No, metadata in downstream packages need to be fixed.


iOS Linking getInitialURL() Cannot read, copy or use the file in the url

When the app is killed and I open the app sharing a file (a zip file) if I try to unzip the file or try to copy it goes in error.
Seems it doesn't have the permissions for that file.
If I get the URL with the app open through addEventListener('url') I can use the file.
React Native version:
0.61.5

Same here o version 0.74.
Any updates on this?


bump version, update changelog

Runs cpu bound code in background executor (#44)

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   95.03%   95.03%
=======================================
  Files          11       11
  Lines         725      725
=======================================
  Hits          689      689
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13ec5d...99be275. Read the comment docs.


Separate BlockValidator from ChainController

This supersedes PR #1085 (it contains all the same commits and then some).

Addressed @peterschwarz and @nick-drozd comments