tweak for npm publish

This includes the package.json tweaks needed to publish to npm.
I've tried to expose some bits via a .d.ts and added a prePublish step to produce a dist folder which the package.json now references for entry points.
It's now published here:
https://www.npmjs.com/package/corewar

Closing cos I cocked up the dist folder which we don't really want on GH

re-opening as I think this may need two PR's to resolve, damn you .gitignore!


Sonoff TH16 warning - 2024.2.0

Hi. After the update, I have a warning in the log.
Everything works ok. Thanks for your work
Logger: homeassistant.components.climate
Source: components/climate/init.py:354
Integration: Klimat (documentation, issues)
First occurred: 14:12:12 (2 occurrences)
Last logged: 14:12:12
Entity sonoff.sonoff_1000e5a55c (<class 'custom_components.sonoff.climate.XClimateTH'>) implements HVACMode(s): off, heat, cool, dry and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/AlexxIT/SonoffLAN/issues
Entity sonoff.sonoff_1000e5a54f (<class 'custom_components.sonoff.climate.XClimateTH'>) implements HVACMode(s): off, heat, cool, dry and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/AlexxIT/SonoffLAN/issues

Correct message - please check that you are using the latest version of the component

Correct message - please check that you are using the latest version of the component

I use version SonoffLAN v3.5.4
Core 2024.2.0
Supervisor 2024.01.1
Operating System 11.5
Firmware of TH16R2 :  3.5.0
previously, before the update to HA 2024.02, this information was not in the log

Please show device diagnostics

sonoff-d6127c3e6345e5772ea3df263b78e947-Spiżarnia-f51f9681fc3fc59a4e1c4d21e05874ea.json

I can see you using latest version. Are you sure you have this warning with this version?

@AlexxIT If you can defeat this alert, can you explain what are you doing for this?
I have the same warning in another climate integration, i was implemented all needed methods, but warning still present. And this issue doesn't have clear explanation in documentation.
Adding this into integraton doesn't disable warning:
    def turn_on(self) -> None:
        pass
    def turn_off(self) -> None:
        pass

https://developers.home-assistant.io/blog/2024/01/24/climate-climateentityfeatures-expanded

https://github.com/AlexxIT/SonoffLAN/releases/tag/v3.6.0


Log message on HA start: Deprecated constants

Version of the custom_component
v3.19.5, latest at time of opening.
Configuration
No custom configuration necessary

Describe the bug
When firing up Home Assistant 2024.1.3, I received two errors around the use of deprecated constants that will be removed as part of HA 2025.1.  Errors attached below
Debug log
SOURCE_TYPE_GPS was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use SourceType.GPS instead, please create a bug report at https://github.com/alandtse/tesla/issues

and
PRESSURE_BAR was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.BAR instead, please create a bug report at https://github.com/alandtse/tesla/issues
PRESSURE_PSI was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPressure.PSI instead, please create a bug report at https://github.com/alandtse/tesla/issues
SPEED_MILES_PER_HOUR was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfSpeed.MILES_PER_HOUR instead, please create a bug report at https://github.com/alandtse/tesla/issues
TEMP_CELSIUS was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please create a bug report at https://github.com/alandtse/tesla/issues
ELECTRIC_CURRENT_AMPERE was used from tesla_custom, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfElectricCurrent.AMPERE instead, please create a bug report at https://github.com/alandtse/tesla/issues

Happy to have a crack at fixing, the error messages are pretty verbose

I’m on my phone I think one of the latest commits addressed this issue. Take a look if you haven’t, otherwise have a crack 🤓

Oops, forgot to look in Closed issues, this is definitely a duplicate 🤦   Sorry about the noise!


Feature: Add option to exclude users from stats

Would be nice to be able to exclude inactive users and bots completely.
P.S. I had to fork you action because having telemetry was not acceptable for a project I'm working on, but I'd be happy not to maintain the fork anymore if you ever consider removing Mixpanel dependency. You can take implementation of this feature from this commit and this fix. Thanks for your work!

Hi @fo2rist, thanks for your suggestions.
About excluding users, may I ask the use case? (I guess there are some collaborators who leave, but they still appearing in the stats for a while, is that the problem?)
About mixpanel, I recently added an option to prevent data from being send to external sources. The dependency still there but it's useless, does it works for for? If it doesn't, may I ask why? I need to understand to improve the privacy of the project.
Thanks

Hey!

About excluding users, may I ask the use case?

We have collaborators who should not be counted of two types:

admins/managers who leave their notes, and can change some files (like docs) but otherwise don't participate
non-human users who post technical comments, that aren't really review comments

The dependency still there but it's useless, does it works for for? If it doesn't, may I ask why?

Main reason is that while the dependency is there it's impossible to guarantee it won't fire accidentally due to a bug, or change in the default value of the parameter one day (the addition of the parameter recently is the example of such case). That means we have to lock the version, and then review the change-log every time we upgrade the action, which is impractical. Another option is to lock and never upgrade to save time, but we wanted a couple of features (like the one above) to be added.
So basically the presence of the code that can send something by mistake was the biggest concern. Without it we'd be more than happy to bring our features back upstream and switch to the original action (added one more since I wrote the comment).

Hi @fo2rist!
Thanks for your reply.
Unfortunately, I think excluding reviewers is a very specific use case, sorry about that. However I'll leave this issue opened to see if more people have the same need and maybe include it in a latter version.
About mixpanel, I think even removing the library there're still the same problems since there's nothing to prevent the library is added again. However, I refactored the telemetry module to make it easier to audit and added a robust test suite, also made it a "premium feature" for sponsors. This way I really have an incentive to ensure the telemetry option works, and is fair for people/companies supporting the project in other way.


K8SPG-514: Let users configure security context for pods

CHANGE DESCRIPTION
Problem:
Pod security context is not configurable.
Solution:
Allow users to configure pod security context.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PG version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/686/commits/1bd9f922dac01ab649de4a570b1c47293e263577
image: perconalab/percona-postgresql-operator:PR-686-1bd9f922d

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
failure

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/686/commits/0eb30159a28deaf8ee00e1a89fbfe3c3bd40675f
image: perconalab/percona-postgresql-operator:PR-686-0eb30159a

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
failure

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/686/commits/0eb30159a28deaf8ee00e1a89fbfe3c3bd40675f
image: perconalab/percona-postgresql-operator:PR-686-0eb30159a

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/686/commits/0eb30159a28deaf8ee00e1a89fbfe3c3bd40675f
image: perconalab/percona-postgresql-operator:PR-686-0eb30159a

Test name
Status

custom-extensions
passed

demand-backup
passed

init-deploy
passed

monitoring
passed

operator-self-healing
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

start-from-backup
passed

telemetry-transfer
passed

upgrade-minor
passed

users
passed

We run 12 out of 12

commit: https://github.com/percona/percona-postgresql-operator/pull/686/commits/5405359063ef7353d21771a22e4fb02061c3d7e9
image: perconalab/percona-postgresql-operator:PR-686-540535906


Socketbot crashs with non JSON incoming message

Hi there,
I'm facing an issue with socketbot and non JSON messages.
I'm creating my bot from botkit-starter-web and NodeJS app appears to crash when I'm sending non JSON message.
This is annoying in production environment :)
Thank you for Botkit, nice tool
(PS: Pull request incoming)
Reproduction

Run npm start from botkit-starter-web template

Send a string to ws://localhost:3000
const websocket = new WebSocket('ws://localhost:3000');
websocket.addEventListener('open', () => websocket.send('message'));

Boom!

Logs
undefined:1
message
^

SyntaxError: Unexpected token m in JSON at position 0
    at JSON.parse (<anonymous>)
    at WebSocket.incoming (/home/labs/botkit-starter-web/node_modules/botkit/lib/Web.js:35:36)
    at emitOne (events.js:116:13)
    at WebSocket.emit (events.js:211:7)
    at Receiver.receiverOnMessage (/home/labs/botkit-starter-web/node_modules/botkit/node_modules/ws/lib/websocket.js:720:20)
    at emitOne (events.js:116:13)
    at Receiver.emit (events.js:211:7)
    at Receiver.dataMessage (/home/labs/botkit-starter-web/node_modules/botkit/node_modules/ws/lib/receiver.js:414:14)
    at Receiver.getData (/home/labs/botkit-starter-web/node_modules/botkit/node_modules/ws/lib/receiver.js:346:17)
    at Receiver.startLoop (/home/labs/botkit-starter-web/node_modules/botkit/node_modules/ws/lib/receiver.js:133:22)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node bot.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Botkit version: 0.6.16
Operating system: Fedora (28)

@gobah Are you working on this issue?


feature: agent 安装优化补充说明

Codecov Report

Merging #985 (1dd76b8) into _V2.2.X_issue#869_optimization_agent_install (3aef50c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@                               Coverage Diff                                @@
##           _V2.2.X_issue#869_optimization_agent_install     #985      +/-   ##
================================================================================
+ Coverage                                         72.22%   72.24%   +0.01%
================================================================================
  Files                                               304      304
  Lines                                             22358    22358
================================================================================
+ Hits                                              16148    16152       +4
+ Misses                                             6210     6206       -4

Impacted Files
Coverage Δ

apps/node_man/handlers/job.py
86.32% <0.00%> (+0.26%)
:arrow_up:

apps/backend/subscription/steps/plugin.py
48.13% <0.00%> (+0.55%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


The bottom of the aligned image is missing

Using this code https://github.com/uzh-rpg/DSEC/issues/25#issuecomment-956491275, I found that there are some missing at the bottom of the aligned image, just like the picture in https://github.com/uzh-rpg/DSEC/issues/25#issuecomment-957253352.
I think this is because these areas in the original image do not exist. But these areas have events. Is there have disparity and optical flow gt in test set? And will this negatively affect the performance of the image-based algorithms?

As you guessed, this part is missing because there are image pixels after the warping at this location. But this should not impact image-based approaches because the ground truth is never available in those regions. The reason for this is that I actually filtered the ground truth based on frames and only then warp it to the event camera.
The only downside with this approach is that you assume infinite depth (or zero disparity) between the left frame and the left event camera. It would probably be better to warp it with the correct depth via a trained stereo network for example.

Your answer has solved my problem, thank you!


Removed Shaped instance for Rep

Description
and replace its uses with TypeRep based instances
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[x] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

It would be good to get the input of @lehins and @TimSheard on this one


Remove max_workers and serving_gpus from constructor

Removes max_workers from the constructor in favor of passing to judge_answers and gen_answers.  The original change was made because workers should be dependent on the particular settings of the model being served which can vary between the model being judged and the judge itself.
Any callers to max_workers= or serving_gpus= in the constructor should switch to use gen_answers and judge_answers for MTBenchEvaluator and MTBenchBranchEvaluator.
Original change made here: https://github.com/instructlab/eval/pull/107
CLI updated here: https://github.com/instructlab/instructlab/pull/2144
This change is not backward compatible with callers using max_workers or serving_gpus in the constructor.  A minor version bump should be made for the next release.

@sallyom FYI


Handle downloading files.redgifs.com URLs

Some download URLs are now redirecting to files.redgifs.com direct downloads. Example traceback:
Traceback (most recent call last):
  ....
  File "/home/flagarby/scripts/link_dropper.py", line 158, in drop_redgifs
    rg_api.download(gif.urls.hd, f)
  File "/home/flagarby/.pyenv/versions/scripts/lib/python3.10/site-packages/redgifs/api.py", line 394, in download
    return self.http.download(url, fp)
  File "/home/flagarby/.pyenv/versions/scripts/lib/python3.10/site-packages/redgifs/http.py", line 263, in download
    raise TypeError(f'"{strip_ip(str_url)}" is an invalid RedGifs URL.')
TypeError: "https://files.redgifs.com/SomeRandomIdentifier.mp4" is an invalid RedGifs URL.

Very likely, but I haven't tested enough to know how reliable that would be. I was just trying to fit your existing style for this PR before I forgot to submit my local changes.
The URL matching could probably be simplified to this:
diff --git a/redgifs/http.py b/redgifs/http.py
index eb983e5..5185e6e 100644
--- a/redgifs/http.py
+++ b/redgifs/http.py
@@ -249,18 +249,9 @@ class HTTP:
                     return f.write(data)

         # If it's a direct URL
-        if all([x in str(yarl_url.host) for x in ['thumbs', 'redgifs']]):
-            match = re.match(REDGIFS_THUMBS_RE, str_url)
-            if match:
-                return (dl(str_url))
-            raise TypeError(f'"{strip_ip(str_url)}" is an invalid RedGifs URL.')
-
-        # If it's a 'files' URL
-        if all([x in str(yarl_url.host) for x in ['files', 'redgifs']]):
-            match = re.match(REDGIFS_FILES_RE, str_url)
-            if match:
+        for pattern in (REDGIFS_FILES_RE, REDGIFS_THUMBS_RE):
+            if re.match(pattern, str_url):
                 return (dl(str_url))
-            raise TypeError(f'"{strip_ip(str_url)}" is an invalid RedGifs URL.')

         # If it's a 'watch' URL
         if 'watch' in yarl_url.path:

...and then a Content-Type check could be added as a preliminary (or folllowup) check. That could allow for a fallback scenario until you're more confident with the logic change.

I was thinking of not using regex for this. I don't even know why I used regex here in the first place because the host (redgifs.com) can be validated using yarl.
Anyways, I've pushed an update right now and from my testing, the URL should download. Here is my code that i used:
from redgifs import API

api = API().login()
result = api.get_trending_gifs()
url = result[2].urls.sd
api.download(url, 'video.mp4')

Hi, I haven't gotten a response and I noticed that this is (possibly) an alt account you've created for this PR. I've gone ahead and fixed this issue along with other minor changes: https://github.com/scrazzz/redgifs/commit/f8f7e901ec293ddfbcad1ab5a0c5a54200aa48e1
Thanks for opening this PR to address the error asap.


Improve SegTree

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Overview

max_right / min_left の追加
パフォーマンスの向上のため、非再帰による実装に変更
@values を property から getter に

Codecov Report

Merging #18 (86c1265) into master (8c5986a) will increase coverage by 0.37%.
The diff coverage is 81.81%.

:exclamation: Current head 86c1265 differs from pull request most recent head 6e074fc. Consider uploading reports for the commit 6e074fc to get more accurate results

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   81.21%   81.58%   +0.37%
==========================================
  Files          14       14
  Lines         985     1032      +47
==========================================
+ Hits          800      842      +42
- Misses        185      190       +5

Impacted Files
Coverage Δ

src/seg_tree.cr
81.17% <78.37%> (+2.33%)
:arrow_up:

src/string.cr
51.65% <100.00%> (+4.94%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


demos not working after refactored verse lib

pulled and installed new verse lib; installation worked fine. When I tried to run the demo, got the following:
polytope failed to import cvxopt.glpk.
will use scipy.optimize.linprog
Traceback (most recent call last):
File "demo2.py", line 32, in
car = CarAgent('car1', file_name=input_code_name)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/verse-0.1-py3.8.egg/verse/example/example_agent/car_agent.py", line 59, in init
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/verse-0.1-py3.8.egg/verse/agents/base_agent.py", line 6, in init
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/verse-0.1-py3.8.egg/verse/code_parser/parser.py", line 253, in parse
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/verse-0.1-py3.8.egg/verse/code_parser/parser.py", line 337, in parse
FileNotFoundError: [Errno 2] No such file or directory: './demo/vehicle/controller/example_controller2.py'

Hi, Sayan! It seems to work on my side. I think the possible reason is it runs in the wrong directory since we use relative path here. '.' mean the current directory, and './demo' means we want to find 'demo' under current directory.
Maybe you try to switch to the root folder of our lib i.e., Verse-library which the 'demo'  folder belongs to, and then run demo by python3 demo/vehicle/demo2.py
When I switch to the demo folder and run by python3 vehicle/demo2.py, FileNotFoundError occurs.
By the way, demo2.py may look abnormal, the reason is the time step is set to 1 which is too large.
What's more, I think we can also use absolute path. Just call a python function to get the absolute path of the current file and modify it to get the target file.

Ok, worked when running demo from root folder.


[FOR REVIEW] RPIP - Bounty Incentives

RPIP proposing bounty incentive levers that may be used by the GMC.

I think it would be good to have A/B/C settings over time (like RPIP-10's historical splits table). This will not gate merge as draft

I think it would be good for GMC to propose initial A/B/C settings before vote time. A second approach, which I like a little less is to explicitly set A/B/C to zero as starting points.


Question about overlay network

Hi Stefan,
I'm trying to use your example for some Windows Container stuff at work, I'm having trouble getting a definitive answer on whether routing mesh supported in Windows 2016 yet?
I'm running Docker 17.03.1-ee-3 on Windows Server 2016 (os build 14393.1358).
Thanks for all the work you are doing in this area!

From here  and various other sources the official github repos.

Routing mesh for Windows docker hosts is not yet supported, but will be coming soon.

This kind of reduces the total impact of swarm mode on windows nodes as is but the impression is that it will be supported pretty soon now.

Correct. Routing mesh is still missing. It's worth to join the Windows Server Insider preview as it should be available first before landing in an official Windows update.

Thanks for the info, I'll keep posted


Fix missing test

Codecov Report
Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.17%. Comparing base (b314f00) to head (eab8c03).

Files with missing lines
Patch %
Lines

...riment/torch_bench/_bash_bench_benchmark_runner.py
25.00%
3 Missing :warning:

experimental_experiment/ext_test_case.py
0.00%
2 Missing :warning:

experimental_experiment/args.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   73.16%   73.17%
=======================================
  Files         143      143
  Lines       20764    20760    -4
=======================================
- Hits        15193    15191    -2
+ Misses       5571     5569    -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Linux (Ubuntu) Error: Bus error at line: "import turicreate as tc"

(venv) user@linux:~/stml$ python styleTransfer.py
#import turicreate as tc
Bus error

Hi @THEDFG, could you please provide steps to reproduce this issue? As it is, most Linux users are able to successfully import turicreate - and I haven't seen this Bus error before.

Hi @znation,
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial
https://mega.nz/#!3MUGTAxL!FOHeBfSe7CmhnTl7CXM_uMmYemqruWJ6nE5Q70nsick

Hi @THEDFG, I've been generally able to run turicreate successfully on Ubuntu 16.04.3 LTS. I can't tell what the contents of that link are that you provided; I see a disk image, but it doesn't appear to be something usable on my machine. Please provide specific repro steps that I can perform to reproduce the issue locally, including installation (if necessary) of common off-the-shelf operating systems as needed. Again, in general though, I am not able to reproduce this issue in Ubuntu 16.04 LTS.

This may apparently repro on the Ubuntu-derived SimpleMiningOS, but not stock Ubuntu. Need to investigate.

Thank you very much Zack. Meanwhile I will try to install an official Ubuntu version on a rig.
Best regards,
Gabriel Dana
Sent from my iPhone

On 18 Jul 2018, at 21:29, Zach Nation<EMAIL_ADDRESS>wrote:
This may apparently repro on the Ubuntu-derived SimpleMiningOS, but not stock Ubuntu. Need to investigate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing this issue.
@THEDFG - please reopen if this is still an issue.


UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd1 in position 8: invalid continuation byte

Are supposed to use the .p8 AuthKey_ or different format?
Found README sparse on key file path info
Trying to run:
python3 simple_test.py
This is error:
"UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd1 in position 8: invalid continuation byte"
Can someone please help?

Yes, it's a .p8 key. You should checkout Apple's documentation about how to generate the key:
https://developer.apple.com/documentation/weatherkitrestapi/request_authentication_for_weatherkit_rest_api
Unfortunately, Apple makes it rather an involved process. Check that the command-line parameters that you passed to simple_test.py were correct. Can you provide more context about the error—what line is generating it. Please provide the full stack trace. Thanks.

Hey, thanks for taking a look at this and for developing the project.
I just checked the command-line parameters and I think they are correct. I also took a look at the Apple doc you provided, I was actually hoping your code was going to do the heavy lifting for this p8 :)
Here is the full stack trace:
Traceback (most recent call last):
File "PyWeatherKit/simple_test.py", line 36, in
client = WKClient(args.team_id, args.service_id, args.key_id, args.key_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "PyWeatherKit/weatherkit/client.py", line 36, in init
self.token = generate_token(
^^^^^^^^^^^^^^^
File "PyWeatherKit/weatherkit/token.py", line 37, in generate_token
key = key_file.read()
^^^^^^^^^^^^^^^
File "", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd1 in position 8: invalid continuation byte

I believe the error is saying that your keyfile is malformed. Sorry, I don't think this is something I can help you with but if you find out it's some kind of bug in the reading of the key file let me know.

Using 'pip3 install PyJWT' instead of 'pip3 install jwt' fixed it for me. I uninstalled jwt and installed PyJWT. Thanks for making the module!


Bump Cargo to 0.23.0

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 1e54d9e has been approved by matklad

:hourglass: Testing commit 1e54d9efa3ed35ad58192d10cd2d4bc2a9c2d465 with merge 6c27637f7b8e24d87f214af30ce979ce79b28c75...

:broken_heart: Test failed - status-travis

Might want to use [..] for that assetion.

@bors: r=matklad
I think that's using different infrastructure :(. In any case had to update other tests for nightly anyway.

:pushpin: Commit 2b7f80a has been approved by matklad

@bors: p=1

:hourglass: Testing commit 2b7f80a8a0f0e4787674631c28ab95b188367aa9 with merge 4b1b4a6ed47d5d2d7ef2d3d09b1186a8ca225f5e...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 4b1b4a6ed47d5d2d7ef2d3d09b1186a8ca225f5e to master...


Spanish translation

Can we help with the UI translation to Spanish?

Is it possible to collaborate on this task?
I had thought about the same thing, would it be possible to try to incorporate i18n for several languages?
I could help with Spanish and Portuguese.


Refactoring lcl_popups

Decided not to mix with #319  :)
So I checked a bit the usage of lcl_popups methods. They are mostly used in one place now. I'm not sure it is needed to separate into a separate class - it just to move a couple of lines from popups to routes or main_page.
BTW 'install' event code is duplicated in router and main_page. Is it OK if I move main_page handling to router ?
  repo_popup
  	OK
  create_branch_popup
  	OK
  repo_package_zip
  	external calls: lcl_zip=>export( lo_repo ).
  	used in: router->packagezip
  repo_new_offline
  	ext: repo_srv calls
  	used in: PAGE_MAIN-on_event
  switch_branch
  	ext: repo->set_*** calls
  	used: PAGE_MAIN-on_event
  delete_branch
  	ext: git->delete_branch
  	used: PAGE_MAIN-on_event
  branch_list_popup
  	ext: branches calls - but maybe it is OK
  	used: FORMS include, internally in class
  repo_clone
  	ext: repo calls
  	used: PAGE_MAIN-on_event and duplicated in router

both router and main_page classes are quite large, so if possible try to minimize the code in these classes
'install': I think the one in router is used from the explore page, so just make sure it also works

not that easy as I expected initially ... :( will need to think.

both router and main_page classes are quite large, so if possible try to minimize the code in these classes

My thoughts:

I think, concentrating all handling in one place and close to each other is very convenient (at least looking fopr event became quicker imho), I'd say handling in pages can be removed at all.
However, router is indeed huge. Do you think splitting it into 2-3 classes would help ? E.g page routing, db-tools, repo commands, in-repo commands ... or someting like that. Maybe it also worth to refactor event names to add some prefix and route to those classes based on prefix (not sure)

all in one place: would require also the state to be all in one place, which can be seen as a set of global variables. I think the state belongs in the page classes, eg.:
https://github.com/larshp/abapGit/blob/master/src/zabapgit_page_db.prog.abap#L14
router: yes, I think it will help splitting it. It will also help if we need to move logic between the router and pages.

Some thoughts. Sorry for much text :)))

There are global commands - services - and local page only commands - like one on branch overview page and stage.
Global command looks really better in router (well, in one place) so that there is a clear catalog of actions.
Local commands do not do any logic, just change the page a bit.
Some pages have state. Actually the goodness of it is arguable. I guess lcl_app can handle some controller-like objects or 'current_repo' - there are not so many states (repo, stage and merge). But that would mean rewriting all pages logic because now the gui creates and exchanges pages (views, not models). So I guess it should stay as it is now.
Then the question is how to handle events, which are 'global' but require internal state ? If I understand this is one of the main contradictions.

Let's consider PAGE_BRANCH_OVERVIEW. All events are local expect merge which creates new page - this is global navigation action. But the new page requires internal state. How to pass it to router ?
Option 1: in this particular case I would actually suggest: add repo_key to postdata, then mo_repo can be obtained in router too
Option 2: give router access to curent page object, and add tech methods to extract needed attributes (get_repo) - simple but I don't like it because too much cross references and unnecessary methods in pages.
Option 3: a bit crazy but works (tested). Create secondary event handler. E.g. any page can raise some event (declared in the interface) and pass some payload on it. Then router catches it and calls the same handling CASE-WHEN. Kind of flux ;) Should work nicely and clearly. There is just one doubt. That event will be handled BEFORE the previous ends - it is syncronous. So raise event should be kind of the last action to do and return event_type should be no_action ... to many conditions - this is a potential pitfall. Do you know if there is a way in abap to fire event asyncronously ?
Option 3.1: Same, but queue the action to router instead of raise (or raise calls queue as an option). Router then must process the queue after finishing with current event. This will make it async. (best option imho)
  events action exporting
      value(iv_action) type string
      value(payload1) type any
      value(payload2) type any
      value(payload3) type any.

Below is the list of actions and some questions to them. In brackets - proposed renaming. 'local' means staying in page. ->lcl_... means separating handling to separate service class so that the method can be re-used somewhere else. Handling CASE-WHEN then would typically look as 2 lines: call a method, assign event_type. All more than 2 lines should be wrapped in methods. Naming: all global actions should have specific prefic, all local - no prefix. Consequently router iteself will have just page navigation logic and a huge (but ordered and convenient ;) action list.
at router
Page navigation
main (go_main)
explore (go_explore)
db (go_db)
background_run (go_background_run)
background (go_background)
abapgithome (go_abapgithome)
diff (go_diff)
stage (go_stage)
branch_overview (go_branch_overview)
jump
Abapgit
abapgit_installation -> lcl_services_abapgit (will also absorb needs_installation from main_page)
DB
db_display - no change, page navigation (maybe rename to go_db_display)
db_edit - same
db_delete -> lcl_services_db
db_save -> lcl_services_db
REPO
uninstall (repo_uninstall) -> lcl_services_repo
remove (repo_remove) -> lcl_services_repo
refresh (repo_refresh) -> lcl_services_repo
install (repo_clone) -> lcl_services_repo
ZIP
zipimport (zip_import)  -> lcl_services_zip
zipexport (zip_export) -> lcl_services_zip
packagezip (zip_package) -> lcl_services_zip
transportzip (zip_transport) -> lcl_services_zip
files_commit - is this command needed ? Seems like it is some old code ... Maybe remove ?
GIT
pull (git_pull) -> lcl_services_git
reset (git_reset) -> lcl_services_git
create_branch (git_branch_create) -> lcl_services_git
at page_background
save (bg_update) -> lcl_services_background, move handling to router
at page_branch_overview
uncompress - local
compress - local
refresh - local
merge - local, fire secondary event (git_branch_merge) to router or add key to postdata, and there to lcl_services_git
at page_commit
commit_post (post) - local , fire secondary event (git_commit) to router and there to lcl_services_git
commit_cancel (cancel)
at page_main
newoffline (repo_newoffline) - move to router, -> lcl_services_repo
delete_branch (git_branch_delete) - move to router, -> lcl_services_git
switch_branch (git_branch_switch) - move to router, -> lcl_services_git
install (repo_clone) - move to router - it is the same as in router in fact, just add show logic there
show (repo_show) - move to router, -> lcl_services_repo
at page_stage
stage_* remain local except that commit and all should fire secondary event (go_commit)

hmm
4: I'm afraid that lcl_app will become a object containing global variables, and it then has to be read in the context of the page to figure out which variables are populated. Currently it serves singleton objects. It is very easy to pass state to a page via CREATE OBJECT, and the information is close to where it is needed.
However it does raise issues with regards to making the router reusable.
Looking at "page_main" actions: newoffline + delete_branch + switch_branch + install + show, I think these are only used in the main page. Moving to logic to lcl_services_repo + lcl_services_git would be a good idea, as it then is possible to reuse it from there if needed.
I think it all comes down to adding more structure and layers in the overall design, it would be nice with a package structure or package interfaces but this is not something we can easily add. It would also be nice to have dynamically generated diagrams of the class dependencies, something I would like to include in abaplint at some point.

ok, then if you don't mind I'll try with:

separate some function to lcl_services_repo, git, abapgit and zip
I'll implement that secondary event layer to show what I mean
would mind if I rename actions as described ?
files_commit question - is this feature still needed ? Seems not very natural anymore as abapGit supports pretty much already
page_main actions: I don't quite agree. branch actions would also look well on branch overview for example. Install is easily unified for Explore and Main - no need to have double code. Show - yes this is main only. newoffline ... not used anywhere else indeed, although it is a global action - it changes repo list. But you decide.

well my point was that I agree with you on keeping state in pages :) btw what do you mean "making router reusable" ? For me it looks like a central controller logic.

It would also be nice to have dynamically generated diagrams of the class dependencies, something I would like to include in abaplint at some point.

That would be an awesomest feature! I miss it so much too (in abapGit in particular). =)) There are some UML generation features in sap but it looks poor and also they are not about depencies.

separate functions: ok
rename as described: ok. In a few places there are constants for the actions, eg.:
https://github.com/larshp/abapGit/blob/094266e4f79402e29598747c8d4c59bccbf7986f/src/zabapgit_page_main.prog.abap#L16
this helps to jump from where the event is defined to where it is handled, via where-used list
files_commit: just remove it, then we'll figure out if someone is using it, I dont use it
page_main: lets try to separate the functions into lcl_service_* first, then I guess it will be easier to make a few examples and see what looks/works the best
4: I am currently thinking more of having the controller logic in the pages, and they then call the logic in the lcl_services_* classes, as the pages have the state. Transferring state to a central controller will require something that looks like global variables, or a factory/singleton class, as we can only transfer strings(POSTDATA/GETDATA) to the router. While it is easy to call from the page.

First commit. Gives some overview how it will look.
actions are defined as constants. I've put them to global defs.
files_commit: +1 :)

for choose_rerender_or_noaction: is it possible to always rerender? If the user press cancel it will then rerender, but I think it will not happen very often, and the time to rerender is usally low. So better with less code?

alternatively perhaps rename rv_success to rv_cancel, and set it when the user cancels the popups. I usually think of methods executing successfully if no exceptions are thrown

Does this look better ?
Cancel: well, yes, it is rare action. But still nothing changed ! So why re_render (and mainly resync). Well, that annoyed me while testing - that's why I did it in fact :)
Indeed the macro does not look ideally clean. But the handling does look better - avoiding clutter with IF cancel ... Maybe as a better option we can create some more types of exceptions ? In particular something like lcx_cancel - there are a lot of places to use it. And then it can be handled as a cancel action and potentially cleaner then now.

Good idea with a lcx_cancel

Some more code. lcx_cancel in particular. Some doubts if it should be moved directly to popups.
zip_services actions seems to be handled with one call each. Except package export - I moved it to lcl_zip. So lcl_services_zip seems to be covered with lcl_zip and lcl_transport well.

Some more new code
and a new feature

Switch action now shows directly branch selection dialog, displays current branch by default and allows creating new branch directly from there.

Maybe PR ? Much code already ... and I'd like to finish 319 =)

yeah, small PRs are good :smile:

PRing then :) Not so small one, sorry :(
Remaining:

background services,
adjust navigation action names
try implementing secondary event

I think I can close this one.
For the only this I want to try yet I opened 348.


Need to define timing model data schema

Currently the FPGA interchange device database lacks timing model data.  This new schema should cover defining timing models for both the routing graph (e.g. pip and wire delays) and BELs (setup/hold w.r.t. clock, launch from clock, combinatorial delays).  This schema should accomidate multiple timing corners and multiple speed grades.

There is a draft PR open with a proposal and discussion around it: https://github.com/SymbiFlow/fpga-interchange-schema/pull/38


Performance: CPU Core running at 100% - not downshifting into 'Idle' state

With the upgrade to Revery - we are no longer 'idling' when there are no animations / no keypresses.
We should see this logging after inactivity for a few seconds:

Possibly related to #647 , but I don't see any animations that would impact this.
Often, when we aren't idling, it's because there is a state change that triggers a re-render - but I don't see state changes coming through causing new renders. Need to check if the window is being set to dirty from somewhere else, or if we're getting an onStale event from brisk-reconciler.
Related:

#304

I narrowed this down to a single line in <TreeView />:
    <ScrollView style=containerStyles> <Tree tree nodeRenderer /> </ScrollView>

If we remove the <ScrollView /> - we no longer get this issue! So there must be something weird happening with the <ScrollView /> deciding it needs to render over and over.


[Feature] Backend for Signup Page

I will create database models and will write backend logic for sign up . So user an Sign up .

Hello parthpathakpp1, thanks for opening a issue, your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

Can you assign me this issue under GSSOC'23.

Can you assign me this issue under GSSOC'23.

@parthpathakpp1 Can you implement this using OAuth ?

Same as #42


fix: Show commit details in the inspector

This change also adds support for opening the commit in the system browser from both the context menu and the inspector.

Partial work for #212.


Adding date and timer in To-Do-List

I want to add the timer and date that we can fix for each task. if time is overs and the task is not completed marked by red else complete is marked add green and also we remove the completed task.

Hey, I want to solve this issue, can you assign me this issue?

Hey, I want to add this feature, Can you assign me?

Hey, I want to add this feature, Can you assign me?

go ahead :)

Hey @avinash201199, I am very sorry because now I can't able to complete it. So can you give it to anyone else?

Hey @avinash201199 , I want to work on this issue. Can you assign it to me?

Hey @avinash201199 , I can do it well. Could you assign it to me?


Problem with script to run veeam-hardened.sh

Describe the bug
Error:
bweadmin@bweintdevapp:~$ pwd
/home/bweadmin
bweadmin@bweintdevapp:~$ sudo bash veeam.harden.sh > output.txt 2>&1
bweadmin@bweintdevapp:~$ more output.txt
veeam.harden.sh: line 9: $'\r': command not found
veeam.harden.sh: line 11: syntax error near unexpected token $'{\r'' veeam.harden.sh: line 11: function print_job {
To Reproduce
Steps to reproduce the behavior:

Go to bash line ,see erorr above
Running : Ubuntu 20.4

due to the \r being mentioned, did you by any chance copy/paste the script and edited it on Windows before copying the script to the Linux system? As it already states an error for line 9, which is actually an empty line in the original script, so it should not throw any error.
You can retry again making sure to download the script properly, or parse the script first through dos2unix or use something like the tr command to delete the "\r" from the script?
But that would be meddling with the script, rather wanna make sure you use the actual script, just in case some steps otherwise might not be performed or incorrectly...

Thanks yes i did copy & paste, i tried like you said and it worked
thanks so much
On Tue, 6 Jun 2023 at 10:13, bartoque @.***> wrote:

due to the \r being mentioned, did you by any chance copy/paste the script
and edited it on Windows before copying the script to the Linux system? As
it already states an error for line 9, which is actually an empty line in
the original script, so it should not throw any error.
You can retry again making sure to download the script properly, or parse
the script first through dos2unix or use something like the tr command to
delete the "\r" from the script?
But that would be meddling with the script, rather wanna make sure you use
the actual script, just in case some steps otherwise might not be performed
or incorrectly...
—
Reply to this email directly, view it on GitHub
https://github.com/VeeamHub/veeam-hardened-repository/issues/1#issuecomment-1578151080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6XR2HS6I62M5VJONCCOZKTXJ3RDHANCNFSM6AAAAAAYX6UU3E
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Kind Regards,
Hamim Ismail
076 6874229

Thanks yes i did copy & paste, i tried like you said and it worked
thanks so much

I did the same thing, copied and pasted, same error. Thanks for posting this.


Can no longer highlight text to copy/paste

I've just updated to mitmproxy 0.12.1 on Linux using KDE desktop environment (kubuntu 14.04).  On previous versions of mitmproxy, I was able to use my mouse to select text and then copy/paste it into other programs.  Now that mitmproxy responds to mouse clicks, I am not able to select text.
Most programs wait for a mouse press+release in the same spot before considering it a click.  Mitmproxy just sees the press and doesnt wait for the release, so I cannot click my mouse and drag it to select text.
I see that there is a message "hold down alt or ctrl to select text" but this does not work in my terminal.  Holding alt while clicking and dragging makes the whole terminal window drag around the desktop.  Holding ctrl has no affect, and holding both of them does not help.
Is there an option to disable the mouse in mitmproxy and have it work like it did in previous versions?

Thanks for the report. Which terminal app are you using? The default one on kubuntu?

Yes, the default terminal in kubuntu.  Its named 'konsole' in the menu and lives at /usr/bin/konsole.

Hi there. Just a quick question - can you select text if you hold down "shift"?
I'm sympathetic to the idea that this breaks user expectations and that we should have an option to turn mouse control off.

Yes, holding shift, I can select text again :)

@giantpune Great. :) So, if we amend the hint message to include shift (sadly it seems to be different on every platform), would that satisfy you, or do you still feel a "mouse-less" command line option is needed?

I'm happy just being able to hold shift and select text.  I bet somewhere out there, there's another desktop environment where none of shift/alt/ctrl allows them to select text.  It doesn't seem like a bad idea to let these users type a certain letter to disable the mouse, or pass in a --no-mouse sort of parameter.  Otherwise you might find yourself with a message like "try pressing alt, shift, ctrl, windows key, alt+gr, numlock, or printscr button to select text."

Wasn't working for me with putty on windows either. Shift did the trick though!

+1 for holding shift (archlinux + urxvt)

same problem here, even when I set EDITOR=vim and open body in vim, still can't select text
I am using Term2 on mac

On the Mac, in Terminal.app, the best option seems to hold fn-command.

+1 for holding fn on mac

@mhils The "--no-mouse" options is already implemented, unless you want to improve the message provided depending on the OS that is running MITMProxy, I think we can close it. What do you think?

Came here searching for an answer why I couldn't highlite text. Found out that on my MacBook the "fn" key is the only thing that works. Using Terminal.app. Frustrating when the help text was wrong :(

As a temporary workaround, I'd immediately merge a PR that fixes the help text :smiley:

I'm on El Capitan, and even if I hold down shift | alt | ctrl and move the mouse the select I cannot select anything since I don't see the selection area.

Hey hey all - if you are on OSX use Fn instead of shift, alt or ctrl

I think this is about which terminal application you're using and then which keys you've set to send escape codes etc.
I'm currently on El Capitan, running iTerm2 but have set the Alt key to send escape codes - so I'm able to select text using Alt and Fn does NOT work for me.
On the default Terminal.app however, I'm able to select text using Fn and Alt doesn't work.

Frankly I find this more annoying than useful. Is there a flag to disable the "GUI" part of this? Terminal apps != GUI in my opinion and should not care where I click.

On Aug 11, 2016, at 6:54 AM, Shadab Zafar<EMAIL_ADDRESS>wrote:
I think this is about which terminal application you're using and then which keys you've set to send escape codes etc.
I'm currently on El Capitan, running iTerm2 but have set the Alt key to send escape codes - so I'm able to select text using Alt and Fn does NOT work for me.
On the default Terminal.app however, I'm able to select text using Fn and Alt doesn't work.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@jschwalbe There sure is. Just run: mitmproxy --no-mouse 😄

I'll add that as an alias to my bash_profile! Thanks

On Aug 11, 2016, at 7:02 AM, Shadab Zafar<EMAIL_ADDRESS>wrote:
@jschwalbe There sure is. Just run: mitmproxy --no-mouse 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jschwalbe Or you could add it to mitmproxy's config file :wink:

mitmproxy 0.17.1 macOS Sierra Terminal none of Fn, Alt, Shit, Ctrl work. Is there a trick to getting text selection work to work?


Ionic 2.3.0 with Native 3+, getting "plugin-not-installed" error

Hi,
I just tried this plugin with Ionic 2.3 and Ionic Native 3, when I use the available function to check whether it is supported, I got "plugin-not-installed" error.
I followed the plugin installation instruction from Ionic docs here and configured it following instruction here
I am using Ionic View app to test my app.
My system info:
Cordova CLI: 6.5.0
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 4.9
Node Version: v6.10.0
Xcode version: Not installed

Thank you for your help!

Hi,
I was able to find out the reason why it shows up the error, I do need to use a physical device to test it. Consider it as closed. Thanks.
GJ


Command mode keymaps are not preserved

Describe the bug
I have a command-mode keymap so that when I press the up arrow, instead of normal cycling through history, it copies the current command into a Telescope command_history finder.
To Reproduce
vim.keymap.set('c', '<Up>', function()
  local search = vim.fn.getcmdline()
  vim.fn.setcmdline('') -- otherwise the command gets executed when opening the finder
  require('telescope.builtin').command_history({ default_text = search })
end)

Then, with noice.nvim replacing your cmdline with the popup window, type :<Up>. It will cycle through history normally instead of opening the Telescope finder.
Expected behavior
It respects command-mode keymaps, or alternatively, the plugin exposes a way to create custom keymaps for the cmdline popup.
Screenshots
N/A
Noice log
N/A

I'll work on something that can be used as a work-around

I just tested this and cmdline mappings work perfectly fine for me.
vim.keymap.set("c", "<Up>", function()
  vim.notify("Test from cmdline")
end)

Your mapping also correctly opens Telescope for me.

Make sure to update noice. Maybe there was another issue causing things to fail.

Ah yeah. It was a bug in my config. Sorry.


Stopped working month ago

Using version 1.1.1. Location and chargelevel control (only ones i use/tested) stopped working.
Log shows this line every 5 minutes:

error with loading initial location: tracking terminated, will retry in 5 minutes.
"not_found"

Hey @goyaweb! Just noticed this issue. Can I contact you for debugging support on this issue?

solved.


add search parameters to API response

Why
Reason 1 - default settings not requested by client
There is some information that might not be set by the client that is relevant to the request.
A simple example of this would be page parameters, where we are actually searching page 1 with pageSize of 25, but the client isn't aware of that state - so we send it down the pipes (we don't actually send current page in the current implementation).
This saves a tiny amount of code on the client i.e. page = query.page ? query.page : 1.
Another default, which we can't infer, and what this was setting up for was to get the queryType name. i.e. ScoringTiers, MSMBoostUsingAndOperator. We currently have a default and n amount of tests. The client needs to report on what query is being used, but can't as if it hasn't set the _queryType explicitly, it has no way of knowing which is being used. Going forward we might want to take this even more out of the client's code, which would be impossible in this state.
example
// GET /works
{ "queryType": "ScoringTiers" }

// on client
track({ queryType: response.queryType })

Reason  2 - Rendering the UI to reflect current filters that are complex objects, but requested via querystring.
We currently render part of the interface that reflects what filters have been applied:

Currently we:

Render aggregation
Take query.workType and do a lookup on the ID to render the filter

aggregations = [{ id: 'a', label: 'Books' }]

// Current implementation when this is clicked
// Change URL: workType=a
filters = { workType: ['a'] }
// Render
filters.workType.map(id => <div>{lookup(id).label}</div>)

We could store the aggregation in a client side state, but when working with rendering from the URL (which we have to 💯 support) we would still need to maintain the lookup.
The only solution I can think of is to do something like this in the URL workType=(label:Books,id:a) <= but, well, no.
So if we returned from the API:
{ "filters": { "workType": [{ "id": "a", "label": Books }] } }

We'd get to remove the hardcoded lookup.

Adds the parameters to the response - similar to the HATEOAS paradigm.
This was some preliminary work I wanted to do as a POC and to move onto adding returning of the workType filters to help the UI respond to the request and the queryType for reporting.
I am still not 100% sure about the shape of this.
calculated fields, properties, filters
I was thinking you could split the data up into these pieces:
{
  "@context": "https://api.wellcomecollection.org/catalogue/v2/context.json",
  "type": "ResultList",
  "pageSize": 10,
  "totalPages": 132784,
  "totalResults": 1327838,
  "results": [
  ],
  "parameters": {
    "sort": [
      "production.dates"
    ],
    "sortOrder": "asc",
    "page": 2,
    "searchQuery": {
      "query": "dogs bogs and hogs",
      "queryType": "ScoringTiers"
    }
  },
  "filters": {
    "workType": [
      {
        "type": "WorkType",
        "label": "Books",
        "id": "a"
      },
      {
        "type": "WorkType",
        "label": "Video",
        "id": "v"
      }
    ]
  }
}

Problem is we use pageSize already at the root level, which is actually a property.
Because of this, we could flatten the properties, and leave the "filters" property there too?

It's not clear what benefit this provides from the PR description. I'm guessing this is to make the API more self-describing and therefore easier for clients to implement against?

Yep, also see my comment on the PR in general :point_up: in case you have missed it.

@kenoir @warrd
Sorry for the murky waters, updated the description

:+1: thanks for the context

Have you checked how the generated swagger looks like? I don't think it will document SortingOrder and SortRequest properly (personally I think an extra reason for using DisplayModels)

@alicefuzier @warrd @jtweed
Bar the serialisers part of this - what do people think about the structure in the description?
Using the case of queryType - how might we add that to the return value of the response?
Maybe I have overcomplicated this and should just add that to the root?

Personally I think I prefer the parameters element instead of everything flattened in the root. It makes it easier to separate things that relate to the context of the request from things that are part of the response proper. I'm not sure if I would call it parameters though

Yes  agree with @alicefuzier better to nest under parameters (or some other appropriate name)

I think it's better to group everything together and have no problem with the parameters name. I don't think there's much point in separating out kinds of parameter.
I also think it's ok to duplicate pageSize under parameters, but that parameters should probably be an include.

Thanks all for the comments, I'll continue with this and make the relevant changes.
@alicefuzier parameters was taken from swagger - but that's on the request, I'll have a think of a name saying that this was what we used to create these results.

Does this need to stay open?

Closing as there's too much in here that is going to be dealt with in other PRs.
Thanks for all the super valuable feedback!


Fill in Selected Lollipop LineMark in SingleLineLollipop

Greetings, reviewer!
This PR fills in and slightly expands the currently selected lollipop LineMark. This adds a visual aid for users to more clearly and distinctly see which LineMark they are currently viewing.
Changes

Data.swift: Made the Sale struct conform to the Equitable protocol. Any data passed to this type of chart should conform to the Equitable protocol in order to easily compare the current selected lollipop LineMark and each LineMark rendered on the Chart.
SingleLineLollipop.swift: Added the lollipop color picker. If the lollipop is currently over the LineMark, it will fill in and slightly expand said LineMark. I wanted to call LineMark's .symbol property with a ternary operator - However, there is no mechanism for supplying a .symbol with a ChartSymbolShape that fills in the shape. This meant that I could not write a ternary operator that chose between the filled in circle (some View) and unfilled in circle (some ChartSymbolShape) as the types did not match. Hence why I pulled baselineMarker out into its own function first before conditionally deciding which .symbol function to call with a parameter type of either some View or some ChartSymbolShape.

Before

After

Thank you!

Psst, is this repo still being maintained? My dusty PR is indeed dusty 😎


'WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Hello.
what it means "Solves the problem of "It works on my machine, but not on XXX machine" ? I intended that your image works on every machine,from windows,to mac to arm32 or 64. It's not like this,the title is misleading. I tried to run your image on the jetson nano and I've got this error :
root@zi-desktop:~/Desktop/zi/Work/I9/Android# docker run -it --rm -v $(pwd)/sdk:/sdk thyrlian/android-sdk bash -c 'cp -a $ANDROID_SDK_ROOT/. /sdk
'WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
standard_init_linux.go:219: exec user process caused: no such file or directory

Thank you for your interest.
First of all, it's not a bug.  You probably misunderstood the concept of "It works on my machine", it's not about cross-platform, but it aims for consistency.  An introduction about that can be found here.
Even for the cross-platform software, they often cover only the most popular platforms.  We should not split hairs, otherwise, the argument will never end: adding support for various OS: Solaris, FreeBSD?  Or adding support for other architectures: MIPS, RISC-V?  That's not the goal.
The purpose of this Docker image is to help engineering teams increase productivity.  Running on an ARM-based Jetson Nano won't achieve such an objective.  However, I don't wanna show any bias here, I would say deploying to Jetson Nano totally makes sense for personal projects or just for fun.  Furthermore, it should be feasible as well, as the base image Ubuntu supports multi-arch, including ARMv7.  Why don't you create a PR for that (you can refer to this article: Multi-arch build and images, the simple way.  Please make sure that the image is properly tested)?  Any contribution is welcome.

While I was able to build an arm64 docker image making a few modifications, I don't know how meaningful that is, since sdkmanager's "emulator" package doesn't seem to be available for arm64.    Does anyone know if that is available anywhere?
For those who are curious, you can see the modifications I made in this branch
https://github.com/yaizudamashii/AndroidSDK/tree/arm64-builds

Thank you @yaizudamashii for providing your branch, I was able to build the docker image from your branch just fine. After building the docker image, I installed a couple of things using the sdk manager following the readme:
sdk/cmdline-tools/tools/bin/sdkmanager "platform-tools" "platforms;android-31" "emulator" "system-images;android-31;default;arm64-v8a"

I then made a new avd by running
docker run -it -v $(pwd)/sdk:/opt/android-sdk:ro android-sdk /bin/bash

avdmanager create avd -n test -k "system-images;android-31;default;arm64-v8a"

Finally, I tried to start the emulator from the docker container
emulator -avd test -no-audio -no-boot-anim -no-window -accel on -gpu off &

which fails with the error bash: /opt/android-sdk/emulator/emulator: cannot execute binary file: Exec format error
I tried running executing /opt/android-sdk/emulator/emulator and got the same result.
What is interesting to me is that if I open a new terminal on my host machine, and navigate to the directory where the sdk is (not the sdk installed on my system, the one mounted for the android-sdk container) and then execute ./sdk/emulator/emulator the binary runs just fine
Is this a docker issue?? The binary will run just fine on my host machine (m1 macbook air) but won't run when mounted inside a docker container?? The only thing I could think of is that this is an issue with the base ubuntu:20.04 image but it is supposed to support multi-arch

Hi @leonitousconforti I believe there is no emulator for arm64 Linux provided by Google.  Google does provide arm64 mac emulator so that's why the sdk works on your host computer.  So sadly arm64 image of this repo isn't useful until Google provides linux arm64 emulator.  Once we get it, we can merge the branch into this repo.

@yaizudamashii see https://github.com/yaizudamashii/AndroidSDK/pull/1

+1 for @yaizudamashii, not only the emulator binary but also other binaries under the bin directory, they are not compiled for arm64 Linux.  Previously, in the older release of Android SDK, if I'm not mistaken, some binaries even had different variations - for different architectures.
But it's great that @leonitousconforti you made it work by compiling it yourself from the Android source repository and adding the missing dependencies.  Really appreciate your awesome work, looking forward to the further news.
Just out of curiosity, why are you guys so keen to run the Android SDK on ARM machines (except for the powerful Apple ARM machines)? :)

@leonitousconforti Thank you for all your work, will test it this weekend to see if I will get the the place you got to.
@thyrlian For me because bare metal on AWS is super super expensive while ARM Ubuntu is cheap...

A minor followup, I am now running the images on GCP instances, from which you can (relatively) cheaply use nested virtualization.  This documented provided by google helped a lot,
https://source.android.com/devices/automotive/start/avd/cloud_emulator
the only differences being 1. use ubuntu-22 based images instead of ubunt-18 based images as instructed (section Create a Linux VM in GCE: 2), and using this repo's image (in my opinion far superior than the one Google provides) instead of Google's container (section Start the hosted containers: 1)
The cost comes out to ~$140 a month, much cheaper than AWS bare metal.


build: upgrade to npm@latest or yarn@latest

I would prefer npm to yarn.
Because:

Comes with node install. Not a separate lib
Applicable feature set is mutually similar with yarn (npm@latest includes workspaces)

Either way, running into this problem on<EMAIL_ADDRESS>https://github.com/yarnpkg/yarn/issues/7807
yarn install

=> error An unexpected error occurred: "expected workspace package to exist for \"babel-loader\"".
info If you think this is a bug, please open a bug report with the information provided in "/Users/jaketrent/dev/design-system/packages/icon/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
error Command failed.
Exit code: 1

Also getting this for yarn add commands in packages.
Solved it with reverting to<EMAIL_ADDRESS>https://github.com/yarnpkg/yarn/issues/7807#issuecomment-588632848
yarn policies set-version 1.18.0

Feeling like<EMAIL_ADDRESS>is dead: https://github.com/yarnpkg/yarn/issues/7734#issuecomment-819110350

Team triage: use npm@latest.
In the meantime, another potential workaround: https://github.com/lerna/lerna/tree/main/commands/add#readme

Need to document this in #1968 in transition internal best pracices

NPM latest causes break in the build and testing environment. Yarn cannot be upgraded to latest because Lerna and Gatsby  do not support Yarn 2+. 😞


[SPARK-26236][SS] Add kafka delegation token support documentation.

What changes were proposed in this pull request?
Kafka delegation token support implemented in PR#22598 but that didn't contain documentation because of rapid changes. Because it has been merged in this PR I've documented it.
How was this patch tested?
jekyll build + manual html check

Test build #99552 has started for PR 23195 at commit e53631b.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #99552 has finished for PR 23195 at commit e53631b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99552/
Test PASSed.

cc @vanzin

@HeartSaVioR thanks for the review!
cc @steveloughran maybe also interested

Test build #99609 has started for PR 23195 at commit 3665d12.

Test build #99659 has started for PR 23195 at commit b97492a.

Test build #99659 has finished for PR 23195 at commit b97492a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99659/
Test PASSed.

Test build #99723 has started for PR 23195 at commit 3ad9cb7.

Test build #99723 has finished for PR 23195 at commit 3ad9cb7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99723/
Test PASSed.

Test build #99771 has started for PR 23195 at commit 49c1353.

Test build #99771 has finished for PR 23195 at commit 49c1353.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99771/
Test PASSed.

Merging to master.


Add a tutorial example on how to use MBTiles

A useful feature of maplibre-gl-native is that you can now use MBTiles files. We should have a tutorial and documentation showing how to do this on all platforms, particularly iOS.
Note that we may need to add a few things to the Objective-C bindings to add an MBTiles source programatically. I think right now it will only work if the MBTiles source is defined in in the style.json, however, that won't work on an iOS app, because the absolute path the the MBTiles file (right now it has to be absolute) includes a UUID for the app's sandbox, which is not known until runtime.

I'm attempting to load an mbtiles by replacing the mbtiles path in a style.json with a simple string replace.
https://github.com/hallahan/maplibre-gl-native/commit/f157ca948e52cd65a021e9cb779612af3749b9ed
However, I'm getting an error
2023-01-28 15:23:25.265545-0800 MapLibre GL[1153:253051] [DEBUG] {com.mapbox.mbgl.MBTilesFileSour}[Database](26): file is not a database in "SELECT * from metadata"

But, I have checked the file with sqlite3, and the metdata table is indeed present, and it is a valid Sqlite3 database...

The following hack allows you to load an MBTiles file in iOS. Note that this is ugly, as we do a string replace in the JSON file.
https://github.com/maplibre/maplibre-gl-native/compare/main...hallahan:maplibre-gl-native:mbtiles?expand=1#diff-cee3c54549008c6cf175a4a38578f91ac799f4adb9a4d0c50181f748d75e2c6bR1910
What we really want is to have the proper accessors in the Objective-C API. Next step, I will look into doing that.

You might be able to already do this by adding a MGLVectorTileSource with an mbtiles:// path.
https://maplibre.org/maplibre-gl-native/ios/api/Classes/MGLVectorTileSource.html

@hallahan have a look at my sample code and screenshots here github.com/lukaszkn/MapLibre-samples
.mbtiles source is added programatically

@lukaszkn Nice examples! We should add them to https://maplibre.org/maplibre-native/ios/latest/documentation/maplibre/ 🙂


Add status page test for rule 920250

PR adds a status page test for rule 920250 (a new test which only triggers this specific rule).
Note:
Important: The 920250 tests are disabled by default (see enabled: false at the top of the test file). I don't know why they're disabled, but this is important to be aware of if attempting to use this new test.

I think they were disabled because of the inability to test then in older setups. I will try to fix this in next iterations.


Remove artifacts folder and redirect artifacts to the osdi20_artifact branch

Current artifacts folder has broken due to the refactor of NNFusion and BlockFusion (e.g., rammer_fast and rammer_base_k has been removed). So the artifacts folder needs to be redirected to the osdi20_artifact branch.
The artifacts folder will be modified to a series of tutorials.

/AzurePipelines run

Is the folder removed or kept for Readme document.

Is the folder removed or kept for Readme document.

This folder is kept for readme document which redirects artifacts to the osdi20_artifact branch.


wsl_docs: Inform user how to uninstall WSL.

From discussion in https://chat.zulip.org/#narrow/stream/49-development-help/topic/Windows.2010.

Merged, thanks @amanagr!


[ TypeScript ] Suspicious expression, checks the truthyness of a function that returns a bool

Describe the bug
Typescirpt complains here if you turn on some stricter nullchecks.
I believe this code is not doing what it should be doing.
https://github.com/Nicklason/tf2-automatic/blob/master/src/classes/UserCart.ts#L39
if ((this.bot.handler as MyHandler).hasDupeCheckEnabled) {
  // ...
}

To Reproduce
Steps to reproduce the behavior:

Turn on strictNullChecks in tsconfig.json
Visit UserCart.ts
Tead the following error message.

ts(2774)
This condition will always return true since the function is always defined.
Did you mean to call it instead?

Expected behavior
Call the function.
Version: 86f1e2f30422509c19fd4f3479e7db4ea092a8a9

Thanks 👍

https://github.com/Nicklason/tf2-automatic/commit/38f7d47a35bcceaf66aae41e51c88061df7a9d00


Android WebView Audio Stream Not Working

Question Checklist

[x] Updated Amplitude.js to the latest version
[x] I read the docs
[x] I searched for existing GitHub issues

Question Subject

Getting Live Stream audio to work on Android WebView
Question Description

Hi, seems like I;m doing something wrong.
I can't get my stream to work on android webview but it's working on all browsers. Could I be missing something?
When I change the url to a local mp3, it plays perfectly on android webview
``

Hi @teddiey So some of the issues I've had with webview and Amplitude is the security permissions to allow remote playing. If you could provide any debug logs, that would be super helpful. However, I'd look into the Content-Security-Policy on your webview: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/media-src.
Let me know if that works, otherwise, if you have a debug logs and send them over I can help!

Hey @danpastori tried twith CSP but nothing worked.
Below is printed-out debug from my console:
{version: "3.3.1", active_song: audio, active_metadata: {…}, active_album: "We Are to Answer", active_index: 0, …}active_album: "We Are to Answer"active_index: 0active_metadata: {name: "RADIO WAUMINI FM", artist: "88.3FM LIVE STREAM", album: "We Are to Answer", url: "http://<IP_ADDRESS>:12087/stream/1/", cover_art_url: "img/defaultArt.jpg", …}active_playlist: ""active_song: audioautoplay: falsebindings: {}buffered: 0callbacks: {}continue_next: truedebug: truedefault_album_art: ""delay: 0handle_song_elements: trueis_touch_moving: falseplayback_speed: 1playlists: {}pre_mute_volume: 0.5repeat: falserepeat_song: falserepeat_statuses: {}shuffle_active_index: 0shuffle_list: {}shuffle_on: falseshuffled_active_indexes: {}shuffled_playlists: {}shuffled_statuses: {}songs: [{…}]soundcloud_client: ""soundcloud_song_count: 0soundcloud_songs_ready: 0soundcloud_use_art: ""start_song: ""starting_playlist: ""starting_playlist_song: ""version: "3.3.1"volume: 50volume_decrement: 5volume_increment: 5__proto__: Object (index):1 Mixed Content: The page at 'https://mcathosmart.com/mcatho/radio/' was loaded over HTTPS, but requested an insecure audio file 'http://<IP_ADDRESS>:12087/stream/1/'. This content should also be served over HTTPS.

@teddiey Hmm this is bizarre. I did some searching though and found that it could be an issue with the stream it self. When I looked at the stream: http://<IP_ADDRESS>:12087/stream/1/ The format was in audio/mpeg which according to some older sites wasn't well supported. This might not be the case now but the way to test it would be to visit the URL of the stream http://<IP_ADDRESS>:12087/stream/1/ in your app and see if it plays.
The other issue could be stronger policy against non HTTP sources in your webview.

@teddiey I'm having a similar in 2019, can you please help?

@kabiesigroup Do you have the issue with mixed sources (http/https) as well?

@danpastori thanks for your reply, its even worse now in android webview app that I created in andoid studio as the stream page that plays fine in web isn't playing at all inside the webview, I had to go buy SSL certificate yesterday just to solve the https issue thinking I will be happy with my app today but guess what I'm very sad now as the app is not running across all androids, it's running on very small phones but failing on other ones such as Samsung a30 and co.... please help me. my WhatsApp no is +2348038194934, see my stream pages at 1) radio.kabiesi.com 2) 1box.network/apps/pkoradio

Hi @kabiesigroup,
Right now you are receiving "community support" (which is on a volunteer basis). Sounds like you may need more urgent help.
For that, we do offer professional support. If you would like to get this issue resolved quickly, I would advise you to continue the conversation through our "Professional Support" channel: https://521dimensions.com/open-source/amplitudejs/docs/get-help/#professional-support
You'll be able to meet and share your screen with @danpastori directly.

Closing this due to inactivity.


fix setup.py on Windows

This fixes the install problem I found in #292 when installing from source on Windows.
As a side note, it seems the setup.py is starting to get bloated. In particular, I noticed that get_version_tofu and updateversion do something very similar (like checking if git is working in the path to know if we are on master...). This would be a an area for refactoring.

Hello @flothesof! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 150:35: E231 missing whitespace after ','
Line 154:5: E722 do not use bare 'except'
Line 155:29: E231 missing whitespace after ','
Line 156:71: E231 missing whitespace after ','
Line 157:50: E231 missing whitespace after ','
Line 160:25: E231 missing whitespace after ','

Codecov Report

Merging #294 into devel will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel     #294      +/-   ##
==========================================
+ Coverage   41.05%   41.11%   +0.05%
==========================================
  Files          79       79
  Lines       23468    23432      -36
==========================================
- Hits         9634     9633       -1
+ Misses      13834    13799      -35

Impacted Files
Coverage Δ

tofu/imas2tofu/__init__.py
80.95% <0%> (+49.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6988b9f...8c5f1dd. Read the comment docs.

So I'm confused, is this solution working now ?

No, this is broken and will not be fixed with this PR. I think @Didou09 was talking about #295 which incorporated these changes. I rewrote my history on #295 to take them out.
Closing since this will fix the problem.


autocomplete for disconnect implemented

Fix: #37789

There's also is_connected.

@akien-mga  done 👍

Thanks!

@akien-mga  could you have a look at these auto completions
#36879
#36759
#37232
#36950

Cherry-picked for 3.2.2.


filebrowser: upload dir for uploading large archives

In Hue 3.9.0 we are facing the problem that on the upload of a large archives (eg. zip files) over the filebrowser (Upload -> Zip/Tgz/Bz2 file)  /tmp/ is filling up before the complete file is actyally uploaded (the unpacking did not start yet).
The prolbem apparently is:

The upload of a > 2.5Mb archive uses the Django TemporyFileUploadHander which is storing the temporary upload in /tmp as default
only then the exitings  parameter [filebrowser] archive_upload_tempdir is used to actually unpack this archive in to this location,

It would be essential to be able to also redirect the initial zip upload to a different folder location. I would suggest that the archive_upload_tempdir parameter sets both directories: For initial upload and for the unpacking of the archive.
Or do I miss a configuration option?
Thanks for any help.
Frederik

Yes, it would make more sense to unify archive_upload_tempdir to also set the path of TemporyFileUploadHander for this archive case.
Note that the archive upload is currently more designed for small files, like 100MB max. Hue's server still does all the work, and we would need at some point the equivalent of a task queuing system to offload this task of the HTTP server.

Sure, there are better ways of data ingestion. But since it is possible for the users to actually try to upload large archives, they potentially do it and fill up /tmp (unluckily, if the upload fails due to space problemm, the file /tmp/<random>.upload is not deleted.


Can Scumblr automatically run stored jobs?

Hi,
Is there a way for Scumblr to automatically run all stored jobs on a rotating schedule or cron job? I thought Workflowable would do this, but that component appears to be more conditional.
Thanks in advance,

Hi @espressobeanie,
Yes scumblr can do this. There is a rake task available that you can setup to run as a cron job. This task will run all the tasks that you have created that are enabled.
rake run_tasks_and_email_updates

Note you you'll need to have your path/working directory setup properly so it can find the task, run the cron job under the right user, etc.
Please reopen if this doesn't answer your questions or if you need any other info.


Use icons from theme in project explorer

This PR use the icons from the icon theme (When possible, see limitations) in the project explorer pane

Use the icons for .fs & .fsproj extensions if defined but still use the embeded icons if the theme doesn't define a more specific icon
Use the icons for folders
Handle light/dark icons
Reload the icons when the theme change

Limitations

When the icon theme change the tree is reloaded (like when the project change) losing what folders are opened or closed.
The specific icon for when a folder is expanded isn't used. (I don't know how to do that)
Icon themes that use icons in Fonts (like seti-icons) are NOT supported, and there don't seem to be any way to support them.

Sample with a few themes

This so terribly hacky that it's scary... I love it! 💯


Issue with webex sample

Manually transferred from Doc's repo:
https://github.com/MicrosoftDocs/bot-docs/issues/1921

It should be::
public WebexAdapterWithErrorHandler(IConfiguration configuration, ILogger logger)
: base(configuration, null, logger)
instead of
public WebexAdapterWithErrorHandler(IConfiguration configuration, ILogger logger)
: base(configuration, logger)

https://github.com/MicrosoftDocs/bot-docs/issues/1899

Here is what I get from the code as-is

public class WebexAdapterWithErrorHandler : WebexAdapter
{
    public WebexAdapterWithErrorHandler(IConfiguration configuration, ILogger<BotFrameworkHttpAdapter> logger)
    : base(configuration, logger)
    {
        OnTurnError = async (turnContext, exception) =>
        {
            // Log any leaked exception from the application.
            logger.LogError(exception, $"[OnTurnError] unhandled error : {exception.Message}");

            // Send a message to the user
            await turnContext.SendActivityAsync("The bot encountered an error or bug.");
            await turnContext.SendActivityAsync("To continue to run this bot, please fix the bot source code.");

            // Send a trace activity, which will be displayed in the Bot Framework Emulator
            await turnContext.TraceActivityAsync("OnTurnError Trace", exception.Message, "https://www.botframework.com/schemas/error", "TurnError");
        };
    }
}

Severity Code Description Project File Line Suppression State
Error CS1503 Argument 2: cannot convert from 'Microsoft.Extensions.Logging.ILogger<Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter>' to 'Microsoft.Bot.Builder.Adapters.Webex.WebexAdapterOptions' EchoBotTest C:\Users\ssy\Documents\Visual Studio 2019\Projects\TennantWebExTeamsBot\EchoBotTest\WebexAdapterClass.cs 23 Active

The sample in the samples repo is correct, and works as expected. The issue is with missing code in the docs. Will reach out to the docs team.


Quenching Model Default Value is Outside of Allowed Range

diffsmhm/galhalo_models/sigmoid_quenching.py, line 22. Default value for fq_sat_tinfall_k is $10^{0.5} \approx 3.16$, while allowed range is [0,2]

This default value is reasonable. I think the allowed range should be more like [0.2, 5.0].

Well, do be careful however about whether the parameter that is actually being varied is linear or logarithmic. The range where you expect $k$ to vary is $0.2\lesssim k\lesssim 5,$ but if we write $k=10^{\rm lgk},$ then $-0.7\lesssim{\rm lgk}\lesssim0.7.$

Yep. We need to deal with the bounding in the hmc stuff and will take a close look.


Added a Hindi translation of the README

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[ ] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Made a Hindi translation of the README.

This is great. Thanks!


Make the hub bind to address specified in hub_ip

Bug: the hub binds to all interfaces and ignores the address given in 'hub_ip'. The 'address' parameter was missing in the call http_server.listen().

Thanks!


Additional/out-of-scope contextual issues

@autonome The non-western (in this case meaning Europe and N America where all the research participants were) context not being covered should be included somewhere. We will have a out-of-scope bit under the browser survey for mobile, but was thinking this should be somewhere else.

I imagine this also applies to the questions of battery life, loss of connectivity, offline collaboration, etc.

To be decided by #63


Update NativeHashes.hpp

Should we add the new natives with 2.0.0 or now @crosire?

Well, dev is the branch that will be 2.0.0. But it's better to update them as the last step before releasing.

Those two natives were added in c28ad7bf9e373373f21d0312c1f5817f48d817da.


"pinned window"

is there "pinned window" method, that pinned a active app window

https://github.com/FuPeiJiang/VD.ahk/blob/a19a9bf711eac40e0404047792f61caf29798edf/VD examples.ahk#L72-L83
@MaxSherry try it ? : )


Fix formatting in bug report template

Unescaped backtics caused visual bugs
Instead of:
```</code> tags, on separate lines before and after the text. (Use <code>```
It was rendered as:
 tags, on separate lines before and after the text. (Use
Test opening a bug report to see the effects

Thanks!

Thank you!


Why it is not allowing more than 4096 tokens as max tokens for gpt-4o

Text generator settings :

These are my defined limits on the openai website.

that's the output tokens.
its limited to 4096.
also if you check the error. its coming from openai.
its not issue in the plugin

Thanks for the info, i got it now. I thought it included input as well.
This can be closed


Use an external signing service to sign blocks and attestations

Description
As a Teku administrator, I want to use an external signing service so that my validator keys can be kept secure.
Acceptance Criteria

CLI options for the signing service url, the public keys of the validator keys that will be used for signing with the external service
Sign blocks and attestations for the validator keys configured to use external signing

Additional Information
Eth2Signer is an example of an external signing service and has the following API:
POST
/signer/block
{"publicKey": , "message": , "domain": }
/signer/attestation
{"publicKey": , "message": , "domain": }
And an example of the request body:
{"publicKey":"0x989d34725a2bfc3f15105f3f5fc8741f436c25ee1ee4f948e425d6bcb8c56bce6e06c269635b7e985a7ffa639e2409bf","message":"0x48656c6c6f2c20776f726c6421","domain":"0x000000000000002a"}

the public keys of the validator keys that will be used for signing with the external service
To clarify, why would you need to specify the public keys. Wouldnt the assumption be that any keys you have are stored in the signer and therefore go there for ANY key?

Teku needs to know what validator keys is acting as validator for so that when it receives a block it can check to see if it is the proposer and create the block if necessary and use Eth2Signer. Similarly for attestations.
Also maybe we don't want all the validator keys to be in Eth2Signer?


[bug] testID does not apply in builds

Describe the bug
data-testid is not applied to Input element
To Reproduce

Create a new project:

npm create tamagui-app@latest

Replace apps/next/pages/index.tsx with the following:

// import { HomeScreen } from 'app/features/home/screen'
// export default HomeScreen

import { Input } from 'tamagui'

const Page = () => {
  return <Input value="hello world" testID="testing" className="testing-classname" />
}

export default Page

Build:

cd apps/next && yarn build

Serve the app:

cd apps/next && yarn start

Navigate to http://localhost:3000/ and inspect the input. Should look something like this:

System Info (please complete the following information):
Output of npx envinfo --system --npmPackages --binaries --browsers
Tamagui info
System:
  OS: macOS 13.0
  CPU: (10) arm64 Apple M1 Max
  Memory: 2.96 GB / 64.00 GB
  Shell: 5.8.1 - /bin/zsh
Binaries:
  Node: 16.17.0 - /usr/local/bin/node
  Yarn: 3.2.3 - /usr/local/bin/yarn
  npm: 8.15.0 - /usr/local/bin/npm
Browsers:
  Chrome: 107.0.5304.110
  Firefox Developer Edition: 104.0
  Safari: 16.1
  Safari Technology Preview: 15.4
npmPackages:
  react-native: 0.0.0 => 0.0.0

Misc
The className attribute is also missing in the attributes

Fixed in 96f881c

In beta 215, reopen if still an issue


Docker Windows inplementation

Docker is currently applicable with Linux and OSX.
Need to find a matching solution for Windows CLI paths

Anyone knows of a volunteer with a Windows desktop that will be available on Monday?
@aviklai @simonaho

@omerxx  I am not sure if I will go to the weekly meeting but I will be available.

@danielhers I'm not sure I understand what needs to be done. Can you please explain?

To use ANYWAY on Windows, a simple way is to use Docker and replicate the
Linux environment. The image shouldn't be any different, so I'm not sure
what this is about exactly - perhaps just Wiki instructions for using
Docker on Windows.
On Tue, Sep 5, 2017 at 10:15 PM Roey Darwish Dror<EMAIL_ADDRESS>wrote:

@danielhers https://github.com/danielhers I'm not sure I understand
what needs to be done. Can you please explain?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hasadna/anyway/issues/570#issuecomment-327274972, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAQEw0JPSj5YZc_R8jQJSyktqqAXWpaBks5sfZ27gaJpZM4H_SbC
.

As far as I remember, people were not successful in activating docker on Windows, no sure if it is due to bad documentation.


Extension methods are not found while using Interface with DbContext

While using an interface for entities with DbContext class can't use/found _context.Database
Steps to reproduce
Interface
public interface IMainDbContext
{
    DbSet<User> Users { get; set; }
    DbSet<Client> Clients { get; set; }
    Task<int> SaveChangesAsync(CancellationToken cancellationToken);
}

DbContext Class
public partial class MainDbContext : DbContext, IMainDbContext
{
   public MainDbContext(DbContextOptions<MainDbContext> options)
    : base(options)
   {
   }
   public DbSet<User> Users { get; set; }
   public DbSet<Client> Clients { get; set; }
}

Created a class(RDFacadeExtensions) mentioned here 1862

Now whenever I inject IMainDbContext and use _context.Database.ExecuteNonQueryAsync is not found gives compile time error.
Further technical details
EF Core version: 3.0
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET Core 3.0
Operating system: Windows 10
IDE:  Visual Studio 2019 16.3.1

@sudurrani In the code above, the interface IMainDbContext doesn't have any Database property, so I wouldn't expect this to compile.  If I'm missing something, then please post a small project/solution that demonstrates the issue so that we can be sure that we're discussing the same code.

It's very simple, there is an interface with entities and this interface is implemented by a class also inherited from DbContext.
Now when ever I try to inject interface and want to write query like.
{
IMainDbContext _context;
      public Any(IMainDbContext context)
      {
           _context = context;
      }
     public List<User> AnyFunction()
     {
            var result = _context.Database.
                       // Here is the issue I can't find Database
      }
}

@sudurrani That's because the interface doesn't define a Database property.

@ajcvickers exactly when I add Database property then whenever I use _context.Database.ExecuteSqlCommand here I won't be able to access .ExecuteSqlCommand.
Actually .Database & .ExecuteSqlCommand are DbContext builtin but here I'm using interface with my context class hence unable to get these methods.
Still Can't In .Database & .ExecuteSqlCommand into the game.

@sudurrani Unless I'm missing something, that's just the way C#/.NET  works. Is there something EF should be doing differently here?

I found the solution.
Therefore closing the issue.


008-feat: Migrate Events and Functions from jQuery to JS ES6

This is the migration of events like click, hover scroll and resize along with their corresponding handlers from Bigfoot.js in jQuery to JS ES6
Util functions like calculatePixelDimensions(), roomCalc(), positionTooltip() etc. related to the positioning and sizing of the popovers have also been successfully moved to ES6 successfully.
Main methods like createPopover() and removePopovers(), have been moved to JS ES6. These methods are called every time a footnote is clicked or when the user clicks outside, respectively.

This would fix https://github.com/Shyam-Sundar-Bharathi/cse210-tinyfoot-team14/issues/8 and bring us closer to achieving https://github.com/Shyam-Sundar-Bharathi/cse210-tinyfoot-team14/issues/12.

@rashi-bhansali LGTM!


Rest API

Want to take a stab at a V2 of the API.

Take advantage of Spring HATEOAS, and make the API self discoverable through use of link and proper rest nouns/verbs.  Will be more consistent and easier to navigate.

Separate the domain model from the rest api resources.  Currently, the client needs to have more knowledge of the domain than it should have to.  Since Hygieia has been around a while now, we have a better understanding of the use cases, which should give us a better understanding of what resources we will need to expose.

Instead of removing the old API, create a V2 we could slowly migrate to.  This would most likely be accomplished through the url.  ex. "http:/localhost/api/v2/foo"

Let me know if you guys have any thoughts on this, or would like to see anything else.

I'd also like to decouple the collector's from the database by having them use the API instead. This should hopefully make it a bit easier for individuals to build/maintain collectors.

Yeah, was definitely going to keep that in mind as we go.

There is some discussion on gitter regarding some changes needed to receive "Comcast" contributions like Rally collector and some others they built.

@irvingoe I believe that one involves changing Hygieia from a monolithic git project to a submodule git project, which might be a bit beyond the scope of this particular issue.
We could certainly split the API out into it's own project, though - that might make it easier for individuals to set up and make localized contributions to just the API. The same could be said about the UI - if all you want to do is make a few aesthetic improvements, you (theoretically) wouldn't have to set up a ton of stuff to make that contribution.
@rob-miller-777 totally onboard with all of the above ideas, though.

fyi... we are looking into having Hygieia as an org. It will help breaking things easily. Stay tuned.


Setup Deployment Pipeline

Jenkins Build Pipeline

Git Push triggers build
Build, Test, Package, Deploy -> Artifactory
Static Code Analysis
Automatically Deploy to Test
Run FrontEnd Tests
Automatically Deploy to Staging
One-Click Prod Deployment

Done: http://<IP_ADDRESS>:8080/view/Pipeline/