Failed to load xml from ROS param [ros_ign_gazebo create]

Test environment

Ubuntu 20.04
ROS2 Foxy
ignition citadel

Test launch file
<?xml version="1.0"?>
<launch>
  <group>
    <include file="$(find-pkg-share ros_ign_gazebo)/launch/ign_gazebo.launch.py">
      <arg name="ign_args" value="empty.sdf" />
    </include>
  </group>

  <node pkg="ros_ign_gazebo" exec="create" args="-world empty -param robot_description" output="screen">
    <param name="robot_description" value="$(command 'cat $(find-pkg-share test_robot_ign_gazebo)/urdf/my_robot.urdf')" />
  </node>
</launch>

This failed for "Failed to get XML from param".
How I resolved
Before
https://github.com/ignitionrobotics/ros_ign/blob/94a719adcf6005fae657a174489cb99349c33ced/ros_ign_gazebo/src/create.cpp#L44-L52
After
   ros::init(_argc, _argv, "ign_create");
   ros::NodeHandle nh;

   gflags::AllowCommandLineReparsing();
   gflags::SetUsageMessage(
       R"(Usage: create -world [arg] [-file FILE] [-param PARAM] [-string STRING]
                        [-name NAME] [-X X] [-Y Y] [-Z Z] [-Roll ROLL]
                        [-Pitch PITCH] [-Yaw YAW])");
   gflags::ParseCommandLineFlags(&_argc, &_argv, true);

This change works good for me.

Thank you for ticketing the issue, @chama1176 . I haven't tried reproducing the issue, but your proposed fix looks ok to me. Would you be able to open a pull request with the fix?

Thank you for confirmation.
OK.I will send a pull request with the fix.

Should be fixed by #120


Server crashes when player with enderite armour goes near endermite that's spawned in structures in the nether

Love the mod but there's a persistent crash issue on our server which is a custom modpack with a variety of structure mods as well as this.
We just got to the end and during our explorations we've encountered multiple crashes, all of which had one thing in common which was the enderite armour set and endermite.
Some assistance to fix this would go a long way!!!
Crash report has been attached below, please let me know how we can fix this issue
crash-2023-08-01_15.57.20-server.txt

Is that in the 1.19?

A maybe easy fix is to disable endermites are peaceful full set bonus. But that is not an elegant way.
I need to make tests and then to try to get a solution.
But can you give some more information?:
Which minecraft version? = 1.20.1
Which Forge version? = 47.1.43
Which enderite version? = 1.3.0
How do you do, that you get the crash?

You say that you have a full set of enderite on?

Is that now every time when you start the server, or if you join the server with the full set of enderite?

Minecraft Version = 1.20.1
Forge version = 47.1.43
Enderite version = 1.30
When one of my friends who had a full set of enderite armour landed at a structure that had endermite spawning in it.
We tried disabling the set effect but that didn't help.
This happens only in some places through the end so the crashes are usually abrupt and I've to admin tp the player to another location to play peacefully.
Is there any other info we can provide apart from the crash report attached above?

Alright. I think we'll have to disable this mod, Il make sure to look into the other mods conflicting. We'll wait for your next update. Hope to hear about that soon!!

I released just now the 1.3.2 update where this bug should be fixed. Because ArmorUtils called a Local player method and not for both. That's now solved and also the 1.19 should be fixed. In my test, everything was fine. No Problems nothing!
Thank you for your report and your support!!!

The new uploading system from Curseforge to protect you for Malware is a little slow, but the files are uploaded you can later download that! I mark this as closed. If you have this problem again, reopen it or made a new issue.
Thank you!

It is now really fixed with the 1.3.3


fix: allow SSH to be enabled and disabled via variable

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
Fixes #2693
Fixes ENG-1886
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace did not allow explicitly disabling SSH when other SSH was given.
What else do we need to know?
This also enables disabling SSH via variables.

@FabianKramm This is ready for review, but the e2e tests are really flakey. The issue seems to be that the helm deploy fails intermittently, sometimes (but not always) accompanied by a Downloading helm... log message, but the runner should already have helm installed, and was able to find it on previous test runs it seems. We can always remove the tests if we're confident in the solution. I haven't been able to reproduce the test flakiness locally either.


NVMe driver race condition

Currently there is a race condition in the NVMe driver, at least with ReleaseFast mode. This is making the kernel unable to load a minimal userspace program since it can't load a file from disk. Hardly ever happens.

NVMe implementation deleted. Closing


Add a Gitter chat badge to README.md

Microsoft/visualfsharp now has a Chat Room on Gitter
@latkin has just created a chat room. You can visit it here: https://gitter.im/Microsoft/visualfsharp.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Ok didn't realize this would auto-open just like that :sweat_smile:
Just floating this our there - anyone want to use Gitter as a VF# Tools development chat?  Seems to have caught on at https://gitter.im/dotnet/coreclr and https://gitter.im/dotnet/roslyn
I know there is http://chat.stackoverflow.com/rooms/51909/f, but that seems more suited to general F# chat, this would be reserved for chat related to development/plans for Visual F#.

did @gitter-badger sign the CLA?

I would appreciate a chat channel for F# dev. It's quite difficult sometimes to find where one should apply look into the code when looking into a bug.


TP2000-804 Add workbasket column to version control tabs

TP2000-804 Add workbasket column to version control tabs
Why
The version control tab of an object shows the activity date of an update and changes to validity periods but doesn't provide the user with the workbasket number in which the update was made.
What

Adds a new column titled "Workbasket" that details the workbasket number in which the update occurred and links to it.

What

Codecov Report
Patch coverage: 91.30% and project coverage change: -0.01 :warning:

Comparison is base (6848d1c) 92.22% compared to head (c0e104d) 92.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%
==========================================
  Files         411      411
  Lines       26998    27021      +23
  Branches     2024     2026       +2
==========================================
+ Hits        24898    24919      +21
- Misses       1714     1715       +1
- Partials      386      387       +1

Impacted Files
Coverage Δ

measures/forms.py
97.35% <71.42%> (-0.41%)
:arrow_down:

measures/tests/test_forms.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Send2Trash Silently Fails on Network Share in Windows 10

Setup:
Computer A is running Windows 10 and is sharing a folder across the network.
Computer B is running Windows 10 and is accessing the shared folder from Computer A. A python script running on Computer B is trying to send a file in the shared folder to the recycle bin.
When I run Send2Trash, I don't get any error message and the file remains on disk. Nothing happens. Is this expected behavior?
Using this method here, I have File Explorer set to send files on the shared folder to the recycle bin when the delete key is pressed. But apparently that doesn't translate over to Send2Trash.

I experienced this issue on Send2Trash 1.5.0. I updated to 1.8.0 and now it works as expected (the file is sent to the Recycle Bin).


AttributeError: 'Instrument' object has no attribute 'tie'

I'm getting the following error when running pianoplayer "xy.mid" --verbose -n10 -rvz
(tested on Windows with Python 3.8 & 3.7, and on Manjaro python 3.8)
Traceback (most recent call last):
  File "/home/anton/.local/bin/pianoplayer", line 195, in <module>
    rh.noteseq = reader(sf, beam=args.rbeam)
  File "/home/anton/.local/lib/python3.8/site-packages/pianoplayer/scorereader.py", line 51, in reader
    if n.tie and (n.tie.type=='continue' or n.tie.type=='stop'): continue
AttributeError: 'Instrument' object has no attribute 'tie'

The error is coming from music21, what version is it?

I had the same issue with version 6.3.0 of music21.
I downgraded to version 6.1.0 and the error went away
To downgrade:
pip install --upgrade music21==6.1.0

Thanks @fchazel !
I need to check what has changed in music21 or specify the version to import in requirements..

Error should be fixed in the latest release.

Error should be fixed in the latest release.


adding check for credentials file not existing before erroring out

Currently with 0.2.3+, assume will always error out if you do not have an ~/.aws/credentials file present despite it not being required.
This patch tests the error for os.ErrNotExist by way of the os.IsNotExist err utility func.

@dcarbone thanks for your contribution! I added an additional check on top of your branch in #198 and have merged this 👍

oop!  sorry i missed that one!


build: Branch main rename build

Contributes to #2884
Updates the build steps targeting V1
What did you change?
Build related main to main_v1
How did you test and verify your work?
Will need to run a test build

Think you are correct @matthewgallo, I don't think a ci-check:v1 is needed. Should probably test this assumption.


Is this ready for submission to official repo?

Can we submit this for inclusion to https://codebase.show/projects/realworld ?
Is there anything missing that is pending for completion?

It doesn't have the commenting system in place, And the styling is done manually, instead of using their pre-defined stylesheet. But I think the second point doesn't actually matter. I don't know how they feel about needing to include the commenting system

These are requirements

Look at the (a bit ridiculous) requirement of a framework used needs at least 300 stars.
At this very moment, Sutil has only 217...

Well that's an awkward requirement. I wanted to update this codebase a little bit anyway

has only 217
;-(

@kaeedo if you need a hand, please do say

has only 217
;-(

I mean... "only"


ModelState Validation doesn't work as expected

Hi,
EDIT : I'm on the beta3 packages, VS CTP 6
I'm actually making some test on the validation of my Model.
I have a class with different property
    public abstract class User
    {
        public string Id { get; set; }
        [Required]
        [EmailAddress]
        public string Email { get; set; }
        [Required, MaxLength(100)]
        public string FirstName { get; set; }
        [Required, MaxLength(100)]
        public string LastName { get; set; }
        [Required, MaxLength(255)]
        public string Address { get; set; }

        public DateTime Birthday { get; set; }
        [Required]
        [EnumDataType(typeof(CountryIso))]
        public object CountryOfResidence { get; set; }
        [Required]
        [EnumDataType(typeof(CountryIso))]
        public object Nationality { get; set; }
    }

Everything is working fine for the Required, but the EnumDataType and EmailAddress doesn't work as expected.
I wrote a simple test
        [Fact]
        public void PostNatural_UnknowCountryIso_PropertyNameIsInList()
        {
            var user = new UserNatural {
                FirstName = "a",
                LastName = "a",
                Email = "a",
                Address = "a",
                Nationality = 250,
                CountryOfResidence = 250
            };
            var results = new List<ValidationResult>();

            ValidationHelper.TryValidate(user, results);

            Assert.True(results.Any(r => r.MemberNames.Any(memberName => memberName == nameof(UserNatural.Nationality))));
        }

To see if the Enum is properly found (The last value is 249)
public enum CountryIso
{
       ...
        ZM = 248,
        ZW = 249
}

But the model State is always Valid.
Am i missing something?
I've tried to Switch the object Type of the properties to string(Which doesn't compile) and int (Which doesn't find an error when the input isn't inserted).
Same with EmailAdresss the "a" value is accepted.
Here is code of The ValidationHelper
    internal static class ValidationHelper
    {
        internal static bool TryValidate(object @object, ICollection<ValidationResult> results)
        {
            var context = new ValidationContext(@object, serviceProvider: null, items: null);

            var isValid = Validator.TryValidateObject(@object, context, results);
            return isValid;
        }
    }

@rynowak @dougbu Where are we at with support for these data annotations?

see #327.
the basic answer is that we have adapters that could support [Validation] and any subclass.  instead we register only a few subclasses.  so we support [EmailAddress] but not [EnumDataType].
@Samvrie [EmailAddress] has very permissive validation.  "a" is valid.  you could try to find something the following regular expression would reject:
"^((([a-z]|\\d|[!#\\$%&'\\*\\+\\-\\/=\\?\\^_`{\\|}~]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])+(\\.([a-z]|\\d|[!#\\$%&'\\*\\+\\-\\/=\\?\\^_`{\\|}~]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])+)*)|((\\x22)((((\\x20|\\x09)*(\\x0d\\x0a))?(\\x20|\\x09)+)?(([\\x01-\\x08\\x0b\\x0c\\x0e-\\x1f\\x7f]|\\x21|[\\x23-\\x5b]|[\\x5d-\\x7e]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(\\\\([\\x01-\\x09\\x0b\\x0c\\x0d-\\x7f]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF]))))*(((\\x20|\\x09)*(\\x0d\\x0a))?(\\x20|\\x09)+)?(\\x22)))@((([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])*([a-z]|\\d|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])))\\.)+(([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])|(([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])([a-z]|\\d|-|\\.|_|~|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])*([a-z]|[\\u00A0-\\uD7FF\\uF900-\\uFDCF\\uFDF0-\\uFFEF])))\\.?$"

@dougbu Thanks for the answer i will try a RegExp for my Email checking.
Is there a way to actually add my own DataAnnotations validations?

@Samvrie the simplest way would be to subclass ValidationAttribute. Nothing much should have changed here so any public docs you find for DataAnnotations should be valid for creating your own.

Thanks! I will look into that!

Well i'm facing an other problems. I've implemented my own class for EnumValidation, my attributes is properly created, but the IsValid method is never called.

@Samvrie please file a separate issue for your new concern.  include information about how your enum validator is being used.
do you agree with closing this issue as a duplicate of #327?
btw the regular expression I provided earlier is from at least one version of [EmailAddress]. my suggestion was to reverse-engineer that to find a string that would result in validation failures.

Yes sure, we can close this issue, i will open a new one more appropriate to the case

thx


Local build instructions

Hey, thanks for adding my request to the latest build of the site, was wondering if you could also add build instructions, including package metadata files (such as package.json), in case anyone wants to build the site locally (I certainly would)

Hey, there is a frontend folder in the repo that holds the code for the frontend.
It's a regular Vue app, so just doing npm install and npm run dev should get you started :)

Ah my bee the package.json file in the frontend code earlier.
Thanks, you can close this issue :)


Draft: 152 feature traffic sign detection

Description
Create a model for traffic sign detection
Fixes #152
Time invested
Tim Dreier: 8h (so far)
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?
No
Most important changes
That the training with the DVC experiment works.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[x] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

Basically, this PR could be merged since it currently isn't involved in driving. However, since we never trained a model I will leave this as a draft.
It could be easy be used in future work :)


Open DB error handling

This PR adds an optional, overridable hook in SquidDatabase that allows the user to attempt to recover if the database fails to open for any reason (i.e., if we catch a RuntimeException trying to open the DB). There aren't too many actions that can be taken here, since the DB isn't open, so the hook is currently designed largely around the actions that are reasonable -- attempting to reopen the DB with a recursive call to getDatabase(), or deleting and recreating the DB using recreate(). A retryCount parameter incremented on each call to the hook allows clients to abort/crash instead of getting caught in an infinite loop if even deleting and recreating the DB file doesn't fix the problem. By default, if this hook is not overridden, it will simply rethrow whatever exception was forwarded to it (meaning if you don't use the new hook, behavior is exactly the same as it was before).
In future versions, we should consider if a checked exception approach would be better, but that would a) be a backwards-incompatible change and b) break from the Android pattern of preferring to throw RuntimeException subclasses for SQLite problems, so for now this seems like the safest option.
This PR is tagged with WIP so we can continue to consider the API and gather a bit of feedback before we merge it.

Let's give this another thorough review, maybe add one or two more test cases, and then get it merged. We can leave it tagged with @Beta to indicate that it's less developed than other APIs and may change in the future.

Let's merge so we can start testing it


Mossy: Gantt extra label at origin

Could we remove this label at the origin of the graph (highlighted in image)?

This is actually the very first date in the dateset, but the format is off and so if being displayed wrong. It should display like the other dates now.

The prod version does not put the first date at the origin, but could leave it this way


GPflow2 small fixes

Some small typing and documentation fixes for GPflow 2
Regarding the TensorLike type definition not working with multipledispatch, I think that multipledispatch expects a class, rather than a type definition, which is why it was failing. In the cases where we were using multipledispatch with TensorLike I think we should have just been using object.

I'd be strongly in favour of not just multiple-dispatching on object, this is more confusing when looking at the source code itself. The multipledispatch package does handle unions of types, but unfortunately using tuples instead of typing.Union[]. Maybe we could make a PR to the multipledispatch package to support that? Should be a fairly simple fix in https://github.com/mrocklin/multipledispatch/blob/b62be264c89cdddb39eb4a4d0d0e525d99b5133b/multipledispatch/dispatcher.py#L211 ...

I'd be strongly in favour of not just multiple-dispatching on object, this is more confusing when looking at the source code itself...

@st-- A couple of comments on this:

I think that the code could be made clearer by using type hints (for example, the Kuf_matern32_fourierfeatures1d function could be declared as Kuf_matern32_fourierfeatures1d(inducing_variable: FourierFeatures1D,  kernel: Matern32, X: TensorLike)) but this is separate from the types that are used by multipledispatch.

I think that multipledispatch expects a class, but Union is (as I understand it) a type definition. So I'm not sure it would be easy to make the two compatible

I think it would be possible to define a tuple of (tf.Tensor, tf.Variable, np.ndarray) for the purposes of woirking with multipledispatch, if you think this would make things clearer. Personally I think that object is a good way of marking paramaters that you don't care about (that you don't want to dispatch on), but I haven't used multipledispatch very much, so don't feel strongly about this.

I think that the code could be made clearer by using type hints (for example, the Kuf_matern32_fourierfeatures1d function could be declared as Kuf_matern32_fourierfeatures1d(inducing_variable: FourierFeatures1D, kernel: Matern32, X: TensorLike)) but this is separate from the types that are used by multipledispatch.

multipledispatch can actually make use of type annotations to dispatch (see https://github.com/mrocklin/multipledispatch/blob/b62be264c89cdddb39eb4a4d0d0e525d99b5133b/multipledispatch/dispatcher.py#L204 and following lines)! so maybe we could unify this more.

I think that multipledispatch expects a class, but Union is (as I understand it) a type definition. So I'm not sure it would be easy to make the two compatible
I do think it could be made compatible, but would involve a code change upstream in multipledispatch (basically, when a type is a Union[], extract its subtypes, and loop over those, instead of only hard-coding this behaviour for tuples).

@nfergu could you split out the typo/docstring fixes in scipy.py (which I'd be happy to approve straight away) from the TensorLike changes (which haven't been resolved yet)?


Sync to chef supermarket

it seems like the latest version isn't uploaded to chef supermarket.
Could you sync the updates?

Released v2.3.0.
https://supermarket.chef.io/cookbooks/td-agent/versions/2.3.0


Removed step name redundancy for yaml/json configurations

Fix for #213

https://github.com/KonduitAI/konduit-serving/issues/213#issuecomment-586802743

Closing this right now. Have to think about a bit more towards restructuring the final looking minimal schema.


Failed to load resource: the server responded with a status of 505 (HTTP Version Not Supported)

Hi I use nginx to forward the 9002 port with following config:
server{
  listen 80;
  server_name  datahub.demo.com;
  index  index.php index.html index.htm;

  location / {
    proxy_pass  http://DatahubServerIP:9002;
    proxy_set_header Host $http_host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
  }
}

But I got the following error...

Hi @suishaojian !
We've had this issue before. See this thread: https://datahubspace.slack.com/archives/CV2UXSE9L/p1630056938000500

Hi @suishaojian !
We've had this issue before. See this thread: https://datahubspace.slack.com/archives/CV2UXSE9L/p1630056938000500

Thanks John. But I cannot join this slack workspace cause some unknown reason. Could you invit me with my email<EMAIL_ADDRESS>or  could you pls give me another way to solve this problem ?

Yes sent the invite!

Yes sent the invite!
@jjoyce0510  Thanks a lot. But another problem ..

My SlackUsername is suishaojian. Could you pls invit me with this username? thank you

Yes sent the invite!

Thanks  a lot . Join successfully ~~


separate core AbstractAnalyzer functionalities from JETAnalyzer analysis

Remaining TODOs:

[ ] explain directory structure
[ ] add performance analyzer (deprecate JETTest.jl)
[ ] re-organize test
[ ] re-organize documentation

Maybe I address 2. ~ 4. in another PR.

Codecov Report

Merging #244 (f1ac3b6) into master (4cb3357) will decrease coverage by 0.65%.
The diff coverage is 87.36%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   87.71%   87.05%   -0.66%
==========================================
  Files          13        8       -5
  Lines        1896     1916      +20
==========================================
+ Hits         1663     1668       +5
- Misses        233      248      +15

Impacted Files
Coverage Δ

src/toplevel/graph.jl
100.00% <ø> (ø)

src/ui/print.jl
90.00% <ø> (ø)

src/JET.jl
66.34% <65.03%> (-6.79%)
:arrow_down:

src/abstractinterpret/inferenceerrorreport.jl
86.15% <86.15%> (ø)

src/abstractinterpret/abstractanalyzer.jl
85.47% <89.28%> (ø)

src/analyzers/jetanalyzer.jl
90.42% <90.42%> (ø)

src/abstractinterpret/typeinfer.jl
94.44% <94.44%> (ø)

src/toplevel/virtualprocess.jl
96.79% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb3357...f1ac3b6. Read the comment docs.

There is no considerable difference in benchmark. Going to merge.


Bindings containing colons break the syntax highlighting

Also bindings inside CDATA don't appear

Adding an = to indicate an eval on an attribute  messes up the syntax highlighting

Make sure in cases like the below its noted we don't recommend using quotes around bindings but if the binding contains symbols it may be necessary, for example date strings.


[Feature]: Migrate all RBAC related resources to Helm chart's templates

Checklist

[X] I've searched for similar issues and couldn't find anything matching
[X] I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?
None
Problem Description
Both manager's and k8sgpt's roles have to match in order for the former to grant permissions to K8sgpt cluster role or add the verb escalate. Following the Least privileged access idiom, would be great if we move away from the existing way of managing roles
Solution Description
Lift and shift the cluster role, bindings and service account from operator's code to Helm chart's tempates
Benefits
To be more transparent to the end users and also avoid situations like K8s API restrictions with roles which caused issues in the latest v0.0.22
Potential Drawbacks
No response
Additional Information
No response

hi @arbreezy, can i do ?

hey @arbreezy, just to make sure I got it right, i need to migrate all the RBAC from this folder config/rbac to the helm template, right?

Hello @MateSousa let me elaborate a bit more,
At the moment we are creating with the controller the K8sGPT's role, rolebinding and service account.
There are two issues with this approach,

The controller's role we define here has to match the K8sGPT's role permissions otherwise K8s API disallow the creation, although controller doesn't need those perms for its own workload
In terms of readability, we want to surface those K8sGPT;s role rolebinding and service account in the chart

So the proposed solution is to move them out of our codebase and include them as part of the chart's template folder
then in the deployment struct we will just reference the service account name (as we already do)


Documentation: Clarify use of the app-icon slot on ic-top-navigation

Summary

improve slot documentation for ic-top-navigation to make it clear that anything set in the 'app-icon' slot will be aria-hidden.
give an example of how to correctly use Gatsby Links in your top-navigation (how we do it in the ICDS Site's Top Nav)

💬 Description
Looking at the code docs for top navigation it states "any type of element can be passed" into the component and 'app-icon' is described as "content will be rendered to left of app title" without explicitly mentioning that it will be considered decoration and hidden from screenreaders.
We have had one customer pass in an image inside a Gatsby Link as the app-icon slot, when the correct implementation for that is to slot it in the app-title

Change the description of the prop in ic-ui-kit to state that it is hidden, in addition to a code example on ic-design-system


UI: Trade Flow: Font gets clipped

Background
In our current app (app.shapeshift.com) when using non-imperial locales (BR for instance) or entering numbers with many digits the values displayed being to clip.
We should instead reduce font size based on character count.
For example in the trade module

You can use Coinbase as a reference since their site does it correctly (screenshots below).  You will see the font size decreases as more characters are added.

Steps to reproduce

go to https://app.shapeshift.com/dashboard
pair your metamask wallet
Attempt to trade something large 5000000 ETH and see how the digits are displayed in the trade section, the trade modal, etc.

Acceptance Criteria

Implement dynamic font size based on increasing character count that works with all screen widths and is fully responsive.
Resolve all places that this is occurring (trade component is shared across two pages)

https://app.shapeshift.com/assets/ethereum - trade and modals
https://app.shapeshift.com/dashboard - trade  and modals

Bounty Hunters

Join our discord here.  Feel free to ask for help in #engineering-public channel
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info

@SS-FOX-McCloud - is there anywhere else that this is an issue or just the trade modal?

A previous attempt at this issue can be seen here for reference - https://github.com/shapeshift/web/pull/742


Same file, but get different results in jadx0.7.1 and jadx0.7.2

Left 0.7.1,right 0.7.2

@luoyesiqiu
Did you enable option to show bad codes in 0.7.1?

@luoyesiqiu looks like a regression, can you share this apk?
Otherwise, I don't know how to reproduce this issue.

@sergey-wowwow I did not find this option

@skylot Of course.
antutu.zip

Looks like jadx-0.7.2-unstable-b441-1931e78 decompiles this method, but jadx-0.7.2-unstable-b442-188bfd1 (and later) decompiles it only with --show-bad-code (with warning about inconsistent code).
Is this a regresion, or jadx just learned to detect such bad code in b442-188bfd1?
Same code fragments (decompiled with --show-bad-code) looks different:
b441 and earlier:
                    for (i4 = 0; i4 < size; i4++) {
                        if (((String) arrayList3.get(i3)).equalsIgnoreCase((String) arrayList.get(i4))) {
                            stringBuilder2 = new StringBuilder();
                            stringBuilder2.append(str3);
                            stringBuilder2.append("#");
                            stringBuilder2.append(arrayList2.get(i4));
                            str3 = stringBuilder2.toString();
                        }

b442..b478:
                    i = 0;
                    while (true) {
                        i4 = i;
                        if (i4 >= size) {
                            break;
                        }
                        if (((String) arrayList3.get(i3)).equalsIgnoreCase((String) arrayList.get(i4))) {
                            stringBuilder2 = new StringBuilder();
                            stringBuilder2.append(str3);
                            stringBuilder2.append("#");
                            stringBuilder2.append(arrayList2.get(i4));
                            str3 = stringBuilder2.toString();
                        }
                        i = i4 + 1;

Code from b441 and earlier looks much better for me, doesn't it?
I'm think, there may be regression somewhere in these commits (maybe in 188bfd1 ?):
6df3150 gui: add Hack font
8445ebf fix sonar badge
a27cb9c core: bind blocks for target instructions at early stage
7b6825d core: move same instructions from predecessors for loops
188bfd1 core: fix endless loop processing (#275)

@luoyesiqiu in both versions generated code is incorrect (don't equal to bytecode) and the problem is similar to #311. But the latest version shows a warning and hide such misleading code. Also here can be some problems with finally block restore because a lot of code is duplicated.
So, I will return to this issue after I fix #311.

@skylot thanks


EOS-26779: Logging configuration in miniprovisioner needs

Problem:
By default the stream in setup_logging is sys.stderr
which is populating the logs in the stderr. stderr
indicates the log type as error. So all logs should
be populated on stdout. Error can be indicated by
return value, instead of log type as stderr.
Solution:
Changed stream from sys.stderr to sys.stdout in setup_logging
Signed-off-by: Bhargav Dekivadiya<EMAIL_ADDRESS>Problem Statement

Problem statement

Design

For Bug, Describe the fix here.
For Feature, Post the link for design

Coding
Checklist for Author

[ ] Coding conventions are followed and code is consistent

Testing
Checklist for Author

[ ] Unit and System Tests are added
[ ] Test Cases cover Happy Path, Non-Happy Path and Scalability
[ ] Testing was performed with RPM

Impact Analysis
Checklist for Author/Reviewer/GateKeeper

[ ] Interface change (if any) are documented
[ ] Side effects on other features (deployment/upgrade)
[ ] Dependencies on other component(s)

Review Checklist
Checklist for Author

[ ] JIRA number/GitHub Issue added to PR
[ ] PR is self reviewed
[ ] Jira and state/status is updated and JIRA is updated with PR link
[ ] Check if the description is clear and explained

Documentation
Checklist for Author

[ ] Changes done to WIKI / Confluence page / Quick Start Guide

Can one of the admins verify this patch?

@bdekvadiya, deployment needs to be tested with this PR. cc @vaibhavparatwar

@bdekvadiya, deployment needs to be tested with this PR.

I have tested the PR changes and results are populated here : https://jts.seagate.com/browse/EOS-26779


Registry

We need to be able to register users. The password must be hashed and salted, in other words we need to use something like passport js. Registry page is the home page, you can add a model, controller, and utility to get this function working

Finished by cole


ECDSA_* is deprecated and not longer available in 1.1.0. EC_KEY_* is used instead

Checklist

[x] documentation is added or updated

Rich, thanks for the pointer. I added the part into the commit message.

Thank you.  And see, that big scary red label went away :)  Just need another person to review and we'll fix it

merged, thanks again!


There are currently too many client-side Graphql queries made on load

Currently, when loading the application dashboard, the front end make a lot of different graphql queries. Taking a look through these, it looks to be pretty inefficient and ad-hoc.
For example, switching tabs calls getApp and getLicenseType and getMetadata. Why do we need three calls? Shouldn't GraphQL be letting the client construct queries that make this a easier?
We currently hard code the queries in the client so that the react components don't construct the query they need, which results in a lot of duplication of queries and inefficiencies. In short, this is making the GraphQL implementation in this project function more like REST, but without status codes.
I think we need to document a strategy here to get this under control before we run into concurrent socket limits and/or put too much load on the kotsadm-api requesting duplicate data.

All of these are slowly being migrated to the kotsadm Go Rest API


Fix maven settings file collision

It is intended that a CI pipeline passes its own maven settings file
into the checkoutAndBuild command as an env variable rather than
creating a hard-coded setting file inside the script.
Creating a new settings file broke the CICD build pipeline in our
organization.
Description

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7287 (e877ed9) into master (6fb51d2) will decrease coverage by 8.84%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7287      +/-   ##
============================================
- Coverage     71.33%   62.49%   -8.85%
+ Complexity     3363     3271      -92
============================================
  Files          1505     1495      -10
  Lines         74224    73874     -350
  Branches      10733    10695      -38
============================================
- Hits          52950    46168    -6782
- Misses        17678    24332    +6654
+ Partials       3596     3374     -222

Flag
Coverage Δ

integration1
29.82% <ø> (-0.04%)
:arrow_down:

integration2
?

unittests1
69.00% <ø> (-0.03%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40e2d3...e877ed9. Read the comment docs.


[WIP] DSV2 support

Problem:

TiSpark uses Datasource API V1 in writing API and catalyst, And spark 3.0 has introduced the Datasource API V2 which allows for a lot of great new possibilities. In my view, Datasource API V2 at least has following advantages for TiSpark

support delete
support spark streaming

Of course, there are lots of other benefits for V2. I think V2 is most likely going to be the key way to interact with datasources in the future for Spark so i'd like to replace V1 API to V2 API
Goals

Replace Datasource API V1 to V2
Obsolete non catalog plugin
More understandable user doc

Solutions

Obsolete non catalog plugin mode
Move the dependency of API v1 in Catalyst
Replace API v1 to v2
Rewrite original writing code. Because API v2 no longer depends on RDD and SparkSession, which are used in original write logic.

Compatibility
No things will be changed  expect the support for non catalog plugin mode. It means you can't operate TiDB without catalog plugin mode anymore.
Design

Implementation

Test

Doc

/run-all-tests tikv=v5.3.0 tidb=v5.3.0 pd=v5.3.0


Fix members page and invite page transition

Details

Added an forwardRef in BaseSelectionList which allows focusing the text input from outside the component.
Added autoFocus in BaseSelectionList, which defaults to true, we can pass false, to disable auto focusing, which breaks the animation.
In WorkspaceInvitePage and WorkspaceMembersPage, the autoFocus is set to false, and it's focused manually after the transition animation ends using onEntryTransitionEnd, so the animation runs smoothly.
Fixed Issues

$ https://github.com/Expensify/App/issues/25860
PROPOSAL: https://github.com/Expensify/App/issues/25860#issuecomment-1691963222
Tests

Click on profile icon to open settings
Go to Workspaces and open any workspace
Click on Members and verify if the page animates/slides in
Click on Invite button and verify if the page animates/slides in

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Click on profile icon to open settings
Go to Workspaces and open any workspace
Click on Members and verify if the page animates/slides in
Click on Invite button and verify if the page animates/slides in

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/120749263/71be6989-7cf5-43b1-8a6f-83c7d34da1fc

Mobile Web - Chrome

https://github.com/Expensify/App/assets/120749263/9204372a-c815-4617-82dc-3f3c14802977

Mobile Web - Safari

https://github.com/Expensify/App/assets/120749263/3db35082-0a1b-4898-a499-b15ca25bfec2

Desktop

https://github.com/Expensify/App/assets/120749263/dd6fb2f5-c39c-459c-8a5a-e67a62e66893

iOS

https://github.com/Expensify/App/assets/120749263/5006b188-b592-4750-8713-8511012a41b8

Android

https://github.com/Expensify/App/assets/120749263/c81440a0-bacd-441b-ae6a-63a880ab7eb0

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I'm testing this, I'll update you once it's done.

@roryabraham
These changes are working fine in WorkspaceInvitePage and WorkspaceMembersPage.
However, it also creates bugs in a few places, some inputs are not auto-focusing.
Currently, these pages are affected CountrySelectorModal, YearPickerModal, and StateSelectorModal.
I think since these are Modal, not navigation pages, so the navigation.addListener('transitionEnd') is never called.
I thought making changes globally would cause bugs in other places, and that's why I made changes that won't affect other pages.
What do you think?

Alternatively, we can add a prop to the BaseSelectionList to focus the text input after the transition ends, so the pages that require the input to be focused after the transition ends, can be set manually just by adding a single prop to the BaseSelectionList.

Hey all! So a quick note - on skimming this issue, I think this is going to be something that's going to be solved in the SelectionList refactor that's in progress, so I'm not sure it needs to be fixed separately. See the related discussion here

Going to close this since it will be handled separately. @DrLoopFall should still be compensated for the fix.


fix: Fixes toBufferBlock error when jsonBlock is null. Add getBlockByNumberWithRetry

Fixes https://github.com/trufflesuite/truffle/issues/3130 with changes to match those in https://github.com/MetaMask/web3-provider-engine/blob/master/index.js by @kumavis

Ok, so it looks like this repo has all the same commits of MetaMask/web3-provider-engine's repo up until this 15.0.0 commit https://github.com/MetaMask/web3-provider-engine/commit/5f7acf6c96028f151b5d3ad2a99cb935056f2b71, and they resolved the invalid block error a couple of commits later in this commit on 24 April 2019 https://github.com/MetaMask/web3-provider-engine/commit/21b1849b5433c0df5371c13a33922c7e1ee83374, but that change was also merged in this later commit on 20 August 2019
https://github.com/MetaMask/web3-provider-engine/commit/8ee565e5acb33a424c42afd15c88639b06489f01, and then later it was improved in this commit https://github.com/MetaMask/web3-provider-engine/commit/fae46ddf3b5b768ffb3e871489d8d8c6d444e236 where _getBlockByNumberWithRetry was added.
And this PR reflects all those changes.

Is there anything in the repo that they mention here that could be useful too? https://github.com/MetaMask/web3-provider-engine/commit/921e9561abd60ee91bbd57c43669e955c2145710

@ltfschoen I don't believe we've scoped out what necessary changes we'd have to make on our end to configure hdwallet-provider to use json-rpc-engine instead of web3-provider-engine.
Hopefully the changes made here suffice for now 🤞 .


why --save-dev?

Seems like it is used in the code, instead of in the toolings.

You are correct, this is now fixed.


Error when pairing

This error comes when I try to pair my Nebra outdoor miner with Bluetooth.

Please send a mail to<EMAIL_ADDRESS>


nodes on same net same password auto-peer

i could swear it was working before like this at some point but time to add it back

got it working again


Text turns white when mouseover in selection fields

I found this little bug
https://github.com/user-attachments/assets/ccda4047-d980-4d3c-bfba-8e3cb82a9708
It turns the text white against a white background, so you can't see it. Would you happen to have an idea why/how to fix it?
PS love the theme, keep up the good work!

It has been fixed. You can now update it from the repository.

Perhaps I've missed something... I downloaded the latest commit and put it in my profile, but I see the same issue happening. Not sure why...

Perhaps I've missed something... I downloaded the latest commit and put it in my profile, but I see the same issue happening. Not sure why...

Please tell me the website's address.

Sorry, it was my mistake. I didn’t test it on macOS last time, but now it’s fixed. Please download it again.


Minor wording modifications

@AErmie : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@AErmie - thank you for the fixes.
#sign-off


Support Dashboard SSO

This project should make it easy to configure dashboard SSO for service instances as documented here: http://docs.cloudfoundry.org/services/dashboard-sso.html#broker-responsibilities

This project should support the Open Service Broker API. Dashboard SSO is a Cloud Foundry feature that is not part of OSB API. This functionality is desirable for Cloud Foundry, but should be implemented in a separate library.


ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  update or delete on table "projects" violates foreign key constr...

https://sentry.io/uncw/rails/issues/492631951/
PG::ForeignKeyViolation: ERROR:  update or delete on table "projects" violates foreign key constraint "fk_rails_f58e9073ce" on table "user_projects"
DETAIL:  Key (id)=(1) is still referenced from table "user_projects".

  app/controllers/projects_controller.rb:55:in `destroy'
    @project.destroy
...
(103 additional frame(s) were not displayed)

ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  update or delete on table "projects" violates foreign key constraint "fk_rails_f58e9073ce" on table "user_projects"
DETAIL:  Key (id)=(1) is still referenced from table "user_projects".
: DELETE FROM "projects" WHERE "projects"."id" = $1

ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  update or delete on table "projects" violates foreign key constraint "fk_rails_f58e9073ce" on table "user_projects"
DETAIL:  Key (id)=(1) is still referenced from table "user_projects".
: DELETE FROM "projects" WHERE "projects"."id" = $1

Fixed with 40f0d75b78d4a65ab7f0dbfe012f3fbede365740


How to specify the max cache memory used while load model

I noticed that while vllm load model in a k8s pod, it use some cache memory, I just want to know how to specify the max size the cache use. So that I can run the pod with much lower memory.
In my case, I start a pod with 32G memory, it load the model successfully, use 100% memory, in which 4GB RSS and 28GB cache memory.
And I start another pod with 116GB memroy, which use 4GB RSS and 100GB cache memory

@jony0113  Try --gpu-memory-utilization 0.5. Be sure this value is limited in (0, 1].

@jony0113 Try --gpu-memory-utilization 0.5. Be sure this value is limited in (0, 1].

thanks for reply, but this param looks like only limit the max gpu memory.
in my case, the cache memory I mentioned is cpu memory

hey @jony0113 were you able to resolve this issue?


Add Bangkit Academy

Bangkit is a Google-led academy designed to produce high-calibre, technical talent for world-class, Indonesian technology companies and startups. This year, Bangkit is offered as an approved Kampus Merdeka program  supported by the Ministry of Education and Culture of the Republic of Indonesia. We’re enrolling up to 3,000 university students across 3 learning paths to help them grow in-demand skills in tech throughout the even semester of 2022. For more information about Bangkit, please visit bangkit.academy.
Web: https://bangkit.academy

@dadangnh Thank you for the request. Regrettably, I have to close it without merging. The academy does not have year-long courses, thus it's formally not eligible for the free university licenses. Please ensure you are familiar with this repository rules located at the bottom of this page if you are in doubt.
Please apply for an appropriate licensing option (which may also be free) at https://www.jetbrains.com/community/education/#courses
Thank you for your understanding!


(suggestion) backport the option to move the camera up and down to MC 1.12.2

¿can the option for move the camera up and down be backported to 1.12.2?

FAQ States:
Q: Can you port feature x to version y ?
A: No


change : [M3-6471] - Add resource links to NodeBalancers empty state landing page.

Description 📝
Add's resource links to NodeBalancers empty state landing page.
Target release date 🗓
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷

Before
After

How to test 🧪
Verification steps
(How to verify changes)

Navigate to http://localhost:3000/nodebalancers
Validate all the resource links as stated in the ticket.

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@mjac0bs Added cypress test coverage and fixed the text wrap issue for small screens. 7e6a1ba


get 404 when visiting localhost:3001

not sure if im doing something wrong on my end but i went through the steps in the readme, used WSL2 on windows with ubuntu as the environment. it starts up just fine as far as i can tell but when i hit localhost:3001 i just gives me a 404 page not found error.

nevermind, i figured it out. for now im using postman to send the json body to localhost:3001/lookup and its spitting out a result now.


MCU change -> no rebuild

Rebuild is not started if I change the MCU:
$ ino build -m mini
...
$ ino build -m mega
make: Nothing to be done for `all'.
make: Nothing to be done for `all'.

Thanks!
This is because make doesn't rebuild when Makefile itself changes. Will look for most elegant solution.


New modmail

This is currently in-progress and nowhere near finished. I wanted to get more centralized feedback on the direction and scope of the implementation instead of cluttering up #56 with snippets.
Once this is finished, it fixes #56.
Edit: Ready for review

Ready for review

Sorry about the delay, I've been a bit busy recently. Just letting you know that I've seen this and will review when I get the chance.

@not-an-aardvark have any time in the upcoming weeks? Would be nice with review while my mind still remembers the code :)

Hi, just checking in on this PR -- is it still a work in progress?

Hi, just checking in on this PR -- is it still a work in progress?

@not-an-aardvark it’s ready for review. Did you notice anything odd?

No, I had been looking at the comment at the top of the PR that says "This is currently in-progress and nowhere near finished." Sorry about the miscommunication -- I'll try to take another look in the next few days.

No, I had been looking at the comment at the top of the PR that says "This is currently in-progress and nowhere near finished." Sorry about the miscommunication -- I'll try to take another look in the next few days.

No worries, I should've changed that too :)

Sorry about the long delay, this is still on my radar. I'll review it over this weekend.

Added it to the subreddit. Not sure if mail is all the permissions it needs but if it doesn't work I can change it
Ideally we should have a script that can setup the testing environment for us. If I get the time I would like to try and work on this next when I get the time. This would need to rely on Snoowrap itself to set up the environment though.

Thanks. All the tests are passing for me with the exception of can mute a user:
  1) snoowrap new modmail can mute a user:
     StatusCodeError: 400 - {"fields":[null],"explanation":null,"message":"Bad Request","reason":"CANT_RESTRICT_MODERATOR"}
      at new StatusCodeError (node_modules/request-promise/lib/errors.js:32:15)
      at node_modules/request-promise/lib/rp.js:70:37
      at tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (node_modules/bluebird/js/release/promise.js:512:31)
      at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:569:18)
      at Promise._settlePromiseCtx (node_modules/bluebird/js/release/promise.js:606:10)
      at Async._drainQueue (node_modules/bluebird/js/release/async.js:138:12)
      at Async._drainQueues (node_modules/bluebird/js/release/async.js:143:10)
      at Immediate.Async.drainQueues [as _onImmediate] (node_modules/bluebird/js/release/async.js:17:14)
      at processImmediate (internal/timers.js:439:21)

Do you know what might be happening there? If not, I can try to look into it (it's possible that it's a local condition).

My bad, missed out one permission for the bot. Should work now!

Great, thanks! I'll merge this and try to get a release out.

Published as v1.16.0.

@not-an-aardvark Seems like tests failed due to permissions, does it run on a different bot?
Also, do you have an IM platform you use where we talk?

The tests on Travis should be using the /u/snoowrap_testing account, but I'm guessing I forgot to add the mail scope (since the scope didn't exist when the token was generated). I'll add it now.
We could use Gitter (I set up a chatroom for this repository awhile ago, but it doesn't appear to have gotten any use). Gitter also supports private messages via the "person" icon on the left sidebar.

@not-an-aardvark have the docs been updated? https://not-an-aardvark.github.io/snoowrap/Subreddit.html doesn't have getNewModmailConversations

@not-an-aardvark have the docs been updated? https://not-an-aardvark.github.io/snoowrap/Subreddit.html doesn't have getNewModmailConversations

Seems like I forgot to add that. I've opened #199 for it
In the meantime you can call snoowrap.getNewModmailConversations({entity: 'subredditName'}) which is more or less what the Subreddit.getNewModmailConversations() will do

Oh right @SpyTec, thanks! Just wondering, are there any docs for the fields on ModmailConversation and ModmailConversationAuthor? I'm working on the TypeScript types for them now and a reference would be handy.

@markspolakovs We would at some point want to add either TS definition files or convert components to TypeScript as the project goes on if that's something you want to help out with 😉
Unfortunately, it will be difficult to map what is returned from new modmail. From a rant I posted to a few friends:

For instance, participant may not be there. Sometimes it is, sometimes it isn't. I don't know when it's there or when it isn't. It also moves around depending on if it's in list or detail view. Same with author

I can give JSON response for each endpoint though:
/conversations
{
    "conversations":
    {
        "75hxt":
        {
            "isAuto": false,
            "objIds":
            [
                {
                    "id": "eg3v4",
                    "key": "messages"
                }
            ],
            "isRepliable": true,
            "lastUserUpdate": "2019-03-07T14:11:06.909685+00:00",
            "isInternal": false,
            "lastModUpdate": "2019-07-24T15:16:33.809212+00:00",
            "lastUpdated": "2019-07-24T15:16:33.809212+00:00",
            "authors":
            [
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "snoowrap_testing",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 50555952,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTec13",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 13118708,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTec13",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 13118708,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTec13",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id": 13118708,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTecSnoowrap",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id":<PHONE_NUMBER>19,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTecSnoowrap",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id":<PHONE_NUMBER>19,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTecSnoowrap",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id":<PHONE_NUMBER>19,
                    "isDeleted": false
                },
                {
                    "isMod": true,
                    "isAdmin": false,
                    "name": "SpyTecSnoowrap",
                    "isOp": false,
                    "isParticipant": false,
                    "isHidden": false,
                    "id":<PHONE_NUMBER>19,
                    "isDeleted": false
                },
                {
                    "isMod": false,
                    "isAdmin": false,
                    "name": "EliteDangerousBot",
                    "isOp": true,
                    "isParticipant": true,
                    "isHidden": false,
                    "id": 47524494,
                    "isDeleted": false
                }
            ],
            "owner":
            {
                "displayName": "SpyTecSnoowrapTesting",
                "type": "subreddit",
                "id": "t5_xogi3"
            },
            "id": "75hxt",
            "isHighlighted": false,
            "subject": "snoowrap test",
            "participant":
            {
                "isMod": false,
                "isAdmin": false,
                "name": "EliteDangerousBot",
                "isOp": true,
                "isParticipant": true,
                "isHidden": false,
                "id": 47524494,
                "isDeleted": false
            },
            "state": 1,
            "lastUnread": null,
            "numMessages": 27
        }
    },
    "messages":
    {
        "eg3v4":
        {
            "body": "

You have been temporarily muted from r/SpyTecSnoowrapTesting. You will not be able to message the moderators of r/SpyTecSnoowrapTesting for 72 hours.
\n
",
            "author":
            {
                "isMod": true,
                "isAdmin": false,
                "name": "snoowrap_testing",
                "isOp": false,
                "isParticipant": false,
                "isHidden": false,
                "id": 50555952,
                "isDeleted": false
            },
            "isInternal": false,
            "date": "2019-07-24T15:16:33.809212+00:00",
            "bodyMarkdown": "You have been [temporarily muted](https://www.reddithelp.com/en/categories/reddit-101/moderators/modmail-muting) from r/SpyTecSnoowrapTesting. You will not be able to message the moderators of r/SpyTecSnoowrapTesting for 72 hours.",
            "id": "eg3v4"
        }
    },
    "viewerId": "t2_7t6gk",
    "conversationIds":
    [
        "75hxt"
    ]
}

/conversation/:id
{
    "conversation":
    {
        "isAuto": true,
        "objIds":
        [
            {
                "id": "ddfzq",
                "key": "messages"
            },
            {
                "id": "5p28r",
                "key": "modActions"
            }
        ],
        "isRepliable": true,
        "lastUserUpdate": null,
        "isInternal": false,
        "lastModUpdate": "2019-06-04T11:04:15.186318+00:00",
        "lastUpdated": "2019-06-04T11:04:15.186318+00:00",
        "authors":
        [
            {
                "isMod": true,
                "isAdmin": false,
                "name": "SpyTec13",
                "isOp": true,
                "isParticipant": false,
                "isHidden": true,
                "id": 13118708,
                "isDeleted": false
            },
            {
                "isMod": true,
                "isAdmin": false,
                "name": "SpyTec13",
                "isOp": true,
                "isParticipant": false,
                "isHidden": false,
                "id": 13118708,
                "isDeleted": false
            }
        ],
        "owner":
        {
            "displayName": "SpyTecSnoowrapTesting",
            "type": "subreddit",
            "id": "t5_xogi3"
        },
        "id": "8f5rc",
        "isHighlighted": false,
        "subject": "invitation to moderate /r/SpyTecSnoowrapTesting",
        "participant": {},
        "state": 2,
        "lastUnread": null,
        "numMessages": 1
    },
    "messages":
    {
        "ddfzq":
        {
            "body": "

gadzooks! you are invited to become a moderator of /r/SpyTecSnoowrapTesting: SpyTecSnoowrapTesting!
\n\n
to accept, visit the moderators page for /r/SpyTecSnoowrapTesting and click "accept".
\n\n
otherwise, if you did not expect to receive this, you can simply ignore this invitation or report it.
\n
",
            "author":
            {
                "isMod": true,
                "isAdmin": false,
                "name": "SpyTec13",
                "isOp": true,
                "isParticipant": false,
                "isHidden": true,
                "id": 13118708,
                "isDeleted": false
            },
            "isInternal": false,
            "date": "2019-06-04T11:04:15.186318+00:00",
            "bodyMarkdown": "**gadzooks! you are invited to become a moderator of [/r/SpyTecSnoowrapTesting: SpyTecSnoowrapTesting](/r/SpyTecSnoowrapTesting)!**\n\n*to accept*, visit the [moderators page for /r/SpyTecSnoowrapTesting](/r/SpyTecSnoowrapTesting/about/moderators) and click \"accept\".\n\n*otherwise,* if you did not expect to receive this, you can simply ignore this invitation or report it.",
            "id": "ddfzq"
        }
    },
    "user":
    {
        "recentComments": {},
        "muteStatus":
        {
            "isMuted": false,
            "endDate": null,
            "reason": ""
        },
        "name": "snoowrap_testing",
        "created": "2016-01-25T06:26:36.059057+00:00",
        "banStatus":
        {
            "endDate": null,
            "reason": "",
            "isBanned": false,
            "isPermanent": false
        },
        "isSuspended": false,
        "isShadowBanned": false,
        "recentPosts": {},
        "recentConvos":
        {
            "8f5rc":
            {
                "date": "0001-01-01T00:00:00+00:00",
                "permalink": "https://mod.reddit.com/mail/perma/8f5rc",
                "id": "8f5rc",
                "subject": "invitation to moderate /r/SpyTecSnoowrapTesting"
            }
        },
        "id": "t2_u3l80"
    },
    "modActions":
    {
        "5p28r":
        {
            "date": "2019-07-24T18:35:00.822908+00:00",
            "actionTypeId": 2,
            "id": "5p28r",
            "author":
            {
                "name": "SpyTec13",
                "isMod": true,
                "isAdmin": false,
                "isHidden": false,
                "id": 13118708,
                "isDeleted": false
            }
        }
    }
}

/conversations/count
{
    "highlighted": 0,
    "notifications": 0,
    "archived": 0,
    "new": 0,
    "inprogress": 0,
    "mod": 0
}

@SpyTec thanks for that! Yeah, I remember implementing this API when it was first a thing - one line somewhere went name: message.user.user.name, prefixed by // what the f**k?.
I'll try to bang out a PR to DefinitelyTyped in the next few days.


B6 challenge submission

pending:B6
@iicc1 it appears you’ve not submitted logs with the Log Summary Tool. If you could please follow the instructions on that page to submit logs that will allow us to properly evaluate your submission. Thanks!

pending:B6
@iicc1 it appears you’ve not submitted logs with the Log Summary Tool. If you could please follow the instructions on that page to submit logs that will allow us to properly evaluate your submission. Thanks!

pending:B6
@iicc1 it appears you’ve not submitted logs with the Log Summary Tool. If you could please follow the instructions on that page to submit logs that will allow us to properly evaluate your submission. Thanks!

FAILURE Client has not been run - so can't gather logs from it!
The logs were too big and I deleted them :(

pending:B6
@iicc1 it appears you’ve not submitted logs with the Log Summary Tool. If you could please follow the instructions on that page to submit logs that will allow us to properly evaluate your submission. Thanks!

FAILURE Client has not been run - so can't gather logs from it!
The logs were too big and I deleted them :(

Form submitted at 23/04/2022 14:17 CEST


Add dictionary lookup to WordFind

There is a free (non-commercial use) API for Merriam-Webster that could be used, as long as the API key is not made public here.... https://dictionaryapi.com

There should be an optional properties file with the developer API key. If present, the file is opened, the key is read, and the API for dictionary lookup is enabled. Also the file (if present) should be bundled into the .jar file.  No errors if it is not present, though, and the dictionary lookup should be disabled.

There is a lot more information contained in the dictionary API response that we could include, but I'll leave that for a new issue. The basic lookup is working now, so this issue is being closed.


Pin azure-keyvault-administration dev requirement

azure-keyvault-administration fails the mindependency test because its dev_requirements.txt includes the master branch's azure-storage-blob, which requires a later version of azure-core. Azure-keyvault-administration doesn't need the latest blob API, so a simple fix is to pin an azure-storage-blob version having a compatible azure-core requirement.

/check-enforcer override


Remove no-longer-needed clamping of RRect radii

Description
This removes some clamping added in https://github.com/flutter/flutter/pull/111515 now that https://github.com/flutter/engine/pull/36062 has landed in the framework.
Related Issues

https://github.com/flutter/flutter/issues/78855
https://github.com/flutter/flutter/issues/111086

Tests

No tests changed here because we're removing unnecessary code.

test-exempt: code refactor with no semantic change


Button Height

Preferences page doesn't look right w select dropdowns
are they supposed to be full width?

full width pho sho
the little bar on the right should be height 100%
ideally, the height of the dropdowns and the buttons would be the same
ideally, skinny buttons wouldn't be necessary :trollface:
ideally, the border colors would match our button styles or vice versa

The height of select elements looked fine before the app color/contrast PR by @jolesbi. They used to be the same height as the buttons, so let's go back to that. (see picture in #864)

I like having two button sizes. Look at GitHub: there's a separate button size for "Close and comment"/"Comment" and the "Edit"/"New Issue" buttons in the top right of this page. I don't think this has to be changed.

Is the distinction: primary action buttons / secondary action buttons?

Yo yo Mr. Picnic, do you need help getting this done for tomorrow?


[launching-pad] Find a home for the "Rust By Example" Working Group

This is a tracking issue for finding a long-term home for the WG-Rust By Example team.
Lead:

@marioidival

Hey there all, as part of #118, I'm starting the triage process of trying to find permanent homes for teams currently under the launching pad. As WG-Rust By Example is also a working group, #91 is also relevant.
In this first pass, I'm making tracking issues for each of the teams, starting the discussion on whether y'all think there is a reasonable team you think would make sense to move under, and in general checking whether the members of these teams are still actively working on things related to these teams.
It looks like https://github.com/rust-lang/rust-by-example is still quite active, so no need to confirm that, in https://github.com/rust-lang/leadership-council/issues/118#issuecomment-2529704249 it was suggested that there are some other groups that might make sense to group together with Rust By Example, or in https://github.com/rust-lang/leadership-council/issues/123#issuecomment-2546569294 it was suggested that it might make sense to home the book team under the lang-docs team. Do either of those suggestions seem potentially reasonable for Rust By Example?
Thanks!

It looks like https://github.com/rust-lang/rust-by-example is still quite active, so no need to confirm that, in #118 (comment) it was suggested that there are some other groups that might make sense to group together with Rust By Example, or in #123 (comment) it was suggested that it might make sense to home the book team under the lang-docs team. Do either of those suggestions seem potentially reasonable for Rust By Example?
Thanks!

Yes, I agree with move RBE under lang-docs for sure.

Hi @ehuss, @JohnTitor, as leads of the lang-docs team, do you have any objections to adopting "Rust By Example" as a subteam of the lang-docs team, with @marioidival as the lead/member of that subteam? This would allow us to help clear teams currently residing under the Launching Pad top level team.
If this seems agreeable, we can open a PR to the team repo to make this process official.
CC @nikomatsakis and @tmandry as leads of T-Lang, where lang-docs is a subteam of.

I would of course be delighted. I think it'd be great to expand the scope of docs to focus on helping people learn rust.
I'd love to talk about how we can incorporate docs better. Something to consider.

I would of course be delighted. I think it'd be great to expand the scope of docs to focus on helping people learn rust.
I'd love to talk about how we can incorporate docs better. Something to consider.

As potential additional teams that may fit a similar profile as Rust By Example, #123 (the Book team) and #132 (community rustbridge) are potential matches as well, however I'd like to get confirmation with those teams whether they are interested in moving into lang-docs as well.


Disabling "Find in Selection" removes the current text selection

Type: Bug

Open the Find/Replace-Prompt in a file (CTRL+F)
Enable "Find in Selection" (ALT+L)
Select some text
Disable "Find in Selection" (ALT+L)

Expected: text selection remains.
Actual behaviour: text selection is replaced by the next match after it.
This is rather a design or usability bug than a technical bug. Other editors I used before VSCode allowed me to keep the text selection and did not even require to disable "Find in Selection" in order to find in a new selection. The extra step of deactivating something that is not related to the desired goals as a user is unintuitive. Therefore I typically select text and only afterwards I realize that I have to deactivate "Find in Selection" too.
On the other hand, deactivating "Find in Selection" by closing the Find/Replace-Prompt with ESC does not remove the text selection and works fine. The best workflow would be however to just select a new matching range and replace the old one with the new one, it's two steps.
It is a disadvantage for button users. I think, button users should not be disadvantaged in comparison to keyboard users.
The usual behaviour for "Find in Selection" in other editors is, that it deactivates or changes the matching range as soon as a new text selection is made. Or it deactivates the old matching range, maybe activating the new  selectedrange, when a new search activity (pressing CTRL+F again) is issued. It is almost never the case that I need to copy text while I am stepping through search results. (Code clones are bad anyways and with precise regExps I can match all at once.)
Related issues:
Find/Replace using selection is very messed up (closed but issue still applies)
Changing the replae text in search/replace loses text selection (closed)
losing text selection when toggling "Find in Selection"
Entering text in find widget should not clear the selection (closed)
VS Code version: Code - OSS 1.86.0 (Commit unknown, 2024-02-01T21:58:13.529Z)
OS version: Linux x64 6.7.3-zen1-1-zen
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz (8 x 3800)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 4, 4

Memory (System)
31.09GB (20.16GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

DESKTOP_SESSION
plasma

XDG_CURRENT_DESKTOP
KDE

XDG_SESSION_DESKTOP
KDE

XDG_SESSION_TYPE
x11

Extensions (16)

Extension
Author (truncated)
Version

mermaid-markdown-syntax-highlighting
bpr
1.6.0

insert-unicode
bru
0.15.1

vscode-pandoc
Chr
0.4.5

unicode-math-input
czh
0.6.3

dhall-lang
dha
0.0.5

gitlens
eam
14.7.0

vscode-highlight
fab
1.9.0

vsc-unicode-latex
gao
1.3.0

pandoc-markdown-syntax
gar
0.0.2

render-crlf
med
1.7.0

typst-preview
mgt
0.10.7

csharp
muh
1.26.0

godot-csharp-vscode
nei
0.2.1

typst-lsp
nva
0.12.1

vt100-syntax-highlighting
Tob
1.1.0

debug
web
0.26.1

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Cookie Header giving 500 error

Hey, sorry, me again. Cookie header seems to have expired again, I went to go scrape my own, and I found that I couldn't find the cookie value for the R6kq3TV7 key?
Is there anywhere specific to find this to get this back up and running again?

Personally, what I do is open TikTok in a private session, open up DevTools, and take the value of the Cookie header.
I'm hoping to look at yt-dlp in order to create a more permanent solution.

Should have this fix implemented by tomorrow!


[Bug] The start date and end date cannot be set on the same day on the calendar on the study list screen.

Describe the Bug
Now, I am using v3.7.0 (release) on my local Windows11.
On the study list screen, the start date and end date cannot be set on the same day on the calendar.
We need to choose 2 days at least, although we want to choose only 1 day.
If we click "Today" button, we can choose 1 day, but it should be only today.
We can't choose past 1 day.

Steps to Reproduce

git clone https://github.com/OHIF/Viewers.git
cd ./Viewers
git checkout tags/v3.7.0
yarn install
yarn run dev:orthanc

The current behavior
On the study list screen, the start date and end date cannot be set on the same day on the calendar.
We need to choose 2 days at least, although we want to choose only 1 day.
If we click "Today" button, we can choose 1 day, but it should be only today.
We can't choose past 1 day.
The expected behavior
On the study list screen, the start date and end date be able to set on the same day on the calendar.
We should choose past 1 day.
OS
Windows11 pro
Node version
node v16.20.0 , yarn v1.22.19
Browser
Chrome120.0.6099.130

This bug is reproducible by using the pop-up calendar provided. The calendar date selector will not allow date entry of the same date in the start and end date fields:
Version number: 3.8.0-beta.47
Commit hash: df2f50748e98283db458b0cb2fb20931d536b161
Tested on a mac (sonoma 14) + chrome browser (v120)
Steps to reproduce:

From the study list, select the Study Date - Start Date field = the calendar pop-up will display

Select a start date from the calendar that you know a study exists (ex: May-11-2023) = the start date populates

Focus is now on the end date field and the calendar pop is displayed with focus on May 11, 2023 = the same date as the start date

However, I cannot select that date to have it auto-entered into the end date field. When I select May 11, the date is highlighted in dark blue, the next day May 12 becomes highlighted in light blue as a suggested date. I do not select that and nothing happens. Selecting May 11 (dark blue date) does not do anything

With the above said I can however manually edit the end date to be the same as the start date:

Click in the end date field and enter in the numerical values by copying and pasting the start date into the end date field: 05/11/2023. This does enter the dates in the end date field and the study list returns the one study that matches the entered start date and end date of May 11, 2023

@IbrahimCSAE take a look at this one https://ui.shadcn.com/docs/components/date-picker

We released OHIF 3.9 which address this issue


Add support for element templates

Developers may provide custom element templates with the modeler.

[ ] read custom templates from $MODELER_CWD/resources/templates and $USER_DIR/resources/templates. Directories contain individual files (JSON descriptors with template definitions
[ ] inject the configuration into the modeler during bootstrapping
[ ] allow selection of task template and editing of defined properties via properties-panel (bpmn-io/bpmn-js-properties-panel#171)

Feedback from a customer: it would be great to have the opportunity to define drop down lists in the template.
e.g.
Field Name: Age
Possible values:

0-10
11-20
21-50
50-99
Binding: To some input mapping