Inconsistent or wrong type of AccessKeyView.nonce when calling provider.query(params)

Describe the bug
While trying to upgrade the near-api-js dependency to the latest version noticed that the type of nonce is not actually of type BN but a number when we call provider.query<AccessKeyView>(params)
To Reproduce
Steps to reproduce the behavior:
import { providers } from "near-api-js";
import type { AccessKeyView, AccessKeyViewRaw } from "near-api-js/lib/providers/provider";

const provider = new providers.JsonRpcProvider({  url: "https://rpc.testnet.near.org" });

const accessKey = await provider.query<AccessKeyView>({
  request_type: "view_access_key",
  finality: "final",
  account_id: "0f06aecd15f2f75c0fa09ac052c4399fa0e4bf8401cb563283dbaa2e5f727c00",
  public_key: "ed25519:21f2VjgBkrGGo1NqoKDUjhaw9TLRgbzrKX5Erzv9eHtB",
});

console.log("Nonce value", accessKey.nonce); // number:<PHONE_NUMBER>00015
console.log("Type of nonce via typeof ", typeof accessKey.nonce); // number
console.log("Type of nonce via Object.is", Object.is(accessKey.nonce, BN.BN)); // false

In the IDE it suggests that the above accessKey.nonce is of type BN and allows you to access methods like accessKey.nonce.add(new BN(1)) (we need to increase nonce when we create a transaction) but at runtime when this code is called it throws:
TypeError: accessKey.nonce.add is not a function
In reality, the error is thrown for a good reason because accessKey.nonce is a type of number.
Doing something like accessKey.nonce + 1 does not work because Typescript throws an error at build time:
TS2365: Operator '+' cannot be applied to types 'BN' and 'number'.
Expected behavior
After looking at the source code I am not sure if this can be fixed to me it looks like the above call to provider.query() to view access key returns the nonce always as a number.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Microsoft Windows 10 Business
Version	10.0.19045 Build 19045

Additional context
Looks like we still can use nonce as a number without any errors in Typescript by using this new interface which was introduced in the latest versions: AccessKeyViewRaw not quite sure why the original AccessKeyView interface was modified here: https://github.com/near/near-api-js/commit/d439492e1a1b8abaf0642d5bcbc7c72316397a4f
Was this breaking change necessary?
Should we still use it like this approach provider.query<AccessKeyView>(params)?

+1 ran in to same issue

Hey @kujtimprenkuSQA you can check out the newest version of NAJ which uses native bigint JS type. The issue you've described should be resolved by these changes. Let me know if that's not the case. Oherwise, I'll close the issue in 7 days.

Hey @kujtimprenkuSQA you can check out the newest version of NAJ which uses native bigint JS type. The issue you've described should be resolved by these changes. Let me know if that's not the case. Oherwise, I'll close the issue in 7 days.

This issue might not be relevant in the future then, looks like the BN > bigint is going to be another breaking change.


Vue SSR v-html on dynamic-component hydration warning

Version
2.6.11
Reproduction link
This reproduction uses NUXT for convenience, but is reproducible outside of NUXT.
https://github.com/privatenumber/vue-ssr-vhtml-dyncomp-bug
Steps to reproduce
Dynamic.vue
<template>
  <component is="div">
    content necessary
  </component>
</template>

App.vue
<template>
  <dynamic v-html="'
trigger hydration warning
'" />
</template>

What is expected?
The expected behavior is for there to be no hydration warning when the SSR and client markup are identical.
What is actually happening?
Although there isn't a discrepancy in rendered HTML between client and SSR, it gives warnings that there is.

Work around
I used a render function instead of a dynamic-component:
render(h) {
    return h(this.component, [this.$slots.default]);
}

Couldn't reproduce with a plain vue js SSR:
// Step 1: Create a Vue instance
const server = require('express')()
const renderer = require('vue-server-renderer').createRenderer()
const Vue = require('vue')

const DynamicCompWrapped = {
  template: `

    <component
      is="div"
      class="dynamic-comp-wrapped"
    >
      Some content
    </component>

`,
}

const DynamicCompContent = {
  template: `
  <component
    is="div"
    class="dynamic-comp-content"
  >
    Some content
  </component>
  `,
}

const DynamicCompEmpty = {
  template: `
   <component
    is="div"
    class="dynamic-comp-empty"
  />
  `,
}

server.get('*', (req, res) => {
  const app = new Vue({
    data: {
      url: req.url,
    },
    template: `

    <dynamic-comp-empty v-html="'A. no warn'" />

    <dynamic-comp-empty v-html="'
B. no warn
'" />

    <dynamic-comp-content v-html="'C. no warn'" />

    <dynamic-comp-content v-html="'
D. warn
'" />

    <dynamic-comp-wrapped v-html="'E. warn'" />

    <dynamic-comp-wrapped v-html="'
F. no warn
'" />

  `,
    components: { DynamicCompContent, DynamicCompEmpty, DynamicCompWrapped },
  })

  renderer.renderToString(app, (err, html) => {
    if (err) {
      res.status(500).end('Internal Server Error')
      return
    }
    res.end(`
      <!DOCTYPE html>

        <title>Hello</title>
        ${html}

    `)
  })
})

server.listen(8080)

This could be related to Nuxt, if you manage to reproduce outside of it, please open a new issue with a reproduction.

@posva
It's not a rendering error -- it's a client-side hydration warning.
This bug was discovered in a non-NUXT code-base, and reproduced in NUXT for convenience.


Link to the Chatterino homies discord in the About tab

Changed and marked the discord link to direct Chatterino homies users, to the Chatterino homies discord, as we are unable to help them with Chatterino homies problems, in the Chatterino discord. :+1:

@Felanbird You are right, I should have changed it. Thank you very much! :)


Track 2 changes for TS/JS KeyVault

NOTE: Please do not merge until arch board approves setSecret -> addSecret name change.
This PR is a draft of the track 2 changes we want to do to the KeyVault TS/JS API. As some of the changes haven't been accepted by the board, this PR should act as a way to look at what the proposed changes might look like before we're ready to lock them in.

setSecret -> addSecret

The set verb does not strongly connote versioning of the underlying value store. Versioning is a concept users struggled with on first encounter, judging from the user studies. The change to add here is intended as part of a multipart approach to improving the on-ramp experience (in coordination with improved intellisense docs and API docs).

SecretAttributes -> SecretManagementAttributes

In order to break Secret into two parts -- Secret and SecretAttributes -- the type that was already called SecretAttributes is renamed. As the docs call this "secret management attributes", I went with that.

Secret -> Secret + SecretAttributes

As getSecretVersions caused confusions in the user studies because users expected to be able to read a value when one wasn't present, we decided to split the Secret type into two parts: SecretAttributes which is the original Secret minus a value, and Secret which extends SecretAttributes with the value. Now, getSecretVersions iterates over SecretAttributes, and the user will get an error if they try to access the value directly.
The corresponding updateSecret became updateSecretAttributes as part of this change.

Type of version moves from string -> EntityVersion

Something a few folks in the user study did was to create their own secret versions and pass in the strings, as they were confused where the secret versions came from. Being a string may invite users to do this, and then be confused why it doesn't work. Here, I explored using a tagged string to denote this was an internal value rather than something the user created. I'm not sure if this is the direction we want to go or if it will improve the user experience.
This PR also adds support for api-extractor, which will roll up the corresponding .d.ts file as part of the build.

export interface GetSecretOptions extends msRest.RequestOptionsBase {

Same comment as above regarding RequestOptionsBase

Refers to: sdk/keyvault/keyvault/src/secretsModels.ts:173 in 66f0724. [](commit_id = 66f072451b5c4c2f48d3fce5b3dbeab94d755210, deletion_comment = False)

export interface GetAllSecretsOptions extends msRest.RequestOptionsBase {

Same comment as above regarding RequestOptionsBase

Refers to: sdk/keyvault/keyvault/src/secretsModels.ts:188 in 66f0724. [](commit_id = 66f072451b5c4c2f48d3fce5b3dbeab94d755210, deletion_comment = False)

maxPageSize?: number;

This field should be removed, we're not going to expose this parameter to users.

Refers to: sdk/keyvault/keyvault/src/secretsModels.ts:193 in 66f0724. [](commit_id = 66f072451b5c4c2f48d3fce5b3dbeab94d755210, deletion_comment = False)

Addressed the feedback. I went ahead and pulled out api-extractor from this PR. I'll follow-up with another PR that adds API extractor support separately.

We're going to be separating secrets, keys and certificates into their own client.  This file should be moved into a subfolder secrets, and the secrets folder should have it's own index.ts

Refers to: sdk/keyvault/keyvault/src/secretsClient.ts:3 in 514e26e. [](commit_id = 514e26e534f4357b59da3a9a30ee30a200184c78, deletion_comment = False)

export interface SetSecretOptions extends msRest.RequestOptionsBase {

This should have a RequestOptionsBase property rather than extending this interface.

Refers to: sdk/keyvault/keyvault/src/secretsModels.ts:97 in 514e26e. [](commit_id = 514e26e534f4357b59da3a9a30ee30a200184c78, deletion_comment = False)

export interface UpdateSecretOptions extends msRest.RequestOptionsBase {

Same comment as above.

Refers to: sdk/keyvault/keyvault/src/secretsModels.ts:130 in 514e26e. [](commit_id = 514e26e534f4357b59da3a9a30ee30a200184c78, deletion_comment = False)


Add some support for formulas in templates

Linked to #176
This will convert a cell with value: '$=SUM(C{{$enumrowstart}}:C{{$enumrowend}})' to the formula cell: 'SUM(CX:CY)' where X is the starting row of the enumerable and Y in the ending row.
Please see the added test case and example in samples/xlsx/TestTemplateBasicIEnumerableFillWithFormulas.xlsx

@dotnet-policy-service agree

🙌 @meld-cp could we invite you to our team?


Wake-word only detected when talking really slow in Python (in web demo it detects perfectly with same audio)

Using a provided working example, I set up a demo in Python. When using this demo, I confirm that the recorder.selected_device is the correct device. While running this script, I have to say the wake words in slow motion for it to be detected. Like "Jaaaarrrviiis". Otherwise it is not detected. Meanwhile, I selected "Create Wake Word" from the Porcupine console https://console.picovoice.ai/ppn and primed the "Jarvis" wake word. And it detects it flawlessly even when I say it really fast. What could cause this simple Python example to perform so much worse than the web version? I tried various sensitivities, but they all perform the same. Code:
    import os
    import pvporcupine
    from pvrecorder import PvRecorder
    from dotenv import load_dotenv
    load_dotenv()

    porcupine_key = os.environ.get("PORCUPINE_KEY")

    print(pvporcupine.KEYWORDS)

    keywords = ['ok google', 'alexa', 'jarvis']

    porcupine = pvporcupine.create(access_key=porcupine_key, keywords=keywords, sensitivities=[1, 1, 1])
    recorder = PvRecorder(device_index=-1, frame_length=porcupine.frame_length)
    print("Device name:", recorder.selected_device)

    try:
        recorder.start()

        while True:
            audio = recorder.read()

            keyword_index = porcupine.process(recorder.read())
            if keyword_index >= 0:
                print(f"Detected {keywords[keyword_index]}")

    except KeyboardInterrupt:
        recorder.stop()
    finally:
        porcupine.delete()
        recorder.delete()

Using https://github.com/Picovoice/porcupine/blob/master/demo/python/porcupine_demo_mic.py instead has seemed to fix the issue. But I have no idea why.

closing due to inactivity. re-open with an update if needed.


fix: runtime chunk hash should depend on async entrypoint hash

Summary
runtime chunk hash should depend on async entrypoint hash

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench


CORS is missing

Fetching API in js throwing an error :
No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
You can refer to a video:
Access to fetch has been blocked by CORS policy: No 'Access-Control-Allow-Origin' - FIXED!

this has been fixed in https://github.com/sumitkolhe/jiosaavn-api/releases/tag/v0.0.5


Fix bug: The default retry for Datastore does not work at all

We have started to use Datastore for our project which has about 100 req/s and 700 million entries.
Soon we noticed a high error rate over 0.3% for fetching data.
This was the error trace:
Google::Cloud::UnavailableError
<EMAIL_ADDRESS>"description":"Secure read failed",
"file":"src/core/lib/security/transport/secure_endpoint.c",
"file_line":157,
"grpc_status":14,
"referenced_errors":[{"created":"@1486867211.149993825","description":"EOF","file":"src/core/lib/iomgr/tcp_posix.c","file_line":235}]}

Google::Gax::RetryError
GaxError Exception occurred in retry method that was not classified as transient, caused by 14:
<EMAIL_ADDRESS>"description":"Secure read failed",
"file":"src/core/lib/security/transport/secure_endpoint.c",
"file_line":157,
"grpc_status":14,
"referenced_errors":[{"created":"@1486867211.149993825","description":"EOF","file":"src/core/lib/iomgr/tcp_posix.c","file_line":235}]}

I found it curious what retry method that was not classified as transient means because UnavailableError should be retried.
Reading the code, I found a misconfiguration of the default client_config.
Here you pass the default json configuration to Google::Gax.
But in the code of Google::Gax, here,  the retry_codes_def is not used.
In the comment of Google::Gax, we can see the differently structured JSON file from that of this repository (There is no retry_codes_def !!).
But in the other comment of Google::Gax still has word +retry_codes_def+ .
I have no idea which library or comment is correct, but I’ve patched to google-cloud-datastore gem(this repository) and now confirmed that retry is working well. Our server’s error rates went down to 0.0%
I use
google-cloud-datastore 0.23
and
google-gax 0.6.0
Maybe am I using wrong version's combination?
If this pull request is correct, I think we have to rewrite all default client_config.json for other services too.
related to this issue maybe? https://github.com/GoogleCloudPlatform/google-cloud-ruby/issues/723#issuecomment-257442519

I'm not sure why the test fails, but please review it. Thanks.

Thanks for the PR @rakusai! These files are generated and given to us by an internal Google product. We will discuss this with that team tomorrow and adjust every library that uses these files.
Thank you for investigating this, I'm very glad you figured this out and your error rate dropped.

@swcloud What are your thoughts on this? Is the behavior of google-gax incorrect? Or is the generated JSON config incorrect?

@rakusai The failed build was due to a change made over the weekend to the library that builds the documentation. We have fixed the documentation build issue and now the build for this PR is fixed.

@blowmage Do you mean have you fixed the gax-ruby? Should I close this PR?

No, we just fixed the failing build. We are waiting on the google-gax team for a fix.

@landrito @jmuk Can you guys weigh in on this?

This seems to be an issue. We'll investigate.

Bug fix is here: https://github.com/googleapis/gax-ruby/pull/60

@rakusai This issue has been fixed with #1242. It is the same as your fix, but applied to all GRPC clients. So I'm going to close this PR. Thank you for investigating this and opening the PR! We really appreciate it!


[VS Code] Cannot read property 'sessionId' of undefined

Error:
Cannot read property 'sessionId' of undefined
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.834

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.28.2

platformName
MacOS

platformVersion
18.0.0

Thanks for reporting the issue. Can you please run the command "Live Share: Export Logs" and drag-and-drop the zip here or send it to<EMAIL_ADDRESS>

liveshare.zip

@legomushroom can you please take a look?

Logs from @paulsnar
liveshare_logs.zip

This issue is has been closed due lack of any recent activity. We've made lots of improvements to Live Share since this issue. Please re-open the issue, if this issue persists.
🤖Live-Share-Clean-Up-Bot🤖


Outline review for rmd files as Rstudio

Is your feature request related to a problem? Please describe.
When I open rmd file,I cannot review outline in vs code.It's convenient to jump to {r chunk name} in Rstudio.

Describe the solution you'd like
https://code.visualstudio.com/api/references/vscode-api
Describe alternatives you've considered
like Rtools
Additional context
Add any other context or screenshots about the feature request here.

This could be implemented in languageserver to follow up https://github.com/REditorSupport/languageserver/pull/186.

Implemented by languageserver.


HOWTO Readme for printing out

I started a HOWTO file to print and add to the box of parts.
Please extend as you see fit.
Especially the rqt part (as I don't know about it)
I copied most of the parts from other readmes

We can also do/talk about this on Friday.

Could you please add documentation on how to calibrate the position of the marimba? :)

And also how you can grab the mallet holder with rviz using the gripper

And also how you can grab the mallet holder with rviz using the gripper

I added something about this in the hardware setup part. Do you think it should be changed?

Could you please add documentation on how to calibrate the position of the marimba? :)

I added some steps for this, please check if they are correct

I upload the section about how to setup the microphone and how to open visualization.

I fixed some spelling errors and reworked the overall structure, so it makes more sense for somebody who wants to get the system up and running. Especially some hardware that were explained separately in the end were required by software that was started in the beginning, so I interlaced it a little bit. Now, following the guide step by step should work. I also changed the calibration a bit.


[PriorityQueue] Custom comparator for priorities

I'd like to use the PriorityQueue but in my case the values I need to use for ordering are dates and I need the oldest one first. This means I can't use PriorityQueue because the order would be reversed.
In my opinion PriorityQueue should accept an optional comparator callback to decide the order.

Could you use -timestamp for the priority?

I think the order would still be oposite to what I need with timestamp.

Negative timestamp huh? Yeah, I guess that could work. It feels like a dirty workaround rather than proper solution though.

It feels like a dirty workaround rather than proper solution though.

I agree. 2.0 will have a Heap with an optional comparator that would work here.

Would it be possible to have another similar structure with custom comparator and non-destructive iteration?

Like a binary search tree? There is one on the way. :+1:


Fix wrapperProps typo in README and comment

I believe wrapperStyle is a shorthand for wrapperProps and not inputProps, but correct me if I'm mistaken.

Good catch!
We generate README.md from README-template.md via npm run generate-readme. Would you mind reverting the two files and applying the change to README-template.md instead? Thanks!

@CMTegner I looked in README-template.md, but it looks like it gets the API documentation from the source files.  So I modified the change to only update the source file, and tested it by running npm run generate-readme.
Let me know if that works!

Sorry, I got myself confused there for a sec. You're completely right, thanks for the fix!


Not SOTA?

Diverse Human Motion Prediction Guided by Multi-Level Spatial-Temporal Anchors
(ECCV2022 oral) has better performance actually.

We do NOT claim our method is a SOTA method, but a simple yet effective method. We do NOT care whether it is SOTA or not, but it is easy to train or use. Actually, HumanMAC has also been used in some recent research (Interactive Humanoid), indicating it is easy to use. We also find that a co-current ICCV23 work BeLFusion also did not compare your mentioned work. I think the existing benchmark is not large enough to fairly evaluate recent work.
I like to name these performances as "COMPARABLE" but not "SOTA". "Simple yet effective" is what we like.

But you have claimed in your paper "As can be seen, for Human3.6M, our method achieves state-of-the-art results on both ADE and FDE metrics". Also, you claimed " Bolded numbers denote the state-of-the-art results."  and bolded some of your results.

The statement is applicable to the compared baselines in the paper. We take the BeLFusion's baselines as our baselines. Our works are both peer-reviewed, which indicates our work is acknowledged by the community. The metric cannot reflect everything.

Thanks for your prompt response. Any reasons why not take that paper as a baseline since it's working on the same task?

Thanks for your prompt response. Any reasons why not take that paper as a baseline since it's working on the same task?

The author of that work and I know each other. The arxiv version of it seems not public when submitting or getting accepted by ECCV. Therefore, the community seems not to know much about the information about it in time. Therefore, some late works did not compare with it. And I followed these (late) works. After HumanMAC getting accepted, Sirui told me that. And I cite it accordingly.
BTW, the SOTA is really not really essential. An easy-to-train/use method is the wise choice for some downstream tasks and the application.

Seems no further question. I close it.


add monodocs ci build in flytekit

Tracking issue
Fixes https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
With the monodocs build process in flyteorg/flyte, we need a way of making sure upstream changes in the flytekit repo do not break the overall build.
What changes were proposed in this pull request?
Adds a github action workflow to build the docs.

Looks like I cannot merge this one myself. Feel free to merge.


compilation ?

Hi, as I understand it, you need to compile the latest release yourself? You also need to compile winmm.dll?

Oops, seems like I forgot to upload the file ;)
Will do that soon.
On the compilation, if you want to compile it yourself: winmm.dll is just renamed ASI loader from ThirteenAG (I renamed it so that it loads before the game's renderer DLL).

Uploaded the file.


Use chrootarchive to head off tar shenanigans

Use the chrootarchive package instead of the archive package in the implementation of "add", in an attempt to avoid problems with tarballs with unusual paths in their headers.
h/t to @rhatdan

Nice


Cannot upload file using Symfony Cookbook Doctrine File Upload example

Using the code from the cookbook example:
http://symfony.com/doc/current/cookbook/doctrine/file_uploads.html#using-the-id-as-the-filename
I get this error when submitting the final step with the files:
Warning: file_get_contents(): Filename cannot be empty
in vendor/craue/formflow-bundle/Craue/FormFlowBundle/Storage/SerializableFile.php at line 41
            case 3:
                $builder
                    ->add('file1', 'file')
                    ->add('file2', 'file')
                break;
        }

I couldn't find any example how the settings in the docs could help here:
https://github.com/craue/CraueFormFlowBundle#handling-of-file-uploads

I'm beginning to understand after looking at issue https://github.com/craue/CraueFormFlowBundle/issues/151:
I HAVE TO disable the handling by the flow to use my own implementation:
protected $handleFileUploads = false;


iOS Compilation is not working, Error: (modules/admob/ios/src/AdmobBanner.h:1:9:(1:9-1:42): fatal error. 'GoogleMobileAdsGADBannerView.h' file not found [1])

OS target (Android/iOS):
iOS
Godot version:
3.0.6
Issue description:

Hello, I'm trying to compile the AdMob for iOS module (http://docs.godotengine.org/en/stable/development/compiling/compiling_for_ios.html).
I did everything that was requested but is giving this error:

Ps: the version of Google Mobile Ads SDK that I downloaded is the latest (7.44.0), I could not find the version 7.41.0

Did you did this step?

Copy the GoogleMobileAds.framework inside the exported Xcode project folder and link it using the "Link Binary with Libraries" option;

Ps: the version of Google Mobile Ads SDK that I downloaded is the latest (7.44.0), I could not find the version 7.41.0

Well, I'm afraid you'll get other issues, as this module will not work with newer versions of Google Mobile Ads SDK. I don't have a Mac and I'm unable to update it. We need help from the community, but it seems like there's no much people developing to iOS on the Godot community.

pt-BR:
Olá, desculpe pela demora,

Copy the GoogleMobileAds.framework inside the exported Xcode project folder and link it using the "Link Binary with Libraries" option;

Eu consigo exportar, o problema é que eu preciso de 2 arquivos que vão surgir após eu efetuar a compilação para iOS

Copy the library (.a) you have compiled following the official documentation inside the exported Xcode project. You must override the 'your_project_name.a' file with this file.

Eu não consigo baixar a versão (7.41.0), não existe nenhum lugar da internet que dê pra baixar essa versão, eu acho que a Kloder deveria colocar uma área para baixar essa versão, mas talvez isso vá contra os termos de serviço da Google, se alguém tiver essa versão e puder disponibilizar, eu ficarei bastante agradecido.
en-US:
Hello, sorry for the delay,

Copy the GoogleMobileAds.framework inside the exported Xcode project folder and link it using the "Link Binary with Libraries" option;

I can export, the problem is that I need 2 files that will come up after I compile for iOS

Copy the library (.a) you have compiled following the official documentation inside the exported Xcode project. You must override the 'your_project_name.a' file with this file.

I can not download the version (7.41.0), there is no place on the internet to download this version, I think Kloder should put an area to download this version, but maybe this goes against Google's terms of service , if anyone has this version and can make it available, I will be very grateful.

Hello, I downloaded the version 7.41.0 of the Google Mobile SDK through CocoaPods, so the error continues, does anyone have a solution?

Did you do this?

Copy the GoogleMobileAds.framework inside the exported Xcode project folder and link it using the "Link Binary with Libraries" option;

My problem with this error comes from compiling, it says it cannot be found and I'm not sure how to fix it. I don't exactly know how this works, but if it imports from the src GoodMobileAds.framework perhaps the fact that the files its trying to import is hidden in a folder named header then maybe renavigating the imports to the correct files? I'm really not sure but that seems the most logical I just don't know python or whatever language this is.

I found a solution, here's my best attempt at making steps.

Download the GoogleMobileAds.framework, I used the latest one so I believe any version is fine.

Go open a random project on Xcode and scroll to the bottom where there are frameworks and the section that says 'Link Binary With Libraries'

Click on one of the existing framework and press 'Show in Finder'

Add the downloaded framework into the Framework folder presented when doing the step above.

You should now compile the godot source code with the AdMob module and the framework in the lib, ultimately making it easier to export using the template you just compiled.

I think the problem with the instructions, well at least for me, was that linking it is okay for exporting but for compiling there is no way of linking it until you actually put it in the frameworks folder. Idk this was just how I solved my problem and hopefully it helps somebody who doesn't get the instructions too.

Hi @GhostWalker562 and @Shin-NiL  I tried what you asked to do and managed to compile by running all the commands from here (http://docs.godotengine.org/en/stable/development/compiling/compiling_for_ios.html), but couldn't run the last one command
"scons p = iphone tools = no target = release arch = x86_64"
gave the same error when I ran this command I mentioned above, but this file is for simulators only, so no problem.
But fortunately I was able to successfully compile this file (godot.iphone.opt.universal.a), done that, I replaced the project ".a" file with this generated file and asked to run it on my iPhone X, but when the game ran, the game closed and no longer opens, and the following erode appeared in Xcode:
! [image] (https://user-images.githubusercontent.com/20030153/61988917-8b971880-affe-11e9-8a91-e82139ce734d.png)
Ps: I linked all libraries, but the last library, I just found a file "sqlite3" (it wasn't with extension ".framework"
(sorry for the delay in giving you feedback, I've been trying to fix it, but I've had no other success so far)

@gustavottc If you're using the latest AdMob you may have to add your ID and link the flags. https://developers.google.com/admob/ios/quick-start On this page it will tell you all the other frameworks you need to put in your frameworks folder and aditionally configure your xCode manually, including adding the -ObjC and your GADApplicationIdentifier

@GhostWalker562 , it works, but it only opens the ad once, if I open the interticial ad, it can't open anymore unless I restart the app, but on Android it's working normal
any idea what it might be?
I also tested with the sample project, but the same thing happens

@gustavottc I’m not sure, perhaps it’s because of the ad not being displayed when loaded again, or not loading it all a second time? An ad must be prepared and loses before it is displayed every time. If this is not the problem then I am not sure.

@GhostWalker562 could you please give me an example of code?

`func _on_interstitial_loaded():
yield(get_tree().create_timer(2),"timeout")
admob.showInterstitial()
func loadInterstitial():
if admob != null:
admob.loadInterstitial(adUnitID)`
I called loadInterstitial() when I need to load an ad, and when it's done loading I would show it. @gustavottc

This issue should be fixed now. Can somebody test the last commit?

Hi, @GhostWalker562 and @Shin-NiL , these functions works.
But, when i try to show an Interstitial AD and after that a Banner AD, it gives me this error "Multiple locks on web thread not allowed" i already tried to use hideBanner() or resize(), but doesn't work.

@gustavottc this is a known issue and is updated into the README. Idk if they fixed the issue, but it could be found in issue #53

Alright, I'll close this issue since the initial issue has already been resolved and the issue I'm dealing with now is another
Thank you so muh @GhostWalker562  and @Shin-NiL !

@gustavottc Hello there Gustavo, there's any way i can get some help from you about this issue, i'm facing pretty much the same trouble, but i'm not able to re-solve it.
Let me know.

@CompassDevs hello, tomorrow i will write a detailed tutorial how solve it, I'm busy now, but don't worry it's easy to solve

@gustavottc hi, sorry to bother you, but I am doing all that you say And keep getting the same error and can’t find any tutorial.
When you say that put the framework on the folder of the project, is the GoogleMobileAdsSdk folder the framework or only googlemobileads.framework that is inside of the GoogleMobileAdsSdk?
And how I can link it? I go to build phases and then to link binary with libraries, click the add button and search for something like googlemobileads or something similar and I cant find anything.

hey @martinpelli try to do this:

Go open the project on Xcode and scroll to the bottom where there are frameworks and the section that says 'Link Binary With Libraries'

Click on one of the existing framework and press 'Show in Finder'

Add the downloaded framework into the Framework folder presented when doing the step above.

hey @martinpelli try to do this:

Go open the project on Xcode and scroll to the bottom where there are frameworks and the section that says 'Link Binary With Libraries'
Click on one of the existing framework and press 'Show in Finder'
Add the downloaded framework into the Framework folder presented when doing the step above.

Yes that what I did. When I click show in finder it took me to the folder where I have my xcode project, and I puting there the folder downloded from this zip https://developers.google.com/admob/ios/download

hey @martinpelli try to do this:

Go open the project on Xcode and scroll to the bottom where there are frameworks and the section that says 'Link Binary With Libraries'
Click on one of the existing framework and press 'Show in Finder'
Add the downloaded framework into the Framework folder presented when doing the step above.

Yes that what I did. When I click show in finder it took me to the folder where I have my xcode project, and I puting there the folder downloded from this zip https://developers.google.com/admob/ios/download

Solved, I was putting the sdk folder and is the content of the sdk what you have to put, thanks for your help and your time

@gustavottc I done all succesfully but I can’t make the admob methods exists. I have to put something on the export template? If I have to put something there which file? Because I have like 10 files in the bin folder of godot

The AdMob only works on a real device, are you testing in a iPhone or iPad?

The AdMob only works on a real device, are you testing in a iPhone or iPad?

Sorry I am very noob. I installed the newer plugin of admob on android and I have an admob node with a script, so all methods exists, here I don’t have anything similar, so the godot debugger says that for example the init method doesn’t exist, that why I am asking if I have to put something on the custom template on export settings, something that “detect” de admob methods

Oh, i think that i know what is going on.
Are trying to use this module on iOS and the other Module on Android, and this can cause incompatibility.
I created a new module that supports the new Android Plugin System and is compatible with iOS, so you can use for new Android and iOS will no problem, you can check here: https://github.com/Poing-Studios/GodotAdMob
p.s: is still on beta, but works nicely

Oh, i think that i know what is going on.
Are trying to use this module on iOS and the other Module on Android, and this can cause incompatibility.
I created a new module that supports the new Android Plugin System and is compatible with iOS, so you can use for new Android and iOS will no problem, you can check here: https://github.com/Poing-Studios/GodotAdMob
p.s: is still on beta, but works nicely

So you can use the admob node to for example load an ad on ios? Or how you can acces to the admob methods, thanks @gustavottc

Yes, to acess the AdMob methods you need to compile the Godot with the Admob module on modules/ folder

@gustavottc
Ooh I think I am understandig what I am doing wrong, after compiling with the admob module, I am opening godot trough the bin folder, I have to open a new godot that I compiled with the module, the problem is that I don’t know which is becasue I have a lot of files with extensions .a .o and other stuff.

After compile the Engine with the AdMob module, you need to pick the ".a" file that has generated and then you need to overwrite this ".a" with the ".a" of your exported project game

That was what I did but doesn’t recognize the methods
@gustavottc

You need to use AdMob.showRewardedVideo(), like:

this is of example https://github.com/Poing-Studios/GodotAdMob

@martinpelli You got it?

@gustavottc stil trying... I download the example of the kloder module and get working everything, except that I can’t test it,  I have and xcode error, so I am doing something wrong because without the module I don’t have this error

I never saw this error, so strange, are you trying to test on a real device? like iPhone

I never saw this error, so strange, are you trying to test on a real device? like iPhone

Yes, on iphone 8 plus, if I export it without the modules its run perfectly, when I change the “.a” file and add the frameworks I can’t install it. I don’t know if the problem comes from the frameworks (maybe I am adding something wrong) or from the “.a” file but I tried with every “.a” file from bin folder after recompiling

Can you talk with me on Discord? I can help you with this more faster there, so, when we solve, we can put here what was the problem.
Put this String on Add a Friend: "Gustavo Maciel / gustavottc#5069"

"Gustavo Maciel / gustavottc#5069"

I can´t jajaja everything goes wrong for me, with your it say "Failed to add friend", try with my :MartinPelli#9828

Apparently the problem was solved alone, we don't know why he gave the error, when he was trying to help @martinpelli, in the first attempt without doing anything, the game installed in his game and he managed to play

Apparently the problem was solved alone, we don't know why he gave the error, when he was trying to help @martinpelli, in the first attempt without doing anything, the game installed in his game and he managed to play

Yesterday I discovered the problem, I have exactly 2 projects equals, one can been installed on my device an the other no, the only diference betwen the project that work was that in the export settings I have a different personal id (which worked without the module) so I don’t no why, it’s very weird but chnged it and worked, now I have a lot of crashes withe the module, I will try the solutions on the issues section. Thanks for your help offered @gustavottc

Hi, quick question.. does this work with Mono?
My mono version is <IP_ADDRESS>.
I've compiled the mono version of Godot (following this tutorial https://docs.godotengine.org/en/stable/development/compiling/compiling_with_mono.html)
And I've got to this point:
scons p=iphone tools=no target=release arch=arm module_mono_enabled=true mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"
But it keeps giving me this error:
modules/admob/ios/src/AdmobBanner.h:1:9:{1:9-1:42}: fatal error: 'GoogleMobileAds/GADBannerView.h' file not found [1]
Any help would be greatly appreciated. I've followed the above steps to a tee, but I just can't get it working.
Thanks!

Hi, quick question.. does this work with Mono?
My mono version is <IP_ADDRESS>.
I've compiled the mono version of Godot (following this tutorial https://docs.godotengine.org/en/stable/development/compiling/compiling_with_mono.html)
And I've got to this point:
scons p=iphone tools=no target=release arch=arm module_mono_enabled=true mono_glue=yes mono_prefix="$HOME/mono-installs/ios-arm64-release"
But it keeps giving me this error:
modules/admob/ios/src/AdmobBanner.h:1:9:{1:9-1:42}: fatal error: 'GoogleMobileAds/GADBannerView.h' file not found [1]
Any help would be greatly appreciated. I've followed the above steps to a tee, but I just can't get it working.
Thanks!

What Godot version are you using? @brendonion

3.2.3

@brendonion , i'm currently working on a new module for AdMob, check here: https://github.com/Poing-Studios/Godot-AdMob-Android-iOS
i will try to make a build by 3.2.3 version for mono on this repository

Awesome, thank you!

Hey,
I have the same error described in the title with Godor 3.2.3 and the most recent admob version 7.68.0:

In file included from modules/admob/ios/src/AdmobBanner.mm:1:
modules/admob/ios/src/AdmobBanner.h:1:9:{1:9-1:42}: fatal error: 'GoogleMobileAds/GADBannerView.h' file not found [1]

I don't understand how the solution involving xcode should fix this, but I tried it anyway without luck.
How do I get rid of the error?

@Tobi-La are you using mono?

@Tobi-La are you using mono?

Not intentionally, I tried building with

scons p=iphone tools=no target=release arch=arm

Okay, but you aren't using the mono version of godot, correct? And what version of godot are you using? The above repo
https://github.com/Poing-Studios/Godot-AdMob-Android-iOS has pre-made templates you can use. Check it out.

Okay, but you aren't using the mono version of godot, correct? And what version of godot are you using? The above repo
https://github.com/Poing-Studios/Godot-AdMob-Android-iOS has pre-made templates you can use. Check it out.

I was using the "normal" version. But it seems I found my mistake: I was copying the GoogleMobileAds.xcframework instead of the GoogleMobileAds.framework. Seems they change that in the newest admob version, in the video tutorial he just copies all extracted files into the module folder. Thanks anyways for your help!


HARP-5432 Adding terrain up vector as normal

Signed-off-by: Jonathan Stichbury<EMAIL_ADDRESS>

Please search for the


Tune-Up for SubSampledNoise

This replaces calls to size().x and size().y in SubSampledNoise with sizeX and sizeY respectively.
This avoids the unneeded allocation of Vector2i instances. Since this was done very often, it quickly amortized causing intense GC cleanup cycles.
The effect can be observed e.g. in JVisualVM. The number of allocated Vector2i instance decreases:

Nice stats!
We get these every once in a while when somebody gets into a profiling tool. But even though we have free access to YourKit I'm not sure we have any good instructions anywhere for a quick setup to use said profiling tools to find things.
Up for throwing a few quick instructions in the wiki sometime, maybe we can link to it from the forum in some sticky thread somewhere? And do you have/want YourKit access?
(Also: it is totally possible we do have instructions somewhere and I'm just missing them. But it seems like a topic we could probably improve)

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/15/
Hooray Jenkins reported success with all tests good!

Feel free to merge this, by the way. Or can somebody else merge/review? My main PC is down and I may be mostly out of commission for a few more days


Committer: Seelam<EMAIL_ADDRESS>

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@madhukirans, I think you are missing csv file.

@mvalahtv there is an error "The specified key does not exist."
Do I need to take any action?

@madhukirans, I think you are missing csv file.

@mvalahtv When we publish the v1.0.0 we didn't submit any csv file. Now we are publishing version 1.1.0 and few additional CRD are added.

@J0zi @mvalahtv  All tests have succeeded can you please approve?

@kumarrprashant2005 Since you are previous contributor, can you please have a look for changes? if it is ok with you. Thanks

/lgtm

@mvalahtv The changes look good to me

@J0zi Can you please review?

@mvalahtv Can you look at the failure? It doesn't seem to be related to the operator?
TASK [deploy_olm_operator_openshift_upstream : Parse 2] ************************
task path: /tmp/.ansible-pulled/roles/deploy_olm_operator_openshift_upstream/tasks/main.yml:35
fatal: [localhost]: FAILED! =>
  msg: |-
    The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'v1.1.0'

    The error appears to be in '/tmp/.ansible-pulled/roles/deploy_olm_operator_openshift_upstream/tasks/main.yml': line 35, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

    - name: "Parse 2"
      ^ here

@madhukirans you can ignore that ci/prow/deploy-operator-on-openshift is failing. We are testing it now. I am going to retest CVP tests and if they are ok i will merge it

/test CVP

@mvalahtv why are we not seeing the updated image in Operatorhub.io ? any idea ?


Visualize progress of steps throughout the workshop

Microsoft provided the images today. Added them to the workshop.


Update Tests and Exercises for workarounds for Dart 2.8.0

Dart 2.8.0 (found in Dart's dev branch) is causing build failures in the Pull Requests.
There are breaking changes related to Null safety and making types non-Nullable.
The likely cause of the test failures is a change with the API.

#253 This fixes any issue previously breaking the build. No null-related issues were addressed, just updated the dependencies.


[Snyk] Security upgrade uwsgi from <IP_ADDRESS> to 2.0.22

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements-prod.txt

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
HTTP Response Splitting SNYK-PYTHON-UWSGI-5886318
uwsgi:  <IP_ADDRESS> -> 2.0.22
No
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Codecov Report

Merging #358 (9b57529) into develop (5490e7d) will increase coverage by 1.60%.
Report is 31 commits behind head on develop.
The diff coverage is 94.62%.

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
+ Coverage    93.33%   94.93%   +1.60%
===========================================
  Files          129      318     +189
  Lines         4829    10833    +6004
  Branches       444      719     +275
===========================================
+ Hits          4507    10284    +5777
- Misses         234      415     +181
- Partials        88      134      +46

Files Changed
Coverage Δ

apartment/api/serializers.py
100.00% <ø> (ø)

...tions/0008_add_uuid_to_apartment_project_models.py
100.00% <ø> (ø)

apartment_application_service/wsgi.py
100.00% <ø> (ø)

application_form/api/sales/views.py
96.57% <ø> (ø)

application_form/api/serializers.py
100.00% <ø> (ø)

...tions/0021_application_date_of_birth_ssn_suffix.py
100.00% <ø> (ø)

...ations/0038_applicationapartment_apartment_uuid.py
70.00% <ø> (ø)

...orm/migrations/0040_lotteryevent_apartment_uuid.py
70.00% <ø> (ø)

...ations/0042_apartmentreservation_apartment_uuid.py
70.00% <ø> (ø)

...ct_terminated_to_reservation_agreement_canceled.py
100.00% <ø> (ø)

... and 128 more

... and 106 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Update Resilience + SD.Next Support

As requested in Interpause's version, here's a pull request of the changes I made to make the extension more resilient to changes made by A1111 or SD.Next. I'm going to copy and paste my description from that fork's pull request here just as a way of keeping everything documented in one place.

I've added code to check what the associated backend actually requires for it's txt2img and img2img calls, then pass only those parameters into wrap_gradio_gpu_call(). If a parameter is not in the dictionary of known parameters, the code will look at the datatype and provide a "default" value for that parameter, making the extension more likely to get an image back than crash. Also added console warnings when parameters are missing, giving their name and datatype, making it easier for users to maintain future updates.
Due to the way this update grabs parameters, it works with both Automatic1111 and Vlads/SD.Next backends (and will likely work with any forks of those).
This update also makes the extension drastically more forwards and backwards compatible. Updated versions of the extension won't crash on older UIs, and updated UIs won't crash this version of the extension as easily.
I know @Interpause is looking to get out of maintaining this repo. I think this update might be the best way to do that, because it drastically reduces the complexity of maintenance, and helps give end users the information to fix their local copies.

Thank you, I will likely be available to test this later tomorrow (EST)

@DrCyanide
I'm done checking out your PR and can confirm it works on 1.5.1, I have no doubt it works on 1.5.2 as well since that version doesn't change anything with args to txt2img or img2img. If you say it works on Vlad's I'll believe you on that 😆. Seems like a good way of preventing catastrophic breaks regardless. Good work!
2 Questions:
1 - How does the gr.Request object get its value for the username field? I'm mostly concerned about whether this is something that would also need to be updated in the future or if your code is taking care of that too. (I assume that's the case since I don't see username anywhere, but I also only see primitives getting default values, which could break fast.)
2 - Can you give me push permission to your fork? There are changes that I want to make (already done) before merging, but I still want to accept your PR.

I don't populate the username field.
A1111 is doing something pretty dumb with that, where it's required to make the API work, but it's optional for actually getting used. Specifically, it's only used in modules/processing.py in create_infotext(), with the line "User": p.user if opts.add_user_name_to_info else None,. Since A1111 itself can generate a None for the username it should always be safe to pass in a None there. The add_user_name_to_info setting is also unlikely to be helpful to anyone using Krita, since Krita's metadata would be what gets saved to the final exported image, not whatever A1111 sets.
While A1111 has an authentication option, it seems that is only used for accessing the Web UI itself. If they extend that functionality to the internal API, then we'd need to get the user password as well, at which point both parts of the Request (and the UI) would need to be reexamined.
I'll have to set up permissions another time, it's very late for me now.

No worries for the permissions, it was late (early lol) for me too and the current state of the extension is working anyways.
As for the username field, I looked into gr.Request and it seems like the default object has a username field set to None already. So that's where it was coming from. I had simply sent the request itself (pydantic model) with a username field initialized to "krita". You're right that it's not really important, but it's potentially useful info to have anyways since the intermediate images in txt2img and img2img folders can contain that metadata. We can generate the request object like this gr.Request(username="krita"). We can make it even more robust if we do gr.Request(username="krita", headers={}, client={"host":"<IP_ADDRESS>"}) This seems to cover the example given in the gradio docs. Urgh, why's A1111 doing this... Utterly backwards responsibility management.
In the future the extension definitely needs to switch to using the official API rather than the module function. Your changes make that a lot less necessary though. We can probably last a good while without needing to change anything related to our .
As for changing the UI, I've been looking into that because I want to improve how the combo boxes work for searching models, and it doesn't seem incredibly complex, but the documentation is very limited. The python examples are machine translated from C++.. Yeah.

@DrCyanide Thanks again for the PR! If you'd like to revert your branch to how it was before I made changes so that it may be accepted as it was into the original extension repo, you can now do that.
I hope to see you active on this repo again in the future 😃


ClaimOnOom example has UB

The pointer returned by addr_of!() may only be used to read from the pointee. Writing through it is UB. Unfortunately using addr_of_mut!() it still unstable: https://github.com/rust-lang/rust/issues/57349, so there is not a whole lot that can be done for now. One possible solution I can think of is to have a macro which expands to a ClaimOnOom like type, except hard coded for a single specified memory area. This way the address of this memory area only needs to be taken at runtime. If this macro also defines the static for the memory area to claim itself, then this may even allow it to be used entirely without any unsafe code as the macro can guarantee that the memory area is writable and not used for any other purposes.

The pointer returned by addr_of!() may only be used to read from the pointee. Writing through it is UB.

I'm under the impression that this is not the case. I may be wrong, please just point me somewhere that spells this out (addr_of! doesn't mention it). In general, taking a pointer to a memory location is safe in Rust, casting the mutability of a pointer is safe in Rust, and there's nothing forbidding about writing through an originally-const ptr as far as I can tell in here https://doc.rust-lang.org/std/ptr/index.html#safety
Miri think the following code is perfectly fine:
static mut THING: usize = 1;

fn main() {
    let ptr = unsafe { std::ptr::addr_of!(THING) };
    unsafe {
    	*(ptr as *mut _) = 3;
    }
    let x = unsafe { *ptr };
    println!("The value of x is {}", x);
}

And it prints 3 and all that good stuff. (Of course, changing static mut THING to static THING causes MIRI to freak out, as expected.)
Either way, indeed, not having const_mut_refs makes this initialization code a lot less convenient than it ought to be. (using addr_of made it slightly less awful but it also feels very dirty, UB or not.)

Miri doesn't catch this as it currently conservatively assumes it is fine: https://github.com/rust-lang/rust/blob/7c4ac0603e9ee5295bc802c90575391288a69a8a/compiler/rustc_const_eval/src/transform/check_consts/resolver.rs#L100-L102 (AddressOf is what addr_of!() and addr_of_mut!() lower to in MIR) Turns out it isn't decided whether or not this is actually fine: https://github.com/rust-lang/rust/issues/56604
If &THING as *const usize as *mut usize instead of addr_of!(THING) as *mut usize was used, this is definitively not fine though, even if it is turned into a *const pointer and then casted to a *mut pointer later. You can't ever write through a pointer derived from a shared reference without interior mutability.

Thanks. I wasn't aware &THING as *const usize as *mut usize was UB, (or  very-thoroughly forgot).

So it looks like this particular code is in the grey zone? I'm not hugely concerned by that. Perhaps const_mut_refs will drop before a decision is made on this ^_^  Definitely something I need to keep my eye on though. If addr_of! later disallows mutation through the returned pointer, I'll return to this and think about whether your suggestion is the best way to go about this (it makes sense to me though). Not implementing it now is also mainly a matter of thinking 1. not Talc's job (it's an allocator, where you get the pointers is ideally irrelevant to Talc) and 2. keep it simple. I'm not dead set on this though, if you have a good reason or two to do this now. (Otherwise I'm going to rename this issue and leave it open while https://github.com/rust-lang/rust/issues/56604 is undecided and const_mut_refs isn't stable.)
Please let me know what you think of this path of action.

However, this means some of the API surface of Talc is genuinely problematic, particularly the From implementations on Span for &[T] and &[T; N]. Not UB in itself but encourages to an unacceptable degree IMO.
Here, the .into() is doing the legwork in hiding the issue as per the above. MIRI indeed takes issue with it.
fn main() {
    let mut arena = [0u8; 10000];

    unsafe {
        let mut talc = talc::Talc::new(talc::ClaimOnOom::new(arena.as_ref().into()));
        let x = talc.malloc(std::alloc::Layout::new::<[u64; 3]>()).unwrap();
        *x.as_ptr().cast::<[u64; 3]>() = [1, 2, 3];
    }
}

That's a big screw-up. Whoops. These conversion functions should not exist.
So... hurry a V5 out the door and yank everything after V4.2 ...? I don't know if this is reasonable. Will the compiler actually trip up on this yet? I believe it's not super aggressive in the interest of avoiding atypical LLVM execution paths but I stand to be corrected.
I've got quite a lot I want to put into a Talc V5 and don't have the time right now to do it. In a few weeks I'll have completed my exams so I'll have more time thereafter. This is why I'd prefer to delay it. But this stuff can just be a V6 if need be.
I'll go open an issue about this so long. I'm eager to hear your opinion on the severity of this.

Opened #33 for the latter issue.

Please let me know what you think of this path of action.

Makes sense. I don't think there is much risk of this miscompiling in the short term.

So... hurry a V5 out the door and yank everything after V4.2 ...? I don't know if this is reasonable.

I don't think yanking is necessary. It is a footgun, but still requires unsafe, so it isn't unsound. Do deprecations work for impls? If so adding a deprecation in a patch release us the best option IMO. Otherwise I would suggest adding a doc comment to the impl to discourge using it and leave it at that until the next breaking release.

In a few weeks I'll have completed my exams so I'll have more time thereafter.

Good luck with your exams!

Solid suggestions. (That I should've taken.) I tried to get this all sorted with talc V5 but didn't manage to get it done before the end of vacation.
A feature request came in so I'll address what I can from this once it gets merged.

With const_mut_refs landing soon, I think this will be an issue that can be bypassed before too long. (Having &raw mut is also a nice-to-have now.)


GSD 0.1.5 PR Server spam on crash

We need to figure out why this is happening so many times in a loop. Should only be occurring once per crash.
[18:32:00][VERBOSE] <IP_ADDRESS>:25565 query error
[18:32:00][WARN] Server appears to have crashed for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][WARN] Restarting server after crash for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:32:00][VERBOSE] Server fa4f81a8-d6e8-42a6-82a0-24311f182f46 status: 0
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][WARN] Restarting server after crash for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:32:00][VERBOSE] Server fa4f81a8-d6e8-42a6-82a0-24311f182f46 status: 0
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] <IP_ADDRESS>:25565 query error
[18:32:00][WARN] Restarting server after crash for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:32:00][VERBOSE] Server fa4f81a8-d6e8-42a6-82a0-24311f182f46 status: 0
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][WARN] Restarting server after crash for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:32:00][VERBOSE] Server fa4f81a8-d6e8-42a6-82a0-24311f182f46 status: 0
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:32:00][VERBOSE] Sever Stopped
[18:32:00][VERBOSE] Starting server for mc-ubuntu_lv8jk (fa4f81a8-d6e8-42a6-82a0-24311f182f46) using plugin minecraft

Also occurs for other things...
[18:40:07][WARN] Server has been killed by user. (fa4f81a8-d6e8-42a6-82a0-24311f182f46)
[18:40:07][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:40:07][VERBOSE] Sever Stopped
[18:40:07][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:40:07][VERBOSE] Sever Stopped
[18:40:07][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:40:07][VERBOSE] Sever Stopped
[18:40:07][VERBOSE] Stopping Server fa4f81a8-d6e8-42a6-82a0-24311f182f46
[18:40:07][VERBOSE] Sever Stopped

This is happening because we told it to keep trying to restart if it 'crashed'. Unfortunatly, it is very hard to figure out WHAT is causing the crash. I have been fixing these issues every so often. Mostly in Vanilla though. Which means once you try to use a different game module, this happens again. I need to re-structure the restarting system upon crash.

Don't even bother.
https://github.com/PufferPanel/Scales


bazel: Allow linux i686 builds too

Motivation for this change
Followup to https://github.com/NixOS/nixpkgs/pull/19380#discussion_r82519843

thanks!


remove the INVALID_MIGRATION error

Not sure when exactly it was removed, but it's not there anymore in draft-24.

Codecov Report

Merging #2234 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -<.01%
==========================================
  Files         106      106
  Lines        7776     7774       -2
==========================================
- Hits         6715     6713       -2
  Misses        797      797
  Partials      264      264

Impacted Files
Coverage Δ

internal/qerr/error_codes.go
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b898e...fce51b6. Read the comment docs.


Displaying section if array exists, without iterating each element of array.

Given JSON:
{
	"images": [{
			"src": "http://www.fpoimg.com/20x20"
		},
		{
			"src": "http://www.fpoimg.com/30x30"
		},
		{
			"src": "http://www.fpoimg.com/40x40"
		}
	],
	"anEmptyArray": []
}

and template:
{{#images.length}}

The images: this should only be rendered once.

        {{#images}}

        {{/images}}

{{/images.length}}
{{#anEmptyArray.length}}

The empty array: this should NOT be rendered.

{{/anEmptyArray.length}}

Some Mustache implementations (including the Demo here return:

The images: this should only be rendered once.

The {{#images.length}} tag does not appear to be part of the Mustache spec.  For that matter, neither does {{#images.0}} which could be used to refer to the first element of the array.

This would seem to be a useful function.
It is not part of the spec
The spec appears to be dead (no commits in 4 years, no meaningful issue closure in 4 years)
The ruby implementation appears to have had at least some activity within the last year, and the website within the last month.

It seems that we are in another "Markdown" scenario where the initial parent project is at least partially dead, whereas one or more child projects are still alive (including this one.)  Which is unfortunate.
I will probably end up implementing these features, as they seem useful to me, and do not seem to violate the logic-less philosophy as demonstrated by other core features.  But I don't have time at the moment, so this is a reminder to myself.

According to this page...
https://stackoverflow.com/questions/11147373/only-show-the-first-item-in-list-using-mustache/17950970
...Mustache.js was updated to allow {{a.0}}, while handlebars.js has been updated to allow {{a.[0]}. From my perspective, I think this is a very basic omission from vanilla Mustache, because there are innumerable cases where you would need this (e.g. to render a preamble to a list conditional on the list existing, etc).
The direct problem for me is that I'd really like to use Magnum to automate some build tasks, but its (entirely reasonable) lack of Lambdas means that I can only use vanilla Mustache. Hence I'd be happy to put some work in to fix this if you're OK with that?
From looking at the code, it looks as though the least intrusive change would be to h(ij)ack the find() function in src/magnum.c so that if the last dot-delimited section of the name is numeric (i.e. index) and the preceding part of the name refers to an array, it instead returns the object array[index]. Does that make sense to you?

As an aside, the Parson author already considered adding code to handle more general array[n] cases, but decided not to do this (because of a memory leak?):

https://github.com/kgabis/parson/issues/57
https://github.com/kgabis/parson/pull/54

@nickpelling  -- thanks for the comments.  And forgive the length of this -- it's partially me just thinking out loud, and partially recording my thoughts for future consideration when I decide I was wrong.  ;)
In the almost 2 years since I started magnum, I have been using it quite a bit as is (though have not needed to push many updates, there are one or two edge case bugs I need to track down related to comments, and I am currently working on creating fuzzers to stress test most of my software projects to identify more bugs).
In that time, I have come to appreciate the "stated design philosophy as I understand it" of Mustache (the syntax).  IF you consider Mustache as a tool to process a JSON object as it is given to you, then there are some clear limitations of the syntax that create troublesome situations (this being one of them.)
Alternatively, IF you consider the workflow to be:

Convert your source data into an appropriately designed JSON object
That is then processed via Mustache

Then some of their design decisions make more sense.
My most common use case over the last 2 years has been "templated programming" -- my unofficial term for trying to pull out repetitive parts of programming into templates, that are then used to build the desired source code via Magnum/JSON/template arrangements.  For example, I created templates that:

Allow me to describe (in JSON) a desired database setup, and then automatically create SQLite and C code to work with said database in a native way.
Use a JSON file to automatically generate Objective-C code to completely manage the preferences window/panes in macOS apps (currently used to develop http://nvultra.com/).

In doing this, I would run up against limits of Mustache only to realize that if I redesigned my JSON, there was no problem.  For example, I started out my database idea by using a dataType attribute that would consist of a variety of string values (char, int, date, etc.).  I quickly ran into trouble using this approach, but realized that if I instead used a variety of booleans, everything worked fine (isChar, isInt, isDate, etc.)
Similarly, a common situation in my uses is that I need to do something different on the last element of an array as compared to all the other elements (usually whether or not to append a comma).  To solve this, I have to remember to include a isLast flag on the last item, and remember to move that flag if I rearrange the order of the array elements.
In my mind, the ultimate question becomes, "How complicated do you make the Mustache syntax in order to accept generic JSON input, or how much care do you require users to take when designing their JSON so that it works properly with Mustache?"
Since I am not the maintainer of Mustache, I obviously don't have the answer.  My opinion is that there is benefit to a bare bones, but consistent, feature set for the Mustache syntax across all implementations.  Individual implementations will, of course, have some custom features as needed for their particular use cases, but hopefully the core syntax will work across them all.
For magnum, this means:

Trying to keep magnum consistent with the standard test suites for core functionality.

Minimizing the addition of custom functionality, except where it really feels like something is missing from Mustache (in my opinion), or where there is something that I really need (and I fully admit this is arbitrary.)

So far, the custom features that have come up for discussion in magnum are:

This feature of an "if-array exists, without iterating through it"  -- this would be convenient, but can be worked around with a boolean hasArray flag if needed.  I am still inclined to consider this feature, but it's a bit lower priority.

Automatic detection of "last item in an array" -- this would be handy to have, and while it can also be worked around, the workaround requires extra caution when editing the JSON, as you have to remember to ensure that each relevant array as a lastItem flag in one, and only one, item in the array.  I am inclined to add this feature, and consider it higher priority than the first one.

Potentially a array.length or array.item[n] syntax.  In my mind, these are getting towards the fringes of what I would consider adding.  I'm not arguing their utility, simply questioning whether it expands beyond the core scope of Mustache in a way where a different tool might be better.  I am currently inclined not to add these at the moment, as I worry about feature-creep here.

As above, I am still considering these, and do not have a final decision.  I also have a lot pressing tasks in my personal, professional, and software lives at the moment, so don't expect any changes soon.
ASIDE: At some point, tools like jq can process JSON that you have less control over to add the necessary flags to be compatible with Mustache.  So there are solutions to just about any problem one encounters.

For me, JSON is a great way of decoupling data from code, and Mustache is a great way of generating all manner of useful stuff from JSON.
But the minute you start having to add isFirst and/or isLast flags into the data, the tail is wagging the dog. If you're having to make implicit stuff explicit to get by, something has gone badly wrong.
Personally, I think that Mustache was right to aim to stay minimal: but even so, there is a very strong case for #IsFirst and #IsLast built-in wrappers. These aren't "logic", they are template sequencing helpers that you can use to do preambles and remove trailing commas {{^IfLast}},{{/IfLast}} etc.


Implement Leaderboard

Description
Implement the leaderboard and have traders listed in ranking based on Total Profit & Loss (PnL).
See issue #278 for the leaderboard design
Deliverables

[ ] Final PR to v2 branch
[ ] Connect the leaderboard to current subgraph: https://thegraph.com/hosted-service/subgraph/kmeraz/optimism-kovan-futures
[ ] Pull PnL using pnlWithFeesPaid from the subgraph
[ ] Fill out the leaderboard with any traders who have PnL
[ ] Display liquidations
[ ] Display total trades placed
[ ] Add timeframe buttons, as seen in the designs. (does not have to be functional yet)
[ ] Use addresses instead of twitter handles for the "Trader" column

Notes

Currently there should only be one user who has interacted with the futures contracts
Layout and background colors will be done in a future ticket
PnL by selected timeframe will be done in a future ticket (but bonus points for ideas for how to solve this)

Rewards
50 SNX

Assigned to @tburm

@platschi I submitted a PR here
There is one outstanding issue related to linting that I would like to get some feedback from a CC if possible.


Fix bug(#38077) that causes a stale SA token is being used in istio-cni

The BoundServiceAccountTokenVolume Kubernetes feature (graduated to stable in 1.22) improves security of service account tokens by requiring a one hour expiry time, over the previous default of no expiration. This means that install-cni should refetch service account tokens periodically.
This PR integrates periodic SA token checks into already existing sleepCheckInstall function and compatible with legacy token secret mounts.

/ok-to-test

@srggavrilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test release-notes_istio

unit-tests_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test release-notes_istio

unit-tests_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test unit-tests_istio

lint_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test release-notes_istio

unit-tests_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test unit-tests_istio

lint_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test lint_istio

integ-security-multicluster_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test unit-tests_istio

lint_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test lint_istio

integ-security-multicluster_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test integ-security-multicluster_istio

release-notes_istio
32e4658c81f58c1def7bb58c402d12f32c4ba442
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test lint_istio

integ-security-multicluster_istio
a1c8d4a70a6b81d8b7c862616779d334ee09d864
link
true
/test integ-security-multicluster_istio

release-notes_istio
32e4658c81f58c1def7bb58c402d12f32c4ba442
link
true
/test release-notes_istio

unit-tests_istio
32e4658c81f58c1def7bb58c402d12f32c4ba442
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/retest-required

@srggavrilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test unit-tests_istio

integ-distroless_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test unit-tests_istio

integ-distroless_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test integ-distroless_istio

integ-security-multicluster_istio
68d180973387c018514d74cc459743dda9a1c1dc
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@srggavrilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
eb185769c657b8021d60051cb7f3fb74796291cd
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The following code in https://github.com/istio/istio/pull/39801 seems to be rather tricky. If the ctx.Done() is not triggered, the goroutine created by each call of watchSAToken() will never return and cause memory leak.
func (in *Installer) watchSAToken(ctx context.Context, fileModified chan bool, errChan chan error) {
curToken := in.saToken
go func() {
for {
select {
case <-ctx.Done():
return
default:
token, err := readServiceAccountToken(in.saTokenFilepath)
if err != nil {
errChan <- err
}
if curToken != token {
fileModified <- true
}
time.Sleep(1 * time.Minute)
}
}
}()
}


Cannot deploy basic configuration

I'm probably missing something obvious here. Here is my swagger configuration:
---
swagger: "2.0"
info:
  title: ExchangeStats
paths:
  /test:
    get:
      x-amazon-apigateway-auth:
        type: none
      x-amazon-apigateway-integration:
        type: aws
        uri: arn:aws:apigateway:eu-west-1:lambda:path/2015-03-31/functions/arn:aws:lambda:eu-west-1:<account-id>:function:broadband-exchange-stats/invocations
        httpMethod: POST
        requestTemplates:
          application/json: "Empty"
        responses:
          "default":
            statusCode: "200"
      responses:
        200:
          description: "ok"

I can successfully create the API:
./aws-api-import.sh --create exchange-stats.yaml
2015-12-21 12:28:18,054 INFO - Using API Gateway endpoint https://apigateway.eu-west-1.amazonaws.com
2015-12-21 12:28:19,042 INFO - Attempting to create API from Swagger definition. Swagger file: exchange-stats.yaml
reading from exchange-stats.yaml
2015-12-21 12:28:19,112 INFO - Parsed Swagger with 1 paths
2015-12-21 12:28:19,112 INFO - Creating API with name ExchangeStats
2015-12-21 12:28:19,345 INFO - Removing default model Error
2015-12-21 12:28:19,388 INFO - Removing default model Empty
2015-12-21 12:28:19,467 INFO - Creating resource 'test' on ulmh3wp3cb
2015-12-21 12:28:19,655 INFO - Creating method response for api 3kyzu48l7j and method GET and status 200
2015-12-21 12:28:19,752 INFO - Creating integration with type AWS
2015-12-21 12:28:19,862 INFO - Creating method for api id 3kyzu48l7j and resource id 07w5kb with method get

But not deploy it:
./aws-api-import.sh --update 3kyzu48l7j --deploy prod exchange-stats.yaml
2015-12-21 12:28:28,541 INFO - Using API Gateway endpoint https://apigateway.eu-west-1.amazonaws.com
2015-12-21 12:28:29,413 INFO - Attempting to update API from Swagger definition. API identifier: 3kyzu48l7j Swagger file: exchange-stats.yaml
reading from exchange-stats.yaml
2015-12-21 12:28:29,483 INFO - Parsed Swagger with 1 paths
2015-12-21 12:28:29,678 INFO - Updating method for api id 3kyzu48l7j and resource 07w5kb and method get
2015-12-21 12:28:29,805 INFO - Creating method response for api 3kyzu48l7j and method GET and status 200
2015-12-21 12:28:29,936 INFO - Creating integration with type AWS
2015-12-21 12:28:30,057 INFO - Cleaning up removed methods
2015-12-21 12:28:30,132 INFO - Cleaning up removed resources
2015-12-21 12:28:30,172 ERROR - Error importing API definition
java.lang.NullPointerException
	at com.amazonaws.service.apigateway.importer.impl.sdk.ApiGatewaySdkSwaggerApiImporter.updateApi(ApiGatewaySdkSwaggerApiImporter.java:88)
	at com.amazonaws.service.apigateway.importer.impl.ApiGatewaySwaggerFileImporter.updateApi(ApiGatewaySwaggerFileImporter.java:58)
	at com.amazonaws.service.apigateway.importer.ApiImporterMain.importSwagger(ApiImporterMain.java:161)
	at com.amazonaws.service.apigateway.importer.ApiImporterMain.execute(ApiImporterMain.java:145)
	at com.amazonaws.service.apigateway.importer.ApiImporterMain.main(ApiImporterMain.java:83)

Possibly something to do with models that don't exist?

I added a definitions section and that seems to have fixed it.


Page load progress bar sometimes goes backwards

If you rapidly click between pages (open a new one before the progress indicator has completely faded out), you'll see the progress indicator start at the end and move backwards. I think it would probably make more sense to force the current bar to fade out immediately and start the animation from the beginning.

A known bug, but I wonder if you've happened to pick up on what behavior causes this? If not, no worries -- we'll get it figured out.

Gotcha - I didn't see another issue open for this so I decided to open this one.
As far as exactly what causes it, I'm not sure, I just know that it only happens if I click another link before the first progress bar has completely faded.


Fix Binary Conformance Test for Enum

https://github.com/protocolbuffers/protobuf/pull/6434

Need to get conformance tests running in the new repo.


retrieving credentials ( database passwords, account credentials etc.) from secret service.

Currently the database passwords and other sensitive information are saved in the configuration file or consul. With new secret service added into the edgex architecture, it is needed to keep these credentials in the secret service and retrieve them from there to enhance the security. This applies to all the core microservices that keep sensitive information in the configuration file/consul currently.

Is this part of the tasks for Edinburgh?

Yes it is. Brandon and I are working on it actively.

Related repos in holding area are

https://github.com/edgexfoundry-holding/edgex-mongo-init (current work on PR 1)
https://github.com/edgexfoundry-holding/go-mod-core-security

We need a coherent plan for how this is going to work. This was discussed during the Core WG call 18-Jul-2019. Planning to revisit this coming week.

A PoC for how this was going to work was started in https://github.com/edgexfoundry/edgex-go/tree/secrets, but I'm not sure if that's the direction we still want to go in.

Depends upon completion of #1825 and #1876.


Wrapping timeseries chart

A Redditor posted a seemingly simple chart design, asking how to produce the design:

Initial responses about how to produce the chart were in three main flavors:

gantt
stacked bar
calendar heatmap

In practice, each of the above chart types present unique challenges for, and may be incapable of rendering, the desired output.
The data structure might be, in effect, an array of two-tuples where each tuple contains a start and end Datetime.
What are some ideas on how this chart could be created with Holoviews?

OK, thanks for your reply.
Yeah, breaking the time along a hinge, or wrapping it across the x-axis does seem difficult.


small issues on first run without parameters

when u first run aws2tf.sh without any parameters , it will take some time.
the second thing is that it will say region not found and then fail on account not found. to me, logic would say the account is more important than region and should be the first check

will be addressed by the forthcoming python version

committed change to check account first

Closing as python version now released


on running the command "dotnet new webapi -o myMicroservice --no-https " the generated code does not have any file called "WeatherForecastController.cs".

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/microservice-tutorial/create
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Yes. I experienced the same. I see the controller named ValuesController got created and proceeded with that and worked

That is not expected. Can you confirm what version of the .NET Core SDK you're running? You can type dotnet --info to see that.
Thanks!

Closing due to the lack of response.


No autocomplete for Model::create([])

When using Model::create([/*attributes*/]) there is no autocomplete for the attributes. Is this behaviour desired? How can I achieve autocomplete for the attributes there?

Hi @Wulfheart
Model::create([/*attributes*/]) Unfortunately is not yet supported!
Just added it to the list! Will close the issue when it is added!

@simoebenhida I could try to implement it. Are there any major technical limitations which prevented you from implementing it?

@Wulfheart Yeah it is a different feature! But it is doable! Just started working on it this weekend


Remove dependency on WSL?

Infer looks really nice, however it does not appear to be something we can add into our standard pipelines amongst the team as it has pretty heavily dependencies on things like WSL. Ideally this can be added to a C# project and run on any machine without external dependencies.

Yes -- this is one of our currently most-requested items right now. We are looking into this in partnership with the Infer team at Meta!


Is there a way to reloading ReCapatcha? or setting custom URL for the js file?

Hello, Sometimes Recaptcha js file fails to load due to some network issues or government restrictions over google APIs anyway, Calling load again does not help the promise never call then, so we need to reset the package state on error so we can call load again and again to ensure that the Recaptcha js file has been loaded
Edit: If we can also create a new option to pass the URL of the Recaptcha js file in case we want to change to a new one

Hey,
thanks for your contribution!  I've published v1.7.0 which contains your commits.


Access Denied on MobileNet downloading

Trying to run /tensorflow/examples/image_retraining/retrain.py, getting the following error:
  File "/home/burjanviktor/DeepLearning/dog_breed/retraining.py", line 1032, in main
    maybe_download_and_extract(model_info['data_url'])
  File "/home/burjanviktor/DeepLearning/dog_breed/retraining.py", line 344, in maybe_download_and_extract
    filepath, _ = urllib.request.urlretrieve(data_url, filepath, _progress)
...
  File "/home/burjanviktor/anaconda3/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

I am trying to use MobileNet for retraining, but the following url:
'http://download.tensorflow.org/models/mobilenet_v1_1.0_160_quantized_frozen.tgz'
gives the following error:
<Error>
AccessDenied
<Message>Access denied.</Message>
Anonymous users does not have storage.objects.get access to download.tensorflow.org/models/mobilenet_v1_1.0_160_quantized_frozen.tgz.
</Error>

The 1.0_220 version works, but 1.0_190 does not work also.
Could you advise on this issue please?

It looks like the only quantized model we have available is this one:
http://download.tensorflow.org/models/mobilenet_v1_1.0_224_quantized_frozen.tgz
Non-quantized models are available for all other sizes (as described in retrain.py).  E.g. the non-quantized version of 1.0_160 is available:
http://download.tensorflow.org/models/mobilenet_v1_1.0_160_frozen.tgz
This corresponds to the following argument to retrain.py:
--architecture mobilenet_1.0_160

@suharshs might have more details on whether we plan to make more quantized models available.

Thanks Todd. We currently only have size 224 image mobilenet quantized model available. We haven't yet prioritized getting trained quantized models for the other inputs sizes. I'll rename this issue as a feature request to help us prioritized training the other models, thanks!

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

We should have updated models available next week.
Thanks!

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I have pushed changes to the retrain.py script to support these, once the next sync happens.
Commands like
python tensorflow/examples/image_retraining/retrain.py \
    --image_dir ~/flower_photos/   --architecture mobilenet_1.0_224_quant

should work for all depth multipliers and image sizes.
Please create a new issue if things don't work once github pulls in the changes to retrain.py

Is this correct way to re-train quantized mobilenet? I mean use re-train.py?

Yes.  Retrain.py architecture switch supports the quant models, as it is described above.  Just make sure you are using a somewhat recent version of TensorFlow with a recent version of the retrain.py script.


Something wrong with the README.md

echo "source ~/catkin_ws/**devel**/setup.bash" >> ~/.bashrc may be wrong.
I think there should be the install folder other than the devel floder

[Please Ignore - RealSense system comment]


Triggers for o6s

Added some basic triggers for o6s's DPS mechanics.

Everything should be fixed!

Thanks for these! :D


Fix feature-request action

They added these new required parameters here https://github.com/microsoft/vscode-github-triage-actions/pull/271/files#

Welp, I got a new error

I'm gonna wait for it to run tonight, otherwise I'm going to have to go to the VS Code team and file an issue because from looking at their code I think it's broken.


Unable to replicate barcode scanner demo app impressive performance with Xamarin

Hi
Thanks for the great Nuget package!
I have implemented an Android fragment which is opening the scanner. However, my app is struggling to decode what is an admittedly large qr code. The thing is that both of your demo apps on the google play store dont struggle at all - they decode the qr code almost instantly.
Do you think you could help by listing the settings for the app? Particularly the ZXing Test app, the Scan QR code option is extremely fast. For the Barcode Scanner app, the best settings are:  Decode QR Codes and Data Matrix and Use auto focus. I see that the MobileBarcodeScanningOptions object has options which cannot be ticked in the settings section of the app. Is it possible that one of those options is what is improving performance? Maybe DelayBetweenContinuousScans or something? Alternatively, could the custom overlay on the scanning view be helping decode the qr code?
My code:
_scanner = new MobileBarcodeScanner();

            try
            {
                var options = new MobileBarcodeScanningOptions
                {
                    PossibleFormats = new System.Collections.Generic.List<ZXing.BarcodeFormat>
                              {
                                 ZXing.BarcodeFormat.QR_CODE, ZXing.BarcodeFormat.DATA_MATRIX
                              },
                    TryHarder = false,
                    AutoRotate = false,
                    DisableAutofocus = false

                };
                _result = await _scanner.Scan(options)
                    .ConfigureAwait(false);
            }
            catch (Exception e)
            {
                Mvx.Error($"Unable to scan :: {e.Message}");
                return string.Empty;
            }
            return _result?.Text ?? string.Empty;

The apps you linked to on Google Play are not using this library. They are using the original ZXing library written in Java. ZXing.Net.Mobile is using a port of ZXing written in C# (ZXing.Net).

Thanks for the input Taylor.
Would you be able to help me in translating the settings from those apps
into the .net port?
If I want to scan qr codes exclusively, as quickly as possible, which
settings should I use in the .net port? The qr codes contain strings as a
payload and are fairly large.
Regards,
Nathan Stasin
On 13 March 2018 at 21:44, Taylor Buchanan<EMAIL_ADDRESS>wrote:

The apps you linked to on Google Play are not using this library. They are
using the original ZXing library https://github.com/zxing/zxing written
in Java. ZXing.Net.Mobile is using a port of ZXing written in C# (
ZXing.Net https://github.com/Redth/ZXing.Net).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Redth/ZXing.Net.Mobile/issues/689#issuecomment-372793906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATlKU2-nSIVVTsGydUBrvXof2wH5z_bgks5teCGBgaJpZM4Slbmg
.

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!


Include 'when' parameter on sub-collection select

Fixes bug where "Select a Collection" Parent Collection dropdown on Collection page was not working due to missing parameter (#343)
This can be a hotfix if others agree.

can you update changelog and I can add it to 1.20.1