Image capture quality

Hi,
I'm trying to use your API to take a photo of an A4 sheet. I'm facing with that the quality of the captured image is very poor and the chars in the A4 are not fully visible.
In other words, in this case I want to use a webcam as a scanner.
Do you have any hint about this issue? Any idea of how to improve the cam quality? I've tried with two webcams (http://www.geniusnet.com/Genius/wSite/ct?xItem=55882&ctNode=1304 Genius 1000x 720) and http://www.geniusnet.com/Genius/wSite/ct?xItem=55315&ctNode=1304&mp=3 Genius 321 VGA).
Thanks. Regards,
Pablo.

Hi @gusgle,
Please make sure to use the max possible resolution that your camera supports. The resolution can be set by calling:
Dimension resolution = new Dimension(1280, 720); // HD 720p
Webcam webcam = Webcam.getDefault();
webcam.setCustomViewSizes(new Dimension[] { resolution }); // register custom resolution
webcam.setViewSize(resolution); // set it
webcam.open();
// to the job ...
webcam.close();

Here is some more sophisticated example:
https://github.com/sarxos/webcam-capture/blob/master/webcam-capture/src/example/java/CustomResolutionExample.java
The other factor is a good light source. With poor light the image is not very good.

One of your cameras (Genius 321 VGA) has 8 MP matrix and therefore it should be able to fetch 3264x2448 image, but please note that the max resolution supported by the API is limited by the USB 2.0 controller capacity which is circa 60 MB/s, and therefore, depending on frame rate (lets calculate for 5 FPS) this gives:
3264 * 2448 * 3 bytes * 5 fps = 119854080 B/s = 115 MB/s

Which is, unfortunately, way too much for USB 2.0 which is supported by Webcam Capture API, thus discarding this resolution from the supported ones.
Also, most of these fancy cameras with UHD resolutions comes with the dedicated software that integrates with Windows and works on top of the h.264 that is natively supported by webcam, but Java API is not able to use it (usually RGB24 format is used, or YUV, no h.264 support).


Add runGuess method to embulk-test

Implement runGuess method, which is test framework for checking the behavior of guess plugin.
follow up of https://github.com/embulk/embulk/pull/503

Implementing this on https://github.com/embulk/embulk/pull/526


Fix the undefined behaviour caused by left shifting of negative values.

Properly handle encoding of the signed values. According to the algorithm (step 3, https://developers.google.com/maps/documentation/utilities/polylinealgorithm) negative values must be calculated using their two's complement.
fixed #15

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9bed987) 95.06% compared to head (4533f9c) 94.04%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   95.06%   94.04%   -1.02%
==========================================
  Files           1        1
  Lines          81       84       +3
  Branches       10       11       +1
==========================================
+ Hits           77       79       +2
- Partials        4        5       +1

Files
Coverage Δ

src/polylineencoder.h
94.04% <80.00%> (-1.02%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Animation point of origin

I'm attempting to use slideInRight for a search bar on the right side of the page. The plan is to have the text-input field slide out from the search button upon hover.
Is it possible to anchor the animation to start from the search button rather than the right edge of the screen?

https://github.com/daneden/animate.css/issues/415

Thanks, didn't see that one.


OPA gatekeeper - gatekeeper-update-namespace-label fails to pull image from private registry

Rancher Server Setup

Rancher version: v2.6.0-rc1
Installation option: Single Airgap

Airgap, Downstream cluster is RKE1

Proxy/Cert Details: rancher generated certs

Information about the Cluster

Kubernetes version: 1.21.3
Cluster Type:

If downstream, what type of cluster?: Custom RKE1 Airgap

Describe the bug
ImagePullBackOff: Back-off pulling image "rancher/kubectl:v1.20.2"
To Reproduce

Setup an Airgap Rancher with Private Registry (basic auth)
On an airgapped downstream cluster install OPA Gatekeeper from Dashboard

Result
gatekeeper-update-namespace-label fails to initialize the images.
Expected Result
Monitoring v2 installed
Screenshots
Additional context
rancher-images.txt includes rancher/kubectl:v1.20.2
The tagged image exist in the registry and is prefixed/tagged with the private registry host:
{"name":"rancher/kubectl","tags":["v1.20.2","v1.18.0"]}

Fix here is same as https://github.com/rancher/rancher/issues/33995
So only PR will be there, then this can go into test.

This issue is caused by the missing {{ template "system_default_registry" . }} in the following line
https://github.com/rancher/charts/blob/4ad408e0ca6f8c903c18553c32aa6540cf3b0b61/charts/rancher-gatekeeper/rancher-gatekeeper/100.0.0%2Bup3.5.1/templates/namespace-post-install.yaml#L33

Available to test with v2.6.0-rc2

Rancher version: 2.6.0-rc2
Repo info:
spec:
  gitBranch: dev-v2.6
  gitRepo: https://git.rancher.io/charts
status:
  branch: dev-v2.6
  commit: abcc294eed065e8dec10a1757ed9dd5f808d15f4

The chart is now working on an Airgap HA setup with private registry.


Add datasets

Related issue #4

Gitlab failed due to not found zip files. However, this doesn't happened in Travis CI.


using custom session and registration controller with extensions

Hi!
I wonder if there are any additional changes required to make custom controllers work with extensions like persistent session plug.

However, to make it easier to integrate extension, you can add callbacks to the controllers that do some light pre/post-processing of the request:

From https://github.com/danschultzer/pow#phoenix-controllers, seems to imply that using custom controllers breaks Pow.Extension.Phoenix.ControllerCallbacks, that is, there are no traces of any function in Pow.Extension.Phoenix.ControllerCallbacks being called during login/logout when using custom controllers.

Yeah, and this is for a good reason. Controller callbacks is mostly a compromise for make Pow plug n’ play, but ideally developers take control of everything they change rather than having implicit callbacks. I have written about it in the custom controller guide, and I’m also thinking of redoing how the callbacks work in #66.
I would recommend writing the controllers  as explicit as possible. However, you can build a controller that uses the Pow.Phoenix.Controller macro, and will use the controller callbacks from the config. Take a look at the registration controller to get an idea of how it works:
https://github.com/danschultzer/pow/blob/master/lib/pow/phoenix/controllers/registration_controller.ex
Controllers are very thin in Pow with a process and response separation that makes it possible to hook in callbacks.

@danschultzer so how would one go about making a custom controller work with persisted sessions plug?

@danschultzer thank you! It seems to have worked.

I would appreciate fuller documentation regarding how to integrate PowPersistentSession with custom controllers. For instance, how do you properly RequireAuthenticated in the router? As a test, I set persistent_session_ttl to just 30 seconds, but after the ttl I see that my user is still able to access protected routes, when I expected that their session would have been purged from the store and the cookie invalidated by that time.

You have to use plug PowPersistentSession.Plug.Cookie as described in https://hexdocs.pm/pow/1.0.19/pow_persistent_session.html#content
It's not a replacement for the session. It's there to ensure that the session can be recreated once it has expired. PowPersistentSession sets a cookie that can be used once to create a new session for the user. In your case the normal session works as expected. Let me know if this could be better described in the docs!

Oh, I see! So setting a ttl for the persistent session lower than the regular session will not result in sessions being invalidated after the persistent ttl. In that case the regular session TTLs will dictate when the session expires. But when the persistent session is in place with a longer ttl than the regular sessions, it will allow sessions that have expired to be renewed.
In that case, the only changes I need to make are to plug in the cookie, and to call PowPersistentSession.create/3 in my custom controller actions, and otherwise the use of pow remains the same. Is that right?

But when the persistent session is in place with a longer ttl than the regular sessions, it will allow sessions that have expired to be renewed.
In that case, the only changes I need to make are to plug in the cookie, and to call PowPersistentSession.create/3 in my custom controller actions, and otherwise the use of pow remains the same. Is that right?

Yeah, you are correct. You need to call PowPersistentSession.Plug.create/2 when you create the session with Pow.Plug.create/2.

Thanks Dan. I think I have things working now. Here is how I finally ended up in my controller actions:
  def signup(conn, %{"user" => user_params}) do
    conn
    |> Pow.Plug.create_user(user_params)
    |> case do
      {:ok, user, conn} ->
        conn
        |> PowPersistentSession.Plug.create(user)
        |> redirect(to: Routes.page_path(conn, :show))

      {:error, changeset, conn} ->
        render(conn, "index.html", changeset: changeset)
    end
  end

  def login(conn, %{"user" => user_params}) do
    conn
    |> Pow.Plug.authenticate_user(user_params)
    |> case do
      {:ok, conn} ->
        conn
        |> PowPersistentSession.Plug.create(conn.assigns.current_user)
        |> redirect(to: Routes.page_path(conn, :show))

      {:error, conn} ->
        changeset = Pow.Plug.change_user(conn, conn.params["user"])

        conn
        |> put_flash(:info, "Invalid email or password")
        |> render("index.html", changeset: changeset)
    end
  end

Thanks @vaer-k for your code :+1:
This is definitely related to #516 which I just opened this morning.


Set ChainID in ABCI Header

Resolves #184.

Codecov Report

Merging #185 (bfcf2f9) into main (08d9cd2) will decrease coverage by 1.00%.
The diff coverage is 33.71%.

:exclamation: Current head bfcf2f9 differs from pull request most recent head 7704bf4. Consider uploading reports for the commit 7704bf4 to get more accurate results

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   54.62%   53.61%   -1.01%
==========================================
  Files          32       35       +3
  Lines        4978     5234     +256
==========================================
+ Hits         2719     2806      +87
- Misses       1849     2011     +162
- Partials      410      417       +7

Impacted Files
Coverage Δ

config/config.go
84.21% <ø> (ø)

conv/config.go
47.05% <0.00%> (-52.95%)
:arrow_down:

node/mempool.go
50.00% <ø> (ø)

node/node.go
63.75% <0.00%> (-0.87%)
:arrow_down:

p2p/client.go
62.94% <0.00%> (-8.33%)
:arrow_down:

rpc/client/client.go
23.05% <21.55%> (ø)

rpc/json/types.go
37.14% <37.14%> (ø)

rpc/json/service.go
44.85% <44.85%> (ø)

rpc/json/handler.go
50.00% <50.00%> (ø)

block/manager.go
62.10% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d9cd2...7704bf4. Read the comment docs.

Rebased on main.


Improve description of the pi constant

This PR proposes a small tweak to the documentation associated with the pi constant in the FloatingPoint module.
Suggested here: https://github.com/apple/swift-numerics/issues/89#issuecomment-1054425264

"The ratio of ... " should not be the top-level summary. E.g. consider the Wikipedia article, which begins with "the number π is a mathematical constant." The first thing to clarify is that we are talking about the mathematical constant, rather than nucleotide diversity or osmotic pressure or the product of a sequence.
I think that it's fine to mention some of the places that π arises in the description; restoring the old summary with an "approximately equal to 3.14159" or similar would be appropriate. Additional discussion can go in the description, which should also include a link to the wikipedia page (https://en.wikipedia.org/wiki/Pi).

Quick question, would using unicode be acceptable, or is there guidance to stick with ASCII characters? Because, if allowable, I think this would be a great opener: "The mathematical constant π, approximately equal to 3.14159" - this would make it more accessible to non-native speakers of English, who might never have seen the spelled out version of the symbol (anecdotally, I myself learned about the constant long before I learned how it was spelled and pronounced in English).

It's completely ok to use π.

Thanks everyone. 🙌


Problem with Installing Requirements on Windows 10

I'm on Windows 10.
When I follow the steps to install the requirements, I am stuck at the step
source bin/activate
I assume this is meant to be the command on a Linux system.
Is there a way to install the requirements on a Windows 10 computer?

You have to do cd scripts and then activate.

@photastic as you are on Windows, please note that the activation binary is under a different directory: Scripts\activate.bat as noted in the documentation, the invocation of the script is platform-specific.
Here is an How-To for Windows.

yes, a windows-specific readme would be nice!


How to pass dependency into sub-services ?

I have learned how to declare sub services in this issue: #14
But I want to pass a dependency into the sub-service, for example:
define([], function (**DEPENDENCY_HERE**) {
    return function () {
        return {
            /**
             * @return {Object}
             */
            get: function () {
                return //code
            },
            /**
             * @param {Object} task
             */
            put: function (task) {
                //code
            }
        }
    }

});

How can I do such kind of thing ?
Many thanks in advance !

i have the same issue too
any solution?


Not Working with pagination

If on finish we are updating the mock data and update dynamicData using useEffect inside hook, then dynamicData is updated but getting error of removeChild.

Hello @amitrajoria15
Did you found a solution for that ?
Thx.


CGP 102: Add RedStone as an oracle provider for Mento

This proposal is to enable RedStone as one of the oracle providers for Mento. RedStone would deliver price data for CELO/USD, CELO/EUR, CELO/BRL, USDC/USD, USDC/EUR, USDC/BRL, EUROC/EUR.

Hello @mattgurbiel as I mentioned to @jakub-wojciechowski in the Isuue before you are able to present the proposal in Governance Call and submit this PR you need to do a Forum Post and let people engage in the conversation around.
Did you already did that? If not you can make one here
You can read more about Celo Governance Process Here

Hey @juanjgiraldoc
just added the forum post: https://forum.celo.org/t/cgp-102-add-redstone-as-an-oracle-provider-for-mento/6627/1 (might still be waiting for admin verification)


fix: set default user and group

handles undefined to equate to current user

1st apply
terraform apply --auto-approve
random_string.suffix: Refreshing state... [id=mutpwo3b]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.name.utilities_local_directory.destination will be created
  + resource "utilities_local_directory" "destination" {
      + force       = true
      + group       = "root"
      + id          = (known after apply)
      + managed     = (known after apply)
      + path        = "/tmp/mutpwo3b"
      + permissions = "0755"
      + user        = "root"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.name.utilities_local_directory.destination: Creating...
╷
│ Error: Error Setting Owner
│
│   with module.name.utilities_local_directory.destination,
│   on ../../main.tf line 21, in resource "utilities_local_directory" "destination":
│   21: resource "utilities_local_directory" "destination" {
│
│ Failed to set directory owner: chown /tmp/mutpwo3b: operation not permitted

2nd apply
terraform apply --auto-approve
random_string.suffix: Refreshing state... [id=mutpwo3b]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.name.utilities_local_directory.destination will be created
  + resource "utilities_local_directory" "destination" {
      + force       = true
      + group       = "root"
      + id          = (known after apply)
      + managed     = (known after apply)
      + path        = "/tmp/mutpwo3b"
      + permissions = "0755"
      + user        = "root"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
module.name.utilities_local_directory.destination: Creating...
module.name.utilities_local_directory.destination: Creation complete after 0s [id=/tmp/mutpwo3b]

terraform plan. this becomes an infinite loop
terraform plan
random_string.suffix: Refreshing state... [id=mutpwo3b]
module.name.utilities_local_directory.destination: Refreshing state... [id=/tmp/mutpwo3b]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.name.utilities_local_directory.destination will be updated in-place
  ~ resource "utilities_local_directory" "destination" {
      ~ group       = "johna" -> "root"
        id          = "/tmp/mutpwo3b"
      ~ user        = "johna" -> "root"
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

workaround is to set
resource "utilities_local_directory" "destination" {
  force = true
  path  = var.destination_path
  user  = "johna"
  group = "johna"
}


Sometimes not adding  and  on a modal

Any ideas on why this happens?

Without seeing the whole implementation it's going to be hard to work that one out.

It is using vex modal to pop up, do i need to re call the setup onclick into a modal? Its seems sometimes it doesn't fully load those elements to the dom.

You'd want to call setup once all the markup you want to call the plugin on, is rendered to the page, yeah.  In this case probably a shown type callback.


Is there a way to add a valid TLS cert to the server?

Hey,
Thanks for this. Is there any way to add a valid TLS cert, Letsencrypt, etc., to the server?
Thank you!

Hi @Hax0rG1rl
Yes sure, take a look into the nginx folder, there you can find the webserver configuration file and the default certificates, change the location or replace them with your own certificates.
https://github.com/1modm/petereport/tree/main/nginx
petereport.conf:
`
ssl_certificate /opt/petereport/nginx/petereport.crt;
ssl_certificate_key /opt/petereport/nginx/petereport.key;
`


pull request for e2e test at 02/06/2017 23:26:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Suggestion] Make it so you can turn off or change the @here when a thread is created.

That is possible, via adding mentionRole = Role in your config.ini

Possible in config, this issue can be closed.

In addition to what Eight8 said, setting mentionRole = none will disable the ping.


fixed output of disk bar when gigabytes are used of a terabyte disk

apparently bar doesn't like it when the first variable is bigger than the second, it went really haywyre.
to see old behaviour, set disk_used to 63 and disk_total to 3.1 (that's what my disk usage and disk total is, in gigabytes and terabytes respectively)

Thanks!


sequenceT with NonEmptyArray

Is there any interest / it would be nice to have a sequenceT overload that accepts NonEmptyArray instead of a list of params. Consider the use case
type MissingParameterException = {name:string, message?:string }

const applicativeValidation = E.getValidation(NEA.getSemigroup<MissingParameterException>())

const getUrlParam = (URL:string) => (param:string) =>
    E.Either<'MissingParameterException',string>

const getUrlParams = (URL: string) => (...params:string[]) =>
    pipe(
        sequenceT(applicativeValidation)(**...params.map(getUrlParam(URL))**),
        E.map(someConcatOfResults)
    )

Right now, that doesn't work because TypeScript does not seem to infer that ...params:string[] means params will be a non-empty array of strings. So sequenceT complains that ...params.map(...) is missing {readonly 0: E.Either....}.
With this new feature, then you could:
const folder = O.fold(()=>E.left({name:'NoParamsException"}), as=>E.right(as))

and then proceed from there, passing it into sequenceT(applicativeValidation)(folder(NEA.fromArray(params)))
I didn't see functionality that replicates this need to spread an indefinite number of function arguments, map them into monads M, and then combine them with sequenceT(M). I've admittedly only been with fp-ts for a week.

The idea here is that the result of url.parse(someUrl).params using Node's built-in url parser returns {[index:string]:any|undefined} and I want to create a function that replicates this but takes arguments of which parameters you're fetching, and then it returns Either<MissingParamException[], ObjectWithThoseRequestedFields>

sequenceT is meant to be used with Tuples, if you have to traverse an array you have to use sequence from the Array module:
import * as A from 'fp-ts/lib/Array'
import * as E from 'fp-ts/lib/Either'
import * as NEA from 'fp-ts/lib/NonEmptyArray'
import { identity } from 'fp-ts/lib/function'
import { pipe } from 'fp-ts/lib/pipeable'

interface MissingParameterException{
  name: string;
  message?: string;
}

const applicativeValidation = E.getValidation(
  NEA.getSemigroup<MissingParameterException>()
)

declare function getUrlParam(
  URL: string
): (param: string) => E.Either<MissingParameterException, string>

const lift = <L, A>(check: (a: A) => E.Either<L, A>) => (
  a: A
): E.Either<NEA.NonEmptyArray<L>, A> =>
  pipe(check(a), E.mapLeft(NEA.nonEmptyArray.of))

const getUrlParams = (URL: string) => (params: string[]) =>
  pipe(
    A.array.sequence(applicativeValidation)(params.map(lift(getUrlParam(URL)))),
    E.map(...)
  )

I'm not sure this is the end result you want (in your example someConcatOfResults is missing and getUrlParams is missing the return type), but I hope it answers your question.
If you need further clarification about sequenceT and array.sequence, just ask.

Thanks. I didn't realize JS/TS distinguished between tuples and arrays. I'll learn this today and get back to you. I thought sequence vs sequenceT was just a difference between "crappy sequencer" and "powerful sequencer" since I know sequence's params must all be of the same typeclass.

The runtime representation of a tuple is an array anyway, JavaScript can't distinguish them (yet). TypeScript is able to represent tuples.
type MyTuple = [string, number]
type MyArray = boolean[]

So, an example with sequence VS sequenceT:
declare const k: Option<string>
declare const v: Option<number>
const a: Option<[string, number]> = sequenceT(option)(k, v)

declare const bs: Array<Option<boolean>>
const b: Option<Array<boolean>> = array.sequence(option)(bs)

@DenisFrezzato  I have "fp-ts": "^2.5.3" but
import * as A from 'fp-ts/lib/Array'
A.array // fp-ts/lib/Array has no exported member 'array'

I'm going to close this since it's been resolved.


upgrade to<EMAIL_ADDRESS>

I'd PR a change for this, but I'm not sure how to test.
Despite that it jumps a major, I suspect that it does not introduce a compatibility problem for appmetrics (and anyhow, the use of graceful-fs@3 that node-gyp@2 pulls in is going to break real soon know in node).
The change that caused the node-gyp major to bump is https://github.com/nodejs/node-gyp/pull/708, FYI, which is why I don't think its going to be a problem.

Actually, there is no need for appmetrics to depend on node-gyp, its builtin to node. I suggest deleting both these lines:

https://github.com/RuntimeTools/appmetrics/blob/master/package.json#L23
https://github.com/RuntimeTools/appmetrics/blob/master/package.json#L18

I think we've got a separate PR for removing the node-gyp dependency so I'm going to close this now

separate PR for removing the node-gyp dependency   https://github.com/RuntimeTools/appmetrics/pull/288


Update RFC 195 to account for RFC 246.

Edit: While the goal of this RFC is the same, namely to provide further interpretation of the design of associated constants, the current proposal differs radically from the original PR. This PR now clarifies that associated statics are not added, only constants, and mentions some limitations on associated constants that require more design work to deal with.
Rendered.
Original text of this post follows
Currently, the associated items RFC only provides for associated functions, lifetimes, statics, and types. However, it was never updated to account for the const/static split. This PR makes minimal changes to address this by adding associated consts as well.
The original motivating example for statics really applies to consts now, and I have updated it accordingly. I have not added a motivating example for statics; I'm sure that there is a use case, but I have not come up with one that could be easily explained.
I have also not bothered to update the examples to account for other RFCs (e.g. uint is now usize, [T, ..N] is now [T; N]). Maybe that would be worth doing for major RFCs that are going to be used as references into the future, but for now I left the RFC as it was historically accepted, since those other cases are not likely to cause confusion about what was intended.

Do associated statics exist? That might encourage writing associated functions that mutate the associated static. And IMO, any sort of "singleton pattern" like that is evil and should not be encouraged in the slightest.

Maybe add a historical note to the RFC, which would help avoid confusion.

@Ericson2314 Right now, neither associated statics nor consts are allowed because the RFC has not been fully implemented. I don't have a strong opinion about whether associated statics should be allowed or not, since I have trouble thinking of any really concrete situation where they would even be useful. I'd really just like the RFC to be clear on this point either way.
@tshepang I've added a brief note in the summary.

@quantheory totally with you on the "being clear either way" part

Thank you very much for pointing out this omission!
It is true that RFC 195 was written in a context where we only had static, and this does need to be clarified before we actually implement associated value items (as opposed to the current fn and type items).
So, once we get around to implementing associated constants, then we will need to address this in some way.
However, associated constants are not part of the plan for the 1.0 schedule.  Therefore, we are going to mark this particular PR as postponed; see newly filed issue #932.
Again: we definitely want to address this, and I hope that the work you have provided here gets us most or all of the way there.  But we want to wait until after 1.0 ships to deal with it.

@pnkfelix OK. To clarify, I am working on implementing associated constants, which is one reason that I wanted to clarify. But the basic idea seems sufficiently obvious that I don't think I need clarification on this particular point. I think that most people have assumed that associated const would happen, and the outstanding question is whether or not static would happen too.

@quantheory Well, this is unfortunate to find out about so late... I also am working on associated constants, and have spent a lot of time already refactoring the compiler so associated constants can be added sanely - see rust-lang/rust#23265 - but I was delayed by a week of exams.
How far along is your implementation (if you don't mind me asking)?
Have you made typeck::check::method handle associated constants or did you pick another route?
Also, do you have anything in mind for const_eval?
I'd like to help with rebasing on top of rust-lang/rust#23265, if you already have a lot of changes (it's a lot of grunt work and I have to make up for the breakage).
@pnkfelix There was a misunderstanding, associated constants are needed for patching up post-UFCS holes in 1.0.
I've been talking to both @alexcrichton and @aturon about this, and they both agree on my plan to solve the arising conflicts, but neither of them seemed to be aware of this RFC (I also wanted to clarify the need for s/static/const/).
@japaric has been working on something similar (marking impls of primitives as lang items), which will also need associated constants for integers and floats.

@eddyb
I should preface this by saying that I had no idea what I was doing when starting out. I was doing this in part to learn how rustc is put together, so quite a lot of my changes involve copy/pasted code that would need to be cleaned up anyway. I will try to take a look at your changes tomorrow and push my latest onto Github so that you can see it. I'm not sure how difficult a rebase will be; it's probably simple but tedious.
I have some basic things working already; the big thing I'm missing is cross-crate usage. I feel like I'm close there, but I'm not sure, since a lot of metadata is still a bit mysterious to me.
Specifically, I've got these working so far:

<T as Trait>::N
<T>::N (using a modified check::method, as you say)
Defaults
Constants in inherent impls

Note that the last two are not actually complete for associated types yet, but they are in the RFC.
For const_eval, a lot of the changes were straightforward. I just modified some of the match expressions to handle DefIds for associated constants. IIRC, the one big change is that middle::traits::select is used to resolve trait-associated constants to the appropriate impl value (or the default value).
Constants don't play very nicely with type parameters. I've got it working so that you can have a trait-associated constant of a type that contains type parameters, if there is no default value. That's the minimum necessary for Int and Float, since their associated constants will be declared with type Self. Other than that case, associated constants can't have generic types yet.
Note also that some potential uses of associated constants in generic code will be impossible without moving monomorphization from trans to typeck, e.g.:
unsafe fn interpret_as_bytes<T>(x: T) -> [u8; <T as Sized>::sizeof] { /*... */ }
fn foo<T: Int>(x: T) {
    match x {
        <T>::ZERO => { /* ... */}
       _ => {}
    }
}

Well, you seem to be ahead of me - I got stuck on metadata and realized it would be very hard to get anything done with the AST in that sad state.
My intention was to produce a DRY implementation, unifying methods and associated constants - potentially even associated types (those already forming some dead weight, making development of new features harder).
The examples you give are not impossible, merely hard. This one, however, should not compile:
fn foo<T: Int>(x: T) {
    match x {
        <T>::ZERO => { /* ... */ }
        <T>::ONE => { /* ... */ }
       _ => {}
    }
}

That is because match checking can't know those values, so it has to assume they could be equal unless we had a feature where Int would require that Self::ZERO != Self::ONE, but that's a bit into the future.

@eddyb
You can see what I have so far on my associated const branch. Note that there are quite a few things that I want to change. E.g. one of the first things I did was add an ast struct called StaticDef, which really should have been called something like TypedConstExpr and which should probably be taken back out because it doesn't really help anything anyway. Also the commit history is kind of messy.
I think that what I'd like to do is to clean my branch up, and try the rebase myself in the next couple of days. That said, I could use your help with a few things after that.
My point with the earlier examples was that they were impossible without doing certain things earlier than trans. You can make some pretty complex examples involving generic code. I don't think that arrays can be properly type-checked if a constant can depend on an arbitrary constant expression involving a type parameter, unless monomorphization (or part of it) is done during type checking.

@quantheory you cannot use function monomorphization during type-checking, that violates Rust's functional isolation paradigm.
However, the only thing you need to do is substitute type parameters in expressions, whereas right now they're only substituted in types.
There's a pretty straight-forward way to store the "value" of an expression which cannot be fully evaluated yet, due to the presence of generic type parameters: a "projection" (that's what @nikomatsakis calls it, anyways).
We already use it for associated types, where ty_projection contains the definition of the associated type (from the trait) and substitutions for the trait's Self and type parameters.
For constants, it would have to be a whole expression (AST for now, as we have nothing better), and substitutions for each ExprPath node that references an associated constant from a trait.

I've taken a look at that first commit, and yes, that's exactly what I did when I first started, as well.
But on top of rust-lang/rust#23265, I now have:
pub enum TraitItem_ {
    MethodTraitItem(MethodSig, Option<P<Block>>),
    TypeTraitItem(TyParamBounds, Option<P<Ty>>),
    ConstTraitItem(P<Ty>, Option<P<Expr>>),
}

pub enum ImplItem_ {
    MethodImplItem(MethodSig, P<Block>),
    TypeImplItem(P<Ty>),
    ConstImplItem(P<Ty>, P<Expr>),
    MacImplItem(Mac),
}

Which I've found to be much easier to work with.
Btw, I don't want to get too deep into implementation details on this issue, could we take this on IRC?

I thought about it a little more, and I guess that I partially agree. At least the examples I mentioned might turn out to be OK. However, you do have to live with some restrictions in the same vein as what's mentioned here.
Specifically, the compiler can't prove that [u8; <T>::N+<T>::N] and [u8; <T>::N*2] are the same type. Therefore either you are stuck rejecting some constant expressions in generic code (that would work if there were no type parameters involved), or you have to throw type errors after monomorphization (whether that means moving monomorphization up or type errors down).
(OK, I just saw your next comment. I'm about to go to work, but we should talk on IRC at some point. In the meantime, if you want to leave notes in a more appropriate place, try rust-lang/rust#17841? I think that your ast changes will be very helpful, since e.g. they accord with my treating defaults for associated constants as simply Option<P<Expr>>, rather than using the Required/Provided type of split.)

"throw type errors after monomorphization" is the part that is not compatible with Rust.
@nikomatsakis can you confirm that the example above should be rejected, lest we normalize one of the expressions to the other? (though that could require a full SMT solver, and that is not something I am eager to have in rustc)

I'm going to reopen this RFC. Given that multiple people are interested in implementing this feature, and there's not much to think about re: updating the original RFC to talk about const as well, I don't think this RFC needs to be postponed.

I hope that it's not too much of a curveball, but I've significantly changed what's here. The basic reasoning is:

Most people (including myself) seem to have assumed that the intention in this RFC was to add associated constants, and not associated (potentially mutable) global variables. So instead of adding associated consts on top of statics, this pull request now simply interprets the original text as referring to constants, and updates it to make that clearer.

I noticed that in generic code, you really can't use associated consts in all of the same situations as you can use other consts. So I added some sections to point out where there are limitations that we don't have a completely "obvious" answer to. That could be a separate RFC, and I'd be willing to make one if it should be its own file. But I think that those sections are really just trying to puzzle out what is or isn't possible within the original design, so in that sense it sort of fits here as a sort of clarification/reinterpretation of the RFC.

Are associated constants object-safe? Is it legal to add where Self: Sized or the like to associated constants?
Note that static methods (aka associated functions) are not object-safe.

No and no. That is, we could probably invent some kind of Sized-related restriction that would allow constants to be emitted into vtables, but AFAIK, no one has requested that. Of course, you couldn't actually use them as constants even if they were allowed. There are no  where clauses allowed on associated constants, so there's no way to express such a restriction anyway.

Hmm, to clarify, those were supposed to be two different answers. 1) Associated consts are never object-safe in the narrow sense of being safe to use in code that deals with objects. 2) In order to preserve the object-safety of traits that use them, I really think that we have to treat all constants as if they had an implicit where Self::Sized. Does that make sense?

@quantheory I don't think we should do that, I doubt there are many traits which would use associated constants without being otherwise object unsafe (Int would have methods involving by-value Self).

@eddyb: If so, that's not a reason for one side or the other, so much as an argument that it hardly matters either way.

@quantheory This is the specific use-case I had in mind when I was asking: https://github.com/rust-lang/rfcs/pull/956#issuecomment-84567203

@quantheory Sorry, I wasn't clear enough: an implied bound will require weird special-cases to remove later, it's a cost that has to be well justified.
It's better not to assume limitations will stay with the design, i.e. associated constants in vtables have been wanted for a long time.

@eddyb OK, I see now. I think that the requirement would have to be that you can't useSelf (or any Self-associated type) in the constant's type, and the constant also has to be Sized. That seems like it would be enough to avoid issues where you don't know the size of an item in the viable.
Even so, I'd like it better if we could express the where Self: Sized restriction on consts by some means.

@quantheory well, it has to be the same type across all trait objects, so only Self is an issue (associated types have to appear in the trait object type, i.e. Box<Deref<Target=T>> is valid, Box<Deref> isn't).
No constants are unsized right now, and even if we were to support that, we can always put them behind a pointer - after all, they're static.
Adding where clauses to associated constants seems like a sensible thing to me, especially given that they are values, just like methods.

I've added the T-lang tags, and am calling for some attention from the @rust-lang/lang subteam. (We're all digging out of quite a backlog from the 1.0 release, still.)

I have not thought about this PR in some time, since the majority of the text is superseded by #1062. I hope it's not too much of a bait-and-switch, but just erased most of the generic constant discussion in favor of that other RFC, which I think is more detailed and current. At the same time, I did add a mention of trait objects here, simply because it seems much more straightforward and consistent with the original RFC.

Hear ye, hear ye. This RFC was moved into Final Comment Period as of Wed, June 11th. (Sorry, forgot to add this notice!)

:+1: from me. I agree that "associated constants" are more in the spirit of the original RFC than associated statics. Associated statics in particular seem to raise some thorny questions about precisely when the static is instantiated, since statics have observable identity.

:+1:, this is in line with the original intent of the RFC.
I notice that the RFC text is out of date with respect to the scoping rules we ended up with, but that can be dealt with separately.

It's official... the language subteam has decided to accept this RFC.


AM6x A53 pinctrl fix

This PR is intended to fix any mistakes made in https://github.com/zephyrproject-rtos/zephyr/pull/55245.
See https://github.com/zephyrproject-rtos/zephyr/pull/56565 for further discussion.
Main changes (so far):

Remove direct usage of pinctrl-0 props in drivers
Convert pinctrl driver to multi-instance

See my comment here as well https://github.com/zephyrproject-rtos/zephyr/pull/56565#issuecomment-1505049967

@gmarull I've added a WIP commit that allows slicing the pinctrl-single,pins array to take #pinctrl-cells + 1 values at a time.
e.g. with #pinctrl-cells = <1>;
pinctrl-single,pins = <
	0x1c8 0x50000
	0x1cc 0x10000
>;

This macro gives two indexes at a time:
DT_FOREACH_PINCTRL_CELLS_GROUP(node_id, prop, fn)
	- fn(node_id, prop, 0, 1)
	- fn(node_id, prop, 2, 3)

and with #pinctrl-cells = <2>;
pinctrl-single,bits = <
	0x00 0x11111111 0xffffffff
	0x04 0x00011000 0x000ff000
>;

The macro gives three indexes at a time:
DT_FOREACH_PINCTRL_CELLS_GROUP(node_id, prop, fn)
	- fn(node_id, prop, 0, 1, 2)
	- fn(node_id, prop, 3, 4, 5)

If you think this is a reasonable approach I will tidy it up and add some unit tests

Thanks for the continued work @gramsay0. I think that the pinctrl-cells usage is the correct approach (also used in Linux). I wonder if the DT_PHA_BY_IDX API is not enough (provided you also add in bindings the pinctrl-cells specifier). Have you tried?

Thanks for the continued work @gramsay0. I think that the pinctrl-cells usage is the correct approach (also used in Linux). I wonder if the DT_PHA_BY_IDX API is not enough (provided you also add in bindings the pinctrl-cells specifier). Have you tried?

@gmarull It's not easy to split the array into groups using preprocessor macros.

Maybe that's good enough for now?
#pinctrl-cells already has bindings, but anything that starts with # or ends with -map does not generate defines/macros in the device tree header


joystick_drivers: 1.11.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository joystick_drivers to 1.11.0-0:

upstream repository: https://github.com/ros-drivers/joystick_drivers.git
release repository: https://github.com/ros-gbp/joystick_drivers-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.23
previous version for package: 1.10.1-0

joy
* fixed joy/Cmakelists for osx
* Contributors: Marynel Vazquez

joystick_drivers

No changes

ps3joy

No changes

spacenav_node

No changes

wiimote
* Sample Teleop Implementation for Wiimote
* C++ Implementation of Wiimote Controller Node
* Add queue_size to remove ROS Warning
* Contributors: Mark D Horn

Need to fix the roslint package requirement


How to disable lsp inline error messages?

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
NVIM v0.8.3 Build type: Release LuaJIT 2.1.0-beta3 Compiled by runner@fv-az183-550  Features: +acl +iconv +tui See ":help feature-compile"     system vimrc file: "$VIM/sysinit.vim"   fall-back for $VIM: "/share/nvim"  Run :checkhealth for more info
Operating system/version
wsl2 ubuntu22.04
Terminal name/version
wezterm
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
In some cases, I don't need lsp inline error diagnostic messages. Too many error messages make my codes messy. I can run LspStop to stop LSP, but i prefer to configure the setting to disable error hints and remain lsp functionalities.
How can I disable these error hints?
Expected behavior
N/A
Actual behavior
No response
Additional information
No response

This is not a bug issue.


Add support for django 3.0

[x] Replace ugettext_lazy with gettext_lazy when running on python 3
[ ] Manual test paths not covered by test suite

@yakky Anything I can do to help push this PR along? This is the last blocker for us to upgrade to Django 3.

@bunchesofdonald I just need to run it to cover code paths not included in tests
Any additional review, tests will help!

Could this be merged?

Merged, thank you very much @yakky


Remvoe build_spec

See https://github.com/bioimage-io/python-bioimage-io/pull/76

LGTM

I will wait till we have merged https://github.com/bioimage-io/python-bioimage-io/pull/76 and then merge this one.


Inconsistent between discourse and taiga in smtp server config

Version information

OS: docker Ubuntu 20.04
Branch: development
commit: 5e1d62a8949b9e93b7700614a1ff58906d4eddfa
Browser: Version 84.0.4147.125 (Official Build) (64-bit)
explorer: testnet

Taiga

Discourse

Commit_ID 3fb43399683fe291a1ad56b2ec07ba5fef8e7eeb , Branch development


Cron job does not work with Prestashop 1.7

In "gsitemap-cron.php", the use of p() at line 55 causes a "PHP Fatal error:  Uncaught Error: Call to undefined function p()".

Created a pull request (#44) for this. 👍

Prestashop 1.7
I'm getting 500 error in gsitemap link for cron jobs.
UndefinedFunctionException in gsitemap-cron.php line 55:
Attempted to call function "p" from the global namespace.
Removing function p like in pull request #44 does not help, then i recieve 500 error without any errors.

Thank you for your report! This issue is fixed here: https://github.com/PrestaShop/gsitemap/pull/53


Error message TypeError: Cannot read property 'prototype' of undefined ->  var sessionQuery = new Parse.Query(Parse.Session);

I used to be able to query the user session counts after they login, but now I keep getting this error basically saying Parse.Session is undefined. I can't find anything in the documentation that changed so not sure why this is throwing an error now. Here is the simple query that is failing.
Parse.Cloud.define("getNumberOfUserSessions", function (__request, __status)
{
  console.log("getNumberOfUserSessions called for "+__request.user.id);
  var __user = __request.user;
//Having issues with Parse.Session, trying this for now.
  var __sessionQuery = new Parse.Query(Parse.Session);
  __sessionQuery.equalTo("user", __user);

  return __sessionQuery.count().then(function (__numberOfSessionsInt)
  {
    // Set the job's success status
    console.log("getNumberOfUserSessions was a success! "+__numberOfSessionsInt);
    __status.success(__numberOfSessionsInt);
  }, function(error)
  {
    // Set the job's error status
    __status.error("Uh oh, something went wrong with getNumberOfUserSessions...Code:"+error.code+"::"+error.message);
  });
});

Hi @animepauly, could you tell us

What version of Parse JS SDK do you use in your cloud code?
The exception happens in this line var __sessionQuery = new Parse.Query(Parse.Session); and the exception message is Parse.Session is not defined?

I am using the JS SDK in CloudCode only and that version prints out as 3.0.2 in my terminal.
Parse.Session seems to be returning undefined

There is no such version as 3.0.2, how are you reporting the version?

3.0.2 is the version of the Parse CLI tool -- to print out the version of the JS SDK, use parse jssdk on your computer, or print out Parse.CoreManager('VERSION') in your cloud code.

Sorry about that. I am using JS SDK 1.3.5 in the Parse CLI

Parse.Session was not implemented until version 1.4.0

I have been using this for months so please don't close and dismiss this. This just started throwing errors. If it truly is a version problem, how do I update the JS SDK for Parse cloud code?

The Parse CLI controls which version of the SDK is used in your cloud code environment.
From the directory for your parse app:
parse jsssk --all lists the SDK versions available
parse jssdk X.Y.Z sets the SDK version to use, where X.Y.Z is a valid SDK version.
On your next parse deploy, it will be set for your cloud code app.

That fixed the issue. Thanks. Not sure how my js sdk got reverted then on cloud code.


Include as a reviewer for workbench images

Include as a reviewer for workbench images
Description
I would like to assist with reviewing on this repo.
I had previously worked on the notebooks images on project thoth and can help out in a similar manner.
How Has This Been Tested?
Not a code change
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Hey, I would propose, adding yourself also in the reviewers list!

Hey, I would propose, adding yourself also in the reviewers list!

oh, i just wanted add myself to reviewers , mistakenly added myself to approver
corrected it now :)


Master

Category

[x] Content fix

Moving pending changes from master to main - given the branch renaming.

Docs Build status updates of commit 24f8522:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/apis/migration-api-overview.md
:warning:Warning
View
Details

docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md
:warning:Warning
View
Details

docs/toc.yml
:warning:Warning
View
Details

docs/transform/modernize-scanner-reports-workflow.md
:warning:Warning
View
Details

docs/transform/modernize-scanner-reports.md
:warning:Warning
View
Details

docs/transform/modernize-scanner.md
:warning:Warning
View
Details

docs/transform/modernize-workflows.md
:warning:Warning
View
Details

docs/solution-guidance/security-and-performance.md
:warning:Warning
View
Details

docs/apis/migration-api-whats-new
:white_check_mark:Succeeded

docs/business-apps/power-automate/guidance/migrate-from-classic-workflows-to-power-automate-flows.md
:white_check_mark:Succeeded
View

docs/solution-guidance/Handle-SharePoint-Online-throttling-by-using-exponential-back-off.md
:white_check_mark:Succeeded

docs/apis/migration-api-overview.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/general-development/how-to-avoid-getting-throttled-or-blocked-in-sharepoint-online.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/toc.yml

Line 2059, Column 13: [Warning: file-not-found - See documentation] Invalid file link: 'apis/migration-api-whats-new.md'.
Line 504, Column 11: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/learn/paths/m365-sharepoint-associate/' will be broken in isolated environments. Replace with a relative link.
Line 558, Column 11: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/learn/paths/m365-extend-viva-connections/' will be broken in isolated environments. Replace with a relative link.

docs/transform/modernize-scanner-reports-workflow.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/transform/modernize-scanner-reports.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 37, Column 225: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepoint/dev/transform/modernize-connect-to-office365-group-scanner' will be broken in isolated environments. Replace with a relative link.

docs/transform/modernize-scanner.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 24, Column 162: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/sharepointmigration/overview-of-the-sharepoint-migration-assessment-tool' will be broken in isolated environments. Replace with a relative link.

docs/transform/modernize-workflows.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

docs/solution-guidance/security-and-performance.md

Line 18, Column 2: [Warning: file-not-found - See documentation] Invalid file link: 'Handle-SharePoint-Online-throttling-by-using-exponential-back-off.md'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Looks like a typo in webpack config: 'partten'

  new ReplacePlugin([{
    // this is actually the property name https://github.com/kimhou/replace-bundle-webpack-plugin/issues/1
    partten: /throw\s+(new\s+)?[a-zA-Z]+Error\s*\(/g,
    replacement: () => 'return;('
  }])

https://github.com/alphagov/accessible-autocomplete/blob/master/webpack.config.babel.js#L38

sorry, just read the comment, how bizarre

I've had plenty of double takes with that too! 😄


User preferences or config settings

I am trying to disable the background network calls which geckoview Mozilla makes in the background but having issues while setting up the preferences,
I found this article https://winaero.com/disable-firefox-captive-portal-and-connection-to-detectportal-firefox-com/#To_Disable_Firefox_Captive_Portal_and_Connection_to_detectportalfirefoxcom where you can set user preference setup like how you modify about:config for Mozilla browser, but I couldn't find the right implementation of it in geckoview documentation
user_pref("network.captive-portal-service.enabled", false);

@kitTiwari I haven't tried setting such stuff before and have no idea where it is.
Where are you trying to set this: user_pref("network.captive-portal-service.enabled", false);? the current implementation does not expose such an api

I was trying to use references from here https://www.javatips.net/api/org.mozilla.gecko.prefshelper but they seems to be deprecated

I will see if there is an api for it on GeckoView. There's an option to enable about:config. Maybe we can set properties too programmatically.


Microformats 2 supprt

There's a pull request at https://github.com/TryGhost/Casper/pull/29 regarding MF2 support in casper, but it was rejected on the basis of MF2 being something undevelped. Three years down the line, I'm wondering if you'd accept that or an updated PR to support MF2 and Indieweb bits?

We've since adopted automatic microformats support in Ghost core via JSON+LD, which we went for because it's abstracted away from the theme and so "just works" everywhere :)

That's excellent news, but at the moment https://john.onolan.org/en-route-to-mauritius/ isn't validating for the basics of microformats2 h-entry classnames (e-content, p-name, dt-published, u-url - see http://microformats.org/wiki/h-entry for the extended bits) or author (p-author h-card and/or rel=author - see http://microformats.org/wiki/h-card). In addition, the https://john.onolan.org/ doesn't support h-card.
I can submit issues to core for this, if that's preferred and/or attempt to generate a PR for you. I just thought I'd check on this issue before I start.

Sorry, I should have been more clear: We're using the schema.org specification via JSON+LD. The output of which is valid, and can be verified here: https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Fjohn.onolan.org%2Fen-route-to-mauritius%2F
At the moment we still don't think that the microformats2 approach is the right way to go or will offer significant benefits beyond our existing structured data -- particularly at the cost of a significant amount of additional clutter in the HTML

Schema isn't microformats. There is no public parser for it, just some opaque stuff at Google. The supposed clutter is much terser than schema. See http://www.kevinmarks.com/microformatschema.html

I also wonder if you'd rethink the view that there's a lot of clutter if you have a moment to look at PR #29 again? There's a total of 46 added characters to index.hbs and 91 characters to post.hbs, so it isn't what I'd call particularly heavy (although I appreciate you might want a new PR focussed on the core rather than the theme).

You're (both) very welcome to add microformats 1/2/any-other to your themes, but this isn't something we're going to include in the default theme at the moment. I have no opinion on any politics RE schema-vs-microformats other than that schema has a concrete use-case and benefit which justifies its inclusion :)


addEnhancedEcommerceImpressionContext  picks up the wrong positional arguments

I was having trouble with the addEnhancedEcommerceImpressionContext as it always was marked as invalid schema. I realized, that the Snowplow library picks up the wrong values of the Datalayer. This seems to be because of the positional arguments the SP library is requiring:
This is an impression datalayer example:
        id: 'U-30-Abo ePaper und M-Plus',
        name: 'U-30-Abo ePaper und M-Plus',
        price: '14.9900',
        brand: 'Mittelbayerische Zeitung',
        category: 'catalog/category/view/s/neukunde-digitale-angebote/id/24/',
        position: 1,
        list: 'Spezial Angebote'

This is what ends up in the Snowplow hit:
id:	U-30-Abo ePaper und M-Plus
name:	U-30-Abo ePaper und M-Plus
list:	Spezial Angebote
brand:	Mittelbayerische Zeitung
category:	catalog/category/view/s/neukunde-digitale-angebote/id/24/
variant:	1
position:	14

Position will end up as variant and part of the price will end up as position.

I fixed it for my use case. I've added all the fields that can be set regarding to the Snowplow context (https://github.com/snowplow/snowplow/wiki/2-Specific-event-tracking-with-the-Javascript-tracker#3142-addenhancedecommerceimpressioncontext)
  if (getType(obj.impressions) === 'array') {
    obj.impressions.forEach(i => tracker('addEnhancedEcommerceImpressionContext',
                                         i.id,
                 				         i.name,
                                         i.list,
                                         i.brand,
                                         i.category,
                                         i.variant,
                                         i.position,
                                         i.price,
				                         obj.currencyCode));
    action = 'view';
  }

This is fixed in PR #13, so PR #15 can be closed.


Fix package build process for Yelp pipeline + bump version

It appears that docker-dev.yelpcorp.com/xenial_pkgbuild already
contains ruby and golang installed as well as fpm.
That makes apt-get commands in Dockerfile unnecessary at the very
least.
In fact, these command actually build the package build.
Also, code perfectly compiles by go 1.11.x version, which is installed
in aforementioned image.
Version is bumped to 0.9.1 to facilitate rollback to previous version if something went wrong.

👍


Notebook Markdown cell does not render image

@CIA-Trash commented on Thu Mar 11 2021

Environment data

VS Code version: Version: 1.55.0-insider (Universal); Commit: 11d5e82c80c6151e3f6d9da10429582b589c16ba
Jupyter Extension version: v2021.4.641214696
Python Extension version: v2021.4.637492490-dev
OS and version: macOS 11.2.1 (20D74)
Python 3.7.9
conda 4.9.2
Jupyter server running: Local

Attempt 0

Expected behaviour
The line here should render a image.
Actual behaviour
However, the image is not rendered

Attempt 1
I also tried the markdown way

Expected behaviour
This is what it should look like, the screenshot is taken from vscode stable build

Actual behaviour
But insider build renders it like this

Both styles of images seem to work fine for me. Does this reproduce in the latest VS Code insiders build?
If not, can you please share a small project that demonstrates this

Both styles of images seem to work fine for me. Does this reproduce in the latest VS Code insiders build?
If not, can you please share a small project that demonstrates this

Yes, this only happens to insiders build.
The stable build is fine.

Looks like you're on an old insiders build though. Make sure you are on commit 111a6cec70f9562cdd31a5fd8cdea4b3a9b7bd82

Danke, all looks good now

Thanks for checking. Let us know if see this again with latest insiders


Show player if they have enough supplies

Add an option to show the player if they have enough supplies in their inventory to complete their current contract. If turned on, it shows it on the right side of the overlay. If the Plank Sack plugin is installed, it also counts planks in the plank sack.
Some pictures showing what it looks like: https://imgur.com/a/rpGHKEN

@TheStonedTurtle Could we get this reviewed/merged in? I think this would be a great addition to the plugin.

Do you think we can get this reviewed and merged? This works great and would solve the first suggestion on #12 .

Sorry for the very long delay on the PR review, life happens sometimes.
@PeaceBear0, if you don't want to make the requested changes just let me know. I will eventually merge this but I would need to resolve the issues myself first which who knows when that will be.

As we haven't had any updates, I had applied your requested changes to PR #28 in behalf of @PeaceBear0 .


DB stored procedure returns incorrect results to Cisco ISE

DB stored procedure returns incorrect results to Cisco ISE
iPSK Manager's stored procedures play a key role in how ISE handles the requests for access.
Affected Stored Procedures

iPSK_MACLookup
iPSK_MACLookupNonExpired

Procedures execute the following SQL Statements and return the results to ISE when an Endpoint is Disabled, causing ISE to continue to the next Identity Store within the Identity Sequence

SELECT 3, 0, 'odbc','ODBC Authen Error';

This causes the DB to always return an incorrect response when an endpoint is either disabled or expired.
Expected Results
The affected stored procedures should return the proper response according to the status of the endpoint within the iPSK Manager Database.


chore: update dependencies

r? @yberreby
@homu r+

:pushpin: Commit b7fffbb has been approved by yberreby

:hourglass: Testing commit b7fffbb with merge 7d32d9b...

:sunny: Test successful - status

@kbknapp Could you bump the version and publish to crates.io? docli-rs must depend on the latest version with the updated dependencies in order to build on nightly.


Sharetool protection messages

Using sharetool protection bypass features causes protection messages at least with protector mod.
Messages are caused because protector mod overrides minetest.is_protected and throws messages when that is called and can_dig check fails.
Code for above stuff can be found from here:
https://github.com/mt-mods/protector/blob/master/init.lua#L194-L288

Same thing was problem in some other mod too and would be nice to fix at root of the problem but this can be fixed here by reordering checks and early return if owner/shared marker/shared account check passes.

Partial fix applied to https://github.com/S-S-X/metatool/tree/shared-nodes

Not very big problem really, maybe it will be fixed someday in protector mod but does not seem to be real problem.
Spamming is fixed by reordering checks.
Few violation messages wont get through and that could also be fixed but does not really seem to be that important, tool simply wont work without reporting violation under some special conditions and currently only really affects single moderator tool.


Focus vanishes after refactoring

VSCode Version: 0.10.11
OS Version: Ubuntu 15.10

Steps to Reproduce:

Press F2 on a variable
Refactor the name
Focus is somewhere else, but not in the editor anymore

closing as dupe of #5008

Thank you!


[Sema] Corrections for for-await-in syntax to prevent specific bad code-gen scenarios and improve diagnostics

SILGen verification crash when no other async functions are called in a function body not marked as async when a for-await-in syntax is used. This corrects the diagnostics to ensure that the type check effects sees the proper async call that the for-await-in syntax infers.
for-await-in syntax was missing a diagnistic hint for inserting a try when the protocol conformance of the sequence shows a potential of throwing. (also there was a superfluous check for the nominal type in that type check (which was removed).
for-await-in syntax and for-try-await-in syntax did not infer async or throwing to closure constraints, both were added to properly identify the asyncy-ness/throwy-ness of the iteration.
Resolves:
rdar://73952786
rdar://73883058
rdar://73953266

@swift-ci please smoke test

ooh that is a fun error from windows:
fatal: not a git repository (or any of the parent directories): .git
error: https://github.com/apple/swift.git did not send all necessary objects

fatal: not a git repository (or any of the parent directories): .git

network failure?

Mac failure is:
/Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swiftpm/Sources/Build/SPMSwiftDriverExecutor.swift:80:39: error: value of type '[Job.ArgTemplate]' has no member 'joinedArguments'
10:51:18       result += " # \(job.commandLine.joinedArguments)"
10:51:18                       ~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~
10:51:18 [14/21][ 66%][34.489s] Linking Swift shared library lib/libXcodeproj.dylib
10:51:18 ninja: build stopped: subcommand failed.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci Please Build Toolchain macOS Platform

@swift-ci please smoke test

Toolchain build had a strange error:
20:52:08 fatal error
20:52:08 : module map file '/Users/buildnode/jenkins/workspace/swift-PR-toolchain-osx/branch-main/buildbot_osx/swiftpm-macosx-x86_64/apple/Intermediates.noindex/GeneratedModuleMaps/macosx/CCryptoBoringSSL.modulemap' not found

@swift-ci Please Build Toolchain macOS Platform


Add Global Rename Log Button

Added global rename log button for Usernames

Codecov Report

Merging #468 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   20.54%   20.54%
=======================================
  Files           9        9
  Lines         584      584
=======================================
  Hits          120      120
  Misses        464      464

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743d3fa...4cf5b03. Read the comment docs.

Changes implemented.


HeliosSoloDeployment: use external host address for HELIOS_HOST_ADDRESS

.. when local environment is Docker for Mac.
This resolves a conflict introduced in #927 where the
HELIOS_HOST_ADDRESS passed into the helios-solo container ends up as
localhost.
This value is then used when a TemporaryJob is deployed and
.address(port) is called, because TemporaryJob queries the environment
variables of the helios agent.
This causes an issue if one tries to pass this "public address of the
TemporaryJob" value into another TemporaryJob instance (for example, to
tell one TemporaryJob how to reach another), because localhost in the
container will route differently than it does on the host.
The change in #927 originally intended to resolve an issue where the
probeContainerGateway value was being used, which in DFM has a value
like <IP_ADDRESS> which is not routable on the host. This caused a
problem if the user tried to use the TemporaryJob.address(port) value
on the host to communicate with the container.
The value returned by address() needs to be usable both outside the
container and inside a container, so the fix here is to use the public
address of localhost on the host.

@spotify/helios-team @lndbrg

[Current coverage][cc-pull] is 49.56%

Merging [#944][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master       #944   diff @@
==========================================
  Files           272        272
  Lines         12830      12834     +4
  Methods           0          0
  Messages          0          0
  Branches       1657       1658     +1
==========================================
+ Hits           6359       6361     +2
  Misses         5989       5989
- Partials        482        484     +2

Powered by Codecov. Last updated by [c319197...4951b7a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/spotify/helios/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/spotify/helios/compare/c3191978a8df5a8b374dc89c1d5b878e5c0a5a09...4951b7a57144cfbf0b788005ea85530f99664d2c?src=pr
[cc-pull]: https://codecov.io/gh/spotify/helios/pull/944?src=pr

😄  👍 :shipit:

@rohansingh @negz @gimaker please review

:+1:

@lndbrg this should be available in helios-testing:0.8.804 now.


Clean-up and optimize router a little bit

Description
This PR fixes the hack I introduced in #1859 and also adds a couple of optimizations optimizations.
Checklist

[ ] I have run cargo make pr-flow
[x] I have reviewed my own code
[ ] I have added tests

@Diggsey, can you take a look? I implemented some of the optimizations from your PR in the current router.
Also, sorry I didn't mention you earlier. I was going to but forgot

Seems reasonable - it's maybe surprising that recognise has side-effects on current-route? And it would be nice if there was a way to reset the route when the router has been destroyed, so that it doesn't continue returning an out-of-date value.

it's maybe surprising that recognise has side-effects on current-route?

Those methods aren't really supposed to be used by the user. We provide abstractions over those which should be used instead. I feel like it is a documentation issue.

it would be nice if there was a way to reset the route when the router has been destroyed, so that it doesn't continue returning an out-of-date value.

That's a good point. I will add a destroy method which is called from component's destroy and will clean up the state.

Should probably update the documentation to state that Routable needs to implement Clone now.
You might even want to add it as a bound to the Routable trait itself.

@siku2 I made the changes. Take a look.


Color picker in Reference panel not working

Material Maker version:

1.0
OS/device including version:
Windows 11

Issue description:

Hasn't been working since version 0.97

Could you please describe how you (try to) use the reference panel and what does not work?
Did it work prior to 0.97?

Hi
In version 0.97 i would click one of the boxes under the reference image and then on the image itself to get a color,
just as described in the documentation under reference panel page.
It stopped working in version 0.98.
It's a very nice feature especially the ability to quickly construct a gradient.


Fix GitHub URLs in book.toml

This makes it easier to contribute while the new tutorial is still in the staging area.

This is intentional, as the definitive URLs are pointing to v1, which will be replaced very soon. The temp fix for the time being is to skip checking for Web links in production, which is okay for the time being.


Vehicle Routing (Frontend)

This is a PR adding VRP support for the provideq toolbox web. Connected PR on the toolbox-server: https://github.com/ProvideQ/toolbox-server/pull/70
In addition to the VRP page that is added there are a few bugs fixed and features added:

added support for Solver specific Settings
added support for a Integer Setting
fixed bug in which the Subroutine data doesn't get added to the solve request

! THIS PR is based on the feat/history branch. It should only be merged after this branch gets merged

Thank you for your contribution! We'll have a look at this PR when our refactoring in #69 is merged


Added methods to calc circle circumference & area

diameterToCircumference and radiusToArea

These are useful functions, but out of scope for this little experiment. Aside from squared, cubed, and fact, this library only defines methods which can trivially be derived from Math functions.
I imagine there exist several JavaScript libraries for working with areas, circumferences, and radii.


.editorconfig from https://github.com/dotnet/format

It will be great to apply official dotnet-format tool as well : )

Thanks


Able to tap through modal backdrop

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:
Expected behavior

Link to runnable example or repository (highly encouraged)

UI Kitten and Eva version

Package
Version

@eva-design/eva

@ui-kitten/components

Environment information

I am also able to click through the backdrop of a modal on 4.3.1. But it appears to be fixed on 4.4.0-beta.3, so all is well. Just posting for future issue viewers.


Add testcases

Coverage remained the same at 38.569% when pulling 5ea46a449602051094eb79faa9c892dab288105a on add-tests into 76150b30607d7b384f90ab7886dba5805d39cacd on master.

Coverage increased (+2.4%) to 40.978% when pulling 5ea46a449602051094eb79faa9c892dab288105a on add-tests into 76150b30607d7b384f90ab7886dba5805d39cacd on master.

Coverage increased (+12.5%) to 51.064% when pulling c6a82dfbe236d85ff88468b4f693765d8442549a on add-tests into 76150b30607d7b384f90ab7886dba5805d39cacd on master.

Coverage increased (+17.7%) to 56.3% when pulling db5aacdfc192218e770490ff2b8ebcb319658554 on add-tests into 76150b30607d7b384f90ab7886dba5805d39cacd on master.


Symfony 3.1 support

I'm starting a new Symfony project for an API application and I'd love to use this bundle for JWT authentication. However, my Symfony project is currently on v3.1: this bundle only supports 3.0.
I've not looked into what's involved in adding 3.1 support myself - are there plans for this to be done? This bundle looks great, so I may end up downgrading to 3.0 temporarily, but if 3.1 support is imminent I can wait.

Hi @chriscollinsboxuk
This bundle works well on Symfony 3.1, you can use it right now.
The only thing is that we don't test the bundle on Symfony > 3.0.
To give you an explanation, we are currently working on a 2.0 version which should be released very soon and is especially suited for Symfony 3+, supporting until 2.8+.
You can get in touch when 2.0 comes to be released by watching this repository, this one gives a lots of improvements and some nice new features.
Let me know if this solved your question or directly close this issue.
I hope this bundle fits your needs.

Hi @chalasr
You're quite right, I made a silly mistake - I was having trouble installing it because I'd forgotten that we mirror our dependencies using Satis and I'd not yet made the dependency available to our mirror. Composer's error messages are sometimes a little vague :)
Thanks for your help.


publishCollection S3Target

Just updated our system from Flow 3.0 to Flow 3.0.2. After this update, clearing the cache, and warming up the cache I got the following PHP Fatal Error:
PHP Fatal error:  Declaration of Flownative\Aws\S3\S3Target::publishCollection() must be compatible with TYPO3\Flow\Resource\Target\TargetInterface::publishCollection(TYPO3\Flow\Resource\CollectionInterface $collection) in //var/www/system/Packages/Application/Flownative.Aws.S3/Classes/S3Target.php on line 24
I got it working again by changing the code below:
/**
     * Publishes the whole collection to this target
     *
     * @param \TYPO3\Flow\Resource\Collection $collection The collection to publish
     * @return void
     * @throws Exception
     */
    public function publishCollection(Collection $collection)
    {
    ....
    }

into
/**
     * Publishes the whole collection to this target
     *
     * @param \TYPO3\Flow\Resource\CollectionInterface $collection The collection to publish
     * @return void
     * @throws Exception
     */
    public function publishCollection(CollectionInterface $collection)
    {
    .....
    }

(changed Collection to CollectionInterface)
I haven't tested this on Flow 3.0.0 or 3.0.1 though....

Fixed since 2016-03-08 and released with version 1.1.0-beta1.


maven wizard doesn't generate Java code

i.e. no src/main/java folder
May be a simple case of needing to select a different archetype by default.

When I change the wizard to use the guestbook archetype instead, it does generate the expected Java code so the issue seems to be that we need a slightly more complex archetype here, if we're going to use archetypes at all.

I'm trying to get some code added to the skeleton in https://github.com/GoogleCloudPlatform/appengine-maven-archetypes-java/pull/23
If that proves problematic, maybe we can get this added as a second skeleton.

Yeah, just hit this. This definitely needs to be fixed.

fixed


Add row and column spanning in tables

As mentioned in issue #27, it should be possible to let an item span over two columns.
Issues found during brainstorming:

Only specific cells have a column or row span, this messes up the row-based calculations, and the data validation

Is this issue or enhancemet in progress?

It is not due to time management. PR is welcome

well to bad I lost the whole branch need to restart working on this

Alright working on it in feature/41-tables-spanning

This will be fixed by #181, setting it on hold

Alright closing it, as this is available on the develop branch now


Notifications on long-running operations and component templates management

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

#1379

Thanks, @SuZhou-Joe! Do you mind if I make some edits and push to this PR?

Thanks, @SuZhou-Joe! Do you mind if I make some edits and push to this PR?

Sure, please feel free to edit.

@natebower I implemented all your comments.

@kolchfa-aws @natebower Thanks a lot for your attentive review.

@SuZhou-Joe @kolchfa-aws - Let's go ahead and publish this blog today since we have a gap in the schedule today.
@krisfreedain @nateynateynate @dtaivpp - Please push this blog live today.

@dtaivpp Date changed. Ready to publish


Add prometheus metrics

Add a prometheus metrics endpoint that will enable monitoring of state.
Metrics for:

Number of graphql subscriptions
Number of unique clients (if possible?)
Number of CA and PVA monitors
Count of exceptions / errors - of different types if appropriate
Number of dropped updates

This will enable better monitoring.

This has been merged as part of #53


Add changelog

Fix: #15
Though for initial version it doesn't make much sense to keep proper changelog. I would suggest to do something similar to initial release of srcd-ce, just mention main features.

Though for initial version it doesn't make much sense to keep proper changelog. I would suggest to do something similar to initial release of srcd-ce, just mention main features.

Yup! I strongly agree. Until we don't have a first release I doesn't make sense. IMO once we have handling of abuse and rate limit error, migrations binded, we could tag the first release.
WDYT?

Yup! I strongly agree. Until we don't have a first release I doesn't make sense. IMO once we have handling of abuse and rate limit error, migrations binded, we could tag the first release.

maybe we should also add multi-org support before the first release.

maybe we should also add multi-org support before the first release.

Fair point. I'll create an issue. 👍


VUU21: Implement the screenshot functionality into the Save Layout component

Scope

VUU21

This incorporates the work done in the screenshot spike (#19) by adding screenshot functionality into the save dialog component.
Implementation

I branched off of origin/main and merged in VUU-17-layoutSave.
Screenshot functionality is provided with the html-to-image package in screenshot-utils.ts. The screenshot is currently stored in browser (local) storage as a base64 encoded string. Where fonts are imported externally via a link, the crossorigin="anonymous" tag has been added due to CORS issues, see this stackoverflow post  and this html-to-image GitHub issue discussing the issue.
A unit test has been written for takeScreenshot(). The html-to-image package had to be mocked out as the browser operations it relies on are not available in the test environment (neither happy-dom nor jsdom).
A Cypress e2e test has been written to check a screenshot can be taken and rendered successfully from the UI. I've restructured the directory by separating the ./support files relevant to component & e2e tests.

As this is adding functionality to VUU-17-layoutSave it makes sense to make that the base branch.
But, if this (VUU21) is merged into that branch (VUU17) before VUU17 is merged into the feature branch, it could really bloat the PR for VUU17 and make it harder to review non-screenshot related changes.
So we can either wait till VUU17 is merged into the feature branch before merging this PR in. Or we can merge this PR straight into the feature branch.

As this is adding functionality to VUU-17-layoutSave it makes sense to make that the base branch.
But, if this (VUU21) is merged into that branch (VUU17) before VUU17 is merged into the feature branch, it could really bloat the PR for VUU17 and make it harder to review non-screenshot related changes.
So we can either wait till VUU17 is merged into the feature branch before merging this PR in. Or we can merge this PR straight into the feature branch.

Discussed offline. Base branch will be VUU-17-layoutSave for reviewing but should be merged into the feature branch when #17 has been merged.


'NoneType' object has no attribute 'Join'

I've got a query with multiple joins. The query looks like this in SQL:
SELECT
    user.id,
    task.id,
    user.username,
    task.task_name
FROM user
JOIN user_has_task ON user.id = user_has_task.user_id
JOIN task ON task.id = user_has_task.task_id

I've verified that this query works and is valid. Now when I try to convert it, I'll get:
sqlitis 'select user.id, task.id, user.username, task.task_name from user join user_has_task on user.id = user_has_task.user_id join task on task.id = user_has_task.task_id'
'NoneType' object has no attribute 'Join'

Am I doing something wrong or is it a bug?

Thanks for the bug report!
There's probably two bugs here.
First bug: some problem handling the table name within the on clause
Possibly the same error occurs when dropping the second join,
$ sqlitis 'select user.id, task.id, user.username, task.task_name from user join user_has_task on user.id = user_has_task.user_id'
'NoneType' object has no attribute 'Join'

$ sqlitis 'select * from user join user_has_task on user.id = user_has_task.user_id'
'NoneType' object has no attribute 'Join'

Yet, when renaming tables (user -> foo and user_has_task -> bar), I don't see the issue. Which is interesting.
$ sqlitis 'select * from foo join bar on foo.id = bar.user_id'
select([foo.join(bar, foo.c.id == bar.c.user_id)])

Second bug: Multiple joins with on clauses
A simple multi-join works,
$ sqlitis 'select * from foo join bar join wumbo'
select([foo.join(bar).join(wumbo)])

I've got at least one test case for this.
But joins with conditions (on clauses) isn't handled right.
$ sqlitis 'select * from foo join bar on foo.id = bar.foo_id join wumbo on wumbo.id = bar.wumbo_id'
'Table' object has no attribute 'On'

@melv1n One issue here is that user is a keyword in some dialects of sql, so sqlparse (which sqlitis uses for tokenization) is detecting user as a keyword rather than an identifier which botches up the conversion.
For example, I'll get the error with a simple join because user is parsed as a keyword.
$ sqlitis 'select * from user join bar'
'NoneType' object has no attribute 'Join'

Whether user is a reserved or non-reserved keyword varies across sql dialects[1], but I need to be compatible with sqlparse which treats user as a keyword, so in this case sqlitis is going to require user be quoted, as follows:
$ sqlitis 'select * from `user` join bar'
select([`user`.join(bar)])

Note that the above is the current output which is invalid Python (due to the backticks) which I'll need to correct as part of a fix for this issue.

In some dialects (like T-SQL) user is reserved, meaning it must be quoted when used as a table name. In other dialects (like MySQL, user is a keyword but is not reserved and therefore does not need quotes when used as a table name.

I think user is a pretty common table name in a lot of schemas. Wouldn't it be more common for most devs to be referring to an identifier instead of a sql keyword (and therefor it shouldn't be interpreted as a keyword by default)?

Well, it's not up to us to decide whether it's a keyword or an identifier. It's part of the sql grammar(s). In real world queries, you have to quote reserved keywords when using them as table names, so I would like this library to work similarly.

Fair enough. I agree being opinionated is not best practice. I still get stuck on the ' joins with conditions (on clauses)'. Any way to get around that one or need to wait for a fix?

Hey @melv1n, I just merged a PR with fixes for this issue. I made a release (v0.0.3). Summary below, but let me know if this doesn't completely fix the issues outlined here and we can reopen (added tests, but they're a little light I think).
Your original, unmodified query will now output an error on the keyword and suggest quotes,
$ sqlitis 'select user.id, task.id, user.username, task.task_name from user join user_has_task on user.id = user_has_task.user_id join task on task.id = user_has_task.task_id'
Unexpected keyword 'USER'. Maybe you need to quote: `USER`?

(the error message is currently tailored for this type of keyword/identifier issue. Not sure how it fairs in other situations)
And the "fixed" query, with user quoted, now works (multiple joins and all).
$ sqlitis 'select user.id, task.id, user.username, task.task_name from `user` join user_has_task on user.id = user_has_task.user_id join task on task.id = user_has_task.task_id'
select([user.c.id, task.c.id, user.c.username, task.c.task_name]).select_from(user.join(user_has_task, user.c.id == user_has_task.c.user_id).join(task, task.c.id == user_has_task.c.task_id))

You can also put quotes on all table / column names now (which is ugly but good practice),
$ sqlitis 'select `user`.`id`, `task`.`id`, `user`.`username`, `task`.`task_name` from `user` join user_has_task on user.id = user_has_task.user_id join task on task.id = user_has_task.task_id'
select([user.c.id, task.c.id, user.c.username, task.c.task_name]).select_from(user.join(user_has_task, user.c.id == user_has_task.c.user_id).join(task, task.c.id == user_has_task.c.task_id))

@pglass I've upgraded and it seems to work now. Many thanks for your support and fixing it on such short notice!


Write tests using Spock

It's something good to try. It could be great in this project, 'cause there's only one method with one input and one output.
A link here: http://spockframework.github.io/spock/docs/1.0/data_driven_testing.html

I've tryed to apply it and... don't know. I don't feel the project too mature. The only place I found how to setup it was at one GitHub project...


Routing issue

With "Adjustment of Routing Table" enabled, vpnclient started in linux adds only 2 routes like
default via <IP_ADDRESS> dev vpn_vpn  metric 216
<IP_ADDRESS>/24 dev vpn_vpn  proto kernel  scope link  src <IP_ADDRESS>  metric 216
but not adds the route to VPN server via local network interface connected to the internet.
So the internet not works after vpnclient starts until this 3rd route not added manually.
Tested in Arch Linux.

I am ready to work on this one. It seems a big pain point when dealing with clients on linux and mac.  I will need some help from the softether community. How do I proceed?
So far what I know.

The 3rd route mentioned by @colorprint is added on Windows, which allows the client to establish direct connection with the server.
On linux and mac, it does.

Where do I start looking into the code to fix this, or add as a feature?
@moatazelmasry2
Thanks

seems like the code for this is no existent. It is only present for windows at https://github.com/SoftEtherVPN/SoftEtherVPN/blob/master/src/Cedar/VLanWin32.c
Am I correct?

There is additional code in https://github.com/SoftEtherVPN/SoftEtherVPN/blob/1a8e1385cf591ac442cfa0159d156411396c67d7/src/Mayaqua/Network.c as I see.

@davidebeatrici I am thinking of a separate Route.c file that does all the routing. Currently routing functions are spread out across different files. Once all pulled in, I could add unix versions of the same routing features as currently working for windows. Is this a good strategy?

Absolutely.


Radio Button. Do not throw value change on every click.

Codecov Report

Merging #1654 into development will decrease coverage by -0.11%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           development    #1654      +/-   ##
===============================================
- Coverage        84.84%   84.73%   -0.11%
===============================================
  Files               85       85
  Lines             2323     2326       +3
  Branches           299      300       +1
===============================================
  Hits              1971     1971
- Misses             252      255       +3
  Partials           100      100

Impacted Files
Coverage Δ

src/buttons/button-radio.directive.ts
71.79% <ø> (-5.99%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fd995...547a426. Read the comment docs.


chore: bdd-spring-1585924274 to 0.0.1

chore: Promote bdd-spring-1585924274 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Transmuxed TS content produces Shaka error 3016 and 3015 in Safari

Have you read the FAQ and checked for duplicate issues:
Yes
What version of Shaka Player are you using:
Latest from master
Can you reproduce the issue with our latest release version:
Unknown
Can you reproduce the issue with the latest code from master:
Yes
Are you using the demo app or your own custom app:
Demo app
What browser and OS are you using:
Safari Version 11.0.1 (13604.3.5), macOS 10.13.1
What are the manifest and license server URIs:
Sent by email
What did you do?
Attempt to load the playlist using the demo
What did you expect to happen?
Content to play
What actually happened?
Shaka publishes error 3016, with a MediaError code 3, MEDIA_ERR_DECODE. Then it publishes error 3015, but I assume that 3015 happens as a result of the underlying decoding error. See attached image below.
If I modify the MediaSource polyfill so that TS content does not get rejected, I can play the video. That is to say, I just make this change in mediasource.js:
if (container == 'mp2t') {
  // return false;
}

The video has other problems (seeking causes errors), but it does play. It's also worth pointing out that Shaka produces some logging indicating a gap at the start of the content. I don't know exactly what this means or if it could be a source of errors for muxjs.

Error 3016 is a decoder error, Safari is just refusing to play the content.  I notice the content is multiplexed; maybe Safari doesn't support multiplexed MP4?  Do you have the same stream without audio or with a separate audio stream?
When I play in Chrome, I notice some logs from chrome://media-internals:

Media segment did not contain any coded frames for track 257, mismatching initialization segment. Therefore, MSE coded frame processing may not interoperably detect discontinuities in appended media.

Maybe Safari is choking on this or the multiplexed content?  I'll look into why we are getting these logs.
Also, FYI, we disabled native TS playback on Safari since it is broken for a lot of content and doesn't play adaptation or track switching well with MSE.

I may be able to send a custom application that will play content that is not multiplexed; I'll have to look into it. I will get back to you.

I just re-tested and it seems to work for me.  So it may be fixed unless you fixed the stream another way (I didn't look too much into it).  Since a lot has changed since then I would suggest testing again.
For now I'll close it, but if the issue persists you can reopen.

I just tested again on master and it plays for me as well. Thanks for the follow up.


IR emitter will sometimes not stop firing after authenticating

This seems to apply to all applications except the terminal and the login screen.
For example, if I try to use Synaptic or GParted or elevate Nemo to root, the IR emitter will fire and authenticate, but then it will continue to fire for several minutes afterwards, before stopping on its own. If you try to run another authentication in the terminal it will throw VIDEOIO ERROR: V4L2: Pixel format of incoming image is unsupported by OpenCV Unable to stop the stream: Device or resource busy and in a gui it will say "Face detection timeout reached" and re-show the password box.

Running Linux Mint 18.3 Cinnamon 64-Bit
Running Howdy 2.3.0

The really weird part is that it occurs everywhere except on the login screen or in the terminal, which lets me to believe it's an openCV bug.
Could you give me your python3 version? (python3 -V) Also, did you install Howdy with the apt command?


How to move camera to position

So I'm working on a game where I need the camera to follow a character and from looking around in the demos I can't find any way to do it. I looked at the views example but Its very unclear how the camera is actually moving. Please help!

Take a look at this part of the code for the views example. Note that this is being updated inside an engine event. You need to make sure you also set render.options.hasBounds = true.

Hopefully that answered your question so I'll close this, but feel free to comment if you still need more info.

Hey liabru , its about the camera, is there a way we can click and drag the view ?

@beetrandahiya check out the views example which should get you started, also see the function Render.lookAt.


Detailed installation instructions for Ubuntu

I installed siderophile to test some rust code, but I ran into a few errors that I needed to find a workaround for.
I decided to document the process for both the crates.io and the github build process.
For each method's installation a fresh Ubuntu VM was set up.
Please feel free to decline to PR should it not be something you feel is needed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @bbresearcher! I've left a few style nitpicks, but this LGTM overall in terms of content. Some thoughts:

I'm so-so on including high-level steps like "install cURL" and "install Rust" -- IMO these could just be links or omitted entirely, since a user who wants to scan a Rust crate with siderophile probably already has Rust installed or knows enough about Rust to install it.
I'm okay with this being a separate documentation file, but IMO it could also just go on the wiki instead.

Thank you I have made the suggested changes.
I am more than happy for the instructions to be moved to a wiki (apologies I tried to follow the link in your comment, but I can't find the wiki folder).
I am also more than happy if you prefer to not include these instructions in the github repository.


joint contracture - amend definition and synonyms

In the MP, joint contracture MP:0030798 is currently defined as:
DEF: chronic loss of joint motion due to structural changes in muscle, tendons, ligaments, or skin that prevents normal movement of joints; a flexion contracture is a bent (flexed) joint that cannot be straightened actively or passively
Synonyms: flexion contracture | flexion contractures | joint contractures
We should move the part after the semicolon “a flexion contracture is a bent (flexed) joint that cannot be straightened actively or passively” into a comment and add (if we can find it) a definition for extension contracture.
The two flexion synonyms should be made narrow.

Can't find a definition for extension contracture.