grunt-babel fails with config from README

Running "babel:dist" (babel) task
Warning: Path must be a string. Received undefined Use --force to continue.

config:
        babel: {
            options: {
                sourceMap: true,
                presets: ['es2015']
            },
            dist: {
                files: {
                    'dist/app.js': 'src/app.js'
                }
            }
        },

It works here: https://github.com/babel/grunt-babel/blob/ce3bbc37035046a84b7988bb9f63189c7671825a/Gruntfile.js#L6-L12

+1

Experiencing this also. 100% sure the paths are correct.


The custom layer is under the building layer

Can someone help me,Why can't I move the layer above the building layer?

You can add
gl.clear(gl.DEPTH_BUFFER_BIT);
in render() of layer in first (before all actions on this function).
But three objects will be always above buildings.
After tests, CameraSync is the thing that 3D depth calcul isn't working.
Maybe this.camera.matrixWorld.copy() or translation of the map... i don't know.
I think i will create a world group, positionned at 0,0,0 and translate camera instead of translating world group.
Difficult is to convert world coords to and from lat/lng.

map.moveLayer('id1','id2')

yes  i got same issue  after using gl.clear(gl.DEPTH_BUFFER_BIT); , also i tried to change ordering nothing work correctly. here a screenshot:

anyone solved this issue?

Hi @adelchamas96 , @limzgiser , @joedjc I I have solved this problem at my fork fine tuning the CameraSync object.


Typescript definitions

Hey! I'm using p2pt in a hobby project, and found it very useful to have Typescript typings.
I see that https://github.com/subins2000/p2pt/issues/4 hasn't had any progress, so in the meantime, I'd like to offer my type definitions :)
It does technically limit the functions you can call, but I've typed everything that's part of api-docs.md.
Please LMK if you'd like me to type anything else!

Hi, thank you for the PR ! I'll take a look at this when I'm free, maybe next week. Thanks once again!


Provide profile analyze query

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
#4104

New feature or improvement

Implement profile anayzation query, complete related e2e test.

Codecov Report

Merging #4335 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4335      +/-   ##
==========================================
- Coverage   27.01%   26.94%   -0.07%
==========================================
  Files        1176     1176
  Lines       25677    25740      +63
  Branches     3664     3672       +8
==========================================
  Hits         6936     6936
- Misses      18128    18191      +63
  Partials      613      613

Impacted Files
Coverage Δ

...oap/server/core/query/ProfileTaskQueryService.java
0% <0%> (ø)
:arrow_up:

...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java
0% <0%> (ø)
:arrow_up:

...lking/oap/query/graphql/resolver/ProfileQuery.java
0% <0%> (ø)
:arrow_up:

...p/server/core/profile/analyze/ProfileAnalyzer.java
33.33% <0%> (-44.45%)
:arrow_down:

...csearch/query/ProfileThreadSnapshotQueryEsDAO.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01829a...9dbabfa. Read the comment docs.


Linux Release VST3 binary file missing

Thank you for this interesting plugin.
I noticed that in the Linux release zip file only the standalone application is found while the VST3 plugin binary is missing:
ai-improviser-plugin-linux-v0.1/
├── ai-midi-improviser
└── ai-midi-improviser.vst3
    └── Contents
        └── x86_64-linux

Thanks for reporting this. I have updated the linux zip. Should be like this now:
No idea if it'll work on anyone else's linux but the cmake build should work if not.
ai-improviser-plugin-linux-v0.1
|-- ai-midi-improviser
`-- ai-midi-improviser.vst3
    `-- Contents
        `-- x86_64-linux
            `-- ai-midi-improviser.so

Thanks. It works fine now.


Command ExtractAPI failed with a nonzero exit code

Hi Philip, thank you so much for creating a great package/framework! I have been trying to make it work as a framework but it fails with 'Command ExtractAPI failed with a nonzero exit code' and it fails to find metal_stdlib file in the framework - "fatal error: 'metal_stdlib' file not found". I am working with iOS SDK 16.2. Not sure if that's something to do with it. I am new to metal (and to AR) so not quite sure how to fix this issue. I am quite sure I followed the tutorial for 'Reconfiguring ARHeadsetKit' to the T. I tried setting the header paths in the settings but to no avail. What might I be doing wrong?

I made these tutorials over a year ago. There should be some way to make this work - Xcode is just different now. Have you gotten the Xcode framework to compile without using any Metal shaders? Try just copying and pasting the MetalUtilities.h file verbatim, like a file you authored in your own Xcode project.

Would you be able to build it using the latest SDK and confirm if it's working for you? In the meanwhile I'll try your suggestion.

I found the problem. In the Xcode project I see when committing ARHeadsetKit to GitHub, everything is correct. The headers appear under "Headers" in the project build phase. But when I download using Git Submodules, the headers magically migrate to "Compile Sources". I also had to rename them from .h to .h.metal because the compiler was flagging them as C or C++ files. Use Cmd + F and search-replace to rename all of these headers with the new extension. That should update the include macros in your source files and ARHeadsetKit's source files.

ARObjectUtilities.h -> ARObjectUtilities.h.metal
ColorUtilities.h -> ColorUtilities.h.metal
MemoryUtilities.h -> MemoryUtilities.h.metal

Then, manually modify the names of the files themselves. They're located in the ARHeadsetKit.xcodeproj reference embedded into your source folder. Go into Project Settings -> TARGETS -> Build Phases -> "Compile Sources", and locate the changed files. They'll be difficult to distinguish from their implementation files, which share the same name but different extensions. The headers are the ones without Private in the file path. Drag those into the "Headers" section.
What I see in the cloned GitHub repository:

What the embedded submodule originally looks like:

What I changed the submodule to:

I don't think there's a seamless way to fix this problem, but I'll hyperlink this GitHub issue into the relevant tutorial. It might be a bug in Xcode.

Builds perfect now!!
Great job catching the problem and thanks once again for your assistance Philip!

Is there a way to keep in touch with you via email while I experiment with the framework? Please send me an email if you are okay. I'll delete this comment in a few hours. My email is: alok dot nagdev at_the_rate gmail dot com.
I would understand if you are not comfortable communicating via email.

I copied the contents of the comment into a private Google Doc. I prefer to discuss over public if possible, just to make stuff reproducible. But if you are more comfortable discussing over email (e.g. privacy reasons), I can do that too.


Android "SSL Error: Hostname Mismatch"

Bug description:
When I use the WebView on expo with an external uri which I'm not the owner (I'm doing an SSO page), if I open on iOS everything works fine, but if I try on Android it gives me error code 2 and I can't open the webpage. I don't know how to solve this in a good way, I'm using react-native with expo sdk 39

Screenshots/Videos:

Environment:

OS: Android
OS version: latest
react-native version: latest with expo
react-native-webview version: latest

Having the exact same issue

Having the exact same issue.
I tryed to comment and add the handler.proceed(); in the onSslErrorHandler method inside the class of library WebViewManager of ract-native-webview, but Google rejected the binary when I try to publish the app.

Having the same issue. Worked with plenty of valid SSL domains, then got the same error on production suddenly :(

@nicollecastrog did you solve this? Same here. Sudden errors on production.


[AutoDiff upstream] Enable @differentiable on setters.

Enable @differentiable attribute on setters of properties and
subscripts in Differentiable-conforming types.
Upstreams https://github.com/apple/swift/pull/30178 from tensorflow branch. Resolves TF-1166.

@swift-ci Please test

Are there tests to verify that derivatives of differentiable setters can be computed end-to-end?

Yes, those tests (derivative registration and automatic differentiation of setters) actually already exist. It's just declaring setters as @differentiable that wasn't supported.
https://github.com/apple/swift/blob/4fb787a8103d9b963c94bec8cb57a145e3a91a60/test/AutoDiff/validation-test/derivative_registration.swift#L121-L153

Are there tests to verify that differentiable setters aren't causing issues related to TBDGen, -enable-testing, -g, or library evolution mode?

Just added TBDGen tests, thanks for the reminder!

Are there tests to verify that derivatives of differentiable setters can be computed end-to-end?

Yes, those tests (derivative registration for and automatic differentiation of setters) actually already exist. It's just declaring setters as @differentiable that wasn't supported.

Thanks for the pointer. However, I was mainly asking about whether the automatically differentiated setters are tested. In the file you pointed it seems to be only testing a manually registered derivative.

However, I was mainly asking about whether the automatically differentiated setters are tested.

Here's one: https://github.com/apple/swift/blob/7afb399610b7bbcd8b3d29754bded64a0f1a3787/test/AutoDiff/validation-test/inout_parameters.swift#L112-L131
I think that's decent for the purposes of this PR - happy to add more if you'd like to test specific cases.

@swift-ci Please test

I think that's decent for the purposes of this PR - happy to add more if you'd like to test specific cases.

I'm sorry my suggestion was not super clear. The test that you pointed to, i.e. inout_parameters.swift, totally counts as a case of "automatically differentiated setters", but it feels slightly less relevant to this patch because it is not using a @differentiable attribute to trigger differentiation on the setter, which is the feature introduced by this PR.  Does this clarify my suggestion?

Build failed
Swift Test OS X Platform
Git Sha - 644a347ba0cb68e510b9258ef8fb8b85e6145da6

Does this clarify my suggestion?

Yep, thanks! Added an automatically differentiated @differentiable setter test.

It would be be good to have a cross-module test suite (in the future) that verifies automatically differentiated functions (triggered by @differentiable attribute) can be taken the derivative of in a different module, for not just computer property setters but all decls. I'm suggesting this because we are exporting and finding differentiability witnesses using the AST @differentiable attributes.

Good idea! More cross-module tests in general sound great, there've been some latent autodiff issues discovered in SwiftPM packages but not caught by the test suite.

@swift-ci Please test


New endpoint to remove all jobs on a queue

Closes #751

Coverage increased (+2.8%) to 80.327% when pulling 37c005a4972154f748c64b80932a1f49bee15fe7 on remove-all-jobs-on-queue into 5891c2e08a30e7c155b6e02a4c15db2db87d204f on main.


[GUI] Device: Attrs the default value or the specialized value

The GUI should have demonstrated that  is using the default value or the specialized value in static values on attrs and metas..
For example using italic to default value.

#924
#1033

It will no longer be applied.


Add more postgres support

Also cleans up authData handling a bit. Note that in order to create the username/email unique constraint in Postgres, that means the _User class needs to exist, so we are now creating it when the server starts.

[Current coverage][cc-pull] is 91.91%

Merging [#2080][cc-pull] into [master][cc-base-branch] will increase coverage by 0.47%

@@             master      #2080   diff @@
==========================================
  Files            93         93
  Lines          6692       6715    +23
  Methods        1183       1192     +9
  Messages          0          0
  Branches       1401       1410     +9
==========================================
+ Hits           6119       6172    +53
+ Misses          573        543    -30
  Partials          0          0

Powered by Codecov. Last updated by [627b416...aede3af][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ParsePlatform/parse-server/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ParsePlatform/parse-server/compare/627b4164bbde9342a600a38914394f25cbf9238c...aede3af247da1de6ec524900ac6c3417e20039fe
[cc-pull]: https://codecov.io/gh/ParsePlatform/parse-server/pull/2080?src=pr

nice! looks super clean.

Is this a Postgres database adapter ? Can I use to replace mongodb ? When is the official release ?

Can I try it ? Super excited !


Add server host and port command-line arguments to Project Manager

Pull Request Description

Closes #6730

Adds --serverHost and --serverPort (?) command-line arguments, and logic to open a Project Manager instance.

Important Notes
:warning: Port scanning is only implemented in the JS frontend. It is not implemented:

In Scala, because the JS/Rust code calling it needs to know the port as well. There shouldn't be any problems with adding port scanning though, if that's desired

In Rust, because I'm not sure parsing the host and port from a string is a good idea.

(This also applies to JS, but it must work in JS, and port scanning is already a dependency there so it's quite a bit easier)

QA will need a new PM (sbt buildProjectManagerDistribution or ./run backend sbt -> buildProjectManagerDistribution), and the path must be supplied as: -engine.project-manager-path=path/to/new/pm/here

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

not sure this needs tests on the scala side

So it seems like running two instances side-by-side by the same user should be unsupported - the Project Managers seem to want to acquire locks on the same files for compilation. So, when testing, instead a dummy HTTP server should be run on port 30535

closing until this becomes an issue again

i've done some basic testing only - by using ide watch with a http server running at port 30535:

:heavy_check_mark: opening new empty project works on local backend
:heavy_check_mark: opening new project from template works on local backend
:heavy_check_mark: opening project works on remote (cloud) backend

oh oops

i've done basic re-testing so there shouldn't be any major problems

@PabloBuchu this should be QAd at some point too btw

just tried build and run normally and it is trowing errors

@JaroslavTulach @4e6 could you do a QA of the part with the PM port?

pushed a commit that may fix it, unable to test due to issues with linux PM bundle

I did the QA. It seems to work on my Linux machine

[x] Started the project manager on a custom port env SERVER_PORT=30536 java -jar $JAVA_OPTS project-manager.jar -vv and then connected to it from the browser http://localhost:8080/?authentication=false&engine.projectManagerUrl=ws://<IP_ADDRESS>:30536
[x] Built the IDE distribution with ./run --skip-version-check ide build --skip-wasm-opt and started it with ./dist/ide/enso-linux-2023.2.1-dev.AppImage -authentication=false --debug.dev-tools without errors in the console.


Create new minecraft-server chart

Following discussion in #225, opening this up to contain the conversation in regards to the creation of a chart to refactor and ultimately replace the existing minecraft chart. This new chart will be named minecraft-server to pair with itzg/docker-minecraft-server.
Goals of the refactor:

Simplify and standardize. Refer to practices defined by industry-leading charts
Implement base features and allow for flexibility. Don't implement every possible feature and value.

Refer to the docs site to provide more comprehensive examples

Create a "feel" comparable to itzg/docker-minecraft-server. Using the chart shouldn't feel like learning a new tool

It was suggested that merging minecraft-bedrock into this new chart could be a goal, but it was agreed that this should be more of a long term goal. This effort should be closer to a rework of the existing chart, keeping in mind that it may need to be flexible to later include the bedrock chart.

Some questions I ran into while doing initial rework:

Do we need to support a Deployment and StatefulSet type? I've always been under the impression that Minecraft can't run dual-instance in any circumstance, so using StatefulSet seems like the right option, but other charts seem to be using Deployments with strategyType: Recreate. This effectively does the same thing as a STS, so I'm interested in knowing more about the potential use-case. IMO, supporting both seems unnecessarily complicated. My sentiment matches the below references, I feel a StatefulSet is supportive of the expectations a Minecraft server has (one instance and only ever once instance)
#84
#163

Perhaps someone like @Robbilie could help here. (Ref: #98)

How, if at all, should the chart maintainers list be revised? I don't feel that I'm in a good place to make this decision, and wanted to toss it out there since there may be opportunity for cleanup.

Should we build in / hint at the integrations for other charts, such as mc-router and mc-monitor? This could be things such as commented service annotations and  service monitors that are disabled by default. I personally like this option, because it supports other parts of the itgz ecosystem.

I'm still leaning towards StatefulSet with no setting to go beyond one replica. A StatefulSet actually extends all the features of Deployment including being a ReplicaSet...but as you mentioned there can only ever be one replica active for the server data volume at a time.

Myself and @billimek are the only active maintainers. So the two of us and yourself would be appropriate as chart maintainers IMHO

Loosely integrating would be nice somehow vs bringing all of those parts over.

That latest build failure sounds similar to something that was fixed recently
https://github.com/itzg/minecraft-server-charts/pull/222
Perhaps double check you started from the very latest revision or just bring any deltas.

In regards to my past PR:
I built a software in front of the Minecraft Servers to keep them in sync. Behind this proxying software normal Minecraft Servers are used, for that I was using this chart.
Without an external way of keeping sync more than one replica will not be the desired use of this chart but as stated back then I would have otherwise had to create a fork of this chart and I was really grateful that instead we went with the replicaCount value and the big warning. I would appreciate keeping this :)


Adjust the checkIfOnline check if in a corporate proxy environment

Adjust the checkIfOnline check if in a corporate proxy environment
If the environment variable https_proxy is set, test that the proxy name is resolveable rather than 'registry.yarnpkg.com'.
Testing on a corporate network where proxies are required.  Prior to change, installation fails as per #2832, post change installation works happily.
Before:

After with proxy set & required:

After with proxy not set, but required:

After with proxy set incorrectly:

Neat, thanks for fixing that so quick!
Does this fix it for you when running it locally with the patch installed by hand?

Yes.  I tested by calling the script directly, rather than the globally installed version.
Screenshots are in the first PR comment.

Hmm, I wonder if we should always test registry.yarnpkg.com first, followed by proxy if set.
I'm not sure of edge cases we might want to account for, and I like to be careful with the global CLI.
What do you think?

I agree with the caution.  Proxies and people's configurations are always troublesome.
Seems like a decent approach to try yarn first, then if that fails and a proxy is set to try the proxy.

Great, thanks so much for this!

Hi there! This change is out in<EMAIL_ADDRESS>please give it a go! Thanks.

Great. I'll update first thing tomorrow.
Thanks for your thoughts on this.

Well, I guess in this case<EMAIL_ADDRESS>

This is insufficient in some corp environments, where they run an internal registry with no direct access to the Internet even via a proxy.
I don't understand why this offline check code exists - yarn will already use its local cache if the network is unavailable so you shouldn't need to add the --offline flag in the first place?


Vertical and Horizontal Headers?

This is a dumb question but how can we achieve this kind of table?
         header1 header2 header3
header1    1        1      1
header2    2        2      2
header3    3        3      3

Just use one header for all columns and hide it.
See https://github.com/tannerlinsley/react-table/issues/2407

@wassim I am also situated  to form a kind of table you asked. any luck for you? did you achieve it?
Please do the needful.


Web-Framework (actix-web) alternatives for future API design

Describe the enhancement

Is there any specific reason actix-web was chosen for this project? I would like to recommend axum instead of actix-web for future API development on this project. There are several bitcoin related project already using axum like mutiny, fedimint, sensei, 10101, bitmask etc.
One analysis and comparison between axum and actix-web by fedimint during their early stage development could be some reference:
https://github.com/fedimint/fedimint/issues/155#issuecomment-1159813304
Use case

I would like to enhance this project for future API development to develop endpoint similar to https://api.nostr.band and use it in app and web, it would be easier for me to contribute to this project if axum was used since it has better ergonomics in my opinion. But that's just my perspective, actix-web could be used to serve the same purpose.
Additional context

If using axum is accepted, I can try to convert this project to axum in a upcoming pull request since it's still relative easy to do the conversion at this stage.

IIRC, I had chosen it for the benchmarks and because I was already familiar with it.
I had done some tests in the past and it was able to handle ~50000 req/sec on my laptop. Not remember about axum.
I checked actix and now it uses tokio and not async-std.
We can do some tests and see what way is better, both in terms of performance (RAM/CPU usage, req/sec, ...) and code complexity.

I haven't done the test by myself yet, just did a quick search for benchmarks:
For req/sec actix does slightly better than axum based on this website, but they are both in top three in all major rust web frameworks.
https://web-frameworks-benchmark.netlify.app/result?l=rust
For RAM/CPU usage it seems axum performs slightly better than actix, but not much differences.
https://github.com/programatik29/rust-web-benchmarks/blob/master/result/hello-world.md
For micro benchmarks axum performs slightly faster than actix.
https://www.techempower.com/benchmarks/#hw=ph&test=composite&section=data-r22
Regarding code complexity, maybe I can try to add equivalent axum examples on my fork and do some comparisons.

Please refer to #24 for comparison.


Report does not contain custom name when custom name is defined through name parameter of captureScreenshot

Expected behaviour
The generated report should use the custom name defined using name parameter as the test name.
Actual behaviour
The generated report uses the actual test method name as the test name. Even though the screenshots are named correctly.

Steps to reproduce

Call createScreenshot with a custom name:

    @Test
    fun testActivity() {
        val activity = launchActivity()
        compareScreenshot(activity, name = "aCustomName")
    }

Run ./gradlew executeScreenshotTests -Precord
Change the UI to make the comparison fail
Run ./gradlew executeScreenshotTests
Check the generated report in build/reports/shot/verification/index.html

Version of the library
com.karumi:shot:4.3.0

Seems like the generated metadata.xml does not have the correct test-name element. This can probably be fixed easily by calling setTestName of the screenshot here: https://github.com/Karumi/Shot/blob/master/shot-android/src/main/java/com/karumi/shot/ScreenshotTest.kt#L131
Let me know if you want me to create a PR for this

Hi @malvinstn thank you so much for the detailed issue. It could be great if you want to contribute 😃 I'll personally review your changes and release a new version with the fix 😃

I tried to dig at the implementation deeper, and it seems like Facebook lib that shot is using does not expose the setTestName method on the RecordBuilder interface. I'll try to bring this issue to Facebook's lib instead.

Sorry for the late response @malvinstn I broke one arm and I've been out for some time. As you mentioned, there is nothing we can do until https://github.com/facebook/screenshot-tests-for-android/issues/255 is fixed. I'm closing the issue in the meantime.


When is js begin and js finish required for code or steps - some examples here

user query
在 TagUI steps 说明里并找不到  split 语法，
但TagUi 里，可以直接用split ： lasttime=lasttime.split(' ')[1]
而不需要放在   js  begin   ...  js finish  里面。
请问，这是为什么？哪些 Steps 之外的命令，可以不用放在   js  begin   ...  js finish  里直接使用？

I can't find the split syntax in the TagUI steps description,
But in TagUi, you can use split directly: lasttime=lasttime.split(' ')[1]
Instead of putting it in js begin ... js finish.
excuse me, can you tell me the reason? Which commands other than Steps can be used directly without putting them in js begin ... js finish?

js, js begin and js finish are used in the following ways -
js 1-line JavaScript code

js begin
JavaScript code line 1
JavaScript code line 2
JavaScript code line 3
js finish

Whenever there is some JavaScript code (anything other than the TagUI steps or helper functions), above will be required. However, TagUI can "smartly" detect the following 3 situations where JavaScript is used but js is not required.
1. Variable assignment
When a variable is being assigned, TagUI can detect the = symbol and automatically treat that line as JavaScript code, without the user needing to explicitly use js or js begin/js finish.
name = "Johnny"

2. Line ending with ;
If a line ends with ; character, and that line cannot match any TagUI steps, then it is treated as JavaScript code.
// quits TagUI using JavaScript exit() function
this.exit();

Copying @ruthtxh on this user question as I've left AI Singapore

谢谢，原来是这样的，我会记录下来，并更新到中文文档内。


Add meshnet grpc-wire option

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.806%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2566

Relevant Lines:
4220

💛  - Coveralls

/gcbrun

/gcbrun


Search index images for multiple organizations

Modify get_operator_indices method for searching index images for
multiple organizations.

@apaplaus , @mprahl , review please


Proposing a PR to fix a few small typos

Issue Type
[x] Bug (Typo)
Steps to Replicate and Expected Behaviour

Examine rediscluster/client.py, rediscluster/connection.py, tests/test_cluster_node_manager.py and observe specefied, however expect to see specified.
Examine tests/test_commands.py and observe impelmentation, however expect to see implementation.
Examine CONTRIBUTING.md, tests/test_commands.py and observe uptream, however expect to see upstream.
Examine tests/test_cluster_node_manager.py and observe itterate, however expect to see iterate.
Examine docs/logging.rst and observe reccommended, however expect to see recommended.
Examine docs/pubsub.rst and observe recieved, however expect to see received.
Examine tests/test_encoding_cluster.py and observe preffered, however expect to see preferred.
Examine docs/pubsub.rst and observe posiblity, however expect to see possibility.
Examine docs/upgrading.rst and observe intervall, however expect to see interval.
Examine docs/index.rst and observe exmaples, however expect to see examples.
Examine docs/development.rst and observe documentaion, however expect to see documentation.

Notes
Semi-automated issue generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md
To avoid wasting CI processing resources a branch with the fix has been
prepared but a pull request has not yet been created. A pull request fixing
the issue can be prepared from the link below, feel free to create it or
request @timgates42 create the PR. Alternatively if the fix is undesired please
close the issue with a small comment about the reasoning.
https://github.com/timgates42/redis-py-cluster/pull/new/bugfix_typos
Thanks.

@timgates42 CI resources are free from TravisCI so just post the PR already

Thanks @Grokzen have done so


Undocumented C# Keyword

Reading through CA2230, it mentions __arglist as a C# Keyword. I never knew the existence of such keyword in C#.
Searching through the documentation doesn't give any results (To be accurate, only results in error messages, not actual documentation for the keyword).
So, I suspect the documentation is missing this keyword.
The documentation for that keyword should also include a note that it's preferred to use params.

I believe __arglist (and keywords related to it) is intentionally undocumented, because it shouldn't be used. That's also why it starts with double underscore. I don't think there's any reason to start documenting it now.

@svick, Thanks for answering. But are there any rare scenarios where one would use __arglist? for interop with C/C++ for example? or it's always bad to use it?

The last section of identifies in the C# spec has the following text:

Identifiers containing two consecutive underscore characters (U+005F) are reserved for use by the implementation. For example, an implementation might provide extended keywords that begin with two underscores.

I think that is sufficient. I recommend closing this.


Added variables

Added a few variables:
Held items:
%player_mainhand_displayname% = Main hand's display-name (if not null)
%player_offhand_displayname% = Offhand's display-name (if not null)
%player_mainhand_durability% = Main hand's durability
%player_offhand_durability% = Offhand's durability
Armor slots:
%armor_helmet_displayname% = Helmet displayname
%armor_chestplate_displayname% = Chestplate displayname
%armor_leggings_displayname% = Leggings displayname
%armor_boots_displayname% = Boots displayname
%armor_helmet_durability% = Helmet's durability
%armor_chestplate_durability% = Chestplate's durability
%armor_leggings_durability% = Leggings' durability
%armor_boots_durability% = Boots' durability

Thank you for doing this!
We will make some future adjustments before releasing a new update since there are still some bugs/issues we need to fix!!
Also I migth make an Expansion for this instead of having it in IBR itself. I will let you know if I change it to hard.

Thanks! If it does eventually become an add-on, I'd love to make tons of variables for it and whatnot.
Keep me up to date!

I talked to the owner of the player expansion, and told him about these placeholders. He says that you or me could add them to the player expansion. So that's what I'm going to do. Here is the link to the Player-Expansion github, so you could add even more PLAYER based variables... you migth have to ask if it's allowed to add certain placeholders...


Make continuation FnOnce

This generally makes code a little bit nicer

Yes, this is a breaking change.

The only reason to make the change is to structure the code in the library with less hassle? In Rust, we normally expose the most generic function type to library users, which is Fn in our case. Yes, FnOnce may look nicer in the library bowels, but I don't think we should introduce this change for just this reason. In addition, this would break someone's code.

While it's true that this change makes calling the continuation more restrictive, at the same time it makes writing the continuation a lot less restrictive. We lose ability to call continuation multiple times (that we didn't use anyway) but gain ability to move stuff into the closure, to set flags from inside it, etc. There really isn't any reason for the continuation to be Fn.

[...] the most generic function type to library users, which is Fn in our case

Not really, as said before: it's more permissive to call, but not to provide.

In addition, this would break someone's code.

While this could of course be the case, this is highly unlikely. For this change to break something a user would need to be writing their own handlers (instead of using tools provided by this library) and calling the continuation multiple times (Fn is trivially FnOnce so providing continuation can't be broken).


pegasus meta 进程内存泄露

Bug Report
最近看到pegasus meta 的primary进程内存一直在增长，
版本： v1.11.1
用pmap 看到
root@iZwz9a47t80hnkbpiuyzoeZ:/proc/29363# pmap -d 29363
29363:   ./pegasus_server config_meta.ini -app_list meta
Address           Kbytes Mode  Offset           Device    Mapping
0000000000400000    7004 r-x--<PHONE_NUMBER>000000 0fd:00010 pegasus_server
0000000000cde000     112 rw---<PHONE_NUMBER>000000 000:00000   [ anon ]
0000000001f58000 11359232 rw---<PHONE_NUMBER>000000 000:00000   [ anon ]
用valgrind --tool=memcheck --leak-check=yes --show-reachable=yes --run-libc-freeres=yes --log-file=./valgrind_report.log ./pegasus_server  config.ini -app_list meta
==26730== Mismatched free() / delete / delete []
==26730==    at 0x4C2EF90: free (vg_replace_malloc.c:540)
==26730==    by 0x5EA5719: deallocate (new_allocator.h:110)
非常多Mismatched free，
==26730== HEAP SUMMARY:
==26730==     in use at exit: 35,786,093 bytes in 61,548 blocks
==26730==   total heap usage: 118,319 allocs, 56,771 frees, 86,003,342 bytes allocated
==26730==
==26730== LEAK SUMMARY:
==26730==    definitely lost: 2,477 bytes in 51 blocks
==26730==    indirectly lost: 4,288 bytes in 90 blocks
==26730==      possibly lost: 89,490 bytes in 253 blocks
==26730==    still reachable: 35,689,838 bytes in 61,154 blocks
==26730==                       of which reachable via heuristic:
==26730==                         newarray           : 18,752 bytes in 1 blocks
==26730==         suppressed: 0 bytes in 0 blocks
==26730== Rerun with --leak-check=full to see details of leaked memory
==26730==
==26730== For lists of detected and suppressed errors, rerun with: -s
==26730== ERROR SUMMARY: 49352 errors from 1000 contexts (suppressed: 0 from 0)

Fixed by https://github.com/XiaoMi/rdsn/pull/477


#1793 renamed arguments

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[x] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Not sure the CI/CD stuff runs properly if "@devel" is not in the branch name (? @bms63), if you want to save some trouble with the merge conflict too, might be easier to start a fresh branch off devel then apply your changes again

Definetely need @devel for everything to run properly.

Definetely need @devel for everything to run properly.
Oh thanks @zdz2101 @bms63 I totally missed that!
So it looks like I need a longer branch name :)


Tracing: update semconv to v1.23.1

Fixes #37440 and #37441

API change check
API changes are not detected in this pull request.

@alzimmermsft @trask could you please take another look?

we won't have support for stable semconv in Application Insights Java agent until mid-Jan
this isn't a problem for semconv changes in azure-core-tracing-opentelemetry since we inject specific compatible version at runtime, but it may be a problem for semconv changes in azure-core

great point!
So let me change this approach to:

keep (for now) old attribute names in azure-core
add mappings to the plugin instead
merge this PR
update plugin version in otel agent
let it settle for a month or two then update core and remove mappings as a final cleanup before we declare HTTP tracing stable


No registered resource provider found for location 'westus' and API version '2018-01-01-preview' for type 'virtualNetworks'

Upgraded az to the latest version available via brew on Mac running Big Sur.  Trying to set up peering for Mongo Atlas per their instructions.  When running
atlas> az role definition create --role-definition peering-role.json
No registered resource provider found for location 'westus' and API version '2018-01-01-preview' for type 'virtualNetworks'. The supported api-versions are '2014-12-01-preview, 2015-05-01-preview, 2015-06-15, 2016-03-30, 2016-06-01, 2016-07-01, 2016-08-01, 2016-09-01, 2016-10-01, 2016-11-01, 2016-12-01, 2017-03-01, 2017-04-01, 2017-06-01, 2017-08-01, 2017-09-01, 2017-10-01, 2017-11-01, 2018-01-01, 2018-02-01, 2018-03-01, 2018-04-01, 2018-05-01, 2018-06-01, 2018-07-01, 2018-08-01, 2018-10-01, 2018-11-01, 2018-12-01, 2019-02-01, 2019-04-01, 2019-06-01, 2019-07-01, 2019-08-01, 2019-09-01, 2019-11-01, 2019-12-01, 2020-01-01, 2020-03-01, 2020-04-01, 2020-05-01, 2020-06-01, 2020-07-01, 2020-08-01, 2020-11-01'. The supported locations are 'westus, eastus, northeurope, westeurope, eastasia, southeastasia, northcentralus, southcentralus, centralus, eastus2, japaneast, japanwest, brazilsouth, australiaeast, australiasoutheast, centralindia, southindia, westindia, canadacentral, canadaeast, westcentralus, westus2, ukwest, uksouth, koreacentral, koreasouth, francecentral, australiacentral, southafricanorth, uaenorth, switzerlandnorth, germanywestcentral, norwayeast'.
atlas> az version
{
  "azure-cli": "2.21.0",
  "azure-cli-core": "2.21.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {}
}

I have seen similar issue https://github.com/Azure/azure-cli/issues/13827 but that was referencing a new API and temporary resolution was to downgrade.  This seems to use an older API version from 2018?

@jiasli for awareness

Could you run the command with --debug and share the output?


redux - update libraries and add github.io page as ericP@jd

We should delete these and start a fresh PR when your CLA situation is finalized. ok?

Ok I tried making a new PR with same content but it has canonicalized us back to this issue #43
I think I can get the CLA scan re-run, when the CLA is approved on your side.
At least the CLA failure here has the right committer ID:

The following contributors were found for this pull request:
❌ https://github.com/google/schemarama/commit/6d7f2be62fb47f309b89c67c2b846b1333d22c4e Author: @ericprud<EMAIL_ADDRESS>

Schemarama's own tests were unhappy, but detailed logs have been purged already. How to re-run?

Seems like closing and re-opening PR is enough to re-run all tests. Ignore what it says in #41 about the ericP-changes branch having uncommitted changes - afaik they were all merged here.


BuildStream CI is not configured to perform any system level testing

See original issue on GitLab
In GitLab by [Gitlab user @tacgomes] on Jul 25, 2018, 15:32
Summary
BuildStream CI should be configured to perform some system tests overnight.
A candidate for system testing would be building a known ref of freedesktop-sdk.

BuildStream version affected: /milestone %BuildStream_v1.x

In GitLab by [Gitlab user @tacgomes] on Aug 3, 2018, 13:59
This is blocked by #500 .

In GitLab by [Gitlab user @toscalix] on Aug 3, 2018, 14:23
marked this issue as related to #500

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:15
mentioned in commit 50523bd1ecfe948b325841b6a4add44cc20239df

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:18
mentioned in commit 0e1e475c492ad0e9c3807c3a9795e3b62fafd53b

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:24
mentioned in merge request !826

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:38
mentioned in commit 83ab183ef3a5b111c4d8772825deabd0d4719aeb

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:39
mentioned in commit 56233ffd7a1b9b3b88f762929213e1c79152f5cf

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 17:41
mentioned in merge request !827

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 18:03
closed via merge request !826

In GitLab by [Gitlab user @tacgomes] on Sep 25, 2018, 18:03
mentioned in commit c859480665501fa805b0b8eac0b66641448d2d50

In GitLab by [Gitlab user @tacgomes] on Oct 1, 2018, 12:17
reopened

In GitLab by [Gitlab user @tacgomes] on Oct 1, 2018, 12:17
assigned to [Gitlab user @valentindavid]

In GitLab by [Gitlab user @tacgomes] on Oct 1, 2018, 12:18
Re-opening this because the pipelines are failing due lack of disk storage.
Once the machines are provisioned with more storage, the pipelines should be re-activated.

In GitLab by [Gitlab user @tacgomes] on Oct 1, 2018, 12:18
unassigned [Gitlab user @tacgomes]

In GitLab by [Gitlab user @valentindavid] on Oct 25, 2018, 16:04
I was thinking of disabling the small builder and re-activating the pipelines. But I discovered I do not have access to the builders on the gitlab CI configuration because they are assigned to the BuildStream group and not the project.
[Gitlab user @toscalix] Could I have access to it?
Or I could move them the the BuildStream project. Are there any other project in the group that will need to use those builders?

In GitLab by [Gitlab user @jjardon] on Oct 25, 2018, 17:13
[Gitlab user @valentindavid] they are needed for https://gitlab.com/BuildStream/buildstream-docker-images
You should have access now

In GitLab by [Gitlab user @valentindavid] on Nov 19, 2018, 15:03
We are now using DO for builders. We can close this.

In GitLab by [Gitlab user @valentindavid] on Nov 19, 2018, 15:04
unassigned [Gitlab user @valentindavid]

In GitLab by [Gitlab user @danielsilverstone-ct] on Mar 29, 2019, 08:55
closed


Let user explain additional financial hardships

Free form box added that allows litigants to say something about their financial situation if boxes for expenses don’t cover anything

Done


Context set doesn't check for presence of GPU in 0_handwriting_ocr.ipynb

When setting the context in the denoising section of 0_handwriting_ocr.ipynb, the code doesn't check for the presence of GPUs and therefore fails when no GPUs are available.
Based on other context setting code in the example, I would suggest that this line...
ctx_nlp = mx.gpu(3)
Should read...
ctx_nlp = mx.gpu(3) if mx.context.num_gpus() > 0 else mx.cpu()

Hi @fugumaki  Thank you for your comment.
Please submit a PR for this.


Create webhook between the forked repo on GitHub and the BuildConfig on OpenShift

So that changes pushed on GitHub can trigger a new build on OpenShift.

#139 PR reference


new [Partners]

Paul's notes:
This is new. Needs a new Google doc entry and block code.

Partners is a suggestion. We can change the name.

Update:

https://www.figma.com/file/toPXlIHGxdI2lUbKaMI6tz/Thinkingbox-Enterprise-ideas?node-id=1887%3A4896&t=uiZOapKfJXWNnv8z-1

Link out to a relevant work page if available, if not an option, link out to the brand landing page.


PodDisruptionBudget Structure

Looking at the definition of the PDB config structure:
https://github.com/Nalum/cert-manager-module/blob/763e31749b3b42a9128cda7976d3e67b89d506a6/templates/config/config.cue#L175-L179
As the fields minAvailable and maxUnavailable are mutually exclusive, I'm thinking it would be better to have this:
#PodDisruptionBudgetData: {
	enabled:         bool
	minAvailable:   int | #Percent
} | {
	enabled:         bool
	maxUnavailable: int | #Percent
}

This would require changes to the PDB resource definition:
https://github.com/Nalum/cert-manager-module/blob/763e31749b3b42a9128cda7976d3e67b89d506a6/templates/podDisruptionBudget.cue#L23-L34
And then the config setup:
https://github.com/Nalum/cert-manager-module/blob/763e31749b3b42a9128cda7976d3e67b89d506a6/templates/config/config.cue#L78-L86
As it would result in an error if either minAvailable or maxUnavailable are not set.
The current setup will fail at apply time, where timoni would validate the above.
@stefanprodan @yyvess do either of you have thoughts on this?

I think you can define it like this:
#OneOfPDB: {minAvailable: int} | {maxUnavailable: int}

#PodDisruptionBudgetData: {
	#OneOfPDB
	enabled:         bool
}

Yeah, that looks good. Did some testing with timoni mod show config and it was not happy with either of these. I ended up with the following:
#OneOfPDB: {minAvailable: int} | {maxUnavailable: int}

#PodDisruptionBudgetData: {
	enabled:         *false | true
	if enabled {
		#OneOfPDB
	}
}

But it's showing an issue with the parsing of the cue files in relation to the markdown generation table. If enabled is false then we don't get output for minAvailable or maxUnavailable, if it's true then we only get the one that's set.

This kind of issues will occur each time we want to add some intelligence on default values.
From my last change =>

if highAvailability is false => pdb are disable by default.
if highAvailability is true  => pdb are enable by default and minAvailable equals number of replicas - 1.

Personally I like the idea of the flag 'highAvailability' that change default values.
It's will really simplify the configuration for the end-user.
The highAvailability  flag is the equivalent to set these values =>
	controller: {
		replicas: 2
		podDisruptionBudget: {
			enabled:      true
			minAvailable: 1
		}
	}
	webhook: {
		replicas: 3
		podDisruptionBudget: {
			enabled:      true
			minAvailable: 2
		}
	}
	caInjector: {
		replicas: 2
		podDisruptionBudget: {
			enabled:      true
			minAvailable: 1
		}
	}


How do you set the playing game?

I've tested MANY commands to get my bot's game status, but none of them work. Any solutions?

The issue tracker is only for bug reports and enhancement suggestions. If you have a question, please ask it in the Discord server instead of opening an issue – you will get redirected there anyway.


Make debug statement in release mode an error

Suppose the debugging macro is oq3dbg. In release mode, this should print "Looks like you forgot to remove oq3dbg for release".
It's possible that one wants to do testing with optimizations turned on, so ideally there would be a way to make the check for oq3dbg later.  Is it possible to add a custom clippy rule?
I use println! as well. A similar macro for this case would be useful.
IIRC there is a macro like this in r-a and it is likely preserved (on purpose, for the arrival of this day) in this repo.

dbg! is fine, I think - clippy can lint against it, it's just not turned on by default.
cargo clippy -- --deny clippy::dbg_macro

Whoops - now the output:
    Checking oq3_lexer v0.0.1 (/Users/jake/code/qiskit/openqasm3_parser/crates/oq3_lexer)
    Checking oq3_parser v0.0.1 (/Users/jake/code/qiskit/openqasm3_parser/crates/oq3_parser)
    Checking oq3_syntax v0.0.1 (/Users/jake/code/qiskit/openqasm3_parser/crates/oq3_syntax)
    Checking oq3_source_file v0.0.1 (/Users/jake/code/qiskit/openqasm3_parser/crates/oq3_source_file)
    Checking oq3_semantics v0.0.1 (/Users/jake/code/qiskit/openqasm3_parser/crates/oq3_semantics)
error: the `dbg!` macro is intended as a debugging tool
   --> crates/oq3_semantics/src/syntax_to_semantics.rs:486:13
    |
486 |             dbg!(version.is_simple());
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#dbg_macro
    = note: requested on the command line with `-D clippy::dbg-macro`
help: remove the invocation before committing it to a version control system
    |
486 |             version.is_simple();
    |             ~~~~~~~~~~~~~~~~~~~

error: the `dbg!` macro is intended as a debugging tool
   --> crates/oq3_semantics/src/syntax_to_semantics.rs:487:13
    |
487 |             dbg!(version.clone());
    |             ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#dbg_macro
help: remove the invocation before committing it to a version control system
    |
487 |             version.clone();
    |             ~~~~~~~~~~~~~~~

error: the `dbg!` macro is intended as a debugging tool
   --> crates/oq3_semantics/src/syntax_to_semantics.rs:489:13
    |
489 |             dbg!((p1, p2));
    |             ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#dbg_macro
help: remove the invocation before committing it to a version control system
    |
489 |             (p1, p2);
    |             ~~~~~~~~

error: could not compile `oq3_semantics` (lib) due to 3 previous errors

@jakelishman I somehow missed your comment above. This issue sort of mixes dbg! and println!. The former
is fixed in https://github.com/Qiskit/openqasm3_parser/pull/47
I'll close this issue and deal with odd println!s if they become a problem

Yeah, I think once the package has passed the critical mass where we start requiring reviews before merge (we're not there yet), the println! problem (if there is one) will largely solve itself.


KCP exception when stopping client

Describe the bug
It's not 100% reproducible, but we have the following stack sometimes when stopping the client:
kcp2k.KcpTransport.<Awake>b__29_4 (kcp2k.KcpTransport)
kcp2k.KcpClient.OnError (kcp2k.KcpClient)
kcp2k.KcpPeer.TickIncoming (kcp2k.KcpPeer)
kcp2k.KcpClient.TickIncoming (kcp2k.KcpClient)
Mirror.NetworkClient.NetworkEarlyUpdate (Mirror.NetworkClient)
Mirror.NetworkLoop.NetworkEarlyUpdate (Mirror.NetworkLoop)

[IMPORTANT] How can we reproduce the issue, step by step:
Not 100% reproducible - I'm using it already in my game, so I can't provide a sample. Sorry, but the scenario is:

Use KCP Transport;
Start the client;
Stop the client.

Expected behavior
It's not supposed to throw an exception
Desktop (please complete the following information):

OS: Windows
Build target: Android
Unity version: 2021.3.36f1
Mirror branch: version 89.8.0 from Unity Package

Additional context
I wasn't able to reproduce on the Editor, but checking the code, I found this: https://github.com/MirrorNetworking/Mirror/blob/693a9999d66462d47ed17687092c4e1bf506b924/Assets/Mirror/Transports/KCP/KcpTransport.cs#L119C1-L120C1 and it seems that a similar issue reported in https://github.com/MirrorNetworking/Mirror/issues/3708 might be happening too.
We could just use OnClientError? too. WDYT?

@s0ckz you posted the stack trace, but what's the error message?

It's the same error in https://github.com/MirrorNetworking/Mirror/issues/3708:

@s0ckz can you confirm that you have this fix in your KcpTransport already?
https://github.com/MirrorNetworking/Mirror/commit/56a1aa096fd22ff54e952458772942cf18536a23

fixed!


ARROW-6004: [C++] Turn non-ignored empty CSV lines into null/empty values

@nealrichardson

👍 cool. Can you remove this skip and make sure the test passes? https://github.com/apache/arrow/blob/master/r/tests/testthat/test-arrow-csv.R#L125

I don't know anything about building or testing R, so I'd rather if you gave me a hand :-)

Or I can simply remove that line and cross my fingers...

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f35dd92). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4935   +/-   ##
=========================================
  Coverage          ?   89.09%
=========================================
  Files             ?      717
  Lines             ?   100450
  Branches          ?        0
=========================================
  Hits              ?    89492
  Misses            ?    10958
  Partials          ?        0

Impacted Files
Coverage Δ

cpp/src/arrow/csv/parser-test.cc
98.66% <100%> (ø)

cpp/src/arrow/csv/parser.cc
97.36% <100%> (ø)

python/pyarrow/tests/test_csv.py
98.62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35dd92...0b5db82. Read the comment docs.

Well, it didn't work, so you'll have to help me :-)
https://travis-ci.org/pitrou/arrow/jobs/563133627

Ok, I'll take a look.

My bad, the test expectation that was finally able to be executed was written wrong. Here's the fix:
--- a/r/tests/testthat/test-arrow-csv.R
+++ b/r/tests/testthat/test-arrow-csv.R
@@ -131,7 +131,7 @@ test_that("read_csv_arrow parsing options: skip_empty_rows", {
   tab1 <- read_csv_arrow(tf, skip_empty_rows = FALSE)

   expect_equal(nrow(tab1), nrow(iris) + 2)
-  expect_true(is.na(tail(iris, 1)[[1]]))
+  expect_true(is.na(tail(tab1, 1)[[1]]))
 })

Ok, trying it.

@nealrichardson Test still fails (see Travis & AppVeyor). It would be nice if you could take a look.

That appeared to work. Now we need a reviewer...

@fsaintjacques


NoValue should not throw exception on conversion to bool

This improves backward compatibility with 0.1.8
It's really hard to find all occurrences similar to
if signed_data.getComponentByName('crls'):
...
in large codebase.

Codecov Report

Merging #64 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
+ Coverage   83.69%   83.7%   +<.01%
=========================================
  Files          28      28
  Lines        3736    3738       +2
=========================================
+ Hits         3127    3129       +2
  Misses        609     609

Impacted Files
Coverage Δ

pyasn1/type/base.py
84.95% <100%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572dc1b...eb6ac59. Read the comment docs.

Thank you for you PR!
I'm not sure about unconditionally ignoring uninitilaized values approach. But your point (to  preserve backward compatibility as much as possible while code evolves) is really important!
Let me sleep it over, may be I could come up with something that fits the overall design...


Issue with CorrelationId header 'Request-Id' Duplicate operatoinId in AppInsights portal

Environment:
<EMAIL_ADDRESS><EMAIL_ADDRESS>Microsoft_ApplicationInsights_AspNetCore: 2.7.0
Microsoft_ApplicatoinInsights: 2.10.0
We are seeing duplicate operationId in AppInsightsPortal.
RequestId format by js sdk: | < rootid >  .< parentid >
On debugging, it looks like the correlation header 'request-id' added by appInsights-js sdk c
does not change rootid of the request but parentId
Two apis with different requestId but has same rootId
Issue Doc.docx
has the same rootid part due to which, server parses same rootid per user per session as operationId and we see it in portal. Is this a bug or configuration issues ?

For client-side SDKs, an operation id is only updated on a new pageview. If you refresh the page or view another page in your app, the rootid should update
https://docs.microsoft.com/en-us/azure/azure-monitor/app/correlation#example

Oh ok in that case, for a single page application, if we fire multiple request from same page , it will cause duplicate operationId in AppInsightsportal causing hard to view each individual request. Is there any other way to overcome ?

It seems like the Dependencies tab is showing the data you are looking for

Thanks @markwolff . For SPA how does correlation. From my understanding operationId do not change? How else can we ident
case 1: SPA ->(req1) svc1 ; SPA ->(req2) svc1
case 2: SPA ->(req3) svc1 calls svc2 and svc3; SPA ->(req4) svc1 calls svc3 and svc4 ?

You can configure your app to change operationId on each route change via enableAutoRouteTracking: true
https://github.com/microsoft/ApplicationInsights-JS#single-page-applications

Cool. thanks.


[Feature Request] KDE Plasma version?

Any chance of a spin or other option where KDE Plasma is the DE instead of Gnome?  Last June I moved from pop_os to my Steam Deck for my daily driver, and intend to build a new desktop soon, and would love to use Chimera, but would prefer to stick with Plasma for consistency sake.

We spent about a month evaluating multiple desktop environments before we added one, looking at the pro's and cons of each to determine the best fit for ChimeraOS. ChimeraOS is intended t o be a console experience by design where  the need f or the desktop is ideally none. Our mindset on the desktop is that it is a utility facilitator rather than a full fledged desktop experience. We needed something lightweight as the GH file size limit is 2GB (which is difficult  to manage even for a compressed image that contains an entire OS) and met the needs of users in the event there was a feature gap in one of the provided tools. Additionally, spinning up multiple distro's isn't  really something our update system supports.
If that is a dealbreaker for you there are a few options. All of our custom packages are available in the AUR and can therefore be installed on any arch system. Endeavouros can install KDE by default and be configured in a similar way. I use it on my desktop and laptop in that configuration. You can also spin up your own fork of ChimeraOS by following the guide in the wiki. Nobara is also an excellent choice based on RedHat.

This is just an excuse for using a macos like interface. The only difference between KDE Plasma and Gnome is the graphical interface.

This is just an excuse for using a macos like interface. The only difference between KDE Plasma and Gnome is the graphical interface.

Honestly, I've been all over the place.  OS-X for work for the last dozen years.  Gave up windows for gnome when pop-os was the hotness (2018 maybe?), and then moved to a steam-deck as my desktop when the laptop I bought from System76 died.  Then I decided to build a desktop and found that I wanted to stick with KDE.  Honestly tried Chimera after some blogger kept saying that SteamOS 3 stole everything from it, found that that blogger was being super-sensationalist, and then found a distribution that I did like that supported KDE.
I could really not care less whether kde or gnome is more or less windows or os-x like.  I care whether it works with the workflow that I've built over time.
Either way, the developers of Chimera have said that they're not supporting KDE and anything further is super off-topic.  If you want KDE with Chimera, you can do as the developers have said and fork it.  I honestly have no interest in being a distribution maintainer, so I haven't.

same, don't want that burden.


Broken build for 2.7 / 3.7

The Travis build is broken at the moment for 2.7 and 3.7. While I would drop the 2.7 support completely, it is interesting that 3.7 fails and 3.4 / 3.5 / 3.6 succeeds.
It's the TestTerminalReporter.test_xdist and TestTerminalReporter.test_xdist_verbose tests. Sadly, I have no clue what the issue is in there.
This one should be fixed before #208

I merged a PR that fixes the CI

Two 3.7 and one 3.8 build are still failing: https://travis-ci.org/github/Teemu/pytest-sugar

Yeah I noticed 😟
On Tue, 25 Aug 2020, 23:41 Martin Thoma<EMAIL_ADDRESS>wrote:

Two 3.7 and one 3.8 build are still failing:
https://travis-ci.org/github/Teemu/pytest-sugar
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Teemu/pytest-sugar/issues/209#issuecomment-680258767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANAMRJLG4YXDZRMS6AETDSCQOXBANCNFSM4QIQ5WHQ
.


install java 8 instead of 7

This should get Java 8 instead of 7.
(Didn't test out yet with new compilebox installation.)

Actually, running  sh UpdateDocker.sh didn't work. I'll look at it again when I get a chance. Here's the message I got:
Step 20 : RUN echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true |  /usr/bin/debconf-set-selections
---> Running in 0c1ac34a6647
---> fe4af2516454
Removing intermediate container 0c1ac34a6647
Step 21 : RUN apt-get -y install oracle-java8-installer
---> Running in 93a90520893f
Reading package lists...
Building dependency tree...
Reading state information...
The following extra packages will be installed:
gsfonts gsfonts-x11 libfontenc1 libxfont1 wget x11-common xfonts-encodings
xfonts-utils
Suggested packages:
[...]
The following NEW packages will be installed:
gsfonts gsfonts-x11 libfontenc1 libxfont1 oracle-java8-installer wget
x11-common xfonts-encodings xfonts-utils
0 upgraded, 9 newly installed, 0 to remove and 0 not upgraded.
Need to get 4492 kB of archives.
After this operation, 7776 kB of additional disk space will be used.


Who wasted their time on this?

Right click print save as PDF has already been a solution for this.. Let's use our skills to solve real problems going forward OK?

That was very unfortunate comment. If you don't experience html to pdf or any other experience, you will never going forward.

@Nick- Javascript, even when limited to the web browser, has an enormous range of applications, perhaps more than any other programming language.  Suppose you have 10 000 html sites that you want to convert to pdf.  Will you pay me whatever the going rate for such labour is in your area, to manually right click print save as PDF on every single one?  (If you will, please contact me, I could use the income 😂)
As a specific example, the company where I work uses this library in a visitor management application which runs on an iPad mounted in kiosks in the reception area of various offices.  Visitors to the office are asked to read and sign a safety agreement when they arrive, which is rendered in html.  In the background, the app automatically converts the signed copy to a PDF, uploads it to amazon S3, and sends the visitor an email with a copy of the agreement attached.  The company using this app can also access a web portal where they can view their visitors and see all of the signed agreements, for auditing/compliance purposes.
Your alternative is that the visitor should instead "Right click print save as PDF" (none of which exist in the iPad context), and then what?  Go into the Mail app on the iPad, and send themselves and their host a copy of this agreement, and then some kind of separate email scraping service will collect the PDFs into a single place for the host company to review later?

Good use case, thanks for explaining

This should be closed now.

To ChatGPT:

There's a dude on Github not understanding the great use cases html2pdf.js could have. He put a comment in the Issues section:
Right click print save as PDF has already been a solution for this.. Let's use our skills to solve real problems going forward OK?
Please help him out, by explaining to him why this project is important.

Its response:
Hi @Nick-
Thanks for sharing your perspective. You're right that the right-click, print, and save as PDF method provides a straightforward way to convert web content into a PDF format. However, html2pdf.js offers several key advantages that cater to more complex and automated needs which this basic method can't fulfill.

Programmatic Control: html2pdf.js allows developers to programmatically control the conversion process. This means that web applications can dynamically generate PDFs based on user interactions or data changes without requiring manual intervention from the user.
Customization and Consistency: While the print-to-PDF feature depends heavily on the browser and user settings, html2pdf.js provides consistent output across different environments. It also allows for more advanced customization, such as setting specific margins, page sizes, or even adding headers and footers, which are crucial for professional-looking documents.
Automation and Integration: In scenarios where PDF generation needs to be part of an automated workflow (like generating reports, invoices, or receipts in response to certain triggers), html2pdf.js becomes invaluable. It integrates seamlessly into the backend processes, unlike the manual print-to-PDF method.
Accessibility and User Experience: Not all users may find the print-to-PDF approach intuitive or accessible, especially those who are not tech-savvy. Having a one-click solution within the web application enhances user experience and accessibility.
Performance and Load Handling: For web applications dealing with high volumes of content or complex layouts, html2pdf.js can handle the conversion more efficiently, reducing the load on the client's browser and providing faster results.

In conclusion, while right-click, print, and save as PDF works for individual, ad-hoc cases, html2pdf.js extends the functionality to meet the needs of dynamic, automated, and professional web applications. It's about enhancing capabilities and providing solutions that cater to a wider range of scenarios.

I personally think ChatGPT is way too subtle for you. But now this 'issue' can be closed. And please try to be constructive on this platform.

close this please

Seems pretty useful as I have, for example, navigation buttons on a page that I don't want to be included in the PDF. and it provides users with a convenient "download PDF" button amongst those. Better UX.


Change between http/https using env vars?

Most probably like everyone else, my DW configuration uses env vars substitution. This works 90% of the time but fails to work when changing a config value requires adding or removing other config properties, like in our app connectors:
I've tried the following, in hopes of supporting both http and https:
  applicationConnectors:
    - type: ${APP_HTTP_CONNECTOR:-http}
      port: ${APP_HTTP_PORT:-8080}
      keyStorePath: ${APP_HTTP_KEY_STORE_PATH:-null}
      keyStorePassword: ${APP_HTTP_KEY_STORE_PASSWORD:-null}
      keyStoreType: ${APP_HTTP_KEY_STORE_TYPE:-null}

Which works for https when I provide the env vars above. The problem is, as soon as the type field is http, I get a config validation error:
  * Unrecognized field at: server.applicationConnectors.[0].keyStorePath
    Did you mean?:
      - port
      - bindHost
      - idleTimeout
      - useDateHeader
      - selectorThreads
        [20 more]

Because it's trying to set keyStorePath field on the HttpConnectorFactory.

Is this doable in some other way that I missed?
If not, do you agree that it's reasonable to support that functionality? If yes, we could start discussing possible simple approaches to supporting that kind of thing.

Possibly related: #3442

The problem is that you're trying to assign a configuration setting (keyStorePath) which doesn't exist in HttpConnectorFactory but only in HttpsConnectorFactory and the type field determines which of the factories to use.
So once type: http has been evaluated, Dropwizard (Jackson) will try to deserialize that part into an HttpConnectorFactory instance.

@joschi Exactly, that's my understanding too. Do you think there is some other way to achieve the end result? That is, be able to switch between http/https based on env vars.
Yesterday I experimented with an approach using YAML anchors. Basically:
x-http-connector: &http-connector
    - type: http
      port: ${APP_HTTP_PORT:-8080}

x-https-connector: &https-connector
    - type: https
      port: ${APP_HTTP_PORT:-443}
      keyStorePath: ${APP_HTTP_KEY_STORE_PATH:-null}
      keyStorePassword: ${APP_HTTP_KEY_STORE_PASSWORD:-null}
      keyStoreType: ${APP_HTTP_KEY_STORE_TYPE:-null}

server:
  type: default
  registerDefaultExceptionMappers: false
  applicationContextPath: /api
  applicationConnectors: *${APP_HTTP_TYPE:-http}-connector

I also annotated my Configuration class with @JsonIgnoreProperties({"x-https-connector", "x-http-connector"}).
I felt I was really close to get it to working, but I failed to get Jackson to properly handle the YAML anchor reference there.
I wonder if there are other approaches to that problem.

I wonder if there are other approaches to that problem though.

Use an environment variable to flex which config file is used.
set CONFIG_FILE=http_config.yaml
java -jar server.jar server $CONFIG_FILE
# or
set CONFIG_FILE=https_config.yaml
java -jar server.jar server $CONFIG_FILE

Another option is to have multiple application connectors active at the same time.
  applicationConnectors:
  - type: http
    port: 8080
  - type: https
    port: 8443
    keyStorePath: ...

@amr You could use a custom ConfigurationSourceProvider that can pre-process the config.yml file before Dropwizard parses it.
For example, I see the  dropwizard-template-config project looks like it would support what you are trying to do.

@pstackle That's very useful and I think could make that work indeed. Thanks for sharing that idea!


Sprint-6

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
Sprint 6 merge to main
Related Tickets & Documents
NA
QA Instructions, Screenshots, Recordings
NA
Added/updated tests?
NA
[optional] Are there any post-deployment tasks we need to perform?
No
[optional] Which Seattle Humane animal would you like to dedicate this PR to?
This nugget <3

I think this vercel deployment is failing because of this PR, https://github.com/digitalaidseattle/seattle-humane-app/pull/82, but it's not clear why that change was causing a problem


test command not running in watch mode

Current Behavior
yarn test isn't running in interactive mode
Expected behavior
to have tests run in interactive/watch mode.
Suggested solution(s)
run jest in watch mode when tsdx test is run.
Your environment

Software
Version(s)

TSDX
0.11.0

TypeScript
3.7.2

Browser
N/A

npm/Yarn
Yarn

Node
12.8.1

Operating System
MacOS Mojave version 10.14.4

i think this is good to have by default. would take a pr for that

I wonder if we can use bash's $@ as mentioned in this post:
https://stackoverflow.com/a/3816747/6107169

eh i think we have better ways to do that programmatically. but feel free to open up a pr and do what works!

what do you suggest?

not sure but check this out: https://github.com/jaredpalmer/tsdx/blob/c5f65bcdee60377886d721bc642cdb22c9f73db0/src/index.ts#L559-L581 and see how you'd change

@tylerthehaas, sorry if I misunderstood, but isn't yarn test --watch what you need?

Yeah all we should do is key off of whether CI=true IMHO

that works. nice 1-2 liner.

Previously I could use yarn test for a single run and yarn test --watch for watching. Is it no longer possible to make it run just once outside of CI now?

@MartijnHols  I use env var CI=true
"test": "CI=true tsdx test --color"
"test:coverage": "CI=true tsdx test --color --coverage"

or ctrl + C to kill :)

@MartijnHols @ambroseus we are reverting the "watch mode by default" behavior we added a month ago - sorry for the flipflop. more info https://github.com/jaredpalmer/tsdx/issues/408

Hi @sw-yx Sorry if this comes off as bad, but - why?
Right now I'm looking at a CI build that has timed out because running test without the watch flag seems to run it in watch mode anyway. Can we use angular cli as a model? --watch=true to enable watch, --watch=false to disable it. I think it's intuitive and straightforward.
In addition TSDX_AUTO_WATCH=false in #408 seems to still run in watch mode? I'm struggling to understand how to turn it off, and the docs don't help: https://github.com/jaredpalmer/tsdx/blob/master/README.md#tsdx-test


edgefirewall_&_edgefunctions_instance_firewall

I have prepared an update to the OpenAPI specification for Edge Firewall and Edge Functions Instances in the repository. The changes include the following:
For Edge Firewall:
Updated the OpenAPI specification to include endpoints for creating, listing, retrieving, updating, and deleting Edge Firewalls.
Replaced placeholder values in the template with the appropriate references for Edge Firewall.
Provided examples for the request payload and schema for Edge Firewall.
For Edge Functions Instances:
Updated the OpenAPI specification to include endpoints for creating, listing, retrieving, updating, and deleting Edge Functions Instances.
Replaced placeholder values in the template with the appropriate references for Edge Functions Instances.
Provided examples for the request payload and schema for Edge Functions Instances.

I have read the CLA Document and I hereby sign the CLA


Config was used from myenergi, this is a deprecated alias which will be removed in HA Core 2025.11

Logger: homeassistant.core
Source: helpers/deprecation.py:222
First occurred: 6 November 2024 at 23:29:50 (1 occurrences)
Last logged: 6 November 2024 at 23:29:50
Config was used from myenergi, this is a deprecated alias which will be removed in HA Core 2025.11. Use homeassistant.core_config.Config instead, please report it to the author of the 'myenergi' custom integration

Spotted this today myself.


readme: correct some mistake in tikv stack image.

region number

Coverage decreased (-12.3%) to 72.588% when pulling e5dc430604375300f6b935aa27bd076934843ce7 on c4pt0r/readme-image into 19bcf2a3a120a1be13cbed535eb4c4ae7abac9cc on master.

@ngaut @qiuyesuifeng @iamxy PTAL

Now node has only one store, so the stack image is not correct now.

Coverage increased (+0.3%) to 85.196% when pulling 737fba90d9d2ae8e656cf0b122264565b885e9a9 on c4pt0r/readme-image into 19bcf2a3a120a1be13cbed535eb4c4ae7abac9cc on master.

@siddontang If the node is a process, i think it's correct.

@ngaut I think the node is a physical machine.

LGTM

@qiuyesuifeng

LGTM


fix: Collect all failing versions before reporting

Included in https://github.com/palantir/log4j-sniffer/pull/20


Version 1

This brings in work for getting the repository to be usable.
Please Squash the request when accepting.

Reviewed and looks great!

Nice.  Merging.


add new trailmap files

Deploy preview for landscape ready!
Built with commit 4924194dc41ee5b240251be080dfd05373b393d6
https://deploy-preview-681--landscape.netlify.com


make einsum deterministic, correct.

Fixes a nondeterministic batch-dimension reordering error that was caused by using a python set collection ordering to fix the final output permutations

I don't need to sign CLA - I work at google. (just registered my account though.)

sigh.  I see there's a few broken einsum testcases that I should look at further to understand why they'd depend on the old set ordering...


Change how Terraform creates VPC private subnet architecture

Currently the Terraform creates 6 "private subnets":

3 from the VPC primary CIDR
3 from the secondary VPC CIDR for custom networking

The way this is done is the use the private_subnets parameter of the VPC module for all of them. This causes other Terraform that needs to retrieve the subnet IDs to be more complex than necessary, for example to get the first set of 3 subnet IDs you need to do something like:
private_subnet_ids = slice(module.aws_vpc.private_subnets, 0, 3)

We should explore if we can use other parameters for this, like intra_subnets or database_subnets. This will more cleanly separate the subnet ID outputs and make them easier to consume.

Terraform is no longer used to create the VPC infrastructure, closing


v0.42.0 - several updates

Fix filters that have search params larger than supported by the server. Solves (#274)
Removed to-fix link
Fix error when clearing date__gte filter field (#266)

👋 @willemarcel Thank you for the PR. I did some testing on the changes and found some bugs. For the sake of the context, I am pasting it here. We can cut out different tickets for each bug.

After I save the big bbox filter and load it by going to the profile page, and press apply, the dialog again comes up again. Do we want to avoid users doing this country size filter? Check 👇 video for more context.

https://www.useloom.com/share/f26d41f8f55b4dbea97bde833e4bc925

Clicking on the clear (x) icon on the bbox filter do not clear the polygon.

Can we use  https://github.com/mapbox/mapbox-gl-boundaries for disputed boundaries.

After I save the big bbox filter and load it by going to the profile page, and press apply, the dialog again comes up again. Do we want to avoid users doing this country size filter? Check point_down video for more context.

When you load a saved filter from your userpage it's already applied, so you don't need to click on apply, maybe we could include a message asking the user to wait the filter to load (big geometries generally takes a long time to load the results...)

Clicking on the clear (x) icon on the bbox filter do not clear the polygon.

This (x) only clears the text field, we have a Clear All button in the map that deletes the geometry. The (x) shouldn't appear when there is not text in the field. I'll try to work on that. I believe it would solve that issue. Do you have another suggestion?

Thanks, @tridip1931 !!


I was not able to use the King Plug

Version
3.2.1 (0770993)
Seed
R720-3MUE-ZNJG90B379F0002E8JXV6694XXGXZZMZZXXGZ0Y3XJZZZZZZZ
Scenario
RE 2 (Leon A)
Player Character
Leon (RE4)
What happened?
I was not able to use the King Plug. It was acting like it was inserted but it stays in my inventory and behaves like it is not inserted so I am not able to open the door.
Leon A_01_2024-01-06 16^18.30.zip
I hope the attached is the correct save file.

I am unable to reproduce this issue. Your saved game appeared to have the knight plug pickup missing and it was not in your inventory, or the item box. I added it via debug menu and was able to put that and the other plugs into the door correctly and open it.

I think I seen what is happening, in my inventory it says I have two king plugs, when you go into the debug it says that you have one of each plug but it still does not open th
Leon A_02_2024-01-08 22^44.37.zip
e door, the save filed should be attached.

Are we just forgetting about this, you can just close it.

@FrequentSword I can close it for now. Let me know if it ever happens again. I was unable to reproduce it and have never seen anyone else hit the same issue.


Client-side keepalive pings server enforcement

Servers responds to misbehaving clients by sending GOAWAY with error code ENHANCE_YOUR_CALM and additional debug data resembling “too_many_pings” followed by immediately closing the connection.
Servers will have the following settings for enforcement:

GRPC_ARG_HTTP2_MIN_PING_INTERVAL_WITHOUT_DATA_MS, defaulting to 5 minutes
GRPC_ARG_HTTP2_MAX_PING_STRIKES, defaulting to 2
GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS, defaulting to false

Client will increase the channel's keepalive ping interval exponentially if it receives GOAWAY with error code ENHANCE_YOUR_CALM and debug data equal to too_many_pings
Moved the change for enabling server-side keepalive pings to this PR, as the change is small but depends heavily on this PR.

@sreecha ping :sweat_smile:

No significant performance differences

No significant performance differences

No significant performance differences

Performance differences noted:
Benchmark                                             allocs_per_iteration    atm_add_per_iteration    atm_cas_per_iteration      cpu_time  locks_per_iteration      real_time  writes_per_iteration
----------------------------------------------------  ----------------------  -----------------------  -----------------------  ----------  ---------------------  -----------  ----------------------
BM_IsolatedFilter<CompressFilter, SendEmptyMetadata>                                                                                +8.50                               +8.50

No significant performance differences

@ctiller There were some fluctuations in performance differences. But they seemed unrelated to this PR.

Known issues:
Basic Tests Mac: #9804


'Add Exit Node' button missing in self-hosted setup

Describe the problem
A clear and concise description of what the problem is.
To Reproduce
Steps to reproduce the behavior:

Go to 'the Linux peer in the Peers page'
See the 'Add Exit Node' button missing from the page as described in (https://docs.netbird.io/how-to/configuring-default-routes-for-internet-traffic#make-the-peer-an-exit-node-routing-peer)

Expected behavior
As described in the documentation linked above a buttons should be visible
Are you using NetBird Cloud?
No, selfhosted
NetBird version
0.27.3

This was added ~1 hour ago: https://github.com/netbirdio/dashboard/commit/2272a1d2a46775ff1b0a8ead6da0fb3838498147

Oh :) only just started with NetBird and came acros the docs page. I assume this will be in the next release?


Make tag names for "buildah bud" optional again

Go back to having the set of names to assign to the resulting image being an optional argument when building a package using a Dockerfile.

Needs work.


Cilium pod failed to start on Ubuntu 22.04 Minimal

If you deploy your own Ubuntu VM, you should use a "normal" version; do not install "Minimal" as it's missing some (kernel?) components preventing successful startup of Cilium pod.
PS: Thanks for great presentation!

This ticket was raised only to document the finding; so closing as it's not a real issue.

Thanks for sharing the info!!


Passing a constant struct discards qualifiers on get_at function.

I get this strange error on a constant struct:
Passing 'const GTSubjectGenerations' (aka 'struct GTSubjectGenerations_s const[1]') to parameter of type 'struct GTSubjectGenerations_s *' discards qualifiers
The size function however, doesn't have this issue. Get at should be read-only, isn't it?

Hi,
The _get_at method may realloc the array to fit the size requirement (and automatically initialize the missing elements). It will never return NULL. So, the method doesn't take a constant array.
The _get method do not realloc the array and return NULL if there is no such index. The method takes a constant array.
I think it is the _get method you need in this context.

I see... Actually a very cool feature to have. I myself use a slightly different naming for such things though, get_ just feels a little bit "read-only" to me, so I use a word ensure instead. Still thank you for the reaction, and sorry for bother.

The documentation is contradicting to what you've said in your reply, so I leave the issue for now. Is that ok?

Yes, I say an error in the answer.
For an array, the _get method do not change the array and return the indexed index. It is up to the caller to check if the index exists.
For a map (or hashmap),  the _get method do not change the map and return the indexed index if it exists, or NULL if it doesn't.

But the docs say that both _get and _get_at never return NULL.

is that correct?

Yes.
For an array, name_get never return NULL since it assumes that i within the size of the array.
But name_get_at doesn't have such assumption.
Both never return NULL but for different reasons.

So there could be a segmentation fault, right?

More exactly, giving an out of bound index to _get raises a buffer overflow in release mode, an assertion failure in debug mode.

I see, I still think there may be some refactoring made for a clearer understanding of what's goin. Thank you. Closing the issue.


Attempt to index a nil value

Hi i have this error message on nvim, using rust-tools (rust_analyzer):
Error executing vim.schedule lua callback: ...ine-lsp-progress/lua/lualine/components/lsp_progress.lua:135: attempt to index a nil value
https://github.com/arkav/lualine-lsp-progress/blob/4d7c4e5cc7dc100280d66e240f670f40bdf601c9/lua/lualine/components/lsp_progress.lua#L135

Thanks @lfdominguez, I have created a pull request with a guard clause, that should prevent this issue (caused by a race condition). Cheers, Garrick.

Great, thanks to you.. I tested the PR and is working great.

Fix merged #4.


apply_folding_hinges_and_snaps() appears to give wrong results

The example for this function which I think is supposed to fold into a tetrahedron is screwed up, with the pins floating in space and the masks in the middle of the faces.  I assume this means something is broken in the code somewhere.

This was fixed a while back.


The installation of GPUStack failed due to the absence of the PATH environment variable

Describe the bug

The installation of GPUStack failed due to the absence of the PATH environment variable.
Steps to reproduce

Create a new user and add them to the sudo list.
Install GPUStack by executing curl -sfL https://get.gpustack.ai | sh -s -.
Verify the operational status of the GPUStack service.

Result

The logs of installation script.

pipx >(_symlink_package_resource:132): Force is true. Removing /Users/tester/.local/bin/gpustack.
  installed package gpustack 0.1.1, installed using Python 3.12.2
  These apps are now globally available
    - gpustack
pipx >(warn_if_not_on_path:474): ⚠  Note: '/Users/tester/.local/bin' is not on your PATH environment variable. These apps will not be globally accessible until your PATH is updated. Run `pipx ensurepath` to automatically add it, or manually modify your PATH in your shell's config file (e.g. ~/.bashrc).
done! ✨ 🌟 ✨
[INFO]  Setting up GPUStack as a service using launchd.
[INFO]  Install complete. Run "gpustack" from the command line. (You may need to open a new terminal or re-login for the PATH changes to take effect.)

After re-logging into the shell, the command for gpustack is still not found.

(base) tester@MyHostName ~ % gpustack version
zsh: command not found: gpustack

The GPUStack service has not started

(base) tester@MyHostName gpustack % ls
uninstall.sh

(base) tester@MyHostName ~ % cat /var/log/gpustack.log
cat: /var/log/gpustack.log: No such file or directory

Expected behavior

Environment

GPUStack version: v0.1.0
OS: MacOS 14.2.1
GPU: Apple M2, 24G

Additional context
Add any other context about the problem here.

Seems no longer valid

Cannot be reproduced in main.