Update license check, version and pre-commit

Previously both gave warnings.

Pre-commit as using Node.js 16
License check as error code was presented

Fixes #58
Now also changed so that license check is performed also on push
Changes tested (for python app) on this repo https://github.com/erikbosch/vehicle-example-app2
Example pre-commit

Previous build: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9464628807
New build: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9513024768

Warning only present in old build
Run unit tests and linters
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Example License check

Old run: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9464326913
New run: https://github.com/erikbosch/vehicle-example-app2/actions/runs/9513024770

Old run gave warning. In new run dash output is presented.
Old:
Check Software Licenses
Process completed with exit code 23.

New:
[main] INFO Querying Eclipse Foundation for license data for 79 items.
[main] INFO Found 23 items.
[main] INFO Querying ClearlyDefined for license data for 57 items.
[main] INFO Found 57 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO
[main] INFO git/github/actions/download-artifact/v4
[main] INFO git/github/actions/setup-java/v4
[main] INFO git/github/actions/setup-node/v4
[main] INFO git/github/actions/setup-python/v5
[main] INFO git/github/actions/upload-artifact/v4
[main] INFO git/github/aquasecurity/trivy-action/0.19.0
[main] INFO git/github/dawidd6/action-download-artifact/v3
[main] INFO git/github/docker/build-push-action/v5
[main] INFO git/github/docker/setup-buildx-action/v3
[main] INFO git/github/docker/setup-qemu-action/v3
[main] INFO git/github/fountainhead/action-wait-for-check/v1.2.0
[main] INFO git/github/mikepenz/action-junit-report/v4
[main] INFO git/github/softprops/action-gh-release/v2
[main] INFO pypi/pypi/-/coverage/7.3.2
[main] INFO pypi/pypi/-/exceptiongroup/1.1.3
[main] INFO pypi/pypi/-/grpcio/1.59.0
[main] INFO pypi/pypi/-/mypy/1.5.1
[main] INFO pypi/pypi/-/paho-mqtt/1.6.1
[main] INFO pypi/pypi/-/parameterized/0.9.0
[main] INFO pypi/pypi/-/setuptools/58.1.0
[main] INFO pypi/pypi/-/typing-extensions/4.11.0
[main] INFO pypi/pypi/-/velocitas-sdk/0.14.1
[main] INFO pypi/pypi/-/wheel/0.41.2
[main] INFO
[main] INFO This content is either not correctly mapped by the system, or requires review.

Changes inspired by what exist in https://github.com/eclipse-kuksa/kuksa-actions/tree/main/check-dash. If a token is available then one could consider supporting automatic review requests as well.
Example Battila7
Previously we got warnings like:

Updated code tested with tags of type v0.0.4, 0.0.5 and tarzan. See results at https://github.com/erikbosch/vehicle-example-app2/pkgs/container/vehicle-example-app2%2Fsampleapp

Here we go again, two more ideas to get rid of warnings. Tested only on Python app, but have difficulties seeing that this should give problems for cpp/sdks

We also have the VELOCITAS_PROJECT_TOKEN which should do the stuff for dash

We also have the VELOCITAS_PROJECT_TOKEN which should do the stuff for dash

You mean to request a review, similar to how we use secrets.ECLIPSE_GITLAB_API_TOKEN in for example Databroker. I think that makes sense, but should we do it in this PR?

      - name: Dash license check
        uses: eclipse-kuksa/kuksa-actions/check-dash@4
        with:
          dashinput: ${{github.workspace}}/dash-databroker-deps
          dashtoken: ${{ secrets.ECLIPSE_GITLAB_API_TOKEN }}


Grammar issues in bit about appendix C

https://htmlparser.info/introduction/

The XHTML 1.0 specification had an appendix that specifies guidelines in how to write XHTML 1.0 documents while being compatible with HTML user agents.

Two issues here:

the had/specifies mixed tense stood out to me, although I don't know if it would to a native speaker
"guidelines in how to" is wrong, should be "guidelines for how to"?

Thanks!


State of the module

Why is this module in official Azure group? It seems like an example/PoC with no real support, configuration, doesn't follow any guidelines. It literally doesn't even allow setting name - why is it here?

Yes, it's long dead and falling apart.


Authentication middleware to verify user token on requests

The function has been created and tested but needs to be added to each route as a middleware. Leaving it off for now so it doesn't affect testing


Installed vite in node_modules is chunked

Clear and concise description of the problem

The installed vite module from npm has the source code compiled and chunked and looks like this:

Suggested solution
Whats the reason for doing this ? Vite 1 and other libraries ship uncompiled (just transpiled) code. This enables easy debugging within the library source code, if needed.

Alternative
Tried to look through the chunks to find relevant lines of code, but couldn't.

Vite compiles its own code in advance for a faster development experience, you can use this to debug the uncompiled library source code.


Random reboot with 0.1.4

Hi,
Facing random reboots with 0.1.4/r30gb as soon as I access my camera with any ONVIF compatible apps (Android or Windows). No problem through RTSP however.
Thanks

Check if the problem is the snapshot, for example through the web interface.

Check if the problem is the snapshot, for example through the web interface.

Yes, seems to be. When I open the Snapshot tab, I can see a fresh snapshot and then the camera reboots itself. No problem however on the PTZ tab.

Yes, seems to be. When I open the Snapshot tab, I can see a fresh snapshot and then the camera reboots itself. No problem however on the PTZ tab.

It's a know issue: low memory.
Enable swap space.

It's a know issue: low memory.
Enable swap space.

Thank you, it works. My bad, I desactivated the swap space in 0.1.4 and didn't think it could be the reason. Sorry for wasting your time !

Thank you, it works. My bad, I desactivated the swap space in 0.1.4 and didn't think it could be the reason. Sorry for wasting your time !

No problem.

No problem.

It would be nice to indicate this configuration change in README.md, so new users would be aware of it

This isn't a configuration change.
Swap space problem is here from the beginning.
But I could add a note in the readme.


Delete and/or replace Existing Crates

I'm sorry if this has been asked before, but I Want to delete the existing crates. I am trying to use this plugin on my RolePlay server to give the Currency to the players, and don't feel that the current drops suit a Roleplay very much.

For notice, I mean, the crates from the system, not breaking them off the ground.

You can move the crates you do not want out of the ./Crates directory (I stash mine in a directory I made ./Crates_offline)
then run /cc reload


Implemented logic for storing and applying multiple field mappings(#2hran7u)

Related Issues

Closes #81
Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

screen-recorder-fri-nov-04-2022-12-57-09.webm

IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

@disha1202
Could you please share some screenshots and videos for the change?

@disha1202
Could you please share some screenshots and videos for the change?

Sure Sir, added in the PR description.


delete plugin logic automated behavior versus user interaction explicit or implicit

I've found, when deleting a plugin the 'crude' way of rm -rf ~/.config/LightTable/plugins, when LT picks up, it is supposed to be removed after 2 consecutive tries unsuccesfully, however it does not always seem to 'kick in' because many times I could click "Install missing" and close/fire-up LT and it would persist nonetheless.
One of the points here probably is that, although to a certain degree the fault tolerance and automated fallback behavior is correctly assumed to be in order here, somewhat control is lacking on behalf of the user.
It would probably be better to have as popup buttons: cancel, remove plugin from cache (or list or memory, whatever) and install missing in the sense that the second option really isn't a explicit option currently. Perhaps even, one could argue the 2 tries fallback is somewhat superfluous if you take 'saving the user actions / clicks per operation' in the fact that left way or right, they'll be forced to make a choice here anyway. Cancel presumes "not now but later again" where install missing implies "try now but don't arse me if you fail" and removal says "don't bother me ever again", I get the feeling this probably a better granularity for this case where we resort to a modal dialog anyway, meaning we seek the input/interaction explicitely - it would serve the user to get a better response by asking the right questions straight away.
That having said, there is also the issue of behavior reloading right after uninstall in the plugin manager. As in it will trigger the above described automated response of "Oops I found a plugin missing" (yes of course, I just removed it explicitely = "don't arse me ever again").
Given this and my current knowledge/skills, this is not something I've gotten into the code too much yet and, although lacking time might be a contribution I could confortably make later by pull request.
Felt it should be here as a ticket probably since this is 'bugged and to be discussed' behavior I'd think.

This happens because we now track dependencies in the User plugin's plugin.edn and that only gets saved when a user uses the plugin manager - which is the expected workflow. If you'd like to add support for deleting outside the plugin manager, you'll need to define an app behavior that triggers on :post-init and calls this plugin-manager behavior. This way of deleting plugins isn't something I'd encourage for most users but happy to leave this open if you're interested in adding this.

Closing as removing a plugin and starting LT should only prompt twice at most for a removed plugin. Can reopen if there are reproducible steps on latest LT where reprompting is occurring more than twice


anext mocking

Hi, how should I mock __anext__ method so it returns a list element with each iteration in an async for construct?
Here's a snippet of what I tried and failed at:
from asyncio import get_event_loop
from asynctest import create_autospec

class A(object):
    def __aiter__(self):
        return self

    async def __anext__(self):
        print('A.__anext__()')
        raise StopAsyncIteration

async def test(obj):
    async for cnt in obj:
        print(cnt)

mock = create_autospec(A)
mock.__anext__.side_effect = [4,5,6]

get_event_loop().run_until_complete(test(A()))
get_event_loop().run_until_complete(test(mock))
print(mock.mock_calls)

When I run it I get:
A.__anext__()
[call.__aiter__()]

Seems that mock's __anext__ method is never called.
What am I doing wrong here?

I guess you should be mocking __anext__.return_value to return the required list of elements. Reference : https://asynctest.readthedocs.io/en/latest/tutorial.mocking.html#asynchronous-iterator .
from asyncio import get_event_loop
from asynctest import create_autospec, MagicMock

class A:
    def __aiter__(self):
        return self

    async def __anext__(self):
        print('A.__anext__()')
        raise StopAsyncIteration

async def test(obj):
    async for cnt in obj:
        print(cnt)

mock = create_autospec(A)
mock.__aiter__.return_value = [4,5,6]

get_event_loop().run_until_complete(test(A()))
get_event_loop().run_until_complete(test(mock))
print(mock.mock_calls)

Output
A.__anext__()
4
5
6
[call.__aiter__()]

Awesome, thank you :)


[Relay][Frontend][ONNX] Add LayerNormalization operator

This PR adds the LayerNormalization operator for relay onnx frontend that was added in onnx in opset 17 here.
@sfvaroglu @AndrewZhaoLuo

@ehsanmok lgtm! Just fix the linting and make sure tests are passing.


mat-select with multiple

Bug
Mat-select with multiple
What is the expected behaviour?
to create a drop down list that allows multiple items to be selected
What is the current behaviour?
Error: Value must be an array in multiple-selection mode.
What are the steps to reproduce?
  <mat-form-field>
       <mat-select multiple placeholder="placeholder" formControlName="formGroup" required>
              <mat-option *ngFor="let c of items" [value]="c.value">{{ c.value }}</mat-option>
       </mat-select>
</mat-form-field>

What is the use-case or motivation for changing an existing behaviour?
this was working, seems to be broken in v7, have tried adding [(ngModel]) which does make it work but get a warning saying ngModel has been removed from v7 angular material mat-select
Which versions of Angular, Material, OS, Typescript, browsers are affected?
Ubuntu 18.4
64 bit
vs code 1.29 insiders
chrome v:70
typescript 3.1.6
angular 7.0.2
Is there anything else we should know?

Can you provide a reproduction in StackBlitz.  This will help us to investigate the issue you are seeing.
Based on our our docs site it appears to allow for multi-selects.


setting state in Menu onScroll event causes Menu to move

I added an onScroll event to the Menu component and am setting state in the callback.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
noticed that the whole Menu component moves up and down. It seems to be the top css property being applied to the Menu component is doing it.
am i wrong to add an onScroll event to the Menu component?

Expected Behavior 🤔
the whole Menu component should stay where the anchorEl is

Steps to Reproduce 🕹
here is a sandbox - the examples are copied from the material-ui component demo of Menu component
https://codesandbox.io/s/material-ui-playground-fjr4o?file=/index.js

Steps:

go to the link.
click on the More Menu icons. One of them is with Hooks, and other with Class. this will pop the Menu component.
Scroll in the Menu.
The whole thing moves.

Context 🔦

i was upgrading material ui from v3 to v4, and this used to work fine prior to update.
Your Environment 🌎

my setup has the following:
"@material-ui/core": "^4.11.0",
"@material-ui/icons": "^4.9.1",
"@material-ui/styles": "^4.10.0",
"react": "^16.9.0",
"react-dom": "^16.9.0",

Tech
Version

Material-UI
v4.11.0

React
16.9.0

Browser
chrome - mac

TypeScript
na

etc.
-

Duplicate of #19245


Sableye can't learn gravity

On the wiki it says sableye can learn gravity from transfer, but the transfer tutor will not allow it to learn it.
It can get it from move tutor in usum.

Hi there Kami! I tested it on a single player world, and my findings was that sableye cannot learn Gravity there either. So it's a Pixelmon bug.
Recommend posting it on the Pixelmon tracker: https://www.pixelmonmod.com/tracker.php

Fixed.

Fixed.


Appstudio update test-component-pac-tgtc

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-tgtc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
29 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-tgtc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
32 seconds
clamav-scan

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/test-component-pac-tgtc-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
32 seconds
clamav-scan

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
5 seconds
show-summary


Add support for table schema

What i did:

added optional schema field for the ModelAttributes
added optional schema_name for TableMetadata
changed query statements to add schema (ex: from INSERT INTO \"{}\" ... to  INSERT INTO {}\"{}\" ... where the first parameter is either empty string or "<schema_name>".

What's not done:

add schema to the whole section related to joins
add schema to the migration part of the code
pass schema to sqlmo (i see it supports schema only that the functions used didn't expose that, i haven't gone too deep into it though)
for sqlite, to bypass the schema (because it doesn't support it). It should be as easy as overriting the schema name to be None in TableMetadata, and everything should work.
🤷♂ I'm sure i missed something
tests with schema (current tests pass)

Would really appreciate a look over the code so far and maybe some help with this? 🙃

Love it. I'll review sometime this week.

I've made a pull request for sqlmo with the exposed schema fields and updated this repo to use that
I'll write some tests a bit later.
One thing thats really annoying is the formatting, i ran cargo fmt --all and its...a mess.
I've made another pull request with only the formatting, and after you merge that, only the changes should show.

Thanks for these. I responded in the cargo fmt PR you opened. Hopefully that isn't a blocker for this contribution, as it's a welcome addition to the library.

I reverted the formatting.
These should be the changes, and only the changes.


feature(tags): allow ability to add custom anchors and tags

Currently we default to empty anchor in tags when using uploadFile - we want to allow clients to optionally provide their own, and adjust the signature accordingly.

duplicate of https://github.com/ardriveapp/turbo-sdk/issues/35


Implement LENGTH, SQRT, CBRT, ROUND

We have added support for functions LENGTH, SQRT, CBRT, ROUND. ROUND supports both ROUND(value) and ROUND(value, precision).
A minor update is made on checkIntRow and checkStringRow. We find the if and else branches are exactly the same, so we have simplified it.
During the implementation of ROUND, we found a bug of ATAN2, which results in an error when calling a math function with two parameters. So we have fixed this in bytecode_generator.cpp.

This can be closed and replaced with https://github.com/cmu-db/terrier/pull/1114


Experiment:  use validation score as early-stopping criteria, not training score

Be better data scientists

@pgbrodrick :  Well, the default metric for this is 'val_loss', so this should be working. Please keep an eye on this and reopen if it's an issue in the future.

I haven't dug into why yet, but this instance appears to demonstrate this is still a problem:
relevant config parameters:
callback_early_stopping:
use_callback: true
min_delta: 0.0001
patience: 5
callback_reduced_learning_rate:
use_callback: true
factor: 0.5
min_delta: 0.0001
patience: 3
model training (starting part way through)
Epoch 00015: saving model to ./tch_extrapoloation_initial_test/model.h5
Epoch 16/100
1/1 [==============================] - 0s 152ms/step - loss: 0.6484 - val_loss: 0.7784
Epoch 17/100
1/1 [==============================] - 0s 141ms/step - loss: 0.6354 - val_loss: 0.7409
Epoch 18/100
1/1 [==============================] - 0s 193ms/step - loss: 0.6251 - val_loss: 0.7441
Epoch 19/100
1/1 [==============================] - 0s 199ms/step - loss: 0.6129 - val_loss: 0.7929
Epoch 20/100
1/1 [==============================] - 0s 187ms/step - loss: 0.5966 - val_loss: 0.8955
Epoch 00020: saving model to ./tch_extrapoloation_initial_test/model.h5
Epoch 21/100
1/1 [==============================] - 0s 123ms/step - loss: 0.5792 - val_loss: 1.0506
Epoch 22/100
1/1 [==============================] - 0s 172ms/step - loss: 0.5669 - val_loss: 1.2140
Epoch 23/100
1/1 [==============================] - 0s 205ms/step - loss: 0.5608 - val_loss: 1.2920
Epoch 24/100
1/1 [==============================] - 0s 235ms/step - loss: 0.5515 - val_loss: 1.2330
Epoch 25/100
1/1 [==============================] - 0s 168ms/step - loss: 0.5351 - val_loss: 1.1079
Epoch 00025: saving model to ./tch_extrapoloation_initial_test/model.h5
Epoch 26/100
1/1 [==============================] - 0s 122ms/step - loss: 0.5236 - val_loss: 1.0452
Epoch 27/100
1/1 [==============================] - 0s 193ms/step - loss: 0.5150 - val_loss: 1.1047
Epoch 28/100
1/1 [==============================] - 0s 184ms/step - loss: 0.4961 - val_loss: 1.2338
Epoch 29/100
1/1 [==============================] - 0s 197ms/step - loss: 0.4819 - val_loss: 1.2764
Epoch 30/100
1/1 [==============================] - 0s 192ms/step - loss: 0.4719 - val_loss: 1.1605

Fixed, callbacks needed to reference 'val_loss' not 'loss', the latter was hardcoded in.


Update eclipse-che operator for openshift to release 7.4.0

Signed-off-by: David Festal<EMAIL_ADDRESS>Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

@dmesser is it possible to restart the CVP/operator-catalog-initialization check ?
the corresponding build doesn't seem to fail because of this PR according to logs

/retest CVP

/test CVP

/test CVP

verified catalog build locally


LEP-86 bugfix: assessment.dependants is only client dependants

https://dsdmoj.atlassian.net/browse/LEP-86
When merging LEP-86, we forgot to notice that assessment.dependants is not the same as Dependant.where(assessment: assessment), as that includes partner dependants too. This means that an accidental defect was introduced around the threshold uplift for the scenario with >4 children

@starswan have you checked your production DB to see whether this impacted any checks conducted? It sounds like an extreme edge case, but we'll want to communicate with providers if we can see someone may have received an incorrect assessment.

@starswan have you checked your production DB to see whether this impacted any checks conducted? It sounds like an extreme edge case, but we'll want to communicate with providers if we can see someone may have received an incorrect assessment.

@patrick-laa the defective code hasn't made it to production yet (I thought it hadn't, but thanks for the nudge to go and check)


mekanism and tinkers construct copper issues

hello,
I'm having an issue with tinkers construct now being able to smelt mekanism copper ores. I'm not sure if its something to do with tinkers construct or with mekanism. From what i've read on the mekanism wiki the copper ore should work with other mods. I've tried melting all forms of copper ore,dust,blocks and so on. I'm using mekanism 9.1 on MC 1.10.2

My guess is that there's something wrong with Tinkers Construct. As EnderIO and Mekanism both have the same issue.
Copper is all oredict in Mekanism to ore- ingot- dustCopper.

thank you that works

@dritz56 You can help issue tracker be clean by closing your issues that has been solved by pressing "Close Issue" button near "Comment"


Use port range shorthand

No functional change here, just noticed unnecessary enumeration of ports.
See https://docs.docker.com/compose/compose-file/#ports

@Druotic Manually merged this into master branch. Closing this as fixed. Many thanks for this contribution.


synchronization example fails to build for SMP platforms

Initially reported by Shippable here https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/47829/3/console while reviewing https://github.com/zephyrproject-rtos/zephyr/pull/17992.
Yet could be reproduced for any other SMP platform, for example qemu_x86_64:
# mkdir build
# cd build
# cmake -DBOARD=qemu_x86_64 ../samples/synchronization/

Enable OpenOCD support (CONFIG_OPENOCD_SUPPORT=y).
# make
...
[ 60%] Built target app
In file included from .../include/kernel_includes.h:16,
                 from .../include/kernel.h:17,
                 from .../kernel/include/kernel_structs.h:10,
                 from .../subsys/debug/openocd.c:7:
.../subsys/debug/openocd.c:39:35: error: 'struct z_kernel' has no member named 'current'
  [OPENOCD_OFFSET_K_CURR_THREAD] = offsetof(struct z_kernel, current),
                                   ^~~~~~~~
.../subsys/debug/openocd.c:66:2: warning: #warning Please define OPENOCD_OFFSET_T_STACK_PTR for this architecture [-Wcpp]
 #warning Please define OPENOCD_OFFSET_T_STACK_PTR for this architecture
  ^~~~~~~

@abrodkin is this issue been taken care off?

@ioannisg sorry I was on ETO last 2 weeks with limited access to Internet, now I'm going to re-spin https://github.com/zephyrproject-rtos/zephyr/pull/18125 with fix in for of !SMP dependency of OPENOCD_SUPPORT in subsys/debug/Kconfig. Is that OK?

there are 2 issues here, one is the SMP support, the other is building on X86_64.
So I think #18125 deals with the SMP issue.
@andrewboie does non-SMP on x86_64 make sense?

@galak what's the problem with building on X86_64? Maybe I missed some discussion last weeks so pls kindly point me to any relevant information and I'll take a look.

@galak what's the problem with building on X86_64? Maybe I missed some discussion last weeks so pls kindly point me to any relevant information and I'll take a look.

The warning #warning Please define OPENOCD_OFFSET_T_STACK_PTR for this architecture is related to x86_64

@galak what's the problem with building on X86_64? Maybe I missed some discussion last weeks so pls kindly point me to any relevant information and I'll take a look.

The warning #warning Please define OPENOCD_OFFSET_T_STACK_PTR for this architecture is related to x86_64

Hm... but how can I reproduce it?
I don't see it with:
cmake -DBOARD=qemu_x86_64 ../samples/synchronization/
make

@galak what's the problem with building on X86_64? Maybe I missed some discussion last weeks so pls kindly point me to any relevant information and I'll take a look.

The warning #warning Please define OPENOCD_OFFSET_T_STACK_PTR for this architecture is related to x86_64

Hm... but how can I reproduce it?
I don't see it with:
cmake -DBOARD=qemu_x86_64 ../samples/synchronization/
make

Ooops, forgot to enable CONFIG_OPENOCD via menuconfig :(
Now I see it but again this has nothing to do with anything except x86_64 and CONFIG_OPENOCD.
So it looks like we'd need this then (since X86_64 seems to be quite incomplete, judging by contents of https://github.com/zephyrproject-rtos/zephyr/blob/master/arch/x86_64/include/kernel_arch_thread.h):
diff --git a/subsys/debug/Kconfig b/subsys/debug/Kconfig
index a5dff0ad4f..202d7f3f29 100644
--- a/subsys/debug/Kconfig
+++ b/subsys/debug/Kconfig
@@ -223,7 +223,7 @@ config EXCEPTION_STACK_TRACE

 config OPENOCD_SUPPORT
        bool "OpenOCD support [EXPERIMENTAL]"
-       depends on !SMP
+       depends on !SMP && !X86_64
        select THREAD_MONITOR
        select THREAD_NAME
        help

Does that look OK?


New testnet Beta chainid

Need to acquire new testnet chainid

We can use chain id 3335 which was registered as EthStorage L2 Devnet


No account drawer

There are apps that don't need a user to be logged in. In such case, in "account area" there is just a text of a size "abc_text_size_headline_material" - usually by def white, with some background, usually only a color (accent in some apps). Nothing else, pretty simple.

@neokree There should be the possibility to hide the accounts section completly. So the only thing to do is to remove the views like in replaceDrawerHeader() and additionally remove the ImageView 'usercover'. Call the method something like 'noAccounts()' and you have done it. :smiley:

@neokree There should be the possibility to hide the accounts section completly. So the only thing to do is to remove the views like in replaceDrawerHeader() and additionally remove the ImageView 'usercover'. Call the method something like 'noAccounts()' and you have done it. :smiley:

ehm, yes but no. @randombyte-developer  you forgot the status bar on lollipop devices, the drawer is between the status bar and the status bar background, so when you remove all user section it should be a little space for status bar, but I actually don't know if I have to color it with the background status bar or simple add some padding from the top

Sorry, I didn't get your point.
Do you mean, that you don't know, what is right in material design? Personally, I think you should just add padding.
Or do you mean that the color is different? Maybe a screenshot?

I have uploaded three new screenshot on the EXAMPLE.md file. Please see if is a possible solution.

On my Nexus 6, the example app and my app behave wrong. When I select no header the drawer is so tiny.

Because I have to release my app soon, I set the custom header to
<LinearLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_height="match_parent"
    android:layout_width="240dp">

    <View
        android:layout_width="240dp"
        android:layout_height="wrap_content" />

    </LinearLayout>

That works not perfectly but is acceptable.

Actually it is an issue only on nexus 6, I suppose for the hight resolution of the screen.
In the example app the others navigation drawers worked or they still have this issue?

If there is no account section at all, sections should not go behind status bar, because it will look wrong.
So padding or something should be in order.
For apps that use no status bar coloring / behind the status bar theme on KitKat, there should be no padding and items should start from the top (as the Toolbar starts as well).

For the nexus 6 and hight resolutions devices problem, I found a solution.
Now I'm working for remove the drawer between the status bar when you select the NO_HEADER option.

wooohooo, we've got an official statement to this @neokree, check this:
https://plus.google.com/u/0/+MiroslavKošík/posts/jeQGkAXUtvA

Any news on this? Another thing I'm seeing on my N6 is this: http://imgur.com/zHOuFz8, when setting the images as Bitmaps. It basically looks like the width just isn't being calculated right. Could we maybe get a way to manually set the width?

@drinfernoo what version are you using? Because in 1.2.9 there was a problem for hight resolution and small screen devices, but in 1.3 alpha version there is fixed.

Bug on Nexus 6 fixed! Drawer expands normally.


TreeError [MarkersPanel] Tree element not found: [object Object]

I believe this was expected to be fixed by #71126, however that fixed is included in the current stable release and it still happens (FYI @sandy081 - the bot locked the existing issue, and I couldn't find another tracking this).
I still see this lots - most noticeably in my CI runs it just fills the logs. This one is using the current insiders build:
TreeError [MarkersPanel] Tree element not found: [object Object]: Error: TreeError [MarkersPanel] Tree element not found: [object Object]
    at t.ObjectTreeModel.getElementLocation (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:136:14)
    at t.ObjectTreeModel.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:135:250)
    at W.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1037:72)
    at z.revealMarkersForCurrentActiveEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:628)
    at z.autoReveal (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:485)
    at z.onActiveEditorChanged (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5860:776)
    at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5859:754
    at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
    at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at e.doEmitActiveEditorChangeEvent (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:364)
    at e.handleActiveEditorChange (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:160)
    at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:474
    at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
    at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5508:875
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
    at async e.openEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5507:750)
    at async e.doOpenEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4864:479)
    at async e.$tryShowTextDocument (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3484:517)

https://travis-ci.org/Dart-Code/Dart-Code/jobs/601130805

ok fine , want me to fix it?
On Oct 22, 2019, at 3:05 AM, Danny Tuppeny<EMAIL_ADDRESS>wrote:

I believe this was expected to be fixed by #71126https://github.com/microsoft/vscode/issues/71126, however that fixed is included in the current stable release and it still happens (FYI @sandy081https://github.com/sandy081 - the bot locked the existing issue, and I couldn't find another tracking this).
I still see this lots - most noticeably in my CI runs it just fills the logs. This one is using the current insiders build:
TreeError [MarkersPanel] Tree element not found: [object Object]: Error: TreeError [MarkersPanel] Tree element not found: [object Object]
at t.ObjectTreeModel.getElementLocation (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:136:14)
at t.ObjectTreeModel.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:135:250)
at W.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1037:72)
at z.revealMarkersForCurrentActiveEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:628)
at z.autoReveal (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:485)
at z.onActiveEditorChanged (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5860:776)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5859:754
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at e.doEmitActiveEditorChangeEvent (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:364)
at e.handleActiveEditorChange (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:160)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:474
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5508:875
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:89:5)
at async e.openEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5507:750)
at async e.doOpenEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4864:479)
at async e.$tryShowTextDocument (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3484:517)
https://travis-ci.org/Dart-Code/Dart-Code/jobs/601130805
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/83040?email_source=notifications&email_token=AMVNWDVXNKRSE7MTIMZSMRLQP2X3LA5CNFSM4JDMAK62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTNPWWA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDX2OXYK6STVCFL4ACLQP2X3LANCNFSM4JDMAK6Q.

someone was wiping my drives at the end, pretty sure one computer is down, Main will boot , just let me know when your ready
On Oct 22, 2019, at 3:09 AM, Rocket<EMAIL_ADDRESS>wrote:

ok fine , want me to fix it?
On Oct 22, 2019, at 3:05 AM, Danny Tuppeny<EMAIL_ADDRESS>wrote:

I believe this was expected to be fixed by #71126https://github.com/microsoft/vscode/issues/71126, however that fixed is included in the current stable release and it still happens (FYI @sandy081https://github.com/sandy081 - the bot locked the existing issue, and I couldn't find another tracking this).
I still see this lots - most noticeably in my CI runs it just fills the logs. This one is using the current insiders build:
TreeError [MarkersPanel] Tree element not found: [object Object]: Error: TreeError [MarkersPanel] Tree element not found: [object Object]
at t.ObjectTreeModel.getElementLocation (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:136:14)
at t.ObjectTreeModel.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:135:250)
at W.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1037:72)
at z.revealMarkersForCurrentActiveEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:628)
at z.autoReveal (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:485)
at z.onActiveEditorChanged (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5860:776)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5859:754
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at e.doEmitActiveEditorChangeEvent (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:364)
at e.handleActiveEditorChange (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:160)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:474
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5508:875
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:89:5)
at async e.openEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5507:750)
at async e.doOpenEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4864:479)
at async e.$tryShowTextDocument (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3484:517)
https://travis-ci.org/Dart-Code/Dart-Code/jobs/601130805
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/83040?email_source=notifications&email_token=AMVNWDVXNKRSE7MTIMZSMRLQP2X3LA5CNFSM4JDMAK62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTNPWWA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDX2OXYK6STVCFL4ACLQP2X3LANCNFSM4JDMAK6Q.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/83040?email_source=notifications&email_token=AMVNWDUBIZHBYBFNPSIDD5LQP2YMXA5CNFSM4JDMAK62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB44E6I#issuecomment-544850553, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDRVW5QA6WBQBPVTMOTQP2YMXANCNFSM4JDMAK6Q.

well they hung a carrot and i probably should have stopped jumping for it earlier (figured a couple hours earlier but had consumed all of my day already, so i entertained liked usual,   but nobody can say i lack persistence :)
On Oct 22, 2019, at 3:09 AM, Rocket<EMAIL_ADDRESS>wrote:

ok fine , want me to fix it?
On Oct 22, 2019, at 3:05 AM, Danny Tuppeny<EMAIL_ADDRESS>wrote:

I believe this was expected to be fixed by #71126https://github.com/microsoft/vscode/issues/71126, however that fixed is included in the current stable release and it still happens (FYI @sandy081https://github.com/sandy081 - the bot locked the existing issue, and I couldn't find another tracking this).
I still see this lots - most noticeably in my CI runs it just fills the logs. This one is using the current insiders build:
TreeError [MarkersPanel] Tree element not found: [object Object]: Error: TreeError [MarkersPanel] Tree element not found: [object Object]
at t.ObjectTreeModel.getElementLocation (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:136:14)
at t.ObjectTreeModel.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:135:250)
at W.isCollapsed (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1037:72)
at z.revealMarkersForCurrentActiveEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:628)
at z.autoReveal (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5863:485)
at z.onActiveEditorChanged (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5860:776)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5859:754
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:114:709
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at e.doEmitActiveEditorChangeEvent (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:364)
at e.handleActiveEditorChange (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:160)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4862:474
at c.fire (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:118:286)
at file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5508:875
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:89:5)
at async e.openEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5507:750)
at async e.doOpenEditor (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4864:479)
at async e.$tryShowTextDocument (file:///Users/travis/build/Dart-Code/Dart-Code/.vscode-test/vscode-insiders/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3484:517)
https://travis-ci.org/Dart-Code/Dart-Code/jobs/601130805
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/83040?email_source=notifications&email_token=AMVNWDVXNKRSE7MTIMZSMRLQP2X3LA5CNFSM4JDMAK62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTNPWWA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDX2OXYK6STVCFL4ACLQP2X3LANCNFSM4JDMAK6Q.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/83040?email_source=notifications&email_token=AMVNWDUBIZHBYBFNPSIDD5LQP2YMXA5CNFSM4JDMAK62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB44E6I#issuecomment-544850553, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMVNWDRVW5QA6WBQBPVTMOTQP2YMXANCNFSM4JDMAK6Q.

cc @joaomoreno

With fix from #71126, markers model and tree model should be in sync always. There is no more asynchronosity. Tree model is updated as soon as markers model is changed.
@joaomoreno Please let me know if this still can happen from within ObjectTree?

@DanTup It would be great if you can provide us reproducible steps. Otherwise we are just shooting in the dark.

@sandy081 sure, though I don't know exactly what's triggering it. Can you explain exactly what this code is doing that might give me a hint? I see revealMarkersForCurrentActiveEditor in the call stack, but I'm not really sure what "markers" are - is this related to the Problems view, or a side-bar tree?

Yes it is related to Problems view and Markers are Problem/Diagnostics.  This is about trying to reveal the current active file in the Problems view if the file has problems.

Tried running the same test runs locally and I'm not seeing this. Is it possible to make the error include more info that might help track it down? (for ex. something more than [Object object])

Added toString to element to print more info about element


Added new unaddressed pack codes for SPG wales

Motivation and Context

Theres been changes to the unaddressed pack codes after it was decided to not have bilingual versions for welsh addresses. This PR adds in welsh unaddressed pack codes.
What has changed

Added in new SPG welsh unaddressed pack codes.

How to test?

Run make test
Build the docker image and the ATs.
Make sure descriptions looks correct.

Links

Trello

 New unaddressed product pack codes for SPG Wales (3)


Thanks a lot for the amazing implementation. Could you please let me know what library did you use for the retriever ?

Is it SCANN or FAISS ?

It's SCANN . I found sorry for the spam :).


Fix Issue #3: Add Support for Identifying Identical Table Names Across Different Data Sets

What is this PR ?
This PR solve https://github.com/devoteamgcloud/dataform-assertions/issues/3

https://github.com/devoteamgcloud/dataform-assertions/issues/3

Overview

Expanded example.js to accept schema.
Expanded JavaScript in includes/assertions to accept schema.

Information
Context Method: ref
ref method use individual arguments for the "schema", and "name" values.

References another action, adding it as a dependency to this action, returning valid SQL to be used in a from expression.
This function can be called with a Resolvable object, for example: ${ref({ name: "name", schema: "schema", database: "database" })}

This function can also be called using individual arguments for the "database", "schema", and "name" values. When only two values are provided, the default database is used and the values are interpreted as "schema" and "name". When only one value is provided, the default database and schema are used, with the provided value interpreted as "name". ${ref("database", "schema", "name")} ${ref("schema", "name")} ${ref("name")}

document

Thanks a lot for you support @KazuSh1geru !
This is indeed a super important feature that need to be implemented.
What do you think about making the schema argument optional? You can have projects with many datasets, and specify them one by one can be very long and we loose usage simplicity.
I am thinking about something like that:
const commonAssertions = require("dataform-assertions");

const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    "schema1.filter": ["Id"],
    "schema2.filter": ["Id"],
    "otherTable": ["Id"]
  }
});

I believe my method of writing the schema in isolation is better from 2 perspectives.
As the first, the above method of specifying tables is not sufficient.
Because the way to specify in the ref function needs to be schema, table. ref("schema1.filter") will cause an error, so the proposed notation needs to be converted to ref("schema1", "filter") and to be correct as the ref argument.
(Parsing of strings is not recommended, as it creates complexity.)
Second, it is against the Dry Principle.
Whenever there is a table other than filter in schema1, e.g. preprocess, postprocess, etc., schema1 must be added.
If this happens in other schemas, readability will be reduced.
const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    "schema1.filter": ["Id"],
    "schema1.preprocess": ["Id"],
    "schema1.postprocess": ["Id"],
    "schema2.filter": ["Id"],
    "schema2.postprocess": ["Id"],
    "schema3.filter": ["Id"],
    "schema3.preprocess": ["Id"],
    "schema3.postprocess": ["Id"],
    "schema3.transform": ["Id"],
    "otherTable": ["Id"]
  }
});

isolation schema pattern
const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    "schema1": {
      "filter": ["Id"],
      "preprocess": ["Id"],
      "postprocess": ["Id"]
    },
    "schema2": {
      "filter": ["Id"],
      "postprocess": ["Id"]
    },
    "schema3": {
      "filter": ["Id"],
      "preprocess": ["Id"],
      "postprocess": ["Id"],
      "transform": ["Id"]
    },
    "otherTable": ["Id"]
  }
});

The idea of being able to cut assertions in this package into arbitrary javascript is very nice!
I trust that this PR will be considered and better extended!
Best regards

ok, I agree for the isolation pattern, It seems to be more readable.
Before merging, here are two points to improve:

[Not blocking] Add the possibility to optionally set the schema.

Can be implemented in a future version if it is not so complicated.
As the example here for "otherTable" :
const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    "schema3": {
      "filter": ["Id"],
      "preprocess": ["Id"],
      "postprocess": ["Id"],
      "transform": ["Id"]
    },
    "otherTable": ["Id"] // THIS is not working
  }
});

[Blocking] How can we specify the environment in a schema name ?

In many projects, envs are included in the dataset name. Do you have an idea on how we can do this with your solution ?
Example:
const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    "schema3" + dataform.projectConfig.vars.env : { // THIS is not working
      "filter": ["Id"],
      "preprocess": ["Id"],
      "postprocess": ["Id"],
      "transform": ["Id"]
    },
    "otherTable": ["Id"]
  }
});

Thanks!

This is a requirement for us at the moment too, we have many models where names are duplicated.

2. [Blocking] How can we specify the environment in a schema name ?

const commonAssertionsResult = commonAssertions({
  globalAssertionsParams: {
    "schema": "dataform_assertions_" + dataform.projectConfig.vars.env,
    "location": "asia-northeast1",
    "tags": ["assertions"],
  },
  uniqueKeyConditions: {
    ["schema3" + dataform.projectConfig.vars.env] : { // Would this not solve the problem?
      "filter": ["Id"],
      "preprocess": ["Id"],
      "postprocess": ["Id"],
      "transform": ["Id"]
    },
    "otherTable": ["Id"]
  }
});```

@danilo-nzyte I tested, and it worked well, I did not know that
I will resolve the conflicts and merge the PR @KazuSh1geru
Thanks for your help everyone !


Relicensing under the Apache License 2.0

This branch changes the license from the LGPL 2.1 to the Apache License 2.0.
This was done following the rules outlined in: https://infra.apache.org/apply-license.html

NOTE: This should not be merged until all contributors relevant to the master branch have signed the ICLA, or the corporate CLA in the case that developers were employed to make contributions on their behalf.

Will this same be done for bst-1 branch assuming it still needs releases?

I would suggest as first step on this road update https://github.com/apache/buildstream/blob/master/CONTRIBUTING.rst. It currently says nothing about ICLA's.

I would suggest as first step on this road update https://github.com/apache/buildstream/blob/master/CONTRIBUTING.rst. It currently says nothing about ICLA's.

I've raised this before and my understanding from @sstriker is that we don't need ICLAs to accept contributions from fly by contributors via pull requests on github. At least this should be true once the ASF license is in place (after merging this PR).

@gtristan great. Can you please handle the bst-plugins-experimental release then at some point? That said, that doesn't prevent merging this change. It prevents tagging after this change.

@gtristan great. Can you please handle the bst-plugins-experimental release then at some point? That said, that doesn't prevent merging this change. It prevents tagging after this change.

Note that bst-plugins-experimental is not slated for a relicensing, so afaics is completely unrelated to this topic.

You are now removing API (Python bytecode mangling) that latest bst-plugins-experimental release depends on. How can it possibly not be related?

You are now removing API (Python bytecode mangling) that latest bst-plugins-experimental release depends on. How can it possibly not be related?

Ah I see what you mean, but I thought there was another issue we recently closed specifically about that :)

Sorry, I mixed up threads and didn't realize context switch. Indeed this PR is not directly related although lack of that tag is blocking tags with Apache license.


Add heu library files

This PR replaces [#10291 ], which changes the target branch from dmlc:master to dmlc:vertical-federated-learning

migrated to [#10570 ]


Standard library license isn't included

Describe the bug
Output generated by the library doesn't contain license of the rust standard library. It's required, see the discussion here: https://internals.rust-lang.org/t/does-the-standard-library-have-linking-exceptions-to-their-licensing/11377/17
To Reproduce

Create empty project
Generate config
Generate license.html
Observer that it doesn't have anything related to the std lib

Expected behavior

Standard library licensing information should be included

Screenshots
If applicable, add screenshots to help explain your problem.
Device:

Any OS, any device

Additional context

https://internals.rust-lang.org/t/does-the-standard-library-have-linking-exceptions-to-their-licensing/11377/17
https://github.com/rust-lang/rust/issues/67014

Duplicated #16


Add --allow-boot-library-installs to CI

This tries to reduce the divergences between Haskell.nix and
cabal-install, as they can cause issues (e.g. Haskell.nix reinstall ghc
by default, assuming that Cabal is in the plan, which it might not be).

Closed in favour of https://github.com/IntersectMBO/cardano-haskell-packages/pull/772


New entrypoint.sh

#!/bin/bash
cd /home/container
Make internal Docker IP address available to processes.
export INTERNAL_IP=ip route get 1 | awk '{print $NF;exit}'
echo
echo -e ":/home/container$ ${startvariable}"
Run the Server
LD_LIBRARY_PATH=.
LD_PRELOAD=${startvariable} ./bedrock_server
start1=./preload.so
if [ "${startvariable}" = "$start1" ];
then
LD_PRELOAD=${startvariable} ./bedrock_server
else
LD_LIBRARY_PATH=. ./bedrock_server
fi

You know what. With all the bdlauncher specific changes this is getting closed.
This is a generic image. Not meant to be changed a whole lot for a specific game/server.


Fix - @-mentions don't work in the same message as an inline code block or a multi-line code block

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/52214
PROPOSAL: https://github.com/Expensify/App/issues/52214#issuecomment-2469097789
Tests

Precondition: You are on private domain

Open any Chat
Compose a message with short mention (@mention) and code message
Verify that the short mention will converted to a correct mention unless it is in a code block

some of the test cases you can test with
`sd` `` g @short
`sd` `` g @short `
`jkl @short-mention `jk`
`sd` g @short
`jkl @short-mention`

The output should look like:

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@FitseTLT there are failing tests here

All unrelated @allgandalf

Passed

I think we should fix it. If users would have typed "sd `` g @short `" then they would expect short mention to be out of the code block. Github does it correctly - the output is fine in this message

I think we should fix it. If users would have typed "sd `` g @short `" then they would expect short mention to be out of the code block. Github does it correctly - the output is fine in this message

I am not saying your expectation is wrong but it is out of the scope of this issue. I can easily allow this in my shortmention regex but the final result would not match your expectation because of how we are handling the code blocks in expensify-common. That was what I was explaining above.
https://github.com/user-attachments/assets/3f98779b-40cb-4c96-bb07-7dcf4aabaf4b

I understand what you're saying. I think we would need to update the code block parser first. Adding a wrong test does not sound good. I'll report an issue

We should hold on https://github.com/Expensify/App/issues/53573


⚠ T:Riza Docs has degraded performance

In 18e516f, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 6920 ms

Resolved: T:Riza Docs performance has improved in 85ac8bf.


[BUG] If no funding target, currency should be 0

Describe the bug
Currency is still set to value of "target" form field which is hidden when no funding target is set

fixed


IMP: da-barplot should use consistant colors for enriched/depleted

Improvement Description
Make the color scheme consistent, even when all graphed features are only enriched or only depleted
Current Behavior
"enriched" and "depleted" are filled with in blue and orange, except when all features passing filter have the same sign, then they are all blue.
Proposed Behavior
The color scheme should be consistent (🟦 & 🟧 or whatever), even when all results have the same sign.

consistent with the other graphs in terms of color scheme for clarity

References
forum x-ref: https://forum.qiime2.org/t/ancombc-barplot-colors/32082

Not sure if this is the correct way ... but here I come

I like code suggestions in issues! 👍
The other way is to fork the repo and open a PR. That's more work, but also more helpful!
(If that's something you want to try, this could be a good opportunity)

I may have some spare time this week so I'll try!


Update Assisted UI to v2.9.1

Manually updating the Assisted Installer version of Assisted UI to v2.9.1
Tagged to latest-0791a7d98879fbc4deb3b3712afb861a8338680a which is associated with
https://quay.io/repository/edge-infrastructure/assisted-installer-ui/manifest/sha256:55c499e4f891900334ee0c2228f85a8a7012b72a004a76aab461a2dc4d6340ae

/cc osherdp I'll follow the instructions on the Bot

/test snapshot-repos-dry-run


0.13.0 modal dialog not closing in angular 1.3.15

This is a bug in using the combination of angular 1.3.15 and ui-bootstrap 0.13.0.
The modal dialog does not actually close even though the triggered code executes with apparent error messages. While I can work around this by using $modalInstance in my own code instead of the local instance variable returned by $modal.open(), some of the libraries I am using via bower are using this local variable handle which used to work in prior releases.
See the attached plunkr for an example: http://plnkr.co/edit/bQbbkuustf0H4iBOGrG6?p=preview

Seems to be going wrong with your var testScope = $scope.new(); implementation which you're passing to the modal options.
When I use the methods provided by the modal itself, everything seems to be working OK, or am I missing something?
http://plnkr.co/edit/1cFGn4SnPw1wt89acQyP?p=preview

This seems to be related to manually calling $new and $destroy for creating and cleaning up scopes in the code. If these are deferred until later, this issue seems to not occur. I fixed the 3rd party library to do this a different way (using $dismiss()) and sent them a bug as well, so I am not blocked, but in terms of behavior, it looks like this is some type of animate bug because the dialog does not get removed.
Tarik

On May 5, 2015, at 12:50 PM, Robin van Baalen<EMAIL_ADDRESS>wrote:
Seems to be going wrong with your var testScope = $scope.new(); implementation which you're passing to the modal options.
When I use the methods provided by the modal itself, everything seems to be working OK, or am I missing something?
http://plnkr.co/edit/1cFGn4SnPw1wt89acQyP?p=preview http://plnkr.co/edit/1cFGn4SnPw1wt89acQyP?p=preview
—
Reply to this email directly or view it on GitHub https://github.com/angular-ui/bootstrap/issues/3624#issuecomment-99201130.

Also, take a look a t this:
https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L422
The modal already creates a scope of its own. So basically it will create a new scope ON your new scope which probably causes the modal not to fire the methods you're calling on your new scope.
Take a look at the documentation page on how to use the scope option.

Makes sense, thank you. I will update the bug report on the library I’m using to change this there.
Tarik

On May 6, 2015, at 4:58 AM, Robin van Baalen<EMAIL_ADDRESS>wrote:
Also, take a look a t this:
https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L422 https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L422
The modal already creates a scope of its own. So basically it will create a new scope ON your new scope which probably causes the modal not to fire the methods you're calling on your new scope.
Take a look at the documentation page on how to use the scope option.
—
Reply to this email directly or view it on GitHub https://github.com/angular-ui/bootstrap/issues/3624#issuecomment-99423139.

Hmm, I've just upgraded to 0.13.0 and noticed that my modals don't seem to be closing anymore. I've also create my own scopes since I have a service to extend $modal functionality and allow the consumers of my service to pass custom properties to the newly created $scope.
How do you suggest that I get around this issue without having to change the implementation to use resolve blocks only?

@wawyed separate issue which we're looking at

@karianna  - Is there a separate issue # for this? I am not sure which issue I am seeing. Basically, I upgraded to 0.13.0 and to Angular 1.3 and my modals no longer close. From this thread it seems to be related to passing in a scope?
openChangeAssignmentModal = function () {
      $modal.open({
        templateUrl: 'template.html',
        controller: ChangeAssignmentModalInstanceCtrl,
        backdrop: 'static',
        scope: $scope
      });```

@311chaos Just want to make sure you realize, with backdrop set to 'static': backdrop is present but modal window is not closed when clicking outside of the modal window.

@RobJacobs - Thanks, this is an application that I have only recently started working on. I am guessing that was the intended behavior. My issue is that the close functions do not close the modal.
$modalInstance.dismiss('cancel');

or
$modalInstance.close();

We are using ui-bootstrap 0.13.0 and using $modal also. Just tried upgrading to angular 1.4.0 and now see this issue. The modal appears to close, but the element is still there. We are using backdrop static, so the page is then unresponsive, and the divs are still found when using the developer element explorer.

Also seeing this issue on ui-bootstrap 0.13.0 & angular 1.4.0

+1
same issue here.  If I set animation: false the modal does disappear.   We compared the default angular-bootstrap modal template with our own template.
Our Template
    $templateCache.put('template/modal/window.html',
        '
\n' +
        '

\n' +
        '
');

Angular Bootstrap Default Template
  $templateCache.put("template/modal/window.html",
    "
\n" +
    "

\n" +
    "
\n" +
    "");

I know it looks mucky, but we started moving one attribute over to our template one at a time. It so happens the first attribute we moved over fixed it: modal-render=\"{{$isRendered}}\".
So if you are overriding the modal template, perhaps you need to update it to match the default.
BTW: does anyone in the Angular community know what semver is?

 We
compared the default angular-bootstrap modal template with our own template.
Our Template
$templateCache.put('template/modal/window.html',
    '
\n' +
    '

\n' +
    '
');

Angular Bootstrap Default Template
$templateCache.put("template/modal/window.html",
"
\n" +
"

\n" +
"\n" +
"");
I know it looks mucky, but we started moving one attribute over to our
template one at a time. It so happens the first attribute we moved over
fixed it: modal-render="{{$isRendered}}".
So if you are overriding the modal template, perhaps you need to update it
to match the default.
BTW: does anyone in the Angular community know what semver
http://semver.org/ is?
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/bootstrap/issues/3624#issuecomment-115429123
.

@jberk It's a beautiful thing, but it doesn't seem like Google and Twitter follow it perfectly.

I'm experiencing the same problem, the modals were working as supposed to, but after a "bower update" (angular went from 1.3.16 to 1.4.1 and angular-bootstrap from 0.12.1 to 0.13.0) modals doesn't "close" anymore.
Quotes on close because when I click on the close button (or outside a non "static" modal for that matter) the modal disappears from the view (but not from the DOM) and the backdrop stills showing, so it is impossible to interact with the page.
Any thoughts?

@moich4no - Angular 1.4.x is not supported yet.

@311chaos Sure... My mistake...


[postgresql] issue with replica creation when database is large

Describe the bug
The creation of a new replica fails when the database to replicate is very large. It seems that the pod is restarted by the readiness probe whilst importing the data into the database. As the import and setup are not yet finished the next start fails.
Version of Helm and Kubernetes:
Kubernetes 1.18
Which chart:
Postgres
What happened:
Database creation/import for slave is interrupted because of readiness probe restarting the pod. When the pod has restarted it complains the postgres folder is corrupted (missing postgres version).
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Primary with a very large database and add a replica, log follow and see the process being interrupted.
Anything else we need to know:

Hi, @leforthomas!
I suggest checking with the current maintainers of the Helm chart you're using if you believe something in the chart is causing this behavior. This repo is the former home of helm charts which are now found at Artifact Hub. Project support is not available in this repo. Thanks!


Overwrite metadata in PreUploadCreateCallback if metadata is available in the hook response

This pull request allows metadata returned by the pre-create hook in the "Upload-Metadata" header to be processed in the PreUploadCreateCallback. If the pre-create hook returns metadata in the "Upload-Metadata" header, the PreUploadCreateCallback sets this metadata in the FileInfo object and overwrites the original data.
This allows metadata from the pre create hook to be modified.
If no metadata comes back from the hook the original data is used.
See also this question: https://github.com/tus/tusd/issues/811

Hello,
I just wanted to ask if there is an update on this topic.
Many greetings,
Jonas

Hi Jonas, thank you very much for this PR. As mentioned before, we are interested in adding functionality to modify the upload ID and meta data in the pre-create hook. I am not sure if this will be included in the first proper release of v2 or only later.
While your approach works, I was more thinking about utilizing the new HookResponse struct to add a field for specifying additional meta data that the pre-create hook wants to set: https://github.com/tus/tusd/blob/aff352c413066bc5bfa53f6998024b5ef29240f3/cmd/tusd/cli/hooks/hooks.go#L33
This way, the feature is more explicit, discoverable by users and converted by type checks. What do you think?

Thanks for your answer. Adjusting the HookResponse is of course also a good solution. I chose the solution based on the header because I wanted to use as much existing code from you as possible to have as few changes as possible in my pull request.
But maybe the two solutions are not mutually exclusive. In a first solution, the metadata could be changed based on the response header. And in the future, also via the HookResponse if you adjusted it.

Hello @Acconut
are there any news from your side regarding this topic?
Many greetings,
Jonas

Hello @Acconut
I have changed the pull request as you suggested and added an "AdditionalMetaData" to the "HookResponse". I hope the solution corresponds to your idea?
Many greetings,
Jonas

Hi @Acconut
I just want to ask if you have already found time to look at the new solution.

Hi @Acconut
I just want to ask if you have already found time to look at the new solution.

Hi @Acconut
I just want to ask if you have already found time to look at the new solution.

Hi,
a few months ago I updated the pull request as you suggested and added an "UpdatedMetaData" to the "HookResponse". Could you please add you thoughts regarding this? Or is there any other update from your side?
It would be really helpful for us if we could merge this pull request.
Thank you in advance and many greetings,
Jonas

Thanks for the updates. I think the structs are getting a bit confusing right now. In v2, we have

handler.HTTPRequest
handler.HTTPResponse
handler.HookEvent (which includes handler.HTTPRequest)
hooks.HookRequest (which includes handler.HookEvent)
hooks.HookResponse (which includes handler.HTTPResponse)

Your PR now also introduces a handler.HookResponse, which is not directly connected to any of the previous types. That is a bit too much and even confuses me. I am not saying that we shouldn't have a handler.HookResponse (we already have a handler.HookEvent), but we should think careful on how to lay out the structs here.
However, I don't have a good proposal right now. What do you think?

What about rename handler.HookResponse to handler.UpdatedFileInfo? Then we don't need the "updated" term in "UpdatedMetaData" and could name it "MetaData".

Hi @Acconut
any update from your side on this topic? Should I implement the renaming to "handler.UpdatedFileInfo"?

Hi @Acconut
any update from your side on this topic?
Should I implement the renaming to "handler.UpdatedFileInfo"?

Any update on this topic?

@jonaskaltenbachz Thank you very for your persistence here! In the meantime, I implemented some minor refactoring to the handling of response hooks (https://github.com/tus/tusd/commit/d5eca08944f30441618a2b5a0a184ad698222ec4 and https://github.com/tus/tusd/commit/b10c1876b1573d007228eea36f7e8af7ec8bfb86). This made it simpler to add optional return values from the pre-create hook. Based on your PR and our discussion, I then implement a system very similar to what we agreed on in #962. The overall idea is still the same, but names are slightly different and logic is in more appropriate places now.
Thank you very much for your work and dedication here, Jonas! It would be greatly appreciated if you and @genofire could have a look at the new PR.


Inverted borders with FTerm and SnipRun

In Neovim v0.5.0-dev+1318-g61aefaf29, using the solarized variant of this theme, the borders become inverted while using FTerm and SnipRun.
At the beginning, I didn't know where to report this because I also noticed this behaviour in older, built-in colorschemes, so I opened an issue with screenshots and steps to reproduce for FTerm and later for SnipRun.

I will look into it thanks.

Made some changes with the commit 526939389db64ce818642e3e52641f8276ed7470. Can you take a look into it.

The borders in those two plugins now look good, as well as borders between splits in general. (I thought this latter was a "feature", so I didn't mention it. But I like it better now.)
Thank you very much!


Setup project using Remix Blues Stack

Description
We need an initial setup for Starchart using Remix Blues Stack script as a starting point so that required features and functionalities from Satellite can be ported over later.
Resources
Remix Blues Stack

This is great.  I'd love to see us get this landed pretty quickly in the 0.1 release cycle, since almost all other code needs to sit on top of it (i.e., Remix will be our front-end and much of our back-end too).  Thanks for filing this.

Working on this.


Inconsistant naming in Estimator documentation

Doc Link: https://www.tensorflow.org/api_docs/python/tf/estimator/Estimator

In the section for export_savedmodel, it mentioned export_to_savedmodel which seems should be export_savedmodel. Maybe worth a fix.

I am new here. Can I take this up?


How can I download .json for an unaired live stream who's link is live

Checklist

[ x] I'm asking a question
[ x] I've looked through the README and FAQ for similar questions
[ x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
I'm trying to download the .json and thumbnail of a not yet aired live stream who's link is already live
The command I used is:
youtube-dl --write-info-json --write-thumbnail  --skip-download https://www.youtube.com/watch?v=dvZITERT7Rw
I get the following error message:
ERROR: This live event will begin in 53 days.
Is there anyway I can make youtube-dl download the data that is already there before the stream goes live?

Not possible.

Not possible.


Accepting invites on macOS shows Linux instructions

    It's recommended to now keep the interface automatically refreshing via systemd:

        systemctl enable --now innernet@divvun

systemctl doesn't exist on macOS. Are there equivalent macOS instructions yet?

There is no systemd for macOS. The equivalent to run services is launchd which controllable with launchtl and plist files.
I wonder how you managed to build without it. Did the cli install a systemd unit file on your mac?
Homebrew has a neat wrapper around launchctl with brew services. Ultimately I wonder if it is possible to integrate this into the tap release for brew services start innernet@divvun

Thanks for opening an issue about this! Yeah, that string is wrong on macOS. I think the easiest step would be to integrate with brew services and possibly also to have a launchd script generator.


cleaning up: draft pr

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

cleanup looks good. Couple of comments that can be handled in the main branch as well.

Change vmss_Cache.go to vmss_cache.go.


[FLINK-36956][transform] Append NOT NULL attribute to PK columns

This closes FLINK-36956 by appending NOT NULL attribute to columns that declared as Primary Keys.

@lvyanquan @Shawn-Hx PTAL


🛡 Revendor<EMAIL_ADDRESS>update Golang version to 1.17, enable ServiceAccount token projection

How to categorize this PR?

/area security
/kind enhancement
/os suse-chost
/merge squash
What this PR does / why we need it:

Revendor<EMAIL_ADDRESS>Update Golang version to 1.17.
When the extension is running on a seed with a gardenlet of at least v1.37 then ServiceAccount token projection is enabled.

ℹ The branch.cfg definition is still using Golang 1.16, hence, the verify step may fail. Once this PR is approved, we can adapt the branch.cfg (also update to 1.17) and then re-trigger the CI pipeline for this PR.
Which issue(s) this PR fixes:
Part of gardener/gardener#4659
Part of gardener/gardener#4878
Special notes for your reviewer:
✅ ~Depends on https://github.com/gardener/gardener/pull/5162 and v1.39 release, hence, PR is in draft state.~
Release note:

The Golang version has been updated to `1.17.5`.

The extension controller uses a projected `ServiceAccount` token in case it runs on a seed with a gardenlet of at least `v1.37` or higher.

/ready
/invite @BeckerMax @timebertt
/invite @vpnachev

Great, thanks for your help!

/ok-to-test


Add using spire tokens back to the node-heartbeat

Summary and Scope
When the node heartbeat code was pulled over from the SKERN repos it was pulled over with SPIRE token use disabled. This mod puts the SPIRE token code back into place. The proper way to disable SPIRE token use is to modify the /etc/sysconfig/heartbeat file and set USE_TOKENS to true.
Issues and Related PRs

Resolves CASMTRIAGE-5649

Testing
TBD
Tested on:

drax

Test description:
Manually installed the RPM and verified that once the service started that ncn-s002 went to Ready in HSM.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? N
Were continuous integration tests run? If not, why? Y
Was upgrade tested? If not, why? Y
Was downgrade tested? If not, why? N - just tested on a single node, leaving it in place for now
Were new tests (or test issues/Jiras) created for this change? N

Risks and Mitigations
No known risks
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

Looks like this PR is stale. Newer version of heartbeat exists.


Isn't generating same UUID for a given string always

Code snippet:
import generateUuid from "uuid-by-string";
convertStringToUUID (stringToConvert: string) {
const uuidHash = generateUuid(stringToConvert);
return uuidHash;
}

Woks fine after adding a namespace

@Arsasana in the previous version, there was an processing bug some utf-8 characters because of this, the function could return the same uuid for different inputs. The problem has been fixed in version 4.0


Add SimpleOperationTracker option for undelete

This PR adds SimpleOperationTracker to Undelete in case where we need it.
Undelete is considered as an Administrative operations. We can relax the global quorum requirement for undelete some times.

Codecov Report
Patch coverage has no change and project coverage change: -54.18 :warning:

Comparison is base (d84f34f) 68.63% compared to head (98cd3cd) 14.45%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2414       +/-   ##
=============================================
- Coverage     68.63%   14.45%   -54.18%
+ Complexity    10143     2347     -7796
=============================================
  Files           773      773
  Lines         60435    60461       +26
  Branches       7401     7405        +4
=============================================
- Hits          41477     8738    -32739
- Misses        16584    51218    +34634
+ Partials       2374      505     -1869

Impacted Files
Coverage Δ

...ain/java/com/github/ambry/config/RouterConfig.java
0.00% <0.00%> (-98.58%)
:arrow_down:

.../github/ambry/router/NonBlockingRouterMetrics.java
0.00% <0.00%> (-89.37%)
:arrow_down:

...om/github/ambry/router/SimpleOperationTracker.java
0.00% <0.00%> (-96.04%)
:arrow_down:

...ava/com/github/ambry/router/UndeleteOperation.java
0.00% <0.00%> (-80.65%)
:arrow_down:

... and 587 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


JOINDIN-730 clicking claim talk twice

Distingish between user making a claim and user approving a claim

Can one of the admins verify this patch?

ok to test

Closed in relation to https://github.com/joindin/joindin-api/pull/398


Key bindings for most common commands?

Having just installed and configured the CoPilotForXcode extension all works great but my experience is that I had to always select the menu options to get CoPilot suggestions/actions (maybe I did not setup everything correctly??).
Could creating some default keybindings help with this?
For some, keybindings are a very personal choice as they are often customised but I found these worked pretty well and did not conflict with any existing/standard Xcode keybindings.
CoPilot -> Get Suggestions:  ⌥?
CoPilot -> Accept Suggestion:  ⌥}
CoPilot -> Reject Suggestion:  ⌥{
CoPilot -> Next Suggestion:  ⌥>
CoPilot -> Previous Suggestion:  ⌥<
Essentially using ⌥⇧ as the "access" key combination for all bindings.

Thanks for sharing, I don't think we can add default key bindings to commands, but will add this recommendation to readme.

A key binding section is added to README.md with your recommendation.

Suggesting another set of key bindings...

i think add this key bindings is very helpful for me, thanks @KieranConlon and hope can add into README

They are now added to readme

xcode setting  did not show the CoPilot key bindings. Anyone know Why?

@13088992520 Please make sure you have enabled the source editor extension https://github.com/intitni/CopilotForXcode#enable-the-extension

Hey guys! Just installed copilot for Xcode. I followed the recommended key bindings but whenever I use option + shift + }, it gives me a single quote. I have an external keyboard but it has a Mac toggle if that makes a difference. Thank you for any tips! I am new to the Mac world to learn swift so I am not sure if I am doing something wrong haha. Windows user most of my life.

@lisbonc1987 Make sure that you have setup the shortcuts in Xcode's Key Bindings as that will override the default key press.
To be honest, it doesn't matter if you have an external keyboard (I use an external keyboard 99% of the time with my MacBook Pro).
BTW welcome to developing with a Mac.  As they say, once you go Mac you never go back!
Next thing you will discover Homebrew and get all the command line tools and libraries that you never knew you needed!!!  :)


Cannot run in Android Studio

Hi,
I am trying to run a project in Android Studio.  I followed your directions in the README, and upon executing  sbt ~android:run I get this error:

[error] (android:rGenerator) com.android.ide.common.process.ProcessException: Return code 1 for process '/Users/eazyigz/Library/Android/sdk/build-tools/23.0.2/aapt package -f --no-crunch -I /Users/eazyigz/Library/Android/sdk/platforms/android-23/android.jar -M /Users/eazyigz/git/square/u2020/target/android/intermediates/manifest/AndroidManifest.xml -S /Users/eazyigz/git/square/u2020/target/android/intermediates/res -A /Users/eazyigz/git/square/u2020/target/android/intermediates/assets -m -J /Users/eazyigz/git/square/u2020/target/android/generated/source -G /Users/eazyigz/git/square/u2020/target/android/intermediates/proguard/proguard.txt --debug-mode --custom-package com.jakewharton.u2020 -0 apk'
[error] Total time: 1 s, completed Dec 6, 2015 7:26:57 PM

Please advise,
Igor

Always provide complete logs.
--
Sent from my phone
On Dec 6, 2015 4:39 PM, "Igor Ganapolsky"<EMAIL_ADDRESS>wrote:

Hi,
I am trying to run a project in Android Studio. I followed your directions
in the README, and upon executing sbt ~android:run I get this error:
error com.android.ide.common.process.ProcessException: Return code 1 for
process '/Users/eazyigz/Library/Android/sdk/build-tools/23.0.2/aapt package
-f --no-crunch -I
/Users/eazyigz/Library/Android/sdk/platforms/android-23/android.jar -M
/Users/eazyigz/git/square/u2020/target/android/intermediates/manifest/AndroidManifest.xml
-S /Users/eazyigz/git/square/u2020/target/android/intermediates/res -A
/Users/eazyigz/git/square/u2020/target/android/intermediates/assets -m -J
/Users/eazyigz/git/square/u2020/target/android/generated/source -G
/Users/eazyigz/git/square/u2020/target/android/intermediates/proguard/proguard.txt
--debug-mode --custom-package com.jakewharton.u2020 -0 apk'
[error] Total time: 1 s, completed Dec 6, 2015 7:26:57 PM
Please advise,
Igor
—
Reply to this email directly or view it on GitHub
https://github.com/pfn/android-sdk-plugin/issues/237.