Update FaceAPIinJavaForAndroidTutorial.md

@miparnisari : Thanks for your contribution! The author, @SteveMSFT, has been notified to review your proposed change.

@miparnisari : Thanks for your contribution! The author, @SteveMSFT, has been notified to review your proposed change.

@miparnisari : Thanks for your contribution! The author, @SteveMSFT, has been notified to review your proposed change.

@miparnisari : Thanks for your contribution! The author, @SteveMSFT, has been notified to review your proposed change.

@miparnisari : Thanks for your contribution! The author, @SteveMSFT, has been notified to review your proposed change.

#sign-off

@huxuan: I'm sorry - only the author of this article, @SteveMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@SteveMSFT , Hi Steven, seems that you need to comment with #sign-off as I have to actually approve the pull request.

@huxuan: I'm sorry - only the author of this article, @SteveMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@huxuan: I'm sorry - only the author of this article, @SteveMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Link locations on opening hours page

Looks good! What would you think of adding a link to the locations:
Library 52/1-052: https://maps.cern.ch/?n=['3/1-003','52/1-052','52/1-204']
Desk 52/1-054: https://maps.cern.ch/?n=['52/1-054']

Originally posted by @salomerohr in #353

Ok for me!


fix memcache-tool - fix missing exptimes

dump is missing exptimes:
add somekey 1  1
1

Duplicate of #448

sorry about that, I'm doing a bug burndown soon!


To run this project make sure you upgrade your python version

Just writing for helping anyone experiencing installation issues or using python version lower than 3.7
This project will not be able to install the dependencies needed if you are using python version lower than 3.7
I just upgraded to latest python version 3.8.5 and it installs the dependencies and everything runs fine :)

Yes. Sorry about this. I will update the docs and README.

This should be fixed in v0.2.0.


Move environment and utilities classes to src/main in engine-test

The PR effectively removes all tests and test resources from the engine-tests.jar. This change should be mostly transparent as nothing should rely on any of the tests.
This also simplifies the build script somewhat.
Helper classes, utilities and environment classes have been moved to src/main to make them available as before.
As a result, modules will not have the `logback.groovy' from engine-tests in their classpath by default and can define their own.
Unfortunately, Eclipse still does not distinguish between compile and testCompile (this was reported in 2008). Therefore the test resources are also available in regular code (main) and must still be removed manually :cry:
Jenkins runs the PR just fine: http://jenkins.movingblocks.net/job/TerasologyTemp/10/
I tested this code in every aspect I could think of, but it would be good if someone could test it in IntelliJ (with a mega-workspace maybe?) to verify that it works as expected. Maybe I'm missing some side-effect.

Thanks, I'll definitely give this a look tonight :-)
Slight tangent: Could you check on #1578 real quick sometime soon? I'd like to get that fixed and do a stable build before merging this and #1575

Test classes should not be engine.
Engine should not depend on junit.

Well, sure, but the idea here was more to put the utility classes involved in testing somewhere other than engine-tests, so modules would only need a dependency on engine, not engine-tests. Helps straighten out some of dependency quirks, and might even allow a full collapse back into engine (with main and test source sets) without a separate engine-tests.
Maybe said utility classes still need to be transformed somewhat to fit properly, or maybe too many are being moved. For instance HeadlessEnvironment is one of the prime candidates for the move. Doesn't it make sense for it to be in engine?

w00t! This PR just moves the files inside engine-tests, namely from test/java to main/java.
No test classes were moved to engine.
Engine does not depend on JUnit.
In fact, the dependency of modules to JUnit has been removed (it's not required since they depend on engine-tests).

Ah, I see. I completely misread that.

Finally time to check this, woo! First observation: IntelliJ can blindly build from clean state without running into compilation order issues (usually would get issues with stuff in engine-tests failing to find stuff in engine unless force-compiling it first). Yay! Although I guess Eclipse got less pretty? Boo, but .. as long as you're on top of it! :-)
Weirdly 6 tests do fail in IntelliJ:

PrefabTest
** prefabHasDefinedComponents
** prefabTransitiveInheritance
** getSimplePrefab
** prefabHasDefinedComponentsWithOrderedMap
** prefabInheritsFromParent
FactoryTest
** testSaveLoad

Probably related to loading test resources - stuff like:
00:53:19.570 [main] DEBUG org.reflections.Reflections - going to scan these urls:
file:/C:/Dev/Terasology/Git/integrate/Terasology/engine/build/classes/
file:/C:/Users/Cervator/.gradle/caches/modules-2/files-2.1/org.terasology/gestalt-module/2.2.3/d7ba668655fc205f3d9da60f299ff4ab6f9fac4f/gestalt-module-2.2.3.jar
00:53:20.841 [main] INFO  org.reflections.Reflections - Reflections took 1269 ms to scan 2 urls, producing 509 keys and 2538 values
00:53:20.848 [main] WARN  org.reflections.Reflections - given scan urls are empty. set urls in the configuration
00:53:20.854 [main] DEBUG org.reflections.Reflections - going to scan these urls:
file:/C:/Dev/Terasology/Git/integrate/Terasology/engine-tests/build/classes/
00:53:20.874 [main] INFO  org.reflections.Reflections - Reflections took 20 ms to scan 1 urls, producing 9 keys and 30 values
00:53:20.875 [main] WARN  org.reflections.Reflections - given scan urls are empty. set urls in the configuration

java.lang.NullPointerException
	at org.terasology.entitySystem.PrefabTest.prefabHasDefinedComponents(PrefabTest.java:92)

Trying from straight Gradle gets me the same results, had thought maybe it related to a way IntelliJ sorts stuff. But it worked in Jenkins ... hmm.
Anyway, merging, then we'll see. Figuring easy fix and we aren't doing the PR test yet so this won't break that. And this is last on my list before I get to work on Jenkins Droplets, yay! Until I go to sleep and wake up with another half dozen new PRs to review ;-)

The 6 tests failed in Jenkins this time too 0_0
http://jenkins.terasology.org/job/Terasology/1352/
Dunno if we made any related changes since this PR went up (or more accurately 9 days ago when the commit was made) that could explain it. Too late for me to think much :-)

I had a look at that and found out that:

eclipse puts everything in one folder - that's why it works for me
Jenkins (the TerasologyTmp job) only git cleans, but does not wipe out, which seems to leave old build files untouched. That's why it still worked there. It runs the "clean" gradle task though - weird..
Setting the output folder for test and test resources to build/classes/main makes the tests compile again, but this is almost as bad as before.

A proper solution would be to:

Explicitly specify additional (test) resources in ModuleManagerFactory to make them available for tests.
or get the assets into "main" (not very clean, but could be quick workaround). A simple move doesn't work though.

@immortius - thoughts on better support for test stuff in ModuleManagerFactory to keep the source tree more sane?
Maybe we should make a new issue with these notes so we won't forget these comments in a merged PR

Yeah, the module stuff is proving a little tricking around testing. The problem is in some environments (gradle) the resource and classes are not combined into one classpath location. The classpath module is set up so you provide a number of classes to indicate classpaths that should be added to the module, but again there is no class in the resource folder to use an indicator. I did add the ability to add all lose folders on the classpath into a classpath module, but this only helps if there is only one such module to deal with.
Otherwise... I've been using a "virtual modules" system in gestalt-assets-core pretty successfully - see: https://github.com/MovingBlocks/gestalt-assets-core/blob/develop/src/test/java/org/terasology/assets/test/VirtualModuleEnvironment.java .  It only works for resource-only modules though.
Perhaps we should just drop test assets from engine-tests.jar and use virtual modules for those? Then engine would be loaded up to include directories on the classpath, other test assets would be in their virtual modules?

@immortius - the tweak over in #1598 made it work for now, do you think that's a suitable fix to keep around for a while? It sounds like you've got a grander design for future improvements :-)


account for partial volume effect with CSF and GM

Is it done with map estimation?

yes! so i'm closing it :-)


easier kind prereq setup. fix register cluster instruction

Signed-off-by: Mike Ng<EMAIL_ADDRESS>relies on the foundation changes at https://github.com/open-cluster-management/registration-operator/pull/90

lgtm, thanks!
let's merge the pr in registration-operator at first :)


Feat cache manager

Information

Type
Breaking change

Feature/Fix/Doc/Chore
Yes/No

Description
A few sentences describing the overall goals of the pull request's commits.
Usage example
Example to use your feature and to improve the documentation after merging your PR:
import {} from "@tsed/common";

Todos

[ ] Tests
[ ] Coverage
[ ] Example
[ ] Documentation

:tada: This PR is included in version 6.30.0 :tada:
The release is available on:

v6.30.0
GitHub release

Your semantic-release bot :package::rocket:


Allow for custom resolvers with no arguments

Allow for creating resolvers that take no arguments.  E.g., OmegaConf.register_new_resolver("cpus", lambda : os.cpu_count)
Currently attempts at this throws an exception.

Passing fake value should work ?
${cpus:temp}
OmegaConf.register_new_resolver("cpus", lambda x : os.cpu_count)

That's a kludge that works but is a bit ugly.  It'd be cleaner and more intuitive if the package supports my original intent.

I'd love to have this feature too. If you are open to PR's and can give me a rough sketch of what will be impacted in the code, I , I can give it a try.

I just tried it and this is working => closing the issue (please re-open with a specific example if the issue still persists on your side)

Hi, I'm trying to use custom resolvers with no params and I'm hitting the same issue reported here. Minimal reproducible example:
import random

from omegaconf import OmegaConf

OmegaConf.register_new_resolver("plus_10", lambda x: x + 10)
OmegaConf.register_new_resolver("random_number", lambda: random.randint(0, 1000))

c = OmegaConf.create(
    {
        "key": "${plus_10:990}",
        "key2": "${random_number}",
    }
)

print(c.key, c.key2)

Output:
...
omegaconf.errors.InterpolationKeyError: Interpolation key 'random_number' not found
    full_key: key2
    object_type=dict

Interestingly, adding : with or without any dummy parameter seems to work, but it's not very idiomatic:
import random

from omegaconf import OmegaConf

OmegaConf.register_new_resolver("plus_10", lambda x: x + 10)
OmegaConf.register_new_resolver("random_number", lambda: random.randint(0, 1000))

c = OmegaConf.create(
    {
        "key": "${plus_10:990}",
        "key2": "${random_number:}",
    }
)

print(c.key, c.key2)

Any thoughts?
Additional context

[x] OmegaConf version: 2.3.0
[x] Python version: Python 3.10.4
[x] Operating system: 5.13.0-41-generic #46~20.04.1-Ubuntu SMP Wed Apr 20 13:16:21 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux


Update favicon

🛠 Fixes Issue

👨💻 Changes proposed
Updated favicon to a transparent GDSC logo
🔧 Check List (Check the type of issue it fixes)

[ ] Bug Fix
[ ] New Extension
[✔ ] Enhancement
[ ] Documentation

✔ Check List (Check all the applicable boxes)

[✔ ] My code follows the code style of this project.
[✔ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ✔] My changes generate no new warnings
[ ✔] Any dependent changes have been merged and published in downstream modules
[✔ ] I have done git pull before adding my new changes
[✔ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots

#12


[RESOLVED] IDRAC_83 has been restarted (uptime < 10m)

Problem started at 19:38:57 on 2023.06.24
Problem name: IDRAC_83 has been restarted (uptime < 10m)
Host: IDRAC_83
Severity: Warning
Operational data: 00:03:46
Original problem ID: 29104
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23186&eventid=29104

Problem has been resolved in 6m 30s at 19:45:27 on 2023.06.24
Problem name: IDRAC_83 has been restarted (uptime < 10m)
Host: IDRAC_83
Severity: Warning
Original problem ID: 29104


I'm free user

That's a chat on the left, in the sidebar, not code. Try typing inside the editor. You can see Refact status bar icon at the bottom, when it fetched code completion you'll see there a rotating icon.

let us know if there's a bug


Add npm instructions to readme.md

Enquire can't be found on NPM easily because another package comes up in Google first. Adding the reference to the right package will stop issues like #136 being reported.

I've done this locally, as I wanted to make a few other changes while I was at it

I will push changes today/tomorrow


test expecting a config file

It looks like the test test_gmt requires a config file. Is there one that can be included in the test directory?
______________________ ERROR collecting tests/test_gmt.py ______________________
test_gmt.py:14: in <module>
    from gmsimviz import gmt
../../../gmsimviz/gmt.py:22: in <module>
    from gmsimviz.config import config
../../../gmsimviz/config.py:8: in <module>
    with open(config_file, "r") as f:
E   FileNotFoundError: [Errno 2] No such file or directory: '/.../gmsimviz/config.json'

related to the JOSS review openjournals/joss-reviews#808

config.json is generated as part of running setup.py install which is part of the install instructions.
i have added a default to the repository to make pytest run even without installing gmsimviz
at least 2 tests will still fail unless the plotting resources are downloaded as per instructions on main github page or when setup.py install attempted

download archive here:
https://github.com/ucgmsim/GMSimViz.git
exctract such that the directory exists:
/resources


As a Data owner/Data manager I want to add to an existing dataset ..so that I do not have to create a new dataset each time with new metadata if this is not required

original id#17

See issue #22, process is the same.


New status dialog

Add new status dialog which will show current choises(without buttons)

Status dialog has been added.


Use json.RawMessage to represent JSON type struct fields instead of []byte

What do you want to change?
Hi there,
I'd like to ask for an update to how structs are generated. Instead of using []byte to represent a JSON type field, use json.RawMessage. This affects serialization and deserialization primarily.  It could of course just be optional.
What database engines need to be changed?
PostgreSQL
What programming language backends need to be changed?
Go

As far as I can tell, sqlc does use json.RawMessage for PostgreSQL JSON database columns. Here's a playground link to demonstrate: https://play.sqlc.dev/p/e54dc46953ed8e3c1be0875c17b84ddb53f65825afc1f20b014d78309331f5b2
In what context are you seeing []byte?

As far as I can tell, sqlc does use json.RawMessage for PostgreSQL JSON database columns. Here's a playground link to demonstrate: https://play.sqlc.dev/p/e54dc46953ed8e3c1be0875c17b84ddb53f65825afc1f20b014d78309331f5b2
In what context are you seeing []byte?

it does not use it to represent struct fields or on receivers for me.

it does not use it to represent struct fields or on receivers for me.

Understood, I just can't reproduce that behavior. Can you provide an example using https://play.sqlc.dev or modify the one I linked previously?

it does not use it to represent struct fields or on receivers for me.

Understood, I just can't reproduce that behavior. Can you provide an example using https://play.sqlc.dev or modify the one I linked previously?

You are very nice! thanks.
The reproduction is simple, the issue is when using pgx.
See this: https://play.sqlc.dev/p/02d8afb0d4d5c2f12f31141833558cb6342747a6eb44f6264f2c2462d2f276b1
I updated the config to use pgx, and added a json value to the model. The result is this:

I think this can be filed as a bug when using pgx

I see, thanks for updating the example. I found an older issue (https://github.com/sqlc-dev/sqlc/issues/2801) which describes the difference in behavior when using different drivers. There is an override workaround described there that should work for you.
I think arguably json.RawMessage should be the default, but since it's a breaking change it will have to wait for a major release. I've added it to the list.

Much obliged!


Create working title of project

We need an efficient working title for this project

Why yes Erik we certainly do

gg wp


Where are the general settings?

I am speaking in terms of liking/following/unfollowing/commenting on those that fall under specified #'s.  Thanks!

Currently they're found here:
https://github.com/ohld/instabot/blob/master/instabot/bot/limits.py
MAX_LIKE_PER_DAY = 1000
MAX_FOLLOW_PER_DAY = 350
MAX_UNFOLLOW_PER_DAY = 350
MAX_COMMENT_PER_DAY = 100
MAX_LIKES_TO_LIKE = 80


Improve CI/Jenkins infrastructure

We want to make our test infrastructure more transparent to communities. Jenkins currently belongs to CoreOS and only CoreOS employees can configure jobs and tests. To address https://github.com/coreos/etcd/issues/8862, a set of sub tests will need to be added to our Jenkins. This will be problematic if only CoreOS people can edit/add tests to Jenkins.
Ideally, we should host public Jenkins for etcd community. If not, we should at least document and host test scripts in etcd repository.

Just to clarify our plan for 3.4, we will first organize all Jenkins test scripts in etcd repository.
And we will take care of the public access later.


Will Buck2 work with Sun Grid Engine for remote execution?

Hi we have a codebase with mixed Python/C++ held with make duct tape. I am thinking of undertaking a study to integrating buck2 for this codebase, we have a Sun Grid Engine infra and I was wondering if this would work as a remote execution target for Buck2?

There's nothing stopping you, but it would be a significant undertaking.
There are many places you could add SGE, but most are a bad idea.

Don't add support directly to Buck2. Nobody is going to maintain that, and anyway, SGE alone is not a cache, RE is not worth it without a cache.
Don't write a Bazel RBE implementation from scratch. Same problem. You'll need to write an action cache + content-addressed storage implementation, which is just so immense an undertaking, and other people have already done this.
Don't shoehorn SGE queue submission into another Bazel RBE implementation as a "worker" -- you'll count "scheduled on SGE but not yet executing" time as executing, which will be weird, you'll never see how long anything truly takes to execute.
Do try to slot SGE in as the the scheduler + worker portion of another Bazel RBE implementation.

Maybe you could implement a nativelink scheduler that lays out files in NFS for the job, simply uses qsub to execute, and doesn't use any nativelink workers. This could be done outside the nativelink binary by implementing the GRPC scheduler protocol that nativelink defines, which you could do in a language of your choice. I would talk to them about it, see what they say, I don't know how stable that GRPC API is and it may only be intended to spread nativelink over multiple machines. But I think that's the right level to do this kind of work at.

Excellent points, I had ruled out 1 and 2, was considering 3 and 4. Appreciate the insights and advice, I might try and explore the nativelink option for my own education, but yeah remote execution can be postponed for later.
Thanks for the feedback, closing this issue as solved.

I do think it would be very cool and a great use of compute resources you've already got. Good luck!


update: README.md to reflect the latest version

@RobertCraigie please consider prioritizing this one, it's a little change that may save some headaches to people.
Right now when one follows the readme to configure pyright with pre-commit the following error occurs:
An error has occurred: InvalidManifestError:
=====> /Users/gius/.cache/pre-commit/repo0hi7c8c9/.pre-commit-hooks.yaml is not a file
Check the log at /Users/gius/.cache/pre-commit/pre-commit.log


Fails with non-existing file

In a unpiped context, creating an instance with a non-existing path fails:
var filed = require("filed")
f = filed("./unexisting-file")

returns
{ writable: true,
  readable: true,
  buffers: [],
  path: './toto.txt',
  index: 'index.html',
  _events: { pipe: [Function] },
  buffering: true,
  mimetype: 'application/octet-stream' }

but also throws
events.js:48
        throw arguments[1]; // Unhandled 'error' event
        ^
Error: ENOENT, No such file or directory './toto.txt'

no time to call write() or end(), it has already failed
I suppose it's linked to the fact that there is no pipe around, because this works:
filed("existing-file").pipe(filed("unexisting-file"))

Anyway, the very first example of the README fails because of this issue :x

I found a way to fix it, at line 46:
if (err && !self.dest && !self.src) return self.emit('error', err)

we should add before this line:
if (err && err.code === 'ENOENT' && !self.dest && !self.src) self.src = self.path

This way the call to finish() would go until line 141 and create a WriteStream.

Closed by PR


PublishSymbols: Excluding directory matches returned Find-VstsMatch, during publish

The api Find-VstsMatch(*) returns directories as well, and  trying to open the directory like a file causes the task to fail.
Typically users use *.*, which often skips directory as long as it does not contain a .,
In our builds we have . in directories (like App.L0.Tests)

@arunkm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Allow exception logging to be customizable for activity failures

Is your feature request related to a problem? Please describe.
We have some use cases where we leverage ApplicationFailure.nonRetryableError for some failures that we expect to happen from an activity.
In these cases, we don’t want these failures to be logged as error. Since we also use a service like Sentry for exception monitoring in our prod services, these expected activity failures will pollute the log and would prefer to only log unexpected failures.
Describe the solution you'd like
Some approach to customize activity failure error logging.
Maxim's proposal was to create a logger per error type as described in here: https://community.temporal.io/t/java-sdk-allow-exception-logging-to-be-customizable-for-activity-failures/2887
Describe alternatives you've considered
An alternative I've considered was to never let expected failures to cause an ApplicationFailure but to model this into a return type.

My current view is that we should add a flag (or separate method for creation) to allow creating an ApplicationFailure that is not logged. All other failures are logged.

We should also cover the generation of activity exceptions in the ActivityTaskExecutor when executing the activity. Specifically for data converter excpetions.

I also need to customize the logging configuration. I use activities for polling, and I throw exceptions from the activity to retry the poll. This currently pollutes the logs. Is there any update on this?

+1 on this
We use activities for polling and the constant failures pollute the logs a lot


Bot Manager is missing link to Learn more when a bot fail to run

Describe the bug
The Bot Manager drawer does not provide a link for more information when your bot fails. Previous versions did include a link.
Version
Version:  1.3.1-nightly.217293.c1e5de3
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[x] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Open a bot project.
Start all bots.
I get this message in the bot manager when the bot has fails to start:

Previously, the bot manager would provide a link to show the error details and clicking on the link would show more information about the error:

Expected behavior
I expected there to still be a link for more information about the error. (The formatting and content of the details might still need work, but I think it was better than no information at all.)

Great catch @mewa1024 . Minor regression introduced in my PR before.


About how to Train ConvNeXt-L Model

Training KITTI in README.md only mentions Python train.py./args_ Files/args_ Res50_ Kitti_ 192x640_ Train.txt, args_ There seems to be no information about the ConvNeXt-L model in the files folder. We look forward to your answer. Thank you!

Similar to training ResNet models, the args_file for ConvNeXt-L is  ./args_files/hisfog/kitti/cvnXt_L_320x1024.txt.


How to make a runtime driver? 🤔

I'm trying to create a UEFI driver that hooks get_variable before the actual OS starts, but I'm running into some problems. Firstly, when I try to load the EDK II shell, it says that it's not a driver. Secondly, when I run it from BIOS, everything freezes after it's done. I think this is because the UEFI phase has ended.
Can you please advise me on how to make a driver?
I apologize if this issue might not be related to uefi-rs, and if I did something wrong. I'm relatively new to osdev.
Thank you for your help.

the freezing was because the hook was null but I still don't know about edk II driver

Hi, can you link to a repository with your code?

Hi, can you link to a repository with your code?

Hi, I don't have a repository for it yet and I don't think my code is the problem because it doesn't even run when I use load myproj.efi in edk 2 shell it just refuses to load it and says not a driver.
But I can upload my project if needed.

I can't say for sure without seeing the code and how you are building it, but my first guess would be that you are using one of Rust's default UEFI target specifications. These inherit from uefi_msvc.rs, which sets the /subsystem:efi_application linker flag. For a runtime driver you want efi_runtime_driver instead.
You can change this by setting link-args:
# In .cargo/config.toml:
[build]
rustflags = ["-C", "link-args=/subsystem:efi_runtime_driver"]

Yes, that was the problem thanks for helping.

Do we have this in the docs somewhere? I think, we should add it to the readme. It's good to have it there.

I think it should be in the book here https://rust-osdev.github.io/uefi-rs/HEAD/tutorial/app.html

Added here: https://rust-osdev.github.io/uefi-rs/HEAD/how_to/building_drivers.html
I also added the same example to https://doc.rust-lang.org/rustc/platform-support/unknown-uefi.html, but it hasn't propagated there yet.

Amazing, thanks Nicholas!


Leverage trading

Is leverage trading supported?

yes it is  there is cross margin of 10

Thanks @Lappls but where can I find settings for leverage to use? I couldn't find anything defined on settings.py

there is a method inside the codes for setting cross-margin in the system

it defaults to 10 so there is no method or something inside setting.py file

Thanks @Abhisheksoni1 btw thanks for this awesome project. It does need allot of improvement though like probably using TA-Lib library to have more indicators.

Thank you @cofibit it means alot, Yeah we can work on TA-Lib let me know if you need my help in this i am happy to code with you :D

Hi @Abhisheksoni1 is this the method you were referring to on setting the leverage?
bitmex_bot/bitmex.py
  @authentication_required     def isolate_margin(self, symbol, rethrow_errors=False):         """Set the leverage on an isolated margin position"""         path = "position/isolate"         postdict = {             'symbol': symbol,             'enabled': False         }         return self._curl_bitmex(path=path, postdict=postdict, verb="POST", rethrow_errors=rethrow_errors)
So I just need to set enabled to True? you said that the default is 10 but where is the default leverage value value defined?

@hashtagex yes on bitmex.py there's a method named isolate_margin just set enabled to True as per @Abhisheksoni1 by default it is set to 10x leverage, I'm not sure if it does get whatever leverage you set on your account or it is hard coded to 10x.

@hashtagex yeah was trying to make bitmex work on freqtrade but was throwing allot of errors reason is that bitmex pairs are not the same with bittrex/binance format. Also this is much better than freqtrade since it is using websocket. Ccxt just polls servers and is subjected to limits.

@cofibit true, I can agree with you there. It's just limited, I like seeing and being able to control on the go. But I ran the default bot live for a bit with a few changes to the indicator numbers and didn't do too bad. I was trying to add some of my own as well, but haven't been able to implement them in the bitmex.py file. Are you making a custom one?  It seems the way it's coded it's not easily modified, as in costum strategy. But then again I'm not a pro coder. I get around. Lol.

when the bot starts it resets to Cross, should I just change the leverage through bitmex ui? using latest master, thanks

nm, tried the True value in the isolate method and started out with 50x, thanks


Tests for Waypoint: Add Borders Around Your Elements don't check for green border color

Challenge http://www.freecodecamp.com/challenges/waypoint-add-borders-around-your-elements has an issue. Please describe how to reproduce it, and include links to screen shots if possible.
There doesn't appear to be any tests for the green border color requirement. I passed the waypoint before adding 'border-color: green;' to my '.thick-green-border' class

Hey @veerhoff,
Thanks for letting us know!

fix should be up soon

Glad to help! FreeCodeCamp has been the best online resource I've found for
all-inclusive browser-based web development education. Keep it up!
On Jun 2, 2015 6:55 PM, "Berkeley Martinez"<EMAIL_ADDRESS>wrote:

fix should be up soon
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/805#issuecomment-108122862
.

Woot!


fix: model-viewer@v3 uses lottie-web as a dev dependency

This issue was caused because the lottie-web is listed as a dev dep to use it's types, in this case import statement is wrong as it would import all the module on runtime, using import type will fix the issue and used to check the types only on compilation stage
Fixes #4090

@elalish I have compiled the google cla, jjust re-run checks and should be ok

Thanks to you for this awesome module! 🙏🏻


Add support for openshift-sar

The OpenShift OAuth Proxy support is added as part of #100 and comes with the default auth strategy (any existing user is allowed to login). An improvement is to add support for openshift-sar, so that more complex auth strategies are possible:
https://github.com/openshift/oauth-proxy#limiting-access-to-users

Done via #508


World map configuration typos

The spellbook options have "Destionation" instead of "destination".
Also, I'd capitalise the spellbook type, at least the Arceeus one, but that's just personal preference.

Haha good ole copy paste


Fix tutorial

Hi Jason,
Thanks for your advice. I make a new branch and separate the changes into several commits. The following are details about the changes:

Update getMatserPort() and getSlavePort() to getPort() in simple_cache and simple_memobj because they are no longer used.
Modify simple_cache.cc,  hello_object.cc and hello_object.hh which would cause compile errors with the original code.
Use Python3 print style
Update description files because of the above changes.

It would have been better to keep the old PR and not open a new one. That way, we could track the history. You could have simply force pushed to the same remote branch. https://git-scm.com/docs/git-push#Documentation/git-push.txt---force
This is easier because I can't tell if you made the changes that I asked for in the other PR.


Add parameter passing to the CBC interface

Previously, CBCInterface does not read from solver-specific
parameters because there is no ReadParameterFile implemented.
This patch implements a ReadParameterFile that takes these
parameters, saves them in the CBCInterface instance, and passes
them to callCbc during Solve as additional arguments.
Tested to work with e.g. the "-threads" argument.
Addresses issue #57.

This failed in some Java test in GLPK_MIXED_INTEGER_PROGRAMMING. Likely not be related to this change. What's the process for continuing?

Fixed the problem. It wasn't the extra space(s), but (I believe) the move-construction performed by std::operator+(string) when there is a constant involved (see http://www.cplusplus.com/reference/string/string/operator+/). The moved string -solve was probably getting freed in multiple threads.

@yingzong I'll revert this commit see #672 for details


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   98.03%   98.03%
=======================================
  Files           1        1
  Lines         102      102
=======================================
  Hits          100      100
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c908e14...e37c6b4. Read the comment docs.


Yuzu crashing on loading .nro file SIGSEV

when running produced .nro files in yuzu 1603 (2023-10-28)
ig get this SIGSEV
Unhandled SIGSEGV at rip 0x0000000000789fa6
this happens with gpu-simple and libapplet (i didnt test others)

I barely use yuzu in general, does usual homebrew work at all?


When i use Del(keys...) to delete multiple keys, none of the keys are deleted

I want to delete multiple keys by using Del(keys...), because i don't want to delete all these keys one by one, i think this way will reduce program efficiency.
And the finally result is none of the keys are deleted. Is there a problem with my usage?
This is my function to delete keys:
func (db *DbClient) Del(key ...string) error {
	var result *redis.IntCmd
	result = db.rdb.Del(db.ctx, key...)
	_, err := result.Result()
	return err
}

Thank you!!

The code you provided looks fine. Most like the problem is somewhere else.


Feature/binance v2

Description
Migrated the "python-binance" library to built-in code. The api.py for Coinbase Pro and Binance now looks the same. It is a lot easier to manage now and much faster and reliable.
Fixes # (issue)
Type of change
Please make your selection.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[X ] This change requires a new dependency  ---  you can remove "binance" and "python-binance" libraries after this
[X] Code Maintainability / comments
[X] Code Refactoring / future-proofing

How Has This Been Tested?
Manual and unit testing
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added pytest unit tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings

Looks like the unit tests are broken. I will need to update those.

I have found an error in AppState.py line 75
info = self.api.client.get_symbol_info(symbol=self.app.getMarket())
I replaced locally with:
info = self.api.getMarketInfoFilters(market=self.app.getMarket())
and it appears to be working now

I fix this one already. Can you pull down the latest code and try again please?


Arrow key navigation in expanded image view on dashboard

In the GUI, allow users to move from one sample to the next using arrow keys.

Resolved by #254 and #412


Replace contentlayer with mdx across docs and configs

Description
Replace contentlayer with mdx across docs and configs.
Is this a breaking change (Yes/No):
No

Issue above may be related to the error below.
Warning: Found 327 problems in 935 documents.

 └── 327 documents contain field data which didn't match the structure defined in the document type definition. (Skipping documents)

     • "community/contributing.ja.mdx" of type "Community" has the following incompatible fields:
       • order: "2\r"
     • "community/contributing.mdx" of type "Community" has the following incompatible fields:
       • order: "2\r"
     • "changelog/v0.1.1.mdx" of type "Changelog" has the following incompatible fields:
       • order: "165\r"
     • "changelog/v0.1.2.mdx" of type "Changelog" has the following incompatible fields:
       • order: "164\r"
     • "changelog/v0.2.0.mdx" of type "Changelog" has the following incompatible fields:


Python2 error:

Cannot run with python2 after 14.0, logs:
Traceback (most recent call last):
  File "/mnt/mesos/sandbox/resources/0000002283417/resource.refreshman2.py", line 5, in <module>
    import tableauserverclient as TSC
  File "/usr/lib/python2.7/site-packages/tableauserverclient/__init__.py", line 8, in <module>
    from .server import RequestOptions, CSVRequestOptions, ImageRequestOptions, PDFRequestOptions, Filter, Sort, \
  File "/usr/lib/python2.7/site-packages/tableauserverclient/server/__init__.py", line 9, in <module>
    from .endpoint import Auth, DataAlerts, Datasources, Endpoint, Groups, Projects, Schedules, \
  File "/usr/lib/python2.7/site-packages/tableauserverclient/server/endpoint/__init__.py", line 4, in <module>
    from .datasources_endpoint import Datasources
  File "/usr/lib/python2.7/site-packages/tableauserverclient/server/endpoint/datasources_endpoint.py", line 5, in <module>
    from .resource_tagger import _ResourceTagger
  File "/usr/lib/python2.7/site-packages/tableauserverclient/server/endpoint/resource_tagger.py", line 7, in <module>
    import urllib.parse
ImportError: No module named parse

@chy9002 that's correct - the library only supports running under Python version 3.5 or newer. You may be able to use an older version of the TSC library, but the recommended solution would be to move to Python 3.x.

@chy9002 that's correct - the library only supports running under Python version 3.5 or newer. You may be able to use an older version of the TSC library, but the recommended solution would be to move to Python 3.x.

Thanks for your reply.

@chy9002 that's correct - the library only supports running under Python version 3.5 or newer. You may be able to use an older version of the TSC library, but the recommended solution would be to move to Python 3.x.

Thanks for your reply.


Test to verify lpar frequency with different powersave modes - v3

This test covers below scenarios:
Set Powersave mode to different available modes and check whether the mode is changed accordingly in OS. Set Powersave mode to different available modes and check whether the frequency chages accordingly. Check frequency is lowest in "powersave" mode and maximum in "Maximum Performance Mode" Set Powersave mode to "Staic Power Saver" mode when lpar is deactivated and check if the mode is set properly when the lpar boots up. Sets Powersave mode to different powersave modes and checks frequency with and without workload. Sets Powersave mode to different powersave modes and verifies frequency with different smt modes.
Signed-off-by: Pavithra<EMAIL_ADDRESS>

logs.txt

Raised https://github.com/open-power/op-test/pull/721


How to render HTML pages as an HTTP server response Using Node.js

Article checklist
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
Preliminary Checks - Formatting and Structure

[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Have you placed your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

@mosesreigns We will need a headshot pic and a short bio for the author's page. Refer to the contributing guidelines for more information. You may also refer to the authors folder in the main repository for more information.

@mosesreigns Add a hero image from Unsplash.com. Let me know if you have any doubts. Before modifying the files, make sure to pull the changes made to avoid merge conflicts.

I have updated the article @lalith1403

What about author pic and bio?

Adde that too @lalith1403

Welcome to the program. This is a great article on rendering HTML pages using Node.js. I would like to point out a couple of points.

While writing technical articles, we tend to stick to deliver the message from a third person's point of view. Usage of I, you, etc. should be avoided.
Maintain consistency in the usage of technical terms. GET, POST, Node.js, Express.js. Avoid mixing it up with get, Get, etc.

The outputs are great! The code works as mentioned. Make these changes and we can move on to the final round fo review.

I still see a lot of you mentioned in the article. A third-person narrative suits technical writing better.

I still see a lot of you mentioned in the article. A third-person narrative suits technical writing better.

Worked on most of the "you", Check the update @lalith1403

plagiairsm check done

@mosesreigns  👋  Welcome and great job submitting you 1st article to the EngEd program.
We're happy to have you join the community - please take keen notes on any changes made by your peer reviewer or myself to apply those to future articles. 🚀
Be sure to go over our resources page if you haven't already for more information and helpful links.
cc @lalith1403

@lalith1403  Please see the changes I made to the front matter 👍
main thing is the list - the front matter does not need to be in list form.


Ladder bug

If we edit out items.otb with this (10.76) we cannot use the cormaya ladder (In ORTS Datapack) and if there is an item on the bottom of the ladder we cannot use the ladder.

Bump? Got the same here

Actual OtItemEditor is not reading forceUse Flag. There is a need of a update in OtItemEditor.

can you check if it was fixed?
https://github.com/ottools/ItemEditor/releases/tag/v0.3.6

Fixed for me! Thanks

Fixed this in 9438fad


Add Gradle download info to project Pages

this info is present on repo README, but not on Pages.

The website is hosted on master in the website/ folder. Please make the change there.

OK, submitted change on master in website/ instead.  Just curious - why is the website hosted there, and not from the gh-pages branch?

So it can be versioned with the code and is available in the zip download.
On Feb 11, 2015 3:54 PM, "Mike Voytovich"<EMAIL_ADDRESS>wrote:

OK, submitted change on master in website/ instead. Just curious - why is
the website hosted there, and not from the gh-pages branch?
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/pull/1390#issuecomment-73962704.


[BUG] Some buttons, strings might overlay text, if they too long.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
So, I tested, how it would look like, if translations already got added, and some of them got overlapped by buttons & strings
Might explained bad, just look at pics & video under..
https://github.com/pizzaboxer/bloxstrap/assets/78297186/8a7111b9-3640-4466-bfbf-545420761b28

@pizzaboxer

I closed it because you opened an issue for a version that hasn't been released yet, and that I am already well aware of.

Oh, alright


Add autcompletion to huggingface-cli (fix #1197)

$ huggingface-cli repo create -<TAB>
Name for your repo. Will be namespaced under your username to build the repo id.
option
--help           show this help message and exit
-h               show this help message and exit
--organization   Optional: organization namespace.
--space_sdk      Optional: Hugging Face Spaces SDK type. Required when --type is set to "space".
--type           Optional: repo_type: set to "dataset" or "space" if creating a dataset or space, default is model.
--yes            Optional: answer Yes to the prompt
-y               Optional: answer Yes to the prompt

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @Freed-Wu , thanks for your PR. The example snippet in the description is very promising !
However, I have not yet been able to reproduce it. Did you do some steps from https://docs.iterative.ai/shtab/use/#cli-usage ?
What I tried is pip install ".[completion]". Should I then run something similar to
shtab --shell=zsh huggingface_hub.commands.huggingface_cli --error-unimportable \
  | sudo tee /usr/local/share/zsh/site-functions/_shtab

to make it work ? Or should I copy-paste the output of huggingface-cli --print-completion zsh somewhere ?
I am running Ubuntu 22.04 using zsh. Thanks in advance for your help :pray:

About the code review itself, seems good to me. I have a few comments but it can wait. Installation will have to be documented somewhere :)

Sorry for late.
huggingface-cli --print-completion bash | sudo tee /usr/share/bash-completion/completions/huggingface-cli
huggingface-cli --print-completion zsh | sudo tee /usr/share/zsh/site-functions/_huggingface-cli
huggingface-cli --print-completion tcsh | sudo tee /etc/profile.d/huggingface-cli.csh

You can refer other projects using shtab https://github.com/andreafrancia/trash-cli#install-shell-completions

Ok nice thanks for the answer. In the end, I made it work by running
# Not under `/usr/share/zsh` but under ` /usr/local/share/zsh`
huggingface-cli --print-completion zsh | sudo tee /usr/local/share/zsh/site-functions/_huggingface-cli

Good. Now can you merge this branch? And how about https://github.com/huggingface/datasets/issues/5269?

OK, fixed.

Hi @Freed-Wu , thanks for making the changes ! What about the concerns about user experience (https://github.com/huggingface/huggingface_hub/pull/1207#pullrequestreview-1188249010) ? Do you have an opinion about it ?

detect from Python code if the autocompletion is set on the machine/in the shell

I don't know and I think it shouldn't be done by python, For example, bash user
should install bash-completion and
zsh user must autoload -Uz compinit && compinit in their zshrc, it is hard to detect if user done this work by python.

Do you know if there is a way to programmatically setup the shell from Python code

As I know, it is usually done by package manager, such as

https://github.com/archlinux/svntogit-community/blob/packages/trash-cli/trunk/PKGBUILD#L31-L34
https://github.com/archlinux/svntogit-community/blob/packages/onefetch/trunk/PKGBUILD#L29-L32
https://github.com/archlinux/svntogit-community/blob/packages/github-cli/trunk/PKGBUILD#L37-L39

Other software distribution, such as
msys2,
termux,
nixpkgs,
homebrew
are same.

About datasets, I'll let @lhoestq answer.

I see. It depends on you.

@Freed-Wu So basically for now your suggestion would be to ship this PR "as it is" (I made some cosmetic changes for code quality) and leave the installation to users themselves ?
Most if not all of our users are installing huggingface_hub via a pip. Not sure that we want to become a CLI-first library as this would require more maintenance cost on our side. Typically, I don't want to start maintaining distributions of huggingface_hub through nix, brew,...
What I wonder is how to notify users that a autocomplete feature is available if they install it properly. I think we should at least explain "somewhere" how to use the output of huggingface-cli --print-completion as I don't expect users to know about it. Any ideas or reference to another library doing this ?

Also, would it be possible to have write-access to Freed-Wu:shtab branch ? I'd like to push a commit to fix a few code quality things.

@Freed-Wu, yep indeed for the permissions on your branch. It was a config mistake on my side. It is now pushed.
About merging the PR, I'm still not a fan of the current state. For now we have:

a new --print-completion option

if shtab is not installed, it suggests to do pip install huggingface_hub[completion]
if shtab is installed, it prints a long list of commands, without explaining what to do with it

When doing huggingface-cli --print-completion:

Either the user knows what to do about it

user still has to find where to put the config (for example: "Is it /usr/share/zsh/site-functions/_huggingface-cli or /usr/local/share/zsh/site-functions/_huggingface-cli ?")
user has to update the completion script each time the huggingface_hub library is updated

Either the user doesn't know what to do about it:

user will most probably expect completion to work just after shtab is installed
we could have a --print-completion-help command to explain a bit the procedure. Still not easy to know where to redirect the user. I have read the official documentation but the shtab --shell=zsh shtab.main.get_main_parser --error-unimportable is not directly applicable in our case (even a shtab --shell=zsh -u huggingface_hub.commands.huggingface_cli.get_main_parser wouldn't feel right if we had it).

All of this feels a bit clunky to me. I'm not sure we want to push a feature that will only be easily usable by a few users knowing about it. Do you see my point ? :confused:

I know your concern. To the best of my knowledge, a solution is perhaps write a Makefile, or a shell script and write some code in setup.py to let pip install XXX[completion] to do this work. (about /usr/share/zsh or /usr/local/share/zsh, it is easy to detect which situation is right.) However, I think it is too complex. As I know, write a makefile for a python project is only used for those project containing C/C++ code, such as <github.com/pytorch/pytorch>, becuase they need compile these C code. For this project, I haven't seen any similar project to do this work. If you want to, you can write many code in setup.py like
if os.path.exists('/usr/share/zsh'):
    subprocess.call(['XXX', '--print-completion'])
    ...
  with open('/usr/share/zsh/site-functions/_huggingface-cli') as f:
      f.write(context)

Like the above.
I think it is complex. However, it depends on you eventually.

Hi @Freed-Wu , thank you for your feedback and for all the time you invested in helping us on this PR.
However we decided internally that we will put this PR on hold for now. The proposed solution is great but comes with its drawbacks. As we are not yet sure which direction we want to give to huggingface-cli (see discussion here), we prefer not to chose a tool that we might end up not using. For example we might want in the future to list repos or files from the Hub directly from the autocomplete, which is not yet possible with shtab.
Thanks again for your help and I'll keep you posted when we move forward for the CLI :slightly_smiling_face:

list repos or files from the Hub directly from the autocomplete

It can refer https://github.com/andreafrancia/trash-cli/blob/master/trashcli/shell_completion.py#L43.
trash-put filename will put filename to trash bin. --trash-dir can allow
user to select trash bin, such as ~/.local/share/Trash (by default) or other
/root_of_disk/.Trash-userid.
trash-put --trash-dir <TAB> can complete trash bin paths.
Its solution is to provide trash-list --trash-dirs to provide trash bin paths.

we will put this PR on hold for now.

I have said that it depends on you :smile: About your concern (install shell completion by pip automatically not by user manually, I'll report to shtab) And I advise fixing #1206, because it is not related to your concern.

I'll keep you posted

OK. Remember post me in the future :+1:

And I advise fixing https://github.com/huggingface/huggingface_hub/issues/1206, because it is not related to your concern.

Done in https://github.com/huggingface/huggingface_hub/pull/1223, thanks :)

Done in #1223,

Good.

I'll report to shtab

See https://github.com/iterative/shtab/issues/122

Hey, thanks for the feedback! A few points:

I would never put shtab into options.extras_require. It's a tiny & pure Python package (no C-extensions/platform-dependencies), so should be in install_requires (so pip install thing is enough; no need to do pip install thing[completion] & no need of this awkward code)
I agree you need to maintain your own docs (see e.g. https://dvc.org/doc/install/completion#what-shell-do-you-have) since you can't expect end-users to know what to do with thing --print-completion=bash

however I'm open to docs improvement suggestions if you still think it's better to maintain user-facing docs upstream under https://docs.iterative.ai/shtab somewhere (source)

dynamic completions: possible via defining custom shell functions (e.g. *.txt example or even more advanced things)
shtab#122 aka pip install thing auto-detecting the shell(s) on the local machine and running the completion post-install setup: this is exceedingly complex, and setup varies a lot depending on platform and the user choices. For example, what happens if someone pip installs into a throwaway conda environment on a machine that has both zsh and bash? Some trickery with environment files? There's just too many edge cases.

Usually, packaging systems implement post-install completion setup, e.g. snapcraft tab-completion and dh_bash-completion. AFAIK no pure Python packaging system implements this.
For now, IMO better to just document and let user decide as per (2) above
We could try to (slowly) implement it in https://github.com/iterative/shtab/issues/122

Thanks @casperdcl for your input !

https://github.com/iterative/shtab/issues/122 aka pip install thing auto-detecting the shell(s) on the local machine and running the completion post-install setup: this is exceedingly complex, and setup varies a lot depending on platform and the user choices. For example, what happens if someone pip installs into a throwaway conda environment on a machine that has both zsh and bash? Some trickery with environment files? There's just too many edge cases.

Yes that's actually what I'm the most afraid of as we don't want to implement/support/debug this type of edge cases.
For now I'll keep this as it is (e.g. no completion in huggingface_hub). We will come back to your inputs when we decide to move forward on the CLI tools more seriously.

so pip install thing is enough; no need to do pip install thing[completion] & no need of this awkward code

Not defense -- I have a little concern about it.  I believe you, but not every one is same as me. For them, reducing the unnecessary dependencies is a good solution to avoid anything like faker.js happens again. The libraries which can let all one believe are only built-in libraries.

dynamic completions: possible via defining custom shell functions

Agree :+1:

I agree you need to maintain your own docs (see e.g. https://dvc.org/doc/install/completion#what-shell-do-you-have) since you can't expect end-users to know what to do

I support writing docs. In any situation, a rich documentation is not a bad thing, absolutely. Although end-user may not read them. (Packagers who package software to apt, pacman, nix, homebrew must read docs).

auto-detecting the shell(s) on the local machine and running the completion post-install setup: this is exceedingly complex

I agree it is complex, however I don't think it is impossible. It is just very trivial to take many different edge situations into consideration.

For now I'll keep this as it is

Support keep current situation. A final solution is better than a current solution, which other current solutions are worse than. Certainly, if any better solution occur, I also support.
Another solution is just to publish the shell completions with package, man page and other things in GitHub release, then let packager or end-user download them directly, not generate by themselves. This is an example. The package script just downloads these files and install them to the correct path. Now python -m build cannot generate these shell completions, which is trouble.
No defense again :smile:

At the risk of starting a tangential discussion:

reducing the unnecessary dependencies is a good solution to avoid anything like [left-pad/colors/faker]

Completely disagree, sorry. Minimising attack surface is done by pinning dependencies, not marking them as optional.

done by pinning dependencies

PYPI seems not to allow user uploading package with same version to override the old package (Perhaps user can delete the old project then create a new project with same name to escape the limitation) so pin version can reduce the risk. (If not, pin the sha256 of the package). git tag is fragile by git tag 1.0.0 -f. Perhaps many projects try to reduce the dependencies due to other reasons, not only reducing risk.

the risk of starting a tangential discussion

I am sorry that I open a tangential discussion. Now I stopped.

@Wauplin Sorry to disturb you, however, I found a solution to solve your following problem:

When doing huggingface-cli --print-completion:
Either the user knows what to do about it
    user still has to find where to put the config (for example: "Is it /usr/share/zsh/site-functions/_huggingface-cli or /usr/local/share/zsh/site-functions/_huggingface-cli ?")
    user has to update the completion script each time the huggingface_hub library is updated
Either the user doesn't know what to do about it:
    user will most probably expect completion to work just after shtab is installed
    we could have a --print-completion-help command to explain a bit the procedure. Still not easy to know where to redirect the user. I have read the official documentation but the shtab --shell=zsh shtab.main.get_main_parser --error-unimportable is not directly applicable in our case (even a shtab --shell=zsh -u huggingface_hub.commands.huggingface_cli.get_main_parser wouldn't feel right if we had it).

The ideal solution is: When user pip install XXX, they will get the shell completions out of box, not need to generate them by --print-completion. In fact, python support packaging some data files to wheel format. For example, If you use setuptools:
# pyproject.toml
[tool.setuptools.data-files]
"share/applications" = ["/the/path/of/XXX.desktop"]
"share/icons/hicolor/36x36/apps" = ["the/path/of/icon.png"]
"share/man/man1" = ["/the/path/of/foo.1"]
"share/bash-completion/completions" = ["/the/path/of/bash_completion.sh"]
"share/zsh/site-functions" = ["/the/path/of/_zsh_completion"]

Then user pip install --user foo will get:

~/.local/lib/python3.10/site-packages/foo
~/.local/share/applications/XXX.desktop
~/.local/share/icons/hicolor/36x36/apps/icon.png
~/.local/share/man/man1/foo.1
~/.local/share/bash-completion/completions/bash_completion.sh
~/.local/share/zsh/site-functions/_zsh_completion

Or user sudo pip install foo will get:

/usr/lib/python3.10/site-packages/foo
/usr/share/applications/XXX.desktop
/usr/share/icons/hicolor/36x36/apps/icon.png
/usr/share/man/man1/foo.1
/usr/share/bash-completion/completions/bash_completion.sh
/usr/share/zsh/site-functions/_zsh_completion

It will be out of box. User doesn't need to generate shell completion scripts by themselves and search which path is correct path to put the generated shell scripts. When they install foo, the shell completion scripts will be installed together.
So we can write a setup.py to when we build the packages, generate these shell completion scripts to a path, then tell tool.setuptools.data-files these paths.
This is some examples:

py-doq
translate-shell

Other tools I am familiar like scikit-build-core, python-meson also support this feature but use different methods. So I think your problem have been solved by these tools.

@Wauplin Sorry to disturb you, however, I found a solution to solve your following problem:

Thanks for coming back to this issue with so all those resources @Freed-Wu! I did not get the time to dig into it yet but I'll definitely have a look at it next week.


Need Create Event feature with Drag and Drop functionality

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
There is functionality to edit the events with drag and drop events , We need create event functionality with similar UI interaction like drag and drop to select area on calendar.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

As mentioned above, it's useful to be able to move items around the calendar like Outlook. What is missing is the ability to create an event on the calendar by selecting the time slots, which then opens a dialoge to enter the details for the event. This is a core function of most calendars like Outlook and Google.


[FEATURE] add remote loader for runtime plugins

Description
This PR uses the remote plugin loader to load all types of plugins at runtime, based on the installed plugins fetched from api/v1/plugins
This will work in conjunction with https://github.com/perses/plugins/pull/16

I adjusted the plugin module structure to match better our types conventions as discussed. I added the changes from the plugins side here: https://github.com/perses/plugins/pull/18

yes exactly. I'll merge it then. Thnx for checking.


Log burst metric headers

Type of PR

[ ] Documentation changes
[ ] Code changes
[x] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

PR Checklist

[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] My code follows the code style of this project.
[ ] I ran lint checks locally prior to submission.
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Purpose of PR
Add X-Load-Feedback header to logged information.
Does this introduce a breaking change

[ ] YES
[x] NO

Validation

[x] Unit tests updated and ran successfully
[ ] Update documentation or issue referenced above

Issues Closed or Referenced

Closes https://github.com/retaildevcrews/wcnp/issues/743

@rcaseymsft I think we should have a design review for this PR. I am not entirely sure if we need to have burst metrics yaml inside the loderunner repo (I am thinking in terms of maintainability and reuse). It might be the case that creating a burst metrics helm chart that we can reference be appropriate for this scenario. But I think it's best to have that discussion with the overall team. @jofultz thoughts?

the

I was sort of hung on that as well. Since burst metrics needs to be deployed for Loderunner to pick up the header, we wanted to keep everything contained here in this repo, which would be consistent with a local cluster.
My concern is the wasm binary we are using. The binary is not committed in this repo, rather we're downloading it from ngsa-asb repo.
We have couple of options we can use to acquire the binary.
We can discuss that in a design review session

@jofultz We had a small discussion yesterday. And according to the discussion we added descriptions and instructions on how to use Burst Metrics header in this environment.
Also, we've changed the wasm binary URL from main branch to a specific commit so that, updating the burst wasm binary doesn't break the dev environment.


Dragonberry

FYI, #8 is a state breaking change, maybe.  It might be able to be applied smoothly without state breaks.
1/3rd of vp should apply ASAP, which will cause the chain to halt in the event that it is attacked.
Once 2/3rd of VP has it, then the chain wouldn't halt in that case
Release notes for v0.46.6 are here:
https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.6

I have another tokenfactory state breaking patch that I need to push out so I'll push it through at the same time thx
Have to figure out how to software upgrade proposal & work with vals to vote in a 6 hour window :D


Make the face tracking and eye tracking  of alvr a single data type again

Like now it used to be in the old version as osc or as the new data type the face tracking is using  it seems to be currently half osc and half custom data type

The reason we don't use OSC is because I haven't managed to find a way of making any OSC library work with VRCFT. Third party dlls can't seem to be picked up by VRCFT and the built-in OSC library in VRCFT is lacks support for arrays of length > 6


Fix WalletConnect app icon and name

This closes #56 showing Gnosis Safe logo and app name when connecting a dapp using WalletConnect
Cleanup in first commit of tx-builder public folder that had errors caused by apps separation

Link for testing
https://ipfs.io/ipfs/QmfZUg9egmkFfNiGMLMcZPE7Ft7CBfsZ98Poq4qUj6qgJH/

So I tried in https://mesa.eth.link/ and it worked fine with the new icon and name. It looks good to me

Something to notice: I tried as well in our safe app and Uniswap and the icon is still the WC, so it seems that every sites handles the WC as they see fit (regarding name and icon).


Add configuration options to enable OIDC middleware

Adding configuration support to enable oidc middleware.
Configuration supports config file variables and environment variables.

@mantas-sidlauskas  lint checks is failing


how to forwarding other rpc interfaces.

In fact, the main requirement is how to set the return information.
Because the original interface already provides information about rpc, it would be embarrassing to repeat this type of information if you forward it again.
like this.
Original return
{
    "error":
        {
            "code":-40003,
            "data":null,
            "message":"xxx does not exist"
        },
    "id":1,
    "jsonrpc":"2.0"
}

Forwarded return
{
    "id":"1",
    "jsonrpc":"2.0",
    "result":{
        "error":
            {
                "code":-40003,
                "data":null,
                "message":"xxx does not exist"
            },
        "id":1,
        "jsonrpc":"2.0"
    }
}

I hope to get back
{
    "error":
        {
            "code":-40003,
            "data":null,
            "message":"xxx does not exist"
        },
    "id":1,
    "jsonrpc":"2.0"
}

It seems that forwarding is not currently supported.

Hi,
Maybe catch this exception on view and return as you desire:
from typing import Any, Dict

from flask import Flask

from flask_jsonrpc import JSONRPC
from flask_jsonrpc.exceptions import InvalidParamsError

app = Flask('minimal')
jsonrpc = JSONRPC(app, '/api', enable_web_browsable_api=True)

@jsonrpc.method('App.greeting')
def greeting(name: str = '') -> Dict[str, Any]:
    try:
        if not name:
            raise ValueError('Name is required')
    except ValueError as e:
        return {'error': InvalidParamsError(data={'message': str(e)}).jsonrpc_format}
    return {'message': f'Hello {name}'}

if __name__ == '__main__':
    app.run(host='<IP_ADDRESS>', debug=True)

Testing:
$ curl -i -X POST \
>        -H "Content-Type: application/json; indent=4" \
>        -d '{
>         "jsonrpc": "2.0",
>         "method": "App.greeting",
>         "params": {"name": ""},
>         "id": "1"
>     }' http://localhost:5000/api
HTTP/1.0 200 OK
Content-Type: application/json
Content-Length: 516
Server: Werkzeug/2.0.1 Python/3.9.6
Date: Mon, 04 Oct 2021 16:07:20 GMT

{
  "id": "1",
  "jsonrpc": "2.0",
  "result": {
    "error": {
      "code": -32602,
      "data": {
        "message": "Name is required"
      },
      "executable": "/Users/nycholas/Temporary/.p/flask-jsonrpc/.venv/bin/python",
      "message": "Invalid params",
      "name": "InvalidParamsError",
      "stack": "Traceback (most recent call last):\n  File \"/Users/nycholas/Temporary/.p/flask-jsonrpc/examples/minimal/minimal.py\", line 55, in greeting\n    raise ValueError('Name is required')\nValueError: Name is required\n"
    }
  }
}

$ curl -i -X POST        -H "Content-Type: application/json; indent=4"        -d '{
        "jsonrpc": "2.0",
        "method": "App.greeting",
        "params": {"name": "xxx"},
        "id": "1"
    }' http://localhost:5000/api
HTTP/1.0 200 OK
Content-Type: application/json
Content-Length: 84
Server: Werkzeug/2.0.1 Python/3.9.6
Date: Mon, 04 Oct 2021 16:09:10 GMT

{
  "id": "1",
  "jsonrpc": "2.0",
  "result": {
    "message": "Hello xxx"
  }
}

Use can put this try ... except on decorator too.
Let me know if this solves your issue (close this issue ;).
Thank you.

@nycholas My question is how to use flask-jsonRPC to forward interfaces of other existing RPCS.You seem to have misunderstood what I mean. The result I'm giving here is just a example.

Original return
{'id': 1, 'jsonrpc': '2.0', 'result': '0x0'}

Forwarded return
{
    "id":"1",
    "jsonrpc":"2.0",
    "result": {'id': 1, 'jsonrpc': '2.0', 'result': '0x0'}
}

I hope to get back
{'id': 1, 'jsonrpc': '2.0', 'result': '0x0'}

Hi,
I'm misunderstood what you would mean, sorry.
That feature isn't currently supported.
Thank you.

Hi,
I'm misunderstood what you would mean, sorry. That feature isn't currently supported.
Thank you.

I read the code of flask-jsonrpc and found that the content of the returned body is too coupled. The impact of this problem is that when I need to manually change the return value, it makes me at a loss. How can I modify the returned response gracefully?
If I can modify the response, then I can handle the problem of forwarding other rpc interfaces.

Hi,
The code was implemented following the specification from JSON-RPC 2.0[1] and Response Object you can find here[2], so the Response Object always will be the same, no matter what. I think you are using this library (flask-jsonrpc) to do something that doesn't follow the specification JSON-RPC 2.0 and you can't change that using this library.
The return of views, always will be wrapping by either result or error, depends on the case.
Thank you.
[1] - https://www.jsonrpc.org/specification
[2] - https://www.jsonrpc.org/specification#response_object


Implement fuzzing via cargo fuzz

Identify interesting interfaces to fuzz, from a security perspective, and implement fuzzing test cases for them. These should ideally include at least data coming from the hypervisor, guest kernel and VMPL0 userspace.

Thanks for proposing this, fuzzing would be great to have. In addition, stress-tests are also something worth looking into.


have autest make hardlink or symlinks before doing a copy

[ci approve autest]

[approve ci autest]

Cheery-picked to 7.1.0 as well.

On Jun 21, 2017, at 8:28 AM, dragon512<EMAIL_ADDRESS>wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/apache/trafficserver/pull/2176
Commit Summary
• have autest make hardlink symlinks before doing a copy

@dragon512 Why do we need a copy? You should be able to use the existing PROXY_CONFIG_PLUGIN_PLUGIN_DIR just by setting the configuration to point to it.
J

@jpeach So technically I would say that it could be done. I could do this with the bin as well. The reason to not do this was to make a reproducible sandbox for the test. This prevents the original directory being messed with for testing. It also allows one to package the directory easier, getting a full copy of the failed test to replay in a different location or system. The later case here given certain "abspath" issues with ATS would make this difficult.
I was thinking this would also make it easier to have a copy plugin API added so we can plugins, copy it to the default location and have it load with others messing with original locations, or verifying that "default" load logic works we expected. For me this is mostly about separating the OS system install from the testing. Hard links allow us to save space for binaries we are testing against, while allowing us the separation provided by have a different directory "containing" item for a given test run

@dragon512 I am having trouble running my tests after this change. Maybe I need to change how I test:

Build ats with make && sudo make install
Run autest.sh from the tests dir

The 204 plugin test fails now because it has no permission (running as me) to copy the plugin source file into the sandbox plugin directory, which is now a symlink to the plugins directory of the system installation (owned by root).
How did you run the tests with this change?


Building blocks for the file-parsing capability

Separate the parsing of a file (known to be in a good state) from reacting to user inputs on keyboard (so e.g. auto-complete causes no clash). The parseFile method could take in a streamReader (or equivalent) and pass it on to the next frame to read more, until exhausted.

In some instances, the parseFile and processKey methods could delegate to common functionality.

Could implement a re-usable FSM class (strictly speaking it is a 'Mealy machine') that is initialised with a state: string and  rules: ParseRule[]. It has a method, say, handleChar.  The rules take the form of four-tuples.

[currentState: string, input: string, newState: string, call: (streamReader) => void]
The input would be specified as regEx. This could specify a single character, or alternative characters, or a sequence of characters.  The FSM would 'peek' at the stream to see if there was a match, and if so would remove the character(s) constituting the match.
The call attribute would be a method defined on the frame that owns the FSM which would typically be a unique purpose method that e.g.

passed on the streamReader to an equivalent parseFile method on an owned field, child frame, or next peer frame
if appropriate created a new frame and passed on control to it

Absorbed into #40


Optionally show or hide Bing 'placeholder' tiles

Fixes https://github.com/openlayers/openlayers/issues/14541
Placeholder tiles are shown by default for different styles as described in the issue. The behavior is controlled by the presence of the n=z url param. This PR adds an optional parameter allowing users to decide whether to show these tiles or, alternatively, overzoom the best available resolution. If the parameter is not set, the default behavior for the style is used.
This is a fairly big improvement from the method of using maxzoom to hide placeholder tiles mentioned in the example because Bing's zoom level coverage differs across the globe, so while a maxzoom of x works to hide the tiles in the US, a different one is required in, eg, Spain.

Thanks for the thoughtful review @jahow! All makes sense.
I've made the suggested changes and added a few basic tests. I'm new to using karma, so any pointers on that front would be very welcome.


plotly

when I use plotly, it only plots a portion of the data I select.  example is this phylostratum.
also, words overlap.
also, the legend is not explained.

What data is missing?
I don't have a good system currently for displaying documentation. Most of the plots don't really need them, but this one definitely does. I could add a caption to each figure, it would take up some space, which is a bit limited. Perhaps I could have a caption that can be toggled on or off.
The values in the legend correspond to -log_2(observed_counts / expected_counts).

IN a given figure, it isnt clear what the legend is about.
-log_2(observed_counts / expected_counts).   which counts (if one is comparing two columns) ?

The observed counts for a given cell are the number of rows with the given pair of x- and y-axis categories. The expected counts are the total number of rows divided by the product of the number of x- and y-axis categories, that is, the number of counts that would be expected if counts were evenly distributed across the cells.


DebugHandler doesn't allow resume/continue execution after a failing step

Currently on error, execution is stoped and breakpoint on failing line but because failed step is rewinded on debugserver. So buttons "Continue" and "Step Over" don't work because failed step is executed again.
The only options to continue execution on the client are edit-save-reload or cancel execution altogether.
Edit-save-reload makes sense if error is in the script itself, but not when script is OK and error is the API or environment where continuing to next test will be preferred over cancelling all tests.
A more flexible behavior would be not resetting failing step on server.  This gives users two options:

resume execution, failing, provide error report and continue with next Scenario/Outline
or manually edit-save-reload & manually step-back

How to reproduce:
Execute/debug this, and will stop on line 5
Scenario:
* url 'https://jsonplaceholder.typicode.com/todos'
Given path '', 1
When method get
Then status 201

1.0 released


[SUGGESTION] - Move to Nukebuild

Use nukebuild to automate build process in a new way, avoid using specifics scripts per platforms with a minimal yaml; All CI/CD in C#. <3
https://nuke.build/
https://www.youtube.com/watch?v=E7CufNR84M4
Let me know your thoughts in this thread

The Github Action do NOT using the scripts in build folder. It's using the dotnet publish command directly to test each commit pushed into develop branch.
The scripts defined in build folder is used to generate the final packages. Before I upload these packages and draft a new release, I need to run each package to confirm there are no obvious BUGs.
And, in my opinion, a script that can be run locally is more helpful to the user than a minimal CI/CD yaml configuration.

Some advantage of using nukebuild:

be able to debug the entire build process using c# code  step by step
ability to run locally and remotely
have an agnostic pipeline that works everywhere
You can automate and extend build tasks without knowing a lot yaml or sh/cmd


Model having length field causes problems

When model has length field and we have single model returned from server like this:
{
  "tracks": {
    "title": "bla-bla",
    "length": 42,
  }
}

Note that tracks is not an array.
Problem caused by extractSingle() method which uses Ember.isArray() which assumes anything to be an array if it has length property =(
Not sure is it an Ember issue or not.

I am closing this issue due to lack of activity and the impending deprecation in favour of the official Ember Data adapter. If you think this is an issue that relates to Ember Data please report the issue there.


Dropdown menu doesn't work when set to a % value

Info
When you use a percentage for the width, the width of the dropdown is being based off of the window, instead of the parent container.
Acceptance Criteria

If you offer percentage of width it should be based off of the parent container

:tada: This issue has been resolved in version 1.17.0-alpha.7 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0-alpha.7 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.18.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.18.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Just adding a comment here for transparency. I spoke to Amar about this and when I went to show him the issue, I was unable to replicate the issue. So this might actually be fixed and was opened erroneously. Amar is going to investigate a little further, but I said if he can't replicate then move to Blocked and I will look at when I'm back in the office next week.

:tada: This issue has been resolved in version 2.6.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.17.0-alpha.13 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0-alpha.13 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.20.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.20.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve add_primary_key_definition_constraint docs

Feel free to make other improvements

Hi @jonashaag ! Anything left to do?

@kklein is the test failure related?

@jonashaag the issue in the BigQuery integration test is solved in main. You should be fine by merging this branch as is.


add unit test to dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default

What is the purpose of the change
add unit test to dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default
#1690
Brief changelog
dubbo-registry/dubbo-registry-default/src/test/java/org/apache/dubbo/registry/dubbo/DubboRegistryTest.java
Verifying this change
ut pass
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Please merge origin/master to make ci success

Codecov Report

Merging #3053 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3053      +/-   ##
============================================
+ Coverage     63.43%   63.46%   +0.03%
  Complexity       75       75
============================================
  Files           653      653
  Lines         28261    28261
  Branches       4820     4820
============================================
+ Hits          17926    17937      +11
+ Misses         8057     8053       -4
+ Partials       2278     2271       -7

Impacted Files
Coverage Δ
Complexity Δ

.../remoting/transport/netty4/NettyClientHandler.java
75% <0%> (-11.12%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-2.18%)
0% <0%> (ø)

...he/dubbo/registry/multicast/MulticastRegistry.java
63.79% <0%> (-1.73%)
0% <0%> (ø)

...dubbo/metadata/support/AbstractMetadataReport.java
69.35% <0%> (-1.62%)
0% <0%> (ø)

...dubbo/remoting/exchange/support/DefaultFuture.java
71.81% <0%> (-1.35%)
0% <0%> (ø)

...pache/dubbo/remoting/transport/AbstractServer.java
47.91% <0%> (-1.05%)
0% <0%> (ø)

.../java/org/apache/dubbo/config/ReferenceConfig.java
57.57% <0%> (-0.76%)
0% <0%> (ø)

...pache/dubbo/registry/support/AbstractRegistry.java
81.2% <0%> (-0.76%)
0% <0%> (ø)

...mon/src/main/java/org/apache/dubbo/common/URL.java
45.9% <0%> (+0.14%)
0% <0%> (ø)
:arrow_down:

...bo/remoting/transport/netty/NettyCodecAdapter.java
54.68% <0%> (+1.56%)
0% <0%> (ø)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea4fa5...a51fd02. Read the comment docs.

Please merge origin/master to make ci success

It has been processed.

LGTM


Release

Hi,
do you have any plan to make a new minor release soon? It would be preferable to have a referable release that includes the new ONT models.

Current master should have new ONT models?

Sorry for being a little bit unclear. The current master have them but I wanted simplify the version tracking as I am planning to update the bioconda recipe to a post 0.4.0 release. Meanwhile I will solve it by referring to a certain commit (i.e. current latest commit) in the conda recipe.

Are there no plans for a production release after 0.4.0?

I'm working on supporting R9 data (and other improvements). I'll make a new release after that work is complete.


Use Clang image to run Valgrind

Install Valgrind on the Clang Docker image to use the latest version.

coverage: 99.639%. remained the same
when pulling 869793eee79d3e6fe5f3e95487e05c0fb0c10011 on valgrind
into 69c8758d517231f62572796b17557bc6ea2a0274 on develop.


No such file or directory

~ > asdf current
flutter         2.5.1-stable    /home/user/.tool-versions

~ > flutter
/home/user/.asdf/installs/flutter/2.5.1-stable/bin/internal/shared.sh: line 229: /home/user/.asdf/installs/flutter/2.5.1-stable/bin/cache/dart-sdk/bin/dart: No such file or directory

~ > l /home/user/.asdf/installs/flutter/2.5.1-stable/bin/cache/dart-sdk/bin/dart
.rwxr-xr-x 38M user users 17 Sep 00:01 /home/user/.asdf/installs/flutter/2.5.1-stable/bin/cache/dart-sdk/bin/dart

~ > asdf info                                                                                ± master | 23 Sep (4) 23:52:14
OS:
Linux nixos 5.12.13-xanmod1-cacule #1-NixOS SMP Tue Jan 1 00:00:00 UTC 1980 x86_64 GNU/Linux

SHELL:
zsh 5.8 (x86_64-pc-linux-gnu)

ASDF VERSION:
v0.8.1-a1ef92a

ASDF ENVIRONMENT VARIABLES:
ASDF_DIR=/home/user/.asdf

ASDF INSTALLED PLUGINS:
flutter                      https://github.com/oae/asdf-flutter.git

seems like NixOS related issue https://discourse.nixos.org/t/no-such-file-of-directory-when-trying-to-execute-binary-file/6150


'1 file reformatted.` appended on run (Sublime)

Operating system: Mac High Sierra 10.13.4
Python version: 3.6
Black version:
pip3.6 show black
Name: black
Version: 18.6b0
Summary: The uncompromising code formatter.
Home-page: https://github.com/ambv/black
Author: Łukasz Langa
Author-email<EMAIL_ADDRESS>License: MIT
Location: /Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages
Requires: appdirs, attrs, click
Required-by:

      // ########################
      // Black specific options #
      // ########################

      // line length
      // uses black default, if not modified
      "black_line_length": 100,

      // If --fast given, skip temporary sanity checks.
      "black_fast": false,

      // prevent black from changing single quote to double quotes
      // default is false
      // add --black_skip_string_normalization
      "black_skip_string_normalization": false,

      // Don't normalize underscores in numeric literals.
      "black_skip_numeric_underscore_normalization": false,

      // force py36 syntax mode
      "black_py36": null,

      // ##########################
      // Sublack specific options #
      // ##########################

      // full path and command to run black
      "black_command": "black",

      // run black before saving document
      "black_on_save": false,

      // set debug mode. default is info.
      // choices : debug > info > error
      "black_log": "debug",

      // default encoding for never saved file, if not specified un  first 2 lines (pep 263):
      // default is "utf-8". Change this only if you want override default behaviour.
      "black_default_encoding": "utf-8",

      // use blackd server instead of black
      "black_use_blackd": false,

      // blackd server host
      "black_blackd_host": "localhost",

      // blackd server port, default is like black, should be string
      "black_blackd_port": "45484",

      // Start blackdserver on start. shuts down at sublimetext exit.
      "black_blackd_autostart": false,

      // Use pre-commit if possible
      "black_use_precommit": false,

      // Disable formatll command
      "black_confirm_formatall": false

}

When running black 1 file reformatted. is appended to the end of the file. I always forget that this happens and fail when I try to run the script. Is there a way to put it on quiet mode during redirect?

Is this maybe because you're running in debug mode? It sounds like a problem with your plugin. For what it's worth, I also use the sublack Sublime plugin and I don't see this line being added.

Thanks, I was running for a long time and had no issues. I started to experience a click object error so I rolled back and now I ma getting this. I am not sure how to check what 'mode' sublack is running.

I was referring to the debug mode mentioned in your config (pasted above).

ah, yes it was on 'info' by default and tried to change it to a lower level in hopes it would not give extra output. But is seems to happen on all selections of black_log

If this is still an issue, maybe it's better to report it here. cc @jgirardet


Add guidance on default port and IP configuration

@ashgreen please review

@ashgreen Can this be merged?


Remove scalar typehint from AmazonSES constructor

Closes #42

Seems OK. Going to approve this. Thanks @stevecoug for your time. Much appreciated.


Add missing comment after .h file #endif

What's in this pull request?
Add missing comment after .h file #endif

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

This is incorrect LLVM style.
The comment should use // not /*.
Please see:
http://llvm.org/docs/CodingStandards.html#comment-formatting
Can you change all of the recent patches you submitted to follow that format.


convert.php in ISO-8859-1, ok after switch to UTF-8

Thank you for this code.
After clone you project under GNU/Linux (Ubuntu Bionic 18.04), values with '°' character doesn't converted.
I run file -i * and find that convert.php (and README.md) are with iso-8859-1 instead of test.php is in uft-8. I switch convert.php to utf-8 and it is ok now.

solve in https://github.com/bcag2/PHPconvertDMSToDecimal/tree/dm2dd


Intersect Model

Currently we have a Union (OR) Model which merges multiple models together. Alternatively, it could be useful to have an Intersect (AND) Model which only contains documents that exists in all provided models.

Yes, I can see how such a model would be useful. However, I am not aware of any atlas that needs it.

I agree. Currently I can't think of any existing atlas which needs this feature, but I thought I should mention the enhancement idea in case it's needed in the future.
Originally I envisioned, both this and the Union model being useful in performing more elaborate document queries.


sempreung domain added.

@weesftw Please provide us with:

the school official website URL
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@weesftw Forneça-nos:

o URL do site oficial da escola
um URL de uma página no site oficial onde a escola oferece um curso relacionado a TI de longo prazo (> 1 ano)
uma prova, que mostra que a escola reconhece o domínio que você está enviando como um domínio de e-mail oficial para os alunos.

http://ung,br
https://vestibular.ung.br/PS_Univeritas/curso/15/3884/3/ciencia-da-computacao/Guarulhos-SP
In anex my profile in office 365 which management by my university (i don't know if that helpful).

@weesftw Please provide us with:

the school official website URL
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

http://ung,br
https://vestibular.ung.br/PS_Univeritas/curso/15/3884/3/ciencia-da-computacao/Guarulhos-SP
In anex my profile in office 365 which management by my university (i don't know if that helpful).

@weesftw Thank you for the clarification. Pull request merged.


Tests for verdeps/revise_deps.go

This is a work in progress.

Coverage increased (+5.1%) to 65.796% when pulling d17033a26f1a7a4ed2d928f886386955036b31a0 on feature/verdeps-tests into 2c6db1c05e63a996640a2dc224cfb9a2ad970738 on master.

Coverage increased (+6.4%) to 67.087% when pulling 17876a6fa6ff9b86b5e26417fb26d165d5566df6 on feature/verdeps-tests into 2c6db1c05e63a996640a2dc224cfb9a2ad970738 on master.


newest 1.17 version crashes on load

with only the latest winged, fabric api, and kotlin, it crashes on load. only using client side, fabric loader 0.11.3-1.17
log attached below
latest.log

Fixed on beta 2, thanks for reporting