Adds tests and ResponseHeader cleanup

Exposing some light on some of the tests that will be added.

@jkotalik,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@Tratcher @davidfowl Once this is in I'm going to polish up a PR for merging with dev.

Making PR with dev.


[Feature]: Add jest and write tests for scripts/extractSlideData.js

Right now, we don't have any tests in the repository. And we have the scripts/extractSlideData.js file which can have unit tests. The task is to write these unit tests.

I would like to work on this

Please assign the task to me.

Hey @anttijankeri , Sorry but I already started working on this part and created the test functions for extractTitle. Is it possible for you work on some other issue?

Hi @AhsanAyaz , Could you please review and let me know if any changes are required?

@Rachit1313 I've merged your PR but even though we use jest, the test command doesn't include jest. It still runs gulp test behind the scenes. But also has an issue with the tests in windows:

@anttijankeri  maybe you can have a look?

@Rachit1313 I've merged your PR but even though we use jest, the test command doesn't include jest. It still runs gulp test behind the scenes. But also has an issue with the tests in windows:

As I can confirm in the screenshot provided, The difference here is that the function returned the path with // i.e windows formatting for a path whereas I created the functions in a macOS.
This can be fixed by adding another statement of checking equal to mac version or windows output.
@anttijankeri hope this helps!
Let me know if you want me to make the changes.

@Rachit1313 I've merged your PR but even though we use jest, the test command doesn't include jest. It still runs gulp test behind the scenes. But also has an issue with the tests in windows:

For the gulp test.
That's because test script was already setup for gulp in the package.json. I wasn't sure if you wanted me to update it or not.
Let me know if you want me to change that.

Ive fixed the problems from earlier. The windows thing may or may not work, cant test it atm.


How to use HuggingFace Data?

Hi, @xujz18 @Xiao9905
Thanks for this nice contribution. I noticed that we can load ImageReward data with:
datasets.load_dataset("THUDM/ImageRewardDB", "8k")
However, the loaded data seem to not match with existing code, I have no idea how to move on with these code (I downloaded these HuggingFace data and save to disk, so I use load_from_disk to load them):
train_dataset = load_from_disk("data/RLHF/ImageRewardDB_8k/train")
valid_dataset = load_from_disk("data/RLHF/ImageRewardDB_8k/validation")
test_dataset  = load_from_disk("data/RLHF/ImageRewardDB_8k/test")

When I print train_dataset[0].keys(), it shows the same results in HuggingFace Dataset introduction:
dict_keys(['image', 'prompt_id', 'prompt', 'classification', 'image_amount_in_total', 'rank', 'overall_rating', 'image_text_alignment_rating', 'fidelity_rating'])

When I run python src/make_dataset.py, following the instruction in the README, this error happens:
making dataset:   0%|                                                         | 0/10000 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/tiger/code/ImageReward/train/src/make_dataset.py", line 12, in <module>
    train_dataset = rank_pair_dataset("train")
  File "/home/tiger/code/ImageReward/train/src/rank_pair_dataset.py", line 59, in __init__
    self.data = self.make_data()
  File "/home/tiger/code/ImageReward/train/src/rank_pair_dataset.py", line 80, in make_data
    for generations in item["generations"]:
KeyError: 'generations'

Unfortunately, it is not compatible with the existing datasets code:
https://github.com/THUDM/ImageReward/blob/1beb4e4de0932acbe7fc090c51208048b6269b58/train/src/rank_pair_dataset.py#L47
Does this mean we have to re-write the code if we want to use the downloaded dataset from HuggingFace?

Yes, the dataset has been collated to make it more readable and scalable, so the training code cannot be matched directly. We will subsequently update the training code to match the Huggingface dataset, which is available in single image, pair and group formats (e.g. 8k, 8k_pair, 8k_group), so you can choose the one that is most convenient for you.

Yes, in order to make the dataset more readable and scalable, we have tidied up the dataset so that it does not directly match the training code. We will subsequently update the training code to match the Huggingface dataset, which is organised into single images, pairs, and groups (e.g. 8k, 8k_pair, 8k_group), so you can choose the one that is most convenient for you.

@xujz18
Huge thanks for the quick reply. May I ask when it will be released? If it is convenient, can you give me some suggestions so that I can solve this problem more quickly?

We apologize that the update of the training code may be a week or two away as the friend who is responsible for putting this part of the training code together has been busy with some important matters of his own recently.
For suggestions to solve quickly: The data format corresponding to the code of make_dataset.py is the same as  https://github.com/THUDM/ImageReward/blob/main/data/test.json, you can use ImageRewardDB "8k_group" (you can refer to preview on HuggingFace to get a visual impression) and turn its format to "test.json".

Thanks a lot! I have one last question, how can I use ImageRewardDB "8k_group" as you mentioned just now? Can I load the 8k_group or 8k_pair subset directly with datasets.load_datasets?

load_dataset("THUDM/ImageRewardDB", "8k_group")

Yes. Like this: load_dataset("THUDM/ImageRewardDB", "8k_group")

Thanks a lot!

Yes. Like this: load_dataset("THUDM/ImageRewardDB", "8k_group")

Hi, @xujz18
I tried to download the 8k_group follow your instruction with following code:
from datasets import load_dataset

dataset = load_dataset("THUDM/ImageRewardDB", "8k_group", num_proc=8)
dataset.save_to_disk("data/ImageRewardDB_8k_group")

However, there are errors:
Found cached dataset image_reward_db (/Users/bytedance/.cache/huggingface/datasets/THUDM___image_reward_db/8k_group/1.0.0/33d18fdde6cd866eeeab2de1471592b802627df4ade050865b4e88c500ee63b7)
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 165.72it/s]
Traceback (most recent call last):
  File "/Users/bytedance/Code/download.py", line 4, in <module>
    dataset.save_to_disk("data/ImageRewardDB_8k_group")
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/dataset_dict.py", line 1225, in save_to_disk
    dataset.save_to_disk(
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/arrow_dataset.py", line 1421, in save_to_disk
    for job_id, done, content in Dataset._save_to_disk_single(**kwargs):
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/arrow_dataset.py", line 1458, in _save_to_disk_single
    writer.write_table(pa_table)
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/arrow_writer.py", line 570, in write_table
    pa_table = embed_table_storage(pa_table)
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 2290, in embed_table_storage
    arrays = [
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 2291, in <listcomp>
    embed_array_storage(table[name], feature) if require_storage_embed(feature) else table[name]
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 1837, in wrapper
    return pa.chunked_array([func(chunk, *args, **kwargs) for chunk in array.chunks])
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 1837, in <listcomp>
    return pa.chunked_array([func(chunk, *args, **kwargs) for chunk in array.chunks])
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 2190, in embed_array_storage
    casted_values = _e(array.values, feature.feature)
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 1839, in wrapper
    return func(array, *args, **kwargs)
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/table.py", line 2164, in embed_array_storage
    return feature.embed_storage(array)
  File "/Users/bytedance/Library/Python/3.9/lib/python/site-packages/datasets/features/image.py", line 263, in embed_storage
    storage = pa.StructArray.from_arrays([bytes_array, path_array], ["bytes", "path"], mask=bytes_array.is_null())
  File "pyarrow/array.pxi", line 2788, in pyarrow.lib.StructArray.from_arrays
  File "pyarrow/array.pxi", line 3243, in pyarrow.lib.c_mask_inverted_from_obj
TypeError: Mask must be a pyarrow.Array of type boolean

We apologize that the update of the training code may be a week or two away as the friend who is responsible for putting this part of the training code together has been busy with some important matters of his own recently. For suggestions to solve quickly: The data format corresponding to the code of make_dataset.py is the same as https://github.com/THUDM/ImageReward/blob/main/data/test.json, you can use ImageRewardDB "8k_group" (you can refer to preview on HuggingFace to get a visual impression) and turn its format to "test.json". Or, more directly, you can modify the code of rank_pair_dataset.py to correspond to HuggingFace ImageRewardDB.

anything news? The train code have finished?

We apologize that the update of the training code may be a week or two away as the friend who is responsible for putting this part of the training code together has been busy with some important matters of his own recently. For suggestions to solve quickly: The data format corresponding to the code of make_dataset.py is the same as https://github.com/THUDM/ImageReward/blob/main/data/test.json, you can use ImageRewardDB "8k_group" (you can refer to preview on HuggingFace to get a visual impression) and turn its format to "test.json". Or, more directly, you can modify the code of rank_pair_dataset.py to correspond to HuggingFace ImageRewardDB.

I try both two ways, but raise the same error.
cannot identify image file 'cache_dir_\\downloads\\extracted\\ba65aabab9974598536781d2df59b59457a2473f4a5341d7c0e8d0dc1988830f\\deb066d4-54aa-4562-8d30-2c67a6badb98.webp' cannot identify image file 'cache_dir_\\downloads\\extracted\\ba65aabab9974598536781d2df59b59457a2473f4a5341d7c0e8d0dc1988830f\\832ff14c-14cd-4d35-965d-bd2c1616d598.webp' cannot identify image file 'cache_dir_\\downloads\\extracted\\ba65aabab9974598536781d2df59b59457a2473f4a5341d7c0e8d0dc1988830f\\99dddbdd-a5d3-41af-98f7-a2f8927405fe.webp'
It seems that there are few invalid images in HF.

Yes. Like this: load_dataset("THUDM/ImageRewardDB", "8k_group")

If I run load_dataset("THUDM/ImageRewardDB", "8k_pair"). I will get a error.
Traceback (most recent call last):
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/builder.py", line 1637, in _prepare_split_single
    num_examples, num_bytes = writer.finalize()
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/arrow_writer.py", line 579, in finalize
    self.check_duplicate_keys()
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/arrow_writer.py", line 501, in check_duplicate_keys
    raise DuplicatedKeysError(key, duplicate_key_indices)
datasets.keyhash.DuplicatedKeysError: Found multiple examples generated with the same key
The examples at index 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17 have the key<PHONE_NUMBER>

Hi, @xujz18 @Xiao9905
Thanks for this nice contribution. I noticed that we can load ImageReward data with: datasets.load_dataset("THUDM/ImageRewardDB", "8k")
However, the loaded data seem to not match with existing code, I have no idea how to move on with these code (I downloaded these HuggingFace data and save to disk, so I use load_from_disk to load them):
train_dataset = load_from_disk("data/RLHF/ImageRewardDB_8k/train")
valid_dataset = load_from_disk("data/RLHF/ImageRewardDB_8k/validation")
test_dataset  = load_from_disk("data/RLHF/ImageRewardDB_8k/test")

When I print train_dataset[0].keys(), it shows the same results in HuggingFace Dataset introduction:
dict_keys(['image', 'prompt_id', 'prompt', 'classification', 'image_amount_in_total', 'rank', 'overall_rating', 'image_text_alignment_rating', 'fidelity_rating'])

When I run python src/make_dataset.py, following the instruction in the README, this error happens:
making dataset:   0%|                                                         | 0/10000 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/tiger/code/ImageReward/train/src/make_dataset.py", line 12, in <module>
    train_dataset = rank_pair_dataset("train")
  File "/home/tiger/code/ImageReward/train/src/rank_pair_dataset.py", line 59, in __init__
    self.data = self.make_data()
  File "/home/tiger/code/ImageReward/train/src/rank_pair_dataset.py", line 80, in make_data
    for generations in item["generations"]:
KeyError: 'generations'

Unfortunately, it is not compatible with the existing datasets code:
https://github.com/THUDM/ImageReward/blob/1beb4e4de0932acbe7fc090c51208048b6269b58/train/src/rank_pair_dataset.py#L47
Does this mean we have to re-write the code if we want to use the downloaded dataset from HuggingFace?

Hello, I am also working on reproducing the training results, but I found the 'train.json' file in huggingface seems cannot be directly used for make_dataset.py. Could you share the processed train.json file? many thanks!

Yes. Like this: load_dataset("THUDM/ImageRewardDB", "8k_group")

If I run . I will get a error.load_dataset("THUDM/ImageRewardDB", "8k_pair")
Traceback (most recent call last):
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/builder.py", line 1637, in _prepare_split_single
    num_examples, num_bytes = writer.finalize()
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/arrow_writer.py", line 579, in finalize
    self.check_duplicate_keys()
  File "/miniconda3/envs/torch1.13.0/lib/python3.8/site-packages/datasets/arrow_writer.py", line 501, in check_duplicate_keys
    raise DuplicatedKeysError(key, duplicate_key_indices)
datasets.keyhash.DuplicatedKeysError: Found multiple examples generated with the same key
The examples at index 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17 have the key<PHONE_NUMBER>

Have you solved it yet？


Adding FeatureSet and TestSet

Changes
fixes https://github.com/knative-sandbox/reconciler-test/issues/65

:gift: Adding FeatureSet, a wrapper around a set of features.
:gift: Adding TestSet, a test entry point to run a FeatureSet.

/kind enhancement
We need a way to vendor a group of features rather than individuals, the aim here is to provide a set of features that might be required for something like a conformance test, and it does not make much sense to vendor them individually as a burden to the downstream user of these.
Release Note
Adding feature.FeatureSet and Environment.TestSet.

/assign @dprotaso

Looks like a very nice way to group features!

You should probably review https://github.com/knative-sandbox/reconciler-test/pull/97 first as it has assumptions that are incompatible with this PR

/hold
hold since Dave had comments


Perform roll outs as intended in MCTS

In the current implementation nodes are created nodes all the way down which is memory intensive

The rollout for pure MCTS isn't right but the rollout with a neural network is working the way it was intended in the Alpha Zero paper.


Netatmo conditions max_temp and min_temp missing since 0.96 upgrade

Home Assistant release with the issue:

0.96.0
Last working Home Assistant release (if known):
0.95.x
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io running in a VirtualBox VM hosted on Windows 10
Component/platform:

https://www.home-assistant.io/components/netatmo/
Description of problem:
Since I had to remove my configured list of monitored conditions because of ADR0003 the conditions max_temp and min_temp are gone missing for each module.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# My sensor config for Netatmo Weatherstation:
- platform: netatmo

Traceback (if applicable):
Nothing special in logs

Additional information:

Thanks for reporting. The issue has been fix in the upstream module.

fixed in 0.96.4
thank you


⚠ Bofrost.de has degraded performance

In 423d89f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1144 ms

Resolved: Bofrost.de performance has improved in 1d04759.


feat: add endpoint for gke ingress health check

Description
Add new endpoint for GKE Ingress health check. GKE Ingress need single endpoint which return 200 OK.
https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#def_inf_hc
https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#direct_hc
Type of change
Please delete any options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Thanks for the pr.
I would suggest you just need to check localhost:3001 instead.
As your implementation isReady is always true once the server started, which is no much different.


Go 1.19

In #29 we talked about keeping Go version for Bazel and for CI synchronized, but the patch was somehow merged without a plan how to achieve that. Here we update Bazel and Gazelle so that we can build the project with new Go and finally update Go toolchain to 1.19.3 in both places.

Codecov Report
Base: 34.40% // Head: 34.40% // No change to project coverage :thumbsup:

Coverage data is based on head (758106f) compared to base (a45cc67).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   34.40%   34.40%
=======================================
  Files          41       41
  Lines        7967     7967
=======================================
  Hits         2741     2741
  Misses       5010     5010
  Partials      216      216

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


download stopped due to file identified as malware or spam

console show:
Failed to download file: googleapi: got HTTP response code 403 with body: {
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "cannotDownloadAbusiveFile",
    "message": "This file has been identified as malware or spam and cannot be downloaded."
   }
  ],
  "code": 403,
  "message": "This file has been identified as malware or spam and cannot be downloaded."
 }
}

anyway to bypass this file or force download file ?

you can download this file from browser?

@szunyi Yes, I can force the download after confirming the warning on the browser.
But here I can't.

Is there a solution for this? Because I have the same problem.

@Bomel no, I manually download file to my computer by web browser
then upload to headless machine by ssh

FYI: There's a parameter, acknowledgeAbuse=true, that can be passed to bypass this warning. The API docs ask that software explicitly get permission from the user before passing it, and passing it for a non-blocked file is an error.

User can be prompted to acknowledge abusive file to forcefully download

User can be prompted to acknowledge abusive file to forcefully download

How? in terminal?

How to fix it in code? can anyone tell me

@dkb007 I switch to Rclone for my purpose

User can be prompted to acknowledge abusive file to forcefully download

How? in terminal?

Did you find out?

Все решается просто.
В файле /gdrive/drive/download.go
находим:
res, err := self.service.Files.Get(f.Id).SupportsTeamDrives(true).Context(ctx).Download()
заменяем на:
res, err := self.service.Files.Get(f.Id).AcknowledgeAbuse(true).SupportsTeamDrives(true).Context(ctx).Download()
Как компилировать - смотрим тут - https://github.com/prasmussen/gdrive/issues/392#issuecomment-472186479


Run error

Hello,
I get this error trying to run main.py :
pygame 2.4.0 (SDL 2.26.4, Python 3.8.10)
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "main.py", line 57, in <module>
    doom = DoomEngine()
  File "main.py", line 20, in __init__
    self.on_init()
  File "main.py", line 23, in on_init
    self.wad_data = WADData(self, map_name='E1M1')
  File "C:\tmp\DOOM-Level-Viewer-main\wad_data.py", line 61, in __init__
    self.asset_data = AssetData(self)
  File "C:\tmp\DOOM-Level-Viewer-main\asset_data.py", line 141, in __init__
    self.textures |= self.get_flats()
TypeError: unsupported operand type(s) for |=: 'dict' and 'dict'

p.s.: this project is super cool! I saw the videos on YT

If you're still alive, it's because |= operand for dictionary was introduced in python 3.9, and you're in python 3.8.10.
https://docs.python.org/3.9/whatsnew/3.9.html#dictionary-merge-update-operators
Just update your python and it should be okay.


fix(imgreco-item): mkdir when dir is not exists

fixed #255 #245

closed #255 #245

closed #255 #245


Unable to Resolve Module with Path Mapping in tsconfig.json

Please provide the environment you discovered this bug in.
Angular
https://stackblitz.com/edit/wwbyfs
Which area/package is the issue in?
accordion
Description
If I add to tsconfig.json module
"@spartan-ng/ui-icon-helm": ["./components/ui-icon-helm/src/index.ts"]

and I want to import it in the component as
import { HlmIconComponent } from '@spartan-ng/ui-icon-helm';

I get the error "Error: Module not found: Error: Can't resolve '@spartan-ng/ui-icon-helm'". But if I import directly by specifying the relative path
import { HlmIconComponent } from '../../components/ui-icon-helm/src/index';

everything works.
Please provide the exception or error you saw
Error: Module not found: Error: Can't resolve '@spartan-ng/ui-icon-helm'

Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[X] No

Thanks, it works now


channel.db massive (22GB)

Background
My channels.db is massive at 22gb and growing quickly. I ran compact on it and it barely shrinks.
I rebalance a lot but have read other people that rebalance a lot don't have massive dbs like I do.
I ran DeleteAllPayments using rest and grpc and it doesn't seem to really do anything.
Not sure how I can get my database to shrink, any ideas?
These are some of my settings:
[Application Options]
payments-expiration-grace-period=30m
ignore-historical-gossip-filters=1
sync-freelist=false
stagger-initial-reconnect=1
maxlogfiles=3
gc-canceled-invoices-on-startup=true
gc-canceled-invoices-on-the-fly=true
accept-amp=true
[bolt]
db.bolt.auto-compact=true
db.bolt.auto-compact-min-age=100h
Your environment
lnd:v0.14.3-beta

try updating to lnd 0.15

Hello @SatCollector, as @alexbosworth said, updating to v0.15.x will help you with this. From the release notes This migration enables a 95% reduction in the disk space consumed by new channel updates
That will help to stop the db from growing that much but it's not a silver bullet to reduce the current size of the db yet. More changes have already been merged to master, but they are not included in any release yet.

Yep, you should upgrade to 0.15 which cuts down state growth by ~90%. 0.15.1 will also contain an optional migration to reclaim all the used up state. 0.15.1 will also keep around less information on disk for failed payments as well.


Use modsecurity rule chain error!

My modsecurity version is 3.0.2
I add the rule to REQUEST-900-EXCLUSION-RULES-BEFORE-CRS.conf,the rule is:
SecRule REQUEST_FILENAME "@beginsWith /admin" "chain,phase:1,block,log,id:1008"
    SecRule REMOTE_ADDR "!@ipMatch <IP_ADDRESS>"

But I run nginx -t is show some error
"nginx: [emerg] "modsecurity_rules_file" directive Rules error. File: /usr/local/openresty/nginx/conf/modsecurity/owasp-modsecurity-crs/rules/REQUEST-901-INITIALIZATION.conf. Line: 1. Column: 75. Expecting an action, got:  # ------------------------------------------------------------------------ in /usr/local/openresty/nginx/conf/vhosts/pibc_n22yeguan.conf:6
nginx: configuration file /usr/local/openresty/nginx/conf/nginx.conf test failed"
After I delete this rule, the detection is OK!!!!
Why??? My syntax is error?

Hi @Hello-Linux,
What kind of editor are you using to save the file?

Closing this on the favor of #2311


Latest Download Proxy crashes QS

My Downloads Path is a symlink to /Volumes/data/Downloads
I use this to conserve space on my SSD
Unfortunately this crashes QS when selecting the Latest Download Proxy.
This is also true if the symlink points to another directory on the same volume.
This is also true if the Downloads folder is empty (although #187 states it should not crash).
var/log/messages gives only this:
Nov 28 17:08:16 hexa com.apple.launchd.peruser.501[654] ([0x0-0x19c19c].com.blacktree.Quicksilver[5851]): Job appears to have crashed: Segmentation fault: 11
Nov 28 17:08:16 hexa ReportCrash[5847]: Saved crash report for Quicksilver[5851] version ß63 (3912) to /Users/hild/Library/Logs/DiagnosticReports/Quicksilver_2011-11-28-170816_hexa.crash

I can attach a crash report if it help.

I had recently come across the 'empty downloads folder' bug. Seems like
#187 didn't fix it.
I have a fix in the pipeline, and just need to submit a request when I get
the time.
Just looked into the symlink bug and that also seems like an easy fix. Will
try and push something out son.
On 28 November 2011 16:22, durandom <
<EMAIL_ADDRESS>
wrote:

My Downloads Path is a symlink to /Volumes/data/Downloads
I use this to conserve space on my SSD
Unfortunately this crashes QS when selecting the Latest Download Proxy.
This is also true if the symlink points to another directory on the same
volume.
This is also true if the Downloads folder is empty (although #187 states
it should not crash).
var/log/messages gives only this:
Nov 28 17:08:16 hexa com.apple.launchd.peruser.501[654]
([0x0-0x19c19c].com.blacktree.Quicksilver[5851]): Job appears to have
crashed: Segmentation fault: 11
Nov 28 17:08:16 hexa ReportCrash[5847]: Saved crash report for
Quicksilver[5851] version 63 (3912) to
/Users/hild/Library/Logs/DiagnosticReports/Quicksilver_2011-11-28-170816_hexa.crash

I can attach a crash report if it help.

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/issues/596

See #616 for further information on another crash

I see this issue as well (B63 on Snow Leopard).  I've got "~/Downloads" symlinked to another mounted volume.  Any attempt to search objects starting with "down" inevitably crashes QS.

Pull request #602 should have fixed this problem. We hope to release a new Quicksilver version soon, but in the meantime you can build the latest version from GitHub (not for the faint hearted!)
See here: http://qsapp.com/wiki/Building_Quicksilver
I will close this now that #602 has been merged into master.

I can confirm that B64 (3915) fixes this problem.  Thanks!


webpack import videojs-contrib-hls will not register hls source handler for html5 tech, that cause media_err_src_not_supported

Sorry, i do not know whether or not it is vue-video-player issue or video-contrib-hls itself. I can not use vue-video-player well with hls, so i report bug here also.
When i use webpack to bundle videojs and contrib-hls, the video-contrib-hls will not register sourceHandlers of "Html5" tech.
Please see the video.js code here:
`
_Tech.selectSourceHandler = function (source, options) {
var handlers = _Tech.sourceHandlers || [];
var can = void 0;
for (var i = 0; i < handlers.length; i++) {
  can = handlers[i].canHandleSource(source, options);

  if (can) {
    return handlers[i];
  }
}

`
So, if i try to play m3u8 video in chrome, the console will printed out:
"
VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) No compatible source was found for this media
"
If i use videojs and videojs-contrib-hls with a tag in html, the contrib-hls will register sourceHandlers of "Html5" tech right. Everything works fine.
Vue.js version and component version
V2.5.4
Reproduction Link

Sorry, it is a generic build and run question, no easy for jsbin

Steps to reproduce

use webpack bundle including video.js and video.contrib-hls
play a m3p8 using video.js

What is Expected?
should play video
What is actually happening?
There will be following error in console:
'
VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) No compatible source was found for this media
'

i pasted the additional info here from videojs bug report also:
So, can you explain when the video-contrib-hls will register HlsSourceHandler to html5 tech a little bit?
The issue is clear: contrib-hls will not register rightly its hls source handler to html5 tech, so videojs can not find a capable source handling m3u8, that will cause 'VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) No compatible source was found for this media' error. If we have some glue on when and how contrib-hls register its hls source handler, we can fix it or workaround it.
thanks~!

how to change vue-video-player‘s package.json ? create a new npm pacakge?

create a new npm pacakge?


chore(changelog): auto-changelog generator

Closes #1210
To generate the changelog of the new release, you have to run:
npm run changelog

I could make that changelog would be generated right before publishing new version but I think it's better to run it manually so you can check everything.

To create a whole new changelog, including very previous changes, use:
conventional-changelog -p angular -i CHANGELOG.md -s -r 0

@kamilkisiela cool :+1:


Update to work with the upcoming version of Zotero (currently in widely popular beta)

The title says it all. Zotero has released a widely popular beta last summer, which will ultimately become a major release (hopefully this year). At some point in the beta development cycle memento stopped working and it would be great if this could be addressed.
Thank you very much for this great add-on and all the best,
Till

As expected, not working with the released v6 :)

As with the mdnotes plugin, a quick workaround is to change  em:maxVersion5.</em:maxVersion> to em:maxVersion6.</em:maxVersion> in the install.rdf in the xpi-file.
Just rename the .xpi-file to a .zip-file, unpack, open the rdf-file in a text editor like Visual Studio Code, change the max version. Compress the files back to a .zip and rename to .xpi
Just tested it, and it works just fine for the time being.

@VanillaChief thanks for the note.

Currently observing the one made by @Spehhhhh for a possible community pre-update (since IDK how to pack XPIs)

Came here because of this problem.

I have put a link of compiled XPI in #19 for those who need it.

As a pesky request @Spehhhhh  is it also okay to handle https://github.com/leonkt/zotero-memento/issues/17 ?

@BrandonKMLee I'll give it a try 😂

[X] #19 work with the Zotero 6.*
[ ] #12 #13 work with BetterBibTeX
[ ] #17


[Group 2][Accessible Pressable] Migrate OptionRowLHN

HOLD on https://github.com/Expensify/App/issues/16988
Description
Migrate OptionRowLHN to use PressableWithFeedback

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details.

Hi can you assign me to this one, please?

@roryabraham In the meantime #16079 was merged into main and it changes TouchableOppacity into PressableWithSecondaryInteraction, so in this case, is my PR still needed? PressableWithSecondaryInteraction will be migrated to GenericPressable in  #17047 by @robertKozik

Oh yeah, looks like this issue isn't needed anymore.


module/private-tls-cert - IP Addresses Requirement

Is there a way to get around the IP addresses requirement in the private-tls-cert module?  I'm generating ASG clusters using terraform in AWS, and it would be beneficial to use domains with wildcards instead of IP's since everything is generated on the fly.
My only other options seem to be:

Include the module in my project, then generating everything together (putting the private key in the remote state file) in order to dynamically generate the IP list
Set up an ELB with an elastic IP, which makes my cluster public

Is there another way?

Have you tried setting it to an empty list?

That may very well be the first thing that I tried.  I also tried removing the variable completely from private-tls-cert given that ip_addresses is an optional field to the tls_cert_request resource.  Unfortunately, both of these changes result in a 'SAN IP` error in response to engaging with the server:
Error initializing: Put https://<IP_ADDRESS>:8200/v1/sys/init: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs

Adding <IP_ADDRESS> to the list fixes this issue for vault operator init, but it doesn't help when the nomad-cluster or any other services are trying to engage from dynamic addresses.
The only immediate solution that comes to mind is to create a *.tf file that gets auto-generated with all IPs that are dynamically allocated under a class B VPC -- 65536 in total, minus the few network, broadcast, and gateway IPs which I wouldn't expect the certs to allow in this case.

AFAIK, TLS certs are issued for IPs or domain names. You can't issue one for "all IPs" or "all domain names." Therefore, you have several options:

Create TLS certs that match the domain name your Vault nodes register in the Consul agent. E.g., vault-0.service.consul, vault-1.service.consul, etc. See dnsmasq.

Attach DNS names to each Vault node using Route 53 private hosted zones and issue TLS certs for these same internal domain names.

Attach an ENI to each Vault server to give it a static IP and issue a TLS cert for the same IP.

Thanks for the feedback.  I see what I was missing: the reverse lookup on the IP addresses was key in allowing the clients to connect.  The following configuration parameters resolved it for me:
ip_addresses = ["<IP_ADDRESS>"]
dns_names = ["*.consul", "active.vault.service.consul"]

The *.consul was the key here, since forward lookup on services was *.service.consul and reverse lookup was `*..consul
Also, I hadn't realized that ENI was a thing, that's good to know.
Thanks!


Invalid invoice (LNURL invoice check rejects invalid LNURL invoice)

Describe the bug
An invoice which contains route hints is considered invalid by Alby. The GUI reports following:
Payment aborted. Invalid invoice

To Reproduce
Steps to reproduce the behavior:

Visit to https://ln.anyone.eu.org/meta1.html
Click on Alby extension button (which should be activated since the site contains appropriate meta tag).
Click the Send Satoshis button.
Click the Confirm button.
See error

Expected behavior
The payment process should be initiated with no Invalid invoice message, like when you do the same at https://ln.anyone.eu.org (which targets at anyone@coinos.io).
Information About Alby

Alby Version: 1.6.0
Alby installed through browser stores
Wallet connected with Alby: Alby LND

Device Information [optional]:

OS: Linux
Browser: Google Chrome (stable)
Browser Version: Version 98.0.4758.102 (Official Build) (64-bit)

Additional context
The issue is not present when paying<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>so here are the decoded invoices of the two:
$ lnaddr.sh<EMAIL_ADDRESS>15000
https://stacker.news/api/lnurlp/justsmile/pay?amount=15000
{"pr":"lnbc150n1p3rnd33pp5qrvzeyvn4j3454pg7a959l4mdhjp5hkg8khgj27gvttuf2y4zn7qhp5rh2046zf4yykuc77pt926gfrq9xmdyg7qmsqckq434q707d2ga7scqzpgxqr23ssp5gf8k52y73mpscsh4yuv8zz89mvg0mhwm76p39d0f73ctlvt49yzq9qyyssqfhwy0qa0377p2slghhxg4je6xxa4x609y39lvhwappy2p3pt977qp72ed2qsd07cgs5y5p5k50eznptqamaypsdzhq8xukvn6nxwdagp8xhcg0"}
$ lightning-cli decode lnbc150n1p3rnd33pp5qrvzeyvn4j3454pg7a959l4mdhjp5hkg8khgj27gvttuf2y4zn7qhp5rh2046zf4yykuc77pt926gfrq9xmdyg7qmsqckq434q707d2ga7scqzpgxqr23ssp5gf8k52y73mpscsh4yuv8zz89mvg0mhwm76p39d0f73ctlvt49yzq9qyyssqfhwy0qa0377p2slghhxg4je6xxa4x609y39lvhwappy2p3pt977qp72ed2qsd07cgs5y5p5k50eznptqamaypsdzhq8xukvn6nxwdagp8xhcg0
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 10800,
   "payee": "03cc1d0932bb99b0697f5b5e5961b83ab7fd66f1efc4c9f5c7bad66c1bcbe78f02",
   "msatoshi": 15000,
   "amount_msat": "15000msat",
   "description_hash": "1dd4fae849a9096e63de0acaad2123014db6911e06e00c58158d41e7f9aa477d",
   "min_final_cltv_expiry": 40,
   "payment_secret": "424f6a289e8ec30c42f527187108e5db10fddddbf68312b5e9f470bfb1752904",
   "features": "024200",
   "payment_hash": "00d82c9193aca35a5428f74b42febb6de41a5ec83dae892bc862d7c4a89514fc",
   "signature": "304402204ddc4783af8fbc1543e8bdcc8acb3a31bb5369e5244bf65ddd0848a0c42b2fbc022000f9596a8106bfd844284a0696a3f2298560eefa40c1a2b80e6e5993d4cce6f5",
   "valid": true
}

Now the other invoice produced by CLN (c-lightning) which has issues in Alby:
$ ./lnaddr.sh<EMAIL_ADDRESS>15000
Enter comment (maxLength: 255): forAlby
https://signetfaucet.bublina.eu.org/cgi-bin/lnurl.sh?amount=15000&comment=forAlby
{"pr":"lnbc150n1p3rnwm8pp5ks2uhszpsscwk35m7tsz5daqengsjpmulew5zs4fnjlpdgan2r2sdqa235xzmntypuk7afpypnx7ujpd338jxqyjw5qcqpjsp5ex6625qahu45uerr34xxcw00nu5cdf6dlexqup3nq3jgwz7dj2vqrzjq2rguyhnyqrnetgv99vugf2el08ar23jdl9egdyja4ls9jvzp23ejz40qsqqrcgqqqqqqqlgqqqqqqgq9q9qyysgqcrlhyz4qgqehsrwt6flq5a2cka0njglrlaf0q3ath8zuhyc2xm6xnwykmtuy840z6mphrzu2zy4m45dy08ewhemx8vdpsswy6y7snncpgtz30a"}
$ lightning-cli decode lnbc150n1p3rnwm8pp5ks2uhszpsscwk35m7tsz5daqengsjpmulew5zs4fnjlpdgan2r2sdqa235xzmntypuk7afpypnx7ujpd338jxqyjw5qcqpjsp5ex6625qahu45uerr34xxcw00nu5cdf6dlexqup3nq3jgwz7dj2vqrzjq2rguyhnyqrnetgv99vugf2el08ar23jdl9egdyja4ls9jvzp23ejz40qsqqrcgqqqqqqqlgqqqqqqgq9q9qyysgqcrlhyz4qgqehsrwt6flq5a2cka0njglrlaf0q3ath8zuhyc2xm6xnwykmtuy840z6mphrzu2zy4m45dy08ewhemx8vdpsswy6y7snncpgtz30a
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 604800,
   "payee": "032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605",
   "msatoshi": 15000,
   "amount_msat": "15000msat",
   "description": "Thank you! forAlby",
   "min_final_cltv_expiry": 18,
   "payment_secret": "c9b5a5501dbf2b4e64638d4c6c39ef9f2986a74dfe4c0e06330464870bcd9298",
   "features": "024100",
   "routes": [
      [
         {
            "pubkey": "02868e12f320073cad0c2959c42559fbcfd1aa326fcb943492ed7f02c9820aa399",
            "short_channel_id": "700164x481x0",
            "fee_base_msat": 1000,
            "fee_proportional_millionths": 1,
            "cltv_expiry_delta": 40
         }
      ]
   ],
   "payment_hash": "b415cbc0418430eb469bf2e02a37a0ccd109077cfe5d4142a99cbe16a3b350d5",
   "signature": "3045022100c0ff720aa04033780dcbd27e0a7558b75f3923e3ff52f047abb9c5cb930a36f4022069b896daf843d5e2d6c3718b8a112bbad1a479f2ebe7663b1a1841c4d13d09cf",
   "valid": true
}

For lnaddr.sh script, have a look at https://github.com/jsarenik/cls.
Are you working on this issue? No, but let me know how can I help.

Same thing with version 1.7.0.

Can you confirm that the amount is set correctly? lnurl-pay is using millisats and the amount request is passed as GET parameter to the callback URL.
this means your callback URL should create an invoice for 10 sats:
https://signetfaucet.bublina.eu.org/cgi-bin/lnurl.sh?amount=10000
but it creates an invoice of 100 sats.
Check the spec: https://github.com/fiatjaf/lnurl-rfc/blob/legacy/lnurl-pay.md

Could the problem be here? https://github.com/getAlby/lightning-browser-extension/blob/master/src/common/lib/lnurl.ts#L109

For completness, here is another lightning address<EMAIL_ADDRESS>which works well with Alby and produces following invoice:
$ lnaddr.sh<EMAIL_ADDRESS>15000
Enter comment (maxLength: 500): forCoinOS
https://coinos.io/lnurl/671ce96fec63876c1fabc68bb95751808559b35bdb94ed390de9cbb9a7137904?amount=15000&comment=forCoinOS
{"pr":"lnbc150n1p3r4f34pp5h9rh6yyrreckexz32a6mvtke5jqz064567htwlg6xlplll7jncpqhp5t7ygdl8ft532fa2gpgxhh4rg9afsn9yp22yfpnglluevg6ey6ytqcqzpgxqyz5vqsp5f8mv3dzgu9nvpzsw4zyuxjernderz65ana0syy0tk3kjx49qvfzq9qyyssqfqhnq8ukxgfp45796j9ew2n5ypyehhlt5azyskztpgdd3u4f864zuy45954qe27qysj56uzl4k3xkefpxng993sazqxgrthxd5g8fcsq2rjzcv","routes":[]}
$ lightning-cli decode lnbc150n1p3r4f34pp5h9rh6yyrreckexz32a6mvtke5jqz064567htwlg6xlplll7jncpqhp5t7ygdl8ft532fa2gpgxhh4rg9afsn9yp22yfpnglluevg6ey6ytqcqzpgxqyz5vqsp5f8mv3dzgu9nvpzsw4zyuxjernderz65ana0syy0tk3kjx49qvfzq9qyyssqfqhnq8ukxgfp45796j9ew2n5ypyehhlt5azyskztpgdd3u4f864zuy45954qe27qysj56uzl4k3xkefpxng993sazqxgrthxd5g8fcsq2rjzcv
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 86400,
   "payee": "02868e12f320073cad0c2959c42559fbcfd1aa326fcb943492ed7f02c9820aa399",
   "msatoshi": 15000,
   "amount_msat": "15000msat",
   "description_hash": "5f8886fce95d22a4f5480a0d7bd4682f53099481528890cd1fff32c46b24d116",
   "min_final_cltv_expiry": 40,
   "payment_secret": "49f6c8b448e166c08a0ea889c34b239b72316a9d9f5f0211ebb46d2354a06244",
   "features": "024200",
   "payment_hash": "b9477d10831e716c98515775b62ed9a48027eab4d7aeb77d1a37c3ffffd29e02",
   "signature": "30440220482f301f9632121ad3c5d48b972a7420499bdfeba74448584b0a1ad8f2a93eaa02202e12b42d2a0cabc024254d705fada26b652134d052c61d100c81aee66d1074e2",
   "valid": true
}

So what we see is that the invoices which are accepted by Alby contain the "description_hash" field, which the c-lightning-generated invoice does not contain (it is considered optional, correctly defined with ? in Alby's src/declarations.d.ts)

For the record: I am pretty sure this issue is not because of routing hints or similar.
This issue is because of the LNURL described validations of the invoice. In this case the invoice (requested through LNURL-pay) does not pass the validation. (amount, description_hash must be the hash of the LNURL metadata, ...)
see also: https://github.com/getAlby/lightning-browser-extension/pull/735#issuecomment-1077440267

@bumi Yes, it is being worked on in c-lightning. See https://github.com/ElementsProject/lightning/pull/5121, which I was totally unaware of.
Thanks @fiatjaf for link!
Leaving this issue open just to track it also on this side (as there may be others like me unaware of the related work).

great, I updated the title to mention the LNURL invoice check.
keep me posted, I did not know that LNURL-pay is not possible with a clightning node right now.

Here is a new invoice with deschashonly=true parameter introduced by ElementsProject/lightning@ccaf04d26 and seems to still not work with Albi. @bumi please have a look what could be wrong here.
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 604800,
   "payee": "032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605",
   "msatoshi": 1000,
   "amount_msat": "1000msat",
   "description_hash": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
   "min_final_cltv_expiry": 18,
   "payment_secret": "26c8de60d4cc4d78db9d641bf724fad4eda0750fd459747eda548e70c9ec0ebf",
   "features": "024100",
   "routes": [
      [
         {
            "pubkey": "038fe1bd966b5cb0545963490c631eaa1924e2c4c0ea4e7dcb5d4582a1e7f2f1a5",
            "short_channel_id": "728591x176x1",
            "fee_base_msat": 0,
            "fee_proportional_millionths": 0,
            "cltv_expiry_delta": 34
         }
      ]
   ],
   "payment_hash": "eda88c6c5de9916d9a9530e3274df0e06ef5e2811f8f676ba8caf37c6c50ef1f",
   "signature": "3044022054085601153fcf15b145d64f73d5a9235f867e25091551daa59602fe79fb5b8d022079249349a36df5952e3cf6fde135eaaa1b89cc50012c08c721e68ed156745fae",
   "valid": true
}

Yes, that's an empty description:
$ printf "" | sha256sum
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  -

Another example. The invoice was triggered via LNURL by Albi:
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 604800,
   "payee": "032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605",
   "msatoshi": 123000,
   "amount_msat": "123000msat",
   "description_hash": "9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08",
   "min_final_cltv_expiry": 18,
   "payment_secret": "1921071e64595e80aee39cc369df7b17a95610bd0e4ac7e03b22aa5ff9aeab4f",
   "features": "024100",
   "routes": [
      [
         {
            "pubkey": "038fe1bd966b5cb0545963490c631eaa1924e2c4c0ea4e7dcb5d4582a1e7f2f1a5",
            "short_channel_id": "728591x176x1",
            "fee_base_msat": 0,
            "fee_proportional_millionths": 0,
            "cltv_expiry_delta": 34
         }
      ]
   ],
   "payment_hash": "10ece78344d524bf1c2516e8bb549ad9996b0510a905b94767140131ba5f0a72",
   "signature": "304402204695669345e139b5e5fa0ac087af55ada6e034428111f8317f9ff29d3eb6c532022044d600a17eb98478c5032770f404488315f912ee64220a5d35a63050064122cd",
   "valid": true
}

This invoice is recorded like this with CLN:
$ lch listinvoices lnurl-generated-12541-test
{
   "invoices": [
      {
         "label": "lnurl-generated-12541-test",
         "bolt11": "lnbc1230n1p3ygeqrpp5zrkw0q6y65jt78p9zm5tk4y6mxvkkpgs4yzmj3m8zsqnrwjlpfeqhp5n7rdpqvgf37ktx30a2sv2kkszk3m7ncm9v9cytx3t4kptv8spgyqxqyjw5qcqpjsp5ryssw8nyt90gpthrnnpknhmmz754vy9ape9v0cpmy249l7dw4d8srzjqw87r0vkddwtq4zevdysccc74gvjfckycr4yulwtt4zc9g087tc62zc7puqqpvqqqyqqqqqqqqqqqqqqyg9qyysgqg62kdy69uyumte06ptqg0t644knwqdzzsyglsvtlnlef604kc5eyf4sq59ltnprcc5pjwu85q3ygx90ezthxggs2t566vvzsqeqj9ngq30954y",
         "payment_hash": "10ece78344d524bf1c2516e8bb549ad9996b0510a905b94767140131ba5f0a72",
         "msatoshi": 123000,
         "amount_msat": "123000msat",
         "status": "unpaid",
         "description": "test",
         "expires_at":<PHONE_NUMBER>
      }
   ]
}

Read https://github.com/fiatjaf/lnurl-rfc/blob/luds/06.md, @jsarenik.
The "metadata" field is this JSON string which is an array of properties. That is what should be hashed for the description_hash. The wallet will check if bolt11.invoice_description == sha256(metadata).

@fiatjaf at https://github.com/fiatjaf/lnurl-rfc/blob/luds/06.md#wallet-to-service-interaction-flow in point 7 writes that h tag in provided invoice… what's is that? I do not see any h tag inside the invoice generated by coinos.io or stacker.news, not even zbd.gg.
I also do not understand the meaning and flow of https://github.com/fiatjaf/lnurl-rfc/blob/luds/06.md#notes-on-metadata-for-server-side-lnurl-pay and need more explanation on that.
Example invoice generated for<EMAIL_ADDRESS>follows:
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 300,
   "payee": "0251fff168b58b74e9b476af5a515b91fe0540a3681bc97fbb65379a807aea5f66",
   "msatoshi": 21000,
   "amount_msat": "21000msat",
   "description_hash": "b66fde4e4d981bce733f07eb743ce9a322905e448d83101ba414cf48925bcc18",
   "min_final_cltv_expiry": 40,
   "payment_secret": "d5e4b8dbb5ef4b29cc883c73efd821babf08bd6a3b947780856b7734e6f748fa",
   "features": "024200",
   "payment_hash": "079849a0ea8b40d4e1a64511a62112b7785893999223f8b0dc3f187ed8fe6955",
   "signature": "304502210092b7e8ddabec75f9ecac805d7bd3326ee30853e90736f2e5b4170b344151579a02206f655d61a9d875cd7e0c3ef872c265eaa93651169520b3b3086be612cf113928",
   "valid": true
}

The JSON sent by zbd.gg was this:
{
  "minSendable": 12000,
  "maxSendable": 45000000,
  "commentAllowed": 150,
  "tag": "payRequest",
  "metadata": "[[\"text/plain\",\"fiatjaf - o bramido do silêncio do diamante\"],[\"text/identifier\",\"fiatjaf@zbd.gg\"],[\"image/png;base64\",\"[encoded data, 5744 characters]\"]]",
  "callback": "https://api.zebedee.io/v0/process-static-charges/1f561267-6b24-4f2e-bb6b-5cd162727840",
  "payerData": {
    "name": {
      "mandatory": false
    },
    "identifier": {
      "mandatory": false
    }
  },
  "disposable": false
}

The h tag is the description hash, see bolt11: https://github.com/lightning/bolts/blob/master/11-payment-encoding.md#tagged-fields=

Can you please point me to some working code that is doing it properly? Any language.

Pseudocode:
handle('/.well-known/lnurlp/username') => {
  return {
    ...,
    metadata: '[["text/plain", "my description"]]',
    callback: 'https://service.com/callback'
  }
}

handle('/callback') => {
  return {
    pr: make_invoice(description_hash=sha256('[["text/plain", "my description"]]', msatoshi=request.qs.amount))
  }
}

I don't know the new c-lightning API works though. How are you calling it?

I call lightning-cli from shell.
$ desc=test
$ lightning-cli -k invoice msatoshi=1000 label="lnurlp-test-$RANDOM" description="[[\"text/plain\", \"$desc\"]]" deschashonly=true
{
   "code": -32602,
   "message": "description: should be a string (without \\u): invalid token '[[\"text/plain\", \"test\"]]'"
}

Pseudocode:
handle('/.well-known/lnurlp/username') => {
  return {
    ...,
    metadata: '[["text/plain", "my description"]]',
    callback: 'https://service.com/callback'
  }
}

handle('/callback') => {
  return {
    pr: make_invoice(description_hash=sha256('[["text/plain", "my description"]]', msatoshi=request.qs.amount))
  }
}

Thank you for this example @fiatjaf. I get the idea, just that description_hash should be the hash of the description. This looks like artificially setting the value (which is not yet implemented in c-lightning, or would require allowing description to contain characters which are filtered now).

Try calling the RPC directly instead of the CLI. Does it raise the same error?

I have no idea how to call that RPC directly. Happy to learn. @cdecker?

If I read that linked PR correct: did you try setting the metadata as invoice description and specify the hash only attribute?

Yes, I tried setting the metadata as invoice description and specified the deschashonly attribute.

@jsarenik:
echo '{"method":"getinfo","params":{},"jsonrpc":"2.0","id":"0"}' | nc -U ~/.lightning/bitcoin/lightning-rpc

But do it with the invoice stuff instead.

It is possible to put there single-quotes, but that will not help probably. I.e. to end up with
"description": "[['text/plain', 'my description']]",

Strange that it does not work with escaped double-quotes as the LUD shows backslashes in the example: "[[\"text/plain\", \"lorem ipsum blah blah\"]]"

I actually found the hash and was able to reproduce it manually, so the double-quotes are not the issue. Writing it down to think more about what I may be doing wrong.
First, an invoice is generated by CLN, triggered by Albi over LNURLp. The description is set to [[\"text/plain\", \"anyone\"]]. This invoice decoded looks like this:
{
   "type": "bolt11 invoice",
   "currency": "bc",
   "created_at":<PHONE_NUMBER>,
   "expiry": 604800,
   "payee": "032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605",
   "msatoshi": 1000,
   "amount_msat": "1000msat",
   "description_hash": "5a6ede4ae913c22e0b5f00c0fd16e376893e2f1ef131e5b296b66993dced971a",
   "min_final_cltv_expiry": 18,
   "payment_secret": "1cf98aa26f31e28f9a42d2d26fe5d716b527bedd3a8cc7e8e4d3e74dd5e5aada",
   "features": "024100",
   "routes": [
      [
         {
            "pubkey": "029e3508ee0579a5aceb3bfecb01839fb1309fe67050b26d9ce9e27323fa2e66f1",
            "short_channel_id": "684650x2064x0",
            "fee_base_msat": 1000,
            "fee_proportional_millionths": 1,
            "cltv_expiry_delta": 40
         }
      ]
   ],
   "payment_hash": "b40e2b930b2282bd187e568868c2ce1c7ef7e302b2487cb876965184e43d6ed6",
   "signature": "3044022019d1e20300ebde2cdd6dffea3939e67a83fcc378a365bb3565d46ecfb3b56eca02201d31fd4d3b1cc4ee69965c3fbb35bf2f5ada38469cc60528ebf7ed7cfa47f9e3",
   "valid": true
}

Now I do the sha256 checksum (note the \" becomes " because of printf, opposite of what I was thinking, so the result actually matches the example code provided by @fiatjaf):
$ printf '[[\"text/plain\", \"anyone\"]]' | sha256sum
5a6ede4ae913c22e0b5f00c0fd16e376893e2f1ef131e5b296b66993dced971a  -

The result is the same hash as the description_hash in the decoded JSON above. Now I need to figure out what am I doing wrong that Alby still reports "Invalid invoice".

@bumi How to see some debugging of the Albi browser extension? And yes, I was trying to set random text description as well.

How are you testing this in Alby?

I am testing exactly as described in the reproduction steps in the beginning of this issue.
As for debugging on my side, you can see the static .well-known file, the source of lnurl.sh and its last JSON output for your originating IP which stays the same until paid or 1 for minute.

@bumi So my question is: what is Alby exactly checking the sha256sum against (with examples please)? My content of description_hash matches exactly the hash of [["text/plain", "my description"]] and the invoice is still deemed invalid.

if this is the lnurl-pay response: https://ln.anyone.eu.org/.well-known/lnurlp/anyone
metadata":"[["text/identifier"<EMAIL_ADDRESS>["text/plain", "anyone"]]"
then I think it checks the hash of [["text/identifier"<EMAIL_ADDRESS>["text/plain", "anyone"]] - the hash of the stringified version of the metadata JSON.
does that help? do you include the text/identifier?
this seems to be missing here: https://github.com/jsarenik/bitcoin-faucet-shell/blob/master/cgi-bin/lnurl.sh#L72
at least it is not using the same metadata as returned by the lnurl-pay JSON response.

@bumi Yes, that was it. Thank you!

great! happy we could solve it and it works! 👍


Policy lists via UTXO: lists updated before block confirmation.

This currently applies to the utxolists branch.
In validation.cpp, in ConnectBlock. The policy lists are updated from the transactions in the block before the block is fully validated; ConnectBlock could later return "false" with CValidationState other than "MODE_VALID".

Is this still a problem?

Potentially, yes. Ideally, the policy lists etc. should be updated just before the "return true". However, this could affect transactions within the same block that depend on policy.

Ok this sounds serious. Affect how do you mean?

For example, an address is added to the freeze list in a policy transaction. In a later transaction, in the same block, the asset from the frozen address is spent. So in this case the earlier transaction invalidates the later transaction.

Unless we want policy list changes only to take effect in the next block.

I think this part is fine since policy lists are used for mempool rejection. Still we shouldn't be updating them until the block is fully validated.

I'll push a fix for this in a moment.
Another possible issue is if e.g. DisconnectBlock is called, the policy lists wont be updated.
This also affects AssetMap and FreezeHistory.

partly resolved. relevant issue open #128


Add a daily scheduled CI build

A minimal daily scheduled CI build that runs the unit tests in an attempt to uncover any problems caused by having loosened our version constraints on some of our dependencies.
See https://arupdigital.atlassian.net/browse/LAB-1639.
Note that, for security reasons, new Actions workflows do not run until they have been created in the default branch, so we won't see this scheduled build start to run until after this PR has been merged.

unsubscribe

🤣


No need to handle version 1.7 Django anymore so removing those cases …

…from runtests.py
Hello,
Please make any comments/changes as necessary.

Thank you. Curious if you had a specific reason for this or just general cleanup?

Np, just cleanup :) I was running the tests and they failed because of something to do with my machine, totally unrelated. But as I was reading through the code I realized the Django 1.7 stuff.


Support for any OGR data source

It would be interesting to have integration of VirtualOGR sqlite extension - this could allow us to support any vector data format in addition to gpkg:
https://gdal.org/drivers/vector/sqlite.html#the-virtualogr-sqlite-extension

How this would work on static builds (iOS)?


Outlined buttons use grey color for border

What RMWC Version are you using [major.minor.patch]:
6.0.14
Name your build system [Webpack, Rollup...]:
Webpack
Describe the bug with as much detail as possible:
Outlined buttons border color is grey by default instead of using the primary color set. This can be seen in the RMWC website: https://rmwc.io/buttons
What happened, and what was supposed to happen:
The border color for outlined buttons should use the same primary color set for the theme as it worked in version 5.x

This is something you’d have to open with google. RMWC uses the css directly from Material components web, they have recently changed the spec.

Thanks for the quick answer @jamesmfriedman, checking their website they are still showing the primary color for outlined colors: https://material.io/components/buttons (maybe their website is not updated though).
Is there a way to change the border color using RMWC or CSS properties?

Oddly enough, the spec is updated, RMWC is right, their live docs are wrong. https://material.io/develop/web/components/buttons/
Just standard css. Target the button and set it's border color to border-color: currentColor

Thanks for the info @jamesmfriedman! I'll close this then.


(kitty) correct shim icon

It would be great if the shim for kitty.exe would have the correct icon from the original program.
this works for other programs, but not for kitty.

The package itself don't generate the shim, and it is chocolatey itself that generates shims for any .exe files located in the package.
I have no idea why the icon don't show up though, could be that the .exe don't have an icon and thus not detected by the shim utility.
I'll add this as an Up for Grabs as there probably is something we can do to add an icon (like specifically calling a function to generate the shim with a separate icon).

KiTTY has many icons as you can see on that page.
The first one is the official one:
.
I'm not sure, but I guess it has been an issue with the compressor binaries that I use: UPX.
Can you test with the KiTTY uncompressed version please ?

KiTTY has many icons as you can see on that page.
The first one is the official one:
.
I'm not sure, but I guess it has been an issue with the compressor binaries that I use: UPX.
Can you test with the KiTTY uncompressed version please ?

Looks better.
At least Windows is able to show/extract the icons.

But I don't know to proceed with this information.
I guess it would not make sense to renounce compression just for a few chocolate users. 😄

Looks better.
At least Windows is able to show/extract the icons.

But I don't know to proceed with this information.
I guess it would not make sense to renounce compression just for a few chocolate users. 😄

@CWempe I think it is fine to change the package to use the uncompressed edition.
TBH, this change should probably have been done quite some time ago (I personally never got around to it), and since it is just a 1,3-1,4 MB difference, it shouldn't matter too much to the majority of users.
I will be updating the script that checks for updated versions of kitty later this week to use the uncompressed edition, however, if you want to provide a PR to update it instead then feel free to do so.

@CWempe I think it is fine to change the package to use the uncompressed edition.
TBH, this change should probably have been done quite some time ago (I personally never got around to it), and since it is just a 1,3-1,4 MB difference, it shouldn't matter too much to the majority of users.
I will be updating the script that checks for updated versions of kitty later this week to use the uncompressed edition, however, if you want to provide a PR to update it instead then feel free to do so.

For your information: compressed version, has sometimes issues with some anti-virus. I suggest you to use the uncompressed version for that reason too. Don't forget to add the kitty.ini configuration file in the same directory where kitty.exe is, with the right save mode selection:

savemode=dir for portable mode
savemode=reg for classic mode (in registry)

For your information: compressed version, has sometimes issues with some anti-virus. I suggest you to use the uncompressed version for that reason too. Don't forget to add the kitty.ini configuration file in the same directory where kitty.exe is, with the right save mode selection:

savemode=dir for portable mode
savemode=reg for classic mode (in registry)

The changes to use the uncompressed edition of kitty is now added to the repository, I have not pushed a fix version to the chocolatey repository but will be available with the next time a new version of kitty is available.

The changes to use the uncompressed edition of kitty is now added to the repository, I have not pushed a fix version to the chocolatey repository but will be available with the next time a new version of kitty is available.


Support detecting submission by keyboard shortcut

To submit leetcode code, there's two way: 1) Clicking the submit button, 2) Pressing Ctrl + Enter.
The first one works well on dynamic layout, but the latter seems not. And it would be great if submitting by keyboard shortcut is also detected too.
Actually, @arunbhardwaj already tried this before, so it would be a proper point to start.
https://github.com/arunbhardwaj/LeetHub-2.0/pull/31

There were some problems leading to this issue. Wrong textarea listener was subscribed to and the timeout for reading the submission id was too fast. I uploaded v0.0.5 to Chrome Web Store. @snowphone Can you please check?
Unfortunately, I can currently only test on Mac. Found no issue so far with v0.0.5...

@snowphone Did you already have time to check v0.0.5? If you confirm this issue has been fixed, I will close this issue.

I just checked it works really well! As always thanks for your help :)

Okay great, thanks for your confirmation. Good that it works now :)


datadog: logger portion of new tracing library

This is part of the initiative described in https://github.com/envoyproxy/envoy/pull/23958.
This revision introduces a new library dependency for Datadog tracing, and adds a small component that will be used in the future when more of the new library is integrated into the Datadog tracing extension.
Logger implements the datadog::tracing::logger interface in terms of a spdlog::logger. This allows dd-trace-cpp to produce logs using Envoy's logging.

/wait

/assign @jmarantz

https://storage.googleapis.com/envoy-pr/be8597a/coverage/source/extensions/tracers/datadog/logger.cc.gcov.html
I'll add a test that modifies the configured logging verbosity so that these return; branches are covered.

/wait
needs main merge also

/wait (for CI to settle)

/retest

Thanks for the reviews. I'll address your comments and merge in main within the next couple of days.
I'm also open to ideas on how we could do logging differently here, either to avoid the leaking abstraction and/or to expose dd-trace-cpp's source files and line numbers.

I don't think we need to solve that problem in this PR -- this is not the first case where spdlog was referenced from envoy code outside its logging library; I just hadn't noticed it before.

/retest

@wbpcode feel free to merge when ready (assuming CI passes)


Rewrite in Compose

PR-Codex overview
This PR focuses on updating dependencies, adding data modifiers, and configuring the build.gradle.kts file.
Detailed summary

Updated versions of Kotlin, IntelliJ, Detekt, JUnit, Kotlin Coroutines, SVG to Compose, Mockito Kotlin, Jetbrains Jewel, Jetbrains Jewel LAF Bridge, and Compose Desktop.
Modified ValueValidator.kt and ProperDirValidator.kt to use data modifiers for sealed class objects.
Added plugins and dependencies to the build.gradle.kts file.
Configured repositories, dependencies, and tasks in the build.gradle.kts file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Closes #62


gt4_wordmap_new: invalid file size (1048576, should be 1429612) Error: Creating the wordmap failed!

During plasmid_seeker run i see this -
Converting sample reads to k-mers...
Finding coverage of bacterial isolate...
Bacteria median coverage is 100
##gt4_wordmap_new: invalid file size (1048576, should be 1429612)
Error: Creating the wordmap failed!
Plasmids done: 4384 of 4388
but after that everything is okay and result is generated. Does this "creating the wordmap failed" can cause change in result?

The problem is probably due to a corrupt list file.
If the error message was only shown once, it means that one list is corrupt and the corresponding plasmid won't be included in the final result even if it should.
Try downloading/creating the database again and see if the problem persists.


Build with ghc-8.6 containers

With Stackage Nightly:
containers-<IP_ADDRESS> is out of bounds for:

[ ] cheapskate-0.1.1 (>=0.4 && < 0.6). Sean Hunt<EMAIL_ADDRESS>@scshunt. @jgm. Used by: library

Okay I see this is already fixed in #28 PR.
Is it possible to have a Hackage revision or (point release) for this?

I just published a point release.
Jens Petersen<EMAIL_ADDRESS>writes:

Okay I see this is already fixed in #28 PR.
Is it possible to have a Hackage revision or (point release) for this?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jgm/cheapskate/issues/29#issuecomment-436139376

Thanks :)
I don't see it in Hackage, or you want me to test it first?

Sorry - it's there now.
Jens Petersen<EMAIL_ADDRESS>writes:

Thanks :)
I don't see it in Hackage, or you want me to test it first?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jgm/cheapskate/issues/29#issuecomment-436216198

Thanks, pandoc should be in tomorrow's Stackage Nightly

Jens Petersen<EMAIL_ADDRESS>writes:

Thanks, pandoc should be in tomorrow's Stackage Nightly

Thanks for that!


registerForStoryboard doesn't work with multiple storyboard

// ViewController1 in Mail.storyboard
container.registerForStoryboard(ViewController1.self) { r, c in
     c.viewModel = r.resolve(ViewModeling1.self)!              // 1
}
// ViewController2 in Other.storyboard
container.registerForStoryboard(ViewController2.self) { r, c in
    c.viewModel = r.resolve(ViewModeling2.self)!              // 2
}
// in didFinishLaunchingWithOptions
let storyboard = SwinjectStoryboard.create(name: "Main", bundle: bundle, container: container)

closure 1 is called when push to viewcontroller1, but not with closure 2
How to i resolve this issue ?

If ViewController2 is in Other.storyboard, another storyboard instance should be created:
let mainStoryboard = SwinjectStoryboard.create(name: "Main", bundle: bundle, container: container)
let otherStoryboard = SwinjectStoryboard.create(name: "Other", bundle: bundle, container: container)

thanks for your prompt response
//  didFinishLaunchingWithOptions method in AppDelegate class
let bundle = NSBundle(identifier: "rootViewController")
let mainStoryboard = SwinjectStoryboard.create(name: "Main", bundle: bundle, container: container)
let otherStoryboard = SwinjectStoryboard.create(name: "Other", bundle: bundle, container: container)
window.rootViewController = storyboard.instantiateInitialViewController()
return true
it still does not work. which object should the otherStoryboard assigns to ?

Are you using Storyboard Reference to transit from the control in Main.storyboard to the other in Other.storyboard? If not, tell me how you use the storyboards and view controllers?

yes, i'm using Storyboard Reference.
Anw, i resolved this issue with the code below
window.rootViewController = otherStoryboard.instantiateInitialViewController()
window.rootViewController = mainStoryboard.instantiateInitialViewController()
is it bad solution ?

Storyboard Reference is not supported yet. I added Issue #8 to track the feature.
So far, a workaround is putting all the view controllers in a single storyboard. Thank you for posting this issue. It is helpful for me to understand how users want to use Swinject.

Swinject version 0.3 supports Storyboard References.

Sound great.
Thanks a lot.


Stripe do not follow RFC6749 OAuth 2 specification in case of rejection by user

As requested in stripe-php#1653 I report the issue here.
Describe the bug
I don't know if this is the right place to open this issue, but since I use the PHP SDK I thought it appropriate to do it here.
Stripe do not follow RFC 6749 section 4.1.2 in the case of authorization rejected by the user. The state parameter is required in the response if the client_id and redirect_uri in the request are both valid (see also section <IP_ADDRESS>), I quote:

If the resource owner denies the access request or if the request
fails for reasons other than a missing or invalid redirection URI,
the authorization server informs the client by adding the following
parameters to the query component of the redirection URI using the
"application/x-www-form-urlencoded" format, per Appendix B:
....
state
REQUIRED if a "state" parameter was present in the client
authorization request.  The exact value received from the
client.
....

Consider implementing the specification according the RFC6749, otherwise cross-site request forgery cannot be verified.
To Reproduce
Steps to reproduce the behavior:

paste an authorization url into your browser like: https://marketplace.stripe.com/oauth/v2/authorize?client_id=${clientId}&redirect_uri=${redirectUrl}&state=${state}
click "Cancel" on the Stripe authorization page
the URL to which the browser is redirected does not have the state parameter: https://*********/oauth2?error=access_denied&error_description=The+user+denied+your+request

Expected behavior
state parameter must be returned unchanged.
Screenshots

not applicable -

Desktop (please complete the following information):

OS: Ubuntu 22.04.4 LTS
Browser Google Chrome
Version Version 121.0.6167.184 (Official Build) (64-bit)

Thank you for your quick answer.
Since it is part of the same area, and I am preparing the data for the review, I saw that your installation links for the app also obviously lack the state parameter since the flow starts from you instead of from a client platform:
https://marketplace.stripe.com/oauth/v2/authorize?client_id=*******&redirect_uri=********

The spec does not mention this type of procedure for the same CSRF security issue, and currently our platform rejects requests without the state parameter.
There is the possibility of chatting with the review team to draw attention to this aspect, otherwise we cannot send the app for review because I think it will be rejected even if it is not up to us.

We do document that the OAuth install link is recommended to include the state parameter in both the example and the callout here: https://docs.stripe.com/stripe-apps/api-authentication/oauth#install-app
Perhaps I'm misunderstanding where you are getting the link and it's lacking that param?

@gabrielhurley-stripe Sorry, I forgot to include the link to the documentation I was referring to: https://docs.stripe.com/stripe-apps/publish-app#submit-app-for-review
Point 5 of the "Submit app for review" section indicates that it is mandatory to specify the Marketplace install URL for OAuth apps.
In the URL that I must specify in the form, should I include a value (in this case hardcoded) of the state parameter for the authorization flows triggered by installing the app from your Marketplace?
There is news about:

Thanks for bringing this to our attention. The eng team is taking a look to ensure we handle this case correctly!

Is there any news about it?


Issue with Xcode 9

I am using Xcode 9 beta 3 and see the following error on line 1644 of Keychain.swift
/Pods/KeychainAccess/Lib/KeychainAccess/Keychain.swift:1644:62: Cannot convert value of type '[NSObject : Any]' to expected argument type '[String : Any]?'

@kishikawakatsumi thanks! When will this be pushed to cocoapods?


feat: upgrade sidecar image versions on node vhd

What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: upgrade sidecar image versions on node vhd
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.969%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3458

💛  - Coveralls

failure is not related to this change:
resources.DeploymentsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidTemplateDeployment" Message="The template deployment 'pkrdppps3wqjdda' is not valid according to the validation procedure. The tracking id is '88601d4f-8e8a-45d6-882a-0a0ebf911c3d'. See inner errors for details." Details=[{"code":"SkuNotAvailable","message":"The requested VM size for resource 'Following SKUs have failed for Capacity Restrictions: Standard_D16ds_v5' is currently not available in location 'eastus'. Please try another size or deploy to a different location or different zone. See https://aka.ms/azureskunotavailable for details."}]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.969%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3458

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.969%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3458

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls


Add in ERCC tracking into pipeline

Background: The ERCC controls are a set of "fake" mRNAs that were developed by a consortium for the purpose of judging RNAseq performance and QC, and are meant to be doped in to actual samples. They are ~92 mRNAs, spanning >6 logs of concentration. They are now sold commercially as a pre-mix.
Here is the product page
GTF needs to be added to the STAR file and a GeneCount file needs to be automatically generated.

@cdebourcy after standup will add more info and the relevant files - probably will just make a quip document.

https://czi.quip.com/UtauAYqoUqVp


cleanup: remove useless error

What this PR does / why we need it:
cleanup
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer:
Release note:

NONE

/close


Text overlap on mobile in contact info/ registered requests page

Seeing issue on mobile page due to text going outside the columns on contact info/ registered requests page. Fix is to wrap them inside the column itself

Duplicate of https://github.com/IEEEKeralaSection/rescuekerala/issues/42
Fixed with https://github.com/IEEEKeralaSection/rescuekerala/pull/93

.table-responsive>.table>tbody>tr>td, .table-responsive>.table>tbody>tr>th, .table-responsive>.table>tfoot>tr>td, .table-responsive>.table>tfoot>tr>th, .table-responsive>.table>thead>tr>td, .table-responsive>.table>thead>tr>th {
    /* white-space: nowrap; */
}

this will solve overlap otherwise we need to set a width for the container

Simple fix
In @media screen and (max-width: 767px)
use white-space: normal insted of white-space: nowrap

I fixed this manually. Please check

Thanks biswas, pls close this

Fixed

Please refer to some changes requested in #132


Sample files

Hi. Maybe you have sample Abaq files? To test syntax. Thanks

Hi! Try to check out the folder "test_inp_files"
:)


[folly] update to v2<IP_ADDRESS>

Fix #20558
Update folly to the latest version v2<IP_ADDRESS>
All feature are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Hello, is there any updates?

Duplicate to #20806


No license file

Hi! Have you considered adding a license file to your repo so it is clear what the terms of use are?
Thanks in advance.

added


Proposal RFC: custom output file locations

Formal proposal for #1561, following some discussion in #1921.
doc: https://github.com/GoogleContainerTools/jib/blob/i1561-proposal/proposals/output_files.md

@jrivard @blagerweij @hoppermann @codeseedr
Feel free to let us know if this meets what you're looking for with this feature, or request changes!

looks good to me, @chanseokoh, @briandealwis we good?

Looks good to me.


add the text  " small application and its program"

A restaurant application for various dishes and printing its bill using conditional statements.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

i would like to contribute more small projects using this topics using C language.


Update Commands: App ALM related commands to handle site collection app catalogs

Add support for site collection app catalogs... supported added to core APIs
Ref: https://docs.microsoft.com/en-us/sharepoint/dev/general-development/site-collection-app-catalog#configure-and-manage-site-collection-app-catalogs
Potentially affected commands

[x] site app add
[x] site app deploy
[x] site app get
[x] site app install
[x] site app list
[x] site app remove
[x] site app retract
[x] site app uninstall
[x] site app upgrade

Hey @andrewconnell, do you mind if I pickup your branch and complete the command. I can see that you almost completed it.
The reason: I am planning workshop on 10 of November on automating the SPFx pipeline and my intention is to use the Office 365 CLI with site app catalogs.

No problem at all... there's no chance I'll get to it by then...

Thanks @andrewconnell! No worries, I should be able to sync it in no time.


Personal access token limited for repository name

Always preffered 2FA.
When 2FA is enabled, user must create PAT to access the repo.
But this PAT have permission to ALL repos.
New feature:
at create token, declare repo name, and this token can access only for this repo name.

How that would be different form deploy keys?

deploy keys is for ssh only?

Duplicate of https://github.com/go-gitea/gitea/issues/2051?

So, 1year and half porposal


Moving UWPHook results in launch error

When creating a shortcut in steam app should copy itself (or a smaller launcher) in a safe location like %appdata% so moving the downloaded app will not result in a failed launch.

Sorry for that, will look into a way to fix it.

If i use a lnk to the app and you move the app it will still cause error because it won't find the .exe it wants and duplicating the app wont be a very inteligente way too. Trying to find another idea.

I don't really see this being a bug.  If you have shortcuts to any other program on Windows, and you move the original program location...your shortcuts will break and you'll have to re-create the shortcuts.


Question: Why do we store the user in local storage vs. just calling window.netlifyIdentity.currentUser() when we need that info?

As always there are many ways to do things, I'm not saying the way it's done here is wrong, just trying to learn.
Is there a reason you needed to store things in local storage, or could you have gotten away with a call to window.netlifyIdentity.currentUser() instead of using getUser() when you needed user info?
I see that the isLoggedIn function doesn't call getUser(), it's relying on a call to netlifyIdentity.
For anyone else trying to implement auth for a gatsby site I found these resources useful (in addition to this repo):

https://www.gatsbyjs.org/blog/2019-03-21-add-auth0-to-gatsby-livestream/
https://www.gatsbyjs.org/docs/authentication-tutorial/

i'm not really sure, its been a while since i made this. i think you want it in local storage just so you can reopen it in future and still grab it off local storage so you dont need to log in again. the implementation could probably be better. feel free to PR improvements!
i'm vaguely aware of a bug in other projects where this mechanism doesnt work, and you have to log in again when you refresh (i.e. the identity is only kept in memory). would love to have a good setup so that just never happens


No local imports into setup.py?

pip-compile fails if there are any local imports in setup.py. See below for traceback.
Environment Versions

OS Type: macOS
Python version: 3.9.0
pip version: 20.2.4
pip-tools version: 5.3.1

Steps to replicate
Structure:
src/
    __init__.py  # empty
    _version.py
setup.py

_version.py:
__version__ = "0.0.1"

setup.py:
from setuptools import find_packages, setup
from src._version import __version__

setup(
    name=“package-name”,
    version=__version__,
    packages=find_packages(),
)

Install pip-tools into a clean virtual environment, then run pip-compile.
Expected result
pip-compile runs and generates a requirements.txt file (empty in this MWE, as setup.py doesn't define any requirements).
Actual result
Traceback (most recent call last):
  File "/Users/njiles/anaconda3/envs/pip-tools-example/bin/pip-compile", line 8, in <module>
    sys.exit(cli())
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/site-packages/piptools/scripts/compile.py", line 393, in cli
    dist = run_setup(src_file)
  File "/Users/njiles/anaconda3/envs/pip-tools-example/lib/python3.9/distutils/core.py", line 215, in run_setup
    exec(f.read(), g)
  File "<string>", line 3, in <module>
ModuleNotFoundError: No module named 'src'

Hello @njiles,
Thanks for the issue. Invoking pip-tools as a module might help:
python -m piptools compile

You can read more information about the difference between pip-compile and python -m piptools compile here (in pytets context).
Also, AFAIK, it's not recommend to import any module that is not installed at the build time in setup.py file.

Thanks for the workaround - invoking pip-tools as a module to add the current location to sys.path solves the problem for me! From my point of view I'm happy for this to be closed, thank you 🙂

Also, AFAIK, it's not recommend to import any module that is not installed at the build time in setup.py file.

This approach is number 6 on this list from the PyPA Python Packaging User Guide - it does come with the warning

Warning
Although this technique is common, beware that it will fail if sample/__init__.py imports packages from install_requires dependencies, which will very likely not be installed yet when setup.py is run.

but this doesn't seem (to me at least) to apply to this case?

I'll close this based on the above. Thanks for the issue!

I'll close this based on the above. Thanks for the issue!


PA function is much slower than pse function during my imgs

test on a test dataset of small imgs (about 600 pics)，panet takes more time than psenet, average 20ms higher than psenet
test on a test dataset of big imgs (about 30 pics)，panet takes more time than psenet, average 100ms higher than psenet
Than I try to figture it out  and find the obivious difference between the two modle is the pa module which takes more time than pse module.
I have no idea how could this happened?

Further test, when img size is  (h,w,c)=(1280, 1280, 3), the pa process takes about 100 ms with about 10 text lines, while the other parts of the network before the pa takes about 10ms.


Revert "Tailing stop bug fix"

Reverts hpcloud/tail#99

@Nino-K Did this patch go sideways with a test?

@TerraTech yes, broke the build but it's merged now and the build is green.

@Nino-K So as of now  hpcloud/tail#99 is merged and there is no problem?

@arunmathew88 thanks for your contribution. So far so good, I tested it myself and did not come across any issues, the test coverage in this project is pretty low, I will have to through some tests in there to cover some of these cases.

Thanks @Nino-K .


F enemy ai

Wolf now deals damage if it touches player. Player also deals damage to wolf with attack animation and fireball.

 [FEATURE] Enemy That Follows PC

 [FEATURE] Melee Combat With Hitboxes

 [GRAPHICS] Preliminary Enemy Model