isServer returns false on the server with Deno

Describe the bug
I've been using SolidJS together with Deno successfully, I just use hyper DOM expressions instead of JSX and I think I even prefer it like this.
However, I was trying out the new ssr capabilities and noticed that the isServer function returns false even when I run it on Deno.
Your Example Website or App
https://deno.land/
Steps to Reproduce the Bug or Issue
Run the following script like this deno run bug.js:
// bug.js
import h from<EMAIL_ADDRESS>import {renderToString,isServer} from<EMAIL_ADDRESS>
console.log(isServer)
console.log(renderToString(()=>h('h1', 'Hello')))

Expected behavior
Output true
Screenshots or Videos
No response
Platform
deno 1.24.3 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 4.7.4
solid-js 1.5.4
Additional context
I've tried fixing this myself but did not see a clear path forward but I might know why we get this behaviour.
When the js module is created by http://esm.sh it does so by using the code in solid-js/web/src and not solid-js/web/server.

Yeah can we leverage conditional exports in deno? By default only make ssr build with node export. But this came up recently with workers too. I could add all these, but almost wish to just make a server export and have it settable for all of these. I imagine with Deno this might be more challenging if we can't set these conditions. Import Maps is potentially another option.

Deno has conditional exports in when running with --compat, and you can have a "deno" condition, but I don't see how that will help in this case.
I've tried another quick workaround with something like this:
import client from<EMAIL_ADDRESS>import server from<EMAIL_ADDRESS>
const IS_BROWSER = typeof document !== 'undefined';

export function renderToString(e) {
    if (IS_BROWSER) {
        return client.renderToServer(e)
    } else {
        return server.renderToServer(e);
    }
}

The problem with this is that it is also difficult to make a esm for dom-expressions beacuse of 'rxcore".

Yeah and we have different runtimes and compilation. Ideally we'd want to write the code from a single import regardless of the platform. Export conditions make this really easy as the code in the browser and server can be different and we basically rely on this behavior to import the right version. Making a deno export condition could assure the right version gets included.
Why are you messing with dom-expressions directly? Solid basically builds that into the library. Are you trying to build a version of HyperScript that works with SSR? Because currently, only JSX supports SSR, mostly that the output is not only different for the server but different for the client as well to allow for hydration.

I wanted todo something similar to deno's fresh which uses preact. I was under the assumption that SSR worked something like JSX -> hyper dom script -> html. But I guess CSR and SSR are just too different especially with the hydration step. Like if I understand it better it should not just be IS_BROWSER but also checks for is_hydrated and needs_hydration and stuff like that. Depending on where you are in the renderer.
Deno does support the conditional exports if you make your project a hybrid between node and deno.  If tested this and it sort of works but I thats not the deno DX I was hoping for. At any rate I do think there needs to be a way for deno to know when what part of the renderer is running where, otherwise you still have the problem that deno import just one behaviour when using conditional import.

Yeah generally we don't do JSX -> HyperScript. This way we can optimize the compiler for the platform, and we use export conditions to optimize the runtime for the platform. This happens all without flags or additional aliasing etc. We can configure a plugin for most bundlers and it just works.
I'm unclear how Deno would either mind you. But build step + export conditions make this trivial with existing tool chains. Not to mention our JSX transform not only offers better DX, performance, and size. I hope there is a way in the future to be able to fully leverage what we are doing here. I mean in general we aren't alone when you consider custom bundling and build required for all the cutting-edge frameworks especially those focused on hydration.
Fresh sort of got in a loop hole because their setup happened to be supported by Deno's tooling choice, but long term this is a very stifling position to take and will get in the way of innovation if they don't expand what they can do.

1.5.6 now has deno condition which is really all we can do right now.


Crash again

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
Why
Command Prompt/Terminal/Crash logs (if existing)
C:\hostedtoolcache\windows\haxe\4.2.5\x64\std/haxe/format/JsonParser.hx (Line 318)
C:\hostedtoolcache\windows\haxe\4.2.5\x64\std/haxe/format/JsonParser.hx (Line 96)
C:\hostedtoolcache\windows\haxe\4.2.5\x64\std/haxe/format/JsonParser.hx (Line 57)
StageData.hx (Line 91)
StageData.hx (Line 63)
Song.hx (Line 166)
FreeplayState.hx (Line 573)
flixel/FlxState.hx (Line 239)
flixel/FlxGame.hx (Line 749)
flixel/FlxGame.hx (Line 679)
flixel/FlxGame.hx (Line 552)
openfl/events/EventDispatcher.hx (Line 426)
openfl/display/DisplayObject.hx (Line 1398)

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
i dont know

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Nope.
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
No
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

missing stage JSON

Nevermind i fixed it


Import packages

Todo: fix the legacyPackages output; the specific intention is to use it to export tomolib.


[TOPI][Hexagon] Implement quantized depthwise conv2d

This PR adds implementation for quantized depthwise convolution op for hexagon. The quantization method uses fixed-point number to replace floating point instructions.
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @mehrdadh

@gayatripk1 please update the PR description

@gayatripk1 please update the PR description

Done.


add arm64 arch

Signed-off-by: Ray Harris<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/19870

/lgtm


[LOC] "ドキュメント" needs to be replaced with "Documents"

https://docs.microsoft.com/ja-jp/office/vba/api/publisher.application

Working on a fix: Bug 3290847


Need a wrapper for cairo_format_stride_for_width()

ImageSurface.create_for_data() calls cairo_image_surface_create_for_data(), and its stride parameter:

Needs to be aligned to 32 bits

Must have an absolute value greater than or equal to cairo_format_stride_for_width() for the corresponding image (negative strides are allowed for bottom-to-top images).

The only place I could find that actually figures out a stride is in examples/src/cairo-threads.rs, but that gets it from an existing image_surface.get_stride() - it doesn't create a buffer on its own.
So, for people who actually want to allocate their own buffers to pass to ImageSurface.create_for_data(), I think we need a wrapper for cairo_format_stride_for_width().

It'd make things simpler indeed.

This can be closed now that it's merged.


Quiz game

please assign me... i star this repo and i wanna add quiz game and 3D page

Please read the entirety of #269. Thank you.


[BUG] When dataset increases, NVTabular workflow causes to Dtype discrepancy.

When I increase the dataset duration from 28 days to 91days, I'm getting Dtype discrepancy.

Same code works with 28 days:

What would be the best way to troubleshoot this issue? Should I share pkl files for both workflow?

@ldane hello. do you mind to clarify When I increase the dataset duration from 28 days to 91days, I'm getting Dtype discrepancy.? is that error from TF4rec model training step or this error is from your NVT workflow? I asssume this is from NVT workflow. do you mind to share the entire error stack pls?
And yes, if you can share your workflow that gives you this error, and together with the parquet file of the day that gives you this error we can take a look. you can send it via email. thanks.

@rnyak, This is coming from NVT workflow. My training is completed successfully (NVTabular+T4Rec). After training, I'm getting this error while doing inference.
I'm loading the workflow and the dataset and doing a transform operation:

I'll look into individual parquet files and confirm that feed_date column has same dtype.
Is there anyway to figure out which parquet file causes me this exception? Maybe somehow I could increase the verbosity of logs generated by NVTabular?
I'm attaching some files, for your consideration.
ETL-code.ipynb.zip
workflow.pkl.zip
Full Stack:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[8], line 1
----> 1 user_profile.head(2)

File /usr/local/lib/python3.8/dist-packages/dask/dataframe/core.py:1256, in _Frame.head(self, n, npartitions, compute)
   1254 # No need to warn if we're already looking at all partitions
   1255 safe = npartitions != self.npartitions
-> 1256 return self._head(n=n, npartitions=npartitions, compute=compute, safe=safe)

File /usr/local/lib/python3.8/dist-packages/dask/dataframe/core.py:1290, in _Frame._head(self, n, npartitions, compute, safe)
   1285 result = new_dd_object(
   1286     graph, name, self._meta, [self.divisions[0], self.divisions[npartitions]]
   1287 )
   1289 if compute:
-> 1290     result = result.compute()
   1291 return result

File /usr/local/lib/python3.8/dist-packages/dask/base.py:315, in DaskMethodsMixin.compute(self, **kwargs)
    291 def compute(self, **kwargs):
    292     """Compute this dask collection
    293
    294     This turns a lazy Dask collection into its in-memory equivalent.
   (...)
    313     dask.base.compute
    314     """
--> 315     (result,) = compute(self, traverse=False, **kwargs)
    316     return result

File /usr/local/lib/python3.8/dist-packages/dask/base.py:598, in compute(traverse, optimize_graph, scheduler, get, *args, **kwargs)
    595     keys.append(x.__dask_keys__())
    596     postcomputes.append(x.__dask_postcompute__())
--> 598 results = schedule(dsk, keys, **kwargs)
    599 return repack([f(r, *a) for r, (f, a) in zip(results, postcomputes)])

File /usr/local/lib/python3.8/dist-packages/dask/local.py:557, in get_sync(dsk, keys, **kwargs)
    552 """A naive synchronous version of get_async
    553
    554 Can be useful for debugging.
    555 """
    556 kwargs.pop("num_workers", None)  # if num_workers present, remove it
--> 557 return get_async(
    558     synchronous_executor.submit,
    559     synchronous_executor._max_workers,
    560     dsk,
    561     keys,
    562     **kwargs,
    563 )

File /usr/local/lib/python3.8/dist-packages/dask/local.py:500, in get_async(submit, num_workers, dsk, result, cache, get_id, rerun_exceptions_locally, pack_exception, raise_exception, callbacks, dumps, loads, chunksize, **kwargs)
    498 while state["waiting"] or state["ready"] or state["running"]:
    499     fire_tasks(chunksize)
--> 500     for key, res_info, failed in queue_get(queue).result():
    501         if failed:
    502             exc, tb = loads(res_info)

File /usr/lib/python3.8/concurrent/futures/_base.py:437, in Future.result(self, timeout)
    435     raise CancelledError()
    436 elif self._state == FINISHED:
--> 437     return self.__get_result()
    439 self._condition.wait(timeout)
    441 if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:

File /usr/lib/python3.8/concurrent/futures/_base.py:389, in Future.__get_result(self)
    387 if self._exception:
    388     try:
--> 389         raise self._exception
    390     finally:
    391         # Break a reference cycle with the exception in self._exception
    392         self = None

File /usr/local/lib/python3.8/dist-packages/dask/local.py:542, in SynchronousExecutor.submit(self, fn, *args, **kwargs)
    540 fut = Future()
    541 try:
--> 542     fut.set_result(fn(*args, **kwargs))
    543 except BaseException as e:
    544     fut.set_exception(e)

File /usr/local/lib/python3.8/dist-packages/dask/local.py:238, in batch_execute_tasks(it)
    234 def batch_execute_tasks(it):
    235     """
    236     Batch computing of multiple tasks with `execute_task`
    237     """
--> 238     return [execute_task(*a) for a in it]

File /usr/local/lib/python3.8/dist-packages/dask/local.py:238, in <listcomp>(.0)
    234 def batch_execute_tasks(it):
    235     """
    236     Batch computing of multiple tasks with `execute_task`
    237     """
--> 238     return [execute_task(*a) for a in it]

File /usr/local/lib/python3.8/dist-packages/dask/local.py:229, in execute_task(key, task_info, dumps, loads, get_id, pack_exception)
    227     failed = False
    228 except BaseException as e:
--> 229     result = pack_exception(e, dumps)
    230     failed = True
    231 return key, result, failed

File /usr/local/lib/python3.8/dist-packages/dask/local.py:224, in execute_task(key, task_info, dumps, loads, get_id, pack_exception)
    222 try:
    223     task, data = loads(task_info)
--> 224     result = _execute_task(task, data)
    225     id = get_id()
    226     result = dumps((result, id))

File /usr/local/lib/python3.8/dist-packages/dask/core.py:119, in _execute_task(arg, cache, dsk)
    115     func, args = arg[0], arg[1:]
    116     # Note: Don't assign the subtask results to a variable. numpy detects
    117     # temporaries by their reference count and can execute certain
    118     # operations in-place.
--> 119     return func(*(_execute_task(a, cache) for a in args))
    120 elif not ishashable(arg):
    121     return arg

File /usr/local/lib/python3.8/dist-packages/dask/optimization.py:990, in SubgraphCallable.__call__(self, *args)
    988 if not len(args) == len(self.inkeys):
    989     raise ValueError("Expected %d args, got %d" % (len(self.inkeys), len(args)))
--> 990 return core.get(self.dsk, self.outkey, dict(zip(self.inkeys, args)))

File /usr/local/lib/python3.8/dist-packages/dask/core.py:149, in get(dsk, out, cache)
    147 for key in toposort(dsk):
    148     task = dsk[key]
--> 149     result = _execute_task(task, cache)
    150     cache[key] = result
    151 result = _execute_task(out, cache)

File /usr/local/lib/python3.8/dist-packages/dask/core.py:119, in _execute_task(arg, cache, dsk)
    115     func, args = arg[0], arg[1:]
    116     # Note: Don't assign the subtask results to a variable. numpy detects
    117     # temporaries by their reference count and can execute certain
    118     # operations in-place.
--> 119     return func(*(_execute_task(a, cache) for a in args))
    120 elif not ishashable(arg):
    121     return arg

File /usr/local/lib/python3.8/dist-packages/dask/utils.py:41, in apply(func, args, kwargs)
     39 def apply(func, args, kwargs=None):
     40     if kwargs:
---> 41         return func(*args, **kwargs)
     42     else:
     43         return func(*args)

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

    [... skipping similar frames: LocalExecutor._build_input_data at line 116 (1 times), LocalExecutor.transform at line 69 (1 times)]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:72, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     69 input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71 if node.op:
---> 72     transformed_data = self._transform_data(
     73         node, input_data, capture_dtypes=capture_dtypes
     74     )
     75 else:
     76     transformed_data = input_data

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:191, in LocalExecutor._transform_data(self, node, input_data, capture_dtypes)
    189         elif len(output_data):
    190             if output_col_schema.dtype != output_data_schema.dtype:
--> 191                 raise TypeError(
    192                     f"Dtype discrepancy detected for column {col_name}: "
    193                     f"operator {node.op.label} reported dtype "
    194                     f"`{output_col_schema.dtype}` but returned dtype "
    195                     f"`{output_data_schema.dtype}`."
    196                 )
    197 except Exception:
    198     LOG.exception("Failed to transform operator %s", node.op)

TypeError: Dtype discrepancy detected for column feed_date: operator SelectionOp reported dtype `object` but returned dtype `datetime64[s]`.

@rnyak, This is coming from NVT workflow. My training is completed successfully (NVTabular+T4Rec). After training, I'm getting this error while doing inference.
I'm loading the workflow and the dataset and doing a transform operation:
I'm using a pandas data frame. Is there anyway to figure out which row causes this exception? Maybe somehow I could increase the verbosity of logs generated by NVTabular?
I'm attaching some files, for your consideration.
ETL-code.ipynb.zip workflow.pkl.zip
Full Stack:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[8], line 1
----> 1 user_profile.head(2)

File /usr/local/lib/python3.8/dist-packages/dask/dataframe/core.py:1256, in _Frame.head(self, n, npartitions, compute)
   1254 # No need to warn if we're already looking at all partitions
   1255 safe = npartitions != self.npartitions
-> 1256 return self._head(n=n, npartitions=npartitions, compute=compute, safe=safe)

File /usr/local/lib/python3.8/dist-packages/dask/dataframe/core.py:1290, in _Frame._head(self, n, npartitions, compute, safe)
   1285 result = new_dd_object(
   1286     graph, name, self._meta, [self.divisions[0], self.divisions[npartitions]]
   1287 )
   1289 if compute:
-> 1290     result = result.compute()
   1291 return result

File /usr/local/lib/python3.8/dist-packages/dask/base.py:315, in DaskMethodsMixin.compute(self, **kwargs)
    291 def compute(self, **kwargs):
    292     """Compute this dask collection
    293
    294     This turns a lazy Dask collection into its in-memory equivalent.
   (...)
    313     dask.base.compute
    314     """
--> 315     (result,) = compute(self, traverse=False, **kwargs)
    316     return result

File /usr/local/lib/python3.8/dist-packages/dask/base.py:598, in compute(traverse, optimize_graph, scheduler, get, *args, **kwargs)
    595     keys.append(x.__dask_keys__())
    596     postcomputes.append(x.__dask_postcompute__())
--> 598 results = schedule(dsk, keys, **kwargs)
    599 return repack([f(r, *a) for r, (f, a) in zip(results, postcomputes)])

File /usr/local/lib/python3.8/dist-packages/dask/local.py:557, in get_sync(dsk, keys, **kwargs)
    552 """A naive synchronous version of get_async
    553
    554 Can be useful for debugging.
    555 """
    556 kwargs.pop("num_workers", None)  # if num_workers present, remove it
--> 557 return get_async(
    558     synchronous_executor.submit,
    559     synchronous_executor._max_workers,
    560     dsk,
    561     keys,
    562     **kwargs,
    563 )

File /usr/local/lib/python3.8/dist-packages/dask/local.py:500, in get_async(submit, num_workers, dsk, result, cache, get_id, rerun_exceptions_locally, pack_exception, raise_exception, callbacks, dumps, loads, chunksize, **kwargs)
    498 while state["waiting"] or state["ready"] or state["running"]:
    499     fire_tasks(chunksize)
--> 500     for key, res_info, failed in queue_get(queue).result():
    501         if failed:
    502             exc, tb = loads(res_info)

File /usr/lib/python3.8/concurrent/futures/_base.py:437, in Future.result(self, timeout)
    435     raise CancelledError()
    436 elif self._state == FINISHED:
--> 437     return self.__get_result()
    439 self._condition.wait(timeout)
    441 if self._state in [CANCELLED, CANCELLED_AND_NOTIFIED]:

File /usr/lib/python3.8/concurrent/futures/_base.py:389, in Future.__get_result(self)
    387 if self._exception:
    388     try:
--> 389         raise self._exception
    390     finally:
    391         # Break a reference cycle with the exception in self._exception
    392         self = None

File /usr/local/lib/python3.8/dist-packages/dask/local.py:542, in SynchronousExecutor.submit(self, fn, *args, **kwargs)
    540 fut = Future()
    541 try:
--> 542     fut.set_result(fn(*args, **kwargs))
    543 except BaseException as e:
    544     fut.set_exception(e)

File /usr/local/lib/python3.8/dist-packages/dask/local.py:238, in batch_execute_tasks(it)
    234 def batch_execute_tasks(it):
    235     """
    236     Batch computing of multiple tasks with `execute_task`
    237     """
--> 238     return [execute_task(*a) for a in it]

File /usr/local/lib/python3.8/dist-packages/dask/local.py:238, in <listcomp>(.0)
    234 def batch_execute_tasks(it):
    235     """
    236     Batch computing of multiple tasks with `execute_task`
    237     """
--> 238     return [execute_task(*a) for a in it]

File /usr/local/lib/python3.8/dist-packages/dask/local.py:229, in execute_task(key, task_info, dumps, loads, get_id, pack_exception)
    227     failed = False
    228 except BaseException as e:
--> 229     result = pack_exception(e, dumps)
    230     failed = True
    231 return key, result, failed

File /usr/local/lib/python3.8/dist-packages/dask/local.py:224, in execute_task(key, task_info, dumps, loads, get_id, pack_exception)
    222 try:
    223     task, data = loads(task_info)
--> 224     result = _execute_task(task, data)
    225     id = get_id()
    226     result = dumps((result, id))

File /usr/local/lib/python3.8/dist-packages/dask/core.py:119, in _execute_task(arg, cache, dsk)
    115     func, args = arg[0], arg[1:]
    116     # Note: Don't assign the subtask results to a variable. numpy detects
    117     # temporaries by their reference count and can execute certain
    118     # operations in-place.
--> 119     return func(*(_execute_task(a, cache) for a in args))
    120 elif not ishashable(arg):
    121     return arg

File /usr/local/lib/python3.8/dist-packages/dask/optimization.py:990, in SubgraphCallable.__call__(self, *args)
    988 if not len(args) == len(self.inkeys):
    989     raise ValueError("Expected %d args, got %d" % (len(self.inkeys), len(args)))
--> 990 return core.get(self.dsk, self.outkey, dict(zip(self.inkeys, args)))

File /usr/local/lib/python3.8/dist-packages/dask/core.py:149, in get(dsk, out, cache)
    147 for key in toposort(dsk):
    148     task = dsk[key]
--> 149     result = _execute_task(task, cache)
    150     cache[key] = result
    151 result = _execute_task(out, cache)

File /usr/local/lib/python3.8/dist-packages/dask/core.py:119, in _execute_task(arg, cache, dsk)
    115     func, args = arg[0], arg[1:]
    116     # Note: Don't assign the subtask results to a variable. numpy detects
    117     # temporaries by their reference count and can execute certain
    118     # operations in-place.
--> 119     return func(*(_execute_task(a, cache) for a in args))
    120 elif not ishashable(arg):
    121     return arg

File /usr/local/lib/python3.8/dist-packages/dask/utils.py:41, in apply(func, args, kwargs)
     39 def apply(func, args, kwargs=None):
     40     if kwargs:
---> 41         return func(*args, **kwargs)
     42     else:
     43         return func(*args)

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

    [... skipping similar frames: LocalExecutor._build_input_data at line 116 (1 times), LocalExecutor.transform at line 69 (1 times)]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:69, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     66 output_data = None
     68 for node in nodes:
---> 69     input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71     if node.op:
     72         transformed_data = self._transform_data(
     73             node, input_data, capture_dtypes=capture_dtypes
     74         )

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:116, in LocalExecutor._build_input_data(self, node, transformable, capture_dtypes)
    114 for parent in node.parents_with_dependencies:
    115     parent_output_cols = _get_unique(parent.output_schema.column_names)
--> 116     parent_data = self.transform(transformable, [parent], capture_dtypes=capture_dtypes)
    117     if input_data is None or not len(input_data):
    118         input_data = parent_data[parent_output_cols]

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:72, in LocalExecutor.transform(self, transformable, graph, output_dtypes, additional_columns, capture_dtypes)
     69 input_data = self._build_input_data(node, transformable, capture_dtypes=capture_dtypes)
     71 if node.op:
---> 72     transformed_data = self._transform_data(
     73         node, input_data, capture_dtypes=capture_dtypes
     74     )
     75 else:
     76     transformed_data = input_data

File /usr/local/lib/python3.8/dist-packages/merlin/dag/executors.py:191, in LocalExecutor._transform_data(self, node, input_data, capture_dtypes)
    189         elif len(output_data):
    190             if output_col_schema.dtype != output_data_schema.dtype:
--> 191                 raise TypeError(
    192                     f"Dtype discrepancy detected for column {col_name}: "
    193                     f"operator {node.op.label} reported dtype "
    194                     f"`{output_col_schema.dtype}` but returned dtype "
    195                     f"`{output_data_schema.dtype}`."
    196                 )
    197 except Exception:
    198     LOG.exception("Failed to transform operator %s", node.op)

TypeError: Dtype discrepancy detected for column feed_date: operator SelectionOp reported dtype `object` but returned dtype `datetime64[s]`.

@ldane we dont recommend to feed  a datetime datetime64[s]  dtype column as it is in NVT workflow. From your workflow code I see that you are trying to use feed_date column, which is a datetime dtype (please correct me if I misread this). We recommend to convert this feed_date datetime dtype to timestamp of int dtype at up front. as we do in this example. Please see cell  6. This way you will also avoid any potential issue if you want to serve your model with Triton. You might get error from Triton due to dtype datetime64[s] as well.
I see you have event_time_ts. Is that same with feed_date column? If yes you can use event_time_ts column. If not same, I'd recommend to convert feed_date to integer timestamp column and use that way. Hope that helps.

@rnyak I shouldn't be using feed_date column at all. It is there to keep track of the data partitions. If I was using any operations, I could understand it might be causing issues.
Are you saying even though I don't do any modifications, It is not advised to use SelectOperator with unsupported data types?
Is there any documentation that allows us to see which data types are supported by NVTabular and Triton?

There are two points here to be considered

your NVT workflow should be able to work as it is. You can feed datetime64[s] dtype column and return it from NVT workflow. You are already doing it with your train set. But the issue here is one of the files in your test dataset might be corrupted dtype and it is not datetime, but object (string). It is hard to tell which row because we cannot detect that from error stack. We dont have an arg or flag to increase the verbosity of logs generated by NVTabular. So as a workaround solution, if you could convert feed_date column to int timestamp and feed that column to NVT workflow, this might help with the error you are getting. Otherwise you need to find this corrupted file(s) and the row(s) in this file(s).
For Triton supported dtypes, I can share this doc for now, but I can gather more info and get back to you about datetime dtype.

hope that helps.
@karlhigley would you like to add something else?

@rnyak I'll explain it better. In this two cases (28 days vs 91 days), the test set is exactly same. There aren't multiple files. I'm using only one day worth of data to verify the inference is working. The data is retrieved and kept in memory as Pandas DataFrame. I verified all of rows for feed_date has exact same value. Therefore, feed_date isn't corrupted as you described.
Let's see if we can't find a way to figure out what is going on, before trying to solve this with workarounds.

@ldane thanks for extra info. Can you please confirm my understanding:

you use 28 days for train set, you fit the workflow (it works), and then you transform the test set (single file) and transforming the test set works too.
you use 91 days, you can fit the workflow (it works), but you cannot transform the test set, you get dtype error you mentioned above.

your ETL pipeline shows you read data (parquet files ) from path like that train_data = Dataset(f"{PIPELINE_ROOT}/2023-03-22/data/bq-export/*.parquet"). that's fine.
can you please print and share the train data dtypes, and sessions_gdf dtypes here? thanks.

28d train_data:

28d sessions_gdf:

91d train_data:

91d sessions_gdf:

@ldane thanks. your raw train data feed_date column is string it is not datetime.. I thought it is datetime object. it is strange that you are getting SelectionOp reported dtype object but returned dtype datetime64[s] error.

Is that what you are generating from BigQuery, i.e.,  string  dtype for feed_rate col for raw parquet files?
does your test set have feed_date as string dtype as well?
do you know if your dataset has any nulls? particularly if your feed_date column might have nulls/Nones/NaNs?

do you mind removing feed_date from your workflow pipeline and fit your workflow with 91 files and transform your test set again? let's see if the issue is really with feed_date column or not.

@rnyak Yes, the feed_date column in train data set is string. I'm generating that field as string from BigQuery. I see some on my test dataset, I'm using DATE data type. In the data frame, feed_date has dtype of dbdate.
I've just tried to cast feed_date into string and 91 days is also working. Now my question is, how is the 28days working with dbdate dtype and not causing the discrepancy? and How does the workflow for 91days verify the dtypes and fails?
This is the dtypes for test data:


General arithmetic propagators over views

Research:

View-based Propagator Derivation, Schulte and Tack, https://doi.org/10.1007/s10601-012-9133-z
See also, View-based propagation of decomposable constraints, Marco Correia and Pedro Barahona, https://doi.org/10.1007/s10601-013-9140-8

This is implemented in the lattice-land project, in the lala-ipc repository: https://github.com/lattice-land/lala-ipc


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 4a46754, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 6840 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 4b5a3bb.


[DSIP-28] Donnot scan whole project beans under classpath

Purpose of the pull request
close https://github.com/apache/dolphinscheduler/issues/15877
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
Attention: Patch coverage is 16.21622% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 39.53%.  Consider uploading reports for the commit 9cd3f14 to get more accurate results

Files
Patch %
Lines

...inscheduler/plugin/task/api/TaskPluginManager.java
0.00%
6 Missing :warning:

...n/registry/etcd/EtcdRegistryAutoConfiguration.java
0.00%
5 Missing :warning:

.../zookeeper/ZookeeperRegistryAutoConfiguration.java
0.00%
5 Missing :warning:

...er/api/service/impl/TaskDefinitionServiceImpl.java
40.00%
1 Missing and 2 partials :warning:

...api/service/impl/ProcessDefinitionServiceImpl.java
0.00%
2 Missing :warning:

...ver/master/runner/TaskExecutionContextFactory.java
0.00%
2 Missing :warning:

...lphinscheduler/api/dto/task/TaskUpdateRequest.java
0.00%
1 Missing :warning:

...r/api/service/impl/ProcessInstanceServiceImpl.java
0.00%
0 Missing and 1 partial :warning:

...e/dolphinscheduler/common/CommonConfiguration.java
0.00%
1 Missing :warning:

...e/dolphinscheduler/server/master/MasterServer.java
0.00%
1 Missing :warning:

... and 4 more

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15874      +/-   ##
============================================
+ Coverage     39.52%   39.53%   +0.01%
+ Complexity     5002     4994       -8
============================================
  Files          1348     1349       +1
  Lines         45674    45543     -131
  Branches       4896     4863      -33
============================================
- Hits          18053    18006      -47
+ Misses        25698    25619      -79
+ Partials       1923     1918       -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve usability of special functions

Resolve the problem like following:
>>> cupyx.scipy.special.gamma(1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/work/chainer/cupy/cupyx/scipy/special/gamma.py", line 41, in gamma

jenkins, test this please.

Jenkins CI test (for commit 28f9b66392397a5524f612e6a3f94bf736cfb6c1, target branch master) succeeded!

LGTM!


Adding helpers and bblfsh error management

First commit:
Renamed gitbase_constants to gitbase_queries and removed all the constants that were not queries. I did this because these other constants were not used by multiple files anymore, and the only reason we have this file is because it's better aesthetically, not as a global constants file.
Second commit:
Added language constant to utils, as well as one helper that create the logger, and one helper to handle tqdm stream. This way, when we log something while a tqdm progress bar is up, it will not be ugly. I also propagated the changes to the creaate_bow file.
Third commit
I added two new arguments to the preprocess command, the value of the timeout for babelfish, as well as the name of the docker container. Both are used to catch the timeout error we talked about. If we see it, then the docker instance is restarted, then after 10s we try to parse the file again. Hopefully we will soon have this, and will not have to care about this anymore.
In order to circumvent the OOM problem the client has (issue here I also added a custom function to replace the call to filter, which given a UAST will traverse it, and return a generator with all of the features. This works faster, and does not create mallocated items. While we don't get rid of the OOM problem entirely as the ResultContext is never deallocated, it is negligible in comparison. This led me to also move the constants used with Babelfish in the preprocess file.

I also wanted to know if you want me to exclude all version of a file if one of the blobs caused an error ?
Also, I've been able to process the Pytorch repository in  2h53min. I got these results:
Extracted features from 16739 distinct blobs.
Parsed successfully 94.506549 % blobs.
   C : 5314 blobs.
   Parsed successfully 94.960686 % blobs.
   C++ : 4468 blobs.
   Parsed successfully 88.827038 % blobs.
   Cuda : 2572 blobs.
   Parsed successfully 98.205422 % blobs.
   Python : 4135 blobs.
   Parsed successfully 98.195203 % blobs.
   Shell : 250 blobs.
   Parsed successfully 98.425197 % blobs.

It restarted the container 64 times the container, I think I saw multiple times the same files causing the problem.

Added a commit for a bug I introduced. Apparently % got to be escaped when used in help strings, or the formatter bugs.

I also wanted to know if you want me to exclude all version of a file if one of the blobs caused an error ?
With this I've been able to process the Pytorch repository in 2h53min. I got these results:
Extracted features from 16739 distinct blobs.
Parsed successfully 94.506549 % blobs.
   C : 5314 blobs.
   Parsed successfully 94.960686 % blobs.
   C++ : 4468 blobs.
   Parsed successfully 88.827038 % blobs.
   Cuda : 2572 blobs.
   Parsed successfully 98.205422 % blobs.
   Python : 4135 blobs.
   Parsed successfully 98.195203 % blobs.
   Shell : 250 blobs.
   Parsed successfully 98.425197 % blobs.

It restarted the container 64 times, I think I saw multiple times the same files causing the problem.

Missed this one in the review: seems to be a good idea. We might miss a few blobs but it should be a very small number, outweighed by the reduction in computaition time.

Okay, adding the feature then

@m09 added the changes, does it look good to you ?

Merging then !


Replaced League of Legends icon with a new one.

List any issues that this PR fixes:

none

This pull request proposes the following changes:

Replaces the old League of Legends icon with a new one. The old one is no longer used anywhere, while the new one has been extracted directly from the League of Legends executable.

Known issues/To do:

none

I don't know how I missed the new icon... Thanks!


gopkg.in pointing to older release

The latest release, v1.3.4, is tagged with 1.3.4. The missing v in front of the tag makes gopkg.in pointing to v1.3.3.
Please rename it to v1.3.4 or add such a tag so gopkg.in's version updates.

Fixed, thanks for the tip!


python311Packages.zamg: 0.3.3 -> 0.3.4

Diff: https://github.com/killer0071234/python-zamg/compare/refs/tags/v0.3.3...v0.3.4
Changelog: https://github.com/killer0071234/python-zamg/releases/tag/v0.3.4
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


tri incompatibility between Justleveling fork - nukecraft - better combat

crash straight to desktop when using both nukacraft (note: not there requirements) & better combat with you mod, I'm posting here because deleting     "MixTargetFinder",  from the mix-ins stops the crash & seems to allow for normal play (no long term testing)

Hi, can you check if this issue is fixed on version 1.1.7?


run owncloud legacy WebDAV & OCS API tests in CI

Part of #884
This is a sorted-out version of PR #901

Getting a silly composer error fetching the test dependencies. Maybe there is currently some packagist-composer problem upstream?
  [Composer\Downloader\TransportException]
  Content-Length mismatch, received 8426 bytes out of the expected 73683

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

make: *** [vendor-bin/behat/vendor] Error 1
Makefile:413: recipe for target 'vendor-bin/behat/vendor' failed

composer-packagist-behat dependency-loading problem in drone has gone away. CI passing:
https://cloud.drone.io/cs3org/reva/1692/4/6
394 scenarios (394 passed)

Very good - with this many regressions... can be detected in CI directly on reva PRs.


Basic usage of 'swagger generate spec'

Hi,
I tried to generate a swagger.json file with some annotations in my Go code but I do not find any concrete examples and I have always this result
> swagger generate spec -o ./swagger.json
{"swagger":"2.0","paths":null}

I tried those annotations from this document but it is not working properly or I do not know how to use them.
http://godoc.org/github.com/go-swagger/go-swagger/scan
Does an exemple of swagger generate spec exist ?

You can take a look here:
https://github.com/go-swagger/go-swagger/tree/master/fixtures/goparsing/petstore
there are a few more issues to work out with the generation of a server and client before I can work on the docs and provide proper examples.

I will take a look. Thanks !

http://go-swagger.github.io/generate/spec/


Log stack trace for file handling or node starting errors

Change summary:

Log stack trace for file handling errors
Log stack trace for the errors in starting blockchainn nodes

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/1309

Thanks for the review! @jiyoung-an Now merging..


python311Packages.seaborn: 0.13.0rc0 -> 0.13.0

Diff: https://github.com/mwaskom/seaborn/compare/refs/tags/v0.13.0rc0...v0.13.0
Changelog: https://github.com/mwaskom/seaborn/blob/master/doc/whatsnew/refs/tags/v0.13.0.rst
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266024 at f7c2f4f9 run on x86_64-linux 1

20 packages marked as broken and skipped:

python310Packages.graspologic
python310Packages.qiskit
python310Packages.qiskit-aer
python310Packages.qiskit-finance
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ignis
python310Packages.qiskit-machine-learning
python310Packages.qiskit-nature
python310Packages.qiskit-optimization
python310Packages.qiskit-terra
python311Packages.graspologic
python311Packages.qiskit
python311Packages.qiskit-aer
python311Packages.qiskit-finance
python311Packages.qiskit-ibmq-provider
python311Packages.qiskit-ignis
python311Packages.qiskit-machine-learning
python311Packages.qiskit-nature
python311Packages.qiskit-optimization
python311Packages.qiskit-terra

8 packages failed to build:

python310Packages.fuzzytm
python310Packages.hyppo
python310Packages.pyfume
python310Packages.simpful
python311Packages.fuzzytm
python311Packages.hyppo
python311Packages.pyfume
python311Packages.simpful

16 packages built successfully:

python310Packages.boxx
python310Packages.bpycv
python310Packages.n3fit
python310Packages.pycm
python310Packages.scikit-posthocs
python310Packages.seaborn
python310Packages.tsfresh
python310Packages.validphys2
python310Packages.zcs
python311Packages.n3fit
python311Packages.pycm
python311Packages.scikit-posthocs
python311Packages.seaborn
python311Packages.tsfresh
validphys2 (python311Packages.validphys2)
visidata

Result of nixpkgs-review pr 266024 at f7c2f4f9 run on x86_64-linux 1

20 packages marked as broken and skipped:

python310Packages.graspologic
python310Packages.qiskit
python310Packages.qiskit-aer
python310Packages.qiskit-finance
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ignis
python310Packages.qiskit-machine-learning
python310Packages.qiskit-nature
python310Packages.qiskit-optimization
python310Packages.qiskit-terra
python311Packages.graspologic
python311Packages.qiskit
python311Packages.qiskit-aer
python311Packages.qiskit-finance
python311Packages.qiskit-ibmq-provider
python311Packages.qiskit-ignis
python311Packages.qiskit-machine-learning
python311Packages.qiskit-nature
python311Packages.qiskit-optimization
python311Packages.qiskit-terra

2 packages failed to build:

python310Packages.hyppo
python311Packages.hyppo

22 packages built successfully:

python310Packages.boxx
python310Packages.bpycv
python310Packages.fuzzytm
python310Packages.n3fit
python310Packages.pycm
python310Packages.pyfume
python310Packages.scikit-posthocs
python310Packages.seaborn
python310Packages.simpful
python310Packages.tsfresh
python310Packages.validphys2
python310Packages.zcs
python311Packages.fuzzytm
python311Packages.n3fit
python311Packages.pycm
python311Packages.pyfume
python311Packages.scikit-posthocs
python311Packages.seaborn
python311Packages.simpful
python311Packages.tsfresh
validphys2 (python311Packages.validphys2)
visidata


[enhancement] : change accent color

Should be customizable rather than standard blue. Maybe from a selection of colors or overridable with an HEX value.

We strive for Keystatic to be a fully accessible application. By introducing consumer-chosen colours that becomes almost impossible. Sorry for the inconvenience but this is not something that we'll be exploring in the near future.


remove comment dom node

Version
3.0.0-beta.14
Reproduction link
https://jsbin.com/vucokaroxo/1/edit?html,output
Steps to reproduce
null and undefined will generate comment dom.

What is expected?
remove it
What is actually happening?
have comment dom

It might be expected
https://github.com/vuejs/vue/issues/5117#issuecomment-284927949

v-if is usually used for elements in a relatively stable node structure, rendering it to empty comment tags makes vnode lists diffing more efficient as the lists are more "stable", and it avoids some edge cases when elements are not keyed. In your case it doesn't seem to cause any real issue other than small inspection annoyance, so unfortunately I don't think we would change this behavior.

// https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/vnode.ts#L491-L493
if (child == null || typeof child === 'boolean') {
  // empty placeholder
  return createVNode(Comment)
} else if (isArray(child)) {

@lawvs .That is scene for v-if create comment.This issues really is inconsistent with 2.x.

This is intended. It doesn't affect visual output so there's no point to be "consistent" with 2.x.

I track this with 2.x.Find some inconsistent behavior with the blew.It's has a bit of weird.
      // ""
      return this.$createElement("div", [true]);
      // "true"
      return this.$createElement("div", true);

Too ugly, there will be many comment nodes on the DOM structure.

Your user doesn't inspect your DOM.

Your user doesn't inspect your DOM.

Some of them do.

This issue is long closed now, but comment DOM nodes to affect CSS pseudo-selectors like :first and can cause unexpected behavior and hurdles when styling, even if users aren't inspecting the DOM.

here I have a case
when the dom is a empty dom,  it show   -  ;
it often used in  a table, when the cell is empty ,  show  a  hyphen

I find it rather concerning that vue gives a meaning to DOM comments. Comments can cause various issues:

Mechanisms like MutationObserver will see them, so will need to perform useless extra iterations.
For SSR, perservation of HTML comments can not be guaranteed as minifying proxies like Cloudflare's will strip them.

Hi !
I asking if this comment doesn't affect DOM size when the navigator downloads the current page. In my case, on a complex page, I have more than 200 empty comments...
'Trob


Dashboard refreshes every 15s, should be more efficient way

See app/assets/javascripts/manage/lib/jquery.chartkickAutoReload.js for where the reload is happening.
Maybe there's a better way to refresh this data (i.e., event-driven).

Action Cable may be a good option: https://guides.rubyonrails.org/action_cable_overview.html

Moving to 3.0 as the UI is being overhauled.


Leaving "Enable Super GB Mode" enabled when switching to "Color Only" prevents build from running

When changing the color mode in the color options in settings to "color only", if the game previously had the "enable super gb mode" option enabled, the build may error out when attempting to run. This appears to only happen on the first instances of attempting to build following correction by the user.
To Reproduce
Steps to reproduce the behavior:

Create a new project in a pre-4.0 version of GB Studio.
Enable the "Enable Super GB Mode" option.
Open the project in the 4.0 beta release.
Change the color mode to "Color Only"
Attempt to run the game.
See error.

Expected behavior
Super GB options should not effect running of color only games. This error can be fixed by the user by switching back to a non-color only mode, disabling super gb mode, and then switching back. Restarting the program will not fix this error. Following the error being fixed, going back to enable super gb mode again does not replicate the initial issue.
Platform:

OS: Windows 11
App version: v4.0.0-beta1

Thanks for raising this issue, I've confirmed this is happening for me too and have implemented a fix in https://github.com/chrismaltby/gb-studio/commit/c65c1cc45aa28ba7103e32f2adabb9dce636217e which will become part of beta 3


Empty range in textDidChange not supported.

Hello. This document https://microsoft.github.io/language-server-protocol/specification#textDocument_didChange states that if range and rangeLength are omitted from a TextDocumentContentChangeEvent, the text is considered to be the full document.
However, your implementation does an assert that range is present here: https://github.com/microsoft/python-language-server/blob/master/src/LanguageServer/Impl/Implementation/Server.Documents.cs#L40
This seems like one of the main things preventing me from using this with this language client in vim: https://github.com/autozimu/LanguageClient-neovim

Thanks so much for the quick response. This fixed my problem, I can use it in vim now!


Build might fail

I've made some changes in the showcase which might cause the build to fail. I'll fix with a pr later today.

It´s in a "try/catch", so build will likely not fail, but the parsing may fail for jsdoc

Excellent, then I'm not too stressed 😂

yeah, no worries :D
see here the code snippet
https://github.com/ui5-community/bestofui5-data/blob/0f85430b4837d6de747b22485c06230224ec3a1d/src/gh-repos.ts#L53-L57


functions.R file missing

Hi there!
I was trying to implement some of the analyses you employed in your excellent publication, but I noticed some of the custom functions are in the functions.R, but this file is not in the repository. Could you please share it?
Thanks in advance!

Hi Cristian,
Thanks for letting me know - I just add it.
Best,
Roman
Cristian @.***> schrieb am Di. 30. Jan. 2024 um 12:45:

Hi there!
I was trying to implement some of the analyses you employed in your
excellent publication, but I noticed some of the custom functions are in
the functions.R, but this file is not in the repository. Could you please
share it?
Thanks in advance!
—
Reply to this email directly, view it on GitHub
https://github.com/rsankowski/sankowski_et_al_human_CAMs_code/issues/1,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC24SM6MOUNGIBK2JT272LDYRFEUNAVCNFSM6AAAAABCR2VAPOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDQNRTGIZTIMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you, @rsankowski, for the speedy reply and code uploading!


How to update badge in background?

Hey there,
Is there a way to update the badge icon when the app's in the background? The documentation is sparse, so it's difficult to tell..
Thanks!

@fabdrol : Did you find any solution for this? I am facing same issue

Hello !
To update in background, it's not an issue about this module. You need to use Firebase Cloud Messaging, to allow your app to handle messaging notification. With that, your app will be able to run background task, and it allows you to update the badge there.
Add this line to index.js
AppRegistry.registerHeadlessTask("RNFirebaseBackgroundMessage", () => MyBackgroundService);

MyBackgroundService.js
export default async (message) => {
    console.log("Received!", message);
}

You need to set up your android manifest and link correctly the module.
For more info :
https://firebase.google.com/docs/cloud-messaging/
https://rnfirebase.io/docs/v5.x.x/messaging/android
I let you mark as closed if you have no questions :)
Best regards,
Florient

@Linoa65 Will this work for iOS?
If you look at RN Firebases 6 documentation, Android highlights how it  offers Foreground Service Notifications for dealing with long-running background tasks but nothing is said about iOS.
I can see why @fabdrol would say that the documentation is sparse because hard to tell one and two apart.

There seems to be no way in RN Firebase to listen to incoming push notifications on iOS while the app is in the background or killed.


overflow due to dim resize using CByte instead of CInt

I am attempting to use this class in a VBA project to talk to Chrome/Edge via CDP and discovered that upon receiving a message larger than 256 bytes an error is thrown.  In cWebSocket.cls function GetMessageUTF8, 2nd to last line, the redim is attempting to convert the receive size to a byte which can cause an Overflow error to be thrown.  I believe this should be using CInt as the buffer itself is more than 256 bytes.
https://github.com/EagleAglow/vba-websocket-class/blob/c1447345287abee39a852f912ac2930edaf969c6/CWebSocket.cls#L554
I.e change
ReDim Preserve rgbBuffer(CByte(dwBytesTransferred))
to
ReDim Preserve rgbBuffer(CInt(dwBytesTransferred))
Thank you.

Changed. Also fixed similar line for rgbOther variable

Thank you.

  Also fixed the server, issue #2.  I hope you find this thing useful, but be prepared to be disappointed.  I'm not sure VBA is actually capable of making asynchronous websockets reliable.  Also, my VBA class writing is a bit iffy. 😊
From: Kenneth J Davis
Sent: Saturday, February 12, 2022 4:34 PM
To: EagleAglow/vba-websocket-class @.>
Cc: EagleAglow @.>; State change @.***>
Subject: Re: [EagleAglow/vba-websocket-class] overflow due to dim resize using CByte instead of CInt (Issue #1)
Thank you.
—
Reply to this email directly, view it on GitHub https://github.com/EagleAglow/vba-websocket-class/issues/1#issuecomment-1037614310 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQJ6I7QLZHP2PMKCZLNMXTDU2336HANCNFSM5OHWNE5A .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you modified the open/close state.Message ID: @.***>


Vectorize a single document

import pandas as pd

from relevanceai import DocumentVectorizer

df = pd.read_csv("pokemon.csv")
documents = df.to_dict(orient="records")

model = DocumentVectorizer()

new_doc = model.encode(documents[0], "type1")

new_docs = model.encode(documents, "type1")

supports all sentence transformer models


Update indicators-overview.md

Need add below point as "Note" so that we could avoid support tickets from users.
If indicators are synced to the Indicator in the MDE portal from MDCA sanctioned/unsanctioned applications, the 'Generate Alert' option will be enabled by default in the MDE portal. If you try to uncheck the 'Generate Alert' option in MDE, it will be re-enabled after some time as the MDCA policy will override it

@mchandran27 I'm moving these doc updates to our private repo, in this pull request: https://github.com/MicrosoftDocs/defender-docs-pr/pull/2145


Skip drawing MultiProgress if backing draw target is hidden

Fixes #602. @cvijdea-bd can you check whether this behaves as you expect?

Yep, seems like it doesn't crash with this commit. Thanks!


Device orientation incorrect for some devices

I ran into an issue with the plugin stating the wrong orientation for certain devices. I ended up using this code and it worked for all devices.
var activity = (Activity)Xamarin.Forms.Forms.Context;
return (activity.Resources.Configuration.Orientation.ToString() == "Landscape")? DeviceOrientations.Landscape : DeviceOrientations.Portrait;

The main devices I had issues with were Sony Xperia Tablets, specifically the Xperia Tablet Z.

@JoshuaNovak919  strange. The plugin uses the method described in this API guide


Calling PUT blueprint route with different data id than id in url crashes the server.

Hello!
Maybe i'm doing something wrong, but it seems like if I call PUT on localhost:1337/pet/6with this data:
{
  "name": "Fido",
  "createdAt": "2014-09-01T07:13:17.663Z",
  "updatedAt": "2014-09-01T07:13:17.663Z",
  "id": 7
}

The server crash with this error message:
warn: Unexpected output from `Pet.update`.
TypeError: Cannot read property 'id' of undefined
    at updated (/rootFolder/backend/node_modules/sails/lib/hooks/blueprints/actions/update.js:81:42)
    at bound (/rootFolder/backend/node_modules/lodash/dist/lodash.js:957:21)
    at applyInOriginalCtx (/rootFolder/backend/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:416:80)
    at wrappedCallback (/rootFolder/backend/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:315:18)
    at _normalizeCallback.callback.success (/rootFolder/backend/node_modules/sails/node_modules/waterline/node_modules/node-switchback/lib/normalize.js:33:31)
    at _switch (/rootFolder/backend/node_modules/sails/node_modules/waterline/node_modules/node-switchback/lib/factory.js:35:28)
    at /rootFolder/backend/node_modules/sails/node_modules/waterline/lib/waterline/query/dql/update.js:224:9
    at Object.async.each (/rootFolder/backend/node_modules/sails/node_modules/waterline/node_modules/async/lib/async.js:121:20)
    at /rootFolder/backend/node_modules/sails/node_modules/waterline/lib/waterline/query/dql/update.js:215:13
    at bound.updatedNestedAssociations (/rootFolder/backend/node_modules/sails/node_modules/waterline/lib/waterline/query/dql/update.js:252:12)

I'm using sails 0.10.5.
If I check in the database, the id is switched to the data id (7 in my example). I'm using mysql as the database if that changes anything?
Thanks

Confirmed this is still an issue in v0.11.x.  This has to do with the way sails-mysql does its "update" logic (possibly other adapters too).  Most logical solution to me is to disallow changing the primary key via blueprints--you should just drop/recreate the record if that's what you really need...

Same problem.
The error is very simple to target in the code:
var updatedRecord = records[0];

// If we have the pubsub hook, use the Model's publish method
  // to notify all subscribers about the update.
  if (req._sails.hooks.pubsub) {
    if (req.isSocket) { Model.subscribe(req, records); }
    Model.publishUpdate(pk, _.cloneDeep(values), !req.options.mirror && req, {
      previous: matchingRecord.toJSON()
    });
  }

var Q = Model.findOne(updatedRecord[Model.primaryKey]);

Simply, update did not updated anything, returned an empty array, updatedRecord is undefined, crash.
A simple if can save everythig.
Will you hear us?

@narf you've been heard (see https://github.com/balderdashy/sails/commit/94e3762431e936df95c4e547be54446b594388f6)
Starting with the next release, Sails will no longer allow you to change a record's primary key via the update blueprint.  It's just bad practice.


CASMCMS-7327: Add information on the flow of CFS sessions

Summary and Scope
This adds a new page and diagram for information on the components and steps involved in running CFS.  This information was requested by a customer.
Issues and Related PRs

Resolves CASMCMS-7327

Testing
Tested on:

NA docs only

Test description:
NA, docs only
Risks and Mitigations
None
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable
[X] HPC Product Announcement prepared, if applicable

/backport release/1.2 release/1.0


exa not installed ? Alias not working?

Just in case someone else, like me (Linux newb) has trouble with installing exa in WSL2 Ubuntu 20.04 LTS.
If you get this when trying to install
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package exa

Do this
wget http://archive.ubuntu.com/ubuntu/pool/universe/r/rust-exa/exa_0.9.0-4_amd64.deb
sudo apt-get install ./exa_0.9.0-4_amd64.deb

I found this solution here: https://askubuntu.com/a/1290552

Remove the annoying text, when exa isn't installed.


errorCode values

What are the available options for errorCode?

If you just set errorCode, the message for the error code is automatically retrieved from the server and displayed in the error dialog. If you specify an invalid errorCode value, an error dialog with a default error message is displyed.

Doesn't have to be on this page, but would be nice to at least have a link in the "Related Topics" section

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ea3c9c94-1f26-c3a4-8789-3b0cef9f1e6b
Version Independent ID: fe0311f8-20c5-5ddb-a618-2ead070afb80
Content: openErrorDialog (Client API reference) in model-driven apps - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/Xrm-Navigation/openErrorDialog.md
Service: powerapps
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

@jason-russell
Thanks for contacting us. We have updated the docs and pushed it live. Closing the issue. If you need further help, please reopen the issue or open a new issue.


Update of Policy definition to reflect:

removal of support value 0 (zero) of link-bandwidth
use of TRANS_ASN as unifid ASN of LBw
relaxed validation fo ASN in LBw ext-community

Pull Request Functional Test Report for #3151 / 24676f5c6171cff543ad13a6ee63371fee2992a8
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
9196564a
Log

Cisco 8000E

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
b57b864d
Log

Cisco XRd

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
fbbce8af
Log

Juniper ncPTX

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
7482cb87
Log

Nokia SR Linux

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
78997118
Log

Openconfig Lemming

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community
ca1e0844
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Cisco 8808

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Juniper PTX10008

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Nokia 7250 IXR-10e

RT-7.5: BGP Policy - Match and Set Link Bandwidth Community

Help


[suggestion] Reset button for the conversation

It would be nice to have a reset button in the chatbot window, just like botfront's ui. That would allow for a user to start a new conversation when session persistence is enabled.

附议


Upgrade org.json Dep, change maven URL to https

In this version:

org.json.json dependency has been upgraded to 20200518
the maven repo URL has been changed to be https instead of http, which the repo now requires

Changed to appropriate branch


Fix Node 12 support

Fixes #261

Should we include the lib line from here: https://github.com/tsconfig/bases/blob/0b8b889fcdada73bf3e6900bf6f74fc9d8d21b43/bases/node12.json?rgh-link-date=2022-02-25T14%3A12%3A58Z#L6?

Should we include the lib line from here: https://github.com/tsconfig/bases/blob/0b8b889fcdada73bf3e6900bf6f74fc9d8d21b43/bases/node12.json?rgh-link-date=2022-02-25T14%3A12%3A58Z#L6?

I don't think there's any harm.


Update gromacs tutorial after changes to tools

Update after https://github.com/galaxycomputationalchemistry/galaxy-tools-compchem/pull/35.
Also a small correction to the protein-ligand docking tutorial added on Friday.

Whoops. :/


How use Univoice with Fish-Net

Hi! I've been trying use Univoice with Fish-Net in my multiplayer project, but i can't implement it. Do you know how i can make this work?

in a month FishNet support should be out.

Any updates on this?


Upgrade Apache BookKeeper Client to 4.11.1

Motivation
Upgrade Apache BookKeeper client to version 4.11.1
Modifications
Upgrade Apache BookKeeper client, fix a few build errors, due to the introduction of BookieServiceInfo structure (see BP-38).
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes)
The public API: ( no)
The schema: (no )
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why? it is only a dependency upgrade, no new BK features enabled with this change
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

This is only a Draft, because BK 4.11.1 still is not released, but the API is the same as BK 4.11.0, it will be better to merge this patch after BK 4.11.1 is released

/pulsarbot run-failure-checks

some CI jobs failed with this error, it looks like a temporary error

Error:  Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.3.0:add-source (default) on project flink: Execution default of goal net.alchim31.maven:scala-maven-plugin:4.3.0:add-source failed: Plugin net.alchim31.maven:scala-maven-plugin:4.3.0 or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.apache.maven:maven-builder-support:jar:3.3.9, org.apache.maven:maven-artifact:jar:3.3.9: Could not transfer artifact org.apache.maven:maven-builder-support:jar:3.3.9 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/maven-builder-support/3.3.9/maven-builder-support-3.3.9.jar: Connection timed out (Read failed) -> [Help 1]

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

I have to fix LICENSE stuff.

/pulsarbot run-failure-checks

@eolivelli Thanks for the fix. there a license check failed. and would you please also help update this pr with latest master code?
https://github.com/apache/pulsar/pull/8270/checks?check_run_id=1285693542
Run src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
src/check-binary-license: line 61: echo: write error: Broken pipe
jakarta.activation-jakarta.activation-api-1.2.1.jar unaccounted for in LICENSE
jakarta.xml.bind-jakarta.xml.bind-api-2.3.2.jar unaccounted for in LICENSE
jakarta.activation-jakarta.activation-api-1.2.2.jar mentioned in LICENSE, but not bundled
com.sun.activation-jakarta.activation-1.2.2.jar mentioned in LICENSE, but not bundled
jakarta.xml.bind-jakarta.xml.bind-api-2.3.3.jar mentioned in LICENSE, but not bundled
jetty-alpn-java-client-9.4.27.v20200227.jar mentioned in lib/presto/LICENSE, but not bundled
jakarta.activation-1.2.2.jar mentioned in lib/presto/LICENSE, but not bundled
jakarta.activation-api-1.2.2.jar mentioned in lib/presto/LICENSE, but not bundled
jakarta.xml.bind-api-2.3.3.jar mentioned in lib/presto/LICENSE, but not bundled

It looks like there are issues with the LICENSE/NOTICE.
Error: Process completed with exit code 2.

thank you @jiazhai
my plan is to commit https://github.com/apache/pulsar/pull/8360 before this one.
Also in that PR I have a problem with license check,
locally the script is passing on my machine, but it fails on CI
this is very weird

@jiazhai I have fixed the conflict on Presto Distribution license

This error is very nasty, investigating now.
It is probably due to some dependency imported from the new BK client
Error:  Tests run: 11, Failures: 1, Errors: 0, Skipped: 10, Time elapsed: 4.263 s <<< FAILURE! - in org.apache.pulsar.client.TlsProducerConsumerTest
Error:  setup(org.apache.pulsar.client.TlsProducerConsumerTest)  Time elapsed: 4.166 s  <<< FAILURE!
java.lang.NoSuchFieldError: xmss_with_SHA256
	at java.security.AccessController.doPrivileged(Native Method)
	at java.lang.Class.newInstance(Class.java:442)
	at org.apache.pulsar.common.util.SecurityUtility.getBCProviderFromClassPath(SecurityUtility.java:125)
	at org.apache.pulsar.common.util.SecurityUtility.getProvider(SecurityUtility.java:102)
	at org.apache.pulsar.common.util.SecurityUtility.<clinit>(SecurityUtility.java:69)
	at org.apache.pulsar.broker.web.WebService.<init>(WebService.java:114)
	at org.apache.pulsar.broker.PulsarService.start(PulsarService.java:479)
	at org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.startBroker(MockedPulsarServiceBaseTest.java:269)
	at org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest.startBroker(MockedPulsarServiceBaseTest.java:251)

/pulsarbot run-failure-checks

The problem was about the fact that now BookKeeper imports a dependency from BouncyCastle and this pollutes the complex handling of BC in Pulsar

/pulsarbot run-failure-checks


Workshop work

r @Raynos @kriskowal
Makes it so that:

can pass a specific IDL file directly to tcurl, rather than relying on dubious directory + matching service name convention
can pass a hostlist instead of peer (uses only single peer at present from said hostlist)

:+1:

lgtm.


[1.3] Add a new cluster to measure distance

Reproduction steps
Hello, I'm trying to add a new cluster to measure distance, I'm following these steps here: https://developers.home.google.com/matter/extensions/sample-cluster
I noticed that there are steps missing in this tutorial, such as adding the new cluster in zaptool (I already managed to do this)

However, after building I noticed that the new cluster is not listed as an available cluster, does anyone know what is missing?

(If you need it I can share my patch)
Thanks a lot!
Bug prevalence
NA
GitHub hash of the SDK that was being used
NA
Platform
esp32
Platform Version(s)
esp-matter v5.2.1
Type
Common Cluster Logic
Anything else?
No response

@igorcoroli Presumably you added XML for the new cluster, right?  Did you then rerun codegen to regenerate chip-tool bits?


[CLOSED] Allow never published manual documents to be deleted through the UI

 Issue by kalleth
Tuesday 07 October 2014 at 14:18 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/274

Opened for discussion. TODO:

[ ] Unpendingize cucumber tests (I thought I'd done them. Guess not).

I figure it's worth having the wider discussion about wether we want to do this and what protections we want to add round this before going any further.
Add a delete button which only displays for Manual Documents that have never been published.
This also guards against deletion of published documents, showing a flash message if so. However, the button isn't shown in this case so that error shouldn't be encountered.
This will delete the manual document entirely -- without confirmation at the moment. Attempting to use 'confirm: true' on a button asks for confirmation but doesn't continue if the user chooses OK -- also alerts twice. The rails ujs isn't attaching properly or it'd work.

kalleth included the following code: https://github.com/alphagov/specialist-publisher/pull/274/commits

 Comment by evilstreak
Wednesday 08 October 2014 at 10:48 GMT

I wonder if we might be better off with a "discard draft" approach, which just gets rid of the latest draft (and the whole thing if it's the only edition).
We need to do the work to remove even a previously published section from a manual, so we should talk about what that would involve too.

 Comment by evilstreak
Thursday 09 October 2014 at 09:55 GMT

Closing this for now.


 Legacy-style Gamerule Names and Descriptions

NOTE: Not a pull request because I don't know how you want to implement this.
This lang file changes all Game Rules to use Legacy Console-style names and gives every one a unique description. Some descriptions were pulled straight from PS4 Edition, but Java-exclusive game rules have been given new descriptions in the same style.
en_us.json

Thanks for the lang file and sorry for bothering you, but there are some repeated keys in the lang, which is not a real problem because I know what the real keys are.

Apologies for those repeated keys. They affected the sendCommandFeedback and showDeathMessages gamerule descriptions.

Here is a fixed version of the file. Repeated keys fixed
en_us.json
and some slight description changes to better match the Legacy style.


matrix-synapse: 1.65.0 -> 1.66.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 189115 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

3 packages built:

matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
matrix-synapse-plugins.matrix-synapse-shared-secret-auth


can i create an EOL farm using the mod like i have the mod installed on the server so can i make a light suppressor in 1.20.1? for EOL farm?

can i create an EOL farm using the mod like i have the mod installed on the server so can i make a light suppressor in 1.20.1? for EOL farm?

With this mod, you can't. The "Disable Light Recalculation DataFixer" option only allows you to convert existing worlds with EOL farms to 1.20 without them being broken. I think there's an option in Carpet TIS to suppress light updates

but mobs dont spawn on portal blocks,so by any chance do u know any mod that reverses the change?


FIX slowness when adding user to workspace

Context
On French administration we can experience instances not beeing able to add users to workspaces due to long queries, and never ending queries.
Proposed solution
https://github.com/gristlabs/grist-core/commit/e26673eff10e93f7383f09886affdd999a2ecde4
To fix this issue we propose the same strategy than in #824.
Splitting the query in to simpler queries to gather informations about workspace and organization.
https://github.com/gristlabs/grist-core/commit/bd43d12110c3ae33fa793b1d658e1a5c630a186a
We also propose to remove the promisyfyAll around iteration of getUsers queries.
During local test, it seems to be the main culprit.
The ForEach iteration launches asynchonously many queries recycling the same transaction. Sometime the transaction never ended.
https://github.com/gristlabs/grist-core/commit/3c6388cb165fe79dbff57454caf2014247bfb53e
Cause the newly added function getExistingUsersByLogin uses a WHERE on logins.email a INDEX is added to allow fastest queries.
Related issues
FIXES #1005
Has this been tested?

[ ] 👍 yes, I added tests to the test suite
[ ] 💭 no, because this PR is a draft and still needs work
[x] 🙅 no, because this is not relevant here
[ ] 🙋 no, because I need help

Hmm, there seem to exist tests that don't pass and that may be related to your changes: https://github.com/gristlabs/grist-core/actions/runs/11103855934/job/30846705667?pr=1205#step:17:2848
Can you fix it? Or provide feedback and tell us whether these are just instabilities? (in such case, it would be more convenient to have tests that pass in the CI)

Can you rebase and try again. I can see other PRs are passing now.

@hexaltation I see some access tests are failing, I think this is caused by this PR, but if it isn't or you have some problems in fixing them, let me know.

@hexaltation I see some access tests are failing, I think this is caused by this PR, but if it isn't or you have some problems in fixing them, let me know.

Hello @berhalak,
I'm trying to fixing it.
Corrections made last week only fix half of failing tests.
I hope to have made all corrections this afternoon.

Hello @berhalak,
All tests are now passing. :)

Hello @berhalak,
All tests are now passing. :)

Hi @hexaltation,
Yes, all looks good. Consider this accepted, we just need to carefully schedule merging this one as it contains migration.

Hello @paulfitz,
A patch is submitted in #1279


Added the data prepper 1.2.1 performance testing blog post

Signed-off-by: Steven Bayer<EMAIL_ADDRESS>Description
Added the data prepper 1.2.1 performance testing blog post
Issues Resolved
n/a
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@sbayer55 hey this looks like a pretty good post! I don't see an issue for this though - not sure how to prioritize. Would you mind putting in a new blog issue so we can put it in context with the rest of the blog posts?

@stockholmux thanks for the feedback. I opened a github issue #645

Skimmed the blog post, is there a reason you didn't compare the throughput with things like vector, fluentd, fluentbit, or OpenTelemetry collector? Comparing against Logstash is somewhat legacy in nature...

@jkowall - I don't want to speak for @sbayer55, but I'm guessing the Logstash comparison is made because in this context it's a drop-in replacement.
Although a head-to-head with the other packages that fill this niche would be very interesting 🤔


llext: cache section headers

The llext_load() and llext_link() functions need to access section header data from the ELF file quite often, but this is currently done by seeking and reading each section header whenever it becomes necessary (even lots of times for the same section, in the case of symbols).
This PR reworks the current code by loading the whole section table in memory and accessing the array elements directly in the code. The memory for the section headers is freed at the end of the llext_load() function. If llext_peek() is supported, no allocation is performed and the data is fetched directly from the ELF file buffer.

The first commit is cosmetic, and restores some debug messages which were lost in the split-file refactor.
The second commit in the series refactors the code freeing memory at the end of llext_load() so that it's clearer and more explicit. As an improvement, the symbol table is kept in memory in debug builds to ease debugging.
The third commit adds the code that loads this section header array and frees it (or uses it directly from the ELF file buffer if available).
The last commit is a pure refactor that introduces no logic changes, but removes all code reading section headers and replaces it with the array indexing.

Unrelated to this PR, but this caught my attention while reviewing:
https://github.com/zephyrproject-rtos/zephyr/blob/dfb240f37ced92b5f487179dba6c93bc8f6c04e6/subsys/llext/llext.c#L160-L173
unsigned int ret is used as returned value for int function... is that OK?

v2:

added a lot more comments to the file header and in the code to explain the error management policy
moved the cleanup code directly inside llext_load()
fixed the memory leak for the symbol table on error spotted by @lyakh


NH-30870 calculate_attributes adds existing attrs earlier

Bugfix: custom sampler's calculate_attributes now adds existing attributes earlier. This is important for scenarios where the customer uses the SDK to start spans with custom attributes, e.g.
  with tracer.start_as_current_span(
      "manual_instrumentation_django_a",
      attributes={"foo-django-a": "bar-django-a"},
  ):
    # do stuff

Example trace with this fix: https://my.na-01.st-ssp.solarwinds.com/136444677275740160/traces/6D23EB224226CC4A59FA70D95C0BB1BE/892E8BFFDE370C5D/details/789BCA3EB9F3A9A0/rawData which was created using this WIP testbed update: https://github.com/appoptics/solarwinds-apm-python-testbed/pull/45
Add a unit tests. All are passing.

Hi again @cheempz ! Thank you for pointing out my wording of sw.w3c.tracestate instead of sw.tracestate_parent_id -- yikes!
As we chatted, the logic was still correct in that sw.tracestate_parent_id is set as the parent span ID if it exists. I've enhanced some unit tests in b52a857, and updated comment and changelog in 9585d5c and 5b99a1c. Also adjusted logging in f4344a3.
Please let me know what you think this time!


Add AWS Glue adapter to trusted list

Link to adapter repo
https://github.com/aws-samples/dbt-glue
Contact Details
<EMAIL_ADDRESS>Which of these best describes you?
I work for the vendor on top of which the dbt adapter functions
Please agree to the each of the following

[X] I am a maintainer of the adapter being submited for Trusted status
[X] I have read both the Trusted adapters and Building a Trusted Adapter pages.
[X] I believe that the adapter currently meets the expectations given above
[X] I will ensure this adapter stays in compliance with the guidelines
[X] I understand that dbt Labs reserves the right to remove an adapter from the trusted adapter list at any time, should any of the below guidelines not be met

What icon should be used?

discussed offline with @mehdimld and @menuetb -- we're going to hold off on adding to Trusted, until there's CI against the dbt-adapter-test suite that shows the adapter is in working order

Thanks for your advise, we have added CI and resolved https://github.com/aws-samples/dbt-glue/issues/240.
Can we move forward?


Updating events page and adding a banner for the conference

Events page
Updated with the date for the next lean coffee.

Banner for the conference
Copy: Cross Government Software Engineering Conference 2025
CTA: Register your interest
Linking to: https://uk-x-gov-software-community.github.io/conference-2025-01-29/

You think we should mention in person in the banner and drop the image ?


Adding the documentation of human pose estimation drone control project in the English docs of Git book

@hany606, thanks for the contribution!
Please, check and fix the markdownlint warnings: https://travis-ci.org/CopterExpress/clever/jobs/564002537#L545.
Also, can you please consider reducing the size of the file human_pose_estimation_project_poses.jpg, 755Kb seems too big.

Please, check and fix the markdownlint warnings: https://travis-ci.org/CopterExpress/clever/jobs/564002537#L545.
Also, can you please consider reducing the size of the file human_pose_estimation_project_poses.jpg, 755Kb seems too big.

The warnings have been solved now, and the size of the image has been reduced to 179kB


ADD: use crypto-js instead of node's crypto to support mobile development such as react-native

xchain-crypto and some other packages are using the crypto package from node. To make xchainjs also usable for react native I suggest using crypto-js instead of crypto.

@severinwullschleger any chance you can point to a public repo that demonstrates the error? we just refactored a few things to better support running in nodejs, would like to include react-natove but want to better understand the issue

Hi @mikewyszinski
For react-native it is suboptimal when node packages like "crypto" are used. If xchainjs should be cross platform one should focus on not using the sub-packages of node. instead we should use packages like crypto-js which do not require node. I realized that it is a relativally big task to do so. Therefore not sure if it makes sense to do that now.
@JonnyBurger do you have something to add here?
we were now able to use xchainjs on react native with a few patches and resolver adjustments. See here https://github.com/THORWallet/thorwallet-react-native/blob/master/metro.config.js


Fix regression in QueryStringEncoder

Motivation:
Commit d675febf07d14d4dff82471829f974369705655a introduced a regression in QueryStringEncoder, resulting in whitespace being converted into a literal + sign instead of %20.
Modification:
Modify encodeComponent to pattern match and replace on the result of the call to URLEncoder#encode
Result:
Fixes regression

@blucas LGTM... will pull in soon

Cherry-picked into 4.1 (dcd322dda2dfd1e0567017d2e02c53728c310032) and 4.0 (9627cdd0297cb3faabde5b340902ca258fb5ffb7)


Remove Dataset.serialize?

Is Dataset.serialize() being used for anything? https://github.com/voxel51/fiftyone/blob/e9b8d728d7637eeef08ad0809906a6102f8cb75e/fiftyone/core/dataset.py#L414-L420
I find it confusing because it does not serialize the dataset, it just returns metadata (currently only the name).
This is becoming especially confusing given https://github.com/voxel51/fiftyone/pull/121, which introduces a Dataset.to_dict() method that actually serializes the entire dataset.

This has been renamed to _serialize()


[TypeSpec Requirement] Add path-based suppression expiration mechanism

Compare path to regex /(preview|stable)/[A-Za-z0-9_-]+/

If match, suppression is targeting a signle version, and is allowed
Else, suppression is too broad, print error message and fail check

# Allowed
- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json

# Disallowed
- tool: TypeSpecRequirement
  path: data-plane/**/*.json

May require addition of paths array to simplify multi-version suppressions:

- tool: TypeSpecRequirement
  paths:
  - data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json
  - data-plane/Azure.Contoso.WidgetManager/preview/2023-11-01-preview/**/*.json
  - data-plane/Azure.Contoso.WidgetManager/preview/2024-11-01-preview/**/*.json
  reason: Same reason for all versions

This is equivalent and would also be an allowed alternative:
- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2022-11-01-preview/**/*.json
  reason: Same reason for all versions

- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2023-11-01-preview/**/*.json
  reason: Same reason for all versions

- tool: TypeSpecRequirement
  path: data-plane/Azure.Contoso.WidgetManager/preview/2024-11-01-preview/**/*.json
  reason: Same reason for all versions

This builds on:

https://github.com/Azure/azure-rest-api-specs/issues/27348


Version wording needs padding to the right

All pages
The version wording runs all the way flush to the right. It needs some padding to make it look better.

Solved by PR #768


2022.05a Iteration Plan

SAP teams plan to work on the following issues in our next iteration:

Close PR #354

The iteration lasts 2 weeks and ends on May 23, 2022.

Iteration Results
Closed
Open

Close PR #354


Revert pairing changes

Reverting #3753 and #3800.
Something in #3753 breaks the pairing as per https://github.com/gnosis/safe-ios/issues/2304.
#3800 had to be reverted too because otherwise there are a lot of git conflicts when reverting 3753 alone.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 81 (23.46%)  changed or added relevant lines in 9 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 35.33%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/logic/wallets/pairing/hooks/usePairing.ts
0
3
0.0%

src/components/AppLayout/Header/components/ProviderDetails/PairingDetails.tsx
0
4
0.0%

src/logic/wallets/pairing/utils.ts
3
7
42.86%

src/logic/wallets/pairing/module.ts
1
7
14.29%

src/logic/wallets/pairing/hooks/useGetPairingUri.ts
0
7
0.0%

src/logic/wallets/walletConnect/module.ts
4
11
36.36%

src/logic/wallets/walletConnect/utils.ts
2
16
12.5%

src/logic/wallets/patchedWalletConnect.ts
5
22
22.73%

Files with Coverage Reduction
New Missed Lines
%

src/logic/wallets/pairing/module.ts
2
61.54%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
3595

Relevant Lines:
9236

💛  - Coveralls

Verified: there is no problem with QR code for pairing with the mobile app
@francovenica , could you check Trezor connection?


Use docker 18.09.0-ce-tp6

Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package. Addresses #166

Successfully used to build 72.0.3590.0

awesome job @mikenz! can't wait :)

@adieuadieu Any chance you can merge this so the automated builds start working again?
Thanks

@skunkworker yes. If @adieuadieu is interested in restoring the automated builds I'll happily update the PR.

@adieuadieu , please can you have a look at this PR? @mikenz has done really amazing work.

Hi @mikenz. I'm late to the party.
I'm a little worried about the maintainability of the hard-coded docker value here. (The irony—or is it hypocrisy—of that statement is not lost on me..)
Is the root issue here that the docker package contained in yum's repository is outdated, hence the manual install? Would this also be resolved by using a newer version of ubuntu on the EC2 instance?

@mikenz I should also add, thank you for your efforts and raising this PR.

So without some changes Chrome 78 and above won't build on the older environment as it stands right now. Though I do have a fork that builds using amazonlinux:2.0.20191016.0-with-sources.  @adieuadieu is that something that I should create a PR for?

@skunkworker please do create a PR, even if it isn't merged, the rest of the community would benefit from it.

@AgDude I've created an PR https://github.com/adieuadieu/serverless-chrome/pull/257
I know it works for sure with Chrome 75 but I haven't touched it in a couple months, I did update all of the dependencies though in order to get it build.

@AgDude I got chrome 81 built with a more up-to-date branch today. https://github.com/adieuadieu/serverless-chrome/pull/258


plugin built from source is incompatible

I built the plugin with bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest and then tried to install ijwb_bazel.zip to Android Studio 3.0.1 but it gives an error: Plugin 'Bazel' is incompatible with this installation. I also tried with Studio 3.2 C11.
Git hash I'm building: b0ed3e65ccac1b61640114ce19cf25faaf92cd6d.

--define=ij_product=intellij-latest

You want --define=ij_product=android-studio-latest.

Ran bazel build //ijwb:ijwb_bazel_zip --define=ij_product=android-studio-latest and got error:
ERROR: /Users/sheldon.neuberger/Snapchat/Dev/intellij/third_party/scala/BUILD:10:15: Configurable attribute "exports" doesn't match this configuration: define an intellij product version, e.g. --define=ij_product=intellij-latest
ERROR: Analysis of target '//ijwb:ijwb_bazel_zip' failed; build aborted:

/Users/sheldon.neuberger/Snapchat/Dev/intellij/third_party/scala/BUILD:10:15: Configurable attribute "exports" doesn't match this configuration: define an intellij product version, e.g. --define=ij_product=intellij-latest
INFO: Elapsed time: 0.163s
FAILED: Build did NOT complete successfully (0 packages loaded)


Fix: PHP web app improvements

This addresses some of the concerns of #2342
This is quite untested, so help is appreciated.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.435%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
451

Relevant Lines:
575

💛  - Coveralls

Not feasible approach, closing.