AI Hounds Tooth Title - crashes game on nashtah pup launch

** Fly Casual Release Version**
Version 2.5 - 2.5.20240223.03
Describe the bug
When AI Yv-666 with Hound's Tooth title dies and nashtah pup should launch. Game hangs.
To Reproduce
Pick YV-666,
Select title - Hound Tooth
Add additional ship - Nashtah Pup.
Play game against this list with AI
When you destroy YV-666 game hangs.
Expected behavior
Nashtah Pup should launch front or rear then YV-666 is removed.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform/Device (please complete the following information):
Windows 11
Additional context
Had this problem for quite a few versions now

Quick note, this happens with a docked shuttle in the VCX and the escape craft with Landos Millennium Falcon.
My workaround is to modify the custom ai saves and remove the title.

Can you confirm it crashes? I'm testing this and not getting a crash (which usually has an error), instead it just doesn't continue at all. It appears that it's supposed to be removing the previous ship and returning control to the game but that's not happening.

You're right, the game doesn't crash. No further actions within the game are available.
I've tried to enter debug and continue on event but it will not finish and allow you to continue

Software stops responding = crash
On Sun, 6 Oct 2024 at 17:01, Jeremy S. @.***> wrote:

Can you confirm it crashes? I'm testing this and not getting a crash
(which usually has an error), instead it just doesn't continue at all. It
appears that it's supposed to be removing the previous ship and returning
control to the game but that's not happening.
—
Reply to this email directly, view it on GitHub
https://github.com/Baledin/FlyCasual/issues/37#issuecomment-2395489588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUJWQ25AGBAV4HRMQXK3WLZ2FNG7AVCNFSM6AAAAABPNQKVN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ4DSNJYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I realized something while testing this today, it doesn't appear to actually crash or freeze but the user input isn't obvious or user friendly. A maneuver selection appears, selecting a maneuver will move the Pup and continue the game as normal. Please try this out on your end and let me know if you still have an issue or if this is indeed just not a clear step in the process. I will try to think of ways to make this more obvious to the player. Perhaps a popup indicating that the user needs to select a maneuver for the escape craft?

Please let me know if the above has resolved your immediate issue or if you see something different. I will close this issue on January 1 if no response. Thanks!


AddressInUseException when new instance of docker container is created

Bug description
When previous instance of container is destroyed and a new instance is created by docker, the AddressInUseException is thrown. Although the port binding only specifies the container port and not the host port. Here the network settings from docker inspect of a working container:
   "NetworkSettings": {
       "Bridge": "",
       "SandboxID": "7ca4c991166252aef6bc5fcbd90f6f915d162dadbf595b1bd8d3377087332459",
       "HairpinMode": false,
       "LinkLocalIPv6Address": "",
       "LinkLocalIPv6PrefixLen": 0,
       "Ports": {
           "50008/tcp": [
               {
                   "HostIp": "<IP_ADDRESS>",
                   "HostPort": "32778"
               }
           ]
       },
       "SandboxKey": "/var/run/docker/netns/7ca4c9911662",
       "SecondaryIPAddresses": null,
       "SecondaryIPv6Addresses": null,
       "EndpointID": "bb262b04350434074cedc1dc0c475bac0fe52e74b8694b5c10c915e5b82fcc5c",
       "Gateway": "<IP_ADDRESS>",
       "GlobalIPv6Address": "",
       "GlobalIPv6PrefixLen": 0,
       "IPAddress": "<IP_ADDRESS>",
       "IPPrefixLen": 16,
       "IPv6Gateway": "",
       "MacAddress": "02:42:ac:11:00:0c",
       "Networks": {
           "bridge": {
               "IPAMConfig": null,
               "Links": null,
               "Aliases": null,
               "NetworkID": "78b10c0ce9b9a670cd3fd6d2366f23e889cdc46505b09eb2322ab329b78a6c0b",
               "EndpointID": "bb262b04350434074cedc1dc0c475bac0fe52e74b8694b5c10c915e5b82fcc5c",
               "Gateway": "<IP_ADDRESS>",
               "IPAddress": "<IP_ADDRESS>",
               "IPPrefixLen": 16,
               "IPv6Gateway": "",
               "GlobalIPv6Address": "",
               "GlobalIPv6PrefixLen": 0,
               "MacAddress": "02:42:ac:11:00:0c",
               "DriverOpts": null
           }
       }
   }

This happened first time ever, we're using AWS ECS, it's common that multiple containers of the same image run on the same underlying instance and we never had these kinds of problems before. Could you also advice on a possible way to debug this in the future?
Expected behavior
This should never happen, it is in a separate network stack and the port should never be occupied.
Additional context
Stacktrace
Microsoft.AspNetCore.Server.Kestrel|FATAL|Unable to start Kestrel. System.IO.IOException: Failed to bind to address http://[::]:50008: address already in use. ---> Microsoft.AspNetCore.Connections.AddressInUseException: Address in use ---> System.Net.Sockets.SocketException: Address in use
   at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName)
   at System.Net.Sockets.Socket.DoBind(EndPoint endPointSnapshot, SocketAddress socketAddress)
   at System.Net.Sockets.Socket.Bind(EndPoint localEP)
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync()
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketTransport.BindAsync()
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass21_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context)
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.ListenOptions.BindAsync(AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.AnyIPListenOptions.BindAsync(AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.BindAsync(AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(IServerAddressesFeature addresses, KestrelServerOptions serverOptions, ILogger logger, Func`2 createBinding)
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)

This should never happen, it is in a separate network stack and the port should never be occupied.

My understanding is that you're correct but it's docker's responsibility to ensure that.
Can you reproduce this reliably at all? Without a repro or additional diagnostics there's not a lot we can do. Perhaps running netstat -a prior to starting up the app to see if there are any other processes holding the address?

@anurse thx for the advise, we'll add netstat -a to the dockerfile to be executed as the first command, before dotnet to see if there are any weirdly occupied ports.
It's something that happened back then  (3 weeks ago) quite reliably, but at the moment I haven't seen it for a while. We definitely didn't change anything in those regards, so all I could think of is a change in the docker image, as we just use the mcr.microsoft.com/dotnet/core/aspnet:2.2 image we'd simply get the latest version every time we build a container for testing.

Closing this as we haven't heard from you and generally close issues with no response after ~7 days. Please feel free to comment if you're able to get the information we're looking for and we can reopen the issue to investigate further!


Rewrite to use sqlite3 and public api of publishing-api, ready for jenkins

Goals of this PR
Use sqlite3 for our local db to avoid having to instal postgres on the
Jenkins node which will run the checker.
Use a new endpoint on Publishing API so that we are using a maintained, public API.
This avoids the fragility and coupling of using the publishing-api database directly.
Define the checks we wish to run in order to detect interesting discrepancies
between Rummager and Pubilshing API content. Report on the results with enough detail
to allow for useful analysis by humans.
Redesign the program so that is is suitable for Jenkins, and can be more easily maintained in future.
In particular, introduce a whitelist so that we can keep Jenkins green while we work on fixing
any problems found.
Still to come
Add rubocop/linting.
Analyse the check outputs and add appropriate whitelisting.
Use the checker in Jenkins, once https://github.com/alphagov/publishing-api/pull/305 is merged.
In the meantime, the checker can be run locally by pointing it at a publishing-api from that PR branch.
Therefore, this PR can already replace the previous version.
Review
This PR is the result of many small commits, which were unfortunately mostly not addressing particular areas of the program in an orderly manner but rather exploring the entire program piecemeal.
It would be rather onerous and conflict-ridden to attempt reordering. Commits have been squashed into a few large chunks, which might represent the failings and increased understanding of the authors over time; however, reviewers will probably find it easier consider the overall result rather than the individual commits.
See https://trello.com/c/DYFgXNYr/621-automate-link-checker-tool
@MatMoore @Davidslv @benhyland

"Always leave a trailing newline in the file to keep compatibility with command-line tools. Some text editors will add this automatically; Sublime Text will add it if you enable the ensure_newline_at_eof_on_save setting. (TrailingBlankLines)"
https://github.com/alphagov/styleguides/blob/master/ruby.md#general

Looks good so far. Is it worth integrating using a test framework for check discovery/execution so we can report it on nicely? Or is that already the plan?

@MatMoore Discussed using a test framework to represent our checks offline. We decided that the value gained is not worth the effort in this particular example, since to do this we would want to further separate the environment and import from the tests, and this is difficult as we are using in-memory sqlite.

Got a little bit left to review on this, will continue tomorrow when Github isn't quite so broken.
Rather than be annoying with my whitespace/indent comments, just a general observation that we could do with a quick run-through of all changed files to remove extra newlines and correct formatting to 2-space indents.
General approach looks fine to me so far, just the odd question here and there.

Thanks all for comments so far and for persistence in the teeth of github being on fire.
I believe I've addressed everything so far in line notes.

I'm going to merge this so any other comments can be addressed in smaller PRs. 👍


Yaki Admin - Add team picture

FRONT MOBILE :

Display the team picture at the team selection page

FRONT ADMIN :

during creation or team edition, the modal designed by Basti has a feature to add or change the team logo / image
Create a fetch to send the image to the backend in the teamservice using formData
Get the image with the team informations

BACK :

route to save the image to the database into byte array with team information (user current route or define a new one for the image ?)
route to get the team picture ? or is the current route is fine ?

DB :

create a new table for team picture ( or edit the avatar table ? : this is to discuss)

This was developped


Tuple4,5,6,7,8 need a transform method

Same implementation as for lower arity tuples.
  public <R1> R1 transform(Function3<? super T1, ? super T2, ? super T3, ? extends R1> fn){
        return fn.apply(_1(),_2(),_3());
    }

Released in 10.0.0-M4


can not log into sql server using domain account

OS: WSL2 / Ubuntu 20.04.6 LTS (Focal Fossa)
Driver: Microsoft ODBC Driver 18 for SQL Server
Installation:
curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add -
curl https://packages.microsoft.com/config/debian/11/prod.list > /etc/apt/sources.list.d/mssql-release.list
apt-get update
ACCEPT_EULA=Y apt-get install -y msodbcsql18
apt-get install -y unixodbc-dev gnupg libkrb5-dev pkg-config
dbt profile.yml:
local:
type: sqlserver
driver: 'ODBC Driver 18 for SQL Server'
server: sql-server-instance.domain.com
port: 1433
trust_cert: true
database: database_name
schema: dbo
authentication: ActiveDirectoryPassword
user: 'DOMAIN\username'
password: 'password'
threads: 4
Error:
with authentication: ActiveDirectoryPassword
Database Error
('28000', "[28000] [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]Login failed for user ''. (18456) (SQLDriverConnect)")
without authentication: ActiveDirectoryPassword
Database Error
('28000', "[28000] [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]Login failed for user 'DOMAIN\\username'. (18456) (SQLDriverConnect)")
Observations:
sql server authentication works fine

If it can help, this is what we're using to connect with the Windows user of the current session.
dbt-transform:
  target: local
  outputs:
    local:
      type: sqlserver
      driver: 'ODBC Driver 17 for SQL Server'
      server: my_server\name
      port: 1433
      trusted_connection: True
      encrypt: False
      threads: 2
      database: my_db
      schema: my_local_schema

I see you use trusted_connection here. doesn't this imply it's running on domain joined windows hosts? I am running dbt for sql server on ubuntu, which is not domain joined.

Yes, it's all Windows.

@yxl1108 as far I know, you need to login with a SQL Account.
AD Accounts, can only login to a SQL Server using Trusted Connection when you had logged with the same account at your machine.
At my setup, I have a dedicated SQL Account for dbt jobs.

@yxl1108 Were you able to resolve this one ?


Present Local Notification not working in Android

presentLocalNotification when implemented does not show off when app is in active state

You must set
show_in_foreground: true
Also try removing icon
So config should look like this:
FCM.presentLocalNotification({
      title: "Title",
      body: "Message",
      icon: "ic_launcher",     // remove this line for example
      show_in_foreground: true
 })

Do not forget to rebuild if you change icon names
react-native run-android

and priority: high if you want to see the banner

@evollu @MilosR Hi i ended up with the same problem. I got everything configured. Everything works when apps in background. I receive notifications on my device when app is in foreground but notifications are not pushed to my device tray.  I posted code, you can check my comment here https://github.com/evollu/react-native-fcm/issues/345

How did you solved this issue?
I can't find the link provided. /issues/345

@binzailani3136 Hi try this little trick. In above url https://github.com/evollu/react-native-fcm/issues/374#issuecomment-301114364 change 374 to 345.

It's empty url, it redirects to 404 page. xD

Damn opens for me every time, it looks like https://github.com/evollu/react-native-fcm/issues/345#issuecomment-301114364. Sorry i meant not in the url above in comment, but the url above in the browser.


typescript publising guide

The best option according to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
close #26

Closing as fs-promise is now deprecated in favor of fs-extra or mz/fs


Adding code to print stable_train_samples_per_second values

This PR is to include stable_train_samples_per_second values in the log

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update docs with instructions of how to use cert manager instead of internal cert

At a high level, the user would need to install cert-manager on their cluster with kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.11.0/cert-manager.yaml then update this line in the config yaml to say ../components/certmanager, then uncomment all the sections beginning with [CERTMANAGER].

/assign

Fixed by #107


change check_auth_status return type, add Clone trait

.gitignore has a conflict, I think you can discard your change there, I applied it on my end. Then I'll approve and you can merge


[4.0][Refactor][WIP] Clean up folder structure

Moved everything but the BackpackServiceProvider into the app folder. Much cleaner now:

Unfortunately, this is a huge breaking change.

Upgrade guide - search and replace:

replace Backpack\CRUD\CrudTrait with Backpack\CRUD\app\Models\Traits\CrudTrait
replace Backpack\CRUD\ModelTraits\SpatieTranslatable with Backpack\CRUD\app\Models\Traits\SpatieTranslatable

I don't think it's such a big breaking change. The solution is pretty simple to implement. And it really does clean up the folder structure. A LOT.


e2e IBC client upgrade

Summary
Add an e2e test for upgrading an ibc client. In theory it should be possible. Might be useful to split this issue up into smaller bite sized sections (add just submission of the upgrade proposal, add execution of the upgrade, add relaying of the MsgUpgradeClient, etc)

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Here's how the test can work:

create two chains, a channel between them, send a packet
create a ibc software uprgade proposal
perform the upgrade using a handler which changes a chain specific field like the unbonding period
restart the chains
ensure the clients cannot be updated normally
use the relayers to perform the client upgrade
ensure clients can be updated normally/process packets

After doing some investigation into this, I've run into a few issues.

The relayer interface does not yet expose an UpgradeClient function.
The golang relayer will create a new client when there is a mismatch here and so it is difficult to re-use the existing client in the test to verify it does not work.

I'm not sure if it is possible to actually write this test without being able to

directly specify an existing client ID to attempt to re-use in a test.

I will close this issue in favour of https://github.com/cosmos/ibc-go/issues/4619, but I will link it there not to lose the comments here.


Align node-role value for kubeadm compatibility

kubeadm sets node label node-role.kubernetes.io/master=''
and this is not configurable. We should use it everywhere.

ci check this

/lgtm
/approve


Publish clicked point with orientation

I would like to publish GPS coordinate message by clicking on the display, where point_click_publisher with frame set to /wgs84 get the job done perfectly.
However, I am looking to add orientation like how the move_base 2D Estimated Pose option works, such that the message field contains GPS coordinate + orientation.
point_click_publisher publishes PointStamped only;
move_base Estimated Pose publishes pose message to /initialpose with data under map frame only and not changeable.
How can I achieve this?

There is not an existing way to do this using just mapviz.
One way we have done something like this is by creating a node which listens to two PointStamps and uses the relative heading between the two to create a Pose. The alternative is creating a new mapviz plugin based on point_click_publisher (or adding an option to it) which does something similar internally.

I'm thinking about how we could integrate this more easily into the UI. What if we did something like a click and drag, where you click where the waypoint should be, and then drag to the direction you want? After you release, the point would be published.

@tky1026, check out https://github.com/swri-robotics/mapviz/pull/716 and see if it does what you need.  I based it off of the move_base plugin.


feature: To add the email/ password required, and valid email notification in the sign in form. dynamically.

Is your feature request related to a problem? Please describe.
There is not warning to the user when they enter a invalid email, and when either of the fields in sign in form are empty.
Solution
To add the email/ password required, and invalid email notification in the sign in form. Using Zod.
https://github.com/user-attachments/assets/6cde0b6a-c306-4dac-80d4-f65386469e4a
Can i get this done, if it looks like a good thing to add?

assign me

@Karthik150502 i think we can make use of regix here which can easily detect the invalid email and password as it should be min 8 characters

can I Try

can I Try

This is not useful. There's no requirement that the input should only be email. You can even try with using phone number it should work good


Fixes for Update-DbaInstance: parallelism, exceptions

Type of Change

[x] Bug fix (non-breaking change, fixes #4988 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Fixing issue raised by @wsmelton as well as some annoying parallelism fix that can't be tested in Appveyor (adding -ImportFunctions to the Invoke-Parallel fixes inability to use internal commands inside the script block).
Approach
no EnableException in the internals
try-catches everywhere
Commands to test
Update-DbaInstance -ComputerName srv1, srv2
Screenshots

Learning

@wsmelton - can you test?

thanks so much @nvarscar  🙇


Can't view details of some tasks from Nextcloud

When clicking on some tasks, got this error and details panel don't appear:
[DEBUG] Details: Update info
Traceback (most recent call last):
  File "/usr/share/errands/errands/widgets/task.py", line 296, in on_details_clicked
    self.details.update_info(self)
  File "/usr/share/errands/errands/widgets/details.py", line 278, in update_info
    self.start_datetime.set_datetime(self.parent.get_prop("start_date"))
  File "/usr/share/errands/errands/widgets/components.py", line 194, in set_datetime
    self.hour.set_value(int(dt[9:11]))
                        ^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: ''

This task is created by TasksOrg app on Android, here's how it looks like in browser network inspect:
<cal:calendar-data>BEGIN:VCALENDAR
VERSION:2.0
PRODID:+//IDN tasks.org//android-130605//EN
BEGIN:VTODO
DTSTAMP:20231229T051546Z
UID:2754374180015068324
CREATED:20231229T051509Z
LAST-MODIFIED:20231229T051540Z
SUMMARY:<<Super-secret task summary hidden>>
PRIORITY:5
X-APPLE-SORT-ORDER:725173819
DUE;VALUE=DATE:20240131
DTSTART;VALUE=DATE:20240114
BEGIN:VALARM
TRIGGER;RELATED=END:PT0S
ACTION:DISPLAY
DESCRIPTION:Default Tasks.org description
END:VALARM
END:VTODO
END:VCALENDAR
</cal:calendar-data>...

Found the issue, fixed now in 08076d4cd8d09e6a7e570054d5199dc2d24928f5. Thanks!

Yes, now it works.
Thank you for your wonderful application)


Decimalv3 pick four commits from master branch

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Please link to the PR number

Please link to the PR number

#15463 #15505 #15574 #15644


Fix errors destroying script with static variables

Fixes #78376
After #78138 script_list is now cleared in GDScriptLanguage::finish. Because of that, we can safely remove the removal from that list that happens on GDScript::~GDScript. This removal was what was causing the error in #78376, since it was trying to remove an element from an empty list.
I tested by running a script that contained a static var declaration. After applying these changes, the USER ERROR: Condition "p_elem->_root != this" is true. no longer appears in the console while closing the project.

This will risk thread unsafe stuff as we are no longer locking the thread
If the list is valid the entry will still be removed, only now it doesn't have a mutex lock when doing so

Got it, I made the requested changes and tested again. Working as expected.

Thanks!


Added security question

Summary of changes

Added a security question that talks about how gets is vulnerable to buffer overflow attacks
Checklist

[X] I have read and followed the contribution guidelines.
[X] I have read through the Code of Conduct and agree to abide by the rules.
[X] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[X] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[X] I have provided a summary of my changes.

closes #XXXXX

@jdwilkin4 I've committed the suggested changes :)


Don't bundle root.css

Update the build process to not bundle root.css, so that users can't customize it.

Removed root.css from min build and created a bundle.


multiple tax keys

Quite a few online shops I've built had two or more tax keys and not just one which is either used or not.

This was discussed before, and we changed a few things to start making that a little easier to do. It just hasn't been done yet. I'm open to it. I first thought that it would be used in a business that had multiple store locations with different tax codes, but realized I was wrong about that.
So that said, it may be long down the list of our immediate priorities. I'm marking it as Help Wanted in case anyone wants to contribute that. Or I could also see someone making a premium add-on for it. I wouldn't be mad at either. If it goes unaddressed for long enough and there's some demand for it, maybe we can circle back to it.

It's good to know you're open to it. Knowthing that makes this package a bit more useable for us! If we need it, we could contribute some code, not as an add-on but rather a pull request.

Of course I'm open to it :) I'm pretty much open to anything that benefits the store.


Improve ios-application sample wrt Xcode IDE generated project

Expected Behavior

As a plugin author, you can add ad-hoc files to be included in the Xcode IDE generated project.
Current Behavior

At the moment, a plugin author needs to rely on internal APIs.
Context

See swift/ios-application sample and this code review discussion.
Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

Bonus points if the solution is cross-cutting across all IDE plugins.

I read the swift plugins announcement, cloned the native-samples repo, built the ios-application sample project, and I'm excited for the progress. I am really looking forward to running an iOS application within XCode from a gradle build when this feature becomes available. I figured that a 👍 reaction did not convey my appreciation for the progress, and my excitement for this feature.

Thanks a lot for the comment, it means a lot.


FeatureTypes attribute

Hello,
I'm checking a Microsoft Teams user with Office 365 E3 and Standard Microsoft Teams Phone System licenses assigned but unable to dial phone numbers (he gets a license issue message), whose FeatureTypes attribute is null.
I see other users whose Feature Types attribute is {PhoneSystem, Teams}, and they are able to dial phone numbers.
Can FeatureTypes attribute be modified directly through Powershell, to set is as {PhoneSystem, Teams} (which command?)? Or it should be modified anywhere else inside Microsoft and it's just showed here, and I'm missing it?
Same problem with DialPlan attribute (it is null for the non-working user).
Thanks and regards,
Cristina

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7008ec10-a056-d8bb-bb4e-b4690a84adfd
Version Independent ID: 2dcb78d9-7f36-208e-0989-184905d73011
Content: Get-CsOnlineUser (SkypeForBusiness)
Content Source: skype/skype-ps/skype/Get-CsOnlineUser.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

Hi @Cristina-Cajal, thank you for your feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome, let me know if it can be called out in the docs.
Please follow this link to contact support for business products: https://docs.microsoft.com/office365/admin/contact-support-for-business-products.
Please keep us posted here on the resolution to feed whatever information you discover into the content.

@dariomws Thank you very much for the contribution and sharing this explanation. @Cristina-Cajal Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


feat(natds-icons): add icons finance-pix

DSY-000
Description

filled-finance-pix
outlined-finance-pix

[update regression]


Plugin configuration issues

Upload plugin configuration does not work

Click on the plug icon -> Avatax
Click on Plugin Configuration
Enter valid values for Account ID and License key
This displays a "We're sorry, but something went wrong." message.

The following error is displayed in the logs:
2023-02-07T06:53:28,302+0000 lvl='INFO', log='rack', th='http-nio-9090-exec-10', xff='', rId='d2ea126c-f9aa-429d-9b0b-be27d6c64f8c', tok='', aRId='', tRId='',F, [2023-02-07T06:53:28.302000 #10456] FATAL -- : org/jruby/RubyString.java:2274:in `concat'
gems/gems/killbill-avatax-2.1.0/app/controllers/avatax/configuration_controller.rb:100:in `update_plugin_configuration'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
gems/gems/actionpack-5.1.0/lib/abstract_controller/base.rb:186:in `process_action'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/rendering.rb:30:in `process_action'
gems/gems/actionpack-5.1.0/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
gems/gems/activesupport-5.1.0/lib/active_support/callbacks.rb:131:in `run_callbacks'
gems/gems/actionpack-5.1.0/lib/abstract_controller/callbacks.rb:19:in `process_action'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/rescue.rb:20:in `process_action'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
gems/gems/activesupport-5.1.0/lib/active_support/notifications.rb:166:in `block in instrument'
gems/gems/activesupport-5.1.0/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
gems/gems/activesupport-5.1.0/lib/active_support/notifications.rb:166:in `instrument'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
gems/gems/actionpack-5.1.0/lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
gems/gems/activerecord-5.1.0/lib/active_record/railties/controller_runtime.rb:22:in `process_action'
gems/gems/actionpack-5.1.0/lib/abstract_controller/base.rb:124:in `process'
gems/gems/actionview-5.1.0/lib/action_view/rendering.rb:30:in `process'
gems/gems/actionpack-5.1.0/lib/action_controller/metal.rb:189:in `dispatch'
gems/gems/actionpack-5.1.0/lib/action_controller/metal.rb:253:in `dispatch'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/route_set.rb:31:in `serve'
gems/gems/actionpack-5.1.0/lib/action_dispatch/journey/router.rb:46:in `block in serve'
org/jruby/RubyArray.java:1735:in `each'
gems/gems/actionpack-5.1.0/lib/action_dispatch/journey/router.rb:33:in `serve'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/route_set.rb:832:in `call'
gems/gems/railties-5.1.0/lib/rails/engine.rb:522:in `call'
org/jruby/RubyKernel.java:1830:in `public_send'
gems/gems/railties-5.1.0/lib/rails/railtie.rb:185:in `method_missing'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/mapper.rb:17:in `block in Constraints'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/mapper.rb:46:in `serve'
gems/gems/actionpack-5.1.0/lib/action_dispatch/journey/router.rb:46:in `block in serve'
org/jruby/RubyArray.java:1735:in `each'
gems/gems/actionpack-5.1.0/lib/action_dispatch/journey/router.rb:33:in `serve'
gems/gems/actionpack-5.1.0/lib/action_dispatch/routing/route_set.rb:832:in `call'
gems/gems/warden-1.2.9/lib/warden/manager.rb:36:in `block in call'
org/jruby/RubyKernel.java:1138:in `catch'
gems/gems/warden-1.2.9/lib/warden/manager.rb:34:in `call'
gems/gems/rack-2.2.3/lib/rack/etag.rb:27:in `call'
gems/gems/rack-2.2.3/lib/rack/conditional_get.rb:40:in `call'
gems/gems/rack-2.2.3/lib/rack/head.rb:12:in `call'
gems/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:266:in `context'
gems/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:260:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/cookies.rb:613:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
gems/gems/activesupport-5.1.0/lib/active_support/callbacks.rb:97:in `run_callbacks'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/callbacks.rb:24:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
gems/gems/railties-5.1.0/lib/rails/rack/logger.rb:36:in `call_app'
gems/gems/railties-5.1.0/lib/rails/rack/logger.rb:24:in `block in call'
gems/gems/activesupport-5.1.0/lib/active_support/tagged_logging.rb:69:in `block in tagged'
gems/gems/activesupport-5.1.0/lib/active_support/tagged_logging.rb:26:in `tagged'
gems/gems/activesupport-5.1.0/lib/active_support/tagged_logging.rb:69:in `tagged'
gems/gems/railties-5.1.0/lib/rails/rack/logger.rb:24:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/request_id.rb:25:in `call'
gems/gems/rack-2.2.3/lib/rack/method_override.rb:24:in `call'
gems/gems/rack-2.2.3/lib/rack/runtime.rb:22:in `call'
gems/gems/activesupport-5.1.0/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/executor.rb:12:in `call'
gems/gems/actionpack-5.1.0/lib/action_dispatch/middleware/static.rb:125:in `call'
gems/gems/rack-2.2.3/lib/rack/sendfile.rb:110:in `call'
gems/gems/railties-5.1.0/lib/rails/engine.rb:522:in `call'
uri:classloader:/rack/handler/servlet.rb:22:in `call'

UI Improvements

The UI needs to be updated to accept other configuration properties as documented here. At the very least, it should at least accept values for the org.killbill.billing.plugin.avatax.url/org.killbill.billing.plugin.avatax.taxratesapi.url properties
If some properties are not mandatory, this should be indicated in the UI and their default values should be pre-populated
The UI should provide a brief explanation for each property (Maybe when the mouse is moved over the property name?)

Hi @reshmabidikar ,
I made a PR here: https://github.com/killbill/killbill-avatax-ui/pull/13
Please help me to verify this.
To test this, you must create a new tenant, and test with a new tenant because this issue only happens when the tenant doesn't have any AvataxConfiguration.


fix: resolve critical issue with keyboard input for s390x

Testers reported that keyboard input was not recognized when attempting to access the VM via VNC. This issue arose because no virtual keyboard was configured for the s390x architecture. This explains why console and SSH access functioned without any problems.

What this PR does
Before this PR: critical bug when connecting via VNC to s390x guests
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/approve

cc: @cfilleke

Thank you all for your understanding.

Regarding the need for more generic code, I agree that this is worth considering. However, it's important to note that for ARM, the bus type is USB, while for s390x, it is Virtio.

As for the functional tests, this error cannot currently be captured, even in tests for other architectures. Nevertheless, we can brainstorm potential solutions. The end-to-end tests I have reviewed for VNC primarily focus on checking the connection.

One final thought: a generic error in QEMU related to input devices could impact virtctl vnc and the console view in the OpenShift dashboard, and as far as I know, we do not currently test for this.

/retest

/cherrypick release-1.4


updated app/added filters, curious about more profiles

I downloaded the latest version from fuckr.me then added back the filters for: looking for, tribe, ethnicity, body type, relationship, and position, hiv status is not a filter in the actual app.  I also fixed the online checkbox to function properly as the value changed from 'onlineOnly' to 'online'
I have also added the ethnicity, body type, tribe, relationship, looking for, and hiv status to the profiles.  The tribe will only show up currently if only one is selected, and looking for shows up as numbers, as I didn't process the numbers in the array into the word values.  If you would like to use any of the updates and incorporate them @tomlandia feel free to grab the code off my fork.
I've also tested this on windows 10 and it's working great.  I am using  a fresh install of Windows 10 and Fuckr, with Windows 10 updated with all updates.  I'm not having any issues of any kind.
Now I'm curious about making more profiles show up.  I customized a separate version of the app to download the rules and user prefs to view the differences between a regular account and an xtra version.   I need to switch OSs and will put the diffs up here, perhaps this will help to get more profiles to load.

XTRA-Rules
app.maxPhotosAtOnce: 5
app.sendSavedPhrases.enabled: true
app.xtraSubscription.secondsRemaining: [redacted]
app.xtraSubscription.subscriptionId: "Grindr Xtra 1 Month Subscription Android"
broadcastsToDisplay: 3
cascade.maxPages: 1
cascade.profileQuantityPerPage: 600
eligibleForVideoAdRewardsOffer: false
isEligibleForVideoAdRewardsOffer: false
maxBlocksPerDay: [redacted]
maxFavoritesPerDay: [redacted]
serverTime: [redacted]
user.eligibleForFreeTrial: true
user.userRole: "Xtra"

Free-Rules
app.maxPhotosAtOnce: 1
app.sendSavedPhrases.enabled: false
app.xtraSubscription.secondsRemaining: 0
app.xtraSubscription.subscriptionId: null
broadcastsToDisplay: 3
cascade.maxPages: 1
cascade.profileQuantityPerPage: 100
eligibleForVideoAdRewardsOffer: true
isEligibleForVideoAdRewardsOffer: true
maxBlocksPerDay: 10
maxFavoritesPerDay: 10
serverTime: [redacted]
user.eligibleForFreeTrial: true
user.userRole: "Free"

@robbie: where can I download the pack you are using? i don't know anything
about code, but thx to all for all the great work!
2017-03-26 6:37 GMT-04:00 RobbieTechie<EMAIL_ADDRESS>
I downloaded the latest version from fuckr.me then added back the filters
for: looking for, tribe, ethnicity, body type, relationship, and position,
hiv status is not a filter in the actual app. I also fixed the online
checkbox to function properly as the value changed from 'onlineOnly' to
'online'
I have also added the ethnicity, body type, tribe, relationship, looking
for, and hiv status to the profiles. The tribe will only show up currently
if only one is selected, and looking for shows up as numbers, as I didn't
process the numbers in the array into the word values. If you would like to
use any of the updates and incorporate them @tomlandia
https://github.com/tomlandia feel free to grab the code off my fork.
I've also tested this on windows 10 and it's working great. I am using a
fresh install of Windows 10 and Fuckr, with Windows 10 updated with all
updates. I'm not having any issues of any kind.
Now I'm curious about making more profiles show up. I customized a
separate version of the app to download the rules and user prefs to view
the differences between a regular account and an xtra version. I need to
switch OSs and will put the diffs up here, perhaps this will help to get
more apps to load.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tomlandia/fuckr/issues/127, or mute the thread
https://github.com/notifications/unsubscribe-auth/AYL6wCeANxUDBuYFvkC6mSJiYhccmgV5ks5rpj_pgaJpZM4MpYrp
.

go here https://github.com/RobbieTechie/fuckr and click the button that says "clone or download" and download the zip.  Then extract it, and copy the files to your current fuckr folder, and overwrite anything it asks to overwrite, and launch the app again, and it should be good to go.

Tried downloading and copying over the Windows version from main fuckr website. Then copied/replaced the RobbieTechie files, but still won't let me login, or signup for new account either. Gives no reason, just resets the name/password fields to blank. When I try to add a Date of Birth and different email, then click Sign Up, it just gives me the spinning "wait" symbol.

@RobbieTechie Can you explain how to "overwrite" / install your version on a Mac? Thanks in advance!


chore: inline contents of common/proof.rs into acvm-backend-barretenberg

These functions are only used in a single file each so I've moved them to the relevant locations.

Yep, previously they were used in the composer.rs file for both of those packages but now those are both the same file.


tooltip should be displayed for all charts not just the very top one

Please see attached 3 .csv files
Syntax to use:

at(0, 0, 100,100) data('CatCellDistribution.csv') bar x(x) y(y) axes(x:1, y:5) stack color(ClusterID:[#CBF7FF, #00B6CB]) tooltip(#all) style('width:20px;') legends(none)  | at(0, 0, 100,100) data('scaleCellDistribution.csv') area smooth(y:40) x(x) y(y)  color(ClusterID:[#CBF7FF, #00B6CB]) tooltip(#all)    | at(0, 0, 100,100) data('ed_catCell.csv') bar x(x) y(y) axes(x:5, y:5) color(ClusterID:[#CBF7FF, #00B6CB]) tooltip(#all) legends(none) style('width:20px;')

You can see the tooltip for the third chart as expected.

From the browser debugger, add style="visibility:hidden" for "chart3". You will see the chart like this:

when mouse over the chart, no tooltip is displayed.
data.zip

I have pushed a fix for this; however note that if you allow panning and zooming (which is on by default for many charts), then the pan/zoom activity for the top chart will consume the event and you will not get tooltips for the charts underneath.
Thus the safest thing to do is to add interaction(none) to all the chart definitions so they do not pan/zoom and all mouse events are good for tooltips

I updated the online javascript and CSS resources; it should work now. For an example, if you go the demo environment (http://brunelvis.mybluemix.net/try.html) and use the following syntax, you should see two overlaid charts, with tooltips on both elements
x(weight) y(mpg) color(origin) tooltip(#all) interaction(none) at(0,0,100,100)| bar x(weight) y(#count) bin(weight) tooltip(#all)  interaction(none) at(0,0,100,100)

indeed it is working after removing the overlay .css overridden.

fixed.


convert index alias to microseconds

Because the index name is now tied to a particular second, when testing a module that uses elasticsearch-elixir, the index name will collide.
Changed to microsecond.

Thanks @jfrolich!


feat: upgrade exposed API from BigInt to BI

This PR is a merge PR, for more information, we can check https://github.com/nervosnetwork/lumos/pull/239

We have migrated to another JSBI wrapped implementation @ckb-lumos/bi https://github.com/nervosnetwork/lumos/pull/248 so close this one


OpenDevin can't apt install

I'm getting these kinds of 127 errors
Command sudo apt update && sudo apt install nodejs npm -y executed with exit code 127.
ODevin Can write to the file system on my machine but anything got to do with downloading or running packages I believe in the sandbox won't work.
I think this has got to do with the fact I'm on Windows but I thought the backend had it's own Docker setup with Linux.

Hmm...this should be solved since we started running Devin as root.
Are there any error messages besides this?
Also--it would be helpful if you could fill out the issue template

same issue.

@andrescevp @AmerDinar Are you also running on Windows like the OP?

Using it with Ubuntu

Maybe this helps? This is the error message I observe with Ubuntu.
ACTION:
CmdRunAction(command='sudo apt-get update && sudo apt-get install -y cppcheck', background=False, action=<ActionType.RUN: 'run'>)
13:02:00 - opendevin:ERROR: sandbox.py:227 - Command timed out, killing process...
13:04:00 - opendevin:ERROR: sandbox.py:227 - Command timed out, killing process...

OBSERVATION:
Command: "sudo apt-get update && sudo apt-get install -y cppcheck" timed out. Sending SIGINT to the process: sudo: unable to resolve host opendevin_sandbox: Temporary failure in name resolution
[sudo] password for opendevin:
sudo: a password is required

Ok updated, I see the command now being run without sudo, but fall into this error, from Opendevin terminal:
Reading package lists... 0Reading package lists... 0Reading package lists... 3Reading package lists... Done
E: List directory /var/lib/apt/lists/partial is missing. - Acquire (13: Permission denied)

Out of interest
parallels@ubuntu-linux-22-04-02-desktop:~/OpenDevin$ ls -l /var/lib/apt/lists
total 183932
...
drwx------ 2 _apt root    12288 Apr  8 15:56 partial
...

Same error for me, trying to install sqlite3:
ACTION:
CmdRunAction(command='apt update && apt install sqlite3 -y', background=False, action=<ActionType.RUN: 'run'>)

OBSERVATION:
Reading package lists... Done
E: List directory /var/lib/apt/lists/partial is missing. - Acquire (13: Permission denied)

@andrewparry @kroggen Apparently this is a Docker problem. I'm having some success editing the docker file and adding:
ARG SSL_KEYSTORE_PASSWORD USER root USER 1001
Looks like:
`FROM ubuntu:22.04
ARG SSL_KEYSTORE_PASSWORD
USER root
install basic packages
RUN apt-get update && apt-get install -y
curl
wget
git
vim
nano
unzip
zip
python3
python3-pip
python3-venv
python3-dev
build-essential
openssh-server
sudo
&& rm -rf /var/lib/apt/lists/*
USER 1001
RUN service ssh start`
Also, adding in sandbox.py:
USER_ID = 1001
before commenting out:
`# if config.get_or_none('SANDBOX_USER_ID') is not None:
USER_ID = int(config.get_or_default('SANDBOX_USER_ID', ''))
elif hasattr(os, 'getuid'):
USER_ID = os.getuid()`

working for me on Ubuntu, thanks guys!

@andrewparry @kroggen Apparently this is a Docker problem. I'm having some success editing the docker file and adding:
ARG SSL_KEYSTORE_PASSWORD USER root USER 1001
Looks like:
FROM ubuntu:22.04 ARG SSL_KEYSTORE_PASSWORD USER root '#' install basic packages RUN apt-get update && apt-get install -y curl wget git vim nano unzip zip python3 python3-pip python3-venv python3-dev build-essential openssh-server sudo && rm -rf /var/lib/apt/lists/* USER 1001 RUN service ssh start
Also, adding in sandbox.py:
USER_ID = 1001
before commenting out:
if config.get_or_none('SANDBOX_USER_ID') is not None: USER_ID = int(config.get_or_default('SANDBOX_USER_ID', '')) elif hasattr(os, 'getuid'): USER_ID = os.getuid()

Thanks, that fixed it for me, but it was exec_box.py and not sandbox.py.

I believe this is fixed now that everything is running in a consistent sandbox with RUN_AS_DEVIN=false


Guard against incidents being duplicated in incident list API responses

Sort by incident_number and not created_by to ensure stable sorting
The incident list API may return duplicate incidents under some circumstances, so as a precaution we'll dedupe the list by incident.id [INCIDENTS-1879]

[INCIDENTS-1879]


question about the the stero images annotation

Hello ,thank you for your great work .
I want to do some tasks with the stereo images but when I have used the annotations provided with dataset, they weren't fit on the stereo images.
so please can you help me to get the stereo images annotations?Thank you so much.?

Hi,
You're right, there is no ground-truth annotation for the stereo images.
During making this dataset, all the stereo annotations were not saved because my SSD has limited space. So, I don't have the backup for the stereo ground-truth...

okay got it,thank you so much


documentation error, constrainCenterOnly vs constrainOnlyCenter

The 6.0 release notes mention constrainCenterOnly

Previously, this options only constrained the view center. This behaviour can still be obtained by specifying constrainCenterOnly in the view options.

But the option is actually constrainOnlyCenter not constrainCenterOnly.

Hi @rgreenwood, thanks for reporting this, it was already fixed with #10513


Map reader writer updates

This fixes reference issues with the MapReader and MapWriter classes.
A non-const lvalue-reference is taken by MapWriter, but a temporary was being passed in, which causes an error on conforming compilers. The workaround is to create a local variable.
The MapReader used unique_ptr in the interface, which burdens the caller. The workaround is the same as above, using lvalue-references and named variables.

This related to the discussion in Issue #47.

Tested this code using a local modified OP2MapImager. It successfully images a map and saves a new map to disk. No compiler warnings or errors from MSVC.
I think what you mean by converting the internal implementation to lvalue is switching SeekableStreamReader* to SeekableStreamReader&.
Strangely, I had never though to declare a variable using & in this manner. I've only used it in function arguments and when converting an existing argument if that makes sense.
If we can change the private reference SeekableStreamReader* to SeekableStreamReader& while only forward declaring The SeekableStreamReader class instead of including the entire StreamReader header file, I would like to switch the internal implementation. This will make it a little easier to read as it will eliminate all the -> calls and when I see pointers, I'm typically looking for the an associated destructor even though one isn't needed here.
Thanks,
Brett

I will use a Rebase and merge for this branch. A few of the other merges today would have been more appropriate as rebase and merge but I made them merge commits. I'll try to be more careful before just pushing the 'Create a merge commit' button.

Correct about converting the internal implementation.
Forward declaration is sufficient to declare either a pointer (*) or reference (&). They are implemented the same under the hood. The compiler only needs to know the size of a pointer to make room for such variables. The full declaration is only needed when the pointer is de-referenced, such as by using ->, or .. That will only occur in the implementation file (.cpp), or inline methods in a header. The full declaration is also needed for object construction, such as non-pointer non-reference member variables, or using new.

I tried cleaning up my local branch after this merge, and I noticed Git complain this change was not fully merged. I believe this is related to the rebase and merge, as the rebase rewrites history, which changes commit IDs. It may also have to do with the merge order. Not sure if you've encountered this with your work. I can just force delete the old branch, though I'm hesitant to adopt a long term workflow that requires force deleting things.
I'm also noticing GitHub doesn't say anything about deleting the branch. It does show the pull request as closed. I guess it makes sense, since you wouldn't want to do multiple rebase and merge, or multiple squash and merge commits from the same branch into master. You might do that with a merge commit merge though, where you periodically bring two branches in sync with each other.
Let's continue to experiment until we figure it out.


Update styling of pages

[ ]  Paragraphs are indented
[ ]  Text does not wrap around to the next line
[ ]  All lines (except for the last line of a paragraph) extend to the right margin
[ ]  Last line on a page does not have any whitespace between the end of the line and the margin unless it is the end of a paragraph
[ ]  Text is large enough to be legible on small screens

Please add your planning poker estimate with ZenHub @Fattimo

@Fattimo Remove the red outline and add some more space between the text and the scroll bar and this will be done.


add headers option

headers is a valid option but is not defined by the TypeScript definition file. Here is an example of using headers: https://github.com/sindresorhus/got#cookies
Not sure why it is lacking from the list of valid options @sindresorhus in the official got docs.

It's documented here: https://nodejs.org/api/http.html#http_http_request_options_callback (Linked to from the readme). Didn't want to duplicate all the core http options.

Oh you're right. Then I will have to add those other properties as well.


Using RBG or BGR?

https://github.com/Prem95/realtime-face-liveness-detector/blob/89a1109a18e6be227f02233ed6f36e15501fe106/main.py#L61
Hi,
The return value of cv2.VideoCapture(0) is based on BGR format by default. You should not convert it in line 61.

Hi, the reason for converting is related to how the Face Detector crops the incoming face and what data the face detector model was trained on.


CDAP-18889 and CDAP-18892

@itsankit-google @rmstar Please review.
PR contains changes for CDAP-18889 and CDAP-18892 :

Add tests with Service Account Type as macro param (JSON)
Capture logs of preview run

Depends on https://github.com/cdapio/cdap-e2e-tests/pull/82

Conflict resolved.


started alias of main package for imports

just need to have a top-level folder eegexpy
and then add relative imports through an __init__.py
probably are going to have a lot of stuf in that __init__.py

merging for now as I want to do a demo :S
can continue to assess the imports question


Fix Issues#6 'Fix sorting in the Views section'

Modified to sort list data with generate_pages function.
Thank you very much for your good advice.

That looks good, thank you so much!
Merging the first PR! 🥇

Thank you so much for merging my PR!
You taught me a lot.Thank you so much.


New parameter type

I would like to have a new parameter type that'll be a Boolean.
This new type will be a multi check box selection that if one selects a check boxes, the value of that parameter of that check box would be true and if it will be left unticked, its value would be false.

ping @gilShin ? We're preparing to release 1.0 to all Jenkins users, and probably we'll move some issues to Jenkins JIRA or will close them before releasing.

We need a better use case and example in order to work on this new parameter type. Please file an issue on https://issues.jenkins-ci.org, with component name active-choices-plugin if you can provide this information :-) Thanks!


Mat-form  outline border

I noticed a small bug in outline border calcualtion:
this is an issue with setting a  _previousDirection variable in form-field.ts
1- the initial value is 'ltr', regardless if the page is originally loaded with 'rtl' layout.
2- in subscribtion of _dir.changes you call
this.updateOutlineGap(); before setting the value in
this._previousDirection = this._dir.value;
so the outlineGap calculated on the old value
my work around:
add style of mat-label to:
background-color: white;
padding:10px;
so no need to calculate outline gap.
please advice

This problem persists
I tested in 8.2.3 but it doesn't work

i update my angular material
but This problem persists
pls help Me

تا زمان حل این مشکل از ورژن 8.2.2 استفاده کنید.
On Wed, Nov 27, 2019 at 12:46 PM AlirezaPhf<EMAIL_ADDRESS>wrote:

i update my angular material
but This problem persists
pls help Me
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/components/issues/17390?email_source=notifications&email_token=AGL7PXDDUXHDLXOS3ALSLETQVY3FBA5CNFSM4JAHLHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFI2ROA#issuecomment-558999736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGL7PXGIBU7TWQFEMKMSFODQVY3FBANCNFSM4JAHLHAA
.

we need this change in v8. When is it gonna be merged to the stable version?


Update kubeadm_init.md, add kubeadm_init execute phases

add kubeadm_init execute phases

ping @mavk , would you have time to resolve comments and perform rebase?

@windsonsea ofcous, wait for me.


Paginate_orders() in authenticated_client.py does not pass auth

The second page comes back with {u'message': u'CB-ACCESS-KEY header is required'}.
The following works for my use case:
     def paginate_orders(self, result, after):
-        r = requests.get(self.url + '/orders?after={}'.format(str(after)))
+        r = requests.get(self.url + '/orders?after={}'.format(str(after)), auth=self.auth)

The auth seems to have been accidentally left out in this version. There is a major overhaul to authenticated_client.py coming soon which already addresses this issue and a ton of others. If you want, you can check out the changes here.
If you need this method working now I would suggest cloning the repo and modifying that line locally, as the overhaul removes this method entirely and introduces a new system for pagination.

This has been addressed. Thank you for sharing.  Pagination is being reviewed moving forward.


refactor: distinguish errors/warning/system errors

closes #549
Summary:
This PR is a refactor proposal aimed at implementing the distinction between ERRORS and WARNINGS in notice
Expected behavior:

by default: SystemError severity level is set to SeverityLevel.ERROR
by default: ValidationNotice severity level is set to SeverityLevel.ERROR

We implement setter/getter to modify field severityLevel of notices. This should be used in use case rule logic.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: -new feature short description-" (PR title must follow the conventional commit specification)
[x] Linked all relevant issues
~[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)~

[WIP] Listing of errors/warnings/system errors: https://github.com/MobilityData/gtfs-validator/issues/709

Thanks @aababilov for your review! I modified the code and provided sample usage for SeverityLevel.INFO and SeverityLevel.WARNING.

I noticed that some notices can be used in different context (as ERROR or WARNING) e.g. MissingTripEdgeNotice which can be an error if stop_times.arrival_time is missing, or a warning if stop_times.departure_times is missing.

An arrival time must be specified for the first and the last stop in a trip.
http://gtfs.org/reference/static#stop_timestxt

Is providing two constructors for this kind of notice the right approach to this situation (as done in https://github.com/MobilityData/gtfs-validator/pull/716/commits/156ccf543f92bae5a1cdfda6752bbe0c33b7fb9d)?

https://github.com/MobilityData/gtfs-validator/commit/156ccf543f92bae5a1cdfda6752bbe0c33b7fb9d is very nice. We actually need just a single constructor that requires to provide severity explicitly, so that the caller never forgets to set it.

 And thanks!

Thanks @aababilov!


Provide a Warning When Deleting Workloads that the Underlying Services Are Deleted As Well

What kind of request is this (question/bug/enhancement/feature request):
enchancement
I was with a client testing the concept of a blue/greeen deployment.
Steps to reproduce (least amount of steps as possible):

Create a Workload with a service
Create a 2nd Workload
Change the selector of the 1st Workload's service to point to the 2nd Workload
Delete the 1st Workload

Result:
The service associated with the 1st Workload is deleted and the 2nd Workload is no longer accessible.
Rancher 2.1.2

This is quite the edge case and I don't want to add a warning about something 99% of people are never going to do (and if they do, then what, how do they delete the workload?)
Seems like the API should only automatically delete the service that was created for the workload if it still selects (only) that workload at the time you're deleting.  Then you don't need a warning.


Not working on Atom 1.17.2

Does this extension still work?
I have Atomic Chrome plugins installed in Atom and Chrome, but pressing on the plugin icon in chrome does not do anything. Any tips on how I can start debugging this?
Running Linux Mint 18.1.

Never mind... it just appeared in an Atom instance that was not being used.


Multi Reference ROUGEScore

What does this PR do?
Fixes #667
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Yes.

Based on the current checks, it seems like the build is literally failing because of the absence of "Literal" typing in python<=3.7. Kindly let me know if it needs to be removed.

@ashutoshml Hi, Literal is not a part of typing for python<=3.6. You can, however, import Literal from typing_extensions, which is compatible with all python versions supported by TM.

@ashutoshml Hi, Literal is not a part of typing for python<=3.7. You can, however, import Literal from typing_extensions, which is compatible with all python versions supported by TM.

Done. Hopefully, the errors would be resolved now.

Made the necessary changes from review comments. Not sure why the PyTorchLightning.metrics build is failing though.


Export CSSOM classes

It can be usefull to be able to get and work with CSS classes, as it's already used in the library, why not make it accessible in root module and window like the rest of classes?
https://github.com/WebReflection/linkedom/blob/5527ee4aada82bd5cc07c739b87e372269922244/esm/html/style-element.js#L1
export * from 'cssom'

PS: as a linkedom user in deno, I don't know how to use CSSRule, etc... appart from importing a fresh new module that will conflict with the one used bt linkedom:
import { CSSRule } from 'npm:cssom'
document.querySelector('style').sheet.cssRules[0].contructor === CSSRule
// false

I would need:
import { CSSRule } from 'linkedom'
document.querySelector('style').sheet.cssRules[0].contructor === CSSRule
// true

this seems a reasonable question, I just need to be sure that module doesn't export conflicting names for the module. If you fancy a PR, please go ahead!

After investing code, there is a conflict with CSSStyleDeclaration, you have one, and CSSOM have one other... without the same role nor apis ! :(
Your's is used to be synced with the ownerElement.style , and the one from CSSOM is the more generic one used to store also CSSRule.style and don't sync to anything.
Your's also is iterable and the other not...
Both are not fully compliant with W3C (like concerning constructed StyleSheet's .replaceSync ... )
So the thing is that you get 2 really different classes that should both be the same, depending on where you get it:
// el is a <style> with some css
assert( el.style.constructor == el.sheet.cssRules[0].style.contructor )
// false !

I tried that to extract the classes from instances :
import { DOMParser } from<EMAIL_ADDRESS>
const temp = ( new DOMParser ).parseFromString(`<style>
@import url("style.css") screen;
@media (min-width: 500px) {}
div {
	foo: bar;
}
</style>`, 'text/html' ).documentElement

const CSSStyleSheet = temp.sheet.constructor
const linkedomCSSStyleDeclaration = temp.style.constructor		// only Element.style , is part of linkedom
const CSSImportRule = temp.sheet.cssRules[0].constructor
const CSSMediaRule = temp.sheet.cssRules[1].constructor
const CSSStyleRule = temp.sheet.cssRules[2].constructor	// or CSSRule
const CSSStyleDeclaration = temp.sheet.cssRules[2].style.constructor
const CSSRule = CSSStyleRule.prototype.constructor

export {
	CSSStyleSheet,
	CSSStyleDeclaration, linkedomCSSStyleDeclaration,
	CSSImportRule,
	CSSMediaRule,
	CSSStyleRule,
	CSSRule,
}

My conclusion is that it's weird to have 2 different implementations of CSS parsing depending on using <style> or <elem style="">.
linkedom should use fully the cssom module to parse style attribute!! As this is the only aspect of CSS of this library and also not its role...
This means rewrite the way CSSStyleDeclaration is synced to the ownerElement and rename this class to be a child of CSSOM's CSSStyleDeclaration and maybe re-implement the Proxy things ...

It’s not a goal of this project to be 100% standard compliant, there’s JSDOM for that goal … I think I remember why indeed I didn’t use cssom internally, neither I’ve exposed that class externally.
as performance here matters more than standard compliance, what is your use case for having cssom available? If the answer is test then I’m afraid I’m not keen to accommodate that use case with changes that might both break and will slow down this project.

I'm trying to re-implement a (compliant like) getComputedStyle for linkedom... but this means to implement a document.styleSheets that imply a way of loading/parsing <styles>s and <link rel=stylesheet>s and manipulate CSS classes.

I agree with you that's not the scope of linkedom (It's why I try to do it externaly from the library

I'm aware of JSDOM and other huge environments, but linkedom is fast! And so simple, no extra features, and that's good! Just need need a basic CSS cascade resolver (that I did BTW, it's working bacause it use only W3C DOM specs and linkedom is fairly compliant on 99% ;) )

it's fast because I've pushed back on many similar requests (it misses just this, it misses just that, this should be more standard, ... and so on) but you gave me an idea around getComputedStyle as it passes through the windows proxy and it might be a decent guard to bootstrap more complex logic around CSS, hence use cssom when that's required.
I'll think about it, but not immediately.

Well, I'm not sure if you took it hard (I'm not english native)... If it's the case please apologize!
I did not asked you to add this or that nor to be more W3C compiant ! :)
I just asked "why not" exporting some already used bits... in fact, it is possible to just re-export cssom's exports, but as is, it could lead to unexpected weird bugs when using .style .
The idea behind my request was to be able to code a custom getComputedStyle for my project... not to be integrated in linkedom not make you work on it ! ;)
And finaly... I may still work on this on my side (the same it's not my priority), if you want I may share future stuff / investigation here...
PS: The issue was more a way to communicate than a real issue though !

it passes through the windows proxy and it might be a decent guard

I did'nt get why passing through the proxy is "a decent guard" ?

Apologies I’m not native English neither, let’s try to assume best intents from both side 😉
a guard meaning I can intercept the usage/need of getComputedStyle via the proxy and enable only when accessed a better cssom integration/story for style attributes and CSS parsing/behavior.
I’m short on time these days but I’ll have a look

OK, I took the time to give cssom a shot and here's what's problematic:

the style can be an observed attribute so I need to be able to pass through this project logic to trigger changes when any style.thinghy is mutated, in case it's observed
this means that I cannot use cssom CSSStyleDeclaration constructor out of the box, I still need to wrap it as Proxy so I gain nothing but a third party dependency on this module own logic
the CSSStyleDeclaration in cssom is a bit outdated ... it doesn't react to properties such as style.backgroundColor = ... because it doesn't use a proxy and it doesn't normalize those properties
the only reason I use cssom is to parse CSS for <style> elements but here's the catch:

the sheet of a style element is a StyleSheet, not a CSSStyleDeclaration
because of previous point, there's literally no issue in using my own classes for different purposes/goals
I'd rather hide the detail behind <style>.sheet than harakiri myself in augmenting and wrapping a 3rd party module as nothing it offers is interesting for LinkeDOM logic

I am skeptic about exporting cssom because of the CSSStyleDeclaration class conflict but, most importantly, because cssom doesn't know anything about this module and doesn't offer me any hook to react to changes or mutations, it would be an hazard to expose logic that won't be reflected (Mutation Observer or anything else) within this module.
Last, but not least, bundled files like the worker.js can't benefit from trrr-shaking if I export all cssom when I need, in fact, only its parser, so that's another no-go from my side.
Accordingly with these findings and blockers, the only escape hatch I can think about is to offer an export linkedom/cssom that just points at cssom and that would be it: you can use the same module exported in here + you areon your own with extra logic ... would that work?

I can to almost the same conclusions:

I undestood the role of linkedom's CSSStyleDeclaration being binded to the ownerNode...
CSSOM is outdated fro W3C, and more complicated not maintained! The author claim some money to anything related to NV/CSSOM. There forks and notably 1 that is maintained and has integrated last PRs it's rrweb-io/CSSOM > npm i rrweb-cssom but I feel that dependency as potentialy problematic in future...

This made me search at other CSS parsers, some are promising (CSSTree, postcss) but exports custom AST and not an OM with names close to W3C CSSOM... It would require to rewrite a class sctructure and transform AST to this structure (too heavy dev, maybe a brand new linkeCSSOM ;) ).

So I came to the question:
Why parsing <style>.sheet tough? Is it so needed for SSR? (I'm not used at every frameworks like react, et cie) Can't it be removed, removing the same way 3rd party dependency. Just disclaim that CSS parsing is a user-land feature...

Why parsing


Nullable

some work on #112

Failures are in test classes where we're deliberately triggering NullPointerExceptions. Trying to figure out how to exclude those for now.

Once again:

[WARN] JavaNCSS got an error while parsing the java file /home/travis/build/GoogleCloudPlatform/appengine-plugins-core/src/main/java/com/google/cloud/tools/managedcloudsdk/components/WindowsBundledPythonCopier.java

ParseException in STDIN

Not sure what's going on here.

Apparently a known issue:
https://github.com/cobertura/cobertura/issues/176
We might have to choose between cobertura and lambdas.

FWIW, jacoco doesn't seem to have issues with lambdas.

Codecov Report

Merging #599 into master will decrease coverage by 0.3%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
- Coverage   75.53%   75.23%   -0.31%
==========================================
  Files         100      100
  Lines        2330     2346      +16
  Branches      341      343       +2
==========================================
+ Hits         1760     1765       +5
- Misses        424      433       +9
- Partials      146      148       +2

Impacted Files
Coverage Δ

...ppengine/cloudsdk/CloudSdkAppEngineDevServer1.java
87.76% <ø> (-0.72%)
:arrow_down:

...oogle/cloud/tools/libraries/json/CloudLibrary.java
100% <ø> (ø)
:arrow_up:

...e/cloud/tools/appengine/cloudsdk/GcloudRunner.java
80% <ø> (ø)
:arrow_up:

...e/cloud/tools/appengine/cloudsdk/CloudSdkAuth.java
78.57% <ø> (ø)
:arrow_up:

...l/process/ExitCodeRecorderProcessExitListener.java
100% <ø> (ø)
:arrow_up:

...n/java/com/google/cloud/tools/project/AppYaml.java
91.66% <ø> (ø)
:arrow_up:

...gedcloudsdk/install/UnixInstallScriptProvider.java
100% <ø> (ø)
:arrow_up:

...google/cloud/tools/project/ProjectIdValidator.java
92.3% <ø> (ø)
:arrow_up:

...ine/cloudsdk/CloudSdkAppEngineFlexibleStaging.java
37.5% <ø> (ø)
:arrow_up:

...aries/json/CloudLibraryClientMavenCoordinates.java
100% <ø> (ø)
:arrow_up:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002b75e...209ca6a. Read the comment docs.


Dev Test: circuit-construction-kit-dc/1.0.0-dev.87

@kathy-phet would like a stable dev version of CCK for AAPT.  In https://github.com/phetsims/circuit-construction-kit-dc/issues/76#issuecomment-316846045 we published dev.87 with numerous fixes.  It would be good to know if there are any severe issues or "gotchas" (or new issues) for @kathy-phet to know about at the conference.  It will also be good to get some initial dev testing for this sim.  Reassigning to @ariel-phet for additional instructions, prioritization, delegation, adding other labels as appropriate, etc.
Let's test on the following:

[ ] Windows Chrome (top priority)
[ ] iPad2

@phet-steele given the short timeline before AAPT this should be top priority.
Please look for "normal" use case issues first (ie don't worry about trying to find multitouch problems or such).

I've finished testing. @phet-steele it's all yours.

@ariel-phet, testing for the sake of AAPT is done. Would you like to change the priority of this test to resemble that of a "normal" timeline, or close and wait for the next dev? (testing is largely done, couple more issues left to make but I don't think I'll be spending time looking for new issues until later next week)

I think close and wait for the next dev (since we are already in the 90's dev versions)


feat: fetch an entity configuration

Still needs testing

It would be great if we can get the error handling right with this library. That keeps being quite hard to do, with having error codes so you can handle the different error types in your application.

Any thoughts on that?

Yes, I would like to revisit that when the first alpha version is finished.


Fix ESM5/FESM5 build: spaces in the absolute path

If there are spaces in the absolute path of the library, the build will fail. In my case I replaced "dev" with "dev with spaces" and got following:

Produce ESM5/FESM5 versions
cp: no such file or directory: dist/package/esm5/src/
cp: no such file or directory: dist/package/esm5/.js
cp: no such file or directory: dist/package/esm5/.js.map
dist/package/esm5/ngx-ui-scroll.js → dist/fesm5/ngx-ui-scroll.js...
[!] Error: Could not resolve entry module (dist/package/esm5/ngx-ui-scroll.js).
Error: Could not resolve entry module (dist/package/esm5/ngx-ui-scroll.js).
at error (/Users/dhilt/dev x/ngx-ui-scroll/node_modules/rollup/dist/shared/rollup.js:5211:30)
at ModuleLoader.loadEntryModule (/Users/dhilt/dev with spaces/ngx-ui-scroll/node_modules/rollup/dist/shared/rollup.js:18275:16)
at async Promise.all (index 0)
Error: FESM5 version failed

This PR fixes the issue. Initially it had been discovered here, but I improved the suggested solution.

@dhilt Thanks!


updating package.json with latest stable API version for chalk

updating package.json with latest stable API version for chalk
forcing colorful formatting for chalk when app starts

commiting this due to a similar PR request on generator meanjs project.

@ilanbiala it's better to put it in config/init.js

Why force set it at all, it is automatically detected?

In my console, it wasn't although it previously did detect it automatically, so I'm thinking maybe something changed with the detection settings in chalk.

@lirantal what system? My Mac 10.9.5 works fine without it.

I'm running an Ubuntu 14 with an XTerm. It did use to work before... I can't say for sure what changed.

Can you look at this issue and see if you have a similar problem?

Thanks, that sheds 'some' light, not really sure.
If I run 'grunt' I don't get the colors (which I assume thats what the issue you were referring to mentions with piping input to the script), but rather if I run 'node server.js' then it works.
Thing is, I do recall that I had colors when running just grunt, and for you it works if you run just grunt and remove the color forcing, right?

Yeah it works. Have you tried on 0.4.0?

No I didn't. What do you think, should we keep it without forcing the colors or should we?

I think we shouldn't force the colors for everyone if most people's machines don't need it.

@ilanbiala I had some issues squashing commits here due to already pushing this branch to github apparently. Anyway, I just submitted a new PR for the package.json change and will close this one.
new PR: https://github.com/meanjs/mean/pull/457


Added my entry with the details including the microtasks link

Signed-off-by: Ramya Kappagantu<EMAIL_ADDRESS>

Hi @ElizabethN ,
Could you please check if this PR can be merged without any conflicts. I've noticed one earlier and updated it.

Looks great to me, @RamyaKappagantu! Merged successfully :+1:


New engine!

@keybase/react-hackers bump

@keybase/react-hackers bump please

not for this PR, but in the future we might want rpc functions able to return something that can be used to cancel them later.

👍 Do I get a 🍪 ?

👍

Epic! :+1: % style comments

@MarcoPolo @chromakode https://github.com/keybase/client/pull/3953/commits/c71e3070f3da99db9f3c716f7e34c786ab966a03 addresses your pr comments and then i rebased after. can i get one more thumb then i'll merge

Updates look good! :+1:
Re: makeEngine calls, I didn't notice any for the mobile code. Is that TBD?

no lemme fix that tnx

sadly i have to update react/react-native on the rn side so we can get pure components for the profile updates

@chromakode @MarcoPolo updated w/ mobile fix

:+1:


[firebase_crashlytics] make sure the keys are actually added to the returned map

Description
In the 'prepareKeys()' method the keys needed to be added to a map that is being returned. In the method there's an iteration over the keys, but the keys are not added to the resulting map. This leads to the issue that custom keys are not being reported to Crashlytics. This PR fixes that.
Related Issues
Fixes flutter/flutter#32873
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Thanks so much for your contribution. I've added tests to your PR. In the future please try to include tests -- it really saves us a lot of time reviewing.


Add Keboola vendor

First PR will add only sources that exist in the connector catalog. Keboola still has 85 connectors that are not in the data/sources. And more we will officially publish soon.

@PoulpiFr I finally found some time to do this, ran the check and all looks good. I only added connectors that are in the data/sources for now.
I will add missing sources in an upcoming PR, in this case should I bulk add them, or one by one, or group them somehow? There is around 80 extra sources to add (some i might skip because they are niche)

@bakobako > I guess that in order to lower the "fixed cost" of opening/reviewing/... a PR, it would be better, at least on my side, to batch them into large PR, it can be a single one if you can do it all at the same time or several medium ones!


Non-UTF-8 filenames silently use replacement character.

When attempting to write a filename containing invalid UTF-8 bytes, it silently interprets the bytes as the replacement character.
e.g. echo x > $'\x80.txt'
All such filenames are treated as identical, and a directory listing returns the filename as \xef\xbf\xbd.txt
Incidentally, filenames created in Windows with invalid surrogates are also returned in directory listings as the replacement character, and the file cannot be accessed from WSL. I don't know if this should be considered as a separate issue or not.
On a real Linux system, in at least one scenario where allowing the filename to be round-tripped is impractical (VFAT filesystem mounted with option iocharset=utf8 - I have not investigated NTFS or CIFS), attempting to create such a file results in an error status [EINVAL] from open(2).

@therealkenc

@therealkenc
[pretty screencap]

Well that's awkward. You didn't provide your version number, distro, or an strace log per the deleted issue template either. But alright. I think I know what is happening here. Dropping the need-repro tag on house rules.

Incidentally, filenames created in Windows with invalid surrogates are also returned in directory listings as the replacement character...I don't know if this should be considered as a separate issue or not.

That's not a bad question. In the context I think that part is "correct", given what is being returned by getdents(). GNU ls and the Windows Console are just following orders. If you do the same ls with (say) xterm you'll get a similar funky character displayed.

@therealkenc Sorry :smile:
For my repro: 17763, 18243. Distribution-agnostic. The invalid character is making it out through the system call:
$ strace touch $'\x80'
openat(AT_FDCWD, "\200", O_WRONLY|O_CREAT|O_NOCTTY|O_NONBLOCK, 0666) = 3
                   ^^^
...
$ strace touch $'\x81'
openat(AT_FDCWD, "\201", O_WRONLY|O_CREAT|O_NOCTTY|O_NONBLOCK, 0666) = 3
                   ^^^

(and if you actually have a file called \x80.txt, lxss returns it from getdents as \xC2\x80)


Petri compiler

See /examples/petri/petri_compiler.jl for code that does codegen to create a much faster implementation of the petrinets.

I have the compiled version at 2 orders of magnitude faster than the interpreted version.