NoMethodError: undefined method `reload' for nil:NilClass

trying to remove an object with tags throws this exception:
irb(main):017:0> a = Article.find 7002
irb(main):018:0> a.destroy
NoMethodError: undefined method reload' for nil:NilClass 	from /home/nikeita/fastroad/shared/bundle/ruby/2.1.0/gems/acts-as-taggable-on-3.4.2/lib/acts_as_taggable_on/tagging.rb:36:in remove_unused_tags'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.6/lib/active_support/callbacks.rb:424:in block in make_lambda' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.6/lib/active_support/callbacks.rb:221:in call'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.6/lib/active_support/callbacks.rb:221:in block in halting_and_conditional' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.6/lib/active_support/callbacks.rb:86:in call'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activesupport-4.1.6/lib/active_support/callbacks.rb:86:in run_callbacks' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/callbacks.rb:292:in destroy'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:263:in block in destroy' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:329:in block in with_transaction_returning_status'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/connection_adapters/abstract/database_statements.rb:199:in transaction' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:208:in transaction'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:326:in with_transaction_returning_status' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:263:in destroy'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/persistence.rb:167:in destroy!' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/associations/has_many_association.rb:112:in each'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/associations/has_many_association.rb:112:in delete_records' ... 25 levels... 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.6/lib/active_record/transactions.rb:263:in destroy'
from (irb):18
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/commands/console.rb:90:in start' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/commands/console.rb:9:in start'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/commands/commands_tasks.rb:69:in console' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/commands/commands_tasks.rb:40:in run_command!'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/commands.rb:17:in <top (required)>' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/app_rails_loader.rb:43:in require'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/app_rails_loader.rb:43:in block in exec_app_rails' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/app_rails_loader.rb:32:in loop'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/app_rails_loader.rb:32:in exec_app_rails' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/lib/rails/cli.rb:5:in <top (required)>'
from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/bin/rails:9:in require' 	from /home/nikeita/fastroad/releases/132/vendor/bundle/ruby/2.1.0/gems/railties-4.1.6/bin/rails:9:in <top (required)>'
from bin/rails:16:in load' 	from bin/rails:16:in 'irb(main):019:0>

I'm having this problem. Where do I put this piece of code?
ActsAsTaggableOn::Tag.find_each do |tag|   ActsAsTaggableOn::Tag.reset_counters(tag.id, :taggings) end

It should only be needed if you are modifying the database outside of the application.
I run it as part of a rake task that imports data from a db backup:
https://github.com/txstate-etc/signup/blob/3a1bbcc/lib/tasks/db.rake#L60


Reverse proxy feature

Reverse Proxy
Description
Adds support for reverse Proxies.
This Feature would allow Hosters to use services like Cloudflare Spectrum to hide their Origin IP and protect themself from malicious Attacks.
Note
I am really sorry, but I didn't had the Time to check if this completly works. The only thing that would need to be updated is the Server Registration Request from the Server to the MasterServer with a new query called host. The host can be null.

After a bit of research and other stuff, this would also need a Server side mod which determins the origin IP of the User, incase of IP-Bans being added. (This may depend on the service.)
For Cloudflare Spectrum refer to this

While this is something we are looking to support eventually, it will not be implemented with the current API. We will consider alternative ways to handle this in the future.


Parser does not detect other commodity in included files

My structure is main.ledger will include 2021.ledger, but when I went into 2021.ledger, the numbers does not seemed to be recognized. I mentioned RM as commodity within main.ledger.

First off, treesitter does not work across files, so there's nothing we
can do about something being declared in a different file.
Also, it's only a parsing library, so it has no notion of "this has been
defined elsewhere", it only cares about the grammar of the language.
Could you give me a short snippet that shows what's going wrong and tell
me what you expect to be different?
I see no issue here with
2021-08-11
     Groceries  3 RM
     Bank

A sample I have, I tweaked the name a bit but it is a real record.
05-24 * Veggie Restaurant  ; 粽子
        expenses:food                                 RM 30.00
        assets:cash

I see, the issue is not that the amount is not highlighted, it's that
parsing fails earlier, in this case at the date, which is (currently)
invalid.

Oh I didn't know about that. Shouldn't it ignore the date if it fails to parse? I think we could at least put a fallback with [^ ]+ for the date maybe to skip it if it fails?

Shouldn't it ignore the date if it fails to parse?

No, since the rest of the transaction makes no sense without a date first. I don't think that treesitter can recover from that, just like (;;) makes no sense without a for first in C.

I think we could at least put a fallback with [^ ]+ for the date maybe to skip it if it fails?

I don't think so, otherwise we'd need fallbacks for everything. Also, for dates in particular, see 0cdeb0e51411a3ba5493662952c3039de08939ca.


[Bug] [GitHub Plugin] ExtractApiPullRequestCommits throwing JSON error

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Running the GitHub pipeline on a few repos throws "unexpected end of JSON input" on this line. This is being caused by the "nil" row.Input which the code tries to deserialize.
What you expected to happen
row.Input should not be nil
How to reproduce
here's one repo that I used that threw this error, but this probably happens elsewhere too. Just run the GitHub pipeline on it and the JSON error mentioned above will show up on the UI.
Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

FYI @klesh


[1.30.0] Revert 6062 - restore -Zunstable-options for rustdoc

This reverts commit 2131e5a253a5490c0ec478c9940193a48eff664c, reversing
changes made to 8dd0b1cc1980f00c94d661d5ccd9d31ac560302e.
Reverts #6062 since edition is destabilized on stable.

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

 Warning

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.30.0. Please double check that you specified the right target!

@bors: r+

:pushpin: Commit 6d6f40ae44e33fdbc9ddda73685c561904f8d515 has been approved by Eh2406

@bors r+ p=50

:bulb: This pull request was already approved, no need to approve it again.

:hourglass: Testing commit 6d6f40ae44e33fdbc9ddda73685c561904f8d515 with merge 3777f63d6f6e07f836cf1d5f56c7869b2e5e9141...

:pushpin: Commit 6d6f40ae44e33fdbc9ddda73685c561904f8d515 has been approved by Mark-Simulacrum

:hourglass: Testing commit 6d6f40ae44e33fdbc9ddda73685c561904f8d515 with merge 36d96825d0f288c6d1bb2219919a277968bd365f...

:sunny: Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 36d96825d0f288c6d1bb2219919a277968bd365f to rust-1.30.0...


strhash replacement -- improve hashing of large strings by 10x or more

A non-OIIO app that happens to use OIIO's ustring extensively was performing badly when dealing with an absurd number of very long strings. We experimentally found that our Strutil::strhash (and therefore all the underlying hashing for ustring) was a primary culprit.

Add Google's farmhash (MIT license) and update our prior use of xxhash to a more modern version that includes a nice fast 64 bit hash.

Lots of benchmarking indicates that old strhash was the worst of the bunch.

Settled on farmhash as the best replacement for strhash's guts.  For extremely short strings, it's slightly slower than the old implementation, but the crossover point is ~6 chars, and the longer the string, the bigger the speedup.  It's well over 10x faster than the old implementation for long strings (100-500 chars).

LGTM


No GUI interaction for any executables and no RDP

Windows Build Number
[Version 10.0.19043.906]
WSL Version
wsl 2
Distro Version
kali linux rolling 2021.1
Other Software
RDP
Wireshark
Chromium
Any tool requiring GUI access
Repro Steps
RDP:
start xrdp on kali instance
RDP through windows application
Wireshark/Chromium/Other:
run from terminal
setting $Display:
export DISPLAY=$(cat /etc/resolv.conf | grep nameserver | awk '{print $2; exit;}'):0.0
Expected Behavior
RDP:
launch desktop
Chromium/Wireshark/OtherApplication:
launch application with GUI
Actual Behavior
RDP:
Displays gray screen with error message "a problem has occurred and the system can not recover..."
WireShark:
11:51:17.599     Main Warn could not connect to display
11:51:17.599     Main Info Could not load the Qt platform plugin "xcb" in "" even though it was found.
Chromium:
[2594:2594:0410/115149.240217:ERROR:browser_main_loop.cc(1390)] Unable to open X display.
Gimp:
Cannot open display:
Maltego:
/usr/share/maltego/bin/../platform/lib/nbexec: WARNING: environment variable DISPLAY is not set
Diagnostic Logs
No response

mostly sorted after a fresh install and a lot of trial and error


Is this line valid?

https://github.com/peter-kish/gloot/blob/7f86281808b230d20f92ae6b84944df4b7dfa46e/addons/gloot/inventory_item.gd#L30-L31
Is this line have a possibility of getting triggered? Because old_prototype_id is set as prototype_id, in line 31 there's an if statement for that, when is that if expected to be called?

Yup, the whole function looks super wrong. I probably did some refactoring at some point and messed it up.
What I wanted to do is probably something like this:
if new_prototype_id == prototype_id:
    return
reset_properties()
prototype_id = new_prototype_id
update_configuration_warnings()
emit_signal("prototype_id_changed")

I will do some testing with this code above and then push a fix asap.

Should be fixed in 535945b70bb94fa03bc0fa1f90fed9a61346f3ed


Force nightly Dask install for upstream testing

It looks like our scheduled Dask nightly testing is sometimes failing to update to nightly Dask packages:
https://github.com/dask-contrib/dask-sql/actions/runs/3625488882/jobs/6113589823
This PR refactors the relevant workflows to more explicitly update to nightly Dask using the -c dask/label/dev option

Codecov Report

Merging #960 (daff53a) into main (8e61d0c) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   76.91%   76.67%   -0.25%
==========================================
  Files          73       73
  Lines        4115     4115
  Branches      751      751
==========================================
- Hits         3165     3155      -10
- Misses        782      785       +3
- Partials      168      175       +7

Impacted Files
Coverage Δ

dask_sql/physical/rex/core/literal.py
58.09% <0.00%> (-2.86%)
:arrow_down:

dask_sql/physical/rel/logical/window.py
95.37% <0.00%> (-1.74%)
:arrow_down:

dask_sql/_version.py
32.76% <0.00%> (-1.13%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Looks like the nightly upstream tests failed: https://github.com/dask-contrib/dask-sql/actions/runs/3634926449. Curious why it didn't show up during [test-upstream] in this pr

My best guess is that it worked successfully back when the command was mamba update -c dask/label/dev dask, which I guess works properly with the strict channel priority compared to just a straight install of dask/label/dev::dask?
cc @jakirkham in case you have any insight here on if this would be expected behavior for strict channel priority


fix(build-common): Update base API-Extractor configs to include tsdocMetadata to ensure cross-package trimming is handled correctly

API-Extractor uses the presence of this file in an npm package to determine whether or not its API members should be considered when making decisions about reports and rollups in consuming packages.
This includes determining whether or not release tags on external members should be respected when making trimming decisions.
We need to ensure this is enabled so that re-exports of API members across package boundaries are correctly trimmed based on their release tags.

As much as I disagree with the design of this policy, it is how API-Extractor currently works.
I've confirmed that manually adding the tsdocMetadata files to protocol-definitions in node_modules results in correct trimming in azure-service-utils, who re-exports ScopeType from the former package.

Follow-up PR #20394


08/08/2018 17:46 : Create Pull Request for branch master -> prTesting1_2018080817

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


mongoclient >= 3.0

with this version 3.0 of mongoclient (mine), i have to init options with :
options.search = {value : ""};
for not having assert error !
even with this line, using the sample code, i have the foowing result :
{
  "draw": 0,
  "recordsTotal": 0,
  "recordsFiltered": 0,
  "data": [],
  "error": "Columns must be defined!"
}

very strange !

Hi @franckFleet,
Sorry for the late response, I think this module is working fine with mongodb native driver v3. I added the example of using this module with mongodb native driver v3 on the README.
I will close this issue, feel free to re-ope if further issue comes up.


WIP oauthclient: add cascading action of token

Adds cascading action on relationship from token to client.
(addresses #3218)

Signed-off-by: Leonardo Rossi<EMAIL_ADDRESS>

ping @jirikuncar

It depends on https://github.com/inveniosoftware/invenio/pull/3314

@hachreak has it been integrated in invenio-oauthclient completely? If yes, please close this PR. Thanks

Solved in https://github.com/inveniosoftware/invenio-oauthclient/blob/master/invenio_oauthclient/models.py#L148


The server automatically acknowledges notifications with the wrong source

Step to reproduce:
Generate a N2K frame like below:
echo '2017-04-15T15:21:02.280Z,7,65288,204,255,8,3b,9f,ff,01,15,01,00,00' | socketcan-writer vcan0
It's alarm notification PilotWindShift going under /signalk/v1/api/vessels/self/notifications/autopilot/PilotWindShift
In my case, it's produce 2 sources one for vcan0.204 with level state alarm and one for vcan0 with level state normal
The second source vcan0 is created 10 seconds after.
All my plugins are disabled with export DISABLEPLUGINS=1
If I send the frame every 2 seconds, the second source is not created.
When I stop sending, 10 seconds after the second source is created.

Closed via #981


Error: Failed to init hasura client

When I try to start nhost server either with host dev or nhost up I get an error
Error: failed to init hasura client: fork/exec /Users/<my_user>/.nhost/hasura: exec format error
I am on Nhost cli v0.8.6
Can you please help me with this?

fixed by removing the hasura binary under ~/.nhost


ARROW-7794: [Rust] Support releasing arrow-flight

I tested this by running cargo publish --dry-run --allow-dirty from the arrow-flight directory as well as running cargo test from this directory and from the root of the rust workspace.

Thanks @nevi-me.
CI error is unrelated so I'll go ahead and merge.


Update Heroku deploy docs to include new integrations (NewRelic, Celery, Opbeat, Sentry)

maybe the documentation can be simplified using this[1] heroku cli plugin
[1] https://github.com/ddollar/heroku-config

Newer heroku config plugin: https://github.com/xavdid/heroku-config


[tech debt] ICON_DEFAULT looks hard code

vim src/plugins/catalog/model.go +24 goto the ICON_DEFAULT, we'd better make the value configurable or generate the image auto.

plain text with base64 encode png would be great.

the backend shouldn't serve the static content, let's move the image to frontend and return an none byte to frontend.

@vitan the reason why store a icon in DB is that we should make api works without frontend provided.


GDAX brokerage updates

Description

Fixed websocket authentication failure for "user" channel
Removed "matches" channel, now using authenticated "user" channel for order fills
Send BrokerageMessageEvent as Error instead of Warning for subscription and authentication failures

Related Issue
Closes #3709
Closes #3527
Motivation and Context

Occasionally missing order fills
Error in algorithm logs: Failed to subscribe - user channel requires authentication

Requires Documentation Change
No.
How Has This Been Tested?

Local and cloud testing with real trades with both total and partial fills.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

🎉 wa hoo!


'Project' object has no attribute 'team'

Crashing on sentry with this issue

Just use another fork, for example pip install https://github.com/pointcz/sentry-mattermost/archive/master.zip


setup install-first-user

Would do a create-admin-role and then put the first user in it.

instead create the admin role on install.


Print a warning when a linter panics

Fixes #299

I think we'll abandon this one. Maybe we can revisit it later.


Create RichTextArea for editing html text

Notes
RichTextArea currently allows for basic formattings such as Bold, Italic, Underline, Font Size, Font Face, Justification, Indenting etc. It does not currently support Links and Images but these can be added.

moved here https://github.com/foam-framework/foam2/pull/2078


Make 'mdc-select' style backward compatible

With new styling to 'mdc-select' we are displaying the placeholder. In few instances we do not want to show placeholder for select . We should probably add a config property to turn on/off the placeholder.

Researching clean approach to hiding placeholder. Will post pics.

Floating label on

Floating label off


Cannot login (self-hosted or x2.email)

I cloned the repository and got things running on a Debian container, but as soon as I click the "Connect to Cloudflare" button, nothing happens. When I load other pages, I see status messages like this:
- wait compiling /login/page (client and server)...
- event compiled client and server successfully in 3.1s (2615 modules)

But after clicking the "Connect to Cloudflare" button, I dont see anything change. The page isnt trying load, nothing.
I tried the same tokens on x2.email and had the same result. As a final check, I tried Firefox (vs Chrome), and also got the same result.
I have verified the api token has the correct permissions and that I am using the correct account/zone ids.
Any ideas?

I haven't tried Debian containers. Could be something there.
Try debugging the authorize function in UserContext.tsx to see what happens there. Or the onSubmit in Authentication.tsx.


fix: missing project reference from test project to client project

Description
Add the missing reference to the project file
Related issue(s)
Fixes: #177

/rtm


ARM Template Extension: Mapping JSON files to JSONC breaks IntelliSense

I currently map the "JSON with Comments" language type to *.json to allow editing of ARM templates without flagging comments as errors. When I do this, IntelliSense for the ARM template does not suggest completions. I can't find a setting that looks like it would let me override this behavior.
Steps to Reproduce:

Install a fresh copy of VS Code and install the ARM Tools Extension.
Add the following to the User Settings and reload VS Code:
{  "files.associations": {      "*.json":"jsonc"  } }
Load an ARM template and attempt to auto-complete a parameter, variable, etc. IntelliSense window will not appear.
Comment out the line above and reload, functionality returns.

@erictorbenson Do you use the https://marketplace.visualstudio.com/items?itemName=msazurermtools.azurerm-vscode-tools?

Yes I do, version 0.4.0.
<EMAIL_ADDRESS>From: Martin Aeschlimann<EMAIL_ADDRESS>Sent: Wednesday, May 2, 2018 12:13
To: Microsoft/vscode<EMAIL_ADDRESS>Cc: Eric Torbenson<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode] ARM Template Extension: Mapping JSON files to JSONC breaks IntelliSense (#48696)
@erictorbensonhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_erictorbenson&d=DwMCaQ&c=tv8X2YgD7mG0v9N2vuBcgw&r=LPefAnwnvx3Cm_UFS1wr14kv90dZrM3BXLqdEeO2D3s&m=kHcaDTGiNEzrFL7kVYnDV-GGOKzbms1aBZ-sLC6DjwI&s=XtbwD7pft54ziNwAGI-b_ye7ODOjtgVDFyhj_dHK1ic&e= Do you use the https://marketplace.visualstudio.com/items?itemName=msazurermtools.azurerm-vscode-toolshttps://urldefense.proofpoint.com/v2/url?u=https-3A__marketplace.visualstudio.com_items-3FitemName-3Dmsazurermtools.azurerm-2Dvscode-2Dtools&d=DwMCaQ&c=tv8X2YgD7mG0v9N2vuBcgw&r=LPefAnwnvx3Cm_UFS1wr14kv90dZrM3BXLqdEeO2D3s&m=kHcaDTGiNEzrFL7kVYnDV-GGOKzbms1aBZ-sLC6DjwI&s=ejzlLUcT1xMjjBFd91O5RjU3mjJTA5SRqRCtjSZGqCM&e=?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Microsoft_vscode_issues_48696-23issuecomment-2D386033324&d=DwMCaQ&c=tv8X2YgD7mG0v9N2vuBcgw&r=LPefAnwnvx3Cm_UFS1wr14kv90dZrM3BXLqdEeO2D3s&m=kHcaDTGiNEzrFL7kVYnDV-GGOKzbms1aBZ-sLC6DjwI&s=o5Ua9roK9CfLc51Td8npAst6PpeTFmWY5NSXD_dTuv8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ASl9hwplJpKQNUbHeqwG-5F1e6i1wgSTt9ks5tudsNgaJpZM4Tj4VN&d=DwMCaQ&c=tv8X2YgD7mG0v9N2vuBcgw&r=LPefAnwnvx3Cm_UFS1wr14kv90dZrM3BXLqdEeO2D3s&m=kHcaDTGiNEzrFL7kVYnDV-GGOKzbms1aBZ-sLC6DjwI&s=eQcvoSNyOPgOOcNukcqlNbLOyMpELsfwzCobRp_SYzc&e=.
Confidential Communication: The contents of this e-mail including any attachment are confidential and intended solely for the person(s) to whom they are addressed. Any reader of this email who is not the intended recipient is notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately and delete all copies from your computer system. Subsequent alterations to this email after its transmission will be disregarded.

This issue was moved to Microsoft/vscode-azurearmtools#100


Adding autoload support for traits (php>=5.4) to Zend_Loader

This is a small patch which updates Zend_Loaderto play nicely with traits.
The following changes were made:

split an isLoaded method out of loadClass to check if loading the
class, interface or trait was successful
added unit tests
keeping care of php versions <5.4

Please keep in mind: ZF1 is in maintenance mode where only bug fixes are accepted.

Version 3 is around the corner, so version 1 is the wrong place for new features.


Update class method in nodes.pyi stub

Add stubs for new method in class Node.

Fun fact: this was added to 0.21 but never made it to this Git repo.

Oh right, I didn't notice 0.21 isn't here...

OMG... I also missed the code for 0.21...

Thank you for your contribution!


Even with Superuser Access, users can't add label for any projects(even for own project)

Hi,
User with Superuser access cannot add/remove labels for own projects.
Thanks,
AN

It works well in my machine. Please give more information.

Dev server using: python manage.py runserver
I have created a new user, with superuser permission. Whenever, I try to add/remove a label, I get this message on console:
Forbidden: /api/projects/2/labels/
Also, note if I make the user a staff_user, I can then add/remove user

Please raise a new issue if you still face this phenomenon.


Not matching colors when using image()

When using image(C) to display the data in array C as an image, the default colors aren't matching.
C = [0 2 4 6; 8 10 12 14; 16 18 20 22];
image(C)

fig2plotly(gcf, 'offline', false);

The previous code prints the following message:
Unrecognized field name "DisplayName".
We had trouble parsing the image object.
This trace might not render properly.

Expected and generated (https://chart-studio.plotly.com/~xarico10/849/#/) plots:

Examples on using image(C) can be found on:
https://www.mathworks.com/help/matlab/ref/image.html#buqlsdw-2

fixed

fixed for both

modes


Promotional Offers introduced in iOS 12.2

Hello
Is there any plan that merchantkit supports "Promotional Offers"?

This will come soon. You can already access the discounts now, we just need a way to add them to a Purchase.


Scan results page: JS issue w/mobile menu

When a user has the categories expanded like this:

And is using the keyboard to tab through the the categories, if they hit "enter" to tab into a section, the categories menu is not closing when enter is being pressed. This is only happening via the keyboard, if someone is using a mouse to click the categories, a click event is happening. So we need an event for focusing and hitting enter that then closes the category menu.
Related to #640 but opening a separate issue to track as the other tasks under that issue are complete.

This issue is part of the formatter, so I'm moving this issue to the hint repo.


Fix SILCombine of pointer_to_address instruction

This change ensures the insertion point of the unchecked_addr_cast is after any copies/borrows that OSSA rauw may create.
Before this fix we could end up creating invalid SIL where operands do not dominate its instruction.

@swift-ci smoke test

@swift-ci smoke test and merge


feat: onboarding ui improvements

Not done yet but maybe some early feedback.
https://github.com/user-attachments/assets/ca4e0a84-17b9-40de-905a-55ac931ca72c

Looks good! Not a massive fan of the gradient on the splash screen, but completely fine to keep it like this.

Update video. I think it's almost done. I'll probably pick up the branding/new name stuff in a diff pr.
https://github.com/user-attachments/assets/fec7418b-75cb-496e-958d-d7529caeb5e1


Add FileChatMessageHistory for persistent chat history storage

Implement FileChatMessageHistory to store chat history in a local file, providing a persistent storage solution for maintaining chat history across sessions and application restarts.

I found that this file-based chat history is beneficial for simpler applications. Moreover, it will aid in providing a more straightforward unit testing process for issue #3072, which I'm working to resolve.


[rv_core_ibex] Update to latest crash dump

Addresses some of the usability issues discovered in #12908
dependent on https://github.com/lowRISC/ibex/pull/1680
The crash dump is now more representative of where the first and second exceptions occurred.

LGTM, I just left a few minor comments.

Please review the order of words in the crash dump. @engdoreis pointed some, and the crash dump is declared as typedef struct packed { logic [31:0] current_pc; logic [31:0] next_pc; logic [31:0] last_data_addr; logic [31:0] exception_addr; } crash_dump_t; So exception_addr is at offset 0 and current_pc at offset 3.

i think you're looking at a stale one. the latest one is here (https://github.com/lowRISC/opentitan/blob/master/hw/vendor/lowrisc_ibex/rtl/ibex_pkg.sv#L20)
I also will probably, as @GregAC suggests, explicitly name these mtval and mepc to be more explicit.


feat(npm-publish): add option to specify npm registry

Hello,
I've came across your quite useful package for releasing NPM packages with nx but I found myself stuck with an issue with the current version.
In my company, we are currently using our internal NPM registry and not the public one.
As I was browsing through your package, I noticed that the .npmrc file was updated when performing release and the following line was added:
//registry.npmjs.org/:_authToken=${process.env.NPM_TOKEN} .
The thing is, we also have to set this line but with a specific registry, being our internal registry and it should be done when performing releasing, not before, just like it is done right now.
With the current PR, I've added the possibility to specify a specific NPM registry through an environment variable called NPM_REGISTRY (it could be changed). If not provided, it defaults to the public NPM registry.
I'd be amazing if I could have your review on this ! :)
Thanks a lot.

Hi @canserkanuren thx a lot for this epic PR! The changes look good. Thx a lot for your contribution. Great job 👏

@all-contributors please add @canserkanuren for code ideas test

@kreuzerk is it also possible to run the release workflow, in order to have my update published on the npm registry ?
Thanks a lot ! :)

Hi @kreuzerk,
I've just noticed something when running the release script: to current .npmrc file that is in the project is actually overridden by the script (https://github.com/kreuzerk/nx-release/blob/main/libs/nx-release/src/executors/npm-publish/executor.ts#L14).
What do you think about modifying the current operator (being >) by >> in order to avoid having the current .npmrc file overridden ?
I am asking this because I'll have to specify other configurations in my .npmrc per package..
Thanks a lot for your answer :)


Simplify sequence of NOT operators

Summary of the changes / Why this improves CrateDB
This fixes the very specific bug scenario in https://github.com/crate/crate/issues/15265 but it is not complete.
Queries like (y is not null) is not null still fails. I think it is because NullabilityContext allows both of its fields useNotQuery and removeNullValues to be set to true which I am thinking need to be mutually exclusive instead.
Checklist

[ ] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

update: not taking this path as a fix for https://github.com/crate/crate/issues/15265 but maybe it will be good to look into this during the feature freeze.

Should be under the topic of scalar function normalization, no need to handle this separately.


keras.Model

Hello, when I test the code in 'https://stellargraph.readthedocs.io/en/stable/demos/node-classification/gcn-node-classification.html', I met a problem. When I run the following code:
model = Model(inputs=x_inp, outputs=predictions)
model.compile(
optimizer=optimizers.Adam(lr=0.01),
loss=losses.categorical_crossentropy,
metrics=["acc"],
)
The error is:
for i in range(len(node.inbound_layers)):
TypeError: object of type 'GatherIndices' has no len()
Is there a problem with the feeding data Model(inputs=x_inp, outputs=predictions)?

Hi, thanks for waiting. Unfortunately there isn't enough information for me to help here. Could you include what version of stellargraph and tensorflow you have installed (the output of pip freeze includes this)? Also, thanks for including the exact error message, it would also be really helpful to see the full stack trace.

Hi, thanks for waiting. Unfortunately there isn't enough information for me to help here. Could you include what version of stellargraph and tensorflow you have installed (the output of pip freeze includes this)? Also, thanks for including the exact error message, it would also be really helpful to see the full stack trace.


Fixed Meshes of bus, desertBoss, desertMedium and desertSmall

Description
A few fixes for issue #449
I have looked at:

bus - old:(https://imgur.com/GzDu3uS) new:(https://imgur.com/kNexlCB)
desertBoss - old:(https://imgur.com/DuPE8U2) new:(https://imgur.com/e7FAN4u)
desertMedium - old:(https://imgur.com/DpEKXtf) new:(https://imgur.com/L0jcuBT)
desertOrbiter - I think there's no need to change it since it is really small (https://imgur.com/QL35Boq)
desertSmall - old:(https://imgur.com/3DZNLCA) new:(https://imgur.com/RyAR03Q)

Can one of the admins please verify this patch?

Meh, since we are at it, do the Orbiter too for good measure. Also, please throw in a comment into the issue mentioning which ships have been checked so far, for easier maintenance.

New desertOrbiter: https://imgur.com/UBd3bvz

@GooeyHub add to whitelist.

Hooray Jenkins reported success with all tests good!

Tests out great!


Bug: all catalogs get x509 errors when using s3 snapshots on Rancher v2.3.2

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Setup HA Rancher installation v2.3.2 using your own set of private signed certificates.
create downstream cluster
setup s3 snapshots, use shorter snapshot periods and retention to reproduce faster

Result:
Observe when snapshots finally rotate through and delete the oldest snapshot that the catalog's in Rancher now have x509 errors.
Other details that may be helpful:
If you update the Rancher deployment it will delete the Rancher pods and fix the problem temporarily until the next time snapshots are cycled through.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.2
Installation option (single install/HA): HA

Reproduced the issue on 2.3.3
Steps:

Bring up a minio with self signed certs
On a rancher server with self-signed certificate that it generates, create an AWS cluster.
Enter the minio details for the S3 config in the cluster, and enter CA cert generated in Step 1 in field Custom CA Certificate
When the cluster comes up Active, after manual delete of snapshots or the automatic deletion of snapshot, on ADDITION of a new catalog like "https://charts.rook.io/beta, branch:master" gives the error. On refresh of existing catalog, NO error is seen.
The issue is also seen when the S3 settings are modified, i.e. change the bucket name. On Listing Snapshots, NO issue was seen.
Stop and start of Rancher server.
The catalogs recover and are seen Active. And Apps are available from these catalogs.

Verified on v2.3-head commit id: 430dd0bb3
Steps:

Bring up a minio with self signed certs
On a rancher server with self-signed certificate that it generates, create an AWS cluster.
Enter the minio details for the S3 config in the cluster, and enter CA cert generated in Step 1 in field Custom CA Certificate
When the cluster comes up Active, after manual delete of snapshots or the automatic deletion of snapshot, on ADDITION of a new catalog like "https://charts.rook.io/beta, branch:master" NO error is seen.
Modify S3 settings, i.e. change the bucket name in the cluster.
No error is seen on ADDITION of a new catalog like "https://charts.rook.io/release, branch:master" NO error is seen.

Closing the issue


problematic recursion in optparse() and optparse_long()

The use of recursion in these functions (particularly in the way it is used, which prevents tail-call optimization), leads to increasing stack usage for every non-option argument, and eventually stack overflow. The recursion should probably be removed to avoid this (setting a variable within the functions to indicate that the function has restarted, along with a goto to the beginning and some other refactoring, might be a solution).

Good catch! I'd like to fix this issue, and to help with that I just
pushed a test suite (f0c65c9) so that the parser can be changed with
confidence. (Or I can accept a patch with confidence.) I would have fixed
it at the same time, but it seems it's going to take longer than have time
to commit at the moment. It needs to track the first non-option index,
continuing hunting for the next option (without recursing), then permute
the option backwards (potentially two elements) to that first non-option
index.
The current code, and my description above, are also quadratic time. I
don't think that can be improved without allocating. Idea: Add a "scratch"
pointer where the caller can optionally supply a scratch argv that is at
least the same size as the input argv. If present, it will use the scratch
space to permute in linear time instead of quadratic. When it sees a
non-option, push its pointer onto the scratch buffer.

Could you assign me this issue?


0.3.0 release

Verison 0.3.0 [2020-02-06]

Dropped support python 3.5 and below
Dropped support django 2.1 and below
Dropped support openwisp-users below 0.2.0
Dropped support openwisp-utils 4.1.0 and below
Dropped support django-netjsongraph below 0.6.0
Added support for django 3.0

Signed-off-by: Ajay Tripathi<EMAIL_ADDRESS>Blocked by: django-netjsongraph 0.6.0 PyPi release

Waiting for django-netjsongraph to be published before merging

Coverage remained the same at 98.261% when pulling 77a8b08ec726e48091533118aecff5c0209b078b on atb00ker:master into feb76483f81226367b40fa42cb0359da51f64b6e on openwisp:master.

Pushed to check for changes, then merged as it was approved! :smile:


Documentation Update: ObservablePoint.ts

Description of change
Update docs for ObservablePoint.ts

fix - update documentation according to: #7159

I made the assumption that we're attempting to document the surface API and there was no need to expose _x and  _y internals. Please correct me if I'm wrong in this assumption.
Note: That there seems to be an issue with webdoc not properly inferring types from documentation on getters (and likely setters). Followed workaround provided by @bigtimebuddy here: https://github.com/webdoc-labs/webdoc/issues/100
Pre-Merge Checklist

[x] Documentation is changed or added
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Should be good to go. Please let me know if there are any issues.

Thanks for this @jrod-disco
@SukantPal would be really nice to have a look at these inference issues with webdoc.

Thank you @jrod-disco :tada:


Incept salty managed keys and post to KERIA

Still pending:

[ ] passing of ...kargs
[ ] improve identifiers.create method when arguments are null

Looks like the Manager is breaking the Habery. Do we even need Habery? Otherwise it looks good to me

Looks like the Manager is breaking the Habery. Do we even need Habery? Otherwise it looks good to me

It's not using habery at all. Where it breaks?

I found the error and fixed. Will be available in next commit

Fixed some errors and added rotation

tested and it work


python3Packages.mpv: 0.4.7 -> 0.5.2

Motivation for this change
Package upgrade.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116462 at c6e28f00 run on aarch64-linux 1

1 package skipped due to time constraints:

plex-mpv-shim

4 packages built successfully:

jellyfin-mpv-shim
python38Packages.mpv
python39Packages.mpv
sublime-music

2 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/mpv/default.nix:28:3:
   |
28 |   meta = with lib; {
   |   ^

warning: unclear-gpl
agpl3 is a deprecated license, check if project uses agpl3Plus or agpl3Only and change meta.license accordingly.
Near pkgs/development/python-modules/mpv/default.nix:31:5:
   |
31 |     license = licenses.agpl3;
   |     ^


[feat] Introduce a appDataDir path

Describe the problem
I am building an application using Tauri in which I would like to store some data in a file on the hard drive, so I was looking into the fs module. For available paths I have found this documentation. I feel like the correct path for storing my data on a linux system would be the dataDir path. However, this path only contains the path to the folder, without a folder for the application itself as in appDir, therefore I have to handle that on my own, which is a tedious task. Additionally I think that this is so common, that it would warrant another path preset.
Describe the solution you'd like
I would like to be able to use something like BaseDirectory.AppData, that stores data in a folder for my own application within dataDir.
Alternatives considered
No alternatives other than leaving it the way it is and handle that in the application itself come to my mind.
Additional context
No response

It would be worth considering a cohesive scheme for all the different app-specific directories - for example, config, data, cache, and probably others.
I would suggest:

appConfigDir (appDir would need to be kept as an alias for now to avoid a breaking change)
appDataDir
appCacheDir
I can't think of any others but maybe there are more?

Personally I think the current appDir is confusingly named anyway because I would expect it to point to the directory where the actual app is located, rather than to a config dir.

I agree current appDir is misleading and as long as we don't introduce a breaking change, this could be a good addition in v1.2. However I think we could just introduce appConfigDir as a separate function without aliasing so it could have a documentation and would include @since tag

logDir is another one that could be renamed to appLogDir to fit with the rest

Wow, that was fast! Thank you, everybody!


Updated logic to check for integers when entering target/budget price

Pull Request Template
script name - amazon-price-alert
What have you Changed
Updated logic to check for integers when entering target/budget price
previous PR didn't return value; this one does
Issue no.(must) - #276
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

This resolves #276
Please accept the PR.


Hadoop-17215. ABFS: Disable default create overwrite

Filesystem Create APIs that do not accept an argument for overwrite flag end up defaulting it to true.
We are observing that request count of creates with overwrite=true is more and primarily because of the default setting of the flag is true of the called Create API. When a create with overwrite ends up timing out, we have observed that it could lead to race conditions between the first create and retried one running almost parallel.
To avoid this scenario for create with overwrite=true request, ABFS driver will always attempt to create without overwrite. If the create fails due to fileAlreadyPresent, it will resend the request with overwrite=true.
This change will be guarded with a config if for any reason this behaviour needs to be reverted.
Tests for file and directory creations with and without overwrite along with file pre-existing or not combinations have been tested.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 15s
trunk passed

+1 :green_heart:
compile
0m 38s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 24s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
17m 35s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 27s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  5s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s
the patch passed

+1 :green_heart:
compile
0m 33s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 29s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-azure: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5)

+1 :green_heart:
mvnsite
0m 33s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 48s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 23s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 35s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

80m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6b7ce80be716 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6a49bf9bffb

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/1/testReport/

Max. process+thread count
424 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 11s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 34s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 26s
trunk passed

+1 :green_heart:
mvnsite
0m 41s
trunk passed

+1 :green_heart:
shadedclient
15m 25s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 45s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  8s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 26s
the patch passed

-0 :warning:
checkstyle
0m 18s
hadoop-tools/hadoop-azure: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
0m 56s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 29s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

77m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux caee03aec651 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6a49bf9bffb

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/2/testReport/

Max. process+thread count
454 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Test results from accounts in East US 2.
From HNS Enabled account with OAuth credential settings
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures:  [ERROR]   ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics:291->AbstractAbfsIntegrationTest.assertAbfsStatistics:445->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Mismatch in bytes_received expected:<143> but was:<311> [INFO]  [ERROR] Tests run: 453, Failures: 1, Errors: 0, Skipped: 74 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140
From HNS Enabled account with SharedKey credential settings
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [ERROR]   ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics:291->AbstractAbfsIntegrationTest.assertAbfsStatistics:445->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Mismatch in bytes_received expected:<143> but was:<311> [ERROR] Tests run: 453, Failures: 1, Errors: 0, Skipped: 41 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
From HNS Non-enabled account with OAuth credential settings
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures:  [ERROR]   ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics:291->AbstractAbfsIntegrationTest.assertAbfsStatistics:445->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Mismatch in bytes_received expected:<143> but was:<311> [INFO]  [ERROR] Tests run: 453, Failures: 1, Errors: 0, Skipped: 250 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140
From HNS Non-enabled account with SharedKey credential settings
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Failures:  [ERROR]   ITestAbfsNetworkStatistics.testAbfsHttpResponseStatistics:291->AbstractAbfsIntegrationTest.assertAbfsStatistics:445->Assert.assertEquals:645->Assert.failNotEquals:834->Assert.fail:88 Mismatch in bytes_received expected:<143> but was:<311> [INFO]  [ERROR] Tests run: 453, Failures: 1, Errors: 0, Skipped: 246 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
The fix for the failing test is tracked under: https://issues.apache.org/jira/browse/HADOOP-17229

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 59s
trunk passed

+1 :green_heart:
compile
0m 38s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 30s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 23s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
15m 43s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 29s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  2s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 59s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 34s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 34s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-azure: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 35s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

75m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 20928ef8a0c1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 75db5526b5d

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/4/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/4/testReport/

Max. process+thread count
421 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  5s
trunk passed

+1 :green_heart:
compile
0m 40s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 32s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 25s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
17m 24s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 25s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  0s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
checkstyle
0m 22s
the patch passed

+1 :green_heart:
mvnsite
0m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m  1s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 23s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

79m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 72954e7413bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 75db5526b5d

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/5/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

If the main purpose is to resolve the potential race condition, this fix seems not enough as the race condition can still happen in the retry process for the second "create with override" call in catch logic. And we introduce an extra call for create operation.
@snvijaya Is this PR tested and proven to be helpful?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
36m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m  3s
trunk passed

+1 :green_heart:
compile
0m 37s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 33s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
15m 16s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 28s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 54s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 17s
the patch passed

+1 :green_heart:
mvnsite
0m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  5s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 28s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

109m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 503e9408ad19 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 89428f142fe

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/6/testReport/

Max. process+thread count
429 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Non-HNS account with SharedKey
[INFO] Results: [INFO]  [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 246 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
Non-HNS account with OAuth
[INFO] Results: [INFO]  [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 250 WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140
HNS account with SharedKey
[INFO] Results: [INFO]  [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 41 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
HNS account with OAuth
[INFO] Results: [INFO]  [INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0 [WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 74 [WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
34m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 44s
trunk passed

+1 :green_heart:
compile
0m 40s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 33s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 25s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
18m 37s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 29s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  1s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 54s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 23s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 21s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

113m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 614f5a16b2a6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ce861836918

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/9/testReport/

Max. process+thread count
429 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Repeated the HNS tests:
HNS account with SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 41
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 24
HNS account with OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 457, Failures: 0, Errors: 0, Skipped: 74
[WARNING] Tests run: 207, Failures: 0, Errors: 0, Skipped: 140

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
28m 54s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 34s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 28s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
15m 25s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 28s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
the patch passed

+1 :green_heart:
mvnsite
0m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

98m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6a1edbe5151e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc2435cb5cf

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/10/testReport/

Max. process+thread count
414 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/10/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m  2s
trunk passed

+1 :green_heart:
compile
0m 41s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 35s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 27s
trunk passed

+1 :green_heart:
mvnsite
0m 43s
trunk passed

+1 :green_heart:
shadedclient
17m 10s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 31s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  2s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
checkstyle
0m 21s
the patch passed

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  3s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 24s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

79m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2246

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b61e07c1a5ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc2435cb5cf

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/11/testReport/

Max. process+thread count
422 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2246/11/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

commit e31a636e922a8fdbe0aa7cca53f6de7175e97254
Author: Sneha Vijayarajan<EMAIL_ADDRESS>Date:   Wed Aug 26 00:31:35 2020 +0530
HADOOP-17215: Support for conditional overwrite.

Contributed by Sneha Vijayarajan

DETAILS:

    This change adds config key "fs.azure.enable.conditional.create.overwrite" with
    a default of true.  When enabled, if create(path, overwrite: true) is invoked
    and the file exists, the ABFS driver will first obtain its etag and then attempt
    to overwrite the file on the condition that the etag matches. The purpose of this
    is to mitigate the non-idempotency of this method.  Specifically, in the event of
    a network error or similar, the client will retry and this can result in the file
    being created more than once which may result in data loss.  In essense this is
    like a poor man's file handle, and will be addressed more thoroughly in the future
    when support for lease is added to ABFS.

TEST RESULTS:

    namespace.enabled=true
    auth.type=SharedKey
    -------------------
    $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify
    Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
    Tests run: 457, Failures: 0, Errors: 0, Skipped: 42
    Tests run: 207, Failures: 0, Errors: 0, Skipped: 24

    namespace.enabled=true
    auth.type=OAuth
    -------------------
    $mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify
    Tests run: 87, Failures: 0, Errors: 0, Skipped: 0
    Tests run: 457, Failures: 0, Errors: 0, Skipped: 74
    Tests run: 207, Failures: 0, Errors: 0, Skipped: 140


[BUG]: Huggingface response truncated

How are you running AnythingLLM?
Docker (remote machine)
What happened?
I've embedded the chat widget in a web page. When asking a question via the chat embed, the response is truncated. When asking the same question within the AnywhereLLM workspace, the response is not truncated.
I got 374 characters in the embed widget.
Are there known steps to reproduce?
No response

We will need more information on this.

Do you see any client disconnections from the chat embed widget from the network inspector
Does the message saved in the chat embed history show the truncated amount as well - or is it fully formed?
What provider and model are you using?
Do you have associated logs from the Docker container as well (if errors persist)

My reference to the embedded chat widget was a red herring. (I've change the title of the issue.) Even when I use the standard interface to dockerized AnythingLLM the response is truncated. My desktop install running on my Mac M1, on the other hand, does NOT truncate the data.

Docker instance

LLM provider is Hugginface with dedicated inference endpoint running mistral-7b-instruct-v0-3-byo.

GPU · Nvidia A10G · 1x GPU · 24 GB
Quantization: none
Max Input Length (per Query): 2048
Max Number of Tokens (per Query): 4096
Max Batch Prefill Tokens: 8192

Default vector DB

Max Context Snippets: 4

Default embedder

Local instance

LLM provider is the included AnythingLLM provider running Mistral7B.
Default vector DB

Max Context Snippets: 4

Default embedder

In both instances I have uploaded 8 word documents which contain the answer to my truncated response.
I don't understand much about LLMs (shocker). How do the document embeddings created by AnythingLLM get to the model? Are they included somehow in the prompt? Might my document embeddings not be reaching the Huggingface model in full? Although it seems more like a token response limit that is hampering my Docker instance.

This looks to be a Huggingface problem:
https://discuss.huggingface.co/t/text-generation-response-truncation/53155
https://huggingface.co/mistralai/Mistral-7B-Instruct-v0.3/discussions/23

Ah, that makes more sense. max_tokens or max_new_tokens should resolve the truncation, there is little or no documentation I can find currently that lets us pass like -1 to that property to allow as many tokens out as needed.
We may have to make an input for this so that we can easily have this property controlled. That being said it is very weird the desktop does not truncate.
Does truncation happen on an empty workspace on the first message? There is usually a max_tokens parameter that is the maximum of input+output tokens and that could cause truncation at random points in a conversation since we inject system prompt + context + history - so a seemingly small query can be many more tokens on the backend - thus resulting in truncation.

Could the reason truncation doesn't occur on desktop be because the desktop uses AnythingLLM/Ollama as the LLM provider, while Docker relies on HF?

Could the reason truncation doesn't occur on desktop be because the desktop uses AnythingLLM/Ollama as the LLM provider, while Docker relies on HF?

The desktop simply uses Ollama as the default. But you can use whatever you want as usual. The HF providers are the same on desktop/docker so if you used the same HF credentials on Desktop you should still get the same behavior. Its the same code, but its certainly specific to the HF connector for the LLM and the issue should be present in both Desktop and Docker


Update CONTRIBUTING.md with Guidelines on Creating Issues, Writing Better Comments, and Submitting PRs

Will Update the CONTRIBUTING.md file to provide clear instructions on how contributors can effectively participate in the project. The updated document should include the following details:

How to Create Issues:
Explaining the process of creating an issue, including how to properly describe the problem or feature request.
Mention the importance of providing a clear, concise title and a detailed explanation of the issue.
Encourage the use of templates if available and emphasize attaching any relevant screenshots, logs, or code snippets.

Writing Better Comments for Issue Assignment:
Will Provide guidelines on how contributors should communicate when asking for issues to be assigned.
Mention the need for detailing how they plan to approach and solve the issue.
Request contributors to include thoughtful and constructive comments to make it easier for maintainers to understand their approach.

How to Create Pull Requests (PRs):
Step-by-step instructions on how to submit a pull request, from forking the repo to making changes and submitting the PR.
Explaining the importance of maintaining a clean and organized commit history (squash or rebase commits if necessary).
Highlighting the need for clear commit messages that explain the changes made, and link the issue being resolved in the PR description.

Time Limit for Assigned Issues:
Specifying that once an issue is assigned, contributors will have 1-2 days to solve the issue and submit a PR.
Mentioning that failure to meet the deadline may result in the issue being reassigned to someone else.

These updates will help streamline the contribution process and ensure that all contributors are aligned on the best practices for creating issues, providing meaningful comments, and submitting clean pull requests.
Kindly assign me this issue under Hacktoberfest 2024, Thank you!!

Thanks you will start it

@DhanushNehru, can you review the PR


Garbled characters at 2400 baud on versions after 0.5.0

I'm using PETTERM on my PET 8296 with Stupid PET Tricks Wifi cartridge.
Version 0.5.0 works perfectly at both 1200 and 2400 baud.
The latest code (calls itself 0.7.0) shows some garbled characters on receive at 2400 baud.  Transmit seems to work, since I'm able to send commands.  1200 baud works fine.
I wonder if one of the optimizations since version 0.5.0 broke the timing at 2400 somehow?

2400 baud with version 0.5.0

2400 baud with version 0.7.0

Ah okay I'll take a look at this. I haven't personally done much testing on the 0.6/0.7 releases as they mostly contain code from @awhitney42 that I have not tested much. I'll have to check what changes were done. Since this seems to only be showing up on an 80 column PET, my guess must be something to due with the screen writing routines, but I'll test on my 40 column to be sure. Sorry for the delay in responding to this issue.
Kinda the reason why 0.7 hasn't been properly released is due to this lack of testing, even though I left it on the master branch, as well as some other changes I wanted to fix as I don't particularly like the solution of a different SYS address being hand calculated per system.

@ChartreuseK Any updates?


[TW#28365] Undefined reference to poll

Environment

Development Kit:      ESP32-DevKitC
Kit version (for WroverKit/PicoKit/DevKitC): v4
Module or chip used:  ESP32-WROOM-32D
IDF version (run git describe --tags to find it):
v3.2-beta1
Build System:         CMake
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
1.22.0-80-g6c4433a
Operating System:     Linux
Power Supply:         USB

Problem Description
I've noticed that there is a poll.h header in newlib/platform_include/sys, with no implementation. So just in case I missed it, I tried using it by taking the UART Select Example, and updating it to use poll instead of select, and I'm seeing an undefined reference to it. Am I missing something or is the implementation legitimately missing?

Yes, you are right @raveious. I'm working on the implementation now.

Hello @raveious. This is now implemented in the master branch. You can test it there. The implementation will be backported to v3.2 ASAP.


(SUP-3348) Telegraf ssl bugfixes

This commit fixes a couple of issues related to Telegraf ssl
configuration.

The service may have been started before the files were copied to
/etc/telegraf
Changing this configuration did not refresh the Telegraf service
The configuration didn't take the $use_ssl parameter into account

Ok, this fixes the Ubuntu issues, but there's still an error on SLES 15:
Error: Could not enable grafana-server

I'll create a separate issue for that one.


🆕 Software Suggestion | PrivacySpy

Basic Information
Name: PrivacySpy
Category: Information
URL: https://privacyspy.org
Description
PrivacySpy uses a consistent rubric to grade major services' privacy practices on a ten-point scale. It's a new open source project that is dedicated to making privacy policies more accessible. PrivacySpy is not unlike ToS;DR (which is already featured in the "Information" section), except it takes a more rubric-driven approach to grading the policies, and it's dedicated to privacy policies only. Full disclosure: I'm one of the maintainers of PrivacySpy, but given that the project is open-source and supported by a non-profit, there's no ulterior motive here.
Here's an excerpt from the "About" page:

Most people don’t have the patience to read privacy policies. But privacy is important, and we shouldn’t just trust that products are treating our data right. PrivacySpy uses a consistent rubric to grade privacy policies on a ten-point scale. [...]
PrivacySpy makes privacy policies more convenient and accessible for those who simply don't have the time—or patience—to read full privacy policies themselves.

Source code (website): https://github.com/Politiwatch/PrivacySpy-Core
Source code (extension): https://github.com/Politiwatch/PrivacySpy-Extension

Also, there are no ads, trackers, etc. on the site. (And it's all open source, so you can verify that!)

I missed your link, but https://github.com/Politiwatch & https://github.com/Politiwatch/PrivacySpy-Extension weren't directly linked.
I am not a coder or able to read the source code and it's 00.36 for me, so this was all I am going to do right now.

I'll update my original post to include those links, too! Thanks.

Thanks for sharing! Looks really helpful.

it looks pretty good, it looks like a sleeker version of tosdr.
i have some questions though: are you aiming to get as many services on there as possible, or mostly just bigger onces? if so, how do you plan to keep all the ratings up to date?

Hey @blacklight447-ptio —
We're trying to get as many services on there as possible, but we're focusing mainly on starting with the biggest ones.
That said, we plan to take archives of as many sites' privacy policies as we can (without assigning ratings) because simply having an archive of a service's privacy policy at a certain point in time can be helpful. For example, having unrated policies on the site allows us to track changes to that policy, even if no one has gotten around to rating it yet.
That said, for the sites that do have ratings, here's how we plan to keep everything up to date:

PrivacySpy takes a wiki-like (note that I did not say wiki) approach to user contributions. Anyone can suggest changes, and then they must either be approved by an admin or the maintainer for that particular policy. (More on maintainers below.) This allows anyone to identify out-of-date sections and bring them to our attention.
Each product on PrivacySpy has a maintainer who is in charge of keeping it up to date. Usually, maintainers are people who use the service a lot—so instead of trusting the admins to keep track of when policies change, we instead give that ability to people who actually use the service themselves (and are more likely to know when a policy does change).
We're super upfront about when everything was last updated. Not only do we publish when policies were first published and last updated, we also show when each individual rubric decision was decided. So if something is out of date, it should be pretty clear judging by the 'last modified' dates. If something hasn't been updated in a long time (> 1 year), we plan on automatically adding a small warning on the top of the page.
Tied to the automatic warning system, we plan on adding a system that automatically notifies maintainers and admins when this warning is added (when a policy hasn't been updated in over a year) so that they can verify that everything is up to date manually.

Anyway, I hope this conveys how we plan on keeping all the info on the site up to date—and how, when things inevitably become out of date, we plan on getting things corrected ASAP.

I see, i like it a lot that you already have policies in place for this, as this is one of my main critiques for Tosdr. i also enjoy that your client are open source. I also noticed the project is affiliated with some non profit call politiwatch, could you tell me a bit more about it?

Sure @blacklight447-ptio  — Politiwatch is a non-profit that I run that houses public accountability, civic information, and data privacy projects. It exists primarily so that the projects can receive tax-deductible donations and receive discounted infrastructure. (Some service providers give discounts to non-profits.)
Here's the homepage: https://politiwatch.org

I would actually be fine to replace tosdr with this in the extension section. this is mainly because tosdr seems to be rather dead

@Mikaela @JonahAragon @dawidpotocki @nitrohorse thoughts?

Just chiming in to say that I'm glad that the response to PrivacySpy has been so positive. I don't have any opinion on whether to remove ToS;DR from the site—as I see it, ToS;DR is a different kind of service, so having both might not be an issue—but either way, all is well.
I just hope PrivacySpy ends up on the site! I think it could really be a helpful tool for a lot of people.

Oh that's all okay, but the problem is is that tosdr seems to be rather inactive , so we no longer know how long it has been since someone checked it, without going thru the hassle and checking the policy ourselves (hence defeating tosdrs purpose)

Their blog isn't even setup, and their browser extensions for Firefox and Chrome haven't been updated in a year but it looks like the project is still active based on their GitHub activity and working group. Regardless I think PrivacySpy would be a good addition.

Maybe after https://github.com/privacytoolsIO/privacytools.io/issues/1327 ?

Ah yeah, forgot to mention that; extension categories would be good.

I appreciate the clear rating system of PrivacySpy and the attempt to use natural language processing to allow the reader to read an excerpt of the privacy policy. Hence, I find the whole reviewing process of PrivacySpy very transparent and I think this combination of a structured and transparent reviewing process gives it good chances to stay for a long time.
I have created a PR if PrivacySpy is still considered a good fit for PTIO :-)

I would actually be fine to replace tosdr with this in the extension section. this is mainly because tosdr seems to be rather dead

Are we still in agreement this is the way to proceed? I'm doing a major cleanup as a part of #1257, #1328, #1430 so we might do this too.


Use assert from unittest instead of normal

I just have to check those tests with a debugger and it will be possible to remove the draft status.

I can't figure out why we have to use normal assert here.

Because it is not a test but an assertion about the test code itself. Like an assert in normal production code.

@scoder this PR is ready for the next review!


Feature Request: do not ignore a line number in links in the terminal

From @TomasB on March 31, 2017 16:27
Given the output in the integrated terminal window:
panic(0xa49c80, 0xc04200a090)
        C:/Go/src/runtime/panic.go:458 +0x251

the link in the output is parsed as C:/Go/src/runtime/panic.go
Probably should be C:/Go/src/runtime/panic.go:458 and go to a specific line once clicked on it.
Copied from original issue: Microsoft/vscode-go#901

That is a VS Code specific behavior and not Go related

Duplicate https://github.com/Microsoft/vscode/issues/21472

Thnx


How to convert the .pkl file to .png

How to convert .pkl file to .png
My research needs .png file not the .pkl file

Hi Kenny,
The short answer is you can't. The .pkl files are features extracted from backbone.
Please refer to the README.md file for details on obtaining the original image files.
Best,
David.

Thanks

Hi Kenny,
The short answer is you can't. The .pkl files are features extracted from backbone.
Please refer to the README.md file for details on obtaining the original image files.
Best, David.

Thanks a lot!!!!


Issue with adding properties to logging with LogContext.Pushproperty and .Net6

I've been using middleware to add logging context to Graylog using LogContext.PushProperty("name", value) in .net 5 without issue.
I've upgraded to .Net6, and now it does not work any more. It still works with file & console loggers, just not with this one.
Is this an issue anyone else has encountered?

Hmm probably you do something wrong. In our systems it just works. You can view my example


Core component variables are not prompted during import

I have noticed that some version of CoE does not prompt admin email and power platform environment variables during the import. I've been testing using 1.98 version downloaded when it was released and that prompts the variables but now downloaded again the same version and there it is not possible to set variables during import. Is this some
Component (please tell us which flow or app you are experiencing issues with):

Solution: Core
Version: 1.98

1.98 downloaded on 19th of March

1.98 download on 3rd of March

Hello,
it looks like we accidentally shipped this version with some of our Default values, which means you won't get prompted from them during import. You can update them after import via the Default solution in the environment, see: https://docs.microsoft.com/en-us/power-platform/guidance/coe/setup-core-components#update-environment-variables
Thank you for raising this, we'll make sure to tidy our default values before shipping the next version!
Manuela

We have introduced a staging environment in our ship cycle to make sure this doesnt happen again. Marking as local fixed as a result.

Fixed with the current release, shipped today. Thank you for using the CoE!