Look up provider IDs programmatically

🔑
Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
This PR is motivated by issue #10796. When you're on multiple App Store Connect teams, it would be helpful if Pilot and Deliver could detect your iTunes provider short name.
Andrew mentioned four goals in the conversation on #10796:

constructing and running this long command from a fastlane action
using my existing credentials in the keychain
parsing the output into something that can be easily consumed programmatically
automatically mapping to developer portal team IDs & iTunes Connect team IDs based on the organization name

This PR implements goals 2, 3, and 4 on that list. I'm not sure about adding the idea of adding a core fastlane action, at least not as part of this PR. However, with the changes to ItunesTransporter described below, it will become possible to make a plugin or custom action that prints out the list of provider names.
I tested this PR by using Pilot to upload an IPA with and without specifying a provider short name.
Description
This PR modifies three components: Pilot, Deliver, and ItunesTransporter. My goal was to keep Pilot and Deliver completely unchanged for single-team users, but add the power to look up the provider short name programmatically for users who are on more than one App Store Connect team.
ItunesTransporter
A new method, provider_ids, is added to ItunesTransporter in Fastlane Core. It runs iTMS Transporter with the -m provider option and parses the table of provider names returned by Apple. It returns a map of provider short names keyed by team name.
Pilot and Deliver
When you're on fewer than two App Store Connect teams, no change.
If you pass an explicit itc_provider, no change.
Otherwise, Pilot and Deliver automatically invoke iTMS Transporter with -m provider. If one of the provider long names matches the name of the active team in your Tunes session, the corresponding provider short name will be used to upload or download binaries.
Thank you so much for your time!

Thank you for your time in reviewing this! The spots that had been storing Spaceship::Tunes state in ivars have been switched over to Spaceship::Tunes.client. The original return type of TransporterExecutor.execute has been restored. Finally, I made some small tweaks in the new documentation, replacing "iTunes Transporter" with "deliver" and "pilot."
Once CI passes, I think this is ready for another look.

@mnespor Thanks for making those changes! I will spend some time tomorrow and/or Thursday thoroughly testing this since this touches a major part of fastlane 😊

@mnespor thanks for putting this together. 🚀

(Failing test on master? What how where why?)

False alarm. spaceship/spec/portal/key_spec.rb turned out to be a Ruby version issue—that test passes under 2.4 on my machine

@joshdholtz, how does the code at the head of mnespor/feature/look-up-provider-ids-programmatically-10796 look? Does it address the concerns you raised?

Took care of another merge conflict.
This "just" needs proper testing, right?

Thank you kindly! It’s ready for testing as far as I know—I didn’t have any further functional changes in mind.

On Mar 7, 2019, at 11:26 AM, Jan Piotrowski<EMAIL_ADDRESS>wrote:
Took care of another merge conflict.
This "just" needs proper testing, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Define full list of platforms for gitStream labeling from Arch Council spreadsheet

Use templates to generate rules for each.

This is WIP, but can't remain a draft PR, since them gitStream will ignore it. 😞

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you.


build: add uninstall target

Pull Request Checklist

[x] New code has 100% test coverage
[x] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[x] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
[x] Pre-Commit Checks were ran and passed
[x] Tests were ran and passed

Description

This PR adds an uninstall target so that users can quickly undo changes to their system made by the install target.
The current make install command places a binary in the user's home directory ($HOME/.local/bin) without explicit consent. This behavior might not be immediately clear to users.
I have not tested the Windows part of the PR because I don't have access to a Windows PC, but it should work based on where PDM claims to install itself to on Windows [0].
[0] The installer will install PDM into the user site and the location depends on the system: $HOME/. local/bin for Unix. %APPDATA%\Python\Scripts on Windows. https://pdm-project.org/latest/

Close Issue(s)

@cofin Done.


self.curr_step never increases in LitPlenoxel

Hi, thanks for releasing this great work! I think there is an error in the implementation of LitPlenoxel. You define self.curr_step here and use it to determine lr decay, voxel upsampling, etc. However, it seems that you never increase this value? I add a print(gstep) after this line, and it always prints 0.

ok so I double-check the code, this line is the only place affected by this bug, because you're reading the correct step value here. All the others (lr, resolution, which are after this correct line) are not affected.
After I change the previous line to the correct one, the performance on my custom data improves a lot (I think this is because I'm using lr_fg_begin_step>0)

There is also another places affected by this, since curr_step is always 0, the ResampleCallBack condition here will never be True, so it will never upsample the Plenoxel voxel grids

I also have another question: the input args near_clip here doesn't seem to be used anywhere? I assume it should be put in RenderOption here. Also background_brightness doesn't seem to be used as well...

Sorry for being late.
This issue is often found when using a different pytorch_lightning version.
Could you share your environment version?

In the case of the last comment, we'll double check it and change the config if some arguments are not used.

Feel free to reopen the issue if you suffer from any problems regarding this issue.


Add letterbox image

Would you be interested in this kind of image transformation?
I have some doubts about this implementation:

it's named letterbox_image but it also scales the image to fit a square of size × size
I did this because it's the more common case and the user can always set it to std::max(img_in.nr(), img_in.nc())
but maybe there should be an overload?

I have the (long term) goal of implementing YOLO training in dlib at some point in my life... This would come in handy, since YOLO trains with square images, and this would allow to convert the bounding boxes between the original and the letterboxed images.
I've already tried it locally initializing a rectangle_transform with the output of this function, and it's pretty convenient.

Yeah it's cool with me.  You can do this with one call to transform_image() but nothing wrong with having a convenience function for doing it.  Add some tests for it though and make it work with the generic image interface though :)

Thank you so much again for the detailed feedback.
I've implemented both versions and tried on two images and averaged 1000 runs:

faces/bald_guys.jpg: 1986 × 1545
faces/2008_002470.jpg: 500 × 332

with resize_image:

faces/bald_guys.jpg: 0.356763 ± 0.0888909 ms
faces/2008_002470.jpg: 0.30611 ± 0.0883218 ms

with transform_image:

faces/bald_guys.jpg: 0.809438 ± 0.144507 ms
faces/2008_002470.jpg: 0.717556 ± 0.288066 ms

So, in my tests, resize_image is over than 2 times faster.
Also, notice that I am not copying the image any more and doing the in place resize, instead I allocate an image with the target size and resize to that function.
For reference, here's the code with transform_image:
const auto nr = static_cast<long>(std::round(scale * vimg_in.nr()));
const auto nc = static_cast<long>(std::round(scale * vimg_in.nc()));
const point b((size - nc) / 2, (size - nr) / 2);
const auto r = rectangle(b.x(), b.y(), b.x() + nc - 1, b.y() + nr - 1);
const auto tform = point_transform_affine(identity_matrix<double>(2) * scale, b);
const auto invt = inv(tform);
transform_image(img_in, img_out, interpolate_bilinear(), invt, white_background(), r);
return tform;

I think it's ready for review, despite the Travis failure (unrelated to this PR).

Sweet.  Thanks for another PR :)

Thank you for the guidance!

No problem :)


Wrong emoji loading

Description
Emojis are not displayed on the blog page

Thank you @corradopetrelli for this issue.
I will try to resolve the problem as soon as possible.
In the meantime, feel free to open a PR :)

I tried by phone and it doesn't give me the same error.
Very strange that it doesn't work on macOS.
Some emojies do not work 😢

Do you use Safari on MacOS?

No, I use Chrome 117 on MacOS. It's definitely an OS problem since it doesn't show me the emoji even on the notepad.


Add Modular Boost section of User FAQ

Parsed the email exchanges and added some questions and answers to the User Guide FAQ - leaving questions and answers more suited for the Contributor Guide aside for the moment. @grafikrobot any feedback?

@alandefreitas I horked my branch somehow - have closed and will resubmit a PR


stm32l0x3 support

Are you going to implement stm32l0x3 support?

There are no plans to implement support at this time, but it's not to say it won't happen. I think most folks are adding to the project based on their MCU of choice.
As always, PR's to add support are always welcome.

Thanks for your honest answer.
It is time to dive into embedded Rust and STM32 deeper.

Sounds good :)
I'm going to close this issue. If you find yourself struggling to add support for the x3, you can always open an issue with an enhancement label to request the added feature.


Sending the Json format log to Elasticsearch.

Hi Team,
We are trying to send the JSON log to Opendistro Elastic search, which is in AWS environment. Can we use the file-beats module for sending the log to Elasticsearch.
Can you give us the Documentation for configuration.

Hi @TPaulManohar, there's no reason the open source version of Filebeat shouldn't be able to communicate with an ODFE cluster. The important thing is to make sure you're using the Apache 2 version, not the "default" version. The Apache 2 version is a bit buried, so look for "The pure Apache 2.0 licensed distribution, is available here." on the Filebeat downloads page.
See here for a configuration example. You'll of course have to tweaks hosts, certificates, credentials, etc.: https://opendistro.github.io/for-elasticsearch-docs/docs/troubleshoot/#beats


do less copying around parsed sigs in resolver

Motivation

Make things go faster.
Each commit in this series is self-contained and can be reviewed independently.  Everything except the last one should be fairly uncontroversial, but the last one is possible a matter of taste (but is also the largest speedup).  The whole series speeds up "resolver.resolve_sigs" by ~10% (~40ms).
fillInInfoFromSig currently takes ParsedSig by value, because fillInInfoFromSig is going to modify the argTypes field:
https://github.com/sorbet/sorbet/blob/3502cd361dea95e33cf10a6127815cab8e3a0997/resolver/resolver.cc#L2596-L2603
for keeping track of signature/definition mismatches.  You can obviously modify fields of a taken-by-value struct.
You would think that we could just take ParsedSig by reference -- after all, the parsed sig only exists during sig resolution and is intended to be a temporary data structure.  But resolve{Multi,}SignatureJob take their job arguments by constant reference and therefore the job.sig field can only be taken by constant reference, barring const_cast tricks.  So to take ParsedSig&, we have to take non-const references to the jobs themselves.
I think having to modify resolve{Multi,}SignatureJob to take non-constant references is mostly OK, but reasonable people can differ on this.
One alternative would be for resolve{Multi,}SignatureJob to take their job arguments by rvalue reference -- this would at least make it clearer to the reader and clearer to any future modifier of this code that, at the callsite to those functions, job is essentially going away.  And then fillInInfoFromSig could take ParsedSig&&, also indicating at the callsite that sig is going away.  (Note that std::move(...)'ing something for an rvalue reference arg doesn't mean that you're actually copying anything.  You're just indicating to the compiler, "tell my callee that they can treat this as a temporary value."  Nothing would change at the actual machine code level versus an lvalue reference.)
This alternative is maybe overly clever, which is why I didn't write the code this way.  Thoughts?
Test plan

See included automated tests.

Thanks for the description. I'm not a huge fan of making the ResolveSignatureJob be mutable (this phase of resolver is parallel, and it's generally easier to not rely on mutation in those cases).
I haven't looked but: are you sure that it's safe to do these const -> mutable changes given how resolver chooses to parallelize this phase?

resolve_sigs happens entirely serially:
https://github.com/sorbet/sorbet/blob/3502cd361dea95e33cf10a6127815cab8e3a0997/resolver/resolver.cc#L3001-L3020
I suppose it's possible that could change in the future...?  Even then, I think the worry wouldn't be the modification of jobs, since that data wouldn't be shared between jobs, but whatever else resolving sigs does (modifying symbols and such)...?


feat: make actors reschedule indefinitely with backoff

Fixes RVT-4196
Fixes RVT-4179
Implemented but untested
Changes

#1475  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry updated to reset retry count only after ready


Add support for Device Information Spec

As per the device-info specification, save the device information in a file using github.com/k8snetworkplumbingwg/network-attachment-definition-client
 utility functions.
As per the design decisions made: Added the create/clean functions to the ResourcePool Interface and implement them in the netResourcePool so that the entire device information can be accessed
Error handling:

Startup: Do not stop the server creation if the DeviceInfo file creation fails, but log it at Error level
Cleanup: Do not stop cleaning if one DeviceInfo file deletion fails, try to clean them all and aggregate errors.

For now, only add the mandatory fields.
Fixes: #286

cc @Billy99

With this change, having the following pools:
$ kubectl get node $HOSTNAME -o json | jq .status.allocatable
{
  "cpu": "8",
  "ephemeral-storage": "3570039515370",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "16Gi",
  "intel.com/intelVFs": "3",
  "intel.com/mlxPFs": "1",
  "intel.com/mlxVFs": "4",
  "memory": "15908252Ki",
  "pods": "110"
}

I get the following files:
$ tree /var/run/k8s.cni.cncf.io/devinfo/dp
/var/run/k8s.cni.cncf.io/devinfo/dp
├── intel.com-intelVFs-0000:05:00.2-device.json
├── intel.com-intelVFs-0000:05:00.3-device.json
├── intel.com-intelVFs-0000:05:00.4-device.json
├── intel.com-mlxPFs-0000:04:00.1-device.json
├── intel.com-mlxVFs-0000:04:00.3-device.json
├── intel.com-mlxVFs-0000:04:00.4-device.json
├── intel.com-mlxVFs-0000:04:00.5-device.json
└── intel.com-mlxVFs-0000:04:00.6-device.json
$ cat /var/run/k8s.cni.cncf.io/devinfo/dp/intel.com-mlxVFs-0000\:04\:00.3-device.json
{"type":"pci","version":"0.1.0","pci":{"pci-address":"0000:04:00.3"}}
$ cat /var/run/k8s.cni.cncf.io/devinfo/dp/intel.com-intelVFs-0000\:05\:00.3-device.json
{"type":"pci","version":"0.1.0","pci":{"pci-address":"0000:05:00.3"}}

/lgtm
None of the comments are real issues, just nits. I tested with the version just before the PR was created and worked fine with pending device-info Multus PR. The PR comment indicated that only the mandatory fields were filled in. Is that the plan for the final PR or just because this is still [WIP] (just wondering, not pressuring to fill in the rest)?

I was thinking in pushing the mandatory fields first (pci-address) mainly because how the rest of the device info is handled is being discussed in #281

looks like CI failed, is it because due to not using 1.15 golang version?

I'm not sure why it's failing. I'm looking into it but it's taking some time since I get errors in Travis that I cannot reproduce locally.

looks like CI failed, is it because due to not using 1.15 golang version?

I'm not sure why it's failing. I'm looking into it but it's taking some time since I get errors in Travis that I cannot reproduce locally.

@zshi-redhat, the CI instability issues I was facing are now solved. PTAL

IMO changes are good. I also tested the change locally to get a better feel for the new behaviour.
Are you planning to add unit test for {Store/Clean}DeviceInfoFile` ?

The current unit test verifies that Store/CleanDeviceInfoFile are called but not what it does internally

nadutils can be put behind an interface to allow mocking

Good idea, I did not think of that option. So we would have to:

Add an interface in types.go with the functions from 'nadutils' we use
Implement it (for example) in pkg/utils/utils.go
Add a function to the factory to create the implementation
Make the resourceManager pass the factory to server.Start() and server.Stop() (boy, we need to make this factory a proper singleton!)

Are we good with this approach?

@martinkennelly, @adrianchiris, Talking to @zshi-redhat, we considered an alternative approach in order to make the unit tests cleaner: make resourceFactory a global singleton. It's anyway referenced all over the place and it makes little sense to carry it's pointer around.
However, that is a big change that would likely miss the upcoming release.
So the strategy would be to merge this PR as is, make the release, and then I'll work on making the resourceFactory global. Once that is done, I'll add Unit tests for the Store/CleanDeviceInfoFile
What do you think?

Good idea, I did not think of that option. So we would have to:

Add an interface in types.go with the functions from 'nadutils' we use
Implement it (for example) in pkg/utils/utils.go
Add a function to the factory to create the implementation
Make the resourceManager pass the factory to server.Start() and server.Stop() (boy, we need to make this factory a proper >singleton!)

NetResourcePool would either need the factory or an implementation to the "nadutils" interface. i dont think you need to pass it to server.Start(), server.Stop().

Are we good with this approach?

Generally Yes from my POV, See my comments below on the proper singleton bit.

@martinkennelly, @adrianchiris, Talking to @zshi-redhat, we considered an alternative approach in order to make the unit tests cleaner: make resourceFactory a global singleton. It's anyway referenced all over the place and it makes little sense to carry it's pointer around.
However, that is a big change that would likely miss the upcoming release.
So the strategy would be to merge this PR as is, make the release, and then I'll work on making the resourceFactory global. Once that is done, I'll add Unit tests for the Store/CleanDeviceInfoFile

resourceFactory is a signleton today, its New method returns the same instance.
having it "globally" available would require alot of changes in unit-test to swap its global implementation with a mocked one.
as well as code refactoring of the various packages. The benefits of doing so is not apparent to me (at least not in a substantial manner).
I think having resourceFactory instance as a member of other constructs follows the pattern of dependency injection, to help with unit tests and ease refactoring/replacing existing implementations of different interfaces. what you propose kinda deviates from that path.

Good idea, I did not think of that option. So we would have to:

Add an interface in types.go with the functions from 'nadutils' we use
Implement it (for example) in pkg/utils/utils.go
Add a function to the factory to create the implementation
Make the resourceManager pass the factory to server.Start() and server.Stop() (boy, we need to make this factory a proper >singleton!)

NetResourcePool would either need the factory or an implementation to the "nadutils" interface. i dont think you need to pass it to server.Start(), server.Stop().

Are we good with this approach?

Generally Yes from my POV, See my comments below on the proper singleton bit.

@martinkennelly, @adrianchiris, Talking to @zshi-redhat, we considered an alternative approach in order to make the unit tests cleaner: make resourceFactory a global singleton. It's anyway referenced all over the place and it makes little sense to carry it's pointer around.
However, that is a big change that would likely miss the upcoming release.
So the strategy would be to merge this PR as is, make the release, and then I'll work on making the resourceFactory global. Once that is done, I'll add Unit tests for the Store/CleanDeviceInfoFile

resourceFactory is a signleton today, its New method returns the same instance.

I don't think that's really the case (although the intention does seem that one):
https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/89b9bc9adbea4df09cf6455e62bfa00ab5ed26c0/pkg/factory/factory.go#L39-L49

having it "globally" available would require alot of changes in unit-test to swap its global implementation with a mocked one.
as well as code refactoring of the various packages. The benefits of doing so is not apparent to me (at least not in a substantial manner).
I think having resourceFactory instance as a member of other constructs follows the pattern of dependency injection, to help with unit tests and ease refactoring/replacing existing implementations of different interfaces. what you propose kinda deviates from that path.
I think the refactor for resourceFactory should be further discussed to reach an agreement, if you could open an issue on it to trigger discussion it would be great ! :)

#300 created

If you think adding unit-test in the current state of code requires alot of code changes im fine with having it as a separate PR.
(and an issue to track that ofc)

I don't think it's a a lot of code, it just requires modifying the resourcePool struct. If that's acceptable I'd go ahead with it.

I don't think that's really the case (although the intention does seem that one):

you are right ! there is no assignment to instance although i expected to be one.

#300 created

Thanks!

I don't think it's a a lot of code, it just requires modifying the resourcePool struct. If that's acceptable I'd go ahead with it.

IMO its a reasonable change to facilitate UT of the added methods

@adrianchiris PTAL at the last 3 commits (the rest of the PR unchanged)

CI failed because pkg/types/mocks/NadUtils.go file is not generated.


Tests for core interface?

A question: are there tests available somewhere for the core trace interface? For example, program binaries and golden references of the expected trace signals?
I'm asking because we're in the progress of adding this interface to Ibex, and it would be good to ensure that this interface provides the data expected by e.g. a Ultrasoc IP core using those signals.

There is a reference flow that should cover this


TestEvents test flake

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/3441
I have seen other failures as well

https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/29122/unit-tests_istio/1330909894945017856

will be obsolete by https://github.com/istio/istio/issues/23943

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1348674467747860480

https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1348674467747860480

@istio/wg-user-experience-maintainers this is currently one of the flakiest unit test. Can we either prioritize https://github.com/istio/istio/issues/23943, skip the test, or fix it?

@istio/wg-user-experience-maintainers this is currently one of the flakiest unit test. Can we either prioritize https://github.com/istio/istio/issues/23943, skip the test, or fix it?

btw, this is probably broken due to https://github.com/kubernetes/kubernetes/issues/95372

btw, this is probably broken due to https://github.com/kubernetes/kubernetes/issues/95372

@istio/wg-user-experience-maintainers this is currently one of the flakiest unit test. Can we either prioritize #23943, skip the test, or fix it?

migration is still on our plate. I will proceed with skipping it for now.

@istio/wg-user-experience-maintainers this is currently one of the flakiest unit test. Can we either prioritize #23943, skip the test, or fix it?

migration is still on our plate. I will proceed with skipping it for now.

btw its not just TestEvents, but also TestEvents_***: https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_release-1.9_postsubmit/1349853372273922048. So probabl all suffer the same race

btw its not just TestEvents, but also TestEvents_***: https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_release-1.9_postsubmit/1349853372273922048. So probabl all suffer the same race


Fix submission queue overflow on large blob writes

#406
From everything I have read, just adjusting the sub queue entries size should be fine... Obviously spin-locking on an entry to be processed is not exactly ideal here but with the entries sized increased it seems like that isn't a likely situation. More than a few examples I found are creating a ring with >= 256.
All the other possible improvements I have read about don't really apply to this use-case (batch submissions being the primary one I have seen)
Probably should add tests with large blob inserts, right now the only tests that are doing inserts is in shelltests.py
EDIT: Currently exploring the possible realistic solutions discussed on discord.

Closing this in favor of upcoming RFC on much of the io_uring/async flow


Add internal logging to track pool items

Add internal logs to allow to track lifecycle of a transaction or snark work from its receival through validation down to inclusion into a block.
Explain your changes:

Add internal logs to track transaction and snark work lifecycle

Explain how you tested your changes:

Tested on a private cluster

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!ci-build-me

!ci-build-me

@georgeee Can you share in verbal form test you performed on private cluster?
Also i presume that this PR help debugging activities, but do you see any new or existing tests which could implement some checks using above code?

!ci-build-me

!ci-build-me

!ci-build-me

@georgeee did you test this with high transaction load? Curious to know if the transaction hashing had any impact

@deepthiskumar I replaced usage of transaction hash with usage of fee payer's signature
This ensures no computation is done, only base58-check conversion for log string.

!ci-build-me

!ci-build-me

!approved-for-mainnet


feat(#576): Handle Char Values Correctly

In thir PR I fix the bug related to chars handling. jeo used to produce some ClassCastExceptions when handled annotations with default values that uses chars. Now I fixed this.
Closes: #576
History:

feat(#576): add example of code which causes cast exception
feat(#576): add unit tests that identidy the problem
feat(#576): fix the bug

PR-Codex overview
This PR introduces enhancements to the DataType class by adding support for char data type conversion. Additionally, it includes new test cases for char data representation and introduces a new custom annotation FixedWidth.
Detailed summary

Added support for char data type conversion in DataType class
Added test cases for char data representation in HexDataTest
Introduced a new custom annotation FixedWidth in FixedWidth.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 8min)


packed update

ripley
station ai
ai lawset boards
tech storage comms-idcard-proto boards
skub

ripley

wait what, packed already had ripley


[BUG] Installation page is broken in eunomia-bpf

Describe the bug

The below link is broken.
https://eunomia.dev/eunomia-bpf/setup/
To Reproduce
Steps to reproduce the behavior:

Go to 'eunomia.dev website'
Click on 'eunomia-bpf'
Scroll down to 'setup'
See error

Expected behavior

It should lead setup page in the repo
Screenshots

Desktop (please complete the following information):

OS: [e.g. Windows]
Version [e.g. 10]

Additional context

I would like to fix this issue

@yunwei37 can you provide me the accurate link to fix this?

I'm finding it...

I'm finding it...

okay.. will wait...

Seems like it's here: https://github.com/eunomia-bpf/eunomia-bpf/tree/master/documents/src
You can run make build to successfully download and build the website, the documents in other repo will be move into the correct position.

Is it better to move all the documents for the tools to this repo?
It can simplify the build process and avoid misunderstanding. See https://github.com/eunomia-bpf/eunomia.dev/blob/main/rename.sh and the Makefile, currently we need to download the documents from other repo, rename it and build the website.
After refactor, the only thing outside this repo and need copy and build will be the tutorials and project README.md. They should be in other repo.
Related to https://github.com/eunomia-bpf/eunomia-bpf/issues/340

Thanks for your help!

Will definitely raise a pr for this once https://github.com/eunomia-bpf/eunomia.dev/pull/25 gets merged!!

After refactor, the only thing outside this repo and need copy and build will be the tutorials and project README.md. They should be in other repo.

Should  'readme' be also in other repo? I saw that wasm-bpf's index.md has content similar to Readme only other projects don't.

Yes, all project readme should be in other repo.


Remove coreos parameters from common so that different tests can be

pinned to different CoreOS versions.

Does this mean we can no longer just "pin" to latest in a channel? Do we care?

is 'current' still valid?

oh, right, you can still use 'current'

LGTM


Consider the default theme in RegisteredServiceThemeBasedViewResolver

Changes the view resolver for registered services to consider the default theme.
Brief description of changes applied
The configured default theme ("cas.theme.defaultThemeName") was only considered by the ThemeResolver but not by the ViewResolver for (registered) services. As specially in the case a non-service (or an unregistered service) like /authentication is called it will use no theme at all. The behaviour of the RegisteredServiceThemeBasedViewResolver is changed so that it will consider the default view name for services and non-services now.

For a service it will first check the configured theme of the service, if it does not exist it will check the default theme and if that also does not exist it will use no theme.
For a non-service it will first check the default theme and if it does not exist it will use no theme like before.

Background: We tried to apply our theme to all sites/services accessible and it works very well for all of our own registered services. Only the /authentication service(?) could not be themed because the RegisteredServiceThemeBasedViewResolver just quits at:

if (service == null) {
applyDefaultThemeToTemplateName( view );
return view;
}

Any documentation on how to configure, test
Just configure "cas.theme.defaultThemeName" in the application.properties of the CAS deployment and access /authentication for example. It will now use the configured default theme.
Any possible limitations, side effects, etc
Only side effect is that existing installations with "cas.theme.defaultThemeName" set will now have that default theme also applied to other services as well.
any comments or suggestions are highly appreciated

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.swoeste seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

One quick question: what exactly is /authentication?

That aside, I think the changes you have applied here are perfectly sound. Just make sure the build can pass with formatting fixes, etc and we should be good to merge.

Only side effect is that existing installations with "cas.theme.defaultThemeName" set will now have that default theme also applied to other services as well.

Can you elaborate on this? Is this not already true where the default theme does already apply to everything?

Hi, sorry i did not explain that point. We deploy CAS as part (WAR) of an EAR and /authentication is the context of that WAR. In other words the CAS WAR file is called authentication.war and therefore /authentication is the root context of CAS.
To the side effect, if a deployment has "cas.theme.defaultThemeName" defined, it is currently not applied to "all" services just the ones which are "registered". The "non-registered" services, like /authentication in our case, will use no theme. If someone estimates that no theme is applied to "non-registered" services this will change now, it will now use the configured default theme.
I will have a look at the formatting problems ...

Excellent; thanks for the explanation. I think that "side effect" is an acceptable compromise. Ping when back the pull is back in shape please.
Who is "we" in this context btw? What organization/company/institution if you can share?

I recommend you merge with master once more to get your changes up to speed.

Excellent work. I"ll let the CI tool do its thing and will then merge. Thanks again.

Thanks for your assistance, that was the quickest and easiest contribution to a project i have done so far.
Please apologise me for my inconsistent builds, I am just getting used to work with gradle ...
And to answer your previous question:
"We" are my colleagues and me from an internal development department of the zeb group.
greetings from Germany :)

Ah, sehr gut.  All are most welcome.


License hyperlink on anaconda.org not working

This hyperlink on anaconda.org does not correctly jump to license_url set in meta.yaml:

Thanks Leo! 😄
Looks like this recipe doesn't have license_url. Only seeing these license* fields:
https://github.com/conda-forge/cub-feedstock/blob/f6cf131f33cd927d40feb78d3c6fa01704331bff/recipe/meta.yaml#L27-L29

Misfired, sorry!

No worries. Though we could keep this open if we want to add it


[CI] Test failure - D8595731 refers to undefined cell @xplat

test_android is broken due to the use of @xplat in xplat/ js/react-native-github/ReactAndroid/src/main/jni/first-party/fb/ BUCK.

@ttsugriy has a confirmed fix for this that should land within minutes.


CSCFAIRMETA-553: [FIX] Crash in events page when dataset_version_set is missing

For some datasets, dataset_version_set is not defined
Add error handling, making sure that dataset_version_set functionality is skipped if the variable isn't supplied in props

For test datasets, see
https://etsin-test.csc.fi/dataset/7a6c192c-179c-42bf-94eb-b04522540f36/
https://etsin-test.csc.fi/dataset/6c6f7332-d684-43d4-ae5f-ea5394ebe8d6/
https://etsin-test.csc.fi/dataset/be5d0f44-c3ba-4511-8872-790b02b9987e/


New rule for issues #97, #100 and #101

Created the rules for issues:

#97
#100
#101

There is a small change in no-restricted-tags rule.
There was an issues with the error message, it showed the scenario/background line instead of the tag line.
@znevrly and @ajthesnare ; please, check if it's waht you expected

@josemenveg thanks for tackling these.
I did some checking and allowed-tags looks good.
However, the other 2 throw this error when you add them and try to run npm run demo:
TypeError: Cannot read property 'forEach' of undefined

The problem is that there are 2 features that are empty:
a.feature
EmptyFeature.feature

Now, these feature are obviously invalid and the rule no-empty-file checks for them.  The question is, do you want your functions to blow up because of this or do you want to short circuit them to bail in this case:
  if (typeof feature.children === 'undefined') {
    return;
  }

I'm not able to reproduce it.
Anyway, as you can see, I have made and update based in your advise:
if (feature.children) {
...
}

sweet, works without error for me now. 👍

Sorry for the delay. Released with v2.12.0.


IntelliSense syntax error bug

VSCode Version: 1.52
OS Version: Windows 10 20H2

Steps to Reproduce:

C/C++ Extension
GNU GCC 10.2.0
This project has configured with header guard. Fortunately the compiler builds and compiles.
IntelliSense showing syntax error.
Refer attached vs code workspace.

Does this issue occur when all extensions are disabled?: Yes
2xq1.zip

/extC++

/extC++


Reimporting Texture after using it in texture packer still uses old texture version

After packing a texture in the texture packer if you then reimport the textures with changes the texture packer will still use the old texture before reimport, the only way I've found to fix this/update the texture in the packer is to restart unity.

You can reimport the ThryEditor folder to also temporarily fix the issue as well.
I also have this issue too though when using the texture packer :c


fix isHidden function

Hi! In my React application when I go to another page this plugin thought that element is hidden but really he didn't exist

If you agree should I update dist folder?

Why is one of slider's parent node is null, is it detached from DOM? I think you should use hook componentWillUnmount and call slider.rangeSlider.destroy() inside it.
Could you try and tell result?

@Stryzhevskyi, yes, it's work! Sorry to bother you


webpack 5: Module concatenation should not rewrite import-referencing declaration following delete

Bug report
What is the current behavior?
Deleting a property on an object imported from an external file results in errors during build because the reference is converted to a local variable which cannot be deleted in strict mode.
If the current behavior is a bug, please provide the steps to reproduce.
Reproduction repo: https://github.com/thecrypticace/webpack-module-concat-delete-prop-bug
Reproduction steps (these are also demonstrated in above repo with a few more examples):

Export object from file:

export default {
  foo: null,
}

Import object from said file

import def from "./other.js"

Delete property in object

delete def.foo

Build with module concatenation

npx webpack -p

See error about deleting local variable

ERROR in ./src/index.js + 1 modules
Deleting local variable in strict mode (3:0)
|
|
| delete __WEBPACK_MODULE_REFERENCE__0_5b2264656661756c74222c22666f6f225d_asiSafe__
|

What is the expected behavior?
Module concatenation should not rewrite whole reference following a delete directive into a local variable as this is an error in strict mode.
Other relevant information:
webpack version:  v5.0.0-beta.15
Node.js version: v14.1.0
Operating System: macOS 10.15.3
Additional tools: Yarn v1.22.4

Confirmed with highcharts library, see https://unpkg.com/highcharts@8.1.2/modules/exporting.src.js?module
ERROR in ./node_modules/highcharts/es-modules/masters/modules/exporting.src.js + 3 modules
Deleting local variable in strict mode (1340:8)
|         }
|         delete chart.printReverseInfo;
|         delete __WEBPACK_MODULE_REFERENCE__1_5b2264656661756c74222c227072696e74696e674368617274225d_asiSafe__;
|         fireEvent(chart, 'afterPrint');
|     },

The problematic line is this one:
delete H.printingChart;

@web-padawan thanks for information, it will be fixed in the near future


Wrong README.md file, missing README-OpenSSL.md in openssl-3.0.10+quic branch

Wrong README.md file (taken from upstream openssl project). Looks like missing README-OpenSSL.md in openssl-3.0.10+quic branch.

@tmshort Thank you for very detailed explanation! I just tried to do automated rpm builds for codeit.guru public repository and confused how to find the correct time/event to make the builds, as @richsalz said there no will be releases anymore. Now I assume that source releases are available again and I reverted changes back to pull tarballs from github releases.
Thanks again for your work!


BREAKING CHANGE: prefix change

Description
changing components prefix to use cv- instead of td-
What's included?

prefix for all covalent componets are cv-
Also fixed buid issue after angular upgrade for scss files

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

:tada: This PR is included in version 4.16.0-beta.2 :tada:
The release is available on:

v4.16.0-beta.2
GitHub release

Your semantic-release bot :package::rocket:


Why is node 5.12.0 still recommended?

This version is two years old, and has not received any backporting of security and crypto fixes from 6,7,8,9 or 10.
In my opinion this should be at least 8LTS.

Absolutely agree with this, security is always the priority, latest LTS version is 8.12.0 and should be updated asap.

Closed by request of @tarmo888

I did not request to close it, I said you made a duplicate.

My point is that it is not a duplicate but a tightened scope - just the node LTS

But I don't want to argue semantics.

For the record, this is what snyk.io reports on a clean install of this app from git:
✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:brace-expansion:20170302
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer brace-expansion than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:braces:20180219
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:braces:20180219
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Time of Check Time of Use (TOCTOU)
- info: https://snyk.io/vuln/npm:chownr:20180731
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Time of Check Time of Use (TOCTOU)
- info: https://snyk.io/vuln/npm:chownr:20180731
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Insecure Randomness
- info: https://snyk.io/vuln/npm:cryptiles:20180710
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer cryptiles than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:debug:20170905
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer debug than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:deep-extend:20180409
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer deep-extend than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:extend:20180424
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer extend than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:hoek:20180212
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer hoek than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:hoek:20180212
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer hoek than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:hoek:20180212
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer hoek than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:hoek:20180212
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer hoek than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:is-my-json-valid:20180214
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer is-my-json-valid than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:lodash:20180130
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:lodash:20180130
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:lodash:20180130
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:lodash:20180130
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No direct dependency upgrade can address this issue.
Run `snyk wizard` to explore remediation options.

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Pollution
- info: https://snyk.io/vuln/npm:lodash:20180130
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Upgrade direct dependency<EMAIL_ADDRESS>to<EMAIL_ADDRESS>(triggers upgrades to<EMAIL_ADDRESS>
✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (DoS)
- info: https://snyk.io/vuln/npm:minimatch:20160620
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer minimatch than<EMAIL_ADDRESS>

✗ Low severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:ms:20170412
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer ms than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Prototype Override Protection Bypass
- info: https://snyk.io/vuln/npm:qs:20170213
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer qs than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Command Injection
- info: https://snyk.io/vuln/npm:shelljs:20140723
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:sshpk:20180409
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer sshpk than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Uninitialized Memory Exposure
- info: https://snyk.io/vuln/npm:stringstream:20180511
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer stringstream than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:tough-cookie:20160722
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer tough-cookie than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:tough-cookie:20170905
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer tough-cookie than<EMAIL_ADDRESS>

✗ Medium severity vulnerability found on<EMAIL_ADDRESS>- desc: Uninitialized Memory Exposure
- info: https://snyk.io/vuln/npm:tunnel-agent:20170305
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>Your dependencies are out of date, otherwise you would be using a newer tunnel-agent than<EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:underscore.string:20170908
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:underscore.string:20170908
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:underscore.string:20170908
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>

✗ High severity vulnerability found on<EMAIL_ADDRESS>- desc: Regular Expression Denial of Service (ReDoS)
- info: https://snyk.io/vuln/npm:underscore.string:20170908
- from<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>


I want to improve the UI of your project by adding animations to the cards.

I want to work on this issue. Kindly assign it to me :).


Failed to add ruleset

When I copy the ruleset into the rulesets folder the game gives and error saying "Failed to add ruleset osu.game.Rulesets.Diva, Version <IP_ADDRESS>, Culture=neutral, PublicKeyToken=null". I am running version 2021.927.0-lazer

.

osu!lazer is a rapidly moving target, and we have CI tasks to automatically bring up the most obvious build issues. If the automated build for this version was successful, we may need additional logs to look into the issue.

Otherwise, try building the ruleset from source code, maybe the prebuilt releases are lagging behind.

I will try building it now. What logs would you need to look into it?

I built the ruleset and it works from there. Thanks for the help!

Otherwise, try building the ruleset from source code, maybe the prebuilt releases are lagging behind.


QUIC codec / channels should work with heap buffers as well

Motivation:
A user may feed a heap buffer into the QUIC codec / channels. We need to do a temporary buffer copy in this case as we need a direct buffer.
Modifications:

Do temporary memory copies if needed
Add uniit test varioants for it

Result:
QUIC works with direct and heap buffers

/cc @thomdev


Renamed test packages

Closes #11

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage     77.84%   77.84%
  Complexity      576      576
=========================================
  Files            55       55
  Lines          1652     1652
  Branches        164      164
=========================================
  Hits           1286     1286
  Misses          244      244
  Partials        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee5be3...1029f73. Read the comment docs.


Rewrite translator

rewrite translator, no need to keep the same functionality as Lichess

Let's leave it for now as it is.


Filter all checkbox in categorical column filter dialog exists but is invisible

Release number or git hash: deployed Taggle demo + Ordino Taggle
Web browser version and OS: Chrome

Steps to reproduce

Open filter dialog in categorical column

Observed behavior

Checkbox invisible but appear when the user clicks the invisible box

Expected behavior

Visible checkbox

cannot reproduce: when I open the dialog all checkboxes are there

the one on the left of the Category label is missing ('filter all').

maybe we should add a dedicated 'Filter all' entry to the list. not sure if users get what the box next to the 'category' label does.


Switch to Yarn 4

Yarn 1 is deprecated (but still supported for now) and it is recommended to migrate to the actively maintained version: https://endoflife.date/yarn
We can use corepack or yarn set version berry to install Yarn 4 in the container at runtime, but we would prefer to use something more immutable.
However, there are breaking changes so it might be necessary to include both versions at the same time (like what is done for Composer 1 and 2).

I'm not using yarn myself, so please forgive my ignorance.
After reading about yarn 4 and corepack, I only got more confused regarding this request.
As yarn 4 wants to be a project level dependency (with its exact version set in package.json), what would be the point to pre-bundle any specific yarn 4 version in docksal/cli?

I guess I'm not a big fan of having to set the version at runtime and would prefer to have something immutable in the Docker image.
However, it seems Yarn 4 is really meant to be installed per-project so it would not make sense to go against this.
I will try to use corepack in Docksal and see if everything works correctly.

I noticed a first small problem:
corepack enable creates a symlink in /home/docker/.nvm/versions/node/v20.11.0/bin/yarn but /home/docker/.yarn/bin/yarn comes before in PATH so yarn --version still runs Yarn 1.


Provide JsonConverter implementations

Kiota uses custom enum serialization that depends on the EnumMemberAttribute. Unfortunately the JsonStringEnumConverter provided in System.Text.Json does not use this attribute. In order to more easily integrate with non-Kiota uses of System.Text.Json, it would be useful to provide JsonConverter/JsonConverterFactory implementations that match the Kiota output.
Similarly the Date and Time types from Kiota abstractions also don't work directly with System.Text.Json.

Transferring issue as part of https://github.com/microsoft/kiota-abstractions-dotnet/issues/238


Safe compare password (timing attack)

Missing implementation ExternalUserLogin

LoginLDAP
LoginSMTP
LoginPAM

Just curious: how's == operator time dependant on password content ?

Got it: early exit on difference
REF: http://stackoverflow.com/questions/20663468/secure-compare-of-strings-in-go
As for this PR: LGTM

LGTM


Type string not assignable to specific string inside Promise.then return value

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms:
"typeof string is not assignable to"
"promise"
Code
interface ITest {
  name: 'test'
}

const createTestAsync = (): Promise<ITest> => Promise.resolve().then(() => ({ name: 'test' }))
// The same works if you write:
//    const createTestAsync = (): Promise<ITest> => Promise.resolve({ name: 'test' })

const createTest = (): ITest => {
  return { name: 'test' }
}

Expected behavior:
Expect both sync and async functions (createTest and createTestAsync) to compile without errors
Actual behavior:
createTestAsync throws the following compilation error:
Type 'Promise<{ name: string; }>' is not assignable to type 'Promise<ITest>'.
  Type '{ name: string; }' is not assignable to type 'ITest'.
    Types of property 'name' are incompatible.
      Type 'string' is not assignable to type '"test"'.

Playground Link:
https://www.typescriptlang.org/play/#src=interface ITest {
  name%3A 'test'
}

const createTestAsync %3D ()%3A Promise<ITest> %3D>
  Promise.resolve().then(() %3D> ({ name%3A 'test' }))%0D%0A%0D%0Aconst%20createTest%20%3D%20()%3A%20ITest%20%3D%3E%20%7B%0D%0A%20%20return%20%7B%20name%3A%20'test'%20%7D%0D%0A%7D%0D%0A
Related Issues:
https://github.com/Microsoft/TypeScript/issues/29078
Further notes
Hi there, first time I'm interacting with the Typescript github repo. I wasn't able to find any issues which described the exact same problem but I wasn't sure exactly what search terms to use so apologies if there are duplicates. Furthermore, I am wondering whether there is something inherent in how Promises work which makes this problem occur - if so, I would love to be educated on the matter! :)
If there is any other information I can provide, please let me know.

This is related to type inference where the target is a union of type variables.
interface Promise<T> {
    then<TResult1 = T, TResult2 = never>(
        onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | undefined | null,
        onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | undefined | null
    ): Promise<TResult1 | TResult2>;
    // ...
}

For reasons that are lost to history we don't make inferences to type parameters in unions with other type parameters. I think it was because we previously lacked the ability to assign lower priority to such inferences (as they are more speculative), but we have that ability now. So, when inferring from Promise<XXX> to Promise<T | U> we ought to make a lower priority inference of XXX to both T and U. Doing so would solve your issue. I will look at making this change.

For example, we currently get this wrong:
declare function test<T, U>(x: T | U): T | U;
let s: string = test('a');  // Error: Type '{}' is not assignable to type 'string'

We ought to infer "a" for both T and U.


No Cloudflare challenge detected.

It says wrong if it exists
[ERROR] No Cloudflare challenge detected.

yea.. i  noticed this just happening a few days ago....

Thanks for letting me know about this issue. It has been fixed in the latest commit.

headless=True
When this is active it is very slow or sometimes it doesn't work at all, it takes more than 120 seconds

Are you receiving a turnstile challenge? If so, you will need to solve it manually by passing the -d flag for the time being.

verify_button = self.page.get_by_role("button", name=verify_button_pattern)
Whether in debug or normal mode, the problem is this line of code
I replaced with below code but still we have error
self.page.locator("//*[@id='challenge-stage']/div/label/input")
problem
this is not Automatic   find checkbox and click

https://github.com/microsoft/playwright/issues/21780

Hello @Xewdy444, congrats for your work. Do you know if there is a way to configure Firefox to enable the interactions with the frame? Via about:config properties or so? Thx in advance

I don't believe there is any workaround as this is just a bug with Playwright.

hi,
Your fix worked.... but now its stuck at
Solving Cloudflare challenge [Managed]...
any idea whats wrong?

Are you receiving a turnstile challenge? If so, you will need to solve it manually by passing the -d flag for the time being.

@sean-tan


using same PSR distance parameter for multiple CW signals

When a user initializes two (or more) CW signals to search simultaneously, each CW carries it's own set of pulsar distance parameters.  These parameters should be collected so that all CW's use the same pulsar distance for each pulsar.
To my knowledge, this was discovered by @caitlinawitt during the IPTA MDC2.  It will be important for when @bencebecsy incorporates pulsar terms in his N*CW work.

I've just got to including pulsar terms. Thanks for the heads-up.
Shouldn't this be an issue at enterprise_extensions rather than enterprise? At least when I set up multiple CWs, the p_dist and pphase parameters are initiated by some enterprise_extension function (CWSignal, I think).
Note: It's a bit complicated though, because I'm not actually using the main of enterprise_extensions, but my own version due to a separate issue (https://github.com/stevertaylor/enterprise_extensions/issues/12). It looks like the current version of CWSignal in enterprise_extensions (https://github.com/stevertaylor/enterprise_extensions/blob/master/enterprise_extensions/models.py#L901) doesn't even set up pulsar distance and phase at psr parameters. Can maybe @stevertaylor explain why?
With that said, I'd be happy to look into this and come up with a solution, but I would need a fix first for issue #12 at enterprise_extensions.

I think you are correct that the CW code is in enterprise_extensions.  There was some discussion about moving it to enterprise base (the GW memory stuff is in enterprise.signals.utils).


无法获取未定义或 null 引用的属性“split”

Version
2.2.6
Reproduction link
https://jsfiddle.net/mohaiyo/50wL7mdz/97951/
Steps to reproduce
Step1: copy the code from jsfiddle to an index.html (I'm sorry but the jsfiddle don't support the IE9 document mode so you have to reproduce this bug this way)
Step2: open the index.html file by IE browser or 360 browser
Step3: F12 Open the debugger. Choose the userAgent IE10 or IE11(must be 360 browser ) by simulation tool
step4:click the datePicker component then you can see the error--无法获取未定义或 null 引用的属性“split”
What is expected?
There is no error on IE when the browser mode(IE10 or IE11) incompatible with the document(IE9) mode .
I know this bug is caused by transition,but how can I fix it?
What is actually happening?
There is an error "无法获取未定义或 null 引用的属性“split”" when js run!

can vue add an feature to remove tansition?

这是 Element UI 相关的问题，不要到 Vue 这里来报

Got it,thx1

Got it,Thx!


Add sendAsync functions to web push service to support non-blocking calls

I did add non blocking async (suspend) function as an alternative to the blocking non async functions.
I had to add one dependency to support this workflow (kotlinx-coroutines-core), which is an official Kotlin dependency from JetBrains. This did increase the jar file by 2 KB (from 24 KB to 26 KB), which shouldn't be a large impact (this should still be considered lightweight). Only the part with the zero dependency wouldn't be true, but it would only be 1 first party dependency. If you don't like this, you can just reject my request.

I have now removed the third party dependency.


Sxs71620

Hi,
This commit has a functionality to display Part description along with lineitem ids and quantity.
Please help me review the changes and merge them to sprint3.

Looks good to me.


Lockups & sudden power-off

Describe the bug
In the terminal, compressing an archive of some files while using the web-browser and attempting to output stream to a file in VLC + other misc related things. System suddenly shuts off. I power back up the machine to find my archive I was compressing for the last 1 hour is now completely gone.....just vanished.
What did you expect to happen?

Compression of files completes successfully after a couple more hours.

Continued functional operation of the device.

Great amusement upon finishing the file stream output given the changes I had made.

Output of rpm-ostree status
State: idle
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:latest
                   Digest: sha256:4151c51fe4e5e394de97987a47600a09b0866a38569baeadccd88b146ea9875c
                  Version: 39.20240224.0 (2024-02-25T07:25:06Z)
          LayeredPackages: cargo libvirt micro mpv rclone rclone-browser rust snapd
                           virt-manager vlc
                Initramfs: '"-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf"'

  ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:latest
                   Digest: sha256:4151c51fe4e5e394de97987a47600a09b0866a38569baeadccd88b146ea9875c
                  Version: 39.20240224.0 (2024-02-25T07:25:06Z)
      RemovedBasePackages: python-unversioned-command python3-tkinter 3.12.1-2.fc39
                           python3-file-magic 5.44-5.fc39 python3-langtable 0.0.65-1.fc39
                           python3-regex 2023.12.25-1.fc39
                           python3-simpleaudio 1.0.4-11.fc39
          LayeredPackages: cargo libvirt micro mpv rclone rclone-browser rust snapd vlc yad
                Initramfs: '"-I /etc/crypttab /etc/modprobe.d/amdgpu.conf /etc/modprobe.d/deck-blacklist.conf"'

Hardware
Lenovo Legion Go
Extra information or context
DMESG Output:
dmesg_out.txt
RPM-OSTREE Ootput:
rpm-ostree_status.txt

It should be noted that I've been experiencing lockups basically since the beginning when I started  using Bazzite. Not often enough to really complain, but enough times that it's caught my attention.

A dmesg containing logs for this would be helpful

A dmesg containing logs for this would be helpful

I'm sorry I don't understand, is that different that just "sudo dmesg > dmesg_out.txt", because I have that one uploaded above. You can find it under Extra Information or context: DMESG Output:dmesg_out.txt

Apologies, couldn't see that from my phone for some reason. I'll take a look!

I'll submit this as well just in case, not sure what's going on but there are segfaults with something called gldriverquery.
journalctl_dmesg.txt

Hey, so I just recalled that part of what I was doing, I had forgotten about momentarily, but I've found my vanished archive files.....I had forgotten I'd mounted an external drive to the folder in my user home that I was checking. I'm still locking up somewhat frequently however.

bazzite has a tendency of automounting drives to odd locations without user input upon detection despite having the setting turned off in the KDE Settings app.


Support for console.group

Looks like Firebug 3.0.0.alpha9 is missing support for console.group and console.groupEnd. In Firebug 2 it would create a collapsed/expanded grouping item in the console, but right now it still displays every line.

Reported DevTools-side here:
https://bugzilla.mozilla.org/show_bug.cgi?id=755534
I don't know what is the best solution here :

wait for an implementation DevTools-side (or propose a patch to them)
do it Firebug-side, if in every case that's the same effort

I don't know what is the output in Firebug.next (I can't test that right know).
Florent

This may be the wrong place to ask this, but what is the general thinking around Firebug 3 vs. DevTools? How does the Firebug team decide which features to implement in Firebug 3 vs. which features get passed off to the Firefox DevTools team?
For example -- I think the entire aesthetic of the Console tab in Firefox DevTools is horrendous compared to Firebug 2. It's very difficult to read (due to the awful text wrapping and lack of create separators) and is lacking a lot of features. Does Firebug intend on extending/replacing this layout at all?

This may be the wrong place to ask this, but what is the general thinking around Firebug 3 vs. DevTools? How does the Firebug team decide which features to implement in Firebug 3 vs. which features get passed off to the Firefox DevTools team?

That's the kind of questions we still are asking to ourselves.

Does Firebug intend on extending/replacing this layout at all?

Among other things, we're customizing the appearance of the DevTools to look like Firebug, yes.
Florent

This may be the wrong place to ask this, but what is the general thinking around Firebug 3 vs. DevTools? How does the Firebug team decide which features to implement in Firebug 3 vs. which features get passed off to the Firefox DevTools team?

We have some rules in place, roughly:

Features that are generally useful for everyone should be fixed on the platform
Features related to theme/layout (to make DevTools look like Firebug 2) belongs to Firebug3
Features related to 3rd party can be implemented in Firebug 3
Features that represents alternatives (and make DevTools closer to Firebug 2) belongs to Firebug 3
Features that can't be implemented in the platform can be considered for Firebug 3

So, console.group and console.groupEnd API should be implemented on the platform (sometimes we can impl it in FB3 if the platform ETA is tool long).
Honza


Autocomplete on macOS interferes with typing

Describe the issue
The macOS keyboard's autocomplete is interfering with the ability to correctly type content into the app.
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Install Zashi iOS on an ARM64 Macbook.

Start typing into the memo field.

Expected behaviour
What I type should be what ends up in the memo field.
Actual behaviour + errors
Every so often parts of words disappear. When typing slowly, it appears that macOS attempts to autocomplete a word, and then the next letter typed replaces the first part of the word instead of being appended to it.

App Version: 0.2.0 (14)
iOS Version: macOS 14.2.1
Device: (if applies) Macbook Air M1.

Maybe not related, but I have very similar, maybe same bug on my iPhone every so often on not Zashi but random apps using both default keyboard or some others. So just maybe it's a bigger issue somewhere deeper not Zashi?

Maybe not related, but I have very similar, maybe same bug on my iPhone every so often on not Zashi but random apps using both default keyboard or some others. So just maybe it's a bigger issue somewhere deeper not Zashi?

I think this is a system level bug, nothing that can be fixed on Zashi level. But will investigate it at some point in near future. @true-jared is this a Zashi 1.0 hard requirement? If you read the desc, it's a case when Zashi is installed on a macbook, I don't think this is considered a valid case for Zashi 1.0.

I agree @LukasKorba, if this is not an issue/blocker on the mobile device, we should push this to post-Zashi 1.0 and investigate it later on.

A user can probably work around this by turning off "inline predictive text" globally. That said, it's obviously still a bug in the app, relative to other macOS apps.
Another possibility is to turn off autocomplete in the app for all text fields that it affects:
textField.autocorrectionType = .no
textField.spellCheckingType = .no

Fixed in Zashi 1.2


Novmar/orange pi zero2 support

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Added armTrustedFirmwareAllwinnerH616 to  all-packages.nix.

Hello, is there some problem with that PR ?

Hi, sorry it took so much time to circle back up to this PR.
Thank you for the contribution!


Add example/test workflows

Current dependencies on/for this PR:

main

PR #3   👈

This comment was auto-generated by Graphite.


ADD INCLUDE macro not replaced

This page has several occurrences of the text "ADD INCLUDE".  From the positioning it looks that this was a macro that has not been replaced prior to publishing the content
Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4eb792f3-7edc-76bd-235b-39f412d1c990
Version Independent ID: a3a8442a-f3d9-7c4e-a70a-86b3133d562c
Content: How to Add Fields to a Word Report Layout - Business Central
Content Source: business-central/ui-how-add-fields-word-report-layout.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: jswymer

Thanks for the feedback! We've fixed the article, and the update will be published soon.

Now live.


Publish to VSCode marketplace on CI?

Looks like we can leverage https://github.com/marketplace/actions/publish-vs-code-extension to automate updating the extension.

Ehh we could, but I'd just end up regenerating the access token anyway. I'll keep it local for now. If we end up publishing often enough we can automate it later.


Daemon Threads with Ensemble sampler not terminating.

I was running some code where I iterated over ~1000 objects, and performed an emcee sample on each. Each iteration generated a new sampler, but the previous one should have been collected so there should've been no issue. However, I noticed I was having a memory leak, and after much digging I found that there was a daemon thread running that kept a reference to the sampler's pool attribute. I called sampler.pool.terminate() after the run_mcmc call and the leak vanished. I don't know what would be the cause, but it was causing my job to crash after ~80 iterations on a machine with 16GB memory.

I am also seeing a substantial memory leak between individual sampler runs. The problem manifests as N idle threads of approx 1Gb each (I have a nasty space...), where N is (about) number of threads+number of walkers.
My problem is 100% reproducible, but each sample takes about 20hrs to run. I'm going to see if the sampler.pool.terminate() call helps, and if so, will check your branch. I should have more info next week.

Awesome, looking forward to hearing back, @mikelum


Added times with fractional values#469

Add a verification for strings with times like seconds with fractional values to fix #469.
Now we can use strings with fractional seconds.
>>> search_dates("'init-local' at secs Thu, 05 Jul 2018 15:13:48. Up 34.78 secs.")

[('05 Jul 2018 15:13:48', datetime.datetime(2018, 7, 5, 15, 13, 48)),
 ('Up 34.78 secs', datetime.datetime(2018, 7, 5, 15, 14, 22, 780000))]

I don’t think “Up 1 second” refers to a point in the future, but a point in the past. It is a duration between a point in the past and the present (it has been up for 1 second, so it started being up 1 second in the past).


[Documentation] Multi-line key ?

When the key is very long, I would like to be able to split it in multiple lines:
key: ${{  A }}- ${{  B }}-${{  C }}-${{ D }}

Instead I would like something like:
key: |
  ${{ A }}
  ${{ B }}
  ${{ C }}
  ${{ D }}

Which is much more readable when the key expressions are complicated.
However it's not currently clear whether this is supported or not ? Are spaces in the key allowed ? What about newlines ?
What about ?
key: >-
  ${{ A }}
  ${{ B }}
  ${{ C }}
  ${{ D }}

Looking at the examples, I can't find a key using newlines: https://github.com/actions/cache/blob/main/examples.md

If this isn't supported currently, it would be a nice feature request.
If this is supported, it would be nice if the doc was showing an example of multi-line.

@Conchylicultor Yes multiline is supported but it does add 1 extra space after every line which seems to be ok.
I tried with this workflow -
    - uses: actions/cache@757c5a8ca4ffdc40ccfb58f32d54537a4d090dfb
      id: cache
      with:
        path: cache-folder
        key: >-
          ${{ runner.os }}
          -${{ github.sha }}
          -key

But the key created here is "Linux -70e0ba076fc22fb98faf61422d401d6ff1313a53 -key" , which does seem to work fine.
I would not recommend adding this to the docs as none of the keys have spaces in them.
More context on the yaml multiline strings can be found at https://yaml-multiline.info/ . There seems to be no way for now to write multiline without adding an extra space. If you any more questions, feel free to reopen.


IGNITE-12364 Migrate JMS module to ignite-extensions

@samaitra, please proceed with the commit. The changes look good to me.

@dmagda thank you, I have merged the changes.


Use the Self annotation in implementation blocks

Description
In Rust, when implementing traits the type Self is used instead of the concrete type. This provides a more flexible and generic API design and it promotes code reusability and simplifies the creation of fluent interfaces. The same has now been done for Sway.
Checklist

[ ] I have linked to any relevant issues.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[ ] I have requested a review from the relevant team or maintainers.

Perhaps this PR could also refactor sway-lib-core? E.g. at least some implementations in primitive_conversions.sw, primitives.sw and primitives.sw could also use Self.

You read my mind, done 😜

Awesome! =)


Make LayerNormBasicLSTMCell compatible with datatypes other than float32

LayerNormBasicLSTMCell only supported float32 so far. With this patch other datatypes such as float64 are available too. The datatype doesn't have to be specified explicitly but it is deducted from the input data as it already happens for example for BasicLSTMCell.

Can one of the admins verify this patch?

@ebrevdo any cycles for this?

No one else should call _norm from outside this module... Does anyone?
On Sep 17, 2017 9:40 AM, "Maximilian Bachl"<EMAIL_ADDRESS>wrote:

@muxamilian commented on this pull request.
In tensorflow/contrib/rnn/python/ops/rnn_cell.py
https://github.com/tensorflow/tensorflow/pull/12209#discussion_r139315193
:

@@ -1303,24 +1303,25 @@ def state_size(self):
def output_size(self):
return self._num_units

def _norm(self, inp, scope):

def _norm(self, inp, scope, dtype=dtypes.float32):

No, you don't need it but in case some legacy code calls _norm directly –
for whatever reason – the default argument prevents this code from breaking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/12209#discussion_r139315193,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtim38RuWEV-z0Dx8SGawkg-QP8qf89ks5sjUtxgaJpZM4O0ckU
.

Not that I know of anyone doing that... I thought the default value wouldn't hurt anyone either.

sounds fine.
On Sun, Sep 17, 2017 at 11:37 AM, Maximilian Bachl<EMAIL_ADDRESS>
wrote:

Not that I know of anyone doing that... I thought the default value
wouldn't hurt anyone either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/12209#issuecomment-330069160,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtim9rK7nWl59QSKJ9uEEc1NkNgl3kdks5sjWblgaJpZM4O0ckU
.

Any updates on this?

Jenkins, test this please.

Kokoro isn't reporting status atm.


Fix issues with sample WoT TD

Add "opcua:type": "nsu=http://opcfoundation.org/UA/PNEM/;i=3005", to root.
change modbus: to modbus+tcp:

Fixed with https://github.com/OPCFoundation/UA-EdgeTranslator/commit/ee6b2601fc5db002feedc0c1167c876d361eba1c


The client library link is broken

https://googleapis.dev/python/billing/latest gives a 404.

Will be fixed by #5
https://googleapis.dev/python/cloudbilling/latest is the correct link


Add Continuous Access Evaluation (CAE) support for service principals

For details, see https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1597935.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'IoT:0.15573,Azure.Core:0.059298247,Cosmos:0.05700755'

Reopening issue for Gallium (feature was kept in beta)

Related https://github.com/Azure/azure-sdk-for-python/pull/30777


How to get UserName or user information from an OpenIdConnect server?

I use IdentityServer 3 v2 as server.

The user name/info is presumably in the claims returned by the server, isn't it?
Can you provide more information about the scenario?


Updating the section to be a warning.

This is a common issue that developers appear to be missing. Maybe making it a warning will make it stand out more and our vendors will stop making this mistake.

Hi @jasonepperly,
Do you have any objection if I moved these warnings to the top of the pages?

Top of page or top of remarks would be great!

From: Amy Viviano @.>
Sent: Thursday, March 2, 2023 2:33:26 PM
To: MicrosoftDocs/windows-driver-docs-ddi @.>
Cc: Jason Epperly @.>; Mention @.>
Subject: Re: [MicrosoftDocs/windows-driver-docs-ddi] Updating the section to be a warning. (PR #1424)
Hi @jasonepperlyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjasonepperly&data=05|01|jasone%40microsoft.com|81486e9085d9495642f008db1b54fe7a|72f988bf86f141af91ab2d7cd011db47|1|0|638133824092378988|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RBS0vm83Lx0joNLsjnyheCJqGcCzzSWxRSvIdEGrZOw%3D&reserved=0,
Do you have any objection if I moved these warnings to the top of the pages?
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindows-driver-docs-ddi%2Fpull%2F1424%23issuecomment-1452442465&data=05|01|jasone%40microsoft.com|81486e9085d9495642f008db1b54fe7a|72f988bf86f141af91ab2d7cd011db47|1|0|638133824092378988|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TFWYYKtukDWYAqgPu2mZD8PQyorefd5zipMLYZwArRQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHP6ZTLNTJOESYA4IEPHMR3W2DYYNANCNFSM6AAAAAAVNX5QSI&data=05|01|jasone%40microsoft.com|81486e9085d9495642f008db1b54fe7a|72f988bf86f141af91ab2d7cd011db47|1|0|638133824092378988|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=gHwb15DTPg9On5KXMFppFcjj2ryzMiiQZHXBy02P%2BIo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


support mixpanel analytics

add mixpanel analytics
modify appopen event to only emit for non logged in users. (to save events amount)

@patpedrosa
to save on event calls i've modified the app_open to only fire for non-loggedin users.
for dashboards that rely on app_open event you will need to now filter on "signedup" user property if you need to filter by registered users


token aware routing broken + code complexity of map_replicas too high with vnodes

token aware routing is broken
complexity of map_replicas is too high (proportionnal to number of tokens) and leads to timeout on reconnect of control connection, if timeout is set at <3s for a cluster of >10 nodes with vnodes activated.

@ecourreges-orange Thanks for your feedback. This is something I'll starting digging into first thing tomorrow. First, I'll get token-awareness  working properly then I'll look into reducing the complexity of map_replicas().

Sorry, I don't know where to post issues/feature requests, but here are the ones related to this Pull Request:

The driver should connect randomly to the contact_points at startup, not in lexicographical order => this will limit the impact of having the control_connection host/node down. The java driver already does that.
The useSchema and tokenAware functionalities should be independent, as useSchema induces unneeded cost when just using tokenAware. The driver should only get the keyspace list.
In case of connection_control reconnect, map_replicas() should be called only once at the end, not for every node
Complexity N of tokens_to_replicas should be reduced and tested on a cluster of at least 10 nodes with vnodes (i.e. >=2560 token ranges).
Request Timeout should be decorrelated from control_connection actions => in the case above, if you set requestTimeout too low, you end up with an infinite loop (with 100% CPU) of control_connection reconnects that do map_replicas()+timeout.
on_query_meta_schema() should not clear the token_map built in on_query_hosts()
All of this must be unit tested
Thank you.
Regards,
Emmanuel.

Thanks again. For future issues you can use JIRA: https://datastax-oss.atlassian.net/, but feel free to continue using GitHub. I've created this issue: https://datastax-oss.atlassian.net/browse/CPP-389 to track the problems with token awareness (and also linked related issues).
The randomizing contact points improvement is tracked in this issue: https://datastax-oss.atlassian.net/browse/CPP-193

Issues addressed @ 4c744dc6537596de05ceb1c9da4ff8da67e9f586. Please let use know if this resolves your issues.


Both Sync and Async I/O degrades its performance after thread increases

Releated PR https://github.com/kuzudb/kuzu/pull/2544
Currently the copy_node (write) performes the best when its single threaded and as # of thread increases, the performance gets worse.
 Test on various parquet files
Parquet file: 64 row group x 64 x 2024 rows  (8000k) with no string columns except for primary key

thread
average performance
total write CPU time (ms)
total write wall clock time

1
8265.741
24840.541
5785.359

2
9660.272
23469.220
5994.398

4
14215.99800
63782.983
9673.685

8
35521.977
261676.507
25066.172

32
219510.595
2560386.155
97496.610

Disable compress:

thread
average performance
total write CPU time (ms)
total write wall clock time

1
9907.258
31406.560
7675.464

2
16241.601000
69737.259
12994.376

4

175680.384
25395.951

5000k with 1 row group and no string columns

thread
average performance

1
2064.91

2
2252.432

4
2102.796

5000k csv file

thread
average performance
total write cpu time  (microseconds)
total write wall clock time

1
2439.594
8190975
2033320

2
2737.176
11108623
2313743

4
5049.973
31248680
456303

8
9453.278
87034638
8212015

50000k parquet

thread
average performance
total write cpu time  (microseconds)
total write wall clock time
backend stall
context -switch
perf elapse

2
36229.629
333007.586
35292.730
104 x 10^9 backend cycles
8e6
46.885s

32
121369.23
1861863.494
118645.931
193 x 10^9 37.37%
5e6
35.278s

on master

thread
compressed(1.1G)
not compressed (1.4G)

1
15176.496
17960.552

2
17751.456
19843.161

4
22089.014
29394.547

8
65322.225
62095.32

32
278003.354
333622.317

thread
write

1
391MB/s

2
541MB/s

4
819MB/s

8
1410MB/s

32
1232MB/s

128
3545MB/s

It's due to PROFILE will have very large overhead on large threads


3dt bug fixes

increase exhibitor response timeout to 11sec.
If a master node goes down, a get request to exhibitor may take up to 10 sec.
(http://<IP_ADDRESS>:8181/exhibitor/v1/cluster/status).
https://github.com/dcos/3dt/pull/50

fix typo
https://github.com/dcos/3dt/pull/51

🚢


Lambda expression confuses branch measurement

A line like this:
    fn = make_sortable or (lambda x: x)

is marked as being a branch with a missing jump to "exit", maybe only if the lambda isn't used.

Bitbucket: https://bitbucket.org/ned/coveragepy/issue/90

Has this been fixed? I'm still seeing issues.
conversion_lookup: Dict[Type[Union[int, bool, float, str, Path]], Callable[[Any], str]] = {
        int: str,
        bool: str,
        float: str,
        str: str,
        Path: lambda x: str(x.as_posix()),
    }

coverage 7.2.7

@sigma67 since this ticket is so old, it would be better to open a new issue with complete details of what the problem is and how to reproduce it.

The issue was actually on my end, the lambda function in question was in fact not covered. Sorry for bothering you about it.


Add description of the problem statement for this workshop

Ie. build a text classifier ...

Resolved with commit:
https://github.com/data-science-on-aws/workshop/commit/e9388ab3f16b5d2b3dbc615eedfdff0eefc41615


Rename to liferay-themes-toolkit

We probably don't want to rename the actual repo so as not to break bookmarks (or maybe we do, I don't know if GitHub makes it possible/easy to redirect people), but at least in terms of the documentation and internal terminology we want to rebrand this as "a themes toolkit" as opposed to an SDK because it is closer in spirit to a toolkit than a set of APIs, and it's a pattern we've been following in other places, according to what I've heard from @jbalsas.

I don't know if GitHub makes it possible/easy to redirect people

According to the docs, redirects will take effect automatically if we rename the repo.

Repo has been renamed now; once the in-flight PRs land, will do a follow-up pass through to make sure all the internal references are updated. (For example, in my first pass at this I change "liferay-themes-sdk" to "liferay-themes-toolkit", but the final name that we settled on is "liferay-js-themes-toolkit".)

Now we have to fix all our training slides :)

Yes @yuchi, although the good news is that the old URLs will still work in the meantime (even git clone etc will work with the old URLs).

Closing this one because it is basically done on both the v8 (#197) and v9 branches (68b92f3af767f6511d0).


Added my name to CONTRIBUTORS.md

Hello, My name is Akshat Gadodia and today I'm starting my open source journey

Hey there,
Thanks for your PR & contribution :wave:!
Don't forget to join follow me, join our organization, & follow our organization to stay updated with the latest developments 💻
Thank you, and have a good day ahead 😊


Clean up mcar-luigi.cfg configuration for MCAR curation workflow

[ ] As noted in https://github.com/BlueBrain/morphoclass/issues/4#issuecomment-1154943646, the skip=True is ignored. So we should remove it from mcar-luigi.cfg configuration to avoid confusion.
[ ] The two stages EnsureNeuritesOutsideSoma and ErrorsReport are run by the moprhology workflow for MCAR curation. So we should also mention them in the mcar-luigi.cfg file even if we are not using them.

Which stages are executed by MCAR curation?

Our MCAR curation stage in the dvc.yaml calls moprhology-workflows on the luigi stage Curate: https://github.com/BlueBrain/morphoclass/blob/65a4909b0ee3250756a50b3f58e4e1356aa38438/dvc/dvc.yaml#L58-L62
The stage Curate depends on 14 different output luigi stages: https://github.com/BlueBrain/morphology-workflows/blob/bdd6cab92fcc35f01fb76c01d006619e47ceffcd/src/morphology_workflows/tasks/workflows.py#L72-L96
These 14 stages do not have any further stage dependencies (except for some cross-dependencies among those 14 stages).
So, in total, the follow 15 luigi stages are run:

Align
CheckNeurites
Collect
Curate -- the main stage we want to execute
DetectErrors
EnsureNeuritesOutsideSoma
ErrorsReport
ExtractMarkers
Orient
PlotErrors
PlotMarkers
PlotMorphologies
Recenter
Resample
Sanitize


js instead ts?

Thanks for the nice plugin. Is there a way to use it as pure javascript (not as a module)?
Thanks!

you can now use<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Thanks a lot!
I wanted to import index.min.mjs but get following error:
openseadragon-select-plugin.min.mjs:1 Uncaught SyntaxError: Unexpected token 'export' (at openseadragon-select-plugin.min.mjs:1:13075)
Seems like this is a Node.js depending module. Is there a way to use it without Node.js? My JS does not know export nor require.