Want to terminate CI pipeline if any fatal error comes

@prymitive I am using pint in ci referring
And after testing I found it is generating a report, in place of that what I want is to get error while pipeline build ( like ./pint lint rules.yaml works) and get error in github workflow check and if any fatal error comes that PR will be failed to get merge. How can I do that? I am confused if I can do any configuration for that. Please help me here.

pint ci exits with a non-zero code if there are bug level problems reported.
You can set it to a lower level if you want by passing fail-on (pint ci --fail-on=warning
$ ./pint ci -h
[..]
   --fail-on value, -w value      Exit with non-zero code if there are problems with given severity (or higher) detected (default: "bug")
[...]


.net version upgrade

Hey there,
Following you on youtube and linked in.
Thanks for all the useful content that you shared.
I wanted to contribute to your repo.
I am able to build and run successfully.
Can you check my changes, please?

I am sure that there are a lot to learn from you. Please keep review

@m-jovanovic  Hey finally ı have used to GitHub editor to fix the indentation issue you can check it now.
I was having issue with VS or VSCode

@EmirhanAksoy I think we should also update the README to state Implement using .NET 6...

README.md was updated

Fantastic work, @EmirhanAksoy !

@m-jovanovic  Thanks for caring 😸

@EmirhanAksoy We forgot to fix the build pipeline! 😁

Let me check it @m-jovanovic


[refactor] basis_keys to list

Cast basis keys to list so it can be serialised in torch.save()
If not, this happens (tested on PyTorch 2.5.1+cu124)

torch.save(model, "test.pt")
Traceback (most recent call last):
File "", line 1, in
File "/home/hilbert/miniconda3/envs/.../lib/python3.11/site-packages/torch/serialization.py", line 850, in save
_save(
File "/home/hilbert/miniconda3/envs/.../lib/python3.11/site-packages/torch/serialization.py", line 1088, in _save
pickler.dump(obj)
TypeError: cannot pickle 'dict_keys' object

@Chokyotager thanks Hilbert!


Add a disclamer for overlayStyles

I've spent about an hour trying to get overlay fonts a bit bigger relying on the readme, all to find out that style overriding hasn't been released yet. Maybe the readme should include a disclaimer in such cases?

Oh whoops, it's actually pretty rare for me to not have released master. I'll cut a release now.

Will be released shortly as 2.21.0


support custom options

Current coverage is 13.83% (diff: 3.70%)

Merging #16 into master will decrease coverage by 3.06%

@@             master        #16   diff @@
==========================================
  Files            16         16
  Lines           142        159    +17
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits             24         22     -2
- Misses          118        137    +19
  Partials          0          0

Powered by Codecov. Last update 5095838...d218afa


small fixes

Codecov Report
Base: 66.02% // Head: 99.75% // Increases project coverage by +33.72% :tada:

Coverage data is based on head (251bbe3) compared to base (7790d9e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##              1.2     #819       +/-   ##
===========================================
+ Coverage   66.02%   99.75%   +33.72%
===========================================
  Files         100       48       -52
  Lines        4168     2412     -1756
  Branches      540      351      -189
===========================================
- Hits         2752     2406      -346
+ Misses       1397        2     -1395
+ Partials       19        4       -15

Flag
Coverage Δ

foundry
?

production
99.83% <ø> (ø)

reference
99.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/BasicOrderFulfiller.sol
100.00% <ø> (+2.20%)
:arrow_up:

contracts/lib/FulfillmentApplier.sol
100.00% <ø> (+16.32%)
:arrow_up:

contracts/lib/OrderCombiner.sol
100.00% <ø> (ø)

reference/lib/ReferenceOrderCombiner.sol
100.00% <ø> (ø)

reference/lib/ReferenceOrderFulfiller.sol
100.00% <ø> (ø)

reference/lib/ReferenceOrderValidator.sol
98.32% <0.00%> (-1.15%)
:arrow_down:

contracts/lib/CounterManager.sol
100.00% <0.00%> (ø)

contracts/lib/OrderFulfiller.sol
100.00% <0.00%> (ø)

contracts/lib/ZoneInteraction.sol
100.00% <0.00%> (ø)

... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Execution failed for task ':superwallkit_flutter:verifyReleaseResources'.

Hi all,
I added "superwallkit_flutter: ^1.1.9" to my project, but I'm still encountering the following error when running
"flutter build apk --release". (on debug it works normal)
I also tried this on a newly created project, and the same issue occurred. Below are the error details and the output from flutter doctor.
Im using gradle 8.4, kotlin 1.9.23, minSdk-26, compileSdk-34
ERROR:"FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':superwallkit_flutter:verifyReleaseResources'.

A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
Android resource linking failed
ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:3: AAPT: error: resource android:color/system_background_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:4: AAPT: error: resource android:color/system_error_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:5: AAPT: error: resource android:color/system_error_container_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:6: AAPT: error: resource android:color/system_on_surface_light not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:7: AAPT: error: resource android:color/system_primary_light not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:8: AAPT: error: resource android:color/system_surface_light not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:9: AAPT: error: resource android:color/system_on_background_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:10: AAPT: error: resource android:color/system_on_error_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:11: AAPT: error: resource android:color/system_on_error_container_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:12: AAPT: error: resource android:color/system_on_primary_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:13: AAPT: error: resource android:color/system_on_primary_container_dark not found.

 ERROR: /Users/boryskusmirek/Documents/dev/test2/build/superwallkit_flutter/intermediates/merged_res/release/mergeReleaseResources/values-v34/values-v34.xml:14: AAPT: error: resource android:color/system_on_secondary_dark not found."

flutter doctor:
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64, locale
en-PL)
• Flutter version 3.22.2 on channel stable at
/Users/user/Documents/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 761747bfc5 (3 weeks ago), 2024-06-05 22:15:13 +0200
• Engine revision edd8546116
• Dart version 3.4.3
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/user/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Utilities/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
17.0.10+0-17.0.10b1087.21-11609105)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Utilities/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.10+0-17.0.10b1087.21-11609105)
[✓] VS Code (version 1.90.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.90.0
[✓] Connected device (4 available)
• sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64 •
Android 14 (API 34) (emulator)
• macOS (desktop) • macos • darwin-arm64 •
macOS 14.5 23F79 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin •
macOS 14.5 23F79 darwin-arm64
• Chrome (web) • chrome • web-javascript •
Google Chrome 126.0.6478.126
[✓] Network resources
• All expected network resources are available.
• No issues found!

Inexplicably, I have the same issue on my device, but my CI environment completes the release build with no issue at all (it's live on the Google Play Store). Investigating now.

I cannot fathom why this works on CI but not locally, but after a lot of digging, I did find a workaround to get the local release build to compile: Manually modifying the local superwallkit_flutter build.gradle file and changing the defined compileSdk from 33 to 34.
Specifically:

Navigate to the superwallkit_flutter local pub cache and open it's build.gradle

For me it was in ~/.pub-cache/git/Superwall-Flutter-3636b62ea8abe21afddf3c3d2b14df08dcf429fa/android/build.gradle

Change the compileSdk from 33 to 34
With this change, flutter build apk —release should complete successfully.

Two main resources I found that led me to this workaround:

https://github.com/flutter-stripe/flutter_stripe/issues/1676#issuecomment-1994166456
Getting "verifyReleaseResources" error after upgrading React Native

thanks, this workaround worked for me


Microsoft.Web/connections (2016-06-01)

Describe the noise
Read-only data and parameterValues with expressions
Resource type (i.e. Microsoft.Storage/storageAccounts)
Microsoft.Web/connections
apiVersion (i.e. 2019-04-01)
2016-06-01
Client (PowerShell, Azure CLI, or API)
PowerShell
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
    {
      "apiVersion": "2016-06-01",
      "type": "Microsoft.Web/connections",
      "name": "[variables('storageAccountConnectorName')]",
      "location": "[resourceGroup().location]",
      "dependsOn": [
        "[resourceId('Microsoft.Storage/storageAccounts', variables('storageAccountName'))]"
      ],
      "tags": "[variables('tags')]",
      "properties": {
        "displayName": "[concat('Azure Table Storage (', variables('storageAccountName'), ')')]",
        "parameterValues": {
          "storageAccount": "[variables('storageAccountName')]",
          "sharedKey": "[listKeys(resourceId('Microsoft.Storage/storageAccounts', variables('storageAccountName')), '2019-06-01').keys[0].value]"
        },
        "api": {
          "id": "[concat(subscription().id, '/providers/Microsoft.Web/locations/', resourceGroup().location, '/managedApis/azuretables')]"
        }
      }
    }

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)
No changes.
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
~ Microsoft.Web/connections/mystorageaccount [2016-06-01]
    - properties.api.brandColor:  "#804998"
    - properties.api.category:    "Standard"
    - properties.api.description: "Azure Table storage is a service that stores structured NoSQL data in the cloud, providing a key/attribute store with a schemaless design. Sign into your Storage account to create, update, and query tables and more."
    - properties.api.displayName: "Azure Table Storage"
    - properties.api.iconUri:     "https://connectoricons-prod.azureedge.net/azuretables/icon_1.0.1327.1946.png"
    - properties.api.name:        "azuretables"
    - properties.api.type:        "Microsoft.Web/locations/managedApis"
    - properties.nonSecretParameterValues:

        storageAccount: "mystorageaccount"

    - properties.testLinks: [
        0:

          method:     "get"
          requestUri: "https://management.azure.com:443/subscriptions/89eeadc3-f5ad-436c-8afa-d5e5db194363/resourceGroups/refunderware-dev-east/providers/Microsoft.Web/connections/refunderwaredeveast/extensions/proxy/Tables?api-version=2016-06-01"

      ]
    + properties.parameterValues:

        sharedKey:      "[listKeys(resourceId('Microsoft.Storage/storageAccounts', variables('storageAccountName')), '2019-06-01').keys[0].value]"
        storageAccount: "mystorageaccount"

Additional context
Add any other context about the problem here.

properties.parameterValues shows up as Create because the it may contain secrets, and the RP removes it in GET response. We'll also need to hide it properties.parameterValues in What-If results.

How come we don't only suppress properties.parameterValues.sharedKey? If we suppress all of properties.parameterValues won't that hide too many properties?

[w19].

This fix should be fully deployed. Please let us know if you still see this issue.


Restore only subtree of snapshot via : syntax

Output of restic version
0.9.4 (debian package + alpine image)
What should restic do differently? Which functionality do you think we should add?
According to this forum post I would like to have a possibility to restore just a subtree of my snapshot, in my case I have a structure like this (example)
| /data
| - | /changes
| - | - | /change01.txt
| - | - | /change02.txt
| - | /designs
| - | - | /picture.png
| - | - | /logo.svg

The goal would be, that I can restore either everything without the data folder so I can override my folder (in case of emergency) or restore a subtree to another folder e.x. designs. I have not seen something like this in documentation. Currently I have to make a detour over /tmp folder which is not really good (imo)
What are you trying to do? What problem would this solve?
Alex Weiss mentioned that a syntax like restic restore <hash>:<subtree> might be the solution. Seems like a good idea to me. But if you want to implement it with --subtree= this would be also fine for me
Did restic help you today? Did it make you happy in any way?
Restic helps me to get a rather comfortable experience of implementing file backups in our project. I like the idea of the creator really much to make it repository likely and it feels familiar a little bit like git to me now. I think incremental backups is a difficult task to do but you do a great job 👍🏻

Wouldn it be sufficient for your case to use --exclude /data like described here https://restic.readthedocs.io/en/latest/050_restore.html ? You can also combine with --include filter. Or am I getting something wrong?


No model.r files generated

Hi. I ran execute MACS2 as below:
$macs2 callpeak -t ID1_sort.bam -c HALO_sort.bam -g 2.1e9 -B -f BAMPE -n ID1-HALO --outdir macs2-out 2> err-macs2.log
I have the following outputs:
ID1-HALO_control_lambda.bdg  ID1-HALO_peaks.xls    ID1-HALO_treat_pileup.bdg  ID1-Y_peaks.narrowPeak  ID1-Y_summits.bed
ID1-HALO_peaks.narrowPeak    ID1-HALO_summits.bed  ID1-Y_control_lambda.bdg   ID1-Y_peaks.xls         ID1-Y_treat_pileup.bdg

I realize that there is supposed to be model.r output as well but it is missing. Any idea how I could generate this file? The version of macs2 <IP_ADDRESS>60309
.

Hello,
I am facing the same issue. I am using macs2 2.1.2. If I run macs2 with the flag -f BAMPE, model.R is not generated. However, when I run without the -f flag, macs2 generates a model.R file but detects as bam format instead of bampe. I want to be able to generate the model.R file for my data but i am not sure what the bug is here? I'd really appreciate your help.

In BAMPE mode, there is no need to estimate fragment lengths since the actual insertion length for each read pair will be considered. That's why there is no model.R generated.


ESM file extensions in codebase to use .ts rather than .js

This is dependent on https://github.com/microsoft/TypeScript/issues/50457 so will implement this on November 15th!

#72


python Version Error

I have a Linux machine.
pip install weave throws me an error.
error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-yfc8hmif/weave_c37d95621c4049e2941ad6a0cd61fdaf/setup.py", line 24, in <module>
          raise RuntimeError("Python version 2.6 or 2.7 required.")
      RuntimeError: Python version 2.6 or 2.7 required.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

Python 2.6 or 2.7 requires.  I don't think this should be an issue. I am using python 3.8.
Thanks for your help. :)

python3.9 with following command solved the problem.
python -m pip install weave
Thanks :)


terraform init not working

The terraform init command doesn't create a state file

I think the main.tf file must contain some info like the provider details

thans buddy


Resolve inconsistent processing logic in mux.ServeHTTP

Fix #535.
At high level this PR aims to fix the issue, that when there are two httpserver.mux rules, with same path but different Method, only first one is considered.
This involves following changes:

Extract lines https://github.com/megaease/easegress/blob/36480f34946b464820360ea1a535880fd7e7751f/pkg/object/httpserver/mux.go#L385-L426 to own function SearchPath
make struct muxPath public: MuxPath so that it can be used as a return type

Codecov Report

Merging #536 (2c3c1d4) into main (8649d00) will increase coverage by 0.01%.
The diff coverage is 83.87%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   80.56%   80.57%   +0.01%
==========================================
  Files          88       89       +1
  Lines       10123    10154      +31
==========================================
+ Hits         8156     8182      +26
- Misses       1514     1517       +3
- Partials      453      455       +2

Impacted Files
Coverage Δ

pkg/util/pathsearch/pathsearch.go
83.87% <83.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36480f3...2c3c1d4. Read the comment docs.

IMHO, packages in the utils folder should only depend on the standard packages or 3rd party packages (although there are already exceptions).
The pathsearch package of this PR depends on the context package, and its interface/implementation is also tightly bound to HTTP, so I propose not to put it in the utils folder, and maybe we don't need to define the MuxPathInterface.

IMHO, packages in the utils folder should only depend on the standard packages or 3rd party packages (although there are already exceptions).
The pathsearch package of this PR depends on the context package, and its interface/implementation is also tightly bound to HTTP, so I propose not to put it in the utils folder, and maybe we don't need to define the MuxPathInterface.

Good point, I updated the PR and the description. It now involves less refactoring

@aniaan please help to review this PR.

Good refactoring, but please fix the errors

Good refactoring, but please fix the errors

Fixed!


No Random Battles

Random battles aren't triggered.

Added basic battle code, but so far, no attacks are dealt and no damage is done. Just menuing and some basic displaying

Done. All that's left to add is the upgrading stats code to the level up code.

Now stat upgrade code is complete.


Unimplemented examples and test plan files in the repository

Creating it as an issue, As there is no discussion tab.
I have been studying this repository and noticed that there are numerous files and directories within the examples folder containing empty files or unimplemented examples. Examples include ntcu04.m.cpp, ntcu05.cpp, and so on. Additionally, I've observed some test plan files that seem incomplete.
Is there a roadmap or plan for these files? I am interested in contributing to the development of these examples and test plans. Could someone provide guidance or direction on how to proceed with these unimplemented files?
Any information or assistance would be greatly appreciated.

Not all the planned example applications have been implemented, as you've noticed. You can start with a PR to implement ntcu04, which should do what ntsu04 does but with the non-blocking sockets and event loop stuff like in ntcu01.
By incomplete test plans I'm assuming you mean the documentation for test cases where the either the concern is undocumented, or the strategy to test that concern is undocumented. There are many test cases that have one or both those characteristics.  I think the priority should be do first implement the examples with empty main()s then you can start by creating an issue (or continuing this one) by proposing specific test driver files that you'd like to contribute changes to.


CRITICAL HTTPSConnectionPool error when 2 hours left

Saved token will expire in 1 hour 46 minutes, please consider renewing the session using the 'dds auth login' command.

but then
CRITICAL HTTPSConnectionPool(host='delivery.scilifelab.se', port=443): Read timed out. (read timeout=5) ERROR

Should be solved by the time out change.


Android - Scan - Icons in Scan receipt context menu appear after delay

Details

We're using expo-image's cachePolicy memory on Android to cache svg icons to memory in order to prevent icons appearing with delay when components that use icons are mounted.
Fixed Issues

$ https://github.com/Expensify/App/issues/34881
PROPOSAL: https://github.com/Expensify/App/issues/34881#issuecomment-1931010975
Tests

Go to 1:1 DM.
Create a Scan request using receipt taken via device camera or upload a high resolution picture.
Navigate to request details page.
Manually enter the amount.
Tap to open the receipt.
Tap 3-dot menu while the receipt is still loading (quick action).
Notice that when the context menu shows up the icons are already there and don't appear with delay anymore.

Create a Scan request using receipt taken via device camera or upload a high resolution picture.
Navigate to request details page.
Manually enter the amount.
Tap to open the receipt.
Tap 3-dot menu while the receipt is still loading (quick action).
Notice that when the context menu shows up the icons are already there and don't appear with delay anymore.

QA Steps

Go to 1:1 DM.
Create a Scan request using receipt taken via device camera or upload a high resolution picture.
Navigate to request details page.
Manually enter the amount.
Tap to open the receipt.
Tap 3-dot menu while the receipt is still loading (quick action).
Notice that when the context menu shows up the icons are already there and don't appear with delay anymore.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/56457735/e20f3147-abce-425c-8052-29038a5a1671

Android: mWeb Chrome
https://github.com/Expensify/App/assets/56457735/4d1506b2-c740-482a-a735-9c482a673379

iOS: Native
https://github.com/Expensify/App/assets/56457735/78900c5b-8ffc-4d4f-9bbe-c5be0aacf375

iOS: mWeb Safari
https://github.com/Expensify/App/assets/56457735/872f46f3-3fc5-474c-ba5f-ce55c50f34c3

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/56457735/f3039010-5538-44f6-b0f4-1c6b7df3be12

MacOS: Desktop
https://github.com/Expensify/App/assets/56457735/0269ed07-1225-428e-b374-88f166d3c48f

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@MonilBhavsar Just synced w/ main, all good -> ready for final review 🚀

Thanks!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.42-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


File Upload issue

Sometimes file are getting downloaded on the server but when it starts to upload on gofile.io it throughs the below error.
pyrogram.errors.exceptions.bad_request_400.MessageNotModified: Telegram says: [400 MESSAGE_NOT_MODIFIED] - The message was not modified because you tried to edit it using the same content (caused by "messages.EditMessage")

can you give the whole error including line number

check out the Heroku
mjgofile-logs-1651637696934.txt
log file

For some video files it happens I tried 2-3 times to upload but getting same error.


Use pytest>=3.0.2

The bug that lead to pin it (pytest-dev/pytest#1888) was fixed in 3.0.2

Thank you and thank you.

:+1: :smile:


Can't export results in json/geojson using geemap.zonal_statistics_by_group/geemap.zonal_statistics

Environment Information

geemap version: 0.11.1
Python version: 3.9
Operating System: Windows 10

Description
Dear Mr Wu,
Thank you for developing geemap. It is wonderful!
Currently, I am using geemap to perfom a zonal statitistic by group. I would like to export my results as a json or geojson.
However, when I set the output format to .geojson it retreives me an error ('The file type must be one of the following: csv, json, kml, kmz, shp').  Then, I set it back to json and retrives me ''The file type must be one of the following: csv, geojson, kml, kmz, shp Earth Engine no longer supports downloading featureCollection as shapefile or json.  Please use geemap.ee_export_vector_to_drive() to export featureCollection to Google Drive."
Same problem was encountered in the zonal_statistic function.
Thanks you in advance for your attention
What I Did
raster = ee.Image('users/fernandobezares/MCSNCyL/MCSNCyL_2021_viales')
in_zone_vector = ee.FeatureCollection ('users/fernandobezares/Admin_Units/Provincias_ETRS89')
out_file_path = 'statsGeeMap.json'
out_file_path2 = 'statsGeeMap2.geojson'

print('with json')
geemap.zonal_statistics_by_group(raster, in_zone_vector, out_file_path, statistics_type='SUM')

**Error Message 1 **
with json
Computing ...
The file type must be one of the following: csv, geojson, kml, kmz, shp
Earth Engine no longer supports downloading featureCollection as shapefile or json.
Please use geemap.ee_export_vector_to_drive() to export featureCollection to Google Drive.
Traceback (most recent call last):
  File "C:\Users\fbezares\anaconda3\envs\GEEAPI\lib\site-packages\geemap\common.py", line 5907, in zonal_statistics_by_group
    ee_export_vector(final_result, filename)
  File "C:\Users\fbezares\anaconda3\envs\GEEAPI\lib\site-packages\geemap\common.py", line 1307, in ee_export_vector
    raise ValueError
ValueError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\fbezares\Documents\01_Proyectos\03_DMM\Teledeteccion\GEEAPI\geoProcesosVicentee.py", line 33, in <module>
    geemap.zonal_statistics_by_group(raster2, in_zone_vector2, out_file_path, statistics_type='SUM')
  File "C:\Users\fbezares\anaconda3\envs\GEEAPI\lib\site-packages\geemap\common.py", line 5910, in zonal_statistics_by_group
    raise Exception(e)
Exception

Process finished with exit code 1

If I use geojson extension instead of json I get...
print('with geojson')
geemap.zonal_statistics_by_group(raster, in_zone_vector, out_file_path2, statistics_type='SUM')

Error Message 2
with geojson
The file type must be one of the following: csv, json, kml, kmz, shp

May be the answer to my question is already in the Error report "Earth Engine no longer supports downloading featureCollection as shapefile or json.  Please use geemap.ee_export_vector_to_drive() to export FeatureCollection to Google Drive."
However, I am curious why would this not work if it is a geojson and not a json. I presume that both json and geojson are not supported for direct downloads.
Thank you for your help.

Thanks for reporting. This bug has fixed. Please update geemap using geemap.update_package(). Then you should be able to use .geojson the format.

Thank you very much for your quick response. Now it worked for me. Wish you a good day.


NEXT-00000 - Add MediaHydrator & Update EntityHydrator

1. Why is this change necessary?

Using a large number of category entities including there media files takes a long time to hydrate
Specifically, there are two hydration points that last longer than others. This is the translation and media hydration of the category
Loading a large number of media entities without the MediaHydrator can take up some time, so this PR adds a new MediaHydrator class in the format of the already existing Category- & ProductHydrator classes
Additionally, the current implementation of translation hydration could call the serializer decoder twice with the same or a null value, which takes additional time. This PR adds checks there to compare the values and reuse the value without using the serializer again, if not required

For the performance example: The NavigationRoute, which (in my dev environment) loads around 550 categories including media files:
Before:

After: Saves ~44ms (~10ms from the translate function improvements & the other ~34ms from the MediaHydrator)

2. What does this change do, exactly?

Added MediaHydrator to perform media hydration faster
Changed MediaDefinition to include the new MediaHydrator class
Changed the translate function in EntityHydrator to remove duplicate field value serialization

3. Describe each step to reproduce the issue or behaviour.

Open the storefront with a large number of categories & media files

4. Please link to the relevant issues (if any).

/

5. Checklist

[X] I have rebased my changes to remove merge conflicts
[X] I have written tests and verified that they fail without my change
[X] I have created a changelog file with all necessary information about my changes
[X] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hey @akf-bw, thanks again for contribution, we have merged it for now and added a unit test for hydrator.
If you are interested how we want to improve the general performance of the store-api and storefront in general please take a look at this draft PR: https://github.com/shopware/shopware/pull/3613
With those changes the hydrator would not be needed anymore


Fiber

Early Preview. Testing my approach from https://github.com/iamdustan/tiny-react-renderer/pull/24.
Will update description later tonight or tomorrow.
To test:

Clone yarn install
node run.js
open second tab, run node_modules/.bin/react-devtools
enjoy.

This PR is intended to reimplement react-blessed on top of ReactFiberReconciler, the new (almost supported) renderer API. It is keeping the React 14.x stack reconciler support around for now by moving those files to src/stack. The shared utilities between stack and fiber have been moved to src/shared. The Fiber reconciler is entirely implemented right now in src/fiber/fiber.js. The other two files src/fiber/index.js and src/fiber/devtools.js exist to support react-devtools integration.
TODO:
Examples (as test cases)

[x] render examples/animation.jsx
[x] render examples/dashboard.jsx
[x] render examples/demo.jsx

Reconciler API

[x] removeChild
[x] insertBefore
[x] *Text* methods
[x] clean up screen.render() calls
[x] ensure event handlers work
[ ] consider using async scheduling (fiber feature)
[ ] consider supporting animation and deferred callbacks
[ ] figure out how to publish/version (current requirement involves npm installing an official renderer to get access to react-{renderer}/lib/ReactFiberReconciler.js

Current status:

Note that 2447 lines of the diff is yarn.lock. The primary fiber implementation is 182 lines of code.

That's really cool @iamdustan. Tell me when you are done with it and will merge. I guess we'll have to wait a bit for react 16 to be released though.

figure out how to publish/version (current requirement involves npm installing an official renderer to get access to react-{renderer}/lib/ReactFiberReconciler.js

Should we engage a discussion with react team about this?

I’ve half-spoken to them about how to distribute the reconciler. There isn’t a clear direction yet and I don’t think it’s high-pri. I’m going to start another conversation in the React Internals facebook group about it.

Added a couple more examples and have event handlers working. Honestly, idk if the last three items (async work) matters at this point. ReactDOM has it disabled for the initial fiber release and I think that’s okay here, too.
Regarding the publishing stuff, I’ll be opening an official issue on the React issue tracker later tonight or tomorrow. I think merging and publishing this as an alpha is okay (it should be feature compatible with previous releases, just on fiber and requiring a specific package of react and react-dom for the time being)

Thanks @iamdustan. I'll try to review the code thoroughly soon. I agree the most blocking point at that time is the fact that we'll need to rely on another renderer to get the necessary files to depend on. Just ping me on the issue you'll open please.

I am also open to modify some features of the library to "modernize" them in the process. The class system comes to mind :)

Issue for ReactFiberReconciler package opened at https://github.com/facebook/react/issues/9103.
Re: modernizing: I’ve started looking at integrating flexbox layout via Yoga. :)

Yes there was some idea once to adapt the CSS layout to the blessed styles. But I am not sure to see what it would entail.

Awesome stuff @iamdustan! I am playing with this currently and stuck with inputs.. Could you give a hint/example how input should work?

Awesome work @iamdustan ! I have played with your example, but failed with making inputs work having this . Tried on iterm2 and terminal. Is there a way to set focus won input without mouse involved, this is 90% use case for cli apps?

@lapanoid you should check blessed's documentation about focus and inputs.

@lapanoid yeah, I’ve never had a lot of fun with blessed forms. I’ve had success with iterm2, but not with default Terminal.app

If I remember correctly, Terminal.app indeed has a lot of quirks, notably the mouse does not work and some focus events also. But it should be possible to devise a kind of form using tabulations & keys I guess.

@iamdustan My concern about react in terminal, that it should not break basic terminal functionality which are REPL and input.. All this gorgeous things will not get much traction if they are not play well with input.

@Yomguithereal sorry this is not right place for this discussion, I will create separate issue

I had no luck using a list element -- errors out with TypeError: Cannot read property 'length' of undefined. Seems to work fine in previous version.

@mashaal could you post a brief demo and I’ll debug?

@iamdustan https://gist.github.com/mashaal/2212d99f35dcadac2dfa096f7ae8623e
first example does render the list, second does not -- tried wrapping it in element, box, etc

Would love to see this PR progressing. What is its current state ?

Basically waiting on facebook/react#9103.

Still waiting on Facebook :)

According to dan's answer, the missing piece should be released along React 16.1 in a week or two:
https://github.com/facebook/react/pull/10758#issuecomment-339154055

@iamdustan don't hesitate to comment on the thread when you feel we can start to work towards a merge.

This PR makes me happy in a way no PR should.

Will do @Yomguithereal. :smile:
Working through a few more issues (eg. facebook/react#11463) and then having you do an actual integration test somewhere would be really helpful.

an actual integration test

Do you have an idea on how to do that with such a library?

Maybe I meant a manual test 😇
I’ve added a few new examples, but I’m not sure if I broke the dashboard one or if it never really worked for me.

@Yomguithereal I think this is ready for a test drive.

Thanks ! I'll try to migrate https://github.com/byteclubfr/socket.io-monitor-cli over this new version to see how it goes.

@iamdustan where are we on this? Doesn't some deps remain where they should not?

I think that this is ready. I removed one of the dependencies completely, but I think the other may be necessary still for react-devtools to work.

Is this PR ready to be used by others? Are there any remaining tasks that I can help with to push this along?

@jonhermansen. This PR should be usable right now. I am just waiting an answer regarding dependencies to merge.

Derp. Missed the last question, @Yomguithereal. I just bumped a few versions and removed the dependency and added a guard during setup for it.

@iamdustan. I will merge & release now so that people can use your goodies. I'll try to find some time in the near future to work a bit on the library. Do you want me to add you as a contributor so you can freely edit the library?

@iamdustan:

figure out how to publish/version (current requirement involves npm installing an official renderer to get access to react-{renderer}/lib/ReactFiberReconciler.js

Is this still the case?

Negative, the official renderer means that is no longer valid.


Update harness-platform-faqs.md

Q4 Platform FAQ's
Description

Please describe your changes: Q4 FAQ

PRs must meet these requirements to be merged:

[x] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6761d6bd56d0912e9e59dbbd--harness-developer.netlify.app


access: may-start-trybots

Gerrit email<EMAIL_ADDRESS>Referencing https://go-review.googlesource.com/#/admin/groups/1030,members
Purpose: Primarily to test math.Fma and its dependent CLs in cmd/compile, but also to be able to run the trybot on a submitter's +1'ed CLs before they reach an approver. Thank You!

All done! Thanks for your contributions.


Create basic architecture for OUDS Swift Package (#46)

Note: Please transform - [ ] into - (NA) in the description when things are not applicable
Related issues

Closes #46
Description

Add Swift Package in repository
Rename demo app to showcase

Motivation & Context

Need to have basic architecture with SPM for project before moving SwiftFormat and SwiftLint from CocoaPods to SPM so as to complete CI/CD chain implementation
Need to have clear naming

Types of change

Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

[x] I have read the contributing guidelines

Accessibility

[x] My change follows accessibility good practices

Design

[x] My change respects the design guidelines of Orange Unified Design System

Development

[x] My change follows the developer guide
[ ]  I have added unit tests to cover my changes (optional)

Documentation

[x] My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

[x] The evolution have been tested and the project builds for iPhones and iPads
[x] Code review has been done by reviewers according to CODEOWNERS file
[x] Design review has been done
[x] Accessibiltiy review has been done
[x] Q/A team has tested the evolution
[x] Documentation has been updated if relevant
[x] Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
[x] CHANGELOG has been updated respecting keep a changelog rules and reference the issues

Sample proejct to test the integration of OUDS as a Swift package from SPM (Xcode)
TestIntegrationOUDS.zip


Exported Map Title uses Today's Date instead of chosen month

Exported maps should have the month that the data is for named in the map , not today's date. Today's date can be specified in metadata at bottom.

Resolved in ef356df6fef8585bc76b473f27fb61504f993a82


Fix for dashboard issues in Internet Explorer Windows.

Fix for issues
https://github.com/capitalone/Hygieia/issues/703
https://github.com/capitalone/Hygieia/issues/737
https://github.com/capitalone/Hygieia/issues/819

LGTM

LGTM


inserter dies out in  collect configuration

Thank for GOFlow software. I am studying how to implement in my small network.
I started with flow-pipeline in a docker environment to better understand all the parts.
docker-compose -f ./docker-compose-mock.yml up
worked fine ! The problem is when I try
docker-compose -f docker-compose-collect.yml up
Apparently inserter dies at the kafka.broker creation. Error is the following:
time="2019-08-09T14:52:02Z" level=fatal msg="kafka: client has run out of available brokers to talk to (Is your cluster reachable?)"
the container restart (as per policy) and dies again. the export to postgresql do not occur.
What is surpring is that the same inserter container with the mock generation is working fine.
Maybe my knowledge on Kafka is still to limited to understand what is going on.
Regards
Enrico
Docker engine
Server: Docker Engine - Community
 Engine:
  Version:          19.03.1
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.5

Docker-compose version
docker-compose version 1.24.1, build 4667896b
docker-py version: 3.7.3
CPython version: 3.6.8
OpenSSL version: OpenSSL 1.1.0j  20 Nov OS 2018

OS system
Fedora 30 workstation

Edit docker-compose-collect.yml.
Change line 41 from "-kafka.out.brokers' to "-kafka.brokers".
Change line 42 from "-kafka.out.topic" to "-kafka.topic"
Change line 72 and remove "/inserter " from the beginning of the line.
Save, restart and it will work.

Hello,
Thanks @scomoletti
Sorry this has been open for way too long.
I just pushed a general update. It should be fixed now.


Update scalajs-bundler to version 0.10.0

It now asserts the existence of the bundle file so the JS packaging code
had to be reworked a bit.

Tested locally, but somewhat experimental due to a lot of moving parts.

Just tested locally and it seems the site works well once generated. I noticed a couple config bugs in our travis setup, ;compile;test was causing us to only run sbt 😅 thankfully the scripted tests were at least running. We were also publishing SNAPSHOT for this PR

Thanks for the CI and formatting fixes.


curl statement issue and UTF-8 encoding issue

Couple of further items to consider updating in this article:
1.) From the psql command prompt, the curl command such as in [! curl -O https://examples.citusdata.com/users.csv] results in "permission denied" error .  Workaround is to download this file locally, then run the \copy command pointing to the local downloaded file path in the from statement as in: [\copy github_users from 'c:\mydata\users.csv' WITH CSV]
2.) If running a command prompt in Windows to run psql command, you need to set the CLIENT_ENCODING to 'utf8' before running the copy commands.  If you do not, the copy command for events.csv [\copy github_events from 'events.csv' WITH CSV] will result in an error [ERROR:  character with byte sequence 0x8f in encoding "WIN1252" has no equivalent in encoding "UTF8"]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9b65f64-c521-3799-b833-9ac27213e927
Version Independent ID: 0d6e2a8b-043b-7cdd-4e19-82c03c803c16
Content: Azure Database for PostgreSQL – Hyperscale (Citus) (preview) quickstart
Content Source: articles/postgresql/quickstart-create-hyperscale-portal.md
Service: postgresql
Sub-service: hyperscale-citus
GitHub Login: @jonels-msft
Microsoft Alias: jonels

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Cool, thanks Micah!  I should have mentioned that for #2 in my first comment, the command for the client encoding needed is:
SET CLIENT_ENCODING TO 'utf8';
This worked to solve the error I mentioned by running it before the /copy commands.

@jjfrost thanks, I'll test your suggestions and update the docs.
On my machine the default psql client_encoding is UTF8, so I overlooked the problem. Just out of curiosity, is WIN1252 the default value on your machine?

@jonels-msft Great, thanks so much.  Yes, correct, WIN1252 was the default upon install of psql and PostgreSQL client tools on my machine.  My OS is Windows 10 Enterprise (version 1809) and my PostgreSQL client tools version is 11.3 (64 Bit).

@jonels-msft Want to follow-up on this item to see if the client_encoding detail has been added to the document?

@Mike-Ubezzi-MSFT I remember from email that @craigkerstiens is the docs backup contact for Joe.
Looks like there are two issues reported on this same article - #31719  and #31546
Thanks, Jason

1.) From the psql command prompt, the curl command such as in [! curl -O https://examples.citusdata.com/users.csv] results in "permission denied" error .

Interesting, the following commands worked for me when I ran them in psql from the Windows 10 Command Prompt application:
\! curl -O https://examples.citusdata.com/users.csv
\! curl -O https://examples.citusdata.com/events.csv

Did you run the command exactly as shown, with the backslash?
Did you run it in psql locally on your computer?
Did you start psql in a working directory for which you have write access?

2.) If running a command prompt in Windows to run psql command, you need to set the CLIENT_ENCODING to 'utf8' before running the copy commands.

Yep, confirmed that this worked for me on windows as well. I'll add that to the quickstart before the \copy commands.


Include version 4 of the war module for the shiro-web

Without this change you can not be installed shiro-web  on Apache Karaf 4.0.

Thanks @amusarra !
Any ideas on how we can better test for these types of problems at build time?

I was just about to merge this, while looking for related issues I found:
https://issues.apache.org/jira/browse/SHIRO-426 - Shiro-web feature can't be installed in karaf 4.0.4
https://issues.apache.org/jira/browse/SHIRO-560 - Update Shiro Feature File With New War Feature File Name (or remove the war feature dependency)
Should we just remove it ?

Hi. You can proceed.
Thank you.
Antonio.

@amusarra thanks for the PR!
It's include in:
https://github.com/apache/shiro/pull/88
I close this one.


Command Line too long

The command line generated appears to exceed a threshold
Perhaps it would be better to generate a command file, to avoid command length limitations
The command line is too long.
Write-Err : Cannot bind argument to parameter 'msg' because it is an empty string.
At C:\Users\GeorgeRu\AppData\Local\Microsoft\VisualStudio\15.0_13f2e2ac\Extensions\43s1b10b.dwz\clang-build.ps1:567
char:15
+     Write-Err ($compileResult.Output)
+               ~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Write-Err], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyStringNotAllowed,Write-Err

Hi,
Can you provide some context for this error ?
What was the operation you performed ?
Did you use the VS extension or the PowerShell script directly (CI/automation) ?
Can you attach a sample project reproducing the issue ?

The context is the invocation of clang-tidy from the GUI toolbar in Visual Studio extension
I do not have a sample project, this issue occurs in a large proprietary project with a) many include paths b) many defines
The commandline invocation of
VERBOSE: INVOKE: "\clang-tidy.exe"
has ~90 lines and is 8657 bytes in length
It largely consists of -isystem"/some/path" arguments, caused by enabling "treat additional includes as system includes"
This appears to be the problem
https://stackoverflow.com/questions/29354602/powershell-error-the-command-line-is-too-long
https://stackoverflow.com/questions/3205027/maximum-length-of-command-line-string

Hello there
I also have this problem, it is unfortunately preventing me from using the VS plugin.
I have a relatively big VS solution, with ~600 projects, and many projects are dependent on others. I used to compile single files with the tool, for the syntax only.
Can you please come up with a solution? Like the other commenter said, move the parameters into a file?
thanks

Sadly, we don't currently have a working solution for this.
As @grrussel pointed out, cmd.exe invocation rules dictate a 8192 character limit for the command-line. This applies to powershell.exe invocations as well.
A command file would likely not help us since it is bound to the same 8192 character limitation.
That cmd file would still need to invoke clang++.exe which would mean the same thing.
As a workaround, we could explore invoking the CreateProcess() Wi32 API function manually from our Powershell code. MSDN documents a 32768 commandline character limit for that.
That would put us at a comfortable 4x above the current limit. Still not a general solution to the problem.
We welcome other ideas on how to overcome this basic limitation.

Guys many thanks for looking into it, I would like to stress that it used to work! On the same PC, with the same project, I have been using the plugin for months. I am not sure if the problem came after an update to the tool or not ... but my project/solution is basically the same (quite complicated).

We changed the behavior of how we pass include directories to clang.
The previous behavior was not correct.
See detailed explanation here:
https://caphyon.github.io/clang-power-tools/QaA.html
Section: How to deal with warnings from system/third-party headers ?

Dear cpp-red-lion, what does it mean please? Do you reckon it will fix the issue, and I shall wait for the next release? Or is it related to another issue? Or do you mean the mentioned -treat-sai would be a workaround for this issue? Please clarify if possible.

Both behaviors we support now (via config panel) for Additional Includes use either -I or -isystemcommands for clang.
We abandoned the usage of %INCLUDE% environment variable at version 2.6
The only workaround I see for addressing your limitation (aside from what @hero101111 suggested) is to (optionally) bring back the %INCLUDE% environment variable usage. But I reckon it would be messy...
We'll think about it and weigh in our options.

Hello there,
I have found a simple workaround, which works with LLVM 6.
The solution, like mentioned a few days ago, is to use the --config parameter of clang, instead of trying to pass a monster command line. In my case, the command line is 19k chars long. I cannot do much about it, the project is complicated.
What I did locally to make it work:

find and make a backup of clang-build.ps1
locate where clang is started for compilation: Function Run-ClangJobs
Before the Start-Job and Invoke-Command call, add:

      $tmp = [System.IO.Path]::GetTempFileName()
      $job.ArgumentList -replace '\\', '/' | Out-File $tmp
      $job.ArgumentList = "--config $tmp"
      Write-Verbose "Params saved to $tmp"

The clang output is not visible!! However it is not shown as a nice message table in VS. --> maybe someone fixes this

I haven't deleted the tmp file afterwards, but you can do it if you like
Have fun guys

This doesn't work for me. Isn't the --config parameter to pass a .clang-tidy YAML configuration and not the command line args?

Honeybunch: for me it works with LLVM 6. According to the docs, the --config option is supported by LLVM 6 and LLVM 7.

I'm also using LLVM 6 but with your solution I get the error YAML:1:1: error: not a mapping since it's looking at that file as the .clang-format (or _clang-format) YAML config file.

For me it works perfectly, I only did a plan vanilla clang compilation, no tidy, no nothing.
If you have a backup of the ps1, you can undo the change. Good luck.

Hello guys,
I had some time and looked into why Tidy does not work. The mentioned "YAML" error indeed means, Tidy does not treat the "--config" option the same way as Clang does.
To put it short: for a Clang run, we can put the whole command line into a file and call Clang with "--config filename"
For a Tidy run, we have a command line like this:
clang-tidy.exe  --
So the command line includes the Tidy params as well as the params passed on from Tidy to Clang, separated by "--".
You guessed the solution yet?
Split the Tidy command line at the "--" separator and pass the left side to Tidy, and pass the right side as in a file to Clang.
I have tested this and it works for me with LLVM6, VS2017 with Clang and Tidy runs.
To patch your installation, please:

find and backup the clang-build.ps1 file
find the Run-ClangJobs function
find the code block which starts with:
 if ($aUseParallelCompile)
Copy-paste this code BEFORE the above block:

    $tmp = [System.IO.Path]::GetTempFileName()
    Write-Verbose "Params saved to $tmp"

    if($job.FilePath -like '*tidy*')
    {
      #Tidy: split parameters: tidy params and clang params
      $splitparams = $job.ArgumentList -split "--"
      $splitparams[1] -replace '\\', '/' | Out-File $tmp
      #pass clang params as file
      $job.ArgumentList = ($splitparams[0] + " -- --config $tmp")
    }
    else
    {
      #Clang: save options to config file
      $job.ArgumentList -replace '\\', '/' | Out-File $tmp
      $job.ArgumentList = "--config $tmp"
    }

Now you should be able to run Clang compile and Tidy using the PowerTools Plugin.

I am not a PowerShell programmer so maybe it is not elegant, not optimal, but it works. It checks if we are doing a Clang or a Tidy run. For a Clang run, the command line is simply saved. For a Tidy run, the string will be split and the left side goes to Tidy, the rest to Clang.
I hope the developers will look into this and give us a fix soon. Have fun guys.

Great find! This works brilliantly! Thanks for digging in to this. This is going to save me an unimaginable amount of time.

Excellent solution, @dzolee.
At first, we were skeptical of this approach, since it means creating and deleting thousands of temporary files, one per cpp. We don't want to slow down Clang Power Tools and we also want to avoid having two (or more) ways of doing things. So we decided to test for it...
We ran a multitude of compilation tests on our test repository, consisting of around 140 projects and 8000 CPP files. To our surprise, we found that the temporary-file creation and deletion additional cost is practically zero.
In the majority of tests the compilation was slightly faster (around 1%) than the baseline of the control group. There appears to be a tiny time cost associated with a long command line, perhaps from CMD.EXE command line parsing. The tests were ran on the same machine, in identical conditions, on both SSDs and HDDs, yielding similar results.
We are very pleased with the results and are happy to inform you that starting with Clang Power Tools v3.8 (i.e. next release) we'll move to using config files for giving arguments to clang.
Thank you all for your very insightful and helpful feedback.

Just ran into this and came here to see that it's already fixed, this is great!
Do you have an ETA for the 3.8 release?

Hi,
Clang Power Tools v3.8 was just released. You can update the extension from Visual Studio or you can download it from here.
Best regards,
Ionut

I see this issue on 5.3 :(


NNBD: Default type bound of the generic type parameter is incorrect in runtime: it's dynamic instead of Object?

Dart VM version: 2.8.0-edge.40f23c735f04433e4fc334fbd674474bd3de0f8b (Tue Jan 28 01:14:48 2020 +0000) on "linux_x64"
NNBD Spec reads:

The default bound of generic type parameters is treated as Object?.
However, currently this is not so.
Please run the following code:

class A<T> {}
main() {
  print(A);
}

It prints A<dynamic> whereas it should be A<Object?>:

iarkh@med:~/dart/dart-sdk/sdk/tests/co191/src/LanguageFeatures/nnbd$  dart --enable-experiment=non-nullable test.dart
A

Closing as working as intended.


meson: Make private static library symbols local

Static libraries are not affected by our symbol file, so private symbols
are globally visible by default.
Use objcopy to make symbols that we do not want to expose local.
Closes: https://github.com/swaywm/wlroots/issues/1892
Closes: https://github.com/swaywm/wlroots/issues/2952

Meson lacks support for prelinking on clang. See https://github.com/mesonbuild/meson/pull/8883.

LGTM with static libs disabled on Clang on BSD and Arch (waiting for the Meson patch to get in)

Do you want to conditionally disable the feature so that existing static linking workarounds remain possible?

Do you want to conditionally disable the feature so that existing static linking workarounds remain possible?

As you prefer. I don't really like hardcoding specific compilers and Meson versions, but making all Clang builds fail when static libs are enabled isn't nice, especially if we're going to recommend static libs.
If we don't set prelink: true, we could always set link_args: '-Wl,--relocatable' I suppose, and that should work on all linkers of interest?

If we don't set prelink: true, we could always set link_args: '-Wl,--relocatable' I suppose, and that should work on all linkers of interest?

What would the idea be here?
Prelinking adds an additional linker step which links all objects into a single object, which runs before packing the final .a (which is not linking, but just making anar archive of all final .o's).
I'll make the new feature gcc-only for now, while I look at fixing meson.

Prelinking adds an additional linker step which links all objects into a single object, which runs before packing the final .a (which is not linking, but just making anar archive of all final .o's).

Hrm, indeed. The linker doesn't get invoked when building a static lib. It doesn't seem like objcopy has a mode where it can do what ld --relocatable does.
Let's just get the CI green for now then, just need to disable --default-libraries=both on Clang builds.

Static linking is now only enabled for GCC in CI.

Maybe we should add static linking to one of the Sway CI jobs?


Assign 2D frequencies to (existing) 1D frequencies or set them manually

If a 1D (e.g. 1H) is already picked, or if a 13C frequency is pre-defined (e.g. from a picked HSQC) when picking an HMBC, there should be a possibility to define, that one of the signals has to share the same shift as the already existing one (or vice versa). Or, at least, as for the 1D it is possible to manually define a frequency, one should be able to define/edit by hand the frequencies in both dimensions

Relatved to https://github.com/cheminfo/nmr-displayer/issues/758

Relatved to https://github.com/cheminfo/nmr-displayer/issues/758

One workaround would be to define in the correlation table that a certain 1H frequency is e.g. connected to peak #4 in the carbon list, even though the zones picking would assign the correlation to carbon peak #3. @hamed-musallam @lpatiny @jobo322


Bugfixes for Dockerfile

Fix "No such file or directory: 'git'" on docker build;
Fix "No module named mtt" on container start.

I also have this problem
  Downloading https://files.pythonhosted.org/packages/e7/a7/4cd50e57cc6f436f1cc3a7e8fa700ff9b8b4d471620629074913e3735fb2/cffi-1.11.5.tar.gz (438kB)
    Complete output from command python setup.py egg_info:

        No working compiler found, or bogus compiler options passed to
        the compiler from Python's standard "distutils" module.  See
        the error messages above.  Likely, the problem is not related
        to CFFI but generic to the setup.py of any Python package that
        tries to compile C code.  (Hints: on OS/X 10.8, for errors about
        -mno-fused-madd see http://stackoverflow.com/questions/22313407/
        Otherwise, see https://wiki.python.org/moin/CompLangPython or
        the IRC channel #python on irc.freenode.net.)

Yeah, looks very good. Does not need more image size or other negative things.
This PR makes affect for the .dockerignore-File, the file was not used in the previous version!


Proposition

Thank you for tips. Here is my Firefox configuration:
https://bitbucket.org/snippets/cedricbonhomme/cbj6
if it can help you.

Thanks.
I wouldn't aggree with the following though:
user_pref("javascript.enabled", false);

Most of the sites strongly rely on Javascript. It would be better to use something like NoScript.
user_pref("network.http.sendRefererHeader", 0);

This will also break many sites. I'd recommend Smart Referrer instead.

Thanks for Smart Referrer, I didn't knew it.
Indeed, I have some problems with the login on Bitbucket. But I rarely identify myself to sites.
I admit that disabling JavaScript is restrictive. I only activate JavaScript when it is really needed. For example GitHub is quite usable with the Tor browser and the highest security level. Not the case for Lotus Notes.

No need for Smart Referrer. There are other settings that make the referrer header not leak any important information, or only be sent in some cases. network.http.referer.spoofSource, network.http.referer.trimmingPolicy and network.http.referer.sendAcrossOrigins are examples.

Indeed, what @rastus-vernon said.

network.http.referer.XOriginPolicy:
0: always send
1: send if base domains match
2: send if hosts match
network.http.referer.spoofSource:
false: real referer
true: spoof referer (use target URI as referer)
network.http.referer.trimmingPolicy:
0: send full URI
1: scheme+host+port+path
2: scheme+host+port

I recommend setting XOriginPolicy to 1, spoofSource to false, trimmingPolicy to 1.
Otherwise quite a few sites will malfunction and you'll have no idea why.
The information you send to websites with these settings can be collected on the server side anyway.
Even with these settings, it's somtimes (very rare though) required to temporarily set XOriginPolicy to 0 for some sites.

@jomo Won't websites always work with spoofSource set to true? If they do, then nothing else is required since that makes the page itself be sent as the referer, and the website already knows what page you're visiting. In any case, it seems to me it should work since you can generally visit a website directly with the URL.

Some websites only work when they see the user is coming from a specific page (or subdomain). I don't have any examples right now, but it has definitely happened to me.
spoofSource would also send a (fake) Referrer even if it wouldn't send it by default.
spoofing or not, it's not like you're 'leaking' any secret information, it's not much of a privacy concern.


Revise statement on persisting IDs from remote systems

From https://github.com/ga4gh/vr-spec/pull/78#issue-285434615, @cyenyxe asks:

Receiving systems SHOULD NOT persist Ids from remote sources. Instead, Identifiers (below) SHOULD be used for communication between systems. -> MUST (NOT) instead of SHOULD (NOT)?

In my opinion this is a good change, but we will want to discuss as group prior to making change. Please comment with your own thoughts here, or react with 👍 / 👎 for making this change.

If our VR-schema is meant to support a messaging standard, similar to FHIR's specifications, then we may want to take a similar approach in the practice and guidance for the use of ids vs identifiers. I do think many folks will be using FHIR (at some point) at it seems to make sense to me. Plus, they have put considerable thought and energy and have years more experience with very broad groups of implementers on this topic specifically.
The "id" attribute on concepts shared in a message document are only required to be unique within the message. The only requirement is that the message receiver can use these values to correctly reconstruct the associations and structured message being received. It has no requirement that these ids are persistent or global, they can be transient.
The "identifier" is aligned much closer to the concept of a business identifier. One that is likely immutable and persistent. One that can be used as a reference by external groups. One that is authored by a single authorizing agency and such.
Identifier values CAN be used for the value of an "id" on a concept in a message as it would be a very logical thing to do in satisfying the need to be able to uniquely reference the concepts in the message that are being digested.
If we combine these concepts or create constraints that make it impossible to separate these concepts then we will essentially be requiring everyone to use our digest as the ids for the purpose of sharing any of the VR concepts in any messages that they participate in.
We should really be clear on whether we want to provide ANY guidance related to whether or not implementers SHOULD, SHOULD NOT, MUST or MUST NOT persist anything. Persistence implementation is outside of our guidance scope (IMO).
In the end, it may be best to remove this line completely from the spec as it appears to be out of scope and can only lead to lots of discussion and little value to any implementers.
(If some implementer wants to persist ids then what concern is that of ours. We could offer the computed digest identifier as a potential candidate for persisting and recalling concepts, but again this is likely outside the scope of our VR-Schema specification.)

We may want to add implementation guidance to computational identifiers section on the use of computational identifiers for the id field. tagging @reece


Make slimit and soffset available in align by device with template

Description
Before fix, slimit and soffset is invalid in align by device with template.
Now I add ColumnPaginationController usage in TemplatedAnalyze.java.  More details are shown in integration-tests.

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (09b7e86) 49.10% compared to head (57be2f0) 49.10%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

.../db/queryengine/plan/analyze/TemplatedAnalyze.java
0.00%
19 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #11696   +/-   ##
=========================================
  Coverage     49.10%   49.10%
- Complexity    24982    24990    +8
=========================================
  Files          2817     2817
  Lines        176773   176805   +32
  Branches      21186    21200   +14
=========================================
+ Hits          86804    86827   +23
- Misses        89969    89978    +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New dask-jobqueue 0.3.0, docrep 0.2.3. Updated distributed 1.15.1 -> 1.22.1

motivation
Adding python package dask-jobqueue. dask-jobqueue has required
dependencies of new package docrep and updated version of
distributed.
The newest release of distributed has a change in
dependencies. msgpack-python (depreciated) -> msgpack and pyyaml
is a new dependency.
Things done
Added python package dask-distributed 0.3.0 and docrep 0.2.3.
Update python package distributed 1.15.1 -> 1.22.1

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Instead of removing meta.maintainers, why not add yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix? This should be done in an additional commit before the existing ones.
Also, please create a separate commit for each package and format the commit messages according to the guidelines, e.g. pythonPackages.docrep: init at 0.2.3.

Closing and separating into separate pull requests.

@costrouc don't, just create separate commits in a single PR.

@FRidh I have already done this sorry. Definitely will just do separate commits in the future because that is much much easier.
See these:

#44665
#44657
#44654
#44653


ADD : Local driver API's Implementation

This PR includes the implementation of API's for Local Storage Driver in NestJS. Here is the list of all API's completed.

Get Meta Data of File.
PUT API to write the file in system.
GET API to get the contents of the file
Exists, Missing API to check the file present in the system or not.
Delete API to delete file from System.
URL API to get the base url of file.

Thank you @babygame0ver for the PR. Merging it.


Double brace on format

Notes:

I feel this issue is somewhat similar to https://github.com/saviorisdead/RustyCode/issues/91
Using rustfmt main.rs on command prompt works without a problem
OS: Windows 10
VS Code: 1.1.0
RustyCode: 0.14.3

Same here with RustyCode 0.14.4

Things get even worse if you try to format:
fn main() {
    println!("Hello, world!");}

it will become
fn main() {
    println!("Hello, world!");
}    println!("Hello, world!");}

if you update cscode to 1.1.1 this should be ficed. :)
original bug: https://github.com/Microsoft/vscode/issues/6281

Yeah, it's okay now. Thanks for your quick reply.

It works now! :D


Don't accidentally load non-blocking servlet API. #229

The check in Http4sServlet comes too late: NonBlockingServletIo is the
default, and it already tries to load classes that aren't there.  It's
fine in the xsbt-web-plugin with Jetty 9, but Tomcat 7 exposes the
problem.
Make the ServletContextOps default to the proper servlet I/O version.
Constructing a servlet by hand will now default to blocking I/O.  When
we can break binary compatibility, we will reinstate the option to
select based on the server.

My intent is to release this as v0.6.3 so @toby5box can have it to start the week.

This looks good to me.


Add log level filter and on error dump HELP_STRING text

This PR addresses issue #426. Specifically, part 1 of this comment.
The 3 parts in the comment were:

validate log levels (HELP text on error)
validate log names (HELP text on error)
dump list of available loggers

This code relies on the tracing library to support part 1. Unfortunately, I wasn't able to figure out how to leverage the tracing library (not sure if that is possible) to filter log level names and dump list of available loggers while still leveraging the level filtering that tracing offers.
I'm open to suggestions on how to do part 2 and 3 if that is feasible for this PR.

@MorrisLaw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
a543bd6d90c44b1f2b68ba520863d4c5ab22abfb
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

could you add a test for the logging API similar to what is present for /config_dump

will do


we can probably do away with installNavigationLinks

Since our converting traversal is top-down anyway, we can propagate custom information from parents to children anyway. I've been doing this for a while already, and this technique seems to work. See one of the many examples here: https://github.com/scalameta/scalameta/blob/b3febd76693e69695e6588635b86d6701acbb3e3/scalahost/src/main/scala/scala/meta/internal/hosts/scalac/reflect/LogicalTrees.scala#L240.

One useful thing about installNavigationLinks is that it enables easy crash reporting without having to maintain the stack of parents.


Only /bin/sh is needed for img2fwup

Yocto found this.  We are using /bin/bash currently when only /bin/sh is really needed.

Thanks!

Coverage remained the same at 85.962% when pulling df83dd002016f8be48f3882e6e01426d62b67192 on se-apc:dep_fix into d64d3d29ff414dea12cd3d75abbce6bf4636fe42 on fhunleth:master.


Implement validate_self_client in connection handshake

We're missing the implementation of validate_self_client:
https://github.com/cosmos/ibc-go/blob/dcd616c24afdca181f7d95d66cdf2a109b2cca09/modules/core/02-client/keeper/keeper.go#L271
in conn_open_try:
https://github.com/cosmos/ibc-go/blob/dcd616c24afdca181f7d95d66cdf2a109b2cca09/modules/core/03-connection/keeper/handshake.go#L86
and conn_open_ack:
https://github.com/cosmos/ibc-go/blob/dcd616c24afdca181f7d95d66cdf2a109b2cca09/modules/core/03-connection/keeper/handshake.go#L198

closed in #57


Useful links to create a site documentation with maven site plugin and Github

https://docs.github.com/en/actions/learn-github-actions/understanding-github-actions#contacting-support
https://www.google.com/search?q=github+action+badge&oq=github+action+badge&aqs=chrome..69i57j0i22i30l7.13155j1j7&client=ms-android-transsion-tecno-rev1&sourceid=chrome-mobile&ie=UTF-8
https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge

https://dzone.com/articles/applying-cicd-to-java-apps-using-spring-boot

https://docs.github.com/en/actions/security-guides/encrypted-secrets


Can this be used in reverse?

Can this be used to convert HTML or AST --> BBCode?

Good question. Technicaly you can parse HTML, we have some tests, but not all HTML behavior (like partialy closed tags and etc). So you can try to convert HTML to AST and than use custom settings to render BBCode.
I created
some sandbox to test


mac CreateMainView never returns

Using v<IP_ADDRESS>
I am seeing the behavior outlined in the below code when extending chromelywindow.
In both cases Chromely correctly opens and displays the browser. Is this expected or a bug?
public class TestChromelyWindow : ChromelyWindow
    {

        public TestChromelyWindow(IChromelyNativeHost nativeHost, IChromelyContainer container, IChromelyConfiguration config, IChromelyRequestTaskRunner requestTaskRunner, IChromelyCommandTaskRunner commandTaskRunner) : base(nativeHost, container, config, requestTaskRunner, commandTaskRunner)
        {

        }

        protected override IWindow CreateMainView()
        {
            //called on win and mac

            var result = base.CreateMainView();

            //never returns on mac

            return result;
        }

        protected override void Run()
        {
            //never called on mac
            base.Run();
        }
    }

@captainjono
Yes it is expected - those methods are never call for Mac. This is part of the challenge with having a single code source for cross-platform, the platforms do not play same way.
Those 2 methods are handled in libchromely.dylib that you are familiar with. If you want to subscribe to some events, I will suggest any of these delegates passed to it - https://github.com/chromelyapps/Chromely/blob/867e69fd32d4efc2395baffd5eeeda7418cdf469/src/Chromely/Native/MacCocoa/MacCocoaHost.cs#L48

Ok great - I just wanted to ensure i wasnt doing anything wrong.
Thanks for tips!


Merge config files into pyproject.toml

Does some of #4.
I didn't merge tox.ini because it looks more complicated and I wasn't sure whether you'd actually want to do that or would prefer to keep it separate?
I checked that all was ok by generating a new project from the template and running validate-pyproject. (I'll make a separate issue about this in a second.)

The CI failures are because these tests still expect the cookiecutter template, see gh-3


Update development dependency

A clean git clone and bundle install failed some tests (on master), it turns out to be some dev dependency unsupported break it.
They are,

opal-rails  since 0.9.0 (which opal 0.8.0 support is dropped)
react-rails since 1.4.0 (which the latest version is 1.8.2)

I will temporarily lock the dev-deps on master and loosen them after they are supported.

[Update] Got our rails test passed with opal 0.9 & opal-rails 0.9.0. Further attempt will be making opal test passed with 0.9 setup.

suppressed by #164


Feature/sort styles

Codecov Report

Merging #164 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #164   +/-   ##
========================================
  Coverage    99.06%   99.06%
========================================
  Files           73       73
  Lines         3417     3417
========================================
  Hits          3385     3385
  Misses          32       32

Impacted Files
Coverage Δ

ppa/archive/tests/test_views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9800046...8d3c79e. Read the comment docs.


need export fbx with animations

It was planned for animation support to be added to wow.export via GLTF, but has not found the necessary development time yet. We will not be adding FBX support to wow.export as it's a dated, proprietary format.
For acquiring animations, your best option currently is to use the wow.tools modelviewer which allows you to download animations as GLTF files. If you need character animations, I have a repository of 14,000+ FBX files for player animations available on my Patreon.


fix: header colour regression from mui theme update

Fix for the homepage header colour. This was caused by the MUI theme update PR. I also added a small change to typography so by default it will use the text colour from the bc gov design system.

There's an issue with the styling of the header title:

There's an issue with the styling of the header title:

Great catch, thank you 🙇♂
This is fixed though really looking forward to getting Happo running in another sprint or two so we can avoid these kind of regressions. Appreciate it!!


if we change animation duration of a video item, then timer completed previously as compare to video.

This works this way because the css animation duration is used as the timer for the next story


[Feature] Give LLM ability to interact with page

It would be neat to give the LLM the ability to interact with the current web page.  User should be able to describe some page interaction and the LLM executes it.  This is likely some combination of providing the page markup as context and a JavaScript eval tool for executing behaviors, with the ability for the user to see the script and allow it before execution

Hey, thank you for the suggestions! It can be done using function calls, I guess. I will look into it :)

It seems that this extension has it https://github.com/gyopak/sidellama
Maybe some can move this feature to this extension

Code for getting webpage in sidellama.

function bridge() {
  const response = JSON.stringify({
    title: document.title,
    text: document.body.innerText.replace(/\s\s+/g, ' '),
    html: document.body.innerHTML.replace(/\s\s+/g, ' ')
  });
  return response;
}

async function injectBridge() {
  const queryOptions = { active: true, lastFocusedWindow: true };

  // `tab` will either be a `tabs.Tab` instance or `undefined`.
  const [tab] = await chrome.tabs.query(queryOptions);
  if (!tab?.id) return;
  chrome.scripting
    .executeScript({
      target: { tabId: tab.id },
      func: bridge
    })
    .then(result => {
      const res = JSON.parse(result?.[0]?.result || '{}');
      localStorage.setItem('pagestring', JSON.stringify(res?.text || ''));
      localStorage.setItem('pagehtml', JSON.stringify(res?.html || ''));
    });
}

This feature still doesn't seem to be working.


Add setting to turn off mention notifications

Add a new settings section for notifications with a setting to globally turn off/on notifications for subscriptions to threads, including mentions.

Hello, I would like to contribute. I'm willing to take this task. How I do it right way ? After reading the contribution guide felt like I have to talk before doing anything.

I assume should look like this. Also it means notifications boolean field will be added to users table. The field will server as toggle.

So I think we should maybe look into a notifications JSON column that can hold settings for different notification types later on as well. I think we should display it as a list of type of notifications (currently only one) with a checkbox to toggle them on or off (by default on). The notifications settings would only contain a setting of a type of notification is turned off.

Maybe it is an idea to directly split the current situation in 2 notification settings?
One for the new reply notification and another for the mentions? (Now a new reply that mentions you result in 2 notifications so I think it can be useful to manage them separately)

That’s actually a bug and shouldn’t happen. Can you maybe open an issue for that @tvbeek?

That’s actually a bug and shouldn’t happen. Can you maybe open an issue for that @tvbeek?

Yes, done in #937

I guess better to have #937 done first ?

They're separate things really.

What I got from conversation above is:

We will have notifications json field on users table
The field will store a list of json objects like for example [{"reply":"off"},{"mentions":"off"}]
On the settings page will be shown list of notification types with checkboxes to toggle them on/off

am I right ?

More like:
[{"replies":false},{"mentions":false}]

okay, got it, will do

Hey, here I have dome something, please let me know am I going right. This is not finished yet but I think it is mostly done like 90%. [pull request](url)

Here are the steps:

Go to your GitHub account and log in.
Navigate to the repository for which you want to add the setting to turn off mention notifications.
Click on the "Settings" tab on the right-hand side of the screen.
Scroll down to the "Options" section and click on "Notifications".
Under the "Notifications" section, you will see the option "Automatically watch repositories," click on it.
Here you can select the option "Only direct mentions" which will notify you only when someone directly mentions you or
unselect it to turn off all notifications.
After selecting the option, click on the "Save changes" button at the bottom of the page to save your changes.

That's it! You have successfully added a setting to turn off mention notifications on GitHub.
https://dolgeneraldgme.com


group with single option issue

Hi, I have encountered some issue with jAutochecklist('getText') method.
test case
I provided a test in jsFiddle
which use latest jAutochecklist.js
problem
problem is _getText method would break when not multiple select, at this context, group name would be pushed to val[] but not the single item in this group.
So , getText would return the group name, is it a bug ?? If I wanna getText of the single item selected in a group, what method should I use. Thanks !
My problem only happens when group contains single one item, cause at this context, item selected would cause group selected.
possible fix
If it is a bug, I suppose fix can be as follows:
_getText: function(obj){
            var data = obj.data(pluginName);
            if (!data || !data.elements.listItem.li)
                return [];
            var val = [];
            data.elements.listItem.li.filter('li.selected').each(function(){
                val.push($(this).text());
                // break the loop if is single select.  Alex: actually there is no need
                // if (!data.settings.multiple)
                //    return false;
            });
	    // return the last chosen item when not multiple.
            if (!data.settings.multiple)
                return val[val.length-1] === undefined ? '' : val[val.length-1];

            return val;
        },

I think a simple solution was found..
Just limit the css in li.filter can solve my problem.
data.elements.listItem.li.filter('li.selected.child').each(function(){//....}

em... Actually, I found previous CSS selector solution would not find item out of group correctly. So I think maybe the first fix is better.


Grounding Util expects all three ontologies

We should fix that, make them optional.

when running apps.MakeMITRETablesFromDirectory


Doesn't support Inc.com videos yet. I'd like to help if i can

I find myself wishing i could access the videos on Inc.com more often without having to use their slightly clunky interface when switching between videos, but the website isn't supported. I know python but i'm still new to working on programming projects. I've tried looking at the source code but i'm not sure where to start on understanding how the code in this project works. Any help would be appreciated.
If anyone else has the experience to know how to go about doing this or already is doing this, please let me know as i'd like to get a better understanding of this project.

Developer instructions may provide what you need.

Post an example URL.

Closing due to no response for a long time.