Infinite recursion blocking upgrade on boot.swraid.mdadmConf setting to config value.

Describe the bug
Infinite recursion error when attempting nixos-rebuild switch --upgrade.  Can't tell if it's an issue with warnDeprecation function related to boot.swraid.mdadmConf, or something in how environment.etc."mdadm.conf".source is set.
[root@hetzner:/etc/nixos]# nix-channel --list
home-manager https://github.com/nix-community/home-manager/archive/master.tar.gz
nixos https://nixos.org/channels/nixos-unstable

Steps To Reproduce
Steps to reproduce the behavior:

configuration.nix + hardware-configuration.nix in this Gist, along with the --show-trace output from nixos-rebuild switch --upgrade

Expected behavior
A normal rebuild to update the latest packages.  I had seen a warning before to migrate TO boot.swraid.mdadmConf (instead of the other settings before), but now the deprecation warning for something appears to cause infinite recursion.  That's blocking my upgrades completely, and I would normally just remove the setting, but this is a Hetzner box and I don't feel comfortable that the swraid configuration isn't critical to booting (I suspect it is).
Screenshots
Details in the gist.
Additional context
The contents of ./mdadm/mdadm.conf file, if interested, is exactly the same as the commented environment.etc."mdadm".text value (with the email changed for privacy).  I'm relatively new to NixOS, so if there's something dumb I'm doing that I can correct on my end, that would be lovely.
Notify maintainers
@SuperSandro2000 (just guessing, please redirect liberally :) )

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[root@hetzner:/etc/nixos]# nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.3.6, NixOS, 23.11 (Tapir), 23.11pre523790.db9208ab987c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Yeah this is just wrong, you can't put the contents of /etc/mdadm.conf into /etc/mdadm.conf. Infrec is a given.

Thanks for the direction, @eclairevoyant .  The odd thing: this exact config was working just fine until a recent nix-channel --update.  I went ahead and removed the 2 environment references, and just directly set the boot.swraid.mdadmConf variable instead, and now it's working.  So thanks for the pointer. :)

This script must not have been touched in years, boot.initrd.mdadmConf isn't even an option in 23.05 until now
They should update it or remove it...


Fix quick node RPC 404 not found issue

Looks like this part of the code which removes the trailing / is breaking quick node RPC as looks like quick node relies on the trailing / for their RPC to work. This PR reverts it back.

Great catch, thank you!

Still happening... @goriunov
Error: RPC request error: cluster version query failed: HTTP status client error (404 Not Found) for url (http://quiet-aged-frog.solana-mainnet.quiknode.pro/6a56c1f12de472ff85a245955e5ff33d99704b2c)

@kobyle69 just did a test run and it works correct with the 5.0.1 version, also note that your endpoint for the quick node should have "/" at the end, make sure to copy the endpoint correctly. And another note you probably want to delete the whole URL your posted and rotate your keys...

Hi @goriunov, thanks for the reply.
Yea the key of quick node was a made-up one.
I did use latest version of metaboss, but now getting cert issues:
error trying to connect: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed:s3_clnt.c:1269: (certificate has expired)

Moreover, getting this without an RPC
[2022-03-09T12:03:01Z WARN  metaboss] Using a public RPC URL is not recommended for heavy tasks as you will be rate-limited and suffer a performance hit.
Please use a private RPC endpoint for best performance results.
Error: HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)
Caused by:
HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)
@goriunov @samuelvanderwaal

Moreover, getting this without an RPC
[2022-03-09T12:03:01Z WARN metaboss] Using a public RPC URL is not recommended for heavy tasks as you will be rate-limited and suffer a performance hit. Please use a private RPC endpoint for best performance results. Error: HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)
Caused by: HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)
@goriunov @samuelvanderwaal

Yeah, don't use public RPCs per the warning. If you don't pass in an RPC it defaults to using whatever is in your Solana config file. I don't want to block public RPCs entirely because they still work for some things but they actively block getProgramAccount calls to the token-metadata program.

Hi @goriunov, thanks for the reply.
Yea the key of quick node was a made-up one.
I did use latest version of metaboss, but now getting cert issues: error trying to connect: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed:s3_clnt.c:1269: (certificate has expired)

Use https. Your example above is http which is not supported by QuickNode AFAIK.

Tried https, for days now metaboss is unable to fetch snapshots no matter what we do.
Also this simple command 'metaboss snapshot holders --update-authority xxxxx' (with and without rpc)
Returns with 'Error: HTTP status client error (410 Gone) for url (https://api.mainnet-beta.solana.com/)'


go moudle: update import path of all packages inside a module when changing module name using go mod edit

i have a module github.com/user/hello.
this module has a package name apackage. so the import path is github.com/user/hello/apackage.
now i import the package from a file in the root dir of the module hello.go.
then i changed the module name to github.com/user/newhello by using go mod edit -module github.com/user/newmodule.
now my go.mod file is changed but the import in hello.go is not changed.
is there is a way to do it automaticly? if not.
Add the ability to do this.
go version:
go version go1.14.2 linux/amd64

Hi there,
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For asking questions, see:

Stack Overflow with questions tagged "go"

The Go Forum, a web-based forum

Gophers Slack, use the invite app for access. The #general channel is a good starting point.

Go Community on Hashnode with questions and posts tagged with "go"

The golang-nuts mailing list

IRC channel #go-nuts on Freenode

Please ask the question on one of the above forums.
(Quoted from https://golang.org/wiki/Questions)

@andybons this is a proposal. have you read the issue properly.

go should have this feature unless we need to manually update import path

Thanks for the suggestion but we aren't going to make this change.  go mod -edit should change your go.mod file; it should not change your Go source code.
It should work for you to go in the other direction: edit your source code, then run go mod tidy to update the go.mod file to match your source code.  The goimports tool is one example of a tool that can automatically modify your source code.

but go import identity the previous package name as a different package and can't help for this purpose

is Go a Google's fantasy?

I didn't mean to say that goimports would work for your particular case.  I meant to say that it is one example of a tool that can automatically modify your source code.  The point is that it is not hard to write tools to manipulate Go code programmatically, and that the information flow should go from the source code to the go.mod file, not the other way around.

OK, but having this capability in cmd/go will be much better.
this is a logical problem. you may want to change the module name and if cmd/go mod edit doesn't help you while to do it , then it is not a go design.
i don't understand why the people who designed of go mod edit didn't think about this.
just because you don't want to change the place were you host your src code.
what if a big go project move like from github to gitlab, Will they edit all there src file manually.
that is a terrible idea.

Again, thanks for the suggestion, but we will not be making this change for the reasons @ianlancetaylor described.
We appreciate the need for some people to do this, and encourage them to write a tool (or use an existing one) that makes the changes you describe. go mod -edit is not the place for this functionality.


Does NVImage.loadFromBase64 work?

Im trying to load a small .nii.gz image from a base64 encoding retrieved from python backend. Is there something we should know regarding successfully using loadFromBase64?
There's no error when loading the image but when I call addVolume(base64Img) I get 'cannot read properties of null'.
Or perhaps a more efficient way to load a .nii.gz image from a GET request to backend?
Thanks!

Hi @sabino-ramirez, Do you have a link to a minimal code example where this is failing? We're using loadFromBase64 in multiple locations within NiiVue and things are working. Happy to help if you can provide some example data and code.


Warning when installing gym!=0.13 with MyoSuite 2.3.0

The following warning is still present: myosuite 2.3.0 requires gym==0.13, but you'll have gym 0.26.2 which is incompatible.

It seems like the requirements files are outdated - https://github.com/MyoHub/myosuite/blob/main/requirements.txt

fixed here 2bddf8c7af65150cc958ed6aceaa113fa32aebdb


Issue 24:	MarkerWithLabel : problem of overlapping labels when two markers are in the same position

On your google repo
https://code.google.com/p/google-maps-utility-library-v3/issues/detail?can=2&start=0&num=100&q=&colspec=ID Type Status Priority Fixed Owner Summary Stars&groupby=&sort=&id=24
someone suggested a fix for the problem of overlapping labels

I found only one solution: (version 1.10)
instead of
line 141:
this.getPanes().overlayImage.appendChild(this.labelDiv_);
use this:
this.getPanes().markerLayer.appendChild(this.labelDiv_);

The overlayImage pane is pane which every elements overlay the any element of image and marker layer.

Because z-index work only in theier stack context, so any change of z-index can't solve this problem. Onle when you add the label and marker image to same pane, you can work with z-index.

Currently it's work for me.

Is there a reason this isn't implemented yet?

Oh, it's not my repo :) I've just cloned it as git repo to be able to use as submodule. And this repo is read-only 'cause it's synced with svn periodically.


I still cant use vertex ai same issue as #993

Issue
When i tried to use vertex ai with sonnet with the following command:
aider --model vertex_ai/claude-3-5-sonnet@20240620
I am getting this error
vertexai import failed please run `pip install -U google-cloud-aiplatform
"anthropic[vertex]"```

### Version and model info

_No response_

I have already ran that specific pip install command

Thanks for trying aider and filing this issue.
How did you originally install aider? What command did you use?
That may affect how to install the google cloud packages.

I used pip install aider-chat

This appears to be a problem with your local python environment. The best thing might be to start with a clean python virtual environment and try installing both again:
pip install aider-chat
pip install -U google-cloud-aiplatform "anthropic[vertex]"

For anyone utilizing using Google Vertex AI to access the Anthropic models, note that only two GCP regions are supported:  us-east5 and europe-west1.  I missed that detail and it took some time to figure out the issue.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Wrong behavior due to Pandas : dict with the same key based on tuple extracted from DataFrame

Can you explain the behavior of the following :

rows = pd.DataFrame([
	(0, np.nan, np.nan, 'toto'),
	(1, np.nan, np.nan, 'tata')
])

dico = {}

for row in rows.itertuples():
	k = (row[2], row[3])
	v = row[4]
	print('hash(k) : {0}'.format(hash(k)))
	v_prev = dico.setdefault(k, None)
	if v_prev is None:
		dico[k] = v

print('dico : {0}'.format(dico))

Result :
hash(k) :<PHONE_NUMBER>408328131
hash(k) :<PHONE_NUMBER>408328131
dico : {(nan, nan): 'toto', (nan, nan): 'tata'}

I manage to create a dict with the same key (np.nan, np.nan). I have got this behavior only with np.nan. With None or whatever else, I get the usual result with only one key.
You can find some hints in my SO question : http://stackoverflow.com/questions/34163497/wrong-behavior-dict-with-the-same-key-based-on-tuple
It seems to be linked to RichCompare. The comparison operator is is not used in this case

What's the pandas issue here? Your iterating over a DataFrame but I don't see anything wrong with that.

I'm going to say this is working as intended (although maybe not as expected! working with NaN is trick). It's the same behavior as the standard library
In [1]: d = {}

In [2]: d[(float('nan'),)] = 1

In [3]: d[(float('nan'),)] = 2

In [4]: d
Out[4]: {(nan,): 1, (nan,): 2}

what's happening is that you don't get a numpy.nan out from a DataFrame -- you get numpy.float64('nan'), which doesn't behave like numpy.nan.

Thank you @kawochen for your bright explanation. Do you know where I can get documentation about that ? and about RichCompare implementation in numpy especially

@Tux1 numpy/numpy/core/src/umath/umathmodule.c
I don't think it has much to do with how numpy implements rich comparison for anything, tho.  You only need to know that float64('nan') != float64('nan'), which as @TomAugspurger said works just like the standard library float('nan').  The reason np.nan seems to behave differently in dict is because it is the same object inside numpy that is being referred to, just like the global singletons (None, ..., etc.) in python.  If you do yourmodule.nan = float64('nan') and use yourmodule.nan whenever you need a nan, then you get the behavior of numpy's nan.

Yes of course, I understand better. Thank you
On mer., déc. 9, 2015 at 6:30 AM, pydata/pandas
<EMAIL_ADDRESS>wrote:
@Tux1 [https://github.com/Tux1] numpy/numpy/core/src/umath/umathmodule.c
I don't think it has much to do with how numpy implements rich comparison for anything, tho. You only need to know that float64('nan') != float64('nan') , which as @TomAugspurger [https://github.com/TomAugspurger] said works just like the standard library float('nan') . The reason np.nan seems to behave differently in dict is because it is the same object inside numpy that is being referred to, just like the global singletons ( None , ... , etc.) in python. If you do yourmodule.nan = float64('nan') and use yourmodule.nan whenever you need a nan , then you get the behavior of numpy 's nan .
—
Reply to this email directly or view it on GitHub
[https://github.com/pydata/pandas/issues/11797#issuecomment-163115468] .[https://github.com/notifications/beacon/AGWku8LcPCt7hGbsamL6igH_v_mh6a92ks5pN7QLgaJpZM4GxUVg.gif]


Allow engines to get parameters through method

Fixes #183

@MasterVexillen I have 'blackened' the source code and added a CI check to ensure that all changes must be black-conformant before they can be merged in. I don't have time to start adding comments everywhere now, but I promise I will be more liberal with them from now on 😄
@LAShemilt you will probably want to configure your editor to ensure that it blackens your code each time you save a file.


Support multiple vertex color sets

glTF supports an arbitrary number of COLOR accessors. We should expose them in a way while still translating COLOR_0 to displayColor, preferably without duplicate data.
See also: https://groups.google.com/g/usd-interest/c/VOkh0aj-8bU/m/zxrMQ-pJAgAJ

Implemented in v0.2.


add inline rendering option

Assume the following is the index.md
# Title
```d2
something ...
```

The problem was when pulldown_cmark_to_cmark::cmark function is making html back to markdown, It'll make the following and HTML can't be generated from this correctly
# Title<pre>...other content

I added \n before <pre> tag  and it's working again

Nice!
Can you also add an integration test for this? You should be able to assert for the presence of the SVG block

Nice!
Can you also add an integration test for this? You should be able to assert for the presence of the SVG block

I'll try it

Let me know if you get stuck

you should be able to just add a new test like so-
#[test]
fn inline() {
    let test_book = TestBook::new("inline").expect("couldn't create book");  # assuming you've created a new book in the 'library'

    assert!(test_book.chapter1_contains(r#"<svg>..."#));  # add a few lines here that prove it was rendered inline
}

(or something along those lines)

LGTM!
thank you very much for the contribution. You've solved a couple of long-running issues there, for which i'm eternally grateful


fix: typo in README.md

Check are still not running, but should be fixed by #17 and would not be affected by these changes anyways, so I am accepting the PR as is.


Developer: Reload Window spawns additional dotnet processes but does not clean up old one

On OSX, every time I reload the IDE, I get an additional language server.
But the old language server process is left around.

Thank you for reporting this bug. I have revised the whole extension and I believe this shouldn't be an issue anymore with the next release (v2.0.0):
https://github.com/dafny-lang/ide-vscode/blob/f6f3fc34fef4d0829fea908aa882adefdcf5438f/src/extension.ts#L24-L26
This deactivation procedure was missing before. Am I right when I assume that you're using the latest version released on the Marketplace (v1.8.0)? What I find interesting is that I couldn't reproduce it on Windows with this version. I May have to give it a try on OSX later to ensure that it's really fixed.

I have 6 dotnet processes running.
If I killall dotnet and then reload, I will have 2.
It may be that there is a limit? I'm not sure.

I've now tested it on my mac and I can confirm the issue. I've identified one possible issue with the following line:
https://github.com/dafny-lang/ide-vscode/blob/f6f3fc34fef4d0829fea908aa882adefdcf5438f/src/extension.ts#L59
The result of the start command should be added to the context subscriptions. However, it did not resolve that old instances are not cleaned up as they should.
What I find interesting is that it appears that VSCode does not wait for the client.stop() command to complete (at least the debugger gets detached before its completion).

Nice!
I found this because I suspect that verification is hanging.
I have had verification take longer than expected and so I reload and the restart verification and it completes quite quickly.
I don't have a lot of details on why the verification seems to hang.
Though I suspect that it has something to do with starting verification and then restarting verification with a syntax error.(?) not sure.

Usually, if the verification is hanging, you might see a z3 process running. If you kill this one (with the latest release, there might be more due to better utilization of the available cores), the verification should finish immediately.
Moreover, the language server aims to cancel active verifications if a change is received. Unfortunately, it appears that it's not always possible, as observed in https://github.com/dafny-lang/dafny/issues/1489.
But from my tests, it does not appear to relate to the verification. Although I didn't disable it, I could reproduce the error with simple code that verify in a few milliseconds. But I'll give it a try with disabled verification just to be on the safe side.

I have not seen this in awhile,
I think we can close it.


[FEATURE] Improve Ui for Post Card.

Description
Make the ui of card component look better.
#kwoc
Screenshots
No response
Additional information
No response

Assign this to me please.

Great go ahead!

do you also need a user profile page

do you also need a user profile page ?

It's a Wip

do you also need a user profile page ?

It's a Wip

Do you want me to work on the user Profile Page?

ping me in that issue, so I can assign if that issue's inactive


Negative test ideas for invite flow

Added negative scenario related to Invite flow

@prapullac Is this PR still valid? I'm only asking because it's fairly old now.
@NandanAnantharamu Can you please review this PR?


ARROW-10331: [Rust] [DataFusion] Re-organize DataFusion errors

This PR:

Renamed ExecutionError to DataFusionError
Renamed DataFusionError::ParserError to DataFusionError::SQL
Renamed DataFusionError::InternalError to DataFusionError::Internal
Renamed DataFusionError::ExecutionError to DataFusionError::Execution
Adds a new error variant DataFusionError::Plan that is used during planning
Removes DataFusionError::InvalidColumn that was not being used.
Removes DataFusionError::General, replacing them by the appropriate errors
Improves the message of DataFusionError::Internal to incentivize users to file a bug report when it happens
Extended the documentation of every variant

The design behind this PR is that the error variants should correspond to what happened:

Internal: a Datafusion's internal invariant was violated (e.g. downcast failed) => file a bug report
Plan: planning was incorrect
NotImplemented: something is not implemented and we know about it. Ideally, we should have an associated JIRA issue
Execution: an error during execution. We should avoid raising these, but sometimes it is impossible.
IoError: stuff related with reading and writing

I went through every error that we return in DataFusion and verified that it is assigned correctly to one of these variants.
I am a bit uncertain about the ParquetError and ArrowError. IMO ArrowError should be mapped to DataFusionError::Execution, as it only happens during execution, and ParquetError should be mapped to an IoError.
I also think that we should split NotImplemented in two: NotImplemented and NotSupported as e.g. float16 is something that we will likely never support, while "modulus" is just not implemented yet.

@kszucs, would it be possible to avoid force-pushing to PRs after a release (even if master is force-pushed)? IMO it is very confusing to the contributor (committer or not).

If a PR has a base commit that is one of the master commits that is part of the rebased master (i.e. some commit between the date the RC was cut and the date of the release), then the PR is completely borked after the rebase. We've seen this happen many times in the past. We could perhaps come up with some more intelligent script that only rebases PRs that are based on a commit hash that no longer exists in master

We are already force-pushing to master on every release, which goes against best practices of an open-source project.
AFAIK, in open source, there is a strong expectation that PRs are managed by individual contributors, and committers of the project only request contributors to make changes to them, or kindly ask before pushing (not force-pushing) directly to the PR. We are inverting all expectations and force-pushing to PRs(!!). Furthermore, those force-pushes actually break the PRs (as you can see above).  IMO this drives any reasonable contributor to be pissed off at the team for what they just did:

force-pushing to master
force-pushing to their PRs
breaking their PRs's CI
no prior notice or request of any of the above

I suggest that we:

stop force-pushing to PRs
stop pushing to PRs without the contributor's explicit consent
document in the contributing guidelines that master is force-pushed on every release, and the steps that folks need to take to bring their PRs to the latest master.

In general, it is the contributor's responsibility to keep the PRs in a "ready to merge" state, rebasing them to master as master changes. IMO a force-push to master corresponds to a change in master, and thus it is the contributor's responsibility to rebase their PRs against the new master.

I see your points.
Keeping the main branch flat is important and the commits after the release tag should have the right version numbers since git is not available in all scenarios, hence the rebase after a release.
We could certainly let the contributors to rebase their own branches, but in certain cases the contributors may be confused what to do after seeing many unrelated commits in their pull requests so additional maintainer roundtrips might be required to ask/advise for pull request rebases. From this perspective I rather find it useful although I'm also against force pushes in general.
I suggest you to bring it up on the mailing list so the topic can reach a broader set of developers and maintainers. I'm sure that we can come up with a better solution after there is a consensus.

I agree with raising the matter on the mailing list -- this is a project governance issue and so needs to be discussed there. We did not arise at the current practices idly and there are pros/cons to whatever approach is taken.


two output dirs?

It would be nice to allow user to specify two different output directories, one for the figures, and one for the (large) output files.

I've implemented this in the MATLAB end of things.  See https://github.com/kendrickkay/GLMsingle/commit/4798e285fc5cdc636e3b2907c7a92f13a7be3a02#diff-2552a9843c49f92bc3234007a066238277bb36eb64adf71c1b11da60b6d99e71
@iancharest - can you port this to Python?


Finishes Rspec configuration

This finishes up the rest of the configuration for rspec feature tests and adds a very basic sign up spec.

Working through some chrome + travis configuration -> https://docs.travis-ci.com/user/chrome#capybara


Help! I can not uninstall<EMAIL_ADDRESS>

Issue Type: Bug
I had success unistall<EMAIL_ADDRESS>but<EMAIL_ADDRESS>was not work!
I had try all of those:
rm -fr ~/Library/Preferences/com.microsoft.VSCode.helper.plist
rm -fr ~/Library/Preferences/com.microsoft.VSCode.plist
rm -fr ~/Library/Caches/com.microsoft.VSCode
rm -fr ~/Library/Caches/com.microsoft.VSCode.ShipIt/
rm -fr ~/Library/Application\ Support/Code/
rm -fr ~/Library/Saved\ Application\ State/com.microsoft.VSCode.savedState/
rm -fr ~/.vscode/

The uninstall reason is plugins not work, now I don't care about plugins, I only want a new version VSCode to use. Please help me.
VS Code version: Code 1.32.1 (05f146c7a8f7f78e80261aa3b2a2e642586f9eb3, 2019-03-08T00:15:00.418Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (5.26GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

vscode is in my downloads...


players can use the /log command to log their reflections about the previous cycle

Implement the /log command as outlined in the Learner UX document.

This is probably blocked on #28

See also: game-cli/#3

Issue moved to LearnersGuild/game-cli #11 via ZenHub.io


Double-check that all of the Artifact icons are correct

We should cross-reference each rendered Artifact card with a printed version of the game to confirm that all of the icons are correct.

[x] Age 1
[x] Age 2
[x] Age 3
[x] Age 4
[x] Age 5
[x] Age 6
[x] Age 7
[x] Age 8
[x] Age 9
[x] Age 10
[x] Relics

this should be good now.


Fix all of the JS in all the pages being broken

Mixed Content: The page at 'https://scottrice.github.io/Ice/' was loaded over HTTPS, but requested an insecure script 'http://code.jquery.com/jquery.js'. This request has been blocked; the content must be served over HTTPS.

Thanks for contributing!


French translation for « heading » should be « titre »

Describe the Bug
Phrasing of « Headings » is « En-Tête » which is an anglicism, « en-tête » exists in french but is something else than a title (it means « header ».
Steps to Reproduce

Configure  bookstack to french language
Create a new page with WYSIWYG editor
Click on style selector
The titles styles appear as « En-tête large » / « En-tête moyenne »… etc.

Expected Behaviour
Use something more French with « Titre »
Examples:

« Titre 1 » / « Titre 2 » /  …
« Titre de niveau un » /  « Titre de niveau deux » / …
« Titre principal » / « Titre secondaire » / …

Screenshots or Additional Context
For reference that is how LibreOffice labels the headings

Browser Details
No response
Exact BookStack Version
v23.08.3

Hi @JocelynDelalande,

exists in french but is something else than a title (it means « header ».

The original English text is based upon header ("Large Header", "Medium Header" etc...).
I'm not well-versed in French though so can't say what suits best.
If you're confident this needs to be changed, would you be willing to jump in via our translation platform and make the required updates?: https://crowdin.com/project/bookstack

Ok, I submited my translations on crowdin, I don't know exactly what to do from here ? Are my suggestions meant to be validated by someone ?
https://crowdin.com/editor/bookstack/88/en-fr?view=comfortable&filter=basic&value=0#q=header

@JocelynDelalande Crowdin changes will automatically sync across, and be merged/released at a convenient point, so nothing extra to do.
I think I may seek a second opinion on these changes though, just because I really don't know French conventions. Having "Title 2" ... "Title 5" for English is something I'd specifically avoid, so just trying to get a wider view to understand that balance of convention vs matching of the source text.

@matthias4217 Thanks for the extra input.
I've now reverted the changes here to the old translations for now, so we're not using numeric heading values, but I'd still welcome non-numeric changes from heading to titre if that suits better for French.


SoC AssertionError: Consumption too high in generate_from_simbev.py

I keep getting this error:
Traceback (most recent call last):
  File "generate_from_simbev.py", line 285, in <module>
    assert soc_needed <= 1 + vehicle_soc, \
AssertionError: Consumption too high for bev_luxury_00161_standing_t in row 17:
vehicle charged to 0.6211955093333333, needs SoC of 1.7750088136000002<PHONE_NUMBER>1600001 kW)

File: bev_luxury_00161_standing_times.csv
The data (row 17 from above is 15 in the CSV):
{'': '15', 'car_type': 'bev_luxury', 'bat_cap': '110', 'location': 'driving', 'netto_charging_capacity': '0.0', 'SoC_start': '0.4395952047999999', 'SoC_end': '0.2715663160727272', 'chargingdemand': '0.0', 'charge_time': '0', 'park_start': '0', 'park_end': '0', 'drive_start': '268', 'drive_end': '281', 'consumption': '18.48317776'})

which looks ok to me.
Checking the code snippet
https://github.com/rl-institut/spice_ev/blob/eb5ea00cb4d779fc1803f75fc171b5db2ffac4c7/generate_from_simbev.py#L279-L287
reveals that to calc soc_needed the wrong battery capacity is used (60 instead of 110).
Can you help, @stefansc1 ?

Fixed in 025afb80cf9be1d4785c82fe12523f60b4087ef2
Background: non-unique filenames in subdirs led to re-usage of old EV configuration.


Dead Link not being picked up... <a #="http://www.freecatphotoapp.com">cat photos.

Challenge Make Dead Links using the Hash Symbol has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Doesn't recognize the dead link

<a href="#""http://www.freecatphotoapp.com">cat photos.

Thank you irishrob86. It worked awesome !!!


expose BackupTimeFormat

I have exposed BackupTimeFormat.
If you have ideas to fix better, tell me please

Can you explain why you need to change the backup name format?  One of the reasons it isn't exposed is that it was chosen carefully to avoid name collisions (unless you rotate more than once a millisecond, which seems unlikely :)

The reasons are like below

To keep consistency of log name format with other apps not made by Go.
It seems unlikely that the log file is rotated more than once as you mentioned.
Some people might prefer to use "20060102T150405" format or other things instead of "2006-01-02T15-04-05".

I think if someone changes log format in new release, he can avoid name collision through handling existing log file or notify to operators, and above all things changing log format rarely happens.
In conclusion, I think that keeping consistency of bakcup format name is important, but it has not big advantage.

Please, could you check my comment again?

Sorry for the delayed response.  One problem is something you hinted at - the log file name is how we control rotation. If someone were to change the log file name after running their application, backup log files would not be removed.
I'll take another look and see if there are any other gotchas that may sway my opinion... but I am thinking this is probably ok.

I understand what you concern. I also concern that someone changes the log file name. I think that we have different assumptions.
I supposed that renaming log file name is the problem but rarely happens. And developer or operator who already handle the system consisting of applications made by different languages want to maintain consistency of log file name with other application's log file name.
I think that your approach is good at the system consisting of applications made by only golang and the new project in golang.
lumberjack is a great package. I hope that it covers the system consisting of applications made by different languages.

LGTM

I don't think the stated reasons for the change are a good enough reason to add to the package's API and add potential footguns if someone changes the backup time format without realizing it'll mean the code won't clean up old log files.
It seems like the only reason for this change is "I don't like the look of the name".  Which is unfortunate, but ultimately, it's not actually a technical problem, as far as I can tell.

Hi @natefinch, it's a nice consideration for old log files clean up. But I think customized backup-file-name is still reasonable requirement. I rotate my logs each day 00:00, and file name with "HH-mm-ss" is redundant.
There should be a way to reach into an agreement, make backup-file-name customized, as well as make this package consistent.

Well, I also don't support rotating files per day or other time period. The whole point of rotating files is to conserve disk space.  The amount of time that has passed is not important.  You might have a day of really heavy traffic that needs three rotations, or you might have 3 weeks of no traffic that doesn't need any rotations.


Avoid killing the process when a login window is closed.

We cannot use startsWith because if we use it we will kill the process when we close a login window.
When we stop the debugging session we receive 2 event names:

Debug Blazor Web Assembly in Browser: https://localhost:7291
Debug Blazor Web Assembly in Browser

So I think it's okay to keep without the startsWith as it was done before this commit: https://github.com/dotnet/razor/pull/5885
Fixes: https://github.com/aspnet/AspNetCore-ManualTests/issues/1834

/azp run

Merging on behalf of @thaystg as she seems to have no permissions to do so.


[config] Add chain-id to config-builder

Remove templates for config-builder based nodes, that's an anti-pattern
Add chain-id (CFG_CHAIN_ID) to all docker containers
Add chain-id to all relevant config(-builders)

@bors-libra r=sausagee

:pushpin: Commit 30d5c61 has been approved by sausagee

:hourglass: Testing commit 30d5c6195db425070d70fe7f266671dcb2d545d5 with merge aa22ab3a5a9c767a5cb0e13f6654689e2a08a19c...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sausagee
Pushing aa22ab3a5a9c767a5cb0e13f6654689e2a08a19c to master...


Error: category and action required ...

I have problem running the phonegap command
Here's the output. The error shows at the end.
How can I fix this? Thank you.
Usage: phonegap [options] [commands]

Description:

  PhoneGap command-line tool.

Commands:

  help [command]       output usage information
  create <path>        create a phonegap project
  build <platforms>    build the project for a specific platform
  install <platforms>  install the project on for a specific platform
  run <platforms>      build and install the project for a specific platform
  platform [command]   update a platform version
  plugin [command]     add, remove, and list plugins
  template [command]   list available app templates
  info                 display information about the project
  serve                serve a phonegap project
  version              output version number
  push                 send test push notification
  analytics            turn analytics on or off, or view current status

Additional Commands:

  local [command]      development on local system
  remote [command]     development in cloud with phonegap/build
  prepare <platforms>  copies www/ into platform project before compiling
  compile <platforms>  compiles platform project without preparing it
  emulate <platforms>  runs the project with the flag --emulator
  cordova              execute of any cordova command

Options:

  -d, --verbose        allow verbose output
  -v, --version        output version number
  -h, --help           output usage information
  --no-update-notifier disable update notifier, to opt-out of update-notifier
                       change the 'optOut' property to 'true' in
                       ~/.config/configstore/update-notifier-phonegap.yml

Examples:

  $ phonegap help create
  $ phonegap create path/to/my-app
  $ cd my-app/
  $ phonegap run ios
  $ phonegap analytics on

/usr/lib/node_modules/phonegap/node_modules/insight/lib/index.js:114
		throw new Error('category and action required');
		^

Error: category and action required
    at Insight.trackEvent (/usr/lib/node_modules/phonegap/node_modules/insight/lib/index.js:114:9)
    at Function.trackEvent (/usr/lib/node_modules/phonegap/lib/cli/analytics.js:135:17)
    at /usr/lib/node_modules/phonegap/bin/phonegap.js:39:19
    at CLI.module.exports [as help] (/usr/lib/node_modules/phonegap/lib/cli/help.js:48:5)
    at CLI.module.exports [as argv] (/usr/lib/node_modules/phonegap/lib/cli/argv.js:116:17)
    at runPhoneGapCommand (/usr/lib/node_modules/phonegap/bin/phonegap.js:31:9)
    at Object.<anonymous> (/usr/lib/node_modules/phonegap/bin/phonegap.js:23:5)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)

Hi @klarizonemar,
Thank you for pointing this out! This error is not an issue with PhoneGap but with the module we use for analytics. All other PhoneGap commands should work as expected.

This is a phonegap error. My mistake.
Currently the basic commands phonegap help, phonegap -h and phonegap --help will fail.
The patch will be out soon.
As a temporary workaround you can use phonegap help -h

Ok. Thank you guys!


Ignore clipboard content from sensitive applications

One feature I miss from Paste is the blacklisting of copied values from secure and sensitive applications like 1Password. Paste detected a copy from 1Password and did not store it in the clipboard manager contents.

It is already done in fa83d5f163592a61c1474b2f10dee4bd356a43d8 and will be availabe in the next release.

Duplicate of #65

Any ETA on the next release :D? Loving Maccy by the way!


Fix how time series widget manages time zones

Description
Shortcut: https://app.shortcut.com/cartoteam/story/261050/ac-7xhfwyml-carto-3-timeseries-filtering-makes-geometries-disappear
There is a problem on how we deal with dates on the time series widget. Sometimes we're receiving dates with time zones, and we're ignoring them when calling the toDate() function. I've added a new function so that we can get the number of milliseconds since the ECMAScript epoch, adding the proper amount of time that corresponds to the time zone.
Type of change
(choose one and remove the others)

[x] Fix
Feature
Refactor
Tests
Documentation

Acceptance
Please describe how to validate the feature or fix

Add a time series widgets to a map created using a dataset containing dates with timezones.
Configure the time series widget to filter by hour/minutes.
Check that the dataset values are filtered correctly.

In order to complete the acceptance in CARTO 3 we have to complete the same steps from Builder.
Basic checklist

[x] Good PR name
[x] Shortcut link
[x] Changelog entry
[x] Just one issue per PR
[x] GitHub labels
[x] Proper status & reviewers
[ ] Tests
[x] Documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.525%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1695

Relevant Lines:
2211

💛  - Coveralls

Hi @moicalcob! Thank you for your work here! It was really useful to understand what was happening. However, as discussed today, it seems this would require a complex solution, and we would need to know if the time includes or not the time zone to properly handle each case. So I've created this document to be reviewed by product team.
Closing this one in the meantime :bow:


Remove unused config batch_pool_size

batch_pool_size configuration is not used since this commit: https://github.com/heroiclabs/nakama/commit/de3ef8866ac97c7234f82ef739e3195bf8e67bc8
Also documentation on the website should be fixed: https://heroiclabs.com/docs/nakama/getting-started/configuration/#matchmaker.batch_pool_size

@maciejmrozinski Awesome! 🙇


Minor edits on notebook for Session 2

I made a few corrections to the notebook based on the experience during the
first lesson.
In summary:

Moved the formative assessment regarding lists to a better position.
Renamed the variable tuple to tuple so we don't override the tuple()
function.

@aguspesce @isamarcortes @mdpiper
Would be nice to review and merge this PR before this Wednesday.


[$250]  iOS Push Notifications sometimes have no avatar

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.75-1
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1716825560361569
Action Performed:
User B logged in iOS device and notifications enabled

Go to staging.new.expensify.com
Send a message from A to B

Expected Result:
The notification received with the user's avatar
Actual Result:
No avatar displays in the notification
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

reportID<PHONE_NUMBER>129650
reportActionID<PHONE_NUMBER>960326136

Relevant logs:

88862970fa2b077b-MRS
laLjTN
s3TC21

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018463b08116cdfa88
Upwork Job ID:<PHONE_NUMBER>839853056
Last Price Increase: 2024-05-27

Issue OwnerCurrent Issue Owner: @arosiclair

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

seems to be an internal issue

I wasn't able to find the root issue for this when I looked into it though I'm pretty sure it was probably a transient issue in the NotificationService for iOS.
We do os_log in that lib for most errors but those are not sent to the backend. I think we should find a way to write and upload logs from swift code so we can debug this kind of issue in the future.

No progress on this yet

Focusing on a critical issue atm.

Since the plan is to just improve logging for swift code, I'm going to switch this to a NewFeature and mark this External.

Problem
We have some native iOS swift code that configures notifications here. This code logs errors using os_log but these are local only so it's not possible to debug those issues in production.
Solution
Find some way to upload logs from Swift code to our server like we do in React here so that we can debug issues in native code.

@dubielzyk-expensify this is just a logging improvement so no design input needed here.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Upload logs from Swift code
What is the root cause of that problem?
No Problem, it's a feature request.
What changes do you think we should make in order to solve the problem?
To support reading logs from Swift code we need to add native module to our app.
The implementation that I'm trying doesn't support devices with iOS version less than 15.0 which I think doesn't seem to be a worry for us.
https://gs.statcounter.com/ios-version-market-share/ Seems nobody now using devices with less v15.0 which is a great thing.
The support to read logs from device is done by using OsLogStore class from osLog class provided in swift.
using OsLogStore.getAllEntries will give the all logs happened with the iOS devices (or current process) based on that we can process the log message.
I'm attaching a sample function that I have tested with and working fine.
  @objc(withResolver:withRejecter:)
  func logs(resolve:RCTPromiseResolveBlock,reject:RCTPromiseRejectBlock) -> Void {
    if #available(iOS 15.0, *) {
     let subsystem = Bundle.main.bundleIdentifier!
     // Open the log store.
     do {
     let logStore = try OSLogStore(scope: .currentProcessIdentifier)

     // Get all the logs from the last hour.
     let oneHourAgo = logStore.position(date: Date().addingTimeInterval(-3600))

     // Fetch log objects.
     let allEntries = try logStore.getEntries(at: oneHourAgo)

     // Filter the log to be relevant for our specific subsystem
     // and remove other elements (signposts, etc).
     let bundleLogs = allEntries
         .compactMap { $0 as? OSLogEntryLog }
         .filter { $0.subsystem == subsystem }
         .map { $0.formatString }

      resolve(bundleLogs);
     }catch {
      reject("OSVersionError","Error", nil)
     }
    }else{
      reject("OSVersionError","Not possible", nil)
    }
  }

With the above code we can read the logs and share it with react-native.
We can create a new module and attach this to expensify app, whenever we want logs we can use logs() function exposed from swift inside our JS code and save it along with the existings logs.

What alternative solutions did you explore? (Optional)
NA
Demo
https://github.com/Expensify/App/assets/59088937/cc3b6434-8a2e-4c38-9e46-e35d977423e9
The above demo is showing that inside multiply function I'm doing logs 4 times which I can read later after calling the multiply function all throughout using JS with native swift code.

@abdulrahuman5196 @arosiclair Soft ping for proposal review, thanks!

Thanks for the proposal @b4s36t4. Is there a way we can actively push logs to our JS logging system rather than fetching logs from Swift after the fact? Put another way, is there a way to implement Log.info() Log.hmmm(), and etc. in Swift and have those logs pushed to JS directly?

No @arosiclair. Basically there's no way to stream the logs directly through code as far as I've researched.
This is the only I was able to extract the logs, I'll try if there's anyway to stream the logs directly.

there's no way to stream the logs directly through code as far as I've researched.

Do you mean logs written to os_log specifically? There's no requirement to keep using os_log if it prevents this. Is there a way we can communicate from Native to React Native to write logs?

@mvtglobally no need to reproduce this issue

Looks like we may have some agencies look at this (thread)

I started working on a proposal for this, but first i'd like get some opinions about how we go forward with writing native modules / TurboModules.
Posted a thread here: https://expensify.slack.com/archives/C01GTK53T8Q/p1719311680059169

@kirillzyusko is going to take this over, because i'm gonna be OOO for the next few weeks.
I did some initial research and shared my findings with @kirillzyusko. Also there was some good traffic in the slack thread, so we should be good to go with (potentially) implementing a native module to solve this problem

@MelvinBot I'm working on this issue 👀

Any updates on this @kirillzyusko?

@arosiclair yeah, I implemented a necessary changes (I created a separate library, because it was easier/faster).
The only one problem right now is to verify that os_log logs are actually can be retrieved. For that we need to test send/receive push notifications, and here is the problem, because I don't belong to Expensify team and I don't have certificates to sign the app.
@hannojg suggested the idea of testing it locally in example app - but here is also a problem, since he tried to invite me to his dev team, but dev team is not showing up in my XCode settings 🤷♂
I've also asked @Kureev to check the example app (he had some spare cycles, but as I know he didn't start to work on this task yet). And @Szymon20000 also offered a help (he belongs to Expensify dev team). So we are discussing it internally how to test that/etc. 👀

Sounds good thanks for the update. If you guys can't find a solution, I can try testing a draft PR if you have one (though I don't have much bandwidth atm).

No worries, I have time today to look into this with Kiryl! 😊

@arosiclair I opened a PR https://github.com/Expensify/App/pull/45905
I decided to move all functionality with forwarding logs to separate library/module (react-native-app-logs), because it'll be easier to support code in such way.
Let me also quickly describe how it works - when NotificationService gets destroyed (i. e. we received notification) we pull all logs and forward them to main app (we need to forward them to main app, because NotificationService doesn't know anything about react-native). In iOS all processes are isolated, so to share the data between them they must belong to the same app group.
So to make this library work in Expensify we need to add new capability to the main app and NotificationService - App Group. And we need to use common identifier between these 2 groups (in my PR I used group.com.expensify.chat).
Once it's done we need to recompile the app, send push notification and verify that everything works 🎉 I tested everything in example app and it works pretty stable. But I can not accomplish remaining changes, because I'm not belonging to the Expensify app.
So @arosiclair may I ask you to help me to finish this task (i. e. to add AppGroup capability + setup common identifier and finally test that everything works)?

Excellent work I'll try making some time to give it a test. If everything looks good I'll get started on adding the new capability (very annoying process 😅).

No updates for this yet

Looks like we'll have to add the App Groups entitlement to our (NewApp) provisioning profiles before I can run the app and test. I'll open up an issue for it.

On second thought, maybe we should hold on setting this up considering it'll need to be re-done for the hybrid app anyway? @AndrewGable @Julesssss what do you think? We're working on pushing logs from native Swift code to our servers so we can debug issues with notification styling that happen in prod.

@kirillzyusko we just merged changes to enable app groups! Can you update your PR to pull those changes and use group.com.expensify.new for the group?

Can you update your PR to pull those changes and use group.com.expensify.new for the group?

@arosiclair yep, updated the PR! Feel free to check it 🙌
Or @chrispader is going to check how it works?

i can have a look at it. going to build it on a physical device (for context: @kirillzyusko isn't part of the provisioning profile to build on physical devices)

Attempted a test on this. Comments on the PR.

No C+ review was needed since this was just an iOS change. PR is merged and on its way to deploy.

The PR has been reverted, being suspected to increase heating / CPU consumption: https://margelo.slack.com/archives/C01GTK53T8Q/p1727896624465699

Any ideas on what might be the issue? We didn't change much in our App code for this. Is there anything suspicious like a possible infinite loop in the react-native-app-logs repo? @hannojg @kirillzyusko

Kiryl is OOO and back Monday next week to have a detailed look!

@arosiclair probably OSLogStore requires a lot of CPU resources so all operations are very expensive. I'll try to profile performance with XCode profiler and provide more details this week!
Anyway I have some potential optimizations in my head that we can apply and significantly reduce overheating 👀

@arosiclair I fixed overheating issue - would you mind to review and test new PR revision? https://github.com/Expensify/App/pull/51086

I'll take a look. What was the root problem?

The operation with OSLogStore (logs retrieving) is a pretty complex operation in terms of performance and on a real devices takes much more time than on simulator (on my iPhone 11 it was taking 1s). Since we did it every 5s the device got overheated pretty quickly.
I re-worked code and made interval customizable. Since we want to intercept only push-notifications logs I disabled constant pulling from main app at all. I think such approach will significantly free up resources.
However I don't know whether device will be overheated if you receive messages (i. e. notifications) frequently - that's something that would be good to test 🙌

Cool, nice work 👍. I'll review soon-ish. I have some higher priority projects to address atm though.

No regression tests needed since this is just for logging. Thanks for the help @kirillzyusko! Closing this out.


Add radial basis functions as a finite element type

This adds finite elements that replace polynomial basis functions with radial basis functions and reproducing kernels. For now, they can essentially be used in place of the L2 elements. A summer student project this year will extend these to H1 and add them as an option for Blast hydrodynamics.
RK has been added as an option for the serial/parallel versions of ex14 and ex18.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3657
@brbass
@tzanio
@v-dobrev + @bslazarov + @tzanio + @vladotomov + @mlstowell
6/6/23
⌛due 6/20/23
⌛due 6/27/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

A few automated checks are failing. Once they are resolved, I will resolve this thread.

A few automated checks are failing. Once they are resolved, I will edit this comment to reflect that.

A few automated checks are failing. Once they are resolved, I will edit this comment to reflect that.

Some of them are because of -Wshadow you may need to rename some method parameters not to shadow data members.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Looks nice 👀
> ./ex14 -r 0 -o 1
Number of unknowns: 80
   Iteration :   0  (B r, r) = 0.105602
   Iteration :   1  (B r, r) = 0.0936915
   Iteration :   2  (B r, r) = 0.0369216
   Iteration :   3  (B r, r) = 0.00480185
   Iteration :   4  (B r, r) = 0.000305308
   Iteration :   5  (B r, r) = 6.01273e-06
   Iteration :   6  (B r, r) = 5.5978e-07
   Iteration :   7  (B r, r) = 1.27492e-07
   Iteration :   8  (B r, r) = 4.87046e-09
   Iteration :   9  (B r, r) = 4.13321e-10
   Iteration :  10  (B r, r) = 2.55884e-11
   Iteration :  11  (B r, r) = 1.71297e-12
   Iteration :  12  (B r, r) = 3.6148e-14

> ./ex14 -r 0 -o 2
Number of unknowns: 180
   Iteration :   0  (B r, r) = 0.0384696
   Iteration :   1  (B r, r) = 0.0674852
   Iteration :   2  (B r, r) = 0.0452407
   Iteration :   3  (B r, r) = 0.0231711
   Iteration :   4  (B r, r) = 0.0143464
   Iteration :   5  (B r, r) = 0.00324877
   Iteration :   6  (B r, r) = 0.000598329
   Iteration :   7  (B r, r) = 0.000114269
   Iteration :   8  (B r, r) = 5.80389e-06
   Iteration :   9  (B r, r) = 3.57913e-07
   Iteration :  10  (B r, r) = 2.58565e-07
   Iteration :  11  (B r, r) = 1.30609e-07
   Iteration :  12  (B r, r) = 2.6538e-08
   Iteration :  13  (B r, r) = 3.38561e-09
   Iteration :  14  (B r, r) = 9.79489e-10
   Iteration :  15  (B r, r) = 2.73808e-10
   Iteration :  16  (B r, r) = 6.4906e-11
   Iteration :  17  (B r, r) = 1.39148e-11
   Iteration :  18  (B r, r) = 2.97879e-12
   Iteration :  19  (B r, r) = 8.5153e-13
   Iteration :  20  (B r, r) = 1.06041e-13
   Iteration :  21  (B r, r) = 2.89985e-14

>./ex14  -r 0 -rk
Number of unknowns: 320
   Pass :  1   Iteration :   0  ||B r|| = 0.497806
   Pass :  1   Iteration :   1  ||B r|| = 0.303602
   Pass :  1   Iteration :   2  ||B r|| = 0.222802
   Pass :  1   Iteration :   3  ||B r|| = 0.122445
   Pass :  1   Iteration :   4  ||B r|| = 0.0593974
   Pass :  1   Iteration :   5  ||B r|| = 0.0233907
   Pass :  1   Iteration :   6  ||B r|| = 0.00800252
   Pass :  1   Iteration :   7  ||B r|| = 0.00331922
   Pass :  1   Iteration :   8  ||B r|| = 0.00171171
   Pass :  1   Iteration :   9  ||B r|| = 0.000836335
   Pass :  1   Iteration :  10  ||B r|| = 0.000300281
Restarting...
   Pass :  2   Iteration :  11  ||B r|| = 0.000127599
   Pass :  2   Iteration :  12  ||B r|| = 6.88162e-05
   Pass :  2   Iteration :  13  ||B r|| = 3.29675e-05
   Pass :  2   Iteration :  14  ||B r|| = 1.74448e-05
   Pass :  2   Iteration :  15  ||B r|| = 7.80894e-06
   Pass :  2   Iteration :  16  ||B r|| = 4.93744e-06
   Pass :  2   Iteration :  17  ||B r|| = 3.48114e-06
   Pass :  2   Iteration :  18  ||B r|| = 1.92142e-06
   Pass :  2   Iteration :  19  ||B r|| = 9.6698e-07
   Pass :  2   Iteration :  20  ||B r|| = 3.42733e-07

Please mention in CHANGELOG

Done. I kept the description relatively short but can extend it if that would be helpful.

@tzanio can re remove the in-review label?

@tzanio can we remove the in-review label?

I removed the label!


Change made for react native breaks all webpack Moment.js users

Hi,
I'm Maggie from the moment core team. We merged + released a change that react native users requested to rename all dynamic requires because they apparently do not work with this library: https://github.com/moment/moment/pull/4207
The net result is that all webpack2 users are now broken: https://github.com/moment/moment/issues/4216
We're working on getting a small sample app that replicates pushed to a branch. In the interim, can you give me any insights on whether there is a different acceptable solution than the one here? I'm happy to ship any kind of bug fix release that makes sense.
Thanks,
Maggie

Example: https://github.com/mj1856/moment-webpack-test

Hey @maggiepint, I believe this is being discussed already in https://github.com/facebook/metro-bundler/issues/65.


Fixed typos and updated references in the documents.

Updated references in documents, from docs.microsoft.com - to learn.
Fixed the typos in the documentation.

@ElYusubov thanks for the contributions, will you be okay to resolve conflicts and update the PR

@ElYusubov quick nudge, we you would like to get this PR in soon :)


HDFS-15217 Add more information to longest write/read lock held log

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 44s
trunk passed

+1 :green_heart:
compile
1m  6s
trunk passed

+1 :green_heart:
checkstyle
0m 48s
trunk passed

+1 :green_heart:
mvnsite
1m 13s
trunk passed

+1 :green_heart:
shadedclient
17m 29s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 42s
trunk passed

+0 :ok:
spotbugs
3m  2s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 58s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

-0 :warning:
checkstyle
0m 44s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 81 new + 164 unchanged - 1 fixed = 245 total (was 165)

+1 :green_heart:
mvnsite
1m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 33s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

-1 :x:
findbugs
3m  5s
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

-1 :x:
unit
110m 34s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

183m  0s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:[line 7436]

Possible null pointer dereference of ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:[line 3207]

Possible null pointer dereference of res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:[line 3242]

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancer

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1954

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 652450b0e918 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 275c478

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/testReport/

Max. process+thread count
2879 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 46s
trunk passed

+1 :green_heart:
compile
1m 10s
trunk passed

+1 :green_heart:
checkstyle
0m 53s
trunk passed

+1 :green_heart:
mvnsite
1m 18s
trunk passed

+1 :green_heart:
shadedclient
15m 50s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s
trunk passed

+0 :ok:
spotbugs
2m 54s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 53s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-0 :warning:
checkstyle
0m 44s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 164 unchanged - 1 fixed = 166 total (was 165)

+1 :green_heart:
mvnsite
1m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  2s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

-1 :x:
findbugs
2m 59s
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

-1 :x:
unit
97m 22s
hadoop-hdfs in the patch passed.

+0 :ok:
asflicense
0m 16s
ASF License check generated no output?

164m  2s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:[line 7442]

Possible null pointer dereference of ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:[line 3213]

Possible null pointer dereference of res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:[line 3248]

Failed junit tests
hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy

hadoop.hdfs.TestDecommissionWithStriped

hadoop.hdfs.TestSetrepIncreasing

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.TestMaintenanceState

hadoop.hdfs.TestErasureCodingPolicyWithSnapshot

hadoop.hdfs.tools.TestECAdmin

hadoop.hdfs.TestQuotaAllowOwner

hadoop.hdfs.TestDFSUpgrade

hadoop.hdfs.TestHFlush

hadoop.hdfs.tools.TestViewFSStoragePolicyCommands

hadoop.hdfs.TestDecommissionWithBackoffMonitor

hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer

hadoop.hdfs.TestFileCorruption

hadoop.hdfs.TestErasureCodingExerciseAPIs

hadoop.hdfs.TestReadStripedFileWithMissingBlocks

hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData

hadoop.hdfs.TestReadStripedFileWithDNFailure

hadoop.hdfs.TestClientProtocolForPipelineRecovery

hadoop.hdfs.tools.TestDFSAdmin

hadoop.hdfs.TestDecommission

hadoop.hdfs.tools.TestStoragePolicySatisfyAdminCommands

hadoop.hdfs.TestDFSClientRetries

hadoop.hdfs.TestFileStatus

hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks

hadoop.hdfs.TestDFSInotifyEventInputStream

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestAppendSnapshotTruncate

hadoop.hdfs.TestStripedFileAppend

hadoop.hdfs.TestRestartDFS

hadoop.hdfs.TestGetBlocks

hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy

hadoop.hdfs.security.token.block.TestBlockToken

hadoop.hdfs.TestFileCreation

hadoop.hdfs.security.TestDelegationToken

hadoop.hdfs.TestDFSStartupVersions

hadoop.hdfs.TestClientReportBadBlock

hadoop.cli.TestHDFSCLI

hadoop.hdfs.TestModTime

hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy

hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.TestBlocksScheduledCounter

hadoop.hdfs.tools.TestDebugAdmin

hadoop.hdfs.TestDFSUpgradeFromImage

hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy

hadoop.hdfs.TestLeaseRecoveryStriped

hadoop.hdfs.TestBlockTokenWrappingQOP

hadoop.hdfs.web.TestWebHDFS

hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.tools.TestDFSAdminWithHA

hadoop.hdfs.TestErasureCodingPolicies

hadoop.hdfs.security.TestDelegationTokenForProxyUser

hadoop.hdfs.TestDFSStripedInputStream

hadoop.hdfs.TestEncryptionZonesWithHA

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.TestDatanodeRegistration

hadoop.hdfs.TestWriteReadStripedFile

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1954

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 1b3d6d7aab73 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8d49229

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/testReport/

Max. process+thread count
2028 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I fixed the checkstyle errors. And I don't think the findbugs errors are related to the patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
26m 48s
trunk passed

+1 :green_heart:
compile
1m 27s
trunk passed

+1 :green_heart:
checkstyle
1m  0s
trunk passed

+1 :green_heart:
mvnsite
1m 35s
trunk passed

+1 :green_heart:
shadedclient
21m 13s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s
trunk passed

+0 :ok:
spotbugs
3m 53s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 49s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 27s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)

+1 :green_heart:
mvnsite
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 22s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

-1 :x:
findbugs
3m 53s
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

-1 :x:
unit
127m 55s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

215m 41s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:[line 7443]

Possible null pointer dereference of ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:[line 3213]

Possible null pointer dereference of res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:[line 3248]

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.TestFSNamesystemLock

hadoop.hdfs.server.namenode.TestNameNodeMXBean

hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1954

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d81063025720 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8d49229

Default Java
1.8.0_242

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/3/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/3/testReport/

Max. process+thread count
2841 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

It looks like extracting the getStackTrace method broke the test of TestFSNamesystemLock. I reverted it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 13s
trunk passed

+1 :green_heart:
compile
1m 34s
trunk passed

+1 :green_heart:
checkstyle
1m  4s
trunk passed

+1 :green_heart:
mvnsite
1m 40s
trunk passed

+1 :green_heart:
shadedclient
21m  4s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s
trunk passed

+0 :ok:
spotbugs
4m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m  8s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 44s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

+1 :green_heart:
checkstyle
0m 58s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)

+1 :green_heart:
mvnsite
1m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
18m 18s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

-1 :x:
findbugs
4m 18s
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

-1 :x:
unit
136m 22s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 59s
The patch does not generate ASF License warnings.

230m 50s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:[line 7443]

Possible null pointer dereference of ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:[line 3213]

Possible null pointer dereference of res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:[line 3248]

Failed junit tests
hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestDecommission

hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.TestErasureCodingPolicies

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1954

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a81ab0443a22 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8d49229

Default Java
1.8.0_242

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/4/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/4/testReport/

Max. process+thread count
3464 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@goiri I added comments in the test. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
25m 36s
trunk passed

+1 :green_heart:
compile
1m 18s
trunk passed

+1 :green_heart:
checkstyle
0m 54s
trunk passed

+1 :green_heart:
mvnsite
1m 28s
trunk passed

+1 :green_heart:
shadedclient
18m 19s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s
trunk passed

+0 :ok:
spotbugs
3m 26s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 25s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 29s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 164 unchanged - 1 fixed = 164 total (was 165)

+1 :green_heart:
mvnsite
1m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 31s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

-1 :x:
findbugs
3m 28s
hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

_ Other Tests _

-1 :x:
unit
118m 25s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

197m 51s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs

Possible null pointer dereference of effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:effectiveDirective in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCacheDirective(CacheDirectiveInfo, EnumSet, boolean)  Dereferenced at FSNamesystem.java:[line 7443]

Possible null pointer dereference of ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:ret in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)  Dereferenced at FSNamesystem.java:[line 3213]

Possible null pointer dereference of res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:res in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean, Options$Rename[])  Dereferenced at FSNamesystem.java:[line 3248]

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1954

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 756ef23e6abd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3edbe87

Default Java
1.8.0_242

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/5/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/5/testReport/

Max. process+thread count
3178 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1954/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@brfrn169 thanks for updating.
One concern I have is the added overhead.
Specially, the overhead within the write lock.
Any thoughts there?

@goiri I don't think the overhead is not large because building the lock report message happens only when the lock interval is more than the threshold. And to reduce the overhead, I use Supplier for the lazy lock report message building.

@brfrn169 I also believe that the Supplier logic should only be trigger if we log it.
Can we do some benchmarking or profiling to verify this?

@brfrn169 Okay. Will do that.

I did microbenchmarking with JMH. The code is as follows:
https://gist.github.com/brfrn169/6a57175d934734b2a2c36652925ffdf6
The results are as follows:
Before applying the patch:
Benchmark                         Mode  Cnt    Score   Error  Units
FSNamesystemBenchmark.benchmark  thrpt   25  567.924 ± 3.184  ops/s

After applying the patch:
Benchmark                         Mode  Cnt    Score    Error  Units
FSNamesystemBenchmark.benchmark  thrpt   25  573.884 ± 11.171  ops/s

It looks like there isn't any performance regression after applying the patch.

Thanks @brfrn169 for the benchmark, I think this is safe enough.
We've also been on this for a while so I guess nobody else has concerns.
I'll go ahead and merge this.


Feature: enable invscov into afl++ (Fuzzbench/OSS-Fuzz)

Your code is not even released and here's your first issue... :-)
We'd love to see your code enabled into afl++ as a special mode.
Afl++ is already supported in Fuzzbench and it used actively to test new fuzzing techniques. If you could enable invscov in mainstream afl++, we'd easily be able to test it with a combination of other afl++ options!
Afl++ is also used in OSS-Fuzz, which is used to continuously fuzz hundreds of open source projects.

Afl++ is already supported in Fuzzbench and it used actively to test new fuzzing techniques

Wow I was not aware of it, really :)
The practical challenges to integrate the feedback from LLVM values in-tree in AFL++ are not trivial. Basically, I used Daikon to not reinvent the wheel, but I really don't like it and I feel that single-thread Java monther does not fit in the AFL++ codebase that we distribute to the public that is not an academic protoype. In addition, stopping the campaign to run a tool and recompile many times the PUT is not so user-friendly as we want AFL++ to be.
So, the way to go, is to code another invariants miner and embed it direclty into the runtime to learn invariants during the execution. I'm working on it, there are several challenges to overcome (e.g. as you don't know the variables involved in invariants at compile time, the pass instruments all, so the produced binary is slow) but I will adress them in the near future. Research is incremental :)

I see what you mean. Note that it's fine to have a non-optimized version of invscov in Fuzzbench to get early feedback on how it performs on the benchmarks. Perfect is the enemy of good, and industry is incremental too!
If it's easier to integrate a non-afl++ version, that's fine too. We don't need to necessarily learn the invariants at runtime. We (Fuzzbench), could start invscov with an existing corpus (we have plenty) and invscov can learn the invariants once at start time. We can manually create several invscov campaigns, run one after the other, each time hardcoding the previous corpus as initial seed to learn the invariants from. We could do that, say, 3 times to see if it plateaus or not. This would already give us a good idea of how well it will work.
We certainly don't need to have the final optimized version to test it out. Sure, for OSS-Fuzz we'd like a more polished version, but don't let that get in the way for Fuzzbench. We've run several fuzzers from academic researchers (e.g. symcc) and they included the results in their submission. We've had a good experience so far with PoC code.

If it's easier to integrate a non-afl++ version, that's fine too.

No I don't think that running Daikon inside FuzzBench will be easy.
Btw, I will for sure have an usable invariants mode into AFL++ (devel in the "unusual_values" branch) before USENIX (and so before that this prototype will be public).
FuzzBench is already evaluating it, I already explained some details in the upcoming experiment https://github.com/google/fuzzbench/pull/1170 about the first one as it seems promising even if a lot slow ATM.

SG! Thanks for submitting the PR!

We'd love to see your code enabled into afl++ as a special mode.

you are aware that @andreafioraldi is one of the 4 maintainers of afl++? ;)

I was not until yesterday, but someone on my team pointed this out :-) hahah
I took so much care of introducing afl++... to the maintainers! ^^

That's when all the fuzzers are between 4 and 5 hours (the OSS Fuzz time IIRC). At least here the new prototype seems to work, but there are several challenges.

I haven't really fixed the speed problem
Invariants are too naive
The policy to decide when alternate CGF with learning and invscov is dumb

The results seems also unstable, maybe max is high because the fuzzer can find the bug but the median is low. This is IMO related to the policy used to alternate learning and invariants feedback fuzzing.

aflplusplus_unusual_disabled is now after 14h slowly reaching enabled. While finding bugs early is very good, I feel that I can do far better because of this additional problem that I forgot:
When an invariant is violated the current impl cannot learn a more strict version and get a feedback when this new version is violated (e.g. x > 0 is violated with x==0 so it should be transformed to x >= 0).

@laurentsimon the thing that I noticed is that the initial corpus from OSS-Fuzz is not really saturated, do u know why?

I have to find a way to compile two binaries with the exact same coverage map :(

you mean you want deterministic edge IDs?

the initial corpus from OSS-Fuzz is not really saturated, do u know why?

What's the name of your experiment?
@jonathanmetzman where did we get the corpus from?


Ft 164 Sidebar with user list

Which Issue was this PR made for?

Closes #164

What is within the scope with this PR

[x] Creating a sidebar
[x] Displays usernames
[x] Styling

[x] Try to reuse the existing AvatarDOM component

What is NOT in the scope with this PR

Chat functionality (will remove it later)

Related Issue

#219
#245
#292

Other sidenotes that reviewer should be aware of

I used scss for styling, will adopt to #235 when the time comes
I think the small components should be separated within Sidebar.tsx as well.
This branch has #302 and #296 merged. Make sure those are merged to main before

SUCCESS

Why does the description say we're removing the chat functionality? I think having chat in the sidebar would be nice

This PR is for user list only and having chat button without function is kinda weird. So what I meant there was removing the chat button from this PR.

This PR is for user list only and having chat button without function is kinda weird. So what I meant there was removing the chat button from this PR.

I see that makes sense

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

The list gets some blank when user leaves

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

I think there should be a bigger margin between the user rows.

The list gets some blank space when user leaves

If it's easily fixable, it'd be nice to have that fixed hmm

If it's easily fixable, it'd be nice to have that fixed hmm

This should be fixed

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com

AUTOMATED: Deployed to https://pr-237.dev.mochatto.com


Question: socket.gethostname() functionality for this crate?

I was just wondering if it makes sense to add a similar functionality to that of python's socket module to this crate so the hostname (FQDN or not) of the machine (for the local end of) socket is returned? or this is something beyond/unrelated to this crate?

Seems reasonable to me to add!

Thanks
I'd like to tackle this.
any hints/directions on design of the API is appreciated. For example, should we support gethostnmame() for all possible combination of Domain, Type and Protocol that socket2 offers or just focus on some?
(ex: does adgram type unix-domain socket need to have access to gethostname())

@spamwax do you still need this? According to the manual glibc actually uses uname(2), so something like Nix might be a better crates for this, they already have a wrapper function: https://docs.rs/nix/0.19.1/nix/sys/utsname/fn.uname.html.

ok, thanks.


Adapt frontend to use new endpoint for DOI information submission instead of folder patch

Description

Adapt frontend to use new DOI info submission endpoint instead of patch call to folder.
The endpoint is /submission/{submission}/doi, which will accept Datacite information in a request body as JSON.
DoD (Definition of Done)
The frontend uses a designated API endpoint for adding Datacite information to the folder.
Testing
At least integration tests

Here's the PR with the change in the backend.
https://github.com/CSCfi/metadata-submitter/pull/450


Drag and dropped assets do not get teleported along with avatar

-The drag and dropped assets such as swords bow, etc do no get teleported along with avatars as we switch scenes.
-Only the asset itself isn't there with avatar
-The action/animation related to asset still get performed as it can be seen in the video below
-Unable to drop the silsword wit "R" key.(Dropping bow with R key works here)
https://user-images.githubusercontent.com/35926530/162500635-1c61ccc6-6e8f-4a52-9484-e9a5322e54a0.mp4

Yes, looks like an item AppManager ownership problem.

Note however that this kind of "teleport" will not exist and that menu will not be there.

Updated the issue with some more info.

Fixed