Unable to launch Husky Gazebo simulator noetic-devel

I started with a clean noetic environment:
mkdir -p ~/catkin_ws/src
$ cd ~/catkin_ws/src
$ sudo apt-get install ros-noetic-desktop-full
$ git clone https://github.com/clearpathrobotics/LMS1xx.git
$ git clone https://github.com/husky/husky.git
$ cd husky
$ git checkout noetic-devel
$ cd ~/catkin_ws
$ rosdep install --from-paths src --ignore-src --rosdistro ${ROS_DISTRO} -y --as-root pip:no
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
husky_bringup: Cannot locate rosdep definition for [um7]
husky_control: Cannot locate rosdep definition for [multimaster_launch]
husky_gazebo: Cannot locate rosdep definition for [multimaster_launch]

Wasn't sure how to solve that last issue (it seems um7 is only available on melodic), but I was successfully able to run:
catkin_make
source devel/setup.bash

But when I try to run Gazebo, I get the following error:
roslaunch husky_gazebo husky_empty_world.launch
... logging to /root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/roslaunch-cpr-mic09-31077.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

started roslaunch server http://cpr-mic09:36295/

SUMMARY
========

PARAMETERS
 * /ekf_localization/base_link_frame: base_link
 * /ekf_localization/frequency: 50
 * /ekf_localization/imu0: imu/data
 * /ekf_localization/imu0_config: [False, False, Fa...
 * /ekf_localization/imu0_differential: True
 * /ekf_localization/imu0_queue_size: 10
 * /ekf_localization/imu0_remove_gravitational_acceleration: True
 * /ekf_localization/odom0: husky_velocity_co...
 * /ekf_localization/odom0_config: [False, False, Fa...
 * /ekf_localization/odom0_differential: False
 * /ekf_localization/odom0_queue_size: 10
 * /ekf_localization/odom_frame: odom
 * /ekf_localization/two_d_mode: True
 * /ekf_localization/world_frame: odom
 * /gazebo/enable_ros_network: True
 * /husky_joint_publisher/publish_rate: 50
 * /husky_joint_publisher/type: joint_state_contr...
 * /husky_velocity_controller/angular/z/has_acceleration_limits: True
 * /husky_velocity_controller/angular/z/has_velocity_limits: True
 * /husky_velocity_controller/angular/z/max_acceleration: 6.0
 * /husky_velocity_controller/angular/z/max_velocity: 2.0
 * /husky_velocity_controller/base_frame_id: base_link
 * /husky_velocity_controller/cmd_vel_timeout: 0.25
 * /husky_velocity_controller/enable_odom_tf: False
 * /husky_velocity_controller/estimate_velocity_from_position: False
 * /husky_velocity_controller/left_wheel: ['front_left_whee...
 * /husky_velocity_controller/linear/x/has_acceleration_limits: True
 * /husky_velocity_controller/linear/x/has_velocity_limits: True
 * /husky_velocity_controller/linear/x/max_acceleration: 3.0
 * /husky_velocity_controller/linear/x/max_velocity: 1.0
 * /husky_velocity_controller/pose_covariance_diagonal: [0.001, 0.001, 0....
 * /husky_velocity_controller/publish_rate: 50
 * /husky_velocity_controller/right_wheel: ['front_right_whe...
 * /husky_velocity_controller/twist_covariance_diagonal: [0.001, 0.001, 0....
 * /husky_velocity_controller/type: diff_drive_contro...
 * /husky_velocity_controller/velocity_rolling_window_size: 2
 * /husky_velocity_controller/wheel_radius_multiplier: 1.0
 * /husky_velocity_controller/wheel_separation_multiplier: 1.875
 * /joy_teleop/joy_node/autorepeat_rate: 20
 * /joy_teleop/joy_node/deadzone: 0.1
 * /joy_teleop/joy_node/dev: /dev/input/ps4
 * /joy_teleop/teleop_twist_joy/axis_angular: 0
 * /joy_teleop/teleop_twist_joy/axis_linear: 1
 * /joy_teleop/teleop_twist_joy/enable_button: 4
 * /joy_teleop/teleop_twist_joy/enable_turbo_button: 5
 * /joy_teleop/teleop_twist_joy/scale_angular: 1.4
 * /joy_teleop/teleop_twist_joy/scale_linear: 0.4
 * /joy_teleop/teleop_twist_joy/scale_linear_turbo: 2.0
 * /robot_description: <?xml version="1....
 * /rosdistro: noetic
 * /rosversion: 1.15.9
 * /twist_mux/locks: [{'name': 'e_stop...
 * /twist_mux/topics: [{'name': 'joy', ...
 * /use_sim_time: True

NODES
  /
    base_controller_spawner (controller_manager/spawner)
    ekf_localization (robot_localization/ekf_localization_node)
    gazebo (gazebo_ros/gzserver)
    gazebo_gui (gazebo_ros/gzclient)
    robot_state_publisher (robot_state_publisher/robot_state_publisher)
    spawn_husky_model (gazebo_ros/spawn_model)
    twist_marker_server (interactive_marker_twist_server/marker_server)
    twist_mux (twist_mux/twist_mux)
  /joy_teleop/
    joy_node (joy/joy_node)
    teleop_twist_joy (teleop_twist_joy/teleop_node)

ROS_MASTER_URI=http://localhost:11311

process[gazebo-1]: started with pid [31087]
process[gazebo_gui-2]: started with pid [31092]
process[base_controller_spawner-3]: started with pid [31095]
ERROR: cannot launch node of type [robot_localization/ekf_localization_node]: robot_localization
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/ubuntu/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
ERROR: cannot launch node of type [interactive_marker_twist_server/marker_server]: interactive_marker_twist_server
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/ubuntu/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
process[robot_state_publisher-6]: started with pid [31098]
ERROR: cannot launch node of type [twist_mux/twist_mux]: twist_mux
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/ubuntu/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
ERROR: cannot launch node of type [joy/joy_node]: joy
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/ubuntu/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
ERROR: cannot launch node of type [teleop_twist_joy/teleop_node]: teleop_twist_joy
ROS path [0]=/opt/ros/noetic/share/ros
ROS path [1]=/home/ubuntu/catkin_ws/src
ROS path [2]=/opt/ros/noetic/share
process[spawn_husky_model-10]: started with pid [31099]
[ERROR] [1611536359.218983933]: Failed to build tree: child link [base_laser_mount] of joint [laser_mount_joint] not found
[robot_state_publisher-6] process has died [pid 31098, exit code 1, cmd /opt/ros/noetic/lib/robot_state_publisher/robot_state_publisher __name:=robot_state_publisher __log:=/root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/robot_state_publisher-6.log].
log file: /root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/robot_state_publisher-6*.log
[ INFO] [1611536360.402585265]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1611536360.407477778]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
[ INFO] [1611536360.584057835]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1611536360.589816492]: waitForService: Service [/gazebo_gui/set_physics_properties] has not been advertised, waiting...
[ INFO] [1611536360.753414765]: waitForService: Service [/gazebo/set_physics_properties] is now available.
Aborted (core dumped)
[gazebo_gui-2] process has died [pid 31092, exit code 134, cmd /opt/ros/noetic/lib/gazebo_ros/gzclient __name:=gazebo_gui __log:=/root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/gazebo_gui-2.log].
log file: /root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/gazebo_gui-2*.log
Error [parser_urdf.cc:3193] Unable to call parseURDF on robot model
Error [parser.cc:488] parse as old deprecated model file failed.
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/impl/tcpros_service.py", line 522, in call
    responses = transport.receive_once()
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/impl/tcpros_base.py", line 737, in receive_once
    self.stat_bytes += recv_buff(sock, b, p.buff_size)
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/impl/tcpros_base.py", line 109, in recv_buff
    raise TransportTerminated("unable to receive data from sender, check sender's logs for details")
rospy.exceptions.TransportTerminated: unable to receive data from sender, check sender's logs for details

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/catkin_ws/devel/lib/controller_manager/spawner", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/ubuntu/catkin_ws/src/ros_control/controller_manager/scripts/spawner", line 212, in <module>
    if __name__ == '__main__': main()
  File "/home/ubuntu/catkin_ws/src/ros_control/controller_manager/scripts/spawner", line 190, in main
    resp = load_controller(name)
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/impl/tcpros_service.py", line 442, in __call__
    return self.call(*args, **kwds)
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/impl/tcpros_service.py", line 532, in call
    raise ServiceException("transport error completing service call: %s"%(str(e)))
rospy.service.ServiceException: transport error completing service call: unable to receive data from sender, check sender's logs for details
[WARN] [1611536361.900845, 1.054000]: Controller Spawner error while taking down controllers: unable to connect to service: [Errno 111] Connection refused
[base_controller_spawner-3] process has died [pid 31095, exit code 1, cmd /home/ubuntu/catkin_ws/devel/lib/controller_manager/spawner husky_joint_publisher husky_velocity_controller __name:=base_controller_spawner __log:=/root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/base_controller_spawner-3.log].
log file: /root/.ros/log/6ae6a5e4-5e74-11eb-9a3b-0de85a64961c/base_controller_spawner-3*.log
^C[spawn_husky_mo

The noetic branch is still being worked-on and hasn't been officially released yet.  Several of Husky's third-party dependencies have not yet been updated for Noetic.  And several files & scripts within the Husky repo still use older Kinetic/Melodic era formats (e.g. Python 2 scripts that need to be updated to Python 3).

The noetic branch is still being worked-on and hasn't been officially released yet.  Several of Husky's third-party dependencies have not yet been updated for Noetic.  And several files & scripts within the Husky repo still use older Kinetic/Melodic era formats (e.g. Python 2 scripts that need to be updated to Python 3).

Got it. Thank you.

Got it. Thank you.

Hello,
So, when will the official noetic branch will be released?
Thank you.

We don't have an "official" release date targeted.  We're hoping to have all of our in-house testing on the physical robot done by the end of the summer.
For now, the husky_gazebo package in the noetic-devel branch is usable in Noetic if you need  to use the simulation environment (which is what this issue was originally asking about).


Add turn movements

We don't need all of this before merging, but here's the plan so far:

[x] Rename Movement -> Turn (road level), add TurnMovement (lane level)
[x] Calculate TurnMovements for degenerate (2 road) intersections
[ ] Calculate movements for IntersectionKind::Connections with more than two roads.
[ ] Do some default allocations for arbitrarily complex intersections.
[ ] Add TurnKind to determine what kind of lane markings the TurnMovements get.
[x] Render "turn guide" lane markings for "turn" turns.
[ ] Render ordinary lane markings for "continuation" turns (ideally, reusing the normal logic).

This is making some good progress towards lane level movements. In fact, some movements are calculated and drawn! I added the movement centrelines in post, the left edge of the movements are being drawn:

We need angled road ends, #95, to draw these markings properly.

Really cool to see this!
Not that I'm likely to play with the JOSM side soon, but is BudgieInWA/JOSM2Streets still up-to-date, or are there new rendering goodies corresponding to this?

The JOSM2Streets build embeds StreetNetwork.jar, which in turn embeds the rust lib. If the osm2streets java classes haven't changed their API, then you can build your own StreetNetwork.jar and replace the copy in the JOSM2Streets repo before building. You'd need to do that for these changes, I haven't pushed up the new JAR yet.

Hi, is this still being considered?

I don't think Ben or I have had time to work on this, so not anytime soon. Are you interested in picking it up?


Merge spectra

We can reuse the algorithms from Hecklib present in CombineProfileSpectra and CombineCentroidSpectra.

Fixed by allowing the use of mzdata.


proposal: add httputil.TCPKeepAliveListener

Currently there's no easy way for users to recreate the behavior
present in http.ListenAndServeTLS, short of copying the
tcpKeepAliveListener out of the net/http package. As a refresher, that's this:
func (srv *Server) ListenAndServeTLS(certFile, keyFile string) error {
	addr := srv.Addr
	if addr == "" {
		addr = ":https"
	}

	ln, err := net.Listen("tcp", addr)
	if err != nil {
		return err
	}

	defer ln.Close()

	return srv.ServeTLS(tcpKeepAliveListener{ln.(*net.TCPListener)}, certFile, keyFile)
}

Making that package public would make it easy for people to mirror the behavior in that function. In my case, I like to open a socket, log a message, and then start the server, as the server blocks until shutdown.
It also seems like a lot of people are trying to copy it, scan the results here:
https://github.com/search?q=tcpKeepAliveListener+language%3Ago&ref=simplesearch&type=Code&utf8=✓
Two questions:

We can't load it in net/http because that would involve an import cycle. Is a copy okay?
the keep-alive period is hard coded to 3 minutes. Should we allow users to configure this? The zero value can conceivably be valid.

Just checking in here to see, with #23459 being closed, if this can move forward or be discussed further.

Seems like #23459 only added a default keepalive for connections created with net.Dial(er). If we wanted to obviate this issue in a similar way, we'd need to do the analogous thing for net.Listen and friends. Am I missing something?

Yeah, we could do this by default for Listen too, but then we should add a way to disable it for people using https://golang.org/pkg/net/#ListenConfig by adding a KeepAlive field to ListenConfig like the Dialer has: https://golang.org/pkg/net/#Dialer.KeepAlive
@cespare, you want to do that?

@bradfitz sure, will do.

@cespare sorry to barge in, but I took the liberty of giving this a try at #31242. I'd be greatful if you could take a look at it and see if it's anything like what you had in mind.
If you already had a CL in the works somewhere, just let me know and I'll retract mine.

@costela thanks!

I just stumbled upon this, I think it would be advisable, for uniformity, to use the same duration internally as the one used by Dialer (https://golang.org/src/net/dial.go#L427).
I'm not saying the value needs to be necessarily 15s (although that was debated a while back and agreed upon, see #23459), but they should be the same value.
@cespare @bradfitz WDYT? should I open a followup issue?

@CAFxX yeah, open a new issue.
I'd vote for doing 15s for both, for the reasons you outlined on #23459.

This was proposed and put on hold and then committed without the proposal being approved.
Are we OK with this API?

The new field in ListenConfig has the same name, type, and default as in Dialer, so approving proposal.

FYI, the new patch triggers this bug: #31449


Fixing link to Grant-AzureRmSnapshotAccess documentation

Currently linked to wrong page

@SofianeMahdjoubi,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@SofianeMahdjoubi : Thanks for your contribution to the Azure documentation! The author, @ramankumarlive, has been notified to review your proposed change.

@SofianeMahdjoubi I'm sorry the response took so long - the article you submitted a change to is no longer in the doc set, so I'm closing this PR.


bug fix on polyfun

put back the correct version of polyfun, with some additional bug fix.
remaining problem:

Too high mem requirement, need to generate mwe
for some reason munged_sumstat cannot take gz file, contrary to provided script and example on polyfun github

Amanda will be looking into these two and also provide feedback on the SOSrized module

It is verified that the issue of unable to read txt.gz sumstat is caused by the container. However, it is uncleared what exactly cause the issue. The next step of figuring this out is to look into the actual script to see what went wrong.


Set the mass

hello, on box2d how to set the mass of an object? even if i set the gravity to 1000, the simulation is still slow. thanks.

Hi,
you set the density of the object and the mass is calculated by box2d.
When you create the body you do something like the fixtureDef.density here:
final fixtureDef = FixtureDef();
fixtureDef.setUserData(this); // To be able to determine object in collision
fixtureDef.shape = shape;
fixtureDef.density = 1.0;

final bodyDef = BodyDef();
bodyDef.type = BodyType.DYNAMIC;
this.body = world.createBody(bodyDef)
  ..createFixtureFromFixtureDef(fixtureDef);

But it shouldn't be slow with the normal density, so this might not be the solution.
Is the simulation lagging or is it just slow?

thanks. i fix it already, i just found the settings.dart on the box2d_flame package and I set the maxTranslation from 2 to 100

test


SA1142ReferToTupleElementsByName slowing down build.

Analyzed code contains no tuples.

I need to update the lightup layer to support IOperation analyzers.


[Bug]: Polybar terminates after a monitor is disconnected

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
Launch Polybar for all connected monitors. After disconnecting and reconnecting any monitor, all Polybar processes will terminate with the following output:
notice: Received signal(15): Terminated
notice: Termination signal received, shutting down...

Expected behavior
Polybar should keep running after disconnect & reconnected.
Actual behavior
All Polybar processes close cleanly. I tried setting screenchange-reload = false and monitor-strict = false but neither helped
Window Manager and Version
BSPWM  0.9.10
Linux Distribution
EndeavourOS
Polybar version
polybar 3.6.3-87-gfc423c09

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -O3 -DNDEBUG -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override  -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override

Additional Context / Screenshots
No response

notice: Received signal(15): Terminated

Something on your system is sending a SIGTERM signal (number 15) to polybar. That's why it is shutting down.
Doesn't look like polybar is doing anything wrong.

I noticed I'm launching polybar using the following snippet in an autorandr postswitch:
# Terminate already running bar instances
killall -q polybar

# Wait until the processes have been shut down
while pgrep -u $UID -x polybar >/dev/null; do sleep 1; done

polybar --reload top -l info &>> log.txt&

I've just realized what's happening. This runs once my monitor is reconnected, which causes polybar to close, but for some reason, the last line doesn't relaunch polybar even though I can see its output in the log file, which doesn't indicate any errors:
NORMAL RUN ------------------------
polybar|notice:  Parsing config file: /home/eric/.config/polybar/config.ini
polybar|info:  Environment var ${MONITOR} is undefined, using defined fallback value ""
polybar|info:  Loaded monitor DisplayPort-0 (2560x1440+0+0)
polybar|info:  Configured DPI = 96x96
polybar|info:  Bar geometry: 2560x24+0+0; Borders: 0,0,0,0
polybar|notice:  Loading module 'bspwm' of type 'internal/bspwm'
polybar|notice:  Loaded 1 modules
polybar|info:  Starting application
polybar|info:  Starting module/bspwm
polybar|info:  Entering event loop (thread-id=1)
polybar|info:  module/bspwm: Parsing socket data: MDisplayPort-0:o1:o2:O3:f4:f5:f6:f7:f8:o9:f10:LT:TT:G
polybar|notice:  Loaded font "Hack Nerd Font Mono:pixelsize=19" (name=Hack Nerd Font Mono, offset=4, file=/usr/share/fonts/TTF/Hack Regular Nerd Font Complete Mono.ttf)
polybar|info:  Bar window: 0x2400001
polybar|info:  Successfully restacked bar window
polybar|info:  Disabling tray manager (reason: missing `tray-position`)
polybar|info:  module/bspwm: Rebuilding cache
polybar|info:  Redrawing bar window
polybar|notice:  Received signal(15): Terminated
polybar|info:  Eventloop finished
polybar|notice:  Termination signal received, shutting down...
polybar|info:  module/bspwm: Disconnecting from socket
polybar|info:  module/bspwm: Stopping
polybar|info:  Deconstruction of module/bspwm took 0 ms.
polybar|info:  Waiting for spawned processes to end
polybar|info:  Reached end of application...


Add build instructions for 64-bit Raspbian

Closes #3872

This should be updated with the instructions that include whatever comes out of #3870 before merging.

So, we don't currently use -fPIC on gravitron so that would be a change there @kulibali. I don't think we need for all aarch64. Is gravitron not aarch64?

I haven't been able to find a way to detect Raspbian from cmake or the shell -- still trying to figure out how.

@kulibali I personally think it would be fine to have build instructions that say "hey for X, you need to use Y" and leave the raspbian64 at that.

OK, I have updated #3949 to not try to change the pic flag, so the instructions should say to use make libs pic_flag=-fPIC and make configure pic_flag=-fPIC.

@kulibali so pic_flag=-fPIC isn't needed on the build command?

@SeanTAllen correct; the build flags are baked into makefiles by make configure, and make build calls make on those makefiles.


Build error

Am I doing something wrong?
xargo build --release --example blinky
   Compiling blue-pill v0.1.0 (file:///home/grayshade/blue-pill)
error: linking with `arm-none-eabi-ld` failed: exit code: 1
  |
  = note: "arm-none-eabi-ld" "-L" "/home/grayshade/.xargo/lib/rustlib/thumbv7m-none-eabi/lib" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.aligned0-d85e69f32a001b7247982de9cdc16ee3.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.bare_metal0-ceb19f83b9d1a417c53fc10e067f36c4.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.blinky0-4a074f58195296a925d077a0b1de6b95.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.blue_pill0-e0100c0169d57470faeb6a12630c98d9.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.cast0-65f58988949b80eada6acccdc5021724.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.core0-2ac42e5c3350e49ce90e504514ab12ee.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.cortex_m0-84e15f74949370e151cbd47a201908a5.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.cortex_m_rt0-1119d0553a8e541b9cc052e46f566d5d.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.cortex_m_rtfm0-4de35aca160d7fbef9ab5e536e21a56e.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.embedded_hal0-27a3320987144148e28022ccc4b488d9.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.nb0-2b1664fbce6a938245fe80c1702d386d.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.r00-3e174e1772c6e4b17978b00559c618ef.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.rtfm_core0-8823343cdd451ea85048d97912dad459.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.static_ref0-f771221c23600a6422236b89cd1aeedd.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.stm32f103xx0-5b37a61009b9b23c28877807e94d7b44.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.untagged_option0-b9ab34e49e380d14a8ef45d286f96c0c.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.vcell0-529000b439629f6f3eb3daaf27051.rs.rcgu.o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.volatile_register0-6c42e7cb355346c5c447351b0be08d41.rs.rcgu.o" "-o" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687" "--gc-sections" "-L" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/deps" "-L" "/home/grayshade/blue-pill/target/release/deps" "-L" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/build/blue-pill-40cd7fce81af253c/out" "-L" "/home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/build/cortex-m-rt-085da2a8930e8fcc/out" "-L" "/home/grayshade/.xargo/lib/rustlib/thumbv7m-none-eabi/lib" "-Bstatic" "/home/grayshade/.xargo/lib/rustlib/thumbv7m-none-eabi/lib/libcompiler_builtins-5e3db6aa2fee9b71.rlib" "-Tlink.x" "-Bdynamic"
  = note: /home/grayshade/blue-pill/target/thumbv7m-none-eabi/release/examples/blinky-9fb6fa70bf8cc687.stm32f103xx0-5b37a61009b9b23c28877807e94d7b44.rs.rcgu.o: In function `WWDG':
          stm32f103xx0-5b37a61009b9b23c28877807e94d7b44.rs:(.text+0x0): undefined reference to `DEFAULT_HANDLER'

This is on Arch Linux with arm-none-eabi-ld 2.91.

Works with 2017-12-02.

I thought this was fixed already. There was a small window (1 week?) of nightlies with this problem. cf. rust-lang/rust#46543. Can't check a recent nightly atm but I have nightly-2017-12-14 and this works fine. Does this happen with a recent nightly?

You're right, sorry. I tried searching https://github.com/rust-lang/rust/ for DEFAULT_HANDLER, but somehow missed that issue. It's working in the latest nightly.


Github Action to build app when sending PR

Is your feature request related to a problem? Please describe.
integrate github action in order to avoid app breakj after PR merge
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

can i do this???? please respond

actually i want to work on this please assign me this @Suryansh1720001

@DevMehta1206
I'm assigning you this task for GSSoC'23. You can reach out to me on LinkedIn through this link or follow me on GitHub. Feel free to connect with me regarding this app.

Thank you, I will do that.
On Tue, Jun 6, 2023 at 11:43 AM Suryansh Prajapati @.***>
wrote:

@DevMehta1206 https://github.com/DevMehta1206
I'm assigning you this task for GSSoC'23. You can reach out to me on
LinkedIn https://www.linkedin.com/in/itssuryansh/ through this link or
follow me on GitHub https://github.com/Suryansh1720001. Feel free to
connect with me regarding this app.
—
Reply to this email directly, view it on GitHub
https://github.com/Suryansh1720001/Taaveez/issues/55#issuecomment-1577976972,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4QNQCOGS5DNDPCVGYBDN6TXJ3DA7ANCNFSM6AAAAAAYZL5FIE
.
You are receiving this because you commented.Message ID:
@.***>


no cookie-parser dependency causes TypeError

TypeError: Cannot read property 'uppyAuthToken' of undefined     at ...node_modules/uppy-server/lib/uppy.js:114:36
https://github.com/transloadit/uppy-server/blob/master/src/uppy.js#L108 should have a fallback if cookies is undefined on the req object. And/or documentation should be made to make it clear

@kylerberry Aye! I think it might be better to not even use cookies at all, and we can send this as part of the header or response. I'll work on this.
Thank you for reporting! 🙂

I have made the use of cookie-parser internal to uppy, so any server using uppy-server doesn't have to require cookie-parser. I am sticking with cookie-parser because it serves as an "out of the box" storage, and no additional implementation is required on the client to make it work.

@ifedapoolarewaju works for me. Thanks! 🌮

closing this, as it has been fixed here


🚩🚩🚩🚩🚩 ✨👉Add the option for zones to behave as an independent monitor. 👈✨🚩🚩🚩🚩🚩

Description of the new feature / enhancement
It would be something similar to what this program does: https://www.ishadow.com/
But it should actually behave like a single monitor, even appearing in the Windows display settings. I believe that this would increase compatibility with other applications.
Currently, both Facy Zones and VDM have somewhat similar settings, but they do not behave completely like a single monitor, which means that they do not work in many applications.
Scenario when this would be used?
The big problem here is full screen. Applications that use full screen cannot recognize the zones and open on the entire screen. For example: Videos on YouTube, or any other application that uses full screen.
However, there are many nuances between just fixing the full screen problem and dividing the zones as if they were individual monitors. I believe that the latter option would be a more robust approach.
Thanks in advance!
And thank you for opening this space so that users can request improvements.
Supporting information
No response

/dup #279


fix: uppercase Discovery.MDNS.enabled in default config

Fixes https://github.com/ipfs-shipyard/ipfs-desktop/issues/1631

@lidel do you think we should have ipfs desktop check for the incorrect key in the config, and remove it where it finds it?

Good question. Right now we only control the defaults applied on clean install.
There is a need to have some generic way of migrating go-ipfs configs of existing users for things like ConnMgr limits, so to make this and future changes easier, I've added migrateConfig function () which checks revision and applies one-time migration, if needed.
@rafaelramalho19 @olizilla mind reviewing my changes?

Merging to unblock #1638


testutil: call flag.Parse in TestMain

Because this test code is using ssntp, which uses glog, you
must call flag.Parse prior to using ssntp.
Signed-off-by: Kristen Carlson Accardi<EMAIL_ADDRESS>

Coverage decreased (-0.02%) to 64.721% when pulling cdd5887b77c72aa18276a6d361dd5be184bda03c on kaccardi:topic/flag-parse into 0749a39a152cafa1d3ba5b0b7562ae342116b5b1 on 01org:master.

Is there a runtime panic without this?

@tpepper IIRC, I think your logs are just corrupted.  The logs are generated but you get an error message.


Add a 404 Error Page

If no books are found, instead of a blank page add an error page.

hello @jatiinyadav  i would like to take this issue.
is there any design you want or what should i design?

You can add an illustration and write some text or something related to the project.


Error testing serilaization-dot

Hi I faced the following error during a mvn clean install. The setup is JDK 1.8 on Windows 7 x64.
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running net.automatalib.serialization.dot.DOTSerializationTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.648 s <<< FAILURE! - in net.automatalib.serialization.dot.DOTSerializationTest
[ERROR] testRegularExport(net.automatalib.serialization.dot.DOTSerializationTest)  Time elapsed: 0.087 s  <<< FAILURE!
java.lang.AssertionError:
expected [digraph g {

        s0 [shape="circle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="circle" label="2"];
        s0 -> s1 [label="a / 1"];
        s1 -> s2 [label="b / 2"];
        s2 -> s0 [label="c / 3"];

__start0 [label="" shape="none" width="0" height="0"];
__start0 -> s0;

}
] but found [digraph g {

        s0 [shape="circle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="circle" label="2"];
        s0 -> s1 [label="a / 1"];
        s1 -> s2 [label="b / 2"];
        s2 -> s0 [label="c / 3"];

__start0 [label="" shape="none" width="0" height="0"];
__start0 -> s0;

}
]
        at net.automatalib.serialization.dot.DOTSerializationTest.checkDOTOutput(DOTSerializationTest.java:96)
        at net.automatalib.serialization.dot.DOTSerializationTest.testRegularExport(DOTSerializationTest.java:59)

[ERROR] testVisualizationHelper(net.automatalib.serialization.dot.DOTSerializationTest)  Time elapsed: 0.014 s  <<< FAILURE!
java.lang.AssertionError:
expected [digraph g {
// this is a preamble

        s0 [shape="doublecircle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="doublecircle" label="2"];
        s3 [shape="circle" label="3"];
        s4 [shape="doublecircle" label="4"];
        s5 [shape="circle" label="5"];
        s6 [shape="doublecircle" label="6"];
        s7 [shape="circle" label="7"];
        s8 [shape="doublecircle" label="8"];
        s9 [shape="circle" label="9"];
        s10 [shape="doublecircle" label="10"];
        s0 -> s1 [color="red" label="null"];
        s1 -> s2 [color="red" label="null"];
        s2 -> s3 [color="red" label="null"];
        s3 -> s4 [color="red" label="null"];
        s4 -> s5 [color="red" label="null"];
        s5 -> s6 [color="red" label="null"];
        s6 -> s7 [color="red" label="null"];
        s7 -> s8 [color="red" label="null"];
        s8 -> s9 [color="red" label="null"];
        s9 -> s10 [color="red" label="null"];
        s10 -> s0 [color="red" label="null"];

// this is a postamble

}
] but found [digraph g {
// this is a preamble

        s0 [shape="doublecircle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="doublecircle" label="2"];
        s3 [shape="circle" label="3"];
        s4 [shape="doublecircle" label="4"];
        s5 [shape="circle" label="5"];
        s6 [shape="doublecircle" label="6"];
        s7 [shape="circle" label="7"];
        s8 [shape="doublecircle" label="8"];
        s9 [shape="circle" label="9"];
        s10 [shape="doublecircle" label="10"];
        s0 -> s1 [color="red" label="null"];
        s1 -> s2 [color="red" label="null"];
        s2 -> s3 [color="red" label="null"];
        s3 -> s4 [color="red" label="null"];
        s4 -> s5 [color="red" label="null"];
        s5 -> s6 [color="red" label="null"];
        s6 -> s7 [color="red" label="null"];
        s7 -> s8 [color="red" label="null"];
        s8 -> s9 [color="red" label="null"];
        s9 -> s10 [color="red" label="null"];
        s10 -> s0 [color="red" label="null"];

// this is a postamble

}
]
        at net.automatalib.serialization.dot.DOTSerializationTest.checkDOTOutput(DOTSerializationTest.java:96)
        at net.automatalib.serialization.dot.DOTSerializationTest.testVisualizationHelper(DOTSerializationTest.java:82)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   DOTSerializationTest.testRegularExport:59->checkDOTOutput:96 expected [digraph g {

        s0 [shape="circle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="circle" label="2"];
        s0 -> s1 [label="a / 1"];
        s1 -> s2 [label="b / 2"];
        s2 -> s0 [label="c / 3"];

__start0 [label="" shape="none" width="0" height="0"];
__start0 -> s0;

}
] but found [digraph g {

        s0 [shape="circle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="circle" label="2"];
        s0 -> s1 [label="a / 1"];
        s1 -> s2 [label="b / 2"];
        s2 -> s0 [label="c / 3"];

__start0 [label="" shape="none" width="0" height="0"];
__start0 -> s0;

}
]
[ERROR]   DOTSerializationTest.testVisualizationHelper:82->checkDOTOutput:96 expected [digraph g {
// this is a preamble

        s0 [shape="doublecircle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="doublecircle" label="2"];
        s3 [shape="circle" label="3"];
        s4 [shape="doublecircle" label="4"];
        s5 [shape="circle" label="5"];
        s6 [shape="doublecircle" label="6"];
        s7 [shape="circle" label="7"];
        s8 [shape="doublecircle" label="8"];
        s9 [shape="circle" label="9"];
        s10 [shape="doublecircle" label="10"];
        s0 -> s1 [color="red" label="null"];
        s1 -> s2 [color="red" label="null"];
        s2 -> s3 [color="red" label="null"];
        s3 -> s4 [color="red" label="null"];
        s4 -> s5 [color="red" label="null"];
        s5 -> s6 [color="red" label="null"];
        s6 -> s7 [color="red" label="null"];
        s7 -> s8 [color="red" label="null"];
        s8 -> s9 [color="red" label="null"];
        s9 -> s10 [color="red" label="null"];
        s10 -> s0 [color="red" label="null"];

// this is a postamble

}
] but found [digraph g {
// this is a preamble

        s0 [shape="doublecircle" label="0"];
        s1 [shape="circle" label="1"];
        s2 [shape="doublecircle" label="2"];
        s3 [shape="circle" label="3"];
        s4 [shape="doublecircle" label="4"];
        s5 [shape="circle" label="5"];
        s6 [shape="doublecircle" label="6"];
        s7 [shape="circle" label="7"];
        s8 [shape="doublecircle" label="8"];
        s9 [shape="circle" label="9"];
        s10 [shape="doublecircle" label="10"];
        s0 -> s1 [color="red" label="null"];
        s1 -> s2 [color="red" label="null"];
        s2 -> s3 [color="red" label="null"];
        s3 -> s4 [color="red" label="null"];
        s4 -> s5 [color="red" label="null"];
        s5 -> s6 [color="red" label="null"];
        s6 -> s7 [color="red" label="null"];
        s7 -> s8 [color="red" label="null"];
        s8 -> s9 [color="red" label="null"];
        s9 -> s10 [color="red" label="null"];
        s10 -> s0 [color="red" label="null"];

// this is a postamble

}
]
[INFO]
[ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] AutomataLib ........................................ SUCCESS [  1.144 s]
[INFO] AutomataLib :: Build Parent ........................ SUCCESS [  0.023 s]
[INFO] AutomataLib :: Commons ............................. SUCCESS [  0.031 s]
[INFO] AutomataLib :: Commons :: Utilities ................ SUCCESS [  6.547 s]
[INFO] AutomataLib :: API ................................. SUCCESS [  5.936 s]
[INFO] AutomataLib :: Adapters ............................ SUCCESS [  0.025 s]
[INFO] AutomataLib :: Adapters :: BRICS ................... SUCCESS [  2.485 s]
[INFO] AutomataLib :: Commons :: Smart Collections ........ SUCCESS [  1.834 s]
[INFO] AutomataLib :: Core ................................ SUCCESS [  7.390 s]
[INFO] AutomataLib :: Utilities ........................... SUCCESS [  8.460 s]
[INFO] AutomataLib :: Incremental ......................... SUCCESS [  2.516 s]
[INFO] AutomataLib :: Serialization ....................... SUCCESS [  0.035 s]
[INFO] AutomataLib :: Serialization :: ETF ................ SUCCESS [  1.877 s]
[INFO] AutomataLib :: Serialization :: FSM ................ SUCCESS [  1.912 s]
[INFO] AutomataLib :: Model Checking ...................... SUCCESS [  0.028 s]
[INFO] AutomataLib :: Model Checking :: LTSmin ............ SUCCESS [  2.445 s]
[INFO] AutomataLib :: Serialization :: Core ............... SUCCESS [  0.361 s]
[INFO] AutomataLib :: Serialization :: AUT ................ SUCCESS [  1.911 s]
[INFO] AutomataLib :: Serialization :: DOT ................ FAILURE [  1.707 s]
[INFO] AutomataLib :: Serialization :: LearnLibV2 ......... SKIPPED
[INFO] AutomataLib :: Serialization :: SAF ................ SKIPPED
[INFO] AutomataLib :: Serialization :: TAF ................ SKIPPED
[INFO] AutomataLib :: Visualization ....................... SKIPPED
[INFO] AutomataLib :: Visualization :: DOT Visualizer ..... SKIPPED
[INFO] AutomataLib :: Visualization :: JUNG Visualizer .... SKIPPED
[INFO] AutomataLib :: Distribution ........................ SKIPPED
[INFO] AutomataLib :: Archetypes .......................... SKIPPED
[INFO] AutomataLib :: Archetypes :: Basic ................. SKIPPED
[INFO] AutomataLib :: Archetypes :: Complete .............. SKIPPED
[INFO] AutomataLib :: Build Tools ......................... SKIPPED
[INFO] AutomataLib :: Examples ............................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 47.118 s
[INFO] Finished at: 2018-07-10T13:54:30+02:00
[INFO] Final Memory: 54M/1028M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on project automata-serialization-dot: There are test failures.
[ERROR]
[ERROR] Please refer to C:\eclipse\workspace\automatalib\serialization\dot\target\surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :automata-serialization-dot

From the looks of your terminal output, the difference seems to be quite subtle. It could the handling of newlines (\r\n vs \n) on Windows or do you have any special language configured?
Could you maybe try to debug the DOTSerializationTest, and tell me what the actual difference between the two values is right before the violating check? (Any IDE with TestNG support should be able to this).

You're absolutely right.
dotWriter.toString() has \n.
expectedWriter.toString() has \r\n.

Great, thanks for the info. We will look into this. At this point I'm not sure yet, if this is an issue with the test or the way, the serializer works.
For now, if you're just interested in building the latest AutomataLib artifacts, you could run mvn clean install -DskipTests or use the public snapshot artifacts

@omarzd, could you maybe try to build https://github.com/mtf90/automatalib/tree/platformFixes? If this works for you, I can merge the changes in the main repo.

@omarzd did you have the chance to test my branch?

@mtf90 I just did. It gives the same error.

@omarzd Hm, that is weird. I set up AppVeyor to have continuous integration on Windows platforms and merged the changes from my branch. As you can see, the build succeeds.
However, I did have to enable git's autocrlf (so that the test files committed with \n are checked out with \r\n newlines). I assume you use the same configuration, because in your initial feedback you said, that the expectedWriter (which is reading the file) contained \r\n. Do the test files (e.g. serialization/dot/src/test/resources/graph.dot) have correct newlines if you open them in an arbitrary editor?

@mtf90 It looks like you merged the fix. I just set my git using git config --global core.autocrlf true and compiled again and it passed the tests. Maybe the git config should be mentioned in the README.
Thank you

@omarzd 3c1a0c5 added a .gitattributes file which should automatically take care of correct, platform dependent newlines conversion, so you shouldn't need to manually configure anything for Automatalib. Although AppVeyor VMs still seem to require manual configuration via core.autocrlf, I checked at least one Windows box where everything worked out-of-the-box.


Name conflict between 'filter' and 'where'

type Mutation {
  updateNote(input: MutateNoteInput!, where: UpdateNoteFilter): Note!
}

We have been using filter in GraphQL CRUD Java and encountered this conflict, where and filter function the same.
where sounds more SQL specific, can be replaced with filter in GraphQL CRUD spec.
IMO, a delete should not require an input argument name, it should be filter.
type Mutation {
    deleteNote(input: MutateNoteInput!): Note
}

Suggested type defination:
type Mutation {
    deleteNote(filter: UpdateNoteFilter!): Note
}

cc: @wtrocki @machi1990 @rareddy

IMO, a delete should not require an input argument name, it should be filter.
type Mutation {
    deleteNote(input: MutateNoteInput!): Note
}

Suggested type defination:
type Mutation {
    deleteNote(filter: UpdateNoteFilter!): Note
}

cc: @wtrocki @machi1990 @rareddy

+1. This makes total sense to me.
/cc @craicoverflow for additional insights.

Makes sense to me also, input makes more sense when inserting data. I guess it was used because it is a mutation.
It would be great if you could copy this issue to https://github.com/graphqlcrud/spec, where it can be discussed in a wider context as there are other contributors who may be interested in this discussion.

It would be great if you could copy this issue to https://github.com/graphqlcrud/spec, where it can be discussed in a wider context as there are other contributors who may be interested in this discussion.

+100.


Sentinal blade add to model / code

Problem: Entity doesn't have / drop the Sentinal blade.
Possible solution: Add it to the model (@Johnny1857), add dropping that item to the source code (@mp3skater)
Image:

added code for drop

solved


Matrix eWiseApply implemented, but not declared in base

The two variants have been implemented in every backend, but not declared in base:

eWiseApply([out] Matrix, [in] Matrix, [in] Matrix, [in] Monoid, ...)
eWiseApply([out] Matrix, [in] Matrix, [in] Matrix, [in] Operator, ...)

In order to have a user-friendly interface for all the grb APIs, it would be interesting to declare these variants in base headers.
It would then appear in the official documentation here.
RC eWiseApply(
	Matrix< OutputType, backend > &C,
	const Matrix< InputType1, backend > &A,
	const Matrix< InputType2, backend > &B,
	const Monoid &mulmono,
	const Phase phase = EXECUTE,
	const typename std::enable_if< !grb::is_object< OutputType >::value &&
		!grb::is_object< InputType1 >::value &&
		!grb::is_object< InputType2 >::value &&
		grb::is_monoid< Monoid >::value,
	void >::type * const = nullptr
)

RC eWiseApply(
	Matrix< OutputType, backend > &C,
	const Matrix< InputType1, backend > &A,
	const Matrix< InputType2, backend > &B,
	const Operator &op,
	const Phase phase = EXECUTE,
	const typename std::enable_if< !grb::is_object< OutputType >::value &&
		!grb::is_object< InputType1 >::value &&
		!grb::is_object< InputType2 >::value &&
		grb::is_operator< Operator >::value,
	void >::type * const = nullptr
)

Fix merged into develop. Many thanks for the contribution!


ipv6calc: Update SHA

Upstream seems to have overwritten the tarball therefore changing the
SHA sum.

Hope that's okay @nckx

Seems legit: upstream timestamps are newer than my last commit, and the old tarball is still cached on my Hydra.
Thanks!


Draft: Templated MD arrays

PR Summary
This is a prototype for "templated MD", that is the reduction of code of the type
PORTABLE_FUNCTION PortableMDArray(T *data, int nx1) noexcept
      : pdata_(data), nx1_(nx1), nx2_(1), nx3_(1), nx4_(1), nx5_(1), nx6_(1) {}
  PORTABLE_FUNCTION
  PortableMDArray(T *data, int nx2, int nx1) noexcept
      : pdata_(data), nx1_(nx1), nx2_(nx2), nx3_(1), nx4_(1), nx5_(1), nx6_(1) {
  }
  PORTABLE_FUNCTION
  PortableMDArray(T *data, int nx3, int nx2, int nx1) noexcept
      : pdata_(data), nx1_(nx1), nx2_(nx2), nx3_(nx3), nx4_(1), nx5_(1),
        nx6_(1) {}

To
  template <typename... NXs>
  PORTABLE_FUNCTION PortableMDArray(T *p, NXs... nxs) noexcept
      : PortableMDArray(p, nx_arr(nxs...), sizeof...(NXs)) {}

The single-value dimension variables int nxN_ have been replaced with a staticly sized container std::array<size_t, MAXDIM> nxs_. Also added PortableMDArray::rank_ member to avoid some reevaluations, though I'm not sure it's necessary.
Currently WIP, so documentation is wanting and a few function names/namespaces are silly/inconsistent/gibberish. I know there can be some reluctance about this coding style, so I wanted to get a "at least compiles" version up and gauge interest in iterating on it. (Actually passes a few tests! but haven't tried spiner with this yet).
It was working fine, why change it?

Update code to more modern style
Code is easier to maintain and diagnose
Allows for forward planning when C++ standards are updated
No change in down-facing API
For developers, the code is easier to read/glance

What are the downsides?

Some extra boilerplate to handle C++14's constrains on variadic programming (e.g. no std::apply(), no std::tuple, no fold expressions). C++14 can be "recursion heavy" in this regard, which may degrade performance.
API not "explicit" w.r.t. index ordering
(possibly) Longer compile times
For downstream users, code or errors passing through/originating in expanded template types can be agitating

Any suggestions, comments, questions welcome! @jonahm-LANL @chadmeyer @dholladay00 @jhp-lanl @jdolence
PR Checklist

[ ] Any changes to code are appropriately documented.
[ ] Code is formatted.
[ ] Install test passes.
[ ] Docs build.
[ ] If preparing for a new release, update the version in cmake.

I've made some changes to push a lot of the indexing/building functions into the object. I don't know that I love the result, which lead to the elimination of some constexpr initialization (not that it couldnt be done, just saved time to get a working code).
One question to ask is how much time should PortableMDArray devote to reconstructing internal layout configuration data - in particular strides. These are the offset widths associated with a particlar dimensional spec, eg.
// ordering based on what MDArray is doing
dims = {NT, NZ, NY, NX};
strides = {NZ * NY * NX, NY * NX, NX, 1};

The options are:

at each compute_index call, recompute the strides. This obviously costs some FLOPS but strides are simple to compute and GPU compute is cheap. Further, because the rank is known at this point, the stride data only needs to go up to rank, rather than compute/store values up to MAXDIM
(current commit) at each construction or reshaping, recompute the strides. This is the "natural" path but does introduce more data to move around, to a first approximation doubling the data that PortableMDArray needs to move from between contexts. Contra to (1), this array needs MAXDIM storage which is likely going to be mostly dead weight.

I've made some changes to push a lot of the indexing/building functions into the object. I don't know that I love the result, which lead to the elimination of some constexpr initialization (not that it couldnt be done, just saved time to get a working code).
One question to ask is how much time should PortableMDArray devote to reconstructing internal layout configuration data - in particular strides. These are the offset widths associated with a particlar dimensional spec, eg.
// ordering based on what MDArray is doing
dims = {NT, NZ, NY, NX};
strides = {NZ * NY * NX, NY * NX, NX, 1};

The options are:
1. at each `compute_index` call, recompute the strides. This obviously costs some FLOPS but strides are simple to compute and GPU compute is cheap. Further, because the rank is known at this point, the stride data only needs to go up to `rank`, rather than compute/store values up to `MAXDIM`

2. (current commit) at each construction or reshaping, recompute the strides. This is the "natural" path but does introduce more data to move around, to a first approximation doubling the data that `PortableMDArray` needs to move from between contexts. Contra to (1), this array needs `MAXDIM` storage which is likely going to be mostly dead weight.

I don't know the answer to this a priori. I'm not married to either option. Which leads to the cleaner code? Probably 2? And do we see a performance hit in a simple test case?

I don't know the answer to this a priori. I'm not married to either option. Which leads to the cleaner code? Probably 2? And do we see a performance hit in a simple test case?

Would be work considering the context that PortableMDArray is used in. Does it reshape often, does it get move on/off device frequently, ect. (2.) would be "best" for host, since it avoids recomputation, but (1.) may be better for device since it would minimize data transfer (tho also it's like 48 bytes extra so probably over-optimizing here).
I've included a simple test with the PR. As originally there wasn't very much being tested directly with poc we may need to add some more for checking these details. I glanced over spiner tests for ideas but most of what is there looks more numerics based.

Yeah fair questions:

Does it reshape often?

No, almost never.

does it get move on/off device frequently

Also no.

(2.) would be "best" for host, since it avoids recomputation, but (1.) may be better for device since it would minimize data transfer (tho also it's like 48 bytes extra so probably over-optimizing here).

Like you said, 48 bytes is basically nothing, so I lean towards (2).

Previously we recalculated at every access it seems. It seems like the number of adds will be the same and the number of multiplies saved will only be noticeable with high rank arrays. Performance data for ranks 2-6 would helpful in this case.

The more I think about this the more I think we should recompute the strides. Even so, I'd like to see performance differences. Integer operations can be noticeable on GPUs so pre-computed may be more performant, but a larger object may use more registers. There are a lot of competing factors so data is the best.

now that singularity-eos 1.9.0 release has been cut, I think we should up to c++17 and get this merged in prep for the next release.

now that singularity-eos 1.9.0 release has been cut, I think we should up to c++17 and get this merged in prep for the next release.

I am in favor of moving to C++17 at this time. However, I would prefer to decouple the shift to 17 from this MR. Let's just update the cmake builds to require 17 and then merge other MRs when they are ready.

@jonahm-LANL @dholladay00 I've pushed some benchmarks using catch2, right now just doing index computation through contiguous memory - (i, j, k) to n. I haven't tested this on device yet but I would be interested to see the results. I intend to put in the same benchmarks on random (rather than contiguous) memory.
I can take off Draft and move forward with review if you want to get this in. There are things I'd like to modify and add but there's a danger of code-creep and I don't want to hold up, the PR 'as-is' should be ready to go.

If C++17 gets in before this is merged, then I do want to do another draft - it will make things cleaner and clearer.

@mauneyc-LANL let us know when this is ready for re-review

@mauneyc-LANL what's the status of this?

@jonahm-LANL Code-proper is good but I'm fleshing out the test, benchmarks and making sure they work on other machines. That could be separated into another PR.

Sounds good. I think 1 test on github is enough to merge this, but I'd like at least one. We can do the more broad test set later down the line.

Ah regarding strides, never mind. I see @dholladay00 's point above. I forgot about it.

@mauneyc-LANL I tried updating spiner to use your branch and spiner fails with a huge swath of test failures, including several segfaults. We need to resolve that before this branch can be merged. Branch jmm/test-md-refactor in spiner.

I think the issue is fast_index the original PortableMDArray implementation allows one to "pun" the dimension of the array to smaller sizes. In particular, indexing in 1d always accesses the flat index, which is a useful feature.

OK I fixed the segfault but several tests still failing. @mauneyc-LANL these need to be fixed before merge. That said, the SAP integration effort is a higher priority. If you're ok with it let's punt on this for now.

Need to rethink and reconfigure some of this work. Will try to split out the ideas into more focused PRs.


Update mixer_codegen.sh to generate proto_descriptors

This is needed so that all built-in Mixer adapters have their config protos generated to get ready for out of process use.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [mandarjog]
mixer/OWNERS [mandarjog]
security/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: guptasu, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [mandarjog]
mixer/OWNERS [guptasu,mandarjog]
security/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1dd9fbe9a929ee6b737552ca70b1c50c2ac0caa9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
1dd9fbe9a929ee6b737552ca70b1c50c2ac0caa9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add LGTM.com badges to README.md

The list of badges is almost as impressive as your code quality :wink:

Coverage remained the same at 100.0% when pulling 3503effb0c32c489455407a2f03bf714101219e1 on sjvs:patch-1 into 3704243ef747695e68f03f6e4c5e82ea4571e8d6 on nnadeau:master.

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #572   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          12     12
  Lines         499    499
  Branches       28     28
=====================================
  Hits          499    499

thanks @sjvs


fix: check for existence of pass on paired watch

Summary
canAddCardToWallet now check specifically for the existence of passes that exist on paired device like apple watches if the hasPairedAppleWatch bool is true. If a pass exists on only one of the device and its paired device, then the merchant should show the 'add to apple wallet' button. added new statuses to the enum for debugging/clarity.
Motivation
Apple's guidelines around this have changed.
Testing

[x] I tested this manually
[x] I added automated tests

Documentation
Select one:

[x] I have added relevant documentation for my changes.
[] This PR does not result in any developer-facing changes.

overrides https://github.com/stripe/stripe-react-native/pull/1162

Hi @charliecruzan-stripe
Some questions if that's ok:

What happens if this is set to true, and the device doesn't have a paired watch?
Does this handle the use case where the pass exists on the iPhone but not the paired watch?

Thanks

What happens if this is set to true, and the device doesn't have a paired watch?

The SDK would check the paired devices for the payment pass, and wouldn't find any

Does this handle the use case where the pass exists on the iPhone but not the paired watch?

Yep!


Component library local development with npm link error: "Please add a @NgModule annotation"

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.6
node: 6.9.5
os: win32 x64
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/router: 4.1.3
@angular/cli: 1.0.6
@angular/compiler-cli: 4.1.3
Repro steps.

Create an empty angular-cli project
Create a new Angular component library with at least one module and one component.
Build the component library with ngc -p ./src/tsconfig.lib.json
Register the component library running npm link at the /dist folder of the library.
From the angular-cli project link to the component library: npm link component-library-package-name
Use the component library (import a module and use a component).
Start the angular-cli project with ng serve.
It compiles but it will fail in the browser with the following error: Unexpected value 'MyModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

The log given by the failure.

Chrome error log:
compiler.es5.js:1540 Uncaught Error: Unexpected value 'MyModule' imported by the module 'AppModule'. Please add a @NgModule annotation.
    at syntaxError (http://localhost:4200/vendor.bundle.js:29720:34)
    at http://localhost:4200/vendor.bundle.js:42674:44
    at Array.forEach (native)
    at CompileMetadataResolver.getNgModuleMetadata (http://localhost:4200/vendor.bundle.js:42657:49)
    at JitCompiler._loadModules (http://localhost:4200/vendor.bundle.js:53810:66)
    at JitCompiler._compileModuleAndComponents (http://localhost:4200/vendor.bundle.js:53769:52)
    at JitCompiler.compileModuleAsync (http://localhost:4200/vendor.bundle.js:53731:23)
    at PlatformRef_._bootstrapModuleWithZone (http://localhost:4200/vendor.bundle.js:5731:25)
    at PlatformRef_.bootstrapModule (http://localhost:4200/vendor.bundle.js:5717:21)
    at Object.122 (http://localhost:4200/main.bundle.js:303:124)

Desired functionality.

Mention any other details that might be useful.

You can find information related to using linked libraries here: https://github.com/angular/angular-cli/wiki/stories-linked-library
If you are still having issues, please let us know and if possible provide a sample library or other repro.

@clydin thanks, I still have issues. I believe my component library follows the guidelines from the link you provided.
I attach a zip file with a sample library and an angular-cli application using it which can be used to reproduce the issue:
npmlinktest.zip

Your component library setup looks fine.
The app needs some slight adjustment to ensure that the application's Angular libraries are used and not the library's development dependencies.  This change will essentially mimic the standard behavior of the Angular peer dependencies for a linked library.
In src/tsconfig.app.json, add this:
{
  "compilerOptions": {
    // ...
    "paths": {
      "@angular/*": [
        "../node_modules/@angular/*"
      ]
    }
  }
}

Great. That fixes it. I can see now that it was also explained in the guide you provided earlier but I didn't understand it there.

Adding paths didn't work for me.  I removed linked library's node_modules and that is a pain but fixes the issue.  See this thread

I have the same issue, but only in development, the result of the production compile run works just fine.
"paths": { "@angular/*": ["../node_modules/@angular/*"] } is already set up in my tsconfig.app.json but in development I still get an @NgModule annotation error.
@angular/cli: 1.4.3
node: 6.11.3
os: linux x64
@angular/animations: 4.4.3
@angular/common: 4.4.3
@angular/compiler: 4.4.3
@angular/core: 4.4.3
@angular/forms: 4.4.3
@angular/http: 4.4.3
@angular/platform-browser: 4.4.3
@angular/platform-browser-dynamic: 4.4.3
@angular/router: 4.4.3
@angular/cli: 1.4.3
@angular/compiler-cli: 4.4.3
@ngtools/webpack: 1.7.1
typescript: 2.3.4

deleting the node_modules folder from linking library solved the error for me

I am having the same issue when i try to link a module after running ngc.
The issue goes away if i use "@angular/cli": "1.2.7" but if i use 1.3.0 and up to 1.4.7 i have the issue where i am asked to "Please add a @NgModule annotation." in the console of the browser. any ideas?

@endy21osu Hi Jeff - you can try removing the linked library's node_modules directory (or just @angular/node_modules) - see above.
See also this issue

Hi Matt,
Thanks for the response. If you are talking about the node_modules folder that might be in the dist folder after running ngc then yes I did delete that.  Is there a different one i should be deleting?

It will be the node_modules folder in whatever is the target of your npm link

yes i did delete it. here is what it looks like

@endy21osu, I explained how I fix it here: https://github.com/angular/angular/issues/15763#issuecomment-339343522, I hope it can help you...

Here i tried to elaborate more on the problem: https://github.com/angular/angular-cli/issues/2154#issuecomment-343288877


Mockup

We are going to be designing the website from scratch and I think a good idea is to get up a mockup up for review as soon as possible.
These are some initial thoughts from ticket 391
omgovic

How about a section where some people will say ideas of plugins?

admdh

[THE LOOK] Maybe it would be good idea to introduce PostCSS like something more luxury, more ambitious? Something that make trends and not follows them. For example just look at bootstrap and foundation websites i think they look like 90th now. PostCSS website definitely shouldn't be like that. i think PostCSS website can, or even should be more conceptual.

[THE FEATURES] i think the most important feature of the website should be well organised documentation, easy to use, easy to find. Maybe search page like gulpjs.com has (as it was mentioned before). I think it would be good if there were rules which plugins will be recommended first (for example those which have good documentation) and which last (with bad documentation). maybe plugins statistics.

Based on feedback I've seen so far, I've come up with a rough mockup for today's meeting. It's wording isn't expanded on yet, but you can get the general look and feel we are going for. Progressive & an alchemy theme. Unfortunately, my kids and I have fallen ill today, I was up off and on all night so I will do my best to be active and present at the meeting, but just in case, here's the latest state of the mockup. Artwork is for placement only right now (but I think it works well in how it's placed).

:+1:

Wow, this looks absolutely brilliant. I really like the way you have combined the clean look with an alchemy touch on it. I am sorry to hear you guys got sick, feel better. No worries if you can't make it.

:+1: love it!

Let’s replace “Featured Plugins” title to “Why PostCSS is useful”. So every plugin will be a story why PostCSS can make your development process better.
Also, I think we can move this “Why PostCSS is useful” section upper. It is out main section and it should be visible without scroll.

Old man image is awesome. Is it free?
Maybe we can put it to footer and make little bit more contrast. Also it will allow us to use lazy load for it. We should load first content that is important for user.

Remember that it's a mockup :stuck_out_tongue_winking_eye:
but great point @ai about visibility without scroll that should definitely be taking under consideration when creating the final design visual.

I think the overall theme should follow that of getgrav.org

Can we start breaking this down into smaller parts as mentioned during the meeting? Small PRs for better and faster feedbacks.
#27

Once we have a template and establish overall theme, I think we can.

Hi folks, here's my first version of the sketch.
Waiting for comments :)

This does not take in consideration the recently update brand https://github.com/postcss/brand
Btw, the sentence is too long imo.

Howdy @deannnrie - Thanks for sending in a mockup for postcss.com. As @MoOx mentioned, we do have a very strict brand to follow but I think overall you added in some very good points to take notes from.
Quick feedback

GitHub link is great in main navigation - adds in as a very nice shortcut that a lot of people recognize right away.
Great set of menu-links
Simple landing screen with "Get Started" button.

 We are however going to be creating more issues next week in design development when #27 is resolved. Be on the lookout for label "design needed".

To be honest though, I think "transform your CSS with JS" isn't a good tagline. As a new user, I'll be thinking "Why would I want to do that?  and not look at the project a second time.
I think the tagline should be something that sells the benefit, not how the benefit is achieved.

my tagline proposal do that same as babeljs but for CSS. Because that what it does. PostCSS is a CSS compiler. :D

I don't think that's the right way to go. That just opens up the question "Why do I need a CSS compiler?" (which is what we should answer with the tagline), and if since we don't immediately answer that I think a lot of first timers won't be intrigued by PostCSS.

I get the point but I think the tagline for PostCSS has been there for too long for it to change really. Everyone seems to explain PostCSS this way as well, that sets a mark.

Don't think it's a reason to keep it. Opening an issue for it.

@marcustisater Ok, I just happened to see today, I will follow an approved brand :+1:

That sounds good @deannnrie - looking forward.

@stephenway can we try organize a more approachable way of getting a template and established theme ready. This issue can easily become very confusing for new incomers.

Here is my quick sketch. It needs more work, but the main idea is to show most common use-cases above the fold and also show some examples (or even integrate the REPL, not sure if this is useful on index page tho)

Oooh I like that @okonet, nice!
I'm not sure the REPL makes sense on the index page, I think the "Featured Plugins" section in @stephenway's design makes more sense, since new users won't really know what to try out in there.

@deannnrie we should focused on content, so gid block with one sentence is not a best way.

@mxstbr yes, I also think this way. I'll update it later.
BTW the logo in the masthead could have a subtle CSS glow animation, something like Apple's heart-beat on older Macs.

@okonet Looks good:

We should focused on content. Your image is not so big. But maybe let’s combine this image with a menu to win some vertical space?
The best way to explain PostCSS is a plugins list.
PostCSS is not a Sass to have simple playground. Maybe each plugin in Featured Plugins list can be opened to Playground?

@ai yes, I agree on that. Will update a bit later

Ouh, I see so awesome visual effect with this background.
When user will hover on white PostCSS logo, we can highlight it (blur filter effect) and start rotate two wheels (with letters and signs of the zodiac) in different directions (just cut them from the image to separated layouts and use rotate animation).

Exactly what I was about to say. If I may chip in, I think if the image has no descriptive purpose, it shouldn't be included. I even think there's no reason to have any image on the comp.
That better represents what postcss actually is.
Just my honest opinion.
I saw "the Swiss army knife of css development"  on tutsplus. And i thought that should be paired with "limitless possibilities with JavaScript plugins" like a heading and subheading

@ai oh wow I now see it too, that would look amazing!

@Promhize but do not forget thet design should contain not only a content, but also a emotions.
The question is about compromise. Babel site have no content on first screen (without scrolling) and it is a big mistake. But we can use 300-500px of vertical space for some branding image, because it shows that PostCSS has big community (because it can spent time for this styling effects).

Some text examples for “What PostCSS does exactly” section:

Solve global CSS problemWith PostCSS plugins from CSS Modules you will be free from any selectors conflict automatically. Local reset by postcss-autoreset and all: initial polyfill from cssnext make your CSS more boilet bullet. [Try it in action]
Use future CSS, today If you are use Autoprefixer, you already use PostCSS, because it is just a plugin for PostCSS. With “CSS4” polyfills from other plugin cssnext you can go even further. [Try it in action]
Increase code readability [some words about PreCSS, postcss-sorting] [Try it in action]
Inline Images [some words about postcss-inline-image, postcss-font-magician] [Try it in action]
Lint your CSS With Stylelint you can save your time in  code review by automatically lint main CSS mistakes and code style issues. [some words about doiuse and colorguard] [Try it in action] (different playground with one input and big warnings list screen)
Compress CSS [something about cssnano] [Try it in action] (different plyaground with % of saving bytes)

Techinally we can add Lost to “Make your library aviable in Sass, Less or CSS” and RTLCSS to “More”.

Also every plugin in “What PostCSS does exactly” section has a good icon.

Here is the follow up:

Decreased the height of the header by putting the navigation into the masthead section. My idea here is then you start scrolling, the logo should zoom out and transition into the center of the navigation.
Made the background image more subtle, so it doesn't distract from the text.
Added GitHub Star button (I think this is very recogniziable for OSS projects)
Tried out a better copy (WIP) with logos on different use cases
Made companies logos look more subtle

I didn't have much time to finilize it. So the REPL part is still here but I think it should be done differently (probably just an example? ideas?)
What are you thinking?

I like the new nav (cough) and copy. The logo is a
bit overpowering though...
I'm still not convinced having the REPL there is useful, it just looks like
Sass. It might work with a better default example that showcases cssnext,
autoprefixer etc.
On Tue, 12 Jan 2016 19:07 Andrey Okonetchnikov<EMAIL_ADDRESS>wrote:

Here is the follow up:

Decreased the height of the header by putting the navigation into
the masthead section. My idea here is then you start scrolling, the logo
should zoom out and transition into the center of the navigation.
Made the background image more subtle, so it doesn't distract from
the text.
Added GitHub Star button (I think this is very recogniziable for
OSS projects)
Tried out a better copy (WIP) with logos on different use cases
Made companies logos look more subtle

I didn't have much time to finilize it. So the REPL part is still here but
I think it should be done differently (probably just an example? ideas?)
What are you thinking?
[image: desktop]
https://cloud.githubusercontent.com/assets/11071/12272128/06ce7b14-b95f-11e5-8f35-30f189820884.png
—
Reply to this email directly or view it on GitHub
https://github.com/postcss/postcss.com/issues/4#issuecomment-170997281.

@okonet Looks awesome!

I always like logo in the center. Of course, it will be har to always keep menu symmetrically. But it looks very fresh and brutal.
Yeap, GitHub start widget is good adition. It gives us more starts and show that it is open source project “in a pictures”.
We can’t have so simple “Try it in action” section, because there is no one PostCSS. Maybe we should have a [Try it in action] button for every item in “Features” section.
I think Plugins search on main page is useful.

There is only one loss for me: previous masthead was more “powerful” :). I remember that I told to fouced on content :). But anyway project title and tagline is not a real content for me. So maybe we can return image contrast? Also we can more logo little it down to have zodiac signs wheel on the image inside a screen.

@okonet Looks great!

Also I very want to share our mockups in Twitter. But we need to fix Companies section first.
Current list:

Google
WordPress
Taobao or Alibaba
webpack

Should we open a issue to collect all our users?

For purposes of this thread, that should be enough for the mockup, but that sounds like a good idea @ai

Update to my version. More content, more complete. I think the missing element is visuals, driving a personal connection to the users. As we define the content strategy I think this will start to show because people see value in differentiation and rich media. I did not include any code examples because I agree that the plugins are where new users will see the value in using PostCSS.
With the brand being established, I think it's important to build up in people's minds the main color version of the logo so that they will have the recall when they see it in the black or white versions elsewhere. Our website has to be a key player in that.

@stephenway

Community photos in footer is good. Technologies really should be about human. Also it will show PostCSS popularity “in a picture”.
I prefer @okonet header, because it medieval engravings is more close to PostCSS spirit. Also they are much fresh.
Chat and Twitter links should be upper, because they are more important.
We can add Live examples. But not a global one, just add a button under every plugin.

@ai

If you have any more photos that might help from conferences, etc. Or I could come up with a collage of what I can find so far.
So we have this one there is also the philosopher's stone, and the line quality on this one is really brilliant.
Got it.
Easy enough.

@stephenway

We should make chat link as a text. Like “Support”. It is hard to understand what you will get under chat icon.
Like widget is better, because it brings us more stars and show open source nature more simplier.
Why we need this brush strokes masks?
There is no difference between text fields and buttons.
Yeap, this Basilicae Pholosophicae engraving is not about alchemy. But seems like alchemy was not so popular in engravings, so we have no good image for it.

@ai

Changed to "Support", I agree that does communicate better.
Added star button with the statistic, same as the babel site. Also moved the twitter link down with it.
I thought the brush strokes added personality, but I have hidden them in this iteration so you can see the difference.
Solid buttons now
While it is factual and more inline with alchemy, it doesn't seem to stand out as much. I'll be on the lookout for more options that work with alchemy and stand out at the same time. Thoughts?

Hi folks,I'm working on the second version, look my wireframe

@stephenway looks nice :)

@deannnrie I think design should be always based on real data. You should always put real content on first iteration, because your decision must be based on content.

@ai I will make soon.

@deannnrie Also, the final design should based on the color version of the logo. It's not an established brand yet, so we need to build it up in it's unique original version. Thanks for jumping in with us.
@ai @marcustisater What is the timeline for this project? I can continue with a mobile version and a secondary page layout or should we move on a decision so we can assign smaller tasks to those who are willing to help out in design?

@stephenway Right now I wait for third iteration of @okonet design to compare your mockup styles.
But we have much more important problem. We need to select different font in logotype, because Franklin Gothic Book is not a free font, so it can’t be used in open source project.

@stephenway I understand. I still do not understand the contents of where to get it :)

@deannnrie this is why design is not about images ;). If you can’t get content, developers will not be able too, and your shinny design will look bad in real world.

Here is my update that includes:

More "power" in mastehead
Removed REPL section
Added "Installation" section. I even think there is enough place for more highlights.
Proper logos for "Companies using PostCSS" section
Better top navigation with icons

@okonet

Could you add button “Try it out” under every item in “Can be done with PostCSS” section? It will open a REPL section with only this plugins.
New mastehead looks awesome (don’™ remind me about me words about content based design :D ).
Icons in header is useful to make attention to Support (we will replace it to Support, because we use Gitter). Also they good to keep some sort of symmetry.
Installation section is useful. But we need a tabs to change Gulp to Webpack and Grunt. In future version we will have good wizard to select plugins. So we can miss Installation section if you think it will take too much work.
Should we visually join Plugins and Installation section. But maybe they are joined only in my eyes.

@stephenway @okonet I really want to say thank you. You both make two iteration today.
I will be honest, I prefer @okonet style because it close to PostCSS style. But I think competion is not a good in open source. technically you both have a good ideas. For example, I think community photos from @jonathantneal sketch is very useful. Maybe you can cooperate somehow?

@okonet also what font do you use in mastehead?

@okonet I just found that items in “Can be done with PostCSS” section has a link in title. You planned to open REPL after a click on title? It saves a lot of space and save us from repeating. But I afraid it is not so obviously. Especially, because we should force users to try REPL for every plugins set :).

@ai Always happy to help!
Open source and design are very different in nature, especially early on when it comes to layout. The design process can be a collaborative process, but when it is not, it's best to let each designer follow their vision to see it through. Now that we have a design that is established we can finish content strategy and figure out what the next tasks are to design.
@okonet The brand is very new, so I think it would be beneficial to the organization if we included it on the site in color and in the right typeface, whatever that will be after the next round tomorrow.

@okonet love the latest, your style is great. The offset search bar is
nice, the masthead looks powerful and the whole thing is coherent. And
while the Installation section needs tabs for different build systems, I'd
love to have that there.
I'm not sure about the NavBar and the titles-are-links approach to the
plugins. I don't agree with @ai that adding a button under each plugin is
the way to go though. Maybe make the whole title and paragraph of each
plugin clickable and change to the pointing cursor when hovered over them?
On Wed, 13 Jan 2016 02:45 Stephen Way<EMAIL_ADDRESS>wrote:

@ai https://github.com/ai Always happy to help!
Open source and design are very different in nature, especially early on
when it comes to layout. The design process can be a collaborative process,
but when it is not, it's best to let each designer follow their vision to
see it through. Now that we have a design that is established we can finish
content strategy and figure out what the next tasks are to design.
@okonet https://github.com/okonet The brand is very new, so I think it
would be beneficial to the organization if we included it on the site in
color and in the right typeface, whatever that will be after the next round
tomorrow.
—
Reply to this email directly or view it on GitHub
https://github.com/postcss/postcss.com/issues/4#issuecomment-171126269.

Sorry, it's been a couple of busy days of work for me. I will try summaries my feedback on these submissions as well. Good job everyone, really great to see things going!

I've done one more iteration:

Added explanation section (ala Babel) to make it clear how it works. I think it is also important to communicate.
To compensate of lost space I removed the tagline from masthead. I think it was too much anyway.
Added community section (we can load userpics directly from GitHub — https://github.com/postcss/postcss/graphs/contributors
Experimented with fonts: trying to unify the design language (more ⚗ FTW). Not sure if it's "too much" now. Thoughts?
Added "call to action" buttons at the bottom.
Removed Installation section — I think it should not be on the home page after all. The goal is to communicate (boldly :facepunch:) what's PostCSS and who is behind it. Am I wrong?

Feedback?

:+1:

@okonet How are you addressing the new logo in your design?

@okonet

Alchemy font is hard to read, but it was qute experiment.
Community photos is not so important, so we can put it under companies and maybe “Call to action” buttons.
It is hard to show one example of PostCSS. It has different syntax and tasks. It can be a one source to explain it. What do you think about just open REPL from one item in main usage examples? Or we can show all these 6 usage examples as sections in a horizontal list.

@ai Regarding 3. — my idea was not even make it interactive, but just show a principle: CSS (Scss, Less) in → PostCSS → CSS out. Also I wanted to draw a logical link between PostCSS and plugins.
I changed 1 and 2. Take a look.
@stephenway until https://github.com/postcss/brand/issues/9 is resolved, I don't think this is the issue. But I'm open to it. What's your proposal?

@ai

What do you think about just open REPL from one item in main usage examples?

Yes, that's the idea: by clicking on each example, we should navigate to the REPL page with the pre-loaded examples.

Here is my take from @okonet mockup
Things to be overlooked

I don't like the masthead to be honest, the background-image looks something taken out of the Game of Thrones series and the logo is "connected" to the background-image, that dosen't speak to me.
The navbar has too much opacity and should be reconsidered not being on top of the background-image, the colors should also follow the WCAG practices.
I don't think we in any way should mention Sass/Less/Stylus, it's a way of promoting. We are moving away from it. I know this is pre-content that we can change but I am just putting the word out there.
The logotype you put for MinifyCSS is CSSNano I believe :wink:

I just pointed out things we should reconsider, you did a good job so don't take this as an insult. I would love for this front-page to really be beginner friendly for new visitors.
I'm going to leave this decision over to @ai and @stephenway to decide for final template. I think however we need a bit more retakes on this to really get a perfect mockup.

I don't like the masthead to be honest, the background-image looks something taken out of the Game of Thrones series and the logo is "connected" to the background-image, that dosen't speak to me.

I don't agree, I think the masthead looks amazing. Imagine the wheels turning inside each other, with the logo in the middle, like @ai posted above.

The navbar has too much opacity and should be reconsidered not being on top of the background-image, the colors should also follow the WCAG practices.

:+1: agreed.

The logotype you put for MinifyCSS is CSSNano I believe

The title is always what the plugin does, not the name of the plugin. What does cssnano do? It minifies your CSS. :-) The logo is the correct one.

@marcustisater

Sorry, but this Game of Trones style (Middle Ages) is a style of PostCSS. It is good, because it is fresh looks and separes us from many other modern JS tools. It is bad when your site looks too similar to Babel.
Do not look into text too hard. It is only mockups. Of course, we should try to use real content. But it exactly text is not important.
But you are right, PostCSS is not a Sass. We can't show PostCSS in one example.
 But maybe your are right. Readability is too important.

@okonet I like a visual part of current REPL, but it has two important issue:

Click behavior is too unclear. Some users could think that it is just a plugin page.
We should force users to see that PostCSS is not a one way. That it can be very different.

Maybe really we should make a separated section from every example and put opened REPL there. Main purpose of first page is a explain PostCSS. And having 6 examples explains good, that PostCSS is not a Sass replacement (it is current main misunderstanding).
Guys, what do you think?

My 2 cents: you are trying to do too many things in a single issue. You should iterate via small PRs or not gonna have a website until weeks/months.

The purpose of this issue was to create a first draft mockup and then make it into an full visual design with small PRs.
@stephenway - What is the plan from #27 ?

@okonet if you can come up with some changes from the previous comments and the plugin section that @ai mentioned - I think we are ready to move on. Agreed or do we need more time?
No rush, thanks!

@okonet here is my new thoughts:

Maybe we can set links in menu to white (#fff) to increase a readability. I think it will be enough.
I am thinking that plugin search is not good for “call to action” idea. Page should have only main call to action. The ideal case for us:

user came to page
see a design and masthead and understand that we have too much resources to draw it
read a examples and try REPLs in every one
see a big companies names and understand that PostCSS is production ready
go to setup wizard
So we can add a plugin search to the wizard after all question and our best practices soluton. We will ask user to search other plugins.

So I think we need two buttons in “Call to Action” section: “How to Setup PostCSS” and “Read More” (best article section).

I'll try to update it this weekend.

Sounds good, then we have to move on to the other pages and start with the #15

@okonet - I don't want to stress :sweat_smile: but did you manage to get some updates for the mockup? It does not need to be 100% to perfection.
@stephenway - if you have any spare minutes off this busy week to talk through some OSD, that would be awesome. Talk gitter, take care.

@marcustisater Will do, we will need to get a repo going with the sketch file for @okonet 's design so we can get going on OSD.

Sure, maybe we can collab all together on an OSD "boilerplate" repo on top of that as well.

Make the repo and I'll populate it with my OSD gulp/sketchtool setup :smile:

Maybe you should host it here directly.

@MoOx Could you expand on that idea?

Just push your sketch in this repo since it should be the reflect of this repo result.

The goals of this new repo would be to make a boilerplate for other designers to fork and design off of per page layout. So if we were to use this repo for that purpose, we would end up with 20+ sketch files alongside the website itself. I think approach could hurt the open nature of OSD, mainly because you should be able to fork quickly and iterate without any extra cruft. This might fall in line with your idea to do smaller PRs since we can selectively decide which forks are addressed in the org repo.
@marcustisater Thoughts?

It might sound confusing but in the long run it's a better decision to make another repo rather then pushing everything in here. This would also be a great thing to form out a starter-boilerplate from for others to fork.
We have to make sure that the other repo is well documented and "linked" to this one, also maybe an contributing guideline for designers.

I've made one more attempt to incorporate all feedback I've got so far. I went back to a more subtle masthead section since I think that the previous one drove too much attention away from the content. We would be missing the famous red color of the logo as well.
The "REPL" section should have pre-defined examples so when the user selects one plugin from a list, it should update both parts (or just one). We still need to think about it, since it will not work for stylelint as is. But I think we could display a terminal output on the RHS for this plugin.
There are some rough parts in this mockups I don't quite like but I think if we all agree on a direction, these should be resolved as atomic updates.
I can check in both mockups into the repository (here or a new one?).

@okonet looks great, but we have 2 problems with REPL section:

Each plugin description is most important part on this page. But to put it to buttons, we wrote it is small font.
The main purpose of this page is to show REPL examples to user. But user see only one. He need special interaction to see other.

So maybe we should just add subsection for every plugin without switcher? Anyway latest mockup have small height, so we have a space.

@ai just to make it clear: what do you mean by "add subsection for every plugin without switcher"? Separate pages for each plugin? Can you do a quick paper sketch of what do you mean?

@okonet not separated page, just add a section for every plugin on this page:
## Autoprefixer

Desc

[Input] → [Output]

## CSS Modules

Desc

[Input] → [Output]

I talked briefly with Audrey and we think i'ts best to leave it up with a vote if we should create a new repository or not for the Open Source Deisgn - #96
Good work @okonet - I like the new version and would love to get you're opinion if we should create a new repository or not, maybe you have some past experience with this?
Let's keep #96 short and simple - keep on moving!

@ai got it. Will try it out soon.
@marcustisater thanks. I'll chime up in #96

This is a good start, adjustments can be made on the front-end or later sketches. Great work with the mockups, now we have to move on the layouts.
@okonet - can you upload the mockups to an Zeplin account #98 and to the repo as well? @stephenway boilerplate should be ready in any day.
Moving on to #97

@ai something like this?

@okonet yeap!

I like it too.
Submit PR with sketch files


added Sentry for error handling

Sentry is a tool for real-time error tracking. We can see what kind unexpected error is being thrown through it.
Let's see it is worth!

Where does the Sentry URL configured here live? Is it a company account?

It is under mapzen.com maybe it will be better to have mapzen.js's account. I will close this until we figure out.

Okay thanks.


[refactor/v4] site refactor

Codecov Report

Merging #1166 into refactor/checkout_pref will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           refactor/checkout_pref    #1166   +/-   ##
=======================================================
  Coverage                   26.18%   26.18%
=======================================================
  Files                         336      336
  Lines                       14365    14365
  Branches                     1294     1294
=======================================================
  Hits                         3762     3762
  Misses                      10150    10150
  Partials                      453      453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e85338...3e3022d. Read the comment docs.


[Feature Request] Concept map editor?

Hello! What do you think about adding a simple tile map editor to the Karta module?
I think it can be useful for people. Making maps in a different app is an option too, but after that we need to make map img, and modify map everytime we want to change something.
It's just a loose idea, I believe that it would be hard to implement.
Something like this: https://www.mipui.net/app
Example Map.

I think this would be very hard to implement and there are already a lot of very good apps for this. Therefore I will not implement this in GoNorth since I think exporting and importing the image works good as well and you will have a lot more features in the dedicated map tools than I will ever be able to implement in GoNorth. But thanks a lot for the input anyways! :)


File Explorer

Hi, huge thanks for this amazing open-source lib!
One question: what would be the best way to implement a file tree (on the left side, as in CSB)? Are there any hidden places in this library / any external ready-for-use libraries / examples that can be used for this purpose?
Thanks!

Hey @MaxChu23, glad you're joining Sandpack!
Currently, we don't officially support the FileExplorer component, as this is a working-in-progress feature and we're taking it into account for future releases.
However, as we already have a basic version of FileExplorer working - but we are still not confident enough to export it - I think there is no problem sharing this for you, so here's CodeSandbox where you can take these components and implement them on your own in your application.
https://codesandbox.io/s/file-explorer-1ffn6?file=/src/App.tsx:547-565
Hope it helps you.


[RHOAIENG-8724] - golang: archive/zip: Incorrect handling of certain …

…ZIP files

closing as 2.9 is EOL


Wrong line numbers

I get wrong line numbers by jest (and as thus this addon):

Is this my fault, Jests fault, or this addons fault? Sourcemaps are obviously enabled (I just cloned this repo and opened it in vscode without editing anything besides intentionally failing a test).
Also yes it is the same for a scratch Typescript/Jest project if my only test is a simple assertion like "expect(3).toEqual(4)".
I mean it looks pretty much like its jests fault still I don't get why it fails since sourcemaps (should be) availible.

Appearently this was a mistake with the npm cache. After clearing it works again!

Thanks for coming back with the answer 👍


Lots: cannons, flying, all the assets, new scripts format

See commits

Merged manually and squashed even more


Redis load

In addition to the unit tests, verified that the redis plugin still functions properly (backup a deployment with services - both shared + dedicated, verify apps working, delete those services + their data, verify apps fail, run restore to bosh shared + dedicated, verify apps working again)

LGTM

:shipit: