deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3

Motivation for this change
Bump deno to ~1.5.4~ ~1.6.0~ ~1.6.1~ ~1.6.2~ 1.6.3
Big change in 1.6.0: can now use deno to compile/bundle a binary
It bundles and runs successfully on nix. Since it's using the underlying deno binary it's linked to all the same dependencies and will only work on a nix machine with said pinned dependencies.
I think that's fine for now, this is an early implementation of the feature.
I haven't seen much on a static version. I'm guessing in theory a static rust binary could be created with the 86_64-unknown-linux-musl toolchain but there isn't a pre-compiled rusty_v8 library for it and that'll take ages for us to compile so I'm not planning on trying that until there's a pre-compiled lib file.
$ ./result/bin/deno compile --unstable<EMAIL_ADDRESS>Download<EMAIL_ADDRESS>Check<EMAIL_ADDRESS>Bundle<EMAIL_ADDRESS>Compile<EMAIL_ADDRESS>Emit cat

$ ./cat README.md

# ...

$ ldd cat
	linux-vdso.so.1 (0x00007ffce21ec000)
	libgcc_s.so.1 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libgcc_s.so.1 (0x00007f0a7f613000)
	libc.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libc.so.6 (0x00007f0a7f452000)
	/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/ld-linux-x86-64.so.2 => /nix/store/a3syww9igm49zdzq3ibzw9m8ccvsgxla-glibc-2.32/lib64/ld-linux-x86-64.so.2 (0x00007f0a817b8000)
	libm.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libm.so.6 (0x00007f0a7f30f000)
	libpthread.so.0 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libpthread.so.0 (0x00007f0a7f2ee000)
	libdl.so.2 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libdl.so.2 (0x00007f0a7f2e9000)

ldd ./result/bin/deno
	linux-vdso.so.1 (0x00007ffc60d80000)
	libgcc_s.so.1 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libgcc_s.so.1 (0x00007fa711ede000)
	libc.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libc.so.6 (0x00007fa711d1d000)
	/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/ld-linux-x86-64.so.2 => /nix/store/a3syww9igm49zdzq3ibzw9m8ccvsgxla-glibc-2.32/lib64/ld-linux-x86-64.so.2 (0x00007fa714083000)
	libm.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libm.so.6 (0x00007fa711bda000)
	libpthread.so.0 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libpthread.so.0 (0x00007fa711bb9000)
	libdl.so.2 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libdl.so.2 (0x00007fa711bb4000)

~had to remove ZSH completion in 1.5.4 until it's fixed~ fixed in 1.6.1
    Finished release [optimized] target(s) in 12m 14s
installing
thread 'main' panicked at 'Fatal internal error. Please consider filing a bug report at https://github.com/clap-rs/clap/issues', /build/deno-1.5.4-vendor.tar.gz/clap/src/completions/zsh.rs:407:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5cpmhqpfz2mql2jmmmyjnj1piiilknmj-deno-1.5.4
# ... etc

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS (x86_64)
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

I've removed zsh completion until it's fixed and un-drafting as it's probably going to be a while until the zsh completion is finished

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

Deno 1.6.0 is out: https://github.com/denoland/deno/releases/tag/v1.6.0

Ah I thought I'd updated this pr already.  Let's just check the darwin build before landing.
@ofborg build deno

LGTM, thank you! Let's just check the darwin build before landing.
@ofborg build deno

Actually turns out darwin builders are currently dead, I was thinking this had been fixed but it turns out not. So let's land, thank you! :)

Actually turns out darwin builders are currently dead, I was thinking this had been fixed but it turns out not. So let's land, thank you! :)


No usage of AbstractCommand::requireTransaction()

Protected AbstractCommand::requireTransaction() method should be public or removed.
If it will be public possible usage
$command->requireTransaction()->execute();

Or if not use requireTransaction()
$db->transaction(fn () => $command->execute());

This method has one advantage. If the logger or profiler is configured on the same db connection, the logger and profiler entries will be rolled back along with the failed request if use $db->transaction(fn () => $command->execute());
This method allows you to complete a transaction for a command only.
But I would not use a logger and profiler in production or need to configure them on different storage / db connection. I'm more inclined that this method is redundant, at least until today it was not used and there were no problems (in yii2 the same).

@darkdef @terabytesoftw What do you think? Can we remove requireTransaction() method?


main.css not loaded properly

IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.
Steps to reproduce and a minimal demo of the problem
npm start
open Dev Tools look at console
you will see this error:
Resource interpreted as Stylesheet but transferred with MIME type text/html: "http://localhost:5555/dist/dev/css/main.css?1473806769382"
What steps should we try in your demo to see the problem?
Current behavior
CSS is not loaded at all
Expected/desired behavior
CSS should be loaded
Other information

working as expected now, tnx


#161255243 Allow users to create a profile

What does this PR do?

Allow users to create a profile

Description of Task to be completed?

Write tests for profile endpoints
Add signal to call create a profile once a user is created
Create list profiles serializer
Retrieve single profile by username API endpoint
Update user profile API endpoint
Add versatileimage external library
Add user profile factory
Mute Django post_save signals when creating a profile
Write model unit tests
Add permission to allow owners only to edit profile
Having the following API endpoints working

Method
Endpoint
Functionality

GET
/api/profile/:username
Retrieve user profile

GET
/api/profile/
List user profiles

PUT
/api/profile/:username
Update user profile

How should this be manually tested?
After cloning the repo, cd into it and RUN python manage.py test authors.apps.profile.test
Any background context you want to provide?

The test uses  Factory boy library

What are the relevant pivotal tracker stories?
#161255243

Pull Request Test Coverage Report for Build 92

187 of 190 (98.42%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+29.6%) to 89.25%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

authors/apps/core/permissions.py
5
6
83.33%

authors/apps/profile/api/serializers.py
23
24
95.83%

authors/apps/profile/models.py
24
25
96.0%

Totals

Change from base Build 54:
29.6%

Covered Lines:
357

Relevant Lines:
400

💛  - Coveralls


Rhoaieng 13430

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 98.80240% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@730b0ed). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

src/codeflare_sdk/common/kueue/kueue.py
93.54%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   91.30%
=======================================
  Files           ?       23
  Lines           ?     1299
  Branches        ?        0
=======================================
  Hits            ?     1186
  Misses          ?      113
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


permission issues

it appears tide (The merge robot) from does not have permission to set contexts on this repo https://github.com/GoogleCloudPlatform/oss-test-infra
cc @fejta

/kind oncall-hotlist

Do you mean the tide components running in the OSS prow cluster cannot set contexts on -this- repo, guest-test-infra ? The only permissions we have granted on all of our prow-managed repos is to grant the google-oss-robot merge and comment permissions. If there's something else we should configure, can you explain?

Correct, @google-oss-robot needs write access to the repo in order to update status contexts. We are seeing the following error:
jsonPayload: {
  component: "tide"
  controller: "status-update"
  error: "status code 404 not one of [201], body: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}"
  file: "prow/tide/status.go:328"
  func: "k8s.io/test-infra/prow/tide.(*statusController).setStatuses.func1"
  level: "error"
  msg: "Failed to set status context from "" to "pending"."
  org: "GoogleCloudPlatform"
  pr: 7
  repo: "guest-test-infra"
  sha: "1892aaa2fc554339b68fed4cecf02583eb5c1467"
 }

@google-oss-robot  is an admin on this repo, so I'm not sure the issue here

Just took over oncall today from Ben, let me investigate more and report back


Check for active internet connection

Some state-aware logic which checks if there is an active internet connection. It must also be able to detect a disconnection. Somehow indicate the state in the UI (status bar green/red lamp).
Dispatch event in EventBus so other features (e.g. google calendar) can use this logic.

done


batched consumption of dask.bag

How do you suggest consuming a dask.bag in chunks of N?  My particular use-case is writing/merging cooked output to the database (which I want to be done by a single writer to avoid unnecessary contention at the database).  I want something that iterates over the bag (ideally gathering back whatever results are available for whatever partition) and returns a block/batch that in turn is iterable to get at the items themselves. E.g.
for batch in bag.batch(N):
    e.execute(q, batch)

where e is a sqlalchemy engine, q is a sqlalchemy insert query.
I have hacked together something similar with itertools.islice on top of ipython parallel.
http://ipython.org/ipython-doc/dev/parallel/asyncresult.html#map-results-are-iterable

I should clarify that in the ipython experiment I alluded to when opening this ticket, I batched the promises and then for each batch, synchronously iterated over each element. I think the problem of iterating over the results as they become available (independent of which partition they are in) is harder.

Closing all issues on this fork.  See github.com/ContinuumIO/dask/issues for current issue tracker.


Cannot reference module..topic_arn inside aws_iam_policy_document as value for topic_policy

Description
When creating a totally custom SNS policy using a terraform aws_iam_policy_document as the topic_policy value, terraform throws a Error: Cycle Error if the module output of the module the policy is being attached to is referenced in the SNS topics policy.
The policy works fine if I remove the module reference and hardcode the ARN, however since this behaviour works in other Terraform modules for example https://github.com/terraform-aws-modules/terraform-aws-s3-bucket I figured it would work in this one
Versions

Module version [Required]: 6.0.1

Terraform version: v1.5.7

Provider version(s):

registry.terraform.io/hashicorp/aws v5.43.0

Reproduction Code [Required]
data "aws_iam_policy_document" "sns_policy" {

  statement {
    sid       = "sub"
    effect    = "Allow"
    resources = [
      "${module.sns.topic_arn}/*",
    ]

    actions = [
      "sns:Subscribe"
    ]
    principals {
      type        = "AWS"
      identifiers = ["*"]

    }
  }
}

module "sns" {

  source = "terraform-aws-modules/sns/aws"

  name = "bug-report-sns-topic"

  create_topic_policy     = false
  topic_policy            = data.aws_iam_policy_document.sns_policy.json
}

Steps to reproduce the behaviour:

run terraform init
run terraform validate

Expected behavior

The validation should pass with no errors.
Actual behavior
The validation fails with the following error:
╷
│ Error: Cycle: module.sns.output.topic_arn (expand), data.aws_iam_policy_document.sns_policy, module.sns.var.topic_policy (expand), module.sns.aws_sns_topic.this
│
│
╵

Terminal Output Screenshot(s)

Additional context
I've done similar things with terraform modules for example https://github.com/terraform-aws-modules/terraform-aws-s3-bucket where doing the following:
data "aws_iam_policy_document" "bucket_policy" {

  statement {
    sid    = "AllowReadWriteAccess"
    effect = "Allow"
    resources = [
      module.s3.s3_bucket_arn,
      "${module.s3.s3_bucket_arn}/*"
    ]
    principals {
      type        = "AWS"
      identifiers = ["*"]
    }
    actions = [
      "s3:List*",
      "s3:Get*",
      "s3:DeleteObject"
    ]
  }
}

module "s3" {
  source = "terraform-aws-modules/s3-bucket/aws"

  bucket        = "s3-bucket"
  attach_policy = true
  policy        = data.aws_iam_policy_document.bucket_policy.json

}

you don't need to, we've already done that for you to avoid this exact situation. Just remove the resource = [...] that you have shown above and it should work
https://github.com/terraform-aws-modules/terraform-aws-sns/blob/501f39c4aaef20d366be9665fc2e928b7ff207c3/main.tf#L99


Fill-in-the-blanks is broken?

Hello,
it seems that "fill in the blanks" questions do not work.
Step to reproduce:

Compile the example:
md2anki fill_in_the_blank_example_type_cloze.md
Import to Anki
Study the deck.

For instance, in fill_in_the_blank_example_type_cloze.md, the question about mitochondria should appear as two cards:

Card 1: [...] are the powerhouses of the cell
Card 2: Mitochondria are the [...] of the cell

Instead I get one single question, without the brackets and dots […], and answers do not appear:

About the environment:

I am running Debian unstable
with python 3.12.1
the latest version of md2anki published on PyPI (3.0.20b0)
and Anki 2.1.15.
The example file is the latest one in the git repository.

Thanks for your work!
-- Louis

I just re-read the README, and I noticed that I should have compiled with -anki-model md2anki_type_cloze. Sorry for the noise!
Maybe a quick comment in the README or example might prevent other people from doing the same error?

Ok. So now the question is: is it possible to have a deck of cards that mixes cloze cards with regular cards? With such a deck, either I compile it with default model, and cloze cards do not work, or I compile it with the cloze model, and default cards do not work…

This seems to have already be fixed in #26? Not tested yet…


fix datetme_tz.from_datetime assertion error

Fix a bug where the following leads to an AssertionError:
datetime_cet.from_datetime(datetime_utc.now())

The issue is, that astimezone will try to instantiate a datetime_utc in the CET timezone, which we don't allow. Because of this, if the input datetime to from_datetime is itself an instance of datetime_tz we need to create a regular datetime object in order to change the timezone.
This is strictly not necessary if one were to do:
datetime_utc.from_datetime(datetime_utc.now())

but making the conditional more complex to spare some processing power on a usecase that doesn't make much sense in the first place (why would you reparse a datetime_utc into a datetime_utc?), I opted to not check for this.

@OpsBotPrime merge

Pull request approved for merge by @p-nilsson, rebasing now.

Rebased as e61c946c02fb424e3494ded346263946fc91cf2c, waiting for CI …

CI job :yellow_circle: started.


Some keys are not working, dunno how to debug

Hello, I've finished to assemble on half of my keyboard, but some keys are not working, my question is, all keys only work when the two halfs are assembled together? or each half should work all keys independently?

Hello! Some buttons are responsible for switching layers. When you click on them, it may seem that nothing happens, because... Most keyboard testing programs/sites cannot detect such keystrokes.
Below is a screenshot with these buttons:

right, but all the esc column is not work here on testing, the 5 key and backspace as well, i will try to  verify with a multimeter if all diodes are working, but i dont know what is happening

If the entire column does not work, it may be due to poor contact on the microcontroller pin. Make sure it is well soldered.

When one button in col/row does not work, it is most likely due to poor soldering of the button legs. In second place, the problem may be in the wrong direction of the diode next to the button.
you can write to me in telegram and send me a photo of the board
https://t.me/keyzog

Right, i will verify it, thank you for the help


Improve First Token Latency for multi-GPU projects (by flash attention or alternative)

For multi-GPU solution, we still have challenges for First Token Latency. The breakdown data is shared in offline.
please help add more optimization features (like SDP/Flash Attention etc) to improve the First Token Latency.

mark it


Add support for DRF 3.9

Django REST Framework 3.9.0 was released on October 18th, but DRF-GIS only supports up to 3.8.x. I can take a stab at checking compatibility if that's an unknown.

Already have PRs for this https://github.com/djangonauts/django-rest-framework-gis/pull/173 and https://github.com/djangonauts/django-rest-framework-gis/pull/175

@auvipy @nemesisdesign are we going to make a release with updated drf version or we are waiting for some additional PRs to be merged?

thanks for reminding @imomaliev, will try to that by the end of this week

@nemesisdesign I suggest updating docs that this project doesn't support 2.7 anymore, because I removed travis entry. I will provide code cleanup from python 2 code after release for drf 3.9

@imomaliev done


Fix conflicting C function definitions

Description of changes:
Declare the function signatures instead of importing system definitions. This avoids conflict between our pre-build libraries and the C files that are built on the user machine.
Also remove the gen_c_lib.c file which seems to be dead code.
Resolved issues:
Fixes #1774
Related RFC:
Call-outs:

Thanks for the suggestion @tedinski.
We should probably increase the amount of tests we run with our bundles. I think there is a gap here. We don't test standalone Kani, neither more complicated examples. I'll leave that for a follow up PR.

Testing:

How is this change tested? Existing tests + manually tested on NixOs

Is this a refactor change? No

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Declare the function signatures instead of importing system definitions. This avoids conflict between our pre-build libraries and the C files that are built on the user machine.
Also remove the gen_c_lib.c file which seems to be dead code.


(docs): Add an example of how to pass an empty third argument

I found it difficult to figure out how to pass an empty third argument, I had to change back to master branch for how I am using this action. Figured it out by trial and error, didn't take long but might save others the trouble I had.
I applaud the idea of defaulting to main! Keep it up!

Closing this PR because now I understand more of how this should work.


Discovering composite resources

It has recently come to my attention that most of the discovery values for a resource are now blank, because all resources have been migrated to composite form!  This is probably why discovery functions so poorly in other issues. Much of the metadata currently associated with discovery has been moved into composite file types.  Thus, the searchable fields for discovery need to be re-engineered for these new data types.
The problem with the new format is that there are many "hidden fields" that are not readily accessible to users. For example, there are abstract, method, etc for files.  So, I'm between a rock and a hard place on exposing these in discovery:

Not exposing them lacks precision; there may be resources that the user will not see.
Exposing them in discovery without exposing them on the resource home page confuses users who might have no idea why this particular resource came up in discovery.

@alvacouch - even though other resource types have been migrated to composite resources, all resources, regardless of type had the standard Dublin Core metadata at the resource level. That metadata was preserved in any migrations to composite. So, primary focus for discovery would first be all of the resource-level metadata, followed by aggregation-level metadata - if we can enable that.
Number 1 is only a problem if we create the expectation that discovery should work beyond resource-level metadata.
All metadata for composite resources - both resource-level and aggregation-level are exposed on the resource landing page, so I don't think 2 is a problem except for users who may not know that they need to click on content files to see aggregation-level metadata.

@horsburgh I have already checked that Dublin core metadata is working. The aggregation metadata, however, leaves much to be desired. I have harvested the concept of "variable" from several of the underlying aggregation types. I am also working on a mystery, which is how the file "keywords" become resource-level Dublin-core "subjects" in harvesting. I know this happens because I recently tested it.

@Castronova I am actively working on this and have scheduled a discussion of the issues involved in design for the stakeholder call tomorrow.


The 116th Congress

Ok. So. We just had an election. See #223 and #375 for how we've handled election results for the past two Congress. Yesterday's special elections are being done in #614.
Yesterday's election was for all representatives (incl. delegates) except Puerto Rico's delegate which is a four-year position and this was an off-year, for a total of 440 seats, and the 33 class 1 senators. The House Clerk promises to provide XML data mid November with bioguide IDs provided for all representatives, so we should use that wherever possible to automate this. I think we'll need to gather Senate results manually.
Cribbing from #375, the overall tasks that need to be done are:
As data comes in:

[ ] Incumbents that won reelection: Clone their term but update the dates. Check if Senate state junior/senior rank needs to be updated.
[ ] Legislators that won election to a new seat, e.g. representatives who ran for senate or who changed district number (possibly in PA where the districts were redrawn): Add a term with new information. Senate terms are likely junior rank.
[ ] Incumbents and legislators who ran for a different seat but lost: Run the retire and sweep scripts to move them to the legislators-historical file and clear their committee and social media records.
[ ] Winners who served in Congress previously: Move their record from the legislators-historical file to the legislators-current file and check if any missing metadata can be filled in. Senators are likely junior rank.
[ ] Winners who are new: Add per the new member template. Senators are likely junior rank. We should have all representative bioguide IDs soon but senator bioguide IDs may not be available until they are sworn in.
[ ] Add end dates to all current leadership_roles for Members who are no longer serving.
[ ] Committee assignments must be cleared.
[ ] Photos need to be found for new members.
[ ] Social media accounts can be added for new members.

After January 3:

[ ] Fix start dates to actual swearing in dates if any legislators didn't get sworn in on the first day.
[ ] Bioguide IDs must be filled in when they become available. We have a script to guess IDs. We should know all representative IDs by now but not Senate IDs.
[ ] New leadership roles
[ ] Fill in the inevitable missing data, like office addresses (via the house_contacts.py and senate_contacts.py scripts) and committee membership.

The House clerk has posted unofficial data on the 116th Congress membership:
http://clerk.house.gov/member_info/unofficial-116-member-elect-data.xml
I am going to start a branch for the 116th Congress this weekend.

Hi Josh...
Y'all have been a big help. Not sure what format would be best, but please see the attached, as follows:

New members only for 116th (House/Senate)
Includes Harris NC09, just in case
uses the Dec. 13th House XML, plus known Senator-elects, as keys.
Adds
-- bioguide IDs where known (source: house clerk, previous IDs for Senators where avail)
-- All known social media: twitter, facebook, instagram, youtube. Labels as campaign, official, personal or other
-- Adds opensecrets_id, votesmart_id, fec_ids, cspan_ids, wikipedia_ids, ballotpedia IDs

We have most of the photos, but we use this for machine learning vs public, so don't know clearances for reuse, though nearly all are either CC wiki, or from campaign.
Hope this data is useful. If a better format, LMK what would work. Just CSV
116th.xlsx

Happy New Year and Happy New Congress! Just ran a pull request on the 116th congress and got 0 members. I realize it hasn't started yet, but any idea when we might see data start filling up there? Thanks for all the great work on this.

I've been working on this in #625, which barring any unexpected issues I will merge at noon tomorrow, which is when the 116th Congress begins.

Awesome. Thank you!

I can add FEC IDs to the House freshmen class, if no one else is working on it. cc @JoshData


JDBC Connectivity

Hi Team -
I am trying to dump my dataset into a PostgreSQL and read from it within a Jupyter Notebook. I referred example you provided in your README docs to connect to a database but I am facing difficulty to apply it within a notebook since I am not able to set driver class path. Normally, when I run spark application using "spark-submit" I can point to postgresql driver using runtime argument "driver-class-path" but couldn't find a way to do it through notebook.
FYI, I tried solutions given in various stackoverflow posts like -
os.environ['PYSPARK_SUBMIT_ARGS'] = '--jars <postgredriver.jar> pyspark-shell'
os.environ['PYSPARK_SUBMIT_ARGS'] = '--packages org.postgresql:postgresql:42.1.1 pyspark-shell'
environ['PYSPARK_SUBMIT_ARGS'] = '--driver-class-path <postgredriver.jar> --jars <postgredriver.jar> pyspark-shell'
Could you please help me in getting around this issue.
Thank you.
Best -
Ishan

Hi @IshanDindorkar ,
I think you can take a couple of approaches here:
You can configure the Spark session with the postgreSQL driver and pass it on to Optimus
from pyspark.sql import SparkSession
spark = SparkSession.builder.appName('optimus').getOrCreate()
op= Optimus(spark)

or we expect to release on the next days a way in which you can create Optimus with jars as params.
Hope this help

Hi @argenisleon , thanks for your response. Perhaps, I tried to set config as well while initiating spark session, the way you showed but unfortunately it didn’t worked. For some reason, it keeps failing to detect my driver JAR and throw me error - No suitable driver. I will wait for your release and meantime will keep trying if I could get it working. Appreciate your help. Thank you.
Have a good weekend!

Hi, @IshanDindorkar did it worked for you now. In fact, I am facing the same issue currently. I couldn't able to connect to redshift.

Hi @IshanDindorkar, @niteshnicholas
We are releasing today version 2.2.6. You can check the progress here https://github.com/ironmussa/Optimus/pull/556#pullrequestreview-248220639

@IshanDindorkar @niteshnicholas 2.2.6 is out!

Thank you @argenisleon for giving an update regarding new release. I will use the new released version of library going forward.


Add support for rkyv serialization and deserialization

This is direct port of the implementation within the rkyv crate, which targets an older version of hashbrown.

@bors r+

:pushpin: Commit 3542d10e2b147ad0d0b3045bcb3af821dac8c1f0 has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 3542d10e2b147ad0d0b3045bcb3af821dac8c1f0 with merge cd28d55f205f33fef08eb8c320db33edbd4c5050...

:broken_heart: Test failed - checks-actions

@bors retry

:hourglass: Testing commit 3542d10e2b147ad0d0b3045bcb3af821dac8c1f0 with merge f552bdb4eca07ca892c0a492354b5840bb3110f9...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing f552bdb4eca07ca892c0a492354b5840bb3110f9 to master...


Download option not working

I have also same issue.

Will be doing a release today to resolve this issue. Sorry for the delay

Just tried updating to beta-8 by running npm install mui-datatables --save but seem to still be running into this issue, am I doing something wrong?

Visit: https://wy2rl1nyzl.codesandbox.io/
That is running beta-8
I need some more information. Version of Material-ui, React. Browser etc.

Hey there thanks for responding. I'm quite new to all of this so appreciate any help I can get. Here are some of the package versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>I'm also using Chrome as my browser

@richardjzhang Sure, no problem. Does this fail with any data? Can I see your config provided to mui-datatables?

TableExample.txt
Seems to fail with all the tables I have - I'll have a go at putting some dummy data in because at the moment the data is a prop

@richardjzhang If you ran the following config could you tell me if you still have issues?
const columns = ["Name", "Title", "Location", "Age", "Salary"];

    const data = [
      ["Gabby George", "Business Analyst", "Minneapolis", 30, "$100,000"],
      ["Aiden Lloyd", "Business Consultant", "Dallas", 55, "$200,000"],
      ["Jaden Collins", "Attorney", "Santa Ana", 27, "$500,000"],
      ["Franky Rees", "Business Analyst", "St. Petersburg", 22, "$50,000"],
      ["Aaren Rose", "Business Consultant", "Toledo", 28, "$75,000"],
      ["Blake Duncan", "Business Management Analyst", "San Diego", 65, "$94,000"],
      ["Frankie Parry", "Agency Legal Counsel", "Jacksonville", 71, "$210,000"],
      ["Lane Wilson", "Commercial Specialist", "Omaha", 19, "$65,000"],
      ["Robin Duncan", "Business Analyst", "Los Angeles", 20, "$77,000"],
      ["Mel Brooks", "Business Consultant", "Oklahoma City", 37, "$135,000"],
      ["Harper White", "Attorney", "Pittsburgh", 52, "$420,000"],
      ["Kris Humphrey", "Agency Legal Counsel", "Laredo", 30, "$150,000"],
      ["Frankie Long", "Industrial Analyst", "Austin", 31, "$170,000"],
      ["Brynn Robbins", "Business Analyst", "Norfolk", 22, "$90,000"],
      ["Justice Mann", "Business Consultant", "Chicago", 24, "$133,000"],
      ["Addison Navarro", "Business Management Analyst", "New York", 50, "$295,000"],
      ["Jesse Welch", "Agency Legal Counsel", "Seattle", 28, "$200,000"],
      ["Eli Mejia", "Commercial Specialist", "Long Beach", 65, "$400,000"],
      ["Gene Leblanc", "Industrial Analyst", "Hartford", 34, "$110,000"],
      ["Danny Leon", "Computer Scientist", "Newark", 60, "$220,000"],
      ["Lane Lee", "Corporate Counselor", "Cincinnati", 52, "$180,000"],
      ["Jesse Hall", "Business Analyst", "Baltimore", 44, "$99,000"],
      ["Danni Hudson", "Agency Legal Counsel", "Tampa", 37, "$90,000"],
      ["Terry Macdonald", "Commercial Specialist", "Miami", 39, "$140,000"],
      ["Justice Mccarthy", "Attorney", "Tucson", 26, "$330,000"],
      ["Silver Carey", "Computer Scientist", "Memphis", 47, "$250,000"],
      ["Franky Miles", "Industrial Analyst", "Buffalo", 49, "$190,000"],
      ["Glen Nixon", "Corporate Counselor", "Arlington", 44, "$80,000"],
      ["Gabby Strickland", "Business Process Consultant", "Scottsdale", 26, "$45,000"],
      ["Mason Ray", "Computer Scientist", "San Francisco", 39, "$142,000"]
    ];

    const options = {
      filterType: 'dropdown',
      responsive: 'stacked'
    };

    return (
      <MUIDataTable
        title={"ACME Employee list"}
        data={data}
        columns={columns}
        options={options}
      />
    );

@gregnb seem to still be having the same issue, this is what I have
`class EnhancedTable extends React.Component {
// Overides styling for the table. Overriding font size only at this stage
getMuiTheme = () =>
// eslint-disable-line
createMuiTheme({
overrides: {
MUIDataTableBodyCell: {
root: {
fontSize: '1.5vmin',
padding: 'auto',
fontFamily: "'Proxima Nova', Helvetica, Arial, sans-serif",
},
},
},
});
render() {
const columns = ["Name", "Title", "Location", "Age", "Salary"];
const data = [
  ["Gabby George", "Business Analyst", "Minneapolis", 30, "$100,000"],
  ["Aiden Lloyd", "Business Consultant", "Dallas", 55, "$200,000"],
  ["Jaden Collins", "Attorney", "Santa Ana", 27, "$500,000"],
  ["Franky Rees", "Business Analyst", "St. Petersburg", 22, "$50,000"],
  ["Aaren Rose", "Business Consultant", "Toledo", 28, "$75,000"],
  ["Blake Duncan", "Business Management Analyst", "San Diego", 65, "$94,000"],
  ["Frankie Parry", "Agency Legal Counsel", "Jacksonville", 71, "$210,000"],
  ["Lane Wilson", "Commercial Specialist", "Omaha", 19, "$65,000"],
  ["Robin Duncan", "Business Analyst", "Los Angeles", 20, "$77,000"],
  ["Mel Brooks", "Business Consultant", "Oklahoma City", 37, "$135,000"],
  ["Harper White", "Attorney", "Pittsburgh", 52, "$420,000"],
  ["Kris Humphrey", "Agency Legal Counsel", "Laredo", 30, "$150,000"],
  ["Frankie Long", "Industrial Analyst", "Austin", 31, "$170,000"],
  ["Brynn Robbins", "Business Analyst", "Norfolk", 22, "$90,000"],
  ["Justice Mann", "Business Consultant", "Chicago", 24, "$133,000"],
  ["Addison Navarro", "Business Management Analyst", "New York", 50, "$295,000"],
  ["Jesse Welch", "Agency Legal Counsel", "Seattle", 28, "$200,000"],
  ["Eli Mejia", "Commercial Specialist", "Long Beach", 65, "$400,000"],
  ["Gene Leblanc", "Industrial Analyst", "Hartford", 34, "$110,000"],
  ["Danny Leon", "Computer Scientist", "Newark", 60, "$220,000"],
  ["Lane Lee", "Corporate Counselor", "Cincinnati", 52, "$180,000"],
  ["Jesse Hall", "Business Analyst", "Baltimore", 44, "$99,000"],
  ["Danni Hudson", "Agency Legal Counsel", "Tampa", 37, "$90,000"],
  ["Terry Macdonald", "Commercial Specialist", "Miami", 39, "$140,000"],
  ["Justice Mccarthy", "Attorney", "Tucson", 26, "$330,000"],
  ["Silver Carey", "Computer Scientist", "Memphis", 47, "$250,000"],
  ["Franky Miles", "Industrial Analyst", "Buffalo", 49, "$190,000"],
  ["Glen Nixon", "Corporate Counselor", "Arlington", 44, "$80,000"],
  ["Gabby Strickland", "Business Process Consultant", "Scottsdale", 26, "$45,000"],
  ["Mason Ray", "Computer Scientist", "San Francisco", 39, "$142,000"]
];

const options = {
  filterType: 'dropdown',
  responsive: 'stacked'
};
return (
  <MuiThemeProvider theme={this.getMuiTheme()}>
    <MUIDataTable
      title={"ACME Employee list"}
      data={data}
      columns={columns}
      options={options}
    />
  </MuiThemeProvider>
);

}
}
export default EnhancedTable;`

What is the issue exactly? Can I see a screenshot?

@gregnb after clicking on the 'Download icon' i receive the following console message:
index.js:1 Uncaught TypeError: t.join is not a function
    at index.js:1
    at Array.reduce (<anonymous>)
    at r.handleCSVDownload (index.js:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:100)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:138)
    at Object.invokeGuardedCallback (react-dom.development.js:187)
    at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:201)
    at executeDispatch (react-dom.development.js:461)
    at executeDispatchesInOrder (react-dom.development.js:483)
    at executeDispatchesAndRelease (react-dom.development.js:581)

And the pop up that usually opens for downloading the csv file doesn't happen

@richardjzhang Can you reply back to me with your package.json as well? Is this inside of create-react-app?

  "version": "1.0.0",
  "scripts": {
    "postinstall": "run-p install:client install:server",
    "install:client": "cd src/client && yarn install",
    "install:server": "cd src/server && yarn install",
    "dev": "run-p dev:*",
    "dev:client": "cd src/client && yarn run dev",
    "dev:server": "cd src/server && yarn run dev",
    "build": "run-p build:*",
    "build:client": "cd src/client && yarn run build"
  },
  "dependencies": {
    "@material-ui/core": "^1.2.0",
    "@material-ui/icons": "^1.0.0",
    "mui-datatables": "^2.0.0-beta-8",
    "react-dom": "^16.4.0"
  },
  "devDependencies": {
    "eslint-config-mathspace": "^0.5.4",
    "eslint-config-prettier": "^2.9.0",
    "eslint-plugin-flowtype": "^2.49.3",
    "eslint-plugin-react": "^7.9.1",
    "npm-run-all": "^4.1.3"
  }

@gregnb We were running it inside of create-react-app but have made some significant changes since then.

I created a repo with create-react-app you can clone: https://github.com/gregnb/mui-download-bug
and then
npm install
npm run start

let me know if it works because I'm not getting any issues in Chrome testing

@gregnb very weird, so this one works! I'll look into what might be going wrong on my end and will let you know if I manage to resolve it

@richardjzhang for sure I would love that seems some other people are suffering from this issue but I can't see what it is

Oh man @gregnb I found what the mistake was...
I have two Package JSON files. One for the backend and front end - the latest version of mui-datatables was in the backend. Moving it to the frontend Package JSON file fixed it

@richardjzhang oh wow, well I’m glad you found the issue!


Create several examples for documentation

Isolated Plummer sphere.
Hernquist sphere going around an external NFW halo with movie.
Something that uses a galpy df.
Exponential disk with pynbody surface density profile.

Can combine 2 and 3 and do the live vs. static NFW potential dynamical friction example.

"1.0.7" merge


--shell-escape option

Hello,
i would need an option to set the flag '-shell-escape'.
In Texshop everything works fine when i add the flags described here:
https://stackoverflow.com/questions/28039856/how-do-i-add-the-shell-escape-option-in-texshop
But i cant do that in your ext. Or i dont know how..
greets!

Thanks for the comment, and sorry for the late reply. Currently the extension doesn’t provide this option, but I’ll consider adding it.
Generally, though, I think it’s best to set this kind of options independently of the editor/extension being used — see second paragraph here. For example (with apologies if you already know this), you can always enable --shell-escape by having a file called .latexmkrc in your home directory containing the following line:
set_tex_cmds('--shell-escape %O %S');

(or put the .latexmkrc file in the project folder if you don’t want to enable --shell-escape globally). Then this will work with Nova LaTeX and with any other editor/extension using latexmk. Does this make sense?

Thanks for your quick reply!
Im very new with latex so i just try to figure things out. I red about the .latexmkrc file and i also read that --shell-escape could potentially cause security issues. So i decided to try out another latex template i found on github. (where i dont need this setting)
I didnt know that you can create a .latexmkrc file in projects. Thanks for that information!
Thanks for your help your extension really helped me finalize my project!

Happy to hear that. Thank you!


Data format version

The data format version (mobilitydcatap:dataFormatVersion) is modelled as a rdfs:Literal. In the example it is filled with "DATEX II v3.2". Using Literal may make it difficult to filter the values entered by the various member states, because it also can be filled with, for example "DATEX-II-v3.2" or "DATEXIIv3.2" or even different values.
To overcome this isse, it may be an idea to use a controlled vacabulary for the data format version.
For example the EU Vocabularies include a controlled vocabulary for File type.
A solution option could be to add, for example, DATEX_II_v3_XML and DATEXII_v2_3_XML and other for mobilityDCAT-AP needed filetypes to the File type defined in the EU vocabularies controlled vocabulary and use the SKOS concept instead of the Literal.
Of course, a precondition is that the EU vocabulary for filetype is actively managed and can be adapted quickly enough if filetypes need to be added for mobilityDCAT-AP. Otherwise, maybe an mobilityDCAT-AP controlled vocabulary may be used.

Closed, see solution above.


Persian support

Hi. Is there Persian in the locale list?

Hi @arsalannury the fa locale exists in the locales list but it is used for displaying month and days of week names in Persian and doesn't change the calendar to Jalali, currently, this component only supports the Gregorian Calendar, and I'm working on it to add support for another calendars like Jalali Calendar

please Added Jalali Calendar


Cannot download setting

Extension cannot download my synced setting after providing the token. Results in these errors when trying to sync:
workbench.main.js:238 [Extension Host] HttpError: Not Found
at module.exports.e.exports.then.n.text.then.r (C:\Users\olegc.vscode\extensions\shan.code-settings-sync-3.2.9\out\extension.js:176:50169)
at process._tickCallback (internal/process/next_tick.js:68:7)
t.log @ workbench.main.js:238
workbench.main.js:2365 Sync : Error Logged In Console (Help menu > Toggle Developer Tools).
onDidNotificationChange @ workbench.main.js:2365
workbench.main.js:238 [Extension Host] HttpError: Not Found
at module.exports.e.exports.then.n.text.then.r (C:\Users\olegc.vscode\extensions\shan.code-settings-sync-3.2.9\out\extension.js:176:50169)
at process._tickCallback (internal/process/next_tick.js:68:7)

Cannot upload either. I was just testing this extension out and ran into this error.

This issue appeared for me when I used the account token as the Gist ID. Do not enter anything, just tell it to upload using the shortcut then paste in your token. Then it will give you an ID to use. If you need to find the ID to use for doanload, just open the gist and copy the ID from the URL. See if that helps

That worked. Thank you!

Switched to GIST ID from Token and everything worked.

I wish i could make the documentation or WIKI clearer for the guys. Most of the issues are raised by miss understanding.
I am always open for PR that improve the readme.
Also Public Edit in Github Wiki is enabled. Feel free to improve that. where you think there is confusion.

Thanks, I made a minor edit to the installation as a note. Hopefully that will be more clear


Follow focus as a seperat app

I was wondering if it would be possible to take the part of kwm that enables mouse follow focus in its own app or daemon or is it tied into kwm really deep? I havent looked that deep into the code but its something that i've never figured out how to do and always wanted to have. Sorry this is kind of unrelated and in a deprecated project

Check out https://github.com/koekeishiya/chunkwm. Also note that Kwm is deprecated with chunkwm being its replacement.
chunkwm is based on a plugin architecture and since focus follows mouse is a separate plugin for it, you might choose to only load the focus follows mouse plugin (ffm.so).
Your chunkwm config file would be just this:
chunkc core::plugin_dir /path/to/plugins
chunkc core::load ffm.so

Oooh yeah that would totally be a way to do this. Thank you! :)


Files as optional in validation rules

Applying the permit_empty rule within the validation of a file does not work correctly as it completely ignores the validation if the user uploads a file
$rules['fotos.*'] = [
    'rules' => 'permit_empty|uploaded[field]|max_size[field,500]|is_image[field]',
];

Another method that could also be useful is to restrict the number of files that a user can upload in the case of using multiple files max_files[field, 3] or a minimum of min_files[field, 2]
grettings

Since the value of a file upload HTML field doesn’t exist.
So, 'permit_empty' always return true.

this is not a bug some validations are for $_POST, and some are for $_FILES don`t use them together.
just dont use the uploaded[field] rule if you dont want it to be required

In the user guide, we have separate sections for file uploads related rules.
The idea with the validation rule for max and min number of files sounds good. PRs are welcomed, as always.


Feature Request: ability to choose narrator

Right now audio downloads only with the first narrator in the list.
Even if I try to download a single session with a specific narrator (authorId parameter in the session link), it is still downloads audio with the first narrator from the list of narrators.
Thanks for the tool!

I have attempted to bring this functionality in #32

Hi @premfix
@jasondilworth56 have implemented the functionality. Please install the package from the git repo, as mentioned in the docs.

Install using
pip install git+https://github.com/yashrathi-git/headspace-cli


Vijitha-Sridharrpa challenge code review and update

Updated Sridhar's code and created pull request. Waiting for pull request approval from Vajrang

This got completed


check-tomcat-app-deployment short options

Hi,
You have the same short option -a for "account" and "apps" .
Regards

I corrected this and published the gem 0.0.3 to rubygems.org.  Thanks for catching this issue!


Finalize model documentation

@Glader011235 @cmshobe @gregtucker
This commit is intended to provide a guide to splitting up finalizing the documentation and testing of the remaining model program files.
Crib notes: Make the docstrings look like model 000's. Add tests for each model like those for model 000 in the test folder. Ideally we get 100% coverage for EVERYTHING!
Some recent changes: We no longer use nose. This means that you can't type from nose.tools import assert_raises. Don't freak out you can do import pytest and then pytest.raises(). I've changed this everywhere in the existing tests already so you can take inspiration examples from within terrainbento (but landlab still uses nose). Why did I do this... because nose isn't being maintained and its developers recommend using py.test.
This is what I propose to start:

Me: All Rock/Till models: (800/804, 802, 808, 810, 840, 842, A00, C00)
@cmshobe : Start with 002, 008/00C, 010, 018, 410
@Glader011235 : start with 040, 400, 440, CCC

I'd recommend that you do one or two, and then create a PR in case there is anything else to clarify.
Still to be assigned:
The stochastic ones: 100/104, 102, 108, 110
the VSA ones: 200/204, 202, 208, 210, 300
@gregtucker will claim some of these when he can.
I am almost done getting the Travis/Coveralls CI to work right. 🤞 I'll make a comment when that's done.

FYI @cmshobe @Glader011235 you can commit directly into this repo instead of using a fork (like you do in landlab).
This is because I added you as contributors to the repository.

OK! Travis and Docs are all working. I'm nearly certain Coveralls is working. I'll test it and report back!

status update: I've done the documentation for 002, 008, 010, 018, and 410 (#56) so just need to do the tests next. @kbarnhart can you remind me what 00C is? Is this just some alternative parameterization of 008?

Quick note. @gregtucker currently taking 100/104, 102, 108, 110

current status:
Remaining for tests only:
808, 810, 840, 842, A00, C00 (assigned to me)
ErosionModel (assigned to me)
StochasticErosionModel (assigned to me)
Remaining for Docs and Tests:
100/104, 102, 108, 110 (assigned to @gregtucker)
012 (not yet assigned)
200/204, 202, 208, 210, 300 (not yet assigned)

Another update on the status of remaining models:
All done (nice job everyone!)

000, 002, 008, 018, 040, 400, 410, 440, 800, 802, and C00

Assigned to me:

010 and 410 need small tweaks to permit thresholds to be passed successfully.
End member analytical unit tests for 808, 810, 840, 842, A00, C00
Finalize ErosionModel and StochasticErosionModel tests
Documentation and end member analytical tests for 300

Assigned to @Glader011235

End member analytical tests for 200, 202, 208, 210, 300. Wait until PR #63 is merged and then feel free to start.

Assigned to @gregtucker

Documentation and end member analytical tests for 100, 102, 108, 110. You'll want to update from #63 once its merged.

since nothing is assigned to me (much appreciated!) and I'll be MIA for the
next week, I will plan to finish whatever Rachel has left when she leaves
for Alaska.
On Fri, Jul 13, 2018 at 8:21 AM, Katy Barnhart<EMAIL_ADDRESS>wrote:

Another update on the status of remaining models:
All done (nice job everyone!)

000, 002, 008, 018, 040, 400, 410, 440, 800, 802, and C00

Assigned to me:

010 and 410 need small tweaks to permit thresholds to be passed
successfully.
End member analytical unit tests for 808, 810, 840, 842, A00, C00
Finalize ErosionModel and StochasticErosionModel tests
Documentation and end member analytical tests for 300

Assigned to @Glader011235 https://github.com/Glader011235

End member analytical tests for 200, 202, 208, 210, 300. Wait until
PR #63 https://github.com/TerrainBento/terrainbento/pull/63 is
merged and then feel free to start.

Assigned to @gregtucker https://github.com/gregtucker

Documentation and end member analytical tests for 100, 102, 108,

You'll want to update from #63
https://github.com/TerrainBento/terrainbento/pull/63 once its merged.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TerrainBento/terrainbento/issues/38#issuecomment-404737943,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJBvYE0HRrteoa875pfQdn9h9qGDY4E6ks5uGDxNgaJpZM4UzF1S
.

@cmshobe that is a great plan!


Add support for naming env variables

Hi, I added support for a new config variable that enables the user to name the environment variable its program will receive.
It is especially useful for source=string and for source=entire-payload schemes
[
  {
    "id": "push",
    "execute-command": "bb2mm",
    "command-working-directory": "/tmp",
    "pass-environment-to-command":
    [
      {
        "source": "entire-payload",
        "envname": "PAYLOAD"
      },
      {
        "source": "string",
        "name": "PUSH"
      },
      {
        "source": "string",
        "envname": "MMURL",
        "name": "https://someurl/hooks/somehooktokengeneratedbymm"
      }
    ]
  }
]

will give you nice env variables:

HOOK_PAYLOAD (using the introduced feature)
HOOK_MMURL (using the introduced feature)
HOOK_PUSH

without this feature the obtained vars are:

HOOK_ (it has no name and thus is not named :/ )
HOOK_https://someurl/hooks/somehooktokengeneratedbymm (the name is also the content and thus you won't be able to find this variable without knowing its content first, which kind of defeats the purpose)

I fixed the tests but did not introduce new ones to cover my changes. If you are interested in this PR please let me know so I can update the test suite to add coverage for it. Cheers!

:+1:

I take this for a yes ... Let's do this then :)
I just added tests for the zone of code I modified. Added some tooling scripts to help visually understand which code is tested or not... coverage report

If you are OK with the current state I am ready for a merge. Nothing to add to this particular PR

Could you extract the coverage script into the webhook-contrib repository, since it's platform dependent and not necessary for the core webhook build, and we want to keep this repo as clean as possible :-)
Otherwise, great job :-)

done

Could you just create a PR into development branch, so we can merge it in, we use master as release branch :-)

also done


Failed to customize font-familiy with Chirpy Starter

Checklist

[X] I have read and accepted the contributing guidelines.

How did you create the site?
Generated from chirpy-starter
Describe the bug
I'm building my blog with the Chirpy Starter, and following the documents of Customizing Stylesheet.
After coping the main.scss and create my own variables-hook.scss under the _sass folder of my blog, nothing happened:

The runtime css indicated that the font-family is still the default value:

Steps To Reproduce

Create a new blog with Chirpy Starter
Try to customize blog font-family following Customizing Stylesheet
Run server at localhost with bundle exec jekyll s
View runtime font-family at http://<IP_ADDRESS>:4000/assets/css/jekyll-theme-chirpy.css

Expected Behavior
The runtime css was successfully replaced by variables-hook.scss in user's blog
Environment

Ruby: 3.0.6p216 (2023-03-30 revision 23a532679b) [x86_64-linux]
Jekyll: 4.3.3
Chirpy: 6.5.3

Anything else?
While debuging the reason why user-defined variables does not overwrite pre-definied variables, I have noticed that the order of the variables file in main.scss maybe the culprit:

Pre-defined variables appears before user-definied variables, maybe the variable cannot be overwrite once defined? I know nothing about scss.
After adjusting the order of the variables file, everything works well!

I have made a pull request to fix this issue: #1604

@cotes2020 Why this issue is labeled Invalid?


sendEmail Array to string conversion error

Hi
I am just trying out Bryglen / yii2-sendgrid
And it throws an error 'Array to string conversion' at:
curl_setopt($ch, CURLOPT_POSTFIELDS, $form);
this is because $form=>from is an array
I have made a change in the Yii2 advanced application at:
PasswordResetRequestForm-> sendEmail()
//                ->setFrom([\Yii::$app->params['supportEmail'] => \Yii::$app->name . ' robot'])
->setFrom(\Yii::$app->params['supportEmail']) // not array - fixed
I know this does not allow the alternate name format but I cant find a better option I have reported it to the author Bryglen
but I'm not sure where the fix is best made.
Great work on the Yii2 I have just started using it.

This is not Yii issue.

OK Fair point, thanks for the quick reply.


Application Exception: Forbidden: bot was blocked by the user

This is an issue created automatically by GrammarNazi when an exception was captured.
Date (UTC): 12/4/2020 1:49:45 AM
Exception:
Telegram.Bot.Exceptions.ApiRequestException: Forbidden: bot was blocked by the user
at Telegram.Bot.TelegramBotClient.MakeRequestAsync[TResponse](IRequest`1 request, CancellationToken cancellationToken)
at GrammarNazi.Core.Services.TelegramCommandHandlerService.HandleCommand(Message message) in C:\Users\QIS9\Documents\GitHub\grammar-nazi-bot\GrammarNazi.Core\Services\TelegramCommandHandlerService.cs:line 74
at GrammarNazi.App.HostedServices.TelegramBotHostedService.OnMessageReceived(Object sender, MessageEventArgs messageEvent) in C:\Users\QIS9\Documents\GitHub\grammar-nazi-bot\GrammarNazi.App\HostedServices\TelegramBotHostedService.cs:line 87
at GrammarNazi.App.HostedServices.TelegramBotHostedService.b__8_0(Object obj, MessageEventArgs eventArgs) in C:\Users\QIS9\Documents\GitHub\grammar-nazi-bot\GrammarNazi.App\HostedServices\TelegramBotHostedService.cs:line 58

Seems like we'll need to handle when a user blocks the Telegram bot. Weird... This only could happen when a user blocks the Bot right before getting a correction 🤔


no-build-isolation problem

Hello,
I'm trying to install the packages.
I encoutered the torch problem you are describing in the README and I used the command
pip install --no-build-isolation mamba-ssm
But I still have the same problem. I'm using torch 2.1.2+cu121
And I have the problem : NameError: name 'bare_metal_version' is not defined

you don't have nvcc installed.


Add test case to Hamming that shows the difference between len() and chars().count()

I see this solution a lot
let x = "Hi";
let y = "Yo";

if x.len() == y.len() {
//do something
} else {
//do something else
}

But that's tricky in Rust because all strings are UTF-8 and the number of characters != the length of the string slice.
An example: https://play.rust-lang.org/?gist=b0fb8157fd7903333d9441164e0fffaf&version=stable&backtrace=0
I just saw this pop up in Hamming, so maybe exposing this difference via a test in that problem is a good idea.

In the case of hamming for DNA mutations the UTF-8 issue doesn't really come into play. Do we have any other exercises where we could expose this?

In our current problem set? Not really. Anagrams can do it, but that's going to move much later in the sequence. Maybe in a problem we haven't implemented yet?

Yeah, maybe, though there's nothing obvious in the list: http://exercism.io/languages/rust/contribute
Maybe we need a new exercise that focuses on this explicitly. Go has the same thing.

Since #175 now deals with the difference between bytes and characters, I think the original intent behind this is in fact covered, even if the test was added to a different exercise than Hamming. What say you?

Sounds good.


Not good as w4rh4wk scripts

Description
This software sets up chocolatey and installs thirdparty software without asking if you want that and doesnt have a list of bloatware to uninstall. You just can debloat xbox and msstore. Also why is there an option to install cortana? I want to uninstall that spyware. Dont know if the maintainer really supports debloating of windows ...
Tryed out, doenst helped and doesnt provide an uninstall script - so i reset my windows to get rid of
Reason
N/A
Examples
No response

Okay, you have a lot of good points.

This software sets up chocolatey and installs thirdparty software without asking if you want that and doesnt have a list of bloatware to uninstall.

This caused me trouble too, as for other people, in the develop branch i don't do it automated anymore, and you can enable and disable these Tasks, and of course uninstall chocolatey. (#110)

Also why is there an option to install cortana?

I thought it was a good way to bring back, but even MS doesn't support it now, Cortana is removed by the "Apply Tweaks", I don't leave it on the system.

I want to uninstall that spyware. Dont know if the maintainer really supports debloating of windows ...

If you want someone who is every day spending time on the script, I would like to recommend Chris Titus software, he is doing it in C# library inside Powershell, XAML, and the UI is much more easy to navigate and simple (https://github.com/ChrisTitusTech/winutil).
To be honest, I'm maintaining this to ease the system stress on CPU/RAM and see my system working without any trouble and being the closest to a "minimal" install of Windows.

Tryed out, doenst helped and doesnt provide an uninstall script - so i reset my windows to get rid of

Sorry if this isn't a fully customizable script, i wish i could do that, but I had to do a lot of things from scratch, or maybe a lot of stuff couldn't be as simple as it is right now. Btw, WinForms sucks, and I didn't have the guts to make like Chris' version with Xaml, even because I don't like copying other codes, but instead doing it my way.

I'll remove Cortana from the UI, it's really useless.


run autocmd on dashboard?

Hi,
I just installed dashboard-vim to replace Startify (or to see whether it can do that, because I just realized how much I rely on startify now that it is gone :D). I have not made up my mind yet, but it does seem really awesome; I just kinda miss seeing the recently edited files and opening them by number, but perhaps I can change my workflow. Anyway, that is not what this is about.
Actual Question
Is it possible to run autocmnds on the dashboard? I use Yggdroot/indentline, which is configured to display tabs. This makes the dashboard look ugly, as there are "random" vertical lines where there should be noting at all. While I can manually run IndentLineToggle, I'd prefer to automatically run this when dashboard-vim is started (and ideally when it's closed again so I got my indentation visible in regular text files again).
I tried :echo @% to determine what the buffer is titled (will usually return something like /home/me/.config/nvim/init.vim), but it will return nothing / empty string for the dashboard when opening vim.
Btw., I just tested, and the very same happens when running :Startify, so this doesn't seem to be a bug per se, but it'd still be nice if there was a way to fix this.
Thank you for your help :)

let g:indentLine_fileTypeExclude = ['dashboard']

Thank you!


Improve link handling

Summary

Ensures that if url is not set, the link is not displayed either.
Potentially improves the issue of link disappearing.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions
Not sure since we don't have a reliable way to reproduce this.
Basic testing would be:

Add an element with link and description.
Unselect the element and verify it displays the link when hovering over it
Select the element and remove the link.
Verify the description disappears as well and the element doesn't show link on hovering anymore when unselected.

Fixes #4582 (hopefully)

Not sure if QA makes sense on this since we don't really have steps to reproduce the bug, moving there anyway for now.

👍
At the very least we get confirmation that nothing broke :)

Verified in QA


Predicting a Binding Site (predict.py): TypeError: sequence item 0: expected str instance, numpy.float32 found

OS: Ubuntu 22.04
mamba: 1.5.5
conda: 23.11.0
Hi,
I am trying to use your program to predict binding sites in a protein PDB. when I run
python ~/DeepPocket/predict.py -p 1A9N_frame_0.pdb -c ~/DeepPocket/first_model_fold1_best_test_auc_85001.pth.tar -s ~/DeepPocket/seg0_best_test_IOU_91.pth.tar -r 3

I get the following terminal message:
/home/luis/DeepPocket/rank_pockets.py:87: UserWarning: Implicit dimension choice for softmax has been deprecated. Change the call to include dim=X as an argument.
  all_probs.append(F.softmax(output).detach().cpu())
Traceback (most recent call last):
  File "/home/luis/DeepPocket/predict.py", line 106, in <module>
    fout.write(''.join(confidence_types))
TypeError: sequence item 0: expected str instance, numpy.float32 found

I have tried to circumvent the TypeError by changing line 106 in predict.py from fout.write(''.join(confidence_types)) to fout.write(''.join(str(confidence_types))), but that only led to yet another more cryptic error after prompting the aforementioned python command:
Traceback (most recent call last):
  File "/home/luis/DeepPocket/predict.py", line 122, in <module>
    test(seg_model, seg_eptest, seg_gmaker,device,dx_name, args)
  File "/home/luis/DeepPocket/segment_pockets.py", line 145, in test
    output_pocket_pdb(dx_name+'_pocket'+str(count)+'.pdb',prot_prody,pred_aa)
  File "/home/luis/DeepPocket/segment_pockets.py", line 85, in output_pocket_pdb
    pocket=prot_prody.select(sel_str)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/prody/atomic/atomic.py", line 232, in select
    return SELECT.select(self, selstr, **kwargs)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/prody/atomic/select.py", line 894, in select
    indices = self.getIndices(atoms, selstr, **kwargs)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/prody/atomic/select.py", line 952, in getIndices
    torf = self.getBoolArray(atoms, selstr, **kwargs)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/prody/atomic/select.py", line 1003, in getBoolArray
    parser = self._getParser(selstr)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/prody/atomic/select.py", line 1102, in _getParser
    parser.enablePackrat()
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/pyparsing/util.py", line 265, in _inner
    return fn(*args, **kwargs)
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/pyparsing/core.py", line 1132, in enable_packrat
    ParserElement.packrat_cache = _FifoCache(cache_size_limit)  # type: ignore[assignment]
  File "/home/luis/miniforge3/envs/DeepPocketEnv/lib/python3.9/site-packages/pyparsing/util.py", line 105, in __init__
    keyring = [object()] * size
TypeError: can't multiply sequence by non-int of type 'Forward'

Do you have an idea how to fix these issues?
Cheers Foly

thank you for the fix on the initial error, it seems like your second error seems to be related prody/pyparsing compatibility, maybe this would help: https://github.com/prody/ProDy/issues/1856

Hi,
it does work now, with both these issues fixed.
Maybe it is helpful for future users to provide a YAML file for easy python environment setup. I attached my environment YAML file to this message, which creates (a hopefully working) environment via
mamba env create -n DeepPocketEnv -f DeepPocketEnv.yaml

or instead of mamba, conda and micromamba should also work.
Cheers, Luis
DeepPocketEnv.zip


Issues empty placeholder

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[x] Optimization
[ ] Documentation Update
[ ] Release

Related Tickets & Documents
Closes #544

Added tests?

[ ] yes
[ ] no, because they aren't needed
[x] no, because I need help

Added to documentation?

[ ] readme
[x] no documentation needed

This looks good, just one small indent nitpick.
Also, React Suspense has a new feature coming for loading fallback. It is still Experimental, so I wouldn't suggest adding it now but something to keep in mind.
Thanks so much for the PR!

Done @bdougie!


FontSize enums? e.g. large, small xlarge

[Enter feedback here]
You have the example of setting a fontsize to a double, but where is the example showing how to do it with an enum?? (or whatever)
e.g. myElement.FontSize = fontsizeenum.large;

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76a7b4ff-2889-6a85-aa3f-075ae6c07387
Version Independent ID: 76a7b4ff-2889-6a85-aa3f-075ae6c07387
Content: Fonts in .NET MAUI - .NET MAUI
Content Source: docs/user-interface/fonts.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @gfmoore
Afraid that what we called the named font sizes (e.g. Large, Medium etc.) have been obsoleted. This PR discusses it a little. At the moment, using a double is the recommended approach, and does support responding to accessibility changes on your device.

Thanks for such a quick response. So I guess there's no point using them in the xaml neither. (Don't need a reply to that ;) )
Regards,
Gordon Moore
@.***

On 20 May 2022, 15:45, at 15:45, David Britch @.***> wrote:

Hi @gfmoore
Afraid that what we called the named font sizes (e.g. Large, Medium
etc.) have been obsoleted. This
PR discusses it a little. At
the moment, using a double is the recommended approach, and does
support responding to accessibility changes on your device.
--
Reply to this email directly or view it on GitHub:
https://github.com/dotnet/docs-maui/issues/547#issuecomment-1132991634
You are receiving this because you were mentioned.
Message ID: @.***>


Document release workflow

Description
Changes proposed in this pull request:

Document release workflow

Related issue(s)

See also #98

/test pre-kyma-environment-broker


Silent Mode not working

Hey!
'Silent mode' doesn't seem to be working for me when using "Append to Daily Note". Even if I shut Obsidian down completely it still opens the application and note.
A bug perhaps?

You need to go to the Obsidian extension "Advanced URI" and uncheck "Open file on write". Worked for me.

Yeah, I see. I thought it worked for a moment, but I have the same problem now. Maybe if the "append" function would just edit the markdown file directly and not open Obsidian...

This is a limitation of the Obsidian Advanced URI plugin or to be more precise a limitation of the way daily notes work within Obsidian.
I am working on a general "Append" command which will work as smoothly as possible.


Add machine parsable DCI Lint configuration

The contents are derived from the recommendations
of the INI and are a direct translation of those
into JSON with a specific schema that DCI Lint expects.
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>

Hello @petermetz - thank you for your work here! The team at INI is heads down with KubeCon + CloudNativeCon activities atm and would like to invite you to our next general meeting to chat about this. If you join our mailing list, you will be automatically added to the invite for 9:15 AM PT meetings on alternate Mondays (the next one is on May 17th). If you do not prefer to join the mailing list, I can send you the invite to the meeting if you let me know what email to use. Thanks!

@pritianka Thank you for the info! I signed up to the mailing list and will attend the call on the 17th.

@pritianka Just double checking: After having signed up to the mailing list, my calendar shows the meetings being held on the 10th, 24th, etc, not the 17th. Did the schedule change by any chance?

@petermetz This may help: https://inclusivenaming.org/calendar/ :)

@petermetz This may help: https://inclusivenaming.org/calendar/ :)

@edwarnicke Cheers, that did it indeed. For some reason the only meeting my calendar saw was the OOS workstream, but now I got the full picture, thank you!

I merged this because it's been sitting for so long. Let's talk about moving it at a future date.


Looking forward to the code release

Hi! Thanks for the cool work! Looking forward to the code release!
Kalyani

Awesome work! May I ask when could we expect the code to be released?


Add Adaptive Bitrate Stream Picker to Video Player

What's the problem? (required)
It's helpful to allow users to pick the video quality within a HLS master playlist.
What's the current behavior? (required)
Currently, the Livepeer video player doesn't allow you to pick a video quality.
Describe a possible solution you've considered (optional)
We should automatically detect when there are multiple qualities in the playlist, and display a control to allow users to pick their desired quality.  This control to default to "auto", but give users the option to manually pick the specific quality.  When the bitrate is not "auto", the adaptive bitrate streaming algorithm should be turned off (so the player doesn't automatically switch between qualities).
Additional context (optional)
Here is an example quality picker.

Note for Bounty
To start working on this bounty, you should:

Have a local media player running.  See documentation for the media player.
Make sure the media player is pointing to a test stream instead of a CDN.  You will need to temporarily change the logic here to make it point to a local video source.  Currently, the player talks to the blockchain to get the latest manifest ID.  Instead, you will want to hard-code it for easy testing.
You can use https://bitmovin-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8 for testing.
Make sure your change is also propagated to the chroma player.

Feel free to join the discord room for questions or discussions.

@gitcoinbot https://github.com/livepeer/livepeerjs/pull/191
I'm working on it, gitcoinbot. back off :smirk:

@gitcoinbot the PR is ready #191 , Awaiting Funder's review / approval

Hi @ericxtang mind paying this one out on Gitcoin? @ya7ya sorry about the overly pushy @gitcoinbot, we're working on training it still 🙂

Hey @ericxtang, Ryan from Gitcoin here. Wanted to check in with you on this issue -- do you think you could pay it out on Gitcoin? Feel free to message me if you have any concerns :)

Hey @ericxtang, wanted to follow up here. Do you have any questions with this? Would love to get this taken care of on Gitcoin :)


[$2000] Web - Inconsistently highlighting occurs when multiple mentions are used without spaces.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat.
Type "@ here" multiple times without including spaces.
Observe that all the mentions are highlighted.
Type a user's email ID followed by "@ here" without a space.
Note that the email address is highlighted, but "@ here" is not.

Expected Result:
Consistency is expected, where both cases should either be highlighted or not.
Actual Result:
Multiple use of "@ here" are highlighted, but when using mentions with a user email followed by "@ here," it does not get highlighted.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.33-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/126239a3-a21b-474a-aaee-dc69411e9072
https://github.com/Expensify/App/assets/43996225/a79acc00-d07d-4b56-bbb4-614adba012e8
Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687759061501769
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01647f661251c3871e
Upwork Job ID:<PHONE_NUMBER>378788352
Last Price Increase: 2023-07-25

Proposal
LHN reflects report value after a click on LHN
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The issue occurs in NewChatPage.js File In this The error in the code lies in the getSections method.
In the if condition that checks for hasUnselectedUserToInvite, the check is incorrect. It currently checks if this.state.userToInvite exists and if it is not included in the filterText. However, the filterText is constructed by concatenating the login property of selected options, so it will not include the email part of the userToInvite. T
his causes the userToInvite option to be consistently highlighted, even if it is selected.
What changes do you think we should make in order to solve the problem?
In Solution of this issue The code can modify as follows:
To fix this issue, We need to modify the if condition in the getSections method as follows:
By checking filterText.includes(this.state.userToInvite.email) instead of filterText.includes(this.state.userToInvite.login), we need to  ensure that the email part of userToInvite is included in the check.
This change will ensure that both cases (mentions without spaces and mentions with user email) are consistently highlighted or not highlighted based on their selection status

Added the external label.

Proposal
Inconsistently highlighting occurs when multiple mentions are used without spaces.
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The issue occurs in NewChatPage.js File In this The error in the code lies in the getSections method.
In the if condition that checks for hasUnselectedUserToInvite, the check is incorrect. It currently checks if this.state.userToInvite exists and if it is not included in the filterText. However, the filterText is constructed by concatenating the login property of selected options, so it will not include the email part of the userToInvite. T
his causes the userToInvite option to be consistently highlighted, even if it is selected.
What changes do you think we should make in order to solve the problem?
In Solution of this issue The code can modify as follows:
To fix this issue, We need to modify the if condition in the getSections method as follows:
By checking filterText.includes(this.state.userToInvite.email) instead of filterText.includes(this.state.userToInvite.login), we need to  ensure that the email part of userToInvite is included in the check.
This change will ensure that both cases (mentions without spaces and mentions with user email) are consistently highlighted or not highlighted based on their selection status

@aimane-chnaif thoughts on the proposal above?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistently highlighting occurs when multiple mentions are used without spaces
What is the root cause of that problem?
When @here mention is added along side user mention, ExpensiMark parser doesn't parse @here mention correctly. The reason is below regular expression for here-mention rule code here
/[`.a-zA-Z]?@here(?=_\b|\b)(?!((?:(?!<a).)+)?<\/a>|[^<]*(<\/pre>|<\/code>))/gm

This regex doesn't extract correct token @here from match result test link to replace with our user-mention markdown.
However, with @here@here comment it extracts, @here match token correctly test link
Hence, this caused inconsistency in highlight of here mention with multiple mentions.
What changes do you think we should make in order to solve the problem?
To fix here mention identification when mentioned with other user mention, we can change regular expression with below code here
/@here(?=_\b|\b)(?!((?:(?!<a).)+)?<\/a>|[^<]*(<\/pre>|<\/code>))/gm

Test link with updated regex
What alternative solutions did you explore? (Optional)
None

@aimane-chnaif thoughts on the proposals above?

@Shivam7-1 The root cause is not correct

Okay I will check again and make changes in proposal accordingly

Hello @aimane-chnaif What about @payal-lathidadiya proposal ?
I tested it and it looks like it is working

@payal-lathidadiya can you please explain in detail about your solution (regex)?

In current regex, we have [.a-zA-Z]? in starting before @here. So with ? specifier, it will match the previous token between zero and one times. So, while parsing here mention token with this regex, it will extract match result as <previous-char>@here when @here is added along side user mention which doesn't get validated here
My proposed solution suggests to remove this initial part [.a-zA-Z]? from regex since we only want to match whole word @here from input

@aimane-chnaif what are your thoughts on the latest proposals?

Doubled the bounty to see if we get more proposals.

Can you confirm this is the expected behaviour for your examples ?

@aiman.chnaif+2@gmail.com@here => <m>@aiman.chnaif+2@gmail.com</m><m>@here</m>

@here<EMAIL_ADDRESS>=> <m>@here</m><m><EMAIL_ADDRESS>
@here@here => <m>@here</m><m>@here<m>

@aiman.chnaif+2@gmail.com<EMAIL_ADDRESS>=>
<m>@aiman.chnaif+2@gmail.com</m><m><EMAIL_ADDRESS>
@here<EMAIL_ADDRESS>=> <m>@here</m><m><EMAIL_ADDRESS>@here@gmail.com@here => <m>@here</m>@gmail.com<m>@here</m>
@here<EMAIL_ADDRESS>=> <m>@here</m><m><EMAIL_ADDRESS>@here+1@gmail.com@here => <m>@here</m>+1@gmail.com<m>@here</m>

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we have two mentions following eachothers the highlights are insconsistent
What is the root cause of that problem?
As explained in other proposals the @here mention regexp is wrong
What changes do you think we should make in order to solve the problem?
If we always want @here mention to be highlighted "alone" and not part of an email, I think we can just look for @here and surround it with <mention-here>
The code would look like this:
{
    name: 'hereMentions',
    regex: /@here/gm,
    replacement: (match) => {
        return `<mention-here>${match}</mention-here>`;
    },
},

It looks too simple so I don't know if this is what we want ?
Result:

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we have multiple mention following eachother, the highlight is wrong
What is the root cause of that problem?
The here mention regexp is wrong and doesn't take into account every cases.
What changes do you think we should make in order to solve the problem?
Please bear with me, this regexp seems hard so I am going to try to explain:
I think we should change the here mention regexp by:
/(@here)([a-zA-Z0-9.!$%&+/=?^\`{|}_-]?)(?=\b)(?!(([\w\-\+\'#]*(?:\\.[\w\-\'\+]+)*@(?:[\w\-]+\.)+[a-z]{2,}(?!(([\w\-\+\'#\.\\]*(?:\\.[\w\-\'\+]+)*@(?:[\w\-]+\.)+[a-z]{2,}))))|((?:(?!<a).)+)?<\/a>|[^<]*(<\/pre>|<\/code>)))/gm,
Result:

Explanation:
We want to prevent matching<EMAIL_ADDRESS>and<EMAIL_ADDRESS>because<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are email addresses
So I first tested that the string after @here is not an email adress using the regexp found here : https://github.com/Expensify/expensify-common/blob/d7e424913550349acc779d029319af5b074c7c9e/lib/CONST.jsx#L3
But it wasn't working because @gmail.com is not an email adress so<EMAIL_ADDRESS>was still matching
So I modified it to accept @gmail.com as a valid email adress (I just replace a '+' by a '*' )
It was almost working:

Unfortunely it doesn't work if the email adress that is after @here has a dot. you can see that @here<EMAIL_ADDRESS>doesn't match because the regexp recognize<EMAIL_ADDRESS>as an email (and it is)
So to prevent that we need to test that the part that would make an email with here is not part of another email:
So we had: (?!(([\w\-\+\'#\.\\]*(?:\\.[\w\-\'\+]+)*@(?:[\w\-]+\.)+[a-z]{2,})))
For more clarity we can use variables instead of this big rexexp
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
when user-mention and here-mention are followed by each other, highlight is wrong
What is the root cause of that problem?
here-mention rule's regex is not covering the edge cases, need to fix it
What changes do you think we should make in order to solve the problem?
Frist, here mention's regex pattern would be as following
new RegExp(`([^@*~]?)((?:@${CONST.REG_EXP.EMAIL_PART})?)(@here)((?:@${CONST.REG_EXP.EMAIL_PART})?)([^@*~]?)(?=\\b)(?!([\\w'#%+-]*\\@(?:[a-z\\d-]+\\.)+[a-z]{2,})|((?:(?!<a).)+)?<\\/a>|[^<]*(<\\/pre>|<\\/code>))`, 'gm')
Second, replacement logic has some tweaks according to regex pattern amendment
                replacement: (match, g1, g2, g4, g5, g7) => {
                    if (!Str.isValidMention(match) && g2 == '' && g5 == '') {
                        return match;
                    }
                    return `${g1}${g2}<mention-here>${g4}</mention-here>${g5}${g7}`;
                },

Explanation:

g2, g5 is possible user mention captured by ((?:@${CONST.REG_EXP.EMAIL_PART})?), if existed, @here is parsed as here mention
(?!([\w'#%+-]*\@(?:[a-z\d-]+\.)+[a-z]{2,})) prevents<EMAIL_ADDRESS>matched as here mention

With my approach, @aimane-chnaif 's edge cases are passed successfully

Test cases
test('Test user mention and here mention, which are concatenated without space', () => {
    let testString = '@aiman.chnaif+2@gmail.com@here';
    let resultString = '<mention-user>@aiman.chnaif+2@gmail.com</mention-user><mention-here>@here</mention-here>';
    expect(parser.replace(testString)).toBe(resultString);

    testString = '@here<EMAIL_ADDRESS>    resultString = '<mention-here>@here</mention-here><mention-user><EMAIL_ADDRESS>    expect(parser.replace(testString)).toBe(resultString);

    testString = '@aiman.chnaif+2@gmail.com<EMAIL_ADDRESS>    resultString = '<mention-user>@aiman.chnaif+2@gmail.com</mention-user><mention-user><EMAIL_ADDRESS>    expect(parser.replace(testString)).toBe(resultString);

    testString = '@here<EMAIL_ADDRESS>    resultString = '<mention-here>@here</mention-here><mention-user><EMAIL_ADDRESS>    expect(parser.replace(testString)).toBe(resultString);

    testString = '@here@gmail.com@here';
    resultString = '<mention-user>@here@gmail.com</mention-user><mention-here>@here</mention-here>';
    expect(parser.replace(testString)).toBe(resultString);

    testString = '@here<EMAIL_ADDRESS>    resultString = '<mention-here>@here</mention-here><mention-user><EMAIL_ADDRESS>    expect(parser.replace(testString)).toBe(resultString);

    testString = '@here+1@gmail.com@here';
    resultString = '<mention-user>@here+1@gmail.com</mention-user><mention-here>@here</mention-here>';
    expect(parser.replace(testString)).toBe(resultString);
});

and it does not make other auto test cases failed
![image](https://github.com/Expensify/App/assets/139204153/cb818d22-111f-4ab9-bb58-5084d834a081)
you can check on this branch
cc: @aimane-chnaif

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01c94cf929c57ebc60?viewMode=1

I agree that there are probably some cases that are not handled by my proposal but I have the general idea, more tests would have been done during the PR. Also I am not sure we can trust the current unit tests, for example there are weird cases like this:
<EMAIL_ADDRESS>.According to the current unit  test that should return
<mention-here><EMAIL_ADDRESS>but isn't<EMAIL_ADDRESS>a valid email adress ? I think it is (and github seem to agree)

Awaiting proposals. No one proposed right solution to cover all these cases:

@aimane-chnaif my proposal here seems working correctly for expected output.
I just checked and re-tested my solution with above given test cases, they are parsed correctly and validated.
Let me know if I'm missing anything.

@payal-lathidadiya This image that @aimane-chnaif  put is not the expected output

but isn't<EMAIL_ADDRESS>a valid email adress ? I think it is (and github agrees)

@ShogunFire it's not valid email address. here_.com is not allowed , since underscore is not valid for domain level.

@Antasel then our current regexp for email validation is wrong...
This is a headache to handle every cases...
<EMAIL_ADDRESS>-> mention user
<EMAIL_ADDRESS>-> website
toto@heretutu -> here mention
@toto@gmail.com@here -> mention user and mention here
If @Antasel proposal don't handle all those cases I think we should just decide to only display the here mention when @here is surrounded by spaces,

@ShogunFire I agree that current email validation regex is wrong, it would be fixed with #17387 , I also proposed a solution to cover all cases there, waiting for @aimane-chnaif 's review. But current my solution here would cover all cases even though email regex is fixed from #17387
@aimane-chnaif could you please confirm final solution in #17387 ?

My proposal doesn't work for every cases and I don't know how to make it work so I am just going to hide it :( good luck sir

@aimane-chnaif what's the latest here? Do any of the proposals work?

@aimane-chnaif there are quite a few updated proposals shared here. When do you think you can review them?

@aimane-chnaif can you give an update here?

@aimane-chnaif please give an update today.

@aimane-chnaif do you expect https://github.com/Expensify/App/issues/17387 to address this issue? It's not clear why we'd put this on hold for that issue, mind clarifying?
Also it might be worth removing some of the edge cases from this issue and focusing on what is most likely to happen?

@aimane-chnaif
I've checked that my previous solution does not works after email base regex is changed from #17387 ,
so i added new solution as alternative option which works even after the email regex is changed
Proposal is updated here

I've figured out that look behind is not supported on Safari version less than 16.4 .
so I did some tweak on new hereMentionAfterUserMentions rule as alternative of lookbehind (?<=)
Alternative solution has been updated here

@flaviadefaria @aimane-chnaif
#17387 's PR has been merged. Could you please check the alternative solution on my proposal ?

@aimane-chnaif can you check @Antasel's comment above? Thanks!

@flaviadefaria @aimane-chnaif
Looks like merge freeze was over. could you check my proposal ? alternative solution

@aimane-chnaif I've removed the hold from the title can you please give an update here?

@aimane-chnaif should I reassign this?

@flaviadefaria @aimane-chnaif
@Antasel and I worked as team. Is it possible for me to contribute here ? here proposal was by me...

no , but i can use my account and upwork account

@aimane-chnaif  Proposal was by me, so I was interested in how you evalute about it. so opening this issue tab on my PC

@aimane-chnaif what do you recommend we do here? Continue looking for proposals,  have @agilejune re-submit the proposal from his account or something else? Also happy to move this to Slack if better.

@puneetlath I'm officially no longer in the BugZero team so reassigning this as it will not close until tomorrow.

@aimane-chnaif
How do you evaluate the alternative solution ?
If it's acceptable, Can I re-submit it using my account ?

@aimane-chnaif
I don't have other proposal,  I just asked if i can contribute with Antasel's alternative solution, I explained it why.

@aimane-chnaif
do you think the proposal covers this issue correctly ?

Proposal
Please re-state the problem that we are trying to solve in this issue.
when user-mention and here-mention are followed by each other, highlight is wrong
What is the root cause of that problem?
here-mention rule's regex is not covering the edge cases, need to fix it
What changes do you think we should make in order to solve the problem?
First, in here mention's regex pattern, add a tweak about negative lookbehind to prevent first @here in<EMAIL_ADDRESS>@here@gmail.com@here matched as here mention
changed part would be like following:
(?!([\w'#%+-]*@(?:[a-z\d-]+\.)+[a-z]{2,}(?:\s|$|@here))|

Secondly, to match @here which is preceding or following the user mention, we need to add another rule like 'hereMentionAfterUserMentions' after userMentions rule
            {
                name: 'hereMentionAfterUserMentions',
                regex: /(<\/mention-user>)(@here)(?=\b)/gm,
                replacement: '$1<mention-here>$2</mention-here>',
            },

lastly, we can replace the long string [a-zA-Z0-9.!$%&+/=?^{|}_-] with [^@*~] in here mention's regex, it does not effect the result. so final here mention regex would be as following:
regex: /([^@*~]?)(@here)([^@*~]?)(?=\b)(?!([\w'#%+-]*@(?:[a-z\d-]+\.)+[a-z]{2,}(?:\s|$|@here))|((?:(?!<a).)+)?<\/a>|[^<]*(<\/pre>|<\/code>))/gm,

I tested all edge cases of main solution and does not make other auto test cases failed.

@aimane-chnaif bump on review!

Sounds good to me. Let's make sure we update the tests to cover the new scenarios.

@puneetlath @aimane-chnaif
The PR https://github.com/Expensify/expensify-common/pull/594 for expensify-common is ready

Great! @aimane-chnaif will take the first round of review.

@aimane-chnaif how's the review going?

@agilejune I merged the expensify-common PR. Please open a PR in Expensify/App to update the expensify-common version. Thanks!

@puneetlath @aimane-chnaif
The App PR https://github.com/Expensify/App/pull/31541 is ready

Ok so is there anything left to do here? Or it sounds like we're ready to pay out?

kk. @aimane-chnaif I sent you an offer.
@agilejune can you please apply here? https://www.upwork.com/jobs/~01f57f05c12d9a825a

@agilejune bump. Can you please apply to the Upwork job so that we can close this out? Actually, also @usmantariq96. https://www.upwork.com/jobs/~01f57f05c12d9a825a
@aimane-chnaif has been paid

@puneetlath link is not opening at my end.
Can you please send me direct message please.
Thanks

@agilejune to this one? https://www.upwork.com/jobs/~01f57f05c12d9a825a
I'm not seeing your application.

@puneetlath

can you check this proposal ?

@agilejune to this one? https://www.upwork.com/jobs/~01f57f05c12d9a825a
I'm not seeing your application.

Yes, I applied there

Super weird. I don't see it.

Can you message me your upwork profile either here or in Slack and I'll try inviting you directly.
Also @usmantariq96 friendly bump to apply.

@puneetlath
this is my profile
https://www.upwork.com/freelancers/~017f0481af079ea44f

I thought I saved my details to contribute here.
But let me try again
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017f0481af079ea44f

Ok, offers sent:
https://www.upwork.com/nx/wm/offer/27999511
https://www.upwork.com/nx/wm/offer/27999485

Ok only @agilejune left to pay once they accept.

@puneetlath
Thanks for your offer,
I've accepted


Convert application navigation to tabbar.

This bounty pays out 5,000,000 PTS.
We require 2 items to be completed to award the bounty.

Remove all the side menu and add a tab bar controller with 4 sections. Assets, Trading, Receive(QR Code), Settings

On the Main wallets view, move the send icon to the top right and wallets (where you choose) your token to the top left of the navigation menu and is now presented modally rather than via the side menu.

I can tackle this over the weekend.
I'll take this one too 🙃

Awesome @ndizazzo !


Add id property in ViewDefinition

It would be convenient to have id property in ViewDefinition resources to make it more similar to FHIR resources.

@rublag We have the intention of creating a FHIR resource that realises the logical model - I think we just haven't got up to this yet.

@johngrimes, do you consider to switch ViewDefinition schema from inheriting Base to inheriting Resource then? This adds id, meta, implicitRules, and language properties.

I think this is still an unresolved issue that requires further discussion.


Update tests for step 1 of RPG game

Describe the Issue
There seem to be a high number of posts on the forum for this step.
https://forum.freecodecamp.org/search?q=Learn Basic JavaScript by Building a Role Playing Game - Step 1 in%3Atitle
Most have to do with this failing test
You should have a div element.
const div = document.querySelector('div');
assert.exists(div);

For example, this should pass the tests

<!DOCTYPE html>

  <meta charset='UTF-8'>
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <link rel="stylesheet" href="styles.css">
  <title>RPG - Dragon Repeller<title>

We should update the tests to account for spacing differences.
The following code above should pass.
If you are interested in working on this please read through the contributing docs first
https://github.com/freeCodeCamp/freeCodeCamp/blob/e8f6266405da8a85a1208f1e576aedcdaf369f8c/CONTRIBUTING.md
Here is the file that needs updating
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-basic-javascript-by-building-a-role-playing-game/5d5a813321b9e3db6c106a46.md
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-javascript-by-building-a-role-playing-game/step-1
Your code
This should pass but doesn't

<!DOCTYPE html>

  <meta charset='UTF-8'>
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <link rel="stylesheet" href="styles.css">
  <title>RPG - Dragon Repeller<title>

Expected behavior
Our tests should account for spacing differences in the camper's code
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

hello,
i read the issue, and i have some question related to this issue,
why would you want to pass title closing tag incorrectly (<title>_xyz_<title> instead of <title>_xyz_</title>) ?
if we just pass normal title tag the code will pass successfully

I think in this case, the test failed because <title> doesn't have a closing tag and interferes with the next query, so maybe we need to have a test that checks for the existence of </title>.
If I place <title> above <link> and remove the closing tag, I'll get "Your code should have a link element.".
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <title>RPG - Dragon Repller</title>
    <link rel="stylesheet" href="style.css" />

And I'm able to pass the challenge with the following code:
<!DOCTYPE html>

    <meta charset="UTF-8" />
    <title>RPG - Dragon Repller</title>
    <link rel="stylesheet" href="style.css" />

Yes you are right, but it's asked in the issue, the description that the code without proper closing tag, should pass.

Hey @sagarkashyap989 !
Yes, you are correct.
I hadn't seen the two opening title tags when I created this issue.
But we still have an issue with multiple people failing this first step with the tests pointing to the wrong reason why they are failing.
So it would be better to strengthen our tests so people know exactly why and how to pass the step.
I do like @huyenltnguyen 's idea of also checking to make sure they have opening and closing tags.