[SPARK-13019][Docs] Replace example code in mllib-statistics.md using include_example

https://issues.apache.org/jira/browse/SPARK-13019
The example code in the user guide is embedded in the markdown and hence it is not easy to test. It would be nice to automatically test them. This JIRA is to discuss options to automate example code testing and see what we can do in Spark 1.6.
Goal is to move actual example code to spark/examples and test compilation in Jenkins builds. Then in the markdown, we can reference part of the code to show in the user guide. This requires adding a Jekyll tag that is similar to https://github.com/jekyll/jekyll/blob/master/lib/jekyll/tags/include.rb, e.g., called include_example.
{% include_example scala/org/apache/spark/examples/mllib/SummaryStatisticsExample.scala %}
Jekyll will find examples/src/main/scala/org/apache/spark/examples/mllib/SummaryStatisticsExample.scala and pick code blocks marked "example" and replace code block in
{% highlight %}
in the markdown.
See more sub-tasks in parent ticket: https://issues.apache.org/jira/browse/SPARK-11337

Can one of the admins verify this patch?

ok to test

cc @yinxusen

Test build #51145 has started for PR 11108 at commit a4dd0fb.

Test build #51145 has finished for PR 11108 at commit a4dd0fb.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51145/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51154/
Test FAILed.

Merged build finished. Test FAILed.

Test build #51352 has started for PR 11108 at commit 0df3e65.

Test build #51352 has finished for PR 11108 at commit 0df3e65.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51352/
Test PASSed.

Test build #51602 has started for PR 11108 at commit d817d0b.

Test build #51602 has finished for PR 11108 at commit d817d0b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #51646 has started for PR 11108 at commit f945222.

Test build #51646 has finished for PR 11108 at commit f945222.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51646/
Test PASSed.

Merged build finished. Test PASSed.

Test build #51800 has started for PR 11108 at commit aec10ca.

Test build #51800 has finished for PR 11108 at commit aec10ca.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51800/
Test PASSed.

@keypointt Finish one pass

thanks a lot @yinxusen , I'm fixing the import format in the other PRs, will commit soon

Test build #52532 has started for PR 11108 at commit e2737ee.

Test build #52533 has started for PR 11108 at commit 3329394.

Test build #52532 has finished for PR 11108 at commit e2737ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52532/
Test PASSed.

Test build #52533 has finished for PR 11108 at commit 3329394.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52533/
Test PASSed.

@keypointt It looks good to me except for those trivials.

Test build #52598 has started for PR 11108 at commit acf7096.

Test build #52598 has finished for PR 11108 at commit acf7096.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52598/
Test PASSed.

@keypointt Thanks for working on this. @mengxr LGTM

cc @mengxr

I'm making a pass now.

@keypointt @yinxusen I made one pass and left some comments inline. One issue is whether we want to print empty lines. It doesn't seem necessary to me for example code appearing in the user guide. There are also some redundant comments, which we should remove. But overall, this look great!

@mengxr If there is no empty line, we will get a bulk of results which are hard to tell and recognize. I think it's a good experience for users that they can use ./bin/run-example ml.xxxExample to see some tidy outputs directly.

I agree. But we don't really need lines just to print empty lines. For example:
println(goodnessOfFitTestResult)
println()

could be simply
println(s"$goodnessOfFitTestResult\n")

It is good to keep the example code short.

Sure, that makes sense.
Sent from my iPhone

On Mar 17, 2016, at 11:04, Xiangrui Meng<EMAIL_ADDRESS>wrote:
I agree. But we don't really need lines just to print empty lines. For example:
println(goodnessOfFitTestResult)
println()
could be simply
println(s"$goodnessOfFitTestResult\n")
It is good to keep the example code short.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Test build #53460 has started for PR 11108 at commit a4eb28d.

Test build #53460 has finished for PR 11108 at commit a4eb28d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53460/
Test PASSed.

Hi @mengxr how do you like this change?

LGTM. Merged into master. Thanks!

Thank you!

Seems this one breaks scala 2.10 compilation (https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Compile/job/spark-master-compile-sbt-scala-2.10/547/console). Can you fix it?

Oh sure I'll try to fix it asap

@yhuai I've just tested on my local machine, and there is no compile error and the example output results correctly.
Also it seems all the parameters are right according to method documentation http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.rdd.PairRDDFunctions
And the build before merging to master was also successful...I'm not quite sure why this master build failed...

I reverted the change in master to unblock other builds. @keypointt Could you test it on Scala 2.10? It seems that Scala 2.10 doesn't resolve keyword arguments nicely:
def f(a: String, b: String, c: String = "xxx") = {
  println(a, b, c)
}

f(a = "abc", "def")
<console>:34: error: not enough arguments for method f: (a: String, b: String, c: String)Unit.
Unspecified value parameter b.
              f(a = "abc", "def")

We should either fix the seed or use keyword argument for fractions.

Oh yes I just tried 2.10 and 2.11, where 2.11 build succeeded but 2.10 failed.
Should I just explicitly add val seed?
// specify the exact fraction desired from each key
val fractions = Map(1 -> 0.1, 2 -> 0.6, 3 -> 0.3)
val seed = Utils.random.nextLong

// Get an approximate sample from each stratum
val approxSample = data.sampleByKey(withReplacement = false, fractions, seed)
// Get an exact sample from each stratum
val exactSample = data.sampleByKeyExact(withReplacement = false, fractions, seed)

I've add keyword argument at my forked repo: https://github.com/keypointt/spark/commit/892fe600e48b49b26a29120c99d171db02c659ab
should I open a separate PR? since new commit is not syncing to this PR

Hi @mengxr , I'm using below command to compile this branch (after merge in latest master branch) by scala-2.10
build/sbt -Pyarn -Phadoop-2.3 -Pkinesis-asl -Pspark-ganglia-lgpl -Phive -Phive-thriftserver -Pscala-2.10 compile test:compile
and I'm always getting this error sbt.ResolveException: unresolved dependency: org.scala-lang#jline;2.11.7: not found where the jline version is set at https://github.com/apache/spark/blob/48978abfa4d8f2cf79a4b053cc8bc7254cc2d61b/pom.xml#L157
I'm assuming that master branch now is using scala-2.11 and when building 2.10 there could be some resolve issues?

See https://github.com/apache/spark/blob/master/docs/building-spark.md#building-for-scala-210.
We don't need to specify seed. Just use keyword argument for fractions.
You can either re-open this PR or create a new one. Just need to make it clear what you changed on top of previously merged.


Bug: data-source files cannot found via cli:seed command

cli seed command cannot found data-source file in non-default directories. I run command in the following directories
backend(root directory)
└db
　└seed
　　└user.seeder.ts
　└data-source.ts

I run command with option like this..
typeorm-extension seed -r db
typeorm-extension seed -r ./db

and cli errors
TypeORMError: No connection options were found in any orm configuration files.
Versions

Node: 16.13.0
OS: mac os 11.5.2
typeorm: 0.3.7
typeorm-extension: 2.1.7

Reproduction

Additional Details

Steps to reproduce
What is Expected?
What is actually happening?

The seed file might not be found, because it could not be read.
The library is now throwing an exception from version v2.1.8 ongoing, if for example a dependency is missing in the data-source file.


js stall

in the native animated example, what is a js stall, and when does it happen normally?

Check out detailed explanation here: https://speakerdeck.com/mkonicek/under-the-hood-of-react-native?slide=36, slides 36 and 37, and the slides before for more context.
This issue looks like a question that would be best asked on StackOverflow.
StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.
Will close this as this is really a question that should be asked on StackOverflow.


Full-width / ideographic space

The full-width space character (aka ideographic space / U+3000) is not rendered properly, but is instead rendered as a dotted box with "ID SP" written inside it. I'm guessing this is a simple issue of which font is being picked to render it - some of the included fonts should definitely be able to display it properly.
An example can be seen at gemini://higeki.jp/fanden

You are correct, selecting a different font fixed the issue.


All substitution scores link in README results in 404

Dear ProteinGym team,
Once again thanks for your amazing work putting this resource together!
In the README, you direct users to download this file that should contain all the scores for the diffrent DMS datasets:
https://marks.hms.harvard.edu/proteingym/scores_all_models_proteingym_substitutions.zip

Unfortunately, following this link results in a 404 error. If you have an updated overview file, it would be much appreciated.
Kind regards,
Stephan Heijl

Dear Stephan,
Thank you for flagging the error with the download link. This was an outdated name for one of the the scoring files which we have just updated on the README. All downloads for files listed in the table should properly work, but please let us know if you run into any issues!
Kind regards,
Pascal

Much obliged Pascal, I found the relevant file, for future reference it is:
https://marks.hms.harvard.edu/proteingym/DMS_supervised_substitutions_scores.zip
Kind regards,
Stephan Heijl


Add Tracing instructions to Mongo integration

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Before we start modifying all 150 integrations, can you tell us about the intent here? There doesn't seem to be anything specific to Mongo here. Maybe we could change the documentation to have some generic links to APM?
Thanks.

Before we start modifying all 150 integrations, can you tell us about the intent here? There doesn't seem to be anything specific to Mongo here. Maybe we could change the documentation to have some generic links to APM?

Yes, we're working with documentation team to create generic templates in assets to simplify adding generic APM information to all integrations.

approved from docs 👍


Documentation: Incorrect information about traefik.docker.network in swarm mode

Do you want to request a feature or report a bug?
Bug
What did you do?
Read the documents at https://docs.traefik.io/configuration/backends/docker/#on-containers it reads:

[1] traefik.docker.network: If a container is linked to several networks, be sure to set the proper network name (you can check with docker inspect <container_id>) otherwise it will randomly pick one (depending on how docker is returning them). For instance when deploying docker stack from compose files, the compose defined networks will be prefixed with the stack name. Or if your service references external network use it's name instead.

The bold part is the problem I believe. Reading all the guides and examples on https://docs.traefik.io/ does state that the network needs to be prefixed with the stack name. I am reading the above quote as I would have to add the stack name to traefik.docker.network

Closing this as the documentation is indeed correct in this regard.


Fix dynamic mappings

I cannot remember what this was about.. I don't think it is a priority, though..

I have no idea what was it about (issue from 10 Oct 2019), and I can't recall, so I'm closing it.


Organization

Javascript Folder
May I suggest that you move all of your javascript into a dedicated js folder? It'd be much easier to look at and organize than the splattered files right now.

@c20ms1 It's a bit confusing because we use JavaScript both on the server and the client side. All client-side JavaScript is under public/js/. Server side JavaScript that serves webpages and API stuff is under routes/, and the JavaScript files in the root directory tie everything together.

Thanks, that explains it pretty well. At least this will be here for future confused organizers.


local variable 'right_proj_act_rec' referenced before assignment

my bad, set dap_size to 1 which is not reasonable to got this error.


⚠ Bofrost.lu has degraded performance

In 536df34, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1471 ms

Resolved: Bofrost.lu performance has improved in 18a2392.


topic_name keyword argument is wrong in the docs (Python SDK)

Describe the issue
As mentioned in https://github.com/dapr/docs/issues/1803#issuecomment-957758553, the examples' topic keyword argument is wrong. It should be topic_name.
URL of the docs
https://docs.dapr.io/developing-applications/sdks/python/python-client/#publish-messages

Thanks, would you like to submit a PR that fixes this?

Yep I can do it

Now that I look into it, should we look at this as a documentation problem or bad naming conventions? Because @dapr_app.subscribe uses pubsub_name and topic whereas .publish_event uses pubsub_name and topic_name.

Anyway, here goes the PR

Resolved


Bug Fix  Move Lambda Types to gtfsrt ingest Module

The Lambda Types file was added in to provide type hints to the
parameters to lambda handler functions in both of our batch files and
ingest scripts. It was put at the top level next to both of these
scripts, but that causes problems when zipping up the project for
deployments. To avoid this, move it to the module itself so that it will
always be bundled.

LGTM, other than the varied import pattern.

changed the import back. i'm going to merge now.


None of the methods for collecting memory limit and usage work in EKS

Using the 0.3.3 version of the library, the following two methods for figuring out memory limit and usage from the OS seems to fail to return any values in my EKS cluster:

lc_lib:do_get_cgroup_memory_usage/0 parses the cgroup memory path correctly (https://github.com/emqx/lc/issues/17 works!) and constructs the filename correctly, but the resulted file (/sys/fs/cgroup/memory/kubepods.slice/kubepods-pod30d0fb1f_937d_45c1_b986_fd363a73f1ea.slice/cri-containerd-3bf62db008468812fcafe483b22a094339421d780dccee198a27d105e828c2f4.scope/memory.usage_in_bytes) does not exist
lc_lib:get_cgroup2_memory_usage/0 also fails because /sys/fs/cgroup/memory.current does not exist either

I would suggest to include a 3rd method that I found working:
do_get_cgroup3_memory_usage() ->
    try
        CgroupUsed = read_int_fs(filename:join(["/sys/fs/cgroup/memory",
            "memory.usage_in_bytes"])
        ),
        CgroupTotal = read_int_fs(filename:join(["/sys/fs/cgroup/memory",
            "memory.limit_in_bytes"])),
        {CgroupUsed/CgroupTotal, CgroupTotal}
    catch error:_ ->
        {0, 0}
    end.

The above method parse these values:
$ cat /sys/fs/cgroup/memory/memory.usage_in_bytes
761204736
$ cat /sys/fs/cgroup/memory/memory.limit_in_bytes
3145728000

> lc_lib:get_cgroup_memory_usage().
0
> lc_lib:get_cgroup2_memory_usage().
0
> lc_lib:get_cgroup3_memory_usage().
0.24186197916666666

Thanks for reporting.
Since I don't have the EkS env now, would you able to make a PR for it?
Btw what is the kernel version?

Sure, I can create a PR, though it might only happen after Christmas.
I'm using: debian:11.9@sha256:f860cec7ccaf31b42cd60b6a409f9dad9510ea27fca9c2864741087b4298a1e3 for base image.
Shell says:
$ uname -a
Linux broker-0 5.10.228-219.884.amzn2.x86_64 #1 SMP Wed Oct 23 17:17:00 UTC 2024 x86_64 GNU/Linux
$ uname -r
5.10.228-219.884.amzn2.x86_64
$ cat /proc/version
Linux version 5.10.228-219.884.amzn2.x86_64 (mockbuild@ip-10-0-35-25) (gcc10-gcc (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1), GNU ld version 2.35.2-9.amzn2.0.1) #1 SMP Wed Oct 23 17:17:00 UTC 2024


fix: nuxt layouts don't work

🐛 The bug
layouts are not being applied to the pages
I tried this on my local set up as well as on the playground and layouts still don't work.
Neither a default layout or a custom one works.
Is there any special configs I need to add for layouts to be applied to pages?
🛠 To reproduce
https://stackblitz.com/edit/github-nvyvzd?file=layouts%2Fmain.vue
🌈 Expected behaviour
The layout should be applied and the "h1 testing HELLO HELLO h1" in the layout should be displayed before and after the content of the page that will be inserted in the slot.
ℹ Additional context
layouts do not work on any project I setup with this module

See https://github.com/nuxt-modules/ionic/issues/217#issuecomment-1399287584

@danielroe following instructions on #217 makes the layout appear but without the content of the slot. So it inverses the issue.

@danielroe To make the slot work by following #217, update to the following:
<ion-router-outlet /> where ever you've used <slot />.
It worked for me.


Getting an exception trying to use $return with ExternalFileTrigger binding

Updated an existing functional template to use $return with ExternalFileTrigger, I got the following exception trying to execute the function
Metadata file 'D:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll' could not be opened -- Access to the path is denied.

Steps

Go to https://functions.azure.com
Create a new function from the template ExternalFileTriggerCSharp
Change the output binding name variable to $return
Change the code to

using System;
public static string Run(string input, string name, TraceWriter log)
{
    log.Info($"C# External trigger function processed file: " + name);
   return input;
}

Not getting a repro on this anymore, Closing this one


Rethink Cobra code structure to remove use of global variables

Describe what should be investigated or refactored
The getting started guide in the Cobra documentations demos the library by using the init() function to register the command and configure flags. Which has resulted in a lot of projects following this pattern for their own code. The subsequent examples in the documentation does not use this pattern.
Error propagation becomes a large challenge when using functions init() as errors cannot be returned and they are magically called when the module is loaded. Additionally testing can become a hassle. This has led to problems like #2756 because there is no easy path to deal with these problems. As the functions are called automatically there is no easy way to pass function parameters, which instead led to using global variables to pass critical information. This includes things like command flags, embedded file systems, and build flags. Using such a pattern creates loose coupling between where the data is set and consumed.
My suggestion is that we refactor the CLI code base a bit to remove any use of the init() function. This would mean following a pattern similar to  what has been suggested in this issue.
https://github.com/spf13/cobra/issues/1041#issuecomment-1050938423
To make things clean we could have a single function for each subcommand/package which would then be responsible for calling and configuring commands downstream. This way we could pass any dependencies down from main to the subcommand which needs it.
Links to any relevant code
https://github.com/zarf-dev/zarf/blob/81f1c7085ea954fd0d8e1610bc516d2b342965e8/main.go#L43-L44
https://github.com/zarf-dev/zarf/blob/81f1c7085ea954fd0d8e1610bc516d2b342965e8/src/cmd/initialize.go#L179-L228
Additional context
N/A

I wrote up a similar issue #3183 that ended up being a duplicate. Copying the context over to here, cause there's code links and an example in zarf say
### Describe what should be investigated or refactored
Right now generate most of Zarf's CLI commands and flags inside of cmd pkg inits. While these inits() do have a reliable order, the order is not at all obvious when reading the code. We can make the code more maintainable by being explicit about when and how we generate commands and flags. Let's move this functionality into root and call the generate functions linearly, rather than in a bunch of init()s.

One pain point in this migration is that the logical commands in Zarf, e.g. `zarf package ...`, are each grouped by file names but are all in the `cmd` pkg. The many init functions help group and split these up, so we take that pain back on by moving them together. Taking additional time to move commands into their own subpackages, e.g. `cmd/dev` will help avoid overpopulating `cmd` with implementation details of specific commands.

### Links to any relevant code
Connect: https://github.com/zarf-dev/zarf/blob/main/src/cmd/connect.go#L106-L116
Destroy: https://github.com/zarf-dev/zarf/blob/main/src/cmd/destroy.go#L106-L113
Dev: https://github.com/zarf-dev/zarf/blob/main/src/cmd/dev.go#L332-L376
Zarf init: https://github.com/zarf-dev/zarf/blob/main/src/cmd/initialize.go#L181-L230
Internal: https://github.com/zarf-dev/zarf/blob/main/src/cmd/internal.go#L370-L385
Package: https://github.com/zarf-dev/zarf/blob/main/src/cmd/package.go#L464-L485
Root: https://github.com/zarf-dev/zarf/blob/main/src/cmd/root.go#L151-L182
Version: https://github.com/zarf-dev/zarf/blob/main/src/cmd/version.go#L85-L88

### Additional context
Zarf Say https://github.com/zarf-dev/zarf/blob/main/src/cmd/say/say.go is an example of how we'd contain the complexity of a specific command to one package, then declare that command explicitly in root.


bump default api_version to 38.0

fixes issues with older versions, for example: https://github.com/ejholmes/restforce/issues/167 describes one such potential issue with older api versions.

Hi @thomasdziedzic! I'm not totally against this, but I suspect we'd need a major version for the library as upping the version will almost certainly lead to backwards-incompatible changes.
Could we consider just changing the README to point people to set the version to a newer one?

Could you give me an example of a backwards incompatible change that could happen?
I always thought that Salesforce tries to keep backwards compatibility as much as possible.
IMO the version bump is necessary to keep the defaults for new users predictable. We could do a major version bump for the gem to reflect this change, but at the end of the day, I think it would be less error prone to use the latest version of the api as the default for the gem for users.

I'll look into it - I assumed that Salesforce API versions would be likely to introduce breaking changes but I could be wrong!
If Salesforce API versions introduce breaking changes, then we can't really change this default without a major version (as we want to stick to semantic versioning) which seems a bit overkill to me - otherwise, a minor version update could break people's code. Leave it with me and I'll do some research.

I've just done some more research on this and the basic answer is that we won't be able to change this without a major version release (e.g. 3.0.0)
Between API versions, the API can change significantly (e.g. see this Quora answer which shows differences in the Chatter users API between versions 23 and 32 - fields have changed completely). This would make any change backwards-incompatible, potentially breaking people's code unless they (a) make changes to their implementation or (b) manually specify the earlier version they want.
Salesforce keep their old API versions around forever, so I feel like there's no pressing need to force the issue. I'll look at making this change when there's a good reason to go to 3.0.0, as it feels a bit silly to release a major version just to up the API version.
For now, I'll update the README to suggest that people specify the latest version - this will get the best value and the newest features for users.
Thanks for your time on this issue - it's definitely a good thing to change! :+1:


Export guard / layer mask fix

This PR has two relatively simple changes;
IGLTFSceneExportGuard - this interface allows a MonoBehaviour on a GameObject to mark a portion of the transform hierarchy as unexportable, which allows us to easily indicate that portions of a scene are for business logic only and not visible objects, without having to create new layers and/or adjust tags. I've also included GLTFSceneExportGuard which is an empty MonoBehaviour purely for convenience when using this feature within the editor.
On line 970, there's a check for _exportLayerMask >= 0. I assume this was written with the assumption that an empty layer mask would be nonsensical and the exporter should just default to all layers. However, if layer 31 is enabled, this sets the sign bit on the underlying int, which will make the layer mask negative, and it'll therefore fail this check. I've switched this to _exportLayerMask != 0.
Both of these changes have been tested by us internally. Please take a look - thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey, and thanks for the PR!
There are multiple ways already to exclude objects from export (via enabled state if wanted, via layers, via export callbacks).
I'm not sure if adding another core mechanism is the right approach here – but the same functionality can totally be achieved with a simple export plugin which would be an excellent small sample to ship with the package.
@pfcDorn can you take a look at making such an example export plugin and putting them into the Samples~ folder so it can be installed from PackMan? And also at the second half of this PR regarding the incorrect LayerMask check? Thanks!

We've been playing around with import/export plugins but couldn't see an obvious and/or approved way to selectively chop nodes out based on our own criteria. If there's a way to do that then please do let us know as that would be perfect - thanks!


Partial verification of blob

Description
This PR enables partial verification of blobs. It solves the issue #268
Meaningful changes

The method hash has been added to the BlobTransactionTrait, it returns a [u8; 32] array, to be compliant with the internal hash representations used in the template.
The structure BufWithCounter has been created, which is a wrapper around Buf. This wrapper maintains an internal counter which tracks the number of bytes read from the inner buffer.
The get_extraction_proof function has been added, it produces proofs that the data have been correctly extracted from the block. The extract_relevant_txs_with_proof has been kept for legacy reasons but it should simply calls extract_relevant_txs followed by get_extraction_proof. The get_extraction_proof should be called after the rollup has processed the transaction so that we can track how far we've read from the blob (and hence do the partial blob verification optimization).
This PR simplified the structure of the apply_blob function of the module_stf_template. Mainly it avoids reading the whole buffer before checking the headers.
The Celestia adapters have been modified to take into account the changes.

Linked Issues

Fixes #268

Tests
The test suite has been ran, no other new tests have been created

Also, I realized now that merging this PR will very likely solve #298


Mounting to an element in ShadowDOM throws error on confirmCardPayment

Summary
Mounting the card element to some place in a shadowRoot works just fine. Doing a confirmCardPayment then throws an error asking if the card element is still mounted. I'm assuming this is due to poor shadow DOM support. Again, an assumption, but there's probably a query selector on your end somewhere searching for the mounted Stripe card iframe or the private input inside it? Normal query selectors do not penetrate shadow DOM :\ but the global Stripe instance probably should be able to do this if it wants to scrape for a mounted Stripe element.
import { loadStripe } from '@stripe/stripe-js';

class MyCustomElement extends HTMLElement {
  connectedCallback() {
    this.attachShadow({ mode: 'open' });
    this.init();
  }

  render() {
    this.shadowRoot.innerHTML = `

        <form id="payment-form" class="sr-payment-form">

          <button id="submit">

            Pay
          </button>
        </form>

Payment completed

    `;
  }

  async init(data) {
    this.render();
    this.stripe = await loadStripe(data.publishableKey);
    const elements = this.stripe.elements();
    this.card = elements.create('card');
    // This works just fine
    this.card.mount(this.shadowRoot.getElementById('card-element'));
    this.clientSecret = data.clientSecret;
    this.getElementById('payment-form').addEventListener('submit', (ev) => {
      ev.preventDefault();
      this.pay();
    });
  }

  pay() {
    // Error , asking if it is still mounted..
    this.stripe
      .confirmCardPayment(this.clientSecret, {
        payment_method: {
          card: this.card,
          billing_details: {
            name: 'Jenny Rosen',
          },
        },
      })
      .then((result) => {
        if (result.error) {
          // Show error to your customer
          this.showError(result.error.message);
        } else {
          // The payment has been processed!
          this.orderComplete(this.stripe, this.clientSecret);
        }
      });
  }
}

The reason I want shadow DOM support is because I want to create a custom element for my Stripe payment form. Then I can encapsulate my styles in this component and not risk styles leaking inward/outward relative to my application.
Other information
Happens in latest Google Chrome (w10)

Unfortunately it's not as simple as updating some "query selectors". There is a fundamental incompatibility between the window.frames collection and Shadow Roots See https://github.com/whatwg/html/commit/7b567729ac3cc66b074b0df53138c353ec540bb9 and https://github.com/WICG/webcomponents/issues/145. Unfortunately, Stripe.js currently relies on being able to reach every iframe through this method.
We do have some ideas on how to work around this limitation, but it would require a complete overall of our iframe communication. In the mean time, you can work around this yourself by using slots to "punch holes" through the shadow tree, and keep the Elements in the light DOM. @bennypowers wrote the clever stripe-elements library that does this automatically.
Btw, the Element mounted in the Shadow DOM is actually not functional at all. Not being able to use it with confirmCardPayment or other Stripe.js methods is only one of the issues. I'll try to see if we can better detect this case and error earlier.

Unfortunately it's not as simple as updating some "query selectors". There is a fundamental incompatibility between the window.frames collection and Shadow Roots See https://github.com/whatwg/html/commit/7b567729ac3cc66b074b0df53138c353ec540bb9 and https://github.com/WICG/webcomponents/issues/145. Unfortunately, Stripe.js currently relies on being able to reach every iframe through this method.
We do have some ideas on how to work around this limitation, but it would require a complete overall of our iframe communication. In the mean time, you can work around this yourself by using slots to "punch holes" through the shadow tree, and keep the Elements in the light DOM. @bennypowers wrote the clever stripe-elements library that does this automatically.
Btw, the Element mounted in the Shadow DOM is actually not functional at all. Not being able to use it with confirmCardPayment or other Stripe.js methods is only one of the issues. I'll try to see if we can better detect this case and error earlier.

Aaah I see, yea that makes it more complicated than I anticipated.
I'll go with the slots workaround, that's definitely workable for my use case. Also hey Benny, I totally forgot you wrote that lib 👍 will check it out

Aaah I see, yea that makes it more complicated than I anticipated.
I'll go with the slots workaround, that's definitely workable for my use case. Also hey Benny, I totally forgot you wrote that lib 👍 will check it out

FYI, we just added some detection to report an error when mounting an Element in the Shadow DOM. It should prevent false assumptions that the element is functional.

FYI, we just added some detection to report an error when mounting an Element in the Shadow DOM. It should prevent false assumptions that the element is functional.

I just did a quick test on https://bennypowers.dev/stripe-elements/?path=/docs/fallback-to-stripe-elements--enter-a-publishable-key and it looks like <stripe-elements> still works. Thanks.


Click Events

I have added a button on top of ARObject, some how action touch event working on view which are on the front, but not receiving for the view which are on top.
Any Help?

I am having the same issue , The objects which can be viewed by tilting the device upwards are not clickable if we add the button arobject .xib file.  Can you please help???    faizandedia have you found a solution?

@faizandedia @xsabdullah Hi, could you find the solution to this problem?

Hi,
Anyone got solution for the above problem. Please suggest me ASAP.


Feature/combineEmail

I would like to add these changes.  Discussed with Mike earlier today.  This combines all the email getting/login functions into a single class MailUtility.  I didn't yet, but Class/File Client.dart can be deleted, and class/file mailPiece_email_fetcher can be deleted.  I moved Client.dart feature into MailUtility (it just checks imapclient works with email/password for sign-in verification) and moved what I had in mailpiece_email_fetcher to mail_fetcher.
I also deleted any passing of email/username and password around app for the login function.  The username / password can be obtained from Keychain in the MailUtility function prior to logging in, so no need to pass between functions.
I also renamed a couple classes that had "mail" in the name but were really only working with mailPieces and storage.  I made it so only items with mail in the name are things that ask the MailUtility to get some emails and work on those emails.

Please fix merge conflicts

Please fix merge conflicts

I updated.  It could be because I had two or three PR at the same time there was a minor difference.


Include try-convert as part of build

This change adds a target that will download try-convert at build time and include it in the package output.

An alternative to #318

We can always update it to use versions.props if that gets hooked up


Add Box Selection to Path Tool

Closes #1234

I believe everything works as intended. Please check and confirm.
Thank you very much for your guidance and your patience.


Feature Request : Good to Have : Schedule Send Emails on Outlook Web

It shall be a great privacy preserving feature to be able to schedule send emails on future date/time.

@bhoisuman - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback and feature request on how to make Office 365 better. They keep a close tab on user feedback and it would be awesome if you could add your voice in UserVoice.
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!


feat(site):[alert,grid,form]Optimize the typography of CJK characters, mix Chinese and…

… English punctuation, and avoid excessive use of spaces for all Chinese text and comments within the site.
PR
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our Commit Message Guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2673
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

非常感谢您的优化PR，因为改的文件太多，所以检视的时候经常被卡死，能不能分几部分去提交呢？还要就是修改文档会导致部分E2E测试用例没过，所以是不是把测试用例的文案也统一改了呢？ @dufu1991


TexturePacker assumes same-sized, all-zero-alpha images are identical

If aliasing is turned on, images that are the same size and have zero alpha in all pixels are treated as aliases of each other and only the first one is included in the pack.
This is a problem if you're using any kind of special effect in which the A channel of the image is not necessarily used for transparency.
I'll take a stab at a PR. I realize that in most cases, the current behavior is desired, so I'll make it optional to turn it off.

My use case is that I'm doing multi-texturing, using the second texture's RGB for normals and its A channel for self-emission (pixels representing light sources like a light bulb or fire). But it could be used for other parameters, depending on the shader. For example, shininess level or ambient occlusion.
(I'm using my FlexBatch library for multi-textured sprites, but it can also be done with SpriteBatch if you are careful to set up two atlases the same way so texture regions match up exactly between them.)
I've used the A channel for other unconventional things in some particle effects before, even without multi-texturing.
Aliasing is super-useful when you have a lot of small sprite animations, so I'd rather not have to turn it off.
One rather minimally invasive way around this would be to allow a custom InputProcessor to be passed into the TexturePacker constructor, and change the InputProcessor.hash() method from private static to protected.
@NathanSweet

Using alpha or RGB for things makes sense. What I wonder is if it makes sense to use RGB but have alpha be all zeroes. If alpha is not used, it's easiest to make it all ones. If alpha is meaningful but just happens to be all zeros for something, then I suppose your PR makes sense.

It's the latter case. Alpha is all zero in some of my sprites but not all.
In my case it's for pixels representing light sources like the fire on
torches.
On Sun, May 13, 2018 at 5:55 AM Nathan Sweet<EMAIL_ADDRESS>wrote:

Using alpha or RGB for things makes sense. What I wonder is if it makes
sense to use RGB but have alpha be all zeroes. If alpha is not used, it's
easiest to make it all ones. If alpha is meaningful but just happens to be
all zeros for something, then I suppose your PR makes sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/issues/5219#issuecomment-388614703, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABwfu4RgHSa7wHrz1YlVipq1yieK5p-Aks5tyAMDgaJpZM4T8NgX
.


WIP: replace failed node

Closes #1082

Let me close this and recreate it, it's a mess :confounded:


Dynamic CUDA and TRT options updating

@pranavsharma this is solving #217 and some other issues that are asking for more option support. I have not tested this change, do you have any recommendation on how to test ? I have next to no triton experience.

@yf711 fyi

@krishung5 I am gonna go ahead and close this PR. Do you plan to apply the dynamic TRT option change at some point or will this happen on an on demand basis ?

I would like to finish it but unfortunately right now the team doesn't have bandwidth to do so. I filed a ticket DLIS-6872 to track this effort. If someone is asking for this then it's likely to get prioritized sooner.


[Bug] Text alignment setting doesn't work on some epubs.

Describe the bug
Changing text alignment doesn't work with some epubs. This is reproducible when using EPUBPreferences#textAlign, as well as in the test-app.
I've attached an epub that reproduces the issue, as well as screenshots.
repro.epub.zip

How to reproduce?

Unzip the attached file. (I had to wrap the epub in a zip because GitHub doesn't allow epub uploads.)
Open the epub in the test app.
Change alignment to left.

Readium version
2.7.1
OS version
iOS 17.5.1
Testing device
iPhone 15 Pro
Environment
Xcode 15.4
Build version 15F31d

Additional context
I suspect it might be related to text-align: justify in the epub stylesheet.

Yes it does look like an issue caused by the text-align: justify in the EPUB, but I think it should still work in this case. However this is not something to be fixed in the Swift toolkit. Would you mind opening a new issue on https://github.com/readium/readium-css instead? Thank you.


Improve Cilium policymap entry generation for allow-all with many identities

Problem description
Cilium master (v1.6 dev cycle)
When there are a large number of identities (for example, 10K with otherwise default Cilium settings), and there is a Cilium endpoint with no policy applied, the agent populates the endpoint's policymap with an entry for each identity, for each direction (for example, 20K entries).
With the default settings, the endpoint PolicyMap size is ~16K, which is less than 20K.
This leads to errors like this showing up in the logs when identity events are received:
level=error msg="Failed to add PolicyMap key Ingress: 70734 0" containerID=4af29ea1bc datapathPolicyRevision=0 desiredPolicyRevision=1707 endpointID=1259 error="Unable to update element for map with file descriptor 34: argument list too long" identity=23679 ipv4=<IP_ADDRESS> ipv6= k8sPodName=default/foo subsys=endpoint

Symptoms
Over time, if identities continue to be added, significant increases in policymap update events occur, here is an example as we approach 10K identities with 8 local endpoints, only one of which has policy applied:

At the same time, with many events being handled, we observe high mapSync time:

If a Cilium instance gets into this state with such an endpoint, then I have observed locally that upon Cilium restart, Cilium times out ~before starting the API~, and gets into a crashloopbackoff state:
...
level=error msg="Failed to add PolicyMap key Ingress: 70734 0" containerID=4af29ea1bc datapathPolicyRevision=0 desiredPolicyRevision=1707 endpointID=1259 error="Unable to update element for map with file descriptor 34: argument list too long" identity=23679 ipv4=<IP_ADDRESS> ipv6= k8sPodName=default/foo subsys=endpoint
level=warning msg="generating BPF for endpoint failed, keeping stale directory." containerID=4af29ea1bc datapathPolicyRevision=0 desiredPolicyRevision=1707 endpointID=1259 file-path=1259_next_fail identity=23679 ipv4=<IP_ADDRESS> ipv6= k8sPodName=default/foo subsys=endpoint
level=info msg="Completed endpoint regeneration" bpfCompilation=0s bpfLoadProg=0s bpfWaitForELF=0s bpfWriteELF=0s buildDuration=203.742008ms containerID=4af29ea1bc datapathPolicyRevision=0 desiredPolicyRevision=1707 endpointID=1259 identity=23679 ipv4=<IP_ADDRESS> ipv6= k8sPodName=default/foo mapSync=175.07156ms policyCalculation=27.293584ms prepareBuild="39.022µs" proxyConfiguration=0s proxyPolicyCalculation=0s proxyWaitForAck=0s reason="one or more identities created or deleted" subsys=endpoint waitingForCTClean=0s waitingForLock="1.017µs"
level=info msg="Shutting down... " subsys=daemon
level=info msg="HTTP server Shutdown: context deadline exceeded" subsys=daemon
level=info msg="Stopped serving cilium at unix:///var/run/cilium/cilium.sock" subsys=daemon
level=info msg="Exiting due to signal" signal=terminated subsys=daemon
level=fatal msg="Agent pipe unexpectedly closed, shutting down" subsys=cilium-node-monitor

The error Failed to add PolicyMap key with argument list too long is trying to communicate that the BPF policymap cannot be updated because it is full.
Note also that the mapSync takes quite some time: mapSync=175.07156ms .
The killing of Cilium above appears to be triggered from Cilium's own HTTP API handling code, not from kubernetes liveness checks. I'm not sure what the exact impact is of endpoints that fail to regenerate (maybe this causes Cilium startup to always fail?)
Improving on this behaviour
Upon ingress, we already use a ep_config_map entry to skip policymap lookup when no policy is applied:
https://github.com/cilium/cilium/blob/9499c3d70f144d4e555ce7b282dec48613bfc743/bpf/bpf_lxc.c#L771-L775
However, we still populate the policymap entries for such endpoints with no ingress policy.
On egress, there is no corresponding logic to skip policymap lookup when no policy is applied.
Tasks

[ ] Investigate how Cilium bootstrap works when an endpoint is guaranteed to fail regeneration
[ ] Consider whether identity allocation from Cilium should be bounded by some function of policymap.MaxEntries (eg, policymap.MaxEntries / 2)
[ ] Don't populate the BPF maps with all identities on ingress when policy is disabled
[ ] Consider how to extend egress to gain similar behaviour

[ ] Introduce datapath logic to handle egress allow-all

Option: Extend the datapath egress path to respect EP_F_SKIP_POLICY_EGRESS, similar to the code above
Option: Re-add #ifdef POLICY_ENABLED_EGRESS.

I'm not as big of a fan of this, because for every potentially common option we introduce, that leads to more required compilations which is quite expensive when starting up Cilium.

[ ] Don't populate the BPF maps with all identities on egress when policy is disabled

(Also related: #8071 , makes policymap size configurable so the limit can be extended)

Also relevant: Recent improvements to map sync logic have decreased map sync time in similar situations by an order of magnitude.

@joestringer btw shouldn't the policy map size be 2 * number of identities we can have? because the policy map has ingress and egress policies

@aanm this "identity explosion" can be worse with port-based policy since we could allow a large set of identities at one port, and then a large set of identities at another port, for both ingress and egress. I don't expect this to be a very common use-case, however.

From the sig-policy meeting today, @jrajahalme proposed that we could add an option to have a 'wildcard' entry in the policymap that 'allows-all', e.g. with identity 0, port 0, etc. If feasible, this would map nicely to the xDS NetworkPolicy and make those protobufs smaller on average. It would also make the maps stored within Cilium per-endpoint much smaller, as we would simply have one key in the desired / realized state. I suspect that iteration over these maps in userspace when computing what has changed between desired / realized state is costly to performance. One note - would be good to profile this!
@joestringer has determined that map lookups are fairly cheap, but in the case of allow-all, we would be performing an extra lookup in the drop case.
The flow would be:

L3-dependent L4
L4-only (allow all at L3 on a specific port)
L3-only (allow specific traffic from L3 for all ports)
L3-only allow all

@joestringer can you please confirm?


Update iam.tf

Adding explicit access to add tags in the ELB 'Create*' API calls.
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Access to attach tags was implicitly granted with permission to 'Create*' APIs. Now as an additional layer of security to ELB ‘Create*' API calls,  API callers must have explicit access to add tags in their Identity and Access Management (IAM) policy . This new addition will satisfy that
Types of changes
What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ x] I have read the CONTRIBUTING.md doc.
[ ] I have added necessary documentation (if appropriate).
[ ] Any dependent changes have been merged and published in downstream modules.

Please merge this one.
This is not exactly a change in https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/v2.5.4/docs/install/iam_policy.json, but close enough to comply with recent AIM change and fix an issue.
W/o PR this TF module is broken and won't function anymore.

The PR #33 has been merged and includes the necessary IAM policies related to it.
I will close the issue.


Add an experimental "homebrew" CASA .image reader

Partial solution to #605.  I think this code now clearly-ish outlines what is needed to build an array from the bytes on disk; the next step is to daskify this reader process.
Also, I want a large series of tests to actually run.  This is just what I did to get to the "good enough" stage.  We really need to test this on different:

numbers of dimensions (1,2,3,4,5)

numbers of chunks (<=1, 2-10)

@astrofrog maybe give this a quick review?  This might be the best solution (once dasked) to all of the CASA segfaulty problems

Coverage remained the same at ?% when pulling 0300b8ba9664d30f461171cc997b7df1c4533c52 on keflavich:casa_numpy_reader into 31b0b5151a0f7c66a43dd09b1519e8c532aa0f86 on radio-astro-tools:master.

so I definitely have this mostly-solved, but the steps of not-loading-into-memory and daskifying the reader are still a step beyond me.  Creating our own slice, as we did with ArrayLikeCasaData, will definitely work, but it would require manual concatenation, etc.  There has to be a better, simpler way.
In the latest commit, I added some commented-out code that shows how to get an n-dimensional array of the chunk indices.  How you populate an n-dimensional array-like object without reading every byte is the part I haven't solved.  It's probably trivial, though, and I'm just overlooking a single, simple function.

@keflavich - I've done some more work to improve performance, and have switched the CASA loader to use the dask reader by default. There is still some work to do, in particular in relation to masks. For now I have modified the code so that we can read in the data for the mask, except that (a) the dtype is probably wrong for datasets with masks, and (b) a lot of datasets I'm looking at have a very small mask file which must be effectively empty, so we need to handle this case.

I've now managed to properly read in the masks (which are actually stored as sequences of bits, so this requires a different approach to the data), and I've also fixed it for 64-bit floating point data. I have all the tests passing locally. We can also read in different masks by name with the low-level function, and that could potentially be exposed from the SpectralCube reader.
At this point, the remaining to-dos are:

[ ] Clean up the CASA tests - I added a new detailed test of the low-level function, but I need to check if we can remove or combine some of the other tests
[ ] Make sure that the SpectralCube CASA reader (not the low-level function) is efficient memory wise and doesn't try and cause all the data to be read in

Otherwise I think this is close to ready. Note that for now I haven't seen performance benefits from using dask, in part due to the small chunk size, but what's important here is first to make sure things are correct and efficient memory-wise, and don't segfault!

@keflavich - I think this is ready for review. One thing that I'd like to understand is how CASA chooses chunk sizes and if we can know for sure they will always be smaller than a certain size. If so, then we could replace the memmap with a fromfile since otherwise we have two 'layers' of lazy-loading - the dask chunks and the memmap within that, which maybe isn't needed. However, if chunks can be arbitrarily large, we should keep the memmap. In any case, this is not something that needs to hold back this PR. As-is, this PR seems to work and the tests pass. I've tried to make the internal dask reader as fast as possible but it can still take ~5 seconds for the data and mask each to construct the dask array when there are ~30,000 chunks.


Need to configure production to use a password for redis

We should add something similar to config/initializers/redis.yml
if Rails.env == 'production' && !config[:password].blank?
  Resque.redis = Redis.new(host: config[:host], port: config[:port], thread_safe: true, password: config[:password])
else
  Resque.redis = Redis.new(host: config[:host], port: config[:port], thread_safe: true)
end

This configuration worked for the events, but for some reason resque is not getting it.


SublimeEthereum

Hi!
I wrote SublimeEthereum package, I see that you used it for the basis of your solidity syntax...
I wonder if you have made some updates to it yourself or do you want a new version which will be done in the next few days. I will update it for Solidity 0.3.0
I just saw you used this grammar converter.

Thanks for the updates! Adding them now :) I hadn't made any other changes after the conversion, but just fixed nested mappings, added throw and the -=/+= operators.

Hello!
SublimeEthereum package received a bigger update in last few days and it's completely up-to-date with latest solidity 0.4.23. So could you please update your package again?
Just out of curiosity, what exactly do you use for this conversion? I tried atomizr and some other things myself but with no success...
thank you!


Support for imgcat?

It would be very useful to be able to see images as images instead of filename listing. With a Node-based solution that would probably be quite easy to show  instead of just the filename. And it would be nice to be able to print an image into the terminal emulator instead of opening an external application just to make sure that I'm working with the image file I think I'm working with. Does that idea make any sense?

This is already possible using the show command.


Indentation of  code broken on v2.0.7

The last update made the indentation on HTML goes crazy.
Version 2.0.6:

Version 2.0.7

I have a similar problem. Always happens inside double curly brackets over multiple lines. I created a minimal example that I could reproduce:
<template>

        {{
            "Test"
        }}
        :
        {{
                "Other Test"
            }}

</template>

When trying to fix it, the formatter always brings it into this weird form.

Duplicate of #3973


Selenium UI test

Added a Selenium Test project with 6 automated tests, the test will run automatically on every push to the Selenium branch

@duynguyen3010 you PR this to the main not your fork.


Adapt %p* newly added LIBC_PRINT_EXTENSION kconfig configuration

Summary
Adapt %p* newly added LIBC_PRINT_EXTENSION kconfig configuration(https://github.com/apache/nuttx/pull/13536)
Impact
N/A
Testing
PC:ubuntu 2004, X86, SIM, GCC 13.1
build：./tools/configure.sh sim:nsh
./nuttx

depend on nuttx https://github.com/apache/nuttx/pull/13536


Adding a new migration when there is only one present results in broken code

Description
When there is only one migration in the /migration/src/lib.rs file, adding a new migration via CLI results in broken code.
Before:
#![allow(elided_lifetimes_in_paths)]
#![allow(clippy::wildcard_imports)]
pub use sea_orm_migration::prelude::*;

mod m20220101_000001_users;

pub struct Migrator;

#[async_trait::async_trait]
impl MigratorTrait for Migrator {
    fn migrations() -> Vec<Box<dyn MigrationTrait>> {
        vec![Box::new(m20220101_000001_users::Migration)]
    }
}

After:
#![allow(elided_lifetimes_in_paths)]
#![allow(clippy::wildcard_imports)]
pub use sea_orm_migration::prelude::*;

mod m20220101_000001_users;

mod m20241020_051916_tests;
pub struct Migrator;

#[async_trait::async_trait]
impl MigratorTrait for Migrator {
    fn migrations() -> Vec<Box<dyn MigrationTrait>> {
            Box::new(m20241020_051916_tests::Migration),
        vec![Box::new(m20220101_000001_users::Migration)]
    }
}

To Reproduce

Remove all but one migration in the /migration/src/lib.rs file as shown above.
Run a command that generates a migration, e.g.cargo loco generate model test name:string

Expected Behavior
The new migration should be added into the vec![] macro correctly.
Misc
I'm willing to contribute a fix, though I'll need some guidance to find the source of the issue because I'm still unfamiliar with the codebase.

Thanks! looks like something we should fix.
I'm wondering how did you get a single migration? (most of the starters have multiple)

Look here: https://github.com/loco-rs/loco/commit/26f0069bbbc25bce209d6298e6d62be93d2ec36a
This should give you a sense for how to fix generator related issues in the future :)
Thanks for catching this!

I was following the file changes in #846 on what files and code to edit, so that I could remove the notes model and related code from the saas starter.


[BEAM-6235] Upgrade AutoValue to version 1.6.3

AutoValue 1.6 has now the annotations in a separate artifact: auto-value-annotations. This allows users to specify the annotations in compile scope and the processor in an annotation processing scope, without leaking the processor to a release binary.

I see FindBugs errors in the Java pre-commit.
LGTM after the failures are addressed.

Thanks @swegner


[Bug?] mangadesk_x64 only shows 'reading' manga.

Today I discovered this application, and, on login, I noticed it didn't actually show any manga that I didn't had in the 'reading' category. The thing is, most of my followed manga where in the 'to_read' category, so I was wondering if it is a bug, the intended behavior, or something else happened.
I expected to get more than 100 mangas in that list, instead I got merely 19.

I believe marking a manga as "to_read" is not the same as following it.


quat_from_mat4 not working

Unfortunately, the function doesn't give correct results.
Here's a proposal to change it (taken from https://www.euclideanspace.com/maths/geometry/rotations/conversions/matrixToQuaternion/index.htm):
float tr = M[0][0] + M[1][1] + M[2][2];

  if (tr > 0) {
    float S = sqrt(tr+1.0) * 2; // S=4*qw
    q[3] = 0.25 * S;
    q[0] = (M[1][2] - M[2][1]) / S;
    q[1] = (M[2][0] - M[0][2]) / S;
    q[2] = (M[0][1] - M[1][0]) / S;
  } else if ((M[0][0] > M[1][1])&(M[0][0] > M[2][2])) {
    float S = sqrt(1.0 + M[0][0] - M[1][1] - M[2][2]) * 2; // S=4*qx
    q[3] = (M[1][2] - M[2][1]) / S;
    q[0] = 0.25 * S;
    q[1] = (M[1][0] + M[0][1]) / S;
    q[2] = (M[2][0] + M[0][2]) / S;
  } else if (M[1][1] > M[2][2]) {
    float S = sqrt(1.0 + M[1][1] - M[0][0] - M[2][2]) * 2; // S=4*qy
    q[3] = (M[2][0] - M[0][2]) / S;
    q[0] = (M[1][0] + M[0][1]) / S;
    q[1] = 0.25 * S;
    q[2] = (M[2][1] + M[1][2]) / S;
  } else {
    float S = sqrt(1.0 + M[2][2] - M[0][0] - M[1][1]) * 2; // S=4*qz
    q[3] = (M[0][1] - M[1][0]) / S;
    q[0] = (M[2][0] + M[0][2]) / S;
    q[1] = (M[2][1] + M[1][2]) / S;
    q[2] = 0.25 * S;
  }

Did you check that the order of the quaternion elements is correct? linmath.h uses a slightly different convention and uses the last element for the real part, i.e. the ordering of the quaternions is i,j,k,r.

I've also tried shifting the elements, but it didn't work either. Does it work fine in your case?
I did a simple test:

Initialize an identity matrix
Extract quaternion with quat_from_mat
Create a new matrix with mat_from_quat
Realized that it's not the identity matrix

Can you do this test? If it works for you maybe it's something I messed up :)

I've also tried shifting the elements, but it didn't work either. Does it work fine in your case?
I did a simple test:
1. Initialize an identity matrix

2. Extract quaternion with quat_from_mat

There's your problem right there. An identity matrix has no distinct eigenvector, i.e. axis of rotation: Every vector is an eigenvector of an identity matrix.
Which in turn means, that there's no unique quaternion associated with it.
You must test with a rotation matrix.

Oh, thanks for pointing me that out!
By the way, I've tested it with some transforms coming from an animated data (which contains rotation matrices) and I couldn't get good results, while using the approach I posted it worked smoothly.
Have you had any issue with the function?

https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf

This part of the code doesn't make sense to me (I added the NOTE).
 for(i = 0; i<3; i++) { 	float m = M[i][i]; 	if( m < r ) 		continue; 	m = r;                          //NOTE: should it not be "r =m" ?  Setting m here is pointless. 	p = &perm[i]; }
Also, shouldn't the order be the same as in quat_identity ({0,0,0,1}, not  {1,0,0,0}) and the other quat functions ?
	 if(r < 1e-6) { 	q[0] = 1.f; 	q[1] = q[2] = q[3] = 0.f; 	return; }
Besides this I've had great use of linmath up to this point. :) Thanks!

Also, shouldn't the order be the same as in quat_identity ({0,0,0,1}, not  {1,0,0,0}) and the other quat functions ?
Besides this I've had great use of linmath up to this point. :) Thanks!

Yeah, I'll have to look at this. A couple of weeks ago I got a bunch of pull requests, and I was so swamped with work, that I didn't check them properly. Mea culpa.
TTBT when I published linmath.h I never expected to take off like that. There are a few warts and pimples I'd like to clean up, but wonder how much that would break for existing codebases.


fix: swallow unhandled exceptions on shutdown

Addresses failure https://dev.azure.com/vscode/VSCode/_build/results?buildId=133283&view=logs&j=087ff425-4815-510c-015a-6444fffaa352&t=5547c453-0547-5e1f-22ff-38d98b3b288a
Exceptions thrown after Node.js environment shutdown cannot be handled, the flag allows to simply ignore them in the binding layer.

N-2


Comb sort in JavaScript

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Implemented Comb Sort algorithm in JavaScript
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Closes: #5504

Kindly review @HarshCasper :)


[BUG] Page layout

Description
When I turn on the extension, the layout of the web player gets messy, just like in the picture.

I do not know what caused it to happen, so I don't know how to reproduce it. When I turn off the extension, everything is fine.
Environment

Operating System: Windows 11
Screen Resolution: 1920x1080 + 1600*900 (Dual Monitor) (Turning off one monitor does not affect the outcome)
Chrome Version: Version 103.0.5060.114 (Official Build) (64-bit)

Additional context
I have other extensions installed interacting with the web player. I turned them off and tried but the issue is still there. So I don't think this issue has any relation to those.

The hotfix is now published to the Chrome Web Store.
Instructions on how to get the update are here.


Structure of JS

Feature branch
Create a feature branch called feature/js to work on .
Comments
add the necessary comments to outline the work that will be done
Constants declaration
Declare the needed constants such as the array of objects which is workouts, access the DOM elements that are already created on the html like the buttons, the elements, etc..
Functions
Declare the functions that I forsee needed for the NewbieFit. and work on them
addEventListeners for the buttons
after creating the necessary functions, addEventListeners for bieFit and for Complete buttons
Client-side Storage
Store the workouts under the Previous Workouts section

Added all the above.


Modified to handle complex types

Added custom namespace to options on createClient. Borrowed
implementation from https://github.com/evgeniyarbatov/node-soap.
changed one function.
Addresses this issue.  https://github.com/vpulim/node-soap/issues/334, Attempted to use their latest but failed tests.
Can test with this.
var soap = require('soap');
var url = 'http://nodewcf.azurewebsites.net/Service1.svc?singleWsdl';

var getData = {};
getData.MyValue = "35";

var opt = { customNs: 'http://schemas.datacontract.org/2004/07/NodeSVC' };

soap.createClient (url, opt, function(err, client) {

   client.Service1.BasicHttpBinding_IService1.GetData2(getData, function (err, result) {
       if (err !== null)
           console.log(err);

       console.log(result);

       console.log('### SOAP MESSAGE ###');
       console.log(client.lastRequest);
   })
});

I'm closing this PR as there was no activity for more than half a year now...


Multiple servers and Lets Encrypt Domain Validation

When you have multiple servers, say for failover or loadbalancing purposes, the Domain Validation by Lets Encrypt is a problem. Imagine server B is trying to do DV and the request from LE gets routed to server A.
I'm aware this is not a simple issue, resolving it will require some form of communication between multiple caddy servers.
My idea for the simplest solution would be to have a configurable datastore (either on the FS or some DB) that can optionally be shared between hosts. This way assuming the storage is protected against race conditions, very little complicated server logic will be needed.

This will be worked around much more easily once Let's Encrypt activates the dns-01 challenge on their servers. We'll work some way into Caddy to take advantage of it (probably using env variables) and that should solve the load balancing situation.
For the record, it's a known issue: https://caddyserver.com/docs/automatic-https


Fix rounding when encoding timestamps

According to edgedb/edgedb#4885 conversion should round up to nearest even.
This should happen when encoding .Net native time format into a millisecond precision:
1970-01-01T00:00:00.0000005 -> 1970-01-01T00:00:00.000000
1970-01-01T00:00:00.0000015 -> 1970-01-01T00:00:00.000002

Also check LocalTime, Duration and LocalDatetime types.
This should happen across all the range of the values, see Rust tests for more comprehensive set of tests (but adjust precision conversion and time format accordingly). And the docs PR for more info.

Merged in #28, I'll close when a release comes out with the changes

Published in 1.0.5


Roads being added that are not visible in prediction

Description
The predicted road shows a certain line segment, but when one "accepts" the road segment, it adds additional, erroneous roads
Screenshots
https://github.com/facebook/Rapid/assets/24398638/0ae2ffdc-69f8-4789-9b14-8e189dc39f4b
Version
2.3.1
What browser are you seeing the problem on? What version are you running?
Chrome v124.0
The OS you're using
win
Steps to reproduce
Go to: https://rapideditor.org/edit#map=16.60/11.02714/-0.76480&background=EsriWayback_2024-03-28&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w-1185400465156696
Click on road
Accept road
Watch new thing appear
The browser URL at the time you encountered the bug
https://rapideditor.org/edit#map=16.60/11.02714/-0.76480&background=EsriWayback_2024-03-28&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w-1185400465156696
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

Thanks - looks like #1313 is still an issue 😢


output frames of a solid color instead of interpolation

I have used the command like this cain-ncnn-vulkan -i input_frames -o output_frames -g 0
but the only thing that it prints is
find_blob_index_by_name x.1 failed
find_blob_index_by_name x.3 failed
find_blob_index_by_name 4070 failed

over and over, and in the output frames the "interpolated frames are only solid colors"
idk if i'm missing a step or something

you need to move the model files from the cain folder into the same folder as the executable. it's the same issue as this https://github.com/nihui/dain-ncnn-vulkan/issues/2

well, i moved cain.bin and cain.param to the same folder as the .exe, but it's still giving me the same error

The current working directory of your terminal needs to be at the same folder as the model files since it just looks for them in "./"

Ok, now this is working

Imao this make me do some extra effort, but I guess that's how it is

thanks


Minor clarifications to TwigComponent doc examples

Q
A

Bug fix?
no

New feature?
no

Tickets
n/a

License
MIT

The examples I've touched sounded a bit misleading to me at first comparing to the Live Component package. Having something available as {{ message }} isn't possible since an error is thrown since it's not a property nor does it exist in the mount() method. I feel like examples should just make the this variable very clear.

Hi there!
Ah, this is tricky. The reason the documentation doesn't work is that you CAN now access local variables, but that feature has not been released yet :/. I think what we SHOULD do is clarify the version this stuff is available in. So what we're missing is:
.. versionadded:: 2.1
    The ability to reference local variables in the template (e.g. ``message``) was added in TwigComponents 2.1.
    Previously, all data needed to be referenced through ``this`` (e.g. ``this.message``).

That would hopefully give a hint of a feature doesn't work.

Ah that would explain things! Thanks for the clarification! I'll close this PR in favor of #244 then :+1:


suggestion: add position information to the positioned node

I need the reposition method to add information regarding the placement of the popper element because I want to use it as tooltips and I need to know where are the poppers places so I could render the correct triangle tip which will point to the side which triggered the tooltip

What about using the return value of the reposition function?

Calling popper.update(...) or reposition(...) both returns a position-pair (For example "te" for Top-End) or null based on if it was possible to find a position for the popper without clipping it.

Ha right. Good idea.


[CfgEditor] Introduce Optimize step

This commit adds HTML and static files for Optimize step.
ONE-vscode-DCO-1.0-Signed-off-by: Seok NamKoong<EMAIL_ADDRESS>
Parent Issue : #751
Draft : #697

Before & After

Type
Item
Before
After

UI
Optimize Step
:x: NYI

IMHO 'ON' (or 'OFF') text looks same with other static texts, e.g., optimization name or description.
To me, it's kinda difficult to know weather 'ON' text is static or it can be changed to 'OFF' by clicking it. Maybe we'd better have some indicator(? e.g., icon? check box? blue underline?) to let users that they can click ON.

Q. what happens when the user edit the property on the text editor and save it?

@hyunsik-yoon

How about having some kinda indicator(? e.g., icon? check box? blue underline?) to let users that they can click ON?

For now, cursor style is pointer for users to know that ON/OFF is click-able.
But I agree that something additional UI would be better :(

@dayo09
"Editing the property on the editor" is equal to "editing the values on the text editor".
It can be checked at the gif files :D

editing property on the editor --> the change is applied to file content but not saved
save --> the changed file content is saved

But I agree that something additional UI would be better :(

It's up to you to proceed this work in this PR or in future PR. :-) Just let us know. 😸

@llFreetimell Oh, I couldn't see that as it was so small, now I opened it on another tab and can see them. thanks.

Q.
As I can see in the gif, the behavior is:

Switching 'ON' adds the optimization property and sets it as True.
Switching to 'OFF' remove the optimization property.
When setting the optimization property as False, it switches to 'OFF'

It seems that the original .cfg file defines these three states :
a) property defined ans set as True
b) property defined and set as False
c) property not defined
And Cfg editor defines two states:
A) Set as ON
B) Set as OFF
So are they equievalant as below?
A<-> a

B <-> b <-> c

@dayo09

it takes me a massive concentration on the cfg editor to notice the difference

Sorry for attacking your eyesight... :cry:

how about highlighting the option when it's changed?

I will find a better way to highlight the changes :)

I'd suggest to make them strictly equivalent as making True/False/None instead of ON/OFF matcher.

At first, your understanding is correct. b and c are exactly same and they are equal with B.
b) property defined and set as False
c) property not defined
B) Set as OFF

Answer : (b == c) <--> B

Unfortunately, I am against for following suggestions T.T

Let's assume that we introduce NONE.
I agree that current implementation can cause some confusion too :(
However, following two expression is exactly same for ONE.
[one-optimize]
input_path=input
output_path=output
fold_add_v2=False

[one-optimize]
input_path=input
output_path=output

In this point of view, we cannot answer for "What is different for both NONE and FALSE?".
It means that NONE can cause even worse confusion for users, even above two have no differences.

Let's assume that we remove c) property not defined, which means that all properties should be defined.
This may reduce confusion for users.
However, I worry about two things

The number of properties

Currently, the number of all the properties is larger than 70~80.
It means that defining all the properties may create really long file.

Sample cfg files in ONE

Most of sample cfg files in ONE are not defining all of the properties.
It means that ONE is allowing c) property not defined.

Of course, it is only my sole opinion.
Therefore, if most of members agree to apply one of above suggestions, I will apply it :)
Or if you have better suggestion, please let me know :D

@llFreetimell Thanks for the explanation.
Considering your comments, I suggest this:

Use 'True / False' instead of 'On / Off'. Because the less terms will make the less confusions.
Put ❓ at the 'switch' button, just like 'optimization parameters' have. And give an explanation that "${option}=False is equivalent to an empty option"

@dayo09

Use 'True / False' instead of 'On / Off'. Because the same words will make less confusion.

I removed the word and used checkbox :D

Put question at the 'switch' button, just like 'optimization parameters' have. And give an explanation that "${option}=False is equivalent to an empty option"

Because of technical issue, codicon is not inserted inside of vscode-data-grid :(
I will find alternative solution later T.T

GIF is updated, PTAL :D

Looks better, and I think it resolves @hyunsik-yoon 's worry too.

IMHO 'ON' (or 'OFF') text looks same with other static texts, e.g., optimization name or description.
To me, it's kinda difficult to know weather 'ON' text is static or it can be changed to 'OFF' by clicking it. How about having some kinda indicator(? e.g., icon? check box? blue underline?) to let users that they can click ON?

Thanks.


Rename namespace and file QtcCppcheck -> Cppcheck - Take 2

Plugin name and translation file are untouched.

I disagree with these (renaming) changes again.

There are no obvious benefits from renaming.
Having different names in one codebase is bad (separate ui names are acceptable).


fix api model to use v1.0.0 and generate api with default model

Generate api with default model.  related: https://github.com/kube-rs/kopium/issues/60
use param of VERSION to generate api and not master.

/lgtm
/approve


Docker - Update Error

Hi, I've recently installed saic-phython-mqtt-gateway on docker. It was working for 12 hours until I restarted my docker pi this morning.  As you can see from the logs, it does speak to saic at the beginning and then keeps erroring (attached). Any suggestions welcome on how I can fix this... Or is it a bug?
saic-mqtt-gateway-2024-07-07T20-11-47.log

Hi @dandwhelan
this behavior is well known. There is a limited number of requests per day, maybe you hit this boundary somehow.
From my experience the only way to get out of the message...
return code: 4, message: The remote control instruction failed, please try again later.

... is to turn on the car.
Just turn on the gateway after your next drive. Then it should be okay again.

I have the same problem. How many requests per day are allowed? Is the interval of 60s perhaps too short?

Unfortunately we don't really know what the cap is, you can definitely increase the polling rate and see if that helps. It seems like the cap has a monthly reset, but that's just empirical evidence.


Support for iOS

Do you plan to add iOS support also in the package?

@ak111in Thanks for opening an issue. Sorry for replying late. Yes I plan to ad IOS support but it may take some time.

are you open to contribution? I am interested in using iOS as well

Yes I am but currently I am not taking IOS contributions as I am in the process of learning myself. I'll notify you within 10-15 days. Thanks for showing your interest.

We would also be highly interested in having a iOS version, too. Also willing to contribute to the project. Please give us an update any time soon. Thanks

Yes, with firebase_ml_vision getting sacked I'm quite positive you'll have a line of us wanting to contribute to get this production ready.

@AlexHartford, @festapp86: we have a couple of PR in the line for some refactors, and after I will give you green light to start helping with some iOS features. I already added some, you can check the README, but I will need help with the rest.

@AlexHartford , @festapp86 : we just released 0.5.0. That includes some iOS features, but we need your collaboration if you want to help us with some of the NL features. Pick one and let me know which one you are taking.

@fbernaly I have no experience with iOS so I won't be very helpful on this front, but I'll be keeping an eye out for future issues that I can tackle for you. Appreciate your work on this package, it's likely going to blow up soon!


Add section on plugins page to read from capabilities

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/122
Originally created by @tayloramurphy on 2021-10-01 21:01:08

Will require a capabilities key in each plugin file. Related to the work in https://gitlab.com/meltano/hub/-/issues/46
This should have a note: "See an error, make a Merge Request to get it corrected!"

View 4 previous comments from the original issue on GitLab


Why is flamethrower handling scrolls to ids?

There is a bug causing errors right now because of it, and I really just don't see the point. I can elaborate on the bug of course, but the simple solution is really just to... Not

I don't think flamethrower is handling scroll to IDs, that's just regular browser behavior.
All modern browsers I've used scroll to the element with the ID specified in the hash URL parameter, since that's looks like its intended use.

The last commit is literally https://github.com/fireship-io/flamethrower/commit/108f40feee5df5204faa715e03e04ba87bb02747


Remove redundant JavaScript import

What
Remove redundant govuk_publishing_components/lib/header-navigation import
Why
header-navigation is already required and executed by all public-facing applications as part of govuk_publishing_components/lib. Given header-navigation is not an actual module, but a IIFE relict from govuk_template, this duplication results in two toggle-like events being attached to the same button, which causes the search button to open and close itself in one click

Nice work catching this. The frontend app I looked at for this was frontend which doesn't seem to have an import of govuk_publishing_components/lib - so I did wonder if we might be trading fixing this in one app to break it another?

Nice work catching this. The frontend app I looked at for this was frontend which doesn't seem to have an import of govuk_publishing_components/lib - so I did wonder if we might be trading fixing this in one app to break it another?

Indeed – I prepared https://github.com/alphagov/frontend/pull/2901 to bring frontend in line with the other apps.


Add a note about connectorPort behaviour with portOffset

A note regarding https://github.com/modcluster/mod_cluster/pull/762

@jajik Should we add a note "Since 2.0.4.Final" ?

@rhusar Is it ok like this?

@rhusar Is it ok like this?

Definitely.

Thanks @jajik


get_empty_room without natten

I'm having a difficult time installing natte on windows. Where does the script need this library? I want to replace it with some substitute

as I remember, it is used by OneFormer model https://github.com/Lavreniuk/generative-interior-design/blob/main/get_empty_room/get_empty_room.py#L16C58-L16C68
If you change to a different model, like https://gitlab.aicrowd.com/bartosz_ludwiczuk/generative-interior-design-challenge-2024-starter-kit/-/blob/master/models/controlnet_baseline.py?ref_type=heads#L44 it may also work, but quality of segmentation masks would be lower.

Thank you!


[Question] Sound fingerprint match always a few seconds/milliseconds too early majority of the time

With using this basic code here, with no configurations at all, the match sometimes is always a few milliseconds too early or a second earlier with the track in question.
var modelService = new InMemoryModelService();
var audioService = new SoundFingerprintingAudioService();
var fingerPrint = await FingerprintCommandBuilder.Instance
                    .BuildFingerprintCommand()
                    .From(trackPath)
                    .UsingServices(audioService)
                    .Hash();
modelService.Insert(track, fingerPrint);

var queryResult = await QueryCommandBuilder.Instance.BuildQueryCommand()
                        .From(pathToSoundFile)
                        .UsingServices(modelService, audioService)
                        .Query();

var match = queryResult.ResultEntries.First();
var startsAt = resultEntry.TrackStartsAt;
var endsAt = resultEntry.DiscreteTrackCoverageLength;

I was wondering if there was a way to know if there's a small micro buffer within the match that can be taken into account for the match, to ensure the match is directly at the exact millisecond the track starts. The DiscreteTrackCoverageLength however, seems to function correctly. Now I made sure the raw track sample and the track to listen from both had the same qualities. Both the start and length of said track is the same exact soundwave, but the seconds before that the sound/voice is a little bit different.
Here is an image of both the tracks that the is being fed to the library, side by side ish, circled in red is the couple milliseconds before the track is played. I know the circle is a little bit bigger on the 2nd track, ignore that. Assume the circle is the same size as the top one. Both wavelengths are zoomed in the exact same spec.

Here is the track that we are fingerprinting and being trained into the model service, to the library, which is then used to be fingerprinted by the track above
The circle indicates where the track starts matched with the black circles on the pic above

I'm just wanting to know if there's something that will help with the slight shift of wave lengths, to get the exact spot where the track plays every time for every track. Right now it sometimes gets around that area where the red circle is, but I want it to get just the black area. I know it might not be possible but any pointers which can help me lead to the right direction would be appreciated

Hello, have you tested, if I have 1 million songs, is the speed slow when users go to match search? How accurate is it?

@sezonis The algorithm has a certain level of matched accuracy which cannot be improved due to various non-trivial reasons. A worst-case scenario (under ideal conditions of having the same source/target track as the query) can yield about 500ms of misalignment.

@sezonis The algorithm has a certain level of matched accuracy which cannot be improved due to various non-trivial reasons. A worst-case scenario (under ideal conditions of having the same source/target track as the query) can yield about 500ms of misalignment.

Fair enough.

Hello, have you tested, if I have 1 million songs, is the speed slow when users go to match search? How accurate is it?

No idea I don't use a database as I don't need to for my use case.


angular2 router not deactivated

Hi,
first of all great work!
I'm trying to use your example to see if this tool fit with my requirement and in the angular2 application I tried to add a simple router example. the angular 2 works great but when I try to switch to react (after angular2 has been loaded) it fail because angular2 is not unmounted and it try to find the path app1.
this is the repository that I created: https://github.com/daniele-zurico/microservice-test

See related https://github.com/angular/angular/issues/19079 and https://github.com/CanopyTax/single-spa/issues/115.
I think there is a bug in angular itself which is causing this.


HTTP Header Editor Middleware Development for React and React Native

Create a Common Middleware Module:

Create a middleware module that can be shared between React and React Native projects. This module should be designed to capture and organize HTTP requests.

Capture HTTP Requests:

Capture HTTP requests using Axios, fetch, or another HTTP client that can be used in both environments. If necessary, select an HTTP client package that is suitable for both environments.

Add AccessToken to Request Header:

Add an accessToken to the header of HTTP requests. This token can be retrieved just before the request is made, or it can be stored securely somewhere in the application.

Unnecessary issues 👎


[KOGITO-8222] Test parallel examples build

https://issues.redhat.com/browse/KOGITO-8222
Related:

https://github.com/kiegroup/kogito-pipelines/pull/690
https://github.com/kiegroup/drools/pull/4808
https://github.com/kiegroup/kogito-runtimes/pull/2606
https://github.com/kiegroup/kogito-apps/pull/1502
https://github.com/kiegroup/kogito-examples/pull/1410

jenkins retest this

runtimes issue unrelated


Adding new Polly extension with policy key selection logic

Adding new Polly extension with policy key selection logic.
https://github.com/App-vNext/Polly/issues/624#issuecomment-478218169
Addresses #bugnumber (in this specific format)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: shagilt sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Looks like you've got some build errors

Thanks @shagilt - will merge this once the build passed

Thanks!


Credentials not working when password does not exist

Hi,
Credentials are not working as expected when password.conf does not exist. I am using VT4Splunk app in Splunk Enterprise 9.0.3 (Debian GNU/Linux 11, Python 3.7). When accessing to Configuration page an ERR0005 is received with the following message:
"Unexpected error \"<class 'splunktaucclib.rest_handler.error.RestError'>\" from python handler: \"REST Error [500]: Internal Server Error -- Traceback (most recent call last):\n  File \"SPLUNK_HOME/etc/apps/TA-virustotal-app/bin/ta_virustotal_app/aob_py3/splunktaucclib/rest_handler/handler.py\", line 124, in wrapper\n    for name, data, acl in meth(self, *args, **kwargs):\n  File \"SPLUNK_HOME/etc/apps/TA-virustotal-app/bin/ta_virustotal_app/aob_py3/splunktaucclib/rest_handler/handler.py\", line 303, in _format_response\n    masked = self.rest_credentials.decrypt_for_get(name, data)\n  File \"SPLUNK_HOME/etc/apps/TA-virustotal-app/bin/ta_virustotal_app/aob_py3/splunktaucclib/rest_handler/credentials.py\", line 203, in decrypt_for_get\n    data[field_name] = clear_password[field_name]\nTypeError: 'NoneType' object is not subscriptable\n\". See splunkd.log/python.log for more details."

If trying to reproduce the issue and fails, delete local/password.conf and it should work.

Checking the code in credentials.py I noticed something strange. Code in here catches CredentialNotExistException and returns None. However, when using _get function, for example here, CredentialNotExistException is trying to be caught but this isn't never happening because _get already caught it.
I guess this isn't the expected behaviour. I edited the _get function not to catch the CredentialNotExistException and it works correctly. There are only two calls to _get function, here and here that don't catch that exception, but it can be fixed by adding:
try:
  original_clear_password = self._get(name)
except CredentialNotExistException:
  original_clear_password = None

The other three calls to _get function in the file do expect to catch the exception. Other solution may be not to edit the _get function and replace the except CredentialNotExistException: by if self._get(...) is None. Both solutions are valid and work as expected.

@pabloperezj thanks for the detailed report and for the proposed fix, Ill review those. I will not be available for the next month, so if I don't have time to check it and merge, I'll ask someone from the team to do that.

Any news?

@pabloperezj sorry for a delay and thanks for the ping!
I reproduced the issue and your fix makes sense.
From my side I'll see how it can be tested in the pipeline and I'll try to make a release today with a fix.


feat(create-vite): move TypeScript ones up

Description
According to The State of JS 2022, TypeScript usage is quite high recently.
https://2022.stateofjs.com/en-US/usage/#js_ts_balance
I think moving TypeScript templates upwards can improve DX slightly.
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Hmm I'm not really sure about this as for people starting out in general, we should probably recommend JS first. This would also interrupt the muscle memory of those using create-vite a lot. I'm voting to keep it as is at the meantime, but curious to hear what others think too

Adding it to the team board to discuss if we don't reach a consensus here. My first reaction is also in line with @bluwy, I think that I would wait a bit more to do this.
On a related note, we're also pointing to the vanilla JS starter on https://vite.new. If we do this change, maybe we should also point that to TS.

+1 for changing the defaults on vite.new & vite.new/framework

I understand it isn't obvious whether this change has more advantages than disadvantages. If we change this when create-vite is reorganized (if it's going to happen), maybe we can reduce the impact of the change relatively.

I think it is better to be consistent for all frameworks.


#339: refactor intellii and android-studio

Fixes: #339
Implements:

removed unnecessary and unused methods and variables
synchronized both tool classes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.08%) to 61.072%

Files with Coverage Reduction
New Missed Lines
%

com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java
1
95.45%

com/devonfw/tools/ide/io/FileAccessImpl.java
1
55.05%

com/devonfw/tools/ide/tool/intellij/Intellij.java
1
95.65%

com/devonfw/tools/ide/tool/LocalToolCommandlet.java
5
80.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
5281

Relevant Lines:
8314

💛  - Coveralls


error: undefined reference to 'HUF_decompress4X1_usingDTable_internal_fast_asm_loop

请问下这种是什么情况
../../../../src/main/native/decompress/huf_decompress.c:856: error: undefined reference to 'HUF_decompress4X1_usingDTable_internal_fast_asm_loop

On what architecture that fails? With which compiler?


Add the {:value, expected} type

This type is not particularly useful per se, but will be really handy for :or. For example, nimble_option's :doc can be validated as:
[
  doc: [type: {:or, [{:value, false}, :string]}]
]

Thoughts?

+1 from me, I think another good use case would be to allow re-implementing timeout:
[
  timeout: [type: {:or, [{:value, :infinity}, :non_neg_integer]}]
]

Isn't this the same as {:in, [false]}? 🤔  Maybe keep in and improve the error message if it has only one element?

@josevalim that is a Good Point™, didn't think about it! I won't even improve the error message for now, it's fine 😄


Unable to set -LockState Readonly on particular Site Collection (all other works fine)

I'm attempting to set a Site Collection from Unlock to Readonly. This Site Collection happens to be "https://tenant.sharepoint.com", so I'm unsure if that factors into it. I'm running:
Set-SPOSite https://tenant.sharepoint.com -LockState Readonly
When I do this with any other Site Collection like "https://tenant.sharepoint.com/sites/pwa", it unlocks just fine, but for this Site Collection, I get the error:

Any ideas?

@officedocsbot assign @yogkumgit

Hello @FedeFigueredo
AFAIK you can't set the LockState property of the root tenant site collection.
Will propose adding a note to the article.
Thank you

@trent-green Please merge the PR #3883

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @FedeFigueredo Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

There´s not any chance of fixing this bug? So -LockState property can be used on root tenant site collection.

Hello @FedeFigueredo please submit the proposal here https://sharepoint.uservoice.com/ as that is the right resource to propose ideas/features.
Thank you

OK @get-itips. Thanks!