urllib error running gw on macOS

Hi,
i installed and it throws Python errors. I'm stumped, sorry.
Here is the installation:
alex@Minivonlexander ~ % python3 -m pip install git+https://github.com/keirf/greaseweazle@latest
Defaulting to user installation because normal site-packages is not writeable
Collecting git+https://github.com/keirf/greaseweazle@latest
  Cloning https://github.com/keirf/greaseweazle (to revision latest) to /private/var/folders/y1/xqj4xsgx111dtsr194gjw3540000gn/T/pip-req-build-hb8e3dq6
  Running command git clone --filter=blob:none --quiet https://github.com/keirf/greaseweazle /private/var/folders/y1/xqj4xsgx111dtsr194gjw3540000gn/T/pip-req-build-hb8e3dq6
  Running command git checkout -q 03280074da38cd488238b20e2a2c0dce9aeda835
  Resolved https://github.com/keirf/greaseweazle to commit 03280074da38cd488238b20e2a2c0dce9aeda835
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: crcmod in ./Library/Python/3.9/lib/python/site-packages (from greaseweazle==1.11) (1.7)
Requirement already satisfied: bitarray in ./Library/Python/3.9/lib/python/site-packages (from greaseweazle==1.11) (2.7.3)
Requirement already satisfied: pyserial in ./Library/Python/3.9/lib/python/site-packages (from greaseweazle==1.11) (3.5)
Requirement already satisfied: requests in ./Library/Python/3.9/lib/python/site-packages (from greaseweazle==1.11) (2.30.0)
Requirement already satisfied: charset-normalizer<4,>=2 in ./Library/Python/3.9/lib/python/site-packages (from requests->greaseweazle==1.11) (3.1.0)
Requirement already satisfied: idna<4,>=2.5 in ./Library/Python/3.9/lib/python/site-packages (from requests->greaseweazle==1.11) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in ./Library/Python/3.9/lib/python/site-packages (from requests->greaseweazle==1.11) (2.0.2)
Requirement already satisfied: certifi>=2017.4.17 in ./Library/Python/3.9/lib/python/site-packages (from requests->greaseweazle==1.11) (2023.5.7)

And here is the output when trying to run 'gw':
alex@Minivonlexander ~ % gw
Usage: /usr/local/bin/gw [--time] [action] [-h] ...
  --time      Print elapsed time after action is executed
  -h, --help  Show help message for specified action
Actions:
Traceback (most recent call last):
  File "/usr/local/bin/gw", line 8, in <module>
    sys.exit(main())
  File "/Users/alex/Library/Python/3.9/lib/python/site-packages/greaseweazle/cli.py", line 64, in main
    return usage(argv)
  File "/Users/alex/Library/Python/3.9/lib/python/site-packages/greaseweazle/cli.py", line 35, in usage
    mod = importlib.import_module('greaseweazle.tools.' + a)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/Users/alex/Library/Python/3.9/lib/python/site-packages/greaseweazle/tools/info.py", line 12, in <module>
    import requests, re
  File "/Users/alex/Library/Python/3.9/lib/python/site-packages/requests/__init__.py", line 43, in <module>
    import urllib3
  File "/Users/alex/Library/Python/3.9/lib/python/site-packages/urllib3/__init__.py", line 38, in <module>
    raise ImportError(
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with LibreSSL 2.8.3. See: https://github.com/urllib3/urllib3/issues/2168

I think this is a recent packaging problem with Python. I could find the error message in Stackoverflow, and there are a few suggestions there for how to work around it. https://stackoverflow.com/questions/76187256/importerror-urllib3-v2-0-only-supports-openssl-1-1-1-currently-the-ssl-modu
Another way to work around would be to install pyenv and from that install a clean Python env of a different version (eg. 3.8) and use that for Greaseweazle. But I think the Stackoverflow suggestions linked above will probably get you going.

The suggested line to try is a downgrade of urllib as follows:
pip install urllib3==1.26.6

You may need to run pip3 instead of pip. LEt me know how it goes. I may need to add this to the software installation hints for MacOS for a while.

I tested this on Linux and probably the correct way to downgrade to latest urllib 1.x is as follows:
pip install "urllib3<2.0"

@keirf
alex@Minivonlexander / % pip install urllib3==1.26.6
zsh: command not found: pip

macOS is driving me crazy today, sorry.
I think i need so set a permanent path in the PATH variable to the location where gw and pip reside.
Could you poste the necessary command(s) please?

 The quotes are simply to escape the < character which otherwise gets interpreted by the shell.

As for commands on your path, it looks from previous command lines you posted that python3 and gw are both on your path? And you don't need pip. Actually it is safer to directly invoke python3 -m pip as you know you are invoking the correct Python env this way!
Python on Mac is known to be an experience. See https://www.explainxkcd.com/wiki/index.php/1987:_Python_Environment
A cleaner setup could be pyenv + virtualenv. I use this for development so I have my own clean isolated Python install for Greaseweazle (on Ubuntu Linux). However, I'm pretty sure the urllib downgrade will get you going!

@keirf
I'm sorry, still not cooperating...
alex@Minivonlexander / % python3 -m pip install "urllib<2"
Defaulting to user installation because normal site-packages is not writeable
ERROR: Could not find a version that satisfies the requirement urllib<2 (from versions: none)
ERROR: No matching distribution found for urllib<2
alex@Minivonlexander / %

Argh, that's because I mistyped the command line. It should be urllib3 not urllib.
Try this:
python3 -m pip install "urllib3<2"

😃
alex@Minivonlexander / % python3 -m pip install "urllib3<2"
Defaulting to user installation because normal site-packages is not writeable
Collecting urllib3<2
  Downloading urllib3-1.26.15-py2.py3-none-any.whl (140 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 140.9/140.9 kB 2.9 MB/s eta 0:00:00
Installing collected packages: urllib3
  Attempting uninstall: urllib3
    Found existing installation: urllib3 2.0.2
    Uninstalling urllib3-2.0.2:
      Successfully uninstalled urllib3-2.0.2
Successfully installed urllib3-1.26.15
alex@Minivonlexander / % gw
Usage: /usr/local/bin/gw [--time] [action] [-h] ...
  --time      Print elapsed time after action is executed
  -h, --help  Show help message for specified action
Actions:
  info        Display information about the Greaseweazle setup.
  read        Read a disk to the specified image file.
  write       Write a disk from the specified image file.
  convert     Convert between image formats.
  erase       Erase a disk.
  clean       Clean a drive in a zig-zag pattern using a cleaning disk.
  seek        Seek to the specified cylinder.
  delays      Display (and optionally modify) drive-delay parameters.
  update      Update the Greaseweazle device firmware to latest (or specified) version.
  pin         Change the setting of a user-modifiable interface pin.
  reset       Reset the Greaseweazle device to power-on default state.
  bandwidth   Report the available USB bandwidth for the Greaseweazle device.
  rpm         Measure RPM of drive spindle.

Thank you!

By the way I just moved the latest tag to the latest version v1.12. So you may want to install greaseweazle package again!


Embedded resources should use hex representation for file name

Previously the SHA256 was being used in byte form. If the hash started with 0x5C this was interpreted as a backslash which made the relative path resolution fail as that is the representation for a Windows-style root.
~There are no tests for this type... but clearly we need some.~ Ah, they're JVM-only!

Thanks for catching this


Allow a logger to be defined on underlying nsq gem

Here we allow for a passthru of .logger= and .logger to the wistia/ruby-nsq gem so that we can override the default logger of Logger.new(nil). This should allow us to setup the nsq gem logger to be something like Rails.logger or some other logger as is needed.
Changes:

Add two methods on MessageQueue (.logger= and .logger)
Support those methods on FakeMessageQueue
Tests for these methods

Minor stuff, but LGTM.
:sheep: it!

:+1:


Improve UX in editor modal, fixes #45

Added form styling and general styles to improve UX in the generator modal. Fixes #45

Looks good, but the spinner still looks broken (maybe I'll fix this later).


wip: Added the methods for list.

Thank your for contributing to Nuitka!
!! Please check that you select the develop branch (details see below link) !!
Before submitting a PR, please review the guidelines:
Contributing Guidelines
What does this PR do?

Fixed a typo that i saw.
Added the methods for list in the specialize tool, and added some unfinished implementation for it, in nodes.

Why was it initiated? Any relevant Issues?

The file ListNodes.py is unfinished.

PR Checklist

[X] Correct base branch selected? Should be develop branch.
[X] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[X] All tests still pass. Check the Developer Manual about Running the Tests.
There are GitHub Actions tests that cover the most important
things however, and you are welcome to rely on those, but they might not
cover enough.
[ ] Ideally new features or fixed regressions ought to be covered via new tests.  # code unfinished so no tests
[x] Ideally new or changed features have documentation updates.  # ~

If you look for tests, checkout the tests/generated/DictMethodsTest.py.j2 file, it does call all methods that have specs, and there are a bunch of conditions, that allows you to specific the arguments to test with. You do not have to cover wrong argument counts, that is generic code, but wrong types used (even possible with list, maybe extend comes to mind with a non-iterable), and it produces a .py file when you execute tests/generated/run_all.py only DictMethodsTest that you can look at.

Any chance for progress on this one? :-)

Sorry i was pretty busy lately. I dont know if i will find much time in the near future. I hope the code can help at least a little.

@Cjw9000-py no worries, thanks for letting me know, I will try and salvage what we can from here, this is a big part, and @Fire-Cube is currently working on something that help us generate nodes or their bases at least automatically, then this will be useful

This didn't make it for 1.0 nor 1.1, but I am hoping to merge it for 1.2 soon, even if maybe commented out until we got that generator for node classes.

I have just merged this and am currently adapting it to the new base class generation from specs, that will eliminate the boilerplate code somewhat. Thanks a lot for taking it on, very helpful.


Update cursor & highlight for buttons and major elements

Description
UI Updates:

When a button is hovered, we see an "I-Beam"

Buttons should not highlight on long press

Main image should not be highlightable

Main OS icon should not be highlightable, add click effect

No github or LI icons should be highlightable

Update github icons, everything else done


Stable Versión

Hello Everybody,
First of all Thanks to everybody who made this great work. I'm from Argentina, sory for my poor english.
For me it is very useful, And I would ask:

Would You have idea when the stable version will be?
2? You Advise me start a new project with this version?
3? I need to start inmediately one project, what do you recommend? Angular Full Stack generator?

Many Thanks! ! !

HI @marianoqueirel,
Thanks for your feedback.
You can definitely go with the current version. We are always improving and enhancing the project so there will always be changes.

@marianoqueirel Did that help? If so, can we close this issue?

@codydaig
I would start my project today.
I wonder if I should start with the 0.4 or the 0.5-Beta.
Obviously I want to start with the 0.5-Beta, with the current branch master, and my question is: Do you recommend I start a project with the current master branch? I prefer that.
Thank you!!

I would use the latest tagged release, which is 0.4.2, if you want fully reliable code for a large project. However, 0.5 will bring quite a few big changes, so definitely use that for your next project if it's ready.


Better horizontal scrolling

Issue Summary

Scrolling looks weird, consumes to mutch time and is not very snapy through unnecesary animations
should be similar to Adobe reader

Steps to Reproduce the Problem

scroll horizontaly through a pdf

Screenvideos
PDF-Viewer:
https://user-images.githubusercontent.com/11321022/121375327-f0cd2c00-c940-11eb-966e-24fc7b8fa437.mp4
Adobe Reader:
https://user-images.githubusercontent.com/11321022/121375371-fa569400-c940-11eb-8463-a532a4da052d.mp4

Go to Settings -> Horizontal Scrolling -> Page Fling
Try it.


Bug - IA upload broken

It appears the IA upload functionality has broken. Data elements below a certain level are appearing in containers above.
Cristina is working on it already and I'll test when  ready.

Fixed


Added default configuration for padding top

I think you can just go ahead and merge this. Our required vscode version is still the same and it's still working if you have the correct version.

I only seem to need 2px to avoid clipping.  Do you need a full 5px?

Then we do 2px


JDK 21 is not a LTS release anymore?

Describe the bug
If you call the https://api.adoptium.net/v3/info/available_releases  you will get the following as response
{
  "available_lts_releases": [
    8,
    11,
    17
  ],
  "available_releases": [
    8,
    11,
    16,
    17,
    18,
    19
  ],
  "most_recent_feature_release": 19,
  "most_recent_feature_version": 19,
  "most_recent_lts": 17,
  "tip_version": 24
}

According to this response LTS versions are 8, 11 and 17 but not 21. Additionally  21 is not under available_releases anymore
To Reproduce
Steps to reproduce the behavior:

wget https://api.adoptium.net/v3/info/available_releases

Expected behavior
21 should be under available_lts_releases and available_releases
Screenshots

I believe this was a temporary issue caused by the updater being unable to connect to the database, we probably need to have the updater fall over and restart when it is unable to connect to the db

yep, seems to be solved


Cabbage tests(if needed), reviews and approves AWS 19.1.0

Please review the release notes, make sure that the components have right versions and test WCs creation/upgrade if needed. We will only merge when we have approval from all the teams. PR: https://github.com/giantswarm/releases/pull/1147

hello @giantswarm/team-cabbage can someone please take a look at this and treat it with high priority?

Checked and tentatively signed off :+1:


Framework for examples

Set up framework to

have example scripts (.py) which show application of mrpro on real data (e.g. downloaded from zenodo)
automatically create example notebooks with results (e.g. reconstruction images) as github actions
add these example notebooks to documentation (requires #92)

This package might be suiteable for the conversion of scripts (.py) to notebooks (.ipynb):
https://github.com/remykarem/python2jupyter


297 add doc for listing containers

This PR:

Adds a page listing default supported labware

Mimics github version of this document with diagrams (can always change once branded 3d versions exist)

Minor css changes for toctrees within a page (removed 1 level bullets, reduced business)

Adds Labware Library to table of contents

Labware library references well access page

Getting Started page reference Labware Library page  in containers section

General Preview:

Dimensional diagrams for plate differentiation:

Coverage remained the same at 95.02% when pulling 94b32cea01d98d7d1e4e6ba5b8c3ad073ba64aea on 297-add-doc-for-listing-containers into 0be966a249a3177d840f2f4beac2829d4968856b on master.

Coverage remained the same at 95.02% when pulling 4e599ba19ccce0423c1c092c98e5b0071f4fb258 on 297-add-doc-for-listing-containers into 0be966a249a3177d840f2f4beac2829d4968856b on master.

Coverage remained the same at 95.02% when pulling 8adc91b856c3b5f04543bc67d0defd6231a38116 on 297-add-doc-for-listing-containers into 0be966a249a3177d840f2f4beac2829d4968856b on master.


How To Make AggregationFunc Like "Show Values as % of Row Total" function in excel pivot table

Do anyone know how to make aggregationFunc to do fraction of result table with row's grand total ?
Like "Show Values as % of Row Total" function in excel pivot table.

or do anyone know how to make diferent aggegation for sub totals and grand totals, cause i try compute in query for "Show Values as % of Row Total" like function, but when in sub totals and grand totals it just sum up the value. Thanks in advance...

No Answer (--____--)


Link to this repo as main learning resource for rhine

See https://github.com/turion/rhine/pull/331


SSL error

Hi,
Thank you for publishing this package!
I am getting the following:
Request Proxied -> /api/v1/[...] // Replaced
Request Proxied -> /api/v1/[...] // Replaced
internal/streams/legacy.js:61
throw er; // Unhandled stream error in pipe.
^
Error: write EPROTO<PHONE_NUMBER>79520:error:1425F102:SSL routines:ssl_choose_client_version:unsupported protocol:../deps/openssl/openssl/ssl/statem/statem_lib.c:1942:
at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:92:16) {

errno: -71,
code: 'EPROTO',
syscall: 'write'
}
Could it be related to using self-signed certificates?
Thanks,
Andrea

Hi,
To disable SSL verification, you can add NODE_TLS_REJECT_UNAUTHORIZED=0 at the beginning of your command like this: NODE_TLS_REJECT_UNAUTHORIZED=0 lcp --proxyUrl  https://github.com

this didn't fix the issue for me :/
➜  ✗ NODE_TLS_REJECT_UNAUTHORIZED=0  lcp --proxyUrl https://localhost:3001

 Proxy Active

Proxy Url: https://localhost:3001
Proxy Partial: proxy
PORT: 8010
Credentials: false
Origin: *

To start using the proxy simply replace the proxied part of your url with: http://localhost:8010/proxy

Request Proxied -> /opentokenisation/v1/api/debbie/read/6e0d4a89-9abf-461d-b3be-ba02b2cfe01a/4001653
(node:126527) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
internal/streams/legacy.js:61
      throw er; // Unhandled stream error in pipe.
      ^

Error: write EPROTO<PHONE_NUMBER>91488:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:

    at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:94:16) {
  errno: 'EPROTO',
  code: 'EPROTO',
  syscall: 'write'
}

Yes, same problem with wrong version number


skin-tone-# vs. _tone#

Hi,
thanks for the full list of emojis!
I am having trouble with the skin tones. When I use slack my emojis look like this: :santa::skin-tone-3: -> two emojis for one thing. However, in this list the same emoji looks like this: :santa_tone3: -> here
What do you think is better? Adding the skin-tone-# emojis to this list or dealing with them with a regex and ignoring the skin tone? Or something else?

Hello,
The list is auto-generated:
https://github.com/Kikobeats/emojis-keywords/blob/master/update.js
that calls to
https://github.com/Kikobeats/emojis-list/blob/master/update.js#L10
so now it depends directly from twemoji classes name.
I suppose we can do that but first we need to determinate what is the standard way out of there (not yet slack)

Thanks for the fast response @Kikobeats.
Ok, for now I will just ignore the skin tones and hope that slack starts using twemoji


Replacement transaction error

Describe the bug

.. I was getting nonce errors before staking, staked (which failed with 'replacement transaction underpriced'), but then it started working again

Expected behavior
Needs investigation, might be a nonce issue.
What does the error mean?

"Returned error: replacement transaction underpriced"

The error means that:

You have a pending transaction from your account in your Ethereum client
The new transaction you are sending has the same nonce as that pending transaction
The new transaction you sent has a gas price that is too small to replace the pending transaction

Additional Information
https://stackoverflow.com/questions/46349202/rinkeby-replacement-transaction-underpriced

Yes that is a nonce issue, after that error it should have resynced and recovered?


Generating config file!

When it comes to the configuration, its quite easy but it takes wasted time. I would suggest to use the: Command Palette, which the user can activate on the shortcut: "CTRL + SHIFT + P", and than search there for: "CSS V.A Config" or whatever you will name it. After clicking on it, it should create the folder ".vscode" if it's missing, and the file "settings.json" if it's missing, with a written template sample, which everybody can configure however they want later. + Additional idea, after clicking the command from the palette, it would be nice the setting.json file to be opened in the editor.
With all my respect :).

@flamurbeqiraj I've published a new version 2, no need configuration file


zipfile.BadZipFile: File is not a zip file

May I ask that what is the reason for this error?
Traceback (most recent call last):
  File "/opt/conda/bin/TotalSegmentator", line 103, in <module>
    main()
  File "/opt/conda/bin/TotalSegmentator", line 96, in main
    totalsegmentator(args.input, args.output, args.ml, args.nr_thr_resamp, args.nr_thr_saving,
  File "/opt/conda/lib/python3.8/site-packages/totalsegmentator/python_api.py", line 183, in totalsegmentator
    download_pretrained_weights(tid)
  File "/opt/conda/lib/python3.8/site-packages/totalsegmentator/libs.py", line 211, in download_pretrained_weights
    download_url_and_unpack(WEIGHTS_URL, config_dir)
  File "/opt/conda/lib/python3.8/site-packages/totalsegmentator/libs.py", line 86, in download_url_and_unpack
    raise e
  File "/opt/conda/lib/python3.8/site-packages/totalsegmentator/libs.py", line 82, in download_url_and_unpack
    with zipfile.ZipFile(config_dir / "tmp_download_file.zip", 'r') as zip_f:
  File "/opt/conda/lib/python3.8/zipfile.py", line 1269, in __init__
    self._RealGetContents()
  File "/opt/conda/lib/python3.8/zipfile.py", line 1336, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

ok, it's ok.

ok, it's ok.

Is it okay for you to try it the second time? Excuse me. I tried it once and found it still failed.


Gather information about relayer fee mechanism

Background
Socket has reported our system of sending relayer fees in sending side gas does not work for their integration. We need to collect some information from other partners about this and see if we have consensus around allowing relayer fees to be paid in sending asset.
On our side this would require changes:

Add an override for xcall that takes in relayerFeeAsset and relayerFee.
If user calls xcall with the extra params, transfer the asset to our vault.
Sequencer checks relayer fee sufficiency in the provided asset.

Linked Issues & Documentation

List of linked issues, external links, etc

Definition Of Done
We have enough answers from partners to make a go/no-go decision since this affects contracts and would require an upgrade.
Tasks

Let's go ask LiFi about this. We should figure out from them how this affects their integration with other folks as well, bc most important thing is to simplify integration path for other projects.
Let's go ask a few more projects about this, especially those that are sending ERC20 tokens through our system.
Let's go ask some end users who are using the bridge.

Update: Posed question to Lifi, Keep3r, and Unlock. Question text:

Hi Keep3r team! We are trying to gather feedback on something:

We have received feedback that some users/integrations do not like the mechanism of paying relayer fee using msg.value (i.e. native asset). We want to ask around and find out if we should work towards enabling a mechanism to pay for relayer fees using the sent asset instead.

What would you guys prefer? And any reasoning behind this preference?

Quick mockup of required contract changes: https://github.com/connext/monorepo/pull/3380

From LiFi:

The same flow for all assets would be important, it would be difficult to communicate that sometimes the bridge fees are deducted from the sent token and sometimes some additional funds have to be sent along.
A solution were the user has to sent multiple ERC20s should be avoided (e.g. sending AAVE, but pay fees with USDC).
I prefer the NXTP flow where fees are payed with the transferred asset, conversion of the amounts based on current gas costs on the chains have to be made in any case so the native asset is no advantage here.

@ArjunBhuptani @LayneHaber to figure out how much effort this would require

Spec: https://www.notion.so/connext/Protocol-d7d760166c3d4b848ac7f53e9b040803?p=d5f331c61beb44b6b06d289c0c03f660&pm=c

Contract changes in #3380


Update ProfileManager.cs

Allow iisProfilingTimeout to be set to max 15 minute when elected in app settings.
ref: https://docs.microsoft.com/en-us/answers/questions/85959/index.html, https://azure.github.io/AppService/2018/06/06/App-Service-Diagnostics-Profiling-an-ASP.NET-Web-App-on-Azure-App-Service.html#:~:text=It is possible to increase the default profiling duration by,to the 60 second value

@suwatch could you please take a look for approval?


replace gh-select-native with one-way-select

no issue

removes gh-select-native component as ember-one-way-control's one-way-select component offers the same one-way-binding but also allows element attributes to be set

Typos fixed, I think those areas weren't tested particularly well. I think if this was applied on top of #277 then the new tests would have at least picked up the invite modal typo.


Wrong patlen value in ex_substitute()

Problem:  Wrong patlen value in ex_substitute() (after 9.1.0426).
Solution: Compute patlen after finding end separator.
Add a more explicit test.  The test already passes as the only case
where a overlarge patlen value matters was fixed by patch 9.1.0689.

thanks!


WIP: Implement new config flow

🚨 TODOs before merging this:

[ ] Add translation strings (shows variable names now)
[ ] Better error handling for fetching authentication code
[ ] Need this PR from pyfreshintellivent (has a small breaking change)

This PR implements a new config flow:

Manual input (already supported)
No code (already supported, but before you had to leave an empty string when asked for auth code)
Automatically fetch auth code (new)

@angoyd Might be that Black/Flake8 is a bit strict. If so, we can change it a bit. I had to do something about it in pyfreshintellivent:
https://github.com/LaStrada/pyfreshintellivent/blob/main/setup.cfg
Not sure if that will work here, since it's a completely different setup.


What's the point of VirtualAllocEx and VirtualFreeEx in vmem.cpp

Hmm, I don't follow, why do you need those functions if you pass the current process handle to them.
Can't you just use VirtualAlloc & VirtualFree? Why overcomplicate things?
#if !defined(ASMJIT_OS_WINDOWS)
  return static_cast<uint8_t*>(VMemUtil::alloc(size, vSize, flags));
#else
  return static_cast<uint8_t*>(VMemUtil::allocProcessMemory(self->_hProcess, size, vSize, flags));
#endif

+

void* VMemUtil::alloc(size_t length, size_t* allocated, uint32_t flags) {
  return allocProcessMemory(static_cast<HANDLE>(0), length, allocated, flags);
}

+

static const VMemLocal& vMemGet() {
  VMemLocal& vMem = vMemLocal;

  if (!vMem.hProcess) {
    SYSTEM_INFO info;
    ::GetSystemInfo(&info);

    vMem.pageSize = IntUtil::alignToPowerOf2<uint32_t>(info.dwPageSize);
    vMem.pageGranularity = info.dwAllocationGranularity;

    vMem.hProcess = ::GetCurrentProcess();
  }

So on anything else than Windows you don't need YOUR OWN process handle, but suddenly on Windows you need it?

This is used for remote code injection - in that case you supply a handle of a different process, where the memory will be allocated and that pointer will be used as a base address. Then by using WriteProcessMemory() you can actually write assembled code into that process's memory. This functionality just simplifies the injection as the memory manager can be used to manage memory of a different process.
I have no clue how this would be done on Windows, never tried on non-windows platform.

But I don't need this :panda_face: it broke compatibility with the ancient Win versions of my app and I keep it compatible as a point of honour :smiling_imp: and the only thing that broke this compatibility was those 2 functions in AsmJit because of some obscure features (show me 1 project that uses it) :smile:
Also tried this new version from GitHub on my old VS2003 (again, compatibility reasons) and I see you just don't care anymore :disappointed:

Well, there does come a point where maintaining compatibility with compilers over a decade old becomes cumbersome...

I don't care, I like my software compatible across all versions of Windows and this is C++ after all, do I really need Windows 10 to run my C++ code?

I don't care, I like my software compatible across all versions of Windows and this is C++ after all, do I really need Windows 10 to run my C++ code?

Huh? All you need to run it is the VC++ 2015 runtime, which even runs on XP. You don't need Windows 10.

How about compiling code without those extra 2 functions and without installing extra runtime libraries? I like this solution better, if you like bloatware code with useless API functions, tons of runtime packages - it's your choice buddy. Someone said AsmJit has become a bloatware and by looking at
https://github.com/kobalicek/asmjit/blob/master/src/asmjit/build.h
or this vmem.cpp mess, I can't disagree... sorry Petr.

I definitely care! But I don't have any continuous integration where I can try if asmjit breaks on something else than I'm using. The problem is that now I don't even use Windows on a daily basis, so I guess the issue is more likely how to properly test asmjit on various windows' configurations, as Linux and MacOS are tested properly.
However, I'm not sure if the VirtualAlloxExis really the issue here. I'm using it from the beginning as it was recommended somewhere (hard to recall the original intention though) when I started with JIT. It's supported by WinXP and Win2003 Server, that's an amazing backward compatibility feature I think.
But if you know anything that prevents compiling asnhut on older compilers you can let me know, but as I said, I don't have these old tools to test it properly and I have developed an extensive compile-feature detection called cxxtool (https://github.com/kobalicek/cxxtool) that I use to manage all my projects and to keep them backward compatible with older tools.

Petr you have hundreds of compatibility settings in build.h (config.h previously) and you say all of this is useless? I don't even know what to say... what's the point if it doesn't work?
This VirtualAllocEx() is not a problem, I've already fixed it for my needs (replaced it with VirtualAlloc and removed the hProcess parameter).

I didn't say that. I think that asmjit backwards compatibility is very good compared to most projects that nowaday just use c++11 and require the newest c++ compiler to be compiled. And I offered you help to make it working, so why that bad tone?

Dude's a troll.  Asmjit is the least bloated project I've seen, keep up the good work!
On Jun 2, 2016 6:08 PM, Bartosz Wójcik<EMAIL_ADDRESS>wrote:How about compiling code without those extra 2 functions and without installing extra runtime libraries? I like this solution better, if you like bloatware code with useless API functions, tons of runtime packages - it's your choice buddy. Someone said AsmJit has become a bloatware and by looking at
https://github.com/kobalicek/asmjit/blob/master/src/asmjit/build.h
or this vmem.cpp mess, I can't disagree... sorry Petr.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

Guys I'm closing this as this discussion is not constructive.
I will still support pre C++0x compilers (through cxxtool) and WinXP+, but I will not support by default Win2000 and older Windows operating systems. Anyone is free to have its own fork. In asmjit:next branch I have reorganized platform dependent code and I have put everything to osutils.h and osutils.cpp, to make possible porting to other platform and maintaining zombies easier.


refactor: migrate to @makerx/node-ipfs

Overview

refactors ipfs api to use @makerx/node-ipfs package
uses FileSystemObjectCache in development and S3ObjectCache in production
adds environment assertion
refactors to esm module

TODO:

[ ] migrate github secrets from WEB3_STORAGE_API_TOKEN to IPFS_API_TOKEN

Issues:

https://algorandfoundation.atlassian.net/browse/ENG-210

Assume you tested end-to-end locally including NFT image and snapshot / metadata works?

Assume you tested end-to-end locally including NFT image and snapshot / metadata works?

Yes, working great locally. Thank you for the package suggestion and great software as always ❤.


Reset self.await_pingresp if we miss ping response

We missed the ping. It's over. It's never coming back.
The only thing we can do is send a new request, and wait for the response to that one.
tentatively fixes #34

Fixed as part of #42


add deposit.all endpoint

for #1133
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Change 1
Change 2
...

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Feel free to re-add me when this is ready for review.

Coverage decreased (-27.3%) to 60.056% when pulling b6c0cd634955fde92569c8214757887f679522c8 on 1133-deposit_all_api_endpoint into 94d24f015213ae6a8542f90cc3afb0138cbdb365 on master.

Drifted too far from master. Closing.


pythonPackages.weboob: add pyqt5 as native input

Motivation for this change
Address @dotlambda feedback for #57555 after merge

https://github.com/NixOS/nixpkgs/pull/57555#issuecomment-472638302
https://github.com/NixOS/nixpkgs/pull/57555#issuecomment-472641284

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Port to stable so since the last change fixed build, and this makes things nicer.

I changed it a tiny bit by using old.src.override.

cherry picked in 497b0237a5accdbb75c719c087ea9a18f34b6849 and 9fa2a21ba46d0d46a5666d7a19735479e87cd0df

I changed it a tiny bit by using old.src.override.

Nice, more people should do it like that :+1:


Fix branch command in README.

git checkout -b creates a branch and switches to it. git branch -b is not a valid command.

Thank you! You have no idea how many times I make this mistake.  Thanks for fixing.

Hehe yeah I was confused by it too. git commands are not the most intuitive things :P


PERF-#5835: Introduce lazy categorical proxy for pandas backend

What do these changes do?
This PR introduces a LazyProxyCategoricalDtype class for pandas storage format which is a lazy proxy representing pandas.CategoricalDtype. The PR changes the existing proxy from being HDK-specific to being backend agnostic.

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.


When to support parameter routing?

As the doc shows, it does't support parameter router currently, is there a plan for it?
Wiki: http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html

What kind of behavior do you need it about parameter routing?

For example, the request parameter has a field cityId, which can be configured to allow a request from a specified city to invoke a specific provider.

在 2018年10月16日，09:14，xujingfeng<EMAIL_ADDRESS>写道：
What kind of behavior do you need it about parameter routing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/incubator-dubbo/issues/2641#issuecomment-430066176, or mute the thread https://github.com/notifications/unsubscribe-auth/AfRPWcvZQPspgjn4DNzQ560p7BCpfxfpks5ulTMFgaJpZM4XZTuY.

Also maybe specified host

在 2018年10月16日，09:14，xujingfeng<EMAIL_ADDRESS>写道：
What kind of behavior do you need it about parameter routing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/incubator-dubbo/issues/2641#issuecomment-430066176, or mute the thread https://github.com/notifications/unsubscribe-auth/AfRPWcvZQPspgjn4DNzQ560p7BCpfxfpks5ulTMFgaJpZM4XZTuY.


Zero gradient

I'm trying to implement the gradient-penalty approach using this code, but this code block:
    gradients = autograd.grad(outputs=disc_interpolates, inputs=interpolates,
                              grad_outputs=torch.ones(disc_interpolates.size()).cuda(gpu) if use_cuda else torch.ones(
                                  disc_interpolates.size()),
                              create_graph=True, retain_graph=True, only_inputs=True)[0]

always returns gradients of 0.
Would this be caused by my using ConvTranspose2d units?

Where are you putting ConvTranspose2d in, Discriminator or Generator? And do you use Dilated feature(Because current double backward does not support dilated feature)? Do you use the latest master branch?

Generator, without dilation. But you're right, if the modules are on the generator, that can't be what's causing this.

On Aug 10, 2017, at 7:38 PM, Marvin Cao<EMAIL_ADDRESS>wrote:
Where are you putting ConvTranspose2d in, Discriminator or Generator? And do you use Dilated feature(Because current double backward does not support dilated feature)? Do you use the latest master branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I traced it to an InstanceNorm2d layer... Anyway it wasn't an issue in your code, thanks again!


Ctrl+Backspace not working properly in "Search in chat's history" after Select All

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue
Instead of delete, it removes Select All highlight and move the text cursor indicator all the way back to the left.
Reproduction steps:

Open a random chat
Press Ctrl+F to search for history
Type in random words asd
Press Ctrl+A or Double Click input box to Select All then Ctrl+Backspace

It works normally:

in chat.
Select All then Backspace without Ctrl
Ctrl+Backspace without Select All

Screenshots
https://user-images.githubusercontent.com/75530836/226168196-4e4b4f9f-ceb3-4194-b8f9-b6b0dafbf26f.mp4
OS and Chatterino Version
Chatterino 2.4.2 (commit c8204ef7) built with Qt 5.15.2, Windows SDK, MSVC 193431942, Crashpad Running on Windows 10 Version 2009, kernel: 10.0.19045

From what I have tested, if you select all and ctrl+backspace, it deletes everything except the last word. Not entirely sure if this is the intention, but this is why in your video, "asd" remains, because its technically the last word. If you type multiple words and try it, you will remain with the last word typed.

I tested again, it does delete everything except the last word

Probably an issue with the underlying QLineEdit widget. There might be a way to make a hacky fix by hooking into its signals but I don't think that's the right way to go

I investigated this quite a bit.  I believe that the reason why selecting all the text by holding and dragging left mouse click behaves as desired is because of the cursor position.  When you use the Ctrl+A shortcut for select all, the cursor position is at the end and using Ctrl+Backspace after would produce the bug.  When you select with the mouse from left to right where the cursor is at the end again, it also produces the bug.  However, if you select right to left, it works as desired.  I tried messing with the cursor and selection related functions for QLineEdit, but I couldn't get a selection with the cursor position at the beginning.  Adding an event filter was the only way that I could fix it using QLineEdit.

@21mtd could you create a new issue referencing this one, and include the places where you've encountered the bug?


Refactor/drop auto initialize

Codecov Report

Merging #24 (116409b) into main (8acee6b) will decrease coverage by 0.06%.
The diff coverage is n/a.

:exclamation: Current head 116409b differs from pull request most recent head f9a804e. Consider uploading reports for the commit f9a804e to get more accurate results

@@             Coverage Diff             @@
##              main      #24      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%
===========================================
  Files           44       44
  Lines         1464     1460       -4
===========================================
- Hits          1464     1459       -5
- Misses           0        1       +1

Impacted Files
Coverage Δ

src/blacksmith/service/_async/client.py
100.00% <ø> (ø)

src/blacksmith/middleware/_async/base.py
95.45% <0.00%> (-4.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acee6b...f9a804e. Read the comment docs.


Develop Custom HTML Dashboard

Once #89 & #90 are complete, I'd like to put together a more user-friendly dashboard in Bootstrap... I've put together most of this in my spare time already, I just need to make modifications as per the outputs in #89.

Status?

Was this decided against? I have base code for this if you want... how’s
touchscreen interface going?
On Mon, Feb 18, 2019 at 12:32 Ashwin Chitoor<EMAIL_ADDRESS>wrote:

Closed #91 https://github.com/FRCteam4909/2019-Deep-Space/issues/91.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/FRCteam4909/2019-Deep-Space/issues/91#event-2146904366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEUIR_wcguSnfsOpYE2Jh2yxIERyYZcyks5vOuO5gaJpZM4a64FL
.


Feature/show inactiveflag costcenteruser

PR Type

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
In the cost center management of the MyAccount section it is not visible, if a cost center user is inactive.

Issue Number: Closes #958
What Is the New Behavior?
The inactive status for a cost center user is shown.
Does this PR Introduce a Breaking Change?

[ ] Yes
[ x] No
Other Information
AB#79878
active flag for costcenteruser available starting ICM version <IP_ADDRESS>-LTS-dev3

@schadii @iwiederhold Our current ICM review server doesn`t completely support this feature, yet, that's why the inactive flag is not shown on the cost center buyers list.
Find the layout here:


support UUID type

It would be great to allow the UUID type.  ATM you'll get an error, that it's not supported.
A workaround is to create the column in duckdb's table with type UUID and the PostgreSQL foreign table's type with type TEXT.

Maybe this will be useful
https://github.com/pgspider/sqlite_fdw/commit/d6387a8ea33129d69c45389ee20180d809a03f03
https://github.com/pgspider/sqlite_fdw/commit/a272452097d6997ac7f44baa70b5b627450f3ded


Comprehensions

It's honestly kind of hard to explain just how useful comprehensions actually are
Like a third of my code in erlang ends up using them somehow
function rem(item, list) {

  const copy  = list.slice(),
        index = copy.findIndex(o => o.class === 'two');

  if (index !== -1) { copy.splice(index, 1); }

  return copy;

}

// this basically reduces permutation to a one-liner

function permute(List) {

  // the permutation of an empty list is the list containing one empty list
  if (list.length === 0) { return [ [] ]; }

  // this will go over list, using each element for item once, then remove it
  // and use the remainder for tail
  return [ [Item].concat(Tail) || Item <- List, Tail <- permute(rem(Item, List)) ];

}

Thank you @StoneCypher, but this proposal is about standard functions, not new syntax.

Syntax isn't really in scope for this proposal. You might suggest it on es-discuss (or find one of the previous threads there).

You may find these relevant:

https://esdiscuss.org/topic/array-comprehensions
https://esdiscuss.org/topic/array-comprehensions-with-spread-operator
https://esdiscuss.org/topic/comprehensions-where-art-thou
https://esdiscuss.org/topic/a-reprieve-for-es6-comprehensions

@nicolo-ribaudo , @bakkot - oh, didn't recognize the difference.  scuttled another one of these sob stories i'm writing, as a result.
what about things that involve both syntax and functions?

@ljharb - thanks

what about things that involve both syntax and functions?

Those also wouldn't be in scope for this.

If I had four array functions to suggest and two object functions to suggest, would you want one issue, two, or six?

@StoneCypher This repo is not for raising any feature request, https://github.com/tc39/proposal-javascript-standard-library/pull/32 is going to make it clear.


interface about shim build check

interface about shim build check
Signed-off-by: yylt<EMAIL_ADDRESS>

The change looks good to me.

The change looks good to me. Can you sign-off your commit with your real name?

sorry, forgot it.

/ok-to-test


Traceback caused by: edit.py

as mentioned at [Solved] issue using “edit” objects recursively
Info:
ST Version: Stable Channel, Build 3103
OS: Windows 10 Pro (64-bit), Build 10586
Error:
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 568, in run_
    return self.run(edit, **args)
TypeError: run() missing 1 required positional argument: 'name'

@ MyPlugin.py:
try:
	from .Edit import Edit as Edit
except:
	from Edit import Edit as Edit

...
...

edit = Edit(view)
edit.replace(region, text)

the above code works with  my modified version  of edit.py
* I used Tito's version as a base *

Works for me.
import sublime_plugin

class TestCommandCommand(sublime_plugin.WindowCommand):
    def run(self):
        view = self.window.active_view()
        from CSScheme.my_sublime_lib.edit import Edit

        with Edit(view) as e:
            e.replace(view.sel()[0], "replacement")

Seems like there may have been some misunderstanding on my part.
@ the ST recursive edit issues thread, I posted this, which I assumed your response was in reference to.
I felt like the with implementation of the original Edit.py added unnecessary bulk to my code, so I ended up creating my own Edit.py; which can be seen in conjunction with it's implementation @ my MatchReplace proof of concept.

Okay. I do not agree with your design decisions you made for your edit.py modifications, so I will not be incorporating them into my code.
"Edits" serve the purpose to group modifications into one undo step and the way you handle it (each modification becomes its own step) defeats the purpose of that entirely. This is why we need the with statement construct or callback method: To explicitly close the edit once we're done with it, i.e. end the TextCommand.

Good info.  I'll probably end up reverting to the with method.
What improvements does your version of Edit.py offer over over the original by linuxbochs?

It should be obvious from the docstring, but iirc:

Edit.call(view, cb) classmethod, which is a shorthand for with Edit(view) as e: e.callback(cb) (or similar)
An additional basic operation but I can't remember which?
Ability to pass callbacks for every parameter of the basic operations that get handed a variable number of arguments based on the function signature. This is useful when you make modications to the buffer and then want to append stuff to the end of the buffer in the same edit. Using view.size() in the with block would yield wrong results because the actual actions are applied after the with block is closed. Or you use the Edit.call variant.


Moving it to react-router-dom v6

Changes to be done

Use Routes instead of Switch component
Use useLocation hook for routing instead of props.match.params

Fixed as part of commit - 6e32ad628178160f56d4e3c47de07f34f7442bcb


Use scalafmt-dynamic so that enable scalaunfmt to use arbitrary version of scalafmt

Closing https://github.com/tanishiking/scalaunfmt/commit/70a26c07c24f9f8dd74751fdaf4548f06137b46f


MM-47289: Migrate /channel_settings e2e tests to TypeScript

Summary
https://github.com/mattermost/mattermost-server/issues/21298
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21298
Release Note
NONE

Hello @sinansonmez,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

MM-T856_1 and MM-T856_2 might fail. @furqanmlk please let me know if this is the case

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/253930

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/254324

@furqanmlk thanks for the support. I tested locally and both tests are passing

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@furqanmlk will you be able to merge this PR?


[Feature Request] allow for precise moving of objects using arrow keys

Some times I found it to be a struggle to move objects and nodes precisely using the mouse. Therefore I would suggest a functionality that allows to move objects using the arrow keys after pressing the m button.

Aren't arrow keys already used for the map?  I personally think this would be confusing and marginally helpful.  I have no issues with using shift-<arrowkey> though, since it doesn't conflict with existing usages.

Aren't arrow keys already used for the map? I personally think this would be confusing and marginally helpful. I have no issues with using shift-<arrowkey> though, since it doesn't conflict with existing usages.

I don't think we are talking of the same thing

I'm pretty sure that we are.  I just think it would be confusing if the arrow keys, which normally move the map, behaved differently in this situation.

This could be useful for those with motor disabilities. What do drawing tools normally do in this situation? I know some drawing tools allow you to “bump” features with the arrow keys; how do they distinguish between moving the object and moving the canvas? Does it depend on whether an object is selected?

In JOSM, Ctrl+arrow keys moves the canvas and Shift+arrow keys moves the currently selected object.

I know some drawing tools allow you to “bump” features with the arrow keys; how do they distinguish between moving the object and moving the canvas? Does it depend on whether an object is selected?

@1ec5 Sketch works like this, but being able to bump the canvas during selection seems more useful in an app like iD where the features can sprawl far and wide. I'd be okay with using shift-<arrowkey> for bumping selected features.

The issue I got with this is that every single nudge is added to the edit history, so reverting can become pain in the a**.


Fix someonewhocares issue link

CI fails are unrelated.

Hi Sandro @SuperSandro2000 - this repo has several readme files.  They are all generated from readme_template.md.
Can you please make this change in the template?

Changed the value in the template. I am not sure how to update all the readmes with it.

Sandro @SuperSandro2000 the readme files are generated by the various python scripts in this repo.  So changes to readme_template.md and the various update.json files ripple through the repo at each release.
Thanks for making the change, and for figuring out the change needed to happen in the update.json in this case.
Merging!

Sandro @SuperSandro2000 I would be glad if you listed this repo under GitHub repositories that I created and contributed to on your website. I can tell, you are going to be a very special developer some day soon.

I must admit that this section is auto generated and only keeps track of repos I have currently in my account. I should probably update the headline.


Issue with the badge (GIF 322)

On your ThreadsX page:

On FF it shows as "Gif 322" (screenshot), on Safari and Chromium as a square box.
Not sure if that's an issue that you could fix here?

Thanks for filing this issue.
It actually works in my Firefox (72.0.1):

Though I guess the point is that using not-so-famous Unicode character in the badge is not a great idea...  I guess the easiest fix is to convert this SVG to PNG locally and serve it via GitHub.


Clews 27620_brazil _Sugar_gpm_gfs_PR

Replace TRMM by GPM as first part of 2 changes

Done

View entire conversation on ReviewNB

Done

View entire conversation on ReviewNB

fixed

View entire conversation on ReviewNB

fixed

View entire conversation on ReviewNB

fixed

View entire conversation on ReviewNB

This is caused by group label change in k-mean clustering. Since Group 0 and 1 are switched, color blue and black are also switched. No code change is necessary.

View entire conversation on ReviewNB


Demo creation of test data id in AT

If ids are generated, e.g., by the db, the id in the expected http response has to be replaced by the id just generated. This is a common technique mentioned in the README and a demo would be nice.
Maybe the demo AT should be changed to use a db.

done


On the last step it shows connection close, should be conn close

Step 11 says: connection.close()
should be conn.close()

Which guide are you referring to? Thank you!

this is referencing a similar issue as: https://github.com/Snowflake-Labs/sfguides/issues/41


arm64: Support for FPU profile with procfs

Summary
To reduce the count of FPU context switching will result at a
performance improve with system. but it need to balance the using of FPU instruction and register
the patch submit a base method to see performance counts for the FPU.
Please read README.txt at chapter of FPU Support and Performance
for more information
Impact
None
Testing

qemu-armv8a(nsh/nsh_smp)
fvp-armv8r(nsh/nsh_smp)

Excellent! Thanks for including the explanation in the commit message!

@acassis could you merge this patch?

@acassis @xiaoxiang781216
Any change is needed?? or we can merge this PR

@qinwei2004
I noticed that ostest crashes with qemu-armv8a:nsh_smp
$ /home/ishikawa/opensource/QEMU/qemu-7.1/build/qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx
...

NuttShell (NSH) NuttX-12.1.0
nsh> uname -a
NuttX 12.1.0 4be499a243 Apr 22 2023 18:41:21 arm64 qemu-armv8a
nsh> ps
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK           STACK   USED  FILLED COMMAND
    0     0   0   0 FIFO     Kthread N-- Assigned<PHONE_NUMBER>000000<PHONE_NUMBER>40   6.3%  CPU0 IDLE
    1     1   1   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000<PHONE_NUMBER>68   2.2%  CPU1 IDLE
    2     2   2   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000<PHONE_NUMBER>28   0.7%  CPU2 IDLE
    3     3   3   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000<PHONE_NUMBER>28   0.7%  CPU3 IDLE
    4     4 --- 192 RR       Kthread --- Waiting  Semaphore<PHONE_NUMBER>000000<PHONE_NUMBER>40   6.3%  hpwork 0x402c3f70
    5     5   0 100 RR       Task    --- Running<PHONE_NUMBER>000000<PHONE_NUMBER>84  17.0%  nsh_main
nsh> free
                   total       used       free    largest  nused  nfree
        Umem:  131210576     571152  130639424  130639328     71      2
nsh> ostest
...

user_main: semaphore test
sem_test: Initializing semaphore to 0
sem_test: Starting waiter thread 1
sem_test: Set thread 1 priority to 191
sem_test: Starting waiter thread 2
waiter_func: Thread 1 Started
sem_test: Set thread 2 priority to 128
waiter_func: Thread 1 initial semaphore value = 0
waiter_func: Thread 1 waiting on semaphore
sem_test: Starting poster thread 3
waiter_func: Thread 2 Started
sem_test: Set thread 3 priority to 64
waiter_func: Thread 2 initial semaphore value = -1
waiter_func: Thread 2 waiting on semaphore
poster_func: Thread 3 started
poster_func: Thread 3 semaphore value = -2
poster_func: Thread 3 posting semaphore
poster_func: Thread 3 new semaphore value = -1
waiter_func: Thread 1 awakened
poster_func: Thread 3 semaphore value = -1
poster_func: Thread 3 posting semaphore
waiter_func: Thread 1 new semaphore value = -1
waiter_func: Thread 2 awakened
waiter_func: Thread 1 done
waiter_func: Thread 2 new semaphore value = 0
poster_func: Thread 3 new semaphore value = 0
[CPU3] _assert: Current Version: NuttX  12.1.0 4be499a243 Apr 22 2023 18:41:21 arm64
[CPU3] _assert: Assertion failed panic: at file: common/arm64_fatal.c:375 task(CPU3): ostest 0x402a4794
[CPU3] up_dump_register: stack = 0x40389d10
[CPU3] up_dump_register: x0:   0xdeaddeaddeaddead  x1:   0x7
[CPU3] up_dump_register: x2:   0x0                 x3:   0x402c3ca0
[CPU3] up_dump_register: x4:   0x1                 x5:   0x2
[CPU3] up_dump_register: x6:   0x0                 x7:   0xa00
[CPU3] up_dump_register: x8:   0x88                x9:   0x0
[CPU3] up_dump_register: x10:  0x0                 x11:  0x0
[CPU3] up_dump_register: x12:  0x0                 x13:  0x0
[CPU3] up_dump_register: x14:  0x0                 x15:  0x0
[CPU3] up_dump_register: x16:  0x4028ca18          x17:  0x0
[CPU3] up_dump_register: x18:  0x0                 x19:  0x402c2098
[CPU3] up_dump_register: x20:  0x4038a010          x21:  0x402b5c88
[CPU3] up_dump_register: x22:  0x0                 x23:  0x0
[CPU3] up_dump_register: x24:  0x0                 x25:  0x0
[CPU3] up_dump_register: x26:  0x0                 x27:  0x0
[CPU3] up_dump_register: x28:  0x0                 x29:  0x0
[CPU3] up_dump_register: x30:  0x40282230
[CPU3] up_dump_register:
[CPU3] up_dump_register: STATUS Registers:
[CPU3] up_dump_register: SPSR:      0x600003c5
[CPU3] up_dump_register: ELR:       0x4028238c
[CPU3] up_dump_register: SP_EL0:    0x4038a040
[CPU3] up_dump_register: SP_ELX:    0x40389d10
[CPU3] up_dump_register: TPIDR_EL0: 0x403726f0
[CPU3] up_dump_register: TPIDR_EL1: 0x403726f0
[CPU3] up_dump_register: EXE_DEPTH: 0x1
[CPU3] show_tasks:    PID GROUP   CPU PRI POLICY   TYPE    NPX STATE   EVENT      SIGMASK  STACKBASE  STACKSIZE      USED   FILLED    COMMAND
[CPU3] show_tasks:   ----   ---  ---- --- -------- ------- --- ------- ---------- -------- 0x402cc000      8192      8192   100.0%!   irq
[CPU3] dump_task:       0     0     0   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000 0x402ce030     16336      1168     7.1%    CPU0 IDLE
[CPU3] dump_task:       1     1     1   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000 0x402d2030     16336       368     2.2%    CPU1 IDLE
[CPU3] dump_task:       2     2     2   0 FIFO     Kthread N-- Running<PHONE_NUMBER>000000 0x402d6030     16336       368     2.2%    CPU2 IDLE
[CPU3] dump_task:       3     3     3   0 FIFO     Kthread N-- Assigned<PHONE_NUMBER>000000 0x402da030     16336       368     2.2%    CPU3 IDLE
[CPU3] dump_task:       4     4     0 192 RR       Kthread --- Waiting Semaphore<PHONE_NUMBER>000000 0x402e0b00     16288      1264     7.7%    hpwork 0x402c3f70
[CPU3] dump_task:       5     5     0 100 RR       Task    --- Waiting Semaphore<PHONE_NUMBER>000000 0x402e5140     16304      2096    12.8%    nsh_main
[CPU3] dump_task:      22    22     1 100 RR       Task    --- Waiting Semaphore<PHONE_NUMBER>000000 0x4036e4e0     16256      2160    13.2%    ostest Arg1 Arg2 Arg3 Arg4
[CPU3] dump_task:     122    22     3 128 RR       pthread --- Running<PHONE_NUMBER>000000 0x403863b0     16336      3680    22.5%    ostest 0x402a4794 0x2
[CPU3] dump_task:     123    22     2  64 RR       pthread --- Waiting Semaphore<PHONE_NUMBER>000000 0x4038a3c0     16336      1808    11.0%    ostest 0x402a4608 0x3
[CPU3] dump_task:      15    15     0 100 RR       Task    --- Waiting Semaphore<PHONE_NUMBER>000000 0x40369db0     16304      1920    11.7%    ostest

@qinwei2004 will take a look tomorrow.

@masayuki2009
I cannot reproduce with ubuntu 22.04.2 LTS and the default qemu  6.2.0
Do you build qemu 7.1 and reproduce this??
So could you give me your build configure with qemu? I want to build qemu like your and reproduce it
thanks

@qinwei2004

I cannot reproduce with ubuntu 22.04.2 LTS and the default qemu 6.2.0
Do you build qemu 7.1 and reproduce this??
So could you give me your build configure with qemu? I want to build qemu like your and reproduce it

Yes, I build qemu-7.1 on ubuntu 20.04.6 LTS (x86_64).
In the build.log, I can see
# Configured with: '/home/ishikawa/opensource/QEMU/qemu-7.1/configure' '--target-list=riscv64-softmmu,riscv32-softmmu,aarch64-softmmu,arm-softmmu,i386-softmmu,x86_64-softmmu' '--enable-kvm'

Also, I've been using the following arm gcc to compile NuttX
$ arm-none-eabi-gcc --version
arm-none-eabi-gcc (Arm GNU Toolchain 12.2.MPACBTI-Rel1 (Build arm-12-mpacbti.34)) 12.2.1 20230214
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@masayuki2009 @xiaoxiang781216
Sorry for lately reply
I check this issue, for SMP, the CONFIG_ARCH_FPU shouldn't enabled, but with configure, I can see
CONFIG_ARCH_FPU=y
the FPU context switch for FPU is little sophisticated and need to be support
for the present, you need to disable the option in boards/arm64/qemu/qemu-armv8a/configs/nsh_smp/defconfig
CONFIG_ARCH_FPU=n
I check with myself qemu(6.2.0 and 7.2.2) and not reproduce the issue again.
please check with your environment, if you confirm the issue is fix, I will push a PR to fix it

@qinwei2004
I confirmed that the following change can avoid the crash on qemu-7.1
--- a/boards/arm64/qemu/qemu-armv8a/configs/nsh_smp/defconfig
+++ b/boards/arm64/qemu/qemu-armv8a/configs/nsh_smp/defconfig
@@ -5,6 +5,7 @@
 # You can then do "make savedefconfig" to generate a new defconfig file that includes your
 # modifications.
 #
+# CONFIG_ARCH_FPU is not set
 CONFIG_ARCH="arm64"
 CONFIG_ARCH_ARM64=y
 CONFIG_ARCH_BOARD="qemu-armv8a"

@masayuki2009
Thank for your suggestion, it seem fvp for armv8r has seem question
I will submit a PR to fix this issue.
@zyfeier


ValueError: Unknown level: 'NULL'

It looks like the latest docker image isn't starting correctly :
[14:16:22] INFO: Starting Matter Server...
curl: (6) Could not resolve host: supervisor
[14:16:22] ERROR: Something went wrong contacting the API
curl: (6) Could not resolve host: supervisor
[14:16:23] ERROR: Something went wrong contacting the API
curl: (6) Could not resolve host: supervisor
[14:16:23] ERROR: Something went wrong contacting the API
[14:16:23] INFO: Successfully send discovery information to Home Assistant.
Traceback (most recent call last):
  File "/usr/local/bin/matter-server", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/dist-packages/matter_server/server/__main__.py", line 72, in main
    logging.basicConfig(handlers=handlers, level=args.log_level.upper())
  File "/usr/lib/python3.9/logging/__init__.py", line 2018, in basicConfig
    root.setLevel(level)
  File "/usr/lib/python3.9/logging/__init__.py", line 1417, in setLevel
    self.level = _checkLevel(level)
  File "/usr/lib/python3.9/logging/__init__.py", line 194, in _checkLevel
    raise ValueError("Unknown level: %r" % level)
ValueError: Unknown level: 'NULL'

Are you running the docker image directly, bypassing HAOS ?
Because we did not specifically account for that and the current docker image is meant to be used for the Matter add-on

That's right yes, it's just a container running next to HA, it's not HAOS

Well, the docker image is not meant to be used standalone as it is created for the Home Assistant supervisor. For example that is where the config file is provided from. It maybe works by accident today and breaks tomorrow. Best is to create a dedicated docker image to run standalone.
At this time we are really busy with the basic stuff and polishing the Matter server and integration for daily usage, focusing on the add-on as first step and we might provide a standalone container later but if you want to pick up the glove, you can look at the add-on structure to find out what's missing for the standalone container.


fix inconsistency package dependendy of poetry install

I've started a manual CI run for this PR.  Thanks for the changes!


Create custom user account on run

From the comments section in DockerHub: https://hub.docker.com/r/microsoft/mssql-server-linux/
Create a customer user admin login with environment variables for added security.

FYI - We released CTP 1.4 today.  This release of the mssql-server-linux image now includes the mssql-tools package (sqlcmd and bcp) in it.
Executing sqlcmd as part of the entrypoint.sh script can be used for this kind of scenario for now.  Since this is such a commonplace requirement we want to make it easier in the future, but sqlcmd will provide a reasonable option until then.

Hi, I tried to use the tag CTP 1.4 but sqlcmd is not found in terminal. Thanks

Hi, I saw your demo https://github.com/twright-msft/mssql-node-docker-demo-app, and i was able to use the sqlcmd base on your guide. Maybe we could include this code in creating the docker image, in order for the sqlcmd be visible globally?
echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bash_profile echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bashrc source ~/.bashrc

We've run into problems in the past with conflicting file names, in particular the rather generic name 'bcp'.  So, for now at least, we recommend pointing to the tools using the fully qualified path.

This is my Dockerfile for building a custom image based on the ctp1-1:
RUN apt-get update &&
apt-get install -y curl apt-transport-https &&
curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add - &&
curl https://packages.microsoft.com/config/ubuntu/16.04/prod.list | tee /etc/apt/sources.list.d/msprod.list &&
apt-get update &&
apt-get install -y mssql-tools unixodbc-dev &&
locale-gen en_US en_US.UTF-8 &&
ln -sfn /opt/mssql-tools/bin/sqlcmd* /usr/local/bin/sqlcmd &&
ln -sfn /opt/mssql-tools/bin/bcp* /usr/local/bin/bcp

OTOH, why not make the image users even easier
MySQL images, for example, are configurable allow to create extra user via environment
MYSQL_USER: joe
MYSQL_PASSWORD: pass123

Why not provide similar hook into the mssql image initialization?

I don't think anyone is looking into this issue anymore.

@pawelmaslyk They should have closed it then. @twright-msft?

We still plan on adding this.  Just havent gotten to it yet.

Any update on this please

Any news on this?


Excludes specified in FLAGS don't work

It appears that the action is not honoring "--exclude" flags in the FLAGS value.  Neither the default --exclude=".*", nor custom patterns defined with --exclude in a FLAGS override are excluding any files.
Using this workflow step:
    - name: Deploy to WPEngine
      uses: wpengine/github-action-wpe-site-deploy@v3
      with:
        WPE_SSHG_KEY_PRIVATE: ${{ secrets.WPE_SSHG_KEY_PRIVATE }}
        WPE_ENV: ${{ inputs.wpe-env }}
        SRC_PATH: ${{ inputs.src-path }}
        REMOTE_PATH: ${{ inputs.remote-path }}
        PHP_LINT: TRUE

and providing no override for FLAGS, here is snipped output from the workflow in github actions. (I've replaced the environment and plugin names here):
Run wpengine/github-action-wpe-site-deploy@v3
  with:
    WPE_SSHG_KEY_PRIVATE: ***
    WPE_ENV: ourenvironment
    SRC_PATH: ourplugin/
    REMOTE_PATH: wp-content/plugins/ourplugin/
    PHP_LINT: true
    FLAGS: -azvr --inplace --exclude=".*"
     MULTIPLEX SSH CONNECTION ESTABLISHED !!!
OpenSSH_9.3p2, OpenSSL 3.1.3 19 Sep 2023
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: multiplexing control connection
debug1: channel 1: new mux-control [mux-control] (inactive timeout: 0)
debug1: channel 2: new session [client-session] (inactive timeout: 0)
debug1: Sending command: rsync --server -vlogDtprze.iLsfxCIvu --inplace . sites/ourenvironment/wp-content/plugins/ourplugin/
debug1: mux_client_request_session: master session id: 2
sending incremental file list
./
.eslintrc
.prettierignore
.prettierrc
.stylelintrc
... [skip remaining lines] ...

Note that:

the debug output reports the FLAGS value as -azvr --inplace --exclude=".*". This should exclude all files starting with a dot.
The debug output shows the command rsync --server -vlogDtprze.iLsfxClvu --inplace is being called. if that's the rsync call that is transferring files from the action runner to WPE, it is not including the flags in FLAGS.
The rsync "incremental file list" that follows includes files that should be excluded by the default flag --exclude=".*" (including .eslintrc, .prettierignore, etc).

Those files are indeed transferred to the WPE host; so even if that debug output is misleading and describes some other rsync operation that is happening, one way or the other the files that should be excluded are included.
To reproduce
Define a github actions workflow to deploy a particular source directory to a particular destination.  Either define a FLAGS value with custom --exclude flags, or leave it as the default value. Note that files in the repository that should be excluded are sent to the WPE host.
Expected behavior
Including an --exclude=<pattern> flag in FLAGS should prevent files matching the pattern from being sent to WPE.
Version information

Action version: v3

One more data-point: excluding using --exclude-from=<file> rather than --exclude=<pattern> works as expected. Looks like there may be something in the way rsync is invoked with the flags that causes --exclude flags to get ignored/pre-empted.

Thanks for the report! I was able to reproduce the behavior you're seeing and traced it back to the quotes around the default --exclude=".*" flag.
I'm not sure when it will be released, but I plan on working on the fix today. In the meantime, you can override the default flags by setting your own - just remove the double quotes that were in the --exclude flag and the dotfile exclusion should work.
- name: GitHub Action Deploy to WP Engine
      uses: wpengine/github-action-wpe-site-deploy@v3
      with:
        WPE_SSHG_KEY_PRIVATE: ${{ secrets.WPE_SSHG_KEY_PRIVATE }}
        WPE_ENV: ${{ inputs.wpe-env }}
        SRC_PATH: ${{ inputs.src-path }}
        REMOTE_PATH: ${{ inputs.remote-path }}
        PHP_LINT: TRUE
        FLAGS: -azvr --inplace --exclude=.*

This should be fixed. I've spent a literal day to just figure out that all my --exclude rules do not work because of the quotes. Also, it looks like both double- and single-quotes are broken. I've made several --include and one --exclude rules with quotes but my pipeline just ignored everything, until I removed them.

A workaround I've used: instead of using --exclude directly within FLAGS, use --exclude-from with a filename.  That helps avoid all the quoting issues for the excluded globs themselves, since they're isolated to the file.  For convenience, you can write the contents of that file in the pipeline. Example:
jobs:
  deploy:
    steps:
      - name: Write excludes file
        run: |
          cat << EOF > .deploy-wpengine-ignore
          .*
          package.*
          tests
          README.md
          EOF
      - name: Deploy to WPEngine
        uses: wpengine/github-action-wpe-site-deploy@v3
        with:
          FLAGS: -azvr --inplace --exclude-from=.deploy-wpengine-ignore

Well, yeah, this is a way to do it. The main problem here is a documentation showing the examples with quotes. That's a little bit misleading.

In addition to the docs update in #94, a complete fix for this issue was released in v1.0.4 of the wpengine/site-deploy image. It has been released in v3.2.6 of this action. You will get this automatically if you're running wpengine/github-action-wpe-site-deploy@v3.
Quotes (both single and double) are now automatically stripped from FLAGS. Only use them when you have a flag that contains whitespace in its value.
For example, you need single quotes for the --filter flag in the following:
 - name: Deploy to WPEngine
      uses: wpengine/github-action-wpe-site-deploy@v3
      with:
        ...
        FLAGS: -azvr --inplace --delete --exclude=.* --filter=':- .gitignore'

Full details of the fix are available in https://github.com/wpengine/site-deploy/pull/32.
More documentation updates coming in #105.

The debug output shows the command rsync --server -vlogDtprze.iLsfxClvu --inplace is being called. if that's the rsync call that is transferring files from the action runner to WPE, it is not including the flags in FLAGS.

This is not the call that transfers files from the action runner to WPE. It's something rsync does under the hood to start the rsync process on the receiving end.
The command that's responsible for initiating the sync wasn't previously available in the action's output. However, it has been added in v3.2.6 of the action. You should now see a line in your action's output that starts with + rsync. That's the full rsync command as the action runner sees it.
+ rsync '--rsh=ssh -v -p 22 -i /github/home/.ssh/wpe_id_rsa -o StrictHostKeyChecking=no -o '\''ControlPath=/github/home/.ssh/ctl/%C'\''' -azvr --inplace --delete '--exclude=.*' --exclude-from=/exclude.txt --chmod=D775,F664 tests/data/plugins/test-plugin wpe_gha+myenv@myenv.ssh.wpengine.net:sites/myenv/wp-content/plugins/

Additionally, we've added some more information to the action log to help with debugging flags. It looks something like this:
Deploying your code to:
	myenv
with the following 4 rsync argument(s):
	-azvr
	--inplace
	--delete
	--exclude=.*


Resource/events

Closes #5
Added event resource.

One last thing, merge develop into this branch.


Add a boolean value on whether to use direct channel callback for all ios versions

Add a new boolean value that control whether to use direct channel callback for all iOS versions. This partially resolves the issue #1409.
We are separating the callback between apns and direct channel. Right now for iOS 10 and above, direct channel message delivered at FIRMessagingDelegate, while for iOS 9 and below, they were delivered at UIApplicationDelegate. To not break existing behavior, if user likes to receive direct channel callback using FIRMessagingDelegate instead of UIApplicationDelegate for all ios versions, they can now set the boolean value useMessagingDelegateForDirectChannel to true.

Please fix travis issue:
$ ./scripts/check_whitespace.sh
Firebase/Messaging/Public/FIRMessaging.h:434:#pragma mark - FCM Direct Channel
ERROR: Trailing whitespace found in the files above. Please fix.

One more change needed. I noticed 'GoogleUtilities/Environment' is missing from the podspec dependencies in https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMessaging.podspec. It's working because of transitive dependencies, but it should be added to make the dependency explicit.


adding changes for calico site branch deployment - master

Description
related to #3729. Adds changes for branch deployment for master branch
Unlike other branches master will have proxy rules and all other contexts for deployment as future releases will be cut from the master and they would need all the contexts (production, branch-deploy etc)
Note: Ideally the base branch for this PR should be a nightly branch which keeps track of master (this is to have a fall back as explained in roll out plan in #3729). Base would be updated as soon as new branch is cut.

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!


Iphone 6 10.2 Snapchat Crashes phone Randomly (Almost every time)

Snapchat Just keeps crashing my IPhone, Only in Jailbreak mode. I cant find a fix. Any ideas?
NO SNAPCHAT TWEAKS ARE INSTALLED
I read the issue posting guidelines.

delete snapchat tweaks

what tweaks you have?

List your tweaks installed

#162
This is not an issue regarding this jailbreak. It could be because you have tweaks installed that modifies Snapchat, and it doesn't support the newest version of Snapchat.
Close this issue. This is not a concern whatsoever.

installed:

Bigboss Icon set
Catalyst
Cydia installer
Cydia Substrate
Cydia Translations
DarkMessages (IOS 10)
Debian Packager
Horseshoe
HYI Repo Icons
Lithium Ion
LockScreenGestureCleanUp
Noctis
NoMoreExpire
Patcyh
Peek-a-boo
Power Tap
RoundDock
Substrate Safe Mode
Tape Archive

I have no tweaks modifying Snapchat

Then we have a problem. When you said "crash", do you mean your phone reboots or just the application?

Phone all together The screen like cuts off, and then the apple logo appears, and jailbreak state is not initiated.

This is weird. I have Snapchat and a jailbroken iPhone. What doesn't make sense is how your phone crashes and mine doesn't.
Are you on the latest jailbreak? If so, which iPhone are you using?

IPhone 6, Cydia Version: Cydia64_1.1.28~b9 (en-us)

One thing I know is different between both of our devices is:

Mine has a notification center malfunction, where no text shows up in the notification with an exception of the app name. ( Exempt messages or system notifications, such as "ICloud backup alerts")

What do you know? We have the same device AND we are on the same Cydia version! :smile:
In this case, I don't know why Snapchat would crash your phone. Are you using the Yau beta 7 jailbreak or something older?
Also, thanks for introducing us to Lithium Ion. I can't believe I never found such a tweak that was so awesome with the battery icon (which is the kind of thing I would say when I have the heartbeat animation for a loading animation).

I was just about to ask that, Do I need to update the Yalu102 application, and if so .. How do I do that on a Windows based machine (Win10)

First, you need to download the IPA file from @kpwn's official website.
Use Cydia Impactor to install it. Just extract all the files from the Impactor zip folder into its own little folder (that means everything, including the dlls and stuff), and then run the program.
Just drag the ipa file onto Impactor, and put in your credentials. The credentials are sent to Apple, and nowhere else (still suspicious on that, but not 100% worried due to 2-factor authentication).

would you be able to link me to the IPA file. I have looked and looked for Kpwn's website, and All I'm finding is some school in the netherlands

Go here.
By the way, I AM LOVING LITHIUM ION!

Lithium Ion, must have tweak no doubt. and wow... it helps to know that "ipa (cydia impactor)" means the ipa and not the download link to cydia impactor.., I will check to see if the beta I was on was the problem. Conflicting with Cydia Substrate.

I would also like to say a quick thanks @tangalbert919 , for helping me so far with this issue.

Huston! We have a FIX. @tangalbert919 your an amazing person, I have followed you on GitHub. ps my snapchat username is "DontAskMeIt". (Just in case you wanna add me ;)) #SOLVED

Did you ever find out how to fix this? I'm still having issues with mine.


[D] @safe optimization

PR prepared by Bruce Carneal.
Some code separation: added @safe part.
Also I've added LDC 1.36-beta1 in the Dockerfile

@jinyus can we please also try to run this PR with previous version of LDC, that currently used (1.34)?
Because I'm not sure that regression problem was solved..

Main: 12.92 ms | 145.65 ms | 1.18 s
Seems regression in 1.35 was fixed.


Skipping domain when evaluating cookie value breaks the cookie

The reason is this line. I have the following poutput when domain is not specified:
user_name=serguey%20kulikov;expires=Thu, 16 Jun 2016 06:52:00 GMT;path=/false;

As you can see, joining an array containing false leads to this. In fact, now I have to provide default path & domain values to avoid this issue.
@andreasonny83 what do you think?
UPD: will create a PR to fix that, we only  need to filter array before  joining.

What is your htlm for that?

["_bi-cookie-global_language", "=", "en", ";expires=Thu, 16 Jun 2016 07:38:31 GMT", ";path=/", false, "", "", ";"]

Where false stands for empty domain.
Applying filter(Boolean) excludes this false value.

Right, I will make that fix ASAP and will introduce unit tests as well to make sure everything works before releasing new versions.
However I was curious about the way you're trying to set that cookie in your project. Are you using the Html attributes or calling the js method?

Ah, undestand. Now we are using js method. It is called by wrapper component, which has an observer which looks like this:
                _valueChanged: function (value) {
                    // try to receive and decode current value
                    var currentValue = this._parseValue(this._getCookie());
                    if (value !== currentValue) {
                        this.$.cookie.value = encodeURIComponent(value);
                        this.$.cookie.createCookie();
                    }
                    // notify global store for propagating changes to data binding
                    this._updateStorageValue();
                }

Thanks again for your precious help. I will fix that during the day and release a new version.

fixed in v1.1.1


Port 80 should be published to the port 80 of the containers

What does this PR change?
Port 80 should be published to the port 80 of the containers. 8080 is squid and accessing it directly will return error.
Test coverage

No tests: add explanation

No tests: already covered

Unit tests were added

[ ] DONE

Links
Issue(s): #

[ ] DONE

Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)
Before you merge
Check How to branch and merge properly!

CC @Bischoff


auto convertion from tui to web ui

I was just thinking how awesome it would be to have an automatic generation feature that could convert Bubbletea UI into web UI. Are there any ongoing efforts or community-driven repositories focused on accomplishing this type of task ?

Hey @nevzatseferoglu this is definitely something I've seen asked more than once. I'm going to convert this to a discussion. There's an existing discussion about WASM support which aims to accomplish a similar goal of making Bubble Tea available in the browser https://github.com/charmbracelet/bubbletea/discussions/300


add a middleware to record the status code return by an http server

Jessica was working on something super similar to this, but it seems like it might end up duplicating logic -- is there a way we can combine the two? (or is that he goal and I am not caught up)

I think we both put up our PRs at around the same time 😅
Combining them is probably what we want, but we might want to get this merged in first and then it can be worked in with @JessicaGreben 's PR since this is for the current metrics while Jessicas work is on a different branch to add prometheus stuff?

@pacejackson Agree, merging this first seems good then I can add to my PR. In the meantime, I'm going to copy your changes into my PR #451 and test it out to see how it works. Will report back.


Please fix

--> evalphobia/logrus_fluent/config.go:49:8 : unknown field 'Async' in struct literal of type fluent.Config

Ok, thank you.

Neither of these solutions worked for me. I tried both the latest fluent-logger-golang (1.3.0) and using version 0.4.0 of logrus_fluent. I am using dep to deploy in docker. Can you offer a more detailed explanation of the fix, please?

@CreativeCactus  You should use the version combinations below,

fluent-logger-golang:v1.3.0~ & logrus_fluent:v0.5.0~
fluent-logger-golang:~v1.2.1 & logrus_fluent:~v0.4.0


[bug/issue] Locator option Has does not work correctly

I have 2 points about locators.

When we create new Locator using Page we can pass PageLocatorOptions. But now if we pass Has option it does not work correctly and returns an error  with message "Malformed token".

For example, this code will return the error because of wrong selector concatenation.
  inputLocator, err := page.Locator("input[name='some']")
  require.NoError(t, err)

  listLocator, err := page.Locator("ul", playwright.PageLocatorOptions{Has: inputLocator})
  require.NoError(t, err)

   text, err := listLocator.InnerText()

The Locator.Locator method does not have a LocatorLocatorOptions parameter. It would be very useful to add the ability to use this option

If this issue is fixed, I would close it ✌🏻


[FLINK-10229] [sql-client] Support listing of views

What is the purpose of the change
This pull request support listing of views
Brief change log

Support sql SHOW VIEWS

Verifying this change
This change added tests and can be verified as follows:

SqlCommandParserTest#testCommands to test command parsing
LocalExecutorITCase#testListViews

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @fhueske and @twalthr

@walterddr and @hequn8128 Can you help me to review this PR? thanks.

@yanghua Thanks for your PR. I will take a look this weekend. :-)

@hequn8128 thanks for your suggestion, I have refactored this PR, can you review it again?

@twalthr Would you like to review this PR? thanks~

@hequn8128 What about this change?

Hi @yanghua , thanks for your update. The PR looks good. +1 to merge from my side.
Best, Hequn

hi @twalthr , hequn helped me to review this PR, does it look good to you?

hi @fhueske can you review this PR? Thanks.

hi @twalthr , hequn has reviewed this PR, can you make a deterministic review?

Have fixed some conflicts and rebased this PR. It has stayed for more than half a year, hope for reviewing. cc @twalthr

leaving...


Update |challstr| to use updated parameters.

First, the commit should indicate that this is actually a documentation change.
Then, I'm fairly sure the upkeep action is still being used when you're already logged in...

The main difference is that getassertion will also get assertions for unregistered usernames, while upkeep just gives it to you for the currently logged-in user. Both work, but if you're going to do that, at least properly document the difference.

Also what Joim said


Fix health endpoint output

Resolves #1673
What is being addressed
After re-enabling the health check again, there are two things which I missed that this PR fixes:

Change the health endpoint output to return the real status (but still always returns 200)
Enable the unit tests again

When reading the PR description, I initially thought that this was changing the health endpoint status code. Looking at the code, it looks like this is still always returning a 200 response for the health endpoint regardless of the health of Cosmos etc - is that the case? (I think always returning 200 is a good thing, to be clear 😄 )

When reading the PR description, I initially thought that this was changing the health endpoint status code. Looking at the code, it looks like this is still always returning a 200 response for the health endpoint regardless of the health of Cosmos etc - is that the case? (I think always returning 200 is a good thing, to be clear 😄 )

You got it right, this intentionally still returns 200, just the json output has changed to reflect the true health status - meaning one can come and debug the system (but the api is still accessible, wont be shut down by Application Gateway)

/test


Implement Schnorr signatures

Rebased.

Rebased.

TODO: use context to store the batch multipliers

This is awesome, as Schnorr signatures are dead easy to understand.
But, for what purpose have they been added?

They have not been added yet :)

Separated batch validation into a separate branch. This pull request should be usable. Question for reviewers:

Enable Schnorr code by default, or hide behind a compile flag (and perhaps move to a separate include/.h file)?

@gmaxwell Added multiparty signing API.

I'm a bit concerned about using secp256k1_nonce_function_default. If you sign the same message in both ECDSA and Schnorr with the same nonce, it is possible to recover the secret key from the two signatures. So I think by default Schnorr should use a slightly different noncegen function.

@apoelstra You're not being stupid, I think.
k is the secret nonce, r is R's x coordinate, m is the message, x is the private key, h = H(m || r). x and k are unknown to an attacker.
ECDSA: s_ecdsa * k = m + r * x
Schnorr: s_schnorr = k - h * x
Or:
ECDSA: k = (m + r * x) / s_ecdsa
Schnorr: k = s_schnorr + h * x
So:
(m + r * x) / s_ecdsa = s_schnorr + h * x
So:
x = (s_schnorr - m/s_ecdsa) / (r/s_ecdsa - h)

Fixed the problem listed above by xoring the name of the signature algorithm into the message.
Added a rationale for the choice of full R validation and implicit even y.

Rebased on top of #269 and passing the signature algorithm name into the PRNG, to avoid the issue @apoelstra found above.

Rebased on top of new #269 and #282, and made compilation of Schnorr code optional (with API defined in a separate header).
@theuni Any comments on the module approach here?

Valgrind shows a bunch of errors on the test binary with this code. You need CFLAGS="-g -O0" ./configure to see them.

Almost there :) test_schnorr_end_to_end is never called (and as a consequence _sign and _recover aren't tested).

Fixed.

ACK

@sipa Looks good to me. One nit though. IMO we should also add a define in the main header that lists which modules are available. Otherwise preprocessing would be necessary to determine if schnorr functionality could be #included.
Even easier than that would be a 3rd (pushing it, i know) header with those defines, to avoid hacking up the main interface header. As a bonus, we could also stick the current config in there so that features like USE_ENDOMORPHISM, USE_NUM_GMP, etc. could be known at the application level.

@theuni Feel like writing a patch for that? I'm not sure I follow, but I
think it would be nice to have a clean extension mechanism (the two ECDH
implementations would also fit there).

Hmm, I don't know about exposing implementation details in the headers. I
jist thought: if you enable the Schnorr module, the schnorr header file is
installed, otherwise it isn't... no preprocessing needed.

@sipa There's no way to tell if it's installed without preprocessing though, you'd just "#include secp256k1_schnorr.h" and hope for the best.
I took a quick stab at it here: https://github.com/theuni/secp256k1/tree/212
If you decide to go this route, since the config details become part of the api, we'd need to namespace/cleanup their values.
Of course, you could also just take a subset of this and only expose the module details, leaving the rest as it is.

Well, duh. But how is that different from doing an include #include <gmp.h>
and hoping that that libgmp is installed?
I would really like to avoid having the public API expose implementation
details. I'd rather just see them as two separate APIs that happen to be
implemented in the same library.

@sipa Because when you 'apt-get install libgmp', you know you can "#include <gmp.h>". But if I apt-get install libsecp256k1, I have no idea what it contains. Using the existence of a file is shaky at best, as it'd be very easy to hit the system file in /usr/include when building against another or a cross build.
No problem if you don't want to expose implementation details, but I still think the user needs some explicit way to know what optional apis are available.

@theuni What would an application do with the knowledge that an extra API is available? If it needs it, the build will fail (at link time or at compile time), if it doesn't, it doesn't care...

@sipa Just as libsecp256k1 falls back to internal implementations if gmp isn't usable, an application could do the same if libsecp256k1_foo feature isn't available.
But it's really not worth the argument, and certainly not worth holding up this PR.

@theuni Right, there may be optional behaviour. But that's something you'd typically check at configure time, which can try to compile.
I guess the fundamental question I have is: why can you trust that the contents of a file on your disk corresponds with the library installed, when you can't trust the presence of the file corresponding to it.

@theuni Ok, one other question: when you don't specify --enable-module-schnorr, the schnorr files don't get included in "make dist" I think. Is that something you'd typically want?

@sipa all files needed to build all configs should be included in the dist tarball. From a quick check, that's currently working as expected:
./autogen.sh
./configure
make distdir # same as 'make dist' and extract tarball
cd libsecp256k1-0.1
./configure --enable-module-schnorr
make

Before merge can you add bench_schnorr_verify to .gitignore?

Also I think you need to change the last line of travis.yml so that the value of $SCHNORR actually affects configure.

Rebased.

@apoelstra Nits addressed.

Thanks! Tested ACK.

is there anyway to use schnorr combined pubkey in a standard p2sh script?
I assume the schnorr sigs are different so OP_CHECKSIG wont work, but if we can assume externally coordinated reveal on secret script, I am hoping there is a way to achieve this as a combined pubkey can be created, but I cant see how to get a script verifiable value before the signature. Maybe there is a way to cooperatively construct a combined privkey that can be used to sign?

I believe schnor is planned for the first segwit upgrade. It will require a new checksig opcode and a soft fork.

well a new schnorr_sig opcode would make this all too easy :)
that is what I am adding now but would be nice to get this on the bitcoin side too

@jl777 Unsure what you mean. Schnorr signatures are not compatible with ECDSA at all, and needs different signing and verification code. Further, Bitcoin scripts that do not use any digital signature are inherently insecure (if there is no secret information being verified, miners can steal all the coins once they see a spend). Thus, indeed, the only way is using a new opcode.

it would be combined with a normal signature: OP_HASH160 <hash(sharedsecret)> OP_EQUALVERIFY <normal_pubkey> OP_CHECKSIG
granted the protection from just the normal_pubkey OP_CHECKSIG isnt as much as full verification, but if there was a way to offchain calculate a schnorr sig based sharedsecret equivalent, then I think it would work.
problem is I dont see a way to know ahead of time any value that a group signature would create. The combined pubkey appears to be a standard pubkey, but without any normal privkey. Maybe there is a way for a set of nodes to create onetime use keypairs and somehow create a combined privkey that can be used with the combined pubkey.

You seem to be describing a normal signature with a hashlocked secret. Where does Schnorr come in?

the schnorr would come in offchain, so a group can do larger scale MofN between themselves
was hoping there was a way to generate some sort of sharedsecret equivalent among the participants so that if each member of the group validates the schnorr combined sig, they release their portion of the sharedsecret.
using shamir's shared secret that each of the participants have and release only if they are satisfied, comes really close to being the hashlocked secret to use. The problem is we cant have any single node to know the secret that is being shamir'ed.
maybe some sort of oblivious transfer method could be used, but this is getting to where I am not comfortable as I dont know of any C libraries for that.
So the constraints are that each member of the group can directly run the schnorr lib, they can coordinate and precalculate any sort of magic value, but ultimately a hashlocked bitcoin tx needs to be used