added a sample workflow for uat test

Issue #, if available:
Description of changes:
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Checklist:

[ ] Updated the README if applicable
[ ] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] If your code makes a remote network call, it was tested with a proxy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please describe the changes and how were they tested


WIP: x

Please add a meaningful description for your change here

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

accidentally created PR to beam master, its in progress and it was only for testing purposes


New ripper request: Miles81.com

Hi, I think it´d be really great if we were able to download complete comics from miles81.com :)

Please request in #38. @cyian-1756 Please close this


[GSoC] OPT model quantization

This is a part of issue #832

It seem test is failing due to timeout, which is expected since OPT350m model is quite massive.

Thank you for your contribution. Before we do the review please do the self-check first (tick the item when it's done):
* [x]  each function is described by docstrings and type hints

* [x]  notebook contains explicit descriptions and explanatory diagrams

* [x]  the notebook doesn't use any data (image, video, etc.) that is not CC4.0 licensed

* [x]  there is a README.md file in consistent style (look at other notebooks)

* [x]  the notebook is added to the main README

* [x] there are no grammar, punctuation or typo issues (use any free tool for that e.g. Grammarly)

* [x]  there are no committed files besides notebook and readme (please use images or videos from data dir)

* [x]  your PR doesn't change any other notebooks

* [x]  all CI checks passed

We are aware of your timeouts, please check if there are no more issues.

Thank you, we will review it when we have some resources. Please note we're reviewing PRs in FIFO style.
Note: The PR must be opened before April 4th, it doesn't have to be reviewed or merged.

I'm closing this due to inactivity for a long time. Nevertheless, thank you for contributing and applying for Google Summer of Code. We encourage you to consider GSoC 2024 as well :)


Patch release of the azure-communication-identity[1.4.6]

Description
azure-communication-identity patch release - 1.4.6

included the latest changes merged to the main branch:

regenated service layer with sync stack enabled
code coverage improvement changes

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/azp run java - azure-communication-identity - tests


Blog app - integration specs for views and fix n+1 problems

The following tasks were accomplished in this milestone.

[x] the N+1 problem is solved when fetching all posts and their comments for a user.

Before

After

Integration specs

[x] Used Capybara to write integration tests for each view in your project.

User index page:

[x] I can see the username of all other users.
[x] I can see the profile picture for each user.
[x] I can see the number of posts each user has written.
[x] When I click on a user, I am redirected to that user's show page.

User show page:

[x] I can see the user's profile picture.
[x] I can see the user's username.
[x] I can see the number of posts the user has written.
[x] I can see the user's bio.
[x] I can see the user's first 3 posts.
[x] I can see a button that lets me view all of a user's posts.
[x] When I click a user's post, it redirects me to that post's show page.
[x] When I click to see all posts, it redirects me to the user's post's index page.

User post index page:

[x] I can see the user's profile picture.
[x] I can see the user's username.
[x] I can see the number of posts the user has written.
[x] I can see a post's title.
[x] I can see some of the post's body.
[x] I can see the first comments on a post.
[x] I can see how many comments a post has.
[x] I can see how many likes a post has.
[x] I can see a section for pagination if there are more posts than fit on the view.
[x] When I click on a post, it redirects me to that post's show page.

Post show page:

[x] I can see the post's title.
[x] I can see who wrote the post.
[x] I can see how many comments it has.
[x] I can see how many likes it has.
[x] I can see the post body.
[x] I can see the username of each commentor.
[x] I can see the comment each commentor left.

@KayLemba Thank you very much !!


Sort Default Deep History table by Start Time

Currently Deep History is sorted by Build ID on initial loading of that view.
In certain cases we have Build IDs that are greater than the most recent runs in the TRSS DB and they end up sorted at the top of the view.  I believe this arises from the fact that we have a nightly pipeline and a release pipeline that launch these jobs / targets and have different initial build IDs.
This issue is to propose to have the initial load of the Deep History view, to sort by Start Time.
Note:  The user can choose to sort by Build ID if they want, so we are not removing the ability to view with that sort order.

i can work on it

I think we can close this issue

Closed via https://github.com/adoptium/aqa-test-tools/pull/887
Thanks @Sangyoon21 !


Revise 0,0-hje rail

Instead of a linear rail, it should be split by some compliant junctions to reduce the number of files that must be edited and the complexity of inserting new destinations on that rail.

Alternatively, it could have just one compliant switch on each end of the rail, to somewhat reduce the distance traveled, while significantly simplifying the switch flow

I chose to make every single parasite switch a compliant switch. This is the worst option, but it makes things better.


Use hash set for visited nodes in HNSW search? [LUCENE-10404]

While searching each layer, HNSW tracks the nodes it has already visited using a BitSet. We could look into using something like IntHashSet instead. I tried out the idea quickly by switching to IntIntHashMap (which has already been copied from hppc) and saw an improvement in index performance.
Baseline: 760896 msec to write vectors
Using IntIntHashMap: 733017 msec to write vectors
I noticed search performance actually got a little bit worse with the change – that is something to look into.
For background, it's good to be aware that HNSW can visit a lot of nodes. For example, on the glove-100-angular dataset with ~1.2 million docs, HNSW search visits ~1000 - 15,000 docs depending on the recall. This number can increase when searching with deleted docs, especially if you hit a "pathological" case where the deleted docs happen to be closest to the query vector.

Migrated from LUCENE-10404 by Julie Tibshirani (@jtibshirani), updated Aug 07 2022

While exploring other things, I noticed this: https://github.com/apache/lucene/pull/12789
There is definitely room for improvement here. We should test:

when to use Sparse vs. Fixed bit set
At what point of percentage exploration should we even drop down to a IntHashMap. Though I am not sure that will ever be worth it when compared against a fixed bit set.


962 - fix(attribute): use attributes manager

use attributes manager to simplyfy attributes syncing code
closes: 847

@treshugart this is now pretty clean and ready for merge.
Please review in detail.


[ms-quic] update to v2.3.5

Library name
ms-quic
New version number
v2.3.5
Other information that may be useful (release notes, etc...)
homePage: https://github.com/microsoft/msquic

Closed as fixed by PR https://github.com/microsoft/vcpkg/pull/39332.


How to use Lora in Diffutoon

Is there any way to use Lora
https://github.com/modelscope/DiffSynth-Studio/blob/main/examples/Diffutoon/diffutoon_toon_shading.py

Used it by adding load_lora. It would be better to have it as optional in config.
def load_pipeline(self, model_list, textual_inversion_folder, device, lora_alphas, controlnet_units):
        # Load models
        model_manager = ModelManager(torch_dtype=torch.float16, device=device)
        model_manager.load_models(model_list)
        model_manager.load_lora("models/lora/r1ge-AnimeRage.safetensors")

通过添加 load_lora 来使用它。最好在 config 中将其作为可选选项。
def load_pipeline(self, model_list, textual_inversion_folder, device, lora_alphas, controlnet_units):
        # Load models
        model_manager = ModelManager(torch_dtype=torch.float16, device=device)
        model_manager.load_models(model_list)
        model_manager.load_lora("models/lora/r1ge-AnimeRage.safetensors")

You can refer to ControlNet_unit for reference

def load_pipeline(self, model_list, textual_inversion_folder, device, lora_alphas, controlnet_units,

lora_units = [],
):

    # Load models
    ...
    model_manager.load_lora(lora_units[0]['model_path'],[i]['scale'],lora_alpha=lora_units[0]['scale'] )


⚠ Bofrost.at has degraded performance

In a398a71, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2229 ms

Resolved: Bofrost.at performance has improved in f9c5c13.


Spring Boot 3.3.2 throws AuthorizationDeniedException instead of AccesDeniedException

Hi Wim,
we are running into an issue where spring security is throwing an AuthorizationDeniedException instead of an AccessDeniedException. This exception is not handled in the io.github.wimdeblauwe.errorhandlingspringbootstarter.handler.SpringSecurityApiExceptionHandler as it does not yet exist in the spring boot version you are using. This causes the http response to be 500 instead of 403.
This is a new exception that comes with the spring boot update. Do you have any plans regarding updating your library?
Kind regards,
Bart

Thank you for your report. I see that this class is new in Spring Boot 3.3.x which means that if I want to support this, I will need to make the library compatible with that version and above only.
For now, you can manually override the response code via application.properties like this:
error.handling.codes.org.springframework.security.authorization.AuthorizationDeniedException=forbidden

Hi Wim, we tried this. It turns out we had to use "http-statuses" instead of "codes". No worries!

Ah, right! 👍


How to do custom loader?

I'm trying to do Aurelia.js HMR here Aurelia HMR.  But can't find the way to setup communication between System HMR and Aurelia loader.
Would be nice to find example for change subscription. Or how to do custom loader.

Looking to the webpack implementation, they have:
module.hot
module.hot.accept
module.hot.decline
module.hot.dispose
Do we have any similar methods or alternatives to manage the HMR module behavior?
Going to avoid such code in each modules, and make general loader, manage that's stuffs in one place. In custom loader.
"import {module} from '@hot'"
"__unload..."
Does it even possible?

I create a sample to show what am I doing aurelia-systemjs-loader.
In general I need some how trigger class methods here (loader)[https://github.com/wegorich/aurelia-systemjs-loader/blob/master/src/lib/aurelia-systemjs-loader.js#L101-L111] for example.

Lets jump on an instant messenger. One moment.

you should have received an invite to the gitter room alexisvincent/systemjs-hmr

So custom loader for systemjs doing via plugins: documentation how to, example for vue
it solves my issues with systemjs


[pytorch] Handles PYTORCH_VERSION is empty case

Change-Id: I9a8c70df7b5ca2cac39f7c652d7f0fbf6e741aa8
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1933 (a580db6) into master (bb5073f) will decrease coverage by 2.19%.
The diff coverage is 67.56%.

@@             Coverage Diff              @@
##             master    #1933      +/-   ##
============================================
- Coverage     72.08%   69.89%   -2.20%
- Complexity     5126     5685     +559
============================================
  Files           473      543      +70
  Lines         21970    25081    +3111
  Branches       2351     2713     +362
============================================
+ Hits          15838    17530    +1692
- Misses         4925     6213    +1288
- Partials       1207     1338     +131

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../cv/translator/SemanticSegmentationTranslator.java
0.00% <0.00%> (ø)

.../cv/translator/StyleTransferTranslatorFactory.java
40.00% <ø> (ø)

... and 444 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Removed sqlEncodeString function (FINERACT-854)

Refer: https://issues.apache.org/jira/browse/FINERACT-854 and #725 #723 for background.

failed due to connection error.


Arena Secrets Helper misbehaves

Mage gets a Paladin secrets due to "add a random spell to.." deathrattle. The secrets helper shows it to be a Mage secret.

yep, unfortunately, there's no hint for the "class of the secret", so the app shows you the secret from the class you're playing against


Apply projectHealth recommendations to various JVM testing deps

Did these as a single PR because they:

Required new verification metadata for bsh (used by testng).
Required new explicit lib for junit platform engine.

This addresses the following projects:

plugins-jvm-test-suite
plugins-test-report-aggregation
testing-junit-platform
testing-jvm-infrastructure
testing-jvm
test-suites-base
testing-base

@bot-gradle test this

These tests are are CI issues that can be ignored - this is ready for review

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.


Add API to check per awareness attribute value health.

Signed-off-by: Nishchay Malhotra<EMAIL_ADDRESS>Description
The PR solves issue #5230. It adds the capability of new API where one can view per awareness attribute health status. As of today opensearch only shows health for full cluster however health per awareness attribute is still not seen. Added an API today monitor the cluster availability status per awareness attribute as that would give use more information on how many shards are assigned per awareness attribute value, how many nodes are distributes per awareness attribute value etc. Follwoing things can be shown per awareness attribute value [eg rack as attribute]:

Total number of nodes per rack
Total shards per rack.
Weights given per rack if defined.
If "cluster.routing.allocation.awareness.balance" is enforced we can also predict the unassigned shards.

Issues Resolved
#5230.
Check List

[x] New functionality includes testing.
[x] All tests pass
[x] New functionality has been documented.
[x] New functionality has javadoc added
[x] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #5231 (fcdf5df) into main (831b3a0) will increase coverage by 0.10%.
The diff coverage is 58.77%.

@@             Coverage Diff              @@
##               main    #5231      +/-   ##
============================================
+ Coverage     70.97%   71.08%   +0.10%
- Complexity    58186    58353     +167
============================================
  Files          4708     4715       +7
  Lines        277558   277786     +228
  Branches      40190    40218      +28
============================================
+ Hits         197006   197468     +462
+ Misses        64444    64198     -246
- Partials      16108    16120      +12

Impacted Files
Coverage Δ

...admin/cluster/hahealth/ClusterHaHealthRequest.java
0.00% <0.00%> (ø)

...luster/hahealth/ClusterHaHealthRequestBuilder.java
0.00% <0.00%> (ø)

.../src/main/java/org/opensearch/client/Requests.java
44.64% <0.00%> (-0.82%)
:arrow_down:

.../org/opensearch/client/support/AbstractClient.java
32.38% <0.00%> (+0.08%)
:arrow_up:

...dmin/cluster/hahealth/ClusterHaHealthResponse.java
21.62% <21.62%> (ø)

...uster/hahealth/TransportClusterHaHealthAction.java
30.76% <30.76%> (ø)

...ction/admin/cluster/RestClusterHAHealthAction.java
42.85% <42.85%> (ø)

...g/opensearch/cluster/hahealth/ClusterHaHealth.java
73.54% <73.54%> (ø)

.../main/java/org/opensearch/action/ActionModule.java
98.24% <100.00%> (+0.01%)
:arrow_up:

.../admin/cluster/hahealth/ClusterHaHealthAction.java
100.00% <100.00%> (ø)

... and 475 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Changes in rest-api-spec is missing

Will Add once everything looks good on the api

API output:
{
  "clusterName" : "runTask",
  "domainHealth" : "green",
  "totalNodes" : 3,
  "totalDataNodes" : 3,
  "totalShards" : 0,
  "totalUnassignedShards" : 0,
  "totalInitializingShards" : 0,
  "totalRelocatingShards" : 0,
  "AwarenessAttribute" : {
    "zone" : [
      {
        "name" : "zone-3",
        "shards" : 0,
        "unassignedShards" : -1,
        "nodes" : 1,
        "weight" : 1.0
      },
      {
        "name" : "zone-1",
        "shards" : 0,
        "unassignedShards" : -1,
        "nodes" : 1,
        "weight" : 1.0
      },
      {
        "name" : "zone-2",
        "shards" : 0,
        "unassignedShards" : -1,
        "nodes" : 1,
        "weight" : 1.0
      }
    ]
  }
}

@gbbafna Can you please review this?


Google +

Describe the bug

Version of the integration
If you are unsure about the version check the github release here.

Add version here.

Logs

Add your logs here.

Describe the bug

Version of the integration
If you are unsure about the version check the github release here.

Add version here.

Logs

Add your logs here.

@moovy2, sorry your issue report is incomplete and impossible to derive what you meant by opening it. I ll close it for now


Pass environment to resolve function

@crisu83 I'm not sure if this is an expected behaviour or not but I think there should be name argument?

@Jalle19 Phpstan is failing all of our builds, can we drop the level back to 1?

@hungneox Arguments are lazy so the arguments should be under $config until it's actually invoked throught getArguments. Was this ok is there still an issue with this?

Rebased on master.

Pull Request Test Coverage Report for Build 283

58 of 84 (69.05%) changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.0%) to 82.02%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Execution/ExecutorExecutionStrategy.php
2
6
33.33%

src/Execution/ExecutionContext.php
2
12
16.67%

src/Execution/ExecutionStrategy.php
50
62
80.65%

Files with Coverage Reduction
New Missed Lines
%

src/Type/Definition/ResolveTrait.php
1
80.0%

Totals

Change from base Build 275:
1.0%

Covered Lines:
2217

Relevant Lines:
2703

💛  - Coveralls

Pull Request Test Coverage Report for Build 283

58 of 84 (69.05%) changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.0%) to 82.02%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Execution/ExecutorExecutionStrategy.php
2
6
33.33%

src/Execution/ExecutionContext.php
2
12
16.67%

src/Execution/ExecutionStrategy.php
50
62
80.65%

Files with Coverage Reduction
New Missed Lines
%

src/Type/Definition/ResolveTrait.php
1
80.0%

Totals

Change from base Build 275:
1.0%

Covered Lines:
2217

Relevant Lines:
2703

💛  - Coveralls

Maybe we could add StyleCI to this project?


hgctl not working with k8s 1.27.3

Sorry about that. We will fix it as soon as possible.
Now you can use helm to install hgctl to avoid this problem.

@karl-chanel hi~, please retry it with the latest hgctl:
  curl -Ls https://raw.githubusercontent.com/alibaba/higress/main/tools/hack/get-hgctl.sh | VERSION=latest bash


DEPRECATE and move this code to abaplint-abap-backend

see comments in https://github.com/abapGit/dependencies/issues/11#issuecomment-646428126
https://github.com/abaplint/abaplint-abap-backend

deprecated


Fix: TotalsComponent test failure

.children() returned null when value of element is 0. so children().text() could not be called.

Cast value to string.

LGTM

[Current coverage][cc-pull] is 100%

Merging [#203][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #203   diff @@
==========================================
  Files            21         21
  Lines           220        220
  Methods          38         38
  Messages          0          0
  Branches         22         22
==========================================
  Hits            220        220
  Misses            0          0
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [bc6513e...a850d91][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Adslot/alexandria/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Adslot/alexandria/compare/bc6513e184fca7ca55b9bb85809a2275ad84de86...a850d918012defec2ddb8d5525cff228ea535c3f
[cc-pull]: https://codecov.io/gh/Adslot/alexandria/pull/203?src=pr

LGTM 🍰

Merging 🚀


Add a way to make format-capable rules lint but not format

For rules that can both do linting and perform complex tree transformations during formatting, users may prefer having the diagnostics when linting but not automatically perform the transformation during formatting. Right now, you can only achieve this with separate configurations. It might be nice to have the ability to tell certain rules "only lint, but don't format".
The easiest way to achieve this would be to change the rules dictionary from [String: Bool] to [String: SomeMoreComplexValue] that lets the user apply different settings to different rules.
If we do this, we'd need to customize the decoding logic to preserve the original behavior of Boolean values from older configurations.
However, this might also be an opportunity to allow other customizations. For example, it's been requested before (but I can't seem to find an issue) to allow customizing the severity levels of different rules. And we could take the top-level customization structs for the rules and nest them in the rules themselves. So maybe this is worth a holistic configuration version bump to tackle multiple cleanups at once.

This sounds interesting!
I think there's a spectrum (and somewhat of a slippery slope) of customizations that we could provide:

We could provide "overrides" similar to eslint: https://eslint.org/docs/latest/use/configure/configuration-files#configuration-based-on-glob-patterns
We could also make swift-format respect .swift-format-ignore file that includes paths to ignore

I think in some other languages where formatting is more valuable (ahem JavaScript), formatting and linters became very complex, and we probably don't want that for Swift.
How do you make decisions about flexibility vs complexity vs maintenance costs in swift-format? How should we go about it in this case?

Tracked in Apple’s issue tracker as rdar://126948389


Nullable input/output with type converters

Type converters in MapType and @AutoMappr right now accept only <Object, Object> (final List<TypeConverter<Object, Object>> converters;).
While this makes sense for mappings, for type converters we want to distinguish and be able to handle nullable types, ergo the contract should probably be <Object?, Object?> and the logic behind type converters should be enhanced to support that.
This is for cases when I have a converter for String to DateTime, but the source/target is nullable. For example, it would pass source String? to that converter which ends in a type mismatch.
Implementation is straightforward, just keep in mind that:
In cases when Object is expected (source or target) and a type converter is set with Object?, this converter should handle it.
In cases when Object? is expected (source or target) and a type converter is set with Object, this converter should not be used.

I need this functionality so I took a look at the code and I think I see how this could be implemented. I want to clarify the requirements though, if possible.

In cases when Object is expected (source or target) and a type converter is set with Object?, this converter should handle it.

Does this mean if we had a TypeConverter<Object?, Object?> it can be used for all conversions?

Object -> Object
Object -> Object?
Object? -> Object
Object? -> Object?

I think anything with -> Object could be a problem for this type converter, since the function that will handle the conversion could possibly return null. I think it's reasonable for it handle both Object -> and Object? -> though, since the conversion function would be built to handle a nullable input, which can also be used to handle a non-nullable input just fine.

In cases when Object? is expected (source or target) and a type converter is set with Object, this converter should not be used.

So in this case, if we had a type converter TypeConverter<Object, Object>, it would not be usable to any conversions that have a nullable source or target? I think it could technically handle -> Object? conversions as well, since the non-null value returned by the conversion function could still be assigned to a nullable variable, but I'm not sure if it should handle it or not.
So I think maybe there is a design choice to be made. TypeConverters with nullable generics can technically handle some non-nullable cases safely, and TypeConverters with non-nullable generics can technically handle some nullable cases safely, but I guess the decision is whether they should or not. We could make them really strict so that the type and the nullability of the type has to match exactly, and that might be easier to understand for someone using the API, but it would also mean that their code might have to be more verbose to cover all the scenarios they need.
What do you think?

Hi @ekerik220 thanks for your initiative! Hmm, you are probably right. Thinking about it more, should it work like this?:
Aka choosing the solution that works the same way as if you had some converter function and manually using it in code.

TypeConverter<Object, Object>

Object -> Object
Object -> Object?

TypeConverter<Object, Object?>

Object -> Object?

TypeConverter<Object?, Object>

Object -> Object
Object? -> Object
Object -> Object?
Object? -> Object?

TypeConverter<Object?, Object?>

Object -> Object?
Object? -> Object?

So the most universal type converter that can handle every case will be TypeConverter<Object?, Object> probably?
This enhancement should be well-tested for sure.

That looks good to me! For sure, this enhancement has a lot of possible cases so all of the cases should be tested.
Do you have any suggestions on how this should be tested? I think generating and using a mapper like in the current integration tests gets us part of the way there, and maybe unit testing TypeConverter.canBeUsed would be good too.
I made a quick implementation that I think might work. No tests yet, but let me know if you think it should be done differently or if I'm missing something. #130

So released in auto_mappr 2.1.1 and auto_mappr_annotation 2.1.0 🎉

Thanks for your quick reviews and release! I'm using the feature now.  🎉


can't find any data in PP-web after deploying app with PP-agent in docker.

I have deployed an app with agent in docker and pp-web、pp-collector in VM ,but it can't work like the
file. and It can monitor an app deployed  with agent  in VM.
If the agent can't support in docker or what can I do to solve the problem.

I found this error in the pinpoint-collector log。

Hi @chuanyi-fang
From the first screenshot, it looks like UDP packets aren't reaching your collector. Please check your docker configuration to allow this.
Furthermore, your second screenshot seems to indicate that channel properties aren't being populated (which should be set during handshake). I would suggest taking a look at your agent log as well as your collector's DEBUG log to see what's going on.

@chuanyi-fang
I don't think this will help with after all this time. But just to let you know, Official Docker Image is now supported.


net/netip: ParsePrefix allows "+" in prefix length

What version of Go are you using (go version)?

$ go version
go version go1.21.3 linux/amd64

Does this issue reproduce with the latest release?
Yes, and the code is unchanged in master.
What operating system and processor architecture are you using (go env)?
(not relevant)
What did you do?
p, err := netip.ParsePrefix("<IP_ADDRESS>/+24")
What did you expect to see?
an error about the fact that "+" is not a valid character in a CIDR string
What did you see instead?
It accepted it as though I'd said netip.ParsePrefix("<IP_ADDRESS>/24").
The code is using strconv.Atoi() to parse the length, and not otherwise validating it, so it accepts anything that strconv.Atoi() would. (Which means netip.ParsePrefix("<IP_ADDRESS>/000024") is also accepted, and maybe shouldn't be, though it's not quite so obviously wrong, and that matches the behavior of net.ParseCIDR anyway.)

This somehow similar to the previous issue with IPs with leading zeros https://github.com/golang/go/issues/30999
/cc @bradfitz @rsc @ianlancetaylor

(It's not that similar... the problem there was that other software interpreted IPs with leading 0s as being a different address, whereas here, we're just accepting values that other software would reject as invalid.)

RFC 4632 Section 3.1 states that only valid prefixes are integer values, also reinforced by RFC 4291 Section 2.3:

is a decimal value specifying how many of the leftmost contiguous bits of the address comprise the prefix.

I feel like we should be more rigorous in the validation of what we accept as a valid prefix, instead of relying simply on what the Atoi function can parse.
The doc comment for ParsePrefix also assumes only valid values are the ones that conform to this:

The string can be in the form "<IP_ADDRESS>/24" or "2001:db8::/32"

cc @neild

Yeah, I think we should tighten this down and not accept + or leading zeros.
/cc @danderson

Yup, makes sense to me. I assume we're accepting + here due to strconv.ParseUint or somesuch?

Yup, makes sense to me. I assume we're accepting + here due to strconv.ParseUint or somesuch?

Exactly, we rely on strconv.Atoi to parse the bits, which allow +, - and leading zeroes.

Question now is, we want to transform these into an error or silently ignore non-digits and leading zeroes from the prefix?

This somehow similar to the previous issue with IPs with leading zeros #30999

netip.ParsePrefix("<IP_ADDRESS>/+24")

that should be an error IMHO

@bradfitz is this something can be backported?

Backports are for critical issues with no workaround, and minor releases prioritize backwards compatibility as much as possible. (https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance) This doesn't seem critical and can be worked around, so I don't think a backport is apprpriate.

@neild, it probably should be backported. It's low risk and there's no good workaround when the invalid input is a dozen layers deep in some JSON structure you're unmarshaling and expected to be well-formed.


GMM in scikit-learn deprecation 0.19.1

setup.py should pin to version 0.19.1 and not accept version above 0.20 as GMM module is removed [1]. Else the new module should be adapted.
https://scikit-learn.org/0.18/modules/generated/sklearn.mixture.GMM.html#sklearn.mixture.GMM

@dpodvyaznikov @alexandrkuvaev Guys, please, make a PR

Solved in #27


Hot module Replacement not working in new Project

Hello,
unfortunately, the HMR does not refresh any file in the starter project. When I start the project the cli shows everything like it should. The console of chrome shows that HMR is enabled. But when I save a file only the server side rendering of the cli refreshes but nothing else.
Do you have an idea?
Thanks in advance

Are you using localhost:8080 (i.e. the browser-rendered version)? Which files are you attempting to change? What's your environment (Windows, Mac, Linux, etc)?

Ubuntu 16.04
node >8
browser version
i want to change usual components like the entry one:
names of the route or changing the color css or any other change in etc..
The browser reacts to savings within the entry folder, lib folder but no other..

It seems to be, that my operating system was messing around. I have clean installed Ubuntu and now it is working lika a charm...
Thanks for this awesome Project
Cheers

np @Ahakke, glad you got it working.


Add Hyde-Y theme

I've finished another theme called Hyde-Y.
Its based on Hyde-X by Andrei Mihu. Hyde-Y is highly customizable: each block layout are stored individually. The main purpose is to allow to override every piece of the template without edit the theme's files.
The HTML pages produced are valid and easy to read in text browser (like lynx).
The CSS was rewritten from sratch and based on KNACSS micro-framework.

Added. Very nice!
I would consider to use the built-in Hugo-menus; but you have probably considered that.


Logic grid puzzle task

We propose a task to solve logic grid puzzles. This task aims to assess how large language models can combine various abilities, including text extraction, memory, spatial reasoning, and logical deduction.

@googlebot I signed it!

@googlebot I signed it!

Thank you for submitting your task! We are in the process of pairing submissions with task reviewers and will be in touch soon.

@googlebot I signed it!

@googlebot I signed it!

My commit was authored with a non-Google email (jiltang@cs.stanford.edu), which I am unable to add as an alternate email to my Google account as it claims it's already used with a Google account. Is there some other way I can sign the CLA with this email?

@googlebot I fixed it.

@googlebot I fixed it.

@GuestMaru and @mbevila You are the assigned reviewers to this task. Please provide feedback before Friday, March 26th.

Dear authors,
I'm one of the reviewers assigned to your submission.
Correctness: The task appears to pass all required checks.
Specificity: The proposed task represents an effective tool to concurrently capture several LMs capabilities, namely, text extraction, memory, spatial reasoning, and logical deduction. Task construction choices are thoroughly detailed in the README.md file.
Difficulty: Even though I have the intuition that the task could be hard enough to solve (in a few-shot or zero-shot setting), the authors may wish to provide preliminary results to highlight current LMs performance over the test set.
Not solvable by memorizing the Internet: The task is not solvable by memorizing the Internet.
Novelty: The task appears to fill a gap in coverage by BIG-bench.
Size: Test size is appropriate.
In summary, I have no major concerns with respect to this proposal. Even though the use of a finite set of attributes in a closed-domain context can be considered a limitation, if LMs won't be able to solve it, they won't be able to solve open-world puzzles either.

I liked this proposed task. I like that it bridges seamlessly natural language and explicit -- and potentially very complicated -- logical reasoning.
Correctness: The task passes all required checks.
Specificity: The README states that the task "tests large language models’ abilities to perform logical reasoning, including spatial and deductive reasoning". The provided data seems to be adequate for that.
Difficulty: I have nothing but an educated guess on the performance of existing LMs on the task. The samples seem to have relatively similar difficulty (2-5 houses). It would have been nice to have some sort of control knob on the difficulty -- the number of houses. Existing pretrained LMs have fixed width and depth, which could limit their possibility to tackle bigger problems, which require more steps of reasoning. I am not sure however how this control knob could possibly integrated within BIG-bench. So maybe you could integrate as a subtask a few larger instances (e.g. > 15 houses)?
Not solvable by memorizing the Internet: The task is procedurally generated, and thus not solvable by memorizing the Internet.
Novelty: I am not aware of anything similar in the literature, but I am not an expert. The closest thing seems to be Arithmetic Word Problems.
Size: Task size seems appropriate.

@GuestMaru and @mbevila  Please tag me with comment to "accept" or "reject" by Friday, March 26th.

@chiafullo Accept

@chiafullo Accept


What are the main differences between vue-cli3 and vue-cli4?

IMPORTANT: Please use the following link to create a new issue:
https://new-issue.vuejs.org/?repo=vuejs/vue-cli
If your issue was not created using the app above, it will be closed immediately.
中文用户请注意：
请使用上面的链接来创建新的 issue。如果不是用上述工具创建的 issue 会被自动关闭。

https://github.com/vuejs/vue-cli/releases/tag/v4.0.0
https://cli.vuejs.org/migrating-from-v3/#vue-cli-plugin-unit-jest
In short:

bump versions of underlying tools;
improved support for PWA and testing experience;
new API for plugins;
support for more package managers besides npm & yarn.


Bug: Talent Sheet touch-ups

Why?
The Talent Item has quite wonky reactive design as for now, and it most likely breaks due to localization.
How?

The styling (at least) should be reviewed and improved.
The structure of the generated psuedo-tables is not great right now, adding a new Header to every effect.

Completed a beauty pass over the sheet, it looks a lot better now.


ENH: ColumnTransformer

This PR implements a daskified column transformer.
There are two issues preventing us from just using scikit-learn's

dask DataFrame doesn't implement .shape (https://github.com/dask/dask/pull/3212)
sklearn.compose.compose._column_transformer._hstack doesn't handle dask objects (or pandas dataframes). Just sparse objects. The _hstack implemented here handles arrays (dask or numpy) dataframes (dask or numpy) and sparse matricies.

In [1]: import dask.dataframe as dd
   ...: import pandas as pd
   ...: import sklearn.compose
   ...: import sklearn.preprocessing
   ...: from sklearn.base import clone
   ...:
   ...: import dask_ml.compose
   ...: import dask_ml.preprocessing
   ...:
   ...: df = pd.DataFrame({"A": pd.Categorical(["a", "a", "b", "a"]), "B": [1.0, 2, 4, 5]})
   ...: ddf = dd.from_pandas(df, npartitions=2)
   ...:
   ...:

In [2]:     b = dask_ml.compose.make_column_transformer(
   ...:         (["A"], dask_ml.preprocessing.OneHotEncoder(sparse=False)),
   ...:         (["B"], dask_ml.preprocessing.StandardScaler()),
   ...:     )
   ...:
   ...:

In [3]: result = b.fit_transform(ddf)

In [4]: result
Out[4]:
Dask DataFrame Structure:
                   A_a      A_b        B
npartitions=2
0              float64  float64  float64
2                  ...      ...      ...
3                  ...      ...      ...
Dask Name: concat-indexed, 22 tasks

In [5]: result.compute()
Out[5]:
   A_a  A_b         B
0  1.0  0.0 -1.264911
1  1.0  0.0 -0.632456
2  0.0  1.0  0.632456
3  1.0  0.0  1.264911

Long-term, it'd be nice to remove this class entirely, but that'll probably require a lot of work upstream (scipy adopting pydata/sparse, NumPy implementing and libraries adopting __array_function__).
Medium-term, _hstack could become a staticmethod on ColumnTransformer. Then this subclass would just override _hstack, and everything else could be removed.
cc @jorisvandenbossche @ogrisel for that last point. Should I open an issue on scikit-learn to discuss that further?

Medium-term, _hstack could become a staticmethod on ColumnTransformer. Then this subclass would just override _hstack, and everything else could be removed.

cc @jorisvandenbossche @ogrisel for that last point. Should I open an issue on scikit-learn to discuss that further?

+1 for opening an issue on scikit-learn and discuss your suggestion (or even a pull request).

If you do a quick sklearn PR it could be part of the 0.20 release.

Will do quick.
On Thu, Jul 26, 2018 at 11:21 AM Olivier Grisel<EMAIL_ADDRESS>wrote:

If you do a quick sklearn PR it could be part of the 0.20 release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/315#issuecomment-408153976, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABQHIlMN2FOutbEgJOYPUBFs2erbTXH1ks5uKeyWgaJpZM4Vgwlc
.

Scikit-Learn PR at https://github.com/scikit-learn/scikit-learn/pull/11689
This passes locally for me, but won't pass here till https://github.com/dask/dask/pull/3212 and https://github.com/scikit-learn/scikit-learn/pull/11689 are done.

The upstream PRs are in. Merging later today.

Ignoring the coverage failure, since coverage isn't run against sklearn dev.


pylance works on local, but fails on remote ssh

The pylance extensions do not work on remote,  any logs or something I need to provide to debug?
My "python.languageServer" settings sets to "Default" both on local and remote, and when I disable Pylance, the autocompletion starts working.

Our issue template includes instructions on where to find logs, but the instructions are mirrored here: https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue

It's been about a month since this was opened; if this still reproduces and you can produce the logs via the instructions I linked to, I can reopen this.


TTL on connections

What kind of issue is this?

[x] Feature Request. Start by telling us what problem you’re trying to solve. Often a solution
already exists! Don’t send pull requests to implement new features without first getting our
support. Sometimes we leave features out on purpose to keep the project small.

We are using OkHttp as an HTTP client as part of a multi service application in AWS.
Our services are behind ELBs and we are using a connection pool per client (with a client per downstream service). ELBs use DNS round robing with a TTL of 60 seconds. Our idle timeout is set to 50 seconds.
We are seeing persistent connections that are in use for a long period of time. In particular we observer errors in cases where a downstream service/stack gets replaced (which will replace the ELB nodes) and those connections become stale.
In addition to errors, we are also not fully leveraging ELB nodes being scaled out, due to the fact that connections in the pool live for significantly longer than the DNS TTL and new nodes are not being used.
This is unlikely to be a problem when OkHttp is used for mobile clients as there are many clients with significantly fewer load balancer nodes, but in our case we are looking at a much smaller set of client nodes that connect to the ELB/LB nodes.
We have a couple of options here (as far as I can tell):

Don't use ConnectionPools/persistent connections (setting maxIdleConnections seems to mostly do this)
Manage our own implementation that periodically evicts connections regardless of their idle time.

The former might be ok for the parts that are not directly on the user request path, but it would be unfortunate if we couldn't use connection pooling at all.
The latter is an approach that we have implemented, but it has some gremlins as care needs to be taken to properly manage the lifetime of the client and its pool and the scheduled task that periodically evicts connections.
Is there interest in allowing clients to specify a connection time-to-live in addition to the idle timeout? Managing this as part of the client or (more likely) the pool seems much better in terms of properly managing the lifecycle of the pool and its management thread.
Or are we misusing OkHttp in the way we use it?

Just to confirm I understand: because the network topology is dynamic, you’d like to impose a maximum lifetime on a connection?
We can do that, though it’s not a great fit for the problem. Whatever time period we use will be too long when you want to change your topology, and too short when you don’t. My experience is that whenever we add configuration options like this many users want to use them, and this would be problematic.
A more natural fit would be for the client or server that’s being taken out of the network to terminate manually. For webservers this is adding Connection: close headers on responses once they’re being cycled out. For clients this is manually evicting connections from the pool.

Just to confirm I understand: because the network topology is dynamic, you’d like to impose a maximum lifetime on a connection?

As one option yes. Another option would be to monitor DNS changes and only recycle connections if DNS records actually change.
We ended up creating our own Call.Factory that uses a scheduled task to evict the pool on a fixed schedule (currently 5 minutes). This effectively imposes an upper bound on the connection TTL (modulo connections that are currently active and won't be evicted).
Instead of doing this from the consumer side, I think it would be beneficial if okhttp3.ConnectionPool#cleanup would not only cleanup idle connections but any connection that isn't currently in use and exceeds a connection TTL configured in the pool.

Cool. I think that’s a good fix.

My experience is that whenever we add configuration options like this many users want to use them, and this would be problematic.

@swankjesse Why it is problematic? If the particular configuration option is excessively used, isn't that indication that it's required?

It is not how HTTP works. Clients aren’t supposed to have special configuration for their endpoints. In particular, browsers don’t do this.
Instead the solution must be server-side.

Thanks @swankjesse, that's a good point.

I have one more usecase, which in my option is not solved by server-side connection termination. Disaster recovery. This is not AWS related, bear in mind please. In case a loadbalancer fails (stops listening to its port, we do the failover by switching the DNS. As this is not predictable, we can't expect the failing loadbalancer to terminate connections.
How to approach this please?

this expected feature exists for apache httpClient connection pool. check timeToLive parameter for this class: https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html
what's the issue:
we have 3 data centers (dc-a, dc-b, dc-c), and we have svc1 calls svc2. normally svc1 in dc-a will call the downstream svc2 in dc-a, same for other 2 data centers. sometime, we want traffic not go to dc-c for svc2, so we remove the IP of svc2 in dc-c on DNS, if we lookup dns, it will not return svc2 IP in dc-c, but the svc1 in dc-c still call svc2 in dc-c, as it still reuse the IP.
expected:
force close the connection in pool if it used N times or used a few minutes.

Linking to #190 just in case anyone is looking for OkHttp's timeToLive (TTL), max age, max lifetime. AKA keepAliveDuration.

Leaving a comment for those who might attempt the Connection: close approach: it seems OKHttp does close the connection properly, but it does not re-run name resolution, so if you're trying to use this in conjunction to changes in DNS records, it'll likely just retry connecting to the same IPs as it had the first time it resolved the address.
Putting this here for documentation, as this issue seems to be one of the top results on search engines.
Relates to #4530


Icon in title

Hello, i like your app very much.
Is it possible to add a custom icon to the title_prefix?

You can use emojis to add an icon to a feed's title_prefix.
Example:
feeds:
    - name: GitHub status
      url: https://www.githubstatus.com/history.rss
      interval: 600
      title_prefix: "⚠"


[$250] Chat not loaded instantly after Selecting a user from chat search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1728476206365989
Action Performed:

Launch the app
Tap Chat search and search for a user
Select the user from search result

Expected Result:
Chat loaded with selected user instantly
Actual Result:
Not loading instantly and hanging
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e43659a2-ac74-4cb5-8139-68bc9d97301f
Profile_trace_for_9.0.45-1.cpuprofile
App_Info_9.0.45-1.json
logs-2024-10-09 12_13_37.002.txt

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021844502587088898350
Upwork Job ID:<PHONE_NUMBER>088898350
Last Price Increase: 2024-10-10

Issue OwnerCurrent Issue Owner: @shubham1206agra

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Looking at the SO, I don't think this is actionable for me until it's reproducible. Feel free to re-assign me once you reproduce or if I've misunderstood the assignment

Sounds great, thanks @adhorodyski! Let me know what I can do to help :)

Asked here to determine how we manage this wrt payment and upwork

Coming in with my notes based on the provided materials.
We can't clearly match a 14s screen recording with a 1:30min cpu profile, I did this based on my experience & the actions took on the recording. We can see the JS navigation events not being triggered, this leads us to this thread being super busy while we press. The native visual feedback is there. There's an area between the 10s-25s of the trace that is most likely what we're looking for, this is what I focused on.
Now please excuse my poor drawing skills :D
I took some notes on what happened in this busy area, here's the screenshot:

For me this looks like the user got unlucky with the timing within our current architecture of processing data synchronously on the JS thread. Here's the simplified timeline:

API updates came in (eg. by receiving some pusher events)
We write these updates to Onyx -> this triggers all the subscribers
Subscribers kick off different, synchronous dependencies (like here, expensive to run functions) living within components/libraries that process based on the new values from Onyx
As an effect, the JS thread is effectively blocked during this time period, here because it had to recalculate the options list by running createOptionList. During all this time, the thread was unable to process other scheduled work like the navigation events.

I'm afraid we can't simply fix this case (it doesn't look like any sort of bug - rather the design), as all that happened is fundamentally what we basically do for everyone - it's just the amount of data to process + the unlucky timing that ended up with the UI being unresponsive for some time.
@quinthar I believe this is not easily reproducible due to the random factors which we cannot time together, or am I wrong?

@adhorodyski is it the kind of perfect storm that is predictable? i.e. on the old system we would have predictable slow patches at times during "harvesting" - is this that kind of group of events that is happening every day, week, month, or was this likely to just be super unlucky timing?

Unfortunately I believe this was just super unlucky (unless @quinthar can reproduce it?), this is one of the problems only happening on the bigger accounts with more data where HTTPS updates running in the background produce heavy synchronous workloads. The result is UI hangs & unresponsiveness.


Unifi device tracker "not_home" state showing incorrectly

Home Assistant release with the issue:

Last working Home Assistant release (if known):
0.70.0
Operating environment (Hass.io/Docker/Windows/etc.):
Docker under Ubuntu 18.04
Component/platform:
https://www.home-assistant.io/components/device_tracker.unifi/
Description of problem:
The not_home state of the UniFi device tracker (may apply to more than just UniFi), is shown as "not_home" in the UI, when it should be shown in a friendly manner, i.e. "Not Home"

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
device_tracker:
  - platform: unifi
    host: localhost
    username: !secret unifi_username
    password: !secret unifi_password
    verify_ssl: false
    ssid_filter:
      - REDACTED
      - REDACTED
    new_device_defaults:
      track_new_devices: False
      hide_if_away: False

Traceback (if applicable):

Additional information:

Same problem. I can see that the unifi user is logged into my controller and that all mobile devices are not listed on the unifi controller? but they all are stated as Home?
## Unifi
  - platform: unifi
    host: <IP_ADDRESS>
    port: 8443
    username: !secret unifi_username
    password: !secret unifi_password
    ssid_filter:
      - 'main'
      - 'guest'
    verify_ssl: False
    site_id: !secret unifi_siteid
    interval_seconds: 30
    consider_home: 120
#   detection_time: 30
    new_device_defaults:
      track_new_devices: True
      hide_if_away: False

I also enabled ping lately could this impact anything?

The not_home state is correct for all device trackers as per the documentation at https://www.home-assistant.io/components/device_tracker/

I just upgraded Home Assistant to the latest version, and encountered the same issue with devices being stuck in a state. I have tried rebooting both Home Assistant and the Unifi Controller.

Same issue goes for me with homeassistant 0.87.1

Is the problem fixed? if not have you updated to the latest version?

No issues for me anymore, after finding out that :latest tag for raspberrypi3 docker images is unstable betas, and not stable releases..

Still going on here. Nothing changed... running Hassio 0.91.2 and RPi 3B+

In my case it has been solved. I'm actually using latest Unifi docker image, and it connects flawless.


Offset all component type ids by +1

This fixes a crash when adding a component with type id 0 to an entity, for example through world.Create(in comp).
If comp has a type id of 0 then an error is thrown when trying to index that type in the chunk, since the archetype retrieved for that type is the one associated with a component type hash of 0, which is the empty one.
I didn't make line 155 use Size++ so that the state doesn't get corrupted if _types.Add throws for some reason, since even though it checks at the start of the method I don't think it's made to be thread safe.

The PR is fine, however i would like to understand why exactly that bug happened. Since i could not reproduce it.
From your explanation and the discord messages i assume that once you attach an ComponentType with the id 0 to an entity, it would throw.
However... var entity = world.Create(new ComponentType(0, typeof(int), 4, false); works perfectly fine for me. Also adding a component with that id. So the bug might not be the id itself, probably its somewhere different.
What exactly did you do? Any idea on how i could reproduce this? ^^

You need to create an empty entity first, here's a test case (in NUnit) for this that will currently throw without this pr:
    [Test]
    public void Test()
    {
        var world = World.Create();
        world.Create();
        world.Create(new Component());
    }

    public readonly record struct Component;


Make HTML semantically correct

The binding element is main
Our App is an article
App will have sections and divs
Also, lowercase css classes in accordance with Udacity best practices

The changes here are in accordance with maintaining semantically correct HTML tags.
though this seems petty, having semantically correct tagging on the DOM, enables the markup to be more readable and index-able, as opposed to a div soup
Also, css classes are best written in lowercase.
overall, is a reflection of Udacity's style guide

Let's have a sidebar as well aside. Because we do have a menu listing in sidebar.

Thanks @retrocausal for the contribution :+1:  . This looks good to me but I am not still sure about footer component but let's keep it. Also let's wait for what @skyshader and @anantoghosh has to say.

@twishasaraiya , I got a picture of what you guys are trying to achieve. Regarding the footer, I have not included it on the home page, but have a component ready. In case we need it. I will be adding the off canvas sidebar soon. Maybe Monday. we could then look at styling the home page which would be the landing page by this weekend. If you could decide what needs to be on the header, I can add it too.

Closing this request since we have already moved ahead in the project.


Unexpected behaviour: database config loads only from /assets/config dir

Hello!
Code $builder->components()->database()->get('anything') throws exception:
PHPixie\Database\Exception\Driver: Driver '' does not exist

81         $driverName = $config->get('driver');
82         if (!array_key_exists($driverName, $this->driverClasses)) {
>>             throw new \PHPixie\Database\Exception\Driver("Driver '$driverName' does not exist");
84         }
85

#0 /var/www/vendor/phpixie/database/src/PHPixie/Database.php:83
#1 /var/www/vendor/phpixie/database/src/PHPixie/Database.php:28
    PHPixie\Database->configDriverName(Slice)
#2 /var/www/bundles/app/src/Project/App/Processors/Grabber.php:33
    PHPixie\Database->get('goodhack_cf')
#3 /var/www/bundles/app/src/Project/App/Console/Download.php:42
    Project\App\Processors\Grabber->process('goodhack_cf')
#4 /var/www/vendor/phpixie/console/src/PHPixie/Console/Runner.php:43
    Project\App\Console\Download->run(Slice, Slice)
#5 /var/www/vendor/phpixie/console/src/PHPixie/Console/Runner.php:28
    PHPixie\Console\Runner->runCommand('app:download', array[1], array[0], true)
#6 /var/www/vendor/phpixie/console/src/PHPixie/Console.php:19
    PHPixie\Console\Runner->runFromContext()
#7 /var/www/vendor/phpixie/framework/src/PHPixie/Framework/Console.php:35
    PHPixie\Console->runCommand()
#8 /var/www/vendor/phpixie/framework/src/PHPixie/Framework.php:61
    PHPixie\Framework\Console->processSapiCommand()
#9 /var/www/console:8
    PHPixie\Framework->processConsoleSapiCommand()

Logged items:

When database config located in /bundles/app/assets/config/database.php, but all ok when file located in /assets/config/database.php, because $config->data for \PHPixie\Database::__construct() will be null in first case and contains data in second case
Expectected behaviour:
Configuration loads from /assets/config dir and after these loads from /bundles/app/assets/config dir

Sorry, just noticed this now.
Is the problem still there?

Yep
ср, 26 окт. 2016 г., 17:48 Roman Tsiupa<EMAIL_ADDRESS>
Sorry, just noticed this now.
Is the problem still there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PHPixie/Project/issues/41#issuecomment-256370485, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADRO9zjX5TA8HY1XJGBQijE6GHkeI1R1ks5q32gfgaJpZM4KGAtZ
.

--
Best regards,
Nikita Chernyi (Backend Developer, DevOps).
rakshazi.cf https://t.co/xkzRIVpuMK

I see, actually
/bundles/app/assets/config/database.php is the configuration file for the bundle, not for the framework. They are not supposed to get merged really. This is for things that are only needed for your bundle. Like for example if you have a bundle that uses guzzle and you need to store the configuration somewhere which is not project-related.
Can you tell me what you want to achieve, and I'll try to help you to do it =)

Ok, here is my case:
I have app bundle. This bundle need connect to multiple databases (and db hosts) in some cases. But this configuration needed only for this bundle, not for all project, that's why I expect that database.php configuration located in bundle scope will be available only in this scope (such as private methods and properties are available only in their's class).


Fix panic in HandleEventRequests when room or event is not known

Signed-off-by: Sean Quah<EMAIL_ADDRESS>

Thanks for the fast review!


Steam crashes at start

Describe the bug
After installing steam, it crashes when I try to launch it. Sometimes the crash happens when it is pulling the needed updates, other times it crashes when trying to login.
Steps To Reproduce
Steps to reproduce the behavior:

Set programs.steam.enable = true;
Launch Steam
Profit?

Expected behavior
Steam to reliably launch allowing me to play games.
Additional context
Output captured by strace when trying to launch steam.
steam.txt
My current steam related settings:
{ pkgs, ... }:
{
  hardware.graphics.enable32Bit = true;
  programs = {
    steam = {
      enable = true;
      package = pkgs.steam.override {
        extraLibraries =
          p: with p; [
            (lib.getLib networkmanager)
          ];
      };
      remotePlay.openFirewall = true;
      dedicatedServer.openFirewall = true;
    };
  };
}

Attempted workarounds tried from another ticket:
Workarounds I tried:

Launching steam with steam -vgui
Launching steam with steam --reset
Removing $HOME/.cache/nvidia/GLCache directory, then launching steam.
Launching steam with steam -no-cef-sandbox
Overriding the steam package as suggested in https://github.com/NixOS/nixpkgs/issues/238101#issuecomment-1627838797

Notify maintainers
@jagajaga
@aidalgol
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
vendion on vili ~ took 65ms
➜ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.02 MiB download, 0.06 MiB unpacked):
  /nix/store/91d27rjqlhkzx7mhzxrir1jcr40nyc7p-stdenv-linux
copying path '/nix/store/91d27rjqlhkzx7mhzxrir1jcr40nyc7p-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.11-xanmod1, NixOS, 24.11 (Vicuna), 24.11.20240929.06cf0e1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - nixpkgs: `/nix/store/r2hk87rfvc5fpfbl2bj64a3x7mcq9f6c-source`

I'm not actually a Steam nixpkgs maintainer; I just submitted an update to the Steam bootstrap package recently.

Okay, sorry for the tag then.

Steam also crashes for me...
steamwebhelper.sh[829938]: Starting steamwebhelper under bootstrap sniper steam runtime via /home/trude/.local/share/Steam/ubuntu12_64/steam-runtime-sniper.sh
src/vgui2/src/surface_linux.cpp (1954) : glXChooseVisual failed
src/vgui2/src/surface_linux.cpp (1954) : glXChooseVisual failed
src/vgui2/src/surface_linux.cpp (1954) : Fatal assert; application exiting
src/vgui2/src/surface_linux.cpp (1954) : Fatal assert; application exiting
10/15 19:23:12 Init: Installing breakpad exception handler for appid(steam)/version(1726604483)/tid(829842)
steamwebhelper.sh[829938]: CEF sandbox already disabled
steamwebhelper.sh[829938]: Starting steamwebhelper with Sniper steam runtime at /home/trude/.local/share/Steam/ubuntu12_64/steam-runtime-sniper/_v2-entry-point
assert_20241015192312_8.dmp[829989]: Uploading dump (out-of-process)
/tmp/dumps/assert_20241015192312_8.dmp

And, nix-shell -p nix-info --run "nix-info -m":
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.54, NixOS, 24.11 (Vicuna), 24.11.20241009.5633bcf`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"nixos-24.05"`
 - nixpkgs: `/nix/store/60sn02zhawl3kwn0r515zff3h6hg6ydz-source`

+1
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.53, NixOS, 24.11 (Vicuna), 24.11.20241001.1839883`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.91.0
 - channels(jay): `""`
 - nixpkgs: `/nix/store/7qkcm6k8phjcjndpqxh2p6why320dqsq-source`

I was having a similar issue. This override fixed it: https://github.com/NixOS/nixpkgs/issues/351180#issuecomment-2438100466

Please test https://github.com/NixOS/nixpkgs/pull/351928.

Hey @K900 I can confirm that the PR fixes the crashing for me!


jruby tests are very flaky

While trying to make test pass for #318, I've noticed that jruby tests are really flaky.
See https://travis-ci.org/schacon/ruby-git/builds/182204463, https://travis-ci.org/schacon/ruby-git/builds/182015600 and https://travis-ci.org/schacon/ruby-git/builds/182011837 (virtually same code).
This makes contribution hard to tests.

I think this is the same as I just saw: https://travis-ci.org/ruby-git/ruby-git/jobs/350814139
We should look into sorting this out, or disabling these tests on JRuby (if all else fails.)

I believe this was fixed in #403 and released in v1.6.0.pre1


v0.26 does not build with lit-recommended tools for experimental bare module exports

Thanks for the new release.
There are a couple of import statement breaking the library to run with the frontend tooling I am using (vite.js):

import {customElement} from 'lit/decorators' -> import {customElement} from 'lit/decorators.js' (see https://lit.dev/docs/components/decorators/#importing-decorators, or https://github.com/lit/lit/issues/2206#issuecomment-931408025);
similarly, all directive imports should have the .js extension specified. For instance import { styleMap } from 'lit/directives/style-map' -> import { styleMap } from 'lit/directives/style-map.js'

Without this, build tools fail to find dependencies:
 The plugin "vite:dep-pre-bundle" was triggered by this import

    node_modules/.pnpm/@material+mwc-dialog@0.26.0/node_modules/@material/mwc-dialog/mwc-dialog.js:9:30:
      9 │ import { customElement } from 'lit/decorators';
        ╵                               ~~~~~~~~~~~~~~~~

✘ [ERROR] [plugin vite:dep-pre-bundle] Missing "./decorators" export in "lit" package

    node_modules/.pnpm/vite@2.9.7/node_modules/vite/dist/node/chunks/dep-88bd5805.js:39941:7:
      39941 │   throw new Error(
            ╵         ^

Same here (not using vite.js).
Release 25.3 transpiled the imports including the .js extension, whereas 26 does not. Webpack 5 doesn't seem to like that. Haven't yet looked into if configuring Webpack differently fixes this.

Thanks a lot for your answer @asyncLiz
I shall be worried v0.26 is going to break build pipelines for many consumers of this library.

Applications should use a build tool such as rollup or webpack with plugins that can handle the bare module specifiers.

vitejs - the frontend build tool that I reported to be using - is an build tool and handles bare module specifyer
@karimayachi is using webpack

Our library use bare module specifiers following TypeScript conventions, which restricts adding .js at the end of files

https://github.com/lit/lit/issues/1986#issuecomment-880298541
Can you re-open the issues and propose a more helpful way forward ?

Hi @asyncLiz ,
Thanks for the reply. As @christophe-g mentioned, we are using bundlers. Webpack in my case and I believe Vite uses Rollup.
It's not the bare specifiers that are the problem (I use those all the time, and Webpack handles them great). Specifically it's about referencing specific files within a package:
Something like this:
import { RippleHandlers } from '@material/mwc-ripple/ripple-handlers'; // no problem
import { html, LitElement } from 'lit'; // no problem
import { eventOptions, property, query, queryAsync, state } from 'lit/decorators'; // problem

Before version 26 this was transpiled as:
import { RippleHandlers } from '@material/mwc-ripple/ripple-handlers'; // no problem
import { html, LitElement } from 'lit'; // no problem
import { eventOptions, property, query, queryAsync, state } from 'lit/decorators.js'; // no problem

Probably your upgrade to TypeScript 4.4.4 caused the change, but Webpack (latest) and probably other bundlers can't handle this.
If this is something that can be fixed on our side by changing the configuration of our bundlers, please point us in the right direction, otherwise please reopen this issue.
Kind regards,
Karim

I am using web dev server and have configured it with the proper flag for bare module resolution and it still doesn't work. I have also tried to get web dev server to use the Rollup plugin for module resolution and that did not work either. I have like 50+ applications that need to be locked into an older version of Mwc components if I can't find a way to get .26 to build.

Thanks for the comments! We're looking into how to resolve this issue.

@asyncLiz Thank-you. If it helps, the issue seems to be, at least for me, happening because the built .js files still contain the bare module specifier so Typescript(which likes bare modules) is done and out of the loop at the point when the bundler(in my case, rollup and @web/dev-server) tries to transform the modules.
I'm guessing because using both the built-in resolver and @rollup/plugin-node-resolver fail because, unless I'm missing something, basic and node-style resolution patterns only like bare modules when pointing to a module by package name or containing directory, not when referencing a module file directly.

Thanks for the comments! We're looking into how to resolve this issue.

Thanks !

hitting this in rollup and lit on the starter package, with no other added dependencies or tooling. has this essentially broken any use of lit with mwc at latest ? if so, what should we be using aside from lit?

i.e. shouldn't this just be titled 0.26 does not build with lit? or is there a tooling change we can apply that works around this issue?

just tested this inside the webpack based https://github.com/neomjs/neo build and it breaks.

will need to downgrade for now.
off topic: regarding "bare module specifiers" => it would be really nice if there was a version which would run as it is directly inside the browser. the entire neo dev mode can handle it, with the exception for your components, which have to get pulled in from a cdn.

Fixed in v0.26.1

this was fast. appreciated! (the neo build works fine again)
for the dev mode (no builds at all), i need to stick to a cdn which resolves the imports. e.g.:
https://unpkg.com/@material/mwc-textfield@0.26.1/mwc-textfield.js?module
a bit slow (could cache it inside a service worker).

@asyncLiz thank you for the quick update!


Fix Content-Length header to count bytes

The minified_content is a string variable, but the content-length must always be specified in bytes.
Using response.content works around this, as response has a setter on content, that encodes the bytes before they're stored

Thank you, well spotted. I added a changelog note and updated the tests to catch the issue. Released in 1.6.1 🎉


Tests that use staging-fuel.ignitionrobotics.org are failing

Environment

OS Version:  all
Source or binary build? all

Description

Expected behavior:  All tests pass
Actual behavior:  Tests are failing

Steps to reproduce

Run UNIT_ign_src_TEST. Many tests there assume that the staging server has some users and models.
Output

Example test:
https://github.com/gazebosim/gz-fuel-tools/blob/21c5eb5ecb6e616f024b7cea6744e8ce028fbbd6/src/ign_src_TEST.cc#L107-L124
And the failure, note the Either failed to fetch model list, or server has no models yet.
[125.129s] 7: [ RUN      ] CmdLine.ModelListConfigServerPretty
[125.476s] 7: ^[[1;31m[Err] [RestClient.cc:327] ^[[0m^[[1;31mError in REST request^[[0m^[[1;31m^[[0m
[125.476s] 7:
[125.476s] 7: libcurl: (60) SSL: no alternative certificate subject name matches target host name 'staging-fuel.ignitionrobotics.org'
[125.476s] 7: ^[[1;33m[Wrn] [FuelClient.cc:317] ^[[0m^[[1;33mFailed to fetch models from server, returning cached models.^[[0m^[[1;33m^[[0m
[125.476s] 7: ^[[1;33mURL: https://staging-fuel.ignitionrobotics.org
[125.476s] 7: Version: 1.0
[125.476s] 7: API key: ^[[0m
[125.476s] 7: ^[[1;33m^[[0m
[125.476s] 7: ^[[1;33m[Wrn] [LocalCache.cc:105] ^[[0m^[[1;33mServer directory does not exist [^[[0m^[[1;33m/staging-fuel.ignitionrobotics.org^[[0m^[[1;33m]^[[0m
[125.476s] 7: /home/chapulina/dev_focal/ws_garden/src/ign-fuel-tools/src/ign_src_TEST.cc:114: Failure
[125.476s] 7: Expected: (this->stdOutBuffer.str().find("owners")) != (std::string::npos), actual:<PHONE_NUMBER>3709551615 vs<PHONE_NUMBER>3709551615
[125.476s] 7: Fetching model list from https://staging-fuel.ignitionrobotics.org...
[125.477s] 7: Either failed to fetch model list, or server has no models yet.
[125.477s] 7:
[125.477s] 7: [  FAILED  ] CmdLine.ModelListConfigServerPretty (347 ms)

Suggested solution
Some possible solutions:

Make sure that server used on the test is always populated
Change the test to a non-staging server
Change the test to use a mock server that doesn't rely on the actual internet

Change the test to use a mock server that doesn't rely on the actual internet

I think this should be the case for any UNIT_ test in fuel-tools.  I noticed that the Model tests have blown up in time recently because they iterate over all of the available models in fuel.
I think it would still be appropriate to have them in INTEGRATION_ tests, but the tests that access external network resources should be clearly labelled.


infra: add dependabot updates for GH actions

Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[ ] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #5 (4d9adf7) into main (d1e69ca) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   98.26%   98.26%
=======================================
  Files           2        2
  Lines         288      288
  Branches       84       84
=======================================
  Hits          283      283
  Misses          2        2
  Partials        3        3

Impacted Files
Coverage Δ

src/braket/_build_tools/_version.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Recent change to how attachment path is handled

I have a folder structure like this:
mark.sh
docs/
  - manuals/
     - device1.md
     - imgs/
       - device1.png

mark.sh has the mark command and it is run from the topmost directory (e.g. n cd command in the script). It runs in kovetskiy/mark:latest docker container.
device1.md uses device1.png as an attachment like this:
<!-- Attachment: ./docs/manuals/imgs/device1.png -->

![Device1](./docs/manuals/imgs/device1.png)

The path was given relative to the folder the mark command is run from, not relative to the markdown file.
This has been working fine until yesterday, when mark started to give the following error:
2022-01-20 04:19:14.085 DEBUG parent page "Manuals" exists: /display/space/Manuals
2022-01-20 04:19:14.085 INFO  page will be stored under path: Space > Manuals > Device1
2022-01-20 04:19:14.085 FATAL unable to create/update attachments
                              └─ unable to get checksum for attachment: "./docs/manuals/imgs/device1.png"
                                 └─ unable to open file
                                    └─ open docs/manuals/docs/manuals/imgs/device1.png: no such file or directory

If I update the path to be relative from the markdown, e.g. ./imgs/device1.png, it works.
Was there any change recently that might have caused this? Or was the relative-to-markdown path always the correct way to specify attachments and I just got lucky that it worked like this before? I don't mind updating all my markdowns to relative paths, but I want to understand what happened and make sure I don't need to go back to the original path later.

Hi, this has been changed with the major version bump because of
https://github.com/kovetskiy/mark/pull/151

Gotcha, thank you!


Questions of calculateContactBasis() of The contacts.cpp

The method calculateContactBasis() of The contacts.cpp has a purpose of calculating orthonormal basis in contact coordinates.
So, I read the contents that the contact normal will be used as a X-axis in the contact coordinates.
To calculate the Z-axis and Y-axis in the contact coordinates, the code uses cross product first between X-axis(contact normal) and World-Up(0,1,0) Vector. and the result is Z-axis.
With the result, it calculates the Y-axis, using the cross product between Z-axis and X-axis.
So, the preliminary code of makeOrthonormalBasis in the book is like:
void makeOrthonormalBasis(const Vector& x, Vector* y, Vector* z)
{
       // Calculate z from the vector product of x and y.
       z = (*x) % (*y);

       // Check for y and z in parallel
       if(z->squaredMagnitude() == 0.0) return;

       // Calculate y from the vector product of z and x
       (*y) = (*z) % x;

      // Normalize the output vectors
       y->normalize();
       z->normalize();
}

I think this method is right and the calculateContactBasis() is based on this logic.
        // Scaling factor to ensure the results are normalised
        const real s = (real)1.0f/real_sqrt(contactNormal.z*contactNormal.z +
            contactNormal.x*contactNormal.x);

        // The new X-axis is at right angles to the world Y-axis
        contactTangent[0].x = contactNormal.z*s;
        contactTangent[0].y = 0;
        contactTangent[0].z = -contactNormal.x*s;

        // The new Y-axis is at right angles to the new X- and Z- axes
        contactTangent[1].x = contactNormal.y*contactTangent[0].x;
        contactTangent[1].y = contactNormal.z*contactTangent[0].x -
            contactNormal.x*contactTangent[0].z;
        contactTangent[1].z = -contactNormal.y*contactTangent[0].x;

And My questions start here.
Because
Z-axis = crossProduct(X-axis, Y-axis)

if X-axis = (x1, x2, x3), Y-axis = (y1, y2, y3) = (0, 1, 0)

crossProduct(X-axis, Y-axis) =

|  i    j    k |
| x1 x2 x3 |
| 0   1   0  |

= (x2 * 0 - x3 * 1, x1 * 0 - x3 * 0, x1 * 1 - x2 * 0)
= (-x3, 0, x1)

But the code is..
contactTangent[0].x = contactNormal.z*s;
contactTangent[0].y = 0;
contactTangent[0].z = -contactNormal.x*s;

When we just write the cross product between Z-axis and X-axis
Y-axis = crossProduct(Z-axis, X-axis)

if Z-axis = (z1, z2, z3) = (z1, 0, z3) (the calculated one from the cross product between X and Y axis,
   X-axis = (x1, x2, x3)

crossProduct(Z-axis, X-axis) =

|  i    j    k |
| z1 0 z3 |
| x1 x2 x3 |

= (0 * x3 - z3 * x2, -(z1 * x3 - z3 * x1), z1 * x2 - 0 * x1 )
= (-z3 * x2, - z1 * x3 + z3 * x1, z1 * x2)

We get the above equation. However, the code of calculating Y-axis is
contactTangent[1].x = contactNormal.y*contactTangent[0].x;
contactTangent[1].y = contactNormal.z*contactTangent[0].x - contactNormal.x*contactTangent[0].z;
contactTangent[1].z = -contactNormal.y*contactTangent[0].x;

The code should be like this
contactTangent[1].x = - contactNormal.y * contactTangent[0].z;
contactTangent[1].y = -contactNormal.z * contactTangent[0].x + contactNormal.x * contactTangent[0].z;
contactTangent[1].z = contactNormal.y * contactTangent[0].x;

In summary, the questions are:

are the lines of calculating the orthonormal basis right?

Hello, did you figure this out? I have a feeling that a bug in my code is to do with this.

@e2-dunstan  No.
I actually gave up clinging to this code.
After this book, I changed my physics engine base, box2D.
If you try to implement your own physics engine, I recommend you see box2D presentations on GDC. It's dealing with jitter problems in modern way.
But Game Physics Engine Developemtn Book is not handling this problem well.
And the sample code is not maintained now.
see this link too : https://pybullet.org/Bullet/phpBB3/viewtopic.php?f=6&t=63
BulletPhysics, and Box2d are famous physics engine which you should study from.
Good luck.


test: Check that there are no data/metadata key collisions

This will ensure that no signals are added that conflict with metadata fields, or vice versa. Ensuring that there are no collisions will become important once the event bus consumer starts sending metadata to receivers.
Merge checklist:

[ ] Version bumped
[ ] Changelog record added
[x] Documentation updated (not only docstrings)
[x] Commits are squashed

For reference:

https://docs.python.org/3/library/importlib.html#importlib.import_module
https://docs.python.org/3.8/library/pkgutil.html#pkgutil.walk_packages

Filed https://github.com/openedx/openedx-events/issues/178 to change the API and submitted https://github.com/openedx/openedx-events/pull/179 to implement it. If that is merged, then this can just be reduced to the auto-detection of signals.py files without any of the new validation.

As we're no longer at risk of collisions, I've reworked this into a smaller PR that just removes reliance on hardcoded imports: https://github.com/openedx/openedx-events/pull/181


style : ui changes in form and update form page

background color , alignment and few jobs were  posted to the database

good work roshini

thank you vijay


Doc comments on use declarations are limited to 5 characters less than max_width

If wrap_comments is true, doc comments on use declarations are wrapped to 5 characters less than max_width (or comment_width, if it is less than max_width - 5). This makes it impossible to wrap such comments to the same value as max_width.
 This five-character difference persists across different values of comment_width and max_width, except if comment_width is more than 5 characters less than max_width, both doc comments will be limited to that value.

This issue presents similarly to #5890, but I don't know if the cause is similar—I would expect both doc comments to have the same internal shape.

Thanks for reaching out. #5890 only applies to multi-line block comments so it's unrelated.
The issue here is that we're passing the nested_shape to UseTree::rewrite_top_level, and that shape gets used to rewrite both the import and the attributes.
https://github.com/rust-lang/rustfmt/blob/da7f67810f263351f61f5618c250f7396a5f9bbc/src/reorder.rs#L126-L141
I can think of two possible approaches to fixes this:

Move the nested_shape derivation into UseTree::rewrite_top_level
Pass both the nested_shape for rewriting imports and the original shape for rewriting attributes to UseTree::rewrite_top_level

linking the tracking issue for wrap_comments (#3347)

Is this bug related then?
/* 50 characters:
0        1         2         3         4         5
12345678901234567890123456789012345678901234567890
*/
use aaaaaaaaa::{bbbbbbbbb, ccccccccc, ddddddddd};

After rustfmt --config max_width=50:
/* 50 characters:
0        1         2         3         4         5
12345678901234567890123456789012345678901234567890
*/
use aaaaaaaaa::{
    bbbbbbbbb, ccccccccc, ddddddddd,
};

The use declaration is only 49 characters but gets wrapped anyway. This also happens with the default max_width of 100 (use declarations > 98 characters get wrapped).

Is this bug related then?

@taylordotfish It's possible, though my guess is that they're not related since your original issue describes doc comments on imports wrapping too early when using warp_comments=true, while this second case is about rustfmt wrapping nested use declarations too early when close to the max_width boundary.
I very much appreciate you taking the time to check other edge cases 🙏🏼. Probably best to create a new issue so we can track that separately.

@ytmimi Sure, created #5927.


Boolean values can be stored and fetched if the field type is str and not bool using aredis.

Hey everyone, I am trying to store and fetch in a model whose field's type is boolean. However, as you may know, Redis will complain about that when trying to encode bool values. But, I found a workaround for this use case, take the following as an example using the sync version redis_om:
from typing import Optional

from redis_om import Field, HashModel, JsonModel, Migrator

class Author(HashModel):
    first_name: str = Field(index=True)
    last_name: str
    active: Optional[bool] = Field(index=True, default=False)

class Blog(JsonModel):
    title: str = Field(index=True, full_text_search=True)
    content: str
    author: Author

Migrator().run()

author = Author(
    first_name="Mahmoud",
    last_name="Harmouch",
).save()

blog = Blog(
    title="Redis",
    content="Redis is a blazingly fast k/v store!",
    author=author
)

blog.save()

print(blog.pk)

assert Blog.find(Blog.pk == blog.pk).all()) == blog

Running this above script will throw the following exception:
redis.exceptions.DataError: Invalid input of type: 'bool'. Convert to a bytes, string, int or float first.

However, if you are using the async version, storing and indexing will work if the type is str. So to make boolean values work in aredis_om, just replace str in place of bool:
class Author(HashModel):
    first_name: str = Field(index=True)
    last_name: str
    active: Optional[str] = Field(index=True, default=False)

class Blog(JsonModel):
    title: str
    content: str
    author: Author = Field(index=True)

And your endpoints call async functions like the following to create/fetch k/v:
async def get_blogs(author: Optional[Author] = None):
    if not author:
        return await Author.find().all()
    else:
        return await Author.find(Author.author == author).all()

async def create_author(request: Request):
    return await Author(first_name=request.first_name, last_name=request.last_name, active=request.active).save()
    # or simply: return await Author(**request).save() if request is a dict.

Just wanted to share in case someone might find it helpful.

thanks for you sharing, it is very useful, and I filtered the data in the following way::
await Author.find(Author.active== 'False').all()

@sav-norem, this isn't documentation issue. In #193 he said:

Hi there - boolean fields aren't yet supported for JSON or Hash, they'll likely appear in JSON first as boolean is a native type there vs a Redis Hash that understands strings, floats and ints.

@llirrikk  - Sure! I meant more like we can label this as a documentation issue since it provides documentation and isn't raising a new bug type of issue that needs a new PR to fix.

should be resolved by #611, so going to go ahead and close this out.