Infraorder Gekkota (Cuvier, 1817)

Gekkota (Cuvier, 1817) is an infraorder. Note that infraorders are not used by the GBIF backbone taxonomy and as a result, this taxon will not appear in the unified checklist (since there is no match). Is there a way to choose a higher/lower level for Geckos?
Note also that Gekkota spec (Cuvier, 1817) appears on the ad hoc checklist. Should it be removed there?

We already had this discussion in #1
The decision was that we should keep them in. Should I reopen the issue?

Loïc: OK if it is not in the unified list.


CLI Commands provide no feedback while executing

Need to implement some visual feedback while executing commands. Similar to other CLIs
Azure node version:

Docker Example:

This was a deliberate design decision in the CLI. If you want more information, you can use --verbose.
If that doesn't give you the right kinds of information you would expect, then please let us know.

Should be --versbose default and should have  a --quiet option

Related to https://github.com/Azure/azure-cli/issues/987.
As @tjprescott said, this was a deliberate design decision.

Closing for duplicate of #987


[BUG] Index-based colormodes raise ZeroDivisionError for single-trace plots

All index-based colormodes raise a ZeroDivisionError when plotting a ridgeline plot with either a single trace or a single trace per row.
The index-based colormodes are:
colormodes = [
    "row-index",
    "trace-index",
    "trace-index-row-wise",
]

MVE:
>>> from ridgeplot import ridgeplot
>>> ridgeplot(samples=[[1, 2, 2, 3]], colormode=colormodes[0])
Traceback (most recent call last):
...
  File "[...]/ridgeplot/_color/interpolation.py", line 68, in _interpolate_row_index
    [((ctx.n_rows - 1) - ith_row) / (ctx.n_rows - 1)] * len(row)
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
ZeroDivisionError: division by zero

@tpvasconcelos oops, I skipped the math classes 🥺 :rofl: . Please, give me some tips (without giving me the final answer) how could I debug to solve this bug.

If you are interested in giving it at try, you could consider taking a look at TDD as a methodology to help arrive at the solution faster. i.e.,

Define some tests cases that should work. These will currently fail and raise the ZeroDivisionError exception
Debug the issue and make the necessary changes until all tests pass (including all existing tests)
Once all tests are green, refactor the code until you're happy with the final result (making sure that the tests never stop passing)
Done!

If you are interested in giving it at try, you could consider taking a look at TDD as a methodology to help arrive at the solution faster. i.e.,
1. Define some tests cases that should work. These will currently fail and raise the `ZeroDivisionError` exception

2. Debug the issue and make the necessary changes until all tests pass (including all existing tests)

3. Once all tests are green, refactor the code until you're happy with the final result (making sure that the tests never stop passing)

4. Done!

Thanks so much @tpvasconcelos . I'll give it a try :smiley:

Thanks @sstephanyy ! 🚀


Fixed cors issue relating to OPTIONS requests

Added OPTIONS route to routes
Added preflight method in HomeController for all OPTIONS requests
Added new headers in Filters for CORS
Added test in ModifyAppSpec to test OPTIONS request

LGTM.


[SPARK-44388][CONNECT] Fix protobuf cast issue when UDF instance is updated

What changes were proposed in this pull request?

This PR modifies the arguments of the ScalarUserDefinedFunction case class to take in serializedUdfPacket, inputTypes and outputType instead of calculating these types internally from function, inputEncoders and outputEncoder. This allows the class to copy over the serialized udf value from the parent instance instead of re-creating it. Through this, we avoid hitting a variant of the issue mentioned in SPARK-43198 which seems to cause protobuf cast for instances that are made through a copy operation.
Why are the changes needed?

Bugfix. Consider the following code:
class A(x: Int) { def get = x * 7 }
val myUdf = udf((x: Int) => new A(x).get)
val modifiedUdf = myUdf.withName("myUdf").asNondeterministic()
spark.range(5).select(modifiedUdf(col("id"))).as[Int].collect()

Executing this code currently results in hitting the following error:
java.lang.ClassCastException: org.apache.spark.connect.proto.ScalarScalaUDF cannot be cast to com.google.protobuf.MessageLite
    at com.google.protobuf.GeneratedMessageLite$SerializedForm.readResolve(GeneratedMessageLite.java:1462)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at java.io.ObjectStreamClass.invokeReadResolve(ObjectStreamClass.java:1274)
    at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2196)
...

If we do not include the myUdf.withName("myUdf").asNondeterministic(), the UDF runs as expected.
Does this PR introduce any user-facing change?

Yes, fixes the bug mentioned above.
How was this patch tested?

Added a new E2E test in ReplE2ESuite.

cc @HyukjinKwon

Merged to master.


Omit stubs for unloaded functions

In exchange, calling an unloaded function is now UB. This is more consistent with how Vulkan is used outside of rust, and saves about 6000 lines of generated code.
This is motivated by the desire to reduce buildtime. However, it empirically doesn't seem to significantly change build times, or even the size of the final stripped binary. Maybe monomorphizing Option and unwrap_unchecked sucks? Is there a better way to approach this?

Manually inlining unreachable_unchecked helped size slightly, but again didn't noticeably impact buildtime.

Even representing every pointer as usize and transmuting on call doesn't seem to change anything!

In exchange, calling an unloaded function is now UB

That doesn't sound very promising unless we can make the user aware (ie. Result<Device, Device>) that not all functions loaded. Won't be the first time that I'm missing functions somewhere because of accidentally using 1.2 functions on a 1.1 device/driver, where the extension should be used. Sure, users should check for the supported extensions and Vulkan versions before doing this.
Hope you can find ways to nuke this code and win some compiletime, otherwise having an easier way to UB without any wins elsewhere is a tough pill to swallow.

In practice I don't think this would be too bad, because 1. it's what you generally expect from Vulkan, and 2. in practice it'll tend to immediately segv, which is easily diagnosed. However, there doesn't appear to be any benefit, so I don't intend to pursue this further; it seems our problems are elsewhere. But maybe someone with more experience profiling rustc could prove me wrong.

unless we can make the user aware (ie. Result<Device, Device>) that not all functions loaded

I think this would require significant API changes, at least splitting Device into multiple objects.

In practice I don't think this would be too bad, because 1. it's what you generally expect from Vulkan

If the driver crashes, sure I'd have to come up with a repro and contact vendors, but if it's a jump-to-null of my own making I'd rather prevent it.

, and 2. in practice it'll tend to immediately segv, which is easily diagnosed.

Fair enough.

However, there doesn't appear to be any benefit, so I don't intend to pursue this further; it seems our problems are elsewhere.

Yeah, agreed. We should probably continue on the builders and debugs which - together - contribute half of the buildtime. Perhaps after that the minor wins here may come to the forefront?

But maybe someone with more experience profiling rustc could prove me wrong.

I wish I knew more about this :sweat_smile: - IIRC there's debug perf output showing where in the compiler most time is spent, but I don't remember it being comprehensive enough nor easily mapping to the source code that is being translated.

unless we can make the user aware (ie. Result<Device, Device>) that not all functions loaded

I think this would require significant API changes, at least splitting Device into multiple objects.

Yeah fair enough, this would make sense for extensions but really tricky to read/use for the entire device (stabilized functions of all Vulkan versions). Perhaps something to think/worry about in the future.


Add fairing container builder

Adding this fork of fairing in the repository for the time being.
Next steps:

Add a fairing builder type that uses the go binary for unprivileged and quick builds
De-dupe (remove) my notebook -> container code
Possibly rewrite some of the builder code in python

This change is

cc @jlewi @wbuchwalter

What is fairing container builder in this case?

@wbuchwalter implemented an abstraction over "builders" in the code just merged which supports docker or kaniko. I'll add support for this builder to be called through that abstraction so that it can be used from William's code.

/lgtm /approve


Enhanced the testeminals Section properly and professionally

Related Issue
#195
Fixes:  #195
Description
BUG: The Testemonials page is right now not looking that much good. #195
I have properly designed the testemonials section you can check it out in the image below

Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please review my PR and merge this and assign this to me and put relvent labels: gssoc 2024 ext, hacktoberfect and level.

@tarunkumar2005 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉


Email being blocked

the notification never goes through my gmail because it gets blocked by google. What should I do about that? I also tried copy pasting my webhook from discord instead but i dont recieve any notifications through their either.

Hi! Do you receive any errors from Stock Alert Bot for either email or webhook? How do you know Google blocks the emails?

Close for inactivity.


WIP: Remove no_consensus_db from modules

related to #937

Codecov Report
Base: 65.81% // Head: 65.85% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (4968db2) compared to base (18883b1).
Patch coverage: 90.90% of modified lines in pull request are covered.

:exclamation: Current head 4968db2 differs from pull request most recent head d1457a8. Consider uploading reports for the commit d1457a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
+ Coverage   65.81%   65.85%   +0.03%
==========================================
  Files         116      116
  Lines       17236    17246      +10
==========================================
+ Hits        11344    11357      +13
+ Misses       5892     5889       -3

Impacted Files
Coverage Δ

modules/fedimint-mint/src/lib.rs
79.84% <90.90%> (+0.13%)
:arrow_up:

fedimint-server/src/net/connect.rs
95.26% <0.00%> (+0.24%)
:arrow_up:

fedimint-server/src/net/peers.rs
89.11% <0.00%> (+0.29%)
:arrow_up:

fedimint-server/src/multiplexed.rs
91.25% <0.00%> (+2.50%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


feature request: ability to return a promise from add

Imagine you are setting up a redux container component with data from async action creators--well, then you need support for promises and async/await in the function passed to add.
I would like to make a PR. I'm gonna start looking into the code soon. Can you give me some hints where I should apply this. Thanks in advance.

Sounds like an good opportunity! PR is very much welcome!

@faceyspacey
this is place when you can start:
https://github.com/storybooks/react-storybook/blob/master/src/client/preview/client_api.js
But I wonder if you need a new functionality why don't consider to create an addon for it instead?
Storybook has setAddon API for that. You can take as an example react-storybook-addon-info
Unfortunately, It's missing in the official documentation. I think we will need to update it

if you can of course, but I doubt you can add support for promises to the core api.
it looks like promise support will be needed right here:
https://github.com/storybooks/react-storybook/blob/master/src/client/preview/client_api.js#L67
The story gets added to the StoryStore via this method:
https://github.com/storybooks/react-storybook/blob/c46a341556c61ac2e99bb70ccee951368b1d75f5/src/client/preview/story_store.js#L13
But somewhere else the fn is eventually called. There likely needs to deal with promises as well. Perhaps that is the only place where the promise must be resolved.
...and those places ultimately are here:
https://github.com/storybooks/react-storybook/blob/master/src/client/preview/render.js#L48
https://github.com/storybooks/react-storybook/blob/master/src/client/preview/render.js#L73
and here:
https://github.com/storybooks/react-storybook/blob/master/src/client/preview/index.js#L48
so perhaps just the last 2 calls in the chain need to be made to resolve promises.
...now all that is left is to do it.

Actually you don't need to touch the final handler passed to subscribe. You only need to change renderMain and the initial decorators. Here's renderMain:
export function renderMain(data, storyStore) {
  if (storyStore.size() === 0) return null;

  const NoPreview = () => (
No Preview Available!
);
  const noPreview = (<NoPreview />);
  const { selectedKind, selectedStory } = data;

  const story = storyStore.getStory(selectedKind, selectedStory);
  if (!story) {
    ReactDOM.render(noPreview, rootEl);
    return null;
  }

  // Unmount the previous story only if selectedKind or selectedStory has changed.
  // renderMain() gets executed after each action. Actions will cause the whole
  // story to re-render without this check.
  //    https://github.com/storybooks/react-storybook/issues/116
  if (selectedKind !== previousKind || previousStory !== selectedStory) {
    // We need to unmount the existing set of components in the DOM node.
    // Otherwise, React may not recrease instances for every story run.
    // This could leads to issues like below:
    //    https://github.com/storybooks/react-storybook/issues/81
    previousKind = selectedKind;
    previousStory = selectedStory;
    ReactDOM.unmountComponentAtNode(rootEl);
  }

  const context = {
    kind: selectedKind,
    story: selectedStory,
  };

  story(context).next(element => { // THIS NOW RESOLVES A PROMISE!
   if (!element) {
    const error = {
      title: `Expecting a React element from the story: "${selectedStory}" of "${selectedKind}".`,
      /* eslint-disable */
      description: stripIndents`
        Did you forget to return the React element from the story?
        Use "() => (<MyComp/>)" or "() => { return <MyComp/>; }" when defining the story.
      `,
      /* eslint-enable */
    };
    return renderError(error);
   }

   if (element.type === undefined) {
    const error = {
      title: `Expecting a valid React element from the story: "${selectedStory}" of "${selectedKind}".`,
      description: stripIndents`
        Seems like you are not returning a correct React element from the story.
        Could you double check that?
      `,
    };
    return renderError(error);
   }

   ReactDOM.render(element, rootEl);
   return null;
 }
}

export default function renderPreview({ reduxStore, storyStore }) {
  const state = reduxStore.getState();
  if (state.error) {
    return renderException(state.error);
  }

  try {
    return renderMain(state, storyStore);
  } catch (ex) {
    return renderException(ex);
  }
}

...@UsulPro perhaps you wanna give the decorators a try. The idea is that our story function returns an element, and the decorators can wrap it in a container element. That's all. But the wrapping must be synchronously performed. So they must be resolved as a group.

the decorators will be more complicated since it happens in a reduce loop. Basically, I think we should pull out the inner most decorated call, i.e. the one to our story and resolve that, and then in the then block, wrap its result in any other potential decorators. I guess the answer is something like this:
const fn = context => {
    return getStory(context).then(storyElement => {
      return decorators.reduce((decorated, decorator) => {
          return decorator(decorated, context);
      }, () => storyElement)
   }
}
const fn = decorators.reduce((decorated, decorator) => {
        return (context) => {
          return decorator(() => {
            return decorated(context);
          }, context);
        };
      }, getStory)

...now we just need to give it a spin.

and it turns out, the Storybook team has been planning on removing the context argument:
https://github.com/storybooks/react-storybook/issues/340#issuecomment-238026263

I imagine the API would look like this:
storiesOf('DataViewer')
  .add('test', () => fetch('http://api.someURLtogetdata.com').then(r => r.json())
    .then(({ data }) => <TestStory data={data} />)
  )

@ndelangen what's the latest on async support? I think we are in agreement in what the API looks like, but I don't suppose you could perhaps go over my guesses on how to implement it above or have someone who knows the codebase do so?
I'll likely do it myself in the coming weeks, but it would be helpful to know if I'm on the right rack.

This might just do it: https://github.com/storybooks/storybook/compare/async-render-support?w=1
Testing it now..

Tested, it works great, story re-renders (and promise is re-resolved every time.)
Do you want to give this a try @faceyspacey ?

I made a PR, and will merge it after also adding some documentation and an example in kitchen sink.
Want to add your comments @faceyspacey ?

Wow! I missed this. I'll try to check this out sooner than later.

Hi @ndelangen,
I need to be able to return a promise from the add method, so tried updating my copy of<EMAIL_ADDRESS>to match the given diff, but AFAICT the renderMain function in the file I've edited is never ever invoked.
Am I doing something stupid?

@dchambers Try this diff maybe? https://github.com/storybooks/storybook/pull/1253

Hi @ndelangen, thanks for the help here and sorry I took so long to come back to you.
This diff seems to be an updated but otherwise identical diff to the last one, and the problem I'm seeing is that the renderMain function never seems to be invoked at all.
Scratch that, I've just realized that this code is only used on the client-side, whereas I've been testing within Jest (using storyshot testing). Although it's not currently working for me in the browser either -- I see this when wrapping my story in a Promise.resolve():
Expecting a valid React element from the story: "Available Questions" of "QuestionPanel".
Seems like you are not returning a correct React element from the story.

Could you double check that?

I have a starting point and will try debugging this further tonight...

Hi @ndelangen, I've just looked at this again and your diff does work for storybook proper, but it looks like a separate change would be needed to get this working for storyshots. I'm actually only really adding the promise for storyshots because otherwise I can't delay when the snapshots are taken, and this causes them being taken before any data has arrived, so that I just see the loading indicator.
I spent a good amount of time trying to get this working on the weekend, but had to work almost blind as a result of the fact that debugging doesn't currently work in Node.js (expected to be fixed in 8.4.0) and since console.log() statements were swallowed within the body of the test.
Yay, looks like Node.js 8.4.0 has just been released so will try to debug this now...

I've now been able to get this working for snapshots too. I created an asyncSnapshot test function that I could use instead of the built-in snapshot function, like so:
const asyncSnapshot = ({ story, context }) => {
  return Promise.resolve(story)
    .then(storyVal => storyVal.render(context))
    .then(storyElement => {
      const tree = renderer.create(storyElement, {}).toJSON();
      expect(tree).toMatchSnapshot();
    });
};

initStoryshots({
  test: asyncSnapshot
});

and then I modified the it function in addons/storyshots/src/index.js to return the promise that I was providing it through my test function, like so:
it(story.name, () => {
  const context = { kind: group.kind, story: story.name };
  return options.test({ story, context });
});

As it happens this doesn't actually help me in my case since the asynchronous delay seems to be within the component itself, so that I need some other way to delay the snapshot from being taken to avoid seeing the loading indicator.

I've now been able to work around my particular issue by using a delayedAsyncSnapshot test function like this:
const delayedAsyncSnapshot = ({ story, context }) => {
  return Promise.resolve(story)
    .then(storyVal => storyVal.render(context))
    .then(storyElement => {
      renderer.create(storyElement, {});
      return new Promise((resolve, reject) =>
        setTimeout(() => resolve(storyElement), 0)
      );
    })
    .then(storyElement => {
      const tree = renderer.create(storyElement, {}).toJSON();
      expect(tree).toMatchSnapshot();
    });
};

initStoryshots({
  test: delayedAsyncSnapshot
});

Obviously this is probably only useful to me, whereas the asyncSnapshot function given earlier should probably be the default implementation within snapshot going forwards.

I was actually able to add the delay I need within the test code, so just regular promise support is working great for me. In case it makes it easier to explain, here's a diff for the changes I'm using:
https://github.com/storybooks/storybook/compare/master...dchambers:master?w=1

@dchambers I'm glad you are making progress here. Can I ask the reason for the async story in the first place?

Hi @tmeasday, in my case I'd like to use to Storyshots to do snapshot testing of GraphQL backed components. Although I connect to an in-process mock GraphQL server rather than a real one for Storybook and unit testing, Apollo still returns the data asynchronously which means that all of my snapshots end up rendering 'Loading...' rather than the components I've created.
There may well be other scenarios where the use of promises to delay things might help, but this is the concrete issue I'm facing.
I can spend some time tomorrow evening adding some tests and maybe some docs that provide an example that hopefully helps to make sense of this feature.

@dchambers thanks for the explanation. That makes perfect sense, and I can understand the use cae.

My use case is that I'm trying to use Storyshots with a component that, several levels down in its render tree, uses a component that is lazily loaded with import(...) from a codesplit module. So on first render it's almost entirely blank. Does anyone have any ideas on the easiest way to get Storyshots to wait until the component is loaded to render? Or to just load the component synchronously if in test mode?

@pelotom could you import all the relevant modules in your storyshots (jest) test file in a beforeAll async block? Kind of janky but maybe would work in theory.

@tmeasday I tried that (actually just a regular static import at the top of the file, but it didn't seem to work. I think even if the module is immediately available the promise won't resolve synchronously.

Can you mock import to just do nothing?
On Mon, 16 Apr 2018 at 12:26 pm, Tom Crockett<EMAIL_ADDRESS>wrote:

@tmeasday https://github.com/tmeasday I tried that (actually just a
regular static import at the top of the file, but it didn't seem to work. I
think even if the module is immediately available the promise won't resolve
synchronously.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/issues/713#issuecomment-381462399,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIFyj89v-rjyjgMUMJ2TQ8Zrs519Zb6ks5tpAFNgaJpZM4MVEe6
.

@pelotom this may be getting too complicated, but what about using a different babel plugin for import() then? One of these maybe:
https://www.npmjs.com/package/babel-plugin-dynamic-import-node-sync
https://www.npmjs.com/package/babel-plugin-transform-import-to-require
Could that possibly work?

@tmeasday I'm not using Babel at all in my project (I'm using TypeScript), and would rather not start now. The solution I'm using for now is to pass down an optional override component to use instead of the lazy one if present.

Lol, why the thumbs down??

I mis-clicked ;) Did you get a notification or something? Looks like a thumbs up for me!

@tmeasday @dchambers This is still an issue with storybook and snapshot testing.
Based on the source code I have created a modified version of snapshotWithOptions.  This modified version make sure fetch-mock has finished its work and that all promises are finished before comparing the snapshot to the tree.  This is a copy and paste of existing source code with two lines added.
If an extension point of 'beforeSnapshotComparison' was provided in the existing code, everyone could do this.  In addition, the code that waits on promises to finish could probably just be inserted no matter what (where fetch-mock is developer specific)
const snapshotWithOptions = (options = {}) => ({
    story,
    context,
    renderTree,
    snapshotFileName,
}) => {
    const result = renderTree(story, context, options)

    const match = async (tree) => {
        await fetchMock.flush()   //new code
        await new Promise((resolve) => setImmediate(resolve))   //new code
        if (snapshotFileName) {
            expect(tree).toMatchSpecificSnapshot(snapshotFileName)
        } else {
            expect(tree).toMatchSnapshot()
        }

        if (typeof tree.unmount === "function") {
            tree.unmount()
        }
    }

    if (typeof result.then === "function") {
        return result.then(match)
    }

    return match(result)
}

const asyncMultiSnapshotWithOptions = (options = {}) => ({
    story,
    context,
    renderTree,
    stories2snapsConverter,
}) =>
    snapshotWithOptions(options)({
        story,
        context,
        renderTree,
        snapshotFileName: stories2snapsConverter.getSnapshotFileName(context),
    })

Thoughts?

@waynebrantley I have struggeling with the excact same issue. All my components follows the same pattern, where all data is loaded in componentDidMount(which I mock using fetch-mock in stories), resulting in empty snapshots since the snapshot is captured before the data is done loading.
So your proposal of having an beforeSnapshotComparison extention seems like a great solution for this issue!

@andwaal if you use the above it will help you do exactly what you want - at the expense of just some copied code.   Hopefully, they can just add the extension (with the awaits, etc), but if not - it works great now.

This comment from #696 offers a simple workaround that worked for me.
(sorry for the noise, but this issue is the first result in Google)

The workaround doesn't work in general. E.g., if the component you're trying to render requires the value as a mandatory property. E.g., an ApolloProvider client property.

And how to apply storiesOf to Vue component?


Simple struct unpacking issue

After migrating from std.mem.readIntLittle to std.mem.readInt(..., .little) I was able to compile and run the tests but I'm receiving the following error:
Test [1/14] test.simple struct unpacking... segmentCount = 65280
file Read segment Length = 50
thread 17268 panic: reached unreachable code
C:\Users\giova\scoop\apps\zig-dev\0.12.0-dev.1879\lib\std\debug.zig:342:14: 0x7ff609311aad in assert (test.exe.obj)
    if (!ok) unreachable; // assertion failure
             ^
C:\Users\giova\repos\other\personal\zig-capnp\src\capnp.zig:609:25: 0x7ff60931138c in fromFile (test.exe.obj)
        std.debug.assert(segmentLengthsBuffer.len == try file.read(segmentLengthsBuffer));
                        ^
C:\Users\giova\repos\other\personal\zig-capnp\src\capnp_tests.zig:60:45: 0x7ff609312406 in test.simple struct unpacking (test.exe.obj)
    var message = try capnp.Message.fromFile(file, std.testing.allocator);
                                            ^
C:\Users\giova\scoop\apps\zig-dev\0.12.0-dev.1879\lib\test_runner.zig:181:28: 0x7ff609329c12 in mainTerminal (test.exe.obj)
        } else test_fn.func();
                           ^
C:\Users\giova\scoop\apps\zig-dev\0.12.0-dev.1879\lib\test_runner.zig:36:28: 0x7ff609319be8 in main (test.exe.obj)
        return mainTerminal();
                           ^
C:\Users\giova\scoop\apps\zig-dev\0.12.0-dev.1879\lib\std\start.zig:350:69: 0x7ff609319963 in WinStartup (test.exe.obj)
    std.os.windows.ntdll.RtlExitUserProcess(initEventLoopAndCallMain());

Seems that in the first bytes it's expecting the number of segments but it's not the case.

Ok the issue was related to the binary writing of windows redirect operator, by switching to bash I was able to run the first tests.


Keptn in a box first draft.

@jetzlstorfer take a look at the first draft. Let's synch tomorrow.

Maintenance windows fixed, emoji fixed and small enhancements.


auto detect Seobility

add allow group
       'seobility' => [
            'allow' => [
                '*',
            ]
        ]

not needed


Update Supabase Logo

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

The Logo I found before was the old one, this PR changes it to the new Logo

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

hello?


Select qualifications to be granted from event

As a planner I expect to select the qualifications that users should acquire after participating in an event if the event type allows so.

Is configured on events and not shifts, what if the event has multiple shifts?

Is configured on events and not shifts, what if the event has multiple shifts?

good point. this just leaves us with the question of trainings that span multiple dates, but this should maybe be another issue

good point. this just leaves us with the question of trainings that span multiple dates, but this should maybe be another issue


cloudflare_record resource data attribute is not Idempotent

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
terraform {
  required_version = "1.0.4"

  required_providers {
    cloudflare = {
      source  = "cloudflare/cloudflare"
      version = "2.25.0"
    }
  }
}

Affected resource(s)

cloudflare_record

Terraform configuration files
resource "cloudflare_record" "www" {
  zone_id = "XXXXXXXXX"
  name    = "test-foo"
  value   = "test-foo.foo.com"
  type    = "CNAME"
  proxied = true
}

Debug output
cloudflare_record.www: Refreshing state... [id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the last "terraform apply":

  # cloudflare_record.www has been changed
  ~ resource "cloudflare_record" "www" {
      + data            = {}
        id              = "XXXXXXXX"
        name            = "test-foo"
        # (11 unchanged attributes hidden)
    }

Unless you have made equivalent changes to your configuration, or ignored the relevant attributes using ignore_changes, the following plan may include actions to undo or respond to these changes.

Panic output
No response
Expected output
I's expect zero changes in Terraform plan.
Actual output
  # cloudflare_record.www has been changed
  ~ resource "cloudflare_record" "www" {
      + data            = {}
        id              = "XXXXXXXX"
        name            = "test-foo"
        # (11 unchanged attributes hidden)
    }

Steps to reproduce

terraform init
terraform plan -out my.tfplan
terraform apply "my.tfplan"
terraform plan -out my.tfplan
Plan shows there are changes but there shouldn't be any

Additional factoids
No response
References
No response

duplicate of #1095


[Flake] Basic Tests C# Linux build

toplevel_run_tests_invocations_run_tests_csharp_linux_opt_native_default_coreclr.run_tests_csharp_linux_opt_native_default_coreclr
https://source.cloud.google.com/results/invocations/ce9e553e-f5b5-4d9b-b337-ba0526a62100/targets/github%2Fgrpc%2Ftoplevel_run_tests_invocations%2Frun_tests_csharp_linux_opt_native_default_coreclr/tests

I only saw this fail once and builds over last several days are passing.


Replace MAX_BYTE_SIZE constant with setting

Status
READY
Migrations
NO
Description
The MAX_BYTE_SIZE constant did not allow for customization, which
is necessary for cases where legitimate SAML responses are larger
than 250,000 bytes. This replaces the constant with a setting, which
has a default value of 250,000 bytes, but can be customized like
any other setting.
This was motivated by https://github.com/onelogin/ruby-saml/issues/598, which was motivated by https://gitlab.com/gitlab-org/gitlab/-/issues/329053.
This follows the existing pattern used for encode_raw_saml.
Related PRs
List related PRs against other branches:

branch
PR

Introduce MAX_BYTE_SIZE
link

Introduce inflate option to disable SAML message inflation
link

Todos

[x] Tests
[x] Documentation

Deploy Notes
Nothing noteworthy.
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
git fetch
git checkout gitlab-djensen:gitlab-djensen-use-setting-for-max-byte-size
bundle install;
ruby -Itest test/settings_test.rb

Impacted Areas in Application
List general components of the application that this PR will affect:

Settings
SamlMessage

@dblessing would you mind doing the initial review on this whenever you have some time?

@gitlab-djensen Thanks for opening the PR. Looks good to me, with my limited knowledge of the ruby-saml code. Let's see what the maintainers think.

@pitbulk this PR is ready for your review, whenever you might have some time.
GitLab is hoping you will release a new version of this gem containing this fix, because MAX_BYTE_SIZE was a breaking change for implementations with large messages (example).

👍 looks good to merge

@pitbulk friendly ping, hopefully this is an easy review 🙂

@pitbulk thanks for reviewing!  I just marked both of your comments as resolved.  Should we run the workflow next?  (It's telling me "First-time contributors need a maintainer to approve running workflows.")

Strangely, the workflow ran anyway.  There were a bunch of failures because settings was still optional in some places where it is now required.  I just pushed 2 commits that make settings a required argument in multiple places, which makes this PR a breaking change.   (We could avoid the breaking change by leaving settings as an optional argument and calling OneLogin::RubySaml::Settings.new when settings is not provided.  But that approach is not currently used anywhere in the gem, so it would be a new pattern.)  I'll keep working on this until the tests are green.

We need to avoid breaking changes. If settings is not provided to the decode_raw_saml method, makes sense to keep using the default value, otherwise, the settings object should be there.

@pitbulk gotcha, refactored to be non-breaking (by calling OneLogin::RubySaml::Settings.new when settings is not passed).  Tests are green.  How's it looking now?

@pitbulk this looks good to me.

@pitbulk friendly ping, prompted by a colleague with an affected client.  Does this look good for merge?

Also, after merge, let's get an gem release please :) Lots of great improvements recently.

Sorry I will be back from PTO on 6 and take care of all the pending PRs


Clean install following documentation requires a lot more extra packages

Describe the bug
When following the documentation on a clean project, I needed to install the following packages to get things running.
Both for the wizard and for running the generator.

@vue/compiler-dom
@vue/compiler-ssr
hash-sum
magic-string
merge-source-map
postcss
postcss-selector-parser
lru-cache

To Reproduce
Steps to reproduce the behavior:
yarn init -y
yarn add graphql
yarn add -D @graphql-codegen/cli
yarn graphql-codegen init

Then you will get the first missing package, and so on.
Expected behavior
Installing the generator following the documentation, without any additional packages required to install.
Environment:

OS: MacOS
@graphql-codegen/cli: 1.20.1
NodeJS: v12.16.1

Just ran into the same issue with a deployment on vercel

graphql-codegen deps in my package.json if it helps
  "@graphql-codegen/cli": "^1.13.1",
    "@graphql-codegen/fragment-matcher": "^1.7.0",
    "@graphql-codegen/introspection": "^1.7.0",
    "@graphql-codegen/near-operation-file-preset": "^1.17.11",
    "@graphql-codegen/typescript": "^1.7.0",
    "@graphql-codegen/typescript-document-nodes": "^1.7.0",
    "@graphql-codegen/typescript-operations": "^1.7.0",
    "@graphql-codegen/typescript-react-apollo": "^1.7.0",

I just tried to set this up with react and apollo and having the same issue. I'm working on a react project, it seems silly that I'd be required to install multiple vue packages.

seems like it's a problem with the graphql-tools dependency? Someone's put an issue on that repo with the same problem.
https://github.com/ardatan/graphql-tools/issues/2542

Workaround:
Install version 6.4.0 of @graphql-tools/graphql-tag-pluck
"devDependencies": {
    "@graphql-codegen/cli": "1.20.0",
    "@graphql-tools/graphql-tag-pluck": "6.4.0"
  }

The graphql-tag-pluck got updated today - and it seems to add some Vue and other dependencies.
See versions
The workaround by keeping the latest 1.20.1 version is:
To you package.json add:
 "resolutions": {     "@graphql-tools/graphql-tag-pluck": "6.4.0"   },
This uses the yarn Selective Versions RFC "resolutions" to override nested dependency versions.

For what it's worth, using "resolutions": { "@graphql-tools/graphql-tag-pluck": "6.4.0" }, didn't work for me. I add to manually add the following devDependencies.
"devDependencies": {
    "@cloudvox/mocha-config",
    "@vue/compiler-dom",
    "@vue/compiler-ssr",
    "hash-sum",
    "magic-string",
    "merge-source-map",
    "postcss",
    "postcss-selector-parser"
}

We're aware of the issue :) Patch version will be available in a few minutes
<EMAIL_ADDRESS>

@leroy0211 @dep-dt @frankshwb @benedict-jackson @pakatagoh Could you reinstall depedencies, make sure 6.4.2 is installed and working fine?

6.4.2 is working

agreed, all good here too.


Undefined method createTable

Migration comment shows:
* The following commands can be used in this method and Phinx will
* automatically reverse them when rolling back:
*
*    createTable
*    renameTable
*    addColumn
*    renameColumn
*    addIndex
*    addForeignKey
class CreateUsers extends AbstractMigration
{
	public function change()
	{
		$this->createTable('users')->save();
	}
}

It gets:
  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Call to undefined method CreateUsers::createTable()

Where is createTable?

$this->table('tableName')->create() works.
Looks like annotation and docs need to be updated

@JayPHP would you be interested in sending a pull request after changing the docs? You can do it from the link on top right on http://docs.phinx.org/en/latest/

And could you please make \Phinx\Db\Table@create returns $this?
Now I must write:
$this->table('users')->create();
$this->table('users')
     ->addColumn('password', 'string')
     // ...
     ->save();

Otherwise I must write dropTable in down() method.
I think this way would be better:
$this->table('users')
     ->create()
     ->addColumn('password', 'string')
     // ...
     ->save();

@tariquesani @eGust Sure, I'll try and find the time and PR once done.

@eGust Just call create() at the end.
$this->table('users')
     ->addColumn('password', 'string')
     ->create()

but yes, it should probably return $this.

Should be fixed in master.


fix(blockingproxy): don't pass "--inspect" to the child process

If Protractor is started with --inspect[-brk], child_process.fork
will create a BlockingProxy process with the same argument, and that
will lead to "address already in use" error.

Debug in WebStorm doesn't work if BlockingProxy is enabled.
The new BlockingProxy process tries to use the same port for inspector and fails:
/usr/local/bin/node --inspect-brk=46857 /home/wncm/cyletrip/protractor/built/cli.js ./spec/driverProviderLocalConf.js --useBlockingProxy
Debugger listening on ws://<IP_ADDRESS>:46857/803e1be6-e7dc-4cea-afb9-b6e2a4610cd9
For help see https://nodejs.org/en/docs/inspector
Debugger attached.
(node:857) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
[22:09:28] I/launcher - Running 1 instances of WebDriver
[22:09:28] I/local - Starting selenium standalone server...
[22:09:29] I/local - Selenium standalone server started at http://<IP_ADDRESS>:48641/wd/hub
[22:09:29] I/BlockingProxy - Starting BlockingProxy with args: --fork,--seleniumAddress,http://<IP_ADDRESS>:48641/wd/hub
[22:09:29] E/BlockingProxy - Starting inspector on <IP_ADDRESS>:46857 failed: address already in use
[22:09:29] E/BlockingProxy - Exited with 12
[22:09:29] E/BlockingProxy - signal null
[22:09:29] E/launcher - Error: Error: BP exited with 12
    at ChildProcess.bpProcess.on.on.on (/home/wncm/cyletrip/protractor/built/bpRunner.js:37:24)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
[22:09:29] E/launcher - Process exited with error code 100
Waiting for the debugger to disconnect...
Debugger listening on ws://<IP_ADDRESS>:46857/803e1be6-e7dc-4cea-afb9-b6e2a4610cd9
For help see https://nodejs.org/en/docs/inspector

Process finished with exit code 100


Composition sections should be ordered (oe, ahdis)

ch.fhir.ig.ch-emed#0.3.0 /StructureDefinition-ch-emed-composition-medicationtreatmentplan.html
The sections in the documents should have fix order equivalent to CDA-CH-EMED:

Medication Treatment Plan Section Content Module (or other depending on document)
Remarks Section - coded (DYNAMIC)
Original Representation Section - coded (DYNAMIC)

oe, ahdis

cannot be fixed currently in ch-emed due to inherited constraints (see issue above), but example will be fixed.

Is this about the documentation pages only? As discussed during the last projectathon, the order of these sections is free in CDA-CH-EMED documents.

@qligier : do you mean with documentation pages Remarks Section - coded (DYNAMIC)
and Original Representation Section?

The three components (MTP/PRE/DIS/PADV) Section Content Module, Remarks Section and Original Representation Section are allowed in any order in CDA-CH-EMED documents, so I'm not sure what you meant by saying "[...] fix order equivalent to CDA-CH-EMED".

closed after feedback from @qligier


feat(iam-role-for-service-accounts-eks): EBS fast snapshot restores

Description
Add addition policy to enable fast snapshot restore for ebs csi
refer to this link for the details
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/fast-snapshot-restores.md
Motivation and Context

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

tf-controller plan output:

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

To apply this plan, please merge this pull request.

tf-controller plan output:

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_iam_policy.external_dns[0] will be created
  + resource "aws_iam_policy" "external_dns" {
      + arn         = (known after apply)
      + description = "External DNS policy to allow management of Route53 hosted zone records"
      + id          = (known after apply)
      + name        = (known after apply)
      + name_prefix = "AmazonEKS_External_DNS_Policy-"
      + path        = "/"
      + policy      = jsonencode(
            {
              + Statement = [
                  + {
                      + Action   = "route53:ChangeResourceRecordSets"
                      + Effect   = "Allow"
                      + Resource = "arn:aws:route53:::hostedzone/*"
                    },
                  + {
                      + Action   = [
                          + "route53:ListTagsForResource",
                          + "route53:ListResourceRecordSets",
                          + "route53:ListHostedZones",
                        ]
                      + Effect   = "Allow"
                      + Resource = "*"
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + policy_id   = (known after apply)
      + tags_all    = (known after apply)
    }

  # aws_iam_role.this[0] will be created
  + resource "aws_iam_role" "this" {
      + arn                   = (known after apply)
      + assume_role_policy    = jsonencode(
            {
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRoleWithWebIdentity"
                      + Condition = {
                          + StringEquals = {
                              + "oidc.eks.eu-west-3.amazonaws.com/id/62F1ABD4C6A26E9709758A81A2503178:aud" = "sts.amazonaws.com"
                              + "oidc.eks.eu-west-3.amazonaws.com/id/62F1ABD4C6A26E9709758A81A2503178:sub" = "system:serviceaccount:kube-system:external-dns"
                            }
                        }
                      + Effect    = "Allow"
                      + Principal = {
                          + Federated = "arn:aws:iam::396740644681:oidc-provider/oidc.eks.eu-west-3.amazonaws.com/id/62F1ABD4C6A26E9709758A81A2503178"
                        }
                    },
                ]
              + Version   = "2012-10-17"
            }
        )
      + create_date           = (known after apply)
      + force_detach_policies = true
      + id                    = (known after apply)
      + managed_policy_arns   = (known after apply)
      + max_session_duration  = 3600
      + name                  = "controlplane-0-external-dns"
      + name_prefix           = (known after apply)
      + path                  = "/"
      + tags_all              = (known after apply)
      + unique_id             = (known after apply)
    }

  # aws_iam_role_policy_attachment.external_dns[0] will be created
  + resource "aws_iam_role_policy_attachment" "external_dns" {
      + id         = (known after apply)
      + policy_arn = (known after apply)
      + role       = "controlplane-0-external-dns"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + iam_role_arn       = (known after apply)
  + iam_role_name      = "controlplane-0-external-dns"
  + iam_role_path      = "/"
  + iam_role_unique_id = (known after apply)

To apply this plan, please merge this pull request.

Can anyone review this pr?

This PR is included in version 5.38.0 :tada:


Admonition Documentation wrong or misleading

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
In the documentation, it states that "basic markdown syntax" for admonitions is supported. For me, this would mean the following syntax should work this is also how it works in plugins for vscode like this. However, when trying this out it didn't work. See below. Am I doing something wrong or is the documentation misleading?

Reproducible demo
No response
Steps to reproduce

create new stackblitz
add the following to a markdown page

!!! note "Title"

    This is content

Expected behavior
The admonition is not rendered.
Actual behavior
The admonition should be rendered.
Your environment

Public source code: https://stackblitz.com/edit/github-uetkkd?file=docs%2Fintro.md
Public site URL:
Docusaurus version used:
Environment name and version (e.g. Chrome 89, Node.js 16.4):
Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

[ ] I'd be willing to fix this bug myself.

as the documentation page states, Docusaurus uses colons (:), not exclamation points for admonitions. this syntax is also more compatible with the directive syntax which may become standardized in CommonMark (https://talk.commonmark.org/t/generic-directives-plugins-syntax/444)

Yes, I'm not sure where the confusion comes from or how we can improve the wording. The documentation states:

In addition to the basic Markdown syntax, we use remark-admonitions alongside MDX to add support for admonitions.

"In addition to the basic Markdown syntax" means admonitions are not basic Markdown syntax😅 There's nothing as "standard admonition", and as @duanwilliam pointed out, we are probably closer to the would-be standard than !!!.
Documentation is meant to be "followed", not to be "inferred". Anything that's not explicitly stated/specced should not be taken as guaranteed behavior.


Readme update

@Akshat0694 okay i get it that action.yml is just a template ....no need to add it to .github/workflows folder


Improvement/reduce network calls

Introduces new cached variables to the library, pytube.__js__ and pytube.__js_url__, in order to reduce the number of network requests made by an application. The media player javascript typically won't change during the course of an application run, so there's no reason to download the javascript for every video. This should speed up the code by a second or two here or there on longer runs that download multiple videos.

cc: @RONNCC

We should probably do a minor version bump when this, #835 and #838 get merged

cc: @RONNCC for this, #835, and #838
p.s. hope you had a good vacation!

@tfdahlin  hope your Thanksgiving 🦃  was good! I know I definitely gained a few pounds haha 😄

It wasn't bad! Can't wait to be able to spend it with friends and family next year though

@RONNCC can we get a minor version bump + push to pypi?


How to deploy the opensearch  EKS cluster with multi zone in same region in.

Hi Team,
We want to deploy the EKS cluster with https multi zone in same region.
In helm charts what changes need to  be change in values.yaml file.
We added the below lines in our config file.
node.attr.availabilityzone: ${zone}
cluster.routing.allocation.awareness.attributes: zone
cluster.routing.allocation.awareness.force.zone.values: ["us-east-2a","us-east-2b","us-east-2c"]
We are not able to see zone info inside the pod.
Please let us know how to add a zone to environment variables.
Please let us know what changes are to do from our side.
Thanks,
Anil

Hey @ganilmca if I'm not wrong you want to run the OpenSearch in multizone, please try with the following information.

Make sure your EKS cluster is already on HA, multi zone nodes, consider as a and b.
Run the kubectl get nodes to see the exact zone label.
Use the chart  nodeAffinity settings to restrict the desired nodes.

  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
      - matchExpressions:
        - {key: zone, operator: In, values: ["a"]}

You can even consider taints and tolerations to restrict on a specific group, but nodeAffinity works better as you dot have to add extra taints and tolerations to the node groups.

Having nodeAffinity you can now isolate your desired OpenSearch component to specific label node that is running in a specific zone.


[doc] Improve API's documentation

Napi doc now only lists methods and assume users have experience or mindsets about programmatic usage.
This is not universally true. To better guide users, the doc site should be rewritten into

why
guide
examples
caveats

Python should also have similar docs.

Hello @HerringtonDarkholme, I checked the public-facing documentation for a description of the Python API and I could not yet find it. If you can point me in the direction of this documentation and give me some suggestions for testing that you would like me to complete, I would be glad to try out the Python bindings and provide feedback. Thanks!

Hi @gkapfham, sg-team has not yet enough time to prepare the Python API doc.
However, you can look at the test case https://github.com/ast-grep/ast-grep/tree/main/crates/pyo3/tests
to know the usage of Python API.
There is also a type declaration file for Python, which will be useful as well.
https://github.com/ast-grep/ast-grep/blob/main/crates/pyo3/ast_grep_py/ast_grep_py.pyi


Use in Winforms

Hi, I downloaded the new version and I noticed that if you try to use the files in Winforms it contains the following errors in compilation:

The name 'ZipFile' does not exist in the current context.
The type or space name of the name 'ZipArchive' was not found.

In the previous version using Winforms returned no error.

ZipFile and ZipArchive require you to add a refernence to "System.IO.Compression" and "System.IO.Compression.FileSystem". https://imgur.com/Vwjmjy7

Thanks, I didn't notice this.

Made a quick test in winforms if you need it. TestClientServer


Add xValid checks where xValues needs to be used

Description:
Added xValid checks in locations where invalid values were blowing up the code.

Hi @derekgengenbacher-wf - the v1.1 release addresses this issue


Add Chinese translation

Hello, I trying to translate your mod to Chinese for a better promotion in Chinese Minecraft community. Here is the json.
But here's one question that what "Luna" mean in modname "Luna Slimes"? It's simply represented "moon", or your authorname?
If it is latter, I need to modify L2.

The Luna was added just because of my name


Bug: New popover commands do not respect the default mode setting

When using any of the commands to open a new popover, they all open in edit mode regardless of the "default mode" setting. Some people seem to think this is a bad thing.

They follow the setting in the Editor tab, though?

Yeah, I'm not sure yet how to best respect these two different settings. The reporter wanted to open a file in a new popover and expected it to respect the default hover editor mode. It's a fair assumption but I'm sure some people would expect/want the opposite.


<EMAIL_ADDRESS>does not work with GCG typescript-urql plugin

Describe the bug
Repository showing the issue: https://github.com/esistgut/testurql
check generated.ts, there is the following error on line 1325:
Argument of type '{ requestPolicy?: Urql.RequestPolicy | undefined; context?: Partial<Urql.OperationContext> | undefined; pause?: boolean | undefined; variables?: Exact<{ [key: string]: never; }> | undefined; query: DocumentNode; }' is not assignable to parameter of type 'UseQueryArgs<Exact<{ [key: string]: never; }>, AllFilmsQuery>'.   Type '{ requestPolicy?: Urql.RequestPolicy | undefined; context?: Partial<Urql.OperationContext> | undefined; pause?: boolean | undefined; variables?: Exact<{ [key: string]: never; }> | undefined; query: DocumentNode; }' is not assignable to type '{ requestPolicy?: RequestPolicy | undefined; context?: Partial<OperationContext> | undefined; pause?: boolean | undefined; } & { query: string | ... 1 more ... | TypedDocumentNode<...>; variables: Exact<...>; }'.     Type '{ requestPolicy?: Urql.RequestPolicy | undefined; context?: Partial<Urql.OperationContext> | undefined; pause?: boolean | undefined; variables?: Exact<{ [key: string]: never; }> | undefined; query: DocumentNode; }' is not assignable to type '{ query: string | DocumentNode | TypedDocumentNode<AllFilmsQuery, Exact<{ [key: string]: never; }>>; variables: Exact<{ [key: string]: never; }>; }'.       Types of property 'variables' are incompatible.         Type 'Exact<{ [key: string]: never; }> | undefined' is not assignable to type 'Exact<{ [key: string]: never; }>'.           Type 'undefined' is not assignable to type 'Exact<{ [key: string]: never; }>'.ts(2345)
if you change urql version to 3.0.3 and do an npm i the error disappears.
Reproduction
https://github.com/esistgut/testurql
Urql version
urql 3.0.4
Validations

[X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
[X] Read the docs.
[X] Follow our Code of Conduct

If I'm understanding this correctly, this is using generators that generate wrapper hooks for React and specifically for the urql (i.e. react-ueql) package.
To keep things short, this is the issue: variables?: Exact<{ [key: string]: never; }> | undefined; and this is obviously not matching. I mean, there could be more issues.
Anyway, this codegen plugin isn't being maintained by the GraphQL Code Generator project any longer, and there's several reasons for that which we don't really have to get into right now 😅 It's also something we don't and can't support. While we have ambitions to be a little more active in providing a TypeScript plugin/generator of our own in the future — which would be officially supported — as you can see, we can't properly maintain type compatibility with these specific type patterns indefinitely, especially if we're not aware of them
So, tl;dr please switch to using one of their approaches that generate TypedDocumentNode. They have some great documentation on the effort, and while it's maybe not always advertised everywhere, TypedDocumentNode generation is superior in all ways to generating hooks or function wrappers.
It works with GraphQL files, inline strings, tagged template literals, etc; there's several ways of generating them with GCG.
Best of all, they just wrap around DocumentNodes and add generic types, so wherever you pass them to urql, @urql/core, or any other API we maintain, their types will infer other types in our API ✌
Hope that makes sense. I'll still leave this open for a bit as a notice, but I'll rename the title for clarity.
Let me know if you have any questions ♥

Hi @kitten,
I'm not sure what you mean by TypedDocumentNode approach, I searched the documentation and found https://the-guild.dev/graphql/codegen/plugins/typescript/typed-document-node but this seems to be deprecated, as many other plugins, in favor of the client-preset plugin.
The client-preset approach is the one used in the urql documentation too so I reworked my sample following https://formidable.com/open-source/urql/docs/basics/typescript-integration/, you can check it on the testnew branch: https://github.com/esistgut/testurql/tree/testnew
It appears to be still showing some kind of regression regarding "variables" in 3.0.4:
Argument of type '{ query: TypedDocumentNode<AllFilmsQuery, Exact<{ [key: string]: never; }>>; }' is not assignable to parameter of type 'UseQueryArgs<Exact<{ [key: string]: never; }>, AllFilmsQuery>'.
  Type '{ query: TypedDocumentNode<AllFilmsQuery, Exact<{ [key: string]: never; }>>; }' is not assignable to type '{ requestPolicy?: RequestPolicy | undefined; context?: Partial<OperationContext> | undefined; pause?: boolean | undefined; } & { query: string | ... 1 more ... | TypedDocumentNode<...>; variables: Exact<...>; }'.
    Property 'variables' is missing in type '{ query: TypedDocumentNode<AllFilmsQuery, Exact<{ [key: string]: never; }>>; }' but required in type '{ query: string | DocumentNode | TypedDocumentNode<AllFilmsQuery, Exact<{ [key: string]: never; }>>; variables: Exact<{ [key: string]: never; }>; }'.ts(2345)
urql-core-chunk.d.ts(751, 5): 'variables' is declared here.

this disappears as soon as I switch to version 3.0.3.
I can work around passing an empty variables object (variables: {}) but this doesn't seem right.

Please note that my last sample does not use typescript-urql any longer.

@graphql-codegen/typed-document-node will still just work, for instance,
@graphql-codegen/client-preset will also generate TypedDocumentNodes so it'll also work
So, both are supported because they interact with urql via the TypedDocumentNode type.

However, settings the Variables generic to Exact<{ [key: string]: never; }> is not supported. I have issued a patch for this anyway in #3029.
That said though, even with this patch, I cannot guarantee that @graphql-codegen/typescript-urql will work or will continue to work.
We've basically never really recommended or adopted support for it and code generators that generate wrappers. The types generally don't work out, and we can't treat internal type structures as public interfaces; instead, only exposed types (and not how they internally work) are public API surface for us. Hence, the need and support for TypedDocumentNode, which has now been around for a while.
So, tl;dr I'll treat #3029 as a resolution of this issue, but I can't 100% guarantee that this fixes your issue. Even if it doesn't however, we can't treat this as our own issue anymore, as we can't influence the types generated by another tool.

@esistgut: Yep, you're right; just tested it and Exact<{ [key: string]: never; }> is still generated by client-preset at least, so the fix should take care of that. I think though that typescript-urql will still fail, since it's just too reliant on our types working a certain way

Should be resolved in<EMAIL_ADDRESS>Just make sure that you deduplicate @urql/core, as per usual, so you don't duplicate versions and hence keep the old type around

I can confirm<EMAIL_ADDRESS>fixes both the client-preset and the old typescript-urql approaches.


Fix unintentionally losing attributes of closures inside extra optional closure

This PR fixes #974.
For example, when parsing this type:
(@convention(c) () -> ())?
The old behavior of unwrapping it turns into (() -> ()).
The new behavior now retains the attributes as well as follow existing closure behavior (@convention(c) () -> ()).

I added a few more tests.
I found the behavior of this test to be quite surprising. I hope it's expected:
expect(typeName("(((@escaping (@escaping ()->())->())))").unwrappedTypeName).to(equal("(@escaping () -> ()) -> ()"))

I think this fix is wrong. I ran into more edge cases in the past that this fix doesn't work on. Closing.


.

This was just some overly alertness on my end when seeing that the deploy contract had a different name, but its not an issue and has therefore been closed.

This is super vague. Can you explain clearly ?

As said above this was not a library issue in the end.


Transfer repository to organization

Hello,
I would like to start a discussion on whether or not we should move this project to it's own organization. It's grown pretty big, and I feel like everyone would benefit from an organization repository.
Tell me what you think below.

Hi!
It may be a good idea. I haven't worked with Github organizations before, what kind of benefits will it add?

The project was moved correctly to an organization, protonmail-desktop. From now on we will work this way.


Fix the Glossary

There are two glossary pages, the old one, which needs cleansing, and the new one imported from the handbook (/handbook/glossary.html).

[x] Both need to be merged. Final format has to be decided.
[ ] Automatic glossary tooltips like we had in the handbook would be great.

Take a look at this for the building of the glossary table:
https://bitbucket.org/vinay.sajip/sphinx_sizzle_theme/src/master/sphinx_sizzle_theme/__init__.py
This builds a JS file with the WHOLE glossary. ALL pages then load it and a JS method that injects the tooltips.


Add batch edit / multi-select

Allow operations to be applied to several documents at once:

Delete
Adding a tag
Trigger re-import

Yes this is an outstanding feature I want to add myself.
Will try to get around to it in the close future


Add comment about pytorch to phi3 demo

@aaronpowell  you can run the phi3 demo now by just doing python phi3_demo.py


nested model is overwriting parent model with the same name

I have nested tree (from mongodb) like this:
var nodes = {"name": "test 1", "children": [{"name": "test 1.1", "children": [{"name": "test 1.1.1", "children": [{"name": "test <IP_ADDRESS>", "children": [/*...*/]}]}]}]}

my html:

nested models do not have functions for work with db (such as $update)

Hi, from the description, it is not clear what the issue. Would it be possible for you to create a plunker?

By the way, documentation for ngRepeat doesn't include information about the maximum supported depth in nested repeats ;)

the nested model will attach to the closest parent form control, and will overwrite whatever was there before --- so, you should use the new interpolated model name feature to work around this

By the way, documentation for ngRepeat doesn't include information about the maximum supported depth in nested repeats ;)

There is no "maximum supported depth", if you recurse indefinitely, you'll get an infdig error for sure, or possibly crash the browser depending on how the recursion is set up. otherwise, you'll just hurt performance as you add more levels

I will have to create a render renderer.html template for each depth models with different names?

@Maiti there are two issues

resolving a recursive directive (there are many blogs and solution out there, just check any)
having an isolated directive will allow you not to have to create different templates

One way or another, these are not issues, so please use the appropriate channels to get support, this place is not for question


Cant stay still in bed.

Reproduction
Lie down on bed, watch the animation glitch.
Screenshots
https://github.com/space-wizards/space-station-14/assets/47093363/1af94102-1170-49be-b20a-9b25ddca5041
Additional context
NA

i think it's a dupe issue, an even more a have seen a fix pr for it

https://github.com/space-wizards/space-station-14/pull/29520

Fixed by #29653


Running neural_artistic_style.py without CUDA uses only 1 core

Hi,
I'm running this script without CUDA and trying to make it work on CPU alone. Problem is, only 1 core is being used out of 4. Is it a bug or multiple CPU cores are not supported?

Your observation is absolutely right. The convolution operations are not very efficient on the CPU - they are not even parallelized. If I have the time at some point I would like to implement them more efficiently. Probably using im2col and matrix multiplications.

Ok, thanks. Closing this issue then.

Fine, I'll update this if anything should happen. :)


Official Week 7 keyShit function

Released by MtH on Twitter. https://twitter.com/emmnyaa/status/1387070779838377986

probably missing a bunch of code scattered about other places in PlayState
We'll see from Angel's comment, probably won't be added though.

probably missing a bunch of code scattered about other places in PlayState
We'll see from Angel's comment, probably won't be added though.

i could add it in the regular fnf source without much tinkering and the stuff i had to change seems to already be done here

Thanks for bringing this to my attention, however, the code from the pastebin contains some anomalies (e.g. including some code that wasn't in the transpiled JS code that could have minor bugs with the rest of the built-in functions). Some of the code also looks like it's from the input system developed by KadeDev for KadeEngine, which, to my knowledge at least, he didn't make v0.2.8's Input System, so I don't know why those elements would be there. When I'm free, I'll look into the pastebin further and merge any piece of non-conflicting code into the project.


Datahub wont start in the docker compose setup

Thank you very much for your hard work!
I know it is challenging to tame all the different software packages.
The standard docker-compose.yml works like a charm but with the .x86 I have the problem that I cannot get the datahub-gms container as well as elasticsearch to stay in healthy state.
I use a 8vcpu and 64 GiB machine on DigitalOcean to tinker with the setup for myself.
Is there maybe a trick to get Datahub working? This is next to Iceberg the thing I would really like to test :)
Thank you very much!

Hi khaferkamp, I was running the Datahub on much smaller machine. However I'm not DataHub expert. I recommend you to ask on their Slack. Regards ZD


Feature: Improved (but hacky) context menu loading

In this PR, a dummy context menu is generated when the application is launched.
I know this is hacky, but this certainly improves the performance of the first appearance of the context menu.
Resolved / Related Issues

[ ] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #issue...

Validation
How did you test these changes?

[X] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

This works really well for folders, is there anything we can do for files as well?

This works really well for folders, is there anything we can do for files as well?

It seems work well for files as well to me.

It's on and off, very likely depends on what else is opened at the time.


msnbc failing

youtube-dl -v http://www.msnbc.com/all-in-with-chris-hayes/watch/the-chaotic-gop-immigration-vote-314487875924
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.msnbc.com/all-in-with-chris-hayes/watch/the-chaotic-gop-immigration-vote-314487875924']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.8 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[generic] the-chaotic-gop-immigration-vote-314487875924: Requesting header
WARNING: Falling back on generic information extractor.
[generic] the-chaotic-gop-immigration-vote-314487875924: Downloading webpage
[generic] the-chaotic-gop-immigration-vote-314487875924: Extracting information
[debug] Invoking downloader on u'http://www.msnbc.com/all-in-with-chris-hayes/watch/the-chaotic-gop-immigration-vote-314487875924'
[download] Destination: The chaotic GOP immigration vote _ MSNBC-the-chaotic-gop-immigration-vote-314487875924.unknown_video
[download] 100% of N/A in 00:00

MSNBC.com will be support in the next version. Thanks for the report.

Here's a sample of MSNBC failing:
https://www.msnbc.com/rachel-maddow/watch/sanders-deeply-satisfied-to-see-his-2016-ideas-in-2020-candidates-63630405955?cid=sm_npd_ms_tw_ma
`frankentosh:~ spork$ youtube-dl https://www.msnbc.com/rachel-maddow/watch/sanders-deeply-satisfied-to-see-his-2016-ideas-in-2020-candidates-63630405955?cid=sm_npd_ms_tw_ma
[ThePlatformFeed]<PHONE_NUMBER>5: Downloading JSON metadata
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/bin/youtube-dl/main.py", line 19, in
File "/usr/local/bin/youtube-dl/youtube_dl/init.py", line 474, in main
File "/usr/local/bin/youtube-dl/youtube_dl/init.py", line 464, in _real_main
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2008, in download
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 807, in extract_info
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 873, in process_ie_result
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/theplatform.py", line 411, in _real_extract
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/theplatform.py", line 345, in _extract_feed_info
IndexError: list index out of range
frankentosh:~ spork$ which youtube-dl
/usr/local/bin/youtube-dl
frankentosh:~ spork$ youtube-dl --version
2019.07.12
frankentosh:~ spork$
`


Update authorizeSubscribe documentation in README

The example suggested that the authorizeSubscribe method receives the topic as a parameter (like in mosca) but it takes a subscription object.

I've only changed the README so I don't know why the build failed

Thanks!! :)

I updated fastparallel, and there was a bug in a test.


Can this be used for Teams

I tried using the php file for bulk updating the webhooks for an user and it worked just fine. However, I want to bulk update the Teams repository webhooks.
Is this possible?
I tried some modifications to bitbucket_bulk_add_webhook.php but it is not working.
Thanks,
Sarang

@felladrin @interativa

Hi, Sarang.
I don't know if it would work for a team, as it needs an account for using the API.
Couldn't you assign a user (the user you'll set up for this php script) to all repositories?
In our company, we use it under a single account, which holds all repos. And, from that account, we allowed all other company developers to access the account repositories.

Thanks @felladrin for a quick reply.
However in our company, we have Team created with multiple repositories in it. The team do have a teamid, email address but does not have a password to authenticate. There are multiple users who have admin rights, I am one of them.
There is bitbucket API for Teams and the URL for accessing Teams repositories is different than account. Whenever I run the script with my bitbucket username, it only lists repositories created by me or under my name and does not list the Team repositories.
Can you check if this can run/modified for the team? I am novice to php and could not find better modules for bitbucket in python, which i know little bit.

@sarangvyas commented on Mar 7, 2016, 12:42 AM EST:

Thanks @felladrin for a quick reply.
However in our company, we have Team created with multiple repositories in it. The team do have a teamid, email address but does not have a password to authenticate. There are multiple users who have admin rights, I am one of them.
There is bitbucket API for Teams and the URL for accessing Teams repositories is different than account. Whenever I run the script with my bitbucket username, it only lists repositories created by me or under my name and does not list the Team repositories.
Can you check if this can run/modified for the team? I am novice to php and could not find better modules for bitbucket in python, which i know little bit.

Check out my fork here: https://github.com/WillPresley/bitbucket-bulk-add-webhook
I also replied to your comment in the older studio24 repository.

Can you check if this can run/modified for the team? I am novice to php and could not find better modules for bitbucket in python, which i know little bit.

I understand, @sarangvyas, but unfortunately I can't test it for teams.
I hope @WillPresley's fork can help you with that matter.
For now, this script will remain as is.


[NETBEANS 470] Var shows as keyword in jdk8, 9

SourceLevel is not passed to JavaLexer, hence version is set to default, which is the latest version supported. So version always set to 10.  Fixed by passing version as inputAttribute to JavaLexer.

+1

Any reason not to merge this?

Thanks, merging.


Add PHP-Curl-Class

These user agents make up about 1% of the traffic received by our server. Would it be possible to get them added to the list?
Thanks!

Thanks a lot for your contribution!

Thanks for maintaining this super useful repo! 👏


Removing deprecated refinements from ez.file()

Removing things deprecated in #1442
Addressing the future v17

coverage: 100.0%. remained the same
when pulling 6c710beeb4543d28be288a147c236e1f0aaa93fb on drop-file-custom-refinements
into 60500c6c0780c4528d72dfd2bacf690ce75a2011 on master.


Heatmap of observations

@stephpenn1 something like this?

Plotting the data by quarter seems better to me; thoughts?

Yes I like this - leaning towards quarterly but am going to do some exploring on my own with tick marks and will come back with thoughts!

If we go the monthly route (also using my google drive downloaded data i see very obviously that it did split the download into multiple zips):

Does the above graph provide extra clarity to use the monthly plotting? If it's still too confusing, I say we go with quarterly with more tick marks.
Now complicating it a step further, it would be really cool to have a waffle chart with data availability colored by the Instrument column :)

Whoah, cool graph you made, although why all the missing data? 😕

it would be really cool to have a waffle chart with data availability colored by the Instrument column

Oh!

Missing data is because i only used one of the zip files what google drive downloaded (I thought the others were duplicates)

Oh got it, thanks.
Are you going to try the waffle chart? Is that like what you did for the COSORE paper?

I'm trying it out but if it becomes too complicated we'll go with your existing code.
Currently, does this only count # of rows and not "look" into the files?
results$rows[i] <- length(readLines(fls[i])) - 1

Exactly right!

fls <- list.files("~/Documents/data package/v1-1 beta/", pattern = "*.csv$", full.names = TRUE, recursive = TRUE)

library(tibble)
results <- list()

for(i in seq_along(fls)) {
    message(basename(fls[i]))

    # results$rows[i] <- length(readLines(fls[i])) - 1
    results[[basename(fls[i])]] <- readr::read_csv(fls[i]) %>% group_by(Site, Instrument, year(TIMESTAMP), month(TIMESTAMP)) %>% summarise(n = n())
}

bind_rows(results) %>%
    rename(Year = `year(TIMESTAMP)`, Month = `month(TIMESTAMP)`) %>%
    arrange(Site, Year, Month) -> r

r %>% group_by(Site, Instrument, Year, Month) %>%
    summarise(n = sum(n)) %>%
    arrange(Month, Instrument) %>%
    mutate(data_present = ifelse(n > 0, "Yes", "No"), Month = month.abb[Month]) %>%
    filter(Site == "MSM") %>% select(-n) %>% ggplot() +
    geom_tile(aes(x = factor(Month, levels = month.abb), y = Instrument, fill = data_present), size = 01) +
    facet_wrap(~Year) +
    theme_minimal() +
    theme(axis.text.x = element_text(angle = 45, vjust = 0.5, hjust=1)) +
    labs(x = "Month") +
    scale_fill_manual(values = "palegreen3")

This will be useful for users but also for you/us. It seems like a great way to look for unexpected missing data streams, etc.

Good to merge once checks pass


Universal Transformer appears to be buggy and not converging correctly

Summary
Universal Transformer appears to be buggy and not converging correctly:

Universal transformer does not converge on multi_nli as of the latest tensor2tensor master (9729521bc3cd4952c42dcfda53699e14bee7b409).  See below for reproduction

UT does converge on multi_nli as of August 3 2018 commit 5fff1cad2977f063b981e5d8b839bf9d7008e232 (we didn’t run this fully out, but it was making meaningful progress, unlike below, so we terminated it and considered it successful).

To confirm this was not simply an odd issue with multi_nli, we tried UT with a number of other problems (exact repo not shown below), including ‘lambada_rc’ and ‘stanford_nli’ (run at commit ca628e4fcb04ff42ed21549a4f73e6dfa68a5f7a from around October 16 2018)  All of these failed to converge.

Environment information
Docker image based off nvidia/cuda:9.0-devel-ubuntu16.04
Tf version: tensorflow-gpu=1.11.0
T2t version: Tensor2tensor master at commit 9729521bc3cd4952c42dcfda53699e14bee7b409 on Oct 30 2018.
We also saw this failed behavior on tf-nightly-gpu==1.13.0.dev20181022
Reproduce
Problem: multi_nli
Model: universal_transformer
Hparams_set: universal_transformer_tiny
python3 /usr/src/t2t/tensor2tensor/bin/t2t-trainer
--data_dir="DATA_DIR"
--eval_early_stopping_steps="10000"
--eval_steps="10000"
--generate_data="True"
--hparams=""
--hparams_set="universal_transformer_tiny"
--iterations_per_loop="2000"
--keep_checkpoint_max="80"
--local_eval_frequency="2000"
--model="universal_transformer"
--output_dir="OUTPUT_DIR"
--problem="multi_nli"
--t2t_usr_dir="T2T_USR_DIR"
--tmp_dir="T2T_TMP_DIR"
Run was stopped after 50000 steps due to lack of convergence as loss fluctuates between 1.098 and 1.099.
INFO:tensorflow:Saving dict for global step 50000: global_step = 50000, loss = 1.0991247, metrics-multi_nli/targets/accuracy = 0.31821653, metrics-multi_nli/targets/accuracy_per_sequence = 0.31821653, metrics-multi_nli/targets/accuracy_top5 = 1.0, metrics-multi_nli/targets/approx_bleu_score = 0.7479816, metrics-multi_nli/targets/neg_log_perplexity = -1.099124, metrics-multi_nli/targets/rouge_2_fscore = 0.0, metrics-multi_nli/targets/rouge_L_fscore = 0.31869644

Paging @MostafaDehghani :)

digging through the diff between 5fff1cad2977f063b981e5d8b839bf9d7008e232 (roughly August 3 2018 our last working merge from upstream) and 9729521bc3cd4952c42dcfda53699e14bee7b409 (master as of yesterday)
https://github.com/tensorflow/tensor2tensor/compare/5fff1cad2977f063b981e5d8b839bf9d7008e232...tensorflow:9729521bc3cd4952c42dcfda53699e14bee7b409
we just ran 9729521bc3cd4952c42dcfda53699e14bee7b409 with
https://github.com/tensorflow/tensor2tensor/blob/9729521bc3cd4952c42dcfda53699e14bee7b409/tensor2tensor/models/research/universal_transformer.py#L399 switched back to sepconv
and https://github.com/tensorflow/tensor2tensor/blob/9729521bc3cd4952c42dcfda53699e14bee7b409/tensor2tensor/models/research/universal_transformer.py#L419 back to False and we are seeing convergence (accuracy 0.49 at step 2000).
going to do runs to narrow which one of those changes is responsible.

switching only https://github.com/tensorflow/tensor2tensor/blob/9729521bc3cd4952c42dcfda53699e14bee7b409/tensor2tensor/models/research/universal_transformer.py#L419 back to False gets me a run that is converging.
https://github.com/tensorflow/tensor2tensor/pull/1192

It seems to have been changed in #1036 by @MostafaDehghani

Oh! Yes, this is my fault! I'm really really sorry!
I actually fixed this in a PR (https://github.com/tensorflow/tensor2tensor/pull/1045/commits/9bec469e9daf62dbad41c3b6fbf31f9f8ee1483d#diff-750434e84a49123af08c4226eb4962f7R419), but I closed that PR because of another problem! Anywyas, I'm sending a new PR to fix this!

Fixed it in #1194.

Isn't it like this:
Behavior before #1194:
use_memory_as_final_state=True
universal_transformer_layer returns (extra_output, extra_output)
Which leads to:
universal_transformer_encoder returns common_layers.layer_preprocess(extra_output, hparams), extra_output
universal_transformer_decoder returns common_layers.layer_preprocess(extra_output, hparams), extra_output
Behavior after #1194:
use_memory_as_final_state=False
universal_transformer_layer returns (output, extra_output)
Which leads to:
universal_transformer_encoder returns common_layers.layer_preprocess(output, hparams),
extra_output
universal_transformer_decoder returns common_layers.layer_preprocess(output, hparams), extra_output
?
Also I'm not sure about what you've written about Behavior with #1192.
p.s.
Note that removing the two lines in the universal_transformer_encoder don't change anything, as it was checking for the use_memory_as_last_state not the use_memory_as_final_state! use_memory_as_last_state were not defined, so if hparams.get("use_memory_as_last_state", False): was alwayse false :)

Hmm @MostafaDehghan, how could this be true?
Behavior before #1194:
use_memory_as_final_state=True
universal_transformer_layer returns (extra_output, extra_output)
given (this is before 1194):
  output, _, extra_output = tf.foldl(
      ut_function, tf.range(hparams.num_rec_steps), initializer=initializer)

  # This is possible only when we are using lstm as transition function.
  if hparams.get("use_memory_as_final_state", False):
    output = extra_output
 if hparams.mix_with_transformer == "after_ut":
   output = add_vanilla_transformer_layer(output, hparams.num_mixedin_layers)

 return output, extra_output

With use_memory_as_final_state=True (as it was set), we never enter the 'if' which sets output=extra_output.


⚠ BCR Bot has degraded performance

In 2ca5d5d, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1191 ms

Resolved: BCR Bot performance has improved in 9d705c6.


Vrrpe pynos

Vrrpe pynos calls for

Vrrpe
Vrrpe_vip
3.Vrrpe_vmac

closing this as new request was created addressing the changes