Release 0.10.0

Considering its been 3 months since the last crates.io release of the comic-text library isn't it about time for the release of 0.10.0?
Apparently, utilizing libraries like iced can not show fonts if using certain Linux distros in combination with version 0.9.0.
https://github.com/iced-rs/iced/issues/2005
This issue seems to be fixed with the current main branch

cosmic-text 0.10.0 has been released: https://github.com/pop-os/cosmic-text/releases/tag/0.10.0


refactor: gets rid of unencrypted emit in private_context

Please read contributing guidelines and remove this line.

#7236  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 65.4 (-89%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 235 (+291%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,412
3,058
1,482 (+1%)
1,648 (+2%)
1,500 (-2%)

proof_construction_time_sha256_100_ms
43,849
11,775
5,444
5,411
5,347

proof_construction_time_poseidon_hash_ms
78.0 (+1%)
34.0
34.0
58.0
88.0

proof_construction_time_poseidon_hash_30_ms
1,516
415
199 (-1%)
227
269 (+1%)

proof_construction_time_poseidon_hash_100_ms
5,754
1,571
719
761
796

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,468
9,440

l1_rollup_execution_gas
610,285
610,289
610,261

l2_block_processing_time_in_ms
752 (-1%)
1,422
2,688 (-1%)

l2_block_building_time_in_ms
25,364 (-1%)
58,399 (+14%)
100,523

l2_block_rollup_simulation_time_in_ms
25,364 (-1%)
58,399 (+14%)
100,522

l2_block_public_tx_process_time_in_ms
21,806 (-1%)
54,579 (+15%)
96,788

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
7,024 (-1%)
9,973 (+1%)

node_database_size_in_bytes
12,206,160
16,072,784

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
69.4 (+4%)
13,873

GasToken:set_portal
17.8 (+4%)
3,495

Token:constructor
93.2
24,207

FPC:constructor
63.3 (-1%)
13,893

GasToken:mint_public
52.8 (+1%)
10,241

Token:mint_public
:warning: 65.4 (-89%)
19,216

Token:assert_minter_and_mint
:warning: 235 (+291%)
13,034

AuthRegistry:set_authorized
32.4 (+1%)
7,869

FPC:prepare_fee
197 (+29%)
15,129

Token:transfer_public
38.7 (-23%)
31,425

FPC:pay_refund
189 (-9%)
28,061

Benchmarking:increment_balance
2,721
15,407

Token:_increase_public_balance
55.6 (-1%)
15,089

FPC:pay_refund_with_shielded_rebate
200 (-1%)
29,148

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.152 (-3%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3
16.8
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.597
0.515
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.3
76.3 (+1%)
129 (-2%)
247
469

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.493
0.469 (+1%)
0.444 (-1%)
0.446
0.438

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.5 (-1%)
111
180 (-1%)
352 (-1%)
691

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.503 (-1%)
0.498 (-1%)
0.476 (-1%)
0.476 (-1%)
0.475

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.5 (-1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.516 (-1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Fix DCE for ownership forwarding instructions

DCE deletes ownership forwarding instructions when it doesn’t have useful users.
It inserts destroy_value/end_borrow for its operands to compensate their lifetimes.
DCE also deletes branches when its successor blocks does not have useful instructions.
It deletes blocks and creates a jump to the nearest useful post dominating block.
When DCE needs to delete a forwarding instruction in a dead block, it cannot just create
lifetime ends of its operands at its position. Use LifetimeCompletion utility in such cases.
rdar://140428721

@swift-ci test


Intellicode does not allow users to disable it

Steps to Reproduce / Scenario:
When a user does not have Pylance installed, and     "python.languageServer" is configured to "Jedi", intellicode will ask users to install the "microsoft language server". There is no option to permanently disable this prompt. There is no option to disable Intellicode for this language.
The only option if I don't want intellicode is to click "later", which to microsoft means "keep prompting and annoying me".
There should be a button to permanently disable intellicode for prompting me to install "microsoft language server".

@savannahostrowski

@catycaldwell On the Pylance side, we fixed this in 2020.11.1 - see microsoft/pylance-release#568 (@phgmacedo filed a similar bug on our release repo).

Thanks @savannahostrowski - let's sync on next steps here.

BTW -- there is an option to disable IntelliCode for Python:
"vsintellicode.python.completionsEnabled": false


Destroy risks on two projets in the same time

Describe the bug
The destroy function on risks_controller use @project who're null if risks to destroy aren't on the same projet.
To Reproduce
Steps to reproduce the behavior:

Destroy risks on two projets in the same time (with the multi-selection)

Expected behavior
Stay on the same page without 500 error

A solution can will be :
<EMAIL_ADDRESS>? nil : project_risks_path(@project))

v1.6.4 should fix your problem. Thanks to bringing it to my attention.


Implement repeat requests on GSuite

We make a lot of requests to GSuite.  This makes it more resilient in case of a Google server blip, which we've seen.
Refactor the transform objects method to be more general to prevent copy-pasta.

@skiptomyliu @tayasteere Can you please provide more information on the failures?  Which data is missing and on which function calls?  Do we have stack traces available for these failures?  Can we repro?
Would like to more thoroughly understand and document the failure before adding retries.

We receive 5xx Service Unavailable from Google's API call.  Scrubbed stack trace:
{"ts": "2019-09-12T21:35:26.334Z", "uuid": "2fdb2fbf-d6d7-4d47-8472-76e12f0ede90", "app": "infraintelgraph", "name": "cartography.intel.gsuite.api", "lvlname": "WARNING", "lvlno": 30, "pid": 31966, "call_site": "srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/cartography/intel/gsuite/api.py:266", "revision": "e6105806c2", "msg": "HttpError occurred in api.get_all_groups(), returning empty list. Details: <HttpError 503 when requesting https://www.googleapis.com/admin/directory/v1/groups?customer=my_customer&maxResults=20&orderBy=email&alt=json&pageToken=..."}
{"ts": "2019-09-12T21:35:26.337Z", "uuid": "6f25e5d0-30fc-4d36-bb89-11ed6578ec44", "app": "infraintelgraph", "name": "cartography.intel.gsuite.api", "lvlname": "INFO", "lvlno": 20, "pid": 31966, "call_site": "srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/cartography/intel/gsuite/api.py:268", "revision": "e6105806c2", "msg": "Ingesting 0 gsuite groups"}

As soon as that occurs, we break out of the loop and return an empty list.  The cleanup script is then run which removes the old entries.  I think to make this more resilient we can:

Add retries (what this PR does) because we make a lot of API calls due to the pagination (i'd estimate perhaps multiple hundreds of calls largely due to fetching group membership)
Don't run the cleanup script if empty lists are returned

Redoing PR with:  https://github.com/lyft/cartography/pull/169
CLA was borked when I re-configured my new laptop and didn't setup my github config yet.


Automatic PR from commercedoc

Codecov Report

Merging #1348 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1348   +/-   ##
=======================================
  Coverage   56.14%   56.14%
=======================================
  Files        2719     2719
  Lines       71614    71614
=======================================
  Hits        40205    40205
  Misses      31409    31409

Impacted Files
Coverage Δ

...mgmt/commerce/models/rate_card_query_parameters.py
55.55% <ø> (ø)
:arrow_up:

...re/mgmt/commerce/models/usage_aggregation_paged.py
80% <ø> (ø)
:arrow_up:

...commerce/operations/usage_aggregates_operations.py
28.2% <100%> (ø)
:arrow_up:

...e/mgmt/commerce/operations/rate_card_operations.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23463c6...f2b551e. Read the comment docs.

Doc only


Can we send and Receive from topics

Hi Team - Great work for awesome sockjs.net project !! I have question does this support to send or receive based on topics names , For example in the send Method:  Send("Topic name" , message);
Thanks in advance !! @doronguttman @dguttman-jacada @DenisBalan

This project was intended as a .NET client for SockJS.
The SockJS protocol does not support topics inherently, however you may want to consider running STOMP on top of it (which is quite common for such a combo).
You can also implement it yourself, e.g.:
public class TopicMessage
{
  public string Topic {get; set;}
  public string Data {get; set;}

  internal string Serialize() => JsonConvert.Serialize(this);
}

public static class SockJsExtensions
{
  public static Task Send(this SockJs sockjs, string topic, string data) => Send(sockjs, new TopicMessage(topic, data));
  public static Task Send(this SockJs sockjs, TopicMessage message) => sockjs.Send(message.Serialize());
}

Thank you for the response , I am trying what you suggested. Similar to the above can we even subscribe to stomp clients topics as well?
my js code: stompClient.subscribe('/user/queue/eventdata', function(message) {  })

Again, the SockJS protocol is built to pass strings (or JSON strings) only. you will have to subscribe to the Message event and parse it, e.g.:
sockJs.Message += (sender, msg) =>
{
    try
    {
        var topicMessage = JsonConvert.Deserialize<TopicMessage>(msg);
        // successful deserialization -> this is a TopicMessage
        InvokeTopicEvent(topicMessage);
    }
    catch (Exception ex)
    {
        // msg cannot be deserialized as TopicMessage
       InvokeNonTopicEvent(msg);
    }
};

Thank you once again @doronguttman  !!
InvokeTopicEvent(topicMessage);
Do we need call the same SockJs send method or any other methods to implement InvokeTopicEvent method which you mentioned or do we need to call receive methods in ClientWebSocket interface
this._socket.ReceiveAsync(buffer, CancellationToken.None);

InvokeTopicEvent is just something you'd have to implement internally in your app to handle the message when it arrives

Hi @doronguttman thank you for time  below event is not capturing the subscribe event from stomp topic . I have to explicitly call this similar to what you guys implemented  for connect in sockjs file like   this.Message?.Invoke(this, subscribetopic) ,  but this will not fulfill the subscribe to topic scenario.
But is there way to subscribe to topic from sock js and get the below code automatically when we get some message on the topic.
sockJs.Message += (sender, msg) =>
{
};

@ShanmukhJoga This is way outside of the scope of this project. I'll be more than happy to help with your specific project elsewhere. Feel free to provide a link to a repository with an MRE.
I also recommend you create an issue in that repo and we can continue the discussion there.

@doronguttman any help on this greatly appreciated !!  https://github.com/ShanmukhJoga/.Net-Stomp-client-Example.git

@doronguttman Thank you my friend , I finally found way to connect to Stomp server using your sock js .net !!Amazing and thank you for responding to my questions !!Hope we can see this project in Nugget soon !!
await sockJs.Send("CONNECT\naccept-version:1.0,1.1,2.0\n\n\x00\n");
await sockJs.Send("SUBSCRIBE\nid:sub-0\ndestination:/user/queue/topicname\n\n\0");
await sockJs.Send("SEND\ndestination:/app/topicname\ncontent-length:\n\n"payload to be sent" \n\n\0");
After calling this I was able to get messages on below code:
sockJs.Message += async (sender, msg) =>
{
//Read messages from server from msg string
};

Good job! I'm using STOMP as well, so I may open-source my STOMP implementation.
The SockJs.NET lib has actually been nuget-ed by someone else, but it is the v1. I have asked that person to remove the package as it is taking the namespace. Hopefully I will be able to publish as well

Hi,
I hopefully found this thread as I also need to use your lib and subscribe to a STOMP destination.
Since you're stuck with publishing a Nuget package, I had to push your code to my private Azure devops repo, in order to use it as a private nuget package.
So please let me know when you manage to publish it, so that I can remove mine.

we're waiting on a PR for the nuget package code. feel free to submit one if you have the time

I'm running a heavy sprint, so for now, I'll rely on @ShanmukhJoga solution, but when it's refactoring time, I'll try !

Actually I switched my source copy to a fork of yours. So if a come with a nice implementation of STOMP destinations, it's gonna be easy for me to PR.

@kall2sollies see: https://github.com/sypbiz/SockJS.NET/issues/15


[AR-2780] Logo not fit properly on Wallet bubble

Changes
Set object-fit to contain for image in Bubble
Issue ticket number and link

AR-2780

Ref - https://www.loom.com/share/22c349e28d4c47edb793cc3b941d5c92
Checklist before requesting a review

[X] You have performed a self-review of your own code
[X] You are using approved terminology
[X] Your changes have been tested locally
[X] Your code builds clean without any errors or warnings

@karthik-durai There's some unrelated changes in the PR. If you are planning to make this a hotfix, you'll need to branch out of main instead of dev. Otherwise, may just need to change the target branch in this PR from main to dev.


parallelize open_mfdataset rather than concurrent

Overview
This parallelize open_mfdataset.

@s-kganz Could you try doing what you did yesterday with this new hopefully improvement to see how long it takes to open the dataset. Thanks!

Pull Request Test Coverage Report for Build 157

0 of 0   changed or added relevant lines in 0 files are covered.
191 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.3%) to 46.862%

Files with Coverage Reduction
New Missed Lines
%

/home/travis/miniconda/envs/TEST/lib/python3.6/site-packages/yodapy/datasources/ooi/helpers.py
9
45.83%

/home/travis/miniconda/envs/TEST/lib/python3.6/site-packages/yodapy/datasources/ooi/init.py
55
40.12%

/home/travis/miniconda/envs/TEST/lib/python3.6/site-packages/yodapy/datasources/ooi/m2m_client.py
127
34.67%

Totals

Change from base Build 155:
0.3%

Covered Lines:
336

Relevant Lines:
717

💛  - Coveralls


Added delicious recipe for tomatosoup

Hey Lennart,
I noticed you are missing my recipe for tomatosoup.
Best Regards
Paul

Thanks @luap3 for the additional changes and sorry for taking so long to respond to this. happy to merge this now and close the PR.

@allcontributors please add @elmwdow for bug, content, code

@allcontributors please add @luap3 for content, code

@allcontributors please add @elmwdow for bug

@allcontributors please add @luap3  for bug


Store precomputed pedersen lookup table

Initializing pedersen lookup table is very costly and it is the core reason why some of the commands of CLI are super slow (relevant issue). Given that the lookup table is "constant" we can pre-compute it and store it. This is the problematic function.
TODO: Store the table and write a test which loads it and compares the result with the output of the init function.
UPDATE: Zac is working on a new pedersen hash which will nuke this slow part of code and hopefully this issue will then be resolved.

Closing this is the current pedersen will be replaced soon™


Run travis tests with -j 1 to solve out of memory

First build worked. I'm going to restart the travis build a few times to see if it's solved.

Worked four times in a row, I'm going to call it fixed.


This is what I meant by putting it in the repo.
There is a button in the toolbar on the right side to mark as draft (it's subtle), you can use that if your PR is not ready to merge.
What transition bug are you fixing by installing the bleeding edge version of flixel-tools?

the transition bug was already fixed in the latest flixel-tools, there's no need to use the latest version

the transition bug was already fixed in the latest flixel-tools, there's no need to use the latest version

ok

ok FINALLY It is ready lmao


Fix the dependencies of Spring Boot integration module

No need to depend on hibernate-validator directly

Codecov Report

Merging #71 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   49.06%   49.04%   -0.03%
==========================================
  Files         211      211
  Lines        9779     9779
  Branches     1319     1319
==========================================
- Hits         4798     4796       -2
- Misses       4242     4244       +2
  Partials      739      739

Impacted Files
Coverage Δ

...internal/storage/repository/git/GitRepository.java
74.84% <0%> (-0.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2480d8...d8dc4d3. Read the comment docs.


Specifying a path starting with "/" in --default-resources tmpdir= creates a syntax error in checkpoints

Snakemake version
6.5.3
Describe the bug
When using the command line argument --default-resources to specify a tmp directory starting with "/", a Syntax Error occurs for the first checkpoints.xxx.get() line.
Logs
Using a non-/ tmpdir:
(snakemake) ➜  snakemake snakemake -j1 --forceall --default-resources tmpdir=test
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
Job stats:
job                   count    min threads    max threads
------------------  -------  -------------  -------------
example_checkpoint        1              1              1
total                     1              1              1

Select jobs to execute...

[Fri Jul 16 11:09:17 2021]
checkpoint example_checkpoint:
    output: 1.txt, 2.txt, 3.txt
    jobid: 0
    resources: mem_mb=1000, disk_mb=1000, tmpdir=test
Downstream jobs will be updated after completion.

[Fri Jul 16 11:09:17 2021]
Finished job 0.
1 of 1 steps (100%) done
Complete log: /home/romain/work/tmp/snakemake/.snakemake/log/2021-07-16T110917.108029.snakemake.log

Using a / tmpdir:
(snakemake) ➜  snakemake snakemake -j1 --forceall --default-resources tmpdir=/home/romain/test
Building DAG of jobs...
Using shell: /usr/bin/bash
Provided cores: 1 (use --cores to define parallelism)
Rules claiming more threads will be scaled down.
InputFunctionException in line 2 of /home/romain/work/tmp/snakemake/Snakefile:
Error:
  SyntaxError: invalid syntax (<string>, line 1)
Wildcards:

Traceback:

Minimal example
Code used to generate the logs above:
checkpoint example_checkpoint:
    '''
    '''
    output:
        '1.txt',
        '2.txt',
        '3.txt'
    shell:
        'touch {output}'

def example_input(wildcards):
    '''
    '''
    rule_input = checkpoints.example_checkpoint.get(**wildcards).output[0]
    return rule_input

rule example_rule:
    '''
    '''
    input:
        example_input
    output:
        'test.txt'
    shell:
        'cat {input} > {output}'

Thanks for the workaround, that will be useful!

The parsing rules for --default-resources are outlined in #1707, as is the need for additional documentation. As such, I'm closing this issue, but please continue the discussion if there is any more relevant information.


rustup run $toolchain cargo succeeds even if $toolchain is not installed

This is unexpected, and can lead to confusion if trying out cargo build or cargo test with some older versions. You end up silently building against nightly instead (see below).
$ rustup --version
rustup 0.6.4 (e6dc1c6 2016-10-24)
$ rustup run 1.0 rustc --version
error: toolchain '1.0' is not installed
$ rustup run 1.0 cargo --version
cargo 0.13.0-nightly (717adc8 2016-11-02)

The call to cargo should fail as well.
To demonstrate that other non-cargo commands do not run:
$ rustup run 1.0 which cargo
error: toolchain '1.0' is not installed

It seems that the silent successful cargo commands use nightly:
$ cd $(mktemp -d)
$ cargo new bad  # to get a valid Cargo.toml
     Created library `bad` project
$ cd bad
$ rustup run 1.0 cargo rustc does-not-exist.rs -- --version
   Compiling bad v0.1.0 (file:///tmp/tmp.iiZg2tF5CK/bad)
rustc 1.14.0-nightly (5665bdf3e 2016-11-02)
    Finished debug [unoptimized + debuginfo] target(s) in 0.2 secs

I think it's using the nightly channel and not a specific nightly, as I hadn't installed 2016-11-02 explicitly:
$ ls $HOME/.multirust/toolchains
1.2.0-x86_64-unknown-linux-gnu  nightly-2016-10-26
1.8.0-x86_64-unknown-linux-gnu  nightly-2016-10-28
beta-x86_64-unknown-linux-gnu   nightly-x86_64-unknown-linux-gnu
nightly-2016-10-09              stable-x86_64-unknown-linux-gnu
nightly-2016-10-19

This seems to be fixed when I try to reproduce.


All Languages: Make 'Chat' models easier to register

@markwallace-microsoft: let's talk and make some plans here.
@dluc to weigh in

Closing since the text completion service (which this was often confused with) is being removed.


Disabling ssl verification in HTTP task

Can we have disableSSLVerification flag support in HTTP task?
Describe the Feature Request
Adding disableSSLVerification flag
Describe Preferred Solution
This is will help to send http request to ssl enabled server
Describe Alternatives
Alternative is to implement our own http client which will take lot of effort

@v1r3n @apanicker-nflx FYI. This request created to allow ssl disabled in HTTP task. Please check if this can be taken up


[nightly] panic: runtime error: invalid memory address or nil pointer dereference

Describe the bug
Suddenly, since this night, the evcc nightly build crashes at startub with the following message:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x155e3b3]
Steps to reproduce
Just starting evcc produces the crash
Configuration details
Sponsor token, usernames and passwords have been redacted. This config file worked fine yesterday afternoon.
evcc.yaml.txt
Log details
evcc-crash.log
What type of operating system are you running?
Docker container
Version
nightly build (needed for elli wallbox)

Closed in 7920b28a3b787e2d85f069061af1b50a55001999

Thanks, evcc is now starting again but the connection to my elli wallbox does not work anymore (tls: failed to parse certificate from server: x509: invalid basic constraints b). I'll analyze some more and open another issue if the problem seems not to be on my setup. Have a nice day.

For time being you're still stuck with the special builds, we're investigating why nightly doesn't work.

Ok then I'll have to wait until the nightly works again, I can't use a special build because I need it in Docker.


Add OSXArm & ppc64le builds

@conda-forge/help-ppc64le
@conda-forge/help-osx-arm64
Could you add OSXArm & ppc64le builds?
Please throw me a link of doc if it can be done by myself.

Pleas add this feedstock to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/arch_rebuild.txt and https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/osx_arm64.txt
Then the bot will make appropriate PRs.

Thanks.


Fix pad_across_processes to allow negative dimensions

What does this PR do?
Fix the pad_across_processes function so that you can input negative dimensions. Right now, indices will always have slices of (None, None) if dim is negative.

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[X] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Could you please run make quality and make style?

@BenjaminBossan I ran it, but seems like there's no file changes. Might be from a different file, I merged
accelerate git:(main) make quality
black --required-version 23 --check tests src examples benchmarks utils
All done! ✨ 🍰 ✨
118 files would be left unchanged.
ruff tests src examples benchmarks utils
doc-builder style src/accelerate docs/source --max_len 119 --check_only

accelerate git:(main) make style
black --required-version 23 tests src examples benchmarks utils
All done! ✨ 🍰 ✨
118 files left unchanged.
ruff tests src examples benchmarks utils --fix
doc-builder style src/accelerate docs/source --max_len 119

but seems like there's no file changes

Strange, not sure what the issue is, maybe something with the installed versions of ruff. Anyway, the lines you touched are too long, you'd have to add a line break to get to 119 chars.

Ok should be fixed @BenjaminBossan

Gentle ping @harish-kamath :)
(Also try doing pip install -e .[quality] to perhaps have make style; make quality pass)

Sorry just fixed, probably just easier to do it this way

Still having trouble with style/quality - pip install -e .[quality] results in no matches found: .[quality].

Make sure you’re running that from the root directory of the accelerate folder

Yep I did. Interestingly, I think it just doesn't interpret it as a pip command? no command found seems to actually think that the .[quality] is part of another command. pip install -e . works as expected though.

Note for anyone else that may have trouble installing with pip and square brackets:
If you are using a zsh shell, you should use '' around your command e.g. pip install -e '.[quality]'

That being said - there is still no issue locally with style or quality having done this @muellerzr and the actual PR is really small, so not sure what is failing

Try rebasing from main, iirc this was an issue with deepspeed back then


xGov-38 - Decentralized Perpetual Margin Exchange

Doesn't Deflex already do all three? https://www.deflex.fi/

Deflex does part of the first, it has stableswap support and some lending pools (I think, their docs do not say what protocols are implemented from what I can tell). But Vestige is currently routing ~10% of all swaps on Algorand, so us supporting it would be a major improvement not only for us but also the individual protocols (pact, algofi, folks).
First some context. Both Vestige and Deflex both currently operate in the same way, we create qoutes off-chain that are then routed through a routing app. The purpose of our second component is to remove the off-chain creation of qoutes and move that on-chain, so that dapps can get access to aggregated liquidity without relying on any centralized infrastructure. This is not something that Deflex has implemented, their on-chain part is only an interface that gets fed off-chain data, just like our current router is.
I will also add that the two first components include research and results that will be directly used in the perpetuals futures market we're building. This exchange will rely completely on a decentralized aggregator to remove any point of centralization while also allowing the protocol itself to do it's own liquidations, order openings and order closings.

Good clarification, thank you.

🐉🔥 High priority for Algorand DeFi


Problem with php

I do not know whose problem it is, ace-editor or yours, but when I select the php syntax, I see this error in the console
Could not load worker
TypeError: name is undefined
Stack trace:
exports.moduleUrl@webpack-internal:///./node_modules/brace/index.js:3646:9

like everything works and there are no problems, but the error is alarming. Also, constantly in any selected language, I see an attempt to load a file 'mode-undefined.js'

Maybe it is determined after the component is initialized, thanks for the help


[WIP] Core upgrade

Hello.
Took me a little bit of time to get my bearings with regards to figuring out the right artifacts to import and such. For now this is a pretty simple set of changes just to make everything compile.

I got rid of AsyncSyntax; I don't think it made any sense to keep it.
Removed all mention of Blocker and ContextShift (naturally)
There's a couple of instances where unsafeRunSync was done where I used the global IORuntime. I'm not sure if that's the right thing to do. If that could be avoided core could probably import just kernel and std.
I don't know if I used the dispatcher correctly. That is, I added Dispatcher as an implicit in a couple of places, which I'm concerned about since it might have a knock-on effect and I don't know if that's desired.

I was primarily focused on getting this to compile and trying to understand how to migrate without changes, but now that it compiles I think that some places where Sync is used could be loosened due to the presence of Files.
Anyway, let me know how I could improve this. I will try to run tests tomorrow.

Left a lot of comments but they are all instance of the same 4-5 things. @djspiewak two interesting points btw:

do we want to encourage importing from kernel?
look at Dispatcher, there are a couple of "mini-ends-of-the-world" cases here

IMO if you have core, import from it. Kernel imports are for when you don't depend on core.

I'll look at the dispatcher call sites when I get back to my laptop

Do you actually need to thread the ExecutionContext through anymore? Cats Effect contains its own EC, so in theory it shouldn't need to appear anywhere in the signatures.

All the usages are in blaze. We could punt it to blaze-core right now, and see if we can eliminate entirely when we get to that backend.

Oh is this the worker pool for blaze? Or is it blaze's Future-shifting pool? If it's the latter, then Async[F].executionContext should give you what you need (an F[ExecutionContext] that produces the compute pool). If it's the former, then continuing to thread it through makes sense, though it does result in some unfortunate API shenanigans higher up in the stack (my fault, I know!).

I think I resolved most of the feedback now.

Farewell kernel imports
: Sync: Files eliminated; it is now either just : Files or : Files: Concurrent
global IORuntime imports removed in favour of SyncIO
couple of misc things

The things that are incomplete right now:

the unsafeRunAsync that @rossabaker mentioned should go into blaze core
One section on multipart parser (line 756). I'll leave a comment outlining my confusion there.

core now compiles; I will proceed to fixing tests

Great! I presume I need to "undraft" this PR now, so I'll do that and then make a new branch for test upgrade.


Improve actix-web example: set content-type, update actix-web to 0.7

Hi.
I just learned how to use optional dependency and feature mechanisms from your Cargo.toml. : )
So I add mime_guess as the optional dependency (because actix-web does not have built-in support for guessing mime type from file names) and set content-type header in the example of actix-web.

LGTM... Thanks @Gowee .


⚠ Jurnal has degraded performance

In 2ddd609, Jurnal (https://jurnal.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 7905 ms

Resolved: Jurnal performance has improved in 2fe4b33.


get_available_regions: try service name first, then endpoint prefix

The botocore.sessions.Session.get_available_regions method is already documented as not always returning the complete set of regions where a service is available (at least in the boto3 docs, botocore's docs don't cover the session module). This PR fixes the opposite problem: In some rare situations the method returns too many regions.
Consider the case of the neptune service: It uses the endpoint prefix rds. As a result, get_available_regions('neptune') will return the available regions for RDS, not Neptune. For example, me-central-1 is listed as available region for Neptune when in fact it is not, as per Endpoints and Quotas docs for the Neptune service.
Any service that shares an endpoint prefix with another service would be affected by this. In a quick search I found neptune and docdb as sharing rds. There may be other examples.
This PR solves this by making get_available_regions try to use the given service name first, then fall back to looking up the endpoint prefix. There was a test case specifically asserting against doing this which I changed.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (9f1dd1c) 93.57% compared to head (6103475) 93.52%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2881      +/-   ##
===========================================
- Coverage    93.57%   93.52%   -0.05%
===========================================
  Files           63       63
  Lines        13455    13456       +1
===========================================
- Hits         12590    12585       -5
- Misses         865      871       +6

Impacted Files
Coverage Δ

botocore/session.py
96.90% <100.00%> (+<0.01%)
:arrow_up:

botocore/compat.py
91.33% <0.00%> (-1.34%)
:arrow_down:

botocore/httpsession.py
91.40% <0.00%> (-0.40%)
:arrow_down:

botocore/utils.py
79.01% <0.00%> (-0.20%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

After offline discussion, we decided to not merge this. It introduces a small but non-zero risk of a future reverse name clash where one service's name is another service's endpoint prefix.
For anyone who comes across this via Google search: Consider using the AWS SSM Parameter Store API introduced in this blog post as an alternative source of region information.


Upgrade to spring boot 2.5.4.

Upgrade to spring boot 2.5.4.

/azp run java - spring - tests

/azp run java - cosmos - tests

/azp run java - keyvault - tests

/azp run java - spring - tests

/azp run java - cosmos - tests

/azp run java - keyvault - tests

Hi, @ZhuXiaoBing-cn .

I think it's ready to merge now.
I suggest to push these commits in one time, to avoid unnecessary checks:

/azp run java - spring - tests

/azp run java - cosmos - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

hi, @zhichengliu12581, Please take a look at the problem. https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1074180&view=logs&j=4d65ddb6-61b1-57ce-0321-ae337fc9c5ee&t=56b2bd38-4099-51d8-2503-bd1f55f7f9cf&l=3403

/azp run java - keyvault - tests

/azp run java - spring - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - spring - tests

/azp run java - keyvault - tests

/azp run java - keyvault - tests

Hi @ZhuXiaoBing-cn, I ran some local and live tests and it looks like the Key Vault Administration code coverage is above the threshold, so I don't know why the pipeline keeps marking this step as a failure. I think you should be able to ignore this for the time being and merge this PR so you are unblocked. I will investigate separately.

LGTM

/check-enforcer override

Hi, @chenrujun, the related conversation has been resolved, please review it.

/azp run java - cosmos - ci


Changes to support -j with backpack

Companion to https://gitlab.haskell.org/ghc/ghc/-/merge_requests/1823

Cool! Thanks @Ericson2314 and @bgamari!


Fix issue related to skipping of Custom Step

Overview
The custom step in onboarding was skipped after the new APCOnboardingManager.
Actions

Setting the customStepIncluded to YES during setup solves the issue.

r=me.


File to import not found or unreadable: vue-mdc-adapter/components/styles.

In your usage SCSS Theming example:
$mdc-theme-primary: #212121;
$mdc-theme-accent: #41B883;
$mdc-theme-background: #fff;

@import "vue-mdc-adapter/components/styles";

File to import not found or unreadable: vue-mdc-adapter/components/styles.

I can see components/styles.scss in the distribution. so it should work for you.
can u plz check the path is in your node_modules.
you need to add node_modules include location to your sass config. That may be your issue

@stasson
You're right. It turned out to be a non-trivial task to make the vue-loader handle the folder node_modules. Specially created a template based on webpack-simple, so that you can quickly start a project using your library:

$ npm install -g vue-cli
$ vue init Bobarev/vue-mdc-adapter-webpack-simple my-project
$ cd my-project
$ npm install
$ npm run dev

https://github.com/Bobarev/vue-mdc-adapter-webpack-simple


MRG, MAINT: Bump minimum versions

It turns out that our "old deps" job was not actually testing old dependencies. This should fix it.
It also bumps our minimums for NumPy, SciPy, Pandas, and matplotlib by one minimum version (but for matplotlib this turns out to require a major version bump 1.5->2.0). This seems like the most sustainable path since it does not really seem possible to CI-test our currently listed minimum dependencies, which is a problem.
If this is okay, I'll then go through fixes (and maybe viz/utils.py?) and axe anything we no longer need.

[x] Bump versions
[x] Check logs to make sure it actually used the requested versions
[x] Get tests to pass
[x] Get @agramfort to agree about actually bumping versions
[x] Clean up fixes.py and viz/utils.py
[x] Get tests to pass again

Closes #6627.

@drammock I let you merge this one as you're a more MPL guru than me :)

Ahh yes we should probably mention them, will push then merge

thanks @larsoner


[BUG] SSO using Google caused in errors

Description
Never logged in before.
Used Google as sign in
Got instant errors at homescreen:
GET https://whisper-app-api.herokuapp.com/api/v1/provider/getProviderServiceRequests/undefined
GET https://whisper-app-api.herokuapp.com/api/v1/app/getUserActiveSubscriptions/undefined
GET https://whisper-app-api.herokuapp.com/api/v1/app/getFriends/undefined

Screenshots

By google do you mean your gmail?


Update Gradle to 8.11.1, AGP to 8.7.2, Kotlin to 2.1.0 for the latest versions configuration for the functional tests

What does this PR do?
This PR updates latest versions configuration for the functional tests.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.31%. Comparing base (98dc5d0) to head (db089e2).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #298      +/-   ##
=============================================
+ Coverage      78.20%   78.31%   +0.11%
+ Complexity       254      251       -3
=============================================
  Files             31       31
  Lines            913      913
  Branches         114      114
=============================================
+ Hits             714      715       +1
+ Misses           148      147       -1
  Partials          51       51

see 2 files with indirect coverage changes


Node in bootstrap before genesis launch prevents ledger operations

Starting a node for mainnet and it is stuck in Bootstrap. this happens even when passing --seed. The upshot of this is that several CLI commands do not work such as dumping ledgers. It would be better if the status was Synced at height 1 until the chain start timestamp so these other commands could be used.

Here is an edited workaround provided by Deepthi:

Change the genesis timestamp in the genesis ledger and pass it using the -config-file flag and run a seed node. The node will not sync to the network but you could get the staking ledgers from the cli command (it doesn't depend on the genesis time)

Hey @deepthiskumar can you please check if we still need to implement an enhancement here?


Feature request: Playlist / Queue delete individual

I'm sure you must already be working on this, but it would be very useful to be able to delete items from the queue (I see they are numbered now) and also whole playlists.
Thanks for this great project!

Changed numbering songlist. Songs are numberd from 0 instead from 1 now.
Fits now to internal mpd order.

Ability to remove playlists implemented with 16d7e11


Fixed link to "part 2" in Valhalla_ubuntu_part_1_build_install.md

I also noticed that the Ubuntu version in the menu does not match the Ubuntu version in the text:

thanks, you're right:)


Don't use 301 redirects

Description
https://github.com/alvgaona/cloudflare-discord-bot/blob/7adf8bc5219d5d4109b708e17924b7132c054a7b/src/authorize.ts#L13-L16
301 redirects are permanent and browsers will hard cache them to the point of not even touching the origin when encountering that url again. This means that if the bot client id changes its impossible for clients to get the new id without manually clearing browser data (and even then that sometimes wont work).
Instead you should use 302
Reproducibility
Create a bot, publish the worker and go to its base url, change the bot's client id/recreate it, go to its base url and get the wrong client id.
Version
0.0.1 (latest)
What browsers are you seeing the problem on?
Chrome
Log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@gzalo do you want to do it?

I can handle this in another pr if you like

Ill open a PR for this once the prettier changes have been merged so as to avoid further confusion


DRILL-6284: Add operator metrics for batch sizing for flatten

@kkhatua please review.

@paul-rogers thanks for the review. Please take a look at updated changes.

@paul-rogers I added metrics for merge join also. I refactored AbstractRecordBatchMemoryManager to handle batches from multiple streams. Please review when you get a chance.

@paul-rogers thanks a lot for the review. updated PR with review comments taken care of.


Added voice assistant at the bottom right

Resolves #26

Two modes:

Search city: Will search up the city as if you searched the city through the search bar
Weather for city: Will tell you what the weather is like and the temperature of the city

I can't really see the voice assistant in deploy preview.

Api key needs to be added to netlify

@kpham841 please fix conflicts

Api key needs to be added to netlify

Okay. After @grace-omotoso adds the api key to Netlify, we can test and merge if everything's alright.

https://deploy-preview-95--mlh-prep-22-nov-prep-2-project.netlify.app/

I have added the key @miador can you check the backend to see what key you are seeing?

Yes, it's working. It's  not showing here because it's cached. You can check from #97

i think we can merge this

LGTM

I guess the assistant isn't available for mobile? @kpham841


Feature: Prebuilt Docker image

Description:
Please consider releasing a prebuilt Docker container to Docker Hub and/or GitHub Container Registry
Use Case:
Allow users to use the prebuilt image rather than having to build from source each time. Allows things such as Unraid template and TrueNAS charts.
Proposed Solution:
GitHub Action to build and release the Docker image whenever a GitHub release is cut.
Additional Context:
Add any other relevant information, screenshots, or examples that help clarify your request.

Hi @nwithan8,
This is a very good point, thanks a lot for bringing it up! Will try to plan this asap!

Hi @nwithan8, thanks again for bringing this up.
We're now providing a prebuilt image via the github container registry as part of our CI, as you suggested.
I've updated the readme with instructions to use it.
Please don't hesitate to let me know if you experience any issues with it!

Thanks! And in return, I made an Unraid template for this, so users can easily install this container on their servers from the Community Apps Store.


Issue #498: Fix to set variables in remote nodes

Issues Resolved by this Pull Request
Fixes #498
Description of the Solution
Added delegate_to remote hosts.
Suggested Reviewers
@j0hnL @lwilson

Hi,
I have signed_off both the committs but still getting an error in DCO.

 To fix, first ensure you have a local copy of your branch by checking out the pull request locally via command line.  Next run
git push --force-with-lease origin devel


I keep getting this error when trying to user rave_flutter

Everything I try to install tripledes: ^2.1.0 I keep getting the error

Because no versions of tripledes match 2.1.0 and no versions of tripledes match >2.1.0 <3.0.0, tripledes ^2.1.0 is forbidden.
So, because **** depends on tripledes ^2.1.0, version solving failed.
pub get failed (1; So, because **** depends on tripledes ^2.1.0, version solving failed.)

It happens every single times and i dont know what caused it, cause am trying to use rave_flutter: ^0.0.9-alpha+2 which depends on tripledes and its not working because of this error.
What is the problem
This are my depencies:

dependencies:
google_sign_in: ^4.5.6
firebase_auth:
provider: ^4.3.2+3
flutter_switch: ^0.2.0
cached_network_image: ^2.5.0
shared_preferences: ^0.5.12+4
image_picker: ^0.6.7+17
flutter_image_compress: ^0.7.0
image_cropper: ^1.3.1
intl: ^0.16.1
http: ^0.12.2
transparent_image: ^1.0.0
country_state_city_picker: ^1.2.7
animations: ^1.1.2
smooth_star_rating: ^1.1.1
csc_picker: ^0.0.4
firebase_core: ^0.7.0
rave_flutter: ^0.0.9-alpha+2
async: ^2.4.2
dio: ^3.0.10
equatable: ^1.2.5
flutter_svg: ^0.19.2+1
get_it: ^5.0.2
meta: ^1.2.4
tripledes: ^2.1.0
webview_flutter: ^1.0.7
flutter:
sdk: flutter

This should be fixed after the support for Flutter 2. #61 has the latest updates on Flutter 2.0 support.


Initial atempts to fix bug with current screen being indicator status

I updated this PR @christianparpart  and at the moment it fixes issue with screen selection and reproduce bug from master branch with same selection happening for LineOffset(0) and status line


The Web Site Name for HydroShare should be spelled with an upper case "S"

Open HydroShare in Chrome and look at the name of the web site in the tab that appears. It is spelled "Hydroshare". I believe we should be consistent with the uppercase "S". Or a lowercase "s" if that is what is preferred, but I believe the current design protocol is uppercase "S".

Putting the big "S" back into HydroShare - verified on dev.hydroshare.org


Compiler type system messup (when using generics, inheritance and casts)

I observed that Crystal has an issue when running only parts of my project specs (as opposed to all specs at once). It started complaining that some obvious-typed instance variables should get explicitly typed outside of the constructor.
So, today I took the time to track it down - below you can find my minimum sized example (still 50 LOC, though).
You can follow these steps:

if you build normally, it fails and requests you to manually add the type of @c in S(T)
if you do so, it just repeats the very same error message, so leading you nowhere
if you compiler with -Dok (and thus adding a seemingly unrelated call) it compiles fine...

# necessary: generics, inheritance, lots of loose ends...
# ... plus absence of one of the ends

class Base(T)
    def m1
    end
    def m2
    end
    def each
        self.as(Base(T)).m1 # necessary, incl. cast
        self.as(Base(T)).m2 # necessary, incl. cast
    end
end

class C1(T) < Base(T) # necessary
end

class C2(T) < Base(T) # necessary
end

class S(T) < Base(T)
    # @c : C1(T) # proposed by compiler, but doesn't even help (error message stays the same)
    # Error: can't infer the type of instance variable '@c' of S(Nil)
    # Could you add a type annotation like this
    #     class S(Nil)
    #       @c : Type
    #     end
    def initialize
        @h = C1(T).new # necessary
        @c = C1(T).new # compiler will complain about this type
    end
    def m2
        @c # necessary
    end
end

class H(T) < Base(T)
    @t : Base(T)
    def initialize
        @t = S(T).new
    end
    def m1
        S(T).new # necessary
    end
    def m2
        @t.as(S(T)).m2 # necessary, incl. cast
    end
end

{% if flag?(:ok) %}
# _removing_ this is triggering error (e.g. being part of another *_spec.cr file)
S(Nil).new
{% end %}

C2(Nil).new.each # necessary
H(Nil).new # necessary

I'm using Crystal 1.10.1 [c6f3552f5] (2023-10-13), LLVM: 15.0.7, Default target: x86_64-unknown-linux-gnu

There's one more catch to this: I don't know what happened, but right after my first post even my regular crystal spec stopped to work on one of my machines (same setup, same sources).
Now I have to manually specify the order of the *_spec.cr files on the command line.
The other machine works as before...
Seems like the built-in order of the spec files is somehow non-deterministic..?

Out of curiosity, can you try crystal spec --order random ?

Seems like the built-in order of the spec files is somehow non-deterministic..?

No, it should be completely deterministic.
crystal spec with no file argument is equivalent to require "spec/**/*_spec.cr". And wildcard path resolution is supposed to be always deterministic given the same environment. Directory entries are explicitly sorted by regular string comparison.
If you see different behaviour, than maybe there is something else in the file system? Are you sure the contents are 100% identical and there are not additional files somewhere maybe?
@Fryguy --order random only has a runtime effect but we never get there when the program doesn't build.

Oh I was more speaking to the more recent problem that @wolfgang371 had regarding the spec ordering - was curious if he could get it to compile with a copmletely different ordering.

I ran crystal spec --order random twenty times, all times failing. As @straight-shoota already noted, it's a runtime option, so it has to compile first.
I tried ruby -e 'puts Dir["spec/**/*_spec.cr"]' on both machines, and it yielded different orderings, while both are on a clean mainline of my git project.

You need to compare Dir["spec/**/*_spec.cr"].sort!. That's what the compiler does when resolving wildcards.

from what I see in crystal/src/compiler/crystal/command/spec.cr there is no sort:
target_filenames = Dir["spec/**/*_spec.cr"]
... which is pretty much what I observe

Oh, yeah. I missed that. Dunno why this is doing that explicitly. This obviously circumvents the compilers regular path lookup.
I was assuming it would use require "spec/**/*_spec.cr" as source. And I'm pretty sure that's what it should do.

FWIW, Ruby didn't have sorted Dir globbing until only very recently, so we likely inherited that quirk.


Add a 'max_send_frag' option to configure maximum size of send fragments

Checklist

[X] documentation is added or updated
[ ] tests are added or updated

Noticed while working on #1008

@levitte : rebased and error message updated.

I think you misunderstood me.  It wasn't just about the message, but also about all that unnecessary checking of values, which is done in SSL_CTX_set_max_send_fragment() et al anyway!

@levitte : rebased on top of last master. It it OK ?

Rebased and conflict fixed. Ready to merge .

Merged.  28e5ea88a8fe93aa6dd023a5abd54f01c1ad6450 to 36b2cfb191f4a3f3a49b7c4d865308b7021daa42

should the doc say that the RELEASE-BUFFERS flag is needed for this to actually reduce memory?


Don't use this api anymore

Apparently Avalara is no longer offering this free api. I've been getting incorrect rates since 1/1/2017 in some areas.
https://community.avalara.com/avalara/topics/california-state-tax-discrepancy

@drewnichols: Thanks for noting that the data is out of date! However, this gem does not use any Avalara web APIs (it's entirely local). Instead it relies on a local, user-downloaded copy of the estimated tax rates tables Avalara publishes.
To automate the downloading of those tables this gem does come with a list of the published tax rate table files. I've updated the gem to download the 2017 files and properly parse them in 691ad60f7fc402c4cc0cc464a1bf25520ffd6452.


Checking for spdx header in CI

This was copied from tt-mlir: https://github.com/tenstorrent/tt-mlir/blob/main/.github/workflows/spdx.yml
This job check whether we forgot this header somewhere.

Deprecated by #231


Doc fixes for cref's so that rider doesn't show red warnings

What was changed

In Rider, when you open the solutions there's a bunch of red warning showing up for cref docs so I've updated them.
Why?

This fixes the solution wide analysis that Rider runs
Checklist

Closes

How was this tested:

Any docs updates needed?

Thanks!
So there seems two issues with Rider that the .NET team and docfx don't consider issues: 1) Not requiring type arguments when not needed for overload ambiguity (why is Rider ok w/ not providing parameters in these situations but not ok w/ not providing type arguments), and 2) inability to resolve references to things in the scope they are in.
I think these are both Rider bugs if https://learn.microsoft.com/en-us/dotnet/csharp/misc/cs1574 does not warn.

@cretz hello
In the end, what decision will we come to? I fixed it too, without being sure that anyone was doing this...

I think if dotnet and docfx consider these valid, this is an IDE specific issue. We count on the compiler to warn on this and unless we use Rider-specific analyzers in CI, we can't guarantee future PRs won't cause more Rider-only warnings. I wonder if there is already an open bug for JetBrains we can link or if we should create one?


Add more options

Swagger-codegen has a lot of options.
It would be nice if we could use them
        swagger-codegen-cli generate
                [(-a <authorization> | --auth <authorization>)]
                [--additional-properties <additional properties>...]
                [--api-package <api package>] [--artifact-id <artifact id>]
                [--artifact-version <artifact version>]
                [(-c <configuration file> | --config <configuration file>)]
                [-D <system properties>...] [--git-repo-id <git repo id>]
                [--git-user-id <git user id>] [--group-id <group id>]
                [--http-user-agent <http user agent>]
                (-i <spec file> | --input-spec <spec file>)
                [--ignore-file-override <ignore file override location>]
                [--import-mappings <import mappings>...]
                [--instantiation-types <instantiation types>...]
                [--invoker-package <invoker package>]
                (-l <language> | --lang <language>)
                [--language-specific-primitives <language specific primitives>...]
                [--library <library>] [--model-name-prefix <model name prefix>]
                [--model-name-suffix <model name suffix>]
                [--model-package <model package>]
                [(-o <output directory> | --output <output directory>)]
                [--release-note <release note>] [--remove-operation-id-prefix]
                [--reserved-words-mappings <reserved word mappings>...]
                [(-s | --skip-overwrite)]
                [(-t <template directory> | --template-dir <template directory>)]
                [--type-mappings <type mappings>...] [(-v | --verbose)]

I suggest using an additionnal Map<String, String> otherOptions to place them into the task. Then merge it within the buildOptions()

Looks good idea. I will add this feature.


ekf2: Fix EKF preflight check fail false positives

Uses a relaxed yaw innovation check threshold for fixed wing vehicle that can recover from larger yaw errors after takeoff.
Replaces the peak hold with decay filtering applied to the magnetic yaw innovations with a conventional lowpass filter. This prevents mag heading innovation transients caused by preflight handling from failing the check, but catches persistent errors. Sign swapping of innovations due to angle wrapping is not a problem due to the way that innovations are calculated inside the EKF, so a simple LPF sufficient.

@antiheavy

@dagar is this PR the same as the test firmware we are flying?  Going to do more flying and ground testing tomorrow.

Yes, it's identical.

Flight testing has shown a large reduction in EKF “internal errors” during preflight handling. I should have some logs to post tomorrow.

@priseborough @dagar
Here are some flight logs with this PR.  Overall it looks like it has successfully suppressed the false positive EKF internal check warnings during pre-flight handling of our hand launched fixed wing.
This FW flight log used firmware based on 1.8.0 release candidate (a few days before formal 1.8.0 release).  This PR was included in a short list of non-related custom items  Everything was great from the user perspective, but looking at the log there are a lot of airspeed innovations.
https://github.com/PX4/Firmware/pull/9723#issuecomment-399091038
These 3 logs are from a 2nd FW vehicle using firmware based on actual 1.8.0 formal release, plus this PR and a short list of other non-related custom items.
https://review.px4.io/plot_app?log=80301c1d-fac9-4a8a-a5e1-870927233e64
https://review.px4.io/plot_app?log=2c435fd6-96c2-41c7-b942-ed77ddb4942c
https://review.px4.io/plot_app?log=825a56c2-6c43-436b-b560-f365edeac9fa
https://review.px4.io/plot_app?log=2dcb0012-38a1-48cc-b144-bcbd06a310c8


(PDB-4897) Correct :source-tables for catalog inputs queries

Fix the :source-tables metadata for the catalog inputs queries They
were incorrectly using :source-table and providing a string, not a
set, but given the current uses of the data, that may not have
affected anything.

CLA signed by all contributors.


编译成功，测试报错

dyld: Library not loaded: /usr/local/opt/openssl/lib/libssl.1.0.0.dylib
Referenced from: /usr/local/opt/ffmpeg/lib/libavcodec.57.dylib
Reason: image not found
[1]    19815 abort      ./test ../models ../data/demo.jpg


Set up telemetry

Audit application logs, add statements where missing, set up Cloudwatch Logs Insights and/or OpenTelemetry

I think this task should be split into multiple smaller subtasks


Imgur doesn't want to be your host

In their tos, they say:

Also, don't use Imgur to host image libraries you link to from elsewhere, content for your website, advertising, avatars, or anything else that turns us into your content delivery network.

Thanks.


Postfx shutoffs

Adds:
$pref::Video::disableSSAO = false;
$pref::Video::disableHDR = false;
$pref::Video::disableLightRays = false;
$pref::Video::disableDOF = false;
$pref::Video::disableVignette = false;
a [Highest] entry in the shader quality dropdown.
as new prefs, which can override per map postfx settings
[Highest] = everything on
[High] = shuts off SSAO
[Normal] = additionally disables HDR
[Low] = for new flags is the same as normal, keeps the older shutoffs.
[Lowest] = takes no prisoners.

Closing this as incompatible and likely redundant due to the template refactor work.


Endless requests

Hi, when i scroll to the bottom/last note, meemo will stuck in a loop and makes endless reqeusts:

regards,
foo

This is due to the auto fetching when the page is scrolled all the way to the bottom. Maybe there is a bug with the viewport height changing. Is this on all browsers for you or just chrome (assuming by the screenshot)?

Hi, seems to be on chrome only. I can't reproduce it with firefox or safari.

Thanks for narrowing this down, I will try to reproduce this in chrome then

Thanks for narrowing this down, I will try to reproduce this in chrome then


[Query] Encrypt content of a file

There is a need to encrypt and store a file received through a HTTP request. Is there a way in Ballerina to achieve file encryption in Ballerina?

Ballerina crypto package provides the necessary utilities that are required to hash content using different hashing mechanisms and algorithms. Refer https://ballerina.io/learn/api-docs/ballerina/crypto.html for more details.


fix: strictly check if NODE_ENV is 'production'

Closes #1481

@hails please check with @kurtmilam if he's happy with this change as he's the OP and if he is, let's merge this.

LGTM!


Load Airlift Slice library in a separate DependencyClassLoader

After refactoring at #1201, we are moving this Airlift's Slice to the separate DependencyClassLoader for Buffer, the same as Netty Buffer.
Airlift's Slice is called from PageBuilder and PageReader. The entry point is io.airlift.slice.Slice here.

Thanks!


Is there a Rust SDK?

I couldn't find one, so I'm making one, based on this.  Let me know if one already exists, and/or you're interested.  Thanks!

Cline split the task into six stages.  I am now halfway through.

Unfortunately there isn't a Rust SDK yet. We're actively working on Java & Ruby SDKs and there are a couple of other languages in our pipeline before Rust.
Please share what you end up with! Interested to see what it looks like.

Unfortunately there isn't a Rust SDK yet. We're actively working on Java & Ruby SDKs and there are a couple of other languages in our pipeline before Rust.
Please share what you end up with! Interested to see what it looks like.

Thank you!  Will do.  It is well underway, and is something I need for further efforts.
Currently on v3.  Amazing developing software 100x faster.  It'll be MIT licensed.


[BUG] NameError from DataFusion changes

What happened:
I'm getting a NameError while testing one of the converted dask-sql notebooks, specifically the dsql_vs_pyspark_netflow, with Jeremy's DataFusion changes.
What you expected to happen:
I expected it to run with no errors.
Traceback:
https://gist.github.com/DaceT/b82b36a092d83ec19f995ce7f9b2e0c7

Looks like I inadvertently changed the build to not include the sql.yaml file as I was adding the rust logic. I have made the adjustment and the file will now be present after this is merged

Closed with #471


Building an fCC Forum Leader Board shows wrong test result output on the page.

Describe the Issue
When putting a join method after map method - some strange output is shown in the window of the pass test result, as depicted on the screenshot attached.

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-asynchronous-programming-by-building-an-fcc-forum-leaderboard/step-14
Your code
const showLatestPosts = (data) => {
  const { topic_list, users } = data;
  const { topics } = topic_list;
  postContainer.innerHTML = topics.map((item) => {}).join('')
};

Expected behavior
The result of the test must show up, but instead some object is printed out.
Screenshots

System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

I have been able to reproduce this on my end.
The output you are seeing is coming from line 12 (console.log(data);).
Sometimes, the results of that fetch call will show up in the hint section like you mentioned.
Logging the data to the console was introduced in step 8 so campers can see what the result looks like.
My proposal is to remove that console.log(data); in step 9, since it is no longer referenced or used in the rest of the steps.
The updated description for step 9 could be this
If there is an error from the `fetch` call, the `catch` block will handle it.

Inside the `catch` block, add a `console.log` to log the `err` parameter.

Also, remove your `console.log(data);` from your `try` block now that you understand what is being returned from the `fetch` call.

Then the  console.log(data); will need to be removed from the rest of the steps seed code.
I'll open this up for discussion by the other maintainers before opening this up for contribution

Note to interested contributors
This issue has been opened up for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.
If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/
Make sure to implement the changes mentioned here
https://github.com/freeCodeCamp/freeCodeCamp/issues/52746#issuecomment-1872824913
Also, note that this involves adding a test to check that the camper has removed the console.log(data); in step 9.
Your PR should also make sure the console.log(data); was removed from the seed code in all steps from step 10 to the end including the final seed code in the last step.
If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum
Happy coding!


Subscriptions/Websockets Support

Is your feature request related to a problem? Please describe.
I'd like to implement realtime on my app
Describe the solution you'd like
Subscriptions, eg https://trpc.io/docs/subscriptions
Describe alternatives you've considered
tRPC server

I came here shopping for the same reason, tRPC is such a pain to get working and I was hoping for a simpler implementation.

oh it would be cool, may be if any unofficial recommendation guy's if any ?


Cannot connect

I can't connect using the Kadira Debug UI.
I installed kadira:debug in my Meteor app, went to the debug ui, clicked connect, but nothing's happening. It does show it's opening a websocket in the Network dev tools, but I'm not getting any info whatsoever.

Same problem here.

It doesn't work for me either.  After hooking into DDPCommon on the server I'm trying to debug, I'm seeing this:
DDPCommon.parseDDP called with arguments "msg":"method","method":"kadira.debug.remote.getAppEnv","params":[],"id":"1"}
DDPCommon.stringifyDDP called with arguments { msg: 'result',
  id: '1',
  error:
   { [Error: Method not found [404]]
     error: 404,
     reason: 'Method not found',
     details: undefined,
     message: 'Method not found [404]',
     errorType: 'Meteor.Error' } }

It looks pretty clear that the meteor methods that this package injects are NOT getting injected or they're getting removed.  Hence, the client cannot connect.  I'm searching for a cause, but no promises.


G8RecognitionOperation 100% tests covering

Coverage increased (+0.5%) to 95.44% when pulling 7349f69cc67a0228c03b754b49bf5943b9cec23f on ws233:master into 2cea0daebd5e3515f2fc8475b98e86201e8f4937 on gali8:master.

Coverage increased (+4.08%) to 99.03% when pulling ccbc68ef9aac27f7df59980ebf7e3a65c4dfa5b0 on ws233:master into 2cea0daebd5e3515f2fc8475b98e86201e8f4937 on gali8:master.

Awesome job! Merging and closing.


cannot build on windows (visual studio 2017)

Tried to build in visual studio 2017, and failed. Here are details-
Output from CMake (worked OK):
Switching to configuration x64-Release....
1> Command line: C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe  -G "Ninja" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\zhangm\CMakeBuilds\388f00b3-512f-9432-b437-6405447a5d4e\install\x64-Release"  -DCMAKE_CXX_COMPILER="C:/Program Files/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.14.26428/bin/HostX64/x64/cl.exe"  -DCMAKE_C_COMPILER="C:/Program Files/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.14.26428/bin/HostX64/x64/cl.exe"  -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\Users\zhangm\git_repos\bamtools"
1> Working directory: C:\Users\zhangm\CMakeBuilds\388f00b3-512f-9432-b437-6405447a5d4e\build\x64-Release
1> CMake Deprecation Warning at CMakeLists.txt:20 (cmake_policy):
1>   The OLD behavior for policy CMP0042 will be removed from a future version
1>   of CMake.
1>
1>   The cmake-policies(7) manual explains that the OLD behaviors of all
1>   policies are deprecated and that a policy should be set to OLD only under
1>   specific short-term circumstances.  Projects should be ported to the NEW
1>   behavior and not rely on setting a policy to OLD.
1>
1>
1> -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
1> -- Checking for one of the modules 'jsoncpp>=1'
1> Did NOT find system JsonCpp, instead using bundled version
1> -- Configuring done
1> -- Generating done
1> -- Build files have been written to: C:/Users/zhangm/CMakeBuilds/388f00b3-512f-9432-b437-6405447a5d4e/build/x64-Release
1> Starting CMake target info extraction ...
1> CMake server connection made.
1> Extracted includes paths.
1> Extracted CMake variables.
1> Extracted source files and headers.
1> Extracted global settings.
1> Extracted code model.
1> Extracted CTest info.
1> Collating data ...
1> Target info extraction done.
Configuration switch to x64-Release complete.
The build process exited with 1154 warnings, and 9 errors. Here are some of the errors-
Code	Severity	Description	Project	File	Line	Suppression State
C2491	Error	'BamTools::FilterEngine::buildRuleQueue': definition of dllimport function not allowed	C:\Program Files\Microsoft Visual Studio\2017\Community\Common7\IDE\CMakeLists.txt	C:\Users\zhangm\git_repos\bamtools\src\utils\bamtools_filter_engine.h	266
C2491	Error	'BamTools::FilterEngine::enabledPropertyNames': definition of dllimport function not allowed	C:\Program Files\Microsoft Visual Studio\2017\Community\Common7\IDE\CMakeLists.txt	C:\Users\zhangm\git_repos\bamtools\src\utils\bamtools_filter_engine.h	292
C2491	Error	'BamTools::FilterEngine::filterNames': definition of dllimport function not allowed	C:\Program Files\Microsoft Visual Studio\2017\Community\Common7\IDE\CMakeLists.txt	C:\Users\zhangm\git_repos\bamtools\src\utils\bamtools_filter_engine.h	370
C2491	Error	'BamTools::FilterEngine::setDefaultCompareType': definition of dllimport function not allowed	C:\Program Files\Microsoft Visual Studio\2017\Community\Common7\IDE\CMakeLists.txt	C:\Users\zhangm\git_repos\bamtools\src\utils\bamtools_filter_engine.h	505
C2491	Error	'BamTools::FilterEngine::setRule': definition of dllimport function not allowed	C:\Program Files\Microsoft Visual Studio\2017\Community\Common7\IDE\CMakeLists.txt	C:\Users\zhangm\git_repos\bamtools\src\utils\bamtools_filter_engine.h	571

Please try with latest HEAD, which has a number of fixes for Windows.


Implement memory range mapping/unmapping; Cleanup and standardize vmap API

This resolves #253.

Great work, Pawel. Only a few nits and questions left, but really no more code changes required.
The comment regarding only being able to unmap single pages via SYSCALL_MUNMAP still applies. But I guess, now with v[un]map_range() available, it's easy to extend the functionality to cover multiple pages. But this can (and should!) be a follow-up change.
Thanks again for the hard work!

Thanks very much Mathias!
I created a dedicated issue for the mmap/munmap usermode extension: #332. This should also depend on another issue: #331, but in general should be much easier to implement now.


Use stm32f3xx-hal instead of stm32f30x_hal and upgrade all dependencies

All dependencies upgraded to the latest ones and all examples retested

Thank you for this! However, this introduces breaking changes for users so the minor version should be bumped instead of the patch version.

I was going to do it but then I decide to let @japaric to bump it when releasing to crates.io.

Thank you for this! However, this introduces breaking changes for users so the minor version should be bumped instead of the patch version.

I just ran into this with #110. I was beginning down the road of making a very similar change when I noticed this. What changes need to be made here to make this ready to go? Is it just the version number?

f3 is quite outdated in its current state: seems like one of the dependencies doesn't even build on nightly. It would be great to release an updated version. @japaric, could you help with this?

@Disasm I continued chasing the compiler errors on my branch a bit. It looked like I was going to end up in the same place as this PR. I’m going to pull this branch later and see if it’s still in working condition.

It builds clean on stable, but some of the dependencies are out of date already.

I can confirm moving from f3 0.6.0 to this fork seems to produce nothing but Framing errors when I read my serial port. Anything I can do to move this forward?

Oh, I fixed it as soon as I posted - typical. With the newer crate you have to set up the clocks to use the external oscillator, otherwise the UART doesn't work. I guess I was running at 32 kHz or something.
Now I get issues clearing UART errors, but that's a question for the HAL crate. I'd like to see F3 updated with the newer HAL as soon as possible.

@thejpster I’ve been working on an alternative bsp that is almost at feature parity.
https://github.com/rubberduck203/stm32f3-discovery


Post of GeographyPoint property fails with conversion error

Trying to post a class which has a GeographyPoint property and I get the error message...
Conversion is not supported from type Microsoft.Data.Spatial.GeographyPointImplementation to OData type [Edm.GeographyPoint Nullable=True SRID=4326]
I think this is due to the type conversion logic in V4.Adapter.RequestWriter which has
case EdmTypeKind.Primitive:
    var mappedTypes = _typeMap.Where(x => x.Value == (propertyType.Definition as IEdmPrimitiveType).PrimitiveKind);
    if (mappedTypes.Any())
    {
         foreach (var mappedType in mappedTypes)
         {
             object result;
             if (Utils.TryConvert(value, mappedType.Key, out result))
                 return result;
           }
          throw new NotSupportedException(string.Format("Conversion is not supported from type {0} to OData type {1}", value.GetType(), propertyType));
      }
      return value;

The issue is that the GeographyPoint is actually constructed by MS as an internal class GeographyPointInternal which won't match the type conversion comparison as it's not an exact match.
I can see some TripPin geo examples but they are just retrieval which works fine

Ok, it is trying to use Convert to change GeographyPointImplmentation to GeographyPoint which is failing due to IConvertible not being implemented.
Found https://github.com/OData/WebApi/issues/718 which is similar so I've fixed it the same way, all the tests pass and I've added a unit test, can add an integration test if you don't mind me extending one of the entities in Northwind service with a property?

For reference the next issue I had was a stack overflow in WebAPI due to http://stackoverflow.com/questions/19941808/exclude-a-type-from-model-validation-example-dbgeography-to-avoid-insufficient/19964146#19964146
The fix there worked


minor: publish new github release for dds support on linux

Resolved by microsoft/vcpkg#33449

thanks


Add the CIDEr metric?

Hi,
I find the api in https://huggingface.co/metrics  quite useful.
I am playing around with video/image captioning task, where CIDEr is a popular metric.
Do you plan to add this into the HF datasets library?
Thanks.

same


What do you lose 'pangloss/vim-javascript'

I am curious why its recommended to install 'pangloss/vim-javascript'. Curious to why. What are we losing or gaining?

@jrock2004
Our plugin only highlights the JSX portion of the js source file. The rest of the source file is highlighted by vim-javascript or some other vim plugins, such as yajs.vim etc. And yes, you don't have to use any of them to highlight the javascript syntax if you like.
I recommend using vim-javascript, because this plugin is widely used and actively maintained. I also read the source code of this plugin and found that its syntax groups are much more reasonable.
Our plugin added some patch code for different javascript syntax plugins to work with them. You can see that there only one line need to be added for vim-javascript.
Personally, I have been using this plugin all the time, and it works well.

Ah ok, so its recommended so you get full highlighting support, gotcha


Ext overrides2 fix predictions

Description of changes

Created storage-api plugin api.
Updated predictions to remove direct mutation of storage cloudformation template.
Updated storage to support multiple lambda triggers .

Issue #, if available
https://app.asana.com/0/1201180241378567/1201248844053114/f

Description of how you validated changes
Manually tested identity walkthrough
[passing tests]

create s3 +  trigger -works in prefix folders( /private/$region, /protected/$region, /public/$region)
create s3 + trigger  + create predictions + admin-trigger
create s3  + create predictions + admin-trigger + new function
no s3 + create predictions  + admin-trigger

[pending fixes]

create s3 +  create predictions + admin-trigger + s3-trigger ( reuse predictions admin-trigger ) - fails
[pending fix] block s3 from mutating admin-lambda in s3 update walkthrough.
2.create predictions + use advanced identity walkthrough + admin-lambda ( fails during function creation since add walkthrough has not completed) .
[pending fix]  update current logic to create predictions category cloudformation prior to generating admin-trigger.
delete predictions - fails
[pending fix] call s3-api from remove.

[pending tests]

migration scenario - ( create predictions, update predictions + storage migrate ).

Checklist

[*] PR description included
[* ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8622 (74a78c0) into extOverrides2 (b51b44e) will decrease coverage by 0.14%.
The diff coverage is 14.32%.

@@                Coverage Diff                @@
##           extOverrides2    #8622      +/-   ##
=================================================
- Coverage          56.26%   56.11%   -0.15%
=================================================
  Files                795      797       +2
  Lines              45285    45492     +207
  Branches            9073     9120      +47
=================================================
+ Hits               25478    25527      +49
- Misses             18997    19155     +158
  Partials             810      810

Impacted Files
Coverage Δ

...dformation/cdk-stack-builder/s3-stack-transform.ts
9.44% <0.00%> (-0.16%)
:arrow_down:

...utils/awscloudformation/cdk-stack-builder/types.ts
15.62% <ø> (ø)

...rage/src/provider-utils/awscloudformation/index.ts
14.10% <ø> (ø)

...mation/service-walkthroughs/s3-user-input-state.ts
8.73% <0.96%> (-2.20%)
:arrow_down:

...oudformation/cdk-stack-builder/s3-stack-builder.ts
4.04% <2.17%> (-0.81%)
:arrow_down:

...dformation/service-walkthroughs/s3-resource-api.ts
15.66% <15.66%> (ø)

...der-utils/awscloudformation/s3-headless-adapter.ts
17.24% <17.24%> (ø)

...awscloudformation/storage-configuration-helpers.ts
14.09% <20.00%> (+1.90%)
:arrow_up:

packages/amplify-category-storage/src/index.ts
22.62% <58.62%> (ø)

...n/service-walkthrough-types/s3-user-input-types.ts
80.00% <100.00%> (+3.52%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51b44e...74a78c0. Read the comment docs.


I have issue running project

When I try to run make seed I get this error
make seed
go run cmd/seed/main.go
(*ent.User)(<nil>)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x18e10ec]

goroutine 1 [running]:
github.com/mikestefanello/pagoda/seeder.SeedUsers.func2(0x0, {0x0?, 0x0?}, {0x0?, 0x80?, 0x3316920?}, {0x21dcd30, 0x2}, {0x1defd71, 0xc})
        /home/bajro/GoShip-main/seeder/seeder.go:103 +0xec
github.com/mikestefanello/pagoda/seeder.SeedUsers(0xc00101fb08, 0xc00126dba0, 0x1)
        /home/bajro/GoShip-main/seeder/seeder.go:135 +0x4c9
main.main()
        /home/bajro/GoShip-main/cmd/seed/main.go:12 +0x2d
exit status 2
make: *** [Makefile:149: seed] Error 1

Hey thanks for the comment! I tried reproducing it (with a fresh git clone in /tmp and fresh containers), but couldn't reproduce it. Not quite sure what's going on here. I will keep an eye out for it.
Let me know if there's more context I might have missed in trying to reproduce this, thanks!!

Hey thanks for your message and trying out GoShip!
I can reproduce your error when I run the seeder more than once on the same containers. While I never made it idempotent before, I added a rough check for idempotency and it can now be run multiple times in a row without issues.
Sorry for the unfriendly crash.
I also updated the Readme to have only 1 command to set up a fully working instance.
Let me know if you have any more questions!

Feel free to re-open if you face this issue again


[Crash] AnimationPlayer with frames outside of animation timeline causes app not to start

Godot version
v3.4.3.rc1.official [894b6d504]
System information
Mac OSX (Intel 2019)
Issue description
AnimationPlayer with frames outside the animation timeline causes the app not to start.

Notice that I lowered the timing from 6.2 seconds to 3.0 seconds. The game then refuses to start.
Steps to reproduce

Add AnimationPlayer
Add frames to an animation
Move frames outside the timeline

Minimal reproduction project
No response

Disregard, seems to be an issue with the animation in general.


[ci::github.com/gardener/machine-controller-manager:0.9.0->0.10.0]

Release Notes:
- Enhanced integration tests to support AWS and GCP.
- Adding support in integration tests for a new provider is simpler and modular now.

The mcm has now support to integrate custom Prometheus metrics. A metric to expose the amount of managed machines is already integrated.

Integrated support for Ali cloud in MCM

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[crictl]Plans to support yaml format podsandbox/container spec?

crictl is designed for CRI general debugging purpose, json format is less easy to read/write for human, is there any plan to support yaml format in run podsandbox or create container related command?

Yep, that's the plan (see here). Also we could support output formats, e.g. json and yaml.


feat: split WebSocket

Fixes #40. Working on this in concert with https://github.com/denoland/deno/pull/20579 and #49
This API is not final
To create a split WebSocket, you can either call:

WebSocket::split, passing a function that can split a stream into read and write halves (tokio::io::split is suitable for this, as well as TcpStream::into_split https://docs.rs/tokio/latest/tokio/net/struct.TcpStream.html#method.into_split), or
after_handshake_split, passing read and write streams.

From the WebSocketRead and WebSocketWrite halves, you'll need to ensure that obligated writes from WebSocketRead::read_frame are passed to write_frame. This is done by passing a closure that returns a future.
Note that a FragmentCollectorRead may be created from a WebSocketRead in the same way that FragmentCollector may be created from a WebSocket.
In the case of Deno's split socket, the read process looks like this:
  let mut ws = RcRef::map(&resource, |r| &r.ws_read).borrow_mut().await;
  let writer = RcRef::map(&resource, |r| &r.ws_write);
  let mut sender = move |frame| {
    let writer = writer.clone();
    async move { writer.borrow_mut().await.write_frame(frame).await }
  };
  loop {
    let res = ws.read_frame(&mut sender).await;

@mmastrac Code looks good but the the example server is not working:
use fastwebsockets::upgrade;
use fastwebsockets::OpCode;
use fastwebsockets::WebSocketError;
use hyper::server::conn::Http;
use hyper::service::service_fn;
use hyper::Body;
use hyper::Request;
use hyper::Response;
use tokio::net::TcpListener;

async fn handle_client(fut: upgrade::UpgradeFut) -> Result<(), WebSocketError> {
  let ws = fut.await?;
  let (mut rx, mut tx) = ws.split(|ws| tokio::io::split(ws));

  loop {
    // Empty send_fn is fine because the benchmark does not create obligated writes.
    let frame = rx.read_frame(&mut move |_| async { Ok::<_, WebSocketError>(()) }).await?;
    match frame.opcode {
      OpCode::Close => break,
      OpCode::Text | OpCode::Binary => {
        tx.write_frame(frame).await?;
      }
      _ => {}
    }
  }

  Ok(())
}
async fn server_upgrade(
  mut req: Request<Body>,
) -> Result<Response<Body>, WebSocketError> {
  let (response, fut) = upgrade::upgrade(&mut req)?;

  tokio::task::spawn(async move {
    if let Err(e) = tokio::task::unconstrained(handle_client(fut)).await {
      eprintln!("Error in websocket connection: {}", e);
    }
  });

  Ok(response)
}

fn main() -> Result<(), WebSocketError> {
  let rt = tokio::runtime::Builder::new_current_thread()
    .enable_io()
    .build()
    .unwrap();

  rt.block_on(async move {
    let listener = TcpListener::bind("<IP_ADDRESS>:8080").await?;
    println!("Server started, listening on {}", "<IP_ADDRESS>:8080");
    loop {
      let (stream, _) = listener.accept().await?;
      println!("Client connected");
      tokio::spawn(async move {
        let conn_fut = Http::new()
          .serve_connection(stream, service_fn(server_upgrade))
          .with_upgrades();
        if let Err(e) = conn_fut.await {
          println!("An error occurred: {:?}", e);
        }
      });
    }
  })
}

Running load_test:
divy@mini ~/g/f/benches (split) [SIGINT]> ./load_test 10 <IP_ADDRESS> 8080 0 0
Running benchmark now...
ERROR: outstanding bytes negative!⏎

divy@mini ~/g/fastwebsockets (split)> target/release/examples/split_server
Server started, listening on <IP_ADDRESS>:8080
Client connected
Client connected
Client connected
Client connected
Client connected
Client connected
Client connected
Client connected
Client connected
Client connected
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Connection reset by peer (os error 54)
Error in websocket connection: Unexpected EOF

I can repro that problem here. Digging into it.

@littledivy Ah. It's because there wasn't a fragment collector on the read half. I will add some documentation around this.

Ran the two benchmarks and it looks pretty good:
Split:
✘-INT ~/Documents/github/deno/deno_third_party [master|✔]
10:01 $ prebuilt/mac/load_test 10 <IP_ADDRESS> 8080 0 0
Running benchmark now...
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
^C

Unsplit
✘-INT ~/Documents/github/deno/deno_third_party [master|✔]
10:07 $ prebuilt/mac/load_test 10 <IP_ADDRESS> 8080 0 0
Running benchmark now...
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
Msg/sec:<PHONE_NUMBER>00
^C


update db-active-record.md

I have tried example script working in transaction using active record (first way). It doesn't work like transaction using db dao because method save only return boolean and doesn't return throw exception when fail. I have not try the second way example script, I will try it later. Thanks.

save() returns false only if validation doesn't pass - you should validate model before starting transaction (and probably handle this more gently than throwing an exception).
save() may still throw an exception on SQL error.

save() returns false only if validation doesn't pass - you should validate model before starting transaction (and probably handle this more gently than throwing an exception).
save() may still throw an exception on SQL error.

Thanks @rob006  for your response before. I suggest this because I want scenario if one data saving fail to saved then all data saving will rollback. I don't know how to handle this besides throwing an exception. May you give example how to handle transaction besides this one?

You can just do this before starting transaction:
if (!$customer->validate() || !$order->validate()) {
    // handle error, usually display form with validation errors
}

thanks again @rob006
I know this pull request closed. But seems I describe wrong about my question, I want to clearify how we trigger method save() in AR so it will throw exception and rollback transaction?
I mean we can write code
if (!$customer->validate() || !$order->validate()) {
    // handle error, usually display form with validation errors
}

$transaction = Customer::getDb()->beginTransaction();
try {
    $customer->id = 200;
    $customer->save();
    // ...other DB operations...
    $transaction->commit();
} catch(\Exception $e) {
    $transaction->rollBack();
    throw $e;
} catch(\Throwable $e) {
    $transaction->rollBack();
    throw $e;
}

How we trigger this block try so it will thrown an exception? Should I worry about this?
Or I should trust this code and only fail/rollback if database server goes down?
Is this probably what you mean?

How we trigger this block try so it will thrown an exception?

Database layer throws exception in case of failure to perform a query.

Should I worry about this?

No.

Is this probably what you mean?

Yes. If validation passed, there's only database failures to look at and these are handled.

many thanks @samdark
I am relieved now


Try finding top-left corner of display window from PIXELSW pin

Denise has an output pin PIXELSW that is supposed to indicate if a pixel has the background color or not. It might be possible to use this pin in some clever way to find the top-left corner of the display window (DIWSTRT), which could be used to remove overscan and only output the pixels in the display window. Probably one has to make additional assumptions about the size of the display window for this to work, which may only work in certain circumstances. Experiment!

BTW what about HDMI and simply skip the analogue part..?

@polluks HDMI sounds great, I would like it very much myself. The only reason I'm using VGA is because it is simple and because there's a VGA connector on the DE10-Lite FPGA dev board.
You don't happen to have a suggestion for a good and easy to use HDMI serializer chip?

I see, however I'm just a software guy.

HDMI serializer chips are only sold to HDMI Adopters (joining fee $5,000). However, it's relatively straightforward to serialize video data on an FPGA and then output it directly to an HDMI connector (or more robustly via a buffer chip such as the TI TMDS141 - which doesn't require joining the HDMI forum).
I have previously worked on an open-source HDMI design in Verilog for Xilinx FPGAs: https://github.com/projf/display_controller
It should be relatively painless to adapt to Altera.

Aha, at least better than a simple upscaler.

Hi @WillGreen. Thanks for the information! The TFP410 sounds quite interesting.
Regarding serializing HDMI signals on the FPGA, isn't it the case that the frequencies become very high? For example, I want to output 1280x1024@60Hz which has a pixel clock of 108 MHz, wouldn't that mean that the HDMI frequency is 10 times that, i.e. over 1 GHz, which a 10M02 FPGA certainly can't handle ?
What do you think of buying a chip such as Analog Devices ADV7513 from AliExpress? I haven't tried buying anything from there yet, and it seems a bit shady with what you wrote about having to be an HDMI adopter, but since it's only for personal use I wouldn't expect there to be any bad consequences, if the chips are actually legitimate. At least the prices seems quite reasonable.


🛡 Inadequate Input Validation in Objectarium Contract Instantiation

[!NOTE]
Severity: Low
target: v5.0.0 - Commit: cde785fbd2dad71608d53f8524e0ef8c8f8178af
Ref: OKP4 CosmWasm Audit Report v1.0 - 02-05-2024 - BlockApex

Description
The instantiation process in the Objectarium contract lacks comprehensive input validation, specifically for the parameters associated with bucket configuration and limits. This deficiency may lead to configurations that render the contract functionally ineffective or vulnerable to misuse. The try_new method in the Bucket class currently only checks for an empty bucket name, overlooking critical validations on the numerical limits set for the bucket.
Recommendation
Enhance the validation logic within the Bucket::try_new method to include checks on all parameters.

For the BucketLimit object, I don't see any additional checks that could be added, since setting a 0 value is considered as no limit (default value).

@bdeneux Are you sure about the 0 considered as no limit?

@amimart Sorry, you're right, according to the documentation it's not the zero value that indicate no limit but omitted value.
https://github.com/axone-protocol/contracts/blob/9d0958df573c13b59ca70319e7cc137cf470c57c/contracts/axone-objectarium/src/msg.rs#L300
PaginationConfig
✅ Ok with your propositions
BucketConfig
We need to check the behavior but according to the documentation, setting empty array is the same as omit this setting parameter (It's mean that all compressions algorithms are allowed) so is not necessary to check this configuration, except if we want to change the behavior and says that setting empty accepted_compression_algorithm is an incorrect configuration.
https://github.com/axone-protocol/contracts/blob/9d0958df573c13b59ca70319e7cc137cf470c57c/contracts/axone-objectarium/src/msg.rs#L268-L280
BucketLimits
✅ Ok for those configurations checks. For the max_objects_pins, there is no interest being set to 0 but it's possible, I don't know too what is the best option 🤷.