Update pytorch dependency and other lint fixes

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Update the pytorch dependency to allow the GPU version per #3, and fix other linter issues.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mgorny - do you want to add yourself as a maintainer here and ask conda-forge/core to merge? It seems like the feedstock has been unmaintained for a while.

@mgorny - do you want to add yourself as a maintainer here and ask conda-forge/core to merge? It seems like the feedstock has been unmaintained for a while.

No. Just doing janitorial work, no real clue about the package in question.


Functionality Increment: Allocate Command

This PR adds the functionality increment of the Allocate Command. Allocation of a room to a student is performed by referencing the index of the room and the index of the student in the Address Book, consistent with the Delete Command for deleting a Student from the Address Book. si/ and ri/ prefixes thus refers to the student index and room index respectively. Student Card in the user interface now reflects the floor and room number if the student has been allocated a room.
Example usage:
allocate ri/1 si/1
Changes made:

Add AllocateCommand, that performs 3 checks on execution:

Student referenced exists.
Room referenced exists.
Student has not already been allocated a room.

Add AllocateCommandParser, that parses student and room indices from si/ and ri/ prefixes respectively.
Add attribute JsonAdaptedRoom to JsonAdaptedStudent, where 2 cases may occur:

If the student has been allocated a room, JsonAdaptedRoom will be reflected under the student in data/addressbook.json.
If the student has not been allocated a room, null will be reflected in data/addressbook.json instead.

Add method withRoom to StudentBuilder in testutil and modify build() to reflect student's allocated room.
Modify StudentCard in ui to reflect floor and roomNumber if the student has been allocated a room, otherwise shows "Unallocated", and corresponding StudentListCard.fxml labels.

To be done:

Add testing support for AllocateCommand, AllocateCommandParser, JsonAdaptedRoom.
Add DeallocateCommand, EditAllocateCommand, including testing support.

As part of #12, #13.

Codecov Report

Merging #78 into master will increase coverage by 0.54%.
The diff coverage is 25.60%.

@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
+ Coverage     65.03%   65.57%   +0.54%
- Complexity      432      450      +18
============================================
  Files            83       85       +2
  Lines          1513     1592      +79
  Branches        160      182      +22
============================================
+ Hits            984     1044      +60
+ Misses          488      486       -2
- Partials         41       62      +21

Impacted Files
Coverage Δ
Complexity Δ

...main/java/seedu/resireg/commons/core/Messages.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../seedu/resireg/logic/commands/AllocateCommand.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

.../seedu/resireg/logic/parser/AddressBookParser.java
84.21% <0.00%> (-4.68%)
12.00 <0.00> (ø)

...du/resireg/logic/parser/AllocateCommandParser.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...in/java/seedu/resireg/logic/parser/ParserUtil.java
78.43% <0.00%> (-19.13%)
16.00 <0.00> (ø)

src/main/java/seedu/resireg/model/AddressBook.java
69.23% <ø> (ø)
14.00 <0.00> (ø)

src/main/java/seedu/resireg/model/Model.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...rc/main/java/seedu/resireg/model/ModelManager.java
87.27% <0.00%> (-3.30%)
23.00 <0.00> (ø)

src/main/java/seedu/resireg/ui/StudentCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...main/java/seedu/resireg/model/student/Student.java
94.33% <75.00%> (-3.39%)
26.00 <4.00> (+5.00)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4836cf2...5f57d96. Read the comment docs.


Infinite loop and autoplay conflict

When infiniteLoop is set to false and autoplay is set to true, carousel reverses order instead stopping at the last slide. If we click on next/prev buttons it worked well.

====================================================================
http://jsfiddle.net/fmo50w7n/304/
====================================================================
Steps to reproduce the problem

Set "infinite" option to false
Set "autoplay" option to true

====================================================================
What is the expected behaviour?
It should be stopped at the end of carousel.
====================================================================
What is observed behaviour?
It is starts reversing the order if "autoplay" is false.
====================================================================

Hey @amit-brainstormforce, interesting issue. Totally get your reasoning. I can see arguments for both behaviors. I did a search through the issue history, and found #1096 and #528 which should help clarify and #1096 even has a solution. Hope that helps. Thanks!


Install firmware from web ui without internet

My yi cameras are all on old firmware and none have internet access.  It would be great if i could upload new firmware from the web ui without having to pull all the cameras down and flash the sd cards.  I only see the option to check for updates online and no option to upload custom firmware.

I ended reading through the firmware update script and just running similar commands to update via ssh after putting the firmware on the camera via ftp.  It worked great :)

I would also appreciate if the firmware installation (e. g. changing back to a former version) would be possible via the web UI.


graphics seem to 'like' crossed over binding features

I think this is an issue with the 'charge' and 'gravity' settings for the force directed layout. Hopefully, if the reppelling 'charge' force is higher they will uncross themselves.

The tendancy to always get it wrong was due to the start positions of the nodes. Hopefully this is better in the version to be pulled by pull request #44.
I going to close, reopen if still a problem.


DatePicker date going out of range

Describe the bug
Currently, users can crash the app by setting a date out of range using the previous/next button in the DatePicker.
To Reproduce
Steps to reproduce the behavior:

Go to UICatalog DatePicker
Set the date, for example, to 12/12/9999.
Click next month button
The app crashes.

Expected behavior
The view should prevent setting a date out of range by disabling the previous/next buttons.

You fixes when you arrive to the 01/01/10000 😄

The exception also occurs when the date is 01/01/0001 and you click on the previous month.

The exception also occurs when the date is 01/01/0001 and you click on the previous month.

Yes, I have also addressed this 😉


fix(web-ui): updata lodash dependency (#927)

Fixes #927

Codecov Report

Merging #928 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #928   +/-   ##
=========================================
  Coverage     84.53%   84.53%
  Complexity      906      906
=========================================
  Files           175      175
  Lines          2735     2735
  Branches        436      436
=========================================
  Hits           2312     2312
  Misses          203      203
  Partials        220      220

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3fa76a...889dc2f. Read the comment docs.

:+1:


Why the canvas manager?

Hi Martin,
I was trying out ipycanvas with solara, on pycafe actually:
https://py.cafe/maartenbreddels/solara-ipycanvas-fractal-tree

And to work with solara, we need to create a new canvas manager for each virtual kernel, since widgets cannot be shared.
We saw the same issue in https://github.com/bloomberg/ipydatagrid/pull/400 , and it seems also shiny is having the same issues:
https://github.com/posit-dev/py-shinywidgets/issues/99
So I was wondering what the idea is behind the canvas manager, and why it is shared.
cheers,
Maarten

Hey Maarten!
All the communication of canvas widgets go through this "manager" to make sure all commands are run in order.
This fixes issues when asynchronous things are happening in the page during the draw (e.g. drawing an image based of an url).
e.g.:
from ipywidgets import Image

from ipycanvas import Canvas, hold_canvas

import urllib.request

urllib.request.urlretrieve('https://github.com/jupyter-widgets-contrib/ipycanvas/raw/master/examples/sprites/smoke_texture0.png', 'smoke_texture0.png')
urllib.request.urlretrieve('https://github.com/jupyter-widgets-contrib/ipycanvas/raw/master/examples/sprites/smoke_texture1.png', 'smoke_texture1.png')

sprite1 = Image.from_file('smoke_texture0.png')
sprite2 = Image.from_file('smoke_texture1.png')

# Create two canvases
canvas = Canvas(width=300, height=300)
canvas2 = Canvas(width=600, height=300)

# We draw some images on the first canvas **THIS IS ASYNC BECAUSE OF DOWNLOAD THE IMAGE PRIOR TO DRAW IT**
canvas.fill_style = '#a9cafc'
canvas.fill_rect(0, 0, 300, 300)
canvas.draw_image(sprite1, 50, 50)
canvas.draw_image(sprite2, 100, 100)

# Draw the first canvas on the second canvas **THIS ABSOLUTELY NEED TO RUN AFTER THE OTHER TASKS**
# the manager will make sure of that by waiting for `canvas` to have finished before executing commands on `canvas2`
canvas2.draw_image(canvas, 0, 0)
canvas2.draw_image(canvas, 300, 0)

canvas2

What if canvas2 (the model on the frontend) asked directly to canvas1 if it has anything in its queue? Why do you need a separate widget?
Maybe this queue pattern that we use in ipyreact would help? https://github.com/widgetti/ipyreact/blob/b48b045fd22a3d4f0d20c5c4b79b71bdb1bbc0a4/src/widget.tsx#L472
(I'm trying to look for ways that ipycanvas would work out of the box on systems with multiple users in 1 process)

FYI, i'm now using this trick to get it working with solara
# workaround for ipycanvas for using a singleton widget
import traitlets
import ipycanvas
ipycanvas.canvas._CanvasBase._canvas_manager.default_value = traitlets.Undefined
ipycanvas.canvas._CanvasBase._canvas_manager.make_dynamic_default = ipycanvas.canvas._CanvasManager

See https://py.cafe/maartenbreddels/stackview-3d-mri-viewer


feature: Add underclock percent (and/or quantity, whichever is more precise) to the hover text for a component

When making a build, it'd be nice to have underclocking added to the hover for a component.
Example:

Ideally the "quantity" calculation would be shown as well, e.g. 1 at 100% (5/min), 1 at 60% (3/min) since a lot of times percentages are long and useless but the per-minute is a whole number - e.g. Concrete where 240 Limestone  = 5.33... constructors. In other words: 5 at 15/min and 1 at 5/min, which is much easier to comprehend.

Yep, this feature is planned in the nearby future and will likely come out at the same time as the ficsmas recipes!

This feature is now live!


Server synchronization

[ ] create server synchronization GUI elements
[ ] specify synchronization tasks
[ ] define exchange format with server
[ ] write synchronization feature

Implemented the synchronization from server to client.


Enable bazel remote cache for macos C/C++ CI tests

speedup macos kokoro C/C++ bazel test by using remote build cache

only use cache on kokoro mac workers
invalidate cache if kokoro macos worker image changes (to avoid false hits)

Speedup:

based on my experiments, the full bazel build on macos workers takes ~23min without cache and ~7mins when rebuilding fully from cache.
so this should speed up macos C/C++ bazel test jobs by ~15mins.

@dennycd  a similar technique can likely be used for speeding up the ObjC bazel build.

Slightly suspicious test result:
https://source.cloud.google.com/results/invocations/368a774a-acc9-4984-9b5a-9031a32a5a45/targets
(I'll add explanation for it once I investigate).

Another strange error: https://source.cloud.google.com/results/invocations/5c1a5bfe-e9cd-4250-9f80-4667ea92e328/log

I ran a bunch more adhoc runs of the macos C/C++ bazel tests and all of them passed, so I wasn't able to confirm that the failures above are linked to the changes in the PR (they seems odd, but they don't seem to be linked to the changes I made).
So I'm going to merge and I'll keep an eye on the tests (and revert if things don't look good).


Fix git9 build in the distribution.

Git was being compiled, but its script library was not included in the
distribution.
Add /sys/lib/git to mkdirs
Add /sys/lib/git to dist/replica/plan9.proto
[really just pipecleaning my git process here...]
Signed-off-by: Paul Lalonde<EMAIL_ADDRESS>

Welcome to harvey, it's very nice to have you here.


ArgumentNullException @ ComboGestureCompilerEditor [1.3.0]

Hey,
firstly thank you for making this awesome tool :)
With the latest release (1.3.0) i've encountered an issue when creating an empty/new ComboGestureCompiler

With this im unable to configure anything in the Compiler, to use the Compiler i added a null check even though i have no clue what implications this has 😂 but it works and thus far i havent seen anything break

or maybe this is just me being an idiot but i hope this helps.

Hello!
Thanks a lot for the issue report, I'll try to publish a release when I get some free time


Remove any L1 collection logic on collection route

The more complex data fetching page layout can be simplified as no longer displaying L1 assets
Some L1 components are used by the Realms bridge in the account route and could be moved there as per #260

Hi @RedBeardEth , Can I be assigned this?


a small typo and fix

I compiled from source and run a simple test but failed at this line https://github.com/Dao-AILab/flash-attention/blob/0dfb28174333d9eefb7c1dd4292690a8458d1e89/flash_attn/flash_attn_interface.py#L853
with the following error: unboundLocalError: cannot access local variable 'out' where it is not associated with a value
I believe it is caused by the wrong ident of this line
https://github.com/Dao-AILab/flash-attention/blob/0dfb28174333d9eefb7c1dd4292690a8458d1e89/flash_attn/flash_attn_interface.py#L852
we should move  this line out of  if block.

I see, thanks for catching it. Can you send a PR?

Could you please merge this PR ASAP to unblock? Thank you very much!


Handle quotes in command-line options

Added support for quotes around file names from command line.

Hi @SetTrend, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@SetTrend, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

For future references, please file an issue first.

Work here shouldn't be done on the command line parser because the command line parser expects all escaping to be done by the shell. So work here should be restricted to the Jakefile.
As an aside, why do you need to do this exactly? Apart from tests, we usually don't accept new files into the code base.

I'm going to close this in the interest of maintainability. Can you refile with no new .d.ts files and keeping things restricted to the Jakefile?

@DanielRosenwasser :
Please go ahead. You are right. I now realize that my changes didn't solve the problem I was trying to solve.
This was my first try of committing to TypeScript today. I learned a number of new insights which I haven't been aware of before. I committed too fast. I'm very sorry for that.
I'll re-create my fork and start over again.

Actually, I'm hunting down the reason for jake tests failing, while the same command, when run directly through TSC, succeeds:

Trying to get jake tests to run successfully I saw the above jake tests errors and assumed it was caused by TSC because they are TSC errors. I then created a pull request to go through the full workflow and see what happens. I did this too early, without even making sure that jake tests runs successfully on my own machine.
I just returned to my desk now and I just noticed that the original TSC command doesn't fail, apparently even without my changes, while jake tests fails. I'll have a look at it again ...


Get Keyvault Password Value

Describe the bug
During the ABS hand-off scenario, it is important that Composer capture the app password so that connections to emulator will work.

This is resolved by this PR #6471


Add horizontal menu and RTL layout

Fix issue #23

[x] Horizontal Layout
[x] Three-level submenu in horizontal-layout
[x] RTL Layout

Solved #23


Sometimes it's important to check for socket writeability before trying to write

I recently discovered that Linux/OS X provide an important API (TCP_NOTSENT_LOWAT) that lets applications avoid queuing up excessive data inside the kernel's socket send buffers. (The socket send buffers are generally too big, for various reasons.) Unfortunately, it turns out that this API works by controlling when a socket is marked writeable by select and friends, but does not affect whether a send call will succeed, so while you might think these are the same thing they actually aren't. [Edit: it turns out that this description  is actually incorrect on Linux, though probably true on macOS -- see] I initially filed a bug on curio about this because curio was assuming they were the same, so I won't repeat all the details: https://github.com/dabeaz/curio/issues/83
@dabeaz points out that asyncio seems to make the same invalid optimization, so filing a bug here too.

On further discussion (see the curio issue), it sounds like the tentative conclusion is:

There should be some way to specifically wait for a socket / StreamWriter to become writeable. (rationale: https://github.com/dabeaz/curio/issues/83#issuecomment-254103790)
For bonus points, it actually probably makes sense to enable TCP_NOTSENT_LOWAT on TCP sockets by default to get better buffering behavior.

At the lowest level in asyncio (i.e. if you have a socket) if you just
start sending, loop.sock_sendall() you will indeed be hit by this if the
optimization misfires. But an app can work around this using
loop.add_writer().
At the next level you have a Protocol/Transport pair, which has a
synchronous write() method that contains this optimization. That's not so
easy to work around at the app side, but there is a Protocol API that could
be used for this: pause_writing()/resume_writing(). We can probably change
the default transport implementation so that it uses these more
aggressively, without API changes.
asyncio streams are built on top of Protocol/Transport pairs, so at that
level we should be able to benefit from whatever we do for the previous
level.
@glyph has this reached Twisted yet?
PS Jim Gettys has been complaining about this for years. Glad something's
finally being done about it. And @njsmith, thanks for the clear
explanations!

I guess this is trying to address the buffer bloat problem?...

@gjcarneiro: bufferbloat is a many-headed hydra, but yeah, this is about bufferbloat in the context of per-socket send buffers specifically. The discussion thread on the curio issue has lots more details.

@glyph has this reached Twisted yet?

Not TCP_NOTSENT_LOWAT, no.  I'm sort of curious how our producer/consumer API interacts with this detail; I have a feeling it'll behave correctly, but I'm not entirely sure.
However, in the process of investigating this, I learned that we apparently removed the eager-write optimization many years ago:
https://github.com/twisted/twisted/commit/c75d1eb93c914f1f95567a76e1ba6c0166a7eee3
Digging into the history and viewing some of the discussion around that time, it seems that we were aware that it punished us pretty brutally on certain micro-benchmarks, but there's no realistic benchmark we could find where it impacts performance significantly.  @dabeaz points out over on the other ticket that it's a massive performance penalty to an echo-server benchmark, and that's true; however, echo is not a realistic application.
If you want to do anything interesting you need to talk to at least one other back-end service, which means that you need to carefully manage the relationship between two transports, which means you need a producer/consumer hookup.  Once you have that, you can't really get the meat of the optimization that eager-writes give you, which is the ability to avoid the extra select/epoll/kqueue(etc) syscall between recv and send, since you need to go back to the main loop to see if it's time to read again between each packet anyway.
It also does punish the writer on benchmarks where you are synthesizing data on the CPU rather than getting it or processing it from a different remote source, but /dev/urandom as a service also has pretty limited utility.
That said, I don't think Twisted is a great model to look towards for good support for tunables; tuning has historically been a weak point for us, because users who have significant performance demands almost always end up fixing them by making scaling up and down easier rather than optimizing throughput.  Also, the only application where this sort of tuning tends to make any difference is something that is just shuttling around huge volumes of data without really processing it, and if you're doing that you're more likely to use HAProxy or something.
That said, I really appreciate learning about this nuance of send on linux.  Hopefully at some point in the coming year we're going to do an overhaul of how we deal with tunable transport parameters (mostly focused on the more-portable SO_SENDBUF and SO_RECVBUF than this platform-specific detail) and it'll be good to keep it in mind for that.

I should note that I have an interest in adding support for TCP_NOTSENT_LOWAT into Twisted because it's highly-valuable for HTTP/2, where it's extremely valuable to keep send buffers small if possible to prevent control frames getting blocked behind buffered stream data. That means that support for APIs of that kind is likely to want to be something asyncio provides as well.
However, I disagree with @njsmith's assertion that asyncio just wants to start using it by default. In particular, for bulk unframed data transfers where throughput is more important than reactivity, applications will want to avoid spinning up the Python event loop wherever possible: for that reason, large writes are ideal and using TCP_NOTSENT_LOWAT with a bad value will have nasty negative performance impacts. The biggest case of this is for protocols like FTP and HTTP/1.1, particularly when sendfile is not available to the application, where we want to free the event loop up to do other things rather than repeatedly send smallish writes into the kernel.
In the worst-case of a 100% CPU-utilisation event loop, aggressively low values of TCP_NOTSENT_LOWAT can lead to pauses in data transfer because the event loop isn't able to respond to the POLLOUT event before the kernel send buffer empties entirely.
It is much better for asyncio to expose this kind of tuneable rather than opt-into it by default. Let application developers decide what the performance characteristics of their protocols should be.

Ah, but that can be handled by the library too. On OS X, the splitting of
large writes isn't an issue at all, since TCP_NOTSENT_LOWAT only affects
select-and-friends, not send-and-friends. And in Linux, you can achieve the
same effect by having your send routine do: (1) turn off TCP_NOTSENT_LOWAT,
(2) call send, (3) turn it on again. The basic intuition here is that you
want to let the send buffer drain before signaling writeability to avoid
standing buffers, but once the application has committed to sending a large
chunk of data, you want to hand that off to the kernel as quickly as
possible, even if that does temporarily create a large buffer.
.
I agree that the actual TCP_NOTSENT_LOWAT value should be tuneable, and
that this is a somewhat experimental proposal. But theoretically at least
it seems like there are some pretty compelling arguments that the best
default value for TCP_NOTSENT_LOWAT is smaller than the "infinity" we
currently default to.
On Nov 15, 2016 04:44, "Cory Benfield"<EMAIL_ADDRESS>wrote:

I should note that I have an interest in adding support for
TCP_NOTSENT_LOWAT into Twisted because it's highly-valuable for HTTP/2,
where it's extremely valuable to keep send buffers small if possible to
prevent control frames getting blocked behind buffered stream data. That
means that support for APIs of that kind is likely to want to be something
asyncio provides as well.
However, I disagree with @njsmith https://github.com/njsmith's
assertion that asyncio just wants to start using it by default. In
particular, for bulk unframed data transfers where throughput is more
important than reactivity, applications will want to avoid spinning up the
Python event loop wherever possible: for that reason, large writes are
ideal and using TCP_NOTSENT_LOWAT with a bad value will have nasty negative
performance impacts. The biggest case of this is for protocols like FTP and
HTTP/1.1, particularly when sendfile is not available to the application,
where we want to free the event loop up to do other things rather than
repeatedly send smallish writes into the kernel.
In the worst-case of a 100% CPU-utilisation event loop, aggressively low
values of TCP_NOTSENT_LOWAT can lead to pauses in data transfer because the
event loop isn't able to respond to the POLLOUT event before the kernel
send buffer empties entirely.
It is much better for asyncio to expose this kind of tuneable rather than
opt-into it by default. Let application developers decide what the
performance characteristics of their protocols should be.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/python/asyncio/issues/446#issuecomment-260631464, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAlOaH3KMPWd80cI2CB8X2cdsddhk99Oks5q-akDgaJpZM4KX5Ye
.


[doc] Deploying on Google Cloud

This pull requests adds some notes on CORS settings for Google Cloud, and some reference material for deploying wagtail on App Engine and Cloud Run.

Fantastic, thank you @glasnt!


added support to lookup security group for fw rules

Adds support for dynamically fetching security group path based on name for firewall rules

It's a good idea to open an issue first for discussion.

[X] Tests pass
[ ] Appropriate changes to README are included in PR

This is a pretty awesome first step. However, with this approach we are losing the capability to directly apply 1) an inidividual IP address (format xxx.xxx.xxx.xxx) in the destination_group and 2) a range of IPs (format xxx.xxx.xxx.xxx-yyy.yyy.yyy.yyy).
The input to destination_group needs to be a valid IP, Range, CIDR, or Group Path.

:shipit:


about hesai timestamp parser

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):

should keep 'timestamp' stay same? or '-=' ?
这里不应该'-='吧,是否存在问题

您好，-=是没有问题的。
Driver中的用是机械式的lidar。Lidar扫描一圈之后有多个block，把所有block数据打包，然后打上一个时间戳，即最新时间。
所以拿到的时间是最新的时间，需要知道点在哪个block、点由40线中的哪个线的激光头发射得到，从而得到时间差。通过最新时间减去时间差，就得到了当前点的时间戳。

用最新时间减去时间差这个是没问题的,但是这里使用的是"-=",每次操作后就不是最新时间了,不应该保持最新时间不变吗,然后再减去时间差

我们咨询了lidar公司的人，这个-=是没有问题的。
某通道的时间戳等于点云包的绝对时间戳减去block offset，再减去通道offset。激光器按次序发光，所有block的激光发完之后，再把数据汇总打包，初始时间是打包时间。

如果是120ms，你们的hesai激光雷达帧率是多少？

我们用的是hesai40p激光雷达,10hz

你们用的hesai40p、10hz，但是用"-="计算得到的一帧数据的时间差是120ms，修改了这块代码之后得到时间差是100ms？

是的,我们当时是这样做的,但不是完全确定是不是由这一块的原因导致的

那我建议你们和hesai人员沟通下，驱动的代码是hesai提供的。

好的,谢谢

好的，如果您有其他问题就随时开一个issue。

好的,非常感谢你的回答

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):
 should keep 'timestamp' stay same? or '-=' ? 这里不应该'-='吧,是否存在问题

您好，不好意思，有些小事需要麻烦你哈。我现在也需要对我的小车更换禾赛的激光雷达，是直接把硬件换上就可以了吗？还是哪里需要做一些额外的操作？

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):
 should keep 'timestamp' stay same? or '-=' ? 这里不应该'-='吧,是否存在问题

您好，不好意思，有些小事需要麻烦你哈。我现在也需要对我的小车更换禾赛的激光雷达，是直接把硬件换上就可以了吗？还是哪里需要做一些额外的操作？

你得保证有对应激光雷达的驱动代码

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04):
Apollo installed from (source or binary):
Apollo version (3.5, 5.0, 5.5, 6.0):
Output of apollo.sh config if on master branch:

Steps to reproduce the issue:

Please use bullet points and include as much details as possible:

Supporting materials (screenshots, command lines, code/script snippets):
 should keep 'timestamp' stay same? or '-=' ? 这里不应该'-='吧,是否存在问题

您好，不好意思，有些小事需要麻烦你哈。我现在也需要对我的小车更换禾赛的激光雷达，是直接把硬件换上就可以了吗？还是哪里需要做一些额外的操作？

你得保证有对应激光雷达的驱动代码，首先保证通信没有问题，然后运行对应的驱动程序

这个我是有的，但应该在哪里替换呢


Update examples.md for rust cargo

Update the example for rust so that the cache key actually works as intended

See #325 for some more elaborate examples that avoid caching redundant data and limit content for inexact restoration. Basically, you only need ~/.cargo/registry/index to be treated this way.


Using south fail

python manage.py syncdb --migrate
Syncing...
Creating tables ...
Creating table auth_permission
Creating table auth_group_permissions
Creating table auth_group
Creating table auth_user_user_permissions
Creating table auth_user_groups
Creating table auth_user
Creating table django_content_type
Creating table django_session
Creating table django_site
Creating table south_migrationhistory

You just installed Django's auth system, which means you don't have any superusers defined.
Would you like to create one now? (yes/no): no
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Migrating...
Running migrations for djangopypi:
 - Migrating forwards to 0005_allow_null_distribution_uploader.
 > djangopypi:0001_initial
 > djangopypi:0002_refactoring
~/hg/chishop/apps/local/lib/python2.7/site-packages/django/db/models/fields/__init__.py:808: RuntimeWarning: DateTimeField received a naive datetime (1970-01-01 00:00:00) while time zone support is active.
  RuntimeWarning)
FATAL ERROR - The following SQL query failed: ALTER TABLE `djangopypi_release` ADD COLUMN `package_id` varchar(255) NOT NULL DEFAULT None;
The error was: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'None' at line 1")
 ! Error found during real run of migration! Aborting.

 ! Since you have a database that does not support running
 ! schema-altering statements in transactions, we have had
 ! to leave it in an interim state between migrations.

! You *might* be able to recover with:   = CREATE TABLE `djangopypi_project` (`updated` datetime NOT NULL, `description` longtext NOT NULL, `metadata_version` varchar(64) NOT NULL DEFAULT '1.0', `owner_id` integer NOT NULL, `summary` longtext NOT NULL, `name` varchar(255) NOT NULL UNIQUE, `license` longtext NOT NULL, `author` varchar(128) NOT NULL, `home_page` varchar(200) NULL, `download_url` varchar(200) NULL, `id` integer AUTO_INCREMENT NOT NULL PRIMARY KEY, `author_email` varchar(255) NOT NULL); []
   = CREATE TABLE `djangopypi_project_classifiers` (`id` integer AUTO_INCREMENT NOT NULL PRIMARY KEY, `project_id` integer NOT NULL, `classifier_id` integer NOT NULL); []
   = ALTER TABLE `djangopypi_project_classifiers` ADD CONSTRAINT `djangopypi_project_classifiers_project_id_cff2b4571a6cca1_uniq` UNIQUE (`project_id`, `classifier_id`) []
   = DROP TABLE `djangopypi_distribution` CASCADE; []
   = DROP TABLE `djangopypi_review` CASCADE; []
   = DROP TABLE `djangopypi_package` CASCADE; []
   = DROP TABLE `djangopypi_package_owners` CASCADE; []
   = DROP TABLE `djangopypi_package_maintainers` CASCADE; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `md5_digest` varchar(255) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `filetype` varchar(255) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `upload_time` datetime NOT NULL DEFAULT '1969-12-31 23:00:00'; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `pyversion` varchar(255) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `project_id` integer NOT NULL DEFAULT None; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `platform` varchar(255) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `signature` varchar(128) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` ADD COLUMN `distribution` varchar(100) NOT NULL DEFAULT ''; []
   - no dry run output for alter_column() due to dynamic DDL, sorry
   - no dry run output for delete_foreign_key() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` DROP COLUMN `package_id` CASCADE; []
   - no dry run output for delete_foreign_key() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` DROP COLUMN `metadata_version` CASCADE; []
   - no dry run output for delete_foreign_key() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` DROP COLUMN `package_info` CASCADE; []
   - no dry run output for delete_foreign_key() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` DROP COLUMN `hidden` CASCADE; []
   - no dry run output for delete_foreign_key() due to dynamic DDL, sorry
   = ALTER TABLE `djangopypi_release` DROP COLUMN `created` CASCADE; []
   = ALTER TABLE `djangopypi_release` ADD CONSTRAINT `djangopypi_release_project_id_3b8fc244160e211b_uniq` UNIQUE (`project_id`, `platform`, `distribution`, `version`, `pyversion`) []
   - no dry run output for delete_unique_column() due to dynamic DDL, sorry

 ! The South developers regret this has happened, and would
 ! like to gently persuade you to consider a slightly
 ! easier-to-deal-with DBMS (one that supports DDL transactions)
 ! NOTE: The error which caused the migration to fail is further up.
Error in migration: djangopypi:0002_refactoring
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 443, in execute_from_command_line
    utility.execute()
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/base.py", line 371, in handle
    return self.handle_noargs(**options)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/management/commands/syncdb.py", line 99, in handle_noargs
    management.call_command('migrate', **options)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 150, in call_command
    return klass.execute(*args, **defaults)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/management/commands/migrate.py", line 107, in handle
    ignore_ghosts = ignore_ghosts,
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/__init__.py", line 219, in migrate_app
    success = migrator.migrate_many(target, workplan, database)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 235, in migrate_many
    result = migrator.__class__.migrate_many(migrator, target, migrations, database)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 310, in migrate_many
    result = self.migrate(migration, database)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 133, in migrate
    result = self.run(migration)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 107, in run
    return self.run_migration(migration)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 81, in run_migration
    migration_function()
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/migration/migrators.py", line 57, in <lambda>
    return (lambda: direction(orm))
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/djangopypi/migrations/0002_refactoring.py", line 96, in forwards
    db.add_column('djangopypi_release', 'package', self.gf('django.db.models.fields.related.ForeignKey')(default='', related_name='releases', to=orm['djangopypi.Package']), keep_default=False)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/db/generic.py", line 46, in _cache_clear
    return func(self, table, *args, **opts)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/db/generic.py", line 408, in add_column
    self.execute(sql)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/south/db/generic.py", line 264, in execute
    cursor.execute(sql, params)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/db/backends/util.py", line 40, in execute
    return self.cursor.execute(sql, params)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/django/db/backends/mysql/base.py", line 114, in execute
    return self.cursor.execute(query, args)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/MySQLdb/cursors.py", line 174, in execute
    self.errorhandler(self, exc, value)
  File "~/hg/chishop/apps/local/lib/python2.7/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue
django.db.utils.DatabaseError: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'None' at line 1")

I to encountered the similar error with south


[BUG] When sending a heartbeat, throw KeeperException$NoNodeException

Describe the bug
problem in OSUtils::getHost,
    try {
      return InetAddress.getLocalHost().getHostAddress();
    } catch (UnknownHostException e) {
      logger.error(e.getMessage(),e);
    }
    return null;

sometimes InetAddress.getLocalHost().getHostAddress(); return <IP_ADDRESS>, sometimes return other address, when using other address sending a heartbeat to zookeeper, throw KeeperException$NoNodeException.

问题在 OSUtils::getHost 这个方法中, InetAddress.getLocalHost().getHostAddress(); 这个方法有时候返回的是 <IP_ADDRESS>, 但是有时候会返回其他IP. 当以其他IP发送心跳时候就会抛 KeeperException$NoNodeException
To Reproduce
i dont kwon how to reproduce, but it really happened on my mac,  i just start application, after a while, application throw KeeperException$NoNodeException.  On debug mode, i find problem in OSUtils::getHost

不太清楚如何在其他电脑上复现, 但确实发生在我的Mac上, 启动应用后过一会就会抛 KeeperException$NoNodeException. 在Debug的时候我定位到问题出在 OSUtils::getHost
Which version of Dolphin Scheduler:
<version>1.2.1-SNAPSHOT</version>
Context:
my hosts file:
##
# Host Database
#
# localhost is used to configure the loopback interface
# when the system is booting.  Do not change this entry.
##
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost
# BEGIN section for OpenVPN Client SSL sites
<IP_ADDRESS>	client.openvpn.net
# END section for OpenVPN Client SSL sites

Describe the bug
problem in OSUtils::getHost,
    try {
      return InetAddress.getLocalHost().getHostAddress();
    } catch (UnknownHostException e) {
      logger.error(e.getMessage(),e);
    }
    return null;

sometimes InetAddress.getLocalHost().getHostAddress(); return <IP_ADDRESS>, sometimes return other address, when using other address sending a heartbeat to zookeeper, throw KeeperException$NoNodeException.
问题在 OSUtils::getHost 这个方法中, InetAddress.getLocalHost().getHostAddress(); 这个方法有时候返回的是 <IP_ADDRESS>, 但是有时候会返回其他IP. 当以其他IP发送心跳时候就会抛 KeeperException$NoNodeException
To Reproduce
i dont kwon how to reproduce, but it really happened on my mac, i just start application, after a while, application throw KeeperException$NoNodeException. On debug mode, i find problem in OSUtils::getHost
不太清楚如何在其他电脑上复现, 但确实发生在我的Mac上, 启动应用后过一会就会抛 KeeperException$NoNodeException. 在Debug的时候我定位到问题出在 OSUtils::getHost
Which version of Dolphin Scheduler:
<version>1.2.1-SNAPSHOT</version>
Context:
my hosts file:
##
# Host Database
#
# localhost is used to configure the loopback interface
# when the system is booting.  Do not change this entry.
##
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost
# BEGIN section for OpenVPN Client SSL sites
<IP_ADDRESS>	client.openvpn.net
# END section for OpenVPN Client SSL sites

Hello, about the other ip you said, is this ip configured in your host file?

Describe the bug
problem in OSUtils::getHost,
    try {
      return InetAddress.getLocalHost().getHostAddress();
    } catch (UnknownHostException e) {
      logger.error(e.getMessage(),e);
    }
    return null;

sometimes InetAddress.getLocalHost().getHostAddress(); return <IP_ADDRESS>, sometimes return other address, when using other address sending a heartbeat to zookeeper, throw KeeperException$NoNodeException.
问题在 OSUtils::getHost 这个方法中, InetAddress.getLocalHost().getHostAddress(); 这个方法有时候返回的是 <IP_ADDRESS>, 但是有时候会返回其他IP. 当以其他IP发送心跳时候就会抛 KeeperException$NoNodeException
To Reproduce
i dont kwon how to reproduce, but it really happened on my mac, i just start application, after a while, application throw KeeperException$NoNodeException. On debug mode, i find problem in OSUtils::getHost
不太清楚如何在其他电脑上复现, 但确实发生在我的Mac上, 启动应用后过一会就会抛 KeeperException$NoNodeException. 在Debug的时候我定位到问题出在 OSUtils::getHost
Which version of Dolphin Scheduler:
<version>1.2.1-SNAPSHOT</version>
Context:
my hosts file:
##
# Host Database
#
# localhost is used to configure the loopback interface
# when the system is booting.  Do not change this entry.
##
<IP_ADDRESS>	localhost
<IP_ADDRESS>	broadcasthost
::1             localhost
# BEGIN section for OpenVPN Client SSL sites
<IP_ADDRESS>	client.openvpn.net
# END section for OpenVPN Client SSL sites

Can you provide the other IP you said?
InetAddress.getLocalHost().getHostAddress(); actually is not a system independent reliable method, and it will encounter problems in multi network environment.
The system will register the worker and master nodes in zk, and if your network environment change, maybe it will cause the KeeperException$NoNodeException.

The reason for the IP change is the InetAddress.getLocalHost().getHostAddress() will change when your InetAddress.addressCache.cache.xxx.value.addresses's first value change, and the result of InetAddress.getLocalHost().getHostAddress() equals your InetAddress.addressCache.cache.xxx.value.addresses's first value.
The result when I connect the wifi:

The result when I turn off the network:

So when it returns <IP_ADDRESS> not <IP_ADDRESS>, it maybe your network env changed.
Can you show the results of ifconfig on the command line of your computer and the result of the picture above when your network env changed?
Although there is little possibility of IP changes in the production environment, but I think we should compare the results of zk record and the result of InetAddress.getLocalHost().getHostAddress() to determine the node?
@dailidong Can you help to confirm this question? Thx.

This is an ifconfig result without desensitization. I hope it helps.
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 16384
	options=1203<RXCSUM,TXCSUM,TXSTATUS,SW_TIMESTAMP>
	inet <IP_ADDRESS> netmask 0xff000000
	inet6 ::1 prefixlen 128
	inet6 fe80::1%lo0 prefixlen 64 scopeid 0x1
	inet <IP_ADDRESS> netmask 0xff000000
	nd6 options=201<PERFORMNUD,DAD>
gif0: flags=8010<POINTOPOINT,MULTICAST> mtu 1280
stf0: flags=0<> mtu 1280
en0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	options=400<CHANNEL_IO>
	ether a4:5e:60:d7:89:bd
	inet6 fe80::106c:8a72:4c45:2478%en0 prefixlen 64 secured scopeid 0x4
	inet <IP_ADDRESS> netmask 0xfffffc00 broadcast <IP_ADDRESS>
	nd6 options=201<PERFORMNUD,DAD>
	media: autoselect
	status: active
p2p0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 2304
	options=400<CHANNEL_IO>
	ether 06:5e:60:d7:89:bd
	media: autoselect
	status: inactive
awdl0: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1484
	options=400<CHANNEL_IO>
	ether 4a:db:8e:c7:2d:11
	inet6 fe80::48db:8eff:fec7:2d11%awdl0 prefixlen 64 scopeid 0x6
	nd6 options=201<PERFORMNUD,DAD>
	media: autoselect
	status: active
llw0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	options=400<CHANNEL_IO>
	ether 4a:db:8e:c7:2d:11
	inet6 fe80::48db:8eff:fec7:2d11%llw0 prefixlen 64 scopeid 0x7
	nd6 options=201<PERFORMNUD,DAD>
	media: autoselect
	status: active
en1: flags=8963<UP,BROADCAST,SMART,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500
	options=460<TSO4,TSO6,CHANNEL_IO>
	ether 82:13:05:e4:90:c0
	media: autoselect <full-duplex>
	status: inactive
en2: flags=8963<UP,BROADCAST,SMART,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500
	options=460<TSO4,TSO6,CHANNEL_IO>
	ether 82:13:05:e4:90:c1
	media: autoselect <full-duplex>
	status: inactive
bridge0: flags=8863<UP,BROADCAST,SMART,RUNNING,SIMPLEX,MULTICAST> mtu 1500
	options=63<RXCSUM,TXCSUM,TSO4,TSO6>
	ether 82:13:05:e4:90:c0
	Configuration:
		id 0:0:0:0:0:0 priority 0 hellotime 0 fwddelay 0
		maxage 0 holdcnt 0 proto stp maxaddr 100 timeout 1200
		root id 0:0:0:0:0:0 priority 0 ifcost 0 port 0
		ipfilter disabled flags 0x0
	member: en1 flags=3<LEARNING,DISCOVER>
	        ifmaxaddr 0 port 8 priority 0 path cost 0
	member: en2 flags=3<LEARNING,DISCOVER>
	        ifmaxaddr 0 port 9 priority 0 path cost 0
	nd6 options=201<PERFORMNUD,DAD>
	media: <unknown type>
	status: inactive
utun0: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1380
	inet6 fe80::ee58:2e5d:c91c:f75%utun0 prefixlen 64 scopeid 0xb
	nd6 options=201<PERFORMNUD,DAD>
utun1: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 2000
	inet6 fe80::a49:c23c:8187:be02%utun1 prefixlen 64 scopeid 0xc
	nd6 options=201<PERFORMNUD,DAD>
utun2: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1380
	inet6 fe80::5628:2952:d245:4c77%utun2 prefixlen 64 scopeid 0xd
	nd6 options=201<PERFORMNUD,DAD>
utun3: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1380
	inet6 fe80::808:197:eabb:939%utun3 prefixlen 64 scopeid 0xe
	nd6 options=201<PERFORMNUD,DAD>

The original method may return a different IP during operation.fix to #2924.


Installation fail since port is not available

Image not available locally, pulling mochoa/pgadmin4-docker-extension:8.1.0...
Extracting metadata and files for the extension "mochoa/pgadmin4-docker-extension:8.1.0"
Installing service in Desktop VM...
Setting additional compose attributes
Installing Desktop extension UI for tab "PGAdmin4"...
Extension UI tab "PGAdmin4" added.
Starting service in Desktop VM......
failed when running compose up for extension mochoa/pgadmin4-docker-extension:8.1.0: executing '/Applications/Docker.app/Contents/Resources/bin/docker --context desktop-linux compose -p mochoa_pgadmin4-docker-extension-desktop-extension -f extensions/mochoa_pgadmin4-docker-extension/vm/docker-compose.yml up -d' : exit status 1:
 Network mochoa_pgadmin4-docker-extension-desktop-extension_default  Creating
 Network mochoa_pgadmin4-docker-extension-desktop-extension_default  Created
 Volume "mochoa_pgadmin4-docker-extension-desktop-extension_pgadmin_data"  Creating
 Volume "mochoa_pgadmin4-docker-extension-desktop-extension_pgadmin_data"  Created
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Creating
 Container pgadmin4_embedded_dd_vm  Creating
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Created
 Container pgadmin4_embedded_dd_vm  Created
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Starting
 Container pgadmin4_embedded_dd_vm  Starting
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Started
Error response from daemon: Ports are not available: exposing port TCP <IP_ADDRESS>:59080 -> <IP_ADDRESS>:0: listen tcp <IP_ADDRESS>:59080: bind: address already in use

executing '/Applications/Docker.app/Contents/Resources/bin/docker --context desktop-linux compose -p mochoa_pgadmin4-docker-extension-desktop-extension -f extensions/mochoa_pgadmin4-docker-extension/vm/docker-compose.yml up -d' : exit status 1:
 Network mochoa_pgadmin4-docker-extension-desktop-extension_default  Creating
 Network mochoa_pgadmin4-docker-extension-desktop-extension_default  Created
 Volume "mochoa_pgadmin4-docker-extension-desktop-extension_pgadmin_data"  Creating
 Volume "mochoa_pgadmin4-docker-extension-desktop-extension_pgadmin_data"  Created
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Creating
 Container pgadmin4_embedded_dd_vm  Creating
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Created
 Container pgadmin4_embedded_dd_vm  Created
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Starting
 Container pgadmin4_embedded_dd_vm  Starting
 Container mochoa_pgadmin4-docker-extension-desktop-extension-service  Started
Error response from daemon: Ports are not available: exposing port TCP <IP_ADDRESS>:59080 -> <IP_ADDRESS>:0: listen tcp <IP_ADDRESS>:59080: bind: address already in use

Removing extension mochoa/pgadmin4-docker-extension:8.1.0...
Removing extension containers...
Extension containers removed
VM service socket forwarding stopped
Extension UI tab PGAdmin4 removed
Extension image mochoa/pgadmin4-docker-extension:8.1.0 removed
Extension "Open Source management tool for PostgreSQL" removed

Can you use the next available port? I am not sure if it is possible.
Or any configuration before starting?

Hi:
Are you using Docker Desktop for Windows?
Other users fix that by rebooting Windows and starting again Docker Desktop to get this free port.
Unfortunately to change the port number is necessary to rebuild the complete image.
Marcelo.

Hi @marcelo-ochoa
Indeed, I am on macOS, and restarting the OS solves it as well.
I am not an expert in docker configuration and don't know if it's possible.
But it will be really helpful if it retries the next available port in case of port is in use.
Thanks for maintaining this useful extension!
Mohan


fixes some bugs in Peer Review activity upon switching orientation

Description (required)
Fixes #4143
What changes did you make and why?
Issue is due to calling   methods of ReviewImageFragment from ReviewActivity is wrong
So i add the other way to call the ReviewImageFragment methods  from ReviewActivity
it solve the issue
Tests performed (required)
Android:Redmi y3;

Codecov Report

Merging #4176 (c16a42e) into master (8c3c9cf) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3c9cf...c16a42e. Read the comment docs.

Codecov Report

Merging #4176 (c16a42e) into master (8c3c9cf) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3c9cf...c16a42e. Read the comment docs.

@nicolas-raoul  review my PR

@nicolas-raoul  review my PR

@misaochan @madhurgupta10 review my PR

@misaochan @madhurgupta10 review my PR

Hey @Prince-kushwaha , please add screen cast to display this changes solve the issue.

Hey @Prince-kushwaha , please add screen cast to display this changes solve the issue.

@neslihanturan i add screen shot

@neslihanturan i add screen shot

@nicolas-raoul @neslihanturan please review my this PR


Improve rendering of tree row

Can the rendering of natural=tree_row be made wider or be shown as a dashed line (like barrier=wall)? It's difficult to distinguish at the edge of natural=wood areas at present, especially when the wood is mapped as a multipolygon (same line colour and same line thickness).

good suggestion 👍


[Website] Feature card – large component

For the v2 updates, we need added guidance for feature card – large which guides adopters through the changes to the component.

[ ] Clear guidance around truncation: body copy only if it is too close to the icon.
[ ] Heading can include product names and is not truncated.
[ ] Body copy is secondary, cannot include product names
[ ] If there’s too much content, use a feature section or content component

Duplicate


Rename and Reorganize "cmake:" commands to be more consistent and easier to remember/spot in GUI.

Brief Issue Summary
The command display names seem inconsistent and difficult to grok. For instance, it's hard to see "cmake: Set the current build variant."
Expected:
All command names should be short, sweet, visually grokkable immediately, and organized as logically as possible. Preferably, commonly accessed functions should be at the top of the list, so alphabetically organized smartly as well. For instance,
cmake: set the current build variant
is quite difficult to spot. It requires scrolling already, then careful reading of an almost sentence-long amount of information.
cmake: Set Variant
and similarly for other options like that would vastly improve the readability and mental organization.
Thanks!

If you or anyone else has any specific suggestions for command renaming, would you be able to list them out here, or better yet, open a PR with your suggestions and we can discuss them?  All command names live in package.json.

How can we contribute with localization?

@MathiasMagnus we're working on setting up a process for this.  There are some files our localization team uses to track all of their work and we don't commit those files to this repo, so it's not super straightforward yet.
We're pushing for the process to be for you to simply open a PR with the suggested changes. After that we'll do some work behind the scenes and then replace your PR with an automated PR that has the changes and is synced with our internal system.

Brief Issue Summary
The command display names seem inconsistent and difficult to grok. For instance, it's hard to see "cmake: Set the current build variant."
Expected:
All command names should be short, sweet, visually grokkable immediately, and organized as logically as possible. Preferably, commonly accessed functions should be at the top of the list, so alphabetically organized smartly as well. For instance,
cmake: set the current build variant
is quite difficult to spot. It requires scrolling already, then careful reading of an almost sentence-long amount of information.
cmake: Set Variant
and similarly for other options like that would vastly improve the readability and mental organization.
Thanks!
Set variant ? What variant? Dog variant?  Cat variant? Compiler variant?

This issue has been addressed in CMake Tools 1.2.0 which is available in the VS Code Marketplace or on the Releases Page
Because the publisher id has changed, VS Code does not automatically upgrade you yet. The Marketplace team will enable this in the next few days.  If you want to install 1.2.0 now, please make sure you uninstall any earlier versions of CMake Tools manually to avoid any conflicts.


add --no-link-dead-code option to coverage and coveralls

Looking for a solution to #43. Not quite sure how to test this. Would appreciate some help!

Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon.

Thanks for the patch! I'm not quite sure this is the right approach: I believe the --bin argument only works with the names of actual binaries (i.e. src/main.rs or src/bin/*.rs), not external tests (i.e. tests/*.rs) nor the #[test]s in a library. Additionally, I think this should be on by default (I can't think of any reason why someone would want wildly wrong coverage info), but this will need careful handling with respect to compiler versions.
I suspect the best way to handle this would be actually changing cargo to support this, and having cargo test (i.e. the test profile) pass this option by default.
Thanks again!

:umbrella: The latest upstream changes (presumably #45) made this pull request unmergeable. Please resolve the merge conflicts.

Now that RUSTFLAGS has landed in the latest cargo, I figured I'd give this another shot. The flag is now opt-out.

Changes Unknown when pulling f309bcbf28d0d32aa15f17bd5871f8fa0ecd0ead on euclio:link-dead-code into ** on huonw:master**.

Attempted build with this branch here: https://travis-ci.org/Hoverbear/rust-rosetta/builds/117127010#L3956
Failed with "error: multiple input filenames"

:umbrella: The latest upstream changes (presumably d0cfb8e) made this pull request unmergeable. Please resolve the merge conflicts.

Hey @euclio, sorry that I've taken so long. I'm about to give some feedback, but if you no longer have time (or not longer have interest in helping a maintainer as slow as me :) ) I'm happy to take over.
In any case, I've just pushed a little more code that will make this easier:

it should mean travis CI passes properly
it adjusts the run function to take an env parameter for overriding the environment when running the subcommand

Thanks again for getting the ball rolling!

Huh, I realised your approach of using RUSTFLAGS is really neat: it solves two problems with one stone. It (obviously) gets the -C link-dead-code argument through to rustc, and it is only interpreted by sufficient new cargo's so the argument can never actually get passed through to a rustc that doesn't support that argument (so travis-cargo doesn't have to worry about detecting when the compiler supports it).
Very nice!

I didn't hear from you for a while (not as long as you didn't hear from me, but I had some time, so I wanted to make progress!) so I built on your patch to fix it/. I agree that it's tricky to test, so I've just resorted to checking manually, it seems to work: https://coveralls.io/jobs/14197011 (that was all 100% previously).
Thanks again!

(Published in 0.1.15, so people will start getting much lower coverage stats now.)

Awesome, thanks for getting to this! Glad that it worked out :)


Race-condition on sandbox

When executing the sandbox at the workshop, it was possibly to:

run redeem_shield and get tx is mined
read the storage (which is not updated)
run redeem_shield on the same note and again get tx is mined (nullifier should already be spent)
wait
read storage which is now updated.
running redeem_shield now would then revert because nullifier already spend

From the user point of view, he got confirmation that both transactions made it into the rollup, but only one of the them actually got executed. The node seemed to fall behind the underlying network allowing full successful simulation even though the actual transaction would be unsuccessful. This lead to it looking like a double-spend but one tx was mined but not included in state.

Ok. I can understand how there is a race condition around the RPC Server. @LeilaWang I think this is because tx status is now read directly from the archiver isn't it? Meaning that the RPC server may not be up to date even though it reports the tx as mined. I think we will just need to add an awaitSync call on the RPC Server to force it to catch up.
@LHerskind  am I right in that the second part of your issue is the sequencer submitting a second rollup containing effectively the same transaction? That surprises me as the sequencer shouldn't start a rollup until the world state has synched the last published block and will then check the nullifiers against what is in the tree.
  protected async isBlockSynced() {
    const syncedBlocks = await Promise.all([
      this.worldState.status().then((s: WorldStateStatus) => s.syncedToL2Block),
      this.p2pClient.getStatus().then(s => s.syncedToL2Block),
    ]);
    const min = Math.min(...syncedBlocks);
    return min >= this.lastPublishedBlock;
  }

@LHerskind am I right in that the second part of your issue is the sequencer submitting a second rollup containing effectively the same transaction? That surprises me as the sequencer shouldn't start a rollup until the world state has synched the last published block and will then check the nullifiers against what is in the tree.
  protected async isBlockSynced() {
    const syncedBlocks = await Promise.all([
      this.worldState.status().then((s: WorldStateStatus) => s.syncedToL2Block),
      this.p2pClient.getStatus().then(s => s.syncedToL2Block),
    ]);
    const min = Math.min(...syncedBlocks);
    return min >= this.lastPublishedBlock;
  }

I think so yes. I don't recall when the lastPublishedBlock is updated, so it might pass that check when downloaded but not updated the state like we have seen before?

After 2 days on this and not being able to reproduce or trace down, I vote for closing it as "can't repro".

Since this was moved to done and otherwise unreproducible, I'm closing this issue.


Fix typos related to S3 in ModeShape schemas

can you please squash the 2 commits ? thanks

Squashed.


[2.1]Add support for new EC2 instance types for eks cluster

Related Kontainer-engine PR: https://github.com/rancher/kontainer-engine/pull/99
Related issue: https://github.com/rancher/rancher/issues/16639

Updated


Allow matching on partial words combined with camel case for autocompletion (Resharper style)

I'm a user of https://github.com/lukebuehler/CShell which uses AvalonEdit for code completion. I originally filed this at https://github.com/lukebuehler/CShell/issues/25 but am refiling it here.
I'd like it if code completion allowed on matching within a word combined with the camel case completion. For example if I want DateTime I could enter dt, see that there are still a lot of types that match dt via camel case completion and continue on to type dtime, which will filter the list down to just a couple choices, one of which is DateTime.
This idea is heavily based on my use of Resharper which allows this sort of query.
One approach to this would be:

The first letter of the query must match the first letter of any word in the text.
Each subsequent letter of the query must match either the next letter in the text or the first letter of the next word in the text.

This could alternately require the query to match starting at the beginning of the text by changing 1. to:

The first letter of the query must match the first letter in the text.

AvalonEdit already has some logic that makes cct match camelCaseText.
I think these kind of smart matching strategies will end up being language-dependent if done properly. AvalonEdit should expose a callback so that user code can override the built-in matching strategy.


Add a custom domain

Description
It would be nice to have a custom domain for this, something like uptime.louiswhite.me or maybe upptime.louiswhite.me to match the name of the app.

oh actually i did this one


docs: Add note about stateRoot in getBlockBy* RPCs

Description:

Documents that stateRoot value is zero

Related issue(s):
Fixes #
N/A
Refs:

https://swirldslabs.slack.com/archives/C03EHC2H8CR/p1706056921483199

Checklist

[x] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.) - N/A

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (599b147) 77.83% compared to head (9dba32c) 77.83%.

:exclamation: Current head 9dba32c differs from pull request most recent head c941fa4. Consider uploading reports for the commit c941fa4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   77.83%   77.83%
=======================================
  Files          40       40
  Lines        3090     3090
  Branches      629      629
=======================================
  Hits         2405     2405
  Misses        479      479
  Partials      206      206

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I don't think I have permissions to re-trigger the CI pipeline, and the failures don't look like they are related to the changes within this patch.


Spree Adyen Hpp payment method is not working on staging

Hello I am using Adyen-HPP payment method in my application for alipay, union pay, express pay. Its working fine at my localhost but in staging order is not tracked.
In localhost order
#<Spree::Order id: 6195, number: "R983256989", item_total: #<BigDecimal:7fa2c0308a58,'0.899E2',18(18)>, total: #<BigDecimal:7fa2c0308940,'0.899E2',18(18)>, state: "complete", adjustment_total: #<BigDecimal:7fa2c0308788,'0.0',9(18)>, user_id: 1, completed_at: "2016-02-23 05:28:41", bill_address_id: 27306, ship_address_id: 27307, payment_total: #<BigDecimal:7fa2c0303eb8,'0.0',9(18)>, shipping_method_id: nil, shipment_state: "pending", payment_state: "balance_due", email<EMAIL_ADDRESS>special_instructions: nil, created_at: "2016-02-23 05:25:30", updated_at: "2016-02-23 05:28:41", currency: "USD", last_ip_address: "<IP_ADDRESS>", created_by_id: 1, shipment_total: #<BigDecimal:7fa2c0302ea0,'0.0',9(18)>, additional_tax_total: #<BigDecimal:7fa2c0302db0,'0.0',9(18)>, promo_total: #<BigDecimal:7fa2c0302ce8,'0.0',9(18)>, channel: "spree", included_tax_total: #<BigDecimal:7fa2c0302b80,'0.0',9(18)>, item_count: 1, approver_id: nil, approved_at: nil, confirmation_delivered: true, considered_risky: false, guest_token: "QQSigCtY46f38ms1rceCzQ", locale: "en", state_lock_version: 0, cod_pay: false, cod_amount: nil>
in staging
#<Spree::Order id: 158, number: "R867042995", item_total: #<BigDecimal:7f6b302ce190,'0.299E2',18(18)>, total: #<BigDecimal:7f6b302ce0c8,'0.299E2',18(18)>, state: "payment", adjustment_total: #<BigDecimal:7f6b302cdf88,'0.0',9(18)>, user_id: 1, completed_at: nil, bill_address_id: 1232, ship_address_id: 1231, payment_total: #<BigDecimal:7f6b302cdc90,'0.0',9(18)>, shipping_method_id: nil, shipment_state: nil, payment_state: nil, email<EMAIL_ADDRESS>special_instructions: nil, created_at: "2016-02-23 05:10:23", updated_at: "2016-02-23 05:12:50", currency: "USD", last_ip_address: "<IP_ADDRESS>", created_by_id: 1, shipment_total: #<BigDecimal:7f6b302ccd18,'0.0',9(18)>, additional_tax_total: #<BigDecimal:7f6b302ccc50,'0.0',9(18)>, promo_total: #<BigDecimal:7f6b302ccb88,'0.0',9(18)>, channel: "spree", included_tax_total: #<BigDecimal:7f6b302cca48,'0.0',9(18)>, item_count: 1, approver_id: nil, approved_at: nil, confirmation_delivered: false, considered_risky: false, guest_token: "vFVPL0Z-YqauH29M4j3lPg", locale: nil, state_lock_version: 0, cod_pay: false, cod_amount: nil>
I had set result url in skin

when I check in adyen it shows like this

When I do order from localhost it redirects me to

http://localhost:3000/orders/R377021338?token=QQSigCtY46f38ms1rceCzQ.

While when I do payment with staging it redirect me to

https://skinnymint-staging.herokuapp.com/orders/thank_you/R867042995

result url which I had set in adyen is

https://skinnymint-staging.herokuapp.com/orders/thank_you_hpp

and the method is as defined as
def thank_you_hpp
    redirect_to thank_you_path(id: params[:merchantReference])
 end

logs in staging
Started POST "/adyen/notify" for <IP_ADDRESS> at 2016-02-23 05:44:37 +0000
2016-02-23T05:44:37.670234+00:00 app[web.1]: Processing by Spree::AdyenNotificationsController#notify as HTML
2016-02-23T05:44:37.670277+00:00 app[web.1]:   Parameters: {"originalReference"=>"", "reason"=>"null", "merchantAccountCode"=>"SkinnyMint", "eventCode"=>"AUTHORISATION", "operations"=>"", "success"=>"true", "paymentMethod"=>"unionpay", "currency"=>"USD", "pspReference"=>"7914562061768685", "merchantReference"=>"R867042995", "value"=>"8480", "live"=>"false", "eventDate"=>"2016-02-23T05:44:15.43Z"}
2016-02-23T05:44:37.776179+00:00 app[web.1]:   Rendered text template (0.1ms)
2016-02-23T05:44:37.776512+00:00 app[web.1]: Completed 200 OK in 106ms (Views: 1.2ms | ActiveRecord: 63.5ms)
2016-02-23T05:44:38.276500+00:00 app[web.1]: Started POST "/adyen/notify" for <IP_ADDRESS> at 2016-02-23 05:44:38 +0000
2016-02-23T05:44:38.299003+00:00 app[web.1]: Completed 200 OK in 19ms (Views: 0.6ms | ActiveRecord: 7.2ms)

2016-02-23T05:44:38.279524+00:00 app[web.1]: Processing by Spree::AdyenNotificationsController#notify as HTML
2016-02-23T05:44:38.279560+00:00 app[web.1]:   Parameters: {"originalReference"=>"", "reason"=>"null", "merchantAccountCode"=>"SkinnyMint", "eventCode"=>"AUTHORISATION", "operations"=>"", "success"=>"true", "paymentMethod"=>"unionpay", "currency"=>"USD", "pspReference"=>"7914562061768685", "merchantReference"=>"R867042995", "value"=>"8480", "live"=>"false", "eventDate"=>"2016-02-23T05:44:20.18Z"}
2016-02-23T05:44:38.298638+00:00 app[web.1]:   Rendered text template (0.0ms)
2016-02-23T05:44:41.137460+00:00 heroku[worker.1]: source=worker.1 dyno=heroku.27467940.2bf35814-c710-451d-9b81-3a9d80cc0d48 sample#load_avg_1m=0.06
2016-02-23T05:44:41.137533+00:00 heroku[worker.1]: source=worker.1 dyno=heroku.27467940.2bf35814-c710-451d-9b81-3a9d80cc0d48 sample#memory_total=183.01MB sample#memory_rss=183.00MB sample#memory_cache=0.02MB sample#memory_swap=0.00MB sample#memory_pgpgin=50842pages sample#memory_pgpgout=3991pages
2016-02-23T05:44:25+00:00 app[heroku-postgres]: source=DATABASE sample#current_transaction=2795 sample#db_size=14692116bytes sample#tables=81 sample#active-connections=4 sample#waiting-connections=0 sample#index-cache-hit-rate=0.99969 sample#table-cache-hit-rate=0.99986 sample#load-avg-1m=0.02 sample#load-avg-5m=0.02 sample#load-avg-15m=0.05 sample#read-iops=0 sample#write-iops=17.946 sample#memory-total=2050172.0kB sample#memory-free=159156kB sample#memory-cached=1635116.0kB sample#memory-postgres=22492kB
2016-02-23T05:44:10.472653+00:00 heroku[router]: at=info method=GET path="/orders/thank_you_hpp?merchantReference=R867042995&skinCode=Ht6pEehJ&shopperLocale=en_GB&paymentMethod=unionpay&authResult=AUTHORISED&pspReference=7914562061768685&merchantSig=PLo97c5V3aA6Aaav4iAtQEZ1c6c%3D" host=skinnymint-staging.herokuapp.com request_id=d12da2a1-4ec9-4f5a-ad2e-5ce149c6a2c2 fwd="<IP_ADDRESS>" dyno=web.1 connect=1ms service=40ms status=302 bytes=1322

In staging its not even going in # AdyenRedirectController Please guide me why I am facing this issue.  And why in local it always give me balance-due

this issue can be solved with the help of giving Result URLs	http://your.site/checkout/payment/adyen	http://your.site/checkout/payment/adyen in your adyen account skin

done


Make simulator reboot logic more robust

Proposed Changes
This PR makes awaitLaunch more robust - no timeout needed anymore, bootstatus is better in this case, since it waits until Springboard is fully launched, while just tracking the Booted state from simctl list doesn't
Testing

[x] tested locally

Looks good after tested!


⚠ Bofrost.de has degraded performance

In 0cf807d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1356 ms

Resolved: Bofrost.de performance has improved in d87b9d4.


test: test against current versions of nodejs

This brings the tested versions up to the current LTS and dev versions used by nodejs.

v0.8 branch does this


Somehow rgthree execution patch blow up when running this workflow.

Reference: https://github.com/Trung0246/ComfyUI-0246/issues/20
I also tried to run the workflow by myself. The cache looks weird:

It looks like exponential growth. Unsure how to move this forward.

This is a huge workflow, and something that is probably not going to work with ComfyUI.
@Pojo267 - were you iterating on this? Was there a recent point this was working?
this could be a bug in the optimization patch, but my first guess is that the structure of highway nodes and the size of this workflow here is the first problem. Regardless, the first step would be to turn off the optimization path via rgthree config:

The config is a json file in the root of the custom nodes. You can create a file (if it doesn't exist) as [comfyui]/custom_nodes/rgthree-comfy/rgthree_config.json.
At the very least, the file should have this to turn off the optimization:{
  "patch_recursive_execution": false
}

When you restart ComfyUI, you should only see the first message below, and NOT the second message:[rgthree] Loaded 20 exciting nodes.
[rgthree] Optimizing ComfyUI recursive execution. If queueing and/or re-queueing
    seems broken, change "patch_recursive_execution" to false in rgthree_config.json

Now, for both @Trung0246 and @Pojo267 here's why this workflow may cause problems...
ComfyUI's recursive execution is incredibly inefficient. It doesn't matter so much for standard workflows, but once nodes with many inputs/outputs are used it becomes unusable; 15 minutes spent for an actual 2 minute model execution just to recursively evaluate the graph. The optimization I've added should make this 1000's of times faster by caching results (which, since the graph isn't changing should be stable).
This is especially true when using nodes with many inputs and outputs, like the rgthree Context nodes or, here, the @Trung0246 highway nodes. Each node highway node here is creating multiple branches, which are then added to possible paths to get to that final Save node. So, when comfy's asking "how many possible paths does it take to get to this Save node" the answer is incredibly large.
So, first step would be turning off the optimization in the rgthree_config.json and seeing what happens. If it executes, even if you have to wait many, many minutes, then that's good; maybe there's a change in the optimization I can make.
But, if you still get an overflow, then there's not much more to do without completely rewriting ComfyUI's graph evaluation (the rgthree patch is an outward-in fix).
(Note, it's possible the terminal will not show any change for many, many minutes. Just hit queue and walk away; you'll be tempted to cancel the execution if you're waiting (as I was, many times, before digging into the execution).)
I can't get the workflow running myself, but let me know how it goes. I'm interested to see what happens here.

For posterity, here's the initial issue I opened on the execution slowness: https://github.com/comfyanonymous/ComfyUI/issues/1502


Turn down volume of all?

PLS add a general volume setting to turn down volume on all, I have 1617 songs on my slam and this would really help

This could be added. However, it would be kind of redundant as you can already click on your first track, shift-click on your last track, and set the volume on all your tracks at once.


IO-734 The OSGi manifest now contains sun.* import packages

Make the sun.* references from BufferedFileChannelInputStream optional

Coverage remained the same at 89.245% when pulling 2a9ac17ccc4cef4cdd9a16b8bc4cf5da8972e356 on enapps-enorman:issue/IO-734 into 3bba1beb8115dac754bafca7b45e424a7b35ba1c on apache:master.


entire directories?

would it be possible to make this work on an entire folder of NSPs or do I have to do one at a time?

You can use a Batch or Bash script to loop through all NSP files in a directory.


Fix Codecov Upload and Scripts

Summary
This PR fixes the following issues

[ ] Fix codecov upload
[x] Fix wnfs helper script

Moving the repo from previous org to the current one broke the codecov upload. This fixes that and also updates the helper script.
Test plan (required)
Manually testing the script.

Optional, but you can cd into the project root directory and install the script
sh scripts/wnfs.sh setup

Building the sub projects with the script.
wnfs build

Running all tests with the script.
wnfs test

Closing issues

Fixes #8

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@7a89949). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   80.42%
=======================================
  Files           ?       10
  Lines           ?      567
  Branches        ?        0
=======================================
  Hits            ?      456
  Misses          ?      111
  Partials        ?        0

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Image-Collection relationship change

Having single image in multiple collections is too messy so simplified it. Please note: after merged your local database is better to be removed and re-created again (recreated the migrations to save time).
The widget is updated as well to handle that
Hope it's still stable...

so after this merge, will the pulumi stack (Azure deployment) need to be destroyed and re-created to avoid slow migration? we can do that now but not for much longer, will soon have non-trivial data that will need to be preserved.

The DB migration changes caused breaking change on the deployed dev environment.
I'll recreate the DB on Monday.
Going forward let's try not to change/delete existing migrations.

oh, maybe i shouldn't have merged this until after tomorrow's demo :/
I might need to do a localhost demo, we will soon have dev+prod envs and then yes, breaking migrations will definitely be a pain.

I will deploy a working version to the Azure environment today, that will be ready for demo tomorrow.

and you can deploy any old commit, the thing about submodules is that we have more or less working widget version for each backend version


Add section about sharding strategy

This moves content that used to be in "Distributed Tables" into its own section and adds a discussion of Citus use cases and tradeoffs.
Fixes #145
Note that once we merge the migration PR we can link to it from the multi-tenant tradeoffs section in this PR.

OK, this section now provides a higher level overview of our use cases and their implications for data modeling. Let me know if you think we need concrete examples. Also there's a broken link to the data migration section will I can resolve once the PR for that section is merged.

Fixes #107 as well

hey @begriffs -- I read over the changes today. I had a few notes/questions that I wanted to share.

We previously emphasized real-time analytics and data modeling for that use case. Now that we have two separate use-cases, one geared towards multi-tenancy and another towards real-time analytics, writing a good Choosing a distribution column section becomes harder. What if we started with an initial heuristic to pick a use-case and then dived deeper into data modeling based on that? -- don't know

If you have tenants in your data and you're looking to migrate into Citus, choose distribution by tenant_id. Else if you have real-time analytics or better high throughput writes/look-ups, choose entity_id.

Since this is the data modeling section, what do you think of emphasizing the distribution column in the subsections? For example, instead of "Multi-tenant Applications", what if we named these sections "Shard by tenant_id" / "Distribute by Tenant_Id" or "Distribute by Entity_Id"?

Do we also want to give specific examples in these data modeling sections?

Could we describes the benefits to "Multi-tenant Applications" more? When I read this section, it feels a bit underwhelming.

(small) Does this pull request close #107? We talk about hash distribution in this section. We don't however talk about a few related concepts: (a) reference tables, (b) coordinator tables (the tables you create on the coordinate node and can't join with other distributed tables), and (c) append distribution.

Open question: what should we call the RT examples? They are currently named inconsistently. Some have domain-specific names and others are the names of generic schema constructions.

Raw Events Table
Events and Summaries
Updatable Large Table
Behavioral Analytics
Star Schema

@begriffs -- I added minor comments to this pull request. I'm very excited about these changes.
We're missing a few sections (Updateable Large Tables and Modeling Concepts). I also have a few higher level questions. Since this section is a major improvement over what we had, I'm inclined to address the current feedback and check this PR in.
We'd then open a second pull request that could have any of the following (to be scoped together):

We now have users coming to Citus for the NoSQL use case. Do we want to mention that in our data modeling section?
Do we want to add an example table schema and/or a diagram to the data modeling section? We could also demonstrate foreign keys here.
Do we want to have two examples for the multi-tenant data model? One for OLTP (example blog) and another for OLAP (example blog)?
We haven't finalized section names (Raw Events Table, etc.). What do we name these tables?
Both in the multi-tenant and real-time sections, we're in fact using the hierarchical data model.
We're missing two sections from our outline -- Updateable Large Table and Modeling Concepts. Should we fill these sections in?

Final changes and then shipit:
[ ]  Remove example code from the events with reference tables section. (but save it for later when our sql coverage has improved)
[ ] switch to User ID as entity in "Events with Roll-Ups"
[ ] find a more literal way to say "unknown unknowns" and without the quote marks
[ ] change name from "Distributed modeling" to data modeling, or even distributed data modeling if it fits
[ ] Remove unused colocation image


typo: additonal -> additional

@nschonni : Thanks for your contribution! The author, @curtand, has been notified to review your proposed change.

We're in the process of pulling these commits to the private repo, so we can verify the content on staging. We'll post a new PR # shortly and then close this PR.

Starting on move to private repo.

@nschonni -
We've moved this PR to the private repo: https://github.com/MicrosoftDocs/azure-docs-pr/pull/61960
Thanks.


Need help with adding Basenji Logo to Aerodrome

 Svg file
Meet Basenji, the oldest dog breed in history, born to live on the Base Chain.
$BENJI
TG: https://t.me/BasenjiBaseOfficial
Website: https://www.basenjibase.com/
Twitter: https://twitter.com/basenjiofficial

The SVG is perfect, I'll make the PR.


Icon shows green dot after restart

Frequently after restarting my Mac, the Tool Releases menu bar icon shows a green dot. When I click on it, there aren't actually any new releases.
ToolReleases v1.4.2, build 45
macOS 11.4

Thank you, @spencertransier for reporting.
I will investigate this issue.

Still shows on 1.5.0 beta 3 build 57

Thanks for the quick feedback.
@etrahretep could you please provide a little more context about your environment, like, OS version, is the ToolRelease set to launch automatically on login?

Running Toolrelases on three systems. Two of them running Monterey 12.3 bèta (21E5196i) and the third one Big Sur 11.6.3 (20G415). All three launch at login/restart. Not been able to time the appearance of the green dot  but a few times a day on all three. And there's nothing new...


Add PyPI

pypi.org
The Python Package Index (PyPI) is a repository of software for the Python programming language.
PyPI helps you find and install software developed and shared by the Python community.
Package authors use PyPI to distribute their software.
Logo

Added in e6c61d4e86536e2ffa2834689a9f44e1d38019e0
Thanks


Update approve text

fixes #86

On Nano(sp/x): Accept?\nPress both buttons to accept. -> Accept\nand send
On Nanos: Accept? -> Accept and send

I manually tested for nanox and nanosp using speculos. "Accept \n and send" working fine on both of them.


Upgrade to Angular 19

Bump core and peer deps to Angular 19 / Angular Material 19

Thanks a million @mixer904 🎉


Setting the Validate Trigger based upon properties

I'm submitting a feature request

Library Version:
1.0.0

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
4.4.7

NPM Version:
3.10.5

AURELIA CLI

Browser:
Chrome 52.0.2743.116

Language:
ESNext

Current behavior:
Currently, 'validationTrigger' applies for all properties. And validation trigger based on properties doesn't seem to be supported.
Expected/desired behaviour:
Besides the current behaviour it would be nice if validation trigger works on property basis. For example, validation  for email property can be triggered on blur rather than on change. On other hand validation for name property can be triggered on change and on blur. Thus the need for validation trigger based on property rather than always applying the same trigger for all properties.

What is the motivation / use case for changing the behavior?
The main motivation is to enhance user experience. .

#303


[SelectField] Add support for errorText for SelectField

@hai-cea sure, my mistake, now it should be in proper place

Thanks @patrykkopycinski - can you squash this PR down to 1 commit please?

@hai-cea done

Thanks @patrykkopycinski


NumberField opens numeric keyboard with , instead of . on some iPhone regions

Provide a general summary of the issue here
Regardless of what is set in I18nProvider, NumberField always opens iPhone numeric keyboard with , instead of . if the iPhone region is set to such that they use that decimal separator.
This makes it impossible to input in decimals.
🤔 Expected Behavior?
Honestly, don't know. I've read about iPhone numeric keyboards and apparently there's no way to change which numeric keyboard is going to be displayed.
Ideally, the keyboard would open with locale identical to the provided to I18nProvider, or it would be possible to change NumberField locale so that it corresponds to iPhone's regional settings.
😯 Current Behavior
Currently, for sk-SK regional settings in iPhone and en-GB in I18nProvider, the iPhone numeric keyboard opens with , instead of . as the decimal separator.
💁 Possible Solution

give an option to open up the full keyboard, as for input[type='number']. slightly worse UX, but much better than being unable to input in decimals
find a way to sync I18nProvider locale with iPhone regional settings

🔦 Context
I am trying to open up numeric keyboard on iPhone with the correct, functioning decimal separator.
🖥 Steps to Reproduce

Set iPhone to e.g. Slovak region
Visit https://codesandbox.io/p/sandbox/gracious-shadow-r445mc
Open up the number field
Try typing 13,37. it will erase the ,, because it expects .

Version
<EMAIL_ADDRESS>What browsers are you seeing the problem on?
Safari
If other, please specify.
No response
What operating system are you using?
iOS 17
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

The team discussed this today and we think that perhaps we could change our number parsing so that we try using the user's locale  and the locale specified by I18nProvider. We figured that a user would be used to typing the number separator they are used to and that they may not even know what separator would be correct for other locales any ways. That way your repro steps would work by converting the , to a . as the user types.

Updating with some links and extra info about an implementation. We already do a check/test for the numbering system being used, we could do something similar for the group/decimal separator and perform two attempts at parsing to figure out what the number is.
See https://github.com/adobe/react-spectrum/blob/main/packages/%40internationalized/number/src/NumberParser.ts#L71 for guesses at the numbering system.

I just realized we might need to make this conditional to only mobile keyboards though? If the keyboard has both , and . it could be ambiguous.

The team discussed this today and we think that perhaps we could change our number parsing so that we try using the user's locale and the locale specified by I18nProvider. We figured that a user would be used to typing the number separator they are used to and that they may not even know what separator would be correct for other locales any ways. That way your repro steps would work by converting the , to a . as the user types.

I think this is predictable behavior
Are there any updates on this issue?


Fix NotImplementedError for no bias.

I tried creating a LoRA of LLAMA-2 model with the following config. But it fails with the shown error. I took a look into the implementation and thought this might fix it for me and it indeed does.
model = AutoModelForCausalLM.from_pretrained(
    'meta-llama/Llama-2-7b-hf',
    device_map = 'auto',
    torch_dtype = torch.bfloat16
)

peft_config = LoraConfig(
    r = 16,
    lora_alpha = 64,
    lora_dropout = 0.1,
    target_modules=['q_proj','v_proj'],
    bias = None,
    task_type = "CAUSAL_LM"
)

peft_model = get_peft_model(
    model,
    peft_config
)

With default active_adapter the bias is None and we're only checking it against "none".
Here's the full error.
	"name": "NotImplementedError",
	"message": "",
	"stack": "---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
/home/datta0/temp.ipynb Cell 4 line 1
----> <a href='vscode-notebook-cell://ssh-remote%2B<IP_ADDRESS>/home/datta0/temp.ipynb#W3sdnNjb2RlLXJlbW90ZQ%3D%3D?line=0'>1 peft_model = get_peft_model(
      <a href='vscode-notebook-cell://ssh-remote%2B<IP_ADDRESS>/home/datta0/temp.ipynb#W3sdnNjb2RlLXJlbW90ZQ%3D%3D?line=1'>2     model,
      <a href='vscode-notebook-cell://ssh-remote%2B<IP_ADDRESS>/home/datta0/temp.ipynb#W3sdnNjb2RlLXJlbW90ZQ%3D%3D?line=2'>3     peft_config
      <a href='vscode-notebook-cell://ssh-remote%2B<IP_ADDRESS>/home/datta0/temp.ipynb#W3sdnNjb2RlLXJlbW90ZQ%3D%3D?line=3'>4 )

File ~/.py3nv/lib/python3.10/site-packages/peft/mapping.py:106, in get_peft_model(model, peft_config, adapter_name)
    104 if peft_config.is_prompt_learning:
    105     peft_config = _prepare_prompt_learning_config(peft_config, model_config)
--> 106 return MODEL_TYPE_TO_PEFT_MODEL_MAPPING[peft_config.task_type](model, peft_config, adapter_name=adapter_name)

File ~/.py3nv/lib/python3.10/site-packages/peft/peft_model.py:889, in PeftModelForCausalLM.__init__(self, model, peft_config, adapter_name)
    888 def __init__(self, model, peft_config: PeftConfig, adapter_name=\"default\"):
--> 889     super().__init__(model, peft_config, adapter_name)
    890     self.base_model_prepare_inputs_for_generation = self.base_model.prepare_inputs_for_generation

File ~/.py3nv/lib/python3.10/site-packages/peft/peft_model.py:111, in PeftModel.__init__(self, model, peft_config, adapter_name)
    109 if not peft_config.is_prompt_learning:
    110     self.peft_config[adapter_name] = peft_config
--> 111     self.base_model = PEFT_TYPE_TO_MODEL_MAPPING[peft_config.peft_type](
    112         self.base_model, self.peft_config, adapter_name
    113     )
    114     self.set_additional_trainable_modules(peft_config, adapter_name)
    115 else:

File ~/.py3nv/lib/python3.10/site-packages/peft/tuners/lora.py:274, in LoraModel.__init__(self, model, config, adapter_name)
    273 def __init__(self, model, config, adapter_name) -> None:
--> 274     super().__init__(model, config, adapter_name)

File ~/.py3nv/lib/python3.10/site-packages/peft/tuners/tuners_utils.py:88, in BaseTuner.__init__(self, model, peft_config, adapter_name)
     85 if not hasattr(self, \"config\"):
     86     self.config = {\"model_type\": \"custom\"}
---> 88 self.inject_adapter(self.model, adapter_name)
     90 # Copy the peft_config in the injected model.
     91 self.model.peft_config = self.peft_config

File ~/.py3nv/lib/python3.10/site-packages/peft/tuners/tuners_utils.py:227, in BaseTuner.inject_adapter(self, model, adapter_name)
    221 if not is_target_modules_in_base_model:
    222     raise ValueError(
    223         f\"Target modules {peft_config.target_modules} not found in the base model. \"
    224         f\"Please check the target modules and try again.\"
    225     )
--> 227 self._mark_only_adapters_as_trainable()
    229 if self.peft_config[adapter_name].inference_mode:
    230     for n, p in self.model.named_parameters():

File ~/.py3nv/lib/python3.10/site-packages/peft/tuners/lora.py:412, in LoraModel._mark_only_adapters_as_trainable(self)
    410             m.bias.requires_grad = True
    411 else:
--> 412     raise NotImplementedError

NotImplementedError: "

Thanks for bringing up this issue. I think it was quite intentional to not allow None for the bias parameter in the config, as this parameter is only supposed to be a string. Therefore, I wouldn't change the code to allow None. However, it can be useful to augment the error message similar as you did, showing the user the value they passed and what values are actually possible.
Also, technically, NotImplementedError is incorrect here, it should be a ValueError. Not sure if we want to change that or keep it for consistency with the rest of the code base, which also uses it incorrectly.

Let's keep the NotImplementedError for now, as there are multiple instances and maybe we do want to keep it for consistency (not only within PEFT, but also the larger HF ecosystem).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update snippet tags

Description
Title says it all.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/migration/inc/http-modules?view=aspnetcore-8.0&branch=pr-en-us-32106
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/migration/inc/http-modules.md
Document ID
fc50c5dd-8eae-c15e-d710-f84ff36b2f81
Article author
@twsouthwick

@timdeschryver please review. This is the format we use now.


Examples are misleading or incorrect or need more details

The examples are either incorrect or misleading and need more clarification on exactly what situation they can be used. Given the examples you would think to upload a new file to SharePoint the format would be "PUT /sites/{site-id}/drive/items/{parent-id}:/{filename}:/content" however this appears to only work for the default Documents folder only as if you try to use the the drive-id of any other document library for the parent-id it fails. Plus it fails to include the syntax example where a folder can be added although this only creates that folder in the default Documents folder. It would seem the only purpose of that syntax is the default Documents folder of a SharePoint site, but this is also not clear. If you want to upload to a particular document library in SharePoint the syntax I finally found to work would be "PUT /drives/{drive-id}/items/{parent-id}:/{filename}:/content". This syntax does't have the reference to the site at all as one might expect when working with SharePoint. This syntax could be confused as being specific to OneDrive, which it might also work for, but it isn't exactly known. The section that lists the various commands should at least be enhanced to indicate when each sample is intended to be used. This same can be applied to the other examples.
PUT /drives/{drive-id}/items/{parent-id}:/{filename}:/content
PUT /groups/{group-id}/drive/items/{parent-id}:/{filename}:/content
PUT /me/drive/items/{parent-id}:/{filename}:/content
PUT /sites/{site-id}/drive/items/{parent-id}:/{filename}:/content
PUT /users/{user-id}/drive/items/{parent-id}:/{filename}:/content

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d92fb8c7-4409-d945-57dd-5d6fc4010051
Version Independent ID: f77c05bd-2688-bd4e-1f8f-f18feb3a8639
Content: Upload small files - Microsoft Graph v1.0
Content Source: api-reference/v1.0/api/driveitem-put-content.md
Product: sharepoint
Technology: microsoft-graph
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKelley

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


*: 0.3.0

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable