Custom CA Integration with K8s CSR fails with cert-manager self-signed CA

Bug Description
Bug report: bug-report.tar.gz
When working through the Custum CA Integration with k8s CSR demo, istiod failed to provide a certificate to istio-ingressgateway resulting in istiod and istio-ingressgateway failures. This issue occurred after deploying istio with the default cert signer information as specified in the demo.
Demo environment:

AKS cluster

Errors in Istiod:
2023-01-24T20:41:14.904656Z     error   serverca        CSR signing error (failed to find root cert from signed cert-chain (found root cert is not a ca type cert: &{[...]} spiffe://cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account))

Errors in istio-ingressgateway:
2023-01-24T22:44:47.922416Z     info    ads     ADS: new connection for node:istio-ingressgateway-7c946df4ff-4pjkt.istio-system-902
2023-01-24T22:44:47.956442Z     warn    sds     failed to warm certificate: failed to generate workload certificate: create certificate: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:15012: connect: connection refused"
2023-01-24T22:44:48.196471Z     warn    ca      ca request failed, starting attempt 1 in 107.722649ms
2023-01-24T22:44:48.305036Z     warn    ca      ca request failed, starting attempt 2 in 210.596616ms
2023-01-24T22:44:48.516831Z     warn    ca      ca request failed, starting attempt 3 in 379.315277ms
2023-01-24T22:44:48.897101Z     warn    ca      ca request failed, starting attempt 4 in 755.246519ms

Verifications:
I verified the specifications for the demo were successfully applied. istiod recieved the correct environment variables:
 env:
    - name: CERT_SIGNER_DOMAIN
      value: clusterissuers.cert-manager.io
    - name: EXTERNAL_CA
      value: ISTIOD_RA_KUBERNETES_API
    - name: REVISION
      value: default
    - name: JWT_POLICY
      value: third-party-jwt
    - name: PILOT_CERT_PROVIDER
      value: k8s.io/clusterissuers.cert-manager.io/istio-system

istiod successfully picked up on the environement variables and correctly used the istio-system cert-manager issuer to issue its own certificate:
2023-01-24T22:51:11.045175Z     info    Generating K8S-signed cert for [istiod.istio-system.svc istiod-remote.istio-system.svc istio-pilot.istio-system.svc] using signer clusterissuers.cert-manager.io/istio-system
2023-01-24T22:51:11.337886Z     info    x509 cert - Issuer: "CN=istio-system", Subject: "O=", SN: 368c7ba0d9aaa81e09060977f266bd09, NotBefore: "2023-01-24T22:51:11Z", NotAfter: "2033-01-21T22:51:11Z"

Cert-manager was also install using the correct feature gate:
helm install cert-manager jetstack/cert-manager --namespace cert-manager --create-namespace --version v1.11.0 --set featureGates=ExperimentalCertificateSigningRequestControllers=true

Containers:
  cert-manager-controller:
    Container ID:  containerd://48338bbf7cf9d056d0cfc373da42665c66b985b8d5e9d1ae8e34401d34d23a06
    Image:         quay.io/jetstack/cert-manager-controller:v1.11.0
    Image ID:      quay.io/jetstack/cert-manager-controller@sha256:d429b6d696e0ef47cff1d15241c6ffaac351e38ac22664b82fafa771d615b89a
    Port:          9402/TCP
    Host Port:     0/TCP
    Args:
      --v=2
      --cluster-resource-namespace=$(POD_NAMESPACE)
      --leader-election-namespace=kube-system
      --acme-http01-solver-image=quay.io/jetstack/cert-manager-acmesolver:v1.11.0
      --feature-gates=ExperimentalCertificateSigningRequestControllers=true
      --max-concurrent-challenges=60

Findings:
The error log in istiod (failed to find root cert from signed cert-chain) was generated by [SignWithCertChain()](https://github.com/istio/istio/blob/4f3e28b2c580ce83c8a9a6d0c8cb20738d9c6a32/security/pkg/pki/ra/k8s_ra.go#L115) in k8s_ra.go. The method is described as follows:
// SignWithCertChain is similar to Sign but returns the leaf cert and the entire cert chain.
// root cert comes from two sources, order matters:
// 1. Specified in mesh config
// 2. Extract from the cert-chain signed by the CSR signer.

However, the ordering of the checks to find the cert chain in the code did not match the description:
rootCertFromCertChain, err = util.FindRootCertFromCertificateChainBytes(cert)
if err != nil {
	return nil, raerror.NewError(raerror.CSRError, fmt.Errorf("failed to find root cert from signed cert-chain (%v)", err.Error()))
}
rootCertFromMeshConfig, err = r.GetRootCertFromMeshConfig(certSigner)
if err != nil {
	pkiRaLog.Infof("failed to find root cert from mesh config (%v)", err.Error())
}

To obtain the root cert, the cert chain is checked first before checking the MeshConfig. Additionally, if the root is not found in the cert chain, an error is returned rather than also checking if the root is in the MeshConfig.
Current Hypothesis:
When calling Sign on the csrPem cert-manager creates a certificate using the istio-system Issuer (created in the demo) created from a self-signed Issuer. Istio expects that the returned cert contains the certificate chain. In this case, the certificate does not contain the certificate chain and therefore does not contain the root certificate. The subsequent call to FindRootCertFromCertificateChainBytes(cert) will return an error and SignWithCertChain will return failed to find root cert from signed cert-chain.
Proposal:

Update the ordering of FindRootCertFromCertificateChainBytes and GetRootCertificateFromMeshConfig
Do not return an error in SignWithCertChain when FindRootCertificateFromCertificateChainBytes returns an error
Write unit or e2e tests to verify this functionality

Version
$ istioctl version
client version: 1.16.0
control plane version: 1.16.0

$ kubectl version --short
Client Version: v1.24.2
Kustomize Version: v4.5.4
Server Version: v1.24.6

Additional Information
No response

cc @shankgan

I followed the documentation and I'm running into the same error.

Istio = v1.16.1
cert-manager =  v1.10.1
Kubernetes = v1.23.14-eks-ffeb93d


feat: use memguard for sensitive data management

Summary
This PR adds memguard to manage sensitive data in memory. memguard implements a byte slice wipe method that doesn't get optimized out by the compiler and provides a LockedBuffer type for locking memory to prevent swapping and handling core dumps.

Memory allocation bypasses the language runtime by using system calls to query the kernel for resources directly. This avoids interference from the garbage-collector.
Buffers that store plaintext data are fortified with guard pages and canary values to detect spurious accesses and overflows.
Effort is taken to prevent sensitive data from touching the disk. This includes locking memory to prevent swapping and handling core dumps.
Kernel-level immutability is implemented so that attempted modification of protected regions results in an access violation.
Multiple endpoints provide session purging and safe termination capabilities as well as signal handling to prevent remnant data being left behind.
Side-channel attacks are mitigated against by making sure that the copying and comparison of data is done in constant-time.
Accidental memory leaks are mitigated against by harnessing the garbage-collector to automatically destroy containers that have become unreachable.

Issues
Overall, this feature adds a good amount of protection but was not able to completely cover every instance of sensitive data in memory. There are a few instances in the code based where memguard LockedBuffers were not able to be implemented at this time:
1. GQ math/big https://github.com/openpubkey/openpubkey/issues/51
2. PK Token lestrrat-go/jwx https://github.com/openpubkey/openpubkey/issues/52
3. GenKeyPair and cic signing https://github.com/openpubkey/openpubkey/issues/53
Fixes
#47

Excited to see a PR adding memguard! Thanks for putting this together
Really like the evaluation of potential storage of secrets that we can't fully manage with memguard. Can you create an issue for each of the areas you have identified where memguard can not completely control the secrets. That way we can track them and ensure we fix them. I have some ideas on how to address the PK Token issue and I suspect that when we move away from bignum in GQ signatures we might be able to address GQ signatures in bignum  too.

Really like the evaluation of potential storage of secrets that we can't fully manage with memguard. Can you create an issue for each of the areas you have identified where memguard can not completely control the secrets. That way we can track them and ensure we fix them. I have some ideas on how to address the PK Token issue and I suspect that when we move away from bignum in GQ signatures we might be able to address GQ signatures in bignum too.

Thanks! Created #51 and #52 for the existing issues.

What are your thoughts on protecting the identity's signing key with memguard?

Created #53 for the identity's signing key since it is similar to #52 using the math/big package to store the private key as big.Int making memguard not viable. It would be good to include it if we figure out a way to make it possible.
The identity's ephemeral signing keys are discussed a bit in #50, prefer using a KMS/HSM for key generation and signing but in the absence of either it would be good to ensure it is handled appropriately in memory.

I'll need a maintainer to merge this if everything looks good 👍

Whoops, I didn't get my comment in before the merge, but I want to push back on this a bit. I think memguard makes it harder to reason about this code without actually protecting us from things like sensitive data being swapped to disk etc.
As noted in the linked issues, if a LockedBuffer's underlying slice is passed to a function that copies it we lose the protection. This will put us in an arms race with every dependency including the standard library - for example, if a patch release of Go changes the implementation of a stdlib function to copy bytes, we'll lose the protection without realizing.
I think it's fine to leave this in as the surface area is pretty limited but I also wanted to share my $0.02


Add version number to GUI

Add version number to web GUI.

It is already present in the side navigation menu
Daniel

On 4 Oct 2019, at 16:39, InstigatorX<EMAIL_ADDRESS>wrote:

Add version number to web GUI.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Ha. Looked all over for it and didn't realize that side window expanded. I swear I looked everyone except that apparently.


Dropship crashing into the warship should be more clear

On 13 the dropship casts a shadow before landing, and plays the dropship landing sounds
https://discord.com/channels/1168210010233376858/1168210011823026271/1259065865257881601

Should be good now with the visualizer though we are still missing the shadow and sounds


Does not recognize the feeder

System Health details
System Information

version
core-2024.12.5

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.13.0

os_name
Linux

os_version
6.6.66-haos

arch
x86_64

timezone
Europe/Madrid

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
5000

Installed Version
2.0.1

Stage
running

Available Repositories
1498

Downloaded Repositories
50

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 14.1

update_channel
stable

supervisor_version
supervisor-2024.12.0

agent_version
1.6.0

docker_version
27.2.0

disk_total
146.9 GB

disk_used
41.5 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization
kvm

board
ova

supervisor_api
ok

version_api
ok

installed_addons
File editor (5.8.0), Advanced SSH & Web Terminal (19.0.0), Mosquitto broker (6.4.1), Samba share (12.3.2), Node-RED (18.1.1), Home Assistant Google Drive Backup (0.112.1), MariaDB (2.7.1), Zigbee2MQTT (1.42.0-2), ESPHome Device Builder (2024.12.2), Studio Code Server (5.17.3), Network UPS Tools (0.14.0)

Dashboards

dashboards
4

resources
28

views
31

mode
storage

Recorder

oldest_recorder_run
11 de diciembre de 2024, 20:39

current_recorder_run
22 de diciembre de 2024, 09:26

estimated_db_size
4674.14 MiB

database_engine
mysql

database_version
10.11.6

Checklist

[X] I have enabled debug logging for my installation.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
The previous integration worked with the "Fresh Element Infinity" feeder but is now not recognized in Homeassistant. It is not listed on the devices. It is the same account that I used previously and in the mobile APP, with another account with which I have shared the devices, if it works correctly.
Reproduction steps
1 - Just configure the account.
Debug logs
There is no error from this integration.

Diagnostics dump
No response

Hello,
Which feeder model is it ?

Fresh Element Infinity--> https://www.amazon.es/PETKIT-Fresh-Element-Infinity-Dispensador/dp/B09R4LPBCD

OK can you send me a message on Discord channel ?

what is the channel?

https://discord.com/invite/bYQWBc9d

Fixed with last release : https://github.com/Jezza34000/homeassistant_petkit/releases/tag/1.3.4


[CARBONDATA-3655] Support set base64 string as struct field value

Why is this PR needed?
Currently, only support set string with delimiter as struct field value, sometime it doesn't work very well on struct field.
What changes were proposed in this PR?
Support set base64 string as struct field value
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

please test this

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1505/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1512/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1515/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1516/

retest this please

@niuge01 : why not support this for Array and MAP also ?

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1519/

retest this please

@niuge01 : why not support this for Array and MAP also ?

It is also support for Array and Map.

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1521/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1528/

LGTM

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/1529/


Discussion and plan for deployment

I think we will discuss this tomorrow, but we should have a plan for how we would suggest a third party to deploy this. I started reading up on the docker build and bundle that is easy to do (and related, #25 ) but still have a lot of operator perusing to get a better sense. Once we have a plan, let's add automation to support it.

Okay this is mostly all set - it really is just make deploy and then applying the config! If we want to delve into the bundle/catalog at some later point, we can discuss and open a new issue for that.


feat: Get login working

Basic login works with a locally running keycloak server
Remaining todos:

[x] Command-line to get keycloak server up and running for other devs (+Bonus get it running in codespaces) (tried to get it running automatically on startup but the background processes for it seemed to get killed automatically
[ ] Deal with coverage drops from my gf-portal and gf-auth* cli command changes. I'm not sure how to/if to unit test them, so maybe i should just exclude them?

(tried to get it running automatically on startup but the background processes for it seemed to get killed automatically

If this is a VSCode task then it's possible to run the keycloak in the background.

(tried to get it running automatically on startup but the background processes for it seemed to get killed automatically

If this is a VSCode task then it's possible to run the keycloak in the background.

It is not currently a VSCode task, just a subprocess.Popen from a python script


Background color for logistics index is not working

Unable to make the background to same color as the page background for the logistics index chart.

Fixed that.


Add an option to sent the first beat on all divisions in Clock Divider

I've added the clock divider to my template and have been using it often but I wish that there was an option to send the first beat after a reset to all divisions so that logic, sample and hold, sequencers etc start correctly rather than making a sound/event only after number of divisions.

Thanks!


[FEA] UDF Support

Is your feature request related to a problem? Please describe.
It would be great to be able to support scala, java and python UDFs
Describe the solution you'd like
Something that can transpile simple scala, java and python byte code into either cuda kernels or catalyst expressions.
Describe alternatives you've considered
There really are no other options if we want to be fast.

This is being addressed in other issues.


In the Chinese environment, some specific symbols are not parsed correctly at the beginning and the end.

Emphasis is placed on displaying certain text that will not be parsed correctly when starting and ending with 《 or 》.
var md = "不如人意的**《李茶的姑妈》**已经为开心麻花影业敲响警钟";
var pipeline = new MarkdownPipelineBuilder()
    .UsePipeTables()
    .UseTaskLists()
    .UseEmphasisExtras()
    .UseAutoIdentifiers()
    .UseAdvancedExtensions()
    .DisableHtml()
    .Build();
var html = Markdown.ToHtml(md, pipeline);
Console.WriteLine(html);

Result:

不如人意的**《李茶的姑妈》**已经为开心麻花影业敲响警钟

Expected:

不如人意的《李茶的姑妈》已经为开心麻花影业敲响警钟

I found that Github is not parsed correctly either.
**《李茶的姑妈》**
**李茶的姑妈**

**《strong》**
**strong**

《李茶的姑妈》
李茶的姑妈
《strong》
strong
Sorry, my English is very poor.
I am still working on my English, but it's getting better.
I use it every day now.

It's not so much the 《 》 characters, but that emphasis requires a space before it:
a**《text》**b

a **《text》** b

See babelmark - most CommonMark parsers behave the same way as Markdig

Thanks.
Can this be considered a bug?
I can be parsed correctly when I use Typora.

It is not a bug - Markdig is behaving according to the CommonMark specification here.
While CommonMark allows intraword emphasis like foo**bar**baz, it has restrictions when the emphasis is preceded/followed by punctuation.
See left-flanking-delimiter-run from the spec.

A left-flanking delimiter run is a delimiter run that is (1) not followed by Unicode whitespace, and either (2a) not followed by a Unicode punctuation character, or (2b) followed by a Unicode punctuation character and preceded by Unicode whitespace or a Unicode punctuation character. For purposes of this definition, the beginning and the end of the line count as Unicode whitespace.

Note (2b) followed by a Unicode punctuation character and preceded by Unicode whitespace or a Unicode punctuation character. In your case, 《 falls under the Open Punctuation Unicode category, so CommonMark requires that emphasis be preceded by a whitespace character.
Similar holds for 》 that falls under Close Punctuation. The right-flanking-delimiter-run definition requires that it is followed by either a whitespace / another punctuation character.
Following these rules, the following are valid:
**《text》**
a **《text》**
a **《text》**
a **《text》** b
a **《text》**.

But
a**《text》**b

is not.

I can be parsed correctly when I use Typora.

Typora may be using a more relaxed definition of Markdown, but isn't compliant to the spec here.

Thank you for your reply and answer.
I'll get to work on those characters next.


Class docs - Provide the name of the NuGet package

Provide the name of the package in which a specific class reside.
The class documentation already tells what assembly the class is in, but not the package.
It is all well when the assembly is shipped as part of the framework, but sometimes you have to install packages and you don't know what package the class is in since the assembly is one of multiple ones that are part of a specific package.

This is already shown for some types, for example, https://docs.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis.csharp.csharpsyntaxnode?view=roslyn-dotnet. I'm not sure why it's not showing for all types that come from a package. @mimisasouvanh do you know?

Related to #71.

@gewarren @robertsundstrom Nuget packages should be showing. If a nuget package is not showing for a class, would you mind specifying an example?

I don't remember one, but I assumed that it was a framework class. It might have been for some of the Identity classes.
Yes, found one: https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.identity.entityframeworkcore.identitydbcontext-1?view=aspnetcore-5.0
Btw. Why don't you make it a link to the package at Nuget.org?

@robertsundstrom Thanks for the example. I'll file an internal bug. Great suggestion about making the package a link to Nuget.org. We'll look into that.


Version 0.5.6

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

Coverage remained the same at 80.097% when pulling b5367311f8a0a8280997b0b1a20460e053da1497 on rel-0.5.6 into debbc00ef1fc4f31e169cadf50730f689e724bee on develop.

Coverage remained the same at 80.097% when pulling b5367311f8a0a8280997b0b1a20460e053da1497 on rel-0.5.6 into debbc00ef1fc4f31e169cadf50730f689e724bee on develop.


Using np.linalg.multi_dot

I believe, it is more succinct and effective to refactor code to use np.linalg.multi_dot rather than numerous np.dot routines. What do you think about this change that has practical value?

Most of the np.dot between 2D arrays have been already replaced by @ in recent PRs.


Backport changes to move to go 1.17 to the 2.4 release

The go update to 1.17 is already used in the downstream 2.4 build
so backporting this change to match
Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

@gparvin is the target branch correct? I think it should be release-2.4

/hold

@ycao56 Thanks!  I forgot to update it.


[SPARK-41575][SQL] Assign name to _LEGACY_ERROR_TEMP_2054

What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_2054, "TASK_WRITE_FAILED".
Why are the changes needed?

We should assign proper name to LEGACY_ERROR_TEMP*
Does this PR introduce any user-facing change?

No
How was this patch tested?

./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*

Sounds good. Just exposed path to error message.
Thanks!

+1, LGTM. Merging to master.
Thank you, @itholic.


Make Program Cache per Device to Support Lock Free Async Execution

Related to: https://github.com/tenstorrent-metal/tt-metal/issues/6217.
Program cache is currently a global object, shared across all devices. To support async mode, with one thread per device, we should have a cache per device to minimize the number of times threads block each other due to shared resource usage.
This way, we limit the use of mutexes in the async mode implementation.

Changes for this pushed to main @ https://github.com/tenstorrent-metal/tt-metal/commit/2fe0c924578a492e445cf183e80fc2c8f850d770.
fyi @tooniz


PHOENIX-5872 Close Internal Phoenix Connections that were running dur…

…ing cancel

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/phoenix/pull/775 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/phoenix/pull/775

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@dbwong - looks like this was committed to 4.x but not master, but now needs a rebase to be committed. When you get a minute, could you please take a look?

Updated @ChinmaySKulkarni @gjacoby126 for master changes please review i'll update the patch on the jira as well.  @sakshamgangwar fyi for master path for your follow up jira as well.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
12m 33s
master passed

+1 :green_heart:
compile
0m 58s
master passed

+1 :green_heart:
checkstyle
2m 21s
master passed

+1 :green_heart:
javadoc
0m 47s
master passed

+0 :ok:
spotbugs
2m 52s
phoenix-core in master has 966 extant spotbugs warnings.

-0 :warning:
patch
2m 59s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
1m  1s
root in the patch failed.

-1 :x:
compile
0m 50s
phoenix-core in the patch failed.

-1 :x:
javac
0m 50s
phoenix-core in the patch failed.

-1 :x:
checkstyle
2m 26s
phoenix-core: The patch generated 64 new + 4559 unchanged - 15 fixed = 4623 total (was 4574)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 41s
the patch passed

-1 :x:
spotbugs
0m 49s
phoenix-core in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 46s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

32m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/775

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux ebb1d6da4dc2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / f1f92aa

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/testReport/

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@dbwong , apologies, but could you please rebase one more time?

Ping @dbwong can you please rebase so we can get this in master as well? There is another Jira (PHOENIX-6256) which depends on this along with @sakshamgangwar's Jira. FYI @yanxinyi

Already merged.


Converted vbproj tells visual studio it is targeting net40, but is actually net472

Converting this project https://github.com/rogersachan/mpv.net/tree/patch-1 has resulted in a vbproj file that targets net472 but visual studio is somehow convinced that it is targeting net40. even when you manually change it and unload/reload the project it is still convinced that it is a net40 project

I see one of your .vbproj files and it has <TargetFramework>net472</TargetFramework> which according to the docs is how it should be so I’m not sure how this is a bug in the tool

If you open the .sln visual studio will say that the project is targeting net40. I'm not sure how to resolve it or if it is something I need to edit myself.

Try closing VS, deleting the hidden temporary folder at the solution level
and any obj and bin folders at project level, then reopen the solution
On Friday, 17 May 2019, Roger<EMAIL_ADDRESS>wrote:

If you open the .sln visual studio will say that the project is targeting
net40. I'm not sure how to resolve it or if it is something I need to edit
myself.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hvanbakel/CsprojToVs2017/issues/249?email_source=notifications&email_token=AAYCFSZC4D4DGUIJ3JC4PRDPV3HO5A5CNFSM4HNODTAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVD5MY#issuecomment-493502131,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYCFS2ORTASK767BXRLK2LPV3HO5ANCNFSM4HNODTAA
.

--
Sent from my mobile

I attempted that when i first encountered the issue and also outright deleted and cloned the repo again. Still the same issue.

What does the project properties window show and what happens to project file if you change it manually to 4.7.2 and save?

The problem is that you have this:
    <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>

instead of:
    <TargetFramework>net472</TargetFramework>

Looking at the code this should be transformed but maybe that depends on how you call it, did you call it with any particular arguments?


Added Labels element

Adds a Labels element type for vectorized drawing of labels and text.

[x] Addresses https://github.com/ioam/holoviews/issues/819 and https://github.com/ioam/holoviews/issues/1837
[x] Add unit tests
[x] Add reference notebooks
[x] Add demo notebooks
[x] Update examples using an NdOverlay of Text elements.
[x] Add xoffset and yoffset options to make usage as labels easier.

I realize this is still WIP but just as a reminder, I would use this PR to add a warning to hv.Text in this PR to say that it will eventually be deprecated.

I realize this is still WIP but just as a reminder, I would use this PR to add a warning to hv.Text in this PR to say that it will eventually be deprecated.

I don't necessarily think we have to deprecate Text, Labels and Text are independently useful for different purposes.

The new docs for Labels make it clear how Labels has uses beyond what is supported for Text.  If Text has uses not well supported by Labels, presumably that should be made clear now in the docs for Text?


FR: Add support for "webpush.fcm_options" (WebpushFcmOptions)

As FCM HTTP API v1  and Firebase JS SDK already supports "WebpushFcmOptions" and click action handling on Web , I forked this repo and will create a PR for this issue.

I'm on this one. Code being developed in a separate branch at the moment.


Update teleop.cc

加速的时候，brake会保持为2；减速的时候，throttle会保持为2。
修正这个小的逻辑问题

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Bug] "AssetMan.Cli" exited with code 134.

Getting the following error when building:
.../.nuget/packages/assetman/0.9.24/build/netstandard2.0/AssetMan.targets(16,9): error MSB6006: "AssetMan.Cli" exited with code 134.
The error only happens when using "Build -> Build All" and not every time (about 50% of the times - if it fails once, it works on next try and it never happens when the app is being build when launching to an emulator).
Part of build log with the exception error:
Target AssetMan_GenerateAssets:
AssetMan is exporting assets...
AssetManBasePath: /Users/jst/.nuget/packages/assetman/0.9.24/build/netstandard2.0//../../tools
AssetManCliPath: /Users/jst/.nuget/packages/assetman/0.9.24/build/netstandard2.0//../../tools/netcoreapp2.2/AssetMan.Cli.dll
TargetFrameworkIdentifier: Xamarin.iOS
/usr/local/share/dotnet/dotnet /Users/jst/.nuget/packages/assetman/0.9.24/build/netstandard2.0//../../tools/netcoreapp2.2/AssetMan.Cli.dll -Options /Users/jst/Projects/QS2Go/src/Improvento.Quality2Go.MobileApp.iOS/Config.assets.json
Export starting...
Output: /Users/jst/Projects/QS2Go/src/Improvento.Quality2Go.MobileApp.iOS/Assets.xcassets
Input: /Users/jst/Projects/QS2Go/src/Improvento.Quality2Go.MobileApp.iOS/../../assets/images/
Unhandled Exception: System.IO.IOException: The process cannot access the file<EMAIL_ADDRESS>because it is being used by another process.
   at System.IO.FileStream.Init(FileMode mode, FileShare share)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at AssetMan.Asset..ctor(String path) in D:\a\1\s\src\AssetMan\Assets\Asset.cs:line 23
   at AssetMan.Exporter.Export(Options configuration) in D:\a\1\s\src\AssetMan\Exporter.cs:line 37
   at AssetMan.Cli.MainClass.Main(String[] stringArgs) in D:\a\1\s\src\AssetMan.Cli\Program.cs:line 45
/Users/jst/.nuget/packages/assetman/0.9.24/build/netstandard2.0/AssetMan.targets(16,9): error MSB6006: "AssetMan.Cli" exited with code 134.

Done building target "AssetMan_GenerateAssets" in project "Improvento.Quality2Go.MobileApp.iOS.csproj" -- FAILED.
Done building project "Improvento.Quality2Go.MobileApp.iOS.csproj" -- FAILED.

Looks like the same problem as https://github.com/kimbirkelund/AssetMan/issues/8


msbuild command line build does not add SwiftSupport folder

Thank you for creating and sharing this project, it has been of great value to me and my team!
Up to now I have been archiving my builds manually through Visual Studio for Mac and everything works great.
From now on, however, I would like to build from the command line, but I noticed that the build targets that you created (_SwiftFrameworksMac, _SwiftSupportIPA, _SwiftSupportArchive) don't seem to be executed with msbuild.
At least i don't see them in the output of msbuild and the created ipa does not include the SwiftSupport folder.
msbuild MyProject.sln \
/p:Configuration="Release" \
/p:Platform="iPhone" \
/p:BuildIpa="true" \
/p:ArchiveOnBuild="true" \
/t:Clean,Build

Maybe I'm just missing something here, can you give me a hint, please?

I'm having the same issue on Swift4 Library

@caldrian @volcano619 are you still having this issue?

Hi Lucas,
I still have the same issue. Maybe it's just the wrong command I use to build the app.
I created a simple project where the issue can be reproduced: (see the Makefile)
SomeApp.zip
When I build the app in Visual Studio the output shows following lines and everything works:
Target _SwiftSupportIPA:
    Looking for Swift version on: bin/iPhone/Release/SomeApp.app/Frameworks/SomeFramework.framework/SomeFramework
    Expected Swift header on: bin/iPhone/Release/SomeApp.app/Frameworks/SomeFramework.framework/Headers/SomeFramework-Swift.h
    bin/iPhone/Release/SomeApp.app/Frameworks/SomeFramework.framework/Headers/SomeFramework-Swift.h exists.
    Including Swift dylibs because you are targeting an OS version that doesnt include it.
    Installed: 5.2.2
    SomeFramework Framework: 5.2.2
    mkdir -p 'obj/iPhone/Release/ipa/SwiftSupport'; mkdir -p 'obj/iPhone/Release/ipa/SwiftSupport/iphoneos'; ls -1 'bin/iPhone/Release/SomeApp.app/Frameworks' | grep libswift | while read dylib; do '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo' "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift-5.0/iphoneos/$dylib"  -remove armv7s -remove arm64e -output "obj/iPhone/Release/ipa/SwiftSupport/iphoneos/$dylib";done
Target _ZipIpa:
...

However, when I build on the command line using
msbuild "./Xamarin/SomeApp.sln" \
	/p:Configuration="Release" \
	/p:Platform="iPhone" \
	/p:IpaPackageDir="./bin/iPhone/Release" \
	/t:Clean,Build

there is no output like above.
To further verify that something is incorrect I submitted the both created .ipa files to TestFlight. The VisualStudio build works as expected, but the command line built app crashes on start-up.
Do you have any clue what mistake I am making?
Thank you very much!
@Flash3001

Running the same command works on my projects. Are you your running the command on the same machine as your Visual Studio for Mac is running?
If nothing works you can use the following script https://github.com/Flash3001/ipa-packager/blob/master/package_ipa_default.sh to include the SwiftSupport folder on the IPA.

yes, on the same machine. okay, that will do as a workaround, thanks a lot!


DataBoxEdge Swagger API Review- 2021-02-01

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@arjoojain2812  Could you first fix the tool check errors?

The change related to 'type:object' will not be considered as breaking change.

    "tags": [

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT should be the right verb here.

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:757 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

        "description": "Accepted the request to update the proactive log collection settings."

If this operation is changed to PUT, then PUT long running operations should return 200/201 + provisioningState.
Refer RPC async guideline here: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:791 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

  "post": {

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:856 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataBoxEdge/dataBoxEdgeDevices/{deviceName}/diagnosticProactiveLogCollectionSettings/default": {

Any resource type MUST implement GET for collection and single resource regardless if it's a singleton or not.
Please implement GET API for /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataBoxEdge/dataBoxEdgeDevices/{deviceName}/diagnosticProactiveLogCollectionSettings

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:711 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

      "202": {

If this operation is changed to PUT, then PUT long running operations should return 200/201 + provisioningState.
Refer RPC async guideline here: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:890 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

      "type": "string"

Why is this annotation removed?

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:4135 in a040437. [](commit_id = a04043767d0f1fe2c65389b8c034d606d523e526, deletion_comment = True)

      "type": "string"

Why is x-ms-secret annotation removed?

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:5350 in a040437. [](commit_id = a04043767d0f1fe2c65389b8c034d606d523e526, deletion_comment = True)

      "description": "Proactive diagnostic collection consent flag",

Consider renaming boolean property to enum.
Refer best practice 'Replace boolean/switch properties with better enum' in https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:7555 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

    "include": {

consider modeling this property as a string array and rename the property to something like 'includeFiles' for better readability

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:8477 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

@arjoojain2812 - Please take a look at the comments.
nit: You may open the PR in codeflow for better viewability of comments.

    "tags": [

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.
Refer https://github.com/Azure/azure-resource-manager-rpc/blob/8e32d15c9c2ca2cc022782f41695e9c88dcf4039/v1.0/proxy-api-reference.md#resource-action-requests
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:757 in a040437. [](commit_id = a040437, deletion_comment = False)

    "tags": [

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.
Refer https://github.com/Azure/azure-resource-manager-rpc/blob/8e32d15c9c2ca2cc022782f41695e9c88dcf4039/v1.0/proxy-api-reference.md#resource-action-requests
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:757 in a040437. [](commit_id = a040437, deletion_comment = False)

Done

    "tags": [

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.
Refer https://github.com/Azure/azure-resource-manager-rpc/blob/8e32d15c9c2ca2cc022782f41695e9c88dcf4039/v1.0/proxy-api-reference.md#resource-action-requests
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:757 in a040437. [](commit_id = a040437, deletion_comment = False)

    "tags": [

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.
Refer https://github.com/Azure/azure-resource-manager-rpc/blob/8e32d15c9c2ca2cc022782f41695e9c88dcf4039/v1.0/proxy-api-reference.md#resource-action-requests
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:757 in a040437. [](commit_id = a040437, deletion_comment = False)

Done

  "post": {

POST should be used for an action on a resource.
For example: /subscriptions/{id}/resourceGroups/{rg}/providers/Microsoft.Compute/virtualMachines/{vm}/restart
'restart' is the action taken on VM in above example.
PUT is the right verb here.
Refer https://github.com/Azure/azure-resource-manager-rpc/blob/8e32d15c9c2ca2cc022782f41695e9c88dcf4039/v1.0/proxy-api-reference.md#resource-action-requests
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:856 in a040437. [](commit_id = a040437, deletion_comment = False)

Done

diagnosticProactiveLogCollectionSettings

I did not understand this comment fully,
I see that- there is a get api for diagnosticProactiveLogCollectionSettings
Please let me know, if there is any more questions.

"include": {

Hi Ramya,
We accept this value in a single ',' string from portal. Similar way we do in ACIS as well for the same API, so we would prefer to keep it as string, though it contains multiple strings, but we ask user to enter it in a single , separated string from Portal and ACIS both.
If we need to change it, It would need a contract discussion, with portal-service-device.
Please let us know if we need to take it, we can try taking up this change in next coming releases.

"include": {

Hi Ramya,
We accept this value in a single ',' string from portal. Similar way we do in ACIS as well for the same API, so we would prefer to keep it as string, though it contains multiple strings, but we ask user to enter it in a single , separated string from Portal and ACIS both.
If we need to change it, It would need a contract discussion, with portal-service-device.
Please let us know if we need to take it, we can try taking up this change in next coming releases.

You should model it as an array. Portal can split by ',' and convert to array.

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataBoxEdge/dataBoxEdgeDevices/{deviceName}/diagnosticProactiveLogCollectionSettings/default": {

Refer  bes t practice 'Inconsistent or incomplete CRUD' in https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html

In reply to: 868786924

Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:711 in 4112bdb. [](commit_id = 4112bdbf870e0e9e47af00a144db1d59d6e61046, deletion_comment = False)

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataBoxEdge/dataBoxEdgeDevices/{deviceName}/diagnosticProactiveLogCollectionSettings/default": {

Any resource type MUST implement GET for collection and single resource regardless if it's a singleton or not.
Please implement GET API for /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataBoxEdge/dataBoxEdgeDevices/{deviceName}/diagnosticProactiveLogCollectionSettings
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:711 in 4112bdb. [](commit_id = 4112bdb, deletion_comment = False)

Hi Ramya,
Have created a task for this, we will take it in the future release: https://msazure.visualstudio.com/DefaultCollection/One/_workitems/edit/9729045

"include": {

Hi Ramya,
We accept this value in a single ',' string from portal. Similar way we do in ACIS as well for the same API, so we would prefer to keep it as string, though it contains multiple strings, but we ask user to enter it in a single , separated string from Portal and ACIS both.
If we need to change it, It would need a contract discussion, with portal-service-device.
Please let us know if we need to take it, we can try taking up this change in next coming releases.

@arjoojain2812, You should model it as an array. Portal can split by ',' and convert to array.

Hi Ramya,
As we discussed, we can take this up in future releases, it would need discussion with different teams.

        "description": "Accepted the request to update the proactive log collection settings."

If this operation is changed to PUT, then PUT long running operations should return 200/201 + provisioningState.
Refer RPC async guideline here: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:791 in 4112bdb. [](commit_id = 4112bdb, deletion_comment = False)

Done

Ramya, have added a work-item for this: https://msazure.visualstudio.com/DefaultCollection/One/_workitems/edit/9729045
currently we have the status code 202 for all the PUT APIs, would discuss it internally and will update it

LGTM. Adding 'ARMSignedOff' label.

        "description": "Accepted the request to update the proactive log collection settings."

If this operation is changed to PUT, then PUT long running operations should return 200/201 + provisioningState.
Refer RPC async guideline here: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put
Refers to: specification/databoxedge/resource-manager/Microsoft.DataBoxEdge/stable/2021-02-01/databoxedge.json:791 in 4112bdb. [](commit_id = 4112bdb, deletion_comment = False)

Done

Ramya, have added a work-item for this: https://msazure.visualstudio.com/DefaultCollection/One/_workitems/edit/10262508
currently we have the status code 202 for all the PUT APIs, would discuss it internally and will update it


implement opentofu REST API methods

in the new tofu-maker project, copy all methods implemented in terraform-boot also to tofu-maker project.

[ ] code
[ ] github actions
[ ] Docker images

Repo available under - https://github.com/eclipse-xpanse/tofu-maker

I will take it


Create connect.txt

Links for reference:
https://hkust.edu.hk/
https://cse.hkust.edu.hk/ug/comp/
https://itsc.hkust.edu.hk/services/general-it-services/communication-collaboration/email/email-address

@martin2021 I am sorry, the domain ust.hk is removed from our trusted domains list because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


Make reaction menu 2x3 on narrow screens

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @jojejo in #android-requests.

@tneotia is this something you changed yet?

not yet, I think @jjoelj wanted to do this but I can look at it as well


Feature request: Random colors

Feature suggestion by Chris Thomas via Chrome Web Store:
A tiny feature request: Random colors everytime! Could even cycle through the default presets to ensure readability. Would keep the extension fresh! Thank You :)

This feature has been added and will be available in the next update.


Incorrect word is half highlighted in red

It looks like this is happening because it thinks that words are separated based on the capitalization of the characters rather than the spacing. Something like split a long word into multiple words by grabbing the first capital letter that appears before lowercase characters
for instance:
HELLOthere would split into 'HELL' and 'OTHERE'.
HELLOthereNOTaword would become 'HELL', 'Othere', 'NO', 'Taword'
HELLOthereNEWWORD would become 'HELL', 'Othere', 'NEWWORD'

100% right.
It's expecting CamelCaseCombinedWords.
So it sees URIs and URLs as UR Is and UR ls.

Do you think we should highlight camelCase words? I think that in most cases, camel case would be used by programmers and many times, variable names aren't whole words. Maybe for camelCase, we can see if it matches any of the already existing camelCase words in the document so it would be like a variable name check rather than a grammer check?

Update: found another bug that doesn't look like camel case.

More weird interactions with highlighting.

The last two comments showing weird spell checking behavior on the last line should now be fixed.

Now, when you open/create a new file from the program, highlights will not work until you save and reopen.

Was that in the last (or only) line in the file? There was a problem with doing highlighting on the last line of the file that I recently fixed.

It is happening in the entire file. A newly created file will not have any highlighting at all until you save and reopen.

I'm going to fix the initial bug report and close this. Please open a different issue if there's more to be fixed :)


Support multiple keys per wallet

Users need to be able to manage multiple keys per wallet, especially given the release of Ledger support.
This isn't possible right now, leaving users with the terrible options of either having to manage multiple browsers, or sign out and back in again frequently.
I was thinking about multi key support as part of the key mgmt refactor, so it should hopefully be possible without significant changes.

I hereby voice my support for this enhancement.

I think this is a critical feature.
I'll copy paste my blurb from Stacks Wallet Discord below.
Context: having to pick either HW or SW when first setting up Hiro, without the option to add the other one after that setup.
The vast majority of people will start of with a software wallet.
They will only get a HW one after they understand why it's important etc etc.
HW costs money, SW does not. People need time to understand why spending money and adding some complexity into the mix is worth it.
So it makes sense to keep both. HW will be added onto already existing SW setup.
And even from a security standpoint, you want to use a hot wallet for most websites and assets you care less about.
And a HW one for the rest.
Most people also think resetting a wallet means losing their assets (which can be true if their seed was not properly stored).
This is yet another barrier to HW adoption.
It's inconvenient and risky to have to keep entering your seed phrase just to get both.
Maintaining 2 browsers is also inconvenient.
People will chose convenience over security most often. We should strive to give them both.

Requested here on Canny: https://hirowallet.canny.io/feature-requests/p/support-multiple-secret-keys-seeds-within-the-hiro-wallet
@kyranjamie I'm curious if your current key refactor work might also lend itself to this feature longer term as well? I.e. help prepare for it

I'm keeping this in mind with all state changes. For example, when saving bitcoin ledger keys, we're doing so with the walletId of default. Such that we can filter/sort later when adding multiple keys.


WebSocket note added

Hi @punitganshani, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


ci: open go linter

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #5 (ec01d6b) into main (9947b29) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head ec01d6b differs from pull request most recent head 9ccd8ed. Consider uploading reports for the commit 9ccd8ed to get more accurate results

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   60.58%   60.58%
=======================================
  Files         119      119
  Lines        6378     6378
=======================================
  Hits         3864     3864
  Misses       2144     2144
  Partials      370      370

Impacted Files
Coverage Δ

components/configstores/apollo/change_listener.go
82.60% <ø> (ø)

components/configstores/apollo/configstore.go
76.16% <ø> (ø)

components/configstores/apollo/repository.go
11.42% <ø> (ø)

...omponents/configstores/apollo/subscriber_holder.go
100.00% <ø> (ø)

components/configstores/etcdv3/etcdv3.go
81.20% <ø> (ø)

components/custom/registry.go
84.00% <ø> (ø)

components/hello/helloworld/helloworld.go
100.00% <ø> (ø)

components/lock/consul/consul_lock.go
83.87% <ø> (ø)

components/lock/etcd/etcd_lock.go
80.00% <ø> (ø)

components/lock/in-memory/in_memory_lock.go
100.00% <ø> (ø)

... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312de4e...9ccd8ed. Read the comment docs.


Extracting data from ListBox item

I'm testing an old application which has a ListBox.  In the app itself I can see the list of names in the ListBox, however when using Inspect.exe, I can't find the displayed text anywhere.
I've been able to get hold of all of the ListBox items using WinApDriver, but again, can't find the 'text' within the item object to be able to pick the right one to click.
I'm guessing that if Inspect can't see that text that it's also not accessible to WinApDriver.
Is there anything I can do to make that text visible? Do I need to modify the data object that is being listed to have accessor methods or something (data object below)

Sometimes this text is displayed from value field, sometimes from Name and sometimes from other attribute. Not always it will be accessible for winappdriver.

Any details on why data may not be available to WinAppDriver, or what can be changed in the code of the application to make it available?

Like I mentioned in comment above. Try to find element with a locator that hold list item and try to inspect LegacyName and LegacyValue attributes for this and child element. Not always must be nested text element. If none of the elements that can be located hold any sign of that text there is possibility it is just a winappdriver limitation.

@mooragor I believe the first document after the list item has it.
AppiumWebElement document;
document.GetAttribute("Value");
Sometimes you get lucky and you can simply do:
ListItem.Text;


upgrade-envoy-v2

WIP moving to v3 discovery API
Upgrade Envoy gRPC API to V3
Fix tests
go mod tidy
changes to docker copy path
HttpFilter ConfigType router config required for v3 > v1.20.x envoy
bump some go packages for envoy
haproxy deprecated ':' valid in config

@mihaitodor I created another PR based on your branch with my changes on top

testing against envoy 1.29.7


fix(llm): improve typing of ReceiveFunds/02-SelectAccount and fix crash case

✅ Checklist

[ ] npx changeset was attached.
[ ] Covered by automatic tests.
[x] Impact of the changes:

Receive funds flow when selecting a token

📝 Description
the fallback case of the logic was indeed broken and unfortunately the typing was hiding the issue, we never should case using as in TS 😢  )
❓ Context

JIRA or GitHub link:  https://ledgerhq.atlassian.net/browse/LIVE-13092

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS the error is not in live-wallet, it's a misusage of the getDefaultAccountName function. Instead of giving an Account we have a CryptoCurrency.


[Bug]: Winston 2.4.6 is not node 4 compatible

🔎 Search Terms
node 4, async, async 3.2.3
The problem
Winston 2.4.6 is no longer compatible with node v4. From the error messages, we believe the issue is due to this Pull Request: https://github.com/winstonjs/winston/pull/2112
It seems that async 3.2.3 is not compatible with node 4, and back porting to Winston 2.X brings that incompatibility.
What version of Winston presents the issue?
v2.4.6
What version of Node are you using?
v4.9.1
If this worked in a previous version of Winston, which was it?
v2.4.5
Minimum Working Example
No response
Additional information
No response

Regrettably, due to legacy hardware constraints we are forced to support node 4. We have locked down our Winston version to 2.4.5, to avoid the incompatibility issue. Normally, I wouldn't have said anything, but the Winston CHANGELOG indicated that node 4 support was being phased out in Winston 3.X. So I figured I'd mention something just in case other consumers were also using node 4.

Do you have an alternative proposal, such as a version of async without the vulnerability which supports node 4?

After some investigation, it seems that async 2.6.4 would have that same security fix as well as have node 4 support. We tested locally and it seems to work.

Feel free to make a PR using 2.x as the base branch.  Maybe also change the test setup a bit to check for that.

Thank you for your feedback. We'll begin working on getting a PR up for you to review.


Added Hugo tool logo image and some design modifications

Added Hugo logo image file to repository
Added some design changes

Added content to Sphinx tool file

Also added Sphinx logo image file to the repository


error when run task with port 8090

how to run tasks with port 8090 now

Hi,
Refer #40. You will have to rebuild with druid 0.10.x to get ingestion to work.
Let me know if it works.


(#396) NULL-out input handle(s) after close(). Rename dismount -> unmount(), where applicable.

Minor rework to tighten the interfaces which close / deinit sub-system handles:

Rename "dismount" to "unmount"; as in 'trunk_unmount()'
splinterdb_close(), trunk_unmount(), test_deinit_task_system(),
task_system_destroy() now receive an addr-of-ptr to handle, and NULL-out
the handle upon a successful close / unmount / deinit. This will cause
a seg-fault if caller tries to access said handle after it has been closed.

While developing C-example programs, I ran into some bad code (my own) while calling splinterdb_close().
I corrected the interface in my private branch, and then recollected that I had proposed to do this cleanup some weeks ago.
Peeling off this cleanup item as its own PR so that this rework can be done independently.
It will help write out the C-example programs with a neat code-construct, calling splinterdb_close(&splinter_handle), so as to inculcate proper form in application programs.

NOTE: The proposal to rename trunk_dismount() to trunk_unmount() and such like has been aired out in this internal slack thread. And has been accepted.


feat: add toggle for eager loading

Current dependencies on/for this PR:

main

PR #55   👈

This comment was auto-generated by Graphite.


Trigger the CloseRequested event on every attempt to close the application

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
As pointed out in #195 and https://github.com/GyulyVGC/sniffnet/issues/291 the CloseRequested is not triggered when:

ctrl+c is typed from the command line
cmd+q is typed on MacOS

You are discussing there, but maybe it's better to make a dedicated issue.
What is the expected behavior?
Trigger the CloseRequested event, not only on the two points listed above, but on every attempt to close the application.
Version
master
Operating System
Linux
Do you have any log output?
No output needed.

Ctrl+C in a terminal is a global process interrupt and should be handled by you.
I can confirm that winit is not producing a CloseRequested event when pressing Cmd+Q on macOS. We should report that there.

I can confirm that winit is not producing a CloseRequested event when pressing Cmd+Q on macOS. We should report that there.

I don't know if it can be of any help, but I noticed that Cmd+Q doesn't even let Application::run correctly return from the invocation.

I can confirm that winit is not producing a CloseRequested event when pressing Cmd+Q on macOS. We should report that there.

This is a pretty important feature for my app since several configurations must be saved before exiting.
At the same time I don't want to put pressure on you to solve this in the short term, but I was wondering if you could give me some hints that can help me fix it @hecrj

Reference some related issues:
https://github.com/rust-windowing/winit/issues/1992
https://github.com/rust-windowing/winit/issues/2776


replace Remote Explorer instruction with Ports tab

The Problem/Issue/Bug
See issue.
How this PR Solves The Problem
Updates instructions to point to "Ports" tab instead of "Remote Explorer" button.
Manual Testing Instructions
Related Issue Link(s)
Closes #111
Release/Deployment notes

Summary by CodeRabbit
"Documentation: Updated user instructions for accessing Drupal services in the DrupalPod extension for VSCode. Users are now directed to the 'Ports' tab instead of the 'Remote Explorer' button. This change simplifies the process of opening Drupal in a new tab or window by clicking the 'Globe' button next to the '8080' item in the list."

Thanks @alisonjo315
Can you also change the arrow to point down where the ports tab is located?
The rest of the change look good to me.
It would be great to have this before Drupalcon Lille since I remember some confusion with first-time contributors about this.
cc @shaal

@rodrigoaguilera lol good catch! -- done 😁


Fork-Function with strange behaviour

Hey everyone,
I recently asked in #269 about the best way to control two scanners without ROS. Me and my colleagues decided to use the old c-function fork() to generate two processes. The plan was that each of that processes then runs one scanner. But we encountered a strange behaviour when we use fork. If I link the sick scan xd library in the CMakeList into our program, the fork-function did not work properly. To make it easier to see here is the code, it is very simple :)
{
    int id = fork()
    printf("Hello from %d\n", id)
    return 0
}

And here is the CMakeList part:
    target_link_libraries_system(mwb
    lib_mqtt
    lib_api_core
    lib_common_config
    sick_scan_xd::sick_scan_xd_shared_lib)

Nothing special here. If we dont use the sick scan xd lib, the output of of the 3 lines of code is of course:
    Hello from 37031
    Hello from 0

But if we link your library in we get only:
    Hello from 0

What is going on there? It seams that the main/parent process is no longer there. Do you have any idea why or how this happend? I had a look at your top level CMakeList.txt but did not found a hint or so. Thanks in advance.
Best regards,
Christian

Thanks for your feedback. I am not sure that the use of fork creates completely independent processes. The man page on https://www.man7.org/linux/man-pages/man2/fork.2.html says: "The entire virtual address space of the parent is replicated in the child, including the states of mutexes, condition variables, and other pthreads objects." I would not rule out the possibility that replicated mutexes are blocking execution. But this is just a guess.
If you are using MQTT, which I think is a good choice, you might implement a MQTT client for each lidar and run them in 2 separate processes.


Context Menu Item for Find

Description of the new feature/enhancement
A menu flyout item for the find feature.

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:

Hopefully once #3789 lands (in 1.1), then we'll be able to add menu entries to the right-click menu on a tab, and I think that's probably a better place to put something like this.
Then there's also #3337 for adding a context menu to the terminal controls themselves, which would also be an appropriate place for this
Then of course, there's always #5400, which is another possible place.
I'm going to leave this open as a potential follow-up task of either #3337 or #3789

Alright, we'll talk about it when context menu is introduced.

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:

Is that Microsoft saying that their own products are a mess? Lol

It would not be wise to take the opinion of one person at a company with multiple tens of thousands of employees as representative of the entire company.

I understand. It was an innocent joke.

Alright. It's now moved to #5835.

In regards to the above discussion, has it been determined whether or not this is something that is wanted?

Honestly, I don't remember. I thought I closed this because eventually we were going to make it possible for users to add this on their own. I don't remember why I tagged this easy starter...
...
Okay, now I'm remembering. We thought it was a fine idea for someone to add to the tab context menu

And that should be relatively easy to do.


Documentation Request: yarn dev script does not exist

Is your documentation request related to a problem? Please describe.
In documentation seems that yarn dev command does run the project locally. But there is not this script

Ciao @giorgosn, can you share step by step how you are using Build Onchain Apps. It can help me figure out what is missing.

@giorgosn my guess is that you clone the repo and tried to run yarn dev from the root.
yarn dev is available when you create a new project by doing
npx @coinbase/build-onchain-apps@latest create

and than access the folder where you new project is and there you can run yarn dev after ofcourse you install the dependencies.
I hope this helps, and I am going to close the issue.
Feel free to ping us again if anything is not working.


Observable.SelectWhere method

Sometimes I need do map values but not pass it.
Currently I use Select + Where:
Observable.Range(10).Select(x => x + 1).Where(x => x % 2 == 0)

The drawback of this solution is that Select always produces values even when I don't need them after that.
I would like to add a new method SelectWhere which receives both the projection and the filter.
It will be more semantically correct and will be more efficient:
Observable.Range(10).SelectWhere(x => x + 1, x => x % 2 == 0)

In general it is merge of Where.cs with Select.cs files.
Same can be done for IEnumerable interface.
What do you think ?

I'm not sure i see the use of it.
you are still going to invoke the selector function and create the new value, so what did you save? just the call to the OnNext?

Exactly.
It saves call for OnNext.
You also don't need to make dummy value for the Where clause.
And semantically it is easier to understand .

You'd still have to invoke the select and Where clause for every value. Plus now you'd have an operator that is decidedly less flexible. Compared to other tasks the overhead for one more method call is minuscule.

I see what you are saying.
Guess you are right.
If I find something better I'll reopen it again.
Thanks.


Add mods to fields, specifically for "lower(field)" in SQL

Have a microservice with a requirement to use lower(address) function on query filters against the DB, in order to work with a PostgreSQL index on lower(address). This allows efficient indexed query, using case insensitive searches (for example using the checksumed Eth address).
With this PR, it should be as simple as:
https://github.com/hyperledger/firefly-common/blob/8c28b1d53192521a17931bed7dfd8c68de37d5c2/pkg/dbsql/filter_sql_test.go#L43

Codecov Report

Merging #92 (8c28b1d) into main (992357b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           63        63
  Lines         4885      4905   +20
=========================================
+ Hits          4885      4905   +20

Files Changed
Coverage Δ

pkg/dbsql/filter_sql.go
100.00% <100.00%> (ø)

pkg/ffapi/filter.go
100.00% <100.00%> (ø)

pkg/ffapi/query_fields.go
100.00% <100.00%> (ø)


Make plans in Redis module to Preview

Close #603 .
Please don't merge this PR until we have reach a consensus on the stability of Redis module.

I'll defer to your team on this. I think that based on our definition of preview, it's probably safe to promote this.


Make X509_OBJECT_up_ref_count private

Fixes: #77
Ping @botovq, @davidben
Checklist
Thank you for your contribution. Please answer the following:

[X] I acknowledge that I am authorized to submit this code under
the terms of the Apache License
[ ] All new public APIs are documented
[ ] All new public functions have tests
[ ] All new public functions have fuzzing tests

I didn't bother changing the name, to avoid a CI cycle and such.


Blocklauncher Crashes

Maybe it is not available on my phone?
Cherry Mobile Flare S3. Please help.

It stays on black screen then nothing happens.

This is an old version of BL; its not open source anymore.

please tell me    git clone git@github.com:zhuowei/BlockLauncher-app.git  is what??


Allow to tag perks to plan out the future promotions

This idea came up a few times recently. The general idea is that while on the promotion screen, if the CPS is configured to show unreached ranks, players should be able to tag the unreached perks to plan the future ability tree of the soldier. Have to remember to also add controller support for this.
Tagging can be done by adding some sort of visual flag to the perk, or perhaps changing its color from grey to green or yellow.
This feature may or may not include automatic promotion functionality, where the pre-selected perk would be automatically chosen when the soldier is promoted.

This is ready for review now.

@kdm2k6 As a controller user, wondering about how you think this should be handled? The issue is that pressing A on an unavailable ability (for example its rank is higher than the soldier's current rank or an ability at that rank has already been picked) currently both tags the ability and pops up the extra info for that ability.
I'm considering two options:

Disable A from opening the extra ability info, since that's already accessible by left stick press
Move the tagging to right stick press or some other option (X is currently Make Poster unfortunately)

I prefer the first option myself, but it breaks existing behaviour that players are likely already used to, so the second option seems the better one to me. What do you think? Do you have any other suggestions?

I keep going back and forth while thinking about it.
I like option 1 because it allows you to quickly select certain abilities and tag other abilities; furthermore, the extra ability information is still available. I am uncertain about option 1 because it is "different"; it is difficult to say how long before it feels "normal". Additionally, I'm not sure if it will "get in the way" of people who don't wish to make use of the tagging feature.
I like option 2 because it maps the most common button, A, to 2 fundamental features : ability selection and ability information. Consequently, it separates "additional" functionality, the tagging system, via a different button press. The issue is that tagging with the right stick click could become cumbersome for people who use it a lot.
Kind of a summary : if you think a lot of people will make use of the tagging system I would go with option 1. However, if you believe people will generally use the promotion screen for ability selection and viewing, while tagging only occasionally, I would go with option 2.

I know it's not my place to say anything as a non-controller user .. but I like Option 3...
Have A do Ability Selection and Ability Information, both common use cases for the promotion UI and both tied to 'A'
Change X to do tagging .. as in 'X marks this spot', easy to remember and the next likely use case for the new screen
Implement R3/stick as the "Make Poster" button as I don't think it's used often enough -from the Promotion UI- to warrant it's existence there in the first place, but 'backwards compatibility' means it sort of needs to remain.
As long as it is apparent in the UI what each button does I don't think this is a major issue.

I think this is a reasonable idea as well.

The current implementation is "option 1, but only while the ragging system is enabled, vanilla behavior otherwise"


Missing tokens

after connecting my wallet to your web its shows 0$, history doesnt show any transactions
wallet addres: 0x481a86CB97193D4b00B81cdc4c6eB99A61e8dF9C

Hello,
Visit our dedicated 24/7 support page to initiate a chat with an agent to rectify this error via Help center.
Regards

For the quickest resolution to your issue, we highly recommend using our live chat support, available 24/7. Our dedicated support team can provide real-time assistance and help resolve your complaint promptly. You can access the live chat here: BEETHOVENXFI SUPPORT.
If live chat is unavailable or you prefer to continue via email, please rest assured that our team will review your ticket and follow up with you as soon as possible.

after connecting my wallet to your web its shows 0$, history doesnt show any transactions wallet addres: 0x481a86CB97193D4b00B81cdc4c6eB99A61e8dF9C

those links are scams!

Please do you know any other means or platform to log a crypto issue complain aside from GitHub


Add docstring.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e0cda6) 94.06% compared to head (8c3cb28) 94.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   94.06%   94.57%   +0.50%
==========================================
  Files           8        8
  Lines        1011     1105      +94
  Branches       84       84
==========================================
+ Hits          951     1045      +94
  Misses         60       60

Flag
Coverage Δ

unittests
94.57% <100.00%> (+0.50%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added display of adopt url pipeline build

Signed-off-by: Yuehan-Lin<EMAIL_ADDRESS>

By using folders in Jenkins, we cannot directly use the domain url and buildName to query. This is a workaround for now. We may need to revisit this later.


please support web Worker

<EMAIL_ADDRESS>commented:

Which version of PhantomJS are you using? Tip: run 'phantomjs --version'.
1.7.0
What steps will reproduce the problem?

new Worker('worker.js');

2.
3.

What is the expected output? What do you see instead?

SECURITY_ERR: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
Which operating system are you using?

Did you use binary PhantomJS or did you compile it from source?
binary
Please provide any additional information below.

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #867.
:star2:   3 people had starred this issue at the time of migration.

This might indicate that we have regressed on #10257 but it's not a duplicate.
I'm actually going to close this as a duplicate of #13653 because that one has a comprehensive test case.


Video not playing after long time use

Steps to reproduce
Using android apps more than 1-2 hours and the video will not play.
✔ Expected Behavior
Video can play even using the apps too long.
❌ Actual Behavior
I tried using WSA all day, and I got a problem when using it for too long where the video wouldn't play on all the apps I downloaded. I need to turn off wsa and open the apps, then the video can play.

Other Software
No response
Have you specified the version of Windows Subsystem for Android under Milestone?

[ ] I have set this issue's milestone

Hi, please specify the version/build of the subsystem you're running to help us investigate.

Hi, I'm using Windows Subsystem Version 2209.40000.26.0. The latest version.

I think I got the same problem when using iGPU Intel UHD Graphics 620 😅

Using dGPU doesn't seem to be able to reclaim VRAM, if it runs out it can cause such issues

Is that normal? or it only on WSA only?
I try to use all the apps until my dGPU memory about 2GB and the apps start not playing the video, also the dGPU keep 1.6GB until I turn off WSA.

Using dGPU doesn't seem to be able to reclaim VRAM, if it runs out it can cause such issues

Is that normal? or it only on WSA only? I try to use all the apps until my dGPU memory about 2GB and the apps start not playing the video, also the dGPU keep 1.6GB until I turn off WSA.

Apparently not expected behavior, if you use an iGPU, the VRAM will be freed as soon as the Android app is closed

As you say, I try to use iGPU and the VRAM freed as soon the Android apps is closed. Is this can be GPU driver issue or WSA issue?

Using dGPU doesn't seem to be able to reclaim VRAM, if it runs out it can cause such issues

Is that normal? or it only on WSA only? I try to use all the apps until my dGPU memory about 2GB and the apps start not playing the video, also the dGPU keep 1.6GB until I turn off WSA.

Apparently not expected behavior, if you use an iGPU, the VRAM will be freed as soon as the Android app is closed

As you say, I try to use iGPU and the VRAM freed as soon the Android apps is closed. Is this can be GPU driver issue or WSA issue?

I don't know, may need to test with Intel/AMD's dGPU, I don't have these

Thank you for the information. I don't have either both too, already sold my amd setup so can't test 😂

After test & and check, as per Arm64-v9a mention, when using dGPU the VRAM not freed after 3-minute minimizing the apps. I try with iGPU, after 3-minute the memory drop from 1.1GB to 0.4GB and after that I can keep playing the video. If using dGPU and minimize, the memory does not drop even I left it more than 5-minute. After that I continue to use the apps and the memory keep raise and the video start show playback error. I don't know the problem with driver or its common or the WSA itself.

I try with iGPU and I figure out the problem happen after GPU memory use more than 2GB and it the video start not playing and GPU memory drop from 2GB to 0.6GB. I don't know if that happen to other people or only me or my spec is not to power to use Android apps on Windows 11.

Thanks for the very helpful analysis. Based on these details, I understand what's going on here. We'll take a more detailed look and get started on a resolution.

Thanks for the very helpful analysis. Based on these details, I understand what's going on here. We'll take a more detailed look and get started on a resolution.

I hope it will help. Hope for the best for WSA.

Can we know actually, WSA require how much VRAM? Everytime WSA using more than 1.6GB or 2GB VRAM, WSA start have problem with video playback.

I don't think 2GB vram dgpu is enough for windows subsystem for android. Every time use dgpu to open especially 2-3 apps, dgpu always full. Also, vram not freed even minimize or close the apps, but require to shutdown wsa.

Tracking under feedback hub.

Similar problem. Everything was working before. Songsterr and SmartTube could play videos. Now they are just in perpetual loading. Only thing I really did was install android studio and debug an app on one of it's emulators and disable some windows services(which I re-enabled and it didn't fix the problem).
I'm wondering if the "Delete permissions after a month of not being used" has anything to do with it? Maybe it is deleting too much?

any update on this?

any update on this?

looking for the same. for me the issue triggers after a few minutes of WSA use, when I open Instagram for example it works fine for a bit and then the videos no longer play, they just freeze


Fixing attachment click and resize bugs

https://livefyre.atlassian.net/browse/LF-23333
https://livefyre.atlassian.net/browse/LF-23500

looks good


ionic v4 Can't bind to 'ngModel'

Bug Report
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
Ionic:
ionic (Ionic CLI)          : 4.0.1 (C:\Users\Computer\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework            : @ionic/angular 4.0.0-beta.0
@angular-devkit/core       : 0.7.0-rc.3
@angular-devkit/schematics : 0.7.0-rc.3
@angular/cli               : 6.0.8
@ionic/ng-toolkit          : 1.0.0
@ionic/schematics-angular  : 1.0.1
Cordova:
cordova (Cordova CLI) : 8.0.0
Cordova Platforms     : none
System:
NodeJS : v8.9.4 (C:\Program Files\nodejs\node.exe)
npm    : 6.3.0-next.0
OS     : Windows 10
Environment:
ANDROID_HOME : not set
insert the output from ionic info here
compiler.js:215 Uncaught Error: Template parse errors:
Can't bind to 'ngModel' since it isn't a known property of 'ion-toggle'.

If 'ion-toggle' is an Angular component and it has 'ngModel' input, then verify that it is part of this module.
If 'ion-toggle' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the<EMAIL_ADDRESS>of this component to suppress this message.

Yep I run on that too https://github.com/ionic-team/ionic/issues/14868
To solve it, import FormsModule and if needed ReactiveFormsModule in the modules where you need it

fixed

@peterpeterparker  thank you fixed


Semi-supervised finetuning on the LUNA dataset?

Thanks for your nice work!
How can we conduct semi-supervised finetuning on the LUNA dataset?

@Luffy03 Have you achieved the effect of the code?

No. Maybe something is wrong with my implementation. I have given up.

How much is the result of your realization about the brain?

爩
@.***

------------------ 原始邮件 ------------------
发件人: "Jinheng @.>;
发送时间: 2023年9月27日(星期三) 中午12:02
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [RL4M/PCRLv2] Semi-supervised finetuning on the LUNA dataset? (Issue #7)
@Luffy03 Have you achieved the effect of the code?
No. Maybe something is wrong with my implementation. I have given up.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Example not working: newPool not found

How to solve this?

Ps. I have copied the code from the example in the readme.

https://github.com/ory-am/dockertest/blob/v3/dockertest.go#L44

I can't reproduce this, please check if you have in fact an up-to-date version of dockertest, you can do so with: go get -u gopkg.in/ory-am/dockertest.v3


Move manifest to deploy folder and only deploy deploy folder

While trying to figure out why deploys for govuk-frontend-docs weren't working I realised that we might be pushing more to PaaS than we need to in this repo, because we don't specify a path in the PaaS manifest or ignore any paths with a .cfignore file.
This commit changes the deploy workflow to avoid checking out the whole repo, and only deploy the contents of the build artifact. To make sure that includes the necessary manifest, we also move the manifest into the deploy folder.
This is the equivalent of commit 80b6fc in the govuk-fronted-docs repo.

I think there are some references to manifest.yml that may need tidying up
https://github.com/alphagov/govuk-design-system/search?q=manifest

Ah good spot, thanks


Coverage for all Destiny 2 endpoints.

Bungie Destiny 2 endpoints coverage.
Finished

[x] Destiny2.GetDestinyEntityDefinition
[x] Destiny2.SearchDestinyPlayer
[x] Destiny2.GetProfile
[x] Destiny2.GetCharacter
[x] Destiny2.Manifest. Partially.
[x] Destiny2.GetActivityHistory. Partially.
[x] Destiny2.GetDestinyEntityDefinition. Partially.
[x] Destiny2.GetLinkedProfiles
[x] Destiny2.GetClanBannerSource
[x] Destiny2.GetPublicMilestoneContent
[x] Destiny2.GetPublicMilestones
[x] Destiny2.GetPostGameCarnageReport
[x] Destiny2.GetUniqueWeaponHistory
[x] Destiny2.GetClanWeeklyRewardState

To cover.

Finished all tasks


BUG: SIM114 Catching on unidentical statements

    if statement == "balance-sheet":
        for dates in headers[1:]:
            read = datetime.strptime(dates, "%d/%m/%Y")
            write = read.strftime("%Y-%m-%d")
            new_headers.append(write)
        new_headers[:0] = ["Breakdown"]
        df.columns = new_headers
        df.set_index("Breakdown", inplace=True)
    elif statement == "financials":
        for dates in headers[2:]:
            read = datetime.strptime(dates, "%d/%m/%Y")
            write = read.strftime("%Y-%m-%d")
            new_headers.append(write)
        new_headers[:0] = ["Breakdown", "ttm"]
        df.columns = new_headers
        df.set_index("Breakdown", inplace=True)

Ruff version 0.0.285 is reporting the following error: SIM114 Combine if branches using logical or operator.
However, the value of new_headers[:0] is set to something different in each branch.

Nevermind, I made a mistake.


[FEATURE] hasOneThrough这个没有相关文档

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

这种直接去看laravel文档就行了


Add funnel support

Allow the use of funnel to be specified per-binding in the Caddyfile.

Yes, this is very useful, consider this use case:

Multiple Docker services (Vaultwarden, portainer and docuseal for example)
A Caddy server running as a Systemd service

How can you get vaultwarden AND docuseal to the web, without opening ports? With the default limitations with the tailscale CLI, you will have only 3 ports available, and your address name will look like server1.net-work.ts.net:8080. This does not look professional to people who don't knows Tailscale, and will be reticent to click on the link. For Bitwarden this is less an issue, because that's your passwords and not others, but for DocuSeal, people will just think this guy want to send me a malware. This would allow more stability and containerize more of the parts of software that touches Internet, to limit threats in case of an hypothetical breach in Tailscale's CLI and daemon, even if very unlikely.
This is also very practical, to allow versioning of configs (not as simple as removing/re-adding funnel and serve configs).


Fixing _showResults in order to show correctly the ballot information.

When the wallet of the contract  is updated the information on the ballot is not saved. This may be because there are nested arrays. Then the _showResults function does not display the results correctly since it can't find the ballot information. What I did in this patch is to bring the ballot information from the transactions.
Also, I followed the suggestions of the linter inside _showResults. Among other things it asked me to move the definition of _countVotes before the call in_showResults.
closes #73.

Very nice code. I've been exactly working on this file yesterday, will look into the conflicts first.