fix: to #157015 fix view label command localized

Fixes #157015

Awesome!
Looks like you do have a couple of issues still:
[tsec-compile-check      ] src/vs/workbench/contrib/scm/browser/scm.contribution.ts(115,2): error TS2322: Type 'string' is not assignable to type 'ILocalizedString'.
[tsec-compile-check      ] src/vs/workbench/contrib/userDataSync/browser/userDataSyncViews.ts(181,32): error TS2352: Conversion of type '{ id: string; name: string; ctorDescriptor: SyncDescriptor<TreeViewPane>; when: RawContextKey<boolean>; canToggleVisibility: true; canMoveView: false; treeView: TreeView; collapsed: false; hideByDefault: false; }' to type 'ITreeViewDescriptor' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[tsec-compile-check      ]   Types of property 'name' are incompatible.
[tsec-compile-check      ]     Type 'string' is not comparable to type 'ILocalizedString'.
[tsec-compile-check      ]
[tsec-compile-check      ]
[tsec-compile-check      ] Found 2 errors.
[tsec-compile-check      ] error Command failed with exit code 1.

From the CI

Awesome!
Looks like you do have a couple of issues still:
[tsec-compile-check      ] src/vs/workbench/contrib/scm/browser/scm.contribution.ts(115,2): error TS2322: Type 'string' is not assignable to type 'ILocalizedString'.
[tsec-compile-check      ] src/vs/workbench/contrib/userDataSync/browser/userDataSyncViews.ts(181,32): error TS2352: Conversion of type '{ id: string; name: string; ctorDescriptor: SyncDescriptor<TreeViewPane>; when: RawContextKey<boolean>; canToggleVisibility: true; canMoveView: false; treeView: TreeView; collapsed: false; hideByDefault: false; }' to type 'ITreeViewDescriptor' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[tsec-compile-check      ]   Types of property 'name' are incompatible.
[tsec-compile-check      ]     Type 'string' is not comparable to type 'ILocalizedString'.
[tsec-compile-check      ]
[tsec-compile-check      ]
[tsec-compile-check      ] Found 2 errors.
[tsec-compile-check      ] error Command failed with exit code 1.

From the CI

Thanks!
Now it is reasonable to say that all the processing has been completed.

(I think I should have handled all the compilation errors before. When I update the main branch code, some code may be restored due to automatic merging)

FYI we are currently in the middle of a release right now, so I want to hold off on getting this in til next week. That way we can let it sit in Insiders for a bit to make sure we don't cause any regressions due to the number of files changed. I think the PR is ready, but I'll approve and merge early next week.

@yiliang114 I hope you don't hate me for this but I just added a new thing that will make this PR much smaller and have less duplicate strings.
I have added a localize2 function in this PR that allows us to replace all of these:
{ value: nls.localize({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console"), original: 'Debug Console' }

with a much simpler:
nls.localize2({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console")

this function returns an ILocalizedString and handles the original string correctly.
Can you move over to using that so the code is easier to maintain and we don't need to have two of the same string next to each other?

@yiliang114 I hope you don't hate me for this but I just added a new thing that will make this PR much smaller and have less duplicate strings.
I have added a localize2 function in this PR that allows us to replace all of these:
{ value: nls.localize({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console"), original: 'Debug Console' }

with a much simpler:
nls.localize2({ comment: ['Debug is a noun in this context, not a verb.'], key: 'debugPanel' }, "Debug Console")

this function returns an ILocalizedString and handles the original string correctly.
Can you move over to using that so the code is easier to maintain and we don't need to have two of the same string next to each other?
I think this won't apply to everything in your PR but probably about 80-90% if the cases.

Haha, it looks better this way. Let me try again.

Please help me review the code again when you are free @TylerLeonhardt , I did not encountered an error  when I compiled locally.


Fix pandoc parameter.

It is --pdf-engine instead of --latex-engine.
Fixes: #773
Signed-off-by: Yang Bo<EMAIL_ADDRESS>

oh cool. I had recently looked into that, and also to try newer versions.
https://quay.io/repository/oci/pandoc?tag=latest&tab=tags
Might you try with one of these newer images from the image quay.io/oci/pandoc?

my pandoc is 2.2.1 . It  looks like the latest version.


Custom implementation of ICorsPolicyService

I've looked into the following documentations about custom implementation of ICorsPolicyService :
https://github.com/IdentityServer/IdentityServer4/blob/release/docs/topics/cors.rst
https://identityserver4.readthedocs.io/en/release/reference/options.html#cors
I created a custom class that implements ICorsPolicyService , but I don't know to register it in identityserver , and the documentation doesn't provide any samples on how exactly can I register custom ICorsPolicyService, it should be registered somehow before setting CorsPolicyName in IdentityServerOptions, right?

and the solution?


Age bins for VirusSeq export

The CanCOGeN-COVID19 template no longer appears to have the original age bins 90-99 and 100+.
We should revert to those bins in the base template and only have 90+ substituted in for the VirusSeq Portal export.
Confirmed with @griffie

I did make that change in google sheet but that can/should be reverted back.  Its not in DataHarmonizer itself now.  Just a pull request that I won't act on.

Is there a pull request? I didn't make one....

ah, i should have said branch!

OK. I've updated the template as follows:

I've tested this out and it works well.  It will be part of next release


New feature for update

I use zsh as my main shell, and I login via startx, so when I have the option to update day by day, when I boot the PC, I get a message prompting if I want to update oh-my-zsh, its really annoying, because I just want to startx and I don't have internet before login. Since I like to be updated, but dont like to be asked to update every time I start my computer, I asking if you could make an option to disable update message for example, the first time ZSH starts.
Thanks for this amazing framework, keep the good work :)

A login shell isn't going to be a sufficient test. Most shells that users fire up are going to be login shells. (This is the default for most terminal emulators I'm familiar with.)

Then maybe checking the value of tty (or $TTY). If it's not a pseudo-terminal don't prompt for update, or something like that.


Use bucketfs-python new SSL verification option

Background

Caused by https://github.com/exasol/ai-lab/issues/196
In https://github.com/exasol/bucketfs-python/releases/tag/0.9.0 we released a new option to configure SSL verification with bucketfs-python
The upload udf can't use it currently, because BucketFSFactory doesn't support it

Acceptance Criteria

[ ] SLC Deployer Lib supports it
[ ] SLC Deployer CLI supports it
[ ] Model Upload CLI supports

Done with https://github.com/exasol/transformers-extension/issues/236 and https://github.com/exasol/transformers-extension/issues/228


SoundHw in Qemu no longer works

Since Qemu 7, the -soundhw option has been removed. Now we need to use the new parameters. Please fix this in the README. Here's where I read it from:
https://computernewb.com/wiki/QEMU/Devices/Sound_cards

The README specifies its arguments are appropriate for Ubuntu 20.04, there is no issue with the README.

Now the makefile convenience targets, on the other hand...
Okay, so, annoying, while you can do -device AC97 and this works without having to specify a backend, I can find no way to enable the PC speaker without one. -device isa-pcspk does not work because only "pluggable device types" can be attached with -device; the option to -M requires an audio dev, and there is no 'default' one that can be referenced by name, so you have to make one, and making one with -audio or -audiodev requires a backend. Ultimately, this will probably just mean having the Makefile pick one based on the host platform - coreaudio for macOS, pa for Linux, but it's still annoying.
It also seems like the QEMU devs intend to remove the idea of a "default" audio backend entirely, so in 9.x or 10.x there may be no option but to take a guess at what audio backend might be available...
This sort of removal of options that make it feasible to use the same command line across multiple environments is quite frustrating.


Allow multiple stylesheet

something like:
webfont: {
    options: {
        stylesheet: ['css', 'scss']
    }
}

at this moment the only way i found to make it happens is generate icons two times with completely same config except needed stylesheet

It would be great! +1

I've created a PR that implements this: https://github.com/sapegin/grunt-webfont/pull/349


Output to png ?

If this could output to png it should make it easy to check against reference renders (e.g. by Cairo + future web browsers)

Outside scope of this project.
librsvg2 has tools to convert SVGs to PNGs (however this polyfill won't help in that conversion)
One way to render PNG of the SVG running this polyfill is to load it in browser and print it from there. A separate JS library could be written to render such SVG on a html5 canvas and then save it as PNG/JPEG. But it doesn't belong to this project.


[webapi] Sync webgl-py consistent with webgl

Impacted TCs num(approved): New 0, Update 15196, Delete 0
Unit test Platform: WTS for Chrome 41.0.2272.118
Unit test result summary: Pass 15161, Fail 33, Blocked 2
https://crosswalk-project.org/jira/browse/XWALK-4507

Merge as-is. Sometime in future, we'll clean up these tests which cannot be submitted to upstream.


Add Mermaid Diagrams to Supervisor strategies

I didn't find how to add the little arrows from Erlang's documentation with the restart and termination order:

Sorry, I just saw that you mentioned another issue with the Mermaid one.
I will take a look too!

I just thought about that but I guess it would be better to move the diagram later in the Livebook, each one with the strategy example with the bomb?

This is awesome! I think this is an improvement so I'd love to merge it in.
There's a failing test though, you can run mix format_headings, and I think it should resolve the issue.
In a future PR We could use Kino.Process to visualize the supervisor tree with the bombs but that's something I'll take a look at when I have some time. For now I think this is an excellent addition. Thank you!

Thanks! <3

🚀🚀🚀


Support for Configurable contrail-dns for v2.1

When upgrading to v2.1 contrail, contrail deploys bind, this conflicts with the existing dnsmasq which we use for consul. Hence to avoid this, we are going to use two approaches, 1. disable contrail-dns by default as we are not using the service now, 2. we are going to add a config to the existing dnsmasq to forward dns traffic based on VM_domains to contrail-dns when enabled.

@sorenh any comments about this? Do you think it's worth worrying about?

What happens if we just don't deploy contrail-dns?

@sorenh that is the behavior that is being proposed, but there is additional code that keeps dnsmasq on port 53 and has it forward to bind on another port


Limit users on free plan to 100 messages

Details here: UX and backend to limit user messages on free plan

Dependencies
This PR can be merged as is but will be ineffective. The limit check always returns true (can send message) at this time. The real check can be done when the new Plan / Subscription objects are merged, cc @daph
Also, the "Check our plans" button in the figma is replaced for now by a "Contact us" => needs to be updated when we actually have a Plans page :)
3 "TODOs" with the code changes are in the PR, to be replaced when dependencies allow
Product notes
cc @gabriel @Duncid (also added that to the card)

Behaviour: Let the user type a message, then see they reach the limit. IMHO This creates drive to pay (vs showing it directly, and user does not even try to type a message): the desire to get the answer to the question they took time writing is a final nudge to conversion

this is a case of "good frustration"

only count succeeded messages (not cancelled, failed or erred). There could be a debate over cancelled messages since it can be abused by those who know beforehand that the plan will stop at 100 messages; at this time I think we should bias to generosity on these little things which can create attachment and do free marketing for a while
The 100 message limit is based on generated messages, i.e. when the user has generated 100 assistant replies

vs 'has sent 100 messages' (message to multiple assistants would count once)

Technical notes

The count is made via an SQL query on conversations => already indexed. Since max 100 messages to count, it should be very fast.

Follow-up
A few elements that are not critical to this PR that needs to be merged fast, but that can be done in a subsequent PR

replacing the constant FREE_PLAN_LIMIT in plan.ts by a field in the Plan object, like the maxWeeklyMessages
sparklizing the LimitReachedPopup component -- TBD with @Duncid on reuse needs
TBD load test on sql query although I'm pretty confident

**Tests: Latency < 4ms"
Seen from a few select counts on our prod db on recent workspaces with ~50-500 conversations
The query is the exact sequlize query run by the code (had it logged)


ETA release?

Any ETA for the release of MyBB2?

It will be ready when it's ready.

On 8 Feb 2017, at 07:41, Mark Topper<EMAIL_ADDRESS>wrote:
Any ETA for the release of MyBB2?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Any ETA for the release of MyBB2?

The project has been open publicly since 2011, only about 8 years have passed.
If they continue to work with this methodology, without doing tests before, i think never, seriously.


Add impersonation option to e2e tests

It allows to impersonate a different service account to verify quota issues. See b/336784945#comment12 for more details.
Bug: b/336784945

/lgtm

/lgtm
/approve


[BUG]: prerelease missing sha256 checksum

What happened?
SHA256 checksum to be generated and uploaded.
Workflow: https://github.com/WLAN-Pi/pi-gen/actions/runs/11520416873/workflow
Result:

Relevant log output
N/A

How often does this bug happen?
Every time
What version are you using?
Latest
Self Service

[ ] I would be willing to fix this bug myself.

Guidelines and Policies

[X] I have read the contributing guidelines and agree to follow the code of conduct and contribution policies.

Looks like we may just need to update the "Create Pre-Release" step.

This is fixed by #62.


.editorconfig settings not working

Gitea version (or commit ref): 1.3.3
Git version: N/A
Operating system: Windows/OS X
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[x] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No (It's down)
[ ] Not relevant

Log gist: N/A

Description
.editorconfig settings are not being honored anymore. For example, insert_final_newline = true is not inserting a final new line in Gitea's own .editorconfig file.
Also confirmed that trim_trailing_whitespace = true is not trimming anything on my personal files.
https://github.com/go-gitea/gitea/blob/master/.editorconfig

Invalid, human error.


validator: report missing NM plugin during validation

Now it is possible to get the plugin capabilities from the NM client.
Nmstate is reporting the missing NetworkManager plugin during the
validation instead of during profile activation.
Ref: https://bugzilla.redhat.com/1785160
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

Coverage remained the same at ?% when pulling 02a2b3c72b72e78fcbc636b0a9b4dceacc512efc on ffmancera:plugin_verification into ab32ef988074876b0b663d1003bd98fbb39b8404 on nmstate:master.

Coverage remained the same at ?% when pulling 02a2b3c72b72e78fcbc636b0a9b4dceacc512efc on ffmancera:plugin_verification into ab32ef988074876b0b663d1003bd98fbb39b8404 on nmstate:master.


Add support for a configuration file

The command line call gets more and more cluttered, esp. with the addition of the dns solver and its wide variety of configuration through environment variables.
Wouldn't it be nice to have a structured configuration file to specify the options?

You mean like wss:// in the client and then proxy to a websocket backend? Assuming the websocket app is listening on localhost:1234:
example.com

proxy /websocket_path localhost:1234 {
    websocket
}

Did I miss this example in the docs?

AFAIK this CLI tool is supposed to stay simple, and using a configuration file makes it easier to make it complicated.

ok - fair enough.

Hm. I don't know. I fully understand that you want to keep this simple, but I have a s**t load of (sub-)domains right now because LE doesn't support wildcard certificates at the moment. This might change in the future with the DNS challenge, but for now it doesn't work. Currently I use the normal LE client, but I really don't like it and would love to use lego but this kind of keeps me from doing it, as adding / removing domains per command line is going to be really cluttered.

@mholt cool! Started watching so that I can stalk it :stuck_out_tongue_closed_eyes:

@mholt any progress? :3

No, will work on it later this year. First priority is some Caddy stuff...

@lenovouser We might get a config file for lego after all. The new CLI library the next version will use does have this for free.

Is there any news on this topic? I liked the acme-client configuration syntax showed here…


Fix minor disk block retrieve seeker 'accessed' race

This change fixes a minor race to read the 'accessed' field of a seeker by the seeker open/close loop that garbage collects open seekers and opens seekers ahead of time to newly flushed blocks.
cc @xichen2020 @cw9 @prateek @ben-lerner

Coverage decreased (-0.05%) to 76.947% when pulling 86d45e24dda7cb9c5cf467aed81431b60859a28c on fix-minor-disk-block-retrieve-race into fcc16a52249beda64f0283301f93fa3abd84da53 on master.


loss when fcn converges

Hi,
I tried to build me own fcn, but it seems that loss I can get after fine tune is still around 1.1k for 512X384 images. So could anyone tell me the loss you got when the cnn converges?
Many thanks.

Hi, which FCN are you trying to train ?
We have the same problem in our team. We are trying to train FCN-8 on Pascal VOC 2012 dataset, but the loss stays extremely high and we have no clue why.
See the full description of the problem here :
https://groups.google.com/d/msg/caffe-users/3eIMYV0OlY8/W-J1MQsvDgAJ

Hi @joh17 , sorry I'm afraid I cannot help much, since I purely used C++ for training and prediction, as I need to integrate fcn into my own project. Actually I found that for our problem (binary segmentation, 512X384 image), when loss ~ 1.1k the training seems to be almost perfect already. Besides, I tried to use U-net (http://lmb.informatik.uni-freiburg.de/people/ronneber/u-net/) instead of FCN-8/16. In U-net the "fuse" layer is replaced by a Concatenate and a convolutional layer, which leads to better results in some cases according to my own experience.

Closing since the future branch is now deprecated; the relevant functionality has been merged to master.
Check out the fcn.berkeleyvision.org repo for master editions of the reference networks, weights, and code for learning, inference, and scoring.


HSEARCH-4023 Expose the total hit count in scroll results

https://hibernate.atlassian.net/browse/HSEARCH-4023

@yrodiere Thanks for the review. I think I've applied all the changes, with the exception of the one described here: https://github.com/hibernate/hibernate-search/pull/2408#discussion_r507635439.
Let me know if you agree with merge it.

Merged, thanks

Thanks!


Add CTA to modal in BW

Proceed

Done,
Changed the Next Button title/text
CC - @Deveshshankar

We decided to change on all modals can see only on one cc @akshay8551 @cakesoft-shashank

Completed


software untested

All of this software isn't tested

At least as a preliminary test, it builds in both ROS Dashing and ROS Foxy just fine!

At least as a preliminary test, it builds in both ROS Dashing and ROS Foxy just fine!

@JWhitleyWork WHen I try to build it in ros galactic I get an error requiring deep_orange_msgs package which has some  custom msg types I can't seem to find this package anywhere. Please help

Can this be updated for humble or iron? Foxy is EOL as of June 20th, 2023.  Galactic was not an LTS so it's already deprecated.

New Eagle currently has no firm plans to upgrade past Foxy; if/when we do, it will be to a long-term distro. To increase the priority on this issue, you are welcome to contact Sales at<EMAIL_ADDRESS>


Log is file is empty under Mac OS X if running app from Applications folder

EasyLogging can't write to log file under Mac, if the app is build and installed into the standard Applications folder.

If I use "open" command, the bug is reproduced. As example:
open ./example.app


chore: updates dependencies

What
chore: updates dependencies

:tada: This PR is included in version 0.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Scrolling through snippets doesn't update drag handle quickly

Describe the bug
When scrolling through snippets in the toolbox in Javascript, the little handle on the right doesn't update to the block that the mouse is hovering on until the mouse moves
This handle:

The behavior:

To Reproduce
Steps to reproduce the behavior:

Go to the Javascript editor
Open the toolbox
Hover over a snippet
Scroll up and down
The handle will scroll away :(

Expected behavior
The draggable handle is always attached to the block we are hovered over
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
arcade version:  0.18.15
Microsoft MakeCode version:  6.1.28

No plans to fix this in near future


Extend API data returned in by pwmetrics

After starting PWMertrics run, users are able to get data adapted and retrieved from Lighthouse.
What if users might need to process expectations vs real results?
Should we extend API with returned data included expectations mixed with real metrics values?

I've asked on twitter and couple people were interested. Other than that I think it will be handy to handle expectation erros manyally, probably stop CI process (since we don't throw exeption if expectations failed) or do smth other.
So I propose to extend object with result data and have smth like this:
'runs': [
    {
      'timings': [
        {
          'title': 'First Contentful Paint',
          'id': 'firstContentfulPaint',
          'timing': 3389,
          'color': 'green',
          'expectations': { // might be empty if not specified
            'timings': {
              'warn': '>=1500',
              'error': '>=2000'
            },
            'result': {
              'warn': true,
              'error': false,
            }
          }
        },
....


When migrating to .NET Core 5, what changes need to be made in Azure Portal?

After migrating our functions app, I'm planning to deploy the new version tomorrow.
Do I need to change anything in Azure Portal? I was a little surprised that there isn't a new Runtime Version for ~5, or something like dotnet-isolated.
This is what I'm seeing:

I noticed in the sample app, in local.settings.json, there is "FUNCTIONS_WORKER_RUNTIME": "dotnet-isolated"... I assume I need to update the corresponding environment variable.
I also see some old environment variables that, not sure if I need these or if any changes are required:

FUNCTIONS_EXTENSION_VERSION is set to ~3 - do I need this?
WEBSITE_CONTENTAZUREFILECONNECTIONSTRING - no idea what this is.
WEBSITE_CONTENTSHARE - no idea what this is.
WEBSITE_NODE_DEFAULT_VERSION is set to ~12. Do I need this since I'm not doing anything with Node?

Please let me know if I'm missing anything else important. Or if there is an up-to-date migration guide. I definitely have a few old / misleading ones!

No response so I bit the bullet and deployed this.
Worth noting that FUNCTIONS_EXTENSION_VERSION automatically updated to dotnet-isolated.
Not 100% sure this is working, still have some testing to do. There is one alarming thing: during deployment all my functions say "No Trigger Found" which seems like a problem.


Solved error in travis.yml

The error was because the google recently renamed the ABIs as mentioned in the following issue
https://github.com/OneBusAway/onebusaway-android/issues/720
I have made the following changes

Upgraded AndroidTarget and AndroidToolBuild to 24.
No manual test being run hence emulator not required (removed emulator). Which has reduced the build time drastically.
Removed connectedCheck test because without an emulator there is no point of running the test.
Added assembleRelease to check if unsigned APK is being generated or not.

@mariobehling @the-dagger
please check the PR.
I have updated the travis.yml to solve the issue mentioned in PR #794 and issue #795.

@free4murad There are conflicts in travis.yml, can you resolve them so that I can merge the PR.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:23: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:26: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:35: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:44: http_url: http://treq.readthedocs.io/ is not https
WARNING: /tmp/abs_6433c6v2pc/clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
Errors were found


Focussed symbol is very subtle

Testing #54935
Focussed symbol is very subtle

Given that non-focussed symbol icons are very prominent, it is hard to see the focused element.
When ... is focused, it is very hard to see that it is.

May be some thoughts:

Using Background colour
Draw outline rectangle
Same colour as title for focused symbol (Not sure how much it helps for ... case)

/duplicate of  #54745


TextPainter.getPositionForOffset reports incorrect multiline positions for web

Steps to Reproduce

Run the code below app as a flutter web app.
Tap the text. Text character positions are reported correctly for the first line, and incorrectly for the second or later lines of wrapped text.
Works incorrectly on web, but correctly on mobile.

import 'package:flutter/material.dart';

final loremIpsum =
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.";

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Welcome to Flutter',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Welcome to Flutter'),
        ),
        body: Center(
          child: Container(
            width: 350,
            color: Color.fromARGB(100, 0, 0, 0),
            child: SelectText(),
          ),
        ),
      ),
    );
  }
}

class SelectText extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    //    return redbox();
    // Set width to max allowed by parent
    return LayoutBuilder(
        builder: (BuildContext context, BoxConstraints constraints) {
      final textPainter = TextPainter(
        text: TextSpan(text: loremIpsum),
        textDirection: TextDirection.ltr,
      );

      final width = constraints.maxWidth;
      textPainter.layout(
        minWidth: 20,
        maxWidth: width,
      );
      final height = textPainter.height;
      GlobalKey key = GlobalKey();

      return Container(
          key: key,
          width: width,
          height: height,
          color: Colors.yellow,
          child: GestureDetector(
            onTapDown: (details) {
              print(
                  "Selection: ${textPainter.getPositionForOffset(details.localPosition)}");
            },
            child: CustomPaint(
              size: Size(width, height), // Parent width, text height
              painter: TextCustomPainter(textPainter),
            ),
          ));
    });
  }
}

class TextCustomPainter extends CustomPainter {
  TextPainter textPainter;

  TextCustomPainter(this.textPainter, {Listenable repaint})
      : super(repaint: repaint);

  @override
  void paint(Canvas canvas, Size size) {
    textPainter.paint(canvas, Offset(0, 0));
  }

  @override
  bool shouldRepaint(CustomPainter old) {
    return false;
  }
}

Target Platform: Web
Target OS version/browser: Ubuntu 18 LTS
Devices: ChromeOS
Logs
Performing hot restart...
Reloaded application in 1,381ms.
# Tapping the first line of text
Selection: TextPosition(offset: 1, affinity: TextAffinity.downstream)
Selection: TextPosition(offset: 3, affinity: TextAffinity.downstream)
Selection: TextPosition(offset: 9, affinity: TextAffinity.upstream)
Selection: TextPosition(offset: 37, affinity: TextAffinity.downstream)
Selection: TextPosition(offset: 43, affinity: TextAffinity.downstream)

# Tapping line 2,3,4... values should be higher than the first line.
Selection: TextPosition(offset: 1, affinity: TextAffinity.downstream)
Selection: TextPosition(offset: 2, affinity: TextAffinity.upstream)
Selection: TextPosition(offset: 2, affinity: TextAffinity.upstream)```

Flutter doctor output:
[✓] Flutter (Channel master, v1.10.15-pre.305, on Linux, locale en_US.UTF-8)
    • Flutter version 1.10.15-pre.305 at /home/sir/development/flutter
    • Framework revision 01dc19b93f (7 days ago), 2019-10-28 19:58:06 -0700
    • Engine revision 49971e2140
    • Dart version 2.6.0 (build 2.6.0-dev.8.2 5e39817ec7)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/sir/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /home/sir/Android/Sdk
    • Java binary at: /home/sir/soft/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /home/sir/soft/android-studio
    • Flutter plugin version 40.2.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.2)
    • IntelliJ at /snap/intellij-idea-ultimate/181
    • Flutter plugin version 40.2.4
    • Dart plugin version 192.7402

[✓] Connected device (3 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64    • Android 10 (API 29) (emulator)
    • Chrome                       • chrome        • web-javascript • Google Chrome 76.0.3809.132
    • Web Server                   • web-server    • web-javascript • Flutter Tools

• No issues found!

Paragraph builder has the same issue. Updating title to reflect the cause.
import 'package:flutter/material.dart';
import 'dart:ui';
import 'dart:ui' as ui;

final loremIpsum =
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.";

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Welcome to Flutter',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Welcome to Flutter'),
        ),
        body: Center(
          child: Container(
            width: 350,
            color: Color.fromARGB(100, 0, 0, 0),
            child: SelectText(),
          ),
        ),
      ),
    );
  }
}

class SelectText extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    final TextStyle style = TextStyle(
      color: Colors.black,
    );

    // Set width to max allowed by parent
    return LayoutBuilder(
        builder: (BuildContext context, BoxConstraints constraints) {
      final ui.ParagraphBuilder paragraphBuilder = ui.ParagraphBuilder(
          ui.ParagraphStyle(
        fontSize: style.fontSize,
        // There unfortunelly are some things to be copied from your common TextStyle to ParagraphStyle :C
        fontFamily: style.fontFamily,
        // IDK why it is like this, this is somewhat weird especially when there is `pushStyle` which can use the TextStyle...
        fontStyle: style.fontStyle,
        fontWeight: style.fontWeight,
        textAlign: TextAlign.justify,
        //maxLines: 25,
      ))
        ..pushStyle(style
            .getTextStyle()) // To use multiple styles, you must make use of the builder and `pushStyle` and then `addText` (or optionally `pop`).
        ..addText(loremIpsum);

      final width = constraints.maxWidth;
      final ui.Paragraph paragraph = paragraphBuilder.build()
        ..layout(ui.ParagraphConstraints(width: width));

      paragraph.layout(ParagraphConstraints(
        width: width,
      ));
      final height = paragraph.height;

      return Container(
          width: width,
          height: height,
          color: Colors.yellow,
          child: GestureDetector(
            onTapDown: (details) {
              // BUG. On web- position is only correct for first line.
              print(
                  "Selection: ${paragraph.getPositionForOffset(details.localPosition)}");
            },
            child: CustomPaint(
              size: Size(width, height), // Parent width, text height
              painter: TextCustomPainter(paragraph),
            ),
          ));
    });
  }
}

class TextCustomPainter extends CustomPainter {
  Paragraph paragraph;

  TextCustomPainter(this.paragraph, {Listenable repaint})
      : super(repaint: repaint);

  @override
  void paint(Canvas canvas, Size size) {
    canvas.drawParagraph(paragraph, const Offset(0, 0));
  }

  @override
  bool shouldRepaint(CustomPainter old) {
    return false;
  }
}

/cc @mdebbar

Possibly related to https://github.com/flutter/flutter/issues/45020

Duplicate of https://github.com/flutter/flutter/issues/39826


Unexpected behavior of skip().

I have resided to rewrite my test using skip() inside of before().
describe(Comparison... `, function() {
xmlFilesInDir.forEach(function(file) {

	var docId = path.basename(file, '.xml');
	var eResponse;
	var mResponse;

	before(`Get data for ${docId}`, function() {
		var self = this;
		return helper.getEventsByDocId(docId).then(function(eRes) {
			if (eRes.status !== 200) {
				console.log(`Document id: ${docId}. Get Document\'s Events(s). Expected HTTP status 200 but was received ${eRes.status}. Test is skiped.`);
				self.skip();
			}
			eResponse = eRes;
		}).then(function(){
			return helper.getMetadataByDocId(docId).then(function(mRes) {
				if (mRes.status !== 200) {
					console.log(`Document id: ${docId}. Get Document\'s Metadata. Expected HTTP status 200 but was received ${mRes.status}. Test is skiped.`);
					self.skip();
				}
				mResponse = mRes;
			});
			});
	});

	it(`Document id: ${docId}. Should...`, function(done){

		done();
	});

});

});`
Where xmlFilesInDir = ["1.xml", "2.xml"] and I expect that test for 1.xml will be performed, but for 2.xml will be skipped.
But in execution I found that the Mocha are skipped the test for both documents:
Comparison...
Document id: 2. Get Document's Metadata. Expected HTTP status 200 but was received 404. Test is skiped.
- Document id: 1. Should...
- Document id: 2. Should...
If there is something that I forgot to add or the issue is not related to Mocha just let me know.

Each before is run before the whole suite and applies to the whole suite, so when you call skip in any before it sets the whole suite to skipped. If I'm understanding correctly, you want to associate specific befores with specific tests? Mocha doesn't currently have a hook for that (although it does have a beforeEach that will run before every test instead of only once for the whole suite, but again, not test-specific beforeEach functions). You can, however, either move the before logic into the start of the test itself (since calling skip works fine inside tests too), or create nested suites that only contain one test each (and in which before and beforeEach are equivalent, either will run just once before the suite's one test).

Thank you for answering my question.
It's my fault, next example more understandable:
var should = require("should");

describe('Test', function() {
  var tests = ["1.xml","2.xml","3.xml"];

  tests.forEach(function(test) {

	before ('Before test' + test, function() {
		if (test.indexOf('2') > -1) this.skip();
	});
	it('test1', function(done) {
	  done();
	});
	it('test2', function(done) {
	  done();
	});
	it('test3', function(done) {
	  done();
	});
  });
});

I want to run the test suite for each value from the array if this value meets a certain logical value, but if not then skip run the test suite. In other words tests 'test1', 'test2', 'test3' should be executed for "1.xml" and "3.xml", and skipped for "2.xml". But by some reason all execution are skipped.
d:\dir>node node_modules/mocha/bin/mocha --version
3.1.2

d:\dir>node node_modules/mocha/bin/mocha test.js

  Test
	- test1
	- test2
	- test3
	- test1
	- test2
	- test3
	- test1
	- test2
	- test3

  0 passing (44ms)
  9 pending

Aaaaah, ok -- the problem is you're only creating one suite total, not a suite for each .xml entry, so your before condition skips that one whole suite rather than just the suite for that specific .xml (because there is no suite just for that specific .xml). You want this:
describe('Test', function() {
  var tests = ["1.xml","2.xml","3.xml"];

  tests.forEach(function(test) {
    describe(test, function() {
      before (function() {
        if (test.indexOf('2') > -1) this.skip();
      });
      it('test1', function(done) {
        done();
      });
      it('test2', function(done) {
        done();
      });
      it('test3', function(done) {
        done();
      });
    });
  });
});

(The important thing here, btw, is the describe inside the forEach, not what's in any of the names; Mocha only uses the names of suites, tests and hooks in printing the results, not for any association between them.)

OMG, how I missed it. You are right in 100% percent. Thank you for helping me.
Definitely, it is not an issue.

👍 You're welcome! Glad we got it figured out.


Apps reports succesful upload, but no files appears on server

Debian Wheezy + nginx + PB server-php. No error in any place reported, photos gets uploaded, but I don't see any actual files to appear on the server side. How can I debug this situation?

That’s odd. I really thought I covered all edge-cases.

How can I debug this situation?

Maybe check the nginx access logs. I do not have a lot of experience with nginx administration. This  minimal implementation does not offer any debugging options and you would have to write it yourself.
What version of PHP are you running?
I should probably add a logger into this. Probably something PSR-3 compatible. But no clue when I will have time to do that.

nginx logs are clean.... nothing suspicious. PHP 5.6.19. Yeah, would be glad to get any ability to find out what is going on...

nginx logs are clean.... nothing suspicious. PHP 5.6.19.

That should all be fine. How annoying. Now I am annoyed. Will probably open a branch tomorrow and just put in a copy of the current server implementation but with log file writing. I’ll mention you when it is up so you can give it a test.

@fliker09: I have just published a logging branch. Could you check it out and see what its logging turns up? It should be making a log entry at every step.
https://github.com/PhotoBackup/server-php/tree/temp-logging

Thank you for your efforts! I didn't get the log, but it was a good hint that something is wrong with permissions (which I thought are totally OK). And I finally found it - problem was on 2 levels up! Photos are happily uploaded :)

That's weird. If the target folder has permission issues that should really be picked up by my over-the-top checking and the server should respond with an error to the client. Maybe that is a client bug. Might require more testing, but glad you figured it out!

It's all logical - log couldn't be written because... no permission! But yeah, it was unpleasant that it couldn't be caught by app


Change my Figure 14, 15 plot scripts to default to a location for copying script

This is done for plot_memory_model.py in memory_model branch and will be merged once #6 is done.
This is done for plot_stream_overhead.py in artifact_cleanup.


abaplint: ABAP keyword shall be upper case

introduces policy from #6

abaplint findings for upper/minor case are solved. So we close the PR. Other abaplint issues will be considered in future PRs.


Reduce operator

Implementation of the reduce operator. For this purpose, I also managed to dissociate empty from nil values by creating a so-called Optional container because I believe it was important to do so (that's the philosophy of other libraries like RxJava for example).
Meanwhile, there's a new type OptionalObservable <-chan optional.Optional.

Pull Request Test Coverage Report for Build 146

0 of 40 (0.0%)  changed or added relevant lines in 2 files are covered.
233 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-28.6%) to 50.631%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

observable/observable.go
0
20
0.0%

optional/optional.go
0
20
0.0%

Files with Coverage Reduction
New Missed Lines
%

observer/observer.go
1
72.5%

observable/create.go
2
80.77%

observable/flatmap.go
2
100.0%

subscription/subscription.go
3
100.0%

errors/errors.go
9
100.0%

handlers/handlers.go
15
100.0%

observable/observable.go
201
98.2%

Totals

Change from base Build 141:
-28.6%

Covered Lines:
361

Relevant Lines:
713

💛  - Coveralls

As I expected, I'm getting the exact same problems than https://github.com/ReactiveX/RxGo/pull/78 or https://github.com/ReactiveX/RxGo/pull/77. I feel like something was broken before.

See https://github.com/ReactiveX/RxGo/pull/95


Flannel network deployment issue

Setting up CNI fails on big clusters that have their Ethernet interface names different from the ones on the master node. Symptoms include canal pods not being ready in K8s CLI output.
The problem is caused by export IFACE command in setup_master_node.sh. The DaemonSet interface uses this env. var.

@cvetkovic does the problem still stand?

Solved by this commit, but just on hy branch.

ok, let's keep it open until #594 is merged.


Support for componentjs

Do you planning to include support for componentjs https://github.com/componentjs/guide ?
I added pull request (https://github.com/janl/mustache.js/pull/393) with minimal support for this package manager.

Closed since there's no longer interest on this.


Syndicate Wall Lockers and Secure Storage

About the PR
Adds Syndicate Wall Lockers and Secure Syndicate Crates
Changes "Armory Lockers" locked variant to be locked. (more details below)
Why / Balance
I needed Syndicate wall lockers and felt it was easier to send them upstream. On my journey, I realized there were a few issues along with more potential. This means lockers that look "locked" are actually locked to the Syndicate.
I felt it was necessary to change the name Armory Locker to Blood-Red Lockers since it could be misleading and confusing for newer mappers to think it is a locker meant for the armory. Now it's not to say one can't be remodeled to be used in the armory but the "Locked" variant is meant for Nuclear Agents. It also doesn't state it is a "syndicate locker" just that it is just "blood-red"
Technical details

Added Syndicate Wall Lockers
Added Secure Syndicate Crates
Changes "Armory Locker" to "Blood-Red Lockers"
Makes Blood-Red Lockers locked to "Syndicate Agents" and Nukie variant locked to "Nuclear Operatives"
Slightly changes the Blood-Red Locker's texture

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes
Could create some issues in maps if any uses the Blood-Red lockers
Changelog
🆑

add: Syndicate Wall Lockers and Secure Crates have been added! Mappers Rejoice!
tweak: Armory lockers have changed name to Blood-Red Lockers and locked variants are now actually locked behind syndicate access.

iirc some maps MIGHT have armory lockers mapped as station equipment, might be best to not change the actual armory locker

iirc some maps MIGHT have armory lockers mapped as station equipment, might be best to not change the actual armory locker

Most armories use the non-locked version; also as said it is a pretty simple fix of merely changing the locker name and or replacing with the non-locked variant. It was always meant to be the Syndicate locker and is designed in every which way mechanically to be so such as on salvie wrecks where it has Syndicate loot tables.


Active crashes when trying to zap passive from cluster

This is observed sporadically from ehcache tests when passive is trying to join cluster with dirty db or after network partition. Here is the exception.
2017-03-30 21:35:44,649 WARN - Requesting node to quit : NodeID : NodeID[localhost:9610] Error Type : Two or more Active servers detected in the cluster
2017-03-30 21:35:44,652 WARN - Requesting node to quit : NodeID : NodeID[localhost:9610] Error Type : COMMUNICATION ERROR
com.tc.exception.TCRuntimeException: Uncaught exception in stage
at com.tc.async.impl.StageImpl$WorkerThread.run(StageImpl.java:206)
Caused by: java.lang.NullPointerException: object is null
at com.tc.util.Assert.assertNotNull(Assert.java:144)
at com.tc.util.Assert.assertNotNull(Assert.java:153)
at com.tc.services.LocalMonitoringProducer.handleRemoteAdd(LocalMonitoringProducer.java:198)
at com.tc.l2.handler.PlatformInfoRequestHandler$1.handleEvent(PlatformInfoRequestHandler.java:73)
at com.tc.l2.handler.PlatformInfoRequestHandler$1.handleEvent(PlatformInfoRequestHandler.java:58)
at com.tc.async.impl.StageQueueImpl$HandledContext.runWithHandler(StageQueueImpl.java:502)
at com.tc.async.impl.StageImpl$WorkerThread.run(StageImpl.java:192)

How often does this happen and can you describe other aspects of the deployment (how many servers, how many clients, how far into a run, etc)?

PR #535


Code Refactoring

Thanks for the inspiring library and the Blog. I found many things in the code which might done better, so I worked on it.
Better variable names, Doxygen style documentation, functions which can deleted, and deleting most of the this-> stuff which is not needed ...
I tried to separate the .h file into a .h and a .cpp file but with no luck, it seems this a problem with templates I have to investigate.
Feel free to overtake (some) changes.
The refactored lib is attached, with an example for Mega.
NextionX.zip

Thank you very much for that! I looked quickly over your variant - it seems to me that all the debug stuff is missing. And you created doxygen tags for methods which are only temporarily public in this interim release but which are intended to be protected or private in later releases. That’s why in my manual documentation, some are intentionally not mentioned. I have in the meantime added (but not yet fully tested and thus not yet published) a bunch of new functions to read attributes back from Nextion components into the MCU, asynchronously (not blocking), so I can consider your optimizations only at a later moment.
Although I admire everything which is made better as my code, we have to respect the multi-platform compatibility, everything has to compile in C++11 (for Arduino), C++14 (for Teensy), and C++17 (for ESP). So, testing and integrating your mods might come only in a few weeks.

Debug works, I renamed most of the functions and variables. e.g. using _var is old C style, also Set and Get methods are no more needed when using overloading functions. I wrote the very popular Ticker library which works on all platforms. The problem I see is using the Arduino String library which is a problem for microcontrollers with small RAM, cause of defragmentation of the heap.
With non blocking did you mean interrupt based? Receiving data from the Nextion display with RX interrupts will solve many timing problems.

GitHub have now a discussion forum which can activated in settings. It is better for non issues problems and ideas.

With non blocking, I mean launching another custom callback function of a NexComp when the requested answer has fully arrived.
I’m aware of the fact that many things can be done in a more modern style, but Arduino users, especially beginners, seem to feel more comfortable with familiar naming conventions and the good old getSomething, setSomething, writeSomething and readSomething methods.


Package request: libtatsu 1.0.3

Project description
Library handling the communication with Apple's Tatsu Signing Server (TSS).

Additional information
Needed for https://github.com/NixOS/nixpkgs/issues/342728
checking for libusbmuxd-2.0 >= 2.0.2... yes
checking for libplist-2.0 >= 2.6.0... yes
checking for libimobiledevice-glue-1.0 >= 1.3.0... yes
checking for libtatsu-1.0 >= 1.0.3... no
configure: error: Package requirements (libtatsu-1.0 >= 1.0.3) were not met:

No package 'libtatsu-1.0' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Metadata

homepage URL: https://github.com/libimobiledevice/libtatsu
source URL: https://github.com/libimobiledevice/libtatsu
license:  LGPL-2.1 license
platforms: unix

Add a :+1: reaction to issues you find important.

Working on this alongside your other issues! PR incoming


Add Flow type declarations

This pull request adds a file specifying the types of all of Kefir's functions in a way that Flow understands. Flow will be able to type-check code using Kefir with this declaration file automatically without requiring any special Kefir-specific configuration by the user. Flow does a lot of type-inference and works really well with Kefir in my experience.
Here's an example of Kefir and Flow used together with the declaration file. We have a function defined to only take streams of numbers, but we pass a stream of strings to it instead. Flow correctly detects this as a type error:
/* @flow */
import Kefir from 'kefir';

function foo(stream: Kefir.Observable<number>) {
}

var s = Kefir.constant(5).map(x => String(x));
foo(s);

test.js:7
  7: var s = Kefir.constant(5).map(x => String(x));
                                        ^^^^^^^^^ function call
  7: var s = Kefir.constant(5).map(x => String(x));
                                        ^^^^^^^^^ string. This type is incompatible with
  4: function foo(stream: Kefir.Observable<number>) {
                                           ^^^^^^ number

Found 1 error

The declaration file was hand-written, not autogenerated or anything like that. As Kefir gets new methods, it would need to be updated by hand in order for user code using them to type-check correctly. Personally as a heavy Flow and Kefir user I don't think it's a big deal if Kefir's declaration file lags behind what Kefir supports; a Flow user can always cast values to any to bypass a type error when they need to do something that Flow doesn't understand. I find huge value in having any Kefir types available at all.
TODO:

[x] The file kefir.js.flow needs to be copied into the dist/ directory (where Flow will look for it) on build. I'm not sure how best to set this up in Kefir's build process.
[x] Optional: a test could be added that checks that the kefir.js.flow file is parseable, and verifies that Flow can typecheck a test file. We should add "flow-bin" as a devDependency if we want to do that. I could take a stab at this.

That's great! Thank you for doing this!

The file kefir.js.flow needs to be copied into the dist/ directory (where Flow will look for it) on build. I'm not sure how best to set this up in Kefir's build process.

Since we use grunt maybe we could use some grunt-plugin that copies files? So running $ grunt would also copy the file. It seems like the most idiomatic approach for our current setup.

Optional: a test could be added that checks that the kefir.js.flow file is parseable, and verifies that Flow can typecheck a test file. We should add "flow-bin" as a devDependency if we want to do that. I could take a stab at this.

Sounds like a good idea.

GitHub have collapsed comments in the code, so I'm answering here for convenience.

I've typed the error type, and made it default to being inferred so that it doesn't need to be specified.

Great!

One difference is that theirs tries harder to keep track of properties and streams as different types (I never bothered much since Kefir has the same methods on both anyway).

Yea, seems reasonable.

The Kefir.zip overloads are to work around facebook/flow#1251. (Kefir.zip and Kefir.combine have a similar type signature to Promise.all, but Flow doesn't support defining functions with that exact behavior. Flow's support for Promise.all's type is hard-coded.) The workaround isn't perfect, it only works for up to five parameters and is pretty verbose. (They could have done the same thing for Kefir.combine but didn't.) Might be worth doing.

Yea, I think it worth doing.

My version defines separate overloads for with and without the combinator function which avoids that issue

Great!

I added a bunch of tests for the flow types. They're just javascript files under test/flow/ that have some flow types and lines that are expected to trigger errors. Turns out Flow supports marking lines expected to throw errors, so no special setup was needed besides adding "flow check" to the "test" script in package.json.

I started going through the effort of adding some overloads for Kefir.combine and Kefir.zip to make its types fully correct with up to 5 parameters, but then I realized that there's also that second passive observables array parameter to Kefir.combine, so there'd have to be an overload for every combination of number of active and passive observables up to 5 to be fully right. And none of that works right if the number and types of array items isn't known to Flow. I'm thinking it's better and more predictable for users to just have the consistently general/weaker type signature that covers all cases than spend a lot of space special-casing only some of them.

I've set it up so the build-kefir task calls the copy:flow task which copies kefir.js.flow into dist/ on build. I believe this pull request is ready now.

Optionally, we could add a note to the readme about the presence of the bundled Flow types and give a shout-out to Flow. I've been sticking this blurb at the end of some of my modules' readmes (from redux-action-log):

Types

Flow type declarations for this module are included! If you are using Flow, they won't require any configuration to use.

so there'd have to be an overload for every combination of number of active and passive observables up to 5

Ah, right. Ok, let's not do this then.

Turns out Flow supports marking lines expected to throw errors, so no special setup was needed besides adding "flow check" to the "test" script in package.json.

But will build fail if line won't throw?

Optionally, we could add a note to the readme about the presence of the bundled Flow declarations

Good idea! Also I think a small example will be helpful. I did it like this in fun-task.

But will build fail if line won't throw?

Tests (npm test) will fail if any of the expected flow errors are missing.

I've added a little blurb to the readme with a short code example. The goal of the code example was to show how you could explicitly type a stream, and show that the type can be automatically inferred.

All looks great to me now! Let me know when it's ready to merge.

Yeah, I think it's good to go.

Thanks a lot!

Ha sorry, actually I've got one more thing to add. Just a small nice-to-have: make it so Flow knows .filter(Boolean) means the stream has no falsey values.

I thought it wasn't going to work, but I just realized I was testing with an old version of Flow.

(I'll put up a new pull request in a moment.)

I've already released 3.5.0 😄
But yeah, just open another PR.
Btw, could you check that npm package works (types are exposed correctly)?

The npm package works great, Flow automatically picked up the types now.


[Bug]: PopoverClose as-child doesn't work

Reproduction
None
Describe the bug
I'm trying to add a Popover on a button for a quick input, and I want a button which the user can click to do the update action and close the popover
I'm naively trying to add PopoverClose from radix-vue and
<PopoverClose as-child><Button @click="myAction">Save</Button></PopoverClose>

but this doesn't show the button
any idea?
Otherwise if I just add a regular button without PopoverClose, how can I control the fact that the popover closes as the user clicks?
System Info
None

Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

@maelp Hi, please provide us with a repro
Did you use PopoverClose inside the Popover component?
based on Provide/Inject functionality, PopoverClose will only works when it's inside Popover

Yes it was insideBasically how would you go about adding a Button inside a Popover which closes the Popover and also runs a custom action?On 16 Jul 2024, at 17:45, Sadegh Barati @.***> wrote:
@maelp Hi, please provide us with a repro
Did you use PopoverClose inside the Popover component?
based on Provide/Inject functionality, PopoverClose will only works when it's inside Popover
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@maelp
https://stackblitz.com/edit/f6j6mu?file=src%2FApp.vue
It's working, chain functions working even with asChild prop

Weird I had literally the same code as you

You should check the Button.vue source, maybe you need to use inheritAttrs: false, and add $attrs to the button element

Hey @sadeghbarati thanks! This is my Button code, how would you change it?
<script setup lang="ts">
import type { HTMLAttributes } from "vue";
import { Primitive, type PrimitiveProps } from "radix-vue";
import { type ButtonVariants, buttonVariants } from ".";
import { GIcon, cn } from "@ui";

// We added "icon" for convenience
export interface Props extends PrimitiveProps {
  variant?: ButtonVariants["variant"];
  size?: ButtonVariants["size"];
  icon?: string;
  class?: HTMLAttributes["class"];
}

const props = withDefaults(defineProps<Props>(), {
  as: "button",
});
</script>

<template>
  <Primitive
    :as="as"
    :as-child="asChild"
    :class="
      cn(
        buttonVariants({ variant, size }),
        'flex',
        'gap-1',
        'items-center',
        props.class
      )
    "
  >
    <GIcon :icon="icon" v-if="icon !== undefined"></GIcon>
    <slot />
  </Primitive>
</template>

Seems similar to https://github.com/radix-vue/shadcn-vue/blob/dev/apps/www/src/lib/registry/default/ui/button/Button.vue

@maelp I thought you changed Button.vue source 🤔
$attrs will automatically attached to the first child of the template so there is no need to do inheritAttrs: false and set $attrs  with v-bind

In that case, can you share your source code or invite me to your private repo for test?

@sadeghbarati I shared it just in the message above

That is shadcn-vue button source link.
Can you share (Your) reproduction?

Yes I meant my Button code is here, haven't yet done the reproduction with my code as it requires a few libs, but if I manage to do it I'll share
<script setup lang="ts">
import type { HTMLAttributes } from "vue";
import { Primitive, type PrimitiveProps } from "radix-vue";
import { type ButtonVariants, buttonVariants } from ".";
import { GIcon, cn } from "@ui";

// We added "icon" for convenience
export interface Props extends PrimitiveProps {
  variant?: ButtonVariants["variant"];
  size?: ButtonVariants["size"];
  icon?: string;
  class?: HTMLAttributes["class"];
}

const props = withDefaults(defineProps<Props>(), {
  as: "button",
});
</script>

<template>
  <Primitive
    :as="as"
    :as-child="asChild"
    :class="
      cn(
        buttonVariants({ variant, size }),
        'flex',
        'gap-1',
        'items-center',
        props.class
      )
    "
  >
    <GIcon :icon="icon" v-if="icon !== undefined"></GIcon>
    <slot />
  </Primitive>
</template>

Also I checked and my Popover, PopoverContent etc implementations are exactly the ones from latest shadcn-vue

Hmmmm I updated my dependencies and this seems to have solved the bug, not sure why

Updated the Stackblitz with your Button.vue source it still working
Added a <div> before the slot with v-if condition
https://stackblitz.com/edit/f6j6mu

Possible ways to fix this issue

update deps
remove node_modules
remove packageManager cache


fix: send stickers in message if present

Code change checklist

[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] My code follows the coding style guide.
[x] I tested that my change works before raising the PR.
[x] I have ensured that I did not break any existing API calls.
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Could you add a function called "add_sticker" or something?

Done


Support for whenAny

Pull request for issue #17
Would it be possible to support a whenAny method where you can have several Callables that as soon as one is successfully returned, the DoneCallback with the result is called with the result (and canceling/failing all remaining Callables if they can be canceled)?
Here's a unit test for the use case:
@Test(timeout = 3000)
public void testWhenAny() {
    final AtomicInteger doneCount = new AtomicInteger();
    final AtomicInteger failCount = new AtomicInteger();
    final AtomicBoolean callable1Run = new AtomicBoolean(false);
    final AtomicBoolean callable2Run = new AtomicBoolean(false);
    final AtomicBoolean callable3Run = new AtomicBoolean(false);

    Promise<OneResult, OneReject, MasterProgress> p = deferredManager.whenAny(new Callable<Integer>() {
        public Integer call() {
            try {
                Thread.sleep(2000);
                callable1Run.set(true);
            } catch (InterruptedException e) {
            }

            return 100;
        }
    }, new Callable<Integer>() {
        public Integer call() {
            try {
                Thread.sleep(500);
                callable2Run.set(true);
            } catch (InterruptedException e) {
            }

            throw new RuntimeException("Oops");
        }
    }, new Callable<String>() {
        public String call() {
            try {
                Thread.sleep(5000);
                callable3Run.set(true);
            } catch (InterruptedException e) {
            }

            return "Hello";
        }
    }).then(new DoneCallback<OneResult>() {
        public void onDone(OneResult result) {
            Assert.assertEquals(100, result.getResult());
            doneCount.incrementAndGet();
        }
    }).fail(new FailCallback<OneReject>() {
        public void onFail(OneReject result) {
            if (failCount.incrementAndGet() == 1) {
                Assert.assertEquals(RuntimeException.class, result.getReject().getClass());
                RuntimeException e = (RuntimeException) result.getReject();
                Assert.assertEquals("Oops", e.getMessage());
            }
        }
    });

    Assert.assertTrue(callable1Run.get());
    Assert.assertTrue(callable2Run.get());
    Assert.assertFalse(callable3Run.get());
    Assert.assertEquals(1, doneCount.get());
    Assert.assertEquals(2, failCount.get());
}

This change is

@saturnism this sounds similar to the race method we discussed earlier.

agreed! we'll have this soon :D

This is implemented by @aalmiray in #127. PTAL. Thanks!


WIP: console disable for openstack

Thanks a lot. I updated https://github.com/openshift/hypershift/pull/4418 and added you as co-author of course.
/close


Change wording of pushing up commits before creating a PR

Change this wording to: There are currently no commits between 'main' and '<my branch>'. Do you want me to push your local changes for you and try to create the pull request again?

I actually think the current wording is consistent with other dialogs in VSCode - I don't know of anywhere where we use "I" or "me" to refer to our code.

I think being more explicit that the PR will be created rather than just "try again" would help, and that this would be easier to read as multiple lines. How about
There are currently no commits between 'main' and '<my branch>'

Would you like to push your local commits and create the pull request?

with buttons "Cancel" and "Push Commits"

Hm very true! I like the button suggestion!


Add implementation for the individual service  /v1/register-application

Describe your feature request :
Support functionality and forwarding for the service /v1/register-application
Implementation tasks and next steps :

[x] Complement the registerApplication operation in controller/IndividualServices.js
[x] Complement the registerApplication operation in services/IndividualServices.js
[x] Support logical-termination-point configuration
[x] Support forwarding TypeApprovalCausesRequestForEmbedding configuration
[x] Support forwarding ServerReplacementBroadcast configuration
[x] Support forwarding OperationUpdateBroadcast configuration
[x] Support forwarding ServiceRequestCausesLtpUpdateRequest to Application Layer Topology
[x] Support forwarding ServiceRequestCausesFcUpdateRequest to Application Layer Topology
[x] Support forwarding RegistrationCausesInquiryForApplicationTypeApproval to Type Approval Register
[x] Support forwarding ServiceRequestCausesLoggingRequest to Execution and Trace Log
[x] Contribute to issue #20 and close the issue.

Alternate proposals if any :
Additional context :

Included implemenation for the service


Documentation

Updated documentation around the standalone client.

A lot of this is re-formatting, sorry about that. The big changes are to documentation and to using a HostPath instead of a ConfigMap for data.


Various changes

Variable name changes
Optional callbacks called if present for error handling
Allow double hyphen for the interval designator per ISO 8601:2004(E) 4.4.2

Superseded by other PR.


Make homebrew install script url configurable

Optionally also specify a checksum for the remote_file

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Hi,
This pull request is not passing on Travis due to the rubocop fail -> raise update, which I have attempted to address in https://github.com/chef-cookbooks/homebrew/pull/96.
I have also added the email in the commit to my account and verified since issuing the pull request, so that should no longer be an issue.
Thanks.


Install cairo on server?

Shoebot renders graphics using cairo, I'd like it to generate graphics that go into the doc, would it be possible to have cairo on the server ?

We are just upgrading our build server deployments, so we could do this now. Do you know the ubuntu packages off hand?

I had a look for libraries that don't work straight from pip (basically Gtk python apps - Shoebot, Gramps, Novacut):  ... and a couple of things like pyaudio, and aubio.
AFAICT these packages predate pip/virtualenv, which is why they need persuading to work with them :)
Virtualenvs can link to the system versions of these either with --system-site-packages, symlinking or using something like 'vext' (my own project that allows only certain packages access to system modules).
Packages:
aubio-tools
gir1.2-freedesktop
gir1.2-pango-1.0
libaubio-dev
libaubio-doc
libcairo2-dev
libgirepository
libgirepository1.0-dev
libglib2.0-dev
libgtkspell-3-0
libjpeg-dev
libpango
libpangocairo
python3-bsddb3
python-cairo
python-cairo-dev
python-dev
python-gi
python-gi-cairo
python-gobject
python-gobject
python-gobject-dev
python-gtk2
python-gtksourceview2
python-gtkspell
python-pyaudio
python-pyicu
python-rsvg

Apps that might want to use gstreamer in some way (can certainly imagine thumbnailing in docs for instance):
sudo apt-get install python-gi python3-gi \
    gstreamer1.0-tools \
    gir1.2-gstreamer-1.0 \
    gir1.2-gst-plugins-base-1.0 \
    gstreamer1.0-plugins-good \
    gstreamer1.0-plugins-ugly \
    gstreamer1.0-plugins-bad \
    gstreamer1.0-libav

This list is reflects stuff I've been using so far, should be enough to get shoebot stuff working and Gtk related libs (using pango etc).
My next project will be doing stuff with GL, so maybe in a few years I'll be back, asking for GL2PS or similar, lets see..

But yeah - for my immediate problem - I need cairo

Heh could have asked for that better, but if there is a chance of cairo, would be great :)

I've added a PR for libcairo2-dev to our docker images: https://github.com/rtfd/readthedocs-docker-images/pull/7/files

Fantastic, if I ever finish my next ubertool that uses some of those other libs I'll be back here.

Just to confirm: our docs generator using cairo works now this is merged, thanks :)


feat: support high priority micro task

feat: support high priority micro task
closes #22, help resolving aurelia-contrib/aurelia-getter-throttle#1

@bigopon have a look. I tested this with getterThrottle, it works.

Lgtm. Perf hit is minor. Its @EisenbergEffect 's call

I can hardly image this new api to be broadly used. But it does enable proper rendering optimisation from aurelia-contrib/aurelia-getter-throttle. It also provides extra flexibility on code execution.
Also, we might need a better name for the new api.

Changed to WIP. I got an idea to refactor it, avoiding mutating microTaskQueue (splice on big array might be costly).

Refactored to use dedicated microTaskJumpQueue array, avoid inserting task to microTaskQueue.

Perhaps we should call it a priorityQueue???

Priority sounds better than jumpQueue.
@EisenbergEffect questions:

should we normalise the api to queueMicroTask(task: Task | Function, highPriority?: boolean): void?

when flushing, the behaviour is what's jumpQueue doing now.
when not flushing, should we ignore highPriority, or should we honour highPriority to use unshift(task) instead of push(task)?
unshift has a surprising effect. When queue high priority tasks A and B, the queue will end up as [B, A, ...] with B, A in reversed order. Another way to get around this is to let user to put a flag on task itself (task.highPriority = true;) before queuing. The flag on task seems better, because it doesn't require visible API change, it also helps to keep the order of high priority tasks.

should we add support of highPriority on macro task queue too? I cannot image the usecase for it. But this makes the API consistent.

I'm thinking of an API like this:
enum QueuePriority {
  normal,
  high
}

queueMicroTask(task: Task | Function, priority = QueuePriority.normal);

We could convert this library to TypeScript... @bigopon What do you think?

Probably need to use separate PR for that convention. If some one got time/plan to do it in near future, I am glad to wait. Otherwise, I don't mind to try.

You can update this PR to export it as a const object. Then, in a future PR we can either convert to TS or create a custom d.ts file with the enum.

I think with the upcoming changes in templating, we have the chance to refactor build of templating - resources, maybe it's a good chance to start from there, as it can always be treated as independent module, then apply the build process from there to here. And finally merge with @ZHollingshead work at https://github.com/aurelia/framework/pull/850
Or we can go all in and continue the work of @ZHollingshead at https://github.com/aurelia/framework/pull/850
@EisenbergEffect @huochunpeng

That makes sense. We can tackle the TS move as part of the monorepo work.

Please review. Test code was cleaned up for eslint warnings, added test coverage for existing code too.

@huochunpeng I like the idea but I'm a little nervous since changing this will affect the entire binding system's performance. @bigopon @jdanyow What do you think?
Another idea would be to experiment with implementing the queue as a linked list where normal priority puts things at the end and high priority puts them at the beginning. On that thought, could you do the same thing with an array and loop using while/pop until there's none left, rather than a for loop?
Basically, I'd really like to see some benchmarks on this and maybe a couple of different implementations since this would be a perf critical change.

Got some benchmark http://jsben.ch/rOx3i
My linked queue implementation is primitive. During flushing, the linked queue doesn't preserve the inserting order of high priority tasks, the high priority tasks will be queued in reserved order. Need few extra lines to fix the order.

results varies across runs (probably due to condition over Math.random). With empty priorityQueue, the performance hit is within +/- 5% comparing to the base line.
surprisingly, on Chrome, the extra condition check on empty priorityQueue doesn't always make it slower?!
something wrong with my setup, my benchmark doesn't run in FireFox/Edge :-(
linked queue is about 5-10% faster.

Chrome

Safari

Definitely interesting. I'd love ot see how it compares with FF and Edge as well, if you can get that working.

I had bit play on jsben, it looks like the usage of eval() (jsben's way to run test) is the reason why Firefox is so slow in jsben.
Firefox has unfixed performance issue (200 times slower!) on eval(). https://bugzilla.mozilla.org/show_bug.cgi?id=1242133
This doesn't reflect Firefox Quantum's JS performance in normal usage, which is comparable to Chrome.
To make it work in Firefox, I need to drop queue size from 5000 to 10. My home machine is 8 yrs old, you probably can pump it up bit more on your machine. http://jsben.ch/koUT1
Due to the small queue size and Math.random, the results vary quite a lot across runs. It generally gave me a feeling linked queue is slower than array on Firefox. This assertion is probably not trustable due to small queue size.
When I got more time, I will probably do a handmade benchmark page, with full task-queue source, plus some alternative implementations on flushQueue.
Firefox


Update default tailscale version to 1.42.0

Implemented in https://github.com/tailscale/github-action/pull/71/


Update event-driven-architectures.md

Description
some edits to text only

...
...
...

Related issue(s)

Covered in here https://github.com/asyncapi/website/pull/227/files


yaml parameter file

have a --config parameters.yaml
and then parse the other CLA paramters
and overwrite the parameters.yaml with those
config file is the only required command line arg
the others are all optional, check if they are specified and then conditionally overwrite
function: process parameters which does that in a clean way
function: generate yaml files on the fly for hparam sweep and documenting model params

Add to wandb https://docs.wandb.com/library/config


4096 bit key?

Is it possible to tell caddy to use a 4096 bit key size instead of 2048? I'm not seeing anything about it in the configuration.

Not currently. We may allow that later on, but I'm waiting for LE to support ECC certs before making those things customizable.


Add outDir options

I like this feature

thanks. i have invited @sebastinez as collaborator

Thanks @milahu for the invite, gladly accepted it, currently not using this package anymore but will gladly help out where I can


Add Image Management APIs to index of documentation for easier access.

Add Image Management APIs to index of documentation for easier access.
Fix the reference to Containerization Design Doc in the Image Management API page.

Pull Request Test Coverage Report for Build 5917

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 43.613%

Totals

Change from base Build 5910:
0.06%

Covered Lines:
15208

Relevant Lines:
34870

💛  - Coveralls


Deleted monitor returns wrong HTTP code

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
I use a "push monitor" that I call via a cronjob. If I now delete this monitor, then the cronjob does not fail. This is because Uptime Kuma reports {"ok":false, "msg": "Monitor not found or not active."} but still responds with a status code 200. I think another code, e.g. 404, should be used here.
👟 Reproduction steps
Call an deleted Push-Monitor.
👀 Expected behavior
Status-Code other than 200.
😓 Actual Behavior
Status-Code 200 is responded.
🐻 Uptime-Kuma Version
1.16.1
💻 Operating System and Arch
Alpine
🌐 Browser
Chrome 10x
🐋 Docker Version
No response
🟩 NodeJS Version
No response
📝 Relevant log output
No response

This is a known issue with the way Uptime Kuma is designed. As it is a SPA and all the rendering and most logic and validation is done client side, it results in the 200 result. There was a PR that fixed this for the web interface but I am not sure if it dealt with this as well.

It is not related to SPA, since the push api is a pure route in express.

Ahh, ok. Good to know. 👍


RFE: extend the snap module to provide more info eg. on available tracks / risk levels and revisions

The snap module provides a convenient way to interact with snaps, however it's limited in the information it provides from the snap store.
E.g. you can query the SnapCache for a snap name but afaict it will only give you info for the default track and risk level
c = snap.SnapCache()
microceph_snap = c["microceph"]
print(mc)
<Snap: microceph-817.reef/stable -- SnapState.Available>

It would be great to get more info on

Available tracks
Risk levels and revisions
Versions
Available archs

Hi @sabaini, thanks for the request. This sounds reasonable, however, Charm Tech has limited time to work on operator-libs-linux at the moment with our roadmap items. Often operator-libs-linux changes come from PRs submitted by devs who need the feature. Are you able to do work on this, or at least suggest how it would work and what changes would be need? We can probably get to it (we also have a new guy starting soon), but possibly not in the timeframe you'd need. Let us know.


Arrival instruction should name the waypoint

For an arrival instruction, this library says “You have arrived at the destination”. Instead of a generic “the destination”, the instruction should say the waypoint’s name, like “You have arrived at White House”.
Unfortunately, OSRM generally gives the associated street as the waypoint’s name, which would cause the instruction to mislead, e.g., “You have arrived at Pennsylvania Avenue” even though the user has been traveling on Pennsylvania Avenue since the beginning of the previous step. Fortunately, the developer can modify the waypoint’s name before passing the route step object into this library. (This is also true in Swift: MapboxDirections.swift persists the waypoint name provided in the original request.)
While we’re at it, it would be nice to change the tense from the present perfect (“You have arrived at”) to the imperative (“Arrive at”): #61.
/ref mapbox/mapbox-navigation-ios#419 mapbox/mapbox-navigation-ios#422
/cc @bsudekum

To be clear, the step’s name is the waypoint name, so we won’t need to introduce any additional inputs.

Need to verify how we want to do this.

Fortunately, the developer can modify the waypoint’s name before passing the route step object into this library.

Note that the developer can technically get the name from any source they want, whether OpenStreetMap, the Mapbox Geocoding API, or a hard-coded string literal.

From @1ec5

this is something that is very doable as long as OSRMTI runs on the client side. If we do this on the server side, then api-directions needs to do some postprocessing of what it gets from OSRM. Specifically, it needs to ignore whatever OSRM names the waypoint in favor of what it was named in the URL query parameter.
[11:32]
But that query parameter’s value comes from our Geocoding API in the case of Voyage and other clients.
[11:33]
This treads kind of close to the discussion about adding geocoding capabilities to the Directions API, which has always ended in :no_good:. That’s a non-issue when everything stays on the client side, b/c the POI name gets inserted at the last possible moment, right before sending off to the text-to-speech engine.

Fixed in #184.


[CP] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive)

Cherry pick request of https://github.com/flutter/flutter/pull/148298 to stable.
Fixes problems in 2D viewport when using keep alive widgets (affects users using Material Ink components).

@itsjustkevin don't we use a bot for CP's? Maybe this being out up manually is what has made CI unhappy?

@itsjustkevin don't we use a bot for CP's? Maybe this being put up manually is what has made CI unhappy?

Yes, but the bot doesn't really do anything special, just generates a normal cherry-pick.  This seems like an infra flake.

Seems like all checks passed. Is there anything else I can do to help here?

This is going to need a second reviewer cc @Piinks

@gawi151 this may miss the current release build and make it in the next, but it is still on our radar 🙂.


[BUG] Warning about overwriting $flagd property when perform bulk evaluation

Observed behavior
A warning is logged to the console for every feature flag with a targeting rule defined when performing a bulk evaluation. This only affects the ResolveAll endpoint.
Here's an output of the logs.
playground-flagd-1            | 2023-09-19T00:56:01.691Z        warn    eval/json_evaluator.go:366      overwriting $flagd properties in the context    {"component": "evaluator", "evaluator": "json"

Expected Behavior
The warning log should only occur when the incoming context includes the property $flagd.
Steps to reproduce
Start the latest version of flagd. In this example, the test bed image is used but the same behavior is visible in flagd as well.
docker run --rm -it -p 8013:8013 ghcr.io/open-feature/flagd-testbed:latest

Run the ResolveAll command
curl -X POST "http://localhost:8013/schema.v1.Service/ResolveAll" \
  -d '{"context":{}}' -H "Content-Type: application/json"

FYI @craigpastro @toddbaert @Kavindu-Dodan

Oh my. I guess this is probably because maps are passed as reference, and we are adding the $flagd properties to the map which then is found in all the references. Probably setFlagdProperties should return a new map?


1:1 extension associations should be easier to handle in admin / general by adding empty entity if missing

Please describe the feature you would like to see implemented.
Using 1:1 extension associations can be quite annoying sometimes to adjust the admin correctly (adding new empty entity to create, if it doesn't exist yet - e.g. on update or on create).
This can be an issue during admin and also when retrieving existing entities and storing such data (check if ID exists, add it etc.).
It would be nice if in such scenarios an empty entity could be pre-added to the entity as extension and to the prepared admin entity, if it does not yet exist.
This should not be done by default, as it might not be helpful in all scenarios but it would be nice to have it optional, e.g. by using a flag in the entity extension.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Kanerogers/issue222

Background
Adds the Sponza stress test - closes #222

Some good stuff in here -- particularly the dynamic vertex buffer!

Yeah that fucker was a real treat!


Python 3

Nice project! Any plans for python 3 support?

Thanks! The project does already support Python 3 (and we run tests against Python 3 as well)!
Installation is usually pip3 install pymagnitude for Python 3 instead of pip install pymagnitude.
Are you having any issues / syntax errors using it on Python 3?

Whoops. I don't know how I missed that.
pip3 install pymagnitude


KNL-1561 TimeRange @deprecated

@buckett ?

Hi Dave,
There is no similar concept of a time range in Java 8 (at least that I've seen) and it's the one thing that we should hold on to from the old TimeService or we would need to change our implementations to always pass a start and end time instead of a TimeRange.
I think the concept of a TimeRange is reasonable so I would propose that we split TimeRange from the old service to make it stand on its own and we update it to work with the Java 8 date time types.
A TimeRange could probably be crafted by supplying a start and end time or either a start or end time with a Duration.

Hi Earle,
OK
check:

org.sakaiproject.time.api.InterfaceRange (class)
org.sakaiproject.time.api.TimeRange (interface) @deprecated


Reflection warning, nvd/task/check.clj:42:9 - call to method scan on org.owasp.dependencycheck.Engine can't be resolved (argument types: unknown).

Fixed in commit 3ab24d995361708176bfa16e8651fa7d2ca4ff32


feat(ConsumeMQTT): customValidation check broker connection

Helps https://github.com/influxdata/data-acquisition/issues/468
Adds functionality to ConsumeMQTT that allows it to actually attempt to connect to the broker during a validation request.

Going to move forward using the image built in this PR for now but am refraining from merging until we've added a unit test so the commit can be cherry-picked and PR'd upstream.

@genehynson Just leaving a reminder here for the future: the existing tests are not run by CI (it runs mvn -T 2.0C clean install -DskipTests), and IIRC this change led to sweeping test failures in the MQTT plugin that would also need to be fixed prior to merge/upstream.

Closing as we could not resolve the thread consumption issues and pivoted to using external validation in nifid


Getting useful info from dishwasher

I am missing information from my dishwasher when it requires cleaning cycle, low/no dishwasher shining liquid, etc... I get them in Home Connect (under: "alerts", the same as for  washing cycle start/finish), but can't seem to have in in HA via this integration.
Describe the solution you'd like
An alert in logbook or any other type of alert device to enable me to see informatrion about need for dishwasher clean cycle, adding shining liquid, etc...
Describe alternatives you've considered
For now I have to use Bosch app in parallel to get this type of information.
Additional context

If this information is available in the API for your device it would be exposed as an event in HA. You can use the developer tools to listen to events generated by the integration to see if anything shows up. If it's not exposed by the API then there is nothing I can do about it.


[MERGE AFTER #2069] Fix/refactoring planning msgs

Status
DEVELOPMENT
Description
As part of autoware_msgs refactoring, in this PR we refactored only messages concerning planning, and created a new messages namespace called autoware_planning_msgs.
This was described at https://github.com/CPFL/Autoware/blob/feature/autoware_msgs_refactoring/ros/concerning-autoware-msgs.md, and further discussed at https://github.com/CPFL/Autoware/issues/1428.
Related PRs
List related PRs against other branches:

branch
PR

feature/autoware_msgs_refactoring
2066

fix/refactoring_sync_msgs
2067

fix/refactoring_sensing_msgs
2068

fix/refactoring_localization_msgs
2069

Todos

[x] Tests
[x] Documentation

Steps to Test or Reproduce

Get a fresh copy of Autoware develop branch, ex. git clone https://github.com/CPFL/Autoware.git -b develop --recurse-submodules [AUTOWARE_PATH].
Make sure the original builds correctly: run ./catkin_make_release (follow the steps in How to build ).
Switch to fix/refactoring_sync_msgs branch, ex. git checkout fix/refactoring_sync_msgs and pull for changes git pull.
Switch to fix/refactoring_sensing_msgs branch, ex. git checkout fix/refactoring_sensing_msgs and pull for changes git pull.
Switch to fix/refactoring_localization_msgs branch, ex. git checkout fix/refactoring_localization_msgs and pull for changes git pull.
Switch to fix/refactoring_planning_msgs branch, ex. git checkout fix/refactoring_planning_msgs and pull for changes git pull.
Make sure refactored version builds correctly: run ./catkin_make_release.

Please work according to https://github.com/CPFL/Autoware/pull/2066#issuecomment-470405702.


Can't Finish Setup

I'm able to properly get the token, and paste it in. It then asks for my username, however hitting Enter after that adds an arrow and lets me search Google:

I'm on Alfred 3.0.1, which just came out.
Thanks!

Same issue. Also on latest Alfred as mentioned above.

Hi, all.
For me, this was related to a couple of hard-coded paths in the workflow that didn't play well with Alfred 3 for some reason. I've got an alpha build of the workflow here where this is fixed and would welcome comments and issues in my fork of this repo.
In this specific case, it seemed that the workflow wasn't able to use the username and token to perform the next step, which is to get a list of boards. That resolved once I got the paths resolved correctly.
If you're still interested, please give that alpha build above a test and let me know if you have any issues.
Cheers!
--j


[PLAT-435] Dataverse Refactor

Purpose
Allows us to access Dataverse datasets via v2 API.  Also there were some incidental style fixes which a threw in rather then make a new ticket.
Changes
Refactor:

add get_folder method to model
adapt view to use model method
refactor front end to use "name" instead of "title", in accordance with API standard

Style:

Fix broken Dataverse and dataset link
Change text color from blue to black

QA Notes
Style changes below.

Side Effects
Because the the Dataverse Repo -> Dataverse -> Dataset -> File sturcture of Dataverse, this needs a degree more configuration from the other addons. So to get Datasets to appear via the API you have to select a Dataverse with a Dataset via the UI.
Ticket
https://openscience.atlassian.net/projects/PLAT/issues/PLAT-435

@pattisdr I'm sorry, it's probably very confusing to track all the changes, but I've changed the code to list dataverses in get_folder instead of datasets because I feel that's more in accordance with the use case. I'm keeping the old get_folder method is renamed get_dataset and is still being used the same way in the view, we'll likely v2-ize it eventually once we work out the dataverse v2 process a bit more.
I also fixed that bug you mentioned.

This is headed to staging3 for QA.


Function vuninitializedq_s16 has no prototype

Hi, I am currently working with the <arm_math.h> library and when I try to compile it with IAR, I get this compilation error:
      vecDst = vuninitializedq_s16();
               ^
\cmsis_dsp\Include\arm_helium_utils.h",684  Error[Pa045]: function "vuninitializedq_s16" has no prototype

I did not find any implementation for this function.

@RemiCSTM It looks like a problem with the compiler since this intrinsics is part of the C interface in arm_mve.h and I have just checked it is defined in gcc, clang and Arm compiler 6:
vuninitializedq_s16

In /inc/c/aarch32/arm_mve.h, I can see:
static __inline__ __attribute__((__clang_arm_builtin_alias(__builtin_arm_mve_vuninitializedq_s16)))
int16x8_t vuninitializedq_s16();

Seems IAR is not well managing __attribute__((__clang_arm_builtin_alias(__builtin_arm_mve_vuninitializedq_s16))) ?
$ /opt/iarsystems/bxarm/arm/bin/iccarm  /xxx/Source/BayesFunctions/BayesFunctionsF16.c  -I/xxx/cmsis/CMSIS/Core/Include -I/xxx/cmsis_dsp/Include -I/xxx/cmsis_dsp/PrivateInclude --cpu=Cortex-M85 --fpu=VFPv5_d16 --endian=little --cmse  -Ohz --debug --dlib_config DLib_Config_Full.h --no_wrap_diagnostics -e --enable_restrict --vla --require_prototypes --dependencies=ns xxx/cmsis_dsp/Source/BayesFunctions/BayesFunctionsF16.o.d -o xxx/cmsis_dsp/Source/BayesFunctions/BayesFunctionsF16.o

      vecDst = vuninitializedq_s16();
               ^
"/xxx/cmsis_dsp/Include/arm_helium_utils.h",684  Error[Pa045]: function "vuninitializedq_s16" has no prototype

Errors: 1
Warnings: none

@jeromecoutant I don't know IAR. I assume it ignores clang attributes ? Perhaps a copy / paste from clang mve header when they started working on MVE ?

@jlonnberg


FORCE_COLOR=3 not supported

FORCE_COLOR = 3 is an officially documented Node.js flag:
https://nodejs.org/api/tty.html#:~:text=16%2C777%2C216 colors%3A FORCE_COLOR %3D 3

Happy to open a PR if you're open to it.


Customize Agent logging configuration

Console: only log a very specific logger, intended for high visibility user messages.
File: log everything to file.

@tgianos @sumitnetflix this is ready for review

Coverage decreased (-0.004%) to 90.731% when pulling 77b18f496e36ebd43727ce4781ff151bbaa6bd69 on mprimi:agent-logging into 985a55f0c8a1c70ea6cab0c6b5697c17ee3d377b on Netflix:master.


Update for 1.17

After a comment on reddit I was going to try updating this mod for 1.17 and leaving a PR but unfortunately its only the api so I wouldn't be updating the whole mod. As the dev for the mod can you update to 1.17. Thanks in advance

Sadly, I can't do this until Minecraft Forge updates to 1.17.
Closing the issue until something can be done about it.

Just thought to throw an update your way that Minecraft Forge for 1.17.1 is out now, and porting my mods to that version might take a while. Throwing my 1.16.x source code for Spartan Weaponry into a 1.17.1 version gave me roughly over 4500 errors! A lot of these are to do with name changes that I'll need to deal with first before I can see what has been removed or changed.

ah yes typical minecraft modding


test: add unit tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dda356c) 0.00% compared to head (d57191f) 73.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #28       +/-   ##
=========================================
+ Coverage      0   73.94%   +73.94%
=========================================
  Files         0        5        +5
  Lines         0      119      +119
=========================================
+ Hits          0       88       +88
- Misses        0       26       +26
- Partials      0        5        +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add description for MapFactory and Benchmark packages

I will cherry-pick this PR for the release branch

Done

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   96.83%   96.83%
=======================================
  Files         123      123
  Lines        9094     9094
=======================================
  Hits         8806     8806
  Misses        288      288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c2c0d...b66be6f. Read the comment docs.


I would suggest to add logo for the website on the header part and also add Brand name Rescue on the header part

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Not required