How to use >2k context size?

From reading https://huggingface.co/TheBloke/wizard-vicuna-13B-SuperHOT-8K-GPTQ I get the sense that exllama supports context sizes greater than 2k - as part of oogabooga, anyhow.
When I load the model in the webui the sequence length shown is 2048, and trying a prompt larger than 2048 causes the python process to peg one cpu core indefinitely:

Is a greater context size supported in the exllama webui as well?

For that model, you'd launch with -cpe 4 -l 8192 (or --compress_pos_emb 4 --length 8192), possibly reducing length if you're VRAM limited and start OOMing once context has grown enough.
Some instructions that are going around say you can use e.g. -cpe 2 -l 4096 (e.g. for 33B on 24GB VRAM, which OOMs around 3400-3600 tokens anyway), but you shouldn't do that, cpe should be set equal to whatever the finetune was done with or the model will act stupid, regardless of what length is limited to.
You can also try NTK scaling by setting -a (--alpha), for that you do not want one of the older linear scaling finetunes, just use a regular 2k model. Without a finetune, -a 2 will go up to ~3400 before exploding, -a 4 will do ~5500, and -a 8 will do ~9000.
Finetuning also helps with NTK scaling, but it's not strictly necessary like it is for linear scaling. At the time of writing, the only NTK finetunes I know of are a SuperHOT 8k LoRA and Airoboros 16k, but this tech has only been around for a few days, so expect more of those in the future.
Also, these "-a vs context" numbers will probably be outdated soon, as exllama still uses a version of NTK scaling as it was originally introduced, which has already been significantly improved upon here, and someone will probably port these changes here sooner or later.

Another vote for NTK. No tuning and better perplexity. Covers basically the reasonable range for a 30b in 24gb, even at the lowest setting.

Thanks! Lrger context size with -cpe -l worked.
What model would you recommend that I try with NTK?
Will close the comment as we got the larger context size working.

What model would you recommend that I try with NTK?

I'm not particularly knowledgeable on this, but every model I've tried with NTK scaling isn't that notably different from the same model without NTK scaling, except that scaled models are more prone to hallucination until you get a larger chunk of context going. Personally I kind of like stock LLaMA the most overall, but the same applies at regular 2k context.


fail to synthesize if with constant natural numbers

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
I can write this:
def u (x : Nat) : Nat := do
  let y := x + x
  y * (if y > 100 then 1 else y)

but if I change the final y to a constant 5 it no longer compiles:
def u (x : Nat) : Nat := do
  let y := x + x
  y * (if y > 100 then 1 else 5)

Steps to Reproduce
See above.
Expected behavior: [What you expect to happen]
should work
Actual behavior: [What actually happens]
failed to synthesize instance
  HMul Nat (Id Nat) ?m.260

Reproduces how often: [What percentage of the time does it reproduce?]
Versions
Lean (version 4.0.0-nightly-2021-11-07, commit d5e05f31e4a7, Release)
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

This is not a bug. Lean is working as expected. There is a lot going on in this example.

Numerals in Lean are polymorphic, and Nat is the default instance when context information is not available.
Arithmetic operations are all heterogeneous and parametrized by type classes: HAdd, HMul, etc.
do blocks automatically lift pure code to monadic code, and between different monads.
do blocks can be used in pure code by implicitly inserting the Id(identity) Monad.

There are also many ways to address this issue.

Ignore. The code is not realistic to me. Novice users would not use do blocks in pure code.
Improve the error message.
Remove an existing feature. For example, if we disallow do blocks in pure code, the issue is gone.
Support the scenario above by adding new instances or new features.
...

if we disallow do blocks in pure code, the issue is gone.

FYI I use this feature all the time to get local mutation.

if we disallow do blocks in pure code, the issue is gone.

FYI I use this feature all the time to get local mutation.

It would still be doable, you would just have to explicitly use the Id monad.
BTW, I am not pushing for this solution, but I have seen users suggesting it.

I don't agree with option 1 "Novice users would not use do blocks in pure code.".  I am a Novice user and I just did :-) So at a minmum we need a better error message pointing the user to these 2 possible solutions.  But I still argue it is inconsistent at best that my first code block in my original bug rep[ort works, but the second does not.
So the 2 fixes I've found so far are, add a return statement:
def u (x : Nat) : Nat := do
  let y := x + x
  return y * (if y > 100 then 1 else 5)

remove the do
def u (x : Nat) : Nat :=
  let y := x + x
  y * (if y > 100 then 1 else 5)

I don't agree with option 1 "Novice users would not use do blocks in pure code.". I am a Novice user and I just did :-)

Not sure you are a novice user ;)
How did you get to this example?
Note that most new users would not even use monadic code, and just write pure definitions and theorems.

But I still argue it is inconsistent at best that my first code block in my original bug rep[ort works, but the second does not.

They are not the same. In the first one, you had y a non-polymorphic symbol. Its type is Nat. In the second, you replaced y with a polymorphic symbol (a numeral).

So the 2 fixes I've found so far are, add a return statement:

In both cases, you are avoiding the Id Nat vs Nat.
There are other ways to "fix" the example.
The general guideline is to provide additional type information. Example: numerals are polymorphic, I am seeing an Id Nat. So, we would write (5 : Nat) instead.

No I really am a Novice so much so I didn't even know numerals were polymorphic.  Now that you pointed that out I see there's another fix:
def u (x : Nat) : Nat := do
  let y := x + x
  y * (if y > 100 then 1 else (5 : Nat))

So how can we improve this error message so I would have realized that is what is going on ? I don't even know how to read this message:
failed to synthesize instance
  HMul Nat (Id Nat) ?m.1340

I can guess "HMul" is what the multiply elaborated to, Nat is the type that 'y' has already but (Id Nat) what is Id ?

And where do we write about the fact that numerals are polymorphic in the reference docs?  I think dependent_type_theory.md brilliantly discussed polymorphism using List as an example which made all kinds of sense, but it missed the opportunity to really blow my mind and point out that numbers are polymorphic too!
And what made me try this example in the first place?  I was exploring what you can do with the second part of a let statement, how much code can that second part expand to, and apparently, it can be a lot of code - with nested if-expressions I could have 10 pages of code where the bound variable y shows up someplace.  Fun... could be used as a kind of templating system. where the x + x is being "plugged into the template" wherever the variable shows up...

No I really am a Novice so much so I didn't even know numerals were polymorphic.

You are not the standard novice either. The standard novice user would start using Lean in pure code, read the tutorial, and prove theorems. The do notation is usually used by advanced users that are trying to extend Lean using itself.
Yes, we want to support users that want to use Lean as a programming language and ignore all the math stuff, but this is not our priority right now.

So how can we improve this error message so I would have realized that is what is going on ?

We have to prioritize the issues and focus on the ones that are blocking the Mathlib port.
The priority is the Mathlib users.

(Id Nat) what is Id ?

It is the identity monad.

Here: https://leanprover.github.io/theorem_proving_in_lean4/type_classes.html#numerals

if we disallow do blocks in pure code, the issue is gone.

FYI I use this feature all the time to get local mutation.

Just to record my preferred solution here: I believe pure do should use a distinct keyword such as puredo. It is syntactically (← doesn't make any sense in it) and semantically (doesn't need to block on the expected type, shouldn't try to lift "actions" as seen here) distinct enough that it should be considered its own thing. This would also resolve the "Option monad issue".

Just to record my preferred solution here: I believe pure do should use a distinct keyword such as puredo ...

I don't like this one. It is extra complexity, a new keyword, and the benefit looks small to me.
It is also not clear whether it would fix the issue reported here or not. I am assuming puredo would still use the Do.lean code, and the Id monad would be used there since a monad is used in a few places (e.g., expanding for .. in .. do).
Are you proposing we have special support for puredo in Do.lean at every place where we use ctx.m?
BTW, as a user, I would prefer to explicitly use Id than writing puredo.

In Haskell, I used to use runIdentity $ do ... all the time.  Id.run do ... would be even less cumbersome. Not suggesting this but we could also call this puredo in user-space:
macro "puredo" cmds:doSeq : term => `(Id.run do $cmds)

example : Array Nat := puredo
  let mut xs := #[]
  for i in [:10] do xs := xs.push i
  return xs

Are you proposing we have special support for puredo in Do.lean at every place where we use ctx.m?

Only where it helps elaboration by hiding Id from the user. This should be mostly the Bind.bind $action ... quotations. In the simplest case, we could wrap action in pure beforehand.

(Strictly speaking, this part is independent from the "separate keyword" proposal)

In Haskell, I used to use runIdentity $ do ... all the time. Id.run do ... would be even less cumbersome. Not suggesting this but we could also call this puredo:
macro "puredo" cmds:doSeq : term => `(Id.run do $cmds)

example : Array Nat := puredo
  let mut xs := #[]
  for i in [:10] do xs := xs.push i
  return xs

Note that your suggestion does not fix the issue here.
macro "puredo" cmds:doSeq : term => `(Id.run do $cmds)

def u (x : Nat) : Nat := puredo
  let y := x + x
  y * (if y > 100 then 1 else 5)

Only where it helps elaboration by hiding Id from the user. This should be mostly the Bind.bind $action ... quotations. In the simplest case, we could wrap action in pure beforehand.

It may work, but this kind of change can easily trigger unforeseen problems.

would still produce the same error.

I was thinking that the Id.run (or the puredo) would make the Id explicit, so this would no longer be a surprising error message. Also, contra https://github.com/leanprover/lean4/issues/770#issuecomment-963539310, on reflection I think it is not a big deal if Id.run/puredo is required to get do behavior in pure context.

BTW, as a user, I would prefer to explicitly use Id than writing puredo.

I second this. Also, @dselsam your example usage of the pure do:

FYI I use this feature all the time to get local mutation.

is very questionable.
What separates pure programming and monadic programming conceptually is precisely the forbidding of things like mutations. In a functional language, If one is using mutations, they should be doing so in a monadic context. And if one doesn't want the algorithm to pollute the function signature with an Id, one can (as you mentioned) use Id.run inside the function to get a monadic context.
The magical injection of a monadic context that Lean currently supports may be a little convenient (though is typing Id.run really that bad?). However, it creates exactly the kind of issues described here. Instead of novice users getting a error message that says something along the lines of can't use do` in a pure context' (which is the conceptual mistake here), they get some opaque error that only makes sense if one fully understands the magic going on beyond the scenes.
Thus, I really think that the idea of a pure do should just be removed.

@tydeu Yeah, the error message "can't use do in a pure context" would solve the problem.
We could include also "consider prefixing the do with Id.run <| to instruct Lean to use the Identity monad". Then, the fix is clear to new users.

Thanks @leodemoura , looks great.


Improve description of branch targeting for action release management

Why:

Fix #2290
Sentence needs rephrasing/simplification

What's being changed:

Clarify use of target branch
Separate clauses for ease of reading
Remove unnecessary conjunction
Replace pronoun to eliminate ambiguity

Check off the following:

[x] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the content style guide for GitHub Docs

@martindes01 Thanks so much for opening a PR! I'll get this triaged for review ✨

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨


Failed to install pycocotools on Windows8 with VS2012 installed

Hi Evan,
This is not directly related to your tutorial, but it fails on my PC and I am wondering if you may help out.
Following your instructions in "2g. Test TensorFlow setup to verify it works" it fails on step

!pip install pycocotools

When I run the command outside the jyputer I get error saying:

cl : Command line error D8021 : invalid numeric argument '/Wno-cpp'

including bunch of others.
Then in your tutorial you mention that you also had issues with pycocotools, so I am wondering if I can ignore this error (comment it out in yupiter file) and proceed without it?
edit: There is no bash on my Windows :-) so these fail also...
Thanks

Update:
Simply skipping the command that does pip install pycocotools does the job. Also where it fails because of lack of bash is also not a problem.
Bottomline, tutorial works if you skip the pycocotools part, and ignore bash errors.


database table's field is case sensitive

accurately, the table field must be lower case.
say:
sql:
tb_mytable{
     TAG_NAME  varchar(50),
}

golang:
type TbMytable struct {
      TagName string,
}

will not work.  unless use the tag
  TagName string  "gorm:column:TAG_NAME"

why not support Case Insensitivity filed name by default? It will be convenient and reasonable.

@qiuchengw this will be tricky issues if do so.

Hmmm, wondering why is this closed


Question

How do I add a text when an Item is tapped, I managed to do a similar app as the GIF shows (autocomplete) but how do I add the token when a cell is tapped?

I figured out how... thanks

hi, did u found solution for delegate/ notification when user click to token?


Caddy subdomain status OK but always got 404

With Caddy 0.11.0 (non-commercial use only)
I want to configure a site with domain p8ji.cn, the caddyfile is following:
p8ji.cn {
  root /var/tmp/p8ji.cn
  log /var/log/caddy/p8ji.cn.log
}

the root path /var/tmp/p8ji.cn layout is:

I started caddy.service and got right status:

Then open the https://p8ji.cn in browser, but 404, refresh, always 404

Any help?😢

Hello, @delapecci
Could you please provide full content of your systemd unit?

Actually i got this one.
If you are using the standard caddy systemd unit there is directive PrivateTmp=true, so there is new directory which is created for you and there are no files which you need.
Change your root in Caddyfile to something other than /tmp or /var/tmp and it would work for you.

I will close this for now.  Thank you @SmilingNavern .
@delapecci feel free to post more info if you wish.


"Live Only" test failures should be identified and flagged with high priority

Is your feature request related to a problem? Please describe.
We have a number of tests that are marked @live_only or LiveScenarioTest because they cannot be replayed as a recording. In these cases, the nightly live run is the only way to detect a CLI regression. Unfortunately, due to the noisiness of the live test system, regressions are not identified and corrected immediately.
Describe the solution you'd like
All data from the live test runs are stored in a database. We can analyze our tests to identify exactly which ones are live only. We should be able to check the daily live test failures and compare it against this list. If a live-only test fails, it should trigger a more elevated response so that it gets immediate attention.
Describe alternatives you've considered
Aside from an automated solution, this scenario relies on consistent, dedicated human intervention, which is not realistic.

@bim-msft add to S162.

for live test,  what we did so far

setup live test pipeline, so that live test could be run regularly or adhoc.
internal doc on how to use live test during sdk version bumping testing scenario

To do

refine email notification for test result
enable regular live test.


Update Chart Data Objects

This is my suggestion for how we should start doing objects from here on out. It provides a ton of advantages from usability to readability. I think we could make our classes all look like this, then use something like marshmallow to provide validations if we need.
This makes these objects read a lot cleaner and makes them easier to
understand. It uses some inheritance for the timestamp and datetime
stuff that is in all of the different chart data content classes.
This also changes how we store this data, since they send a timestamp
and we parse it into a datetime we should just save the timestamp and
only get the datetime when we call the method. This lets us not explode
if the timestamp is not parseable, it will only explode on the call to
datetime().

Code looks good to me. Nice use of generics.


Local emulator storage always loading

Storage Explorer Version: 1.7.0
Platform/OS: macOS 10.14.4
Architecture: x64?_
Regression From: N/A (this is the only version I have used.)
Bug description
After attaching to a local emulator Queues, Blob Containers and Tables are stuck "Loading...".
Steps to Reproduce

Click Add Account.
Chose "Attach to local emulator". Click next.
Fill in fields then click Next.

Display name: local-1
Blobs port: 10000
Files port: 10003
Queues port: 10002
Tables port: 10003

Click Connect.
In the Explorer expand Local & Attached > Storage Accounts > local-1 (Key) > Queues.
Queues will say "Loading..." for around 30 minutes.
Alert will popup saying:

Unable to retrieve child resources.
Details: A network error occurred (NetworkTimeoutError: connect ECONNREFUSED <IP_ADDRESS>:10002)"

It is also not possible to add a new Queue while it is stuck loading. Right click Queues > Create Queue, then type a queue name and press return does not show the new queue in the list.
What I see in the app:

Expected Experience
Queues should load and be able to add a new queue.
Actual Experience
Queues do not finish loading and finally errors with the message above. New queues cannot be added and not feedback is given when a new queue is added - it just disappears.

I asked this question over on Stack Overflow and found out I needed to run the Azurite emulator for Storage Explorer to connect. I wish the official MS guide on Storage Explorer made its clearer that Azurite is needed for both Linux and macOS.

even after running azurite i am not able to get queue working :(


Master -> Live

Docs Build status updates of commit b1eb945:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/Configure-Unity-Project.md
:white_check_mark:Succeeded
View

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/direct-manipulation.md
:white_check_mark:Succeeded
View

mixed-reality-docs/galaxy-explorer-update.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/getting-started-unity-quality-settings.jpg
:white_check_mark:Succeeded
View

mixed-reality-docs/images/getting-started-xr-settings.jpg
:white_check_mark:Succeeded
View

mixed-reality-docs/images/unityqualitysettings-350px.png
:white_check_mark:Succeeded

mixed-reality-docs/unity-xrdevice-advanced.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Infra/more tests

Adds tests

Codecov Report

Merging #143 into dev will increase coverage by 5.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #143      +/-   ##
==========================================
+ Coverage   47.71%   53.69%   +5.97%
==========================================
  Files          11       11
  Lines        1138     1138
  Branches      139      136       -3
==========================================
+ Hits          543      611      +68
+ Misses        586      518      -68
  Partials        9        9

Impacted Files
Coverage Δ

src/pricer/analysis.py
100.00% <100.00%> (+22.38%)
:arrow_up:

src/pricer/sources.py
74.82% <100.00%> (+7.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aacfb...af0de2d. Read the comment docs.


Add code coverage CLI checks for home view

Utilizing Vitest we can setup code coverage reporting, and CLI checks to fail when we do not hit thresholds.

Vitest has a setting which can auto update threshold values when code coverage is improved: https://vitest.dev/config/#coverage-thresholds-autoupdate
It could be possible to commit that if those change in a PR when vitest is run 🤔

Related to https://github.com/posit-dev/publisher/issues/58 ? or does this supersede that one?


Remove workaround for longer heartbeat interval in debug mode

Before contract setup was split into dedicated actors on each side, heartbeats
were not being delivered correctly and the taker would close the connection
half-way through contract setup.
This was especially noticeable in debug mode, as the contract setup could take even
~60 seconds to complete. A workaround was set in place (45s for heartbeat
interval, making it drop connection only after 90s, longer than contract setup).

of course it passed the tests on my machine before posting, but seems to have failed on CI :( if the workaround's needed, the issue is still there :(

Perhaps this is due to our tests only using a single-threaded tokio runtime. If one task is busy (verifying signatures), it might be that the other tasks never get to run! We could experiment with using https://docs.rs/tokio/1.15.0/tokio/task/fn.spawn_blocking.html to do the verification and signing?

@thomaseizinger @luckysori @da-kami  I have come up with a different, IMHO less hacky workaround - instead of trying to have crazy long times for heartbeats in debug mode, I'd like to propose not acting on a "false readings" (ie. when our measurements fell behind due to some compute-heavy task blocking the thread). Please let me know what you think.
@thomaseizinger I also tried using spawn_blocking() and multi-threaded tokio runtime in tests, none of which produced promised results :( happy to look into that someday again, but I hope this one will do the trick in a least hacky way.

bors r+


dependency scope setting issues

Hi,
We are developing a tool to check whether the dependencies' scopes in maven are set rightly and reasonably.
Our tools have found some issues in your project about scope setting in maven' pom.xml file.

in rest\pom.xml, com.github.stefanbirkner:system-rules scope should be test  instead of compile.
in voltdb\pom.xml, org.voltdb:voltdb scope should be compile  instead of provided.
in core\pom.xml, org.codehaus.jackson:jackson-mapper-asl scope should be test  instead of compile.

Please help us confirm whether the above reports are right and explain why it should set like these.
Thanks a lot.

please provide a rationale for each of your claims.


code coverage

https://github.com/nickmerwin/node-coveralls

coveralls
istanbul

in theory it works. :-)

I'll check these later.

Istanbul does not have Windows support and since I develop current on Windows without VM, I won't use that.

Coveralls probably would work, but it is not that easy to configure, and I don't think it's worth the effort. I won't use code coverage. I don't think it is necessary. Let's read about it.

At the beginning of my projects code plasticity is always high and it takes a great effort to follow this frequently changing code with TDD. So it is a pitfall to develop my codes with TDD. On the other hand BDD is a great tool to implement features with constantly changing code, since it does not care about the application interface, it cares only about the features the code implements. So I will use BDD in my projects and I'll add the unit tests probably later, when their application interface becomes stable enough to do so.
According to this answer http://stackoverflow.com/a/90021/607033 the code coverage is not that important. It is more important to understand what amount of tests my application requires. So I don't really need metrics. At least I am not prepared to use metrics by developing. Probably much later by optimizing code, the metrics would help. I never really used it.


Refactor current situation to MVP architecture

Currently, the code is in terrible shape in terms of architecture, everything is mixed up and with every commit it becomes harder and harder to analyse, especially for a newcomer.
Hence, It has been decided that current code (until it gets massive) should be restructured in accordance with MVP (Model-View-Presenter) pattern.
I have forked a good example of MVP implementation, a project from GDG Moscow 2018 StudyJam - https://github.com/ardovic/CurrencyRates, use it as a reference.

Don't worry, I'm working on it O_o

Need any help?

@rajBopche yea sure!


graphicx package

I suggest to change
\RequirePackage{luacode}

to
\RequirePackage{luacode,graphicx}

because graphicx is necessary in all cases.
...Rolf

I had submitted the package earlier today to CTAN, so I guess that might be a thing for v0.2 then.
I had not added this, since I did not want to couple it to either graphicx or pgf tightly.
But since it is a LaTeX package, and the pgfmanual (page 1146) states "For all other backends, PGF currently maps its commands back to the graphicx package.", you're right and it could be changed as suggested.


Add query source to DB spans

Adding OTel compatible information to database spans that show the code location of the query.
Refs https://github.com/getsentry/team-sdks/issues/40
This has to be

[x] "opt in" and
[x] only add the location where the query takes longer than 100ms to run
[x] working with SQLAlchemy
[x] working with Django
[x] working with asyncpg

In the product this will then be displayed with something like this:

Is it possible to tell what the overhead of this is going to be?

Is it possible to tell what the overhead of this is going to be?

Hard to tell. I am "only" walking the stack until i find the right frame and then add the data to the span. But maybe we should do some load testing.
(it is opt-in, so we will not break anything out of the box)

@AbhiPrasad  Did some load testing on an FastAPI example app running 50 concurrent users doing around 85 requests per second:
Without attaching the query source:

With attaching the query source:

The only difference I can see is the 99percentile is a bit slower with attaching query sources (but those are probably some outliers, the the max column)
So I think we are good here.

And here the event as JSON: python-with-query-source.json

One thing to mention: When finding the right frame to attach as query source I am omitting external sources (stuff that is in site-packages and dist-packages)
This works well if someone has for example Django and does queries using Djangos ORM because the queries are done in the users code. But if they have Django and DjangoRestFramework the place in the users code that defines the query does not show up in the stack trace and I can not add the query source.
Which is a bummer, but I think kind of ok, because if they have DjangoRestFramework the transaction name will lead them to their serializer and then they know where to look for the query/queries.


Add WeightToFee and LengthToFee impls to transaction-payment Runtime API

This PR makes a runtime's WeightToFee and LengthToFee impls available via runtime API. The rationale for this is that these are now opaque functions which are not directly available in any way outside of a runtime.
Specifically, a client cannot take an executed extrinsic from a block and validate each portion of its fees without knowing this information (or making some assumptions). We do this extensively in testing on Moonbeam.
polkadot companion: https://github.com/paritytech/polkadot/pull/6536
cumulus companion: https://github.com/paritytech/cumulus/pull/2073

In trying to test this, I came across something unexpected. With my changes (basically my Polkadot companion PR plus some diener-created overrides to this PR), there is no transactionPaymentApi or transactionPaymentCallApi listed under developer -> Runtime calls:

When compiling without my changes (polkadot master), they appear as expected:

It seems others are missing as well, such as accountNonceApi.
Any idea what might cause this?

In trying to test this, I came across something unexpected. With my changes (my Polkadot companion PR plus diener overrides), the transactionPaymentApi and transactionPaymentCallApi both disappear from Developer > Runtime calls -> Calls:

On recent Polkadot master, they both appear as expected:

Any idea what might be causing this?

Any idea what might be causing this?

I believe this is because the type info is currently hard-coded here: https://github.com/polkadot-js/api/blob/ebb9f055c13d663bf3af5fad5043c5461b2f2b8a/packages/api-augment/src/substrate/runtime.ts#L268
Should I open a companion PR to include this new definition there? CC @jacogr
Are there examples of using either the state_call (I think that's the State::call() RPC) or api.runtime (the later doesn't appear in my testing with @polkadot/api 9.11.2).

Indeed. At this point they need to be hard-coded on the JS API until such time as these appear in the metadata. Once there, it appears on api.call.* (assuming the runtime api version matches)
Alongside that, I would really encourage you to bump the actual runtime api version - because we are hardcoding these each version defines a specific shape (and the types). Unless we bump it all these will also appear decorated for runtimes that don't actually have them but has the same version.
(Because of that compatibility issue, the JS API won't be adding them unless there is a version bump since it just ends up with masses of support otherwise when we have mismatched "shapes" of the same version)

All companion PRs are now approved (the polkadot-js one approved verbally :) Let me know if there is anything missing :+1:

Dont know why the CI is read, lets try rebasing.

/cmd queue -c fmt $ 1

bot merge

bot merge

bot merge

Companions were not merged.

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122/1

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/substrate-developer-newsletter-february-2023-notable-updates-for-frame-devs-new-deep-dives-released-calling-builders-to-apply-to-rfps-and-bounties/2137/1


Refactoring the code.

Refactor the code to achieve separation of concern. For the example: remove all the queries in the controller to its special file.

Because all the queries had been moved to separate file. I consider closing this issue.


Bootstrap update for v4

The bootstrap initialisation code (which is a really neat idea BTW) looks for a  temporary element for styling of the main frame,
The panel class was removed in bootstrap 3. In Boostrap 4, we have the "card" class that does the same things.
So the bootstrap.js init code just needs panel replacing with card.
Another niggle with the bootstrap code is that the z-index should be set to make the picker appear above a modal. Bootstrap currently sets the z-index of its modals to be 1050.

I was not using bootstrap integration for ages, so if you're willing to make a PR to make it work with Bootstrap v4 that would be great!

@nazar-pc consider it done.


restore cache on all but ubuntu and latest go

Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:

[ ] Tests exist or have been written that cover this particular change.

@go-playground/admins

Coverage remained the same at 76.07% when pulling e3a9ac5b171f5fb4a22f7ef8074e6dc9cbac17a2 on gh-actions into 3bb48666026cfe1dc2a53ad33ade90c238b99091 on master.


Resolves Issue #55: Update README to correct reference benchmark.

Reference benchmark: CIS Red Hat Enterprise Linux 8 Benchmark v1.0.0 - 2019-09-30
Signed-off-by: Douglas MacDuff<EMAIL_ADDRESS>

I have added your change with my commit last night, there was an issue of workflow in our CI pipeline I needed to work out. I will close this PR, but in the future pr's from your branch will PR to the staging branch. There are some repo secrets needed with our testing pipeline to run, which won't work from your own repo. Thanks for pointing out the issue and implementing a fix. I will also close the associated issue.


License ?

I am reading your paper and wondering under what license is this project released under ? I would like to study how certain parts were implemented in the code. Thank you.

it's under the MIT license, just added it to the repo


What would playing music files look like in Clean Architecture?

Hi,
It is not actual issue, just question.
I am very interested in clean architecture, and my application is about playing audio files. I am about to rewrite my app for the third time (none even complete in 20%), this time using Clean Architecture.
How would playing music files fit in CA? Where should music playing service reside (which layer)?

Dependent on your scope of the application, this could happen in a few layers. An easy solution is to place it in the Data Layer. But myself, i'm more a fan of creating an Infrastructure layer, and having the "music playing service" reside there. This is because the actual implementation of what plays the music is external to your app. The layer starts making sense when you have a lot of these "system services" in the app, like a service for communication with Google Cloud Messaging and so on.

First off I want to say think you for making this project!!! you seriouly made my app 100 times more maintainable. I'm still getting the hang of this structure though. I have a few questions regarding this:

assuming we have an infrastructure layer, would each action on the audio player be represented by a use case? Example: a use case for play and one for skip track... etc?

can something in the infrastructure layer talk directly to the data access layer? or is data passed between the domain layer for the infrastructure layer to get data?

assuming my second question is false ie. We do have to use the domain layer to mediate data... is it a bad practice for the domain layer to request data from the data access layer using a Use Case of course, and return that to the audio player in the infrastructure layer, so we don't have to go all the way out to the presentation layer for this data?

let me illustrate 3 a little bit:
let's say we have a simple interface for our audio player, for the sake of this example:
public interface player {
  boolean loadTrack(String uri); // id here refers to a persisted track in the the local DB.
  void play();
}

in this example it would be ideal to have my use case get the track URI from the data access layer rather than storing that in the presenter layer. Would It be a bad idea to call a data access use case from this play use case to request the track URI from the data layer?
any help on this would be greatly appreciated.

hi @alexwhb , I am facing the same problem and I am very curious about how did you finally resolve this issue. Can you share your knowledge?

Hello @alexwhb, did you find out the solution? I have same problem now

Somehow I never got notified of the @leninZ's question. It's been a long time since I wrote, but I think my advice with the player connecting to the app using UseCases... I would use a MediaSession instead which allows you to easily interface with your player without having to hack a media service together. Then I would only expose a very small part of the interface to your use cases if you absolutely need to control from your Use Cases... I would do all the player logic in the player.
I'd also highly recommend anyone interested look at this project for reference
I would let the player pull data that it needs rather than get data pushed to it from the central system mostly because these two systems live in different lifecycles. I would also not use Use Cases for player actions (though I did in my implementation). It just became really messy.  I would probably dependency inject a service connector into whatever presenter / view model needs access to the player controls and talk directly to the player that way.
Take all of this with a grain of salt. Do whatever works for you.. don't be too dogmatic about structure. If it gets in your way too much it's not worth it IMO.


improve optimize routine load task schedule to make consume real-time and balanced

Proposed changes
If be slot is full, the task will be put in the end, causing the partition corresponding to this task will be delayed in consumption and consumption not balanced.
Therefore, the PR keeps the task still in the head of the queue to avoid it.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


URI Encoding/Decoding

Does the router perform URI encoding/decoding or should application code handle that? I'm seeing inconsistent behavior.
When navigating (href click or push) to a URI with a space in it (e.g. /search/all-results/foo bar) the store contains the space (in the pathname and params) and the browser URL bar displays an encoded URL (/search/all-results/foo%20bar) presumably provided by the router. This is convenient, as I don't have to do any URI encoding/decoding as the store contains the decoded version and the browser URL bar has a valid encoded URL. The href on anchors does contain the space, of which I'm not particularly fond.
The catch is that when refreshing the page, the store subsequently contains the encoded URI in both the pathname and params. If, instead, I URI-encode the space character in the original URI, the URI gets doubly-encoded such that /search/all-results/foo%20bar becomes /search/all-results/foo%2520bar in the browser URL bar.
FWIW I would advocate for all URI encoding/decoding to be handled by the application, not the router. Short of that, it would be good to have predictably behavior and ensure characters like = are supported as params. Currently I'm unable to obtain a string containing = as a param in the URI.
e.g.
Doesn't work (params.id === undefined):
/user/VXNlcjo2MTk4MDc4OTg3MTY5NDc3MzE=/profile for route /user/:id/profile
Works (params.id === "VXNlcjo2MTk4MDc4OTg3MTY5NDc3MzE"):
/user/VXNlcjo2MTk4MDc4OTg3MTY5NDc3MzE/profile for route /user/:id/profile

looks like this isn't an issue anymore. the history lib decodes the url on initialization (https://github.com/ReactTraining/history/blob/dca21eaa9230ae187c72ef657f70aac97cb172aa/modules/LocationUtils.js#L35), so the store will always contain decoded strings.


[Storage] [DataMovement] Improve checking on part completion for pause/stop/completion status

This removes the need for doing a large check on all the Task.IsCompleted and also improves checking the failure status as well when they occur, as Task.IsCompleted sets the status then throws the exception.

API change check
API changes are not detected in this pull request.


DNS DSC

Description
Adds ability to manage DNS using DSC, and to install a module using for
managing DSC
Signed-off-by: Jason Field<EMAIL_ADDRESS>Issues Resolved
N/A
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

What a pain, so doing a suggested fix commit doesn't add the DCO 👎

Closing as we are going to use the windows_dns cookbook.


Finding Port

it's not a issue , but I don't know to how to add the port. Like port do I have to add it would be great if there is a video explanation for this, because I found ollama a opensource to be in our mobile but I kinda feel myself so dumb that I don't know to how to add this port 😅

If you are planning to make it for web, I am really interested to help you out ... I know there are multiple AI software out there which run by ollama but still you like to have a web version which mapped with your app like I would like to work with you bro 😁

The default port of Ollama is 11434. So you most likely have to enter http://<ip>:11434. Make sure you have done the steps discussed in #5 to allow Ollama App to connect.
I'm currently looking into providing a desktop version of the app. Web could maybe be added in the future.

ok bro I will checkout the steps, its still kind of fussy will checkout ...


map() function video contribution

Description 📜
I have added a video contribution for the map() function.
Fixes #572

Type of change 📝

[x] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)

Domain of Contribution 📊

[x] Python_Domain

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Thankyou ma'am !   :)  @Randrita


Re-vendor / cleanup apitools as used in storage

Work plan:

[x] Pull in the subset we use as a non-temporary fork (e..g, gcloud._apitools). #1189
[ ] Get it to 100% unit test coverage using our normal testing style. #1190, #1191, #1191, #1192, #1193, #1196, #1207
[ ] Rename it gcloud.streaming so nose finds its tests. #1208
[ ] Remove unused bits. #1209
[ ] Make it fit our coding standards. #1210

IMO this needs to go in core. As a start you could pull the multi-part message stuff into core?

IMO this needs to go in core.

ATM, I'm pulling the code into a gcloud/_apitools sub-package:  this will include the transfer and http_wrapper modules we use directly, plus those they pull in (util, exceptions, buffered_stream, and stream_slice).
I have these modules imported on a branch, and am adding from-scratch test coverage to them one by one.  Once coverage is complete, I intend to strip deadwood (any APIs we don't use), and then make the modules conform to our standards.

As a start you could pull the multi-part message stuff into core?

I'm not sure which multi-part stuff you mean:  is it the bits currently in gcloud.storage.batch?

I like the approach.

is it the bits currently in gcloud.storage.batch?

Yup

FWIW, apitools is getting more external love via the cloudsdk folks. in particular, they cleaned up the google-apputils and gflags dependencies.
given that, it might be worth using? (i don't remember how much of apitools you use.)

@craigcitro we basically use only the transfer.Download and transfer.Upload classes.

k. forking may well be the better road.

@craigcitro We didn't have time to wait and assumed it would be getting left behind. To me, the fact that there are still no docs does not scream "use this, it's cared for".

We're done, I think.


Remove Kopano wording from readme file

fixes https://github.com/libregraph/idm/issues/3
Signed-off-by: Felix Bartels<EMAIL_ADDRESS>

and thus not have anything in this README which does not work unless you have it installed via packaging on Debian

Yes, I was wondering about that as well while updating the readme, hence the link to the github action for building packages. Have switched it over to a draft again and will rework.

@longsleep readme has been updated


Update tutorial text for Universes

We might want to explain something about Universes? Maybe at the very end of the non-crypto tutorials?


cfn_nag v0.7.2 fails on templates for lambdas that are packaged as containers

We have a lambda packaged as a container image we want to deploy using CfCT. The Cloudformation template itself is valid and a current version of cfn_nag (v0.8.9) finds no failures.  In the CfCT pipeline the validation phase fails because cfn_nag v0.7.2 that is used shows a Failure when Handler and Runtime are not defined.
The error message we get using cfn_nag v0.7.2 is:
Basic CloudFormation syntax error:[#<Kwalify::ValidationError: [/Resources/LambdaFunction/Properties] key 'Handler:' is required.>, #<Kwalify::ValidationError: [/Resources/LambdaFunction/Properties] key 'Runtime:' is required.>]
The newest versions of cfn_nag do allow for the fact that lambdas can be packaged as containers.
I kindly request to update the cfn_nag package used version in CfCT.
Best regards,
Marcel

Thanks for bringing this up @lots2learn, I've gone ahead and created a backlog item with the team to address this

Thanks @balltrev. You get my +1 of removing cfn_nag from the pipeline validation stage. Additional to using cfn_nag before committing, we've written a script that does all kinds of other validations before we commit and kick off the pipeline. This includes checking if all resource files exist, target OUs, Accounts and regions are valid and if all parameters that are mentioned in the manifest actually exist in the resource templates. So lots of overlap of what is done in the pipeline as well, but when there are issues we catch them sooner.

This issue is also impacting myself from creating Container lambdas due to the cfn-nag version being out of date. Any updates on this?

cfn_nag appears to be abandoned by its authors. There are multiple issues with it that prevent CfCT from deploying stacks using common CloudFormation constructs (Fn::ForEach, etc.) that show no sign of being resolved. Could it be removed entirely from CfCT?

If it's removed, what should replace it? “Nothing” is a viable option I think.


Docker compose

Hi,
very nice project.
Are there any plans to be able to use this with docker (-compose)?

Hey, tank you! :)
Unfortunately, I don't really have time for this right now. But i'm open for pull requests :)

The project looks amazing! However, I always wonder how people miss the opportunity to develop something inside Docker from the start to avoid polluting their local environments with dependencies. I might look into it but I'm in family first mode right now for the holidays 😃

True, but i use something like devilbox or laradock for local development. Have good holidays ;)

I always wonder how people miss the opportunity to develop something inside Docker from the start to avoid polluting their local environments with dependencies.

That's because Docker does not solve every problem that exists. While yes, in theory it is undoubtedly better to run everything isolated in its own VMs/Containers, but like many things it comes with its own trade-offs.
If you are not working on a Linux OS then chances are you are running sooner or later in annoying issues like performance slowdowns, file watching issues on mounted volumes or other annoyances like their pseudo tty container access while debugging.
And if you by chance were planning on deploying on an ARM architecture, but have been developing on a x86-64, you would have to go out of your way and start crosscompiling the image too. (Not anymore, I know) Also, in my case, that deployment env (rpi) did not have enough resources to run Docker properly, exclusively anyway. At this point the use case for Docker was rather slim back then in 2016/17, as we both (devfake and I) only deployed this via ssh on a vps and rpi.
Personally, I've been working with Docker and VMs like Bosh for a while now in a cloud-native environment in a cloud-hosting company and at this point I'm "fed-up" with development envs in containers or VMs that I would rather prefer to "pollute" my local machine than bother with these reoccuring annoyances.
I'm not saying Docker is not good or anything, just stating why some people might not wanna bother with Docker sometimes. So feel free to contribute. 👍

So I forked the project (https://github.com/dangerfish96/flox) to add a docker-compose solution; Just because I want to learn how create the containers myself.
But I am stuck at the following error:
flox_1_80b801d0e6f0 | TRYING TO MIGRATE DATABASE
flox_1_80b801d0e6f0 | Nothing to migrate.
flox_1_80b801d0e6f0 | MIGRATION COMPLETED
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 | In Connection.php line 669:
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |   SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'username' can
flox_1_80b801d0e6f0 |   not be null (SQL: insert into `users` (`username`, `password`, `updated_at`
flox_1_80b801d0e6f0 |   , `created_at`) values (?, $2y$10$ESzwusvOchjxSnuaiDa9tdWstzkRPbuVsI18ztK36
flox_1_80b801d0e6f0 |   a9r7XxsUEBxi, 2019-12-23 12:43:34, 2019-12-23 12:43:34))
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 | In PDOStatement.php line 123:
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |   SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'username' can
flox_1_80b801d0e6f0 |   not be null
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 | In PDOStatement.php line 121:
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |   SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'username' can
flox_1_80b801d0e6f0 |   not be null
flox_1_80b801d0e6f0 |
flox_1_80b801d0e6f0 |

What could be the problem here? Is there maybe an interactive input that I am skipping to insert the username?

There's a non-interactive way. 😄
https://github.com/devfake/flox/blob/master/backend/app/Console/Commands/DB.php#L14
There you can see that the command php artisan flox:db accepts default arguments for user and password. So if you'd use for example php artisan flox:db admin admin a user will be created with username "admin" and password "admin".
Could also be added to the readme for future use.

Thank you very much :)

You can have a look at https://git.walbeck.it/mwalbeck/docker-flox - data is stored in /var/www/flox/ and as far as I can tell you need a separate nginx container to invoke the php fpm that's in the flox container (?)

There's an explainer for that container in the issues here. You do need a separate nginx (or other webserver) container - the flox container is flox and php only.
I do have it working with the official nginx docker, but it all falls apart for me when I try to access it via a reverse proxy 😢 .

There's an explainer for that container in the issues here. You do need a separate nginx (or other webserver) container - the flox container is flox and php only.
I do have it working with the official nginx docker, but it all falls apart for me when I try to access it via a reverse proxy 😢 .

I am currently running Flox through a reverse proxy, the branch I am currently running is https://github.com/D3v01dZA/flox/tree/working and I did include some instructions and I also added my own feature to hide tv shows I have completed, feel free to remove that. Remember to run a db init!

I am currently running Flox through a reverse proxy, the branch I am currently running is https://github.com/D3v01dZA/flox/tree/working and I did include some instructions and I also added my own feature to hide tv shows I have completed, feel free to remove that. Remember to run a db init!

Oh nice, I will take a look. Are you planning to publish containers to docker hub or ghcr?

Oh nice, I will take a look. Are you planning to publish containers to docker hub or ghcr?

Probably not, if I did I'd want to make the trusted proxies configurable and I'm not really planning on doing anything else for this right now

Probably not, if I did I'd want to make the trusted proxies configurable and I'm not really planning on doing anything else for this right now

Sorry for the much too late reply. I will close this issue because i will completely redevelop Flox. In the next version, docker support will be included.


v-slice support

would this mod chart system theoretically support base game with its new rendering for its sustain notes? or are the changes to much? any help is appreciated as I could not get it working when I tried. tho I might be doing things wrong

specificaly. the 4.0 bbuild is what i tried

It would likely need to be rewritten almost from scratch

specificaly. the 4.0 bbuild is what i tried
uhm, MT does not support fnf vslice and won't support it due it being too buggy, once game itself releases i'll myself work on MT for vslice, for now its limited to psych engine and leather + there is already someone making a modchart template for vslice

specificaly. the 4.0 bbuild is what i tried

uhm, MT does not support fnf vslice and won't support it due it being too buggy, once game itself releases i'll myself work on MT for vslice, for now its limited to psych engine and leather + there is already someone making a modchart template for vslice

oh? is their any public github I could look into then? that would be awsome if so

specificaly. the 4.0 bbuild is what i tried

uhm, MT does not support fnf vslice and won't support it due it being too buggy, once game itself releases i'll myself work on MT for vslice, for now its limited to psych engine and leather + there is already someone making a modchart template for vslice

oh? is their any public github I could look into then? that would be awsome if so

Im sorry, but its not public yet due how buggy VSlice is, but im sure it will be public once VSlice became a stable engine

but im sure it will be public once VSlice became a stable engine

*if VSlice became a stable engine


test add some update-example in doris's doc to regression test

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx
Problem Summary:
Check List (For Committer)

Test

[x] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No colde files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[x] Yes. https://github.com/apache/doris-website/pull/1267

Release note

None

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


style: css and dom fixes for better mobile and layout [sc-00]

Affected Components

[ ] Content & Marketing
[ ] Pricing
[ ] Test
[ ] Docs
[ ] Learn
[x] Guides
[ ] Other

Pre-Requisites

[ ] Code is linted (npm run lint)

Notes for the Reviewer

Cards are clickable now. No need to snipe the links.
Small CSS fixes to align card items easier and neater.

New Dependency Submission
Screenshots

Feels like we moved backwards in styling? How come we added these dropdown carets instead of the icons?


int/long fix

Might closes #95

Not sure if it will really closes #95 as I wasn't able to reproduce issue but it shouldn't break anything

Coverage decreased (-0.3%) to 88.568% when pulling 3d18662572cbf37bb0e3e6f4d93fe42a12da9406 on femtotrader:int_long into 4507a284c1670c3428615db506450632931efa67 on mhallsmoore:master.

Hi @femtotrader , thanks for looking into this. I ran the same backtest with the updated code and  returned the below error:
File "C:\Users\Andre\Anaconda3\envs\python27_env_tradeEngine\lib\site-packages\qstrader\statistics\simple.py", line 57, in update     pct = ((self.equity[-1] - self.equity[-2]) / self.equity[-1]) * 100 ZeroDivisionError: float division by zero
I have since reverted back and added:
 @staticmethod     @dispatch(long)     def display(x):  # flake8: noqa         return round(x / PriceParser.PRICE_MULTIPLIER, 2)
This now resolved the original issue. The second issue I mentioned was due the initial investment amount being less than the default 100 shares and default 1USD commission
I am using Python 2.7.12 :: Continuum Analytics, Inc., Windows 10 64-bit

long doesn't exist with Python 3
so
try:
    long
except NameError:
    long = int

could help for Python 3 support

@femtotrader - Perhaps we should we add in your fix:
try:
    long
except NameError:
    long = int

And then merge?

I don't think we should merge this for now as I haven't been able to reproduce error on my side and with Continuous Integration.
Maybe you or @ryankennedyio have been able to reproduce it ?
An other idea could be to setup an other CI environment (Windows specific) like AppVeyor
https://github.com/mhallsmoore/qstrader/issues/108

@femtotrader sorry, don't have a Windows computer.
I do have a Windows VM on an old macbook air, I can probably spend a few hours trying to set qstrader up on that?

good idea because I don't think it's a great to merge a fix if we haven't been able to reproduce this issue

Sorry folks. Haven't been able to set up a Windows version of this very successfully. Mostly due to windows being a general pain. I can't sink much personal time into windows compatibility to be honest.


🎉 Recipe app 🎉

📝  PR Description:
This pull request adds the long-awaited login and registration pages to our application, providing a seamless user experience and enhancing our platform's functionality.
🔑 Login Page:
The login page allows existing users to securely access their accounts and take advantage of all the amazing features our application offers. With this addition, users can easily log in using their registered email and password.
✍ Registration Page:
We have also implemented a registration page, empowering new users to create accounts effortlessly. By filling out a simple form, users can join our community and enjoy all the benefits we provide.
🍽 Food List and Recipes List:
In addition to the login and registration pages, we have further expanded our platform's capabilities by implementing two crucial features: the Food List and the Recipes List.
🥦 Food List:
The Food List now incorporates full CRUD (Create, Read, Update, Delete) functionality. Users can easily manage their food items, add new ones, view existing ones, and delete any they no longer need. With these capabilities, users have complete control over their food inventory.
📚 Recipes List:
Similarly, the Recipes List also boasts full CRUD implementation, allowing users to create, view, and delete recipes. They can explore a wide range of delicious recipes shared by the community and contribute their own culinary creations. With these features, users can keep track of their favorite recipes and discover new ones.
🛒 General Shopping List View:
We've taken convenience a step further by introducing a comprehensive shopping list view. This feature dynamically generates a list of all the missing food items needed for the user's recipes. Moreover, it calculates the total price for these items, making grocery shopping a breeze.
📋 Public Recipes List:
To foster a sense of community and inspire users, we have included a public recipes list. Users can explore and discover recipes shared by other members of our platform. Each recipe includes the name and total price, giving users a glimpse into the culinary wonders created by others.
✨ Let's make our application even more amazing together! Please review and merge this pull request to bring these exciting features to our users. 🚀
✅ Testing:
We have thoroughly tested each feature to ensure a smooth user experience and minimize any potential issues. The code has been reviewed by our QA team, and all tests have passed successfully.
🎉 Thank you for considering this pull request. 🍽👨🍳👩🍳

Hi @Rudy-Menekam,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! :+1:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding! :1st_place_medal:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hello @BenMukebo , to comply with the suggestion from the previous reviewer, kindly check  to access the new PR.
Thanks for the review.
8:27


LogonScript k3s installation (intermittent failiure)

Is your issue related to a Jumpstart scenario, ArcBox, HCIBox, or Agora?

https://azurearcjumpstart.io/azure_arc_jumpstart/azure_arc_k8s/aks_hybrid/aks_edge_essentials_single/#post-deployment
Describe the issue or the bug
When LogonScript executes, it failed to download k3s. This could be just an intermittent network failure. The script continues to run with "Deployment successful", even though k3s failed to install. See logs below. At the very least, I think this should throw an exception or even better, maybe have a retry logic.
I did create another VM and was successful the second time.
To Reproduce

Follow the Jumpstart to deploy an AKSEE VM
Log In to trigger the LogonScript
Watch script logs

Expected behavior
Installation of k3s successful
Screenshots
LogonScript logs excerpt
--- Verifying AksEdge Install Configuration...
* AKS Edge Essentials - K3s to be installed
*** No errors found in the Install Configuration.
Installing AKS Edge Essentials - K3s from https://aka.ms/aks-edge/k3s-msi
PS>TerminatingError(Invoke-WebRequest): "Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."
failed to download from https://aka.ms/aks-edge/k3s-msi
Deployment Successful.

Checking kubernetes nodes

Full log attached below
LogonScript.txt

Thank you for the feedback.
This message in your logs indicates some kind of network interruption. As part of our ongoing development we will continue to add additional error handling and retry logic where possible. Glad to hear that retrying the script was successful and thank you again for your feedback.
Installing AKS Edge Essentials - K3s from https://aka.ms/aks-edge/k3s-msi
PS>TerminatingError(Invoke-WebRequest): "Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."


[WIP] Testing gradle test

I think #19 might not even be needed...

Validated that no more changes are needed to fix Gradle tests.


Added sections 4, 5 & 6 of chapter 9 - Italian

As mentioned in #45, I am adding the sections 4,5 and 6 of chapter 9 in Italian. 🙂

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @lewtun , apologies for the ping. Not sure if you saw this PR :)


opt print ignored runtime filter in shape/physical plan

Proposed changes
shape plan and physical plan should display the "ignore" tag of ignored runtime filters, like
hashJoin[INNER_JOIN bucketShuffle] ... build RFs:RF0 r_regionkey->[n_nationkey];(ignore)RF1 r_regionkey->[n_nationkey]
Issue Number: close #xxx

run buildall

run buildall

run buildall


Test tag version

Spoke with Kostas and agree to move with this solution until https://github.com/orgs/community/discussions/65447 is fixed


Update to 2 in STEP and README.md

Comparing Main to CI base and merging

Comment on merge pull request, possibly merging in the correct direction


Path matching is creating confusion, so ask you to include the below to avoid confusion.

though the file name (the link below calls file.gif a path) is only under INCOMING MATCH, its creating confusion, can you update the document which should somewhere say the custom forwarding path should not include the file name and should only include the directory instead.
I see the same question asked last year as well regarding filename inclusion in the forwarding path, so this avoids the confusion here. https://github.com/MicrosoftDocs/azure-docs/issues/21287

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c9317fa-eb84-c6f2-2943-f4572059b4cd
Version Independent ID: fdfe5fc4-a7ec-e0fa-2ed1-1632dfd37b20
Content: Azure Front Door Service - Routing rule matching monitoring
Content Source: articles/frontdoor/front-door-route-matching.md
Service: frontdoor
GitHub Login: @sharad4u
Microsoft Alias: sharadag

@peddabavisriram Thank you for your query. We will investigate and update further on this.

@peddabavisriram, Recently there has been a new feature released for front door service which can perform URL rewrite to file instead of the path. This will allow a URL rewrite to rewrite a path to a file. You can refer to the feedback forum here.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Must the protobuf compiler be built from sources before a simple scala_binary?

Hello the rules_scala team.
I'm trying to build a simple scala_binary rule:
scala_binary(
    name = "hello-bin",
    srcs = glob(["*.scala"]),
    main_class = "Hello"
)

My command line:
bazel run -c opt --jobs 4 hello-bin

But the first thing Bazel is doing is the compiling of protobuf compilers for many languages:
Compiling src/google/protobuf/compiler/command_line_interface.cc [for host]; 3s local
Compiling src/google/protobuf/compiler/cpp/cpp_file.cc [for host]; 2s local

This is a piece of C++ code, well I have a C++ compiler on my machine, but this is not a thing that must be expected by any Java/Scala developer. There is no any protobuf in my hello world project and I use no scala_proto_library in the build configuration.
Can you make the protobuf an optional dependency that will be taken into account only when the scala_proto_library rule presents? I believe it can gain better user experience for your amazing project.
Bazel version: bazel 4.0.0
OS: Windows 10

Hi @samolisov,
protobuf is used internally by rules_scala and cannot be avoided at the moment.
However you can avoid compiling it and use released binaries. To do so you need to declare rules_proto repository and it's dependencies before rules_scala like here.

@simuons Thank you for the suggestion. The solution works fine, the initial build of my project has been much faster.

For others arriving here late, @simuons's link is mutable (pointing at master). The code originally referneced is https://github.com/bazelbuild/rules_scala/blob/475cc5b2379c4b08f81359e12399bf6d171b5636/WORKSPACE#L14-L31

Is there any news on that?
I still get protobuf always compiled, no matter what I try
That is kind of annoying because that is super slow, for a relatively small scala project that builds with sbt in 2 minutes,  the bazel build takes 8 on CI (github actions)


DCOS-52080 - Fix AWS Onprem w/ Static Backend and Security Permissive CI

Backport of  https://github.com/dcos/dcos/pull/5634/
Fixes: DCOS-54487 - test_dcos_diagnostics_bundle_create_download_delete fails on Permissive mode cluster

@mesosphere-mergebot label  ready for review


Reduce calls to Sentry API

It's not necessary to query for the list of teams in an organisation AND the list of projects for a team AND the projects in the organisation.
The team list already contains a list of projects within it.  Just need to create a mapping from that

Resolved by #8


CMake package support

This PR updates the CMake support in DirectX Tool Kit to support find_package(directxtk12 CONFIG):
find_package(directxtk12 CONFIG REQUIRED)

target_link_libraries(foo Microsoft::DirectXTK12)

Related to this issue: https://github.com/microsoft/DirectXTK/issues/247


Mac bug: Game does not start

I downloaded the latest binary zip abstreet_mac_v0_2_2.zip, extracted it within my Downloads folder, and attempted to run it. It crashed.
This happens either running the binary in a shell or double-clicking on it.
MacBookAir9,1
OSX 10.15.5
➜  abstreet_mac_v0_2_2$ RUST_BACKTRACE=1 game/game
Inner window size is PhysicalSize { width: 1600, height: 1200 }, monitor is PhysicalSize { width: 2880, height: 1800 }, scale factor is 2
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Os { code: 2, kind: NotFound, message: "No such file or directory" })', /Users/runner/runners/2.263.0/work/abstreet/abstreet/ezgui/src/runner.rs:214:21
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::option::expect_none_failed
   9: ezgui::runner::run
  10: game::main
  11: std::rt::lang_start::{{closure}}
  12: std::panicking::try::do_call
  13: __rust_maybe_catch_panic
  14: std::rt::lang_start_internal
  15: main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Can you run play_abstreet.sh? Or from terminal, be sure to execute the binary while your current directory is game/. In the released version, it looks for the ../data/ directory and is very particular about where you start it. I finally fixed this problem today, so you could run the binary from anywhere, but that's not packed in a release yet

Nice, running that shell script works for me. I just went looking for a binary & tried to run that to start, but guess that was the wrong move.

Great! I'll close this bug then. By next Sunday, running the executable will also work.


Add a static code inspection to identify tutorial links presented in the Skyline start page that do not correspond to the links found in our tests

Note this test will fail until these are cleaned up, at which time we can merge this to master.

ref https://skyline.ms/issues/home/issues/details.view?issueId=953 "add a code inspection test to check that the start page Tutorials tab uses the same links as the Tutorials tests"


Fix double percentage in LiveStatus of status-page

CLA Assistant Lite bot ✍ All contributors have signed the CLA

Thanks for opening this PR! This has already been fixed in upptime/status-page#64


Cannot build on arm64

When running xcodebuild in the source directory, the build failes. This happens with x86_64 and arm64e.
/Users/kloenk/Developer/java/jtouchbar/src/main/objective-c++/Bridged/JNI/JNIContext.h:16:10: fatal error:
      'jni.h' file not found
#include <jni.h>

Apple Silicon macs (at least on macOS monterey) do not have JavaVM framework anymore. I managed to compile jtouchbar this way.
I used sdkman.io to install a java jdk. Then the header search paths must be modified to point to the sdkman jdk include location for both jni.h and jni_md.h (the darwin implementation).
All references to #include <JavaVM/JavaVM.h> must be deleted as well as the framework reference to JavaVM.

@derreisende77 can you do a fork of the project that's compatible with m1?

@VoltixIGS Unfortunately no as I stopped using the lib and deleted all files. But it wasn't that difficult to build.

@derreisende77 i tryed doing what you explained but i could not get it to compile i was getting an error like "missing symbols for arm64"

Dunno if you still need it but I got it to build just fine on my M1 MacBook by following their instructions exactly, I can upload a fork or something tomorrow

@estyseesghosts yeah i need it if you can upload the fork

It's been posted
On Thu., Mar. 10, 2022, 7:15 a.m. VoltixIGS, @.***>
wrote:

@estyseesghosts https://github.com/estyseesghosts yeah i need it if you
can upload the fork
—
Reply to this email directly, view it on GitHub
https://github.com/Thizzer/jtouchbar/issues/57#issuecomment-1064046599,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP6MYNHFPYI5UGF6PP47SW3U7HYYFANCNFSM4YZSLCDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


pin: r-base 4.2.0

this PR sets a min pin for r-base at 4.2.0, which will bring us up to date with the latest bioconductor-dada2 release and will allow for compatibility of bioconductor-ancombc within q2-composition, which requires r-base 4.2.0.

I messed up, we need underscores


Instructions for Node.js Hello World are incorrect

The readme says to clone a subdirectory of this repository. git does not allow this.
git clone https://github.com/vercel/examples/tree/main/solutions/node-hello-world
Cloning into 'node-hello-world'...
fatal: repository 'https://github.com/vercel/examples/tree/main/solutions/node-hello-world/' not found

https://github.com/vercel/examples/blob/main/solutions/node-hello-world/README.md

Hi! I'd like to work on this issue. If no one else is currently working on it, I'll submit a PR shortly.


fix: race condition of credentials

Closed in favor of https://github.com/googleapis/google-auth-library-java/pull/1031


config: Do not run "go tool vet" on files

"go tool vet" can only be used on a set of files if they are all in the
same package. It however can be used on a set of directories or package
paths.
Fixes: #307
Signed-off-by: Rob Bradford<EMAIL_ADDRESS>

Unfortunately this fix is not correct, as go vet recurses by default when provided with a directory:
By directory:

go tool vet source/directory

recursively descends the directory, vetting each package it finds

cc @dnephin

hmm, yes that's a problem. I guess we need a different way to partition for go tool vet.
According to https://github.com/golang/go/issues/11727 this PR would be correct if we used go vet  instead of go tool vet.
According to https://golang.org/cmd/vet/ these would run the same checks. Unfortunately it seems that go vet does not support the -shadow flag.
I wonder if it is possible to fork the tool and add support. I will look into it more and otherwise add a third way of running (partition files by packages).

@dnephin I'd prefer having a new partitioning option to forking.


why the test result no the same ?

Expected behaviour
Actual behaviour
Environment Details

Karma version 4.1.0

var webpackConfig = require('../../build/webpack.test');

module.exports = function (config) {
    config.set({
        // to run in additional browsers:
        // 1. install corresponding karma launcher
        //    http://karma-runner.github.io/0.13/config/browsers.html
        // 2. add it to the `browsers` array below.
        browsers: ['Chrome'],
        frameworks: ['mocha', 'sinon-chai'],
        reporters: ['spec', 'coverage'],
        files: ['../../node_modules/babel-polyfill/dist/polyfill.js', './index.js'],
        preprocessors: {
            './index.js': ['webpack', 'sourcemap']
        },
        webpack: webpackConfig,
        webpackMiddleware: {
            noInfo: true
        },
        coverageReporter: {
            dir: './coverage',
            reporters: [
                {
                    type: 'lcov',
                    subdir: '.'
                },
                {
                    type: 'text-summary'
                }
            ]
        }
    });
};

Steps to reproduce the behaviour

when i test all files, some file show the result wrong, but when i want to fix the file , so i test the file single .there is no error, its test pass.  why ?

Probably one of your tests does not cleanup after itself. Let's say test B modifies some variables and doesn't reset them to original values. Then test A relies on this variables and fails if test B was run, but works if it was not. This sounds more like issue with your tests and not with Karma.

ops, it because i use  vue-test-utils . it influences my old files test . when i remove it , my test work good.
its really make me feel sick.......


Add vertical merge feature to table cells

John please consider this approach to implement vertical merge in table cells.
Maybe its not too sophisticated, but it works. Here is how:
vmerge = nil
if condition_to_continue_merge_cell
     vmerge = 'continue'  #probably you want this to be more fancy
elsif condition_to_start_new_merge_cell
     vmerge = 'restart'  #probably you want this to be more fancy
end
cell = Caracal::Core::Models::TableCellModel.new do
     vertical_merge vmerge unless vmerge.nil?
     p 'Foo text'
end

I think is a good place to start.  What do you think?
More info here, look for vMerge property

Thanks for this.  The feature was recently implemented a bit more completely by another user, so I'm going to close your PR.  Table cell styling now supports colspan and rowspan, which work exactly as you would expect.


Update BasicFileSystemExample.nfproj

Updating <OutputType>.
Description
Set value of <OutputType> to Exe.
Motivation and Context

Allows project to debug on connected device.

How Has This Been Tested?

Debugs on device.

Types of changes

[ ] Improvement (non-breaking change that improves a sample)
[x] Bug fix (fixes an issue with a current sample)
[ ] New Sample (adds a new sample)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Sour-Codes sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Math magician: Refactor with Hooks

This pr consists of:

[X] I refactored the Calculator component from a class-based component to a functional component with hooks.

Thank you for reviewing my project

Hello reviewer: This project has a git flow, The first commit I did on this branch is for Refactor with Hooks, the above git flows are the ones resulting from the previous branches that I have not merged earlier!
Thank you for your kind attention.


Certification time

My extension has the status "Microsoft is reviewing your submission right now" for 31 days so the "up to 7 business days" line should be changed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 303075ec-ed9b-7ba4-15c5-242f93d53eb2
Version Independent ID: 15d3653d-af25-8ee7-2e94-01057a734de4
Content: Publish An Extension - Microsoft Edge Development
Content Source: microsoft-edge/extensions-chromium/publish/publish-extension.md
Product: microsoft-edge-chromium
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

"Microsoft is reviewing your submission right now" in Extension Overview
is likewise misleading, and should be changed! My experience:

Approval in Google (Chrome): prompt
Approval by Mozilla (Firefox): very fast
Approval by Microsoft (Edge): the check is in the mail

Makes me question why I did an Edge version of my extension.

UPDATE: Not as bad as I expected.
Took 2 days to get a rejection.
The reasons were silly, easily fixed, and I've resubmitted.
Will be interesting to see how long it takes this time,
and if I'll have to go through any more cycles.


[Automated] Update eventing-istio-eventing-kafka-broker nightly (#339)

Update eventing-kafka-broker nightly
Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Running on SQL Server

I noticed that you already have drivers for MySQL and PG, If I want to run this on SQL Server (on Windows), I assume I need to write a new driver.  Is there anything else that I need to change?

Thanks for reaching out. Yes, I think you only need to write a new driver. Thanks. Please let me know if you have any other troubles. If it doesn’t work well, I can provide further help.


The O(n^3) complexity of importRandomAddress

…peration
Issue Number

#1903
Overview

[x] I have added integration test illustrating the issue
[ ] solution

Comments

Can this be benchmarked in the db bench?
We have a benchmark for SeqState but not RndState.

closing in favor of #1911


Cannot create ListView command Set Extension on an on-premise SP2019 solution using the latest Yeoman generator

Hi all. I've just installed the latest versions of all the dev tools (gulp, yo, generator, node 14.7.1 etc) as per the MS article on https://docs.microsoft.com/.../set-up-your-development...
I'm getting the following error when I try to create a ListView Command Set extension on a SP2019 on-prem solution:
Error: ENOENT: no such file or directory, scandir '....\AppData\Roaming\npm\node_modules@microsoft\generator-sharepoint\lib\generators\onPrem19CommandSet\templates\none'
The "templates" directory that the generator is looking for does not exist.
Did anyone experience the same issue?
Many thanks in advance.

Thanks for the information - we'll take a look.
Note that when creating solutions for on-prem, your environment has to match the older install requirements.  See this - https://docs.microsoft.com/en-us/sharepoint/dev/spfx/sharepoint-2019-support
In the meantime, there is no real benefit from using the 1.12.1 generator compared to earlier versions.  You should be able to install 1.11.0 or 1.10.0 to work around this.

Hi @hesperanca - can you share more details if this is still an issue for you if you match the Node etc. with the provided documentation for the SharePoint 2019. We can't really provide exact assistance without knowing more from your environment, so thanks for your details advance.
If you are building SPFx solutions for SP2019, you cannot use the latest node and SPFx versions - please see the following for details https://docs.microsoft.com/en-us/sharepoint/dev/spfx/sharepoint-2019-support

Hi Vesa,
Thanks for coming back to me.
I am using the 1.12.1 generator to create the scaffolding for a SP2019 project. Then generator correctly setups the project to run SPFX 1.4.1. I'm also running all the supported versions of the tools (as per the link you sent) namely:
Node 8.17.0
yo 3.1.1
gulp 3.9.1
The problem seems to be caused by a missing folder on the generator installation. The entire "templates" folder seems to be missing from the "AppData\Roaming\npm\node_modules@microsoft\generator-sharepoint\lib\generators\onPrem19CommandSet"
which causes the error displayed in my original message when I try to create a Command Set extension project for SP2019.
The way I've managed to get around the issue was by copying the missing folder from the yo PnP SPFX generator into the yo Microsoft SPFX generator.
I hope this helps.
Regards,
Hugo

Thanks for the update @hesperanca - we will update our 2019 docs to point at a better generator version.

Thanks for the update @hesperanca - we will update our 2019 docs to point at a better generator version.

Sorry, @patmill . What do you mean by this? Will the latest MS yo generator still have the option to generate projects for SP2019? If that option will still be there then the issue should be fixed instead of simply updating the documentation. Otherwise, it will be very confusing for people ( why leave an option available that we know it's not working?)

@hesperanca - the option will be removed in v1.13 (is has been already removed in beta).
As we're not investing in supporting that option going forward, we will update the docs to reference correct version of the generator to be used for on-prem solutions.


test: failing many-to-many revalidateRelations test

Related to this issue: https://github.com/psteinroe/supabase-cache-helpers/issues/390
This PR includes a failing test for revalidateRelations when dealing with many-to-many relationships and a junction table. This includes a new migrations that adds two new tables: address_book and address_book_contact. address_book and contacts have a many-to-many relationship through the new junction table address_book_contact. In the test, we get a specific address book and all the related contacts that have access to it. When we remove a contact from the address book, we need to invalidate the original address book query cache so it will be re-fetched.
Hope this helps!

thanks, that helped a lot @Keithcat767! fixed two bugs thanks to your issue + test. I didn't want to fiddle in your pr, but would you be so kind and remove the comments etc from this so we can just merge the test?

thanks, that helped a lot @Keithcat767! fixed two bugs thanks to your issue + test. I didn't want to fiddle in your pr, but would you be so kind and remove the comments etc from this so we can just merge the test?

Awesome! Glad to hear it! Yeah, I can remove those and clean up the test a tiny bit in an hour or so.

thanks, that helped a lot @Keithcat767! fixed two bugs thanks to your issue + test. I didn't want to fiddle in your pr, but would you be so kind and remove the comments etc from this so we can just merge the test?

Awesome! Glad to hear it! Yeah, I can remove those and clean up the test a tiny bit in an hour or so.

great, thanks! just merged the pr that fixes this, so your test should be green.

thanks, that helped a lot @Keithcat767! fixed two bugs thanks to your issue + test. I didn't want to fiddle in your pr, but would you be so kind and remove the comments etc from this so we can just merge the test?

Awesome! Glad to hear it! Yeah, I can remove those and clean up the test a tiny bit in an hour or so.

great, thanks! just merged the pr that fixes this, so your test should be green.

Confirmed the test passes when I update the import in useDeleteItem, but it looks like we will need a new build of core to get the test to pass on its own. The useDeleteItem hook relies on the built core package it looks like:
import {
  deleteItem,
  DeleteItemOperation,
} from '@supabase-cache-helpers/postgrest-core';

@Keithcat767 its actually simpler - the migration just needs an on delete cascade so that we can cleanup the test by deleting the contacts properly. otherwise it interferes with the other test. added it for you, should pass now! thanks again.

@Keithcat767 its actually simpler - the migration just needs an on delete cascade so that we can cleanup the test by deleting the contacts properly. otherwise it interferes with the other test. added it for you, should pass now! thanks again.

Doh! Good catch!


fields needs to be imported in examples

neither attrs as a whole nor field is imported from attrs. Therefore the example using field does not work if one goes through the examples step by step. either import fields from the beginning (as suggested) or in the example using fields.
Summary

Pull Request Check List

[ ] Added tests for changed code.
Our CI fails if coverage is not 100%.
[ ] New features have been added to our Hypothesis testing strategy.
[ ] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).

[ ] ...and used in the stub test file tests/typing_example.py.
[ ] If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.

[ ] Updated documentation for changed code.

[ ] New functions/classes have to be added to docs/api.rst by hand.
[ ] Changes to the signature of @attr.s() have to be added by hand too.
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
Find the appropriate next version in our __init__.py file.

[ ] Documentation in .rst files is written using semantic newlines.
[ ] Changes (and possible deprecations) have news fragments in changelog.d.
[ ] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

I would prefer if you imported field when it's used for the first time. Think it keeps the flow better.

I would prefer if you imported field when it's used for the first time. Think it keeps the flow better.

I 100% agree in general, but I think it's fair enough to import the two most important functions at once.

Thanks!


Incomplete pip release?

When installing pyopenxr-1.0.2401 on windows 10 for python 3.10, trying to import gives me an ImportError out of the box:
import xr

# Query the available VR/AR extensions
available = xr.enumerate_instance_extension_properties()
print([i for i in available])

->
Traceback (most recent call last):
  File "C:/Users/nhamm/Desktop/xr_test.py", line 1, in <module>
    import xr
  File "C:\Program Files\Python310\lib\site-packages\xr\__init__.py", line 1, in <module>
    from . import (
ImportError: cannot import name 'api_layer' from partially initialized module 'xr' (most likely due to a circular import) (C:\Program Files\Python310\lib\site-packages\xr\__init__.py)

Downloading the repo as a zip and dragging the apparently-missing api_layer and extension folders into C:\Program Files\Python310\lib\site-packages\xr\ resolves, but likely something's up with the instance on pip for py3.10

Thanks for investigating and reporting this. I probably neglected to update the setup configuration correctly.

@nhammond129 Thank you very much for bringing this to my attention. Could you please try uninstalling then reinstalling the new 1.0.2402 version then report back here whether the problem is resolved?

Well we are getting closer. Please try 1.0.2403.
I suppose this means it's about time for me to set up continuous integration for this project.
Thank you for reporting the problems.

Awesome! Thank you so much @timrobot for your help and patience.

Could you please try uninstalling then reinstalling the new 1.0.2402 version then report back here whether the problem is resolved?

Sorry for the slow reply, but works for me now as well!
Thanks @cmbruns !
Future google delvers:
Fixed as of 1.0.2403, and double-check that you're doing pip install --upgrade pyopenxr and not pip install --upgrade openxr as I just did for a good 20 minutes with much confusion.


Fusiontableserror

@afmckinney
Please review this and check that it does not break the Youth Radio app.   To test it change the Youth Radio app to issue a bad query with a SQL error, for example in a SELECT statement,

@halatmit LGTM, moving to Gerrit

MERGED


Propagate phy::RawSocket send error to caller

For #587

Thanks for the PR!
Now that I look at it again (sorry!) in receive, WouldBlock errors are propagated and everything else panics (instead of returning Illegal): https://github.com/smoltcp-rs/smoltcp/blob/61639d59211024f88ba1004740a1fe3cfd842b81/src/phy/raw_socket.rs#L75-L76
send and receive should probably be consistent, either both panic or both returning an error. I don't know in which cases can a RawSocket send/recv fail, I think they should be fairly rare since it's a "virtual" network thingy instead of actually talking to a peer, so maybe panicking is better?

I generally lean towards propagating any error, but in the name of consistency, it makes sense to have the same behavior on both. If I run into other errors, I can a separate issue!


API/CLI discrepancy on hostname validation (#21595).

This fix tries to fix the discrepancy between API and CLI on hostnamevalidation. Previously, the hostname validation was handled at theCLI interface in runconfig/opts/parse.go and return an error if the hostname is invalid. However, if an end user use the remote API topass the hostname, the error will not be returned immediately.Instead the error will only be thrown out when the container creation
fails. This creates behavior discrepancy between API and CLI.
In this fix, the hostname validation was moved to verifyContainerSettings so the behavior will be the same for API andCLI.
After the change, since CLI does not handle the hostname validationany more, the previous unit tests about hostname validation on CLIin runconfig/opts/parse_test.go has to be updated as well becausethere is no validation at this stage. All those unit tests are movedto integration test TestRunTooLongHostname so that the hostnamevalidation is still properly covered as before.
Note: Since the hostname validation moved to API, the error message changes from invalid hostname format for --hostname: toinvalid hostname format: as well because --hostname is passedto CLI only.
This fix fixes #21595.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

LGTM

@yongtang I think the invalidHostnames should be removed all together them, as there is almost no purpose on keeping them (other than we don't validate anything anymore).

I should add, there are invalid characters on Windows: ComputerName cannot use spaces or any of the following characters: { | } ~ [ \ ] ^ ' : ; < = > ? @ ! " # $ %  ( ) + / . , * &, or contain any spaces.` from https://technet.microsoft.com/en-us/library/ff715676.aspx

Thanks @jhowardmsft @vdemeester @calavera for the review and providing great information. It looks like I will need to make changes so that Windows platform could be taken into consideration. I will update the pull request soon.

@vdemeester The invalidHostnames have been removed.

@vdemeester @jhowardmsft: I may need some input with respect to hostname check in Windows. I am not very familiar with how Docker works cross-platform so I am not sure where to perform the hostname check.
Should the hostname check be done separately for Windows and Linux, one in daemon_windows.go and  another in daemon_linux.go?
Or we need to combine the hostname restrictions in Windows and Linux to have one check for all platforms? At the moment the different between Linux and Windows check is that

64 bytes for Linux and 63 bytes for Windows
Windows does not allow . char.

Any input would be much appreciated.

Linux and Windows check is that

64 bytes for Linux and 63 bytes for Windows
Windows does not allow . char.

Hm, a quick search brought me; http://www.ietf.org/rfc/rfc1035.txt

The labels must follow the rules for ARPANET host names.  They must
start with a letter, end with a letter or digit, and have as interior
characters only letters, digits, and hyphen.  There are also some
restrictions on the length.  Labels must be 63 characters or less.

And https://tools.ietf.org/html/rfc1123

The DNS defines domain name syntax very generally -- a
string of labels each containing up to 63 8-bit octets,
separated by dots, and with a maximum total of 255
octets.

So looks like 63 characters is actually the right length

@thaJeztah Thanks. The 64 bytes was from the Linux reference:
http://man7.org/linux/man-pages/man2/gethostname.2.html
I tested with 64 and 65 bytes hostnames on Linux and 64 bytes is fine (65 bytes will throw out an error). Also hostnames in Linux could contain . (dot) which seems to be different from Windows.

Windows has two things: host name and computer name. For containers, we take the provided host name and convert it to a computer name by upcasing and truncating it. Technically we should filter out some other characters, but this hasn't been a priority.
I don't think Docker should concern itself with these details since the computer name typically won't be of interest to containers. It should just ensure that we are passed a valid host name (which should be <= 63 characters without dots, per various RFCs).

@jstarks Thanks. I have updated the pull request with the restriction of hostname <= 63 bytes, to stick with RFCs.
Let me know if there are any other issues.

still LGTM

ping @vdemeester @jhowardmsft PTAL

LGTM

LGTM and green :green_heart:


[FLINK-9211][REST] JarRunHandler submits job to Dispatcher via RPC

What is the purpose of the change
This PR reworks the JarRunHandler to submit the job to the dispatcher via RPC, instead of setting up a RestClusterClient and going through the client's job-submission routine.
The reasoning is that the existing behavior was causing issues on kubernetes, and this change also removes a special-case as this was the only handler that actively sends out rest requests.
Brief change log

JarRunHandler now has access to DispatcherGateway
JarRunHandler now uploads jar and submits job via RPC

Verifying this change

run JarRunHandlerTest
submit job through webUI

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

merging.