virt_to_phys: breaks if guest_address is not equal to 0

This is the result of an excruciatingly long debugging session for https://github.com/hermit-os/uhyve/pull/711.
Say that we want to replace arch::RAM_START in the line 98 of vm.rs:
https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/vm.rs#L94
... to let mem = MmapMemory::new(0, memory_size, GuestPhysAddr::new(0x20000), params.thp, params.ksm);.
So, guest_address will be equal to 0x20000. There are many parts of the code which effectively already consider this case, by subtracting self.mem.guest_address. This is very often the case in vm.rs.
Debugging this was much more difficult because of the fact that the process "froze". With cargo test gdb (I could've used gdb) and LLDB running on the side. A previous indicator that something in phys_to_virt is broken was running the following test with a similar change: https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/arch/x86_64/mod.rs#L372
This would always return a WrongMemoryError.
virt_to_phys invokes a function called mem.host_address(pagetable_l0): https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/arch/x86_64/mod.rs#L208
That function has two conditions:
	pub fn host_address(&self, addr: GuestPhysAddr) -> Result<*const u8, MemoryError> {
		let addr_lt_guest: bool = addr < self.guest_address;
		let addr_ht_guest_plus_memsize: bool = addr.as_u64() as usize > self.guest_address.as_u64() as usize + self.memory_size;
		let expression: bool = addr_lt_guest || addr_ht_guest_plus_memsize;
		if expression
		{
			return Err(MemoryError::WrongMemoryError);
		}
		Ok(

Let's take a look at read_addrs in uhyve/src/linux/gdb.rs:
https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/linux/gdb/mod.rs#L129
This uses a constant: pub const BOOT_PML4: GuestPhysAddr = GuestPhysAddr::new(0x10000);
https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/consts.rs#L12
which is passed onto: https://github.com/hermit-os/uhyve/blob/efc35639f8c6939b9ec6745ad44c71dd4fda0a28/src/linux/gdb/mod.rs#L134
... as the pagetable_l0 variable, which is in turn passed as the addr variable. If we choose a guest_address equal to 0x20000, the first condition will fail.

This error basically pops up everywhere, one way or another, when the guest_address is modified. This was the best and most reproducible case that I could find after spending hours of trying to crack it for https://github.com/hermit-os/uhyve/pull/711.

The conclusion is that the physical address of the PML4 has to be changed accordingly, and that the control register that stores 0x10000 will have to be informed of that said change as well.
An open question is whether this can be fixed in Uhyve with one memory starting at a different offset, especially given the indications in the kernel that there are some hard-coded addresses in the zero page. With two memories (with separate offsets), this could be possible, but a way to distinguish them without the Kernel necessarily knowing about it is required, while having to convince Hermit to not load itself or the application in between of the addresses by "memory 1" and "memory 2".
https://github.com/hermit-os/kernel/blob/2143b3bc85fb274eedfac5a0e0794b1151f9f68c/src/arch/x86_64/kernel/boot.s#L1-L4
https://github.com/hermit-os/kernel/blob/2143b3bc85fb274eedfac5a0e0794b1151f9f68c/src/arch/x86_64/kernel/boot.s#L25-L30
https://github.com/hermit-os/kernel/blob/2143b3bc85fb274eedfac5a0e0794b1151f9f68c/src/arch/x86_64/kernel/boot.s#L122

Related: https://github.com/hermit-os/uhyve/issues/719

To summarize the issue: The page tables must reside within the physical memory space.
Hermit uses recursive pagetables, so it is agnostic to the location of PML4, as long as the location is written to the last entry in PML4:
https://github.com/hermit-os/uhyve/blob/e6ffffa81e04522479f374878da435a4fc99e8e1/src/arch/x86_64/mod.rs#L176-L184
So, I think this is quite solvable by modifying initialize_pagetables:

make BOOT_PML4 a static variable (OnceCell or similar).
remove BOOT_PGT/BOOT_PDPTE/BOOT_PDE constants and calculate these values via offset to BOOT_PML4 instead.
Set the CR3 register to the appropriate value of BOOT_PML4:  https://github.com/hermit-os/uhyve/blob/e6ffffa81e04522479f374878da435a4fc99e8e1/src/linux/x86_64/kvm_cpu.rs#L244

Set the CR3 register to the appropriate value of BOOT_PML4:

https://github.com/hermit-os/uhyve/blob/e6ffffa81e04522479f374878da435a4fc99e8e1/src/linux/x86_64/kvm_cpu.rs#L244
Completely missed that part, I will take a look. Thank you!

I tried an entirely different method other than using OnceCell so as to be able to get a "working proof of concept" of a codebase that is aware of the offsets and different addresses by dynamically calculating and storing all of these values inside of a struct instead of repeatedly calculating them, as well as moving some of the functions relying on these values in the impl. I also had some difficulties with OnceCell.
It still doesn't 100% work and I am not 100% pleased with it - I will have to go over this one with you. The read and write hypercall handlers now also rely on passing an object called pagetable, and it is not architecture-agnostic. However, I also had the implicit goal of enumerating all of the places in the codebase that depend on hardcoded addresses and getting a proof of concept ready before refactoring again. I will share the tree here in a bit once I look after some details.

First attempt (lots of dirty hacks, some hardcoded things, non-conventional variable names etc. etc.): https://github.com/n0toose/uhyve/commit/03842a0b202892663ef5529441a5defce3d949bb
It seems like I've gotten a little bit further, I am getting an error here - so something is not writing in something else properly:
https://github.com/n0toose/uhyve/blob/2b2de2a2aa3d98bb6064b478c160832ae3b24458/src/arch/x86_64/mod.rs#L225
As I am not completely sure whether essentially ignoring the OnceCell tip / instruction was a good idea, I'll call it a day and continue working on it later.


Fix code format scripts compat with non-GNU Unices

And improve it to also remove trailing tabs, not just spaces.
Not tested on macOS myself but at least this is documented as working on https://stackoverflow.com/a/15416836
CC @RevoluPowered or @bruvzg to confirm.
@aaronfranke The script takes a while to format the codebase, it would be nice if we can find some optimizations:
$ time misc/scripts/file_format.sh
real    1m8,844s
user    0m56,079s
sys     0m12,323s

The script takes a while to format the codebase, it would be nice if we can find some optimizations:

Maybe it could be run in parallel if parallel is available in the PATH.

stat: illegal option -- c
usage: stat [-FlLnqrsx] [-f format] [-t timefmt] [file ...]
Files in this commit comply with the formatting rules.

And it is creating filename-e files for every singe file in the repo.

GNU stat is available in homebrew coreutils package as gstat.

Alternatively, the tool can be modified to format only modified files (according to Git).

I don't think there is really an issue with the CI running it on all files in PRs. Plus if there is a problem I think it's best to "be noisy" about it so that it gets fixed fast. The Static Checks action doesn't really take that long overall, so if we can make it faster with something like parallel that would be nice I guess, but it's not really that slow IMO. On my system:
$ time misc/scripts/file_format.sh
real	0m36.572s
user	0m29.118s
sys	0m8.100s

By the way, on the topic of "parallel isn't available by default" - well you already need dos2unix and recode, one more dependency doesn't hurt I suppose.

I replaced sed usage by perl -pi -e and dropped usage on GNU stat.
@bruvzg @RevoluPowered Can you test if it now works on macOS?
Performance wise, I found that half the time is spent in recode, so maybe we can optimize there a bit by finding a faster way to ensure encoding.
The two perl one liners take ~10 to ~15 s each. It's possible that the dos2unix call (~8 s) is no longer needed if perl -pli -e handles fixing line endings already (didn't check).

Can you test if it now works on macOS?

Seems to work fine.

and dropped usage on GNU stat.

stat is also used in the black_format.sh and clang_format.sh scripts.

And maybe it should check if dos2unix and recode are installed and print error message (neither is installed on macOS be default, perl is).

stat is also used in the black_format.sh and clang_format.sh scripts.

Fixed.

And maybe it should check if dos2unix and recode are installed and print error message (neither is installed on macOS be default, perl is).

Done.

Cherry-picked for 3.2.3.

misc/scripts/black_format.sh is still broken.
Formatting Python files...
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

No Path provided. Nothing to do 😴

find seems to be different too, as it was with the previous issues, changing it to the GNU version (gfind form brew install findutils) works fine.


Disable syntax highlight

It would be really helpful to be able to disable syntax highlight because it might help with big responses.

Hi
Thanks for the suggestion.
The option to disable syntax highlighting will be available in the next version (3.0)


Add ALPN protocols to DestinationRule.TLSSettings

Describe the feature request
Add ALPN protocols to DestinationRule.TLSSettings, to set Envoy's alpn_protocols in CommonTLSContext.
Seems to be the problem described in https://discuss.istio.io/t/trust-custom-root-ca-on-egress-gateway/3063/17 and a missing feature in Istio.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Additional context

cc @rshriram


Update torso calibration

Update the joint encoder offsets on the torso (manual calibration). Also checked the neck joints calibration which didn't require any update.

Sure, I keep that in mind. Thanks!


feat: lido oracle

implements lido oracle off new/lido
addresses comments from #2
adds fork tests for lido oracle

I think that the contract that serves as source is WSTETH, instead of STETH (remember that this oracle returns the WSTETH/STETH and STETH/WSTETH feeds).

happy to revert for clarity since the change is only semantic. looking at it as a WSTETH-STETH oracle (since it prices the WSTETH/STETH and STETH/WSTETH pairs) it feels to call the associated stETH function which is marginally cheaper


[Bug-App]: Failed to disconnect the slack integration through web app setting.

Describe the bug

Hi, I am using the web app for alerts to slack. I connected to the wrong channel when setting it up the first time. Then I want to disconnect it at the setting page of the web app. It fails and returns the following page.

Hey @pipixiaqishi1, thanks for flagging this! I just tested but couldn't reproduce this issue, so would it be possible to share the name of your entity to I can take a look?

Thanks for your reply. My username of wandb is jerrykzhang and my account is connected with my current GitHub account.

Thanks for sharing this @pipixiaqishi1! That seems to be your personal account, so may I please ask how you're trying to remove this? Just by going to the /settings page? I would recommend that you create a team and then set the integration there

Oh yes, I see, thanks for your assistance.


Shadow effect of Our Tours corrected

Related Issue

Issue No. #187

Changes you made :

Corrected the shadow effect that wasn't working previously

Describe the changes :

Check list :

[ ] I have followed code style of this project.
[ ] I have read the CONTRIBUTING document.
[ ] All the aspects mentioned in the issue are covered.
[ ] The website is properly working after my changes.
[ ] 🌟 ed the repo

Type of change :

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Output Screenshots :

Good to go
LGTM 👍


lifecycle restorer should should support restoring image layers with read-only directories

The cached image layer created by the go-mod-cnb can't be restored. This is due to the cached layer having read-only directories as detailed in https://github.com/cloudfoundry/go-mod-cnb/issues/6.
It looks like the restorer should implement functionality similar to tar --delay-directory-restore to allow the cached layer be restored correctly

I believe this is fixed by #178. Thanks!


Links to specific accordion sections only work partially in Firefox (Windows and Mac)

I have noticed that, when following a link to a specific accordion section in Firefox for Windows or Mac, the page is correctly opened and so is the relevant accordion section, but one is not automatically taken to the beginning of the accordion section.  To see an example, click on the link to "gravitational potentials" in the preamble of https://isaacphysics.org/concepts/cp_fields .

This turned out to be a Firefox thing; for some reason most browsers allow $("body").animate(...) but Firefox does not. To support Firefox as well, it needs to be $("html,body").animate(...) which risks running it twice on browsers that support both body and html scrolling - but oh well!


Inventory Bug

Hi, today i just downloaded the plugin and put the italian default config. and i don't why i can't get block in gmc.... you can but you need to click more times to the item, and it wasn't possible to clear the inv. bar....

Could you show me a gif/video of this?

Hello, it appears that I'm having the same issue so I decided to comment here instead of opening a new ticket. This is the link for the video of my issue: https://youtu.be/fkFAJWwfRL0
Here is the Inventory Issue when having CrazyAuctions installed.

Attempted middle-clicking to get the block.

Attempted to drag-and-drop item into hotbar.

I am able to press 1-9 to 'quick select' the item into my hotbar slot after pressing multiple times (about 4-5).

After selecting items, I attempted to throw items onto the ground, they disappear but don't drop at all.

Thanks, I hope this gets resolved soon.
ULucky

Added to project board.


move overloads of execute to @libsql/core/api (because its part of the public API) && add CONTRIBUTING.md

move overloads of execute to @libsql/core/api (because its part of the public API)
and
add CONTRIBUTING.md to provide instructions to setup repo for experimentation and contribution

Just read your comment sorry. We setup the repository so it runs prettier before pushing your changes so all of our code is formatted following the same rules. Seems that not all files are formatted though as commented in #256 so it would be nice if you can run prettier --write . (I think the whole command is npm run prettier --write .)

i originally didnt run this because this might've changed many files and that would've looked suspicious


MediaError missing message property

https://github.com/Microsoft/TypeScript/blob/bb23e9601f5ea0b4fe1e97545ef01535fa18a23d/lib/lib.d.ts#L11664
According to spec The MediaError object should have a message:string property:
https://html.spec.whatwg.org/multipage/media.html#dom-mediaerror-message

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.


Support initialising graphics card memory from sonnet.library

As a temporary solution, we should support initialising graphics card memory from sonnet.library. This is supposed to be a temporary solution since KlozetPCI is not ready to use yet, so that we can avoid using pci.library.
Add support for at least Voodoo 3. I'm digging through the datasheet, I'll see what I can do.

Any progress on this? I have to admit that the documentation of the avenger doesn't read as wel as the  motorola docs. However, I have the source of the BeOS VooDoo3 drivers laying around if that helps.

Not really, other projects getting in the way. I still intend to do it though.
Toni Willen just implemented emulation of Mediators in WinUAE (with a bit of my help :smile:), this should help me with PCI programming while on the road.

This does not seem necessary anymore, just as #1.


Unable to install on Mac

Encountered multiple errors:

export email address was optional in docs but it broke the installation script.
Fixed by exporting email address
after that, I got an error during installation script about sam command.
Fixed by installing sam (also needed to upgrade xcode). Might be helpful to add it as a prerequisite in dependencies.

breaking error

current error is I think the CFN is unable to create the S3 bucket and upload. output below:

▶ curl -sL http://get.eksphemeral.info/install.sh | sudo --preserve-env bash
Cloning into '/Users/me/eksp'...
remote: Enumerating objects: 334, done.
remote: Counting objects: 100% (334/334), done.
remote: Compressing objects: 100% (210/210), done.
remote: Total 1688 (delta 153), reused 274 (delta 100), pack-reused 1354
Receiving objects: 100% (1688/1688), 5.53 MiB | 5.27 MiB/s, done.
Resolving deltas: 100% (1001/1001), done.
Attempting to download https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/eksp-macos
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   601    0   601    0     0   1914      0 --:--:-- --:--:-- --:--:--  1920
100 2754k  100 2754k    0     0  1500k      0  0:00:01  0:00:01 --:--:-- 1957k
Trying to install EKSphemeral ...
Installing the EKSphemeral control plane, this might take a few minutes
Using S3 bucket eks-svc for the control plane service code
Using S3 bucket eks-cluster-meta to store cluster specifications
mkdir -p bin
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/createcluster -o bin/createcluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/destroycluster -o bin/destroycluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/prolongcluster -o bin/prolongcluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/status -o bin/status
chmod +x bin/*
sam package --template-file template.yaml --output-template-file eksp-stack.yaml --s3-bucket eks-svc

Unable to upload artifact bin/ referenced by CodeUri parameter of StatusFunc resource.
An error occurred (AllAccessDisabled) when calling the CreateMultipartUpload operation: All access to this object has been disabled
make: *** [up] Error 255
Something bad happened after command completed:: exit status 2

Mac OS version: 10.14.5
aws cli version: 1.15.76
sam version: 0.19.0

Thanks for reporting this @shrasool and inline, point for point, the comments:

export email address was optional in docs but it broke the installation script.

That shouldn't happen, let me see if I can re-produce this.

Fixed by installing sam (also needed to upgrade xcode). Might be helpful to add it as a prerequisite in dependencies.

Indeed, great catch! I have it listed in https://eksphemeral.info/dev/ but my bad, I forgot to add it to the main install instructions, will fix, ASAP!

current error is I think the CFN is unable to create the S3 bucket and upload

Maybe the instructions are not clear but you need to pick names for your buckets yourself, you re-used my bucket names there. That won't work, since you don't have write-access to my buckets.

My terminal buffer doesn't have that email error unfortunately so that's that.
It is still failing even though I can create the bucket using aws cli. Here is the new error now:
sam package --template-file template.yaml --output-template-file eksp-stack.yaml --s3-bucket eks-ice

Unable to upload artifact bin/ referenced by CodeUri parameter of StatusFunc resource.
S3 Bucket does not exist. Execute the command to create a new bucket
aws s3 mb s3://eks-ice
make: *** [up] Error 255
Something bad happened after command completed:: exit status 2

▶ aws s3 mb s3://eks-ice
make_bucket: eks-ice

▶ aws s3 ls
2019-08-09 17:32:59 eks-ice

Hmm, it's a little hard to see what's going on but I'd suggest not to manually create the buckets but only set the env variables. Could be some location constraint missing.

The manual command at the end was just to confirm that the aws cli can create the buckets itself. Here is another run with different bucket name:
▶ curl -sL http://get.eksphemeral.info/install.sh | sudo --preserve-env bash
Cloning into '/Users/syedhamid/eksp'...
remote: Enumerating objects: 334, done.
remote: Counting objects: 100% (334/334), done.
remote: Compressing objects: 100% (210/210), done.
remote: Total 1688 (delta 153), reused 274 (delta 100), pack-reused 1354
Receiving objects: 100% (1688/1688), 5.53 MiB | 6.00 MiB/s, done.
Resolving deltas: 100% (1001/1001), done.
Attempting to download https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/eksp-macos
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   601    0   601    0     0   1526      0 --:--:-- --:--:-- --:--:--  1529
100 2754k  100 2754k    0     0  1473k      0  0:00:01  0:00:01 --:--:-- 3064k
Trying to install EKSphemeral ...
Installing the EKSphemeral control plane, this might take a few minutes
Using S3 bucket eks-ice-2 for the control plane service code
Using S3 bucket eks-ice-2-cluster-meta to store cluster specifications
mkdir -p bin
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/createcluster -o bin/createcluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/destroycluster -o bin/destroycluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/prolongcluster -o bin/prolongcluster
curl -sL https://github.com/mhausenblas/eksphemeral/releases/download/v0.4.0/status -o bin/status
chmod +x bin/*
sam package --template-file template.yaml --output-template-file eksp-stack.yaml --s3-bucket eks-ice-2

Unable to upload artifact bin/ referenced by CodeUri parameter of StatusFunc resource.
S3 Bucket does not exist. Execute the command to create a new bucket
aws s3 mb s3://eks-ice-2
make: *** [up] Error 255
Something bad happened after command completed:: exit status 2

Strange. I'll try to reproduce it.

Also hitting this but on Linux. It appears to be the S3 bucket not getting created from eksp-up.sh.
Running this manually... it does not create the bucket:
if [[ $(aws s3 ls | grep $EKSPHEMERAL_SVC_BUCKET) -ne 0 ]]; then     aws s3api create-bucket \         --bucket $EKSPHEMERAL_SVC_BUCKET \         --create-bucket-configuration LocationConstraint=$(aws configure get region) \         --region $(aws configure get region)     echo "Created S3 bucket $EKSPHEMERAL_SVC_BUCKET" fi
Taking the code out in isolation without the if loop, it does create the bucket, maybe timing and/or return code not being correct.

Cool, thanks @tomellis! I'm back from PTO tomorrow and will have a look.

Looks good to me @mhausenblas Thanks!


This is an example python exception

Hey hey :wave:!
An error occured at 2016/6/25 23:47:38 and the culprit was: raven.scripts.runner in main
StacktraceTODO

This is looking pretty nice. I'll add the stacktrace and a link to the sentry line later as well as formatting the date better.


Create backup and restore with dryrun to detect any validation errors

/cc @pixelsoccupied

/lgtm

/approve


Publish error on wasm project

When trying to publish the project, I first am asked twice what application to use to open "this .py file" with, and when I choose the default Python, I first get
C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\7.0.5\Sdk\WasmApp.Native.targets(502,5): Warning : Emscripten version mismatch. The runtime pack in C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.browser-wasm\7.0.5 expects 'emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.12 (38d1292ba2f5b4a7c8518931f5ae6f97ef0f6827)', but emcc being used has version ''. This might cause build failures.
and finally
C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\7.0.5\Sdk\WasmApp.Native.targets(436,5): Error MSB3073: The command "wasm-opt.exe --enable-simd --enable-exception-handling  --strip-dwarf "C:\Users\nwitt\Source\Repos\Ikwasm\Ikwasm\obj\Release\net7.0\wasm\for-publish\dotnet.wasm" -o "C:\Users\nwitt\Source\Repos\Ikwasm\Ikwasm\obj\Release\net7.0\wasm\for-publish\dotnet.wasm"" exited with code 1.
If this is a Python version mismatch, please help finding and installing the correct one.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: efff6954-a035-d1da-5975-af04ff7c05ed
Version Independent ID: efff6954-a035-d1da-5975-af04ff7c05ed
Content: Run .NET from JavaScript
Content Source: aspnetcore/client-side/dotnet-interop.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @pavelsavara
Microsoft Alias: riande

Hello @nicowitteman ... We only work on docs here. Stand-by, and I'll ping management to see which repo should receive your issue.

@pavelsavara, @lewing do you guys think this should be moved to the dotnet/runtime or some other place?

It looks like damaged installation of workload. I don't know much about how workloads and their upgrades work.
cc @radical

The same problem occurs on multiple machines, with the latest updates of the workloads.

@pavelsavara, @lewing do you guys think this should be moved to the dotnet/runtime or some other place?

This should be moved to dotnet/runtime.

@nicowitteman Are you building this from VS, or from the command line? If the latter, then could you please add -bl to the command line and share the generated msbuild.binlog? Also, what is the version of the "default python" that you have installed?

Actually, I am building from VS, I set the build output and build log verbosity to "diagnostic" and I attached the output:
wasm-buildlog.zip. I hope that contains the information you are looking for.
The version of python I have installed now (from the store) is 3.11.3, the warning disappeared but the build still fails. Your help is appreciated.

This looks odd. This shouldn't fail.
                Exec: emcc --version
emcc(0,0): Error : no input files
                Exec: The command "emcc --version" exited with code 1.

Can you try a fresh build (delete bin, and obj directories) from the command line, with -bl added?
Also, what was name of the .py file that it tried to load?

Ok, after more trial and error I find that on one machine, both debug and release builds and publish work fine. On another machine, however, debug (dotnet publish  /p:Configuration=Debug -bl) is OK, but release (dotnet publish  /p:Configuration=Release -bl) still ends up in the same error. I include both binlog-files in case you want to waste more of your time. I would totally understand if you don't.
msbuild.binlog.zip


uradar not compiled when outside if statement

uradar(enemy,any,any,distance,0,1,e)
when put ouside if statement isn't compiled gives nothing

Hi, thanks for all the bug reports. The optimizer is buggy and requires any of the variables declared in uradar in order to work correctly. Otherwise, the optimizer will think « Oh, nothing uses e, so I can safely delete this line ». In a « real » program, e would not be unused and would thus generate the correct code. Since this is a toy program, mindcode-the-compiler will output nothing.
If you can, you could check out the code and disable the optimizer. You can change the call to generateAndOptimize into generateUnoptimized at https://github.com/francois/mindcode/blob/main/webapp/src/main/java/info/teksol/mindcode/webapp/CompilerFacade.java#L35 https://github.com/francois/mindcode/blob/main/webapp/src/main/java/info/teksol/mindcode/webapp/CompilerFacade.java#L35. This will obviously generate slower code, but the code will be exactly as you wrote.
Alternatively, you can disable the dead code eliminator at https://github.com/francois/mindcode/blob/main/compiler/src/main/java/info/teksol/mindcode/mindustry/LogicInstructionGenerator.java#L30 https://github.com/francois/mindcode/blob/main/compiler/src/main/java/info/teksol/mindcode/mindustry/LogicInstructionGenerator.java#L30.
Hope that helps

@catornot You should use it as an if condition anyway, or you risk getting x and y of null.


Missing replyUrls important information

Hi,
the property replyUrls is missing the very important requirement that any reply URL which is not localhost shall use the HTTPS URI scheme.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f7ced07-0b71-715f-749b-180567591c72
Version Independent ID: 8c533d7b-a058-3f1a-c296-9c0305f85f13
Content: Understanding the Azure Active Directory app manifest
Content Source: articles/active-directory/develop/reference-app-manifest.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@astaykov Thanks for your feedback! We will investigate and update as appropriate.

@astaykov - Hello. Thank you for your feedback. We are releasing our updated docs this coming Monday, September 24th, and this includes updates to the app manifest reference. replyUrls has been renamed to replyUrlsWithType. I've copied the info here:

The info has been live as of Sept 24.
#please-close

@astaykov We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


how to nest ListView within a Column, so I can display widgets before and/or after the List e.g load more button or status bar

Steps to Reproduce
Please tell us what you were doing and what went wrong. If you are running flutter tools from the command line, please try adding the -v or --verbose option to gather more information.
If the problem is with your application's rendering, please attach a screenshot and any relevant source code.
If you are getting an exception in the logs, and your code is implicated in the first few frames, then please include the source code for the functions involved.
Logs
Run your application with flutter run and attach all the log output.
Run flutter analyze and attach any output of that command also.
Flutter Doctor
Paste the output of running flutter doctor -v here.

For more information about diagnosing and reporting Flutter bugs, please see https://flutter.io/bug-reports/.

Closing due to inactivity


feat: allow removing BLOCK_CONFLICT_CHAINLOCK flag via ResetBlockFailureFlags

Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Guix Automation has began to build this PR tagged as v22.1.0-devpr6500.ab112e71. A new comment will be made when the image is pushed.

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v22.1.0-devpr6500.ab112e71. The image should be on dockerhub soon.


Third try at fixing test/IRGen/objc_subclass.swift

I couldn't figure out how to make CHECK-DAG work with
CHECK/CHECK-32/CHECK-64 lines in between. (I tried)
rdar://44644016

@swift-ci Please smoke test and merge


test(dialog): dialog测试用例补充

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[x] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue
#1197

💡 需求背景和解决方案

📝 更新日志
test(dialog): dialog测试用例补充

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[ ] 文档已补充或无须补充
[ ] 代码演示已提供或无须提供
[ ] TypeScript 定义已补充或无须补充
[ ] Changelog 已提供或无须提供

Codecov Report

Merging #1199 (45e13f0) into develop (a0db0df) will increase coverage by 0.97%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1199      +/-   ##
===========================================
+ Coverage    57.56%   58.53%   +0.97%
===========================================
  Files          346      406      +60
  Lines        12828    15148    +2320
  Branches      2405     2865     +460
===========================================
+ Hits          7384     8867    +1483
- Misses        5200     6008     +808
- Partials       244      273      +29

Impacted Files
Coverage Δ

src/cascader/interface.tsx
0.00% <0.00%> (-100.00%)
:arrow_down:

src/swiper/props.ts
68.75% <0.00%> (-31.25%)
:arrow_down:

src/dialog/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/calendar/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/date-picker/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/drawer/props.ts
71.42% <0.00%> (-28.58%)
:arrow_down:

src/cascader/props.ts
64.28% <0.00%> (-27.39%)
:arrow_down:

src/pagination/props.ts
72.72% <0.00%> (-27.28%)
:arrow_down:

src/affix/affix.tsx
39.06% <0.00%> (-27.01%)
:arrow_down:

src/popup/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

... and 236 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301a7dc...45e13f0. Read the comment docs.


Running instructions

Reference: https://github.com/hendrycks/apps#how-to-use
Files train/README and eval/README are not present in the repository.
Would really appreciate if the instructions are added for training and evaluation of the models.

I'll check what happened to them. I remember they used to be there but maybe I'm mistaken. Will double check soon. Thanks for raising the issue.

I do not believe we plan to release the filtered dataset as the hosting costs are too much for the size of dataset.

The links in the README were broken but the actual README instructions for train and eval were present in their respective folders.  I've updated the links and will now close the issue.
Thanks for reporting it!


move to .csproj project format

Beginning with Visual Studio 2017 the old project.json + .xproj format will not be supported anymore.
Using .csproj for .NET Core projects will be the new standard. It's already used by the classic .NET Framework and will add more compatibility between .NET Framework and .NET Core.
Especially referencing libraries (e.g. .NET Standard libraries) will be much easier.
The new format is not backwards compatible, though.
In addition to the migration the following changes have to be made:

[ ] Change git tag creation in appveyor.yml

The migration was successfully done in new "csproj" branch:
bd6296ea197c90db7b731411fd04c90237ad27f5
AppVeyor support is currently not given.

Current build is failing due to bug in current cli tooling (https://github.com/dotnet/cli/issues/5168).
Could be fixed by adapting the build script but the final cli release will probably fix this anyways.

Adapted AppVeyor build script to add support.
Latest build was successful.

Although the project was migrated a while ago I'll keep this issue open to track status on some issues that required workarounds.


Deterministic Key Generation May Produce Duplicate Private Keys

This is not the final code. PR is Draft. No need to merge. First of all need NCC approval of approach

Ready for review, not a draft anymore


🐛 Fix missing comma in default config

Doh, this is a trailing comma, not needed... but let's add it because then you can just comment out the lines under without adding the comma?

In #2286 we started getting reports of a missing comma in the config, very weird.
So i looked in the default config, and saw the comma there.
Now @peauc reported the same thing but on macOS, then i thought it couldn't be the issue I was originally thinking #2286 was about (sync issue, user problem).
~and after double checking master config again i remembered that i forgot to check canary, well here's the issue, finally fixed 🎉~
~Don't know when this was introduced but let's not blame anyone, this should have been caught by the linter...! 😱~

Is this actually fixed on the canary branch?
https://github.com/zeit/hyper/blob/canary/app/config/config-default.js#L101

yes @oswaldoacauan, the copyOnSelect prop is inside an object, and is the last one, so there should be no trailing comma (we could add it, but this is valid, hence why the linter didn't "catch" it)

I lost a couple minutes trying to figure out why it was saying my config was invalid since I just copy-pasted some plugin config under the config key.
A trailing comma here will prevent people of making the same mistake :)

I think so too @oswaldoacauan, but we should update the linter to require trailing commas in the config file while adding the comma there too,  so we don't forget it in the future when we add more stuff to the config.
There's no harm in adding trailing comma, it will just make it easier for everyone.
I can't work on this right now, but should be able to do it soon-ish, otherwise, PR welcome 👍


Fix directive examples in docs

Seems like the documentation has incorrect examples on how to define a directive.
I tried to do it according to the docs and saw the stringified function in the rendered DOM. Then I looked the implementation of existing ones in the core and made mine in the same way (https://codepen.io/bashmish/pen/oQxBYZ) and it started working. I fixed examples accordingly.

Looks like this is related to this https://github.com/Polymer/lit-html/issues/604 and this https://github.com/Polymer/lit-html/pull/562
Feel free to close this PR if you think it is not the best moment to fix examples in docs back to the old syntax.

Closing since 0.13 is released now.


Explore the feasability of bringing OCR analysis done by Robotoff offline

@teolemon Suggestion: a new "AI" label in github.

We have the existing "On Device ML" and MLKit when we explicitely use MLKit @monsieurtanuki

Robotoff for server-side ML


fork -> change hetzner provider to vercel

Hello,
I've forked the Hetzner Repository and modified it to work with domains that are managed by Vercel (vercel.com).
Can we get this as an official caddy-dns package?
I didn't know where to open the request, obviously i don't want this to be merged into hetzner.

I'll take a look at this soon. Thanks!

LGTM, repo created - thanks!


Standardize terminology in UI between "Discoverable" and "Private/Public" items

Describe the bug
Discovered this usability issue while writing/updating documentation for the 7.2 release.  We use two terms for the same thing within our User Interface. We should obviously use the same terminology throughout to avoid confusion.

Submission UI's new "Item Access Condition" step provides a "discoverable" checkbox.  This allows you to select whether an item is discoverable (i.e. public) or non-discoverable (i.e. private)

This is a new terminology for the "Private" item, which has always been a problematic term, see for example this old ticket https://github.com/DSpace/DSpace/issues/7334

In the Item Edit > Status tab, we still have a "Make it private..." button.
In Administrative Search, the filter is named "Private".  When a Private item is found the button says "Make Public"
When an Item is non-discoverable, it gets a "Private" red label (in Administrative Search for example)

Expected behavior
We should use the same terminology throughout DSpace.
I personally like the new "Discoverable" terminology, as it more accurately describes this item state.  We should consider renaming all terminology in the UI as follows:

Private => Hidden (or possibly Non-Discoverable)
Public => Discoverable

Yes, please.  I will add my support for the more accurate "discoverable".

Atmire would like to claim this. It will take an estimated 2 hours

@artlowel: sounds good! Will assign to you, so that you or your team can work on it.


doc updates due to new polars integration

We should rename our pandas integration section for "pandas/polars" integration and show how to use it: https://jupysql.ploomber.io/en/latest/integrations/pandas.html
also, we can mention the autopandas/autopolars options. note that we should let users know that autopolars was added in version 0.6
this also needs to be updated to mention this is new in version 0.6: https://jupysql.ploomber.io/en/latest/api/configuration.html#autopolars
hey, @jorisroovers - if you get a chance, I'd appreciate your help here!

awesome!

i fixed this but forgot to close this, so closing it now


Setting keyboard shortcut when to editorTextFocus && (editorDirty || editorReadonly) gives editorReadonly) || (editorDirty && editorTextFocus instead

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: https://vscode.dev/
OS Version: https://vscode.dev/

Steps to Reproduce:

@stdedos The parser for context keys does not support parens, so when typing:
editorTextFocus && (editorDirty || editorReadonly)
---------------    ------------    ---------------
        A                B               C

it parses A && B || C, where A is editorTextFocus, B is (editorDirty and C is editorReadonly).
It then proceeds to render that as C || A && B which yields:
editorReadonly) || editorTextFocus && (editorDirty
---------------    ---------------    ------------
        C                A                 B

So the root request here is to add parens support to context keys.


Copy to a mounted cifs share fails because of attempt to change file mode

Expected Behavior

The files should be copied to the destination folder without trying to change the file mode afterwards
Current Behavior

After copying a file, gradle tries to change the file mode. This fails, as it is not allowed.
Context

I'd like to copy files to a cifs share. This is not possible. I even used fileMode=null and dirMode=null, still gradle tries do change the fileMode to 0664. Also changing the fileMode to 0777 does not change the behaviour. But changing the file mode is not allowed at all.
Steps to Reproduce

Basically mount a windows share with cifs on a linux machine and then try to copy or sync files with a gradle task to this mount.
I have to mention, the zip task does work, so I can create a zip file on the share, as this does not try to change the file mode afterwards.
Your Environment

Build scan URL:

OK, there seems to be a workaround. If you add 'noperm' as a mount option, the chmod is allowed but ignored.
Still it would be great to have an option to not change the file mode at all.

Sorry that you're having trouble with Gradle!
Your issue lacks information about how to reproduce the problem you're having. A reproducer project can really help us track down and fix your problem quicker.  We may also be able to suggest workarounds or ways to avoid the problem if we can reproduce it.
You can use the following as a base for your reproducer: https://github.com/gradle/gradle-issue-reproducer
This issue will be closed after 7 days, unless you can provide more information.


update to latest version of firecracker

Potential duplicate of PR https://github.com/kata-containers/runtime/pull/1265


Listen to State Changing

Please add the OnLoadingStateChange method from cef api for listening to the browser state

ok, it will be add on my next commit.


usb-host error on macOS

M1 Macbook Pro, macOS Big Sur
libqemu-x86_64-softmmu.utm.dylib: -device usb-host,vendorid=0x0403,productid=0xfa24: 'usb-host' is not a valid device model name
USB Passthrough does not seems to work on macOS. VM does not start when -device usb-host,vendorid=0x0403,productid=0xfa24 is used as extra args. I'm running a Windows XP VM.
VM_configs.zip

USB is not supported on UTM v2.0 but is a planned feature for UTM v2.1


Update wasmcloud-host and wasmcloud on crates.io

The entries for wasmcloud-host and wasmcloud are currently way old, dating back to an earlier iteration of the Rust wasmCloud runtime. Since these pages appear old, unmaintained, etc I feel it would give an impression that this project isn't active when in fact we're (of course) very active, and just not publishing these crates currently.
Part of the reasoning to hold this back was out of caution, knowing that the host, runtime, component, etc etc crates would break frequently and are not 1.0 stable from a library perspective. I think we should bump these crates to the latest minor versions and get these out on crates.io, moving forward and breaking individual crates if needed.
Additionally, wasmcloud the binary should be published to crates.io as well. This may take a bit of effort to publish all the dependent crates, but with cargo smart-releaser we should be able to publish these crates well in the future.

Definitely not stale, we're going to try and get this done this week! Big crate releases are underway :)

Done!

SO CLOSE!


Question about distinctUntilKeyChanged performance

RxJS version:
Current master branch af20916db55fb917ffb9e86d61ab07ff873d1c74
Code to reproduce:
None
Expected behavior:
Ternary operator can resolve on operator creation once,
export function distinctUntilKeyChanged<T, K extends keyof T>(key: K, compare?: (x: T[K], y: T[K]) => boolean): MonoTypeOperatorFunction<T> {
  return distinctUntilChanged(compare ? (x: T, y: T) => compare(x[key], y[key]) : (x: T, y: T) => x[key] === y[key]);
}

Actual behavior:
it resolves on every item emission.
https://github.com/ReactiveX/rxjs/blob/4dd0be0a446a7d5fec7a15001e7ba56d4962346f/src/internal/operators/distinctUntilKeyChanged.ts#L84-L86
Additional information:
Could this change improve performance?

You can test the change locally and see how much it improves performance: https://github.com/ReactiveX/rxjs#performance-tests

Closing this because no evidence of a meaningful performance improvement was forthcoming.


only read payload from network stream

Addresses: https://github.com/nats-io/nats.java/issues/900
Might need a regression test?

I see some coverage check that hasn't completed yet. Do I need to trigger that manually? Also I'm not currently set up for commit signing, or is that done by the maintainer team when merging?

@GrafBlutwurst Coverage doesn't work for forks which explains the missing check. We prefer signed commits, so for the future please set that up, but it's fine for this PR. Thanks for the contribution!


Feature/rest api

Please add changelog like in https://github.com/samply/reporter/blob/main/CHANGELOG.md

Please add @Threated as a reviewer when the functionality is implemented.

Review to be continued. Meeting participants: @afigueroaDkfz , @djuarezgf , @Threated


Refactoring the code ?

Hey !
So, sixer is pretty cool already, but after looking at the code, I have some suggestions.
First of all, the CLI is not especially user-friendly: one would expect a "--help" option that would list checkers and give a detailed, noobie-oriented description of what they do, for instance.
Secondly, I do not think one can use sixer with a "plugin" that would fit their very specific needs and that would not be suitable for upstream. It would be nice to be able to define a checker/fixer as a plugin, or to load it as a module.
Finally, the code is getting quite big and a bit hard to read, imho. I would much rather define a Fixer/Checker class per task (so, an "IteritemsFixer" class, a "RangeFixer" class, etc.) that would have a "check()" and a "patch()" method, as well as a string giving detailed explanations about what it does. We would have all the code related to a change at the same place and could probably use some OOP magic to factorize some code.
WDYT ?

 It's a quick & dirty project which answers to a very specific use case. I accept patches to enhance the code ;-)

Fixed by commit 8c897fcf50805ffc954f6e4ffaaffcd02923f81d.


[DS-4113] Configure clean plugin in parent pom to also clean sub-modules

https://jira.duraspace.org/browse/DS-4113
This change will get the 'clean' maven task to also clean target directories from sub-modules. Currently, they never get touched by a 'clean' from the parent project.
It does refer to 'dspace/modules' as the path for submodules so if that ever changes, this plugin configuration will need to be updated (but so will a lot of pom configuration).
I'd like to port this to 6.x as well if others agree.

Hello @kshepherd,  it has been applied to master branch but it hasn't been ported to 6.x. I'm using it on 6.x and it is really useful. Could it be cherry-picked?
Let me know if I can help submitting the 6.x port. Thanks!

@toniprieto thanks! and tanks for the reminder about porting - i thought i'd done it already
if you have something ready to go feel free to send it up!


How to generate DeepFool attack with l_2 constraints?

I have tried generating some adversarial samples with DeepFool and setting the eps parameter to 0.2, however the attack samples had a distance far greater than 0.2 from the original samples.
Is it possible to use another parameter or modify the value of eps to ensure that the l_2 norm of adversarial - original is less than a certain threshold?
Thank you in advance.

Hello!
Indeed, I was referring to the epsilon argument.
In the following code, I attack a simple fully connected MNIST classifier. We can see that even though the epsilon parameter was set to 0.2, all samples have a much higher distance from the original than that:

import tensorflow as tf
from art.estimators.classification import TensorFlowV2Classifier
import numpy as np
from art.attacks.evasion import DeepFool

mnist = tf.keras.datasets.mnist
(X_train, y_train), (X_test, y_test) = mnist.load_data()
X_train, X_test = X_train / 255.0, X_test / 255.0

model = tf.keras.Sequential([
tf.keras.layers.Flatten(input_shape=(28,28)),
tf.keras.layers.Dense(100, activation='relu'),
tf.keras.layers.Dense(100, activation='relu'),
tf.keras.layers.Dense(10, activation='softmax')
])

model.compile(
loss='SparseCategoricalCrossentropy',
optimizer='adam',
metrics=['accuracy']
)

model.fit(X_train, y_train, epochs=10)
model.evaluate(X_test, y_test)

ART_classifier = TensorFlowV2Classifier(
model=model, nb_classes=10, input_shape=(28, 28),
loss_object=tf.keras.losses.SparseCategoricalCrossentropy(),
clip_values=(0, 1)
)

attack = DeepFool(classifier=ART_classifier, epsilon=0.2)
SAMPLE_SIZE = 10
X_test_adv = attack.generate(X_test[:SAMPLE_SIZE])

_, adv_accuracy = model.evaluate(X_test_adv, y_test[:SAMPLE_SIZE])
print('Accuracy on adversarial test data: {:4.2f}%'.format(adv_accuracy * 100))

for i in range(SAMPLE_SIZE):
print("l2 distance from original: {}".format(np.linalg.norm(X_test_adv[i] - X_test[i], ord=2)))

Output:

l2 distance from original: 7.5198902445117515
l2 distance from original: 12.517949078098
l2 distance from original: 15.583265832646825
l2 distance from original: 10.309606071366971
l2 distance from original: 12.67709685435253
l2 distance from original: 14.319209476402303
l2 distance from original: 14.030292651152768
l2 distance from original: 11.192603835883371
l2 distance from original: 13.267377609462349
l2 distance from original: 9.74294408168186

Hi @kotleta2007
Thank you for the example code. I have noticed two items:

The argument epsilon of DeepFool does not define the maximum permitted perturbation and therefore cannot be compared directly to the L2 norm of the observed perturbation. The epsilon corresponds to the parameter eta of Moosavi-Dezfooli et al. which defines how much the adversarial example should be pushed across the boundary instead of having it exactly on or too close to the boundary.

Your model is using a softmax activation in its last layer. DeepFool expects a model to output logits to achieve its best attack performance. Therefore you should change softmax to linear.


alt+shift+f formats html but not css

Issue Type: Bug
I really like alt+shift+f keyboard shortcut for formatting html document content.  It appears this is not enabled for css document content which i woiuld expect it to do both for educational and easy of css format maintenance in the case of skilled users.
VS Code version: Code 1.27.2 (f46c4c469d6e6d8c46f268d1553c5dc4b475840f, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.85GB (6.30GB free)

Process Argv
C:\Users\ob1\AppData\Local\Programs\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

vbscript
Dar
1.0.4

nightswitch-lite
gha
2.1.0

csharp
ms-
1.16.1

vsliveshare
ms-
0.3.735

team
ms-
1.136.0

Check out the marketplace for a CSS formatter.
The request to add a css formatter to the built-in css support is https://github.com/Microsoft/vscode/issues/19166
(but we actually rather let the use have a choice)

Thanks for the response on this.  Yes I saw marketplace offerings, e.g.  this 4 star ranked css formatter, but it doesn't hook up to the out of the box html document format keyboard shortcut alt+shift+f.  I opened this  issue in that extension's repo to see if there is a solution to that.
Not understanding why there isn't an oob offering that folks can use marketplace to get alternative versions of.  Just not following thinking that an oob offering with keyboard shortcut should exist for html5 but not dependent css3 documents.


Reduce memory consumption and increase performance for image comparison

[ ] Determine memory usage for individual image (both raw and loaded into resemble)
[ ] Determine what impact converting image to smaller size has on cumulative memory usage, comparison speed, and general cpu usage
[ ] Potentially refactor image comparison object usage (repeat/recent reference objects) based on results from above

Turns out the majority of run time is due to downloading images. Also using "ignore colors" or setting a bounding box on comparison actually slowed comparisons down b/c resemble is doing more work in those instances...
Was able to reduce rule run time in f8fc63991f6b8f732878c722790ee7a3a07d9bff by:

refactoring image fetch into an async getter (get on-demand)
use reddit previews where possible so the downloaded image is a smaller resolution (if comparable to reference preview resolutions)
do image comparisons in parallel using Promise.all instead of for-looping

Unfortunately comparisons in parallel is making memory usage skyrocket. Need to investigate p-map so i can set concurrency to something reasonable (or user-configurable)


Historic values of the observables

Is it possible to recover the values of the observables at the end of each sweep? I see they're saved as LogBinners and I wonder if I can recover the original values. Thanks in advance.

Oh that's easy enough. Thanks again!

Sorry to keep bothering but something breaks when making that change (changing every definition from LogBinner to FullBinner in Observables.jl).  This is the error I get when I try to import the modified package.

Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, ignore_loaded_modules::Bool)
@ Base ./loading.jl:1466
[3] compilecache(pkg::Base.PkgId, path::String)
@ Base ./loading.jl:1410
[4] _require(pkg::Base.PkgId)
@ Base ./loading.jl:1120
[5] require(uuidkey::Base.PkgId)
@ Base ./loading.jl:1013
[6] require(into::Module, mod::Symbol)
@ Base ./loading.jl:997
in expression starting at /home/user/Documents/try.jl:1

The FullBinner struct has slightly different type parameters, so you would need to make the following adjustments in Observables.jl:
mutable struct Observables
    energy::ErrorPropagator{Float64,32}
    magnetization::FullBinner{Float64,Vector{Float64}}
    magnetizationVector::FullBinner{Vector{Float64},Vector{Vector{Float64}}}
    correlation::FullBinner{Vector{Float64},Vector{Vector{Float64}}}
end

function Observables(lattice::T) where T<:Lattice
    return Observables(ErrorPropagator(Float64), FullBinner(Float64), FullBinner(Vector{Float64}), FullBinner(Vector{Float64}))
end

You can then access the full time series of measurements e.g. in Observables.magnetization.x.

Thank you, that worked!


Review and modify the Beckn-ONIX core specification

Description
Rajaneesh is working on Beckn-ONIX specification. Work with Rajaneesh to:
a. Finish review of the Core Beckn-ONIX specification
b. Revisit the document and fill in details on the core features
c. Work with Ravi on the non-core specifications.
Maybe this ticket will be split into multiple issues.

It has been decided that this approach is not needed. Instead a new effort is being started to document the core requirements of Beckn ONIX. So closing this issue. The following are the issues on the new effort.
https://github.com/beckn/missions/issues/95
https://github.com/beckn/missions/issues/96


Downloading package 'Mono Runtime (macOS)' Failed at stage: downloadPackages Error: self signed certificate in certificate chain

Environment data
dotnet --info output:.
NET Command Line Tools (1.0.0-preview2-003148)
Product Information:
Version:            1.0.0-preview2-003148
Commit SHA-1 hash:  18ca244551
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.11
OS Platform: Darwin
RID:         osx.10.11-x64
VS Code version: 1.7.1
C# Extension version:1.5.2
Steps to reproduce
Installed Visual Studio Code for Mac OS
Opened VS Code
Because Firewall Set user settings:
{
"http.proxyStrictSSL": false
}
Installed C# for VS Code
Make new dotnet app in terminal
Open dotnet app folder
Expected  behavior
Normal Behavior
Actual behavior
Alert = An error occurred during installation of the .NET Core Debugger. The C# extension may need to be reinstalled.
C# Output:
Updating C# dependencies...
Platform: darwin, x86_64 (osx.10.11-x64)
Downloading package 'Mono Runtime (macOS)' Failed at stage: downloadPackages
Error: self signed certificate in certificate chain
Finished
[ERROR]: C# Extension failed to install the debugger package
Tried reinstall VS Code, Mono, an the C# Extension multiple times.

Hmmm... are you able to download from the following link? https://omnisharpdownload.blob.core.windows.net/ext/mono.osx-4.6.1.zip

Also, do you somehow have a proxy enabled (ex: "http.proxy" option, or environment variable)?

@DustinCampbell I am able to download from that link.
@gregg-miskelly I don't believe I have any environment variables set. Not sure about the "http.proxy" option, except the User Settings one in VS Code I set to allow me to install extensions
{
"http.proxyStrictSSL": false
}

Hmmm... @gregg-miskelly: it looks like we'll never use that option unless http.proxy is set.

I bet we also need to set rejectUnauthorized here using the value of strictSSL.

Yup: https://github.com/Microsoft/vscode/blob/2f76c44632b0d47ba97f66fbc158c763628e30b3/src/vs/base/node/proxy.ts#L47

@Jamie-McCaw: I've produced the first beta of our next release which should address this problem. Could you install it and try it out? You can follow the steps below to install the beta:

Open Visual Studio Code and select View->Extensions to display the Extensions Pane.
In the Extensions pane, clear the little gear icon for the C# extension and select "Uninstall". Confirm Visual Studio Code's prompts and allow it to reload.
Download the latest beta .vsix here.
In the Extensions pane, click the [...] in the top-right corner and select "Install from VSIX...". Locate the .vsix you just download and click "Open".
Allow Visual Studio Code to reload and open your project.

Let me know if the downloads work for you now.

This resolves the issue for me on Windows using VSCode 1.7.1.

Excellent! Thanks for letting me know

@HjoshM Sorry the storage account that used to host these old packages has been removed. Meaning these packages are no longer available for download.


Don't defer updating threadmark thread_id when moving posts

See #17.
When moving a threadmarked post to a different thread, it would be preferable to not defer the updating of a threadmark's `thread_id.
It takes a few seconds (or longer if larger forums are running deferred tasks via cron) for the threadmark to appear in the target thread. This is likely to lead to confusion among moderators/admins, they may think the threadmark has been lost during the move.
Investigate alternatives to deferring.

One solution may be to relate the join condition in Sidane_Threadmarks_Model_Post::preparePostJoinOptions
LEFT JOIN threadmarks  ON
          (threadmarks.thread_id = post.thread_id && threadmarks.post_id = post.post_id)

It would require a post_id index on threadmarks since MySQL may not be able to use the index without the thread_id.
Then in the display code, if the thread_id from the threadmark doesn't match the thread; display a spinner on the presumption a deferred task is working on cleaning it up.

PR #40 should vastly improve this.

Yep, a definite improvement, thanks.
All that remains in this issue is that the threadmarks menu isn't visible until the deferred task completes.

Fully resolved in #49


Add an option for a village to grow

Prerequisites: #185 #161
Add a reward that grows a village, rather than a character.

[x] Create a database for a village
[x] Create back-end functionality to grow the village, similar to the Character. Look in #161
[x] Create the front-end summary of the village
[x] Allow for switching

Database
Table: villages

id
timestamps
name
user_id
active
For the types:
Villagers (level)
Economy/Trade/Traders (Probably economy level - cha++ int+ end+) - Mental++ Social+
Labourers/Farms (Probably labour level - strength++ end++ agility+) - Physical+++
Craftsmen (Probably craft level - agility++ int+ end+) - Mental++ Physical+
Artists (Probably art level - cha++ int++ ) - Social++ Mental+
Community (Probably community level) - Social++ Physical+
str 2, agi 3, cha 4, int 4, end 4,
Phys 5, Mental 5, Social 5.

TODO check all functions, mainly the stores, for unnecessary functions


Review Computation of No-Skill reference line on Reliability Plots

Describe the Problem
The No-Skill line on the reliability diagram should always be half-way between the skillful line and the climatology line.  Right now METviewer doesn't not always place it there.  This was pointed out by Binbin and Binyu at EMC.  Their reporting of the issue can be found on the METplus Users meeting notes from 9/21/2020
Expected Behavior
See Ensemble Forecast Verification Slides 11-16 for expected behavior (slide 16 shows where the no-skill line)
Environment
Describe your runtime environment:
*1. Machine: AWS or Linux server
*2. OS: whatever is on AWS and Mohawk
*3. METviewer 3.1
To Reproduce
Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
This is a bug and needs priority attention.  It probably needs to be updated in both METviewer R and here.  I'll be linking this to METviewer
Funding Source
2790541
Define the Metadata
Assignee

[x ] Select engineer(s) or no engineer required
[x ] Select scientist(s) or no scientist required

Labels

[X ] Select component(s)
[X ] Select priority
[X ] Select requestor(s)

Projects and Milestone

[ ] Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
[ ] Select milestone to relevant bugfix version

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ]  METviewer,

Bugfix Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of main_<Version>.
Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
[ ] Fix the bug and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into main_<Version>.
Pull request: bugfix <Issue Number> main_<Version> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s), Project(s), Milestone, and Linked issues
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Complete the steps above to fix the bug on the develop branch.
Branch name:  bugfix_<Issue Number>_develop_<Description>
Pull request: bugfix <Issue Number> develop <Description>
[ ] Close this issue.

this is a part of #48 and was implemented


feat(advance-runner)!: validate snapshot hash

The snapshot's template hash gets compared with its counterpart in the blockchain, causing the advance-runner to stop if it does not match.
BREAKING CHANGE: adds the PROVIDER_HTTP_ENDPOINT parameter, which is required to validate snapshots. Validation is enabled by default, but can be disabled by setting SNAPSHOT_VALIDATION_ENABLED to false
Closes #36

Since you're already adding a BREAKING CHANGE with PROVIDER_HTTP_ENDPOINT parameter, I think it's a great opportunity to standardize the PROVIDER parameter across services.
dispatcher
TX_PROVIDER_HTTP_ENDPOINT => PROVIDER_HTTP_ENDPOINT

state-server
BH_HTTP_ENDPOINT => PROVIDER_HTTP_ENDPOINT
BH_WS_ENDPOINT => PROVIDER_WS_ENDPOINT

@endersonmaia, these changes are unrelated to this PR. Also, they are in another service and involve changing external dependencies (the state fold and the transaction manager). So we should not do this now.

Should I open an issue for that?

Here is the related issue: https://github.com/cartesi/rollups-node/issues/7


Feature Request: Generate items like UUIDs in headers

There are times where you want to generate a UUID or a timestamp in the header to be able to track a request. Would be nice if we could do {{UUID}} or {{TIMESTAMP}} to automatically generate this and insert it like with env variables.

hello @ErkanSensei !
This is a very great idea. I'll note that one in the todo list
Have a great day

Wish I could help with these requests but I don't know Rust unfortunately :/ Great project though either way!

here you go @ErkanSensei

Closed by https://github.com/Julien-cpsn/ATAC/commit/3d5155241829216b9dc8c38efc759ce4a23edfc3


Contains the lab section in the subject line.
Contains the feedback in the body.


Add idle state to LCE

Add idle state to LCE to simplify TournamentModel (removed the need for Optional).

Codecov Report

Merging #19 into develop will increase coverage by 0.11%.
The diff coverage is 89.47%.

@@              Coverage Diff              @@
##             develop      #19      +/-   ##
=============================================
+ Coverage      46.52%   46.63%   +0.11%
+ Complexity       313      310       -3
=============================================
  Files             82       82
  Lines           1382     1383       +1
  Branches          91       89       -2
=============================================
+ Hits             643      645       +2
  Misses           699      699
+ Partials          40       39       -1

Impacted Files
Coverage Δ
Complexity Δ

...ava/net/erikkarlsson/smashapp/common/data/Lce.java
93.33% <100%> (+1.66%)
15 <10> (+3)
:arrow_up:

...ashapp/tournament/domain/TournamentInteractor.java
84.21% <100%> (ø)
8 <0> (ø)
:arrow_down:

...on/smashapp/tournament/domain/TournamentModel.java
90% <77.77%> (+2.5%)
21 <8> (-6)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd3659...3f220ae. Read the comment docs.


Use versioned api path

Is your feature request related to a problem? Please describe.
Currently this service exposes its base controller under /api/server. This deviates from the pattern used across other services.
Describe the solution you'd like
Provide a versioned base endpoint and include the service name is the base path (e.g. /api/dispatch/v1/). The existing path should also be supported during a transition period.

@tassja I'd have a grep of the codebase to see anywhere the dispatch service is used. This is a service without a client, so I'd be extra careful


Browser Release Dates

This isn't really an issue, it's more of a suggestion than anything else. I think it would be cool to have the release year for each browser that is listed in the support section.

Duplicate of #202.


Query regarding practice mergers

From a user:

I just tried to check the data for my own local practice, which is Dukinfield Medical practice. You don't show this. It was formed by a merger of The Hollies surgery and Davaar Practice well over a year ago. You only show Davaar. Is this because you haven't caught up with the change of name but are including all the data, or are you only showing half the data - the combined practice is using both sites as before.

In our current practices table:

Dukinfield Medical practice does not exist
Davaar Medical Centre is P89021 and is Active
Hollies P89027 is Closed

This is reflected in the epracurr.csv we used in August for the June import.
@brianmackenna says:

Dukinfield P89021 and Hollies P89027 is listed on epracur but not Davaar

Which I have verified. But I note the current NHS Digiral epraccur was uploaded on 31 August, after our last import.
It looks like the data on our website is correct, but NHSD hadn't updated epraccur with the name of the mergee practice.  That, or there was an issue with our import, but I doubt it.
Suggest waiting til next month and seeing if that's fixed then. @inglesp feel free to take a look sooner if you feel like it!
To close this issue: check that  this practice is now called Dukinfield Medical Practice.

Practice now has correct name


Its 1208

This branch contains many changes from multiple cards
https://jira.tools.tax.service.gov.uk/browse/ITS-2727
https://jira.tools.tax.service.gov.uk/browse/ITS-2743
https://jira.tools.tax.service.gov.uk/browse/ITS-2745
https://jira.tools.tax.service.gov.uk/browse/ITS-2807
https://jira.tools.tax.service.gov.uk/browse/ITS-2805

Please do Squash & Merge.


Encounter padding is Negative in function _renderMarkedMap

Version of flutter_calendar_carousel
flutter_calendar_carousel: ^1.3.18
Expected behavior
Working nicely even the marked dates have more than one event
Actual behavior
The following assertion was thrown building:
'package:flutter/src/widgets/container.dart': Failed assertion: line 314 pos 15: 'padding == null || padding.isNonNegative': is not true
flutter doctor result (run flutter doctor in terminal)
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.15 19A602, locale en-ID)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
[✓] Android Studio (version 3.5)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.2.3)
[!] VS Code (version 1.39.1)
✗ Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (1 available)
Steps to reproduce the behavior
The markedDates have multiple events who have exactly same date time even though the titles are different

I think we need minimal reproduction to test out.

This is the sample codes for the reproduction
CalendarCarousel<Event>(
            height: height,
            onDayPressed: (DateTime date, List<Event> events) =>
                _onShowScheduleDialog(context, date, events),
            onDayLongPressed: (DateTime date) {},
            daysHaveCircularBorder: this.isCircular,
            // header
            showHeader: showHeader,
            headerTextStyle: TextStyle(
              color: _headerColor,
              fontSize: this.headerSize,
              fontWeight: this.headerWeight,
            ),
            iconColor: _headerColor,

            daysTextStyle: TextStyle(
              color: this.labelColor,
              fontWeight: FontWeight.w300,
            ),
            markedDateCustomTextStyle: TextStyle(
              color: this.labelColor,
              fontWeight: FontWeight.w600,
            ),
            nextDaysTextStyle: TextStyle(
              color: this.headerColor,
              fontWeight: FontWeight.w300,
            ),
            prevDaysTextStyle: TextStyle(
              color: this.headerColor,
              fontWeight: FontWeight.w300,
            ),

            weekdayTextStyle: TextStyle(
              color: this.labelColor,
              fontWeight: FontWeight.w500,
              fontSize: this.labelSize,
            ),

            selectedDateTime: selectedDateTime ?? DateTime.now(),
            selectedDayBorderColor: Colors.transparent,
            selectedDayButtonColor: _activeColor,
            selectedDayTextStyle: TextStyle(
              color: Colors.white,
              fontSize: labelSize,
              fontWeight: FontWeight.w800,
            ),

            todayTextStyle: TextStyle(
              fontSize: this.labelSize * 1.2,
              fontWeight: FontWeight.w800,
              color: this.todayLabelColor,
            ),
            todayButtonColor: _activeColor,
            todayBorderColor: Colors.transparent,

            isScrollable: true,
            customGridViewPhysics: NeverScrollableScrollPhysics(),

            markedDatesMap: _getMarkedDates,
            markedDateShowIcon: true,
            markedDateIconMargin: 0,
            markedDateIconBuilder: (event) => event.icon,
)

And this is the _getMarkedDates()
EventList<Event> get _getMarkedDates {
    var eventList = <DateTime, List<Event>>{
      DateTime(2019, 10, 26): [
        Event(
          date: DateTime(2019, 10, 26),
          title: 'Schedule One',
        ),
        Event(
          date: DateTime(2019, 10, 26),
          title: 'Schedule Two',
        ),
      ]
    };
}


Custom white color that Monaco Editor shows before render the control

Hi
We are integrating Monaco Editor in Microsoft Windows Template Studio project to show new files and modified files when a developer is adding new pages or features to an existing project.
On this new release, we are integrating Visual Studio Color Service in the wizard, adding Dark Theme support. We are adding the setting theme: "vs-black" to Monaco editor, but it quickly shows a white screen before rendering the control, and it produces a strange effect because the layout is on dark theme.
It also happens on Monaco Playground if I add the dark theme and click on run button.
Is there any way to avoid this white screen before render the control or custom that color?
We are loading Monaco editor in this HTML file displayed on a Web Browser control inside the WPF application.
Thank you so much.

@mvegaca I don't observe any flashing when running at https://microsoft.github.io/monaco-editor/playground.html#creating-the-editor-hello-world the following sample:

js:

setTimeout(function() {
    monaco.editor.create(document.getElementById("container"), {
        value: "function hello() {\n\talert('Hello world!');\n}",
        language: "javascript",
        theme: "vs-dark"
    });
}, 1000);

html:

Notice how there is a white flash, but that happens before the monaco editor executes anything. The creation of the editor (which is delayed by 1s) makes no background flash:

The white color displayed is, in this case, the background color of the web browser, the gif image you added shows it: White Screen -> Black Screen -> Code Displayed.
The following Image shows the effect on WTS Wizard.

I think it is caused because the Web browser is loaded as a white control, and then Monaco starts using the dark theme.

We've done a visibility updates implementation to fix it. Thank you.


Tutorial

Hello @mahnve, great repo.
Do you have a tutorial or blog post of how to configurate all these CIs types?
Best

Thanks. No, I would have to refer to the individual CI services, as I am using them in a very basic way. Most of them are configured by files in the root, like .travis.yml


Unable to resolve version 3.18.3

I am unable to resolve dependencies (through Terminal or Xcode) with the latest versions of the SDK. It looks like RadarSDKLocationPermission.xcframework.zip artifact is no longer being published by the core Radar SDK.
swift package resolve
Downloading binary artifact https://github.com/radarlabs/radar-sdk-ios/releases/download/3.18.3/RadarSDKLocationPermission.xcframework.zip
error: failed downloading 'https://github.com/radarlabs/radar-sdk-ios/releases/download/3.18.3/RadarSDKLocationPermission.xcframework.zip' which is required by binary target 'RadarSDKLocationPermission': badResponseStatusCode(404)
Downloading binary artifact https://github.com/radarlabs/radar-sdk-ios/releases/download/3.18.3/RadarSDKMotion.xcframework.zip
Downloading binary artifact https://github.com/radarlabs/radar-sdk-ios/releases/download/3.18.3/RadarSDK.xcframework.zip
error: fatalError

My example Package.swift:
import PackageDescription

let package = Package(
    name: "RadarTest",
    products: [
        // Products define the executables and libraries a package produces, making them visible to other packages.
        .library(
            name: "RadarTest",
            targets: ["RadarTest"]),
    ],
    dependencies: [
        .package(url: "https://github.com/radarlabs/radar-sdk-ios-spm", from: "3.18.3")
    ],
    targets: [
        // Targets are the basic building blocks of a package, defining a module or a test suite.
        // Targets can depend on other targets in this package and products from dependencies.
        .target(
            name: "RadarTest"),

    ]
)

Looks like this was fixed by the re-release of 3.18.3.


Attribute values are not HTML decoded

When I get the attribute value of a node the result is not HTML decoded. When I read it with XmlDocument it is decoded. I think it should be decoded in HAP, too.
            var doc = new HtmlDocument();
            doc.Load(fileName);
            var link = doc.GetElementbyId("link1");
            var href = link.GetAttributeValue("href", null);
            Console.WriteLine("html:" + href);

            var xml = new XmlDocument();
            xml.Load(fileName);
            var link2 = xml.DocumentElement.SelectSingleNode("//html/body/a");
            var href2 = link2.Attributes["href"].InnerText;
            Console.WriteLine("xml:" + href2);

Result:
html:http://example.com/?q=1&r=2
xml:http://example.com/?q=1&r=2
The test file:

Test

Hello @romainecarter ,
Thank you for reporting, we will look at it.
Best Regards,
Jonathan

Help us to keep this library free: Donate

Hello @zgabi ,
You are correct about what is the right value our library should return. But due to the number of people using this library and the impact of breaking this code, we cannot do this fix by default.
Some people already reported us in the past some issue when we fixed the value in the correct way.
What I could propose is adding this fix only when the option BackwardCompatibility = false.
So people already using our library are not impacted and people with this options have some of the latest fixes.
Best Regards,
Jonathan

Hello @JonathanMagnan
That is ok for me.
Is it possible to add a static default setting for this compatibility flag, like this?
In HtmlDocument.cs:
        public static bool DefaultBackwardCompatibility = true;

        /// True to stay backward compatible with previous version of HAP. This option does not guarantee 100% compatibility.
        public bool BackwardCompatibility = DefaultBackwardCompatibility;

So all the new HTML documents will be correct if you set the DefaultBackwardCompatibility to false.
The name and the position of the property is only a suggestion, you can put it anywhere. I don't know, maybe HAP has a static configuration place.
Thanks,
Gábor

Hello @jnyrup  ,
The v1.6.10 has been released.
I have added a builder as I normally do in my other projects to perform some global config. You can now use the DefaultBuilder options to specify all configurations that will be applied to newly HtmlDocument
HtmlAgilityPack.HtmlDocument.DefaultBuilder = builder => builder.BackwardCompatibility = false;

Let me know if there is something else we can do.
Best Regards,
Jonathan

Help us to support this library: Donate

Hi,
Now you have added a breaking change for the P tags. Why don't you set this BackwardCompatibility setting also to false, too?
When somebody needs the old mode, then he can set it to true. Your library would be more compatible with the modern web browsers.

+1 for me. I'm using the library to transform Html to plain text, and the latest changes in 1.10.0 made lots of tests red. I'd be happy with setting the default to false, to continue with the old behavior if nothing is explicitly set.

The library needs a big revamp to make it HTML5 compatible. We already know exactly how to do it but unfortunately, time is always missing for a free library ;(
It's possible to report in which case the P tag currently doesn't longer work? We will review it on our side today by setting tag omission and other stuff: http://w3c.github.io/html-reference/p.html
It's possible that we revert our change, but I would like to try it at least as the old setting will never work. Too much issue has been reported with the P tag caused by this line: https://github.com/zzzprojects/html-agility-pack/blob/master/src/HtmlAgilityPack.Shared/HtmlNode.cs#L133

A new version 1.10.1 is now released.
All "implicit ending" should now be handled correctly.
A new version will be available later today as we have found a major issue last week about how a tag is not ended correctly. It will certainly fix a lot of additional issues.
As said, I believe it worth the try to change the behavior if we can make it quickly work correctly.
@GeorgDangl , if you could provide us your test project to<EMAIL_ADDRESS>it will greatly make this process faster.

I'll look at the test and extract the changed behavior that affected me.
I think it was when
 elements had nested children, something like this:

Begin
Inner
End
. The parsing related to that has changed.
I'll report back when I've got something more detailed.

You can reproduce it with this test case:
[Fact]
public void ChangesToPHandling()
{
    var input = "
Begin
Inner
End
";
    var doc = new HtmlAgilityPack.HtmlDocument();
    doc.LoadHtml(input);
    var docNode = doc.DocumentNode;

    // Check tree is correct
    Assert.Single(docNode.ChildNodes);
    Assert.Equal("p", docNode.ChildNodes[0].Name);

    var pRootNode = docNode.ChildNodes[0];
    Assert.Equal(3, pRootNode.ChildNodes.Count);
    Assert.Equal("Begin", pRootNode.ChildNodes[0].InnerText);
    Assert.Equal("Inner", pRootNode.ChildNodes[1].InnerText);
    Assert.Equal("End", pRootNode.ChildNodes[2].InnerText);
}

This succeeds in 1.9.1 but fails in 1.10.1.
Here's how the trees are generated:
v1.10.1:
Tree:

p: Begin
div: Inner
#text: End

v1.9.1:
Tree:

p

#text: Begin
div: Inner
#text: End

Additionally, this parses correctly when replacing the inner div with a span element.
div is actually not a valid child element of p, so I guess the behaviour is correct within the Html specification. But it would be great to be able to still parse such trees, since not every string I encounter conforms to the Html spec:)

The v1.10.1 is what we are expecting. A div cannot be inside p as you specified.
You can turn on globally the default P behavior using:
HtmlDocument.DisableBehavaiorTagP = true;

We are currently looking all prerequistes if we want to create a HAP V2.0. I have added an option to disable all those kind of fixes.

The test case above fails with both settings for HtmlDocument.DisableBehavaiorTagP, neither true nor false make any difference.
Is there another option to restore the original behavior from v1.9.1? Optionally, can you point me to the commit where this change was introduced? I'd be very happy to create a pull request and make this a configurable option for the document.
Unfortunately, I have to parse documents that may contain
 inside of
. So far, I've always been quite happy with HtmlAgilityPack parsing the DOM exactly as given, but I understand that you want to make some corrections during parsing.

You are right,
I forget that we added implicit end logic here: https://github.com/zzzprojects/html-agility-pack/blob/master/src/HtmlAgilityPack.Shared/HtmlDocument.cs#L1797
I would make the change and release it in a few minutes.

The v1.10.2 is now released.
We added your unit test to make sure we always support this case.
Let me know if everything is correct on your side with HtmlDocument.DisableBehavaiorTagP = false

So far, everything looks good on my side, except one issue:
The static constructor for HtmlNode has the following check:
if (!HtmlDocument.DisableBehavaiorTagP)
{
    ElementsFlags.Add("p", HtmlElementFlag.Empty | HtmlElementFlag.Closed);
}

So there can be situations where the static constructor for HtmlNode is invoked, then the HtmlDocument.DisableBehavaiorTagP property is set. This led to flaky tests on my side, since I'm using xUnit and this randomized the order of execution - in some test runs, HtmlNode was initialized before, and in some, after the field was set in HtmlDocument.
There's no update or synchronization mechanism between these two.
I've updated my classes to perform this action:
private static void EnsureHtmlAgilityPackLegacyBehavior()
{
    if (!HtmlDocument.DisableBehavaiorTagP)
    {
        HtmlDocument.DisableBehavaiorTagP = false;
    }
    if (!HtmlNode.ElementsFlags.ContainsKey("p"))
    {
        HtmlNode.ElementsFlags.Add("p", HtmlElementFlag.Empty | HtmlElementFlag.Closed);
    }
}

To solve this directly in HtmlAgilityPack, maybe you could implement something like this:
/// True to disable, false to enable the behavaior tag p.
internal static bool DisableBehavaiorTagP = true;
/// True to disable, false to enable the behavaior tag p.
public static void SetLegacyBehaviorForTagP(bool useLegacy)
{
    DisableBehavaiorTagP = useLegacy;
    if (useLegacy && !HtmlNode.ElementsFlags.ContainsKey("p"))
    {
        HtmlNode.ElementsFlags.Add("p", HtmlElementFlag.Empty | HtmlElementFlag.Closed);
    }
    else if (!useLegacy && HtmlNode.ElementsFlags.ContainsKey("p"))
    {
        HtmlNode.ElementsFlags.Remove("p");
    }
}
public static bool UseLegacyBehaviourForTagP()
{
    return DisableBehavaiorTagP;
}

and just remove the logic in the static constructor for HtmlNode completely.
Btw, thank you very much for the quick replies and the fast releases, I really appreciate that:)

Hello @GeorgDangl ,
Sure, we will look at it and release something similar or exactly this tomorrow.
No problem ;)

Hello @GeorgDangl ,
The v1.11.0 has been released.
We fixed the spelling mistake in DisableBehavaiorTagP to DisableBehaviorTagP . We have kept it as a property since we know some people already use it but we added your code inside the set to make it work exactly as you specified.
This version also contains another major change for when ending tag is missing, so make sure to test it.
Let me know if everything is working as expected.

Thank you!
So far, I've noticed no regressions with v1.11.0, but I will have to run the tests also in dependent projects. I'll update here.

Just wanted to report back, I've upgraded to the latest version, no regressions in any downstream projects for me. Thank you very much!

Great @GeorgDangl ,
Thank for letting us know :)


Update message usage of delete, mark and unmark to match user guide

Codecov Report

Merging #326 (7dbfd94) into master (dd5a416) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #326   +/-   ##
=========================================
  Coverage     63.26%   63.26%
  Complexity      514      514
=========================================
  Files            89       89
  Lines          1851     1851
  Branches        235      235
=========================================
  Hits           1171     1171
  Misses          607      607
  Partials         73       73

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/DeleteCommand.java
92.68% <ø> (ø)

...java/seedu/address/logic/commands/MarkCommand.java
0.00% <ø> (ø)

...va/seedu/address/logic/commands/UnmarkCommand.java
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5a416...7dbfd94. Read the comment docs.


Button changes

This PR adds new props to <Button />:

Button Icon <Button icon="face" />

Button Disabled <Button disabled />

Button Small <Button size="small" />

Button Medium <Button size="medium" />

Button Large <Button size="large" />

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updated componentWillReceiveProps methods

Updated methods using using npx react-codemod rename-unsafe-lifecycles. Temporary solution to issue  #534

@oliviertassinari could this pull request be accepted?

Looks like this is the solution recommended by react. Checks have passed, its been approved - do we think we can merge this?
p.s. @doper1234 :raised_hands: - thank you from all of us

can we merge this?

@oliviertassinari please

@oliviertassinari please

@ValentinMumble please approve

I pulled this into #616 and merged it.


Cached diagram retrieval is case-sensitive

Even though GitHub usernames and repository names are case-insensitive (meaning e.g. ALPHA, alpha, and ALphA are equivalent identifiers), GitDiagram will regenerate the repository diagram if the case is not the same.

See e.g. https://gitdiagram.com/quantum9innovation/quasaros and https://gitdiagram.com/quantum9innovation/QuasarOS (same repository but with different case yields different default diagrams)


How to control how fast an interactable view sends an onSnap event?

Hi,
I have a use case where I need to receive the onSnap event faster than default behaviour.
Is there a way to control how fast an interactable view sends an onSnap event?
I tried to set view's velocity but it didn't help.
Thanks for the help!

Could you provide some more input on what you'd like to achieve?
I'm using a hack to remove an overlay instantly but don't know if this would be helpful to you.

I have a top panel that needs to be displayed when clicking on a button.
This panel has 4 snapPoints:

fully hidden (before clicking preview)
2 intermediate points
max snap point

When the user open this panel to the maximum, the panel should become scrollable.
The issue is that I receive the onSnap event for the max snap point with a little delay as visible in the gif below (see warning at the bottom of the screen).
I am wondering if it is possible to control how fast the event for a snap point is sent.

<Interactable.View
        ref={thumbPreviewRef => {
          this.thumbPreviewRef = thumbPreviewRef;
        }}
        style={{
          position: 'absolute',
          left: 0,
          right: 0,
          top: 0
        }}
        verticalOnly
        initialPosition={{ y: -PANEL_HEIGHT }}
        snapPoints={[
          { y: -PANEL_HEIGHT, id: CLOSED_SNAP_POINT_ID },
          { y: -PANEL_HEIGHT + PADDING },
          { y: -Screen.width * (1 / 2) },
          { y: 0, id: MAX_OPENED_SNAP_POINT_ID }
        ]}
        boundaries={{ bottom: 0 }}
        animatedNativeDriver
        onSnap={event => {
          const { nativeEvent } = event;
          if (nativeEvent.id === CLOSED_SNAP_POINT_ID) {
            if (this.state.scrollEnabled) {
              this.setState({ scrollEnabled: false });
            }
            this.props.onClosed();
          } else if (nativeEvent.id === MAX_OPENED_SNAP_POINT_ID) {
            console.warn('Received max snap point event');
            if (!this.state.scrollEnabled) {
              this.setState({ scrollEnabled: true });
            }
          }
        }}
      >
        <View style={styles.panel}>
          <FlatList
            ref={flatListRef => (this.flatListRef = flatListRef)}
            data={this.props.data}
            bounces={false}
            directionalLockEnabled
            keyExtractor={(item, index) => index}
            scrollEnabled={this.state.scrollEnabled}
            onScroll={event => this.onScroll(event)}
            scrollEventThrottle={16}
            renderItem={({ item, index }) => {
              return (
                <Text>
                  <Text>
                    In in ut adipisicing fugiat ullamco anim aliqua cillum
                    labore esse commodo deserunt dolor consectetur. Id eu ipsum
                    esse pariatur id consectetur aliqua non. Veniam nulla irure
                    et cillum irure. Sint ea enim est eiusmod consectetur velit
                    do elit irure adipisicing pariatur.
                  </Text>
                  In velit pariatur id tempor. Magna deserunt enim amet minim.
                  Laborum est sint magna consectetur reprehenderit consectetur
                  ea consectetur culpa amet exercitation laborum officia
                  proident.
                </Text>
              );
            }}
          />
        </View>
      </Interactable.View>

// and the style
  panel: {
    height: PANEL_HEIGHT,
    backgroundColor: '#eee'
  },

What you want to achieve is called nested scrolling and a big problem on android. Therefore the android sdk contains classes like CollapsibleLayout and NestedScrollView to achieve the effects you'd like to get.
I don't think interactible is the right tool (yet) for your requirements. I'd rather look into wrapping a native Collapsible Header + NestedScrollView. Maybe there are already libraries doing this for you.
That said I see two possible hacks to resolve the problem. By hacks I mean I don't really like these solutions but you might want to try it out.

Put a static view above your scrollview inside the panel so that you cannot scroll it. Then add a transforms function to the overlay to remove it according to the panel position. Just translate X/Y by screen width/height for 99% of the possible panel positions. The other 1% translate 0 so that the scrollview cannot get touches. If you set your transform points exactly 1 pixel in front of the snapping point this "snaps" 100% immediately.

Calculate your scrolling content total height. Make the content static, not scrolling. Add snap points according to content height / screen height so that the user can snap through the panel.
I'm looking forward to hearing your thoughts.

@jnsone11  Thanks for those precious details :)
I'll try have a look at this in the coming days and will give updates.
One thing I forgot to mention is that I try to implement this behavior only in iOS.
Is your comment still valid for iOS?

This is also valid for iOS because what you'd like to achieve is reacting immediately to the snap event which is a problem on both iOS and Android if you handle these events from within JS and not native only. You will have to find a way to declare the desired behaviour, encode it and send it from JS to native. From there it should be executed without further communication via the bus to guarantee smooth ux.

@talkol @rotemmiz Any thoughts about this issue? Do you think such UI requirement could be supported by react-native-interactable? If so, what would be the best approach (for iOS first) ?
I would like to contribute but not sure how to tackle this.

@jensneuse What's your hack to remove overlay instantly? I am trying something similar where I need to remove the overlay when user swipes a card out. However, onSnap event is firing slow (1-2s delay) on iOS which makes the overlay modal background slow to dismiss.

@chefkefu I've described it above.

The issue I see here is that onSnap may be called with a big delay. Of course this is not intentional, onSnap show be called instantly.
We will investigate.

This makes swipe action looks really really laggy

Same issue here, onAlert works instant, onSnap works with delay

Issue solved :)
Use id for your snapPoints, example:
snapPoints={[
  { y: 40,  id: 'top' },
  { y: Screen.height - 300, id: 'middle' },
  { y: Screen.height - 100, id: 'bottom' }
]}

After what use onDrag:
 onDrag={event => {
     // Your current position - alert.nativeEvent.targetSnapPointId
     console.tron.log(event.nativeEvent.targetSnapPointId);
 }}

You will have instant snapPoints current position.

If your user isn't dragging (e.g. if you use instance.snapTo()) but you still require the event to fire instantly, add alertAreas to your view and then make use of the onAlert event.


Refactor PresolverImpl

This PR adds a few things

Support for TechniqueFlags rather than one single boolean to toggle presolve techniques. Although right now we don't yet implement the individual flags
Support for Feasibility enum which will be used to indicate whether a model is feasible
Many presolve techniques have been renamed to normalization_* methods. This is a step towards addressing https://github.com/dwavesystems/dwave-preprocessing/issues/78
Implemented PresolveImpl::normalize() and PresolveImpl::presolve() as methods that can be called separately
Added tests for the individual normalization techniques

There are several things still to do

Make the presolve techniques public members of PresolveImpl so that they can be individually tested
Implement the individual TechniqueFlags
Support setting the Feasibility enum rather than raising an error for infeasible models

But, since this PR is at somewhat at a stopping point, I think it makes sense to get it reviewed where it is and then the todos can be done in followup PRs.


BUG: Support for markdown preamble cell seems to be broken

The preamble option jupyter_header_block appears to be broken.

this is not heavily used so will move to 0.6 milestone


Simple WSGI deployment

Deploying the server on WSGI compliant HTTP servers is currently not straightforward. We need simple, well-documented recipies for deploying on common platforms such as Apache and Nginx. We may need to add some helper functions into ga4gh.server to make this as easy as possible.

Fixed in #238