Decompiler: add for loop construct

For loops are one of the most natural and popular loop constructs for programmers. The decompiler currently only supports while variant loops (Issue https://github.com/NationalSecurityAgency/ghidra/issues/644), which are typically harder to quickly grok when scanning through decompiled code. Once I realized that this wasn't already being worked on, it seemed like the perfect project to jump into. So, here is my attempt to add a for loop control flow structure to the decompiler.
The main challenges with getting this code to behave were:

Taking ownership of FlowBlock objects that were inferred to be used to initialize a for loop, but were already in a structured block (e.g. in a List)
Determining how much of a basic block should be printed in the initializer and post-body sections of the for loop

The big parts of the patch are the For block rule (blockaction.cc) and the For block printer (printc.cc).
For Block Rule
Starting at the CollapseStructure::collapseInternal, I created a new structure BlockFor and added the matching rule to this inner loop. BlockFor can have either 2 or 3 child blocks: the comparison block, the clause block, and an optional initializer block.
Matching a BlockFor follows a similar pattern to BlockWhile and diverges right after an appropriate clause block is found. From here, we need to identify potential initializer and post-body blocks that would make up a for loop in addition to the loop body and condition. This rule appears before the BlockWhile rule meaning it will match patterns that would typically be emitted as while loops. For example, this:
initializer;
while (condition) {
   body;
   post-body;
}

Would become:
for (initializer; condition; post-body) {
   body;
}

Let's start by finding the initializer block. Normally you'd assume this to be simply one of the in-blocks to the condition, but the extra catch is that we need a block that is not a child of any other block or control flow (meaning it will unconditionally execute after the body). For example, if the selected in block was a BlockList, it may contain other blocks that do not act as an initializer. I added a new helper function FlowBlock::getBackBasicLeaf to extract out the single block that meets this criteria. It descends a BlockGraph object and gets the last graph object, including those that are members of a BlockList. Here is an example of a initializer block:
List block 113 invalid_addr-invalid_addr
  If block 113 invalid_addr-invalid_addr
    Condition block(&&) 113 invalid_addr-invalid_addr
      Basic Block 113 0x001aabd9-0x001aac0a
      Basic Block 114 0x001aabdf-0x001aabee
    Basic Block 115 0x001aabee-0x001aabee
  Basic Block 116 0x001aabf2-0x001aabf9

The block of interest isBasic Block 116 0x001aabf2-0x001aabf9.
But now there is an issue: there is no way to transfer ownership of a structured block that is owned by another structured block. This seems intentional given that structure recovery is progressive and one-way, but if a List grabbed my initializer block before the For rule, then this recovery would fail. To handle this, I added BlockGraph::reparent which will allow for a block to be transferred to a new BlockGraph parent. This destroys all edges, but adding them back when the block has a known position is simple. I ran into a ton of segfaults/double frees/use after frees when trying to figure out the right way to do this. Enabling -DBLOCKCONSISTENT_DEBUG in the Makefile was essential for getting this working.
We need to do the same getBackBasicLeaf check for the post-body block, BUT we don't need to reparent it as we take ownership of its parent, which is the body block. This brings us to the next part, which is properly printing the for loop.
For Block Printer
Now that our for block has all of the necessary blocks, we need to pretty print this for the reverse engineer. This brings extra challenges as the selected initializer and post-body blocks may contain statements or expressions that are not relevant to be in these fields. For example, below shows the actual transform we need to make:
initializer -> [not-relevant, initializer]
while (condition) {
   body -> [body, post-body]
}

We need to determine the split between not-relevant/initializer for the initializer field and the body/post-body split for the post-body field. The way to do this, is to selectively walk the PCode of each block in reverse to determine how much of the previous statements should be printed in the for construct or elsewhere. With this approach, I had to employ a hacky way to print the same block twice in two different places without rewriting a lot of logic. To do this, I selectively mark PCode ops as non-printing and restore them once the second half of the block has been printed. Then I use a comma separated scheme to emit the remaining ops for the for construct. This is a bit tricky and messy and could probably be made into a helper function of some kind.
Overall, I'm not happy with the way I solved some of these problems and I've likely missed some corner cases here. As such, this PR should be reviewed by a lot of people for testing on a diverse set of binaries. For my evaluation, I decompiled GLibc before and after the introduction of for loops.
Results
I decompiled all of libc with and without the the patch enabled.
Tool: Ghidra 9.2 (decompiler hot swapped using symbolic link)
Input binary: libc6_2.19-0ubuntu6_amd64.so (not sure why I chose this, just had it lying around)
Eliminate deadcode disabled
Line break at 100 characters.

Metric
Stock
ForLoop

# If-Statements
29114
28778

# Gotos
7326
7214

# DoWhile
2237
2232

# While
1705
785

# For
0
869

# Lines of Code
281109
288861

The reduction of while loops by over 50% is really promising! (Raw results decompile-bench-for.zip)
Here is a great example of it in action
BEFORE

AFTER

It would be nice to print the number in the condition as a decimal; moreover, the condition should be printed as a less-than, with the iterator on the left. It may be possible to add nested loops with a recursive call, I guess

It would be nice to print the number in the condition as a decimal;

Agreed. There already are settings for this in the decompiler. This is out of the scope for this PR.

moreover, the condition should be printed as a less-than, with the iterator on the left.

Agreed, but not in scope for this PR.

It may be possible to add nested loops with a recursive call, I guess

Nested loops are handled perfectly fine. See the raw eval data for libc that I attached.

Well...it looks like a separate commit (https://github.com/NationalSecurityAgency/ghidra/commit/b2bc1eb0193ce3922aac081b1f79c5579234922a) from @caheckman has completely replaced all of this code. I guess this PR is obsolete and can be closed. Too bad it didn't make it in. How should I contribute if I don't know what features are being worked on behind the scenes?

Even if obsoleted, pull requests such as this still have value for many reasons.  This well done write up helps us better understand the needs of our customers.    We have seen other pull requests with code samples that indicate better than words what a user wants.   In many of these pull requests, due to the lack of Ghidra familiarity, the code was not written in a way that we could accept.     But, such code has been the basis for many changes made since Ghidra has gone open source.
We do not yet have a well-defined process for collaboration for changes such as yours.   What has worked the best so for is to start as you have done, with a good write-up and some code changes.  Once you submit such a pull-request, it will sit in the queue until one of the developers has a chance to evaluate it.  Assuming we take on the changes, that is the point at which collaboration will begin.
Regarding this request, I suggest keeping it open until the subject matter expert has a chance to evaluate it.  Even though the underlying code has changed, this ticket still serves to show a desired feature.

Even if obsoleted, pull requests such as this still have value for many reasons. This well done write up helps us better understand the needs of our customers.

Agreed. I may work on more documentation and technical context for the decompiler feature as I feel that this would help
drive more contributions.

We have seen other pull requests with code samples that indicate better than words what a user wants. In many of these pull requests, due to the lack of Ghidra familiarity, the code was not written in a way that we could accept. But, such code has been the basis for many changes made since Ghidra has gone open source.

Understandable. This PR was my first contribution and it had quite a few icky approaches to solving the issue. Did this PR help in any way to drive the closure of GP-565 internally?

We do not yet have a well-defined process for collaboration for changes such as yours. What has worked the best so for is to start as you have done, with a good write-up and some code changes. Once you submit such a pull-request, it will sit in the queue until one of the developers has a chance to evaluate it. Assuming we take on the changes, that is the point at which collaboration will begin.

Could I get some advice on how I can improve my code for next time?

Regarding this request, I suggest keeping it open until the subject matter expert has a chance to evaluate it. Even though the underlying code has changed, this ticket still serves to show a desired feature.

I'll leave the status up to the reviewers.

I'm sure this code was helpful during development.   As to the specifics of how we used this code and how to make it better, I will leave that to those working directly on the Decompiler.

Should become closed (at least after that long time of OBE)


upgrade pysha3 in 0.8

Done. Tag is at https://github.com/bigchaindb/bigchaindb/releases/tag/v0.8.1


CodePush.restartApp not working after updating Datadog

Describe what happened
After updating @datadog/mobile-react-native from 1.0.0-rc2 -> 1.0.0-rc8, I am seeing a completely unrelated issue where my app doesn't restart when I call CodePush.restartApp call or try restarting the app in development by pressing r in the metro development console.
Steps to reproduce the issue:

Update @datadog/mobie-react-native -> 1.0.0-rc8
Press r in metro development console application, or call CodePush.restartApp
Instead of restarting the app, it closes down without any warning or errors

Describe what you expected:

The app restarts correctly as it did before.

Additional context
- SDK Version: 1.0.0-rc8
- package-copy.json.txt
Please let me know if you need any additional information. And thanks a lot for the help!

Hi @tux4, and thanks for opening this issue!
Could you share snippets from the files where you do initialize the Datadog SDK as well as CodePush?
Also I suggest a few debugging actions that might help pinpoint the issue:

Does the issue happen on both iOS and Android?
If you have native error tracking enabled, do you see any error in Datadog?
If you comment the Datadog initialization code (call to DdSdkReactNative.initialize), does the issue still happen?

Don't hesitate to come back to me if any of these isn't clear :)

Hi @louiszawadzki ,
Thanks for the prompt response and the suggestions for debugging. I am providing some additional information based on what you asked.
Snippet
CodePush initialization snippet
// This is exported from App.tsx which is the main App component

export default CodePush({
  checkFrequency: CodePush.CheckFrequency.ON_APP_RESUME,
  installMode: CodePush.InstallMode.ON_NEXT_RESUME,
  deploymentKey: getCodePushDeploymentKey(),
})(Sentry.wrap(App));

Datadog initialization snippet
// This is the main index.js file at the root of the app

const initializeDatadog = () => {
  const config = new DdSdkReactNativeConfiguration(
    Config.DATADOG_RUM_CLIENT_TOKEN,
    Config.ENV,
    Config.DATADOG_RUM_APPLICATION_ID,
    true, // track User interactions (e.g.: Tap on buttons)
    true, // track XHR Resources
    true, // track Errors
  );

  config.nativeCrashReportEnabled = true;

  DdSdkReactNative.initialize(config).catch(e =>
    logger.error('Datadog failed to initialize', e),
  );
};

AppRegistry.registerRunnable(appName, async props => {
  initializeDatadog();
  AppRegistry.registerComponent(appName, () => App);
  AppRegistry.runApplication(appName, props);
});

I tried the debugging steps you recommended and here is what I learnt.

Does the issue happen on both iOS and Android?

Only happens in iOS. App is restarting correctly.

If you have native error tracking enabled, do you see any error in Datadog?

I have attached the native error that was logged when the app crashes. Curiously, there is no mention of DataDog in the logs. Please find the attached log file for more.
46a9ca6e40f643f5881f5becb87c6b75-symbolicated.crash.txt

If you comment the Datadog initialization code (call to DdSdkReactNative.initialize), does the issue still happen?

When I commend out the Datadog initialization code, the issue goes away, and the CodePush.restartApp call does what is expected.
Thanks again!

Hey @louiszawadzki ,
I am initializing Sentry in App.tsx outside of the component function like so -

const optionalSentryConfig: Sentry.ReactNativeOptions = {};
if (Config.RELEASE && Config.DIST) {
  optionalSentryConfig.release = Config.RELEASE;
  optionalSentryConfig.dist = Config.DIST;
}

Sentry.init({
  dsn: Config.SENTRY_DSN,
  environment: Config.ENV,
  ...optionalSentryConfig,
})

In your index.js file, have you tried moving the Datadog initialization our of the registerRunnable, like so:

I tested by moving the initializeDatadog out of the registerRunnable but the behavior is the same as before, i.e. in iOS it is crashing instead of correctly restarting.

Hi @tux4 ,
I've reached out to our iOS SDK team to understand better what's going on here :)
When looking at the crash log it seems that this line of code is breaking: https://github.com/getsentry/sentry-cocoa/blob/758519cbd4c38b8ee11927e11e005ad81b5f744d/Sources/Sentry/SentryNSURLSessionTaskSearch.m#L46
It could be because both the Sentry and the Datadog SDK swizzle (i.e. override the implementation) some of the URLSession APIs in Swift - we would need some time to make sure.
Now that bug probably happens only with version 1.0.0-rc8 because we've added support for first party hosts in this version. And on Datadog's iOS SDK, the moment we set first party hosts is also when we swizzle some of the URLSession APIs at the moment.
What can be tried to prevent this bug

Using codePush.restartApp might lead to other issues with the native iOS SDK, such as actions, views and traces not being sent right after the reload - that will be fixed in the next release but in the meantime it might be worth disabling it if that's possible for you
If you've added some firstPartyHosts in your configuration, try to remove them to see if this fixes the issue

On Datadog's iOS SDK side, we are going decouple the first party hosts and the swizzling some time in the future, which should enable you to specify firstPartyHosts once again if that was the cause of the issue

Maybe look for a way to prevent the Sentry SDK from being initialized again when the packager reloads
Finally, it may be worth to open an issue on Sentry's repo as well so they can look if they can also help preventing the crash

Tell me if that makes sense, and if any of the suggestions worked!

Hi,
We're aiming to release the new RC before the end of next week, it will contain the fixes for actions, views and traces not being sent right after a reload.
As for the initial issue, it looks like it is fixed on newer versions of Sentry (see the sentry issue thread) :)
I've tested it to integrate both Sentry and Datadog and didn't have any crash on reload, let me know if that works for you as well :)

Hey @louiszawadzki,
After updating "@sentry/react-native" -> "3.4.3", the crash went away. So it is all fine and good now. Thanks!

Hi @tux4 @milkman4,
We've just released a new version which will ensure that actions, views and traces are being sent after a reload :)


[DO NOT MERGE] Recovery services site recovery - sdk for net - for new API version 2021-02-10

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/13525
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[x] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged?

@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged?

@nilgupta6 can we open this as a draft PR if its not intended to be reviewed / merged?

@m-nash : We want it to be reviewed but we will merge it once our swagger PR is merged.
Can you please review it.

@m-nash
Can you please start reviewing it.
our swagger is approved (https://github.com/Azure/azure-rest-api-specs/pull/13525). We are waiting for service release to merge swagger PR.
We will run generate.ps1 after swagger PR merge is done. Please start review meanwhile.

@m-nash / @allenjzhang
Can you please review / approve this.
This is time critical for us. We have to push powershell PR by friday.

See verification discrepancies. https://dev.azure.com/azure-sdk/public/_build/results?buildId=854383&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=50b9345f-2a7f-5980-cb0f-1a8f9fb09dd0&l=190

See verification discrepancies. https://dev.azure.com/azure-sdk/public/_build/results?buildId=854383&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=50b9345f-2a7f-5980-cb0f-1a8f9fb09dd0&l=190

@allenjzhang
I have updated files. This should resolve verification discrepancies.
please review and merge if evrything is OK


Improvement suggestion: DNS over HTTPS

Hello,
First of all, thanks for your work on dns-proxy-server. You made there an amazing tool, which ease my work in many ways :)
I would like to suggest an improvement for it.
What do you think about the idea of implementing DNS over HTTPS protocol into dns-proxy-server?
Please have a look at: https://tools.ietf.org/html/rfc8484
I think it could greatly increase portability for dns-proxy-server and ease its configuration.
Especially on Windows system since browsers start to implement this feature.
This would be really useful when network configuration update is restricted on the system and only the browser configuration can be changed.
Let me know what you think.

@noglitchyo thanks for the suggestion
At the first place this idea looks great to me

I you have to study this feature to understand it's idea better
DPS DNS server is based on https://github.com/miekg/dns I will have to check if I would be able to use that or if I will have to implement the HTTP API
After all I will have to measure how big is the change to implement all this

Regards

@mageddo Thank you for your reply.

I will have to check if I would be able to use that or if I will have to implement the HTTP API

I made some research on the link to the repository you mentionned.
Seems that some attempts to implement DoH (client) in the library were made and then reverted:

https://github.com/miekg/dns/pull/649
https://github.com/miekg/dns/pull/651
https://github.com/miekg/dns/pull/671
https://github.com/miekg/dns/pull/800

semihalev/dns which is also based on miekg/dns actually made a DoH server implementation (if you want to have a look) and had to implement the HTTP API.

Is there any update?


SW-5728 Rename "community" to "social impact"

Change the name of the "community" score to "social impact." This requires a
corresponding client-side change to use the renamed value in the score category
enum.

#2216  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

https://github.com/terraware/terraware-web/pull/2925 is the client side of this.


⚠ ClamAV has degraded performance

In 4ed3ad3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in a168d94.


full  Libri-light dataset

Hello!
I was wondering if there was a way to train using Libri-light (with transcriptions) without having to completely
rewrite the data-loaders?
I have never use lhotse but see that does not seem to support custom datasets.

FYI
#87 and  https://github.com/lhotse-speech/lhotse/pull/1014

FYI
https://github.com/lifeiteng/vall-e/issues/87 and https://github.com/lhotse-speech/lhotse/pull/1014

Just to clarify, these do not give you transcriptions, right?


monasca-schema, Mysql and PostgresSQL changes

updated text columns' lengths
switched from enum to triggers in mysql schema
switched from mediumtext to longtext in mysql schema
optional task migration via ansible
default migration files for mysql due to schema changes
column types
triggers

Change-Id: Ib72a36492f555da6154de30c7f057dac238f82a1

I think we need to use reference tables instead of triggers to enforce integrity constraints. This is the usually preferred solution unless there is a compelling reason to do otherwise. In this case there does not seem to be a compelling reason to use triggers. Triggers have the following drawbacks:

They have to be hand-coded and maintained. This places the burden on the developers who are most likely going to get it wrong at some point doing development/maintenance.

They are more difficult to understand and it can become very difficult to follow the logic. They complicate things enormously if propagated to a certain extent.

They require developers to understand and use the 'trigger' language.

Reference tables on the other hand are easy to understand and maintain. They use the standard facilities of the database in a natural way. No coding is necessary to add values to the reference tables.
The existing monasca code should not need to be changed to use reference tables. The primary key values in the reference tables can be strings and a foreign key integrity constraint can be instantiated just using the values of the strings. No integer-to-string conversions should be necessary. This will be less efficient than using an integer as the primary key, but these tables are going to be so small, that it probably won't make any difference.

code rebased to github/master
added ref tables + migration script

The following two tables should be a single table.
alarm_action_state
alarm_state
We need to ensure that the values are always the same. Two independent tables would allow the values to diverge.
Please merge these table into a single table.

Please create a pull request for the hpcloud/monasca-ci repo. The new tables that have been added in MySQL need to be added in the  monasca-ci/tests/smoke/smoke2_configs.py.j2 file. Just add them to the mysql_schema array. This test is currently failing with this pull request.

@ddieterly, tables have been merged + migration script has been updated.

https://github.com/hpcloud-mon/monasca-ci/pull/5
added tables in monasca-ci

Nice :+1:


fix(invitations): Support multiple statuses

In this PR, we update the invitations to allow filtering by multiple statuses instead of just one, since we already support this in Backend API.

This is a breaking change. What version are we planning to release this in?

It’s for v2 only. AFAIK, we haven’t officially released v2 yet. Would this still be considered a breaking change?


chore(master): release 5.0.0

:robot: I have created a release beep boop
5.0.0 (2024-09-27)
⚠ BREAKING CHANGES

use Pydantic 2 and move records to use computed_fields

Features

include release please (248ffcd)
use Pydantic 2 and move records to use computed_fields (2181e9c)

Bug Fixes

fix some validation errors to be aligned to latest pydantic v2 (115ffa6)
set explicit stacklevel on warnings (e034663)
solve mypy errors (4ed35c4)
use POSIX timestamps for SSM cloud records (c1df014), closes #113

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v5.0.0
:sunflower:


docs(configuration): add more experiments' options

Add more experiments' options according to https://github.com/webpack/changelog-v5#experiments
closes: https://github.com/webpack/webpack.js.org/issues/3697

Thanks!


Media playback while downloading

At the moment, when the media player loads a file that hasn't completely downloaded yet, it plays up to the point when the incomplete file was loaded. In some cases, this leads to a loss of audio during video playback, and then the video eventually stops shortly after that. When playing audio, the playback gets interrupted and the player doesn't do anything afterwards.
We need to find a way to allow the media player to continuously load the file until the download is completed.
I have been exploring options for this and one of the suggestions I've found is to set up a local stream server on the device which will only be used for files which have not been completely downloaded. This may ultimately be the solution if there is no way to enable the underlying media player (ExoPlayer) to progressively play an incomplete file until it is completed.

More research should be done into possible solutions before doubling down on the existing one.

Fixed.


customizing color and logos

I am new to Typst, and one of the reasons I started using it is because of this amazing template. I have a question regarding the customization of the template. I see that it's possible to add a logo and secondary color, but is there any reason why this option is not available for the rest of the logos and colors in the template? Is it possible for me to customize the logos and colors in my document without modifying the original template?

Hi there,
Thanks for your kind words 😄.
You cannot change the logos or colours without changing the original template. This might be a feature I will implement in the future, but this template is mainly focused on FHICT use so it will not happen soon.


Key Vault Parameters

Type of PR

[ ] Documentation changes
[X] Code changes
[ ] Test changes
[ ] CI-CD changes
[ ] GitHub Template changes

Purpose of PR

add --kvname and --authtype env var and cmd line params

Issues Closed or Referenced

Closes #58

Two things I noticed:

Need to update the readme with new CLI/environment variable instructions
I didn't see where (per https://github.com/retaildevcrews/helium-csharp/issues/58), unused/unexpected args result in an error.


Don't talk to the serial port after close (fix #910)

I was able to reproduce this on an RPi.   I think it's because some of my calculation phases in my test project are computationally intensive so parts of the shutdown are delayed.
Luckily, the fix is really not a big deal.

I get the point but feel like this will be a performance detriment since it has a check on every call to write.

A single None check?!  Each time you call a method, it costs probably 10x that.

Just being OCD :P Was just making sure... I get twitchy around serial
changes. This needs to be heavily tested.
On Wed, Aug 8, 2018 at 9:54 AM Tom Swirly<EMAIL_ADDRESS>wrote:

A single None check?! Each time you call a method, it costs probably 10x
that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411413948,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6o9xuLvMNUCeK7x9-Pvu--h0eXEcks5uOu2ygaJpZM4Vz8zl
.

I tested it here with actual serial ports.
:-D
Before we release, I'm going to run all the release_tests of course...
On Wed, Aug 8, 2018 at 3:57 PM Adam Haile<EMAIL_ADDRESS>wrote:

Just being OCD :P Was just making sure... I get twitchy around serial
changes. This needs to be heavily tested.
On Wed, Aug 8, 2018 at 9:54 AM Tom Swirly<EMAIL_ADDRESS>wrote:

A single None check?! Each time you call a method, it costs probably 10x
that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411413948
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA6a6o9xuLvMNUCeK7x9-Pvu--h0eXEcks5uOu2ygaJpZM4Vz8zl
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411414648,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPdstqyhyb6-1p_rRoVPBEtck14E3Dkks5uOu4sgaJpZM4Vz8zl
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com

So the test rig came in handy? :P
+1
On Wed, Aug 8, 2018 at 10:10 AM Tom Swirly<EMAIL_ADDRESS>wrote:

I tested it here with actual serial ports.
:-D
Before we release, I'm going to run all the release_tests of course...
On Wed, Aug 8, 2018 at 3:57 PM Adam Haile<EMAIL_ADDRESS>wrote:

Just being OCD :P Was just making sure... I get twitchy around serial
changes. This needs to be heavily tested.
On Wed, Aug 8, 2018 at 9:54 AM Tom Swirly<EMAIL_ADDRESS>wrote:

A single None check?! Each time you call a method, it costs probably
10x
that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<

https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411413948

,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AA6a6o9xuLvMNUCeK7x9-Pvu--h0eXEcks5uOu2ygaJpZM4Vz8zl

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411414648
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAPdstqyhyb6-1p_rRoVPBEtck14E3Dkks5uOu4sgaJpZM4Vz8zl
.

--
/t
https://tom.ritchford.com https://tom.ritchford.com
https://tom.swirly.com https://tom.swirly.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411419439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6hol4uauGBessoJmTFRONm30AjMqks5uOvFkgaJpZM4Vz8zl
.

Paranoia is your job!  :-D
I sleep with the test rig.  Well, I don't, but I do use it to test serial changes.

Awesome. Glad it's useful :)
On Wed, Aug 8, 2018 at 10:30 AM Tom Swirly<EMAIL_ADDRESS>wrote:

Paranoia is your job! :-D
I sleep with the test rig. Well, I don't, but I do use it to test serial
changes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/912#issuecomment-411426438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6pyoWQ-0abzoKveuTWKPsgCcKqgQks5uOvX-gaJpZM4Vz8zl
.


Revert "chore(deps): update sigstore/cosign-installer action to v3 (v1.13)"

This broke v1.13 in the branch https://github.com/cilium/cilium/pull/26422, reverting...
Reverts cilium/cilium#26441

/test-backport-1.13

Sadly we have to push the button to get this one in; merging.


Combinations without using factorials-Python

Signed-off-by: Muhammad Arslan<EMAIL_ADDRESS>

It's ready...


Fix dashboard data processing

Fixes #423
Solutions:

Fixed pandas.DataFrame.to_dict("records")
Updated column names to reflect data in https://github.com/mlco2/codecarbon/blob/master/codecarbon/data/private_infra/global_energy_mix.json
Added unit tests to catch these tyupe of issues in the future
Extracted some manipulation in get_country_choropleth_data to make it easier to test

Please let me know if this is something you are interested in, and if I can improve this PR in any way :)

Thanks, while testing your PR, I find other bugs :

per_capita_electricity is not in TWh, it is in Wh
per_capita_electricity is used in total_TWh computation, so it get it completely wrong, so the percentage was wrong in the end.
total_TWh also use *_Twh, but there are already other aggregates.
Errors in emissions.csv  : azure and aws do not provide carbon intensity of their cloud.

I've pushed all these fixes, could you test it on your side ?

Let me know what do you think. I am happy to make the fixes in the PR or in separate PRs, depends of what you prefer.

You could do everything in this PR. Thanks a lot !

Hi @benoit-cty , sorry for the delay! This should be ready now. Let me know if there is somenthing else I should change :)


Microsoft.Web - Add snapshots, deleted apps, app recovery

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

There will be some validation errors / warnings that are expected. Please refer to another currently open pull request for this spec at https://github.com/Azure/azure-rest-api-specs/pull/1551 for a discussion of those errors.

I'm reviewing this today.

@Nking92 I see a bunch of removals which looks like breaking changes. This would need a new api-version. Plus, you cant stop supporting GA APIs without any deprecation notice to customers.

Outside of our swagger specs this feature is unannounced and not GA. The old version of this API will no longer work. I can still create a new API version if we need to.

@Nking92, Please note that there are SDK that are released on top of these swaggers and removing this operation breaks customers that have already built dependency on them
The swagger has to represent the Status of the API. if you swaggers are representing preview feature then add a -preview flag to the version folder of your swagger

What are the next steps here, will a new API version be created and the existing functionality be preserved?

The backend for the old API has been completely gutted from our production service since it had many crucial design flaws. I'm not worried about breaking customers who took a dependency on this particular feature, because the old API no longer works. Moving forward I'd prefer to completely revise our old API instead of creating a new API version, if that's acceptable.

@Nking92 - So there are APIs being removed in DeletedWebApps.json file which, from what I understand, are not supported on the service side. These are non-GA APIs and so the customer impact should be minimal. I checked the traffic and there is no external traffic in the last 45 days. So we should be ok in removing the API in this file. Correct me if I am wrong on this.
Now, there are more changes in the other files which relates to adding new properties/models. What are these about and shouldnt those result in a new API-version?

@ravbhatnagar Here are some of the technical details behind the change
The recovery API was changed to use a long-running operation pattern that is compliant with ARM. In the past it returned HTTP 200 with an operation ID packed into the response body. Now it returns HTTP 202 with the operation resource in the location header. This is a breaking change, but this particular API has only been intended for internal use until we announce the feature is ready for preview.
A few additional fields were added into the objects used to create website recovery requests. Those should not be breaking changes.

It looks like some of the new properties being added are required which would be a breaking change yes?

I agree that those would technically be breaking changes, however in the interest of getting the feature ready for an upcoming deadline, it would be helpful to not create a new API version. I checked ARM logs and only found 2 instances of this API being called externally, with both calls failing. I feel that it's safe to assume we won't be breaking any customer code with this change.
Additionally, this version of the spec will be what I use to create the .NET SDK and Powershell commands for the feature. Since the feature hasn't been surfaced in any way except for the prior spec, I don't feel much risk in breaking customer code with this update. However if we decide that it's too risky to make this change as it is, I can do my best to update with a new API version.

@Nking92 I think this sounds reasonable given the ARM metrics.  Thanks for bearing with us.

 https://github.com/Azure/azure-sdk-for-python/pull/1402

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-ruby/pull/939


Classic typography vs. true classic

Greetings, I am just now upgrading from about a year of non-upgrades. I really like the work that has been done.
I just notice one little thing which does not seem to be consistent with #289 :
There is an option for typography: "default", "classic", "playfair".
I notice that when "classic" is chosen that the sub-title of sections on the main page appear in a serif-ed font. It use to be a san-sarif font. The same as the section title, but just a little smaller in size. It would be nice to have the san-sarif option back.
New

Old

Since the previous version of Academic that you were using, a theme system was introduced. The theme system standardises the style in this way so that different font and color themes can be easily applied.
You can customize fonts or override the subtitle font using custom CSS if you wish. Please use the discussion forum for any further support.

I think your missing what I'm saying... I'm not asking for support on this issue. I'm reporting a bug. It looks like per #289 that the objective with the classic style was to replicate this theme's typographical choice. This part was missed, and therefore seems to be a bug.


BRuh

make it loop and not exit on error, plus make it convert all text to lowercase to avoid case sensitivity, deafualt 16 doesnt work, so make it work

wha?

i made this so long ago i dont remember


multiple annotation channels

hello,
i am trying to write the classifications of two different technicians into one edf file and i need to write both classifications seperate annotation channels.
is pyedflib/edfplus support the multiple annotations channel and how can i write two different classification seperate channel?

Does EDF+ allow multiple channels?
The EDF+ specs refer to a single annotations signal in 2.2.1. The 'EDF Annotations' signal:

This signal is identified by giving it (in the EDF+ header) the label 'EDF Annotations'.

You may add a prefix to each annotation, to distinguish between technicians:

tech1: here is an annotation
tech2: another annotation

I don't think there is a way to add a second annotation channel without violating the EDF specifications (correct me if I'm wrong!). So this can only be solved by manually using some char in front of the annotation.


[Issue] When using the command "open link under cursor in new hover editor" my cursor doesnt move to the new hover editor

Video

https://github.com/nothingislost/obsidian-hover-editor/assets/121588624/65dcbac2-f87e-4344-b19e-8dca1d7b914d

In your "Editor" settings in Obsidian, what do you have set as the "Default view for new tabs"?
Also, can you reproduce this issue in the sandbox vault with only Hover Editor enabled?  I'm currently not able to reproduce this problem at all.  I can get it to open in reading mode or editing mode, and if it opens in editing mode the cursor appears and is focused.

Ive just disable every Plugin except Hover Editor and then reanabled some, to find out which causese the Problem. Its make.md. Ive then disabled all internal settings of make.md but it sitill doesnt work. My resoultion is now to disable make.md. It is a common "bug" that is known under the make.md community. (it is documented from the author itself on the make.md discord under  the channel improvement)


Check min profit percent was changed, cancel cancel order if profit percent is changed

https://github.com/AndreyMashukov/go-crypto-bot/blob/5c55cde5ab1f11e0cca92551ec60dd87803f9559/src/service/exchange/order_executor.go#L715

In issue #7 we implemented dynamic min profit, but we allow system to keep previously posted order alive until profit is positive, we have to cancel new not filled orders when min profit percent has changed and post new one with new calculated price

https://github.com/AndreyMashukov/go-crypto-bot/blob/5c55cde5ab1f11e0cca92551ec60dd87803f9559/src/service/exchange/order_executor.go#L550
Refactoring is required and unit tests


adding custom-columns examples

Adding examples of using -o=custom-columns= output with Kubectl to the frequently used KubectlCcheatsheet.
The biggest one I could not find an example for was finding all images running in a cluster: kubectl get pods -A -o=custom-columns='DATA:spec.containers[*].image'

/lgtm

/approve


wth

why the hell you've got a shortcut link to take me to yt google or fb whene I right click in the exsample website?

actual I like it even when its random, leave it there, I might copy the right click functionality from that website if you dont mind

bye


Improve Content API and etc.

Some features are not implemented correctly:

CaptainChar: implemented as ComponentModBase, so you can't change the appearance of the chair.  (Suggestion: implement how TurretMod is implemented)
For some components, not all method overloads work due to missing patches.

Suggestions for new content features:

QuestAPI or MissionsAPI.
ShopAPI (for exampel: IShopItem interface; implements a method similar to "OnNewShopCreated(Shop shop, Sector sector)" that allows you to manually add items to the shop.  Or add a spawn chance property and store type to the interface.)
DialogAPI for ships
DialogAPI for pawns
CreaturesAPI (maybe, if possible)
Pawn Appearance API

Other Suggestions:

Fix-patch for one bool method in SteamVR api (Creates boolean (false) many times if you don't have VR.  For 1 hour of play, it creates them for 1 gigabyte +_+) (Solution: prefix override patch with "return false")
Move the start PML method to Awake and add an attribute to it that will tell Unity that this Awake should be called first.

We can also add base classes for new items:
Melee Item click
And add fix patch for prefabcache click. We can create photonview objects on the client by adding it to the PrefabCache, but sometimes the client gets an error +_+. This patch fixes the bug.


Avoid exception if lhs of path expression returns NullNode rather than null

If the object being evaluated does not include the lhs portion of a path, the test was only if lhs == null but when a NullNode is returned this failed causing an exception. Added test || lhs.isNull() to avoid the exception.

Updated to version 1.0.3


[WIP] ci: cross-compile container images

It builds, but someone would need to test that it all works on ARM64
make-containers.sh has been removed as --platform can take a comma-separated list, thus podman build command can simply live in the Makefile
Closes #460

:thinking:
 exec container process `/bin/sh`: Exec format error

It works on my machine with Podman 4.1.0 :disappointed:
GitHub Actions runners have 3.4.2, I'll investigate

>60 min :arrow_right: <10 min!
I have decided not to spend time troubleshooting Podman, and use Docker Buildx instead.
Don't get me wrong I love podman, but it is not as mature as we would need it to be yet, there are lot changes in every releases, we can try podman again after some time (I have left make container in the Makefile).
Buildx also supports gh actions cache which will speed up builds further. With podman, it is not the case yet
Let me know if that works for you

We need to check if this is possible with buildx now. We make sure we haven't broken the reproducibility.

Ah yes, the timestamp! I thought about it, then it slip my mind :see_no_evil: still not possible :disappointed:
Oh well, build outside the container, it is going to be. Since its all static now, do we want standalone binaries while we are at it?

Since its all static now, do we want standalone binaries while we are at it?

What exactly mean by this? We have standalone binaries attached to the releases. Thanks to Goreleaser :)

We have standalone binaries attached to the releases.

Ah I had not seen it :+1:, amd64 only tho

For the PR to work as is, we would need Podman v4.1.0+:

stage_executor: Add support for inline FROM --platform= within Containerfile/Dockerfile

https://github.com/containers/buildah/releases/tag/v1.24.1

We have standalone binaries attached to the releases.

Ah I had not seen it +1, amd64 only tho

With the next major release, we will be having ARM binaries as well.

I thought I could fix it at least while you finish with #517, but this is doomed :weary:
With the Podman container image (so close! :angry:):
--> e7af32eb4dd
[linux/amd64] [3/3] STEP 3/3: CMD ["/bin/parca-agent"]
[linux/amd64] [3/3] COMMIT ghcr.io/parca-dev/parca-agent:refs-pull-486-merge-62e922b2
--> f734f6e2bfe
Successfully tagged ghcr.io/parca-dev/parca-agent:refs-pull-486-merge-62e922b2
panic: assignment to entry in nil map
goroutine 18888 [running]:
github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah.(*Executor).buildStage(0xc000171500, 0x558133cfd720, 0xc0002e7650, 0x0, 0xc00022b860, 0x3, 0x4, 0x1, 0xc0010ba000, 0x8000, ...)
	/usr/src/packages/BUILD/src/github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah/executor.go:475 +0x256
github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah.(*Executor).Build.func3.1(0xc000171500, 0xc000396ab0, 0x558133cfd720, 0xc0002e7650, 0xc000516a50, 0xc00022b860, 0x3, 0x4, 0x1, 0xc000314a80)
	/usr/src/packages/BUILD/src/github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah/executor.go:659 +0x108
created by github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah.(*Executor).Build.func3
	/usr/src/packages/BUILD/src/github.com/containers/podman/vendor/github.com/containers/buildah/imagebuildah/executor.go:656 +0xbe

With the Podman 4 Debian package (and Ubuntu 22.05):
--> f47439ec0bb
[linux/amd64] [1/3] STEP 3/21: RUN printf 'deb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-updates main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-backports main\ndeb http://snapshot.debian.org/archive/debian-security/20220420T025302Z bullseye-security main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z sid main\n' > /etc/apt/sources.list
error running container: error from /usr/bin/crun creating container for [/bin/sh -c printf 'deb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-updates main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-backports main\ndeb http://snapshot.debian.org/archive/debian-security/20220420T025302Z bullseye-security main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z sid main\n' > /etc/apt/sources.list]: sd-bus call: Permission denied
: exit status 1
time="2022-07-06T06:09:34Z" level=error msg="did not get container create message from subprocess: EOF"
Error: 2 errors occurred:
	* error building at STEP "RUN printf 'deb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-updates main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-backports main\ndeb http://snapshot.debian.org/archive/debian-security/20220420T025302Z bullseye-security main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z sid main\n' > /etc/apt/sources.list": error while running runtime: exit status 1
	* error building at STEP "RUN printf 'deb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-updates main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z bullseye-backports main\ndeb http://snapshot.debian.org/archive/debian-security/20220420T025302Z bullseye-security main\ndeb http://snapshot.debian.org/archive/debian/20220420T025302Z sid main\n' > /etc/apt/sources.list": error while running runtime: exit status 1
time="2022-07-06T06:09:36Z" level=warning msg="Failed to add pause process to systemd sandbox cgroup: exec: \"dbus-launch\": executable file not found in $PATH"

Podman 4 seems to be working now (I had configured the container at the wrong spot facepalm)
But go build fails for arm64 without explanation:
...
github.com/prometheus/prometheus/tsdb/tsdbutil
github.com/prometheus/prometheus/storage
github.com/prometheus/prometheus/promql/parser
make: *** [Makefile:88: dist/parca-agent] Error 1
Error: error building at STEP "RUN export CC='clang';     case "${TARGETARCH}" in       amd64)         export CPPFLAGS='--target=x86_64-pc-linux-gnu --sysroot=/usr/x86_64-linux-gnu -I/usr/include/x86_64-linux-gnu -I/usr/include';         ;;       arm64)         export CPPFLAGS='--target=aarch64-pc-linux-gnu --sysroot=/usr/aarch64-linux-gnu -I/usr/include/aarch64-linux-gnu -I/usr/include';         ;;       *)         export CPPFLAGS="--target=${TARGETARCH}-pc-linux-gnu --sysroot=/usr/${TARGETARCH}-linux-gnu -I/usr/include/${TARGETARCH}-linux-gnu -I/usr/include";         ;;     esac;     make build": error while running runtime: exit status 2

It took some time to figure out why things fail. It should be fixed with #517

Closing for the sake of #517
Changes moved from this PR in https://github.com/parca-dev/parca-agent/pull/517/commits/cf011c0854c27fdd61e77a6b5ac37d09b09fc688


Parse error in Laravel 5.7

ErrorException message:
syntax error, unexpected 'img' (T_STRING), expecting ',' or ')'
The line on the Blade file:

The line on the parsed file:

    ">

Already tried after running:
php artisan view:clear
php artisan cache:clear

PHP version: 7.1.3

    ">

works fine for me

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? We'll help you out and re-open this issue if so.
Thanks!


Fails to start on Fedora 29

Checklist:

[X] I have checked that there are no issues with similar or the same content
YOU SHOULD CHECK CLOSED ISSUES ASWELL

[X] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[X] I have double checked and can reproduce the issue

GPMDP fails to start on Latest Fedora 29. Seems to be a segfault complaining that package isn't signed with the proper key. See the attached output of journalctl.
OS:
Fedora 29 64-bit
Kernel : 4.18.16-300.fc29.x86_64
GPMDP Version:
4.6.1.x86_64.rpm
Issue Descriptions:
Installed ok using terminal, but application will not start.  I greped thru the journalctl file and found reference to the application not being signed with the proper key. I'm unable to start the app in order to generate the debug zip log as per FAQ instructions.
Steps to Reproduce:
On a Fedora 29 64-bit system with kernel 4.18.16-300.fc29:

download google-play-music-desktop-player-4.6.1.x86_64.rpm.
in terminal run: sudo dnf localinstall google-play-music-desktop-player-4.6.1.x86_64.rpm
Try to open th application using the Gnome Application menu
in terminal run: journalctl -b | grep 'google-play-mus' to find the resulting error messages attached here: gpmdp_journalctl.log

Hopefully, I provided all the relevant info y'all need. Great work on the app guys! Let me know what else I can provide to help this issue along.

I have checked that there are no issues with similar or the same content

GitHub has a wonderful new feature to help prevent you making duplicate issues 😄

Duplicate of #3408

Hi @MarshallOfSound, thanks for the reply.
I did do a search and read through those issues. I created a new one because the cause of the segfault error (complaining that package isn't signed with the proper key) appears to be a new problem not previously mentioned in the other bug reports. Perhaps I was not as clear in my wording, sorry for that.

@SpacemanPete i fixed this already --- it was present in my ubuntu 18.10 installation but the same fix should fix the segfault in fedora 29. https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3413


[PolicyRecordingBot] Recording bot Doesn't seem to be working anymore.  Was there any changes on this functionality or on teams server?

PolicyRecordingBot doesn't seem to be working anymore, though deployed app is report as running ok on the cloud.  Call always shows "Forwarding to voicemail" message then immediately Leaves the Call.
This was working fine from last week.  I haven't made significant changes on my code but its not working anymore after deployment to the cloud, even reverting those changes does nothing.
I tried to deploy the original code from this repo [PolicyRecordingBot] with just those changes required on the settings, and its not working as well.  :-(
Are there any changes/updates made on this project that are not yet pushed to fix this?  Or maybe changes made on the server (Call/Media session) that we do know of broke the functionality of the project?
Please advice.
Thank you.

A moment ago, I deleted the bot channel registration and app registration and started fresh. Without changing the actual code, I just got it working for the first time. Previously, I couldn't even get packets into the webhook link https://mydomain.com/api/calling. Not exactly sure if it's that issue for you but that's what I had been going through.

hmm... checked that already and also followed the execution of powershell scripts for creation of application instance, creation and assignment of policy, but call still not connecting.
I'm on a new tenant now and on the previous tenant I was working on, it was working fine, following the steps/guide from the readme of the project.  Now on this new tenant, its not working.  I'm still finding out what I'm missing out and did wrong. :-(

ok found the issue.  the domain name was pointing on different server.


muzero_policy search vs gumbel_muzero_policy search performance

I've seen others reporting that the muzero_policy is slow and I've run into this problem myself so I wanted to add a bit more information. I'm not expecting a solution to this problem, but it might be interesting for the authors to better understand this problem.
muzero_policy is drastically slower than gumbel_muzero_policy, and the problem stems from the body_fun in search.py. I'm not able to identify the exact LOC, but the execution halts to almost a complete stop in this loop. When executing on CPU I see very strange behavior where the first N calls to muzero_policy execute lightning fast, only to come to a complete stop at iteration N+1, taking minutes to complete a search with only 100 simulations. The batch size seems to affect when this halt occurs.
I wish my solution to this problem was as easy as switching to gumbel_muzero_policy but I'm working with stochastic nodes, and we've observed significantly worse performance from gumbel in this setting

I've identified the root selection function as the culprit. Switching out the muzero's root selection function to gumbel's root selection policy incurs a ~100x speedup in my case.


Inconsistency iOS & Android (All in one)

AlphaWallet/alpha-wallet-android#969

https://github.com/AlphaWallet/alpha-wallet-android/issues/971

https://github.com/AlphaWallet/alpha-wallet-ios/issues/1552


master/seed mla stack requires port numberts for scraping

This changes the annotations to use port number, so that prometheus can scrape the targets.
This means that port number has to be managed in multiple places, unfortunately, but this is a temporary solution.

/lgtm
/approve

/hold

/lgtm

This is already overriden in config/cortex/values.yaml


[IBCDPE-459] Implement command-line interface (CLI) for dcqc

Alright, this is the "goal PR" for IBCDPE-448, although I've tagged the PR using the relevant subtask.
In this PR, I'm using typer to build a CLI that is roughly equivalent to the one I created for the proof of concept script. I think it went really well! It's also easy to test typer commands.
Each command is document, so it should be self-explanatory. I also included some sample input/output files in the tests/data/ directory to (1) demonstrate what they look like and (2) for testing purposes.
Depends on #8

Codecov Report

:exclamation: No coverage uploaded for pull request base (bgrande/IBCDPE-458/improve-apis-for-cli@8d2d67a). Click here to learn what that means.
The diff coverage is n/a.

@@                            Coverage Diff                             @@
##             bgrande/IBCDPE-458/improve-apis-for-cli       #9   +/-   ##
==========================================================================
  Coverage                                           ?   95.16%
==========================================================================
  Files                                              ?       16
  Lines                                              ?     1200
  Branches                                           ?      159
==========================================================================
  Hits                                               ?     1142
  Misses                                             ?       41
  Partials                                           ?       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The primary use case for these CLI commands is the Nextflow workflow, which requires smaller steps to enable parallelism. Once we have a use case for using dcqc directly (i.e. outside of Nextflow)—which I expect to surface eventually—I can implement a high-level CLI that's user-friendly and document it in the README. I captured this plan in the README.

The create-suite and combine-suites also create parent folders thanks to the _create_parent_directories() method in the JsonReport class, which uses URLs instead of Paths. I'm unhappy with the inconsistency between paths and URLs. I plan on resolving that discrepancy in a future iteration with either a mixin or an abstraction (e.g. a URL class).

Oups, I forgot to commit the change. Done! Merging now.


Resolution causes cjs file to be imported even though js file exists

I am not sure if this is to be expected, but I am seeing this behaviour in the following reproduction.
Behaviour

<EMAIL_ADDRESS>(see .cjs extension) is added to the scopes
This code doesn't run properly
It seems to be due to the resolution

Expected

<EMAIL_ADDRESS>is added to the scopes instead

import { Generator } from "@jspm/generator"

const generator = new Generator({
  mapUrl: "about:blank",
  inputMap: undefined,

  env: ["production", "browser", "module"],
  resolutions: { "chart.js": "^4.4.0" },
  defaultProvider: "jspm.io",
  fetchRetries: 10,
})

await generator.install([
  "react-chartjs-2",
  "chart.js",
  "chartjs-plugin-colorschemes",
])

console.log(generator.getMap())

{
  imports: {
    'chart.js'<EMAIL_ADDRESS>    'chartjs-plugin-colorschemes'<EMAIL_ADDRESS>    'react-chartjs-2'<EMAIL_ADDRESS>  },
  scopes: {
    'https://ga.jspm.io/': {
      '@kurkle/color': 'https://ga.jspm.io/npm<EMAIL_ADDRESS>      'chart.js'<EMAIL_ADDRESS>      react<EMAIL_ADDRESS>    },
<EMAIL_ADDRESS>{
      '@kurkle/color': 'https://ga.jspm.io/npm<EMAIL_ADDRESS>    }
  }
}

So this is correct resolution behaviour unfortunately - chart.js defines its package.json as:
  "exports": {
    ".": {
      "types": "./dist/types.d.ts",
      "import": "./dist/chart.js",
      "require": "./dist/chart.cjs"
    },
    "./auto": {
      "types": "./auto/auto.d.ts",
      "import": "./auto/auto.js",
      "require": "./auto/auto.cjs"
    },
    "./helpers": {
      "types": "./helpers/helpers.d.ts",
      "import": "./helpers/helpers.js",
      "require": "./helpers/helpers.cjs"
    }
  },

which means that when a CommonJS require loads chart.js, it will get dist/chart.cjs whereas an ES module willl get dist/chart.js instead.
That is, chart.js is badly defined and defines different versions for ESM and CJS and this is a bug in the package itself.
As for the interop issue - the chart.cjs module is actually correct, it's reading .defaults.global.plugins but in the latest version of ChartJS this is .defaults.plugins that is the global property of the defaults object no longer exists in the latest version. So the plugin is not compatible with this newer version of ChartJS as it needs to be updated to reference the .defaults.plugins object instead. This is not a JSPM interop issue either.
So both issues are package issues here unfortunately, and not JSPM issues.
For the first I would suggest to PR chart.js to avoid the dual package hazard by defining one main module.
And for the second I would suggest to use an updated version of the plugin that references .defaults.plugins.


yocto recipe

I would like to integrate the python endesive library into my yocto build. Is there a recipe for python3-endesive?

Everything needed in packages or installed with the pip command. I don't have a recipe for yocto


Clone Twitter Home page with Vue and Tailwind

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
Clone Twitter Home page with Vue and Tailwind
Introduction paragraph (2-3 paragraphs):
The tutorial will demonstrate the implementation of Twitter Home page UI using Vue with Tailwind CSS. The content will impart thorough knowledge on the implementation of each section of the Twitter Home page. The most essential thing is that the total implementation of UI in Vue Version 3. The detailed stepwise integration of how to integrate Tailwind CSS into the Vue project will also be shown. We will also be implementing a tweeting feature.
Key takeaways:

Basics of Vue Version 3
Basics of Tailwind CSS
Integration of Tailwind CSS in Vue project
Using Tailwind CSS to implement Twitter Home page UI

References:
https://v3.vuejs.org/
https://tailwindcss.com
https://tailwindcss.com/docs/guides/vue-3-vite
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

good topic - approved @Worawat101

merged


virtualbox client is broken

Needed for this issue https://github.com/threefoldtech/home/issues/635

It's because virtualbox is not installed
install on linux using
sudo add-apt-repository multiverse && sudo apt-get update
sudo apt install virtualbox
virtualbox

perhaps an install method?

@rkhamis this client is for the insystem only. and may some os like windows or make don't support cli installation ?

no no. you're right.

when try to install jsx in host ubuntu it fail as below
root@jsxbishoy:~# ./3sdk_v10.5.3_linux_x86_64 --expert
3sdk> install
..........
python3-pip is already the newest version (9.0.1-2.3~ubuntu<IP_ADDRESS>).
The following packages were automatically installed and are no longer required:
  bridge-utils grub-pc-bin libdumbnet1 ubuntu-fan
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Requirement already satisfied: pudb in /usr/local/lib/python3.6/dist-packages
Requirement already satisfied: pygments>=1.0 in /usr/local/lib/python3.6/dist-packages (from pudb)
Requirement already satisfied: urwid>=1.1.1 in /usr/local/lib/python3.6/dist-packages (from pudb)
OK
Traceback (most recent call last):
  File "/usr/bin/add-apt-repository", line 11, in <module>
    from softwareproperties.SoftwareProperties import SoftwareProperties, shortcut_handler
  File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 67, in <module>
    from gi.repository import Gio
  File "/usr/lib/python3/dist-packages/gi/__init__.py", line 42, in <module>
    from . import _gi
ImportError: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/_MEI5QOVEd/libgirepository-1.0.so.1)

Could not execute:    apt-get update
    apt-get upgrade -y --force-yes
    apt-get install sudo python3-pip  -y
    pip3 install pudb
    curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
    add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic stable"
    apt-get update
    sudo apt-get install docker-ce -y

3sdk>

note sure why jsx not install , is it need a ubuntu desktop ?

root@jsxbishoy:~# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.4 LTS"
root@jsxbishoy:~#

installer error should be in another issue however it is fixed here
https://github.com/threefoldtech/jumpscaleX_core/pull/864

verified
3BOTDEVEL:jsxbishoy:jumpscaleX_libs: git log -1
commit 7513ec400d0c60353486fc971880a9b81abb188a (HEAD -> master, tag: v10.5.3, origin/master)
Merge: 41a8062 6d75496
Author: Reem Khamis<EMAIL_ADDRESS>Date:   Thu May 14 16:54:24 2020 +0200

    Merge pull request #213 from threefoldtech/rc_10.5.3

    Fixes in zosv2 sal regarding gw


add search menus to inventory screens

maybe a duplicate of #6, feel free to close if so

implemented in 9033a0e


API: discussion about supported content-type

As of today, the only official spported content-type for api request is x-www-form-urlencoded.
The fact that some endpoint work when sending json is a side effect.
Some of our client will probably not have up to date SI and supporting x-www-form-urlencoded is the minimum we can do to help them.
So the question is should we support both json and form input data?

I think I agree more with this post stating the best practice should be to accept json in both request/response:

REST APIs should accept JSON for request payload and also send responses to JSON. JSON is the standard for transferring data. Almost every networked technology can use it: JavaScript has built-in methods to encode and decode JSON either through the Fetch API or another HTTP client. Server-side technologies have libraries that can decode JSON without doing much work.

In case a client has some issues with that, we can choose later how to solve the issue (for my knowledge anyway, which SI cannot send json content-types btw?)

also this way we would have a consistent content-type between request and response, since we send back json to the client side

I believe some old java 6 code base may have difficulties, on top of that if they are not used to it may cause friction. Supporting a list form really seems to be required, as I stated, the question is  should we support both json and form input data?

I agree with @MattiaPrimavera. Support only json and if we have some issues we'll see at this moment

I persist with the form content type. I will keep this as it works as of today and will need to support both in the future.

If you really want to stick with form type, we have to change the way of sending POST requests on the front-end side (doable as well)

you could keep it as it works currently knowing specific case for array.

Shouldn't you expect url encoded values if you accept x-www-form-urlencoded by the way ? You're currently expecting to receive a stringified version of participant addresses, not a urlencoded one. So I fixed the call by stringifying the destinations to send to the API (on client side), and it works by still using a json content-type: #361


What about the same Identifier URI for Azure AD?

I understand that we can set different Issuers for outgoing assertions to Azure AD, but when Azure AD makes a SAML request to ADFS, it uses the Issuer urn:federation:MicrosoftOnline. How do you modify this when trying to federate a single ADFS environment to multiple Azure AD tenants? Is there a way to specify in Azure AD, what the Relying Party identifier in ADFS will be? This identifier URI needs to be unique in ADFS, and because (from what I can tell) we can't edit this, federating a single ADFS to multiple Azure AD is not as straight forward as the article shows.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ff136fb-c076-b37a-9772-1c30a07fabec
Version Independent ID: ea5cf8c8-2ff3-7ebc-1c16-adc80912cb50
Content: Federating multiple Azure AD with single AD FS - Azure
Content Source: articles/active-directory/hybrid/how-to-connect-fed-single-adfs-multitenant-federation.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

Hey @shadewlkr thanks for your feedback! we're currently investigating the issue and will get back to you as soon as possible in regards to this.

Hey @shadewlkr can you please clarify what the issue is?
If you follow the steps below :
On the AD FS server, open Azure AD PowerShell (ensure that the MSOnline module is installed) and perform the following steps:

Connect to the Azure Active Directory that contains the domain contoso.com Connect-MsolService Update the federation settings for contoso.com Update-MsolFederatedDomain -DomainName contoso.com –SupportMultipleDomain

Issuer in the domain federation setting will be changed to "http://contoso.com/adfs/services/trust" and an issuance claim rule will be added for the Azure AD Relying Party Trust to issue the correct issuerId value based on the UPN suffix.

It should work properly. Are you saying after updating it to support multiple domains it still is not working properly?

Hello,
Sorry, no, I'm not talking about the issuer URI that gets sent in the outgoing assertion to Azure AD from ADFS.  The claim rule you indicated changes the Issuer value to the custom URI as you indicated.
I'm talking about the incoming SAML request from Azure AD to ADFS.  It contains an issuer of urn:federation:MicrosoftOnline (the Relying Party ID) before ADFS sends it's outgoing assertion.  I want to know if we can change this value when configuring the federation trust to an Azure AD tenant.  Since I can't find any documentation on how to change this, and it seems like this value is required to be the relying party ID and Audience value of the outgoing assertion, it has to be unique in ADFS and therefore I am seeing an issue when trying to federate to two Azure AD tenants from the same ADFS server.   The command you referenced actually fails because the relying party IDs (urn:federation:MicrosoftOnline) are the same.
Does that help clear things up?
Thanks!

From: Frank Hu<EMAIL_ADDRESS>Sent: Wednesday, November 6, 2019 9:24:11 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Zac Ambrosio<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] What about the same Identifier URI for Azure AD? (#42127)
Hey @shadewlkrhttps://github.com/shadewlkr can you please clarify what the issue is?
If you follow the steps below :
On the AD FS server, open Azure AD PowerShell (ensure that the MSOnline module is installed) and perform the following steps:
Connect to the Azure Active Directory that contains the domain contoso.com Connect-MsolService Update the federation settings for contoso.com Update-MsolFederatedDomain -DomainName contoso.com –SupportMultipleDomain
Issuer in the domain federation setting will be changed to "http://contoso.com/adfs/services/trust" and an issuance claim rule will be added for the Azure AD Relying Party Trust to issue the correct issuerId value based on the UPN suffix.
It should work properly. Are you saying after updating it to support multiple domains it still is not working properly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/42127?email_source=notifications&email_token=AEZ5ET2VHXZHWE6N4TZQVPTQSN34XA5CNFSM4JJD64R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDIVRWY#issuecomment-550590683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEZ5ET34YCLCBC4A2H33A7TQSN34XANCNFSM4JJD64RQ.

hey @shadewlkr thanks for clearing it up, I'm going to take a deeper look into this and reply back as soon as possible, thanks!

hey @shadewlkr I'm following up in regards to this issue. I see that this issue was resolved and answered here : https://github.com/MicrosoftDocs/azure-docs/issues/42126
do you have anymore questions in regards to this?
Or would it be fine to go ahead and close out this issue as a duplicate.

Hey @shadewlkr can you please respond in regards to the last message? If there's no response by end of day tomorrow I will be closing out this issue.


Is there a way to download images of size greater than 256x256 and better clarity using label-maker?

@PallawiSinghal right now the 256 value is (unfortunately) hard coded a few places throughout the library. So it doesn't support that without modifying the code directly but I'd be happy for a PR in this direction


Merge 'pre-release', 'release', and 'Compile' Workflows into one workflow - Fixes 'Release WinUtil' Workflow & Removes 'winutil.ps1' From Git Tracking List

Type of Change

[ ] New feature
[x] Bug fix
[ ] Documentation update
[x] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description
~Copy-Pasted some things from 'pre-release' workflow, and learned a few things from it (like Environment Variables and how they're shared across steps in GitHub Actions), as well as make sure that both work as expected.~ Old PR Purpose
After a bit of tinkering here & there, I was able to get Input Workflow Working, you can now choose if you want to release WinUtil as a Stable Release or as a Pre-Release (default is Pre-Release).
Also there has been alot of changes to how WinUtil is deployed, which's converting from the old Test & Stable Git Branches with Direct Linking to winutil.ps1 file on GitHub, to a more Standardized Deployment System (Using GitHub Actions & GitHub Releases), Because of this.. the compiled file winutil.ps1 on the main branch will be removed, as it's no longer needed, it isn't referenced anymore, through the docs, project source code, nor through christitus.com/win web re-direct (it now redirects to a specific Release on GitHub (new method), rather than winutil.ps1 on main branch (old method)).
Testing
After alot testing, I got it working pretty well, I haven't noticed any issues in the logs, nor did I see any error in Release Title & Description.
One minor exception is when you Release twice in the same day.. the release body & generated notes of second run will be appended to the previous run.. which is something to look at (can be easily fixed by making append_body field equal false in the last step (the release step) of release.yml workflow, haven't changed it as I thought you want this behavior.. so I left it as is)
Impact
Will make it possible to use the 'Release WinUtil' Workflow, and it'll make other issues like Auto-Compile & Commit action less annoying on Forks (all workflows are enabled by default, and you'll need to disable it.. not very intuitive to be honest)
Additional Information

[!NOTE]
I'm still new to this GitHub Actions thing.. so if you notice anything odd, feel free to point it out, thanks in advance 👍

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

After further inspection of these two workflow files.. they're almost identical to one another, to the point where I'm questioning if there's a reason of having two workflow files instead of one (which has some input parameters, which'll allow you to make the release a Pre-release or a Full Stable Release), screenshot proving my point.

@ChrisTitusTech @Real-MullaC @MyDrift-user @Marterich @CodingWonders and anyone who's interested on these changes, especially the removal of winutil.ps1 from Git Tracking List.
First, my bad for pinging you guys, I just wanted to inform the most active contributors about this, as it's a step I believe is necessary, which's updating your Local Git Cache, you can do this by running two commands:
cd Path/To/Local/WinUtilRepo
git rm -r --cached .
git add .

First Command changes your working directory to be your Locally Cloned WinUtil Repo (the Path/To/Local/WinUtilRepo part).
The second is git rm -r --cached ., which'll remove every file from the current directory (which's WinUtil Root Directory) from Git Tracking Cache, this's needed whenever you updated .gitignore file, but the ignored folder(s)/file(s) are already tracked.. so you need to clear the cache.
You'll need to add every file, as git will see every single file as Un-tracked file (new files), so you need to tell it "Hay Git, please track these files" by running git add ., where . is WinUtil Root Directory.

I hope this helps out, and if you've any question about it, feel free to post it, and I'll reply when I can. Have a nice day 😄

Also @ChrisTitusTech , if you find any changes to be odd in these changes, feel free to change it by editing the file on GitHub, and committing it to my branch.

especially the removal of winutil.ps1 from the Git Tracking List

@og-mrk, every time winutil.ps1 appeared in the changes list, I would simply tell Git to assume that the file never changed with this command:
git update-index --assume-unchanged .\winutil.ps1
However, this seems like a more permanent solution

@og-mrk please keep in mind, that the pre-release script also used different tags (with the prefix pre-) this had a simple reason.
If Chris would create a full release in the morning and a pre-release later that day, the full release would be converted to a pre-release again (becaus the same tag was used)
Haven't checked out your code too closely, but do you handle the case, that a full release with the same tag already exists when a new pre-release is added so that the full release doesn't get overwritten?

@og-mrk please keep in mind, that the pre-release script also used different tags (with the prefix pre-) this had a simple reason.
If Chris would create a full release in the morning and a pre-release later that day, the full release would be converted to a pre-release again (becaus the same tag was used)
Haven't checked out your code too closely, but do you handle the case, that a full release with the same tag already exists when a new pre-release is added so that the full release doesn't get overwritten?

Will check this edge case today when I get home. Thanks for the feedback @Marterich 😄

As removing winutil.ps1 in this PR results in merge conflicts (meaning it can't be merged to main branch).. I'll make removal of this file in a separate PR entirely, where when every other PR is closed, it'll be the last one to be merged on the review batch.
 I don't want to have anything with the Compile and most time I will use the pre-release and change it to a full release after it has been tested.

I like having these job separated. I don't want to have anything with the Compile and most time I will use the pre-release and change it to a full release after it has been tested.

@ChrisTitusTech In that case, would it be an option to completely remove the full release action if it's not really used anyways?


count() method missing on Model

I'm using the count() method on a few of my models but it seems to be missing from the sequelize-mock API
See: http://docs.sequelizejs.com/class/lib/model.js~Model.html#static-method-count

If you're using jest:
let mockModel;
jest.doMock("path/to/model", () => {
  mockModel = dbConnectionMock.define("MyModel", myMockModel);

  mockModel.count = () => 1;

  return mockModel;
});

We are currently using sinon and we have the same problems as sinon does not allow to stub non-existent properties by design.
Does anyone know if Sequelize is planning to fix this in a timely manner ?
Btw same problem applies to other non-existing methods such as findByPk() which causes the same problem of count()

So findAndCount does exist.
mockModel.count = () => mockModel.findAndCount().then(res => res.count);

But this feels like something that should be added in.


isort formatting error

Unable to use isort extension. always facing the following error when reload the windows
Formatting error, please see Output > isort for more info: Traceback (most recent call last): File "c:\Users\user\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\format_server.py", line 140, in _run result = utils.run_module( File "c:\Users\user\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\utils.py", line 177, in run_module return _run_module(module, argv, use_stdin, source) File "c:\Users\user\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\utils.py", line 162, in _run_module runpy.run_module(module, run_name="__main__") File "C:\Users\user\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 212, in run_module return _run_code(code, {}, init_globals, run_name, mod_spec) File "C:\Users\user\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code exec(code, run_globals) File "c:\Users\user\.vscode\extensions\ms-python.isort-2022.1.112610...
Settings:
"[python]": {
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
      "source.organizeImports": true
    },
    "editor.defaultFormatter": "ms-python.python"
  },
  "isort.args": [
    "--profile",
    "black"
  ],

@sudheer82 Can you copy paste the contents of the Output> isort panel, the stack you have posted is incomplete, the output > python panel should have the complete stack? Please make sure that if you have isort installed in your environment it is >= 5.10.1. Run python -m pip list | findstr isort to get the isort version info from your environment.

isort is not listed in output panel to get the log.
One more observation is, i am using a custom python path/interpretor "python.defaultInterpreterPath": "C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python310\\python.exe", and in that i do not have isort lib. ie, python -m pip list | findstr isort returns nothing. is it required for the lib to be manually installed before using the extension ?

Hi Karthik,
here is the complete output of isort
Formatter Name: isort
Formatter Module: isort
CWD Format Server: c:\Users\<user>\
sys.path used to run Formatter:
    c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter
    C:\Users\<user>\AppData\Local\Programs\Python\Python310\python310.zip
    C:\Users\<user>\AppData\Local\Programs\Python\Python310\DLLs
    C:\Users\<user>\AppData\Local\Programs\Python\Python310\lib
    C:\Users\<user>\AppData\Local\Programs\Python\Python310
    C:\Users\<user>\AppData\Roaming\Python\Python310\site-packages
    C:\Users\<user>\AppData\Roaming\Python\Python310\site-packages\win32
    C:\Users\<user>\AppData\Roaming\Python\Python310\site-packages\win32\lib
    C:\Users\<user>\AppData\Roaming\Python\Python310\site-packages\Pythonwin
    C:\Users\<user>\AppData\Local\Programs\Python\Python310\lib\site-packages
    c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\libs

Settings used to run Formatter:
[
    {
        "workspace": "file:///c%3A/Users/<user>",
        "trace": "error",
        "args": [
            "--profile",
            "black"
        ],
        "severity": {},
        "path": [],
        "interpreter": [
            "C:\\Users\\<user>\\AppData\\Local\\Programs\\Python\\Python310\\python.exe"
        ]
    }
]

isort --profile black --check --filename Untitled-1.ipynb -
CWD Formatter: c:\Users\<user>
[Error - 11:26:29 AM] Traceback (most recent call last):
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\format_server.py", line 140, in _run
    result = utils.run_module(
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\utils.py", line 177, in run_module
    return _run_module(module, argv, use_stdin, source)
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\formatter\utils.py", line 162, in _run_module
    runpy.run_module(module, run_name="__main__")
  File "C:\Users\<user>\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 212, in run_module
    return _run_code(code, {}, init_globals, run_name, mod_spec)
  File "C:\Users\<user>\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\libs\isort\__main__.py", line 3, in <module>
    main()
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\libs\isort\main.py", line 1119, in main
    incorrectly_sorted = not api.check_stream(
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\libs\isort\api.py", line 264, in check_stream
    changed: bool = sort_stream(
  File "c:\Users\<user>\.vscode\extensions\ms-python.isort-2022.1.11261002\bundled\libs\isort\api.py", line 189, in sort_stream
    raise FileSkipSetting(content_source)
isort.exceptions.FileSkipSetting: Untitled-1.ipynb was skipped as it's listed in 'skip' setting or matches a glob in 'skip_glob' setting

Looks like instead of using the CLI, we should use the APIs available via isorts API module. This will allow us to skip the file check and get the sorted content. This is currently, occurring because isort does a file exists check on files which may not be on disk yet, because we are in the process of formatting before saving file to disk.

In this case, Untitled-1.ipynb is not applied for save or format. the issue generally occurs when the save or format is being performed on other files on disk while Untitled-1.ipynb is open in one of the tabs.

@sudheer82 We check all open files for import sorting issues. The underlying problem is the same, the file skip check in isort is to strict here, and causes this problem.

@sudheer82 We check all open files for import sorting issues. The underlying problem is the same, the file skip check in isort is to strict here, and causes this problem.

https://github.com/microsoft/vscode-isort/pull/44 should address this


Building a Request Helper (JSON Function)

In issue # 12 was requested to helpers path, I agreed and did it, after in issue # 13 was requested to do a helper for requests, I did Json helper first, because they are most common. Them we can use this method located at helpers / sendRequest.
In the method SendJSONRequest receives the PayGoRequest interface its has 3 methods GetUrl, that returns a url to send the request, GetJSON, returns to marshaled json to send and the treatment, theSetResponse treats the request response like you wants.

I believe that create an Interface for request/response with only one use case is overkill. I prefer start simple, using net/http inside the mercadopago package instead to create a interface that encapsulates the net/http

I submited a changes for your reviews, please check it.


docs: HAHAHUGOSHORTCODE link?

hey there! :heart: the project.
was reading the docs and there's an odd link on the middleware section, specifically: the Source Code bullet on the table of contents has a weird and broken URL.
i looked at the source in the docs folder but couldn't immediately figure it out - i think it's just a hugo reference issue, but not sure.

Probably some problem with template and Hugo (https://github.com/gohugoio/hugo/issues/6081)

note to self: check page https://echo.labstack.com/middleware/ and bottom of the page "Writing Custom Middleware"

+1 on this, was a bit thrown off as a new user trying to write some middleware. I don't know much about Hugo but I'll look into this if I have some time.


New Feature RandomAccess in streams

It would be very usefull random access (position) for compressed stream.

To support random access, somebody needs to manage offsets to compressed chunks. I guess this is out of scope of snappy-java in a sense providing snappy compressor, originally implemented in C++, to Java world.

Ok i m implementing on my own. Please i need just a info.
Snappy.compress(byte[40])
Snappy.compress(byte[60])
then i read
Snappy.uncompress(byte[50])
Snappy.compress(byte[50])
does it work? pratically the compression is invariant or it keeps a state about compression length so i need to uncompress
Snappy.uncompress(byte[40])
Snappy.compress(byte[60])
?

I'm not sure this is helpful or not, but for checking uncompressed data length, you can use:
https://oss.sonatype.org/service/local/repositories/releases/archive/org/xerial/snappy/snappy-java/<IP_ADDRESS>/snappy-java-<IP_ADDRESS>-javadoc.jar/!/org/xerial/snappy/Snappy.html#uncompressedLength-byte:A-

Yes for making it seekable ,might be not difficult. The difficult if I want also to add write method. Space compressed might be depending by content , so if write 10 bytes , and then I replace 10 bytes i thing space could be different


Have students more consistently submit arena code to ladder

This makes sure students, when finished with ladder code, submit it for ranking, and that it doesn't depend on courseInstances on the user being correct, which sometimes is not.
POST /queue/scoring:

Refactor, test
Accepts courseInstanceId to force adding to leagues
Does not automatically remove users from leagues or course instances

Other:

CourseVictoryModal submits ladder levels for ranking
Do not wrap findCurrentVersion for versioned mongoose model instances,
so calls can chain further query methods like lean
Catch ObjectId CastErrors on server and return 422, rather than 500

Coverage increased (+0.5%) to 56.102% when pulling d3c375b7472ae8cedb956d4a6e0769a1bf3d8c81 on fix-classroom-arenas into 47e149bf28eaef35b8147e9d6850ddba2e5d94bb on master.

Coverage increased (+0.5%) to 56.088% when pulling d8a1b502d831f810e33c8eb9f71570adcba0cdd5 on fix-classroom-arenas into 47e149bf28eaef35b8147e9d6850ddba2e5d94bb on master.


IndexError: index XX is out of bounds for axis 0 with size XX of scLVM/core.py

Hi,
the code around 204 line of scLVM/core.py :
if not _conv:
        var[count,-2] = SP.maximum(0,y.var()-tech_noise[ids])
        var[count,-1] = tech_noise[ids]
        count+=1;
        if self.geneID is not None:	geneID[count] = self.geneID[ids]
        continue

I think count+=1; should be put after if self.geneID is not None:	geneID[count] = self.geneID[ids]. Otherwise when I call the function varianceDecomposition() with i0 and i1 setting as, for example,  100 and 150, the  out of bounds error occur frequently if ids reach i1.
Also I don't know why do the assignment geneID[count] = self.geneID[ids]  only when _conv is False, rather than assigning the geneID for every ids.
Thanks!

good catch, thank you. fixed.


OpenTracing spring-cloud instrumentation

This is an umbrella issue to discuss an instrumentation for Spring Cloud supported frameworks.
Currently Spring Boot applications are traced using spring-cloud-sleuth, however this framework does not allow to use OpenTracing API. There are two options which could be done:

Reuse sleuth and create OpenTracing integration for it. At the moment sleuth does not provide hooks or API to do this effectively. There is a POC already https://github.com/DealerDotCom/sleuth-opentracing, however it is not an ideal solution for use in production environments.
Natively instrument all spring cloud frameworks. Currently we have instrumentations for spring-web, feign, rxjava and maybe something more. The current approach is to go with micro instrumentations per package/framework. All these micro instrumentations could be combined into one project (opentracing-spring-cloud) which would just contain auto-configurations and integration tests.

Some interesting links:

https://github.com/spring-cloud/spring-cloud-sleuth/issues/599

For now we will go with option 2). Repo is created here https://github.com/opentracing-contrib/java-spring-cloud

Closing, the first version has been released


DBZ-6875 ensuring root user is created before secured Mongo RS is considered started

https://issues.redhat.com/browse/DBZ-6875

@jcechace Applied, hopefully it will go away, thanks!


Fix for GUI HA if n/w policy is not applied to primary GUI

Fixes https://github.com/IBM/ibm-spectrum-scale-csi/issues/1054 and https://github.com/IBM/ibm-spectrum-scale-csi/issues/1055
Pull request type
Please check the type of change your PR introduces:

[ x] Bugfix
[ ] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

GUI HA connection is not happening if the n/w policy is not allowed to primary GUI

What is the new behavior?

GUI HA connection will take to the GUI where n/w policy is applied to

How risky is this change?

[ x] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

Image: quay.io/hemalatha_gajendran/driver_gui_ha_fix


chore(deps): update common-dev-assets digest to 75ffb91

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
31cae60 -> 75ffb91

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Wallet log cursor exhibits weird behavior

These aren't in the right order:

Also, there should be several 70 sat receives before from nwc that aren't appearing (you can tell because waiting for invoice is only logged after other things are logged. I suspect the dual-cursor logic is faulty and skipping pages/merging pages poorly.
@ekzyis

Oh that was definitely something I didn't fully test since it looked right but I forgot to make sure at the end / flag it during review.


[Sort-Flink] Remove lzo-core dependency

Description

Since lzo-core belongs to the GPL type of protocol authorization, it does not meet Apache's protocol requirements for third-party dependent packages. It must be removed and adjust the corresponding code logic at the same time.
InLong Component
InLong Sort
Are you willing to submit PR?

[X] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Assign to me please