relativeToWrapper bugfix

Added a condition to make sure scroll event listeners are not being applied to the wrapper element if relativeToWrapper is true. This fixes issue #170 .

Has anyone else tested this fix? As for me, the animation is still happening on the element even if it is not within the viewPort.
This is my initialization:
var parallaxSlider = new Rellax('.rellax'
    , {
      speed: -2,
      center: true,
        wrapper: '.custom-element',
        relativeToWrapper: true,
      round: false,
      vertical: true,
      horizontal: false,
      breakpoints:[576, 768, 1201]
    });

And still, the animate() function executes and so the image gets hidden due to the scrolling action.

That's correct, the animation is still happening outside of the viewport. From my understanding its just the values of speed and percentage that are relative to the wrapper element when using wrapper and relativeToWrapper.
However, without this fix there would be no animation at all, since the scroll listener initially was being applied to the wrapper element and thus listens for some scrolling action happening inside of it. I may be wrong, but i think this feature just doesn't work the way one would expect it to, unfortunately.

Oh ok, I got your point. Agree with your solution proposed.
Indeed, the custom wrapper does not seem to work as one will expect.
Actually, I have coded a new attribute within the library so the animation takes place only lead by the ViewPort area. This is configurable as needed. If you want to check my proposal here is the link to the PR: https://github.com/dixonandmoe/rellax/pull/242


ValidationData field added to CognitoEventUserPoolsMigrateUserRequest

Issue #, if available:
Description of changes:
According to AWS docs, values passed in ClientMetaData to AdminInitiateUs will be passed to lambda as validationData. Though this field doesn't exist in the CognitoEventUserPoolsMigrateUserRequest
Request sample and Explanation on AWS docs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #351 (e3aba8f) into master (e60bf50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   72.22%   72.22%
=======================================
  Files          19       19
  Lines         738      738
=======================================
  Hits          533      533
  Misses        138      138
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60bf50...e3aba8f. Read the comment docs.

Thanks for the update! I made one additional change to keep the unit tests passing


How to guide overview

Added Overview Section

Hi @abhishek-iiit , As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045
This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@Soumi7 We would be glad if you may once go through the PR, and either request for changes or approve the PR.

@abhishek-iiit pls remove the merge conflicts


Fix Console UI unfocusing on click in certain themes

Some themes didn't even check if the user clicked within the UI, so I've made it consistent with all the built-in themes.
Fixes #1109

I can submit a PoF of all of them working with these changes if needed, but I need to head out for now

Waow?!?!!! Le EPIC FIX!!!

tbh I haven't even seen any of the bug reports yet but this seemed pretty simple 😭


Detect duplicate files as a build error to avoid reference 404.

Docs Build status updates of commit bc80534:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e1096d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Page Load behaviour differences Protractor/Manual

We have a small hotel booking app for which I have written a simple automated smoke-test based on an E2E flow.
Select hotel > Choose Start Date > Choose End Date > Select no of Adults > Select No of Children > Enter Promo code > Click Search. From the offered hotels, click Submit to return room availability and costs.
Works fine when run by a user and also fine under an automated test UNTIL the last Submit action - the results page frame loads, then there is a 'wait' wheel followed by an error message stating the hotel's availability is not available!

I've checked that the url being posted contains the same data when run manually and automatically - i.e the enquiry data mentioned above...it's correct.
I've asked my dev colleagues if there's something different between the two ways of sending the data post-button press - no.
I've tried:

Browser.wait - of many different times.

Expected Condition (wait for the page to load)

Var V = element(by.xpath...........
V.submit
..that generates no element found on the form (I don't think the page in question IS a form so I'm not surprised!

Below is the last straw clutched!
 it('should check when new page is loaded', function () {             button.click().then(function (){                 browser.getCurrentUrl();                 browser.getTitle().then(function (title) {                         expect(title).toEqual('https://obmng.dbm.guestline.net/availability?hotel=OBMNG4&arrival=');                     return expect(newElement.isDisplayed()).toBeTruthy();
Has anyone got anything I could try or perhaps can explain this behaviour difference?
Thanks
David
Bug report

Node Version: 5.6.0
Protractor Version: 5.4.0
Angular Version: ``2.0.0-beta.21
Browser(s): ``Chrome
Operating System and Version `` Win 7 and OSX
Your protractor configuration file
A relevant example test
Output from running the test
Steps to reproduce the bug
The URL you are running your tests against (if relevant)

NB Tried on FireFox too...same error. BUT getting a console error that might be a clue?
 - Failed: java.net.SocketException: Software caused connection abort: recv failed

it('should check when new page is loaded', function () {
    button.click().then(function () {
        browser.getCurrentUrl();
        browser.getTitle().then(function (title) {
            expect(title).toEqual('https://obmng.dbm.guestline.net/availability?hotel=OBMNG4&arrival=');
            return expect(newElement.isDisplayed()).toBeTruthy();

Could you post a more complete code sample? Also, be careful with Github's formatting. It removed all the whitespace from your snippet.
A few things about this sample stand out to me:

Why do you call browser.getCurrentUrl(); but not wait for the promise to resolve and do nothing with the result?
You also seem to have mixed up browser.getCurrentUrl(); and browser.getTitle()?
Why do you return the second expect?

I wouldn't expect any of this to cause the error you've described so long as you haven't disabled selenium's promise manager (SELENIUM_PROMISE_MANAGER: false), but perhaps your error is caused by a similar issue elsewhere in your test.


Implement Integer#size in Rust

One of the patches we carry to mspec works around the lack of an Integer#size implementation.
This function is easily implemented in Rust using artichoke_backend::types::Int and mem::size_of.
https://github.com/artichoke/artichoke/blob/35adec79094c5406468225d377a22c6ca4fb7709/artichoke-backend/src/types.rs#L6-L10

I would like to give this a try.


Jtravert/issue 712 add eeprom

Rewrite from #936 (which died due to #980) taking @martukas' review comments into account except:

i2c1 is still a global variable, will make it disappear in a future commit
concern about void* in I2C::Request, I2Ceeprom::WriteBytes|ReadBytes and NVParams::Handler::Set|Get, which I see no (clean) way around
NVParams local functions are still local
concern about needing additional protection for NVParams reset
mock is still done with localized #ifdef e4f5c5c is hopefully solving this the way you expected

Still needs some additional work on unit tests to make them more modular.
Closes #712

This is really well commented and clean @asmodai27 :+1:
Most of my comments are minor and just spelling in comments. I'm uncertain about the need to protect the circular buffer from raced conditions so I thought I should bring it up. Thanks!


Translation for the page 'Basics -> Thinking in React'

Please help us translating this page in Italian!
Aiutaci a tradurre questa pagina in Italiano!
You can find all the details about how to help here: https://github.com/reactjs/it.reactjs.org/issues/1
GRAZIE! :smile:

I am working on this


ViewComponent inside form and Model Biding

From @ciacco85 on Friday, 19 October 2018 07:32:34
Using a Model like
class A
{
B b {get; set;}
}
class B
{
string testString{get;set;}
}

and passing the b property to the viewcomponent
<form aspAction='testMethod'>
<vc:myModel model="@(Model.b)"></vc:myModel>
</form>

when posting the form, the model property testString is alwayse null.
I've found a workaround, after a long experience with MVC, inside the viewcomponent, adding the "b" inside name
<input asp-for="testString" name="b.testString" class="form-control" />
but in this situation, a ViewComponent should know something about the class in wich the model is placed...two object coupled with no relationship is not that good
Should I use the editor template o change the approch?? ViewComponent are so powerful.
Thanks for your great work!!!
Copied from original issue: aspnet/AspNetCore#3673

Thanks for contacting us, @ciacco85.
@dougbu, can you please look into this? Thanks!

Thank you for filing this issue. In order for us to investigate this issue, please provide a minimalistic repro project that illustrates the problem.

@ciacco85 thank-you for your feedback. We're closing this issue as no updates have been provided in a timely manner and we have been unable to reproduce the issue. If you have more details and are encountering this issue, please add a new reply and re-open the issue.
In particular,

to the viewcomponent
Please provide the view component source, both C# and the .cshtml file (if any)

the model property testString is alwayse null.

Where?

Should I use the editor template o change the approch??

That's a good approach if I'm understanding the issue (guessing at the moment). View component invocations pass values but do not change the TemplateInfo.HtmlFieldPrefix. That's by design.


Add missing closing parenthesis in error message

For the record: Since this has been closed, but I don't see the patch in the SVN repo, I've opened a bug report in the ASF Bugzilla: https://bz.apache.org/bugzilla/show_bug.cgi?id=63806


misc: expose handle print APIs

cc @bnoordhuis

This can be done easily using uv_walk. I'm -1.

Yes but I would just copy paste libuv's code to io.js to do that then :|

Yes but I would just copy paste libuv's code to io.js to do that then :|

Like the wise man once said: so? :-)

also uv_walk doesn't iterate over internal handles, does it?

No, it doesn't. There is no reason to expose them, other than people shooting themselves in the foot.
I should have asked earlier, sorry: what do you need / want to accomplish? How does this help?

For instance there is a bug in OS X where the internal async handle used for the select loop that backs streams to /dev segfaults in uv_async_event due to use-after-free - it took me quite long to realize it's not my async handle at all but the libuv internal async handle.
In general I see the workers implemenationg exposing many more bugs in libuv and this function would be very helpful - it is absolutely crucial that all handles are always closed when a worker terminates because we cannot rely on OS doing that for us anymore.

And the idea is that when someone is running io.js with the --experimental-flags enabled, they would not just get a random assertion failure when the loop is attempted to be closed with handles still on it - but they would instead get a message + list of all handles that were active at that point so that we don't need to ask someone to run gdb just so they can reproduce their issue again and call uv_print_all_handles() manually.

For instance there is a bug in OS X where the internal async handle used for the select loop that backs streams to /dev segfaults in uv_async_event due to use-after-free - it took me quite long to realize it's not my async handle at all but the libuv internal async handle.
In general I see the workers implemenationg exposing many more bugs in libuv and this function would be very helpful - it is absolutely crucial that all handles are always closed when a worker terminates because we cannot rely on OS doing that for us anymore.

I can try to guess what those workers are, but I'm not familiar with your work there.
I assume you need to close a loop. libuv returns an error if you try to close a loop with active handles, so if you run into a problem is likely you're not closing the loop right. If you need to be absolutely certain that a loop is closed you can do the following:

uv_walk all handles and call uv_close on them
call uv_run with UV_RUN_DEFAULT mode
call uv_loop_close, it must return 0, if it doesn't there is an internal problem in libuv.
memory can now be safely released

And the idea is that when someone is running io.js with the --experimental-workers flag enabled, they would not just get a random assertion failure when the loop is attempted to be closed with handles still on it - but they would instead get a message + list of all handles that were still associated with the loop at that point so that we don't need to ask someone to run gdb just so they can reproduce their issue again and call uv_print_all_handles() manually.

I understand that. But it makes me very uneasy of the precedent this sets. We promised backwards API compatibility and ABI stability, but now we'd add this with a note basically saying "we make no promises on these". Remember this is the stable libuv branch, so IMHO this is not acceptable.
@bnoordhuis, @piscisaureus thoughts?

I assume you need to close a loop. libuv returns an error if you try to close a loop with active handles, so if you run into a problem is likely you're not closing the loop right. If you need to be absolutely certain that a loop is closed you can do the following:

I actually had the "force close" logic using uv_walk already implemented but I removed it as it would still leak resources when someone needs custom callback to close additional resources. Instead general architecture for attaching handle closure logic when a thread exits is implemented. So when uv_loop_close is called and it returns non-zero, someone forgot to register a callback somewhere and it should be debugged.

Remember this is the stable libuv branch, so IMHO this is not acceptable.

Yeah sorry I had no idea which is the correct branch to PR against.

Yeah sorry I had no idea which is the correct branch to PR against.

I assume this is the correct branch since it will take time for libuv 2.0 to make an appearance, but in the meantime we have tried (and succeeded I might add! :-)) to not introduce undertainty into the codebase.

I actually had the "force close" logic using uv_walk already implemented but I removed it as it would still leak resources when someone needs custom callback to close additional resources. Instead general architecture for attaching handle closure logic when a thread exits is implemented. So when uv_loop_close is called and it returns non-zero, someone forgot to register a callback somewhere and it should be debugged.

Hum.  Note that closing the loop could take more than one iteration (at least that's true on Windows IIRC), so if you'd run the loop with UV_RUN_DEFAULT you'd prevent the loop from exiting.

The general pattern is to call uv_close, and then wait until the callback is called before proceeding, e.g.
  while (HandleCleanup* hc = handle_cleanup_queue_.PopFront()) {
    handle_cleanup_waiting_++;
    hc->cb_(this, hc->handle_, hc->arg_);
    delete hc;
  }

  while (handle_cleanup_waiting_ != 0)
    uv_run(event_loop(), UV_RUN_ONCE);

@saghul  btw here is the irc conversation I had with bnoordhuis yesterday:
20:46 <petka__> btw is there a reason uv_print_all_handles is not exposed?
20:46 <bnoordhuis> it's just a debug tool i wrote to make my life easier
20:46  → dob_ joined  ⇐ nodweber and StoneCypher quit
20:47 <petka__> yes it has been very handy, but annoying to add to uv export everytime I need it :D
20:47 <bnoordhuis> oh, you can always call it from inside gdb
20:47 <bnoordhuis> that's my main use case, really
20:48 <petka__> I was thinking of printing all handles to stderr when a worker terminates and its loop still has stuff on it
20:48 <petka__> and abort
20:48 <petka__> cos basically at that point the loop is supposed to be completely empty (not counting the 2 internal handles that are always there)
20:49 <bnoordhuis> i guess that's convenient. if you're going to file a pr, please add a comment in uv.h and the docs explaining that the function is not part of the normal api/abi stability guarantees
20:49 <petka__> cool

I personally don't see anything wrong with making exemptions for certain functions, provided they're clearly advertised as such (which they are.)
If it's controversial, maybe put them in a uv-experimental.h header?  I defer to @saghul, I don't really have a dog in this fight.

Yeah I don't need it to be in a stable header so @saghul is the experimental header fine for you?

Let me think about this some more.

Also, if it's in experimental header it could also be documented on some hard-to-find experimental api page rather than in mixed with stable api docs ;p

I've bumped into similar unclosed handle issues too. Printing this information is not very useful for handling errors at runtime, instead of adding an API for this what would help is some instrumentation for debugging it e.g. in debug builds log this somewhere when calling uv_loop_close.
@saghul already has a nice description on how to handle this type of errors, that would fit well into the documentation (or maybe its already there I missed it).

Sorry for the absurd delay here... I had a change of hear, lets land this :-) Can you please make sure the functions are not defined inside "#ifndef NDEBUG"? Thanks!

done

Thanks! LGTM.

Thanks Petka, landed in 6490c50, and sorry for having this almost rot here :-S
(I added a ".. versionadded" to the docs part)


Updated parts of DG

According to our CS2101 teacher's feedback (left out model section)

Thanks for updating the DG!


Update telemetry-sdk, version 0.2.0

update the telemetry sdk to 0.2.0
add version and product for User-Agent
change nrcensus package doc comment for golint

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Targetcharging - not using all three phases

Describe the bug
When using target charging, not all possible phases are used. The system only uses one phase on a charger that is capable of switching phases from 1 to 3:

The current implementation is working precisely with one phase as far as I tried it.
Furthermore the interface states that it will switch down to one phase with zero time, this is a bit confusing as it is already switched to one phase.
To Reproduce
Steps to reproduce the behavior:

Set target charging active
Wait for target charging to start
See the screen above.

Expected behavior
Expected would be that target charging initiates the charge to determine the available phases and use them all. If needed it could also stop again if at the calculated start time for one phase charging, a three phase possibility is found and re-starts when the calculated time for three phase is reached.
 Es gab noch ein Problem mit dem hochschalten auf 3p, sollte seit 2 Tagen behoben sein. Falls nein bitte volles Log ab Start.

Moin @andig,
ist der aktuelle Master. Log ist gerade in Arbeit. Bitte wieder aufmachen.

Mist :(

Fixed in https://github.com/evcc-io/evcc/commit/2a320d1379a382acc69d9c5c508f40a8a07f040c


Bug: Function return different output as compared to the output that is shown in React Docs Beta

…and it was resulting different output as compare to the one in react beta doc under keeping components pure , changing the guest value to 2 , (guest=guest+2) will return the desired output as shown in react doc beta--> keeping components pure--> side effects--> untended consequences

#5606

The output produce by the TeaSet() shows in react beta doc==>keeping components pure==>Side Effects: (un)intended consequences  is :
Tea cup for guest #2
Tea cup for guest #4
Tea cup for guest #6 ,
But which is not correct  because the guest variable is incremented buy +1 so in order to to get 2,4,6 we should add +2  with guest variable.


[FEATURE REQ] Support server timeout parameter in GetMessagesXXX APIs

Library name
Azure.Storage.Queues
Please describe the feature.
https://docs.microsoft.com/en-us/rest/api/storageservices/get-messages#uri-parameters mentions a timeout parameter that is not present in the .NET SDK.
Please update the SDK to reflect the service functionality.

@iouri-s I have checked this and yes ReceiveMessages does not have this property currently.


fix: github workflow -branch to actual default branch

See https://github.com/openedx/docs.openedx.org/pull/135 for more details

apparently @kdmccormick is scooping me on these.
dupe of https://github.com/openedx/openedx-events/pull/118


Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

Edge Version 93.0.961.47 (Official build) (64-bit)
SPFx version 1.12.1
Node.js version 14.17.6
React /React-dom version 16.9
Gulp version 4.0.2

Describe the bug / error
Using a newly-scaffolded field customizer and make NO changes, the cell will render fine for the first page of entries on a document library (did not test on generic list), when the user pages, the cell will [intermittently] not render (onRenderCell is never called).  On some pages the cell will render and others is won't.. it appears to be all-or-nothing for any given page block..
Steps to reproduce

Get latest spfx generator
Scaffold a new field-customizer project
Deploy to sharepoint online (put package in app catalog, create instance on test site and add column to a document lib)
Add several pages of items to the library
Refresh the page and scroll to include additional entries
Sometimes the customized column will render and sometimes it won't

Expected behavior
I would expect the cell to be rendered regardless of page size and paged-scrolling.

Have you done any investigation into this? Any errors in the console?  Does your component get called?

Yes, originally I was seeing it in one of our products and suspected it had something do with initialization maybe taking too long as we are looking items up in SharePoint, but once I eliminated almost all our specific code and it was still happening, I tried a newly-scaffolded project and had the same issue.  The onCellRender is not getting called when the issue happens and there are no errors logged in the browser console.  Sometimes it seems to be a timing issue with how quickly the paging happens after initial page load, but others time (more rarely) it doesn’t seem to matter.
As a side note, if we have two such solutions, each having a column in the library, both solutions behave exactly the same way..not rendering on the same rows.
Ted
From: Pat Miller @.>
Sent: Monday, September 20, 2021 12:15 PM
To: SharePoint/sp-dev-docs @.>
Cc: tedley63 @.>; Author @.>
Subject: Re: [SharePoint/sp-dev-docs] Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation (#7330)
Have you done any investigation into this? Any errors in the console? Does your component get called?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/7330#issuecomment-923072811, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMO52NKR5L4Q6XYDLYEOTH3UC5MW5ANCNFSM5EEZCLFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi @tedley63,
Could you please provide few more details?
You're using Field Customizer in Document Library - correct?
What type of column do you have with the Field Customizer applied?
Do you have any additional customizations applied to the document library?
How many items do you have in the doc library?
Did you try to repro it on any other document library or list?
Sorry for bombarding you with questions. But currently we were unable to reproduce the issue so trying to collect as much information as possible.
Thanks!

Yes, it is being used in a generic Document library (template 101) with no other customizations. The custom column in a clean scaffolded project is of type Number, but it was originally noticed on both single-line and Multi-line Text columns. We have the page size on the library set to 30 and we have 40+ items in the list. It has been reproduced on multiple libraries, different site collections and different tenants.
Ted
From: Alex Terentiev @.>
Sent: Tuesday, September 21, 2021 1:58 PM
To: SharePoint/sp-dev-docs @.>
Cc: tedley63 @.>; Mention @.>
Subject: Re: [SharePoint/sp-dev-docs] Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation (#7330)
Hi @tedley63https://github.com/tedley63,
Could you please provide few more details?
You're using Field Customizer in Document Library - correct?
What type of column do you have with the Field Customizer applied?
Do you have any additional customizations applied to the document library?
How many items do you have in the doc library?
Did you try to repro it on any other document library or list?
Sorry for bombarding you with questions. But currently we were unable to reproduce the issue so trying to collect as much information as possible.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/7330#issuecomment-924226006, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMO52NIMYWMRI2NCA3EZGALUDDBULANCNFSM5EEZCLFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thank you @tedley63 for the additional info!
I'd like to ask you few more things if you don't mind...

Do you experience the issues both when debugging the field customizer and when it's deployed?
Could you please try the attached project and see if it's failing as well. If not - could you please share with us the failing solution?

Thanks!
issue-7330.zip

Sorry for the delay, been distracted.  I have not tried when debugging..  I will try the attached project today..
Ted
From: Alex Terentiev @.>
Sent: Wednesday, September 22, 2021 6:30 PM
To: SharePoint/sp-dev-docs @.>
Cc: tedley63 @.>; Mention @.>
Subject: Re: [SharePoint/sp-dev-docs] Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation (#7330)
Thank you @tedley63https://github.com/tedley63 for the additional info!
I'd like to ask you few more things if you don't mind...

Do you experience the issues both when debugging the field customizer and when it's deployed?
Could you please try the attached project and see if it's failing as well. If not - could you please share with us the failing solution?

Thanks!
issue-7330.ziphttps://github.com/SharePoint/sp-dev-docs/files/7214188/issue-7330.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/7330#issuecomment-925375375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMO52NKXXL44VLHGXEX5XJ3UDJKIFANCNFSM5EEZCLFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Alex,
This solution doesn’t seem to be complete as its missing the field definition and its association to the customizer..
Ted
From: Alex Terentiev @.>
Sent: Wednesday, September 22, 2021 6:30 PM
To: SharePoint/sp-dev-docs @.>
Cc: tedley63 @.>; Mention @.>
Subject: Re: [SharePoint/sp-dev-docs] Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation (#7330)
Thank you @tedley63https://github.com/tedley63 for the additional info!
I'd like to ask you few more things if you don't mind...

Do you experience the issues both when debugging the field customizer and when it's deployed?
Could you please try the attached project and see if it's failing as well. If not - could you please share with us the failing solution?

Thanks!
issue-7330.ziphttps://github.com/SharePoint/sp-dev-docs/files/7214188/issue-7330.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/7330#issuecomment-925375375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMO52NKXXL44VLHGXEX5XJ3UDJKIFANCNFSM5EEZCLFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sorry @tedley63 - my bad.
Here is the updated zip.
issue-7330.zip

Status update:  I’m now unable to duplicate with either your solution or mine.. until I add another of our field customizers to the library.. I have not focused on that customizer in a while so it is using an older version of SPFx libs and may be causing the issue.. I will continue by looking into that customizer to make sure it is not doing anything untoward.
Thanks for your time; I’ll repost as I continue working on it..
Ted
From: Alex Terentiev @.>
Sent: Wednesday, September 29, 2021 10:04 AM
To: SharePoint/sp-dev-docs @.>
Cc: tedley63 @.>; Mention @.>
Subject: Re: [SharePoint/sp-dev-docs] Column linked with SPFx Field Customizer not rendering cell [intermittently] after first library paging operation (#7330)
Sorry @tedley63https://github.com/tedley63 - my bad.
Here is the updated zip.
issue-7330.ziphttps://github.com/SharePoint/sp-dev-docs/files/7252540/issue-7330.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-docs/issues/7330#issuecomment-930208842, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMO52NOEZFD3C5C43RB5X7DUEMMGFANCNFSM5EEZCLFA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


crash during authentication

(horrible and totally user-unfriendly) oauth authentication seems to be broken:
husqvarna_automower version = 2022.7.1
homeassistant version = 2022.7.3
2022-07-12 12:18:02 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
resp = await request_handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 79, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 136, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 168, in get
return await super().get(request, flow_id)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 95, in get
result = await self._flow_mgr.async_configure(flow_id)
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 277, in async_configure
result = await self._async_handle_step(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 359, in _async_handle_step
result: FlowResult = await getattr(flow, method)(user_input)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 303, in async_step_creation
token = await self.flow_impl.async_resolve_external_data(self.external_data)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 169, in async_resolve_external_data
return await self._token_request(
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 205, in _token_request
resp.raise_for_status()
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 1004, in raise_for_status
raise ClientResponseError(

(uncomplete and developer-unfriendly) issue can't be solved without more information:

log ends at the most interessting part: raise ClientResponseError(
in which case this happend?

@Thomas55555 : sorry for my sarcastic remark... all my user experiences involving o-auth2 are terrible... so it's not a complain about this add-on, or to you as a developer: I'm grateful that guys like you take the time to develop this at all!
It's merely about my horrible oauth2 user experiences.
in which case this happend?
this happened when trying to add our mower to home-assistant. It worked fine before (by providing the user & password credentials), but after update to latest home-assistant (2022.7.1) it didn't work anymore: then I updated your add-on to (2022.7.3)
by the way: first I didn't change the 'redirect URL' on Husqvarna's side.. this resulted in a endless UI dialog sequence : I had to click OK, was directed to Husqvarna, provided my username & password, came back to home-assistant.. something went wrong... but never got the chance to change anything
After I removed the application credentials in home assistant I could retry stuff. Even after I had removed the addon, and reinstalled the addon the application credentials were stored inside home-assistant.. this is unclear to me as a user.
** log ends at the most interessting part: raise ClientResponseError(**
here is the log again, including the last line:
2022-07-12 12:18:02 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
resp = await request_handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 79, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 136, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 168, in get
return await super().get(request, flow_id)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 95, in get
result = await self._flow_mgr.async_configure(flow_id)
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 277, in async_configure
result = await self._async_handle_step(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 359, in _async_handle_step
result: FlowResult = await getattr(flow, method)(user_input)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 303, in async_step_creation
token = await self.flow_impl.async_resolve_external_data(self.external_data)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 169, in async_resolve_external_data
return await self._token_request(
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 205, in _token_request
resp.raise_for_status()
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 1004, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url=URL('https://api.authentication.husqvarnagroup.dev/v1/oauth2/token')

Hello, not sure if it's the same issue but after the last update of the integration I've got this:

Any help is really appreciated.
Note:
Auth key already created on Husqvarna dev site.
Integration version 2022.7.1
Home Assistant 2022.7.3
Thanks

Yeah, I filled in the wrong info and now its stuck in this loop... I cant seem to delete the integration and reload it.... just goes back to that error page every time now

Just to be sure, no one is doing it wrong. I made I video about how to add the integration
https://user-images.githubusercontent.com/59625598/178572694-73986b4d-de13-4950-a774-be99da21defa.mp4

@trickiegt
Better delete it in the UI: https://my.home-assistant.io/redirect/application_credentials/

that fixed it for me - thank you!

Hi, sorry, but what is the URL that should be put in the husqvarna site under redirect?
I receive that message:

Invalid client: redirect_uri does not match client value

thx
N.

Just to be sure, no one is doing it wrong. I made I video about how to add the integration
simplescreenrecorder.mp4

I don't see the video, possibile?
THx
N.

Video didn't open in browser for me.  Here is URL to download directly.
https://user-images.githubusercontent.com/59625598/178572694-73986b4d-de13-4950-a774-be99da21defa.mp4

followed Thomas's video and now it connects.
most important missing thing was the matching string inside 'Description'.. which seems to need to match with the one entered during the 'link account' dialog.
still: a bit vague how to connect this.. but after fumbling around it now connects.
thank you Thomas!

@nicolap75 I recall getting the

Invalid client: redirect_uri does not match client value

error because I had an extra space at the end from when I selected the url to copy it.

Fixed also on my side :-), many thanks Thomas for the video and the support.

followed Thomas's video and now it connects. most important missing thing was the matching string inside 'Description'.. which seems to need to match with the one entered during the 'link account' dialog.
still: a bit vague how to connect this.. but after fumbling around it now connects.
thank you Thomas!

The string inside the description was just for copy and paste later. Normally I don't do that and it stills works.

and here we are again, a couple months later I've replaced the mosquitto settings, and now this integration is not working for me anymore... it's the same problem as before.
@Thomas: could you please re-post your video (it can't be opened anymore) ? somehow it contains the magic way how to use oauth2
the way I seem to use the UI results in the same 'oauth2' failure as before.
Consider using debug logging and log_response for further investigation.
2022-11-21 20:42:35.046 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
resp = await request_handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 222, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 82, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 136, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 171, in get
return await super().get(request, flow_id)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 96, in get
result = await self._flow_mgr.async_configure(flow_id)
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 280, in async_configure
result = await self._async_handle_step(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 367, in _async_handle_step
result: FlowResult = await getattr(flow, method)(user_input)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 303, in async_step_creation
token = await self.flow_impl.async_resolve_external_data(self.external_data)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 169, in async_resolve_external_data
return await self._token_request(
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 205, in _token_request
resp.raise_for_status()
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 1004, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 400, message='Bad Request', url=URL('https://api.authentication.husqvarnagroup.dev/v1/oauth2/token')


Release 4.15 hacks

This PR is adding the ARO hacks on top of the upstream 4.15 branch.
Additionally to what's documented in https://github.com/Azure/ARO-RP/blob/master/docs/upstream-differences.md, I also run ./hack/verify-vendor.sh after each cherry pick, which resolved merge issues in go.sum and modules.txt nicely. For making vendoring faster, I added a new commit which skips running it for the terraform and CAPI modules, similar to what we have in ./hack/build.sh, see https://github.com/openshift/installer-aro/commit/e67ab7b527ef934b2f96e8205a99214610d2ace5
I will create PR for https://github.com/Azure/ARO-RP/blob/master/docs/upstream-differences.md to document that vendoring should be run as well, if no one disagrees.
ARO-6044

adding CI config for this branch here: https://github.com/openshift/release/pull/52620

It might be better to have it reviewed along with the changes in installer-aro-wrapper and confirm if the cluster creation succeeds with the new 4.15 installer image.
Because of differences between normal OCP and ARO, you sometimes need to change some codes additionally.
Once you finished installer-aro-wrapper changes, you can test the installer image following https://github.com/Azure/ARO-RP/blob/master/docs/deploy-development-rp.md#use-a-custom-installer.

* dofinn
  * User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

* s-amann
  * User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

* shivkumar13
  * User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

We will need to remove the 3 above usernames from the comment of openshift-ci bot, because they have left RH.
Can you re-push the last CARRY PATCH that modifies the OWNERS file? We will review older release branches that are still active as we rebase them.

Just needing to re-push the commit for the OWNERS file. Everything else looks great to me.

done :)
Can you also please lgtm and approve the CI config update, in order to run tests here? :)
https://github.com/openshift/release/pull/52620

/lgtm

/approve


Data size

You said the data is around 260GB, but my computer storage is only 100GB..could you please tell me some hint to solve this problem?
Thank you!

@LouisChang I don't think this belongs as an issue, so am closing. If you only have 100 GB of hard disk space available, here are some options:

Only download and process some of the taxi files (say, 2015 only)
Only download the Uber data files, as they're significantly smaller than the taxi data files
Buy an external hard drive
Use Google's BigQuery hosted version of the dataset: https://bigquery.cloud.google.com/table/imjasonh-storage:nyctaxi.trip_fare


Allocation of existing pay-as-you-go plans

Comments below were machine-translated
@go-shinyashiki commented on Thu Jun 11 2020
Azure Functions scale and hosting> Pay as you go plans

You can assign function apps in the same region to the same pay-as-you-go plan.

For the above 1 sentence on the page, I tried the following operation on the GUI.
-When creating a new Azure Function, specify the App Service Plan that is configured with the hosting plan "Pay-as-you-go" already created in the Azure portal.
As a result, the App Service Plan configured with Pay-As-You-Go was not displayed when selecting the plan and the new Azure Function could not be assigned to an existing pay-as-you-go plan.
If the documentation is incorrect, I would appreciate it if you could delete the one sentence in question.

ドキュメントの詳細
⚠ このセクションを編集しないでください。 docs.microsoft.com で必須です ➟ GitHub の問題のリンク。

ID: 06436739-8586-23b1-6b69-1960e93c26be
Version Independent ID: 8f7abfae-cf6d-56cb-1d20-f02041a6f6d9
Content: Azure Functions のスケールとホスティング
Content Source: articles/azure-functions/functions-scale.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@srvbpigh commented on Thu Jun 11 2020
Hello, @go-shinyashiki
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

@CeciAc Thank you for the feedback!  We are investigating this and will get back to you shortly.

@SunnyDeng I think that "pay-as-you-go" may be a mistranslation of "consumption." The intended meaning of the "consumption" plan is that you only pay for "resources consumed during function execution." I don't think "pay as you go" is correct in this context. #assign:SunnyDeng

@go-shinyashiki there is no easy way to add a function app to an existing Consumption plan like you can an app service plan or Premium plan. There is also no benefit to doing this as because each Consumption plan function app is scaled and managed independently even if in the same plan.

@ggailey777 Thanks for your reply.
My request was to remove that wording from the documentation.
I have now checked the documentation and confirmed the phrase has been removed, so you can close the case.
Thank you very much.


Improve ARM experience

This will be a tracking issue for optimizing the ARM port.

[x] It's working :)
[ ] We're using Hypriot kernel, which I think can be made smaller if we build it ourselves
[ ] Takes ~60 s to boot the persistent fs... I think it should be faster
[ ] About ~200 MB fs size when booted, maybe that could be smaller
[ ] Using 100MB+ RAM when booted. Why?
[x] sudo is -rwxr-xr-x instead of -rwsr-xr-x. Can be fixed by: chmod a=rx,u+ws /usr/bin/sudo
[ ] Provide pre-built images (.img) at least for Raspberry Pi, which should self-resize to the SD Card on first boot
[ ] Document how to build it yourself
[ ] Support Raspberry Pi 1?

Related: #417 #735
@imikushin @ibuildthecloud

Another thing: your rancher/docker-arm release aren't runnable on ARMv6 (RPi 1), so if we want RPi 1 support, we have to build it in with e.g. resin/rpi-raspbian as base image and GOARM=6

@luxas If you like, we can discuss some of these points in detail to build an optimised SD card image for the RPi2. I did already built a first version, but would like to get to know your thoughts. Currently it's only running on ARMv7, thus I removed the dual kernel support and saved some additional space.
wget http://downloads.hypriot.com/rancheros-rpi2-20160221.zip

Current build includes:

RancherOS v0.4.3 rootfs for armhf
single RPi2 kernel from Hypriot (no support for RPi 1!)
clean build from scratch, not from HypriotOS
no firmware files included (only needed to support WiFi USB dongles)

Yeah, maybe we should target Pi 2 first (a bird whispered that a Pi 3 is coming :smile:) and then consider a separate Pi 1 support for saving space.
Have you uploaded the build script or something? Maybe we could work on a Gist?

Now rancher asks for a new password on first boot. That's good.
The sudo problem I had is also fixed.
Some stats on first boot:
free -m: 125 MB
du -sh /: 197 MB
ps aux | wc -l: 76 processes
It uses pretty much 0-1% of the cores when idle
A funny thing, when running sudo system-docker ps, it says that the containers were created 46 years ago :) Probably because 1970 is the default startup time.
Will investigate even more.
I got Kubernetes running on this image now :tada: Yay!
In fact, the only thing I had to change was sudo modprobe tun
When running a Kubernetes master ~640 MB is consumed, so it's OK.
I'm excited to be a part of this work :) Let's move on to the script...

@luxas I just used the script from @ibuildthecloud and done some optimisations. So maybe it's best, if you start with his script here https://github.com/rancher/os/tree/master/scripts/images/rpi-hypriot.
As soon as I have the time, I can cleanup my improved build script to publish it.

How is RPi 3 compatibility?

@spralle You already have one?
Honestly, we can only tell anything about the RPi 3, when we were able to test it.

I ordered mine ~20 mins ago. I expect it to ship in 2-3 days.
To answer your question, yes, RancherOS is RPi compatible (at least theoretically)
I'm working right now on arm64 RancherOS rootfs though.

@DieterReuter, Yes but I haven't had time to play with it yet. If I can do something to test it just point me in the right direction.

Hi @DieterReuter, Thank you for the img. I am just struggling on one point, I successfully resized the partition but after reboot rootfs doesn't expand. Could you explain briefly the process?

@JulekFr, we do have a resizefs script, which we run in HypriotOS at first boot only. The partition table of the SD card has to be changed in order to expand the rootfs.
The same thing has to be done in RangerOS at first boot, but I think we don't have all the used Linux tools installed. So I guess, one has to modify the partition table directly and has to test this in RancherOS.

@JulekFr Here's the RancherOS builtin way of doing it: https://github.com/rancher/os-images/tree/master/src/docker/10-resizefs. There's a PR open for ARM support for that image too, and will hopefully be in for v0.4.4 or something.

@ibuildthecloud @imikushin What are your opinions about RPi 1 support?
I'm leaning towards that it's not worth it really, that we should see 1024MB RAM as a hard limit.
Then we could build binaries for ARMv7+ only, and focus on arm64 support for RPi 3.
WDYT?

@luxas According to RPi 3, I don't expect any improvement to run 64-bit on this board. And there is currently no support for 64-bit from the Raspberry Pi Foundation at all. The device is currently and will be limited to 1GByte for a longer time and in this case it's more efficient to use is with 32-bit userland binaries ONLY! With 1GByte you will have only disadvantages with 64-bit, the binaries will be 50% to 100% larger in size and consume more memory when running. Just my two cents.

Yeah, you're completely right about the RPi 3. Was just too excited about getting an ARM64 board to experiment with :smile:, so I didn't think about the 64-bit facts with larger size, RAM usage etc. compared to 32-bit ones.
Thanks for pointing that out.
The RPi is stuck at 1GB RAM, because of the VC4, IIRC?
What do you think about the Pine64 with 2GB RAM?
Is it worth to use 64-bit there? At least it would be cool with RancherOS for ARM64
I'm still waiting for my Pine64 to ship...

@luxas, I do have a Pine A64+ with 1GByte here for testing and right now the Linux support should be there - at least for the first tests. Maybe this would be a could experiment to compare and benchmark this board between 32- and 64-bit userland. My rough guess here: 32-bit will win.

I know this benchmark is quite silly, but it might give a hunch about what's better.
https://github.com/luxas/benchmark
Then one could compare if 32-bit or 64-bit compilations are faster.
WDYT?

@DieterReuter
Have you successfully tested the Pine A64+ ? And if so, do you still have the .img file? I would really like to add my (currently not used) Pine64 to my personal Rancher environment.

Has there been any progress on getting RancherOS running on a Pine64?

I'm chiming in for pine64 support as well. I have a nice clusterboard (7 sopine modules, each quadcore with 2GB RAM) on which I'd like to play with rancher around.

Is there any plan for supporting server ARM64 platforms like Ampere Computing eMAG?


android build error due to global static resources

Error	CS1002	; expected
----------.Uni.Droid
--------------.Uni.Droid\obj\Debug\g\XamlCodeGenerator\HelpPage_9dfed88ee309a80cecea1fb464f2de5e.g.cs	303	N/A
the error happened when there is style property in the page tag that reference a static resource defined in app.xaml
so I think that the code generator generate wrong code if the page contains reference to a globally referenced style.

This kind of issues is related to the styles management in general. In this case, this can happen if a style has been defined inside of a DataTemplate/ControlTemplate inner element.
This will be addressed as part of a Styles work.

I fail to reproduce this problem... is it possible to give code or a repro?


BBR unlocking bbr-usage-servicedb on backup_restore - PCF 2.3.4

[bbr] 2019/03/26 16:07:08 ERROR - Error unlocking bbr-usage-servicedb on backup_restore/78a03107-5bab-4fb4-8308-0a4d5c60bb8f.
[bbr] 2019/03/26 16:07:08 INFO - Finished running post-backup-unlock scripts.
2 errors occurred:
error 1:
1 error occurred:
error 1:
Error attempting to run pre-backup-lock for job bbr-usage-servicedb on backup_restore/78a03107-5bab-4fb4-8308-0a4d5c60bb8f: + exec /var/vcap/jobs/bbr-usage-servicedb/bin/lock

export PATH=/var/vcap/packages/cf-cli-6-linux/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
PATH=/var/vcap/packages/cf-cli-6-linux/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
cf api https://api.sys-xxx-xxx.xxx.xxx.net --skip-ssl-validation
echo 'Using cf auth to authorize'
set +x
Credentials were rejected, please try again. - exit code 1error 2:
1 error occurred:
error 1:
Error attempting to run post-backup-unlock for job bbr-usage-servicedb on backup_restore/78a03107-5bab-4fb4-8308-0a4d5c60bb8f: + exec /var/vcap/jobs/bbr-usage-servicedb/bin/unlock
export PATH=/var/vcap/packages/cf-cli-6-linux/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
PATH=/var/vcap/packages/cf-cli-6-linux/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
sleep 120
cf api https://api.xxxx.net --skip-ssl-validation
echo 'Using cf auth to authorize'
set +x
Credentials were rejected, please try again. - exit code 1
It is recommended that you run bbr backup-cleanup to ensure that any temp files are cleaned up and all jobs are unlocked.

Hey @sarojraju
Could you provide some steps or context to reproduce this error?  What version of PAS are you running this task against?  This is the deployment backup task yes? What was the result after running bbr deployment backup-cleanup against your deployment?
Best,
Glen

Hi @sarojraju,
As we haven't heard anything else on this so we're going to close this for now. If you have more information regarding your environment, please feel free to re-open the issue with the relevant information.


How To CONNECT?!

How connect??? I have only token, where get TLS Client Auth?
And what ip need on URL???
Heeeeelp please......

please refer to https://github.com/grafana/kubernetes-app/issues/35#issuecomment-407878758

I don't have user key and user cert, only token and ca.crt...

You can add a basic auth user and then config the cluster like below:

My guess is this is an amazon user. You only get the ca.crt in EKS.  see https://github.com/grafana/kubernetes-app/issues/55 if you are. More details would be useful.


Default view on open

My most common workflow when using git-control tends to be,

Toggle git-control
Hit 'compare' option
Review changes
Commit

When I open up git-control I'm presented with changed files but the right hand panel is always empty. I then have to hit the control button to see what the actual changes are within those files.
Thoughts on making the view default to the comparison page on toggle? I'm happy to put in a pull request...

Good idea actually. (Honestly very short on time at, if you can make a PR, will pull it in)


Add numeric_precision_radix to information_schema.columns

Closes #3625.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e710bbee4f26d624c8a5094d37e4648e9d31a634/

@nvanbenschoten when you have time, can you review this?


[zh] Add kubectl_delete/_index.md

Add zh text to:
content/zh-cn/docs/reference/kubectl/generated/kubectl_delete/_index.md

Sorry, accidently deleted the branch -_!

/lgtm
/approve


Add text

How to add text view above the each menu in FloatingToolbar

There's no support out of the box, without using a custom view:

I'm going to close this. If you need help, feel free to reopen.


⚠ Bofrost.nl has degraded performance

In 52f253b, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1819 ms

Resolved: Bofrost.nl performance has improved in e68c51d after 6 minutes.


Add Float.toFixed and friends

Previously based on asset-prefix (#140).
Adds some functions to Js.Float.

I'm not convinced this is the way to go. Because the behavior in native will differ from the JS one in some cases, it kind of defeats one of the main purpose of server-reason-react (render same HTML in server with OCaml and client with Melange).
I think it's better to keep current not_implemented alerts and let users use alternatives from the stdlib, which guarantees the behavior is the same.
@davesnx feel free to reopen if anything's recoverable :)

Currently the Js module is marked as very unstable, so keeping a half-backed implementation sounds good to merge to me.


Update live-search-catalog-data-sync.md

@torhoehn  thank you for your contribution, but our technical reviewers confirm that our docs got the commands right.


SAK-32627 Upgrade jGroups to latest 3.x

This is includes lots of jGroups fixes but doesn’t have a change of API.
Also remove the additional maven repository as it’s in central now.

@ottenhoff Roger!

Is there some background I should be aware of? Is this change going to cause problems or not needed?

Hi @buckett,
We're providing a new backend for the chat tool (Not the portal-chat) using jGroups, so we will use the same version you provided :)
Also i'm thinking about upgrade to 4.x after this work, because there will be some API changes, but we'll finish this first.
If you want more info just let me know, here is the reference https://jira.sakaiproject.org/browse/SAK-32035


Update dependencies

Update to TS 4.9 and fix resulting issues
Add casts to prevent TS errors showing up when debugging apps that step into polyfill code
switch to @rollup/plugin-terser plugin
add version override for rollup-plugin-sourcemaps (verified in source that this seems OK) to avoid peer dependency warnings on build
Added JSON type assertion for importing package.json, because otherwise there were build errors.
Switched to using default imports for all rollup plugins

It's weird that Rollup doesn't like our config because it's not CJS...

I researched this. The issue (if I understand it correctly which I very well might not be!) is that some newer rollup plugins are ESM-only, and they seem to have trouble loading configs in pre-Node17 environments because in those environments, .js files are assumed to be CJS. I'm sure I'm mangling the explantation, but in any case there's a  --bundleConfigAsCjs CLI option when running rollup which seems to fix the problem.  More info: https://github.com/rollup/rollup/pull/4621

Maybe we should split the build and test actions in the CI config so that all the build steps use the same consistent Node env (17?) and then the test steps use whatever relevant version of Node (for most non-test actions, same as the version above, for test actions whatever version we are aiming to test against)?
...
Instead of worrying about backwards-compatibility for Rollup, I think we should only ever run it on a recent Node version.
#202 should fix the issues with Node14 tests without having to use any backward-compat stuff.

@12wrigja whoops, I just saw these comments after I checked in workarounds for both issues.  I'm open to your proposals for both of these. My only concern is a bit of chicken-and-egg where this PR introduces new dependencies and your PRs change how the build process works but don't validate against these new dependencies.  Someone needs to validate that your build process changes work against these new deps.
Given that this PR is currently all green, should we merge it (including the backwards-compat Node14 and CJS config workarounds) and then your build-process PRs can revert those workarounds assuming that they fix everything?  Or should we merge those other PRs first and them remove the workarounds from this one? (Assuming they work with these new deps.)
I'm OK either way, although I have a slight preference for merging this PR as-is because I'm lazy. :-)

Feel free to merge this as-is and I'll play around with just how much is fixed by my other PR.


Fix the all issues template for when there are no issues

Fixes https://github.com/datagovuk/ckanext-dgu/issues/301

Great :-)


In the recyclerview, the expansion does not display the entire content correctly.

According to debug, I think that the number of rows that get the textview is incorrect. The number of rows obtained before the super.onMeasure() method is correct (may be 0), but the number of rows obtained after this is less. Up
------------------------------Above from Google Translate, the following is the original----------------------
根据debug，我认为是获取textview的行数不正确导致的，在super.onMeasure()方法之前获取到的行数是正确的（也可能是0），但是在这之后获取到的行数变少了

I see a problem, because mRelayout this switch affect the execution of onMeasure, this switch will only limit the re-measurement at the time the text changes, and in recyclerView in, setText time may not accurately measure the width and height, needs The measurement is accurate after the complete itemView is drawn, so just let the onMeasure perform the measurement smoothly after the view is drawn to solve the problem. My current solution is to remove the mRelayout condition. I don't know what it will do now.
我发现了问题所在，是因为mRelayout这个开关影响了onMeasure的执行，这个开关限制了只有在文本变化的时候才会重新测量，而在recyclerView中，setText的时候可能并不能测量准确的宽高，需要在完整的itemView绘制之后测量才准确，因此只要让onMeasure在view绘制之后也能顺利往下执行测量就能解决问题。我目前的解决办法是把mRelayout这个条件去掉，目前不知道这样会有什么影响。

Yes, you are right. I have same problem. I see just half of my text when I do expand. Any solution out there for this? Thank you.

Yes, you are right. I have same problem. I see just half of my text when I do expand. Any solution out there for this? Thank you.

Please see my reply above.
if (!mRelayout || getVisibility() == View.GONE) {             super.onMeasure(widthMeasureSpec, heightMeasureSpec);             return;         }
to
if (getVisibility() == View.GONE) {             super.onMeasure(widthMeasureSpec, heightMeasureSpec);             return;         }

how to change that? Can' t change anything in class.

Yes, you are right. I have same problem. I see just half of my text when I do expand. Any solution out there for this? Thank you.

Please see my reply above.
if (!mRelayout || getVisibility() == View.GONE) { super.onMeasure(widthMeasureSpec, heightMeasureSpec); return; }
to
if (getVisibility() == View.GONE) { super.onMeasure(widthMeasureSpec, heightMeasureSpec); return; }

In my case, remove mRelayout  may cause shrink when click the textview first, so I also change the Animation reference #55


update docs

@buehlefs please have a look at the QHAna chapter, we need some updates there.

https://github.com/UST-QuAntiL/QuantME-TransformationFramework/issues/38
QuantME may need also an update. Do we require it now @lharzenetter?

I have updated the QHAna documentation in this PR.


added a closing button for reservation section fixed #242

fixed #242 issue
I have added a closing button for reservation section
screenshot

video
https://github.com/c4coderandcreator/Flavour-Fusion/assets/82786865/b75185ae-e486-464f-859e-ad69cb288a81

Thank you @love-sonkar


Improve server_test

Current server_test package contains test that relies on time.Sleep to wait server to be ready for accepting connection. Hope to refactor these test to use the ready channel of server for better readability. I can open a PR to refactor these tests

@KianYang-Lee could you give a link to test you mean, I see only protection selects that help us to not wait forever on a signal and fail test faster

@ksysoev for example this https://github.com/ksysoev/wasabi/blob/main/server/server_test.go#L85-L117 . We can just wait on ready chan . Makes for better readability

let me make a PR and you can see better

implemented in #62


[Perf] Include running average in per-second output

Same change in .NET: https://github.com/Azure/azure-sdk-for-net/pull/18071

@g2vinay: Should be ready for final review

@g2vinay: Should be ready for final review


Add link to Dart pub

Hi! Thanks for making this.
I had trouble finding the right Dart package for this because the GitHub repository name is different. Could we remedy that?
A couple suggestions:

Add a link to the Dark package into the repo description
Add a link in the README
Add a portion of the readme that has a pubspec.yaml line on how to import.

Not a big issue, but a little cognitive friction for the consumer.

Edit: Ok I was wrong. The GitHub package is the same name, but other packages are taking the SEO from google pretty bad. I was confusing it with redux_dart_tools.
I think a link somewhere would help a bit. LMKWYT


Add adornments to images

[ ] hats
[ ] earrings
[ ] necklaces
[ ] facial expressions

[ ] smiles
[ ] frowns
[ ] tears
[ ] tongue

[ ] eye adornments

[ ] glasses
[ ] patches

[ ] badges

Example from @dsbush:

Super nice. How about pants?


Consistent release versioning and tagging

Consistent release version numbers and corresponding git tags are not only expected by users of our software, but also necessary for automated tools, such as dependency scanners, or downstream packager update detectors (see https://github.com/secure-systems-lab/securesystemslib/issues/167 and https://github.com/in-toto/in-toto/issues/286 for discussions).
Versioning
"semantic versioning" (semver) provides a clearly defined de-facto standard, which we already adhere to with TUF, in-toto and securesystemslib (more or less). We should make this a principle and be strict about it.
Tagging
The easiest way seems to just use the semantic version number as git tag name. However, @SantiagoTorres has a compelling argument for v-prefixing the semantic version string, that is command line auto-completion (e.g. git checkout v[tab]).
Most importantly, there should be no switching between conventions, such as a mix of X.Y.Z, vX.Y.Z or <arbitrary-prefix>vX.Y.Z  (see in-toto#releases and securesystemslib#releases).

I just found out that TUF uses PEP 440 (see    https://github.com/theupdateframework/specification/issues/33#issuecomment-468379281).


[Bug] code highlight don't work

Describe the bug

codeblock's option  title, {line}, and so on..  don't work when update to latest v4

Screenshots and Source

Desktop (please complete the following information):

Quartz Version: [e.g. v4.2.3]
OS: [e.g. macos]
Browser [e.g. chrome, edge]

should be fixed by this revert: https://github.com/jackyzha0/quartz/pull/965


wget not found in cog

Hi bro @zeke @mattt @anotherjesse ....
    def setup(self):

        os.makedirs('weights', exist_ok=True)
        os.chdir('weights')
        if not os.path.exists('Swin2SR_ClassicalSR_X4_64.pth'):
            os.system(
                'wget https://github.com/mv-lab/swin2sr/releases/download/v0.0.1/Swin2SR_ClassicalSR_X4_64.pth'
            )
        if not os.path.exists('Swin2SR_CompressedSR_X4_48.pth'):
            os.system(
                'wget https://github.com/mv-lab/swin2sr/releases/download/v0.0.1/Swin2SR_CompressedSR_X4_48.pth'
            )
        if not os.path.exists('Swin2SR_RealworldSR_X4_64_BSRGAN_PSNR.pth'):
            os.system(
                'wget https://github.com/mv-lab/swin2sr/releases/download/v0.0.1/Swin2SR_RealworldSR_X4_64_BSRGAN_PSNR.pth'
            )

        os.chdir('..')

The isssue has been...
Starting Docker image cog-pixalto-tools-base and running setup()...
sh: 1: wget: not found
sh: 1: wget: not found
sh: 1: wget: not found
sh: 1: wget: not found

But i have installed wget in locall it's works fine..

Try adding wget to https://cog.run/yaml/#system_packages


Rustc nightly required

Hi, seems compilation fails due to this:
error[E0554]: #![feature] may not be used on the stable release channel
This is the offending line:
https://github.com/mrchantey/forky/blame/1a1fdf10044dae337cd3922b219d5cfae4e3ed76/crates/gamai/macros/src/lib.rs#L1
Works fine in nightly though.
P.S might want to push an update to crates.io . It's still on Bevy 0.11.3 there.

Ok yeah i should probably document this, the current architecture relies heavily on a bunch of unstable features like associated_type_bounds, I'm looking into some big changes that will hopefully get it running on stable.
I'll release 0.1.37 now.


Documentation improved in example env

LNBITS_ALLOWED_USERS and LNBITS_ADMIN_USERS wants usr string from wallet url
List needs to be comma separated if used more than one user

Need to do some research of what to set in the env variables. Was also asked here on how to use those environment variables.

Codecov Report

Merging #1125 (db4232f) into main (2cbbea0) will decrease coverage by 2.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   51.59%   48.65%   -2.94%
==========================================
  Files         238      238
  Lines       13461    13461
==========================================
- Hits         6945     6550     -395
- Misses       6516     6911     +395

Impacted Files
Coverage Δ

lnbits/extensions/boltz/mempool.py
32.75% <0.00%> (-50.00%)
:arrow_down:

lnbits/extensions/boltz/crud.py
29.23% <0.00%> (-49.24%)
:arrow_down:

lnbits/extensions/boltz/utils.py
23.52% <0.00%> (-41.18%)
:arrow_down:

lnbits/extensions/boltz/boltz.py
17.91% <0.00%> (-39.31%)
:arrow_down:

lnbits/wallets/cln.py
19.00% <0.00%> (-29.76%)
:arrow_down:

lnbits/wallets/lndrest.py
17.09% <0.00%> (-29.06%)
:arrow_down:

lnbits/wallets/lndgrpc.py
22.72% <0.00%> (-27.93%)
:arrow_down:

lnbits/extensions/boltz/views_api.py
31.40% <0.00%> (-18.19%)
:arrow_down:

...nbits/wallets/lnd_grpc_files/lightning_pb2_grpc.py
38.22% <0.00%> (-12.25%)
:arrow_down:

lnbits/wallets/lnd_grpc_files/router_pb2_grpc.py
40.54% <0.00%> (-11.49%)
:arrow_down:

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM

This PR changes has been reverted in the last commit  https://github.com/lnbits/lnbits/commit/c8e18ac4be046a602e4aa6415bffe83886673d7b
@ChuckNorrison
@arcbtc

Looks like a missing rebase.

Thank you for noticing @Bashy. Fixed.


Bugfix: issues 143

Thanks for this very basic, albeit very logical fix. I'm trying to think of any reason where we wouldn't want a PureComponent and I can't.
@j-o-d-o @izakfilmalter any thoughts on this?


is it possible to compile .a android library with lime?

i just realized, that if i use .a libs, for some reason performance of the app is better, thats why i'm asking for this.
So is there any flag for it? if answer is no, then, i think that i should make a feature request or smth?
P.S. if you have questions about how i found out that .a have better performance than .so, if lime can't do so, then: i'm using linc_luajit in my app and i compiled luajit libs using make with my hands and suddenly found out that performance became better

Did you try compiling a .so file using Make?

yes, make compiling for both .so and .a at the same time and you can find both libs after running single build command


Glow doesn't work in Windows11 Home

Is Glow supposed to work with Windows11 Home?
I have no problems with Windows10 Pro (v22H2) and Windows11Pro (v23H2), but on a laptop running Windows11 Home (v22H2), when I double click Glow_x64.exe, all I see is a very brief 'egg-timer' then nothing. Also when I try to launch Glow, nothing happens in 'Task Manager' if it is open at the the time so there is nothing running in the background.
I should point out that I am not running the executable from within the zip file but have extracted everything and all 3 machines are using the same downloaded files so not a download issue.
Martin Dashper

Is Glow supposed to work with Windows11 Home? I have no problems with Windows10 Pro (v22H2) and Windows11Pro (v23H2), but on a laptop running Windows11 Home (v22H2), when I double click Glow_x64.exe, all I see is a very brief 'egg-timer' then nothing. Also when I try to launch Glow, nothing happens in 'Task Manager' if it is open at the the time so there is nothing running in the background. I should point out that I am not running the executable from within the zip file but have extracted everything and all 3 machines are using the same downloaded files so not a download issue.
Martin Dashper

Hello,
There is no such error.

Then why does my laptop display this behaviour?
I have to say that I feel that simply dismissing my problem by, effectively telling me it is not happening, is incredibly disrespectful.


feat:support mongodb commit sql with comments

function execute_check() add sql filter ,support commit sql with comments
before:

after:

done,please check it again


Adaptive cards are not rendering when iframe embed used for WebChat

Screenshots
Ms team channel for same bot shows adaptive rendering

WebChat using iframe embed for same bot shows broken adaptive cards rendering.

Version

embedding Web Chat to your site via `
Using botbuilding v3 SDK to build the bot.

Expected behavior
Adaptive cards are not channel specific so they should be rendered correctly in all supported channels.
[Bug]

Hi @rjgmail88, unfortunately v3 of Web Chat (using the iframe from Azure Portal) is in sunset mode right now and we're not performing maintenance that doesn't fall under security issues for v3. We are hoping that using v4 of Web Chat in embed (iframe) will be available very soon.
Could you try out your bot on a basic web page made by following our sample 01.a? This is just to test if your adaptive cards issues are persisting to v4 of Web Chat. If so, we'll be able to investigate the problem and file this as a bug. Otherwise, my immediate fix recommendation would be to use v4 through CDN or NPM until we get v4 available via embed, which will hopefully be in the upcoming weeks.

Thanks @corinagum. I am trying to use sample 01 and not sure how to replace following URL  for my bot
https://webchat-mockbot.azurewebsites.net/directline/token

@corinagum , can you  help with above so I can confirm if this is really a bug or not.

, Mock Bot has code showing users how to implement a token server, which is the API call that you are linking above.
For protecting the Web Chat secret, the simplest implementation is to store the secret on the bot side so that the client never sees the secret, and exchange it for a token before sending it to the client. If you are interested in implementing a token server like Mock Bot has, you are welcome to take a look at Mock Bot on the following files:
https://github.com/compulim/BotFramework-MockBot/blob/master/src/generateDirectLineToken.js
https://github.com/compulim/BotFramework-MockBot/blob/master/src/renewDirectLineToken.js
https://github.com/compulim/BotFramework-MockBot/blob/master/src/index.ts#L109
(#1534 is for tracking the creation of a sample, but hasn't been implemented yet)

Thanks @corinagum , As I'm just testing web chat v4 example to make sure cards work I would like t skip the server steps if implement server step. Do you suggest any other way ? I can still use  sample 01.a

You can temporarily use your secret instead of a token. Remove the token fetch code from sample 01.a and instead place the secret on the createDirectLine line, like so:
 directLine: window.WebChat.createDirectLine({ secret: 'YOUR_SECRET_HERE' })
Disclaimer: This is not recommended for deployed code and is good for testing only. Please don't use your secret on a deployed app. :)

I have verified and adaptive cards worked.

@rjgmail88 thank you for investigating! As I said above, we don't have the bandwidth to commit to v3 fixes right now so I'm going to be closing this issue as a won't fix. Based on your immediate needs, I would recommend either waiting for v4 to be available via embed, or to bump to v4 by following the sample 01.a (or others).
If you need help with implementation, please feel free to check out the Stack Overflow web-chat tag, where our support engineers can help you out. :) Thanks again!


feat!: remove ec_double opcode

Remove the ec_double ACIR opcode since we can use EC addition with itself to double a point.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 301f0e6d and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,620
866,932
3,448,408

l1_rollup_execution_gas
314,039
984,604
3,667,997

l2_block_processing_time_in_ms
1,587 (-2%)
5,301 (+2%)
20,995 (+2%)

note_successful_decrypting_time_in_ms
287
846 (+1%)
3,251 (+2%)

note_trial_decrypting_time_in_ms
96.0 (-1%)
74.0 (+18%)
148 (+1%)

l2_block_building_time_in_ms
16,136
64,054 (+1%)
256,386

l2_block_rollup_simulation_time_in_ms
11,749
46,709
187,123

l2_block_public_tx_process_time_in_ms
4,351 (+1%)
17,257 (+1%)
68,980 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,276 (+2%)
30,732

note_history_successful_decrypting_time_in_ms
2,019 (+2%)
3,988 (+3%)

note_history_trial_decrypting_time_in_ms
150 (+2%)
141 (-39%)

node_database_size_in_bytes
3,519,670
3,556,544

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
212
44,681
25,561

private-kernel-ordering
165
43,753
14,809

base-rollup
1,198
128,338
881

root-rollup
81.2 (+3%)
4,088
677

private-kernel-inner
292
71,208
25,561

public-kernel-private-input
206
31,863
25,561

public-kernel-non-first-iteration
203
31,905
25,561

merge-rollup
7.66 (+1%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
12.2 (+2%)
17.5 (-6%)
13.6 (-10%)
20.4 (+6%)
24.4 (-3%)
66.9 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.623
0.616 (-7%)
0.548 (-11%)
0.561 (+4%)
0.482
0.444
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
83.3 (+1%)
51.8
252 (+2%)
483
923 (+2%)
3,592 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.468
0.496 (-1%)
0.440 (+1%)
0.438
0.431 (+1%)
0.429 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
118 (+1%)
62.9 (+1%)
373 (+2%)
783 (+2%)
1,444 (+2%)
5,681 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.504
0.505
0.479 (+1%)
0.489 (+1%)
0.477 (+1%)
0.474

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
68.1 (+1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
94.1
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
0.596
N/A
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,222

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
375 (+1%)
1,087

Metric
1 public data writes

tx_sequencer_processing_time_ms
536


Fixed typos on booleans.

Fix typos for booleans in various places.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the fixes @andrewple! Cherry-picked as a8da9c1.


Add support for DICTIONARY encoding to PrestoSerializer

Extend PrestoSerializer to support deserializing dictionary-encoded data.
The format of dictionary-encoded columns is:

4 bytes: number of rows
N bytes: dictionary column
4*numRows bytes: indices
24 bytes: 'instance id' (used by Presto, but not present in Velox)

Part of #6595

@pedroerp Pedro, thank you for review. Addressed comments and updated the PR.


Update readme.md

Added Latin to the list
Adding a language

[ ] The code displays "Hello World"
[✓] I have updated the readme to include the new language
[✓] I have incremented the language count in the readme

Should be merged into #1159

done


.only() shouldn't print all tests when verbose is on.

When one of the tests has .only() on them I still get all the rest of the tests marked as passed -even if they would otherwise fail. There are two solutions:

do not print out those tests at all and just show the one with .only()
print the rest of the tests in the same manner as they would use .skip()

Because right now, it's easy to miss that we're performing one test only, which is a UX concern, to say the least.

Sounds like a bug. It should only show the .only() test.

I can't seem to replicate this.
I have a file with two failing tests and one passing test with .only()... I only get "1 test passed" and a green check next to that test, with verbose. Can you share the code you are using?

@tomazzaman ping ~

Sounds like #549. Nice find @tomazzaman, it's being fixed :smile:


♻ migrate codebase to nullsafety

This was/is a mostly manual migration*, so it's very likely that there are bugs here and there, but overall the migration is complete, now it's time for testing. I'm still testing as many features of the app as possible, to make sure everything works as intended. So far, apart from some smaller issues I've noticed, everything works fine. If you want to help debug things, you can build the app yourself report bugs back to me.
Sometimes there's some lag going on in the debug build** but that might be because it's not optimized and has a lot of debug symbols left in, which makes it slower.
When building the app, you have to use the --no-sound-null-safety flag for now, as some libraries are not yet migrated to support nullsafety (such as the OneSignal SDK). The vscode build tasks include this flag by default.
*) I tried using the Dart migration tool but I couldn't get it to work at all. Also, I preferred to have this be manual for the most part, since trusting machines to automagically migrate such a large codebase is not necessarily a good idea because it could result in lots of debugging.
**) Haven't used the production build more thoroughly just yet.
P.S.: the oldest (largest) commit was originally split into multiple smaller commits, but I rebased it so it's all clean and tidy :)
Relevant issue: #546
Todo list

[x] app ignores link preview preferences until you change them
[x] images in link previews don't show up (weird because it used to work)
[x] onesignal_flutter was migrated over, we can upgrade it
[x] clicking on a community from hashtag search (probably other post streams) displays a nullcheck operator error for a second, then it displays the community
[x] overflow error in user stream: https://i.imgur.com/1Y6OzCF.png
[x] default profile pic doesn't show up in community (if a user has no profile pic): https://i.imgur.com/bLJ3Aq9.png
[x] adding administrator displays "Unknown error" but adds the admin anyway (moderators and blocked users don't have this issue)
[x] this very questionable overflow: https://i.imgur.com/fiqv7jM.jpg (we can prooooobably ignore this)
[x] tapping on "new circle" in the "add user to connections" bottom sheet results in this error (lists don't have this issue and the new circle modal works when opened from the menu): https://i.imgur.com/XwekOvk.jpg

If you'd like to help testing the app post-migration but don't want to build it yourself, you can use the following APK: https://s3-us-west-1.amazonaws.com/sallai/app-production-debug.apk (I don't have an iOS device, so I can't provide with an iOS build, sorry) 🎉

Uploaded a new apk with all of the bugs from the initial todo list fixed. The download link should be the same.

Good job man! I'm going to test on the iOS now...

Thanks @vituocgia! Lemme know if you've encountered any bugs!


[CHORE] restart all bots that used updated gecko.json

Restart all the bots using new gecko.json

[x] https://github.com/VolumeFi/curve-twap-bot-script
[x] https://github.com/VolumeFi/uniswap_v3_twap_bot_script
[x] https://github.com/VolumeFi/curve-limit-order-bot-script
[x] https://github.com/VolumeFi/limit-order-bot-uni-v3-script
[x] https://github.com/VolumeFi/curve-stop-loss-bot-script
[x] https://github.com/VolumeFi/twap_bot_python_script

Done.


Speak Audio with PCM Buffer, no lip sync

Hi,
first thank you for this great work.
I have a problem with the function speakAudio, i pass a object with
let object = {           audio: data.buffer,           words:  ['Ça', 'va', 'bien', 'grâce', 'à', 'toi'],           wtimes: [93.75, 262.5, 481.25, 693.75, 862.5, 1118.75],           wdurations: [87.5, 187.5, 212.5, 50, 100, 56.25]         };
Audio is working well (Buffer PCM), but there is no animation and no lipsync. No error too.
I wonder if i forget something or it's a bug

Hi. I couldn't reproduce your problem. I copied the object into my own test app, and the lips moved fine. Of course, I didn't have the right audio, and I used the English lip-sync language, but the lips moved nevertheless. The problem must be somewhere else.
Since you don't provide visemes (visemes, vtimes, and vdurations) to speakAudio, it means that the class uses one of the lip-sync modules to generate the visemes for each word. There is no lip-sync module for French, so are you using the English module, some other supported language, or perhaps developing one for French?

You're right, the problem was the 3D model i used. It's strange because i downloaded it from Ready Player Me like wrote in the appendix  ....
Do I forgot something in the export for Ready Player me ?
6633cd2ebc7a300396411cc5.zip
Here is attached the GLB file.

OK, that explains it. The attached file is missing most of the blend shapes (morph targets) needed for facial expressions and lip-sync. You need to manually add all the URL parameters listed in Appendix A when you download the GLB file.
Here is the correct download link for your avatar:
https://models.readyplayer.me/6633cd2ebc7a300396411cc5.glb?morphTargets=ARKit,Oculus+Visemes,mouthOpen,mouthSmile,eyesClosed,eyesLookUp,eyesLookDown&textureSizeLimit=1024&textureFormat=png


SCons: Replace _find_scu_section_name function with SCons builtins

Not only that it is a clean up and ammending of custom workaround but it also transparently allows to process SCons specific paths which contains # in the starts (which in turn in the future should allow me to implement SCU for thirdparty sources which should greatly increase compilation speed)

I've just found that scu_builders.py have a Ctrl+C, Ctrl+V version of methods I am deleting in this PR. I think this should be done in this PR too. I've also noticed that tendency not to use SCons related stuff inside builders... An when I tried to add from misc.utility.scons_hints import * to file and it didn't work :sweat_smile: I delayed that question as much as possible but it is time to ask. Why does builders doesn't use SCons?

I've just found that scu_builders.py have a Ctrl+C, Ctrl+V version of method I am deleting in this PR.

Oh. I was a bit wrong. It returns in format dir_dir_dir instead of dir/dir/dir so it is for another PR  :thinking:  or for this... Anyway this PR again can be considered as ready to be merged :sweat_smile:

Thanks!


How to close input window?

Before creating an issue, take some time to search these resources. It's possible that someone else has already asked your question and gotten an answer.

old NERDTree issues
NERDTree documentation - :h NERDTree
NERDTree Wiki
Other resource: https://stackoverflow.com, https://vi.stackexchange.com, etc.

State Your Question
After i created some files with ma keymap, and the input window grows up and i have no way to close it. There is any way to fix this? If i set terminal to minimum and restore, the input window disappears, but i think nerdtree itself can refresh window automatic.

What is the exact version of your Vim? It should close with the press of the Esc key. It previously was a bug in the Vim9 maybe you are using an old version?
https://github.com/preservim/nerdtree/pull/1322

Thanks for replay.

Thanks for replay.

Thanks for replay. I use the latest version nerdtree and neo-vim info as follow:
➜  ~ nvim --version
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
brew@iMac-Pro
Features: +acl +iconv +tui
See ":help feature-compile"

What is the exact version of your Vim? It should close with the press of the Esc key. It previously was a bug in the Vim9 maybe you are using an old version? #1322

Thanks for replay. I use the latest version of nerdtree and neo-vim info as follow:
➜ ~ nvim --version
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3
brew@iMac-Pro
Features: +acl +iconv +tui
See ":help feature-compile"

I've tried to reproduce this issue to no avail. Is it possible for you to update your nvim to the latest stable version? A faulty version of nvim might be causing this problem(similar to the Vim9 issue).

I've tried to reproduce this issue to no avail. Is it possible for you to update your nvim to the latest stable version? A faulty version of nvim might be causing this problem(similar to the Vim9 issue).

Thanks a lot. Everything works well after upgrade neovim & plugins.

I've tried to reproduce this issue to no avail. Is it possible for you to update your nvim to the latest stable version? A faulty version of nvim might be causing this problem(similar to the Vim9 issue).

Thank you very much @rzvxa . Everything works well after upgrade neovim & plugins. This staps maybe useful to others:
bash:
# update all programs and dependencies
brew upgrade

in vim:
:checkhealth # maybe you should fix errors in result
:PluginUpdate


CentralAuth issues

There are several CentralAuth related issues on the tool, this is just a quick list. They probably need to be split into separate issues at some point if they are verified:

[ ] JIRA:ACC-254 Tool doesn't detect conflicting SUL accounts that haven't been used on the English Wikipedia
Tool doesn't detect all conflicts - see #67
[ ] JIRA:ACC-246 "conflicitng accounts" should also check SUL accounts

Closing as duplicate of #212, which has better information.


[FEATURE] Share token location but not sight

Might it be possible to share token location, rather than full vision, with other players?
For example, if the characters are in a dungeon and one goes around a corner, I would like the other players to know where that character's token is, though not be able to see everything they can see, if you understand what I mean. Let me know if I'm not explaining well, and I'll try to clarify.
Edit: Same for pets and the like that are assigned to a character.

I think I understand what you're looking for. There is already a different module that can do that: Shared Token Visibility. I don't know if it still works, though. Please give that a try, and if there's issues with it, let me know, and I'll consider adding it to Shared Vision.

Yep, that's one that I've used in the past. Unfortunately, it's been non-functional for a long while now, or I would use it.
Whenever I use the above module, the entire canvas goes gray and doesn't show anything. I've tried Find the Culprit, and even when it's the only module active, it still does that. I think the author has abandoned it, unfortunately.

Alright, I'll see what I can do.

This has been added in the latest version. Go to the actor's Shared Vision config, and enable 'Token'