[N4S] Rule isNegative | isPositive

Add a new enforce rule:
enforce(-5).isNegative() // ✅
enforce(5).isNegative() // 🚨

enforce(5).isPositive() // ✅
enforce(-5).isPositive() // 🚨

what should happen when:
enforce(0).isNegative() // ❓

or
enforce(0).isPositive() // ❓

Hey @sagivStekolshik, that's an excellent question.
The truth is that whether zero is positive or negative is context dependent, and sometimes it is regarded as neither.
This means that we can arbitrarily decide how we want to treat it.
For example, we could decide that in both cases it is false
enforce(0).isNegative() // false
enforce(0).isPositive() // false

or even treat it always as true
enforce(0).isNegative() // true
enforce(0).isPositive() // true

In our case, I think it would be most intuitive to start with the negative case:

negative is everything that's smaller than zero value < 0

So anything else would be considered as positive.
In that scenario 0 would be treated as positive.
The one exception is - how to deal with signed zero -0, because:
-0 === 0 // true
Object.is(-0, 0) // false

But since signed zero is so rare in js, it might not even worth looking at.

My idea was using Math.sign() to get the number or string(works as well)
sign function returns 0 or -0  according to MDN
so going the 0 -> false route will be easier
going the 0 isPositive number will be even easier as it can be the "negative" of isNegative

Hi @ealush
I would like to work on this issue.
Please assign to me. I already started working on it and is there any diagram or documentation to get started?
Thanks,

Is this issue still open?

@ganeshpatil0101

Hi @ealush
I would like to work on this issue.
Please assign to me. I already started working on it and is there any diagram or documentation to get started?
Thanks,

@zivkaziv

Is this issue still open?

Yes. No need to assign anyone, simply submit a pr and we'll get it merged 🙂

@zivkaziv I can see other unit tests are failing. does that expected ? I will add unit test for isNegative & isPositive and then raise pr.

@ealush @zivkaziv  unit tests are working fine. But on my local example of vest with vanilla is not working. I will check it. Thanks.

@ganeshpatil0101 do you have a branch you can share with those changes that do not work? I might be able to help.

@ealush Please review and merge the PR https://github.com/ealush/vest/pull/433
New unit tests are added & all tests are passed.
I request you to test this feature with one real example as I am having issues to setup a vest - vanilla example on local.
Please let me know you if there any changes required.
Thanks.


Improve search performance

Typing in two characters in the search bar starts a search that is slow?
Investigate why search is slow/why UI is jamming up.
Consider using moving the search to background?
Consider using lunr to index the text in routes?

Fixed in #489 and #490


Using moto with smart_open raises ValueError: file descriptor cannot be a negative integer (-1)

Creating a simple unit test case using smart_open
smart-open==1.5.5
moto==1.1.25
from unittest import TestCase

import boto
import smart_open
from moto import mock_s3_deprecated

class TestSimpleSmartOpen(TestCase):
    @mock_s3_deprecated
    def test_write_encoding(self):
        conn = boto.connect_s3()
        conn.create_bucket('bucket')
        key = "s3://bucket/key.txt"
        text = u'Hello there'

        with smart_open.smart_open(key, 'w', encoding='utf-8') as fout:
            fout.write(text)
        with smart_open.smart_open(key, encoding='utf-8') as fin:
            actual = fin.read()
        self.assertEqual(text, actual)

This raises an error
ValueError: file descriptor cannot be a negative integer (-1)

Old


Update POM with the latest dependencies

Which ones are you referring to in particolur @anuragknoldus? Should be coherent with our current  tests and plans

I have updated dependency version for powermock, junit, org.openjdk.jmh, neo4j-kernel, neo4j-harness and jackson.
I have sent PR also. You can refer that.

Just seen it. I'll have a look at it.
In the meantime could you please share with us your particular use case (if any).
We'd like to know how people are using the driver in order to better support you.

I am exploring Neo4j with Scala and in this process I started using Neo4j-jdbc and found Bolt and it looks so cool. I am just exploring it.

3.0 and 3.1 branches now have the latest ones.


Merge branch 'main' into gd-gas-proposal

Proposal to add GoodDollar (G$) as a gas token
Two proposals are created the first to add the oracle for the G$ celo price and the second is to add G$ as a gas token

@juanjgiraldoc @willkraft
i've modified the numbers to 85 and 88

@sirpy please rename files with 88 to 85 your proposal for Good Dollar is the number 85

@juanjgiraldoc done


feat: port CategoryTheory.Limits.Shapes.Terminal

[ ] depends on: #2368

This PR/issue depends on:

leanprover-community/mathlib4#2368
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#2368
By Dependent Issues (🤖). Happy coding!


[fix][broker] Fix Broker was failing to create producer with broken schema ledger

Motivation
When schema ledger is broken and producer tries to connect without schema then broker fails to add that producer with below error.
It fixes below errors
03:46:47.861 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.BrokerService - No autoTopicCreateOverride policy found for persistent://ncp/global/content.ncp/url_uuid_alias.prod
03:46:47.861 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://ncp/global/content.ncp/url_uuid_alias.prod] Storage size = [0], backlog quota limit
 [53687091200]
03:46:47.861 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage - [ncp/content.ncp/url_uuid_alias.prod] Fetching schema from store
03:46:47.862 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage - [ncp/content.ncp/url_uuid_alias.prod] Got schema locator Optional[org.apache.pulsar.broker.se
rvice.schema.BookkeeperSchemaStorage$LocatorEntry@2a675a45]
03:46:47.862 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage - Reading schema entry from ledgerId: 742584758
entryId: 0

03:46:47.862 [pulsar-io-4-63] DEBUG org.apache.pulsar.metadata.bookkeeper.PulsarLedgerManager - No such ledger: 742584758 at path /ledgers/07/4258/L4758
03:46:47.862 [pulsar-io-4-63] ERROR org.apache.bookkeeper.meta.CleanupLedgerManager - Failed on operating ledger metadata: -25
03:46:47.862 [pulsar-io-4-63] DEBUG org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage - [ncp/content.ncp/url_uuid_alias.prod] Get operation completed. res=null -- ex=java.util.concu
rrent.CompletionException: org.apache.pulsar.broker.service.schema.exceptions.SchemaException: No such ledger exists on Metadata Server -  ledger=742584758 - operation=Failed to open ledger

Modifications

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (bbc6224) to head (e8fddf0).
Report is 630 commits behind head on master.

Files with missing lines
Patch %
Lines

...rg/apache/pulsar/broker/service/AbstractTopic.java
66.66%
1 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23395      +/-   ##
============================================
+ Coverage     73.57%   74.59%   +1.02%
- Complexity    32624    34047    +1423
============================================
  Files          1877     1936      +59
  Lines        139502   145368    +5866
  Branches      15299    15895     +596
============================================
+ Hits         102638   108439    +5801
+ Misses        28908    28623     -285
- Partials       7956     8306     +350

Flag
Coverage Δ

inttests
27.76% <33.33%> (+3.18%)
:arrow_up:

systests
24.51% <33.33%> (+0.19%)
:arrow_up:

unittests
73.94% <66.66%> (+1.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...rg/apache/pulsar/broker/service/AbstractTopic.java
87.48% <66.66%> (-0.51%)
:arrow_down:

... and 615 files with indirect coverage changes

I am also adding email thread reply here

I want to revert this PR. Background: When the schemas of a topic are lost, all of the messages in the topic can not be consumed successfully, and producers can not publish messages anymore.

We must not revert this PR and broker must not allow topic unavailability in any cases and we can't rely on manual operational efforts to fix any topic server side issue
There are already many issues created related to the lost schema ledgers so, it is a very well-known issue that the topic becomes unavailable and producers are not able to publish messages anymore just because of server issues which is extremely critical for mission-critical usecases and not acceptable as well. Because of that brokers must be fault tolerant to recover in case of missing ledgers. Broker already handles such issues during manged-ledger or managed-cursor legers but it should also handle in case of schema ledger as well and make sure that broker won't impact topic's unavailability. It is also very important to just not rely on operational effort to fix such unavailability issues manually but broker should have a mechanism to recover by itself,
Therefore, this PR is important to make sure tenants don't face topic unavailability due to well known issues of missing schema ledgers.

@rdhabalia
Answered in discussion channel, we should do this. User can delete the broken schemas manually if they wanted

Discussion channel<EMAIL_ADDRESS>

User can delete the broken schemas manually when they received such error if they wanted

First of all user can't delete ledgers from the metadata store as ledger concept has to be abstract to user. System admin may be able to delete such ledgers but that is not possible for the systems which is running millions of topics and this issue is happening with multiple ledgers at the same time and manual efforts are not possible to address this issue.

created PR: https://github.com/apache/pulsar/pull/23428 it will switch back to previous behavior unless force-flag is configured and ledger error is non-recoverable.


[eks] EoL for 1.18 changed

@captn3m0 could you also update versions info within this pr?
I mean 1.21.5 , 1.20.11 , 1.19.15 , 1.18.20 is latest versions of this product

The EKS website mentions 1.21.2 etc https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html#available-versions.
What page are you checking against?

https://docs.aws.amazon.com/eks/latest/userguide/platform-versions.html

I don't think 1.21.3 is actually available (See this open issue on the roadmap for eg https://github.com/aws/containers-roadmap/issues/1499)
That document is probably future proofing. I'll double check on this, but going to merge this for now. Will file a second PR if needed.


Support uploading big files using a browser

I'm trying to upload video of size 2GB and webpage show me error just after few second
Could not create the task
Error: Network Error.
and I've checked it works with videos of size 100mb

@korabelnikov
Hi, what error can you see in the Browser Console?
Try to use share functionality.
Similar issue: #799

Failed to load resource: the server responded with a status of 413 (Request Entity Too Large)
create:1
Access to XMLHttpRequest at 'http://localhost:8080/api/v1/tasks/8/data' from origin 'http://localhost:7080' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
cvat-app.tsx:145 Error: Network Error.

I suppose it's not an enhancement but real bug

@korabelnikov , in the particular case your problem isn't connected with the size of data. The request is blocked by CORS policy. There are settings in CVAT which you need to adjust.
# Cross-Origin Resource Sharing settings for CVAT UI
UI_SCHEME = os.environ.get('UI_SCHEME', 'http')
UI_HOST = os.environ.get('UI_HOST', 'localhost')
UI_PORT = os.environ.get('UI_PORT', '3000')
CORS_ALLOW_CREDENTIALS = True
CSRF_TRUSTED_ORIGINS = [UI_HOST]
UI_URL = '{}://{}'.format(UI_SCHEME, UI_HOST)
if len(UI_URL):
    UI_URL += ':{}'.format(UI_PORT)

CORS_ORIGIN_WHITELIST = [UI_URL]
CORS_REPLACE_HTTPS_REFERER = True

Thank you! Maybe it worse to add this adjustment as default?

@korabelnikov
Actually, default settings from current develop branch are expected to work.
It wasn't stable for some short time, but now it must be.

@bsekachev I've checkout this repo just a few days ago

@korabelnikov
Anyway. Try rebuld and clean the browser cache just in case.
CORS messages aren't expected to appear in default settings.
What about code 413 (Request Entity Too Large), CVAT never supports large files uploading via a browser. We use "shared" functionality to do it. But I agree it make sense to implement better approach of uploading.

I get, just simple message that shows "CVAT doesn't support large file uploading, use shared folder functionality instead" will be helpfull

@korabelnikov
Great idea!

@bsekachev
But I don't know how to use shared folder function. Is there any guide for doing this?

https://github.com/openvinotoolkit/cvat/pull/3692


Teams Support 1000 participants

[the article shows 300 participants can join the audio/video calls in teams meetings, now it is changed to 1000 Participants]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 905e2c09-ef3e-07cc-0809-6ff171157c47
Version Independent ID: c0d33162-183d-fff8-32e9-a999f391ea51
Content: Limits and specifications for Microsoft Teams - Microsoft Teams
Content Source: Teams/limits-specifications-teams.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

Technically it's still 300.  With the Advanced Communications add-on license you can have up to 1000 interactive participants and 20k view-only participants in overflow.

@zubisultan79 Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Installing a python package from Azure DevOps Artifacts feed in python:3.9-slim

I am currently working on python:3.9-slim docker image and trying to install  a private python package from Azure DevOps Artifacts feed which is using  azure-servicebus and azure-data-tables , and I got the following error.  I followed the instruction in the issue #27902 but did not succeed. Could you help me to resolve this issue ?
#13 42.22   error: subprocess-exited-with-error
#13 42.22
#13 42.22   × Building wheel for uamqp (pyproject.toml) did not run successfully.
#13 42.22   │ exit code: 1
#13 42.22   ╰─> [103 lines of output]
#13 42.22       running bdist_wheel
#13 42.22       running build
#13 42.22       running build_py
#13 42.22       creating build
#13 42.22       creating build/lib.linux-aarch64-cpython-39
#13 42.22       creating build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/types.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/message.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/mgmt_operation.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/__init__.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/session.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/compat.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/utils.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/sender.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/client.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/connection.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/address.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/errors.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/receiver.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       copying uamqp/constants.py -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       creating build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/client_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/sender_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/__init__.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/utils.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/receiver_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/connection_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/session_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       copying uamqp/async_ops/mgmt_operation_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/async_ops
#13 42.22       creating build/lib.linux-aarch64-cpython-39/uamqp/authentication
#13 42.22       copying uamqp/authentication/__init__.py -> build/lib.linux-aarch64-cpython-39/uamqp/authentication
#13 42.22       copying uamqp/authentication/cbs_auth_async.py -> build/lib.linux-aarch64-cpython-39/uamqp/authentication
#13 42.22       copying uamqp/authentication/cbs_auth.py -> build/lib.linux-aarch64-cpython-39/uamqp/authentication
#13 42.22       copying uamqp/authentication/common.py -> build/lib.linux-aarch64-cpython-39/uamqp/authentication
#13 42.22       running egg_info
#13 42.22       writing uamqp.egg-info/PKG-INFO
#13 42.22       writing dependency_links to uamqp.egg-info/dependency_links.txt
#13 42.22       writing requirements to uamqp.egg-info/requires.txt
#13 42.22       writing top-level names to uamqp.egg-info/top_level.txt
#13 42.22       reading manifest file 'uamqp.egg-info/SOURCES.txt'
#13 42.22       reading manifest template 'MANIFEST.in'
#13 42.22       writing manifest file 'uamqp.egg-info/SOURCES.txt'
#13 42.22       copying uamqp/c_uamqp.c -> build/lib.linux-aarch64-cpython-39/uamqp
#13 42.22       warning: build_py: byte-compiling is disabled, skipping.
#13 42.22
#13 42.22       running build_ext
#13 42.22       will build uamqp in build/temp.linux-aarch64-cpython-39/cmake
#13 42.22       Building with generator flags: -G "Unix Makefiles"
#13 42.22       calling cmake /tmp/pip-install-5mjpe1c0/uamqp_72f3c6a3ba2c4d9aaad785ccfa682892/src/vendor/azure-uamqp-c/ -G "Unix Makefiles" -Duse_openssl:bool=ON -Duse_default_uuid:bool=ON  -Duse_builtin_httpapi:bool=ON  -Dskip_samples:bool=ON -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE -DCMAKE_BUILD_TYPE=Release
#13 42.22       CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
#13 42.22       CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
#13 42.22       CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
#13 42.22       -- Configuring incomplete, errors occurred!
#13 42.22       See also "/tmp/pip-install-5mjpe1c0/uamqp_72f3c6a3ba2c4d9aaad785ccfa682892/build/temp.linux-aarch64-cpython-39/cmake/CMakeFiles/CMakeOutput.log".
#13 42.22       Traceback (most recent call last):
#13 42.22         File "/usr/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
#13 42.22           main()
#13 42.22         File "/usr/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
#13 42.22           json_out['return_val'] = hook(**hook_input['kwargs'])
#13 42.22         File "/usr/local/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 249, in build_wheel
#13 42.22           return _build_backend().build_wheel(wheel_directory, config_settings,
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 413, in build_wheel
#13 42.22           return self._build_with_temp_dir(['bdist_wheel'], '.whl',
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 398, in _build_with_temp_dir
#13 42.22           self.run_setup()
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 484, in run_setup
#13 42.22           super(_BuildMetaLegacyBackend,
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 335, in run_setup
#13 42.22           exec(code, locals())
#13 42.22         File "<string>", line 260, in <module>
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/__init__.py", line 87, in setup
#13 42.22           return distutils.core.setup(**attrs)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 185, in setup
#13 42.22           return run_commands(dist)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
#13 42.22           dist.run_commands()
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
#13 42.22           self.run_command(cmd)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
#13 42.22           super().run_command(command)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
#13 42.22           cmd_obj.run()
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/wheel/bdist_wheel.py", line 325, in run
#13 42.22           self.run_command("build")
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
#13 42.22           self.distribution.run_command(command)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
#13 42.22           super().run_command(command)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
#13 42.22           cmd_obj.run()
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/command/build.py", line 132, in run
#13 42.22           self.run_command(cmd_name)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
#13 42.22           self.distribution.run_command(command)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
#13 42.22           super().run_command(command)
#13 42.22         File "/tmp/pip-build-env-0625zamf/overlay/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
#13 42.22           cmd_obj.run()
#13 42.22         File "<string>", line 134, in run
#13 42.22         File "<string>", line 183, in build_cmake
#13 42.22         File "/usr/local/lib/python3.9/subprocess.py", line 373, in check_call
#13 42.22           raise CalledProcessError(retcode, cmd)
#13 42.22       subprocess.CalledProcessError: Command 'cmake /tmp/pip-install-5mjpe1c0/uamqp_72f3c6a3ba2c4d9aaad785ccfa682892/src/vendor/azure-uamqp-c/ -G "Unix Makefiles" -Duse_openssl:bool=ON -Duse_default_uuid:bool=ON  -Duse_builtin_httpapi:bool=ON  -Dskip_samples:bool=ON -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE -DCMAKE_BUILD_TYPE=Release' returned non-zero exit status 1.
#13 42.22       [end of output]
#13 42.22
#13 42.22   note: This error originates from a subprocess, and is likely not a problem with pip.
#13 42.22   ERROR: Failed building wheel for uamqp
#13 42.22   Building wheel for pendulum (pyproject.toml): started
#13 42.68   Building wheel for pendulum (pyproject.toml): finished with status 'done'
#13 42.68   Created wheel for pendulum: filename=pendulum-2.1.2-cp39-cp39-manylinux_2_31_aarch64.whl size=109777 sha256=cbfa9857e677d214e7cb92aa9238c5b3d6d648a8de97e9cfb17076057faf65f8
#13 42.68   Stored in directory: /root/.cache/pip/wheels/76/ce/18/d6d0ab24c15c9e8460b0657def1382c9b299c3d44622d1d1f4
#13 42.68   Building wheel for snaptime (setup.py): started
#13 43.10   Building wheel for snaptime (setup.py): finished with status 'done'
#13 43.11   Created wheel for snaptime: filename=snaptime-0.2.4-py3-none-any.whl size=3593 sha256=6e5c7372124cc54f87e631447ef35ed599a89133ba32f60083fedd39f10377de
#13 43.11   Stored in directory: /root/.cache/pip/wheels/13/bd/2b/a5534e04a0b2b4a49f7ce54265458e0f3987d35b4bce59cd40
#13 43.11   Building wheel for validate-email (setup.py): started
#13 43.51   Building wheel for validate-email (setup.py): finished with status 'done'
#13 43.51   Created wheel for validate-email: filename=validate_email-1.3-py3-none-any.whl size=5482 sha256=0d0eb1be70b2f2b82c8d566bbf425f051278ba87ebdc4c1c94a6c5e56ab18e91
#13 43.51   Stored in directory: /root/.cache/pip/wheels/b2/3f/33/dde9e091e4bd6b23f693279a5b0a62701a078bdf990e9d73f5
#13 43.51 Successfully built pytest-mockito pytest-pythonpath pendulum snaptime validate-email
#13 43.51 Failed to build uamqp
#13 43.51 ERROR: Could not build wheels for uamqp, which is required to install pyproject.toml-based projects
------
executor failed running [/bin/bash -c pip install dist/*.whl --extra-index-url=PIP_EXTRA_INDEX_URL]: exit code: 1```

Hi @dvu4, thank for your feedback. Is the docker for arm linux, since I am seeing linux-aarch64 in the logs?

@kashifkhan, yes the docker is created using debian

@dvu4 unfortunately uamqp is not supported on the ARM platform. and thats why its not building. If you are able to switch over to x86 then the instructions from the other issue will apply. A debian based image x86 would not need the compilation step.
My team is currently working to replace uamqp with a pure python implementation which will remove the need for compilation but that is a few months away.


[FEAT] Add ability to override chat user icon and name in embedded chat widget

Pull Request Type

[x] ✨ feat
[ ] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues

resolves #1058
What is in this change?
Describe the changes in this PR that are impactful to the repo.

Add support for "data-assistant-name" and "data-assistant-icon" attributes for embedded chat widget

Additional Information
Add any other context about the Pull Request here that was not captured above.
Developer Validations

[x] I ran yarn lint from the root of the repo & committed changes
[x] Relevant documentation has been updated
[x] I have tested my code functionality
[x] Docker build succeeds locally

Looks good, can you yarn lint and yarn build:publish in the embed folder so the new version is committed?


Frontend/feat/error boundary

Let me know if tests would be needed for some part of this PR.
I didn't find an api endpoint for logging errors to our backend, is that correct?

Fixes #1082


Loading session on account page

Loading session on account page
Issue Number(s): #150
Redirects to login if fetching the current user fails
Checklist

[ ] Requirements have been implemented
[ ] Acceptance criteria is met
[ ] Database schema docs have been updated or are not necessary
[ ] Relevant reviewers (EM) have been assigned to this PR

Critical Changes

Database change / migration to run
Environment config change
Breaking API change

Related PRs
PR Number(s): #number_of_pr
How To Test
The steps to test the functionality of your ticket. Include edge cases and testing of error handling, if applicable.

Fixed by #215


Fix/app crashing because of wrong vc hierarchy

Fix: App Crashing Due to Wrong View Controller Hierarchy
Changes

Enhancements:

Added UIApplication+CurrentViewController category for getting currentViewController.
Updated BrightcoveIMAPlayerView to use the new category.
Added TestHost to host unit tests requiring UIApplication.

Cleanup and Reorganization:

Removed unused adDisplayView and adResumeButton.
Removed fullScreenCloseBtn and fullscreen logic.
Removed the logic for forcing fullscreen mode for the Ad.
Reorganized BrightcoveIMAPlayerView for readability.
Removed commented-out code.

Updates:

Bumped library version to 2.3.6.
Updated react-native from 0.63.4 to 0.68.0.
Added bob to simplify building the React Native library.
Added patch-package to patch iOS codebase issues.
Updated dependencies to match the latest feature branch.

Exclusions:

Excluded BrightcoveImaPlayerTest.
Excluded tests from the podspec.

The initial fix was searching for the top View Controller and attaching the AdView to it and it was running for an article with 1 Video

When there are 2 videos, first video will get added correctly, but for the second video it will try to be added to the top ViewController which is the first AdView , that’s why the app was crashing.

I have updated my fix to search for the first Non-AdView View Controller, and it’s working now.


Bash script with embedded control M characters in strings becomes corrupted

VS Code Version: 1.56.0
OS Version: macOS 11.3

Steps to Reproduce:

Edit a bash shell script in Unix format (LF line endings) that contains CR characters embedded in strings.
Save the file.
Notice that the CR characters have been replaced with LF characters, thus corrupting the script and causing it to no longer function.

Does this issue occur when all extensions are disabled?: Yes
Edit the attached build_parts_catalog.txt in VS Code, then simply save without doing anything else. Then compare to the original file, and notice that the file is now different in ways that cause it to no longer function. (I doubt you can run the shell script, but if you just look at the result, you will be able to see that it will no longer function.)
build_parts_catalog.txt
I understand that VS Code tries to fix line endings in files. However, a lone CR character in a string in a shell script is not intended to be a line ending, and is (correctly) not treated as a line ending by vim (for example).

I acknowledge the problem. This was an intentional design choice in order to cover as many files on as many Operating Systems as possible, while having also happy lives :). The problem comes from using a multi-process architecture, with language servers written in other programming languages or by 3rd parties and with desiring to ship on multiple OS's.
VS Code often communicates with language servers using (line;char) based positions, so for example when triggering jump to definition on a symbol, the language server will typically return the URI of the file to jump to and the line number and character where the symbol is defined. The file to jump to is oftentimes not even loaded by VS Code until the actual jump occurs. But what exactly is a line? Well, sometimes even staying on the same platform can be problematic, as programming languages don't quite agree on what should be a line terminator, see https://github.com/microsoft/vscode/issues/96142 .
Although with serious drawbacks (like the one you run into of not being able to have a CR in a file/language where CR is not a line terminator), we have opted to recognize CRLF, CR and LF as line terminators indiscriminately in all files, irrespective of programming language and irrespective of OS. We do this in all processes and we have specified that to be our behavior such that language servers can build on our definition of what a line is and return consistent positions.
Again, this is not 100% correct and I am sorry about that, but this is not something we would want to address.


Corrected Word movement "e" example

Suggesting tiny improvement of user manual.
Also checking that this reporting workflow would work.
Thanks for a great app, regards, --pj

These used to be pictures in the book, a bit hard to translate to ASCII.  I think only one "ge" command should be "2ge".  The rest is more about making clear what the characters mean.  i'll update it a bit.


getting error while installing

error logs
/Users/../Documents/work/ReactNative/work/../node_modules/react-native-esc-pos-printer: Command failed.
Exit code: 1
Command: node ./scripts/movelib.js
Arguments:
Directory: /Users/../Documents/work/ReactNative/work/../node_modules/react-native-esc-pos-printer
Output:
internal/modules/cjs/loader.js:905
throw err;
^
Error: Cannot find module '/Users/../Documents/work/ReactNative/work/../node_modules/react-native-esc-pos-printer/scripts/movelib.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
at Function.Module._load (internal/modules/cjs/loader.js:746:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
at internal/main/run_main_module.js:17:47 {

Fixed in v1.7.1

hi @tr3v3r  what is the major difference in v1.5.0 between v1.7.1

@devudr the only difference is that SDK for iOS is moved to a separate repo.


Add support for selecting table rows

I ended up using Grid.select() api, but it would be nice if there was support in karibu for this type of operation.

I'm striving here to provide testing support only (say an assert on the current selection state) rather than to complement the existing API. So you should use an existing grid API if you wish rows to being selected.
With that being said, it could be so that an useful selection function is missing which would help with the testing. Could you please provide details on your use case, and what kind of selection method you are missing and why the current ones are lacking?


Pull Request

Sirfetch\u2019d to Sirfetch'd
Kadabra cannot mega, transfer it to Alakazam
added url.json file, which stores the pokemon image url
added image for type: null
fixed beedril, hes missing an 'l'
fix names with replace for type null, reason being filenames cannot have ':'
adds lines to pokecord.py initialize function to add in url to self.pokemondata

The sir fetchd unicode was actually just the unicode representation of a ' so that one actually never mattered 😅
Otherwise I haven't tested this but I trust it by the amount of commits kek

oh no, i cannot stress enough, somehow they're actually different
they were '  and ’
sirfetch’d and farfetch'd had different 's
one of them is 0027 and another 2019


Add support for filesystem-based SBOM.

Summary

Add support for filesystem-based SBOM, in addition to the existing metadata-label-based BOM, in order to conform with: Paketo RFC0038.
Closes #32
Note: we also added CPEs for poetry as that is a requirement of the upstream SBOM library. This will be added automatically once https://github.com/paketo-buildpacks/dep-server/pull/153 is merged.
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Hey @paketo-buildpacks/python-maintainers! I'm reviewing this PR because its similar to others I've recently reviewed and seems like a time-saver since I have context. Feel free to also review it if you see fit!
I'm not a maintainer, but I am a contributor. I have also worked on a number of similar PRs to implement filesystem SBOM in other buildpacks (example), as well as reviewed a number of related PRs (example).

@paketo-buildpacks/python-maintainers FYI it looks like the codeowners weren't automatically requested for review on this PR so you might need to turn that on in repo settings


Indexes with ignoreNullValues cause errors on new nodes in distributed mode

This error prevents being able to use indexes with { ignoreNullValues: false } when in distributed mode.
Start 3 servers in distributed mode (core-1, core-2, core-3)
CREATE DATABASE remote:<IP_ADDRESS>/testdatabase root root plocal graph

Wait for database to sync across 3 nodes. Then...
CONNECT remote:<IP_ADDRESS>/testdatabase root root
CREATE CLASS Person extends V
CREATE PROPERTY Person.name STRING
CREATE INDEX Person.name NOTUNIQUE METADATA { ignoreNullValues: false }

Then start node 4 and wait for database to sync across to new node (core-4). Then...
CONNECT remote:<IP_ADDRESS>/testdatabase root root

CREATE VERTEX Person SET name = 'Tobie'
# Created vertex 'Person#28:0{name:Tobie} v1' in 0.077000 sec(s).
# This query works fine

CREATE VERTEX Person SET temp = true
# Created vertex 'Person#28:1{temp:true} v1' in 0.068000 sec(s).
# This query causes the error, probably because it does not have a 'name' field

However an error occurs on the new node, and the data is now out of sync on the servers.
Error on distributed transaction commit
com.orientechnologies.orient.core.index.sbtree.local.OSBTreeException: Null keys are not supported.
   at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.checkNullSupport(OSBTree.java:769)
   at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.get(OSBTree.java:185)
   at com.orientechnologies.orient.core.index.engine.OSBTreeIndexEngine.get(OSBTreeIndexEngine.java:226)
   at com.orientechnologies.orient.core.index.OIndexMultiValues.putInSnapshot(OIndexMultiValues.java:162)
   at com.orientechnologies.orient.core.index.OIndexAbstract.applyIndexTxEntry(OIndexAbstract.java:1025)
   at com.orientechnologies.orient.core.index.OIndexAbstract.addTxOperation(OIndexAbstract.java:690)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic$CommitIndexesCallback.run(OTransactionOptimistic.java:98)
   at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.commit(OAbstractPaginatedStorage.java:922)
   at com.orientechnologies.orient.server.distributed.ODistributedStorage.commit(ODistributedStorage.java:802)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic.doCommit(OTransactionOptimistic.java:483)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic.commit(OTransactionOptimistic.java:147)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2376)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2346)
   at com.orientechnologies.orient.server.distributed.task.OTxTask.execute(OTxTask.java:111)
   at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.executeOnLocalNode(OHazelcastPlugin.java:757)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:300)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.run(ODistributedWorker.java:121)
[core-4] error on executing request 65 (tx) on local node:
com.orientechnologies.orient.core.index.sbtree.local.OSBTreeException: Null keys are not supported.
   at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.checkNullSupport(OSBTree.java:769)
   at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.get(OSBTree.java:185)
   at com.orientechnologies.orient.core.index.engine.OSBTreeIndexEngine.get(OSBTreeIndexEngine.java:226)
   at com.orientechnologies.orient.core.index.OIndexMultiValues.putInSnapshot(OIndexMultiValues.java:162)
   at com.orientechnologies.orient.core.index.OIndexAbstract.applyIndexTxEntry(OIndexAbstract.java:1025)
   at com.orientechnologies.orient.core.index.OIndexAbstract.addTxOperation(OIndexAbstract.java:690)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic$CommitIndexesCallback.run(OTransactionOptimistic.java:98)
   at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.commit(OAbstractPaginatedStorage.java:922)
   at com.orientechnologies.orient.server.distributed.ODistributedStorage.commit(ODistributedStorage.java:802)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic.doCommit(OTransactionOptimistic.java:483)
   at com.orientechnologies.orient.core.tx.OTransactionOptimistic.commit(OTransactionOptimistic.java:147)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2376)
   at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2346)
   at com.orientechnologies.orient.server.distributed.task.OTxTask.execute(OTxTask.java:111)
   at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.executeOnLocalNode(OHazelcastPlugin.java:757)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:300)
   at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.run(ODistributedWorker.java:121)

2015-03-17 02:42:48:468 WARNING [core-4] detected 1 conflicts, but the quorum (2) has been reached. Fixing remote records. Request (id=65 from=core-4 task=tx userName=) [ODistributedResponseManager]

NOTE:

The index is fine and works correctly before the new node (core-4) is added to the cluster.
If the index is defined as CREATE INDEX Person.name NOTUNIQUE without the METADATA { ignoreNullValues: false } then the error does not occur.

OrientDB version: 2.0.5

This still exists in OrientDB Version 2.0.6 and 2.0.7
The bug removes the possibility of using indexes with ignoreNullValues in a distributed setup. The bug prevents being able to add a database on 1 node, and then start up other nodes in distributed setup.
Rebuilding ALL of the indexes on ALL of the servers does not fix the issue.
If you try to create a vertex/edge which belong to a class which has an ignoreNullValues index then the following error will appear...
orient|com.orientechnologies.orient.core.index.sbtree.local.OSBTreeException: Null keys are not supported.
orient|	at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.checkNullSupport(OSBTree.java:769)
orient|	at com.orientechnologies.orient.core.index.sbtree.local.OSBTree.get(OSBTree.java:185)
orient|	at com.orientechnologies.orient.core.index.engine.OSBTreeIndexEngine.get(OSBTreeIndexEngine.java:226)
orient|	at com.orientechnologies.orient.core.index.OIndexMultiValues.putInSnapshot(OIndexMultiValues.java:162)
orient|	at com.orientechnologies.orient.core.index.OIndexAbstract.applyIndexTxEntry(OIndexAbstract.java:1025)
orient|	at com.orientechnologies.orient.core.index.OIndexAbstract.addTxOperation(OIndexAbstract.java:690)
orient|	at com.orientechnologies.orient.core.tx.OTransactionOptimistic$CommitIndexesCallback.run(OTransactionOptimistic.java:98)
orient|	at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.commit(OAbstractPaginatedStorage.java:922)
orient|	at com.orientechnologies.orient.server.distributed.ODistributedStorage.commit(ODistributedStorage.java:811)
orient|	at com.orientechnologies.orient.core.tx.OTransactionOptimistic.doCommit(OTransactionOptimistic.java:483)
orient|	at com.orientechnologies.orient.core.tx.OTransactionOptimistic.commit(OTransactionOptimistic.java:147)
orient|	at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2406)
orient|	at com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx.commit(ODatabaseDocumentTx.java:2376)
orient|	at com.orientechnologies.orient.server.distributed.task.OTxTask.execute(OTxTask.java:113)
orient|	at com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin.executeOnLocalNode(OHazelcastPlugin.java:772)
orient|	at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.onMessage(ODistributedWorker.java:300)
orient|	at com.orientechnologies.orient.server.hazelcast.ODistributedWorker.run(ODistributedWorker.java:121)

Anyone have any idea how to get round this?

Hi @lvca - any possibility of this being marked as a bug?

Is there any latest info on this issue?

I created this test case and everything works: https://github.com/orientechnologies/orientdb/commit/f97cccb32860eedf8cda7b54983761290488a305. I don't know if this has been fixed in 2.1-SNAPSHOT (develop branch). Could you please try with 2.1-SNAPSHOT?

The issue has been closed because no response has been received after a while. In case the issue is still valid, please reopen it or write a comment that explains why it's still valid and a way to reproduce it. Thank you.

I ran into this exact issue in version 2.1.15. I have the following schema.
{
   "@type":"d",
   "@rid":"#15:147",
   "@version":1,
   "@class":"MToken",
   "user":"#12:3",
   "expiration":1460820192,
   "lastUsed":1460776992,
   "description":null,
   "token":"3_26j8C0fvxyiyJg2-b_nie1ynSRA-1QldkEb2cKGmA",<-- unique non-null Index on this field
   "created":1460776992,
}

{
   "@type":"d",
   "@rid":"#12:3",
   "@version":160,
   "@class":"MUser",
<EMAIL_ADDRESS>   "firstName":"Sample",
   "lastName":"User",
   "enabled":true,
   "properties":{
   },
   "created":1460614838,
   "loginDate":1460776984,
   "tokens":[
     <null>, <-- reference to deleted record
     ...
     <null>, <-- reference to deleted record
      "#15:147"
   ],
}

My Token and user objects have a circular reference that is enforced by java hooks. My application works perfectly when not running in distributed mode. When I enable distributed mode I got the same exception as @tobiemh. I was also getting zero records returned when I would query my Token.token index, or run the following query.
SELECT FROM MToken where token = '3_26j8C0fvxyiyJg2-b_nie1ynSRA-1QldkEb2cKGmA'
What I eventually figured out is that some of my User objects had references to deleted tokens in the tokens embedded link set due to deleted records that escaped my AFTER_DELETE hook. Once I removed these null links with the following command, distributed mode started working correctly.
update MUser remove tokens = null
The rebuild index functionality seems to be attempting to index these null references when in distributed mode.


[VFS-497] Ported filters from Commons IO

https://issues.apache.org/jira/browse/VFS-497

@ecki @garydgregory Any opinion on this?

I do not like it. Commons CVS is already a kitchen sink of sorts, so would just centralize all filters in Commons IO and make VFS depend on IO.

Darn autocomplete! I meant VFS, not CSV.

I checked this option before I decided to port the code to VFS. Unfortunately commons IO filter uses the Java type File all over the place. You would need to make an incompatible change to the commons io code or create a new package for it. So, I'd suggest just to merge the (three years old) code.

It's a bit heavyweight and I had no need for those filters however I like the fact that the patch does not add a dependency, so it is fine with me. Will merge it.

Great. Go ahead!

Merged with some changes.


Vitomu: Add version 2.1.0

[x] I have read the Contributing Guide.

No persist and no bin. It's a standard Electron-based app.

/verify


Foreing fields in mytableRepository

Hello.
I have a Reservations table that basically "confirms" a registry by editing one of its fields from false to true.
This table contains a foreing key from my Users table (UserID), so I can access User's fields like UserName and UserEmail in my Reservations grid and form.
When a registry is confirmed, an email needs to be sent to the user that applied for the reserve.
I already implemented that logic in mysavehandler in myReservationsRepository, but I can't access all the foreing fields I need from there.
Fields like myRow.UserId are ok, but fields like myRow.UserName or myRow.UserEmail always bring null values.
Is there a way I can get these values in mytableRepository so I can use them?
Thanks in advance for your help.

Override PrepareQuery and select them

Something like this?
protected override SqlQuery PrepareQuery()
{
            var query = new SqlQuery();
            query.Select(fld.Username);
            query.Select(fld.UserEmail);
            return base.PrepareQuery();
        }

base.PrepareQuery(query);
query.Select(fld.SomeField);

It says "No overload for method "PrepareQuery" takes 1 argument.
I was trying something like:
base.PrepareQuery();
var query = new SqlQuery().From(Row)
.Select(fld.SomeField);
return query;
And it works, but I have to select all the table fields as well.
The problem with that query is that it brings this error when one registry is edited:  Query affected 0 rows while 1 expected!
I suspect the reason is the Old.Fields, since they bring null values with the new query.
I tried to change this line:   var query = new SqlQuery().From(Old)
And it brings the old values but from another registry, so I guess I just need to add a condition, something like  .WhereEqual(fld.IdField, Old.IdField).
Please, let me know if I am wrong or if I need to do something else.
Thanks in Advance for your answer.

sorry, base.PrepareQuery().Select(fld.SomeField)
SaveHandler has a different PrepareQuery

Someone can put an example of how to get foreign fields before performing an update. ?
Thanx


harfbuzz: 2.3.1 -> 2.5.0

Motivation for this change
We skipped 2.4.0 due to upstream repeatedly (!) changing the tarball,
hopefully that's over now :3.
https://github.com/harfbuzz/harfbuzz/releases/tag/2.5.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Been working well here, glad for the upgrade! Darwin failure is in much earlier dependency, handing off to builders that will see it through :).


FIDO2 MakeCredential Failed

Hi Yubico,
I'm encoutering the problem when trying to run example code from the yesdk fido2 documentation. The keycollector delegate always point to KeyEntryRequest.VerifyFido2Pin request. After 3 times input the PIN (i had set this before using YubiKey Manager), i got this exception Yubico.YubiKey.Fido2.Fido2Exception: 'The comand failed to complete.'
Here is the stacktrace :
at Yubico.YubiKey.Fido2.Fido2Session.TryVerifyPin(ReadOnlyMemory1 currentPin, Nullable1 permissions, String relyingPartyId, Nullable1& retriesRemaining, Nullable1& rebootRequired)
at Yubico.YubiKey.Fido2.Fido2Session.TryVerifyPin(Nullable1 permissions, String relyingPartyId)    at Yubico.YubiKey.Fido2.Fido2Session.VerifyPin(Nullable1 permissions, String relyingPartyId)
at Yubico.YubiKey.Fido2.Fido2Session.AddPermissions(PinUvAuthTokenPermissions permissions, String relyingPartyId)
at Yubico.YubiKey.Fido2.Fido2Session.GetAuthToken(Boolean forceNewToken, PinUvAuthTokenPermissions permissions, String relyingPartyId)
at Yubico.YubiKey.Fido2.Fido2Session.MakeCredential(MakeCredentialParameters parameters)
My app is targeting .NET6.0, and will run on Linux machine. But currently i'm trying it on windows first.
If there is further guide about this topic, that's would be great. Thanks in advance.

It sounds like PIN collection is not working properly.
The YubiKey will require a reboot (of the key) prior to allowing more than 3 consecutive PIN retries. That is likely what the exception you are getting is trying to tell you.
Are you remembering to convert your PIN from string form to byte form using Encodings.UTF8.GetBytes() or something similar? If your PIN is "123456" in YubiKey Manager, the value you should pass to the key collector is the result of Encodings.UTF8.GetBytes("123456") and not byte[] { 1, 2, 3, 4, 5, 6 }

Hi Greg,
Thanks for your respons, i'm currently using the utility from Yubico.Core.Buffers namesapce , or should i use UTF8 encoding instread? and if it succeed, is there any information from the makecredential() method that i should save, so i can use it in makeassertion() method?
But i will try your suggestion and report it  soon. (my office is on long weekend mode now).
here is the snippet code i'm currently use for demo.
case KeyEntryRequest.VerifyFido2Pin:
                    {
                        Console.WriteLine($"Enter your PIN and hit enter: ");
                        string input = Console.ReadLine();
                        arg.SubmitValue(Hex.HexToBytes(input).ToArray());
                        return true;
                    }

Thanks.

Yes. You almost certainly should be using Encoding.UTF8.GetBytes. That is what would match the YubiKey Manager behavior.
I don't believe you will need anything from MakeCredential in GetAssertion for most cases. However, you do need to send the MakeCredentialData back to whatever system is acting as your "Relying Party" in order to verify that the credential creation was successful and no alterations or tampering has occurred.
You can read more about the FIDO2/Webauthn flow from the relying party's perspective here: https://www.w3.org/TR/webauthn-2/#sctn-op-make-cred

OK, thanks Greg, i get it now. I'll close this issue for now.


Fix integration test "Interaction in js-colors.pdf must change colors"

Introduction date: February 20, 2021
Introduction PR: https://github.com/mozilla/pdf.js/commit/4a5f1d1b7aa0e0576fc21c455555bb0923978186 (/cc @calixteman)
Type: intermittent (sometimes it works, indicating a possible timing/waiting issue)
OS: Windows
Logs: http://<IP_ADDRESS>:8877/972b6fbf01d54b8/output.txt
Traceback:
Failures:
2) Interaction in js-colors.pdf must change colors
  Message:
    Error: Timeout - Async function did not complete within 30000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
  Stack:
        at <Jasmine>
        at listOnTimeout (node:internal/timers:569:17)
        at process.processTimers (node:internal/timers:512:7)

Closing since I haven't seen this one show up anymore, and it could be that the other fixes we did also fixed this one. Moreover, the tweaked protocol error timeout should make sure that if this ever fails again we'll have more information than just the Jasmine timeout because the protocol error will now be raised in time and in scope of the test. If it happens again we can simply reopen it when we have more context, but for now there doesn't appear to be more we can do here.


Update README.md

Made a few minor grammar fixes that stuck out in the README.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Agunderman10 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #836 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   17.33%    17.4%   +0.06%
==========================================
  Files         222      222
  Lines      137798   137798
  Branches    12199    12199
==========================================
+ Hits        23893    23984      +91
  Misses     112876   112876
+ Partials     1029      938      -91

Flag
Coverage Δ

#2017
17.4% <ø> (+0.06%)
:arrow_up:

#Debug
17.4% <ø> (+0.06%)
:arrow_up:

#Release
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/PerfView/StackViewer/StackWindow.xaml.cs
24.83% <0%> (-0.13%)
:arrow_down:

src/PerfView/StackViewer/PerfDataGrid.xaml.cs
33.92% <0%> (ø)
:arrow_up:

...c/TraceEvent/Parsers/ClrPrivateTraceEventParser.cs
19.12% <0%> (+0.03%)
:arrow_up:

src/TraceEvent/TraceLog.cs
60.26% <0%> (+0.08%)
:arrow_up:

src/TraceEvent/DynamicTraceEventParser.cs
66.34% <0%> (+0.12%)
:arrow_up:

src/TraceEvent/TraceEvent.cs
63.05% <0%> (+0.13%)
:arrow_up:

src/TraceEvent/ETWTraceEventSource.cs
46.05% <0%> (+0.19%)
:arrow_up:

src/TraceEvent/Parsers/TplTraceEventParser.cs
48.94% <0%> (+0.21%)
:arrow_up:

src/TraceEvent/Stacks/FilterStacks.cs
48.9% <0%> (+0.27%)
:arrow_up:

...w/OtherSources/Linux/LinuxPerfScriptEventParser.cs
77.01% <0%> (+0.32%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c80f7...dbe3570. Read the comment docs.

Thanks for doing this.

No problem. Happy to help! Lemme know if there is more I can do.


Allow to turn off autostart WITHOUT login.

I am not currently ready to login with my account on this machine. Please allow me when I click on "SETTINGS" to actually view the Settings screen instead of trying to force me to login. This way I can turn of Autostart until I am actually ready.
my log id: 741dca3622dc2a26b429191c

In Keybase 5.0, you can change this setting on all platforms. Please make a new issue if you are still having trouble. Thanks!

As of Keybase 5.0, you can change the autostart settings in the GUI in the Settings tab on all platforms. Please make another ticket if you're still having trouble. Thanks!

The issue is that you cannot do so before you login. Is that possible now on all platforms?

Sorry, I misread. That is a good idea. On Linux this is possible with keybase ctl autostart in the CLI.


Error spam when using specific model with jiggle physics

I have downloaded Astolfo Model Replacement, and everytime when I (or someone else) was using it, the log are spamming error with following:
NullReferenceException: Object reference not set to an instance of an object
  at JigglePhysics.JiggleRigBuilder.PrepareBone (UnityEngine.Vector3 position, JigglePhysics.JiggleRigLOD jiggleRigLOD) [0x00054] in <bdee04eb0b3f4377bcee7c264ff1616f>:IL_0054
  at JigglePhysics.JiggleRigBuilder.Advance (System.Single deltaTime) [0x0006d] in <bdee04eb0b3f4377bcee7c264ff1616f>:IL_006D
  at JigglePhysics.JiggleRigHandler.UpdateJiggleRigs () [0x00024] in <bdee04eb0b3f4377bcee7c264ff1616f>:IL_0024

I'm not sure if it's a fault from model author or this mod, but the model itself are looking every fine, except this error are spamming every single frame, which it will impact performance.

Any questions you have regarding jiggle physics should be asked here.
https://github.com/naelstrof/UnityJigglePhysics
Though I am fairly certain that those errors are a result of how the mod author did things. In my experience UnityJigglePhysics is quite stable.


How to write to input tensors in custom op?

Click to expand!
Issue Type
Others
Source
binary
Tensorflow Version
tf 2.8
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
How can I write to input tensors in a custom op? I can read and write to output tensors but only read on inputs. (compiling outputs "assignment of read-only location" error when trying to write to input tensor). I want to write an inplace op, and making it inplace is crucial for my project, as writting the results to an output tensor and then assigning the output to the variable is too slow). Here is a minimal example that just sets the input tensor to zero. What code can I add to this example code so that I can be able to write to the input tensor?

Standalone code to reproduce the issue
#include "tensorflow/core/framework/op.h"
#include "tensorflow/core/framework/shape_inference.h"
#include "tensorflow/core/framework/op_kernel.h"
#include "tensorflow/core/util/work_sharder.h"

#include <iostream>

using namespace tensorflow;

REGISTER_OP("Example")
    .Input("variable: float")
    ;

class ExampleOp : public OpKernel {
public:

    explicit ExampleOp(OpKernelConstruction* context) : OpKernel(context) {}

    void Compute(OpKernelContext* context) override {

        const Tensor& variable_tensor = context->input(0);
        auto variable = variable_tensor.flat<float>();

        for(int i = 0; i < variable.size(); ++i)
            variable(i) = 0;

    };

};

REGISTER_KERNEL_BUILDER(Name("Example").Device(DEVICE_CPU), ExampleOp);

Relevant log output
minimal.cc: In member function ‘virtual void ExampleOp::Compute(tensorflow::OpKernelContext*)’:
minimal.cc:25:25: error: assignment of read-only location ‘variable.Eigen::TensorMap<Eigen::Tensor<const float, 1, 1, long int>, 16, Eigen::MakePointer>::operator()(((Eigen::TensorMap<Eigen::Tensor<const float, 1, 1, long int>, 16, Eigen::MakePointer>::Index)i))’
   25 |             variable(i) = 0;
      |             ~~~~~~~~~~~~^~~

How can I write to input tensors in a custom op? I can read and write to output tensors but only read on inputs. (compiling outputs "assignment of read-only location" error when trying to write to input tensor). I want to write an inplace op, and making it inplace is crucial for my project, as writting the results to an output tensor and then assigning the output to the variable is too slow). Here is a minimal example that just sets the input tensor to zero. What code can I add to this example code so that I can be able to write to the input tensor?

@Alantlb Could you please refer to this link and let us know if it helps?
Thank you!

Hi, If you are looking for assigning value to the Tensor variable, you can do it using tf.Variable.assign().
Let us know if you are looking for something else. Thanks!


Skipping hidden steps

This PR resolve #11

Hmm, that looks awesome!
Can you give me a clean PR from non-master?  I'd like to avoid the extra commits about adding/removing the travis config/readme.

i need to rebase for that, what's wrong with the commits?


Avoid reusing ingest connections by creating a new one each time

we certainly can do a retry, but this was more about preventing the reuse problem to begin with, which it seems to do in testing.

This looks good.. Ideally there'd be a corresponding issue to request queued beacon and witness reports?

You mean a GitHub issue to add this feature to the local grpc api?

This looks good.. Ideally there'd be a corresponding issue to request queued beacon and witness reports?

You mean a GitHub issue to add this feature to the local grpc api?

No sorry that was confusing.. an issue, but an issue to add queued witness/beacon report submission in case the hotspot fails to deliver

This looks good.. Ideally there'd be a corresponding issue to request queued beacon and witness reports?

You mean a GitHub issue to add this feature to the local grpc api?

No sorry that was confusing.. an issue, but an issue to add queued witness/beacon report submission in case the hotspot fails to submit the beacon or witness report

Why don’t we take 10 min tomorrow to figure out what the parameters for this are and I’ll write it up


[Question] What is hard_delete doing / whats the use-case?

Hi,
So i found that the implementation is this:
  public function onFlush(EventArgs $args)
    {
[..]
                if (isset($config['hardDelete']) && $config['hardDelete'] && ($oldValue instanceof \DateTime || $oldValue instanceof \DateTimeInterface) && $oldValue <= $date) {
                    continue; // want to hard delete
                }

which looks to me like "if we try to delete a soft-deleted record, then really drop it", right? What is the use case for that? Or better: As the em wont give the soft-deleted records back from a query, how does one get here? By "forcing" the delete via DQL?

+1

which looks to me like "if we try to delete a soft-deleted record, then really drop it", right?

Correct. The use case depends on your application's needs. You may never care about fully deleting data, or you might want to give your users that option. Maybe there are regulations such as HIPAA that you need to be careful of, and have the ability to fully remove data in the event of someone not following procedure.
You can tell the entity manager to ignore the soft delete filter when retrieving records:
<?php
$article = new Article;
$article->setTitle('My Article');

$em->persist($article);
$em->flush();

// Now if we remove it, it will set the deletedAt field to the actual date
$em->remove($article);
$em->flush();

$repo = $em->getRepository('Article');
$art = $repo->findOneBy(array('title' => 'My Article'));

// It should NOT return the article now
$this->assertNull($art);

// But if we disable the filter, the article should appear now
$em->getFilters()->disable('soft-deleteable');

$art = $repo->findOneBy(array('title' => 'My Article'));

$this->assertTrue(is_object($art));

// Enable / Disable filter filter, for specified entity (default is enabled for all)
$filter = $em->getFilters()->enable('soft-deleteable');
$filter->disableForEntity('Entity\Article');
$filter->enableForEntity('Entity\Article');

// Undelete the entity by setting the deletedAt field to null
$article->setDeletedAt(null);

At which point you could pass the entity to $em->remove() for a hard delete.
I don't remember off the top of my head if DQL queries go through the entity manager and/or listeners, so I can't say for sure about forcing deletes via DQL.

Ah! That makes sense!


feat: Add sepolia chain to infura

Description
Inufra now supports sepolia.
Addresses: https://github.com/wagmi-dev/wagmi/discussions/954
Additional Information

[x] I read the contributing docs

Your ENS/address:

0xflick.eth / 0xa08ea173f778e4a264d3308385E6F046E691BbA7

Can we add a changeset for this? 🙏
Run pnpm changeset, and make this one a patch!

Not sure what to do about the tests. I can't seem to get them to run well on mainline either.

@0xFlicker I just ran the tests. Can you add wagmi to the changeset too? Right now it's just @wagmi/core.


Being able to optionally disable logging of "GET /status" in the access logs

Kong provides a GET /status endpoint to check for the status of Kong, which should be optionally disabled since it creates lots of noise in the access logs when a client is making frequent requests to it.

We have Kong running in kubernetes with datadog and an ALB load-balancing(multi-region so effectively three). All 5 are hitting this endpoint to generate 50 requests per minute per kong instance (we have 2)
50 × 2(hosts) × 60(minutes) × 24(hours) × 30(days) = 4_320_000
so that's 4 million log lines that we would like to turn off.


Outdated version # in 'About' dialog box

The 'About' dialog box still has 0.8.2 as the version number. Current version for Windows is 1.0.3402.

Hey @k0k0b34n thanks for your feedback, 0.8.2 is the current Daedalus version … we are currently improving the version label to be more concise (show exactly which Daedalus / cardano version and build is used)


Feat/relay

[Current coverage][cc-pull] is 64.80%

No coverage report found for develop at 37750e8.

Powered by Codecov. Last updated by [37750e8...4200c04][cc-compare]
[cc-base-branch]: https://codecov.io/gh/NCI-GDC/portal-ui-legacy/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/NCI-GDC/portal-ui-legacy/compare/37750e8d34b013ef264f928e25329acc3bcc4b64...4200c040a4e70d065ee1d29fd93bd135cbf7d8ef
[cc-pull]: https://codecov.io/gh/NCI-GDC/portal-ui-legacy/pull/116?src=pr


The product must be added to the wishlist which the user wants to add

Bagisto Version: Master
Steps To reproduce--
1. Visite on the shop
2. Add multiple variants of the same product into the cart.
3. Move any one variant onto the wishlist
4. Go to wishlist.
Expected result: The product must be added to the wishlist which the user wants to add
Actual result: The product that the user wants to move to the wishlist is not being adding to wishlist. Please find the screen recording Here

@jitendra-webkul
The user should not able to move items from the wishlist to compare.


Add device tracker support to picture card

it shows a map with a list of device_trackers

You're thinking too small again.
Map card that has a list of entities. Will show the entities that have lat/longitude. Combine with entity-filter to just show device trackers.

Hi guys,
I've coded up a very basic solution for this, how should I share it so that others can see it? Should I share it here or in the forums?
Nigel

well create a pull request

I don't think that what I have is ready to go into the project, I just wanted to share it for guidance, and to start discussion about creating custom cards.
Which repository should it be sent to? This one? I don't see any code files, so have no idea how to structure the filesystem.

You can create a GitHub gist

https://gist.github.com/nlinnett/d0671682de8bdffeb61d5b87ce140473
Okay, gist created. As I said it's a very basic implementation, and I still have things I would like to add to it. No need to be too gentle with feedback on it (if any).

Need to be able to put a title on it
I would like to be able to specify a colour for each entity that it tracks


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_493f2b99-df8f-49d9-b687-8c115952be17/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_493f2b99-df8f-49d9-b687-8c115952be17.git

Docs Build status updates of commit 61205cc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-source-1' (branch: Release_Archive_main_2022-02-14-01-51-05) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Is there a prop to change class for current active li?

Is there a prop to change class for current active li?
I would like to use background-color: blue when on hover.
I don't find any prop for this, am I wrong?

There is now:
export let liActiveOptionClass = ``

Related https://github.com/sveltejs/svelte/issues/7294.

@frederikhors Just occurred to me, do you think we need a class for the <input> itself. Right now we have these:

Selected 1

Selected 2

  <input />  // add inputClass here?

Option 1

      Option 2 (currently active)

Unless I misunderstand the capabilities of something like TailwindCSS, this does not allow to e.g. change the color of the input::placeholder, correct?

I'm unable to try now (busy). I'm using svelte-select for now. I'll switch in the future. I think tailwind does this thing: https://tailwindcss.com/docs/hover-focus-and-other-states#placeholder-text.

Thanks for the link. 👍
That does look like a class on the <input> is needed. I'll add one.


Models with identical filename and unique identity.

Sails version: 0.12.13
Node version: 6.9.4
NPM version: 4.4.1
Operating system: Win 10

Hi,
I'm building an App separated into modules, with the models and controllers in sub-directories, and custom identities for namespace.
/api/models/ModuleA/Model1.js -> identity: 'ModuleA_Model1'
Now i have 2 modules that each uses its own set of Tags, resulting in 2 Tags.js Models, which i thought would be no problem, because of their different identity.
/api/models/ModuleA/Tags.js -> identity: 'ModuleA_Tags'
/api/models/ModuleB/Tags.js -> identity: 'ModuleB_Tags'
But it seems that unique identities is not enough, also filename has to be unique, sails lift gives:
Error: Attempting to flatten modules but duplicate key detected (Tags).  Enable keepDirectoryPath: true to enable namepspacing based on hierarchy. (typo in include-all? namepspacing?)
Setting a custom unique globalId in the models does not solve the problem.
Imho, the unique check should be done on the identity, not the filename. Or, that atleast unique custom globalIds should work.
For just the tags its not that critical, but the app will grow, with different installations with different modules, so theres potential for unneccassary errors.
If i got this right, for a quick fix i have to manipulate the sails source and set keepDirectoryPath in the moduleloader hook - loadModels - include-all call? Will this influence the custom identities, or just their globalIds?
If you don't use subdirectories, the keepDirectoryPath setting will not change anything? And if you use subdirectories, the identities will most likely be custom. From that, the keepDirectoryPath could be set by default (of course not in this version, breaking), with a hint to custom unique identities for the globals. Or, atleast configurable in /config/models.js.

Ok, fixed!

Thanks @rene-lindner-isw.  I think your instinct is probably right that this is an issue in include-all, so I'll poke around and see if there's some rationale for how it's working now, and if not I'll patch we'll patch it up.

@rene-lindner-isw Still picking apart the intricacies of include-all, but in the meantime I think it's worth noting that you should really be giving your model files unique names anyway.  I don't really see the rationale for having identical filenames, especially considering that the model identities have to be unique, and having the identity be different from the filename is bound to cause more confusion than it's worth when it comes time to debug that model.

Thanks for your feedback!
I agree - as i wrote its not critical for my tags-example.
But we are developing an module based application, and i'm trying to make them independent, and trying to minimize type-work. Just trying to avoid /models/module/module_resource.js.
But imho the easiest solution would be to make an config option for the models include-all keepDirectoryPath in the /config/models.js. I tried setting the keepDirectoryPath hardcoded, and got the expected behavior, everything worked.
Another option we are considering is to outsource modules controllers and models into installable hooks, but can't find any info on manually including controllers and models into sails -> https://groups.google.com/forum/#!topic/sailsjs/bEaM_VsAgl8

@rene-lindner-isw there's a new, albeit still experimental (read "we reserve the right to change it in case it sucks in some unexpected way, but otherwise will probably keep it as-is"), way of doing this for models, via sails.config.orm.moduleDefinitions.models.
Be careful loading models in hooks though- if you go that direction, you'll want to make sure you've got a very clear and thought-through strategy for schema migrations in dev and prod (and you'll need to make sure you understand the Waterline lifecycle pretty well).
Realistically, I'd suggest we look into some kind of simpler way to allow you to do what you're aiming to do with models (either an easy moduleloader override or some kind of simple config flag).  Holler at me if you want to dig further into that.

As for registering controllers/actions in hooks, fortunately, there's a much cleaner answer for that!  Check out: http://next.sailsjs.com/documentation/reference/application/advanced-usage/sails-register-action


Change transaction syntax to make Commit() implicit

The current transaction syntax is the following:
using(var transaction = db.BeginTrans())
{
    // (operations)
    transaction.Commit();
}

This is unclear and prone to mistakes. Forgetting to commit the transaction will roll it back, or in certain cases (nested transactions) lead to difficult to diagnose bugs. For example, modifying the sample from the wiki:
using (var transaction1 = db.BeginTrans())
{
    col.Insert(new Person { Id = 1, Fullname = "John" });

    using (var transaction2 = db.BeginTrans())
    {
        col.Insert(new Person { Id = 2, Fullname = "Joana" });
        //transaction2.Commit(); // we don't commit the inner transaction
    }

    col.Insert(new Person { Id = 1, Fullname = "Rick" });
    transaction1.Commit();
}
// what's the result? surprise! only the third person (Rick) gets comitted.

I propose a new syntax that makes the Commit() statement implicit at the end of the transaction.
using(var transaction = db.BeginTrans())
{
    // (operations, no need to commit)
}

The IDisposable.Dispose() implementation uses Marshal.GetExceptionCode() to decide whether the transaction should be committed or rolled back. I preserved the behaviour of Rollback() only cancelling the operations until the rollback statement, not withing the scope of the entire transaction.
I am not certain what behaviour is intended in some cases so please review the code and decide whether this kind of solution is acceptable.
I am also adding several tests for the transaction system.

Have you ever worked with ado.net transactions? the default behavior is to rollback.   See https://msdn.microsoft.com/en-us/library/2k2hy99x(v=vs.110).aspx

Hi @apkd, thanks for your contribution. To be honest with you, I prefer your way to implement transaction (and it's new to me that you can get exception inside Dispose). To me, less code is better :). But, I posted in gitter about a month ago how was better way to implement transaction and write this samples: https://gist.github.com/mbdavid/9a8daddb1fe8e73732cf156f5b622022
The way was implemented is more "standard" and it's used in many libraries (including ado.net, TransactionScope and EF).


editor.action.showSnippets command does not has label

From @jabacchetta
Similar:
Same appears to be happening for editor.action.showSnippets, which is the command executed by the Insert Snippet command. Insert Snippet command name is not showing up above the command ID. This command name should maybe be renamed to Show Snippets as well? Because there's also a separate insertSnippet command ID.
editor.action.insertSnippet command ID is not showing in the search. Looks like there are actually three different commands being named/mixed up?

editor.action.showSnippets does not has any label provided and hence only command id is shown in keybindings editor. @jrieken FYI
editor.action.insertSnippet command is not showing in the keybindings editor because the editor does not show commands with arguments.
Leaving this issue for editor.action.showSnippets command label.

editor.action.showSnippets is only there for compatibility reasons, the new command is showSnippets (which has a label et al). What is this about?

There are two parts in this request.

User complained that when typing editor.action.showSnippets in Keybindings editor, there is no label for it. - This issue is for tracking this.

editor.action.insertSnippet is not shown in keybindings editor which I respond saying that Keybindings editor does not show commands with arguments. There is a separate feature request for this.

Ok - closing then. We cannot add a label to showSnippets because we don't want it in the UX (and since there is no way to redefine a keybindings-editor label)

@jrieken There is already a label for editor.action.showSnippets, it just isn't showing in the keyboard shortcuts editor from my understanding. Open the command palette and execute the Insert Snippet command, which "shows snippets".

@jrieken @sandy081 Think I'm still confused. Is showSnippets supposed to appear in the search?
The primary problem for me was that I was able to open the command palette and use the following command name to show a list of snippets: Insert Snippet.
However, let's say you want to add a keybinding to that command name. You go into the keyboard shortcuts editor and you search for that exact command name, Insert Snippet, which I would assume would show up. That command name does NOT show up. What does show up is a different command ID, insertSnippet, that belongs to a different command.
To assign a keybinding to the command that's associated with the Insert Snippet command name in the command palette, you have to assign the keybinding to the editor.action.showSnippets command ID.

@jabacchetta Command is not shown because of this - https://github.com/microsoft/vscode/issues/80214


Port binding validation when creating a container

Is it interesting to get an overview of available port and used port ?
I m using a lot of ports on the same machine and it get confusing sometimes.
What will be great - to me at least - is a list for available ports remaining usable on a new container which can be put as a list in the container creation on the host port.
I see differents "ways" to implement it:

a panel with port available or busy somewhere in the dashboard
an autocompletion in the container creation/edit form which shows available port as a list while your typing and if the port is already busy, the text will appear red and the form will not submit.

let me know !

We could prevent the user from using an already published port but I do not see how we would be able to list available ports.
I'll tag as an evolution and rename the issue.

"I do not see how we would be able to list available ports" - agree
I'm looking for a solution on that part.


find a way to extract commit when running a function

so far we've used pre-commit from git/hooks, but this does not work because it is looking at the previous commit.
other solutions include:

post-commit
reset --soft? (to check: http://stackoverflow.com/questions/14208272/know-git-hash-before-committing)

solution to implement:
https://github.com/neuropoly/spinalcordtoolbox/blob/master/scripts/isct_test_function.py#L291

fixed in pr #1010


Upgrade to netty-all 4.1.50.Final

The update netty-all ver 4.1.50 includes both security fixes and AArch64 performance improvements
Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html
Signed-off-by: odidev<EMAIL_ADDRESS>

Coverage increased (+0.08%) to 93.56% when pulling 17dddf6ff16d41ecd97504ebd7d24a4c3ca94e61 on odidev:arm_support into 30507fda33745c44ba45a03fade16ec7d586c315 on jhalterman:master.

Netty is just a test dependency for the example code. Are there any updates needed to the example code?

Hi @jhalterman
Yes, netty is a test dependency for the example code here. On updating netty just in this package, we will not need any more code change in example code. However example tests depends on vertx-core as well and further vertx depends on netty. On upgrading vertx (along with netty there), we will be required to fix a build issue.
I will raise another PR when vertx release will be published with upgraded netty.


Split out bass amplitude computation to separate class

Feels better from a code quality perspective, but may also pave the way to using this in SampleChannel (something I am currently looking in to.

[ ] Depends on https://github.com/ppy/osu-framework/pull/3646

Adding a test scene for this, hold off on checking just yet (there's no way to test amplitudes are working framework side currently).

Okay, good to go now.


Update BogeyInstance.java

BogeyInstance-NoSealed

We are not making these changes. They need to be made on forge.


Character consistency

Spoiler alert: I'm a noob
ControlNet is the first real method to control SD. I was thinking if with this method there would be a way to teach the network to keep the generated character. I'll give you an example:
dog with blue fur => save subject =>  riding a motorcycle
I know there are already methods to teach the network about the subject, like dreambooth etc.
but I thought since the network already knows the subject 'cause he created it in the first place, isn't there a way theorically to tell the network to keep overall subject traits without training it and waste time.
This imho would unleash the power of SD. Ranging from creating storyboard, to notime character design creation
Ps. sorry for my bad english

Interesting!
I will be following.

Here's an article showing how to use Control Net to do what you want: https://onceuponanalgorithm.org/consistent-ai-character-generation-with-different-poses-in-stable-diffusion/


ARCoreExtension breaks app input detection inside UnityView

Hey there, we are trying to combine react native and Unity while using ARCoreExtensions inside Unity for AR View. As soon as the ARCoreExtension iOS Helper kicks in, the app loses input detection completely. Even reloading through metro does not fix it. Testing with Unity standalone does not show this behaviour. Is there anything, that you can think of, that might cause this issue or can fix it?

did you find this solution ? why input detection breaks?

did you find this solution ? why input detection breaks?

When debugging with Xcode I was able to reveal, that different iOS window layers have been fighting with each other. Imagine something like a css z-index fight. It seems like a bug and if I remember correctly, we used something like a hacked react view style to reset the focus of the iOS wrapped window
return (     // If you wrap your UnityView inside a parent, please take care to set dimensions to it (with flex:1for example).     // See theKnow issues part in the README.     <View style={{flex: 1}}>       <UnityView         // @ts-ignore         ref={unityRef}         style={{flex: 1}}         onUnityMessage={result =>           console.log('onUnityMessage', result.nativeEvent.message)         }       />     </View>   );


Docker Image

It would be helpful if zswag would provide a Docker base image with all requirements necessary to run a zserio-swagger-based service.

Deemed not necessary.


Use callback instead of deprecated context methods

It appears that context.fail() and context.succeed() are deprecated in Lambda since Node.js 4.3. They still work but it is easier to users when the code matches current best practice, I think.
See http://docs.aws.amazon.com/lambda/latest/dg/nodejs-prog-model-using-old-runtime.html#nodejs-prog-model-oldruntime-context-methods

Thank you!

 Thanks for merging.


Issues using ALT keys in applications like irssi

CTRL+AD for disconnecting screens etc and CTRL keys works fine within other terminal applications.
Anyone else that can reproduce this? My main reason for using Wetty is so that I have access to my irc client through proxies etc. Until then I just have to live with the workaround I guess ( /windows N )

could you tell me what browser you are using?
if its chrome the issue is probably that the browser itself takes any input from alt itsself for its own shortcuts

Chrome, Edge & IE all acts the same. It has worked with previous versions of wetty that used to run on node 4. But all wetty versions on node 6 have had this same issue.
I brought it up on https://github.com/krishnasrinivas/wetty/issues/81 but the build from freeeflyer behaves the same. From what I also remember was the previous builds also had a right click menu which allowed you to select between monochrome setups and colorsetups also. So I recon it has something to do with hTerm etc.

alright thanks ill have a look
im trying to update hterm currently but thats breaking edge support

cheers :) let me know if you need additional testing at some point and I'll be glad to assist in any manner I can.

hey @weq could you tell me if this is still an issue on the latest build. it seems to be working for me

closing due to lack of response will reopen if still an issue

i can reproduce this issue.
my scenario is the following:

login in wetty
connect to my other server via ssh
resume screen session
try to switch channels in irssi via ALT+Number, ALT+2 or ALT+3 etc.

That does not work and instead prints the number to the chat field


[CBR-325] Compare parent IDs last

Description
Make sure that comparing addresses compares the root ID only as the last step. This is important when we have a ton of different address IDs that we want to sort, we don't want to be comparing the root ID over and over and over again.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-325
Type of change

[x] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

Rebased.