Dialog doesn' t show

Hello. Thank you for this library ,dialog  doesn't show and I don't get any error messages in logcat. i use the same code in  exemple :
HouseAdsDialog houseAds = new HouseAdsDialog(RingtonesActivity.this, "https://api.myjson.com/bins/15dehw"); . 		houseAds.hideIfAppInstalled(false);  		houseAds.setCardCorners(80);  		houseAds.setCtaCorner(80);  		houseAds.setForceLoadFresh(true); 		houseAds.showHeaderIfAvailable(true);  		houseAds.loadAds();
my json is :
{   "apps": [     {       "app_title": "Kawaii Cats Wallpapers (Dialog)",       "app_desc": "Kawaii Cats Wallpapers - Cute wallpapers",       "app_icon": "https://funnyjokes.me/kawai/icon_play.png",       "app_header_image": "https://funnyjokes.me/kawai/cover.png",       "app_uri": "https://play.google.com/store/apps/details?id=com.CuteWallpaper.KawaiiCat",       "app_rating": "5",       "app_cta_text": "Install",       "app_price": "Free",       "app_adType": "dialog"     },     {       "app_interstitial_url": "https://funnyjokes.me/kawai/icon_play.png",       "app_uri": "https://play.google.com/store/apps/details?id=com.CuteWallpaper.KawaiiCat",       "app_adType": "interstitial"     },     {       "app_title": "Kawaii Cats Wallpapers (Native Ad)",       "app_desc": "Kawaii Cats Wallpapers - Cute wallpapers",       "app_icon": "https://funnyjokes.me/kawai/icon_play.png",       "app_header_image": "https://funnyjokes.me/kawai/cover.png",       "app_uri": "https://play.google.com/store/apps/details?id=com.CuteWallpaper.KawaiiCat",       "app_rating": "4.5",       "app_cta_text": "Install",       "app_price": "Free",       "app_adType": "native"     }   ] }

tried calling houseAds.showAd(); ?

i used houseAds.showAd(); and still not working !!

I tried using your json file & it works as expected..

How & when are you calling houseAds.showAd(); ?

in onCreate function

You should use a listener..
Check the ReadMe again for instructions..

i added setAdListener and display this error

use like this,
houseAds.setAdListener(new com.lazygeniouz.house.ads.listener.AdListener() {
@Override
public void onAdLoadFailed() {}
@Override
public void onAdLoaded() {
    //Show AdDialog as soon as it is loaded.
    houseAds.showAd();
}

@Override
public void onAdClosed() {}

@Override
public void onAdShown() {}

@Override
public void onApplicationLeft() {}

});

use like this,
houseAds.setAdListener(new com.lazygeniouz.house.ads.listener.AdListener() {
@Override
public void onAdLoaded() {
    houseAds.showAd();
}});

just implement all the methods!


Better typesafety for getRoutes function

This PR uses the types from the backend libraries and makes the getRoutes function more typesafe
Let me know if any further changes are required

Hi @max-programming! Thank you so much for this PR and apologies for late response here.
You're importing types from all packages that user may not have - would that cause issues for them?

@VladimirMikulic I don't think that will be a problem. Because the packages are installed here in the route-list library.
Secondly we're only importing types just for better type checking when the users use the library

@max-programming they are installed but as dev dependencies?

I think because we only use the types, we don't really need them in dependencies
As the code is not going to run on the runtime, it's just the types


Add XML string payload protocol test

Issue #, if available:
Description of changes:
Add string payload test for restXml, similar to existing restJson test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

After generating updated tests for AWS SDK JS V3, running yarn test:protocols yields the following successful test:
lerna success run Ran npm script 'test' in 6 packages in 20.0s:
lerna success - @aws-sdk/aws-protocoltests-ec2
lerna success - @aws-sdk/aws-protocoltests-json-10
lerna success - @aws-sdk/aws-protocoltests-json
lerna success - @aws-sdk/aws-protocoltests-query
lerna success - @aws-sdk/aws-protocoltests-restjson
lerna success - @aws-sdk/aws-protocoltests-restxml
Done in 188.22s.


Bits/Bytes confusion in StructMember initialization on IDA

See https://github.com/binsync/libbs/blob/2ec1fc993a9624b97292d2c9aabf2186d8fb7802/libbs/decompilers/ida/compat.py#L1009-L1018
Here udt_memb.offset is actually the offset in bits of the member, whereas StructMember.offset represents the offset in bytes. This breaks any structure upon modification.
Additionally, it would be great to precise in comments that the StructMember.offset field actually represents a byte-offset, to avoid further confusion (or to convert it into a bit-offset, for later support of bifields?)
Thanks in advance for the fix!

I guess there is the same bug here (not tested yet)
https://github.com/binsync/libbs/blob/2ec1fc993a9624b97292d2c9aabf2186d8fb7802/libbs/decompilers/ida/compat.py#L1195-L1196


Add preliminary Google AdSense support

When googleAdsense is set in config.toml, the AdSense code snippet
will be inserted between the <head></head> tags of your site. Only
Google AdSense auto ads is supported at the moment.

Feel free to close this PR if this is not planned for this Hugo theme.

Thanks for your contribution! 😉


X dimension of Z error when Coregistering ArcticDEM strips

Hi there,
I am trying to use xdem to coregister DEMs using the Nuth and Kaab Method. I am coregistering an ArcticDEM strip (EPSG:3413) to an ArcticDEM tile that has been masked to bedrock and is also in the same projection.
When I try and execute the fit section (nuth_kaab.fit(reference_dem.data, dem_to_be_aligned.data, transform=reference_dem.transform) I get the following error (this has also appeared when clipping the ref DEM to equal extents, and trying a different ref dem):
Traceback (most recent call last):
File "/home/jhansen/JasmineShare/petermann/xdem_coreg.py", line 27, in
nuth_kaab.fit(reference_dem.data, dem_to_be_aligned.data, transform=reference_dem.transform)
File "/home/jhansen/miniconda3/envs/gdal/lib/python3.9/site-packages/xdem/coreg.py", line 506, in fit
self._fit_func(ref_dem=ref_dem, tba_dem=tba_dem, transform=transform, weights=weights, verbose=verbose)
File "/home/jhansen/miniconda3/envs/gdal/lib/python3.9/site-packages/xdem/coreg.py", line 1215, in _fit_func
elevation_function = scipy.interpolate.RectBivariateSpline(
File "/home/jhansen/miniconda3/envs/gdal/lib/python3.9/site-packages/scipy/interpolate/fitpack2.py", line 1333, in init
raise ValueError('x dimension of z must have same number of '
ValueError: x dimension of z must have same number of elements as x
xdem_coreg.txt
Do you happen to have any ideas as to why this may be occurring?
I attach the script in text form that I am using to execute the coregistration and I am using the following xdem version:
xdem                      0.0.7              pyhd8ed1ab_0    conda-forge
thanks!

Hi @jaha2600,
Thanks for reporting this issue!
Using the following syntax might solve your issue (not using the .data but directly the Raster objects):
nuth_kaab.fit(reference_dem, dem_to_be_aligned, inlier_mask=inlier_mask)

The Coreg module is one of our oldest and we are currently in the process of re-organizing and simplifying it (#329), and we are then going to adjust the documentation in the next months (aiming for a first stable release sometime next year :wink:).
We also need to update the  README for which some examples are outdated. If you want to use the package's features, it is better to use the syntax demonstrated in the documentation example, for example for Nuth & Kääb: https://xdem.readthedocs.io/en/latest/basic_examples/plot_nuth_kaab.html#sphx-glr-basic-examples-plot-nuth-kaab-py

Hi Romain,
Thanks for the reply I shall try that new syntax today, looking forward to the upcoming stable release!
I just wanted to check a few things:

Would pipelining multiple methods based on the Nuth Kaab example you suggested result in the below syntax needing to be used?

methods = xdem.coreg.NuthKaab() + xdem.coreg.Deramp(degree=1)
methods.fit(reference_dem, dem_to_be_aligned, inlier_mask=inlier_mask)

I have already masked my reference DEM to the stable surfaces I require (bedrock only etc.). In that instance would it be fine to exclude the inlier mask option or would you suggest also including a vector mask alongside the reference DEM ?

thanks,

Hi @jaha2600,

Yes.
Should be fine!

@jaha2600 I assume this is solved, closing!


Custom places icons

Would it be possible to update folder icons? For example, I use the nextcloud folder icon, but when I change the accent color, the nextcloud folder stays blue.

Same here. Changing a folder icon is then reverted to the default folder icon.

Hello, changing accent color shouldn't mess with custom icons, so it would stay the one you've set by UI or by gio set command.
Also currently the extension can't address for custom icon either, so if you set the icon to, for example, folder-games under Adwaita-red, it will stay red if you change to accent green. The extension isn't able, in it's current form, to keep track of custom changes, but it is planned in future releases.

https://github.com/user-attachments/assets/f0a68c31-c1da-4d2b-a467-ffc5cea4d07d
Tried to manually change the custom place icon in /var for a mounted volume and the color remained the same. The icon I choose was in /var/usrlocal/share/icons/Adwaita-green/scalable

Tried to manually change the custom place icon in /var for a mounted volume

Right now the extension manipulates only directories under user home, I may be able to add more places for it to loop up to, but I can't guarantee it will work because of permissions issues that may arise.
Gravação de tela de 2024-11-21 12-27-21.webm

Thanks for working on this. I have to install icons in /usr/share/icons because icons stored in /home tend to get buggy with some apps and are sometimes lost by Gnome after wake and unsuspend. I know this is not uncommon, so would be awesome to see support for non-home locations!

Thanks for working on this. I have to install icons in /usr/share/icons because icons stored in /home tend to get buggy with some apps and are sometimes lost by Gnome after wake and unsuspend. I know this is not uncommon, so would be awesome to see support for non-home locations!

The extension accounts for directories with custom icon within user home, the icon itself could be anywhere, even on /usr/share/icons, the extension will just change the variant, e.g. Adwaita-red to Adwaita-green. For example:
Directory $HOME/Games has attribute (set by nautilus gui or gio set) metadata::custom-icon path is file:///home/$user/.local/share/icons/Adwaita-red/scalable/places/folder-games.svg will be changed to metadata::custom-icon: file:///home/io/.icons/Adwaita-green/scalable/places/folder-games.svg.
The same applies even if the icon is under /usr/share/icons, it doesn't matter for the extension, as it simply just replace the part of the path that points to a Adwaita-colors variant, nothing else. It just replaces the Adwaita- related part from the URI and sets the attribute to the directory.
What I meant before is that the extension won't handle updates to icons outside $HOME for now, because of safety concerns, I'm working on it, I pretend to add other directories such as /var to the loop.

The extension accounts for directories with custom icon within user home, the icon itself could be anywhere, even on /usr/share/icons, the extension will just change the variant, e.g. Adwaita-red to Adwaita-green.

Oh!! Well unfortunately then I have to report it doesnt work as intended on my system - I have the most recent version of the extension installed and when customizing folder icons located in my /home directory the icons do not update with a color theme change.

customizing folder icons located in my /home directory the icons do not update with a color theme change.

Could you please provide the full path to the custom icon you've set to the directory in question, the output of gio info -a metadata::custom-icon

customizing folder icons located in my /home directory the icons do not update with a color theme change.

Could you please provide the full path to the custom icon you've set to the directory in question, the output of gio info -a metadata::custom-icon path/to/dir

Happy to! Iroinically it's a "games" folder haha:
metadata::custom-icon: file:///usr/share/icons/Adwaita-slate/scalable/places/folder-games.svg

Thank you, that path should be updated on accent change. Can you please also provide the path to the directory itself? Is it really within your home dir? Also did you reload nautilus view, it is never notified about the custom icon change, so it requires manually reload view

Also did you reload nautilus view, it is never notified about the custom icon change, so it requires manually reload view

That was it!! I had been testing with an open window - I totally should have considered Nautilus would need a view reload. Apologies for the confusion and thank you for the quick follow-up!

Tried to manually change the custom place icon in /var for a mounted volume and the color remained the same. The icon I choose was in /var/usrlocal/share/icons/Adwaita-green/scalable

Hello, I've just uploaded a new version to github, it doesn't have a release yet, but if you can, you could lcone the repo, or download it as a zip and install it using gnome-extension install --force path/to/file, test if now it is updating custom icons under /var. I'm not quite sure it is. Also files and directories under /var are owned by root, right? I can't be sure if the extension will be able to change if it is.

This should be under the settings, the current behavior breaks the option of using folder icons with different colors.

You mean as a switch "automatically update custom icons"? Or as a list, "update custom icons for the following locations..."?

Would it make sense to implement the ability to assign an icon to a specific directory from the extension's settings page? That way, the extension could keep track of which folders have a custom icon and change it to the same icon of a different color when needed.


FixedCompositeByteBuf should allow to access memoryAddress / array wh…

…en wrap a single buffer.
Motivation:
We should allow to access the memoryAddress / array of the FixedCompositeByteBuf when it only wraps a single ByteBuf. We do the same for CompositeByteBuf.
Modifications:

Check how many buffers FixedCompositeByteBuf wraps and depending on it delegate the access to the memoryAddress / array
Add unit tests.

Result:
Fixes [#7752].

Also @ldaley

Was the branch fixed_buffer_memoryaddress supposed to stay around?

@carl-mastrangelo nope... deleted. Thanks


Update to support new module API

https://github.com/facebook/react-native/commit/bc28a35bda0e358a8296a7b53eb7315b736c6e4b

modules are no longer plain objects
isPolyfill is now a function
id is now retrieved asynchronously with getName

@elliottsj this is ready for a 3.0.1 release.

Looks good after the one comment. Once we merge this, I think we can release v0.4.0 and enforce react-native >= 0.10.0 in peerDependencies

@elliottsj fixed. Shouldn't it just be 0.3.1 since this is an incremental change. Jumping from 0.2.0 made sense because switching to ReactPackager.getDependencies was a large change for this project.

Also :+1: on enforcing peerDependencies but I think it would be >=0.11.0

Ah true, should be >=0.11.0.
From my understanding of semver, changes that maintain backwards-compatibility should be minor updates and changes that break compatibility should be major updates. Though anything goes for versions before 1.0.0.
Since we're breaking compatibility with react-native<=0.10.1, I think it should be a 'major' update.

@elliottsj gotcha

Since v0.11.0 is still release candidate, maybe we should release a 0.4.0-rc, then bump to 0.4.0 once v0.11.0 is officially released. Thoughts?

@elliottsj that is fine

Woo, 0.4.0-rc is now published!

And now my project is using it :smile:


AssetLlib should be able to filter plugins by compatibility with Godot version

Issue description:
Since 3.0 is coming, we should have ability to filter plugins compatibility by engine version in AssetLib. We probably should display some kind of warning when user will decide to install plugin in non-matching version of the editor.
Also there should be a way for plugin creators to declare in which versions of the engine given plugin will work without problems.

It would be great if it were possible to upload different versions of the plugin for different versions of Godot.

Duplicate/related to this badly spelled issue #7147

Maybe related. Now that we also have more scripting languages, it would be great to also filter plugins automatically by available languages.

closing as duplicate of https://github.com/godotengine/godot/issues/7147


Did not work out of the box with Mac

Sonoma:
nc: invalid option -- U
using socat (installed via brew) works as expected, just need to replace nc -U ... with  socat - UNIX-CONNECT:/tmp/mpv-socket

That's very odd, I'm using a Macbook that's only ever run Sonoma and it has -U,
What's the output of which nc? It should be /usr/bin/nc.

you are absolutely right - it works with /usr/bin/nc
i had netcat installed via brew and it was used instead of /usr/bin/nc
providing full path in scrobble.pl has solved the issue.
thank you
On Sun, Aug 11, 2024 at 08:48:42, Ethan @.***> wrote:

That's very odd, I'm using a Macbook that's only ever run Sonoma and it
has -U,
What's the output of which nc? It should be /usr/bin/nc.
—
Reply to this email directly, view it on GitHub
https://github.com/ethanndickson/iina-lastfm/issues/11#issuecomment-2282646306,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAATZ3M7QGRCESFHQB5X74TZQ4CMVAVCNFSM6AAAAABMKPF6KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGY2DMMZQGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Glad to hear!


Project does not compile on Android (Termux)

TypeScript Version:  master branch 2016-11-21
Code
$ gulp local

Expected behavior:
Project to compile successfully.
Actual behavior:
...
[08:37:07] 'src/compiler/diagnosticInformationMap.generated.ts' errored after 74 ms
[08:37:07] Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1026:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
...

And no js files are generated, only .d.ts.
Workaround
Edit Gulpfile.ts and replace /bin/sh with sh on line 74:
const ex = cp.spawn(isWin ? "cmd" : "/bin/sh", [subshellFlag, ...command], { stdio: "inherit", windowsVerbatimArguments: true } as any);

Becomes:
const ex = cp.spawn(isWin ? "cmd" : "sh", [subshellFlag, ...command], { stdio: "inherit", windowsVerbatimArguments: true } as any);

This is because Termux does not have access to the root folder, and uses a different path to sh.
Please note that I have not tested the effects of the above change on Linux or MacOS. If this change clashes with those systems, then Android could be detected by checking process.platform === 'android'.

Accepting PRs if anyone wants to get this working and can test on the existing platforms

dose jake local work?

No, it fails similarly:
$ jake local --trace
node lib/tsc.js --noImplicitAny --noImplicitThis --noEmitOnError --types  --pretty --preserveConstEnums --module commonjs -sourcemap -mapRoot file:////data/data/com.termux/files/home/a/p/TypeScript/scripts --target es5 --noUnusedLocals --noUnusedParameters scripts/buildProtocol.ts
jake aborted.
Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1026:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

The offending code here is gone; the build system hasn't called sh in some time.


Minify feature detects

I notice feature detects are not being minified. Not sure if it's a regression, but (particularly when the detect contains comments) adds a not insignificant amount to the bundle)

Rhys, can you quantify 'not insignificant'?  Average length of a detect is about 50 bytes.  There are longer ones, I concede, but it will be slightly annoying to minify these and I am not sure it is worth the bother.

Probably not worth the bother if it's difficult - thought it may have been an oversight/regression that'd be easy to fix.


Add all param for feature powershell

Signed-off-by: Graham Davison<EMAIL_ADDRESS>Description
This PR adds the all parameter to the Powershell windows_feature provider to allow all dependencies to be installed automatically. Matches DISM provider feature.
Issues Resolved
none
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thanks!


SVG and Extra Blank

Just wondering if it could be possible to use svg version of certificate badges rather than png. As svg would be crisper and scalable from 0 to infinite without quality loss.
Also, I noticed an extra - unnecessary - line break (OCD alert), see:
<!--START_SECTION:badges-->

[![Offensive Security Web Expert (OSWE)](https://images.credly.com/size/96x96/images/c8c413ce-fce6-4b61-89e6-6a1b9f1e358a/AWAE-OSWE-badge.png)](http://www.credly.com/badges/654e5bc5-0fbe-4d17-ab44-93331a1fc365 "Offensive Security Web Expert (OSWE)")
[![Offensive Security Certified Professional (OSCP)](https://images.credly.com/size/96x96/images/e3c9ad3c-b142-45ae-bb2b-2f19ff2b742a/PWK-OSCP-badge.png)](http://www.credly.com/badges/1064ddf3-8305-4f17-bc79-72f1e9f86408 "Offensive Security Certified Professional (OSCP)")
<!--END_SECTION:badges-->

I don't know if it's possible to receive the SVG, because the project is not for an API, but a web scrap on the Credly page.
I check again and can't find any information about SVG. Since I don't work at Credly, I only index public information.
I'll close this issue because I joined your PR and I don't have much to do about SVG. But I'll go by history, maybe things will change in the future.
thanks for the contribution


Nord

Hello 👋, is there a proxy client for the nordvpn?

Hi! No, not that I'm aware of. NordVPN has browser extension, but it has no free usage tier, so I didn't put efforts to make a proxy client for it.


Resize the image

Hi, I'm trying to resize the image to fit my requirements however, it seems like its fixed to a certain size. Tried scaling it via createScaledBitmap method but it seems it's not working.
How can I resize the image? any help with this will be appreciated

@hliosdja You can use the Bitmap API like this
val originalBitmap: Bitmap = ...
val resizedBitmap = Bitmap.createScaledBitmap(originalBitmap, newWidth, newHeight, false)

@hliosdja You can use the Bitmap API like this
val originalBitmap: Bitmap = ...
val resizedBitmap = Bitmap.createScaledBitmap(originalBitmap, newWidth, newHeight, false)

thanks for the reply, will try again this method. there might be something im missing.


Resource leaks -- cursor not closed -- found by Facebook's static analyzer

Hello,
These resource leak reports, included with comments below, were found by running
Facebook's Infer static analyzer on duckduckgo.
Regards,
Dulma Rodriguez
Facebook Static Analysis Tools Team
For the following bugs, the problem is that Cursor objects need to be closed.
File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 631 is not released after line 644

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 408 is not released after line 409

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 400 is not released after line 401

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 387 is not released after line 388

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 332 is not released after line 333

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 362 is not released after line 363

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 379 is not released after line 380

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 345 is not released after line 346

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 313 is not released after line 320

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 299 is not released after line 306

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 432 is not released after line 434

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 392 is not released after line 396

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 424 is not released after line 426

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 424 is not released after line 428

File: src/com/duckduckgo/mobile/android/db/DdgDB.java
Report: Resource Leak: resource acquired by call to query(...) at line 499 is not released after line 506

For this report, the problem is that os.flush could throw an exception, in which case os won't get closed.
File: src/com/duckduckgo/mobile/android/download/FileCache.java
Report: Resource Leak: resource acquired by call to FileOutputStream(...) at line 48 is not released after line 53

nice -- so close @fgei

Hi,
Facebook's Infer static analyzer, the tool that we used to find these issues, is open source now! Check it out! (http://fbinfer.com/).


🔧 rmrk collection destroy

https://github.com/kodadot/nft-gallery/issues/7552#issuecomment-1831838902

💔 I feel censored

auto deploy new version

oups removed node_modules during process so new lock file

transaction went well:
https://kusama.subscan.io/tx/0x30629971a4eb4b0dae4804349910fe5f7f98ce44e63de63d7e2610231eb81f25
collection still showing on my profile tho:
https://deploy-preview-8395--koda-canary.netlify.app/ksm/u/FSMdmCLv5gFZ87YerB3M8ZSQ58BGHdSnreC4J6znWpqPQK9?tab=collections
Name: Future of Housing

transaction went well: https://kusama.subscan.io/tx/0x30629971a4eb4b0dae4804349910fe5f7f98ce44e63de63d7e2610231eb81f25 collection still showing on my profile tho: https://deploy-preview-8395--koda-canary.netlify.app/ksm/u/FSMdmCLv5gFZ87YerB3M8ZSQ58BGHdSnreC4J6znWpqPQK9?tab=collections
Name: Future of Housing

we don't filter burned collection (#4612) if you try to mint in it it will throw error.
Congratulation! collection is now destroyed.

continue #8413


Using custom font after the system built

I used a custom font locally and load them according to this commit. It works well inside the doc.
But once I did npm run build:system and install the design system as a seperate npm module in my main app, the custom font wasn't loaded in any of the design-system's component. Is this a known limitation of the system, or is there some extra steps I have to follow?

@MrJoeXu It isn’t really a limitation. The static assets just aren’t copied by default when running build:system.
I modified that branch a little and added a little more functionality. See this commit: https://github.com/viljamis/vue-design-system/commit/e7eea29327b54520df8c8eaca26294f52d4159de
With those changes, you can run npm run build:system and it’ll copy the fonts over as well. Once the build is complete, you just need to make sure to import the fonts correctly in your projects. So for example importing the fonts in your main.js:
import system from 'vue-design-system'
import 'vue-design-system/dist/system/system.css';
import 'vue-design-system/dist/system/fonts/fonts.css';
Vue.use(system)

And making sure that your Webpack config has the necessary rules to load font files (you might already have something like this, but if not, Webpack will throw you an error):
{
    test: /\.(woff2?|eot|ttf|otf)(\?.*)?$/,
    loader: "file-loader",
    options: {
        limit: 10000,
    },
}

@MrJoeXu I’ve release a new version (2.1.4) where the static assets are now copied by default when build a lib too. If you already did those changes, no need up update though.


Parsl executor and corresponding tests with simple config

This implements the basic parsl workflow.
Executor test makes sure that we get out expected counts of muons and dimuons is test root data.
Could do more?
This PR also includes some cleanup for spark and some udf templates.

@nsmith- Can you give this a quick look?


Fix Private Methods not getting mocked properly

Note:
When all tests are run together the system runs in to a threading bug due to the static exception defined in InternalMockOrchestrationService
I tried to find ways to pass in "thread safe variations" but hit some weirdness.
I think we need to figure out how to pass the method itself down in to the Harmony lib then have that hold a reference to it to use or hold non static references higher up the application stack somewhere.
Bottom line ... it works but not multi threaded.
I'll think more on this one.

No idea why the checks are failing here, this is what I see locally.


Missing some data download files in data path like Hateful memes, UCF101

Thank you for your great work. But could you provide sh files for some datasets like Hateful memes, UCF101 in the data path?
I tried to download the Hateful memes dataset by myself but the structure is different from your configuration. For example the test.jsonl in the original link of hateful memes dataset does not contain labels like your data_partition.py. And for UCF101 dataset, the download_ucf101.py like the instructions is missing also.

Thanks for pointing this out, I will check with my colleague on Hateful memes, but would you mind sharing where you download the data?
For UCF101, we mentioned that we use the MMAction2 for downloading and preprocessing (extract audios and frames out). To skip this step, I am going to add the processed features for download so people can start from the modeling. However, if people want to apply other pre-trained models to extract other features, going through MMAction2 is probably unavoidable.

Thanks for your reply and hope you get better soon. For the Hateful memes dataset, I downloaded it on Kaggle. I just found the test_seen.jsonl file on Kaggle and it contains labels, maybe it is the test file that you used in this experiment ?

I believe I have answered this, but not sure if to the same person. In case, here is the link: dsa


unicode doesn't render properly

Please provide some details!  For example, platform, Python version, terminal, your LANG and LC_* environment variables.


npm support?

Hi, Nazar!
It would be very nice, if you`ll add this plugin on npm!

Just published as is: https://www.npmjs.com/package/pickmeup
In future I'll likely add some tweaks to it.
Is it fine for you?

Yes. It's great.
Thx!

Hi, again. Sorry for disturbing.
But npm module need minor fix with adding entry point

thx!

I'll add it in next release, anyway you'll include that file manually on frontend.

Actually not. I use this file like module - require('pickmeup')
It's much simplier )

Just released 2.9.0

thx for quick response


Vue-call modal is unable to read javascript date object

I have a problem passing the dates I received from my mongodb server onto the vue-cal modal as start and end dates. I passed the dates as new Date("2019-06-24T16:00:00.140Z").
I also passed the string just like this "2019-06-24T16:00:00.140Z" but it did not accept. Instead the calendar just disappeared completely from the DOM.
Please can anyone explain what I am doing wrong?

Hi @eakenbor,
Please share some code if problem is not solved after that.
As per the documentation in API > events (https://antoniandre.github.io/vue-cal/#api), and until V2 is out, the only way to set event dates is this format: yyyy-mm-dd hh:mm.
V2 will accept passing JavaScript Date objects.
Let me know if you need more help. If so please share your code.

Thanks antoniandre. I managed to concatenate the dates before passing them in. However, when are you expecting to release v2? The feature of event creation by clicking on a time in the calendar is a very important feature that I need now.

There's probably 2, 3 weeks of work before release.


Damaging shield with mei left click slows down enemies

Created by: MaxwellJung
For example, if rein takes 1 tick of freeze damage and holds shield, he will slow down for the entire duration mei is shooting shield.

moved from ow1_emulator_backup#712

mentioned in merge request ow1_emulator_backup!121


Update README.md

Changed $npm install -g node-gyp to #npm install -g node-gyp because it gives an permission error.

Checklist

[ ] npm install && npm test passes
[ ] tests are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Description of change

well.. it's fairly common to put a prompt character in there, I think most people know to remove the character. Personally I prefer to not include anything that's not going to be copied and pasted and the prompt character usually gets in the way, especially for multi-line bash.
# is wrong, so -1 on this particular change, it just turns it into a comment and the syntax highlighting is just going to make it grey. But I'd be fine with removing the $ completely but you'd need to do it for every instance of script copypasta in the README, and there's a lot of them.


[NFC] Some Uncontroversial Frontend Refactorings

Privatize a header that was needlessly part of libAST's includes
Refine the return type of loadAST - this is needed for some upcoming work on incremental builds
Generalize SourceFileDeclFinder to remove the hard dependency on a SourceFile as the source of decls for dependencies

@swift-ci smoke test

@swift-ci smoke test

⛵


patch: align versions

patch: align versions

:tada: This PR is included in version 1.0.47 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: add protocol icon

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[1.0] TypeError: Cannot read property 'markdownRemark' of undefined

Submit my questions here

Could you try again with the latest version of Gatsby? You should just be able to delete your node_modules directory and reinstall.


docs

Add readme.md files for react boilerplate and terminal component, include:

purpose and architecture of react boilerplate
how to create new components using react boilerplate
purpose and architecture of terminal component
any additional information that will help the next developer

Fulfileld by https://github.com/openh2labs/elastic-erga/pull/76


Implement presentation-time

23:27 <ascent12> presentation-time is one of those things I was going to get around to doing in my "DRM 2.0" thing, but it would be easy enough for someone to just do now if they wanted to. the "page_flip_callback" function in drm.c basically contains all of the values you'd need.

page_flip_callback

Correcting myself: page_flip_handler.
Also, when doing this (at least initially), it's probably only worth implementing/exposing this for the DRM backend. We could do it with the Wayland backend by doing this as a client and passing the values through, and I even think X11 had an extension related to this, but it's probably not worth the effort.

Talked to some guys at XDC today, it seems that this extension suffers from a chicken-and-egg problem: no client implements it because no compositor implements it. Use cases include VR, games, medical apps, video players.


Permission denied to run containerdisk binary if /var/lib/kubelet is mounted with noexec flag

What happened:

Attempted to run a containerdisk vmi,

spec:
  domain:
    devices:
      disks:
        - disk:
            bus: virtio
          name: containerdisk
    resources:
      requests:
        memory: 1Gi
  volumes:
    - containerDisk:
        image: kubevirt/cirros-container-disk-demo:latest
      name: containerdisk

Failed with:

$ k logs virt-launcher-vmi-container-disk-6t9kf -c volumedisk0-init
exec /usr/bin/container-disk: permission denied

Upon digging more, this issue only surfaces for nodes with /var directory mounted with noexec flag. When virt-launcher pod is run on the such a node, the emptyDir will be bindmounted from /var/lib/kubelet/pods... location leading to this error.

# findmnt -l | grep "/var"  | grep noexec
/var                                                                                /dev/mapper/system-var                                             xfs        rw,nosuid,nodev,noexec,...

To confirm the theory, ssh'ed into the node and tried this to run ls from the mount point, it failed, as expected:

# cp /bin/ls /var/lib/kubelet/pods/<pod-uid>/volumes/kubernetes.io~empty-dir/virt-bin-share-dir/ls
[root@nd-sjc6nn-br2-001-a alayp]# ls -al /var/lib/kubelet/pods/0058c526-6e21-41bf-ac5c-d53457d3c74f/volumes/kubernetes.io~empty-dir/virt-bin-share-dir/
total 2108
drwxrwxrwx  2 root root      38 Oct 19 14:06 .
drwxr-xr-x 10 root root     166 Oct 19 14:05 ..
-r-xr-xr-x  1 root root 2009168 Oct 19 14:05 container-disk
-rwxr-xr-x  1 root root  143400 Oct 19 14:06 ls
# /var/lib/kubelet/pods/<pod-uid>/volumes/kubernetes.io~empty-dir/virt-bin-share-dir/ls -al
bash: /var/lib/kubelet/pods/0058c526-6e21-41bf-ac5c-d53457d3c74f/volumes/kubernetes.io~empty-dir/virt-bin-share-dir/ls: Permission denied
#

The noexec flag prevents running binary from /var on the node.
What you expected to happen:

Expected the vmi to go into running state

How to reproduce it (as minimally and precisely as possible):
Additional context:
There are two potential paths forward:

Change the emptyDir.medium: Memory. Since the binary has a pre-determined size, it should not cause any problems. The tempfs is mounted without noexec flag, more details here https://github.com/kubernetes/kubernetes/issues/48912 but there could still be a psp policy that could break this option
Add a *v1.VolumeSource field https://github.com/kubevirt/kubevirt/blob/main/staging/src/kubevirt.io/api/core/v1/schema.go#L819:6 to ContainerDiskVolumeSource to allow all the options for mounting the volume correctly. A small pvc, for example, can be used to copy and run the binary depending on the cluster policy.

Environment:

KubeVirt version (use virtctl version): N/A
Kubernetes version (use kubectl version): N/A
VM or VMI specifications: N/A
Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): N/A
Kernel (e.g. uname -a): N/A
Install tools: N/A
Others: N/A

/cc @rthallisey @rmohr
/assign


OpenSSH 7.6 deprecated MACs

OpenSSH 7.6 deprecates hmac-ripemd160 MAC, see here: https://www.openssh.com/txt/release-7.6.
The baseline should reflect this.

I also noticed that the library does not check which openssh-version is installed, rather it checks the operating system. Should we change that?

@rndmh3ro yes this would be a good idea. the openssh 7.6 version should be include in ubuntu 17.10 or 17.04.


Customizer's issues

Should the hash change even if nothing has changed? I mean, click download 2x without changing anything and you'll get a different hash.
Finally, shouldn't we remove the previous bs-callout bs-callout-info?
The dismissible gist alert doesn't seem to work here

Those are 3 different issues, I can split it later if needed.

Punting on this for v4.


VIPs are not readded after recreating a tun/tap interface

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines.
[x] I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
VIPs are not readded after recreating a tun/tap interface. I experienced this problem when using Tinc but it seems to be related to any tun/tap interface so I generalised it.
To Reproduce
Steps to reproduce the behavior:

Add a network and at least one host in Tinc configuration
Assign a newly created Tinc interface
Add a virtual IP (alias) to the interface
Restart Tinc daemon from the dashboard or make any changes in Tinc configuration
Check that the virtual IP is missing

Expected behavior
Virtual IPs should be readded each time a tun/tap interface is created.
Environment
OPNsense 20.1.2

It's the plugins responsibility to handle its own interfaces, openvpn for example triggers the configd action interface newip {interface}  in ovpn-linkup, which is called from
https://github.com/opnsense/core/blob/ff290c95ec27b7afb306ab63295ccd390da1ea18/src/etc/inc/plugins.inc.d/openvpn.inc#L607
Same applies to dhcp type interfaces and ppp links. If an interface signals a devd event, these will be catched as well, using https://github.com/opnsense/core/blob/eb95e8f53e56e25ce8f0898ee6936d8201bd9a29/src/etc/devd/ifnet.conf
(calling rc.linkup which also boils down to the same event)
https://github.com/opnsense/core/blob/eb95e8f53e56e25ce8f0898ee6936d8201bd9a29/src/etc/rc.linkup#L60

@AdSchellevis, just checked it manually: if I call /usr/local/opnsense/service/configd_ctl.py interface newip $tinc_interface after Step 5 above, a VIP is not readded. Probably I have misunderstood your point. Otherwise adding such a line in tincd,py could easily resolve the problem.

@vnxme that should work indeed, maybe we're missing something here. If I have some time available, I'll try to setup something similar on my end.

@AdSchellevis, thanks in advance, your contribution is very much appreciated.
BTW, when Tinc is restarted, it is not only a VIP that disappears but also a network route. E.g. Tinc interface address is fc00::1/120 and a virtual IP is <IP_ADDRESS>/24. When I restart Tinc daemon or change configuration, netstat -rn4 does not have <IP_ADDRESS>/24 at all and netstat -rn6 has only fc00::1/128 (assigned to lo0) while the network route /120 is missing.
To fix network route /120 I have to do the following:

Remove a VIP (otherwise a red warning is displayed on the interface page)
Reassign the interface (go to Interfaces -> Tinc_Interface and click Save)
Restart Tinc daemon

@vnxme hmm, on my end it works like a charm, below my output:
root@OPNsense:~/core # ifconfig tinc0
tinc0: flags=8043<UP,BROADCAST,RUNNING,MULTICAST> metric 0 mtu 1500
	options=80000<LINKSTATE>
	inet <IP_ADDRESS> netmask 0xffff0000 broadcast <IP_ADDRESS>
	inet6 fe80::20c:29ff:feaf:8196%tinc0 prefixlen 64 scopeid 0x22
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
	groups: tun tinc
	Opened by PID 48813
root@OPNsense:~/core # configctl interface newip tinc0
OK
root@OPNsense:~/core # ifconfig tinc0
tinc0: flags=8043<UP,BROADCAST,RUNNING,MULTICAST> metric 0 mtu 1500
	options=80000<LINKSTATE>
	inet <IP_ADDRESS> netmask 0xffff0000 broadcast <IP_ADDRESS>
	inet <IP_ADDRESS> netmask 0xffffffff broadcast <IP_ADDRESS>
	inet6 fe80::20c:29ff:feaf:8196%tinc0 prefixlen 64 scopeid 0x22
	nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>
	groups: tun tinc
	Opened by PID 48813

<IP_ADDRESS>   is the address configured as vip:

@AdSchellevis, thank you for investing your time in it. I suppose, you a) used tun, not tap; b) used primary IPv4 (<IP_ADDRESS> in your example); c) used same address family VIP (<IP_ADDRESS> in your example). Although it does not sound reasonable, all these factors make a difference.
I spent another couple of hours experimenting with it and the problem I described seems to be a little more complex than just a configd_ctl.py call... Tomorrow I will try to document every detail to show you.
My first preliminary guesses are as follows:

There are some issues with TAP interfaces, e.g. no fe80::/10 link locals are created for them.
There is an issue with configd_ctl.py script when called on interface with primary IPv6 address: opnsense: /usr/local/etc/rc.newwanip: Failed to detect IP for TINC0[opt1] message in log.
There are some issues with IPv6 network routes: they disappear from time to time leaving only /128 address assigned to lo0 in netstat -rn6 output which breaks routing.

@vnxme the newipv6 is probably the one you're looking for if you would like to signal IPv6, in my case that would be configctl interface newipv6 tinc0 ppp interfaces seem to do the same for ipv6 only.
Maybe I can reproduce your issue after you supplied the additional information, I expect you only need some additions in tinc to make this functional.

The table below illustrates all the issues I identified in connection with the readding VIPs problem:

Unlike TUN interfaces, TAP interfaces do not have IPv6 link-local net+address pairs (fe80) though both have auto_linklocal option enabled - see red cells F37:G58;
Kernel/OPNsense loses (or fails to add) IPv6 networks while adding IPv6 link-local and primary net+address pairs - see red cells G14:G22, K26:K34, K50:K58 - it consequently breaks routing;
Kernel/OPNsense keeps (or fails to delete) IPv6 networks while deleting IPv6 alias net+address pairs - see red cells O21, O33 and O57;
Kernel/OPNsense keeps (or fails to delete) IPv4 alias net+address pair and IPv6 alias address for TAP interface while deleting corresponding net+address pairs - see red cells L42:M42 and L45:N45;
Configd_ctl.py fails to readd IPv6 alias network for TAP with primary IPv4 at step 10 - see red cell O46.

Unless you want me to open separate issue reports for the aforementioned facts, I suggest we should continue discussing them here.

@vnxme Most of your issues seem to be related to tap interfaces combined with ipv6, tap is hardly used on our end.
Just one question, if you do the following, it results in a tap interface without link local on your end (if I understand your chart correctly):

create new tinc network in switch mode
add a couple of hosts
apply settings

On my end it seems to create an interface with link local in this case. I'm afraid it will be quite labor intensive to debug your problem and at the moment I'm quite convinced that the issue isn't in core, but either a missing piece in Tinc or an upstream problem if it's very specific to tap interfaces.
By my knowledge we don't have similar reports about OpenVPN, which uses tun devices as well.
The tun plugin is something I wrote a long time ago for a customer, who eventually switched to a different setup, so unfortunately we're not really working on it ourselves at the moment (other than reviewing PR's and fixing minor bugs).

@AdSchellevis Yes, issues 1, 4 and 5 seem to be related to tap, but issues 2 and 3 are related to primary and virtual IPv6 addresses. The most crucial is the second one as it breaks routing (with no IPv6 network on interface packets are sent by OPNsense using default route which is wrong).
Yes, you are right, a tap interface is was created without link-local address. In my case the same is was true not only for Tinc (mode switch), but also for OpenVPN (mode tap) and Zerotier. Update: Actually I traced back this particular issue with tap interfaces to net.link.tap.up_on_open=1. I added it as it had been recommended by Zerotier pkg-message. I have removed it from System/Settings/Tunables and restarted, so tap interfaces are created with link-local addresses now.
I will rebuild the chart for switch (tap) cases shortly. Besides, I am going to propose an alteration to tincd.py as a part of PR 1733 so that tinc-up scripts properly trigger configd_ctl.py. Nevertheless, issues 2 and 3 are still valid.

@AdSchellevis Now, as we have an updated picture, it looks more or less symmetric in terms of tun/tap. Link-local addresses now work as expected.
As for issue 2, the pattern appears to provide for Kernel/OPNsense improper handling of the last added IPv6 addresses on interfaces

It handles link-local addresses properly (does not delete /64 net) when an interface has a primary IPv6 address (the primary is the last added one as fe80 is always added first);
It does not handle link-local addresses properly when it is the only IPv6 address, i.e. when an interface has a primary IPv4 address.

Issues 3 and 4 do not break anything for me but something is definitely wrong with how kernel/OPNsense handles VIPs.

on FreeBSD / IPv6, primary is a concept that doesn't really exist, some context about this can be found here https://github.com/opnsense/core/issues/3310.
Your statement about something being completely wrong in handing VIPs, I don't share, haven't seen proof of that to be honest and other interfaces implementing the correct events don't seem to be suffering from it.
If you can write steps how to reproduce the specific issue, it might be better to open a new ticket for that and close this one.
I can't spend more time on this subject, unless there is a clear direction on where it should lead.

on FreeBSD / IPv6, primary is a concept that doesn't really exist, some context about this can be found here #3310.

No, it does not exist. However, I believe it's a good way to make a distinction between an address assigned by the corresponding daemon (I indicated on the chart that primary addresses are assigned by Tinc in my case) and an alias address assigned by some firewall scripts. Haven't realy found anything related to the issue I described in #3310.

Your statement about something being completely wrong in handing VIPs, I don't share, haven't seen proof of that to be honest and other interfaces implementing the correct events don't seem to be suffering from it.

Sorry, I did not intend to hurt you or anyone else by my statement. I provided you with the results of my tests showing that e.g. when in switch mode at step 9 (tincd restart) the system's netstat -rn4 and -rn6 output have VIPs while they should not be there (false positives).

If you can write steps how to reproduce the specific issue, it might be better to open a new ticket for that and close this one.

It's a good idea, I will do that.

I can't spend more time on this subject, unless there is a clear direction on where it should lead.

Thank you again for your time and effort!

Sorry, I did not intend to hurt you or anyone else by my statement. I provided you with the results of my tests showing that e.g. when in switch mode at step 9 (tincd restart) the system's netstat -rn4 and -rn6 output have VIPs while they should not be there (false positives).

No offence taken, just saying there's not enough to point to a general core issue yet.

@AdSchellevis You are right it is not a core issue. I managed to resolve the missing IPv6 network route issue (number 2 and I believe it also includes issues 3 and 4 above) by destroying tun/tap interface each time Tinc stops/restarts. Suggested changes are in PR 1733.


clean up structure around cat command, and what it does

in https://eksworkshop.com/calico/stars_policy_demo/create_resources/
at
Let’s examine our file by running cat namespace.yaml.

kind: Namespace
apiVersion: v1
metadata:
  name: stars

Create a namespace called stars:

cat command should be copy/pasteable, and the yaml body should not be.

further down as well:
cat management-ui.yaml:

https://eksworkshop.com/calico/stars_policy_demo/apply_network_policies/
Let’s examine our file by running cat default-deny.yaml.

https://eksworkshop.com/calico/stars_policy_demo/directional_traffic/
Let’s examine this backend policy with cat backend-policy.yaml:

I believe this has been addressed with a recent edit. Please reopen if it's still a problem.


Program Files variable incorrectly has space included.

Variable for Program Files incorrectly has a space in it, in the following
Copy robocopy.exe to the %Program Files%\FSLogix\Apps folder as frxrobocopy.exe
Add an exclusion for the anti-virus product for %Program Files%\FSLogix\Apps\frxrobocopy.exe

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 210b2987-c214-abe0-d248-8e851b4ba043
Version Independent ID: 09e4be89-9877-af60-9ab5-a9a4defe11fd
Content: FSLogix installed components and functions - FSLogix
Content Source: fslogix-docs/fslogix-installed-components-functions-reference.md
Product: fslogix
GitHub Login: @SteveD-MSFT
Microsoft Alias: stdowns

Updated - changes will be live by EOD


KAFKA-2793: Use ByteArrayDeserializer instead of StringDeserializer for keys in ConsoleConsumer with new consumer.

LGTM.
Committing to trunk and cherrypicking to 0.9.0, since this is a small but important change.


Testing the instance of "BindType" but using "Type" afterwards.

A "ClassCastException" is thrown in the case of an HQL query with a "ManyToOne" relationship.

When modifying the query to a native query, there is no issue anymore.

Thanks for your attempt to contribute, but please create a fresh PR against the main branch and include a test case that provokes this bug.


Lay/reset on hunter traps.

Full left click hunter. Lay/reset as #1 option.

You commited .class instead of .java file


Environment variables replacement

Replacement of env-vars for config file using double curly braces {{ ENV_VAR }} .

Pull Request Test Coverage Report for Build 415290193

31 of 35 (88.57%)  changed or added relevant lines in 1 file are covered.
331 unchanged lines in 12 files lost coverage.
Overall coverage increased (+0.1%) to 58.164%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/config/loader/config.go
31
35
88.57%

Files with Coverage Reduction
New Missed Lines
%

internal/agent/event_sender_vortex.go
1
73.21%

pkg/config/defaults.go
1
66.67%

pkg/metrics/sampler/sampler_routine.go
2
94.74%

pkg/integrations/v4/logs/cfg_watcher.go
4
67.5%

pkg/helpers/network/network_helpers.go
12
65.85%

pkg/integrations/v4/emitter/emitter.go
15
58.33%

pkg/plugins/http_server.go
21
62.9%

pkg/plugins/plugins_linux.go
24
0%

internal/plugins/linux/hostinfo.go
27
12.14%

internal/integrations/v4/integration/integration.go
52
52.56%

Totals

Change from base Build 405458512:
0.1%

Covered Lines:
11388

Relevant Lines:
19579

💛  - Coveralls

Pull Request Test Coverage Report for Build 415290193

-4 of 35 (88.57%)  changed or added relevant lines in 1 file are covered.
324 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.1%) to 58.195%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/config/loader/config.go
31
35
88.57%

Files with Coverage Reduction
New Missed Lines
%

pkg/config/defaults.go
1
66.67%

pkg/helpers/network/network_helpers.go
12
65.85%

pkg/integrations/v4/emitter/emitter.go
15
58.33%

pkg/plugins/http_server.go
21
62.9%

pkg/plugins/plugins_linux.go
24
0%

internal/plugins/linux/hostinfo.go
27
12.14%

internal/integrations/v4/integration/integration.go
52
52.56%

cmd/newrelic-infra/newrelic-infra.go
58
7.49%

pkg/config/config.go
114
70.71%

Totals

Change from base Build 405458512:
0.1%

Covered Lines:
11394

Relevant Lines:
19579

💛  - Coveralls

Pull Request Test Coverage Report for Build 415290193

31 of 35 (88.57%)  changed or added relevant lines in 1 file are covered.
324 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.1%) to 58.195%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/config/loader/config.go
31
35
88.57%

Files with Coverage Reduction
New Missed Lines
%

pkg/config/defaults.go
1
66.67%

pkg/helpers/network/network_helpers.go
12
65.85%

pkg/integrations/v4/emitter/emitter.go
15
58.33%

pkg/plugins/http_server.go
21
62.9%

pkg/plugins/plugins_linux.go
24
0%

internal/plugins/linux/hostinfo.go
27
12.14%

internal/integrations/v4/integration/integration.go
52
52.56%

cmd/newrelic-infra/newrelic-infra.go
58
7.49%

pkg/config/config.go
114
70.71%

Totals

Change from base Build 405458512:
0.1%

Covered Lines:
11394

Relevant Lines:
19579

💛  - Coveralls


Implicitly convert percentages better

Currently the behavior is not what you would expect (See #164).
In practice, percentages are usually used as scalar multipliers,
not as "units" in the traditional sense.
## Propsed Change to Multiplication

This was a failure, it broke too many internals
I propose changing the rules of multiplication to treat percentages as unit-less scalars in some situations.
This means 80 kg * 5% will now return 4 kg, instead of "400 kg %".
There is one case when the percentage is not converted into a scalar:
If it is on the left hand side, and no other units are involved.
In this case, the user most likely intended the query to be about the percentage itself.
This means "5% * 5% = .25%" and "5% * 5 = 25"
If the percentage is on the right hand side, then it is unconditionally converted,
regardless of whether other units are involved.
This means "100 * 5% = 5", despite the fact that "5% * 100 = 500%"
Although in a sense this makes the operation non-commutative,
this is really just a UI thing (the underlying value is the same).

New rules to simplify percentages
Here are the new rules added to the simplify function specifically for percentages.

If there are any other units (kg, lbs, etc..) then all of the percentages are removed (fixing first problem)
No more than one "percentage unit" is permitted.

Rule one fixes cases like 5% * 80kg = 400 kg % (changes to give correct result of 4 kg.
Rule two fixes case like "5% * 5% = 25%^2" (changes to give correct result of 0.25%)
Ambiguous case
With the above rules, there is still one ambiguous case: 5% * 100
Should it be parsed as "5% of 100" (giving 5) or as "100 time 5% (giving 500%).
The current rules parse it as the latter, which may be unexpected.
It is not really possible to adjust the simplify function to give the result "5". At that point the internal value is already 500%, and stripping the percentage here would just strip all percentages.
Proposal to overload of
I propose overloading the of operator specifically to handle this case with percentages. We would have 5% of 100 == 5, while multiplication would give 500%. This would clear up any ambiguity (although I would probably file a separate issue/PR).
It should not cause issues with any other operations, since it would only activate when a percentage is on the left-side of the of operator (similar to how string concat is special-cased in many languages).
Problems

[x] Fix current test failures

Probably need to move conversion logic from mul -> simplify

[x] Add new tests for new behavior

I re-enabled the five_percent_times_five_percent test which was previously marked as #[ignore]

[x] Remove dbg! statements
[ ] Consider "ambiguous case" I brought up (not a blocker)
[ ] Documentation on wiki?

Fixes issue #164

Thank you so much for the PR!!
The changes look really good and make a lot of sense, so I'll go ahead and merge this. I don't think the slight ambiguity you identified is too important, so I'd probably just leave it the way it is.
Overloading the of operator is a good idea, I'll add it to the issue tracker.
Thanks again for putting in all that work :)


Unexpected token(1:0)

./node_modules/react-native-leaflet-view/lib/module/LeafletView/index.js:22:7
Module not found: Can't resolve '../../android/src/main/assets/leaflet.html'
20 |
21 | const LEAFLET_HTML_SOURCE = Platform.select({

22 |   ios: require('../../android/src/main/assets/leaflet.html'),
|       ^
23 |   android: { uri: 'file:///android_asset/leaflet.html' },
24 | });

@pavel-corsaghin

@miallo help me~~~

How to enable CRS.Simple

I am sorry for the late response... Is this still a problem for you? Can you verify, if ./node_modules/react-native-leaflet-view/lib/android/src/main/assets/leaflet.html exists? Did you run npm run ios after installation?

I am sorry for the late response... Is this still a problem for you? Can you verify, if ./node_modules/react-native-leaflet-view/lib/android/src/main/assets/leaflet.html exists? Did you run npm run ios after installation?


Do not use llvm.smul.with.overflow.i64 anymore

as it might not be available on some 32 bit systems (verified for an illumos system by @jasonbking ).
The required runtime function __mulodi4 is not available from the gcc runtime library on these systems, it seems.
This change should not have any performance impact, as already verified in #2645 .
See also:

https://bugs.llvm.org/show_bug.cgi?id=14469
https://bugs.llvm.org/show_bug.cgi?id=16404

@vassilvk confirmed on IRC that the same issue also appeared on a 32 bit ubuntu 16.04 machine. So it seems to be indeed related to 32 bit compiler runtime libraries (libgcc, compiler-rt) not providing __mulodi4.
This issue only appeared recently with the merge of #2645 but it exhibited a but that was existing beforehand when I64.mulc would have been used, so i go with the changelog - fixed label.


Create Sowmya_M.md

Notes for Reviewers

This PR fixes #

Signed commits

[x] Yes, I signed my commits.

Thank you @Sowmya7501 :rocket:


remove custom-mixins.less from build process

:+1:
Note that this also converts an heading tag, replaces sidebar icons w/ images (rather than the icon font), and replaces an instance of <i> with <span>


⚠ Blutopia has degraded performance

In 8719e0d, Blutopia ($BLU) experienced degraded performance:

HTTP code: 502
Response time: 15228 ms

Resolved: Blutopia performance has improved in e000c4c after 1 hour, 14 minutes.


Benchmarking git submodule not cloning

Hi,
by cloning Attabench repository (folowing the installation step 1) i was not able to build the project.
It was required to manually add the files from Benchmarking submodule.
Am i the only one with this issue?

@cserban by adding --recursive option solves the issue for me:
git clone https://github.com/attaswift/Attabench.git --recursive

Thank you!


gradle plugin for consumer api generation

According to https://github.com/Netflix/hollow/issues/31
I need some help - push commits or give explanation, whatever fits you best

I am not sure what is correct way for publishing plugins and stuff under Netflix TM, should it be published to some special place or directly to https://plugins.gradle.org/ ? I haven't published it yet anywhere, so only local publishing is available at the moment if you wanna see it in action

It's also a question for me - how to version plugin - separately from hollow-core (if so - then what is it - 1.0.0 or 0.1.0?) or inherit from root

And my english is not very good, so README might be kinda awkward and some names over-detailed

@IgorPerikov
(1) I'm not certain, either. Let me get back to you. My first thought is that something as special purpose as a Hollow gradle plugin doesn't belong in plugins.gradle.org. Stay tuned.
(2) Maybe we should go with having the plugin exist as a standalone project? This probably depends on the outcome of (1). If we move to a separate project I recommend starting with a 0.y.z that we bump to 1.0.0 once stable. Stay tuned on this as well.
(3) No worries. Create a README.md that you think will help people use the plugin. We'll assist you with the editing.

Hi @IgorPerikov.
I got some advice from our gradle plugin experts. Here's the plan:

Build it using the "Nebula plugin" plugin. http://nebula-plugins.github.io/
Use a stand-alone project with its own repository

initially we can work from a repository you create or if you prefer I'll create a Netflix/hollow-plugin
when we're ready to release (or have an RC) we'll move it under the nebula-plugins org as nebula-plugins/nebula-hollow-plugin

Prior to release we'll test out the plugin by doing local maven publishes
After release the Nebula system will automatically publish the plugin artifacts to Bintray and the Gradle Plugin Portal for us

Confirming that we should start with a 0.0.1 or 0.1.0 version. We'll switch to 1.0.0 when we move it under the Nebula umbrella.
Does that help, @IgorPerikov?

This is a relatively minimal nebula plugin project you can use as a starting point:
https://stash.corp.netflix.com/projects/NEBULA/repos/nebula-ospackage-node/browse

Hi @toolbear! Yes, sure, it clears up all the questions.
Just one moment

https://stash.corp.netflix.com/projects/NEBULA/repos/nebula-ospackage-node/browse

sadly it's not available for me, is it under internal access only?

@IgorPerikov yes, my mistake, that plugin isn't available yet. Also, I'm going to redact that repo URL.
One of our gradle plugin wizards looked at this PR and said your plugin looks idiomatic, so perhaps following  http://nebula-plugins.github.io/ will be sufficient for you to incorporate the nebula-plugin-plugin? If not, I can find a suitable, public plugin repo for you to use as reference.

@toolbear thanks, yes, I've looked through some nebula plugins and, guess, it would be enough

@toolbear, I've just realised, that it would be better if you'll create some empty Netflix/hollow-plugin repo as you mentioned before. Currently all subprojects receives general stuff from parent script that is useless for plugin (like nebula.netflixoss plugin).

Hi, @toolbear! I finished plugin as a standalone project, if separate repo is a problem, I can push it to my own repo. Just wondering - would it be a problem further or not

https://github.com/Netflix/hollow/issues/31#issuecomment-289195125


/api/dcim/interfaces?form_factor=0 (Virtual Interface) returns 0 results

Environment

Python version:  Python 3.4
NetBox version:  2.4.8

Steps to Reproduce

Create a virtual interface (form_factor=0)
Create a LAG interface
Create a Physical 10GBE Interface (form_factor=1000)
Run an API query against /api/dcim/interfaces?form_factor=0
Result will be a count: 0
Run an API query against /api/dcim/interfaces?form_factor=200
Result will be a count of at least 1 (depends on environment)

Expected Behavior

API will return virtual interfaces for form_factor=0
API will return LAG interfaces for form_factor=200
API will return 1000GBE interfaces for form_factor=1000

Observed Behavior

API does not return interfaces for form_factor=0
API returns interfaces for form_factor=200
API returns interfaces for form_factor=1000

I believe this is strictly related to form_factor=0 only, however I don't have time to investigate further today.  I did test this on a clean netbox 2.4.8 as well.

Appears to be related to the fact that 0 is treated as a null value.
To fix:
   form_factor = django_filters.MultipleChoiceFilter(         choices=IFACE_FF_CHOICES,         null_value=None     )


Adding '--tag' to install.sh to simplify pre-release or specific version install locally

Adding a 'feature' to the install script for Linux users that allows specifying the --tag on installation.
Why
There will be times where we'll want to allow early-adopters to quickly access and test new features; however, they're not stable enough for a release.
Solution
Allow the user to specify a dynamic tag on the install.sh script. The script is 100% backwards compatible with current functionality and acts exactly the same without the 'tag' argument.
Error Handling
In the case the user doesn't specify a tag or specifies 'latest' they'll get the exact same functionality today.
If they specify a tag which is semantically invalid based on historical tag scheme, e.g. v[number].[number].[number] then the system will exit in an error. This can easily be removed if the scheme changes.
If the user specifies a valid tag name that doesn't exist, the download can't be found, or github is down then the script fails and provides an error to specify that the download failed.
In both cases, trying again with the 'latest' release would provide the user a potentially confusing understanding of their local state where they may miss the error output and think they're running a newer or different version of the tool.
Follow on Work
If this PR is accepted, we may want to consider documenting in the core readme where we discuss this process
curl -fsSL https://ollama.com/install.sh | sh
To share how to download a specific tag. I wouldn't think removing the existing simple script is a good idea bc it complicates the experience for new users.
curl -fsSL https://ollama.com/install.sh | sh -s -- --tag "$TAG"

Thanks so much for the PR! I appreciate you taking the time to add this flag. As of recent, this can be done with the OLLAMA_VERSION variable:
curl -fsSL https://ollama.com/install.sh | OLLAMA_VERSION=0.1.34 sh


Specify property update payload can't be replayed

Update messages shouldn't be replayed. We should:

[ ] Specify this property formally.
[ ] Write tests for it
[ ] Adapt the executable spec to make sure the tests pass

This is not a responsibility of the update layer. We use the replay protection provided by the ledger layer. See the Shelley design spec for details on how replay protection is achieved.


Make tools/generate-identifier-regex.js respect ES6 identifier grammar

This is the first step towards fixing https://github.com/estools/esutils/issues/11.

Usurped by revisions to #12. Thanks for the submission!


error when generating a module without vuex

Describe the bug
Generating a module without vuex breaks application.
To Reproduce
Steps to reproduce the behavior:

clone the repo

git clone https://github.com/vuesion/vuesion

cd directories

cd vuesion

install dependencies

npm install

generate module without vuex

npm run generate

Select -> module
What should it be called? -> test
Do you want routes? -> Y
Do you want vuex? -> n

run dev server

npm run dev

Failed to compile.

ERROR in ...vuesion/src/app/test/Test/Test.vue(26,28):
TS2307: Cannot find module '../module'.
No lint errors found

Expected behavior
generate a static page without vuex
Desktop (please complete the following information):

OS: IOS
Browser chrome
Version Chrome 73

@NickRossBrown thank you for reporting.
I didn't come to a point where I covered all the cases in the templates (I only implemented the happy path). I am not quite sure which priority this issue will get.
Sorry for the inconvenience, I hope it's not a blocker for you to remove this line in the test and run it again.

Not a blocker for me at all. I just want to help were I can. This repo is amazing. I would submit a pull request, but I am confused on how to implement changes to the generate script.

Additional notes about the Issue

After removing that line 26, then throws an error from the beforeCreate() and prefetch hooks calling the module. Removing all those lines allows the application to run again.

Removing those lines from the file located at .vuesion/generators/connected/connected.vue.hbs allows the generator script to create a working static page (which have to be added back to generate modules with vuex)

Hey @NickRossBrown,
thank you very much! that is a big compliment and gives a lot of motivation to all of us working on that project.
I like to encourage you to contribute and create your first PR in this repository. I will point you to the parts that you have to understand in order to implement this feature.

handlebar templates, you need to know the if-else syntax in handlebars because this is what the templates are based on (https://handlebarsjs.com/builtin_helpers.html)
the variables you have to build your logic on can be found here: https://github.com/vuesion/packages/blob/master/packages/service/src/generators/module/index.ts (in your case it would be wantVuex and maybe wantRoutes)
all the above can then be added to the vuesion templates for modules (https://github.com/vuesion/vuesion/tree/master/.vuesion/generators/module) and connected components (https://github.com/vuesion/vuesion/tree/master/.vuesion/generators/connected)

you might also want to read our contribution guidelines first (https://github.com/vuesion/vuesion/blob/master/.github/CONTRIBUTING.md)
If you need more information, please let me know 😊


Source Berry Bushes do not auto harvest on BlazeBloom Soil

Just Dire Things version
1.4.2
Minecraft Version
1.21.1
(Neo)Forge Version
21.1.61
Modpack & Version
Direwolf20 1.21 version 1.2.1
Do you have optifine or Rubidium installed?
None
Describe the issue
Sourceberry Bushes on Blazebloom soil do not get harvested
Steps to reproduce

Create BlazeBloom Soil
Plant Sourceberry
Never gets harvested automatically

Note: It would be great if this also worked on Pumpkin and Mellon Steams as well.
Expected behaviour
Should be auto harvested like other crops
Screenshots
No response
Log files
No response
Additional information
No response

Should be resolved by: https://github.com/Direwolf20-MC/JustDireThings/commit/08aceef72e41019e9d24127f96f1be49d8a50192
Thanks!


PreviewMap : Zoom interaction

Question
Hi,
I'm a new user of your great tool and sorry if the question has been already asked.
I'm just wondering why we cannot zoom on the Preview Map component ? It seems to be disabled.
I think it would be interesting for the users to see when the rules is applied or not depending zoom level (defined by the min. scale and max. scale) and see the rules sequence.
Maybe does it exist a technical limitation ?
Thanks!

Happy to hear that you like our tool!
You can configure interactions on the PreviewMap component via its interactions property (see here).
This property expects a list of OpenLayers interactions.
I just noticed that the PreviewMap component is missing in our docs. We will add it soon.

Thank you for your reply ! I will try to add the interactions like zoom. Maybe it will be useful to see the zoom interaction in the demo app.

Maybe it will be useful to see the zoom interaction in the demo app.

Absolutely agree with you on that.
It would be awesome, if you can provide a PR for that to geostyler-demo.


Camera-DmgUld-JwtTest

Latest RN Camera added
Registration Page Created
JWT Auth/Token Handling using MobX implemented
Damaged Ulds module merged

Latest RN Camera added
Registration Page Created
JWT Auth/Token Handling using MobX implemented
Damaged Ulds module merged


Consider using mozjpeg instead of jpegtran in PostProcessor?

Google PageSpeed flagged a couple of images as being more compressible then they currently are, even with PostProcessor installed. In some cases it was suggesting up to 60% savings on what was currently being served.
After further investigation, it seems that a lot of vendors have adopted mozjpeg instead of jpegtran. The following site allows you to test this for yourself:
https://imageoptim.com/mozjpeg
The following is an image that had been resized by ImageProcessor and with quality set to 80, coming in around 20KB

The following is the same image after being processed by mozjpeg at the URL above on the default settings, coming in at 8KB

Yeah, been considering that for a while... Struggling to cope with time just now though.

Is the 20kb image postprocessed? I.e you cleared cache before installing postprocessor.  Diff seems awfully high if so. Jpegtran is better than that.

Correct - went to the trouble of grabbing the embedded jpegtran and running the command below (same as source).
jpegtran -copy all -optimize img.jpg img.jpg

I suspect the image was already optimised, as it only saved me around 500 bytes. I was pretty shocked at the difference mozjpeg made to file size.

Seriously impressive then! I'll have a look asap... In the interim, if you get time and the opportunity to PR please let me know

Will see if I can get it into the next sprint, as the savings do sound significant for JPEG-heavy sites.

Fixed with https://github.com/JimBobSquarePants/ImageProcessor/commit/871fa4a06b8784e85ca4f75cac8566387dd41dfb


Emscripten?

Does anyone know if sdl-gpu works with emscripten? And if not, any possibility for emscripten support?

Not officially, but I got it to work. Unfortunately I'm not confident enough with cmake to submit a PR: https://github.com/grimfang4/sdl-gpu/issues/68#issuecomment-345543582
PS. I might be wrong about some of the flags, WebGL2 is supposed to support OpenGL ES3, but I've got it working with only OpenGL ES2 enabled. I plan to play around with it more in the future, but it's just a proof of concept for now.

I just pushed a commit to make things work better with Emscripten and CMake.  I was able to build SDL2 and SDL_gpu as static libs and link them in a test program.


create tlsProxy service

Problem statement
This PR enabled Gateway API TLS conformance by creating a new TLSProxy service with ports 443->8899 (in Kong), as the conformance tests need to use port 443. The service has been created in KIC when running the conformance test suite, but it is a temporary solution, as we need to create such a service through Helm, as we do for the udpproxy service.
Acceptance Criteria

[ ] a new TLS service that maps Kong's port 8899 on port 443 can be created by setting the proper arguments.

@randmonkey we should wait for https://github.com/Kong/kubernetes-ingress-controller/pull/3797 to be accepted by the team and merged before working on this one. The Additional service solution is still under discussion.


__is_pod(T)

It is Ok to mention?

cl.exe intrinsic __is_pod(T)
std::is_pod<> deprecation as from C++20

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 249da7e2-4135-6468-221b-d62df3af0f22
Version Independent ID: 2e68cba5-e743-2d88-7b4c-7bb6f79c54cd
Content: Trivial, standard-layout, POD, and literal types
Content Source: docs/cpp/trivial-standard-layout-and-pod-types.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@DBJDBJ
I'm inclined to say it's not necessary to mention __is_pod(T), as that's a Microsoft-specific implementation detail that could change, and probably shouldn't be used anywhere except the library implementation of std::is_pod.
The deprecation, on the other hand, is worth mentioning. I wasn't previously aware of it as specifically deprecated, just that there were now more specific tests for is_trivial and is_standard_layout. Thanks for pointing that out.

cl intrinsics are one very interesting subject.  Why is each made, when etc ... That would be a real thriller book.


Fixes #126 by checking JsonArray elements before casting to JsonObjects

Fixes #126 by checking JsonArray elements before casting to JsonObjects
Does not address any other parsing exceptions that could cause a similar problem.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: timothyolt sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Closing this PR because Contribution License Agreement is not signed after more than a year. Taking the fix in #140.


Security: Limit the number of outbound peer connections when dialing new peers

Motivation
Zebra has no limit on the number of open outbound connections. This is a remote distributed denial of service risk.
It's not currently happening on the network, but it might be easy for malicious nodes to trigger, so we should fix this issue soon.
Solution
Limit the number of outbound connections to 75. (Just under one third of the number of Zcash peers, as of March 2021.)

[ ] add a method to CandidateSet that returns the number of live Responded peers in the AddressBook
[ ] In crawl_and_dial, drop the demand signal if the number of live Responded peers is more than 75

Alternatives
We could limit the number of PeerSet services directly, rather than via the CandidateSet/AddressBook #1851. But this risks denial of service attacks where inbound peers fill up all our connection slots.
Ideally we want to directly limit the number of open TCP connections, but that's a bit hard to do in our architecture. The PeerSet is the closest we can get.
We could make the maximum number of connections configurable #1429
We could make the number of open connections depend on the number of available file descriptors #1429
Context
zcashd does not have this issue, it only makes 8 outbound connections by default.

We can fix this issue after the mempool works


Mirror mode does not render shadows

Figured this one out (Non-inverted G_TRI2 call in the game code). Will hold off on pushing this fix until after my current PR


Use openssl on Unix rather than C functions directly for SHA256

Takes on an extra dependency, but removes unsafe code in the process.
@alexcrichton I was a little confused by what you were saying on IRC, so I went ahead and just speculatively made this. No worries if it is no good.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+ 2a66dfba1f29cabf434ccdb73738ed9b46a00716

:hourglass: Testing commit 2a66dfb with merge 01bdd66...

:sunny: Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: alexcrichton
Pushing 01bdd663f357fe1f853190018e18e611bba449d8 to master...


How to setup local dependencies to test local changes to react-scripts

I need to make a tweak to react-scripts/config/webpackConfigDev.config.js (specifically just this change: https://github.com/laran/create-react-app/commit/f4a241aed8620837dec92ee5012e56069a8a8b0b) and then use that locally. I've pulled down a local copy and wrestled for an entire day with npm link, yarn link, lerna and yalc to try to set my own project to depend on my local clone of create-react-app, but I've been unable to get it to work properly.
I'm probably missing something simple. But what I've done so far always has some of the dependencies among the local copies of the create-react-app packages unsatisfied and my app then throws errors when trying to load a script usually from react-dev-utils, react-error-overlay or babel-plugin-named-asset-import.
A simple walkthrough or set of instructions would be super helpful. My apologies if I just missed something super simple. But some simple instructions would be super helpful. Thanks!

Run yarn and let Yarn Workspaces do its thing. Link react-scripts up via:
$ cd packages/react-scripts/
$ yarn link

Go to your package you want to test in and wipe node_modules, run yarn, and link to react-scripts:
$ # your project folder
$ rm -rf node_modules/
$ yarn
$ yarn link react-scripts

Let me know if you need more help!


Refactor WorkerServer

Background
WorkerServer executes task by scanning ZK and DB. When WorkerServer starts, it try to retrive the lock in zk, and then executes task by loading data from DB. This is not nice for distributing system, and the current implementation will result in delay executing task.
Suggestion
We wanna use tcp channel to refactor WorkerServer.
General Implementation Idea

Using Netty for our tcp framework.
MasterServer keeps the current logic and when it picks a task, directly sends it to target worker using RoundRobin policy.
WorkerServer will start up as predefined group and register itself to zk node.
WorkerServer will start a tcp server listening port for executing task instead of scanning ZK and DB.
Executing result will send back to the MasterServer node using the previous channel.

General Failover Idea

For WorkerServer, only it receives the task command and gives back the ack command to keep the task is acknowledged.
If the WorkerServer executes the task normally, it will send back the result by the previous channel.
If the WorkerServer died after receiving a task, MasterServer will use execution-timeout time to ping WorkerServer to detect liveness. If ping failed, try another worker node. In this case, task may execute more than once.
If the MasterServer died after sending out the a task, WorkerServer will retry to rebuild the channel with N times to the original MasterServer. If failed after retry times, choose a new MasterServer to send back the result.  New MasterServer will analysis the task, decide the next process. (Stop or continue execute by instanceId/processId, or just update the status)

If the suggestion takes into consideration, I will lead the job

MasterServer keeps the current logic and when it picks a task, directly sends it to target worker using RoundRobin policy.
what's the mean 'directly sends it to target worker using RoundRobin policy.'

WorkerServer will start up as predefined group and register itself to zk node.
what's the ‘predefined group’

WorkerServer will start a tcp server listening port for executing task instead of scanning ZK and DB.

Executing result will send back to the MasterServer node using the previous channel

all of above process need stable communication network,  what should to do in unstable situation?

MasterServer keeps the current logic and when it picks a task, directly sends it to target worker using RoundRobin policy.
what's the mean 'directly sends it to target worker using RoundRobin policy.'
RoundRobin's chinese name is "轮询"

WorkerServer will start up as predefined group and register itself to zk node.
what's the ‘predefined group’
I'm also curious，haha

all of above process need stable communication network, what should to do in unstable situation?
netty can easily implement this

If the WorkerServer died after receiving a task, MasterServer will use execution-timeout time to ping WorkerServer to detect liveness. If ping failed, try another worker node. In this case, task may execute more than once.

I have a question about this, why not use zookeeper to monitor whether the worker alive or not ?  ping method seems old

If the WorkerServer died after receiving a task, MasterServer will use execution-timeout time to ping WorkerServer to detect liveness. If ping failed, try another worker node. In this case, task may execute more than once.

I have a question about this, why not use zookeeper to monitor whether the worker alive or not ? ping method seems old

why not use zookeeper to monitor whether the worker alive or not ? +1

MasterServer keeps the current logic and when it picks a task, directly sends it to target worker using RoundRobin policy.

Whether or not to consider If the worker is out of memory or system resource?

Regarding the third point of Failover, my consideration is this. When the MasterServer before assigning tasks to WorkerServer, the first step is to insert the task into the DB to generate an id, then send the task id to the WorkerServer for execution.
It is assumed that the WorkerServer dies or the network overlaps after receiving the task, the MasterServer does not receive a task execution heartbeat from the WorkerServer within a certain period of time, it indicates that the task execution failed, and the MasterServer modifies the task status in the DB to a failed state.
After that, if the network recovers and receives the heartbeat of the task that has been marked as failed before, the MasterServer directly sends a task termination command to the WorkerServer.
If the user sets the number of retries, the task is retried in the MasterServer, and if not, an alert is send.

zookeeper

I said : WorkerServer starts up listening a port and registers itself to zk. So when MasterServer schedules a task , it can get the worker list .  But when MasterServer sends out a timeout with 5s task, and WorkerServer crashes after giving back acknowledge. In this case, we have to ping the workerServer after 5s, not relies on zk.
Let talk about ping :   Ping is a type msg with empty body in self defined binary protocol in most Rpc framework . Not ping command in OS system.

MasterServer keeps the current logic and when it picks a task, directly sends it to target worker using RoundRobin policy.

Whether or not to consider If the worker is out of memory or system resource?

Yes, not in this phase. As tcp channel comes, some more functions should be taken into consideration.

Regarding the third point of Failover, my consideration is this. When the MasterServer before assigning tasks to WorkerServer, the first step is to insert the task into the DB to generate an id, then send the task id to the WorkerServer for execution.
It is assumed that the WorkerServer dies or the network overlaps after receiving the task, the MasterServer does not receive a task execution heartbeat from the WorkerServer within a certain period of time, it indicates that the task execution failed, and the MasterServer modifies the task status in the DB to a failed state.
After that, if the network recovers and receives the heartbeat of the task that has been marked as failed before, the MasterServer directly sends a task termination command to the WorkerServer.
If the user sets the number of retries, the task is retried in the MasterServer, and if not, an alert is send.

Yes, very good . we should do like what you said.
Task has many different status in scheduling system, we have to insert DB before scheduling.

zookeeper

I said : WorkerServer starts up listening a port and registers itself to zk. So when MasterServer schedules a task , it can get the worker list . But when MasterServer sends out a timeout with 5s task, and WorkerServer crashes after giving back acknowledge. In this case, we have to ping the workerServer after 5s, not relies on zk.
Let talk about ping : Ping is a type msg with empty body in self defined binary protocol in most Rpc framework . Not ping command in OS system.

I think zk can do this better,  if worker server down, zk can handle it immediately through listener/watch.   I assume you want to remove dependency about zk?

+1

what is “predefined group”？ and do you want to implement this predefined group in the first phase?

+1

I think this topic has been done, so I will close this issue


Build windows app package on PR

Use for now a static rootfs, do not do any other change, and pull
everything to latest.
This ensures we can always build before merging our windows app package
and attach it to the PR to sideload, without any further change.

ok, build passes and we don’t have duplicated files with the last PR. We should check in the future on how we can store a given rootfs closer to CI so that we don’t rely on cloud-images download slowliness and still be able to test the final product.


TAJO-1580: Error line number is incorrect

Modified to avoid adding useless new line characters

+1
Thanks for your contribution.
I found that this had printed right line at TajoMaster log file.


Lack of clarity

[Enter feedback here]
This version is a step back. As an owner of Microsoft Defender product in the FIS organisation I need to know  exactly what data is stored in Azure, so I can communicate it to a regulator. These details were available in the previous version of this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df30eb4f-795f-17a3-2a9a-a68c73a2ba75
Version Independent ID: d9f2b07e-0deb-2bc9-99e3-bdc4f7752914
Content: Microsoft Defender for Endpoint data storage and privacy
Content Source: microsoft-365/security/defender-endpoint/data-storage-privacy.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@mjcaparas Please help us in resolving this issue. Thanks

Looking at the history of this page - it hasn't gone through major updates apart from rebranding. Not sure what exact Azure info is being sought for.

The exact information on what Defender data is stored on Azure, can the Azure integration be disabled, what would be the implication?


Dead Link on "Using the Web API" page

Hello!
I want reading the documentation on using the Web API from the Bolt Python library and found there is a dead link on the page.
The source of the link is https://slack.dev/bolt-python/concepts/web-api/ and the dead link is in the first sentence for the link for "WebClient": https://slack.dev/python-slack-sdk/basic_usage.html
It's not obvious to me what the correct link is, so I am sharing here in hopes the team knows!
Thanks in advance!
The page URLs

https://slack.dev/bolt-python/concepts/web-api/

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi,
Can I work on this issue? Seems like a relatively straightforward fix


Center cards

For https://github.com/OpenCollective/OpenCollective/issues/185#issuecomment-234661223
.center === text-align: center;

Can you pull the latest from master so that the tests can pass?

@xdamman Already up-to-date, I've reran the tests

I merged master earlier. You might need to rerun tests without cache
On Tue, Jul 26, 2016 at 8:12 PM Ascari<EMAIL_ADDRESS>wrote:

@xdamman https://github.com/xdamman Already up-to-date, I've reran the
tests
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenCollective/opencollective-website/pull/373#issuecomment-235444412,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF0vPeFBXgqLNlna2b10Pzc6_Mi30WBqks5qZqJJgaJpZM4JVZYe
.


Backport AllowAssociatePublicIP

backport https://github.com/rancher/rancher/issues/15419

Tested with v2.1.1-rc4 . Created cluster with AllowAssociatePublicIP=False.
Cluster was created successfully.


[GLUTEN-8128][VL] Retry borrow when granted less than size in multi-slot and shared mode

What changes were proposed in this pull request?
Retry memory borrow when granted less than requested size in multi-slot and Gluten shared mode. If ThrowOnOomMemoryTarget cannot acquire memory, spill more memory and then retry.
(Fixes: #8128)
If the case in issue #8128 occurs, the first borrow(sizeA) will spill sizeA memory. After spill, if curMemory is greater than the maxPerTaskSize, we'll get 0 returned. So we retry spill(long.max), then re-borrow.

Add argument isDynamicCapacity when construct TreeMemoryTargets#Node, which means multi-task-slot and shared mode.

How was this patch tested?
Test with my production ETL.

Hi @kecookier thanks! Is this ready for review or still in draft?

Hi @kecookier thanks! Is this ready for review or still in draft?

@zhztheplayer Thanks, still in draft, more tests are needed for this PR.

@zhztheplayer This PR is ready. Can you help review it?

Can we just spill maxPerTaskSize memory in the first try? Since task1 can't allocate any "new" memory any more. The retry has high possibility to be triggered.

@FelixYBW  Good question. In gluten shared mode, the first spill is triggered by Vanilla Spark TaskMemoryManager, which only spills the requested memory. The spill size might be difficult to control easily within gluten.


Updated profile first/last to given_name/family_name

This modifies the fields coming from FreeIPA to fit the OpenID standard as commented in https://github.com/ubccr/mokey/issues/68

@jvinolas This is great, thanks so much. Can you please update this PR to just add the given_name and family_name attributes and keep first and last for now? Just so we don't break existing functionality. Thanks!

Should be fixed now.


Reset uno board form Fermentrack

During my first batch, Fermentrack lost signal from the 2 temp sensors after a couple of days.
Pressing the reset button on the Uno fixed the problem - is there a way a Uno reset command could be included within fermentrack, so you can remotely reset the board without having to physically access it?

If you restart the script (at least in BrewPi) the board will restart.

Thanks
What's the best way of restarting the script?  Can you do it via the web interface from another computer, or do you need to VNC / SSH into the pi?
Will you lose the ongoing log if you restart the script, or can it carry on logging?

I'm not actually a user of Fermentrack - but I am sure the script is there in a form.  Perhaps someone else will be able to help with that.
Restarting the script does not impact logging.  Since the controller is restarting anyway there will be a blip in controlling because of the normal "wait for heat/cool" but that's about it.
The nuclear option is rebooting the Pi. :)

I don't actually have a flashed Uno to test with, but I definitely have the functionality present in the firmware for the ESP port. I'll add a button to the controller settings page to trigger a restart.

Awesome - thanks
Regards
Rich Potter
Sent from my iPhone

On 17 Apr 2020, at 17:32, John<EMAIL_ADDRESS>wrote:

I don't actually have a flashed Uno to test with, but I definitely have the functionality present in the firmware for the ESP port. I'll add a button to the controller settings page to trigger a restart.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Reduce memory usage of watcher

According to topfreegames/maestro#473
kubernetes/kubernetes#103789
https://github.com/kubernetes/sample-controller/blob/master/docs/controller-client-go.md
https://github.com/kubernetes/client-go/blob/master/examples/workqueue/main.go
we're supposed to only put the key on the work queue, and retrieve it from the indexer when processing it.
But in https://github.com/elastic/elastic-agent-autodiscover/blob/e092f627f97a0224516c5c94d06e90326a80d28b/kubernetes/watcher.go#L243 it's storing the whole object
Then later it's using it to retrieve it by key
https://github.com/elastic/elastic-agent-autodiscover/blob/e092f627f97a0224516c5c94d06e90326a80d28b/kubernetes/watcher.go#L275

Having reviewed that code, I think it's fine and doesn't make any copies. obj is always a pointer to a k8s resource, so putting it in the queue doesn't copy it. The reason we need it is that we want to run handlers for delete events - and in that case, the object may not exist in the store anymore at the time our handler runs.

From my understanding, the updates keep coming in, then you add them to the queue with a reference to that version of the object.
If there are multiple updates coming in quickly, by the time it's getting "processed" it might already have been updated. But, we only care about the latest version, not each change, so we look up the current version in the store. But since we keep a reference to the old version in the queue it can't be GCed. So the only case we care about older versions is if it's a delete, so we should only keep it if it's a delete.

That's a fair observation, but I doubt this makes a significant difference in practice. It's rare to get updates for the same object so quickly, and worst case we just hold on to some references for a bit longer. This change would make the code more complicated. I'm not convinced it's worth it, would need to see evidence that it actually makes a difference.