Aliased relation in sub-query causes 'Serialization of 'Closure' is not allowed'

What steps will reproduce the problem?

Override find() of an ActiveRecord (say, Customer) to select from a subquery that does a joinWith an aliased(!) relation

return parent::find()->from([
    static::tableName() => Foo::find()->joinWith('bar b'),
]);

Set up a relation using the model (e.g. getCustomer()) in another model (such as Order)

public function getCustomer()
{
    return $this->hasOne(Customer::class, ['id' => 'customer_id'])
        ->inverseOf('orders');
}

Query for Order instance(s) joining with the customer relation.

Order::find()
    ->joinWith('customer')
    ->all();

What is the expected result?
Instance(s) of Order with related Customer instance(s) pre-fetched.
What do you get instead?
Exception with message 'Serialization of 'Closure' is not allowed'.
Additional info
Changing this line to convert the join definition to an array before serializing
$uniqueJoins[serialize(\yii\helpers\ArrayHelper::toArray($j, [], true))] = $j;

seems to help. I did not check for edge cases, so this may not be the solution.
EDIT: This is definitely not the solution, because only the public properties of objects used (if any) when building the query are accessible to the toArray() method. Therefore, if a, say, subquery was to be an instance of a class that has protected/private properties, the unique values of those properties would not set it apart from other instances of that very class having the same public property values.
Another solution (maybe somewhat closer to a real one) could be setting the keys of $uniqueJoins to serialized/hashed copies of relation definition arrays where object references are replaced by hashes as returned by spl_object_hash.

Q
A

Yii version
2.0.12

PHP version
7.0.22

Operating system
Ubuntu 16.04.3 LTS (GNU/Linux 4.4.0-91-generic x86_64)

After poking around the code a little I came up with this little gem:
public static function replaceObjectsWithHashes($array)
{
    $result = [];

    foreach ($array as $key => $element) {
        if (is_array($element)) {
            $result[$key] = self::replaceObjectsWithHashes($element);
        } else if (is_object($element)) {
            $result[$key] = spl_object_hash($element);
        } else {
            $result[$key] = $element;
        }
    }

    return $result;
}

(Yea, I know, see Two Hard Things)
Even though var_export yields a somewhat better performance (in addition to retaining private/protected property values and being able to serialize Closures without choking the same way as serialize does), it serializes all closures to the same single thing:
Closure::__set_state(array());

So objects, that are set apart by a closure (or several), would appear identical when represented by the output of var_export. Unlike objects represented to by their unique hashes.

For the past two months we've been using the following patch (via cweagans/composer-patches) in our production code and it seems to do the trick:
diff --git a/db/ActiveQuery.php b/db/ActiveQuery.php
index c25ea8d..12bfc9c 100644
--- a/db/ActiveQuery.php
+++ b/db/ActiveQuery.php
@@ -8,6 +8,7 @@
 namespace yii\db;

 use yii\base\InvalidConfigException;
+use yii\helpers\ArrayHelper;

 /**
  * ActiveQuery represents a DB query associated with an Active Record class.
@@ -460,7 +461,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
         // e.g. when joining a relation and a via relation at the same time
         $uniqueJoins = [];
         foreach ($this->join as $j) {
-            $uniqueJoins[serialize($j)] = $j;
+            $uniqueJoins[serialize(ArrayHelper::replaceObjectsWithHashes($j))] = $j;
         }
         $this->join = array_values($uniqueJoins);

diff --git a/helpers/BaseArrayHelper.php b/helpers/BaseArrayHelper.php
index a395f6f..01e8a46 100644
--- a/helpers/BaseArrayHelper.php
+++ b/helpers/BaseArrayHelper.php
@@ -882,4 +882,30 @@ class BaseArrayHelper

         return $result;
     }
+
+    /**
+     * Returns a copy of the array where all object references replaced with SPL hashes.
+     *
+     * NB! Once an object is destroyed, its hash may be reused for other objects.
+     * @see spl_object_hash()
+     *
+     * @param array $array
+     * @return array
+     */
+    public static function replaceObjectsWithHashes($array)
+    {
+        $result = [];
+
+        foreach ($array as $key => $element) {
+            if (is_array($element)) {
+                $result[$key] = self::replaceObjectsWithHashes($element);
+            } else if (is_object($element)) {
+                $result[$key] = spl_object_hash($element);
+            } else {
+                $result[$key] = $element;
+            }
+        }
+
+        return $result;
+    }
 }


Update VMWare Exporter and Add Dashboards

Update vmWare Exporter and add recent Grafana Dashboard to helm chart

/approved

/approve

/verify-owners


'after' is not doing every time what is expected

after 'task1', 'my_task' is not every time executed at the end of the task.
For instance in a rake-file:

  task 'demo1' do
    puts "demo1"
  end

  task 'after' do
    puts "after demo1"
  end

  after 'demo1', 'after'

  task 'demo1' do
    puts 'more to do for demo1'
  end

# expected output
> demo1
> more to do for demo1
> after demo1

# real output
> demo1
> after demo1
> more to do for demo1

I don't know a solution at the moment. I think to get this issue fixed execute in rake application has to be extented, so that after tasks are executed at the end.

I've never seen a task be redefined with more behavior. Does this still behave the same way with newest Rake, and is this a common technique? I'd expect the output to be:

more to do for demo1
after demo1

I believe it's typical, logic being that rake is Make in Ruby, make allows
subsequent definitions of "targets" (tasks, in Rake parlance) to extend
previous definitions in order that you say, setup the basic build commands
and then "#include" the dev / release make file extension to augment the
basics with environment specifics.
I might be a bit off the mark, but I'm just trying to recall this issue. I
believe historically "after" callbacks are only called once because of the
rake task being marked as "already done" (another relic from its build
tooling heritage) and this not firing.
On the train now so I can't quite make out if this bigger is relevant in
this case.
On 10 Oct 2017 14:38, "William Johnston"<EMAIL_ADDRESS>wrote:
I've never seen a task be redefined with more behavior. Does this still
behave the same way with newest Rake, and is this a common technique? I'd
expect the output to be:
more to do for demo1
after demo1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/capistrano/capistrano/issues/1064#issuecomment-335458719,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABKCN1vLRkS2X8ZLayNDVP7aBEBSOkFks5sq2VjgaJpZM4B-lTw
.

@will-in-wi it's still part of rake. It's a shortcut for Rake::Task['xxx:xxx'].enhance .  It behaves a mostly like Double-Colon Rules within make, but differ a little.
With #ehnhance rake enables you to add further prerequisites and more actions (make calls it recipe) to a task. This has 2 benefits in my point of view. First you can reuse every task defined within a gem and enhance this task at your will. Second you can specify actions more closely to the prerequisites. For instance instead of:
file 'a.x' => ['b.x', 'c.x'] do
     do_somthing_with 'b.x'
     do_somthing_with 'c.x'
end

you can write:
file 'a.x' => ['b.x'] do
     do_somthing_with 'b.x'
end

 file 'a.x' => [ 'c.x'] do
     do_somthing_with 'c.x'
end

Well, I've learned something new about rake and capistrano. I agree the behavior as currently defined is unexpected. I'd be in favor of merging a PR which corrects this. I might have time to take a look, but if someone else wants to take a look, go for it!

This test seems to be what is needed. It just needs to be made to pass.
https://github.com/will-in-wi/capistrano/commit/2c34cedcbecdb24877496d25993ee42a70be340c

In my point of view this spec is correct. To get it pass can be difficult.
after and before use enhance to hook into the task execution order. before is not critical because it add's only a prerequisite. after can be dricky.
The first solution which comes into my mind is monkey patching Rake::Task#enhance.  Rake::Task#define_task uses Rake::Task#enhance internally. So you can manipulate @actions which contains all actions.
But I don't know if changing the behavior of after is a breaking change to some people.
To me it doesn't matter any more. I'm out of ruby business for a year now.

Just to play devil's advocate: is it worth making a breaking change to "correct" this behavior? To be clear, it probably won't break projects that use vanilla Capistrano and don't re-open tasks (a pretty esoteric feature of Rake, IMO). However I suspect a large portion of the Capistrano community assembles their deployment scripts by taking snippets from gists, Stack Overflow answers, and plugins, many which are not actively maintained. It is possible these could break in ways that are surprising and difficult to debug.
If we wanted to be really cautious, we could do a deprecation/warning cycle, sort of like we did with invoke vs invoke!: https://github.com/capistrano/capistrano/issues/1686
Also consider this ticket was dormant since 2014. There doesn't seem to be a large number of people advocating for it.

I think we came to the root of the issue thanks to @dspaeth-faber 's help. There's a trail of discussion, given that we all agree, I'm closing [wontfix] thanks all.

@mattbrictson I wouldn't call it an esoteric feature. When you use rake as a build tool, then you will like it. Further more when you use after and before you rely on this feature.
@leehambley & @will-in-wi
One more point I want to mention. The current implementation of after and before has one more drwaback. Imagine you use a third party gem. Every thing works great, except one Task.
The gem look's like this:
 namespace :my_gem do

   task :pre1 do
      puts "pre1"
   end

    task :after1 do
      puts "after1"
    end

    task :to_change do
      puts "the org task"
    end

    before :to_change, :pre1
    after :to_change, :after1

  end

You try to override the task you need with a different behavior via:
Rake::Task["my_gem:to_change"].clear

# override to_change
namespace :my_gem do
  task :to_change do
     puts "changed task"
  end
end

task :pre2 do
    puts "pre2"
end

task :after2 do
    puts "after2"
end

# add more dependencies
before "my_gem:to_change", :pre1
after "my_gem:to_change", :after1

Expected output:
   pre1
   pre2
   changed task
   after1
   after2

Real output:
  pre1
  changed task
  after1

In this case you have to check every before and after within my_gem and dependent gems, to get it right.
In my opinion I would deprecate after and before at all in favor of rakes own features.

Thanks for the additional example; that is a good illustration of what makes Capistrano vs Rake concepts confusing. If Capistrano were in a 0.x state, this would definitely be something I would consider changing. However given the maturity of the project and large number of existing users and plugins, we cannot change or deprecate the before and after DSL without a huge amount of pain.
Also, IMHO, the before/after DSL, while certainly flawed, is much more intuitive than Rake's system of declaring prerequisites and enhancements. Making Capistrano more similar to Rake is a laudable goal and would certainly reduce surprising edge cases, but I am not convinced it would overall make Capistrano easier to use or more approachable as a general-purpose deployment tool.


Adding typeahead-focus-first=false option

Hi folks, is it possible to add the typeahead-focus-first=false option like it is descript here: https://github.com/angular-ui/bootstrap/pull/2916
Thanks in advance!

that would be awesome!
+1

No that feature does not exist yet. It was added to angular-bootstrap after we forked. Feel free to submit a Pull Request if you'd like to add this feature. :wink:


Add warning when TESTSRC_ALL is empty

Since TESTSRC_ALL is used in multiple places for automation, it seems reasonable to warn when the variable is actually empty.

Ran into an issue where TESTSRC_MAIN (or even _AUX) was set but not TESTSRC_ALL and it honestly took a fair amount of time to realize that this was in fact the issue of missing input files, etc.
We could also add some fallback like using TESTSRC_MAIN and TESTSRC_ALL and only warn if those are empty, too.
Would like to hear some ideas on this, or even if this is considered 'not needed'.

IMHO if there is more easy errors we can catch in the automation, we should do that. May well save us precious time down the road.


ValidHookNames: ignore deprecated hooks by design

Hooks which are marked as @deprecated should be ignored for the purposes of the ValidHookName sniff.
Related: #1797, #1806, #1811

Hard-deprecated hook using apply_filters_deprecated() and do_action_deprecated() are currently already ignored by the sniff. It is only the "soft" deprecated hooks, i.e. hooks which have a @deprecated marker in the docblock, but don't use the above mentioned functions which are not (yet) ignored.


Do not require raf polyfill, but instead add it to bundle

Also including new version of polyfill based on all references listed in header comment.
Allowing browserfy to wrap and pass global reference

This is my stab at it. I looked far and wide all over the interwebs for a decent raf polyfill that was good for the purpose of pixi, and honestly wasn't completely happy with any of them. I also tried out 2 different polyfill services, as well as integration with said services through gulp plugins. Through all of that, I just thought wow, this is overkill.
Although cringing a little, I finally settled on looking at all of the references listed, and creating a custom version for pixi, and only including it in the bundle.
I went this direction because any polyfill should be included at the highest level possible, and for this lib, it's the distributed bundle. If anyone is using the bundle as is, it is a good assumption to think that they just want things to work without worry, and in all of the lib's supported browsers. It's only when users are building the library that they are opting out of the bundle provided, and polyfills should already be a part of this pipeline. I'm quoting somebody here (sorry can't remember who off hand), but "requiring" polyfills as modules is a anti-pattern. Although it is kind of a "module" here, it is technically an entry file, and included and executed at the beginning of the bundle.

Only problem with this is if I require('pixi.js') in my app I don't get the polyfill since it is dynamically added by out bundle script. Meaning people using this in browserify will have to add their own polyfill which I don't think will be a good idea.
I know requiring polyfills is an anti-pattern, but why don't we require it in our entry file, but don't expose it.
// use only side effects of this code running
require('./polyfills/...');

module.exports = {
    //....
};

I agree I would like the polyfill there when I require pixi and not use the bundle.

@englercj @woutercommandeur That wouldn't be too bad, it's nearly the same. I just didn't include the people NOT building their own versions yet still bundling, with the group using the bundle that just want things to work in supported browsers. But will make this change.
Side note, here's 2 services to get polyfills on your pages with User-Agent sniffing (polyfills will be different based on browser):

https://cdn.polyfill.io/v1/polyfill.js
https://cdn.jsdelivr.net/polyfills/polyfill.js

Example forced raf:

https://cdn.polyfill.io/v1/polyfill.js?features=requestAnimationFrame&flags=always,gated

Wow that cdn service is neat, never knew about it.


@bind @loop

How work bind and loop into select (and get value of option selected) and we have access to increment number of loop ?
i try this https://codesandbox.io/s/lemonadejs-select-loop-hux4o9?file=/index.html

You can do something like that:
  let template = `<>
    <select @bind='self.value' @loop='self.options'>
      <option value='{{self.id}}'>{{self.name}}</option>
    </select>

    {{self.value}}
  </>`;

To get the incremental number of loop, you can use indexOf(self).

i have change the code in the previews link, Okay, but can you show me for the indexOf, how to implement this in the template ?


Make scandir resolve relative symlinks

This PR allows LuaSnip to work smoothly with GNU Stow, which only creates relative symlinks.

Nice! I wasn't aware that readlink doesn't resolve relative links, but it's kind of in the name, so makes sense.
While looking into the doc for luv, I found uv.fs_realpath (which we actually use at another point), which could resolve links (including relative ones) for us.
While I appreciate the work that has gone into this patch, I think just using realpath is the better option when it comes to maintainability.
Would you look into using that to resolve symlinks?

I don't know if we should care about it, but fs_realpath has some platform-specific caveats -> https://docs.libuv.org/en/v1.x/fs.html#c.uv_fs_realpath

I think we can ignore those :sweat_smile:
If fs_realpath messes up in some way we can look into rolling our own again, but I don't think it will.

Removed resolve_symlink as there is no way to access it from the outside of the module.
Please let me know if this is too much.

That's alright :+1:
There's one potential problem though: we resolve the filetype a given file provides snippets for from the name of the real file, not from the name of the link, which could lead to subtle problems (I tested your patch by linking to a file just named luasnippets from all.lua, but luasnippets doesn't match the <filetype>.lua-pattern, and therefore no all-snippets were loaded).
Would you like to improve that?
IMO the simplest fix would be to return lists of {ft, path}-tables from scandir instead of just lists of file/directorynames.

OTOH, the simplest option could almost be to only resolve symlinks before actually reading the files/directories.

Tested with

/Users/itepechi/.config/nvim/luasnippets/markdown.lua@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown
/Users/itepechi/.config/nvim/luasnippets/markdown.lua@ -> ../../../Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown.lua
/Users/itepechi/.config/nvim/luasnippets/markdown.lua@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown.lua

and it worked well.
Thank you for the suggestion.

Nice, looks good.
Could you try if it works with linked directories, like snippets/markdown/file.lua where markdown is a symbolic link?
scandir might not resolve symlinks before iterating.

I am not sure if I understand it correctly, but here is the test I did:
With symlink /Users/itepechi/.config/nvim/luasnippets/markdown@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown
$ ls -l /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown
total 8
-rw-r--r--  1 some  staff  122 Mar 26 02:08 code_block.lua

:LuaSnipListAvailable
{
  all = {},
  markdown = { {
      description = { "code" },
      name = "code",
      regTrig = false,
      trigger = "code",
      wordTrig = true
    } }
}

Ouh, indeed it does, nice.
I'm not sure if we should append the realpath: the filenames created there are used for

reading the content of the file (where links are resolved in fs_open it seems). But it could actually be problematic to use realpath: one file could be loaded for two filetypes (ft1 then ft2), which would mean that the snippets loaded for ft1 are removed when the ones for ft2 are added (ft2 would reuse ft1's key)
in edit_snippet_files, which opens a vim.ui.select and prompts to open some file which contained snippets. This would currently show realpath, but I think it might be nicer to show the path containing the link instead.

What do you think?

I'm trying to keep both paths as a table like { path = path, realpath = realpath }, but it seems like it will take some time to rewrite things.

Wait, i came up with a better idea. If we lookup realpaths from the Cache, there's no need to rewrite the codebase massively, or access the filesystem hundreds of times with fs_realpath. I don't know why i didn't think of that.

Sorry for the mess.

Tested the loading with several types of symlinks:html.lua@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/html
lua.lua@ -> ../../../Documents/git/dotfiles/nvim/.config/nvim/luasnippets/lua.lua
markdown@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/markdown
xhtml.lua@ -> /Users/itepechi/Documents/git/dotfiles/nvim/.config/nvim/luasnippets/html

:lua require("luasnip.loaders.from_lua").edit_snippet_files() shows the path containing the link
Using the path containing the link when generating keys for snippets

Are you sure we need to store the realpath? 😅
I'm pretty sure both fs_open and edit work with links as well.

Oh, I can confirm that.

Nice :D
Thank you (especially for your patience :D), this is a good addition, it really simplifies that code :+1:


Stacked bars' corners not rounded correctly

Expected behavior
When a stacked bar chart's bars are set to rounded corners, the entire stack's outer borders should be rounded.
Current behavior
Depends on the borderSkipped attribute:

if it's true, then no corners are rounded.
if it's false, then only the lowest and highest value dataset's bar is rounded on all corners, not the entire stack's outer corners, creating a weird look.
if it's absent, then the corners at the 0 value are not rounded.

Reproducible sample
https://codepen.io/szekelyisz/pen/GRPwbNV
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
Just trying to style a stacked chart.
chart.js version
4.4.0
Browser name and version
Firefox 118.0.1
Link to your project
https://github.com/szekelyisz/ffd-ui/

The best way to achieve this would be to make the borderRadius property a function and determine when it needs to be non 0. For example https://github.com/chartjs/Chart.js/issues/5413#issuecomment-782947351

The current behaviour of not rounding the border at the 0 mark I think is the correct built-in behaviour since that has been the most requested.
Another solution is to only add borderSkipped: false on the bottom bar in the stack, and then specify the corners for the border radius explicitly https://codepen.io/etimberg/pen/gOZZrpe

Thanks @etimberg I didn't see that borderRadius can be an object also with explicitly set radius for each corner. Works perfectly now.


Override description for items in array schema

I'm using OpenAPI 3.1.
I have the following classes:
    class Street {
        @ArraySchema(schema = @Schema(implementation = House.class, description = "A house in a street"))
        public List<House> houses;
    }

    @Schema(description = "A house")
    class House {
        public String number;
    }

The generated YAML looks like this:
Street:
type: object
properties:
  houses:
    type: array
    items:
      $ref: "#/components/schemas/House"

House:
type: object
description: A house
properties:
  number:
    type: string

The description for the items is not included.

I'd expect the item definition to contain both the $ref and the description in both cases.

FTR, If I use OpenAPI 3.0, I only get the $ref in both cases, with and without the implementation = House.class.

For single-valued properties, the description can be set.
For example,
    class Street {
        @Schema(description = "The elected leader")
        public Person spokesPerson;
    }

results in
Street:
type: object
properties:
  spokesPerson:
    $ref: "#/components/schemas/Person"
    description: The elected leader

If seems to work if I use @ArraySchema(schema = @Schema(allOf = House.class, description = "A house in a street"))


Mapping not found - ui/index

I'm trying to change the route from swagger/ui/ to /docs/ui/.
This is my config
.EnableSwaggerUi("docs/{*assetPath}", c =>...
But when I try to browse to the new mapping I get the following error. If I browser to the original route I get a 404

An error has occurred.
Mapping not found - ui/index
Swashbuckle.SwaggerUi.AssetNotFound

at Swashbuckle.SwaggerUi.EmbeddedAssetProvider.GetAsset(String rootUrl, String path) at Swashbuckle.Application.SwaggerUiHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)

:+1

If you've set the routeTemplate to "docs/{*assetPath}", then you should be navigating to the following URL to view the swagger-ui:
http://your-api-host/docs/index.html
This should definitely work

Closing due to inactivity


Writing string to pubsub on Python SDK

Can you please add writing strings to pubsub on batch job like it is now available in streaming, please.
https://beam.apache.org/releases/pydoc/2.2.0/apache_beam.io.gcp.pubsub.html
Imported from Jira BEAM-11923. Original Jira may contain additional context.
Reported by: ArturJ.

@damccorm @liferoad - for your consideration: An issue came in the context of YAML where it was noted that pubsub IO in python does not work in batch mode (unlike java). This seems to be a gap in the python connector. It is not urgent, but it may be higher priority than P3.


lib.haxe.org: markdown tables don't work

See the readme of http://lib.haxe.org/p/flixel/:

On GitHub it looks like this:

Hmm, I thought tables were added to haxe markdown library. I'll check it.

Actually, this is a duplicate of #254

I'll try to look into fixing it in markdown, but I'd still just use pandoc or something like I said in #254

I'd go for pandoc, just because it's not in haxe doesn't mean we shouldn't use it,
we didn't rewrite apache and mysql :p
If it's the better tool for the job then why hesitate.

BTW, I ported commonmark.js to haxe https://github.com/nadako/commonmark-hx, but I only managed it to pass tests on js and c# targets :-P

I'll try integrating pandoc, let's see if it's easy or not

Oh, it's probably requires pandoc binary to be installed on our servers (or somehow copied by ufront deploy).

I don't have anything against pandoc but I think it's really unfortunate if Haxe doesn't have a proper markdown library. We should look into getting this right, I don't think it's that complicated.

@nadako tried inserting your code from #254 in https://github.com/HaxeFoundation/haxelib/blob/development/src/website/controller/ProjectController.hx#L47 and it worked perfectly
(the css for table makes them 100% in width, which is weird, although not an issue with pandoc/haxe-markdown)

Yeah I guess it works for real-world cases, but the CommonMark test suit just hangs up neko :)

oh wait, you're talking about pandoc.

Yeah.
We could use a process to a cs version of commonmark-hx if neko doesn't work yet, instead of pandoc.

I don't know. I don't feel like it's ready to use in production, apparently c# version is much slower than js one too: https://travis-ci.org/nadako/commonmark-hx
I'll try to fix this particular issue in haxe-markdown for now.

Apparently, commonmark spec doesn't define tables, so there's no implementation for that neither in commonmark.js, nor commonmark-hx, so yeah, we should fix haxe-markdown.
Does anyone know tho, why is colons (:) are handled here? https://github.com/dpeek/haxe-markdown/commit/9c6a25db7ba9ac9df4d24cfbd94b9d89cf50b965#diff-94a768d35a21dae7c044af3a8e3d594aR143 Github spec doesn't say anything about colons in table separators.

Maybe @dpeek remembers!

Oh, apparently these are aligning hints, but Github markdown doesn't support it, so I wonder where does it come from.

Okay, I think I fixed it in https://github.com/dpeek/haxe-markdown/pull/26. I don't know how long it'll take to be reviewed/merged though...

I found where alignment stuff comes from! It's indeed supported by GFM: https://help.github.com/articles/organizing-information-with-tables/
But they are bound to hyphens, not pipes. Also GFM requires at lest 3 hyphens, while haxe-markdown doesn't care about it. Oh well...

aaaaaaaaaaaaaaa
bbbbbbbbbbbbbbbbbb
cccccccccccccccccc

1
2
3

I guess I'll try pointing our build configs to my fixed markdown repo and see what happens.

Actually, there's an easy way for a temporary fix :-P

Deployed a temp fix.

Should this be closed then? Or do you want to keep it open beacuse it's just a "temp fix"?

I'm not sure. @dpeek accepted my PR to haxe-markdown, but I think what I done doesn't strictly follow GFM table spec, so I think I need to look into this, then prepare a new PR, then wait for haxe-markdown haxelib release, remove this hack and change required markdown version in the hxmls. Then this should be closed :)

I'm closing this because its a markdown lib related issue.


Poor Internal Documentation

I'm using Laravel for the first time and I'm noticing the documentation within the code itself is rather poor in most instances. I've noticed this quite a bit while trying to figure out how Eloquent relations are defined and work (since the site docs aren't overly clear about it, which will hopefully be improved in 5.1).
A few examples:
MorphTo#212
	/**
	 * Create a new model instance by type.
	 *
	 * @param  string  $type
	 * @return \Illuminate\Database\Eloquent\Model
	 */
	public function createModelByType($type)

The documentation for that method is the method name in sentence form. It's a simple method, but it doesn't say what Model $type is, whether it be an instance of the polymorphic model (i.e. "Comment") or the associated model (i.e. "Posts")
MorphTo#238
	/**
	 * Get the dictionary used by the relationship.
	 *
	 * @return array
	 */
	public function getDictionary()

Just a few lines lower, you see this. The doc, again, says the function name with the added "by the relationship", which isn't overly helpful since the class itself extends Relation.
Those two docs add nothing at all of value to the method and just reword the method name. They're both fairly pointless to have and should either be expanded on or removed.
Model#941
	/**
	 * Define a many-to-many relationship.
	 *
	 * @param  string  $related
	 * @param  string  $table
	 * @param  string  $foreignKey
	 * @param  string  $otherKey
	 * @param  string  $relation
	 * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
	 */
	public function belongsToMany($related, $table = null, $foreignKey = null, $otherKey = null, $relation = null)

This one is a little more excusable since there is a bunch of comments within the code itself, but the comments do not show up in the API documentation (see here) making the actual technical docs for that method completely useless.
Query\Builder#432
	/**
	 * Add a basic where clause to the query.
	 *
	 * @param  string|array|\Closure  $column
	 * @param  string  $operator
	 * @param  mixed   $value
	 * @param  string  $boolean
	 * @return $this
	 *
	 * @throws \InvalidArgumentException
	 */
	public function where($column, $operator = null, $value = null, $boolean = 'and')

One of the most frustrating things about using Laravel so far has been the lack of argument documentation, as seen in above and in the belongsToMany() example. You can figure out what $boolean is, but it's a poor name with no documentation whatsoever. I had to spend 10 minutes explaining to a colleague that $boolean = 'or' is the same as Doctrine's ->orWhere(). It just didn't click and, according to him, the lack of documentation about it was confusing for him. If you look back at belongsToMany(), which key is $foreignKey and which is $otherKey? I managed to figure it out after digging through the source a bit and running some tests, but why is it not clearly stated with the argument declaration in the docs? Why are really generic variable names like $otherKey and $boolean being used?

I really like Laravel. Once I figure something out, it is much, much faster than the work I was previously doing in Silex. But the problem is I have to sit there reading through code and testing it for 45 minutes to figure out how to properly define a one-to-many polymorphic relationship both ways. The site docs aren't very complete, and I know they are being worked on for 5.1, but it would be somewhat forgivable if things within the code were adequately documented.

Yeah, I agree that most descriptions could be improved. That is a lot of work, though. =)

For sure it is. It's definitely not something I expect to be improved for next release or anything. Just voicing concerns and pointing out areas that I've noticed are lacking is all.

This would also require a lot of initial work and future maintenance, but It would be awesome if all the magic __call'ed methods all over Laravel were doc blocked with @method. It's frustrating enough having to use 3rd party tools like ide-helper at all, and yet still not having code completion for things like ModelName::findOrFail, and the methods available on ..Query/Builder that are still callable from ...Eloquent/Builder

People can always add comments to the code themselves and submit pull requests instead of wishing.

@GrahamCampbell Will phpdoc documentation improvements be accepted as PRs? I just thought that may be they are left out because of maintainability costs. I really miss them and I would make PR or two with phpdoc improvements, if it desired.

Will phpdoc documentation improvements be accepted as PRs

Probably yeh. Please send to the 5.1 branch. :)

@FractalizeR How about a coordinated PhpDoc improvement effort some time in the coming weeks?

Sounds good. Please don't send 100s of PRs though. 2 or 3 PRs would be really awesome. :)
We really appreciate your contributions. :)

Well, Taylor also doesn't like huge PRs... what do you guys want? ;)

@franzliedke Yep, why not? We can create an organization for that and fork laravel repo there for shared use. I guess there should be a PR per each Laravel subsystem unless it is too big.

Well, Taylor also doesn't like huge PRs... what do you guys want? ;)

PRs that are not massive and atomic, but not loads of them.
For example, dealing with the database component separately might be a good idea.
Ping @taylorotwell. Only Taylor can decide what he wants. :)

I would suggest a WIP PR, so people could give feedback gradually.
I vouch for what @GrahamCampbell said, start will one component, to establish the rules and figure out what Taylor wants, before trying to improve the whole framework.

Maybe we should all start sending pull requests.

is possible to at least provide link to source file (at github)? That would help speed up figuring what a method does (at least from web browser)

@nanaya1 I don't think this is related to improving phpdoc comments.

@FractalizeR at least it'll help changing the current api on web from "quite useless" to "less useless"...

I agree that the phpdocs and comments in the code can be improved. However it can be hard to maintain and slow down development when you've to maintain large phpdocs. I know that it can be hard because of backwards compatibility but descriptive names are quite better.


[Places] "More options" button is not displayed according to mockup

Environment: Windows, Chrome 128.0.6613.86
Reproducible: always
Steps to reproduce
Go to GreenCity
The user must be logged in to the system
Go to Places page
Actual result
active and non active state of button are higher than other buttons

Expected result
active and non active state of button are in correct position

Mockup: link
Labels
"Bug", Priority ("pri:low "), Severity ("severity:trivial"), Type ("UI), Places

'More option' button is still different from mockup.

'More option' button is still different from mockup.

Sorry about that, didn't mention the active state and non active(updated the issue), when active it's green(choosed sth), it's all as it should be, the button just was moved a little below (the active and non active state too)

The font of the 'More Options' button is still different from the mockup and the fonts on the other buttons

The font of the 'More Options' button is still different from the mockup and the fonts on the other buttons

Fixed, now looks like that


Update bin/install-arturo

https://github.com/exercism/arturo/blob/main/bin/install-arturo currently downloads the Linux build for MacOS systems (below). The script should check which operating system is installed, bailing with a message if it's MacOS (no full build). For Linux systems, it should grab the Linux build and for Windows systems, the Windows build.
file ~/.arturo/bin/arturo
/Users/anagy/.arturo/bin/arturo: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=814a41f9a784138f45f9001a28d2af05a9185192, for GNU/Linux 3.2.0, not stripped

We could use the exercism/arturo-test-runner Docker image for macOS, as that does work, even on ARM-based macs.

It seems the team is pretty close to having a working Arturo download script for nightlies. That'd simplify things for us.


Updating Supercheq docs

A couple things we should probably update:

Change all instances of Super.tech to Infleqtion
The Binder and Colab links are currently broken - this should fix it: [alt text](image_url)](link_url)
Make the install instructions more similar to the QSCOUT and IBM tutorials
Somewhat relatedly, I think we should delete # provider = qss.SuperstaQProvider(api_key="Enter Your API Key Here") and equivalent text in the css notebook to mirror the QSCOUT and IBM install instructions

Some minor formatting nits but otherwise, looks good!


python error

command:
python mkbsd.py
error:
/Library/Developer/CommandLineTools/usr/bin/python3: can't open file '/Users/shahin/mkbsd.py': [Errno 2] No such file or directory

not an issue with the script, issue with your env


HARP-9460: Fix Synchronous example.

Signed-off-by: Andres Mandado<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

Codecov Report

Merging #1397 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
+ Coverage   54.68%   54.85%   +0.16%
==========================================
  Files         255      255
  Lines       23447    23473      +26
  Branches     5271     5275       +4
==========================================
+ Hits        12821    12875      +54
+ Misses      10626    10598      -28

Impacted Files
Coverage Δ

@here/harp-mapview/lib/VisibleTileSet.ts
73.29% <0.00%> (-0.07%)
:arrow_down:

...e/harp-mapview/lib/geometry/TileGeometryCreator.ts
40.53% <0.00%> (-0.04%)
:arrow_down:

@here/harp-datasource-protocol/lib/DecodedTile.ts
26.98% <0.00%> (ø)

@here/harp-mapview/lib/PickHandler.ts
19.62% <0.00%> (+0.23%)
:arrow_up:

@here/harp-mapview/lib/Tile.ts
72.95% <0.00%> (+1.95%)
:arrow_up:

@here/harp-geoutils/lib/coordinates/GeoBox.ts
55.78% <0.00%> (+2.10%)
:arrow_up:

@here/harp-omv-datasource/lib/OmvDecoder.ts
29.46% <0.00%> (+5.35%)
:arrow_up:

...here/harp-mapview-decoder/lib/ThemedTileDecoder.ts
52.94% <0.00%> (+5.88%)
:arrow_up:

@here/harp-geoutils/lib/math/OrientedBox3.ts
97.97% <0.00%> (+10.10%)
:arrow_up:

@here/harp-omv-datasource/lib/OmvDataSource.ts
55.73% <0.00%> (+15.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db60901...eac1409. Read the comment docs.

@harpgl-bot retest this please

@harpgl-bot retest this please


YOLOv4-P7 Nan error

Hello.
I've tried to train your YOLOv4-P7 model and previously was facing NaN error.
I have observed that you have updated loss function slightly to fix the issue and wonder whether the issue has been resolved, as mAP scores of P6 and P7 haven't been updated yet.
Has the issue been solved??

The NaN loss problem has been fixed, I tested it on yolov4-p5 and yolov4-tiny, I haven't tested it on yolov4-p7 (Because My gpu don't have enough memory) . You can try it. Let me know if there is a problem.

@wangermeng2021
I appreciate your well refined source code and prompt reply. I have saved lots of time. :) I do know that NaN loss can be caused by various issues and was thinking whether I should fix some parts of the model itself or not.
Could you elaborate how you determined 1e-07 addition to atan2 function?
Did you print out when are the cases that cause NaN specifically? and determine the digit?

When I see NaN error, My first guess is "divided by zero". so I check the loss output. I found the prediction(pred_wh) occasionally equal zero.  so I determined 1e-07 addition to atan2.
Debug outputs:
pred_wh:tf.Tensor(
[[0.         0.2800796 ]
[0.         3.9574223 ]
[0.         0.25130844]
...
[0.         2.1104202 ]
[0.         3.933052  ]
[0.         1.6214828 ]], shape=(983, 2), dtype=float32)

I see. It sounds right. :) Thanks a lot! I’ll close the case. Have a great weekend!


feat: update SEO content changes due to new project

Since we are using the afetharita.com repository's clone, the SEO content kept same with old one.
We need to update that.

We fixed some of the seo issues with #41 i think what we are missing is embed image, what else do you know we are missing?

did not see that closed issue, sorry! we can close that after embed image @usirin

@eraygundogmus no worries, just wanted to make sure if we missed a place or not. TY so much for the report <3

I forwarded the up-to-date logo files to @usirin . We also discussed that we would use different variations if necessary.


IPv6 support

Am I able to use IPv6 addresses in reverse-proxy xml mapping?

Yes, of course. The overall implementation is quite agnostic to IPv4 or IPv6 address. Have you tried?

Yes. For the date of Oct 26 I've tried to put an IPv6 address into xml mapping file just to find out, that IPv6 address wouldn't even parse (parsing code. I've tried to rewrite this part to parse IPv6 adresses, but even after that I've encountered errors. If it will help, I could duplicate everything I've done and post it here for further discussion and improvement.

For the record, the URI parser here doesn't work either with the IPv6 convention, where the IP is encased in [].
The URI usually looks like this: coap://[fd01::315e:1253:681f:a123]/test.

Same here.
I just tried python coapclient.py -o GET -p coap://[aaaa::212:4b00:63a:7631]:5683/sensors and get:
Traceback (most recent call last):
  File "coapclient.py", line 162, in <module>
    main()
  File "coapclient.py", line 101, in main
    host, port, path = parse_uri(path)
  File "D:\projects\smartgrid\sft\python\CoAPthon\coapthon\utils.py", line 115, in parse_uri
    port = int(t[1])
ValueError: invalid literal for int() with base 10: ':212:4b00:63a:7631]:5683'

Well, I'll check this. It could happen that I made some mistake in the client part. IPv6 should work fine for the server part.

Ok I fixed it.

I'm sorry for reopening this issue, but there is still a little bug.
It's when you do a request with a full IPv6 (example fd01:0000:0000:3ead:c5b2:bad0:6bb1:6dbf) but when the response received only gives back the shortened address (aka fd01::3ead:c5b2:bad0:6bb1:6dbf).
I believe the trouble starts here (or end here ;-) ), line 108 in messagelayer.py, function  receive_response. This function hashes the tuple (host, port, response.mid), with the data received in the response, and then tries to compare it with the hash made in the function send_request, in the same file at line 216.
So I believe the function parse_uri (here) could be modified to include a contraction of the consecutive 0 in IPv6 addresses.


Update dependency sanity to ^3.59.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.21%. Comparing base (c08f2c9) to head (f65b715).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   99.21%   99.21%
=======================================
  Files          29       29
  Lines         255      255
  Branches       68       70    +2
=======================================
  Hits          253      253
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Test GLEIF root-of-trust chaining vs. non-GLEIF root-of-trust chaining

The business logic of the verifier should check that the Root-of-trust is Production GLEIF.
Then add tests to reg-pilot that simulate both (although we'll have to configure the verifier to use a fake-production-root-of-trust)

Solved with latest release. See VERIFIER_ENV and VERIFY_ROOT_OF_TRUST


[FLINK-7647] [flip6] Port JobManagerConfigHandler to new REST endpoint

What is the purpose of the change
This PR ports the existing JobManagerConfigHandler to the new REST endpoint. This includes introducing the ClusterConfiguration response and ClusterConfigurationHeaders. The DispatcherRestEndpoint now registers the JobManagerConfigHandler.
Additionally, this PR also contains other cosmetic changes, such as properly renaming the JobManagerConfigHandler to ClusterConfigHandler, and refactoring common test logic for marshalling / unmarshalling of REST responses.
Brief change log

Let JobManagerConfigHandler implement LegacyRestEHandler
Register JobManagerConfigHandler at DispatcherRestEndpoint
Rename JobManagerConfigHandler to ClusterConfigHandler
Introduce RestResponseMarshallingTestBase

Verifying this change
This change is a trivial rework / code cleanup.
Only additional test is ClusterConfigurationTest for the marshalling of the ClusterConfiguration.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Thanks for your contribution @tzulitai. There are still some checkstyle violations in the code.

@tillrohrmann I've corrected checkstyles violations and rebased.

Still failing with ClusterConfigHandlerTest.testGetPaths:32 NullPointer

Sorry about that, local Travis tests pass, should be fine now.

Thanks a lot for the review @tillrohrmann. I'll go ahead and merge this PR after addressing your comments.


Check for type mismatches

Running the mypy static type checker reveals that some of our code is not sufficiently type hinted. It would be good to correct this to get maximum value out of the type hinting.

This looks like a good first issue which should fit around other work.  I'll take it on, if there are no objections?


Simplify logging Error types

While developing a server-side web app, it is very common to log errors. But, the library doesn't automatically extract the localizedDescription from Error types.
Given
let error = // some `Error` type thrown
let logger = Logger(label: "com.example")

Expected behavior
logger.error(error)

Actual behavior
logger.error(error.localizedDescription) // This doesn't even compile
logger.error("\(error.localizedDescription)") // It works but it is very cumbersome

Solution
Add an extra error() method to handle Error types automatically.

Thanks for opening the issue, I don't think that's right quite to be honest.
For example, here you want to log localizedDescription -- that's specifically an NSError thing and does not exist on Linux. So eve if we were to add this, it'd have to be #if darwin platforms. Then using it would also have to be #if-ed around.
In addition to that, this library is primarily for the server ecosystem -- on Darwin you should be using OSLog after all. Making such "only for Darwin" addition somewhat weird.
I would also encourage using structured logging:
logger.error("Error doing something", metadata: ["error": "\(error)"])

rather the "just log the error" which yields better results in servers, and in general, gives more context about what the error is.
Summing up I don't think this is a good addition to the core API, though you're ofc free to make an extension Logger and add such method if you want to use it.

@ktoso agreed on the structured metadata point. one other thing to point out is that MetadataValue accepts CustomStringConvertible so if the Error conforms to that it can be sent directly eg
MyError: Error, CustomStringConvertible {
   ...
}

logger.error("Error doing something", metadata: ["error": error])

@tomerd Couldn't we provide a default implementation for Error types? Or is that asking for potential footguns where an error may contain more data than we intend to leak out in logs?
Most often, I write code like this
catch {
  logger.error("failed to do X", metadata: "\(error)")
}

right, I ran into many cases where "(error)" yielded undesired results due to the nature of the underlying Error implementation


[New game]: Add AI reversi

🎮 Game Request
Game logic and basic description
The game starts with an 8x8 board with two initial black and two initial white pieces placed in the center.
Players take turns placing their colored pieces on the board. A move is valid if it results in the flipping of at least one opponent's piece in a straight line (horizontally, vertically, or diagonally).
some of the features are :
-to flip the token
-cascading effects
-the corners and edges of the board have special strategic significance in Othello
Point down the features
Game points
The game is a single-player experience in which an AI assumes the role of your opponent.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @RitiChandak !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @RitiChandak ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


DEBUG:spydercustomize:Could not get breakpoints from the frontend

Description
What steps will reproduce the problem?

Menu : Debug > Debug
debugfile('/home/sum/PycharmProjects/py38/email_multipart.py', wdir='/home/sum/PycharmProjects/py38')
DEBUG:spydercustomize:Could not get breakpoints from the frontend.
 I think we should remove the logging entry from the kernel because (as you can see), users interpret it as an error.

I am not sure about that:

AFAIK, the user need to enable logging to see that?
This actually is an error, and it might help the user understand why the code doesn't stop on breakpoints. So we might actually want to make sure this is printeds for every user.

AFAIK, the user needs to enable logging to see that?

Sure, but we can do it because his/her program requires it.

This actually is an error, and it might help the user understand why the code doesn't stop on breakpoints. So we might actually want to make sure this is printed for every user.

You're right. Then we just need to improve the logging messages we're printing right now.

Closing because no one else has reported something like this (as far as I recall).


Moving prefix rfc2622 translation in modules instead of configuration (Closes #122)

Description of PR

What component(s) does this PR affect?

[x] Back-End (Database, Microservices, Containers, etc)
[x] Front-End (Flask, API, etc)
[ ] Docs
[ ] Build System

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Database, Microservices, Containers, etc)
[ ] Front-End (Flask, API, etc)
[ ] Docs
[ ] Build System

Related Issue

Resolves #122
Solution

Move translation from configuration to modules
Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[x] None of the above

Checklist:

[x] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

[ ] TODO: need to check frontend rendering of such lists

@slowr @pgigis this PR needs more testing due to this issue https://github.com/jfloff/alpine-python/issues/46
I will test and ping you when to check.

@slowr the codefactor issue is a remnant; I have fixed it in in-between commits (not sure why it does not get updated)

@pgigis will work on #124 in the same branch


callback issue

how to get callback while scrolling?

Hi @chiragbatra29,
Thank you for giving me an issue and sorry for my slow response. Would you like to tell me what do want to achieve by get the callback while scrolling? Because I think we can simply use the window onscroll event. And also we have onMaxScroll callback.
But it's a nice idea to add onScrolling callback. But I just wanna know the case :smile:


Update dev dependency "@types/estree"

@willmtemple: This update is causing build breaks. Can you please take a look?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=399179&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=26452410-bb74-52b8-246c-3b6de8b4706f&l=510

/azp run js - core - ci


add GitHub support

...specifically, publish for POSSEing issues and issue comments and backfeed for issue comments. (anything else?)
of all the "add silo X" feature requests we have, this is the one i'd use, and use a lot. i don't expect to implement it anytime soon, but i'd love to use it!
(#326 - Instagram publish support for likes - is maybe the one other i'd use, but we already support IG backfeed, so it only half counts. :P)

(for posterity, i currently back up my github issues with https://github.com/snarfed/misc/blob/master/export_github_issues.py )

Plain text posts could be POSSEd to github as a Gist!

I've done some experimental POSSE to GitHub, and have found the following patterns useful:
If no in-reply-to property, then create a gist.
If in-reply-to matches:

/https:\/\/github\.com\/.+\/.+(?:\/issues)/: open a new issue. Use the "name" of the h-entry as the issue name. If no name present, try to construct one from the first sentence of the entry content.
/https:\/\/github\.com\/.+\/.+\/issues(?:\/\d+)/: reply to an issue thread

Suggested title edit: Bridgy Publish to Github: note->gist, reply-> issues/ or issues/n

if anyone's interested in tackling this, i've written up comprehensive instructions on how to add a new silo to bridgy. feel free to jump in!

starting to think about this again...

thinking about the v4 API's 5000 points/hr rate limit now. i'm not sure, but afaict it seems to be per app, per user, which is problematic for scaling.
if i estimate a poll will cost ~22 points (more on that later), and i poll hourly, that sets a scaling celing of ~227 github accounts. beyond that, i have to start dropping poll frequency. :( maybe they expect to talk to individual apps once they get big and raise their limits individually? who knows.

testing foo bar

Let’s see if a reply to this thread works!

in #dev star/liking a repo was suggested to be added a Feature request. Would a separate issue be helpful? I would assume it would be similar to how silo.pub considers a like of repo URL. Or am I conflating two different things?

@miklb that's it! no new issue needed, it's on the list.

(circling back, i shipped starring support this past weekend.)

The “Authorize Bridgy” prompt page has a big green button that says to “Authorize snarfed” which seems a bit incongrous.
It would be better for branding/trust reasons if this prompt for Bridgy could use the github.com/bridgy organization, and thus show a button named “Authorize bridgy” instead.
(Originally published at: http://tantek.com/2018/050/t1/authorize-bridgy-prompt)

^ fixed the auth prompt, thanks again @tantek for acquiring the @bridgy org! example prompt below. the real one has the real logo and omits "local."

ok, first pass is pretty complete. publish to github supports issues, comments, reactions, and repo stars. backfeed supports comments and reactions. docs:

https://brid.gy/about#which
https://brid.gy/about#publish-types

there are still bugs to fix, and backfeed is best effort (and may be for the foreseeable future), but i think i'm comfortable closing this now. if anyone disagrees, feel free to holler.


Use duration when animating setRegion:

duration was being passed, but wasn't being used when calling setRegion:.

Awesome! Thanks.


Improve completion for Objective-C

Fixes https://github.com/Shougo/deoplete.nvim/issues/784.

OK.


Shortcut_CopySelectedTextAsBlockRefAlias not working on Windows

Windows Desktop 0.7.0
Have tried changed the Shortcut_CopySelectedTextAsBlockRefAlias to multiple other keybinds but still doesn't work. All other features work well for me.
Maybe it's just my laptop that has issue? Submit this to see if any other Windows users have the same problem.

can you open dev tools (ctrl+shift+i) and see if there are any errors when you try to use the keybinding?

I think it's this? If not let me know what info I need to provide to you.

ah i see - it's a cross-origin error. i've submitted a pull request in the marketplace to address this issue
until the PR has been merged, please download v.1.1.1 from github and load the plugin manually - let me know if you still run into the issue using this method

The manually loaded plugin works as expected. Thanks so much!


Typo fix: remove apostrophe from possessive "its".

Used the Edit on GitHub button from dvc.org to improve a doc in place.

thanks @mfickett ! 🎉


flake8 tests shows failures

Description
pytest shows a lot FAILED conftest.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_op.
How to reproduce
pytest
Screenshots
If applicable, add screenshots to help explain your problem.
Versions

Operating System : linux, mambaforge

Moin @ReimarBauer , I recreated this issue and I got the same errors, also this PR addresses this issue and I think version pinning of flake8 might solve it.

I tested by installing 'pip install "flake8<=3.8.0"' and it passed all the tests, I think for now, maybe could stick to version pinning.

I do think we should compare configuration between MSS and here, because there is no need for an outdated flake8 when we check mslib.
Be aware that the pypi modules are differently compiled to the conda-forge packages.

fixed by
https://github.com/Open-MSS/fs_filepicker/commit/3d92058b7696fb84c50a29b57888af4aacec7382


Add systemd system sleep hook dir

Enables the use and configuration of hooks in /etc/systemd/system-sleep. Which is used, for instance, by upower to notify the upower daemon of resume.
In order for NixOS to manage the system-sleep directory the systemd Makefile.am must be patched. Otherwise systemd will attempt to create and write to the directory directly during build. Which will fail. Since Makefile.am is patched the systemd build is extended to depend on automake and autoconf.

Is this still being worked on or can it be closed?

I am no longer working on this as I no longer require this support.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/how-to-add-a-file-to-pkgs-systemd-lib-systemd-system-sleep/2775/4


MacOS: libtink.so built with wrong options

Shared library is built with @rpath, which is a bad idea:
$ clang++ -std=c++11 -o hello_world -I/opt/local/include hello_world.cc -L/opt/local/lib -ltink
$ otool -L hello_world
hello_world:
	@rpath/libtink.so (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.50.4)
$ ./hello_world aes128_gcm_test_keyset_json.txt encrypt plaintext.txt "associated data" ciphertext.bin
dyld: Library not loaded: @rpath/libtink.so
  Referenced from: /private/tmp/./hello_world
  Reason: image not found
Abort trap: 6
$

Manually fixing @rpath for the library did not help:
$ sudo install_name_tool -change<EMAIL_ADDRESS>/opt/local/lib/libtink.so /opt/local/lib/libtink.dylib
$ otool -L /opt/local/lib/libtink.dylib
/opt/local/lib/libtink.dylib:
	@rpath/libtink.so (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.4)
	/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation (compatibility version 300.0.0, current version 1555.10.0)
	/usr/lib/libobjc.A.dylib (compatibility version 1.0.0, current version 228.0.0)
$ ./hello_world aes128_gcm_test_keyset_json.txt encrypt plaintext.txt "associated data" ciphertext.bin
dyld: Library not loaded: @rpath/libtink.so
  Referenced from: /private/tmp/./hello_world
  Reason: image not found
Abort trap: 6
$

As a sarcastic side-note - you couldn't find a more obscure build environment than hazel?

If you compile hello_world.cc with -rpath /opt/local/lib/ does it work?

Will try later this week (I'm on a different machine).
But offhand, it seems more reasonable to remove this flag altogether, rather than adding it in two places.

@mouse07410 friendly ping :)

Sorry, was too busy, and frankly, Bazel doesn't look like a tool I really want in my toolbox. Too flaky, too rough yet, way too complicated, and no perceptible advantage compared to everything else I'm using for automated multi-platform builds.
I will try that later, as time allows. Please feel free to close this issue if needed, as it's not a burning one for me anyway.


Modified InternalApi allocation range in network_v1beta1_netconfig.yaml

Since config/samples/network_v1beta1_netconfig.yaml is used in install_yamls for NetConfig setup, when we try to spawn multiple instances a couple of them try to use addresses that are already used elsewhere and that led os-net-config to fail (and left the network configuration broken) E.g.
[root@edpm-compute-6 ~]# grep ERR /var/log/os-net-config.log
2023-07-19 06:11:07.797 ERROR os_net_config.impl_ifcfg.apply Failure(s) occurred when applying configuration
2023-07-19 06:11:07.797 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (46:2F:73:15:5F:29) already uses address <IP_ADDRESS>.
2023-07-19 06:11:07.797 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (46:2F:73:15:5F:29) already uses address <IP_ADDRESS>.
2023-07-19 06:11:07.797 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (46:2F:73:15:5F:29) already uses address <IP_ADDRESS>.

<IP_ADDRESS> is already used by ovn sb metadata agent:
[ralfieri@localhost install_yamls]$ oc get ovndbcluster ovndbcluster-sb -o json | jq -r .status.dbAddress
tcp:<IP_ADDRESS>:6642

[root@edpm-compute-7 ~]# grep ERR /var/log/os-net-config.log
2023-07-19 06:11:08.749 ERROR os_net_config.impl_ifcfg.apply Failure(s) occurred when applying configuration
2023-07-19 06:11:08.750 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (8A:24:B4:AF:9B:B4) already uses address <IP_ADDRESS>.
2023-07-19 06:11:08.750 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (8A:24:B4:AF:9B:B4) already uses address <IP_ADDRESS>.
2023-07-19 06:11:08.750 ERROR os_net_config.impl_ifcfg.apply stdout: ERROR     : [/etc/sysconfig/network-scripts/ifup-eth] Error, some other host (8A:24:B4:AF:9B:B4) already uses address <IP_ADDRESS>.

<IP_ADDRESS> is also already used elsewhere.

Yeah, there is overlap with NADs[1] in install_yamls, I would probably change it for all networks.
[1] https://github.com/openstack-k8s-operators/install_yamls/blob/main/scripts/gen-netatt.sh#L75-L76

recheck


网易云跟帖无法使用，key也使用了，排查了gentle.swig也是与云跟帖上代码一样，next是不是还不支持？

Expected behavior (预期行为)
评论系统使用的是网易云跟帖
Actual behavior (实际行为)
没有任何显示。
Steps to reproduce the behavior (重现步骤)
NexT Informations
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist
Pisces

Other Informations (Like Browser, System, Screenshots)

谢谢各位大神帮忙解答

There should be some requests pointed to Gentie 163. You can check the status of them and provide them in this issue.

楼主解决问题了么

Please check the response of the request to https://api.gentie.163.com/thread/check.
I have just tested this comment service, it works well. Please note, this service requires that the domain you set in GenTie management console should be the same as your site's domain.
If you need to validate this in your local machine, you need to do:

Map your domain request to <IP_ADDRESS> in your machine's hosts file.
 notes.example.com <IP_ADDRESS>

Run Hexo to listen on port 80
 hexo server --port 80 --debug

Once you confirm that the service works, please remove the mapping info in your hosts.

Vi   正解！！！！谢谢，问题解决，只是本地调试无法看到评论界面，上传github后，可以使用，还是喜欢网易云跟帖的风格。  网址：  www.lyyiqo.win

注意next的版本！！！


Unit test failure: CodeEditorWidget suite

Refs https://dev.azure.com/monacotools/Monaco/_build/results?buildId=276771
Regressed via https://github.com/microsoft/vscode/commit/3bb57eb6ef04824b426e4dd76e305cb2bfca3f75 . Currently main branch PR pipeline is broken, increasing priority on this issue. PTAL, thanks!

Fixed.


Django Rest Framework integration

This project generates Swagger definitions for DRF - https://github.com/axnsan12/drf-yasg
Which can be used together with existing Schemathesis code.

Inject a view for swagger.json (Django has globally available urls if the project is set up)
Use schemathesis.from_wsgi
Profit

I think it is better to keep it as a separate project instead and then apply Schemathesis on the generated schema


feat(ci): codecov workflow

This is a PR to test codecov.

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

I'm going to close this PR with "needs more work". Adding CodeCov to the CI is easy but our unit tests fail left-and-right. (Sporadically.)
We should only do this when we have enough confidence in our unit tests.
@sergio-mena @andynog @hvanz Tagging you here so the information doesn't get lost.


⚠ WSINGRESOS - GENERICO has degraded performance

In b8bbc70, WSINGRESOS - GENERICO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsGenericoPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6203 ms

Resolved: WSINGRESOS - GENERICO performance has improved in 75728fb.


Use schemastore catalog to add schema associations for json files

Fixed #26289
The code source provided in this PR is a modified version of the source code of the yaml-language-server

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jabby sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello @aeschli I draft a proposal for issue #26289
Feel free to review it. I will be glad to fix any of your comments.

Hey, I'd like to see this PR merged soon. Is there any planned progress on that?

I have no time to work on this right now.

Any hope of work on this during the summer?

Hi, @jabby any chance to push this PR forward? 🙏🏼


Add a better error message for TogetherAI 400 errors

Under certain weird cases, TogetherAI will return a 400 error with important details in the HTTP body. This makes it throw something that includes the content. Not sure if there's a better exception to throw than Exception here; I rummaged a bit and the only thing I found was the together response_status_exception function, which just throws Exception.

The specific problem I'm trying to solve is that our service providers seem to be pretty quirky. Issues with adding SUTs are hard to diagnose because some of the feedback from services gets swallowed, and the retries can make take a long time to diagnose. The way I normally deal with quirky services  is to build up a set of tests that document real-world issues, so that anybody working on the code gets instant feedback.
I'm not at all attached to the solution here, just the test. So I'd say feel free to do anything you like with the code as long as the test case is preserved.


added testID prop

Very well fellow, will soon be  next to a computer and will confirm and merge.. 👍👌🏻👌🏻

hey friend, great pull request:
one last thing so could fully accept your pull:
change the readme and add touchableWrapperStyle, touchableWrapperProps, and TouchableComponent props and add a proper description.
also, if you want, change the version in the package.json file from v1.3.0 to v1.4.0. also. don't forget to update the Vectsions section in the Readme.md.
make sure to test the package before submitting the changes.
then, I will merge the request and will publish v1.4.0. you will appear as a contributor on this repo.

published v1.4.0


Add statistics for Find and Findtags search

Statics are printed to the console with System.out.println()
Waiting for extended screen to be completed to show in extended screen.

Coverage increased (+0.2%) to 92.93% when pulling e379992862529bdd60759ab7a8c43e771da770c7 on lincredibleJC:feature/add_statistics into 28a6374a12a1dbc6e2a225d79ecdb705e9334264 on CS2103AUG2017-T16-B2:master.

Coverage increased (+0.3%) to 92.986% when pulling 44f152bbad89be530fa882e516c3ae077860d6bc on lincredibleJC:feature/add_statistics into 28a6374a12a1dbc6e2a225d79ecdb705e9334264 on CS2103AUG2017-T16-B2:master.

Coverage increased (+0.3%) to 92.986% when pulling 82ff27013df80a6fa5b5a21cf9e0f0699e39c337 on lincredibleJC:feature/add_statistics into d520ac726cb3f465657d35f2cdcb98636deba19c on CS2103AUG2017-T16-B2:master.

Coverage increased (+0.3%) to 92.986% when pulling cc7b8da2391f5c95ecfa8a61d12959106c824200 on lincredibleJC:feature/add_statistics into d420e3e0fab3edd9aecbefb66b144b8ae08bea29 on CS2103AUG2017-T16-B2:master.

Coverage increased (+0.3%) to 92.986% when pulling f6dc13798f91a2451f99a915b4c6d0d7cee4d04b on lincredibleJC:feature/add_statistics into 24dceb17e8f8e0530cd7a8feddb27997734f1caf on CS2103AUG2017-T16-B2:master.


Update the html lang attribute

Hi,
In an application, I have the lang attribute set on the  <html> tag.
When the user switches the locale, the body is changed with Turbo.
However, the lang attribute is not updated by Turbo, and some of my JavaScript relies on this attribute to use the correct locale.
I know that I could either add an event listener listening to a Turbo event to update the attribute, or trigger a full page refresh instead.
Would it make sense for Turbo to also update the lang attribute by default instead of adding custom logic?

Turbo should probably monitor changes to the <html> element's [lang] attribute.
Until that support is baked in, applications that drive to pages with different html[lang] attributes should disable Turbo Drive for those mechanisms by annotating those <a> and <form> elements with [data-turbo="false"], or by requesting a full-page reload by including <meta name="turbo-visit-control" content="reload"> in the response.

I've opened https://github.com/hotwired/turbo/pull/1035 to implement this behavior.

I came here after encountering this exact issue: the document's lang attribute stays stuck in the previous language when switching language. So for example this kind of CSS doesn't work until the page is reloaded: html[lang="fr"] q { quotes: "« " " »"; }.
Thank you so much @seanpdoyle for the PR.


Fixed social links in footer

Minor issue with a template of footer

Sorry I haven't seen you PR and fixed this issue 5 mins ago with the commit


Use pe-puppet user for environment

tested, I assume?

Don't merge yet, there are other issues I just discovered.


Authenticate using tokens

Could you point me in the good direction if I wanted to use header tokens to authenticate myself?
Some sample code or general directions.
Thanks!

Nevermind, turned out to be rather easier using the UmbracoIdentityExtensions.
Added
            app.UseUmbracoBackOfficeTokenAuth(
                       new BackOfficeAuthServerProviderOptions()
                           {
                          		//Modify the CorsPolicy as required
                               CorsPolicy = new CorsPolicy
                               {
                                   AllowAnyHeader = true,
                                   AllowAnyMethod = true,
                                   Origins = { "http://localhost:11000" }
                               }
                           });

to my Startup.cs and then I was able to make a POST request to /umbraco/oauth/token which returned a token.
And if I used the token in my Authorization header Bearer my-token I got it working.


add eventemitter onImageClicked

Hi, would it be possible to add a new event emitter that would emit clicked image index in the source array upon image click?
I know you have the clickAction property but I wasn't able to figure out how to use it to listen to image clicks and send the clicked image index to the angular component where the slideshow is actually used.

@metalllus I can add this. For now you could listen for clicks on the slideshow element and then check the index when this happens.

@metalllus I can add this. For now you could listen for clicks on the slideshow element and then check the index when this happens.

The important thing for me is to emit the event only when the center part of the image is clicked and not when the arrow parts are clicked on the sides if that would be possible.

@metalllus yeah, that's exactly what I was thinking! My suggestion was just a workaround

available in 1.3.0-beta.4

If this is the onClick event, the event gets fired but it refreshes my browser window for some reason.

if I use the 1.3.0-beta.4 version and click the image I get the browser window refresh every time even if I do not use the new onClick event at all.

@metalllus do your images have click actions? It works fine on the demo (open the console and click on the slideshow) https://ng-simple-slideshow.firebaseapp.com/

I do not know what the problem is, I created a very simple slideshow for testing, only two inputs used, [imageUrls] pointing to a list with two strings with imageUrls and [minHeight] input set to 440px. Still, on image click I get browser refresh. If I click the arrows, everything works fine, next image gets displayed. But if I click the center portion of the image, I get browser refresh.

Can you make a reproduction on StackBlitz or something? I tried but can't recreate your isse

Damn, that's a shame. I will dig deeper when I have time. Thx for the effort anyway.

@metalllus if you want, just paste your component.ts file, maybe I'll see something obvious

In the template I have only this:
`<slideshow
[imageUrls]="imageUrls"
[minHeight]="'440px'"

`
In the component:
`@Component({
selector: 'app-welcome',
templateUrl: './welcome.component.html',
styleUrls: ['./welcome.component.css'],
})
export class WelcomeComponent implements OnInit {
imageUrls = [
'https://storage.googleapis.com/pezinsky-baby-sekac.appspot.com/thumb%40600_1571040552480-122041324-moon-stars-with-sleep-lettering-patch-bedtime-stitched-frame-flat-sticker-night-sky-sticker.jpg?GoogleAccessId=firebase-adminsdk-sncih%40pezinsky-baby-sekac.iam.gserviceaccount.com&Expires=3589660800&Signature=pdLfFW6HYTcNvl1oz5U3U9s0u%2Fo7%2B9Pa4msa8ciGi7GN4Z1ylApilx%2FR7p%2Fjfq%2Fd93aceq8eaAksgwhEc5qohOaMBq7jh2rghlA%2BWtbdrp8%2BlY4JD86wiV3qTFQt3n8ygbAkOopuk%2Fls1OZtNF71%2F0kjkgojieEGl8o5qzR3Gc%2F7UlFilmwONodku4mn%2FsB74lNCAIzguYVLoNPXCtdMNRbpEY%2FSWOTw3b5fqLvIaAL6mZUf3g9h7UtoKpw0Q5q6biQnrlLaPBma1ghX5uZu2rpFmuTq2YSbp%2FfghCi%2B7ok3vU1PgW4eqvbfGhWbaiuwOxM2%2FjoNGHRi7J6PkTga2g%3D%3D',
'https://storage.googleapis.com/pezinsky-baby-sekac.appspot.com/thumb%40600_1568902238199-1559244390-best-toys-2019-walking-buzz-1559244376.jpg?GoogleAccessId=firebase-adminsdk-sncih%40pezinsky-baby-sekac.iam.gserviceaccount.com&Expires=3589660800&Signature=JMJNJ01RfqKeXj29xCFfHvwuEA%2BdtMCmqAvWj%2Bd%2F%2FU%2FZJE3JKPg79kNVP4JL2OSQ1xLR4vNK79xvliBVjEhoN8dNfED%2FrSnRt%2BfsbQSocZPpCbIpJ7HDkAARO0lqDNtQIf4jHitJaWUTIkpgJO8Bl5PMglTKmP7QehcsYM4WMRNfMLBwlA9micmiaCHu68wsclRCt2O2omkptq8iiywWTpBLnwujp5kkwYG%2Bl8mPiQ%2BDNZM7tb2X%2FU0vRmudJZ3VxT1WhhsScfbXu%2B61s23xxjrKduCWzw0PXSK1bHJdCb%2BK6fdFSIN4oSh7dJTPw3GUrw4NkvFQn7wO%2FQSrQ23n9A%3D%3D'
];
constructor() { }
ngOnInit() {
}
}`

I sent you an email with a screenshot, please have a look.

@metalllus this is fixed in beta 7. I prevent the click default

Works flawlessly now. Thx for hanging in there :)
S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Blog:        www.blogick.sk [http://www.blogick.sk/]
Tel. :       +421 905 870 436
e-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 3. 11. 2019 22:46:51, Richard Jeffords<EMAIL_ADDRESS>wrote:
@metalllus [https://github.com/metalllus] this is fixed in beta 7. I prevent the click default
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBTAXXQU5OBKX3GN5GLQR42DXA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC55WXI#issuecomment-549182301], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTC4C3RSNNNFVHBR23QR42DXANCNFSM4JFRWB6Q].

Hi, today I ran into another problem with the onClick event. If I have multiple slideshows on page and I click on an image on any of them, every slideshow on page triggers the onClick event. Could this be fixed somehow?
S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Tel. :       +421 905 870 436
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 3. 11. 2019 22:46:51, Richard Jeffords<EMAIL_ADDRESS>wrote:
@metalllus [https://github.com/metalllus] this is fixed in beta 7. I prevent the click default
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBTAXXQU5OBKX3GN5GLQR42DXA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC55WXI#issuecomment-549182301], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTC4C3RSNNNFVHBR23QR42DXANCNFSM4JFRWB6Q].

@metalllus interesting. It sounds like they are sharing the same service. I'll have to look into it

Is this a deeper problem, will it take longer to fix?
S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Tel. :       +421 905 870 436
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 19. 11. 2019 14:51:34, Richard Jeffords<EMAIL_ADDRESS>wrote:
@metalllus [https://github.com/metalllus] interesting. It sounds like they are sharing the same service. I'll have to look into it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBV2ULWYRS5QSWXD7ZDQUPVONA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEOIEBY#issuecomment-555516423], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTNPXRZ35FLWN2UVI3QUPVONANCNFSM4JFRWB6Q].

hi, did you make any progress on fixing the issue I reported? Unfortunately, I came across another bug caused by the very same thing. If I create three slideshows on one page and I swipe left or right to get to the next image, the next image gets displayed on all the slideshows, not on just the one I swiped. If I use the arrows to move between images, everything works fine. But the swipe motion controls all the slideshows at the same time, not just the one you swipe on. If you make any progress on this please let me know. I would desperately need this to work.
S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Tel. :       +421 905 870 436
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 19. 11. 2019 14:51:34, Richard Jeffords<EMAIL_ADDRESS>wrote:
@metalllus [https://github.com/metalllus] interesting. It sounds like they are sharing the same service. I'll have to look into it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBV2ULWYRS5QSWXD7ZDQUPVONA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEOIEBY#issuecomment-555516423], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTNPXRZ35FLWN2UVI3QUPVONANCNFSM4JFRWB6Q].

this is fixed in beta.9!

Great, pls make it available on npm, i still see only beta.8 there. Thank
you very much.
On Sun, 15 Dec 2019, 21:39 Richard Jeffords<EMAIL_ADDRESS>wrote:

this is fixed in beta.9!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBUGRH3V2FNLHYK7VQTQY2IYFA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG5BVCA#issuecomment-565844616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALVNFBXHUH5QYEVSKONBST3QY2IYFANCNFSM4JFRWB6Q
.

It should be available. I published it

S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Tel. :       +421 905 870 436
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 16. 12. 2019 14:08:09, Richard Jeffords<EMAIL_ADDRESS>wrote:
It should be available. I published it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBWQL7CZDCYVBLWPVFLQY54TTA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6UTWA#issuecomment-566053336], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTKBZA2Z5FRW6AKH7TQY54TTANCNFSM4JFRWB6Q].

Hi, could you kindly make a quick update to add support for Angular 9? It is a very simple update a few lines of code. Thank you in advance.
S pozdravom / Best Regards,
Ľuboš Valkovič
Freelance Translator and Linguist
Ing. Ľuboš Valkovič
Kalinčiakova 1730/2
953 01 Zlaté Moravce
IČO: 43960707
DIČ:<PHONE_NUMBER>
Tel. :       +421 905 870 436
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS>On 16. 12. 2019 14:08:09, Richard Jeffords<EMAIL_ADDRESS>wrote:
It should be available. I published it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/dockleryxk/ng-simple-slideshow/issues/90?email_source=notifications&email_token=ALVNFBWQL7CZDCYVBLWPVFLQY54TTA5CNFSM4JFRWB62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6UTWA#issuecomment-566053336], or unsubscribe [https://github.com/notifications/unsubscribe-auth/ALVNFBTKBZA2Z5FRW6AKH7TQY54TTANCNFSM4JFRWB6Q].


Want to add content in STL section

Hey @UjjwalSharma01 sir
In STL/Containers(vector) I want to add contet with code snipest and functions used to retrive ,delete , modify and capcity
only for vector container in because it will take lots of time to write down every function for every container
will you please assign me this issue so I can work on it

Go ahead

Sir I go through the hactoberfest website,
in oreder to accepted by hactoberfest
hactoberfest-accepeted label is mandatory so will you please add it .

I'm well aware of all the guidelines, hacktoberfest-accepted label will be added after you PR is merged

Sir @UjjwalSharma01  , I have one query , where I have to create new checklist under container checklist with name of vector or just I add the content about vector with their name like you did in c++ basics please guide me here

after adding this I am facing issue which is in the scond screen shot will please guide me on that how I supposed to fix this issue so I can work further

Check box and other content in that checkbox section is mixing with content which I added in vector dropdown

Check box and other content in that checkbox section is mixing with content which I added in vector dropdown

We will fix this in further updates
For the time being don't include this as the subtopic of an already existing checklist
Add this as a complete topic

Then I have to add only topic name and small content because if given height get extended then it will not work give same issue

nope, i meant to say, instead of adding content under container tag, create a separate list to avoid this, we are working on the issue


feat(remote_wal): make meta srv able to alloc kafka topics

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR is part of the Kafka remote wal project.
It adds Kafka stuff to meta srv which is now able to allocate Kafka topics for regions while handling create table requests.
Details
There resides a WalMetaAllocator in MetaSrvTablemetadataAllocator. When the create inferface of the MetaSrvTablemetadataAllocator is invoked, a number of topics will be allocated by WalMetaAllocator. Those topics will be assigned to regions when executing CreateTableProcedure by the procedure manager.
A region's topic is stored in RegionOptions so that it could be used in opening and creating regions by datanode.
Checklist

[x]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Waiting for https://github.com/GreptimeTeam/greptimedb/pull/2816 to be merged.

@niebayes There are some comments, are u currently working on addressing them? Let's discuss if you have any problems.


Docs use development build of React

Not totally sure if this is fixable or worth fixing - we have sort of a convoluted build system for the docs. But I'd like to try and fix it.
Seems like we would just want to use the production package of React.

Fixed with Docusaurus.


Move to pyproject.toml and cleanup non-source files

Fixes #56, #49.
In addition to moving to pyproject.toml format, I've made a few other fairly significant updates:

Add autogenerated CONTRIBUTORS from the git history, removed the AUTHORS file, and updated LICENSE to reference the contributors file since under the MIT Licence each contributor still maintains copyright over the code they added.
Add more classifiers, specifically the Python versions and Typed. Changed the Development Status to Production/Stable since that probably more accurately represents that status.
Added some badges to the README.md.

If you want to preview changes you can use a tool like grip

Removed tox.ini, updated python-requires>=3.8, added 3.12 to CI
Moved to f-strings (removed many "x".format(...))
Applied black formatter
Applied MyPy type checker
Narrowed the type on Fingerprint.get_fingerprint - now only accepts BinaryIO.

I would be surprised if any program worked with StringIO files.

removed six
added static test files
added .gitattributes
lots of minor changes while on wild goose change to fix failing tests.

Test Plan

Check tests still pass
Validate pyproject.toml against validate-pyproject
Check README.md using grip
Check project builds

Questions / Discussion / Misc

We may want to add a PR template to remind contributors to add their name if they haven't already.

Note
I strongly recommend this is merged using a squash commit (opposed to a merge or rebase - the commit history here is pretty garbage).

@Acconut - I should add,
a. it /might/ be better now that we know cause of the broken Windows tests that we scrap this particular PR because there's a lot of potentially breaking changes (due to specifying / narrowing types for instance) and instead we could do a bunch of smaller changes
b. If we're making breaking changes - do we lean into it and start a 2.0.0.dev branch for other changes we may want before releasing it?

I haven't look thoroughly at this PR yet because it's a lot of changes, but I can answer the two recent questions.

it /might/ be better now that we know cause of the broken Windows tests that we scrap this particular PR because there's a lot of potentially breaking changes (due to specifying / narrowing types for instance) and instead we could do a bunch of smaller changes

I agree. It would make sense to fix the Windows tests in a separate PR and see how many of the improvements we can pursue in individual PRs before breaking backwards compatibility. All the other changes can then be done afterwards for a v2.

If we're making breaking changes - do we lean into it and start a 2.0.0.dev branch for other changes we may want before releasing it?

Yes, breaking changes will require a v2 release as we follow SemVer for all of our software :) If there are additional breaking changes, now will be a good time to make them. However, I don't know any changes out of my head that we had planned.

In that case, probably don't worry about reviewing this PR, I'll break it up into a few (or more).
May not be for a little while though - depends on what I'm working on.

Thank you very much for your help, @nhairs! I cherry picked the test fixes in https://github.com/tus/tus-py-client/pull/91, so we now have green CI in main again.


High-level Interaction Instrument

Algorithm Optimization

Select nearest 10 item.

Rendering

Support canvas and svg. (maybe webgl)

Instrument

combine algorithm and render engine together, to complete an out-of-box interaction instrument.


OCAT database update

Thanks for this wonderful application.
I hope I have made a contribution to keeping the application clean and streamlined.

Keep in mind that some config templates may use some of these specific SSDTS before deleting or renaming them!

Keep in mind that some config templates may use some of these specific SSDTS before deleting or renaming them!

My bad. I didn't check it carefully. I'm sorry.
In the future, I have decided not to accept any similar PR. Sorry again.

I deleted double files, too specific files, such as SSDT-PM Ivy Bridge, these are created based on the HW in use.
Then you just need to recall the newly added SSDTs.
See for example config and SSDT for precise Laptop models.
The renames I removed were duplicates or harmful to OC optimizations.
Example renaming EC0 or ECDV to EC in laptops is deleterious.
Better to remove what is not essential or is too personalized.

Your actions ruined some of the Intel configs, because the following SSDTs are now missing:

SSDT-EC-USBX.aml
SSDT-AWAC-DISABLE.aml
SSDT-PMC.aml

We can fix, as you see now there are new files EC_USBX_Desktop which includes ALL gen HW , SSDT-USBX_Laptop which contains _DSM of apple laptops.
Awac was duplicated so I put in the latest version of SSDT-AWAC , SSDT-PMC has been replaced with SSDT-PMCR.
I'll fix all the various SSDT Config.plist links shortly if that helps

No, that's not necessary. I just fork OCAT myself and then I create a subfolder for all the SSDTs that are used by the base configs so they remain future-proof.


[azure-core-cpp] Update to 1.14.1

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

Adding azure-messaging-eventhubs to release
cc: @antkmsft

Adding azure-core to release
cc: @antkmsft


Add support for component integration test

@jeradg I've merged your branch with master and created this new PR. It gave me some merge issues that I'm fixing in this branch. This is work in progress because there are some failing tests I have to fix.
Also, I did some changes to the actions, you can see the changes in the merge commit. Let me know what you think.

@san650: I see that you moved the integration- and acceptance-test-specific logic for the actions into functions. +1 from me for that.

This PR is no longer valid.


nodelet issue

Hi @koide3
Today when I ran the bagfile and ran the hdl_people lauch file, I was dealing with this error:
[ INFO] [1563533791.312999571,<PHONE_NUMBER>.586027466]: background subtractor constructed
[ INFO] [1563533791.331089009,<PHONE_NUMBER>.596427322]: done
[velodyne_nodelet_manager-1] process has died [pid 28844, exit code -11, cmd /opt/ros/kinetic/lib/nodelet/nodelet manager __name:=velodyne_nodelet_manager __log:=/home/agn/.ros/log/fb6ba99a-aa00-11e9-b73f-dc5360059dc1/velodyne_nodelet_manager-1.log].
log file: /home/agn/.ros/log/fb6ba99a-aa00-11e9-b73f-dc5360059dc1/velodyne_nodelet_manager-1*.log

What's wrong?
Also, I remove build and devel folder then did catkin_make again but the problem is remaining.

Hi @agn-7 ,
Can you run the nodelet in the standalone mode by changing "load" in the following line to "standalone"?
https://github.com/koide3/hdl_people_tracking/blob/8c0d863e77207e7012217fcd16ce89f29a78ba67/launch/hdl_people_tracking.launch#L10

I did it, but the problem remains still.

@agn-7 did you solve this issue? I also have the same problem. So far, I have only been able to narrow down that it is probably due to our Robosense Lidar. In our simulation we use a Velodyne Lidar and there it works without problems. But somehow it doesn't make sense.


[hosted-widget] report IPFS error to Sentry

Works: https://superfluid-finance.sentry.io/issues/4412237447/?environment=vercel-preview&project=4505306233503744&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
The UX is still bad for the user with an infinite loader.


NullableTypeDeclarationForDefaultNullValueFixer - handle mixed pseudotype

closes #5483

Coverage remained the same at 91.929% when pulling f12caa27ffab6ee4d647c9c47e6751d814b08892 on keradus:2.18_fix5483 into ea98c014c1bc2f94fdb672346b63252bc66b18ab on FriendsOfPHP:2.18.

Coverage remained the same at 91.929% when pulling f12caa27ffab6ee4d647c9c47e6751d814b08892 on keradus:2.18_fix5483 into ea98c014c1bc2f94fdb672346b63252bc66b18ab on FriendsOfPHP:2.18.

I believe we should not touch it, as if we would, we would make someone else code harder to migrate to PHP8.
Usage of future-reserved words, while possible on lower PHP engines, is discouraged.


File task line count and read line

Need to only count EOL but Java probably brings in whole line into memory.
Requires https://github.com/folio-org/mod-workflow/pull/58
Blocks https://github.com/TAMULib/fw-registry/issues/272

Need to only count EOL but Java probably brings in whole line into memory.

You could try something along the lines of:
          FileInputStream fis = new FileInputStream(file);
          int c;
          do {
            c = fis.read();
            if (c == (int) "\n".getBytes()[0]) lineCount++;
          } while (c != -1);

I think -1 represents EOL, but I could be wrong.
There also is probably an EOL byte somewhere that is better to use.
My understanding is that FileInputStream doesn't buffer the file at all.
This should perform better in terms of memory and resources.
Of course, if you really wanted to optimize, then a buffered read that approximates the buffer size to the standard file system buffers. (Many are along the lines of 512b, 1k, 2k, 4k, 8k, and 16k).
This would have better disk i/o performance at the cost of trivial amounts of memory for buffering.
(Using a static int[] array of a set size, like int[2048], and counting the buffered newlines via an inner loop based on the number of bytes actually read.)
These are just my thoughts on this.
I see no reason to reject/restrict the code being used.
The buffered reader already being used here is likely good enough as is.

Thanks @kaladay will test naive approach and then attempt to optimize.