response error code: 500

react-native, react and native-base version
0.46.0
15
2.2.0
windows10
Android
Expected behaviour
Actual behaviour
when I install it via npm install native-base then react-native link
and react-native run-android then react-native start
The development server returned response error code: 500

URL: http://<IP_ADDRESS>:8081/index.android.bundle?platform=android&dev=true&hot=true&minify=false

Body:
{"from":"C:\\Users\\user\\ex\\node_modules\\native-base\\dist\\src\\Utils\\computeProps.js","to":"react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry","message":"Unable to resolve module `react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry` from `C:\\Users\\user\\ex\\node_modules\\native-base\\dist\\src\\Utils\\computeProps.js`: Module does not exist in the module map\n\nThis might be related to https://github.com/facebook/react-native/issues/4968\nTo resolve try the following:\n  1. Clear watchman watches: `watchman watch-del-all`.\n  2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.\n  3. Reset packager cache: `rm -fr $TMPDIR/react-*` or `npm start -- --reset-cache`.","name":"UnableToResolveError","type":"UnableToResolveError","errors":[{}]}
processBundleResult
    BundleDownloader.java:172
access$100
    BundleDownloader.java:38
execute
    BundleDownloader.java:108
emitChunk
    MultipartStreamReader.java:69
readAllParts
    MultipartStreamReader.java:116
onResponse
    BundleDownloader.java:96
execute
    RealCall.java:135
run
    NamedRunnable.java:32
runWorker
    ThreadPoolExecutor.java:1162
run
    ThreadPoolExecutor.java:636
run
    Thread.java:764

The full error shows in the packager:
Loading dependency graph, done. Bundling 'index.android.js'  97.1(609/618), failed. error: bundling failed: "Unable to resolve module 'react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry' from '/Users/me/projects/appname/node_modules/native-base/dist/src/Utils/computeProps.js': Module does not exist in the module map\n\nThis might be related to https://github.com/facebook/react-native/issues/4968\nTo resolve try the following:\n  1. Clear watchman watches...
RN: 0.46.0
Native Base: Both 2.1.4 and 2.2.0
Using OSX

For a temporary solution while waiting for official fix, you can edit the file: node_modules\native-base\dist\src\Utils\computeProps.js, replace:
react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry
WITH
react-native/Libraries/Renderer/shims/ReactNativePropRegistry

Same issue https://github.com/GeekyAnts/react-native-easy-grid

I can finally git rid this error using this solution
replace react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry
with react-native/Libraries/Renderer/shims/ReactNativePropRegistry
on node_modules\native-base\dist\src\Utils\computeProps.js
and node_modules\react-native-easy-grid\Utils\computeProps.js
Thanks to @deathemperor and @ajostergaard

@novalagung solution It also worked in my case.

@novalagung Thanks it worked .

We've published a fix with version 2.2.1. Can anyone confirm that it's working so that the issue can be closed.

@sankhadeeproy007 I still get this error with NativeBase 2.2.1, using react-native 0.45.1 with Expo in iOS

@cosmocoder This issue is for rn 0.46. For 0.45, use v2.2.0.

Fixed with version 2.2.1.

I'm still getting the issue.
native-base: 2.2.1
react-native: 0.46.2.
Windows 10.
Any help would be appreciated.

Please use below if issue persist
replace react-native/Libraries/Renderer/shims/ReactNativePropRegistry
with react-native/Libraries/Renderer/src/renderers/native/ReactNativePropRegistry
on node_modules\native-base\dist\src\Utils\computeProps.js
and node_modules\react-native-easy-grid\Utils\computeProps.js


PowerShell Update-Help won't clear screen when returning to cursor.

Steps to reproduce
------------------'
In Linux Ubuntu or Windows Bash, execute cmdlet:
Update-Help -force
Expected behavior
To clear the screen of messages when it completes updating help.
Actual behavior
In Linux, it doesn't cleared the messages when returning back to the cursor.
By the way, in Windows works OK.
Environment data
OS: Ubuntu 16.04.1 LTS and Windows 10 Bash

PS /mnt/c/Users/mtrinidad> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.13
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

It's still the same problem with progress bar #1625 #2654


Fix "implicitly has any type" lint

This was causing CI to fail on an unrelated PR.
Now it has an explicit any type :)

and now it breaks CodeFactor. :(
I have zero experience with TypeScript or its ecosystem 😅
@WuJun2016, @khushboo-rancher, do you know which type I'm supposed to plug in here? I presume this is coming from the Cypress env here: https://github.com/harvester/tests/blob/62f4aa8b4592626ee78c067a233fb28b15925d51/cypress/cypress.config.ts#L23 but it seems to be untyped JSON and different from the interface in hosts.po.ts.

I'm not sure, I think we can ignore this codeFactor check at the moment.

and now it breaks CodeFactor. :(
I have zero experience with TypeScript or its ecosystem 😅
@WuJun2016, @khushboo-rancher, do you know which type I'm supposed to plug in here? I presume this is coming from the Cypress env here:
https://github.com/harvester/tests/blob/62f4aa8b4592626ee78c067a233fb28b15925d51/cypress/cypress.config.ts#L23
but it seems to be untyped JSON and different from the interface in hosts.po.ts.

You can change the code in the image below so that CodeFactor doesn't report errors, but I agree with @khushboo-rancher  suggestion that we ignore codeFactor checks for now.

Merging this now as this is blocking https://github.com/harvester/tests/pull/817


[Arctic-1349][Core]Reuse Spark SparkStructLike and Container and SparkInternalRowWrapper

Why are the changes needed?
fix: #1349
Brief change log
Make reuseContainer to true in ArcticSparkUnkeyedDataReader, ArcticSparkKeyedDataReader
Reuse SparkInternalRowWrapper in ArcticSparkUnkeyedDataReader, ArcticSparkKeyedDataReader
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@baiyangtx I add code to spark 3.3,cc

the spark 2.3 module has been removed from projects. so you can remove the change under spark/v2.3
@shidayang


Custom fonts

Hi, thanks a lot for the library.
I have just tested it with ili9341 without problem. However, I am creating custom fonts using The Dot Factory but I can't get it working.  I have tried almost all options but still failed.
I would like to know how to create fonts for this library. Thank you.

Hi. You can use PixelFontGeneratorUB. Please download from my google drive. Link: https://drive.google.com/open?id=105Z92oXuPc31tbzNCNSIot0m41IIiUxG&usp=drive_fs

Hi, thanks a lot for your help!


Immortal Syndicate IG Help Update

The current reference image is from this reddit thread.
It should be updated to the most recent version by the author. A more recent version is linked to in a reply to that thread. Alternatively data could be pulled from the spreadsheet.

MercuryTrade isn't being updated anymore. You will have to manually change the image itself. The simpliest method is open MercuryTrade.jar and open the app folder and insert a new "helpIGImg.png" to replace the old image.

I get an error when trying to replace the image
https://i.imgur.com/5gIj9ER.png


Sphinx: add basic page for structure of the document

PR does:

Adding install dependencies in requirement.txt so that people can install it
Adding project link ( source + issue link)
Add basic page for structure of the document.

Issue: #425

I am adding the content for *.rst files

@taoliug .
I try to add information for overview, and getting start. Could you check it looks good?
pip3 install requirements.txt
cd docs
make html
open index.html


[$500] Money Request - Deleted IOU in offline mode appears when User switch to online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Disable the internet connection on the device
Create a money request in a 1:1 conversation
Open the IOU details and DELETE the IOU request
Enable the internet connection on the device
Refresh the app

Expected Result:
The request should be deleted and the message should be still grayed out in offline mode.
When user switch to online mode the request should remain deleted
Actual Result:
When user delete the request in offline mode the request should be grayed out, in this case the request disappear
Deleted IOU in offline mode appears when User switch to online
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] Windows / Chrome
[x] MacOS / Desktop

Version Number: 1.3.61-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/df5a8606-3bc5-4e74-b10c-61ef552cac75
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bb43036fdffd3721
Upwork Job ID:<PHONE_NUMBER>276990976
Last Price Increase: 2023-09-04

I reported this issue in slack here. Can someone please confirm which one was earlier? Thanks.

Proposal
Please re-state the problem that we are trying to solve in this issue.
There are two problems that we are trying to solve here. 1) In offline mode, the grayed-out ReportPreview is not shown. 2) When online, the ReportPreview should not be shown.
What is the root cause of that problem?
The problem occurs because we are not clearing the Report Preview on the deletion of the IOU Report. . Further, pendingAction is not set for ReportPreview for Offline support.
What changes do you think we should make in order to solve the problem?

This can be solved by clearing up the Report Preview when IOU Report is deleted at this location within successData of deleteMoneyRequest method

The changes can be as follows:
        ...(shouldDeleteIOUReport
            ? [
                {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${chatReport.reportID}`,
                    value: {
                        [reportPreviewAction.reportActionID]: {
                            pendingAction: null,
                            message: [
                                {
                                    type: 'COMMENT',
                                    html: '',
                                    text: '',
                                    isEdited: true,
                                },
                            ],
                            errors: null,
                        },
                    },
                },
              ]
            : []),

In addition, we need to support offline mode. For this, we can add the pendingAction to DELETE as follows here

    let updatedReportPreviewAction = {...reportPreviewAction};
    if(shouldDeleteIOUReport)
    {
        updatedReportPreviewAction.pendingAction = CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
        updatedReportPreviewAction.errors = null;
    }

What alternative solutions did you explore? (Optional)

Reviewing

Proposal
Updated with more clarity on root cause.
@fedirjh Hope the explanation is better now. Please let me know.

@rojiphil Could you provide more details about problem 1? How does problem 1 relate to the current bug?

@fedirjh I do not think this is dupe as this issue specifically aims to handle the offline case. Please give me some time. I will upload a video to explain this.

a)

I noticed you posted the same proposal in the other issue.

Yes, I posted in the other issue as well as both these issues were related although they do not have the same Root Cause. May be, that adds to the confusion too.
Regarding this issue, this is what I think,
Problem 1: Current issue
Problem 2: Partly handled by #26627 which is fixed via Onyx PR fix.
b)

Please make sure to include the code for the root cause as well.

Regarding this, I think, the proposal here covers the code aspect as well.  Or am I missing something there? Or may be, I should have additionally mentioned that Offline support is currently not there for Report Preview in Chat Report. That is what we are resolving here.
c) Here is an attached video of solution in offline mode. When offline, we still need to show the Report Preview Action until it becomes online. This is Problem 1.
https://github.com/Expensify/App/assets/3004659/bb3aee70-714e-4bf6-aaed-1c1099e51285

Okay. I'm going to put a hold on this for the Onyx PR which itself is on hold for https://github.com/Expensify/react-native-onyx/pull/334

Same as above

""

No update yet

""

Proposal
Updated
@greg-schroeder  @fedirjh
The dependent issue #26627 is resolved and closed.
The original proposal is also updated accordingly.
Also, the problem could be reproduced with the latest main.
Can we take this forward now?

Removing hold, ready for @fedirjh to review updated proposals

@fedirjh
Thanks for sharing the test video. That helped me to understand why you could not reproduce.
In your test, I notice that you already had an existing money request (i.e. of TND 5.00) because of which the IOU Report will not get deleted.
We will get this problem when a) All the previous money requests are settled & b) There is only one money request left. Now, if we delete the one and only money request, Money Request Preview action in Chat Report will disappear. It is expected to disappear when online. But, when offline, it should show graded out until it comes online. This is the problem.
Here is a test video of the problem.

Staging
https://github.com/Expensify/App/assets/3004659/3d7affb8-fa27-4956-939a-54a9f7ebc32e

v1.3.90-0.
https://github.com/Expensify/App/assets/3004659/7555eb6f-ecf3-481a-9efa-2cdde78767c4

Does this help in reproducing this problem?

When all the money requests are removed from the IOU report, the report is removed, and it redirects to the parent report. I guess that's expected no?

@fedirjh
Did you mean online or offline or both?
When online, the report preview should disappear which is happening as expected. However, I think the issue mentioned here is that when offline, the report preview should not disappear until it comes online.

I think the mentioned bug is that the preview re-appears after switching online, and that seems to be fixed.

I think that is just one part of the mentioned problem. But, I agree that it is fixed.

Expected Result:
The request should be deleted and the message should be still grayed out in offline mode.mode.

However, the other expected result in this issue (as mentioned above) is the one with offline scenario. When offline, I think the pattern is to display some message until it comes online. For example, when a task is canceled, we display Deleted task like this

I think addressing the offline feedback style will require a lot of work. Do we really want that?

Not sure what you meant by lot of work. But, one thing I notice is that, with the proposed fix, it was earlier looking like the test video here. But, now, it looks like this as shown below. Looks like something is broken.
https://github.com/Expensify/App/assets/3004659/18f38a90-8f66-476f-a1ee-23139b157ab3

i.e. Earlier, I use to get this with the proposed fix:

But, now, I see this:

I think the mentioned bug is that the preview re-appears after switching online, and that seems to be fixed.

I think that is just one part of the mentioned problem. But, I agree that it is fixed.

Expected Result:
The request should be deleted and the message should be still grayed out in offline mode.

However, the other expected result in this issue (as mentioned above) is the one with the offline scenario.
When offline, I think the pattern is to display some message until it comes online. For example, when a task is canceled, we display [Deleted task] like this. But, I think, the need for this is not just restricted to offline scenario. Whether online or offline, I think there is another strong reason to display such [Deleted task] as there could be visible actions within the deleted task. In such scenarios, we need to display the [Deleted task] action in chat report with reply counts.
I think the same reasoning applies also for deleted IOU reports.

I think addressing the offline feedback style will require a lot of work. Do we really want that?

Meanwhile, I do agree that this requires some additional work.
The work can be broken up like this

Implementing the offline support
Implementing the [Deleted request] support in the Report Preview
Apart from this, there are improvements required on the LHN side as well which we can take separately or add as improvements here.

@fedirjh
But, first, we have to come to a common ground.
Let me know your thoughts on the above and we can take it up from there.

Proposal
Updated
@fedirjh
The proposal is updated based on the comments here.
Would this be good enough to take this forward?

awaiting updating proposal review

I still think addressing this issue on the front end will require some work

@fedirjh
Thanks for your detailed feedback. And, you are right. This needs more thinking.
Also, I agree with your concerns between the current and the proposed approach.
Maybe there is a need to revisit our approach here and there are already existing issues (mentioned in other GH issues) related to current approach.
Opened up a discussion on slack here to know thoughts on related issues as well from a wider audience.

Waiting for outcome of slack discussion

@fedirjh
In the offline scenario here, the concern you mentioned in your comment here will not happen as iouReportID is set to null during deleteMoneyRequest here. Further, once all the money requests are deleted, new money requests will not get merged with deleted IOU report. It will create a new IOU report as can be seen here. Sorry for overlooking the finer details of this.
Regarding inconsistencies revolving around merging money requests, @luacmartins's thoughts are that the inconsistencies will be handled in the BE such that BE will generate a new money request and send it to FE. That way, there will not be any jarring experience in FE. So, if there are any issues arising out of inconsistencies due to the offline scenario, that will get ironed out by BE.
If there are no more concerns, I think we are good to go here.
Let me know your thoughts or if you want me to check any other special scenarios I can do that too with my POC here.
@luacmartins Would love to have your inputs here too.
Here is a test video of how it will look after the fix here + the fix of the related issue here
https://github.com/Expensify/App/assets/3004659/7a7a885f-7a70-4a3e-979a-c74a388ba2c2

That summary sounds correct to me.

Okay got it, thanks @rojiphil - can you confirm you agree @fedirjh?

Bump @fedirjh

What if we send a message inside the IOU report after deleting all the requests inside it ? how the App should behave in that case ? will it display [Deleted Request] along with replies count like this one ?

Yes @fedirjh. It behaves like tasks.
Please have a look at the attached test video that demonstrates this.
https://github.com/Expensify/App/assets/3004659/9ffd0450-7566-42d7-9bd2-dd1d67e75d36

If So what will happen if we navigate to the "deleted" IOU report and add a new money request inside it ?

Interesting... I just checked it. The BE and FE works like a charm.
Here is a test video demonstrating that.
Hopefully, this is what you meant.
https://github.com/Expensify/App/assets/3004659/3735ce30-2915-41db-96c9-97917ba321f8

Tricky. I am asking the team to weigh in because it's not obvious to me what we should do

With "Offline- Pattern B" a UI element that is pending to be deleted should show as a strikethrough until the user comes online. At that point, it gets deleted from the UI or an error message and the RBR gets added if for some reason we couldn't complete the action.
So there are a few aspects of "Offline Pattern B” to highlight here:

Pending create, which shows the UI element greyed out while it’s pending to be created
Pending delete, that shows the UI element with a strikethrough while it’s pending to be deleted.
When you come back online, if successful, it should be created or deleted depending on the action you took.

KNOWN IMPROVEMENT: When you create something then delete that same thing all while offline it can cause a “replay effect" where it disappears, gets re-added, and disappears again as the queued create/delete actions run sequentially. It’s a bit of a downside of the offline design in this edge case, but there’s an issue for it with other cases we’ve seen it. As such, I think that aspect of this issue is out of scope and we should mention it on the main issue looking into that holistically.
So coming back to what bug we should address here to bring this in-line with Pattern B. I think we should do the following:
Deleting an existing request offline

Online, create a request
Go offline
Delete the request
The request preview component on the expense/iouReport should show as a strikethrough
It should no longer be clickable to be able to re-access the request details to modify the details while it's pending to be deleted
Go online
The request preview component on the expense/iouReport should;
7.a disappear if there are no comments in the request thread to preserve
7.b update and remain in the [Deleted request] state if there are comments in the request thread to preserve

It describes the money request preview inside the IOU/Expense

Right, it describes the preview of the thing you're deleting.

The money request preview works as expected and is similar to how you described it.

Want to show me? It doesn't work as expected in the steps on staging:
https://github.com/Expensify/App/assets/16232057/c6fd2d1c-2ea3-4b51-9a7f-50eddec247b5

Where did this "owes TBD" pattern thing come from for this case? I'd like to read more about that.
I agree that even if it's the last or only request on an iou/report report, the request preview component inside that report should still show as a strikethrough while it's pending to be deleted. We shouldn't disappear it from the UI until you come back online and that action to delete the request is successful. Equally, the iou/expenseReport preview in the parent report that is now pending to be deleted as well because it's empty should show as a strikethrough as well.

Yeah, Carlos is out atm, but I think it might just be some kind of cross-polluting with distance requests where the amount can't be calculated yet (perhaps from here) because the distance travelled hasn't been obtained from the server yet until coming back online.
I don't think we want or should have extended that pattern to "empty" iou/expenseReports at large to display as "X owes TBD". (CC: @JmillsExpensify @mountiny pretty sure this will impact drafts if we don't fix it).
So I think with your remaining steps should be:

Go online

Delete the report preview without a trace if there are no comments in the iou/expense report to preserve
If there are comments on the iou/expense report to preserve, the preview remains as a $0.00 report. (There aren't any other changes to the report view in this case, except for the total(s) showing $0).

Interesting discussion... Thanks for taking this forward.
Let me try to summarize the problems

Problem 1: When Offline, deleting Money Request in IOU Report removes the money request

Go Offline
Add Money Request in Chat Report.
Go to IOU Report for the Money Request
Delete Money Request

Actual Result: When offline, Money Request get’s removed in IOU Report. Also, report preview is removed from parent Chat Report
Expected Result: When offline, Money Request should be shown with striked-out amount in IOU Report. Also, Report Preview should be shown
https://github.com/Expensify/App/assets/3004659/2c5181fb-469f-45eb-be97-03b331bac59e

Additionally, I notice one more problem as below.
This also needs to be fixed. Is this correct?
Problem 3: When Offline, Report Preview does not update amount when a new Money Request is added

Go Offline
Add Money Request in Chat Report
Go to IOU Report for Money Request
Add a message in IOU Report
Delete the only Money Request in IOU Report (created in Step 2)
Go to parent Chat Report. Verify that Amount 0 is shown.
Go to IOU Report again and add a new Money Request
Go to parent Chat Report and review Report Preview amount.

Actual Result: Report Preview amount is not updated with money request amount of step 7
Expected Result: Report Preview amount should be updated with money request amount of step 7
https://github.com/Expensify/App/assets/3004659/46813702-8630-4448-8aed-759a2daa7a4c

@fedirjh
Can we say that the above three problems form the scope of this issue?

Proposal
Updated

@rojiphil, could you please provide a new proposal including all the relevant details, along with the analysis of the root cause and proposed solutions for each problem?

@fedirjh
One more additional issue was noticed while testing. So, that makes it 4 in total.
I have updated the proposal to address each one of the issues as per your comment
Kindly have a look.

For the second issue, I think we should fix the root cause of the bug. Your proposed solution looks like a patch rather than fixing the root cause. I think it would be better to revise the implementation that was done in #29892 and either fix the root cause of the bug or implement a new one.

@fedirjh
Agree. Maybe a revised implementation within TransactionUtils could help here. I have added Solution 2 for Issue 2 to the proposal.
Please have a look at this too when you review the remaining issues.

Issue not reproducible during KI retests. (First week)

can you take a look at the updated proposal @fedirjh? thanks!

Issue not reproducible during KI retests. (Second week)

@luacmartins @greg-schroeder @mvtglobally
Based on the comment here and here, I think the issue is still open.
Also, as mentioned here, @fedirjh has partially reviewed the proposal.
Currently, we are just waiting for the completion of proposal review.

Ah thanks for reminding me of that haha! Reopening!

For the third issue, I was unable to reproduce it, neither on the development nor staging environments. Could you please attempt to reproduce it on staging ?

@fedirjh
Thanks for sending the recording as that helped here. The problem only occurs for 1:1 DM Chat Report and not for the Workspace Chat Report. I think, the description of Issue 3  should have covered this aspect. I have updated Issue 3 of the proposal to reflect these changes.
Also, here is the reproduction test video of Issue 3 on staging.
https://github.com/Expensify/App/assets/3004659/2b52b4ed-f26f-4baa-8bfa-8a19a2c754b4

Regarding the fourth issue, I have successfully reproduced it. Upon investigating the root cause, it appears that we can navigate to the child report from the preview, but clicking on the reply count does not yield the expected result. Could you please provide an explanation as to why it works for the money report preview but not for the reply count?

@fedirjh
Navigating to the child report from the preview is via linkedReportID in Report Preview action which is optimistically set. However, navigating to the child report from reply count is via childReportID which is not optimistically set. This is the difference between both of them.
I have updated Issue 4 in proposal to reflect this.
Please do have a look.

Assigned you @rojiphil. Great job on the proposal. It is very detailed and thoughtful. I look forward to reviewing the PR!

@fedirjh
PR is ready for review.

Review still working on the linked PR - @fedirjh thoughts on when you can get that completed?

@fedirjh do you have the bandwidth to review the PR?

Review continues on linked PR

Hmm. Tricky, because this PR was linked to a deploy blocker, no? So if we did increase the bounty, it would be halved as a result.

Seems like they're going to get reward for fixing https://github.com/Expensify/App/issues/34263 as separate issue.
So neither increasing bounty nor applying penalty makes sense here.

because this PR was linked to a deploy blocker, no?

@greg-schroeder
That issue was considered a separate issue. Also, we have not discussed any reward there yet.
So, I have included that too in my comment here.
If we want to consider that issue separately, then we have solved 4 issues as part of this issue.
I think @blimpich can take a call on how to consider this issue.
Regarding the issue itself, I am not sure if we can consider it as a regression because offline support for money requests was introduced only here. It is sort of a new feature.
Also, the fix for this issue involved code changes due to recent changes in a separate unrelated PR here whereas the code changes as part of this issue stayed the same.
@fedirjh , @blimpich, please correct me if I am wrong here.

Okay. I mean what is the proposed bounty increase in the first place? Someone suggested we raise it at some point in the past but I don't think we ever got to a number.

Lets do $1000 for the whole thing, including https://github.com/Expensify/App/issues/34263, and not apply any penalty to this issue. @rojiphil I really appreciate the attention to detail and professionalism, and I agree this deserves more of a reward than a normal issue 🙂. And in the future we can make sure we increase the bounty before you put up your PR, so that you can know what you're going to get paid before working on an issue.

Paid $1k to both C and C+

@fedirjh just need to complete the checklist above and we're good to go!

Bump @fedirjh :)

Thanks! Added regression test and closing.


chore(main): release 2.8.1

:robot: I have created a release beep boop
2.8.1 (2024-05-03)
Features

Update to v2.8.1 of wails (8de48bd)

Bug Fixes

add CHANGELOG (675f999)

Miscellaneous Chores

release 2.8.1 (1788e75)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/whynotea/devcontainer-wails/releases/tag/v2.8.1 :sunflower:


validateKeyFilenameTemplate is not used

The protected method validateKeyFilenameTemplate, which was added in https://github.com/Aiven-Open/commons-for-apache-kafka-connect/pull/39, isn't executed anywhere in this repository, nor is it invoked by the S3/GCS connectors mentioned in the PR.
Should we invoke validateKeyFilenameTemplate() from AivenCommonConfig::validate, or do we expect each connector to invoke it?

@stephen-harris thanks! This doesn't seem to be used in the current version.
I took a stab at fixing this issue, see #193. Have a look.
Once we solve this issue, I can release a new version (0.11) to start working on S3/GCS connectors.


How to clear the comments in the template after packaging?

Related plugins

[X] plugin-vue

[ ] plugin-vue-jsx

Describe the bug
How to clear the comments in the template after packaging?

Reproduction
no
Steps to reproduce

System Info
win11

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

try setting it like this：
vue({ template: { compilerOptions: { comments: false } } })


Grouping with EfficientSugiyamaLayoutAlgorithm as layout algorithm for groups

Good afternoon. Thx for your work around the library.
Grouping with RandomLayoutAlgorithm as LayoutAlgorithm for AlgorithmGroupParameters works fine for me, but grouping with EfficientSugiyamaLayoutAlgorithm just draws one last group and skips others.  I use your standard GroupingLayoutAlgorithm<TVertex, TEdge, TGraph> as ExternalLayoutAlgorithm for core logic. Code with random group layout algorithm works with code from your project ShowcaseApp.Wpf in LayoutGrouped.xaml.cs. Is there any way to bring efficient sugiyama in my groups ?

Sorry, I read source code and find out what I am doing wrong. There is quite nice support for efficient sugiyama in grouping.


[CON-252] Show token usage per message

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
It's currently difficult to find out how many tokens are being used in each message
Solution
At the bottom of each message (I'm thinking next to the thumbs up/down buttons, but maybe on the left), we should show
CON-252

Would be nice to see estimated cost as well - could cycle through {tokens | cost | total daily spend} etc ... in the same UI chip on click or something

I believe Cline has this functionality and it's great. Shows how much each call is actually costing the user.


WIP: Seed db

Pull Request Template
Description
WIP script to seed DB to facilitate testing
@IonesioJunior I am not sure how to pass the app context to this script (/gateway/app/test.py)
I imagine we should use the app context from /gateway/app/init.py? (How to do that?)
also not sure where best to put this test script to seed db but I put it in this location for now to make imports easier.
also there is a bug when creating cycle (see the last line in the test.py file)... it causes this bug

I am a little lost with this one because the stack trace goes deep into the sqlalchemy package 😰🤣
Fixes # (issue). no issue... context for PR is here: https://openmined.slack.com/archives/CS2G05L5R/p1583359685042600
Type of change
Please mark options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

seed model works:

[ ] Test B

Checklist:

[ ] I did follow the contribution guidelines
[ ] New Unit tests added
[ ] Unit tests pass locally with my changes

ahh sorry... this should have been a draft PR... but it won't get merged until I get approval and remove "WIP" from title

No worries! 😃
Could you create this PR in a new PyGrid branch? That way we can help you to fix those errors (I don't have access to your repository, but if you create a new one in PyGrid, everyone with write permissions can contribute).


Implement a naive colourize option using -c

Hey, really like the concept of what you have here. Not sure if my implementation is cross-platform as I do not develop for Windows but I added a -c flag to allow colourized output for *nix systems using shell escape codes.
I am also just starting with golang so my implementation might be pretty naive. Still I thought I could get the ball rolling and see what develops.

Hello!
Thank you very much for this. I have reviewed it and I think it's a good idea and a good start. But I think we can do it even better! I have opened two issues that I think they are interesting and fun, so take a look and if you want, I'll be happy to discuss them with you and to implement them with your help!
It could be a good way for both of us to learn more about Golang!


feat: add nprogress

Description & Technical Solution
add nprogress
Checklist

[x] I have commented my code, particularly in hard-to-understand areas.
[x] Already rebased against main branch.

Screenshots
Color is using primary-700

📝 Changed routes:

/_app.page

(view full size)

Commit aa5c267a568282cec0dd01e4841cdfd4e7ca8687 (https://design-system-moon-gk569nyur-ppdbultimate.vercel.app).


Cannot cross-compile anything to windows from the latest OSX: Invalid target platform "windows"

Godot version
4.0.beta3
System information
Apple M1, MacOS 12.6
Issue description
Following the doc, I should be able to cross compile export templates from Mac OS to windows?
Here is what I get:
scons: Reading SConscript files ...
Invalid target platform "windows".
The following platforms were detected:

	ios
	macos
	web

Please run SCons again and select a valid platform: platform=<string>

Steps to reproduce
Follow the doc to install MINGW.
Run:
scons platform=windows
or
scons platform=windows tools=yes target=template_release bits=64"
And then you get got it.
It is the same if you run it for 32 bits.
Minimal reproduction project
None

cc @bruvzg

MinGW installed using homebrew (brew install mingw-w64) seems to be working fine. Make sure compilers are in PATH (should be done automatically, but you might need to restart terminal after install it) and there's no MINGW_PREFIX environment variable set. What's output of x86_64-w64-mingw32-gcc -v?

Here is the output I get:
x86_64-w64-mingw32-gcc -v
Using built-in specs.
COLLECT_GCC=x86_64-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/opt/homebrew/Cellar/mingw-w64/10.0.0_3/toolchain-x86_64/libexec/gcc/x86_64-w64-mingw32/12.2.0/lto-wrapper
Target: x86_64-w64-mingw32
Configured with: ../configure --target=x86_64-w64-mingw32 --with-sysroot=/opt/homebrew/Cellar/mingw-w64/10.0.0_3/toolchain-x86_64 --prefix=/opt/homebrew/Cellar/mingw-w64/10.0.0_3/toolchain-x86_64 --with-bugurl=https://github.com/Homebrew/homebrew-core/issues --enable-languages=c,c++,fortran --with-ld=/opt/homebrew/Cellar/mingw-w64/10.0.0_3/toolchain-x86_64/bin/x86_64-w64-mingw32-ld --with-as=/opt/homebrew/Cellar/mingw-w64/10.0.0_3/toolchain-x86_64/bin/x86_64-w64-mingw32-as --with-gmp=/opt/homebrew/opt/gmp --with-mpfr=/opt/homebrew/opt/mpfr --with-mpc=/opt/homebrew/opt/libmpc --with-isl=/opt/homebrew/opt/isl --with-zstd=no --disable-multilib --disable-nls --enable-threads=posix
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 12.2.0 (GCC)

Update: I did reinstall all my env on both Mac OS (the latest, on M1 apple silicon) and UBUNTU. I did not manage to cross compile to another plateform from both environment. I am kinda lost.

Still... When running scons platform=windows  I get:
scons: Reading SConscript files ...
Invalid target platform "windows".
The following platforms were detected:

	ios
	macos
	web

Please run SCons again and select a valid platform: platform=<string>

The arch param is required, otherwise SCons will try to compile for windows + arm64, which is not a valid target (at least for Homebrew's mingw-64). With mingw-w64 installed with Homebrew, here's the command I've used for a successful Windows build:
MINGW_PREFIX=/opt/homebrew/opt/mingw-w64 scons platform=windows arch=x86_64
(x86_32 is the other valid arch)

Actually, MINGW_PREFIX is not required, mingw-w64 binaries are in the path after brew's installation.
I'll try to send a small PR to update the docs, the current steps are outdated and rely on env variables that aren't used anymore.

PR with proposed update to docs submitted: https://github.com/godotengine/godot-docs/pull/8469


implements backoff in sso.go, avoids 429s when too many roles are present

What changed?
Implemented backoffs when running listAccountRoles in sso.go
Why?
429's when too many roles are present
How did you test it?
I ran locally using make cli, and tested against real use case that was returning 429 when using main
Potential risks
Possible still not enough attempts, but this number got me through
Is patch release candidate?
No

Addresses: https://github.com/common-fate/granted/issues/458

Thank you so much @c0nfleis for implementing the fix! We're really grateful for your work. Just a heads up, we've also just finished implementing a fix that rate limits the AWS SSO API call to AWS's max throttle limit and added a progress bar too #463

Closing as we've just merged #463 - we opted for the implementation in that PR because it has a progress bar which should improve UX for large org sizes. This will be included in the next Granted release.
As mentioned though we're hugely grateful for your contribution here @egibs - let us know how the next release works for you and contributions which further improve functionality here are very much welcomed.


Transitioned setup step to ocpdiag

Current dependencies on/for this PR:

SAT_INIT_TEST_RUN

PR #6

PR #7

PR #8   👈

This comment was auto-generated by Graphite.


CJS - End of life

At some point we will need to take the steps to drop cjs support, at the moment the build pipeline is verbose and in fact it opens for potential errors, we don't really support a mixed env we only support using either one of the targets but if any app for whatever reason uses both it will lead to errors because state will be duplicated.
With fast transpilers such as esbuild and node natively supporting esm it becomes less and less relevant to support cjs, in fact I am already defaulting to esm modules in pretty much everything I do.
While I understand that the ecosystem is not ready some push towards a unifying future is needed.
This issue is to vote on an end of life date from which we will no longer provide cjs builds.
Following the options:

31/12/2022
30/06/2023
31/12/2023

While you may be tempted to just vote for the last option please take a moment to think about it and vote what you think it's best for the broader ecosystem.
My vote is 31/12/2022.

My vote is 31/12/2022

30/06/2023

31/12/2023

@opentelemetry/api doesn't support ESM yet, please wait for that?

OTEL auto instrumentation doesn't support ESM yet, should that be waited for?
open-telemetry/opentelemetry-js#1946
open-telemetry/opentelemetry-js#1946 (comment)
Note that, manual instrumentation works fine.

When chatting with @gcanti more recently we though it may be a good idea to also poll some companies that are currently using either fp-ts or effect and get the feel, we don't really want to do a launch without a parachute so by all means this issue isn't settled just yet.
Specifically in regards of open-telemetry I doubt anyone would want to use auto instrumentation when using effect primarily because spans are tracked by effect itself so to get the parent-child relation right you need to instrument the wrappers around foreign calls (also otel-like tracing is becoming native in effect so that libraries can provide tracing facilities without depending on opentelemetry directly)

Seems like you have a pretty reasonable understanding already but as the OTel JS maintainer I'm happy to answer questions regarding that. The comment linked by Jason sums it up well, particularly the point that the maintainers would welcome support but it is tricky and there are other priorities and limited resources. I would point out that there is a fairly up-to-date PR using import-in-the-middle https://github.com/open-telemetry/opentelemetry-js/pull/2846. There are limitations (currently only one loader hook per process is possible) but it is better than nothing as they say.
I am also very interested in the idea of using diagnostic channels to fill this gap, but it will be a long time before we can rely on that as a widely adopted and used feature.


az disk update command missing --resource-group and fails

[Enter feedback here]
https://docs.microsoft.com/en-us/azure/virtual-machines/disks-shared-enable?tabs=azure-portal#cli
az disk update --name mySharedDisk --max-shares 5 command fails with the below error, please update --resource-group
az : ERROR: (--resource-group | --ids) are required
At line:1 char:1

az disk update --name shareddisk1 --max-shares 0

  + CategoryInfo          : NotSpecified: (ERROR: (--resou...s) are required:String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4adcc7c9-6709-7f9e-4ec8-63dec6d78293
Version Independent ID: 151f998f-898f-6b49-dfeb-ae29040d1af1
Content: Enable shared disks for Azure managed disks - Azure Virtual Machines
Content Source: articles/virtual-machines/disks-shared-enable.md
Service: storage
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for reporting this. I have made a PR to update the documentation and the changes should go live once reviewed.


Push: uncaught exception

Customer (Edgar) reported this issue
Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '-[.../Pods/Ably/Source/ARTPushActivationState.m:38 -[ARTPushActivationState transition:]] should always be overriden.'

@mattheworiordan Could Edgar test the push-spec-activationstatemachine branch and see if it works?

Hi @ricardopereira, effectively, branch push-spec-activationstatemachine is working


MM-12416: Adds boolean config for 'memberOf' overlay.

Summary
Adds ability to determine group membership retrieval strategy. Defaults to the faster strategy, using the memberOf overlay. If that overlay is not available on the LDAP instance it can be disabled at a cost of slower syncs.
Ticket Link
https://mattermost.atlassian.net/browse/MM-12416
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Needs to be implemented in mobile (link to PR or User Story)
[x] Has server changes (https://github.com/mattermost/mattermost-server/commit/b06b3fef0351d6848e62fefb5953663a0cb4ecde)
[ ] Has redux changes (please link)
[x] Has UI changes
[x] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

//cc @michaelgamble This is the new configuration setting as discussed in our last group sync meeting.

Oops. Github closed the PR when I renamed the base branch. Reopened.


Consider support u128 for PrimitiveArray ?

Thanks!
This would be outside of the arrow specification. Since this crate follows Arrow's specification, such addition would need to be approved in Apache Arrow's official channels.
Maybe a starting point would be to describe the use-case: is the idea to have a larger unsigned for compute?

Ok, I closed it,


Fixed stuck CI

CI is getting stuck. This PR fixes it by:

Using the kubectl binary directly (still managed by Bazel).
Killing the k3s cluster after the test is completed.

@mook-as 2 different problems. One is the problem that the tests' job never finished. And the problem that it always returns code 0. We are solving the first problem in this PR.


fix: Fixes reference app crash on triggering Evaluation

Close #319

Checked and fixed nullability issues in engine implementation
Moved the files to core module which were being used in multiple modules
Abstracted out the FhirApplication to CoreModule as CoreApplication

~PS: The engine doesn't run fine cqlreference(throws class-cast exception, saying android.app.application cannot be cast to {packagename}.cqlreference.FhirApplication) but works smoothly in the reference application; attempting a fix~(fixed as per 74da8e1)

@deepankarb @jingtang10 Would it be Ok to create a factory in this PR and use it to create instances of FhirEngine, as currently  we have different FhirApplications(BaseApplication classes that extend the CoreApplication(class which is the abstraction of FhirApplication class)) for reference and cqlreference modules whose companion object method is accessed to create a fhirEngine.

Why is spotless check failing, irrespective of the fact that I've same settings as mentioned in wiki : (
See:

Indents for Kt
Ktfmt settings

Things like CoreApplication.kt should be in the new cqlreference application instead.

As of now, I don't have any plausible reason to move CoreApplication.kt to cqlreference module, as it is being used by both, the reference module and the cqlreference module(to instantiate fhirEngine), also the files moved to the core module have the same reason as mentioned for the CoreApplication.kt; we can do move 'em to cqlreference module but they won't be accessible from reference module and we'll have to rewrite 'em there(in reference module) as well, thereby increasing the code duplicacy.

we'll need to rewrite the cql reference app (see the linked issue) by depending on a different library (cql-evaluator rather than cql-engine).

Oh this makes it clear, I was under the impression that we need to separate the engine only.

just starting afresh with a new PR

So will I have to create a new PR for this issue then, what's the problem with this one? I can rewrite commit history if that is an issue, rest is on your preference

Thanks @s-ayush2903 for preservering - this is a structural change and we had some direction changes. Appreciate it.
👍 👍 👍

Thanks to you too for clarifying stuff. With this, maybe an Issue can be created that targets about the todos in the cqlref module. And I would be happy to work on it! Thoughts?


Exported function Input parameters

I am still going through the code to see if I can answer this myself.
Do you currently support input parameters to exported wasm functions, If so do you have an example.
I am currently stepping through vm.Run and vm.Ignite.

I added a params flag to the cli in main.go
Created and entry function that accepts a single param and passed it to the vm.Run
// Run the WebAssembly module's entry function.
	ret, err := vm.Run(entryID, *paramsFlag)
	if err != nil {
		vm.PrintStackTrace()
		panic(err)
	}
	end := time.Now()


Enable the search box font to be enlarged

Please enable the search box font (and consequently the search box height) to be enlarged.  Currently it is very difficult for me to read regexes there.  While "editor.fontSize"  enlarges the main text, it does not also enlarge the search box text.
Perhaps you could add a setting "search.fontSize", or else make the search box font the same as "editor.fontSize".

Does zooming in help? This will increase the size of everything in the UI. ctrl+plus or cmd+plus

Yes, this helps a lot (in conjunction with adjusting editor.fontSize smaller).  However, it's not ideal, as the zoom feature goes in large increments, and it would be nicer to be able to adjust the search box font relatively larger for working with a non-basic regex (which is harder to view than regular text).  I guess the best solution would be to have a setting something like "search.fontSize".

I don't really want to add settings to adjust the individual sizes of different UI elements, this is very hard to maintain and test. But I can leave it open as a feature request.

Can we reopen this please?  My eyes struggle to see the text in the search box and I don't want to make the editor text larger.

I don't really want to add settings to adjust the individual sizes of different UI elements, this is very hard to maintain and test. But I can leave it open as a feature request.

I don't think this is necessarily a slippery-slope into adding configuration options for lots of disparate UI elements. Entering and editing complex search strings (especially regex) is very akin to the task of programming. We are allowed to configure the programming (editor) font face and size separately from the UI font because the level of visual resolution required for comfortably interacting with the UI is generally lower than the level of visual resolution required for comfortable interaction with program code. That, and variable width fonts are typically fine (even preferable, for compactness or in some cases natural-language readability) for interacting with the UI, whereas a majority of people prefer a monospace font for editing program code. Find Boxes exists in a sort of median space between having a UI role like a code editor, and having a UI role like a more standard UI element.
Perhaps a compromise would be to create a setting that tells VSCode to use (for search boxes where regex can be entered) the Editor's font and font size, rather than the UI's font and font size.


Deploying portfolio Page

Hi,
I have deployed the project to github pages - see here
Gracias,
Rychrr

Status: REQUIRED CHANGES ♻
Hi @rychrr   👋🏼
Good job so far! 👏🏼👏🏼👏🏼 however, there are some issues that you still need to work on to go to the next project but you are almost there! 💪🏼💪🏼💪🏼.

Highlights

Used GitHub Pages to deploy the website  ✔
The website is live and working perfectly ✔

Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
You can also consider:

Please consider Updating the Live demo section in the README file 👍🏼

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Fixed now

Hi @adel-gu 👋,
Status: Approved 🟢
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

All linters checks passed ✔
Deployed Link provided ✔
Application works properly on deployed version ✔

Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.


Created How-to XRC-721 NFT Tokens using Remix IDE

This PR is in response to the issue #36

I am having trouble verifying the contract and I noticed this section of the how-to has some information that doesn't make sense:

I am getting this error message during verification and am not sure if it is a problem with Apothem or a problem with something I have entered:

Actually I was also not able to verify the contract myself. It might be because we are importing code also which is not present. We can remove this section if not required. I have seen that most of the NFT Contracts are not verified.
You can tell if it is possible with this bounty.

@yash0501 I am reaching out to BlocksScan about this to see if it is a known issue or if I need to raise it as a new issue.  I will get back with more information.  For now let's leave the how-to as is, verification should be a part of the write up.

@yash0501 I am reaching out to BlocksScan about this to see if it is a known issue or if I need to raise it as a new issue. I will get back with more information. For now let's leave the how-to as is, verification should be a part of the write up.

@yash0501 when deploying contracts with dependencies, we need to flat source code. Install Flattenet for Remix
 )
and submit the copied code

@yash0501 BlocksScan pointed me to this tutorial on flattening the dependencies from OpenZeppelin: https://www.xdc.dev/ivan_blocksscan/learn-how-to-flatten-a-smart-contract-and-verify-on-blocksscan-56on

Okay I will check it and update the documentary in for the same.


Update free-programming-books.md

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
Adds kotlin language resources and creates the kotlin category
For resources
Description
Why is this valuable (or not)
How do we know it's really free?
It is from goalkicker.com, previously used in this list
For book lists, is it a book?
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

Welcome to free-programming-books!

Stupid question but why all of these spacing rules?
Thanks!

looks better
cleaner version control


You Pypi page looks weird...

I could be an ReST issue.... May be you can try restview by @mgedmin ? It helped me fix my faulty long descriptions so they look good on Pypi.

Cool utulity, thank you! Now read me is fixed: https://pypi.python.org/pypi/processor/0.10.0
BTW, it was broken because a missing indentation in a CHANGELOG.rst :(

@svetlyak40wt Thanks for the quick fix my Lord!


Banned Password Not available in Government Tenants

Hi team, this needs to be updated to include banned password not being compatible in GCC tenants.  The note in the banned password doc is not clear that Gcc is not supported. Our team had to spend many days on the phone with MSFT to confirm this was not an option in Gcc.
https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-password-ban-bad-on-premises-faq

#assign:Justinha

@rohinigoyal1  @jay98014 @michaelrm97 @megan-walsh
Can you respond to this issue? And let me know who to assign it to? Thanks

#reassign:megan-walsh

@megan-walsh  - Anything happening with this work item?

@sjiang26 - Any updates?


[Feature] UI - More Detailed View of a book when clicked by user

Description
I would like to add the more detailed view of a particular book, when the user clicks on any book. For now the route will be common for all books '/books/id'. Later when backend will be made route would be dynamic according to the book id. The design would be as below:
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the [Contributing Guidelines]
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Done!


yaml: Minor fixes in machine descriptors

Remove duplicated 'default' attribute
Reorder list of variables for two machines, so
we have same order for all machines.
Add comment regarding machine with 2x4g memory config

Signed-off-by: Ruslan Shymkevych<EMAIL_ADDRESS>

Acked-by: Volodymyr Babchuk<EMAIL_ADDRESS>

'Ack' is added.
Ready to be merged.


The "|| true" install script trick doesn't work on Windows

There seem to be a number of projects that have install scripts that look something like:
"scripts" : {
  "install" : "node-waf configure build || true"
}

In the above, the || true (I believe) is so that, even if node-waf doesn't exist and the shell reports an error, the || true reports success.  Then npm can install successfully even if node-waf isn't on the user's computer (probably a good bet on Windows using the pre-built binary).
However, on Windows, the || true seems to attempt to run a command called true from the shell.  I believe this is abnormal behavior.
An example of a package that fails is pg (try npm install pg).  This gives me the following error response:
c:\node>npm install pg

><EMAIL_ADDRESS>install c:\node\node_modules\pg
> node-waf configure build || true

'node-waf' is not recognized as an internal or external command,
operable program or batch file.
'true' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! error installing<EMAIL_ADDRESS>Error<EMAIL_ADDRESS>install: `node-waf configure
build || true`
npm ERR! error installing<EMAIL_ADDRESS>`cmd "/c" "node-waf configure build || true"`
 failed with 1
npm ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.<anonymous> (c:\node\node
_modules\npm\lib\utils\exec.js:49:20)
npm ERR! error installing<EMAIL_ADDRESS>   at ChildProcess.emit (events.js:70:17)
npm ERR! error installing<EMAIL_ADDRESS>   at maybeExit (child_process.js:336:16)
npm ERR! error installing<EMAIL_ADDRESS>   at Process.onexit (child_process.js:371:5
)
npm ERR<EMAIL_ADDRESS>install: `node-waf configure build || true`
npm ERR! `cmd "/c" "node-waf configure build || true"` failed with 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is most likely a problem with the pg package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-waf configure build || true
npm ERR! You can get their info via:
npm ERR!     npm owner ls pg
npm ERR! There is likely additional logging output above.
npm ERR!
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "c:\\node\\\\node.exe" "c:\\node\\node_modules\\npm\\bin\\npm-c
li.js" "install" "pg"
npm ERR! cwd c:\node
npm ERR! node -v v0.5.10
npm ERR! npm -v 1.0.103
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     c:\node\npm-debug.log
npm not ok

Which part of npm does the script execution?  I can't figure it out.

I submitted a patch, 1ae770e6314f70ac87d6bd9ef43d12ae067b17e6

One can manually add a "true.cmd" file with contents exit 0 to the same folder as node.  This will fix the above issue.
I consider this now a flaw with the package author and not with npm, so I am closing this issue.

@chowey It was a flaw in npm itself in many cases, since it would default to this || true for the configure step when it detected a node-waf wscript.  I've updated the default install command, so this should be less hazardous in the copy of npm bundled with node 0.6.4.

@isaacs, does this cause problems with node-waf clean || (exit 0); node-waf configure build since exit 0 also causes the session to terminate?  Or does npm internally break it into two commands and execute it as two sequential child processes?
I say this because an alternative for Windows might be node-waf clean || true || color; node-waf configure build.  On Windows the color command returns an error code 0, just like true does on unix, without exiting.


"Mihăești", "Bușca" are listed in the drop-down menu

Description:
When user writes ” Mihăești” and "Bușca" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mihăești"

Expected results
The location appears in the drop-down menu as "Sat Mihăești, OLT (Mihăești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Bușca"

Expected results
The location appears in the drop-down menu as "Sat Slătioarele, ** OLT** (Mihăești)".


Cargo updates registry index on every command with bad permissions

For a while now I've seen "Updating crates.io index" before every build in the rust-lang/rust repository on one of my computers. I got a chance to investigate today and it looks like that's because of this error:
$ CARGO_LOG=info ./x.py build --stage 0 library/std
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.03s
Building stage0 library artifacts {std} (x86_64-unknown-linux-gnu)
    Updating crates.io index
   0.424170519s  INFO main:exec:compile_ws:create_bcx:resolve_with_registry:resolve_with_previous:resolve: cargo::sources::registry::index::cache: failed to write cache: Permission denied (os error 13) cache_path="/home/mark/.cargo/registry/index/index.crates.io-6f17d22bba15001f/.cache/r-/ef/r-efi"
    Finished `release` profile [optimized + debuginfo] target(s) in 0.67s

That error is because a bunch of the files in the cache directory ended up owned by root rather than my user, probably as a result of a docker build of test-various (see lockfile which contains this crate).
I'm filing this because it seems like we ought to:

Not silently ignore this error if it's going to cause us to "Updating..." every build
Potentially delete/prune the cache (not sure if possible) rather than failing in this way

In my case r-/ef/r-efi where all owned by root.

The Cargo team discussed this, and we feel like elevating this to a warning should be fine. Just some things to consider if we do that:

Make sure there isn't warning spam if there are multiple files it can't write to (should just be one warning).
The warning should probably point to which file it can't write to.
We should be careful in case there are situations where the user legitimately does not want to have a writeable cache (like some readonly Docker mounted setup or whatever).

If user's report issues with a new warning, we should consider reverting it if it seems like a problem.
We can consider making this a "lint" where the user can squelch it if they want to. That, however, is blocked on not only stabilizing Cargo's lints, but also having user-defined lint levels (like in a config file), which has yet to be designed.


Fixed issus with Fedora 36

I tested with Fedora 36 and localhost is translated in ::: rather than <IP_ADDRESS>. It might be better to change it with <IP_ADDRESS>

Thanks for catching this flaw in the documentation!
Made some suggestions before merging. Apart from those could you also modify line 262 in the README.md file to
pool.add_http_server(server_port)

and the typo on line 175 to
### Advanced usage

Thanks again

@rtaiello if you modify these I'll merge the PR.

Thanks @ThomasTNO I think I've done, I just commited them.
Let me know, thanks.

Incorporated, thanks a lot for the community contribution @rtaiello!


Add modifier to enable/disable workflow and show it's current state

Feature details
I have a number of workflows that I use very infrequently so I keep them disabled to avoid cluttering the UI. I'd love to be able to access and enable them directly through this workflow without the requirement of opening the settings page.
It would also be helpful to know whether each extension is active or not. One option to only show active workflows by default and use a different keyword a display inactive workflows. Another option would be to display them differently in the UI ( grayed out, or a different icon).

Thank you for the request. I mulled it over and ultimately decided not to do it for several reasons. Chief amongst them is that I want the workflow to remain blazing fast. Some people have hundreds of workflows installed, and because this presents the most recently viewed at the top, a cache cannot be used. Meaning that a full execution needs to happen every time.
Every check necessarily adds more computation (and thus delays) so I want to keep those to a minimum. Having modified images is immediately disqualified because it would require creating alternatives on demand for each disabled one. Then every single entry would need to have a check for their status and produce a different item which complicates the feature of having customisable modifiers (which is important since there are many options). Interface-wise, having items disappear on disabling would also require continuous reruns, though having an option to just not show disabled could work. Having a separate keyword for just disabled ones is something I don’t feel would be appropriate for this one.
Worth noting that I’m not opposed to those techniques and in fact use them in other workflows, such as Library Sounds and Virtual Machines, and it is precisely because I’ve done it before that I have a sense for how they could work in this workflow and feel they’re not entirely appropriate for its scope.
Note there are other workflows to search for workflows (at least two others) and other creators may have different goals. But for this one, and seeing it’s not a highly requested feature, passing at least for now. I’ll revisit if I come up with a satisfactory idea, I frequently keep these in mind and let them simmer for future releases.
Thank you again for the request. Have a great week.


Vagrant: Improve Test Coverage & Align Tests In VPC process.

Fixes #3207 & #3288
Update the vagrant playbook check tests of the built JDK, this will now run the standard smoke tests after each build, plus 2 sets of tests ( jdk_math and hotspot_sanity ). These tests are now identical across linux & windows. Also identified a bug whilst testing with Fedora 40, where there is insufficient disk space on the vagrant box to clone the test materials.
Checklist

[X] commit message has one of the standard prefixes
[X] playbook changes run through VPC or QPC (if you have access)

VPC Run : https://ci.adoptium.net/job/VagrantPlaybookCheck/2025/

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little :)

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.

👍🏻  The important thing here is that we're looking to test the playbooks, not the JDK specifically, so we need a fairly quick to run set that covers anything that might get missed.

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.
New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/

Had some failures although not 100% sure related to your changes!

I'm not sure about this. Adding the smoke tests in is definitely good, but the system tests and MBCS ones were specifically chosen because they validate other bits of the playbook setup (The STF build processes, and the perl installation). It looks like this is removing that validation.

I'll look to identify some equivalents and add those in too, hopefully its a bit simpler to add more tests now I've rationalised the setup a little.
New VPC run in progress : https://ci.adoptium.net/job/VagrantPlaybookCheck/2027/

Had some failures although not 100% sure related to your changes!

I dont think they are, Im rerunning the 2 problem platforms centos7 and debian 10 ( I have a feeling JDK21 doesn't build on debian 10 )... but the first run was successful across Ubuntu 22,24, Fedora 40, Solaris, & Windows, and all builds and tests ran successfully.


I cannt get the right model

Download dwpose weights (dw-ll_ucoco_384.pth, yolox_l_8x8_300e_coco_20211126_140236-d3bd2b23.pth) following this.

Sorry! But I cannt get this two models. Because, this link can only get onnx model.

onnx or pth all is ok!


TypeError: Cannot read property 'indexOf' of undefined

TypeError: Cannot read property 'indexOf' of undefined
at IncomingMessage. (/var/app/current/node_modules/mailgun-js/lib/request.js:217:72)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:978:12)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickDomainCallback (internal/process/next_tick.js:128:9)

Hi @vatex,
Could you please provide the code or explain how did you get this message?

@andrii-yelis I don't remember details, since it happened 2 years ago.
I think it happened when I received an event on the webhook. I'm sure it resolved in newer versions because I don't remember this error during the last year.

@vatex Thank you for the answer. Will take a look on it.


Block third party cookies

Reviewer: @kdzwinel

Description:

This PR adds blocking functionality for 3rd party cookies
Steps to test this PR:

Visit https://privacy-test-pages.glitch.me/privacy-protections/storage-blocking
Click "Store data"
Click "Retrieve data"
Third party header and js cookie should fail

Automated tests:

[x] Unit tests
[x] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[x] Get advice or leverage existing code
[x] Agree on technical approach with reviewer (if the changes are nuanced)
[x] Ensure that there is a testing strategy (and documented non-automated tests)
[x] Ensure there is a documented monitoring strategy (if necessary)
[x] Consider systems implications

@kdzwinel re: tests, I've opened #544 which does integration tests against privacy-test-pages for cookie blocking. This is intended to cover the tests needed for my project, but it also easily covers 3rd party cookie blocking, so I added those tests too. We could cherry-pick that commit into the PR to add tests.

I've commited a change to use the TR block list for cookie blocking. Feel free to review it but it is currently untested due to intermittent power issues here.

Superseded by #570


$transclude() commenting out ng-repeat in transcluded source

I'm submitting a ...

[x ] bug report
[ ] feature request
[ ] other

Current behavior:
When using $transclude() in the directive function to obtain the source html, ng-repeat is coming in commented out. This doesnt seem to be a problem when using ng-transclude.
Expected / new behavior:
$transclude() exposes source html without making any changes.
Minimal reproduction of the problem with instructions:
Source html using tabs directive:
<tabs>

Tab 1

{{item}}

{{$ctrl.tagList}}

Tab 2

Tabs 2 content

    ...
</tabs>

I then manually use $transclude() to create an array of panels and iterate through them inside my template. The issue is that when I run the following:
var panels = Array.from($transclude());

The html above with the ng-repeat comes in commented out though, so I'm not able to compile the content:

{{$ctrl.tagList}}

Scope doesn't seem to be an issue here since compiled transcluded content only is showing unexped results for the ng-repeat only. $ctrl.tagList is rendering correctly in the pre element.

["Tag 1","Tag 2","Tag 3","Tag 4"]

AngularJS version: 1.6.6
Browser:
All

Hi, any chance u got a reproduction sample using plunkr?
Atm it's kinda cryptic to me to fully understand what it is exactly you're doing.

When calling $transclude() you already receive a compiled and linked DOM fragment. If your repeat source is empty at that point, then you'll get the placeholder comment that is generated by ngRepeat.


Bringing some dependencies in house

Back when Isaac started we looked around at the best packages to use for some of the work that we then built on. That was a good thing, but longer term having the isaac repo depend on third-party repos that may go away without notice is likely a fragile state of things.
When there's more dev time, perhaps one can look at this list of third-party deps, https://github.com/oleg-alexandrov/mvs-texturing/blob/isaac/elibs/CMakeLists.txt, and switch those to some forked repos under nasa/isaac. Even my own repo, as seen above, should be forked I think.
This came about because I managed to break some stuff in those dependencies (that I fixed with Marina). That was made robust now, by ensure a specific version is checked out, but the longer term dependency on repos whose history may be rewritten or even they may be deleted is still there.

@bcoltin what are your thoughts on this? Even now we're adding more and more forked repos in our accounts, I have a couple as well as Brian K. But I don't think we can have forks under nasa/isaac and an organizations can't fork repos under the free account (and that would be a big hassle)

I think this is a good idea but the effort / reward ratio is very poor. I think if we do want to make this more robust, our effort would be better spent getting the minor patches we need merged upstream if possible...

A simple though imperfect way to make this more robust would be: for every place we depend on a repo personal fork, make sure there is a redundant personal fork containing the same required frozen commit, and keep some notes about where those redundant forks are in case we need to swap out a broken link.


dra-cla: unstable-2023-03-10 -> unstable-2023-10-10

fix on main url, should be working now

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 262305 run on x86_64-linux 1

1 package built:

dra-cla


Feature: Prefetching

Implemented these pipeline methods:

prefetchToDiskCache: Promise<void>
prefetchToMemoryCache: Promise<void>
isInDiskCache: boolean

@ddfreiling amazing thanks a lot!
Did you test it well? Don't really have time to test.
Can i release? ;)

No problem @farfromrefug. Tested it a lot with the angular demo, and it seems to work well and handle errors correctly. I would definitely prefer you do some cursory testing before releasing it.
The only thing which bugs me, is that Fresco's prefetchToBitmapCache also seems to store in the disk cache, while it does not on iOS.
This could be "smoothed out" by having iOS store to both caches too.
Alternatively we could just add a new prefetchToCaches, so that all 3 things are possible.

No problem @farfromrefug. Tested it a lot with the angular demo, and it seems to work well and handle errors correctly. I would definitely prefer you do some cursory testing before releasing it.
The only thing which bugs me, is that Fresco's prefetchToBitmapCache also seems to store in the disk cache, while it does not on iOS.
This could be "smoothed out" by having iOS store to both caches too.
Alternatively we could just add a new prefetchToCaches, so that all 3 things are possible.

@farfromrefug Any plan for when you'll release this?

@ddfreiling may be next week if that s ok. Need to test it but dont really have time right now. Big release time for an app ;)

@farfromrefug that's perfectly fine, good luck with the big release :)


Laravel 5.5 AutoDiscover

I have added the Autodiscovery feature of laravel 5.5 to auto register the Service Provider and the Facade

Thanks.


Can't figure out how to use GET request for a single rocket/launchpad/etc.

Every time I try to use the get request URL, I either get all of the launchpads or rockets returned, or I get a 404.
I've tried two different URL's for the get request since I wasn't sure if I had the syntax wrong or something.
I get the 404 code if I use "https://api.spacexdata.com/v4/launchpads/:id" as the url, which I imagine is because ".../launchpads/:id?id=xxxxx..." is not the correct syntax.
This is what my code looks like for that:
import requests

upcomingLaunchesURL = "https://api.spacexdata.com/v4/launches/upcoming"
launchPadGetURL = "https://api.spacexdata.com/v4/launchpads/:id"
rocketGetURL = "https://api.spacexdata.com/v4/rockets/"

upcomingLaunches = requests.get(upcomingLaunchesURL).json()

launchpadID = upcomingLaunches[0]["launchpad"]

launchpadResponse = requests.get(url=launchPadGetURL, params={'id': launchpadID})

All the other variables are correct there. launchpadID returns the correct value and it is a string.

On the other hand, if I use the proper syntax (or so I would be led to believe), instead of returning the launchpad or rocket corresponding to the ID that I passed in, I get all of the rockets/launchpads returned as if I was using the "all" URL.
My code in this case is the exact same thing, just with the different URL like so:
import requests

upcomingLaunchesURL = "https://api.spacexdata.com/v4/launches/upcoming"
launchPadGetURL = "https://api.spacexdata.com/v4/launchpads/"
rocketGetURL = "https://api.spacexdata.com/v4/rockets/"

upcomingLaunches = requests.get(upcomingLaunchesURL).json()

launchpadID = upcomingLaunches[0]["launchpad"]

launchpadResponse = requests.get(url=launchPadGetURL, params={'id': launchpadID})

i've even looked at the response objects, and the urls that are showing up seem to look just right. For example when I use the above code - which returns 200, but gives me all of the launchpads instead of one - the url it's using is "https://api.spacexdata.com/v4/launchpads/?id=5e9e4502f509094188566f88"
Shouldn't this be giving me just one JSON object for that id? What am I doing wrong?

in https://api.spacexdata.com/v4/rockets, you find id fields for a value.
one of them is https://api.spacexdata.com/v4/rockets/5e9d0d95eda69955f709d1eb

For your specific example, the correct url would be https://api.spacexdata.com/v4/launchpads/5e9e4502f509094188566f88

Okay, I’ve gotten it working by just appending the is onto the url like you’ve done there. I was using the “parameters” argument which the API wasn’t responding to.
Perhaps this should be noted somewhere in the documentation for clarification purposes. For python users at least.
Thanks.


Improve channel actions dispatcher to allow inheritance/mixins

Fixes #14

Mostly copy / pasted from rails' abstract_controller :)

Lets keep the newlines you deleted (to be consistent with the rest of the project) :smile:

@kaspth updated


Update readme node compatibility matrix

This wasn't done in #3736
Exact revision comes from https://github.com/input-output-hk/cardano-wallet/blob/master/cabal.project#L121

Don't think we want this after #3820


Desktop ports: Mac and Linux

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
The desktop version should support Windows, Mac and Linux main distros. At the moment, only the linux port is being tested.
Mockups or Images of the feature
No response

If you have a MacOS device, contribute to this issue!


Mobile menu

General requirements

I made sure that there are [no linter errors
I made sure that I used correct [GitHub flow]
I made sure that I documented my work [in a professional way]

[HTML/CSS & JavaScript requirements]

Followed the list of [best practices for HTML & CSS]
Followed the list of [best practices for JavaScript]

[Project requirements]

[ ] When the user clicks (or taps) the hamburger button, the mobile menu appears.

[ ] When the user clicks (or taps) the close (X) button, the mobile menu disappears.

[ ] When the user clicks (or taps) any of the mobile menu options, the mobile menu disappears.

[ ] When the user clicks (or taps) any of the mobile menu options, a correct part of the page is displayed.

@mioOleen Hello, due to some conflicts that have occurred, I am unable to review your code at this time. Please kindly consider resolving the conflict error and then request a review again. Ensure that you move the card to 'fixing changes' while addressing the issue. Thank you.😁 💯


Halted by "incompatible types" error due to lack of a record field

With the merge of #1375, I've noticed that one of the index creation steps in the zar README that worked before now fails.
$ zq zng/*.gz | zar import -s 25MB -
$ zar index -q -o custom.zng -k id.orig_h -z "count() by _path, id.orig_h | sort id.orig_h"
incompatible types

I narrowed it down to a characteristic our Zeek test data. Specifically, whereas most Zeek events have an id field that's a record containing fields orig_h, orig_p, resp_h, resp_p, the Zeek x509 event happens to contain a top-level field called id that's a string. Here's a trimmed down data set that covers the repro:
$ cat input.tzng
#0:record[_path:string,id:record[orig_h:ip,orig_p:port,resp_h:ip,resp_p:port]]
0:[weird;[<IP_ADDRESS>;49562;<IP_ADDRESS>;80;]]
#1:record[_path:string,id:bstring]
1:[x509;FYNFkU3KccxXgIuUg5;]
0:[weird;[<IP_ADDRESS>;40712;<IP_ADDRESS>;80;]]

At commit a80c575 that came right before the merge of #1375, zq seemed to quietly "skip over" the x509 record. This made sense to me as a user because id.orig_h didn't exist in the x509 event.
$ zq -version
Version: v0.22.0-18-ga80c575

$ zq -t 'count() by id.orig_h' input.tzng
#0:record[id:record[orig_h:ip],count:uint64]
0:[[<IP_ADDRESS>;]1;]
0:[[<IP_ADDRESS>;]1;]

Now at commit 56ed80d that comes with the merge of #1375:
$ zq -version
Version: v0.22.0-19-g56ed80d

$ zq -t 'count() by id.orig_h' input.tzng
incompatible types

I wondered if maybe this is some intentional new stricter behavior. However, we do still quietly "skip over" attempts to aggregate by wholly absent top-level fields, e.g.:
$ zq -version
Version: v0.22.0-19-g56ed80d

$ zq -t 'count() by foo' input.tzng
[no output]

Therefore I assume this is worth a look. If consensus is that the current behavior is actually desired, then at minimum we'll need to adjust the zar README.

I think this is a bug, but since @mccanne is reworking how dot-fields are handled, this bug might be fixed along with that.

Verified in zq commit e65ed59.
First, I had to update the input data from the alpha TZNG format shown above to the new beta ZNG format.
$ zq -version
Version: v0.22.0

$ zq input.tzng > input.zng

[...update to current zq commit e65ed59...]
$ zq -version
Version: v0.22.0-50-ge65ed59

$ zq -t input.zng > input-beta.tzng
warning: input.zng: converting from alpha zng to beta zng (slow)
warning: update zng by running 'zq -o new.zng old.zng'

$ zq -t 'count() by id.orig_h' input-beta.tzng
#0:record[id:record[orig_h:ip],count:uint64]
0:[[<IP_ADDRESS>;]1;]
0:[[<IP_ADDRESS>;]1;]

The index creation shown from the zar README that was broken also works now.
$ zar -version
Version: v0.22.0-50-ge65ed59

$ zq zng/*.gz | zar import -s 25MB -
$ zar index -q -o custom.zng -k id.orig_h -z "count() by _path, id.orig_h | sort id.orig_h"
$ zar ls -l
file:///Users/phil/logs/zd/20180324/d-1ise0yfDIpEGpbBGxou72pNvfgD-188695-1521912990158766000-1521911720601474000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0qTowgbKLIwFJhd6FPwOBmF-212117-1521912809032641000-1521911720612096000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0s6m9ZfpD1MJcko4aaBDNbt-224712-1521912573152746000-1521911720608867000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0jbLU2Pfc3fy7smVHJILJFF-199875-1521912355502512000-1521911720601374000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0edG7qOGsK0UU32FCiRPbsx-209351-1521912172917284000-1521911720609380000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0RmPPNQbS2FruKI4lpDdl4c-212678-1521911994618642000-1521911720726418000.zng.zar/custom.zng
file:///Users/phil/logs/zd/20180324/d-1ise0NrwoZ2ROt4g5yheRuaHwlc-214650-1521911858335096000-1521911720600725000.zng.zar/custom.zng

Thanks @mccanne!


v2.0 - Map.getMyLocation() does not invoke error callback if location permission denied

I've taken out the body of my callbacks, but this is essentially what I have.  If user denies the app permission from using location, the error callback is not invoked.  I looked through the code and nothing looked obvious.  I've never done any cordova plugin development so I dont really know what to look for though. :D
map.getMyLocation({}, function (location) {
  console.log('Success!');
}, function () {
  console.log('Error!');
});

Do you use Android or iOS?

Ah sorry... Android

The plugin code is really clean by the way :+1:

I just executed the v2.0 demo app, but it worked.
Document page
Full code
Demo APK
https://github.com/mapsplugin/v2.0-demo#demo-apk

Sorry false alarm.  I had included the "myLocationButton: true" option in the Map.getMap() function and I didn't realize that the permission was being checked in the Map.getMap() function.
Thanks for helping and sorry about the false alarm.  Closing the issue.


Upgrade isort and black to latest possible.

For isort this is latest stable but for black we have to hang back
pre-stable since stable drops support for Python 2.7.

The only real change is support for sorting imports in all locations.


[REFACTOR] Cleanup longhorn-manager common packages

Is your improvement request related to a feature? Please describe
Currently, the common packages (types, util) in longhorn-manager are unorganized.
Describe the solution you'd like
Reorganize longhorn-manager common packages.
Describe alternatives you've considered
None
Additional context
https://github.com/longhorn/longhorn-manager/pull/1891#discussion_r1212707846

We will have some refactoring together with #3161, but for the remaining refactor, let's move to 1.7 instead.

If this is finished, please close it.


MythicalMysfitsServiceCodeBuildProject  failes with an error

BUILD | Failed | COMMAND_EXECUTION_ERROR: Error while executing command: docker tag mythicalmysfits/service:latest $AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com/mythicalmysfits/service:latest. Reason: exit status 1
POST_BUILD | Failed | COMMAND_EXECUTION_ERROR: Error while executing command: docker push
$AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com/mythicalmysfits/service:latest. Reason: exit status 1
UPLOAD_ARTIFACTS | Failed | CLIENT_ERROR: no matching artifact paths found
Any ideas why am I getting this error?

There are some changes that are required in the json file to create the CodeBuild Project:
https://github.com/aws-samples/aws-modern-application-workshop/blob/python/module-2/aws-cli/code-build-project.json
These errors could be a sign that those commands are looking for the AccountId and Region variables to be appropriately set but still have the placeholder values instead.

Closing after inactivity. Please comment/reopen if the issue persists.

@abaird986 the error happens in module-4 after this push: git commit -m "Update service code backend to enable additional website features."

I've got the same error. The readon was
docker pull toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit


weight parameter not working

Good day,
I am interesting to use the weight param to set my weight for my objective function. I believe this weight give me the option to set individual weight to each row and this will in turn leads to higher weight == higher contribution in the terms of loss.
Based on the documentation:

I passed this as a dictionary params: (just a simple example). My weight column is the first column.
params = {
        'nthread' : 6,
        'learning_rate': 0.01,
        'num_leaves':80,
        'max_depth': 7,
        'weight': 0}

and later used it in train.
After training, when i check the feature importance and find that the column weight is used as a feature. Does this mean that the weight parameter is not taken into account? It will be good if you can help
Edit: is this weight_column suppose to be in .dataset and not in param dictionary?

@germayneng Use the Python API in Python for setting weights. You are using the documentation for CLI which behaves differently in wrappers.
See the following, the weights must be set separately: https://lightgbm.readthedocs.io/en/latest/Python-API.html#lightgbm.Dataset

thanks @Laurae2
One more thing, if i were to add to .Dataset, i assume that i only need to pass this weight array into the train dataset right? I should not need to pass it into the valid dataset?

weight should also affect metric. Passing weights to the validation set is possible.


Service request: Digitally Imported, a multi-channel internet radio

From Launchpad bug #1260335 by Laurențiu Lozan:
Digitally Imported is a multi-channel internet radio service that focuses exclusively on Electronic Music. Today, our team of curators sift through petabytes of new releases and back catalogs to find only the best from each genre or style. But it wasn’t always like that.
Homepage: http://www.di.fm
Playback: Requires Flash :-(
Scriptable: Yes
Country availability: Not specified, probably not restricted
Accessible to the Nuvola Player's developer: Yes :-)
The old bug tracker contains some patches for Nuvola Player 2.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Digitally Imported is now called just DI.FM.  The initial release has been published and will be announced with Nuvola 4.17. See installation instructions.


chore(master): release 1.1.16

:robot: I have created a release beep boop
1.1.16 (2023-08-15)
Bug Fixes

deps: update dependency wayofdev/laravel-cycle-orm-adapter to v4.0.59 (c7d0b5b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-webhook-client/releases/tag/v1.1.16 :sunflower:


Integrate Google Webmaster and sitemap generator with DNs

this sitemap generation will be something EN will always run. closing.


Question of Zero123 unified guidance file

What is the structure of the pretrained file of zero123-unified-guidance?  The zero123-unified-guidance use pretrained_model_name_or_path of diffusers, corresponding file examples should be provided of "bennyguo/zero123-diffusers"

Hello, You got it?
I am getting an error regarding it -> #336


Add functions to mutate a dataframe in place

The goal is to be able to keep up with rapidly changing data by
writing directly into the dataframe.
Modifying dataframes
The way that we do this is that we index into the chunk, and once we do, we have
access to a contiguous array of memory:
Step 1: index into the series we care about
Step 2: index into the chunk within the series
Step 3: modify all the data within the chunk
allowing multiple writes to a single chunk all at once helps to amortize away fixed
costs such as ocaml interop and the cost of shallow clones or something. This interface
requires that users know which chunk they care about -- otherwise, finding the
appropriate chunk would be O(n_chunks).
In this feature:
ints satisfy NativeType and are handled by this feature.
uints satisfy NativeType and are handled by this feature.
floats satisfy NativeType and are handled by this feature.
Future work:
bool chunks are represented as BooleanArray and can be mutabled.
Naivedate + Naivedatetime chunks are represented by logical types and can be
mutated by casting to i32 + i64 arrays, respectively.
use arrays instead of lists?
Not handled:
String chunks are represented by concatenating the chunk together, and are hard to
modify in-place because changing the length shifts the chunk left or right.
vstack_and_execute
The second part of this feature is vstack_and_execute. The goal here is that we
would like to be able to

append one row at a time from a kafka stream, with each append taking O(1) time.
update a value within a series in O(1) time.

We maintain a pseudo-dataframe that partitions the rows into two partitions:

One partition that only contains chunks of length 1000
One partition of length 0 <= len < 1000 that only contains chunks of length 1

Basically, all the chunks of the dataframe are length 1000, except that the remainder
is placed in partition 2. Approximately speaking, this allows us compute convert an
index within a series into a chunk index in O(1) time by computing [index % 1000]
The problem is that once partition 2 reaches length 1000, we need to rechunk those
1000 rows by popping off the last 1000 chunks, rechunking them, and popping them back
on to the dataframe. I don't know how to do that without segfaulting, so I did the
following thing instead:

One dataframe that only contains chunks of length 1000
One dataframe of length 0 <= len < 1000 that only contains chunks of length 1

When dataframe 2 exceeds size 1000, we rechunk it and vstack it onto dataframe 1.
If we want to run a sql query, we shallow clone both dataframes, vstack them on top of
each other, run the query over the union, and then destroy the shallow clones. I think
this vstack operation is O(n_chunks) but I'm not 100% sure.
Testing
Expect tests for modifying int and float values, and expect tests for vstack_and_execute

@mt-caret do you know what's going on with these build failures? I think it builds fine for me locally

I'm digging into this, but I'm pretty puzzled at why we're getting weird errors here.

I haven't been able to figure out what's going on with the CI, but I don't want to block this PR for any more longer; merging.

🎉


Fix unit-test build error on ARM64

I'm not sure about this, but on ARM64 using gccgo, I got this error when doing unit-test:
# _/go/src/github.com/docker/docker/pkg/archive
./archive_test.go:876:14: error: incompatible type for return value 1 (cannot use type uint32 as type uint64)
  return statT.Nlink, nil
              ^

But according to https://golang.org/pkg/syscall/#Stat_t, statT.Nlink should be uint64.
Don't know what really happened.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

@hqhq interesting. This is coming directly from C type Stat_t C.struct_stat

LGTM

LGTM