[bug]: ES6 module / CommonJS combination issue

When loading in a component into a module that is mainly ESM syntax using commonjs require, the error "Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object." is appearing.

The react component being loaded in is written in ESM
The App wrapper it is being put in is written in ESM
The react component being loaded in is loaded with CommonJS (const Test = require('./test');)

This issue was extracted from a bug found in Gatsby where if we wrote a gatsby-browser.js file in CommonJS and imported a module that was written in ESM syntax: https://github.com/gatsbyjs/gatsby/issues/13667

Is this a bug report?
Yes
Environment
N/A (npx create-react-app --info is not giving me my environment for some reason)
Steps to Reproduce
Started with a base CRA app and then added this feature.

Clone this reproduction: https://github.com/lannonbr/CRA-ES-CommonJS-Bug-Reproduction and install the dependencies
Run yarn start
See the error on the clientside

Expected Behavior
The page would load in and include the <Test /> component that is loaded in.
Actual Behavior
It throws this error when the page is loaded:

cc: @sidharthachatterjee

I could be entirely wrong here but I don't think it's a bug. babel-loader is set to modules: false which means do not compile modules to commonjs or whatever format you like. It stays esm. If it's an esm module it converts more or less to exports.default <=> export default when using require. Webpack won't do any interop here.
Most packages compile to cjs form es which have the special __esModule property. This tells webpack (and other bundlers) to resolve exports.default as module.exports.
There is an ongoing discussion about this https://github.com/webpack/webpack/issues/4742

After discussion downstream, this is going to be resolved so it's really doesn't need to be handled as @wardpeet discusses. Closing this.


Default load additional direnv libs

I use some plugins that put some files in ~/.config/direv/lib (like asdf-direnv. It would be nice if there was built-in support for loading those in quickenv.
As a workaround is there a way to add this to a search path for quickenv?

yeah, quickenv should implement this part of direnv. patches welcome.


Merge against latest google/gopacket master

There were mostly conflicts around imports, at least one block of CGo that needs a little more careful inspection, and a conflict in DecodeFromBytes which could use a glance, too.
This is required by https://github.com/elastic/beats/pull/4719.

That sounds less bad than I was afraid of. How do you propose we continue? Is there a way for me to review the conflicted files?
I'm thinking we could merge this one, and then try to update the vendored copy in Packetbeat, to see if anything broke. If it gets to messy, we can still revert the merge.

Sounds good, @tsg! Unfortunately, I don't think there's an easy way to tell git to show only changes in conflicted files, as once they're merged that information is lost.
I think it's possible to point the vendored copy in Packetbeat at this branch in order to test it, so master on this repo isn't left at any point in time in a potentially broken state (don't know how much that would matter, tbh - up to you).

@cv Thanks! I'm going to do the merging next week because we're just before a feature freeze and don't want to take risks until we branch out the current release.

Cleaning up my PR queue, feel free to take over this PR if it's still valuable!


Lums/sc 42599/implement ivf pq index

This PR implements IVF index with PQ encoding.  It requires the results from #265 so this is a branch from there.
As the name implies, this index synthesizes the indexing from IVF with the vector encoding from PQ.  Ultimately there should be a decomposition of indexes into index representation, vector representation, and distance computation.  However, because there is still a need to gather sufficient implementation experience with the different variants of each (and their compositions), the current implementation is monolithic.  The new story sc-43058 was created for this refactoring.
The current scheme for C++ indexes includes implementing a class for metadata, for the storage group, and for the index itself.   These exist as separate files in the index subdirectory for each of the current indexes.  (Note that flat_l2_index and flat_pq_index have not been re-factored this way yet, though placeholder files for the metadata and group classes have been created.
Group and Metadata
The metadataivf_pq_metata essentially includes the metadata for each of IVF Flat and Flat PQ.  The group ivf_pq_group contains arrays that are the integration of IVF and PQ:

cluster_centroids -- the centroids used for encoding with PQ
flat_ivf_centroids -- the flat (unencoded) centroids used for IVF indexing.  These are obtained by applying kmeans to the  flat input vectors.
pq_ivf_centroids -- the PQ encoded centroids used for IVF indexing. These are currently obtained by PQ encoding the flat_ivf_centroids.
pq_ivf_vectors -- PQ encoded vectors from the input, partitioned and shuffled
ivf_index -- IVF index vector (same as in IVF Flat)
ivf_ids -- vector ids (same as in IVF Flat)
distance_tables_* -- distance tables, one table per subspace and one array per table.  These should probably go into a single array at some point.
The data for pq_ivf_vectors, ivf_index, and ivf_ids are maintained as a PartitionedMatrix (or tdbPartitionedMatrix).

Ingestion
The first step in ingestion is in train_pq which generates the cluster_centroids -- using sub_kmeans as was used in the previous PQ related PR.  (Note that all kmeans functions have been moved to the file kmeans.h). Once we have the cluster_centroids we have the ability to encode all of the input vectors.  train_pq also generates the distance_tables.
The train_ivf function applies kmeans to create a set of centroids and partition the input vectors.  There are two ways this could be accomplished:  Partition the flat vectors first to create a set of flat centroids, or encode the vectors first, apply kmeans to the encoded vectors to create a set of encoded (or unencoded) centroids.  We opted for the former in this PR.  With the former, we can then create compressed pq_ivf_centroids from the flat_ivf_centroids.
Once we have the ivf_centroids (flat or pq), we can partition and shuffle the input vectors (unencoded or encoded).  In our case, we use the flat centroids to create the partitioning and then apply that partitioning to shuffle the encoded vectors.  Again, there are multiple variations to try in terms of whether to use encoded or unencoded quantities at various steps in the ingestion / indexing process.
Right now everything happens in the add function:
    train_pq(training_set);   // Create cluster_centroids_, distance_tables_
    train_ivf(training_set);   // Create flat_ivf_centroids_
    unpartitioned_pq_vectors_ = pq_encode(training_set); // encode the input vectors
    pq_ivf_centroids_ = std::move(*pq_encode(flat_ivf_centroids_)); // encode the flat ivf centroids

    auto partition_labels = detail::flat::qv_partition(
        flat_ivf_centroids_, training_set, num_threads_, distance);  // partition

    partitioned_pq_vectors_ = std::make_unique<pq_storage_type>(
        *unpartitioned_pq_vectors_, partition_labels, num_unique_labels);  // shuffle

There is not currently a separate train function, though perhaps this add() function should be split into different parts.  These pieces were kept together for the time being to allow experimentation with different ordering of encoding and so forth.
Note that when the create_default_impl function is called during ingestion, the metadata are set with information from the index at the very top of the function, as that information will be used later on in the function.
Queries
Queries are applied by calling the existing query functions to search the ivf index, using an appropriate distance function.  If we pass in flat query vectors, we use the asymmetric distance function.  If we pass in compressed query vectors, we use the symmetric distance function.  Currently we do not compress the queries, so we use the asymmetric distance function.  Per sc-43051, we should SIMDize these functions, as well as reorder the loops for encoding, etc -- which should result in 10-20X speedup.  The ivf_pq_index class only currently includes query_finite and query_infinite (it does not have calls tot the various qv, nut, and so forth).
Unit Testing
Unit testing performs most of the same tests as for flat_pq and for ivf_flat -- though currently not as thoroughly.
Distributed Computation
This should be as easy to distribute as IVF Flat, since partitioning and querying (etc) are oblivious to vector representation.

NOTE(paris): I'm currently waiting to merge this until Vamana is fully working end to end, as that will help keep the changes I need to do when fixing bugs in the group / metadata / etc. down. Once it's working I'll bring this in and apply all changes.


Add "interval": "validation" to scheduler configuration

🚀 Feature
This request concerns the optimizer Scheduler.
For now, the scheduler can be configured like this:
lr_scheduler_config = {
    "scheduler": lr_scheduler,
    "interval": "epoch",  # epoch, step
    "frequency": 1,
    "monitor": "val_loss",
    "strict": True,
    "name": None,
}

It would be great to add the option "interval": "validation".
Motivation
My use case is the following. I want to .step() the scheduler after each evaluation step, using an evaluation metric and ReduceLROnPlateau scheduler.
Sometimes (1) I'm using a bigger dataset, so in the case I use val_check_interval=0.1.
and Other times (2) I'm using smaller dataset, so I use check_val_every_n_epoch=5.
The current interval options are not working for me. step will call the scheduler each step, and epoch will do it after each epoch, however, for my case (1), the scheduler will be called once every 10 validations, and in (2), the scheduler will be called before the validation, and I will get the error pytorch_lightning.utilities.exceptions.MisconfigurationException: ReduceLROnPlateau conditioned on metric my_quantity which is not available. Available metrics are: ['train/loss']. Condition can be set using 'monitor' key in lr scheduler dict.
I hope this is clear for you.
cc @borda @tchaton @rohitgr7

@tchaton do you think adding an additional 'validation' interval would be a good idea? can't think of any configuration to support it with 'step'|'epoch'. Although there are 2 cases in the above-shared example but I think there can be a case where multiple validation checks can happen in a single training epoch with validation configured to be triggered after every n epochs. So both step and epoch won't work here.

@de-gozaru following the doc you could set "interval": "step" and adjust frequency to be equal to your evaluation process frequency.
E.g. for (1) set:
lr_scheduler_config = {
    "scheduler": lr_scheduler,
    "interval": "step",
    "frequency": 0.1*epoch_length,
    "monitor": "val_loss"
}

For (2) just set "frequency": 5 and  "interval": "epoch".

I'd second this feature. Setting up LR scheduleres that monitor a validation metric and having a fractional val_check_interval is currently not easily possible.


Hitas contract PDF template update (ASU-1642)

Update the Hitas contract PDF template and its generating code.
Also add tests for it.

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fcabbb9) 89.63% compared to head (8eb9011) 89.64%.

Files
Patch %
Lines

application_form/tests/test_pdf_hitas.py
83.87%
3 Missing and 2 partials :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   89.63%   89.64%
=======================================
  Files         342      343    +1
  Lines       12329    12396   +67
  Branches      890      893    +3
=======================================
+ Hits        11051    11112   +61
- Misses       1136     1139    +3
- Partials      142      145    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore: run CI on Windows image

What does this PR do?
Change CircleCI configuration to run on Windows image
What issues does this PR fix or reference?
W-8914917

OK. I've changed it to use Node 14, which requires the installation of Node and then Yarn. Unfortunately, this adds ~15s to the pipeline :-(  (I've tried but failed to configure CircleCI to properly cache Node and Yarn installations).


Why aren't exceptions handled by the Exception middleware

In the samples folder if you hit /error it throws an exception.  The UseExceptionHandler  middleware should capture that and redirect.  This used to work but no longer does, we need to investigate why.

I've added some console.writeline everywhere and its simply not coming back into botwin.  If I do the below:
app.UseExceptionHandler("/foo");

            app.UseWhen(ctx=>ctx.Request.Path=="/foo", subapp => subapp.Run(ctx=>ctx.Response.WriteAsync("ppppp")));

            app.UseBotwin(this.GetOptions());

/foo is hit
The route handler for /errorhandler is never hit in the sample as it stands

The issue seems to be adding headers to the request on the exception handler. The sample does this on the Botwin global before hook
https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNetCore.Diagnostics/ExceptionHandler/ExceptionHandlerMiddleware.cs#L82

Issue raised here https://github.com/aspnet/Diagnostics/issues/425


GraalVM Native Image support

Provide a GraalVM Native Image support feature that creates native executable.
More information here https://www.graalvm.org/docs/reference-manual/native-image/
Expected Behavior
User should be able to select if he wants to produce a jar or a native image of GraalVM.
Current Behavior
No such feature.
Context
It might be useful to have it either integrated into Gradle or have an official plug-in that can compile your application into GraalVM native image.

There is at least one plugin for this: https://github.com/palantir/gradle-graal and might be others.
There is currently no plans to have this made a core Gradle plugin.

ok, but I hope somewhere in future along with jar and war you will integrate one more application packaging type -- native image.

I am closing this as this is something that is already provided by plugins non core to Gradle. And there is no plans to offer this from a core Gradle plugin.


Patch conf.py for readthedocs sphinx injection deprecation.

What does this PR do?
Patch conf.py for readthedocs sphinx injection deprecation. As build time injection is deprecated, we apply the patch recommended by readthedocs.

@bandish-shah @dakinggg bumping for review in case it slipped through


RGB and HSV differ in assumptions regarding coordinate order

I have a notebook with the following code:
from holoviews.operation.datashader import aggregate
import holoviews as hv
import numpy as np
import dask.array as da
import dask.dataframe as dd
from dask.distributed import Client
import geoviews as gv
from elm.readers import *
client = Client()
band_specs = [BandSpec('name',
                       'B{}.TIF'.format(idx),
                       'B' + str(idx),
                       buf_xsize=1000,
                       buf_ysize=1000)
              for idx in range(1, 8)]

pix = load_array(TIF_DIR, band_specs=band_specs) #elm.readers

dset = hv.Dataset(pix)

for b in dset.data.band_order:
    band = getattr(dset.data, b)
    band.values = band.values.astype(np.float64) / 2 ** 16

hv.HSV(dset, kdims=['x', 'y'], vdims=['B3', 'B4', 'B5'])

The HSV plot causes the image (below - Chesapeake Bay) to have north - south reversed:

When changing just the final line of the snippet above to:
hv.RGB(dset, kdims=['x', 'y'], vdims=['B3', 'B4', 'B5'])

then image south - north orientation makes sense:

Thanks, I can reproduce, I forgot to update the HSV.rgb property after changing how it accesses the data. Simple fix and good to get in before 1.7.

The PR fixing this issue has now been merged. Closing.


Show InlinePanel non field validation errors

This fixes https://github.com/wagtail/wagtail/issues/3890.
Non field form errors were not rendered for InlinePanel items. This PR fixes the issue and renders the error message like this:

I've added a test case for the issue.
Feedback is appreciated

Thanks for your review @ababic
I've implemented your feedback

Merged in 9f5cd32! Thank you very much @Stormheg! and congratulations on your first contribution! 🎉 🎉 🎉


support given localAddress binding in connection creation

Support localAddress binding if default IP is not enough.

@pfmooney or @mcavage, can you support here. Is it possible to merge this change and publish new version of ldapjs? As for tests they pass on same nodejs version locally :/

Any feedback please?

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


network sync protocol leaks documentIds to peers

Imagine the following -- I have a document containing secrets. I give you the AutomergeUrl so you can request it from me.
In order to request the document, you broadcast that URL to all your peers asking if they have it. Now any misbehaving peer could record that request and replay it a few minutes later to fetch the document.
Unfortunately, there isn't really a great solution for this right now aside from only connecting directly to peers you trust. This hasn't been a major issue to date in our work because we only use a single trusted sync server -- but in the case of federated sync servers (per @clemens work) or peer-to-peer configurations, we'll need a more robust solution.
Probably the state of the art here is to do something like hypercore's discovery key: a deterministically hashed version of the ID in question which can be trivially calculated if you have the actual document but is unguessable otherwise.
I've filed this as an issue so it doesn't get forgotten as we think about the next version of our sync protocol. cc / @alexjg

This scenario is only a problem if we honestly think it's a good idea for a single ID to simultaneously have the jobs of (1) uniquely identifying a document and (2) acting as a token giving the bearer read/write access to that document until the end of time.
Rumplestiltskin security has served us well while we work on other problems, but I hope we're being honest with ourselves about the fact that it's only really an option for a real-world application with zero security concerns.

100% agree. It's time to do something better. Even in a world where only
(1) is true we should still be mindful about where we send them though.


Remove demo files from the built apk file

each time the apk is buit the demo files also gets included adding extra 3mb to the apk file. is there a way to skip the png files ? or maybe i think they should not be there in the first place.

Thanks @astroanu I will remove then
this answers the question from @KhaledElAnsari
Will be implemented next days

thank you .

https://github.com/appfeel/admob-google-cordova/commit/faa5c7945c0aa39c58fddbeba56761b75d2fd65a


Enable identity form on Polkadot

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #6099
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?
yes - $

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 77c1059
Improved the identity form validation and the profile dropdown navigation. The identity form now handles the submit event properly and checks the input length correctly. The profile dropdown only shows the incoming offers link for chains that support the remark protocol.

🤖 Generated by Copilot at 77c1059

To show offers for remarkable art
We check the chain before we start
We use v-if and template
To render the link as appropriate
And avoid a confusing or empty part

all chains that support identity seem to be fetching balance properly minus Statemint because i believe it has yet to be implemented.
Statemine won't show the needed KSM amount for creating an identity tho
Identity created successfully on Basilisk:

https://basilisk.subscan.io/extrinsic/3515088-2
@daiagi i believe the charcount is 4px under textfield, alligned right (#6116 )

how u managed to do that? :D

pay 50 usd

how u managed to do that? :D

lol, i've deleted a comment of my in this PR because i though it was related to the whole identity form other than only enabling it on Polkadot, but the label can't be removed, so, haha.
Wasn't able to test this one properly since i'm out of DOT atm


Get Health probe more details about unhealthy backend

Hi, I'm trying to get more information about unhealth backend. I will find general information (based on https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-diagnostics#back-end-health) in log. But I need to get more details, e.g. status code 404, 500. Is it possible to get it from log somehow ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5f080ad-843f-d7be-eba6-2837993d052b
Version Independent ID: b6f75acf-e3ed-f6c3-a29e-8f440eb0a9dd
Content: Monitor access logs, performance logs, back-end health, and metrics for Azure Application Gateway
Content Source: articles/application-gateway/application-gateway-diagnostics.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@jjindrich , Thank you for posting here. I will investigate and get back to you shortly.

@jjindrich , Do you have any update for me?

Hi, I checked REST API, but as I can see https://docs.microsoft.com/en-us/rest/api/application-gateway/applicationgateways/backendhealth#get-backend-health returns only Up/Down status. But no more details which I'm looking for. I need to get the result of calling backend, like http status. Let's imagine from operation model - ops guys is alerted that backend is down from AppGw perspective, but he has no details what happend.

@jjindrich , I am getting the message as why the probe is failed. See the below image:

Fine, got it. Is it planned to put this information into log in Azure Monitor ? Will help

@jjindrich , as of today you will only get this info via calling the REST API. Will pass on your feedback to get this info incorporated in Azure Monitor.


Group Golang Kiota repositories

Related to https://github.com/microsoft/kiota/issues/4636 and https://github.com/microsoft/kiota-abstractions-dotnet/issues/238
As a language specific concern, we should look into the feasibility of grouping the repos and outline if this is not feasible in this issue.

@andrueastman for this one I don't think we can do it since the package namespace and the module distribution are directly mapped to the repo address. I suggest we close this issue to avoid confusion here.

Thanks @baywet.


[unity3d] Update version info

Latest Release Dates Added
Missing Versions Added

Let me handle latestReleaseDate things before review, give me a few minutes

@captn3m0 why this one giving error from latest.py ? i couldnt see any error on syntax

The error is :
 ruamel.yaml.parser.ParserError: while parsing a block mapping
  in "products/unity.md", line 2, column 1
expected <block end>, but found '-'
  in "products/unity.md", line 27, column 1

Looks there is a problem with the releases list.

Fixed. The - for the first two releases were not properly aligned.

Fixed. The - for the first two releases were not properly aligned.

Thank you , idk how i missed it :)


[RFR] One push per review

Fix #59

Please do not merge, we have a loop on fixes in the index

Good for me now!


Can't connect to Firestore anymore

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.3.1
Firebase SDK version: 6.22.0
Firebase Component: Firestore
Component version: not sure (but sure I have latest [removed and installed again])
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
Can't connect to firestore. Can't read data.
Steps to reproduce:
What happened? How can we make the problem occur?
this is enough to make the problem occur
FirebaseApp.configure()
I did pod update with no luck, the following is the error stack trace:
****[14875:781917] [GoogleDataTransport][I-GDTCOR001006] There was an error reading extension bytes from disk: Error Domain=NSCocoaErrorDomain Code=260 "The file “event-5660938629709599763” couldn’t be opened because there is no such file." UserInfo={NSFilePath=***/Developer/CoreSimulator/Devices/24E1E711-47A4-4048-841F-C7BAFA14B833/data/Containers/Data/Application/D01B42C8-7503-486D-96FC-42F725EB3CC2/Library/Caches/google-sdks-events/event-5660938629709599763, NSUnderlyingError=0x600003e49cb0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}} 2020-04-09 15:29:28.978481+0300 BJ_HouseOwner[14875:781919] [GoogleDataTransport][I-GDTCOR001006] (/***/Pods/GoogleDataTransport/GoogleDataTransport/GDTCORLibrary/GDTCORStorage.m:152) : There was an error removing an event file: Error Domain=NSCocoaErrorDomain Code=4 "“event-5660938629709599763” couldn’t be removed." UserInfo={NSUserStringVariant=(     Remove ), NSFilePath=***/Developer/CoreSimulator/Devices/24E1E711-47A4-4048-841F-C7BAFA14B833/data/Containers/Data/Application/D01B42C8-7503-486D-96FC-42F725EB3CC2/Library/Caches/google-sdks-events/event-5660938629709599763, NSUnderlyingError=0x600003eab300 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Relevant Code:
FirebaseApp.configure()

Here is my firebase access rules
rules_version = '2'; service cloud.firestore {   match /databases/{database}/documents {     match /{document=**} {       allow read, write: if  true ;     }   } }

I solved this issue by making more space available in the iOS simulator. I deleted some of the apps that I developed in the past, and now it is working fine. I will close this issue now.

@mikehaney24 FYI

@Ryan-Gadhi Thanks for the report! Indeed this does look like an internal component was unable to write to disk because you were out of space.


KafkaChannel: missing RBAC for webhook certs

Describe the bug
https://github.com/knative/eventing-contrib/blob/6809717129cb7c917fe163397fb4f1a86aaff14e/kafka/channel/config/200-webhook-clusterrole.yaml#L32-L41
Is missing "update"
Expected behavior
Webhook able to update config
To Reproduce
Install KafkaChannel
Knative release version
Tested in 0.11.3 but appears to also exist in future versions as well.

Fixed https://github.com/knative/eventing-contrib/pull/1082
/close

/close


Warn about ~ not expanded when setting up the auth cache

Or maybe actually expand it?

Fixed by 485356a39bfb26430bb8c4fbfc0fb3d19acede13: ~ is expanded to $HOME.


chore: bump version to 1.4.1

Codecov Report

Merging #68 (26ce7e5) into main (c2765ae) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 26ce7e5 differs from pull request most recent head 6d47ce6. Consider uploading reports for the commit 6d47ce6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        13    +2
  Lines           66       100   +34
=========================================
+ Hits            66       100   +34

Impacted Files
Coverage Δ

lib/src/bloc_action_listener.dart
100.00% <100.00%> (ø)

lib/src/bloc_builder.dart
100.00% <100.00%> (ø)

lib/src/bloc_comparative_builder.dart
100.00% <100.00%> (ø)

lib/src/bloc_comparative_listener.dart
100.00% <100.00%> (ø)

lib/src/bloc_defaults.dart
100.00% <100.00%> (ø)

lib/src/bloc_factory.dart
100.00% <100.00%> (ø)

lib/src/bloc_hook.dart
100.00% <100.00%> (ø)

lib/src/bloc_listener.dart
100.00% <100.00%> (ø)

lib/src/config/hooked_bloc_config.dart
100.00% <100.00%> (ø)

lib/src/hooked_bloc.dart
100.00% <100.00%> (ø)

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


text labels for segmentation layer

Is it possible to construct a segmentation layer with a mapping that assigns a name to each unique value in the underlying data?

Yes, via a segment property map defined using the precomputed format:
https://github.com/google/neuroglancer/blob/master/src/neuroglancer/datasource/precomputed/segment_properties.md
See example here:
https://hemibrain-dot-neuroglancer-demo.appspot.com/#!gs://neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json
Note: The segmentation data itself does not need to be in the neuroglancer precomputed format, you can just add the segment property map as an additional data source.

Note: Ignore the "indexed" property type, that isn't implemented yet.

Depending on your use case, it might also make sense to define a new segment property map data source type, e.g. a DVID-backed one.

Thanks for the information, I'm not sure I grok it all yet. For context, my datasets are n5 arrays stored on s3. I will have between 0 and 60 text labels to map to the same number of integer values in the segmented volume.
Are you saying that I would need to define a segment property map as a datasource backed by a new JSON file that contains the mapping between uint64 values in one of my segmented volumes? (I know the FlyEM team, so I can ask them about this if you think they can demonstrate this to me)

Yes, create a JSON file like:
https://neuroglancer-janelia-flyem-hemibrain.storage.googleapis.com/v1.0/rois/segment_properties/info
Then make sure it can be retrieved via a URL like:
https://whatever/path/info
(the filename must be info)
then add as a data source:
precomputed://https://whatever
If there is some convention for defining such maps as additional attributes within the n5 attributes.json file, then it would be easy enough to add support to Neuroglancer for that as well (then the map could be used automatically when you add the n5 data source).

@jbms what is your suggested method for hosting the segment properties JSON file? I only know about hosting precomputed datasets with cloudvolume, but since this info file is not of the right format for cloudvolume, then that is not an option.

You will have to write your own code to generate it, but that should be easy since the format is pretty simple.  If you are using Google Cloud Storage, you can upload it using gsutil or with one the Python libraries (e.g. boto or https://cloud.google.com/storage/docs/reference/libraries).

I wrote my own code to host the info file locally using flask, but Neuroglancer gives me a CORS error:
Fetching "http://localhost:5005/info" resulted in HTTP error 0: Network or CORS error. I verified that curl http://localhost:5005/info does give me the json body. I find the CORS error strange because I can successfully use cloudvolumes in Neuroglancer that are hosted locally and without https.

Using a local web server is fine, but you will need to set it up to send back the appropriate CORS headers.  I'm not sure specifically how to set that up with flask (though I did find this https://flask-cors.readthedocs.io/en/latest/).  As an example, you can use cors_webserver.py in the neuroglancer repository, or the node http-server package with the --cors option.

OK that worked in the sense that I no longer get a CORS error and can load in localhost:5000 as a layer with no errors. However, I don't see any segment property information showing up in my segmentation layer under the "Seg." tab. I have tried the example info file you referenced above and another one, but still no luck. I figured the problem with the example info file was that there was no "string" type property, so I added one in my example but that did not help. Is there an extra step required that I am missing? Here is the example info file I have tried in addition to the one referenced above:
{"@type": "neuroglancer_segment_properties", "inline": {"ids": ["1"], "properties": [{"id": "string", "type": "string", "values": ["AB(L)"]},{"id": "label", "type": "label", "values": ["AB(L)"]},{"id": "description", "type": "description", "values": ["AB(L)"]}]}}

@d-v-b did you end up getting this working with a separate info JSON file defining the segment properties?

Yes, via a segment property map defined using the precomputed format:
https://github.com/google/neuroglancer/blob/master/src/neuroglancer/datasource/precomputed/segment_properties.md
See example here:
https://hemibrain-dot-neuroglancer-demo.appspot.com/#!gs://neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json
Note: The segmentation data itself does not need to be in the neuroglancer precomputed format, you can just add the segment property map as an additional data source.

Is there a template or an accessible example of base.json for segmentation properties?  I suppose gs://neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json is not accessible?

The base.json file is accessible, but it is just a Neuroglancer state:
https://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json
Add a segment_properties member to the the info file for the segmentation:
http://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/rois/info
The value is the name of the sub-directory.
Then create the info file in the sub-directory specified by the segment_property key:
http://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/rois/segment_properties/info

@austinhoag I missed your comment earlier, but the additional step required for the segment properties to show up in the data source list is to reference it from your top-level info file via a "segment_properties" member.  See example in prior message.  You can also directly add the segment_properties as an additional data source to the layer, using the "+" button at the button of the Sources tab.

The base.json file is accessible, but it is just a Neuroglancer state:
https://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/neuroglancer_demo_states/base.json
Add a segment_properties member to the the info file for the segmentation:
http://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/rois/info
The value is the name of the sub-directory.
Then create the info file in the sub-directory specified by the segment_property key:
http://storage.googleapis.com/neuroglancer-janelia-flyem-hemibrain/v1.0/rois/segment_properties/info

@jbms I can't seem to load up "segment_properties" even after I created the sub-directory and info file.  And I have doubts where I'm placing the "segment_name_map": "names", "segment_property": "segment_properties" since they disappear after I apply the change to json on Neuroglancer.  (When I load this sub directory as a main source, I do see segmentation ids in the tab without the actual data.)  Would you be able to point out what I'm doing wrong here?  Thanks, -m
{
  "dimensions": {
    "x": [
      0.000025,
      "m"
    ],
    "y": [
      0.000025,
      "m"
    ],
    "z": [
      0.000025,
      "m"
    ]
  },
  "position": [
<PHONE_NUMBER>7539062,
<PHONE_NUMBER>2148438,
    0.5
  ],
  "crossSectionScale": 1.055028746424448,
  "crossSectionDepth": -5,
  "projectionOrientation": [
    0.20196738839149475,
    0.7169978022575378,
    -0.618348240852356,
    -0.25053688883781433
  ],
  "projectionScale": 82.81277574512146,
  "layers": [
    {
      "type": "segmentation",
      "source": [
        "precomputed://http://localhost:8888/precomputed/test_data",
        "mesh"
      ],
      "tab": "segments",
      "name": "segmented mesh",
      "segment_name_map": "names",      ----> (disappears)
      "segment_property": "segment_properties"   ----> (disappears)
    }
  ],
  "showSlices": false,
  "gpuMemoryLimit":<PHONE_NUMBER>,
  "systemMemoryLimit":<PHONE_NUMBER>,
  "selectedLayer": {
    "layer": "segmented mesh",
    "visible": true,
    "size": 290
  },
  "layout": "4panel",
  "statistics": {
    "size": 309
  }
}

segment_name_map is a remnant for an earlier version of the support in Neuroglancer.  Don't use that, just use "segment_properties".
segment_properties is not a property to be specified in the Neuroglancer JSON state (what you've posted above).  It is a property to set in the info file.   However, if you have your segment_properties info file available at:
http://localhost:8888/precomputed/test_data/segment_properties/info
Then if you don't want to add the segment_properties property to your test_data/info file, you can instead add:
precomputed://http://localhost:8888/precomputed/test_data/segment_properties
as an additional data source to the same layer in the Neuroglancer JSON state:
...
  "layers": [
    {
      "type": "segmentation",
      "source": [
        "precomputed://http://localhost:8888/precomputed/test_data",
        "precomputed://http://localhost:8888/precomputed/test_data/segment_properties",
      ],
      "tab": "segments",
      "name": "segmented mesh",
    }
  ],
...

You can also add additional data sources in the UI:

segment_name_map is a remnant for an earlier version of the support in Neuroglancer. Don't use that, just use "segment_properties".
segment_properties is not a property to be specified in the Neuroglancer JSON state (what you've posted above). It is a property to set in the info file. However, if you have your segment_properties info file available at:
http://localhost:8888/precomputed/test_data/segment_properties/info
Then if you don't want to add the segment_properties property to your test_data/info file, you can instead add:
precomputed://http://localhost:8888/precomputed/test_data/segment_properties
as an additional data source to the same layer in the Neuroglancer JSON state:
...
  "layers": [
    {
      "type": "segmentation",
      "source": [
        "precomputed://http://localhost:8888/precomputed/test_data",
        "precomputed://http://localhost:8888/precomputed/test_data/segment_properties",
      ],
      "tab": "segments",
      "name": "segmented mesh",
    }
  ],
...

You can also add additional data sources in the UI:

That works great!  Thanks @jbms Could I also ask how to open and use the bottom "select" UI?  I suppose it is to select coordinates in the viewer and pin to the dashboard?  I have not figured out the "Annotations" tab yet so I suppose it might be used for just picking a point versus cropping a volume in "Annotations" tab?
Thank you always for your help @jbms
-m

Control right-click opens that panel.

Agh, I see. I had to use a mouse instead of the track pad.  My track pad on mac keeps getting the following warning and I wasn't sure how to activate this.  Could I activate annotation tool without mouse?  But mouse right click seem to ok.  Thank you @jbms

Thanks for pointing out the issue with using control+rightclick on macOS.  I think the issue is that macOS converts rightclick to control+click and vice versa in some cases, because historically Apple shipped machines with just a single button mouse in order to accommodate users without multiple fingers, or something like that.  It appears that control+rightclick is getting translated to just control+leftclick, which is the annotate action.  I will have to look into an alternative binding that works on macOS.  Or perhaps you can check if there is already a way to trigger control+rightclick from the touchpad?

I figured "control + two fingers" on the trackpad and that seem to pop up the GUI so I suppose that could work?

Sorry, I had to ask this @jbms Does segment_properties support color attribute to assign fixed color code on each segmentation?  l key works great to reassign colors on each mesh but I was wondering if that is already supported.
Thanks, -m
https://github.com/google/neuroglancer/blob/master/src/neuroglancer/datasource/precomputed/segment_properties.md

To be clear, control + two finger click already works on your trackpad?  If I get around to writing documentation, I'll include that.
Currently setting colors via precomputed segment_properties is not supported, but that would certainly make sense as a feature if you were interested in implementing it.  At the moment you can only assign colors using the segmentColors property of a segmentation layer in the Neuroglancer JSON state.

yes, I've given a try and control + two finger click does work on my trackpad.


Teensy 4.0

Hello,
Does this work with Teensy 4.0?
I keep getting errors
Arduino: 1.8.13 (Windows 10), TD: 1.53, Board: "Teensy 4.0, Serial, 600 MHz, Faster, US English"
C:\Program Files (x86)\Arduino\arduino-builder -dump-prefs -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\Daniel Walker\Documents\Arduino\libraries -fqbn=teensy:avr:teensy40:usb=serial,speed=600,opt=o2std,keys=en-us -vid-pid=16C0_0483 -ide-version=10813 -build-path C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999 -warnings=none -build-cache C:\Users\DANIEL~1\AppData\Local\Temp\arduino_cache_194824 -verbose C:\temp\Teensy 32\TeensyStripController\TeensyStripController.ino
C:\Program Files (x86)\Arduino\arduino-builder -compile -logger=machine -hardware C:\Program Files (x86)\Arduino\hardware -tools C:\Program Files (x86)\Arduino\tools-builder -tools C:\Program Files (x86)\Arduino\hardware\tools\avr -built-in-libraries C:\Program Files (x86)\Arduino\libraries -libraries C:\Users\Daniel Walker\Documents\Arduino\libraries -fqbn=teensy:avr:teensy40:usb=serial,speed=600,opt=o2std,keys=en-us -vid-pid=16C0_0483 -ide-version=10813 -build-path C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999 -warnings=none -build-cache C:\Users\DANIEL~1\AppData\Local\Temp\arduino_cache_194824 -verbose C:\temp\Teensy 32\TeensyStripController\TeensyStripController.ino
Using board 'teensy40' from platform in folder: C:\Program Files (x86)\Arduino\hardware\teensy\avr
Using core 'teensy4' from platform in folder: C:\Program Files (x86)\Arduino\hardware\teensy\avr
Detecting libraries used...
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -E -CC -x c++ -w -g -Wall -ffunction-sections -fdata-sections -nostdlib -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr\cores\teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\TeensyStripController.ino.cpp" -o nul -DARDUINO_LIB_DISCOVERY_PHASE
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -E -CC -x c++ -w -g -Wall -ffunction-sections -fdata-sections -nostdlib -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr\cores\teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\OctoWS2811Ext.cpp" -o nul -DARDUINO_LIB_DISCOVERY_PHASE
Generating function prototypes...
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -E -CC -x c++ -w -g -Wall -ffunction-sections -fdata-sections -nostdlib -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr\cores\teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\TeensyStripController.ino.cpp" -o "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\preproc\ctags_target_for_gcc_minus_e.cpp" -DARDUINO_LIB_DISCOVERY_PHASE
"C:\Program Files (x86)\Arduino\tools-builder\ctags\5.8-arduino11/ctags" -u --language-force=c++ -f - --c++-kinds=svpf --fields=KSTtzns --line-directives "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\preproc\ctags_target_for_gcc_minus_e.cpp"
Compiling sketch...
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/precompile_helper" "C:\Program Files (x86)\Arduino\hardware\teensy\avr/cores/teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999" "C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -x c++-header -O2 -g -Wall -ffunction-sections -fdata-sections -nostdlib -MMD -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr/cores/teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999/pch/Arduino.h" -o "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999/pch/Arduino.h.gch"
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -c -O2 -g -Wall -ffunction-sections -fdata-sections -nostdlib -MMD -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999/pch" "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr\cores\teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\TeensyStripController.ino.cpp" -o "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\TeensyStripController.ino.cpp.o"
"C:\Program Files (x86)\Arduino\hardware\teensy/../tools/arm/bin/arm-none-eabi-g++" -c -O2 -g -Wall -ffunction-sections -fdata-sections -nostdlib -MMD -std=gnu++14 -fno-exceptions -fpermissive -fno-rtti -fno-threadsafe-statics -felide-constructors -Wno-error=narrowing -mthumb -mcpu=cortex-m7 -mfloat-abi=hard -mfpu=fpv5-d16 -D__IMXRT1062__ -DTEENSYDUINO=153 -DARDUINO=10813 -DARDUINO_TEENSY40 -DF_CPU=600000000 -DUSB_SERIAL -DLAYOUT_US_ENGLISH "-IC:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999/pch" "-IC:\Program Files (x86)\Arduino\hardware\teensy\avr\cores\teensy4" "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\OctoWS2811Ext.cpp" -o "C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\OctoWS2811Ext.cpp.o"
C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\OctoWS2811Ext.cpp: In member function 'void OctoWS2811Ext::begin()':
OctoWS2811Ext.cpp:94: error: 'GPIOD_PCOR' was not declared in this scope
GPIOD_PCOR = 0xFF;
^
OctoWS2811Ext.cpp:119: error: 'FTM2_SC' was not declared in this scope
FTM2_SC = 0;
^
OctoWS2811Ext.cpp:120: error: 'FTM2_CNT' was not declared in this scope
FTM2_CNT = 0;
^
OctoWS2811Ext.cpp:121: error: 'F_BUS' was not declared in this scope
uint32_t mod = (F_BUS + frequency / 2) / frequency;
               ^

OctoWS2811Ext.cpp:122: error: 'FTM2_MOD' was not declared in this scope
FTM2_MOD = mod - 1;
^
OctoWS2811Ext.cpp:123: error: 'FTM_SC_CLKS' was not declared in this scope
FTM2_SC = FTM_SC_CLKS(1) | FTM_SC_PS(0);
                      ^

OctoWS2811Ext.cpp:123: error: 'FTM_SC_PS' was not declared in this scope
FTM2_SC = FTM_SC_CLKS(1) | FTM_SC_PS(0);
                                     ^

OctoWS2811Ext.cpp:124: error: 'FTM2_C0SC' was not declared in this scope
FTM2_C0SC = 0x69;
^
OctoWS2811Ext.cpp:125: error: 'FTM2_C1SC' was not declared in this scope
FTM2_C1SC = 0x69;
^
OctoWS2811Ext.cpp:126: error: 'FTM2_C0V' was not declared in this scope
FTM2_C0V = (mod * WS2811_TIMING_T0H) >> 8;
^
OctoWS2811Ext.cpp:127: error: 'FTM2_C1V' was not declared in this scope
FTM2_C1V = (mod * WS2811_TIMING_T1H) >> 8;
^
OctoWS2811Ext.cpp:130: error: 'PORT_PCR_IRQC' was not declared in this scope
CORE_PIN32_CONFIG = PORT_PCR_IRQC(1)|PORT_PCR_MUX(3);
                                  ^

OctoWS2811Ext.cpp:130: error: 'PORT_PCR_MUX' was not declared in this scope
CORE_PIN32_CONFIG = PORT_PCR_IRQC(1)|PORT_PCR_MUX(3);
                                                  ^

OctoWS2811Ext.cpp:135: error: 'GPIOD_PSOR' was not declared in this scope
dma1.destination(GPIOD_PSOR);
                ^

OctoWS2811Ext.cpp:142: error: 'GPIOD_PDOR' was not declared in this scope
dma2.destination(GPIOD_PDOR);
                ^

OctoWS2811Ext.cpp:156: error: 'DMAMUX_SOURCE_PORTB' was not declared in this scope
dma1.triggerAtHardwareEvent(DMAMUX_SOURCE_PORTB);
                           ^

OctoWS2811Ext.cpp:157: error: 'DMAMUX_SOURCE_FTM2_CH0' was not declared in this scope
dma2.triggerAtHardwareEvent(DMAMUX_SOURCE_FTM2_CH0);
                           ^

OctoWS2811Ext.cpp:158: error: 'DMAMUX_SOURCE_FTM2_CH1' was not declared in this scope
dma3.triggerAtHardwareEvent(DMAMUX_SOURCE_FTM2_CH1);
                           ^

C:\Users\DANIEL~1\AppData\Local\Temp\arduino_build_114999\sketch\OctoWS2811Ext.cpp: In member function 'void OctoWS2811Ext::show()':
OctoWS2811Ext.cpp:206: error: 'FTM2_C0SC' was not declared in this scope
FTM2_C0SC = 0x28;
^
OctoWS2811Ext.cpp:207: error: 'FTM2_C1SC' was not declared in this scope
FTM2_C1SC = 0x28;
^
OctoWS2811Ext.cpp:208: error: 'FTM2_C0V' was not declared in this scope
uint32_t cv = FTM2_C0V;
             ^

OctoWS2811Ext.cpp:211: error: 'FTM2_CNT' was not declared in this scope
while (FTM2_CNT <= cv) ;
      ^

OctoWS2811Ext.cpp:212: error: 'FTM2_CNT' was not declared in this scope
while (FTM2_CNT > cv) ; // wait for beginning of an 800 kHz cycle
      ^

OctoWS2811Ext.cpp:213: error: 'FTM2_CNT' was not declared in this scope
while (FTM2_CNT < cv) ;
      ^

OctoWS2811Ext.cpp:214: error: 'FTM2_SC' was not declared in this scope
FTM2_SC = 0;             // stop FTM2 timer (hopefully before it rolls over)
^
OctoWS2811Ext.cpp:215: error: 'FTM2_CNT' was not declared in this scope
FTM2_CNT = 0;
^
OctoWS2811Ext.cpp:218: error: 'PORTB_ISFR' was not declared in this scope
PORTB_ISFR = (1<<18);    // clear any prior rising edge
^
OctoWS2811Ext.cpp:229: error: 'FTM_SC_CLKS' was not declared in this scope
FTM2_SC = FTM_SC_CLKS(1) | FTM_SC_PS(0); // restart FTM2 timer
                      ^

OctoWS2811Ext.cpp:229: error: 'FTM_SC_PS' was not declared in this scope
FTM2_SC = FTM_SC_CLKS(1) | FTM_SC_PS(0); // restart FTM2 timer
                                     ^

'GPIOD_PCOR' was not declared in this scope

There is a PR From me for Teensy 4
https://github.com/DirectOutput/TeensyStripController/pull/7

There is a PR From me for Teensy 4
#7

Yes thank you i saw that, and managed to install it on the Teensy4.0
But DOF is reporting error Teensystripcontroller not found.
2020.10.12 00:17:40.475 DirectOutput Logger initialized
2020.10.12 00:17:40.476 DirectOutput Version 0.8.5307.1702 as of 2014.07.13 00:56
2020.10.12 00:17:40.476 Global config loaded from: K:\DIRECTOUTPUT\config\GlobalConfig_B2SServer.xml
2020.10.12 00:17:40.476 Loading Pinball parts
2020.10.12 00:17:40.476 Loading cabinet
2020.10.12 00:17:40.477 Will load cabinet config file: K:\DirectOutput\Config\Cabinet.xml
2020.10.12 00:17:40.543 Warning: Output controller type TeensyStripController not found during deserialization of data.
2020.10.12 00:17:40.573 0 output controller defnitions and 3 toy definitions loaded from cabinet config.
2020.10.12 00:17:40.573 Cabinet config file has AutoConfig feature enabled. Calling AutoConfig.
2020.10.12 00:17:40.574 Cabinet auto configuration started
2020.10.12 00:17:40.648 Cabinet auto configuration finished
2020.10.12 00:17:40.648 Autoconfig complete.
2020.10.12 00:17:40.648 Cabinet config loaded successfully from K:\DirectOutput\Config\Cabinet.xml
2020.10.12 00:17:40.648 Cabinet loaded
2020.10.12 00:17:40.648 Loading table config
2020.10.12 00:17:40.649 Warning: No table config file found. Will try to load config from LedControl file(s).
2020.10.12 00:17:40.649 Will try to load configs from DirectOutput.ini or LedControl.ini file(s) for RomName mm_109c
2020.10.12 00:17:40.651 Loading LedControl file K:\DIRECTOUTPUT\config\directoutputconfig30.ini
2020.10.12 00:17:40.709 EXCEPTION: Table with ShortRomName Galaxie_1971 has already been loaded (Exists more than once in ledcontrol file).
2020.10.12 00:17:40.709 EXCEPTION: Thread:
2020.10.12 00:17:40.711 EXCEPTION: Table with ShortRomName Big_Shot_1974 has already been loaded (Exists more than once in ledcontrol file).
2020.10.12 00:17:40.711 EXCEPTION: Thread:
2020.10.12 00:17:40.744 EXCEPTION: Table with ShortRomName SpotPool_1976 has already been loaded (Exists more than once in ledcontrol file).
2020.10.12 00:17:40.744 EXCEPTION: Thread:
2020.10.12 00:17:40.769 1 directoutputconfig.ini or ledcontrol.ini files loaded.
2020.10.12 00:17:40.770 Config for RomName mm_109c exists in LedControl data. Updating cabinet and config.
2020.10.12 00:17:40.791 Table config loading finished
2020.10.12 00:17:40.791 Pinball parts loaded
2020.10.12 00:17:40.791 Starting processes
2020.10.12 00:17:40.792 Initializing cabinet
2020.10.12 00:17:40.795 Cabinet initialized
2020.10.12 00:17:40.797 Framework initialized.
2020.10.12 00:17:40.797 Have fun! :)

Perhaps the wrong com-Port?
Had also Problems to configure it.
for this i include the „Test-Mode“ over serial.
Open an serial console (putty) and press „t“.
All LEDs Should Then Go on.

ok thanks i will try that.
Did you manage to get the teensy4.0 working with DOF in the end?
Regards.

Yes. It Works for me

ok so i tried T in putty and it works, the board LED flashes quickly, so problem must lie elsewhere.

Yes. The board is ok and working.

Thanks, got it working, seems this Pull Request works great, was just a DOF config issue (my fault)


Failure when building with browserify

When building my project with browserify and babelify, I get the following error:
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module './Generic.js' from '/opt/project/node_modules/xterm/dist'
    at /opt/project/node_modules/resolve/lib/async.js:55:21
    at load (/opt/project/node_modules/resolve/lib/async.js:69:43)
    at onex (/opt/project/node_modules/resolve/lib/async.js:92:31)
    at /opt/project/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:123:15)

This is new from version 2.2.0 and 2.2.1.
Details

OS version: ubuntu-12.04
xterm.js version: 2.2.0 and 2.2.1

Steps to reproduce

Create a project witch require('xterm')
Build this project with browserify and babelify

Are you pointing at out/xterm.js or dist/xterm.js?

This small example should illustrate what I'm doing:
index.js
var Xterm = require('xterm')
console.log(Xterm)

package.json
{
  "name": "xtermex",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "xterm": "^2.2.1"
  },
  "devDependencies": {
    "browserify": "^13.1.1"
  }
}

Running ./node_modules/.bin/browserify index.js will fail with the error mentioned above.

OK, I am not sure what causes this and if it's a bug of xterm.js TBH, but:
It seems that it's source is this line of code in the dist/xterm.js.
It seems like it's trying to access the real ./Generic.js file, which does not exist actually, despite it is being bundled in dist/xterm.js.
I Googled a little bit about issues when requiring standalone bundles (like xterm.js) with browserify but I was not able to find out what might be going wrong.
Any ideas? Maybe an issue at the upstream browserify repo is the best option.

I suspect that the script works fine in the browser?

I'll take a look at this tomorrow (CET).

Yep, script works fine in the browser and with require.js (tested latest release).

Can it be something about double browserifying? I mean wouldn't it make
sense if the entrypoint of the package was src/xterm.js?
On Thu, Dec 8, 2016 at 10:11 PM Paris Kasidiaris<EMAIL_ADDRESS>wrote:

Yep, script works fine in the browser and with require.js (tested latest
release).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sourcelair/xterm.js/issues/397#issuecomment-265856706,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVCyy-MDRqMTHh1-OI1rkcOH6Bg0mAqks5rGHKMgaJpZM4LHe_1
.

@budde377 src/xterm.js depends on TS modules that are build to out and then packaged up with browserify in dist.
I guess browserify doesn't know that we redefined require. Pointing it at out/xterm.js instead would probably work fine as that's the ES5 version before we concat into a single module using browserify. You would need to trigger a build manuall to generate that though (and doesn't work on Windows until https://github.com/sourcelair/xterm.js/issues/359 ).
Perhaps there's an option you can pass to browserify?

Okay, I think that I have a pretty clear image of the problem now. I have in https://github.com/sourcelair/xterm.js/pull/398 proposed that you add a prepublish script which will build the TS and publish it. This will enable usage with require('xterm') of non-browserified code. Please note that I have added a .npmignore file which does not contain the out/ folder. This will overwrite the .gitignore file for npm publish and should be updated with the .gitignore file.


Docker presto extension

https://github.com/onetable-io/onetable/issues/246
What is the purpose of the pull request
Adding Presto to docker demo mix, to extend and showcase the capabilities of OneTable
Brief change log
Added configs required for Presto
Modified docker-compose
Modified the notebook
Verify this pull request
Tested locally

@the-other-tim-brown can you please help in testing this on your x86_64 machine?


Create a apk , PLEASE

Hello sir.
vpn-over-dns is not on playstore, can you create the apk for newer android version please ?

this app is too slow for free internet for dns tunneling, in my case only about 1 kB/s bandwidth, took me a day just to download 100 MB file, better alternative is your freedom vpn, it has dns tunneling too, and speeds as fast as real internet, and updated more frequently, also more options and less bugs


Unable to detect error when extended attribute value is null！

Description
We have a case in bugzilla where several error certificates contain empty cpsurls. We used zlint to check and no errors were reported. Please confirm whether zlint supports this error check. The zlint version used is v3.6.2
bugzilla address: https://bugzilla.mozilla.org/show_bug.cgi?id=1902947
appendix
The relevant error sample book is as follows:
-----BEGIN CERTIFICATE-----
MIIHfDCCBmSgAwIBAgIQdijhjRc6iD2nu+XtGDLX5DANBgkqhkiG9w0BAQsFADBA
MQswCQYDVQQGEwJDTjERMA8GA1UECgwIVW5pVHJ1c3QxHjAcBgNVBAMMFVNIRUNB
IEVWIFNlcnZlciBDQSBHMzAeFw0yNDAzMTgwNTM0MThaFw0yNTAzMTgxNTU5NTla
MIIBcDEdMBsGA1UEDxMUUHJpdmF0ZSBPcmdhbml6YXRpb24xEzARBgsrBgEEAYI3
PAIBAxMCQ04xGjAYBgsrBgEEAYI3PAIBAgwJ5LiK5rW35biCMRowGAYLKwYBBAGC
NzwCAQEMCeS4iua1t+W4gjEbMBkGA1UEBRMSOTEzMTAwMDA2MzEyOTEyODlYMQsw
CQYDVQQGEwJDTjESMBAGA1UECAwJ5LiK5rW35biCMRIwEAYDVQQHDAnkuIrmtbfl
uIIxDzANBgNVBBETBjIwMDA4MDFDMEEGA1UECQw65LiK5rW35biC6Jm55Y+j5Yy6
5Zub5bed5YyX6LevMTcxN+WPtzE4MDjjgIExODA544CBMTgxMOWupDE2MDQGA1UE
Cgwt5LiK5rW35biC5pWw5a2X6K+B5Lmm6K6k6K+B5Lit5b+D5pyJ6ZmQ5YWs5Y+4
MSIwIAYDVQQDExlyc2FldmczLnJldm9rZWQuc2hlY2EuY29tMIIBIjANBgkqhkiG
9w0BAQEFAAOCAQ8AMIIBCgKCAQEAo5512vvetdN4Yp0F5fuYit5yzmwwR9yHQNpt
Uu849hRMPfDcFtLTfXPwFHVTvFxPRiGmGIDoFrLnJ1A35Grt98B+avSk3tJFb6jz
tP/d2VboRpUgkicaU5Xqpg36rL0M59NGhqKkNu2wsc9+1B7dSqd3EQR2ufD0usPA
t7OJ1DXiJR+k8VpHBwVgm0y7shQ3JNOqjdT0jyz4bAcClJFQLWptvVPJbC1I7AZY
7//OBTuGAMD18Vi3fcH/stGitL/i0nMB4WQhpdi4XFIbWafviL1PPQsKi3RYpU72
n6a7YXCumK6x9odqt9pmGGwhUc96KfeZiTLWveI7OCEkJZonbwIDAQABo4IDPjCC
AzowHwYDVR0jBBgwFoAUVOly+3hmn+XL8zuPmEZVU3OcC4QwHQYDVR0OBBYEFBzW
siu+4iX0YZa4hQQzXBDENlaxMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggr
BgEFBQcDAQYIKwYBBQUHAwIwXwYDVR0gBFgwVjA7BgkqgRyG7zoBAQMwLjAsBggr
BgEFBQcCARYgaHR0cHM6Ly93d3cuc2hlY2EuY29tL3JlcG9zaXRvcnkwFwYFZ4EM
AQEwDjAMBggrBgEFBQcCARYAMCQGA1UdEQQdMBuCGXJzYWV2ZzMucmV2b2tlZC5z
aGVjYS5jb20wDAYDVR0TAQH/BAIwADA4BgNVHR8EMTAvMC2gK6AphidodHRwOi8v
Y3JsLmdsb2JhbC5zaGVjYS5jb20vZXZzY2FnMy5jcmwwdwYIKwYBBQUHAQEEazBp
MDAGCCsGAQUFBzABhiRodHRwOi8vb2NzcC5nbG9iYWwuc2hlY2EuY29tL2V2c2Nh
ZzMwNQYIKwYBBQUHMAKGKWh0dHA6Ly9jZXJ0cy5nbG9iYWwuc2hlY2EuY29tL2V2
c2NhZzMuY2VyMIIBfwYKKwYBBAHWeQIEAgSCAW8EggFrAWkAdgDM+w9qhXEJZf6V
m1PO6bJ8IumFXA2XjbapflTA/kwNsAAAAY5QDbXBAAAEAwBHMEUCIQDvhPCwmHSC
R9NTYozUltUrpCrVDhIxGPm1zIHEiI5jbwIgUaSGy3b6TJQjBJ4i4bDeJlktk5am
UXjsFM0s4QqtITEAdgBOdaMnXJoQwzhbbNTfP1LrHfDgjhuNacCx+mSxYpo53wAA
AY5QDbXbAAAEAwBHMEUCIQC6ZOWdT938QKn5Yno620rj1asoyEaJuFw4PATORIjA
MQIgWmyLdTuuk8mIL0mSvkcfGIV0RROZBJ1KUIYTa8a6KHcAdwDPEVbu1S58r/OH
W9lpLpvpGnFnSrAX7KwB0lt3zsw7CAAAAY5QDbljAAAEAwBIMEYCIQDFPZECINh3
XHc/p0YSA2uXpVimDazVnDafXkB2nI8JYAIhAI0Wl+DkwJveSNrhX9GUHa54AxUd
fi12ms/GutfBow5DMA0GCSqGSIb3DQEBCwUAA4IBAQAxHBMMywdG+y9gECt7Fr4n
CPZsHFMfKgt1zzrCZHdUU1VKGMxLPfuJN9eRqOmnD5HCqFRCZHRl2nBIeB7tEdN+
3P4cHtIJK14hHlamYOig/iqLMY2ItkiT5XSgVLpyhGaZNmvgXYoD61X0IP1ueMnR
w2ivLGwrHtwbRGb0BD6zQN4uBfMPwn3J4TGaCWtG8kulDXJUyKfO1HRJD72tIzPn
zE9CRRRpZca27y2V8rSa7K+F5eF4N5ugUybkwrgq7WI/jvTyFE2XNtU57dI16hQ7
qtDi/RcbzJWXzstfDmk5y+KUvfe9bMsKtcBtRU+R5nak3d5EmMEdTl+5tzfyP0Ul
-----END CERTIFICATE-----

Hi @SHECA-Alvin! This issue feels like a great opportunity where you could help contribute to ZLint. ZLint is a community project and as it stands, your request comes across as directly offloading the work needed onto other CAs and contributors rather than making a good faith effort to understand what happened. I would encourage you to investigate whether an existing lint should have caught this. If not, can you suggest a lint that would help catch this in the future?

Hi @SHECA-Alvin! This issue feels like a great opportunity where you could help contribute to ZLint. ZLint is a community project and as it stands, your request comes across as directly offloading the work needed onto other CAs and contributors rather than making a good faith effort to understand what happened. I would encourage you to investigate whether an existing lint should have caught this. If not, can you suggest a lint that would help catch this in the future?

Thank you for your reply. I will listen to your advice. Please allow me to do some research on zlint's code first. I am not very good at projects developed in golang language.


build_app parameter use_system_scm is ignored

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

I'm really happy that you've added use_system_scm property to the scan and gym commands in previous version!
But it seems like it's not working correctly since the flag is not added to the xcodebuild command. There should be -scmProvider system flag added there to force the xcode to use the system git configuration. It's missing in the log, which results in the build error. See the log below:
[17:56:31]: -----------------------
[17:56:31]: --- Step: build_app ---
[17:56:31]: -----------------------
[17:56:31]: Resolving Swift Package Manager dependencies...
[17:56:31]: $ xcodebuild -resolvePackageDependencies -workspace Example.xcworkspace -scheme Example -configuration Release
[17:56:32]: ▸ Command line invocation:
[17:56:32]: ▸     /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -workspace "Example.xcworkspace" -scheme "Example" -configuration Release
[17:56:34]: ▸ Resolve Package Graph
[17:56:34]: ▸ Fetching git@github.com:private/repo.git
[17:56:36]: ▸ xcodebuild: error: Could not resolve package dependencies:
[17:56:36]: ▸   Authentication failed because the credentials were rejected
Command line invocation:
    /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -workspace "Example.xcworkspace" -scheme "Example" -configuration Release

Resolve Package Graph

Fetching git@github.com:private/repo.git

xcodebuild: error: Could not resolve package dependencies:
  Authentication failed because the credentials were rejected

Running xcodebuild -resolvePackageDependencies -workspace Example.xcworkspace -scheme Example -configuration Release -scmProvider system forces the xcodebuild to use the system git configuration and resolves the packages correctly.
I've looked around and could not see any possible workarounds to resolve this issue.
 Nice spotting.
Could you post here a full log using --verbose option? Also providing details of the command you executed, as well as your configuration files (e.g. Fastfile, Deliverfile, etc) would help 🙏

I think I'm running into this issue as well, but for the "scan" action. The use_system_scm parameter seems to be completely ignored.

I'm running into this issue as well. It seems this option needs to be added here as well: https://github.com/fastlane/fastlane/blob/48151291f2c4949c3b1b9919ba2cc81a7cc33293/fastlane_core/lib/fastlane_core/project.rb#L317

Hey guys!
@wvteijlingen thanks for providing the info you found out, it definitely sped up the resolution of the problem 🎉
I just opened a PR fixing this issue: https://github.com/fastlane/fastlane/pull/17832

Great, thank you @rogerluan! Hope we can merge and release this fix soon.

@rogerluan thank you for the fix!


Refinement code & Update

Bugs to be expected! (Not really, but you're all warned)
Things to put in/code: Staff upgrades, Deathly Dagger, Parthia, bunny weapons, armor effective weapons (just to put the special tag in) and all the special ones that aren't in refinements.json yet.
And now, off to the bed!

Going to wait for the effects and a bit more testing before I merge this. The other changes you've made recently are live though, and seem to be working.
Cheers

@winsomniak updated... The fixes are for the special cooldown part and other little stuff...
BTW, Valentine Lyn is still missing the portrait!

Portrait is there, was just the filename. Anything with 's removes the apostrophe, not both the apostrophe and the s


Adding TAPEX to HuggingFace Transformers

Hi!
First of all, congratulations on the great paper and results! If you need any help regarding converting the models to the HuggingFace API, let me know. My very first contribution to HuggingFace Transformers was actually TAPAS, the table question answering model from Google. We also create a subsequent table-question answering task on the hub, as well as an inference widget which let's users directly try out TAPAS in the browser.
We could do the same for TAPEX! TAPEX also looks way simpler as it's a generative model. The only thing required would be to write a conversion script (which I can help you with).
Also, are you interested in joining the Microsoft organization on the hub?
Btw, the README is also very comprehensive and well written. Wish more authors did that ;)
Kind regards,
Niels
ML Engineer @ HuggingFace

Hi,
So I've managed to convert the TAPEX-base checkpoint to its HuggingFace counterpart (in a BartForConditionalGeneration model). However, can you tell me a bit more about the BPE vocabulary? I see that this checkpoint has a vocab size of 51201.
Where can I find this vocabulary file? Is the same vocabulary used during pre-training and fine-tuning?
Similar to TAPAS, I'm considering making a TapexTokenizer that has the following API:
from transformers import TapexTokenizer, BartForConditionalGeneration
import pandas as pd

model_name = 'microsoft/tapex-base'
tokenizer = TapexTokenizer.from_pretrained(model_name)
model = BartForConditionalGeneration.from_pretrained(model_name)

data = {'Actors': ["Brad Pitt", "Leonardo Di Caprio", "George Clooney"], 'Number of movies': ["87", "53", "69"]}
table = pd.DataFrame.from_dict(data)
queries = ["What is the name of the first actor?", "How many movies has George Clooney played in?", "What is the total number of movies?"]
inputs = tokenizer(table=table, queries=queries, padding='max_length', return_tensors='pt')

# forward pass
outputs = model(**inputs)
logits = outputs.logits

@NielsRogge Hi Niels! It looks that you have found the BPE files. Right they follow the same procedure with BART-base.
BTW, we have an initial plan to release T5 based models (or more models) under the pre-training procedure of TAPEX to faciliate the community. What model names do you think are appropriate for the current TAPEX for future potential compatibility? For example, microsoft/tapex-bart-base or microsoft/tapex-base?
Thanks again!

Oh great to hear!
Maybe it makes sense to include the model architecture in the name of each checkpoint, so microsoft/tapex-bart-base (and then microsoft/tapex-t5-base) sounds good.

@NielsRogge I agree with that. Thanks for your quick reply! If there is any other thing I can help, please directly ping me or email me (qian.liu@buaa.edu.cn). Any discussion about TAPEX itself is also warmly welcome! In the next few months, I will be relatively free lol.

Do you have time to add this model to the library?
The modeling part is done, as the model is just a BART model. However, it would be great if you could implement the TapexTokenizer. The conversion notebook can be found here.
I can help you in the process. It will also make you familiar with HuggingFace Transformers (it's like a behind-the-scenes of the library).

@NielsRogge Sure! I'm interested to do that (I'm a earlier fans of huggingface transformers lol). I will add it to the library following the official guideline, which may cost nearly 1 week. I will be back here if I meet anything I cannot deal with, or I think the pull request needs reviewing. Thanks in advance, Niels!

Ok great, let me set up a Slack channel with your email address such that we can communicate over there rather than here.
Is that ok for you?

@NielsRogge It sounds good for me!

@SivilTaram Hi, I just wanted to check in on the status of adding these models to Huggingface. Thank you!

@vnik18 Hi! You can see the updated README to preview the fine-tuning script. And tapex may be merged into Transformers in the near future!

@SivilTaram Thank you for letting me know!

TAPEX is merged into huggingface now. Now you can view https://github.com/huggingface/transformers/tree/main/examples/research_projects/tapex to have a try! Enjoy it ☕ .


[space-station-os.github.io] Prepare for prospective demos

User Story:

By reading prospective demos, the prospective contributers can imagine what to contribute in demos. The description should be of appropriate depth
Found in space-station-os.github.io.

Acceptance Criteria:

6 (TBD) prospective demos are shared on the web.
Feedback for depth of description is received.

https://space-station-os.github.io/demos.html

Restructured GitHub project to accept demos. Done.


Fix typos

offical -> official

@eltociear, I'd also suggest changing infomation -> information @ scene/dataset_readers.py ln#236

thank you. we have fixed it in the latest version.


Compile Issue For 0.5.2

Describe your problem here.
When i try to compile the game in versions 0.5.1 and above, it says its creating the applicationmain.exe but then nothing happens, im wondering if someone can help? I know its only 0.5.1 and above because i downloaded the version 0.4.9 and it was just fine.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I did not edit anything

Did you check the export folder?
Did you compile correctly?
Check your source code.

The game could be crashed.

Turns out i have visual studio code 2021 and i downgraded to 2019 and it worked


Added ARN of VPC in module output

I need in my policy generator the arn of vpc so I would like to include this

Thanks!
v1.63.0 has been released.


[move-prover] Clean up of prelude.bpl

Clean up of prelude.bpl:

fixed a couple of typos in comments
Removed redundant ValueArray function (AddalueArray same as ExtendValueArray)
Many instructions were using "assume" for the types of their input parameters - these should be enforced by requires - fixed this
Changing the above uncovered a couple of issues

Unimplemented instructions lose type information - fixed for now by adding a dummy call that preserves typing information
Vector function models that were using loops broke requirements because of loop havocing - I commented these out for now

:umbrella: The latest upstream changes (presumably 02bd6b0192b834d6e9778cc82d30c2b44e3ba263) made this pull request unmergeable. Please resolve the merge conflicts.

My concern is that this breaks any code with a loop, even if it does not contain any explicit specifications.
That might be true in practice because of the requires that the sender address have an account, but, obviously, we had some test cases with loops that went through before.
How can we tolerate loops? Will the problem disappear with Shaz's new memory model? Or can we add loop invariants that remember all the types?

We don't currently handle loops correctly.  Or more precisely, we can parse functions with loops, but we can't prove anything about them because a loop in Boogie havocs everything.  We probably need to have a careful discussion about what to do for loops.  If we just want them to parse and generate Boogie code (and not prove anything about that code) like it was before, all you need to do is add loop invariants for the types.  This seems like the minimum we would have to do anyway to avoid spurious counterexample values.

@bors r+

:pushpin: Commit eb8cc99 has been approved by cbarrettfb

:hourglass: Testing commit eb8cc99e586d4ff7e1cc71d7520734091db381f7 with merge 0d71cec16a57d39dce7e344d91702c22e016ffcd...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: cbarrettfb
Pushing 0d71cec16a57d39dce7e344d91702c22e016ffcd to master...

Oops! At least I submitted my comments one minute earlier than this was merged.


feat: Update title from Langflow to Boostle, update text from Langflo…

…w to Boostle in MainPage components, update text from Langflow to Boostle in loginPage and update text from Langflow to Boostle in signUpPage

Apologies.


Fix Windows cryllic character from ENV issues

The underlying problem is that ENV variables with cryllic
characters come in as ASCII-8BIT rather than utf-8

https://bugs.ruby-lang.org/issues/9715

@dickeyxxx please review

lgtm
actually it doesn't, it's really ugly, but it should get the job done


Ability to use any DNS server.

Feature Request:
Ability to use any dns server. This would give the ability to use not only public dns servers; but, internal private dns servers as well.

Hi, thank you for your contribution.
This is simple wrapper to do DoH (DNS over HTTPS) lookups, so private DNS lookups can not be done in this solution. For further information please take a look at markup file. I guess there is not any solution to do this in dart (package or library) at the moment, but it can be ideal for you to search the correct answer in the community. In the future, private dns lookups can be implemented, but it is not necessary for me to add this functionality to the package for now.


Replace expired vbox additions signing cert

The certificate are already shipped with the VBoxGuestAdditions.iso:
The oracle-cert.cer can be removed and the vs-guest-tools.bat can be modified with the following definition for the :virtualbox label.
:virtualbox
move /Y C:\Users\vagrant\VBoxGuestAdditions.iso C:\Windows\Temp
cmd /c ""C:\Program Files\7-Zip\7z.exe" x C:\Windows\Temp\VBoxGuestAdditions.iso -oC:\Windows\Temp\virtualbox"
cmd /c C:\Windows\Temp\virtualbox\cert\VBoxCertUtil add-trusted-publisher C:\Windows\Temp\virtualbox\cert\vbox-sha1.cer --root C:\Windows\Temp\virtualbox\cert\vbox-sha1.cer
cmd /c C:\Windows\Temp\virtualbox\cert\VBoxCertUtil add-trusted-publisher C:\Windows\Temp\virtualbox\cert\vbox-sha256.cer --root C:\Windows\Temp\virtualbox\cert\vbox-sha256.cer
cmd /c C:\Windows\Temp\virtualbox\cert\VBoxCertUtil add-trusted-publisher C:\Windows\Temp\virtualbox\cert\vbox-sha256-r3.cer --root C:\Windows\Temp\virtualbox\cert\vbox-sha256-r3.cer
cmd /c C:\Windows\Temp\virtualbox\VBoxWindowsAdditions.exe /S

I can confirm the fix works. It would be good to merge it.

Just ran into this problem as well, merging would be great.

The PR #257 looks better as we do not have to update the certs every x years in this repo. I‘ll try to find some time to test in the nect days and merge a fix.

Thanks. Fixed with #247 so we don't have to update the cert in this repo


Make SIMPLE standard archetype consistent with doc-string comments.

FIxed with PR#63.

FIxed with PR#63.


function() {return this this returns transaction address ?

// contract/ThisTest.sol
contract ThisTest {
function getContractAddress() constant returns (address){
return this;
}
function () constant returns (address){
return this;
}
}
// test/ThisTest.js
contract('ThisTest', function(accounts) {
var eth = web3.eth;
var minerAddress = eth.accounts[0];
var sellerAddress = eth.accounts[1];
var buyerAddress = eth.accounts[2];
var users = [minerAddress, sellerAddress, buyerAddress];
var getBalance = Promise.promisify(eth.getBalance);
var sendTransaction = Promise.promisify(eth.sendTransaction);
it(" 'this' should return contract address ", function(done) {
    var thisTest = ThisTest.at(ThisTest.deployed_address);
    sendTransaction({from:buyerAddress, to: thisTest.address, value: 1 * Math.pow(10, 18)}).then(function(test){
        console.log("ThisTest contract address is " + thisTest.deployed_address);
        console.log("ThisTest contract address is " + thisTest.address);
        console.log("Solidity function() return address is " + test);
        //assert.equal(thisTest.address, test, "contract address should be matched, but not matched!");
    }).then(function(){
        thisTest.getContractAddress.call().then(function(test2){
            console.log("ThisTest contract address is " + thisTest.address);
            console.log("getContractAddress return address is " + test2);
            //assert.equal(thisTest.address, test2, "contract address should be matched, but not matched!");
            done()
        }).catch(done)
    }).catch(done)
});

});
// then
$ truffle test test/ThisTest.js
// return
$ truffle test test/ThisTest.js
Using environment test.
Compiling contracts...
Contract: ThisTest
ThisTest contract address is 0x9de4202e79ac256507c23f25d5ec9098743297f9
ThisTest contract address is 0x9de4202e79ac256507c23f25d5ec9098743297f9
Solidity function() return address is 0x0f401f0f3e49cb7217aa4262121bd2024bc637b8353556c7c521eb2decf7bf87
ThisTest contract address is 0x9de4202e79ac256507c23f25d5ec9098743297f9
getContractAddress return address is 0x9de4202e79ac256507c23f25d5ec9098743297f9
✓  'this' should return contract address
1 passing (7s)

This looks like a duplicate of #121. Closing.


Define Types Once

Hi all,
it might be nice if we had a small script that defined all of our types, which we could then import as necessary into our other files. This would reduce the amount of boilerplate at the top of many files which have things like . Here is an example which I have not tested:
__all__ = [OpticalLayer, ApertureLayer, WavefrontLayer, Array]
Array = np.ndarray
WavefrontLayer = dLux.wavefronts.WavefrontLayer
ApertureLayer = dLux.apertures.ApertureLayer
OpticalLayer = dLux.optics.OpticalLayer

What are your thoughts?

Hmm I see the point but I think this hurts us on the readability front. Having delved deep into the source code of quite a few different packages, being more explicit rather than clever has always been a top priority. Given that this is only a few lines of code and they aren't repeated within any of the scripts, then I think they should be done explicitly within that script.

I also have never been able to get the OpticalLayer = dLux.optics.OpticalLayer to work without throwing an error on importiirc).

I think keeping Layer objects explicitly defined is not a bad thing. For things like Array I'm less sure, and as Louis said the repetition is once as part of the structure of a file.

Because type annotations are optional in python the exact implementation of the type does not matter. We have already encountered problems across the different files with how types have been handled. For example, changing from Array = TypeVar("Array") to Array = np.ndarray. Other examples include the Wavefront type, which is included in most __call__ methods. It is just more work to change this across multiple files (anti-DRY).
Since, the package is nearly stable I don't think it will matter too much anyway :shrug:, so I will close the issue.


preparing for pypi release

add Python 3.6 to setup.py

removed Python 2 from setup.py

@sjsrey @ljwolf please review for merge when you have time.

@jGaboardi want to change this to look like spreg?
The on_failure and on_success should be change, and on_change is deleted.


Hello. Why there is no .documents and .library folder for iOS builds?

It took me 20 minutes of searching through the API know about that!
I don't know why this is not supported!

Same here, .documents and .library are the fundamental needs.

Hi @JohnSundell can you please add this into the library for making  .documents and .library available for iOS.
/// Extension below make the "library" and "documents" folder available for the iOS
#if os(iOS)
public extension Folder {
    /// The current user's Documents folder
    static var documents: Folder? {
        do{
            let url = try FileManager.default.url(
                for: .documentDirectory,
                in: .userDomainMask,
                appropriateFor: nil,
                create: true
            )
            return try? Folder(path: url.relativePath)
        }catch{
            return nil
        }
    }

    /// The current user's Library folder
    static var library: Folder? {
        do{
            let url = try FileManager.default.url(
                for: .libraryDirectory,
                in: .userDomainMask,
                appropriateFor: nil,
                create: true
            )
            return try? Folder(path: url.relativePath)
        }catch{
            return nil
        }
    }
}
#endif

Fixed here: https://github.com/JohnSundell/Files/pull/122


SlideImage - Title field

Keep Name required, use as internal reference. Name would not show in template
Add Title to be optional, used in templates if exists.

closed via #38


Hide Purpur's configurable seeds in timings reports

This adds Purpur's seed settings to Aikar's set of values to be hidden from timings. Seems to make sense not to expose these as all other generator seeds are hidden, although end spikes aren't a concern there is a possibility knowing Purpur's dungeon seed could be abused from what I can tell.

Thank you ^_^
Manually merged with changes https://github.com/pl3xgaming/Purpur/commit/d478261f8e15f24edcb4459b72571046faaf0926


Enhance Prowler Detection for Overly Permissive Policies in Critical Services

New feature motivation

While experimenting with Prowler, I provisioned the following Policy Document, which was later attached to a Role:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Statement01",
            "Effect": "Allow",
            "Action": [
                "s3:*",
                "ec2:*",
                "ecr:*",
                "rds:*",
                "dynamodb:*",
                "route53:*",
                "sns:*",
                "sqs:*"
            ],
            "Resource": "*"
        }
    ]
}

After running prowler aws --excluded-services <EVERY_SERVICE_BUT_IAM>, Prowler only detected ec2:* and dynamodb:* as problematic.

This policy is arguably close to full Administrative Access, considering that an attacker with access to this Policy would have control over critical services, potentially compromising the entire AWS Account. For example, the s3:* action could be used to exfiltrate data, and route53:* could be employed to manipulate multiple DNS records that may be mission-critical. I'd like to emphasize that none of these actions adhere to the least privilege principle, which is something a blue team should be aware of and address promptly.
Solution Proposed
I'd like to propose the addition of the following services to the Prowler IAM Checks:
["s3:*", "ec2:*", "ecr:*", "rds:*", "dynamodb:*", "route53:*", "sns:*", "sqs:*", "*"]

Describe alternatives you've considered
As an alternative, it would be possible to fork Prowler's repo and provision a local instance of it, adding more actions and checks but this would make us fall behind on updates and new cool features that the team might release.
Additional context
No response

By the way, I think the solution to this is a simple add to this variable. I tried to contribute with a PR but got caught with a deny. 😅
remote: Permission to prowler-cloud/prowler.git denied to exiett.
fatal: unable to access 'https://github.com/prowler-cloud/prowler.git/': The requested URL returned error: 403

Hi @exiett, you're right and currently we are not checking it but I don't think it makes sense to include that permissions in the iam_policy_allows_privilege_escalation check.
We have two similar checks to review full access to CloudTrail and KMS:

iam_policy_no_full_access_to_cloudtrail
iam_policy_no_full_access_to_kms

Maybe makes more sense to create new checks to cover the most important AWS services.
Regarding your permissions issue, did you create a new fork of the Prowler repository? To contribute you should fork the repository and then create a new Pull Request.
Thanks for using Prowler 🚀

Hi @exiett, we have fixed some issues in the iam_policy_allows_privilege_escalation check at this branch PRWLR-1969-aws-iam-policy-allows-privilege-escalation-check-are-not-accurate-2220.
What were the permissions you want to include there?
Thanks!

Hi @exiett we are closing this issue since the iam_policy_allows_privilege_escalation check now detects a policy like the following as a FAIL since allows to privilege escalation.
{
  "Version": "2012-10-17",
  "Statement": [
      {
        "Sid": "Statement01",
        "Effect": "Allow",
        "Action": [
            "s3:*",
            "ec2:*",
            "ecr:*",
            "iam:*",
            "rds:*",
            "dynamodb:*",
            "route53:*",
            "sns:*",
            "sqs:*",
        ],
        "Resource": "*",
    }
  ],
}

Please feel free to reopen the issue if you notice some issue or unexpected behaviour.
Thanks for using Prowler 🚀


Improving database logging by adding duration, referrer and post data

@bkyryliuk @ascott @vera-liu

Not sure if this is the right forum for suggesting this, but would it be better to allow users to log activity to Google Analytics, Snowplow Analytics or Google tag manager?
Most webmasters are very familiar with monitoring site performance and activity in there. Would reduce the writes on the database too...
If people need more detailed logs they could store them to disk via Nginx.
Thoughts?

@kingo55 sounds like they are 2 different kinds of logs. This table is used in the superset internally to provide some insights for the creators:

views per dashboards
views per slice etc
And it can be used to personalize user experience
Having all this data outside the service will make things a bit more complicated.

Providing a way to load the data to external services - is pretty good idea, however we do not have such a use case internally

LGTM once build is green

@kingo55 I'm in sync with @bkyryliuk on this. Would happily review a PR that added a hook for Google Analytics and the likes.
I've also been meaning to ship our internal "Superset Usage" dashboard along with the codebase examples so that people can analyze how Superset is doing in their environment.


Streaming and file type issues in data & results

via @kessler-frost :
we may want to change
https://github.com/AgnostiqHQ/covalent/pull/215/files#diff-d5a1b52ef809a88edbb01367cf4a161ddc0b9ce35c885981d8a8363cb0588949R182
to
https://github.com/AgnostiqHQ/covalent/blob/refactor-intermediate/refactor/results/app/api/api_v0/endpoints/workflow.py#L190
this comment from @cjao :
https://github.com/AgnostiqHQ/covalent/pull/215/files#r837530992

We are going to upload bytes and download bytes
We need to change the SDK wrapper to handle this change

There are two sub-issues:

To benefit from stream=True and StreamingResponse, one needs to access the response body through iter_content() or iter_lines(). Currently we load the entire response body into memory using the content property, so the stream=True argument confers no advantages.

Handle the actual StreamingResponse.

That is true, but that gives us the option to handle loading into memory on the receiving end. So, if we're using things internally between microservices, we anyway will want to load the whole object into memory as we will be editing it in most cases. But when the user does the download, we can write the download wrapper in the sdk using iter_lines() or iter_content() so later on when we do support having > memory files we can provide the user the ability to download them.


onCloseCodeCallback not getting called when close code is absent

As per https://tools.ietf.org/html/rfc6455 section 5.5.1 closing code may be absent. In particular, Safari/Chrome/Firefox seem not to send it thus onCloseCodeCallback is not getting called at all:
        if let closeCode = data.readInteger(as: UInt16.self)
            .map(Int.init)
            .flatMap(WebSocketErrorCode.init(codeNumber:))
        {
            webSocket.onCloseCodeCallback(closeCode)
        }

It would be nice to have that callback called even if there's no code so app could stop sending data to client at this point without waiting for onClose {}.
Also there's reason field which the lib does not currently fetch which also belongs to that callback imo.
I propose renaming it to onClosingHandshakeBegin or onCloseFrameReceived with params (code: WebSocketErrorCode?, reason: String?). If it sounds good, I can make a PR.

@zmeyc I believe that onClose.always will be helpfull :)
webSocket.onClose.always {
// handle close
}

@albertaleksieiev Ideally the app should stop sending data to client on the start of closing handshake (when close frame is received) without waiting for onClose and it's currently undetectable in some cases as the callback is not getting called.


Ft custom filtering and search 161255256

What does this PR do?

Add custom filtering to articles

Description of Task to be completed?

Allow filtering by tags
Allow filtering by articles

How should this be manually tested?

Access the endpoint api/articles/
Add ?tag=sampletag to filter with tags
Add ?author=sampleusername to filter by author

What are the relevant pivotal tracker stories?
Add search and cutom filtering
Screenshots (if appropriate)
Filter by author

Filter by tag

Pull Request Test Coverage Report for Build 421

14 of 14 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 91.504%

Totals

Change from base Build 420:
0.06%

Covered Lines:
1971

Relevant Lines:
2154

💛  - Coveralls


Handle set_weights() for dtype string

For further details see issue: https://github.com/tensorflow/tensorflow/issues/46553

Perhaps a more elegant implementation would be preferable.

Perhaps a more elegant implementation would be preferable.

@mihaimaruseac Should I change anything due to the failed check: import/copybara?

@mihaimaruseac Should I change anything due to the failed check: import/copybara?

@MansBermellLeo no, copybara is the service that imports the PR and then merges once the internal change is approved and lands.

@MansBermellLeo no, copybara is the service that imports the PR and then merges once the internal change is approved and lands.

Was it reverted?

Was it reverted?

No, it wasn't reverted. Just needs tests added in a separate PR.

No, it wasn't reverted. Just needs tests added in a separate PR.


2020.1_b18: Errors appearing in Homeassistant log

This may just be a cosmetic issue but wanted to report it just incase
Hive integration is working correctly, there are no debug options enabled but Home Assistant Log showing following errors:
2020-11-09 21:05:28 ERROR (MainThread) [pyhiveapi.custom_logging] ERROR - No data found for device - Ground Floor
2020-11-09 21:05:30 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.boost_hot_water fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/config/custom_components/hive/switch.py", line 99, in async_update
    if self.device["hive_type"] == "activeplug":
KeyError: 'hive_type'
2020-11-09 21:06:00 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.boost_hot_water fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/config/custom_components/hive/switch.py", line 99, in async_update
    if self.device["hive_type"] == "activeplug":
KeyError: 'hive_type'

Fixed in Beta 19

Reopened.
Sorry, my mistake: still present in b19:
KeyError: 'hive_type'
2020-11-15 15:51:30 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.boost_hot_water fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/config/custom_components/hive/switch.py", line 93, in async_update
    if self.device["hive_type"] == "activeplug":
KeyError: 'hive_type'
2020-11-15 15:51:58 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.boost_hot_water fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/config/custom_components/hive/switch.py", line 93, in async_update
    if self.device["hive_type"] == "activeplug":
KeyError: 'hive_type'
2020-11-15 15:52:30 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.boost_hot_water fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 278, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 474, in async_device_update
    raise exc
  File "/config/custom_components/hive/switch.py", line 93, in async_update
    if self.device["hive_type"] == "activeplug":
KeyError: 'hive_type'

Getting same issue in B19, (1000 log entries in 2 hours)

b20 seems to have sorted this for me

I haven’t done anything to fix the yet so that’s surprising?

Mmm, yes sure is, updated about 6 hours ago and nothing in logs

Yeah looks fixed here too in beta 21 (may have been fixed in b20)
Issue closed


Implementation problem of the GAT multi-head

🐛 Bug

Based on the original "Graph Attention Network" paper, The multi-head attention means calculate different attention coefficients for the same neighborhood. However, in the current implementation,
it just reshapes the tensor, e.g.  x.view(-1, self.heads, self.out_channels). It does not duplicate the node features by the number of head. I think the expected behavior should transform the size of input from the size (N, F) -> (N, H, F), which N is the number of nodes, H is the number of head, F is the number of features.

I do not see anything wrong with that. Note that before we reshape x, we transform it using a weight matrix, so we get differently features for each head. This is exactly what the GAT paper is doing, see Eq. 5.

Thanks. I see the transformation of the weight matrix now.


Commit the added comment on Application.java

This is a new pull request for the change of Application.java

That is a pull request

To merge the pull request

Spam


Builds should be reproducible

Building a specific revision should be reproducible.
Currently, the multi-release jar created by the build contains the timestamps of the compiled class files. And therefore each time the multi-release jar is built, it has different content.
See
https://maven.apache.org/guides/mini/guide-reproducible-builds.html

Fixed in 2eea281f56110be6a69b250bbe5f7dab8264ddf6