Roadmap for Timber 2.0

This is an overview issue for the release of version 2.0 of Timber. If you find questions about the release of Timber 2.0, guide them here.
Roadmap
The next steps for a 2.0 release are:

[x] Release second beta 2.0.0-beta.2 by the end of this week
[x] Work through open pull requests and issues. Triage issues and pull requests that are not critical for the 2.0 release.
[x] First release candidate 2.0.0-rc.1 by June/July 2023
[ ] Release Timber 2.0 one to two months after developers could test out the release candidate.

The past has shown us that it’s difficult to predict an exact ETA. And with our limited resources, we don’t want to make promises we can’t keep. But let’s work towards a 2.0 release by being strict about what we really need for a 2.0 release and what we can postpone for later.
Help is welcome from everyone, also developers who are not maintainers. If you can provide insights, spot issues in the pull requests and comment on these, you’ll help us move the project forward.
Pull requests
The following pull requests need to be reviewed and resolved.

[x] https://github.com/timber/timber/pull/2669
[x] https://github.com/timber/timber/pull/2730
[x] https://github.com/timber/timber/pull/2660
[x] https://github.com/timber/timber/pull/2667
[x] https://github.com/timber/timber/pull/2668
[x] https://github.com/timber/timber/pull/2749
[x] https://github.com/timber/timber/pull/2750
[x] https://github.com/timber/timber/pull/2751
[x] https://github.com/timber/timber/pull/2700
[x] #2753

For each of these pull requests we should decide whether we can solve them in the future or whether we really need to solve them for a first 2.0 release. By "future", we mean that we can decide whether:

The issue can be resolved in a minor version of Timber 2.x, so 2.1 or 2.2, etc.
The issue will have to wait for Timber 3.x.

Postponed issues and pull requests

https://github.com/timber/timber/pull/2733 (postponed to 2.x Future)
https://github.com/timber/timber/issues/2453 (postponed to 2.x Future)
https://github.com/timber/timber/pull/2725 (postponed to 2.x Future)
https://github.com/timber/timber/issues/2762 (postponed to 2.x Future)

Outstanding issues

[x] https://github.com/timber/timber/issues/1784 – Is possibly resolved already and can be closed.
[x] https://github.com/timber/timber/issues/2766
[x] https://github.com/timber/timber/issues/2771
[x] https://github.com/timber/timber/issues/2745

Issues with patches
This issues have patches and will be resolved when their corresponding pull requests are resolved.

[x] https://github.com/timber/timber/issues/2626
[x] https://github.com/timber/timber/issues/2772
[x] https://github.com/timber/timber/issues/2444
[x] https://github.com/timber/timber/issues/2737
[x] https://github.com/timber/timber/issues/2278

I'm also adding links errors in docs, at least for 2.0:

[ ] https://github.com/timber/timber/issues/2742

PR for #2742 in https://github.com/timber/timber/pull/2743

Amazing, this is exciting stuff. It's really important to highlight: what we really need for a 2.0 release and what we can postpone for later. This provides a clear and focused mapping to get us the rest of the way there!

Update:

The second beta is released: https://github.com/timber/timber/releases/tag/2.0.0-beta.2.
A new build of the docs is published on https://timber.github.io/docs/.

Excited for RC release

We’re glad that we could finish the first steps towards the final release as planned.

The first release candidate of Timber 2.0 is out: https://github.com/timber/timber/releases/tag/2.0.0-rc.1! 🥳
Docs are updated with the latest changes on timber.github.io/docs.

This is such a massive step forward! Thanks a lot everyone for working so hard on this

https://timber.github.io/docs/v2/upgrade-guides/2.0/

Love Timber! It'd be great if you would reconsider offering a plugin for the new version.

That's great to know! thanks for your feedback :)

Updated my parent/child theme framework as well without any issues. I am going to test this in some upcoming projects to see if I run into any other issue.

I updated my theme today with 2.0.0-rc.1. Everything went quite smooth, although it took me some time to understand the new handling of ACF repeaters, relationships and flexible content field. I have a quite elaborate ACF structure of layouts and field mixed with CPTs etc. Esp. the .image property of what actually I was sure is already a picture was tricky... But after a bit of thinking, it all makes sense to me. Thanks for the great work!
Just one annoying observation: During debugging, I recognized a warning in my logs:
PHP Notice:  [ Timber ] {{ site.meta() }} is deprecated since Timber version 2.0.0! Use {{ site.option() }} instead. in /var/www/html/wp-content/themes/swkoeln/vendor/timber/timber/src/Helper.php on line 441
I did not find any reference to site.meta in my code, and only after adding a debug_print_backtrace() into timber code I realized it seems it is actually caused by Timber itself (see backtrace below my post)?! Not sure though, I am a bit of a PHP newbie...
Thanks again for the good work!
Jonas
Backtrace:
#0 /var/www/html/wp-content/themes/swkoeln/vendor/timber/timber/src/Core.php(68): Timber\Site->meta('home') #1 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Extension/CoreExtension.php(1637): Timber\Core->__call('home', Array) #2 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Environment.php(361) : eval()'d code(125): twig_get_attribute(Object(Twig\Environment), Object(Twig\Source), Object(StarterSite), 'home', Array, 'any', false, false, false, 17) #3 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(171): __TwigTemplate_59318c560271a4dc2aa74740c399e1bb->block_header(Array, Array) #4 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Environment.php(361) : eval()'d code(48): Twig\Template->displayBlock('header', Array, Array) #5 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(394): __TwigTemplate_59318c560271a4dc2aa74740c399e1bb->doDisplay(Array, Array) #6 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling(Array, Array) #7 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Environment.php(361) : eval()'d code(42): Twig\Template->display(Array, Array) #8 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(394): __TwigTemplate_4d0a745a7f7051148cedce069e0b004b->doDisplay(Array, Array) #9 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling(Array, Array) #10 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/Template.php(379): Twig\Template->display(Array) #11 /var/www/html/wp-content/themes/swkoeln/vendor/twig/twig/src/TemplateWrapper.php(40): Twig\Template->render(Array, Array) #12 /var/www/html/wp-content/themes/swkoeln/vendor/timber/timber/src/Loader.php(178): Twig\TemplateWrapper->render(Array) #13 /var/www/html/wp-content/themes/swkoeln/vendor/timber/timber/src/Timber.php(1442): Timber\Loader->render('page.twig', Array, false, 'default') #14 /var/www/html/wp-content/themes/swkoeln/vendor/timber/timber/src/Timber.php(1579): Timber\Timber::compile(Array, Array, false, 'default', true) #15 /var/www/html/wp-content/themes/swkoeln/page.php(76): Timber\Timber::render(Array, Array) #16 /var/www/html/wp-includes/template-loader.php(106): include('/var/www/html/w...') #17 /var/www/html/wp-blog-header.php(19): require_once('/var/www/html/w...') #18 /var/www/html/index.php(17): require('/var/www/html/w...')

Hey @jrathert , Thank you for trying out Timber 2! Are you calling site.home somewhere in you code? You might want to call site.link here instead. @gchtr , The __call() method in core.php tries to call the meta method on the object. Shouldn't that call option() when we are working with the site object?

Hi @Levdbas - yes, site.home was used before - replaced it with site.link and everything works like a charm, no more deprecation warnings. Maybe this should be added then to the upgrade guide https://timber.github.io/docs/v2/upgrade-guides/2.0/?! (And/or fixed in the core lib, as you mentioned.)
Thanks for the quick reply, btw.

@jrathert , no problem! From what I can see site.home was never a recommended option to link to the homepage. site.link was always the way to go. The way site.home worked was because of this magic __call method that would read the site option home  with $site->meta('home') in this case, which would result into the same result. But the meta() method is deprecated on the Site object since 2.0. So I think we have some work to do for this magic __get 'er

Hi @Levdbas - fair point re: site.home. I actually inherited the theme/project (and needed to learn twig and timber to be able to work with it), and it contained a lot of weird stuff (e.g.: heavy use of post.guid instead of post.link...).
Back to the topic, and also asking @gchtr: Is there anything specifc open re: a 2.0 release? Something to test? To document? Because to me 2.0-rc.1 looks super stable - and I also saw people refering to the 2.0 documentation and running into trouble (the publically available https://timber.github.io/docs/v2/installation/ says installation goes like: composer install timber/timber - which currently installs v1 and lets people get into trouble ;-) ).

Hey @jrathert , Thank you for trying out Timber 2! Are you calling site.home somewhere in you code? You might want to call site.link here instead. @gchtr , The __call() method in core.php tries to call the meta method on the object. Shouldn't that call option() when we are working with the site object?

In the same as we deprecated calling custom fields directly on posts and other objects, direct access in Timber\Site is deprecated as well.
Instead of calling site.home, you should call site.option('home'). I see that this isn’t very well documented in the Upgrade Guide.
Maybe it would be a good idea to overwrite __call in Timber\Site as well, so that it doesn’t call meta().
Could you create a separate issue for that, @Levdbas?

Back to the topic, and also asking @gchtr: Is there anything specifc open re: a 2.0 release? Something to test? To document? Because to me 2.0-rc.1 looks super stable - and I also saw people refering to the 2.0 documentation and running into trouble (the publically available timber.github.io/docs/v2/installation says installation goes like: composer install timber/timber - which currently installs v1 and lets people get into trouble ;-) ).

If you test it by upgrading your sites to use Timber 2.0, that’s already testing enough. And we’ll see what needs to be documented better when people are using it.
We should definitely fix the documentation about how to install the release candidate. Otherwise, it might really confuse people, especially if they’re not familiar with Composer.
Thanks for mentioning that, @jrathert!

Hey @jrathert , Thank you for trying out Timber 2! Are you calling site.home somewhere in you code? You might want to call site.link here instead. @gchtr , The __call() method in core.php tries to call the meta method on the object. Shouldn't that call option() when we are working with the site object?

In the same as we deprecated calling custom fields directly on posts and other objects, direct access in Timber\Site is deprecated as well.
Instead of calling site.home, you should call site.option('home'). I see that this isn’t very well documented in the Upgrade Guide.
Maybe it would be a good idea to overwrite __call in Timber\Site as well, so that it doesn’t call meta().
Could you create a separate issue for that, @Levdbas?

Back to the topic, and also asking @gchtr: Is there anything specifc open re: a 2.0 release? Something to test? To document? Because to me 2.0-rc.1 looks super stable - and I also saw people refering to the 2.0 documentation and running into trouble (the publically available timber.github.io/docs/v2/installation says installation goes like: composer install timber/timber - which currently installs v1 and lets people get into trouble ;-) ).

If you test it by upgrading your sites to use Timber 2.0, that’s already testing enough. And we’ll see what needs to be documented better when people are using it.
We should definitely fix the documentation about how to install the release candidate. Otherwise, it might really confuse people, especially if they’re not familiar with Composer.
Thanks for mentioning that, @jrathert!

In the same as we deprecated calling custom fields directly on posts and other objects, direct access in Timber\Site is deprecated as well.

I think the part of the documentation you linked to should is super important for upgrading and should probably be called "Custom fields / meta" instead of just "meta". During my upgrade procedure, I only found out about custom fields handling when reading the ACF part of the docs. I simply did not realize that the section "Meta" is relevant for custom fields in the first place.

@gchtr , I've updated the roadmap with some todo's after we release 2.0

In the same as we deprecated calling custom fields directly on posts and other objects, direct access in Timber\Site is deprecated as well.

Is accessing custom fields ddirectly really deprecated or just not the recomended way anymore (as it says in the upgrade guide)? I'm asking because doing to the wrong way doesn't seem to trigger any deprecation warnings.

Okay, maybe this was too long ago since I last looked at this. Let me clarify: We deprecated using {{ timber_object.get_field() }}. Instead, {{ timber_object.meta() }} should be used. We didn’t deprecate direct access to custom fields yet, but it’s not recommended, because it can lead to unexpected effects. The meta() method is the recommendation here as well.
We maybe will deprecate direct access to custom fields in a future major version and eventually remove it. This would need another discussion.

Just started the upgrade to Timber 2.0rc1 and it all has been smooth sailing. For an aversion Wordpress site I’m sure it’s no more than a day of work.
The deprecation warnings are thoughtfully written and the upgrade docs are in pretty good shape. It may have took some time but this is solid work 👏

Thanks for the feedback, @rmens. That means a lot! 😊
UPDATE: If all goes well, we will have a Timber 2.0 release out by the end of this week.

Timber 2.0 is released 🚀🎉🌲. Check out the Release notes.
Thanks to everyone who contributed with their time, pull requests, comments and discussions to get us here.
There’s one final todo left on the After release list in this issue. So let’s wait until we fix this before we close this.

[ ] Update readme.md in both branches to refer to eachother.


fix authorization errors; they were backwards, saying the user had al…

…ready authorized 'always' when actually it was 'when in use' and vice versa

They are not backwards. Please see the error description and comments. They are intended to inform the caller that the authorization the user has granted previously is different from the one they are requesting at this time.

Thanks for the comment. I understand the intended purpose. Take this case, as implemented:
         case .AuthorizedWhenInUse:
             if authorization != .WhenInUse {
                return NSError(THGLocationError.AuthorizationAlways)
             }

In this case, .AuthorizedWhenInUse refers to the value returned by  CLLocationManager.authorizationStatus().
So, we are authorized for when in use. Correct?
If we hit the error condition, the message given to the user is: The user has granted permission to location services always, so use that or change it. But this is not true! CLLocationManager.authorizationStatus() returned .AuthorizedWhenInUse - why would we say the user has granted "always" permission?

You're correct. Thanks for the the fix!


removed deprecation warnings. Do not use Time#workday?

Change was introduced in PR #95 (commit e2e06ddbf)

Fixed in 0.7.4.


Fail on compilation if users are importing from angular/src

This could initially be introduced with a flag that allows unsafe imports for 4.0. Example:
transformers:
  angular:
    allow_unsafe_imports: true # Opt-in to allowing lib/src imports without a build failure.

WDUT @kevmoo @jakemac53 @hterkelsen?

sounds good to me!

Pushed to 5x.


Still active?

Hi, I'm looking to use this library for a production tool, and was wondering if it's still being actively maintained?

@duncan-bayne you can follow https://github.com/HuKeping/GoCache

@HuKeping thanks :smile:

https://github.com/biogo/store/tree/master/llrb

Closing due to age.


Display total number of pages

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Just a little badge or something above or below the "Page Output" section to display the total number of pages to be printed.

Oh yes that makes sense, Thank you for pointing it out!
We can have it beside the "Output" heading. I am keeping this open if someone wants to work on it.
In the file src/generate-images.mjs, there's an array called outputImages which contains all the output images so that array's length will be total number of pages.


Hotfix deployment of latest v0.11.1 without mainnet

Unfortunately our CI pipeline is broken and has built the latest release
in development mode. This for examples allows the user to connect to the
main network which is not allowed yet.

@christianbrb @taleldayekh I tested it locally, but let's be super secure: please test this locally. Serve pr does not work. Instructions follow.


Improve layout of charts on the screen

Make better use of the screen space. Some charts are not that important and useful - make then smaller. For some characteristic consider using of http://omnipotent.net/jquery.sparkline/ for some really small charts. For charts display also actual (the most recent) values.

I am archiving this repository now. Thanks for contributions.


added self updater

fixes #17
kombustion update will prompt if a new version is found
kombustion update -y no prompt.
Currently, just pulls the latest version.
Would like to add codesigning to the build process and this updater, and also semver when semver plugins are added.

Pull Request Test Coverage Report for Build 302

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+12.9%) to 51.825%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/manifest/init.go
0
1
0.0%

Totals

Change from base Build 300:
12.9%

Covered Lines:
284

Relevant Lines:
548

💛  - Coveralls


Missing or invalid Task test/s2i-buildah-push: translating Build to Pod: serviceaccounts

Issue
I'm getting a very strange TaskRun message
message: 'Missing or invalid Task test/s2i-buildah-push: translating
Build to Pod: serviceaccounts "build-bot" not found'

even if the serviceaccount exists like the task and taskruns before that Tekton creates the pod running the different tasks as initContainer
https://gist.github.com/cmoulliard/28cede49e8a2ea69531aa814ded10307#file-gistfile1-txt-L67

This can happen if the serviceAccount gets created after the TaskRun (or around the same time with a small race).
To fix this, we may want to be able to do a retry with backoff (and like 3 retry max or something) when we hit the serviceaccounts not found.
/kind bug


Never see a timeout

When I try to connect to a WS server which is down, I won't receive any timeout exception or error in my adapter.
The state changes to CONNECTING (onSendingHandshake) and the it stuck on this stage forever. I setConnectionTimeout to something about 1000 MS.
I tried to set timeout to very low value to see whether it's working or not. When I use for example 1 or 10 MS as timeout. The connection after this time closes and I can see timeout error properly.

I was using ver. 1.22. I've tried 1.27 and this issue seems fixed. Thanks.

I'm glad to hear it.


Fixes #2180

Avoid starting taskqueue multiple times, causing weird state to exist and weird exceptions to be created

:+1: Earlier two task queues were started with same MetadataStore and it can definitely cause issues. Are all tests in TaskLifecycleTest passing correctly now as I still some failures for testResumeTasks or you took care of them ?

:+1: are there any pending test fixes that needs to go in this PR ?

@pjain1 all other tests r cool

@nishantmonu51 no more afaik


⚠ Bofrost.at has degraded performance

In 2c71e55, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1365 ms

Resolved: Bofrost.at performance has improved in 4649213 after 13 minutes.


add dependabot config

this config will automatically create pull requests to update major versions in github actions

Nice idea. Lets see how "annoying" it can be, as I have read no so good feedback about it.
It may create a lot of noise. But lets give it a try.
Thanks again for all of your PRs. They really enhance the project infrastructure a lot.

Nice idea. Lets see how "annoying" it can be, as I have read no so good feedback about it. It may create a lot of noise. But lets give it a try.

yeah i'm not sure about this. i think there's potential for it to create a lot of noise since the lockfile is committed. If the lockfile was not committed, then it would only create PRs for major changes. So there are two options in that case-

remove dependabot. or clamp its updates to 'monthly' or something
rework the CI to not rely on the poetry.lock file, and then remove it from VCS


Fix Border styling of Footer Follow Us

What is the bug*
A clear and concise description of what the bug is.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Fo


⚠ Bofrost.at has degraded performance

In b21396b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2248 ms

Resolved: Bofrost.at performance has improved in 8df5933 after 13 minutes.


Getting black images after adding 27 images through addHTML

I using JS PDF v 1.3.3, with in angular2 project. I am generating pdf with addHTML function. Code works fine for 26 pages. onces it crosses 26 pages complete pdf is generted with black images. I am using below code to generate the pdf.
has any one faced this kind of issue?
 this.pdfDoc.addHTML(this.pages[index], 0, 0, this @.options, () => {
                let obj = this.getClientHeightWidth(index);
                this.pdfDoc.addPage(obj.clientWidth, obj.clientHeight);
                index++;
                this.addPage(index);
            });

27 pages with addHTML? Sounds like a buffer overflow

@arasabbasi is there any way to increase the buffer?

tbh, I dont know the syntax of angularJS. But if your code is grabbing the whole html-site, than it could be the buffer overflow.
https://stackoverflow.com/questions/6081483/maximum-size-of-a-canvas-element
Like I said.. I guess it is a buffer overflow.
A4 are 595x 842 pixels. If we take chomes limit of 32,767 pixels than we have 38 pages to render.
It could be also the addImage-Problem. Go to the addImage Plugin and replace the jsPDFAPI.arrayBufferToBinaryString method by this code.
	/**
	 * Convert the Buffer to a Binary String
	 */
	jsPDFAPI.arrayBufferToBinaryString = function(buffer) {
		if (typeof(window.atob) === "function") {
			return atob(this.arrayBufferToBase64(buffer));
		} else {
			var data = (this.isArrayBuffer(buffer)) ? buffer : new Uint8Array(buffer);
			var chunkSizeForSlice = 0x5000;
			var binary_string = '';
			var slicesCount = Math.round(data.byteLength / chunkSizeForSlice);
			for (var i = 0; i < slicesCount; i++) {
				binary_string += String.fromCharCode.apply(null, data.slice(i*chunkSizeForSlice, i*chunkSizeForSlice+chunkSizeForSlice));
			}
			return binary_string;
		}
	};

And then check again

@arasabbasi issue was with html2canvas. if document height is too big, its generating black images.  fixed it by reducing the dom size.

Hi @AswarthaA ,
I have the same issue, how did you handle this problem?
Thank you.

@newdevsoft7  I had like 35 applications altogether and I was generating PDF pages for all of them together. Now I am generating one page at a time and clearing the DOM..


Server don't show in the list till I Join

Vanilla server works fine and everyone can join
but with rocket the server only show in the list if i Join first but only for like 5 mins
after a while the server don't show in the list again and I need to disconnect and connect to the server show again also I think I am the first person having this issue never see a server with this bug

Do you happen to have the max players on the server above 24 players? That would cause it to not show up in the internet tab in the in-game server browser.
Nelson had made it so that "high slot" server's won't appear on the in-game server list, however the high slot server should still show up fine in-game in the favorites tab, if you have them there, and in the steam server browser(The one that you can use from the steam client.).


Support pipeline evaluation for baichuan2, llama2, mistral and qwen

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.同润 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[v4.0.0-rc.1] Can't copy libraries

Library Affected [v4.0.0-rc.1]:
workbox-cli, workbox-build
Browser & Platform:
MacOS
Issue or Feature Request Description:
For the RC.1 when you copy the libraries using CLI or workbox-build there is an error:
workbox copyLibraries testDir

One or more of the Workbox libraries could not be copied over to the destination directory:
Error: ENOENT: no such file or directory, lstat 'packages/workbox-background-sync/build'

cc: @philipwalton

This was introduced in https://github.com/GoogleChrome/workbox/pull/1895/files#diff-67f62b752408d4f9a08ce4f73718d971R51.
We need to go back to using require.resolve() to get the path to the directory that contains each of the published packages. Using a hardcoded relative path that includes 'packages/' will only work in a local development environment, but not for end users who are loading things from node_modules.


Customize title using main_organization in config.yaml

Fixes #115

Agreed that main_page_title is the desired name, and that we should make clear it's optional.

Closing; this was implemented in https://github.com/MeasureOSS/Measure/commit/cc1040c46b035d633ece22e664cd1b5f848ed435 (which was essentially copied from this PR but tweaked a bit), and thank you!


Add a lastPublished timestamp to datasources.json

The following timestamps are already kept in datasources.json
created: timestamp of the initial import of the datasource
lastUpdated: timestamp of the last import of the datasource
Suggestion

Change lastUpdated to lastImported
Add a lastPublished timestamp that is updated when publish command is run on that datasource.

@twelch considering the ability to access the modification dates of published data, am I good to close this ticket? Unless you still want to change lastUpdated to lastImported


Client unable to fetch update on local machine hosted inside local network (linux server)

Hi there,
I encountered an error when executing code-push-standalone release-react <app-name> android -d Staging --mandatory true --targetBinaryVersion "<app-version>".
This is the response of the code push server api:
Processing package: v6
Unknown error source
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undefined
    at Object.mkdirSync (node:fs:1384:10)
    at PackageDiffer.ensureWorkDirectoryExists (/root/code-push-server/api/bin/script/utils/package-diffing.js:297:20)
    at /root/code-push-server/api/bin/script/utils/package-diffing.js:228:27
    at promise (/root/code-push-server/api/node_modules/q/q.js:702:9)
    at PackageDiffer.downloadArchiveFromUrl (/root/code-push-server/api/bin/script/utils/package-diffing.js:227:16)
    at PackageDiffer.generateDiffPackageMap (/root/code-push-server/api/bin/script/utils/package-diffing.js:38:44)
    at processDiff (/root/code-push-server/api/bin/script/routes/management.js:1101:14)
    at /root/code-push-server/api/bin/script/routes/management.js:758:29
    at _fulfilled (/root/code-push-server/api/node_modules/q/q.js:854:54)
    at /root/code-push-server/api/node_modules/q/q.js:883:30

Though I can see the releases on the deployment history, react-native-code-push is unable to fetch the update.
Code Push client logs:
 LOG  [CodePush] Checking for update.
 LOG  [CodePush] Sync already in progress.
 LOG  [CodePush] Downloading package.
 LOG  [CodePush] An unknown error occurred.
 LOG  [CodePush] Failed to connect to /<IP_ADDRESS>:10000

Environment Setup
Using local development setup on linux machine (Ubuntu 24.04.1 LTS).
.env
EMULATED=true
AZURE_STORAGE_ACCOUNT=someValue
AZURE_STORAGE_ACCESS_KEY=someValue
SERVER_URL=http://<IP_ADDRESS>:3000
GITHUB_CLIENT_ID=someValue
GITHUB_CLIENT_SECRET=someValue
LOG_INVALID_JSON_REQUESTS=true
LOGGING=true

Azurite running on Docker container
docker run --restart always -d -it \
  --name codepush_azurite -v $HOME/data:/data \
  -p 10000:10000 -p 10001:10001 -p 10002:10002 \
  mcr.microsoft.com/azure-storage/azurite

Engine version

NodeJS (v18.20.4)
npm (10.7.0)

@lfrallon seems like your problem is caused by azurite,
if you use emulated storage (azurite), the connection string to azurite is default to local machine, which is <IP_ADDRESS>, and port 10000 is spesific to Azurite Blob Service.
When you test to download the code-push update from server, the server returning blob url with azurite host as is. And that's why your mobile device can't connect to <IP_ADDRESS> of your host machine.
The easiest way to make it work is to use azure blob storage. but if you want to try more deeper, take a look at my repository here
it just simple code-push-server fork, i'm just adding ENVIRONMENT var to customize azurite connection string
you just need to customize the host (maybe use your local wifi address for your machine), and tune up your azurite setting if needed.
i hope it help

@lfrallon seems like your problem is caused by azurite, if you use emulated storage (azurite), the connection string to azurite is default to local machine, which is <IP_ADDRESS>, and port 10000 is spesific to Azurite Blob Service.
When you test to download the code-push update from server, the server returning blob url with azurite host as is. And that's why your mobile device can't connect to <IP_ADDRESS> of your host machine. The easiest way to make it work is to use azure blob storage. but if you want to try more deeper, take a look at my repository here
it just simple code-push-server fork, i'm just adding ENVIRONMENT var "AZURITE_CONNECTION_STRING" to customize azurite connection string
you just need to customize the host of azurite connection string (maybe use your local wifi address for your machine), and tune up your azurite setting if needed. i hope it help

@azrulhaifan that's also what I thought.
Thank you. I'll check it then and also currently looking for different solutions.

@lfrallon seems like your problem is caused by azurite, if you use emulated storage (azurite), the connection string to azurite is default to local machine, which is <IP_ADDRESS>, and port 10000 is spesific to Azurite Blob Service.
When you test to download the code-push update from server, the server returning blob url with azurite host as is. And that's why your mobile device can't connect to <IP_ADDRESS> of your host machine. The easiest way to make it work is to use azure blob storage. but if you want to try more deeper, take a look at my repository here
it just simple code-push-server fork, i'm just adding ENVIRONMENT var "AZURITE_CONNECTION_STRING" to customize azurite connection string
you just need to customize the host of azurite connection string (maybe use your local wifi address for your machine), and tune up your azurite setting if needed. i hope it help

Hello, there! I am using your fork, but when I am trying to login, I am gettting the following error instead of the access key
Account not found.
Have you registered with the CLI?
If you are registered but your email address has changed, please contact us.

in my browser, here is my .env file with AZURITE_CONNECTION_STRING
EMULATED=true
SERVER_URL=http://<IP_ADDRESS>:3000
AZURITE_CONNECTION_STRING="DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://<IP_ADDRESS>:10000/account1;QueueEndpoint=http://<IP_ADDRESS>:10001/devstoreaccount1;TableEndpoint=http://<IP_ADDRESS>:10002/devstoreaccount1;"
any help is very much appreciated

@alisyd I think you need to register again like code-push-standalone register http://<IP_ADDRESS>:3000.

Account not found.
Have you registered with the CLI?
If you are registered but your email address has changed, please contact us.

try to re-register like what @lfrallon say, or logout than relogin. if you can't achieve it, try to remove your CLI profile manually.
it placed somewhere on your home directory with the name ".code-push.config" (on mac os), than try to relogin again. make sure you have setted up github oath variable.

and how do we use the blob storage solution that you pointed out?
any help is very much appreciated

if you setup a correct AZURITE_CONNECTION_STRING, than your codepush server will serve the blob url (for downloading code update) from it, you just need to make sure the azurite server are published & can be accessed via internet.
and take a look your connection string at :
BlobEndpoint=http://<IP_ADDRESS>:10000/account1
i think the correct string is :
BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount1
one simple way to make sure your azurite blob server are exposed to internet is by access your IP:PORT on browser, than it will show xml page

Account not found.
Have you registered with the CLI?
If you are registered but your email address has changed, please contact us.

try to re-register like what @lfrallon say, or logout than relogin. if you can't achieve it, try to remove your CLI profile manually. it placed somewhere on your home directory with the name ".code-push.config" (on mac os), than try to relogin again. make sure you have setted up github oath variable.

and how do we use the blob storage solution that you pointed out?
any help is very much appreciated

if you setup a correct AZURITE_CONNECTION_STRING, than your codepush server will serve the blob url (for downloading code update) from it, you just need to make sure the azurite server are published & can be accessed via internet.
and take a look your connection string at : BlobEndpoint=http://<IP_ADDRESS>:10000/account1
i think the correct string is : BlobEndpoint=http://<IP_ADDRESS>:10000/devstoreaccount1
one simple way to make sure your azurite blob server are exposed to internet is by access your IP:PORT on browser, than it will show xml page

Yep that was it, Changed the connection string and things are working fine. Thanks for the help!

Hello
@alisyd @azrulhaifan @lfrallon
What should I give to AccountKey in the url below?
DefaultEndpointsProtocol=http;AccountName=account1;AccountKey=base64key;BlobEndpoint=http://<IP_ADDRESS>:10000/account1;QueueEndpoint=http://<IP_ADDRESS>:10001/account1;TableEndpoint=http://<IP_ADDRESS>:10002/account1;

If the AccountKey is incorrect, the codepush server will throw the following error:
Unknown storage error.
Error: Server failed to authenticate the request. Make sure the value of the Authorization header is formed correctly including the signature.
RequestId:90e2171e-b288-4e91-8aae-413975826666
Time:2024-11-04T07:34:47.929Z

Thanks in advance.

AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;
BlobEndpoint=http://<IP_ADDRESS>:9000/devstoreaccount1
I changed the IP and port for queue and table and blob and accountKey,
and confirmed that it works normally until the update check.
However, It still see <IP_ADDRESS> like below when downloading. ㅜㅜ
 LOG  [CodePush] Sync already in progress.
 LOG  [CodePush] Checking for update.
 LOG  [CodePush] Awaiting user action.
 LOG  [CodePush] Downloading package.
 LOG  [CodePush] An unknown error occurred.
 LOG  [CodePush] Failed to connect to /<IP_ADDRESS>:10000

@alisyd @azrulhaifan @lfrallon
What could have gone wrong?

AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==; BlobEndpoint=http://MyIP:9000/devstoreaccount1
I changed the IP and port for queue and table and blob and accountKey, and confirmed that it works normally until the update check.
However, It still see <IP_ADDRESS> like below when downloading. ㅜㅜ
 LOG  [CodePush] Sync already in progress.
 LOG  [CodePush] Checking for update.
 LOG  [CodePush] Awaiting user action.
 LOG  [CodePush] Downloading package.
 LOG  [CodePush] An unknown error occurred.
 LOG  [CodePush] Failed to connect to /<IP_ADDRESS>:10000

@alisyd @azrulhaifan @lfrallon
What could have gone wrong?

Using Azurite connection string in .env works with @azrulhaifan   fork  of code-push-server,  if you are using the one from this repo, I would not work

@alisyd @azrulhaifan
IHere's what I did:
I cloned this repository below.
https://github.com/azrulhaifan/code-push-server-freedom.git
.env
EMULATED=true
LOGGING=true
SERVER_URL={IP:8090}
GITHUB_CLIENT_ID={}
GITHUB_CLIENT_SECRET={}
AZURITE_CONNECTION_STRING="DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://{IP}:9000/devstoreaccount1;QueueEndpoint=http://{IP}:9001/devstoreaccount1;TableEndpoint=http://{IP}:9002/devstoreaccount1"

I gave it <IP_ADDRESS> to accept remote requests.
azurite --debug ./debug.log --blobHost <IP_ADDRESS> --blobPort 9000 --queueHost <IP_ADDRESS> --queuePort 9001 --tableHost <IP_ADDRESS> --tablePort 9002

PORT=8090 npm run start:env

Checking for updates was successful, but downloading still fails with IP address <IP_ADDRESS>.
 LOG  [CodePush] Sync already in progress.
 LOG  [CodePush] Checking for update.
 LOG  [CodePush] Awaiting user action.
 LOG  [CodePush] Downloading package.
 LOG  [CodePush] An unknown error occurred.
 LOG  [CodePush] Failed to connect to /<IP_ADDRESS>:10000


Operator start behavior

The Operator.start method is implemented like:
public void start() {
   ...
    try {
      ...
    } catch (Exception e) {
      log.error("Error retrieving the server version. Exiting!", e);
      System.exit(1);
    }
  }

I wonder if instead of doing a System.exit(1), the start method should thrown an exception and let the caller decide what to do.

I second this, this could just throw an OperatorException and go on from there. System.exit(1) won't even produce a clean halt, so it's just an unhandled (and unhandleable) exception with less information on the output.

@lburgazzoli do you have a specific use case or issue with the current handling? The idea here, which might be misguided, is that if the operator fails to start then that's usually a non-recoverable error and the pod the operator runs in should crash so that Kubernetes gets the opportunity to re-schedule a new pod at some later time.

That's ok but it is not possible to intercept the error, so for example if we are using quarkus, I may want to use Quarkus.asyncExit() instead of using System.exit()


Configurable estimator similar to boruta_py

Would it be possible to make the estimator configurable?  Currently you're requiring xgboost, but I'd prefer to be able to try to use lightgbm (https://github.com/szilard/GBM-perf) as it benchmarks a bit faster.

To follow-up, would you be open to a PR implementing such a thing?

I have been wanting to do this for a while, but haven't been able to think through the implementation as I would ideally like to be able to implement more estimators.  I'm definitely open to a PR on it - let me know what you are thinking for how to structure it: chasedehan at yahoo dot com

We are starting to look into the implementation of a configurable estimator.


Fixing gather_there for used with lvalue reference argument

Fixes issue reported here: https://github.com/STEllAR-GROUP/hpx/pull/4676#issuecomment-860999175
@khuck, please verify whether this fixes your problem.

@msimberg I'd appreciate it if this fix would go into V1.7, still.

@hkaiser building/testing it now...

@hkaiser That works, thanks!

retest lsu


Add --reset flag to deploy task

Adds a --reset flag to wipe the deployments state before a deployment. Also includes a confirmation when used on a non-hardhat network.
resolves #649

I have done of manual tests. No issues against local/sepolia.


Add default status for new user

AC
Add default status idle when a new user is created
Description:
When a user joins RDS, the default status of the user is "idle". To represent this,  in the user modal we have status: "idle". This field can also be used as a query in firestore to filter the idle users https://github.com/Real-Dev-Squad/website-backend/issues/635

Closing this Issue. As the new status collection is getting created which make this issue irrelevant https://github.com/Real-Dev-Squad/website-backend/issues/818


Fix Windows compatibility

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 62.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
1239

Relevant Lines:
1723

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 62.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
1239

Relevant Lines:
1723

💛  - Coveralls


Version 8.2.4 conflicts with the Babel plugin

I use Rollup via JS API this way:
Bundling script:
const rollup = require('rollup'); // 0.50.0
const rollupBabel = require('rollup-plugin-babel'); // 3.0.2
const rollupNodeResolve = require('rollup-plugin-node-resolve'); // 3.0.0
const rollupCommonJS = require('rollup-plugin-commonjs');
const babelPresetES2016 = require('babel-preset-es2016'); // 6.24.1
const babelPresetES2017 = require('babel-preset-es2017'); // 6.24.1
const babelPluginTransformRestSpread = require('babel-plugin-transform-object-rest-spread'); // 6.26.0
const babelPluginExternalHelpers = require('babel-plugin-external-helpers'); // 6.22.0

rollup.rollup({
	input: 'scriptToBundle.js',
	context: 'window',
	plugins: [
		rollupNodeResolve({
			browser: true,
			extensions: ['.js', '.json']
		}),
		rollupCommonJS({
			sourceMap: false
		}),
		rollupBabel({
			presets: [babelPresetES2017, babelPresetES2016],
			plugins: [babelPluginTransformRestSpread, babelPluginExternalHelpers]
		})
	]
}).then(bundle => bundle.write({
	file: 'bundledScript.js',
	format: 'iife',
	indent: false
}));

Script to bundle:
const obj1 = {fruit: 'orange', car: 'lada'};
const obj2 = {...obj1, music: 'jazz'}

When I use the rollup-commonjs plugin version 8.2.3, the bundling is run successfully. But when I use the rollup-commonjs version 8.2.4, the rollup-babel plugins ignores the rest spread transform, the rest spread operator ({...obj}) gets to Rollup and the bundling fails:
events.js:160
      throw er; // Unhandled 'error' event
      ^
SyntaxError: Unexpected token (2:14) in ~/scriptToBundle.js
    at error (~/node_modules/rollup/dist/rollup.js:185:14)
    at Promise.resolve.then.catch.err (~/node_modules/rollup/dist/rollup.js:9448:6)

npm ERR! Darwin 17.0.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/bin/npm-cli.js" "run" "build" "--scripts-prepend-node-path=auto"
npm ERR! node v6.11.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! @ build: `gulp build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ build script 'gulp build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     ~/npm-debug.log

Same here. Though I'm using the babel-plugin-transform-react-jsx plugin for babel. I'm getting an Unexpected token the moment rollup-plugin-commonjs reaches JSX syntax.
This occurs in 8.2.4 and still occurs in 8.2.6. Going back to 8.2.3 is the current work-around.

I made it work by excluding the project source folder:
cjs({
  exclude: 'src/**',
}),

The exclude option in a lerna setup does sadly not work for me. My plugins look as follows
replace({
      'process.env.NODE_ENV': JSON.stringify(env),
      VERSION: `'${version}'`,
    }),
    globals(),
    builtins(),
    resolve({
      module: true,
      jsnext: true,
      main: true,
      preferBuiltins: true,
    }),
    commonjs({
      ignoreGlobal: true,
      exclude: ['packages/**'],
    }),
    babel({
      exclude: ['node_modules/**'],
      babelrc: true,
      runtimeHelpers: true,
    }),
    filesize(),

Anything wrong with this setup?

@Akryum It works, thank you!
You can also use this setup:
rollupCommonJS({
    include: 'node_modules/**'
});

The bug is still a bug though.

This still occurs with 8.4.0

Just to get a little more context:

As of version 0.56.0, rollup natively understands object rest spread while as of version 9.0.0 (which is actually more or less the same as 8.4.0 except that rollup is listed as a peer dependency), this plugin will re-use rollup's parser and should thus be able to handle object rest spread as well. Do you still experience this issue when using these versions?
Otherwise if you are using unknown/future syntax that you transpile via babel, then the babel plugin must come before the CJS plugin because the CJS plugin needs to be able to parse files to do transformations. Do you still experience issues if you order your plugins[rollupNodeResolve(), rollupBabel(), rollupCommonJS()]

?

@lukastaegert  I have the problem even with the correct ordering.

@lukastaegert that's right, it worked for me(i use jsx) :ok_hand:

Still actual for:

rollup v0.66.4
rollup-plugin-babel v4.0.3
rollup-plugin-commonjs v9.1.8
@babel/core v7.1.2

@lukastaegert Changing the order of plugins solves the problem. Thank you!


Merge pull request #1 from CobaltFusion/master

merge with  origin:master

I see no changes.

Sorry , I  messed it up with git ....

Am 26.08.2018 um 15:17 schrieb Jan Wilmans<EMAIL_ADDRESS>I see no changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Why are these rules specific to React Native?

Shouldn't these rules apply to all React projects?

Rules that apply to all React projects can be found in the eslint-plugin-react project. The rules in this plugin are specific to React Native API's such as StyleSheets and platform based (.ios/.android) components.


Zigbee2MQTT remove common.values.setup

Details
Helm chart name:
zigbee2mqtt
Describe the solution you'd like:
The common.yaml file includes the line {{- include "common.values.setup" . }}. It appears that this is called regardless by the final line with {{ include "common.all" . }}. Is there a reason to keep this line in the chart or could it be removed?
Anything else you would like to add:

Additional Information:
Very new to helm and K8s-at-home so it may very well be vital and I am just missing the contextual understanding

Clarified via discord that calling this twice does no harm and is intended to ensure user and default values are merged in the case of wanting to operate on the combination object before the call to .all function


Cypress/E2E: Revert changes using lodash.set and mattermost types imports

Summary

Revert changes using lodash.set
Use Mattermost types under Cypress namespace to keep imports in one place only.

Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/251170


guess conntrack netns ino independently of tracer netns ino

What does this PR do?
Currently the ct_netns_ino offset value in conntrack offset guessing is set to the one that is guessed via tracer offset guessing since it should be the same offset. In reality this means that even when running the CO-RE tracer, tracer offset guessing is still required to support conntrack (which is always prebuilt). This PR removes that link between the two modules.

Motivation
https://datadoghq.atlassian.net/browse/NPM-3143

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


add hostname to dcgm_* metrics

@D1abloRUS, when prometheus scraps metrics from nodeexporter, it automatically appends new label instance which can be used to identify the host. Does that help?

@muzammil360 yes, i already use this


all-tests.c is unused

Hi Mark. It appears that all-tests.c isn't compiled by any target, and isn't used. Its logic is superseded by CMake code in tests/CMakeLists.txt. Should all-tests.c be deleted?

This file was removed. I guess it's safe to close this issue! - thanks for the contributions - keep 'em coming.


Able to add not imported mesh as mesh component.

Steps to reproduce:

Create a model, without importing a fbx file
Create a mesh component on a entity
You will now be able to add the not imported mesh to the component.

Fixed by setting a default model to model resource?

Still not wokring. will be moved to "wontfix"


Roadmap state for TreeScale

Going through the project readme page I can see that there still undone items on the Roadmap whilst there have been no commit since a long time.
Could I know the project state in purpose of using it?
Thanks.

@tmarwen thanks a lot for considering to use this codebase, but it was just a POC project to make a scalable PubSub system as a basis for our multi-cloud storage solution. We have some plans on open-sourcing it, but most probably it will be by the end of this year.
I left roadmap there just to inform what's there and what needs to be done. Generally, the basic messaging and grouping works, and the base concept of tree base scalability is also there.
If you have any questions about architecture or you need to advise on how to implement this concept, I would be happy to discuss it. I'm always interested in use-cases.


Gitrepository fails to checkout and determine revision

When using with GitRepository.spec.ref.semver: ~32.5 we get error as below
Status:
  Condition:
     Message: failed to checkout and determine revision: unable to resolve tag revision: unsupported object type

we use GitRepository.spec.ref.tag: 32.5.0 , its working fine..
helm-controller: v0.31.0
source-controller: v0.36.1
notification-controller:v0.33.0
kustomize-controller: v0.33.0
Anyone clue on this.. ? pls

sure.. tried with semver:32.5.0
Same error.
those tags are lightweight

I can't reproduce this. This error message leads me to believe that there's something wrong/unusual with either the the object that the tag is pointing to or the tag object itself.  Could you please confirm that all tags in your repo are valid?

Yeap.. all tags are valid.  How can I get more trace logs to dig deep on the issue?


docs(product): add a guide to explain how the configurable product se…

…lectors work
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
The configurable product selectable attributes selector is a bit complicated, and since it abstracts away the concept of configurable product variants, it would probably be useful to explain how the selector translates the variants into available attributes.
What is the new behavior?
A doc is provided that explains how the selector works and, conceptually, how and why it was developed.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

The tone is not very technical but the info itself seems good.

Yea, it kind of has a blog-post type feel, but I thought an explanation of how we got to the solution would be more helpful to more people than just an explanation of how it works. I couldn't think of a reason why our guides needed to feel really technical. Maybe there is a reason. I'm not sure.


Extract highlighting tags to an enum

We use strings to tag syntax-highlighted tokens: https://github.com/rust-analyzer/rust-analyzer/blob/d6223253b628b279f9ddae8f83f7173d01f6b32c/crates/ra_ide/src/syntax_highlighting.rs#L119
This is less than idea, because there's no single place that lists all the tags. We should fix it by either using an enum, or declaring all the tags as named constants (I lean towards the latter option).

cc @omerbenamram, as the person who last touched that code :)

@matklad I'll extract those to constants then.

Isn't this issue fixed?


Create a yaml processor

The processor will read any yaml file
The processor will validate any yaml file if it can understand command in yaml files.
The processor will translate yaml file into a workflows that our program understand.
The processor will pass those workflows to executor.

I prefer using properties file which more native than yaml in jvm world, so close this one


Setup CI

Would be great if you could setup some CI like travis on this project. Let me know if you need a hand.

Good idea! I actually wanted to implement this already, but I didn't have the time yet. I'd also like to implement StyleCI if possible, but I don't have any experience with it so far.

Super :+1:


Update README to show correct Android Setup Doc

In README, the section for Android App Development Setup points to this doc, which is not present.
The correct link is this
Maybe happened due to folder structure change during one of the commits

@iamareebjamal The PR for this issue has been sent and it will be updated as soon as some mentor merges it! I guess you can close this issue :+1:


"Explain command" in context (existing conversation)

Test plan
CI and manual testing.
Changelog
When I use “explain command”, no longer opens a new chat session. Instead, it sends it to the active chat session.
This is a revised version of #5698.

Is this a desirable change? Wouldn't sending it to an existing chat session include the previous session chat history, which may or may not be relevant to the explanation.

Yes 100%.
The happy path (and the most common scenario I found myself needing this) is when sending a terminal command from Cody to terminal, then getting an error from it. So I believe it'll be helpful in more cases than not.
It's easy enough to start a new chat and send terminal output there, but the other way around (sending terminal output to an existing chat) is only possible with this.
I found a small bug in the implementation here though - will update here once it's fixed.

Yes 100%.
The happy path (and the most common scenario I found myself needing this) is when sending a terminal command from Cody to terminal, then getting an error from it. So I believe it'll be helpful in more cases than not.
It's easy enough to start a new chat and send terminal output there, but the other way around (sending terminal output to an existing chat) is only possible with this.
Here's a short screen video to show a simple example of how this can be really useful:
https://github.com/user-attachments/assets/87d3458e-ca76-48cc-a66a-69cfd00a76cc

@ykdojo can you add a changelog entry please!

@kalanchan sure. Does it need to be merged in the same PR, or can it be done in a separate one?

@ykdojo it can be in a separate PR


Add config to instantiate ConsulSecretStore

Also updated the README.md for secret and session store config
examples
Add version to fat jar

Fixes #40

Current coverage is 92.49%

Merging #92 into master will decrease coverage by -0.77% as of 1019043

@@            master     #92   diff @@
======================================
  Files           31      31
  Stmts          564     573     +9
  Branches        36      36
  Methods          0       0
======================================
+ Hit            526     530     +4
  Partial          0       0
- Missed          38      43     +5

Review entire Coverage Diff as of 1019043

Powered by Codecov. Updated on successful CI builds.


Consider adopting signed release tags

The OpenSSF Best Practices Badge suggests signing release tags. The process is simple, described here: simply create the release from a tag created with -s:
$ git tag -s v1.2.3
The project maintainer who creates the release tags needs a GPG key. Instructions for creating a key are described here.

Thanks for posting these ideas for security improvements, @cary-ilm, and they all sound valuable to me!


moolamreddy

Type: Bug
i need to connect for github with
VS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:48:05.904Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-2350M CPU @ 2.30GHz (4 x 2295)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: unavailable_offraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: unavailable_offwebgpu: enabled

Load (avg)
undefined

Memory (System)
3.91GB (0.74GB free)

Process Argv
-n --crash-reporter-id 200bd77f-1cd3-4372-bd9a-736a3e1e8be6

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

htmlplay
bia
0.0.10

dadroit-json-generator
Dad
1.1.7

gitlens
eam
14.4.0

codespaces
Git
1.16.0

copilot
Git
1.128.0

copilot-chat
Git
0.8.0

vscode-pull-request-github
Git
0.74.0

vscode-edge-devtools
ms-
2.1.3

LiveServer
rit
5.7.9

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263cf:30856253
vscaac:30438847
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
89544117:30613380
vscrp:30673768
showlangstatbar:30737416
0bi6i642:30841073
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
copilotsettingt:30859503
asynctok:30869155
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30866406
pyreplss1:30865275
pythonmypyd1:30859726
2e7ec940:30869480
pythontbext0:30864172

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


DISCORD SERVER

https://discord.gg/BRSjzXcj

can you make another invite i made another acc with 2fa

im grounded

im grounded


option to redirect html queries to resources

From a user's perspective, it would be helpful to redirect some queries to the public digital library, for instance, under some circumstances, http://purl.bdrc.io/resource/W8LS19368 would be redirected to http://library.bdrc.io/show/bdr:W8LS19368 . The circumstances would be:

html or xhtml accept header
no accept header
accept header not corresponding to a known RDF serialization

Done


Support for gnutls

I was able to leverage a fork that I'll try to get merged of this repository (with minimal changes), to support the use of gnutls instead of OpenSSL with the mqtt_cpp library.
Would the owners be accepting of a pull-request that adds support for gnutls using this other repository 'as a reference in docs' or a git submodule?
The changes I've had to make have primarily been the following across files in the mqtt_cpp repo:

Include gnutls headers instead of OpenSSL

#if defined(MQTT_USE_TLS)
#if !defined(MQTT_USE_GNU_TLS)
    #include <boost/asio/ssl.hpp>
#else
    #include <boost/asio/gnutls.hpp>
    #include <gnutls/gnutls.h>
#endif // !defined(MQTT_USE_GNU_TLS)
#endif // defined(MQTT_USE_TLS)

Change namespace definitions for the ssl library:

namespace as = boost::asio;

#if defined(MQTT_USE_TLS)
#if !defined(MQTT_USE_GNU_TLS)
    namespace ssl = as::ssl;
#else
    namespace ssl = as::gnutls;
#endif // !defined(MQTT_USE_GNU_TLS)
#endif // defined(MQTT_USE_TLS)

I think your best path to success for getting support for this merged is going to be to isolate the logic for handling which SSL library to use into a single header file.
Basically just take the stuff you specified in your initial comment here, and put that into ssl_implementation.h, or something similar.
But I don't see why the changes you're proposing would be rejected. This seems like a very useful thing to have.
Further, it also helps with regards to using wolfssl, which is useful for embedded contexts like OpenWRT.

@shantanu1singh, I'm not sure why you want to use gnutls.
Do you send a pull request for Boost.Asio to support gnutls ? If you did it, please let me know the link of the pull request.
If Boost.Asio support gnutls, maybe mqtt_cpp automatically support it via boost. Perhaps small change is required.
This is another point that the license of gnutls is LGPL. It is more constrained licence that Boost license. I don't want to contain LGPL code as the submodule of mqtt_cpp.
I guess that it is related topic for #636. The license of WolfTLS is GPLv2 or commacial license.
I'm not sure how Boost.Asio treat the license issue well.
Anyway, I want to keep that mqtt_cpp simply use Boost style.

@jonesmz With respect to moving the logic to a separate header, I can do that.
@redboltz I'm using mqtt_cpp in a project and our customer is hesitant to use the OpenSSL ssleay license
Boost.Asio doesn't support gnutls right now. This repository provides a GnuTls wrapper for Boost.Asio and it uses the Boost license (Not LGPL)
With the proposed change, there won't be any explicit gnutls related function calls in the mqtt_cpp library. It'll only consume the headers of the wrapper mentioned above. I should have a pull-request ready sometime tomorrow for you to see if it's acceptable.
If you don't like the idea of using a git submodule, could we instead just add instructions in the ReadMe or in the wiki to tell potential users that if they wish to use GnuTLS with mqtt_cpp, they will need to install the headers present in the wrapper above on their device?

@shantanu1singh , I understand your situation.
And I've read https://github.com/paullouisageneau/boost-asio-gnutls carefully.
There is no header file name conflict with Boost.Asio, it is good.
I accept

Include gnutls headers instead of OpenSSL

Please don't use negative condition with else clause. See https://github.com/redboltz/mqtt_cpp/wiki/Coding-Rules
https://github.com/paullouisageneau/boost-asio-gnutls

Change namespace definitions for the ssl library:
It this required?
I think that the existing code always use as::ssl not ssl. Am I missing something ?

submodule vs outside
I think that outside file is better for this situation. If user wants to use gnutls, user need to prepare gnutls as the outside module. Similarly, https://github.com/paullouisageneau/boost-asio-gnutls too. Just install it to the system include path or add compiler option for adding include path.

@redboltz

Please don't use negative condition with else clause. See https://github.com/redboltz/mqtt_cpp/wiki/Coding-Rules

Will do

Change namespace definitions for the ssl library:
It this required?
I think that the existing code always use as::ssl not ssl. Am I missing something ?

Yes, mqtt_cpp currently uses as::ssl, but the equivalent namespace in boost-asio-gnutls is as::gnutls. That's why I was thinking of creating a new namespace alias ssl which refers to boost::asio::ssl for OpenSSL and boost::asio::gnutls when boost-asio-gnutls is used. The side-effect of that though is that I'll have to change all occurrences of as::ssl in mqtt_cpp to ssl. Did you have a better solution in mind?

I think that outside file is better for this situation. If user wants to use gnutls, user need to prepare gnutls as the outside module. Similarly, https://github.com/paullouisageneau/boost-asio-gnutls too. Just install it to the system include path or add compiler option for adding include path.

That works. I can add instructions to the ReadMe in mqtt_cpp or the wiki. Which one would you prefer?

@redboltz

Please don't use negative condition with else clause. See https://github.com/redboltz/mqtt_cpp/wiki/Coding-Rules

Will do

Change namespace definitions for the ssl library:
It this required?
I think that the existing code always use as::ssl not ssl. Am I missing something ?

Yes, mqtt_cpp currently uses as::ssl, but the equivalent namespace in boost-asio-gnutls is as::gnutls. That's why I was thinking of creating a new namespace alias ssl which refers to boost::asio::ssl for OpenSSL and boost::asio::gnutls when boost-asio-gnutls is used. The side-effect of that though is that I'll have to change all occurrences of as::ssl in mqtt_cpp to ssl. Did you have a better solution in mind?

Thank you for elaborating. I understand. Replacing existing as::ssl is good.
I think that newly introduced namespace alias should be tls.
I guess that boost asio sub namespace ssl is by historical reason.

I think that outside file is better for this situation. If user wants to use gnutls, user need to prepare gnutls as the outside module. Similarly, https://github.com/paullouisageneau/boost-asio-gnutls too. Just install it to the system include path or add compiler option for adding include path.

That works. I can add instructions to the ReadMe in mqtt_cpp or the wiki. Which one would you prefer?

I think that https://github.com/redboltz/mqtt_cpp/wiki/Config is appropriate place.
In addition, you can add something at TLS support table on README.md.

@redboltz I'm using mqtt_cpp in a project and our customer is hesitant to use the OpenSSL ssleay license

Currently OpenSSL 3.0.0 and higher is under Apache license.


Support utimens for JNI-FUSE

Fix #13090

@apc999 @LuQQiu I have tested this PR can solve the #13090, please take a look, thank you.

I do the following test
[root@9 ~/alluxio-github/alluxio]# integration/fuse/bin/alluxio-fuse mount fuseMount /
[root@9 ~/alluxio-github/alluxio]# touch fuseMount/iamok.txt
[root@9 ~/alluxio-github/alluxio]# ll fuseMount/iamok.txt
-rw-r--r-- 1 root root 0 Apr 13 14:45 fuseMount/iamok.txt

with the alluxio-site.properties like this,
alluxio.fuse.debug.enabled=true

see the fuse.out like this,
LOOKUP /iamok.txt
getattr /iamok.txt
   unique: 64, error: -2 (No such file or directory), outsize: 16
unique: 65, opcode: CREATE (35), nodeid: 1, insize: 66, pid: 29470
create flags: 0x8841 /iamok.txt 0100644 umask=0022
   create[7] flags: 0x8841 /iamok.txt
getattr /iamok.txt
   NODEID: 4
   unique: 65, success, outsize: 160
unique: 66, opcode: FLUSH (25), nodeid: 4, insize: 64, pid: 29470
flush[7]
   unique: 66, success, outsize: 16
unique: 67, opcode: SETATTR (4), nodeid: 4, insize: 128, pid: 29470
utimens /iamok.txt<PHONE_NUMBER>.713091734<PHONE_NUMBER>.713091734
getattr /iamok.txt
   unique: 67, success, outsize: 120
unique: 68, opcode: FLUSH (25), nodeid: 4, insize: 64, pid: 29470
flush[7]
   unique: 68, success, outsize: 16
unique: 69, opcode: RELEASE (18), nodeid: 4, insize: 64, pid: 0
release[7] flags: 0x8801
   unique: 69, success, outsize: 16

It seems looking good.

alluxio-bot, merge this please


 This is an automatic PR.

Closing this as it was a test


[FLINK-5129] make the BlobServer use a distributed file system

Previously, the BlobServer held a local copy and in case high availability (HA)
is set, it also copied jar files to a distributed file system. Upon restore,
these files were copied to local store from which they are used.
This PR abstracts the BlobServer's backing file system and makes it use the
distributed file system directly in HA mode, i.e. without the local file system
copy. Other than that the behaviour should not change.
Secondly, BlobCache instances at the task managers also make use of this
distributed file system and download files from there instead of bothering
the blob server. As before, however, distributed files may only be deleted
by the blob server. If the distributed file system is not accessible at the blob
caches, the old behaviour is used.

BlobServer: include the cluster id in the HA storage path for blobs
make the BlobServer use the HA filesystem back-end properly:
make the BlobCache also use a distributed file system in HA mode

@uce can you have a look?

Sorry for the hassle, found a regression and added a fix plus an appropriate test for it. Should be fine now.

despite the tests completing successfully, I do still need to check a few things:

BlobService#getURL() may now return a URL for a distributed file system, however:
related code, e.g. java.io.File, may not know how to handle HDFS URLs, for example :(

I need to adapt a few things and choose a different approach - I'll re-open later


2021-02-12 GUARD-1792 Cannot-Load-EU-Marketplaces

Summary
It looks like Amazon added Poland (PL) marketplace for EU region without mirroring this information in the official documentation:
https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html
Besides this added extra marketplaces - Sa, Sg, Eg to prevent possible issues with loading marketplaces list for different regions.

@fabulaspb , GUARD-719 was released yesterday - RLS-1903. You can merge GUARD-719 into master, then pull from master into this branch, and change this PR to have master as destination

Changes look good, but see my comment about GUARD-719

Merged tracking numbers changes into master branch.


position: center does not seems to work at all

$.notify("Failed to add the URL.", { position:"center" });
$.notify("Failed to add the URL.", { position:"center top" });
$.notify("Failed to add the URL.", { position:"center middle });
$.notify("Failed to add the URL.", { position:"center bottom" });

All of these produce the following error:
Must be one of [t,b,l,r]
If I in any of the examples above change center to example "left", it starts working.
Using 0.4.2.

Ah yep this is a bug, the parser should handle those cases. In the meantime, it works when you do "<v-align> <h-align>": $.notify("Failed to add the URL.", { position:"top center" });


DI\object() should not extend the previous definition by default

This is a BC break planned for next major version (5.0).
The problem is that we want to add decoration and definition extension, but that already exists for DI\object() today and it's implicit.
The reason it works implicitly today is to take advantage of autowiring/annotations as much as possible, for example:
class Foo {
    public function __construct(Bar $bar, $string) …
}

return [
    'Foo' => DI\object()
        // I only have to define the non type-hinted parameter
        ->constructorParameter('string', 'Hello world'),
];

If we add definition extension and decoration as a main feature with explicit syntax addition (e.g. adding items to arrays, etc.), should we make it also explicit for objects. This is a BC break.
return [
    'Foo' => DI\object()
        ->extend()
        ->constructorParameter('string', 'Hello world'),
];

Without ->extend() the definition is considered as a complete override of any previous existing definition (defined either in a file, autowiring or annotations… doesn't matter).
Pros

it's explicit whether you extend or not
you can choose not to use it to replace the previous entry (which is currently impossible)
you can control what you extend (->extend('some_other_custom_entry')) like in Symfony for example
it would be more consistent with other ways to extend definitions
it would solve side-effect/bug #193

Cons

BC break: people have to update their config files
syntax more verbose to extend a previous definition

I have finally decided not to introduce this change.
I have implemented it in #244 but after writing tests and playing with it, I realized some difficult problems where surfacing which meant that the level of complexity was much higher for the user. Even I had trouble writing very simple object definitions with the patch.
Regarding #193 this can be fixed regardless of this.
Regarding extending another entry like in Symfony, I have never met that use case yet (it's a very rare need): at worst we have to write twice the same definition, which is acceptable compared to adding complexity to every other use case.
Regarding "you can choose not to use it to replace the previous entry (which is currently impossible)" it is still possible to introduce an option to DI\object() to make that possible.


Make gallery link sharable/copyable

closes #167
#167 also mentions the overwriting of current piece, but i believe that's being worked on in #170

Though I see the motivation, the current behavior is intentional. Without it you may make edits which get over-ridden by reloading the page.


Fix setbufvar() move cursor position in Visual mode

The last change is possibly not needed, as it is matters on failure to find the original window, but it's better to be more consistent anyway.


Support the currently existing features in https://github.com/aws/aws-mwaa-local-runner

Overview
We want to make sure that customers will have the same features they used to have with https://github.com/aws/aws-mwaa-local-runner.
Acceptance Criteria
Add support for the following features:

Resetting database
Testing requirements
Packaging requirements
Test startup script

For more information, check this
Additional Info
N/A

We want to make sure that customers will not have the same features they used to have with

@rafidka You mean "will have", not "will not have", right? 😄

Sorry yeah, you are right, I will update the description.

But generally my question is about amazon-mwaa-docker-images vs aws-mwaa-local-runner. Should we still use aws-mwaa-local-runner for running a local instance of MWAA >= 2.9 or rather start switching to this solution? Is aws-mwaa-local-runner going to be archived or these two will exist together and aim different goals?

The aws-mwaa-local-runner will eventually be deprecated, but for now you can continue using it. The only reason we haven't deprecated it yet is there is a couple of functionalities in aws-mwaa-local-runner that we haven't reported yet to this repo, e.g. requirements packaging, etc. Having said that, if this repo currently already fulfills your need, then by all means use it as your new local runner. Take a look at the README and give it a try and see if it does what you need.

@rafidka get it, thanks for clarification!

The neccessary docker images for mwaa-local-runner seem to have been disappeared from Docker Hub. Was this on purpose?


Update config YAML to remove JSON

Consider removing the escaped JSON string from the configuration and replacing it with nested data fields.
   CTP_POST_BODY: '{
          "destination": {
            "type": "SQS",
            "queueUrl": "<url_to_your_queue>",
         "accessKey": "<your_key>",
         "accessSecret": "<your_secret>",
         "region": "<your_region>"
          },
         "messages": [
         {
             "resourceTypeId": "order"
         }
         ]
    }'

  CTP_POST_BODY:
      destination:
          type: SQS
          queueUrl: "<url_to_your_queue>"
          accessKey: "<your_key>"
          accessSecret: "<your_secret>"
          region: "<your_region>"
      messages:
          - resourceTypeId: order

Not sure that yml supports this for the provider env vars


Reminder binding after registration causes the page to crash

image: casbin/casdoor:v1.78.0
linux
mac
Source code docker

发现有如下报错

It's reproduced for now, I'll fix it.

Clicking this button will cause the OAuthWidget component to re-render. I didn't notice this in the last pr. I'm very sorry for the trouble.

cc @hsluoyz


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 877

Questions ?
Please refer to the Backport tool documentation


A problem in the layers.index_matrix_to_pairs function

Hi,
Thanks for your code sharing.
But I found there are some problems in layers.index_matrix_to_pairs function:
By using the original code, I can't get
[[[0, 3], [1, 1], [2, 2]],
[[0, 2], [1, 3], [2, 1]]]
while inputing [[3,1,2], [2,3,1]].
It works, after I change the code to:
def index_matrix_to_pairs(index_matrix):
# [[3,1,2], [2,3,1]] -> [[[0, 3], [1, 1], [2, 2]],
#                        [[0, 2], [1, 3], [2, 1]]]
replicated_first_indices = tf.range(tf.shape(index_matrix)[1])
rank = len(index_matrix.get_shape())
if rank == 2:
replicated_first_indices = tf.tile(
tf.expand_dims(replicated_first_indices, dim=0),
[tf.shape(index_matrix)[0], 1]
)
return tf.stack([replicated_first_indices, index_matrix], axis=rank)
I don't know either the given example or the code is wrong.

Could you tell me which version of tensorflow  you use? I just learn tensorflow.

I use tf 1.3. Actually, I am also a green hand in tensorflow.
2017-09-05 11:01 GMT+08:00 SHUht<EMAIL_ADDRESS>
Could you tell me which version of tensorflow you use? I just learn
tensorflow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/devsisters/pointer-network-tensorflow/issues/10#issuecomment-327059328,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUMLs09qumPe0Y0YdkdfRQ9Aa8J-iVq1ks5sfLltgaJpZM4PBPdc
.

"dynamic_rnn_decoder = tf.contrib.seq2seq.dynamic_rnn_decoder " Attributerror: 'module' object has no attribute 'dynamic_rnn_decoder'?
who can tell me which tensorflow can solve it?
thank you


fix to support newer conda-build versions

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
With conda-build versions higher than 3.21.7, we are seeing the issue described in https://github.com/open-ce/open-ce-builder/issues/117 with default value of chroot.
Thus setting chroot to blank here, to avoid the error and thus support newer versions of conda-build.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Codecov Report

Merging #142 (2fc2b99) into main (fa4d7a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.05%
==========================================
  Files          23       23
  Lines        2108     2110       +2
==========================================
+ Hits         2026     2029       +3
+ Misses         82       81       -1

Flag
Coverage Δ

unittests
96.16% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

open_ce/build_feedstock.py
95.65% <0.00%> (+0.05%)
:arrow_up:

open_ce/build_tree.py
96.61% <0.00%> (+0.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #142 (2fc2b99) into main (fa4d7a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.05%
==========================================
  Files          23       23
  Lines        2108     2110       +2
==========================================
+ Hits         2026     2029       +3
+ Misses         82       81       -1

Flag
Coverage Δ

unittests
96.16% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

open_ce/build_feedstock.py
95.65% <0.00%> (+0.05%)
:arrow_up:

open_ce/build_tree.py
96.61% <0.00%> (+0.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #142 (471be76) into main (fa4d7a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Current head 471be76 differs from pull request most recent head 0f7a792. Consider uploading reports for the commit 0f7a792 to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.05%
==========================================
  Files          23       23
  Lines        2108     2110       +2
==========================================
+ Hits         2026     2029       +3
+ Misses         82       81       -1

Flag
Coverage Δ

unittests
96.16% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

open_ce/build_feedstock.py
95.65% <0.00%> (+0.05%)
:arrow_up:

open_ce/build_tree.py
96.61% <0.00%> (+0.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #142 (471be76) into main (fa4d7a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Current head 471be76 differs from pull request most recent head 0f7a792. Consider uploading reports for the commit 0f7a792 to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.05%
==========================================
  Files          23       23
  Lines        2108     2110       +2
==========================================
+ Hits         2026     2029       +3
+ Misses         82       81       -1

Flag
Coverage Δ

unittests
96.16% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

open_ce/build_feedstock.py
95.65% <0.00%> (+0.05%)
:arrow_up:

open_ce/build_tree.py
96.61% <0.00%> (+0.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #142 (0f7a792) into main (fa4d7a3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Current head 0f7a792 differs from pull request most recent head 40d63b0. Consider uploading reports for the commit 40d63b0 to get more accurate results

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   96.11%   96.16%   +0.05%
==========================================
  Files          23       23
  Lines        2108     2110       +2
==========================================
+ Hits         2026     2029       +3
+ Misses         82       81       -1

Flag
Coverage Δ

unittests
96.16% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

open_ce/build_feedstock.py
95.65% <0.00%> (+0.05%)
:arrow_up:

open_ce/build_tree.py
96.61% <0.00%> (+0.26%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #142 (ab71b26) into main (d3a0954) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   96.16%   96.16%
=======================================
  Files          23       23
  Lines        2109     2110    +1
=======================================
+ Hits         2028     2029    +1
  Misses         81       81

Flag
Coverage Δ

unittests
96.16% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/conda_utils.py
98.88% <100.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


"type 'int' is not a subtype of type 'String'" during app execution without context

I often see this error and it leaves me puzzled since most errors give a line number where the error actually occurs. All I get is:
I/flutter (27667): Another exception was thrown: type 'int' is not a subtype of type 'String'
How am I supposed to fix an error like this when I've no idea where in the code it occurs?

Could you please post your code?

No because I don't know where in the code the error is referring to. That's exactly the problem...it doesn't indicate where the error is whatsoever.

Then please post the error message fully and mention the 'filename'.dart you are working on.

I don't think you understand what I'm saying at all. That is the entire error message! That's the point. That's what the problem is.

I understand that you were trying to point out a bug in flutter. My intention was to help you in fixing the code, if there were any, that I could help you with.

Yes I realise you're trying to help but you don't seem to have understood my original post at all. My problem is that that is the ENTIRE error message. It's that the error message did not give any more information, nor did it tell me where in my code the error occurred.
Your response was to ask for the whole error message...and where in the code it occurred...!
If I knew that it wouldn't have been a problem in the first place...

Without any response we're unable to make progress here


Add user option to sort interface names RELENG_2_3

Backport of #3685 to RELENG_2_3
Signed-off-by: Phil Davis<EMAIL_ADDRESS>

Someone mentioned this somewhere - maybe in Redmine or Forum?
That triggered me to look at back-porting it, which turned out to be not so difficult. It would be handy to have for people on production systems in the 2.3.* series.


Generate config.json in React

Generate config.json in react (simple mode) and send to native same as advanced mode.
The configuration state managed in React and its more easy and reasonable to manage both of them in one place - one source of true instead sync both of them in both ways.

/cib


Fix payment:0=yes issue on the map

Remove payment:0=yes tags from the map after the release is published.

These tags were removed in late June by user mueschel, like this. We've lost some information on card payment, but overall it's fine.


如何在已经创建好的pai集群中新加入一台机器

新的节点无法创建kubernetes环境:
python paictl.py cluster k8s-bootup -p ~/pai-config/
docker: Error response from daemon: Conflict. The container name "/kubelet" is already in use by container "e45ecf783f38bc6c8c9e13151128c2cb55ff5b741ce54b124e127446696d59e2". You have to remove (or rename) that container to be able to reuse that name.
See 'docker run --help'.

https://github.com/Microsoft/pai/blob/master/docs/paictl/paictl-manual.md#Machine_Add

@qzwlinux 您能按着Create Issue的Template把信息再丰富一下吗？谢谢。
Issue Template
Organization Name:
Short summary about the issue/question:
Brief what process you are following:
How to reproduce it:
OpenPAI Environment: Cluster, one master and two worker node.
OpenPAI version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Hardware (e.g. core number, memory size, storage size, GPU type etc.):
Others:
Anything else we need to know:

Since Fan already provided the resolution, closing the issue. Please feel free to reopen it if you met problem with that document: https://github.com/Microsoft/pai/blob/master/docs/paictl/paictl-manual.md#Machine_Add


Replace pip installation with APT for python-openshift

Description
Let python-openshift be managed with APT instead of PIP. I'm maintaining a repo for various debian flavors but at the moment 20.04 is hardcoded. We'll remain to pull in from the AUR for arch linux.
Checklist

[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[x] All commits contain a well written commit description including a title, description and a Fixes: #XXX line if the commit addresses a particular GitHub issue.
[ ] All workflow validation and compliance checks are passing.

Notes
Resolves tech debt from https://github.com/raspbernetes/k8s-cluster-installation/pull/72

Tested against Ubuntu 20.04 x86 https://gist.github.com/anthr76/7ad52523cb6778fc78057d835b1ce97d#file-gistfile0-txt-L127-L144

Upstream issue tracking:
https://github.com/openshift/openshift-restclient-python/issues/392
https://github.com/openshift/openshift-restclient-python/pull/57/files
https://github.com/openshift/openshift-restclient-python/issues/241
https://github.com/openshift/openshift-restclient-python/issues/271


Update the version of containerd used for testing

Codecov Report

Merging #1875 (55f9812) into main (bc71780) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   68.89%   68.89%
=======================================
  Files         122      122
  Lines       13717    13717
=======================================
  Hits         9451     9451
  Misses       4266     4266


Apache Superset schedule email reports issue

Hello
When I create a new email reports from Apache Superset schedule mail, I'm getting the following OS errors from Celery worker.
How can I solve that issue?
[2022-01-13 17:21:19,871: ERROR/ForkPoolWorker-4] Task email_reports.send[dd4bbba5-cfc4-4b2f-858d-2f3d8fa0a473] raised unexpected: OSError()
Traceback (most recent call last):
File "/python3.8/site-packages/celery/app/trace.py", line 451, in trace_task
R = retval = fun(*args, **kwargs)
File "/python3.8/site-packages/superset/initialization/init.py", line 103, in call
return task_base.call(self, *args, **kwargs)
File "/python3.8/site-packages/celery/app/trace.py", line 734, in protected_call
return self.run(*args, **kwargs)
File "/python3.8/site-packages/superset/tasks/schedules.py", line 528, in schedule_email_report
deliver_slice(
File "/python3.8/site-packages/superset/tasks/schedules.py", line 460, in deliver_slice
report_content = _get_slice_data(slc, delivery_type, session)
File "/python3.8/site-packages/superset/tasks/schedules.py", line 342, in _get_slice_data
response = opener.open(slice_url)
File "/usr/lib64/python3.8/urllib/request.py", line 531, in open
response = meth(req, response)
File "/usr/lib64/python3.8/urllib/request.py", line 640, in http_response
response = self.parent.error(
File "/usr/lib64/python3.8/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/usr/lib64/python3.8/urllib/request.py", line 502, in _call_chain
result = func(*args)
File "/usr/lib64/python3.8/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
OSError
Thanks

Hello @kyarali please provide the Superset version that you are running and any other useful information to reproduce the issue. Thank you

Hello
Apache superset version: 1.3.2
Python version: 3.8
OS Type: RHEL8
Thanks


[PEC-01M] Potential Withdrawal Denial-of-Service

PEC-01M: Potential Withdrawal Denial-of-Service

Type
Severity
Location

Language Specific

ProtectedERC20Gateway.sol:L106

Description:
The ProtectedERC20Gateway::withdrawProtectedTokenWithPermit function will attempt to consume a permit before executing the ERC20::transferFrom operation. Given that permits can be submitted and consumed by anyone, it is possible for a user to detect a substantial ProtectedERC20Gateway::withdrawProtectedTokenWithPermit operation and sabotage it by consuming the permit first.
Impact:
While the Denial-of-Service attack is trivial to perform, its impact is minimal as it would only be important in case a substantial withdrawal is detected and wished to be arbitraged.
Example:
function withdrawProtectedTokenWithPermit(
  address pToken,
  uint256 amount,
  address to,
  uint256 deadline,
  uint8 permitV,
  bytes32 permitR,
  bytes32 permitS
) external {
  IAToken apToken = IAToken(POOL.getReserveData(pToken).aTokenAddress);
  uint256 userBalance = apToken.balanceOf(msg.sender);
  uint256 amountToWithdraw = amount;

  // if amount is equal to type(uint256).max, the user wants to redeem everything
  if (amount == type(uint256).max) {
    amountToWithdraw = userBalance;
  }
  // permit `amount` rather than `amountToWithdraw` to make it easier for front-ends and integrators
  apToken.permit(msg.sender, address(this), amount, deadline, permitV, permitR, permitS);
  apToken.transferFrom(msg.sender, address(this), amountToWithdraw);

  POOL.withdraw(pToken, amountToWithdraw, address(this));
  IPERC20(pToken).withdrawTo(to, amountToWithdraw);
}

Recommendation:
We advise the code to opportunistically perform the IAToken::permit operation, continuing with the ERC20::transferFrom operation regardless of whether the permit succeeds as it may have been consumed by another party.

i think this is a really good catch. after some thinking we decide not to fix it, as:

there is no economic incentive to do so.

the user can always just fallback to use withdrawProtectedToken instead of withdrawProtectedTokenWithPermit, so no actual impact except some potential UX overhead.

even if we enable an opportunistic permit, new user can still be Dos, since they dont have any allowance for the gateway anyway. this problem still exists, just for a smaller set of audience.


Support for providing SSL certificate through labels

This provides support to pass SSL certificate through labels.
Note that as no carriage return is supported in label values passed from the command line, each carriage return should be replaced by the following two characters: "\n". The concept has been taken from the official docker HAProxy image.

I fixed a minor bug and added a few tests.
It's part of the release 1.121

Thanks for merging it.
Concerning your initial comment, I agree that it would be cleaner to add the cert only to the host but I went for the faster to code and thanks to haproxy SSL certificate automatic selection it works properly.

Great! I'll leave it as is for now. Later on, we can work on an improvement that would let us put a certificate specific to a service.