Duplicate deploys with ftl dev

Note that after "info: All modules deployed, watching for changes..." modules continue to deploy.
Unfortunately I wasn't able to replicate this with --log-level=trace after this first time.
🐚 ~/dev/ftl-examples $ ftl dev online-boutique --recreate       main
info: Starting FTL with 1 controller(s)
info:currency: Building module
info:ad: Building module
info:cart: Building module
info:ad: Deploying module
info:currency: Deploying module
info:cart: Deploying module
info:payment: Building module
info:productcatalog: Building module
info:shipping: Building module
info:payment: Deploying module
info:shipping: Deploying module
info:recommendation: Building module
info:productcatalog: Deploying module
info:checkout: Building module
info:controller0: Deployed dpl-cart-515hkq3w24griq2m
info:controller0: Deployed dpl-currency-g54syitdsqqgyz2
info:controller0: Deployed dpl-ad-189gw4hgs7glgecp
info:recommendation: Deploying module
info:checkout: Deploying module
info:controller0: Deployed dpl-payment-pc926s88owsim5m
info:controller0: Deployed dpl-shipping-vir6waj51oy7w9y
info:controller0: Deployed dpl-recommendation-ex39lr3bgs5oqdb
info:controller0: Deployed dpl-productcatalog-17flrebfhph4vkjt
info:controller0: Deployed dpl-checkout-17xyauu86aq03wjj
info: All modules deployed, watching for changes...
info:currency: Building module
info:currency: Deploying module
info:controller0: Reusing deployment: dpl-currency-g54syitdsqqgyz2
info:ad: Building module
info:ad: Deploying module
info:controller0: Reusing deployment: dpl-ad-189gw4hgs7glgecp
info:cart: Building module
info:cart: Deploying module
info:controller0: Reusing deployment: dpl-cart-515hkq3w24griq2m
info:productcatalog: Building module
info:productcatalog: Deploying module
info:controller0: Reusing deployment: dpl-productcatalog-17flrebfhph4vkjt
info:shipping: Building module
info:shipping: Deploying module
info:controller0: Reusing deployment: dpl-shipping-vir6waj51oy7w9y
info:payment: Building module
info:payment: Deploying module
info:controller0: Reusing deployment: dpl-payment-pc926s88owsim5m
info:recommendation: Building module
info:recommendation: Deploying module
info:controller0: Reusing deployment: dpl-recommendation-ex39lr3bgs5oqdb
info:checkout: Building module
info:checkout: Deploying module
info:controller0: Reusing deployment: dpl-checkout-17xyauu86aq03wjj

Close until we see this again, we think this is fixed with the file change transactions

I just saw this again, slightly worse this time in that it is building infinitely:
info:echo: Building module
info:time: Deploying module
info:controller0: Reusing deployment: dpl-time-3dh919rt7ionay2u
info:echo: Deploying module
info:controller0: Reusing deployment: dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info: All modules deployed, watching for changes...
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Deployed dpl-echo-2k8ri477zeu8nqig
info:controller0: Deployed dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-time-3dh919rt7ionay2u
info:controller0: Stopped dpl-echo-2k8ri477zeu8nqig

Disregard! I think this was some other bug I introduced.

Closing again until we see it happen again


Tests for IJupyterSessionManager and IJupyterSession

Write tests for the IJupyterSessionManager and IJupyterSession interfaces to verify that item #10481 is correct.

Closing this off as the main RawJupyterSession work is done along with unit testing. I've split off a few issues for the remaining followup work as I like that better than working with a big meta issue like this. One meta issue specifically covers full stack functional tests for the raw kernel work.


fabricateMarketRedeemStable redeemed amount in aUST and not UST

I would expect this to withdraw 0.5 UST and not 0.5 aUST
This was with 1.1.0-alpha.2 and using bombay-12.
This is how I was calling the function:
fabricateMarketRedeemStable({
    address: 'terra1cq8l6fxx5gfs9qde80f2rcp7n0j020zwffrlx0',
    currency: DENOMS.UST,
    amount: '0.5'
})(addressProvider);

And here is the tx:
https://finder.terra.money/bombay-12/address/terra1cq8l6fxx5gfs9qde80f2rcp7n0j020zwffrlx0

It looks like within the withdraw function itself the amount is changed based on the exchange rate here: https://github.com/Anchor-Protocol/anchor-earn/blob/cfddf82475ddd90323ce8770c2cf7f9dc3577843/src/facade/terra-anchor-earn.ts#L275
But the docs indicate that the amount being passed into that function are denominated in the currency you are specifying.

Hello there, thanks for your report. As far as I understood, you are using message fabricators not anchor-earn itself. But, using the anchor-earn withdraw function will always lead to a withdrawal of less than the amount that you specified (as the doc notes), here is one example https://finder.terra.money/bombay-12/tx/79236004282349B59A74B047E77454C8008DA29B38384C1990EF35B3F613E5A5.
The withdrawal amount here is 0.5.
here is the code for the above example:
const withdraw = await anchorEarn.withdraw({
      amount: '0.5',
      currency: DENOMS.UST,
    });

I think you are using message fabricators that withdraw aUST and the denom there, represent market denomination, not currency. Please instantiate anchor-earn and use withdraw function like the above code snippet.

Yes, we are using fabricators on purpose since we are generating the tx to be serialized and signed elsewhere. We require specifying the UST amount to be withdrawn vs. the aUST amount. The confusing part is that both deposit and withdraw take an amount and currency param but only deposit actually uses that currency for the amount.

If you use anchor-earn for only fabricators, I recommend using anchor.js.
If you want to have your own customSigner or customBroadcaster, anchor-earn supports that.
Besides that, fabricators have nothing to do with this function that you mentioned.
https://github.com/Anchor-Protocol/anchor-earn/blob/cfddf82475ddd90323ce8770c2cf7f9dc3577843/src/facade/terra-anchor-earn.ts#L275
For the confusion, the currency related to fabricators is market currencies, which for now, we have only UST.

My main question is:
How would I specify that I want to withdraw 100 UST for example (knowing that I would get less after fees).
is the only way to calculate the exchangeRate between aUST and UST like anchor-earn is doing here: https://github.com/Anchor-Protocol/anchor-earn/blob/cfddf82475ddd90323ce8770c2cf7f9dc3577843/src/facade/terra-anchor-earn.ts#L275

yes exactly like that. My point was, fabricateMarketRedeemStable withdraws the amount you specified in aUST denom; if you need to get it in UST denom, you have to calculate it like that function you mentioned.

Thanks for clarifying. My point was that the way the params are documented in the code and the inconsistency between deposit and redeem fabricators made that confusing :)

Thanks for the report, We will reflect that on the document. May I close this issue?


TypeError: Cannot read property 'forEach' of undefined

When I scan my whole home directory, htmlhint will eventually stop with this error message:
.../node_modules/htmlhint/bin/htmlhint:242
        files.forEach(function(file){
             ^

TypeError: Cannot read property 'forEach' of undefined
    at .../node_modules/htmlhint/bin/htmlhint:242:14
    at FSReqWrap.oncomplete (fs.js:82:15)

$ npm view htmlhint version
0.9.9

Your system is mac?

Try :
npm i htmlhint@beta -g

No, my system is Linux (Ubuntu 14.04). htmlhint-0.9.10 runs through a lot further. Thanks!


"cd" is wrong

It says "cd LocalFunctionsProject", but should be "cd LocalFunctionProject" (no s)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40b416d5-6ea5-39a5-9a2c-ab188d00a686
Version Independent ID: 855c85f7-53b3-59a2-3f42-fbccbba07d32
Content: Create a function in Azure that responds to HTTP requests
Content Source: articles/azure-functions/functions-create-first-azure-function-azure-cli.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@mperdeck Thanks for the feedback. We are investigating the issue and will update you shortly.

@mperdeck Thanks for catching that! We have worked up a PR to address, which once merged should reflect in a couple of hours.


Implement native IAM operations for GCS.

This change is needed to support IAM conditions. They have proven the
google::cloud::Iam* object to not be versatile enough to accomodate
for future protocol changes. In order to make this a bit more
future-proof, a decision has been made to stick with the low-level,
native representation.
The native operations use raw json underneath, so that even if the
protocol is exptended, fields aren't silently dropped.

This change is

This will be split.


Create dataset-description values

Description of datasets. Gets a match-count for spaCy matcher objects. This allows us rather complicated rules: https://spacy.io/usage/rule-based-matching#phrasematcher
Implemented counts for occupations, gendered terms, religions and names.
Might want to extract some of the functions to a more general utility file or similar, if we want e.g. #51 to share the codebase.
In future PRs:

Visualisations
General benchmarking utility

Missing:

Tests
Visualisations

[ ]  An approximation on speed (potentially test with dict if too slow)

176 seconds on 1% of DAGW on an M1 👍

Mismatch in black version - update to the one in requirements in main

Checks fail because of a dependency-incompatability with dacy. @KennethEnevoldsen, anything I can do here? 🙏

ERROR: Cannot install -r requirements.txt (line 12), dacy, spacy<=3.3.0 and >=3.1.4 and transformers~=4.16.2 because these package versions have conflicting dependencies.

Huh, right now it's a triple-dependency problem.
In requirements.txt we have:
spacy<=3.3.0 and >=3.1.4```

`dacy 1.3.0 depends on spacy<3.3.0 and >=3.2.0`
`spacy-transformers 1.0.6 depends on transformers<4.10.0 and >=3.4.0`

Yeah, that reduces the dependency conflict to:
`ERROR: Cannot install dacy and transformers~=4.16.0 because these package versions have conflicting dependencies.
438
439
The conflict is caused by:
440
The user requested transformers~=4.16.0
441
spacy-transformers 1.0.6 depends on transformers<4.10.0 and >=3.4.0`

Thanks for looking into this. Yea so even changing to the newest version of spacy transformers would not solve the problem.
Something like this should though
# custom install of DaCy where we only use install the requirements needed for the lookup tables:
# should not be necessary after: https://github.com/centre-for-humanities-computing/DaCy/pull/98
dacy --install-option="--no-deps"
pandas>=1.0.0,<2.0.0

(in requirements.txt)
Then you can also remove the downgrade of wasabi.

Thanks for the thorough code review! Dependencies are still failing, though:
ERROR: dacy 1.3.0 has requirement wasabi<0.9.0,>=0.8.2, but you'll have wasabi 0.9.0 which is incompatible. in spite of --no-deps?
ERROR: spacy-transformers 1.0.6 has requirement transformers<4.10.0,>=3.4.0, but you'll have transformers 4.16.2 which is incompatible. – which we don't have a solution for?

I don't know how you do the local install? You should be using the pip install -e .
I don't know if you can specify torch<1.11.0,>=1.10.2 try using torch>=1.10.2,<1.11.0, but there should be a working torch version for linux.
It seems like to no deps flag is not working in requirements.txt, but you should be able to resolve it in the setup.py which install the package. What you need to do here is remove the dependency from the requirements (and setup.cfg) and have it install dacy without dependencies (something like this) in the setup.py.

@KennethEnevoldsen, ready for mere? :-)

@martbern you can also press the "rerequest review" top right corner next to my name ;)

I'm not sure why Spacy is needed for this. It looks like we're simply counting word occurrences without using any advanced processing?
If thats the case, then I think would could improve both code complexity and performance by simply using a reverse index (keys as words, values as a list of categories the word belongs to). Scanning a doc and looking up words should run in practically O(n) as most words will belong to a small number of categories.

Hmm, yeah, currently we aren't using any of the more advanced processing steps that Spacy affords us.
That said, spacy also allows us to just use a term list – so maybe convert the regex to a term list, but maintain spacy in case we want to do something more complicated later? What do you guys think, @KennethEnevoldsen, @mollerhoj?

I'm not sure why Spacy is needed for this. It looks like we're simply counting word occurrences without using any advanced processing?

You are completely correct. There is two main advantages here.

SpaCy tokenizer is the best tokenizer for Danish text (at least tested on DDT) handling a wide variety of edge cases. Stanza's is also quite good, but as it is neural is fails in weird ways which is somtimes unpredictable.

Why use match patterns instead of a dict then?

It allow us to quickly transition the extraction into using e.g. POS-tags. I allow us to do matches on sequence of text e.g. "___ was very happy". However I agree in its current form it seems silly, but the idea is that this approach extends easier simply forcing the user to write new match patterns as opposed to a list.

Okay both those points make sense to me. I'm not sure how if the O(n*m) runtime of this approach is prohibitive or not, but it should be rather easy to parallelize if it becomes a problem.

The huggingface .apply  has parallellisation across docs - I can do 10% of DAGW in 10 minutes on my M1 👍
@KennethEnevoldsen, I think it's ready for merge – lemme know if you have corrections.

The huggingface .apply has parallellisation across docs - I can do 10% of DAGW in 10 minutes on my M1 👍
@KennethEnevoldsen, I think it's ready for merge – lemme know if you have corrections.

That sounds extremely slow unfortunately. Actually surprised that its that slow

On a single core or multiple cores?

Huh, damn. That's with 16 jobs.
Some of the docs are way larger than others, so it spends about 20% of the time waiting for the last thread.
Is it a dealbreaker for this?

Let us merge it for now and sample from the data it should be fast enough and 10% of DAGW in 10 minutes gives is a sample size of 1B words in <1 hour using 64 cpus - which should be more than enough to get an estimate of the balance in the corpora.
If performance becomes a problems we will go back and redo this.
This of course means that we can use this as a pornographic filter, but that was also never the intention with the implementation. If this shows a problem with pornographic domains, then we can implement a specific pornographic filter.

SGTM

SGTM

Acronyms are bad, non-standard acronyms are worse ;-)
Haha, thanks for the reviews!


browser.explore() doesn't exist

Bug report

Node Version: v6.9.5
Protractor Version: 5.1.1
Angular Version: 2.4.3
Browser(s): Chrome
Operating System and Version macOs Sierra 10.12.3 (16D32)

Your protractor configuration file
/**
 * @author: @AngularClass
 */

require('ts-node/register');
var helpers = require('./helpers');

// creds
var creds = require('../.tip.credentials.json');

// screenshot reporter
var HtmlScreenshotReporter = require('protractor-jasmine2-screenshot-reporter');
var reporter = new HtmlScreenshotReporter({
  dest: 'e2e-report/screenshots',
  filename: 'mgmt-console.html',
  fixedScreenshotName: true,
  takeScreenshotsOnlyOnFailures: false,
  userCss: 'my-report-styles.css',
  pathBuilder: function(currentSpec, suites, browserCapabilities) {
    // will return chrome/your-spec-name.png
    return browserCapabilities.get('browserName') + '/' + currentSpec.fullName.split(' ').join('-');
  },
  metadataBuilder: function(currentSpec, suites, browserCapabilities) {
    return { id: currentSpec.id, os: browserCapabilities.get('browserName') };
  }
});

exports.config = {
  baseUrl: 'http://localhost:3000/',

  // use `npm run e2e`
  specs: [
    helpers.root('src/**/**.e2e.ts'),
    helpers.root('src/**/*.e2e.ts')
  ],
  exclude: [],

  framework: 'jasmine2',

  allScriptsTimeout: 110000,

  jasmineNodeOpts: {
    showTiming: true,
    showColors: true,
    isVerbose: false,
    includeStackTrace: false,
    defaultTimeoutInterval: 400000
  },
  directConnect: true,

  capabilities: {
    'browserName': 'chrome',
    'chromeOptions': {
      'args': ['show-fps-counter=true']
    }
  },

  beforeLaunch: function() {
    // setup report before any starts
    return new Promise(function(resolve){
      reporter.beforeLaunch(resolve);
    });
  },

  afterLaunch: function(exitCode) {
    // close report at this point
    return new Promise(function(resolve){
      reporter.afterLaunch(resolve.bind(this, exitCode))
    });
  },

  onPrepare: function() {
    // omitted for brevity
    ....
  },

  /**
   * Angular 2 configuration
   *
   * useAllAngular2AppRoots: tells Protractor to wait for any angular2 apps on the page instead of just the one matching
   * `rootEl`
   */
   useAllAngular2AppRoots: true
};

A relevant example test
// app.e2e.ts
describe('App', () => {

  let appPage;

  beforeAll(() => {
    appPage = new AppPage();
    appPage.load();
    console.log('\x1Bc');
  });

  // cleaned up version

  it('should find `menu` component', () => {
    browser.explore();
    expect(appPage.hasMenu()).toBeTruthy();
  });

});

// app.e2e-page.ts
export class AppPage {
  menuElement;

  constructor(){
    this.menuElement = element(by.css('.menu'));
  }
  load(){
    browser.get('/');
  }

  hasMenu(){
    return this.menuElement.isPresent();
  }
}

Output from running the test
...

[14:22:33] D/launcher - Running with --troubleshoot
[14:22:33] D/launcher - Protractor version: 5.1.1
[14:22:33] D/launcher - Your base url for tests is http://localhost:3000/
Report destination:   e2e-report/screenshots/mgmt-console.html
[14:22:33] I/launcher - Running 1 instances of WebDriver
[14:22:33] I/direct - Using ChromeDriver directly...
[14:22:35] D/runner - WebDriver session successfully started with capabilities Capabilities {
  'acceptSslCerts' => true,
  'applicationCacheEnabled' => false,
  'browserConnectionEnabled' => false,
  'browserName' => 'chrome',
  'chrome' => { chromedriverVersion: '2.27.440174 (e97a722caafc2d3a8b807ee115bfb307f7d2cfd9)',
  userDataDir: '/var/folders/cg/cwn0yp852fx0lyl35brm075r0000gn/T/.org.chromium.Chromium.wA0VFy' },
  'cssSelectorsEnabled' => true,
  'databaseEnabled' => false,
  'handlesAlerts' => true,
  'hasTouchScreen' => false,
  'javascriptEnabled' => true,
  'locationContextEnabled' => true,
  'mobileEmulationEnabled' => false,
  'nativeEvents' => true,
  'networkConnectionEnabled' => false,
  'pageLoadStrategy' => 'normal',
  'platform' => 'Mac OS X',
  'rotatable' => false,
  'takesHeapSnapshot' => true,
  'takesScreenshot' => true,
  'unexpectedAlertBehaviour' => '',
  'version' => '56.0.2924.87',
  'webStorageEnabled' => true }
[14:22:35] D/runner - Running with spec files /dev/web/mgmt-console-web-app/src/app/app.e2e.ts,/dev/web/mgmt-console-web-app/src/app/app.e2e.ts
[14:22:43] E/launcher - Error: TSError: ⨯ Unable to compile TypeScript
src/app/app.e2e.ts (26,13): Property 'explore' does not exist on type 'IBrowser'. (2339)

...

I did look up on this both on SO and Issues, but no luck. Apologies if this is a duplicate or in an inappropriate place.
Thanks in advance.

Hi there,
looking at at the ProtractorBrowser class declaration file, I am also missing browser.manage() and thus browser.manage().addCookie(). Now that the Protractor API differs from the Selenium-Webdriver API (DefinitelyTyped Selenium-Webdriver addCookie() declaration) it neither helps to install the @types/selenium-webdriver types. Am I missing something?

Interesting, I'm not able to reproduce with a small example:
require('ts-node/register');

module.exports.config = {
  framework: 'jasmine',
  directConnect: true,
  capabilities: {
    browserName: 'chrome'
  },
  specs: [ 'spec.ts' ],

  // You could set no globals to true to avoid jQuery '$' and protractor '$'
  // collisions on the global namespace.
  noGlobals: true
};

import {browser, element, by, By, $, $$, ExpectedConditions} from 'protractor';

describe('App', () => {
  let appPage;

  it('should allow usage of `browser.explore`', () => {
    browser.get('http://angularjs.org');
    // manage works as well
    browser.explore();

    expect($('input').isPresent()).toEqual(true);
  });
});

What typescript version are you using?

I'm using Typescript 2.0.10.
I just tested your example and it truly does work, well partially because when I try to fetch an element by id, it gets stuck and eventually timeout.
Check below:
➜  prt npm test

><EMAIL_ADDRESS>pretest /dev/web/prt
> npm run tsc

><EMAIL_ADDRESS>tsc /dev/web/prt
> tsc

><EMAIL_ADDRESS>test /dev/web/prt
> protractor conf.js

[10:20:19] I/launcher - Running 1 instances of WebDriver
[10:20:19] I/direct - Using ChromeDriver directly...
Started
[10:20:25] I/protractor -
[10:20:25] I/protractor - ------- Element Explorer -------
[10:20:25] I/protractor - Starting WebDriver debugger in a child process. Element Explorer is still beta, please report issues at github.com/angular/protractor
[10:20:25] I/protractor -
[10:20:25] I/protractor - Type <tab> to see a list of locator strategies.
[10:20:25] I/protractor - Use the `list` helper function to find elements by strategy:
[10:20:25] I/protractor -   e.g., list(by.binding('')) gets all bindings.
[10:20:25] I/protractor -
Starting debugger agent.
Debugger listening on [::]:5858
>
element(by.id(''))         element(by.css(''))        element(by.name(''))       element(by.binding(''))
element(by.xpath(''))      element(by.tagName(''))    element(by.className(''))

> element(by.id('the-basics'))

> element(by.id('the-basics'))FA Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.

Failures:
1) App should find `menu` component
  Message:
    Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
  Stack:
    Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
        at ontimeout (timers.js:365:14)
        at tryOnTimeout (timers.js:237:5)
        at Timer.listOnTimeout (timers.js:207:5)
  Message:
    Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
  Stack:
    Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
        at ontimeout (timers.js:365:14)
        at tryOnTimeout (timers.js:237:5)
        at Timer.listOnTimeout (timers.js:207:5)

1 spec, 1 failure
Finished in 87.107 seconds

[10:21:49] I/launcher - 0 instance(s) of WebDriver still running
[10:21:49] I/launcher - chrome #01 failed 1 test(s)
[10:21:49] I/launcher - overall: 1 failed spec(s)
[10:21:49] E/launcher - Process exited with error code 1
npm ERR! Test failed.  See above for more details.
➜  prt

Thanks for you reply anyway @NickTomlin

Interesting, thanks for reporting back! Let's focus on the typing issue first and then we can always create a second issue for the hanging inside browser.explorer. Do you feel like it is resolved? I'm not sure what differs between our repos but it sounds like an issue with an out of date typings dep?
@stefan-- I'm able to use browser.manage as well, can you reproduce using my small example, or produce an example of your own? If you are able to do so, please open up an additional issue. Thanks!

@NickTomlin yes, I left it open for you to make a decision whether to keep it in loop or not. I have setup debugging inside VSCode which is actually more user friendly to my QA team than dealing with the terminal :).
So finally by replicating your small example, this is what I have in my package.json

Ah, that's due to my example being slightly out of date. https://github.com/angular/protractor/commit/4752ad1287af536c6dd442dd8c74546f978627d9 fixes this issue by pinning the jasmine typings.
I'm going to go ahead and close this since the original issue doesn't seem to be a problem any more. Please feel free to open up a new issue for the hanging in the explorer (or let me know if this is still an issue and I can re-open it).
Thanks! 😄


Make it possible to access public ports within starlark

Background & motivation
Context: https://github.com/kurtosis-tech/ethereum-package/pull/363#discussion_r1404129138
Desired behaviour
An api in starlark that exposes both private and public ports.
How important is this to you?
Painful; the lack of this feature makes using Kurtosis frictionful.
What area of the product does this pertain to?
CLI: the Command Line Interface

Makes sense. Definitely need to account for this use case somehow - lots of web based applications are unusable in kurtosis without it.

https://discord.com/channels/783719264308953108/1131048810861314169/1226727014854033539

Right now I can access:
service.ip_address
service["port_name"].number

But I'm missing very much that:
service["port_name"].public_number
Also, I would need that to be available inside the ServiceConfig itself same than ip_address to be able to set envvars with this value. This breaks many web apps that needs to know its own host/port (I already know the host) and that can not be proxied.
I guess that at the same point/with the same logic that you can preallocate the ip_address you should be able to do the same for the port as well !


Fixes #374 - logging add_to_input_history if args.message is used.

Fixes https://github.com/paul-gauthier/aider/issues/374

btw. this is how I am testing it https://gist.github.com/gwpl/8faa1b314c7d5905dd23ce041d65dc79 :
# https://github.com/paul-gauthier/aider or when working on a patch on fork:
docker build --file docker/Dockerfile -t aider-image .
# to launch pytest:
docker run -it --volume $(pwd):/app --entrypoint /bin/bash aider-image -c "pip install pytest && pytest"

of course for faster runs I have docker image with already included pytest. However if someone want's just to copy&paste, above line is robust as will install pytest in case it's missing.


Memory leak again

Master branch doesn't have such issue.
The issue doesn't happen when ligature option been turned off.

Not an issue. The buffer is still not full, so it keeps growing.


Suggestion: Center Preferences window on first open

On first run, when opening the Preferences window, it appears at the upper-right corner of the screen. This looks a little odd, especially on a very large display.
Preconditions: First run of the app, Preferences never opened
What I did: Hit Command-comma to open the Preferences window
What I expected: The Preferences window opens up, centered in the same screen as the NNW main window
What happened: The Preferences window opens up at the very top-left corner of the display
Note: I have only one display connected to this machine, so I don't know if it would open on the same display as the NNW main window or not. Might be worth checking that too if you decide to make changes in this area.

Decided to punt till 5.0.1.


Add WPT appendix listing all test results by section

See the Shepherd test results, nicely grouped by spec section, versus the "everything at once in alpha order" chaos of the wpt.fyi results.
I should add an Appendix that looks like the shepherd results.

That would be excellent.
Is there a way to choose whether the stable or experimental versions of browsers are tested?

Now that drafts.csswg.org is back up, I see the same thing there: CSS Color 4 has no test result banner while CSS Color 5 does.

So the Shepherd tests have bitrotted and are no longer useful - tests added in the last year or so are not visible in the test report and also can't be run, so there are no results. Thus, the little test result icon at the top of the spec is currently actively misleading.
However, the automatically formatted "by spec section" is exceptionally useful in terms of presenting a CR implementation report and also for checking spec coverage.
The WPT tests require the extra step of adding <wpt> elements into the bikeshed source, which wasn't needed in Shepherd (the links were from the test to the spec); however having done so, there is now a nice per-section list of tests which looks readily harvestable to build an implementation report (appendix, or standalone spec; both would be useful).
However, the WPT tests have the disadvantage that tests for all levels are in the one folder, which requires spec-editor effort to add <wpt-ignore> blocks for older and newer levels.

I should also add that, based on a recent experience where WPT were re-organized, it is now harder to write test for just one specific section because they will get merged with others. The emerging pattern seems to be "one parsing test for all valid values of one property".
However, I would still love to see this bikeshed-generated report because apparently fixing the Shepherd-generated ones will require additional rounds of future funding and future work so does not seem likely to happen in the near term.
An example of how far apart the WPT and Shepherd views of test status are:

Shepherd says zero tests; WPT says 3160 tests.


Synchronized consume method in AbstractCacheRateLimiter impact performance

Currently we are using 1.7.2 which is similar with AbstractCacheRateLimiter  in latest version. The repository we use is redis.
We did performance test. With 1.7.2, the TPS is 600+. After remove synchronized , it is up to 2000+.
In AbstractCacheRateLimiter, it has a synchronized method. In redis implementation, there is no object shared among threads. This method is invoked by each incoming request.

@addozhang
I think that the synchronized method is important otherwise we might miss consumptions.

But in RedisRateLimiter, both RateLimiterErrorHandler and RedisTemplate are thread-safe. It is not necessary to use synchronized.

Hi, @addozhang we recently changed the code in #108 and it should has better performance.
Can you test it?

Closing due inactivity

@lchayoun Why you think remove synchronized method, it might miss consumptions.

@Fangfeikun Let me answer it. synchronized is usually used in race condition. ZuulFilter should be stateless object among requests. RateLimiter object used in RateLimitPreFilter should be stateless object too. Otherwise, all requests in this filter will wait for the monitor of RateLimiter.

@lchayoun Sorry for late reply.
I am confused. What is protected by synchronized?  In RedisRateLimiter, both RateLimiterErrorHandler and RedisTemplate are thread-safe. There are no objects cannot be shared among threads.

@addozhang How do you solve this? remove synchronized key word has any problem?

@taxus1 yes, by removing synchronized and no any other problem found.

@addozhang thanks


version 1.4 ignore header

this is<EMAIL_ADDRESS>but I see github, it should three args
and I install guacamole-common-js@1.3.1,it had three args

Mh I'm unsure how this happened. The distributable files were regenerated after I updated from upstream, so not sure how it ended up with just one argument. I just regenerated them again and now everything seems in order:
Guacamole.HTTPTunnel = function(tunnelURL, crossDomain, extraTunnelHeaders) {

I just published these as a patch 1.4.0-a. Thanks for pointing this out and apologies for the inconvenience!

Thank you for your quick reply

The extraTunnelHeaders is not sent while making a request in 1.4.x
so I did fix it by restoring version 1.3.1


Note regarding ARMC5 & added IAR usage details

Made the following doc updates:

Added clarification regarding the installation of the ARM Compiler 5 on 64-bit Linux machines
Added an example WIndows path to the IAR toolchain information
My text editor removed the trailing spaces at the end of lines

@bridadan I amended the Added an example path to the IAR toolchain commit with the changes!

@yennster Could you please rebase?

@yennster Bump

@screamerbg Done!

@bridadan Should be good now

@yennster Thanks!


Adding ENF (Explicit Network Feedback)

Coverage decreased (-0.3%) to 82.501% when pulling 49283893ce3b26825b78c93cb4ace6e39971b4f7 on palerikm:master into d9b6b5df736c7bd071399aa631907a6d91193d68 on NATTools:master.


Create a new "TempDir" option for atomic write

The current atomic write is somewhat broken as the temporary files are
created inside the base directory, and so count as potential keys (and
can conflict). Move these temporary files in the TempDir specified by
the user so that they can't conflict with future keys.
Note that the TempDir must be on the same device/partition/mount or the
atomic Rename will fail across partition.
Atomic write will not happen if TempDir is left empty.

Added documentation for TempDir. PTAL


Added custom @Generated annotation

In this PR, which follows https://github.com/Netflix/dgs-codegen/pull/424 (and https://github.com/Netflix/dgs-framework/discussions/1147#discussioncomment-3354730), I'm adding a custom @Generated method. It appears that in order for Jacoco to ignore code annotated with @Generated, the annotation must have a CLASS/RUNTIME retention, and the javax.annotation.Generated are SOURCE retention.
In this PR the --add-generated-annotation flag will create a custom @Generated annotation with the CLASS retention, and will annotate all generated code with that annotation.
The PR also uses a more solid testing strategy, which verifies the generated AST (and not just the generated text), to catch cases where multiple classes that require annotation are stored in a single file.

These changes look good to me. Thanks for the PR!

Completes the discussion in https://github.com/Netflix/dgs-codegen/issues/420


Question: Going from ipynb to .ju.py

Hi @AbaoFromCUG
Thanks for putting this together.
I'm interested how you work with current notebook files that you want to edit and keep in sync.

I used jupytext to convert from ipynb to a py file  - Is there a way of directly creating a .ju.py from a .ipynb within neopyter ?
how do you keep the ipynb and ju.py in sync ?
have you considered integrating jupytext in some fashion ?

Thanks

In my practices,  .ju.py files as souce file, and .ipynb as temporary file,  my version control system only track .ju.py file.
Current sync mode only support one-way synchronization, which means that .ju.py=> .ipynb, support two-way synchronization is complex, cann't support in a short term
jupytext  use a “virtual notebook” in Jupyter lab, I think it is a better design than Neopyter, because Neopyter require a real .ipynb file. I will support it later.

``
This is my work flow

prepare work

start jupyter lab via jupyter lab command and open in browser, different jupyter lab port identify different project
start neovim in terminal, write neopyter's config in  .neoconf.json , see https://github.com/SUSTech-data/neopyter/blob/master/.neoconf.json
Notice: the current work directories of neopyter and JupyterLab could be different, because JupyterLab may run in server in my case

new .ju.py

create same name .ipynb in jupyterlab side
create same name .ju.py in neovim
Start edit

open .ju.py

if there is a same name .ipynb, which will be opened in jupyterlab automatically
if there is not the same name notebook, I will execute :Neopyter sync current to force sync with current opened notebook (In temporary use case)

Currently, .ipynb is temporary file, should only be used to preview/execute


Add missing ConfigurationScriptSource hierarchy and Automate models

See https://github.com/ManageIQ/manageiq/pull/13879
When adding (and rebasing and rebasing and rebasing) #13879, the changes to ConfigurationScriptSource` model hierarchy were dropped.
This adds the model hierarchy back in and adds the appropriate automate models.
This also fixes the AnsibleTower inventory collection to specify the correct models in the InventoryCollectionDefault, the Parser (for credential records), and the Refresher spec (for ConfigurationScriptSource).

just needs the specs fixed.

D'oh, I fixed refresher_spec and missed refresher_v2_spec.


K8S-PXC-257: Smart Update

Test name
Status

recreate
passed

storage
passed

init-deploy
passed

big-data
passed

scaling
passed

scaling-proxysql
passed

self-healing
passed

limits
passed

upgrade
passed

demand-backup
passed

monitoring
passed

self-healing-advanced
passed

upgrade-consistency
passed

monitoring-2-0
passed

security-context
passed

operator-self-healing
passed

affinity
passed

one-pod
passed

scheduled-backup
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

init-deploy
failed

big-data
passed

scaling
passed

recreate
passed

storage
failed

limits
failed

monitoring
passed

scaling-proxysql
passed

monitoring-2-0
passed

demand-backup
passed

self-healing
passed

upgrade
passed

affinity
passed

upgrade-consistency
passed

self-healing-advanced
passed

security-context
passed

one-pod
failed

auto-tuning
passed

operator-self-healing
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

big-data
failed

recreate
passed

scaling
passed

init-deploy
failed

self-healing
passed

limits
passed

scaling-proxysql
passed

monitoring
passed

demand-backup
passed

upgrade
passed

self-healing-advanced
passed

monitoring-2-0
passed

upgrade-consistency
passed

operator-self-healing
passed

affinity
passed

security-context
failed

one-pod
passed

auto-tuning
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

big-data
passed

recreate
passed

init-deploy
failed

scaling
passed

limits
passed

monitoring
failed

self-healing
passed

scaling-proxysql
passed

monitoring-2-0
passed

upgrade
passed

demand-backup
passed

self-healing-advanced
failed

affinity
passed

upgrade-consistency
passed

operator-self-healing
passed

security-context
passed

one-pod
failed

auto-tuning
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

scaling
passed

big-data
passed

init-deploy
failed

recreate
passed

limits
passed

scaling-proxysql
passed

self-healing
passed

upgrade
passed

monitoring
passed

demand-backup
passed

self-healing-advanced
passed

monitoring-2-0
passed

upgrade-consistency
passed

security-context
passed

operator-self-healing
passed

affinity
passed

scheduled-backup
failed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

big-data
passed

init-deploy
failed

storage
passed

scaling
passed

recreate
passed

limits
passed

monitoring
passed

scaling-proxysql
passed

self-healing
passed

monitoring-2-0
passed

upgrade
passed

demand-backup
passed

self-healing-advanced
passed

upgrade-consistency
passed

affinity
passed

security-context
passed

one-pod
passed

operator-self-healing
passed

auto-tuning
passed

scheduled-backup
passed

proxysql-sidecar-res-limits
passed

Test name
Status

big-data
passed

init-deploy
failed

storage
passed

scaling
passed

recreate
passed

limits
passed

scaling-proxysql
passed

self-healing
passed

upgrade
passed

monitoring
failed

demand-backup
passed

self-healing-advanced
failed

upgrade-consistency
passed

operator-self-healing
passed

security-context
passed

monitoring-2-0
passed

scheduled-backup
failed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

Test name
Status

Test name
Status

storage
passed

big-data
passed

init-deploy
failed

scaling
passed

recreate
passed

limits
passed

monitoring
passed

self-healing
passed

scaling-proxysql
passed

upgrade
passed

demand-backup
passed

monitoring-2-0
passed

self-healing-advanced
failed

upgrade-consistency
passed

affinity
passed

security-context
failed

operator-self-healing
passed

one-pod
passed

scheduled-backup
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

Test name
Status

storage
passed

recreate
passed

scaling
passed

init-deploy
failed

big-data
passed

limits
passed

monitoring
failed

self-healing
passed

scaling-proxysql
passed

monitoring-2-0
failed

affinity
passed

demand-backup
failed

upgrade
passed

one-pod
failed

self-healing-advanced
passed

auto-tuning
passed

upgrade-consistency
passed

security-context
passed

scheduled-backup
failed

operator-self-healing
passed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

big-data
passed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

Test name
Status

init-deploy
failed

storage
passed

recreate
passed

big-data
passed

scaling
passed

limits
passed

monitoring
passed

self-healing
passed

scaling-proxysql
passed

demand-backup
passed

monitoring-2-0
passed

upgrade
passed

self-healing-advanced
passed

upgrade-consistency
passed

affinity
passed

security-context
passed

operator-self-healing
passed

one-pod
passed

scheduled-backup
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

scaling
failed

big-data
failed

scaling-proxysql
passed

self-healing
failed

upgrade
passed

self-healing-advanced
failed

operator-self-healing
passed

upgrade-consistency
passed

security-context
failed

Test name
Status

scaling
passed

big-data
passed

storage
passed

recreate
passed

init-deploy
failed

limits
passed

scaling-proxysql
passed

self-healing
passed

monitoring
passed

demand-backup
passed

upgrade
passed

monitoring-2-0
passed

self-healing-advanced
passed

upgrade-consistency
passed

affinity
passed

security-context
passed

one-pod
passed

operator-self-healing
passed

auto-tuning
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

Test name
Status

recreate
passed

big-data
failed

storage
failed

init-deploy
failed

scaling
failed

limits
passed

scaling-proxysql
passed

monitoring
passed

self-healing
failed

upgrade
passed

demand-backup
failed

self-healing-advanced
failed

monitoring-2-0
passed

operator-self-healing
passed

upgrade-consistency
passed

security-context
failed

affinity
passed

one-pod
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

scheduled-backup
failed

Test name
Status

init-deploy
failed

recreate
passed

big-data
failed

scaling
failed

storage
passed

limits
passed

scaling-proxysql
passed

self-healing
failed

monitoring
passed

upgrade
passed

demand-backup
failed

self-healing-advanced
failed

monitoring-2-0
passed

operator-self-healing
passed

upgrade-consistency
passed

security-context
failed

affinity
passed

one-pod
failed

scheduled-backup
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

init-deploy
failed

recreate
passed

big-data
failed

scaling
failed

storage
passed

limits
passed

scaling-proxysql
passed

self-healing
failed

upgrade
passed

self-healing-advanced
failed

monitoring
passed

demand-backup
failed

operator-self-healing
passed

upgrade-consistency
passed

security-context
failed

monitoring-2-0
failed

affinity
passed

one-pod
failed

scheduled-backup
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

storage
passed

recreate
passed

scaling
passed

init-deploy
failed

big-data
passed

limits
passed

scaling-proxysql
passed

self-healing
passed

upgrade
passed

demand-backup
passed

self-healing-advanced
failed

monitoring
failed

upgrade-consistency
passed

operator-self-healing
failed

security-context
passed

monitoring-2-0
failed

affinity
failed

one-pod
passed

auto-tuning
failed

scheduled-backup
passed

proxysql-sidecar-res-limits
failed

Test name
Status

recreate
passed

scaling
failed

big-data
failed

storage
passed

scaling-proxysql
passed

self-healing
failed

self-healing-advanced
passed

demand-backup
failed

upgrade
passed

operator-self-healing
passed

upgrade-consistency
passed

security-context
failed

scheduled-backup
failed

Test name
Status

big-data
failed

init-deploy
failed

storage
failed

scaling
failed

recreate
passed

limits
passed

scaling-proxysql
passed

monitoring
passed

upgrade
passed

monitoring-2-0
passed

demand-backup
failed

affinity
passed

upgrade-consistency
passed

security-context
failed

one-pod
failed

auto-tuning
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

self-healing
failed

self-healing-advanced
failed

operator-self-healing
failed

Test name
Status

storage
passed

big-data
passed

scaling
passed

recreate
passed

init-deploy
passed

self-healing
failed

scaling-proxysql
passed

limits
passed

demand-backup
passed

upgrade
passed

self-healing-advanced
failed

upgrade-consistency
passed

monitoring
passed

security-context
passed

operator-self-healing
passed

monitoring-2-0
passed

scheduled-backup
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

Test name
Status

scaling
passed

big-data
passed

recreate
passed

init-deploy
failed

storage
passed

limits
passed

scaling-proxysql
passed

self-healing
failed

demand-backup
passed

upgrade
passed

monitoring
passed

self-healing-advanced
passed

upgrade-consistency
passed

monitoring-2-0
passed

security-context
passed

operator-self-healing
passed

affinity
passed

scheduled-backup
failed

one-pod
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

PXC operator docker - perconalab/percona-xtradb-cluster-operator:PR-369-663453c2

Test name
Status

scaling
passed

big-data
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
passed

security-context
passed

recreate
passed

demand-backup
passed

scheduled-backup
passed

storage
passed

self-healing
passed

init-deploy
passed

limits
passed

monitoring
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

self-healing-advanced
passed

operator-self-healing
passed

Test name
Status

storage
failed

recreate
failed

init-deploy
failed

big-data
failed

scaling
failed

limits
failed

monitoring
failed

scaling-proxysql
failed

demand-backup
failed

self-healing
failed

upgrade
failed

self-healing-advanced
failed

upgrade-consistency
failed

operator-self-healing
passed

security-context
failed

monitoring-2-0
failed

scheduled-backup
failed

affinity
failed

one-pod
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

storage
failed

big-data
failed

scaling
failed

recreate
passed

init-deploy
failed

scaling-proxysql
failed

limits
failed

monitoring
failed

self-healing
failed

demand-backup
failed

upgrade
passed

self-healing-advanced
failed

operator-self-healing
passed

upgrade-consistency
failed

security-context
failed

monitoring-2-0
failed

scheduled-backup
failed

affinity
failed

one-pod
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

recreate
passed

big-data
passed

scaling
passed

init-deploy
failed

storage
failed

limits
failed

monitoring
failed

scaling-proxysql
failed

self-healing
failed

demand-backup
passed

upgrade
failed

self-healing-advanced
passed

upgrade-consistency
failed

security-context
failed

monitoring-2-0
failed

operator-self-healing
passed

scheduled-backup
passed

affinity
failed

one-pod
passed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

init-deploy
failed

storage
failed

recreate
failed

scaling
passed

big-data
passed

limits
failed

monitoring
failed

scaling-proxysql
failed

self-healing
passed

demand-backup
failed

monitoring-2-0
failed

self-healing-advanced
failed

scheduled-backup
failed

upgrade
passed

operator-self-healing
passed

upgrade-consistency
failed

security-context
failed

affinity
failed

one-pod
passed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

scaling
passed

storage
failed

big-data
failed

recreate
passed

init-deploy
failed

limits
failed

monitoring
failed

scaling-proxysql
failed

self-healing
passed

demand-backup
failed

upgrade
passed

self-healing-advanced
failed

monitoring-2-0
failed

upgrade-consistency
failed

security-context
failed

operator-self-healing
passed

affinity
failed

one-pod
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

scheduled-backup
failed

Test name
Status

scaling
passed

scaling-proxysql
failed

storage
failed

recreate
passed

demand-backup
failed

init-deploy
failed

big-data
passed

limits
failed

monitoring
failed

self-healing
passed

self-healing-advanced
failed

upgrade
passed

upgrade-consistency
failed

security-context
failed

scheduled-backup
failed

monitoring-2-0
failed

operator-self-healing
passed

affinity
failed

one-pod
passed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

init-deploy
failed

scaling
failed

storage
failed

recreate
failed

big-data
failed

self-healing
failed

scaling-proxysql
failed

demand-backup
failed

limits
failed

monitoring
failed

self-healing-advanced
failed

upgrade
failed

scheduled-backup
failed

operator-self-healing
failed

upgrade-consistency
failed

monitoring-2-0
failed

affinity
failed

security-context
failed

one-pod
failed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

big-data
passed

recreate
passed

init-deploy
failed

scaling
passed

storage
failed

self-healing
passed

limits
failed

monitoring
failed

scaling-proxysql
passed

monitoring-2-0
failed

affinity
failed

one-pod
failed

auto-tuning
failed

self-healing-advanced
passed

upgrade
failed

restore-to-encrypted-cluster
passed

proxysql-sidecar-res-limits
failed

operator-self-healing
passed

upgrade-consistency
failed

security-context
failed

demand-backup
failed

scheduled-backup
passed

demand-backup-encrypted-with-tls
passed

Test name
Status

recreate
passed

storage
failed

init-deploy
failed

big-data
failed

scaling
passed

self-healing
passed

limits
failed

scaling-proxysql
failed

monitoring
failed

upgrade
failed

restore-to-encrypted-cluster
failed

monitoring-2-0
failed

self-healing-advanced
passed

demand-backup
failed

affinity
failed

one-pod
failed

operator-self-healing
passed

scheduled-backup
failed

auto-tuning
failed

upgrade-consistency
failed

security-context
failed

proxysql-sidecar-res-limits
failed

demand-backup-encrypted-with-tls
failed

Test name
Status

scaling
passed

big-data
failed

storage
failed

init-deploy
failed

recreate
passed

self-healing
passed

limits
failed

monitoring
failed

scaling-proxysql
passed

monitoring-2-0
failed

affinity
failed

one-pod
passed

upgrade
passed

self-healing-advanced
passed

upgrade-consistency
failed

security-context
failed

restore-to-encrypted-cluster
passed

auto-tuning
failed

operator-self-healing
passed

proxysql-sidecar-res-limits
failed

demand-backup
passed

scheduled-backup
failed

demand-backup-encrypted-with-tls
failed

Test name
Status

init-deploy
failed

scaling
passed

big-data
passed

storage
failed

recreate
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

upgrade
passed

demand-backup
passed

upgrade-consistency
failed

scheduled-backup
passed

security-context
failed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

limits
failed

monitoring
failed

monitoring-2-0
failed

affinity
failed

one-pod
passed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

demand-backup-encrypted-with-tls
passed

Test name
Status

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

storage
failed

scheduled-backup
passed

scaling
passed

demand-backup-encrypted-with-tls
passed

scaling-proxysql
passed

upgrade
passed

upgrade-consistency
failed

init-deploy
failed

big-data
passed

security-context
failed

self-healing
passed

self-healing-advanced
passed

operator-self-healing
passed

limits
failed

monitoring
failed

monitoring-2-0
failed

affinity
failed

one-pod
passed

auto-tuning
failed

proxysql-sidecar-res-limits
failed

Test name
Status

storage
failed

recreate
passed

init-deploy
failed

scaling
passed

big-data
passed

self-healing
passed

limits
failed

monitoring
failed

scaling-proxysql
passed

monitoring-2-0
failed

affinity
failed

restore-to-encrypted-cluster
passed

one-pod
passed

self-healing-advanced
failed

upgrade
passed

operator-self-healing
passed

auto-tuning
failed

upgrade-consistency
failed

security-context
failed

demand-backup
passed

proxysql-sidecar-res-limits
failed

scheduled-backup
passed

demand-backup-encrypted-with-tls
passed


RL4J - Added ExperienceHandler

Note: This is a re-submit of PR #320, which I canceled.
What changes were proposed in this pull request?
The goal of this PR is to externalize experience handling and network update from the learning classes. A few experience handling classes has been added in the package org.deeplearning4j.rl4j.experience and the network update logic has been extracted from A3CThreadDiscrete and AsyncNStepQLearningDiscrete to A3CUpdateAlgorithm and QLearningUpdateAlgorithm respectively.
I'd like to merge the sync and async update algorithms into a common interface (sync outputs a dataset with feature-labels and async outputs Gradient[]). To be done later.
Also note that the A3C update algorithm is not fully unit tested; I don't think its implementation is correct.
How was this patch tested?
unit tests and manual tests
Quick checklist
The following checklist helps ensure your PR is complete:

[X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[X] Reviewed the Contributing Guidelines and followed the steps within.
[X] Created tests for any significant new code additions.
[X] Relevant tests for your changes are passing.

@aboulang2002 Yeah, it looks like this doesn't build. Please fix it! Thanks


"Vâlcelele" is listed in the drop-down menu

Description:
"Vâlcelele" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Vâlcelele" in the search bar.

Expected results
The location is listed in the drop-down menu as "Vâlcelele, Argeș (Merișani)".


Cyt assist printer

For future stories, can you please include the story number in your git commit message? That way we can see what the purpose of any particular change was.
For this one, is there a story for this?


problem with scripts shebang

It seems to me that the shebang of the script are wrong.
The -py3 version should have python3 instead of python if I am not wrong.

You're right. It's fixed now.


Short options pass delimiter

When using the short option -n to pass the host's name a space gets added to the hostname resulting in undesirable behaviour later.
Example:
./mod-ua -n foobar

This sets $hostname to _foobar (_ = space)

This only happens on the automatic builds. Not with manual builds. The automatic buildscript needs to be reviewed. This is not in scope of this repo.


time.clock is removed from py3.8

Instances of time.clock in consumptionsaving is removed in https://github.com/econ-ark/HARK/pull/455

@MridulS, what do you think we should do about this?
I was going to say "could you do a global search on HARK, REMARK, and DemARK repos and replace any instances of the use of time.clock() with whatever" but I'm not sure there's a "whatever" that is future-proof.  Is there, for py3, an equivalent to "from future import"?

for time.clock() there is time.time() which works for both py2 and py3. I have replaced it in HARK, will do it for REMARKs and DemARKs too.

I think these changes are not yet published to the conda-forge.

@adsk2050 what version of HARK are you using from Conda-forge?

I installed it by using the command conda install -c conda-forge econ-ark. The version is 0.10.4, but this is the same version as what is showing when I installed from source.


Not allowed to batch insert into a MySQL8 server

Now allowed to execute batch inserts on MySQL8 server, Works fine when running with knex directly, maybe mysql2 client is not getting grouped together with the mysql/postgress client?
The following query works just fine using knex directly
knex('plaid_account_meta')
	.insert([{
		account_id: '12345',
		type: 'abc'
	}, {
		account_id: '1574515',
		name: 'test'
	}])
	.onConflict('account_id')
	.merge();

but  get the error below when I try to run it using Objectionjs
PlaidAccountMeta.query()
	.insert([{
		account_id: '12345',
		official_name: 'abc3',
	},{
		account_id: '1574515',
		name: 'testName3',
	}])
	.onConflict('account_id')
	.merge();

error: Error: batch insert only works with Postgresql and SQL Server
      at InsertOperation.onBefore2 (/home/node/app/node_modules/objection/lib/queryBuilder/operations/InsertOperation.js:31:13)
      at QueryBuilder.callAsyncOperationMethod (/home/node/app/node_modules/objection/lib/queryBuilder/QueryBuilderOperationSupport.js:387:39)
      at /home/node/app/node_modules/objection/lib/queryBuilder/QueryBuilder.js:1143:19

On the knex file:
client: 'mysql2',
version: '8.0',

MySQL doesn't return the identifiers of the created rows. Kysely models can't be created for the result without identifiers. That's why it's not supported.

That makes sense. In my opinion, I believe there should still be some support, and instead of returning a set of models, just a count or boolean. Especially since this in a sort creates a weird scenario where it removes a feature of knex. I would imagine having this feature would still be more beneficial than having to break out of using objection to make a knex query? or at least some clearer explanation as to why in the docs or error messages.


Fix volume assignment upon OpenStack VM craetion

The volume(s) to be attached to a VM are now defined as a list and are optional as some flavors already provide a volume.
Closes #295
Closes #294
Closes #293

The ansible script is failing on the package update task. The server is available as I had an independent SSH connection to it with a top executing.
TASK [openstack/init_vm : Upgrade all packages] **********************************************************************************************************************************************************************************************
Thursday 20 April 2023  13:25:33 +0200 (0:00:03.473)       0:05:58.121 ********
fatal: [xxx]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: Shared connection to xxx.xxx.xxx.xxx closed.", "unreachable": true}

The problem exists on OS level, executing sudo dnf update closes the SSH connection.
[yyy@xxx ~]$ sudo dnf update
Connection to xxx.xxx.xxx.xxx closed by remote host.
Connection to xxx.xxx.xxx.xxx closed.

The problem might be an OOM that's killing the connection. The machine used to test as very little resources. Will test with a better VM.
░░ Subject: A process of session-13.scope unit has been killed by the OOM killer.
░░ Defined-By: systemd
░░ Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
░░
░░ A process of unit @UNIT has been killed by the Linux kernel out-of-memory (OOM)
░░ killer logic. This usually indicates that the system is low on memory and that
░░ memory needed to be freed. A process associated with session-13.scope has been determined
░░ as the best process to terminate and has been forcibly terminated by the
░░ kernel.

Fixed replacing the tiny flavor ci.m1.micro which has 1 GB RAM.

Can you also add g.standard.xxl and disk 120GB ?

The idea of the flavors is now only informational. g.standard.xxl already comes up with a 120GB disk so no extra volume is required. If an extra volume (or any number of extra volumes) is required they must be filled as a list of volumes on the following openstack.vm yaml structure:
openstack:
  vm:
    volumes:
      - name: "volume1"
        size: 160

Approved !


Update documentation build to use "assets"

GitHub have changed the way they handle "pages."
In the past they were taken from a branch in the repository called "gh_pages." Now they are tarred up as an "asset" and installed from there.
This change reflects that.
I've tested it as far as I can but it's always hard to be certain if workflows are correct until they are deployed.

@MatthewHambley , could you please fix the conflicts, then I'm happy to merge.


Add nav link transition

The nav links do not transition while tabs do, this felt a bit odd.

Are we 100% sure about this? It feels a little weird to me. Maybe we shouldn't have a transition for tabs either?

Maybe we shouldn't have a transition for tabs either?

The transition can be removed by removing the fade class.

Are we 100% sure about this? It feels a little weird to me.

It felt weird to me the buttons had a transition while these nav links hadn't.

I'm still not convinced about this. I'm not saying it's wrong but it just
feels weird.
On Fri, Feb 7, 2020, 17:06 Martijn Cuppens<EMAIL_ADDRESS>wrote:

Maybe we shouldn't have a transition for tabs either?
The transition can be removed by removing the fade class.
Are we 100% sure about this? It feels a little weird to me.
It felt weird to me the buttons had a transition while these nav links
hadn't.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/pull/29988?email_source=notifications&email_token=AACVLNLNJOR5HEBZXNAIQU3RBV2IHA5CNFSM4KENSF5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELDJXCY#issuecomment-583441291,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACVLNLC7U23VXMM3N445PDRBV2IHANCNFSM4KENSF5A
.

I guess it would be fine to leave this as is since I seem to be the only one in the world whining about this 😄

Let's wait until @ysds or @mdo comment too :)

I can not find the branch...

@ysds check again please, I restored it (you could do it also via the button :))

Changed the transition duration to .15s, which feels better.

I'd like @mdo's opinion before merging this


Use data type to create an inspector for a foldable GPU expression.

Take care of the GpuLiteral and foldable GPU expression specially when creating an inspector from an expression.
This fixes https://github.com/NVIDIA/spark-rapids/issues/4275

[ ] Add tests

Signed-off-by: Firestarman<EMAIL_ADDRESS>

Mark as draft because it is missing tests. I am working on it.

build

build

build


Secure Deployment

CORE=(stack query locals morpheus-graphql-core version)
SERVER=(stack query locals morpheus-graphql version)
CLIENT=(stack query locals morpheus-graphql-client version)

if ($TAG_VERSION == $SERVER == $CLIENT == $CORE) deploy
else reject

done


ci: add runner architecture to cache key

macos-latest has been bumped from macOS 12 (x86_64-based) to macOS 14 (ARM-based). Yesterday, macOS 14 didn't offer binaries for Python 3.8 and 3.9, which led to #1604. But it seems GitHub has added those binaries now. Yet our CI checks now run on heterogeneous runner architectures: x86_64 for Linux/Windows and ARM for macOS. Our current cache key does not contain the runner architecture, so  files built for x86_64 might be restored on the ARM runner until that cache gets updated with files built for ARM. So, I've added the architecture of the runner to the cache key which should fix immediate issues and make us more robust against similar changes in the future.
While at it, I took the opportunity to reformat the cache keys to use a - separator, which seems more common according to GitHub's documentation. I also took the liberty and added a nasty # prettier-ignore comment above the cache key to format it manually because Prettier's line wrapping is (IMHO) really ugly and difficult to read here.
Supersedes #1604.

@copier-org/maintainers In case one of you is available for a quick review, getting this merged will unblock other PRs. :innocent:

Thanks for the quick review, @pawamoy! :pray:


Does stinsen support installation with CocoaPods?

First of all, thank you for providing such a simple and elegant way to implement coordinator pattern with SwiftUI, I have been sniffing around about this topic and your approach is the best I found.
I installed this library with Swift Package Manager very easily and had zero issues when using it. But my project also depends on some other third party libraries that do not support SPM, so I also had to use CocoaPods to install those. And now, for some Apple M1 chip and arm64 compilation reason, I couldn't make the project compile for both CocoaPods and SPM dependencies, so I am thinking about dropping SPM and use CocoaPods only, because I know how to make it work with CocoaPods.
So here we are back to my original question: do you currently or plan to support installation with CocoaPods? I tried searching stinsen on CocoaPods.org but could not find it. Also, if you can add a Installation section to your readme, it would definitely help some devs to use your framework more easily.
Thanks again, for sharing this great library!

Hi! Thanks, just happy to be able to help out other developers 😄. I haven't used CocoaPods for a while so I haven't really thought about adding support yet, but of course it makes sense to do so. I've released 1.0.6which has support for Cocoapods, and I've also added a small Installation section to the readme.md 😊

Thank you for fast response! @rundfunk47
I was just looking at your master branch so I didn't realize that you have already supported CocoaPods. But weirdly enough, I gave it a try yesterday and now, and below is the result I am getting.

Btw I have figured out a way to make CocoaPods and SPM work together on M1, but still, knowing it has CocoaPods support is always reassuring.

Hi, does it work now? It takes a while for the main Cocoapods repo to index it, it seems

@rundfunk47 Thanks for confirming! After I ran pod repo update, then pod install, it's all working! I have successfully installed Stinsen (1.0.7)! Appreciate all your helps!

Great 👍🏼


Refine the HTTP Service.

Some remarks:

I made some client changes for #3928 : create and update won't return any data with this PR, so I changed every response type to void. There are some places where the response is needed. I placed a TODO there, because this needs to be discussed in which way the server should send responses other than void.
All requests can now take content in their bodies :)
Error handling is done in another PR.

TODO: Docs.

Also fixes race conditions during tests. No more random errors in travis.

I added id to every CREATE request in #3928.

@tsiegleauq @jsaalfeld Please check again after we have discussed the usage and I did some changes.


Variables for Mute Group and Mute Button states

Hi,
with the new companion feature to trigger on variables it would be nice to have variables for the mute groups and mute button states, to trigger buttons with.

Triggers can now use feedbacks, so this is no longer necessary


how can one include docinfo header and footer in workflow?

i tried adding header using docinfo https://docs.asciidoctor.org/asciidoctor/latest/docinfo/ but build fails with
"Configure git
fatal: --local can only be used inside a git repository"
Thanks,

The same started occurring to me.

Hello guys
I've never used this docinfo feature.
Nothing has changed on the action lately. Maybe it's something related to the container it used, version of tools and things like that.
Can something share the link to a repo where the issue occurs?

The issue was because the git version inside the container was updated and some behaviors changed,
requiring the action to be updated.
I'll try to make the container version fixed to avoid such a kind of surprise.
Thank you all for reporting.
Just try to rerun your workflows and it may work.


Attribute Search is not showing proper results

What is going wrong?
When searching in the Attr. List in the Data Model Builder the search function is bro
Steps to reproduce

Goto DME
Create new Attr.
Search for existing  component e.g. 'Textbox'
'No results here'

What should happen?
Show the matching components
Possible cause
The field does search, but matches not the label but the underlying 'id'.
E.g. searching for 'stringf' has the result 'Textbox'

fixed in latest release-0.10


python312Packages.commoncode: 31.2.1 -> 32.0.0

Diff: https://github.com/nexB/commoncode/compare/refs/tags/v31.2.1...v32.0.0
Changelog: https://github.com/nexB/commoncode/blob/v32.0.0/CHANGELOG.rst
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339904 run on x86_64-linux 1

48 packages built:

python311Packages.commoncode
python311Packages.commoncode.dist
python311Packages.container-inspector
python311Packages.container-inspector.dist
python311Packages.debian-inspector
python311Packages.debian-inspector.dist
python311Packages.extractcode
python311Packages.extractcode-7z
python311Packages.extractcode-7z.dist
python311Packages.extractcode-libarchive
python311Packages.extractcode-libarchive.dist
python311Packages.extractcode.dist
python311Packages.plugincode
python311Packages.plugincode.dist
python311Packages.scancode-toolkit
python311Packages.scancode-toolkit.dist
python311Packages.tern
python311Packages.tern.dist
python311Packages.typecode
python311Packages.typecode-libmagic
python311Packages.typecode-libmagic.dist
python311Packages.typecode.dist
python311Packages.univers
python311Packages.univers.dist
python312Packages.commoncode
python312Packages.commoncode.dist
python312Packages.container-inspector
python312Packages.container-inspector.dist
python312Packages.debian-inspector
python312Packages.debian-inspector.dist
python312Packages.extractcode
python312Packages.extractcode-7z
python312Packages.extractcode-7z.dist
python312Packages.extractcode-libarchive
python312Packages.extractcode-libarchive.dist
python312Packages.extractcode.dist
python312Packages.plugincode
python312Packages.plugincode.dist
python312Packages.scancode-toolkit
python312Packages.scancode-toolkit.dist
python312Packages.tern
python312Packages.tern.dist
python312Packages.typecode
python312Packages.typecode-libmagic
python312Packages.typecode-libmagic.dist
python312Packages.typecode.dist
python312Packages.univers
python312Packages.univers.dist


Shading Bouncy Castle classes to prevent collision with Gradle API

I've been working on a patch for the os-package Gradle plugin (https://github.com/nebula-plugins/gradle-ospackage-plugin) to support signing RPM/DEB packages. Luckily for me, both jDeb and Redline RPM already support signing packages, and those libraries are already being used by os-package. Unluckily for me, making use of the Gradle API for plugins causes some odd issues with dependencies; notably, even though Redline RPM has a dependency on Bouncy Castle 1.50, I'm seeing the Bouncy Castle 1.46 jar on the classpath which directly causes a MethodNotFound exception due to a changed contract between those versions. More information on Gradle's weirdness can be found on this blog post: http://jdpgrailsdev.github.io/blog/2014/04/15/gradle_api_dependencies.html .
This PR addresses the root issue for me by shading the Bouncy Castle classes in the Redline RPM jar.

Thanks for the update!


#670 - Correcting IAM User Filters

correcting issue causing AttributeError
missing unittest added

wip... adding boolean option for users without attached policy

@kapilt -- so, test passes when i record the flight data but fails when i replay. All the requisite data seems to be stored within the placebo data so im not sure what's happening.

@joshuaroot could you resolve conflict on this


Migration to CFS

Description: This PR adds .npmrc to all packages in the repository to consume packages from the internal feed.
Related: AB#2197030

/azp list

/azp run

/azp run

/azp list


fix:  "Records" and "RecordsCppImpl" behave differently.

Description
In the "Records" class (used in GitHub Actions) and the "RecordsCppImpl" class (used in the local execution environment), it has been observed that they exhibit different behaviors for the same input. To address this issue, "RecordsCppImpl" will be built and used in GitHub Actions. Additionally, when there are no changes in "RecordsCppImpl," caching will be employed to optimize the build process for increased speed.

Related links

Notes for reviewers
https://tier4.atlassian.net/browse/RT2-590

Pre-review checklist for the PR author

[ ] I've confirmed the contribution guidelines.
[ ] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR has been properly tested.
[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] (Optional) The PR has been properly tested with CARET_report verification.
[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

There is no consistent use of words.
imple should be changed to 'impl'.
Could you correct it? @h-suzuki-isp


[CP to 1.5] C# Unit Test Project: Set PublishTrimmed =false even in Release mode

Cherry Pick of #4175 to release/1.5-stable.
The unit tests do not work with PublishTrimmed=true. So building the unit test project in Release configuration will result in the tests no working.
The fix is to set PublishTrimmed=false unconditionally instead of basing it on the Configuration.

/azp run


Sometimes when I load an item, "java.lang.RuntimeException: No player info block." is thrown

Sometimes when I load an item to play, lavaplayer throws the Exception "java.lang.RuntimeException: No player info block.". This doesn't happen always - only sometimes. It even only happens sometimes when I load the same track. I'm having no internet connection issues. Is youtube rate limiting me? If yes, then what can I do? I have my own Youtube API key from Google, which I use to make youtube searches, if that matters. But I don't use this API key anywhere in lavaplayer, I use it for my own classes.
This is the full error I get:

Same issue here

I'm getting this same exception with a lot of consistency, https://pastebin.com/k6M1phWW

Been getting the same issue.

I am still having the same problem.
(I'm sorry that I'm using Google Translate because I'm not good at English.)

Update to version 1.3.53

Thanks :)


nixos/caddy: improve security about acme certs

Description of changes
Before this patch, the caddy user will be added to the acme group if
acme is used, which may give caddy more permission than needed and is
inconsistent with the documentation.
This patch improves this to only give caddy the needed permission by
suggesting setting the group of needed certs to caddy, which is what
other web servers, e.g. nginx, do.
It also suggests the old way in case needed.
@m1cr0man @aanderse
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Thanks for the review.

the implementation needs to be more careful to not entirely break existing systems.

I don't think this will cause any break since we have mkCertOwnershipAssertion. With mkCertOwnershipAssertion, SupplementaryGroups is redundant currently.

Set the default group value (lib.mkDefault) to caddy for each required certificate as we do for other web servers

I agree. Will do.

Add a note to the changelog

Since there is no break, it seems not needed.

I renamed reloads to certCfg and improved commit message.
Should be ready to merge I think.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/541

Looks like this fixes #162924. 🎉
@m1cr0man Per your comments in that issue, do you think this is still a good solution? Specifically wrt your concerns about attacks from the ACME end of things.
To be clear @jian-lin, this implementation looks sane + is in line with all of the other modules, so we can probably still merge in this in the meantime to ensure consistency, though I do wonder if overhauling the entire permissions situation like Luca said is the best longterm solution?


Crash when encountering invalid manifest

Tested on Windows 7 64bit, Dependencies 64bit v<IP_ADDRESS>, inspecting MsiCofire.dll 64bit. This DLL has manifest ID 1 containing invalid XML, Dependencies crashes.

I think 29b942f635195a3d0d27db67d9e03ffb58b42bd3 fix the crash you've seen.
However, this DLL which has two manifests is pretty trippy :

C:\Windows\System32\rundll32.exe .\MsiCofire.dll, DllMain loads C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.592_none_e6c0b1911312be02\COMCTL32.dll
C:\Windows\SysWOW64\rundll32.exe .\issue115\MsiCofire.dll, DllMain does not

This is the manifests embedded :
ID1 :
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity
    name=SXS_ASSEMBLY_NAME
    processorArchitecture=SXS_PROCESSOR_ARCHITECTURE
    version=SXS_ASSEMBLY_VERSION
    type="win32"/>
<description>Windows Corrupted File Recovery MSI reinstall dialog</description>
<dependency>
    <dependentAssembly>
        <assemblyIdentity
            type="win32"
            name="Microsoft.Windows.Common-Controls"
            version="<IP_ADDRESS>"
            processorArchitecture=SXS_PROCESSOR_ARCHITECTURE
            publicKeyToken="6595b64144ccf1df"
            language="*"
        />
    </dependentAssembly>
</dependency>
</assembly>

ID2 :
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<!-- Copyright (c) Microsoft Corporation -->
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity
    name="Microsoft.Windows.base.MsiCofire"
    processorArchitecture="amd64"
    version="<IP_ADDRESS>"
    type="win32"/>
<description>Windows Corrupted File Recovery MSI reinstall dialog</description>
<dependency>
    <dependentAssembly>
        <assemblyIdentity
            type="win32"
            name="Microsoft.Windows.Common-Controls"
            version="<IP_ADDRESS>"
            processorArchitecture="amd64"
            publicKeyToken="6595b64144ccf1df"
            language="*"
        />
    </dependentAssembly>
</dependency>
</assembly>

I'm pretty sure the Manifest ID1 is ignored, and only Manifest ID2 is used (which defines the comctl32 dependency only for amd64). If you've got some insight on how sxs manifests are parsed, you're more than welcome
In the meantime, I keep this issue opened
Lucas

Hi Lucas,
I think your commit is too specific, you don't need to search for the exact phrases and handle them.
Having multiple manifest is fine as you have only one manifest in range 1-16 (inclusive).
I think that for DLLs manifest ID 1 is always ignored, but I'm not sure.
I cannot reproduce your findings. I tested on Windows 7 64bit. Running 64bit version of rundll with 64bit version of msicofire.dll loads modern version (6.1) of comctl32.dll. And running 32bit version of rundll with 32bit version of msicofire.dll also loads modern version (6.1) of comctl32.dll. Note that I don't have 32bit version of msicofre.dll on my 64bit Windows 7 machine, I copied it from 32bit Windows 7.
How to parse SxS? I tried that and I abandoned it, I think you should do the same as Dependency Walker does. You can try to use APIMonitor tool (http://www.rohitab.com/apimonitor) to learn that Dependency Walker uses CreateActCtx, ActivateActCtx, FindActCtxSectionString functions to handle SxS. I already told you that in discussion about issue#3.
Marek

I probably fixed this with the PR I have open: #150


Returning Early RSX Causes an Error on Desktop Windows

Problem
When running a Desktop app on Windows 10, early RSX returns are not rendered and an error is shown in the console.
Steps To Reproduce
Run this component on the Dioxus Desktop platform in a Windows environment.
fn app() -> Element {
    let mut data = use_signal(|| false);

    if data() {
        println!("RAN1");
        rsx!("true")
    } else {
        println!("RAN2");
        data.set(true);
        rsx!("false")
    }
}

Expected behavior
true should be displayed instead of false.
Screenshots
This error is shown is the console when the true branch of the if statement is ran.

Environment:

Dioxus version: main, 0.5
Rust version: 1.77.1
OS info: Windows 10
App platform: Desktop

This also happens with if, else if and else statements inside of RSX blocks:
fn app() -> Element {
    let mut data = use_signal(|| false);

    rsx! {
        if data() {
            "true"
        } else {
            {data.set(true)}
            "false"
        }
    }
}

Also happens on release.


WIP: chore: enable embed runtime

Description
No need to merge
enabel embedRuntime in manifest-webpack-host demo, and set runtimeChunk ,there are two different phenomena will occur:

nx build manifest-webpack-host : build sussess
nx serve manifest-webpack-host : throw below errors

Related Issue

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the documentation.

@squadronai review


[kube-prometheus/exporter-kube-state] Use fullname template so it's consistent with other exporters

Part of: https://github.com/coreos/prometheus-operator/issues/592

lgtm, thanks!


Tool version updater

Add shell script to allow update tool version easily.
As of now, to update version of some of the tools, I need to find the latest version manually and find where I need to update the version.
Currently, this script works for updating:

checkstyle (update the jar, and dockerfile)
goodcheck (update gemfile)
ktlint (update variable on dockerfile)
puppet-lint (update gemfile)
rubocop (update gemfile)
swiftlint (update image on dockerfile)

Some are still missing as I'm not sure which files that also need to be updated to make sure it uses the latest version of the tool.
As to use the script
# Simple shell script call
./update_tool.sh $tool

# Example:
./update_tool.sh checkstyle

# or use Makefile
make update tool=ktlint
or
make update rubocop

I tested the script and it works on Mac, maybe should be tested on Linux and Windows too.

Thanks this is great! I can add support for python and php tools.


Promise.race resolves the combined Promise multiple times, which emits an error/warning event in node

Description says it all.
Since Node 10.12.0 it emits an event when a promise is resolved/rejected multiple times https://nodejs.org/api/process.html#process_event_multipleresolves.
While it's usually overlooked because these errors are by default silently swallowed, this really shouldn't be implemented like this: you're expected to only call one of resolve or reject once.

Subsequent resolves being ignored is a first class feature of promises. It is intended exactly to make it easy to have races like this. Since this isn't using the native promise implementation, we won't fire that event, making multiple resolves for internal cases like this impossible to observe.


Error: wasm execution failed with error: FunctionCallError(HostError(GasLimitExceeded))

Hey, is there a way we can configure the near node to allow higher gas limits than whatever's default?
Calls like contract.methods.someBigMethod.call({ gas: 1e18 }) currently throw a wasm execution failed with error: FunctionCallError(HostError(GasLimitExceeded)) error and there's apparently no way around it.
Full error log:
Error: Returned error: Internal Error - Querying [object Object] failed: wasm execution failed with error: FunctionCallError(HostError(GasLimitExceeded)).
{
  "block_hash": "9pTg5KQVELmNo2ZArq8GhHjTFmzKEMiWkSPLvBtzmYQz",
  "block_height": 65175732,
  "error": "wasm execution failed with error: FunctionCallError(HostError(GasLimitExceeded))",
  "logs": []
}. Please report a bug at <https://github.com/aurora-is-near/aurora-relayer/issues>
    at Object.ErrorResponse (errors.js?d2dd:28:1)
    at eval (index.js?b20e:300:1)
    at XMLHttpRequest.request.onreadystatechange (index.js?b231:98:1)

It's happening the same to me. Did you make it work?

@apoorvsingal , @aguirrel Thank you for submitting this. Can you please provide example of a contract so we can reproduce this.

https://docs.rari.capital/fuse/#get-pools-by-account-with-data This is one, it takes more gas than what aurora relayer allows (given the pools and assets count are high enough)

After setting up my own self-hosted Aurora node (VM on cloud), I faced the same issue as above, but when I utilized public RPC, that error did not show up. Is there any further step that needs to be configured?

This repository is deprecated. If issue still persists, please reopen it on a new repository of Aurora Relayer v2.


RolesController

Some code logic is done in the RolesController (updating the role). Shouldn't it be done in the Service instead ?
Moreover, there is this method in the service which is unused : RoleDTO update(Long roleId, RoleUpdateForm roleUpdateForm) which makes me think that the logic was planned to be done here but there was a little oversight.

Are you talking about this ?
RoleDTO role = this.roleService.getOne(id);     if (role == null) {       throw new NoSuchElementException(String.format("Role=%s not found", id));     }     role.setName(roleUpdateForm.getName());     role.setDescription(roleUpdateForm.getDescription()); RoleDTO updatedRole = this.roleService.update(id, role);
?

Yes and it's also done there :
RoleDTO role = this.roleService.getOne(id);     List<String> availablePrivileges = this.roleService.getAvailablePrivileges().stream().map(Privilege::privilege).collect(Collectors.toList());     if (role == null) {       throw new NoSuchElementException(String.format("Role=%s not found", id));     }     role.setPrivileges(rolePrivilegeUpdateForm.getPrivileges().stream().filter(availablePrivileges::contains).collect(Collectors.toList()));     RoleDTO updatedRole = this.roleService.update(id, role);

Whatever is the right choice (controller or service) it must be done everywhere.
I personnaly think it sould stay at the controller level as the modification of the entity is done there and then we call the update method from the service with the new values.


fix the logic error on isNotPassing

This is to fix
https://github.com/rndsolutions/trx-merger/issues/14
I'm not sending the pr to trx-merger since it's not maintained anymore.

Thanks for PR, looks good but I'll need to look at it properly over the weekend as I think the code currently always outputs "Failed" at the moment.

Thanks for PR, looks good but I'll need to look at it properly over the weekend as I think the code currently always outputs "Failed" at the moment.

Yea. the code needs some change. The error is probably because the code is expecting ResultSummary.outcome 's value to be 'Passed' or 'Failed'.
The actual case might be 'Completed' instead of 'Passed'.
See this real trx:

fixed ResultSummary.Outcome too

I've merged that and made a version 1.0.0 should be available from nuget shortly.


PhpStorm shows 'Multiple definitions exists for class'

Larastan Version: 0.5.5

Description
PhpStorm shows 'Multiple definitions exist for class' warnings. It breaks code assistance.
Check the following screenshots.

It seems to be related to stubs defined in the package.
Laravel code where the issue was found
Declaring a model is an example.
<?php

declare(strict_types=1);

namespace Domain\Campaign\Model;

use Illuminate\Database\Eloquent\Model;

class Post extends Model
{
}

Very interesting!

@mariomka We are not sure how to improve this. Can you investigate this?

The stubs in Larastan are not even php files. They have .stub extensions for this very reason.
So check your IDE settings, I believe you associated stub extensions with PHP files.

@canvural Yep! I removed .stub extension from PHP file types. I don't know if this extension is set by default or maybe I added it.
Thank you all.


Benchmark: CLI option to set subcomm size

Add flexibility to the 30 frame benchmark by letting the user specify the number of MPI ranks per extraction group.
This is useful for testing the CPU version of gpu_specter on nodes with many CPU cores where it may be beneficial to split the MPI communicator into smaller extraction groups.

This looks good to me, the new flag functions in a similar way to that for desi_proc, and makes it easier to find the optimal subcomm size for a given system.


Torch model

Seems like there's a memory leak, it grows to ~70% usage and then freezes and reboots

This branch isn't ready yet!

Can I test on the drive home?

@geohot go for it!

UI crashes for me after going onroad. I'm on commit 87a42c1.
Here's some scrollback which I hope is useful:
type = 0x0004 = CL_DEVICE_TYPE_GPU
driverState: Reader was evicted, reconnecting
driverState: Reader was evicted, reconnecting
cameraOdometry: Reader was evicted, reconnecting
loaded model with size: 56036227
thermald logmessaged ui uploader deleter updated logcatd tombstoned sensord pandad controlsd plannerd loggerd radard calibrationd paramsd camerad proclogd locationd cloc
ksd ubloxd dmonitoringd dmonitoringmodeld gpsd rtshield modeld
frontFrame: Reader was evicted, reconnecting
selfdrive/camerad/main.cc: client start fd 146
driverState: Reader was evicted, reconnecting
selfdrive/camerad/main.cc: client start fd 147
selfdrive/camerad/main.cc: client start fd 148
driverState: Reader was evicted, reconnecting
loaded model with size: 1134208
ioctl returned -1 with errno 22
model: Reader was evicted, reconnecting
thermald logmessaged ui uploader deleter updated logcatd tombstoned sensord pandad controlsd plannerd loggerd radard calibrationd paramsd camerad proclogd locationd cloc
ksd ubloxd dmonitoringd dmonitoringmodeld gpsd rtshield modeld
vipc_recv err: Connection reset by peer
selfdrive/camerad/main.cc: client end fd 146
model: lambda/div:0 -> outputs/concat:0
input product is 307200
selfdrive/camerad/main.cc: client start fd 146
selfdrive/loggerd/loggerd.cc: camera 0 rotate encoder to /data/media/0/realdata/2020-11-11--20-46-22--0.
selfdrive/loggerd/loggerd.cc: camera 1 rotate encoder to /data/media/0/realdata/2020-11-11--20-46-22--0.
selfdrive/modeld/dmonitoringmodeld.cc: connected with buffer size: 1492992   ```

Sorry, fixing now.