Refactor perf module for better readabiity

References and relevant issues
Fix things pointed in #6575
Description
Improve readability and remove obsolete code in perf module

Could you point exact places where docs should be expanded?

I can't make suggestion there easily, but in PerfTimers:
docstring for add_instant_event currently """Add one instant event.

would like just few words, 1-line max, what this is/does
docstring for add_counter_event currently """Add one counter event.
would like just few words, 1-line max, what this is/does

I think these are then repeated in DummyTimers

I have updated.
I do not feel fully familiar with perfmon code. The idea of this PR is to remove bad patterns from code.


Validation bug with nested schema and type_specs enable

I have to use type_specs = true as workaround of another bug, and noticed that it works differently in direct and nested schemas.
I have one field, which has both coercion and validation rules, and I try to set them separately in schema DSL, which seems logically.
It works fine for direct schema, but if this schema is nested, coercion doesn't seem to work.
Here is example in code:
        Types = Dry::Types.module
        Validation = Types::Strict::String.constrained(format: /\A\w+\z/)
        Coercion = Validation.constructor { |a| a.gsub(/\s+/, '') }

        A = Dry::Validation.Form do
          configure { config.type_specs = true }
          required(:val, Coercion).filled(Validation)
        end
        B = Dry::Validation.Form do
          required(:parent).filled(A)
        end

        hash = {'val' => 'a b c'}
        p A.call(hash)
        #<Dry::Validation::Result output={:val=>"abc"} errors={}>
        p B.call('parent' => hash)
        #<Dry::Validation::Result output={:parent=>{:val=>"a b c"}} errors={:parent=>{:val=>["is in invalid format"]}}>

A couple more considerations:

It doesn't matter, either B schema is type_specs = true or not
It works fine, if there is required(:val, Coercion).filled(Coercion)
Coercing in A stops to work if Dry::Validation.Form changes to Dry::Validation.Schema (is it by intention?)

Maybe there is mistake how I understand type_specs, but as for me, it's expected, that Coercing should be in required and validation should be in filled helpers.
Currently I use second consideration as workaround

This shouldn't be allowed, if you want to pass in a schema you need to do required(:parent).schema(A). Can you confirm that this works?

with schema instead of filled
    B = Dry::Validation.Form do
      required(:parent).schema(A)
    end

it's the same. A schema works, but B schema doesn't

This will be fixed in the next version. I'm closing this one since, here's another issue for tracking progress https://github.com/dry-rb/dry-schema/issues/25


Fix segfault in the Breadcrumb system when associated model is unloaded

Currently, when a model is unloaded, the model systems associated with that model do not get unloaded. If the systems then try to access the components of the model, they will fail. However, most systems check the validity of the model they are associated with in the System::Configure function and assume that if the model is valid then, it will be valid in PreUpdate/PostUpdate functions. I think it would be nice for that assumption to hold, but right now it might not.
In the case of the Breadcrumb system, the system retrieves the pose of the model at every time step in PreUpdate and assumes that it will be valid. However, if the model is unloaded, the Pose component will be a nullptr causing a segfault.
The ideal fix would be to make sure systems are unloaded when the model gets unloaded (see #113), but until then, this PR adds a check for the validity of the model in Breadcrumbs::PreUpdate.

Failing tests are fixed by https://github.com/ignitionrobotics/ign-gazebo/pull/455


Multiple flags in a command leading to errors

I'm currently using the lastest SF version from Github
Sponge command parsing seems to be confused when a command has multiple flags.
Example:
CommandSpec testCommand = CommandSpec.builder()
			    .executor((src, args) -> {
			    	src.sendMessage(Text.of("X: ", args.hasAny("x"), Text.NEW_LINE, "Y: ", args.hasAny("y")));
			    	return CommandResult.success();
			    })
			    .arguments(GenericArguments.flags().flag("x").buildWith(GenericArguments.none()),
			    		GenericArguments.flags().flag("y").buildWith(GenericArguments.none()))
			    .build();
Sponge.getCommandManager().register(plugin, testCommand, "testcmd");

When only the first flag is used, everything is fine:

When the second flag is used it throws an exception:

Using both flags also doesn't work:

I meant to comment on this a while ago. This isn't so much a bug really. Each command should only have one flag parser, your code should be:
CommandSpec testCommand = CommandSpec.builder()
			    .executor((src, args) -> {
			    	src.sendMessage(Text.of("X: ", args.hasAny("x"), Text.NEW_LINE, "Y: ", args.hasAny("y")));
			    	return CommandResult.success();
			    })			.arguments(GenericArguments.flags().flag("x").flag("y").buildWith(GenericArguments.none())
			    .build();
Sponge.getCommandManager().register(plugin, testCommand, "testcmd");

The reason is that the flag parser checks all flags it comes across. The first flag succeeds because the -x flag is known to the first parser. The second flag doesn't succeed, because the first parser you specify (for x) doesn't know about y. Flag arguments are designed to take more than one flag, however, so just chaining them in the one flag argument would work as intended.


Problems in compiling torch module in plumed

Pytorch==1.13.1
In the beginning, I start to compile the torch module of plumed with libtorch-cxx11-abi-shared-with-deps-1.13.1+cpu, then I found the error "undefined reference to<EMAIL_ADDRESS>As it is not wise to update GLIBC, I then try to use libtorch-1.13.1 without ABI, then another error occurred:

"""collect2: error: ld returned 1 exit status
    Makefile:499: recipe for target 'plumed' failed
    make[4]: *** [plumed] Error 1
    make[4]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'
    Makefile:110: recipe for target 'all' failed
    make[3]: *** [all] Error 2
    make[3]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'
    Makefile:8: recipe for target 'lib' failed
    make[2]: *** [lib] Error 2
    make[2]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src'
    Makefile:33: recipe for target 'lib' failed
    make[1]: *** [lib] Error 2
    make[1]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0'
    Makefile:21: recipe for target 'all' failed
    make: *** [all] Error 2"""

In fact, I have tried to install GLIBC-2.27 in my own path. However, it throws out a weird error:

"""make -r PARALLELMFLAGS="" -C .. objdir=`pwd` all
    make[1]: Entering directory `/home/jyzha/tmp/glibc-2.27'
    make  subdir=csu -C csu ..=../ subdir_lib
    make[2]: Entering directory `/home/jyzha/tmp/glibc-2.27/csu'
    /usr/bin/install -c -m 644  /home/jyzha/tmp/glibc-2.27/build/cstdlibT
    /usr/bin/install: missing destination file operand after ‘/home/jyzha/tmp/glibc-2.27/build/cstdlibT’
    Try '/usr/bin/install --help' for more information."""

I am looking forward to your advice on installing the torch module. I strongly require this tool in my work and I am also willing to contribute to mlcolvar.  Thank you~

Hi Jinyin,
First, sorry for the late reply.
About your issue, with those few details, it's difficult to help!
You did not provide many important details for debugging.
Can you please give more information about:

Where are you trying to install the code (workstation, cluster..) and what OS are you using?
The error lines you get, i.e., from which command they are triggered and the actual error (not the make leaving messages) You can find these things in the config.log file in PLUMED installation folder
The configuration option you are using, i.e. the configure command you are using for PLUMED
Some details on the steps you have followed for the installation, i.e., which version of PLUMED, if you followed the instructions on PLUMED website, if you exported the libtorch path etc.

Hopefully with more details we can help you

Thanks for the reply.
I compile plumed on centos 7.9, using the commands from the tutorial
./configure --enable-libtorch --enable-modules=pytorch --prefix=/home/jyzha/software/plumed-2.9
The configuration is OK. It shows
checking whether mpic++ accepts -std=c++14... yes checking libtorch without extra libs... no checking libtorch with  -ltorch_cpu -lc10... yes
Then I start to compile.
make -j32
Then the error "undefined reference to<EMAIL_ADDRESS>is thrown. It seems to be the problem of GLIBC. As it is not wise to update GLIBC, I then try to use libtorch-1.13.1 without ABI, then another error occurred:
collect2: error: ld returned 1 exit status     Makefile:499: recipe for target 'plumed' failed     make[4]: *** [plumed] Error 1     make[4]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'     Makefile:110: recipe for target 'all' failed     make[3]: *** [all] Error 2     make[3]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'     Makefile:8: recipe for target 'lib' failed     make[2]: *** [lib] Error 2     make[2]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src'     Makefile:33: recipe for target 'lib' failed     make[1]: *** [lib] Error 2     make[1]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0'     Makefile:21: recipe for target 'all' failed     make: *** [all] Error 2
Therefore, I tried to update my GLIBC (2.27) in my own account, and it still fails in the make step.
wget https://ftp.gnu.org/gnu/glibc/glibc-2.28.tar.gz tar -xvf glibc-2.27.tar.gz cd glibc-2.27 mkdir build  cd build …/configure --prefix=/home/jyzha/software/glibc-2.27 make -j32
And it also fails.
"make -r PARALLELMFLAGS="" -C .. objdir=pwdall     make[1]: Entering directory/home/jyzha/tmp/glibc-2.27'
make  subdir=csu -C csu ..=../ subdir_lib
make[2]: Entering directory /home/jyzha/tmp/glibc-2.27/csu'     /usr/bin/install -c -m 644  /home/jyzha/tmp/glibc-2.27/build/cstdlibT     /usr/bin/install: missing destination file operand after ‘/home/jyzha/tmp/glibc-2.27/build/cstdlibT’     Try '/usr/bin/install --help' for more information.

Thanks for the reply. I compile plumed on centos 7.9, using the commands from the tutorial
./configure --enable-libtorch --enable-modules=pytorch --prefix=/home/jyzha/software/plumed-2.9
The configuration is OK. It shows
`checking whether mpic++ accepts -std=c++14... yes
checking libtorch without extra libs... no
checking libtorch with -ltorch_cpu -lc10... yes`
Then I start to compile.
make -j32
Then the error "undefined reference to<EMAIL_ADDRESS>is thrown. It seems to be the problem of GLIBC. As it is not wise to update GLIBC, I then try to use libtorch-1.13.1 without ABI, then another error occurred:
`collect2: error: ld returned 1 exit status
Makefile:499: recipe for target 'plumed' failed

make[4]: *** [plumed] Error 1

make[4]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'

Makefile:110: recipe for target 'all' failed

make[3]: *** [all] Error 2

make[3]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'

Makefile:8: recipe for target 'lib' failed

make[2]: *** [lib] Error 2

make[2]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src'

Makefile:33: recipe for target 'lib' failed

make[1]: *** [lib] Error 2

make[1]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0'

Makefile:21: recipe for target 'all' failed

make: *** [all] Error 2`

Therefore, I tried to update my GLIBC (2.27) in my own account, and it still fails in the make step.
`wget https://ftp.gnu.org/gnu/glibc/glibc-2.28.tar.gz
tar -xvf glibc-2.27.tar.gz
cd glibc-2.27
mkdir build
cd build
…/configure --prefix=/home/jyzha/software/glibc-2.27
make -j32`
And it also fails.
"make -r PARALLELMFLAGS="" -C .. objdir=pwd` all
make[1]: Entering directory `/home/jyzha/tmp/glibc-2.27'

make  subdir=csu -C csu ..=../ subdir_lib

make[2]: Entering directory `/home/jyzha/tmp/glibc-2.27/csu'

/usr/bin/install -c -m 644  /home/jyzha/tmp/glibc-2.27/build/cstdlibT

/usr/bin/install: missing destination file operand after ‘/home/jyzha/tmp/glibc-2.27/build/cstdlibT’

Try '/usr/bin/install --help' for more information.`

Hi Jinyin, First, sorry for the late reply.
About your issue, with those few details, it's difficult to help! You did not provide many important details for debugging.
Can you please give more information about:
1. Where are you trying to install the code (workstation, cluster..) and what OS are you using?

2. The error lines you get, i.e., from which command they are triggered and the actual error (not the make _leaving_ messages) You can find these things in the config.log file in PLUMED installation folder

3. The configuration option you are using, i.e. the configure command you are using for PLUMED

4. Some details on the steps you have followed for the installation, i.e., which version of PLUMED, if you followed the instructions on PLUMED website, if you exported the libtorch path etc.

Hopefully with more details we can help you

Thanks for the reply. I compile plumed on centos 7.9, using the commands from the tutorial
./configure --enable-libtorch --enable-modules=pytorch --prefix=/home/jyzha/software/plumed-2.9
The configuration is OK. It shows
`checking whether mpic++ accepts -std=c++14... yes
checking libtorch without extra libs... no
checking libtorch with -ltorch_cpu -lc10... yes`
Then I start to compile.
make -j32
Then the error "undefined reference to<EMAIL_ADDRESS>is thrown. It seems to be the problem of GLIBC. As it is not wise to update GLIBC, I then try to use libtorch-1.13.1 without ABI, then another error occurred:
`collect2: error: ld returned 1 exit status
Makefile:499: recipe for target 'plumed' failed

make[4]: *** [plumed] Error 1

make[4]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'

Makefile:110: recipe for target 'all' failed

make[3]: *** [all] Error 2

make[3]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src/lib'

Makefile:8: recipe for target 'lib' failed

make[2]: *** [lib] Error 2

make[2]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0/src'

Makefile:33: recipe for target 'lib' failed

make[1]: *** [lib] Error 2

make[1]: Leaving directory '/home/jyzha/tmp/plumed-2.9.0'

Makefile:21: recipe for target 'all' failed

make: *** [all] Error 2`

Therefore, I tried to update my GLIBC (2.27) in my own account, and it still fails in the make step.
`wget https://ftp.gnu.org/gnu/glibc/glibc-2.28.tar.gz
tar -xvf glibc-2.27.tar.gz
cd glibc-2.27
mkdir build
cd build
…/configure --prefix=/home/jyzha/software/glibc-2.27
make -j32`
And it also fails.
"make -r PARALLELMFLAGS="" -C .. objdir=pwd` all
make[1]: Entering directory `/home/jyzha/tmp/glibc-2.27'

make  subdir=csu -C csu ..=../ subdir_lib

make[2]: Entering directory `/home/jyzha/tmp/glibc-2.27/csu'

/usr/bin/install -c -m 644  /home/jyzha/tmp/glibc-2.27/build/cstdlibT

/usr/bin/install: missing destination file operand after ‘/home/jyzha/tmp/glibc-2.27/build/cstdlibT’

Try '/usr/bin/install --help' for more information.`

Ciao, I had a chat with @luigibonati and this reminded him of a similar problem someone else encountered in the past.
In that case, the solution was to compile libtorch from scratch.
I'll leave you the link to the discussion thread from PLUMED users group so you can try to follow it and hopefully solve the problem:
https://groups.google.com/g/plumed-users/c/F_59ozWJh1s/m/CkYgVl0UEAAJ?pli=1
Let us know if this helps!

Much thanks, I would try it.

Since this issue has been inactive for a long time, I'll close it for now, hoping the problem was solved :smile:


jellyfin: 10.3.2 -> 10.3.3

Motivation for this change
Changelog: https://github.com/jellyfin/jellyfin/releases/tag/v10.3.3
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test jellyfin


Fixed Grammer

Fixes #.
Fixed some grammatical errors on README.md, ApplicationArchitecture.md, ManuelTests.md, NewFeatureProcess.md, Roadmap.md
Description of the changes:

Pretty self-explanatory -- you could view the grammatical changes that make the sentence flow better for each change.

How changes were validated:

I proofread all the changes I made 4 times.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: RajdeepPy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

fwiw, it's grammar ...

I believe that "Calculator" in this case is a proper noun. They are referring to the application. This makes statements like "Calculator is  ..." a legal move the same way "Microsoft is ..." is legal.

Hi @RajdeepPy, thanks for your interest in this repo. For PRs which primarily make small improvements to comments or documentation, we'll typically consider them only if they fix objective defects in the existing documentation and only if they're easy to merge. Some of the changes here might be okay, while others should be left out (as others have mentioned).
I'm going to close this PR for now, but if you'd like to submit a more limited set of changes we'd take another look.


Change ticker write way

Problem:
Some controller's Lifecycle or Handler doesn't work, when something out of time.
Solution:
I find Rancher.ticker used the wrong way. ticker.Stop will not close the channel and this function will be permanently blocked. I change the ticker write way.

 Now everything is fine! : )


GUVNOR-2340 - Annotation for element inside subprocess fails validation

small indentation problem, otherwise looks good: https://github.com/tsurdilo/jbpm-designer/blob/master/jbpm-designer-backend/src/main/java/org/jbpm/designer/bpmn2/validation/BPMN2SyntaxChecker.java#L645

@csadilek @manstis Thanks guys! Amended

master: 2d16f9b432f88276a632fdf933ddf518bfacbbde


Can not get more than 3 timers to work on Mega2560

Hi,
Does anyone know how to get 6 timers to work on Mega2560 so I can play six tones at once?

OK.. Iv'e figured out how to make it work now...
in the "Tone.CPP" file change all lines with
#if defined(AVR_ATmega1280)
to
#if defined(AVR_ATmega1280)||(AVR_ATmega2560)


Create a physical infrastructure user group

This PR adds a new physical infrastructure user group and a default dashboard for the new group. The default dashboard contains a few physical server widgets.

@miq-bot add_label providers/physical

@miq-bot add_label enhancement

@agrare Could you take a look at this PR when you get a chance? Thanks

@miq-bot assign @agrare

@gtanzillo can you help review the new role?


Added clipper

Added clipper: This plugin disassembles CLIPPER assembly code and generates LLIL.

Clipper had a plugin.json so I went ahead and added it to the repo and generated the readme, thanks.


Using just the instructions in the readme....

Do you really think this works?  When I clone the repository...

The folder is not a react-native project.  Running react-native init Example or Core in your folder screws up your project.

The folders unzip in such a way that I believe they're losing their hierarchy.

Once I got past those errors, I'm now getting.... 'element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.'  It looks like AWSCognitoCredentials isn't getting picked up from the src directory...  Suggestions?

I feel your pain, here's the step-by-step guide for your reference:
https://github.com/awslabs/aws-sdk-react-native/issues/35


Docker bind mount is made on old partition instead of new mounted on the host after docker daemon started

There was a partition /opt on my docker host. I've created and mounted new partition (at path /opt/ssd) without stopping/restarting docker.
After that I create container with bind mount: docker run -v /opt/ssd/test:/data busybox:latest /bin/sh -c "echo test > /data/f".
Result:

it doesn't create /opt/ssd/test/f (and directory /opt/ssd/test) on partition mounted to /opt/ssd,
it does create /opt/ssd/test/f (and directory /opt/ssd/test) on partition mounted to /opt.

Env:
# cat /etc/centos-release
CentOS Linux release 7.0.1406 (Core)

# uname -a
Linux localhost 3.10.0-123.9.3.el7.x86_64 #1 SMP Thu Dec 18 20:10:00 MSK 2014 x86_64 x86_64 x86_64 GNU/Linux

# docker version
Client version: 1.3.2
Client API version: 1.15
Go version (client): go1.3.3
Git commit (client): 39fa2fa/1.3.2
OS/Arch (client): linux/amd64
Server version: 1.3.2
Server API version: 1.15
Go version (server): go1.3.3
Git commit (server): 39fa2fa/1.3.2

# docker -D info
[root@ac-srv-002 opt]# docker -D info
Containers: 11
Images: 200
Storage Driver: btrfs
Execution Driver: native-0.2
Kernel Version: 3.10.0-123.9.3.el7.x86_64
Operating System: CentOS Linux 7 (Core)
Debug mode (server): false
Debug mode (client): true
Fds: 53
Goroutines: 65
EventsListeners: 0
Init SHA1: c906504aa058139c1d0569ecd0aa5f462a73440f
Init Path: /usr/libexec/docker/dockerinit

@grossws
Could you give us a small reproducible case, shell script would be awesome.  I just want to see the mount options that you are using, SHARED, PRIVATE, REC, etc...

@crosbymichael, I'll try to reproduce this in vagrant, on the same centos version in several days, ok?

@grossws perfect.  Thanks.
I tried to reproduce but could not on my machine.  I tr

I believe I ran into this issue on a fresh Fedora 21 Server install with a remote mount.
Here is a small script that reproduces the problem:
#!/bin/bash

mkdir /tmp/a
mkdir /tmp/b
touch /tmp/b/foo
mount --bind /tmp/b /tmp/a
docker run -v /tmp/a:/opt/data:rw busybox ls /opt/data

On the initial run there is no output from the ls command. However, if you restart docker after the mount operation the ls command properly shows foo

@gsaulmon, your script reproduces similar issue. It also present on centos 7 with bind mount.
Sorry for delay with checking this in vagrant.

To reproduce is isolated env:
# vagrant should been preinstalled
vagrant init chef/centos-7.0
vagrant up
vagrant ssh

# in vagrant
sudo -i
yum -y install docker
systemctl enable docker
systemctl start docker
docker pull busybox:latest
reboot

# vagrant ssh again, as soon as rebooted
sudo -i
mkdir /tmp/a
mkdir /tmp/b
touch /tmp/b/foo
mount --bind /tmp/b /tmp/a

# this shows nothing but after docker restart shows "foo", as @gsaulmon said
docker run -v /tmp/a:/d busybox ls /d

To reproduce my case:
# in same virtual machine
mkdir /opt/s
dd id=/dev/zero of=/opt/d bs=128M count=128
mkfs.ext4 /opt/d # say "y" to proceed
mount -o loop /opt/d /opt/s

docker run --rm -v /opt/s/test:/data busybox /bin/sh -c "echo test > /data/f"
# will show file before docker restart
docker run --rm -v /opt/s/test:/data busybox /bin/sh -c "ls /data/f"
# doesn't show bind-mounted volume since it was created not on mounted /opt/s but on underlying partition.
ls /opt/s

# check that it's on underlying part
umount /opt/s
ls /opt/s/test

Thanks for the repo cases.  I'll take a look.

closing as fixed by #10147

It seems that this bug is still present in 1.12.6 on Amazon Linux (kernel 4.4.41-36.55.amzn1.x86_64).
1.12 is still default docker version there.
[ec2-user@ip-10-83-79-138 ~]$ cd testdir/
[ec2-user@ip-10-83-79-138 testdir]$ touch file_1
[ec2-user@ip-10-83-79-138 testdir]$ cd ..
[ec2-user@ip-10-83-79-138 ~]$ sudo mount /dev/xvdf testdir/
[ec2-user@ip-10-83-79-138 ~]$ cd testdir/
[ec2-user@ip-10-83-79-138 testdir]$ touch file_2
[ec2-user@ip-10-83-79-138 testdir]$ cd ..
[ec2-user@ip-10-83-79-138 ~]$ docker run --rm -it -v /home/ec2-user/testdir/:/mountpoint ubuntu /bin/bash
Digest: sha256:dd7808d8792c9841d0b460122f1acf0a2dd1f56404f8d1e56298048885e45535
Status: Downloaded newer image for ubuntu:latest
root@e395a98e1232:/# cd /mountpoint/
root@e395a98e1232:/mountpoint# ls
file_1
root@e395a98e1232:/mountpoint#

And if I do sudo service docker restart and then run the same container with the same mount, I'm able to see file_2 in mountpoint, as expected.

@bsod90 not the same thing.
How are you starting Docker, init.d?
Does this have an "unshare -m" call in it?

Hmm.. from the description is looked the same, sorry.
Amazon Linux is init.d based and yes, there's an unshare -m call in init script for docker.
@cpuguy83

@bsod90 That's the problem, you'll either need to remove unshare -m or after calling unshare -m and before starting dockerd run mount --make-rslave / (or whatever subdir you might be adding mounts to).

I see
Thank you!


Highlight breaks if filtered string contains HTML

I threw together this jsfiddle (http://jsfiddle.net/4FxZ7/1/) to demonstrate.  I used the same demonstration from your site except I wrapped the 'thank you' at the end of the filtered string in a  tag.  The highlight still works, but it throws a slew of errors to the console because the HTML sanitizer can't parse the broken HTML tags the highlighter creates.
To reproduce, go to http://jsfiddle.net/4FxZ7/1/ and search for 'thank'.  As soon as you hit the first character it will throw an error like this:
Error: [$sanitize:badparse] The sanitizer was unable to parse the following block of html: thank you.

UI.Utils modules was split in individuals repositories. If still valid, please consider re-submitting the issue on its dedicated issue tracker.
See the README for details.


Refetch reconcile service manifest for new changes (#3645)

Fixes #3645
Changes proposed in this pull request:

ReconciliationManager.refetchServiceManifest function has been created which can be used to refetch reconcile service  manifest provided service object as input.
Then the function has been used in ReconStandardServicePanel to fetch the latest manifest of selected service.

 Thank you for the review.
Yes, that makes sense. For this scenario my proposal would be as follow:

Okay, For the waiting part, I was thinking we can make a manifest call (with async:false) on the service list page itself.
Then
-1. on fail, throw alert if service is unreachable and stay on the same page
-2. on pass, we can re-register the service, and then move to next page.

For the second case, I think with this approach we will now have separate alerts. And we can prevent removal of service by
-1. while calling the manifest (on service list page), if success then only re-register
-2. if failed then do not re-register and throw an alert

Please feel free to let me know your approach or suggestions on this!
Also one question, for the loading part, is this component  DialogSystem.showBusy($.i18n('core-recon/contact-service')+"..."); responsible and could be used for this scenario as well? or there's any other common loading component I can use?

Thanks! That sounds like a good approach to me. I'd generally try to avoid async: false calls so I wound tend to formulate the new control flow with callbacks still, but arguably that's more of a matter of taste.

Also one question, for the loading part, is this component DialogSystem.showBusy($.i18n('core-recon/contact-service')+"..."); responsible and could be used for this scenario as well? or there's any other common loading component I can use?

That looks appropriate to me. We can try with this and see if it gives a satisfactory UX.

I'd generally try to avoid async: false calls so I wound tend to formulate the new control flow with callbacks still, but arguably that's more of a matter of taste.

I think it's a best practice, not just a matter of taste. Many browsers and performance tools will warn about synchronous calls blocking other activities.

Thank you @wetneb for your feedback! I understand your point about preferring callbacks over async: false calls. I'll make sure to refactor the control flow using callbacks for better flexibility. Regarding the loading component, I'll proceed with using DialogSystem.showBusy($.i18n('core-recon/contact-service')+"...") for now, as you suggested, and we can assess how it impacts the overall UX.
Thank you @tfmorris for pointing that out! I appreciate the clarification. I agree that avoiding synchronous calls is indeed best practice, especially with the performance implications you've highlighted. I'll ensure the control flow is updated accordingly.
Thanks again for your guidance!

Hello,
I have pushed new changes. It's much better now thanks to all suggestions. Also please feel free to remove docs, if not relevant, that I have added above function definitions.
Here's result screenshot for reference:

Thanks @wetneb  for the review. You are correct, I missed this use case. If I understand correctly, then we just have to make two calls (one with cors and one with legacy JSONP) like we do while registering the service. I have pushed the changes and below attached some result that I tested.
Result:

I added two logs to check the flow which shows that it's calling inner ajax on fail of outer ajax. Let me know if this approach is good enough!

Hi @akashinde, do you still intend to work on this?

@akashinde I'm closing this for now per inactivity, but happy to reopen when you're working on it again.


Copy PR template from main project

Signed-off-by: Daniel Widdis<EMAIL_ADDRESS>Description
This PR copies over the PR template from the main OpenSearch project site, which includes a check list prompting the submitter to write tests and add javadocs, and prompts reviewers to check for the same.
Issues Resolved
Part of a strategy to address #27.  Additional checks will be added in a later PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Doesn't look like this follows the template from opensearch-project/.github is cleaner. What do you think about using it instead?

It follows that template and adds the checklist to it. It's currently active for PRs on OpenSearch site (where I copied it from and it takes priority over the organization-wide default):
https://github.com/opensearch-project/OpenSearch/blob/main/.github/pull_request_template.md

OK, so this is probably a bigger question/comment/concern.
We should have a standardized template across all opensearch-project repos. The template @dblock has here accomplishes this: https://github.com/opensearch-project/.github/blob/main/PULL_REQUEST_TEMPLATE.md

+1 to this.

I don't think it's a good idea to have differing templates across the projects. @peternied raises some good points about whether we need to include items that are already part of the automated checks (tests pass; DCO signoff) and I'll be adding another PR to include javadoc checks as part of the gradle build.

Regarding the checklist
Check List

[ ] New functionality includes testing.

[ ] All tests pass.  -> This is covered by gradle check. We can remove this for OpenSearch and opensearch-sdk.

[ ] New functionality has been documented.

[ ] New functionality has javadoc added. -> Now since OpenSearch has strict javadoc rule as a part of gradle check. We can remove this as well for OpenSearch repo. SDK repo doesn't have the rule integrated yet.

[ ] Commits are signed per the DCO using --signoff -> We have DCO bot for all the repos of opensearch-project. We can remove this too.

+1 to @peternied. Lets just use whats the standard for our project.
@dbwiddis there are great questions here like redundant DCO, test pass etc. Probably a PR to .github upstream?


How to pass selected date to api

How can i pass the selected date to an api i'm developing? I send the InitDate variable, but sends the previous value of InitDate. Example: InitDate = 19/02/2019, i open the calendar and select 25/02/2019. The value of InitDate should be "25/02/2019" but sends "19/02/2019"

@cesarockstar1985 Did you find any solution for this?


Get starting data on non-alc places

We need location data to seed in, so we have some starting points


Do not hide server sidebar burger button on desktop browsers

Currently the button is only visible on mobile devices, however it could be desirable to hide channels on desktop too.

Should the title icon be removed? Or just show the button beside it?

I'm not fond of this suggestion, @xPaw. I'd rather not have yet another menu button always shown on the app.
Also, not trying to emulate others, but none of the desktop (Mac) clients for Skype, Slack or Telegram offer a way to hide the channels when window width permits it.

Just realised this is a duplicate of #17


docs *: Add files about monitoring #169

What type of PR is this?

/documentation
Which issue(s) this PR fixes?

#169
What this PR does?
Summary:

Add files about monitoring feature
Modify the path of deploy-files
Modify README.md and README_zh.md

Special notes for your reviewer?
n/a

ping @andyli029 , content has been reviewed and approved


Change API to be closer to the Android/D-Bus spec ?

I am working on adding support for D-Bus as a Linux backend to the flutter connector.
I am running into troubles because the Android API exposed here hides the token behind an instance chosen name instead, and store a mapping for that.
It complicated a lot of things when trying to abstract it, and I think staying closer to the specification and letting this to be handled by the user, or to some helpers instead, is perhaps not a bad idea.
What do you think ? The main problem is that we would break the API. I am however happy to propose something.

We can also not break the API, but this is going to be ugly, with some weird names for the new methods.

I made a prototype of linux flutter without having to change this library, though I never completed my implementation so I might be missing something. Do you want to discuss in UnifiedPush/flutter-connect#45 first? I'll post some more info about my experiments there soon

Well, it seems we did not write the spec for the instance extras - which I was pretty sure it was done. So we indeed made something that has been out of spec. :/
Actually the token identifies the connection between the app and the distributor. The instances have been added to easily have multi-account with a single endpoint per account.
https://github.com/UnifiedPush/specifications/blob/main/specifications/android.md?plain=1#L55

token: with a random token to identify the connection between the connector and the distributor. It MUST be unique on distributor side.

To argue in favour of updating the spec :

current spec with instances is backward-compatible since the instance extra is not mandatory ;
current android-connector and flutter-connector are not backward compatible if we remove the instance extra ;
the token is kept has an unique identifier between app and distributor.

But, I am not against keeping the spec without the instance, and removing it in the connector. Is it worth it ?

I am not sure we should add another identifier to the connection mainly for ease of use in the spec, it feels to me like it's an implementation detail and mainly cosmetic. It will add complexity to it, while it's currently pretty minimal and I find that great.
In my flutter prototype, for the platform interface, I have ditch some other interfaces (saveDistributor, registerAppWithDialog, ...) that are not in the spec (and cross-checked the D-Bus one), here is the end result:
  Future<List<String>> getDistributors()

  Future<void> registerApp(String distributor, String token, String app)

  Future<void> unregister(String token)

  Future<void> initializeCallback({
    void Function(String token, String endpoint)? onNewEndpoint,
    void Function(String token, String? message)? onRegistrationFailed,
    void Function(String token, String? message)? onRegistrationRefused,
    void Function(String token)? onUnregistered,
    void Function(String token, String message)? onMessage,
  })

  Future<void> initializeBackgroundCallback({
    void Function(String token, String endpoint)? onNewEndpoint, //need to be static
    void Function(String token)? onUnregistered, //need to be static
    void Function(String token, String message)? onMessage, //need to be static
  })

With that you can even register on several distributors at the same time and all should work fine.
This is the platform interface only however, I am currently trying to mostly not break the actual API by adding support for instance and distributor selection/dialog in the Dart code instead. Also I am currently not depending on the android connector anymore, I have copy paste some code but not really much in the end.
We could also do the same in the Android code, separate the code in 2 layers for example.

Sorry, I probably answered too late yesterday ! And I've got mixed up implementation and specifications.
So, the android-connector follows the specifications. The instance parameter is an implementation thing that identify a connection between the connector and the distributor. As we can see here, it is never sent to the distributor : https://github.com/UnifiedPush/android-connector/blob/main/connector/src/main/java/org/unifiedpush/android/connector/Registration.kt#L26-L31
Instance and token
There are 2 reasons we wanted the developers never have to deal with the token :

it is easier to use (no token has to be generated) :

registerApp(context) // single instance
registerApp(context, account1) // multi instance

https://github.com/UnifiedPush/android-connector/blob/main/connector/src/main/java/org/unifiedpush/android/connector/Registration.kt#L15

Developers won't do weak things, like using static token (I have seen a mastodon using a static private key for webpush). It would allow a malicious app to interact with the app and we don't want it.

Therefore, token generation will definitely not be given to the user.
Nevertheless, what you are describing can be very easily tweak :
  Future<List<String>> getDistributors()

  Future<void> registerApp(String distributor, String tokenIdentifier, String app)

  Future<void> unregister(String token)

  Future<void> initializeCallback({
    void Function(String tokenIdentifier, String endpoint)? onNewEndpoint,
    void Function(String tokenIdentifier, String? message)? onRegistrationFailed,
    void Function(String tokenIdentifier, String? message)? onRegistrationRefused,
    void Function(String tokenIdentifier)? onUnregistered,
    void Function(String tokenIdentifier, String message)? onMessage,
  })

  Future<void> initializeBackgroundCallback({
    void Function(String tokenIdentifier, String endpoint)? onNewEndpoint, //need to be static
    void Function(String tokenIdentifier)? onUnregistered, //need to be static
    void Function(String tokenIdentifier, String message)? onMessage, //need to be static
  })

Actually, that is what is already done, but we named the tokenIdentifier an instance to make it less technical. And the functions without tokenIdentifier are done for backward compatibility.
I will edit my previous post, I am sorry for the previous misleading answer. I hope it is more clear now.
Multi-Distributor
The instance/token said, there is still something different on your implementation :
## Today:
  UnifiedPush.saveDistributor(distributor);
  UnifiedPush.registerApp(tokenIdentifier); // instance=tokenIdentifier
## Your proposition
  UnifiedPush.registerApp(distributor, tokenIdentifier, app) // I have changed token to tokenIdentifier

So today saved a single distributor for the app and you suggest to set a distributor per connection. (app must be removed since it is the application package name on android).
That was also an implementation choice so end user won't have to choose the distributor for each account, to make it a bit more user friendly (which is not totally :laughing: ). It wasn't obvious to do it this way, we discussed about it. Do you think we should allow multi distributor per app, and why ?

Ahhh cool then we are basically in sync :)
Happy to keep that in the implementation for ease of use.
My interface is only the platform interface for the platform specific implementations, I can totally keep the instance mechanism, automatic token generation and distributor selection dialog at the user API level.
I'll ditch app indeed, I was already feeling that it was the right way to do it.
Thanks a lot for the feedback, you should have a PR pretty soon on flutter-connector and we can see from there I guess.

Ah and for multi distributors, I don't really know if there is a use case. I guess a fallback one ? But it would be a bit complicated since the app will have to deduplicate the pushes. As long as it stays a possibility in the spec in case of I am happy :)

Thanks a lot for your contribution, we will try to review it asap :)

And here it is:
https://github.com/UnifiedPush/flutter-connector/pull/56
No rush, this is a sizable one, and thanks for the nice welcoming around !

Can we close this issue (since it follows the specs :smile:) and continue on the flutter-connector PR ?

Indeed let's close that :)


JWTExpired errors after leaving the app open for a short while

I'm seeing JWTExpired errors when leaving the app open for a bit, suggesting the token refresh is not working correctly. It's a dealbreaker right now in terms of being able to use nhost in production because after a fairly short amount of time the app breaks because all queries/mutations/subscriptions stop executing and you have to refresh the entire app.
Similar to #21 but the errors I'm seeing are for any type of operation, not just subscriptions, so I don't think it's purely a websocket problem. I also saw https://github.com/nhost/nhost/issues/405 and it seems that the JS library had a very similar issue, so it might be that the Dart/Flutter library needs to implement the same logic to make sure that the app does not allow the JWT to expire.

Did you try simple implementation of this without any extra code?
i am leaving my app open when i.e. eating lunch and it never yelled at me, that the token expired.
After like 2 months of using it, i didnt have this problem once.

Can you try latest BETA version https://pub.dev/packages/nhost_sdk/versions/4.0.0-dev.8
It reuiqres you to pass subdomain and region

It's still there in 4.0.0.dev.13
User gets logged out after some time, automatically. Using all dependencies with 3.x-dev.x versions. Any hints?

please use new package https://pub.dev/packages/nhost_dart
I will depreciate the old package soon.
There is a maximum expiry date for the token however refresh token is issued, therefore, you can silently call the Refresh method to renew the token. This will avoid logout user
Please see this https://github.com/nhost/nhost-dart/issues/91#issuecomment-1378566909

Hi,
Thanks for the quick update. Will go through it and let you know how it goes!


Twipsy doesn't work with Modal windows (patch included)

Hi guys,
Twispy doesn't work on modal windows because of low z-index css attribute. The following CSS code fixes it:
.twipsy {
    z-index: 12000;
}

Fixed in dev branch already.


Accumulate the gradients of 2 models

Thanks for the great work! I met an issue where I hoped to accumulate the gradients of 2 networks. How can I handle it with accelerator.accumulate() function? Looking forward to hearing from you!

cc @muellerzr

This is a limitation on PyTorch and we have a mildly working hack, once we've tested it a bit more independently + verify with PyTorch it's "expected" behavior we'll bring it into Accelate directly

Thanks for the quick response! Looking forward to it! I will close this issue once it is included.


PWA: Can't edit icons in vue.config.js

Version
3.8.0
Environment info
  System:
    OS: macOS Mojave 10.14.5
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 12.3.1 - /usr/local/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 74.0.3729.169
    Firefox: 66.0.3
    Safari: 12.1.1
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.8.0
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.8.0
    @vue/cli-plugin-babel: ^3.6.0 => 3.8.0
    @vue/cli-plugin-pwa: ^3.6.0 => 3.8.0
    @vue/cli-plugin-typescript: ^3.6.0 => 3.8.1
    @vue/cli-service: ^3.6.0 => 3.8.0
    @vue/cli-shared-utils:  3.8.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/web-component-wrapper:  1.2.0
    typescript: ^3.4.3 => 3.4.5
    vue: ^2.6.10 => 2.6.10
    vue-class-component: ^7.0.2 => 7.1.0 (6.3.2)
    vue-hot-reload-api:  2.3.3
    vue-loader:  15.7.0
    vue-mixin-decorator: ^1.1.1 => 1.1.1
    vue-mixins:  0.2.20
    vue-portal: ^1.0.0 => 1.0.0
    vue-property-decorator: ^8.1.0 => 8.1.1
    vue-router: ^3.0.3 => 3.0.6
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
    vuex: ^3.1.1 => 3.1.1
    vuex-module-decorators: ^0.9.9 => 0.9.9
    vuex-persist: ^2.0.0 => 2.0.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

Create vue.config.js file with this content:

'use strict';

module.exports = {
    devServer: {
        port: 8087,
    },
    pwa: {
        icons: [
            {
                'src': 'icons/android-chrome-192x192.png',
                'sizes': '192x192',
                'type': 'image/png',
            },
            {
                'src': 'icons/android-chrome-512x512.png',
                'sizes': '512x512',
                'type': 'image/png',
            },
        ],
        iconPaths: {
            favicon32: 'icons/favicon-32x32.png',
            favicon16: 'icons/favicon-16x16.png',
            appleTouchIcon: 'icons/apple-touch-icon-180x180.png',
            maskIcon: 'icons/safari-pinned-tab.svg',
            msTileImage: 'icons/mstile-144x144.png',
        }
    }
};

Run yarn serve

What is expected?
The icons in the manifest should be the same path you entered in the config file.
What is actually happening?
The icons that used are the default.
https://github.com/vuejs/vue-cli/blob/dev/packages/%40vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js#L15
Chrome debugger:
Error while trying to use the following icon from the Manifest: http://localhost:8087/img/icons/android-chrome-192x192.png (Download error or resource isn't a valid image)

I'm using modern mode
I tried it only on development yet

same problem

For versions before v4.0.0-alpha.0, the manifest.json is copied to the public folder at plugin installation, meaning you have to edit it yourself there.
With version 4, the manifest.json is generate at build time by the plugin. You can alter the default manifest options via pwa.manifestOptions at the vue.config.js file, or the "vue" field in package.json. For details, you could refer to the latest README.md at the dev branch.

We currently don't have plugins documented directly on the documentation website, but simply link to their README files on github on the dev branch.
this is the reason for OPs mistake. They read the README and found docs there that they should be able to make the change, because the README on the dev branch already contains the docs for this feature, even though the current stabvle release doesn't support it yet.
Sorry for that :(
I think we should dedicate some time to create some minimal docs for each core plugin on the documentation website to prevent such confusion in the future.

@LinusBorg I would like to work on this 😅

That's awesome!
Since this issue here is about a specific misunderstanding with one plugin, would you open a new issue where we can discuss the approach?
Then we can close this issue here with reference to the new one.

@LinusBorg done!

Closing in favor of #4117

@LinusBorg Are you sure that icons array is now modifiable from the vue.config.js/package.json?
I updated my CLI version to v4.0.0-beta.1 and my icons array isn't get updated in the manifest.json file, I still can see the default values.

I updated my CLI version to v4.0.0-beta.1

Did you update all of the @vue/* packages in package.json as well? the @vue/cli package is only responsible for creating the initial boilerplate, the actual config etc happens in the plugins that you see ion your project's dependencies.

@LinusBorg Yes, I did.

Right. Got thosse mixed up.
However I now spotted the mistake:

pwa.icons is used for the icons in the meta tags only.
pwa.manifestOptions takes all options for the manifest file, so you have to define the icon options for the manifest here as pwa.manifestOptions.icons. You defined pwa.icons though.

@LinusBorg Gotcha, thanks, it works!

@LinusBorg nice, thats works for me

@LinusBorg Would it pe possible to add the icon parameter in the example of pwa.manifestOptions.icons in the doc ?
For people like me who start discovering the world of pwa directly with vue-cli its confusing on how is generated the icons parameter of the generated manifest.json
I lost an hour to finally end up on this issue to find the solution.
Besides this little issue the PWA integration in Vue CLI is really great ! You made a really great work !!

I opened a new issue, #5407, and a corresponding PR #5408 Which should clear up the confusion around icons.

I still couldn't figure out how to change my favicon. Can someone help me?

@Syiabonga the bug is still there. it is a bug, not a documentation issue.

@Syiabonga the bug is still there. it is a bug, not a documentation issue.

Right. Got those mixed up.
However I now spotted the mistake:

pwa.iconPaths is used for the icons in the meta tags only.
pwa.manifestOptions takes all options for the manifest file, so you have to define the icon options for the manifest here as pwa.manifestOptions.icons. You defined pwa.icons though.

thanks man!

Right. Got those mixed up.
However I now spotted the mistake:

pwa.iconPaths is used for the icons in the meta tags only.
pwa.manifestOptions takes all options for the manifest file, so you have to define the icon options for the manifest here as pwa.manifestOptions.icons. You defined pwa.icons though.

Can someone tell me please why is this not written in the documentation? Wasted so much time on this... Once you know it is logic to set it in pwa.manifestOptions.icons, but since it doesn't mentioned in the doc, it's very hard to find out.


zstd seems to use default (1) number of threads

We've noticed that on fast machines zstd usage in crane appears slow and bottlenecks on saturating only one CPU, even though zstd is supposed to support multi-threaded compression&decompression.

As far as I can tell, zstd does not support multi-threaded decompression: https://github.com/facebook/zstd/issues/2470

Well, we'll take what we can. AFAICT zstd -o ... used currently for compression could use -T0 and we'll see if decompression is still an issue.

I was going to wonder whether zstd compression is deterministic and according to https://github.com/facebook/zstd/issues/2079 it is!
Though it looks like cargo artifacts themselves aren't deterministic. That said I have no issue with using -T0 since we'd have to solve that non-determinism separately anyway
@dpc feel free to try out #183


Network error: the network request failed on some phone brand and POST type requests

Description
Hello
Our application is in production and has problems for POST type requests. On some phone brands and all android versions (5, 6, 7,8,9,10). and on the other hand the Post type requests work very well on other phones and all android version (5,6,7,8,9,10)
The exact error produced is: Error · Error: Network error: Network request failed.
React native command result:
Different solutions already tested:

By default, access to our backend is via https using cloudflare. I even thought that it could be an https certificate problem, I changed cloudflare to use a certificate from
Let's Encryptletsencrypt, until then we have the same problem.

We figured this was a problem with the https protocol and decided on http and added to AndroidManifest.xml the directive:
<android application: usesCleartextTraffic = "true">
</application>

despite all this we have the same problem namely the POST type request are not functional on some brands of phone and any android version (5,6,7,8,9,10)
Thank you for any help in relation to this problem because at this time we already no longer block more than 1200 Registrations on our Mobile application.
React Native version:
System:
    OS: Linux 4.19 Debian GNU/Linux 10 (buster) 10 (buster)
    CPU: (4) x64 Intel(R) Core(TM) i3-5005U CPU @ 2.00GHz
    Memory: 761.15 MB / 11.65 GB
    Shell: 5.0.3 - /bin/bash
  Binaries:
    Node: 10.15.2 - /usr/bin/node
    Yarn: 1.17.3 - /usr/bin/yarn
    npm: 6.14.5 - /usr/bin/npm
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>14223
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-rename: 2.4.1

Related? #28551

We have facing the same problem also using GET method. Some phones (Android e iOS) doesn't work.

fixed TypeError: Network request failed when upload file to http not https with Android debug builds


Fix var args and kwargs positions

When merged, the var args and kwargs stay at the position they were in the parent signature and child parameters could appear after them, whereas they shall be at the end.
This PR move those parameters at the end of the parameters section.

Why does *args need to be at the end? The following is valid:
def f(x, *args, y):
    # y is a keyword-only argument

I fully agree!
My use case was **kwargs only and I've added *args without thinking enough.


Binary range search?

The question has been re-posted on StackOverflow: Binary search through IPv6 addresses
I appreciate, if you can provide some input on it, either here or on StackOverflow.
Thank you!

Sort them, then use a regular binary search over an array.

What do you think would the the most suitable presentation for IPv6 address to make the compassion fast?
I was thinking of a possibility to convert IPv6 into a test string, so the addresses can be compared as simple strings. That's just to be an alternative to integer conversion, because using 128-bit integers isn't feasible in JavaScript.
Any idea how to convert IPv6-s into comparable text strings? By comparable I mean so you have range {first, last}, and you want to be sure when you compare your IPv6 address as first <= MyAddr <= last you would get the right result.

The simplest one would be to represent an IP address as a string byte by byte, starting with the least significant.

That sounds well, I just don't know how to do that, given the complexity of IPv6 range presentation. I was hoping to borrow some of your expertise on the subject of doing such conversion.

Since you didn't come back, I re-published my question on Stack Overflow: http://stackoverflow.com/questions/30329991/ipv6-as-a-comparable-javascript-string


No such file or directory @ rb_sysopen

I just upgraded to buybug 4.0.0 I and get this error:
No such file or directory @ rb_sysopen - /home/khursev/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/byebug-4.0.0/lib/byebug/printers/texts/plain.yml
instead of the debugging console when execution reaches buybug in the code.
Ubuntu version: Ubuntu 14.04.2 LTS
Ruby version: 2.2.0
Please tell me if you need more information.

Uups, sorry about that. It should be fixed in 4.0.1.

Yes, it's fixed. Thanks!


chore: use libc::fsync in writeout

#317  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gabriele-0201 and the rest of your teammates on  Graphite


Dark theme

I would like to build a button to toggle between light mode and dark mode in the vertical navbar

Hi, @Akshatchaube01  , you can work on this and please refer to the Contribution guidelines on the readme once.
All the best!

Any updates or I close this issue, @Akshatchaube01 ?


Using exogenous variables with AutoNHITS

Hi,
Thanks a lot for this library!
Is there a way to use exogenous variables with the AutoNHITS wrapper? I would like to perform hyper-param tuning for the NHITS with exogenous variables in the mix.

Hi @SwapnilDreams100,
You can perform hyperparameter tuning exploring exogenous variables hist_exog_list like this:
nhits_config = {
    "scaler_type": tune.choice(['robust']),
    "hist_exog_list": tune.choice([[f'y_[lag{seasonality}]']]),
    "learning_rate": tune.choice([5e-2, 1e-3, 5e-3]),                                  # Initial Learning rate
    "max_steps": tune.choice([100, 1000]),                                             # Number of SGD steps
    "input_size": tune.choice([3 * horizon]),                                          # input_size = multiplier * horizon
    "batch_size": tune.choice([64]),                                                   # Number of series in windows
    "windows_batch_size": tune.choice([256]),                                          # Number of windows in batch
    "n_pool_kernel_size": tune.choice([[2, 2, 2], [4, 2, 1]]),                         # MaxPool's Kernelsize
    "n_freq_downsample": tune.choice([[12, 4, 1], [24, 12, 1], [4, 2, 1], [1, 1, 1]]), # Interpolation expressivity ratios
    "mlp_units":  tune.choice([[[512, 512], [512, 512], [512, 512]]]),                 # 2 512-Layers per block for each stack
    "val_check_steps": tune.choice([100]),                                             # Compute validation every 100 steps
    "early_stop_patience_steps": tune.choice([5]),
    "num_lr_decays": tune.choice([-1, 3]),
    #"random_seed": tune.randint(1, 10),
}

models = [AutoNHITS(config=nhits_config,
                    loss=GMM(n_components=num_components, level=list(level)),
                    h=horizon,
                    search_alg=HyperOptSearch(),
                    num_samples=num_samples)]

# Fit and predict
nf = NeuralForecast(models=models, freq=frequency)

Y_hat_df = nf.cross_validation(df=Y_df,
                               static_df=static_df,
                               n_windows=None,
                               val_size=val_size,
                               test_size=test_size)

In principle all AutoModels should be able to receive in their config dictionaries the instantiation parameters of the neuralforecast inherited Models.
Here is a link to AutoNHITS example: https://nixtla.github.io/neuralforecast/examples/longhorizon_with_nhits.html
Here is a link to NeuralForecast inherited models documentation: https://nixtla.github.io/neuralforecast/models.nhits.html
Hope this helps.

Thanks a lot!


⚠ TROJAN 🇸🇬 Singapore SGV 1 has degraded performance

In 5f17cb9, TROJAN 🇸🇬 Singapore SGV 1 (https://sgt-1.optnl.com/) experienced degraded performance:

HTTP code: 200
Response time: 11604 ms

Resolved: TROJAN 🇸🇬 Singapore SGV 1 performance has improved in bbf910e.


Reduce build time dependencies

Avoid the pulling in (at build time) of unnecessary Artemis dependencies (and its dependencies).  This simplifies EnMasse's build time footprint.  No functional change.

I just use mvn dependency:tree

215fecb avoids build time dependencies on a bunch of dependencies of keycloak-services itself (such as Twitter).

I was more thinking how you determine which dependencies are only required build time vs run time

I was more thinking how you determine which dependencies are only required build time vs run time

Nothing fancy.  I was just examining the contents of the Jar artefact produced and reasoning from there.  If we are producing a plugin for a product, then the only classes that need to exist on the class path at compile time are those needed to compile for the plugin.  Everything else is superfluous.  At runtime, it is just the plugin's classes and any dependencies the plugin introduces itself.


adds std_normal_log_qf

Summary
Adds the quantile function of the standard normal density function with log input.
Release notes
Adds the quantile function of the standard normal density function with log input.
Checklist

[x] Math issue #2697

[x] Copyright holder: Sean Pinkney
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@andrjohns I cannot get the mix test to work. It just gives a google test error of xml failed. I'm just trying to get this to run and so I haven't updated the derivatives. At the moment, I'm using the same code as in the rev code for the inv_Phi function to see if I can get the mix test to at least run.
The prim tests pass. Maybe you have an idea of how to get this to work?

I don't understand why this segfaults the google test framework. I believe it has to do with a template issue. I'm following the same template as in inv_Phi. The two main differences to inv_Phi are that this function uses functions in stan::math instead of std and it uses long double types. I've changed the long doubles to doubles but still the same issue. Also do we support long double types?
@rok-cesnovar @bob-carpenter @SteveBronder or someone else with template expertise may
test/unit/math/mix/fun/inv_Phi_log_test --gtest_output="xml:test/unit/math/mix/fun/inv_Phi_log_test.xml"
Running main() from lib/benchmark_1.5.1/googletest/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from mathMixMatFun
[ RUN      ] mathMixMatFun.invPhiLog
test/unit/math/mix/fun/inv_Phi_log_test --gtest_output="xml:test/unit/math/mix/fun/inv_Phi_log_test.xml" failed
exit now (05/09/22 07:16:59 EDT)

Nevermind, with all the stan math functions I just need to templatize it.

@andrjohns or @SteveBronder this is ready for review

The impetus to add this function to the language was due to @andrjohns testing normal copula models in Stan and he found the numeric stability of working on the original scale problematic. Which is the same reason we typically work with _lcdf functions rather than _cdf. In the normal copula example one typically is interested in modeling each univariate margin of the multidimensional outcome as a (possibly) separate distribution and connecting each of these univariate margins by a multinormal correlation. The "trick" to model this is by transforming each univariate margin via their specified cdf into a probability which is then transformed again into "normal-space" via the normal quantile function - i.e. inv_Phi. Instead of using the cdf to begin the "trick", it is much computationally stable to use the log cdf. This, in turn, suggests to continue working on the log scale via inputting the log probability value into a modified quantile function which works on the log scale but still outputs to the same space as the original quantile function.
The idea can be expressed in the following pseudo-stan code (assuming we had a multi_normal_cholesky_copula_lpdf function):
data {
  int<lower=0> N;
  int K;   // K is 2 here
  matrix[N, K] x;
}
parameters {
  array[K] real mu;
  array[K] real<lower=0> sigma;
  cholesky_factor_corr[K] L;
}
model {
  target += gumbel_lpdf(x[ : , 1] | mu[1], sigma[1]);
  target += lognormal_lpdf(x[ : , 2] | mu[2], sigma[2]);

  {
    matrix[K, N] y;
    for (n in 1 : N) {
      y[1, n] = inv_Phi(gumbel_cdf(x[n, 1] | mu[1], sigma[1]));
      y[2, n] = inv_Phi(lognormal_cdf(x[n, 2] | mu[2], sigma[2]));
    }
     y ~ multi_normal_cholesky_copula(L);
  }
}

The addition of this inv_Phi_log means we can modify the above to the more computationally stable version of
data {
  int<lower=0> N;
  int K;   // K is 2 here
  matrix[N, K] x;
}
parameters {
  array[K] real mu;
  array[K] real<lower=0> sigma;
  cholesky_factor_corr[K] L;
}
model {
  target += gumbel_lpdf(x[ : , 1] | mu[1], sigma[1]);
  target += lognormal_lpdf(x[ : , 2] | mu[2], sigma[2]);

  {
    matrix[K, N] y;
    for (n in 1 : N) {
      y[1, n] = inv_Phi_log(gumbel_lcdf(x[n, 1] | mu[1], sigma[1]));
      y[2, n] = inv_Phi_log(lognormal_lcdf(x[n, 2] | mu[2], sigma[2]));
    }
     y ~ multi_normal_cholesky_copula(L);
  }
}

My questions to @bob-carpenter, @bgoodri, @SteveBronder, @WardBrian, and @andrjohns is that when we start adding _qf we should also add the log input version. This at least doubles the work - though probably more than doubles because I don't think anyone has code/math written out for these. Secondly, what naming convention would be appropriate? This pr has _log as the suffix but the typical quantile function will have _qf and we don't want log to come after nor do we want log to be before the qf (such as _lqf) because that seems to suggest a log output.
One obvious choice is to append l like _qfl and then if we have log-output quantile functions it would be _lqf and _lqfl.  Or we could be a bit more descriptive and add lp for log-probability. Something like _lpqf and lplqf for log-probability quantile function and log-probability log quantile function, respectively. I think this more appropriately conveys what's happening and I tend to read it as "log-input x".
This PR can then be aliased to std_normal_lpqf.

Until 2.32, _log is still used for probability distribution functions, and anything that isn’t one of those ends up being special cased in the compiler. This is why things like multiply_log are renamed/deprecated (though, in theory, we only needed to deprecate either their use in probability functions or their use elsewhere to get sane behavior, but both have been deprecated).
I think lmultiply already breaks the convention, as the log is applied to one of the two inputs

@WardBrian this case is quite different in that the log suffix signifies that the function takes the log of the traditional input but outputs the same.

Ah, I see. I think conveying that information via a suffix alone won’t be possible, people will need to read the doc to use it properly
If anything, such different behavior calls for an entirely new nomenclature so that users don’t try to put it into a pre existing notion they have from other functions.  Maybe like inv_Phi_logscale? I’m not terribly creative about such things

Let me change the name to std_normal_log_qf, I'm happy to have consensus and to make that change!

multiply_log(x, y) = x * log(y).  So the log was an operation applied, not the scale of the argument.   lmultiply is a common name for this function, but it doesn't follow our more verbose conventions.

@WardBrian does this stay in the fun directory or do we want _qf functions in the prob directory?

That’s a good question but I defer to someone with more experience in this repo like @bob-carpenter @SteveBronder

The _qf functions should go in the prob directory.  That way, we'll have all the foo_suffix functions together for distribution foo.

The _qf functions should go in the prob directory. That way, we'll have all the foo_suffix functions together for distribution foo.

Alright, that's what I thought but it comes with some complications. This function is different than the current prob functions in that it is vectorized in both the input and output. There is a rev specialty but our prob functions have the partials written in to them. I would like to make a prob subdirectory in the rev directory so I can just move this function over into prim -> prob and rev -> prob but I don't know if that will have any unintended side effects.
Or I can try writing it all in prim -> prob with the partials in and a vectorized return. I'm not sure how this is supposed to look because all the prob functions return a scalar.
I'm asking two questions:

Should I make a rev -> prob folder which houses all the rev-derivatives for _qf and hypothesized _v* (as in vectorized versions of lpdf, lcdf, etc) prob functions
or vectorize the prob function and have the partials written in prim like the current prob functions?

Forget what I said.  I have no idea how the devs currently want things organized, so I suggest asking someone more actively working on Stan's C++ than me.

@rok-cesnovar would you be willing to work with me on this?


ci: Delete jobs that are not part of SDLC process anymore

Description
Deleting CypressAddKnownfailedtests because the job was meant to help with maintaining our flaky tests list, but we have an Appsmith app to manage this now.
Deleting label-checker because we do not follow the process for "Test plan approved" anymore.
Automation
/ok-to-test tags=""
:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

@sharat87 @pratapaprasanna  Are you sure we want to remove the packer-ami CI job? I know we haven't built an AMI in a while, but do you believe it's good to have a CI job that does this?

@mohanarpit Goutham mentioned that we have moved this job to the cloud-deployment repo and is hence okay to be removed from here.


[docs] Add vale ini and styles for docs linting

Description
This PR adds the .vale files to the /docs folders of vizro-core and vizro-ai so that I can manually run vale on docs pages as I work on them.
At some point I need to work with @l0uden to add this to our CI. We can do this as part of the PR but equally, as long as these files are in place, I can just invoke Vale for now.
Screenshot
Notice

[ ] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

I'm not sure what the problem with the vizro-ai docs build is but I haven't changed anything in the docs build, so will investigate separately. It may be that we can/should put a single set of Vale files in the root of vizro to avoid duplication across core and ai folders?

Yes, ideally we would only have one folder with those files!
How are you using it, how is it invoved? Can we add it to pre-commit such that it gets invoked with our hatch run lint command. Then it should be not a problem in CI either, as this is done automatically!

How are you using it, how is it invoved? Can we add it to pre-commit such that it gets invoked with our hatch run lint command. Then it should be not a problem in CI either, as this is done automatically!

At present, I'm just invoking vale from the same folder as vale.ini and pointing at an individual file or folder to target. It's probably worth thinking how we want to use it across our docs -- we could either take the big hit of fixing everything in one, and then run across the full docs, or we could apply it just to any markdown file in a PR, which I think is what Kedro do https://github.com/kedro-org/kedro. I don't really mind which as long as it's available to check anything I'm working on. I think it can become annoying (it's still not fully tweaked for our purposes, so will be moaning about things) so I'm happy to spend more time on the styles to get them adjusted to Vizro lexicon.
As I'm not an engineer and not very well-versed in setting up this kind of tooling, please can I pass this one over to whoever could finish the PR from that perspective?
If you want to run across the full docs set, I'll need to put some time in place to read the issues and tweak styles or docs to get things passing.

How are you using it, how is it invoved? Can we add it to pre-commit such that it gets invoked with our hatch run lint command. Then it should be not a problem in CI either, as this is done automatically!

At present, I'm just invoking vale from the same folder as vale.ini and pointing at an individual file or folder to target. It's probably worth thinking how we want to use it across our docs -- we could either take the big hit of fixing everything in one, and then run across the full docs, or we could apply it just to any markdown file in a PR, which I think is what Kedro do https://github.com/kedro-org/kedro. I don't really mind which as long as it's available to check anything I'm working on. I think it can become annoying (it's still not fully tweaked for our purposes, so will be moaning about things) so I'm happy to spend more time on the styles to get them adjusted to Vizro lexicon.
As I'm not an engineer and not very well-versed in setting up this kind of tooling, please can I pass this one over to whoever could finish the PR from that perspective?
If you want to run across the full docs set, I'll need to put some time in place to read the issues and tweak styles or docs to get things passing.

Ok I see :)
Can you estimate how long the full pass would take? I think if we make this PR the introduction of vale, then there is no harm in it sitting here a bit longer. Ultimately I would like it to be another linter, because this is the only way to achieve consistency. Let me take a quick look what we can do, can I work into this PR?

@maxschulz-COL Yes please feel free to commit on this branch and take it on. I think a full pass would be less than a day of tweaking.

@maxschulz-COL Yes please feel free to commit on this branch and take it on. I think a full pass would be less than a day of tweaking.

Ok then let's go for that option, I will setup the pre-commit version of it

@stichbury I think you are good to go - vale can be invoked via hatch run lint, and it will also do so in CI :) Let me know if there are still any issues.
So the plan is to fix the existing vale errors, warnings and suggestions, tweak the setting a little, and then have our docs perfectly styled all the way 😎 ?

@stichbury Please double check if I messed up anything with the styles folder - I just copied over the one from the vizro-core, it's now all in a central place

Thank you, that is all fine! It all looks great, and I'll make a branch from this one to fix up the docs errors and tweak styles to get all building cleanly as we go forward. Thanks for making the changes to get it in the tooling!


How can compare date vs TimeStampedModel?

Hello Sir.
In my django app how can i filter by date in TimeStampedModel fields?
I am tried
`from datetime import date
date = date(2016, 5, 22)
Order.objects.filter(created_attr__date=date)
`
But failed with error "Cannot resolve keyword 'created_attr' into field"
Please tell me how to resolve?
Many thanks

Hi! Where did you get created_attr from? The field on TimeStampedModel is called just created, so the query would be .filter(created__date=date).

resolved, thank man

Hello @carljm. This is still issue with me, some day ago i resolved my issue is i want to  get query from date to date, so i make query by Order.objects.filter(created__range=(start_date, end_date)) But to day i try to make a more simple query by Order.objects.filter(created__date=today) as you sussgested above but it make an error "Unsupported lookup 'date' for AutoCreatedField or join on the field not permitted."
Please help me how to resolve?
Many thanks.


Skip CI on draft PRs

This shows how to skip the CI run on draft PRs, useful if using paid runners with long-running CI.

This is helpful -- can you just add a link in the comment to where the different choices are listed as well?

Added! There are so many options for github actions that's it's almost a language in itself! might even be Turing complete :smile:

Added! There are so many options for github actions that's it's almost a language in itself! might even be Turing complete 😄

I'm going to rewrite Caiman in github actions. 😆

One thing we recently is that this repo is in an ambiguous state at the moment -- is the point the docs or the code? should people be able to fork this and start from here, or should they read it / treat it as reference material? I think we're leaning towards the docs / reading, so to that end, can you also add a bit of explanation in the corresponding notes file? (06-ci.md)


IOS tap gesture FAILS on latest IOS OS and Mac OSX

This control worked perfectly for me until March, 2020.
I began having trouble running and debugging with my Phone, so updated OSX (10.15.4) and IOS (13.4).  My coding environments all changed as well. The Mac build server is now on <IP_ADDRESS> and <IP_ADDRESS>.
The problem is that the pancake view no longer responds to taps. Android works fine.  The code is unchanged from a month ago.
I have monkeyed around with InputTransparent, but the fact that Android works indicates that something fundamental changed in these last Apple releases.
Can you have a look?  Just add a tap gesture recognizer to a pancake view, build & run with Apple's latest, and see what happens.
Thank you!

Unfortunately this is not an issue in PancakeView but on a higher level. You can read more about it here: https://github.com/xamarin/Xamarin.Forms/issues/10162
Hope that helps!

Hi Steven,
Thanks, IOS is not currently connecting except with a yellow flag, but
cleary tha is not your fault.  I appreciate the clarification.
On the Android side, this error has popped up:
*Severity Code Description Project File Line Suppression StateError Can not
resolve reference: Xamarin.Android.Support.Compat, referenced by
Xamarin.Forms.PancakeView. Please add a NuGet package or assembly
reference for Xamarin.Android.Support.Compat, or remove the reference to
Xamarin.Forms.PancakeView. VDT.Mobile.Android   *
I don't declare the Pancake view under Android currently.  I just include
it in my Forms project.
Stephen
On Thu, Apr 2, 2020 at 10:48 PM Steven Thewissen<EMAIL_ADDRESS>wrote:

Unfortunately this is not an issue in PancakeView but on a higher level.
You can read more about it here:
https://github.com/xamarin/Xamarin.Forms/issues/10162
Hope that helps!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sthewissen/Xamarin.Forms.PancakeView/issues/83#issuecomment-608242537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABW5SC2B3EQUTVMLCA2DV53RKV2DFANCNFSM4L3MFS5A
.

Please try installing it on each platform you want to use it. Other than that this is not specifically a bug in PancakeView itself and the original bug is a Xamarin bug, so I will close this for now.


tolerating missing optimizer states for MoE [2nd attempt]

Fixes #2737
When load_optimizer_states=False is used for MoE load_checkpoint - do not attempt to load the optimizer state files.
This currently fails as DeepSpeed still attempts to load those, even though they are not used afterwards.
Previous attempt: https://github.com/microsoft/DeepSpeed/pull/2738

For your consideration, @tjruwase.

@tjruwase is there on-going issue with HuggingFace integration tests? This looks unrelated to my changes.

@tjruwase is there on-going issue with HuggingFace integration tests? This looks unrelated to my changes.

I am not sure if there is an on-going issue with HF. Are you able to run the tests on your side?

@tjruwase is there on-going issue with HuggingFace integration tests? This looks unrelated to my changes.

I am not sure if there is an on-going issue with HF. Are you able to run the tests on your side?

I'll double-check.

@tjruwase HuggingFace tests work fine for me:
====== 1 failed, 42 passed, 94 skipped, 30 warnings in 296.84s (0:04:56) =======

The only failure is some hardware incompatibility:
self = <op_builder.async_io.AsyncIOBuilder object at 0x7f7371078880>
verbose = False

    def jit_load(self, verbose=True):
        if not self.is_compatible(verbose):
>           raise RuntimeError(
                f"Unable to JIT load the {self.name} op due to it not being compatible due to hardware/software issue. {self.error_log}"
            )
E           RuntimeError: Unable to JIT load the async_io op due to it not being compatible due to hardware/software issue. None

Triggering another build.

Addressed your feedback, @tjruwase.

@tjruwase thanks for approving this PR, 3 (seemingly unrelated) HuggingFace tests still fail. Should I keep retrying, do you know if it's being looked at or a known issue?


forgot $event dependecy onMouseUp HostListener

Hey,
please add $event dependecy on mouseUp event.
from:
@HostListener('document:mouseup')
to:
@HostListener('document:mouseup', [ '$event' ])
so we can use event parameter.

@morwn added. Watchout if you are using an earlier version than 1.3.0 and if you are somehow using an handler.  https://github.com/cedvdb/ng2draggable#drag-element-with-child-element


feat: umbrel connector

TODO:

[x] Find a proper icon
[x] Figure out how to change the connect URI to http://umbrel.local:58000/apps/new?...
[x] Add intermediate step for description how to connect (otherwise the popup just opens a non-existent page :thinking:)

@reneaaron I am happy to merge it, can you change it out of draft status?


Issue 5 submit repair request page

Change Summary

Created basic frontend page to submit repair request
Added brand, item-types GET endpoints
Added repair-request POST endpoint
Added zod library
Added test for repair-request POST endpoint
Added reset database command to clean up function for test

Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[x] The change has tests
[ ] The change has documentation

Other Information
Still to-do:

Events GET endpoint and replace hardcoded events in the frontend
Add disclaimer popup and image upload functionality

Related Issue

Resolve #5

thanks baby g @dct0


Improvements to editor interface migrations

Changes
When changing the editor interface of a field, I'd like to see those changes listed in the intents before approving the migration.

Include field settings in editor interface intent
Fix true/false label types
Extend documentation for changeEditorInterface

I'm not sure if this is the proper way of doing it — one thing that bothers me is that there's no spacing between the editor interface intent and the next intent. I couldn't figure out how to add it.
Happy to be pointed in the right direction :)

Thanks @connor-baer


How much memory do i need？ Or What parameters do I need to adjust

torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 17.14 GiB. GPU 0 has a total capacty of 79.33 GiB of which 9.96 GiB is free. Process 21567 has 69.36 GiB memory in use. Of the allocated memory 68.87 GiB is allocated by PyTorch, and 7.84 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
I use A800 80GB to run python models/dino/ops/test.py
The error is above

Hello,
It's perfectly fine if you encounter an error when running models/dino/ops/test.py, particularly the CUDA out-of-memory error you mentioned. This script is mainly intended to check if the deformable attention module is installed correctly. As long as the initial checks pass, the installation is successful.
On my system, for example, I see the following results:
`* True check_forward_equal_with_pytorch_double: max_abs_err 8.67e-19 max_rel_err 2.35e-16

True check_forward_equal_with_pytorch_float: max_abs_err 4.66e-10 max_rel_err 1.13e-07
True check_gradient_numerical(D=30)
True check_gradient_numerical(D=32)
True check_gradient_numerical(D=64)
True check_gradient_numerical(D=71)
True check_gradient_numerical(D=1025)
torch.OutOfMemoryError: CUDA out of memory. Tried to allocate 7.50 GiB. GPU 0 has a total capacity of 47.54 GiB of which 3.87 GiB is free. Process 3398236 has 4.84 GiB memory in use. Including non-PyTorch memory, this process has 38.82 GiB memory in use. Of the allocated memory 37.53 GiB is allocated by PyTorch, and 1.00 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)`

If the first few gradient checks (like check_gradient_numerical(D=30)) pass, the deformable attention module is installed correctly. The CUDA out-of-memory error usually happens with larger configurations (like D=1025), which aren't needed.
Feel free to ask if you need more help!


Improve .flip module

Codecov Report

Merging #385 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +0.01%
==========================================
  Files          33       33
  Lines       10853    10870      +17
==========================================
+ Hits        10377    10394      +17
  Misses        476      476


support switch lb rule vip in the same subnet as its backend ip

Feature request
support switch lb rule vip in the same subnet as its backend ip
01-swtich-lb-font-vip-backend-ip-use-the-same-subnet.md

https://github.com/ovn-org/ovn/issues/190


Remove plugin backend widgets after uninstall

1. Why is this change necessary?
Most parts of a plugin will be automaticly deleted after uninstall. Its missing for widgets
2. What does this change do, exactly?
Removes all widgets of a plugin after uninstall
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
That the process is now handled by plugin manager
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21081
Please use this issue to track the state of your pull request.

Hey @shyim,
thank you for your contribution! 💙
Unfortunately this might be an annoying feature when using the "re-install" method.
Probably a better way to fix this behavior would be to add a SQL-check while reading the backend widgets.
The check should be something like "if this element is part of a plugin, check if the plugin is also active, otherwise skip this element".
Can you please consider this suggestion and create a new PR for this? :-)


[DNM] Check swift-wasm-5.7-SNAPSHOT-2022-09-18-a

OK, I confirmed the latest snapshot works well :)


New App Submission

App Logo (Required)
(Attach image here)
App Details (Required)
Type: Wallet or Dapp
Name: Marco wallet
Homepage Url: metamask.io
Chains supported:
0xe33d2C1223A025c8B89d4C12eC09Bb951E6f4D91
App Url (Required - at least one)
Browser Url:
iOS Url:
Android Url:
Mac Url:
Windows Url:
Linux Url:
Mobile Linking (Optional)
Deep Link:
Universal Link:
Desktop Linking (Optional)
Deep Link:
Universal Link:
Metadata (Optional)
Short Name:
Primary Color:
Secondary Color:

This issue will be closed since required content is missing.


Zip download doesn't have sub modules

need to have ds check for submodules.
need to put separate zip file in readme for downloading.

new master update scheme hard copies sub modules into master and hence zip now


iOS Background Location

🚀 Feature Requests
Hi, would it be possible to add a way for us to tweak the background location setting of the iOS location manager?
Contextualize the feature
AppleSettings(
        accuracy: LocationAccuracy.high,
        activityType: ActivityType.airborne,
        allowsBackgroundLocationUpdates: true,
        showsBackgroundLocationIndicator: true,
      )

Would set
if (@available(iOS 9.0, *)) {
                self.clLocationManager.allowsBackgroundLocationUpdates = enable;
            }
            if (@available(iOS 11.0, *)) {
                self.clLocationManager.showsBackgroundLocationIndicator = enable;
            }

Describe the feature
Adding addition options for Apple Settings to configure the clLocationManager allowsBackgroundLocationUpdates and showsBackgroundLocationIndicator.
Platforms affected (mark all that apply)

[X] :iphone: iOS
[ ] :robot: Android

Hi @Wackymax,
There is a way to do so but is not documented. You can enable the allowsBackgroundLocationUpdates property by adding the location key to the UIBackGrounds collection in your ios/Runner/Info.plist file. The easiest way to do this is by opening your project in Xcode (make sure you open the ios folder in your project) and add the Background Modes capability to your XCode project (Project > Signing and Capabilities > "+ Capability" button) and select "Location Updates".
The current implementation looks like this ([GeolocationHandler.m#L117-123(https://github.com/Baseflow/flutter-geolocator/blob/291ebf052ac562756fae67242d1db45114031a1c/geolocator_apple/apple/Classes/Handlers/GeolocationHandler.m#L117)]:
+ (BOOL) shouldEnableBackgroundLocationUpdates {
    if (@available(iOS 9.0, *)) {
        return [[NSBundle.mainBundle objectForInfoDictionaryKey:@"UIBackgroundModes"] containsObject: @"location"];
    } else {
        return NO;
    }
}

and is called on line 71when you start listing to the stream returned from getPositionStream():
#if TARGET_OS_IOS
  if (@available(iOS 9.0, macOS 11.0, *)) {
      locationManager.allowsBackgroundLocationUpdates = [GeolocationHandler shouldEnableBackgroundLocationUpdates];
  }
#endif

I hope this answers your question, I will close this issue for now. Feel free to leave a comment if you have additional questions.

Perfect. Thanks!

On 28 Jan 2022, at 18:48, Maurits van Beusekom @.***> wrote:

Hi @Wackymax,
There is a way to do so but is not documented. You can enable the allowsBackgroundLocationUpdates property by adding the location key to the UIBackGrounds collection in your ios/Runner/Info.plist file. The easiest way to do this is by opening your project in Xcode (make sure you open the ios folder in your project) and add the Background Modes capability to your XCode project (Project > Signing and Capabilities > "+ Capability" button) and select "Location Updates".
The current implementation looks like this ([GeolocationHandler.m#L117-123(https://github.com/Baseflow/flutter-geolocator/blob/291ebf052ac562756fae67242d1db45114031a1c/geolocator_apple/apple/Classes/Handlers/GeolocationHandler.m#L117)]:

(BOOL) shouldEnableBackgroundLocationUpdates {
if @.***(iOS 9.0, *)) {
return [[NSBundle.mainBundle objectForInfoDictionaryKey:@"UIBackgroundModes"] containsObject: @"location"];
} else {
return NO;
}
}
and is called on line 71 when you start listing to the stream returned from getPositionStream():

#if TARGET_OS_IOS
if @.***(iOS 9.0, macOS 11.0, *)) {
locationManager.allowsBackgroundLocationUpdates = [GeolocationHandler shouldEnableBackgroundLocationUpdates];
}
#endif
I hope this answers your question, I will close this issue for now. Feel free to leave a comment if you have additional questions.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.


VideoRecorder?

Quick question, How would you go about implementing a videorecorder so that after some number of episodes passes, you can record to view it? I can do it in a normal environment, but I think MPI is throwing things off, I'm not mistaken.

@hlsafin I did this: https://github.com/vwxyzjn/cleanrl/blob/53a3d0ffab83f7b0698479d79cdc0aee94f1f83d/cleanrl/ppo_procgen_fast.py#L90-L105, which results in https://wandb.ai/cleanrl/cleanrl.benchmark/runs/1b9dgx04/overview?workspace=user-costa-huang


No Attribution

Greetings
This project looks like it's a near-identical clone of https://github.com/gilt/postcss-less, which is in of itself a fork of https://github.com/postcss/postcss-scss. You've removed the LICENSE and don't have any attribution mentioned anywhere. Kindly suggesting you add attribution for one of the projects that this is based from.

No problem! I will add an additional info about these projects and that the current one is based on them.

:+1:  cheers

Done :)
https://github.com/webschik/postcss-less/blob/master/README.md#appreciation


License?

Hi,
What is the license?
Hugh

(eg MIT is fairly standard, github has some functions to make adding a license fairly straightforward, though I confess to not having tested them: https://help.github.com/articles/adding-a-license-to-a-repository/ )

MIT license is added. Thanks for the info.

Awesome, thanks! :)


github issues templates

When I was creating an issue I've noticed lack of issue template.
My solution bellow. :D

Thanks, I modified it a bit but it's merged in https://github.com/art049/odmantic/commit/7441cd5b44b0320f6198227b6594d1ccc0a6c286 :smile:


⚠ Bofrost.de has degraded performance

In c02b176, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1313 ms

Resolved: Bofrost.de performance has improved in 5939e47 after 7 minutes.


Prepare for hydration of typed properties as supported by PHP 7.4

As of PHP 7.4, typed properties are supported. In case typed properties are used for "mapped" classes  used during resource hydration as discussed in https://github.com/woohoolabs/yang/issues/20, the property types of the used class should be respected.
For example:

a property of type float can not be assigned a returned string value of 1.0

By detecting the type of the property, the value can be determined as (float) $value

a property of type DateTimeImmutable can not be assigned a returned string value of '2020-01-01T10:59:59.711148+02:00

By detecting the type, the value can be determined as new DateTimeImmutable($value)

Therefore, next to the DocumentHydratorInterface, a DocumentPropertyHydrator or DocumentAttributeHydrator interface would be nice to have to use prepare for this functionality to be used here. Note this requires PHP 7.4or higher.
Already have a working approach, just created this issue to get it out of my head and be able to discuss it before spending time on a PR and tests 😉
@kocsismate What do you think?

Hi @holtkamp ,
Interesting idea! However, it seems to be a bit fragile for me :( What happens with interfaces? For example when the property is a DateTimeInterface? Or when the instantiation of the object is not trivial, e.g. when it contains more constructor parameters? We can't even be sure that the constructor is available because it might not be public.
That's why I prefer hydrating Data Transfer Objects - which are simple data bags. I usually map them to Value Objects if some kind of validation is needed, or directly use them for presentation.
If your preferred workflow is different then the best thing in my opinion to do is override the ClassDocumentHydrator::hydrateResourceAttributes() method - but I think this is what you did anyway. :) It might make sense to create a custom hydrator for each resource if the mapping is not trivial.
To be honest I was always sceptical about general solutions for mapping/hydration which are too advanced because they tend to be fragile (in the sense that people will always keep finding features that it doesn't have yet), and I think it's much easier and less complex to do the mapping/hydration manually - for the price of some repetitive work.

Nice observations!

If your preferred workflow is different then the best thing in my opinion to do is override the ClassDocumentHydrator::hydrateResourceAttributes() method - but I think this is what you did anyway. :)

My "only suggestion" was actually this:

Therefore, next to the DocumentHydratorInterface, a DocumentPropertyHydrator or DocumentAttributeHydrator interface would be nice to have

The example with typed properties I gave was an illustration of "why" this would/could be useful.
So "by default" nothing will change, but one can choose to implement a custom DocumentHydrator, which uses a custom DocumentPropertyHydrator/DocumentAttributeHydrator
Code would probably explain it, I can try to come up with a PR and then we can discuss the added value there 😄

OK! I'm looking forward for the PR :)

@kocsismate as you can see the change is small, but opens up the possibility for somebody to write his own AttributeHydrator without the need to use inheritance to specialize  ClassDocumentHydrator::hydrateResourceAttributes()

Yep, I like it :) Thanks!

Thanks for merging, does this justify a new minor release? Then this issue can be closed.

Sure! I'll release it this week :)

@holtkamp Relese is done :) https://github.com/woohoolabs/yang/releases/tag/2.3.0