Docs: OlsDatasetExtractor: CSV not generated

Description
I'm trying to learn about OXO and I have set up a local instance using docker. I'm following the docs, and I want to create datasets.csv and follow the rest of the documentation walkthrough. But either (a) the file is not being generated, or (b) I can't find it.
This is the command that I'm running:
docker run --net=host -v $(pwd)/config.ini:/mnt/config.ini -v $(pwd)/idorg.xml:/mnt/idorg.xml \
    -v oxo-neo4j-import:/mnt/neo4j -it ebispot/oxo-loader:stable \
        python /opt/oxo-loader/OlsDatasetExtractor.py \
            -c /mnt/config.ini -i /mnt/idorg.xml -d /mnt/neo4j/datasources.csv

Expected behavior
After running command, a CSV file should be created within the docker container oxo_oxo-web-1 at the path /mnt/neo4j/datasources.csv.
Actual behavior
After running the command, no such file is found at /mnt/neo4j/datasources.csv is not found in that container. The /mnt directory exists, but /mnt/neo4j/ directory does not exist.
Additional information
I simply followed the documentation (https://github.com/EBISPOT/OXO) prior to running this command. I had done the following:
git clone https://github.com/EBISPOT/OXO.git
cd OXO

docker volume create --name=oxo-neo4j-data
docker volume create --name=oxo-neo4j-import
docker volume create --name=oxo-mongo-data
docker volume create --name=oxo-solr-data
docker volume create --name=oxo-hsqldb

docker-compose up -d   # docs left out the '-d' part, but I added it

cd oxo-loader

# from here, I continued w/ the documentation at: https://github.com/EBISPOT/OXO/tree/main/oxo-loader
# then I ran the command mentioned above in "Description"

Neo4j and the other containers are up and running and appear to be healthy.

My config.ini (I didn't create this; it was already there)
[Basics]
oxoUrl=http://host.docker.internal:8080
oxoAPIkey=key
olsSolrBaseUrl=http://host.docker.internal:8993/solr
solrChunks=5000
neoURL=bolt://host.docker.internal:7687
neoUser=neo4j
neoPass=dba
olsurl=http://www.ebi.ac.uk/ols/api
oboDbxrefUrl=https://raw.githubusercontent.com/geneontology/go-site/master/metadata/db-xrefs.yaml

[Paths]
exportFileDatasources=datasources.csv
exportFileTerms=/path/terms.csv
exportFileMappings=/path/mappings.csv
idorgDataLocation = /path/idorg.xml

[SQLumls]
user=username
password=password
host=mysql-name
db=dbName
port=4570

[LOINC]
Part=/path/Part.csv
PartRelatedCodeMapping=/path/PartRelatedCodeMapping.csv

Command output
pwd
/Users/joeflack4/projects/OXO/oxo-loader
docker run --net=host -v $(pwd)/config.ini:/mnt/config.ini -v $(pwd)/idorg.xml:/mnt/idorg.xml \
    -v oxo-neo4j-import:/mnt/neo4j -it ebispot/oxo-loader:stable \
        python /opt/oxo-loader/OlsDatasetExtractor.py \
            -c /mnt/config.ini -i /mnt/idorg.xml -d /mnt/neo4j/datasources.csv

Ignoring chebi from idorg as it is already registered as a datasource
Ignoring go from idorg as it is already registered as a datasource
Ignoring geo from idorg as it is already registered as a datasource
Ignoring eco from idorg as it is already registered as a datasource
Ignoring pride from idorg as it is already registered as a datasource
Ignoring fma from idorg as it is already registered as a datasource
Ignoring so from idorg as it is already registered as a datasource
Ignoring biomodels.teddy from idorg as it is already registered as a datasource
Ignoring biomodels.kisao from idorg as it is already registered as a datasource
Ignoring cl from idorg as it is already registered as a datasource
Ignoring bto from idorg as it is already registered as a datasource
Ignoring pato from idorg as it is already registered as a datasource
Ignoring ro from idorg as it is already registered as a datasource
Ignoring obi from idorg as it is already registered as a datasource
Ignoring ncit from idorg as it is already registered as a datasource
Ignoring pr from idorg as it is already registered as a datasource
Ignoring edam from idorg as it is already registered as a datasource
Ignoring orphanet from idorg as it is already registered as a datasource
Ignoring doid from idorg as it is already registered as a datasource
Ignoring cco from idorg as it is already registered as a datasource
Ignoring pw from idorg as it is already registered as a datasource
Ignoring po from idorg as it is already registered as a datasource
Ignoring efo from idorg as it is already registered as a datasource
Ignoring vario from idorg as it is already registered as a datasource
Ignoring ma from idorg as it is already registered as a datasource
Ignoring uberon from idorg as it is already registered as a datasource
Ignoring unimod from idorg as it is already registered as a datasource
Ignoring mamo from idorg as it is already registered as a datasource
Ignoring hpo from idorg as it is already registered as a datasource
Ignoring probonto from idorg as it is already registered as a datasource
/opt/oxo-loader/OlsDatasetExtractor.py:143: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  yamlData = yaml.load(urllib.request.urlopen(oboDbxrefUrl))
New datasource AgBase from GO db-xrefs file
New datasource AGI_LocusCode from GO db-xrefs file
New datasource AGRICOLA_ID from GO db-xrefs file
New datasource AGRICOLA_IND from GO db-xrefs file
New datasource Alzheimers_University_of_Toronto from GO db-xrefs file
New datasource ApiDB_PlasmoDB from GO db-xrefs file
New datasource APweb from GO db-xrefs file
New datasource ARUK-UCL from GO db-xrefs file
Ignoring ASAP from OBO as it is already registered as a datasource
New datasource AspGD from GO db-xrefs file
New datasource AspGD_LOCUS from GO db-xrefs file
New datasource AspGD_REF from GO db-xrefs file
Ignoring BFO from OBO as it is already registered as a datasource
New datasource BHF-UCL from GO db-xrefs file
Ignoring BioCyc from OBO as it is already registered as a datasource
New datasource BIOMD from GO db-xrefs file
New datasource bioRxiv from GO db-xrefs file
Ignoring BRENDA from OBO as it is already registered as a datasource
Ignoring BTO from OBO as it is already registered as a datasource
New datasource CACAO from GO db-xrefs file
New datasource CAFA from GO db-xrefs file
Ignoring CARO from OBO as it is already registered as a datasource
Ignoring CAS from OBO as it is already registered as a datasource
New datasource CASGEN from GO db-xrefs file
New datasource CASREF from GO db-xrefs file
New datasource CASSPC from GO db-xrefs file
Ignoring CAZY from OBO as it is already registered as a datasource
New datasource DTU from GO db-xrefs file
Ignoring CDD from OBO as it is already registered as a datasource
Ignoring CGD from OBO as it is already registered as a datasource
New datasource CGD_LOCUS from GO db-xrefs file
New datasource CGD_REF from GO db-xrefs file
Ignoring CGSC from OBO as it is already registered as a datasource
Ignoring CHEBI from OBO as it is already registered as a datasource
Ignoring CL from OBO as it is already registered as a datasource
New datasource CO_125 from GO db-xrefs file
New datasource COG from GO db-xrefs file
New datasource COG_Cluster from GO db-xrefs file
New datasource COG_Function from GO db-xrefs file
New datasource COG_Pathway from GO db-xrefs file
New datasource CollecTF from GO db-xrefs file
New datasource ComplexPortal from GO db-xrefs file
Ignoring CORIELL from OBO as it is already registered as a datasource
Ignoring CORUM from OBO as it is already registered as a datasource
New datasource cribi_vitis from GO db-xrefs file
Ignoring dbSNP from OBO as it is already registered as a datasource
Ignoring DDANAT from OBO as it is already registered as a datasource
New datasource DDBJ from GO db-xrefs file
New datasource dictyBase from GO db-xrefs file
New datasource dictyBase_gene_name from GO db-xrefs file
New datasource dictyBase_REF from GO db-xrefs file
Ignoring DOI from OBO as it is already registered as a datasource
New datasource EC from GO db-xrefs file
Ignoring EchoBASE from OBO as it is already registered as a datasource
Ignoring ECO from OBO as it is already registered as a datasource
New datasource EcoCyc from GO db-xrefs file
New datasource EcoCyc_REF from GO db-xrefs file
Ignoring EcoliWiki from OBO as it is already registered as a datasource
Ignoring EMAPA from OBO as it is already registered as a datasource
New datasource EMBL from GO db-xrefs file
Ignoring ENA from OBO as it is already registered as a datasource
Ignoring ENSEMBL from OBO as it is already registered as a datasource
New datasource ENSEMBL_GeneID from GO db-xrefs file
New datasource ENSEMBL_ProteinID from GO db-xrefs file
New datasource ENSEMBL_TranscriptID from GO db-xrefs file
New datasource EnsemblFungi from GO db-xrefs file
New datasource EnsemblMetazoa from GO db-xrefs file
New datasource EnsemblPlants from GO db-xrefs file
New datasource EnsemblProtists from GO db-xrefs file
New datasource ENZYME from GO db-xrefs file
New datasource EO_GIT from GO db-xrefs file
New datasource EuPathDB from GO db-xrefs file
New datasource Eurofung from GO db-xrefs file
New datasource FB from GO db-xrefs file
Ignoring FBbt from OBO as it is already registered as a datasource
Ignoring FMA from OBO as it is already registered as a datasource
Ignoring FYPO from OBO as it is already registered as a datasource
New datasource GenBank from GO db-xrefs file
New datasource Gene3D from GO db-xrefs file
Ignoring GeneDB from OBO as it is already registered as a datasource
New datasource Genesys-pgr from GO db-xrefs file
Ignoring GEO from OBO as it is already registered as a datasource
Ignoring GO from OBO as it is already registered as a datasource
New datasource GO_Central from GO db-xrefs file
New datasource GO_Noctua from GO db-xrefs file
New datasource GO_REF from GO db-xrefs file
New datasource gomodel from GO db-xrefs file
New datasource GOC from GO db-xrefs file
New datasource GOC-OWL from GO db-xrefs file
New datasource GONUTS from GO db-xrefs file
New datasource GOREL from GO db-xrefs file
New datasource GR from GO db-xrefs file
New datasource GR_Ensembl from GO db-xrefs file
New datasource GR_GENE from GO db-xrefs file
New datasource GR_MUT from GO db-xrefs file
New datasource GR_PROTEIN from GO db-xrefs file
New datasource GR_QTL from GO db-xrefs file
New datasource GR_REF from GO db-xrefs file
New datasource GRIN from GO db-xrefs file
New datasource GRINDesc from GO db-xrefs file
New datasource H-invDB from GO db-xrefs file
New datasource H-invDB_cDNA from GO db-xrefs file
New datasource H-invDB_locus from GO db-xrefs file
Ignoring HAMAP from OBO as it is already registered as a datasource
Ignoring HGNC from OBO as it is already registered as a datasource
Ignoring HPA from OBO as it is already registered as a datasource
New datasource HPA_antibody from GO db-xrefs file
New datasource HUGO from GO db-xrefs file
Ignoring IAO from OBO as it is already registered as a datasource
New datasource IMG from GO db-xrefs file
New datasource IMGT_HLA from GO db-xrefs file
New datasource IMGT_LIGM from GO db-xrefs file
Ignoring IntAct from OBO as it is already registered as a datasource
Ignoring InterPro from OBO as it is already registered as a datasource
New datasource iPTMnet from GO db-xrefs file
New datasource IRIC from GO db-xrefs file
New datasource IRGC from GO db-xrefs file
Ignoring ISBN from OBO as it is already registered as a datasource
Ignoring ISSN from OBO as it is already registered as a datasource
New datasource IUPHAR/BPS from GO db-xrefs file
New datasource IUPHAR_GPCR from GO db-xrefs file
New datasource IUPHAR_RECEPTOR from GO db-xrefs file
New datasource Jaiswal_Lab from GO db-xrefs file
Ignoring TIGRFAMS from OBO as it is already registered as a datasource
Ignoring JSTOR from OBO as it is already registered as a datasource
New datasource KEGG from GO db-xrefs file
New datasource KEGG_ENZYME from GO db-xrefs file
New datasource KEGG_LIGAND from GO db-xrefs file
New datasource KEGG_PATHWAY from GO db-xrefs file
New datasource KEGG_REACTION from GO db-xrefs file
New datasource LIFEdb from GO db-xrefs file
Ignoring MA from OBO as it is already registered as a datasource
New datasource MACSC_REF from GO db-xrefs file
New datasource MaizeGDB from GO db-xrefs file
New datasource MaizeGDB_Locus from GO db-xrefs file
New datasource MaizeGDB_QTL from GO db-xrefs file
New datasource MaizeGDB_REF from GO db-xrefs file
New datasource MaizeGDB_stock from GO db-xrefs file
New datasource MEDLINE from GO db-xrefs file
Ignoring MEROPS from OBO as it is already registered as a datasource
New datasource MEROPS_fam from GO db-xrefs file
Ignoring MeSH from OBO as it is already registered as a datasource
New datasource MetaCyc from GO db-xrefs file
New datasource MGCSC_GENETIC_STOCKS from GO db-xrefs file
Ignoring MGD from OBO as it is already registered as a datasource
New datasource MGI from GO db-xrefs file
New datasource MIPS_funcat from GO db-xrefs file
New datasource MITRE from GO db-xrefs file
New datasource ModBase from GO db-xrefs file
New datasource NASC_code from GO db-xrefs file
New datasource NC-IUBMB from GO db-xrefs file
New datasource NCBI from GO db-xrefs file
Ignoring NCBIGene from OBO as it is already registered as a datasource
New datasource NCBI_gi from GO db-xrefs file
New datasource NCBI_GP from GO db-xrefs file
New datasource NCBI_locus_tag from GO db-xrefs file
New datasource NCBI_NP from GO db-xrefs file
New datasource NIF_Subcellular from GO db-xrefs file
New datasource NTNU_SB from GO db-xrefs file
Ignoring OBI from OBO as it is already registered as a datasource
New datasource OBO_SF_PO from GO db-xrefs file
New datasource OBO_SF2_PO from GO db-xrefs file
New datasource OBO_SF2_PECO from GO db-xrefs file
Ignoring OMIM from OBO as it is already registered as a datasource
New datasource OMSSA from GO db-xrefs file
New datasource PANTHER from GO db-xrefs file
New datasource ParkinsonsUK-UCL from GO db-xrefs file
Ignoring PATO from OBO as it is already registered as a datasource
New datasource PATRIC from GO db-xrefs file
Ignoring PDB from OBO as it is already registered as a datasource
New datasource PECO_GIT from GO db-xrefs file
Ignoring Pfam from OBO as it is already registered as a datasource
New datasource PharmGKB from GO db-xrefs file
New datasource PhenoScape from GO db-xrefs file
New datasource PIR from GO db-xrefs file
Ignoring PIRSF from OBO as it is already registered as a datasource
New datasource PlantSystematics_image_archive from GO db-xrefs file
New datasource PMCID from GO db-xrefs file
New datasource PMID from GO db-xrefs file
Ignoring PO from OBO as it is already registered as a datasource
New datasource PO_GIT from GO db-xrefs file
New datasource PO_REF from GO db-xrefs file
New datasource POC from GO db-xrefs file
Ignoring PomBase from OBO as it is already registered as a datasource
New datasource Pompep from GO db-xrefs file
New datasource PPI from GO db-xrefs file
Ignoring PR from OBO as it is already registered as a datasource
Ignoring PRINTS from OBO as it is already registered as a datasource
Ignoring Prosite from OBO as it is already registered as a datasource
New datasource protein_id from GO db-xrefs file
New datasource PseudoCAP from GO db-xrefs file
New datasource PSO_GIT from GO db-xrefs file
New datasource PSI-MI from GO db-xrefs file
New datasource PSI-MOD from GO db-xrefs file
New datasource PSORT from GO db-xrefs file
New datasource PubChem_BioAssay from GO db-xrefs file
New datasource PubChem_Compound from GO db-xrefs file
New datasource PubChem_Substance from GO db-xrefs file
New datasource RAP-DB from GO db-xrefs file
Ignoring Reactome from OBO as it is already registered as a datasource
Ignoring REBASE from OBO as it is already registered as a datasource
New datasource RefGenome from GO db-xrefs file
Ignoring RefSeq from OBO as it is already registered as a datasource
Ignoring RESID from OBO as it is already registered as a datasource
Ignoring Rfam from OBO as it is already registered as a datasource
Ignoring RGD from OBO as it is already registered as a datasource
Ignoring RHEA from OBO as it is already registered as a datasource
New datasource RiceSES from GO db-xrefs file
New datasource RNAcentral from GO db-xrefs file
Ignoring RNAmods from OBO as it is already registered as a datasource
Ignoring RO from OBO as it is already registered as a datasource
New datasource SABIO-RK from GO db-xrefs file
New datasource Sanger from GO db-xrefs file
Ignoring SEED from OBO as it is already registered as a datasource
Ignoring SGD from OBO as it is already registered as a datasource
New datasource SGD_LOCUS from GO db-xrefs file
New datasource SGD_REF from GO db-xrefs file
Ignoring SGN from OBO as it is already registered as a datasource
New datasource SGN_ref from GO db-xrefs file
New datasource SGN_germplasm from GO db-xrefs file
Ignoring SMART from OBO as it is already registered as a datasource
Ignoring SO from OBO as it is already registered as a datasource
New datasource Soy_gene from GO db-xrefs file
New datasource SOY_QTL from GO db-xrefs file
New datasource SOY_ref from GO db-xrefs file
New datasource SUPERFAMILY from GO db-xrefs file
New datasource SynGO from GO db-xrefs file
New datasource SynGO-UCL from GO db-xrefs file
New datasource SYSCILIA_CCNET from GO db-xrefs file
New datasource TAIR from GO db-xrefs file
New datasource taxon from GO db-xrefs file
New datasource TC from GO db-xrefs file
Ignoring TGD from OBO as it is already registered as a datasource
New datasource TGD_LOCUS from GO db-xrefs file
New datasource TGD_REF from GO db-xrefs file
New datasource TO_GIT from GO db-xrefs file
New datasource TRANSFAC from GO db-xrefs file
New datasource TreeGenes from GO db-xrefs file
Ignoring UBERON from OBO as it is already registered as a datasource
New datasource UM-BBD from GO db-xrefs file
New datasource UM-BBD_enzymeID from GO db-xrefs file
New datasource UM-BBD_pathwayID from GO db-xrefs file
New datasource UM-BBD_reactionID from GO db-xrefs file
New datasource UM-BBD_ruleID from GO db-xrefs file
Ignoring UniParc from OBO as it is already registered as a datasource
Ignoring UniPathway from OBO as it is already registered as a datasource
Ignoring UniProt from OBO as it is already registered as a datasource
New datasource UniProtKB from GO db-xrefs file
New datasource UniProtKB-KW from GO db-xrefs file
New datasource UniProtKB-SubCell from GO db-xrefs file
New datasource UniRule from GO db-xrefs file
New datasource VZ from GO db-xrefs file
New datasource WB from GO db-xrefs file
New datasource WB_REF from GO db-xrefs file
Ignoring WBbt from OBO as it is already registered as a datasource
Ignoring WBls from OBO as it is already registered as a datasource
Ignoring WBPhenotype from OBO as it is already registered as a datasource
New datasource Wikipedia from GO db-xrefs file
New datasource WikipediaVersioned from GO db-xrefs file
Ignoring Xenbase from OBO as it is already registered as a datasource
New datasource YeastFunc from GO db-xrefs file
New datasource YuBioLab from GO db-xrefs file
Ignoring ZFIN from OBO as it is already registered as a datasource
New datasource TFClass from GO db-xrefs file
New datasource HGNC-UCL from GO db-xrefs file
New datasource Animal_QTLdb from GO db-xrefs file
New datasource Animal_CorrDB from GO db-xrefs file
New datasource AlphaFold from GO db-xrefs file
Adding paxo as datasource
Adding loinc as datasource

Examining oxo_oxo-web-1 to find CSV
Last login: Tue Sep 28 17:19:52 on ttys009
docker exec -it a270b0b333736e3c99c3bf44f29ec0f59d65a8af2e2d322e4005b64433dd2aa8 /bin/sh
docker exec -it a270b0b333736e3c99c3bf44f29ec0f59d65a8af2e2d322e4005b64433dd2aa8 /bin/sh
ll/ # ls
bin    dev    etc    home   lib    media  mnt    opt    proc   root   run    sbin   srv    sys    tmp    usr    var
/ # pwd
/
/ # cd mnt
/mnt # ls
hsqldb             hsqldb.lck         hsqldb.log         hsqldb.properties  hsqldb.script      hsqldb.tmp
/ # ls /mnt/neo4j
ls: /mnt/neo4j: No such file or directory

@joeflack4 Thank you for logging the issue in such detail. We will look into it as soon as we can.

We should probably unify custom deployments in https://github.com/EBISPOT/ontotools-docker
These kinds of issues are mostly problems with mount points etc.. @joeflack4 did you try using the docker compose setup?

@matentzn https://github.com/EBISPOT/ontotools-docker addresses the complete Ontology Tools stack. However, not everyone wants to install the complete stack.

I agree, I was more thinking of moving the docs there, and using docker compose even for the individual services; it would just be less support work in the future, bypassing typical mistakes in Following readme docs.

Hey guys. Thanks for looking into this!
@matentzn Yep, I was just following the documentation. It asks to do docker-compose up, so yep, I called that from the root directory.

It seems the paths are wrong in the supplied config.ini.
[Paths]
exportFileDatasources=datasources.csv
exportFileTerms=/path/terms.csv
exportFileMappings=/path/mappings.csv

should be
[Paths]
exportFileDatasources=/mnt/neo4j/datasources.csv
exportFileTerms=/mnt/neo4j/terms.csv
exportFileMappings=/mnt/neo4j/mappings.csv

I will get this updated. As @matentzn says we should probably in the long term unify all of these separate Docker instructions into the ontotools-docker repository, which is more up to date but currently only deploys the whole stack.

Makes sense that that is the issue! For now, Nico has instructed me to use the full ontotools stack for my purposes, as it should serve my purposes just fine. But thanks for looking into this.


Adds information about Fast searching

This addresses #6. Not sure this is an exhaustive list, but "Enable fast searching" at least seems to be a required setting for the module to work

I think this is a red herring, I just disabled fast searching and it still works...

I had to restart my computer after changing the setting for the issue to popup. Then I could reproduce it. Does that happen on your machine too?

Sorry for the delay. Can't seem to reproduce. Will see if I can find out what is going on, but closing this since it isn't the solution.


finetuned using lamma-13B

Hello, if I want to use llama-13B's pth for fine-tuning, what changes need to be made to the train.sh script? After fine-tuning according to the parameters of llama-7B, the accuracy is very low.

In our experiments, you may change --adapter_layer from 32 to 40, and also decrease the learning rate.

In our experiments, I changed --adapter_layer from 32 to 40, and you may also decrease the learning rate.

thank you!

In our experiments, I changed --adapter_layer from 32 to 40, and you may also decrease the learning rate.

Hello, after I adjusted --adapter_layer  to 40, I changed the learning rate to 9e-3, but your result in the double line can only reach 65%.I don't know what I did wrong


OLC inconsistent reference to Earth equatorial circumference

The document/specification/notes refer to the Earth as having a circumference of 111321 meters per degree of latitude.

NB: This table assumes one degree is 111321 meters, and that all distances are calculated at the equator.
https://github.com/google/open-location-code/blob/d47d9f9b95e9f306628396e1b30aaf275f83a5d4/docs/specification.md#code-precision

However, elsewhere it is specified that plus codes are predicted over the WSG 84 standard.
The WSG 84 geoid sets the semi major axis at 6 378 137.0 m. (Sorry, can't find actual reference for this // https://en.wikipedia.org/wiki/World_Geodetic_System)
That means one degree is 6378137.0 * 2 * π / 360 ≈ 111319.49.

Of no consequence. But still, all standards should be written consistently and in the voice of an expert who cares more about all the things you are implementing than you do.

Nothing in that statement claims that it refers to WGS84 - and if it did, I would question the correctness of using the exact semi-major axis value but not the semi-minor axis value for a calculation that tries to roughly approximate lengths not only along the equator but also perpendicular to it.
Considering that

these values don't differ in the first four digits, and would have the same fifth digit after rounding,
the approximated lengths given in the table are rounded to four or less significant digits in all cases but one anyway,
there's a much bigger error than any of that as soon as you step away from the equator a bit,
there actually is an NB stating that this is just an approximation based on some assumption,

I'd say that, by all means, let's split the difference and call it 111320m, or 111257m if we use the average between semi-major and semi-minor, or 111194m if we base our calculation on what Wikipedia claims is the "mean radius" of Earth... or let's stop pretending that any of these values is really "better" than the others and that not using it is a sign of abundant sloppiness.

in the voice of an expert who cares more about all the things you are implementing than you do

Just BTW, this is borderline insulting and IMO uncalled for.

Regarding tone.
Very insulting! And ambiguous!!!

in the voice of an expert who cares more about all the things you are implementing than you do

This is meant to mean the person who writes the standard (us, you and me, everybody here) should care more than anybody reading the document (implementors, the public, baseline humans) about any detail written down.
Sorry for that confusion.
(The insulting, unintended alternate meaning reads as a personal attack against a "you" some person here.)

WGS84 is referred in:

https://github.com/google/open-location-code/blob/d47d9f9b95e9f306628396e1b30aaf275f83a5d4/FAQ.txt
https://github.com/google/open-location-code/blob/d47d9f9b95e9f306628396e1b30aaf275f83a5d4/docs/specification.md
https://github.com/google/open-location-code/blob/d47d9f9b95e9f306628396e1b30aaf275f83a5d4/docs/olc_definition.adoc

In my draft (PR coming), I am using the wording like "< XXX meters" so that the statement has a more concrete meaning. I will also check the correct equatorial distance.

This issue is fixed (actually, obviated) at https://github.com/google/open-location-code/pull/463


Atom input phone number fix

Checklist:

[ ] Test added / Snapshots updated
[ ] Documentation added / updated

@kialysa let's work on this 🙈

@kialysa yay! Do you think we are good now?


Update golangci-lint and config

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updating golangci lint to the latest release and fix reports.
Which issue(s) this PR fixes:

None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

None

/retest


Prevent a deprecation warning in php >= 8.2

This prevents a PHP deprecation notice "Creation of dynamic property Howtomakeaturn\PDFInfo\PDFInfo::$pageRot is deprecated"

Thank you very much.


changed Resolve Asset Source 'require' to use actual path to resource

it was only require('resolveAssetSource'), which was causing errors in some cases

Thanks! Can you create an issue or provide a description of a case that causes this bug? I just want to understand (and document) what this PR is fixing.

Basically, require('resolveAssetSource') was kind of a magic import. And in some cases, there was an error message displayed that stated that 'resolveAssetSource' could not be found. Making the import more explicit however, reduced the errors down to zero.

Here is an explicit example:

when I simply use require('resolveAssetSource'), the app does not recognize where or what that is, even after running npm install:

after making the import more explicit, with a direct reference to the file (require('react-native/Libraries/Image/resolveAssetSource'), then the webview worked flawlessly every time.

Cool. This magical require style is standard for React Native's "haste" build system, but I think this is a good move.


Test Kokkos CMake overhaul

This is to test https://github.com/kokkos/kokkos/pull/2104.

I think we should test the overhaul against not carrying our own FindKokkos.cmake.

Superseded by #73.


DEFAULT_VERSIONS=gcc=8 still builds with gfortran7

Might be nothing to do with synth, just my confusion with FreeBSD ports builds.
# grep DEFAULT_VERSIONS /usr/local/etc/synth/LiveSystem-make.conf
DEFAULT_VERSIONS=gcc=8

synth build net/mpich

results in using gfortran7:
--------------------------------------------------
--  CONFIGURE_ENV
--------------------------------------------------
PKG_CONFIG=pkgconf
F77="gfortran7"
FC="gfortran7"

What else do I need to force using of gfortran8 in synth builds?
Thanks
Anton

as far as I can tell from the ports tree code, setting gcc=8 on DEFAULT_VERSIONS should do it. That should set GCC_DEFAULT to 8 which is what https://svnweb.freebsd.org/ports/head/Mk/Uses/fortran.mk?revision=454428&view=markup uses.
Does the log should DEFAULTS_VERSIONS=gcc=8 is part of the make.conf ?

Here's the full build log:
https://seis.bristol.ac.uk/~mexas/net___mpich.log
Re make.conf:
# cat /etc/make.conf
#DEVELOPER=yes
#FFLAGS+= -O2 -pipe -march=bdver2 -mtune=bdver2
#FFLAGS+= -funroll-loops --param max-unroll-times=4 -ftree-vectorize
#FFLAGS+= -g
#DEFAULT_VERSIONS=gcc=8

I moved all /etc/make.conf stuff explicitly into synth make.conf,
although I understand from the manual, that /etc/make.conf is
always appended to synth make.conf.
# cat /usr/local/etc/synth/LiveSystem-make.conf
DEVELOPER=yes
FFLAGS+= -O2 -pipe -march=bdver2 -mtune=bdver2
FFLAGS+= -funroll-loops --param max-unroll-times=4 -ftree-vectorize
FFLAGS+= -g
DEFAULT_VERSIONS=gcc=8

that's not what I asked.
Look at the build log, and ensure DEFAULT_VERSIONS=gcc=8 is on it.
in other words, if your profile is not LiveSystem then it's not getting in the jails make.conf.

but i see now you posted a link to log and it is indeed there

do you have an unaltered ports tree?
Because according to the code, what you've done should be working.  It's acting like DEFAULT_VERSIONS is getting undefined or something.

(and for the record, it's probably not a synth issue.  the definitions are getting to the jail's make.conf)

I'm an idiot, I had net/mpich/Makefile.local with DEFAULT_VERSIONS.
Sorry for wasting your time.


[Lecture14][1215] result of edge detection

Why is the result of edge detection on the shoe part of a WQHD LED image clearer than that of real images?
What causes this difference?

Using a WQHD LED display increases high-frequency components, such as noise, which makes edge detection algorithms more sensitive to these components, resulting in clearer and more pronounced edges.

@chan991112 @jungseongryong
Thank you for the question and answer:)
To add, this scenario involves capturing the screen displays. In such cases, high-frequency patterns (commonly referred to as Moiré patterns) often appear, which serve as a key indicator for detecting spoofing attacks.


stop spying on us.

what the title says.

Meh. I say thanks for the code.

hey, the code is nice... its just I have principles.

:D +1

:thumbsup:

This is not a place for political disputes.  Please evaporate this issue with one hydrogen bomb. ;-)

@bitdivine you've been outvoted. as per a democracy...

:+1:
@bitdivine :eggplant:

@gaffer01 racist!


✨ Manifest import - assume UTC when no timezone provided

Is there an existing issue for this?

[X] I have searched the existing issues

Suggestion
When we receive a manifest without a timezone specified, support it as UTC
example: "start_date: "2023-01-02T12:00:00"
Possible Implementation
No response
Anything else?
No response

Reason not to work this: Timezone is required in ISO 8601 datetime


OnlyOffice can write changes through an "upload" public link share

Describe the bug
OnlyOffice can write documents from a public link share with "Can upload" role.
Steps to reproduce

As "admin", create asdf/test.docx via OnlyOffice
As "admin", create a public link to the folder asdf with Can upload role (which states permissions view, download and upload)
As anonymous, receive and follow the public link
As anonymous, open asdf/test.docx via OnlyOffice
As anonymous, write some content into the file and leave the document again
As "admin", see that the changes have been written to disk (e.g. by downloading the file after the lock has been released)

Expected behavior
"anonymous" should have a read only view or at least an error message when trying to save.
Actual behavior
"anonymous" can edit and save the document.

confirmed in both v5.0.0-rc.5 and v4.0.6

Step 2. Is admin create a public link to this file with the Can upload  role using API or UI ?
The Can upload  role has to be used for folders, bu for files.

To clarify, the "upload" permission should allow "anonymous" to create new files in the folder, but not overwrite (=edit) existing files.
After "anonymous" has uploaded a file, they should not be able to change what they uploaded (can't edit it or delete it), but should be able to list the files and download files.
Correct?

What API is OnlyOffice using for that? I'm surprised the API tests did not catch it

Wopi

To clarify, the "upload" permission should allow "anonymous" to create new files in the folder, but not overwrite (=edit) existing files.
After "anonymous" has uploaded a file, they should not be able to change what they uploaded (can't edit it or delete it), but should be able to list the files and download files.
Correct?

Correct, thank you!

We have e2e coverage for an app provider. It is not very large, because we wanted to implement only primitive tests as a first step (create and open a docx or odt document).
Maybe we should increase the coverage with e2e?

Yes I think we should. I believe the decision to make only small coverage was because the security related code path should be the same as with webDAV, but that does not look like its true

@kulmann I found the place in a code when we give the write permissions to OnlyOffice but it is not a root issue. Because the permissions statements (view, download and upload) do not contradict that.
If a user can upload then the user can change the file, right?

@micbar @kulmann  Is the upload permission redundant in this case?

If a user can upload then the user can change the file, right?

No... @phil-davis interpretation is what we want: The user can upload files, but not overwrite existing files.

We should clarify the public permission definitions.
FYI @tbsbdr @micbar

How does the WebDAV API currently react in that case?

Currently I see 3 options

fix the bug
Add "edit" to the role description
remove the whole role "Uploader"

I'd favour the 3rd option for now, as Uploader and Editor would then be almost the same. what do you think @kulmann @micbar ?

Option 3 would be fine by me. UX-wise the differentiation is hard to understand anyway. So might actually be an improvement...

yes. Option 3 is the best.

ok, so lets remove this role from the link 😬

Is the "can upload"  should be changed to "can edit" or "can view"?

Yes. We need a better description which matches our behavior

@tbsbdr @kulmann
Let us fix the description.

@tbsbdr propose a text

🙈 adding "edit" to the description won't work, as text or md files can not be edited.
@micbar @kulmann I currently see 2 options and would choose the one with least effort. do you agree?

fix the bug
~Add "edit" to the role description~
remove the whole role "Uploader"

I could Not Edit txt, can you?

you can upload a new txt file version.

The main problem here is the "edit" vs. "upload" semantics. From the ocis backend perspective, both are uploads and require the upload permission. This is different for directories. They are controlled by the create-directories permission.

Note: "edit-save" and "upload-overwrite" really mean the same thing. There is no such thing as "editing" a file that is sitting on a server. Actually, there is also no such thing as "editing" a file on the local filesystem on my laptop. "editing" is a thing that is done in-memory with a user-interface (graphical (LibreOffice...) or textual (VI, nano, a line-based command-line editor...)
When the person doing the "editing" asks to "save", then the editor software does an "upload-overwrite" to the file, wherever the persistent storage is. It might rewrite the whole file, it might append to the end (if the change just adds to the file), it might overwrite just some bytes of the file (if it implements some optimized way of saving just the bits that changed).

From a linux file system perspective, which is similar to webdav:
"upload" rights should mean  "write permissions to directory, but not the files".
Uploading a file should check if the file exists and the user has write permissions to that file.
mkdir test
echo "bar" > test/foo # works, because of write permissions to test
chmod -w > test/foo
echo "foo" > test/foo # fails, permission denied

@tbsbdr adjust wording for the role

Suggestion for the rewording of the roles description.

Assuming that "Only for invited ppl" will be removed
Adds edit to Can upload
Adds delete to Can edit
I'd prefer to be less verbose in the role description (option 2)
Note: In general I'd prefer to remove the Uploader role at all, as it adds little value for the user, but if I understand @micbar correctly this would be expensive due to a migration necessity.

@kulmann is option 2 - less verbose, fine for you?

1) Verbose
2) Less verbose

General overview

Needs authentication
delete
upload/edit
view
download
upload (existing content not   revealed)

Invited People
✅
(✅)
(✅)
(✅)
(✅)
❌

Can edit
❌
✅
✅
✅
✅
❌

Can upload
❌
❌
✅
✅
✅
❌

Can view
❌
❌
❌
✅
✅
❌

Secret File Drop
❌
❌
❌
❌
❌
✅

@kulmann whats your opinion - go or no? 👆

We had that in the past and changed it to being more verbose because people had difficulties understanding the implications. Now that the whole context is more verbose we may as well go back to less verbose within the dropdown. Fine by me.

@kulmann So I guess this would be a web ticket now? On the server side we don't have any descriptive texts for the public link types AFAICS.


JOSS review: missing dependencies for unit tests

I installed all dependencies via pip install -e .[ci] and run python -m pytest -n auto tests/. There are multiple errors, like:
E       pxr.Tf.ErrorException:
E               Error in 'pxrInternal_v0_24_11__pxrReserved__::UsdStage::Open' at line 1052 in file /opt/USD/pxr/usd/usd/stage.cpp : 'Failed to open layer @/home/afabisch/Projekte/scene_synthesizer/tests/data/assets/srl_kitchen/scene_overlay.usd@'

...

E               ValueError: /home/afabisch/Projekte/scene_synthesizer/tests/data/assets/partnet_mobility_v0/7236/mobility.urdf is not a file

...

E               ValueError: /home/afabisch/Projekte/scene_synthesizer/tests/data/assets/robots/franka_description/franka_panda.urdf is not a file

...

E               ValueError: /home/afabisch/Projekte/scene_synthesizer/tests/data/assets/partnet_mobility_v0/7236/mobility.urdf is not a file

...

E                   ValueError: string is not a file: /home/afabisch/Projekte/scene_synthesizer/tests/data/assets/shapenetsem/Mug/10f6e09036350e92b3f21f1137c3c347.obj

https://github.com/openjournals/joss-reviews/issues/7561#issuecomment-2515256983

Yeah, these assets are not shareable. I assume the preferred way is to remove all the tests?

Not shareable as in not public or as in you don't want to add it to the repository? Running a download script before the tests shouldn't be an issue.
Removing all the tests does not make sense. Could you split it into tests with and without internal dependencies and skip the ones with internal dependencies if not available? Could you maybe also replace some of the non-public assets with freely available assets? Which assets do you use in the examples?

They are not public and the ones in the examples are procedural ones from the library. With the latest update (https://github.com/NVlabs/scene_synthesizer/commit/51b1c47b31ad13194bb45c68d269a808e3274117) I'm skipping the tests that depend on the internal files.

Now I get the following errors:
FAILED tests/example_test.py::test_vertical_wall_oven_microwave_cabinet - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/exports_test.py::test_export_primitives_gltf - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_layers - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_collision_manager_with_scene - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_support_as_layer - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_adding_object_transform - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_randomization - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/urdf_export_test.py::test_primitives_urdf_export - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/urdf_export_test.py::test_primitives_urdf_export_single_link - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/urdf_export_test.py::test_primitives_urdf_export_single_link_with_separate_assets - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_part_as_layer - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/urdf_export_test.py::test_primitives_2_urdf_export - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/urdf_export_test.py::test_primitives_2_urdf_export_single_link - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
FAILED tests/scene_test.py::test_container_as_layer - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/usd_export_test.py
ERROR tests/example_test.py::test_kitchen_collision_bounds - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/exports_test.py::test_export_urdf_kitchen_collision - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/example_test.py::test_kitchen_bounds - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/exports_test.py::test_export_urdf_kitchen_write_meshes - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/exports_test.py::test_export_urdf_kitchen_collision_write_meshes - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...
ERROR tests/exports_test.py::test_export_urdf_kitchen - ImportError: cannot import name 'examples' from 'scene_synthesizer' (/home/...

And another dependency is missing here:
ImportError while importing test module '/home/afabisch/Projekte/scene_synthesizer/tests/usd_export_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../Data/anaconda3/envs/py311/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/usd_export_test.py:15: in <module>
    import meshsets
E   ModuleNotFoundError: No module named 'meshsets'

Uff, sorry, now it's fully fixed.

Great, now it works for me :)
I was also interested in the test coverage. In case you are interested, I changed the pytest configuration a bit in #6
I get 55.2% coverage. Which number do you get with the closed source dependencies?
In any case, I think this issue can be closed.

Great, thank you!  I get 63.0% coverage with those closed source dependencies.


Support Tile Collision Editor

As I understand it the new way to handle collisions in Tiled is to draw objects on the tiles themselves (not as a separate layer) with the Tile Collision Editor. It would be fantastic if this plugin supported that. :)

Yeah I started to support this, but found the collision editor difficult to use (at best) so I kind of just moved on.
I can revisit it though.

I find it to be roughly equivalent effort for one map, but when you're reusing tiles I think the collision editor is very helpful. Especially when the collisions have curves and such.

+1 I'd like to help out with this if I could. Gonna fork the code now and see what I can do (unless progress is already a decent amount along).

Honestly, I don't remember. It has been some time since I worked on this and I do not remember if I implemented support for it or not...but I think not.


Replace tar.gz with gz to comply with client compatibility

Overview
Replacing .tar.gz allowed extension with .gz since the upload form in the client seems to crash with .tar.gz. I didn't see any other usages outside of letting the client know the allowed extensions.
Testing

Deployed locally
Verified response from https://udis-dev.local.apidb.org:8443/projects/ClinEpiDB/datasetTypes/isasimple/fileTypes

This is the chromium bug report, related to this issue. Maybe we can revert this, once it's fixed?
https://bugs.chromium.org/p/chromium/issues/detail?id=1423362

Codepen to reproduce the error: https://codepen.io/dmfalke/pen/MWqXMqR


Add Array#select, Array#reject and some description.

Add Array#select, Array#reject and descriptions,
Add spec for Array#select! and Array#reject!.
Add descriptions for Array#select! and Array#reject!.

Doesn't it already have select? Enumerable#select

Oh! sorry. i mistook it

I like to add some tests for Array#select! and Array#reject! for empty array.
And also description for the methods.

What's the point of adding new tests if the implementation didn't change?

@waj i think we need to know what happen when all the elements of array have been removed. return empty array, nil or exception.

I understand, is not a big deal. It's just that is a bad practice in TDD to add tests that doesn't fail before changing the implementation.

I'm sorry. I mistook it.
I will commit once more

@waj I understand what you say. Thanks. now I remove the tests. Thanks.
I just add the descriptions.
I'm sorry for the mishap.

Thanks!


[CFE] Library cannot augment itself

Now the following code is accepted by CFE.
// Library 'main_lib.dart'.
library augment 'main_lib.dart';
import augment 'main_lib.dart';
...

According to the https://github.com/dart-lang/language/issues/3646 it should be a compile-time error
Tested with
Dart SDK version: 3.4.0-204.0.dev (dev) (Tue Mar 5 20:04:06 2024 -0800) on "windows_x64"
Dart SDK version: 3.4.0-edge.dfe0457f84352a402c7fe590c743cef3e2280509 (main) (Tue Mar 12 00:50:43 2024 +0000) on "linux_x64"

This is obsolete with https://github.com/dart-lang/language/issues/3848


fs::copy API

The format for errors from fs::copy are a little different because there are two paths involved. I solved this in my FS abstraction crate by having a new internal error type, CopyError.
I can PR this; I'll need it to port some projects over to use fs-err!

Sounds good, a PR would be welcome 👍


Track Activity log in the DB

Add records in DataModel
Add method to populate the tables in the DB with the necessary data at the end of the activity.

@dcolleoni @dtrzesniak which "necessary data" have to be uploaded to DB? Could we have a list here to facilitate the analysis of the linked PR?

@dcolleoni @dtrzesniak which "necessary data" have to be uploaded to DB? Could we have a list here to facilitate the analysis of the linked PR?

We need to log the conditions to be able to reproduce the calculations.
Data inputs normally trigger many calculations, and we need to save various things. We need to ensure that whatever state we have, we are never inconsistent in the data --> showing outdated results. We have to also be careful here, as some updates should not trigger recalculation: example yield curves in the past.
We need to be able to show this though, and by looking at the logs any auditor is able to reproduce the numbers.
Not sure it answers what you asked.


agent configuration of multiple instances service(cluster)

Please answer these questions before submitting your issue.

Why do you submit this issue?
[√] Question or discussion

Question

What do you want to know?
Hi, what should I config for "agent.service_name" if there are multiple instances for a service, should they all share below agent.config(same namespace and same service_name):

agent.namespace=${SW_AGENT_NAMESPACE:xxx-application}
agent.service_name=${SW_AGENT_NAME:xxx-service}

would appreciate some help to clarify this.

oops, just saw in https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties
agent.service_name: ...service instance nodes share the same code
sorry, closing this.


Create iceoryx2_cli command to list the full system configuration

Brief feature description
The file iceoryx2-bb/posix/src/system_configuration.rs provides the interface to the configuration of all system resources and a print_system_configuration() function to show them. Now, since iox2 is finally here, we should remove the function print_system_configuration() and move it into an iox2-config command to show the config from the command line.

Make a binary called iox2-config in the crate iceoryx2-cli
Make a verb show to show the currently used configuration
Make a verb generate to generates a default configuration file in the default location that iceoryx2 looks for it

cc @orecham maybe you can provide a bit more details what steps one has to make and also provide a name suggestion directly in the issue description.

@elfenpiff Made a rough plan, the implementer can take some creative liberties though, if they have ideas that make more sense


moved to swift 3

In case you don't want to do it yourself;)

Thanks again. I've been meaning to get around to doing this.

@nidegen I pushed some additional improvements, including updating the unit tests to Swift 3.

oops, missed these:)


Add environment variables for batch ensembling

This PR adds environment variable configuration via the SDK. The API also supports environment variables to be propagated to the Spark driver and executors.
I regenerated the OpenAPI stubs and it seems that I have forgotten to regenerate the stubs from this PR: https://github.com/gojek/turing/pull/93

Done with review and left some suggestions.
Can you also make sure that UI renders env variables as well? All components and layout is already done as part of my previous PRs, but you might need to change the variable name here:
https://github.com/gojek/turing/blob/2c673b24428589f84d71d710f7ad9777f6ac9dbd/ui/src/jobs/details/config/configuration_section/ConfigurationConfigSection.js#L18

Looks good to me:

One more question, why do we define this type manually, instead of using the one generated from the openapi specs:
https://github.com/gojek/turing/blob/992d465ceb24a9f7e84a7c3346bed982a58862c6/api/turing/models/ensembling_job.go#L66
?
I likely missed it in the previous review rounds, but now it came to my attention because you are manually adding EnvVars field into it, instead of re-generating it from the specs

InfraConfig has always been hand written. JobConfig is generated. I'm not sure if it should be inside the JobConfig since the value is going to be discarded by the ensembler. I put it into InfraConfig since it is easier to reference the value rather than navigating through the clunky JobConfig. Also I would suppose environment variables has always been an infra thing.

One more question, why do we define this type manually, instead of using the one generated from the openapi specs:
https://github.com/gojek/turing/blob/992d465ceb24a9f7e84a7c3346bed982a58862c6/api/turing/models/ensembling_job.go#L66
?
I likely missed it in the previous review rounds, but now it came to my attention because you are manually adding EnvVars field into it, instead of re-generating it from the specs

InfraConfig has always been hand written. JobConfig is generated. I'm not sure if it should be inside the JobConfig since the value is going to be discarded by the ensembler. I put it into InfraConfig since it is easier to reference the value rather than navigating through the clunky JobConfig. Also I would suppose environment variables has always been an infra thing.

No, the question is not about where EnvVars should be (I'm ok with having it under InfraConfig). What I'm trying to understand why

InfraConfig has always been hand written

One more question, why do we define this type manually, instead of using the one generated from the openapi specs:
https://github.com/gojek/turing/blob/992d465ceb24a9f7e84a7c3346bed982a58862c6/api/turing/models/ensembling_job.go#L66
?
I likely missed it in the previous review rounds, but now it came to my attention because you are manually adding EnvVars field into it, instead of re-generating it from the specs

InfraConfig has always been hand written. JobConfig is generated. I'm not sure if it should be inside the JobConfig since the value is going to be discarded by the ensembler. I put it into InfraConfig since it is easier to reference the value rather than navigating through the clunky JobConfig. Also I would suppose environment variables has always been an infra thing.

No, the question is not about where EnvVars should be (I'm ok with having it under InfraConfig). What I'm trying to understand why

InfraConfig has always been hand written

Something's amiss here, am I out of the loop about something? Has the models package been autogenerated or something?

There's some stuff in InfraConfig that is not in the JSON payload, like EnsemblerName.

Ok, this is the answer I was looking for :) However I can see ensembler_name defined in the EnsemblerInfraConfig  schema.
I was wondering why the JobConfig is just an alias to openapi.EnsemblerConfig, but InfraConfig is defined completely from the scratch.
If it's the case that InfraConfig has some extra fields, compared to openapi schema, then it can still be composed from the base type + extra fields, similar to this:
type InfraConfig struct {
    openapi.EnsemblerInfraConfig
    EnsemblerName string `json:"ensembler_name"`
}

@romanwozniak Could you help to take a look at the last commit one last time? I refactored to use the openapi generated code but it's quite a number of changes involved.


fix(summeruniversity): improve equality start/end location

:tada: This PR is included in version 1.33.28 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[T3A4][W09-A2] Jasmine Ang

Ready for review

It's the right method to throw the exception. But the solution seems to be partial.
Please close the PR after reading comments.


chore: cleanup.

@KillDozerX2 this is a cleanup PR. There is no need to keep the original CloudFormation schemas.

Let me review this please.

@KillDozerX2  The original idea is maintained, the files are generated with node index.js I just changed the paths and remove the originals files. In the future we just download the zip from https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip and, unzip it in the cloudformation/ folder in the root of the project, I added this folder to .gitignore, like this that the original files will never be committed. When we generate the new files with node index.js, git will do its magic, and we will only see the new changes.

Yeah, but I've made some modifications, even to the original files. For example, I've added an enum for DynamoDB -> KeySchema -> KeyType, even the Cloudformation docs say that only two values are allowed, but for some reason the schema from Cloudformation specifies it as string. What do you think the solution would be here?

I'm sorry, I didn't realize that, let me think about this. Of the original files, which ones have you modified?

I seriously can't remember. Focused on a lot of them. I will close this PR, I've made a few more updates till then.


Audio via Microphone capture

Hi,
Is audio capture via microphone a planned feature?  wcap does not appear to record from my attached microphone, but it does capture system audio.
Thanks

Yes, wcap records only output audio via loopback recording. If you can configure your audio settings to mix microphone input into system's audio output then it will be captured.
Currently I have no plans to add extra audio source like microphone input to capture.

It's not just a parameter. You would need to capture to audio sources, and properly mix them together to encode to single audio track. Not that it is complex, it's just very annoying. Timing needs to be correct, the volumes need to be correct. Those probably need to be exposed so user can adjust relative volume, and add offset in case their audio drivers are crappy. Just a lot more to deal with...

Thank you. I will research more this issue. I would think that we could start with the default microphone, in order to avoid having to build a picker.

@mmozeiko I might have dreamt, but I remember there was a pull request for microphone recording. Did you delete it recently?

I've never seen such pull request.


chore(build): bump toolchain to 2022-10-16

Co-Authored-By: xxchan<EMAIL_ADDRESS>Signed-off-by: Bugen Zhao<EMAIL_ADDRESS>I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR is mostly a replication of https://github.com/risingwavelabs/risingwave/pull/5119. We use a workaround for zip_order_key to make it compile.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#5977

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: BugenZhao:x: UbuntuUbuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@MrCroxx I've workaround the file cache lifetime problem. You should fix it if you have time later.

@BugenZhao Any idea why building simulation timed out on CI? 🥵

@BugenZhao Any idea why building simulation timed out on CI? 🥵

Nope. 🥺 Does it mean we should write code really carefully after this PR? 🥵

Building nexmark_chaos.rs become extremely slow in the new toolchain. Need help from rustc experts 🆘

Thanks for identifying 🤣

Building nexmark_chaos.rs become extremely slow in the new toolchain. Need help from rustc experts 🆘

There shouldn't be much black magic inside. Perhaps const generic?

Probably yes. Also why don't we merge hello, nexmark_chaos, nexmark_q4 into one single binary?

That's okay. But I think there's no problem to separate integrated tests into multiple files? 🤣

Still don't think we should get this merged before the compiler fixes the issue. It's abnormal to put such effort or attention on these hacks while programming. 🤔

Still don't think we should get this merged before the compiler fixes the issue. It's abnormal to put such effort or attention on these hacks while programming. 🤔

I think it's more like we are abusing the type system. Sometimes we just insert random 'a at some random place and we even don't know why it works.

Agree on some storage stuffs, but it makes little sense on such a simple integrated test. 🤣

Agree on some storage stuffs, but it makes little sense on such a simple integrated test. 🤣

This is something I've been fixing before. All interfaces exposed by lib and not needed for inlining should have BoxFuture. Otherwise it will be recompiled in every binary. Let's see if it improves compile speed.

I feel like it's also a bug of lifetime inference. FnMut seems to be the root cause for slow integration test compile. Will reproduce later. Let's workaround it first.

Removing impl<ToString> and impl<IntoIterator> seem to fix everything.

Removing impl<ToString> and impl<IntoIterator> seem to fix everything.

This is unreasonable. 🤣🤣 There should be tons of occurrences in well-known library crates of them.


problem with fee amount

Hello,
There is a problem with the fee amount :
I could reproduce the error both on my install and on demo.cocorico.io :
after booking a listing ; on the last page Total amount including fees adds 100 euros of fees!
I changed the parameters.yml in src  with the fee as asker and as offerer to different values  but still adds 100euros as  a booking fee...
clear php cache , browser cache restart apache....
I also modified in mysite.com/admin : it works only with 0
In which format do we need to put the fee : 10% ; 10 ; 0.1 ?
same question in the parameters.yml which format do we need to write?
Do we need to change both parameters.yml and /admin for it to work?
I think it's a bug
Thank you

Hi,
Look into the Cocorico/CoreBundle/Resources/config/parameters.yml you will see the default values and format : ex for 10% it is 0.1.
This parameters are the default fees. But you can override them through admin. The format still the same : 0.1 for 10%.

Hello,
Tuant toi dit tout answer; this is what I entered but then the fees are
100€ even for small amounts... you can check also in demo.cocorico.io it
gives also a fee of 100€ even for small amounts . I think there is a bug
somewhere...
Thank you
Le 4 sept. 2017 3:56 PM, "Cocolabs"<EMAIL_ADDRESS>a écrit :

Hi,
Look into the Cocorico/CoreBundle/Resources/config/parameters.yml you
will see the default values and format : ex for 10% it is 0.1.
This parameters are the default fees. But you can override them through
admin. The format still the same : 0.1 for 10%.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Cocolabs-SAS/cocorico/issues/64#issuecomment-326969584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFU1AjYV5NS-I2gIePp2p1n6IxbSIK8vks5sfAGXgaJpZM4PHOZk
.

Hi,
the fees percent value in demo admin was 10 meaning 1000%. Put 0.1 or erase the value in admin and it will be resolved.


Polls are lost if the bot crashes/restarts while a poll is running

They are kept in memory so they go away. There is no way right now to get them back and there should be

Not a bug, missing feature. There is already some output info being saved to disk for polls to persist them in preparation for dealing with this issue, but I didn't have a good solution for loading it until recently. Can create a single command that also works for normal poll creation, and parse with parseArgs


error: product dependency 'Configuration' not found

after update
   .target(name: "Application", dependencies: [ "Kitura", "KituraCORS", "Configuration", "CloudEnvironment", "Health" , "SwiftMetrics",   ]),
swift package generate-xcodeproj
I got an error that is:
error: product dependency 'Configuration' not found

After delete "Configuration", I can generate project.
After Step 7, I refresh the test html, I still failed the first test.


Engie - Scraper doesn't run

ENVIRONMENT: production
URL: https://firme.peviitor.ro/
Browser: Safari
Device: Laptop
OS: macOS 14 Sonoma
STEPS TO REPRODUCE:
Open URL: https://scrapers.peviitor.ro/ in browser
Type "codezilla" in the search bar
Click on "Codezilla" file
Click on "Run Scraper" button
EXPECTED RESULT:
After clicking "Run Scraper" relevant data pertaining to the company "Codezilla" is retrieved without any errors.
ACTUAL RESULT:
After clicking "Run Scraper" the following error is observed with the message: "python3: can't open file '/root/scraper_Api/scraper_Api/scrapers/Scrapers_Job_PeViitor/sites/engie_scraper.py': [Errno 2] No such file or directory"

This environment will not be used in the future


ci: Update triggers for NPM pipelines

Reason for Change:

Adds triggers for tags and PR(s).
This will enable Scale Test and NPM Conformance pipelines to be required for PR(s) that impact npm/* and all to be ran when merge to master occurs or a tag is created.
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[x] relevant PR labels added

Notes:

/azp run NPM Conformance Tests

/azp run Azure Container Networking PR

/azp run NPM Scale Test


Login component rendered after login on homepage #401 - avoid setting intendedRoute to 'login'

fix for solution 2. described in #401 - avoid setting intendedRoute to 'login'. @aconeanu mentioned :"We never want the intended route to be login.". Issue occurred when a link was clicked while the app session was expired, and intendedRoute was overwriting initial intended route with additional API calls (like loading some filter options) which were redirected to login. This made the next page after login load a login form as homepage.

@Reviewer :

I've tested similar behavior for intendedPath and did not find the same issue. If after session is expired the URL is force to a page where filters were loaded incorrectly before table, the  intendedPath is not set to "/login". Therefore, I did not felt that setIntendedPath needs changes.
Regarding the explicit function codding - I've seed that you do not normally use hard to read code like:

setIntendedRoute: (state, value) => (value && value.name !== 'login' && (state.intendedRoute = value))

neither one-line-ifs, so I keep the code plain and simple, similar to other enso-ui implementations.
Feel free to choose whatever form you like 👍🏼

@robbykrlos I look at this and somehow I feel that it would be better to have this check here
what do you think?

@robbykrlos I look at this and somehow I feel that it would be better to have this check here
what do you think?

@aocneanu it felt a bit wrong since intendedPath did not have any issues, so it was something more specific to intendedRoute whet it was set as login route specifically.
So yes, seems better this way, and we'll keep the setter nice and simple.
Let me give it some tests and will PR this new change


Fix transitivity of Value#compareTo.

This is breaking certain map operations.
https://kolmafia.us/threads/6445/page-115#post-169713
For instance:

the darkness (blind) > fired-up Knob Goblin King (string comparison)
the darkness (blind) < zombie waltzers (string comparison)
zombie waltzers < fired-up Knob Goblin King (id comparison)

There is still... special breakage with how we handle Ed the Undying (which has some special fix-up in MonsterDatabase), although the fix isn't superficial.
Note that I removed various comparisons of mixed Types. I do not think these are exercised in real code because Operator will perform coercions such that the resulting types are sufficiently similar.

This change means that "150" == 150 is no longer true, which I think at least one script was relying on.
Instead, can we order monsters by id, then string? I don't think anything relies on the string ordering (though I may be proven wrong).
And also:
> ash (150 == "150")

Cannot apply operator == to 150 (int) and 150 (string) (char 2 to char 14)
Internal error: left hand side and right hand side do not correspond ()
Returned: void

> ash ("150" == 150)

Returned: true

This is plain odd! Equality isn't symmetric.

Instead, can we order monsters by id, then string? I don't think anything relies on the string ordering (though I may be proven wrong).

By that, do you mean add a special case to bypass all of the isStringLike() logic, as we do for VYKEA_TYPE? We currently only use the string ordering as a fallback if monster id == 0. The problem arises when we compare a monster with id == 0 with one with id != 0.

This is plain odd! Equality isn't symmetric. It wasn't before this PR, either (but the latter comparison was true).

This reads to me like an issue with how we do coercion.
Anyways, I'll think about this a little more.


New term proposal: ´num_capture_reamp_cycles´

New term details
For us to assess a new term request we require the following details:
Term name - Number of capture reamplification cycles
Structured comment name - num_capture_reamp_cycles
Definition - Number of amplification cycles after capture enrichment
Expected value - number of amplification cycles
Value syntax - {integer}
Example - 10
Preferred unit - NA
Package(s) - ancient

Additional context
Add any other context about the new term here.

This term will be for the MInAS project's proposed ancient extension


Fix footer gap

First thing, PLEASE READ THIS: [Code Review Checklist]

Description
Fix footer gap
Fixes #32
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Screenshots or example output

Looks like we need to rebuild the deployment

Looks like we need to rebuild the deployment

Yes, but I am unaware if I have the required permission to do it.


Experimental support error

Im getting Experimental support for decorators is a feature that is subject to change in a future release. Set the 'experimentalDecorators' option to remove this warning
This is my tslint.json:
{
  "compilerOptions": {
    "experimentalDecorators": true
  },
  "include": [
      "src/**/*"
  ],
  "exclude": [
      "node_modules",
      "**/*.spec.ts"
  ]
}

If I run tsc with --experimentalDecorators it compiles fine :/

Compiler options are defined in tsconfig file, not tslint. This issue is not real.

I'm using angular-cli, and it creates a tsconfig.json file with the "experimentalDecorators": true already, but I'm still getting this warning. How did you solve it?

When I added the option to my tsconfig file it stopped happening.

Make sure your task specifies the config file with --config and see if it still happens


Fix #4248

This pull request includes a

[x] Bug fix

The following changes were made

Added test case
Observe subtree for added options and sync the container text

Issue: #4248

The new test fails as expected, still trying to fix it, but there might be a design decision to make so I'm not really sure. Should _syncAttributes be extended to support this ? should a new _sync method be added ? should we reuse the same observer and enable subtree: true on it for performance or make another observer ?

Ready for review B)

I've mentioned it on other channels (IRC, specifically) that this pull request has issues because it bypasses the formatting of selections. This is because instead of triggering selection:update with the new selection, it just sets the selection directly. This also only works on single selects, partially because that's the easiest to design for, but it results in this being inconsistent.
As a result, I'm finally going to formally reject this pull request. Tonight I'll take a shot at doing this in a way that works with the Select2 event system instead of bypassing it.

Perhaps you could reuse the test case though ?


Adopt ServiceContext 1.0

Resolves https://github.com/apple/swift-distributed-tracing/issues/99
Motivation:
The baggage type ended up more useful than anticipated and we're renaming it to ServiceContext for the 1.0 release.
Many libraries and production systems end up passing context around which may not necessarily be related to tracing, which made us make this naming change. Functionally ServiceContext and Baggage are the same, but the way we talk about context propagation in general makes more sense if we call this a context stype.
Modifications:
Use the new type; The Baggage still exists in the InstrumentationBaggage module so people can still use it if they wanted to but it is a TYPEALIAS to the ServiceContext.

Thanks for review! I’ll push this to completion on Monday I think

Sorry to have you folks pinged while this was still a draft; I've gone through now cleaning up more of the baggage word use and will be doing another pass tomorrow to clean things up and add any necessary wording about what the context is.
The entire README is to be replaced by the reference docs pages.


Tweak the ChatQuery.Role API

What
Make  the Chat.role property Role instead of String.
public struct Chat: Codable, Equatable {
    public let role: String // <<
}

Why

It offers consistency and make comparing its role less weird.

Before:
Chat(role: .user, ...)
XCTAssertEquals(chat.role, "user")

Now:
Chat(role: .user, ...)
XCTAssertEquals(chat.role, .user)

When others wanting to use Role as their first class type, they don't want to parse from the string unsafely like
Role(rawValue: chat.role)!

Affected Areas

I have a demo app that follows this https://github.com/DJBen/OpenAI/pull/2.
For convenience, can you add me to the collaborator list, so I can create PRs here?

I just gave a quick look at your demo app and it's awesome😍
Sure, it's a good idea, I can add you as a maintainer asap, but I need to contact organization admins first 👌

You are right. Let me amend and remove this file.On Apr 9, 2023, at 2:51 AM, Sergii Kryvoblotskyi @.***> wrote:
@Krivoblotsky commented on this pull request.
On Demo/Demo.xcodeproj/xcshareddata/xcschemes/Demo.xcscheme:
Hey, @DJBen!
Do we need this file to be included with this PR?
Look like a part of the next one.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


update cc

👷 Deploy Preview for fancy-puffpuff-df775f processing.

Name
Link

🔨 Latest commit
9d720140fc9826f87f616e9739214de6c7ae168a

🔍 Latest deploy log
https://app.netlify.com/sites/fancy-puffpuff-df775f/deploys/6672e954a702ae0008ee2f88


How this can work with other docker-compose file?

Comments
Hello, may I know how should I update the docker-compose file after I run the ./start.sh, many thanks!
I guess I need to add sth like ::
networks:
- webproxy
My original docker-compose file  :
version: '3'
services:
    botlinker-service:
      image: registry.gitlab.com/liquidsky/hello-bot:v1.0
      working_dir: /code
      volumes:
        - .:/code
      ports:
        - "80:3000"
      depends_on:
        - mongodb
    mongodb:
      image: "mongo"
      container_name: mongo
      working_dir: /code
      ports:
        - "27020:27017"

Im having the same problem (502 Bad Gateway) but with Jenkins
https://github.com/jenkinsci/docker/blob/master/Dockerfile
version: "3"
services:

  jenkins:
    image: jenkins/jenkins:lts
    environment:
        VIRTUAL_HOST: xxx.site.com
        VIRTUAL_PORT: 8080
    networks:
      - webproxy

networks:
  webproxy:
    driver: bridge

Sorry, my bad. Network section of docker-compose.yml is incorrect. Working example:
version: "3"
services:

  jenkins:
    image: jenkins/jenkins:lts
    environment:
        VIRTUAL_HOST: xxx.site.com
        VIRTUAL_PORT: 8080

networks:
    default:
       external:
         name: webproxy


time: Parse of am/pm should be forgiving of spaces and case

What version of Go are you using (go version)?

1.17.5

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
Mac OS

What did you do?
import (
"testing"
"time"
)
func TestParse(t *testing.T) {
var tm time.Time
var err error
tm, err = time.Parse("3:04PM", "5:23 PM")
if err != nil {
	t.Error(err)
}
if tm.Hour() != 17 {
	t.Error("hour does not match")
}

tm, err = time.Parse("3:04pm", "5:23PM")
if err != nil {
	t.Error(err)
}
if tm.Hour() != 17 {
	t.Error("hour does not match")
}

}
What did you expect to see?
Tests pass
What did you see instead?
=== RUN   TestParse
parse_test.go:14: parsing time "5:23 PM" as "3:04PM": cannot parse "M" as "PM"
parse_test.go:17: hour does not match
parse_test.go:22: parsing time "5:23PM" as "3:04pm": cannot parse "" as "pm"
parse_test.go:25: hour does not match
--- FAIL: TestParse (0.00s)

@rsc per owners.
It seems as though it would be very easy to write a bit of Go code that would preprocess time values to put them in canonical form prior to the time.Parse() invocation. That is, if you want  both "PM" and "pm" to be accepted, just pattern match the tail end of the value string and replace it if needed.

Another example, including periods and dots:
parsing time "07/13/2023 9:34 A.M." as "01/02/2006 3:04 P.M.": cannot parse "A.M." as " P.M."

(error message is self-explanatory; just tried this in the 1.20 playground)


programs.feh.keybindings does not support multiple keys for one value

in feh, you can have more than one key corresponding to the same action, but in Nix home manager programs.feh.keybindings you can only have one value per action (one key only)

A bit of a hack, but what has worked for me is to just put multiple keys, separated with whitespace, in the string for a command. E.g.
{
  programs.feh.keybindings = {
    menu_parent = "h Left";
    menu_down = "j Down";
    menu_up = "k Up";
    menu_child = "l Right";

    prev_img = "h Left";
    next_img = "l Right";

    zoom_out = "j Down";
    zoom_in = "k Up";
  };
}


Bounding box around multiple detection (custom DB)

Hello,
During training the visualization results in a single BB around ALL the objects of the same class, whereas what I would have expected is a separate BB box around each object.

What am I doing wrong?

Sorry, I'm not sure what you are saying about..


add more NFData instances

adds:

NFData2 HashMap
NFData k => NFData1 (HashMap k)
NFData1 HashSet

closes #304

I'm all in favor of the new instances. Please make sure performance is not lost for existing instances. Either

Check that they produce identical Core (including unfoldings, arity, and unfolding guidance)
Benchmark with several instances, especially including cheap ones (e.g., ones where deepseq = seq, where rnf = const (), and where rnf just forces one field of a record), where the map is various sizes and already in normal form.
Leave the existing instances alone and just add the new ones on top. This is a bit silly, of course, but it's certainly the easiest way to be confident you won't goof anything up.

Will inspection-testing be sufficient for proving (1)?
On Sat, 6 Feb 2021, 10:35 am David Feuer<EMAIL_ADDRESS>wrote:

I'm all in favor of the new instances. Please make sure performance is not
lost for existing instances. Either

Check that they produce identical Core (including unfoldings,
arity, and unfolding guidance)
Benchmark with several instances, especially including cheap ones
(e.g., ones where deepseq = seq, where rnf = const (), and where rnf
just forces one field of a record), where the map is various sizes and
already in normal form.
Leave the existing instances alone and just add the new ones on
top. This is a bit silly, of course, but it's certainly the easiest way to
be confident you won't goof anything up.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-774361006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATLFOJT7JJ6XWVAEQRJ33LS5SFG5ANCNFSM4XFU3WYA
.

No, I don't think so. That's not looking at things like unfoldings.
On Fri, Feb 5, 2021, 9:37 PM Isaac Elliott<EMAIL_ADDRESS>wrote:

Will inspection-testing be sufficient for proving (1)?
On Sat, 6 Feb 2021, 10:35 am David Feuer<EMAIL_ADDRESS>wrote:

I'm all in favor of the new instances. Please make sure performance is
not
lost for existing instances. Either

Check that they produce identical Core (including unfoldings,
arity, and unfolding guidance)
Benchmark with several instances, especially including cheap ones
(e.g., ones where deepseq = seq, where rnf = const (), and where rnf
just forces one field of a record), where the map is various sizes and
already in normal form.
Leave the existing instances alone and just add the new ones on
top. This is a bit silly, of course, but it's certainly the easiest way
to
be confident you won't goof anything up.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-774361006
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AATLFOJT7JJ6XWVAEQRJ33LS5SFG5ANCNFSM4XFU3WYA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-774383336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7LEKY5ZHXJ3GFIJIZDS5STNPANCNFSM4XFU3WYA
.

Given that, I decided to leave the existing instances as-is and only add the new ones.

Can you add some CPP, so the new instances are only defined with recent enough versions of deepseq?

Or should we bump the minimum deepseq bound?
On Mon, Feb 8, 2021, 8:18 AM Simon Jakobi<EMAIL_ADDRESS>wrote:

Can you add some CPP, so the new instances are only defined with recent
enough versions of deepseq?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-775144077,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7I3JMNSQRRJQESBL3DS57QCJANCNFSM4XFU3WYA
.

Or should we bump the minimum deepseq bound?

I think that might limit GHC compatibility too much for people who can't easily upgrade boot libraries separately from the compiler.

The latest deepseq supports base>=4.5. Even we don't go back that far!
On Mon, Feb 8, 2021, 12:57 PM Simon Jakobi<EMAIL_ADDRESS>wrote:

Or should we bump the minimum deepseq bound?
I think that might limit GHC compatibility too much for people who can't
easily upgrade boot libraries separately from the compiler.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-775330116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7LH7GDEAZJDBOWTRZTS6AQXBANCNFSM4XFU3WYA
.

The latest deepseq supports base>=4.5. Even we don't go back that far!

True. But AFAIK using the latest deepseq with e.g. GHC 8.2 is rather tricky with e.g. Nix.

Explain?
On Mon, Feb 8, 2021, 1:02 PM Simon Jakobi<EMAIL_ADDRESS>wrote:

The latest deepseq supports base>=4.5. Even we don't go back that far!
True. But AFAIK using the latest deepseq with e.g. GHC 8.2 is rather
tricky with e.g. Nix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-775333582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7NI4XNVCWHYHPM2YITS6ARLDANCNFSM4XFU3WYA
.

I don't remember the details. AFAIK it's non-trivial to update boot libraries with Nix. I think I once tried to update containers or bytestring and it was a PITA.

For this we'd only need deepseq-1.4.3, which came out in July, 2017.
Honestly, if someone has to fuss a little too use that with an old GHC, I
don't think that's our problem.
On Mon, Feb 8, 2021, 1:05 PM Simon Jakobi<EMAIL_ADDRESS>wrote:

I don't remember the details. AFAIK it's non-trivial to update boot
libraries with Nix. I think I once tried to update containers or
bytestring and it was a PITA.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-775335782,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7I7V26LTLZXLIXZZWTS6ARXTANCNFSM4XFU3WYA
.

OK. If that's easier we'll need to update the deepseq bound and fix CI.

It's easy either way, but CPP always makes the future harder.
On Mon, Feb 8, 2021, 1:34 PM Simon Jakobi<EMAIL_ADDRESS>wrote:

OK. If that's easier we'll need to update the deepseq bound and fix CI.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-775354211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOOF7KRXNVDMRJFA2ZOIQTS6AVEJANCNFSM4XFU3WYA
.

CI is failing.

Yes, it is. Have you reached consensus on how you'd like me to fix the
version issue? It looks like it leans toward "increase the deepseq bound".
On Fri, 12 Feb 2021, 4:50 pm David Feuer<EMAIL_ADDRESS>wrote:

CI is failing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/haskell-unordered-containers/unordered-containers/pull/305#issuecomment-778013368,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATLFOKRHZ3T3QG7LCMTKRLS6TFSHANCNFSM4XFU3WYA
.

That's definitely my inclination, yes.

Have you reached consensus on how you'd like me to fix the version issue? It looks like it leans toward "increase the deepseq bound".

My preference is for retaining backward compatibility with deepseq < 1.4.3, but raising the bound doesn't seem too bad either.

On third thought, I'm fine with raising the deepseq bound for now. If this ends up causing problems for users we can probably improve compatibility later on.
@LightAndLight Could you raise the bound and fix CI, please?

I believe bytestring is the last package where the installed constraint needs to be removed. You can check this locally by using the generated cabal.project.local locally and building with GHC-8.0.2, GHC-7.10.3 and GHC-7.8.4.

I'd like to cut a release fairly soon and ideally include this PR. Do you think you can finish this PR in the next, say, 2 weeks, @LightAndLight? Otherwise I can take a stab at it, but I'd probably take the CPP route.

I can reproduce the error from https://travis-ci.com/github/haskell-unordered-containers/unordered-containers/jobs/495652251 by using the following cabal.project.local:
constraints: Cabal installed
constraints: array installed
constraints: base installed
constraints: directory installed
constraints: filepath installed
constraints: ghc installed
constraints: ghc-boot installed
constraints: ghc-boot-th installed
constraints: ghc-prim installed
constraints: ghci installed
constraints: haskeline installed
constraints: hoopl installed
constraints: hpc installed
constraints: integer-gmp installed
constraints: pretty installed
constraints: rts installed
constraints: template-haskell installed
constraints: terminfo installed
constraints: transformers installed
constraints: xhtml installed

and the following command:
cabal build -w ghc-8.0.2 --enable-benchmarks --enable-tests

I think the error message is pretty unhelpful, but I noticed that the process dependency might be constrained by its directory and filepath dependencies. Indeed removing these constraints from the cabal.project.local makes the command succeed.
With 7.10.3 I also have to remove the constraint on pretty and increase --max-backjumps.
I don't have 7.8.4 installed, so I haven't been able to test with it.
I'm not sure how much more pain it would take to fix the CI setup. We can probably take a shortcut and disable the benchmarks for GHC < 8.
I'm slightly worried that some users might end up going down this constraint-fighting path too though, so I think we should rather switch to the CPP route. I'm sorry that I didn't insist on it in the first place.

Merged via #314. Thank you, @LightAndLight!


mognodb database name is hardcoded in all Models

What steps will reproduce the problem?
Generate any model with MongoGii.
What is the expected result?
The model should take only collection name like mysql table. else problem is, if I copy the setup to another instance, I need to manually find and replace all occurrences of database-name. when we are already providing the database name in config, why it needs the db info from model.
What do you get instead?
Additional info

Q
A

Yii version
2.0.31

PHP version
7.2.24

Operating system
Ubuntu Linux 18.04

The solution sounds like the one breaking backwards compatibility. Am I correct? We may do it in 2.2.0.

I didn't get what you mean by "breaking backwards compatibility".  What I am trying to say is like say I have one yii2 where I have 50 collections.
I copy the whole yii2 setup for another application for reuse. Now in the new setup the database name is different. Since db-name is included in all the 50 models, I have to replace all occurrences of db-name in all models.
In mysql model we return only table name, so I think we can use only collection-name for mongodb model.
please let me know if you need any other info.

"breaking backwards compatibility" means that if we'll replace database name with collection name, existing applications that relied on the old behavior may break.

yes samdark. that is correct. if we change the database name only in config file and don't make change in all models it will break. collection-name remaining same.


cbft can infinite loop on non-json document

cbft gets stuck if you put a non-json doc into a bucket.
That is, cbft seems to infinite loop trying to parse a document value as JSON when it isn't JSON.
The current theory is that when bleve Batch ingest encounters an error on some document in the batch (during mapDocument()), then bleve Batch() will return an error.  (But we don't know which exact doc in the batch had an error.)  This error in turn propagates back to cbft and then in turn back to cbdatasource, which in turn shuts down its DCP connection, and restarts the entire DCP stream.
But, the DCP stream (correctly) just restarts where it left off (re-streaming over the same problematic docs).  So the error repeats.
cbft might need to use a lower-level bleve API instead of the easy-to-use high-level "porcelain" bleve Batch API, so that cbft can detect that there's a document mapping / character-analyzer error and just ignore that document in the batch.  (cbft also probably needs to track and expose a "side area" of errors for things like document parsing/analysis errors, like "these are some of the docs which recently couldn't be indexed and the related error info".)
In more detail, the actual error appears like this...
2015/02/24 21:39:47 feed_dcp: on error: intrapop-leveldb.1_4fc326d5c2fec085: error: HandleRecv, err: invalid character 'h' looking for beginning of value

The document was just the (non-JSON) bytes of "hello".

looks like updating to bleve's new Batch.Index API fixed this


remove obsolete rust config

Fixes #6070
and
rustic depends on rust-mode since version 2.0 so the rust-mode hack shouldn't be needed anymore
depends on #6153

I've implemented your other changes and then some, to reflect changes upstream, along with a minor refactor of our :lang rust. For the time being I've kept the (after! org-src ...) block, but I'll keep an eye out for any changes upstream that make them redundant. Anyhow, thanks for bringing it to my attention (and for your great work on rustic)!


Consistent pretty-printing for open and closed type families

Currently pretty printing equations of open and closed type family equations is inconsistent:
   Calling type family ‘Id’ is not allowed in injective type family equation:
      IdProxy a -- Defined at T6018fail.hs:27:15

    Calling type family ‘IdClosed’ is not allowed in injective type family equation:
      IdProxyClosed a = IdClosed a

I want two fixes:

for open type families print the RHS
for closed type families print location

Suppose I say:
type family F a b (c :: k) = r | r -> a b

type family Fa a b (c :: k) = r | r -> a b c where
    Fa a b c = [F a b c]

I get:
Type family equation violates injectivity annotation.
Injective type variable ‘c’ does not appear on injective position.
Injective kind variable ‘k’ is not inferable from the RHS type variables.
In the RHS of type family equation:
forall (k :: BOX) a b (c :: k). Fa a b c = [F a b c]
In the equations for closed type family ‘Fa’
In the type family declaration for ‘Fa’

The quantified type family equation is not indented, unlike equations without forall. Thus I want a third fix:

indent equations preceded by forall.

After converting Fa to an open type family the equation is printed without forall quantifier - another inconsistency.

After changes in 00680ef86417907960e87f28c58b0024db2ffe10 there is no more inconsistency because makeInjectivityErrors now works for CoAxBranch (previously it was polymorphic to work with FamInst as well). The difference in pretty printing is exactly the difference between pprinting CoAxBranch and FamInst.


Golang not highlighting?

I'm trying to get my (hugo) blog to highlight go code, but it doesn't seem to work....
I started with v9.1.0, and just changed it to v9.4.0 but still no luck. I using both go and golang.
See this page for an example: https://penguinpowernz.github.io/2016/06/golang-interfaces/
Any ideas?
(it works for ruby)

The highlight.js package on CDN doesn't include a definition for Go (it only includes the "Common" set from https://highlightjs.org/download/). You can add it manually:
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.4.0/languages/go.min.js"></script>

If you're going to need more languages it'll be more efficient to download a custom package then to link to individual languages.

Ah!  Terrific, I did not realize that.  Thank you! :D

Yeah, that's one common gotcha we often have to deal with. The full package would've come close to 500K, so no chance of it being the default option :-)


Snapshots the default ansible role and names it v1.33.

This is only going in the v1.33 branch because we only need this to temporarily build from the v1.33 branch

If you build and use this within the Maistra/OSSM environment, it requires the Maistra operator to set its generated Kiali CR's spec.version field to v1.33.


Change EVM docker images to use the bench-build-base / llvm-10 images

@hugo-dc can you have a look?


Add an option/command to the formatter where the type declaration gets inserted on bindings

This is going to be a bit tricky since we need to decide which bindings should get types. It certainly can't be all bindings since that would mean annotating bindings such as let x = 1 which is just noise.
I can think of three strategies here.

Annotate all bindings that are exported from the module

// Annotate `let f x : Int -> Int ...`
let f x = x + 1
// Leave alone
let g y = y
{ f }

Expand type holes

// Expand `_` into the actual type
let f x : _ = ...

Insert the type on the binding under the cursor in the editor

let f x = ...
// ^ cursor here, insert `let f x : Type...`

I see this less as a formatting concern, and more of a interactive editing concern. Have you tried out interactive Agda and Idris sessions before? They can be super cool, with in-place case splits and hole expansion. You might also want to give a list of possible types if a hole could be more than one possibility.

Have you tried out interactive Agda and Idris sessions before

No, but it sounds like I'd want to try that before trying to implement stuff like this!

Lean is also a neat one to try, they have a really nice VS Code plugin. Alas they are lacking more on the code inference front - ie. case splitting and hole expansion.


Undo / Backup function

Is there a way to undo
mup deploy

if I get any errors? like saving a backup before?

See this thread and please report back if you still have issues thanks.
https://github.com/arunoda/meteor-up/issues/478

um...not really.
I would like to return to my previous version, e.g. to have something like:
mup deploy last release

so I can test a new release.


lomiri.u1db-qt: init at 0.1.7

Description of changes
Working towards #99090.
u1db-qt, a Qt5 binding & QML module for the U1DB API. Will be used by the Lomiri clock app.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 260967 run on x86_64-linux 1

3 packages built:

lomiri.u1db-qt
lomiri.u1db-qt.dev
lomiri.u1db-qt.examples

LGTM


refactor {request,cancel}Frame

Instead of creating new functions on every iteration, use the fact that hasRaf is static and only create functions once (and don't create functions for global methods). I don't think this is a super important change, but could be beneficial for perf and simplicity.

Very nice simplification 👍