GetAuthenticatedUser

using AuthFlow in our .NET MVC app, we ask for a user's Twitter name/pwd to establish a connection to Twitter. Our registered "confirmation" callback function looks like:
[AllowAnonymous]
public ActionResult Confirmation(long hash, string oauth_token, string oauth_verifier, string authorization_id)

// Using the last 3 parameters we then call
ITwitterCredentials newCredentials = AuthFlow.CreateCredentialsFromVerifierCode(oauth_verifier, authorization_id);

// and get a non null response

We then call:
Auth.SetCredentials(newCredentials);

// But, when we try:

 string connected_as = null;
 IAuthenticatedUser authenticatedUser = null;

 Auth.ExecuteOperationWithCredentials(newCredentials, () =>
 {
    // Get the IAuthenticatedUser from the specified credentials
    authenticatedUser = User.GetAuthenticatedUser(newCredentials);
    if (authenticatedUser != null)
         connected_as = authenticatedUser.ScreenName;
 });

// We get an exception.

// I've tried:
Tweetinvi.ExceptionHandler.SwallowWebExceptions = false;
try
{
}
catch(Tweetinvi.Exceptions.TwitterException tweetEx)
{
    //Execution never gets here
}
 // I've tried:
try
{
}
catch(Exception ex)
{
     //always returns null
     var lastEx = Tweetinvi.ExceptionHandler.GetLastException();
}

I've spent several days on this - I've tried many different approaches and it just doesn't work - Any help you could provide would be greatly appreciated

Forgot to mention TweetInvi version 4.0 - .NET framework 4.6.1 - Windows 10

Hello @vinceweeks-69,
Unfortunately as you did not manage to get out an exception out of Tweetinvi it will actually be impossible for me to help you without having access to your code.
Is it possible for you to share some code that reproduces this issue?
Thanks
Linvi

Thanks for your response but, I'm confused. The code that I've sent, is the code that fails. The call to GetAuthenticatedUser is the one that fails. Further, the code to retrieve credentials also goes through TweetInvi. There isn't any code of ours that could possibly participate in this.

Hello there,
I don't think there is a problem with your code per say. What I meant is that as you could not get some exception details, I would need to have access to a project that reproduces your issue.
If you could share a project on github or via a zip file I will be able to test it and provide further help.
Cheers,
Linvi

Thanks for your response. I'll have to see if I can get permission.

Closing as receiving no more feedback.


电脑手机传输

Could you please explain in English? That would be very much appreciated , thank you.

That title means "transferring data between PC and phone", which has no question, description or issue related... I think you could ignore and close it.

Thanks @shisaq, I have the same feeling, though I'll wait to hear from @coralinabubu for a few more days before closing it. I see they joined Github recently and might not be too much familiar with how it works yet.


Move syntax error description to notification body

closes #2346
This is a simple one! Although I only tested it on Windows 10, this should resolve the error on Windows 7... it moves the bulk of the error message for syntax validation to the body parameter of notify, as suggested.
Thank you @albinekb for marking this as a 'good first issue' and allowing me to contribute!

I'll check this out tonight 🙌 but awesome and thanks ❤

Nice catch !
I find another error like this, but it seems that it was the only one
Thank you so much @kjswalls  🙏

thank you! really excited to have contributed here, I use Hyper every day at work. <3


Custom icons for .lnk files (shortcuts) are ignored in v. 0.76.0

Microsoft PowerToys version
0.76.0
Installation method
PowerToys auto-update
Running as admin
None
Area(s) with issue?
PowerToys Run
Steps to reproduce

Create a LNK file that points to some other file (in my case, to an AutoHotkey file)
Go to the LNK properties and use Change Icon.. to change the LNK icon to something custom
Launch PowerToys Run and start typing the name of the new LNK shortcut

✔ Expected Behavior
Based on PowerToys Run behaviour up to v. 0.75.1, I was expecting the icon in the PowerToys Run window to be the custom one I set for the LNK shortcut.
❌ Actual Behavior
In PowerToys Run, version 0.76.0, the icon displayed is the icon of the target (in my case, the default AutoHotkey icon for all AutoHotkey scripts).
Other Software
No response

I am noticing a similar regression where icons for WSL applications are now all a generic icon whereas they were previously correct.

Another issue, about icons for Chrome Applications, that seems to be related:
https://github.com/microsoft/PowerToys/issues/30175


refactor(backend-tests): Use pic backend struct

Motivation
Historically the backend test environment consisted of a tuple (PocketIc, Principal).  This worked well until we needed multiple backend canisters, as is the case now.  In #1982 a structure was introduced to replace the role of that tuple.  Now we need to use it.
Changes

Bulk change the pic_setup tuple to the replacement struct.
Bulk change canister_query(...) to pic_setup.query(...) and the same for update.
Miscellaneous other changes required for the switch.

Tests

Please see CI

@AntonioVentilii-DFINITY  PicCanisterTrait defines methods such as query() and update(..).  To use these methods in a file, it is necessary to import the trait that defines them.

Thank you for the review!

Ah! thank you for the explanation!


Decoding netCDF is giving incorrect values for a large file

What happened:
0 value is decoded as 2
What you expected to happen:
Data encoded to -32766 should translate to 0
Minimal Complete Verifiable Example:
The first example is the base file I've been using, which is a 9GB packed netCDF. The first 12 values in this lookup should be 0 but are getting decoded as 2.
$ xarray.open_dataset("BIG_FILE_packed.nc").ssrd.isel(time=slice(0, 23)).sel(latitude=44.8, longitude=287.1, method="nearest").values
> array([2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
         2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
         2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
         2.565200e+04, 3.547440e+05, 1.091760e+06, 2.170378e+06,
         3.482364e+06, 4.704884e+06, 5.689655e+06, 6.297786e+06,
         6.534908e+06, 6.543667e+06, 6.543667e+06], dtype=float32)

This second example shows that if the file is decoded without automatic mask_and_scale, the value is decoded as 0 when applying the scale factor and add offset to an example value in the interpreter.
$ xarray.open_dataset("BIG_FILE_packed.nc", mask_and_scale=False).ssrd.isel(time=slice(0, 23)).sel(\
                      latitude=44.8, longitude=287.1, method="nearest").values
> array([-32766, -32766, -32766, -32766, -32766, -32766, -32766, -32766,
         -32766, -32766, -32766, -32766, -32725, -32199, -31021, -29297,
         -27200, -25246, -23672, -22700, -22321, -22307, -22307], dtype=int16)

$ xarray.open_dataset("BIG_FILE_packed.nc", mask_and_scale=False).ssrd.isel(time=slice(0, 23)).sel(\
                      latitude=44.8, longitude=287.1, method="nearest").values[0] * \
  xarray.open_dataset("BIG_FILE_packed.nc").ssrd.encoding["scale_factor"] + xarray.open_dataset("BIG_FILE_packed.nc").ssrd.encoding["add_offset"]
> 0.0

When the netCDF is unpacked using the nco command line tool, the correct values are unpacked.
$ xarray.open_dataset("BIG_FILE_unpacked.nc").ssrd.isel(time=slice(0, 23)).sel(latitude=44.8, longitude=287.1, method="nearest").values
> array([      0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
           25651.61906215,<PHONE_NUMBER>522 , 1091757.933255  ,
         2170377.23235622, 3482363.69999847, 4704882.32554591,
         5689654.23783437, 6297785.304381  , 6534906.36839455,
         6543665.4578304 , 6543665.4578304 ])

Something else that may be relevant is that another file with this same packed data but as much smaller subset (1.7KB) of the big file is unpacked correctly.
$ xarray.open_dataset("SMALL_FILE_packed.nc").ssrd.isel(time=slice(0, 23)).sel(latitude=44.8, longitude=287.1, method="nearest").values
> array([      0.  ,       0.  ,       0.  ,       0.  ,       0.  ,
               0.  ,       0.  ,       0.  ,       0.  ,       0.  ,
               0.  ,       0.  ,   25545.75,  354397.5 , 1091577.  ,
         2170077.  , 3482645.8 , 4704689.  , 5689927.  , 6297856.5 ,
         6535169.  , 6543583.  , 6543583.  ], dtype=float32)

For this to be a real verifiable example, I can transfer the 9GB file to someone or give instructions on how to download it from the climate API I'm getting it from! I'm not sure if this is an issue with xarray or the API or something I'm doing wrong. I've mostly been using an older version of xarray, but I also tested on the most recent version available on PIP:
Output of xr.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.9.6 (default, Jul  8 2021, 20:44:16)
[GCC 5.4.0 20160609]
python-bits: 64
OS: Linux
OS-release: 4.4.0-200-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: ('en_US', 'UTF-8')
libhdf5: 1.12.0
libnetcdf: 4.7.4
xarray: 0.18.2
pandas: 1.3.0
numpy: 1.21.0
scipy: None
netCDF4: 1.5.7
pydap: None
h5netcdf: 0.11.0
h5py: 3.3.0
Nio: None
zarr: None
cftime: 1.5.0
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: <IP_ADDRESS>
iris: None
bottleneck: None
dask: None
distributed: None
matplotlib: None
cartopy: None
seaborn: None
numbagg: None
pint: None
setuptools: 51.3.3
pip: 20.3.3
conda: None
pytest: None
IPython: 7.25.0
sphinx: None

A small question to clarify:

When the netCDF is unpacked using the nco command line tool, the correct values are unpacked.
$ xarray.open_dataset("BIG_FILE_unpacked.nc").ssrd.isel(time=slice(0, 23)).sel(latitude=44.8, longitude=287.1, method="nearest").values
> array([      0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
               0.        ,       0.        ,       0.        ,
           25651.61906215,<PHONE_NUMBER>522 , 1091757.933255  ,
         2170377.23235622, 3482363.69999847, 4704882.32554591,
         5689654.23783437, 6297785.304381  , 6534906.36839455,
         6543665.4578304 , 6543665.4578304 ])

Is that the output of the .open_dataset command? Is that the same code that generates the 2s? Or is the command that generates the zero different?

That example is actually a different file than the original. I unpacked the original file externally using ncpdq -U BIG_FILE_packed.nc BIG_FILE_unpacked.nc before opening it with xarray, so the decoding step is skipped and there aren't any 2 values generated. The data is correct using that method, so it's a possible workaround, but unpacking externally makes each file 4x larger.
In all the examples, the data is the same time and location, so they should be the same values outside of whatever is lost from compressing to int16 and decompressing, and the output arrays are from selecting a single day (24 hours) at a single location from the dataset returned by open_dataset in the ipython interpreter.
So actually there are three files I've tested with, all of which should have the same data (assuming the issue isn't with how the files are built, which could be the case): BIG_FILE_packed.nc BIG_FILE_unpacked.nc and SMALL_FILE_packed.nc, and the only one that displays the issue is the first one.

@ohsqueezy Does this issue also show up, if just plain netCDF4 is used to open the files?

Thanks. Does passing different values to engine= make any difference? I suspect the issue is at that layer.

Thanks for your help!
I checked using the netCDF4 module, and the data is returned correctly
$ d = netCDF4.Dataset("BIG_FILE_packed.nc")
$ d["ssrd"][d["time"][:] < d["time"][24], d["latitude"][:] == 44.8, d["longitude"][:] == 287.1]
> masked_array(
  data=[[[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[      0.        ]],
        [[  25651.61906215]],
        [[<PHONE_NUMBER>522 ]],
        [[1091757.933255  ]],
        [[2170377.23235622]],
        [[3482363.69999847]],
        [[4704882.32554591]],
        [[5689654.23783437]],
        [[6297785.304381  ]],
        [[6534906.36839455]],
        [[6543665.4578304 ]],
        [[6543665.4578304 ]],
        [[6543665.4578304 ]]],
  mask=False,
  fill_value=1e+20)

I tried with scipy as the engine, and it still returns the 2 values
$ xarray.open_dataset("BIG_FILE_packed.nc", engine="scipy").ssrd.sel(latitude=44.8, longitude=287.1, method="nearest").values[:23]
> array([2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
       2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
       2.000000e+00, 2.000000e+00, 2.000000e+00, 2.000000e+00,
       2.565200e+04, 3.547440e+05, 1.091760e+06, 2.170378e+06,
       3.482364e+06, 4.704884e+06, 5.689655e+06, 6.297786e+06,
       6.534908e+06, 6.543667e+06, 6.543667e+06], dtype=float32)

I should mention that in another large packed dataset from this API, I have gotten the same error but with a very small decimal value in place of the zero instead of 2.

@ohsqueezy You might also try engine="h5netcdf (h5py/h5netcdf packages needed). And would it be possible create a small subset of that file via netCDF4 to share?

h5netcdf seems to be a separate issue for me as it gives me the error
OSError: Unable to open file (file signature not found)

I looked into it once though, and I think I might be able to fix that. I'll also see if I can build a small netCDF that has reproducible behavior!

sure, no prob
$ xarray.open_dataset("BIG_FILE_packed.nc").ssrd.encoding
{'source': 'BIG_FILE_packed.nc',
 'original_shape': (743, 1801, 3600),
 'dtype': dtype('int16'),
 'missing_value': -32767,
 '_FillValue': -32767,
 'scale_factor':<PHONE_NUMBER>183389,
 'add_offset': 20500023.17537729}

This may just be the expected floating point error from using float32:
In [5]: import numpy as np

In [6]: -32766 * np.float32(625.6492454183389) + np.float32(20500023.17537729)
Out[6]: 1.2984619140625

If you use full float64, then the data does decode to 0.0:
In [7]: -32766 * np.float64(625.6492454183389) + np.float64(20500023.17537729)
Out[7]: 0.0

So the question then is why this ends up being decoded using float32 instead of float64, and if that logic should be adjusted or made customizable:
https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L225

That explains it to me! Not sure if it's still useful but I exported the subset as a netCDF file.
In [59]: packed_vals = xarray.open_dataset("packed_solar_data_subset.nc", mask_and_scale=False).ssrd.values

In [60]: packed_vals[0] * numpy.float32(e["scale_factor"]) + numpy.float32(e["add_offset"])
Out[60]: 2.0

In [61]: packed_vals[0] * numpy.float64(e["scale_factor"]) + numpy.float64(e["add_offset"])
Out[61]: 0.0

Hm actually I think converting the packed vals to 64 bit and then decoding does what I'm looking for
In [62]: xarray.decode_cf(xarray.open_dataset("packed_solar_data_subset.nc", mask_and_scale=False).astype(numpy.float64)).ssrd.values
Out[62]:
array([      0.        ,       0.        ,       0.        ,
             0.        ,       0.        ,       0.        ,
             0.        ,       0.        ,       0.        ,
             0.        ,       0.        ,       0.        ,
         25651.61906215,<PHONE_NUMBER>522 , 1091757.933255  ,
       2170377.23235622, 3482363.69999847, 4704882.32554591,
       5689654.23783437, 6297785.304381  , 6534906.36839455,
       6543665.4578304 , 6543665.4578304 ])

Thanks for sharing the subset netCDF file, that is very helpful for debugging indeed!
The weird thing is that the dtype picking logic seems to have a special case that, per the code comment, suggests we want to be using float64 here:
https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L231-L238
But in fact, the dtype picking logic doesn't do that, because the dtype is already converted into float32, first. The culprit seems to be this line in CFMaskCoder, which promotes the dtype to float32 to fit a fill-value of NaN:
https://github.com/pydata/xarray/blob/eea76733770be03e78a0834803291659136bca31/xarray/coding/variables.py#L202
To fix this, I think logic in _choose_float_dtype should be updated to look at encoding['dtype'] (if available) instead of dtype, in order to understand how the data was originally stored.

To fix this, I think logic in _choose_float_dtype should be updated to look at encoding['dtype'] (if available) instead of dtype, in order to understand how the data was originally stored.

This is aimed at in #7654

New attempt here: #8713

@ohsqueezy After #7654 going out of focus I've resurrected the changes in #8713. Would you mind taking a look there, maybe test and let us know your thoughts on that?


ADBDEV-6592: Treat S3 errors as query errors (#1097)

Treat S3 errors as query errors
It is possible for reader_cleanup and writer_cleanup to produce errors (via S3Exception), resulting in incorrect query completion. Errors in these functions should be treated as ERRORs, not WARNINGs.
However, we cannot throw ERRORs inside resource owner callbacks, so during an actual abort we still use WARNINGs. This shouldn't be an issue because such an abort should only occur in erroneous conditions anyway.
Tests are not presented, as there is no existing test infrastructure to make an auto test with S3 storage.
Ticket: ADBDEV-6588
(cherry picked from commit 31895ff2311706c93a0e1335e7ebb07c47789dd4)

Note: Do not squash to preserve authorship

Please write a scenario explaining how I can reproduce the problem and get these warnings: Failed to cleanup gpcloud extension... during export, import, and AbortCallback.

To reproduce: revert this patch to make the error reproducible and perform steps from this ticket. This should reproduce the export error. Import error is equivalent but with select instead of insert. Error in AbortCallback is harder to reproduce, you would have to pause the export before it enters destroyGpcloudResHandle (with a debugger or a new fault injector), and then abort the process (by causing a panic in a different session, for example)

After revert this patch. I still can't reproduce import scenario. @silent-observer  could you please provide scenario for import branch testing? I think we have to test this branch.
postgres=# DROP FOREIGN TABLE public.ext_s3_write_test;

CREATE WRITABLE EXTERNAL TABLE public.ext_s3_write_test (
    a int,
    b float,
    c text
)
LOCATION (
    's3://localhost:9000/retest-1/write_test.csv region=ru-central1 config=/home/den/s3/s3cfg.conf'
)
FORMAT 'CSV';
DROP FOREIGN TABLE
CREATE EXTERNAL TABLE
postgres=# INSERT INTO public.ext_s3_write_test
SELECT i, 1.11, 'one'
FROM generate_series(10, 20) AS i;
ERROR:  Failed to cleanup gpcloud extension: writer_cleanup caught a S3LogicError exception: AWS returns error InvalidRequest : You must specify at least one part, Function: completeMultiPart, File: src/s3interface.cpp(557). (gpcloud.cpp:229)  (seg0 <IP_ADDRESS>:7002 pid=195494) (gpcloud.cpp:229)
postgres=# SELECT * FROM public.ext_s3_write_test;
ERROR:  cannot read from a WRITABLE external table
HINT:  Create the table as READABLE instead.
postgres=# DROP FOREIGN TABLE public.ext_s3_read_test;

CREATE READABLE EXTERNAL TABLE public.ext_s3_read_test (
    a int,
    b float,
    c text
)
LOCATION (
    's3://localhost:9000/retest-1/write_test.csv region=ru-central1 config=/home/den/s3/s3cfg.conf'
)
FORMAT 'CSV';
DROP FOREIGN TABLE
CREATE EXTERNAL TABLE
postgres=# SELECT * FROM public.ext_s3_read_test;
 a  |  b   |  c
----+------+-----
 10 | 1.11 | one
 11 | 1.11 | one
 16 | 1.11 | one
 18 | 1.11 | one
 20 | 1.11 | one
 ...

Right, that patch only affects export, not import. For import there is no known reliable way to produce an error during the cleanup, but you can simulate that by adding something like throw new S3LogicError("Code", "Text"); into reader_cleanup() function which should simulate that code path.


OpTestCAPI: add new memcpy afu test KernelAPITest

Signed-off-by: Philippe Bergheaud<EMAIL_ADDRESS>

Can one of the admins verify this patch?

verified
(is that what I have to do? still figuring out the Jenkins magic)

retest this please


Typo in the generated XML file for training

When using createTrainingXXX, with papers where a middle name is present in the authors' names, the generated XML file shows "XXX.", with the dot after the closing tag.

Yes this is working as expected. Punctuations are left outside the tagged spans as guidelines.


Task/create proxy mappers

This handles the initial state of adding proxy mapping - further mappers are very simple, though I'd like to make them even simpler.
Depends on #167

Superceded by #169


twint-zero is not Working!!!

I just tried this tool today after i tried like a week ago. But this time after running go run main.go -Query $QUERY ,it is not returning any output in terminal , just pauses for like 2 seconds then prints nothing.

Does this problem have anything to do with what twitter is trying to do like maybe stop scraping ?

Hello @avisekksarma ,
as you may be aware of the recent news, there are some issues regarding accessing Twitter feeds for non-auth users.
The situation is being monitored and we hope it'll be restored as soon as possible.
FP

The issue is partially resolved. Now we are able to get tweets however the time-frame is very limited to the most recent days.


DFBUGS-850: Reflect cephrbd image health in VR and VRG status

Backport of three commits for improving the reported condition. All commits are part of the release-4.18 branch already.
/cc Madhu-1 Rakshith-R yati1998

@nixpanic @yati1998 is this required for 4.17?

@nixpanic @yati1998 is this required for 4.17?

That is what DFBUGS-850 requests. It helps with troubleshooting, and therefor improved the supportability and user experience.

/jira refresh


Linting OCSP responses

In this bug, Apple shared a very thorough list of lints they apply to OCSP responses from their own issuance infrastructure. It would be useful to implement these in an open-source linter. Are the folks here interested in incorporating an OCSP linter into zlint? Do you think it would be better as a separate project?

This came up once in the past #382. I think the consensus is: Yes! We'd love to have them, but we should structure their addition that they don't make running or maintaining existing certificate lints more difficult.

I think this fits into our sets of lints nicely, we could even exclude OCSP/CRL lints by default.

+1 for being able to linting CRLs too

+1 for being able to linting CRLs too

Hi Maintainers,
I would be happy to work on implementing OCSP linting. The question is:

Given that CAB Forum has made OCSP optional in v2.0.1 (SC63)
Please let me know. We're planning to implement something internally which we can think of contribute to zlint.
Let me know if there is interest?


libaio package missing with latest <IP_ADDRESS> OracleFMWInfrastructure dockerfiles

Issue:
When we built OracleBI <IP_ADDRESS> image with latest <IP_ADDRESS> OracleFMWInfrastructure dockerfiles,
system components did not start as libnqcsfwrapper.so could not load. This was because of dependent libaio.so.1 was not present.
Analysis:
After debug we found that initially libaio which was being shipped with OracleFMWInfrastructure  <IP_ADDRESS> image is missing with latest dockerfiles.
Root Cause:
When multistage build was implemented to  Shrink the image size, install of libaio was done in intermediate first build and was not installed with final build. Hence libaio is missing in final <IP_ADDRESS> OracleFMWInfrastructure image.
Dockerfile details:
libaio installed in intermediate step of build:  https://github.com/oracle/docker-images/blob/1714789336409f66b4027ee1c11a860ad13d196b/OracleFMWInfrastructure/dockerfiles/<IP_ADDRESS>/Dockerfile#L59
But not present with final build: https://github.com/oracle/docker-images/blob/1714789336409f66b4027ee1c11a860ad13d196b/OracleFMWInfrastructure/dockerfiles/<IP_ADDRESS>/Dockerfile#L88

I believe @mriccell is already aware of this.

Fixed by #1293.


Kit's Drawing Snapshot

Hey Natalie here, can you invite me on Google Hangouts and give me your email address? Is it possible to start around 11:10am today?

Merged!


fix: flamegraph script issue

Flamegraph script failed to handle PrivateFPC contract as it incorrectly formatted the artifact name. This PR fixes it.

#7886  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 2,773 (+21%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,799
1,562
709
746 (-1%)
765

proof_construction_time_sha256_30_ms
11,895
3,182
1,408
1,445 (+1%)
1,483 (+1%)

proof_construction_time_sha256_100_ms
44,452
12,503
5,665 (-1%)
5,550
5,498

proof_construction_time_poseidon_hash_ms
79.0
34.0
35.0 (+3%)
59.0 (+2%)
88.0 (+1%)

proof_construction_time_poseidon_hash_30_ms
1,543
421
202
226 (-3%)
268

proof_construction_time_poseidon_hash_100_ms
5,688
1,536
681 (+1%)
742 (+1%)
754 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,324
7,844
14,852

l1_rollup_calldata_gas
49,696
92,458
177,440

l1_rollup_execution_gas
1,292,215
2,039,945
3,866,966

l2_block_processing_time_in_ms
251 (+2%)
443
805 (+2%)

l2_block_building_time_in_ms
9,576
18,873
37,247 (-1%)

l2_block_rollup_simulation_time_in_ms
9,575
18,873
37,246 (-1%)

l2_block_public_tx_process_time_in_ms
7,976
16,994 (-1%)
35,356 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,911 (-3%)
3,942 (+3%)

node_database_size_in_bytes
12,718,160
16,937,040

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
95.0 (+1%)
8,139

FeeJuice:set_portal
12.3 (+23%)
2,362

Token:constructor
124 (+1%)
31,107

FPC:constructor
105 (+10%)
22,380

FeeJuice:mint_public
80.6 (+3%)
6,150

Token:mint_public
84.6 (-10%)
11,720

Token:assert_minter_and_mint
90.6 (+12%)
8,028

AuthRegistry:set_authorized
9.71 (-5%)
4,537

FPC:prepare_fee
304 (+1%)
8,812

Token:transfer_public
33.9 (-6%)
47,374

FPC:pay_refund
66.6 (+8%)
12,114

Benchmarking:increment_balance
1,022
7,450

Token:_increase_public_balance
9.69 (-7%)
8,960

FPC:pay_refund_with_shielded_rebate
140 (+2%)
12,663

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.166 (+3%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.19 (+4%)
3.95 (+3%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.113 (+3%)
0.112 (+3%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.5 (+2%)
18.3 (+5%)
31.0 (+1%)
59.3 (-4%)
113 (+1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.110 (+1%)
0.105 (+4%)
0.101 (+1%)
0.102 (-3%)
0.101

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.4
26.0 (+3%)
43.8 (+1%)
83.0 (-2%)
162 (+2%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109
0.105 (+2%)
0.102 (-4%)
0.103 (-2%)
0.103 (+3%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.5 (+2%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106 (+1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,756
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Update kind-projector to 0.13.2

Updates org.typelevel:kind-projector from 0.13.0 to 0.13.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kind-projector" } ]

labels: library-update, semver-patch

Superseded by #76.


Fix layout with sixel image backend

Problem
With sixel image backend, unnecessary +2 on cursor up CSI sequence causes misalignment between image and text:

while +2 keeps alignment on terminal in fullscreen mode:

How to fix

remove unnecessary +2 for terminal not in fullscreen mode
fix row number calculation for terminal in fullscreen mode

Screenshots of the fixed version
not in fullscreen mode

in fullscreen mode

Environment

onefetch runs on Ubuntu 20.04
mlterm runs on Windows 10

Both the previous version and your fixed version have the same (correct) alignment on my end (mlterm on NixOS).
I don't remember the exact reason I added 2 lines to the vertical movement, I tried a lot of offsets and those looked correct everywhere I tried.
You're right that removing it makes more sense mathematically, and it still works, so that seems fine.
I'm not sure what was wrong with the ratio calculations, I can only guess that there were rounding errors that I haven't encountered.


authz: fix the presence match in v1beta1 policy

For #12394
In v1beta1 policy, "*" means presence match for non-empty values, change to use regex .+ instead of .*. Also added e2e tests to cover this.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test gencheck_istio

integ-new-install-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test gencheck_istio

integ-new-install-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-new-install-k8s-tests_istio

integ-security-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-new-install-k8s-tests_istio

e2e-simpleTests-cni_istio
0a325ebd48bd0e1f6ef9debfd867aa1baf2e768f
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

A high level question, so in v1alpha1 * means anything including empty, but in v1beta1 we're changing it to anything except empty? If so, we may need to change it in the converter as well.

A high level question, so in v1alpha1 * means anything including empty, but in v1beta1 we're changing it to anything except empty? If so, we may need to change it in the converter as well.

Yes, the semantic is different and we need to handle it carefully in the converter. cc @liminw

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-new-install-k8s-tests_istio

integ-istioio-k8s-tests_istio
0a325ebd48bd0e1f6ef9debfd867aa1baf2e768f
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7c1a6f2c972ac6668f8feda07be99ea756e7ea7d
link
/test integ-new-install-k8s-tests_istio

integ-istioio-k8s-tests_istio
0a325ebd48bd0e1f6ef9debfd867aa1baf2e768f
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0a325ebd48bd0e1f6ef9debfd867aa1baf2e768f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

@pitlv2109 @liminw @diemtvu Added more unit tests and fixed naming, PTAL, thanks.

/lgtm if the test in https://github.com/istio/istio/pull/18316#discussion_r340313108 has been covered.
I'm not one of the maintainers so my approval won't do much.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
106d920b1a6a3593023fbcd8211660dc513c5909
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio

In response to a cherrypick label: new pull request created: #18462


Extension Menu Blowout

Check out, how on smaller viewport, the Browser Window menu is blownout. Notice the excess padding to the left and bottom?

Hi @grand-lotus-iroh, thanks for reaching out about an issue! This repo is for tracking new ideas/explainers from the Microsoft Edge team. If you're experiencing an issue in Dev or Canary builds of Microsoft Edge, would you mind filing these via the "Send feedback" button in the browser UI? That will ensure that your issue doesn't get lost. Thank you!


added account_deposit command which is able to deposit time locked transaction into wallet

fixes #3553

Coverage increased (+0.02%) to 71.618% when pulling 84ef52cf4d12a442a451bb1c557497b5a62856ae on spend_time_locked into 8cdcd770c0530fb854a470ac610f8865c8e12a1b on master.


title text isn't centered (at least on iPhone X)

Open Shrine on iPhone X and notice the title text isn't centered. The word SHRINE should be directly below the notch, centered.

I'm not sure if this is a generic issue with framework, or something with iPhone X.
cc @cbracken

Thanks! Did some looking and the Contacts and other demos look right. This looks specific to the Shrine demo, which uses a lot of customisation. Tested on a few other devices and it doesn't look specific to the iPhone X.
I've got a couple last Gallery cleanups; I'll take a look at this at the same time.

Thanks for taking a look!

Looks like this is also the case for Android actually. Fix out in #13586.

Fixed.

Wow, thank you! That was fast :)


Issue #5: Test CI/CD workflow

This is a basic workflow that will create a website on Github pages. This can be tested only on the master branch of the main repository as ACTIONS_DEPLOY_ACCESS_TOKEN would work on the master repository only.

package-lock.json is created since this is being tested in npm.


Feature Request: Adjust the sensitivty when the FOV changes ingame

Most games lower the sensitivity of aiming when you look down sights or zoom in, but I've noticed that KAMI doesn't do that. Based on how I imagine mouse injection works, that is to be expected, but it would be nice if I had some way to lower the sensitivity without pausing whenever I want to snipe something.

I have plans to take this in another direction, but it requires some ground work. My idea is to scale the sensitivity based on the FOV of the game, so that moving the mouse a certain distance always moves it ingame by a set amount of "pixels" no matter how zoomed in you are.

Yeah, that's a certainly a better idea.


Roll engine 21ae92651a38..3e10d92b2bbb (7 commits)

git@github.com:flutter/engine.git/compare/21ae92651a38...3e10d92b2bbb
git log 21ae92651a38..3e10d92b2bbb --no-merges --oneline
2019-08-19<EMAIL_ADDRESS>Roll src/third_party/dart 0e201edeeb..9f13d07670 (27 commits)
2019-08-19<EMAIL_ADDRESS>Notify framework to clear input connection when app is backgrounded (#35054) (flutter/engine#9498)
2019-08-19<EMAIL_ADDRESS>Re-enable firebase test and don't use google login (flutter/engine#11228)
2019-08-19<EMAIL_ADDRESS>Update tflite_native and language_model revisions to match the Dart SDK (flutter/engine#11230)
2019-08-19<EMAIL_ADDRESS>Roll src/third_party/skia f8221786d088..8566dda51b42 (4 commits) (flutter/engine#11220)
2019-08-19<EMAIL_ADDRESS>Update metal layer drawable size on relayout. (flutter/engine#11224)
2019-08-19<EMAIL_ADDRESS>Make firebase testlab always pass (flutter/engine#11226)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Change the LINK token to version 0.4

Version 0.6 of the LINK token imports openzeppelin contracts, which can cause conflicts when others want to use OZ packages.
Default to the mock contract using v0.4 of solidity to avoid collision

Fixed via https://github.com/smartcontractkit/hardhat-starter-kit/pull/42


Change position to select when we click on the status bar options

VSCode Version: 1.14.0 - Insiders (6afdf30 - Date 2017-07-05T08:33:33.146Z )
OS Version: Windows 10

-- Sorry for the English, I used Google Translator --
One suggestion would be that when we click on the options that exist in the status bar, it will appear next to it.

That would be only when we clicked there. If we used the Command Palette it would work the way the current form does.
As for the search bar I would vote for being at the bottom (different from how the images are) next to the own status bar.

Reproduces without extensions: Yes

Makes sense, we have https://github.com/Microsoft/vscode/issues/29193 however already for it.

@bpasero Oh! Thank you! 😄

@bpasero
Actually, it is more like my idea, not yours...
https://github.com/Microsoft/vscode/issues/26596


[AUTOPATCHER-CORE] Upgrade fluent-bit to 2.2.3 to fix CVE-2024-4323

[AUTOPATCHER-CORE] Upgrade fluent-bit to 2.2.3 CVE-2024-4323
Upgrade pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=576960&view=results

CVE-2024-4323 is fixed in this commit of the 2.2.3 version

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/9237

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=577398&view=results


Ensure custom header values are strings

Ensure all custom header values are strings, as required by Requests.

On second thoughts, there are too many unknowns here. A third-party could (for example) pass in a value which cannot be properly cast to a string. It's the responsibility of the client code to provide valid custom header values.
Closing.


Make sure dispatch can be called multiple times per-tick

Mostly fixes #1206
Test plan (required)
I've added tests:

To validate the dispatch => true/false return value behaviour is retained
dispatch functions normally, updating the state by the next tick
The change to dispatch works, allowing 2 calls to dispatch to work in the same tick without throwing away data

react-test-runner applies setState synchronously instad of waiting for the next tick like React normally does so the test file makes sure to inject a batching strategy that applies setState when jest.runOnlyPendingTimers(); is called
The test also verifies that state has not been updated synchronously immediately after the dispatch call to ensure that  jest committing setState synchronously does not result in a falsely passing test

Test failure appears to be due to pre-existing issues with the flow types

CC: @ericvicenti

What's the status of this, @dantman?

@Jacse Waiting for anyone to re-review it. I made all the requested changes and since then no-one has bothered to review it.

Looking forward to this as well.

@dantman I think I have a better solution to this problem. Your solution can handle two dispatches fired in a row. In my solution I am not relying on componentDidUpdate to detect when setState has completed. I am queuing all action request and dispatch them on setState callback. This way we can handle multiple dispatches fired in a row without worrying about losing data and besides this I also fixed the Transitioner in the same way. The Transitioner was able to queue only one transition but even that was flawed with reset action followed by a setParams for example..

@rpopovici

This solution isn't limited to 2 dispatches in a row, it can handle an infinite number of them.
This solution does not rely on componentDidUpdate to work, the componentDidUpdate is just a bit of housekeeping. The code would still work even if you deleted that, all the logic is in dispatch.

@dantman my bad, now I understand how it works. Still, I don't think it's a good way to do it like this because you are not waiting for setState to finish. setState is async per React docs https://facebook.github.io/react/docs/react-component.html#setstate and it should not be called in a synchronous manner even if you can predict the next state. You are assuming that everything will work correctly, but you don't know how React is going to change in the future and this approach might not work anymore

@rpopovici
Firstly a side note: IMHO #2400 doesn't do it right either, waiting for setState like that is problematic in 2 ways.

Firstly you can already write dispatch + wait a tick + dispatch on your own (setImmediate), when a developer calls dispatch + dispatch intentionally in the same tick all dispatches should be resolved in the same tick, not run one by one waiting for a tick to pass and transition to finish.
Secondly you double the react updates (the setState callback is "guaranteed to fire after the update has been applied", so by waiting for it and making another setState call you now guarantee that even if you write multiple dispatches in the same tick, every single one of them will trigger a separate renderer update by React instead of allowing react to optimize those calls into one update.

Still, I don't think it's a good way to do it like this because you are not waiting for setState to finish. setState is async per React docs https://facebook.github.io/react/docs/react-component.html#setstate and it should not be called in a synchronous manner even if you can predict the next state. You are assuming that everything will work correctly, but you don't know how React is going to change in the future and this approach might not work anymore

React isn't going to break this, if they did it would fundamentally break react in normal usage.
The documentation you quote explicitly states:

Subsequent calls will override values from previous calls in the same cycle, so the quantity will only be incremented once.

The async nature of setState only means that you cannot access changes in this.state until the next tick and need either a 2nd source of truth or the updater function.
If react were to change this, it would mean that this.setState({a: 1}); this.setState({a: 2}); might sometime set the state to {a: 1} instead of{a: 2}. That would fundamentally break react.
And even if you were so paranoid that react would do that, I could just refactor it so all dispatches are batched into one setState call.

I could easily have wrote this commit without this._nav. In fact that is what I wrote originally looked like. And with a few lines of code I could easily change it back to that. You do not need a queue array, to wait a tick for setState, or have a separate queueDispatch method, you just use the updater function.
The reason I used _nav instead is because getStateForAction needs to be resolved in the same tick to return success/failure. And none of the alternatives (promise, callback, error event, etc...) were worth the breaking change and redux breakage when you can do the change without them.

@dantman OK, I will try your approach to see if it's working for my project and cancel my PR if everything works fine

@dantman you should rebase this PR against master. There are lots of changes since you open it

@rpopovici I tried doing that before I added that test for 5 dispatches.
Unfortunately react-navigation no longer runs under react-test-renderer. So when someone finally comes around to review this change I'll have to ask them whether they want me to just delete the tests or come up with a way to do on-device tests.
That's also how I ran into #2406.
That aside rebasing is trivial. The only merge conflict comes from a formatting change where this._onNavigationStateChange(state.nav, nav, action)); was changed so ); is on the next line.

Hi any chance someone can review this ? @matthamil I see that you are the currently assigned reviewer, do you have time to follow up on your previous review ?
Would be great to get this contribution merged, thanks in advance.

enzyme is a dead end, it won't actually work with React Native (https://github.com/airbnb/enzyme/issues/928) and the mock it depends on doesn't support react@16 either.
I looked more at react-test-renderer and it should be possible to get it to work at some point. However we're affected by some bugs in the test setup. We have to wait till this commit is released in the next version of RN (v0.49.0) and we'll have to update react-navigation's devDeps/example to that. The other caveat is that the ReactUpdates mocking to mock the timers may need to be replaced with something equivalent for react@16.

Hey @dantman I'd love to take a shot and review this to merge it. It looks like there is a conflicting file, can you please update the PR?

@kelset The merge conflict is a minor whitespace change, the code is the same so the functionality is the same.
Is react-navigation going to upgrade the dev deps to react-native 0.49? I need that to be able to update the tests when I rebase. Changes in react-native between when I wrote the commit and now switched to versions of react-native where react's test renderer was broken.

Ok thanks for the clarification - yeah tbh I want to update the lib to the new versions of the deps; I'm a bit afraid something will break, tbh.
@spencercarli @skevy what do you think?

Hey @dantman we finally upgraded to 0.49 & flow 0.53 so I think this PR can be unlocked now, right?

@dantman may I ask you to resolve the conflicts? Thank you.

It was tricky to get async setState working again for the tests, but I think I got it sorted out.

Thanks @dantman for the write up in https://github.com/react-community/react-navigation/issues/1206#issuecomment-298149588 and the consequent PR. I tested this and it looks good to me so I'm (finally) merging. Thanks again!!

Awesome, thanks @dantman !!! 🚀


DBZ-6957 Remove spaces in Signal and Notification JMX ObjectName

closes: https://issues.redhat.com/browse/DBZ-6957

Applied to main (=2.4) and branch 2.3.


Don't memoize so much

Working on fixing https://github.com/hammerlab/varcode/issues/156, this doesn't clean up everything but it's a start.

This change is

Coverage decreased (-0.6%) to 87.462% when pulling de66cbd86252795ec4e7012a9ebd3609a7add1f4 on less-memoization into 0f23586004e6b4931866c5d10b077b46cc048336 on master.

Coverage decreased (-0.03%) to 87.994% when pulling de66cbd86252795ec4e7012a9ebd3609a7add1f4 on less-memoization into 0f23586004e6b4931866c5d10b077b46cc048336 on master.

Coverage decreased (-0.03%) to 87.994% when pulling bc218c915c7f4c4a49c66abbff67c6fd0a312f7e on less-memoization into 0f23586004e6b4931866c5d10b077b46cc048336 on master.

@timodonnell: OK to merge?

yup LGTM


Write tests

Test files already made, nothing in them.
I suggest using pytest to write them. Can use coverage as well.

+1 to this, I actually have pytest-cov as a dev-dependency

[X] twitter.py
[ ] storage.py


Compiler panic for unknown reasons - 0.53.0, sway-ir

forc --version
forc 0.53.0
Example code and repository branch
contract;

use std::{
    execution::run_external,
    constants::ZERO_B256,
    string::String,
    call_frames::first_param,
    hash::Hash,
    hash::sha256,
};
use src_20::SRC20;
use contract_message_receiver::MessageReceiver;
use interface::{bridge::Bridge, src7::{Metadata, SRC7}};

configurable {
    TARGET: ContractId = ContractId::from(ZERO_B256)
}

// Inspired by EIP-2535: Diamonds, Multifacet proxy
storage {
    facets: StorageMap<u64, ContractId> = StorageMap {},
}

abi Diamonds {
    #[storage(read,write)]
    fn set_facet_for_selector(method_selector: u64, facet: ContractId);
}

impl Diamonds for Contract {
    #[storage(read,write)]
    fn set_facet_for_selector(method_selector: u64, facet: ContractId) {
        storage.facets.insert(method_selector, facet);
    }
}

#[fallback, storage(read)]
fn fallback() -> Option<ContractId> {
    let method_selector = first_param();

    storage.facets.get(method_selector).try_read()
}

impl Bridge for Contract {
    #[storage(read, write)]
    fn claim_refund(from: b256, token_address: b256, token_id: b256) {
        run_external(TARGET)
    }

    #[payable]
    #[storage(read, write)]
    fn withdraw(to: b256) {
        run_external(TARGET)
    }

    #[storage(read)]
    fn bridged_token_gateway() -> b256 {
        run_external(TARGET)
    }

    #[storage(read)]
    fn asset_to_sub_id(asset_id: AssetId) -> SubId {
        run_external(TARGET)
    }

    #[storage(read)]
    fn asset_to_l1_address(asset_id: AssetId) -> b256 {
        run_external(TARGET)
    }

    fn double_value(foo: u64) -> u64 {
        run_external(TARGET)
    }
}

impl MessageReceiver for Contract {
    #[payable]
    #[storage(read, write)]
    fn process_message(msg_idx: u64) {
        run_external(TARGET)
    }
}

// // Uncomment this and compiler fails

// impl SRC20 for Contract {
//     #[storage(read)]
//     fn total_assets() -> u64 {
//         run_external(TARGET)
//     }

//     #[storage(read)]
//     fn total_supply(asset: AssetId) -> Option<u64> {
//         run_external(TARGET)
//     }

//     #[storage(read)]
//     fn name(asset: AssetId) -> Option<String> {
//         run_external(TARGET)
//     }

//     #[storage(read)]
//     fn symbol(asset: AssetId) -> Option<String> {
//         run_external(TARGET)
//     }

//     #[storage(read)]
//     fn decimals(asset: AssetId) -> Option<u8> {
//         run_external(TARGET)
//     }
// }

I tried to add the SRC20 library from the sway standards repo. When I uncomment the lines related to impl SRC20 for Contract, I get the following error:
forc build
warning
 --> /Users/mad/fuel/bridge/packages/fungible-token/bridge-fungible-token/interface/src/src7.sw:5:10
  |
3 |
4 |
5 | pub enum Metadata {
  |          -------- This enum is never used.
6 |     B256: b256,
7 |     Bytes: Bytes,
  |
____

  Compiled library "interface" with 1 warning.
thread 'main' panicked at sway-ir/src/constant.rs:172:14:
Enums are aggregates.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I can't reproduce this.
Compiling on that branch, with either 0.53.0 or master works without issue.


Align the release tags with the version of the Guidelines document

@dslmeinte suggested

I think I'd be useful to tag releases with the version number of the value set update (e.g. vs-1.5 for the latest) as well. That way it's clearer that e.g. a 2.4.0 release only add this versioning process, but doesn't correspond to an update of the eHN value set. (Same goes for other purely technical/process-related changes to this repo.)
https://github.com/ehn-dcc-development/ehn-dcc-valuesets/pull/33#issuecomment-971463706

@dslmeinte @kruzikh @ryanbnl I moved the discussion here so we could merge the PR and still keep track of the task. The comment in the PR may be lost after we finish with PR.

We currently have 1.x tag not schematically related to the version of the Guidelines document.
@dslmeinte My understanding is that you are suggestion a parallel tagging policy with a prefix.
Since the history is not actually relevant nor there is any system depending on past releases I sense it is safe to

Introduce a new model
Keep the old model live for a certain amount of time and kill it when it will become completely irrelevant

I'm in favor of the vX.X.X pattern which was not use so far which is broadly used. Since it does not collide with the existing versions I would suggest to go with it and mark/tag the versions

v1.5.0 - https://github.com/ehn-dcc-development/ehn-dcc-valuesets/releases/tag/2.3.0
v1.4.0 - https://github.com/ehn-dcc-development/ehn-dcc-valuesets/releases/tag/2.2.0
v1.3.0 - https://github.com/ehn-dcc-development/ehn-dcc-valuesets/releases/tag/2.1.0
v1.2.0 - https://github.com/ehn-dcc-development/ehn-dcc-valuesets/releases/tag/2.0.0

It's not clear which releases correspond to the document 1.1 and 1.0

@skounis Indeed: parallel tagging. I do this for CertLogic as well: there are tags for versions of the specification, tags for versions of the JavaScript implementation, and likewise for Kotlin, and Dart.

In this case I sense that the vX.X.X pattern, e.g. v1.5.0 will be a bit misleading. It could be perceived as the semver of the code, something that is not correct. For example the version 1.6.0 of the guidelines may introduces changes in the schema that will force us to go up to 3.x due to API changes.
What the vs- prefix stands for?

Use rather sgs or SGS for Subgroup on Semantics - this is widely being used and understood by many.

@dslmeinte @kruzikh @ryanbnl Should we go with the prefix sgs- so we have sgs-1.5.0, sgs-1.4.0 etc.?

@skounis What about dcc-vs-1.5.0? Specifying rather DCC Value Set guidelines version rather than its source.

the repository is already about the DCC Valuesets. The scope of this parallel tagging is to link the releases with the version of the Guidelines Document. So I would be in favor of something the reflects this.

I added tags for versions 1.2 through to 1.5 of (updates to) the value set document.

Closed as I believe that this was either completed or abandoned.

We've adopted this, and are tagging releases with the version of the guidelines document.


Update advanced-features-windows-defender-advanced-threat-protection.md

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/2743
Added note to Skype for business integration.

@mjcaparas - can you please assist to check, approve and merge the content for this PR based on issue #2743?
Thank you.


Add support for k8s 1.13 and introduce releases

With adding support for k8s 1.13, k-d-c will switch to using GitHub releases
instead of fixed/ script. Each released script will be pinned to its particular
image tagged with commit id and k8s version, and with added SHA256
digest, so issues with script-image mismatch will no longer happen.
It's also possible to use images produced for non-released commits
by means of setting DIND_COMMIT=kdc_commit_id_for_your_copy_of_dind_cluster_sh.
The release is to be made after this PR  is merged. Also, fixed/ directory
will be updated from the release for backward compatibility (this will be
happening with each release for a while).
The solution is more or less outlined in this comment:
https://github.com/kubernetes-sigs/kubeadm-dind-cluster/issues/255#issuecomment-442415465
except that tag/branch names aren't used for image tagging, just commit & k8s version.
This PR also introduces auto-generated test matrix for CI and improves the handling of mounts in control plane pods for k8s 1.11+.
Fixes #262
Fixes #255

/lgtm

Thanks for the fix! Though one thing: the link mentioned in README.md https://github.com/kubernetes-sigs/kubeadm-dind-cluster/releases/download/v0.1.0/dind-cluster-v1.13.sh gives 404

@kkimdev right now there'll be short transitional period (2-3h) after which the release will happen
and fixed/ directory will be re-populated. The link will become live once the release workflow
completes on CircleCI, if all goes well https://circleci.com/workflow-run/ae8b678d-5e4b-474f-94a6-3fbe89016126

@ivan4th Oh I see.  Thanks!!


Backdrop flickering after upgrading from 2.3.0 to 2.3.1

Please fill out this template appropriately when filing a bug report.
Please remove this line and everything above it before submitting.

Description
After upgrading from 2.3.0 to 2.3.1 there is a flickering effect when the backdrop is dimmed.
This is a video from 2.3.1
https://user-images.githubusercontent.com/6479433/119173355-7149ec80-ba67-11eb-8b95-50d31f4cd8a4.MP4
And this is how it looks after downgrading to 2.3.0
https://user-images.githubusercontent.com/6479433/119173412-8888da00-ba67-11eb-91f9-6c215e80fd97.MP4
Steps to reproduce
Code example that reproduces the issue
How do you display panel(s)?
I present it modally
How many panels do you displays?
1
Library version
2.3.1
Installation method
Swift Package Manager

Oh, i'm really sorry it's a regression in 2.3.1. Thanks for your quick report. I would like to fix this ASAP but I can't reproduce it. Could give more information about your implementation, or give me a sample code to reproduce it?

I might have found the cause of this issue. So I created a patch in iss-466 branch. It would be helpful if you could try the branch.

Thanks... Sorry for not being responsive and providing you with details. Have had a super busy week. Thanks for all the hard work you put into this.

No problem, @sipersso :) I'm ok whenever you can.

Finally had a chance to try out the branch and can confirm that the iss-466 branch fixes the issue. Great job!

@sipersso Thank you so much! I've merged the patch into master. I will release v2.4.0 later.

Glad I could help! @scenee


Don't warn when ip_local_port_range not found

This warning is alarming to users and is really more debug level.
Since when the file is not found (or when it can't be read for some
reason) docker will just fallback to the default port range anyway, set
to debug level.
Also changes log.Error to log.Warn when there is a problem reading
the file for whatever reason.

LGTM

Think the title of the PR should be "Don't warn..."?

LGTM

Waiting for CI to merge.

Hmm, I'm -1 on Debugf. "just fallback" can lead to totally unexpected port-ranges.

How is it unexpected? It's the range Docker has always used.

I'm removing the milestone so we can discuss

@cpuguy83 But now it's not. So we'll write in changelog that now we use ip_local_range by default and silently ignore if default fails.

Ok, I updated to revert to old warn/error behavior, but improved messages, PTAL.

Ok, updated again, hopefully the last time.

LGTM
@jfrazelle PTAL

LGTM

This is for 1.6.0 right

@jfrazelle Ideally since the warning is a bit scary atm (and not in 1.5).

cool I cherry-picked it in :D
On Mon, Mar 23, 2015 at 2:23 PM, Brian Goff<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle Ideally since the warning is a
bit scary atm (and not in 1.5).
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11545#issuecomment-85203969.


Publish and consume OptProf data under new casing

We should

[x] ensure publication of OptProf profiles uses the new canonicalized microsoft/msbuild name
[x] back out #4719

A note to my future self:
Directly related to .vsts-dotnet.yml. Currently, setting RepositoryName to Build.Repository.Name sets it to Microsoft/msbuild, which no longer works because it should be microsoft/msbuild
Running (internally)
drop list --dropservice "https://devdiv.artifacts.visualstudio.com" --pathPrefixFilter "OptimizationData/Microsoft/msbuild/master" --toJsonFile "...\temp\someJsonFile.json"

I think I accidentally fixed this while trying to get a couple of things going last week @BenVillalobos. Can you just verify that everything is flowing well for master optprof collection and builds?

Both master and vs16.4 are building properly.


Add profile binary to dev image

Why tensorflow/core/profiler:profiler was not added at least in dev images?
I.e. for the gpu one:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/docker/Dockerfile.devel-gpu#L103

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@tensorflowbutler is a bot and won't respond. You should fill out the template, as @tensorflowbutler suggested, to get a response.

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

In this case, it's purely bureaucratic. We have an internal list of issues that we need to respond to, and issues only appear if the template is filled out. We do this because most of the time, the template info is useful, and people still tend not to fill it out even when it is useful.
/CC @gunan, can you take a look at this issue?

The exclusion of the binary is mostly a size optimization.
@martinwicke wdyt?

Probably for the non-dev one we could at least complete the docs on high level api cases https://github.com/tensorflow/tensorflow/issues/18732

Sure, but that's independent of the docker image, right?

Yes but could be a valid runtime solution. Generally my evaluation is that the non dev image could be a little bit more related to hight level APi users than the devel one. So if we finally exclude perf from not dev images we can let at least a complete solution with the docs coverage completion.

Nagging Assignee @gunan: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @gunan: It has been 32 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @gunan: It has been 47 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@martinwicke I know that with this comment I will reset the Nagging Assignee counting days stats but if this has a low priority can you prioritize https://github.com/tensorflow/tensorflow/issues/18732 so that beginners will have a quick path to profile theirs high level API models?

Nagging Assignee @gunan: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I've recently proposed a change to TensorFlow that obsoletes parameterized_docker_build.sh, which may help alleviate this issue. If anyone following this thread is interested in making TensorFlow's Dockerfile story better for everyone, please take a look at the RFC.

Nagging Assignee @angersson: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @angersson: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I think this is no longer relevant, since we have new docker images now. If it still is a problem, please comment again.


Bug in logging the key setting message

When republishing the keys the key object is a digest, not a string
so it cannot be printed
Do not log the key or values because they may not be printable
Remove the digest from the set

With this change the client is required to perform the hash of the key if desired. The problem with the previous code is that the hashed key would get rehashed if the keys were republished.

I think this has now been fixed in e58c710 - feel free to reopen an issue or PR if not.  Thanks, and great catch!


Bug problem on the console with Loot Sheet 5e module

Foundry v10.291
System dnd5e   2.2.1
Let's Trade   0.6.0
Loot Sheet 5e   5.0.6
The console gives me the following error, when I have Loot Sheet 5e and Let's trade active.

I don't know what it could be due to, or how it affects .... but I'm opening the thread in case it's a bug of relevance or easy to fix.

ok, I just saw that it is not compatible with loot sheet 5e.... and that it doesn't make sense either, because there is no exchange, as there is a sale.
I close the threat.


Exclude chore from changelog

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.074%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
1250

Relevant Lines:
2116

💛  - Coveralls


Build runtime images and run tests in parallel

By using a Container Builder pipeline, we can reduce our test time from ~37 minutes to ~24 minutes (on CircleCI. The e2e test takes ~12 minutes by itself).
The main cloudbuild.yaml now builds the test runner, php-base image, php-onbuild image, and the gen-dockerfile builder.
Each of these images' tests are also run as soon as their respective image is built.

Parallelizing the build uncovered an race condition using the structure_test image in parallel. https://github.com/GoogleCloudPlatform/runtimes-common/pull/169

We can also run the end to end test in parallel with other tests if it always runs. It's currently possible to skip the e2e tests, but both circle and our release builder are configured to run them.

@tmatsuo can you take a look at the last few changes since the merge from master. Switched to using the Symfony Console CommandTester.

LGTM

Oh wait. Do we need to change builder/php-latest.yaml?

I left the base image as the first argument and made the workspace an option.


HHH-10230 HHH-10729 HHH-9021 HHH-10861 - Fix Issue with literals in select expression

https://hibernate.atlassian.net/browse/HHH-10230
https://hibernate.atlassian.net/browse/HHH-10729
https://hibernate.atlassian.net/browse/HHH-9021
https://hibernate.atlassian.net/browse/HHH-10861

Looks good.

applied


Use proper defaults for Q-Ctrl path

What is the expected feature or enhancement?
Similar to #1048, proper defaults should be used when Q-Ctrl strategy is selected, so that users don't get any warnings/errors when using the default settings on the Q-Ctrl path.
Acceptance criteria
Proper defaults are set when using Q-Ctrl strategy.
@eginez, do you mind taking on this one? Since you know what would pass validation 🙂

I think this one is done?

Done in #1027


[Question] I have something to say about the difference between the official version of OpenWRT and the Lean version

This topic comes from a project called Lean's OpenWRT that I found on the GitHub Chinese board
Their ecology in terms of applications is really much better than the official version of OpenWRT, and there are many more luci-apps than the official version.
This is Lean's OpenWRT LuCI Repo
The question I've always been curious about is why your officials don't look at this branch of the Repo
You guys can recall LEDE and merge it into your mainline repo, why can't you also merge Lean's OpenWRT into your mainline repo and test it?
My hope is that, since they are all OpenWRT, there will be no distinction between the Lean version and the LEDE version.
Because users who use it will have headaches saying why each version is very different, why the number of software in the official version is not as good as the Lean version.
More simply put, it doesn't matter who released it or who compiled it, as long as it doesn't affect subsequent software and firmware updates, it's enough

There is a big difference: LEDE was pretty much the whole active OpenWrt team, which first split off as LEDE and then later merged back and took over the previous OpenWrt repo.

So you guys just don't try to fix it? Why just shut it down?

@hnyman hello?

No new apps are pulled in from third-party repositories. If the author wants to submit them here via PRs, that is fine.

@hnyman If you still allow the existence of the language lua, otherwise it is very difficult


[MOB-1391] fix typo in updateSubscriptions

This could be a breaking change for customers using our Objc API.


docs: note expectations around config vs. monitoring

This is intended to resolve #96
As it adds a normative requirement (primarily targeting connection-oriented transports) it won't be backported.
@garethsb-sony This modifies what was recorded in the issue slightly by suggesting that a known permanent connection-oriented error (only) could be indicated with master_enable (and as such a corresponding IS-04 version update). I don't think that causes an issue, but if you're not sure that sentence could be removed.

I think that is clear, and due to judicious use of RFC 2119 language allows an appropriate range of implementation options. Hope others will chime in though!

the implementation MAY choose to reflect this into the /active resource by setting the master_enable to false.

In this case, should the /active resource's activation also be overwritten? E.g. to
{
  "mode": null,
  "requested_time": null,
  "activation_time": "1496759200:5000"
}

In this case, should the /active resource's activation also be overwritten? E.g. to
{
  "mode": null,
  "requested_time": null,
  "activation_time": "1496759200:5000"
}

I suspect we should match what happens if the configuration is modified by another means (e.g. device's own configuration tool). I doubt that existing implementations would be changing the activation_time when this happens, but that doesn't mean it couldn't now be required.

An alternative approach may be that a lack of a changed activation time would indicate that a system other than IS-05 had made the change.

Or the lack of a (i.e. null) "requested_time"?
But since the spec doesn't currently say either way what should happen to "activation" in these various cases, maybe no further change is necessary to the PR.


Update of cosine-error documentation on Read The Docs

Development of cosine-error derivation under the HBP framework. The PR also includes some typo fixes and editing improvements of the entire "Mathematical Details" page. @jdiedrichsen

My latest commit includes suggestions/fixes addressed on my comments above as well as typo fixes and formatting of equations.

Ok now after rewrite. Note that the vectors sum to 1 over N, not over K!


[BEAM-2735] Update Custom Window Merging Tests

Update the merge windows to be order-independent.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

run dataflow validatesrunner

Changes Unknown when pulling 3ef011b11d6cd8b5ea4df56a60b0db74a66b884b on tgroh:custom_merging_test into ** on apache:master**.

R: @echauchot
This makes the WindowFn and related code more resilient to the arbitrariness of ordering.
This does cause the two tests to succeed on the Dataflow Runner, where they had previously failed. The failure of the ValidatesRunner suite are due to unrelated failures.

+R: @jkff

Thanks @tgroh ! I'm starting the review.

Run Flink ValidatesRunner

Run Apex ValidatesRunner

Run Gearpump ValidatesRunner

I do not run Spark validates runner tests because spark runner does not support custom window merging yet (https://issues.apache.org/jira/browse/BEAM-2499)

retest this please

Changes Unknown when pulling 2cff236da002a132bacd9cf75d24706265c39780 on tgroh:custom_merging_test into ** on apache:master**.

LGTM

Run Flink ValidatesRunner

Run Apex ValidatesRunner

Run Flink ValidatesRunner


Question for Azure App Service: Can you list files on the hosting platform?

Is there a way to see the files I've deployed to the App Service through AZ CLI? Is there a way to look at files on the hosting platform, that the platform creates, such as logs?

route to CXP team

For this you'll need to either use FTP or the kudu API. We don't have this functionality built into the CLI. Marking this as closed. Please let us know if you have any questions about this.
https://learn.microsoft.com/en-us/azure/app-service/resources-kudu
https://learn.microsoft.com/en-us/azure/app-service/deploy-ftp?tabs=portal


Fix midPos overflow

Fix the integer overflow issue when going above 2^30.

Add a comment explaining why this way

This is the method you came up with when we were discussing the far lands. I've checked it and it works for all numbers.

I mean comment in the code - that it's to avoid integer overflow.


Two sided lighting

Looks good to me. Unless anyone else objects, please go ahead and merge.

Just needs UI chechbox


Block(paragraph) detection compare to pdfalto/pdf2xml

Hi there, currently I am finding a way to detect paragraphs in PDF and I fond the file org.grobid.core.visualization.BlockVisualizer is doing what I want.
I want to find out how it works, in other words, how it combines lines into paragraphs. But I didn't find out any code related to blocks(block in Document), it seems to directly retrieve from pdf2xml, am I right?

Hello @voidmagic !
A block is not a paragraph, it's a consistent content zone following a XY-cut. So it is a purely visual object without any "intelligence" and it does not take into account any logical aspect of the document. It is used by GROBID as a low level feature to detect for instance paragraph based on training examples. See this issue.
org.grobid.core.visualization.BlockVisualizer is simply visualizing on the original PDF the blocks provided by pdf2xml or pdfalto. The purpose is debugging.


Slight refactor on BatchProcess & fixed comments

Hi,
got your point, but can you please give some numbers on how this patch increases performance ?
Greetings
Stefan

Hey,
This won't necessarily directly correlate to an increase in performance; however, it is cleaner IMO than creating synchronized lists & blocks of code. It's always best to let java libraries handle that when possible (like what blocking queues do)

Josh


bug: panic caused by channel full

Is your feature request related to a problem? Please describe.
https://github.com/kubernetes/kubernetes/issues/110431
Describe the solution you'd like
don't panic
Describe alternatives you've considered
Additional context

/assign @ryansxy


[Feature Request]: Make IGattCharacteristic.SubscribedCentrals an ObservableCollection

Summary
Currently, the Shiny.BluetoothLE.Hosting.IGattCharacteristic.SubscribedCentrals is an IReadOnlyList<IPeripheral>. I propose changing this to an ObservableCollection<IPeripheral> so that developers know when a device has unsubscribed/disconnected.
Looking through the code, this seems technically feasible and likely would not cause a breaking change for the majority of developers. Raising an event when add or removing from the IReadOnlyList<IPeripheral> could also be an option, however.
I am happy to pick up this work if a conclusion is met.
API Changes
IGattCharacteristic.SubscribedCentrals: IReadOnlyList<IPeripheral> would become IGattCharacteristic.SubscribedCentrals: ObservableCollection<IPeripheral>.
OR
public event EventHandler<CharacteristicSubscriptionEventArgs> OnCharacteristicSubscription would be added to IGattCharacteristic where CharacteristicSubscriptionEventArgs looks as follows:
public class CharacteristicSubscriptionEventArgs
{
public IPeripheral Peripheral { get; set; }
public bool Subscribed { get; set; }
}
Intended Use Case
Currently, there is no way of knowing when a device has disconnected. This will remedy that.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/shinyorg/samples/blob/bdaf209fdf09d8a2f561c8c1fb0a07b5792e7832/BluetoothLE-Hosting/Sample/MainViewModel.cs#L171
https://github.com/shinyorg/shiny/blob/master/src/Shiny.BluetoothLE.Hosting/IGattCharacteristicBuilder.cs#L8


Issue found on page 'Command Line Arguments'

Page URL: https://duckdb.org/docs/api/cli/arguments.html
output mode links (https://duckdb.org/docs/api/cli/arguments#output-formats) don't go anywhere

should link to https://duckdb.org/docs/api/cli/output-formats instead?

@rmoff, indeed, thanks for reporting this. A fix is coming in a second.


PageEdit: 1.9.10 -> 1.9.20

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Sigil-Ebook/PageEdit/releases.
meta.description for PageEdit is: "ePub XHTML Visual Editor"
meta.homepage for PageEdit is: "https://sigil-ebook.com/pageedit/"
meta.changelog for PageEdit is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.20 with grep in /nix/store/71yv51wdy3z2pvbfapp76w54vhwxdmk4-PageEdit-1.9.20
found 1.9.20 in filename of file in /nix/store/71yv51wdy3z2pvbfapp76w54vhwxdmk4-PageEdit-1.9.20

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
PageEdit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/71yv51wdy3z2pvbfapp76w54vhwxdmk4-PageEdit-1.9.20 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A PageEdit https://github.com/r-ryantm/nixpkgs/archive/d970656eb49f05987ae0a57b2624ccf1ae2c7304.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/71yv51wdy3z2pvbfapp76w54vhwxdmk4-PageEdit-1.9.20
ls -la /nix/store/71yv51wdy3z2pvbfapp76w54vhwxdmk4-PageEdit-1.9.20/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

PageEdit

Maintainer pings
cc @pasqui23 for testing.

Tested and LGTM


Game fails to run on Android: shows Godot logo, disappears, repeats

Godot version: 3.1
OS/device including version: Xiaomi Redmi 4
Issue description: When I build/run the Android version of my game, I see the following behaviour:

Godot splash logo appears
Logo disappears in <= 100ms
This cycle repeats roughly 4-5x

I tried to capture adb catlog to a text file. I think this is the relevant part:
04-01 08:04:18.672  1384  1394 I ActivityManager: START u0 {act=android.intent.action.MAIN flg=0x10000000 cmp=com.deengames.controlyourtongue/org.godotengine.godot.Godot} from uid 2000 on display 0
04-01 08:06:13.069  1384  1426 E PackageInstaller: Commit of session 566684875 failed: Failed to collect certificates from /data/app/vmdl566684875.tmp/base.apk: Attempt to get length of null array

I tried two different keystores to be sure I have the right user/password combination.

GLES version?
If you see the logo it is usually related to the renderer, other errors (key or not common characters on filename) fail on install.

I tried GLES2 and GLES3. Same behaviour. These error logs are from GLES3.

I have the same problem. Both GLES2 and GLES3 too. Working with Light2D and Shadows (which produce in another game a black screen on GLES2 btw. Maybe related?).

I downgraded my (simple) project to Godot 3.0.6 to see if that's a work-around. It's not; I didn't check the catlog, but the behaviour of the application is exactly the same.
I now suspect my application code, since I was able to make Android apps work with 3.0.6 in the past. I'll experiment more and see if I can figure this out.
Can anyone suggest a work-around?

I found a partial solution. It looks like my dummy project didn't have a Main Scene specified in the project settings (under Run). Although this allowed me to run it on Windows, it crashed on Android.
Specifying a main scene fixed the problem. This applies to both 3.0.6 and 3.1.
However, my main (broken) project already has a main scene specified; this isn't the reason it's broken.

@nightblade9 no, unfortunately not. I have a Main Scene.

I debugged further and found that my issue is that I preload the same resource twice.

Main scene preloads Second.tscn and HelperScript.gd
Second scene also preloads HelperScript.gd
This is what caused the behaviour.

I think Godot can do the following:

Fail when I run it on PC, the same way it fails when I run it on Android. That way, as a developer, I can be confident that my game works when it works on PC, and I can find problems sooner than later.
Output a warning or error about this problem in the Editor. I checked; there are no warnings about this.

The two work-arounds I found:

Make HelperScript.gd an autoload singleton instead
Use load instead of preload

I solved my problem with the not starting game: it was the broken "Tiled Map Importer" addon.
However: this and the other game still showing a black screen in GLES2, when Light2D is in the scene.

GLES2 and Light2D: had to change the Environment from "Canvas" to "Custom Clear Color". Obviously there was a change that I have missed. Sorry! All functional now.

I wrote a blog post about this today, and I realized that this seems like a genuine Godot bug.  Using preload crashes, but using load doesn't.
Is this expected, or is this a real issue?

Can you make a sample project to reproduce the problem consistently?

It doesn't reproduce any more - not on the original project, and not in a brand-new project.
I'm going to close this issue for now. If I can find a repro case, I will come back to this again and we can investigate more.

HI, please help.
i made a game export apk used to be on Godot 3.1 now i upgrade to 3.3. u got the right template for both. but no mater how i try to resetting it. the game only work perfectly on my Samsung galaxy s10plus. i try it on different divide and it ran fine on the selection screen but when i click start game it load a bit then crash. i try the game on Gl 51 doesn't work, then i try on s10e and still doesn't work. my brother try on galaxy s10 also doesn't work. only work on s10 plus which is mine. thanks for the help.

@duybui0187 Please use other community channels for support questions.


Code migration helper

This PR introduces Rector in order to help migrating and upgrading code using a few set of rules e.g. for PHP or Symfony.

In the last commit, I took the opportunity to change the $this->assertSame(xxx, $response->getStatusCode()); into $this->assertResponseStatusCodeSame(xxx);

Thank you @Spomky.


fix: can not resize pane

Description
fix: can not resize pane
Task Item
close #4952
Screenshots

@alanlong9278 please fix the linting issue


pull request for e2e test at 11/25/2016 16:56:04

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


training code

Nice work! And do you have any plan for releasing taining code?

Same question :)

Yes, it's in our plans

Hello, great work，is there any time plan for releasing the training code? Thanks～

Thank you for sharing this project! I have been using the inference code and it works great. However, I would also like to experiment with training the model from scratch. Could you please provide the code or instructions for training?


Added type hints to State, and made it a dataclass

(trying to make it more newcomer friendly)

Looks great to me.

interesting use of data classes

I'll just add some thoughts (I don't call the shots on this though). Honestly I like the type hinting but I'm not a fan of the use of dataclass in this particular case.
As I understand, dataclasses are designed to save you time from boilerplate code. They may save you from writing some common methods (such as eq and repr), however this change only moves attribute definitions from the init to the class namespace (and provides a repr which can be easily written). I believe the State class is intricate (read: specific) enough that it is worth skipping the dataclass and using the useful type hinting. Is my impression valid?

The __init__ is the boilerplate we're avoiding here...
I personally don't see dataclasses as a way to avoid boilerplate code (although they can be useful for that) but more of a way to specify a class whose central purpose is to hold a specific type of data. The most important thing a dataclass saves you is the __init__ method: not only writing it, but it lets you to separate class api from the implementation.
Moving the specification of that data to the class definition as opposed to the implementation of the init function is exactly the point: positions : List[Hexagon] is a better way to specify that this class holds a list of Hexagons named positions than expecting the user to look inside my init method, and seeing self.positions = positions and then following the definition of positions back to to the arguments.
Basically, a dataclass gives you a neat specification (or interface) of the class that is decoupled from the implementations, whereas an __init__ only specifies the arguments used to initialize a state, and the interface is hidden in the implementation (and if we're lucky it's only in the __init__).

This would be my favourite point:

Basically, a dataclass gives you a neat specification (or interface) of the class that is decoupled from the implementations

I appreciate all the feedback on how to make the project more newcomer friendly.
The users should have a similar experience with the type hints in #55 . If they would like to study the module I believe the arguments in the init should work for them (though I do intend to add more details in the docstring on each attribute). TBH it looks more readable to me like so, however I am not against the idea in principle. So I will look at an updated PR for making state a dataclass if it comes. And if someone wishes to maintain the module, I would be more than happy to be less involved :)


support: neutron-query-relayer

Overview
Add support for neutron-query-relayer.

Since there has been more requests for this, changing the priority to high.


feat(Cdk): Add support for cdk schema version 21

fixes #2

Closing in favour of https://github.com/sv-oss/cdk-cloudone-conformity-scan-action/pull/5 - CDK can handle this for us...


[Bug|UI]: Newline before input

Thank you for your wonderful work on this library. I'm currently trying to integrate it as an interactive shell for a REPL, but I'm stuck with an additional seemingly bugged newline after every entered command. This error is reproducible in the online demo (recording). I also couldn't find any obvious indication why it happened using debug mode.
System

OS: MX 19 / Linux 5.8.0-3 / Mozilla Firefox 90.0.2
Package<EMAIL_ADDRESS>
Steps to reproduce

See video

Enter a command and press enter
type something

Thank you for the fix :)


Poetry MSWC SNN bug

Due to new version of torchaudio (2.1.2), which uses ffmpeg backend for decompressing opus vs the older 2.0.2 which uses sox_io, the MSWC SNN is broken.
Use wav files from HF instead of opus files:

Not possible with the word selection because not all of the dataset is available in wav.

Adding eps of 1e-6 to melspecgram before taking log in S2S, poetry run:

GSC SNN without eps:

'classification_accuracy': 0.848432529519656, 'activation_sparsity': 0.967613262583072, 'Effective_ACs': 3395286.9895502045

GSC SNN with eps:

'classification_accuracy': 0.8564288947648321, 'activation_sparsity': 0.9676503746614553, 'Effective_ACs': 3290823.3114039074

MSWC SNN (before proto) without eps, base words:

'classification_accuracy': 0.011299999999999998, 'activation_sparsity': 0.9220476215115827, 'Effective_ACs': 69445443.028

MSWC SNN (before proto) with eps, base words:

'classification_accuracy': 0.9214999999999998, 'activation_sparsity': 0.9170702291763837, 'Effective_ACs': 71508560.5244

The epsilon trick looks good but it still requires people to install the ffpmeg backend and have this weird conversion of opus files. Plus the epsilon trick is a bit weird to explain for the paper.
Could we rather try to manually convert the opus files to a standard format like wav and see what we get with that?
This way the dataset will be lighter + a better experience for future users.

TODO: add log_offset to S2S as an option, as default option

d1f05afd8dbbc039a1251205ea91741947db7556


pub get : version solving failed after upgrade to flutter 2.0.0   with lottie ^1.0.0

Because audioplayers >=0.16.2 depends on uuid ^2.2.2 which depends on crypto ^2.0.0, audioplayers >=0.16.2 requires crypto ^2.0.0.
And because archive >=3.0.0 depends on crypto ^3.0.0, audioplayers >=0.16.2 is incompatible with archive >=3.0.0.
And because lottie 1.0.0 depends on archive ^3.0.0 and no versions of lottie match >1.0.0 <2.0.0, audioplayers >=0.16.2 is incompatible with lottie ^1.0.0.
So, because flutter_web_demo depends on both lottie ^1.0.0 and audioplayers ^0.17.4, version solving failed.
pub get failed (1; So, because flutter_web_demo depends on both lottie ^1.0.0 and audioplayers ^0.17.4, version solving failed.)
while using :
dependencies:
flutter:
sdk: flutter
lottie: ^1.0.0
audioplayers: ^0.17.4
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.0, on Mac OS X 10.15.7 19H15 darwin-x64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.2.4)
[✓] VS Code (version 1.53.2)
[✓] Connected device (3 available)
• No issues found!

Having the same issue here.
Because no versions of printing match >5.0.1 <6.0.0 and printing 5.0.1 depends on pdf ^3.0.1, printing ^5.0.1 requires pdf ^3.0.1.
And because no versions of pdf match >3.0.1 <4.0.0 and pdf 3.0.1 depends on crypto ^3.0.0, printing ^5.0.1 requires crypto ^3.0.0.
And because audioplayers >=0.16.2 depends on uuid ^2.2.2 which depends on crypto ^2.0.0, printing ^5.0.1 is incompatible with audioplayers >=0.16.2.
So, because bsoft_docs depends on both audioplayers ^0.17.0 and printing ^5.0.1, version solving failed.
pub get failed (1; So, because bsoft_docs depends on both audioplayers ^0.17.0 and printing ^5.0.1, version solving failed.)

Fixed by https://github.com/luanpotter/audioplayers/pull/785


Add setting to determine what happens after closing the last open workspace

Description
this PR adds a preference for what happens after a workspace is closed. the options are:

Do nothing
Show welcome window
Quit

Related Issues

closes #1193

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Good job! The current implementation seems to work, however I think it might be a good idea to generalize it more. Instead of "after the last workspace is closed", we could do "after the last window is closed". For example, if a user has no workspaces open, but it has some other window open (Settings, About, maybe later on some other window). What should happen in that case?

thanks for the review! I only intend the welcome window to open when a workspace/file (as you pointed out) is closed, i could very easily add this feature but i think it's not necessary (unless you think otherwise).

@luah5 Can you post screen recording of it working or at a minimum a screenshot of the settings with the picker?

@luah5 Can you post screen recording of it working or at a minimum a screenshot of the settings with the picker?

sure!

@allcontributors add @luah5 for code


New version: NiLang v0.9.0

Registering package: NiLang
Repository: https://github.com/GiggleLiu/NiLang.jl
Created by: @GiggleLiu
Version: v0.9.0
Commit: 22744e7e4374357996b45c41133c5abeb81e3824
Reviewed by: @GiggleLiu
Reference: https://github.com/GiggleLiu/NiLang.jl/issues/3#issuecomment-758967885

Sorry, the version number is incorrect. Please close this PR.

Sorry, the version number is incorrect. Please close this PR.