Update Laravel Starter

Goal
A comprehensive Laravel starter template to jumpstart your PHP web application development.
Payout
$50
Expectation
Contribute a feature-rich Laravel starter template with a well-organized project structure. Include essential dependencies and configurations. Bonus points for integrating popular packages and writing clear documentation.

gonna try this

I would love to try


PatchItem method in sample code which should not be supported yet

[Enter feedback here]
In sample code of below doc there is one line ".PatchItem(test4.id, patchOperations)" but we actually don't GA partial update now right?
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.cosmos.transactionalbatch?view=azure-dotnet#methods

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f6e924d-f60d-25f3-8864-078be50cde34
Version Independent ID: 08cad3ad-3d3f-064f-8f24-069ce2926b8f
Content: TransactionalBatch Class (Microsoft.Azure.Cosmos) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Cosmos/TransactionalBatch.xml
Service: cosmos-db
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Patch has been GA


Do not show progess bar on npm install on CI

See https://github.com/npm/npm/issues/11283 for more discussion on this.

Clone of PR #1514: https://github.com/ripple/rippled/pull/1514

Current coverage is 62.21%

Merging #1523 into develop will not affect coverage as of 577422a

@@            develop   #1523   diff @@
=======================================
  Files           891     891
  Stmts         63094   63094
  Branches          0       0
  Methods           0       0
=======================================
+ Hit           39254   39256     +2
  Partial           0       0
+ Missed        23840   23838     -2

Review entire Coverage Diff as of 577422a

Powered by Codecov. Updated on successful CI builds.

Merged as 0dc911c09129e91db1803276d18455f56687f12c


Recaf as a Java Agent

It would be REALLY neat if recaf could be applied to a jvm as an agent and the edits would be applied via the instrumentation API.
It'd be sorta like JavaSnoop.
So this would probably pass some arguments to the main method, which would replace the file menu with a "refresh classes" button or something similar. It would still behave largely the same as before with the file tree, as that can just be retrieved via the class path / agent launch args.
Since it would have access to all the libraries I'd imagine there should be some sorta option to limit what is accessible so some operations of recaf aren't slowed to a halt.

Awesome idea!

Soon™

Pushed what I got so far in https://github.com/Col-E/Recaf/commit/ea8f632d555af987e7beaa6ec1b7b0b7f3893ff0. The ability to save edits in agent-mode is not implemented yet, but everything else seems to work!

Gonna close this as its now supported and works as defined by the original post. Only difference is the file tree updates classes automatically in 1.0


feat: support flatten and reshape via shuffle_layer

Description
Support flatten and reshape via shuffle_layer
Fixes #2214
Type of change
Please delete options that are not relevant and/or add your own.

New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project (You can use the linters)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[x] I have added tests to verify my fix or my feature
[x] New and existing unit tests pass locally with my changes
[x] I have added the relevant labels to my PR in so that relevant reviewers are notified

@bowang007

When I test flatten via torch.flatten(inputs, start_dim, end_dim), got error AssertionError: False is not true : expected ops {<OpOverload(op='aten.flatten', overload='using_ints')>}, actuall ops {<OpOverload(op='aten.view', overload='default')>, <OpOverloadPacket(op='aten.sym_size')>, <built-in function mul>}

Is there a specific reason - performance or otherwise, why flatten should need a different implementation than reshape, when using static shapes?

Thanks for the advice! I did this because I noticed there's a flatten op in this schema. I thought our goal is to support these native_functions as much as possible. But anyways, I'll comment out the flatten converter and then wrap the reshape to do flatten op.

Generally, the focus is to cover as much of this operation set as possible: https://pytorch.org/docs/stable/ir.html#core-aten-ir, though if there are operators that show up which we can directly convert as opposed to lowering, that is certainly a good thing to have.

I do still think flatten_dims can be a utility which gives the shape to pass to reshape.

I tried implementing flatten_dims in converter_utils.py. Since flatten_dims needs to call reshape, it caused circular import.

Relevant tests pass locally on Torch 2.1.0. Merging to main.

@bowang007 Please consult this PR for the shuffle op.

@zewenli98  Thanks! Let me update PR accordingly


Runtime Additions

Makefile to build venv
sourceme to setup shell env to run

Thank you for your pull request. I really appreciate your effort and contribution. I'm somewhat new to using Makefile and sourceme, but I definitely see how they could be beneficial for the project, especially in streamlining the development environment setup.
I'm going to accept the pull request. This is a great chance for me to learn something new and improve PyPixelStream. Thanks again for your input!
Best regards.


What happens if the object escapes?

I'm assuming this should have an obvious answer but I can't see one in the README.
If I have
function foo() {
    using reader = stream.getReader();
    return () => reader.read();
}

what happens if I call foo()()?

@rbuckton ok so the answer is that the object gets disposed of no matter what.
I think it would be handy to call this out explicitly in the readme? It makes sense that closure lifetimes are ignored but it's not always obvious with these things


manifest: nanopb: Upmerge to version 0.4.6

This PR upmerges the nanopb module to the tagged 0.4.6 version.
A maximum v3 python protobuf package version is set to fix builds with upgraded scripts/requirements.txt

@pdgendt  SHA: dc4deed54fd4c7e1935e3b6387eedf21bb45dc38

@mbolivar-nordic any open comments?


Spelling fixes

Sorry, this is the same as pr#897, the tool I was using accidentally let me eat my branch marker which closed it...

It's weird there's no hooked CLA checking here.
cc @jzaefferer

@leobalter: you probably lost a race w/ @jquerybot

Ok, we've got a timeout delivering the CLA hook, it's working now and the CLA is verified.
I'll squash and merge this soon, thanks @jsoref!

you probably lost a race w/ @jquerybot

I had to trigger the Redeliver button on the project settings and it saved everything! :)


Discussion on design patterns of (meta)data management and extraction

Around August, there was a function called read_opus_file() in opusreader2.
This yielded what appeared to be correct sample data from files I have been testing with, such as the one attached: DECCW1013_A11.zip
I updated the package today and note that read_opus_file() does not exist now.
I tried to use read_opus() but this returns a different result.
Instead of result$spec$wavenumbers and result$spec$data we now have result$sc_sample$wavenumbers, result$sc_sample$data, result$sc_ref$wavenumbers, result$sc_ref$data and so on for different block types.
Should I do something like divide sc_sample by sc_ref data to yield absorbance data?
Also, at least in the case of sc_sample, the wavenumbers vector has a different length from the data and the data values don't match what I was seeing from  result$spec$data with read_opus_file().
See also:

https://github.com/pierreroudier/opusreader/issues/24
https://github.com/pierreroudier/opusreader/issues/23

I also realise that there is a lot of active development.

Hi David!
Thanks for the input.
I just parsed your file with:
 test <- read_opus("inst/extdata/test_data/DECCW1013_A11.0")
The previous spec is now renamed to ab or ab_no_atm_comp
According to the parsing output of your file, the ab_no_atm_comp is contained in the file.
I also checked the length of the sc_sample data and wavenumber. They both have the same length.
Important to mention is, that the data is a matrix and the wavenumber a normal vector.
I add the screenshots of the output:

What was the length of the sc_sample you got with the read_opus_file() function?

https://github.com/spectral-cockpit/opusreader2/blob/989cfa8f21639cffac6702c7426cd5d56f7eb2ea/R/prepare_spectra.R#L25

sc_sample (single channel sample): Length of NPT := 4827
We found that in data, the last parsed number of the spectral blocks (sc_ref, sc_sample, ab_no_atm_comp) is 0. We also checked this in the Bruker OPUS software (right click on loaded file). We guess, either this is either by design (Bruker) to make reverse engineering more difficult, or by artefact ;-) We slice columns of the data matrix therefore from 1 to NPT.

Indeed, you can calculate the apparent absorbance with the sc_ref and sc_sample blocks (single channels in sensor intensity) so that abs = log10(1 / (sc_sample / sc_ref)). However, you need to do so, because there is the ab_no_atm_comp block. We specifically renamed this because it makes one aware of that no atmospheric correction was performed. Out of interest, is there a reason why you don't do atmospheric correction (CO2, water vapor) at CSIRO?

Well, we hope that with the active development we can now soon release a stable CRAN release of opusreader2. @ThomasKnecht has done some internal refactoring to clean the parse logic with some proper modularization. We want to have read_opus() as a really stable workhorse, with a slim interface. We decided to strictly keep any extra functionality such as extracting metadata as additional helper functions. Or we can make high-level wrappers of read_opus() that come in handy for specific workflows of the community. With this, we hope to leverage as many use cases as possible.

Short question: We plan to draft a vignette in the R package that shines light on the inner working Bruker files and parsing. For this purpose and for extended unit tests, we would like to compile a test suite of files (many types of Bruker FT-IR instruments, equipments and measurements setttings). Can we use your file for this purpose? We would reference your institution for credits.

Thanks for the feedback! This is very valuable to further improve. If you have any other feedback, feel free to say.

@philipp-baumann and @ThomasKnecht. First, thank you very much for your rapid and enthusiastic replies!
I overlooked ab_no_atm_comp initially. I agree that it makes perfect sense to use this and yields the kind of result I expected to see.
Client code calling read_opus() could I suppose first check whether ab exists and if not, use ab_no_atm_comp. Would you consider that to be a reasonable strategy? Are there circumstances under which neither would be present, other than for an invalid file?
I will raise the atmospheric compensation question with the researchers I am collaborating with (as a research software engineer). It may be that this has changed over time or that different Opus settings are applied across site labs for different purposes, but it is very much worth discussing, so thank you.
@ThomasKnecht, I don't recall what was the length of the sc_sample from read_opus_file() since I only used it a couple of times before noticing what I thought was a problem under Linux vs Windows, but just turned out to be a different version installed via devtools::install_github(). Then I updated the installation under Windows and by then only read_opus() was present.
@philipp-baumann, I suspect there will be no problem in using the file in your vignette but I will talk with the researchers.

One thing I'm wondering about is whether rather than or in addition to a message like:
Error in if (next_offset >= raw_size) { :
  missing value where TRUE/FALSE needed
In addition: Warning message:
In 4L * chunk_size : NAs produced by integer overflow

from read_opus(), a status value or string could be returned from the function so that code could programmatically check whether a file read succeeded? Would it be worth creating an issue for this?

On the subject of metadata, can the existing opusreader metadata extraction approach be added to opusreader2?

What is the best way to determine which block to look for data in?
For example, suppose the data are reflectance, will the block containing data always be refl? As you have noted above, if the data are absorbance, presumably the block will be ab or ab_no_atm_comp.
But how to determine which of these to use? Inopusreader one could ask:'
result$metadata$result_spc

and get:
[1] "RFL"

One thing I'm wondering about is whether rather than or in addition to a message like:
Error in if (next_offset >= raw_size) { :
  missing value where TRUE/FALSE needed
In addition: Warning message:
In 4L * chunk_size : NAs produced by integer overflow

from read_opus(), a status value or string could be returned from the function so that code could programmatically check whether a file read succeeded? Would it be worth creating an issue for this?

Could you elaborate on how and when you got such an integer overflow condition? Assume it must be an extremely large integer.

On the subject of metadata, can the existing opusreader metadata extraction approach be added to opusreader2?

@ThomasKnecht and me have discussed a plan how to work on a much better metadata extraction/management scheme that enables more sophisticated data integrity checks (plate positions, sample id, time stamps) etc. . We'd like to separate key infos across table "dumps" so we can link them in relational manner via keys. Save common entries and meanwhile enable comprehensive standard operation procedures on a platform.

What is the best way to determine which block to look for data in?
For example, suppose the data are reflectance, will the block containing data always be refl? As you have noted above, if the data are absorbance, presumably the block will be ab or ab_no_atm_comp.
But how to determine which of these to use? Inopusreader one could ask:'
result$metadata$result_spc

and get:
[1] "RFL"

fist part, yes. We plan a separate table for spectral types in the metadata. Something like that results from the prototype of new extract_metadata()

@davidbenncsiro , FYI we have been updating some basic stuff like README and we are now starting proper semantic verisioning announced in NEWS.md.

Generally I'd be very cautious mixing corrected and non-corrected data in a production environment (when doing cross-comparisons of two identical spectrometers at two different locations on basis of models (developing models with data on one device with atmospheric correction, predict on the same type but different instrument using measurements without correction). It took us a while to figure out what is going on.

#44 @Thorsten-Behrens FYI the discussion we are having with @davidbenncsiro here also refers to your issue/wish. We are working on something we could use in downstream services of spectral-cockpit.

Short question: We plan to draft a vignette in the R package that shines light on the inner working of the Bruker file specification and parsing. For this purpose and for extended unit tests, we would like to compile a test suite of files (many types of Bruker FT-IR instruments, equipments and measurements setttings). Can we use your file for this purpose? We would reference your institution for credits.

I checked with the researcher in question and this is fine.

One thing I'm wondering about is whether rather than or in addition to a message like:
Error in if (next_offset >= raw_size) { :
  missing value where TRUE/FALSE needed
In addition: Warning message:
In 4L * chunk_size : NAs produced by integer overflow

...Would it be worth creating an issue for this?

Could you elaborate on how and when you got such an integer overflow condition? Assume it must be an extremely large integer.

I thought I had created a ticket for this but it appears I didn't. I will need to see if I can reproduce this.

for the metadata extraction see #66

also @davidbenncsiro we have now support for basic metadata here #84

closing since we have this in #66


Legacy IssueReporting collides with projects that rely on it.

This change makes it so that newer projects that also leverage swift-issue-reporting collide with the following error:

multiple similar targets 'IssueReporting', 'IssueReportingTestSupport', 'XCTestDynamicOverlay' appear in package 'swift-issue-reporting' and 'xctest-dynamic-overlay', this may indicate that the two packages are the same and can be de-duplicated by using mirrors. if they are not duplicate consider using the `moduleAliases` parameter in manifest to provide unique names

I would think the way to solve this would be to do what IssueReporting does and create a<EMAIL_ADDRESS>file with this reference in it, then fallback to this one if needed.

Originally posted by @briannadoubt in 84c4f7f

Create a PR for this here. I don't have the permissions to connect this to the PR

I deleted the PR because what I did didn't work

@briannadoubt I changed this so Mockable is compatible with TCA, im not sure what to do here. Best would be if TCA would update to using issue-reporting also...

I think the path I started down would work, with two package files, each consuming a different version of issue reporting based on the Swift language mode.
The issue I ran into is that there are some things that don't compile with Swift 6 language mode, and it would require a refactor. I can maybe try my hand at said refactor! The complexity comes from the swift syntax dependency being shared (with different versions based on the package's language specification) combined with the multiple names for the issue reporting library, so it makes it complicated to support the matrix of all those variables.
I'll spend some time with this!
As an aside, this package is wonderfully designed and this tool is an amazing contribution to the community! I've seen it used in all kinds of tools around me, and it makes consuming the swift-dependencies protocol pattern so nice and clean. So the effort on this would be worthwhile to modernize to Swift 6 language mode 😇 Thank you 😊

@briannadoubt there is already a branch where I implemented swift 6 support, see #64 I just hadn't had the time to finish it yet.

@briannadoubt I merged Swift 6 support changes and would like to revisit this issue. Can you help me understand your use-case better?
For more context, I created #84 so that Mockable is compatible with pointfree libs.
Pointfree packages use the old name of swift-issue-reporting in their package manifest:

TCA /<EMAIL_ADDRESS>TCA / Package.swift
swift-dependencies /<EMAIL_ADDRESS>etc...

all have
.package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "1.3.0")

in the manifest.
This means, that if Mockable uses the new swift-issue-reporting instead of the old package name, you will get the duplication error you posted above if you try to depend on Mockable and TCA together.
If you project uses issue reporting as a dependency I suggest following this to resolve the duplication issue.

I think the discrepancy comes when the package has swiftLanguageModes: [.v6] on it. Then the swift-issue-reporting is used instead of xctest-dynamic-overlay

Can you help me repro that? As I wrote above, I don't see how you run into this issue:

Do you yourself use swift-issue-reporting in your own project?

pls change it to use xctest-dynamic-overlay  bacuse I want to keep compatibility with pointfree libs (delete derived data + swiftpm cache after)

Do you use an other lib that depends on swift-issue-reporting?

which one?

Im closing this for the reasons described above, reopen if needed.


Strange behavior when switching between masks

I am trying to use two masks, one for American Express credit cards (9999<PHONE_NUMBER>9) and one for everything else (9999 9999 9999 9999).
I almost have it, but I'm having a strange problem: as you can see below, when I type 37 the mask switches properly to the Amex one. However, when I erase the 7 and change it to an 8 to make the mask switch back, the 3 disappears.
Am I doing something wrong? Thanks for the help.

JSFiddle
$.extend($.inputmask.defaults.definitions, {
    'a': {  // matches 37 and 34, amex prefixes
        "validator": "3(4|7)",
        "cardinality": 2,
        'prevalidator': [{ validator: "3", cardinality: 1 }]
    },
    'o': {  // matches two-digit number except 34 and 37
        "validator": function (chrs, buffer, pos, strict, opts) {
            return /\d\d/.test(chrs) && chrs != "34" && chrs != "37";
        },
        "cardinality": 2,
        'prevalidator': null
    }
});

$('#x').inputmask({
    mask: ["o99 9999 9999 9999", "a99<PHONE_NUMBER>9"]
});

Now possible.
Consider your field has this ID #cc
`$("#cc").on("input", function() {
var value = $("#cc").val().replace(/\D/g, '');
var mask;
if ((/^3[47]\d{0,13}$/).test(value)) { // American Express
mask = '9999<PHONE_NUMBER>9'
} else if ((/^3(?:0[0-5]|[68]\d)\d{0,11}$/).test(value)) { // Diner's Club
mask = '9999<PHONE_NUMBER>'
} else if ((/^\d{0,16}$/).test(value)) { // Other Credit Cards
mask = '9999 9999 9999 9999'
} else {
mask = 'remove'
}
if($('#cc').attr('data-currentmask') != mask) {
$('#cc').attr('data-currentmask', mask);
$('#cc').inputmask(mask, { placeholder: '' });
}
});`
I found this solution here


rework envs for performance in CI, Binder, RTD

References

fixes #50

Code changes

[x] rework lockfile generation
[x] relock envs
[x] rework RTD and binder envs
[x] tighten up pytest warnings

User-facing changes

docs should build faster
binder should start faster
CI should run faster

Backwards-incompatible changes

dev envs will need to be rebuilt

Provided this makes its way through CI, binder's looking pretty good, and starts much faster (assuming conda is pre-cached).
RTD isn't much faster, but it seems like CI might be.

Back to green. Gonna just merge, if only so we can further debug the steeeking badges.


Extension authoring: Error: Cannot activate the 'helloworld-web-sample' extension because it depends on the 'Git' extension, which is not loaded.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.70.2
OS Version: Windows 10

Steps to Reproduce:

Create new extension https://github.com/microsoft/vscode-extension-samples/tree/main/helloworld-web-sample
Add to package.json:

  "extensionDependencies": [
    "vscode.git"
  ],

Press F5 to start extension.
Try to activate the extension. (Execute the Hello World command)
Get the following error:

Cannot activate the 'helloworld-web-sample' extension because it depends on the 'Git' extension, which is not loaded. Would you like to reload the window to load the extension?

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

@Ark-kun, I believe that this is currently by design as the two extensions are running in different extension hosts. The web sample is running in the web worker extension host, while the vscode.git extension can only run in the node extension host. Extension dependencies only work within the boundary of an extension host.

@lszomoru How can I debug a Web extension that uses git?

The web sample is running in the web worker extension host, while the vscode.git extension can only run in the node extension host.

I was going to disagree with you since Git support is a core piece of https://vscode.dev and https://github.dev . However I now see that the web version has vscode.git-base and GitHub.codespaces.
In any case, how can I use VSCode Web's Git extension?
My scenario: For a given workspace file I need to learn it's GitHub URL and whether the file is "dirty".


Storing credit card information in the clear is a problem

Nice work on eshop/Aspire! I was looking through the code to get a better handle on Aspire and other things when I came across this migration:
https://github.com/dotnet-architecture/eShopOnAzure/blob/master/src/Services/Ordering/Ordering.API/Infrastructure/Migrations/20170208181933_Initial.cs#L91
It looks like a table is created in the database with columns to store card number, expiration date, and security code - all in the clear. Looking at the command/model for saving this information:
https://github.com/dotnet/eShop/blob/main/src/Ordering.API/Application/Commands/CreateOrderCommand.cs#L78
It doesn't look like there's any encryption or attempt to conceal private information for the card or the user. Running the app and placing an order confirms this:

This is kind of a Big Deal when it comes to PCI Compliance which many companies are held to.  Moreover it's just a good idea to not store credit card information in the clear in a database :). Given that we refer to this as a "reference app" it might be a good idea to do the needful for people so they don't accidentally do Bad Things.
Recommendations
One idea that we could do here would be to call out, explicitly, in the API that we're not logging/storing the credit card information. At that point you could return a FakePayment object, for instance, with the information the app needs.
Another idea would be to stub out a Stripe Webhook Receiver with Stripe Checkout integration. Easy to do and I would be more than happy to PR that!

Hi @robconery, thank you for pointing this out - we agree with you that this should be fixed, since this sample should not guide people down the wrong path.
In this case, I think faking the payment call is the right approach (your first suggestion), but we should ultimately adopt an API pattern which is similar to Stripe's, completing payment via another site, with a Webhook to call back into the app.

Cheers @ReubenBond I'm hoping to help on this as I can.

Thank you, @robconery! If you are willing to open a PR, it would be greatly appreciated!

@SrushtiPasari94 Are you working on this one?

Close Srushti's PR for now, talking with Rob looks like we will look into something else.
Srushti verified that right now if you don't add card details then it will break our VerifyOrAddPaymentMethod so that would have to be adjustred or something new


[HA] initial node in NotReady state fails when joining.

When the initial node is in NotReady state, joining another node will fail.
Propose to have microk8s status --wait-ready to wait until all nodes in the cluster are Ready.

There is a bug at https://github.com/ubuntu/microk8s/blob/master/scripts/wrappers/common/utils.py#L45 . We should be checking for " Ready" (note the space) because "Ready" is also part of "NotReady". This should make microk8s status --wait-ready to report True if any one of the nodes are Ready. Why do we need all nodes to be Ready?

Not really necessary to have all nodes to be in Ready. We just need the seed (or initial) node be in Ready state so joining nodes can join appropriately.
Yeah i saw this bug as soon as i created the issue. 😊

Fix merged. Closing the issue.


HHH-17228 - apply the discriminator for 1-1 mappings

to single-table-inheritance subclass attributes

https://hibernate.atlassian.net/browse/HHH-17228

Thanks to @mbladel for helping out with the solution!


Fix GetSinglePersonalAccessTokenByID arg name

Calling the token ID user is extremely confusing...!
Relates to #1686.
Also removes some misleading and redundant error checking within the tests.

@svanharmelen Thanks for the quick response! 🙂

In my opinion you shoud always check errors, also in tests. So please revert those changes.
Updating the error message to make it more descriptive and applicable to the actual error is of course fine.

I'm happy to update my PR, but can you please explain what the purpose is / what error you might expect to see in these specific lines of code, given that it's essentially calling a standard library function with fixed arguments (so the return value will always be fixed)? Error checking would make sense if the arguments were variable, but that's not the case here.
Also, the TestRotatePersonalAccessToken test doesn't have error checking either.

I'm not going to spent too much words on it, but I believe that you should always check all your errors everywhere. As soon as you start to reason about which error checks make sense and which do not, you'll be on a slippery slope just waiting for a missed error check to bites you in production when you least expect it.
Next to that it will set a precedent for other users or committers of this package or maybe even to people who are new at Go. I prefer to encourage them to get used to just always check all errors as in my opinion the Go language best practices also encourages you to do so.
If TestRotatePersonalAccessToken doesn't do error checking then that one slipped through unintentionally. So feel free to update that test instead in order to fix it and make everything consistent again.

@svanharmelen I've now removed the changes regarding the tests.
As a general best practice, I understand and agree with your intentions. However, in this particular case, I'm struggling to articulate what the error message should actually be (and PersonalAccessTokens.ListPersonalAccessTokens returned error:" is definitely not accurate because it has nothing to do with the ListPersonalAccessTokens function), so I'll leave it for somebody smarter than me to rename the error message.


bring v10 to nextcord

Summary

This PR brings v10 to nextcord.
I have removed Guild.remove_threads entirely since Discord doesn't support it anymore. (why?) misread the coded, added it again
I have removed AppInfo.summary.
Also, I have make embed field now converting to a list of embed.
Checklist

[ ] If code changes were made then they have been tested. (will test it later)

[ ] I have updated the documentation to reflect the changes. (no need)

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

id gonna move to other branch.


TaskGroup can't be used in GlobalActor isolated context in Swift 6

Description
TaskGroup can't be used in a GlobalActor isolated context (e.g. MainActor) because "nonisolated callee risks causing data races."
Reproduction
The code below doesn't build with Swift 6. It builds if @MainActor is removed.
@MainActor
func foobar() async throws {
  await withTaskGroup(of: Void.self) { group in
    // 🔴 Sending main actor-isolated 'group' to nonisolated callee risks
    // causing data races between nonisolated and main actor-isolated uses
    _ = await group.reduce(into: [Int]()) { _, _ in }

    // 🔴 Sending main actor-isolated '$generator' to nonisolated callee risks
    // causing data races between nonisolated and main actor-isolated uses
    for await _ in group {}
  }
}

Expected behavior
I expect this builds without errors in Swift 6.
Environment
swift-driver version: 1.110 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.52 clang-16<IP_ADDRESS>.3)
Additional information
No response

I'm experiencing this too. Seems to be any @MainActor-isolated class that uses withTaskGroup and does a for await _ in group { ... }. I tried to isolate it into a sample project but couldn't reproduce it outside the context of my full app.

Possibly related to #72942

for now you can use TaskGroup's own backdeployed API available on swift6
@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
@frozen public struct TaskGroup<ChildTaskResult> where ChildTaskResult : Sendable {
    /// - Returns: The value returned by the next child task that completes.
    @available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
    @backDeployed(before: macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0)
    public mutating func next(isolation: isolated (any Actor)? = #isolation) async -> ChildTaskResult?

    /// Wait for all of the group's remaining tasks to complete.
    public mutating func waitForAll(isolation: isolated (any Actor)? = #isolation) async
}

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
@frozen public struct ThrowingTaskGroup<ChildTaskResult, Failure> where ChildTaskResult : Sendable, Failure : Error {
    public mutating func waitForAll(isolation: isolated (any Actor)? = #isolation) async throws

    @available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
    @backDeployed(before: macOS 15.0, iOS 18.0, watchOS 11.0, tvOS 18.0, visionOS 2.0)
    public mutating func next(isolation: isolated (any Actor)? = #isolation) async throws -> ChildTaskResult?

    public mutating func nextResult(isolation: isolated (any Actor)? = #isolation) async -> Result<ChildTaskResult, Failure>?

}

@MainActor
func foobar() async throws {
    await withTaskGroup(of: Void.self) { group in

        _ = await group.waitForAll(isolation: #isolation)

        while let value = await group.next(isolation: #isolation) {

        }
    }
}

I believe @gottesmm or @ktoso fixed this recently

Yeah I think this had to do with improving how we treat the async closure and adopting isolation. I can double check!


On Startup can appear this pygame-text-input as 2nd window get username and after close it... and continue playing the snake game... ?

If I have a Snake Game
On Startup can appear this pygame-text-input as 2nd window get username and after close it... and continue playing the snake game... ?

I failed in pygame
Can Not appear two windows...
how get username,... after popup get closed, and after continue Snake game in the main window ???

I'm not sure why you're coming to me with this question. Nevertheless, here's an answer: It's not possible to use multiple windows in pygame.


add brave-browser-deb

First of all update your local branch. It's lagging behind. Then reopen this PR


Refactor the Dashboards dependencies

Refactor ALL the dependencies.
 We
were kind of entering a dependency hell that
I wasn't pleased with. So we remove gulp in
favor of NPM.
On top of gulp getting chopped, the express
boilerplate also got removed, as it also
introduced a lot of YAGNI dependencies that
we don't care about (at least, not yet). I
replaced the express boilerplate with more readable
code and a more sensical file structure.
@Lettuceman44 @mok4ry

@Lettuceman44 after this get's merged, we'll need to kill jenkins (thank god) and start using travis. that'll free up some server processing power and integrates directly into github (as in, you can see builds kicking off right here on the PR when we hook it up.. super cool).

-290 lines. amazing

Looks good!


chore: improve import statement

✅ Checklist

[ ✅ ] I have followed every step in the contributing guide (updated 2022-10-06).
[ ✅ ] The PR title follows the convention we established conventional-commit
[ ✅ ] I performed a functional test on my final commit

Changelog
I just improved the import statements

Hey thanks for the PR
However, I am not a proponent of barrel files so gonna close this


Invalid URLs fixes for OfficeDev Training content and Office Fabric UI

Category

[X] Content fix
[ ] New article
Related issues: fixes #1989, #1973, #1974

What's in this Pull Request?
Fixes of the invalid URLs in the docs.microsoft.com documentation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ekapic sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/scenario-guidance/Security.md
:white_check_mark:Succeeded
View

docs/solution-guidance/search-api-usage-sharepoint-add-in.md
:white_check_mark:Succeeded
View

docs/sp-add-ins/sharepoint-add-ins-ux-design-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/scenario-guidance/Security.md
:white_check_mark:Succeeded
View

docs/solution-guidance/search-api-usage-sharepoint-add-in.md
:white_check_mark:Succeeded
View

docs/sp-add-ins/sharepoint-add-ins-ux-design-guidelines.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Gateway config are not combined into one document for apply

The apply command takes a file that has one or more resources defined.  For the resource Kind of GatewayService, all these resources have to be combined into one document before sending to the /gw/api endpoint.
For example:
kind: GatewayService
name: service-1
host: api.co1.com
---
kind: GatewayService
name: service-2
host: api.co2.com
---
kind: GatewayService
name: service-3
host: api.co3.com

Needs to be sent as:
services:
- name: service-1
  host: api.co1.com
- name: service-2
  host: api.co2.com
- name: service-3
  host: api.co3.com

testing here

Note that publishing the gateway should return the same response as when just running publish-gateway


Fix StatusPage colors

Details

This page was referencing outdated colors

Fixed Issues

$ https://github.com/Expensify/App/issues/33091
PROPOSAL:
Tests

[X] Verify that no errors appear in the JS console

Offline tests

QA Steps

[X] Verify that no errors appear in the JS console
[ ] Go to Status Page
[ ] Toggle on Both Light / Dark Mode
[ ] Verify Colors are Correct

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Open settings > Preferences > Theme
Switch the theme to light
Go to Profile > Status page
Switch the theme to dark
Go to Profile > Status page
Verify Colors are Correct according to the selected theme

@grgia could we update QA steps to ^ for clarity?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@grgia should we also update the loading page if it is even possible.

Missing shadow on the header, it'll also be nice if we could include it here.

Task view
Other chats

should we also update the loading page if it is even possible.

@getusha the loading page cannot be updated to match the theme in ONYX currently because it is set by HTML

Missing shadow on the header, it'll also be nice if we could include it here.
@getusha is this on both dark and light / is this on production? I think we may want to fix in a separate PR

@getusha is this on both dark and light / is this on production? I think we may want to fix in a separate PR

just checked and able reproducible on prod, we can ignore it.

@grgia lets update the testing steps https://github.com/Expensify/App/pull/33100#issuecomment-1856356862

@getusha done!

@AndrewGable @getusha I'm going to make one more one-line color key update in this PR

@getusha @AndrewGable done

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

CP'd the fix

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 1.4.13-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add after and before streams

Adding actions for after and before streams, added in v7.0.0
It seems like it works on v7.0.0-rc4, but it would be nice to include an update to v7.0.1 in this PR as well. I'm unsure how to do that. Will be glad for help on that.
I also guess there should be some test added for this?

[x] add after and before
[ ] update to v7.0.1
[ ] add tests?

Thanks!
Can you please extend the test at https://github.com/miguelgrinberg/turbo-flask/blob/main/tests/test_turbo.py#L138 to include the two new stream types?
And then you can define the 7.0.1 version here: https://github.com/miguelgrinberg/turbo-flask/blob/main/src/turbo_flask/turbo.py#L9. The version information can be obtained from the CDN page at https://cdn.skypack.dev/@hotwired/turbo.

Not sure about the test, tried it naively.


A Responsive version of Bootstrap

I've tried to quarantine all my changes to test out a responsive version of Bootstrap to the css and responsive directory and the examples/responsive.html file. It's all very experimental and more of a first kick at a responsive layout using an alternate grid system, but it might be an interesting alternative approach to the 2.0-wip branch.
View a demo of the responsive version at domain7.com/mobile/tools/bootstrap/responsive/. It has also been developed as a Symphony CMS ensemble. View the demo of the ensemble at sym.domain7.com/demo/bootstrap/.

Looks very good! I just tested with Iphone, Android & BlackBerry http://minus.com/mUCuSCgF3

NIce! Thanks for testing it out. It is a departure from the recommended grid system, but I don't think a front-end design framework should necessarily enforce usage of a specific grid system, but instead provide a variety of options. This could be one possible option.

I like its grid system, for me it is more compact and simple to use than the original. Thank you for this.

Great! That was the intent: a simpler and more semantic set of classes. In practice, I've found that more complex grids tend to be less useful, especially when "mobile first" is the goal.

I notice that some forms, modal and popout are not responsible in your sample html.

You're right. It's actually a work in progress rather than a finished demo. So this really is more a proof of concept for a possible approach. It shouldn't be pulled in as is.

Going to be looking at the rest of this soon to see what we can pull in to the 2.0-wip branch. So far you're off to a good start.
One thing to note now: all those self-closing elements you "fixed" aren't actually required in the HTML5 doctype. No need for trailing slashes on meta, ìnput, img`, etc.

Thanks @markdotto. I know it's pretty rough around the edges.
Also, the reason for the self-closing elements is my own preference to still maintain valid XML, even though HTML5 does not require it, mostly because I am using XSLT to both render and manipulate the output. This is how it gets rendered by the XSLT processor: http://sym.domain7.com/demo/bootstrap/.
Just because the lemmings are paving the cowpaths, that doesn't mean I have to fall off the same cliff.

Since this is just a demo, going to close it out. If you'd like any of this to be added in smaller chunks to 2.0-wip, let's do that—we'd be more than happy to have them (just in more manageable pieces).


Fix mpi search

Addresses issue reported by @rouson and makes it so that CMake can find MPI installation from install.sh even when it's not on the user's PATH

Current coverage is 48.18% (diff: 100%)

Merging #256 into master will not change coverage

@@             master       #256   diff @@
==========================================
  Files             2          2
  Lines           907        907
  Methods          42         42
  Messages          0          0
  Branches        195        195
==========================================
  Hits            437        437
  Misses          392        392
  Partials         78         78

Powered by Codecov. Last update 1eb9ce1...ac4b398

LGTM


unify use of password and secureTextEntry for TextInput

Currently, the documentation shows both password and secureTextEntry as props for TextInput. However, the password prop is only passed to the Android component, so it does not work as expected for iOS developers. This PR prefers password over secureTextEntry but won't break anybody's code.

:+1:

Looks good!
@vjeux, @sahrens does React Native aim for backwards compatibility before the 1.0 release? If not, you could simply do secureTextEntry={this.props.password}.

Good question @mkonicek - that would be nice if we could just standardize on password. @vjeux @sahrens what do you think?

Many things here:

What is the web naming for this attribute if it even exists?
Have those two attributes exactly the same behavior?
We want to split this into TextInputIOS and TextInputAndroid because they don't share the exact set of props. Maybe add a TextInput that's a lowest common denominator

@vjeux - re: point 1, it is type="password"


POST cant't work  good

this library is really nice , but when I use post to submit some data，it response nothing. I’m tried  many way to request.
I'm trying to use Node to make a simulated login. The next request requires the cookie returned by the previous request. I don't understand the usage of cookieJar. I wonder if I can automatically save and pass cookies like the Python Request Library?
Looking forward to your reply.

You can use const yourRequest = request.defaults({jar: true})
Then you use yourRequest instead of normal request


Broken link

There is a typo on  link to jxnblk.com/rebass on https://github.com/jxnblk/rebass/blob/master/README.md .

Thanks! Should be fixed now

Hello,
Cool, it is working now.


[libshortfin] Fix non-editable install

https://github.com/nod-ai/sharktank/pull/177 Broke building non-editable packages using pip install . . Non python files are not copied by package_dir and need to be explicitly copied to build_lib. The approach taken is same as IREE: https://github.com/iree-org/iree/blob/main/runtime/setup.py#L371-L390

Fine to land but the way that iree does this is wrong too as editable doesn't work.
I think we're missing a thing but would need to fiddle with it.
Let's make one of the CI actions so a non editable install and one editable so we can refactor with a bit more confidence.

Let's make one of the CI actions so a non editable install and one editable so we can refactor with a bit more confidence.

As building libshortfin is quite fast it would be good anyway to do multiple builds with different configurations (e.g. get IREE as a bundled dep, provide the source, use system deps,...). I will add this to my list  for the release build ci.

Fine to land but the way that iree does this is wrong too as editable doesn't work.
I think we're missing a thing but would need to fiddle with it.
Let's make one of the CI actions so a non editable install and one editable so we can refactor with a bit more confidence.

I think editable is working for me with this. If the build is editable, self.build_lib is set to a temporary directory where the lib is built and the target is copied there. So, it essentially becomes a no-op. The editable_finder still finds the correct target. Is there some other problem that i'm missing?


Automated testing for Python 3.12 should be added

For now, testing of new pull requests is only performed for Python 3.6-3.11, while 3.12 is the latest release.

I have added them as part of the chore tasks on releasing 0.6.0


deno: 1.43.6 -> 1.44.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for deno is: A secure runtime for JavaScript and TypeScript
meta.homepage for deno is: https://deno.land/
meta.changelog for deno is: https://github.com/denoland/deno/releases/tag/v1.44.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.44.0 with grep in /nix/store/hnl24llk9cqzkgrx22yyg7ilrldncbsx-deno-1.44.0
found 1.44.0 in filename of file in /nix/store/hnl24llk9cqzkgrx22yyg7ilrldncbsx-deno-1.44.0

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

12 package rebuild(s)

First fifty rebuilds by attrpath

deno
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
vimPlugins.denops-vim
vimPlugins.vim-pluto
windmill

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hnl24llk9cqzkgrx22yyg7ilrldncbsx-deno-1.44.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A deno https://github.com/r-ryantm/nixpkgs/archive/002ccdfa82f6cc30801857d5d9de29606ee6719b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/002ccdfa82f6cc30801857d5d9de29606ee6719b#deno

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hnl24llk9cqzkgrx22yyg7ilrldncbsx-deno-1.44.0
ls -la /nix/store/hnl24llk9cqzkgrx22yyg7ilrldncbsx-deno-1.44.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

11 packages built:

deno
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
vimPlugins.denops-vim
vimPlugins.vim-pluto
windmill

Maintainer pings
cc @06kellyjac for testing.

Probably hold of on this as 1.44.1 has also been tagged


[Feature Request]: Make fakes semi-transparent by default across noteskins

Is there an existing issue for the feature?

[X] I have searched the existing feature requests

Describe the Feature
Fake notes would be slightly transparent by default in noteskins, it would use a noteskin's normal arrows, but just make them slightly transparent to differentiate them
How Does The Feature Add To The Game?
Fakes have always been identical to normal normal notes, this has lead to them slowly being faded out of peoples consciousness by design due to how limiting that was. If they were faded by 25% opacity, or something similar, that would open the gate for many things - letting fakes become another form of expression for charters, and another gimmick style for people to enjoy. It also lets people do more creative things with charting, and let players enjoy more creative charts.
It's not identical, but a similar thing has been done by user Foxfire667 in their noteskin, where he made fakes a semi transparent outline, and it proved to open the gate for creativity. Here's a screenshot of his noteskin:

and here's a video if the idea being used in a chart:
https://youtu.be/w2mJa9ANBC4
Additional Context
No response

added this as an option for all note types instead of just fakes. any noteskin can easily control the opacity of all notetypes freely. a default value for fakes has been added to each preinstalled noteskin, and in the event the values for each notetype are missing, the fallback will be 1 for all except fakes, which are set to 25%
to modify fake opacity in your own noteskin for example, add TapFakeNoteOpacityMultiplier=1.0 to your noteskin's metrics.ini. 1.0 will cause the note to be fully visible, and 0 will bring it down to completely invisible.
to use this option for the other notetypes, follow the pattern for notetypes...
TapNoteNoteOpacityMultiplier=1.0 ... HoldBodyNoteOpacityMultiplier=1.0 ... etc
e4def5fa4075f4d9138cf449fcb5c6f2cdc421cc
38cf1c8d403952540567364a9faa37ddcfef605b


Make test does not finish

After compiling flashlight (with ArrayFire-no-gl-v3.6.2) using CUDA backend, I tried running make test but it takes forever and never finishes the first test. Looking at htop, AutogradTest is in state S and utilizing 0.0% CPU.
Any suggestions as what might be the issue?
Thanks

@hhadian — this sounds like it might be a problem with ArrayFire. Can you try running the ArrayFire tests and see if they pass?

I didn't build Arrayfire.
But anyway, I guess I figured it out. Seems like the prebuilt ArrayFire-no-gl-v3.6.2 was built against a higher cuda version than the one I have installed (which is 9.2). I upgraded nvidia driver to 410.xx and things are running fine now.

@hhadian  Cool. The upcoming version of AF will check driver versions in order to assert the drivers are recent enough against the cuda verison.

@hhadian @WilliamTambellini — good to know. In general, I've discouraged others from using the precompiled libraries because of issues with driver versions; glad to hear there's a fix on the way.


[Issue 11185][pulsar-brokers test] Fix failing auth test.

Fixes #11185
Motivation
TokenAuthenticatedProducerConsumerTest is currently broken due to expiry of hard coded token.
Modifications
Instead of hardcoding the token, we can generate the token dynamically and
avoid this problem in future
Verifying this change

[x] Make sure that the change passes the CI checks.
The change is fixing a broken test.

Does this pull request potentially affect one of the following parts:
No
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why? Not a feature. Fixing an existing testcase
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

/pulsarbot rerun-failure-checks


Add hashbrown to homu

See also: https://github.com/rust-lang/team/pull/63
r? @pietroalbini
cc @Amanieu

Thanks!


standard does not unserstand async generators

What version of standard?
9.0.0
What operating system, Node.js, and npm version?
windows 7
npm 6.0.1
node 10.1.0
What did you expect to happen?
no errors
What actually happened?
Parsing error: Unexpected token *  when using async generators
https://jsbin.com/folotu/edit?js,console

You should update to a more recent version of standard which supports async generators :)


import wmi, pywinauto print Win32 exception occurred releasing IUnknown at xxx

Expected Behavior
No Error Message like Win32 exception occurred releasing IUnknown at xxx
Actual Behavior
import wmi, pywinauto results in Error Message Win32 exception occurred releasing IUnknown at xxx
Steps to Reproduce the Problem

Install Python 3.7.2 32 Bit or Python 3.7.2 64 Bit
Create a new python File with import wmi, pywinauto
Execute the File >> Error Message: Win32 exception occurred releasing IUnknown at xxx

Short Example of Code to Demonstrate the Problem
import wmi, pywinauto
Specifications

Pywinauto version: 0.6.6
WMI version: 1.4.9
Python version and bitness: 3.7.2 32 Bit / 64 Bit
Platform and OS: Windows Server 2012 R2

Hi @dschiller can you provide the full traceback of the exception? Also pip freeze output would be helpful: comtypes and pywin32 versions are the most interesting.

Well, short googling tells me that the problem has multi-threading nature. See https://stackoverflow.com/q/2880723/3648361 and https://github.com/sethmlarson/virtualbox-python/issues/114
So let's take a look at the code beyond.

@vasily-v-ryabov There is no full traceback I just see this Message.

@vasily-v-ryabov pip freeze:
comtypes==1.1.7
pywin32==224

Did you try import sys; sys.coinit_flags = 0 before import pywinauto?

If I try that I get this:
C:\Users\Administrator\AppData\Local\Programs\Python\Python37\lib\site-packages\pywinauto\__init__.py:72: UserWarning: Apply externally defined coinit_flags: 0
  .format(module_sys.coinit_flags), UserWarning)
Win32 exception occurred releasing IUnknown at 0x32218c00

Source Code Excerpt:
import sys; sys.coinit_flags = 0
import pywinauto, os, time, wget
from pywinauto import ElementNotFoundError, ElementAmbiguousError, keyboard
from pywinauto.timings import TimeoutError
from pywinauto.findbestmatch import MatchError

Can you open a command prompt, execute the command below and the output?
python  -v -c "import pywinauto"

@dschiller can we have a short call this Saturday? It's better to take a look at this problem with sharing screen and debug. You can find my e-mail like this: "vasily-v-ryabov".replace("-", ".") at gmail dot com.

Seems has something todo with the Combination of the Imports for pywinauto and wmi.

Hi, May I ask is there any progress on this? I have also encountered the same issue, the issue only happened when pywinauto and wmi module was imported together
And this exception can be reduced by using multithreading

@sunjeen had no chance to look into this yet.

I have also encountered the same issue again, happened when wmi and pythoncom was imported together. Multithreading is normal together, this problem occurs when single threading.When I remove pythoncom in a single thread, everything works fine.

@wawa0210, if I understand correctly you tried to play with sys.coinit_flags as explained in our docs https://pywinauto.readthedocs.io/en/latest/HowTo.html#com-threading-model Am I right?
Notice that the flags should be set before importing all involved modules: wmi, pythoncom and pywinato

@wawa0210, if I understand correctly you tried to play with sys.coinit_flags as explained in our docs https://pywinauto.readthedocs.io/en/latest/HowTo.html#com-threading-model Am I right?
Notice that the flags should be set before importing all involved modules: wmi, pythoncom and pywinato

I set before import all involved modules


Feature request: Get area under a implicit function

I am not sure if it is already available, but AFAIK it is not possible the get the area from a implicit function. This post seems to confirm my supposition.
My code, for instance,
from manim import *

class ImplicitFunctionExample(Scene):
    def construct(self):
        ax = Axes(x_range=[1, 4], y_range=[-1, 4]).add_coordinates()
        x_label = ax.get_x_axis_label(MathTex("x"), edge=DOWN, direction=DOWN, buff=0.5)#.shift(DOWN)
        y_label = ax.get_y_axis_label(MathTex("y"), edge=LEFT, direction=LEFT, buff=0.5)#.shift(DOWN)
        graph = ax.plot_implicit_curve(lambda x, y: x*y-1, color=YELLOW)
        area = ax.get_area(graph)
        axis = VGroup(ax, x_label, y_label)
        self.add(axis, graph, area)

Prompt to the error

AttributeError: ImplicitFunction object has no attribute 't_min'

I am not sure that it is possible, in general, to determine a suitable definition of "area under the curve" for an implicit function. What would be the area under the curve $x^2 + (y-2)^2 = 1$?
You can construct a corresponding object via something like VMobject.set_points_as_corners, more or less like the current implementation of the get_area method does for parametric functions.


Need link of plug in that needs to be installed.

Where can I find the link to the plug in that needs to be installed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ce7a531-5b1f-f404-50a3-58eb285a0a1a
Version Independent ID: 61d27af3-cfd6-ed7f-102c-072721db0209
Content: Plan for Meetings clients (Web App and Meetings App)
Content Source: Skype/SfbServer/plan-your-deployment/clients-and-devices/meetings-clients.md
Product: skype-for-business-itpro
GitHub Login: @jambirk
Microsoft Alias: jambirk

Thank you for this feedback and for contributing to the wellness of the content! This is a good idea and we have added it into our backlog for triage and prioritization.

@tseward Is investigating this.

Hi thanks for your feedback!
The plugin is mentioned early in the document as Skype for Business Web App browser plug-in
Hope this information has helped you!

A more detailed answer: the browser plugin self-installs when an external user without a regular client tries to access a meeting via the web. You can't preinstall the plugin, the only way to get it is to try to join a meeting. Most questions of this nature stem from wanting to have the client preinstalled, which isn't a supported scenario.

Thanks for expanding my answer @jambirk


The Editing of profile is working with use of JAVASCRIPT

Fixes issue #4706
The editing of profile is now seen using modification with the help of basic html and intermediate javascript.

Dear @anuragverma108 , please merge this pull request

Dear @anuragverma108 , please merge this pull request

resolve conflicts @pinakviramgama


failed to run pgbench in docker setup

I'm running pgbench -s5 -i in docker setup as it is in our console repo.
pgbench output:
NOTICE:  table "pgbench_accounts" does not exist, skipping
NOTICE:  table "pgbench_branches" does not exist, skipping
NOTICE:  table "pgbench_history" does not exist, skipping
NOTICE:  table "pgbench_tellers" does not exist, skipping
creating tables...
generating data (client-side)...
500000 of 500000 tuples (100%) done (elapsed 0.28 s, remaining 0.00 s)
vacuuming...
pgbench: fatal: query failed: ERROR:  could not read block 0 in rel 1663/16385/16399.2 from page server at lsn 0/08D8C7A8
CONTEXT:  while scanning block 0 of relation "public.pgbench_branches"
pgbench: query was: vacuum analyze pgbench_branches

In pageserver logs:
INFO Created database 1663/16385, copied 1014 blocks in 243 rels at 0/169F110, location: pageserver::restore_local_repo, pageserver/src/restore_local_repo.rs:646
INFO switched segment 0/1FFEB00 to 0/2002660, pageserver/src/walreceiver.rs:257
INFO switched segment 0/2FFFDF8 to 0/301D870, pageserver/src/walreceiver.rs:257
ERRO get_page_at_lsn: Timed out while waiting for WAL record at LSN 0/8D89210 to arrive, pageserver/src/page_service.rs:377
INFO switched segment 0/3FFF090 to 0/4004C40, pageserver/src/walreceiver.rs:257
INFO switched segment 0/4FFE860 to 0/5005EF8, pageserver/src/walreceiver.rs:257
ERRO get_page_at_lsn: Timed out while waiting for WAL record at LSN 0/8D89210 to arrive, pageserver/src/page_service.rs:377
INFO switched segment 0/5FFFAF8 to 0/6003658, pageserver/src/walreceiver.rs:257
INFO switched segment 0/6FFED28 to 0/7000D88, pageserver/src/walreceiver.rs:257
ERRO get_page_at_lsn: Timed out while waiting for WAL record at LSN 0/8D89210 to arrive, pageserver/src/page_service.rs:377
INFO switched segment 0/7FFFF80 to 0/8001FE0, pageserver/src/walreceiver.rs:257
WARN drop_segment called on non-existent relish 1663/16385/16389 at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16389_fsm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16389_vm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16386 at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16386_fsm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16386_vm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16395 at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16395_fsm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16395_vm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16392 at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16392_fsm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
WARN drop_segment called on non-existent relish 1663/16385/16392_vm at 0/8D8A6D0, pageserver/src/layered_repository.rs:820
ERRO get_page_at_lsn: Timed out while waiting for WAL record at LSN 0/8D8C7A8 to arrive, pageserver/src/page_service.rs:377

Timeouts are probably fine, because I had runs with timeouts but without this warnings
@lubennikovaav is it #502 or something new?

Warning was fixed some time ago, wait lsn timeout error should be fixed in #630

@LizardWizzard let's check that again since backpressure was merged/fixed?

Lets close this in favor of https://github.com/neondatabase/neon/issues/1587.
Current issue was discovered when I was running whole setup in docker on mac os, so it was quite slow. I no longer have this setup at hand, so I think it makes sense to test backpressure while applying CPU limits on pageserver


Fix the numerous reversals of qubit orderings for cliffords and paulis

After qubit orderings for cliffords and paulis were changed to the computational basis ordering, issues related to inconsistent qubit ordering conventions have repeatedly bitten us in the booty. All clifford and pauli related functions are now consistent in taking arguments in this ordering, but there are still many stray reverses lying around, which should be cleaned up and restructured appropriately to reflect the logic of computational basis ordering.

Was this closed by #307, or is there still more to do?


Fix typo in unambiguous.md

Coverage remained the same at 97.646% when pulling cfc2427199c048e7336264e0864177e95f344bb4 on SimenB:patch-1 into 0e6cbacbad96ca0a2ba9ee4de96468ccd18c77d4 on benmosher:master.

Thanks @SimenB! :smile:


Non-ASCII characters in entity names

They may contain letters, digits, underscores (_), spaces, dots (.), and dashes (-).

Entity names (such as column names) don't support non-ASCII characters (such as Japanese or Korean characters).
Could you please clarify what characters are supported as "letters"? (I think they are a-z and A-Z)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e85b21a1-258d-b3bf-8c35-51f0e7162f21
Version Independent ID: 7d58da00-bfa7-9303-8e63-872a65b9bc6a
Content: Entity names - Azure Data Explorer
Content Source: data-explorer/kusto/query/schema-entities/entity-names.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

@satonaoki
Thanks for the question! We are investigating and will update you shortly.

Any letters supported, including Korean ones (with escaping):
print ['여보세요'] = 's'

@satonaoki - thanks for your feedback. @sloutsky - thanks for the response. I am now closing this issue.


[suggestion] upload release class jar & sources jar to Maven central repo

Which module is your feature request related to?
All, deployment related
Is your feature request related to a problem?
If the release class & sources jars were uploaded to maven central repository, the java developers can add provided dependencies to their project, learn& debug the pinpoint and plugins. No need to build the pinpoint project by themselves locally.
** solutions
./mvnw clean source:jar install deploy -Prelease

I'm working on it.
https://issues.sonatype.org/browse/OSSRH-66408
The pinpoint snapshot has been deployed on the sonatype repo.
https://oss.sonatype.org/content/repositories/snapshots/com/navercorp/pinpoint/


Remove all but the reductive walker from the codebase

Feature Request
Description of Problem:
There are 3 different decision tree walkers, one is the default for data generation and the others are 'not used' (once #423 has been completed). The 'unused' editions should be removed to save confusion and execution of otherwise untested modules.
Acceptance Criteria:

[ ] Cartestian product tree walker has been removed
[ ] Routed tree walker has been removed
[ ] Command line options to vary the tree walker are removed

[ ] Documentation updated to remove mention of these options - at least: GenerateOptions & TreeWalkerTypes

[ ] Cucumber steps to vary the tree walker are removed

[ ] Wiki updated to remove mention of this step

Out of scope

Major refactoring to remove other types, e.g. DataBag's CombinationStrategies, etc.

Blocked by #423

I'm not sure this is the right move. One of the core design philosophies we should adhere to is: People should be able to contribute new solvers (or other modules). If we have just one implementation, I think we're gonna lose sight of that.
On top of that, if the cartesian strategy is the one we had in the old days, it's better than the newer one in some ways. I'd sooner have a bit of code that chooses between solvers based on analysing the inputs.

Major refactoring to remove other types, e.g. DataBag's CombinationStrategies, etc.

I know this is considered out of scope for this issue, but please talk to me before you go about these things.

what about RandomReductiveDecisionTreeWalker. should it be removed or left in place

No preference from my side - I've no idea what it is 😄

Impetus to do this piece of work has been removed. The other 'solvers' have different characteristics and can be more efficient for certain (often simpler) profiles. Therefore these could be selected to solve these types of profiles.


[forecast: fit, lag_transforms, SeasonalRollingMean] double free or corruption (out) error

What happened + What you expected to happen
I get a double free or corruption (out)error in linux when trying to fit a model using SeasonalRollingMean as lag_transform.
I do not get that error on macOS, nor if I use RollingMean instead of SeasonalRollingMean, nor if I use coreforecast==0.0.12
Versions / Dependencies
OS: debian
python: Python 3.11.10
mlforecast==0.15.0
coreforecast==0.0.14
Reproduction script

import lightgbm as lgb
from mlforecast import MLForecast
from mlforecast.lag_transforms import SeasonalRollingMean
from mlforecast.utils import generate_daily_series

def main():
    data = generate_daily_series(10)
    fcst = MLForecast(
        models=[lgb.LGBMRegressor()],
        freq='D',
        lag_transforms={
            56: [SeasonalRollingMean(season_length=7, window_size=4, min_samples=2)]
        },
    )
    fcst.fit(data)

if __name__ == "__main__":
    main()

Issue Severity
Low: It annoys or frustrates me.

Hey. Thanks a lot for the detailed report, I'm able to reproduce the issue and will work on a fix.

Fixed by https://github.com/Nixtla/coreforecast/pull/62, will make a release later today. Thanks for reporting!


SCP-2716: Add missing values to export tx

ExportTx has a new field missingValueBalance indicating the crypto value that needs to be supplied by additional inputs or paid to additional outputs. This information is already contained in the transaction field, but it can be helpful to see it directly in the JSON.
Example:
{
    "transaction": {
        "cborHex": "84a60081(...)",
        "description": "",
        "type": "Tx AlonzoEra"
    },
    "signatories": [],
    "inputs": [
        {
            "txIn": "8d73f4d4df61b16e5db0debea1c6f7d975b0c68f7c8647aedde730a114f71b9e#2",
            "txOut": {
                "address": "addr1wxfy83f7qgt734ph2m992a063tucwp74psdtefmr5kjzwfc4dlfvg",
                "data": "89c864ada93e78e54c0146da830077d209999197a36f8b172323b705832ad5cf",
                "value": {
                    "lovelace": 101
                }
            }
        }
    ],
    "missing-value": {
        "outputs": {
            "73e56188788f45b176f3f2735be07a12cc466b864da0449a313e7792": {
                "stablecoin": 50
            }
        },
        "inputs": {
            "lovelace": 50
        }
    }
}

Pre-submit checklist:

Branch

[X] Tests are provided (if possible)
[X] Commit sequence broadly makes sense
[X] Key commits have useful messages
[X] Relevant tickets are mentioned in commit messages
[X] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[X] Self-reviewed the diff
[X] Useful pull request description
[X] Reviewer requested

Chatted about this with WBE team and decided it's best to not add this field after all.


Symfony 3.0.4 sidebat token not found

Hi,
I installed the bundle and I me trying to add some menus to the sidebar using https://github.com/avanzu/AdminThemeBundle/blob/master/Resources/docs/sidebar_navigation.md .
I created a Model in my bundle and imported the interface needed funciontions.
Then I creted a new folder EventListener and a new class MyMenuItemListListener.php I copyed the code and added some menu items
protected function getMenu(Request $request) {
        // Build your menu here by constructing a MenuItemModel array
        $menuItems = array(
            $blog = new MenuItemModel('ItemId', 'ItemDisplayName', 'category_index', array(/* options */), 'iconclasses fa fa-plane')
        );

        // Add some children

        // A child with an icon
        $blog->addChild(new MenuItemModel('ChildOneItemId', 'ChildOneDisplayName', 'category_index', array(), 'fa fa-rss-square'));

        // A child with default circle icon
        $blog->addChild(new MenuItemModel('ChildTwoItemId', 'ChildTwoDisplayName', 'category_index'));
        return $this->activateByRoute($request->get('_route'), $menuItems);
    }

Nothing more changed here (namespace of course).
After that I created my service like this:
parameters:
    my_admin_bundle.menu_listener.class: AppBundle\EventListener\MyMenuItemListListener

services:
    my_admin_bundle.menu_listener:
        class: AppBundle\EventListener\MyMenuItemListListener
        tags:
            - { name: kernel.event_listener, event:theme.sidebar_setup_menu, method:onSetupMenu }

Now If I go to my app I can see an error:
Token not found
I´m I missing something?

not sure if this helps, but for what it is worth I extended the NotificationModel, would be the same as you have done for the sidemenu, I did over write the parent construct to intialising my variables as that was giving me trouble
namespace hounded\hsBundle\Model;

use Avanzu\AdminThemeBundle\Model\NotificationModel as BaseModel;

class NotificationExtensionModel extends BaseModel
{
    protected $id;

    function __construct($message = null, $type = null, $icon = null,$id = null)
    {
        parent::__construct();

        $this->message = $message;
        $this->type    = $type;
        $this->icon    = $icon;
        $this->id = $id;
    }

    /**
     * @param mixed $id
     *
     * @return $this
     */
    public function setId($id)
    {
        $this->id = $id;

        return $this;
    }

    /**
     * @return mixed
     */
    public function getId()
    {
        return $this->id;
    }
}

I tried to do the same using yout code but I´m having the same problem
Token not found
Can you show me your model, listener and services yml ?

I found the problem. I copied the code and the namespace is in AppBundle\Model instead of AppBundle\Entity
Fixed.


first pass at converting to pytest

Coverage decreased (-1.8%) to 95.116% when pulling b24a286118b8bf506e5c00003702d1864b4624a2 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-2.2%) to 94.673% when pulling 5cb1152668d0e630c48c79ad454647fb1a2e7043 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-11.1%) to 85.784% when pulling 3e8dded5fd7836b4471fc828a151ebca332b03fe on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-11.5%) to 85.455% when pulling 01beb600ecc08e4d85e5b26acae93a47b3f1e3a9 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-14.1%) to 82.774% when pulling 9efd0b787bbcd5b65ffc3de2b673777c73b833a5 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-12.4%) to 84.484% when pulling aa977b27c5106349b494f9804dfc8d2ebfbb0ebd on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-12.5%) to 84.433% when pulling 637f9296b9a6db023a189ae94beed7abbbc1d2a0 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-12.5%) to 84.421% when pulling 9098ee655b983a2c53beb39f45c81c9e3be2bcf3 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.

Coverage decreased (-12.5%) to 84.421% when pulling 3ae02b265eefaa4bd2889f8f500af2393e84a495 on phobson:pytest into c5dd8b3dc537ee747ec93663467d7d22a4756613 on Geosyntec:master.


[AutoPR frontdoor/resource-manager] 2019 08 01 rules engine

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6962

(message created by the CI based on PR content)


[BUG] Matvis does not work with CUDA 12

Attempting to run matvis with GPUs using CUDA 12 produces this error:
/opt/devel/rbyrne/envs/py310/lib/python3.10/site-packages/pycuda/cuda/pycuda-helpers.hpp(17): error: expected a ";"
    {
    ^

kernel.cu(119): error: identifier "lerp" is undefined
          lerp(Agrid[origin], Agrid[origin + 1], fx),
          ^

kernel.cu(118): error: identifier "lerp" is undefined
      Asrc[pol * nbeam * nsrc + ant * nsrc + src] = lerp(
                                                    ^

At end of source: error: expected a "}"
kernel.cu(1): note #3196-D: to match this "{"
  extern "C" {
             ^

46 errors detected in the compilation of "kernel.cu".
]

I've attempted a workaround by installing CUDA 11 with conda but it hasn't worked. The installations I performed were:
conda install -c conda-forge cudatoolkit=11
conda install -c conda-forge pycuda
conda install pytorch torchvision torchaudio pytorch-cuda=11.8 -c pytorch -c nvidia
The resulting error traceback is:
pycuda.driver.CompileError: nvcc preprocessing of /tmp/tmp9gepm5pa.cu failed
[command: nvcc --preprocess -arch sm_86 -I/opt/devel/rbyrne/envs/py310/lib/python3.10/site-packages/pycuda/cuda /tmp/tmp9gepm5pa.cu --compiler-options -P]
[stderr:
b'cc1plus: fatal error: cuda_runtime.h: No such file or directory\ncompilation terminated.\n']

Thanks @rlbyrne. The issue with CUDA 11 seems to be an environment issue with your system. It would be good to get matvis working with CUDA 12 though, so I will look into that. Unfortunately, this is beyond what my current schedule can handle, so it might be a few weeks. How urgent is this? I wonder if we can find a workaround.

Hi @rlbyrne . To clarify @steven-murray reply a bit, yes, matvis currently only works with CUDA 11 because the GPU code is developed in that version.
As for your error, it indeed seem to be a compiling issue coming from nvcc. Do you have this command after installing cudatoolkit and pycuda. This stackoverflow post suggests that cudatoolkit installed through conda-forge doesn't have nvcc, but the one install from nvidia channel does. I would check on that.
The version of the CUDA driver on your system also matter. On an HPC, I have to load the correct version of CUDA driver, usually with the module load cuda=11 command, for example.

@piyanatk I'm trying to install cuda via the nvidia channel (conda install cuda -c nvidia), but the environment solve has been hanging for hours.
The module load cuda=11 command errors with message Lmod has detected the following error:  The following module(s) are unknown: "cuda=11"

@rlbyrne I am not sure about the issue with installing from nvidia channel ... maybe switch to mamba? It solves the environment a lot quicker. On your base environment, just install mamba from conda-forge channel. Then, you can pretty much use it as a replacement for conda
For loading the driver with module, you must check with module avai command first if the software is installed in the system and which versions are available. I also made a mistake in my previous post - module, at least on the HPC I am using, use / to indicate the version, so I would have to do something like, module load cuda/11.8.0_520.61.0, for example.

@piyanatk I don't see any cuda packages under module avail. Running the cuda installation with mamba worked, but I am still getting an error (traceback 71 errors detected in the compilation of "kernel.cu".)

@rlbyrne Can you check your cuda version that mamba has installed, mamba list | grep cuda. I am suspecting that it is version 12. Also, do which nvcc to check that it point to the cuda install through mamba and not other ones in the system.
BTW, are you running matvis through hera_sim?

@rlbyrne. OK. I got it working without the system CUDA installed.
mamba create -n <env_name> python=3.11
mamba activate <env_name>
mamba install -c nvidia cuda=11 cuda-python=11 cuda-nvcc=11 cuda-toolkit=11
mamba install -c conda-forge numpy=1.26.4 pyuvdata=2.4.5 pycuda
pip install matvis[gpu] hera_sim[gpu] pyuvsim pyradiosky

It turns out that if you only install cuda=11, it doesn't install version 11 of the other required libraries and compiler. Luckily the library is packed into the cuda-python package, so we don't have to manually install version 11 of every library.
Although not cuda related, numpy and pyuvdata versions here are important because we do not support Numpy 2 and pyuvdata 3 yet
@steven-murray We should update the package requirements until we have time to update to CUDA 12. I will make an environment file for GPU installation and put it somewhere, also update the documentation if I can find time.

Hey @piyanatk, yes that would be much appreciated! There is a PR open for hera_sim to make it compatible with numpy2 and pyuvdata 3, so hopefully it will be merged inside the week. A GPU environment file would be very useful (even if it does go out of date rather fast).

Ok things are looking promising! I think the job is running. Thank you @piyanatk

Unfortunately running things with the GPUs didn't speed things up at all. A single time and frequency step for the OVRO-LWA took 140 minutes with the GPU setting and 132 minutes without, so actually slower with the GPU setting. Any idea what's going wrong?

@rlbyrne Can you please share the command that you use?

@piyanatk I'm just setting use_gpu=True. Is there something else I need to be doing?
The full call is
matvis.simulate_vis(
          ants=antpos,
          fluxes=m3.stokes[0].T.to_value("Jy"),
          ra=ra_new,
          dec=dec_new,
          freqs=freqs,
          lsts=np.array([lst.to_value("rad")]),
          beams=beams,
          beam_idx=beam_ids,
          polarized=True,
          precision=2,
          latitude=location.lat.rad,
          use_gpu=True,
)

@rlbyrne I think the bigger question is what is the configuration of your simulation? How many baselines and sky sources/pixels? And also are your beams analytic or UVBeams, and if UVBeams, how many pixels? For some smaller simulations (per time and freq) the overheads are dominant and GPU isn't that useful.

You could also try running some line-profiling to see what the dominant bottleneck is. You can also check out the matvis profile command with your setup-size to see if it reflects what you're seeing (though it currently has the limitation that if you're working with a simulated beam model, it only profiles with a low-res model, which under-estimates the beam-interpolation part of the calculation).

@rlbyrne I want to also suggest using the wrapper in hera_sim to run matvis. It takes puuvsim style configuration file and works with any array and telescope configurations. The command line tool hera-sim-vis.py also has a build in profiling options.

The simulation has 1 time, 1 frequency,  62,128 baselines, and I would estimate 1,572,864 "sources" (pixels in the hemisphere for a Healpix map with nside 512).
I do suspect the beam size has some impact. I was previously using a lower resolution beam and things were running faster, although I didn't actually profile the speed. I can try downsampling the beam and hope it doesn't have much impact on the result. Does matvis support any other beam formats that could run faster? Like a Gaussian decomposition?
I haven't worked with pyuvsim configuration files. Is that expected to speed things up?

Sorry to be late on this again -- I was on vacation. I agree with @piyanatk that for the simulation size you're using, there should be significant speed up with GPU, so I'm not quite sure what is going on here.
Is your beam on a rectilinear alt/az grid or in healpix? I am assuming the former because currently the GPU version of matvis can't handle the latter. Also, if you're using the same beam for each antenna, make sure you specify only one unique beam in the beam list (and use the same beam index for each antenna).
For this size of simulation with a single unique beam, I wouldn't expect to the beam interpolation to be the bottleneck, but rather the single big matrix multiplication. This should be much faster on the GPU no matter how you slice it.


Adjust generators to my preferred style

I hope you agree :)

use $injector.get() instead of underscores (_)
remove the tests that we don't use right now
ngInject is needed almost everytime
Object.assign is a simple shorthand to initialize the class

Current coverage is 96.46% (diff: 100%)

Merging #137 into master will not change coverage

@@             master       #137   diff @@
==========================================
  Files            77         77
  Lines          1104       1104
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1065       1065
  Misses           39         39
  Partials          0          0

Powered by Codecov. Last update 9e3af5a...5d896b8