Need error if json has missing value for constructor argument instead of passing null and ignoring DefaultValueHandling (v7.0.1+)

It is extremely nice that Newtonsoft.Json deserialization works with immutable objects that needs all input to passed to the constructor.
However there are problems in v7.0.1 when the input json to deserialization lacks data. Right now Newtonsoft.Json will just pass "null" for constructor arguments where data is missing - regardless of how how NullValueHandling, DefaultValueHandling and MissingMemberHandling is configured. I would like to force errors to occur if data for constructor arguments is missing. Hence, I would have expected DefaultValueHandling.Ignore to work for constructors but this setting is ignored. Regardless of what this is set, Newtonsoft.Json pass null to the arguments in my constructor that has no data in the json input. I suspect DefaultValueHandling to be tested only for deserialization using properties and not for when using constructors.
P.S. Newtonsoft.Json's support for immutable objects could also be better advertised. Right now this super-feature is a bit of a secret.

Use Required

Thanks for the tip. However, it is quite invasive to add '''[JsonPropertyAttribute(Required=Required.Always)]''' to all my properties In all my classes so I would very, very, very much prefer if DefaultValueHandling.Ignore would work for constructors also so I could centrally make sure that NewtonSoft do not try to call my constructors will null arguments.

I'm with @bluemmc here. It's not practical to mark every constructor argument with an attribute.
Regardless of whether objects are deserialized via properties or constructor parameters, I'd really like to see a new JsonSerializerOption called ExtraMemberHandling that would work just like MissingMemberHandling, except that instead of checking for cases where there are JSON properties that don't have a matching type property or constructor parameter, it would check for cases where there are type properties or constructor parameters that don't have a matching JSON property.
I basically want a simple way to guarantee that there is a one-to-one match between constructor parameters and JSON properties (or between type properties and JSON properties).
I'd be happy to make this a separate feature request if you think it's worth considering.

I have the same problem, using the following (A) to serialize and (B) to deserialize, I get null exception with the parameter passed in (C) 'flagNums' is null. Need way to supply value to this parameter. Thank you for your help in advance. -Kevin
(A-serialize settings)
           jsonSettings.TypeNameHandling = TypeNameHandling.Objects;
           jsonSettings.TypeNameAssemblyFormat = System.Runtime.Serialization.Formatters.FormatterAssemblyStyle.Simple;
           jsonSettings.PreserveReferencesHandling = PreserveReferencesHandling.Objects;
(B-deserialize settings)
           TypeNameHandling = TypeNameHandling.Objects,
           PreserveReferencesHandling = PreserveReferencesHandling.Objects,
(C-deserialize null parameter exception)
        public Foo( IIndex<Ctrl.FNum, ICtrl> flagNums )
        {
            _ctlrFlag6 = flagNums[ Ctrl.FLAG_6 ];


ruby187: clean up and vendor in rubygems

Adapt the formula to make it behave as much as reasonably possible like the core Ruby formula. Vendor in an up-to-date RubyGems installation to make the formula more useful and put Gems outside of cellar to retain them across reinstalls. Consequently, also set Gem binary directory to HOMEBREW_PREFIX/lib/ruby/gems/ABI_VERSION/bin, so that wrapper scripts also are retained. (And inform user about this location in caveats.)
Reduce some code duplication by introducing program_suffix and rubygems_bindir. Also make some minor stylistic adjustments, use a HTTPS download URL, add a description, and slightly beef up the test.
Work around a breakage with superenv, where the Homebrew compiler wrappers are broken because RUBYLIB/RUBYOPT is set in build system.
Fix test if option --with-suffix is specified.
Fix installation of documentation with option --with-doc.
Note: I picked quite liberally from #1017 and the Ruby formula in Homebrew core. Hope that's okay. I think I was able to resolve all outstanding issues.

@UniqMartin you are my hero :heart_eyes:

@mikemcquaid Thanks, that's a lovely thing to say! :smile: Glad I could help and thereby also scratch my own itch in getting one of my other PRs merged sooner rather than later.
While working on this PR, I also touched and tested ruby193, ruby20, and ruby21 and brought them to the same standards (resolving some issues along the way). Should I open three separate PRs or one PR with three commits? I'm personally leaning towards the latter, as that would focus the discussion and make it easier to see the bigger picture.

Should I open three separate PRs or one PR with three commits? I'm personally leaning towards the latter, as that would focus the discussion and make it easier to see the bigger picture.

I'd probably go for three separate PRs to be honest. Some of them have pretty tetchy build processes, and if one fails you end up redoing the a lengthier build over again. Mike can overrule me though.

I think one PR is fine :+1:

I have prepared #1028. The bot seems to be happy.


Add support for Servd Bundle Hash

Is your feature request related to a problem? Please describe.
The problem is that my site's caching (Servd & Cloudflare) creates a situation where the available css & js assets differ from the cached version of the manifest.json file. This renders the site without styles applied for a moment after deployment.
Servd's suggested approach to cache-busting assets is to append the SERVD_BUNDLE_HASH to the end of the asset file urls. I'd like to be able to accomplish this as it's described in their docs: https://servd.host/docs/cache-busting#using-the-bundle-hash
Describe the solution you would like
Provide a config option to append a string like ?v={{ getenv('SERVD_BUNDLE_HASH') }} to the end of the compiled assets on build.
Using rollupOptions.output in my vite.config file, I'm able to remove the Vite hash from the file name, which renders this in my site head:
<link href="https://my.ddev.site/dist/assets/app.css" rel="stylesheet">

My request is to append a string to the end of the href like so (assuming the SERVD_BUNDLE_HASH is "123456"):
<link href="https://my.ddev.site/dist/assets/app.css?v=123456" rel="stylesheet">

Describe alternatives you have considered
I've been blowing up the servd team ( @mattgrayisok & Joe ) on their intercom about configuring for Vite. The above article has 2 suggestions that would be problematic:

Clear site cache on post-deploy: this would put a large load on our server every time i push code to production as Servd would be forced to re-cache the whole site
Include historical copies of my assets: I don't think this is possible with Vite as the entire dist folder is wiped out on build
In my vite.config.js, I removed the hash with the rollupOptions.output config:

build: {
        [...]
        rollupOptions: {
            [...]
            output: {
                assetFileNames: `assets/[name].[ext]`,
                entryFileNames: `assets/[name].js`,
            },
        },
    },

Then using Ben C's (@bencroker) cloudflare plugin, I'm attempting to purge the cache when the bundle is built, with the cloudflare/purge/purge-urls console command. Unfortunately, this is also not purging the css & js files as expected after a build.
Additional context
This Vite local setup absolutely rules and I'm committed to making it work somehow. I'm certainly open to other solutions if you have thoughts. Just looking to avoid the site rendering without styles & scripts.

With the cloudflare purge not working as hoped, I'm going to attempt to manually add the scripts and styles to my staging and production environments with the string param. I've removed the hash from my vite config, and i'm adding it into the manual script & style injections like so:
{% if envIsDev %}
    {{ craft.vite.script("/app-ui/scripts/app.js", false) }}
{% else %}
    <script type="module" src="https://themodernproper.com/dist/assets/app.js?v={{ servdHash }}" crossorigin="" onload="e=new CustomEvent('vite-script-loaded', {detail:{path: 'app-ui/scripts/app.js?v={{ servdHash }}'}});document.dispatchEvent(e);"></script>
    <link href="https://themodernproper.com/dist/assets/app.css?v={{ servdHash }}" rel="stylesheet">
    <script src="https://themodernproper.com/dist/assets/app-legacy.js?v={{ servdHash }}" nomodule="" onload="e=new CustomEvent('vite-script-loaded', {detail:{path: 'app-ui/scripts/app-legacy.js?v={{ servdHash }}'}});document.dispatchEvent(e);"></script>
{% endif %}

Currently testing this option. @khalwat do you see any potential issues with this approach?

Ok. We're back to the drawing board.
I put the hashes back on to the asset files and I'm using wildcards in cloudflare to purge the cache as a post-deploy task:
cloudflare/purge/purge-urls https://mysite.com/dist/assets/*.js,https://mysite.com/dist/assets/*.js.gz,https://mysite.com/dist/assets/*.css,https://mysite.com/dist/assets/*.css.gz,https://mysite.com/dist/manifest.json

I have yet to see a broken frontend after a build. I'll keep testing.

So rather than modifying the Craft Vite plugin in some way, I think the right way to do this is to have your Vite build system bake the query string into the asset URLs in your manifest.json ala:
https://github.com/vitejs/vite/issues/5825#issuecomment-1084087519


Use another variable to track the autoplay state

When autoplay and pauseOnHover are true, it is impossible to really pause the slider because it will always re-register itself to autoplay again when the mouse moves over and away of it. To fix this, we probably need to set autoplay to false when pause is called. However, I don't think it is appropriate to change the value of autoplay internally as this is an option and shouldn't be used to track state. So in this pull request I introduce a new variable "autoplaying" to track the autoplay state.

This may be the cause of #1516.

what's wrong with:
$("button").on("click", function() {

$slider
  .slick("setOption", "autoplay", false)
  .slick("pause");

});

:question:

It really depends on how autoplay and pauseOnHover are supposed to work in this library.
To my understanding, an autoplay option means that the carousel should advance itself without calling play() manually after the carousel is initialized. Nothing more, nothing less. If this sounds sensible, then this particular autoplay option is actually synonym to something like playOnStart.
So imagine this autoplay option is really named playOnStart. It doesn't really make sense to "pause playback on mouse hovers" and "resume playback when mouse exits" because this playOnStart option is true.
When pause() is called explicitly, I expect the carousel to stop completely unless I call play() again. Moving the mouse to and out of the carousel should not trigger this play() action again. pauseOnHover should only resume playback when such pause is triggered by the same hover action.
To my observation, the root cause is that the meaning or responsibility of autoplay is being mixed up.  It is currently being used for two purposes:

to determine whether to automatically call play() on init (=playOnStart, as an option).
to track whether the current carousel is "automatically advanced" (= isPlaying, as a state flag). A carousel can be "playing" or "stopped", so this autoplay can also be set to true or false.

Great comment, and I totally agree with your reasoning, but I think it can be achieved without adding another (somewhat confusing) internal state tracker... I kind of feel it needs to be refactored completely without destroying the API. -- the current interactions between pause/play/mouse are spaghetti.
Any interest in tearing it down, and starting fresh while maintaining the public api, @tamcy ? :)

Thank you for your invitation, but as I am young to Javascript I don't think I can come up with something better than the current one. After all, proposing a fix and maintaining a library are two different stories. But I still think it is inevitable to introduce a new variable to track the playback state, of course its name can be chosen so that it isn't as confusing as the one I use in this PR. Thanks again.

no problem @tamcy  :)
and you're right, it was inevitable to add another state tracker ;) -- but I had to re-think the states.
there's paused, interrupted and focussed now, each tracking their own thing.
Sorry I couldn't get your PR merged, but don't worry about being new to JS... keep up the good work, im sure there's other stuff you can contribute to Slick! :bow: :grin:


fix(immutable-data): ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions

Fix #000
Proposed Changes

#850
#849  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on  Graphite


Bucket name is not shown inside endpoint

Environment info
[root@ocp-neha-1-inf ~]# oc version
Client Version: 4.7.0
Server Version: 4.7.0
Kubernetes Version: v1.20.0+bd9e442
[root@ocp-neha-1-inf ~]# noobaa version
INFO[0000] CLI version: 5.8.0
INFO[0000] noobaa-image: noobaa/noobaa-core:5.8.0-20210418
INFO[0000] operator-image: noobaa/noobaa-operator:5.8.0
[root@ocp-neha-1-inf ~]#
Actual behavior

Bucket object is listed but bucket name is not shown inside endpoint.
If I create another bucket at same path with new name it will have all the objects of other bucket at that path

Expected behavior

Bucket name should be created and objects should be listed inside it in endpoint pod. This "trial-buc" bucket should be created .
Two buckets data can't be copied automatically without any s3 operation performed on it

Steps to reproduce

Create a namespace resource
noobaa api pool_api create_namespace_resource '{
"name": "fs1",
"nsfs_config": {
"fs_backend": "GPFS",
"fs_root_path": "/nsfs/fs1"
}
}'

noobaa api bucket_api create_bucket '{
"name": "trial-buc",
"namespace":{
"write_resource": { "resource": "fs1", "path": "trial/" },
"read_resources": [ { "resource": "fs1", "path": "trial/" }]
}
}'

More information - Screenshots / Logs / Other output
Inside endpoint pod:
sh-4.4# [root@ocp-neha-1-inf ~]# oc rsh noobaa-endpoint-57c787988d-57wfv
sh-4.4# cd nsfs
sh-4.4# ls
fs1  fs2  neha
sh-4.4# cd fs1
sh-4.4# ls
dg  hello.txt  nsfs  test  trial
sh-4.4# cd trial
sh-4.4# ls
object.txt
sh-4.4# [root@ocp-neha-1-inf ~]#
On App node:
[root@fyreauto-x-app1 ~]# s3 ls
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2021-05-03 03:26:11 ne-there
2021-05-03 03:26:11 first.bucket
2021-05-03 03:26:11 trial-buc
2021-05-03 03:26:11 trial-buc-new
[root@fyreauto-x-app1 ~]# s3 ls s3://trial-buc
urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
2021-05-03 02:46:32          6 object.txt
endpoint.log

How did you export the trial-buc bucket and to which directory he points?

I created trial-buc bucket at path nsfs/fs1/trail and using s3 cp copied some object into it

When a created one more bucket with new name at path nsfs/fs1/trail , bucket got created and have objects of "trial-buc" into it automatically even I didn't performed any s3 operation

you mapped two buckets on the same path, so both buckets show the same object list. Am I missing something here ?

Hey @nehasharma5

directory with bucket name shouldn't be created - it was true in previous version of this feature but there was a requirement to change it and not use the same name of the bucket but the path you passed when calling create_bucket..
when you created trial-buc, you pointed to /nsfs/fs1/trial/, which is a path that already exist.
and regarding Two buckets data can't be copied automatically without any s3 operation performed on it - Nimrod is correct and you basically have 2 buckets that are pointing to the same directory so it's not copied, it's exactly the same directory.

@nimrod-becker There are two things

I created a bucket (trial-buc)on the path (nsfs/fs1/trial)which already exist on the File system and copied some object into it.  When I went to that path(nsfs/fs1/trial) , i can see the objects under it , no bucket was created with name trial-buck. Isn't it should be nsfs/fs1/trail/tria-buc and then objects should be there inside trial-buc?
I created one more bucket with different name at path nsfs/fs1/trial , when list objects of this bucket it have all objects of "trial-buc" . It should be empty ?

@romayalon as per your comment, at one path we can only have one bucket and there will no bucket name on FS path as it was there in earlier build of noobaa.

I think it boils down to blocking exporting two buckets on the same path (via the CLI, via S3 create - see PR in review, its already blocked)
@romayalon @jeniawhite WFYT? Should we just add that verification in the CLI?

Updating the title of the issue


Support for Ruby 1.8 using backports gem

Short:
Maybe use backports to support ruby 1.8.6+?
https://github.com/marcandre/backports
Long:
I am having troubles with Celluloid together with Rspec on Ruby 1.8 (which I unfortunately need to use). Somewhere in the celluloid timeline there was an api-breaking change on a 0.X or 0.0.X version, which is intended to be used for non-breaking feature additions / hotfixes only. This is probably why bundler and gems have problems when trying to install celluloid on ruby 1.8.
I believe that support for ruby 1.8 could easily be implemented with the backports gem (https://github.com/marcandre/backports). This way maybe we who are stuck in 1.8-land could enjoy some celluloid.
Forgive me if this has been addressed before, but I was not able to find that thread.

Over a year old, feeling is not to support 1.8 and other EOL versions. Closing //


Error: Forbidden send.js

Heading this problem on current version.
https://github.com/visionmedia/express/issues/1229

@doomsbuster  I fixed the issue as you. thank you very much!

It works for me too! thx

@doomsbuster also worked for me, thanks!

@doomsbuster  thx,it helps me!~


User directories (like apache's UserDir)

Search for duplicate feature request

[X] I already searched, and this feature request or improvement is not a duplicate.

Feature scope
Completely new feature
Feature request related to a problem
No response
Describe the solution you'd like
The ability to specify (in the config file) a UserDir-like directive, so that a directory such as public_html in each user's home directory could be served. Essentially, duplicate this functionality from Apache.
This isn't as common a use case as it once was, but for (for instance) a computer science department webserver, I'd love to be able to move away from Apache and to a Rust-based solution.
Describe alternatives you've considered
Stick with Apache
Build target
All targets
Additional context
No response

Very definitely should not serve every user's home directory as you point out. Ideally it would be good to support not just users but groups in the allowed/denied lists. I like the syntax you suggest, though a 'groups' key would be nice (and then use unix groups to configure who gets a public_html dir).

Certainly, group membership could be dynamic, even chaotic. But on a well-run system it shouldn't be -- set up a 'webusers' group and include appropriate regular users in it. Certainly you'd add new users over time, and add them to that group. You probably wouldn't routinely remove them from the group unless you disabled their account.
I would suspect that for performance reasons, you'd want to fetch group membership at startup or upon receiving a SIGHUP, so standard procedure when adding a new user would be to kill -HUP the webserver (or restart the daemon). Same if removing a user.
As far as a fatal error, I think that should be configurable with some sort of --paranoid flag. At the minimum, a warning should be logged.

Thanks for the feedback on this. As you discussed, I'm also in favor of being explicit when exposing user home directory content.
The configuration proposal is concise enough in my opinion, which could be extended in the future by adding opt-in directory listing, basic auth, etc per or even allowing multiple [userdir] entries per config.
About groups, I vote for fetching the group membership at startup time for performance reasons. But to keep the group membership data synced, we could go with a zero-downtime syncing approach via some mechanism like signaling (SIGNUPs) so SWS could decide whether to serve or not accordingly without restarting. Because the other option should be to restart the server on demand.
Or maybe restarting could be the option in the first stage of the eventual implementation and then enhanced with a zero-downtime syncing approach, just ideas.
Please feel free to continue discussing and suggesting.

Will do! Speaking of first stage implementation, I'd like to start
poking at it this weekend. Once I have something that seems to work I'll
make a draft PR and we can go from there. Sound good?

Sure, please go ahead and let me know if you need any help.


Helper entity for turn on/off TV

Many users with TV connected by WiFi experiencing problems with TV on/off (most cases with on). For this cases is it possible to add extra redundant (all will works as before but for on/off the component will also call homeassistant.turn_on/turn_off for this entity) settings of helper entity which will turn on/off TV?
As an example of usage, user can create switch entity which will use Broadlink IR for ON and OFF the TV and specify it as helper entity for component. Sure in this case better if user will use different IR on/off codes and not power toggle code, fortunately many TV support this.
Thanks in advance!
Edit: Because extra control usually based on IR, maybe even better to call scripts instead entity like switch, for example:
# https://github.com/yahat/broadlink_mini_homeassistant_ir_codes_samsung_tv
script:
  broadlink_samsungtv_off:
    alias: Broadlink SamsungTV Off
    mode: queued
    sequence:
      - service: remote.send_command
        data_template:
          entity_id: remote.broadlinkir_remote
          command: b64:JgBGAJOVEDoQOhA6DxYPFhAVEBUQFRA6ETkROREUERQRFBEUEBUQFREUERQRORE5EBUQFRE5ETkRORE5ERUQFRA6DzsPFhAADQUAAA==
          num_repeats: 3
  broadlink_samsungtv_on:
    alias: Broadlink SamsungTV On
    mode: queued
    sequence:
      - service: remote.send_command
        data_template:
          entity_id: remote.broadlinkir_remote
          command: b64:JgBGAJKVETkRORA6ERQRFBEUERQRFBE5ETkQOhAVEBUQFREUEBUQOhEUERQRORE5EBURFBA6EBUQOhE5EBUQFRA6EDoRFBEADQUAAA==
          num_repeats: 3

Will be nice to have.

There is an open PR for this that need some review...


F-M3-4F View evidence research

Results viewing for the final users (personalized feedback).

depends on #17

We need a mockup for this.


Implement getCacheKey

What & Why

Now, jest-preview hasn't implemented getCacheKey for css, file and fileCRA transformer.
https://github.com/nvh95/jest-preview/blob/6ce35ca37d6c9de5fc72b05ce433cb83b10b0538/src/preconfigTransform/css.ts#L1-L8
The reason is that we are not very deeply understand the benefit of getCacheKey. The [docs]((https://jestjs.io/docs/code-transformation) itself is not very detail. But we know it boosts the performance when running Jest since we're caching the transformed files.

How

We can find @swc/jest implemented getCacheKey. Let's see how they do that.
https://github.com/swc-project/jest/blob/17cf883b46c050a485975d8ce96a05277cf6032f/index.ts#L37-L52
There are some related PRs as well https://github.com/swc-project/jest/pull/32 https://github.com/swc-project/jest/pull/76
We need to benchmark to see how much users' time getCacheKey saves.

As I observe and guess, if we do not implement getCacheKey, Jest automatically cache using return value in the transformation.
For e.g: If our css transform a css file to
const relativeCssPath = "/demo/App.css";
const link = document.createElement('link');
link.rel = 'stylesheet';
link.href = relativeCssPath;
document.body.appendChild(link);

module.exports = JSON.stringify(relativeCssPath);

This whole file content will be used as the key for caching.
So what is the point of implementing getCacheKey? To get a shorter key? Do we need to do that?

How to see the cache key by yourself

Run jest --clearCache to see where the cache located. For e.g, on mac: /private/var/folders/hg/cg39z3hd4gv3grbrd08524gh0000gp/T/jest_dy
cd to that project and explore

My hypothesis: If we do not explicitly implement getCacheKey. It will use src and filename as cache key.
So, we should add transformer file content into account. So each time we upgrade the transformer. The Jest cache get cleared.


Add VFS abstraction

We would like to use redb in an environment where there is no access to a file system.
Sqlite defines a virtual file system https://www.sqlite.org/vfs.html . Maybe something similar but quite a bit simpler could be done for redb.

Have you tried patching the PagedCachedFile struct? I'm not familiar with the details of Sqlite's VFS, but that's probably similar

Following up on this, I started looking into what it would take, and got this branch going https://github.com/dignifiedquire/redb/tree/feat-file-abstraction
The good news: the surface are of the API is quite small overall, as you can see here: https://github.com/dignifiedquire/redb/blob/feat-file-abstraction/src/file.rs
The bad news: because this goes all the way through, if I want to avoid boxing, the generic ends up invading everywhere.
Would love to hear your thoughts about if there is a direction of this that you would consider merging eventually.

If it requires a new generic parameter everywhere, I won't want to merge that.
If boxing doesn't add noticable overhead, I'd be open to considering that. I'd like to hear more about the proposed use cases though to be sure this is valuable enough to warrant adding support to redb, vs people just patching PagedCachedFile in their own fork


pt-BR Localization

I helped localize pt-BR.js – Português (Brazil). The updated file is attached.
SugarCube-pt-BR.zip
I'd also like to translate the SugarCube docs into Brazilian Portuguese. My e-mail<EMAIL_ADDRESS>

Thanks.

As to translating the docs.  I don't have a issue with it in general, but I do have some concerns:

I ask that you wait a bit.  The docs currently have some issues that need to be addressed.
I'm worried that the translation won't be kept up to date.  An out of date translation is often worse than no translation.  If you decide not to keep it updated at any point I ask that you let me know so I can remove it.

Other than those issues feel free.
PS: I'll let you know when it's good time to start.

I completely agree with your concerns, and I recognize that I might not be
able to keep the translation consistently updated. Given this, I think it’s
best to focus on maintaining tutorials instead.
Thanks
Em sex., 16 de ago. de 2024 às 16:39, Thomas M. Edwards <
@.***> escreveu:

As to translating the docs. I don't have a issue with it in general, but I
do have some concerns:

I ask that you wait a bit. The docs currently have some issues that
need to be addressed.
I'm worried that the translation won't be kept up to date. An out
of date translation is often worse than no translation. If you decide not
to keep it updated at any point I ask that you let me know so I can remove
it.

Other than those issues feel free.
PS: I'll let you know when it's good time to start.
—
Reply to this email directly, view it on GitHub
https://github.com/tmedwards/sugarcube-2/issues/322#issuecomment-2294102277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKHWDWJECBNY6IY74R3D3K3ZRZIP7AVCNFSM6AAAAABLREYNSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUGEYDEMRXG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Failing to start API, bind can't assign the requested address

Failed to start API listen tcp <IP_ADDRESS>:8080: bind: can't assign requested address
System: Mac OS X, 64 bit
Dockerfile and build.yml file are in the same directory
Command that I tried to run is:
habitus --build host=<IP_ADDRESS> --secrets=true --binding=<IP_ADDRESS>
Changing the ip inputs in both arguments still resulted in the same error
Omitting both ip arguments and keeping secrets still resulted in the above error.

It works with <IP_ADDRESS>

hi @spacether  good to know you figured it out.  <IP_ADDRESS> is just an IP address as an example. when you run habitus on macosx you can bind to <IP_ADDRESS> or the IP address of your network interface.


Select top 1000? how can I change this number?

It would be nice to be able to set manually the count of top X records to be selected.

Azure Data Studio Version:
Version: 1.11.0
Commit: 460c739a8d90bdbbde39e01abfb8ecdc278ea787
Date: 2019-09-06T17:14:33.682Z
VS Code 1.37.0
Electron: 4.2.9
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:
right click on any table

I know this is 2 1/2 years old, but I also would like this. I don't always need 1000 rows - 10 to 100 would be fine.

would also be cool to have in the context menu:
select top 100 * from xy order by 1 desc
maybe something like this already works and I don't know. but own commands in the context menu with variables for tables, etc.

I also would like this as most of the issues referencing it get closed and then recreated at a later point.

I had commented in #19221, but please also allow a value of 0 = no TOP clause.


Pin cirq_rigetti pyquil dependency to pyquil-3.*

Problem: pip install cirq --pre may install pyquil-4.0.0rcN which is
incompatible with cirq_rigetti.
Solution: pin the pyquil dependency to "3.*".

Do you know what's causing the incompatibility? We should also reach out to cirq-rigetti maintainers and see if they can fix the dependency issue.
I've also run into a few issues like https://github.com/rigetti/qcs-api-client-python/issues/9 that causes introduces transitive constraints for us which seem unnecessary.
cc @dabacon @dstrain115  Can we reach out to a cirq-rigetti owner and ask for a comment? Maybe Josh?

This should also unblock our nightly builds of API docs, which currently fail on inconsistent installation of cirq_rigetti.

Do you know what's causing the incompatibility?

pyquil-4.0.0rcN uses qcs-sdk-python instead of qcs-api-client which is assumed by cirq_rigetti.
While pyquil has no stable release 4, pip install --pre ... enables its rcN versions.

Can we reach out to a cirq-rigetti owner and ask for a comment?

That's a good idea to ask them to adjust cirq_rigetti for the upcoming pyquil-4.


Finish 2D Barcodes

Hey mate, im using your code and have to say it is pretty useful and working as intended.
Any chance to get this issue done?

Yeah, it's been worked on. @Lexinek, just curious, are you more interested in QR or DataMatrix?

Definitely QR for me.

Cool, I'm going to put this on my immediate roadmap. I've needed to finish this for some time now.

👍Thumbs-up from me! Great work so far!

i vote for this.


Vulnerability roundup 77: lz4-1.9.1: 1 advisory

search, files

[x] CVE-2019-17543 (nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.09: 5f506b95f9f; nixos-unstable: c1966522d7d. May contain false positives.

See PR #82437.


[Databricks Connection] Support connection endpoint to databricks environment

Add support in Perseus for Databricks Spark SQL

Are there any details on what the challenges are for working with Databricks? I have a good deal of experience with Databricks, I'm still familiarizing myself with Perseus (and ETL-CDMBuilder which I suspect may be the relevant technology). I'd be happy to lend a hand.

Thank you Nathan! The main long-term goals are to have 1) CDMBuilder and 2) running the actual ETL migrated to Databricks itself, instead of it being ran locally through Perseus's embedded code. As a first step, having an export feature that would generate a DBC file to be sent to Databricks

Putting together an SPIP doc would be great! The process for feature request and documentation has been very ad-hoc up to this point, so this would be a good opportunity to increase structure.
As for audiences I'm not sure what the best choice would be. @paulnagy has been a defacto person to talk to for higher-level decisions, so we could potentially have talks with him to discuss outputs

Thank Zack. This may be naive, but it's something to start with. @Zwky26 @paulnagy (and any other stakeholders) Is this roughly what you have in mind?

https://mermaid.live/edit#pako:eNp9VWtv2jAU_SuWVbVBooxHSBnSNK0EaVQwWFP2EtJkkgtkTWJmOx1ZxX_ftc2rjJIv8eOee869Pk6eacgjoG3acTs8U7BSk4zgo2KVABmBkJBLcg8JPLFMEZ8pRoJCKkilDdQhPHOWemeAqZIERJlM6FiCINfkyiC2G1fO-9KEbrblLr3iJBTAFBCWkeFgOCIdf1CZ0JKluOV5FjFRONPhIpKxhg8_-kHPZhoGAemGXBpRiCHPFqUfq9SRYwPa0hlpPSxWzFgIxBn3NqIeFkDGPTLjwuqJszlJ2XKJb4nSIhLBMuGFXv7Fp0a3QkikS5yy8BGySO5l7wX87K6UI7sq6UTpbR4nkW1R96GvCyWbpR1wfVR2pHs4SphCYanUSNPU3YoV_wXZuZCvdEAjpiIOH3d4O7PYbSpTupZ1ST5kLClUHEriXJIYmzUX2BCe4Zgwgi0JF6XKecmB4gL2eu30pD5_igohUcwE64HVZXB99ggGzOZwqrv-1PZ3xKWaCwh-J6akzexz_wwEYwMQT_Y4MJTY2WFZdoAX4NjiG1PhrZnF8xwrMw7xjUMkGWxss0s1XqJNAPMEqkjgZLILPptJUN_fTeh1s7pDam6z_7-DAu24rUVJaKQQ5y4Yfiq9Rnwy0yHzzSnml_axtP5tB31yhxfhPNchdkP0DYnqRzxHko6O8x5Y9OariBWcR7040ddAh4r2vjuKPqyozwqeK3vUzkXoBgu2hF52z_9gIQ3tVVzcmn-7XsM0tExTECmLI_zEGttPKH4yUqRo43DKJI4m2RrjWK54UGQhbSuRQ5nmhtmPGV68lLZnLJG4umTZD85fzGn7ma5o-6ZV8epuw2u16u5Ns1Zzy7Sg7Wu3UWlU3Va93vI8r-ri1rpM_5oUtUq16jZqzWqt5TUbLe-tV6YQxXjTBvafYH4N63_TePW-

(Draft)
Q1. What are you trying to do? Articulate your objectives using absolutely no jargon.

We are enabling Perseus to scan Delta data sources by running jobs in a Databricks workspace.
We are using the mappings created by the Perseus UI to create ETL jobs in a Databricks workspace using Delta.

Q2. What problem is this proposal NOT designed to solve?
This is not a solution for migrating from one data store to another (ex. Postgres to Delta). For that, a dedicated “lift and shift” data migration solution would be recommended. This would better address concerns like incremental data load with CDC, etc.
Q3. How is it done today, and what are the limits of current practice?
(Apparently, input welcome)

The scan is either imported from White Rabbit, or performed by the “source_schema_service” that is part of the “perseus-api”.
The mapping is encoded as a JSON and sent to the ETL-CDMBuilder to execute on the underlying data sources.

Q4. What is new in your approach and why do you think it will be successful?

A Databricks job will be written to execute a scan report. The job can be executed by the “perseus-api" just like today.
A Databricks job will be written that can take the mapping and execute on Delta using Spark.

Q5. Who cares? If you are successful, what difference will it make?
This will make CDM’s created by Perseus more scalable and give access to the analytic toolkit available using Spark and Delta.
Q6. What are the risks?

The existing solution combines integration and ETL functionality. That’s not a solution that will scale very well. The recommendation would be to isolate integration functionality, “lift and shift” to the preferred platform, then perform ETL on that platform. This may cause some confusion with the ETL-CDMBuilder processes.
Typically, the ETL job would be triggered from a back end service, not a UI. No analogous endpoint exist today in the Perseus API.

Q7. How long will it take?
1 - 3 person months

1 - 3 person weeks for the scan job
1 - 3 person weeks for the ETL job
1 - 3 person weeks for integration with Perseus UI & back end.

Q8. What are the mid-term and final “exams” to check for success?

Scan job in isolation
Scan job via Perseus
ETL job in isolation
ETL job via Perseus

After parsing through the code and understanding the system design a bit better, this would seem to be blocked on https://github.com/OHDSI/WhiteRabbit/issues/334 I will look in to that issue more closely. (barring any input on how this could be useful without the ability to scan delta tables)

@ssamus @Zwky26 I've been hacking on this. I have a question about the Perseus backend. The Databricks integration requires some support on the backend, but the version of Pandas is a bit outdated, and not supported by the Databricks libraries. Are there thoughts on whether it makes sense to stand up a separate service vs updating pandas?


Gateway pinger goroutine is not shutdown on Close()

I have created a PR to fix this issue: #9

For the moment, rather than merge the associated #9  PR into this repo, I have decided to keep the numerous changes separate.
You can explore this repo to see if it better suits your needs:
https://github.com/cameronelliott/janus-go
The main goal is to get to a high level production usability.


Bind mount /etc inside the snapshot

If MicroOS is used, the /etc/crypttab version inside the snapshot /etc can be a base that is actually modified via an overlay.  This is the case when during the enrollment we add the use of TPM2.
When dracut is called via --sysroot, it will use the unmodified version of /etc/crypttab, generating an initrd that will not contain the TPM2 libraries (/usr/lib64/cryptsetup/libcryptsetup-token-systemd-tpm2.so), failling the open of the LUKS2 device.
This commit bind mount the external current /etc inside the snapshot, making it visible for dracut to generate a current valid initrd.

We'd need to bind mount the overlay that belongs to the given snapshot though, right? Just using the current one would not work for arbitrary snapshots.

So far it's in fstab but should be changed IMO (https://github.com/openSUSE/transactional-update/issues/117)

@laenion we need a way to get a fully set up snapshot in order to generate arbitrary initrds from it. Short of https://github.com/openSUSE/transactional-update/issues/117 which would allow us to parse the info ourselves, can we get a function from tukit to either return the underlay dirs or mount an existing snapshot properly right away?
After all it can set up new ones which is a very similar operation, just with an additional subvol clone?

For completion. @laenion suggested this too:
tukit --continue=2 open; tukit call 3 <your commmand>; cp bla somewhere_else; tukit abort 3

@lnussel updated the PR.
This one mount the overlays as read-only. It takes the upperdir and prefix it into the lowerdir list, so it can avoid to set the upper and work directories during the mount.  This seems to stabilize the overlay.
Seems that mounting /var is not required.
Some observations (for a MicroOS with two snapshots):

When running from snapshot 2 to generate the initrd of snapshot 1 (sdbootutil add-all-kernels 1) I can see this kind of error during the execution of dracut.  Today I can see this error also using the original mount --bind, that was not present last week. So I am not sure if it is related with this change or not.

find: warning: ‘-name’ matches against basenames only, but the given pattern contains a directory separator (‘/’), thus the expression will evaluate to false all the time.  Did you mean ‘-wholename’?
...
gzip: /var/tmp/dracut.LRh5HK/initramfs/.snapshots/1/snapshot/usr/share/kbd/keymaps/i386/qwerty/es.map.gz: No such file or directory
gzip: /var/tmp/dracut.LRh5HK/initramfs/.snapshots/1/snapshot/usr/share/kbd/keymaps/xkb/es.map.gz: No such file or directory

When removing the current kernel from the second snapshot (sdbootutil remove-all-kernels) I see this error if I recreated the entries for the first snapshot:

opensuse-microos-6.6.11-1-kvmsmall-2.conf is the default boot entry
opensuse-microos-6.6.11-1-kvmsmall-2.conf is the selected boot entry
Removed "/boot/efi/opensuse-microos/6.6.11-1-kvmsmall/linux-4190f9a56e931d4394b78c1917e9ff1e3f50c212"
Removed "/boot/efi/opensuse-microos/6.6.11-1-kvmsmall/initrd-58015452d169f1d55382cdafa3004b08e4152103"
Removed /boot/efi/loader/entries/opensuse-microos-6.6.11-1-kvmsmall-2.conf
Fatal: Unable to open file /tmp/efimnt.ZlWJLC//opensuse-microos/6.6.11-1-kvmsmall/linux-4190f9a56e931d4394b78c1917e9ff1e3f50c212: No such file or directory
Error: Failed to install TPM predictions for opensuse-microos-6.6.7-1-kvmsmall-1.conf

The code assumes there is only one lowerdir. AFAIK there could be many, even though t-u nowadays tries to fold them

No, multiple lowerdirs are separated by colon: lowerdir=dir1:dir2:...[1]. The current code is using this, removing the sysroot and adjusting the base lowerdir (the last of the list).
The code is based on how t-u does something like this: https://github.com/openSUSE/transactional-update/blob/master/sbin/transactional-update.in#L339
[1] https://docs.kernel.org/filesystems/overlayfs.html#directories


Document: CORDOVA_JAVA_HOME environment variable

As pointed out by https://github.com/apache/cordova-android/pull/1229#issuecomment-1493993119
The CORDOVA_JAVA_HOME is not documented as an option. CORDOVA_JAVA_HOME will take precedence over JAVA_HOME if set.
The feature was added in v10 of cordova-android.

This is other issue however, as for sure JAVA_HOME works not only on Windows, but macOS as well.
I bet specific OS should be omitted.

For sure... I didn't change what was already, there I just appended. However this is definitely true and I think this is a good opportunity to address that. Thank you for pointing that out.

It is live at https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#java-development-kit-jdk
And it feels like it should be moved to section https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#setting-environment-variables

It is live at https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#java-development-kit-jdk
And it feels like it should be moved to section https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#setting-environment-variables

I would... also agree with that. A PR is welcome to move it.


Backup of dirs with spaces still not working

$ ./rustic -V
rustic v0.5.1

$ ./rustic -P test backup
using config ./test.toml
[INFO] repository local:/home/piotr/rustic_test: password is correct.
[INFO] using cache at /home/piotr/.cache/rustic/bcbb400559f5e2d884f009f8f2be955e401245d14ac73bc8607b7bc0db3d4e79
[WARN] error sanitizing source="/home/piotr/dir with spaces" in config file: No such file or directory (os error 2)
[INFO] using all backup sources from config file.

$ ls /home/piotr/dir\ with\ spaces/
drwxr-xr-x  1 piotr piotr    4 2023-03-31 19:10 .
drwx--x---+ 1 piotr piotr 1.1K 2023-04-14 11:16 ..
-rw-r--r--  1 piotr piotr    0 2023-03-31 19:10 aa

Can you show how you defined the source in your config file?

[[backup.sources]]
source = "/home/piotr/dir with spaces"

If you specify the source in this way, rustic wants to backup 3 directories: "/home/piotr/dir", "with", "spaces". As multiple dirs are allowed as source and those dirs are separated by a space, dirs with spaces needs to be wrapped, e.g.:
[[backup.sources]]
source = "'/home/piotr/dir with spaces'"

or
[[backup.sources]]
source = '"/home/piotr/dir with spaces"'

(note the order of ' and " is swapped)

Oh i see. Yes now it's working, thanks!
On unrelated note, not sure if its only me, but i'm getting repetition of messages even when rustic is run directly from the terminal:

Thanks for the feedback.
About the progress messages: The progress bars by default update 10 times per second. It seems that in your case each update gives a new line.
If the width is a problem, try with a wider terminal. In any case there are the options --no-progress and --progress-interval available to modify progress bar behavior.
I'm closing this "dirs with spaces issue" as resolved.

Sure thing. Thanks again!


[bug]: New outpainting code doesn't work as well as expected

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
32G
What happened?
@Kyle0654 Try as I might I can't get the new outpainting code to work as well as well as my original version did. I have modified the outcropping.py code to do the following:

Extend the image by the selected number of pixels (I'm testing with 64)
Make the extended border pure black
Convert the image into RGBA
Make the extended part of the image completely transparent (alpha 0)
Pass to generate() with the following options:

     - init_img = the extended image
     - seam_size = 32
     - seam_blur = 10

I'm not passing an additional mask.
I've tried a variety of settings, including using the defaults for seam size and blur, but I'm getting terrible discontinuities. In the screenshots below, the first three were generated using my original inpaint code. The second set of three were generated by the new inpaint code.
I'm also including the RGBA image that is passed to init_img and its RGB counterpart.
I hope you can help me with this. Since the only use case for outpainting right now is the outcrop function, I would be tempted to revert the code, or just keep the color matching part, if this is not just user error on my part.
Screenshots
Original inpainting code, using the outcrop function:

New inpainting code, using outcrop:

The masked and unmasked images passed to inpainting:

Additional context
No response
Contact Details
No response

Here's a couple of 64 pixel outpaints. Random seed, 96 pixel seam_size, 16 pixel seam_blur (SD-1.5).

Are you setting force_outpaint to True or passing a full white init_mask? I wonder if it's skipping the outpainting and just trying to inpaint. Though event with force_outpaint set to False I get this:

That may just be my seam size being really large though (A small seam doesn't help much).

I'll try the larger seamsize. force_outpaint actually doesn't do anything
except suppress a warning from Generate that "colors were erased" from
beneath the transparent region, which of course is the intent of
outpainting.
Lincoln
On Mon, Oct 31, 2022 at 12:44 AM Kyle Schouviller @.***>
wrote:

Here's a couple of 64 pixel outpaints. Random seed, 96 pixel seam_size, 16
pixel seam_blur (SD-1.5).
[image: result_1667191106 989473]
https://user-images.githubusercontent.com/1947631/198932372-aa7e46fd-47c0-4363-8e95-6f90a4745eb9.png
[image: result_1667191215 316071]
https://user-images.githubusercontent.com/1947631/198932374-c6708d57-d497-4623-933f-73193fb2e3b0.png
Are you setting force_outpaint to True or passing a full white init_mask?
I wonder if it's skipping the outpainting and just trying to inpaint.
Though event with force_outpaint set to False I get this:
[image: result_1667191383 429578]
https://user-images.githubusercontent.com/1947631/198932744-20c142d6-fe04-4595-9bbf-e0900dfcd181.png
That may just be my seam size being really large though (A small seam
doesn't help much).
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296536125,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVKWAYFPKSRF4NWPRSLWF5FDPANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

I passed your masked image in and got this out:

    test = Image.open('.scratch/test_outpaint_bug.png')
    prompt = "a woman with curly red hair in a forest in the snow"
    r = generate.prompt2image(
        prompt = prompt,
        steps = 50,
        init_img = test,
        init_mask = None,
        strength = 0.9,
        fit = True,
        color_match = True,
        seed = None,
        width = 512,
        height = 512,
        cfg_scale = 7.5,
        sampler_name = 'k_lms',
        seamless = False,
        inpaint_replace = 0.0,
        seam_size = 96,
        seam_blur = 16,
        seam_strength = 0.7,
        seam_steps = 20,
        tile_size = 32,
        force_outpaint = True
    )[0][0]
    r.save(f'outputs/test/result_{datetime.now(timezone.utc).timestamp()}.png', 'PNG')
    r.show()

I'll try adding the seam_steps and tile_size options as well.
On Mon, Oct 31, 2022 at 12:50 AM Kyle Schouviller @.***>
wrote:

I passed your masked image in and got this out:
[image: result_1667191768 115792]
https://user-images.githubusercontent.com/1947631/198933441-268efaf5-cf5c-4e03-8631-fa126aab3425.png
test = Image.open('.scratch/test_outpaint_bug.png')
prompt = "a woman with curly red hair in a forest in the snow"
r = generate.prompt2image(
    prompt = prompt,
    steps = 50,
    init_img = test,
    init_mask = None,
    strength = 0.9,
    fit = True,
    color_match = True,
    seed = None,
    width = 512,
    height = 512,
    cfg_scale = 7.5,
    sampler_name = 'k_lms',
    seamless = False,
    inpaint_replace = 0.0,
    seam_size = 96,
    seam_blur = 16,
    seam_strength = 0.7,
    seam_steps = 20,
    tile_size = 32,
    force_outpaint = True
)[0][0]
r.save(f'outputs/test/result_{datetime.now(timezone.utc).timestamp()}.png', 'PNG')
r.show()

—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296539858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMI6SUKON4VSB5OCDDWF5F2ZANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

My tile_size should be the default. I doubled seam_steps, but I've seen 10 do well. Are you running this through the CLI, or through code? I haven't tried it through the CLI yet.

Through the CLI using the outcrop command. It creates an image with the
black border and alpha channel I pasted into the initial report and then
right to generate.prompt2image using pretty much the same options you
provided just now.
On Mon, Oct 31, 2022 at 12:55 AM Kyle Schouviller @.***>
wrote:

My tile_size should be the default. I doubled seam_steps, but I've seen 10
do well. Are you running this through the CLI, or through code? I haven't
tried it through the CLI yet.
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296542225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVJ62X5M46XWVUDDIFTWF5GN7ANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

What do you prompt it with? I got this running !fix .scratch/test_full_outpaint_nomask.png --outcrop top 64 right 64

It's roughly coherent, though there was no prompt for me to give it (unless it pulls it from the metadata and I just don't have that on my image?)

It pulls the prompt from the metadata.
On Mon, Oct 31, 2022 at 1:02 AM Kyle Schouviller @.***>
wrote:

What do you prompt it with? I got this running !fix
.scratch/test_full_outpaint_nomask.png --outcrop top 64 right 64
[image: test_full_outpaint_nomask 942491079 outcrop]
https://user-images.githubusercontent.com/1947631/198934676-3372beee-1787-4335-b75e-2d66518470a1.png
It's roughly coherent, though there was no prompt for me to give it
(unless it pulls it from the metadata and I just don't have that on my
image?)
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296545394,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMAPPA33NFALCVXQALWF5HHNANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

The original prompt and seed are: "pretty curly-haired redhead woman"
and 942491079
L
On Mon, Oct 31, 2022 at 1:02 AM Kyle Schouviller @.***>
wrote:

What do you prompt it with? I got this running !fix
.scratch/test_full_outpaint_nomask.png --outcrop top 64 right 64
[image: test_full_outpaint_nomask 942491079 outcrop]
https://user-images.githubusercontent.com/1947631/198934676-3372beee-1787-4335-b75e-2d66518470a1.png
It's roughly coherent, though there was no prompt for me to give it
(unless it pulls it from the metadata and I just don't have that on my
image?)
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296545394,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMAPPA33NFALCVXQALWF5HHNANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

Also still getting some shadowing in plain inpainting. This is from the
preflight checks, and a couple of people have pointed out the problem.
[image: image.png]
On Mon, Oct 31, 2022 at 1:10 AM Lincoln Stein @.***>
wrote:

The original prompt and seed are: "pretty curly-haired redhead woman"
and 942491079
L
On Mon, Oct 31, 2022 at 1:02 AM Kyle Schouviller @.***>
wrote:

What do you prompt it with? I got this running !fix
.scratch/test_full_outpaint_nomask.png --outcrop top 64 right 64
[image: test_full_outpaint_nomask 942491079 outcrop]
https://user-images.githubusercontent.com/1947631/198934676-3372beee-1787-4335-b75e-2d66518470a1.png
It's roughly coherent, though there was no prompt for me to give it
(unless it pulls it from the metadata and I just don't have that on my
image?)
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296545394,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMAPPA33NFALCVXQALWF5HHNANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada
M5G 0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or
privileged information for the sole use of the intended recipient. Any
review or distribution by anyone other than the person for whom it was
originally intended is strictly prohibited. If you have received this
message in error, please contact the sender and delete all copies.
Opinions, conclusions or other information contained in this message may
not be that of the organization.

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

Looks like the seed is 942491079 and the prompt is pretty curly-haired redhead woman. Here's what I get from my code with that:

Here's what outcrop gives me with about the same parameters !fix .scratch\test_full_outpaint_nomask.png --outcrop top 64 --seam_strength 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7:

Setting a breakpoint in prompt2image, at least seam_size and seam_blur are coming through as 0, despite having set them in the command. seam_steps is also 10 when I specified 20.

outcrop isn't passing through any of those arguments. I was using your
defaults until I noticed the issues this evening. At the moment, I'm
hardcoding them to find good defaults.
L
On Mon, Oct 31, 2022 at 1:18 AM Kyle Schouviller @.***>
wrote:

Setting a breakpoint in prompt2image, at least seam_size and seam_blur
are coming through as 0, despite having set them in the command.
seam_steps is also 10 when I specified 20.
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296554159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVKXQZO57Y4E5R6DBO3WF5JCBANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

Ah, I had seam settings at 0 to disable them unless explicitly enabled. I guess 96 and 16 for size and blur are probably better defaults.
I'm still getting different behavior with the outcrop code after I change it to pass through the arguments though:
!fix .scratch\test_full_outpaint_nomask.png --outcrop top 64 --seam_strength 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7

These parameters are producing better imagery:
        result= self.generate.prompt2image(
            orig_opt.prompt,
            seed        = orig_opt.seed,    # uncomment to make it deterministic
            sampler     = self.generate.sampler,
            steps       = opt.steps,
            cfg_scale   = opt.cfg_scale,
            ddim_eta    = self.generate.ddim_eta,
            width       = extended_image.width,
            height      = extended_image.height,
            init_img    = extended_image,
            strength    = 0.9,
            image_callback = wrapped_callback,
            seam_size = 96,
            seam_blur = 16,
            seam_strength = 0.7,
            seam_steps = 20,
            tile_size = 32,
            color_match = True,
            force_outpaint = True,  # this just stops the warning about erased regions
        )

I'll pass through the various command-line options and commit this to release-candidate-2-1

Ok, with the parameters above, I think outcropping is doing at least as good a job as the much simpler code I wrote. Here is one image extended by 64 on the top, and another with extensions on the top and bottom simultaneously:

You're passing --stream_strength through twice, once with 96 and the second
time with 0.7. Not sure what the code does when it gets two of the same
arguments. It's supposed to throw an exception.
Lincoln
On Mon, Oct 31, 2022 at 1:26 AM Kyle Schouviller @.***>
wrote:

Ah, I had seam settings at 0 to disable them unless explicitly enabled. I
guess 96 and 16 for size and blur are probably better defaults.
I'm still getting different behavior with the outcrop code after I change
it to pass through the arguments though:
!fix .scratch\test_full_outpaint_nomask.png --outcrop top 64
--seam_strength 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler
k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7
[image: test_full_outpaint_nomask 942491079 outcrop-08]
https://user-images.githubusercontent.com/1947631/198937465-89aa2103-3bfc-438b-9355-258cdd1565f5.png
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296558882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVLTERPWZ5PUT4LUGCLWF5J7PANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

Ah yah I realized I'd done that and checked it again without much better results:
!fix .scratch\test_full_outpaint_nomask.png --outcrop top 64 --seam_size 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7 --force_outpaint True

I'm also hard-coding seam_strength at 0.9, seam_steps at 20, and tile_size
at 32. The issue is that prompt2image() has bad defaults on these
arguments. We should default these to None so that I can pick up whether
the user has failed to provide the argument, but I don't want to break more
code tonight.
L
On Mon, Oct 31, 2022 at 1:26 AM Kyle Schouviller @.***>
wrote:

Ah, I had seam settings at 0 to disable them unless explicitly enabled. I
guess 96 and 16 for size and blur are probably better defaults.
I'm still getting different behavior with the outcrop code after I change
it to pass through the arguments though:
!fix .scratch\test_full_outpaint_nomask.png --outcrop top 64
--seam_strength 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler
k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7
[image: test_full_outpaint_nomask 942491079 outcrop-08]
https://user-images.githubusercontent.com/1947631/198937465-89aa2103-3bfc-438b-9355-258cdd1565f5.png
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296558882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVLTERPWZ5PUT4LUGCLWF5J7PANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

0.7 gave me the best results for seam_strength. At 0.9 it tries really hard to add extra subjects.
I don't think anyone else is using them. You could default seam_size to 96 and seam_blur to 16 safely. I think seam_steps of 10 should be okay, but 20 has been fine in my testing too.

Well, take a look at the RGB and RGBA images I sent and tell me if there's
something wrong with the way I masked them. Here is the current call to
prompt2image():
result= self.generate.prompt2image(
            orig_opt.prompt,
            seed        = orig_opt.seed,    # uncomment to make it
deterministic
            sampler     = self.generate.sampler,
            steps       = opt.steps,
            cfg_scale   = opt.cfg_scale,
            ddim_eta    = self.generate.ddim_eta,
            width       = extended_image.width,
            height      = extended_image.height,
            init_img    = extended_image,
            strength    = 0.90,
            image_callback = wrapped_callback,
            seam_size = opt.seam_size or 96,
            seam_blur = opt.seam_blur or 16,
            seam_strength = opt.seam_strength or 0.7,
            seam_steps = 20,
            tile_size = 32,
            color_match = True,
            force_outpaint = True,  # this just stops the warning about
erased regions
        )

I don't like what I'm doing with opt.seam_strength or 0.7 or the similar
patterns with seam_size and seam_blur, but there's no good way at the
moment to separate the user's intention from what prompt2image() defaults
to when an argument is missing.
On Mon, Oct 31, 2022 at 1:54 AM Kyle Schouviller @.***>
wrote:

Ah yah I realized I'd done that and checked it again without much better
results:
!fix .scratch\test_full_outpaint_nomask.png --outcrop top 64 --seam_size 96 --seam_blur 16 --tile_size 32 --seam_steps 20 --sampler k_lms --cfg_scale 7.5 --strength 0.9 --steps 50 --seam_strength 0.7 --force_outpaint True
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296575224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVPP2LQDS4IKQUUFGN3WF5NJJANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

I'm using 0.7 for seam_strength and 0.9 for strength. Have you experimented
with higher values of strength? I tried 0.99 and it seemed better.
Anyway, it's good enough now not to be embarrassing when people run the
outcrop test. The inpainting model is still doing a better job, although it
will probably need postprocessing to prevent it's habit of overpainting the
non-masked regions.
On Mon, Oct 31, 2022 at 1:56 AM Kyle Schouviller @.***>
wrote:

0.7 gave me the best results for seam_strength. At 0.9 it tries really
hard to add extra subjects.
I don't think anyone else is using them. You could default seam_size to 96
and seam_blur to 16 safely. I think seam_steps of 10 should be okay, but 20
has been fine in my testing too.
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1319#issuecomment-1296576329,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVMU4DN6YBKVOJ3UFALWF5NQXANCNFSM6AAAAAARSWFS5I
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

I ran it with just your "masked" version and it works well (some of my "good" screenshots above are from that).
I had mostly tried really aggressive outpainting sizes though, 50% to 75% outside the image typically. At that far out, you don't want a high strength unless you modify the prompt to remove the subject entirely (otherwise it'll just introduce more subjects).


range-v3: fix on darwin

Motivation for this change
This blocks #148672 :(
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

It seems the option was added after latest tag, I added the commit with fetchpatch

Result of nixpkgs-review pr 153117 run on x86_64-darwin 1

2 packages built:

cryfs
range-v3

@ilya-fedin FYI: I'm removing myself as maintainer of this package since I don't use Telegram-Desktop anymore: https://github.com/NixOS/nixpkgs/pull/153199. Just in case you're interested in maintaining it ;)


Include wheels on the PyPI release

The PyPI release only has a source distribution. It would be a pleasant speed increase for pip install werkzeug  if it could have wheels as well.

0.10.2 is the first one to have those.

Gracias, Señor.


Scala 3 RC1

@eed3si9n would you mind doing a release with this PR so I can release expecty later?

Done.


remove bme280 , add config params:

Why did you remove the BME280?

Sorry wanted to do PR on my fork but ended up here instead


Better names for device valid timestamps bits

kernelTimestampValidBits  can only be used with ze_kernel_timestamp_data_t  context  and timestampValidBits  has to be used with any device global timestamps. So, more representative names would be:
kernelTimestampValidBits -> contextTimestampValidBits
timestampValidBits -> globalTimestampValidBits
To avoid braking backwards compatibility, alias names could be used.

@matcabral @aravindksg

kernelTimestampValidBits -> contextTimestampValidBits
timestampValidBits -> globalTimestampValidBits

Please clarify what is the assumed valid bits for "kernel global timestamp" ?
For PVC it would be the same as "contextTimestampValidBits" , based on the above renaming.
Just wondering whether it would be a little confusing to mention "kernel global timestamp" has contextTimestampValidBits.
(Or may be I am missing what is "context" and "global" in the above explanation)
Alternately, would it be ok to rename only "timestampValidBits " to deviceTimestampValidBits ?
Thanks

After reviewing this more in depth, I found that "kernel global timestamp" could potentially have a different resolution/valid bits than timestamps returned by *GlobalTimeStamp(). So, this request is not valid. Will close


A little translation mistake in Turkish Language.

"Şimdi önce" is a wrong term. It should be "birkaç saniye önce" for long version and "şimdi" for short.

Thank you for the careful revision!
i will ship that with version 2.2.1

Thanks for your interest.


shouldn't @types/* and typescript be devDependency?

Hello, guys, I just tried the yarn create react-app my-app --typescript. But looks like in the generated package.json, @types/jest, @types/node, @types/react, @types/react and typescript dependency are all in dependencies. But I feel it should be devDependency instead?

This is intentional. We install everything as a dependency. See #6180 for more information.


Could not require module '@nexrender/action-encode' with v1.44.1 binary

Hi, I'm getting the following and I'm not sure where to go from here.
I'm using the v1.44.1 MacOS Binary from the releases. I've even installed @nexrender/action-encode as a global package just to be safe but that doesn't help.
error occurred: NestedError: Could not require module '@nexrender/action-encode'
    at requireg (/snapshot/nexrender/packages/nexrender-core/node_modules/requireg/lib/requireg.js:14:11)
    at /snapshot/nexrender/packages/nexrender-core/src/tasks/actions.js
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Caused By: TypeError [ERR_INVALID_ARG_TYPE]: The "id" argument must be of type string. Received undefined

Information about environment

Which version of nexrender are you using?
v1.44.1

What kind of the setup do you have? (server+worker or cli)
server + worker

Are you using pre-built binaries or globally installed npm packages?
binaries

Which kind (and version) of operating system you are running it in?
server: ubuntu 22.10
worker: MacOS 13.4

Any additional information that might be helpful

Expected behavior
I'd expect the encoding to work
Screenshots

I downgraded to 1.43.3 and it works there.

Hey @meza
I see, thanks. I will investigate.

Uploaded new fixed binaries to the same release https://github.com/inlife/nexrender/releases/tag/v1.44.1
Please take a look to see if it works for you now.
(they got significantly bigger, seems like during packaging some packages were not properly linked)

Works now, thanks!


Integrated Django Static file Conventions

The purpose of this integration is to allow django to collected static files from each of our applications (and any other places you specify) into a single location that can easily be served in production.
[more information] (https://docs.djangoproject.com/en/1.8/ref/contrib/staticfiles/)
Additions

vendor directory in the root project location
runserver script that integrates the global collection of static assets and running the server ```./runserver````

Removals

src directory

Changes

SRC templates now live permanently in cfgov/v1/jinja2/v1 so there is no longer a need to copy them anywhere.
FEWDs will now make any changes to front-end related assets in the cfgov/v1/preprocessed directory.
The new workflow during Gulp Build is it will take assets in preprocessed process them and dump them in cfgov/v1/static where they are how production ready and waiting to be collected by collectstatic script in runserver.sh

Testing

Review

@anselmbradford
@rosskarchner
@kurtw
@jimmynotjim
@KimberlyMunoz

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

bah closing this one out due to Github file diff constraints. going to move all file location changes to a singular commit


Regex support?

First, thank you for great library!
Do you plan (or when do you plan) to support regex manipulations in polars?
Example would be, build a new column, which extracts multiple matches from another column using regex expression and combining output. Is it possible currently archive in another way?
I would be open to contribute them with some guidance.

Isn't it possible doing so using Elixir's already existing regex capabilities?
I don't know if that's exactly what you want, but I think you might write a function that returns the desired value after evaluating a cell with Regex.match?/2, and then you could map this function over an existing column, and using Explorer.DataFrame.mutate it is possible create a new one.

You can use Series.transform with Elixir regexes but that requires materializing all results to Elixir and back, which is not the most efficient format.

https://pola-rs.github.io/polars-book/user-guide/howcani/data/strings.html
So this one is certainly possible but opens up a bit of a can of worms. In the Python Polars, there is a string namespace. I think we could totally do that. Something like Series.String.lengths or Series.String.filter. There's a regex builder re-exported by polars so that's also pretty straightforward. So I guess it's mostly a design decision. As someone who works with a lot of text, I think it'd be very useful. @philss @josevalim what do you think about something like Series.String? Is there another option I'm not seeing? The only pause I have is whether we'd want to then namespace other things. E.g. Series.List in support of #296?

Honestly, I am not the biggest fan of the namespacing, it feels everything could fit in a single namespace and in the worst case we use string_ prefixes? It looks like less to manage and closer to SQL too?

Sure, I'm just a bit wary of confusing verbiage but agreed it's best to give it a try in the single namespace first and if it feels painful look at string_ prefixes.

I'm planning to close this issue this week. We now have two new functions to work with regexes: re_contains/2 and re_replace/3 - see #894.
I would like to add 4 more functions:

Series.count_matches/2 mirroring Python Polars' Series.count_matches/2, but only for literals.
Series.re_count_matches/2 which is the same function from above, but with regex support.
Series.extract_all/2 mirroring the function of the same name in Polars, but this time it only accepts a string representing a regex. The resultant series is of type {:list, :string}.
Series.extract_groups/2 that also only accepts a string representing a regex. It mirrors the function of the same name in Polars. The resultant dtype is {:struct, [{string(), :string}]}, with the key names as the group indexes or names.

Please let me know if you see any problems with this, or if you think we could name them differently.

Awesome work, @philss!
What about re_extract_all and re_extract_groups to hint that the input is a regex? Do we have other functions which accept regex but don't have that prefix?

Agreed on the proposed new functions!

Btw, Elixir has scan (extract_all) and named_captures (extract_groups). Should we name them re_scan and re_named_captures to mirror Elixir?

@josevalim yeah, I agree we can mirror Elixir. re_scan and re_named_captures will be.
I'm facing a little problem with the re_named_captures implementation that is: we need to calculate the dtype, but we cannot do it without run the regex against the backend. This is not a problem for the eager backend, but it is a problem when we are using a  "lazy series". I'm thinking of having an optional "names" argument that is required for the lazy series, and we always name the fields following these names. The downside is that people may need to repeat the names inside the regex and outside it. WDYT?
It would like like this:
DF.mutate(df, [parts: re_named_captures(a, "(a|b)=([0-9]+)"), ["key", "value"])])

@philss Rust regex crate should have a function that extract the names of a regex. Could we perhaps use it? Or is the issue that we don't call the lazy backend at all when building a query?

Or is the issue that we don't call the lazy backend at all when building a query?

@josevalim yeah, we don't touch the lazy backend at the moment we build the query. So we cannot (or we should not) call the backend at this point.

Let’s skip this function for now then. Eventually we should have a way of calling the backend to get this info.

I will try one last thing, and if it does not work, I will give up for now.


#noissue migrated nodeTrackerRegistrationIntervalInMillis from /8 to /16

Codecov Report
Base: 66.85% // Head: 66.82% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (a054349) compared to base (d0f884e).
Patch coverage: 75.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   66.85%   66.82%   -0.03%
==========================================
  Files          71       71
  Lines        1442     1444       +2
  Branches       31       30       -1
==========================================
+ Hits          964      965       +1
- Misses        478      479       +1

Impacted Files
Coverage Δ

...sregistry/InMemoryBackgroundJobsRegistryImpl.scala
76.92% <66.66%> (-4.90%)
:arrow_down:

...ks/panda/nodestracker/NodeTrackerServiceImpl.scala
89.65% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added 8.0 to the supported PHP versions in composer.json.

Please see the discussion in #107.
This would work best if the 0.x versions continue to support PHP 5.4 (if desirable), and a new 1.x release line supports PHP 7.4 and 8.x.
A subsequent PR updates PHPUnit to 9.5 so the tests also run successfully on PHP 8.0. The current version-locked dependency uses the each() function, which has been removed.

Ideally composer.json for a 1.x version would look like:
  "require": {
    "php": "^7.3 || ^8.0",

I didn't do that here because I didn't want to unilaterally remove support for PHP 5.4 through 7.2 without a discussion first. My main concern is Composer pulling openpgp-php in PHP8. I can update PHPUnit to 9.5 locally to verify the unit tests work.
TravisCI could be updated to test PHP8 once PHPUnit is updated; but that removes support for PHP versions earlier than 7.3.

Merging this into #109


Add a rule that disallows usage of protected and suggests private isntead

In some teams and projects there is such a convention, but it is not enforced by a tool and leads to wasteful code review comments and code changes. Based on my experience protected is almost never needed, and when used it usually turns out that private is to be used instead. So, please, add this rule and maybe even enable it by default.

Unless there are others who'd support your request, I'd suggest you develop a small custom cop for this. RuboCop can never cover every possible team preference out there - we aim to support out-of-the-box only popular conventions & practices.

Agree with @bbatsov here. Occasionally, I do use protected in Ruby code, and it is always with a good reason.

I've only ever seen it used mistakenly by people who expected protected and private to be java-like on inheritance.  Disabled-by-default cop that could be turned on?

Disabled-by-default cop that could be turned on?

Writing a custom cop would take about 12 lines of code or so. I suggest that would be a better idea than adding unnecessary bulk to core.


Use std::string_view instead const std::string& since we update codebase to c++17

Now that the c++ standard has been upgraded to c++17 is there any consideration of using the  standard library to implement FileUtils?
This would greatly reduce code variability across platforms.

Some more hints where you can replace pre-C++17 string parameter with std::string_view:
https://riptutorial.com/cplusplus/example/6571/using-the-std--string-view-class

Now that the c++ standard has been upgraded to c++17 is there any consideration of using the standard library to implement FileUtils? This would greatly reduce code variability across platforms.

I'm not sure does it worth to replace exists FileUtils implementation with c++17 filesystem APIs

Some more hints where you can replace pre-C++17 string parameter with std::string_view: https://riptutorial.com/cplusplus/example/6571/using-the-std--string-view-class

Good point

A search construct can find all this "parameter constructs" to help to to replace it with 'string_view'

That's a little crazzy, but may be workable with regex search

@aismann  Do you have interesting to post a PR work for this?

Some hints:

Should skip all thirdparty
Should skip some extensions: fairygui, DragonBones, spine
Does the return type const std::string& also need replace with std::string_view?

@aismann Do you have interesting to post a PR work for this?

At the moment I have to work on real world stuff.
Maybe 2022.

Are there more examples how you update codebase to std::string_view?

const std::string&
see examples above

Info:
Changed:
virtual void setString(std::string_view label) = 0;
Cannot change:
virtual const std::string& getString() const = 0;

Maybe virtual const std::string& getString() const = 0; can change to virtual std::string_view getString() const = 0;

Maybe virtual const std::string& getString() const = 0; can change to virtual std::string_view getString() const = 0;

It will also change some inherited method on extensions: fairygui, DragonBones, spine.

Maybe virtual const std::string& getString() const = 0; can change to virtual std::string_view getString() const = 0;

It will also change some inherited method on extensions: fairygui, DragonBones, spine.

But it is a peformance improvement.
@halx99  want you try a PR?

Maybe virtual const std::string& getString() const = 0; can change to virtual std::string_view getString() const = 0;

It will also change some inherited method on extensions: fairygui, DragonBones, spine.

But it is a peformance improvement. @halx99 want you try a PR?

Should be done by this PR: https://github.com/adxeproject/adxe/pull/560, Huge changes, if somebody interested in it, please help us  review & test it

@halx99 I'm running into many issues converting a relatively large project to use the string_view changes.  Besides the large number of compilation issues (which is expected), and the fact that doing this means completely breaking any form of Cocos2d-x compatibility, there is the possibility of more serious, and hidden, problems.
Any parts of the code that use std::string::c_str() cannot be simply changed over to use std::string_view::data(), since it does not guarantee that the data returned is null terminated.  The safe way would involve a cast the std::string_view to to std::string first, then calling c_str() on the result.
Took me quite a while to get the compilation issues fixed, and now I'm facing a memory leak somewhere that is just chewing up large amounts of memory and freezing Visual Studio. so I'm trying to dig into the cause of that.

Guarantee data with null-terminated c styled string:

Construct with literal strings
Construct with std::string

Not Guarantee with null-terminated

Construct with default constructor std::string_view{}
Construct with other blob buffer without null-terminated character, such as std::vector<char>

Would something like this cause a problem:
std::string_view UserDefault::getStringForKey(const char* pKey)
{
    return getStringForKey(pKey, "");
}

std::string_view UserDefault::getStringForKey(const char* pKey, std::string_view defaultValue)
{
    auto pValue = getValueForKey(pKey);
    if (pValue)
        return *pValue;

    return defaultValue;
}

The return getStringForKey(pKey, ""); creates a temporary value for defaultValue on the stack.  If a value does not exist in the store, then it will return the std::string_view defaultValue, which is a memory address pointing to a temporary value.  Would the return value still be valid given that it's pointing to a stack that already been unwound (if my assumption on how it works is correct)?

It's no problem when the string_view construct with "", it's a permanent memory, that why I define a safe empty_sv at https://github.com/adxeproject/adxe/blob/ahead/cocos/base/hlookup.h#L62

All good, I understand.
I've managed to fix all remaining issues in my project, so now it's working with the string_view changes, and it all seems fine at the moment.

When will this big PR available?

Currently, It's available to build & test, you can simply fetch & checkout to branch ahead to test it

Currently, It's available to build & test, you can simply fetch & checkout to branch ahead to test it

My fork has only the dev branch (default) after fetch, no ahead there.
How can I fork ?

My fork has only the dev branch (default) after fetch, no ahead there. How can I fork ?

Follow the instructions here:
https://stackoverflow.com/questions/4410091/github-import-upstream-branch-into-fork

The big PR will merge to dev first, and the default branch release instead dev for stable and compatible reason

with the latest adxe (dev from today)
Works on VS IDE!
Get error if it run directly:

will check it later

with the latest adxe (dev from today) Works on VS IDE! Resources on IDE from: adxe\tests\cpp-tests\Resources !!! Get error if it run directly:

Aha, you needs use run.bat

The working directory needs set to Resources

Here a first check and counting:
Starting with "templates' and 'tests' is a good first step.

I belive it is done (Issue can be closed):