fix: tapping assignee and mark as complete quickly navigates to not found page

Details

Tapping assignee then marking the task as complete at the same time navigates to not found page. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/38577
PROPOSAL: https://github.com/Expensify/App/issues/38577#issuecomment-2018491026
Tests

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only and task is not marked as completed
Tap Description then quickly tap Mark as complete
Verify that user is navigated to Description page only and task is not marked as completed

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only and task is not marked as completed
Tap Description then quickly tap Mark as complete
Verify that user is navigated to Description page only and task is not marked as completed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/113963320/6908c51d-284f-430f-b72e-bd8c2dddeec1

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/d8df8a55-d973-420e-a24c-d7158fcdbb39

iOS: Native

https://github.com/Expensify/App/assets/113963320/63715150-79f6-4c30-9f08-392804ee6633

iOS: mWeb Safari

https://github.com/Expensify/App/assets/113963320/a6dcb226-9720-47d7-9b5c-fdc14a347847

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/620bcbdc-59ad-4fad-b124-7920723aae6e

MacOS: Desktop

https://github.com/Expensify/App/assets/113963320/620bcbdc-59ad-4fad-b124-7920723aae6e

Will review this today/tomorrow.

@mananjadhav After tapping Assignee, if we quickly tap Mark as completed many times, when we went back from Assignee page, the Mark as completed button will be dimmed but it's still functioning if we tap it (just dim, not disabled).

I think we can treat it separately. You can report it on the bug channel.
@tienifr Can you update the PR body to remove singleExecution now that the code logic is changed. Overall the code looks fine. I'll test and work on the checklist today.

Also @tienifr Can you please add a comment on why we're adding these route checks?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/3069065/76d9d310-54f4-4834-8a25-75d22c54404f

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/59edac3c-29e1-4850-8b6f-aadbae41fcc5

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/704934c9-b673-4e03-b0cb-3dc6459651ee

I am getting build errors on this branch.

 BUNDLE  ./index.js

error: Error: Unable to resolve module react-compiler-runtime from /Users/manan/dumpd/expensify/App/src/components/ActiveWorkspaceProvider/index.tsx: react-compiler-runtime could not be found within the project or in these directories:
  node_modules
> 1 | import React, {useMemo, useState} from 'react';

@tienifr Did you face this issue? I am getting this only for this branch. Can you sync with the latest main?

@tienifr Quick bump on the previous message. Can you sync your code to latest main? Syncing to main resolves the earlier error for me.

@mananjadhav just missing one item in the checklist now 🚀

Done @rlinoz

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fails with meteor-sharejs

I try to run demeteorizer on an app with the meteor  package meteor-sharejs.
https://github.com/mizzao/meteor-sharejs
However there are some files missing in the end.
The folder
  /programs/web.browser/packages/mizzao_sharejs/.npm/package

is empty after running npm install
However there needs to be the npm package share be installed.
What step did I miss?
For an try out you can use the demo app in the meteor-sharejs repo, there the same problem occures.

+1?

Check out https://github.com/mizzao/meteor-sharejs/issues/37
We'll have to figure out a way to get the dependencies for meteor-sharejs
included in the bundle.


Reentrancy + DLL call design choices

Hi,
"Multithreading safe operations" is a main argument for this library. However, all VIs are non-reentrant, is it on purpose?
I still can change them to reentrant but what will happen if I update the vip or if I need to distribute the code to my team?
Plus, it uses DLLs,  so debugging will not be worst.
Also, all DLLs are called in UI Thread. I’m not familiar with LabVIEW thread management, but from what I understand, it could lead to UI slowdowns. Am I wrong?
Regards

Thanks for the feedback @thomas-allibe-se . You're right that the VIs should be reentrant, and you're also right that the Call Library Nodes should be set to 'Run at any thread'. I'm in the process of fixing both issues and hope to get the changes submitted to github today, and a new package uploaded to vipm.io as soon as possible.

Changes present in main branch and in package build <IP_ADDRESS> that is now published to vipm.io.


feat(verify): zksync contract verification

Motivation
Closes #102

Solution

We need to add 2 fields to the Etherscan request to make it compatible with their API for ZkSync:

compilermode to indicate wheter to use zksync-solc or just solc with zksolc
zksolcVersion to indicate the version of zksolc in use

We also have to provide the zksolc settings instead of the solc ones.
### Warning
The current version of the branch most likely breaks compatibility with Etherscan, instead focusing on https://explorer.zksync.io compatibility.
Please use the API endpoints listed in the docs. An API key is not required by these endpoints, but forge still requires the value to be present, which can be anything.

is there an updated README on how to use it?

No, we have not yet updated the README to explain the added functionality. verify-contract should work as expected, and also create --verify. Without --zksync (or without specifying zksync.compile in the config) it would behave the same as normal foundry.
From our testing, script --verify is not there yet, especially because only the top level contracts are verified, so for example factories would be verified but not the contracts deployed by a factory.
Feel free to open an issue if something isn't behaving as expected!


cachetool via fcgi doesn't work if php-fpm starts with systemd unit  set to PrivateTmp=true

If the php-fpm systemd unit file has PrivateTmp=true and you run cachetool with this:
cachetool  opcache:status -vvv --fcgi /var/run/php-fpm/php-fpm.sock

then you see this in the logs (snipped to the relevant part):
[2015-01-06 20:55:05] cachetool.DEBUG: Executing code: return extension_loaded('Zend OPcache'); [] []
[2015-01-06 20:55:05] cachetool.INFO: FastCGI: Dumped code to file: /tmp/cachetool-54ac91f90c03f.php [] []
object(CacheTool\Code)#82 (1) {
  ["code":protected]=>
  array(1) {
    [0]=>
    string(40) "return extension_loaded('Zend OPcache');"
  }
}
[2015-01-06 20:55:05] cachetool.DEBUG: FastCGI: Response: {"statusCode":404,"headers":{"status":"404 Not Found","content-type":"text\/html; charset=UTF-8"},"body":"File not found.","stderr":"Primary script unknown\n"} [] []

  [RuntimeException]
  Primary script unknown

Interesting!
/dev/shm or (worse) /var/run could be used instead. Can you test if php-fpm with PrivateTmp can read from those directories?

they both work

as an aside: the visible error you get when this fails (  Primary script unknown  ) was kinda hard to understand. definitely had to open up the fastcgi client code to figure it out.

Did you add any logging code? Could be useful to have this logged.
I will have a look at this tomorrow, add a input option for the writable directory and as a configuration parameter.

i just added a var_dump in ebernhardson/fastcgi

is there a reason we can't just use /dev/shm if it exists and fall back to /var/run instead of using /tmp at all?

Fixed in 1.5.0

wow. thanks @gordalina! I really appreciate you taking the time to work so closely with me.

thanks for your instrumental feedback! are you using it in production?

i'm about to. It's part of my ansible playbook for deploying my php application. BTW: i heard about it here: http://www.reddit.com/r/PHP/comments/2l1hx6/cachetool_cli_application_library_to_manage/

Thanks :) let me know if something doesn't work
On qui, 8/01/2015 at 23:59 Johnny Robeson<EMAIL_ADDRESS>wrote:

i'm about to. It's part of my ansible playbook for deploying my php
application. BTW: i heard about it here:
http://www.reddit.com/r/PHP/comments/2l1hx6/cachetool_cli_application_library_to_manage/
—
Reply to this email directly or view it on GitHub
https://github.com/gordalina/cachetool/issues/7#issuecomment-69272658.


[Feature Request]: Adding Trending Blogs section in the blog section

How would you like to enhance the existing project.
Hi, I would like to add "Trending Blogs" in the blogs section, I think it will be more user-friendly. So please assign me this issue under GSSOC'23.
Describe breifly how would you implement the same.
Solution_steps
Are you contributing for a program?
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I would like to work on this issue!

Sure, go on ..

Hi, I opened the issue. Please assign it to me

@tech-bash please look into the matter

sorry, i have to. deassign @yatigautam ..actually author should be assigned.. I have created more issue please comment on that.. I'll assign you

@anmode right my bad, didn't looked at the description well that the author is interested or not!


Show a confirmation when an order was successfully canceled

Do what it says on the box.

Also replace the order submit "green check" with similar UI.

This is superceded by #8154. Closing.


test: add DB transaction tests

Description
This is tests for v4.2.
Related #6919, #6886
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/3555886311/jobs/5972871727 to see Exception classes.
The current behaviors:

All the current DB drivers throw an exception when a query error occurs.
MySQLi driver sets mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX) that throws mysqli_sql_exception.
SQLite3, Postgres and OCI8 drivers throw ErrorException because of Error Handler.
SQLSRV driver has different implementaion. It throws Exception when the query return value is false.

Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
[x] Conforms to style guide

This PR just adds test code.
Please review.


I parsed jquery w/ it and only found 6 regexps :(

I found 71 regexps in jQuery v1.11.3 (Chiffon v1.4.0)
And, I have test whether the Chiffon and Esprima is the same result.
https://github.com/polygonplanet/Chiffon/blob/1.4.0/tests/test.js#L42-L44
Please tell me your execution environment or jQuery's version etc..


Details (gh:mtb_scale, gh:surface and gh:road_class) are added to trackpoint extensions instead of route.

Wrong target repo 🙄


angular 15 how can I avoid long relative paths import

Angular 15
I want to '@import 'variables.scss' like this instead of '@import '../../../assets/scss/variables.scss;'
my code in project.json file
   "stylePreprocessorOptions": {
                    "includePaths": ["apps/client/src/assets/scss","./node_modules"]
    },

I get an error like this when I defined this short '@import 'variables.scss'
Error: Transform failed with 1 error:
C:/my-project/home.component.scss:17: 100 : ERROR: Unterminated string token

The includePaths are relative to the workspace root, so likely the correct path should be src/apps/client/src/assets/scss if you have a root level application. It is also worth mentioning that using @import is discouraged by the SASS team and it is being phased out.  See: https://sass-lang.com/documentation/at-rules/import
If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.


Want to work with a quantized GPTQ model

[NEED ADVICE]
Is then my best bet is to

Use one of the vanilla llama2 models
Use autotrain to fine tune it
Quanitze it
Use it?

Looking for someone who already has worked with it or has experience with it.

Hey @sauravm8 I did work on it and the results look good,
#1 and #2 you can use autotrain library to train your model on your custom dataset
for #3 and #4 I used TGI they have provided quantisation script and hosting model on TGI is pretty straightforward.


Update scores.json

Fixes #
Changes proposed in this pull request:

Updating score after one last minute pr got merged. @Anupam-dagar


tunnel service not starting on fedora

Fedora 29
Version 3.30.2

install code-insiders from rpm
in a
in a terminal run code-insiders tunnel --accept-server-license-terms service install (see #177351 for the need of --accept-server-license-terms)
authorise
command fails with

[aeschli@kyrian-fedora-vm ~]$ code-insiders tunnel --accept-server-license-terms service install
...
[2023-03-16 13:24:30] info Successfully registered service...
[2023-03-16 13:24:30] info Successfully enabled unit files...
[2023-03-16 13:24:30] error error starting service: org.freedesktop.systemd1.NoSuchUnit: Unit code-insiders-tunnel.service not found.

I'm not expereinced with systemd. How can I debug this? Where should code-insiders-tunnel.service be?
ls /etc/systemd/system/ does not show code-insiders-tunnel.service
No additional info in the log:
[aeschli@kyrian-fedora-vm ~]$ code-insiders tunnel service log
Unit code-insiders-tunnel.service could not be found.
-- Logs begin at Tue 2019-01-15 15:34:47 GMT. --

From discussion: may have been on an old version of Fedora. I verified this works on the latest Fedora release.


Basset/Laravel concat issues with tooltip

Just a heads up for anyone.
I'm using Gulp.js with the uglify and concat plugin on Laravel 4.1. Tooltip.js will concat after popover and cause issues in the bootstrap.min.js file. Tooltip will compress after popover, so your console will throw an error. This could also be due to Basset/Laravel or gulp not to sure. To combat this issue and for a quick fix change tooltip.js to "atooltip.js" in your "//= require" and jquery will start to play nice. Another error will be no slide transition in navbar toggle (mobile). Not really an issue with Bootstrap-sass but something maybe someone may come across and hopefully this will be of some help.
SEO Purposes: Uncaught Error: Popover requires tooltip.js

+1

The next release of bootstrap-sass (coming very soon) will reference the concatenated file at assets/javascripts/bootstrap.js in bower.json's main. Meanwhile, use that file, or specify the order explicitly.


ci: :zap: Add /cli change validation to CI workflow

Should allow for changes to www and docs to be free from ci errors around changeset, I have little exp working with the ci but thought I would try my attempt at a fix!
Closes #1623
✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[ ] I performed a functional test on my final commit (may need to push a change to /cli to test)

Changelog
Added a new step in the CI workflow to check for changes in the /cli directory. If there are any changes, it will validate the changeset by running pnpm changeset status --since origin/next. This ensures that changes made to /cli are properly tracked and validated.
💯⚡

noice

thanks for picking this up! the current version seems to hit false negatives, see https://github.com/t3-oss/create-t3-app/pull/1626
also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli

thanks for picking this up! the current version seems to hit false negatives, see https://github.com/t3-oss/create-t3-app/pull/1626
also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli

Ah okay thanks for adding the test PR, I'll see what's going on with that

thanks for picking this up! the current version seems to hit false negatives, see #1626
also @juliusmarminge do we also need to include a few files in root such as eslintrc, prettier config, etc? i'm leaning no, because none of them should change the ux of using the cli

@c-ehrlich I think I got it working if you would like to pull my changes and test for yourself. I was able to fail and pass with and without a change in cli/src/index.ts

Okay in my testing it fails when no changeset + change in ci/src/index.ts and passes when you add changeset or remove the change from ci/src/index.ts

Gonna come back to this tomorrow ...

Running all the tests ... but it seems the grep command was the culprit, needed to return true if grep doesn't find any matches, allowing the script to proceed to the else block gracefully.


move to file scoped namespace

not sure what your preferences is on this feature. so feel free to discard if you dont like them

Although I'm very happy with this kind of syntax simplification in each new version of C#, we need to hold off on this for a few reasons.
First, although this particular feature probably works in practice, it is officially unsupported outside of .NET 6, and at least for a while I wish to hold onto our support for LTS .NET Core 3.1. See https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version "C# 10 is supported only on .NET 6 and newer versions".
Second, we have a high-value PR in progress over in #263 that I've been inattentive for while I juggle a lot at work, and I want to avoid causing it to "die on the vine" due to large scale conflicts, even the "easy" conflicts of a whitespace change.
Out of respect for that developer's contribution-in-waiting, I want to defer this to the future when I can be more certain of the language support for our target frameworks. Since it's easy enough to automate with tooling like ReSharper, we can opt into it later and in smaller pieces based on what all other work is in flight at the time.


Can't build from source with crystal installed from snap

I followed Install from sources with Crystal installed from snap.
$ make
Using /usr/bin/llvm-config-15 [version= 15.0.7]
g++ -c  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc -I/usr/lib/llvm-15/include -std=c++14   -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
CRYSTAL_CONFIG_BUILD_COMMIT="df960cf76" CRYSTAL_CONFIG_PATH='$ORIGIN/../share/crystal/src' SOURCE_DATE_EPOCH="1687369226" CC="cc -fuse-ld=lld" CRYSTAL_CONFIG_LIBRARY_PATH='$ORIGIN/../lib/crystal' ./bin/crystal build -D strict_multi_assign -D preview_overload_order -Dwithout_interpreter  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib -D use_pcre2
error: unknown command "build", see 'snap help'.
make: *** [Makefile:214: .build/crystal] Error 64

The issue is that the realpath command for the following line
PARENT_CRYSTAL_COMMAND=$(realpath "$(command -v "$PARENT_CRYSTAL" 2> /dev/null)" 2> /dev/null)

resolves to /usr/bin/snap.
The following rough patch for the binstub resolves the issue:
diff --git a/bin/crystal b/bin/crystal
index 8e42d4e7e..800c1277c 100755
--- a/bin/crystal
+++ b/bin/crystal
@@ -154,6 +154,9 @@ if [ -z "${PARENT_CRYSTAL##*/*}" -a "$(realpath "$PARENT_CRYSTAL")" = "$SCRIPT_P
 fi

 PARENT_CRYSTAL_COMMAND=$(realpath "$(command -v "$PARENT_CRYSTAL" 2> /dev/null)" 2> /dev/null)
+if [ $(basename "$PARENT_CRYSTAL_COMMAND") = "snap" ]; then
+  PARENT_CRYSTAL_COMMAND="$(command -v "$PARENT_CRYSTAL" 2> /dev/null)"
+fi
 PARENT_CRYSTAL_EXISTS=$(test !$?)

 # check if the parent crystal command refers to this script

There's probably a more proper way to handle the snap case. If that's good enough I'm happy to submit a PR. Otherwise I'm open to suggestions on how to improve the patch.

Can you give some insights into why the realpath of PARENT_CRYSTAL ends up being /usr/bin/snap?
I suppose it might have something to do with how snap operates (which I have no idea about).

I'm not familiar with how snap binaries work internally, but it's a sandboxed execution environment and somehow goes through the snap binary.
$ which crystal
/snap/bin/crystal

$ readlink /snap/bin/crystal
/usr/bin/snap

$ ls -l /snap/bin/crystal
lrwxrwxrwx 1 root root 13 Mai  9 14:18 /snap/bin/crystal -> /usr/bin/snap

$ realpath /snap/bin/crystal
/usr/bin/snap

Okay this looks reasonable and not a specific issue with snap. So we should apply a generic solution.
The only reason for calling realpath on the crystal executable is being able to check whether it resolves to the wrapper script itself (to avoid self loops). It's not necessary for anything else and I think the script can be adapted to not use realpath for calling the crystal executable.

@koffeinfrei Could you check if this patch works for you?
--- a/bin/crystal
+++ b/bin/crystal
@@ -153,11 +153,12 @@ if [ -z "${PARENT_CRYSTAL##*/*}" -a "$(realpath "$PARENT_CRYSTAL")" = "$SCRIPT_P
   PARENT_CRYSTAL="crystal"
 fi

-PARENT_CRYSTAL_COMMAND=$(realpath "$(command -v "$PARENT_CRYSTAL" 2> /dev/null)" 2> /dev/null)
+PARENT_CRYSTAL_COMMAND=$(command -v "$PARENT_CRYSTAL" 2> /dev/null)
+PARENT_CRYSTAL_COMMAND_REALPATH=$(realpath "$PARNET_CRYSTAL_COMMAND" 2> /dev/null)
 PARENT_CRYSTAL_EXISTS=$(test !$?)

 # check if the parent crystal command refers to this script
-if [ "$PARENT_CRYSTAL_COMMAND" = "$SCRIPT_PATH" ]; then
+if [ "$PARENT_CRYSTAL_COMMAND_REALPATH" = "$SCRIPT_PATH" ]; then
   # remove the path to this script from PATH
   NEW_PATH="$(remove_path_item "$(remove_path_item "$PATH" "$SCRIPT_ROOT")" "bin")"
   # if the PATH did not change it will lead to an infinite recursion => display error

@straight-shoota The patch works for me :+1:.


LCOW SCSI Add/Remove ends up hanging in UVM

The test:
https://github.com/Microsoft/hcsshim/blob/master/functional/uvm_scsi_test.go#L20
Ends up hanging in the UVM remove path when it tries to remove SCSI /0 for the 2nd time. The sympotms seem to be less frequent if you lower the test case size but this a bug somewhere.
To repro just run the test but it seems that its the 2nd add/remove that causes the issues.

@jhowardmsft - FYI


[PE-D][Tester D] App does not allow different entries with the same name.

There is already an entry for John but of a different email and phone number. Considering the possibility of multiple patients with the same name, perhaps can consider validation check on email or phone number instead as duplicates for these fields would be a stronger indication of duplicate entries.

Labels: type.FunctionalityBug severity.Medium
original: jinyuan0425/ped#2

Remove unique name behaviour. Add "Add NRIC" into "Planned Enhancements".


fix: remove ugly badge

:tada: This PR is included in version 1.3.10 :tada:
The release is available on:

v1.3.10
GitHub release

Your semantic-release bot :package::rocket:


How to clean up '\home\data\SitePackages'

I'm using ZipDeploy and find there are more and more zip files uploaded to '\home\data\SitePackages'
Is there a convenient way of clean up unused packages?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7838171-5cab-d164-cc88-2973c0d0e56e
Version Independent ID: d888bc9c-c031-f67c-d5a0-25cc265f14e3
Content: Run your app from a ZIP package - Azure App Service
Content Source: articles/app-service/deploy-run-package.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

This comment is related https://github.com/Azure/app-service-announcements-discussions/issues/32#issuecomment-554379071, which is not answered

This comment is related https://github.com/Azure/app-service-announcements-discussions/issues/32#issuecomment-554379071, which is not answered

nvm, found answer here: https://github.com/projectkudu/kudu/wiki/Dealing-with-locked-files-during-deployment

nvm, found answer here: https://github.com/projectkudu/kudu/wiki/Dealing-with-locked-files-during-deployment

Thanks for leveraging Azure docs feedback channel to raise this question. Glad you found the answer, much appreciate the follow-up and update.

Thanks for leveraging Azure docs feedback channel to raise this question. Glad you found the answer, much appreciate the follow-up and update.


[Feature Request] Add captcha at login page

Currently there is no Captcha code required at log in page, it is vulnerable to brute force attack.
Not sure if you guys could add captcha verification at log in page?

Question 1: If 2FA is enabled within OnlyOFFICE (a feature that exists today), would you still suffer a brute-force attack?  I would think that, although the credential would be found, at this point, the user would be notified 1,000's of times that their account is breached (where they could simply change/regenerate a password).
Question 2: Can rate-limiting assist in this case specifically on the "login" page, as an average user will enter their username/password at most 10 times per minute, I would think. (once per every 6 seconds, which I think is awful fast)
Our PCI track for a project I am on requires the support of 2FA, but does not seem to protect against brute-force attacks, like mentioned here.
Looking forward to understanding this more in-depth.

@dealproc I deployed Community Server at our local intranet, which absolutely has no Internet access, but intranet still is vulnerable to potential attacks. Yes, 2FA is good enough to protect the login page from brute-force attack, but it requires the Internet. Captcha (or other similar verification methods), which doesn't need to communicate with the Internet, is a good solution for intranet users, at least I think.
Indeed, I fully understand Community Server is a free version, I can't ask for anything. So, just some advice/thoughts here.

Closed for a reason - there has been no activity for a long time.


Server IP Change After Installation

Hi , i have installed SOMO when Raspberry was connected with LAN cable , but all the players that i would like to manage is under wireless network that closed to internet access, now in SOMO settings server IP is wrong , can i change the server IP manually?
Thanks for you're help!

Hello @cerform
the server IP is the device IP.
If something wrong with them, you need to edit the service file: /etc/systemd/system/docker.somo.service
Best
didiatworkz


Added Goldberg

No worries if you don't want to merge this in.  It was just useful for me.  I can always maintain my own fork with this minor change going forward if necessary.

Can the Goldberg fork be added? It's an updated version of Goldberg.
I think the achievements are the same, only the path has changed.
%appdata%\GSE Saves
https://github.com/Detanup01/gbe_fork

@DogancanYr, since 3.2, none of the local achievements work for me.  I had an update ready with the new location, but when I noticed 3.2 was out, I updated and made my change to that one.  Tested and it wouldn't recognize any local achievements.  I just submitted an issue for this, but will put forward another PR that updates Goldberg with the new path (leaving the old one in as well) after that issue is resolved.


Add matchExpressions to WorkLoadSelector

Describe the feature request
Relevant Docs
As a user of Istio, I would like to be able to select resources based on matching expressions. In addition to existing matchLabels field, I would like to be able to select from values via a matchExpressions as follows:
matchExpressions:
    - {key: tier, operator: In, values: [cache]}
    - {key: environment, operator: NotIn, values: [dev]}

(from https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#resources-that-support-set-based-requirements)

Describe alternatives you've considered
N/A
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[x] Developer Infrastructure
Additional context
Sorta relates to #25021

I am quite interested in this feature. Any way to get this issue reopened? @pkg-committers

Not stale

+1

+1

+1


My FCC challenges have started all the way from the beginning. Also, my FCC appears in mobile format

Challenge Name

freecodecamp.com/jeffersonnnn
Issue Description

Now, i upgraded my laptop from Windows & to Windows 10 the day before. I use Chrome so i went ahead to download and sign in to chrome browser to access my FCC page. Worryingly, i can't seem to start from where i stopped in my challenges even though my profile acknowleges that i have gone above and beyond that place
Also, my FCC also appears to be in mobile format. I think...because i am not sure. i just isn't as it should be.
Browser Information

Browser Name, Version: Chrome Version 52.0.2743.116 m
Operating System: Windows 10
Mobile, Desktop, or Tablet: Desktop

Your Code

Screenshot

Seems to be some compound issues going (imo more hardware related but I'll leave that to a mod).

When you upgraded from (presumably from win 7), it's possible that your local cache was cleared. (but as you've discovered you can access your solution from profile (that's normal in terms of cache btw).
The browser view. That newer chrome release based on some comments in forums etc., has had some UI changes (might be what you're perceiving) - **You might might want to include additional information like:
What kind of device is it and was chrome showing a desktop view in old chrome/windows version?
Have you tried looking at fcc from edge (default browser) just to see if it too renders in mobile view?
Do other sites in this new chrome version also display/render in mobile view?**

oh thank you for being swift with a reply.

Indeed, i upgraded from win 7, so yeah.
I hope that this new feature(s) is not here to stay.
a. I run with a core2duo on HP Pavilion dv6000; under win 7, i had the desktop version.
b. I have, i get the same mobile view.
c. No other site renders in mobile view with this new chrome and/or windows 10. it seems site-specific.

Help needed!

@jeffersonnnn thanks for reporting.
Luckily I am on a Windows 10, so I am all in to help resolve this. But meanwhile we request your patience, this being an isolated case for now atleast.
Just consolidating the scenario:

[ ] Windows 10 , Chrome Version 52.0.2743.116 m
[ ] Issue is also on all other browsers (including Edge)
[ ] Machine is a Core 2 Duo, HP Pavilion DV 6000
[ ] Issue wasn't present on your Win7 earlier.
[ ] Issue is site specific, that is it is on Free Code Camp's website only

Just a few more in depth details should get us thru:

Could you check your system spec once and dump it here, it's available under Settings > System . About
What's the screen resolution of your machine, right now? Should be available in Settings > Personalization > Display
Have you upgraded to the latest graphics drivers for your System, to check that resolution is at par that your hardware supports?

Thanks.

@raisedadead thank you!
All the above information remain true.

Edition                                  Windows 10 Enterprise
Product ID                            00329-00000-00003-AA172
Processor                              Intel(R) core(TM)2 CPU        T5600 @ 1.83 GHz GHz
Installed RAM                        2.00 GB
System type                           32-bit operating system, x64-based processor
Pen and Touch                       No pen or touch input is available for this display

Resolution stands at 1024 x 768

i am missing a fair number of drivers as my upgrade wasn't done *properly. As it stands, i should have the nvidia geforce go7400 driver for my display but  it is missing.
Can the above be the problem? hm.
blessings on you and yours @raisedadead !

I just see two things with the second being a problem mostly:

System type 32-bit operating system, x64-based processor:
While it's not necessary, your processor does support a 64 bit OS, why not have Windows 10 64 bit? You don't have to answer this, and again this is not required as well.

And yeah with the Graphics you mention, upgrading the drivers might resolve the issue. Was your resolution the same when your were on Windows 7?

The model specs suggests 1280x800 was the base - Almost guaranteed a driver or settings issue

Well, the computer tech gave a long and convoluted explaination why i presently run a 32-bit on a x64-based processor. If it is absolutely necessary, i can go back to win 7.
I shall redownload my nvidia driver right now to see if that is responsible for the mobile view problem.
Any ideas about the other issue?

Downgrading to windows 7 : No not needed, stick with Win10 32 bit. That's okay.
Upgrade your drivers and run a windows update as well.
Let us know how it goes.

I feel for you (though I run linux and have my win10 installs in VMs so can't help you with a native hardware experience/troubleshooting). Really, though I think this is hardware related and less about site - If you google 'windows 10 nvidia problems' you get a ton of stuff (e.g, - My guess is that you would have better luck in windows-hardware type forums etc. (as well as being prepared to troubleshoot a problematic upgrade (things don't always go smoothly, but that's part of the 'fun'). Maybe, also,  touching base with folks in the general fcc gitter room as you're doing this would be a good way to sort of walk through this in real time - But, again, just one person's opinion.

It's possible that the mobile view could be due to zoom settings. I can get partial mobile view if I zoom in enough that the challenge switches to mobile view but the navbar stays the same.

Thanks guys. my FCC is now in the right viewing format and i am at the right point in my challenges. What i eventually did was to downgrade back to win 7 because the combination of win 10 and the display driver i use for my laptop is ill fated. Apparently, there are compatibility issues. I couldn't have gotten ahead without the insights from this forum. Thanks all, you guys rock.

@jeffersonnnn glad it worked out.
Happy Coding


fix(deps): update module github.com/gofiber/fiber/v2 to v2.47.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/gofiber/fiber/v2
require
minor
v2.46.0 -> v2.47.0

Release Notes

gofiber/fiber
v2.47.0
Compare Source
🚀 New

Add queries function (#2475)
https://docs.gofiber.io/api/ctx#queries

// GET /api/posts?filters.author.name=John&filters.category.name=Technology

app.Get("/", func(c *fiber.Ctx) error {
    m := c.Queries()
    m["filters.author.name"] // John
    m["filters.category.name"] // Technology
})

Middleware/logger: Add DisableColors to set the default output format (#2493)
https://docs.gofiber.io/api/middleware/logger#config

// Disable colors when outputting to default format
app.Use(logger.New(logger.Config{
    DisableColors: true,
}))

🧹 Updates

Update getOffer to consider quality and specificity (#2486)
Use c.app.getString instead of string(...) (#2489)
Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 (#2474)
Bump golang.org/x/sys from 0.8.0 to 0.9.0 (#2508)

🐛 Fixes

Middleware/limiter: Fix Sliding Window limiter when SkipSuccessfulRequests/SkipFailedRequests is used. (#2484)
Fix onListen hooks when they are used with prefork mode (#2504)
Fix middleware naming and returned values of group methods (#2477)
Treat case for possible timer memory leak (#2488)
Reset terminal colors after print routes (#2481)

📚 Documentation

Update version of html template (#2505)
Translate README_fa.md (#2496)
Correcting a syntax error in the README (#2473)

Full Changelog: https://github.com/gofiber/fiber/compare/v2.46.0...v2.47.0
Thank you @Kamandlou, @Satont, @Skyenought, @cmd777, @dozheiny, @efectn, @gaby, @kaazedev, @luk3skyw4lker, @obakumen, @sixcolors and @ytsruh for making this update possible.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: backend-go/go.sum
Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v "/tmp/renovate/repos/github/bcgov/quickstart-openshift":"/tmp/renovate/repos/github/bcgov/quickstart-openshift" -v "/tmp/renovate/cache":"/tmp/renovate/cache" -e GOPATH -e GOSUMDB -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/tmp/renovate/repos/github/bcgov/quickstart-openshift/backend-go" docker.io/renovate/sidecar bash -l -c "install-tool golang 1.20.5 && go get -d -t ./..."
go: downloading github.com/gofiber/fiber/v2 v2.47.0
go: downloading github.com/gofiber/swagger v0.1.12
go: downloading github.com/gofiber/helmet/v2 v2.2.26
go: downloading github.com/golang-migrate/migrate/v4 v4.16.0
go: downloading github.com/joho/godotenv v1.5.1
go: downloading github.com/sirupsen/logrus v1.9.2
go: downloading gorm.io/driver/postgres v1.5.2
go: downloading gorm.io/gorm v1.25.1
go: downloading github.com/devfeel/mapper v0.7.13
go: downloading github.com/tinylib/msgp v1.1.8
go: downloading github.com/google/uuid v1.3.0
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading github.com/mattn/go-isatty v0.0.19
go: downloading github.com/mattn/go-runewidth v0.0.14
go: downloading github.com/savsgio/dictpool v0.0.0-20221023140959-7bf2e61cea94
go: downloading github.com/valyala/bytebufferpool v1.0.0
go: downloading github.com/valyala/fasthttp v1.47.0
go: downloading github.com/swaggo/files/v2 v2.0.0
go: downloading github.com/swaggo/swag v1.16.1
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/lib/pq v1.10.2
go: downloading go.uber.org/atomic v1.7.0
go: downloading golang.org/x/sys v0.9.0
go: downloading github.com/jackc/pgx/v5 v5.3.1
go: downloading github.com/jinzhu/now v1.1.5
go: downloading github.com/philhofer/fwd v1.1.2
go: downloading github.com/rivo/uniseg v0.2.0
go: downloading github.com/savsgio/gotils v0.0.0-20230208104028-c358bd845dee
go: downloading github.com/valyala/tcplisten v1.0.0
go: downloading github.com/andybalholm/brotli v1.0.5
go: downloading github.com/klauspost/compress v1.16.3
go: downloading github.com/KyleBanks/depth v1.2.1
go: downloading github.com/go-openapi/spec v0.20.9
go: downloading golang.org/x/tools v0.9.1
go: downloading github.com/hashicorp/errwrap v1.1.0
go: downloading github.com/jinzhu/inflection v1.0.0
go: downloading github.com/jackc/pgpassfile v1.0.0
go: downloading github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a
go: downloading golang.org/x/crypto v0.8.0
go: downloading golang.org/x/text v0.9.0
go: downloading github.com/go-openapi/jsonpointer v0.19.6
go: downloading github.com/go-openapi/jsonreference v0.20.2
go: downloading github.com/go-openapi/swag v0.22.3
go: downloading github.com/mailru/easyjson v0.7.7
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/bcgov/quickstart-openshift v0.1.0
github.com/bcgov/quickstart-openshift/backend-go imports
	github.com/bcgov/quickstart-openshift/backend-go/docs: cannot find module providing package github.com/bcgov/quickstart-openshift/backend-go/docs

already addressed


fix(admission) add KongClusterPlugin validation

What this PR does / why we need it:
Currently we don't validate KongClusterPlugin. As KongClusterPlugin needs the same validation as KongPlugin for almost all fields, this PR builds a KongPlugin from the KongClusterPlugin and pushes it through the existing ValidatePlugin() logic.
The only transform ValidateClusterPlugin() performs converts namespaced KongClusterPlugin ConfigFrom into the non-namespaced KongPlugin type. To ensure Secret lookup functions as expected, ValidateClusterPlugin() sets the KongPlugin namespace to the namespace of the KongClusterPlugin ConfigFrom.
Tests duplicate those used for ValidatePlugin() with type adjustments.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1764
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Is there any chance of backporting this patch to the version 1.x line?

Had you found something in 2.x that prevented you from upgrading?

No, I just hadn't tried! Speaking of which, within the last five minutes I got version 2.0.5 running. It worked on the first try. I'll be rolling it out to all of our Kubernetes clusters once I get my patches through code review.


Expression Builder needs two modifiers added to drag-and-drop: % and

Modifiers Panel will contain "%" and ±

see #93


Call a service method on a different broker

Inside the action you can call other actions in other services with ctx.call method. It is an alias to broker.call, just set itself as parent context (due to metrics).
This is great because it allows for chaining of calls, however, I'm able to do that only as long as the service is loaded on the same node/broker, i.e. given return ctx.call("service.method") where service is on a separate broker, service.method will not be found. I am use gnats as transport.
Maybe I'm missing on something? thanks ;)

Upon closer inspection I see repl outputs Waiting for service(s) 'myservice'.. - NATS client is connected on both service brokers.

No, you can call services on other nodes with ctx.call of course. This is the point, that you don't know a given service which nodes is running and how many instances.

Check the nodes command result in repl that all nodes see each others.

@icebob Thank you, yes I understood that, the problem I'm facing is that even though the nodes are connected (I see that in the logs, also for gnats) the service which I'm attempting to require another logs Waiting for service(s) 'myservice' - it basically waits for it but never finds it, as a result ctx.call() returns and 404 error message. I'm thinking could it be related to nodeId being undefined?

(PS awesome job on a well thought framework!)

I think the problem is that you was running multiple brokers with the same nodeID. (If nodeID is empty it will be the computer name). I recommend to use manual nodeID or something similar: nodeID: "node-" + process.pid

You I have just tested it, this was indeed the case! Thank you!
Very excited about moleculer!


Can't create two indexes?

Hello!
I was working on #274 and I got an issue I was not expecting.
Now I'm wondering if I'm badly using milli or if milli stores some information that it shouldn't store.
I created a small git repo to reproduce the bug: https://github.com/irevoire/milli_bug
All you have to do basically is run cargo run and you should get a panic:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UserError(PrimaryKeyCannotBeChanged)', src/main.rs:28:32

From what I see, even after deleting entirely the milli database and dropping the index. When we create a new index milli still contains document: https://github.com/meilisearch/milli/blob/main/milli/src/update/settings.rs#L435

I am not quite sure I understand the problem, in your repository you didn't delete the index, you didn't even close it.
To be sure that it is effectively closed you must call index.prepare_for_closing().wait() on it, then you must delete the file from the filesystem like you currently do. Keep in mind that a memory-mapped file is always accessible until it is unmapped, that the reason why only deleting the file from the disk without quitting the program keeps the database alive.

YES, thank you, that was totally the issue!
I was pretty sure to be the one who is wrong :smile:


Add before-html-generation event

This allows you to add assets to the html when not using injection

Shouldn't we better move the html-webpack-plugin-before-html-processing event up so it can deal with both ways?

Then you have no way to modify the HTML before injection


Add three more icons (adjust, bookmark-regular, bookmark-solid)

Fixes

Fixes #105 by @panchovm
Description

Add three icons

Adjust
Bookmark regular
Bookmark solid

Checklist

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main or master).
[ ] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @panchovm, @zackkrida. I have looked at https://github.com/FortAwesome/Font-Awesome/tree/master/svgs/solid and couldn't find the "bookmark regular" SVG file. There is only "bookmark solid" which is named bookmark.svg.

@makkoncept this should be the 'empty' (outline only) icon:
https://www.github.com/FortAwesome/Font-Awesome/tree/master/svgs%2Fregular%2Fbookmark.svg

looks good @makkoncept thanks for fixing the unicode sequence


Drag & Drop for sorting training sets

Enable sorting of trainging sets with drag & drop like in modules.

Work-around to limit django-mptt to only set root nodes: https://github.com/django-mptt/django-mptt/issues/708


InputPin debounce support

I'm using this library on a Pi Zero W to interface with an old rotary phone, and switch transitions definitely aren't clean 100% of the time.
Previously I have used the gpiozero Python library, which has the option to "debounce" inputs: a user-supplied time delay controls how soon before new input states can be registered. As far as I can tell, this crate does not have any such capability.
What I would love to see is a new method for InputPin that sets a debounce time using a Duration. This might work something like the following:
const BCM_INPUT: u8 = 2;
let gpio = Gpio::new()?;
// Ignore state changes on `button` less than 50 ms apart.
let debounce_time = Duration::from_millis(50);
let button = gpio.get(BCM_INPUT)?.into_input_pulldown().debounce(debounce_time);
// ...

Of course, I could implement my own debouncing code on top of rppal, but I strongly feel that this is something that should be implemented in this crate directly, as debouncing digital inputs from switches is an extremely common practice.

This would be a good addition, adding a resistor in line does this too

Debounce has been added to synchronous and asynchronous interrupts for the upcoming 0.19.0 release.


Slightly reduce dependency.

No need to depend on full protobuf, just the io part is what we're interested in.

... saves about 170 processes run by bazel. Small amount, but also worthwhile to be specific.


Rewrite buffer.d

The current AudioBuffer design needs some major changes.  It works, but there is little flexibility for resizing.

Currently rewriting delay.d to implement buffer mechanism inside it.  Will probably remove buffer.d since it isn't needed for any other type of effect.

DigitalDelay now supports it's own buffer.  buffer.d may not be needed anymore.  Although it could be rewritten based on DigitalDelay

Buffer is useful for look-ahead limiting.  It has been rewritten and simplified as of 9362ee1


[standalone electron app] Can't install on linux

Version
4.1.4
Browser and OS info
Archlinux (latest) / Ubuntu (latest)
Steps to reproduce
Run in terminal:
sudo npm install -g @vue/devtools

What is expected?
@vue/devtools successfully installed
What is actually happening?
@vue/devtools is not installed

Operation log:
# npm install -g @vue/devtools
/usr/local/bin/vue-devtools -><EMAIL_ADDRESS>
><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/@vue/devtools/node_modules/electron
> node install.js

/usr/local/lib/node_modules/@vue/devtools/node_modules/electron/install.js:48
  throw err
  ^

Error: EACCES: permission denied, mkdir<EMAIL_ADDRESS>npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-05-02T15_08_07_733Z-debug.log

Can be verified on any platform using docker

Your error message says permission denied, npm global installs must be given root privileges.

@gterras Command was run with root privileges. I'm sure about that

@gterras https://askubuntu.com/a/700266/510172

If you are using bash (the default), your prompt will tell you if you are acting as root. If it ends in a $ you are running as a normal user. If it ends in a # you are running as root.

Check the line abowe  (it ends with a # so, I'm running it as root )
# npm install -g @vue/devtools

Any updates on this issue? I'm getting the same error when trying to install devtools. Thanks

Thanks for your message @fabioguarrasi. I thought I'm alone with this issue )

@probil are you using sudo ?

@fabioguarrasi Yeap

run this command sudo chown -R whoami /Users/{{your_user_profile}}/.npm-global/ then install the package globally without using sudo

It seems like you are from Mac OS world. There is no /Users/ folder on linux :smile:
I have no issue with any other packages installed with root permission globally.

yes, I have a mac. I never had issues with root permission as well, but this helped me to solve the problem

I get the same error on Arch OS (also with sudo)

Can confirm, have the same issue on Ubuntu 18.04.
Tried both with sudo and as root.

Same issue on Manjaro.
Based upon #609 and Troubleshooting Guide from electron, I can install it by setting --unsafe-perm to true.
Complete command would be  sudo npm install -g @vue/devtools --unsafe-perm=true.

same issue with Ubutnu please help !

even i am facing this issue for so long please help
"sudo npm install -g electron"
/usr/local/bin/electron -> /usr/local/lib/node_modules/electron/cli.js

<EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/electron
node install.js

/usr/local/lib/node_modules/electron/install.js:49
throw err
^
Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/electron/.electron'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: node install.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/tarunmanchukonda/.npm/_logs/2019-04-09T08_51_19_163Z-debug.log

@tarunmanchukonda
I ended up using Chrome extension instead of standalone electron app.

I also have this issue, Here is what I was doing until now: #1076
Reading this thread I tried with sudo and here is what I get: btw I'm on Archlinux:
$ sudo npm install -g @vue/devtools
/usr/bin/vue-devtools -><EMAIL_ADDRESS>
><EMAIL_ADDRESS>postinstall /usr/lib/node_modules/@vue/devtools/node_modules/electron
> node install.js

/usr/lib/node_modules/@vue/devtools/node_modules/electron/install.js:48
  throw err
  ^

Error: EACCES: permission denied, mkdir<EMAIL_ADDRESS>npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `node install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-10-15T14_31_45_905Z-debug.log

This issue has been open for 1 year and 5 months and almost 10 people are having it. Please consider putting some effort on this. Please keep in mind that some of us are using vue for native applications, I'm using nativescript-vue personally. For us, using browser extension is not an option. We have to use the electron app. I'm sure you know how difficult vuejs development can be without the wonderful devtools.

I also experienced it. I tried to install it in a newest Lubuntu 19.10 but I get the same error with @aranmohyeddin @tarunmanchukonda and @probil. Its said that its a permission isuue even though I already sudoing. Here is the additional log from /root/.npm/_logs/2019-10-24T17_42_40_610Z-debug.log
8103 error code ELIFECYCLE
8104 error errno 1
8105 error<EMAIL_ADDRESS>postinstall: `node install.js`
8105 error Exit status 1
8106 error Failed at the<EMAIL_ADDRESS>postinstall script.
8106 error This is probably not a problem with npm. There is likely additional logging output above.
8107 verbose exit [ 1, true ]

It's 05 February 2021, I am facing same issue on Ubuntu 20. Any updates?


Is this module no longer open source?

Is this module no longer open source? If it has been moved to a private repository for maintenance.
Will this module be open source again in the future?

Yes, the development has been moved to a private repository for the time being. This repository will be updated once 0.0.7 releases.


relative URIs calculated wrong when processing Documents in a pipeline (base-uri related)

I suspect problems with processing documents that use the xinclude mechanism in the xslTNG stylesheets pipeline. To get to the bottom of this, I created a test scenario as simple as possible (see attachment). All transformations are done outside of Oxygen, using the xslTNG jar File (Version 2.1.9)
xinclude-issue.zip
The starting point was the sample directory of the xslTNG distribution, where I put a book with one chapter, which is included via xi:include (book.xml and chapter.xml). It contains two graphics with relative URLs. It is well-formed and valid.  When i transform with the standard stylesheet docbook.xsl, everything is as expected. The img/@src values for Images are correct.
To check the pipeline idea i created the xslt/driver.xsl file as a customization layer which imports docbook.xsl. The only thing it does is to define a step in the pipeline by setting $transform-original to preprocessor.xsl. This preprocessor does nothing but shallow-copy. So i would expect the same output as before. But when i use the xslTNG jar file setting the stylesheet parameter to xsl:../xslt/driver.xsl i get an Runtime Error because  xslTNG/xslt/chapter.xml is not found.
You can see that the URI of the included chapter is wrong. It is given as an URI relative to book.xml, but is calculated relative to the static base uri of the stylesheet.
To check whether it depends on xinclude i made a second book in book-monolith.xml with the same content, but without xi:include. Applying the driver.xsl Stylesheet leads to a different error message:  Can't find the image file in xslTNG/xslt/media/lamb.png. Again, the relative URI is calculated wrong: not against the base-uri of the Input Document, but against the static base uri of the stylesheet.
My conclusion is that the base uri of the input document is absent when it is processed by an $transform-original pipeline, and that the static-base-uri is used instead, which in turn leads to File not Found Errors. To check this, i changed the preprocessor.xsl so that it adds the xml:base attribute:
<xsl:template match="/*" as="element()">
  <xsl:copy>
    <xsl:attribute name="xml:base" select="base-uri()"/>
    <xsl:apply-templates select="@*, node()"/>
  </xsl:copy>
</xsl:template>

This time it works without errors, and correct img/@src values in the HTML result.
Greetings, Frank

I don't think this is a bug in the stylesheets, but I have attempted to clarify the documentation. Please let me know if you think I've misunderstood.


Polars: simplify SeriesDomain

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2158  👈 (View in Graphite)
#2096 : 2 other dependent PRs (#2097 , #2156 )
#2157
#2095 : 1 other dependent PR (#2155 )
#2091 : 1 other dependent PR (#2153 )
#2089
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Timeline tool: per chart option toggle

Each chart corresponding to one or multiple stats vars with same measured value. But there could be other stats observation properties to choose: observationPeriod, unit, scaling factor, measurementMethod. We should give user the option to toggle among these.
It's also nice to have perCapita, logScale as a toggle on per chart basis.
@beets what would be a good UI for this? A naive solution is to have a dropdown menu by the chart.

This seems like an advanced feature, for someone in tune with the data that we have :)
Will we be able to know what all the possible options are? Will the options apply to all lines in a chart (since we currently group by mmethod I believe?) Then we could add a dropdown in the top or bottom left corner with the options to choose from.


Functional tests

- What I did
Added functional tests for all the verbs
- How I did it
- How to verify it
- Description for the changelog
-->  Functional tests for the verbs

@purnimavenkatasubbu thanks for rebasing this. It looks like a bunch of the functional tests are failing for various reasons, so there's still some polish needed before these can be merged.

@purnimavenkatasubbu can you please fix the merge conflicts on this (@kalluriramkumar please help if needed)
@gkc added you as a reviewer. I'd like to get this merged, as there's a lot of work here that's taken many months of effort.

@purnimavenkatasubbu it looks like 42662aa has a corrupted fullchain.pem in it that's got merge conflict dividers still present, which is stopping the virtual environment from coming up for functional tests.
I'll grab the latest certs from at_virtual_environment and try to fix it.

@purnimavenkatasubbu please take a look at test run #464 as it seems a bunch of the functional tests are failing inside of GitHub Actions.
We may also need to do some refactoring (to run tests in parallel) if tests are going to take significantly longer than before, as I'd like to keep the commit loop where it was ~4m. But for now working tests are the priority, we can work on speedy later.

@purnimavenkatasubbu lots of NoSuchMethodError: The method 'trim' was called on null., which I think we seen before when dependencies have been tangled.
I also see a bunch of @cicd1 stuff in logs. Is there stuff that's supposed to be in the end to end tests that's found its way back to the at_functional_tests directory? I fear that this might be introducing a dependency on the cicd host VMs that shouldn't be there for functional tests.


Fix modal scrolling for overflow

When modal contains absolute positioned element which is taller than available screen, the modal scrolling is not triggered. By using scrollHeight the extended height is taken into account.
scrollHeight is how Bootstrap modal determines whether to trigger scrolling.
The bug demo:
https://jsfiddle.net/lulalala/ngjvzwkc/1/

The fix above doesnt work for a few reasons

When sizes are calculated the modal has display: none;
Height calculation is used for vertical centering, and offscreen calculation is  based on relative position of modal centering
Modifying modal height to use scrollHeight would change the centering

7450aa3c9c32d0d608e73c2f52b7bfa4f32a718f adds a new loading state for calculating height, and uses both heights together. If scrollHeight is larger than modal base height, it'll use scrollHeight to calculate whether the modal is off stage.

thanks for the fix!


Test the RTM_EVENTS.CHANNEL_JOINED event

The RTM_EVENTS.CHANNEL_JOINED isn't firing for some reason...

Resolved >> 3cc672c


Idea, new mapper

Please add mapper on LabyMod 1.16.5

I'll see, but not my priority, you can do that yourself, labyMod is just forge, you just have to update mappings.h accordingly.
Also the more I add new versions, the longer it takes to maintain and to add new features.
I'm also thinking if it's not better to drop support for 1.16.5, because it's too hard to maintain


Adding .env and faster rails c

You can now use env's to load up enviroment variables to hide your
passwords :)

Muchas gracias :)


为什么预览的页面中不能设置暗黑模式？

Describe the bug （描述 Bug）
A clear and concise description of what the bug is.
To Reproduce （重现步骤）
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior（你期待的是什么?）
A clear and concise description of what you expected to happen.
Screenshots（截图）
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context（附加信息）
Add any other context about the problem here.

antdv 尚未提供黑暗模式的支持，无法切换


Fix today's time indicator in week view

When you navigate into weeks and come back to today, the time indicator position was reset to the very top of the column. To keep it accurate, we re-compute its position after the component did update.

Accidentally push this PR. Ref to https://github.com/intljusticemission/react-big-calendar/pull/1054 for the fix.


Specify expansion mode for adapter

Edited from original submission:
This issue is tracking the ability to give a specialized collapse/expand mode. For example, that only one item can be expanded at a time, or only one can be collapsed at a time.
Original title: Is there any method to collapse other items?
Original body:
I found method as "mAdapter.collapseAllParents();" to collapse all items but is there any method to collapse other items when expanding one item.

@girubhai There's currently a story that may be of some help to you here: #90. We don't currently have an official way of doing this rolled into the library, but it's something we've discussed.
Let's use this story to track this feature request going forward.

@dgreenhalgh Thanks to reply,For the time being I did use "lastExpanded" variable to find last expanded item and it working.
private int lastExpanded = -1;
And use it on onListItemExpanded method as
if (lastExpanded != -1)
mAdapter.collapseParent(lastExpanded); // collapse previous expanded item.
lastExpanded = position;  // set last expanded parent position.
And in onListItemCollapsed method reset lastExpanded if same expanded parent is collapsing again as
if (position == lastExpanded) {
lastExpanded = -1;
}

Re-opening this issue to track progress on a collapse mode feature

@girubhai I had implement this Api
you can see my lib refer to this lib,thanks!

Did you add the mode for only one parent expansion?

No this feature has not been added yet. This issue is being used to track that effort.


MB-2623 Upgrade Node to v12

Description
Also upgrades react-uswds to version 1.3.0
Reviewer notes
This PR:

includes an ADR for using nodenv as the tool for managing local Node versions.
uses a new updated Docker image from circleci-docker so that CI runs with Node version 12.

Setup

Follow the nodenv installation instructions
nodenv install 12.16.3
nodenv local 12.16.3
make server_run
make client_run
You should now be able to use the app!

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

@donaldthai good call, I'll link to the more in-depth nodenv shell setup instructions in the PR description.

After following these instructions I still have node (and yarn) installed via brew. Should we also have people uninstall those?
Also, I followed instructions but when I run node -v it tells me I am running v10.20.1.

@tinyels I didn't have to uninstall yarn, but I did uninstall Homebrew's Node. One thing to try would be nodenv rehash which will make sure your path finds nodenv. Will add that to the PR instructions.

@tinyels I didn't have to uninstall yarn, but I did uninstall Homebrew's Node. One thing to try would be nodenv rehash which will make sure your path finds nodenv. Will add that to the PR instructions.

I can't uninstall node because of yarn.


feat(forge): integration testing & test harnesses

Component
Forge
Describe the feature you would like
Current Behavior

forge test picks up and runs all function test*
This means that both unit tests and integration tests are run when forge test is called
You cannot support integration tests across two networks without filtering using various match calls
Generally, this leads to projects using a Makefile to discriminate between tests

Desired Behavior
Ideally, we would distinguish between two types of tests:

unit test: runs with no environmental dependency and is deterministic
integration test: expects a specific environment and may not be deterministic

Unit testing would continue as it currently runs, the UX of forge is strong in this area. Integration tests would however carry around config as to the environment they expect to run in. I see two ways to achieve this:

Declare config in solidity

Support setting RPC URL / chain-id (where it then reads rpc-url from environment/config) as a minimum
Inherit from TestHarness that requires config to be passed in constructor
Set desired config using cheatcodes

Declare config in toml/json

Support setting RPC URL / chain-id (where it then reads rpc-url from environment/config) as a minimum
Ideally support passing arguments to setUp / discrete functions within the test contract
Pin config to a contract or function within the contract
Could have multiple configs per contract or function, enabling a form of table testing (though I suspect there might be better UX from pure solidity here)
Would enable running new contracts through re-usable tests, as you could potentially pass the contract/bytecode as an argument for testing. E.g. an ERC-20 test harness that gets run against multiple contracts/deployments

Next steps
Interested in getting feedback on:

The demand for this sort of functionality
Whether the potential solutions are appealing
Alternative approaches

Additional context
No response

How does this differ from fork tests?
Test discrimination by profile is coming in #1378, which also means you can set different fork urls and blocks for different sets of tests. For cross-network tests in the same test, see #834. For table testing see #858

Can you expand on ow this differs from fork tests?
Test discrimination by profile is coming in #1378, which also means you can set different fork urls and blocks for different sets of tests. For cross-network tests in the same test, see #834. For table testing see #858

Nice! I think the UX I'm after can be pulled together by the mentioned issues. I think we can close this and re-open if they UX isn't quite there after the other issues.
The harness testing would be achieved via #858 and #834, each case would declare its environment including RPC url.
As for #1378, it appears you cannot currently define fork_url in foundry.toml, so until that is added you can't use foundry.toml to separate unit tests from integration tests.

Then in that case we can close this?

Yep, the only difference is declaring test cases in solidity vs some other format. Happy to close this for now and watch how the other issues play out


Update of Mi Flora sensor is taking over 10 seconds

Home Assistant release with the issue: 0.84

Last working Home Assistant release (if known): < 0.83
Operating environment (Hass.io/Docker/Windows/etc.): Hass.io

Component/platform: https://www.home-assistant.io/components/sensor.miflora/

Description of problem: I have 4 Mi Flora sensors. 3 of them are working fine but the 4th is no longer connecting and updating Home Assistant. If I use the Android Flower Care app, the sensor is actually functioning, but Home Assistant is timing out trying to receive updates.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# sensor
  - platform: miflora
    mac: 'C4:7C:8D:67:2B:43'
    name: Master Bedroom Palm
    force_update: true
    # median: 3
    monitored_conditions:
      - moisture
      - light
      - temperature
      - conductivity
      - battery

# plant
  master_bedroom_palm:
    sensors:
      moisture: sensor.master_bedroom_palm_moisture
      battery: sensor.master_bedroom_palm_battery
      temperature: sensor.master_bedroom_palm_temperature
      conductivity: sensor.master_bedroom_palm_conductivity
      brightness: sensor.master_bedroom_palm_light_intensity
    min_moisture: 15
    max_moisture: 60
    min_battery: 15
    min_conductivity: 350
    max_conductivity: 2000
    min_temperature: 10
    max_temperature: 32
    max_brightness: 35000

Traceback (if applicable):
Update of sensor.master_bedroom_palm_temperature is taking over 10 seconds
8:54 AM util/async_.py (WARNING)
Update of sensor.master_bedroom_palm_battery is taking over 10 seconds
8:54 AM util/async_.py (WARNING)
Update of sensor.master_bedroom_palm_light_intensity is taking over 10 seconds
8:54 AM util/async_.py (WARNING)
Update of sensor.master_bedroom_palm_conductivity is taking over 10 seconds
8:54 AM util/async_.py (WARNING)
Update of sensor.master_bedroom_palm_moisture is taking over 10 seconds
8:54 AM util/async_.py (WARNING)

Additional information:

I struggled with timeouts as well (in previous versions), but I have been steadily adding more MiFlora sensors.  I was wondering if the BT driver was having issues, because I sometimes could get it to function correctly if I restarted BT daemon.
I ended up setting up a Plant Gateway on a Raspberry Pi that is more centrally placed in my home.
Watching Plant Gateway working, I have noticed that it will fail to connect to 1 or 2 of the 5 sensors I currently have active.  It will eventually connect, get the metrics from the sensor and send the results to Home Assistant via MQTT.  I believe it's due to the distance between the Raspberry Pi and some sensors.  So, knowing that, I have been wondering if the MiFlora component code is issuing this warning and not retrying?  I have yet to inspect the component code.

Something did get worse here.
Pre 0.84 Mi Flora through some "over 10 seconds" errors but otherwise worked ok.  Since 0.84 having Mi Flora sensors has resulted in HomeAssistant startup times taking in excess of 15-20 minutes, no UI (http not responding).  Commenting out the Mi Flora sensors gets it working again.
This is all via Docker.

@ChristianKuehnel since you've worked on Mi Flora before, would you be able to investigate this?

The general problem with these sensors is that they are not meant to be
used over longer distances. In my apartment I get a range of about 1 dry
wall or 6m direct line of sight. Everything beyond that is not really
stable. And as it's a radio connection there can always be issues with the
stability.
There weren't any recent changes to the miflora library.
https://github.com/open-homeautomation/miflora/releases
There were some recent changes to the home assistant component by
@PaulAnnekov . Could you please have a look?
Otherwise I don't really know what could cause the change...
Am Sa., 29. Dez. 2018, 22:42 hat Marat Levit<EMAIL_ADDRESS>geschrieben:

@ChristianKuehnel https://github.com/ChristianKuehnel since you've
worked on Mi Flora before, would you be able to investigate this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/19362#issuecomment-450525631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATCWCH6aAyKpLbHCCiyAxdNqSc_iR_aqks5u9-_BgaJpZM4ZVe96
.

The last release of miflora component was in 0.80.0. I don't see any significant changes after that time.
Checking this issue will require a lot of debugging and it will be faster to debug on place, e.g. to change a distance between miflora sensor and bluetooth transmitter or to patch-restart HA. Also, I don't use miflora anymore.

Just tried 0.88b and it's not working.
It seems to have broken between 0.83 and 0.84 best I can tell.  I don't think it's necessarily a change in the mi flora library/component itself.  This smells like a race condition or some other contention issue.  It seems to be mainly (or only) impacting people with multiple sensors.

@raccettura Can you please turn on debug logging on miflora, btlewrap and bluepy?
You can do this by adding this to your configuration.yaml:

Some snippets that seem relevant:
2019-02-18 19:03:08 DEBUG (SyncWorker_16) [miflora.miflora_poller] Received result for handle 56: 5B 15 32 2E 37 2E 30
2019-02-18 19:03:08 DEBUG (SyncWorker_3) [miflora.miflora_poller] Received result for handle 56: 5B 15 32 2E 37 2E 30
2019-02-18 19:03:11 DEBUG (SyncWorker_13) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x7f0f36e6e048> failed, try 1 of 3

2019-02-18 19:03:16 DEBUG (SyncWorker_13) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x7f0f36e6e048> failed, try 2 of 3
2019-02-18 19:03:18 DEBUG (SyncWorker_13) [miflora.miflora_poller] Received result for handle 56: 0B 15 32 2E 37 2E 30

2019-02-18 19:03:21 DEBUG (SyncWorker_19) [miflora.miflora_poller] Received result for handle 56: 0A 10 32 2E 36 2E 32
2019-02-18 19:03:21 DEBUG (SyncWorker_0) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x7f0f36e6e048> failed, try 1 of 3
2019-02-18 19:03:24 DEBUG (SyncWorker_0) [miflora.miflora_poller] Received result for handle 56: 0B 15 32 2E 37 2E 30
2019-02-18 19:03:24 DEBUG (SyncWorker_0) [miflora.miflora_poller] Filling cache with new sensor data.

2019-02-18 19:04:59 DEBUG (SyncWorker_16) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x7f0f36e6e048> failed, try 2 of 3

2019-02-18 19:05:40 DEBUG (SyncWorker_16) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x7f0f36e6e048> failed, try 3 of 3
2019-02-18 19:05:40 INFO (SyncWorker_16) [homeassistant.components.sensor.miflora] Polling error

After 3rd attempt it actually loads.  Took maybe 3-4 minutes.  Interestingly without the debugger turned on I could never get it to start.

I had the same problem - it stopped working suddenly, had the 10 second warnings (though they were also present before, when it worked), tried several restarts (including of the entire VM) and when enabling the debugger it magically started working again!

This seems indeed the same problem as I am facing in https://github.com/home-assistant/home-assistant/issues/21774,
I think enabling the debug log slows down the startup process in such a way that sometimes not all threads are assigned to the miflora sensor and then the system is able to boot.

Hi all. I have the same problem with my MIFLORA sensors (10 seconds warnings). Moreover, I've tried to make a clean new installation of hassio on new sd card. Well, when rasp rebooted for the first time after upload last snapshot, UI stopped until I've wrote "#" on miflora lines in configurator.yaml. Could someone solve this issue? TY

Have similar problems with Mi Flora. It suddenly stops working but after HA restart could start working again. I turned on debug for Flora and bluetooth, have tons of the following messages in log:
DEBUG (Thread-4) [btlewrap.bluepy] Call to <function BluepyBackend.write_handle at 0x61b44d20> failed, try 1 of 3
and
DEBUG (Thread-3) [btlewrap.bluepy] Call to <function BluepyBackend.connect at 0x61d4e6a8> failed, try 1 of 3

Any news on this?
I started experiencing the same problem (No values from sensor, with the BluepyBackend.connect failed call error)  a week or two ago. Not sure what I changed :/ My config file history shows no changes on the MiFlora config, I have updated to a later Hassio version, not sure if that was the cause.

I solved every problems with 3A power supply and ABSOLUTELY IMPORTANT 32 GB
micro sd V30
In data 13 agosto 2019 11:45:06 Wessel du Plooy<EMAIL_ADDRESS>ha scritto:

Any news on this?
I started experiencing the same problem (No values from sensor, with the
BluepyBackend.connect failed call error) a week or two ago. Not sure what I
changed :/ My config file history shows no changes on the MiFlora config, I
have updated to a later Hassio version, not sure if that was the cause.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks, will give that a try!

Little tip: I upgraded my system to Intel nuc i3 with 8gb ram and ssd 128
GB. FABOLOUS! Another universe! Reboot in about 5 sec and cameras without
stuck. If you can, upgrade to nuc
Bye
In data 13 agosto 2019 13:03:19 Wessel du Plooy<EMAIL_ADDRESS>ha scritto:

Thanks, will give that a try!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I have the same problem with 3 Miflora Sensors. It used to work until the end of year 2018, and since then I have problems.
I am sure it can not be the distance between the sensor and the Raspberry Pi3. I tried the following with no effects:

Reduce the distance of the sensor and Pi to 1m and less.
Delete all sensors except one from configuration.yaml.
Update Hass.io
Reinstall / Clean new installation
Restarting Hass.io and Home Assistant Server
Change battery of the Miflora Sensors (the battery is almost full)

What I see now:

It looks like it is working worse for every month.
First I thought a restart of Hass.io helps. Most time a restart helps after some time I get values, but very fast the values freeze. And then I need a new restart.
Sometimes a restart helps and all sensors have new values. Sometimes 2 sensors have new values and 1 has only the battery value. It is like random.

Hi, I solved with esphome (esp32) and nuc
Ciao!
In data 29 agosto 2019 10:35:22 gilbert-grape<EMAIL_ADDRESS>ha
scritto:

I have the same problem with 3 Miflora Sensors. It used to work until the
end of year 2018, and since then I have problems.
I am sure it can not be the distance between the sensor and the Raspberry
Pi3. I tried the following with no effects:Reduce the distance of the
sensor and Pi to 1m and less.
Delete all sensors except one from configuration.yaml.
Update Hass.io
Reinstall / Clean new installation
Restarting Hass.io and Home Assistant Server
Change battery of the Miflora Sensors (the battery is almost full)
What I see now:
It looks like it is working worse for every month.
First I thought a restart of Hass.io helps. Most time a restart helps after
some time I get values, but very fast the values freeze. And then I need a
new restart.
Sometimes a restart helps and all sensors have new values. Sometimes 2
sensors have new values and 1 has only the battery value. It is like random.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Little tip: I upgraded my system to Intel nuc i3 with 8gb ram and ssd 128 GB. FABOLOUS! Another universe! Reboot in about 5 sec and cameras without stuck. If you can, upgrade to nuc Bye In data 13 agosto 2019 13:03:19 Wessel du Plooy<EMAIL_ADDRESS>ha scritto:
…
Thanks, will give that a try! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Nice for you. But this is not really helpful for me.
How do you set up your ESP32? Do you have a manual?

Buy esp32 wroom from ebay, install esphome in hassio (integration) and
follow wizard when open esp page from hassio. If you don't see ota option
to upload code in esp32 from hassio, you must connect only for first time
esp32 with usb cable to pc with arduino ide.
https://esphome.io/devices/esp32.html
https://esphome.io/components/sensor/xiaomi_miflora.html
Try and let me know
Bye
Mario
In data 29 agosto 2019 11:00:45 gilbert-grape<EMAIL_ADDRESS>ha
scritto:

Little tip: I upgraded my system to Intel nuc i3 with 8gb ram and ssd 128
GB. FABOLOUS! Another universe! Reboot in about 5 sec and cameras without
stuck. If you can, upgrade to nuc Bye In data 13 agosto 2019 13:03:19
Wessel du Plooy<EMAIL_ADDRESS>ha scritto:
…
Thanks, will give that a try! — You are receiving this because you
commented. Reply to this email directly, view it on GitHub, or mute the
thread.Nice for you. But this is not really helpful for me.
How do you set up your ESP32? Do you have a manual?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I do the same like @sajikur, works fine.
And after you can use the esphome to update esp32 & ESP8266 from more devices:
https://blakadder.github.io/templates/
The templates from tasmota help you to find the correct pin use.

It's true! you can use the same device for both miflora and mijia ble
temperature and humidity or to update esp8266 and esp32
In data 30 agosto 2019 08:57:05 ElGranLoky<EMAIL_ADDRESS>ha
scritto:

I do the same like @sajikur, works fine.
And after you can use the esphome to update esp32 & ESP8266 from more devices:
https://blakadder.github.io/templates/
The templates from tasmota help you to find the correct pin use.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

In Home Assistant exists the attribute scan_interval, where I can define the read interval for the miflora sensor.
But in esp32home does not exist this attribute. In the documenataion is written it depends on the sending of miflora. Esp42 does only listen.
Can you explain how it works exactly?

In miflora over esp32 you can't control battery level and scan interval. So
you use esp32 if you have errors in Rasp log, miflora is far from Rasp or
simply to make Rasp's work easier.
Ciao
In data 30 agosto 2019 16:47:57 gilbert-grape<EMAIL_ADDRESS>ha
scritto:

In Home Assistant exists the attribute scan_interval, where I can define
the read interval for the miflora sensor.
But in esp32home does not exist this attribute. In the documenataion is
written it depends on the sending of miflora. Esp42 does only listen.Can
you explain how it works exactly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

duplicate of #24453

@gilbert-grape The ESPHome Xiaomi integration listens passively to packets the xiaomi device sends by itself.  Since version 0.84 this problem exists and not everyone knows how to program or search for errors. For my part I don't usually do many PR but I try to help whenever I have time.
And even if the missing library is added, the problem reappears over time as users comment.

For me, the problem was solved by changing to a stronger 3A power supply. I can only assume that something on the RasPi started drawing more power, which underpowered it's BT radio. Maybe this helps someone.

Weezul: Thanks for the tip. I changes my power adapter to an Apple iPad adapter which has enough power.
Result: Nothing changed, still only an update on miflora when i restart HA. And not all miflora have values. Sometimes One of 3 has values after a restart. Sometimes 2.

Closing this as it's a duplicate of #24453 and that has been resolved.