What does inference.py produce ?

Hi,
First, thanks for sharing and congratulation for your paper.
I'm trying to replicate your results using your code and after running for 1h the inference using:
python inference.py -lo 11
I'm only getting purple or black png images of depth, segmentation and normal. (Also, I'm wondering where in the code you used a Neural Network to produce the 2D layout proposal.)
Thanks,
Elias
For debugging purpose here is the output I had:
[12.505933386565303, 11.840489850059223, 15.729679877696523, 20.618404598707315, 20.604609863008843, 20.627059253822228, 20.600119984846167, 15.706996849585847, 11.807378893377756, 11.809321755817825, 20.582860259569415, 20.584939248583467, 20.576565089759814, ...  20.20288421484522, 20.197662885707548, 11.407069203630291, 11.406951353697252, 20.190112783937515, 11.399563047782623, 20.187815793977286, 20.187741693292583, 20.186761376778033, 15.28390536794825, 20.184846489007857, 20.177022930041492, 15.27399344846434, 11.386237157008493, 12.558552073047844, 15.273921132185398]
[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 0, 1, 1,0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ..., 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0,0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0]
3214
total inference time is :22654.6464229

And the content of the generated files:
>>> set(np.load('rgb.npy').flatten())
{0}
>>> set(np.load('normal.npy').flatten())
{0}
>>> set(np.load('segmentation.npy').flatten())
{0}
>>> set(np.load('depth.npy').flatten())
{0.1}

Also during compute_prior I always have this output:
picture out of the layout with 1.73472347598e-19
I dont have any improvement.
loading CAD model
66cdea8432907e9fb99d331574136d26
bed exists and align success
f1b1e6d1cb875b9f11c3739edd52fa3
dresser exists and align success
1316780d9b4a8ca71bb088904f7cb154
night_stand exists and align success
b3836ad467e9f3157199c3a1b4ff8300
lamp exists and align success
859e9c3a93ad1f03e1f4f9b641386c6a
picture exists and align success
3d6b55fe2deb2aa3a1c746794f191dc8
night_stand exists and align success
b3836ad467e9f3157199c3a1b4ff8300
lamp exists and align success
CAD model loaded successfully

I'm trying to Hello World with osmesa and PyOpenGL to see if the problem is there. Keep you updated.

In fact I managed today to make it work by deleting the osmesa content and replacing everything by this python file:
https://gist.github.com/NestarZ/9b358dfbe2a730bc6be2f0b3c0e929fa
It almost the same content as osdemo.c but only with python.
It works after doing this:
apt-get update && apt-get install -y libosmesa6-dev freeglut3-dev

There is a last problem I need to solve to replicate your awesome paper results and with your code.

How can I input a single RGB image to this algorithm that isn't in the data folder ?

I figured that every image have multiple files associated (a pickle file for pg, a depth map, a normal mal and a semgentation map). But what if I don't have them ?
Thanks,
Elias

Nice! You can now try our examples.
The generating of initial parse graph is composed by several different modules, those modules could be run in some certain environments. We are still merging those modules currently. Hopefully they could be released in the following month.


Make donation links more prominent + add alert

Adds donation links to the main QS menu, and to the menu bar icon
Adds a donation alert, which opens on Quicksilver startup

The donation alert appears for any of the following:

User upgraded Quicksilver
User hasn't seen the alert for 1 week

The alert will be suppressed for the following:

It's the first time the user's launched Quicksilver (we don't want to bother them if they're trying out Quicksilver for the first time)
The user checked 'Do not show again for this version', and they haven't just upgraded
For devs who've set a hidden pref (see here)

The only point worth making is that I guess a lot of users (like myself) only shut down their Macs every 2-3 weeks or months. That which means QS is only launched every 2-3 weeks or months, so the donation alert won't appear that often. I'm OK with that, and anyway - we give users the option to disable the alert anyway. The way to get the alert to appear more often is to make more releases of QS ;-)

I’ve been running a build with this included for a while without issue. I haven’t had time to look over the code closely, but I trust you. 😄
It’s been a while… [inhales deeply] MERGE!

I just remembered that we released 1.0.0 on March 25, 2013 so if you want to wait a couple of days… I doubt that anyone cares though.

Looks pretty good to me. The links work.
How to I force it to pop-up again? I didn't see the "Do not show again" button and wanted to check that out. Tried deleting caches, cleaning and rebuilding,
$ grep -r -i -a donation ~/Library/Application\ Support/Quicksilver ~/Library/Preferences/com.blacktree.Quicksilver.plist
$

It'll only remind you once per week, maximum.


Check the udf output size which should be equal to the input size

          Hmmm...or we should check the result size of udf? I'm not sure wether it's proper that the sizes of input and result could be different. cc @alamb @mingmwang @tustvold

Originally posted by @doki23 in https://github.com/apache/arrow-datafusion/issues/5635#issuecomment-1475092781

@alamb @doki23 it seems that this issue is fixed?

@alamb @doki23 it seems that this issue is fixed?

I'm not sure :(

I think the idea of this ticket was to put some basic checks / assert to ensure that the output of UDFs has the correct
As I understand it this would mean adding (or seeing if there was an assert) that the number of output rows from accumulators was correct
Maybe somewhere in
https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-plan/src/aggregates/row_hash.rs

Hi, i would like to take this issue

So the idea here is that we add a check after invoking a ScalarUDF that the number of rows that came out was the same as the number that went in. If this is not the case DataFusion should raise an internal error with a clear error message

This was implemented in this PR (and we fixed 2 existing UDF violating this violation)


Publish to NuGet

So that people can actually use it!

I added a GitHub Action to do this and the first preview is out now! 🎉


Currently, it only outputs some errors, but it’s still very buggy; most of the code I wrote lives in numbat-lsp/src/main.rs. Almost everything else comes from this repo that I cloned.
https://github.com/user-attachments/assets/6831dff5-662b-42be-9755-a6d237ad5284
Adding support for completion + gotodefinition doesn't seem impossible.
Maybe we could even push further and get the types to work.
I was wondering if this was the kind of stuff you would be willing to accept in the future?

Currently, I’m hitting this bug a lot: https://github.com/ebkalderon/tower-lsp/issues/413
I’m not sure, but maybe tower-lsp is not really prod ready, and we'll need to move out of it? 😩

Awesome stuff :smile:. LSP is definitely something I'd like to look into. I only had a very brief look into how this works and it seems like you run numbat::Context::interpret* and then collect errors from there. Is this a sane approach to building a language server? What if there are side effects? I would imagine a language server only runs frontend of the compiler (tokenizer-parser-typechecker), but not the backend (code generation and execution), where no errors can occur.

Just popping in because this is a topic I'm familiar with.

Is this a sane approach to building a language server?

It's not too bad. Rust-Analyzer gets most of its diagnostics from running rustc upon saving the file. There are some diagnostics baked in though, and it does have a front-end and part of the middle end in it for semantic analysis. The sema implemented allows for "go-to definition", semantic token highlighting, completion, and "lightbulb" refactors among other things.
So in reality having a front-end is pretty much required.
The front-end should have a lossless view of the syntax, what this really ends up meaning is having a concrete syntax tree rather than an abstract syntax tree so that refactors don't clobber trivia. This is also great for formatters and rustfmt hits this limitation, and rustfmt has been considering switching to a CST.
Other useful posts:
https://rust-analyzer.github.io/blog/2020/09/28/how-to-make-a-light-bulb.html
https://rust-analyzer.github.io/blog/2019/11/13/find-usages.html

It's not too bad. Rust-Analyzer gets most of its diagnostics from running rustc upon saving the file.

Ok, but the rustc backend doesn't execute the code. numbat::Context::interpret runs the whole compiler and the execution on the bytecode VM. This is what I meant by: "is this a sane approach …".

So in reality having a front-end is pretty much required.

I have no issue with that. I would also imagine the Numbat LSP to reuse the tokenizer, parser, and semantic analysis stages (prefix handling, name resolution, type checker) of the compiler.

The front-end should have a lossless view of the syntax, what this really ends up meaning is having a concrete syntax tree rather than an abstract syntax tree so that refactors don't clobber trivia. This is also great for formatters and rustfmt hits this limitation, and rustfmt has been considering switching to a CST.

That's something we definitely don't have at the moment. We lose all whitespace information (and things like parens in expressions, see also #102) during parsing.

I would definitely look into generating CST structures with ungrammar as I do find that construction pretty valuable for your parser, so you don't throw information away that would be useful for LSP things and error reporting.
Another thing would be making the lexer infallible in a similar vein to how your parser is already. The most common way of doing that is making an error token that can be emitted. So then the type signature of the lexer would become fn scan(&mut self) -> Vec<Token>. Adding a debug config that checks that all tokens are contiguous is also a good idea for testing. Here's an example of how I've done it in the past.
https://github.com/RossSmyth/meowfile/blob/2a89f23f1a34a27b3275de9d004113deed3f6932/crates/lex/src/lib.rs#L16-L19


Add llamaindex integration cookbook

This is work in progress. Before merging, potential bugs (https://linear.app/langfuse/issue/LF-1519/llamaindex-bug-decorator-are-not-detecting-generations-and-not-logging, https://linear.app/langfuse/issue/LF-1518/llamaindex-bug-single-llm-call-creates-two-traces, https://linear.app/langfuse/issue/LF-1517/llamaindex-bug-settingcallback-manager-does-not-work) have to be reviewed/fixed and results have to be discussed.

For the cookbook to run, one has to install a langfuse version that supports decorators (e.g, 2.20.2a3)

Note that example 1 and 2 in this issue are also very good examples of interoperability although they do not log to Langfuse due to a bug with the LlamaIndex CallbackHandler (https://linear.app/langfuse/issue/LFE-650/llamaindex-integration-interoperability-not-working-with-query-engines)


Haiku fixes for nix

Looks like there are CI failures?

Ah, this is because of #[cfg(not(target_os = "haiku"))] in unix/mod.rs.
I guess I'll need to move definitions of POLL* & RTLD_LAZY into all of the submodules...

@bors: r+

:pushpin: Commit 0d822be has been approved by alexcrichton

:hourglass: Testing commit 0d822be88c717ee03817d518e7b81635b03deded with merge 209468a67345caba39b6d40fd6f08efed68106ef...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 209468a67345caba39b6d40fd6f08efed68106ef to master...


Add an option to start an "silent" action

I think it could be useful if it was possible to start/finish an action, but not having the start/finish messages logged out.
That would mean we'd still be able to track individual tasks (task_uuid) and order/level of the tasks ( task_level), but we don't care when they were started/finished.
That would also mean a possibility to start&finish action silently - without any messages explicitly logged out, an action would be invisible. And that's actually cool - in our case, we don't care about 80% of the requests & so we don't want to have anything logged.
If the "silent" actions were available, we could simply start a task/action all the time, then log something if we need it, without getting hundreds of meaningless lines.
Do you think this would make sense?

We've been talking at ClusterHQ about similar issues where we have noisy logs, we'll see what we come up with. One worry I have with silent actions is that it makes the task tree have missing nodes, which will be confusing (and hard to distinguish from logging bugs).

Instead of a silent action, what about an abridged action? I think the only output necessary to avoid the missing nodes problem is at task ID and a task level.

Well, abridged action wouldn't really help us - we literally don't care about 80%+ of the requests, so even abridged start+end would result in a lot of clutter. It could be made configurable, I guess?
I'm sure Itamar will come up with something cool though :)

You say you "don't care about 80% of messages". Why are they logged in the first place? Could you remove that logging? Or is it that you sometimes care and sometimes don't? In which case, how do you distinguish between the cases?

Here's a use case we have: we're using machinist state machine library, the logs state transitions using Eliot. In a complex state machine this is probably useful. In our case it turns out we don't actually care for some of our state machines.

The use case was kind of an on-line store. As long as people are browsing through products, we don't really want to log anything - we're indexing ngingx access logs, so we don't need logs.
But, once a user performs an actual action (adding to a basket, paying, etc) all kind of logging kicks in, with multiple messages and levels - we wanted to have whole all logs coming from a single request to share task_uuid and levels mechanism.
Now, I could modify our logger to actually start action as soon as we log anything, but that quickly becomes messy - storing states, manually closing things, handling exceptions.
Having starting a single "silent" action per-request, with a simple context manager, seemed like a much cleaner idea, and, honestly, easier to implement on eliot itself?

Hm. If you want to suppress a full action, I can imagine something like with silence_logging(), yeah. Not sure if that quite deals with our use case...

Internally we've discussed post-facto silencing: I've discovered current action isn't worth logging. This requires some sort of buffering layer, otherwise those logs will end up being logged before you can make the decision. On the other hand you don't want to lose them if the process crashes.

http://www.exampler.com/writing/ring-buffer.pdf talks about some relevant patterns. @jml

Sorry, I don't know how to solve your use case. Also, I don't see how a ring-buffer could help :/
I'm not sure if both of our cases can we solved by the same feature. I mean, if you figure out how to solve your thing, I'm sure we could adapt it to our problem (since our is much simpler :)), but maybe we would need two separate solutions?
Have you considered an external post-processing tool? Like, still dumping everything on disk, and only then filtering things out? I cannot say if it would be worth the effort though.
Or, some kind of learning system? Make it guess if a message is likely to be interesting? That's assuming you can accept having some false negatives?

Your use case is as I understand that you know in advance whether a set of actions are important. Ours is post-facto - 90%-through we realize that this action has been a no-op so not worth logging. So yeah more complex use case, and supporting yours would be easier.

So here's a sketch of a design (also relevant to use case from @keturn):

Provide a passthrough filtering destination for logs is configured with another destination, the one you want logs to end up when you care about them, e.g. /var/log or logstash or whatever.
The filtering destination has an on-disk task level temporary ring buffer. That is, it stores up to N tasks, when N+1 arrives the oldest finished one is deleted. Because it'll be a relatively small number the hope is it'll mostly stay in OS buffers and never actually hit disk.
When certain conditions are met (could be explicit request from business logic code "this task is about logged in user", or could be pre-configured rules within the filter itself like "eliot:traceback was logged") a specific task, or sometimes all current in-progress tasks, are marked as important. That means all messages in the ring buffer and all future messages are for that particular task are passed on to the final destination.

Bunch of edge cases to think though, but the goal is:

Only important tasks are passed on to the more permanent log storage... and what gets passed through is the whole task.
Importance of a task does not need to be decided in advance.
In-progress and recent tasks are available for post-mortem debugging after process crashes.

@jml might be interested too --^

Downsides of this design is that you still have CPU overhead of serializing messages you mostly don't care about.

I guess in-memory ring buffer is also an option for people who want to swap crash-resistance for performance.

Sounds pretty sensible.
Would suggest making the filtering abstraction completely unaware of ring buffer and the like, and providing an implementation that provides the ring buffer stuff.
Not 100% clear how one would implement a filter for "only failed tasks", nor how/whether that would summarize a lot of the boring logs that make up that task (e.g. in our machinist examples). Would like to see an imagined example.
I guess the start action / stop action thing is in fundamental tension with crash-resistance.
I'd like to see an imagined before and after example using the flocker logs to get a better idea of what we're aiming for.

This does not involve any summarization; the filter is "include whole task or not'. Possibly summarization is better handled by omitting in the code log messages we know are pointless, though that likely requires new eliot APIs too...
"Only failed tasks" is application-specific and perhaps not quite comprehensive enough, which is why I talked about importance. Some variations of importance might include:

A eliot:traceback was logged.
Any action within the task failed.
The top-level action (the task) failed.
This is an operation by a logged-in user (use case from @rabbit).
A deadlock occurred; this means all in-progress tasks are relevant (use case from @keturn).
Flocker convergence loop iterations that are not boring, where boring is defined as "configuration and state were the same as previous iteration and no actions were calculated as being necessary."

It's not clear to me if ring buffer can really be omitted given you don't know importance up front.

And yeah, will want to provide a bunch of examples before proceeding.

I added a coupe of use cases above.


Upgrading uglify, adding lock file

Upgraded uglifyJS to fix security vulnerabilities.
Fix for:
https://github.com/marcuswestin/require/issues/9
https://github.com/marcuswestin/require/issues/11

Please merge this. :+1:


Records  like a/24 or mx/24 ignores net mask

records like a/24 and mx/24 get ignored.
Example:
dig +time=1 +short -t TXT mail.fcsny.com
"v=spf1 a/24 mx/24 -all"

./despf.sh mail.fcsny.com
ip4:<IP_ADDRESS>

I see it in SPF docs, but it's a strange thing as there is no distinction between IPv4 and IPv6 a in SPF. So if I set a/24 and AAAA record for that domain is set, I get fec0::7/24 :-) But I hope everyone who uses a/netmask or mx/netmask know what they are doing.
Thanks for the patch! Feel free to close now. There are also tests in #52


NO css loading

I have successfully installed Huginn but as image attached no css is loading although functions looks to be working.

Can you please tell me what is wrong ?

You likely need to compile assets.  How did you install Huginn?  Via the https://github.com/cantino/huginn/blob/master/doc/manual/README.md guide?

Yes did exactly as in the guide above.

I have that messages while compiling ruby after command "make -jnproc"
Failed to configure -test-/win32/console. It will not be installed.
configuring -test-/win32/dln
Failed to configure -test-/win32/dln. It will not be installed.
Failed to configure -test-/win32/dln/empty. It will not be installed.
configuring -test-/win32/fd_setsize
Failed to configure -test-/win32/fd_setsize. It will not be installed.

This looks like you are running on windows? We only support *NIX operating systems for the manual installation guide. I recommend you have a look at out docker images.

NO I have installed on Ubuntu 14

I see, you might have the same problem as described in this issue.

@dsander Thank you your reference solution fixed it :)

Great, glad it works.

@somadona Do you have a suggestion on where we could add a warning to the docs to make this clearer?

@cantino Sure I recommend make the following change on here:
https://github.com/cantino/huginn/blob/master/doc/manual/installation.md
Install Init Script
Huginn uses foreman to generate the init scripts based on a Procfile
Edit the Procfile and choose one of the suggested versions for production:
sudo -u huginn -H editor Procfile
To be:
Install Init Script
Huginn uses foreman to generate the init scripts based on a Procfile
Edit the Procfile and choose one of the suggested versions for production:
sudo -u huginn -H editor Procfile
Comment out (disable) these two lines
web: bundle exec rails server -p ${PORT-3000} -b ${IP-<IP_ADDRESS>}
jobs: bundle exec rails runner bin/threaded.rb
Enable (remove the comment) from these lines
web: bundle exec unicorn -c config/unicorn.rb
jobs: bundle exec rails runner bin/threaded.rb

Thanks @somadona, @dsander just made these changes.


Fix security issues cluster-proxy-addon.

Signed-off-by: xuezhaojun<EMAIL_ADDRESS>

/hold
Wait for this PR merged.

/assign @eemurphy Sorry for the discussion caused by the PR merge timing, this PR keeps holding until the cluster-proxy-addon changes PR merged. And I tested this build in my test env and it works fine.
Please take a look when you have free time! Thanks!

/assign @eemurphy
Sorry for the confusion caused by the PR merge timing, this PR keeps holding until the cluster-proxy-addon changes PR merged. And I tested this build in my test env and it works fine.
Please take a look when you have free time! Thanks!

/unhold
unhold the PR since the cluster-proxy-addon PR is merged.


this will add the login component with basic styling

Closed btw, it's directed to main branch. Submitted another pull request to dev


fix for RAC-6006

We need to update docker daemon to 17.06 where ARG preceding FROM is supported
use ARG to set the tag instead of  the sed command

@geoff-reid  @hohene @johren

adding docker release notes:
https://docs.docker.com/release-notes/docker-ce/


Initial Commit of Mobile Sample

Mobile Office 365 REST API cross-platform sample using Apache Cordova and ADAL Cordova plugin to obtain access token.

thx Bill, we'll have a look on this during up coming days. Target is to get it merged for the April release.

thx Bill. Sorry for the delay on this one. Resourcing challenges.

Missed this one - just to group this one with other Microsoft Graph samples, renamed the folder slightly. Now located in https://github.com/OfficeDev/PnP/tree/dev/Samples/MicrosoftGraph.Cordova.Mobile

Thanks. Wasn't sure about the name.


Enhancement: floating point zoom optional set up

From @spyhunter99 in #640:

it would be useful and/or feasible to making the floating point zoom be optional or be able to be disabled? I'm thinking about potential issues users may have with custom layer setups

float zoom level values will alows for displaying maps at non integer zoom values. Then it will be possible to zoom with two fingers (like on GoogleMap).
I do this on my fork of this projects but it is a huge refactoring!

@ycuicui Actually floating point zoom is already implemented in 6.0.0 and is the only way the zoom works now.
The question here is for the user to be able to switch back to integer zoom for nostalgia reasons.
-------- Message d'origine --------
De : ycuicui<EMAIL_ADDRESS>Date : 10/11/2017 21:57 (GMT+01:00)
À : osmdroid/osmdroid<EMAIL_ADDRESS>Cc : monsieurtanuki<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Objet : Re: [osmdroid/osmdroid] Enhancement: floating point zoom optional set up (#703)
float zoom level values will alows for displaying maps at non integer zoom values. Then it will be possible to zoom with two fingers (like on GoogleMap).
I do this on my fork of this projects but it is a huge refactoring!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/osmdroid/osmdroid/issues/703#issuecomment-343583782, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALCkb6U7ucozVj4rPAkKjs53tEFmMa8Pks5s1LjNgaJpZM4PLHCs.

i'd say it's low priority, compared to the remaining open issues. this could even be for the follow up version

@spyhunter99 The way things are evolving (including recently smooth pinch gesture zoom), it will be very hard to make it possible to switch back to integer-only zoom. Unless you have a use case in mind, I think we could close and forget this issue.


Is there a way to use ORM vars with null values?

ex:
// orm creation/etc omitted
orm_addvar_int(ormid, data[playerid][P_FACTION_ID], "faction_id"); // <- Foreign key,  accepts NULL (no faction)

Register(playerid)
{
  //  what should i use to set it NULL ?
  data[playerid][P_FACTION_ID] = 0; //  0 != NULL. It's not an option in factions (there's not a faction=0 row) and of course it produces:
  orm_insert(ormid);  //  Error: Cannot add or update a child row: a foreign key constraint fails
}

orm can be set to null though but the thing is a foreign can't become null since it should never be null and should carry a value of what its foreign of... i.e a userid from a character details in the database is a foreign key to the primary ket of the userid of the accounts details in the database... You can null a non key variable...

@earltacs what do you mean by "should never be null"?
Anyway, joining the problem of the issue,  I have following scenario:
h_number and h_owner_ID in houses table in database, first one is just the int, second one is nullable int field that is foreign key also.
I'm trying to assign ORM to this.
For example, I have the house with number 3 and no owner, so it's null in DB.
After orm_apply_cache, changing the number, I want to save changes with orm_save() but I simply can't do that cause owner_ID became 0 in pawn, so we've got this:

error #1452 while executing query "UPDATE houses SET h_number='5',h_owner_ID='0' WHERE h_ID='1' LIMIT 1": Cannot add or update a child row: a foreign key constraint fails

Does it mean that it's not able to work with not nulls(as it's in pawno) at all and I must change my columns in database, disabling Foreign Keys and set "no-owner values" to simple int zero?

The ORM system doesn't support the NULL value yet, that's why I assigned this issue to me. I currently don't have the time to work on this, but I'll look into this problem in detail when I'm free.

@maddinat0r Thank you! Will be very glad to see this update in the future!

The only reason I'm not using ORM is because NULL doesn't work. pls fix!

It is impossible to use ORM, in that NULL does not work. please fix!

After long time, please fix, joke, at least we need method where we can check is column (in this scenario FK ) mapper to var, basically orm_does_var_exist, if does if u need to map FK with good FK value orm_addvar_int, otherwise if u want to remove orm_delvar


Refactor components (Obsolete)

Description

Refactoring BasicSide component to use MUI Drawer components (List, ListItem, ListItemButton ...).
Refactoring BasicHeader, for now extracted BasicAutocomplete as a standalone React component.

Since the changes touch on multiple files, I will try to fix them in multiple smaller PRs. Hence why i'm closing this.


Added Canvas.DrawImage (#784)

As per #784, this introduces a DrawImage(Material / BatchInfo) to the Canvas.
The code has been taken inspiration from FillRect, but feel free to add suggestions on how it can be improved

👍

Thanks! Finally managed to look into this again and update the review.
Instead of requesting a few more changes, I took the time to add them myself right away, to avoid going stale again, since I think this is a pretty useful feature. Some of the changes were not part of earlier review requests and only occurred to me when doing a more thorough review today, checking out the most recent changes. I know it's not the cleanest way to go through with this PR, but right now it's the best I can manage, given the limited time I have - sorry about that, but I hope that's fine with you.
Changes I made and rationale behind them:

Premise: DrawImage is a shortcut that aims specifically to fit the "I want to draw this texture as-is" use case, since all others are better off with existing, more complex / verbose API.
Removed all ContentRef<Material> and BatchInfo overloads, since they are easily available via canvas.State.SetMaterial if needed.
Removed all overloads that allow to specify with and height, since they're already available via canvas.FillRect when setting the material beforehand.
Added a unit test for DrawImage.


The 'Generate commit message' button is not displaying.

VS Code Version: 1.85.0
OS Version: Ubuntu 20.04 x64

Make some changes in the project
Stage changes
There should have been a "sparkle" button, but it's not there.

Copilot is working, copilot chat is also working

Upd.
This error occurs when I add two or more repositories to the project.
When I have only one repo in the workspace, it works fine.

Thank you @BorovlevAS , this thing was driving me crazy! The thing is that if you also have Gitlens installed, the gitlens takes over asking for an openai key.
This happens only if I have multiple repositories in my project (currently I have a git submodule). A workaround is to change the settings.json with:
``` "git.openRepositoryInParentFolders": "root",````

"git.openRepositoryInParentFolders": "root",
But there are only these three options available:

never
always
prompt

Yeah same issue over here. I wonder what I gotta do to make it work again...


Can't Build for tvOS - generateXcprivacy issue

Just tried a couple of projects I have not built for tvOS for a while and I'm getting:
CoronaBuilder: ERROR: Runtime error /Users/runner/work/corona/corona/platform/resources/tvosPackageApp.lua:984: attempt to call global 'generateXcprivacy' (a nil value) stack traceback: 	[C]: in function 'generateXcprivacy' 	/Users/runner/work/corona/corona/platform/resources/generateXcprivacy:984: in function 'generateFiles' 	/Users/runner/work/corona/corona/platform/resources/tvosPackageApp.lua:2011: in function </Users/runner/work/corona/corona/platform/resources/tvosPackageApp.lua:1750> CoronaBuilder: tvOS build failed (2) after 14 seconds
I've had a quick look at the file in question and it seems to me that in tvosPackageApp.lua, the function:
generateXcprivacy( options )
has been added at line 1012 which is after the line it gets called (984).
In the other files iPhonePackageApp.lua & OSXPackageApp.lua the function was added before it is called.
Seems like it was added in this commit:
https://github.com/coronalabs/corona/pull/690/commits/192fd1ad15980afeec23e5b42673038efadd7e37

Added a pull request - I can't build to test but it should work!
https://github.com/coronalabs/corona/pull/753


TS:1.0 - css type is {} when using React.ComponentProps

Repro code:
const StyledStatus = styled('span', {
  color: 'red',
  variants: {
    mySize: {
      myLarge: {},
    },
  },
});

export const Status = React.forwardRef<HTMLSpanElement, React.ComponentProps<typeof StyledStatus>>(
  (props, forwardedRef) => {
    return <StyledStatus aria-hidden {...props} ref={forwardedRef} />;
  }
);

export default function Home() {
  return <Status css={{ /* this should be typed! */ }} />
}

Just tested this today with latest build from canary but still not working

This should be working, but there is an issue with React.forwardRef that I think is unrelated to Stitches. See the following code that does not work, and does not include anything from Stitches —
const Generic = function(props: { happy?: true }) {
	return null
}

export const GenericForwardRef = React.forwardRef<
	HTMLSpanElement,
	React.ComponentProps<typeof Generic>
>(
	(props, forwardedRef) => {
		return <Generic {...props} />;
	}
)

export function GenericForwardRefPage() {
	return <StyledForwardRef />
}

Fixed in V1. Please refer to migration guide and changelog


Add "line style" and "marker style" for 1D plots - similar to colour property

As suggested by @lindaudby, line style should be configurable and probably default to "no line" for things loaded via iData.
Shorthand syntax inspiration from Matlab available here: https://se.mathworks.com/help/matlab/ref/linespec.html
e.g. red crosses and no line would in matlab be 'rx'.
I suggest to make another widget supplementing the Colour widget with e.g. x- to signify cross and line, +: to indicate plus and dots etc..

Simplified tasks defined in #2 and #3, closing this one


Standarize examples

Several fixes/changes:

stressng syntax error issues.
So work in standardizing our examples.
Enables verify_cert to all workloads wrapped by snafu.

Helps fixing some issues from https://github.com/cloud-bulldozer/benchmark-operator/issues/520

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
0
00:04:35

test_byowl
Pass
0
00:01:23

test_fiod
Pass
0
00:18:20

test_fs_drift
Pass
0
00:04:48

test_hammerdb
Pass
0
00:03:57

test_iperf3
Pass
0
00:06:36

test_kubeburner
Pass
0
00:17:24

test_pgbench
Pass
0
00:02:58

test_smallfile
Pass
0
00:05:01

test_stressng
Pass
0
00:01:55

test_sysbench
Pass
0
00:01:18

test_uperf
Pass
0
00:25:05

test_vegeta
Pass
0
00:04:26

test_ycsb
Pass
0
00:02:04

test_scale_openshift
Pass
0
00:08:42

/rerun all

Results for ec2_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
0
00:04:07

test_byowl
Pass
0
00:01:09

test_fiod
Pass
0
00:18:17

test_fs_drift
Pass
0
00:04:51

test_hammerdb
Pass
0
00:03:52

test_iperf3
Pass
0
00:06:36

test_kubeburner
Pass
0
00:16:52

test_pgbench
Pass
0
00:02:51

test_smallfile
Pass
0
00:04:57

test_stressng
Pass
0
00:01:51

test_sysbench
Pass
0
00:01:16

test_uperf
Pass
0
00:25:06

test_vegeta
Pass
0
00:04:11

test_ycsb
Pass
0
00:01:50

test_scale_openshift
Pass
0
00:08:28


Chrome JSONView extension

It might be worth suggesting people install the JSONView extension to make the last part more legible.

Great suggestion - I will add this. Thanks @JWLD


Try switching to  askama for templates

https://github.com/djc/askama

Looked into it, benefits didn't outweigh the cost of conversion.


add transport interface

Codecov Report

Merging #20 (45bbe2e) into master (128ce85) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 128ce85...45bbe2e. Read the comment docs.


SAK-29851 - Web service to copy Lessons pages from site to site.

Changed Vector() for ArrayList().

It seems by the logs that checks have failed due to Samigo. How could I repeat the checks from Github? Or should I push the PR again?

I've kicked off the build again.

If there is separate handling needed for a single tool, see example "Resources" its fine to put some logic related to that but a completely new method doesn't seem reasonable.

Hi Danny,
Can you create a unit test for this web service?

I have this issue on the agenda to fix the code and use a single method, but not in short term. When I do that, I will try to include a unit test.

I delete this branch, this has been solved in SAK-31123.


Update gpg_helper to add in the --no-tty

By adding this option it allows to run for rake tasks

Thanks! I've published version 0.4.0 of this gem which incorporates this change.


micrometer: adds configuration to skip tracing health

workaround to https://github.com/spring-projects/spring-boot/issues/34801 to prevent excessive health traces in zipkin

thanks for the look folks. thanks also @ryanjbaxter for the workaround


Add support for Consul 0.7.1

Oops, I've made a mistake while trying to rebase the PR branch. Really sorry about that 😞
Re-created a PR: #374


android okhttp3 has a 403 Forbidden question,call swankjesse~

Thank you for answer me,swankjesse! this is my first to submit issues, so maybe is not so good, hope you forgive.
Ok,here is my test case.Maybe the layout is not so good.But you just need to copy and paste it.
@Test public void testDoGetByOkHttp() { String[] urls = new String[]{ "http://c.m.163.com/nc/video/list/V9LG4B3A0/n/0-10.html", "http://c.m.163.com/nc/video/list/V9LG4CHOR/n/0-10.html", "http://c.m.163.com/nc/video/list/V9LG4E6VR/n/0-10.html", "http://c.m.163.com/nc/video/list/00850FRB/n/0-10.html" }; for (int i = 0; i < urls.length; i++) { String value = OkHttp3Utils.doGetByOkHttp(urls[i]); Assert.assertNotNull(value); } }
@Test public void testDoGetByConnection() { String[] urls = new String[]{ "http://c.m.163.com/nc/video/list/V9LG4B3A0/n/0-10.html", "http://c.m.163.com/nc/video/list/V9LG4CHOR/n/0-10.html", "http://c.m.163.com/nc/video/list/V9LG4E6VR/n/0-10.html", "http://c.m.163.com/nc/video/list/00850FRB/n/0-10.html" }; for (int i = 0; i < urls.length; i++) { String value = HttpURLConnectionUtils.doGetByConnection(urls[i]); Assert.assertNotNull(value); } }
My OkHttp3Utils class source code is:
public static String doGetByOkHttp(String url) { Request request = new Request.Builder().url(url).build(); try { Response response = new OkHttpClient.Builder() .connectTimeout(10000, TimeUnit.MILLISECONDS) .readTimeout(10000, TimeUnit.MILLISECONDS) .build().newCall(request).execute(); if (response.isSuccessful()) return response.body().string(); } catch (IOException e) { e.printStackTrace(); } return null; }
My HttpURLConnectionUtils class source code is:
public static String doGetByConnection(String url) { BufferedReader reader = null; try { HttpURLConnection connection = (HttpURLConnection) new URL(url).openConnection(); connection.setDoInput(true); connection.setDoOutput(true); connection.setConnectTimeout(10000); connection.setReadTimeout(10000); connection.setRequestMethod("GET"); int code = connection.getResponseCode(); if (code == 200) { reader = new BufferedReader(new InputStreamReader(connection.getInputStream())); StringBuilder builder = new StringBuilder(); int len = 2048; char[] cbuf = new char[len]; while ((len = reader.read(cbuf)) != -1) builder.append(cbuf, 0, len); return builder.toString(); } } catch (IOException e) { e.printStackTrace(); } finally { if (reader != null) { try { reader.close(); } catch (IOException e) { e.printStackTrace(); } } } return null; }
And you can use the browser to test urls, you will find that you can still get the datas.

This appears to be a problem with that particular webserver. Sometimes it returns 403s and sometimes it returns 200s. Nothing we can do unfortunately.


Should return 400 ApiVersionUnspecified but instead returns 404

I have following setup and I want version specified in the route path.
config.AddApiVersioning(opt =>
	{
		opt.ReportApiVersions = true;
		opt.AssumeDefaultVersionWhenUnspecified = false;
	}
);

config.AddVersionedApiExplorer();

// Web API routes
config.MapHttpAttributeRoutes(
	new DefaultInlineConstraintResolver
	{
		ConstraintMap =
		{
			["apiVersion"] = typeof(ApiVersionRouteConstraint)
		}
	}
);
config.Routes.MapHttpRoute(
	"DefaultApi",
	"api/{controller}/{id}",
	new { id = RouteParameter.Optional }
);

Following tests were done:

api/v1/values => 200
api/v2/values => 200
api/v3/values => 400 (UnsupportedApiVersion)
api/values => 404 (should return 400 ApiVersionUnspecified)

Error Resposne:
{"Message":"No HTTP resource was found that matches the request URI 'http://localhost:56057/api/values'.","MessageDetail":"No type was found that matches the controller named 'values'."}

@sabmah apologies for the delayed response. Unfortunately, in the particular scenario this is the expected behavior and is yet another consequence of versioning by URL segment (which I'm not a fan of).
API versioning can tell that an API version is required in the path when you have the route constraint present in your route template. It can also allow it to be omitted if you so configure it that way. However, it cannot disambiguate between a route that truly doesn't exist (ex: api/i-do-not-exist) and should return 404 versus a route that is missing an API version by convention. The only way API versioning knows that an API version is required in this scenario is via the route constraint.
In your particular scenario and configuration, there is never a scenario were api/values could exist so 404 is the correct response. The reason responses are 400 versus 404 all the time is a bit of a gray area. API Versioning will use 400 when an unmatched route could match. The correlation is all done with URLs and in this case, the paths do not match up.
I hope that helps clarify things.

It seems this issue was resolved or otherwise abandoned. If you still have questions or issues, feel free to come back and/or reopen the issue. Thanks.


Added my contributor details to index.html

For validation my limited contributions so far are at
https://github.com/vert-x/vertx-gradle-template/pull/23 and
https://github.com/vert-x/mod-lang-groovy/pull/75
I assumed you wouldn't want the contribution links to be built into the actual page though.

Thanks!
Would you mind adding an avatar? You can of course use your GitHub avatar if you don't have another picture: https://avatars.githubusercontent.com/u/1318862?v=3&s=80

I will do. Would you like me to add to this PR or close this one and raise a new one when I've added the avatar and flattened into one commit?

In fact you could do a git commit --amend and a git push -f to update the PR, but I really don't care :-) Do whatever suits you :-)

Done, I broke the rule I give our developers which is not to amend commits on branches we have already pushed, but it doesn’t matter since noone else has committed to my fork, nor have you already merged the PR.
Have a good weekend


rs rasterize requires an undocumented --dataset option

rs rasterize won't work unless you pass in a --dataset option, this isn't documented, and the file format isn't documented. For the record here's a file I've cobbled together, it makes the command not complain:
[common]
classes = ["notbuilding", "building"]
colors = ["dark", "white"]

Most tools require dataset or model configs by now. Check out the configs in
https://github.com/mapbox/robosat/tree/121057b96607d2ae9b2740edfa15fd607c1cb9b0/config
We should document that better.


Subscriptions/Public pages: we're saying that you're subscribed even if you aren't

Fixed in #2239


Add mutex stress test

as a part of stress-testing we want to ensure that mutex implementation is working correctly and protecting shared resource to be allocated from other threads when mutex is locked.
This test covers the most common situations that happen when some program uses mutexes like locks from various threads, locks from the same thread etc
If you have any other cases that left uncovered please mention them in the comments
cc @loganek @g0djan @eloparco

LGTM


Blazor Client Side Project Razor tag InputNumber Visual Studio syntax error

In a Blazor Client Side project, the following InputNumber tag causes Visual Studio to display an error.
<InputNumber id="todoPriorityNumber"<EMAIL_ADDRESS>class="form-control" />
This is the error message.
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0411	The type arguments for method 'TypeInference.CreateInputNumber_0(RenderTreeBuilder, int, int, string, int, string, int, object, int, object)' cannot be inferred from the usage. Try specifying the type arguments explicitly.	BlazorClient1 C:\Users\vmtest\source\repos\BlazorClient1\BlazorClient1\Pages\Todo.razor	1	Active

However, the project can be compiled without error.
Changing attibute bind-value to bind-Value (uppercase V) seems make the error going away. However, the bind attribute should not be case sensitive.

Thanks for contacting us, @zzhang2001.
The problem you're facing is because component attributes are case-sensitive. This is by design.


Add //external:zlib as dependency of grpc_unsecure target

When I was building grpc on Windows for TensorFlow, zlib was required by grpc++_unsecure target. There is already a PR to add this dependency in TF repo, it's better to also add it in original repo to keep the minimal difference between the BUILD files.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

this is ok to test
(magical Jenkins invocation)

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Out of date, closing.


Add zc.lockfile.LockError handling to locks.file_lock

Following @StabbarN lead for issue #38 and fix in #39, I added a timeout loop and exception handling for the exception raised by zc.lockfile.
Working on getting tox to run for your unit tests, figured I would open the PR in the meanwhile.
Testing against SatelliteQE/Robottelo unit tests where this was encountered after the update to pytest-services 2.2.0 is successful, for what its worth.

This change is

@mshriver please add a changelog record and update the authors file

@mshriver travis seems to be stuck

Coverage decreased (-0.7%) to 70.772% when pulling 705bfd8fefe4458376634e8cc6d4288d0b9dfe6a on mshriver:fix-zc-lock-file into 451debde7db6818e758caf1e3d9f72d756594de5 on pytest-dev:master.

@bubenkoff I've noticed travis taking quite some time to start builds, but it looks like it ran and completely successfully since you mentioned it being stuck.  That being said, I should add a file_lock unit test, as I don't see one currently.  I would hate to fix it for my use and break it for someone else.

@mshriver thanks, 2.2.1 is out

@bubenkoff Thanks so much! Really appreciate your time to review and merge this.  Thanks @StabbarN for the original fix pattern, made it incredibly easy to identify and resolve this issue.


Use default Eloquent where() method in Laravel 5.2 and above

A new inspection was created.

The inspection completed: 1 updated code elements


springdoc-jwt: add authorization in header and improve documentation

Fix #4273

Hello @pascalgrimaud,
I fill the token in the header and improve the documentation 👍

Thanks, I'll try to have a look and test it soon

Bounty Claimed https://opencollective.com/generator-jhipster/expenses/131945 😀👍
Thank you @pascalgrimaud !

@renanfranca : approved


It was not possible to find any installed .NET Core SDKs

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

It was not possible to find any installed .NET Core SDKs

What error message you're getting? Can you check what have you installed?
This doc goes over some ways to check: https://docs.microsoft.com/en-us/dotnet/core/install/how-to-detect-installed-versions


apache license on the header of the files?

Hello,
I've noticed that not all of the files have the Apache license on top of the code.
I was going to fix it but I'd like some clarification.
When the module as a docstring which should come first the docstring or the module docstring?
Example:
"""
Some docstring.
"""
# Copyright (c) 2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations under
# the License.

or
# Copyright (c) 2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations under
# the License.
"""
Some docstring.
"""

I would naturally scroll down any copyright header. So maybe after it than? :)

I think after yes. The license applies to the documentation as well :)

@erikbern and @themalkolm to double check I got it right,
it's example 2, right? license and then docstring?
for reference:

Apache 2.0 License > APPENDIX: How to apply the Apache License to your work

and something to consider...
https://www.clahub.com/pages/why_cla

long doc, what's the tl;dr? happy to do whatever's good for contributors :)

@erikbern can you clarify it's license-docstring please?
CLA is more to protect the project, I think...
The purpose of a CLA is to ensure that the guardian of a project's outputs has the
necessary ownership or grants of rights over all contributions to
allow them to distribute under the chosen licence.
In some cases this will mean that the contributor will assign the
copyright in all contributions to the project owner; in other cases,
they will grant an irrevocable licence to allow the
project maintainer to use the contribution.

in Contributor License Agreement

I don't understand what you mean about the license-docstring and the CLA quote. But let me know in more concrete terms what I should do. I don't care too much about license terms, and I'm happy to use the most liberal license there is

sorry I mixed two answers on the same comment.
so I understand correctly that his the format to be used?
# Copyright (c) 2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations under
# the License.
"""
Some docstring.
"""

regarding the CLA quote I'm not an expert so let me talk with a few people.
if I learn that something should be done I'll let you know.

Pretty sure everybody will be happy with the last example.

perfect.


Missing F1 Keywords

Learn Build status updates of commit 8cf8d31:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/relational-databases/system-dynamic-management-views/sys-dm-xtp-gc-queue-stats-transact-sql.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@rwestMSFT
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


More Tag Filtering and other updates

:wave: I have local changes that add:

tag_filter / tag_filter_id for Radarr - v3 just hit the main line and it was only working for Sonarr
Implemented new tag_exclude / tag_exclude_id for Sonarr and Radarr. Prevents items with a tag from being synced
client_id / client_secret - Supports Cloudflare access  where my remote Sonarr / Radarr live behind, which I would like to sync locally

Would a PR be welcome for any of the above changes?

I would appreciate the Radarr tag filter in the least, if you wanted to push that somewhere. I assumed it existed this morning and made a frustrating mistake due to that :)

I ended up discovering https://github.com/chrishoage/arrsync though searching GitHub repo tags and have since been using it instead.


DPL-263 - As a Heron lab user I would like to be able to upload Heron qPCR quants so I can see the concentrations in Limber (C=M, V=4)

User story
Currently qPCR quants are done manually and analysed in a spreadsheet. Thhis means that there is no concentration in Limber and they can't be validated. Heron qPCR results should be able to be uploaded to quanthub so the quants are stored in the warehouse for analysis and can be seen in Limber to validate concentrations.
Who are the primary contacts for this story
Sara / Scott G
Acceptance criteria
To be considered successful the solution must allow:

[x] There should be a Heron qPCR quant type
[x] There should be a different dilution factor than for standard qPCR - 0.000001424
[x] concentration in molarity by taking the median of n=8 replicates and multiplied by dilution factor
[x] the plate layout should max 8 samples, n=8 replicates in 4x2 blocks (plate map below)
[ ] the quant should be able to be exported to Sequencescape and in turn the warehouse
[ ] Lab users should be able to see those concentrations in Limber

Dependencies
This story is blocked by the following dependencies:

#<issue_no.>
sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

#<issue_no.>
sanger/#<issue_no.>

Additional context
Add any other context or screenshots about the feature request here.

Plate map:

Wells in Copycount output
Source well of 96-well plate

A1-A4,B1-B4
A1

C1-C4,D1-D4
B1

E1-E4,F1-F4
C1

G1-G4,H1-H4
D1

I1-I4,J1-J4
E1

K1-K4,L1-L4
F1

M1-M4,N1-N4
G1

O1-O4,P1-P4
H1

Example output file:
HT_132817_2897_2945_2956_HERON_16_2_22_results.csv

Meeting (16/03):

we could change the lightcycler output to add the tube barcodes
There are two types of output from the opycoun server
We could use a combination of those spreadsheets to provide the data we need
This would require R&D input to create a new protocol for the lightcycler

Things to clarify:

How big a piece of work is this for R&D
How big a piece of work is this for PSD
Is it a priority

HT134961_972_001_004_HERON_10_03_22_replicateSets.csv
HT134961_972_001_004_HERON_10_03_22_results.csv

Closed as not needed


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing, rkpagadala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: istio-testing, rkpagadala
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test istio-pilot-multicluster-e2e

prow//e2e-simpleTests-minProfile.sh
1f14fe41c5b9ed58353f252ae92a292375276d7a
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Main window toggle on tray icon click.

This is the click-toggle part of #278.
I tried keeping both 'click' and 'double-click' handlers, but it didn't work, so only the 'click' handler is currently enabled. Maybe it could be configurable, but 'click' feels more comfortable (imo).
There is one glitch (which however is not new). Please see the comments.
I've tried some hacks and nothing worked, so we can probably just let it be. It's not that bad.

So what remains to be resolved is the click / double-click.

@MarshallOfSound so what do you think of this?
I see you prefer the double-click, ideas:

Make it configurable
Single click on Linux only (maybe Mac? idk)

Consider this, one action needs to be opening the tray icon menu.  Another needs to be opening the app.
On windows thats like Right Click for context menu and double for show.
On mac double to show isn't a thing, and it is left click for context menu
On linux I'm assuming it's similar to mac?

On Linux it should be

left click to show / hide
right click to show context menu

okay I'll make it the way you said, want to have this finally marged.

Here we go.

Windows
Linux
Mac

Double left click to toggle
Left click to toggle
N/A, use the context menu

I hope I understood it right. Works fine on Linux / xfce, that's what I can test.


Training loss not decreasing if both mixed-precision and XLA/JIT is enabled (with deep model)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Linux Ubuntu 18.04:
TensorFlow installed from binary
TensorFlow 2.4.0
Python 3.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA 11/cuDNN 8:
GPU model and memory Titan RTX/2080Ti:

Describe the current behavior
Training a deep model, e.g., ResNet50, with both mixed-precision and XLA/JIT simultaneously enabled results in the training loss not decreasing.
Mixed-precision alone or XLA/JIT with float32 works both fine.
Describe the expected behavior
Enabling XLA/JIT and mixed-precision training should behave the same as if only mixed-precision is enabled.
Standalone code to reproduce the issue
Minimal Colab notebook to reproduce issue
Notes
Note that this bug does not occur for small models like the ConvNet in the mixed-precision training guide.
Also, the fact that training with mixed-precision alone works fine might point to where there could be an issue here.

@mlech26l,
I do not have access to the Colab notebook you have linked. Could you please provide the required permissions to view the files. Thanks!

@mlech26l,
I do not have access to the Colab notebook you have linked. Could you please provide the required permissions to view the files. Thanks!

Hi, @amahendrakar
Sorry, the following link should work.
Thanks

Hi, @amahendrakar
Sorry, the following link should work.
Thanks

Hi @mlech26l, try using a Learning Rate scheduler

Hi @mlech26l, try using a Learning Rate scheduler

Facing an error stating AttributeError: module 'tensorflow.keras.mixed_precision' has no attribute 'Policy' on running the code with TF v2.3.
Was able to reproduce the issue with TF v2.4.
Whereas with the latest TF-nightly, model.fit runs indefinitely. Please check the linked gist for reference. Thanks!

Facing an error stating AttributeError: module 'tensorflow.keras.mixed_precision' has no attribute 'Policy' on running the code with TF v2.3.
Was able to reproduce the issue with TF v2.4.
Whereas with the latest TF-nightly, model.fit runs indefinitely. Please check the linked gist for reference. Thanks!

Ran into the same problem when training an EfficientDet model after upgrading from TF 2.3.1 to 2.4.1.
After updating to tf-nightly 2.5.0-dev20210127 the loss is decreasing again as expected.
@amahendrakar Code to enable mixed precision is slightly different in TF 2.3:
policy = tf.keras.mixed_precision.experimental.Policy("mixed_float16")
tf.keras.mixed_precision.experimental.set_policy(policy)

Ran into the same problem when training an EfficientDet model after upgrading from TF 2.3.1 to 2.4.1.
After updating to tf-nightly 2.5.0-dev20210127 the loss is decreasing again as expected.
@amahendrakar Code to enable mixed precision is slightly different in TF 2.3:
policy = tf.keras.mixed_precision.experimental.Policy("mixed_float16")
tf.keras.mixed_precision.experimental.set_policy(policy)

Hi @juliangrosshauser and @jvishnuvardhan
I can confirm that the issue seems to be fixed in the latest tf-nightly.

Hi @juliangrosshauser and @jvishnuvardhan
I can confirm that the issue seems to be fixed in the latest tf-nightly.

@mlech26l Thanks for updating us. Closing the issue since the issue was fixed in Nightly version.Thanks!


Fixes #404

Describe what this PR does / why we need it
delete useless active profiles in NacosConfigProperties
Does this pull request fix one issue?

Describe how you did it
delete field , getter, setter , toString, and update NacosPropertySourceLocator
Describe how to verify it
Run testcase
Special notes for reviews

Codecov Report

Merging #410 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
- Coverage   42.26%   41.98%   -0.28%
==========================================
  Files         206      206
  Lines        4955     4947       -8
  Branches      518      518
==========================================
- Hits         2094     2077      -17
- Misses       2712     2722      +10
+ Partials      149      148       -1

Impacted Files
Coverage Δ

...ork/cloud/alibaba/nacos/NacosConfigProperties.java
85.05% <ø> (+0.11%)
:arrow_up:

...ibaba/nacos/client/NacosPropertySourceLocator.java
69.14% <100%> (-0.65%)
:arrow_down:

...d/alibaba/nacos/registry/NacosServiceRegistry.java
42.5% <0%> (-25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412c185...fa0b5a8. Read the comment docs.


i18n files on CDN

Any chance of the i18n locale files being added to the Google CDN?  Eg
https://ajax.googleapis.com/ajax/libs/angularjs/1.4.0-rc.2/i18n/angular-locale_sk-sk.js

Or if they're already there, what's the path?

@poshest you could try this one:
https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.4.0/i18n/angular-locale_sk-sk.js


Update pr.yaml

Linked issue
Provide the issue(s) which this pull request relates to or fixes.
Additional context
Are there things the maintainers should be aware of before merging or closing this pull request?

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update

/expo-update


[bug] XSS use of ace.min.js

Describe the bug
Hi, I'm working on a project that involves examining a bunch of the ComfyUI nodes' JS.
In comfyui_shared.js:417 and note_plus.js you use a loadScript() to load ace.min.js into the script. NotePlus node wasn't visible in utils. I've disabled the remote script import for our purposes but just wanted to point out the state it was found in. This may be an out of date version issue that's already been fixed in your main? Regardless, the external path thing is something that would probably be best localized for security reasons for most uses.

web/extern/shodown.js being deleted seems to not cause any errors at a cursory glance, and I'm not sure why it's there? Solving this riddle is flagged as one of my remaining issues before we can include your node in a large project.

Reproduction
The affected code is note_plus.js
Expected behavior
I would hope to see the ace.min.js call either localized to directory or removed altogether to prevent the possibility of the remote server being used as a vector of attack to other people's machines/browser experience/servers.
Operating System
Linux
Comfy Mode
Other (online services, containers etc..)
Console output
No response
Additional context
No response

Good point yes it makes sense since I do for other externals.
Ace is used solely for the editing part of note plus

https://github.com/melMass/comfy_mtb/pull/167

#167
As mentioned, test before pulling.

Thanks, given the nature of the PR (huge minified code..) I will do it myself.
I think it's also missing all the utility files (from cdn they are linked properly)
I will quickly look into it now, and if there are no blockers it should be solved soon

Fantastic.
On Tue, Apr 2, 2024 at 1:46 AM Mel Massadian @.***>
wrote:

#167 https://github.com/melMass/comfy_mtb/pull/167
As mentioned, test before pulling.
Thanks, given the nature of the PR (huge minified code..) I will do it
myself.
I think it's also missing all the utility files (from cdn they are linked
properly)
I will quickly look into it now, and if there are no blockers it should be
solved soon
—
Reply to this email directly, view it on GitHub
https://github.com/melMass/comfy_mtb/issues/166#issuecomment-2031302131,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC36LN7N34NIKSPZZHMV3KDY3JO5RAVCNFSM6AAAAABFOVEHK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZRGMYDEMJTGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

It was way more involving than planned since comfy preloads all the scripts in the web folder.
The trick was to add an extra static path to the server!
Let me know if it solves your security concerns

Yeah, that should work.  Now it isn't technically XSS exposed, and if we
scan the file it'll tell us what we need to know.
On Tue, Apr 2, 2024 at 9:25 AM Mel Massadian @.***>
wrote:

It was way more involving than planned since comfy preloads all the
scripts in the web folder.
The trick was to add an extra static path to the server!
Let me know if it solves your security concerns
—
Reply to this email directly, view it on GitHub
https://github.com/melMass/comfy_mtb/issues/166#issuecomment-2032359482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC36LN44J7UWTLAWWCFZOHDY3LEX7AVCNFSM6AAAAABFOVEHK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGM2TSNBYGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


delete before replace will cause slight downtime, so remove

• Does any part of it require special attention?
• Does it relate to or fix any issue?
avoid causing downtime on deployments
Standard checks

Unit tests: Any special considerations?
Docs: Do we need to update any docs, internal or public?
Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

Do the comments not apply? It sounds like we needed this, and removing it would cause us to break when we switch exec unit types?

My belief is thats what the triggers on the deployment do. Either way, causing downtime is something we shouldnt do so i think we have to remove this and see if it truly breaks deployments because we cant leave this in

wfm, though I do hope this doesn't cause a regression :)
If it does, hopefully our new tests will catch it!


Lowercase optional text in feedback component

Addendum to https://github.com/cfpb/cfgov-refresh/pull/3216
Changes

Converts (Optional) to (optional) in the feedback form.
Adds a-label_helper class, which should be added to CF to set color of optional text. Currently this doesn't do anything.

@jimmynotjim One update: changed span to small:


fix library detection

fix library detection
manually cherry-picked from PR #788
See also #876

rebased. fix some mistakes. partial squashed.

rebased with some fixes.

rebased, partial squashed, conflict resolved

@wkpark Thanks a lot for the nice PR and your continuing great work around bnb, despite frustrations! The code looks good from a preliminary review. Unfortunately, this part of the code doesn't have an easy way to test and I currently don't have too much time to look very deeply into this.
This code has been kind of flaky in the past. I'm a bit worried about releasing it without thorough testing. How risky do you see this merge and how could we make sure that things work out smoothly?
Did you validate on Linux as well? Another target to check is Collab. I wish we had a better strategy for testing this module: Any ideas? If we were less worried about breaking things, we could follow up with further refactorings, which would be needed.


Try re-numbering field type constants to use jump tables in type case switches

This was originally discussed in #756.
With SDK cl/256180, the compiler started to generate a binary search or jump tables for switch statements. Before the CL switch was compiled to linear scan of alternatives.
With the current implementation of field types, range of the integers being checked are quite large, so the compiler cannot generate a jump table and generates binary search.
We should try re-numbering the type constants to consecutive integers so that the compiler will be able to generate jump tables instead, and then benchmark it.

cl/479015700 tests making message and map bits mutually exclusive, so that we can have a different type number for each.
When testing I found 9 projects that copy the type constants in field_types.dart and use FieldInfo.type field to check types of fields. I updated all of them but there is still breakage, so maybe I'll discover more copies of type constants.


Issue Connecting SatStack to Ledger Live in CMD Prompt - Windows 11

See error below: PLEASE HELP!!
[0;90m[2022/12/11 - 12:07:02]←[0m ←[0;32m INFO←[0m Ledger SatStack (lss) v0.16.1                 ←[0;32march←[0m=windows amd64 ←[0;32mbuild←[0m= ←[0;32mcommit←[0m= ←[0;32mruntime←[0m=go1.17.13
←[0;90m[2022/12/11 - 12:07:02]←[0m ←[0;32m INFO←[0m Config file detected                          ←[0;32mpath←[0m=C:\Users\Jack/AppData/Roaming/Ledger Live/lss.json
←[0;90m[2022/12/11 - 12:07:02]←[0m ←[0;32m INFO←[0m Warming up...
←[0;90m[2022/12/11 - 12:07:02]←[0m ←[0;31mFATAL←[0m Failed to initialize Bus                      ←[0;31merror←[0m=bitcoind unreachable: status code: 200, response: "Umbrel<meta http-equiv=X-UA-Compatible content="IE=edge"><meta name=viewport content="width=device-width,initial-scale=1"><meta name=robots content="noindex, nofollow"><meta name=description content="Welcome back">We're sorry but Umbrel doesn't work properly without JavaScript enabled. Please enable it to continue."

What is error code 200? How would I enable JavaScript on my raspberry Pi running umbrel? Or is this a windows issue since I'm trying to run satstack thru the CMD prompt on a windows machine...

hi @wuhan500 do you manage to log in into your Umbrel normally?

Yes....
On Sun, Dec 11, 2022, 10:32 PM Adrien Lacombe @.***>
wrote:

hi @wuhan500 https://github.com/wuhan500 do you manage to log in into
your Umbrel normally?
—
Reply to this email directly, view it on GitHub
https://github.com/LedgerHQ/satstack/issues/93#issuecomment-1345966109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZTHFXT3AITAEVGFQCMA4XTWM3BGJANCNFSM6AAAAAAS3F36XI
.
 Ledger Live doesn't set the port number unfortunately.


Support internationalized installations of Ohana

I'd like to understand what are the current thoughts on making Ohana more suitable for installation in other countries. Could the validations be made more configurable to support different locales? I'm not currently sure what other kinds of changes would be involved, just starting a conversation at this point.
Some examples:

ZipValidator regex is for US zip codes.
state_province is validated to be 2 characters long.
UI strings related to these fields are not localizable.

Specifically the validators prevented importing of UK addresses when I was trying this.

Thanks, Paul. Ideally, a GitHub issue (whether it's a bug report or a feature request) should contain the following details:

What you did or were trying to do
How you did it
What you expected to happen
What actually happened

In this case, I would ask you which specific validations failed for you, and what else makes Ohana unsuitable for installation in other countries.

Have updated description with more details.

Thanks for the update. For zip code validation, I think using one of these gems would be the best solution.
For state_province validation, I'm not sure if a gem exists, so it might make more sense to just update the documentation and show people how to disable or edit it.
And for the UI strings, did you mean the error messages related to the validation or something else? The error messages are localizable in config/locales/en.yml. If you find any strings that should be localized, feel free to submit a PR.

Thanks. Sounds like its better to submit very specific issues, which I can do for things related to this. But about this:

it might make more sense to just update the documentation and show people how to disable or edit it.

Is there a long term interest in making this project easily deployable in other locales? If so, I wonder if a longer term solution would be needed to make this configurable, rather than a documented edit. This is what I'm trying to get a sense of from this issue at a general level.

@pmackay You may be interested in the discussion I started around making ohana-web-search into a Rails Engine: https://github.com/codeforamerica/ohana-web-search/issues/798
I think most of what I said over there applies to ohana-api as well.

@pmackay Yes, there is, but it depends on your definition of easy, and if there are other issues besides address validations.
What I had in mind for the postal_code and state_province validations was to tie them to a setting in config/settings.yml where you would define the locale, and the validations would automatically perform the appropriate work for the locale. For the state_province validation, that would mean adding a condition that the validation would only be performed if the locale was US. That would solve the issue with importing UK addresses.
However, if you wanted to validate that the state_province met certain conditions, you would have to add your own custom Rails validation. I'm all for making things as easy to customize as possible, but certain things aren't easily customizable from settings.yml or application.yml, and for certain levels of customization, you're gonna have to get into the code. Do you agree?

@monfresh yes ok that's exactly the kind of info I was looking for. Totally agree with config via settings.yml. And yes validating states for different locales would need a new custom validator.
Happy to close this as its helped my understanding and best to raise focussed issues for each change.
@md5 thanks for mention, very interesting thread but perhaps slightly different. Here I was trying to clarify what scope of changes could be pushed back upstream as it were, related to i18n.

Sounds good. If you prefer to open separate focused issues, that's fine with me. Also, let me know if you were planning on submitting pull requests for those issues. If so, I would go with the going_postal gem for now because it also provides formatting options based on the country code.

I'm closing now that we have separate issues. I also already fixed the state_province issue in #321.


Updates plugin to use Pane/PaneAxis APIs.

Tentative proposed fix for https://github.com/denieler/save-workspace-atom-plugin/issues/10.
It looks like the APIs have changed for nested panes (or something; I'm not familiar enough with Atom).

@davelnewton thanks for really awesome PR! I will test it and definitely will merge in `master


Feautre/rp/rerun examples

Reran and completed the example notebooks concept_figure and render_labels. I was able to run aggregate_predictions until the last cell referenced a function that no longer exists (get_fractional_overlap). For now the PR only includes the finished notebooks but not the last one until I figure out what in geospatial.py or aggregate_predictions.ipynb needs to be changed.

I actually updated render_labels and aggregate before our meeting last week. It looks like this branch probably doesn't have those changes in it. Sorry, I was sloppy and didn't update the issue. I'll check tomorrow and see if the updates to the concept_figure can still be helpful.

Closing because this was completed in parallel


Update OS versions

Debian 10 reached EOL
Ubuntu 18.04 reaches EOL in April
Fedora 34 reached EOL
Fedora 35 reached EOL
Update FreeBSD 12.2 to 12.3
Update FreeBSD 13.0 to 13.1

bors r+


Refresh heatmap when data is returned from ElasticSearch

Currently the heatmap is only updated when the user interacts with the data, but it should be automatically updated when the data is returned from the query.
Definition of done

[ ] Determine the point when the map can be refreshed.
[ ] Implement a hook to refresh the map when the data is available.
[ ] Ensure that the map is refreshed every time data is filtered is interacting with charts.

"Refresh" function can be actually placed in filter.js file but the problem is that once leaflet map has been initialized it is not possible to reinitialize one. There is built in "update" function (within leaflet) but even if calling it, data/heat won't update. The solution I came up with that seemed to work is onFiler event, removing DOM element from the page and reinitialize leaflet map with fresh data. Not the best approach but at least this could work


CognitoAuth-Sample Conversion to latest Version

Hi there, I've used the code to get this to run however, it cant be used with the latest verson of xcode and swift.
Does anyone know how to upgrade the code, as it not converting to the latest version with out errors.
Apologies as Im fairly new to this.
Just need to get the sample working.
Thanks

@gunteefe Just confirming you are using 9.3.1 or some other version of Xcode?

Hi there, yes I've checked it is version 9.3.1

@gunteefe I was able to run the CognitoAuth-Sample successfully on Xcode version 9.3.1 as is without any changes. Are you getting build errors or runtime errors? Can you please share the errors that you are running into with Xcode version 9.3.1? Thanks.


feat: Add fr-FR translation and begin translation with dashboard and clients

Closes #2

Nice! You need to add clients.json too

Why clients.json ? I don't have a file with that name

Can you push .prettierrc.json and the update package.json and package-lock.json?

Good point, I hadn't noticed that they hadn't been added to the commit

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can't get flow type coverage for a function

I have the following function:
type KeyboardInfo = {
  key?: string,
  code?: string,
  meta?: boolean,
  alt?: boolean,
  ctrl?: boolean,
  shift?: boolean,
  prevent?: boolean,
  log?: boolean
}

function on(event: KeyboardEventTypes, {key, meta, alt, code, shift, ctrl, prevent = true, log = false}: KeyboardInfo, callback: (e: KeyboardEvent) => void) {
  window.addEventListener(event, (e: KeyboardEvent) => {
    if (log) {
      console.log(e);
    }

    if (key && e.key !== key) {
      return;
    }
    if (meta && e.metaKey !== meta) {
      return;
    }
    if (code && e.code !== code) {
      return;
    }
    if (ctrl && e.ctrlKey !== ctrl) {
      return;
    }
    if (alt && e.altKey !== alt) {
      return;
    }
    if (shift && e.shiftKey !== shift) {
      return;
    }
    if (prevent) {
      e.preventDefault();
    }
    callback(e);
  });
}

I try to get this covered by flow, but I'm not sure how. Atom says it is not covered:

Is this because I call window? Not sure what is going on here.

Maybe Flow wants you to specify return type of the callback?
- window.addEventListener(event, (e: KeyboardEvent) => {
+ window.addEventListener(event, (e: KeyboardEvent): void => {

Another possibility is that it just points out that window.addEventListener is uncovered by built in type definitions (https://github.com/facebook/flow/blob/master/lib/dom.js).
Or maybe both. Anyway those are just guesses, but I thought it might be helpful.

Another possibility is that it just points out that window.addEventListener is uncovered by built in type definitions (https://github.com/facebook/flow/blob/master/lib/dom.js).

Seems like this is the case. Actually the whole window object seems to be missing ....

@kasperpeulen it's often useful to use the flow cli to get better information.

The --color flag, which seems to be undocumented will mark exactly the issues.

@aackerman Thanks for the tip 👍
@avikchaudhuri Is there any reason that the window object is not typed yet?
I saw typescript has some type definition here:
https://github.com/Microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#L12835

@kasperpeulen No good reason. Would you like to send a PR?

Is there a way to convert the TypeScript type to Flow type? That generated window type is huge.

@kmiyashiro Not yet no. But a lot of the syntax is similar so you can usually start by copying the TS file and manually editing it till it works. Remember to add optionals where needed.

@avikchaudhuri Is there a place we should put this? It seems like it would be easy to make it a global libdef (is it very important that Flow knows it's in a browser or hybrid environment?). Then we'd provide it via flow-typed. However, flow-typed seems like it's for specific libs and having a global libdef might be out of place. If we produce a PR internally, can we still provide a .flow.js libdef for it? I'm not familiar with how the builtin types get expressed.

Curious if there's further interest in adding a window type. Seems like we are unlikely to get an exact type for it.

I've added one locally for a project I work on. I would love to see something like it in flow core.

@asolove I haven't looked at the Typescript declaration but I have no doubt it's non-trivial in size. I'd be up for helping with incremental PRs.

The only problem with incrementalism is that a partial window declaration will break existing code that works because of the any type.

I don't understand, and would like to :)
Any code that uses window right now cannot type check unless someone shims a libdef in, correct? Or is this more for when people hang things off of window as a means of adding globals?

Right now flow declares window this way:
declare var window: any;

So all uses of window typecheck correctly, although also aren't considered covered for the coverage report.
Replacing that with a definition of window that doesn't include every possible browser api would cause currently passing code to fail to type check. So I doubt that is a workable solution.
Would be nice to have a way to opt in to a more carefully typed window object though.

@asolove how does typescript get around this issue with their pre-defined window type? I believe they use Edge's API as the basis for their type, which most likely overlaps with the vast majority of modern browsers.

Good point, wonder if we can piggyback on what they do.

So it looks like TS has a built in way to declare new stuff that hangs off the window object. As a result, some window typings are distributed like libraries for each chunk of functionality like web audio. Which means there can be different
versions, you can write them yourself to use in your project, etc.
This probably won't work in Flow, since I don't think you can extend interfaces from another file. Maybe window should b a special case?

Perhaps it would be better to accommodate Javascript's mutable nature and allow any type/interface to be "patched". This way when libs want to hang things off of window, we can go into the libdef and provide an additive annotation to it.


Foreground Vision Bot - when pressing W for a long time, sometimes it get stuck going forward forever

Fixed in #17


ModalPane does not interact properly with screenreaders

When using the Windows screen reader, the contents of a ModalPane are still recognized even though they should not be visible anymore after calling hide().

I suppose it’s another JavaFX bug and the screen reader doesn’t take the view order property into account. I’ve checked the list of AccessibleActions and failed to see something suitable.

Can't you just make it invisible/not managed/not focus traversable when the pane is hidden?

Hard to say as it could break the content animations. I would prefer to avoid this level of complexity.

Closing in favor of https://github.com/mkpaz/atlantafx/issues/63 as it's more generic issue.


fix: location_ids and buildingCatalogue are inconsistent

Continuing the saga from #784 and #779, location_ids and buildingCatalogue are inconsistent.
Noted in #855:

Not all locations are recognized for custom events on the map even though they are for classes (BS3, for example) and some don't even read on the calendar

In the particular case above,
buildingCatalogue:
    83057: {
        name: 'Biological Sciences III (BS3)',
        lat: 33.645363,
        lng: -117.846222,
        imageURLs: ['463/biological-sciences-iii.jpg'],
    },

    114877: {
        name: 'Biological Sciences III (BS3)',
        lat: 33.645363,
        lng: -117.846222,
        imageURLs: ['463/biological-sciences-iii.jpg'],
    },

location_ids:
    BS3: 114877,

Custom Events seemingly use the 83057 which don't exist in location_ids, whereas course events use 114877 which do.

RFC: @KevinWu098 How should I handle inconsistencies, for example ids present in location_ids are not present in buildings_catalogue, and vice versa, and duplicates in buildings_catalogue where neither is present in location_ids?

RFC: @KevinWu098 How should I handle inconsistencies, for example ids present in location_ids are not present in buildings_catalogue, and vice versa, and duplicates in buildings_catalogue where neither is present in location_ids?

Haven't delved too deep into the code, but here's some thoughts:

For consistency, this PR should probably ensure 1-1 parity for buildings and IDs
Every building is listed across all lists, and every building is only associated with one ID (and vice versa)
Ideally (IMO), we should aim to consolidate everything into one file, one source of truth instead of having multiple files
If parity is unachievable -- some key or value doesn't exist, you could try hunting it down 😅


Add cron job to periodically purge

Short description of the changes:
Add a monthly cron job to purge expired data
Long description of the changes:

Adds script which runs purge_expired_data command
Adds a cron job to run this script at 00:00 on the 1st of each month

writes output to /var/log/cron.log

Rename "deploy-config" to simply "deploy"
Move django app docker files into this folder
Add default auto field type to ensure longevity and suppress warnings
Add counter to track how many runs are deleted

Check list for the pull request

[x] I have read the [CONTRIBUTING]
[x] I have read the [CODE_OF_CONDUCT]
[x] I have added tests for my changes
[x] I have updated the documentation accordingly

Check list for the reviewer

[ ] I have read the [CONTRIBUTING]
[ ] I have verified the proposed changes
[ ] best software practices

[ ] all internal functions have an underbar, as is python standard
[ ] clearly named variables (better to be verbose in variable names)
[ ] code comments explaining the intent of code blocks

[ ] All the tests are passing
[ ] The documentation is up to date
[ ] code comments added when explaining intent

Manual test for the reviewer

References

Maybe we can configure the code coverage to exclude migration in the future

Maybe we can configure the code coverage to exclude migrations in the future

oh that's a good idea, I'll look at how to exclude folders!


Dependency issue

I've been getting an error about dependencies since alpha.23.
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@sundaeswap/asset npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@sundaeswap/sdk-core npm ERR<EMAIL_ADDRESS>from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@sundaeswap/cpp npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@sundaeswap/sdk-core npm ERR<EMAIL_ADDRESS>from the root project
I can still continue by doing a --force, but that's not ideal.

Hey @NickJorens, can you update to 0.2.0-alpha.26 and let me know if the issue is resolved?

Hi @cjkoepke,
This has fixed the issue for me. Thank you


Vector tiles does not match with geojson geometry.

I recently switched my application from geojson type to vector tile source. Features drawn from vector source are geometrically different than that of geojson.
I am using following command to create these tiles
tippecanoe --no-feature-limit --no-tile-size-limit  --minimum-zoom=1 --maximum-zoom=g --output-to-directory "tiles" states.json

Features with blue boundary are drawn from geojson source.
How do I configure the command so that I can get exact tiles to be drawn?

If you want a more precise match to the source data, you can specify a higher maximum zoom level.


spm version 2.7.0 error

@nghia10216
Can you provide more information like your Xcode version?
I just did a test and it worked fine. (Xcode 14.2)

I'm using
Xcode Version 13.4.1

@nghia10216
I am not sure what caused this issue. Maybe it is because I began to release Mantis using Xcode 14 after 2.4.0
Would it be possible for you to update your Xcode to the latest version to have a test?

I had the same issue on Xcode 13.4
Unfortunately, I can't update to Xcode 14. my office work environment not allowed using the internet.
so can't update MacOS for using xcode14.
is there any solution for this issue?

I closed this issue for now.
You can reopen it anytime if it happens to the latest Xcode.


[Feature][UI] Provide users with a button to enable auto-refresh

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description

If DS could provide users with a button on task instance page or task instance logs page to enable auto-refresh, it would be pretty cool.

Use case

If users want to see the update of task instance status or task logs, they could switch on the auto-refresh button.
If users do not need to see the updates in time and have concerns about the performance cost of auto-refresh, they could switch off the button.

Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What about adding good first label to this issue?

What about adding good first issue label to this?

Done.

Can I take this issue? @EricGao888

Can I take this issue? @EricGao888

Sure~

Thanks!! @EricGao888. Also, regarding the auto-refresh log feature, do you think it would make sense to add some refreshing time interval options, eg., Refresh after 1 second, 2 sconds, 1 minute?
A similar product feature screenshot is attached here--

Thanks!! @EricGao888. Also, regarding the auto-refresh log feature, do you think it would make sense to add some refreshing time interval options, eg., Refresh after 1 second, 2 seconds, 1 minute? A similar product feature screenshot is attached here--

Good point! If the task outputs logs in a low frequency, we could set the auto-refresh interval longer so that it will not waste resource. WDYT? @songjianet @Amy0104

This function can be added, allowing users to freely choose an automatic refresh interval is a good method, but considering the 400a version, we may use websocket and other even communication schemes. @SbloodyS @EricGao888 @lynn-illumio

I'm linking another related issue here: https://github.com/apache/dolphinscheduler/issues/11079