chore(deps): support for node 18 and higher versions

upgrade package dependencies
BREAKING CHANGE:
remove support for node 16
GH-83
Description

support for node 18 and higher versions
upgrade package dependencies

Fixes #83
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] Performed a self-review of my own code
[ ] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


if  a service have more than one port, only one of the port can be used

What happened:
I created a service on my server with 2 ports ,but when i curl the service with the port, only one of the 2 ports can be accessed,another one can not be accessed
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

EdgeMesh version:

v.1.8.0

Kubernetes version (use kubectl version):

v1.20.10

KubeEdge version(e.g. cloudcore --version and edgecore --version):

v1.8.1

Cloud nodes Environment:

Hardware configuration (e.g. lscpu):
OS (e.g. cat /etc/os-release):
Kernel (e.g. uname -a):
Go version (e.g. go version):
Others:

Edge nodes Environment:

edgecore version (e.g. edgecore --version):
Hardware configuration (e.g. lscpu):
OS (e.g. cat /etc/os-release):
Kernel (e.g. uname -a):
Go version (e.g. go version):
Others:

release-1.9 has fix this issue: https://github.com/kubeedge/edgemesh/blob/release-1.9/agent/pkg/chassis/registry/registry.go#L98-L115
You can patch it by yourself or upgrade edgemesh version.

OK， thank you

release-1.9 has fix this issue: https://github.com/kubeedge/edgemesh/blob/release-1.9/agent/pkg/chassis/registry/registry.go#L98-L115
You can patch it by yourself or upgrade edgemesh version.

I hvae patch it to edgemesh-agent v1.8.0 and i have build the image by the Dockerfile in edgemesh, but how can i build the image based arm?

make IMAGE_REPO= IMAGE_TAG=latest push-all

make IMAGE_REPO= IMAGE_TAG=latest push-all

My branch is v1.8.0 .I  have checked the makefile in v1.8.0 and can not find the "push all".

And i want to build the arm64 image on my x86 server

My branch is v1.8.0 .I have checked the makefile in v1.8.0 and can not find the "push all".

You can checkout branch to main, then refer to the Makefile and Dockerfile and hack/*.sh files of main branch. These files also can work on branch v1.8.0.

docker buildx subcommand can meet your needs.

thanks


IE8 Support?

Hi,
I am looking for a solution like this, but the client requires Internet Explorer 8 support.  While the Leaflet map loads in your example page, your layers do not load.
Any possibility, or advise for getting this to work with IE8?
Thanks,
Jim

Try the ie8 branch, from memory the polyfills should make things work (although I have not tested it).

Thanks @cbaines !
Will report back here with our findings.
Jim

Hi @cbaines
We didn't end up going with this for the project, but your IE8 branch did work.
Thanks,
Jim


docs: Correct mockClear api docs

Documentation  page:
https://jestjs.io/docs/mock-function-api#mockfnmockclear
<EMAIL_ADDRESS>Summary
mock.mockClear() and clearMocks: true both resets mock.calls, mock.instances and mock.results of a mock function not only the first two ones that doc says.
Code
// jest.config.js

module.exports = {
   clearMocks: false,
   resetMocks: false
}

const mock = jest.fn(x => x * 2);

beforeEach(() => {
   mock.mockClear()
})

it('test1', () => {
   mock(2);
   mock(3);
   console.log(mock.mock.calls, mock.mock.instances, mock.mock.results);
   // [ [ 2 ], [ 3 ] ]
   // [ undefined, undefined ]
   // [ { type: 'return', value: 4 }, { type: 'return', value: 6 } ]
});

it('test2', () => {
   console.log(mock.mock.calls, mock.mock.instances, mock.mock.results);
   // [] [] []
});

Removing beforeEach() and toggling clearMocks config option won't affect the result.

thanks! Can you update https://github.com/facebook/jest/blob/master/docs/MockFunctionAPI.md as well?

I updated that too.

Codecov Report

Merging #11325 (e214b2d) into master (6fcdb1e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11325      +/-   ##
==========================================
+ Coverage   64.17%   64.19%   +0.01%
==========================================
  Files         308      308
  Lines       13528    13528
  Branches     3297     3297
==========================================
+ Hits         8682     8684       +2
+ Misses       4132     4131       -1
+ Partials      714      713       -1

Impacted Files
Coverage Δ

packages/expect/src/utils.ts
96.12% <0.00%> (+1.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcdb1e...e214b2d. Read the comment docs.


Binary not being built?

When I try building my project (gb build) inside the root of one of my projects, nothing happens; the bin/ directory along with the built binary is not being created. It's odd because it's only happening inside this one project -everything builds fine in my other projects in other workspaces.
I tried starting from scratch by deleting vendor/, pkg/, reinstalling all dependencies and building it again, but it still doesn't work.
I'm using go1.6.2 darwin/amd64 with the latest gb and everything looks correct regarding gb env.
No errors or anything weird is outputted after gb build, it just fails silently.
Any idea what could cause the binary to not be built?

Can you please try again with
env DEBUG=. gb build
And paste the complete output. It should be pretty straight forward to
figure it out from there.
On Thu, 2 Jun 2016, 09:07 elimist<EMAIL_ADDRESS>wrote:

When I try building my project (gb build) inside the root of one of my
projects, nothing happens; the bin/ directory along with the built binary
is not being created. It's odd because it's only happening inside this one
project -everything builds fine in my other projects in other workspaces.
I tried starting from scratch by deleting vendor/, pkg/, reinstalling all
dependencies and building it again, but it still doesn't work.
I'm using go1.6.2 darwin/amd64 with the latest gb and everything looks
correct regarding gb env.
Any idea what could cause the binary to not be built?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/600, or mute the thread
https://github.com/notifications/unsubscribe/AAAcA0SiYXpBHpRChwQpllfgWNTWuXg1ks5qHhCWgaJpZM4IsD__
.

ok, here is the output from env DEBUG=. gb build
❯ env DEBUG=. gb build
2016/06/01 16:51:57 main.go:115: args: []
2016/06/01 16:51:57 cmd.go:86: project root "/Users/elimist/projects/auth"
2016/06/01 16:51:57 import.go:20: /Users/elimist/projects/auth ..
2016/06/01 16:51:57 context.go:435: matchPackages: ...
2016/06/01 16:51:57 main.go:165: args: [github.com/elimist/auth github.com/elimist/auth/identity]
2016/06/01 16:51:58 build.go:49: build duration: 97.43µs map[]
2016/06/01 16:51:58 context.go:319: removing work directory: /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb007489542

Nothing is stale so nothing is rebuilt
On Thu, 2 Jun 2016, 09:59 elimist<EMAIL_ADDRESS>wrote:

ok, here is the output from env DEBUG=. gb build
❯ env DEBUG=. gb build
2016/06/01 16:51:57 main.go:115: args: []
2016/06/01 16:51:57 cmd.go:86: project root "/Users/elimist/projects/auth"
2016/06/01 16:51:57 import.go:20: /Users/elimist/projects/auth ..
2016/06/01 16:51:57 context.go:435: matchPackages: ...
2016/06/01 16:51:57 main.go:165: args: [github.com/elimist/auth
github.com/elimist/auth/identity]
2016/06/01 16:51:58 build.go:49: build duration: 97.43µs map[]
2016/06/01 16:51:58 context.go:319: removing work directory:
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb007489542
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/600#issuecomment-223160027,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcAzo5kB0ggK3-TfGKmsGX1aICdWWNks5qHhzJgaJpZM4IsD__
.

Hmm, interesting. I tried rebuilding again after modifying some source, still no bin/ is being created.
env DEBUG=. gb build
2016/06/01 17:04:54 main.go:115: args: []
2016/06/01 17:04:54 cmd.go:86: project root "/Users/elimist/projects/auth"
2016/06/01 17:04:54 import.go:20: /Users/elimist/projects/auth ..
2016/06/01 17:04:54 context.go:435: matchPackages: ...
2016/06/01 17:04:54 main.go:165: args: [github.com/elimist/auth github.com/elimist/auth/identity]
2016/06/01 17:04:54 install.go:130: /Users/elimist/projects/auth/pkg/darwin-amd64/github.com/elimist/auth/identity.a is older than /Users/elimist/projects/auth/src/github.com/elimist/auth/identity/repository.go
2016/06/01 17:04:54 context.go:340: cd /Users/elimist/projects/auth/src/github.com/elimist/auth/identity; [/usr/local/Cellar/go/1.6.2/libexec/pkg/tool/darwin_amd64/compile -p github.com/elimist/auth/identity -pack -o /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943/github.com/elimist/auth/identity.a -I /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943 -I /Users/elimist/projects/auth/pkg/darwin-amd64 -complete cache.go config.go model.go repository.go service.go]
github.com/elimist/auth/identity
2016/06/01 17:04:54 context.go:340: cd /Users/elimist/projects/auth/src/github.com/elimist/auth; [/usr/local/Cellar/go/1.6.2/libexec/pkg/tool/darwin_amd64/compile -p github.com/elimist/auth -pack -o /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943/github.com/elimist/auth.a -I /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943 -I /Users/elimist/projects/auth/pkg/darwin-amd64 -complete handlers.go main.go types.go utilities.go]
github.com/elimist/auth
2016/06/01 17:04:54 build.go:49: build duration: 506.423567ms map[gc:504.807623ms]
2016/06/01 17:04:54 context.go:319: removing work directory: /var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943

Which is the main package?
On Thu, 2 Jun 2016, 10:12 elimist<EMAIL_ADDRESS>wrote:

Hmm, interesting. I tried rebuilding again after modifying some source,
still no bin/ is being created.
env DEBUG=. gb build
2016/06/01 17:04:54 main.go:115: args: []
2016/06/01 17:04:54 cmd.go:86: project root "/Users/elimist/projects/auth"
2016/06/01 17:04:54 import.go:20: /Users/elimist/projects/auth ..
2016/06/01 17:04:54 context.go:435: matchPackages: ...
2016/06/01 17:04:54 main.go:165: args: [github.com/elimist/auth
github.com/elimist/auth/identity]
2016/06/01 17:04:54 install.go:130:
/Users/elimist/projects/auth/pkg/darwin-amd64/
github.com/elimist/auth/identity.a is older than
/Users/elimist/projects/auth/src/
github.com/elimist/auth/identity/repository.go
2016/06/01 17:04:54 context.go:340: cd /Users/elimist/projects/auth/src/
github.com/elimist/auth/identity;
[/usr/local/Cellar/go/1.6.2/libexec/pkg/tool/darwin_amd64/compile -p
github.com/elimist/auth/identity -pack -o
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943/
github.com/elimist/auth/identity.a -I
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943 -I
/Users/elimist/projects/auth/pkg/darwin-amd64 -complete cache.go config.go
model.go repository.go service.go]
github.com/elimist/auth/identity
2016/06/01 17:04:54 context.go:340: cd /Users/elimist/projects/auth/src/
github.com/elimist/auth;
[/usr/local/Cellar/go/1.6.2/libexec/pkg/tool/darwin_amd64/compile -p
github.com/elimist/auth -pack -o
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943/
github.com/elimist/auth.a -I
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943 -I
/Users/elimist/projects/auth/pkg/darwin-amd64 -complete handlers.go main.go
types.go utilities.go]
github.com/elimist/auth
2016/06/01 17:04:54 build.go:49: build duration: 506.423567ms
map[gc:504.807623ms]
2016/06/01 17:04:54 context.go:319: removing work directory:
/var/folders/cp/35w3f3mx5hv7gq9tc8krbqkm0000gn/T/gb741846943
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/600#issuecomment-223161987,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA5n6Jceh6dFOOyLRYcXKy5lOAPWUks5qHh_dgaJpZM4IsD__
.

the main package is auth

Gb doesn't think that is main package, so it isn't linking it, you should
find an auth.a file in pkg/ directory.
Is the source of this project available?
On Thu, 2 Jun 2016, 10:15 elimist<EMAIL_ADDRESS>wrote:

the main package is auth
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/600#issuecomment-223162498,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA6R0mmJtmIwGjiSbi58esswjOwdoks5qHiCigaJpZM4IsD__
.

Ah, unfortunately the code is not open for now, as per prudish company policy.
But yeah, what you say makes sense -this was completely my fault. I had forgotten that executables always need a package main. Changing the auth's package name to main resulted in a proper build. Perhaps we could add a warning for future cases. Thanks for all your help and the quick replies -big fan of your blog!

You're welcome. I don't know how to make gb detect that a main package is a
main package when the package declaration is not main. Perhaps this is
something go vet could do.
On Thu, Jun 2, 2016 at 10:37 AM, elimist<EMAIL_ADDRESS>wrote:

Ah, unfortunately the code is not open for now, as per prudish company
policy.
But yeah, what you say makes sense -this was completely my fault. I had
forgotten that executables always need a package main. Changing the
auth's package name to main resulted in a proper build. Perhaps we could
add a warning for future cases. Thanks for all your help and the quick
replies -big fan of your blog!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/constabulary/gb/issues/600#issuecomment-223165620,
or mute the thread
https://github.com/notifications/unsubscribe/AAAcA7aIboRkiHwSbjbiGONvTfrkgUQrks5qHiXAgaJpZM4IsD__
.


support for spark 1.5

can you add support for 1.5, or is 1.6 backwards compatible to spark 1.5? a package doesn't seem to be available for 1.5.

Currently 1.5 works for Spark 1.5. Now the new features are only committed to branch-1.6, branch-2.0 and master. Of course, SHC does welcome PRs to 1.5 branch and before.
There is no package available in Hortonworks repo, and you need to built it with mvn package -DskipTests (please refer the readme doc).

Any chance you could publish a version build for spark 1.5 to Central?

Nope, sorry i don't have that code base accessible to me anymore.
On Wed, Jan 25, 2017 at 8:52 AM Philipp M<EMAIL_ADDRESS>wrote:

Any chance you could publish a version build for spark 1.5 to Central?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/hortonworks-spark/shc/issues/54#issuecomment-275127797,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf4JmgISNMfjIT-Huwl-PLm8zdR39aJks5rV2GhgaJpZM4KmQCZ
.


Error when using output location that is absolute path that is not underneath working directory

As part of our build process, we copy the resulting artifacts for our build to a separate directory, one that is not a subdirectory of our workspace, and zip them up for publishing. We would like to use this directory as our output location to be uploaded, but when we try to do so, the plugin throws an error because there's an illegal character (":") in the resulting path.
For example, let's say our workspace directory is "C:\Data\build\jenkins\workspace\OurApp", and we   output our artifacts to publish to "C:\Data\build\jenkins\published\OurApp". If I configure out Jenkins project to upload and output location of the latter path, it blows up when trying to publish because there's an "Illegal char <:> ... " in the path "C:\Data\build\jenkins\workspace\OurApp\C:\Data\build\jenkins\published\OurApp".
I suspect this is an easy fix, and one I think I could put together a PR for -- is there any reason against adding this support?
Thanks!

It seems like : characters should be supported, are you able to provide a stack trace so I can see exactly where the issue is? I've made a note of your issue internally so we can investigate it further.
In the interim, is it possible to use a directory inside your workspace for the output artifact? I believe it's quite common to use a directory called something like build or target inside your workspace for this purpose.

I do not have a stack trace currently (I will re-configure the job and repro for a stack trace as soon as I can), but to me it certainly looks that the error I see comes from line 209 of CompressionTools.java (here). If outputPath is an absolute path already, the code tries to concatenate outputPath with the absolute workspace path, yielding a bogus path.


This is not

This is not a PSModule or PSSnapin.
What is process to add Connect-EXOPSSession on ISE VSCode and another ?

Détails du document
⚠ Ne pas modifier cette section. C’est obligatoire pour docs.microsoft.com ➟ Liaison des problèmes GitHub.

ID: 65e527db-a4c2-782e-5a5f-ad8b3159a977
Version Independent ID: f2de1272-5e37-c59f-fcb9-34fa66b0d268
Content: Connexion à Exchange Online PowerShell avec l’authentification multifacteur
Content Source: exchange/docs-conceptual/exchange-online/connect-to-exchange-online-powershell/mfa-connect-to-exchange-online-powershell.md
Service: exchange-online
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @CallMeByMyName, thank you for your comment.
Here you can find the information your are looking for:
https://blogs.technet.microsoft.com/richardroddy/2018/04/04/using-powershell-ise-to-connect-to-exchange-online-when-mfa-is-enabled/

@dariomws306  Thank you very much for the contribution and sharing this explanation. @CallMeByMyName Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close

Install-Module CreateExoPsSession
It doesn't do the implicit session reconnection thing yet, but it's an actual module, not the fake module from the MS site.


Extend skinning for >4 bones per vertex

Improve bone skinning for more than four bones per vertex

can you sign the CLA btw -- I know it's moot, but this way we can commit the changes.

Would you be able to rebase the change so it builds on main again? thanks!

Also please add a line in NEW_RELEASE_NOTES.md. I think we're getting very close :-)

@poweifeng @bejado I think we're super close to being able to land this PR, I'd like a one last round of going over it, since it's such a large change.  Thank you!

@poweifeng @bejado I think we're super close to being able to land this PR, I'd like a one last round of going over it, since it's such a large change. Thank you!

Will take another look

@fvbj you also will need to rebase (hopefully) one last time and resolve the release notes and main.vs

@fvbj the android/ios (GLES shader issue) and windows builds are failing (C++ issue), FYI.

@pixelflinger Everything looks good, what can I do to finalize the PR? Thank you.

@poweifeng @romainguy @bejado @fvbj I'm planning to merge this on Monday after we branch the release. Let me know if there are any concerns.

@fvbj it looks like several targets are not building.

The failures seem due to a reliance on an implicit conversion:
ERROR: lit_opaque.mat:857: '!=' :  wrong operand types: no operation '!=' exists that takes a left-hand operand of type ' temp highp int' and a right operand of type ' const uint' (or there is no acceptable conversion)

@fvbj can you rebase one more time, hopefully there won't be conflicts tomorrow morning when I try to merge it. Thanks!


[webview_flutter] Gestures stop working in iOS13

I'm having trouble responding to gestures when I load some web pages using webview_flutter
After the webpage is loaded successfully, and then click once, then the gesture operation can no longer be performed, whether it is click or drag.
Even affects flutter_widget click events.
These events only happen in the iOS13 series.
When I use native flutter, the above problem is not reproduced.

@jsleishen
Can you provide flutter doctor -v and a complete minimal reproducible code sample without any 3rd party plugins, that shows the behavior you are reporting ?


Instagram Login Page Clone using HTML, CSS

I am TRIDIB BAG, GSSOC'22 contributor, wanted to add Instagram Login Page Clone using HTML, CSS as there is nothing on this topic . So I want to contribute on it.
Please @Rayman-Sodhi , can You assign it to me ?

@Mrjoy832 assigned to you

@gurjeetsinghvirdee will be done by tonight for sure

@Mrjoy832 make sure to deploy it

@Mrjoy832 make sure to deploy it

PR created ..please check


[docs] RHV UPI refers to RHCOS image

https://docs.okd.io/latest/installing/installing_rhv/installing-rhv-creating-custom-vm.html#installing-rhv-using-ansible-playbook_installing-rhv-creating-custom-vm mentions RHCOS image instead of FCOS image. Instead https://getfedora.org/en/coreos/download?tab=metal_virtualized&stream=stable should be used

https://docs.okd.io/latest/installing/installing_rhv/installing-rhv-customizations.html no longer mentions it


Create public API for validation

This is the API that a consumer would use, from start-to-end in order to construct and use a validator.
It must support injecting custom components, but it should also be terse in scenarios in which the user just wants to use built-in functionality.

The vague process is:

Instantiate a manifest builder (user's choice of how) - this would be generic for the type under validation
Build the manifest
Optionally combine manifests
Instantiate a validator factory (alternatively, there will be a default singleton available)
Create the validator using the manifest
Perform validation

Some rough pseudocode might look like this, for a minimal scenario:
var builder = new CodedManifestBuilder<MyObjectType>();
var manifest = builder.Create(x => {
  // All of the guff to create the manifest here
});
var validator = ValidatorFactory.Default.CreateValidator(manifest);
var result = validator.Validate(myObject);


[WIP] Rewrite the E2E test framework and tests

Motivation:
According the feedback from the community, the e2e tests are hard for
them to understand and get them started, so this pull request aims to
rewrite the e2e tests with some improvements:

debuggable locally, now you can run every individual case directly
inside the IDE, just like running a plain unit test.

same functionalities of multiple counterparts share the same codes,
cases like different storages and cluster coordinators share the same
codes, easy to add more similar cases.

the "end" now extends to the Doccker images, meaning that some bugs
like #4483 and #4471 can be more easily and early to be discovered.

codes style and license headers are checked

Modifications:

adopt jupeter (a.k.a junit 5), testcontainers as the new test
framework, all containers are orchestrated by docker-compose.yml,
well-known technology that developers should be familiar with.

rewrite all test cases and verify them.

reorganize the workflows in GitHub Actions.

Result:

new e2e test should be easy to add.

closes https://github.com/apache/skywalking/issues/4472

It's hard to review the diff, so just checkout the branch locally and review the final codes

You need to keep name same, especially all CI required tasks. Otherwise, this can't be merged.

Codecov Report

Merging #4510 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4510   +/-   ##
=======================================
  Coverage   25.49%   25.49%
=======================================
  Files        1244     1244
  Lines       28895    28895
  Branches     3953     3953
=======================================
  Hits         7367     7367
  Misses      20849    20849
  Partials      679      679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5efc97...b4d8d24. Read the comment docs.

What are these? Some mistakes?

#4470 merged, so you are facing conflicts, please add this case in here too.

@wu-sheng this pull request is ready IMO, and I add it back to 7.0.0, please review and let me know if it's possible to included in 7.0.0

Once this PR merged, please send the notification mails to

Release vote as a verified result
Juan Pan about the update
Separated notification mail about the e2e framework changed totally.


Update krabsetw to latest version

We need the new "trace::set_trace_information" method to setup sampling profiling.
This is a snapshot of https://github.com/microsoft/krabsetw.
Commit: 0409b3ecfad72c4d62cbd393287e109d9e869621

Cool, thanks @ronaldfw !


Running Own Dataset with Qpath Output (CODEX) using STELLAR

I have a Qpath output data file from CODEX and the top columns are labeled with channels and X and Y coordinates. Since this is only one sample, we did not label the sample name or tissue name.
I was able to run the demo pipeline, but unfortunately, I am unable to run my own dataset even after changing the function as instructed (i.e. load_hubmap_data and load_tonsil_data).
I am a bit confused about the terms "landed" and "unlanded" dataset. Do I need to provide a labeled dataset?
Thank you for your help.

Hi! Yes, you need to provide a labeled dataset so that labels from labeled to unlabeled dataset can be transferred. STELLAR takes as input labeled and unlabeled datasets.


Report which custom reference was applied

Currently, after calling set_eeg_reference() with a custom channel name, or invoking add_reference_channels() (which calls the former after adding all-zeros channels), to my knowledge it's impossible to retrieve which reference channels are being used in the current referencing scheme. The only thing that gets set in info is 'custom_ref_applied'.
import os.path as op
import mne

data_path = mne.datasets.testing.data_path()
examples_dir = op.join(data_path, 'Brainvision')
vhdr_file = op.join(examples_dir, 'Analyzer_nV_Export.vhdr')

raw = mne.io.read_raw(vhdr_file, preload=True)
raw.set_eeg_reference(['F8'])

# do fancy stuff here
# ...
# Wait … WHICH reference did I apply again? Guess I'll have to find the channel
# with all-zero data :(

Isn't there a way to keep track of which references were set?

Maybe we can use this existing attribute, but instead of True/False we set it to the reference channel name(s)? I'd also include the average reference case here, which is currently also not stored anywhere.

Maybe we can use this existing attribute, but instead of True/False we set it to the reference channel name(s)?

Currently, the following values are supported:
FIFF.FIFFV_MNE_CUSTOM_REF_OFF       = 0
FIFF.FIFFV_MNE_CUSTOM_REF_ON        = 1
FIFF.FIFFV_MNE_CUSTOM_REF_CSD       = 2

(CSD – current source density)
Interestingly, there's yet another constant in constants.py; not sure why we have this kind of redundancy:
FIFF.FIFF_MNE_CUSTOM_REF             = 3567     # Whether a custom reference was applied to the data

In any case, when writing the measurement info, we do the following:
https://github.com/mne-tools/mne-python/blob/8e3bcefe2da6b47d1725eee5a487468277e8f5dd/mne/io/meas_info.py#L1681-L1682
I don't think we can simply write a different data type there…
At first I thought: Oh, cool, it's an int, so we simply write the index of the reference channel! But … obviously this wouldn't work for channels 0 to 2 ;) Also you wouldn't be able to specify more than just a single reference.

(heads-up, I've edited my above post several times)

Yeah, that's the old FIFF format compatibility story which is really holding us back. If we can't change info["custom_ref_applied"], what about adding info["reference"]?

Yeah, that's the old FIFF format compatibility story which is really holding us back. If we can't change info["custom_ref_applied"], what about adding info["reference"]?

Can one "simply" add new entries? I wasn't aware of that!
I was also thinking about abusing the new per-channel Annotations somehow… But this is really not my area of expertise. Let's wait for @larsoner to chime in here :)

Also we'd want to support the REST average as well. And maybe future references which haven't been invented yet…

No, we can't simply add new FIFF fields, but I thought that exporting to FIFF doesn't simply dump the whole Info object, but instead picks out the relevant fields. If this really works like this, we can add a new field which will be ignored. This field should be a string or list of strings, so any future references are automatically supported.

No, we can't simply add new FIFF fields, but I thought that exporting to FIFF doesn't simply dump the whole Info object, but instead picks out the relevant fields.

Yes, that seems to be the case

If this really works like this, we can add a new field which will be ignored.

👌

I meant ignored by MNE when writing to FIFF - so this field shouldn't be written. However, it would be even better if we wrote that field and programs would just ignore it when reading if they don't know about it. But let's wait for @larsoner, he'll know for sure.

I meant ignored by MNE when writing to FIFF - so this field shouldn't be written.

But then you'd lose the info during an I/O roundtrip, which is super confusing IMHO…
Let's wait for @larsoner  ;)

But then you'd lose the info during an I/O roundtrip, which is super confusing IMHO…

I know, but FIFF was never designed to hold all that information. If we can easily add optional fields, then everything is fine. Maybe we should think about a new simple format such as pickling raw?

Maybe we should think about a new simple format such as pickling raw?

I do love pickles (Spreewald 🥳) but I don't like pickled data :) It's not really portable and not suitable for long-term storage.
I'd actually prefer something like a simple JSON sidecar file or so…

I don't like the pickle format either, but two files are also asking for trouble. Maybe we should just store as .mat (I'm only half-joking here)...

If this really works like this, we can add a new field which will be ignored.

But then you'd lose the info during an I/O roundtrip, which is super confusing IMHO…

Agreed, Info should only hold things that will survive I/O round trip. If we need to store more information there we should improve the spec.

Maybe we should think about a new simple format such as pickling raw?

I don't think we plan to jump to a new format anytime soon and even if we do, we need to make FIF work as well as possible so I don't see it really helping with the problem.
We can add things to info the right way -- i.e., by enhancing the fiff-constants spec -- but we need to justify it and do the work of coming up with an appropriate spec.
I agree it would be nice to store what each channel's set of references is more flexibly. For example in sEEG if you have a ton if bipolar-reference pairs, it would be nice to store properly these references and be able to recover them. This case is technically possible now because you can store one ref location in info['chs']['loc'][3:6]. However, our system currently only works if each channel only has a single reference, or all channels use an average reference.
Is there a format that stores such arbitrary reference information well? We could look to that for guidance.
Just to give one proposal -- we recently spec'ed out and added support for an enhanced channel information block, mostly to get us past the 15-char limit for FIF. To make a concrete proposal, then, we could add a new tag there like FIFF_CH_REFS, which is a float32 ndarray of shape (N, 4) containing the x/y/z location (first 3 cols) and weight (last col) for the N references used for the channel. For standard Neuromag data and standard one-ref EEG acquisitions, this would just be (ref_x, ref_y, ref_z, 1.). If you did an average reference using a direct application instead of a projector, this would be all channel locations with a value of 1 / N in the last column. For non-EEG channels it's empty.

I agree it would be nice to store what each channel's set of references is more flexibly. For example in sEEG if you have a ton if bipolar-reference pairs, it would be nice to store properly these references and be able to recover them. This case is technically possible now because you can store one ref location in info['chs']['loc'][3:6]. However, our system currently only works if each channel only has a single reference, or all channels use an average reference.

But this would only help you recover the location of the reference, not its name or channel index (in case the channel is present in the data). To find out if the specified reference channel is even still part of your data, you'd have to iterate through all channel locations until you hopefully find the matching coordinates … seems awkward?
Which also highlights that there are two different we'd have to deal with:

reference channels that are present in the data – they'd have a channel index, an associated name, and a location
reference channels that are not (currently) present in the data. They'd only have a channel location (if any), and potentially a name.

When I opened this issue, I was only thinking about addressing case 1, assuming this would be easier. We'd force users to add missing reference channels via mne.add_reference_channels(), reducing the amount of special-casing needed to be done surrounding those references.

To make a concrete proposal, then, we could add a new tag there like FIFF_CH_REFS, which is a float32 ndarray of shape (N, 4) containing the x/y/z location (first 3 cols) and weight (last col) for the N references used for the channel. For standard Neuromag data and standard one-ref EEG acquisitions, this would just be (ref_x, ref_y, ref_z, 1.). If you did an average reference using a direct application instead of a projector, this would be all channel locations with a value of 1 / N in the last column. For non-EEG channels it's empty.

I'm not sure we'd really need the weights. I'd just assume all refs are weighted equally … I mean, I've never seen anything else during EEG processing. But of course, your experience may differ.
Again, here we're only talking about channel locations again, instead of indices or names. Doesn't that make things unnecessarily complicated for case 1 described above?

To find out if the specified reference channel is even still part of your data, you'd have to iterate through all channel locations until you hopefully find the matching coordinates … seems awkward?

Let's be clear about the "who" is here. When I'm talking about keeping track of the information in the FIF spec, the "who" I'm talking us as maintainers dealing with our internal storage of the information and I/O possibilities.
For the user -- a very different "who" -- we can easily expose some function or something that converts these locations to channel names, or whatever they need.
So to me the I/O spec should be complete (what I was addressing), and the user-facing API is a separate issue.

To find out if the specified reference channel is even still part of your data, you'd have to iterate through all channel locations until you hopefully find the matching coordinates … seems awkward?

For the base case of Neuromag EEG data, you won't find one because there is a single ref electrode and it's not in the data (it would be all zero anyway). So we're already in this situation for a lot of datasets. And I'm not too worried about having to do this iteration, a suitable np.allclose should get us there. And we update set_montage or anything else that updates channel locations to be "channel reference aware". So I don't think it's too difficult for us to internally manage this.

Doesn't that make things unnecessarily complicated for case 1 described above?

Only in terms of how we internally deal with things, not to users. And it actually supports use case (2), and works like things do now ("store the location of the reference" -> "store the locations of any references").

I'm not sure we really need the weights.

I don't know what sorts of refs people have used, but having weights allows for (nearly) arbitrary linear transformations of the data, which is nice. And the storage here is pretty trivial so I don't see any problem with including it, even if we never really end up using it.

Thanks for the clarification, @larsoner! If you think the np.allclose() approach would work to construct location <> channel identity, I'm +1 for your proposal!

How would we encode the REST referencing scheme?

REST is weird as it depends on passing a forward etc. We could think about adding a new constant for it or something but this seems like a far less critical case than standard channel-based references

REST is weird as it depends on passing a forward etc.

Yep. But a way to store a name – simply the string "REST" – could make sense, don't you think?

Actually on second thought IIRC REST is also known as an infinity reference, so we can signal it's being used even in main just by setting locs[3:6] to np.inf, and we can also do this in the system I proposed. So no need for a chance just for that

@larsoner Good idea!
What do you think, how should we go about moving forward here? Clearly I'm lacking a big deal of expertise, but if you think I could somehow contribute, please do let me know!

using locations to know how channels were referenced should not be the primary source of information. I anticipate that we have EEG data without channel locations but we some channel based references. See channel names you see in EEG world (eg saying that it's Cz-M1 referenced to M1). This suggests that the channel block idea (which I like) should contain a list of channels and not locations). Note that it means that it may contains channel names that don't exist in inst.ch_names or info['chs"] and it contains no data...

Note that it means that it may contains channel names that don't exist in inst.ch_names

This is exactly the case for data acquired by Neuromag systems currently for example. So I think just keeping track of channel names won't work for systems that do actually encode physical locations, just like you think keeping track based on locations won't work for systems that don't.
What if we keep track of name+location of each reference? This would just mean one more tag with is a list of names to match the list of locations.

What if we keep track of name+location of each reference? This would just mean one more tag with is a list of names to match the list of locations.

Sounds good to me. @agramfort's comment also reminded me of EEG recordings we'd done a few years back with reference electrodes placed on the tip of the nose. These would not have any proper location associated with them.

but to me you will always have names even if they are ad-hoc names like
EEG001,EEG002, etc.

but to me you will always have names even if they are ad-hoc names like EEG001,EEG002, etc.

Yep!

Whatever you decide is best to represent the reference internally, I would really love to see a public API that simply gives me the reference as a string (e.g. "C3", "average", "REST", ...) or a list of strings (e.g. ["M1", "M2"]). Many EEG data sets do not specify the reference, so in that case we could simply set this to "unknown".
Come to think of it, maybe we shouldn't even use "average", because we could use a list of all channel names instead. This would be more explicit and would avoid ambiguities such as whether or not the original reference channel was added back to the data before the average reference was computed. If references consisting of multiple channels that are weighed differently are a thing, we could also store a list of weights in addition (which by default consists of all 1/N elements, where N is the number of reference electrodes).

but to me you will always have names even if they are ad-hoc names like EEG001,EEG002, etc.

It sounds like you're pushing to store only the names? To me this is still problematic because it's lossy. If we eventually want to do anything having to do with the physical arrangement of the recording setup (e.g., forward modeling), we need the locations of the references, which might not be proper channels (in the sense of having an entry in info['chs']) in the dataset, hence they could be missing/gone.
We have some recordings with just channels and no locations. We have other recordings with (at least) a single ref location and no channel name (Neuromag). And in theory it's not hard to imagine a recording with just reference locations stored in the dataset somehow (e.g., a recording with two EEG data channels, Cz and FCz, each of which was recorded referenced to the average of left and right mastoids), and in practice it's easy to get this after some picking/dropping.
To me I don't see a downside to storing names+locations rather than just names. In terms of implementation it's not much harder: if we set an EEG location based on a channel name (set_montage is really the only place we do this I think?) then we need to check the EEG reference names and set those locations, too.

ok fair enough It seems that storing both names and locations is
necessary...

I like that!
It's almost like eating the cake and having it too! 🍰


Correct parenthetical type spacing

Resolves #215

Yikes... Let me fix the merge conflicts

Subsumed by #258


fix: make tfsec.sh executable

@antonbabenko I sincerely apologize, must have been an oversight. Looks like chmod +x needed to be ran on this file to make it executable. Can you please merge this in ASAP?

It happens to all of us. Thanks for the correction.
v1.37.0 has been just released.


Translate text

Is it possible to translate the text through the options?

@Henqsan You can pass the translated text as option labels in your default select element.


fugitive  branch change

airline can't display branch name that use "git checkout" command
example
1st: ariline display current branch is 'master'
2nd: I run 'git checkout test', airline don't display 'test'

Is there a function exposed that re-reads the branch from fugitive? AirlineRefresh doesn't, but some combination of time and switching windows and tabs will eventually update the branch.


Clicking on narrow doesn't maintain position in stream

Clicking on a narrow results in the stream jumping to the latest narrow in the message.
The intended behavior (consistent with the web app) is to jump to the message whose header was clicked.

@neerajwahi Have you started on this, or can I do it?

You can do it. I left comments on some open PRs though so best if you could address those first


DOC: add to the documentation what summary_fg means

Can you run python -m ruff format mriqc/qc/anatomical.py on this?


Add support for custom CA.

Is your feature request related to a problem? Please describe.

I have a system where I want to build repeatable images with k3s, and give them to downstream developers.
I want to use certificates signed by a full CA chain that is entirely within my control, to sign into these k3s api servers for auth purposes.
I do not want to check in to source control my entire chain of certs, including the keys.  For either the root or the intermediate.  I do not want private keys involved, or any other secrets.
I just want the ability to specify a trusted CA by the api server, without interfering with k3s's creation of the cert chains that it uses for interoperability internally.
When I give the arg --k8s-apiserver-arg client-ca-file=/my/root/ca, it totally ignores the argument and spawns the api server with one in "/etc/rancher/something".  I think that should at least result in a failure to start, not silently drop my argument on the floor.  That would have saved me some debugging, at least.
Describe the solution you'd like

I want a flag called "trustThisCA" that will import a root PEM file and trust that root, in addition to any roots that k3s may create.  I do not want to replace k3s root files, I want it to use both when passing them on to the apiserver that k3s is spawning -- I want the convenience of not having to run custom_CA_generate.sh and I want to be able to specify additional root PEMs to trust certs signed by it.
Describe alternatives you've considered

N/A
Additional context

Most of the input to building a k3s server for me has to be submitted to version control, so putting anything with a secret into it, sucks.  Public keys are great, secrets, not so much.  Being able to say "trust this" without providing a secret is a win, for me.

I do not want to check in to source control my entire chain of certs, including the keys. For either the root or the intermediate. I do not want private keys involved, or any other secrets.

This is not possible. K3s generates a number of certificates for use by internal components. If you want to K3s to sign its internal certs, and validate client certificates, using an existing CA, you MUST provide an intermediate CA certificate that K3s can sign additional certificates with. There is no way around this.
Check the docs at https://docs.k3s.io/cli/certificate#custom-ca-topology for more information on supported CA topologies.


Possible to create a version without the TTS part?

Hey! I'd like to use this plugin but I have no intention of using the TTS part and would not like my IP being sent to a 3rd party server. Is it possible to create a fork / another plugin on the plugin hub that doesn't involve the 3rd party server warning?

In general I don't think creating forks of plugins to be hosted on the hub would be a good precedent. But I think there's a couple things we could do here. First of all, the plugin will only make a request to the server if you ask it to play TTS. So if you never do that (either by clicking test or by an alert firing) then the server is never hit. I know that's fragile, but in the meantime it's something.
As a long term solution, I could introduce a global tts-disable setting. Could maybe even default it on so that you have to opt-in specifically for the tts.

Thanks for the input! I just blocked the domain in my hosts file, however, if the domain was ever changed in the plugin, or worse hacked / registry lapsed and stolen it could be an issue. The IP warning on RL definitely is keeping the installs down, and it's such a good plugin to have certain things force notifications, i.e I use it for Prayer and HP while focused, with the rest like skilling only out of focus.
Unfortunately I'm not a Java/Kotlin developer but if I can help contribute in any way please let me know. I only have one possible idea for the TTS that would be using some code/library that allows the RL plugin to do TTS locally on device, without sending a string of text to a website.

I, and many others, have tried to use local TTS libraries in plugins but they've all been denied because of security concerns (also file size is pretty large) so this was the only way for us to get any form of TTS in.
I wouldn't have thought the RL warning would deter that many people, but maybe that sort of thing scares more people than I would expect. Even though anytime anyone visits any website they get their ip....haha. There might be precedent for removing the warning as long as the tts is opt-in.

Pending plugin hub release

This is now released on the plugin hub! 🎉


Add icon exclusion list for color check

We need to exclude some icons for testing, because it is better not to change their color
Here is a list of these icons:

folder-vue*
grunt
jenkins
kotlin
travis

Maybe the color check tool could scan for a specific attribute. If the attribute is present inside of the SVG file, then the colors of such a file are ignored.

Maybe the color check tool could scan for a specific attribute. If the attribute is present inside of the SVG file, then the colors of such a file are ignored.

No, it would be better to add the exclude: key in the material-colors.yml configuration, and there already write a list of icons to exclude
Because these attributes will take up space and the purpose of svgo is to minimize svg
The option with config will be the best

Move this issue to https://github.com/PKief/svg-color-linter

I've moved it.


Wait for jobset operator on starting e2e tests.

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:
Wait for jobset operator ready before start e2e tests.
Which issue(s) this PR fixes:

Fixes #2428
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/test all

I think we might also need to have an update to JobSet to wait for the webhook service with probes as we do here: https://github.com/kubernetes-sigs/kueue/blob/5be1c2037751fedbcca58f4c3834ee1b8da2fcc5/cmd/kueue/main.go#L294-L320. Otherwise JobSet can say it is available but it is really not.

Thanks @mimowo. Created an issue https://github.com/kubernetes-sigs/jobset/issues/607.

I guess this doesn't fix https://github.com/kubernetes-sigs/kueue/issues/2428 but itself, but it gets us closer.
/lgtm
/approve

/cherry-pick release-0.7

@mbobrovskyi can you prepare a cherry-pick for this?


Fix recipe maintainer

I'm actually the author of the nr.fs PyPI package.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This is handled with PR ( https://github.com/conda-forge/nr.fs-feedstock/pull/7 ), right?

Yeah, looks like I accidentally created the PR twice. :)


Ref injection

Creating a PR to master to publish the package with the updated docs.

Creating a PR to master to publish the package with the updated docs.

Please provide a full overview of this PR for review. There are examples from previous PRs and directions in the sprint task within the project. Thank you.

Creating a PR to master to publish the package with the updated docs.

Please provide a full overview of this PR for review. There are examples from previous PRs and directions in the sprint task within the project. Thank you.

@devloverumar please note:
From #228 on the centre-website project.

[ ] Provide an overview of your solution and rational in your PR.
[ ] Include images or code references to help whomever is doing the code review understand your workflow.
[ ] include a GIF or loom of your solution.
[ ] include a note of what you would like to see in the next version of your feature.
[ ] Use headings, sub-headings, and bullet lists in your PR.

Please also add all labels that fit to the side-bar. I've included this PR in the V5 website project.

Creating a PR to master to publish the package with the updated docs.

Please provide a full overview of this PR for review. There are examples from previous PRs and directions in the sprint task within the project. Thank you.

@devloverumar please note:
From #228 on the centre-website project.

[ ]  Provide an overview of your solution and rational in your PR.
[ ]  Include images or code references to help whomever is doing the code review understand your workflow.
[ ]  include a GIF or loom of your solution.
[ ]  include a note of what you would like to see in the next version of your feature.
[ ]  Use headings, sub-headings, and bullet lists in your PR.

Please also add all labels that fit to the side-bar. I've included this PR in the V5 website project.

I updated PR as per #228

Right now ref injection is not working for nested styled-components.

@devloverumar is this still the case? Did you attempt a solution? What was it? Why didn't it work? Or if not, what is your current latest advice?

Yes I tried debugging with the react-reveal source code with different scenarios on my local but no success yet. I think I would be able to solve it by tomorrow. Otherwise, another option would be to create a hook for the Fade effect like useFade() to inject in our styled-components. What are your thoughts?

Right now ref injection is not working for nested styled-components.

@devloverumar is this still the case? Did you attempt a solution? What was it? Why didn't it work? Or if not, what is your current latest advice?

@mustefa Yes I tried debugging with the react-reveal source code with different scenarios on my local but no success yet. I think I would be able to solve it by tomorrow. Otherwise, another option would be to create a hook for the Fade effect like useFade() to inject in our styled-components. What are your thoughts?

The issue could be as mentioned here in styled-components docs
Passing a ref prop to a styled component will give you one of two things depending on the styled target:

the underlying DOM node (if targeting a basic element, e.g. styled.div)    (my solution is working for this scenario)
a React component instance (if targeting a custom component e.g. extended from React.Component)  (solution not working in this scenario, maybe the component being passed to styled component have to be a class component extended from React.Component)

Right now ref injection is not working for nested styled-components.

@devloverumar is this still the case? Did you attempt a solution? What was it? Why didn't it work? Or if not, what is your current latest advice?

@mustefa Yes I tried debugging with the react-reveal source code with different scenarios on my local but no success yet. I think I would be able to solve it by tomorrow. Otherwise, another option would be to create a hook for the Fade effect like useFade() to inject in our styled-components. What are your thoughts?

The issue could be as mentioned here in styled-components docs
Passing a ref prop to a styled component will give you one of two things depending on the styled target:

the underlying DOM node (if targeting a basic element, e.g. styled.div)    (my solution is working for this scenario)
a React component instance (if targeting a custom component e.g. extended from React.Component)  (solution not working in this scenario, maybe the component being passed to styled component have to be a class component extended from React.Component)

@mustefa  and it worked when I applied a solution as per the above points. Let me test properly and then I'll push changes.


Fix local participant item to show menu icon when hovered and there are menu buttons

What
Fix local participant item to show menu icon when hovered and there are menu buttons
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3726245
How Tested
Local calling sample:
https://github.com/Azure/communication-ui-library/assets/79475487/716d1d45-b2fc-47cb-a1a0-1791e9bd21f0
Local call with chat samples test:
https://github.com/Azure/communication-ui-library/assets/79475487/f5cffc70-c286-4b54-9ae5-9313d24410e1
Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

I thought we intentionally disable menu icon for local participant - what happens if people click on the icon?


Implement socket connection for ssh

Tools using SSH usually implement reusing of ssh connection via a socket which greatly speeds up the ssh commands. We should look into if this would be possible in tmt to gain the same benefit.
Some similar concepts used by other tools:
https://docs.ansible.com/ansible/latest/reference_appendices/config.html#envvar-ANSIBLE_PIPELINING
https://puppet.com/blog/speed-up-ssh-by-reusing-connections/

Hello. Is this still free?
There is already master connection with multiplexing used in 1minutetip so I less or more understand that topic.

As far as I know, noone has expressed interest in working on this yet, I assigned it to you @RHEmployee

Thank you.

Hello.
After some digging. Putting all in one place to avoid fragmentation.
Looks like paramiko library doesn't support multiplexing:
https://github.com/paramiko/paramiko/issues/852
so ControlMaster seems to not be supported.
So I just fallback back to use CLI ssh, however this needs one process for master connection which going to run in background while tmt runs. Then cleanup is needed to avoid many processes on system which dies eventually but it takes some time.
There is one issue with openssh with -S argument however it's not directly openssh issue but it is issue of userland/kernel which doesn't allow sun_path longer than exact num of chars (256 or similar size which you can read: not enought).
https://github.com/openssh/openssh-portable/blob/master/mux.c#L2265
I still investigate in parallel other libs for ssh however main goal is to gain multiplexing.
Main source of material for further investigation is here:
https://medium.com/the-elegant-network/a-tale-of-five-python-ssh-libraries-19cb8b72c914

WIP is now here:
https://github.com/psss/tmt/pull/900
it seems to work, but some code cleanup will be nice.

Add support for ssh multiplexing has been merged. Closing.


How can i create custom mini dataset using 3d objects and images?

I don't have any idea to create dataset for LGM models.

@Rameshkumardas Hi, you only need to render multi-view images and save them with camera poses properly. For example, you can try this blender script for rendering: https://kit.kiui.moe/blender/.

@Rameshkumardas Hi, you only need to render multi-view images and save them with camera poses properly. For example, you can try this blender script for rendering: https://kit.kiui.moe/blender/.嗨，您只需要渲染多视图图像并使用相机姿势正确保存它们。例如，您可以尝试使用此 blender 脚本进行渲染：https://kit.kiui.moe/blender/。

I am also very interested in this project. Will you consider to add this part later into the code?


Add support for Ollama, Palm, Claude-2, Cohere, Replicate Llama2, Hugging Face TGI (100+LLMs) [LiteLLM]

This PR adds support for the above mentioned LLMs using LiteLLM https://github.com/BerriAI/litellm/
LiteLLM is a lightweight package to simplify LLM API calls - use any llm as a drop in replacement for gpt-3.5-turbo.
Example
from litellm import completion

## set ENV variables
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["COHERE_API_KEY"] = "cohere key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# cohere call
response = completion(model="command-nightly", messages)

# anthropic call
response = completion(model="claude-instant-1", messages=messages)

addressing here: https://github.com/GPT-Fathom/GPT-Fathom/issues/7

@shenz2-2000 re your point about minimizing dependencies litellm itself is a lightweight package: you can see our dependencies here: https://github.com/BerriAI/litellm/blob/6f4707bbb38ec9e6b054a6337f9a4bbb12e4eb08/pyproject.toml#L9

Hi @ishaan-jaff, thank you for writing an support for litellm in our repo. As we want to minimize external dependency, we would like to provide litellm as an optional feature for the user, and let users themselves decide to use it or not. You are very welcome to provide a document/guideline, demonstrating how to use litellm in GPT-Fathom, thus we can put on our homepage and suggest our users to use it.
Also, we would appreciate it if you could run some experiments to check the usability of your guideline to make sure it works normally in our use cases.
Thanks again for your contribution.


Multi-tenancy architecture on actor model

There is a paper at http://homepage.usask.ca/~ama883/publications/moamen-jamali-splash16.pdf

https://www.javacodegeeks.com/2013/11/architecting-a-multi-tenant-application.html

https://github.com/aspnet/EntityFrameworkCore/issues/4468


Remove SetInclusionRule{,WithArrays}

Keramelizer rewrites S \subseteq T since https://github.com/informalsystems/apalache/pull/1621.

Remove SetInclusionRule and SetInclusionRuleWithArrays, which are now redundant.
Remove 2 remaining delegations to \subseteq in CherryPick and SetInRuleWithArrays.
Remove \subseteq as an acceptable operator in KeraLanguagePred.

Closes #1710

Codecov Report

Merging #1716 (148be95) into unstable (56da0f1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           unstable    #1716      +/-   ##
============================================
+ Coverage     76.08%   76.10%   +0.02%
============================================
  Files           353      351       -2
  Lines         11316    11259      -57
  Branches        553      545       -8
============================================
- Hits           8610     8569      -41
+ Misses         2706     2690      -16

Impacted Files
Coverage Δ

...yte/apalache/tla/bmcmt/SymbStateRewriterImpl.scala
93.02% <ø> (ø)

...he/tla/bmcmt/SymbStateRewriterImplWithArrays.scala
100.00% <ø> (ø)

...ir/transformations/standard/KeraLanguagePred.scala
94.50% <ø> (-0.06%)
:arrow_down:

...apalache/tla/bmcmt/rules/SetInRuleWithArrays.scala
91.93% <100.00%> (ø)

...syte/apalache/tla/bmcmt/rules/aux/CherryPick.scala
93.28% <100.00%> (-0.03%)
:arrow_down:

.../src/main/scala/at/forsyte/apalache/tla/Tool.scala
0.00% <0.00%> (ø)

...syte/apalache/tla/imp/ParserExceptionAdapter.scala
0.00% <0.00%> (ø)

...rsyte/apalache/infra/DefaultExceptionAdapter.scala

...a/at/forsyte/apalache/infra/ExceptionAdapter.scala
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56da0f1...148be95. Read the comment docs.


Play back button for audio stimuli

How can create a playback button for audio stimuli, there does not seem to be an option in the audio plug-ins ?
Use case: I want the subject to be able to replay the stimuli (an audio) as many times as they want.
Thank you!

You could set up a looping timeline with the audio-button-response plugin so that whenever a repeat button is clicked the trial loops and the audio plays again.
var repeat = {
  timeline: [{
    type: 'audio-button-response',
    stimulus: 'sound.mp3',
    choices: ['Play Again', 'Continue'],
  }],
  loop_function: function(data){
    if(data.values[0].button_pressed == 1){
      return true; // loop again!
    } else {
      return false; // continue
    }
  }
}


[Graph RBAC] Regenerate with top param for users op

Regenerate the graph rbac package with the swagger here: https://github.com/Azure/azure-rest-api-specs/pull/13045 (the get users operation gets $top as a parameter) to help fix https://github.com/Azure/azure-sdk-for-js/issues/13625.
Regeneration command: npx autorest --typescript --typescript-sdks-folder=~/repo --license-header=MICROSOFT_MIT_NO_VERSION ~/azure-rest-api-specs/specification/graphrbac/data-plane/readme.md --use=<EMAIL_ADDRESS>

Should we add support for other ODATA parameters as well in one go?

The Graph supports the following query options: $filter, $orderby, $expand, $top, and $format. The following query options are not currently supported: $count, $inlinecount, and $skip.

What about other listing APIs that also take these parameters?

@deyaaeldeen Given that Azure AD Graph API is on its path of being deprecated in favor of the Microsoft Graph API, it is not worth pursuing the fix in this PR.
We can keep https://github.com/Azure/azure-rest-api-specs/pull/13045 open. If the service team agrees to the change and requests an update to the generated package across languages, we can revisit this.


Add text/blob option for mysql (implemented in Rails 5)

Dear, @winebarrel .
I'd like to set text/blob type of following on Schemafile.
https://github.com/rails/rails/commit/059820c09afaf18e2d29da61db0e0a3215989b89
Can I add them to dsl_parser.rb and create pull-req?
https://github.com/winebarrel/ridgepole/blob/v0.6.5/lib/ridgepole/dsl_parser.rb#L21

Thanks for your report!
This issue is fixed. 😃


DNS Change - migrate traffic from Wix to Github Pages

https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site
Note:

Make sure you add your custom domain to your GitHub Pages site before configuring your custom domain with your DNS provider. Configuring your custom domain with your DNS provider without adding your custom domain to GitHub could result in someone else being able to host a site on one of your subdomains.

Troubleshooting doc: https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/troubleshooting-custom-domains-and-github-pages

Note:  HTTPS is already configured in settings.
https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

Verifying domain ownership, per https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/verifying-your-custom-domain-for-github-pages
Added a new domain to organization: ideasawakened.com
Added a TXT record in Gandi as instructed:
name: _github-pages-challenge-ideasawakened
value: from settings page:
https://github.com/organizations/ideasawakened/settings/pages_verified_domains/ideasawakened.com
Waited a few seconds and clicked the Verify button... domain verified:

Setup a custom domain in repo Pages settings via: https://github.com/ideasawakened/ideasawakened.github.io/settings/pages

Added ideasawakened.com and hit save

Error occcurred as DNS hasn't changed yet

Error occcurred as DNS hasn't changed yet

Edited www CNAME record from www0.wixdns.net. to ideasawakened.github.io.

Edited A record for @ from <IP_ADDRESS> to <IP_ADDRESS>

Created three more A records:  <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>

Saved a DNS backup after changes made

Back on settings page, https://github.com/ideasawakened/ideasawakened.github.io/settings/pages
Clicked on check again and still failed...but now a new message about certificate being provisioned was also displayed.

Changes already working on my phone... new site displayed when visiting
http://ideasawakened.com
https://ideasawakened.com
https://ideasawakened.com/blog

Note: multiple A records are apparently used for retry attempts by browsers: https://webmasters.stackexchange.com/a/12704

Changes working on Ryan's computer

10:05pm  DNS Check successful on settings page! https://github.com/ideasawakened/ideasawakened.github.io/settings/pages

GitHub pages link for more info: https://docs.github.com/en/rest/pages?apiVersion=2022-11-28#update-information-about-a-github-pages-site


FeatureRequest: Please support true multiline input

Current Situation: When dealing with scala multiline code in scripting mode you still have to adapt the source code instead of just running it in the REPL (ammonite has by now the unwrapping support of code blocks { } so that multiline code can be rather easily adapted, but nevertheless you still have to adapt the code)
FeatureRequest: I would like to see ammonite have a true multiline support out-of-the-box without any need of code adaptations.
Suggestion:
As a reference I want to refer to ipython, which supports this style of multiline input by waiting for the first blank line (i.e. a line with only whitespace) and then executing the whole code chunk.
To be fair, python does not have leading dots, but only need this for method definitions and for loops which have a clear indicator (the colon :) as the start for additional multiline support.
In scala the leading dot in need of multiline support can appear anywhere, so in addition to wait for the blank line, one would ideally skip it in the true output. I mean that if you just want to execute 1 + 2 then you have to enter an additional blank line after it (i.e. press Enter twice)
@ 1 + 2

(note the blank line in the end without any comments or else)
which should result in overall output
@ 1 + 2
res0: Int = 3

where the additional blank line is skipped

I'm gonna call this a wontfix. As you said, you can already trivially wrap things in {}s, and your description of ipython doesn't really match reality (we already support exactly the same multi-line input that ipython supports)


Whole image selection

How to make whole image is selected by default. now if I open image 9:16 only part is selected by default, I want full space of image be selected

Hello @BoikoIlya !
The initial selection depends on the default aspect ratio. Which is the first element in the list of aspectRatios that you can pass to cropperStyle.
If you pass your image's aspect ratio, it would look like this:

(Picture from the demo)


[4.2 06-11] When loading Obj-C methods via a selector and the method is an accessor, import the property as well.

When loading Obj-C methods via a selector and the method is an accessor, import the property as well.

@swift-ci please test

@swift-ci please test and merge


FontAwesome5Pro New Icons update

There are many new icons available to use in FA5, it needs a refresh :)

👍 stay tuned 🙂

Good day, any news on this? @hampustagerud.
There are a ton of new icons that return a '?'. About half of them I try to use (newer ones) result in this.
Cheers.

Hello, I have a branch running the very latest release (5.13.0) so I think I can get that pushed today 🙂 Sorry for taking so long on this one!

Hello, I have a branch running the very latest release (5.13.0) so I think I can get that pushed today 🙂 Sorry for taking so long on this one!

Hello, I have a branch running the very latest release (5.13.0) so I think I can get that pushed today 🙂 Sorry for taking so long on this one!

Great! No worries, thank you @hampustagerud


run kube-flannel-aliyun.yml with ali coud vpc

Expected Behavior
I used kubespray to deploy k8s cluster, Ali cloud VPC network. Network plug-in uses flannel backend ali-vpc
I try run kube-flannel-aliyun.yml error
Current Behavior
kubectl logs  kube-flannel-ds-wrrmw  -n kube-system

I0624 04:00:45.340799       1 main.go:470] Determining IP address of default interface
I0624 04:00:45.341171       1 main.go:483] Using interface with name eth0 and address <IP_ADDRESS>
I0624 04:00:45.341189       1 main.go:500] Defaulting external address to interface address (<IP_ADDRESS>)
I0624 04:00:45.444724       1 kube.go:130] Waiting 10m0s for node controller to sync
I0624 04:00:45.444783       1 kube.go:283] Starting kube subnet manager
I0624 04:00:46.444910       1 kube.go:137] Node controller sync successful
I0624 04:00:46.444946       1 main.go:235] Created subnet manager: Kubernetes Subnet Manager - node4
I0624 04:00:46.444952       1 main.go:238] Installing signal handlers
I0624 04:00:46.445067       1 main.go:348] Found network config - Backend type: ali-vpc
I0624 04:00:46.445129       1 alivpc.go:62] Unmarshal Configure : { }
E0624 04:00:46.445218       1 main.go:280] Error registering network: ACCESS_KEY_ID and ACCESS_KEY_SECRET must be provided!
I0624 04:00:46.445262       1 main.go:328] Stopping shutdownHandler...

Possible Solution
How to pass the secret ACCESS_KEY_ID and ACCESS_KEY_SECRET to flannel
Your Environment

Flannel version:v0.9.0
Backend used (e.g. vxlan or udp): ali-vpc
Etcd version:
Kubernetes version (if used):v1.10.4
Operating System and version: centos7.5
Link to your project (optional):

Pass the ACCESS_KEY_ID and ACCESS_KEY_SECRET by  config it on the flannel pod template's env  section;


Plugin is incompatible with Gradle 8.4 + Kotlin 1.6.21 since 0.4.1

This plugin unfortunately seems to incompatible with our Spring Boot 2.7.x projects since 0.4.1 (maybe due to a Kotlin plugin update?).
We use Gradle 8.4 and Kotlin 1.6.21.
0.4.0 works while 0.4.1 and all newer releases fail with:
java.lang.NoSuchFieldError: KOTLIN_STAT_ENABLED_PROPERTY
        at org.jetbrains.kotlin.gradle.plugin.KotlinGradleBuildServices.<clinit>(KotlinGradleBuildServices.kt:52)
        at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:92)
        at org.jetbrains.kotlin.gradle.plugin.KotlinBasePluginWrapper.apply(KotlinPluginWrapper.kt:54)

Upgrading from Kotlin 1.6.21 to 1.7.0 fixes the problem but that's unfortunate as 1.6.21 is the version that is officially supported by Spring Boot 2.7.x and 3.x is a major change that can't easily be done yet for some projects.
Is there anything that can be done?
Example project https://github.com/felixscheinost/reproduce-javaagent-gradle-plugin-issue
Thanks!

Hi @felixscheinost, thanks for pointing this out and for providing the reproducer project! I don't have a formal backwards compatibility policy for this project yet, but I'll take a look at what makes sense in the context of this issue and work on clarifying this for the future. I should have a response to you later next week

Yeah, I understand that with Kotlin it is a little bit difficult to keep backwards compatibility sometimes. It may also not be worth it, if it means restricting the library code too much. But maybe there is a solution and if not I maybe a test could be added which tests a baseline of compatible versions.

👋 Hi @felixscheinost, I believe you can fix this issue in your build without limiting this project to older kotlin versions. Take a look at this solution where the javaagent dependency is managed in an included build (buildSrc) and the subproject uses an old kotlin version but still applies the plugin.

Thank you very much for coming up with that solution, even though I don't completely understand how that makes a difference 😄 Does the resolution of transitive dependencies work differentlly when included in buildSrc compared to when included in plugins block directly?
I haven't had a chance yet to test this in the upstream project but I could reproduce that your solution fixes the problem in my example project.
This issue can probably be closed or do you think there's anything left to do?


Update Python from 3.10.x to 3.12.x

Describe the Task
Python needs to be updated from Python 3.10 to Python 3.12.x, consistent with the version on the NCEP/NCO WCOSS2 hosts.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Upgrade other modules (i.e. pandas, numpy, matplotlib, plotly, etc.) to Python 3.12-compatible versions and make necessary changes
[ ]  test/verify for METcalcpy
[ ]  test/verify for METplotpy
[ ] update the requirements in the NCO and repository requirements.txt and toml files

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Review default alert labels
[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Milestone and Projects

[ ] Select Milestone as a METcalcpy-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
[ ] For a METcalcpy-X.Y.Z version, select the METcalcpy-X.Y.Z Development project

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of develop.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Add any new Python packages to the METplus Components Python Requirements table.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into develop.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METcalcpy-X.Y.Z Development project for development toward the next official release
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

Closing this issue as "not planned" in favor of the METplus issue for all of the applicable repos: Update Python from 3.10.x to 3.12.x #2697.


⚠ Bofrost.be has degraded performance

In 76a9917, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1233 ms

Resolved: Bofrost.be performance has improved in 62d642d.


Add information about GPU-focused AMI

A lot of GPU related software can have a steep learning curve w.r.t. installation and configuration. Amazon has a pre-baked AMI to get started at no up front cost, at the risk of a bit of lock-in if you use these AMIs in production.

Great addition. Two possible small improvements:

Should this bullet could be moved up, so it's up one level (a 2nd level bullet before "As with any expensive...")?
This lock-in is because of Amazon Linux as well as the software configs, right? Might be worth mentioning that there is lock-in from that, and putting ⛓ at the front of the bullet.

Over to @max-zanko (ec2 topic editor) for 2nd pair of eyes.

Cool! LGTM. @max-zanko ?

Any other changes on this @max-zanko ? It's ready to go as far as I'm concerned.


1 curl https request strace

Hello Alex,
I tried to do 1 curl requst to SSLApp from examples/HelloWorlds.js:
$ curl -k https://localhost:9001/
It seems something wrong in the event loop request handling logic:
1549719277.970468 accept4(20, NULL, NULL, SOCK_CLOEXEC|SOCK_NONBLOCK) = 21
1549719277.970569 epoll_ctl(3, EPOLL_CTL_ADD, 21, {EPOLLIN, {u32=4294967295, u64=1791001362431}}) = 0
1549719277.970664 epoll_ctl(3, EPOLL_CTL_DEL, 21, 0x7fffac471a20) = 0
1549719277.970690 ioctl(21, FIONBIO, [1]) = 0
1549719277.970713 epoll_ctl(3, EPOLL_CTL_DEL, 21, 0x7fffac471a40) = -1 ENOENT (No such file or directory)
1549719277.970737 setsockopt(21, SOL_TCP, TCP_NODELAY, [1], 4) = 0
1549719277.970776 accept4(20, NULL, NULL, SOCK_CLOEXEC|SOCK_NONBLOCK) = -1 EAGAIN (Resource temporarily unavailable)
1549719277.970813 epoll_ctl(3, EPOLL_CTL_ADD, 21, {EPOLLIN, {u32=21, u64=563242011197461}}) = 0
1549719277.970837 epoll_pwait(3, [{EPOLLIN, {u32=21, u64=563242011197461}}], 1024, 950, NULL, 8) = 1
1549719277.975440 recvfrom(21, "\26\3\1\0\317\1\0\0\313\3\3X\2776\256\234\356\22d\377t)\t9\\\352\216\3E\353Q\16"..., 524288, 0, NULL, NULL) = 212
...

After accept4 file descriptor 21 we do EPOLL_CTL_ADD then EPOLL_CTL_DEL twice, then accept4 again.
Please correct this behavior, this is not only waste of time. Some bigger problem inside.

In the end double DEL too:
1549719277.977965 recvfrom(21, "\25\3\3\0\32\370\207{\"\320\34\225u\340\3622\2672\2105v\310\5\317\250\355%2;\325\277", 524288, 0, NULL, NULL) = 31
1549719277.978002 epoll_ctl(3, EPOLL_CTL_DEL, 21, 0x7fffac471a50) = 0
1549719277.978024 epoll_ctl(3, EPOLL_CTL_DEL, 21, 0x7fffac471a50) = -1 ENOENT (No such file or directory)
1549719277.978046 close(21)             = 0


Scanning QR code on iOS produces no result

Reported by oliversalzburg on 6 Oct 2014 09:10 UTC
When I scan this QR code on Android, the entry will be imported just fine. On iOS the camera will disappear and no entry will be added to the list.
[[Image(http://i.imgur.com/11WpJU9.png)]]

Closing as outdated, this was a reported issue against Android.


https_redirect does not correctly handle presence of a port in the request Host header

When a route action is configured to do https_redirect and a request is send with a port specified in the Host header the port is preserved in the response leading to incorrect behavior.
Repro steps:

Configure a route to do https_redirect
send a request which includes Host header with port :80 in it.

curl -v http://localhost:80/redirect_to_https   -H "Host: localhost:80"
> GET /redirect_to_https HTTP/1.1
> User-Agent: curl/7.19.7
> Accept: */*
> Host: localnost:80
>
< HTTP/1.1 301 Moved Permanently
< location: https://localhost:80/redirect_to_https
< server: envoy
< content-length: 0
<

It can be seen that the original port 80 was pereserved in the Location header.
Envoy should at least recognize port 80 as the default HTTP port and change it to 443 or just remove it in the Location header.
Config:
static_resources:
  listeners:
  - address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 80
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          codec_type: auto
          stat_prefix: ingress_http
          route_config:
            name: local_route
            virtual_hosts:
            - name: backend
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/redirect_to_https"
                redirect:
                  https_redirect: true
          http_filters:
          - name: envoy.router
            config: {}

I don't think this is a problem, if HTTPS in a non-default port work, remove the port number in the Host also can cause problems.  to the following this way, whether can you solve the problem?
curl -v http://localhost:80/redirect_to_https   -H "Host: localhost"

I don't think this is a problem, if HTTPS in a non-default port work, remove the port number in the Host also can cause problems. But can be optimized place is for the default port 80 can be removed.

Hmm maybe you could just add port_redirect: 443?

Hmm maybe you could just add port_redirect: 443?

This will work but it is a workaround. We should at least handle the trivial 80 -> 443 case with the https_redirect
What I saw is that curl does not put the port in the Host header by default when the port is 80 but python urllib does. Due to this I hit this very unexpectedly because the curl based tests were working while the python based tests were failing.

Fixed.


Can't add Faraday HTTP caching using README example

The example in the README for adding HTTP caching with faraday-http-cache doesn't work.
This is the example code:
Github.configure do |config|
  config.stack do |builder|
    builder.use Faraday::HttpCache, store: Rails.cache
  end
end

However, inside the outer block, config.stack is nil and so the inner block is never used.

I got the some error.
https://github.com/peter-murach/github/blob/master/lib/github_api/connection.rb#L62
api.stack is nil

Same here.

I don't think the stack property takes a &block it can take a proc though which you can then call seems like @peter-murach has more ambitious goals for the stack stuff.

You can also actually use the original code you just have to define an entirely new stack like so
stack = Faraday::RackBuilder.new do |builder|
  builder.use Faraday::HttpCache, store: Rails.cache
end

but then you use all the original middleware, and there is quite a few
module Github
  class Middleware
    def self.default(options = {})
      api = options[:api]
      proc do |builder|
        builder.use Github::Request::Jsonize
        builder.use Faraday::Request::Multipart
        builder.use Faraday::Request::UrlEncoded
        builder.use Github::Request::OAuth2, api.oauth_token if api.oauth_token?
        builder.use Github::Request::BasicAuth, api.authentication if api.basic_authed?

        builder.use Faraday::Response::Logger if ENV['DEBUG']
        unless options[:raw]
          builder.use Github::Response::Mashify
          builder.use Github::Response::Jsonize
          builder.use Github::Response::AtomParser
        end
        builder.use Github::Response::RaiseError
        builder.adapter options[:adapter]
      end
    end
  end # Middleware
end # Github


Example app not working

Hello, when I try to run the example app, all downloads immediately fail? I load up the app and all of the download tasks fail instantly. When I press the remove button then download, they also fail instantly.
More details:

ALDownloader 1.5.9
Flutter mode: release (working in debug)
Android 13 on Pixel 4 XL

aldownloader_log.txt
I tried the example app in flutter_downloader and downloads are working in release mode.

Hi @al-virti , thanks for ur issue.
It does indeed have the problem, and it's been fixed, please pull the latest code and use the latest version.

All working great, thank you very much for the swift response!


Typo in UserService.cfc - Line 99

Typo in model/services/UserService.cfc - Line 99
ending '.' (period) should be ',' (comma).
  Thanks and nicely done.

Doh! Nice catch! Thank you :)


Reconnect to firebase not working while in loop

In setup() firebase gets connected but after it gets disconnected reconnect function doesnt work.

try to add Firebase.begin(FIREBASE_HOST, FIREBASE_AUTH) in failed like that:
if(Firebase.failed())
{
   Firebase.begin(FIREBASE_HOST, FIREBASE_AUTH);
}

it will reconnect if the internet lost until the internet back again.

Yes tried that one but it never connects and results in failed

I've been having the same problem! Firebase setup seems to work. Serial monitor accuses sending variables once (which doesn't happen in fact) then the connection to Firebase fails.

@saiof95 @cayamic
Try this library by @mobizt to solve this connection issue:- https://github.com/mobizt/Firebase-ESP8266/
For more info, checkout this tutorial:- https://youtu.be/nLzC0-VaqDs
Thanks

Thank you... checked, seems good...will surely try it out...

@saiof95 Welcome 😊

Thank you so much!!!! It's finally working!
I guess the problem was that the Secret Keys are deprecated and the
Fingerprint keeps changing all the time. Firebase is suggesting users to
set up Firebase Admin SDK. I still don't have any idea how to do that.
Thanks again TrickSumo!
On Fri, Jul 17, 2020 at 8:06 AM TrickSumo<EMAIL_ADDRESS>wrote:

@saiof95 https://github.com/saiof95 Welcome 😊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FirebaseExtended/firebase-arduino/issues/472#issuecomment-660045118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APKVEVFVRARALZXQT4PAXSTR4AWBPANCNFSM4KL6JDRA
.


update ethers contract methods overrides

The existing overrides don't include EIP-1559 gas properties and I figured it's easier to just import them from ethers

Hey thanks for your PR! Looks awesome let me have a proper look tomorrow from PC and if all good I will merge and get it deployed. Appreciate the PR 💪👍👍

I need to merge this but not got round to testing it doesn't break anything! - sorry for the delay


Support apple_static_library

https://bazel.build/reference/be/objective-c#apple_static_library

No longer exists.

It's in rules_apple now, I think. But yes I agree it's not worth supporting since it's not intended to be used directly.


Alert - State not restoring if light was off.

Describe the bug
I have a node red flow setup, pretty simple, if motion is detected alert 'red' for 4 seconds.
If the light is on, 100% brightness, color: beige and the motion sensor is tripped, the alert will fire red for 4 seconds and the light will restore to 100% brightness beige.
However, if the light was off (previously on, 100% beige) and the motion is triggered, the alert will fire for 4 seconds red (correct) then fade back to off (also correct) however when you turn the light back on the brightness will be 1% even though previously it was 100% but "off"

Flow to reproduce
[{"id":"c863c01.b7ed54","type":"mqtt in","z":"511a6902.2e6b88","name":"Mailbox Light Sensor","topic":"zigbee2mqtt/Letterbox Hue Motion Sensor","qos":"0","datatype":"auto","broker":"cefc0b78.ae1558","x":140,"y":1680,"wires":[["33d68782.c800a8"]],"icon":"node-red-contrib-huemagic/hue-brightness.png"},{"id":"33d68782.c800a8","type":"json","z":"511a6902.2e6b88","name":"","property":"payload","action":"","pretty":false,"x":310,"y":1680,"wires":[["8b069a13.67c318"]]},{"id":"8b069a13.67c318","type":"switch","z":"511a6902.2e6b88","name":"Did Detect Motion","property":"payload.occupancy","propertyType":"msg","rules":[{"t":"true"}],"checkall":"true","repair":false,"outputs":1,"x":470,"y":1680,"wires":[["de3eba0.516a148"]]},{"id":"e42c0c1e.4bf6a","type":"hue-light","z":"511a6902.2e6b88","name":"RyansOffice/Roof","bridge":"36ec56b5.0cc09a","lightid":"26","colornamer":true,"x":490,"y":1800,"wires":[[]]},{"id":"de3eba0.516a148","type":"function","z":"511a6902.2e6b88","name":"Trigger Alert WITH Debounce","func":"var isInProgress = flow.get(\"mail_alert_in_progress\");\nif(isInProgress === null || isInProgress === false){\n    flow.set(\"mail_alert_in_progress\", true)\n    msg.payload.alert = 4;\n    msg.color = \"red\";\n    return msg;\n}\n\n","outputs":1,"noerr":0,"x":200,"y":1740,"wires":[["e42c0c1e.4bf6a","9f023317.91fdb","c4570949.a8e688"]]},{"id":"9f023317.91fdb","type":"delay","z":"511a6902.2e6b88","name":"","pauseType":"delay","timeout":"6","timeoutUnits":"seconds","rate":"1","nbRateUnits":"1","rateUnits":"second","randomFirst":"1","randomLast":"5","randomUnits":"seconds","drop":false,"x":460,"y":1860,"wires":[["ed8144bb.2bbd68"]]},{"id":"ed8144bb.2bbd68","type":"function","z":"511a6902.2e6b88","name":"Reset Debounce","func":"flow.set(\"mail_alert_in_progress\", false);\n\nreturn msg;","outputs":1,"noerr":0,"x":650,"y":1860,"wires":[[]]},{"id":"c4570949.a8e688","type":"trigger","z":"511a6902.2e6b88","op1":"","op2":"Triggered","op1type":"nul","op2type":"str","duration":"1","extend":false,"units":"ms","reset":"","bytopic":"all","name":"","x":470,"y":1740,"wires":[["33d1c045.8c9c6"]]},{"id":"33d1c045.8c9c6","type":"debug","z":"511a6902.2e6b88","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":630,"y":1740,"wires":[]},{"id":"cefc0b78.ae1558","type":"mqtt-broker","z":"","name":"","broker":"localhost","port":"1883","clientid":"","usetls":false,"compatmode":true,"keepalive":"60","cleansession":true,"birthTopic":"","birthQos":"0","birthPayload":"","closeTopic":"","closeQos":"0","closePayload":"","willTopic":"","willQos":"0","willPayload":""},{"id":"36ec56b5.0cc09a","type":"hue-bridge","z":"","name":"Philips hue","bridge":"<IP_ADDRESS>","key":"5BVDE8Ga9tp6aOc870qsptDahZLTgqwKNmRQbtfU","interval":"3000"}]

Is there a plan to address this bug? I'm having the same issue and I decided to search before posting and found that it's been an issue for 2 years.

Should be fixed in the latest release (v4)


Trouble with the overhangs for the impeller

Hi,
Printing with PLA on an A1 and the impeller is just really hard to print for me.
Used the Bambu 3mf files and speeds.
This is my second attempt now with lower speeds.
Thinking of printing this also with even lower speeds on the overhangs (now the defaults for slowing down during overhangs).
Did anyone else have such a hard time printing this?

I made a short about that topic;
https://m.youtube.com/shorts/qC6KJh5NBew
I printed the first one in januari when it was colder.
now I need to print with the door open en top cover removed. The normal impeller printed fine on my X1 carbon. It was the mirrored impeller that caused issues.

I started to suspect room temperature as well. The printer was in a closed off room all night and the graph of an external temperature sensor is pretty much in line with the ugly overhangs. At a certain point the temperature starts to drop and the overhangs gradually start to look better.
I will wait a few days until the temperature starts to drop here so I hope it results in a better print!
Thanks!

I cannot get the impeller to print correctly.
Have tried everything. Printing when the ambient temperature was lower, and even an airconditioned room at 18 degrees.
Slowing down to 50% printing speed on the A1 also does not improve to a perfect result.
Any tips I can try?

I have not. It was a new spool straight from the vacuum packaging.

I bought a dryer and dried it. Indeed, also with a new spool this time, the result is much better. It’s not perfect yet. The front side is now smooth, yet the back (so the actual overhang) is still a bit of a moon landscape. I think next I’m going to install the prusa slicer and see if I can get a decent quality print of the mirrored impeller. Maybe the slicer also makes a difference.
Btw I printed with overhang speed of 30mm/s. That seems to give the best results.

What quality settings are you using in Bambu Slicer?  I would recommend switching the print order to "outer/inner" if you haven't already.  This will fix a lot of those issues.
You can also mess around with "Arachne" wall generator settings, as that can usually improve more detailed overhangs/curves in the slicer.
I would continue to slow down as well.

Did you try the OrcaSlicer and clockwise printing already?

I have been printing other stuff yesterday so I haven’t had time to play with OrcaSlicer yet. I will try tonight.
Thanks for the tips regarding the order of walls. I will also do a test print with that setting later.

Tried switching the order of walls as well as the Arachne wall generator. Unfortunately no real improvements.
I have one pretty decent print (slowing down the overhangs to 30mm/s, but slowing down the entire print to 50%) where only the overhanging side of the fins are a bit like sandpaper, but the top side is looking OK. I’m going to sand that back side a bit and call it good. Next up today will be the Orca Slicer for the mirrored impeller.
I think in general this design can only be printed on the really high end machines. An A1 is just not good enough. Not sure if the design can be changed for easier printing without changing its characteristics.

If you still can’t get the impeller smooth I can print them for you. I believe you live in the Netherlands so sipping will not be a problem. Are you making the EU version?

That is nice of you to offer! I do live in NL (Breda area), so I might take you up on your offer. Thank you.
I tried the Prusa Slicer with the mirrored impeller and the direction reversed. Had to stop the print after two hours because the quality was really bad again. Looking at the design though, is there a reason for the fins to be about 1mm thick on the bottom while being almost 3mm thick on the top? Making the fins thicker might help with stability while printing?

I did not designed the impellor blades myself. It is a 1:1 copy from the original file from pilson guitars. So a lot of people did print it this way. I only made the mirrored version of it 😅.

@Stevenpolak both versions. Up until yesterday I only tried printing the non-mirrored version. Both have problems.
@Makerr-Studio if the offer still stands to print them for me I would like to take you up on that! Let me know what the best way is to get in touch.
Still find it weird that I am having such a hard time printing this. I must be doing something wrong. Or the A1 is just not capable of printing such a difficult part.

Yes it still stand. You can contact me on<EMAIL_ADDRESS>

I am having the same issue. I have tried various settings   Any settings advice?  I have also tried opening my P1S and putting a box fan pointing in it.

I am having the same issue. One side looks better but the overhang part not so much.  I have tried various settings   Any settings advice?  I have also tried opening my P1S and putting a box fan pointing in it.


Unit file for service provider

Issue Description
Create a unit file for the service-provider command. It uses the basic provider configuration.
Related Tickets
https://github.com/cerana/cerana/pull/263

Waiting for merge of the PR for the service-provider. (https://github.com/cerana/cerana/pull/263)

Resolved by @StevenIsaacs in https://github.com/cerana/nixpkgs/commit/7af6d99c00b4febd5d6783ca0a776a990a83399e