Color picker window toggles

Hi,
I was trying to use the color picker for the input box. If you press on input box the color palate will appear but as soon as you click on the tab like advance its just disappearing. Is it a bug or you did it intentionally.
Pleas let me know how can I solve this.
Regards
Zea

I had the same issue which I solved by changing these lines around https://github.com/lauren/pick-a-color/blob/master/src/js/pick-a-color.js#L1001-L1013
            // Prevent blur from not applying color selection
            var menuClicked = false;
            myElements.colorMenu.on(startEvent, function (e) {
                menuClicked = true;
            });

            myElements.thisEl.focus(function () {
                var $thisEl = $(this);
                myColorVars.typedColor = $thisEl.val(); // update with the current
                if (!settings.allowBlank) {
                    $thisEl.val(""); //clear the field on focus
                }
                methods.toggleDropdown(myElements.colorPreviewButton, myElements.ColorMenu);
            }).blur(function (event) {
                if (menuClicked) {
                    menuClicked = false;
                    return false;
                }

Thank you.
Yes it worked for the click function but if you click on tabs (advance, saved) and click outside without changing any value the previous value just disappeared or empty.
Regards
Zea

I just modify this... may be you also meant this but I did'nt get at first glance
myElements.thisEl.focus(function () {
          var $thisEl = $(this);
          myColorVars.typedColor = $thisEl.val(); // update with the current
          if (!settings.allowBlank) {
            $thisEl.val(""); //clear the field on focus
          }
          methods.toggleDropdown(myElements.colorPreviewButton,myElements.ColorMenu);
        }).blur(function (event) {
            var $thisEl = $(this);
            myColorVars.newValue = $thisEl.val(); // on blur, check the field's value
            // if the field is empty, put the original value back in the field
            if (menuClicked) {
                menuClicked = false;
                if (myColorVars.newValue.match(/^\s+$|^$/)) {
                    if (!settings.allowBlank) {
                        $thisEl.val(myColorVars.typedColor);
                    }
                }
                return false;
            }


Player talents return value

When a player has talents, they are returned as an object:
"talents":{"1":"WitchDoctorWidowmakers","4":"WitchDoctorHexedCrawlers","7":"WitchDoctorSpiritofArachyr","10":"WitchDoctorHeroicAbilityRavenousSpirits","13":"GenericTalentIceBlock","16":"WitchDoctorSoulHarvest","20":"WitchDoctorVileInfection"}

When a player doesn't have talents, they are returned as an empty array:
"talents": []

Example replay: https://hotsapi.net/api/v1/replays/7
Shouldn't that be an empty object (or null)?

I still need investigate closer why exactly ReplayParser resets talents here

If you just want the talents, then use the EndOfGameTalentChoices event.
The TalentChosen event allows you to get the time at which the talent was chosen.

Great, thanks.


Fixing additional/cifES and additional/nieES algorithms

Description
This PR will improve additional/cifES and additional/nieES algorithms regarding on some comments found at http://moreovercoder.blogspot.com.es/2013/07/validacion-de-nie-nif-y-cif-con-jquery.html
Will fix:
https://github.com/alfonsomartinde/jquery-validation/issues/1
Thank you!

looks really good to me. could you rebase and squash all the commits into one?

Yep, sure! I'm not quite familiarised with rebasing, sorry about that, but I'll figure out how to do it. Any help will that be very welcome :)

see e.g. https://help.github.com/articles/using-git-rebase/

Not sure if I did it properly...

merged. great job, thx.


Inline mode shifted when adding row

When I am using
selectMode: 'multi',
mode: 'inline'

Here is what I get :

When I create a new row, the columns are shifted to the left and the last column is empty.
Anyone got a solution for this please ?

Is there any fix / workaround available? The issue still persists.

As it turned out, the solution is migrating from ng2-smart-table to its fork https://github.com/dj-fiorex/angular2-smart-table
It's a shame, since there's a pull request with a fix available (https://github.com/akveo/ng2-smart-table/pull/427), however it has never been merged.

@KostyaDanovsky @elupanov @malashkevich @lugovsky @SashaSkywalker @greenfrvr @Tibing Please guys can you speed up this pull on the main branch, it is a change already implemented and working. Thanks for your attention

@toboko this PR is quite old and has conflicts with the main branch.
It would be nice if you could take it as base, and fix the conflicts.


Correct typos in variable names

Fixed the 2 instances of "sinlge" in the terraform variable names.

Also, after I fixed that locally, the deployment failed due to the provider version was too old. It worked once I changed it to this:
version  = "~> 1.6.0"


Anopheles pca() and plot_njt() functions should have sensible defaults for min_minor_ac and max_missing_an

Previously (in version 7) we set defaults for these parameters:
    def pca(
        self,
        region,
        n_snps,
        thin_offset=0,
        sample_sets=None,
        sample_query=None,
        site_mask="default",
        min_minor_ac=2,
        max_missing_an=0,
        n_components=20,
    ):

When some refactoring happened internally, we also changed these default values (unintentionally?) to None. This means that PCAs being run with default parameters may be using lots of uninformative SNPs (non-segregating and singletons) and also SNPs with lots of missingness, which is not ideal.
Propose to set these parameters back to their default values in the pca() function as of version 7.

We should also set the same defaults for the plot_njt() function.

cc @leehart

Investigating test failures:
FAILED tests/anoph/test_pca.py::test_pca_plotting[ag3_sim] - ValueError: Not enough SNPs.
FAILED tests/anoph/test_pca.py::test_pca_plotting[af1_sim] - ValueError: Not enough SNPs.

For some reason biallelic_snp_calls() isn't getting many variants, e.g.
test_pca n_snps_available 19262
test_pca n_snps 17593

biallelic_snp_calls ds_out.sizes["variants"] 333
biallelic_snp_calls n_snps 17593

🤔

Ah, I suspect we might need to apply the defaults to these functions too:

biallelic_snp_calls()
biallelic_diplotypes()
biallelic_diplotype_pairwise_distances()

Ah, I suspect we might need to apply the defaults to these functions too:

biallelic_snp_calls()
biallelic_diplotypes()
biallelic_diplotype_pairwise_distances()

FWIW I would leave default values as None for these functions. These are more general functions to obtain SNP data. The pca() and plot_njt() are more specific functions where it matters more to have low missingness and segregating variation.

For some reason biallelic_snp_calls() isn't getting many variants, e.g.
test_pca n_snps_available 19262
test_pca n_snps 17593

biallelic_snp_calls ds_out.sizes["variants"] 333
biallelic_snp_calls n_snps 17593

🤔

Requiring max_missing_an=0 is actually quite strict, it means you want SNPs where there is absolutely no missingness. For some datasets there may not be that many SNPs that satisfy it.


idris: unbreak

Description of changes

Applied the upstream patch to relax the requirement of libffi. https://github.com/idris-lang/Idris-dev/pull/4920
It builds now. REPL and compiler work for me.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thanks! Cherry-picked as b66a46f781cf8f1b20a76c4a498ef8fa84a3f4bb.


[falcon judge panic] nil pointer dereference

module_name: falcon-judge
version: 2.0.2
panic log:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x7568c9]
goroutine 488390973 [running]:
github.com/open-falcon/falcon-plus/modules/judge/store.(*SafeLinkedList).HistoryData(0xc443fbd240, 0xa, 0x81c300, 0xc487850401, 0xc4d92e5230, 0xc4c08ad688)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/linkedlist.go:63 +0x1c9
github.com/open-falcon/falcon-plus/modules/judge/store.AllFunction.Compute(0x0, 0x0, 0xa, 0xc46e08d70c, 0x1, 0x4056800000000000, 0xc443fbd240, 0x411618, 0xc4d92e5230, 0x839580, ...)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/func.go:116 +0x42
github.com/open-falcon/falcon-plus/modules/judge/store.(*AllFunction).Compute(0xc4d92e5230, 0xc443fbd240, 0xc46e08d70c, 0x1, 0x4056800000000000, 0xa1b200, 0xc4d92e5230)
:10 +0x66
github.com/open-falcon/falcon-plus/modules/judge/store.judgeItemWithStrategy(0xc443fbd240, 0x15e, 0xc46e08d6d4, 0xc, 0xc4c8fe8090, 0xc46e08d700, 0x8, 0xc46e08d70c, 0x1, 0x4056800000000000, ...)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/judge.go:54 +0x205
github.com/open-falcon/falcon-plus/modules/judge/store.CheckStrategy(0xc443fbd240, 0xc4950413b0, 0x5cd4f23f)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/judge.go:43 +0x3cc
github.com/open-falcon/falcon-plus/modules/judge/store.Judge(0xc443fbd240, 0xc4950413b0, 0x5cd4f23f)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/judge.go:15 +0x3f
github.com/open-falcon/falcon-plus/modules/judge/store.(*JudgeItemMap).PushFrontAndMaintain(0xc42016fb20, 0xc48e777360, 0x20, 0xc4950413b0, 0xb, 0x5cd4f23f)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/store/history.go:79 +0xa8
github.com/open-falcon/falcon-plus/modules/judge/rpc.(*Judge).Send(0xc42012a060, 0xc437a70000, 0xc8, 0xc8, 0xc4f5442d90, 0x0, 0x0)
/GO/builds/github/src/github.com/open-falcon/falcon-plus/modules/judge/rpc/receiver.go:22 +0x10f
reflect.Value.call(0xc42007c2a0, 0xc42000e050, 0x13, 0x852f45, 0x4, 0xc4c08adf20, 0x3, 0x3, 0x0, 0xa1b840, ...)
/GO/builds/go/src/reflect/value.go:434 +0x91f
reflect.Value.Call(0xc42007c2a0, 0xc42000e050, 0x13, 0xc48956f720, 0x3, 0x3, 0xc48956f718, 0x43e421, 0xc48faa0680)
/GO/builds/go/src/reflect/value.go:302 +0xa4
net/rpc.(*service).call(0xc420122180, 0xc420122080, 0xc4512d7750, 0xc420082300, 0xc42a968ac0, 0x7b3c40, 0xc45b4ff3a0, 0x197, 0x7d72a0, 0xc4f5442d90, ...)
/GO/builds/go/src/net/rpc/server.go:387 +0x144
created by net/rpc.(*Server).ServeCodec
/GO/builds/go/src/net/rpc/server.go:481 +0x404

当配置了一个counter类型指标的报警，最大报警次数超过remain限制的时候，judge会报空指针，进程crush


Review of the french translation so far

Also fixes a small typo in the contributing guide.

thanks domi!


chore: update deps

Same as #2683, but without updating fresh

Same as https://github.com/denoland/dotland/pull/2683, but without updating fresh

This sounds very concerning.. I'll look into<EMAIL_ADDRESS>in details tomorrow


DOC: Unused order argument in factorize

def factorize(values, sort=False, order=None, na_sentinel=-1):
    """
    Encode input values as an enumerated type or categorical variable

    Parameters
    ----------
    values : ndarray (1-d)
        Sequence
    sort : boolean, default False
        Sort by values
    order :
    na_sentinel: int, default -1
        Value to mark "not found"

    Returns
    -------
    labels : the indexer to the original array
    uniques : the unique values

    note: an array of Periods will ignore sort as it returns an always sorted PeriodIndex
    """

But it isn't used anywhere. Technically this is an API change, if people aren't using kwargs. So I'll add it to the deprecation list.

@wesm what was the original reason for the order kw? (as about to remove it as we deprecated a while back)


Owen/rust generator with static mem alloc

Implemented the example generator using rust with an optimized size of 23K.
Fix: https://github.com/bitseed/bitseed/issues/13

Nice Job!
Today, I also gave it a try, using the lighter-weight cbor library tinycbor, and separately provided implementation code for memory allocation. The final compiled wasm file size is around 8KB.
The code is written in C.
Usually, for code with the same functionality, files compiled from Rust are 1 to 3 times larger than those compiled from C.


Function Creation Action Refinement

There are a couple of issues here:

Different action names registered for the 'P' hotkey
'P' hotkey does not work in graph view
If you're in an existing function (say thumb2) and hit 'p', an ARM function is created.

Fixed in 3.0.3312-dev.


which flow is the node 'chart tag' for?

I would like to know the flow library that has the node 'chart tag'.

I would like to know the flow library that has the node 'chart tag' too.

The chart tag node doesn't have a node module associated with it. The .js and .html files that make up the node get installed in /usr/lib/node_modules/node-red/nodes/core/core by the node-red-experience package.


How to fetch data from the store into my container?

I don't understand how the container works.. All I'm trying to do is fetch some data from my store (which fetches its data from a rest call).
Watching this store in your example:
    //https://github.com/martyjs/marty-chat-example/blob/master/app/stores/roomsStore.js
getAll: function () {
    return this.fetch({
      id: 'all-rooms',
      locally: function () {
       //bla bla
      },
      remotely: function () {
        //bla bla
      }
    });
},

makes me wonder why do we need 2 functions, 1 remotely and 1 locally? Do I need to implement both?
This is my store called SessionStore.
    var {API_ENDPOINTS, SESSION_CONSTANTS} = require('../constants/Constants');
    var Marty = require('marty');
    var rest = require('superagent');

var SessionStore = Marty.createStore({
    id: 'SessionStore',
    handlers: {
        login: SESSION_CONSTANTS.LOGIN_REQUEST
    },
    getInitialState: function () {
        return {currentUser:''};
    },
    isLoggedIn: function () {
        return (this.state.currentUser!='');
    },
    login: function(username, password) {

        request.post(API_ENDPOINTS.LOGIN)
            .send({ identifier: username, password: password })
            .set('Accept', 'application/json')
            .end(function(error, res){
                //console.log("Error: "+error+ "responce: "+JSON.stringify(res));
                if(error) return false; //do something in case of an error?
                if (res) {
                    var responseParsed = res.body;
                    if(responseParsed.success){
                    //ALL GOOD!
	                        return true;                      //Is this a correct way to return data to my container?
	                    }else{
 	                        return false;                     //Is this a correct way to return data to my container?
	                    }
                }
            });
    },
});

Is my way of returning results correct? Also I noticed I don't have to use superagent since you provide rest calls in marty through state sources, but can a store also be a state store in order to call a method like this.post() ?
Thank you...
Bah, thats confusing...

For the first question, let's suppose you have a container like so:
export default Marty.createContainer(MyComponent, {
    listenTo: ['myExampleStore'],
    fetch: {
        values() {
            return this.app.myExampleStore.getValues();
        }
    }
}

What this is saying is that MyComponent would like to have whatever myExampleStore returns from getValues available as this.props.values.  Then on your store, you want something like:
export default class MyExampleStore extends Marty.Store {
    getValues() {
        return this.fetch({
            id: 'values',
            locally: () => this.state.values,
            remotely: () => this.app.myExampleQueries.getValues()
        });
    }
}

What happens is that every time your component is rendered, it'll hit getValues() on the store.  Each time, fetch will hit the locally handler first, to see if the store already contains that data.  If it doesn't (which is detected by locally returning undefined), it will then hit the remotely handler which is meant to trigger a query to, eventually, hit a state source.  When remotely finishes, it will re-run locally, which should contain the value (if remotely worked), or will return undefined (if your state source couldn't get the value either).
So yes, you normally need to implement both, but locally just returns data from the store's state, and remotely just triggers a query.  Neither one is meant to be a big function.
Finally, not entirely sure what you're trying to do with the login method, but that's not going to do anything useful.  Your login request should probably fire some sort of LOGIN_SUCCESSFUL action on success, which your SessionStore listens to with some sort of receiveSession handler, which updates the store's state.  Your container should get the state via some sort of getSession method.

Thank you...
You totally and absolutely filled the gaps for me..
I plan to fire a Login_successfull action indeed.
If only the above explanation could be copied and pasted into the docs. Did I somehow miss it? You really helped me understand how it works, I really really appreciate it.
AGAIN Thank you.!!
Now could you or someone else be kind enough to answer a few more questions:

How is a query identical to an action creator when in your Query docs example you clearly run code and do stuff. (more than what an action creator would do - which is to dispatch an event).

Is there a reason I should prefer to use the built in (Marty) session storage for keeping data like the user email, token etc, or is it ok to just keep those in my SessionStore as I'm doing now.

Can a store be an http state source as well? (So that I get rid of external restful libraries like superagent to access my backend api)

Actually it is exactly as said in the link you provided -> you use queries for reads and action creators for writes. they both eventually dispatch an event, so for example: if u wish to query for user(id) you would use queries, but if u want to update user(id) you would use the action creator.

so in the example above:
export default class MyExampleStore extends Marty.Store {
    getUser(id) {
        return this.fetch({
            id: id,
            locally: () => this.state.user[id],
            remotely: () => this.app.userQueries.getUser(id)
        });
    }
}

getUser = your query
class UserQueries extends Marty.Queries {
  getUser(id) {
    this.dispatch(UserConstants.RECEIVE_USER_STARTING, id);
    this.app.userAPI.getUser(id).then(
      res => {
        if (res.status === 200) {
          this.dispatch(UserConstants.RECEIVE_USER, res.body, id);
        } else {
          this.dispatch(UserConstants.RECEIVE_USER_FAILED, id);
        }
      },
      err => this.dispatch(UserConstants.RECEIVE_USER_FAILED, id, err)
    );
  }
}

and in your store:
constructor(options) {
  super(options);
  this.state = {};
  this.handlers = {
    login: UserConstants.LOGIN,
    getUserStarting: UserConstants.RECEIVE_USER_STARTING,
    getUserSuccess: UserConstants.RECEIVE_USER_DONE,
    getUserFailed: UserConstants.RECEIVE_USER_FAILED,
    updateUserStarting: UserConstants.UPDATE_USER_STARTING,
    updateUserSucces:UserConstants.UPDATE_USER_DONE
    updateUserFailed: UserConstants.UPDATE_USER_FAILED
  }
}

getUserStarting() {
//whatever
}

getUserSuccess(user, id) {
 this.state.user[id] = user;
}

getUserFailed() {
//whatever
}

update user:
class UserActionCreator extends Marty.ActionCreators {
  updateUser(id) {
    this.dispatch(UserConstants.UPDATE_USER_STARTING, id);

    this.app.userAPI.updateUser(id).then(res => {
      this.dispatch(UserConstants.UPDATE_USER_DONE, user.cid, res.body);
    }).catch(err => {
      this.dispatch(UserConstants.UPDATE_USER_FAILED, id, err.body);
    });
  }
}

I don't know how u are doing it now, but for simple get and set, what marty provided should be enough.
"Can a store be an http state source as well? (So that I get rid of external restful libraries like superagent to access my backend api)"

I don't understand the question, your stores is where the state lives, the sources (if remotely) u query, so your store should not be a http state source, i don't see how it could. your queries, and actions are the way to trigger communication with your sources. Your store is where the state is set, which will update the components that are making use of it. But if u are using external restfull libraries, u shouldnt have to, depending on the complexity of what u are doing, but with marty http state source u can do CRUD.

Ok my question was a bit weird, but nevermind, I'll be using marty sessions anyway.

I take it that a Marty store, can not be an http state source itself. By that I mean, I can not run get,post requests from within a marty store, I have to create another class, a state source class to do so because a store cannot also be a state source.
I've decided the answers for myself on the above 2 questions.

but my main question was the 3rd:
3) Why do you run code and do stuff in action creators and queries. By that I mean, why have CRUD calls within action creators and queries...
I thought the sole purpose of an action creator or a query (in Flux) was to "JUST  dispatch an event, in order for an action to begin" rather than "just do an action and dispatch its result"? I see you do follow second

Ignoring the query/action creator distinction for now, which is more for organization or whatever, it is in fact correct to initiate REST calls from the action creators - see e.g. https://github.com/facebook/flux/blob/master/examples/flux-chat/js/actions/ChatMessageActionCreators.js. As for why action creators... well, where else would you put them?

Ok, thanks @taion, I didn't know that. I thought perhaps you could put that logic inside store methods.


fix issue #63

Take a look

no. something like this button prototype

Okay, got it.

Check this one.

add some delay to change the background wheel hovering


Moved required dependencies to dependencies

When installing chakra-dayzed-datepicker, @chakra-ui/react, date-fns and dayzed are required.
You could install them seperately, but thats an additonal step for the user. It also clutters the users package.json unnecessarily.
In addition, I've had issues with depcheck (https://www.npmjs.com/package/depcheck) complaining I have unused deps. (Due to date-fns and dayzed not being used outside chakra-dayzed-datepicker in my program)
It would be easier if these are listed as direct dependencies, and that is the purpose of this PR.

Make sense, except I wouldn't put the charka into required dev since ppl always have chakra lib first.
I also don't want to install the entire chakra by install this package itself.
I will put the chakra back for you if you don't want to do it.

Sounds fair 👍


Fix TF naming reference in Transform module

Recent merge introduced a misnamed reference, this fixes it
(Also amended readme formatting)

/test

/test

/test

/test

/test

/test

/test

Closing and re-opening to fix naming issue (need new prRefId)

make /destroy-env

/destroy-env


missing 'Floor plans' option

Hello,
I can't find the 'Floor plans' option in the Settings -> Microsoft Search
Am I missing something in configuration? I'm global admin...

Regards,
Marek

Floor plans is in the process of completing rollout to all customers; it is not available to everyone yet. The rollout will complete presently and you should see it at that time.


Add a channel

Could you please add this channel : https://www.youtube.com/channel/UCq22aK0t0mrOEq676Be4ezw

Hey @atabti, I did not find any live video on the link you gave me.


Fix #1348: Rework the Record Encryption documentation describing the role of the administrator

Type of change
Select the type of your PR

Bugfix
Documentation

Description
The intent is to try to convey that the fact that something outside the system (an admin) needs to be responsible for creating KEKs that will be used by Record Encryption without dictating an organisational model or an account called 'kroxylicious-admin'.
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[x] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

@PaulRMellor would you be able to review these changes please?


Nitro project getting gradually slower and slower as the DB gets bigger to a point where it times out.

Description
I have a local and production build of a project and I have been regularly pulling the production DB down onto my local version. However, with each time it makes my nitro platform slower and slower. It's to the point now where I am getting 504 errors when I log into the nitro CMS.
Please see the logs below to note that there is nothing out of the ordinary going on.
web.log
The database that finally caused time outs was only 16.5mb, so I'd not have expected this to be big enough to cause time outs, however, I have increased the max_execution_time and increased the resources that docker can utilise and I'm getting the same timeout issues.
Additional info
I understand this may be a setup/dev error issue, but it's something I've struggled to find advice on resolving, so even if it is an issue that is easily resolved, this could be highlight a requirement in the docs.

Nitro version: 2.0.8
Docker version: 4.6.1

Hi, we are closing this issue as we have decided to retire Nitro, so no additional work will occur on this project. You can read the official blog post here https://craftcms.com/blog/retiring-craft-nitro. We appreciate everyones feedback and involvement and we look forward to refocusing our efforts on Cloud!
If you're looking for a new local development environment, we recommend DDEV and have a knowledge base article to help you with the transition: https://craftcms.com/knowledge-base/migrating-from-craft-nitro-to-ddev.


gd: 2.3.0 -> 2.3.3

Motivation for this change
This partially resolves https://nvd.nist.gov/vuln/detail/CVE-2021-40812. Fixes it for BMP and WebP, leaves GIF unresolved. That will apparently take a significantly larger fix, possibly API-breaking.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Oh looks like I'll need to rebase this to staging.

Looks good to me too!

Fails build at least for php80Extensions.gd:
/build/php-8.0.10/ext/gd/gd.c: In function 'zif_imageflip':
/build/php-8.0.10/ext/gd/gd.c:3529:8: error: 'GD_FLIP_VERTICAL' undeclared (first use in this function)
 3529 |   case GD_FLIP_VERTICAL:
      |        ^~~~~~~~~~~~~~~~
/build/php-8.0.10/ext/gd/gd.c:3533:8: error: 'GD_FLIP_HORIZONTAL' undeclared (first use in this function)
 3533 |   case GD_FLIP_HORIZONTAL:
      |        ^~~~~~~~~~~~~~~~~~
/build/php-8.0.10/ext/gd/gd.c:3537:8: error: 'GD_FLIP_BOTH' undeclared (first use in this function)
 3537 |   case GD_FLIP_BOTH:
      |        ^~~~~~~~~~~~

As if header inclusion is missing.

https://aur.archlinux.org/packages/php74-gd/#comment-827056

Downgrade 'gd' to 2.3.2. In 2.3.3 some macros have been removed and older versions of PHP will not build anymore.
There are details https://github.com/libgd/libgd/commit/bdc281eadb1d58d5c0c7bbc1125ee4674256df08

I should perhaps revert the staging-21.05 backport before it hits release.
I might be able to apply the fix as a patch to 2.3.2.


Limit the amount of virtual memory used by uchiwa process

I added a new MAX_VIRTUAL_MEMORY variable with an empty default value to avoid any change in the current installations.
This works because if you run "ulimit -Sv" just return the current value, that by default is unlimited.
koe@vm01:~# ulimit -Sv && echo $?
unlimited
0

Ping @palourde - can you look at this and let us know if you think it's sane?

This needs to be redone against https://github.com/sensu/uchiwa/blob/master/build/assets/etc/init.d/uchiwa


[BUG] Kubectl Error - Waited for ... due to client-side throttling, not priority and fairness, request:..

Environmental Info:
Node(s) CPU architecture, OS, and Version: Dell PowerEdge XR11 (32Core, 128GB RAM, 2 x 1.5TB SSD)

Cluster Configuration: I was able to install only first node and Kubectl was showing those errors

Describe the bug:

UI is not responsive and kubectl gets error messages
see Error messages examples:

Steps To Reproduce:

Installed RKE2: harvester-v0.3.0-amd64.iso
Testing Harvester 030 - SUSE Alliances - Installation Screenshots - Draft 3.pdf

Expected behavior:

Ability to use Bond0
no Kubectl errors

Actual behavior:

Kubectl error messages and UI performance makes it difficult to work

Additional context / logs:

kubectl-debug.log
rke2-server.log
containerd.log
Environment:

Harvester ISO version: v1.0.0-rc1
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
backport https://github.com/rancher/rke2/issues/2119

FYI: It is caused by the read-only filesystem on the root disk.
https://github.com/rancher/rke2/issues/2119#issuecomment-984627066
Use kubectl -v3 get pod to get the full debug message.

The main reason is that if you switch to Shell by pressing F12, you won't have the $HOME environment variable.
Lacking $HOME would cause kubectl to use the current working directory to create the .kube/cache folder, which is /, and it would just fail because / is a read-only file system.
There are two workarounds:

Switch to Shell by switching virtual terminal (Press Ctrl-Alt-F2). Login with rancher/<Your password>
Add $HOME environment variable after you switched to Shell by pressing F12: export HOME=/root

Verified fixed on master-75cc3ced-head.(03/11) Close this issue.
Result
Can switch to shell console directly with root by pressing F12 for

Run kubectl command with root privilege without error
Response time and smooth experience

Test Information

Test Environment: 3 nodes harvester on provo bare machine
Harvester version: master-75cc3ced-head.(03/11)

Verify Steps

PXE boot installation
Access PXE boot server
Edit the config-create-cluster-01.yaml and config-join-cluster-01.yaml file
Set tty: tty1
PXE install harvester node
Wait for installation complete, display Ready on console terminal
Press F12
Run kubectl get nodes
Run kubectl get all -A


[$100] Job Oppurtunity at Ninjas Code for Full Stack Developer

About the position
At Ninjas Code we have an opening for Full Stack Developer. To be qualified for this position you need to match below criteria's:
1. Must Star the repo
2. Submit PR for this issue
3. Open to on-site full time role
If your PR is selected you will be rewarded $100 USD and you will be interviewed for our opening.
For any queries you can contact:
Email<EMAIL_ADDRESS>Phone WhatsApp: +92<PHONE_NUMBER>
Deadline for task Submission: 10th May 2024 4:00 PM GMT +5
Please note PR's after the deadline won't be accepted
Task Details
1. Implementation of tech stack change:
In current repo folder enatega-multivendor-web we have the following tech stack implemented:
a. React
b. Material UI
c. Apollo Client
d. JavaScript
This sub task requires changing the tech stack to following tech stack:
a. NextJS
b. Tailwind with ShadeCDN
c. Storybooks with e2e and unit testing
d. Typescript
Please note that you don't need to implement the whole project just one screen with good practices that is scalable would be good enough.
That means you need to use the above mentioned technologies for task 2.
2. Implementation of Design of New Home Page:
Please review following images below:

Current design of the system to view the deployed version of the screen click here.

Design that needs to be implemented for the new revamp of the version

Exact pixel perfect is not required thus you are given the design implementation in .png format. Important part is how scalable you make the solution. Functionalities that needs to work.
1- Getting current location of user
2- Displaying user location in text area
3- Display user location in dropdown
4- Clicking Find Restaurant should query the endpoint that is already deployed in the final version with latitude and longitude
5- Clicking Find Restaurants should display restaurants in Grid Format with respect to users location

Dear Candidates the deadline has been extended till 15th May 4:00 PM 2024 +5 GMT

Appreciate that.

where to upload the second task

i completed the task-2
https://task2-eosin.vercel.app/
this is the linkof the task

@OMARxKHALID you need to submit PR

SIR @SharanGoharKhan the task is done and also i submitted the PR

Alright the @OMARxKHALID the team will review it

Deadline has been extended till 30th May this is the final extension.
Instead of submitting a PR over here since we do not want other candidates to copy your test please fork the repo and after the deadline add<EMAIL_ADDRESS>as collaborator.

got it sir
should i delete the previously uploaded PR ?
On Wed, May 15, 2024 at 3:19 PM Sharan @.***> wrote:

Deadline has been extended till 30th May this is the final extension.
Instead of submitting a PR over here since we do not want other candidates
to copy your test please fork the repo and after the deadline add
@.*** as collaborator.
—
Reply to this email directly, view it on GitHub
https://github.com/ninjas-code-official/food-delivery-multivendor/issues/494#issuecomment-2112126112,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BC2NF4PQOWXZ2FIVLJYQNLTZCMZBJAVCNFSM6AAAAABGYXQ3OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGEZDMMJRGI
.
You are receiving this because you were mentioned.Message ID:
<ninjas-code-official/food-delivery-multivendor/issues/494/2112126112@
github.com>

Yes @OMARxKHALID

Ok, thanks Sir.
On Wed, May 15, 2024 at 3:33 PM Sharan @.***> wrote:

Yes @OMARxKHALID https://github.com/OMARxKHALID
—
Reply to this email directly, view it on GitHub
https://github.com/ninjas-code-official/food-delivery-multivendor/issues/494#issuecomment-2112151069,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BC2NF4NEJVOJZENODB7QJ7LZCM2V5AVCNFSM6AAAAABGYXQ3OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGE2TCMBWHE
.
You are receiving this because you were mentioned.Message ID:
<ninjas-code-official/food-delivery-multivendor/issues/494/2112151069@
github.com>

Found out the comp today let's see how long it takes me

Dear all thank you for your submissions, we are waiting for few candidates to submit their test till tomorrow and then we will announce a winner.

Dear @SharanGoharKhan
I hope this message finds you well. I wanted to follow up regarding the announcement of the winner for the submissions. Could you kindly provide an update on the progress? Your response would be greatly appreciated.
Thank you,
Muhammad Umar

Hello @OMARxKHALID competition winner has been announced and internal prize distribution was performed today. Unfortunately you did not make to the top submissions however our HR might still contact you for further opportunities.

I am closing this competition the winner as mentioned above the winner was given the prize in a short company ceremony, for reference here is the link to its short video here.
Due to overwhelming responses we are going to conduct more competitions like this in future so stay tuned.

Hi there, is it necessary to integrate the Google Maps API? as shown in the above screenshot? Because their API is paid i think.

Resolved

Task Submission:
Title:
Implemented New Homepage with Next.js 14+, Tailwind CSS, Prime React, Cypress, and TypeScript.
Repository Invite Link:
https://github.com/yahyanoor000123/Restaurant-Finder-Enatega/invitations
Thank you.
Regards,
Yahya Noor


feat(proxy-wasm) allow setting ":status" header

Since #484, we now have an easy way to implement support for setting the ":status" pseudo-header.

Before merging this (I have not made any changes yet locally), I think we should add context checks for set_response_header to better capture which phases the function can be called from (and :status be set from, particularly). These context checks go in t/03-proxy_wasm/hfuncs/contexts.

I think we should add context checks for set_response_header to better capture which phases the function can be called from (and :status be set from, particularly).

@thibaultcha How hard should the context checks be? In the current code, headers being set in the wrong context are soft errors, and bodies being set in the wrong context are hard errors.
For headers, functions such as ngx_proxy_wasm_hfuncs_replace_header_map_value and ngx_proxy_wasm_hfuncs_set_header_map_pairs return OK and just log an error when attempting to set response header when the headers are already sent.
For bodies, in ngx_proxy_wasm_hfuncs_set_buffer, attempting to set the response body or request body from the wrong place trigger a trap.
To clarify, by "add context checks" are you suggesting we turn the header checks mentioned above into hard errors?

@thibaultcha is this second commit 6014ff0 what you had in mind?

@thibaultcha is this second commit 6014ff0 what you had in mind?

Yes, strengthen our context checks and formalize the behavior in each unsupported phase. Regarding the tests themselves, setting a response header in the request phases will not have any effect so I think we should catch usage there is what I meant, cutting some decisions where the behavior is "strange". In other words, solidify the response header behavior especially if we introduce :status, which may work when used from the request phases(?). As we add more unknowns into the response headers, I think we should cover all expected behaviors and make the decisions wherever we have margin.

@thibaultcha The added context checks and tests should be ready for review now!

Thanks! The code etc all looks good; I'll just reorganize the tests to try not to duplicate test cases between hfuncs/ and hfuncs/contexts (also the contexts tests are supposed to be non-functional - only test the return code - but maybe they should be to avoid confusion, I'll compare with the other suites).

Thanks! I did notice some duplication there, but when in doubt I added stuff to both, just in case. The main difference I could spot is that hfuncs/contexts tests are using context-checks which is testing at the extern "C" low-level (e.g proxy_set_buffer_bytes), and the ones in hfuncs/ are using proxy-wasm-rust-sdk (e.g. ctx.set_http_response_headers).


FluentAvalonia NavigationView

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: rocksdanister:x: SplitwirezYou have signed the CLA already but the status is still pending? Let us recheck it.

...aaaand I accidentally opened the PR to the main branch instead of the avalonia branch. Ugh...now what?

This is no longer required since I made a custom control instead, thanks for the help.


Player can hide in enemy area after taking damage from enemy forever

This issue is not an extension of #136 as new issues will get their own separate GitHub issues as requested by Policiu. Also from now on I am going to put a lot more effort into making new issues even if they are self explanatory. I will try to be clear and concise as possible.

Issue
Damage is only dealt once when the player enters the enemy area. The player has to leave the enemy area for the damage detection to to be active again.
Steps to Reproduce

Get hit by enemy
Immediately after getting hit by enemy go inside the enemies area
Notice how you can stay here forever

Relevant Scripts
https://github.com/Valks-Games/sankari/blob/main/Scripts/Entities/Enemy/BasicEnemy.cs
https://github.com/Valks-Games/sankari/blob/main/Scripts/Entities/Player/Player.cs
Discussion on Godot Discord
Link to Godot Discord
Link to Message

I'm thinking Entity should have a new variable called ImmunityFrames or ImmunityMs (short for immunity milliseconds). The immunity timer will start when the player (or any entity) enters a enemy / hurt zone. Once the immunity timer is up, somehow the code will check if the entity is still within that hurt zone and if so damage that entity again. If the entity leaves the zone via the OnExitArea signal then perhaps a bool will be updated saying "no longer in hurt zone".


Benchmark initial sync

Motivation
Track current initial sync speed in CI before applying https://github.com/ChainSafe/lodestar/pull/3989
Description

Add range sync perf test (verify + import 31 blocks)

Blocked by https://github.com/ChainSafe/lodestar/issues/4017

Circumvented https://github.com/ChainSafe/lodestar/issues/4017 by uploading the tests files to a Github repo's release page. This is a temporary solution to unstuck this PR.


Refreh timer issue

I think I have a problem with the refresh timer. Due to the constant logins, it looks like Husqvarna always logs me out in the original app or IFTT. If this is related, only the manufacturer can adjust this, of course.
2.
In the Homebridge UI Config for the plugin, I can't set the Auto Refresh to deactivated. Only a numerical value can be set.

Hi,
Indeed, the plugin connection involves disconnection from the app, can't do anything about that.
If you want to disable the refresh timer, remove the option from the config . I did not check but setting it to 0 should also work as far as I remember


[WIP] Upgrade jQuery to v3

Upgrades jQuery to version 3.2.1. This involves updating some third party modules that break under the update.
There are some big fixes that need to be made on top of this.
In the stream popover, the color selector doesn't appear. (I updated spectrum, which fixed jQuery explosions, but resulted in this)
The server_events system seems to be broken at the core.

Automated message from Dropbox CLA bot
@cory2067, it looks like you've already signed the Dropbox CLA. Thanks!

I suspect the spectrum issues could be related to the fact that we've patched spectrum.js:
git log -p static/third/spectrum/
It may be that the options we added exist in the newer Spectrum upstream, or it may not, but we should investigate :).  I think we also have patched filedrop which we're probably using in some way.
So, this is great, in that we've determined that we definitely need to upgrade those 2 libraries.
Since we want to do relatively small incremental merges that someone can test, I think strategically, the way we should go about the jQuery upgrade is:

Figure out how to upgrade spectrum (with fixed jquery) without breaking anything.  Or replace it if there's a better library we should be using in 2017?
Do the same for filedrop.
Merge those first 2 changesets.
Come back to trying to upgrade JQuery.

Does that make sense @cory2067?  It might make sense to do the spectrum/filedrop upgrades on their own PRs and then come back to rebasing this, to avoid extra effort managing things.

Sure, I'll start with those module upgrades.

Quick question: I've made the appropriate updates in our own code, but is it worth modifying the files in static/third that make use of deprecated functions?

Ok, we're almost done here. One more thing is that the jQuery mousewheel plugin hasn't been updated in a long time, and even the most recent version is not compatible with jQuery 3. Will need to find a way around this.

Ok, now I think this should be ready. I've searched the update doc and tested the site features, and it seems to check out.

@cory2067 looks like the tests are failing?

Yeah, casper isn't happy. I'm kind of hoping #5670 will fix it.

I rebased this, added a few changes to the removeAttr migration, and merged this, Thanks @cory2067, and sorry for the slow review :).


Allow plugins to supply an optional list of event_ids when adding hooks

Plugins should be able to supply a list of event_ids when adding hooks (probably only useful for dynamically adding hooks as described in #40) such as "m.reaction".
As such, plugins that only track one specific event_id at a time would not need to check for event_id when their respective method is being called.

closed by https://github.com/alturiak/nio-smith/commit/3d13c79d08ec50ce138109eee0463cf96fec9b0b

closed by https://github.com/alturiak/nio-smith/commit/3d13c79d08ec50ce138109eee0463cf96fec9b0b


Match Ratings: User Upvotes

Goal
If the match is an intent-based match and the current user is seeking an intent, allow the current users to rate the other user(s) who are giving that intent with an upvote if they were helpful and save this information so the matching pipeline can consider it when ranking matches.
Definition of Done

The feature only triggers in intent-based matches where the current user is a seeking an intent.
The user is able to upvote a user in the app.
When the user submits their upvote it is saved to the correct location in the database.
The saved data contains the fields that the offline pipeline expects.

Requirements clarifications:

If chat.metadata.generator is one of "rareIntentsGenerator" or "similarIntentsGenerator", show this feature.
Otherwise, show a message that says "User upvotes are not available for this match."
Do not show a user upvote option for the current user.
Read the intents from chat.metadata.rareIntents or chat.metadata.matchingIntents depending on the match generator.
More information about the match metadata in its offline schema.
You can find the thumbs up icon in the font awesome library.
When a user hovers over the the upvote icon, it should change color. Use var(--color-theme-accent).
You do not need to show whether the user has been upvoted before. That will be a stretch goal.


nixos/zfs: only enable trim if zfs is enabled

Also don't fail the service if there are no pools yet.
This might happen on installation ISOs.
See also: https://github.com/NixOS/nixpkgs/pull/69672#issuecomment-538793932
cc @delroth
This has been not tested yet.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Note that this makes the logic for zpool-trim different than the one implemented for the other ZFS services in that file. For example, enableZfs is defined to be enabled if inuse || enableAutoSnapshots || enableAutoScrub, without taking zpool-trim into account. IMHO enableAutoSnapshots and enableAutoScrub should be removed from the enableZfs boolean, but I don't have a clear understanding of the consequences or how much it would break.

The Autosnapshot/autoscrub services are now only enabled if zfs is somehow used in the system.


c++14 ?

@codebot could you give some input here ? I noticed that this branch was tested along all cpp14 branches but has never been merged. Feel free to close this PR if the merge has been postponed/discarded on purpose

ROS 2 already uses a forked branch named ros2. So ROS 1 isn't relevant in this case.
But Travis CI is failing for this.

I think the only repository that doesn't have a dedicated ros2 branch currently is console_bridge. I think that every repo having a dedicated ros2 branch can be updated along the rest of the ros2 code.
Yes travis is failing on the new flag. AFAIK travis has been failing for a few PRs already. So I'm wondering if the merge policy for the ros2 branch should be:

passing both travis/appveyor and ros2 buildfarm
ros2 buildfarm is enough for the ros2 branch

Since Travis uses Trusty it doesn't seem to support -std=c++14. I don't the argument that the CI has failed before is reasonable. So either we need to modify the Travis or not use C++14.
So the first question imo would be why does this package have to use it in the first place? All the code in this package compiles fine with C++11. And the headers don't even require that afaik.

yes there is no use of any c++14 feature in this package yet. I think that the only repository using some c++14 is examples for now.
I thought we updated all packages for consistency rather than a case by case approach where we convert only if and when needed. If the decision is to update everything in the ros2 org at once but update other packages only when necessary I'm totally fine with it. In the case of ROS1 packages that will have the advantage of keeping the diff short and readable if we decide to backport some changes.
I just didn't know if there has been any discussion on that matter or if this branch was just forgotten along the way so I wanted to raise the question.

The fact that it has diverged is just because we didn't take the time to carefully consider what can be done in master but move forward with it for ROS 2 as fast as possible. I think on goal would be to merge as many (at best all) changes from the ros2 branch to master at some point. Therefore I would avoid any unnecessary changes on the ros2 branch - especially if they are unlikely to be backportable.

Agreed, thanks for the feedback. Closing this

Should the branch then be deleted?

The question is still of the branch can be deleted now.

Branch has been deleted 9 hours ago

Sorry for the noise. I shouldn't check those things from a phone...

no worries :wink:


plan?

Do you have a plan to implement Libtorch version YOLOV4 or YOLOV5 or YOLOX can be trained?

I really need the libtorch training version of yolo5 or yoloX, but it’s a bit difficult for me to implement it myself   Looking forward to your realization


ignore_target_hosts

In a deployment I saw this error:
all relevant MX records point to non-existent hosts

After some research I discovered the ignore_target_hosts configuration option. This was configured in both:
/etc/exim4/conf.d/router/200_exim4-config_primary
/etc/exim4/exim4.conf.template

Since my MX server's A records record resolves to an address in the <IP_ADDRESS>/8 it was being ignored as a viable host. I had to modify both configuration files and reload the service in order to send messages.
Can we add environment variables to allow modifying this configuration option?

I did try to bind mount localmacros with the following:
.ifdef DCconfig_internet
dnslookup:
  debug_print = "R: dnslookup for $local_part@$domain"
  driver = dnslookup
  domains = ! +local_domains
  transport = remote_smtp
  same_domain_copy_routing = yes
  # ignore private rfc1918 and APIPA addresses
  ignore_target_hosts = <IP_ADDRESS> : <IP_ADDRESS>/8 : <IP_ADDRESS>/16 :\
                        <IP_ADDRESS>/12 : <IP_ADDRESS>/16 :\
			<IP_ADDRESS>
  dnssec_request_domains = *
  no_more

.endif

This does get added to /etc/exim4/exim4.conf.localmacros as expected however it does not override what is set in exim4.conf.template and in the router config.


Feat. Req. : Manage Netflix library from inside Kodi library

I'm submitting a ...

[ ] bug report
[X] feature request
[ ] support request

General information
I propose once our database work is done to create a new feature: a context menu on movies and tvshows in the Kodi library that will allow to:

Refresh
Remove show or movie
Export new episodes (shows only)
Include/Exclude from auto update (shows only)

In my idea, it will be based on tags. A tvshow (or movie) exported from the Netflix addon will be tagged "netflix_addon", and if this tag is present, the context menu items will appear.
To avoid a too large list on Kodi, it will be one context menu item named "Netflix" with sub items for all options.
I hope it can make the library management more convinient.
Comments are welcome.

I'm wondering if having the 'exported' folder from the add-on in the favorites wouldn't be enough, then no need of an extra dev...

@notoco As I know you use the library a lot, any comment on this? Thanks!

I'm on vacation now, if I get to the box, I'll check it out

It's not done yet ^^ it's just an idea I have.
If implemented, would you use it? Do you think it can really be interesting? Thanks.
And have a nice vacation by the way!

i use the add-on only via my library (now that the nfo downloads for the weirdly structured series).
importing fresh episodes
remove show/movie from library
would certainly both be useful
download nfo might also be useful (for those who didnt use the nfo with the original import), although that might come under "refresh"

download nfo might also be useful (for those who didnt use the nfo with the original import), although that might come under "refresh"

It's already implemented with a refresh. If you set NFO export to 'yes' or 'ask', a refresh will use those settings.
The auto export new episodes will use the last choice: if you said 'yes export nfo' the all new episodes will have their NFO.
Back to the main topic, I think I won't implement it, at least now very soon, as it will complexity too much the library management in the code, and may cause too much issues using tags.
So I'm closing this feature request.


Appsmith Hacktoberfest! Help us fix bugs, improve code, make new features, write examples and many more!

Hey Contributors 👋🏻 !
We're back again this year for an exciting month-long virtual festival supporting open-source projects. We love it because it's celebratory and community-oriented!
This issue tracks all the engineering, design, content-related ideas, issues and contribution guidelines to help you get started with Appsmith and Hacktoberfest!
Before contributing to Appsmith, please fill out the form here so that we will make sure that the swag reaches you correctly. We highly recommend you to follow these guidelines for code related issues and these for content-related issues.

Before working on an issue, please discuss it with the maintainer and get it assigned to you 😄

This can be a great way to get started with Appsmith and contribute to our fantastic open-source project.
Feel free to share more feature requests and content ideas as a comment on this issue.
Good First Issues / Bug Fixes / Code Improvements
If you're new to Appsmith and Hacktoberfest, this is the best place to start with; we have a bunch of good-first-issues for hacktoberfest that are tagged frontend, bug, and many more. You can pick from these based on your expertise and can start working on them. If you need help understanding the issue or code-related things, do chat with us on Discord channel.

For content related to contributions please check out our documentation repo here, and guidelines here.

Contribute to Appsmith's Documentation 📃
Check out these issues to contribute to our documentation.
How-to Guides (Data source reference)

[ ] How to use Redis as a data source on Appsmith
[ ] How to use ArangoDB as a data source on Appsmith
[ ] How to use Snowflake as a data source on Appsmith
[ ] How to use Redshift as a data source on Appsmith
[ ] How to use MsSQL as a data source on Appsmith
[ ] How to use ElasticSearch as a data source on Appsmith
[ ] How to work with GraphQL on Appsmith
[ ] How to use Notion as a Database on Appsmith

How-to Guides (Appsmith Widget reference)

[ ] How to create Custom Charts on Appsmith
[ ] How to use filters on Appsmith Table Widget
[ ] How to build auto-generated forms using the list widget
[ ] How to group multiple widgets on Appsmith

Blog and Tutorial Contributions
On Appsmith, you can build internal applications, admin panels, CRUD dashboards, and many more. If you would like to build one and write a blog post or tutorial around it, please share your idea with us, and we will create an issue on this repo. Our editorial team will review it, and you can raise a PR to list it on the documentation. Here are some of the examples of blog posts and tutorials to help you get started.

Building an E-commerce Store using Appsmith and Postgres
Building a Shopify Admin Panel: A Step by Step Guide

The blog post can be published either on your blog or can be submitted to the Appsmith blog.
Please comment on what you would like to work on, and we will update this list with your name and assign the issue to you.
To check out our swag and events, please visit https://hacktoberfest.appsmith.com
Happy Hacking!

Hello, I would like to work on this repo! Can u assign me issues?

Hi! I'd like to build a project management app with Appsmith and write a blog post about it. How can I share my idea with your editorial team?

Greetings @siddhantdixit, thanks for showing interest 🎉 , you can look under the hacktoberfest label to find more issues to work on, Leave a comment on the issue you like to work on and tag one of us in the team, You will be assigned to it 🙂
Please don't forget to read the Contribution Guidelines.
Also, please don't forget to register with Appsmith's Hacktoberfest Community in order to be eligible for Appsmith swag.

Hey @oliver-pham, a Project Management App with Appsmith is super cool. Can you share your idea on our discord channel? We have a dedicated #hactoberfest channel!


gRPC in Production: url changed!

the url changed, i searched the article and fixed the link!

@googlebot I signed it!

@googlebot I signed it!


add port mappings configuration for ecs on ec2 doc

Description
Provide a concise summary of the changes made in this pull request
Pull request type
Check the appropriate box:

[ ] Review Fixes
[x ] Documentation Overhaul
[ ] Feature/Story

Link one or more Engineering Tickets
*

[ ] A-Force
[x ] Error in documentation
[ ] Maintenance

Documentation tickets
https://github.com/appsmithorg/appsmith-docs/issues/2464
Checklist
From the below options, select the ones that are applicable:

[ ] Checked for Grammarly suggestions.
[ ] Adhered to the writing checklist.
[ ] Adhered to the media checklist.
[ ] Verified and updated cross-references or added redirect rules.
[ ] Tested the redirect rules on deploy preview.
[ x] Validated the modifications made to the content on the deploy preview.
[ ] Validated the CSS modifications on different screen sizes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


refactor: blur views on mobile safari

Why
Blur backgrounds are not working as expected on mobile safari browsers because we are not targeting webkit browsers, I tried even using Tailwind but its not adding these prefixes, needed to update the blur background hook.

How

Test Plan
Checking header, feed item details, bottom nav bar background on mobile web Safari

Yeap, of course, wanted to get approve first 👍🏽


Upgrade AFNetworking 2.5.2

Are there any plan that RestKit will have AFNetworking 2.5.2 integrated in near future ?
It looks like the latest using 1.3.4
I would like to have 2.5.2 or above specifically for security fix on AFNetworking.
http://arstechnica.com/security/2015/04/1500-ios-apps-have-https-crippling-bug-is-one-of-them-on-your-device/

No, the goal is to get rid of the AFNetworking dependency entirely.

There is an estimative to that?

No, but there are many other issues discussing this.

From reading through the docs, it seems RestKit Object Mapping is independent of AFNetworking. Is my assumption true?
I would like to use the mapping, just not the networking.
Is this case, we have a lot of networking code (using AFNetworking 2) which returns json or NSDictionary. Which we plan to just pass to restkit to do it's thing.

@mozeryansky correct. That's all currently possible.

@segiddins, I've read other comments where you mention you no longer use RestKit at your job. What do you use currently?

I'm not building full apps, otherwise I would be using RestKit.

Ok, thanks for the quick responses. I will be using the Object Mapping.


Setting Downloads(WIFI only), not working.

Steps to reproduce

Go to settings Enable Downloads(WIFI only)

Try to downloads any video courses

Expected behavior

The download should fail or be queued for the next time WIFI Available
Actual behavior

The download is successful and the video plays see the video below:

Environment

iOS Version:14.2
raywenderlich.com App Version: 1.0.6
Device:iPhone 11

Hi @luke-freeman, I've confirmed this bug and this is occurring. How would you like to handle it? I can present a simple iOS dialog when the user taps on a download, informing them that they can't download being on a cellular connection. Or do you want to display a custom notification?


Make stop_on_invalid_record effective for invalid dates such as 2018-02-31

We observed that CSV parser's stop_on_invalid_record: false was not working as intended when a parsed timestamp was invalid (non-existing) date/time, such as 2018-02-31.
It was because DateTimeException in creating a *DateTime instance was not caught and wrapped with TimestampParseException although DateTimeParseException was caught.
@sakama @kamatama41 Can you have a look?

Thanks!


Feature Request: Exchange arbitrary metadata between sidecars at connection time

Title: Exchange arbitrary metadata during TLS handshake or some other process
Description:
In order for Envoy to produce rich telemetry about details of source and destination workloads, we need a mechanism to exchange this information.
As an example, Istio telemetry produces highly dimensioned metrics that identify source and destination of the traffic. The metrics are dimensioned using source and destination metadata such as NodeID and labels associated with the pods or VMs.
For HTTP this can be achieved easily by forwarding the node metadata to destination in a well-known header, and the destination responding with its own header.
Even though the above solution works, it needlessly sends the same information over and over with every request.
For TCP this does not work, and we have to rely on ip address to metadata mapping at the destination and source.
Options:

When mTLS is used, it gives us a way exchange this metadata up front.
If there is a way to add metadata during TLS handshake, it works.
Use HaProxy protocol to exchange this information. Not sure if it works both ways.
https://www.akamai.com/us/en/multimedia/documents/technical-publication/tls-aux-associating-auxiliary-data-tls-connections.pdf

@PiotrSikora

/cc @yangminzhu

/cc @incfly

Exploring if TCP over HTTP/2 metadata frames can be used to implement this...
We would need both these issues fixed for that afaik:

https://github.com/envoyproxy/envoy/issues/1630
https://github.com/envoyproxy/envoy/issues/2394

/cc @alyssawilk
To use TCP over HTTP/2 metadata frames, looks like support for TCP over HTTP(https://github.com/envoyproxy/envoy/issues/1630) is a blocker right now.
We are going to explore TLS extension path for which https://github.com/envoyproxy/envoy/issues/173 is currently a blocker..
Ref: @kyessenov  has a great doc on metadata exchange https://docs.google.com/document/d/1bWQAsrBZguk5HCmBVDEgEMVGS91r9uh3SIr7D7ELZBk/edit.

A required PR to enable "network filters for upstream" https://github.com/envoyproxy/envoy/pull/7503

@mandarjog : I think this can be closed now...


Implement initial --webgpu-mode flag

Fixes #2166

@s-perron, can you confirm that these are sensible flags to be setting for dead code elimation? I suspect agressive might already cover the other flags.


print nested_exception recursively

in case of uncaught nested_exception from test case, print all subexceptions recursively as in example of https://en.cppreference.com/w/cpp/error/nested_exception

already done?


[Internal] Client Telemetry: Adds ClientConfig API support

Description
New API had been introduced to get Database Account Client Configuration from Gateway. As part of this PR, Account Client Configuration will be fetched/refreshed with Account Properties in every 5 minutes.
Client Telemetry Integration will be taken care as part of separate PR.
Note: Supports 2.14.11 and onwards version of emulator
Type of change

[] New feature (non-breaking change which adds functionality)

GatewayStoreModel is created after the GatewayAccountReader is created (which is also passed to the GlobalEndpointManager).
How about passing GatewayAccountReader into the GatewayStoreModel?

out passing GatewayAccountReader into the GatewayStor

We can do a lot of refactoring, but I would like to avoid it doing as part of this PR. maybe I can take it as separate PR.

What happens if it fails?
Right now, it fetches only client telemetry configuration. but still I believe, it should behave similar to Account Properties API. > Hence initialization should fail if this API fails.

What if we get the account information but the call to get the Client Telemetry config fails? Would it be disabled?
It is any like any other configuration where we will have a flag which will tell if feature is enabled or not and other information > will be client telemetry URL. Client Telemetry Job will act according to the returned config.

The question here is how does the SDK react on the scenario where the account information was obtained, but for whatever reason, the Client Telemetry call fails.
Why would we fail the client initialization if the Client Telemetry configuration fails? The SDK client has all the information needed to initialize, wouldn't this add a new failure point to customers initializing? Could we make it more resilient? What if it fails to initialize and we set it as disabled, and 5 minutes after with the refresh, it gets the right information, would the client telemetry job initialize?
What happens if the first initialization works (we get the information, we enable the Client Telemetry Job) but in one of the 5 min refreshes we fail to get it? Would we disable the Client Telemetry job? Or retain the previous known configuration (that it's enabled)?
Is the new client config endpoint available in all regions? For example, if the account is in West US, we can fetch the account information from myaccount.documents.azure.com and from myaccount-westus.documents.azure.com, is the same valid for the new API? Or is it just limited to the global endpoint myaccount.documents.azure.com?

@ealsur Please see my comments below:
The question here is how does the SDK react on the scenario where the account information was obtained, but for whatever reason, the Client Telemetry call fails.
You mean "Account Client Config API" call is failed? If yes, then, first there should not any reason to fail this call only because it is developed and hosted similar to "Database Account Properties" call. Even if it fails, I think it is important for us to know that it is failing and should be fixed or supported by us like any other API. Suppressing failure of this API will increase the problem for us as we will never know that this API is failing at all.
Why would we fail the client initialization if the Client Telemetry configuration fails? The SDK client has all the information needed to initialize, wouldn't this add a new failure point to customers initializing? Could we make it more resilient? What if it fails to initialize and we set it as disabled, and 5 minutes after with the refresh, it gets the right information, would the client telemetry job initialize?
Same as above, there should not any scenario where "only" this API should be failing. If it is happening, we should know.  It is re-checking for the job configuration in every 5 minutes and start and stop the job accordingly.
What happens if the first initialization works (we get the information, we enable the Client Telemetry Job) but in one of the 5 min refreshes we fail to get it? Would we disable the Client Telemetry job? Or retain the previous known configuration (that it's enabled)?
it should mimic the AccountProperties API behavior.
Is the new client config endpoint available in all regions? For example, if the account is in West US, we can fetch the account information from myaccount.documents.azure.com and from myaccount-westus.documents.azure.com, is the same valid for the new API? Or is it just limited to the global endpoint myaccount.documents.azure.com?
It is account level configuration hence shouldn't matter which region call it is. this API will return client configuration for that account.

incorporating all changes/feedback in a new PR which is a new design for this feature.


OCPCLOUD-1871: Merge https://github.com/kubernetes-sigs/cluster-api-operator:v0.4.0 (667606e) into main

Manually tested with e2es on AWS, passing ✅
[~/src/cluster-capi-operator git:(main)] $ make e2e
./hack/test.sh "./e2e/..." 30m
Ran 1 of 3 Specs in 326.767 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2 Skipped
PASS

Ginkgo ran 1 suite in 5m41.33226165s
Test Suite Passed

/lgtm

/retest

/retest


Tablet Galaxy A 8 inch - unable to install latest update to ark mobile wallet

It says my device is not compatible.  Any ideas on when this might be available on tablet?
thanks heaps

Hi @Pleiadien. True, we owe this, need to fix some "details" before releasing it for tablets.


Upgrade deps with go 1.17

Description of the change:
Upgrade deps with go 1.17:

k8s 1.23.1
controller-runtime 0.11,
Kubebuilder latest release v3.3.0
operator-lib to 0.10
operator-framework/api
controller-tools v0.8.0
operator-registry v1.19.5

Motivation for the change:

Bump of/api to get the fix: https://github.com/operator-framework/api/pull/215 - Follow up of; https://github.com/operator-framework/operator-sdk/pull/5495
Get bug fixes and latest changes from KB
Update go

Closes: https://github.com/operator-framework/operator-sdk/pull/5503
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

/hold


[3.0] Backport fixes for bsc#1101004

Backports of

https://github.com/kubic-project/salt/pull/651
https://github.com/kubic-project/salt/pull/652

Looks like the bug was only fixed on master but we need it for release-3.0 as well.
Please double check if the backports are enough or more fixes are needed for 3.0

Hi. We are removing the release-3.0 branch and so I have to close this PR. Even this is "mergeable", there is no validation from QA. Given this is a P5, I don't think this will be validated anytime soon. Please create again a PR to the maintenance branch when this is a priority again. Sorry.


Add documentation for Metrics Service preview

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)
Add documentation for Metrics Service in APIML.
:heart:Thank you!

May have missed it but, do we actually say in the doc where the metrics service can be found? Or is this so obvious it doesn't need stating.

Adding info on where to access metrics service.


Add a E2E test to know when the binary breaks the API

The first step (testing zeit/pkg) is done via https://github.com/prisma/e2e-tests/pull/424 and https://github.com/prisma/e2e-tests/pull/425.
About testing the whole repo via an automated way is tricky, as it would involve a lot more complex stuff like auto publishing prisma binaries, auto updating them  in this repo via pull requests, and considering different branches for latest vs. dev releases.

Cool, do you mind explaining how testing zeit/pkg works? And what we're testing and what we're not testing with this change?
My thinking was we'd have one of those (in)famous Luca actions where every 5 minutes you'd check for an update on engines, download it and run go test. Does that not work?

zeit/pkg just tests if everything works fine when running simple commands with a built binary. It feels a bit too simple but this part broke tons of times in the past (and it's broken right now), so it's definitely a good first step.

Great. I love first steps :-D

My thinking was we'd have one of those (in)famous Luca actions where every 5 minutes you'd check for an update on engines, download it and run go test. Does that not work?

Is this just more work but planned? Or does this idea not make sense?

My main concern is how much value whatever solution we can build provides.
Do we want to bump this directly in this repo with each alpha? Then we'd need to use the action, bump this, and introduce a dev branch in this repo. It would only be used to notify us if something stops working (because otherwise we'd need PRs to the main branch for this change, which would be very cool but also noisy and a lot more work), but if it's in that dev channel, we'd need a slack notifier. However, often we introduce breaking changes which I know about, but couldn't get to yet. Then for each alpha update the slack feed gets spammed that the build fails. I'm not sure what the best solution here is which is not so relaxed that I'll not notice when something fails, but also not so strict that I'll get overwhelmed by it.

Sounds good. The important thing is that the people don't install an incompatible version of the query engine.
As long as we can control when this happens and we have tests that won't let us release without first checking compatibility with the engine, then we should be good.

Yes, it has hardcoded and has to be updated manually via a PR with passing tests by me. And even when it's successfully merged to master, it still has to be released to a tag so go modules users will get that update (expect if they explicitly re-install with @master).

Great! Can this be closed then?

Not sure. I guess I'll close and re-open if I have new plans for this.


SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

https://issues.apache.org/jira/browse/SOLR-11623
First incarnation of this feature (#372) had test failures in prod, and was reverted.
This PR fixes tests. The rest of the code is identical.

BTW I reviewed the the choice of which handler has which permissions (we did this in the previous PR for this) but I don't feel qualified to gauge the impact on tests, as it requires someone familiar with the authorization system's quirks.  Maybe @gerlowskija could help look?

@gerlowskija Please look at the latest changes

I'll merge this soon. Running tests...


fetch_recordings_sensor_range service doesn't work

Trying to use fetch_recordings_sensor_range I got the following error
Traceback (most recent call last):
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
await func(hass, connection, msg)
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/components/websocket_api/commands.py", line 647, in handle_execute_script
await script_obj.async_run(msg.get("variables"), context=context)
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 1524, in async_run
await asyncio.shield(run.async_run())
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 409, in async_run
await self._async_step(log_exceptions=False)
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 453, in _async_step
self._handle_exception(
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 476, in _handle_exception
raise exception
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 451, in _async_step
await getattr(self, handler)()
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/helpers/script.py", line 684, in _async_call_service_step
await service_task
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/core.py", line 1808, in async_call
task.result()
File "/srv/homeassistant/lib/python3.10/site-packages/homeassistant/core.py", line 1845, in _execute_service
await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
File "/home/doudz/.homeassistant/custom_components/bosch/services.py", line 95, in async_handle_recording_sensor_fetch_past
await entity.insert_statistics_range(start_time=day)
AttributeError: 'EnergySensor' object has no attribute 'insert_statistics_range'

it's for recording sensors currently. I can make it for Energy as well if you found it useful.

oh ok
it can be useful since there is data missing...

no more error but it doesn't seems to work but maybe I'm wrong ?

Service added in v0.22.1

Thanks ! But could you please tell how it works ?
I tried the following to retrieve missing data but it does nothing...

Turn on debug logs for the time of service call and check:
It should try to fetch data page by page until it'd find date you want.

Hi
I tried
2023-04-06 20:16:08.044 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [139791145465792] Received {'type': 'execute_script', 'sequence': [{'service': 'bosch.fetch_recordings_sensor_range', 'data': {'uuid': '101027819', 'day': '2023-03-06', 'statistic_id': 'sensors:ehwenergy_hot_waterexternal'}}], 'id': 42}
2023-04-06 20:16:08.046 INFO (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Running websocket_api script
2023-04-06 20:16:08.047 INFO (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Executing step call service
2023-04-06 20:16:08.048 DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=bosch, service=fetch_recordings_sensor_range, service_data=uuid=101027819, day=2023-03-06, statistic_id=sensors:ehwenergy_hot_waterexternal>
2023-04-06 20:16:08.049 DEBUG (MainThread) [custom_components.bosch.services] Performing sensor update on service request. UUID: 101027819
2023-04-06 20:16:08.050 DEBUG (MainThread) [custom_components.bosch] Next update of 1-hour sensors scheduled at: 2023-04-06 21:06:00+02:00
2023-04-06 20:16:08.051 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection] [139791145465792] Sending {"id":42,"type":"result","success":true,"result":{"context":{"id":"01GXBWGXKD3SJ3FYFYSEWX9YN5","parent_id":null,"user_id":"82dec7e7b0f54de399b80bf36264fa89"}}}
2023-04-06 20:16:08.052 DEBUG (Recorder) [homeassistant.components.recorder.core] Processing task: EventTask(event=<Event call_service[L]: domain=bosch, service=fetch_recordings_sensor_range, service_data=uuid=101027819, day=2023-03-06, statistic_id=sensors:ehwenergy_hot_waterexternal>)

and that's all... I don't see any request to history


Add datasource cloudstack_template

This datasource allows you to retrieve a template according to filters you set.
There can be several versions for one template, the datasource will always returns the most recent one.
Parameters:

templatefilter is needed according to the Cloudstack API (https://cloudstack.apache.org/api/apidocs-4.9/apis/listTemplates.html).
filter is used to sort templates.

If you set a filter, the datasource will only returns templates where the field name has the value value (the value can be a regex).
To see the list of available options, check the Template struct of the Cloudstack client : https://godoc.org/github.com/xanzy/go-cloudstack/cloudstack#Template
Example:
data "cloudstack_template" "my_template" {
    templatefilter = "featured"
    filter {
        name = "name"
        value = "CentOS 7\\.1"
    }
    filter {
        name = "hypervisor"
        value = "KVM"
    }
}

Note:
At the moment, filters only work with string fields, you will not be able to set options like size, tags or bootable.

Thanks for the review, I made the requested changes.

There is still a small part that I would like to change/improve to make it a bit more idiomatic Go (using if..else is really discouraged in Go).
But overall it looks good now, so I'm going to merge this as is and then add a few small tweaks/fixes. Thanks again for the work!

@cryptobioz see this commit for my additional changes: 1ca338ff038d1d39c7bde2a8b3337f0d2bf05c13
One more thing I totally forgot about is the documentation or this new data source! Would/could you please open a new PR with some docs (doesn't have to be much) to go with this data source?
That would be awesome and is of course needed to make people aware of the fact that this data source now exists :wink: Thx!

I'm sorry that you had to rewrite almost everything, however, it's very instructive.
I'll open a new PR to add documentation to this datasource.
Thanks for your time and for the merge!

Don't be sorry! I only tweaked the style a bit, the logic is still all you 👍


Change fillColor on click event?

I am trying to fill marker with some color, but fail to implement.
Was trying like this:
google.maps.event.addListener(marker, 'click', function() {
    this.fillColor('black');
});

But surely it didn't work :(

I haven't tested, but this.getIcon() should return a google.maps.Symbol object, which you can just change the properties on.
eg:

google.maps.event.addListener(marker, 'click', function() {
    this.getIcon().fillColor = 'black';
});

That works, how do I toggle between colors then? if or else if don't work.

@knitevision1 As your question doesn't relate to this package, you'll be better off getting support by asking a question at stackoverflow.com under the google-maps-api-3 tag. Or, reading the documentation provided by google


exim: fix enableMySQL (use libmysqlclient.dev)

Motivation for this change
When setting enableMySQL=true for exim via an overlay the build fails, because the mysql.h file cannot be found. That file exists in the dev-output of libmysqlclient.
For testing i ran nix-build -E 'with (import ./default.nix {}); exim.override { enableMySQL = true; }'.
before:
make[2]: Entering directory '/build/exim-4.94.2/build-Linux-x86_64/lookups'
cc dbmdb.c
cc dnsdb.c
cc dsearch.c
cc lsearch.c
cc mysql.c
mysql.c:16:10: fatal error: mysql.h: No such file or directory
   16 | #include <mysql.h>       /* The system header */
      |          ^~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:25: mysql.o] Error 1
make[2]: Leaving directory '/build/exim-4.94.2/build-Linux-x86_64/lookups'
make[1]: *** [Makefile:1012: buildlookups] Error 2
make[1]: Leaving directory '/build/exim-4.94.2/build-Linux-x86_64'
make: *** [Makefile:35: all] Error 2

after:
❯ ./result/bin/exim -bV | grep mysql
[...]
Lookups (built-in): [...] mysql

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Seems like this is also broken on release-20.09. Cherry-picking your commit doesn't seem to fix it there, though.
I'm wondering when this broke, must have been a while. The other options defaulting to false seem to still build, at least.

Since c0825ddbe925d50be9c1068546a51e34e1835903 / d44e1ac0a7447d7c5ad7a2b3eb79618783511bab (on 20.09) the include folder is in the dev output - so I would guess it's broken since at least September 2020 but fell through the cracks due to not being build by default.
I cherry-picked the commit onto release-20.09 and the build succeeds with the patch applied. I can create a backport PR if needed.

Ah, I probably forgot to unset my NIX_PATH, when I tested the backport.
Nobody seems to have complained on 20.09 so far, but I'd still say this is worth backporting.


Install cisagov/skeleton-python-library directly with pip

🗣 Description
This pull request updates the installation of cisagov/skeleton-python-library to be installed directly with pip.

[!WARNING]
This change breaks the Docker composition's ability to change the secret message that is printed. I am hoping to restore this functionality by changing part of how cisagov/skeleton-python-library works in the future.

💭 Motivation and context
There is no reason we shouldn't let pip handle the retrieval, decompression, and installation of a source package on its own. This is a cleaner approach and involves fewer dependencies in the generated Docker image which in turn gives us a smaller image (130MiB vs. 223MiB).

🧪 Testing
Automated tests pass.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

@mcdonnnj Did you mean to enable auto-merge on this skeleton PR?

@mcdonnnj Did you mean to enable auto-merge on this skeleton PR?

Ah, my bad - I see that this PR is not to the develop branch.


CSS & JS

I'm using this route system and I just want to say its amazing. I was just wondering if there's a way to include CSS & JS files in HTML. It keeps returning 404 and it exists but I know the route isn't registered but I don't want to register a route for each file. Is there a better way to do this? All of the viewable pages are in a folder called public. The main site redirects them to the folder. The assets are in a different folder, not in public (I will move the assets if necessary).
Main .htaccess:
RewriteEngine On
RewriteCond %{HTTP_HOST} ^URL [NC]
RewriteRule ^(?!public)(.*)$ /public/$1 [L]

Public folder .htaccess
RewriteEngine On
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ index.php?params=$1 [L,QSA]

I have solved this issue. I moved everything to the public folder and updated my .htaccess for public folder.
.htaccess:
RewriteEngine On
RewriteBase /public
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^.*$ index.php [L]


celery: refactor to use service registry

closed in favour of https://github.com/inveniosoftware/invenio-drafts-resources/pull/160


String literals reduced to generic string type when being cast to intersection type

Worth noting the Devforum post on the topic, which remains unresolved: https://devforum.roblox.com/t/string-constants-lose-type-info-when-being-cast-to-an-intersection-type/2008679
Repro:
type X = {
    FieldX: "ValueX"
}
type Y = {
    FieldY: "ValueY"
}

local XandY: X & Y = { --(Inferred to be type '{ FieldX: string, FieldY: string }'
    FieldX = "ValueX",
    FieldY = "ValueY"
}
--^^^^^^^^^^^^^^^^^^^^ Type Error

Workaround:
Manually typecasting the table fields into their respective literal types
local XandY: X & Y = {
    FieldX = "ValueX" :: "ValueX",
    FieldY = "ValueY" :: "ValueY"
}

I think the following bug belongs to the same category?
This gives an error (TypeError: Type '_my_tagged_union' could not be converted into '({| a: number |} & {| discriminator: "A" |}) | ({| b: string |} & {| discriminator: "B" |})'; none of the union options are compatible):
--!strict
type MyTaggedUnion = VariantA | VariantB
type VariantA = { discriminator: "A" } & { a: number }
type VariantB = { discriminator: "B" } & { b: string }

local _my_tagged_union: MyTaggedUnion = { discriminator = "B", b = "test" }

This works:
--!strict

type MyTaggedUnion = VariantA | VariantB
type VariantA = { discriminator: "A", a: number }
type VariantB = { discriminator: "B", b: string }

local _my_tagged_union: MyTaggedUnion = { discriminator = "B", b = "test" }


Websocket-Ping doesn't stop directly after graceful application exit

After exiting the current running application gracefully by calling launcher.dispose() after a logout(), the handled exitcode 1000 on closing the websocket connection is never sent by the server code and the sent "DISPOSE" isn't implemented.
   // WebSocketListener.java

    /**
    * {@inheritDoc}
    */
   public void pushDispose()
   {
     session.getAsyncRemote().sendText("DISPOSE");
   }
   // ...
   /**
    * {@inheritDoc}
    */
    public void close() throws Throwable
    {
    	session.close(new CloseReason(CloseCodes.GOING_AWAY /* = 1001 */, null));

    	launcher = null;
    	session = null;
    }

The server just handles the 1000 exit code in AppProvider.tsx to stop the application:
     // ...
      ws.current.onclose = (event) => {
          // Stop sending ping and alive on ws close
          pingInterval.stop();
          clearInterval(aliveInterval.current);
          if (event.code === 1000) {
              // no reconnect
              wsIsConnected.current = false;
              console.log("WebSocket has been closed.");
              resolve();
          }
     // ...
      }

And because the reconnectInterval is currently not cleared, the websocket will try to reconnect to a closed session.
This way, the initially displayed "410 - Gone" message from the response will change to the "server is not reachable" message and restart the websocket connection.
Is there currently a other preferred way to close the application?
The EXIT request currently seems only be used in the development commands and also restarts the application.

Not clear why you dispose an application after logout?
The server-side shouldn't dispose the application. The browser is the application and is responsible for such events.

Thank you for your follow-up question.
In case e.g. the server is going down for maintenance or detects the session was killed, the application and launcher does get disposed.

In this case, the client shows a banner and tries to re-connect.
What do you expect?

Not clear why you dispose an application after logout?

It's not the common application logout, it's more of a exit function, which logs out and disposes the launcher to free all used ressources instantly.
The intent here is to tell the client to leave instead of to login again as it would be the case of a logout - but this is not what I intent to get out of this fix.
My issue here is, that the client currently (as far as I can tell) can't handle a full graceful application exit (a far fetched comparison to the Java exit where the application window is closing).
Currently the initial error (bright orange banner 410 - Gone) gets lost, a misleading? one appears (server is not reachable) and a error on the Middletier-Client (WebsocketListener#onClose - NullPointerException at launcher.removePushHandler) appears.
Back to the initial question:

Is there currently a other preferred way to close the application?
If not, should there be one or is it intended to keep the ping-task and session data active by design?

It's not implemented to destroy the application on server-side and leave the page on client-side.
Could be a nice feature request (redirect after destroy).
If there's a problem with banners, we will check it.
The server-side stores all applications in http/intern sessions and the database objects (DBAccess, DBStorage) don't store records. So the UI (application, screens, databooks) consumes memory. If you do a logout, all/most resources should be closed and released.
The current implementation on server, already handles disposed applications:
//Application was disposed
if (launcher.isDisposed())
{
    setStatus(Status.CLIENT_ERROR_GONE);
    return null;
}

and client should handle it. In this case it makes no sense to keep the websocket open. Additional banners should be suppressed but I guess this is not fully checked.

also check #474


Retire in_lvalue/in_param arguments to simplify

Adapting to https://github.com/YosysHQ/yosys/commit/a511976b489ab266a511b9d8d96ee7e5001c9306

@kbieganski @kgugala , can you merge this one, this sync us up with latest Yosys