AWX and community module installation

Environment

OS: CentOS 8
Kubernetes/K3s: 1.21.3
AWX Operator: 0.13.0

Description

Hi,
I am having issues figuring out how to install community module requirements and notices that you code contains builder/requirements.yml and builder/requirements.txt.
Can these be used to customize which modules are present at runtime?
Can't execute community.vmware modules since it's nowhere described how to do this in AWX.
Step to Reproduce

- name: Make sure requirements are met to run vmware modules
  become: true
  ansible.builtin.pip:
    name: pyVmomi
    state: present

- name: Export virtual machine facts
  community.vmware.vmware_guest_info:
    hostname: "{{ hostname }}"
    username: '{{ domain_user }}'
    password: "{{ domain_password }}"
    datacenter: "{{ datacenter }}"
    validate_certs: no
    schema: vsphere
    name: VM01
  register: virtualmachine_facts

Both commands result in:
fatal: [<IP_ADDRESS>]: FAILED! => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/libexec/platform-python"
    },
    "changed": false,
    "module_stderr": "/bin/sh: sudo: command not found\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
    "rc": 127
}

@nicolaibaralmueller
The error means that you can't use sudo, not that you can't use community.vmware.
commynity.vmware is preinstalled in the Execution Environment which used in AWX by default (awx-ee).
If you just want to use community.vmware, you can probably just add become: false to your playbook and the error will go away.

You are absolutely right. Thx @kurokobo.
Still not working though. Added requests to pip install but still got the below error.
ModuleNotFoundError: No module named 'requests'
This is not your issue though and will report to the collection repo.

btw: How I can update the awx-ee image used in the installation? This might fix the issue.
EE_BASE_IMAGE should be quay.io/ansible/ansible-runner:stable-2.11-latest

Hmm the default awx-ee already includes requests. In my environment, community.vmware.vmware_guest_info works good with any of the following Execution Environments.

quay.io/ansible/awx-ee:0.5.0 (This is default for AWX 19.2.2)
quay.io/ansible/awx-ee:0.6.0.
quay.io/ansible/awx-ee:latest (This is default for AWX 19.3.0)

You may want to check that the AWX correctly uses one of these Execution Environments.
If you want to build your own EE yourself anyway, you will need to use ansible-builder. Instruction is also available in my repo: https://github.com/kurokobo/awx-on-k3s/tree/main/builder

Have you changed the ansible_python_interpreter anywhere in your inventory, job templates, or extra variables?

Have you changed the ansible_python_interpreter for the job anywhere in your inventory, job templates, or extra variables?
Or make sure the playbook is running on localhost (connection: local).

Nope. Running below playbook against localhost (inventory) in AWX.
---
- hosts: localhost
  gather_facts: no
  roles:
  - { role: vmware-add-facts }
  post_tasks:
  - name: Export virtual machine facts
    community.vmware.vmware_guest_info:
      hostname: "{{ hostname }}"
      username: '{{ domain_user }}'
      password: "{{ domain_password }}"
      datacenter: "{{ datacenter }}"
      validate_certs: no
      schema: vsphere
      name: TMDC01
    register: virtualmachine_facts

  - debug: var=virtualmachine_facts

This is the complete output:
Enter passphrase for /runner/artifacts/35/ssh_key_data:
Identity added: /runner/artifacts/35/ssh_key_data (/runner/artifacts/35/ssh_key_data)
[WARNING]: You are running the development version of Ansible. You should only
run Ansible from "devel" if you are modifying the Ansible engine, or trying out
features under development. This is a rapidly changing source of code and can
become unstable at any point.
ansible-playbook [core 2.12.0.dev0]
  config file = /runner/project/ansible.cfg
  configured module search path = ['/runner/project/Modules']
  ansible python module location = /usr/local/lib/python3.8/site-packages/ansible
  ansible collection location = /runner/requirements_collections:/home/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible-playbook
  python version = 3.8.6 (default, Jan 29 2021, 17:38:16) [GCC 8.4.1 20200928 (Red Hat 8.4.1-1)]
  jinja version = 2.10.3
  libyaml = True
Using /runner/project/ansible.cfg as config file
Vault password:
host_list declined parsing /runner/inventory/hosts as it did not pass its verify_file() method
Parsed /runner/inventory/hosts inventory source with script plugin
Skipping callback 'awx_display', as we already have a stdout callback.
Skipping callback 'default', as we already have a stdout callback.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.

PLAYBOOK: vmware_test.yml ******************************************************
1 plays in Playbooks/VMware/vmware_test.yml

PLAY [localhost] ***************************************************************
META: ran handlers

TASK [vmware-add-facts : Set VMware facts] *************************************
task path: /runner/project/Roles/vmware-add-facts/tasks/main.yml:3
ok: [<IP_ADDRESS>] => {
    "censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result",
    "changed": false
}
META: role_complete for <IP_ADDRESS>
META: ran handlers

TASK [Export virtual machine facts] ********************************************
task path: /runner/project/Playbooks/VMware/vmware_test.yml:16
<<IP_ADDRESS>> ESTABLISH LOCAL CONNECTION FOR USER: runner
<<IP_ADDRESS>> EXEC /bin/sh -c 'echo ~runner && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/runner/.ansible/tmp `"&& mkdir "` echo /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196 `" && echo ansible-tmp-1630585517.0975893-74-96176537889196="` echo /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196 `" ) && sleep 0'
Using module file /runner/requirements_collections/ansible_collections/community/vmware/plugins/modules/vmware_guest_info.py
<<IP_ADDRESS>> PUT /home/runner/.ansible/tmp/ansible-local-20x0gt007_/tmphyunxz9a TO /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196/AnsiballZ_vmware_guest_info.py
<<IP_ADDRESS>> EXEC /bin/sh -c 'chmod u+x /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196/ /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196/AnsiballZ_vmware_guest_info.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/libexec/platform-python /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196/AnsiballZ_vmware_guest_info.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c 'rm -f -r /home/runner/.ansible/tmp/ansible-tmp-1630585517.0975893-74-96176537889196/ > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_community.vmware.vmware_guest_info_payload_suy3w41g/ansible_community.vmware.vmware_guest_info_payload.zip/ansible_collections/community/vmware/plugins/module_utils/vmware.py", line 26, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
fatal: [<IP_ADDRESS>]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "datacenter": "TM",
            "folder": null,
            "hostname": "virtuelcenter.tm.dom",
            "moid": null,
            "name": "TMDC01",
            "name_match": "first",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "port": 443,
            "properties": null,
            "proxy_host": null,
            "proxy_port": null,
            "schema": "vsphere",
            "tag_details": false,
            "tags": false,
            "use_instance_uuid": false,
            "username"<EMAIL_ADDRESS>            "uuid": null,
            "validate_certs": false
        }
    },
    "msg": "Failed to import the required Python library (requests) on automation-job-35-75jhk's Python /usr/libexec/platform-python. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"
}

PLAY RECAP *********************************************************************
<IP_ADDRESS>                  : ok=2    changed=1    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

Seems to be python related issue.
As a side note playbooks also mentions this:
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can become unstable at any point.

Thanks for the complete output. This is no longer an issue about the contents of my repository, but I'll comment on something I noticed 😄
Seems you have ansible.cfg in your project root, and you invoke vmware-add-facts role before the task.

Are you specifying anything in ansible.cfg, such as library to modify module search path?
Check the tasks in vmware-add-facts role whether there are something which change the path for Python or Ansible related.

I mean, in your output, the search path for the module is;
ansible-playbook [core 2.12.0.dev0]
  config file = /runner/project/ansible.cfg
  configured module search path = ['/runner/project/Modules'] 👈👈👈

Also, /usr/libexec/platform-python is being used for your playbook.
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/libexec/platform-python /home/runner/.ansible/... 👈👈👈

But in my environment, the search path for the module is;
ansible-playbook [core 2.12.0.dev0]
  config file = None
  configured module search path = ['/home/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] 👈👈👈

And /usr/bin/python3 is used to invoke playbook.
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/bin/python3 /home/runner/.ansible/... 👈👈👈

I think your ansible.cfg or vmware-add-facts role is causing some unintended effects.

You are very helpful. Beyond what is expected. Thx
The role just contains set_fact call since some variables are vaulted.
ansible.cfg contains only library         = Modules in regards to modules.
Just changed the line to library         = Modules:/home/runner/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
But same error:
Enter passphrase for /runner/artifacts/41/ssh_key_data:
Identity added: /runner/artifacts/41/ssh_key_data (/runner/artifacts/41/ssh_key_data)
[WARNING]: You are running the development version of Ansible. You should only
run Ansible from "devel" if you are modifying the Ansible engine, or trying out
features under development. This is a rapidly changing source of code and can
become unstable at any point.
ansible-playbook [core 2.12.0.dev0]
  config file = /runner/project/ansible.cfg
  configured module search path = ['/runner/project/Modules', '/home/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.8/site-packages/ansible
  ansible collection location = /runner/requirements_collections:/home/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible-playbook
  python version = 3.8.6 (default, Jan 29 2021, 17:38:16) [GCC 8.4.1 20200928 (Red Hat 8.4.1-1)]
  jinja version = 2.10.3
  libyaml = True
Using /runner/project/ansible.cfg as config file
Vault password:
host_list declined parsing /runner/inventory/hosts as it did not pass its verify_file() method
Parsed /runner/inventory/hosts inventory source with script plugin
Skipping callback 'awx_display', as we already have a stdout callback.
Skipping callback 'default', as we already have a stdout callback.
Skipping callback 'minimal', as we already have a stdout callback.
Skipping callback 'oneline', as we already have a stdout callback.

PLAYBOOK: vmware_test.yml ******************************************************
1 plays in Playbooks/VMware/vmware_test.yml

PLAY [localhost] ***************************************************************
META: ran handlers

TASK [vmware-add-facts : Set VMware facts] *************************************
task path: /runner/project/Roles/vmware-add-facts/tasks/main.yml:3
ok: [<IP_ADDRESS>] => {
    "censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result",
    "changed": false
}
META: role_complete for <IP_ADDRESS>
META: ran handlers

TASK [Export virtual machine facts] ********************************************
task path: /runner/project/Playbooks/VMware/vmware_test.yml:8
<<IP_ADDRESS>> ESTABLISH LOCAL CONNECTION FOR USER: runner
<<IP_ADDRESS>> EXEC /bin/sh -c 'echo ~runner && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/runner/.ansible/tmp `"&& mkdir "` echo /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888 `" && echo ansible-tmp-1630653333.580897-31-198337812307888="` echo /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888 `" ) && sleep 0'
<<IP_ADDRESS>> Attempting python interpreter discovery
<<IP_ADDRESS>> EXEC /bin/sh -c 'echo PLATFORM; uname; echo FOUND; command -v '"'"'python3.10'"'"'; command -v '"'"'python3.9'"'"'; command -v '"'"'python3.8'"'"'; command -v '"'"'python3.7'"'"'; command -v '"'"'python3.6'"'"'; command -v '"'"'python3.5'"'"'; command -v '"'"'/usr/bin/python3'"'"'; command -v '"'"'/usr/libexec/platform-python'"'"'; command -v '"'"'python2.7'"'"'; command -v '"'"'python2.6'"'"'; command -v '"'"'/usr/bin/python'"'"'; command -v '"'"'python'"'"'; echo ENDFOUND && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/bin/python3.8 && sleep 0'
Using module file /runner/requirements_collections/ansible_collections/community/vmware/plugins/modules/vmware_guest_info.py
<<IP_ADDRESS>> PUT /home/runner/.ansible/tmp/ansible-local-20brg61loo/tmpv73bmco3 TO /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888/AnsiballZ_vmware_guest_info.py
<<IP_ADDRESS>> EXEC /bin/sh -c 'chmod u+x /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888/ /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888/AnsiballZ_vmware_guest_info.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/libexec/platform-python /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888/AnsiballZ_vmware_guest_info.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c 'rm -f -r /home/runner/.ansible/tmp/ansible-tmp-1630653333.580897-31-198337812307888/ > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_community.vmware.vmware_guest_info_payload_2bqm6z8h/ansible_community.vmware.vmware_guest_info_payload.zip/ansible_collections/community/vmware/plugins/module_utils/vmware.py", line 26, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'
fatal: [<IP_ADDRESS>]: FAILED! => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/libexec/platform-python"
    },
    "changed": false,
    "invocation": {
        "module_args": {
            "datacenter": "DC01",
            "folder": null,
            "hostname": "virtualacenter.domain.local",
            "moid": null,
            "name": "VM01",
            "name_match": "first",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "port": 443,
            "properties": null,
            "proxy_host": null,
            "proxy_port": null,
            "schema": "vsphere",
            "tag_details": false,
            "tags": false,
            "use_instance_uuid": false,
            "username"<EMAIL_ADDRESS>            "uuid": null,
            "validate_certs": false
        }
    },
    "msg": "Failed to import the required Python library (requests) on automation-job-41-2z79x's Python /usr/libexec/platform-python. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"
}

PLAY RECAP *********************************************************************
<IP_ADDRESS>                  : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

any hosts file in your project?

any hosts file in your project?

Nope. I just created a AWX inventory 'localhost'  with group 'localhost' and host '<IP_ADDRESS>'.
I am not specifying any python executable anywhere. this is a fresh install with just the one playbook.

I just created a AWX inventory 'localhost' with group 'localhost' and host '<IP_ADDRESS>'.

Ah, that is...
Remove <IP_ADDRESS> from localhost group. It's ok to keep localhost group empty.

Alternatively you can add these two variables as variables for <IP_ADDRESS>
ansible_connection: local
ansible_python_interpreter: '{{ ansible_playbook_python }}'

The localhost of the Demo Inventory is configured in the same way.

You are correct again @kurokobo. This was not an issue in older AWX versions.
Now the playbook runs as expected but another issue arises:
Unable to connect to vCenter or ESXi API at virtuelcenter.tm.dom on TCP/443: [SSL: UNSUPPORTED_PROTOCOL] unsupported protocol (_ssl.c:1124)
I solved this issue in AWX 15.0.1 by executing /usr/bin/update-crypto-policies --set LEGACY in the containers.
I will continue the good fight ;)


Get changes opt

In order to improve sync performance I've taken a look at the generate_sync_message functionality and it was quite largely spending time in getting the changes, this can be especially bad when we can't use the fast version...
This PR optimises the get_changes function by doing the following:

Maintain a vector clock for each change (hash) to allow constant time calculation of the vector clock
Use this new clocks state to speed up finding the clock at any given hash
Change get_changes to use the clocks under the hood, converting the hashes first to a single clock and then building the resulting changes from that
Precalculate the number of operations in a change and store it alongside, otherwise we have to individually count the operations every time

This does add overhead to each document's memory to store the clocks, I'm sure we can optimise this somehow but I'm basically trying to have syncing not take too long, even though it is something that shouldn't be done too frequently it still shouldn't take multiple seconds!
Note: speeding up the clock_at function also speeds up all of the _at queries for historical content so this is kind of a double win!
And this turned up a bug in the wasm tests which is fixed here.

There is a small change in behavior here where get_changes() returns an error instead of an empty set when given an unknown hash.  Seems reasonable.   Just want to make sure we discuss weather this is the most useful behavior.  I'm sad to see more places where we need unwraps but think this is probably a good change.  Thoughts?


Inclusion of a LUCID implementation

OpenCV currently contains at least two nonfree programs that can be used for construction of image descriptors (SURF and SIFT, to my knowledge). I offer a free adaptation of the Locally Uniform Comparison Image Descriptor (Ziegler, Andrew, Eric Christiansen, David Kriegman, and Serge J. Belongie. "Locally uniform comparison image descriptor." In Advances in Neural Information Processing Systems, pp. 1-9. 2012.), under a license compatible to GPL, hoping to provide one additional free program to OpenCV that allows descriptor construction, such that developers and users need not sacrifice the freedom of their computer for completion of this task.
This is my first contribution to OpenCV. I attempted to adhere to coding standards where required as instructed by your style guide. This initial functionality includes the construction of descriptors, as well as exposing a separable box filter blur that the developer may use on images independently. I have also included a simple test case, sample code and required documentation. This code compiles and the test succeeds on my GNU/Linux operating system, but is currently untested on other platforms. In accordance with your contribution guide, this commit does not include additional feature matching functionality that would be compatible with this image descriptor, as is stated that PRs should focus on one issue at a time. Please don't hesitate to point out in which places, if any, the code is not yet suitable for inclusion into OpenCV, and I will attempt to rectify it in a timely manner.

Closed due to being better suited to opencv_contrib for now.


Multiple filters in video lock app

Hello!
Trying to filtering video with multiple filters like in demo.
App is locked, not crushed
Code stopping in file Compute.swift, 37 row

Hello! When i try to filter some video, it's crush due to loss memory


Fix logs url when the frontend url is not on the root of the url

Example: http://neotys.com/frontend

Already merged and tested with unit test by the Pull request "Topic workspace compatibility"


Force -ip option does not seem to work

I am still getting the internal container ip (i.e. <IP_ADDRESS> etc) for a container running on a host with a registrator instance that was started like this: (i would expect it to be <IP_ADDRESS>)
docker run -d \
    --name=registrator \
    -h $HOSTNAME \
    --volume=/var/run/docker.sock:/tmp/docker.sock \
    gliderlabs/registrator:latest \
      consul://<IP_ADDRESS>:8500 \
    -ip <IP_ADDRESS>

This seems to have tripped a few people up, but the flags / options need to come before the registry URI. See #288 which I'm planning to follow up with a PR soon.


Mssql

Summary
Thank you for contributing to pointblank! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Related GitHub Issues and PRs

Ref: #

Checklist

[ ] I understand and agree to the Code of Conduct.
[ ] I have listed any major changes in the NEWS.
[ ] I have added testthat unit tests to tests/testthat for any new functionality.

Hey @pachadotdev thanks for getting this going! I'll take a look a this and see what's going on with that error message.


Getting a warning while running cmake on Windows

Confirm by changing [ ] to [x] below:

[x] I've gone though Developer Guide and API reference
[x] I've searched for previous similar issues and didn't find any solution

I'm trying to build the SDK on Windows from sources. I downloaded the sources as a zip file from https://github.com/aws/aws-sdk-cpp/releases/tag/1.8.106
When I run cmake, I get a warning, stating the sources of the SDK are not under source control of git.
I succeeded to build the SDK, however I wondered if this warning needs my attention or not.
Here is the command I run:
cmake -G "Visual Studio 16 2019" -DSTATIC_LINKING=1 -DCMAKE_EXE_LINKER_FLAGS_DEBUGOPT="" -DCMAKE_CXX_FLAGS_DEBUGOPT="" -DTARGET_ARCH=WINDOWS
And here is the output with the warning message (fatal: not a git repository):
D:\Development\3rdParties\aws_sdk_cpp\1.8.106\aws-sdk-cpp-1.8.106
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.21.0.windows.1")
-- Building AWS libraries as static objects
-- Generating windows build config
fatal: not a git repository: 'D:/Development/3rdParties/aws_sdk_cpp/1.8.106/aws-sdk-cpp-1.8.106/.git'
-- Building project version: 1.8.106
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.14393.
-- The C compiler identification is MSVC 19.27.29111.0
....
Is that OK?

@Eliyahu-Machluf , it is weird that you're getting this message, my best guess is that the sdk is somehow in an unexpected folder structure.
But anyways yea, that is a git warning and not a cmake or msbuild one, so as long as the project is built successfully I wouldn't worry about it.

@KaibaLopez,
Thanks for the quick response.
It is good to know I can ignore this error and proceed with my work.
BTW, the error is very simple to reproduce, and does not relate to directory structure:

simply download the sources as zip file from https://github.com/aws/aws-sdk-cpp/releases/tag/1.8.106
extract the sources to SOURCE_PATH.
make directory BUILD
cd BUILD
run the command cmake SOURCE_PATH

And you'll get the "fatal: not a git repository:" warning at the first 10 lines of cmake output.


Incorporating additional objects into an existing environment

Incorporating particles.xml into an existing environment
Hi,
We are students trying to use MuJoCo to simulate an environment with additional elements.
We intend to integrate a modified version of the composite <particle.xml> environment.

Incorporate the contents of the xml file shown below:
This is a modification of the "particle.xml" composite objects.

Modified particles.xml -

<option solver="CG" tolerance="1e-6" timestep=".01"/>

<size memory="1G"/>

<visual>
    <map stiffness="100"/>
</visual>

<default>
    <default class="wall">
        <geom type="plane" size=".5 .5 .05"/>
    </default>
</default>

<worldbody>
    <!-- Central Box -->
    <geom name="central_box" type="box" size=".5 .5 .5" pos="0 0 0.25"/>

    <!-- Surrounding Boxes -->
    <geom name="box_1" type="box" size=".03 .03 .03" pos=".6 0 0.15"/>
    <geom name="box_2" type="box" size=".03 .03 .03" pos="-.6 0 0.15"/>
    <geom name="box_3" type="box" size=".3 .3 .3" pos="0 .6 0.15"/>
    <geom name="box_4" type="box" size=".3 .3 .3" pos="0 -.6 0.15"/>

    <!-- Particle System -->
    <composite type="particle" count="10 10 20" spacing="0.03" offset="0 0 1">
        <geom size=".025" rgba=".8 .2 .1 1"/>
    </composite>
</worldbody>

into an existing environment :

 Addition to the above existing environment would be the following world body (as taken from the code linked above)

    <body name="box" pos="0.2 0.5 0.05">
        <joint name="red_box_joint" type="free" frictionloss="0.01" />
        <inertial pos="0 0 0" mass="0.05" diaginertia="0.002 0.002 0.002" />
        <geom condim="4" solimp="2 1 0.01" solref="0.01 1" friction="1 0.005 0.0001" pos="0 0 0" size="0.02 0.02 0.02" type="box" name="red_box" rgba="1 0 0 1" />
    </body>
    <geom name="box_1" type="box" size=".03 .3 .3" pos=".6 0 0.15"/>
    <geom name="box_2" type="box" size=".03 .3 .3" pos="-.6 0 0.15"/>
    <geom name="box_3" type="box" size=".3 .3 .3" pos="0 .6 0.15"/>
    <geom name="box_4" type="box" size=".3 .3 .3" pos="0 -.6 0.15"/>
    <composite type="particle" count="2 1 1" spacing="0.03" offset="0 0 1">
        <geom size=".025" mass="0.6" rgba=".8 .2 .1 1"/>
    </composite>
</worldbody>

We are able to get the objects in the environment by including them into the xml as shown above, however we are facing errors corresponding to properties of mass and inertia, when we try to simulate the environment by passing path of this xml to the command: ./simulate <path to the xml file>
The error we came across when we  is as follows:
Error: mass and inertia of moving bodies must be larger than mjMINVAL Object name = B0_0_0, id = 26
What is the best way to go about with this?
Thanks and Regards

You are including a file with the string <compiler ... inertiagrouprange="4 5"/>. This is telling the compiler to only infer inertias from geoms in groups 4 and 5. The default group for geoms (and everything else) is 0. So the mass="0.6" inside your composite is being ignored and you have a massless moving body, which is not allowed.

Thank you for your input on the error!
It helped resolve the issue we were facing.


Chalk'it in the IDE

It is much more pleasant for developers to develop in their favorite IDE. A solution for Chalk'it would be to develop a utility for:

xprjson to directory
directory to xprjson

with automatic updates on save...
Plan for the use of the IDE debugger...

Thanks Tristan. Great work !


document instillation on windows.

Haw dose one install on windows? can we add some info to the readme? if it is not compatible, document that as well.

Hi Eh2406,
There is code in place to use CMake on Windows, but I do not know if this works.  Can you try installing CMake and then running cargo build in a clone of the rust-pcre repository?
I will try to find a Windows machine that I can use to test.

Installed CMake on path.
--- stdout
-- Building for: NMake Makefiles
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
-- Configuring incomplete, errors occurred!
See also "C:/Users/.../rust-pcre/target/debug/build/libpcre-sys-e14940ffe5643b78/out/pcre-8.38/CMakeFiles/CMakeOutput.log".
See also "C:/Users/.../rust-pcre/target/debug/build/libpcre-sys-e14940ffe5643b78/out/pcre-8.38/CMakeFiles/CMakeError.log".

--- stderr
CMake Error at CMakeLists.txt:69 (PROJECT):
  The CMAKE_C_COMPILER:

    cl

  is not a full path and was not found in the PATH.

  To use the NMake generator with Visual C++, cmake must be run from a shell
  that can use the compiler cl from the command line.  This environment is
  unable to invoke the cl compiler.  To fix this problem, run cmake from the
  Visual Studio Command Prompt (vcvarsall.bat).

  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.

CMake Error at CMakeLists.txt:69 (PROJECT):
  The CMAKE_CXX_COMPILER:

    cl

  is not a full path and was not found in the PATH.

  To use the NMake generator with Visual C++, cmake must be run from a shell
  that can use the compiler cl from the command line.  This environment is
  unable to invoke the cl compiler.  To fix this problem, run cmake from the
  Visual Studio Command Prompt (vcvarsall.bat).

  Tell CMake where to find the compiler by setting either the environment
  variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
  to the compiler, or to the compiler name if it is in the PATH.

thread '<main>' panicked at '`cmake . -DBUILD_SHARED_LIBS=OFF ...` did not run successfully.', libpcre-sys\build.rs:118

Looks like it is trying to compile with Visual Studio witch wont be compatible with Windows (GNU ABI †) even if it had worked.


use impl Executor in Insert::insert instead of &mut Connection

This implements the solution discussed in https://github.com/NyxCode/ormx/issues/22#issuecomment-1010043291
⚠ Please beware that this is a BREAKING CHANGE ⚠
Essentially, it allows to use the same API db: impl Executor<...> in Insert::insert instead of the odd db: &mut Connection<...>.
The reason for that special case was to fetch the newly created id for MySQL by reusing the connection.
This solution implements that by opening a transaction when generating Insert::insert for MySQL.

this was on my to-do list for a long time! thanks!


bug: attempting to load external non-module alias triggers .resolve_target()

Description of the bug
It looks like when loading a non-module alias, the on_package_load event triggers on it, causing an extension (I think?) to run .resolve_target().
To Reproduce
Create two files, demo.py, and demo2.py. I'll use the package tabulate here as the external package in this demo (edit: actually tabulate wasn't needed, since it couldn't resolve demo, but same idea 😅 ).
demo.py
# importing the tabulate function from tabulate
from tabulate import tabulate

demo2.py
from demo import tabulate as alias

Then run the loader:
from griffe.loader import GriffeLoader

loader = GriffeLoader()
loader.load("demo2.alias")

Full traceback

Full traceback
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1373, in Alias._resolve_target(self)
   1372 try:
-> 1373     resolved = self.modules_collection.get_member(self.target_path)
   1374 except KeyError as error:

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/mixins.py:78, in GetMembersMixin.get_member(self, key)
     77     return self.members[parts[0]]  # type: ignore[attr-defined]
---> 78 return self.members[parts[0]].get_member(parts[1:])

KeyError: 'tabulate'

The above exception was the direct cause of the following exception:

AliasResolutionError                      Traceback (most recent call last)
Cell In[8], line 1
----> 1 loader.load("demo2.alias")

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/loader.py:233, in GriffeLoader.load(self, objspec, submodules, try_relative_path, find_stubs_package, module)
    231 # Package is loaded, we now retrieve the initially requested object and return it.
    232 obj = self.modules_collection.get_member(obj_path)
--> 233 self.extensions.call("on_package_loaded", pkg=obj)
    234 return obj

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/base.py:345, in Extensions.call(self, event, **kwargs)
    338 """Call the extension hook for the given event.
    339
    340 Parameters:
    341     event: The trigerred event.
    342     **kwargs: Arguments passed to the hook.
    343 """
    344 for extension in self._extensions:
--> 345     getattr(extension, event)(**kwargs)

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/dataclasses.py:226, in DataclassesExtension.on_package_loaded(self, pkg)
    220 def on_package_loaded(self, *, pkg: Module) -> None:
    221     """Hook for loaded packages.
    222
    223     Parameters:
    224         pkg: The loaded package.
    225     """
--> 226     _apply_recursively(pkg, set())

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/dataclasses.py:197, in _apply_recursively(mod_cls, processed)
    196 def _apply_recursively(mod_cls: Module | Class, processed: set[str]) -> None:
--> 197     if mod_cls.canonical_path in processed:
    198         return
    199     processed.add(mod_cls.canonical_path)

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1138, in Alias.canonical_path(self)
   1132 @property
   1133 def canonical_path(self) -> str:
   1134     """The full dotted path of this object.
   1135
   1136     The canonical path is the path where the object was defined (not imported).
   1137     """
-> 1138     return self.final_target.canonical_path

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1339, in Alias.final_target(self)
   1337         raise CyclicAliasError([*paths_seen, target.path])
   1338     paths_seen[target.path] = None
-> 1339     target = target.target  # type: ignore[assignment]
   1340 return target

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1308, in Alias.target(self)
   1302 """The resolved target (actual object), if possible.
   1303
   1304 Upon accessing this property, if the target is not already resolved,
   1305 a lookup is done using the modules collection to find the target.
   1306 """
   1307 if not self.resolved:
-> 1308     self.resolve_target()
   1309 return self._target

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1367, in Alias.resolve_target(self)
   1365 self._passed_through = True
   1366 try:
-> 1367     self._resolve_target()
   1368 finally:
   1369     self._passed_through = False

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1380, in Alias._resolve_target(self)
   1378 if resolved.is_alias and not resolved.resolved:
   1379     try:
-> 1380         resolved.resolve_target()
   1381     except CyclicAliasError as error:
   1382         raise CyclicAliasError([self.target_path, *error.chain]) from error

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1367, in Alias.resolve_target(self)
   1365 self._passed_through = True
   1366 try:
-> 1367     self._resolve_target()
   1368 finally:
   1369     self._passed_through = False

File ~/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py:1375, in Alias._resolve_target(self)
   1373     resolved = self.modules_collection.get_member(self.target_path)
   1374 except KeyError as error:
-> 1375     raise AliasResolutionError(self) from error
   1376 if resolved is self:
   1377     raise CyclicAliasError([self.target_path])

AliasResolutionError: Could not resolve alias demo.tabulate pointing at tabulate.tabulate (in demo.py:1)

$ griffe dump ... -LDEBUG
griffe dump demo2.alias -LDEBUG
INFO       Loading package demo2.alias
DEBUG      Searching path(s) for demo2.alias
DEBUG      Found demo2.alias: loading
DEBUG      Loading path /Users/machow/repos/quartodoc/demo2.py
Traceback (most recent call last):
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1373, in _resolve_target
    resolved = self.modules_collection.get_member(self.target_path)
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/mixins.py", line 78, in get_member
    return self.members[parts[0]].get_member(parts[1:])  # type: ignore[attr-defined]
KeyError: 'demo'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/machow/.virtualenvs/quartodoc/bin/griffe", line 8, in <module>
    sys.exit(main())
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/cli.py", line 555, in main
    return commands[subcommand](**opts_dict)
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/cli.py", line 385, in dump
    loader = _load_packages(
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/cli.py", line 97, in _load_packages
    loader.load(package, try_relative_path=True, find_stubs_package=find_stubs_package)
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/loader.py", line 233, in load
    self.extensions.call("on_package_loaded", pkg=obj)
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/base.py", line 345, in call
    getattr(extension, event)(**kwargs)
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/dataclasses.py", line 226, in on_package_loaded
    _apply_recursively(pkg, set())
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/extensions/dataclasses.py", line 197, in _apply_recursively
    if mod_cls.canonical_path in processed:
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1138, in canonical_path
    return self.final_target.canonical_path
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1339, in final_target
    target = target.target  # type: ignore[assignment]
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1308, in target
    self.resolve_target()
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1367, in resolve_target
    self._resolve_target()
  File "/Users/machow/.virtualenvs/quartodoc/lib/python3.10/site-packages/griffe/dataclasses.py", line 1375, in _resolve_target
    raise AliasResolutionError(self) from error
griffe.exceptions.AliasResolutionError: Could not resolve alias demo2.alias pointing at demo.tabulate (in demo2.py:1)

$ mkdocs build -v
PASTE LOGS HERE

Expected behavior
An Alias object is returned, even when tabulate is not loaded.
Environment information
griffe --debug-info  # | xclip -selection clipboard

- __System__: macOS-14.4.1-arm64-arm-64bit
- __Python__: cpython 3.10.2 (/Users/machow/.virtualenvs/quartodoc/bin/python)
- __Environment variables__:
- __Installed packages__:
  - `griffe` v0.45.2

Found the cause:
-        self.extensions.call("on_package_loaded", pkg=obj)
+        self.extensions.call("on_package_loaded", pkg=obj.package)

Pushing a fix :slightly_smiling_face:
I'll try to pack a few more things before a release though. It's friday so I think it's fine to make you wait until monday :yum:


Error: Syntax error, unrecognized expression: unsupported pseudo: hover

Summary
When running a11y on the following page;
https://www.bbc.co.uk/newsround/46660407
I get:
Unexpected Error Error: Syntax error, unrecognized expression: unsupported pseudo: hover
and the tool doesn't run.

Expected Behaviour
Tool should finish running.

Current Behaviour
The tool fails with the following console output:
Unexpected Error Error: Syntax error, unrecognized expression: unsupported pseudo: hover
    at Function.Sizzle.error (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1541:8)
    at PSEUDO (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1888:13)
    at matcherFromTokens (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2437:44)
    at Sizzle.compile (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2591:13)
    at Sizzle.select (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2677:16)
    at Sizzle (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:845:9)
    at Function.Sizzle.matchesSelector (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1504:9)
    at Function.jQuery.filter (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2846:22)
    at winnow (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2835:16)
    at jQuery.fn.init.is (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2885:12)
Unexpected Error Error: Syntax error, unrecognized expression: unsupported pseudo: hover
    at Function.Sizzle.error (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1541:8)
    at PSEUDO (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1888:13)
    at matcherFromTokens (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2437:44)
    at Sizzle.compile (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2591:13)
    at Sizzle.select (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2677:16)
    at Sizzle (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:845:9)
    at Function.Sizzle.matchesSelector (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:1504:9)
    at Function.jQuery.filter (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2846:22)
    at winnow (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2835:16)
    at jQuery.fn.init.is (/Users/waltea07/workspace/accessibility-checker/node_modules/jquery/dist/jquery.js:2885:12)
0 pages checked, 0 errors found, 0 warnings, 0 standards skipped

Possible Solution

Steps to Reproduce (for bugs)

$ bbc-a11y https://www.bbc.co.uk/newsround/46660407
Context & Motivation
Trying to check accessibility of BBC sites.

Your Environment

Version used: v2.2.6
Operating System and version: Mac OSX 10.11.6 El Capitan
Link to your project:

Hi @AdamJamesWalters and @murkas , as Chris said this maybe similar to something that has come up before. @oluoluoxenfree said she is happy to help someone work on a solution for this. And Michael offered some advice about using a try-catch in #275 .

Cheers for nudging this @EmmaJP, Michael's suggestion of a try...catch will probably be the best solution, as it won't degrade the experience of using a11y, as far as I can tell.

I've had a quick look into this, this morning and have struggled to recreate (I guess CSS must have changed since this was initially report). Can anyone provide a link to a page that still causes this error? Thanks!

@murkas yes I've just got this error when running bbc-a11y against https://www.bbc.co.uk/news/politics/constituencies/E14000939
Unexpected Error Error: Syntax error, unrecognized expression: [type="range"]:disabled::-webkit-slider-runnable-track
at Function.Sizzle.error (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:1560:8)
at Sizzle.tokenize (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2216:11)
at Sizzle.compile (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2610:12)
at Sizzle.select (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2700:16)
at Sizzle (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:862:9)
at Function.Sizzle.matchesSelector (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:1523:9)
at Function.jQuery.filter (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2869:22)
at winnow (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2858:16)
at jQuery.fn.init.is (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2908:12)
at getElementFontSizes (/usr/local/lib/node_modules/bbc-a11y/lib/standards/tests/textMustBeStyledWithUnitsThatAreResizableInAllBrowsers.js:43:28)
Unexpected Error Error: Syntax error, unrecognized expression: [type="range"]:disabled::-webkit-slider-runnable-track
at Function.Sizzle.error (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:1560:8)
at Sizzle.tokenize (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2216:11)
at Sizzle.compile (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2610:12)
at Sizzle.select (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2700:16)
at Sizzle (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:862:9)
at Function.Sizzle.matchesSelector (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:1523:9)
at Function.jQuery.filter (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2869:22)
at winnow (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2858:16)
at jQuery.fn.init.is (/usr/local/lib/node_modules/bbc-a11y/node_modules/jquery/dist/jquery.js:2908:12)
at getElementFontSizes (/usr/local/lib/node_modules/bbc-a11y/lib/standards/tests/textMustBeStyledWithUnitsThatAreResizableInAllBrowsers.js:43:28)

@greenc05 Thanks for sending this on - I'll investigate and see if I can determine where the error is thrown using this!

Hi @AdamJamesWalters and @murkas
I've just released v2.4.1 which should fix this issue. Please re-open this issue if not.
Thanks.

Thank you


Is Schedule497ItemBase inheriting for models.Model on purpose, or is it an oversight of our base abstract classes?

I assumed this was an oversight and changed it for #48.


cve-2024-45296 cve-2024-45590 security bumps

Typo, should have been : cve-2024-45590 and  CVE-2024-45296


OpenSSL 1.1 compatibility patches

OpenSSL removed SSL_R_SHORT_READ upstream
See #2047
SSL_R_SHORT_READ was removed in https://github.com/openssl/openssl/commit/45f55f6a5bdcec411ef08a6f8aae41d5d3d234ad about 2.5 years ago.
This still will not allow rippled to build with OpenSSL 1.1.0, but it fixes one of the two main error sites (the other one being src/ripple/basics/impl/make_SSLContext.cpp, see #1914).

Codecov Report

Merging #2126 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2126      +/-   ##
===========================================
- Coverage    68.98%   68.97%   -0.01%
===========================================
  Files          684      684
  Lines        50394    50394
===========================================
- Hits         34764    34761       -3
- Misses       15630    15633       +3

Impacted Files
Coverage Δ

src/ripple/beast/asio/ssl_error.h
90.9% <ø> (ø)
:arrow_up:

src/ripple/basics/DecayingSample.h
77.77% <0%> (-8.34%)
:arrow_down:

src/ripple/server/impl/BaseWSPeer.h
67.5% <0%> (-0.63%)
:arrow_down:

src/ripple/beast/asio/io_latency_probe.h
98.5% <0%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e1b99...8e7d67f. Read the comment docs.

I don't expect this to be merged in this state, but at least it build for me now with OpenSSL 1.1 and it doesn't impact anything since the 2 problematic features that caused compiler errors are deprecated already.
There are still some deprecation warnings left and some functions should maybe anyways be removed - I personally am not going to work on this PR any more than this, since my main goal was to be able to compile rippled on current distributions with OpenSSL 1.1 - and it is already reached.

Rebased to 0.70.0-b7.

#2151 is probably the better patch for this, closing this PR.


fix: recursion challenges that abuse global space

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Temporary fix for #43516

I tested the first recursion challenge with the code jeremy included that he wanted to fail, the second recursion challenge was tested with code I wrote, and it fails as expected:
const holder=[] function rangeOfNumbers(startNum, endNum) {   if(startNum===endNum){     holder.push(startNum)     return holder   } else {     holder.push(startNum)     return rangeOfNumbers(startNum+1,endNum)   } };
It wont close the issue for all challenges, but it could work as a temporary fix for the specific challenges that he wanted to fail. Yes?

I like these changes. Steamroller is another challenge that would need this.
Also Cash Register and Roman Numeral Converter tend to see recursive solutions.

I like these changes. Steamroller is another challenge that would need this.
Also Cash Register and Roman Numeral Converter tend to see recursive solutions.

Ok, Ive fixed challenges Steamroller, Cash Register, and Roman Numeral as instructed. Please advise any further actions necessary.

These checks specifically see if the (ab)use of the global space ruins the reusability of the function, which I think we want. What's the point in accepting a function that will return completely wrong answers if called more than once?
With certification projects, the picture is muddy. We used to not reset the global state between tests, which would lead to test failures due to global space (ab)use - we even have a canned reply on the forum to address the mistake. When we changed to run tests independently, we created a situation where users could submit projects with global space (ab)use and have them pass when they used to fail. So, we have a regression in the concepts required to pass the certification projects.

I specifically noticed it the recursion challenges before I understood the root cause. I'm not aware of other challenges where using the global space is a common workaround, but I'm not sure.

Well, I am fine with the added test for the three challenges. I do think it's possible to abuse that space on most JS challenges, maybe not common, though. I'm hesitant on the cert projects - the additional test is pretty minor, but I think I would prefer to leave those. Either way, we need to either remove those tests on the cert projects, or add the tests to the duplicate cert projects. What do you think @jeremylt.

Recursion isn't a common approach to the certification projects, so either approach is fine to me.

Well, I gave my vote. If you two want to get another opinion, that's fine with me. Otherwise, feel free to make that change @KravMaguy. Thanks.

Well, I am fine with the added test for the three challenges. I do think it's possible to abuse that space on most JS challenges - maybe not common, though. I'm hesitant on the cert projects - the additional test is pretty minor, but I think I would prefer to leave those. Either way, we need to either remove those tests on the cert projects, or add the tests to the duplicate cert projects.

Well, I gave my vote. If you two want to get another opinion, that's fine with me. Otherwise, feel free to make that change @KravMaguy. Thanks.

please specify what changes you would like me to make and ill do it. do you wish me to:
a. remove the changes made to the certification projects, or
b. make similar changes to duplicate certification projects
if option b please specify which challenges you would like me to check for global (ab)use as im not currently aware of a duplicate javascript cert

we need to either remove those tests on the cert projects, or add the tests to the duplicate cert projects.
Recursion isn't a common approach to the certification projects, so either approach is fine to me.

Ok i just went with option A, as I wasnt aware of duplicate challenges. I see them now though, so if youd like me to revert this later I can do it no problem.

Thanks for contributing to freeCodeCamp @KravMaguy 🎉


If this is just an input feature that does not need to be predicted and you are adding it similarly to the other input features such as node type, then it should work. If you are getting nans, it is probably because of a different reason (perhaps the feature has a very bad scale). Is the loss nan even for the very first iteration?

If this is just an input feature that does not need to be predicted and you are adding it similarly to the other input features such as node type, then it should work. If you are getting nans, it is probably because of a different reason (perhaps the feature has a very bad scale). Is the loss nan even for the very first iteration?
If it is not the scale, or something like that, then I am afraid it will be very hard for us to say what me be wrong.

Yeah, it happens in the first iteration.
When I debug it, this error is caused by the minus variance in the normalization of the solid concentration, leading to a Nan standard deviation. I guess the cause of this error is the python float number mechanism. For example, when I input 0.0414, the actual number obtained by the python is 0.04140000005.
Originally posted by @yq60523 in https://github.com/deepmind/deepmind-research/issues/267#issuecomment-1061400898

The minus variance is obtained while normalizing


Rename NullableContextOptions to Nullable

Summary
Rename NullableContextOptions to Nullable.
See also dotnet/roslyn#35901.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: KexyBiscuit sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

See #12417
This PR addresses the changes in the C# Guide.

This is the correct change moving forward, but I have a concern: the Nullable rename has not yet shipped in a .NET Core SDK preview. 3.0.100-preview5-011568 still uses the name NullableContextOptions, so dotnet CLI users might use these new instructions and then see confusing errors (the inverse of the confusing errors that VS 16.2-p1 users see with the old name).

@rainersigwald
Good point.  I'll add more clarifying language in a new PR.


BlynkSimpleEsp8266.h does not exist

I'm using NodeMCU board and "Blynk Blink" example. Arduino IDE is showing statement:
C:\Users\PaweĹ‚\AppData\Local\Temp\arduino_modified_sketch_384200\sketch_jan19a.ino:39:32: fatal error: BlynkSimpleEsp8266.h: No such file or directory
I've downloaded and unziped Blynk library.

I have the same problem, an Arduino Nano with esp2866. The code from the Website generated, but it print this error every time! And I have searched after the file: it exists!

Blynk Blink example won't compile.Keeps getting Error.

please consult our community forum for such questions: https://community.blynk.cc/


🐛 Redis parser throwing an error every 1 hour

Issue

Issue type:*

[x] bug report
[ ] feature request
I'm getting the following error every 1 hour in production and I wasn't able to reproduce it locally
{ AbortError: Fatal error encountered. Command aborted. It might have been processed.
    at RedisClient.flush_and_error (/.../node_modules/redis/index.js:297:23)
    at JavascriptRedisParser.returnFatalError (/.../node_modules/redis/index.js:148:18)
    at handleError (/.../node_modules/redis-parser/lib/parser.js:196:10)
    at parseType (/.../node_modules/redis-parser/lib/parser.js:304:14)
    at JavascriptRedisParser.execute (/.../node_modules/redis-parser/lib/parser.js:533:24)
    at Socket.<anonymous> (/.../node_modules/redis/index.js:218:27)
    at Socket.emit (events.js:315:20)
    at Socket.EventEmitter.emit (domain.js:482:12)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:271:9)
    at Socket.Readable.push (_stream_readable.js:212:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:186:23)
  code: 'NR_FATAL',
  command: 'INFO',
  origin:
   { ParserError: Protocol error, got "\u0015" as reply type byte. Please report this.
       at handleError (/.../node_modules/redis-parser/lib/parser.js:190:15)
       at parseType (/.../node_modules/redis-parser/lib/parser.js:304:14)
     offset: 1,
     buffer: '{"type":"Buffer","data":[21,0,0,0,2,1,0]}' } }

My Redis is on AWS elasticach Redis cluster.
This Redis is only used by my DB ORM TypeORM, you can find more details about the configuration here

Environment

Node.js Version: 12.18.1

Redis Version: 3.x ==> 3.0.2

Platform: Amazon Linux on EBS

@AdelUnito Did you manage to resolve this? Have you updated node-redis version? We're looking at a similar issue now.

@AdelUnito Did you manage to resolve this? Have you updated node-redis version? We're looking at a similar issue now.

Hi @philwhln, Unfortunately, no I didn't manage to resolve it. I've disabled caching from typeORM to avoid this issue.

@AdelUnito Thanks! I've managed to get to the bottom of our issue. It's was related to TLS settings not property configured in one area of the code. \u0015 was coming back in the handshake, but the code was not expecting TLS.

@AdelUnito Thanks! I've managed to get to the bottom of our issue. It's was related to TLS settings not property configured in one area of the code. \u0015 was coming back in the handshake, but the code was not expecting TLS.

@philwhln Thanks for sharing. I hope it will help someone with the same issue


AbsentOrWrongFileLicense doesn't take into account test files

Expected Behavior
AbsentOrWrongFileLicense rule should take into account test files (src/test/kotlin/**/*.kt).
Observed Behavior
The rule doesn't detect missing license preamble even if I explicitly call detektTest (I'm aware of https://github.com/detekt/detekt/issues/2956).
Steps to Reproduce
Custom config:
comments:
  AbsentOrWrongFileLicense:
    active: true
    licenseTemplateFile: license.template

Gradle config:
detekt {
    buildUponDefaultConfig = true
    config = files("$projectDir/detekt-custom-config.yml")
}

I'll publish a link to my open-source project once the project is public :)
Context
I'm working on covering legal requirements to publish an open-source library from my company. I found it when adding this preamble to existing files, and Detekt didn't complain about missing preamble in some test file.
This bug can have potentially legal implications.
Your Environment

Version of detekt used: 1.16.0
Version of Gradle used (if applicable): 6.8
Operating System and version: Ubuntu 20.04.2 LTS
Link to your project (if it's a public repository): will be public within several days

Hi. By default, detekt does not contain test sourceSet, comment rules exclude test folder.
So, to achieve this, modify it like this:
config
comments:
  excludes: []
  AbsentOrWrongFileLicense:
    active: true
    licenseTemplateFile: license.template

gradle
detekt {
    buildUponDefaultConfig = true
    config = files("$projectDir/detekt-custom-config.yml")
    input = files(
        "$projectDir/src/main/",
        "$projectDir/src/test/",
    )
}

Running detektTest and the configuration pointed by @zmunm should work too. And the last version of detekt includes test source set by default (the current RC) so even the Detekt task will include those by default.
Anyway, we should probably remove that exclude for this rule...

Thanks, adding excludes: [] worked. However I agree with @BraisGabin it would be safer to not exclude anything in this rule. I was close to not spotting this issue, which worst case might have legal consequences for my company.


How to use with AWS Lambda (ie. w/o env vars)?

AWS Lambda does not support environment variables:
http://stackoverflow.com/questions/36230545/how-can-i-use-environmental-variables-on-aws-lambda/
Is there some other way to configure debug that would work with Lambda?
Or is there some other module like debug that works with Lambda?

@GitTom why can't you use dotenv ? .env files are supported pretty much anywhere, and it can load your environment variables to process.env.*,

Good suggestion.  Looking more closely I see that node-lambda (a module for testing and deploying lambda functions) uses dotenv itself, and from it's docs it looks like it uses it to load stuff into process.env.  I'm a little confused about how that jives with the assertion that lambda doesn't support environment variables which I've seen in a few places, but that's just academic now.
http://stackoverflow.com/a/37033620/150016

I'm using Apex, which supports using environment variables with Lambda. It just creates a small wrapper around your lambda handle that sets variables on process.env:

try {
  var config = require('./.env.json')
  for (var key in config) {
    process.env[key] = config[key]
  }
} catch (err) {
  // ignore
}

exports.handle = require('./index').handle

See https://github.com/visionmedia/debug/issues/370.  Closing

For the record, AWS Lambda recently added support for environment variables.

@GitTom how did you specify the variables? I can't get debug to turn on regardless of what I set in the AWS console.

@johnelliott I'm configuring debug module via the Lambda env variables.  On the code tab of my lambda configuration, in "Environment variables" section, I added 'DEBUG' with value '*'.
Looking around I see that I also have a line "DEBUG=*" in my deploy.env file for node-lambda, and then in my .env file I have "CONFIG_FILE=deploy.env".

Thanks @GitTom for replying.
I did a bit of a debug-ectomy on my function for now.  I tried setting DEBUG in the AWS console as you mentioned and manually setting process.env.DEBUG in my code. Neither of those worked, so I'll have to give it another shot some time. Thanks 👍

how do you set environment variables from .env file in following syntax?
aws lambda create-function \     --environment Variables= \

For posterity: Lambda@Edge functions don't support environment variables, so dotenv or similar is the only way to go for those.


sample: bluetooth: beacon: USAGE FAULT after few seconds on board b_l4s5i_iot01a

Describe the bug
sample/ bluetooth: beacon crashes on b_l4s5i_iot01a board with USAGE FAULT after about 20 seconds of execution
To Reproduce
Steps to reproduce the behavior:

west build -p auto -b b_l4s5i_iot01a  samples/bluetooth/beacon/
west flash
See error

Logs and console output

*** Booting Zephyr OS build zephyr-v2.5.0-2661-g45418dedc0bd  ***
Starting Beacon Demo
Bluetooth initialized
Beacon started, advertising as DA:2A:C2:FC:65:8E (random)
[00:00:00.000,000]  spi_ll_stm32: CS control inhibited (no GPIO device)
[00:00:00.008,000]  bt_hci_core: Identity: DA:2A:C2:FC:65:8E (random)
[00:00:00.008,000]  bt_hci_core: HCI: version 4.1 (0x07) revision 0x3107, manufacturer 0x0030
[00:00:00.008,000]  bt_hci_core: LMP: version 4.1 (0x07) subver 0x0023
[00:00:01.000,000]  os: ***** USAGE FAULT *****
[00:00:01.000,000]  os:   Illegal use of the EPSR
[00:00:01.000,000]  os: r0/a1:  0x00000000  r1/a2:  0xe000ed00  r2/a3:  0x20000b0c
[00:00:01.000,000]  os: r3/a4:  0x20000460 r12/ip:  0x20676e69 r14/lr:  0x080056bd
[00:00:01.000,000]  os:  xpsr:  0x60000000
[00:00:01.000,000]  os: Faulting instruction address (r15/pc): 0x00000000
[00:00:01.000,000]  os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
[00:00:01.000,000]  os: Current thread: 0x20000460 (unknown)
[00:00:01.005,000]  os: Halting system

Environment (please complete the following information):

OS: Windows
Toolchain gnuarmemb
Commit SHA 45418dedc0bde40d69b61dbfa6c0449f1098aba8

I found that doubling spi_rx_stack (in file ...\zephyr\drivers\bluetooth\hci\spi.c) fixes the issue
static K_KERNEL_STACK_DEFINE(spi_rx_stack, 512);
But strangely, there is no issue with board nucleo_wb55rg.
So I am not sure increasing stack is the right fix.

^^ @joerchan @jhedberg @Vudentz

@ABOSTM Can you please enable the thread analyzer and report the stack usage for both boards. Run it with the increased stack size that you set, so that we don't get a crash.
Configurations to enable thread analyzer.
CONFIG_THREAD_NAME=y
CONFIG_THREAD_ANALYZER=y
CONFIG_THREAD_ANALYZER_AUTO=y
CONFIG_THREAD_ANALYZER_RUN_UNLOCKED=y
CONFIG_THREAD_ANALYZER_USE_PRINTK=y

I don't know these boards, what kind of architecture are they?
Can you compare the default board configurations to see if there is additional features selected?

@joerchan, thanks for your quick answer.
Let's forget about nucleo_wb55rg: it is a dualcore with Cortex M0 dedicated to BLE ... with shared memory. So no hci over spi.
b_l4s5i_iot01a has an STM32L4S5VIT6 chip based on Cortex M4.
It embed a Bluetooth (V4.1 compliant) SPBTLE-RF module, connected to Cortex M4 through SPI.
Below the log of b_l4s5i_iot01a with thread analyzer (and increased stack), please note that thread analyse come just after reset whereas USAGE FAULT comes after about 20 secondes of execution.
*** Booting Zephyr OS build zephyr-v2.5.0-2661-g45418dedc0bd  ***
Starting Beacon Demo
Thread analyze:
 0x20000620  Bluetooth initialized
Beacon started, advertising as F7:40:5E:58:FE:9F (random)
        : STACK: unused 328 usage 184 / 512 (35 %); CPU: 1 %
 BT RX               : STACK: unused 872 usage 152 / 1024 (14 %); CPU: 0 %
 BT TX               : STACK: unused 216 usage 200 / 416 (48 %); CPU: 14 %
 thread_analyzer     : STACK: unused 120 usage 392 / 512 (76 %); CPU: 1 %
 sysworkq            : STACK: unused 240 usage 784 / 1024 (76 %); CPU: 49 %
 logging             : STACK: unused 656 usage 112 / 768 (14 %); CPU: 0 %
 idle 00             : STACK: unused 288 usage 32 / 320 (10 %); CPU: 0 %
[00:00:00.000,000] <inf> spi_ll_stm32: CS control inhibited (no GPIO device)
[00:00:00.009,000] <inf> bt_hci_core: Identity: F7:40:5E:58:FE:9F (random)
[00:00:00.009,000] <inf> bt_hci_core: HCI: version 4.1 (0x07) revision 0x3107, manufacturer 0x0030
[00:00:00.009,000] <inf> bt_hci_core: LMP: version 4.1 (0x07) subver 0x0023

@ABOSTM With the thread analyzer in AUTO mode (CONFIG_THREAD_ANALYZER_AUTO) it should run the analyzer once every 60 second (by default, can be changed with THREAD_ANALYZER_AUTO_INTERVAL).
Can you get the thread analyzer values once it has had a chance to run for a while?
For convenience, could you also add a name to the thread.
--- a/drivers/bluetooth/hci/spi.c
+++ b/drivers/bluetooth/hci/spi.c
@@ -521,6 +521,7 @@ static int bt_spi_open(void)
                        (k_thread_entry_t)bt_spi_rx_thread, NULL, NULL, NULL,
                        K_PRIO_COOP(CONFIG_BT_DRIVER_RX_HIGH_PRIO),
                        0, K_NO_WAIT);
+       k_thread_name_set(&spi_rx_thread_data, "BT SPI RX");

Here it is:
Thread analyze:
 BT SPI RX           : STACK: unused 216 usage 296 / 512 (57 %); CPU: 0 %
 BT RX               : STACK: unused 872 usage 152 / 1024 (14 %); CPU: 0 %
 BT TX               : STACK: unused 216 usage 200 / 416 (48 %); CPU: 0 %
 thread_analyzer     : STACK: unused 128 usage 384 / 512 (75 %); CPU: 0 %
 sysworkq            : STACK: unused 240 usage 784 / 1024 (76 %); CPU: 0 %
 logging             : STACK: unused 288 usage 480 / 768 (62 %); CPU: 0 %
 idle 00             : STACK: unused 272 usage 48 / 320 (15 %); CPU: 99 %

By the way, with THREAD_ANALYZER_AUTO_INTERVAL=5 ... it took about 1,5 minutes to get a Thread analyze update.


Enrich arm64 tests in Travis matrix

1, Remove simple test just with --strict-warnings enabled.
2, Share the three common envs with amd64.
3, Add matrix item running test in bionic(default xenial) for arm64.
4, Enable MSan test on arm64 for extended test.
5, Enable UBSan test on arm64 for extended test.

I've run the extended tests, they all past. See https://travis-ci.org/zorrorffm/openssl/builds/616997290

Yes for both branches.

Some of the extended tests did fail due to timeout, I manually restarted those jobs to check if it is just a spurious problem.

And while I would like this to go to 1.1.1 as well, I am not sure that cherry-picking will be entirely trivial.

The label is there to indicate the intent.  If it turns out that a cherry pick is hard, it's always possible to submit a backport PR

The extended tests suppose to exit with 0. I have no idea why they failed.  Would someone help on this?

The extended tests suppose to exit with 0. I have no idea why they failed. Would someone help on this?

It looks like the travisci issue on arm64.   See link:  https://travis-ci.community/t/exit-0-cannot-exit-successfully-on-arm/5731/6

As soon as #10561 is merged, this should go in.

Merged.
77fedcdc8cf5446354a1e7ff9123d8ada5b79b06 Enrich arm64 tests in Travis matrix

Almost forgot!
1.1.1:
7a930005adc470ffaa49dbef04010e77d76e0363 Enrich arm64 tests in Travis matrix


Why do you build both to es and dist?

Hi, what is the thinking behind build:es and build:commonjs? I'm trying to wrap my head around the config and understand why it is done.
kind regards,
Tarjei

So you can import the es modules or commonjs modules from another package. For instance, I share some components between web apps and react-native apps.

Aha! Thanks :)
2017-04-20 18:45 GMT+02:00 Jared Lunde<EMAIL_ADDRESS>
So you can import the es modules or commonjs modules from another package.
For instance, I share some components between web apps and react-native
apps.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaredlunde/webpack2-react-sass-env-boilerplate/issues/3#issuecomment-295808696,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAM5P27EXDgak83W9p43N993LW_avaowks5rx4u1gaJpZM4NCzhT
.

--

Tarjei Huse
Mobil: 920 63 413


AttributeError: 'UserObject' object has no attribute 'lower'

Running this against my draw.io file I get this output:
./materialize-threats --diagram=/Users/tlarkin/Documents/casec\ stuff/casec-1611/dfd.drawio
Traceback (most recent call last):
  File "./materialize-threats", line 8, in <module>
    sys.exit(ThreatMaterializer.materialize())
  File "/Users/tlarkin/material-threats/env/lib/python3.8/site-packages/materialize_threats/materialize.py", line 116, in materialize
    zones = dbgraph.get_node_trust_zones_from_graph(graph)
  File "/Users/tlarkin/material-threats/env/lib/python3.8/site-packages/materialize_threats/db/dbgraph.py", line 43, in get_node_trust_zones_from_graph
    zone = UserObject.get_trust_zone_from_node_label(orphan.value)
  File "/Users/tlarkin/material-threats/env/lib/python3.8/site-packages/materialize_threats/mx/models/UserObject.py", line 33, in get_trust_zone_from_node_label
    zone = label.lower().split(cls.ZONE_PREFIX)[cls.ZONE_INDEX]
AttributeError: 'UserObject' object has no attribute 'lower'

My Python venv:
% python3 -V
Python 3.8.5
% pip3 list
Package             Version
------------------- -------
attrs               20.2.0
gherkin-official    4.1.3
iniconfig           1.0.1
materialize-threats 1.0.4
packaging           20.4
peewee              3.13.3
pip                 20.1.1
pluggy              0.13.1
py                  1.9.0
pyparsing           2.4.7
pytest              6.1.0
setuptools          47.1.0
six                 1.15.0
toml                0.10.1

If you need more info I can provide the file too.  Thanks!

This issue is mostly resolved.
The exception happens because the diagram parser would find the trust boundary, not be able to get the trust zone of it, and break. The diagram parser can now examine objects it doesn't expect to see (e.g. trust boundaries and STRIDE labels) and discard them without breaking, continuing to parse the rest of the diagram.
If you hadn't run into that issue, you would have found two other issues: you have data flowing between entities without an intermediary process, and you have bidirectional flows. Those issues are still extant in the code, but are easy to correct by hand if you know they exist - I added some details to the readme to clarify what a correct (parseable) DFD should look like.
With a slightly redrawn diagram to fix those issues, it parses correctly and without issue. I'm going to close this issue and open two more to address the outstanding problems in the future.


Unrecognized 'num-gen-tokens' Argument in model_args.json During Model Checkpoint Pruning

Hi Again,
I'm attempting to prune the model's checkpoints using the provided script. I'm curious to know about the "num-gen-tokens" parameter in the model_args.json file.
It seems there's no corresponding argument passed to or found in the model under that name. Therefore running the "prune_model_ckpt.py" fails.

Hi, thanks for pointing this out! This is a typo and it should be num_tokens -- I think this was an artifact left from early in development. I believe 8216fea47f7c8040aa51154547161bd35cef7124 should fix this, but please let me know if not.

That's what I was thinking too :)
Also, loading a new trained model, for training the decision classifier fails in the "TrainDecisionClassifier" fails too. It is due to the assertion error on line 45 of models.py, saying:
AttributeError: 'args' object has no attribute 'text_emb_layers'
There are 3 arguments that are not saved in the model_args.json file (compared to provided json file in the repo) after conducting a training:
"text_emb_layers": [
-1
],
"share_ret_gen": true,
"norm_image_embed": "none"
I think this is the reason.
P.s: I am just trying to train the model with a different LLM and rerunning all the scripts

Thanks! This is helpful. The other arguments are not used, but text_emb_layers is, so we need it to be saved in the model_args.json file. Oddly enough it doesn't seem to be saved here, even though it's part of model_args. I guess we can explicitly add it, since there's no command line flag to change text_emb_layers in main.py: 6b183ac32bff6c15e8d0c7434e11e638832487cc
Sorry about that, text_emb_layers was something used for debugging and I didn't remove it completely in the final version. I think with your newly trained LLM, you can also edit the .json to set "text_emb_layers": [-1] and it should work fine. Hope that helps!

Of course :) adding "text_emb_layers": [-1] explicitly worked actually, thanks!
I see that the "share_ret_gen" is used here , but I guess it's not affecting anything.
thanks anyways.


Slate to ciceroMark transform sometimes omits nodes

Describe the bug
Some nodes disappear in the Slate to CiceroMark transform.
To Reproduce
Steps to reproduce the behavior:

Use the attached acceptance.txt file (which contains JSON)
acceptance.txt
Execute: markus draft --slate --data acceptance.txt
Result is:

Acceptance of Delivery.
----

Inspection and Notice.
----

Acceptance Criteria.
----

The "Acceptance Criteria" are the specifications the <variable id="deliverable" value="%22Widgets%22"/>
must meet for the <variable id="shipper" value="%22Party%20A%22"/> to comply with its requirements and
obligations under this agreement, detailed in <variable id="attachment" value="%22Attachment%20X%22"/>, attached
to this agreement.

Instead of the expected:
Acceptance of Delivery.
----

<variable id="shipper" value="%22Partry%20eeA%22"/> will be deemed to have completed its delivery obligations
if in <variable id="receiver" value="%22Party%20B%22"/>'s opinion, the <variable id="deliverable" value="%22Widgets%22"/> satisfies the
Acceptance Criteria, and <variable id="receiver" value="%22Party%20B%22"/> notifies <variable id="shipper" value="%22Party%20A%22"/> in writing
that it is accepting the <variable id="deliverable" value="%22Widgets%22"/>.

Inspection and Notice.
----

<variable id="receiver" value="%22Party%20B%22"/> will have <variable id="businessDays" value="10"/> Business Days to inspect and
evaluate the <variable id="deliverable" value="%22Widgets%22"/> on the delivery date before notifying
<variable id="shipper" value="%22Party%20A%22"/> that it is either accepting or rejecting the
<variable id="deliverable" value="%22Widgets%22"/>.

Acceptance Criteria.
----

The "Acceptance Criteria" are the specifications the <variable id="deliverable" value="%22Widgets%22"/>
must meet for the <variable id="shipper" value="%22Party%20A%22"/> to comply with its requirements and
obligations under this agreement, detailed in <variable id="attachment" value="%22Attachment%20X%22"/>, attached
to this agreement.

Fixed in #146


Add missing code documentation

The code is missing required comments, above methods.
Please add comments for:

useCubit
useCubitBuilder
useCubitListener
useActionListener
HookedBloc

there is new branch called documentation/code-documentation please create PR's with documentation to this branch.

I have took: useCubit

1.0.2


getting errors when input is not in DOM

Hey,
when i create constant of datepicker and the specified input field (el) is not in the dom tree yet, i get an error.
Is it possible to change this behaviour? We would like to use the datepicker for multiple inputs and buttons.
Or is it even possible to create a constant/picker without specifieng the input element (el)?
Or should i use hidden input fields for this?!
Would be great if you could add some examples and your opinion for this :)

Hey,
The el config option is the only option that is required. The MCDatepicker uses it to find an element in the DOM tree with the specified id and apply a listener to it that makes the calendar appear.
I could actually make it optional, so you could handle the triggers by yourself.

That would be great :)

hey man, i dont want you make trouble, but how's the progress on this an the other issues?
I am for my self not so familiar with js, i know how to use jQuery and thats all :D

Hey Luis,
Actually, I've solved both of them some time ago, but i was working on new features and wanted to merge them in one version.

Hey,
very nice to hear. I am very excited for the new version :)

Hey Luis,
this issue is fixed in the last version!

nice to hear, will try out soon :)


No control over image naming

Hi, thank you for this library but I have an issue. I want to save an image with a custom filename so that I can overwrite over and over again. My implementation is for a profile picture, each time a user takes/picks a picture and crops it, a new copy will be saved to the cache and eventually after 20 profile changes the app would’ve cache about 20 MB!! I could tell them to clear the cache but that isn’t really ideal for a good user experience.
saveDir(parentPathCache, “photo.jpg/“)
Doesn’t give expected results, it will append to it like:
file://somePath/cache/photo.jpg/IMG_2020_4646474848.jpg
Which isn’t what I expected.

I’ve figured out something temporarily, I clear the folder when setting a new picture. Like:
fun pickPhoto() {

runCatching {
val myCacheDir = File(cacheDir+”/my_pics”)
myCacheDir.deleteRecursively()
}

ImagePicker.withGallery()
.storageDir(myCacheDir)
.start(123)

}

@southerndevz Thank you so much for providing the alternate solution. I will explore the option to allow image naming over the weekends.

Hey! Your library is awesome. I need to choose the image name too! Do you have any expectations in releasing this feature?

I've figured out a way to change the file name on OnActivityResult.
      File file = ImagePicker.Companion.getFile(data);
  File newFile = new File(directory, "newFileName");
file.renameTo(newFile);


CMD+D should be smarter

VSCode Version: 1.4.0-insiders
OS Version: OSX

Steps to Reproduce:

Create file with:

test
TEST
Test
aTesTer
test-123
test234
test

Put cursor at position 1:1 and press CMD+D 7 times
VS Code selects:

It should only select next matches using case sensitivity and whole words
Here is Atom result for the same:

FYI, Sublime Text utilise the settings from Find panel in order to match these words.

@wallverb cmd+d respects the find widget settings which can be toggled via keyboard (match whole word, case sensitivty)

I recommend that VSCode adopt the behaviour that Atom has, and which I believe Sublime also has: If you don't start with a selection, then whole-word matching is implicit.
For example: If I have the cursor at the beginning of the word "foo", then cmd-D will only match whole-word instances of "foo". If I select "foo", then cmd-D will match any substring.
This is extremely convenient as a shorthand.
FWIW, I personally find the feature where cmd-D respects the Find panel's case/whole-word settings to be quite exhausting. The setting I need is usually different every time I need to use cmd-D. I continually have to hit cmd-alt-c, cmd-alt-w in order to toggle these (and I rely on cmd-D a lot). My above suggestion will reduce the necessary keypresses to just one key, which would help greatly.

This behavior is the only thing keeping me from switching to VS Code. It's unfortunate when I decide to rename a variable like i and it starts selecting random I's in the middle of other words. It ruins the refactor use-case of multiple cursors.

Indeed. Replying to myself to make another important point:

The setting I need is usually different every time I need to use cmd-D.

...and it's exacerbated by the fact that you don't know what the case/word toggles are set to unless you hit cmd-F. Almost every time I use the cmd-D feature, not only are the toggles wrong, but I have to do a cmd-F just to see what the toggles are set to.

The new version (1.9) semi-addresses the problem by making the toggle states visible when using Ctrl+D, but I don't see why these states are shared with the search functionality at this point. Doing this has probably added more complexity when compared to Sublime's behavior as described by @atombender

Isn't this already addressed?
You'll need to toggle Match case and Match whole words option:

Then it'll work as expected:

I'm pretty sure that sublime also behaves this way

@jameslieu: No, Sublime does not work that way. Read my explanation. Sublime always uses whole-word matching unless you explicitly make a selection before hitting cmd-D. It's a superior workflow and reduces the need for a whole-word toggle for cmd-D.
@alexandrudima: Looks to me like this issue is being ignored. Any way we can move it forward?

I believe this is resolved with PR #36682 (for #8869) . When starting with a collapsed selection, Command+D will now search with wholeWords: true and caseSensitive: true.


Feedback Page and Login Page fixed

Feedback Page and Login Page  fixed  and: #469

Title :
Issue No. :#469
Code Stack :
Close #469
https://github.com/apu52/Travel_Website/assets/137484958/fe29cfb1-261a-43ec-a261-d58db399f808

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

hi @apu52
i corrected both page feedback and login page
I see that there was issue in linking the styles file
now it is all correct

and also Navbar of both page is working properly

Hi @apu52
i have created another new PR with all correct changes please assign me

hey @apu52
conflict can be resolved here only
please reopen the PR?