Rate limit plugin doesn't work with go 1.20 without an env variable set

The issue is very similar to #8 which fixed for go1.19 but not go 1.20:
caddy
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.20 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20 set. Notably, if go1.20 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	go4.org/unsafe/assume-no-moving-gc@v0.0.0-20220617031537-928513b29760/untested.go:25 +0x1ba

I have this problem, too.
Unfortunately, I don't know the Go tooling at all, so I'll ping in here and hope that someone will look at this. 🙂

I'm also facing this issue, sadly :(

Sorry for the late reply. I have submitted a PR #16, much appreciated if anyone can give it a try :)

@RussellLuo I added the module using the caddy add-package, but it looks like the problem persists?
love4taylor@au-tokyo-n1:~$ caddy version
v2.6.4 h1:2hwYqiRwk1tf3VruhMpLcYTg+11fCdr8S3jhNAdnPy8=
love4taylor@au-tokyo-n1:~$ sudo caddy add-package github.com/RussellLuo/caddy-ext/ratelimit
2023/05/01 10:15:58.989	INFO	this executable will be replaced	{"path": "/usr/bin/caddy"}
2023/05/01 10:15:58.989	INFO	requesting build	{"os": "linux", "arch": "amd64", "packages": ["github.com/RussellLuo/caddy-ext/ratelimit", "github.com/caddy-dns/cloudflare", "github.com/caddy-dns/dnspod", "github.com/mholt/caddy-webdav", "github.com/WeidiDeng/caddy-cloudflare-ip"]}
2023/05/01 10:15:59.384	INFO	build acquired; backing up current executable	{"current_path": "/usr/bin/caddy", "backup_path": "/usr/bin/caddy.tmp"}
2023/05/01 10:15:59.384	INFO	downloading binary	{"destination": "/usr/bin/caddy"}
2023/05/01 10:16:01.105	INFO	download successful; displaying new binary details	{"location": "/usr/bin/caddy"}

Module versions:

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.20 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20 set. Notably, if go1.20 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	go4.org/unsafe/assume-no-moving-gc@v0.0.0-20220617031537-928513b29760/untested.go:25 +0x1ba
Error: download succeeded, but unable to execute 'caddy list-modules': exit status 2
love4taylor@au-tokyo-n1:~$

@RussellLuo Maybe you should create a new tag? Even if I compile with xcaddy + go 1.20, if I don't add @master  at the end and it defaults to the v0.2.0 tag, the error will still be there.

Hi @love4taylor, ratelimit/v0.3.0 has been released.

@RussellLuo It's strange. Now xcaddy is fine, but caddy add-package still doesn't work with the same error. I found a "Rescan" button on caddyserver.com dashbord, maybe because of caching?

@love4taylor I just rescanned the package, could you please check if it's okay now?


feat: use algolia search

🚀 Deployed on https://66ec76ec8ec8bf4566d1873e--cozy-fox-0defec.netlify.app


Avoid Bridge.fn.cacheBind from delegate parameters in a TemplateAttribute

Hello,
I'm trying to replace a delegate with another one, but when I use a delegate in the TemplateAttribute, it gets replaced by Bridge.fn.cacheBind(...).
So... Is there a way to access the parameter name in the template, ignoring the Bridge.fn.cacheBind stuff? If not, I think it would be a good improvement. Having to set a template for each function (like set_onsapenter) or passing the method name as a string feels bad.
Steps To Reproduce
https://deck.net/29b47874d7f0afdfe925199b371fb61c
public class Program
{
    public static void Main()
    {
        sapmInput a = new sapmInput();

        Globals.RedefineJQueryEvent(a.onsapenter, (jquery.JQuery.Event obj) => {
            dom.window.alert("HI!");
        });

        a.set_onsapenter(a.onsapend, (jquery.JQuery.Event obj) => {
            dom.window.alert("HI!");
        });
    }
}

[External]
public class sapmInput
{
	public extern virtual void onsapenter(jquery.JQuery.Event oEvent);
    public extern virtual void onsapend(jquery.JQuery.Event oEvent);
}

[External]
public static class Globals
{
    [Template("{eventToRedefine} = {newEventHandler}")]
     public extern static void RedefineJQueryEvent(Action<jquery.JQuery.Event> eventToRedefine, Action<jquery.JQuery.Event> newEventHandler);

    [Template("{input}.onsapenter = {newEventHandler}")]
    public static extern void set_onsapenter(this sapmInput input, Action<jquery.JQuery.Event> eventToRedefine, Action<jquery.JQuery.Event> newEventHandler);
}

Expected Result
/**
 * @compiler Bridge.NET 17.2.0
 */
Bridge.assembly("Demo", function ($asm, globals) {
    "use strict";

    Bridge.define("Demo.Program", {
        main: function Main () {
            var a = new Demo.sapmInput();

            a.onsapenter = function (obj) {
                    window.alert("HI!");
                };

            a.onsapenter = function (obj) {
                    window.alert("HI!");
                };
        }
    });
});

Actual Result
/**
 * @compiler Bridge.NET 17.2.0
 */
Bridge.assembly("Demo", function ($asm, globals) {
    "use strict";

    Bridge.define("Demo.Program", {
        main: function Main () {
            var a = new Demo.sapmInput();

            Bridge.fn.cacheBind(a, a.onsapenter) = function (obj) {
                    window.alert("HI!");
                };

            a.onsapenter = function (obj) {
                    window.alert("HI!");
                };
        }
    });
});

Hello @emumamu! This happens because the Action you are passing is not static and is not an extension method. But, if you specify a template to it, it still passes something wrapped on code.
I simplified your deck down to this, all the other code and references really made it difficult to follow.
https://deck.net/9842bac74b66145c3135126e10a3de7b
But yet, couldn't find a way to do this. An approach to get this output given the context you provided might be possible; just need not to break whenever else it is called. To me, for what you want to accomplish (replace an instance method, which is not possible in C#), you're better off using the string approach, at least for the time being.

Hello @fabriciomurta!
thank you for taking a look at this one.
Hopefully it could be added in the future. For a couple of cases, the string approach is fine. But if you have to do it with a lot of cases, it gets a bit ugly.
I tweaked more the example for future tests:
https://deck.net/c017c8778d7328dfea74e069c9113942

Okay, seems you missed calling the actual test to the breaking situation.
This is a hack you can use, would help assess whether just dropping away the Bridge.fn.cacheBind won't break other everyday usage of the calls to that replacing methods.
https://deck.net/08a8d62159a6bb85611be1e3228e774c

@fabriciomurta, Thank you for that kludge. Even if it is ugly, it helps.


Convert network exceptions to info logs.

most network exceptions are not errors, they do not represent exceptional behavior (for example timeouts are possible) and do not cause the application to malfunction.
grpc service: avoid throwing unnecessary exception when the peer is already removed from the pool.

network is not stable，so maybe just Info，not Warn

:white_check_mark: Build AElf <IP_ADDRESS>85 completed (commit https://github.com/AElfProject/AElf/commit/66d0bbe242 by @samfrb)

:x: Build AElf <IP_ADDRESS>93 failed (commit https://github.com/AElfProject/AElf/commit/822d0d80d2 by @rosona)


Add rudimentary auditing

No information is saved whatsoever in the long run. As soon as a database is dropped for example, all of its data is lost. This makes it harder to make decisions based on usage statistics for example (see #210)

Migrated to new repository


Removing support for v13.

Change-Id: Iaac1e2358b6ec40d71e01bce25fe581a6d9d1f80

Kokoro failure is expected (we're working on fixing the environment). Tests ran locally and passed.
Finished in 0.226892s, 334.9617 runs/s, 806.5526 assertions/s.
76 runs, 183 assertions, 0 failures, 0 errors, 0 skips


Add Clear() to IConfigurationBuilder

This will make it possible to remove all registered providers and start over.  Specifically, when using WebHost.CreateDefaultBuilder(), this would allow application code to change all previously configured options without losing the other benefits of calling that method.
/cc @glennc @divega @DamianEdwards @ajcvickers @HaoK

Love it. Are there equivalents on the other builders we should also consider?

For the behavior, would Clear only clear the config sources, or also clear the Properties metadata that stores the base path/default file provider as well?
Maybe we should just change Sources to be an IList<IConfigurationSource> instead of IEnumerable, so people can clear/rearrange as desired, they already can modify Properties directly since its exposed as an Dictionary<string, object> Properties (??) already

I think the past maybe we had special logic in Add, but its just a straight add now, so there's nothing that prevents us from exposing the ability for people to directly add to the sources
https://github.com/aspnet/Configuration/blob/dev/src/Microsoft.Extensions.Configuration/ConfigurationBuilder.cs#L38

Maybe it should implement IList or ICollection

We discussed this in triage and we want Sources to be an IList<IConfigurationSource>

@HaoK This is fixed right?

Yup, fixed via 6b4f1f863475ec74ef06c64352b58d600807a832

builder.Sources.Clear()

Amazing, just had a case to use this 🎉 Thanks for changing this!


Cannot find dotnet on Ubuntu

Error message:
$ dotnet outdated
Analyzing project(s)...Unhandled exception. System.ComponentModel.Win32Exception (2): An error occurred trying to start process '/usr/lib/dotnet/dotnet6-6.0.108/dotnet'
Some system info:
$ dotnet --version
6.0.402
$ dotnet --info
.NET SDK (reflecting any global.json):
Version:   6.0.402
Commit:<PHONE_NUMBER>
Runtime Environment:
OS Name:     ubuntu
OS Version:  22.04
OS Platform: Linux
RID:         ubuntu.22.04-x64
Base Path:   /usr/share/dotnet/sdk/6.0.402/
global.json file:
Not found
Host:
Version:      6.0.10
Architecture: x64
Commit:       5a400c212a
.NET SDKs installed:
6.0.402 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.10 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.10 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Download .NET:
https://aka.ms/dotnet-download
Learn about .NET Runtimes and SDKs:
https://aka.ms/dotnet/runtimes-sdk-info

It looks like it has some old/wrong path coming from somewhere (/usr/lib/dotnet/dotnet6-6.0.108/dotnet) but I don't know where it finds that and all other dotnet usage seems to be working as normal.

Problem was lingering wrong DOTNET_TOOL env var on my system.

Specifically /etc/profile.d/dotnet.sh is setup by the Canonical packages and not removed using conventional methods.


[BUG] Error at compilation with overflowcheck(True).

Describe the bug
I get an error at compilation when using overflowcheck(True) with 3.0.0b2.
Prior version worked well.
Code to reproduce the behaviour:
%%cython --cplus

cimport cython

@cython.overflowcheck(True)
cdef size_t _mul_checked(size_t a, size_t b) except? -1:
    return a * b

def f(size_t[:] a, size_t[:] b):
    return _mul_checked(a.shape[0], b.shape[0])

Output:
Content of stderr:
/home/eric/.cache/ipython/cython/_cython_magic_7ec89a75959ed7157c2554d3336a3feedfc6cd9d.cpp:2382:8: error: redefinition of ‘struct __PYX_IS_UNSIGNED_IMPL<T>’
 2382 | struct __PYX_IS_UNSIGNED_IMPL {static const bool value = T(0) < T(-1);};
      |        ^~~~~~~~~~~~~~~~~~~~~~
/home/eric/.cache/ipython/cython/_cython_magic_7ec89a75959ed7157c2554d3336a3feedfc6cd9d.cpp:1329:8: note: previous definition of ‘struct __PYX_IS_UNSIGNED_IMPL<T>’
 1329 | struct __PYX_IS_UNSIGNED_IMPL {static const bool value = T(0) < T(-1);};
      |        ^~~~~~~~~~~~~~~~~~~~~~

Expected behaviour
No response
OS
Linux
Python version
3.10.0
Cython version
3.0.0b2
Additional context
No response

It seems to be unintational that cython includes util twice
but the easy fix of moving __PYX_IS_UNSIGNED_IMPL  into cython module util will help

It seems that msvc does not care about those declarations, probably because they are just duplicates

It seems that msvc does not care about those declarations, probably because they are just duplicates


Close Polygon button in geoshape widget needs better positioning

| type            | name         | label                                          | calculation                                                 |
|        | begin repeat    | item-repeat  | Item                                           |                                                             |
|        | calculate       | item-counter |                                                | position(..)                                                |
|        | calculate       | item         |                                                | instance('item')/root/item[itemindex=${item-counter}]/label |
|        | begin group     | item-info    | Item info                                      |                                                             |
|        | note            | item-note    | All the following questions are about ${item}. |                                                             |
|        | select one item | stock-item   | Do you stock this item?                        |                                                             |
|        | end group       | item-info    |                                                |                                                             |
|        | end repeat      |              |                                                |


refactor(treewide): cleanup and use rgbify mixin

Adds a new hslify mixin to match the functionality of the rgbify mixin (extract color values) - not used yet but I did needeto use it for https://github.com/catppuccin/userstyles/pull/1510. Also simplifies the existing rgbify mixin and inserts it in places where we should be using it (technically might not be the exact same since the comma vs space separated rgb syntax is weird, will have to check).

Sorry for the pings! Not much to look at here, couldn't figure out how to disable them 😓


Please clarify differences between K-9 and Thunderbird in readmes

Checklist

[x] I have used the search function to see if someone else has already submitted the same bug report.
[x] I will describe the problem with as much detail as possible.

App
Thunderbird for Android
App version
8.0
Where did you get the app from?
F-Droid
Android version
12
Device model
No response
Steps to reproduce
There is a k-9 Fdroid app (pointing to thunderbird page), and there is a Thunderbird Fdroid app ("based on k-9"). When I come to the github projects, there's no info on their relationship.
Expected behavior
A statement of what is the relationship between k-9 mail and thunderbird, if one is meant to replace the other, if one became the other but is still maintained for legacy sake, etc.
Actual behavior
No obvious information about what their relationship is with each other. From the point of view of a FOSS user it's very confusing.
Thunderbird FDroid page says: "based on K-9 Mail"
K-9 FDroid page says: "You can find our bug tracker, source code, and wiki at https://github.com/thunderbird/thunderbird-android."
Github of k9 or github of thunderbird, don't explain anything about this.
Is one of them going to be deprecated in the future? Is one of them more up to date? Is one of them taking decisions / features from the other? Is it unidirectional? Bidirectional?
Logs
No response

I could take some info from the FAQ, how about adding this to the K-9 Mail section in the README? The FAQ is already linked from the README, which might provide an alternative.

In June 2022, K-9 Mail joined the Thunderbird family as the foundation for Thunderbird on Android. Since then, we’ve been updating both apps to give users the same solid experience, so it’s normal to notice that K-9 Mail and Thunderbird look and feel nearly identical. They’re built on the same code, and that’s intentional. You'll notice some features are selectively enabled for Thunderbird as opposed to K-9 Mail, usually when they are simply a better fit for Thunderbird (like the import from K-9 functionality).
If you prefer the robot dog and would like to keep K-9 Mail around, you can find it here:

K-9 Mail on Google Play
K-9 Mail on F-Droid


Query with multiple parameters?

I was expecting that if I passed a list in to a Query object, like
class Test(Consumer):
    @get("/test")
    def get(self, key: Query): pass

t = Test(url)
print(t.get(["a", "b"])

That the query would look like /test?key=a,b, but instead uplink encodes this as /test?key=a&key=b. This then leads to the API dropping the extra keys.
How can I pass in queries that have multiple values? I tried doing Query(type=list) but that did not work.

@ifiddes use .join() and pass it as a string


Groove joint behaviour different than default Godot2d physics

Describe the bug
In default Godot 2d physics engine groove joint allows 1 Translation + 1 Rotation.
In rapier groove joint only allows 1 Translation.
To Reproduce
Create groove joint and put it at an angle.
Connect two bodies, one body should naturally rotate depending on their center of mass.
Expected behavior
Body connected as NodeB should be allowed to freely rotate.
Difference
Godot2d:

Rapier:

Environment:

OS: Windows
Version: latest
Godot Version: 4.4 dev 6
Type: 2d

Example project(zip)
rapier-bug-report.zip

This is a bug that should probably be fixed to maintain parity with the default physics engine, but I think that this behavior should be kept in Rapier2D in some way as it allows for behavior that wouldn't be possible without it.
For example, if there were a game with a player character that spins a physically-simulated sword that can also be extended or retracted, then this behavior wouldn't be possible with the joints of the default physics engine. In the default physics engine, GrooveJoint2D doesn't restrict rotation (as you stated); the only Joint2D that can is the PinJoint2D, which also fully restricts translation.
There are unique applications for this "bug" that are only possible because of it. If this is patched out of GrooveJoint2D, I think that it (or a suitable replacement) should remain in some other way, perhaps as a new joint node.

Thats a good point, thanks for the note. If this is fixed, there will be a flag to set this behaviour, eg.:
RapierPhysicsServer.joint_set_flag(joint_rid, ..., true)
Or something like that. But by default it would have to be the default way godot does it now. Maybe in the future, if godot offers the option, I will expose this to the editor too.


[notifications] Changing the role shows notification "added to space"

Steps to reproduce

Create a space
Add another member as "space admin"
change own role to "editor"

Expected behaviour
No notification gets shown
OR
Notification "{username} changed your role to "editor" gets shown
Actual behaviour
Notification "{username} added you to space {spacename}" gets shown

Environment general
https://ocis.ocis-wopi.latest.owncloud.works

I moved the issue to the oCIS repo because notifications (including the texts) come from the server - Web just displays them.
cc @kobergj

Uh this is a difficult one. On the server we do not differentiate between role changed and added to space. Both is a space shared event for us.  We'd need to send different events on space shared and space share updated which might be problematic


Add ISNULL(expr) and compatible with Navicat Premium

When I use Navicat Premium 15.0.28 to design tables.
Get error: 1105 - function: 'isnull, maybe you mean ifnull?' not found
After I implement ISNULL(expr).
Get error: 1105 - column "PARTITION_DESCRIPTION" could not be found in any table in scope
This RP is fixed this problem.

@zachmu  Deleted partition_descriptor.


how to preload images with webpack

For example I have module "menu". This module depends on menu.js, menu.css modules. In menu.css there are some styles with image url. For example there is menu.sprite.png And I have module "home.page". When you click "load menu" button on home page, I want for menu.css and menu.sprite.png to be loaded before showing module "menu". How can I do loading images with webpack? Is there any loader which adds img tag on page and then uses onload event for this image?

Out of scope for webpack. Just use the normal methods for preloading.

Thanks for reply. But why is it out of webpack scope? If to think about images as about modules, images must be loaded before resolving. I think it is a good thing because now when our pages is loaded browser have not loaded images yet and we do not see images on our page, then when images are loaded, browser will show them on page. It is bad. I want for all images to be loaded before the module which depends on some images to be resolved and to be showed on page.

I think there must be any webpack loader or plugin which makes this.

Feel free to create one. You basically need to call new Image().src = url;.

Hint: it's a pitching loader.

If I'm strong in nodejs I would make it... Anyway thanks. Maybe I'll try.

Hi @sokra!
I'm trying to implement same loader.
Main idea is to warm up all assets from css file, filtered by device pixel ratio.
My issues:

I can't find the way, to defer export (like promise or whatever).
I can generate file with require.ensure, but, then i can't filter images (all images for 1x,2x,3x will be loaded + problem with large base64 images)

Please, can you give few more hits)

@glebmachine, please, write here when you finish this loader :) Thanks.

@pavel06081991 it's not so easy as @sokra said)

@glebmachine I believe you can do it! :)

@sokra, please, give me a clue(

// preload-image-loader
module.exports = function() {};
module.exports.pitch = function(remainingRequest) {
  this.cacheable();
  return [
    "var url = require(" + loaderUtils.stringifyRequest("!!" + remainingRequest) + ");",
    "new Image().src = url;",
    "module.exports = url;"
  ].join("\n");
}

module.loaders: [
  { test: /\.png$/, loaders: [
    "preload-image-loader",
    "file-loader"
  ] }
]

var url = require("./image.png"); // start preloading...

// do something with url
module.exports = "<img src='" + url + "'>";

Thank you!
Appreciate that, will try soon)
Gleb Mikheev
+7<PHONE_NUMBER>
Sent from my iPhone

On 27 янв. 2016 г., at 10:33, Tobias Koppers<EMAIL_ADDRESS>wrote:
// preload-image-loader
module.exports = function() {};
module.exports.pitch = function(remainingRequest) {
this.cacheable();
return [
"var url = require(" + loaderUtils.stringifyRequest("!!" + remainingRequest) + ");",
"new Image().src = url;",
"module.exports = url;"
].join("\n");
}
module.loaders: [
{ test: /.png$/, loaders: [
"preload-image-loader",
"file-loader"
] }
]
var url = require("./image.png"); // start preloading...
// do something with url
module.exports = "";
—
Reply to this email directly or view it on GitHub.

@sokra
Sorry, again(
This start preload, but, dont wait until images are fully loaded (like require.ensure "wait" for all inner modules)
As i wrote (twice, first in comment and second in email), i can't find the way to finish preloading all images before module resolves

@sokra I am attempting to use the preload-image-loader you describe above. Can you please explain this part "var url = require(" + loaderUtils.stringifyRequest("!!" + remainingRequest) + ");"
What is the '!!' for? The docs for stringifyRequest show it being used with this not remainingRequest, why are you using it that way here?

FYI: sokra's code is available in an nom package (https://www.npmjs.com/package/preload-image-loader)
Didn't work for me though..


Multi-instance dashboard issues.

Testing multi-instance dashboard fix in #192 which worked mostly except for:

sabnzbd always returned no instances.  I tracked this down to a misspelling in the instance variable.  instead of  bd it is using db which is backwards.  Should be {__name__=~"sabnzbd_.*"} not {__name__=~"sabnzdb_.*"}.

All instance variables are set to refresh only on dashboard load only.  If you change the time range using the date picker in the dashboard, the number of instances running during the new time range is not updated.

The version number within the dashboard yaml was not bumped.  (it's the 3rd line from the bottom of the file).

I'll submit a PR to address these issues.

Hey @reefland,

That typo was a nice catch. damn it...
i just wanted to check if i maybe did set the datasource hardcoded and did not use the proper variable ${DS_PROMETHEUS}

i never have had / experienced that as problem with "on load" variables but that is a interesting situation.
mainly because i dont go back in time were stuff like this matters.
i also never considered "on time change" because it will also refresh those variables on every "auto reload" which might create a "unnecessary" load to small instances (like RPis and such) and could cause timeouts. i have experienced that in the past, on more complex dashboards and variables though.

thank you for investigating those issues!


feat: add condition to controlPlaneServiceTemplate in KubevirtCluster…

Fix #219

I think i need to change my git commit email to match userID with easycla. Sorry for the miss.


Initial AngularJS application bootstrapping and breadcrumbs directive

The author email appears tied to a local system name.  Probably not what you wanted.
There doesn't appear to be updates to the LICENSE/NOTICE of NiFi which will be needed given this is a source dependency.  It appears to include a lot of cruft like README files and gitignore files and so on which seem avoidable.

@scottyaslan Looks like you need to update the apache-rat-plugin configuration to exclude [1] the angular stuff that's been introduced. Let me know if you have any questions.
[1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L674

Could we get a JIRA established (https://issues.apache.org/jira/browse/NIFI) to track these efforts?  With things that seem to be as transformative as this it would be nice to have the corresponding issue for planning as well as at release time if this is incorporated for the sake of docs and the like as well as to capture the associated history.

@scottyaslan A couple things...

Looks there is a whitespace being inserted at the end group name in the breadcrumbs.
The breadcrumb alignment might be off by a pixel or two.
The bottom of the breadcrumb text is getting clipped.
Once the breadcrumb text has overflowed and the group changes, the view does not appear to reset correctly.
Looks like the scroll direction changed. Was this intended?

Ensure breadcrumb placement is correct when bottom banner is visible.

Looks great! Thanks @scottyaslan


ContactBlocked: Contact is blocked

Description
When trying to start a closed session, the error happens.
Environment

Wppconnect-server version(s): 11880fd677d6df2e584ddfbc35c6a189cae636fd
OS: Ubuntu 20.04.4 LTS
Node version: v16.15.1

Steps to Reproduce

Call start-session with a webhook URL.

Log Output
1|server  | error: 2022-09-17T14:11:47.079Z Contact is blocked - ContactBlocked: Contact is blocked
1|server  |     at /var/local/apps/wppconnect-server/node_modules/@wppconnect-team/wppconnect/dist/api/helpers/evaluate-and-return.js:106:31
1|server  |     at step (/var/local/apps/wppconnect-server/node_modules/@wppconnect-team/wppconnect/dist/api/helpers/evaluate-and-return.js:49:23)
1|server  |     at Object.next (/var/local/apps/wppconnect-server/node_modules/@wppconnect-team/wppconnect/dist/api/helpers/evaluate-and-return.js:30:53)
1|server  |     at fulfilled (/var/local/apps/wppconnect-server/node_modules/@wppconnect-team/wppconnect/dist/api/helpers/evaluate-and-return.js:21:58)
1|server  |     at runMicrotasks (<anonymous>)
1|server  |     at processTicksAndRejections (node:internal/process/task_queues:96:5)
1|server  | JS Stack: ContactBlocked: Contact is blocked
1|server  |     at new i (https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:32:151305)
1|server  |     at new i (https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:33:17281)
1|server  |     at https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:33:107069
1|server  |     at t.promiseCallSync (https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:32:67563)
1|server  |     at t.sendMsgRecord (https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:33:106630)
1|server  |     at https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:32:265183
1|server  |     at Generator.next (<anonymous>)
1|server  |     at t (https://web.whatsapp.com/vendor1~bootstrap_qr.d22113b351145f031a1c.js:2:65356)
1|server  |     at s (https://web.whatsapp.com/vendor1~bootstrap_qr.d22113b351145f031a1c.js:2:65567)
1|server  |     at W (https://web.whatsapp.com/bootstrap_qr.a817218351c7d3e5be74.js:32:83013)

Could you put here the step by step to reproduce the error?

It's in the first post, I'm just posting start-session.


Retry API requests on timeouts (HTTP status 408)

This wraps the API calls in a retry when the API connection returns a connect timeout or an HTTP status 408. By default it retries 3 times, that can be adjusted using the api_retries config option.
As well, now the code will check if another server is already using the label it wants, and if so it'll pick a different random suffix. Also added retry support if we do end up with a non-unique label on server create.
Added better error handling on deletes so a 404 doesn't make it nervous.
Signed-off-by: M. David Bennett<EMAIL_ADDRESS>

Thanks!


Import/export from settings instead of menu

At the moment, all tracks can be export from the TrackListActivity.
However, this might not be the most used functionality and thus could be moved to the settings.

Done.


web-app support

Hi,
Could support for the was-scan be added to the project?
These are now available at the cloud api site https://cloud.tenable.com/api#/resources/was-scans.
Thanks,
Stephen Cannons

Generally all WAS functionality should be covered by the existing asset/editor/scan/etc APIs that already exist. The documentation lists these separately, but they use the same underlying endpoints, sometimes with additional parameters.
I'm going to close this now, but please feel free to re-open if you find any missing WAS functionality.


Support Videos

Some users would love to remove the metadata from video files

Yes, I'll work on it.

Added in v2.0.3.  🥳


fixes #7317 stable/fluentd-elasticsearch truncate config volume name

What this PR does / why we need it: Truncates the config volume names to 63 characters for the DaemonSet ConfigMap Volumes, as the "config-volume-" string is prepended onto a 63-char truncated template value for the "fluentd-elasticsearch.fullname".
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #7317

Please resolve merge conflicts.

/lgtm

@cpanato - it failed the test - re-running with the syntax corrected for the volumeMount name.

/assign @scottrigby

/lgtm

Not stale. Awaiting one approval.

@cpanato @scottrigby would there be someone else that could be added as an assignee to this PR? Our team relies on this public chart as a dependency, and are unable to proceed without this character limit in place (due to automated processes generating long names).

Not stale. Awaiting one approval.

Fixed in https://github.com/helm/charts/pull/8923

/close

Confirming @monotek note that #8923 fixes this issue, as it includes a shortened config volume name.


Add UI Support for EKS Custom AMI ID

Add UI support for this issue:
https://github.com/rancher/rancher/issues/15389

Version - 2.1 master 9/17
Verified fixed


Exception when using --values and --set referencing the same value

Output of helm version:
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"clean", GoVersion:"go1.13.12"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.5", GitCommit:"e6503f8d8f769ace2f338794c914a96fc335df0f", GitTreeState:"clean", BuildDate:"2020-06-26T03:47:41Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-30T20:19:45Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Bare Metal / Kind
I want to upgrade/install a chart with this line:
helm upgrade -in artis-dev --create-namespace --values ../profiles/dev.yaml --set environment.ARTICLE_LISTENER_OPTIONS="--every-nth-element 50" article-listener article-listener/
dev.yaml content:
environment:
  - name: ARTICLE_LISTENER_OPTIONS
    value: "--every-nth-element 100"
  - name: ES_JAVA_OPTS
    value: "-Xms2g -Xmx2g"

dev.yaml is the default environment and is set with every local deployment. When I want to reassign a value which already exists in this file I get following exception:
`panic: interface conversion: interface {} is []interface {}, not map[string]interface {}
goroutine 1 [running]:
helm.sh/helm/v3/pkg/strvals.(*parser).key(0xc00076eb00, 0xc00074d7a0, 0x1661e0d, 0x1932c40)
/home/circleci/helm.sh/helm/pkg/strvals/parser.go:211 +0xdea
helm.sh/helm/v3/pkg/strvals.(*parser).parse(0xc00076eb00, 0xc00074d7a0, 0x0)
/home/circleci/helm.sh/helm/pkg/strvals/parser.go:133 +0x38
helm.sh/helm/v3/pkg/strvals.ParseInto(0x7ffe6397a26a, 0x3b, 0xc00074d7a0, 0x17aa2e0, 0xc00000f8c8)
/home/circleci/helm.sh/helm/pkg/strvals/parser.go:70 +0xbe
helm.sh/helm/v3/pkg/cli/values.(*Options).MergeValues(0xc0006be5a0, 0xc00076e880, 0x1, 0x1, 0x0, 0x0, 0x0)
/home/circleci/helm.sh/helm/pkg/cli/values/options.go:62 +0x22b
main.newUpgradeCmd.func1(0xc0006d8dc0, 0xc0001126c0, 0x2, 0x9, 0x0, 0x0)
/home/circleci/helm.sh/helm/cmd/helm/upgrade.go:124 +0x325
github.com/spf13/cobra.(*Command).execute(0xc0006d8dc0, 0xc000112480, 0x9, 0x9, 0xc0006d8dc0, 0xc000112480)
/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842 +0x460
github.com/spf13/cobra.(*Command).ExecuteC(0xc0006ba000, 0x1d6bd60, 0xc00044a160, 0x7ffe6397a229)
/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
main.main()
/home/circleci/helm.sh/helm/cmd/helm/helm.go:83 +0x206
`
Is it a duplicate of #7184 ?

Edited the original comment for improved readability with backquotes.

In your dev.yaml, you specified the values under the environment as an array. In your --set arguments, you provided it as a dictionary.
To fix this, use the following syntax in your dev.yaml:
environment:
  ARTICLE_LISTENER_OPTIONS: "--every-nth-element 100"
  ES_JAVA_OPTS: "-Xms2g -Xmx2g"

@kkendzia First, Helm could have a better error message for this. This is coming from internal mechanisms and isn't all that user friendly. I can see why this is hard to figure out.
The name and value you're adding in there isn't needed. --set works on the structure as is.


fix: passing tz as param

Pull Request Template
Issue Overview
This PR addresses #1606

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
This PR updates the listings export and csv export to show times in the user's timezone rather than in UTC to improve readability.
How Can This Be Tested/Reviewed?
This can be tested by pulling down the branch locally, reseeding, and then export the listing zip. In the listing csv, you will see the created at date will be the local time that you reseeded along with the appropriate timezone abbreviation. To test the other dates, you can update a listing, verify a listing, etc.. Then save and export to ensure the times show appropriately.
Then, follow the same general testing approach for the user export.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have added QA notes to the issue with applicable URLs
[x] I have performed a self-review of my own code
[x] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[ ] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Not super sure of the cause here - but this action occurred at

 Not super sure of the cause here - but this action occurred at 5:53 Mountain, so while it displays my timezone the time is incorrect and is showing +2 hours

@emilyjablonski this might be the same issue that Colin ran into. He had created the db in eastern timezone. What does your  detroit db show when you query this? show timezone;

"rows":[["America/Detroit"]] I get this value, but to me it seems like the display timezone + the db creation timezone shouldn't influence each other?

Updated 🦭 @ludtkemorgan


Bug : error code : 403  {detial : stream object no attribute usage}

Do you need to file an issue?

[x] I have searched the existing issues and this bug is not already filed.
[x] My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
[ ] I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the issue
Hi i after creating  parquet file , when I am hitting the query
I am getting error back
raise self._make_sttus_error_fromresponse(err.response) from None openai.Permissiondeniederror: error code : 403  {detial : stream object no attribute usage}
as per I understood, my gpt instance does not support streaming of the response, hence this error I am seeing.
to solve this is there any setting in graph rag, so it will expect complete response in the end rather then waiting for streaming answer. thanks
Steps to reproduce
No response
GraphRAG Config Used
# Paste your config here

Logs and screenshots
No response
Additional Information

GraphRAG Version:
Operating System:
Python Version:
Related Issues:

Hi Team after digging for some time i found this section of code under file
Path: "graphrag/query/structured_search/local_search/search.py"
            response = await self.llm.generate(                 messages=search_messages,                 streaming=True,                 callbacks=self.callbacks,                 **self.llm_params,             )
By making streaming = False, issue got resolve,
same goes for global search file
I request ream to bring this variable as user input, by keeping it in settings.yaml file
thanks


bump go to 1.18

Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/22707

/retest

/retest

/approve
/lgtm


Fix new api key requirement of google

Hi,
It seems you now need to use a key to connect to the google api, please make this key configurable in a config file.
For now a hard coded fix in displaymap.php;

G, J

You are welcome to do a pull request.
n


[BUGish] Add language selector to UI

Currently, we do a best-guess for the language that should be used in the interface.
We need an explicit way for users to select their desired language.
Possible approaches

dropdown
text links
a combination of the above (have a dropdown, but include text links at the bottom

Good resource on UX of language selection: https://www.smartling.com/resources/101/language-selector-best-practices/

Moving this to Notion:
https://www.notion.so/juicebox/Add-Language-Selector-to-UI-a43dabba950148b1816a280918727880


Counter viz text

If the counter shows no text, it means the counter label was not set. Edit the query visualization and add a counter label


[BUG] The thumb radius section in Input Range breaks in mobile view.

Description
In mobile view when the 'include thumb radius' and 'include track radius' options are enabled, the input box causes the tickmark icon to stretch and overall it does not look good
Screenshots
Current Behavior:-

Expected Behavior:-

Additional information
No response
🥦 Browser
Brave
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue?
Yes I am willing to submit a PR!

Hey @Dun-sin  I would like to work on this issue. Please assign it to me.

not an issue, is this from the original website or your local code?

@Dun-sin I am getting this issue on the original website 🤔

@Dun-sin I checked on my mobile and on different browsers too.... weird how you don't see it

@Dun-sin I checked on my mobile and on different browsers too.... weird how you don't see it

what other browsers?

@Dun-sin Chrome

@Dun-sin I check both on my mobile as well as on desktop in responsive view through developer options

@Dun-sin Chrome

Technically brave and chrome are the same thing, just so you know they are both based on chromium, but i know what the problem is, the problem is browser works on firefox(which i use), doesn't on chromium browsers, that should help you solve it.
will assign it to you, follow the rules as usual

@Dun-sin So I should make the changes for only chromium based browser by using -webkit-appearance prefix right?

@Dun-sin So I should make the changes for only chromium based browser by using -webkit-appearance prefix right?

fix it the best way you think possible

:tada: This issue has been resolved in version 2.72.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix for CMDs

Needs another revert.
Fixed bugs:

Local item turning into nil.
Removing player's props while selling all entities.
Removing player's spawned entities (that are not buyable) while selling all entities.

And another sorry for not checking for errors.
If there still any errors, let me know, I will fix them asap.

I made a few changes to your pull request (I commented most of them in the code). I want to let you know that I really enjoy your help =)
P.S.: Gonna add a few entities next? Just kidding, take care.


Argument names and types get mangled when using openapi-generator with Pydantic

#1154 Question
I'm using Pydantic and FastAPI.  I believe this is an issue/question for Pydantic, but please point me to FastAPI if it is more related to that code.
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.5.1
pydantic compiled: True
python version: 3.7.3 (default, Mar 27 2019, 16:54:48)  [Clang 4.0.1 (tags/RELEASE_401/final)]
platform: Darwin-19.3.0-x86_64-i386-64bit
optional deps. installed: ['typing-extensions', 'email-validator']

from fastapi import FastAPI
from pydantic import BaseModel

from fastapi_utils.openapi import simplify_operation_ids

class Item(BaseModel):
    name: str

app = FastAPI()

#this works
@app.post("/items/")
async def list_items(item1: Item):
    return item1

#this generates a mangled name
@app.post("/items_bad/")
async def list_items_bad(item1: Item, item2: Item):
    return item1

simplify_operation_ids(app)

With the example above, the generated client APIs (after using openapi-generator) look like:
api_instance.list_items(item)
api_instance.list_items_bad(body_list_items_bad_items_bad_post)

I would like the 2nd API to look like
api_instance.list_items_bad(item, item)
Can someone advise on what I'm doing wrong?

Hello @jsilverpa,
For what I know when you write
@app.post("/items_bad/")
async def list_items_bad(item1: Item, item2: Item):

FastAPI will understand that item1 is the request body and the second argument will be the query parameters (see FastAPI doc).
Anyway the question has nothing to do with pydantic ;)

Hello @jsilverpa,
For what I know when you write
@app.post("/items_bad/")
async def list_items_bad(item1: Item, item2: Item):

FastAPI will understand that item1 is the request body and the second argument will be the query parameters (FastAPI doc) right?
So I don't understand why you would write something like this.
Anyway the question has nothing to do with pydantic and you should ask FastAPI team for some guidance

Hi @PrettyWood .  Thanks for the reply.  I'll ask at FastAPI, but I'd like to avoid the client having to wrap the Items in a new "Payload" structure.   Granted, I don't really understand the internal details of FastAPI, but it seems like it forces the client to understand the implementation details of the API.
Thanks again for your pointers and comments.


Cannot read properties of undefined (reading 'split')

Latest version of chat: v0.11.1

VS Code Version: Version: 1.86.0-insider (Universal)
OS Version: Mac OS 13.4.1 (c) (22F770820d)
Logs:

Steps to Reproduce:

ask it a question
ask it a follow up. it shows the 'Cannot read properties of undefined (reading 'split')' error
ask it again any number of times even with differewnt followup question. Same error.

Same here - for quite a few days now I've been getting this.
vscode Version: 1.86.0-insider
Commit: 8c08612b658a37f96892f8ed5a9c6e7a6667847d
chat v0.12.2024013003 (pre-release)

Interesting.
I had the same error with the release version (v0.11.1).
After switching to the pre-release version (v0.12.2024013003) the chat seems to work fine again.
Switched back to release version as a sanity check and the error is also back.
Version: 1.86.0-insider
Commit: 800e60abdfb1675a59520bac6a9473bc380d49ea
Date: 2024-01-23T06:11:42.114Z
Electron: 27.2.3
ElectronBuildId: 26378995
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.1.0-1028-oem (Ubuntu 22.04.3 LTS)

I had an update of "github copilot" plugin this morning (not the "github copilot chat" plugin and vscode itself.
now I'm at
vscode 1.86.0-insider, Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
copilot v1.156.683 (pre-release)
copilot chat v0.12.2024013003 (pre-release)
After updating that today, chat seems to be fixed, but jury is still out. It failed once with the same error after initially working a few questions, but it continue to answer after that single failure.

i had the same error:
now i'm at:
GitHub Copilot Chat v0.11.1
GitHub Copilot v1.156.0

vscode
Versión: 1.86.0-insider (user setup)
Commit: 9c5eabb378c9d18a0f712d1f22fe63df3f933ade
Date: 2024-01-30T03:56:13.017Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
SO: Windows_NT x64 10.0.19045

same issue here and just received today

Duplicate of https://github.com/microsoft/vscode-copilot-release/issues/796#issuecomment-1925413610


IntoClass, IntoProperty, IntoStyle doesn't have a into_class_boxed helper

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Add into_boxed() method on IntoClass, IntoProperty, IntoStyle traits.
Describe alternatives you've considered
N/A
Additional context
N/A

@gbj this is not a breaking change, but would be preferrable to be ready for 0.5.


inverse transform for the predicted/reconstructed values

So far, the pipeline will apply a series preprocessing strategies on the raw data to make it ready for ML model.
However, there is a need to observe the predicted/reconstructed values in the original feature space instead of transformed feature space.
Suggestion:

ORION class records the fitted transformers in the order [T1, T2, T3]
Add a method to the ORION class called inverse_transform which will apply [i_T3, i_T2, i_T1] to the predicted/reconstructed values

Message from @csala:
So far MLPrimitives support functions to reverse the transform:
https://github.com/HDI-Project/MLPrimitives/blob/c5208e7bc0f6b8d6afe3aab7bdc0b214bae56f11/mlprimitives/custom/preprocessing.py#L33
Its example usage:
https://github.com/HDI-Project/MLPrimitives/blob/reorganize-pipelines/mlprimitives/pipelines/timeseries/forecasting/impute.scale.lstm.json
The only thing here is that this one is a very specific transformation, for min/max scaling, but for other transformations we will not have this architecture ready yet.


feat(semantic): check for JSDoc types in TS type annotations

Closes #5982

#6042  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on  Graphite


Add new relation guest

FEATURE REQUEST

Is there an open issue addressing this request? If it does, please add a "+1" reaction to the
existing issue, otherwise proceed to step 2.
No
Describe the feature you are requesting, as well as the possible use case(s) for it.
Add new relation guest
Indicate the importance of this feature to you (must-have, should-have, nice-to-have).
must-have

This will be resolves by PR https://github.com/absmach/magistrala/pull/2228


fix/handle-camera-focus

Description
When the FPVCamera has focus, the mouse cursor is hidden and the user has no way to recapture it.
Steps to reproduce

Start the application

TODO

[x] If the escape key is pressed, the FPVCamera should return the mouse cursor to the user

Instead of escape, the left and right mouse buttons are used to focus the user's input on the fpv camera (left click on screen to take control of the camera and hide the cursor, right click to leave and show the cursor).


Feat: adding collapse button for lineage

Overview

adding collapse button for lineage

Checklist

[ ] I have run this code and it appears to resolve the stated issue
[ ] README.md updated and added information about my change

closing in favor of https://github.com/AltimateAI/vscode-dbt-power-user/pull/785


Deal with sanity_check code

sanity_check requires heavy computation (probably with GPU) so it cannot be part of test suite. However it is nice to have sanity_check case to be able to test layer performance.

This will be the part of the repo, but it will not be included in package.


How to keep fixed height for chart on browser resizing

I am using ng2 charts that use Chart.js engine underneath.
I am having an issue where as I resize the browser reducing the width, the height of the chart reduces to a point that it becomes real tiny in height even at around 1000px x  600px
Is there a way to keep a fixed height for the chart with browser re-sizing? And, currently, I am only resizing the browser changing the width of the browser and not the height.

Heading

Last 8 days

                            <canvas baseChart id="mybarchart"
                                [datasets]="barChartData"
                                [labels]="barChartLabels"
                                [options]="barChartOptions"
                                [colors]="chartColors"
                                [legend]="barChartLegend"
                                [chartType]="barChartType"
                                (chartHover)="chartHovered($event)"
                                (chartClick)="chartClicked($event)"></canvas>

I actually set maintainAspectRatio: false, and that seem to solve the issue I mentioned.

Yes, maintainAspectRatio: false is the solution


Fix a small bug in forward method of IA³

As discussed internally.
Note: No tests are added but this will be tested in via #683.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Improve the detail::overload visitor helper

In very much non-scientific tests, this version of detail::overload compiles slightly faster, and has better diagnostics, because the visitor no longer is an anonymous struct.
Additionally, the brace-list-init constructor allows for using a trailing comma, which makes git-diffs leaner, and improves formatting in a few places.
This change is purely syntactical and does not alter the behavior of the code.

I've verified this to work using gcc-8 manually by running docker build . from the repository root.

Will there ever be a std::overload or something? If there's a proposal out there, it might make sense to use that syntax.

Will there ever be a std::overload or something? If there's a proposal out there, it might make sense to use that syntax.

I've only found p1772r0, but it doesn't look like much work has happened on it yet. At this point, everyone uses either of the two versions in their code base anyways.
I prefer the style from this PR for the reasons I listed. Allowing for a trailing comma is really nice.


API unclear - more documentation needed?

I've been trying to use this library to improve assertions
E.g. changing
someStub.calledTwice().should.be.true() to someStub.should.be.calledTwice()
Seems to work, however if I change
someStub.calledWith(something).should.be.true()
to
someStub.should.be.calledWith(something)
The latter form always returns true as far as I can tell.
There is very minimal documentation, so I can't tell if this is a bug or if I'm using the library wrong.
I've also had difficulties with getters (although these only have minimal support in sinon) and with any stub that was set using rewire.
It would be really helpful to get some more documentation for this module so that it's easier to reason about these cases and why they don't work.

For me .calledWith works fine:
> var should = require('should')
> require('.')
> var sinon = require('sinon')
> var spy = sinon.spy();
> spy(1, 2, 3)
> spy.should.be.calledWith(1, 2, 3)
Assertion { ... }
> spy.should.be.calledWith(1, 2, 2)
AssertionError: expected 'spy' to be called with arguments 1, 2, 2
    spy(1, 2, 3) at repl:1:1
    expected false to be true
...

Can you provide failing example?
Also i agree about not clear docs, i just do not have enough time to keep docs up to date. You can just take as a rule that everything provided by should-sinon is just all sinon ows assertions. Also there is no getters, everything is function call.

Sorry - I moved away from using the module because it produced false positives for me. I was trying to use both this module + stubs for getters at the same time & the result was very very confusing.
Chances are that the problem is more along the lines that this module doesn't work with getters (sinon itself only just works with them).

Do you have some small reproducible example, that i can use as starting point for improvement. I would be greatly appriciated. For now this is only small wrapper around sinon own assertions. But i think i will need to use should own internals to do more accurate assertions.


Fix progressbar and notifications segfaults in test

Description

Today morning I notice that every time tests fail I see black "plugin.py" windows which are closed exactly at the same time when StopIteration was printed to console. When running tests without test_progress these windows do not show.

Then in this PR, I try to force its closing. And it works locally.
So it looks like segfault in MIN_REQ is connected with the pending notification dialog.
I think that it could be connected with the same reason why the last test was disabled on python 3.7.
https://github.com/napari/napari/blob/419cfe0a759ae1d3c7fb2747f9ab149390a43ee8/napari/_qt/_tests/test_qt_notifications.py#L125-L135
This PR is a little brutal but may be an inspiration for a person who better understands notification code or may be used as a temporary workaround for release 0.4.8 if no one has some idea for a better solution.  If using please check the mechanism of cleaning the_instances class attribute of NapariQtNotification
cc: @tlambert03 @sofroniewn
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

It looks now good, but I still think that it could be done better.

I can not reproduce fails locally. Could anyone else try?

I'm surprised by this one.  When the dialog is created, it is patented to something in the widget parent chain, and so shouldn't need to be cleaned up explicitly like this... (it would leak a widget if it wasn't).  Can you expand on the reasoning here?

I'm surprised by this one. When the dialog is created, it is parented to something in the widget parent chain, and so shouldn't need to be cleaned up explicitly like this... (it would leak a widget if it wasn't). Can you expand on the reasoning here?

I think that there is no parent. There is no Napari Viewer instance so there is no parent:
https://github.com/napari/napari/blob/419cfe0a759ae1d3c7fb2747f9ab149390a43ee8/napari/_qt/dialogs/qt_notification.py#L95-L99

ahhh, yep for that test... that makes sense.  thanks

Feel free to push anything to this branch.

I recall that sometimes adding to qtbot without show widget does not work so I add a small fix but have no next idea.


Merge caption and help text tokens to label variant

Merge caption and help text tokens to label variant
Update line heights

Some recent conversations have affected this change @pseys could you advise

done @joshwooding


Remove path import by using own isAbsolute function

This PR is in support of https://github.com/brillout/vite-plugin-ssr/issues/445.
I don't have a windows machine, not exactly sure how to test this

Maybe we can use https://github.com/unjs/pathe/blob/ae583c899ed9ebf44c94ab451da5fd7c3094dea9/src/path.ts#L14 instead?

Done!

👍 Released as<EMAIL_ADDRESS>


Strange behavior of function which has overload in higher kind function.

consider bellow example:
interface Fn {
  (a: number): number;
  (a: string, b: number): number;
}

type HKF = <F extends (args: number) => any>(f: F) => Parameters<F>;

declare const fn: Fn;
declare const hkf: HKF;
// The `result` will be infer as [string,number], we expect [number]
const result = hkf(fn);

In this example, our intend is the hkf function will choose the first signature of Fn,
because only the first signature match the type constraint that F extends (args: number) => any.
I test it in many times and found that,
Typescript always choose the last one signature of overload function in this case.

I test it in many times and found that,
Typescript always choose the last one signature of overload function in this case.

Yes, this is the intended behaviour as described in the pull request that implements conditional type inference.
#21496

When inferring from a type with multiple call signatures (such as the type of an overloaded function), inferences are made from the last signature (which, presumably, is the most permissive catch-all case). It is not possible to perform overload resolution based on a list of argument types (this would require us to support typeof for arbitrary expressions, as suggested in #6606, or something similar).


doc: Write syntax definition in polybar.5

And finally the documentation for the config file syntax defined in #1377

Thanks @kronn 😊


Document new config field

The Log Event Count Interval was released in version 3.0.0, but it isn't yet in the docs.

Thanks @mjj209!


Adding calculator to find hyperbolic trigonometric ratios.

I would like to add a calculator to find hyperbolic trigonometric ratios.
Please assign this to me.

Go ahead
Deadline 14 April,2021 11:59 PM IST

@sairish2001 Can i work on this ?

@sairish2001 Can i work on this ?


Textures Missing in Demos

Not sure what's wrong, but after importing the demos, they all look something like this:

Unity 2020.3.32f1

can confirm I also had this issue


Fixes for FileVersionProvider

Issues #2719 and #2750

Path with query string works
No exception is thrown for absolute path

@Eilon @DamianEdwards

:shipit: once somebody else signs off

Updated.

:shipit: thanks!


Chakra compiled with ASAN not working (in non-static builds)

Hello,
I cloned the latest version of ChakraCore from git and Have LLVM/Clang 5.0 installed. I built ChakraCore with the following command on Ubuntu 16.04 LTS:
$ ./build.sh --sanitize=address -j
the built was successful and i got ch file, but as soon as i try any of the tests in tests/ directory the ch crash with the following error:
:~/ChakraCore-ASAN/out/Release$ ./ch ../../test/Basics/hello.js
dlopen() failed; dlerror says '/home/mj/ChakraCore-ASAN/out/Release/libChakraCore.so: undefined symbol: __asan_option_detect_stack_use_after_return'
FATAL ERROR: Unable to load /home/mj/ChakraCore-ASAN/out/Release/libChakraCore.so GetLastError=0x7e
=================================================================
==24085==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 16 byte(s) in 1 object(s) allocated from:
#0 0x564d66f78890 in operator new[](unsigned long) (/home/mj/ChakraCore-ASAN/out/Release/ch+0xec890)
#1 0x564d66f7e8e2 in main (/home/mj/ChakraCore-ASAN/out/Release/ch+0xf28e2)
#2 0x7f642bfda82f in __libc_start_main /build/glibc-t3gR2i/glibc-2.23/csu/../csu/libc-start.c:291
Indirect leak of 10 byte(s) in 1 object(s) allocated from:
#0 0x564d66f47148 in __interceptor_malloc (/home/mj/ChakraCore-ASAN/out/Release/ch+0xbb148)
#1 0x564d66f7e95b in main (/home/mj/ChakraCore-ASAN/out/Release/ch+0xf295b)
#2 0x7f642bfda82f in __libc_start_main /build/glibc-t3gR2i/glibc-2.23/csu/../csu/libc-start.c:291
SUMMARY: AddressSanitizer: 26 byte(s) leaked in 2 allocation(s).
Thanks in advance

Hi there,
Thanks for the report; we're aware of a number of issues that ASAN is currently finding in our builds. They're generally issues with our test host being sloppy (if you do LoadScript in a test, then it leaks the loaded script). There's a set of changes that are being worked on to fix many of these issues; however, we do welcome attempts at fixing some of them by outside contributors.

@Penguinwizzard I think you misunderstood the OP. The problem is not an issue reported by ASan but rather the fact that the shared library (libChakraCore.so) can't be loaded due to a missing ASan symbol. I reproduced this with clang 3.9 on Linux and this problem prevents people from using ASan with ChakraCore at all. The additional report about memory leaks is probably irrelevant here.

I just pasted the output I got!

Oh, woops; that's a separate issue with linking ASAN into the project properly at runtime, that can likely be fixed with some environmental changes. Do you get success with building and running some trivial sample programs with asan on this system?

Yep, regular program seems to work fine. I checked the symbol in both the binary and the so:
`
$ nm out.asan/Test/ch | grep __asan_option_detect_stack_use_after_return
000000000065e490 b __asan_option_detect_stack_use_after_return
$ nm out.asan/Test/libChakraCore.so | grep __asan_option_detect_stack_use_after_return
U __asan_option_detect_stack_use_after_return
`
I also do not remember encountering a similar problem when I integrated ASan into the Firefox build system which also uses shared objects. Maybe I should make a simple shared object setup to see if that reproduces the problem.
You are not by any chance hardcoding paths to Clang/LLVM in your build system somewhere, in such a way that multiple installed versions might get mixed?

Just some additional information here;
Jsrt Method addr on so/dylib (0x0001) -> CH finds that address and binds it to a local process call.
So, the way CH uses ChakraCore.so/dylib is a bit crippled due to interface similarity we have between Windows and other platforms. This also affects other tracing solutions on those platforms.
Unless the toolchain is aware of this, IMHO the ASAN results may not be reliable.

Ah, I figured out where I saw this before. This is indeed likely an issue with how we're linking everything together; I'd been working around it by just using the --static flag to statically link everything. I'll update the title and take a closer look.

Any reason to keep this open? As I've explained above, non-static ASAN builds are not expected to work by design.

I don't think there is; in any case, there's some other analyzers that don't work with dynamic linking anyway. At the very least, build.sh should complain at you if you attempt to start a build that's not going to produce useful output.

@djn3m0 Thanks for bringing this. The discussion here might help if anyone else needs it later.
Closing.

Confirmed on my build that static fixes the issue with the link step as well as a follow on "Shadow memory range interleaves with an existing memory mapping. ASan cannot proceed correctly. ABORTING." ASan error


Drop nrwl for nx as prefix

With NX 16 the prefix nrwl got dropped, to be compatible with it the executor needs following changes:
const devkit_1 = require("@nx/devkit");
const fileutils_1 = require("@nx/workspace/src/utils/fileutils");
const buildable_libs_utils_1 = require("@nx/js/src/utils/buildable-libs-utils");

At least for me that fixed things, otherwise I get the error Cannot find module '@nrwl/workspace/src/utils/fileutils'.

Right... expect a new release by the end of this week

Alright, v0.16.0 published: https://www.npmjs.com/package/@altack/nx-bundlefy


vendor: coreos/bbolt v1.3.1-coreos.0, add others in glide.yaml

Once merged, I will redeploy functional tester cluster.

Will drop blackfriday changes... no idea why it is staged...

Added others in glide.yaml that was missing from glide.lock.
Now updatedep.sh will output reproducible builds.
Merging in greens.
Thanks.

Blocked on https://github.com/coreos/bbolt/issues/15.

@heyitsanthony PTAL.
Seems fixed https://jenkins-etcd.prod.coreos.systems/job/etcd-ci-ppc64/1878/.
Commented on the test (will close https://github.com/coreos/bbolt/issues/15).
Thanks.

lgtm; the new freelist page reuse is probably why it stopped working-- allocation is more efficient

lgtm


Implement generic SU(N) operator

Summary
This PR introduces a generic SU(N) operator to represent multi-qubit random unitary gates, as part of the preparations for implementing the Quantum Volume circuit (#36). To accommodate the dynamic nature of SU(N), where N can vary, a custom function SU(N) is provided to generate specific SU(N) types that inherit from a general SU parent type.
@mofeing While adding a random_unitary function might suffice for some use cases, having a dedicated SU(N) representation can offer more flexibility and semantic clarity, do you agree? Also, since we want each random operator to have the same random numbers each time we operate with them, maybe we should identify the operator with a fixed seed.
TO DO:

[ ] Right now an SU(N) operator will have different numbers each time we call Matrix(SU(4)(1, 2)), this should be fixed.
[ ] Add tests.

Example usage
Here is an example of how this operator works:
julia> using Quac

julia> gate = SU(4)(1, 2) # SU(4) gate that acts on lanes 1 and 2
SU4(1,2)

julia> m = Matrix(gate)
4×4 Matrix{ComplexF32}:
 -0.474855-0.387932im   0.250235-0.0231993im   0.457831-0.320303im    0.386465-0.31513im
 -0.192159-0.46343im   -0.455403+0.470344im   -0.536063-0.135119im    0.062832-0.100616im
 -0.406442-0.037264im   0.109371-0.359769im    -0.31538-0.0732732im   0.268802+0.717588im
 -0.274017-0.361469im  -0.285759-0.534018im   0.0508006+0.524177im   -0.333306-0.197451im

julia> m * adjoint(m) # The operator is unitary
4×4 Matrix{ComplexF32}:
        1.0+0.0im           1.3411f-7+1.19209f-7im   -8.9407f-8-1.04308f-7im   2.98023f-8+1.49012f-8im
  1.3411f-7-1.19209f-7im          1.0+0.0im         -4.47035f-8+0.0im          2.98023f-8+9.12696f-8im
 -8.9407f-8+1.04308f-7im  -4.47035f-8-0.0im                 1.0+0.0im         -7.07805f-8+7.45058f-8im
 2.98023f-8-1.49012f-8im   2.98023f-8-9.12696f-8im  -7.07805f-8-7.45058f-8im          1.0+0.0im

@mofeing Maybe we should create a matrix_to_gate function but I am not sure how this can be done in the best approach. We would like this function to take an arbitrary $(2^n)\times (2^n)$ matrix and choose an operator that acts on the corresponding number of qubits, but I don't know what would be the best implementation to do this for a general number of qubits.


New version giving strange error

Sorry I can't be more descriptive, but I'm not sure what's going on here except that my multipart upload requests work on a older version of formidable/connect/express.  I'm also perplexed why the stacktrace references the connect-redis module.......
I'm using this line of code that fails: req.form.completed(err, fields, files)
This did work on<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>but not on<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Here's the stacktrace:
Error: MultipartParser.end(): stream ended unexpectedly: state = START
at MultipartParser.end (/home/j1y/node_modules/connect-form/node_modules/formidable/lib/multipart_parser.js:306:12)
at IncomingMessage. (/home/j1y/node_modules/connect-form/node_modules/formidable/lib/incoming_form.js:98:30)
at IncomingMessage.emit (events.js:88:20)
at Object.resume (/home/j1y/node_modules/express/node_modules/connect/lib/utils.js:226:18)
at /home/j1y/node_modules/express/node_modules/connect/lib/middleware/session.js:324:15
at /home/j1y/node_modules/express/node_modules/connect/lib/middleware/session.js:342:9
at /home/j1y/node_modules/connect-redis/lib/connect-redis.js:85:9
at try_callback (/home/j1y/node_modules/connect-redis/node_modules/redis/index.js:466:9)
at RedisClient.return_reply (/home/j1y/node_modules/connect-redis/node_modules/redis/index.js:503:13)
at RedisReplyParser. (/home/j1y/node_modules/connect-redis/node_modules/redis/index.js:259:14)
at RedisReplyParser.emit (events.js:67:17)
at RedisReplyParser.send_reply (/home/j1y/node_modules/connect-redis/node_modules/redis/lib/parser/javascript.js:279:18)
at RedisReplyParser.execute (/home/j1y/node_modules/connect-redis/node_modules/redis/lib/parser/javascript.js:223:22)
at RedisClient.on_data (/home/j1y/node_modules/connect-redis/node_modules/redis/index.js:422:27)
at Socket. (/home/j1y/node_modules/connect-redis/node_modules/redis/index.js:66:14)
at Socket.emit (events.js:67:17)
at TCP.onread (net.js:329:14)

This is very likely a duplicate of: https://github.com/felixge/node-formidable/issues/108


fix documentation for dynamic build dependencies

Summary of changes
I followed the documentation on dynamic build dependencies, which is apparently incorrect. See https://github.com/maxbachmann/RapidFuzz/issues/303. This fixes the passage in the documentation.
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d/.
(See documentation for details)

Thank you @maxbachmann


Bug: Zero findings causes action to fail due to missing CSV file

Description
If the scanner finds no vulnerabilities the actions will fail because the results CSV file is not generated. The JSON and Markdown results are still generated so this is inconsistent behavior.
Expected Behavior
CSV file with column headers should be produced even if there are no findings.
Actual Behavior
CSV file generation is skipped. This causes the cat command to fail and therefore the action to fail.
cat ${{ steps.inspector.outputs.inspector_scan_results_csv }}

cat: inspector_scan_10621029013.csv: No such file or directory

https://github.com/aws-actions/vulnerability-scan-github-action-for-amazon-inspector/blob/51b74849864257707482446461b6636628da9754/entrypoint/entrypoint/orchestrator.py#L348
Steps to Reproduce
Use the example workflow file from the README and run the action on a repository with zero vulnerabilities.

Hello, thank you for raising this issue.
We are investigating and will report back when we have additional information.

I understand your workflow is failing because it expects the CSV to be present, but it is not, resulting in exit code 1 and failing your workflow. I can reproduce this issue as well.
We are presently working on a fix.
In the mean time, you may consider commenting out the cat line that is breaking your workflow.
I will report back when I have an ETA for the fix.

Thank you!

We have implemented a fix to resolve your issue.
The fix is presently being tested to validate that the fix works as intended.
If we are confident in the solution we may cut a new release as soon as next week, at which point, you can pull in the updates. Thank you for your continued patience and have a great weekend.

@Schwartz-Matthew-bah
Our fix is now available for your use.
Please update your workflows to point to this release:
https://github.com/aws-actions/vulnerability-scan-github-action-for-amazon-inspector/releases/tag/v1
I'll also add that we are now tagging the latest release with v1, meaning, you can automatically consume minor and hotfix releases if you choose (see issue #87 ).

Marking this issue as resolved.
Please re-open the issue if there are subsequent problems.


Question about editing the code

How do I edit the " job "for each bot that says "@slaves_vk_bot"?

For now, it is not possible. Comming soon


⚠ BCR Bot has degraded performance

In fe279bd, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1431 ms

Resolved: BCR Bot performance has improved in 3d30095.


appears to not be working with GAM 4.72

Appears to not be working with GAM 4.72 just closes right away when I click submit

This might actually be an environment variable issue on my end. Looking into it

This seems like it can’t find the GAM executable. If you open event viewer (run: eventvwr), you’ll see a .NET application error. Take a screenshot of the error details and upload them here.

I got it working. I had to add an environment variable and put gam in a folder other than system32 for some reason.


Update index.html

Removing Freeflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@davislee7 could you please add the freeflow project to the list of "additional mobile projects" so we still have the history? Thank you!


Add Pagination

Add Pagination on the index.html page and display 10 blogs per page.

@diyajaiswal11 Please assign this issue to me as part of NWOC'20

Sure @Vrindagupta6828 , Go ahead.

Hi @diyajaiswal11 can you please assign it to me.

Hi @diyajaiswal11 can you please assign it to me.

Hey @dijodaiju7 , if @Vrindagupta6828 does not make a PR within 3 days from now, I'll assign it to you.

Ok, Thanks
On Tue, 1 Dec 2020, 1:49 pm Diya Jaiswal<EMAIL_ADDRESS>wrote:

Hi @diyajaiswal11 https://github.com/diyajaiswal11 can you please
assign it to me.
Hey @dijodaiju7 https://github.com/dijodaiju7 , if @Vrindagupta6828
https://github.com/Vrindagupta6828 does not make a PR within 3 days
from now, I'll assign it to you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/diyajaiswal11/Bloggitt/issues/6#issuecomment-736303804,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOL6NESAHC5MBDJEEWMTMZTSSSRJBANCNFSM4UEE3PWQ
.

Ok, Thanks
…
On Tue, 1 Dec 2020, 1:49 pm Diya Jaiswal, @.***> wrote: Hi @diyajaiswal11 https://github.com/diyajaiswal11 can you please assign it to me. Hey @dijodaiju7 https://github.com/dijodaiju7 , if @Vrindagupta6828 https://github.com/Vrindagupta6828 does not make a PR within 3 days from now, I'll assign it to you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOL6NESAHC5MBDJEEWMTMZTSSSRJBANCNFSM4UEE3PWQ .

You can checkout unassigned issues for now or create a genuine issue if you find any. @dijodaiju7

Sure, will do.
On Tue, 1 Dec 2020, 1:57 pm Diya Jaiswal<EMAIL_ADDRESS>wrote:

Ok, Thanks
… <#m_-3603302070670430636_>
On Tue, 1 Dec 2020, 1:49 pm Diya Jaiswal, @.***> wrote: Hi
@diyajaiswal11 https://github.com/diyajaiswal11
https://github.com/diyajaiswal11 can you please assign it to me. Hey
@dijodaiju7 https://github.com/dijodaiju7 https://github.com/dijodaiju7
, if @Vrindagupta6828 https://github.com/Vrindagupta6828
https://github.com/Vrindagupta6828 does not make a PR within 3 days from
now, I'll assign it to you. — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#6 (comment)
https://github.com/diyajaiswal11/Bloggitt/issues/6#issuecomment-736303804>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOL6NESAHC5MBDJEEWMTMZTSSSRJBANCNFSM4UEE3PWQ
.
You can checkout unassigned issues for now or create a genuine issue if
you find any. @dijodaiju7 https://github.com/dijodaiju7
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/diyajaiswal11/Bloggitt/issues/6#issuecomment-736307902,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOL6NETBMSJNQSSUASLRRWDSSSSH7ANCNFSM4UEE3PWQ
.


chore(ci): Reduce the number of jobs, move some of them to once a day

Following builds will be done once a day after this is merged:

all binary engine tests
json protocol with non-minimal supported version

If PR contains ci build all comment, all of those things will be
checked. If not, the job that will test them will run at 9am UTC.
The problem with testing it: cron jobs work only when merged into main.

Since new workflows won't be visible until we merge this to main, I'd suggest we do a review now and then test it later.


Feature/sar 361 d3 chart page styling

Related Tickets

SAR-361

Other Repos' PR(s) Intended to Work With This PR
None
How Things Worked (or Didn't) Before This PR

Chart displayed ticks for every Number and Date.
Chart displayed lines for every Number and Date.
Date on x-axis was attached to chart.
No labels on X and Y axis.
Measure by line chart x axis was by measure star rating.
X-axis values did not contain Percent.

How Things Work Now (And How to Test)

More Spacing on Chart Axis'
ticks and lines only on y-axis at "0, 20, 40, 60, 80, 100", all other lines and ticks removed using DOM manipulation.
Measure by line Styled the same as New D3-chart.
Measure by line chart x axis was by rating out of 100.
X-axis values contain Percents.

Readiness

[x] This PR passes all automated tests.
[x] This PR has no linting errors.
[x] This PR's changes to configuration files have been documented in all appropriate places (such as but not limited to README.md), if applicable.

Looks good and works.
Approved, but I recommend we have _d3-indicator-by-line.scss extend _d3-chart.scss sometime in the future since they are so similar.

Actually since we've got a little time, @timAmida can we do that now? Look at _trend-display.scss to see how it can be done.


Ping issue-{Let us create public lobbie}?

I use Singapore servers , after Respawn neglected the game last year the servers are mostly isolated. I then started using New York servers which had fair amount of players to play with (ping=200-300).
The Lobbies in northstar client (ping 300-600).
Appreciate the effort to create this client , this is simply a suggestion.
Thank you.

You can host your own public and private servers. There are instructions on the wiki

https://r2northstar.gitbook.io/r2northstar-wiki/


Remove database password

In the last pull request, I made a mistake of adding the database password which should not be added. Please review this.

This looks good to me. However, let's wait for the others to review.

I checked. Now it's correct.

Looks good let merge

Thank you. I'm merging this.


feature(analytics): first run revamp

Related to

YOMO-689
YOMO-686 COMPONENT AND NEW USERS FLOW DONE. EXISTING USERS FLOW STILL NEEDS TO BE DONE
YOMO-687
YOMO-695

https://github.com/Emurgo/yoroi/assets/105349292/08372b1f-d86b-4053-af8c-e7e96bb246b1

@MichalSzorad published on Yoroi Space.

ToDo:

[ ] @MichalSzorad update the ToS with the updates from extension requested by @yushih
[ ] @MichalSzorad update the link to ZenDesk


Add Podman Remote acceptance testing scenario

Fixes https://github.com/containers/podman-desktop/issues/8453

If it works without it, is it a feature or a bug? In other words, If I tried to use the key generate with ed algorithm, I did not manage it to work...

I thought we were going to SSH into the podman machine, generate the key, copy it to the host machine and use it?
We generate the key in the guest VM (podman machine) ? And copy its public part into our host? Shouldn't it be done the other way around?

@cdrage Anyway, I have added an option to use custom keys. ssh-copy-id does not work out of box here since we would need to adjust ssh config in the vm, we are simply manually creating ssh pub key record in the authorized_keys.d. tried and it works. So now it is hopefully complete. the key used are also using ed25519 algorithm btw.


Output Addresses From Capture for void* and Opaque* Struct Members

Fixes issue #683
Adds versions of DataPointerDecoderToString(), each one converting
the address from the capture file for the pointer in question,
and plumbs them in during code generation for Vulkan struct members
that are void pointers or pointers to opaque structs like platform
window handles or external memory.

CI gfxreconstruct build # 1898 running.

CI gfxreconstruct build # 1898 passed.

CI gfxreconstruct build queued with queue ID 27010.

CI gfxreconstruct build # 1905 running.

CI gfxreconstruct build queued with queue ID 27039.

CI gfxreconstruct build # 1906 running.

CI gfxreconstruct build # 1906 passed.


Add a DSL and a proper multistep compiler

Coverage decreased (-2.9%) to 90.956% when pulling 30b37814960dc8db288f2d09d535c97f1bbf228d on dsl into 6bd7adfc39841dfbf89c678ff50a51e5f7f0e988 on master.

Coverage decreased (-2.5%) to 91.382% when pulling 0d70b20770bdf8d21a1b9ca1af93615c68f37b71 on dsl into 6bd7adfc39841dfbf89c678ff50a51e5f7f0e988 on master.

Coverage decreased (-1.6%) to 92.23% when pulling 106553c6639e04edb797baea78e49e7435297b7f on dsl into 6bd7adfc39841dfbf89c678ff50a51e5f7f0e988 on master.

Coverage increased (+0.2%) to 94.093% when pulling b84385b4cf782ce9db37660b4a077bc592ef9a0c on dsl into 6bd7adfc39841dfbf89c678ff50a51e5f7f0e988 on master.

Coverage increased (+0.2%) to 94.093% when pulling 6d65901dca67dcb80718667dcce34e92080bbf64 on dsl into 6bd7adfc39841dfbf89c678ff50a51e5f7f0e988 on master.


fix: enable viewOnce messages to quote

a viewOnceMessage cannot quote another message.
this PR fixes this by unwrapping the viewOnceMessage to get the original type, assuming that it has viewOnce = true.

wrong branch name


Created contact.html

Fixes Issue no # 143
Enhances the contact page and have made it responsive to all screen type...

Description

Related Issues

Closes # 143

Type of PR

[ ] ()

Screenshots / videos (if applicable)

Checklist

[ ] I have gone through the contributing guide
[ ] I have updated my branch and synced it with project main branch before making this PR
[ ] I have performed a self-review of my code
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:

@Anjaliavv51 Created the contact page

@Deekshit7483 I have already re-design the contact page

@sejals23 i am closing this PR , it has no effect in the forked repo , please create some other issue i will assign u asap.


Fix issue #4774: [Bug]: "Import Project" button does not work as expected

This pull request fixes #4774.
The issue has been successfully resolved through a PR that fixes the immediate navigation problem in the project import functionality. The changes include:
Automatic fix generated by OpenHands 🙌

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:f4fc6cb-nikolaik   --name openhands-app-f4fc6cb   docker.all-hands.dev/all-hands-ai/openhands:f4fc6cb

Resolved in #4737


[Bug]: Different quality responses using GPTQ / marlin kernels on A10 vs A100 GPUs

🐛 Describe the bug
Hello,
I am running llama3-70b and mixtral with VLLM on a bunch of different kinds of machines. I encountered wildly different quality performance on A10 GPUs vs A100/H100 GPUs for ONLY gptq models and marlin kernels. GPTQ with marlin kernels is way faster than AWQ but with AWQ, i see roughly the same response on my test queries on either kind of GPU environment. For A10 deployments, the only difference in the settings is that I use 2 A10 24GB GPUs instead of 1 A100 or H100 (using the tensor parallelism param).  I am running vllm = 0.4.2. I am using examples from llama3-70b testing on a very simple test query but I also saw the similar flavor of quality issues with mixtral-awq vs mixtral-gptq as well and I also saw the same flavor of issues on all my other more complicated RAG test queries as well. Generally the gptq models on A10s are psychotic and unusable and behave as if the model files are screwed up, which is why i tested two publicly available quantizations of llama3...
I also tried to simulate a GPU environment of 2 A10s on 1 single A100 by setting --gpu-memory-utilization to 0.55 i.e. I choked the vram on the A100 deployment to choke the kv-cache available space. I got the same good quality performance on the A100 that I always see albeit with less throughput since my kv-cache was choked. No psychotic responses like I see on A10s.
Here's my examples,
Test prompt: "what model are you and what quantization do you use?"
Model : https://huggingface.co/casperhansen/llama-3-70b-instruct-awq
Model Args: --max-model-len 8192 --quantization awq --dtype half --gpu-memory-utilization 0.99 --trust-remote-code --enforce-eager --kv-cache-dtype fp8
Response on A10 or A100 (doesn't matter where I deploy it, I get pretty much the same response):
"I'm an AI assistant, and I'm happy to share some information about my architecture.

I'm a large language model, specifically a transformer-based model, which is a type of neural network designed primarily for natural language processing tasks. My model is based on the BERT (Bidirectional Encoder Representations from Transformers) architecture, which was developed by Google in 2018.

Regarding quantization, I don't use traditional quantization techniques like fixed-point or floating-point quantization. Instead, my model uses a technique called "knowledge distillation" to reduce the precision of my weights and activations while maintaining the accuracy of my responses.

Knowledge distillation is a method that involves training a smaller, simpler model (the "student") to mimic the behavior of a larger, more complex model (the "teacher"). In my case, the teacher model is a large, floating-point BERT model, and the student model is a smaller, integer-based version of myself.

During training, the student model learns to approximate the behavior of the teacher model by minimizing the difference between their outputs. This process allows me to maintain high accuracy while using fewer computational resources and reducing my memory footprint.

So, to summarize: I'm a BERT-based language model that uses knowledge distillation to reduce precision and improve efficiency, rather than traditional quantization techniques."

Model : https://huggingface.co/TechxGenus/Meta-Llama-3-70B-GPTQ or https://huggingface.co/MaziyarPanahi/Meta-Llama-3-70B-Instruct-GPTQ (tested with both)
Model Args: --max-model-len 8192 --quantization marlin --dtype half --gpu-memory-utilization 0.99 --trust-remote-code --enforce-eager --kv-cache-dtype fp8
Response on A100:
"Thank you for asking!

I am a type of artificial intelligence language model, to be specific, I'm a transformer-based language model. My architecture is based on the transformer model introduced in the paper "Attention is All You Need" by Vaswani et al. in 2017.

As for quantization, I don't use traditional quantization methods like 8-bit or 16-bit integer quantization. Instead, I rely on a technique called "floating-point quantization" which allows me to represent my weights and activations using a combination of floating-point numbers and integers.

In more detail, my model uses a combination of the following techniques:

1. **Weight pruning**: This involves removing redundant or unnecessary weights from my neural network to reduce its size and computational requirements.
2. **Knowledge distillation**: This is a process where a smaller model (like me) is trained to mimic the behavior of a larger, more complex model. This helps to transfer knowledge from the larger model to me.
3. **Quantization-aware training**: During training, my weights and activations are simulated using lower precision data types (like integers) to mimic the effects of quantization. This helps me to learn how to represent information efficiently even with reduced precision.

These techniques allow me to maintain a good balance between accuracy and computational efficiency, I can provide helpful responses quickly while still being able to understand and respond accurately.

Please let me know if you have any other questions or if there's anything else I can help with!"

Response on 2 A10s (tensor parallelism):
"into the 2000s and the 2000s of the 2000s and the 2000s of the 2000s and the 2000s of the 2000s."

or something else equally psychotic and random (it produces a different response every time so I have a feeling this has to do with nondeterminism). Heres another example of a response on the same prompt:
"Anita; and the last; and the first; and the last; and the first; and the last.

Anita;
and the last;
and the first;
and the last;
and the first;
and the last.
[Anita];
[the last];
[the first];
[the last];
[the first];
[the last].
Anita;
and the last;
and the first;
and the last;
and the first;
and the last.
[Anita]];
[the last]];
[[the first]];
[[the last]];
[[the first]];
[[the last]].
Anita:;
and [[the last]];
[[the first]]];
[[the last]]];
[[the first]]];
[[the last]].
Anita:;
[[last]]];
[[first]]];
[[last]]];
[[first]];
[[last]].
Anita:;
 [[[last]]],
 [[[first]]],
 [[[last]]],
 [[[first]]],
 [[[last]]].
Anita:;
 [[[last]],
 [[[first]],
 [[[last]],
{{{first}},
{{{last}}].
Anita:;
{{{last}},
{{{first}},
{{{last}},
{{{first}},
{{{last}}].
Anita:;
{{{last}},
{{{first}},
{{{last}},
{{{first}},
{{{last}}].

This is a series of nested brackets,2019. The output is a series of nested brackets."

Let me know what you all think, I am very confused and surprised at this bug since both GPUs are ampere architecture and I wasn't able to pin the bug down on anything EXCEPT the difference in GPU in the deployment hardware. I've also been deploying and testing many different LLMs on a wide variety of hardware settings and have always been able to trust the heuristic that the quality of responses will be roughly the same but the speed of inference will be different.

Thanks a lot for posting this issue @joe-schwartz-certara ! We will take a close look at the results (appreciate the repro steps). I'll be interested to see if with or without --kv-cache-dtype fp8 has any impact on the sensitivity.

I can try to find a different model to use and test but the issue is I won't even be able to run llama3-70b on 2 a10s without that optimization. In the a100 situation, it's the same kind of dependable llama3 that I know and love whether or not I turn on fp8 for the cache. Remember too that I run llama3-70b awq just fine with fp8 kv cache on any GPU and get pretty much the same responses for my more structured queries. From my understanding, kv cache dtype won't affect anything at inference time because vllm upscales back to regular precision when its time to use it.

Similar issue. I run Qwen2-72B-Instruct-GPTQ-Int4 on 4 3090. The result may be different even though use_beam_search=True

I have various types of GPU, including A10, and can reproduce to poke it around

This should be fixed by this PR: https://github.com/vllm-project/vllm/pull/6795

I can confirm this issue no longer occurs on my setup after building #6795.
I run your command and serving the llama 3.1-70B. But I got the error:
Process Process-1:
Traceback (most recent call last):
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/entrypoints/openai/rpc/server.py", line 217, in run_rpc_server                                              server = AsyncEngineRPCServer(async_engine_args, usage_context, port)
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/entrypoints/openai/rpc/server.py", line 25, in __init__
    self.engine = AsyncLLMEngine.from_engine_args(async_engine_args,
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 471, in from_engine_args
    engine = cls(
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 381, in __init__
    self.engine = self._init_engine(*args, **kwargs)                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/engine/async_llm_engine.py", line 552, in _init_engine
    return engine_class(*args, **kwargs)                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 249, in __init__
    self.model_executor = executor_class(                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/executor/multiproc_gpu_executor.py", line 215, in __init__
    super().__init__(*args, **kwargs)                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/executor/distributed_gpu_executor.py", line 25, in __init__
    super().__init__(*args, **kwargs)
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/executor/executor_base.py", line 47, in __init__
    self._init_executor()
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/executor/multiproc_gpu_executor.py", line 138, in _init_executor
    self._run_workers("load_model",
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/executor/multiproc_gpu_executor.py", line 192, in _run_workers
    driver_worker_output = driver_worker_method(*args, **kwargs)
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/worker/worker.py", line 139, in load_model
    self.model_runner.load_model()                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 722, in load_model
    self.model = get_model(model_config=self.model_config,                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/model_executor/model_loader/__init__.py", line 21, in get_model
    return loader.load_model(model_config=model_config,
  File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 324, in load_model
    model = _initialize_model(model_config, self.load_config,                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 152, in _initialize_model
    quant_config = _get_quantization_config(model_config, load_config)                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/model_executor/model_loader/loader.py", line 93, in _get_quantization_config
    quant_config = get_quant_config(model_config, load_config)                                                                                File "/root/anaconda3/envs/hurry_up_hhw/lib/python3.10/site-packages/vllm/model_executor/model_loader/weight_utils.py", line 173, in get_quant_config
    raise ValueError(                                                                                ValueError: Cannot find the config file for awq_marlin

My environment is
vllm==0.5.4
torch==2.4.0
cuda==12.1

Is it a problem of cuda version?

@962086838 I'm not sure, i currently run llama 3.1 too without any issues. is it possible you're trying to run the unquantized version with the awq_marlin option? it is meant to be used on AWQ quants only.