feat: blur the composer focus when open context menu

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/44042
PROPOSAL: https://github.com/Expensify/App/issues/44042#issuecomment-2191415145
Tests

Go to any chat
Click on the composer to bring the keyboard (if its not already open)
While the keyboard is open long press on a message to bring the action menu

Verify that: The keyboard closes when the action menu is opened

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat
Click on the composer to bring the keyboard (if its not already open)
While the keyboard is open long press on a message to bring the action menu

Verify that: The keyboard closes when the action menu is opened

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/13fec0b8-39ba-4037-9caa-52de694e63ef

Android: mWeb Chrome

https://github.com/user-attachments/assets/359a03a2-90cd-4a11-907c-7f91d835a297

iOS: Native

https://github.com/user-attachments/assets/24a80c02-337c-4242-96e2-2a49a0586fd3

iOS: mWeb Safari

https://github.com/user-attachments/assets/ab6a7a7c-faf5-49fc-a666-4d9468069399

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/ca68a201-528a-421c-8451-2d9c45fcfee3

MacOS: Desktop

https://github.com/user-attachments/assets/705c7fa6-7bac-4e14-b274-15cd4f2771b3

@dominictb There are conflicts that must be resolved. Please resolve and ping me here when ready for review. Thanks.

waiting on @rojiphil's review.

@dominictb Can you please merge with the latest main? I will review this today.

Also, shouldn't it be ReportActionComposeFocusManager.clear(); here as we do not want to reset the editcomposer if focus already exists on another edit item

You're right, I think we just call ReportActionComposeFocusManager.clear(true) when editComposerRef === textInputRef.current. Any thoughts?

Yes. That make sense.

@dominictb This looks much closer to getting it done. Can you please merge it with the latest main?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: mWeb Safari
https://github.com/user-attachments/assets/dc5e189e-df07-4ff6-9e9f-253c5672cd8f

Android: Native
https://github.com/user-attachments/assets/785985a8-5ea4-41da-9b82-a7402747498b

Android: mWeb Chrome
https://github.com/user-attachments/assets/c7506e5d-cee9-4363-8033-ef8cbcc35c98

iOS: Native
https://github.com/user-attachments/assets/ed1f8e63-6c10-4099-8848-664ddc9c8d25

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/690eb899-47ea-4704-9854-7c3d9d548e10

MacOS: Desktop
https://github.com/user-attachments/assets/56f0cb76-8d84-4d25-b288-0787b1e7338a

mWeb Safari - Original Issue
https://github.com/user-attachments/assets/abe1de9d-ca24-4ac9-8390-5a95942e9bc6

@rojiphil I see a console warning on your iOS video for "Function components cannot be given refs", is that the same as the one in this issue https://github.com/Expensify/App/issues/49062? If so, do we need to merge main into this branch to solve it? If it's different please report it in GH or slack, and don't forget checking for console errors is part of the checklist

I see a console warning on your iOS video for "Function components cannot be given refs", is that the same as the one in this issue #49062? If so, do we need to merge main into this branch to solve it? If it's different please report it in GH or slack, and don't forget checking for console errors is part of the checklist

The warning is the same but this comes up in another flow. I have reported the same in slack here

The linked the same GH issue https://github.com/Expensify/App/issues/49062 on that slack thread. So let's merge main into this branch, test again, and if it doesn't happen, problem solved.
If it does happen, we need to open a new GH issue to solve this for the flow in which is happening

They linked the same GH issue #49062 on that slack thread. So let's merge main into this branch, test again, and if it doesn't happen, problem solved.
If it does happen, we need to open a new GH issue to solve this for the flow in which is happening

I still think they have got it wrong as I could reproduce this in the latest main and the mentioned duplicate issue's PR has already been merged since last one week. And our PR also contains that code. Anyway, I have responded to this in slack here.
Meanwhile, I think we can go ahead and merge this as we have reported it.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


.NET Core WebAPI - .NET 7.0

Wondering if there is a work around for this. I am seeing an error when implementing the "AuthenticationTestHandler" class.
https://learn.microsoft.com/en-us/azure/notification-hubs/notification-hubs-aspnet-backend-ios-apple-apns-notification#create-the-webapi-project

public class AuthenticationTestHandler : DelegatingHandler
{
    protected override Task<HttpResponseMessage> SendAsync(
    HttpRequestMessage request, CancellationToken cancellationToken)
    {
        var authorizationHeader = request.Headers.GetValues("Authorization").First();

        if (authorizationHeader != null && authorizationHeader
            .StartsWith("Basic ", StringComparison.InvariantCultureIgnoreCase))
        {
            string authorizationUserAndPwdBase64 =
                authorizationHeader.Substring("Basic ".Length);
            string authorizationUserAndPwd = Encoding.Default
                .GetString(Convert.FromBase64String(authorizationUserAndPwdBase64));
            string user = authorizationUserAndPwd.Split(':')[0];
            string password = authorizationUserAndPwd.Split(':')[1];

            if (VerifyUserAndPwd(user, password))
            {
                // Attach the new principal object to the current HttpContext object
                HttpContext.Current.User =
                    new GenericPrincipal(new GenericIdentity(user), new string[0]);
                System.Threading.Thread.CurrentPrincipal =
                    System.Web.HttpContext.Current.User;
            }
            else return Unauthorized();
        }
        else return Unauthorized();

        return base.SendAsync(request, cancellationToken);
    }

    private bool VerifyUserAndPwd(string user, string password)
    {
        // This is not a real authentication scheme.
        return user == password;
    }

    private Task<HttpResponseMessage> Unauthorized()
    {
        var response = new HttpResponseMessage(HttpStatusCode.Forbidden);
        var tsc = new TaskCompletionSource<HttpResponseMessage>();
        tsc.SetResult(response);
        return tsc.Task;
    }
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 26be6221-1fbc-c630-db58-223a34b40e07
Version Independent ID: 78506c32-c57f-3149-84b3-d0a35d4bf36b
Content: Send push notifications to specific users using Azure Notification Hubs
Content Source: articles/notification-hubs/notification-hubs-aspnet-backend-ios-apple-apns-notification.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@MobileDev327
Thanks for your feedback! We will investigate and update as appropriate.

@MobileDev327 Thanks for your feedback! We will investigate and update as appropriate.

Thank you!

Hi @MobileDev327 you want to leverage IoC to access HttpContext from your DelegationHandler as shown here. I believe there's been under the hood changes which makes IoC the preferred way. Let us know if this helps.

@MobileDev327,  Just checking in to see if you have had a chance to see the previous response ( from @RyanHill-MSFT). Kindly let us know if you need further assistance on this issue or is good to be closed.

Hello @RyanHill-MSFT and @AjayBathini-MSFT,
So sorry for the delay in my response. Yes, I was able to resolve the issue with the information provided in the link.
Thank you so much for your quick response!

MobileDev327, No worries! Thanks for the update. Glad to know that it's working, much appreciate your feedback.


IntelReports Share to Demo Review

@jrweakland Intel Reports service needs to be shared to demo Review group

@pHill5136 - these portal items will not be shared with the Demo Review Group until the items have the: Title, Summary, Description, Access and Use Constraints, and Credits fields completely filled out. You are also missing all of the proper tags.
https://nsec.esri.com/arcgis/home/item.html?id=60d9c717ebd64314bb1764bd5ea5c96b
https://nsec.esri.com/arcgis/home/item.html?id=b1ab24b97f9f4bd4925d2a5f0b792fce
You named this intel reports and the layers are mission reports and incident reports. Is this correct?

updated metadata on services

Shared with Demo review group - https://nsec.esri.com/arcgis/home/item.html?id=60d9c717ebd64314bb1764bd5ea5c96b

Shared with Demo Review group - https://nsec.esri.com/arcgis/home/item.html?id=b1ab24b97f9f4bd4925d2a5f0b792fce

Closing issue. Changed owner to me and placed in my final review folder.


Bathroom data - VCC

Gather real bathroom data on Voorhees Computing Center.
Update the bathroom data spreadsheet.
Backend:

Edit data.sql

Insert the following into data.sql:

In building table:
-- INSERT INTO building (proper_name, region_id) VALUES ('Voorhees Computing Center', 3);

In building name table:
-- INSERT INTO building_name (name, building_id) VALUES ('Voorhees Computing Center', INSERT NEW BUILDING ID HERE);
-- INSERT INTO building_name (name, building_id) VALUES ('VCC', INSERT NEW BUILDING ID HERE);
-- INSERT INTO building_name (name, building_id) VALUES ('Voorhees', INSERT NEW BUILDING ID HERE);

Insert floor data

Insert floor plan data

Insert bathroom data

Look at existing data.sql for example queries and format.

complete, but might want a guy to verify men's restroom information


Intellisense in gulpfile.js

I have a ASP.NET MVC6 project created in Visual Studio 2015. In the gulpfile.js, I'm using gulp-typescript like below:
var gulp = require("gulp"),
    rimraf = require("rimraf"),
    concat = require("gulp-concat"),
    cssmin = require("gulp-cssmin"),
    uglify = require("gulp-uglify"),
    ts = require("gulp-typescript"),
    project = require("./project.json");

When I type ts. to see the methods it supports, I don't see createProject. How can I get intellisense for gulp-typescript in Visual Studio 2015?

I'm not sure how intellisense works in VS2015. I do know that in VSCode you can just grab a definition file (.d.ts) from Definitely Typed to get JavaScript intellisense, but I don't know whether that works in VS 2015.
Is intellisense working for gulp? Does VS show you that ts is callable?

You can get intellisense in VS 2015 for JavaScript if you use d.ts. But in this case, gulpfile.js is created by the VS ASP.NET template and is used by the build. I don't know whether creating a typescript for gulpfile.js and referencing other d.ts would help? In my opinion, the VS should support intellisense for JavaScript.

It shouldn't matter that the file is generated and used by the build. Can you try to add a d.ts file and reference that from your gulpfile?

@varghesep Is this still an issue?

Sorry for the late response.
It is working now although I did not have to do anything. I use the latest [http://www.microsoft.com/en-us/download/details.aspx?id=48738](ASP.NET and Web Tools) which might have made the reference. What I see is that VS 2015 is loading the intellisense files and show the definition also correctly.

Good to hear that!


Special characters removed

Hi,
I have a problem with some words in French. For exemple: "récépissé" which is transformed to "piss". So "ré", "cé" and the last character "é" are being removed.
Do you have an option to resolve this problem ?
Thanks !

@davenlin19 it's not related to the plugin itself, you should take a look at https://github.com/NaturalNode/natural tokenizer options.


kn/fix cross file backlinks

Fix ArgumentError exception from getDeclarationFromElement
Simplify remappeRealmName

Fixes: #1015

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 88.842%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
2747

Relevant Lines:
3092

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 88.02%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
2307

Relevant Lines:
2621

💛  - Coveralls


No error to debug tag helper rendering

Hi,
After creating a viewcomponent I used the tag helper notation to render in view:
<vc:bread-crumb></bread-crumb> and it dose not work. If I use the @await Component.InvokeAsync("BreadCrumb") it dose work. How to debug the problem ?
I added @addTagHelper *, <assemblyName> in _ViewImports.cshtml

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62cdbf88-1fff-6999-f75a-26fbe730b911
Version Independent ID: bc48b5cb-d500-f75d-8e48-be4d069a9198
Content: Tag Helpers in ASP.NET Core
Content Source: aspnetcore/mvc/views/tag-helpers/intro.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@LucaGabi Do you have a simple project I can see that reproduces the problem?


Add Client Search API Key in Terraform

Also update actions and use index name and endpoint.

:tada: This PR is included in version 2.0.0-next.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Exports + .d.ts emit

This PR is an aggregation of #2008 and #2025 and subsumes them.

Sorry to bother, do you know when this will be landing on master? It’s necessary for me to update dts-generator for use with ES6 modules.

Hopefully by end of week.

Great, thanks!
I hope you feel better soon, @sheetalkamat !


Alex test1

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/cloud-adoption-guide/adoption-stage/test.md
:white_check_mark:Succeeded
View

docs/cloud-adoption-guide/adoption-stage/test2.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enhancements

Description
This pull request focuses on the refactoring and optimization of the model code to enhance readability, maintainability, and performance. The following key improvements have been made:

Code Formatting: Ensured consistent and clean code formatting for better readability.
Type Annotations: Added type hints for improved code clarity and static analysis.
Function Streamlining: Simplified functions and removed redundant logic.
Buffer Management: Ensured proper handling and registration of buffers.
Tensor Operations: Optimized tensor operations in the attention mechanism for enhanced performance.

Changes Made

Classes Refactored:

LayerNorm
Linear
Conv1d
MultiHeadAttention
ResidualAttentionBlock
AudioEncoder
TextDecoder
Whisper

Function Enhancements:

Improved the sinusoids function for positional embedding.
Enhanced buffer management and registration.

Literally less readable, removed docstrings, moved from multiline params to single line, etc
Please refrain from making this kind of PR.


Type ahead support ?

Was wondering how hard it could be to combine with htmx so that as the user types a query the logical set of possible commands is presented .
just an idea :)

Sorry, that is completely irrelevant to this project. These are SQLite extensions, not some kind of web database UI.


[v3]: Indicate supported Node.js versions; test on Node.js v16

Targeting #125

Indicate supported Node.js versions via engines.node in manifest
ci: Test on node.js v16

Can we use same engines.node that noble curves / hashes use?

Can we use same engines.node that noble curves / hashes use?

For sure. I was thinking it's a nice property that each supported major version is also tested in CI, which reduces the likelihood of gaps. And thinking there is little value in maintained support for odd-versioned (non-LTS) majors 19/21.
Requiring higher minor versions of the legacy versions also means we can fearlessly use newer language- and runtime features on 16.x series that may not be available in 16.0.0. Since CI is typically running on latest 16.x. For this reason, I now also added CI running explicitly on the lowest supported versions as well (16.0.0 and 18.0.0).
In any case, updated according to suggestion.


SecureNet - convert from minor to major

The psp.PSP interface function makePayment() currently takes an integer to represent minor units. SecureNet currently takes a float value (major units).
Currently I have wedged in conversion by means of simply dividing by 100. This needs to be fixed as results are rounded badly.

Resolved :: 03b2ee59fe6c55b34e5d587fae60bc7d8f406c5a


Add module verification and blueprintId update

Add check if the module has been installed
Update assign.json file to automatically put the blueprintId

@charotAmine - I'm going to close this PR as I ended up using code from a few different sources to resolve this, but I do really appreciate the work here. I am using the code you submitted for checking the existence of the module, but because I used different code to handle the dynamic replacement of the ID.


Roadmap? Docker image not working

Hello, we are experiencing multiple problems with the Docker image, including the app/console bug, mysql not working, among others.
So two questions:

We found the docker image https://hub.docker.com/r/benoitcocolabs/cocorico-k8s is that perhaps supported? It seems to fail at the installation process, and there are no docs, but still it seems to be the most up-to-date image out there. Comments?

There were numerous mentions about a new strategy for Docker, e.g. https://github.com/Cocolabs-SAS/cocorico-docker/issues/12#issuecomment-463639104
Is there perhaps a roadmap for that release? Should we be expecting that, and if so, when?

Hello @michalmikolajczyk ,
You can pull the new cocorico image to avoid this issue.

This image was just a proof of concept to run Cocorico on Kubernetes clusters.
There is no roadmap, goal is to keep the image updated regarding Cocorico updates.


Add note that TLC isn't guaranteed to find shortest counter-example

See https://www.reddit.com/r/tlaplus/comments/bsvdnp/is_tlc_really_breadthfirst_search/

will do :+1:


Initial query standardization working group proposals.

This is an example for the community to comment on and build from.

online
Online could be real-time or batch
offline
Offline would be batch only?

Just trying to capture the real-time or interactive use case (queries returned in less than a few seconds) vs the run and return format where a job is run and you look at the results minutes, hours or a day later.

Can we add an abbreviation.md or glossary.md with the most commenly used abbrevation?
I think this would help people that come in later to catch up.


Crazyfly 2.0 on the current master does not connect with QGC

@dennisss I have the same problem as in issue https://github.com/PX4/Firmware/issues/7624 with the current master.
I followed the steps for flashing PX4 on crazyflie 2 from this link: https://docs.px4.io/en/flight_controller/crazyflie2.html
It finished flashing (erase, program, verify), but CF wasn’t able to connect with QGC, so I couldn't calibrate.
I tried the latest master, stable and beta (via QGroundControl as well), all of these finished flashing (erase, program, verify), but again CF wasn’t able to connect with QGC.
Then I did a binary search between the latest master and the commit https://github.com/PX4/Firmware/commit/ca82d36c3f84fc7215057113c843cba14bc57626 described in the issue https://github.com/PX4/Firmware/pull/7658, and found the last working commit: https://github.com/PX4/Firmware/commit/c82deaf26f5812e73890bbeef942c35f4687e0c7  Mon Sep 4 11:04:17 2017 that I can flash and connect with QGC, calibrate and so on.

Hi @barzanisar, I don't have one of these, but I might be able to help you debug and get it working again. Then we need to put something in place to keep it working.

yes, please thank you!

Would you like to discuss on the dev call or ping me on slack?

Looks like there was a regression in the defconfig for this platform.
@barzanisar Can you try out this change and see if it resolves the issue: https://github.com/dennisss/Firmware/commit/fcb4ce4bbffbdf856ccc6dfff34aeb674805b560

Yes it works! Thank you!

@dennisss There's one more issue, when I arm the motors, they don't rotate. Even when the arming speed "PWM_MIN" parameter is above 1000us. I tried 1100,1200,1400 us.

@barzanisar make sure that you are using the crazyflie airframe (SYS_AUTOSTART = 4900). The default settings should work and have PWM_MIN, PWM_DISARMED, PWM_MAX set to 0, 0, 255.

@denisss we would like to have the props spinning when armed - what is the best way to achieve that? Without it the flight stability is not optimal in extreme maneuvers

@LorenzMeier if you are referring to spinning props at 0% throttle, then pick your choice of value for PWM_MIN between 0-255 and adjust the value constraints configured here: https://github.com/PX4/Firmware/blob/master/src/drivers/boards/crazyflie/board_config.h#L169

Great, thanks! @barzanisar let me know when you need support on that.

Thanks @dennisss ! When I set PWM_MIN parameter in QGC or PWM_LOWEST_MIN value from
https://github.com/PX4/Firmware/blob/master/src/drivers/boards/crazyflie/board_config.h#L169
, the motors don't spin when armed. However, when I changed PWM_DEFAULT_MIN, the motors rotated when armed with the correct speed as set in PWM_DEFAULT_MIN. So I guess, PWM_DEFAULT_MIN does the job of PWM_MIN, but we have to change it from board_config.h every time.
Also, the cfbridge does not seem to properly communicate the joystick commands from QGC to CF2. When I use USB connection, joystick commands are sent properly and I can arm, disarm and change flight modes. However, when I use crazyradio PA with cfbridge, sometimes I am not able to arm/disarm.
Also, I noticed that when I first connect QGC with CF2 via USB (to calibrate etc) and then unplug usb and connect via crazyradio PA + cfbridge, the following happens:
In manual mode, when I arm using joystick, it denies the Arm command (eventhough throttle is zero from joystick). Then when I switch to altitude mode, it switches to LAND and ARMED mode, the motors start spinning fast. I disarm the motors using joystick button, which QGC reads and disarms the motors.
This doesn't happen when I reflash the firmware and only connect QGC and CF2 via crazyradio PA and cfbridge, i.e. without using the USB connection.
In short, if I flash the firmware, use USB connection and then unplug and use crazyradio PA, QGC is not able to communicate properly with CF2 and I observe the same pattern everytime so it is not a connection lost problem.
On the other hand, if I flash firmware, use crazyradio PA directly, QGC is able to communicate with CF2 but disarming command is not sent sometimes from some flight modes.

Also, when I first built cfbridge and tried "make run" command, it failed to find the radio. Then I followed the steps in https://github.com/bitcraze/crazyflie-lib-python#setting-udev-permissions to set udev permissions and restarted my computer. cfbridge could then find the radio and radio connected.

There's a delay of communication between crazyradio and CF2 and it seems like some messages are being dropped and sent late.

@barzanisar I have noticed the disarm issue in manual flight modes as well, but I am unsure of the exact cause of it. I usually stick to offboard modes, where it is a non-issue for me. Radio loss is a known issue which I believe is due to the Crazyradio PA only being able to receive 31 bytes at a time, so large packets are split. Adding better packet sequencing to the protocol would probably help with this, although right now being conservative with message sending is the best solution I've found so far.

@bkueng @barzanisar should discuss in the afternoon. I think it needs some cleverness on both sides.

Update: @LorenzMeier @bkueng  @dennisss
There were two issues:

Arm or disarm command sent from QGC was not received by CF2. We kind of dealt with this problem by reducing the joystick update rate from 25 Hz to 10 Hz in https://github.com/mavlink/qgroundcontrol/blob/9d5bed4842228dc7f247b1af90fd9020632b6d24/src/Joystick/Joystick.cc#L530 and keeping it consistent 10 Hz in https://github.com/mavlink/qgroundcontrol/blob/9d5bed4842228dc7f247b1af90fd9020632b6d24/src/uas/UAS.cc#L1001-L1012

Sending less Joystick  commands per second allows space for MAV_CMD_COMPONENT_ARM_DISARM command to be sent.

Once we send arm/disarm command, CF2 arms/disarms but COMMAND_ACK is not received by the cfbridge and hence QGC keeps waiting for COMMAND_ACK message and does not respond to other arm/disarm commands we send next. Only when we switch to another flight mode, QGC is programmed such that it stops looking for the ACK message and sends the arm/disarm commands queued up. This I found out from Vehicle.cc

We tried switching to "custom" mode Mavlink from "osd" in  https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d/rcS#L603 and set the rate to 1000.
This was done to ensure that CF2 sends minimal data to QGC and hence the link has enough space for ACK message. "mavlink status" shows that the link has enough bandwidth for ACK message to be sent, yet the cfbridge doesn't receive it.
Now the next step I guess is to debug the bitcraze/crazyradio-firmware to see if it receives the ACK message? Any other suggestions?

Ideas

new PX4 minimal mavlink mode (https://github.com/PX4/Firmware/pull/8947) to send the bare minimum needed for functional QGC. Depends on your exact configuration, but this will likely reduce your mavlink telemetry rate (vehicle -> ground) by at least an order of magnitude.
QGC throttle MANUAL_CONTROL rate based on stick movements or mav command queue depth
QGC prevent excessive message queuing (might be hacky)

https://github.com/mavlink/qgroundcontrol/pull/6138
take a look at Vehicle::sendMavCommand() in this PR where additional commands of the same type are updated in the queue, rather than stacking deeper

@dagar

Custom mavlink mode sends even less data to the QGC as you can see here:
. Yet, this didn't solve the problem of receiving Ack message from the vehicle.

I decreased the joystick update rate which sends less MANUAL_CONTROL id=69 messages to the vehicle so that there is space for MAV_CMD_COMPONENT_ARM_DISARM command to be sent. Is it the same thing you're talking about?

Also, I tested again with reduced joystick update rate, again sometimes MAV_CMD_COMPONENT_ARM_DISARM message is sent by QGC and cfbridge but is lost on the way from radio to the vehicle. I guess I'll have to decrease the joystick update rate even further but it will deteriorate the joytick command response.

I looked at your hack. Your hack works for my case only if I replace the first element of the Queue (which QGC has already sent to the vehicle and is waiting for its Ack message) with the latest command of the same type, i.e. by making these changes:
if (_mavCommandQueue.size() >= 1) {      for (int i = 0; i < _mavCommandQueue.size(); i++)

I was thinking about such a hack as a last resort but was worried about its implications since by doing this, we are simply ignoring the receipt of Ack message which removes the first command from the queue (see Vehicle::_handleCommandAck) and replacing that queued command with the latest command of the same type.

Update:
@dagar @LorenzMeier @bkueng
Issue1: COMMAND_ACK sent from CF2 is received into QGC but discarded
Observation: After digging into the lower level i.e. in syslink module, I found out that some bytes sent by the Syslink::send_message, are randomly not received by the cfbridge. I printed the bytes received in cfbridge by printing this buffer. For example, vehicle's heartbeat payload (of length 9 bytes) sent from CF2 to QGC is dropped sometimes and only header(10 bytes) and checksum(2 bytes) is received. And if the Ack message is unfortunately sent just after this bad hearbeat message, QGC keeps reading the Ack message thinking of it as the payload of the bad heartbeat in MAVLinkProtocol::receiveBytes and then discards forwarding the message to Vehicle::_mavlinkMessageReceived since the Ack message header is larger than the payload expected for the bad heartbeat.
Another possible issue: If some bytes are randomly dropped, it is possible that some bytes of the Ack message are also dropped sometimes. Though I never observed this and only observed payload dropping from heartbeat messages, since of course heartbeat message is more frequently sent.
Issue 2: COMMAND_LONG encoding MAV_CMD_COMPONENT_ARM_DISARM sent from QGC is either received partially or not received at all in CF2
Observation: Some messages sent from QGC and then cfbridge are sometimes not received in CF2 (they are dropped). Hence, the arm/disarm command message (that is longer then 32 bytes and hence is split into two messages in UdpClient::read is either not received at all in CF2 (i.e. both messages are dropped) or received partially (one of the messages is dropped) and this behavior appears to be random.

Solved, see document updated


1.0.2 release

[1.0.2] - 20/10/2018
Fixed

added a fix for 404 errors not working correctly

Pull Request Test Coverage Report for Build 12

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 63.542%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/util/ServerHelper.js
0
4
0.0%

Totals

Change from base Build 8:
-0.7%

Covered Lines:
180

Relevant Lines:
280

💛  - Coveralls


Move clinical notes tab

Moved clinical notes tab from left panel into the Notes Panel. Created a new component in Notes Panel called Note Assistant which contains the context tray and the list of existing clinical notes. This branch does not cover styling of the notes (preview view). That is covered in a different jira task.
Users can click on the arrow in the Note Assistant to switch from viewing the context tray to viewing the list of clinical notes. The clinical notes view has a button go back to editing the current note (functionality of button has not been implemented as it's not part of this task and is part of a different task).
Pre encounter view includes NotesPanel with the editor view disabled as well as the context tray. Only the list of clinical notes is displayed.
Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (N/A) and :white_check_mark:.
Submitter:
Running the Application

[x] Manually tested in Chrome
[x] Manually tested in IE

Documentation

[x] This pull request describes why these changes were made
[x] Recognizes any potential shortcomings/bugs in the description
N/A Cheat sheet is updated
N/A Demo script is updated (current demo script doesn't go over viewing existing notes)
N/A Documentation on Wiki has been updated
N/A Additional technical components and libraries are documented and added to wiki as needed

NoteParser

N/A Note parser has been updated if structured phrases change

Code Quality

[x] 4-space indents - convert any tabs to spaces
[x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[x] Code is commented

Tests

[x] Existing tests passed
N/A Added UI tests for slim mode
[x] Added UI tests for full mode
N/A Added backend tests for fluxNotes code
N/A Added note parser examples to test new functionality

Reviewer 1: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

This looks great!

Everything looks great!
Can we remove the renderedNotes function from DataSummaryPanel.jsx, I don't think it is being called anymore.  I think it may have gotten back in there when the branch was rebased.

I will wait to approve until we answer Dan's question above (DL1?).

Great catch @danlee1025 ! I removed renderedNotes from DataSummaryPanel


[Preview 9] ElementReference and backing fields

Remove @ref:suppressField in examples.
Update text for Removing automatic backing field support for @ref in 3.0.0-preview9.

Resolved by #13860


[WIP] Arch linux support

Hi
I've added image scanning for Arch Linux, but I've run into a couple of problems. I've put the problems in as separate commits:

When versionfmt.InRange is run and the versionA and rangeB are the same, InRange will return false e.g.

VersionA = 5.4.2-1, RangeB = 5.4.2-1 returns false, which means that the vulnerability is not included in the affected namespaced feature.
This doesn't seem right to me, although I could be misunderstanding the idea behind it?

The bigger problem is that Arch Linux stores installed packages as directories under /var/lib/pacman/local as opposed to a single file like Debian. This causes an issue when processing the layers as it will only return the features found in the last layer.

I've put in a hack to append the current features from each layer, which fixes the problem for Arch Linux, but it obviously breaks other image scanners.
I'm a bit stuck on how to process.
Thanks

Why not define a new versionfmt for Arch version strings that works the way they should. It looks like there's a program for comparing version strings explicitly for Arch.
This is actually desirable. We'll aggregate the features together at the Ancestry level. Because layers can be reused across different Ancestries, you actually don't want information from any previous layers.

@hhomar any updates?


Migrate to new envtest tool

As part of https://github.com/humio/humio-operator/pull/355 I had to fix the SHA we use to fetch envtest with so our scripts continue to work for the time being.
We should migrate to the new envtest tool.

Upgrading envtest is done as part of upgrading operator-sdk. At this point we've upgraded to an operator-sdk version that pins envtest to a specific version (and not just a SHA that we did previously). The "new envtest tool" will follow as part of upgrading to future operator-sdk builds.


Each line item shows up multiple times with each refresh

Variables need to be initiliazed to 0 for each api call.

Fix is in https://github.com/minio/buzz/pull/72. Note that this issue is not a regression, as the bug (global variables) was never fixed in the first place.


MovieTexture not found

Hi, build error in AsyncWWW.cs on 5.6.6, MovieTexture class not found, I notice you are using
#if !UNITY_2018_2_OR_NEWER
for MovieTexture class, I think it should be
#if UNITY_2018_2_OR_NEWER

Hi, @imtrobin. I'm not able to reproduce the issue using Unity 5.6.6. There is no compile errors for me.
The #if !UNITY_2018_2_OR_NEWER define is needed because MovieTexture class has been deprecated in Unity 2018.2.
That said, if you could provide more details on the issue, I can investigate it further.

It doesn't happen in editor, try making an Android build. I had errors during build and I had to remove the ! to build the apk.


Allow any newer pytz version

Remove the upper bound for pytz releases. They use date version and it represents the version of the timezone database that it contains. It is safe to keep the upper bound.
It ends up conflicting with Home Assistant pytz version and pip is really strict nowadays.

@Quentame can we get this merged and released? We're getting Home Assistant ready for the new pip and this is one of the last 6 conflicts.

Thanks! Could we have a new release please? 🙏


Reports End Date

When choosing the end date e.g. 31 March 2016 on the cover page, the report subsequently generated indicates one day later (e.g. 1 April 2016).
Could we please change so it reflects the same date (ie. 31 March 2016)

any update on this?

No, has not been a priority

I thought in the last discussion that it was a known issue with a minor fix? Clearly we cannot start sharing any reports with such an obvious bug in the report, so it becomes a major issue!
I have no idea when things and realise you guys are constantly managing different requests all the time, but would be great to put estimated timelines on each of these issues to perhaps better allow us to prioritise them.


Update nodeTemplate on worker pool machineType update

How to categorize this PR?

/area auto-scaling
/kind bug
What this PR does / why we need it:
Currently nodeTemplate's Capacity fields are not updated if a workerPool's machineType is updated.
This happens as we refer to worker resource for already existing nodeTemplate but don't check if the machineType is same or not.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

a bug regarding nodeTemplate ,where its not updated if the machineType is updated for the workerPool, is now fixed.

/invite @rfranzke


Date.fromString crashes the repl

> import Date as D
> D.fromString "test"
TypeError: undefined is not a function

Maybe linked to https://github.com/elm-lang/elm-compiler/issues/1010 ?

This is fixed on master. You can install it easily using this if you don't want to wait for the next release: https://github.com/elm-lang/elm-platform .
Let me know if that doesn't fix it for you.


Fence line - Tree and shrub trimming.

25-01-22 Arbor Master Ltd Tree Specialist attended the Ponderosa and carried out work as per quotation.
"Trim various trees and shrubs overhanging fence line from neighbours property, including Gleditsia over rear corner of garage.
Remove all debris."

04-02-22 Payment of invoice for works.


No longer run app while running test suite. To make test suite more reliable, especially on Travis

Works locally.
See how it works with Travis.

Strangely, on a single, anecdote run of make test, it's actually slightly slower! It seems faster from a IDE. But let's see if this helps make it run on Travis more reliably.
Before PR
Fri Feb 17 13:50:05 +08 2023
$ make test
Tests Passed: 0 failed, 349 total (314.398 seconds)
Fri Feb 17 13:56:39 +08 2023
so 6m 34s
After PR
Fri Feb 17 13:35:35 +08 2023
$ make test
Tests Passed: 0 failed, 349 total (327.396 seconds)
Fri Feb 17 13:42:30 +08 2023
so 6m 55s

Closing for now


[event publisher change] in event "Copy Document Mgt." (Codeunit 6620)

Dear Support,
Could you please modify the publisher in "Copy Document Mgt." (Codeunit 6620) and a bit the following code? The publisher name is: "OnCopyPurchDocOnAfterCopyPurchDocLines".
<<<<< Original Code >>>>>
[IntegrationEvent(false, false)]
    local procedure OnCopyPurchDocOnAfterCopyPurchDocLines(FromDocType: Option; FromDocNo: Code[20]; FromPurchaseHeader: Record "Purchase Header"; IncludeHeader: Boolean; var ToPurchHeader: Record "Purchase Header"; MoveNegLines: Boolean)
    begin
    end;

OnCopyPurchDocOnAfterCopyPurchDocLines(FromDocType.AsInteger(), FromDocNo, FromPurchHeader, IncludeHeader, ToPurchHeader, MoveNegLines);

        if ReleaseDocument then begin
            ToPurchHeader.Status := ToPurchHeader.Status::Released;
            ReleasePurchaseDocument.Reopen(ToPurchHeader);
        end else
            if (FromDocType in
                ["Purchase Document Type From"::Quote,
                 "Purchase Document Type From"::"Blanket Order",
                 "Purchase Document Type From"::Order,
                 "Purchase Document Type From"::Invoice,
                 "Purchase Document Type From"::"Return Order",
                 "Purchase Document Type From"::"Credit Memo"])
               and not IncludeHeader and not RecalculateLines
            then
                if FromPurchHeader.Status = FromPurchHeader.Status::Released then begin
                    ReleasePurchaseDocument.SetSkipCheckReleaseRestrictions();
                    ReleasePurchaseDocument.Run(ToPurchHeader);
                    ReleasePurchaseDocument.Reopen(ToPurchHeader);
                end;

<<<<< Modified >>>>>
[IntegrationEvent(false, false)]
    local procedure OnCopyPurchDocOnAfterCopyPurchDocLines(FromDocType: Option; FromDocNo: Code[20]; FromPurchaseHeader: Record "Purchase Header"; IncludeHeader: Boolean; var ToPurchHeader: Record "Purchase Header"; MoveNegLines: Boolean; var ReleaseDocument: Boolean; var IsHandled: Boolean)
    begin
    end;

Add "IsHandled" To local var selection
OnCopyPurchDocOnAfterCopyPurchDocLines(FromDocType.AsInteger(), FromDocNo, FromPurchHeader, IncludeHeader, ToPurchHeader, MoveNegLines, ReleaseDocument, IsHandled);

      if not IsHandled then
        if ReleaseDocument then begin
            ToPurchHeader.Status := ToPurchHeader.Status::Released;
            ReleasePurchaseDocument.Reopen(ToPurchHeader);
        end else
            if (FromDocType in
                ["Purchase Document Type From"::Quote,
                 "Purchase Document Type From"::"Blanket Order",
                 "Purchase Document Type From"::Order,
                 "Purchase Document Type From"::Invoice,
                 "Purchase Document Type From"::"Return Order",
                 "Purchase Document Type From"::"Credit Memo"])
               and not IncludeHeader and not RecalculateLines
            then
                if FromPurchHeader.Status = FromPurchHeader.Status::Released then begin
                    ReleasePurchaseDocument.SetSkipCheckReleaseRestrictions();
                    ReleasePurchaseDocument.Run(ToPurchHeader);
                    ReleasePurchaseDocument.Reopen(ToPurchHeader);
                end;

Additional context
We need to skip the Release part of the code for several times due to a customer condition.
Thank you in advance.
Internal work item: AB#555035

Related to https://github.com/microsoft/ALAppExtensions/issues/27417

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 27480.


Update dependencies and test suite

Depends on #8
Ticket https://app.shortcut.com/mineiros/story/6291/update-terraform-google-organization-policy-module

Isn't this PR includes #8?

yip as written in the description, it depends on #8 :)

blocking till #8 is merged, could you reverse the PRs?

closed the other PR, deleted the commit in this branch


Metamodel bug in JS

As moved from https://github.com/ceylon/ceylon-ide-eclipse/issues/1321
Apparently there's a difference in initialisation between traversing a module to get a private function and getting just that function from the metamodel.
Easy to reproduce: just add an unshared test in the SDK and call it:
../ceylon-dist/dist/bin/ceylon test-js --test 'test.ceylon.collection::testUnshared' test.ceylon.collection

So the code does:
Package? findPackage(String pkgName) {
    for(m in modules.list) {
        if( pkgName.startsWith(m.name) ) {
            if( exists p = m.findPackage(pkgName)) {
                return p;
            }
        }
    }
    return null;
}

if (exists pkg = findPackage("test.ceylon.collection")) {
 value decl = pkg.getMember<FunctionDeclaration|ClassDeclaration>("testUnshared");
 if (is FunctionDeclaration decl) {
    if (decl.toplevel) { // I THINK this is where it fails
    }
}
}

Lemme try to resolve this before @chochos wakes up.

OK I can reproduce in the language module tests:
[ceylon-run-js] ceylon.language::NativeError "TypeError: Cannot read property 't' of undefined"

But the function must be in a separate module.

So there's no runtime metamodel, so we use meta, we call _findTypeFromModel(pkg,meta); and it fails to find the type:
[ceylon-run-js] Could not find decl named unsharedFunction looking for unsharedFunction
[ceylon-run-js] Model contains keys:
[ceylon-run-js]  $CCMM$
[ceylon-run-js]  Type
[ceylon-run-js]  $init$Type
[ceylon-run-js]  $mod$ans$
[ceylon-run-js]  $pkg$ans$modules$imported
[ceylon-run-js]  $pkgunsh$modules$imported
[ceylon-run-js] tipo: undefined

The model file contains:
(function(define) { define(function(require, ex$, module) {
ex$.$CCMM$={"$mod-deps":["ceylon.language\/1.1.1"],"$mod-name":"modules.imported","modules.imported":{Type:{super:{md:"$",pk:"$",nm:"Basic"},pa:1,mt:"c",nm:"Type"},unsharedFunction:{$t:{md:"$",pk:"$",nm:"Anything"},mt:"m",nm:"unsharedFunction"},"$pkg-pa":1},"$mod-version":"1","$mod-bin":"8.0"};
});
}(typeof define==='function' && define.amd ? define : function (factory) {
if (typeof exports!=='undefined') { factory(require, exports, module);
} else { throw 'no module loader'; }
}));

So it is there.

OK, found it, it was hiding in the $pkgunsh$modules$imported member.

Fixed!

So you filed a JS metamodel issue, documented it, and fixed it, all in an hour? Wow.

Well, it took me an hour more to find that it was a metamodel issue ;)


changedGoToAPIToGoToService

as api is depreciated, I changed the link to go the newly created services/routes page

NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch,
and ensure you followed them all:
https://github.com/Kong/getkong.org/blob/master/CONTRIBUTING.md
Summary
SUMMARY_GOES_HERE
Full changelog

[Edited docs to ...]
[Added cool new feature ...]
...

Issues resolved
Fix #XXX

Checklist:

[ ] Commit message & atomicity checked
[ ] Documentation
[ ] Spellchecked my updates
[ ] Ready to be merged

@john-paul-keenan are you able to update this PR as requested and resolve merge conflicts?

@coopr I actually need someone with a bit more git knowledge to help. I'm not sure how to correct this

@john-paul-keenan you might want to just close this PR, and open a new one that fixes this in the EE 0.32 and 0.33 docs at the same time.


Wellhello

Text me

Hello

Who is this. Why did u say text me!!
On Sep 14, 2017 1:17 AM, "Daniel Hwang"<EMAIL_ADDRESS>wrote:

Closed #441 https://github.com/github/opensource.guide/issues/441.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/opensource.guide/issues/441#event-1248511241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdE9QrHT-SVpLmz4hzIyUu1t1Sl7hpDGks5siLbggaJpZM4PXD1H
.


Added ability to provide an overlay such as UIVisualEffectView

Sometimes it's necessary to show an overlay over main view. This overlay could be any UIView instance.

Hi @vkaramov, thanks for making this suggestion to SideMenu.
After reviewing your code, I'm choosing not to merge this for the following reasons:

The functionality you seek can likely be accomplished by using the UISideMenuNavigationControllerDelegate methods. If you want a generic solution that works for all of your screens, you can extend UIViewController with those delegation methods to perform your overlay changes.
Given that your desired functionality should be achievable with the current code, adding additional code to this repo is a liability and requires ongoing maintenance and testing of this feature in the future.

If you disagree with these reasons, please reply with your thoughts for additional consideration.
Thanks again!

@vkaramov See See https://github.com/jonkykong/SideMenu/issues/575#issuecomment-801811361. You just need to replace UIView with UIVisualEffectView.


Implement markdown link syntax and "follow link" popup.

Pull Request Description
Fixes #9907
Implements link support in the comment markdown editor. Supports both markdown-style links and auto-detection for raw URLs.
https://github.com/enso-org/enso/assets/919491/b38f860a-ee4a-41a8-b936-41e9ef1602b9
https://github.com/enso-org/enso/assets/919491/059beca2-7737-41a1-a136-31a42ef9ee48
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.

Yeah, we are now supporting arbitrary linking intentionally, therefore TRUSTED_EXTERNAL_HOSTS doesn't make much sense anymore.

The bundling issue was fixed by removing PlainTextEditor's dependency on MarkdownEditor/formatting.ts.


What is embed_files in Custom Dataset

torchmdnet.dataset.custom.Custom take 3 arguments: coordglob, embedglob, energyglob.
For each file:

Coord is a numpy array of lenght N with N the number of atom in the molecule
What is embed ? My first guess was a numpy array with the Z of each atom, but this don't match the dimension
What is energy ? Energy array seems to match the dimension of the coord array

Maybe this test will help clarify:
https://github.com/torchmd/torchmd-net/blob/e20876ff79fe952db25e5fc55cc051a919ef218f/tests/test_datasets.py#L13-L45

coord is an array of shape (n_molecules, n_atoms, 3)
embed (could be z or whatever you want to use for the embedding) is an array of shape (n_molecules, n_atoms), note that the class refers to it as "z" anyhow.
energy is an array of shape (n_molecules, )

I am closing this, please feel free to reopen if you have further questions about it!

Yes this was clear thanks !


RainLoop logs out while logging in with a new user

I have the following issue while loading some of my mailboxes. Most of them work fine but some of them just don't work. They start to load, but at the end of the loading process it just fall back to login screen.
I checked mailboxes itself, they are working fine in other clients. Also, RainLoop tested the connection, there was no problem on network side. Mailboxes are not significantly bigger than other ones.
Might it be a issue with number of mailbox I have added?
Just as a sidenote, the mailbox I cannot access is a newly created one.
Does anyone have a clue?
The Rainmail log shows:*
[14:14:08.528][a0a7732f] IMAP[DATA]: < * BYE Internal error occurred. Refer to server log for more information$
[14:14:08.528][a0a7732f] IMAP[ERROR]: Stream Meta: Array
(
[crypto] => Array
(
[protocol] => TLSv1.2
[cipher_name] => ECDHE-RSA-AES128-GCM-SHA256
[cipher_bits] => 128
[cipher_version] => TLSv1.2
)
[timed_out] =>
[blocked] => 1
[eof] => 1
[stream_type] => tcp_socket/ssl
[mode] => r+
[unread_bytes] => 0
[seekable] =>
)
IMAP[ERROR]: MailSo\Net\Exceptions\SocketReadException: MailSo-Net-Exceptions-SocketReadException (NetClient.php ~ 515) in /var/www/rainloop/rainloop/v/1.12.0/app/libraries/MailSo/Net/NetClient.php:515

Found the problem, it was with the way the user was created. It had no /home/user in the server created. Possibly it was because it was created using useradd (which doesn't create folders automagically) instead of adduser.


Adding type checking of bodyless predicates

Predicates of the form
/**
 * first_string(+X:list(string), ?Y:string) is det.
 */
first_string([X|_],X).

Were not being recognised by term expansion as they have an empty body and the pattern matching was on :-
This fix checks to see if the Term is none of the other known Term types which can exist at top_level, and if it is not it creates a :- and adds the type checking to the body.

Thanks for the pull request.  I'm no longer using or maintaining mavis, so I don't plan to take any action here.  If you're interested in taking over maintenance, I'll gladly investigate what's required to make that happen.

What are the overheads so far of being maintainer? I'm planning on using mavis in anger so it might be worth taking it over.

What are the overheads so far of being maintainer?

Your pull request is the first one I've had in a couple years, so being the maintainer shouldn't require much effort.  You'll need an SWI-Prolog installation so you can run the tests and upload new releases with pack_install/1.  That's about it.

Ok, I'd be willing to act as maintainer so.

I've modified the README to point at your GitHub repository.  I'm archiving mine so that people know it's no longer active.  Thanks.


abnormal exit

terminate called after throwing an instance of 'std::bad_cast'
what():  std::bad_cast
probably while access denied to proc
Fatal: Failed to stat file /proc/xxxx/fd/yyyy
and
Fatal: Trying to add file while file num already open

Are you running the tool with sudo / root permissions?


mwc-button ripple is not robust to css rotation

Describe the bug
The center of the ripple ellipsis is not centered with the button anymore when it is rotated
To Reproduce

Go to  https://material-components.github.io/material-components-web-components/demos/button/
in the console:  document.querySelector('mwc-button[icon=code]').style.transform='rotate(90deg)'
click on the button

Expected behavior
Ripple should adjust to rotated elements.
Screenshots

I can reproduce this bug, but I'm pretty curious, in what scenarios outside of circular buttons would you need to rotate a button 90 degrees?

@cryptoAlgorithm
For instance, for a feedback tool where a (rotated) button would slide in from the right of the screen. It would appear after the app is used for some time, and then hide itself if not clicked. Clicking on it opens a feedback dialog:
I agree, it is a niche scenario.
Smth along:

This is a problem with base MDC styles too. Moving this issue there instead


Does not patch rest api #1

Disable new admin token generate end point functionality for 2fa
allow merchants to use existing token generate service without enabling 2fa

Thank you @Jitheesh. Can you please list out steps that I can take to test this?

Hi @markshust
In 2.4.1, Magento changed api end point for admin token generate.
`Two-Factor Authentication is implemented for Magento Web APIs with the following changes:
AdminTokenServiceInterface::createAdminAccessToken() throws an exception when the Admin user doesn’t have personal 2FA configured, and also indicates that the confirmationh email has been sent.
AdminTokenServiceInterface::createAdminAccessToken() throws an exception that indicates which provider is configured for the user and suggests a provider-specific login endpoint.
2FA provider-specific endpoints allow each Admin user to configure a personal 2FA and provides tokens for username, password, and OTP (2FA code).`
So to disable 2fa from token generate api, I've re-enabled our previous token generate end point. ie, if you disable 2fa for token generate, you can continue to use existing end point. Otherwise you should configure 2fa and integrate new end point.
Test steps

upgrade Magento to 2.4.1
Try to generate admin token using rest api end point
POST /V1/integration/admin/token
Magento will return error
Open store configuration and disable 2fa for token generate
Try to generate admin token, it will respond with token

I can confirm that this fix works, can we merge it?

I'm taking the updates, will be pushed momentarily

I'm taking the updates, will be pushed momentarily

Thanks @markshust for your code styling suggestions, It is really helpful.

Thanks @markshust for your code styling suggestions, It is really helpful.

Sorry to be "that guy who's late to the party with a problem" but these changes fail to parse with PHP7.3
Typed props only appeared in 7.4 - and I wouldn't mention it at all, except composer specifies php>=7.3

Sorry to be "that guy who's late to the party with a problem" but these changes fail to parse with PHP7.3
Typed props only appeared in 7.4 - and I wouldn't mention it at all, except composer specifies php>=7.3

Thanks @cmacdonald-au and @Rud5G -- definitely a mistake on my part. Fixed that in https://github.com/markshust/magento2-module-disabletwofactorauth/issues/6

Thanks @cmacdonald-au and @Rud5G -- definitely a mistake on my part. Fixed that in https://github.com/markshust/magento2-module-disabletwofactorauth/issues/6


Bugfix: DOM elements werent appended to body in Firefox + Bootstrap3's f...

According to Bootstrap3's doc (http://getbootstrap.com/css/#responsive-utilities):
The classes .visible-xs, .visible-sm, .visible-md, and .visible-lg also exist, but are deprecated as of v3.2.0. They are approximately equivalent to .visible-*-block, except with additional special cases for toggling table-related elements.
We should insert classes visible-*-block to ensure forward compatibility.

I tested version 3.3.4 of Bootstrap stylesheets on Firefox 36.0.3 and everything works as expected. If you've found an edge case where it doesn't work, could you try to reproduce the problem by creating a jsfiddle and providing more information on the problem?
Unfortunately, I can't accept your pull request, because I failed to reproduce the problem it's meant to fix. Additionally, it reintroduces the necessity of adding the 4 divs into DOM manually, which for simplicity's sake, I'd like to avoid.
Thanks for pointing out the visibility classes changes. I'll introduce them in the new version, along with a few more features.

I'll try to make it reproducible.

Hi Maciej,
Unfortunately I could not reproduce the bug on jsfiddle. But you can download an HTML file under https://www.wetransfer.com/downloads/63a46c3afe96fe62074b44a2796eab1720150413090316/23c0c69f67ce99db32847dec495eb3c420150413090316/2ea3ce where the bug should occur. I tested it under two different versions of firefox and chrome.
Regards

Hi Felix,
Thanks for the example. The reason why the standard .is() method does not work for you and works in the example, is because you've included the library in <head> section, while as the example uses `.
In your case, there's no <body> to append to yet, at that point, hence the broken functionality. Try moving your script and library inclusion to <body> and it will start working.
Now for cases, where for some reason you'd have to keep your script and library inclusion in <head>, here's a temporary solution:
The last line of Responsive Bootstrap Toolkit is })(jQuery);. This means everything within ResponsiveBootstrapToolkit expression will be evaluated immediately. You can remove (jQuery) to postpone the execution until the point you're sure the document has been fully initialized.
We'll run ResponsiveBootstrapToolkit after document has fully loaded as follows:
$(document).ready(function() {
    (function($, viewport){

        if (viewport.is('xs')) {
            alert('XS');
        }

      })(jQuery, ResponsiveBootstrapToolkit(jQuery));
 });

Thanks for pointing out this behaviour. I'll take a look at a cleaner solution some time soon.
Best regards,
Maciej

Thanks for your solution.
As moving our JS code after the  tag is still in our pipeline, I wont dig any further and use my version as it is, more or less...
...I was indeed appending too many div's https://github.com/felixmaier1989/responsive-bootstrap-toolkit/commit/c9e160ede57345d4dda8201baa99773db50ff3ab


About dataset update interval

Hi,
A quick question is that if the total iteration is 30k, and the update interval is 2.5k, only (30/2.5)=12 images will be edited, which seems to be usually smaller than the dataset size. Is there something wrong with my understanding?
Best,

Hi @pansanity666, sry this seems to be a separate question: I wonder if you are able to get the most up to date code working? for me it runs without calling ip2p and doing the editing : /

@pansanity666 Gotcha, if you do it would be greatly appreciated if you can lmk hows it going cuz im having this issue: https://github.com/cvachha/instruct-gs2gs/issues/10

Hi @pansanity666, the full dataset of training images is edited/updated every 2.5k iterations. The pipeline in igs2gs_pipeline.py first edits all dataset images with Instruct-Pix2Pix, then trains the splat for 2.5k iterations, then repeats the process.

Hi @pansanity666, the full dataset of training images is edited/updated every 2.5k iterations. The pipeline in igs2gs_pipeline.py first edits all dataset images with Instruct-Pix2Pix, then trains the splat for 2.5k iterations, then repeats the process.

Hi,
I understand your explanation but still kind of confused by the implementation code:

It seems that you just edit 1 image every config.gs_steps here https://github.com/cvachha/instruct-gs2gs/blob/5890babbe169857e6764390e365f54ada8675783/igs2gs/igs2gs_pipeline.py#L115-L132

Editing the whole dataset might be very time-consuming, making the training very slow?

Best,

Hi, it iterates through all training images and edits one image at a time (also which ends up training 1 iteration per edited image), so the first [num of images] iterations are just for editing each individual image and training after replacing the original image with the edited one.
Once the full dataset has been updated (and it has trained for [num of images] iterations), we train for 2.5k (gs_steps) iterations on all the edited images, which applies the edit over the entire splat.
Since the edits are progressive (editing over the previously edited images after each dataset update), we generally recommend 2-3 dataset updates (training for about 5k-7.5k iterations). Editing the full dataset is a little time consuming (few seconds per training image) but applying the edits on the splat (training for 2.5k) is pretty quick.


fix(deps): force deps version for shadowJar to allow import in other …

…plugins

I'm not sure about this change...
I think we are in a wrong situation because we are using shadowJar for a library meaning we embark unwanted dependencies without the ability to provide transitive dependencies as-is...
Or we could but it would get verbose because we would have to duplicate the include inside the shadowJar.
The chosen fix here is to force the resolution version but it leads to some cons:

Idk if dependabot will be able to detect it and ensure we up the version as it goes
Shadowing dependencies is such a bad practice imo because it could lead to dependencies conflicts which would not be detected by gradle you lose track of which dependency brings what due to shadowJar when you're on the final project which is importing it...

WDYT ?

Also, another solution would be to exclude dependency conflicts brought by docker-java-client since it brings a lot of old versions which leads to tests failing


Update Composer dependencies (2020-11-14-00-04)

Visual regression test passed!
View the visual regression test report


[youtube] - Extra filtering arguments for comment fetching.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
N/A
Example URLs
Does not apply, any youtube video would be applicable for this.
Provide a description that is worded well enough to be understood
I wish there was a more fine grained way to filter which comments are downloaded with the --write-comments feature already available.
Like being honest here, 99% of youtube comments are useless, so I don't care about archiving all of them.
But, there is some exceptions, some Youtubers use the comments sections to add additional info, that it should be in the description but they put it in comments. They are usually pinned so they appear at the top, but not always. They also reply to some comments adding extra info related to the video, not always but sometimes.
So basically what I would like to be able to do, or at least some of it:

Filter by users. Like I want to save only the author comments for example. Basically a whitelist.
Filter by all the comments involving a user and the related comments. So if the user gets replies to his comments that thread is archived, if the user replies to somebody that thread gets archived, etc. So we get the user comments and the related context.
Filter by pinned, so only the pinned comment (not sure if there can be multiple) are fetched.
Inverse filters, like all comments except the ones from these users, like a blacklist, or other situations where an inverse filter would make sense.
Filter by age, so only download comments from the last two months, or only the first comments on the video (as in the oldests ones)... etc
Filter by content, like be able to filter comments by their content, some regex would be fine.  So be able to filter short comments like "Great", "Thanks for the video", etc..
Any other option.

This can be done after the comments are downloaded, with a script to process the downloaded data file, so I don't expect here to have a perfect solution with lot of filters possible, but I feel like some extra filtering could added, maybe the simplest ones like download the pinned comment.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
N/A

We can only extract comments in order. You can use an external script to filter it as you want after the extraction is done.

This is out of the project's scope. Besides, we can only extract comments in order anyway. It's best to just use an external script to filter it as you want after the extraction is done.

Ok, I understand I was hoping for something at least but I understand.
Hopefully we can get the "pinned" status in the output, it seems in the code is already being tracked (to avoid some kind of loop it seems), https://github.com/yt-dlp/yt-dlp/blob/6f10cdcf7eeaeae5b75e0a4428cd649c156a2d83/yt_dlp/extractor/youtube.py#L3352 ,  but it's not in the output and I was hoping to use it. But in any case I saw there is a related issue open already for it so I will not open a new one: #5411


Blender/GLTF vertex coloring is changed on import.

Tested versions
reproducible in v4.3.dev6.mono.official [89850d553]
System information
Godot v4.3.dev6.mono - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>61) - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)
Issue description
issue possible related to https://github.com/godotengine/godot/issues/87486.
when exporting a mesh from blender 4.0 to using gltf, the vertex colors are not imported correctly and appear different in godot. attach is a screenshot of the vertex colors in blender and the imported result in godot. the data has been changed as you see jagged edges / harder transitions in the colors as well as slighter darker colors. (is vertex color being compressed?). if you export from blender to gltf and then reimport, you will see there is no change in the colors. (blend file attached)

Steps to reproduce
-create a mesh in blender 4.0 with a range of vertex colors (colors near black seem to be problematic the most)
-export the mesh using the gltf exporter in blender
-import the glb file in godot and apply an unshaded material which displays the vertex color to albedo
Minimal reproduction project (MRP)
vc issue MRP.zip

Is this potentially related to what this asset is trying to fix? https://godotengine.org/asset-library/asset/2905 changed behaviour in Blender 4.1.

Is this potentially related to what this asset is trying to fix? https://godotengine.org/asset-library/asset/2905 changed behaviour in Blender 4.1.

No, thats an issue with the gltf exporter not exporting vertex color at all in 4.1. oops sorry this actually applies to blender 4.0 i meant. I will update the description.

I was about to open a new issue with a problem importing a GLB model with color attributes. I have almost zero experience with Blender but I think vertex coloring is the same as using color attributes in Blender (with domain set to Vertex).
Since this is a voxel based model with a clearly defined texture (the eyes in the face and other details) it is easy to see that the colors are incorrectly applied. But if you open the advanced importer dialog in Godot then it looks fine so Godot is reading the format without issues.

Try disabling Meshes > Generate LODs in the import options.

@Calinou That worked for my case, thanks!! so then my issue was a different one than the described in the first post.

I just wanted to show this comparison which shows that there is way more saturated red in the imported colors in godot as seen here. This is was just done in godot 4.3 where the issue remains.

just a thought but, is it possible the vertex colors are being compressed somehow by godot on import?

just a thought but, is it possible the vertex colors are being compressed somehow by godot on import?

You can force disabling mesh compression in the Import options (Force Disable Compression).

just a thought but, is it possible the vertex colors are being compressed somehow by godot on import?

You can force disabling mesh compression in the Import options (Force Disable Compression).

oh? I thought that mesh compression only compressed the vertex positions. it does colors and uvs as well?


refine log for cop/batch cop

What problem does this PR solve?
Issue Number: close #8181
Problem Summary:
What is changed and how it works?

refine the log of cop/batch cop
refine the log inside client-c for remote read
update client-c to fix some minor bugs

Before this pr, the log for cop/batch cop is
[DEBUG] [PhysicalPlan.cpp:84] ["tidb table scan has runtime filter size:0"] [source=CoprocessorHandler(stream)] [thread_id=240]

The log for client-c remote read is
[INFO] [<unknown>] ["thread start."] [source=pingcap/coprocessor] [thread_id=250]

After this pr, these log will be
[DEBUG] [PhysicalPlan.cpp:84] ["tidb table scan has runtime filter size:0"] [source="Coprocessor, is_remote_read: true, start_ts:<PHONE_NUMBER>61370884, region_info: {1125035, 2, 1088}, resource_group: default"] [thread_id=283]
[INFO] [<unknown>] ["thread start."] [source="MPP<gather_id:<gather_id:1, query_ts:1697002862090574000, local_query_id:26, server_id:1412, start_ts:444859118274478084, resource_group: default>,task_id:1> pingcap/coprocessor"] [thread_id=287]

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests


Add biber package for Ubuntu installations

This may fix an issue uncovered by @newtonj in installing Scriptorium on new Ubuntu installations. biber is used/assumed, but not installed by default. This may be due to package dependencies changing, or simply a missed package.

Installing the biber package seems to fix the glitch. Pulled.


Broken query in PagePermissionPolicy.get_all_permissions_for_user()

Issue Summary
I am using django-allauth to handle external user signups, allowing each user to create a so-called PartnerAccount. Upon signup, I create a profile (PartnerPage) for each such account, which is a subclass of Wagtail's Page model . Each user should be able to manage their profile without having access to the entire Wagtail backend. The profiles will be shown to the general public on the frontend of my site.
To achieve this, I assign each user to a dedicated group (created using Wagtail's GroupForm) and grant the group all relevant permissions (e.g., add_page, access_admin, edit_page, ...). The group assignment and permissions setup appear to work correctly in the admin UI when logged in as a superuser (I can see that all groups and permissions are set up correctly).
However, when I try to access Wagtail's admin area with a user created via django-allauth, I receive this error:
ValueError: Cannot query "<User Object>": Must be "Group" instance.
The error seems to stem from a faulty query in Wagtail's permission system, specifically in wagtail/permission_policies/pages.py.
Steps to Reproduce

Create a new Wagtail project with wagtail start myproject.
Install and set up django-allauth for user registration.
Create a profile page for each user and a corresponding group with permissions (add_page, access_admin, etc.) using Wagtail's GroupForm (outside of the Wagtail admin UI)
Assign the user to the group and attempt to access Wagtail’s admin UI as the external user (not a superuser).
Observe the error when trying to load the page edit view in the Wagtail admin.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project.
Technical details

Python version: Python 3.12.7
Django version: Django 5.0.9
Wagtail version: Wagtail 6.2.2
Browser version: Chrome Version 129.0.6668.100

Working on this
The issue is that Wagtail's permission system tries to query like this:
GroupPagePermission.objects.filter(group__user=user)
Since the Group model in Django does not have a user field, the query fails.
Instead, the query should be performed through the user's group memberships. For example:
GroupPagePermission.objects.filter(group__in=user.groups.all())
I would be happy to create a PR for this, but I want to confirm that the error is not on my local side of things.

PS: I'm wondering why this works for regular users but not for the ones I created via django-allauth, since both should be using the same authentication models under the hood.
PPS: If anyone here can help me to enable external users to manage a page with or without Wagtail UI, please let me know!

Hi @maximiliancw - thanks for the report. However, this doesn't give us enough detail to replicate the issue - for example, rather than saying "Create a profile page" you need to provide us with the exact code you're putting into models.py. Otherwise, someone following these steps is going to arrive at different code to you, and there's no guarantee that their version will produce the error.

Since the Group model in Django does not have a user field, the query fails.

The user relation on Group is set up by the groups relation on Django's PermissionsMixin (note the line related_query_name="user", which sets the name for the reverse relation to use in filter expressions):
https://github.com/django/django/blob/cee95e6172f2ea3dbf8cfd4214562cfc92f95392/django/contrib/auth/models.py#L323-L333
I'm not familiar enough with django-allauth to know whether it uses something else in place of PermissionsMixin, but this is documented as a requirement for custom user models in Wagtail - https://docs.wagtail.org/en/stable/advanced_topics/customisation/custom_user_models.html#creating-a-custom-user-model


Upgrade VTK.

Fixes
https://github.com/CDAT/vcs/issues/399

@muryanto1 You'll need to merge this as well.

@muryanto1 You'll need to merge this as well.

Thanks Dan for the reminder. I pulled out vtk-cdat to be a separate repo, and this change is in https://github.com/CDAT/vtk-cdat/tree/upgrade_vtk at the moment, and it will be merged to the master branch once I complete the testing.  The reason for me to pull vtk-cdat out and make it to be a separate repo is so that I can use same conda-recipes' build_tools/conda_build.py to build the vtk-cdat packages. I am building all packages in parallel in Circle CI now, and that whole build take about 1 1/2 hr (vs. 8 - 10 hours before).


Extension issue

Issue Type: Bug
Extension Name: LiveServer
Extension Version: 5.6.1
OS Version: Windows_NT x64 6.3.9600
VS Code version: 1.57.0

:warning: We have written the needed data into your clipboard. Please paste! :warning:

I've been having issues with LiveServer, When I open the file with LiveServer it just shows me the port 5500 but it does not open the Chrome window.


Build fails

Building different targets with make after running cmake generates a myriad of different error messages. Some are compiler related, e.g. #error due to lacking c++11 support, and some are related to library specific function calls, e.g. omp_get_max_threads due to not linking with -fopenmp. None of these errors are justified however, as the target system does provide support for the error messages just mentioned. Below is a selection of make commands and some of their related error messages that I get on the target system: Linux x86_64, 4.4.0-135-generic, Ubuntu 16.04, g++ 5.4.0.
Error: make
error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.

Error: make StaticBoundaryDemo
error: ‘omp_get_max_threads’ was not declared in this scope

Error: make DynamicBoundaryDemo
error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.

Error: make SPlisHSPlasH
error: ‘omp_get_max_threads’ was not declared in this scope

These are purely build related, as the support is there, the build system just don't detect the required tools.
A pointer (no pun intended) in the right direction would be much appreciated.

The openmp errors should be fixed in the current version. The problem was a missing compiler flag in the debug build. However, I cannot reproduce the C++11 problem.

So,how to solve the openmp errors?

Okay, so the errors related to openmp are gone now, thanks! However, I still get the following error:
/usr/include/c++/5/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.

I've tried setting the cmake environment variables to reflect the ISO C++ 2011 standard, but no luck. It should be noted that I don't have much experience with cmake, so it's possible I'm overlooking something trivial. I'm building the project using:
cmake CMakeLists.txt -DCMAKE_CXX_COMPILER="/usr/bin/g++" -DCMAKE_CXX_FLAGS="-std=c++11" -DCMAKE_CXX_STANDARD=11

This is strange since I set the C++11 standard in the common.cmake file:
set(CMAKE_CXX_STANDARD 11)

So, I' building from a new system now: Linux x86_64, 4.15.0-42-generic, Ubuntu 18.04.01, g++ 7.3.0.
ISO C++ problems appears to be gone, however the OpenMP errors are back:
SPlisHSPlasH/Utilities/PoissonDiskSampling.cpp:127:25: error: ‘omp_get_max_threads’ was not declared in this scope

I'm giving up on this now, maybe next year. Merry Christmas :christmas_tree:

Try to build it in release mode:
cmake -DCMAKE_BUILD_TYPE=Release

Building with cmake -DCMAKE_BUILD_TYPE=Release works. Thanks for helping! Can't wait to play with this during Christmas holidays :smiley:
Closing...


[Android] - Video resizes visually before playing

When using the video player on android (Samsung galaxy Tab A, running android 7.0), the video is already rendered before the onPrepared event is triggered. This results in a single frame that is being shown for about 1 second in the wrong size and after that 1 second, the video is being shown in full screen.
Expected:
I expect the video to only be rendered in the correct resizeMode="cover" way, without a frame first being shown in a incorrect size.
I've also tested this on a Oneplus 3T running android 7.1.1 and on a nexus 7 running android 6.0.1, the video player works fine on those devices.
react native version: 0.47.1
react-native-video version: 2.0.0

I'm getting this problem as well, any fixes for this yet?
Samsung S8
react-native 0.55.2
react-native-video 2.0.0


Start Documentation

Created a frame based documentation application (based on static)
Created build script to generate static site (this will be used to plop into gh-pages branch
Uses angular-markdown module
Provided an example markdown documentation on circle-button

:+1:

:+1:


heartbeat_threshold using time delta

Short Description:
@solderzzc
This PR changes the behaviour of heartbeat_threshold such that it measures the time since it was last run and only runs if this exceeds the set threshold.
I've done this because ticks are of variable lengths and with the changes I've been making to add configurable delays they can sometimes be >10 sec between ticks for me.

@Quantra  great PR, thanks a lot.


Increase log level for the API call

It's hard to know when the api call has been called.
Need to increase the log level for recognize the api has been called.

Done!


Publish eRPC to pypi automatically

Hi @MichalPrincNXP, as you are owner of eRPC account on pypi i wanted to ask you to implement this feature:
https://github.com/marketplace/actions/pypi-publish
You will set action "on push to master branch" publish ePRC to pypi. So you don't need to do it manually in future .... In link is description how to do it. Theoretically i can help with start...

Thanks, will do it before 1.8.0 release.

After looking at the PyPI publish GitHub Action in details, the benefit of the use in our case is not so high and the decision has been made to stay with the current manual PyPi update. Thank you.

After looking at the PyPI publish GitHub Action in details, the benefit of the use in our case is not so high and the decision has been made to stay with the current manual PyPi update. Thank you.


[AutoPR network/resource-manager] Add AzureFirewall swagger and examples

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3276

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2944


Slides don't reset when going to the next page

I just cloned the repo, and I noticed that the currentSlide value does not reset when the page changes. This happens with just the test content included by default.
Reproduce:

Start dev mode
Open the slideshow
Press space (or right arrow) until page changes (see url)
The view is black because the currentSlide number is still where it was left from the previous page
Setting the currentSlide value to 0 makes it work on page-2

I'll try to come up with a solution myself, but this seems like a pretty major issue.

Not sure if you're still interested in this, or if you already found the solution, but here it's my workaround for going to the next page and reset the slide number, I'm working on how going back:
in SlidePage.jsx there is a useEffect hook listening lilke this:
 useEffect(() => {
    router.push(
      `${router.pathname}`,
      `${router.pathname}?mode=${mode}#${currentSlide}`
    );
  }, [currentSlide, mode, router.pathname]);

This one is taking care of handling the slides, by making a mask of it, it should be set to "shallow" since it's just masking the URL:
 useEffect(() => {
    router.push(
      `${router.pathname}`,
      `${router.pathname}?mode=${mode}#${currentSlide}`,
      { shallow: true }
    );
  }, [currentSlide, mode, router.pathname]);

To reset the currentSlide state I just added another useEffect listening to route events:
 useEffect(() => {
    router.events.on("routeChangeComplete", () => {
      // resetting slides to 0
      setSlide(0);
    });
    router.events.on("routeChangeStart", () => {
      // going to next page
      console.log("going to next");
    });
  }, [router.events]);

routeChangeComplete will only trigger when you successfully loaded another "page" , in this case is /page-2;
There is another function handling that router push:
// Handle next page
  if (NEXT.indexOf(keyCode) !== -1 && currentSlide === slideCount) {
    if (router.query && router.pathname && next) {
      router.push(`${next}?mode=${mode}`);
    }
    return false;
  }

so, this should work as expected.

Hope it helps.


Fixed double-slash syntax for comment

The code snippet for swap.md had a comment that was missing a forward slash.

Thank you for your contribution @kwakp05  :+1:
:relaxed: :relaxed: :relaxed: