12.3.1 Incompatible?

Hi,
I recently saw that unc0ver works with iOS versions 11.0-12.4 and decided that I should JB my 12.3.1 device. I sideloaded unc0ver to my iPhone from a Linux OS using Cydia Impactor, and when I open unc0ver is states that my device is Unsupported. I am unaware if this issue can be reproduced or if I am just missing something.
Steps to reproduce the behavior:

Open unc0ver
see error

iOS Version: 12.3.1 (Build: 16F203)

iOS Device: iPhone XR

Model Number: MT302LL/A

unc0ver Version: 3.5.6

[X] this is a bug others will be able to reproduce

[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled

[ ] this issue is present after a rootfs restore

[X] this issue is present on the latest version of unc0ver

12.3.1 is unsupported. in 12.4 Apple unpatched the exploit and is jaibreakable and re patched it quickly in 12.4.1 .
Sent with GitHawk

Can I update my iPhone to 12.4 and then JB it?

Can I update my iPhone to 12.4 and then JB it?

@idchoppers you can check if you can, but don’t update to 12.4.1 because the exploit is patched. If you can’t then it’s game over till the next jailbreak breakthrough...
Sent with GitHawk

Right now my iPhone says that it can update to 12.4.1 only, and I'm not sure about trying iTunes, as it would probably just update me to the most recent version.

So I think I may be screwed for now...

Right now my iPhone says that it can update to 12.4.1 only, and I'm not sure about trying iTunes, as it would probably just update me to the most recent version.

@idchoppers

So I think I may be screwed for now...

@idchoppers sadly, this looks to be the case, you can try to look up ways to only update to 12.4 but I’ve been reading something about not being officially signed so I don’t know what it means by that but you will most likely find that out as you look up how to do it.
Sent with GitHawk

@CARLO5ONIC That's bad news, but, anyway, thanks for your help! Should I close the ticket now or keep it open?

@CARLO5ONIC That's bad news, but, anyway, thanks for your help! Should I close the ticket now or keep it open?

@idchoppers I would keep it open just in case you can get better help from a more experienced person.
Sent with GitHawk

@CARLO5ONIC OK, will do!

You can still currently sign 12.4 for your XR. You will have to download the firmware here https://ipsw.me/#version and then proceed to use Itunes to install

@thatbrooklynkidyo Thank you! I will try that and get back to you to see if this will work.

@CARLO5ONIC @thatbrooklynkidyo Good news! I used the ipsw for 12.4 and it worked! I jailbroke my phone! I have one last question though, where is Cydia?

@CARLO5ONIC @thatbrooklynkidyo Good news! I used the ipsw for 12.4 and it worked! I jailbroke my phone! I have one last question though, where is Cydia?

@idchoppers congrats! You are lucky to still be able to get 12.4 officially while it is. Apperently, cydia is unsupported for 12.4 and A12 devices. Now we just have to wait till pwn20 updates uncover and it’s features.
Sent with GitHawk

Alright, I think it may be a good time to close the ticket now.

Thanks for your help everyone!


In DITA-OT project files, allow subsets of deliverables to be published

Description
Currently, DITA-OT project file publishing is limited to publishing one deliverable or all deliverables.
To publish subsets of deliverables, the <deliverable> definitions must be split into multiple files, with subsets built using a hierarchy of <include> directives:

This has the following drawbacks:

Many files can be required.

We have 100+ contexts, shared by dozens of products, organized into several help collections.
Our deliverable definitions are resistant to grouping in fewer files, due to being shared where products overlap.

It is difficult to know what a particular file publishes without tracing through multiple files.
It is difficult to explore the evolution of project file content over time in a revision control system.
Maintenance operations (search-and-replace, adjusting collections) are more complex.
<context> and <publication> information must be replicated in every deliverable file to allow individual publishing (inelegant, but technically harmless).

Possible Solution
It would be useful to be able to natively define collections of deliverables (and collections of collections), perhaps like this:

where a "collection" represents its subset of referenced deliverables:
dita --project project.xml --deliverable product3

When a collection is published, its deliverables should be published in the order resulting from expanding the references. This provides support for order-dependent deliverables (such as HTML online help that cleans its output directory first, followed by PDF deliverables written to that same output directory).
If the reference expansion includes a deliverable multiple times, the deliverable should only be published once (the first occurrence seems reasonable).
Detection for circular collection reference loops would be needed.
Potential Alternatives
I considered having a deliverable declare its dependencies via a new <depends> element, but this made it difficult to specify whether to publish a deliverable alone or with its dependencies, plus there was no intuitive way to describe order dependency.
Additional Context
A testcase is included:
ditaot_project_file_collections.zip
The project.xml file in the testcase uses the format proposed above, although other implementations are possible.

This also sounds useful to me.

@xephon2 - do I recall correctly that this was something interesting to you? If so, what are your thoughts on this enhancement request?

@chrispy-snps , not much to add. This is exactly how it should work.

In project files, you have context, publication, and output and those make up a deliverable. Multiple deliverable can be grouped into a collection. Yeah.
But is the keyword collection right for a set of deliverables. My I would expect it to be a collection of contexts. Maybe because in MongoDB—which I use at work—there’s are collections that contain documents.
deliverable-set would be one, but I don’t like it and would like to avoid hyphenated terms.
Regardless of the keyword chosen, the feature seems simple enough: a named set of deliverable references.

Syntax equivalence:
XML
<project>
  <collection id="product1" name="Product 1">
    <deliverable idref="A"/>
    <deliverable idref="B"/>
  </collection>
</project>

YAML
collections:
- name: Product 1
  id: product1
  deliverables:
  - idref: A
  - idref: B

JSON
{
  "collections": [{
    "name": "Product 1",
    "id": "product1",
    "deliverables": [
      { "idref": "A" },
      { "idref": "B" }
    ]
  }]
}

Excursus:
I generated an iiRDS package with two dummy PDFs using the iiRDS Open Toolkit. The iiRDS OT is a public webservice, just click'n'play if you like. The iiRDS content delivery package design is slightly similar to this DITA-OT Deliverable Collection approach. An iiRDS package groups assets and defines their semantical relationships with RDF.
In this syntax it works the other way round. Instead of defining a non-semantical collection which simply groups the assets, the asset "knows" the semantical relations to their peers and parents.
Why could it matter?
Jarno is, for good reasons, always very careful when it comes to backwards compatibility. This means, we should think about the long-term vision of the DITA-OT project file concept. One way could be to think of it more as a replacement for a build script (for example an Ant file). Another way would be to give it a broader, high-level role, as a semantical container for DITA publishing maps, so, a higher level of abstraction to define semantical relationships across deliverables.
Personally I think that the definition of relations between deliverables should be more a topic for the OASIS DITA TC (maybe for 3.0) and not for the DITA-OT. For the DITA-OT I think the DITA-OT project file is and should be seen as a replacement for a build script and should not contain semantical data.
<?xml version="1.0"?>
<rdf:RDF xmlns:iirds="http://iirds.tekom.de/iirds#"
  xmlns:iirdsMch="http://iirds.tekom.de/iirds/domain/machinery#"
  xmlns:iirdsSft="http://iirds.tekom.de/iirds/domain/software#"
  xmlns:plus="https://data.plusmeta.de/metadata#"
  xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
  xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#"
  xmlns:xml="http://www.w3.org/XML/1998/namespace">

  <!-- *** iiRDS Open Toolkit (v1.1.1) *** -->
  <!-- *** generated on 14.4.2022, 09:27:50 *** -->
  <iirds:Package rdf:about="urn:uuid:824ea311-6495-4d13-9c77-b481af9ee844/package">
    <iirds:title>iiRDS Open Toolkit Export</iirds:title>
    <iirds:iiRDSVersion>1.1</iirds:iiRDSVersion>
  </iirds:Package>

  <iirds:Document rdf:about="urn:uuid:34a74b6f-2211-47ea-8bf3-51d3d76c6712">
    <iirds:is-part-of-package rdf:resource="urn:uuid:824ea311-6495-4d13-9c77-b481af9ee844/package"/>
    <iirds:has-rendition>
      <iirds:Rendition rdf:about="urn:uuid:34a74b6f-2211-47ea-8bf3-51d3d76c6712/rendition/foo.pdf">
        <iirds:format>application/pdf</iirds:format>
        <iirds:source>CONTENT/foo.pdf</iirds:source>
      </iirds:Rendition>
    </iirds:has-rendition>
  </iirds:Document>

  <iirds:Document rdf:about="urn:uuid:ce622607-c59b-46a3-bf8f-901f2337ada1">
    <iirds:is-part-of-package rdf:resource="urn:uuid:824ea311-6495-4d13-9c77-b481af9ee844/package"/>
    <iirds:has-rendition>
      <iirds:Rendition rdf:about="urn:uuid:ce622607-c59b-46a3-bf8f-901f2337ada1/rendition/bar.pdf">
        <iirds:format>application/pdf</iirds:format>
        <iirds:source>CONTENT/bar.pdf</iirds:source>
      </iirds:Rendition>
    </iirds:has-rendition>
  </iirds:Document>

</rdf:RDF>

Regarding the element name, @jelovirt, I'd suggest to use <package> to avoid <collection> and <deliverable-set>. This would also be consistent with the iiRDS terminology.

A DITA authoring/CCMS tool could present collections-of-collections, collections, and deliverables graphically in expandable tree form, making it easy to explore and select from the available publishing options.

Thinking about the syntax and trying to make it more compact.
Syntax equivalence:
XML
<project>
  <collection id="product1" name="Product 1">
    <deliverable idref="A"/>
    <deliverable idref="B"/>
    <collection idref="product2"/>
    <collection idref="product3"/>
  </collection>
</project>

This could be more compact by using attributes with comma separated list
<project>
  <collection id="product1" name="Product 1"
              deliverables="A, B"
              collections="product2, product3"/>
</project>

But I don't really like this.
YAML
collections:
- name: Product 1
  id: product1
  deliverables:
  - A
  - B
  collections:
  - product2
  - product3

JSON
{
  "collections": [{
    "name": "Product 1",
    "id": "product1",
    "deliverables": [ "A", "B"],
    "collections": [ "product2", "product3" ]
  }]
}

Is the order of deliverable generation a requirement (👍🏽/👎🏽)?
If we call this a collection set, then it's unordered; if the processing order needs to be configurable, then using the word set might cause confusion.

@jelovirt - syntax-wise, I prefer the @id/@idref approach for the following reasons:

It is consistent with how project file references work today.
XSLT preprocessing is easier because of the built-in id() and idref() functions.
In revision control history, the addition or removal of references are line-based changes that more easily merge, revert, etc.

@jelovirt - I am normally not a fan of hyphens in element names, but I have come to prefer <deliverable-set> because

It makes more sense with dita --deliverable.
It keeps terminology focused on the "big three" - contexts, publications, deliverables - without introducing a fourth term.
Its purpose and relationship to the "big three" are more intuitively clear without referring back to documentation.

So regardless of the ordering connotation that comes with <deliverable-set>, I have come to prefer it.
An ordering guarantee for deliverable generation is a nice-to-have, but not a requirement.
For us, the documentation for a product family is (1) one Oxygen WebHelp deliverable that contains all the books as submaps, plus (2) individual book PDFs placed into that same output directory:

Because WebHelp is HTML-based, we must clean the output directory before publishing it to avoid orphaned files (see #1199), but that must be done before the PDF deliverables are also written into that directory.
If there were an ordering guarantee "built into" deliverable sets, then we could invoke output-cleaning plugins in a certain way. If not, then output-cleaning must be moved to a preprocessing operation that computes and cleans all output directories for the deliverables to be published. This is easy in automated linux publishing where I can write a wrapper script to do that, but not easy in Oxygen where writers interactively publish from the software's UI. They will need to remember to manually delete their output directory from time to time.
And some day, perhaps if the DITA-OT implements a "parallel deliverable publishing" capability (wouldn't that be cool!), then an ordering guarantee becomes even harder to implement because you'd need to derive a whole make-like dependency tree, and that is asking a lot for a feature you are trying to keep simple!
So if an ordering guarantee is implemented, I think value could be obtained from it. But it's just a nice-to-have, not a requirement.
@xephon2 - do you have any thoughts on order of deliverable generation in a deliverable set?


default logs to stderr

This makes me rage always, I think it's worth fixing.
@Sirupsen
Pretty good rationale on when to use stdout/stderr by @jstorimer:
http://www.jstorimer.com/blogs/workingwithcode/7766119-when-to-use-stderr-instead-of-stdout

I definitely agree with this, and it's been brought up multiple times. I'm unsure whether or not to ship this before or after 1.0

I've bumped the version to 0.8 for that purpose. Any reason why you would prefer making the change in 1.0?

@stevvooe @icecrime would this have any heartbreaking implications for Docker?

@Sirupsen For the registry (docker/distribution), this would change the output location of the logs. This may affect infrastructure consuming those log messages if they don't also consume stderr. I don't see an issue with this. Logs should go to stderr.


Publish Cocoapod

Use pod trunk to push podspec to specs repository.

Update version tag to 0.2.0

Addressing in Version 0.2.0 - Publish Cocoapod #3


[do not review/merge] testing forking docs

Description
Please explain the changes you've made.
Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number
Auto-generated summary

🤖 Generated by Copilot at 93349ab
Summary
:fork_and_knife::test_tube::arrow_up:

Added a test change to docs/README.md to demonstrate the fork and pull request workflow. This change is not meant to be merged.

Fork and pull request
A test of collaboration
Leaves fall, not merged

Walkthrough

Add a test message to the docs/README.md file (link)

Closing, picked up in a different task/PR


RaiNews: Unable to extract relinker URL

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.05.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Italy
Example URLs
https://www.rainews.it/rubriche/24mm/video/2022/05/24mm-del-29052022-12cf645d-1ffd-4220-b27c-07c226dbdecf.html
Description
Seems to be working the same way Raiplay does but when trying to use yt-dlp, it fails to extract relinker URL
Verbose log
C:\ytdl>yt-dlp.exe -vU https://www.rainews.it/rubriche/24mm/video/2022/05/24mm-del-29052022-12cf645d-1ffd-4220-b27c-07c226dbdecf.html
[debug] Command-line config: ['-vU', 'https://www.rainews.it/rubriche/24mm/video/2022/05/24mm-del-29052022-12cf645d-1ffd-4220-b27c-07c226dbdecf.html']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d523] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19042-SP0
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg git-2020-08-31-4a11a6f, ffprobe git-2020-08-31-4a11a6f
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [Rai] Extracting URL: https://www.rainews.it/rubriche/24mm/video/2022/05/24mm-del-29052022-12cf645d-1ffd-4220-b27c-07c226dbdecf.html
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading webpage
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading video JSON
ERROR: [Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Unable to extract relinker URL; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 642, in extract
  File "yt_dlp\extractor\rai.py", line 707, in _real_extract
  File "yt_dlp\extractor\common.py", line 1226, in _search_regex

Rai news is actually already supported. So this is obviously a bug in the Rai News extractor

here's another test link for this case:
https://www.rainews.it/tgr/piemonte/notiziari/video/2022/07/TGR-Piemonte-del-17072022-ore-1400-0012d7a7-a5d5-43e6-87b9-6d6327e7247a.html

@nixxo

will look into it.

ok:
❯ ydpm https://www.rainews.it/rubriche/24mm/video/2022/05/24mm-del-29052022-12cf645d-1ffd-4220-b27c-07c226dbdecf.html -F
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading webpage
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading video JSON
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading XML metadata for platform mon
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading m3u8 information
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading XML metadata for platform flash
[Rai] 12cf645d-1ffd-4220-b27c-07c226dbdecf: Downloading XML metadata for platform native
[info] Available formats for 12cf645d-1ffd-4220-b27c-07c226dbdecf:
ID         EXT RESOLUTION FPS |   FILESIZE   TBR PROTO | VCODEC        VBR ACODEC    ABR
----------------------------------------------------------------------------------------
hls-1296   mp4 768x432     25 | ~251.47MiB 1296k m3u8  | avc1.4d401f 1296k mp4a.40.2  0k
https-1200 mp4 768x432     25 | ~251.47MiB 1296k https | avc1.4d401f 1296k mp4a.40.2  0k

will cleanup the code and make a test for it.


fix(9870): common expression elimination optimization, should always re-find the correct expression during re-write.

Closes #9870
Which issue does this PR close?
We found an example where the common-expr-elimination was mutating the logical plan incorrectly. Specifically, it would replace a logical plan node with an incorrect node => leading to a failure in the type check. We have a reproducer of this error (see the first commit's expected test errors).
Rationale for this change
We isolated this error to how the IdArray is generated and used. The IdArray is generated by insertion-at-index during traversal of a first visitor. This IdArray is then read during the second visitor, also by an index, but this index is incremented differently as this second visitor traverses.
As such, the second visitor finds the wrong expr symbol, and then inserts the wrong expression. We could make small changes to fix our bug, but then broke other statements. We feel that the index-based lookup may be inherently fragile to slight changes in traversal patterns across the two visitors; as such, this PR is an alternative approach.
What changes are included in this PR?
1st commit == reproducer, with the expected test errors
2-4th commits == our steps as we introduced the refactoring:

2nd commit = remove the use of an indexed array, and instead rely upon mapping by expr_identifier() (a.k.a. a stringified expr) which is constant across the two separate tree traversals.
3rd commit = move the aliased symbol (which is NOT the same as the expr_identifier()) into the ExprSet
4th commit = encapsulate much of the logic within the ExprSet. (we anticipate further cleanup may occur later.)

5th commit == update the reproducer tests, which are now passing.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Outstanding question:
There may be some changes in the performance. While consuming the IdArray, the second visitor (the rewriter) had an early termination once all symbols were consumed. We could add logic to include this early halting, but we're unclear if there are additional performance considerations that we are also missing. Do you mind sharing some of your insights @waynexia ? 🙏🏼

Given this is a regression I will plan to merge this PR tomorrow unless someone else would like time to review

For the performance part, I learned the overall plan optimization phase is costly, but haven't looked into the per rule detail. The planner benchmark is very helpful 👍

Yes, I agree. It is key to our ability to make performance improvements in planning

For this specific rule, it needs many traverse passes and many stringify in the base. I agree with @alamb that this fix doesn't make worse. But find some way to alleviate the overhead is very meaningful, especially when we extend this rule to run across plans. And the way to identify an expr might also need to change later considering #9776.

💯  to this as well. I think avoiding creating String identifiers will be the key.

Thank you for the review @waynexia

I think this one may need some change in SqlParser, currently in Sqlparser we just parse syntax like "struct(xx, xx, xx, xx)" to be parsed to Expr::Struct, but when encounter some structure like "t2.struct(xx, xx, xx, xx)" the Sqlparser would parse them into two ident. I think right now it is not ready yet.

I think the issue is tracked in https://github.com/apache/arrow-datafusion/issues/9891


Add docs for features

Part I

Something is wrong about my repo, I fixed it and I create a new pull request


Optimize color computation in prepare_uinodes

Objective
Speed up prepare_uinodes. The color [f32; 4] is being computed separately for every vertex in the UI, even though the color is the same for all 6 verticies.
Solution
Avoid recomputing the color and cache it for all 6 verticies.
Performance
On many_buttons, this shaved off 33% of the time in prepare_uinodes (7.67ms -> 5.09ms) on my local machine.

I guess this would have to change if / when we start supporting gradients and custom shaders for UI?

Yeah it would, but until we explicitly need it, this should be a nice perf boost.

bors r+


Share types between report-schema and mutation-server-protocol

The report-schema and mutation-server-protocol have some overlap in their defined types—namely the MutantResult type.
I see 2 ways forward.

DAMP
Leave it as is. We accept this bit of overlap in favor of readability, portability, and possibly maintainability.
DRY
Create a new package, "mutation-testing-schema" (I guess), with all types from both report schema and MSP. Let report-schema and mts use that.

I'm currently leaning toward the DAMP option, maybe, until we have more to share.

CC @rouke-broersma @hugo-vrijswijk @jaspervdveen @bmesman

We don't use the schema to generate our types so this decision is not currently relevant to us. I would suggest that you check your json schema type generator to see if this potentially creates conflicting types and if not that it's fine for now.
For the future I would like to see us publish relevant types as separate schema's so they can be reusable and composable: https://json-schema.org/understanding-json-schema/structuring#dollarref
At that point I would also like to publish the schema's so they can be referenced.

At this time I don't have a preference yet. For  go (golang) and Kotlin I don't know yet if I want to generate any models. Maybe only validate the json output, which could be executed by a validator that does not depend on the target languages for implementing the server or plugin.
Maybe we can setup a validation pipeline for the parts of the spec that should be kept in sync?

which could be executed by a validator that does not depend on the target languages for implementing the server or plugin.

Which do you prefer? If you prefer json schema than we can use zod-to-json-schema to convert the current Zod schema

Maybe we can setup a validation pipeline for the parts of the spec that should be kept in sync?

Sure. I can do that in a PR after #3

Which do you prefer? If you prefer json schema than we can use zod-to-json-schema to convert the current Zod schema

I don't have enough experience to have a well founded preference.


Skmanage returning an invalid message when using an inactive (but listed) router id

I have noticed one issue with skmanage in the following situation. Suppose I have two linked sites: sk2 -> sk1.
If I run skmanage on sk2 to query the router nodes, I get this:
[
  {
    "id": "sk2-skupper-router-5787ff9d4f-sdnjc",
    "protocolVersion": 1,
    "instance":<PHONE_NUMBER>,
    "linkState": [
      "sk1-skupper-router-56bbc5dd7c-svp9j"
    ],
    "nextHop": "(self)",
    "validOrigins": [],
    "address": "amqp:/_topo/0/sk2-skupper-router-5787ff9d4f-sdnjc",
    "lastTopoChange":<PHONE_NUMBER>,
    "index": 0,
    "name": "router.node/sk2-skupper-router-5787ff9d4f-sdnjc",
    "identity": "router.node/sk2-skupper-router-5787ff9d4f-sdnjc",
    "type": "io.skupper.router.router.node"
  },
  {
    "id": "sk1-skupper-router-56bbc5dd7c-svp9j",
    "protocolVersion": 1,
    "instance":<PHONE_NUMBER>,
    "linkState": [
      "sk2-skupper-router-5787ff9d4f-sdnjc"
    ],
    "validOrigins": [],
    "address": "amqp:/_topo/0/sk1-skupper-router-56bbc5dd7c-svp9j",
    "routerLink": 0,
    "cost": 1,
    "index": 1,
    "name": "router.node/sk1-skupper-router-56bbc5dd7c-svp9j",
    "identity": "router.node/sk1-skupper-router-56bbc5dd7c-svp9j",
    "type": "io.skupper.router.router.node"
  }
]

Then supposing I am going to iterate through the nodes and perform this same query again, but this time passing the router id, in this case the router id for sk1, using:
skmanage query --type io.skupper.router.router.node -r sk1-skupper-router-56bbc5dd7c-svp9j
It works fine, see:
[
  {
    "id": "sk1-skupper-router-56bbc5dd7c-svp9j",
    "protocolVersion": 1,
    "instance":<PHONE_NUMBER>,
    "linkState": [
      "sk2-skupper-router-5787ff9d4f-sdnjc"
    ],
    "nextHop": "(self)",
    "validOrigins": [],
    "address": "amqp:/_topo/0/sk1-skupper-router-56bbc5dd7c-svp9j",
    "lastTopoChange":<PHONE_NUMBER>,
    "index": 0,
    "name": "router.node/sk1-skupper-router-56bbc5dd7c-svp9j",
    "identity": "router.node/sk1-skupper-router-56bbc5dd7c-svp9j",
    "type": "io.skupper.router.router.node"
  },
  {
    "id": "sk2-skupper-router-5787ff9d4f-sdnjc",
    "protocolVersion": 1,
    "instance":<PHONE_NUMBER>,
    "linkState": [
      "sk1-skupper-router-56bbc5dd7c-svp9j"
    ],
    "validOrigins": [],
    "address": "amqp:/_topo/0/sk2-skupper-router-5787ff9d4f-sdnjc",
    "routerLink": 0,
    "cost": 1,
    "index": 2,
    "name": "router.node/sk2-skupper-router-5787ff9d4f-sdnjc",
    "identity": "router.node/sk2-skupper-router-5787ff9d4f-sdnjc",
    "type": "io.skupper.router.router.node"
  }
]

Then if I remove the link from sk2 to sk1 and repeat both operations again, I am seeing an invalid response.
After doing it, the first query (against sk2) still returns sk1 as a router node, if I try to query again using -r sk1-skupper-router-56bbc5dd7c-svp9j, I am seeing:
SendException: RELEASED

https://github.com/skupperproject/skupper/pull/1087

The question is, should we improve skmanage to always return a json. We are not planning to do that at least for the time being.
I am closing this as "Not planned" but we can reopen this if requirements change in the future.

The question in my mind is whether SendException: RELEASED is the best we can do for an error message if an incorrect router-id is specified. Not an urgent or serious issue, but helpfulness of error messages is a key part of usability.

The question in my mind is whether SendException: RELEASED is the best we can do for an error message if an incorrect router-id is specified.

That's what the router network does when it tries to deliver the management message to the targeted router, but since the router is missing and there is nowhere to deliver the message, it gives back the RELEASED disposition?
If so, then the response for querying a completely bogus router id should be (currently) something still different, I'd guess.

The question is, should we improve skmanage to always return a json. We are not planning to do that at least for the time being. I am closing this as "Not planned" but we can reopen this if requirements change in the future.

If the idea is that skmanage is to have machine-friendly output, then probably yes. I am honestly surprised that skupper runs skmanage, I thought it sends its own AMQP management queries directly, with the go amqp lib.

That's what the router network does when it tries to deliver the management message to the targeted router, but since the router is missing and there is nowhere to deliver the message, it gives back the RELEASED disposition?
If so, then the response for querying a completely bogus router id should be (currently) something still different, I'd guess.

Good point. However in each case, it seems like the skmanage tool could interpret the error it encounters a present something more meaningful to users. In skupper it is used mostly for debugging (as you say, most cases that are able to use the management protocol directly).
To me, machine friendly output is a separate issue from helpful error messages (i.e. error that don't require a router expert to interpret them).

If the idea is that skmanage is to have machine-friendly output, then probably yes. I am honestly surprised that skupper runs skmanage, I thought it sends its own AMQP management queries directly, with the go amqp lib.

It uses AMQP directly for components running in k8s (like another container).
The CLI sometime needs to use skmanage, as the AMQP port is not exposed externally.


[BUG] If Mod is active, creeper or TNT did not make any block damage

Describe the bug
Mod active: No block damage due creeper or TNT anymore
Mod inactive: normal behavior
Forgotten Graves Version
forgottengraves-1.20.4-3.2.6.jar
MC 1.20.4
fabric-api-0.96.11+1.20.4.jar
Fabric 0.15.9
To Reproduce
A list of steps to reproduce your issue, i.e.:

Create clean profile with only this mod active
Create new world
Spawn creeper and let them explode

Expected behavior
Normal Blockdamage
https://mclo.gs/CyWUDVi

This should be affecting both 1.20.3 and 1.20.4. I have an idea of how to fix it, but I'll need to play around with the code when I get home from work.
I'll see if I can't get an update out later tonight. Thanks for taking the time to make a report!

Alright, I'm pushing out a release for 1.20.4 right now that fixes this bug (v3.2.7); let me know if you run into any more issues & thanks again for the report!


HDFS-16866. Fix a typo in Dispatcher

JIRA: HDFS-16866.
Fix a typo in Dispatcher.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 49s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 32s

trunk passed

+1 :green_heart:
shadedclient
25m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 39 unchanged - 1 fixed = 40 total (was 40)

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 24s

the patch passed

+1 :green_heart:
shadedclient
25m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
399m 36s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

529m 58s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.TestWriteConfigurationToDFS

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5202

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4ae53a473a08 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 93a7a0902c5008efe98467a86428e972b32adb99

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/1/testReport/

Max. process+thread count
1980 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 23s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 37s

trunk passed

+1 :green_heart:
shadedclient
25m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
25m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
395m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

518m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5202

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fd19d37f6edb 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f8069ddb1010f6fb07ad1239258e106087d542ba

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/2/testReport/

Max. process+thread count
2112 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @Happy-shi , please fix checkstyle warn. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 53s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 36s

trunk passed

+1 :green_heart:
shadedclient
25m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 52 unchanged - 1 fixed = 52 total (was 53)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
25m 41s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
375m 28s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  0s

The patch does not generate ASF License warnings.

490m 23s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5202

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2a3f2997e089 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1e7414ae0caeb47ac6811b7b1bb761dfb99b6b8a

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/3/testReport/

Max. process+thread count
2255 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5202/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @Happy-shi for your contribution.


Option to add "View in dataviewer" to the context menu of variables in the "Watch" section

I would like the option "View in dataviewer" also enabled in the context menu of variables in the "Watch" section.

There doesn't seem to be a extension point for adding an item to the watch menu.

Thanks for your fast reply! That means there is no way to add such an option?

I've suggested a better feature request https://github.com/microsoft/vscode/issues/150161

Closing as dupe of https://github.com/microsoft/vscode/issues/150161 (basically, making it possible for extensions to contribute to watches/variables context menus)


Error: Native setTimeout will not work when Date is faked

Hey,
What's with that warning? Upgrading Sinon's minor version number broke my tests, which seem to be caused by Lolex. Downgrading to Sinon v1.15 (with an older ver of Lolex) removed the warning and tests continued to work. No setTimeout mocking necessary.
Thanks!

Do you have some more information? I am not seeing this in any of my projects. Are you calling useFakeTimers in your code when you don't need it?

Hey. Aye. By "No setTimeout mocking necessary" I meant using the following has worked a-okay for a while now: Sinon.useFakeTimers(+NOW, "Date").

I see. Well, the error is thrown to save you the frustration that will follow if you do that on node and try to use setTimeout - it will not work. Are you actually using setTimeout? If not, you could simply add it to the list of functions?
We could make this warnings instead of hard errors, but I really don't think you should be doing this, as it's likely to cause trouble. @mantoni @mroderick opinions?

Oh, adding setTimeout et alii for code that depends on it for deferring tends to break it. And I don't want to bother ticking along manually just because their implementation happened to use setTimeout. :) I'm only explicitly interested in mocking time and that's why useFakeTimers takes names, doesn't it? :)

And no warnings for me, thank you. ^-^ Only a fake Date object, please.

I guess we could restrict the error to be thrown on Node. Would need to check if this is the case in any other environment as well.

Hmm, but I am using Node. What's the problem it's meant solve? Faking Date is a different concern from faking timers.

Weird. You'd think they are separate issues, but:
> global.Date = function () {}
[Function]
> setTimeout(function () { console.log('Hey'); }, 100);
TypeError: Object function () {} has no method 'now'
    at insert (timers.js:53:26)
    at Object.exports.active (timers.js:179:7)
    at exports.setTimeout (timers.js:225:11)
    at global.setTimeout (node.js:174:27)
    at repl:1:1
    at REPLServer.self.eval (repl.js:110:21)
    at repl.js:249:20
    at REPLServer.self.eval (repl.js:122:7)
    at Interface.<anonymous> (repl.js:239:12)
    at Interface.emit (events.js:95:17)

Weirdly enough, it does work if the faked Date has a now function, even if it always returns the same number. Ok, will remove the error.

What version of Node is that? v0.12.7 doesn't throw with a replaced Date...
I've used the explicit useFakeTimers thing for some time now ever since I noticed faking setImmediate by default broke all kinds of promise libraries. And probably better to be explicit anyways as they are different concerns and implementation-dependent tests are flaky. ;-)

Ok, will remove the error.

Yay.

I somehow managed to not push Sinon last night, so I won't be able to fix the problem in Sinon until I get to my home computer.

No biggie. Thanks. Clamping Sinon to <1.16 was a quick fix.

Any status here? Not sure if this was resolved anywhere?

Closing as lack of information.

I'll report if it still doesn't work once I get around to upgrading Sinon. Trying to live the "if it works, don't fix it" principle with updates. ;-)


Hi, I am getting: Command CodeSnap not found after loading codesnap.nvim

It takes too much time to compile, not the reason of coming here...
I have to select the next line for preview, see video

https://github.com/mistricky/codesnap.nvim/assets/84800625/56da45b8-452f-4475-99d0-90c3c14dcc28

I want the watermark to be the $(PWD) any way to do so? Like:

echo $PWD
> /home/daUnknownCoder/.config/NeutronVim

I would also like to change the title of the window from React App to <My Custom Title> is that possible?
Custom Installable font instead of most probably Pacifico in watermark?

See i really like the project but if these can be resolved then this project will be a gr8 success

i will see if i can think of a way to implement a more customisable watermark

found a workaround:
watermark = (vim.fn.getcwd():gsub(os.getenv("HOME"), "~")),

can u remove the unnecessary

because it is not required as it already is in the photo gen...

Hii @daUnknownCoder, now the codesnap.nvim already implement custom watermark & preview code font_family in the latest version, you can config them via:
require("codesnap").setup({
  -- ...
  editor_font_family = "CaskaydiaCove Nerd Font",
  watermark_font_family = "Pacifico",
})

The preview title can also be customized via:
require("codesnap").setup({
  -- ...
  preview_title = "CodeSnap.nvim",
})

Based on your question, it seems like you want someplace to display the path of the code that previews on the page, maybe breadcrumbs is a better choice. We will implement breadcrumbs in the future :)

@mistricky this workaround works so if u can integrate this to something like
watermark = (vim.fn.getcwd():gsub(os.getenv("HOME"), "~")) (with tilde)
watermark = vim.fn.getcwd() (without tilde)
With aliases liek
watermark = PWD
And
watermark = tPWD
Would be awesome, and wow u guys are fast, maybe focus more on decreasing the dependencies and compilation time first coz these things will resolve on the go but the deal breaker is the compilation time that  too 2 different languages... Tho this plugin is v nice

About the compilation time, at the latest version, the code of the preview client was packed on CI before release, this will reduce a lot of compilation time :)
And looks like you just wanna display the $pwd on somewhere if I'm not mistaken, but watermark of this plugin is design to display your own identity symbol or something, it's not suitable to display something like $pwd, but there is a workaround as you say, custom watermark and it's font family would be make the $pwd looks not weird. But still it's a workaround, we have planned to develop breadcrumbs to display pwd, you can looking forward to next release version :)

Can i contribute to those breadcrumbs of yours like do you accept pull requests?

Also a CodeSnapPreviewOff to disconnect from localhost

Hi can you tell me how to chaneg the watermark family? coz i tried watermark_font_family = "JetBrainsMono Nerd Font", which didnt work

Can i contribute to those breadcrumbs of yours like do you accept pull requests?

Yeah, of course I'm glad to have others to contribute codesnap.nvim, but this feature is already under development

Hi can you tell me how to chaneg the watermark family? coz i tried watermark_font_family = "JetBrainsMono Nerd Font", which didnt work

looks like your config is correct, please make sure you have installed JetBrainsMono Nerd Font in your computer

Good to know you moved from bloatware rust to Good, pure lua

But this is not working, i removed my ~/.local/share/NeutronVim/lazy/codesnap.nvim folder, i reinstalled the plugin but i always get:
Command CodeSnap not found after loading codesnap.nvim
lazy.nvim also says:
Failed to run `config` for codesnap.nvim

...nfig/NeutronVim/lua/NeutronVim/plugins/Utils/useless.lua:103: loop or previous error loading module 'codesnap'

# stacktrace:
  - lua/NeutronVim/plugins/Utils/useless.lua:103 _in_ **config**

I also get a horizontal split with:
   Error  lazy.nvim Failed to source `/home/daUnknownCoder/.local/share/NeutronVim/lazy/codesnap.nvim/plugin/codesnap.lua`

vim/_editor.lua:0: nvim_exec2()../home/daUnknownCoder/.local/share/NeutronVim/lazy/codesnap.nvim/plugin/codesnap.lua: Vim(source):E5113: Error while calling lua chunk: vim/loader.lua:0: /home/daUnknownCoder/.local/share/NeutronVim/lazy/codesnap.nvim/lua/generator.so: invalid ELF header
stack traceback:
	[C]: in function 'error'
	vim/loader.lua: in function <vim/loader.lua:0>
	[C]: in function 'require'
	...hare/NeutronVim/lazy/codesnap.nvim/lua/codesnap/init.lua:3: in main chunk
	[C]: in function 'require'
	.../share/NeutronVim/lazy/codesnap.nvim/plugin/codesnap.lua:1: in main chunk
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function 'cmd'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:485: in function <...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:484>
	[C]: in function 'xpcall'
	...l/share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/util.lua:113: in function 'try'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:484: in function 'source'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:443: in function 'source_runtime'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:411: in function 'packadd'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:346: in function '_load'
	...share/NeutronVim/lazy/lazy.nvim/lua/lazy/core/loader.lua:191: in function 'load'
	.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:10: in function '_load'
	.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:34: in function <.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:16>

# stacktrace:
  - vim/_editor.lua:0 _in_ **cmd**

Device things:
neovim version:
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1702233742

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

OS: Arch Linux -> 6.7.6-arch1-1
WM: Hyprland -> Hyprland, built from branch main at commit 927da86e3e76a8465c8b45fd7a87a34f25401b37
Terminal: Warp -> v0.2<IP_ADDRESS>.02.stable_01-1

This issue is duplicates https://github.com/mistricky/codesnap.nvim/issues/39

Hi @daUnknownCoder the readme was updated, now you can build codesnap.nvim manually if you still face these problem. And the breadcrumbs is added, you can display current file path easier by open breadcrumbs

hey @mistricky that was cool, yeah but still:

i cannot use codesnap how hard i try...
1 ->

Error executing Lua callback: .../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:48: Vim:Error executing Lua callback: ...hare/NeutronVim/lazy/codesnap.nvim/lua/codesnap/init.lua:31: Please select code which you want to take snapshot first
stack traceback:
	[C]: in function 'error'
	...hare/NeutronVim/lazy/codesnap.nvim/lua/codesnap/init.lua:31: in function 'get_config'
	...hare/NeutronVim/lazy/codesnap.nvim/lua/codesnap/init.lua:49: in function 'copy_into_clipboard'
	.../share/NeutronVim/lazy/codesnap.nvim/plugin/codesnap.lua:4: in function <.../share/NeutronVim/lazy/codesnap.nvim/plugin/codesnap.lua:3>
	[C]: in function 'cmd'
	.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:48: in function <.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:16>
stack traceback:
	[C]: in function 'cmd'
	.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:48: in function <.../NeutronVim/lazy/lazy.nvim/lua/lazy/core/handler/cmd.lua:16>

when i not select code ⬆
if i select code, codesnap freezes and after sometime, neovim quits

running the codesnap takes so long idk why and the copied thing doesnt even paste anywhere it does take a long  time, almost hangs my PC my neovim crashesmostly saying some panic

CodeSnap command is design for take snapshots of selected code, so if you don't select anything codesnap will reject this action.
Because CodeSnap need a few time to generate snapshot, can you provide the crash log?

Because CodeSnap need a few time to generate snapshot, can you provide the crash log?

where do i get that

almost hangs my PC my neovim crashesmostly saying some panic
after the crash happens, probably exec the :message command can find messages contain "panic"

the generated snapshot isnt copied, the saved snapshot doesnt have breadcrumbs

If you wanna breadcrumbs, you can set has_breadcrumbs to true like README mention that:

Breadcrumbs are something to display the current snapshot file path, you can open it through config has_breadcrumbs:

require("codesnap").setup({
  -- ...
  has_breadcrumbs = true
})

almost hangs my PC my neovim crashesmostly saying some panic

after the crash happens, probably exec the :message command can find messages contain "panic"

after the crash i exit neovim so there's no previous session messages

after the crash i exit neovim so there's no previous session messages

Can u reproduce and get the crash message?

ikr

If you wanna breadcrumbs, you can set has_breadcrumbs to true like README mention that:

this is my config
  {
    "mistricky/codesnap.nvim",
    build = "make",
    version = "^1",
    lazy = true,
    cmd = { "CodeSnap", "CodeSnapSave" },
    config = function()
      require("codesnap").setup({
        has_breadcrumbs = true,
        bg_theme = "summer",
        save_path = "./idk.png",
      })
    end,
  },

so there's no breadcrumbs in save img and i cannot paste the said copied to clipboard anywhere, mind if you reopen this issue? it feels dumb commenting in a closed issue

after the crash i exit neovim so there's no previous session messages

Can u reproduce and get the crash message?

ig i got something:

so there's no breadcrumbs in save img and i cannot paste the said copied to clipboard anywhere, mind if you reopen this issue? it feels dumb commenting in a closed issue

what's your codesnap.nvim version? please make sure update codesnap to latest version v1.1.0

it feels dumb commenting in a closed issue
Would u mind open another issue to describe these issues? this issue contains too much information includes old version issues.

so there's no breadcrumbs in save img and i cannot paste the said copied to clipboard anywhere, mind if you reopen this issue? it feels dumb commenting in a closed issue

what's your codesnap.nvim version? please make sure update codesnap to latest version v1.1.0


Simplify integration test harness with js

Which issue does this PR close?

Closes #.
Rationale for this change

Follow on to #2449 but keeping JS enabled
What changes are included in this PR?

Are there any user-facing changes?

Superseded by #2689


response too slow

thanks for sharing this amazing project!
the average of http-responsing time is too slow, about 3 seconds.
Is there a way to optimize?

What's your platform and how memory SDRAM have you ?

esp32 , about 128k RAM

There are many memory allocation in the web server, 128k is can be just if you have microwebsrv (websockets? pyhtml?) + another code around.
Do you use the threaded mode or the blocking mode? 3 seconds, it's slow yes...
You can also adjust threads stack size of your micro-controller.
However, this is not due to the DNS resolving?

hi，buddy, I just bought a new esp32 chip with psram. And I'm going to test it tomorrow.

Ok


Is there a way to get the query params in index.js (outside react components)

Is there a way to get the query params in index.js (outside react components)
Can't use this.props.location
Thank you!

You can just grab window.location.search and parse that.
If you need to do this on every location change, you can use history.listen to subscribe to location changes, but that will require you to create your own history (<Router history={history}> instead of <BrowserRouter>).

Gotcha! Thanks


Random Number#3217

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @surya1926 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @surya1926,
Please make sure to link the relevant issue using the appropriate syntax, such as "#issueNumber" 👀.
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @surya1926 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Otel collector dynamic config

End goal – custom metric receivers and processors can be defined in policies and dynamically applied to otelcollector in agents.

[ ]     Some slight refactoring how cloud plugin interacts with otel (it needs to support injecting into dynamic config)
[x]     Remove hardcoded list of all otelcollector factories, introduce a way to register factories as fx options.
[ ]     Implement hot-reload (actually, we already are registering configprovider for otelcollector which in theory allows dynamic updates, we "just" need to use it), but at this step, the source of dynamic config will agent config file.
[ ]     Implement config as part of policies (as component) and switch source of dynamic config from agent config file to policies (and remove any metrics config from agent config).
[ ]     Figure out how reliable is existing hot-reload of otelcollector config. What we know is that it conceptually restarts the whole collector (which sounds bad), but we need to look how gracefully it does it. Does it allow existing requests to finish? Does it keep the port open? If it's not working well enough, we'll figure out a way out of that. One solution is to have two instances of collectors (core & custom) piped to each other (passing data in-memory). Core collector would not be restarted, custom one might. Other solutions can also be considered.

(if scope of this task is to broad, it will be split)

@hasit @harjotgill Regarding hot-reload part – I had a POC the week before leave and some things worked, but there are some rough edges around what happens during the event of config reload. And I realized that if we "just restart" agent as a whole, it's actually better behaviour because we can completely avoid any downtime. So I'm not sure what's your current plan, but right now I we shouldn't do hot-reload, unless it is necessary.

Closing this as hot-reload of otel config is not needed to solve any actual problem, and scope of this task has changed – opened a new issue #1628


Lose trailing slash while create absolute url

Mojolicious version: 6.66
Perl version: 5.22.1
Operating system: Ubuntu 16.04 LTS

Steps to reproduce the behavior
$ perl -MMojo::URL -le '$u = Mojo::URL->new("http://x.com/a/"); $x = Mojo::URL->new("?page=1")->to_abs($u); print $x;'
http://x.com/a?page=1

Expected behavior
Expected url is http://x.com/a/?page=1
Actual behavior
to_abs drop trailing slash, but browsers leave trailing slash when address bar has trailng slash and href attr contains only query string.

Thanks, should be fixed.


autorest.gotest issue

subscriptionID type uuid

mock test: module version

/azp run

/azp run

@chlowell can you please take a look at the changes to autorest.go?

You should also update related logic in gotest.

@jhendrixMSFT if you are ok, we are going to release a new version of autorest/go as well as autorest/gotest.


[Android] Cannot find a parameter with this name: returnUrl

Describe the bug
When building on Android (react-native run-android), it fails with the error below:
e<EMAIL_ADDRESS>(69, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(85, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(108, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(121, 11): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(136, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(187, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(204, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(217, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(235, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(250, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(266, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(282, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(298, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(335, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(351, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(380, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(409, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(309, 16): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(313, 13): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(405, 14): None of the following functions can be called with the arguments supplied:
public final fun handleNextActionForPayment(activity: ComponentActivity, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun handleNextActionForPayment(fragment: Fragment, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(434, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(480, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmSetupIntent(activity: ComponentActivity, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmSetupIntent(fragment: Fragment, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe

FAILURE: Build failed with an exception.

To Reproduce
Steps to reproduce the behavior:

Install the library
Run the build on Android
See the error

Expected behavior
Build and run on Android
Desktop (please complete the following information):

OS: macOS Big Sur
Version 11.4

@PabloGiraudCarrier can you provide your code? Does it build fine on iOS?

Hi, it builds fine on IOS yes.
I just created an app from scratch (react-native init Test), installed the library (npm i @stripe/stripe-react-native)
And then build (react-native run-android)
➜  Test react-native run-android
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
(node:6676) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
Jetifier found 896 file(s) to forward-jetify. Using 4 workers...
info JS server already running.
info Installing the app...
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :app:compileDebugJavaWithJavac

> Task :app:stripDebugDebugSymbols
Unable to strip the following libraries, packaging them as they are: libc++_shared.so, libevent-2.1.so, libevent_core-2.1.so, libevent_extra-2.1.so, libfb.so, libfbjni.so, libflipper.so, libfolly_futures.so, libfolly_json.so, libglog.so, libglog_init.so, libhermes-executor-common-debug.so, libhermes-executor-common-release.so, libhermes-executor-debug.so, libhermes-executor-release.so, libhermes-inspector.so, libimagepipeline.so, libjsc.so, libjscexecutor.so, libjsijniprofiler.so, libjsinspector.so, libnative-filters.so, libnative-imagetranscoder.so, libreact_codegen_reactandroidspec.so, libreact_nativemodule_core.so, libreactnativeblob.so, libreactnativejni.so, libreactnativeutilsjni.so, libreactperfloggerjni.so, libturbomodulejsijni.so, libyoga.so.

> Task :app:installDebug
Installing APK 'app-debug.apk' on 'Redmi Note 9S - 10' for app:debug
Installed on 1 device.

BUILD SUCCESSFUL in 1m 1s
29 actionable tasks: 29 executed
info Connecting to the development server...
8081
info Starting the app on "a5f12580"...
Starting: Intent { cmp=com.test/.MainActivity }
➜  Test npm i @stripe/stripe-react-native

added 122 packages, and audited 1115 packages in 21s

88 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
➜  Test react-native run-android
info Running jetifier to migrate libraries to AndroidX. You can disable it using "--no-jetifier" flag.
(node:6744) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
Jetifier found 915 file(s) to forward-jetify. Using 4 workers...
info JS server already running.
info Installing the app...

> Task :stripe_stripe-react-native:compileDebugKotlin FAILED
38 actionable tasks: 30 executed, 8 up-to-date
e<EMAIL_ADDRESS>(69, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(85, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(108, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(121, 11): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(136, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(187, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(204, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(217, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(235, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(250, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(266, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(282, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(298, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(335, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(351, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(380, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(409, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(309, 16): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(313, 13): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(405, 14): None of the following functions can be called with the arguments supplied:
public final fun handleNextActionForPayment(activity: ComponentActivity, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun handleNextActionForPayment(fragment: Fragment, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(434, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(480, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmSetupIntent(activity: ComponentActivity, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmSetupIntent(fragment: Fragment, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':stripe_stripe-react-native:compileDebugKotlin'.
> Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3m 43s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
e<EMAIL_ADDRESS>(69, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(85, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(108, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(121, 11): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(136, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(187, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(204, 7): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(217, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(235, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(250, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(266, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(282, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(298, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(335, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(351, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(380, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(409, 9): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(309, 16): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(313, 13): Cannot find a parameter with this name: returnUrl
e<EMAIL_ADDRESS>(405, 14): None of the following functions can be called with the arguments supplied:
public final fun handleNextActionForPayment(activity: ComponentActivity, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun handleNextActionForPayment(fragment: Fragment, clientSecret: String, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(434, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmPayment(activity: ComponentActivity, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmPayment(fragment: Fragment, confirmPaymentIntentParams: ConfirmPaymentIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
e<EMAIL_ADDRESS>(480, 14): None of the following functions can be called with the arguments supplied:
public final fun confirmSetupIntent(activity: ComponentActivity, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe
public final fun confirmSetupIntent(fragment: Fragment, confirmSetupIntentParams: ConfirmSetupIntentParams, stripeAccountId: String? = ...): Unit defined in com.stripe.android.Stripe

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':stripe_stripe-react-native:compileDebugKotlin'.
> Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3m 43s

    at makeError (/Users/pablo/Projects/Yego/Test/node_modules/execa/index.js:174:9)
    at /Users/pablo/Projects/Yego/Test/node_modules/execa/index.js:278:16
    at processTicksAndRejections (node:internal/process/task_queues:93:5)
    at async runOnAllDevices (/Users/pablo/Projects/Yego/Test/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/runOnAllDevices.js:94:5)
    at async Command.handleAction (/Users/pablo/Projects/Yego/Test/node_modules/@react-native-community/cli/build/index.js:186:9)
info Run CLI with --verbose flag for more details.

I've tested it on another computer and it builds.
However, instead of the error Cannot find a parameter with this name: returnUrl, I still have a warning saying that the parameter returnUrl is deprecated and that it will be removed in the next major version.

I'm glad you managed to finally build the app @pablogdcr.
But you're right, customUrl was deprecated in Android SDK in version 16.8.0 for some payment methods. The information about it can be found here - https://github.com/stripe/stripe-android/blob/master/CHANGELOG.md
@thorsten-stripe let's fix it and remove the usage of deprecated parameters since it will be removed in the future versions of stripe-android SDK.

Unfortunately, I'm still not able to build on my current computer.
The only difference that I can see between my two computers is the version of node that I'm using (16.4.2 on this computer, 16.1.0 on the computer where the build succeed).
Can the error be due to this?
I don't understand why I have this build error when the error is related to the Android SDK, which does not depend on the computer but on the version used in the package.

@pablogdcr are you testing exactly the same project (same repo) on both devices? Or maybe you created the project separately on the second computer?
Node version should not matter

Yes, exact same repo.
The issue is solved now, I upgraded my react-native version from 0.63.x to 0.64.x today, and now it builds fine.
I suppose that something was wrong with the dependencies installed on this computer and that the problem has been solved by reinstalling everything correctly.
Thanks a lot for your help, let's hope that the problem doesn't come back and that no one else faces it!


prices_to_returns cuts off dataframe to last asset launch [BUG]

Describe the bug
prices_to_returns promises to take a dataframe of prices and convert them to returns. In the event I have a dataframe with returns with different starting times (such as VTI and BITI) this function will cut rows to the start of BITI.
To Reproduce
from skfolio.preprocessing import prices_to_returns
import yfinance as yf
import pandas as pd

STOCKS = ["VTI", "BITI"]
return_dfs = []
for ticker in STOCKS:
  ticker_yahoo = yf.Ticker(ticker)
  df = ticker_yahoo.history(period="1d", start="2010-01-01")
  df.index = df.index.date
  return_dfs.append(df[["Close"]].rename(columns={"Close": ticker}))
return_df = pd.concat(return_dfs, axis=1).sort_index().fillna(0.0)

prices_to_returns(return_df)

Expected behavior
Returns for BITI before 2022-06-21 are 0.0. Instead it cuts off the dataframe.
Additional context
This occurs due to the dropna. I believe this should use fillna with 0.0 after the pct_change call to mark the previous periods are 0.0 for returns. I would be more than happy to make this change just want to be sure this is considered the right move by the maintainers.
Versions
0.2.1

The prices_to_returns function currently forward fill missing values (NaN) and drop all dates that have missing values placed at the start. The reason we don't apply a backfill is to avoid data leakage. However, we need to have an option to keep these NaNs at the beginning because in some cases we can use a Pre-Selection Transformer that drops assets that have not started yet while keeping the older ones.
In your example, you are replacing NaNs with 0 but on the prices, therefore the return computation will return NaNs, one Inf, then the correct returns. The NaNs will indeed be dropped by the dropna.

The prices_to_returns function currently forward fill missing values (NaN) and drop all dates that have missing values placed at the start. The reason we don't apply a backfill is to avoid data leakage. However, we need to have an option to keep these NaNs at the beginning because in some cases we can use a Pre-Selection Transformer that drops assets that have not started yet while keeping the older ones.
In your example, you are replacing NaNs with 0 but on the prices, therefore the return computation will return NaNs, one Inf, then the correct returns. The NaNs will indeed be dropped by the dropna.
The proper way would be to implement the improvement I just described, then if you need you can replace the returns NaN with 0

I think we should also raise an explicit Error when prices are 0 or neg

I'm not quite sure I follow the improvement you are describing, can you give me some colour around what this would look like mechanically?

Let's assume you have two assets with the below prices time series:
p0, p1, p2, p3, nan, p5, p6
nan, nan, nan, p3, p4, nan, p6
The prices_to_returns function with it's default param nan_threshold=1.0 will first forward fill the prices:
p0, p1, p2, p3, p3, p5, p6
nan, nan, nan, p3, p4, p4, p6
Then compute the returns:
nan, r1, r2, r3, r4, r5, r6
nan, nan, nan, nan, r4, r5, r6
Then remove all NaNs:
r4, r5, r6
r4, r5, r6
I'm proposing to have another parameter to keep rows with partial NaNs for this last step. So we would get:
r1, r2, r3, r4, r5, r6
nan, nan, nan, r4, r5, r6


clean eunit and ct

Currently the only way to do this is rebar3 as test clean. Maybe we should extend either the eunit and ct providers ho have clean commands or extend clean to have a --tests option?

sounds like rebar3 clean --tests is exactly as many characters as rebar3 as test clean

It isn't about number of characters it is about discoverability. If it is an option on clean then doing rebar3 help clean would inform the user of this.

it would, but then if I'm running a different tool, then there's no option for it and we're stuck adding arguments forever.
It might be better for rebar3 help clean to mention using it with a profile to clean stuff in non-default profiles. If I end up running tests under the native profile, then I would still need to do rebar3 as native clean --tests, or ask for rebar3 clean --profile=test+native which frankly isn't great.

I'm not sure what a different tool would matter. If it is based on tests compiled as extra src to the test profile it would be deleted just the same as eunit and common test beams. And if there is more to clean then it would have to provide a rebar3 <tool> clean command.

What I'm saying is not tool-related. It's that if I'm running test under a different compiler profile for example (where native specifies HiPE compilation), then our standard tools break because of the profile.
The current failure of the clean command is due to profile usage. I'm not too sure why profiles shouldn't be used to fix it either.

Then not sure what is wrong with rebar3 eunit clean.

that would be fine. That's up to the provider and I like it more than rebar3 clean --test or something.

command line options already supported by eunit/ct complicate this
if a user does:
$ rebar3 ct --dir protocol

they will need to do:
$ rebar3 ct clean --dir protocol

i think extending rebar3 clean --all to simply deleting _build would be better

I've put the 3.0.0 milestone on this since we should make a decision before cutting a final release if it risks breaking backwards compatibility.

Crap, @talentdeficit has a good point. But I don't know that I like rebar3 clean --all just deleting the _build dir... That seems over the top.

i think we should reconsider having rebar3 clean --all remove _build. it solves #1074 i think