Underscores in GraphQL schema are causing problems

Underscores don't seem to be handled correctly when codegen is building the API.swift file
Given this schema
type TripInput {
	id: ID!
	date_created: AWSDateTime
	title: String
}

Codegen will add this to the API.swift file:
public struct TripInput: GraphQLMapConvertible {
  public var graphQLMap: GraphQLMap

  public init(id: GraphQLID, dateCreated: String? = nil, title: String? = nil) {
    graphQLMap = ["id": id, "date_created": dateCreated, "title": title]
  }

...

  public var dateCreated: String? {
    get {
      return graphQLMap["dateCreated"] as! String?
    }
    set {
      graphQLMap.updateValue(newValue, forKey: "dateCreated")
    }
  }

The init function correctly sets the "date_created" field but the getter and setter do not.

shannon-hager-skookum commented 7 days ago
This bug was reported on the aws-appsync-codegen repo but I don't think it will be fixed unless you fork and fix it yourself. All issues on aws-appsync-codegen have been removed and the repo is read-only in favor of using Amplify CLI going forward.
https://github.com/aws-amplify/amplify-cli
@airstance
airstance commented 5 days ago
Unfortunately, this is happening with the amplify codegen command
@airstance
airstance commented 5 days ago
I'm afraid it's an Apollo thing and won't be fixed. It would be nice if this was pointed out early and not buried in the Apollo server documentation. I now have a ton of data with underscores in my repository. If this is indeed true, perhaps Amazon can add this to their documentation in a more prominent place.
From the Apollo 2 server documentation: Understanding schema concepts
Style conventions

The GraphQL specification is flexible and doesn’t impose specific naming guidelines. However, in order to facilitate development and continuity across GraphQL deployments, it’s useful to have a general set of conventions. We suggest the following:

    Fields should be named in camelCase, since the majority of consumers will be client applications written in JavaScript, Java, Kotlin, or Swift, all of which recommend camelCase for variable names.

    Types: should be PascalCase, to match how classes are defined in the languages above.

    Enums: should have their type name in PascalCase, and their value names in ALL_CAPS, since they are similar to constants.

If you use the conventions above, you won’t need to have any extra logic in your clients to convert names to match the conventions of these languages.

@muellerfr muellerfr added the AppSync label 4 days ago
@muellerfr muellerfr assigned palpatim 4 days ago
@shannon-hager-skookum
shannon-hager-skookum commented 3 days ago
Regardless of Apollo's style conventions, the codegen should never produce this bug.
If the generated code has
graphQLMap = ["id": id, "date_created": dateCreated, "title": title]
then the generated code should also have
public var dateCreated: String? {
get {
return graphQLMap["date_created"] as! String?
}
not
public var dateCreated: String? {
get {
return graphQLMap["dateCreated"] as! String?
}
If this is an issue of style, the snake_cased names should never be changed to camelCase. Currently, the snake_case names are changed to camelCase in some places when generating the swift code but remain snake_case in other places for the same names, causing fatal errors when trying to retrieve those values.
@dgarkusha
dgarkusha commented 3 days ago
Just some observations (though I'm still using aws-appsync-codegen):
For me the codegen properly works for types, for example, it translates:
type Reminder {
...
audio_repeats: Int
expire_at: Float
}
into
public struct Reminder: GraphQLFragment {
...
public static let selections: [GraphQLSelection] = [
...
GraphQLField("audio_repeats", type: .scalar(Int.self)),
GraphQLField("expire_at", type: .scalar(Double.self)),
]
 ...

 public var audioRepeats: Int? {
      get {
           return snapshot["audio_repeats"] as? Int
      }
      set {
           snapshot.updateValue(newValue, forKey: "audio_repeats")
      }
 }

 public var expireAt: Double? {
      get {
           return snapshot["expire_at"] as? Double
      }
      set {
           snapshot.updateValue(newValue, forKey: "expire_at")
      }
 }

 ...

}
But for inputs it works only partially. Similarly to what @shannon-hager-skookum mentioned, the following piece of schema:
input CreateReminderInput {
...
audio_repeats: Int
}
is converted into
public struct CreateReminderInput: GraphQLMapConvertible {
public init(..., audioRepeats: Optional<Int?> = nil) {
graphQLMap = [..., "audio_repeats": audioRepeats]
}
but at the same time ends with
 ...

 public var audioRepeats: Optional<Int?> {
      get {
           return graphQLMap["audioRepeats"] as! Optional<Int?>
      }
      set {
           graphQLMap.updateValue(newValue, forKey: "audioRepeats")
      }
 }

}
@palpatim palpatim added closing-soon-if-no-response requesting feedback labels 28 minutes ago
@stale stale bot removed the closing-soon-if-no-response label 28 minutes ago
@palpatim
Member
palpatim commented 20 minutes ago
Thanks for the conversation and for the link to the Apollo reference @airstance.
I agree the inconsistency in the handling between snake- & camel-case feels like a bug. Realistically though, I'm not sure when we'd be able to investigate this. I'll engage the AppSync CodeGen team, since this isn't technically part of the AppSync client-side SDK. I'll reply back on this thread when I have more info.


Responsive Grid with video.

Hello and good day,
I having a challenge creating a responsive grid with media elements since grids use percentages.  Is there a trick to get this to work? I have tried to use Fill & Auto but, I get mixed results.
Is there a responsive grid you would recommend best with MediaElements or any suggestions.  Thank you and have an amazing day! :)

Have you tried responsive in the stretching configuration?

Ok.  I will try it.  Thank you very much! :)
It is my understanding that the documentation makes it seem that the responsive is a result of "auto" and not its own mode:
Stretching modes for video player. If auto is set, player will try to find the max-width and max-height CSS styles to turn it into responsive mode;

well it is true if the video tag is something like this:
<video id="player" controls style="max-width: 100%" width="640" height="380">
     <source src="..." type="video/...">
</video>

then auto takes place

Oh ok.  I was not aware that there was a responsive setting.  Thank you.  The responsivness seems to work on the page load as I expected.
However, I have another error and I do not if the cause is a mediaelement.js setting or in the grid itself.
To see the error, please click on the pagination number #9 at the link below:
Also,  I had turned off the preview hover plugin while the website is in development.
https://mmt.staging.wpengine.com/testing-dual-header/

Ok I'll check this and keep you posted

Thank you very much! :)

I see 2 errors and none of them are related to the plugin; I'd start from there.

Thank you.  :)
Are you using firefox or Chrome.

Thank you.  I have removed those 2 errors.
The issue seems to be that I do not have a defined height.  Once I add it, it seems to work.
Thank you for all your amazing work and help.  Have a great day! :)

I spoke too quickly.  Every time I change the pagination page the mediaelements goes out of the height size.

Maybe this current grid is not the best one to use Media Elements.  I will search other ways to do it, before I lose my hair :)
Thank you :)

You are welcome closing this ticket now since it's not related to the plugin


The LocalResponseCacheGatewayFilterFactory is creating a new CacheManager for each Filter

Describe the bug
The LocalResponseCacheGatewayFilterFactory is not using the "gatewayCacheManger" bean, but always creating a new instance.
Is this a bug or correct by design?
https://github.com/spring-cloud/spring-cloud-gateway/blob/eb098a759634f5e4898eb0963b83b966ae1b0063/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/factory/cache/LocalResponseCacheGatewayFilterFactory.java#L75

That's intentional. You have two types of Cache for LocalResponseCache

Global: if you activate spring.cloud.gateway.global-filter.local-response-cache.enabled all the responses will be stored in the same cache unless you use LocalResponseCache filter at the route level
At Route level: if you add the filter LocalResponseCache in a route, it will use its own independent cache with its own configuration

I see the point of having an independent cache for each route, but why is it needed to instantiate a new cache-manager for each route?
If there are e.g. 5 routes with LocalResponseCache fiter then it will result in 5 cache-managers each having 1 cache. With that solution it is impossible to customize the cache manager.

``
I think because proxyBeanMethods is set to false, each time creates a new cache-manager that its Bean is defined in line 71 of the LocalResponseCacheAutoConfiguration class

I doubt that setting proxyBeanMethods to true would change anything because LocalResponseCacheAutoConfiguration.createGatewayCacheManager(cacheProperties) is not a @Bean method

But it called in Bean method:
@Bean(name = RESPONSE_CACHE_MANAGER_NAME) 	@Conditional(LocalResponseCacheAutoConfiguration.OnGlobalLocalResponseCacheCondition.class) 	public CacheManager gatewayCacheManager(LocalResponseCacheProperties cacheProperties) { 		return createGatewayCacheManager(cacheProperties); 	}

That is what I'm saying.
The gatewayCacheManager is NOT used in the LocalResponseCacheGatewayFilterFactory!
Please check the code at https://github.com/spring-cloud/spring-cloud-gateway/blob/eb098a759634f5e4898eb0963b83b966ae1b0063/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/factory/cache/LocalResponseCacheGatewayFilterFactory.java#L75
The cacheManager should be reused instead of creating a new instance for each route.

Yes you're right, It's like anti-pattern!

Same question from my side, why would you create a separate cache manager for each route.
In my case, I need to create and use my own cache manager, according to the documentation I can by annotating my cache manager as primary but it is never being used.

I am also facing this issue. Additionally, the cache managers created in LocalResponseCacheGatewayFilterFactory are not visible in '/actuator/caches.' As I wanted the option to manually invalidate some of these caches from time to time, I ended up with a custom re-implementation of LocalResponseCacheGatewayFilterFactory. I don't know if there was a better option to achieve this.

The properties are per cache manager. If you can describe how to do it without a cache manager per route, we'd be happy to work on it.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

The properties could be set per cache not per cacheManager as it is possible with any other spring cache manager. I also don't understand why the implementation is bound to Caffeine and not using a generic solution and support any Cache implementation.
To instantiate a cache manager for each LocalResponseCacheGatewayFilterFactory is a code smell and I think it should be  possible to share a cache manager and not instantiate a new one each time.

The properties could be set per cache not per cacheManager as it is possible with any other spring cache manager.

All the properties are set on Caffeine, not the cache manager. Can you show me how you would do it per cache?
https://github.com/spring-cloud/spring-cloud-gateway/blob/7e4bb5c185772021c8cb51a45543e7466cc0256c/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/config/LocalResponseCacheAutoConfiguration.java#L95-L107
See #3145 for a more generic solution beyond caffeine.

Thanks, I wasn't aware of this chsmge!


Feature request: logarithmic gamma function

The logarithmic gamma function is missing in Chainer. It is required when parameterizing a Beta distribution.
Tensorflow implementation: https://www.tensorflow.org/api_docs/python/tf/lgamma
Pytorch implementation: https://github.com/rachtsingh/lgamma (unofficial)

bump

lgamma will come with many probability distribution implementations in this PR #4678:
https://github.com/chainer/chainer/pull/4678/files#diff-714b726ad7916530f4c83de6e33e3e9b

Great, but its backward computation (digamma) is implemented only in cpu using scipy. I think it may be good to keep this issue open until its full gpu support. https://github.com/YoshikawaMasashi/chainer/blob/fb71a98cece3d23b73e90ecae4bc024c00dee60f/chainer/functions/math/digamma.py

This issue has been fixed via #4720.


Fix for ToImage() creating a black image

This fixes ToImage() creating a black image.
There were two problems:

The channels were ordered incorrectly.
The alpha channel is set to 0 (i.e., image is black).

I don't know enough about opencv to determine if calling img.Get2D(x, y) is supposed to return a 0 alpha channel, but it seems like you want to set that to 255.

Awesome! So I assuming this should fix #33 ?

Yup, it should.

Got it. Thanks so much for the efforts!


Sed script libmode

I've been working on a version of the sed script that caches compiled files. In the process, I reorganized the sed script to

be source-able as a library
not depend on any ./ files or cd commands (by using make -C and figuring out absolute paths names for generated_file etc).

Besides being extensible and not requiring any hacks, I think the reorganized code is somewhat clearer, so I'm opening a pull request.
FWIW, I've benchmarked (results below) sed-cached with a simple sed command. It's about 15 times faster than compiling each time, but still twice as slow as native sed (only 75% slower on busybox sh with builtin applets). Yeah, it should be written in C not sh. But it was a fun as a proof of concept :)
I'm curious what you think of this. Perhaps sed-cached can make it to contrib/. Perhaps a C version would be even faster than sed, and then maybe sed-bin is not so useless after all.
hyperfine --export-markdown /tmp/sed-bin.md -w2 -L sed /S/sed-bin/sed,/S/sed-bin/sed-cached,'busybox sh /S/sed-bin/sed-cached',sed 'for i in $(seq 1 5); do {sed} s/:/_/g /etc/passwd; done

Command
Mean [ms]
Min [ms]
Max [ms]
Relative

for i in $(seq 1 5); do /S/sed-bin/sed s/:/_/g /etc/passwd; done
397.3 ± 8.2
383.1
408.5
33.07 ± 0.84

for i in $(seq 1 5); do /S/sed-bin/sed-cached s/:/_/g /etc/passwd; done
25.5 ± 0.2
25.0
26.0
2.12 ± 0.03

for i in $(seq 1 5); do busybox sh /S/sed-bin/sed-cached s/:/_/g /etc/passwd; done
21.4 ± 0.3
19.4
22.0
1.78 ± 0.04

for i in $(seq 1 5); do sed s/:/_/g /etc/passwd; done
12.0 ± 0.2
11.1
12.6
1.00

Just to be clear, my sed-cached script is on a separate sed-cached branch; this pull request only includes changes to sed.

... and, finally, sed-busting performance  for shell scripts, with the latest sed-cached used in library-mode. It's about 4x faster than calling sed in a regular shell (and 2x faster than calling the builtin sed, if running in a busybox with static applets)
To use this, one has to pre-define SED_DIR, SED_LIBMODE, source the sed  and sed-cached scripts from the repo, and call the entrypoint function whenever desired. It takes care of computing a hash for the script and looking up a cached binary, or compiling one.
Notes at the end of https://github.com/kstr0k/sed-bin/blob/sed-cached/sed-cached

I really like the idea, let me look into this

Sure, have a look and let me know if you want to do things differently. I've converted this to a draft PR.
I've just noticed there's a bug (also present on lhoursquentin/sed-bin) whereby a malformed expression (./sed 's/:/_' </etc/passwd) just hangs.

I've just noticed there's a bug (also present on lhoursquentin/sed-bin) whereby a malformed expression (./sed 's/:/_' </etc/passwd) just hangs.

Yeah unfortunately malformed scripts are not handled correctly for the most part, I have a small note in the README regarding this:

The translator does not handle invalid sed scripts, it will just generate invalid C code which will probably fail to compile, make sure you can run your script with an actual sed implementation before attempting to translate it.

Proper error checking in the translator is possible but it would require keeping a lot more state in memory. For instance the translator isn't even aware of curly brackets nesting depth, it just prints them right away and forgets about them.
In this specific case (s/:/_)  though it cannot even finish translation an is trapped in an infinite loop, I just fixed it in commit 72f5a89404d866d0561f8168deeb0b26814fff50 since it was straightforward and clarified in the README that infinite loop is a possibility when trying to translate invalid scripts.

That would be easily checked using "if system_sed script </dev/null 2>/dev/null" — compared to invoking gcc, it's practically free. But, again, this needs design decisions (have a SED_REAL_SED var?)

All right, I had the chance to take a more in depth look, it's really nice!
I'm just wondering if it wouldn't even be easier to merge the two together and instead have a SED_CACHED env var to trigger the cached version, so that we can keep a single sed script (which could also be sourced), what do you think?
It's also worth noting that the cached version seems slower than the non-cached one when dealing with big sed scripts, I tried with par.sed and the cached version was roughly two times slower.

That would be easily checked using "if system_sed script </dev/null 2>/dev/null" — compared to invoking gcc, it's practically free. But, again, this needs design decisions (have a SED_REAL_SED var?)

My main concern with this approach is that some scripts can have side effects: creating and writing to files with the w command, reading files with r (which can remove data from a FIFO for instance), or with the GNU extensions even run a shell with s/.*/rm some-file/e. So I'd rather let the user handle this verification process manually to avoid any surprises.

All right, I had the chance to take a more in depth look, it's really nice!
I'm just wondering if it wouldn't even be easier to merge the two together and instead have a SED_CACHED env var to trigger the cached version, so that we can keep a single sed script (which could also be sourced), what do you think?

Thanks (it's even cleaner now). Sure; a few more changes will be needed to avoid namespace pollution (BIN). I don't know if any users rely on this "API".

It's also worth noting that the cached version seems slower than the non-cached one when dealing with big sed scripts, I tried with par.sed and the cached version was roughly two times slower.

Interesting. It turns out shell string-truncation (e.g.: s='????'; s=${1#$s}; set -- "${1%"$s"}" "$s" to generate a truncated 4-char string + rest) is heavily dependent on the #/% combination used (even though in this context #/## and %/%% are equivalent). FWIW I found out that dash, busybox sh (and even Bash) all favor # + %% (head truncation) and % + ## (tail truncation). However even the best tail-truncation is several times slower than head-.
It just so happened that the combination I was initially using (% / #) is one of the slowest. Like, orders of magnitude slower...
I've added a hyperfine example to test this at the end of sed-cached to test all # / ## / % / %% combinations. I would drop script-tail hashing completely, except that's the "most unique" part (e.g. your par.sed starts with a bunch of comments).

My main concern with this approach is that some scripts can have side effects: creating and writing to files with the w command, reading files with r (which can remove data from a FIFO for instance), or with the GNU extensions even run a shell with s/.*/rm some-file/e. So I'd rather let the user handle this verification process manually to avoid any surprises.

I was afraid that might be the case. Speaking of which, I wonder, would it be feasible to add a sandbox mode like GNU sed (disable e/r/w)?


[Event Request] table 5900 "Service Header" - OnAfterUpdateBillToContact

We would like to add a new event OnAfterUpdateBillToContact in the following procedure:
local procedure UpdateBillToCont(CustomerNo: Code[20])
var
    ContBusRel: Record "Contact Business Relation";
    Cont: Record Contact;
    Cust: Record Customer;
begin
    if Cust.Get(CustomerNo) then begin
        Clear(ServOrderMgt);
        ContactNo := ServOrderMgt.FindContactInformation("Bill-to Customer No.");
        if Cont.Get(ContactNo) then begin
            "Bill-to Contact No." := Cont."No.";
            "Bill-to Contact" := Cont.Name;
        end else begin
            if Cust."Primary Contact No." <> '' then
                "Bill-to Contact No." := Cust."Primary Contact No."
            else
                if ContBusRel.FindByRelation(ContBusRel."Link to Table"::Customer, "Bill-to Customer No.") then
                    "Bill-to Contact No." := ContBusRel."Contact No."
                else
                    "Bill-to Contact No." := '';
            "Bill-to Contact" := Cust.Contact;
        end;
    end;
    OnAfterUpdateBillToContact(Rec, Cust, Cont); //A108F0013.Event
end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnAfterUpdateBillToContact(var ServiceHeader: Record "Service Header"; Customer: Record Customer; Contact: Record Contact)
begin
    //A108F0013.Event
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


MXNet website often down with "Error 503 Backend unavailable, connection timeout"

Error 503 Backend unavailable, connection timeout

Backend unavailable, connection timeout
Guru Mediation:

Details: cache-pao17420-PAO<PHONE_NUMBER> 879971478

Varnish cache server

Happened for the second time (at least) this week. Who operates the webserver?

Apache Infra team operates the server. If it still happens frequently, this is where we can report the problem. On our side, there is very little we can do about it.

https://issues.apache.org/jira/projects/INFRA/issues/INFRA-20453?filter=allopenissues.


Remove roundstart powergamer bait from Youtool.

Why are we handing out utility belts like candy.
:cl:

remove: Youtool no longer has free utility belts.

maybe put it in contraband so dedicated tiders can still get belts while making it annoying and more suspicious for powergaming hops

I don't really understand what this changes, besides making people prioritize looting Maints more often, which is what the average Powergamer is doing anyway for their Multitool and Insuls. This won't effect Powergamers. They'll just use their bags, like they always have been, or start using toolboxes, substituting the region for something else useful, like Medical belts, if they can't find one in maints. The only "Bait" the YouTool has are the things the YouTool advertises in the first place. The Tools.

maybe put it in contraband so dedicated tiders can still get belts while making it annoying and more suspicious for powergaming hops

This doesn't really help, either, because again: The Utility Belt is NOT The Problem, it's the easily accessible tools that entice powergamers to flock to the Youtool. Making the Utility Belt harder to obtain doesn't fix anything, and, unfortunately, I don't have an idea that could fix the problem properly, either. I guess removing Tools from the maint locker loot pool and the You Tool could potentially fix the issue, but this solution just adds more problems (The first one, off the top of my head, is making the jobs of anyone in the tri-state area that DON'T spawn with them unnessisarily more difficult, like... Most of R&D).

as an powergamer i dislike this PR, but doesn't hate.  This won't effect Powergamers. They'll just use their bags, like they always have been, or start using toolboxes, substituting the region for something else useful, like Medical belts, if they can't find one in maints. The only "Bait" the YouTool has are the things the YouTool advertises in the first place. The Tools.

maybe put it in contraband so dedicated tiders can still get belts while making it annoying and more suspicious for powergaming hops

This doesn't really help, either, because again: The Utility Belt is NOT The Problem, it's the easily accessible tools that entice powergamers to flock to the Youtool. Making the Utility Belt harder to obtain doesn't fix anything, and, unfortunately, I don't have an idea that could fix the problem properly, either. I guess removing Tools from the maint locker loot pool and the You Tool could potentially fix the issue, but this solution just adds more problems (The first one, off the top of my head, is making the jobs of anyone in the tri-state area that DON'T spawn with them unnessisarily more difficult, like...


Restructure into subpackages

Refactored all sources into sub packages as described in
https://trello.com/c/fvKIVdNP/128-azurectl-refactor-azurectl-into-python-subpackages

successfully tested package build, install and tool


Update website banner to increase 2020 election awareness

I'm glad we've used our platform to show support and bring awareness to the Black Lives Matter movement. With election day less than two months away, we should update our messaging towards increasing civic engagement and ensuring people are registered to vote. I've noticed a few websites/apps have already changed their messaging in a similar fashion:
Microsoft / GitHub

Links to an internal blog post about civic engagement
Discord
(Banner appeared last time I logged in, but now I can't get it to show up again. If anyone can screenshot it, repleace it here)
Links to vote.org which has a lot of valuable election day info, like checking to make sure you are registered and letting people sign up to vote by mail.
@vpicone suggested the idea of having it be a different color this time, so people know that the banner has changed 👍

@jeanservaas thoughts on the color of this banner, would we need to keep it blue, or could we change it to a gray 80 or something else?

@vpicone @tw15egan  let's make this the issue where we change the content to the voting link:
sorry, I made a duplicate issue (#1672) but I brought the specs over here and closed that one.

[ ] Change banner color to Cyan 80
[ ] Change action text (@janchild I took a crack at this but it could be better (the link is https://www.vote.org/ )
[ ] Add 20px 'x' close icon to the banner to allow people to collapse it if they want to

@janchild these are @mjabbink 's suggestions for copy
how about
Vote. Make sure you’re registered.
Vote America. Confirm you’re registered.
Remember to vote. https://www.vote.org

Prefer the ones with links so you know where you’re going
Remember to vote. https://www.vote.org
Vote America. https://www.vote.org
Consider efficiency for mobile


[REQUEST] Create an SQS Stream Connector

Is your feature request related to a problem? Please describe.
 Since this library has other AWS integrations, its reasonable that we expand it to include SQS.
Describe the solution you'd like
Implement a StreamConnector that polls AWS SQS. Ideally, it would be able to use the same assume role functionality.
Describe alternatives you've considered
The alternative is to simply write the connector externally in another library or on your own.
Additional context
N/A

Closed with #318


How to run on a single gpu

please refer to https://github.com/cskkxjk/MonoNeRD/issues/6#issuecomment-1731348504


Create New Sample Application

The current one relies on imgur whose API is not that stable and our API key might no longer be working. Lets come up with a good, small, clear sample that newcomers can learn from easily.

No plans for a new sample at this time.


Add Category to incremental analysis attributes

resolves

#23559

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you.


vpn gateway

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45d7ab31-fdf3-9b0f-1439-6a01fb257aab
Version Independent ID: af13a45f-3061-2f0e-7452-b52d700b4805
Content: About Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-about-vpngateways.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@supriyasadhu,   Thanks for leveraging Azure docs feedback channel to raise this question. This channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.
Since you have closed the issue, we presume that you have resolved your issue/question. If you have any feedback on any Azure, please let us know in the associated doc 'Feedback' we would be more than happy to assist you.


[check enforcer] Support local testing and dev environment integration testing

It's not easy or obvious right now how to test webhook payloads against new versions of check enforcer in a live dev environment. Add documentation/scripts/tests for doing this.
Some instructions are here but they can be mostly automated: docs. Also it would be useful to have an end to end setup for webhook router, check enforcer, and test proxy for github GET/POST check-run calls.

Closing as we have replaced check enforcer with a different solution which has local testing support: https://github.com/Azure/azure-sdk-actions/blob/main/docs/check-enforcer.md#testing-and-debugging


Problem in german version of chapter 4.4 Git on the Server - Setting Up the Server

This insturction doesn't work:
https://git-scm.com/book/de/v1/Git-auf-dem-Server-Einrichten-des-Servers
There are missing several steps which are described in the english version:
https://git-scm.com/book/en/v2/Git-on-the-Server-Setting-Up-the-Server
E.g. the chmod commands are missing in the german version

This is due to the second edition of Progit not being translated to German. However, this project is dedicated to the git-scm.com website. Your issue deals with the progit book whose project is located at
https://github.com/progit/progit2
There is already a team of German translators who would be glad to receive some help.

@peff this issue can probably just be closed right?


Why tf.matmul doesn't get zero?

I got a problem when using TensorFlow eager mode that tf.matmul result of two matrixes should obvious be zeros but now different small number as results.
System information

OS Platform and Distribution:Linux Ubuntu 16.04, also on macOS
TensorFlow installed from:binary
TensorFlow version :1.12
Python version:3.6
GPU model and memory: no GPU, 8GB memory

Describe the current behavior
It should be all zeros of the output, but it shows random small values
Code to reproduce the issue
 index=np.random.randint(10, size=20)
 grad = tf.one_hot(index, 10, on_value=-0.045, off_value=0.005)
  w=tf.constant(0.01, shape=[100, 10])
  print(tf.matmul(grad, tf.transpose(w)))
Is this a bug or something else?

I don't understand why it should be all zeros. AFAICT, all the elements of grad will either be 0.005 or -0.045 (i.e. none will be 0.0.) Also, all the elements of w will be equal to 0.01. Multiplying (the transpose of) these will result in a non-zero matrix.

The results should be zeros mathematically but standard floating point numbers simply do not have enough precision to compute the exact results. This seems to be expected results.

The results should be zeros mathematically but standard floating point numbers simply do not have enough precision to compute the exact results. This behavior is common and expected.
e.g.:
$python3 -c 'print(sum([0.005 for k in range(6)]))'
0.030000000000000002

Precision was my first thought, but it have different result for the same calculation as follow.

import numpy as np
import tensorflow.contrib.eager as tfe
import tensorflow as tf

def main():
  tfe.enable_eager_execution()
  np.set_printoptions(threshold=np.nan)
  index=np.random.randint(10, size=20)
  grad = tf.one_hot(index, 10, on_value=-0.045, off_value=0.005)
  w=tf.constant(0.01, shape=[100, 10])
  print(tf.matmul(grad, tf.transpose(w)))

if __name__ == '__main__':
  main()

And floating point shouldn't get the problem of representing 0.005. Calculating 0.0050.0019 - 0.0045*0.01=0.

Your code contains randomness, so getting different result is no surprise.
float32 has no problem representing 0.005. But as I have shown above, it does have problems representing something like this which is very likely to be an intermediate result of your computation:
$python3 -c 'print(sum([0.005 * 0.01 for k in range(6)]))'
0.00030000000000000003

Your code contains randomness, so getting different result is no surprise.
float32 has no problem representing 0.005. But as I have shown above, it does have problems representing something like this which is very likely to be an intermediate result of your computation:
$python3 -c 'print(sum([0.005 * 0.01 for k in range(6)]))'
0.00030000000000000003

The randomness is only about the place of -0.045 in vector when multiplying, which affect the order of adding, but they show different results.
I asked another question in numpy. It seems the problem from original python.
https://github.com/numpy/numpy/issues/12643

which affect the order of adding

and the order of adding may affect results due to precision.

which affect the order of adding

and the order of adding may affect results due to precision.

Thanks for answering and sorry for my stubborn. Finally I figured out IEEE754 can not represent 0.05 accurately. I forgot the rule to generate binary representation back to university.


[SPARK-7150] add range() api

Merged build triggered.

Merged build started.

Test build #32495 has started for   PR 6081 at commit 0729620.

Merged build triggered.

Merged build started.

Test build #32500 has started for   PR 6081 at commit 2c5b461.

Merged build triggered.

Merged build started.

Test build #32501 has started for   PR 6081 at commit 22adff8.

Test build #32495 timed out     for PR 6081 at commit 0729620     after a configured wait of 150m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32495/
Test FAILed.

Test build #32500 has finished for   PR 6081 at commit 2c5b461.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32500/
Test PASSed.

Test build #32501 has finished for   PR 6081 at commit 22adff8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32501/
Test PASSed.

Should we just reuse ParallelCollectionRDD and sparkContext.parallelize(0 until n) here? ParallelCollectionRDD handles integer ranges in a pretty efficient way.

No. 0 until n cannot support long.

@adrian-wang can we update this asap? I really want to have this in 1.4.

Sure, I'll finish it this afternoon.

@rxin for the more general range() api, should I change the API both in SQLContext and SparkContext, or just generalize it in SparkContext and keep range(n: Long) in SQLContext?

or maybe keep both?

Merged build triggered.

Merged build started.

Test build #32680 has started for   PR 6081 at commit bd998ba.

Merged build triggered.

Merged build started.

Test build #32690 has started for   PR 6081 at commit 13dbe84.

Test build #32680 has finished for   PR 6081 at commit bd998ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32680/
Test PASSed.

Test build #32690 has finished for   PR 6081 at commit 13dbe84.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32690/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32706 has started for   PR 6081 at commit 867c417.

Test build #32706 has finished for   PR 6081 at commit 867c417.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32706/
Test PASSed.

@adrian-wang  your codes cannot pass the following test. Could you add it in the unit tests and fix the bug?
import org.scalatest.FunSuite

class RangeSuite extends FunSuite with LocalSparkContext{

  test("aaaa") {
    sc = new SparkContext(new SparkConf().setAppName("test").setMaster("local"))
    for (numSlices <- 1 to 10) {
      for (start <- -10 to 10) {
        for (end <- -10 to 10) {
          for (step <- (-20 to 20).filter(_ != 0)) {
            val scalaRange = Range(start, end, step).toList.sorted
            val sparkRange = sc.range(start, end, step, numSlices).collect().sorted.toList
            assert(scalaRange === sparkRange,
              s"start=$start end=$end step$step excepted: $scalaRange but was $sparkRange")
          }
        }
      }
    }
  }
}

Error:
 List() did not equal List(-10) start=-10 end=-9 step-20 excepted: List() but was List(-10) (RangeTest.scala:15)

Merged build triggered.

Merged build started.

Test build #32775 has started for   PR 6081 at commit 617da76.

Test build #32775 has finished for   PR 6081 at commit 617da76.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32775/
Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #32791 has started for   PR 6081 at commit 617da76.

LGTM except the toLong thing.

@adrian-wang can you add the Python API for DataFrame also?

Will do, Thanks!

Merged build triggered.

Merged build started.

Test build #32802 has started for   PR 6081 at commit f45e3b2.

Merged build triggered.

Merged build started.

Test build #32809 has started for   PR 6081 at commit 705d0c4.

Test build #32809 has finished for   PR 6081 at commit 705d0c4.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32809/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32811 has started for   PR 6081 at commit 19bcc57.

Test build #32791 has finished for   PR 6081 at commit 617da76.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32791/
Test PASSed.

Test build #32802 has finished for   PR 6081 at commit f45e3b2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32802/
Test FAILed.

Test build #32811 has finished for   PR 6081 at commit 19bcc57.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32811/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #32821 has started for   PR 6081 at commit ea345ef.

Test build #32821 has finished for   PR 6081 at commit ea345ef.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32821/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32837 has started for   PR 6081 at commit 45abc27.

Test build #32837 has finished for   PR 6081 at commit 45abc27.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32837/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #32875 has started for   PR 6081 at commit bd3f63e.

Test build #32875 has finished for   PR 6081 at commit bd3f63e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32875/
Test PASSed.

Could you add range() for RDD in Python? It could be something like this:
  sc.parallelize(xrange(start, end, step), numPartition)

It will be more efficient than using the jsc.range(), do not need to serialize the values from JVM to Python.

@davies, if we use parallelize to do this, we have to generate the whole seq in driver side, which could be a nightmare if the data size is huge...

@adrian-wang xrange() is an iterator, it will not generate all the seq. Also, parallelize() treats it efficiently.

Merged build triggered.

Merged build started.

Test build #32970 has started for   PR 6081 at commit cbf5200.

Test build #32970 has finished for   PR 6081 at commit cbf5200.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32970/
Test PASSed.


Put toil tutorial examples under some kind of test

I believe it is possible to run the examples in the docs to check they work. We should do this.

Dupe of #525


Investigate ways to handle rehydration

This is in relation to EclairJS/eclairjs-node/issues/20.
Since we will be adding the ability to reconnect to a running Toree kernel, this would mean that previously run code could get resent over the websocket to get executed (think a Node.js program that dies and reconnects to a running Toree kernel).

@bpburns Here is a diff of using a hashmap to cache code -> result executions
diff --git a/src/main/scala/org/eclairjs/nashorn/JavascriptInterpreter.scala b/src/main/scala/org/eclairjs/nashorn/JavascriptInterpreter.scala
index 0640af5..71e7c91 100644
--- a/src/main/scala/org/eclairjs/nashorn/JavascriptInterpreter.scala
+++ b/src/main/scala/org/eclairjs/nashorn/JavascriptInterpreter.scala
@@ -27,6 +27,8 @@ class JavascriptInterpreter() extends org.apache.toree.interpreter.Interpreter {
     e
   }

+  private val executionMap = scala.collection.mutable.HashMap.empty[String, String]
+
   override def init(kernel: KernelLike) = {
     engine.put("kernel", kernel)
     this
@@ -126,9 +128,20 @@ class JavascriptInterpreter() extends org.apache.toree.interpreter.Interpreter {
    */
   override def interpret(code: String, silent: Boolean): (Result, scala.Either[ExecuteOutput, ExecuteFailure]) = {
     val futureResult = Future {
-      engine.eval(code) match {
-        case res:Object => res.toString()
-        case _ => null
+      if (executionMap contains code) {
+        executionMap(code)
+      } else {
+        engine.eval(code) match {
+          case res: Object => {
+            val resString:String = res.toString()
+            executionMap += (code -> resString)
+            resString
+          }
+          case _ => {
+            executionMap += (code -> null)
+            null
+          }
+        }
       }
     }.map(results => (Results.Success, Left(results)))
       .recover({ case ex: Exception =>


[clean up] remove unused filed authenticationData in ServerCnx

In the class ServerCnx, the variable authenticationData is not used.

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@merlimat PTAL,thanks!

@eolivelli PTAL ,thanks!

@lordcheng10 thanks. Please provide doc-related info in the PR template when you submit a PR, then the Bot can identify it, thanks.

@lordcheng10:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

No need to modify the document

@eolivelli Please take a look again

ping


DO NOT MERGE Test metacp with default settings on windows

Hmm, the CI passes on windows. I was expecting it to fail with URI error.


added no display msg for no search results

Coverage remained the same at 93.118% when pulling d12b075951872a1e3e9045d274dcebe3c64b197d on no-display into 5745e89d44410fa79f52b052c8aa5d432d3b9c63 on dev.

This branch has missing javascript loops causing broken functions. Closing pull request


Add IME support for each platform (glfw-2130)

Since IME is an essential feature for professional use of GLFW,
I will merge #glfw/2130.

https://github.com/glfw/glfw/pull/2130: PR to merge


fix: skip code splitting if asyncDependenciesBlock is the same

Summary
AsyncDpendenciesId changes every compilation, so compare the asyncDependenciesBlock with their identifier, not ID

Require Documentation?

[ ] No
[ ] Yes, the corresponding rspack-website PR is __

!canary

Close because if skip building chunkGraph, asyncDependenciesBlockId wil change, thus the new async block can't be found in old chunkGraph


Error launching fortls

Hi,
I am getting the following error:

Error launching fortls: Please check that all selected options are supported by your language server version.

I have FLS 1.12.0 installed through pip:

done the debugging as described on the FLS WIKI and all seems correct.

I have python installed (3.8.3).
I have Modern Fortran extension installed as well.

Is there any way I could see what exactly is the problem? Is there any kind of log file for this extension? I suppose that since I have latest version of FLS the arguments I am providing should not be a problem, right?
Thanks in advance!

A bit of an update.
I've played a bit with the code inside extension.js. Looks that even when fortls is called w/o any arguments I get the non-zero large value of results.status:
const results = child_process_1.spawnSync(executablePath, [""]);
I've also tried specifying explicit path to fortls.exe here and that also ended up with some large integer for results.status,
By the way, I am worrking on Windows.

That was a python version issue. Going back to Python 3.7.7 solved the issue. Cheers!


properly parse the quaternion data from the steam controller

the SC actually outputs a quaternion, so a fourth value has to be read to handle it properly.
also the structure representing the orientation is now a four-vector
details about quaternions are rather painful but never the less interesting!
https://en.wikipedia.org/wiki/Quaternion
cheers

LGTM, thank you!


How to abort transaction?

There isn't such method in Transaction interface.

There is no Transaction interface in sqldelight. If you are running into problems with SQLBrite's Transaction interface then I would file an issue on that project.
That being said, calling endTransaction without calling markTransactionSuccessful is how you abort a Transaction


Re-filter out nil errors from AnalysisError calls. [phab:D1456]

Created by fromberger at 2017-03-28 06:13:22:

fromberger wrote at 2017-03-28 06:24:02:

Fix a go vet warning.

salguarnieri accepted this revision at 2017-03-28 16:00:51

fromberger wrote at 2017-03-28 22:56:57:

Fix a go vet warning.

fromberger closed via commit ba7550ab7a1ca16c1247045fcf306497747bb4c8 at 2017-03-29 17:17:53


3a. refactor(rpc): use ChainTip for get_best_block_hash

Motivation
This makes the results of get_best_block_hash and get_blockchain_info consistent.
It also simplifies the code, and improves performance.
Solution

Use ChainTip for get_best_block_hash RPC
Use ReadStateService and LatestChainTip in tests

Review
This PR changes how the RPC tests work, so it could cause merge conflicts or test failures. So I've marked it as a high priority.
It is based on PR #3863.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

Follow Up Work
Implement the related RPC:

#3143

I rebased this PR, anyone can re-approve and merge once CI passes.

Merging manually, due to bug #3886


0.1.2.h2 - Hot fix for error when add new schedule to existing jobs.

Coverage remained the same at 35.497% when pulling 11d03bde0b58ce703488c368cc49a96a5c5602c1 on 0.1.2.h2.ScheduleAndMigrate into 84f1c90a1b4efae085696b1c1f779fdfc1a5719a on dev.


renovatebot(deps): update micrometer to v1.2.0

This PR contains the following updates:

Package
Update
Change

io.micrometer:micrometer-core (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-atlas (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-cloudwatch (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-ganglia (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-graphite (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-influx (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-jmx (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-new-relic (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-prometheus (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-signalfx (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-statsd (source)
minor
1.1.5 -> 1.2.0

io.micrometer:micrometer-registry-wavefront (source)
minor
1.1.5 -> 1.2.0

Release Notes

micrometer-metrics/micrometer
v1.2.0
Compare Source
NOTE: This is a non-LTS release. 1.2.x patches will be provided only until 1.3.0 is released. See the support policy for more details.

Notable changes

#1254 Caffeine metrics support now requires Caffeine 2.7 or later
#1315 Wavefront registry now ships cumulative values instead of rates; use the rate functions in Wavefront to derive rates
#1446 InfluxDB registry will write the metric_type with the Meter.Id.Type for custom Meter implementations instead of unknown

See the 1.2.0 milestone for all included issues.

Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.null seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve linting Config typing

Replace custom linting typing with Linter.Config from eslint

The typing of the config objects are typed by hand. We want to make the configs typed more precisely


Custom interpolator prop for NavigationCardStack

This makes it possible override the built in card stack interpolator without having to maintain your own copy of NavigationCardStack. We were not crazy about the slight zooming or the opacity change that the built-in one was doing for the previous card, so this allows us to just use the translate.
This leaves the current behavior and API completely intact, but adds a new prop to NavigationCardStack for passing in your own interpolator. People that want to do this will want to look at the built-in one to get an idea of how an interpolator works.

The more I dive into this, I basically want to be able to pass in my own interpolator, configureTransition and panHandler (to remove the scale and opacity change, speed up the transition and use a different ease function, and to consider velocity in the swipe, respectively).  I don't know if you'd accept pull requests for all those. But it seems a shame that I'd have to maintain my own fork of all this code just to change a few lines in each.

What if we created a HOC that took in {interpolator, panHandler, configureTransition}, and outputs a component like CardStack. I would be in support of that refactoring
cc @skevy

@ericvicenti that seems like a great idea to me.

I've never created a HOC but I've just gone and looked at a few in the code base.  Are there any particularly good examples I should try and emulate?

Lets go ahead with this refactoring, but we should do it in React Navigation, which is where CardStack now lives: https://github.com/react-community/react-navigation/blob/master/src/views/CardStack.js
@bentomas, a HOC is just a normal function that returns a react component. (Usually you create a new class within the function)


Unify Trajectory type for static, dynamic HMC samplers.

We have the following nice composable interface for NUTS at the moment
p = NUTS{Multinomial,GeneralisedNoUTurn}(int)

where NUTS is a subtype of DynamicTrajectory. Maybe we can also unify StaticTrajectory and DynamicTrajectory via introducing a Static type and  a MetropolisTS trajectory sampler (with the final point as an MH proposal), i.e.
struct Static{T<:Integer} <: AbstractTerminationCriterion
    n_leapfrog::T
end

struct MetropolisTS <: AbstractTrajectorySampler end

# dynamic HMC with Multinomial sampling and generalised No-U-Turn.
nuts = Trajectory{MultinomialTS,GeneralisedNoUTurn}(int)

# static HMC with a Multinomial sampling
hmc_Multinomial = Trajectory{MultinomialTS,Static}(int)

# standard HMC with an MH correction step
hmc= Trajectory{MetropolisTS,Static}(int)

We can also use integration time instead of a number of leapfrog steps in the Static type. This allows us to use Trajectory to construct all common HMC samplers including HMC, HMCDA and NUTS.

I will do https://github.com/TuringLang/AdvancedHMC.jl/issues/102 first and see how to unify them later.

After working on the spiral idea for a bit I realise that what we really need to do is treat the transition kernel as a seperate type.
sturct Kernel{T<:AbstractTrajectory,S<:AbstractTrajectorySampler,F<:AbstractRefreshment}
t::T
s::S
f::F
end

The current NUTS{MultinomialTS,GeneralisedNoUTurn} should be Kernel(NUTS{GeneralisedNoUTurn}, MultinomialTS()) where f by default is set to be the completely refreshment.
By explicitly dispatch over transition() over Kernel, we can also the compelte control of a complete transition.
PS: We can also provide a composite kernel somehow. This is useful to combine a multinomial step + a MH step. Or maybe it's overcomplicated and we could introduce a specific type for this.

Closed by https://github.com/TuringLang/AdvancedHMC.jl/pull/245


Update test suite to fail on console.* calls

Currently there are console.{error,warn,log} statements being emitted when running npm test. This can be confusing to contributors who may not understand if the issues are pre-existing or caused by changes that they made when making a contribution.
This issue has two goals:

[x] Add a system by which we can fail tests that call console.{error, warn, log} (Note: console.log() should only fail in CI)
[x] Update tests which currently fail when adding this check

[x] src/drafts/MarkdownEditor/MarkdownEditor.test.tsx
[x] src/__tests__/useSafeTimeout.test.tsx
[x] src/__tests__/TabNav.test.tsx
[x] src/drafts/MarkdownViewer/MarkdownViewer.test.tsx
[x] src/__tests__/Textarea.test.tsx
[x] src/drafts/hooks/useIgnoreKeyboardActionsWhileComposing.test.tsx
[x] src/__tests__/RadioGroup.test.tsx
[x] src/__tests__/Select.test.tsx
[x] src/__tests__/Radio.test.tsx
[x] src/__tests__/CheckboxGroup.test.tsx
[x] src/__tests__/CheckboxOrRadioGroup.test.tsx
[x] src/NavList/NavList.test.tsx
[x] src/__tests__/deprecated/ChoiceInputField.test.tsx
[x] src/__tests__/Autocomplete.test.tsx
[x] src/SegmentedControl/SegmentedControl.test.tsx
[x] src/__tests__/FormControl.test.tsx
[x] src/__tests__/ThemeProvider.test.tsx
[x] Overlay

Closed by: https://github.com/primer/react/pull/2730


1.0 exposing route requires explicit mtls disable or other option

https://github.com/redhat-developer-demos/istio-tutorial/blame/master/docs/2deploy-microservices.adoc#L90
Either the service permissions will need to be modified to disable mTLS or enter we need to not use the router and enter the mesh through the gateway routes.

The default install for this tutorial should not have mTLS enabled. Are you
seeing that it is? We need to change the install instructions if so.
On Mon, Jul 23, 2018 at 11:00 AM Erik M Jacobs<EMAIL_ADDRESS>wrote:

https://github.com/redhat-developer-demos/istio-tutorial/blame/master/docs/2deploy-microservices.adoc#L90
Either the service permissions will need to be modified to disable mTLS
or enter we need to not use the router and enter the mesh through the
gateway routes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer-demos/istio-tutorial/issues/102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADP0a0lCRCt5zUlXPxNs3LmYYPMnX4Hks5uJeUogaJpZM4VbKAd
.

--
Christian Posta
twitter: @christianposta
http://blog.christianposta.com http://www.christianposta.com/blog

I was using istiooc which I am assuming is enabling global mTLS which is causing the issue.
So, it brings up a question about whether or not we want the tutorial to use "our" bits?

apiVersion: authentication.istio.io/v1alpha1
kind: Policy
metadata:
  name: customer-service-mtls-disabled
spec:
  targets:
  - name: customer
    ports:
    - number: 8080

This disables mTLS for the customer service.

So this is not a bug in the tutorial.


METRON-1374 Script Metron Release Validation

This PR introduces a script that automates the documented process for validation of metron release candidates.
It will:
Download the files
Install the keys
Validate the signatures
Build and test metron + rpms
Start full dev
to test ( with RC2 )
%> cd build_utils/release-utils
%> bash ./metron-rc-check 0.4.2 RC2 0.1.0

where 0.4.2 is the release number, RC2 is the RC, 0.1.0 is the bro plugin version

When asked, enter yes (y) for testing and full dev

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?

### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

@ottobackwards I am using this to validate the current release candidate.  Works great.
Small nit pick... Any chance we could use proper flags for the args and a --help? Maybe something like...

-v / --version,
-c / --candidate
-pv / --plugin-version
-h / --help

That's what I did with the release-utils/validate-jira-for-release.  Although, I would totally accept this as-is, as this is a really handy script to have.  Your choice.
Either way, +1 from me.

I thought the same thing once I saw your script.  I will definitely do that, I just wanted to get some eyes on it before I started mucking with it.
Would you mind if it were a follow on?

Follow on works for me.  We can probably do some work to standardize naming, flags, etc (including changes to my script too).
+1 on this as-is

I was thinking about a shared config file when you land the others...

@nickwallen  https://issues.apache.org/jira/browse/METRON-1376


os.getppid() < os.getpid()

In the file tests/sniptters/stdlib_os.py on line 269, this comparison is made:
assert os.getppid() < os.getpid()
Is this always true? The test failed once, but when I re-run, it passed?

resolves #1240


Conversations SDK - Add release date to changelog

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Fix snapshot volume size

This was preventing Ubuntu cloudimg from booting

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


HTTP Error 403: Forbidden

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'mp4', 'https://vz-c8dfe676-56e.b-cdn.net/ae94be3c-7df3-498f-9c9a-1c7c3bd00a63/1920x1080/video.m3u8', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.11.1 (CPython) - macOS-11.6-x86_64-i386-64bit
[debug] exe versions: rtmpdump 2.4
[debug] Proxy map: {}
[generic] video: Requesting header
WARNING: Could not send HEAD request to https://vz-c8dfe676-56e.b-cdn.net/ae94be3c-7df3-498f-9c9a-1c7c3bd00a63/1920x1080/video.m3u8: HTTP Error 403: Forbidden
[generic] video: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 634, in _request_webpage
return self._downloader.urlopen(url_or_request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 2288, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 525, in open
response = meth(req, response)
^^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 634, in http_response
response = self.parent.error(
^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 563, in error
return self._call_chain(*args)
^^^^^^^^^^^^^^^^^^^^^^^
File<EMAIL_ADDRESS>line 496, in _call_chain
result = func(*args)
^^^^^^^^^^^
File<EMAIL_ADDRESS>line 643, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)

Plainly you need to provide some authorisation data with the manifest URL to download it, so find out what that is and supply it.
If you reveal where the manifest URL was found or what site you're trying to use, we might be able to help.

Closing for lack of response.

Hi there,
I'm not sure if this issue was resolved or it's already duplicated.
But I tried it by providing my email and password (as below) yet I still got this error.
youtube-dl --username<EMAIL_ADDRESS>--password 'P@ssw0rd!' --output '/Users/test/Downloads/Backup' URL 'https://www.udemy.com/course/automated-software-testing-with-playwright/'

Read existing issues regarding Udemy and why, if lessons can be downloaded at all, you have to use --cookies ... rather than ---password ...


Remove TryGetPointer call from UvTcpConnection

Following the discussion in #1298
This is a really simple code change to remove the call to TryGetPointer in UvTcpConnection. It looks like the semantics are similar, but I don't think I'm fully following where that memory comes from and when it gets cleaned up, so want to make sure I'm not missing something important.
It probably also has a slight performance penalty.
I don't expect this is correct yet, just a starting point. Once this one's sorted I'll look at the RIO impl.

@davidfowl Like this? It feels kind of weird having to call Free and null the buffer variable, but maybe it's not actually a big deal.

@davidfowl Like this? It feels kind of weird having to call Free and null the buffer variable, but maybe it's not actually a big deal.

Yea, the problem is that OnRead can get called without OnAlloc so you have to know if you did indeed call .Pin so we don't try to double free (decrement the ref count)

cc: @mjp41

If your are aiming for parity with gchandle the there should be an "IsAllocated" property
Then you can do Is allocated okay then free

This allows a user who knows for sure it will be allocated to not have to pay the price of a check. But a user who is unsure can implement the check

LGTM, shall we raise an issue to make Free idempotent, or provide a IsAllocated? (@davidfowl, @KrzysztofCwalina)

Why would we want to allow multiple calls to free? Isn't it a bug to call it multiple times? If multiple threads call it, it seems like it's left to change that one of the threads won't need the handle after another thread frees it.

Why would we want to allow multiple calls to free? Isn't it a bug to call it multiple times?

Both MemoryHandle and its internal GCHandle are pass by copy structs so you'd either need to deal with that if you want to catch it.
I assume GC Handle's extren InternalFree is idempotent; so is only the multi-call to _owner.Release(); that needs caution?

Why would we want to allow multiple calls to free? Isn't it a bug to call it multiple times?

It is convenient to allow calling Free if the handle was not allocated at all. Considers something like this:
class MyAsyncReader
{
    MemoryHandle<byte> _handle;

    ...

    ~MyReader()
    {
        // This can be null if an exception happened before the _handle was allocated so you need to check for IsAllocated
        _handle.Free();
    }
}

Similar if you do cleanup using try/finally blocks. You either need to structure your try/finally blocks just right, or check for IsAllocated before calling Free.
It matches what C/C++ does. operator delete or free can be passed null and do nothing in that case.
GCHandle.Free is over engineered in a bad way in this regard: It throws for null handle and thus requires you to check for IsAllocated; but has Interlocked.CompareExchange to protect against people calling it on multiple threads.
I do not have opinion on this yet. Just listing some reasons why it may be a good idea to allow it…

If you don't have the lifetime logic totally under control of a single thread, calling IsAllocated does not help either. It has a race and it would just make finding bugs harder.

You might have the life time sorted .. it is a struct right? So consider a gchandle which was the Api guideline  rather than having to have nullable you can test in a destructor if it is already freed. If so don't call free.

Both MemoryHandle and its internal GCHandle are pass by copy structs so you'd need to deal with that if you want to catch it.

@benaadams Hmm, that's interesting, so you can't tie the Free method to a particular instance of the handle, since there may be more handles floating around that correspond to the one ref count.
My feeling is that because this is a public API we should make an effort to avoid footguns like multiple calls to Free. Since it's pass-by-copy you can't really store that as state on the handle itself, right?

Since it's pass-by-copy you can't really store that as state on the handle itself, right?

You can solve it for a class member or use within a single function stack space/async; its whether to go further and try to solve it for multiple copies?

Ahh the footgun known as GCHandle... I am missing some toes due to that very thing
Readonly Structs Copy When Calling a Method
At least it will be consistent with the current GCHandle 😈

Is this discussion about Free likely to block this PR as it stands? Or can it be moved to a new issue and worked out independently?

I think we should merge with a change to allow multiple calls to Free, or merge as-is and then change to allow multiple calls.
@davidfowl?

If you merge as is. I can fix free today.

Sure this is fine. I still don't want to remove TryGetPointer as yet.


entc/gen: fix method conflicts in mutation builders

Fixed #475

Thanks for doing all this! Much appreciated.
On Fri, May 8, 2020 at 11:02 AM Ariel Mashraki<EMAIL_ADDRESS>wrote:

Merged #479 https://github.com/facebookincubator/ent/pull/479 into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebookincubator/ent/pull/479#event-3317887763, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAET25TR4C3KFXSGD64XBTRQRCLZANCNFSM4M4K7G3A
.


Poll System

players
teams
heroes
maps

[...]

Quoting Rikki:
we would like to have the option to have backendusers create polls on the website in any way shape or form
And options should be choosable from all players, all teams, all heroes
filters like: All seasons, all divisions, Season X, Division Y, Season X-Y, Division X-Y, Player has role X
certain players, certain teams
most importantly: only people who are registered shall be able to vote, with further restrictions like: parcipated in season X or is active, or [...]. This ensures non lounge players wont rigg the polls.
you are actually quite free to do whatever you like, but that's what I think about while brainstorming.

Sloth


Work Package wp-aa.csv

I would like to work on this please!

Results of Phase 1
wp-aa-results.csv

I completed this work package.

I completed this work package.

I would like to work on this please!

Results of Phase 2
wp-aa-results.csv

I completed this work package.

Thanks for you work on the package. I just included the data into the repository and it will appear on the website soon.


Chinese characters can not typed in any editable text field

Operating system or device, Godot version, GPU Model and driver (if graphics related):
OS:Mac OS
Godot: 2.X and 3.X
Issue description:

Steps to reproduce:
add A Label
Change the input source to Pinyin-Simplified
Chinese characters can't typed into the Text property box.
Link to minimal example project:

Godot default font does not support non-latin letters. It sounds like #6404 but im not sure

OS: windows10
Godot: 3.1.stable

Editor and script can show and input chinese characters, but label cannot.
@akien-mga

@dingdalong This is because the default project font doesn't contain CJK characters. Try loading one of the Noto fonts as a DynamicFont in your project, and specify it as the default font of the root Control node's Theme resource.

This is absolutely not a bug. Godot TextEdit works with CJK characters 100% sure. If you haven't see any CJK characters, just set a CJK font to custom font property.
Please close this issue. It's not an issue.

I'll close this issue then. I still think we should find a way to document this better (or make missing characters more obvious), but I remember seeing other issues about that.


High CPU usage.

VSCode Version: 1.5.3
OS Version: OS X 10.11.6

Steps to Reproduce:

Open VSCode with disabled extensions (--disable-extensions)
Open a JS file from this repo: https://github.com/artsy/emission
Scroll vertically (possibly 2 files in split panes)
Observe Code Helper process consuming ~100% CPU cycles.

Note that I’m seeing ~15% CPU usage when idle, which also adds up quickly when running multiple editors.
CPU-20160928T134657.cpuprofile.txt

If this was Windows I would assume this is because of accessibility ON, but since this is on Mac it might be something else.
@alloy does this reproduce with any 2 files open?

Open a JS file from this repo

@alloy Can you precisely name the file which causes this for you. If I open a JS file I cannot repo (index.js, load_failure_viewjs, opaque_image_view.js)

I open the full project with: code . --disable-extensions
Open e.g. infinite_scroll_grid.js in 2 split panes.
Scroll fast up and down repeatedly in one of the panes.

Maybe the same with #10289

doesn't repo for me - I see some CPU load while scrolling but not after, nothing stays busy

I have also tried, but was not able to reproduce any slowness.

When I have the time, I’ll spend some more time thinking about what in my local env could cause this.


Add vhdd_temp_path to hyperv-iso builder

Issue
#69
List of Changes Proposed
Add vhdd_temp_path to hyperv-iso builder

Coverage remained the same at 81.944% when pulling 7c7d838e88c1040ef54fbe356f93b005b908349c on mprince:issue69 into 48bff8ea61ef558a828d97f2640fd550f2ab375c on mayn:master.


getting the fastq reads from accession ids

Hey All,
I am interested in extracting out the fastq reads of accession ids. But I cant find the element FtpPath in the document summary information.
I am trying something like this-
esearch -db sra -query "ERX4643323" | elink -target biosample | efetch -format docsum | xtract -pattern DocumentSummary -element FtpPath_RefSeq
Is It possible?
Regards
Jigyasa

In order to download reads from SRA in FASTQ format, you will need to use the sratoolkit. You can find more information about downloading data from SRA here.

But I cant find the element FtpPath in the document summary information.
Not every docsum includes the FtpPath tags. You need to first check the XML returned by esummary for what's included and then use xtract to retrieve specific data.


Increase range for peer dependencies

Hi Alvar! Thanks for creating this great package - love the approach you took 👏
While installing, I ran into this annoying npm --legacy-peer-deps issue. So I thought increasing the compatibility range for peer deps might be a good idea - assuming that the package works with React 17 too (though I don't know why it shouldn't).

That does seem like something I could do. Will get to it tomorrow.

Did not realize this was a PR. My CI action did not seem to run, so I edited it to hopefully include this PR. Please rebase against master when you can.

Done 👍

Merged. A new release was just created automatically. Realizing now that since the commit here did not follow Conventional Commits, the release note is empty. But the change should be there.


Generated API guard pattern for C# should not throw 'Exception' type

Currently the C# backend generates the following if the API version check pattern is implemented and the API version check fails:
throw new Exception($"API reports hash {api_version} which differs from hash in bindings<PHONE_NUMBER>713624474). You probably forgot to update / copy either the bindings or the library.");

It is recommend practice to never throw an Exception of the base 'Exception' type:
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/using-standard-exception-types.
There's not an incredibly obvious answer as to what system exception type to use instead, potentially a 'TypeLoadException'? Alternatively a custom generated Exception type could be created and used.

Amazing, thanks for the quick fix!


Request Times

Is there a way configure the HTML reports to show the number of requests per minute or hour?

Not at the moment. That would probably be part of #300. Stay tuned for those updates.


Optimize OrExpr

From<EMAIL_ADDRESS>on February 13, 2014 19:55:40
While profiling Crbug, I noticed that a lot of time is being spent executing OrExpr.f().  This must be for the "status=New,Accepted,Started" (Open issues) query.  The QueryParser should parse this as an InExpr instead because the QueryOptimizer can better optimize these kinds of statements.
Also, test the use of Array.some() to make sure that it isn't less efficient than the old method of implementing OrExpr.
Test a move-to-front optimization (for AnExpr also).
Original issue: http://code.google.com/p/foam-framework/issues/detail?id=182

Merged with #34.


New table: actors

actors

table for all subjects related to activities (table: measures)
can either be active "doers" or passive "targets" of an activity

Permissions by role

public: none
registered, no role: none
analyst: R
manager: CRUD
admin: CRUD

Fields

type_id: FK > actortypes.id
code: string
title: text
description: text
url: string
population: decimal
gdp: decimal
private: binary
draft: binary

Hi @parndt, please note that I have added one more text field "activity_summary" to this table. Cheers!

Thanks @tmfrnz !

@parndt actor_type_id should have been called actortype_id as per specification (please action if easy to change)

see #57

Fixed by #61

attribute code should not be required and allowed to be null or empty, eg

https://github.com/dumparkltd/marine-defrag-server/blob/master/db/schema.rb#L47
https://github.com/dumparkltd/marine-defrag-server/blob/master/app/models/actor.rb#L4


OSD does not show ADF

Hello good day.
I have installed OSD on an A500 Rev 5 and apparently everything works.
L. Ctrl + L. Alt + Return works.
L. Ctrl + L. Alt + Help works.
L. Ctrl + L. Alt + Del works.
L. Ctrl + L. Alt + Left Up and Right do not work. It does not show anything on the screen I can not switch between the different ADFs, but if the GOTEK buttons work, however I can configure the OSD menu.
what can happen?

Do you have a jumper installed across A0-A1 and are you using latest FlashFloppy v3.x?

Yes, the jumper is in A0-A1 and the firmware is version 3.7A, this version is programmed with USB-TTL to avoid failures.

Do the arrow keys actually work? Have you tested them on the Amiga?

I have done several tests with the keyboard and it works perfectly, I have recorded a video with the error if there is a way to indicate where the problem is. Thanks greetings.
https://youtu.be/pqOCq13rmkY

And so we're clear on the situation, what is the FF OSD version number?

Ah I see in the video... Latest v1.7? You don't have any wires installed from OSD to gotek buttons right (you shouldn't)?

I don't see any output from the gotek to the OSD. Are you sure the gotek is talking to the osd? When you change image it should appear on screen, for example.

The version of the OSD is the latest 1.7, I have no cable connected to the GOTECK buttons, and nothing appears on the screen when switching between ADF, it seems that effectively as you say you do not communicate the Goteck with the OSD. The diagram used for the connection has been as follows:
SCL = B6
SDA = B7
VCC = 3.3
GND = G

I'm going to try changing the lines:
SCL = B7
SDA = B6
and I comment the result, since the goteck is also flashed with the FF 3.7a version with USB-TTL.

Did you attach a 4.7k pullup resistor from each of B6 and B7 to 3.3 ? It won't work otherwise.

I hope you can apologize to me, do not connect the 3.3v to B6 and B7, for that reason there was no communication. Thank you very much for your work, a big greeting


[WIP] add support for rename/renameat

Please first review https://github.com/nix-rust/nix/pull/751

see https://github.com/nix-rust/nix/pull/751#issuecomment-333878207


Possible issue with Elasticsearch 1.3.3

See https://github.com/elasticsearch/elasticsearch/issues/7916 (or here: https://groups.google.com/d/msg/elasticsearch/jf_c1nyyeAc/cUcSyo58lDkJ)

I am archiving this repository now. Thanks for contributions.


Need to provide VersionFlag to JsonSchemaFactory.getInstance()

I am trying to set this up in a project running the following versions of dependencies:
    implementation("com.networknt:json-schema-validator:1.4.0")
    implementation("com.mservicetech:openapi-schema-validation:2.0.8")

It's a simple Spring Boot Web app with the following controller:
@RestController
@RequestMapping(value = ["/v1/inputs", "/inputs"])
class InputsController(val apiValidator: OpenApiValidator) {
    @PostMapping(consumes = [MediaType.APPLICATION_JSON_VALUE])
    fun postInputs(
        @RequestBody
        body: String,
    ): ResponseEntity<Any>
        val requestEntity = RequestEntity()
        requestEntity.requestBody = body
        val validation = apiValidator.validateRequestPath("/inputs", "post", requestEntity)
        return ResponseEntity.ok("OK")
    }
}

Following the thread of execution I found the call and the error is pretty clear in my IDE:

I'm happy to provide a PR to fix this, but I was wondering what you wanted the behaviour to be? It feels to me like we could just add something onto the configuration for the OpenApiValidator so people could override the behaviour if they wanted to but then just set a sensible default.
What do you think?

It is all fixed in the master branch. We need to release a new version to take advantage of the OpenAPI 3.1.0


il2cpp-bridge source code theory question

I want to know some deep theory about il2cpp-bridge

Il2Cpp.perform

https://github.com/vfsfitvnm/frida-il2cpp-bridge/blob/e99fb8a2d4812a52e40e6cf2f8ceb5a6b4db6e14/src/il2cpp/base.ts#L204
especially this line , the line run on il2cpp thread ? if this line run on il2cpp thread , i can under stand to code below this line , if not , i can't understand
wish to get your reply

Hi!
1
if (Il2Cpp.Api._getCorlib().isNull()) {
    await new Promise<void>(resolve => {
        const interceptor = Interceptor.attach(Il2Cpp.Api._init, {
            onLeave() {
                interceptor.detach();
                setImmediate(resolve);
            }
        });
    });
}

This snippet waits for Il2Cpp to be initialized. When libil2cpp.so (or whatever) is loaded into memory and its library constructors are invoked, we still need to wait for the call to il2cpp_init to finish.
int il2cpp_init(const char* domain_name)
{
    // Use environment's default locale
    setlocale(LC_ALL, "");

    return Runtime::Init(domain_name);
}

Runtime::Init initializes the Il2Cpp world (metadata, types and other things). If we try to invoke a il2cpp_* function before the initialization process finishes, we'll mostly run into problems or errors.
Il2Cpp.Api._getCorlib().isNull() is a workaround to check whether the call to il2cpp_init is already finished. If it's not, we hook il2cpp_init and wait. When the invocation finishes, we are here:
onLeave() {
    interceptor.detach();
    setImmediate(resolve);
}

We detach the interceptor and call resolve so the await for the Promise ends. We must use setImmediate, otherwise our code will keep executing in the same thread who called il2cpp_init (we don't want that to happen).
2
let thread = this.currentThread;
const isForeignThread = thread == null;

if (thread == null) {
    thread = Il2Cpp.Domain.attach();
}

try {
    const result = block();
    return result instanceof Promise ? await result : result;
} catch (e: any) {
    (globalThis as any).console.log(e);
    throw e;
} finally {
    if (isForeignThread) {
        thread.detach();
    }
}

This snippet makes sure block is invoked in a Il2Cpp thread.
this.currentThread (which calls il2cpp_thread_current) returns a null pointer if the caller thread is not attached to Il2Cpp (= it's not a Il2Cpp thread). So, if the caller thread isn't attached to Il2Cpp, isForeignThread is true.
When isForeignThread is true, we are responsible to attach the caller thread to Il2Cpp (Il2Cpp.Domain.attach()) and to detach it later (thread.detach()). This ensures block is executed in a thread attached to Il2Cpp.

oh , thank you so much , i understand the code via debug the snippet
and another question
static attach() {
    return new Il2Cpp.Thread(Il2Cpp.Api._threadAttach(this));
}

why here _threadAttach function can pass an object ? _threadAttach  function is NativeFunction and the argument shoule be nativePointer ? can replace by this.handle
the NativeFunction internal detect the argument ? if the argument is an object , it will pick up the object's handle ?

oh , thank you so much , i understand the code via debug the snippet and another question
static attach() {
    return new Il2Cpp.Thread(Il2Cpp.Api._threadAttach(this));
}

why here _threadAttach function can pass an object ? _threadAttach function is NativeFunction and the argument shoule be nativePointer ? can replace by this.handle the NativeFunction internal detect the argument ? if the argument is an object , it will pick up the object's handle ?

I see get object() method

You can pass a NativePointerValue, which is a NativePointer or ObjectWrapper.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/frida-gum/index.d.ts#L1624
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/frida-gum/index.d.ts#L1597


Is there a plan to publish checkpoints?

Thanks for the great work! And I'm also looking forward to the release of the pre-trained models.

Sorry for the late reply.  I release pre-trained models on the KITTI dataset for your reference:
https://huggingface.co/claudecc/diffusiondepth/tree/main.
You may also refer to the updates on the README for more information.
cheers


Implement PRs checks to validate that curated license expressions are actually valid SPDX

    PR validation is a great idea. we have an spdx library that should be able to do that work so putting together an action should be straight forward.

cc @nellshamrell
Originally posted by @jeffmcaffer in https://github.com/clearlydefined/curated-data/issues/7937#issuecomment-722745006

Hi @sschuberth! I am no longer working on Clearly Defined (I've moved to another project at MSFT). Tagging @mpcen.

Ok

The current SPDX check isn't correctly identifying Unicode-3.0 which is listed here https://spdx.org/licenses/Unicode-3.0.html
and blocking my PR https://github.com/clearlydefined/curated-data/pull/28735
The Unicode-3.0 identifier is already used multiple times within the curated files


Create modal - Template naming and list order

Describe the bug
The list of templates in the create modal should be arranged intentionally, potentially from simple to more complex for R12 release, and the names themselves should be revised. @Dewain27 @emivers8 @benbrown and @mareekuh to agree on naming. Initial recommendations below, but final TBD.
Initial recommendations:

Blank bot (empty bot)
Basic conversational bot (conversational core)
QnAMaker bot (generator-qna-bot)

(Is multibot or calendar part of release for R12?)
Screenshots

No the multibot "Calendar assistant" and the "Calendar" bot are not going to be publicly released.
It is quite difficult for us to sort these in a different order than they come in from the API without building making things quite brittle. We'll need to discuss a method for achieving this.


Vscode shell tasks

Type: Feature Request
I know from regular terminal processes when you reload the window the terminal does not get killed can this be an option feature for vscode tasks as well
In addition I would like an os-agnostic solution where you have the option to open running tasks in external terminal windows and even so if the OS terminal supports tabs have all the task run in each respective tab in the same terminal window
In addition just like you can dock text editors you should add a feature to dock terminals as well, so you dont have to create an os-agnostic solution
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.22621
Modes:

I know from regular terminal processes when you reload the window the terminal does not get killed can this be an option feature for vscode tasks as well

Tasks do support reconnection, I believe this was implemented before you reported this. Please create a new issue with more information if you have problems with this.

In addition I would like an os-agnostic solution where you have the option to open running tasks in external terminal windows and even so if the OS terminal supports tabs have all the task run in each respective tab in the same terminal window

We have minimal integration with external terminals to reduce bloat in VS Code. This is a good candidate for an extension to implement.

In addition just like you can dock text editors you should add a feature to dock terminals as well, so you dont have to create an os-agnostic solution

Not sure what you mean exactly, but it sounds a little like https://github.com/microsoft/vscode/issues/34442

We have minimal integration with external terminals to reduce bloat in VS Code. This is a good candidate for an extension to implement.

I am not sure what is meant by this. Essentially what we are coming to find is that when a task is run in vscode and it has to run a command in an external terminal for progress reporting the external terminal is opened. But an error is thrown when attempting to run the command in an external terminal and it has to be done via different methods. This is needed to show user progress of the task they are running


Frame tests

Create tests for frame_authenticate
Derive tests to frame_auth_response

Coverage increased (+0.1%) to 97.542% when pulling c905591ffcf7e729610fdef374f749d4d76ed5bb on frame-tests into 7f033373305a217cf91547f6a1f1f1d72c05bf26 on master.

Codecov Report

Merging #75 into master will increase coverage by 0.13%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage    97.4%   97.54%   +0.13%
==========================================
  Files          12       14       +2
  Lines         848      895      +47
==========================================
+ Hits          826      873      +47
  Misses         22       22

Impacted Files
Coverage Δ

src/frame/frame_authenticate.rs
100% <100%> (ø)

src/frame/frame_auth_response.rs
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f03337...c905591. Read the comment docs.


An SST-based random data generator

Introduces a new command-line utility, datagen, that generates a random dataset conforming to an SST.
There are a couple of known limitations which will be addressed in future work

Structure within strings is not recognized (phone numbers, SSNs, UUIDs, ISO8601, etc) and the values generated from these will not retain any of their structure. This can be improved by improving the amount of information we capture about the distribution of characters within strings in SSTs and also possibly by explicitly recognizing certain common patterns for more declarative generation of the represented values.

Known tagged types are not generated directly. Since most of these are temporal types and are represented as maps, the resulting generated values are actually quite useful, though there is a chance they are invalid (i.e. 2017-02-30). This can be improved by noticing the type tags and using them to drive the semantics of generation.

#qz-3634 Done.

I'll add issues in YouTrack for the aforementioned limitations.


Argument types in documentation.

I'm trying to understand Docile a little bit and are going through some of the code.
I have a question regarding the argtypes in the output of the documentation.
e.g.: in documentation

source: https://github.com/MichaelHatherly/Docile.jl/blob/master/src/interface.jl#L76

Do you thing it is required to have the module added.
Sometimes it gets quite long: Docile/src/types.jl:129
pushmeta!(doc::Metadata, object, entry::Entry)

becomes
pushmeta!(doc::Docile.Metadata, object, entry::Docile.Entry{category})

I just wonder if it should not appear in the documentation as the original source was written.
I know the extra added info has some value but just asking - if for instance this could be optional or as extra info like meta data source or so
I'm asking especially as we consider also to add the kwargs then this might get real long and might be not so easily readable?
This happens already with some of the call things.
call{format}(::Type{Docile.Docs{format}}, docs::Docile.Docs{format})

source points to: https://github.com/MichaelHatherly/Docile.jl/blob/master/src/types.jl#L24
Docs(docs::Docs) = docs

I find such hard on the eye eventhough there might be extra info.

Basic idea behind it: if the code author did not not plan to fully specify the types - maybe it should also not be automatic in the generated documentation.

Yes, it will get really long if we start adding kwargs there as well. I'd prefer something like a list or table of the keywords and their default values added in the metadata section of the output.
Regarding the module-qualified output, 0.4 changed the printing of objects to always display their full names. So we need to decide whether to match the output of julia itself, or clean up things where possible. That also goes for the call overloading, we'd need to special case call and rewrite the signature.

Yes the call things looks ugly at best.
My personal feeling is it should be like in the source code: if a developer things the Types are important so might it be in the docu - if a coder things it is not important in the code neighter should it be a problem for the documentation

So the beginnings of signature rewriting is already in https://github.com/MichaelHatherly/Lexicon.jl/blob/a145a3b6fcbb38869494355ed79111b2bcafa7e7/src/render.jl#L216-L223. We'd just need to decide on what to rewrite and what not to.
Perhaps the following rules:
Module-qualified objects should have the module removed if they're from the current module.
Rewriting call as
call{format}(::Type{Docile.Docs{format}}, docs::Docile.Docs{format})

 ->

Docs{format}(docs::Docs{format}))

Not sure how simple this will be though.

Closed in favour of: https://github.com/MichaelHatherly/Lexicon.jl/issues/118


Improve retrying index issues

Fix #27540

I was unable to create a backport for 1.20. @wolfogre, please send one manually. :tea:
go run ./contrib/backport 27554
...  // fix git conflicts if any
go run ./contrib/backport --continue


How to change wirings runtime

Please help.
How to change wirings runtime when my node has dynamic selects and inputsm, visible/invisible  by conditions.
When I fill inputs/selects then box height changed and inputs/outputs positions changed too, but wirings are on the same positions.
How to rearange wires by runtime?

View function updateConnectionNodes(id)
Example use:
editor.updateConnectionNodes('node-5');


Use sideEffects: false

What's your idea?
We could try adding sideEffects: false to our package.json for more aggressive optimization in webpack. Off the top of my head I'd say this should be as simple as it sounds, but we should definitely verify.
We should also verify what the actual impact on bundle size is.

See https://github.com/stereobooster/package.json#sideeffects