comment-author cannot be printed at this case

Hi, I'm satisfied with this product.
However, when I was testing my github-action with your product, I found something strange.
After the several tests, I think maybe you didn't deal the case that comment-body contatins \n character for some reason
These are what I tested...

I used this code at Find Comment and Run echo step below
- name: Find Comment
      uses<EMAIL_ADDRESS>      id: fc
      with:
          issue-number: 1
          body-includes: ${{ github.event.comment.body }}
    - run: |
        echo ${{ steps.fc.outputs.comment-id }}
        echo ${{ steps.fc.outputs.comment-body }}
        echo ${{ steps.fc.outputs.comment-author }}

When I posted an issue comment like (not includes \n)
[질문] 개행아아아아

-> get comment-author well

When I posted an issue comment like (inclues \n)
[질문]
개행아아아아

-> it occurs error 개행아아아아 commands not found. BUT, actually 개행아아아아 is not a command but a part of comment-body

When I posted an issue comment like (not inclues \n, space)
[질문]

-> it occurs error \r command not found.

Hi @kimhanui
I think you need to quote the input. I'm not sure if there is a difference between single and double quotes for yaml, but you can try both and see.
e.g.
      uses<EMAIL_ADDRESS>      id: fc
      with:
          issue-number: 1
-         body-includes: ${{ github.event.comment.body }}
+         body-includes: '${{ github.event.comment.body }}'

@peter-evans
oh.... I didn't even imagine it, thanks for answering this. 👍


Rename main endpoint from /paradas, to /main

This change will affect other projects, such as katangapp-frontend and katangapp-android, so we must send a PR changing it on those repos

On android repo: https://github.com/craftsmanship-toledo/katangapp-android/blob/dev/app/src/main/java/es/craftsmanship/toledo/katangapp/services/StopsService.java#L14
On frontend repo: ??

Merged, thanks!


2023 June meeting: raw notes

Raw notes, with names removed apart from the main index page which lists attendees.

I wonder if we should pay more attention to content and ensure all of it is stuff people are happy to be public (e.g. ways that openSAFELY works etc)

@manics what do you think?

Probably a good idea!

Looks like a game of nice-idea-but-i-dont-want-to-do-it-tennis. You got time to look this week? Otherwise I can do a quick runthrough on Monday


Badges de codecov y travis.

Instrucción de como ejecutar la aplicación

Codecov Report

Merging #39 into develop will decrease coverage by 3.80%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop      #39      +/-   ##
=============================================
- Coverage      41.33%   37.53%   -3.81%
  Complexity        86       86
=============================================
  Files             41       41
  Lines            375      413      +38
  Branches          13       15       +2
=============================================
  Hits             155      155
- Misses           215      253      +38
  Partials           5        5

Impacted Files
Coverage Δ
Complexity Δ

...ba/algo3/controller/GenericQuestionController.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df0b2f...e0dc00e. Read the comment docs.


Rename SelectItem to Projection

For #3061.

Pull Request Test Coverage Report for Build 455

121 of 193 (62.69%)  changed or added relevant lines in 35 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.009%) to 65.872%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/core/merge/dql/DQLMergeEngine.java
7
8
87.5%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/segment/select/pagination/engine/PaginationContextEngine.java
0
1
0.0%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/ProjectionsTokenGenerator.java
18
19
94.74%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/SQLRouteResult.java
0
1
0.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/adapter/AbstractResultSetAdapter.java
2
3
66.67%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java
2
3
66.67%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/segment/select/pagination/engine/RowNumberPaginationContextEngine.java
0
2
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/statement/impl/SelectSQLStatementContext.java
8
10
80.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/SQLRouteResult.java
1
60.0%

Totals

Change from base Build 418:
0.009%

Covered Lines:
9728

Relevant Lines:
14768

💛  - Coveralls


Can't view archived logs in UI

Summary
What happened/what you expected to happen?
User cannot view the logs in 3.1rc6 (also tested in rc5) despite the fact they are there.

Enable log archiving.
Install v3.1-rc6 and run a workflow. When completed look at the archived logs (user just gets the error "Artifact not found")
Downgrade to v3.0.4, view that completed workflow in the UI and look at the archived logs.

Diagnostics
What Kubernetes provider are you using? EKS 1.19
What version of Argo Workflows are you running? 3.1-rc6
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary Docker
Did this work in a previous version? I.e. is it a regression? Works in 3.0.4
All the logs indicate that the logs have been archived, and there are no errors in logs when trying to view them.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Can you confirm if the problem is that the logs are not viewable (UI issue) or they were never stored in the bucket?

They are not viewable. They save fine.

@tim-sendible would you be willing to investigate, maybe with @dcherman help? The core team is short-staffed at the moment.

@tim-sendible Are you getting any network errors / HTTP 500s at all?  I haven't had time to dig into anything really, but I did notice that with the code in master, the log viewer fails to load logs.  It's seemingly due to the following commit:
https://github.com/argoproj/argo-workflows/commit/284adfe16aeb11536a1c98f1956fdeb76dac4f1c
Where the main-logs is misidentified as an input artifact.  That HTTP 500 should almost certainly be a 404 as well since the artifact wasn't found.  Not sure if this is the same bug you're seeing or not, this commit was first released in 3.1.0-rc1 it looks like.

@dcherman I have not seen any network errors at all. I will try and find time tomorrow to reinstall the latest RC and try again.

@dinever it seems your commit has introduced a regression. Would you please be able to investigate?

@dinever it seems your commit has introduced a regression. Would you please be able to investigate?

Sure, will look into it

Same problem here. The artifacts, including the logs, are in the S3-bucket but the UI shows a 502 Bad Gateway
error in the argo-server log:
time="2021-05-26T09:47:03.606Z" level=info msg="Download artifact" artifactName=main-logs isInput=true namespace=argo nodeId=terraform-tsvg5-3595155252 workflowName=terraform-tsvg5
2021/05/26 09:47:03 http: panic serving <IP_ADDRESS>:41622: runtime error: invalid memory address or nil pointer dereference
goroutine 2284 [running]:
net/http.(*conn).serve.func1(0xc0006f6fa0)
	/usr/local/go/src/net/http/server.go:1801 +0x147
panic(0x2315e20, 0x43a8770)
	/usr/local/go/src/runtime/panic.go:975 +0x47a
github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1.(*Inputs).GetArtifactByName(...)
	/go/src/github.com/argoproj/argo-workflows/pkg/apis/workflow/v1alpha1/workflow_types.go:2473
github.com/argoproj/argo-workflows/v3/server/artifacts.(*ArtifactServer).returnArtifact(0xc00020e300, 0x3407100, 0xc000d5cab0, 0x33fe5c0, 0xc0007947e0, 0xc000ec2500, 0xc0001f1c00, 0xc00061098a, 0x1a, 0xc0006109a5, ...)
	/go/src/github.com/argoproj/argo-workflows/server/artifacts/artifact_server.go:148 +0x118
github.com/argoproj/argo-workflows/v3/server/artifacts.(*ArtifactServer).getArtifact(0xc00020e300, 0x33fe5c0, 0xc0007947e0, 0xc000ec2500, 0x1)
	/go/src/github.com/argoproj/argo-workflows/server/artifacts/artifact_server.go:76 +0x5b1
github.com/argoproj/argo-workflows/v3/server/artifacts.(*ArtifactServer).GetInputArtifact(...)
	/go/src/github.com/argoproj/argo-workflows/server/artifacts/artifact_server.go:51
net/http.HandlerFunc.ServeHTTP(0xc000923910, 0x33fe5c0, 0xc0007947e0, 0xc000ec2500)
	/usr/local/go/src/net/http/server.go:2042 +0x44
net/http.(*ServeMux).ServeHTTP(0xc000920a40, 0x33fe5c0, 0xc0007947e0, 0xc000ec2500)
	/usr/local/go/src/net/http/server.go:2417 +0x1ad
net/http.serverHandler.ServeHTTP(0xc000794000, 0x33fe5c0, 0xc0007947e0, 0xc000ec2500)
	/usr/local/go/src/net/http/server.go:2843 +0xa3
net/http.(*conn).serve(0xc0006f6fa0, 0x3407040, 0xc0005f43c0)
	/usr/local/go/src/net/http/server.go:1925 +0x8ad
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:2969 +0x36c

Speaking of log artifacts: wouldn't it make more sense to automatically get the logs from the artifact repository when archiveLogs is enabled?

@dinever I think the problem is here:
https://github.com/argoproj/argo-workflows/blob/c8df5eae262223e8d32d740f43b8a7c013aba4ce/ui/src/app/shared/services/workflows-service.ts#L201
The download-URL for the logs is treated as an "input" artifact instead of an "output" artifact. In fact, if you replace /input-artifacts/ with /artifacts/ the logs download just fine.

Thanks for the info @svmaris! I've opened #6019 for the fix.

@svmaris what is the 'archiveLogs' you are speaking about ? I'm looking into such a feature in #5996 but impossible to make it work ... (Pod failed: Error (exit code 1): key unsupported: cannot get key for artifact location, because it is invalid")

@christopheblin I configured archiveLog in a ConfigMap named "artifact-repositories":
apiVersion: v1
kind: ConfigMap
metadata:
  # if you want to use this config map by default - name it "artifact-repositories"
  name: artifact-repositories
  annotations:
    # v3.0 and after - if you want to use a specific key, put that's key into this annotation
    workflows.argoproj.io/default-artifact-repository: default-v1
data:
  default-v1: |
    archiveLogs: true
    s3:
      bucket: my-bucket-name
      endpoint: s3.amazonaws.com
      insecure: false
      accessKeySecret:
        name: argo-artifacts-s3-creds
        key: accesskey
      secretKeySecret:
        name: argo-artifacts-s3-creds
        key: secretkey

For an example using the default minio storage backend, see https://github.com/argoproj/argo-workflows/blob/master/manifests/quick-start/base/artifact-repositories-configmap.yaml

I can confirm that this is resolved in 3.1.0-rc9. Thanks all.


Add Martin Alonso to Contributors.md

Followed gitkraken tutorial

@mtnalonso, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

@Roshanjossey it was pretty easy doing my first PR following the tutorial, I always like to contribute with the community but I'd never decided to do a PR sometimes because I wasn't confident enough with myself or felt lost doing it. Those are the main reasons why I joined Hacktoberfest, to improve myself and help more people with their projects.
Also noticed in the section "Keeping your fork synced with this repository" it was not necessary for me to follow the step "Double click the master branch under upstream on the left." as when I added your repo as remote, it fetched automatically all the changes and I was able to drag my master branch and drop it onto the upstream's master. I don't know if other users experienced the same behaviour, but for me doing doble click gave me some errors about updating the project.
Thank you!

@mtnalonso, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Prepare and release version 0.1.0

TODO:

verify dependencies
verify setup.py configurations
remove no-longer-needed template instructions (such as NEXTSTEPS.md)
verify changelog
tag version
push release to PyPI

3b. another example is ndx-nirs/docs/readme.md
7. remove text descriptions of version (I.e. alpha or beta), e.g. ndx-nirs/docs/source/release_notes.rst lists beta & ndx-nirs/docs/source/conf.py lists alpha

Release v0.1.0: https://github.com/agencyenterprise/ndx-nirs/releases/tag/v0.1.0

PyPI: https://pypi.org/project/ndx-nirs/


Feature Request: Windows 10 allow code to run a bash shell in addition to powershell

I use bash to run things like Ansible in my windows 10 workstation.  currently in Creators update, I can run via PowerShell bash -c "Ansible-playbook exampleplay.yml ".  It would be nice to have vs code to either give me the option to use a bash shell from codes integrated window or process a bash shell command from PowerShell.

https://code.visualstudio.com/docs/editor/integrated-terminal#_windows
// Git Bash
"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe"
// Bash on Ubuntu (on Windows)
"terminal.integrated.shell.windows": "C:\\Windows\\sysnative\\bash.exe"

???

Please see the documentation: https://code.visualstudio.com/docs/editor/integrated-terminal#_windows
Also new in 1.11 you should get a prompt on first launch to select the shell on Windows https://code.visualstudio.com/updates/v1_11#_improved-start-experience-on-windows

I use both bash and powershell. Can I configure VS Code so I can have a bash terminal and a powershell terminal at the same time??

@douglas-woods you should be able to run bash.exe in your ps session, there is also an extension I published to help with this https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher


Adding preflight validation for search engine

Signed-off-by: Vinay Satish<EMAIL_ADDRESS>Description
The search will not work as expected if the indexes are configured to read-only. This PR adds a preflight validation to make sure that indexes are not read-only
Issues Resolved
https://github.com/chef/chef-server/issues/3109
Doc PR - https://github.com/chef/chef-server/pull/3182
Check List

[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/main/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

Adhoc build - https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3938

Pipielines -
Adhoc - https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3967

https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3980

https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/3986

https://buildkite.com/chef/chef-umbrella-main-chef-server/builds/1090


Fix lint errors

This PR is based on top of https://github.com/conda-forge/fastpath-feedstock/pull/10 and fixes lint issues (adds stdlib(c) and bumps the build number).

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

No valid build backend found for Python recipe for package fastpath using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11518401417.

@conda-forge-admin, please rerender

@conda-forge-admin, please ping team


Phaser 3 - How can I change the slot skin programmatically?

I'd like to know does there have any document or pseudo code to show how to change the skin on  the runtime?
Thanks for the help.
The example I found is for Laya:
skeleton=templete.buildArmature(1);//创建动画，类型：1   支持换装
skeleton.pos(150,250);//动画位置
skeleton.play(0,true);//动画播放，从0帧开始，不断循环播放
skeleton.scale(0.5,0.5);//动画缩放为原始状态的二分之一
skeleton.replaceSlotSkinByIndex('head',0,1);//head插槽下，让索引为1的皮肤替换索引为0的皮肤

Finally, I found the solution:
const slot = armatureDisplay.armature.getSlot('head');
(armatureDisplay as any).factory.replaceSlotDisplay("Dragon", "Dragon", 'head', 'head2', slot);

But I just can't found BaseFactory, so I export to armatureDisplay object.
Has any standard way to access BaseFactory?

yes to access the factory instance, you'd better to call this.[dbPluginName].factory (assume that your code is right in the scene class).
for example, in your game config you inject the dbplugin with name 'dragonbone':
cfg = {
....
plugins: {
        scene: [
            { key: "DragonBones", plugin: dragonBones.phaser.plugin.DragonBonesScenePlugin, mapping: "dragonbone" }    // setup DB scene plugin
        ]
    },
....
}
new Phaser.Game(cfg);

and in your scene class, you need to define a type definition to avoid the error 'dragonbone is not defined'. for example
class myScene extends Phaser.Scene {
           dragonbone: dragonBones.phaser.plugin.DragonBonesScenePlugin;

           create(): void {     this.dragonbone.factory....       }
}


⚠ Turnos 24x7 has degraded performance

In 6a7445f, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3196 ms

Resolved: Turnos 24x7 performance has improved in 98e9872.


Add Strikingly

Hi,
I'm suggested to add Strikingly to the list, which is a CMS.
You can find a list of sites using Strikingly here : https://www.strikingly.com/s/discover.
Thank you !

Thanks, but your PR contains over 5,000 changed lines. I'm guessing it's auto-indented.


FolderPicker

It would be nice to extend the plugin with PickFolder method.
Possible use cases:

Select a folder to search files (folder with images, music, etc)
Select a folder to save file

Well, as a Xamarin plugins user I would not expect to find a FolderPicker method in a FilePicker plugin, but YMMV. There is a PR already for a folder picker, but I think it would better fit in another plugin, or even in Xamarin.Essentials. Just my two cents...

We can rename plugin to FileFolderPicker or something similar

In theory that is possible, but I think we’re going to make a lot of people unhappy if we start renaming namespaces.
The future of this plugin is with Essentials. For the time being this won’t be implemented because of that. Sorry :(

I am sure we do not need to rename namespaces (even the name of the package).
Unfortunately Essentials doesn't support Xamarin.Mac, WPF etc(


Enable reporting of TabletManagementIterator errors

Enable the TabletManagementIterator to report error's back to the TabletGroupWatcher when trying to determine actions that should be taken for an extent. Increment metric gauges when an error occurs.
Fixes #3469

@dlmarion would it make sense to remove ManagementAction.BAD_STATE and roll it into this new more general error handling?

BAD_STATE is set in TabletManagementIterator when tm.isFutureAndCurrentLocationSet(). However, it's never checked in TabletGroupWatcher. Instead, TGW also checks tm.isFutureAndCurrentLocationSet() and throws BadLocationStateException in this case. When this is thrown, repairMetadata is called to fix it. I think we can get rid of BAD_STATE in the iterator entirely, as it's checked in TGW. I don't think we should roll it into the error handling.

Looking at the code further, I think we should leave as is. If we are not going to add an error for this condition, then we need to add an action so that the TabletMetadata gets returned.

When this is thrown, repairMetadata is called to fix it.

Ok, so need to do one or the other.  I had an item on the project board to look into the repairMetadata function and I just converted it to an issue #3888 and commented on it.


Code quality: use injector / get_service in uninstall.php

Feature Description
Use injector / Service:get_service in uninstall.php, in the following lines.
https://github.com/google/web-stories-wp/blob/99422064c5a6d7a8b81e220de1ee0e3805191c22/includes/uninstall.php#L186-L191
Alternatives Considered

Additional Context

Some of these services might not be available in certain contexts, e.g. when uninstalling via WP-CLI. Would need some testing.


Added M pattern

@madhavtripathi05 I'm closing the PR as it is not fulfilling the requirement...you can send a PR again after maintaining all the steps and eligibility criteria for a valid PR...

serial number was ambiguous everytime I tried and resulted in a merge conflict so had to remove my details from contributors.md but okay as you wish man


Edits to MATLAB code: 1) add missing data values functionality, 2) substantial speed optimizations in non-parametric adjustments

Edits to the MATLAB code in order to 1) allow for missing values in data to be harmonized (PNT), and 2) substantial speed optimizations to the non-parametric adjustments procedure in inteprior.m and parallelization (2-5x speedup without parallelization, with parallelization can be up to 40-50x with 16 workers) (JCW).  Also minor optimizations in combat.m (JCW).

Added changes to readme to reflect that MATLAB code can now handle missing values.


kws_streaming demo training code seems not working well @rybakov

@rybakov
I need some help here while running the 01_train.ipynb code, the dataset I used is from Speech Commands V2. I did not change any of your code.  While running this training part using ds_tc_resnet, the training log looks like this. Could you please help me check what is wrong on this?  I think it should keep increasing close to >95% as shown in your paper. What parameters should I change to reach a performance similar to your paper? Thanks!

These colabs are used as fast playground, so most parameters are for toy example: e.g. FLAGS.batch_size=1. Please feel free to set it FLAGS.batch_size=100. I would suggest to use command line from line

With batch_size=100 training will report reasonable accuracy in the log you shared

All experiments reported in the paper are described in kws_experiments_paper_12_labels. All colabs in this repo are toy examples.

Thanks @rybakov!


Add support for Youtube and Vimeo to Video block

Fix #32
change: all videos are now centered and have a max-width.
Test URLs:

Before: https://main--helix-block-collection--adobe.hlx.page/block-collection/video
After: https://video--helix-block-collection--adobe.hlx.page/block-collection/video

@fkakatie do you think this is ready to merge?


Changes made to colordetection.py

Made some changes to colordetection.py and added a new file color_params.py used for parameter settings

Hi, thanks for your time. Really appreciate it. I'd love to get some help to improve color detection much more. Your version is quite an improvement already, but there are still colors it guessed wrong, see below:

The orange is detected as red
Green is detected as white

Hi, thanks for your time. Really appreciate it. I'd love to get some help to improve color detection much more. Your version is quite an improvement already, but there are still colors it guessed wrong, see below:

The orange is detected as red
Green is detected as white

Hey I've been following notifications from this repo. I used to do color detection like this too when I was starting out until I looked into creating an algorithm to do it for me that helped me achieve almost perfect accuracy every time.
I will explain this in brief and send you a couple links too.
The way my color sorting and detection algorithm works is that I use the centers as the "core" colors.

I then create 6 groups, one for each center.
I then take all the colors on the cube and compare them against my "core" colors.
I find the euclidean distance between the current core color and the "nth" color and store the distance.
I store the lowest 8 euclidean numbers closest to the current "core" color and define them as that core color.
I remove these 9 colors from the pool of 54 and repeat the process until there are no more colors left to pick from.

Tips: I have all this code available in my solver linked in my repo
Code I use to find centers:
https://github.com/HaginCodes/3x3x3-Rubiks-Cube-Solver/blob/3b95db9094e48e082b78a737874ff50f2d9ca316/src/AnalyzeFrame.java#L260
Code for finding the rest of the stickers:
https://github.com/HaginCodes/3x3x3-Rubiks-Cube-Solver/blob/3b95db9094e48e082b78a737874ff50f2d9ca316/src/AnalyzeFrame.java#L309
(Note: this is called k-means because it's the algorithm I used to sort the colors. I had to write it by hand because I was using Java but I'm sure you can find a python library that has it and you can use it to do the exact same thing
Finding the distance between colors, when I was working on my color detection algorithm, initially, I was using HSV too. However, I switched from it because it wasn't reliable enough colorspace when it came to certain colors like red and orange and other close colors depending on the ambient lighting. Options you can look into are HSL, YCbCr, and LaB. I personally used LaB and I found it worked best for me and was reliable in all lighting conditions.
For calculating color distance there's two options you can choose but this depends on the color space you use. When I was using LaB, I had two options. Euclidean distance (very quick and arithmetic calculation light and quick) and the other was CIEDE2000 https://en.wikipedia.org/wiki/Color_difference#CIEDE2000. They both work in similar ways, and "apparently" CIEDE2000 is more accurate but I didn't notice any difference when using one or the other after very numerous tests.
If you have any further questions just let me know and good luck on your color detection algorithm, this was definitely the most annoying and tedious part of the whole project but once you get it working reliably it's so rewarding. Best of luck!

Hey I've been following notifications from this repo. I used to do color detection like this too when I was starting out until I looked into creating an algorithm to do it for me that helped me achieve almost perfect accuracy every time.
I will explain this in brief and send you a couple links too.
The way my color sorting and detection algorithm works is that I use the centers as the "core" colors.

I then create 6 groups, one for each center.
I then take all the colors on the cube and compare them against my "core" colors.
I find the euclidean distance between the current core color and the "nth" color and store the distance.
I store the lowest 8 euclidean numbers closest to the current "core" color and define them as that core color.
I remove these 9 colors from the pool of 54 and repeat the process until there are no more colors left to pick from.

Tips: I have all this code available in my solver linked in my repo
Code I use to find centers:
https://github.com/HaginCodes/3x3x3-Rubiks-Cube-Solver/blob/3b95db9094e48e082b78a737874ff50f2d9ca316/src/AnalyzeFrame.java#L260
Code for finding the rest of the stickers:
https://github.com/HaginCodes/3x3x3-Rubiks-Cube-Solver/blob/3b95db9094e48e082b78a737874ff50f2d9ca316/src/AnalyzeFrame.java#L309
(Note: this is called k-means because it's the algorithm I used to sort the colors. I had to write it by hand because I was using Java but I'm sure you can find a python library that has it and you can use it to do the exact same thing
Finding the distance between colors, when I was working on my color detection algorithm, initially, I was using HSV too. However, I switched from it because it wasn't reliable enough colorspace when it came to certain colors like red and orange and other close colors depending on the ambient lighting. Options you can look into are HSL, YCbCr, and LaB. I personally used LaB and I found it worked best for me and was reliable in all lighting conditions.
For calculating color distance there's two options you can choose but this depends on the color space you use. When I was using LaB, I had two options. Euclidean distance (very quick and arithmetic calculation light and quick) and the other was CIEDE2000 https://en.wikipedia.org/wiki/Color_difference#CIEDE2000. They both work in similar ways, and "apparently" CIEDE2000 is more accurate but I didn't notice any difference when using one or the other after very numerous tests.
If you have any further questions just let me know and good luck on your color detection algorithm, this was definitely the most annoying and tedious part of the whole project but once you get it working reliably it's so rewarding. Best of luck!

@HaginCodes Many thanks for the answer! I will definitely read your implementation and try to do it myself. Getting quite accurate results every time is something I'm really trying to achieve. This project started out 5 years ago just because I was a programmer and I liked solving cubes, but I've always wanted to optimize this, but never knew how you. Thanks a lot man! If I have any questions, I'll ask you! ;)

@HaginCodes Many thanks for the answer! I will definitely read your implementation and try to do it myself. Getting quite accurate results every time is something I'm really trying to achieve. This project started out 5 years ago just because I was a programmer and I liked solving cubes, but I've always wanted to optimize this, but never knew how you. Thanks a lot man! If I have any questions, I'll ask you! ;)

@Heydok I will first use another version based on what @HaginCodes mentioned. If his version is more accurate using LaB then I'll close this issue.

@Heydok I will first use another version based on what @HaginCodes mentioned. If his version is more accurate using LaB then I'll close this issue.

This PR has no use anymore, since I've finished the rewrite to use the CIEDE2000 algorithm.
@HaginCodes Many thanks for the suggestion. I didn't use the kmeans since that wasn't needed at all.

This PR has no use anymore, since I've finished the rewrite to use the CIEDE2000 algorithm.
@HaginCodes Many thanks for the suggestion. I didn't use the kmeans since that wasn't needed at all.


Error creating pool on Uniswap

The inability to select two tokens when adding liquidity to a pool on Uniswap testing the Scroll Alpha Testnet results in the creation of incomplete pools that cannot be used effectively.

@Turupawn

Hey @denominatedmhd please move this issue to the Scroll V3 repo:
https://github.com/scroll-tech/uniswap-v3-interface
I will close this and help you there
Cheers!


Update ci.yml

Codecov Report

Merging #37 (afc4c03) into main (2232db5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   96.35%   96.35%
=======================================
  Files          13       13
  Lines         411      411
=======================================
  Hits          396      396
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2232db5...afc4c03. Read the comment docs.

Codecov Report

Merging #37 (afc4c03) into main (2232db5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   96.35%   96.35%
=======================================
  Files          13       13
  Lines         411      411
=======================================
  Hits          396      396
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2232db5...afc4c03. Read the comment docs.


A bug was found and the scroll bar was blocked

###A bug was found and the scroll bar was blocked
https://gyazo.com/1b0773543a04812431b2551d458a0c6f

@honest666 can you tell us how to reproduce this or provide an example project?

In IGListKit/Examples/Examples-iOS/IGListKitExamples/SectionControllers/FeedItemSectionController , scrollbars are occluded by headView

Oh weird, yup I can repro this. Strangely if I switch the layout in that demo to use ours, it works just fine. Hmm.

That's an ios original bug

Going to close as this seems like a UIKit issue
Sent with GitHawk


Page subheadings do not have code formatting applied

It would be a nice-to-have feature to have any code snippets formatted in the subheadings. An example here:
https://nuxt.com/docs/api/advanced/import-meta

I think we should avoid adding code-formatting for the description as much as possible since this description is also set in the <meta> description @DamianGlowala

Wouldn't it only modify the visual layer and leave the meta description untouched? (I might be unaware of how these two can possibly be related.)

It is possible but so far we will have an hydration error by using the MDC component will create a <p> inside another <p>.
I think this is fine for now for this formatting.

Alright, let's leave it as is! :) thanks for explaining


Cannot assign a device for operation using Google Cloud TPU

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
The codebase can be found at https://github.com/google/compare_gan.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu on Google Cloud.
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
Not applicable.
TensorFlow installed from (source or binary):
Binary
TensorFlow version (use command below):
TF v1.15
Python version:
3.8
Bazel version (if compiling from source):
Not applicable.
GCC/Compiler version (if compiling from source):
Not applicable.
CUDA/cuDNN version:
Not applicable.
GPU model and memory:
TPU v3-8

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
v1.15.0-rc3-22-g590d6ee 1.15.0
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
The original issue can be found at here. I used the exact same software setup as stated in the CompareGAN repo, and ran it on V3-8 TPU with 4 vCPU VM.
I had the following error:

tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation input_pipeline_task0/TensorSliceDataset: node input_pipeline_task0/TensorSliceDataset (defined at /usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py:1748)  was explicitly assigned to /job:worker/task:0/device:CPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0 ]. Make sure the device specification refers to a valid device.

It looks to me that this error is caused by different naming conventions from older TF. The original repo uses TensorFlow 1.15, while the firmware of TPU/VM might have been updated over time, thus, it may not properly recognize the device name. I tried a workaround as suggested here (https://github.com/google/compare_gan/issues/53), but using a GPU instance can be very expensive and it goes against the reason of using TPUs.
Therefore, I wonder if there is a way to rename the device from TensorFlow, or manually assign the device for input_pipeline handling?
Describe the expected behavior
I expect TF to recognize the device name properly.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
You can use the following command if you have a TPU:
python3 compare_gan/main.py --use_tpu=True  --gin_config=/home/xxx/compare_gan/example_configs/resnet_cifar10.gin
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
 File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/api_utils.py", line 52, in disallow_positional_args_dec
    return fn(*args, **kwargs)
  File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/dataset_builder.py", line 236, in download_and_prepare
    self.info.compute_dynamic_properties()
  File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/dataset_info.py", line 245, in compute_dynamic_properties
    self._compute_dynamic_properties(self._builder)
  File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/dataset_info.py", line 258, in _compute_dynamic_properties
    builder, split_name)
  File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/dataset_info.py", line 447, in get_dataset_feature_statistics
    for example in tqdm.tqdm(np_dataset, unit=" examples"):
  File "/usr/local/lib/python3.5/dist-packages/tqdm/std.py", line 1107, in __iter__
    for obj in iterable:
  File "/home/xxx/.local/lib/python3.5/site-packages/tensorflow_datasets/core/dataset_utils.py", line 98, in _graph_dataset_iterator
    yield sess.run(ds_item)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 956, in run
    run_metadata_ptr)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1180, in _run
    feed_dict_tensor, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1359, in _do_run
    run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/client/session.py", line 1384, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation input_pipeline_task0/TensorSliceDataset: node input_pipeline_task0/TensorSliceDataset (defined at /usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/ops.py:1748)  was explicitly assigned to /job:worker/task:0/device:CPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0 ]. Make sure the device specification refers to a valid device.
         [[input_pipeline_task0/TensorSliceDataset]]

@StevenShi-23,
TensorFlow 1.x is not actively supported. Could you please update TensorFlow to the latest stable version v2.4.1 and check if you are facing the same issue. Thanks!

Hi @amahendrakar , thanks for the prompt reply!
I've tried to port the original repo to TF v2, but it requires much more changes than fixing this issue, and some code explicitly depends on TF v1. Therefore, I resort to finding a fix from TF v1. In my humble option, It should be easy, as we only need to mask the device name, but I don't know where to start. May you advise please?
Many thanks in advance!

A quick update: I ported the code to TF v2.4.1, but the same error occurs:
Traceback (most recent call last):
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1375, in _do_call
    return fn(*args)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1358, in _run_fn
    self._extend_graph()
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1398, in _extend_graph
    tf_session.ExtendSession(self._session)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation input_pipeline_task0/TensorSliceDataset: {{node input_pipeline_task0/TensorSliceDataset}} was explicitly assigned to /job:worker/task:0/device:CPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0 ]. Make sure the device specification refers to a valid device.
         [[input_pipeline_task0/TensorSliceDataset]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "compare_gan/main.py", line 135, in <module>
    app.run(main)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/absl/app.py", line 300, in run
    _run_main(main, args)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/absl/app.py", line 251, in _run_main
    sys.exit(main(argv))
  File "compare_gan/main.py", line 129, in main
    eval_every_steps=FLAGS.eval_every_steps)
  File "/home/xxx/xxx/compare_gan/runner_lib.py", line 337, in run_with_schedule
    hooks=train_hooks)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 3130, in train
    rendezvous.raise_errors()
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/error_handling.py", line 150, in raise_errors
    six.reraise(typ, value, traceback)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/six.py", line 703, in reraise
    raise value
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 3125, in train
    saving_listeners=saving_listeners)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/estimator.py", line 349, in train
    loss = self._train_model(input_fn, hooks, saving_listeners)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/estimator.py", line 1175, in _train_model
    return self._train_model_default(input_fn, hooks, saving_listeners)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/estimator.py", line 1204, in _train_model_default
    self.config)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 2962, in _call_model_fn
    config)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/estimator.py", line 1163, in _call_model_fn
    model_fn_results = self._model_fn(features=features, **kwargs)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 3242, in _model_fn
    input_holders.generate_infeed_enqueue_ops_and_dequeue_fn())
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 1484, in generate_infeed_enqueue_ops_and_dequeue_fn
    self._invoke_input_fn_and_record_structure())
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 1591, in _invoke_input_fn_and_record_structure
    host_device, host_id))
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 927, in generate_per_host_enqueue_ops_fn_for_host
    inputs = _Inputs.from_input_fn(input_fn(user_context))
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_estimator/python/estimator/tpu/tpu_estimator.py", line 3096, in _input_fn
    return input_fn(**kwargs)
  File "/home/xxx/xxx/compare_gan/gans/modular_gan.py", line 426, in input_fn
    preprocess_fn=self._preprocess_fn)
  File "/home/xxx/xxx/compare_gan/datasets.py", line 334, in input_fn
    return self.train_input_fn(params=params, preprocess_fn=preprocess_fn)
  File "/home/xxx/xxx/compare_gan/datasets.py", line 284, in train_input_fn
    ds = self._load_dataset(split=self._train_split)
  File "/home/xxx/xxx/compare_gan/datasets.py", line 245, in _load_dataset
    as_dataset_kwargs={"shuffle_files": False})
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/api_utils.py", line 52, in disallow_positional_args_dec
    return fn(*args, **kwargs)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/registered.py", line 253, in load
    dbuilder.download_and_prepare(**download_and_prepare_kwargs)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/api_utils.py", line 52, in disallow_positional_args_dec
    return fn(*args, **kwargs)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_builder.py", line 236, in download_and_prepare
    self.info.compute_dynamic_properties()
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_info.py", line 245, in compute_dynamic_properties
    self._compute_dynamic_properties(self._builder)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_info.py", line 258, in _compute_dynamic_properties
    builder, split_name)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_info.py", line 447, in get_dataset_feature_statistics
    for example in tqdm.tqdm(np_dataset, unit=" examples"):
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tqdm/std.py", line 1170, in __iter__
    for obj in iterable:
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_utils.py", line 98, in _graph_dataset_iterator
    yield sess.run(ds_item)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 968, in run
    run_metadata_ptr)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1191, in _run
    feed_dict_tensor, options, run_metadata)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1369, in _do_run
    run_metadata)
  File "/home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1394, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Cannot assign a device for operation input_pipeline_task0/TensorSliceDataset: node input_pipeline_task0/TensorSliceDataset (defined at /home/xxx/miniconda3/envs/tf2.4/lib/python3.7/site-packages/tensorflow_datasets/core/dataset_utils.py:76)  was explicitly assigned to /job:worker/task:0/device:CPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0 ]. Make sure the device specification refers to a valid device.
         [[input_pipeline_task0/TensorSliceDataset]]

I ported the code to TF v2.4.1, but the same error occurs:

@StevenShi-23,
Could you please provide the ported code, so that we can reproduce the issue on our end. Thanks!


verify that the traefik configuration is reload successful

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
when  traefik reload configuration,how can i kown it reload successful

Hello @,
Thanks for your interest in Traefik!
It can be found there : https://doc.traefik.io/traefik/observability/metrics/overview/#last-configuration-reload-success


Canasta CLI now unusable on Ubuntu due to "docker compose" requirement?

PR #78, if I understand it correctly, made the presence of "docker compose" (as opposed to "docker-compose") required to run the Canasta CLI. Which in theory is correct behavior, since "docker-compose" is the "v1", and now deprecated, while "docker compose" is the "v2". So that's good - but the problem is that, on Ubuntu, it seems like only "docker-compose" is installable. Which, if true, is a big problem.
The official Docker install guide for Ubuntu (https://docs.docker.com/engine/install/ubuntu/) says to call this:
 sudo apt-get update
 sudo apt-get install docker-compose-plugin

But when I do that (on a server running Ubuntu 20.0.4), I get the following message:
E: Unable to locate package docker-compose-plugin

Pretty shocking that the official instructions don't work. As might be expected, other people have noticed this problem; here is one example of someone giving alternate instructions. However, the instructions there don't work for me either (and they're more complicated).
This seems quite bad - and perhaps the only solution, for now, is to get the Canasta CLI to fully support both "docker-compose" and "docker compose".

Hi @yaronkoren,
Have you added the apt repository for Docker as instructed in https://docs.docker.com/engine/install/ubuntu/#install-using-the-repository? If so, apt-get should be able to locate them, as the docker-compose-plugin is available at https://download.docker.com/linux/ubuntu/dists/focal/pool/stable/amd64/.

@PiyushRaj927 - maybe that's the issue; I was trying to install the CLI on a server that already had Docker installed. Should Docker be un-installed, then installed the right way? And if so, maybe the CLI documentation should explain this?

https://docs.docker.com/engine/install/ubuntu/#delete-old-versions indicates that builds offered by distros are unofficial, so I think it is best to uninstall the packages and install them from the official docker apt repo, to prevent version conflict when upgrading.

This issue, when fixed, should resolve #21, #59, #35

I brought up these related issues at the last meeting and will now work to fix them.

For Desktop users (Windows, Mac and Linux), I believe Canasta should drop support for the v1 binary docker-compose; emphasizing that the way to prepare your system for Canasta so that it has all prerequisites and works properly is to install Docker Desktop (which will have the correct and latest docker compose).
For System Administrators, when existing systems may still rely on old tools or software that uses the deprecated docker-compose, we could suggest the compatibility shim Compose Switch. Although, AFAIK, it is only good for Ubuntu and CentOS


Module build failed (from ./node_modules/less-loader/dist/cjs.js):

I installed bootstrap less port into my Vue project. I updated less to 3.9.0 and less-loader to 3.9.0 and 5.0.0 as well.
Do you have any idea what's going on?
 error  in ./node_modules/bootstrap-less-port/less/bootstrap.less

Module build failed (from ./node_modules/less-loader/dist/cjs.js):

//}
each(@form-validation-states, #(@data, @state) {
^
Error evaluating function `each`: Operation on an invalid type
      in /Users/mihai/code/Shaw-PhiladelphiaCommercial/pc-vue/node_modules/bootstrap-less-port/less/_forms.less (line 247, column 0)

 @ ./node_modules/bootstrap-less-port/less/bootstrap.less 4:14-190 14:3-18:5 15:22-198
 @ ./src/main.js
 @ multi (webpack)-dev-server/client?http://<IP_ADDRESS>:8080/sockjs-node (webpack)/hot/dev-server.js ./src/main.js

When I move bootstrap-less-port from version 2.2.1 to 1.0.0 it does compile properly.
I do use less 3.9.0

I'm also seeing this in my angular 8 project with version 2.2.1.

I think I've narrowed it down to this line. https://github.com/seanCodes/bootstrap-less-port/blob/master/less/mixins/_forms.less#L96 I'm not sure what is supposed to be going on there so I don't know how you can take a property of "center right " and divide it by " " but I'm really not a less expert either.

Same here for my react app

Unfortunately for me "parens-division" does not fix the issue, or am I doing it wrong?

"less": "^3.10.0",
"less-loader": "^5.0.0",

{     loader: 'less-loader',         options: {             parensDivision: true,         } }

ok, got it :)
 loader: 'less-loader', options: {     math: {         'parens-division': true,     } }

@seanCodes Yes, that works. Thx a bunch!

For those following along at home, or find this via google. I have a fork that compiles with angular until either angular allows passing flags or less changes their default flags. Not likely to be well maintained, but it might save someone some time. https://github.com/cthrax/bootstrap-less-port

@cthrax Were minor changes required to make it work? I’d be happy to merge if you submit a PR

@seanCodes pretty minor, pull-request linked.


Allow to cancel requests

Add mechanism to cancel a request. Using the abort signal from the tsp-typescript-client and the listener in the Trace Compass server

@bhufmann was this fixed via #259?

@bhufmann was this fixed via #259?

No, #259 supports cancellation of the open procedure, i.e. scanning selected directory for CTF traces, posting trace and experiment to server and open the timeline container.
This issue tracker (#55) is to support cancellation of individual TSP REST calls and related handling of cancellation.


Issue Credential protocol cannot handle unknown credential formats

The issue credential V20CredFormat does not allow unknown format identifiers to be present. As the format is used in all the credential exchange messages this means message validation will fail if we receive an unrecognized format.
The way I currently handle it is that we only process the formats that we recognize. If that means no formats are processed, we throw an error. This allows a flow where we receive two formats, one of which we recognize and can respond to.
I already modified the cred v2 manager in our branch to check we at least recognize a single format. So I think we should only loosen up the higher level validation a bit such as:

Update V20CredFormatSchema to allow any string identifier
Update the validate_fields methods in the cred ex messages to check if the format is found before calling validate_fields
Maybe others??

BTW -- This is the same for present proof

@sklump Could you maybe pick this up? 🙂

I can look into it starting tomorrow


1.40.0 has rendering lag and flickers when minimize/maximize window with custom title

VSCode Version: 1.40.0
OS Version: Windows 10 1903

Steps to Reproduce:

Open VSCode 1.40.0 and maximize its window.
Click VSCode icon on the task bar to minimize the window.
Click VSCode icon on the task bar to restore the window.

Expected result
Window restored instantly without flickering.
Actual result
Window flickers and there's a small lag in rendering status bar. Sometimes the window is restored empty for 2-3 seconds. Look at screencast: vscode-1.40-rendering-lag.mp4.zip.
Does this issue occur when all extensions are disabled?: Yes
It's a regression in 1.40.0. In 1.39.2 all is OK.

I'm having the exact same issue. It could happen with any file and it seems like it's not affected by extensions or settings.

Probably the same reason as https://github.com/microsoft/vscode/issues/84342

I experience the same behavior from vscode, this issue happen specifically when 'minimizing/maximizing' not when scrolling through alt+tab

Related with https://github.com/microsoft/vscode/issues/81102.
It's a known problem with Electron: https://github.com/electron/electron/issues/19934

@halega does it reproduce if you configure "window.titleBarStyle": "native" ?

@halega does it reproduce if you configure "window.titleBarStyle": "native" ?

Using that setting fixes it.

Same issue here, can confirm the workaround also seems to speed things up so must be related to custom title bar style

@halega does it reproduce if you configure "window.titleBarStyle": "native" ?

Yes, it helps: no more lag in restoring window.

The rendering lag is a first issue, but the difference in performance when enabling window.titleBarStyle is really big, maybe there is something more going on with this? It seems like the performance increases overall.

This should be fixed in our insiders build https://code.visualstudio.com/insiders/, can you please verify ?

@deepak1556 did we update Electron already?

@bpasero yeah we updated it in master a while back so insiders should have it.

still seeing some issue with 6.1.4

Can confirm issue is still present, working on a fix.

Electron PR https://github.com/electron/electron/pull/21164

Fixed with https://github.com/microsoft/vscode/pull/85266


Channel Packer improvements

Closes #308
Closes #467
Mipmap and Quality options
Luminance as Height
Invert Smoothness
Image Resizing
DDS file type support
normal alignment fix
Edit: now includes:
Inverted Depth
width and height display
selectable source channels for height / roughness
Drag n drop, including from OS
Edit2:
Fixed window management with defered dialogue calls and always ontop
some minor formatting
some code restructing
Luminance now a button that loads the generated height texture
Switched to Refcounted instead of Object as script base class.

added width and height to each texture.
when resize is enabled, textures provided for packing no longer need to be the same size.

This is ready for review!

Rebased, all reviewed points addressed.
window now closes on ESC.
The error im looking into a bit more.

Great work, thank you!


pylint: ingore zmq Context abstract-class-instantiated warnings

LGTM

ingore -> ignore

@stefanberger fixed.


only load layers when their opacity is > 0

Will likely be implemented as allowing the user to enable / disable a layer w/out removing it permanently

we don't need this anymore, now that you implemented the add channel thing, right?

Well, lets say you load 15 layers and set 10 opacities to 0. NDV is still going to make 15 web requests x <<number of tiles / layer>>. Even though you only want to look at 5 layers. So, modifying leaflet to only load layers with opacity > 0 might not be a bad idea. The trick is getting leaflet to reload layers if the opacity is set above 0. I think it's worth investigating further as part of the general goal of speeding things up for multi-channel datasets.

ok
On Tue, Jan 26, 2016 at 4:45 PM, Alex Baden<EMAIL_ADDRESS>wrote:

Well, lets say you load 15 layers and set 10 opacities to 0. NDV is still
going to make 15 web requests x <>. Even though you only want to look at 5
layers. So, modifying leaflet to only load layers with opacity > 0 might
not be a bad idea. The trick is getting leaflet to reload layers if the
opacity is set above 0. I think it's worth investigating further as part of
the general goal of speeding things up for multi-channel datasets.
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/NeuroDataViz/issues/6#issuecomment-175246573
.

--
the glass is all full:  half water, half air.
neurodata.io


Where is the best place to clean/refresh resources after queued jobs are handled?

Running queue:work command, I want to be sure that all the resources are clean and healthy before handling the next job. For example, I would like to rollback or reconnect the DB connection if the previous job was not successful in closing the transaction.
I was thinking to listen to Events\JobProcessing event. However, this event is also fired when pushing a job to a 'sync' queue, and I don't want to reset the DB connection every time I push a job to a 'sync' queue.

It sounds like you want to run the queue without the daemon mode. Running queue:work --once will only execute one job and then quit; this will close down all resources and database connections (as php scripts  do at the end of execution). Running queue:listen will call queue:work --once repeatedly.

I am already aware of that option. However, queue:listen is not efficient enough for my use-case, because of the fork overhead, plus the unnecessary overhead of resetting all the remote connections, when there is no need to.


Download / Delete actions missing

I noticed that the download / delete actions shown here:
https://v2.filamentphp.com/plugins/spatie-backup
Are now missing in the latest version:
https://github.com/shuvroroy/filament-spatie-laravel-backup
Allowing download would be very useful for me. Is there a way to enable this feature?
Thanks!

I second this. Without a download feature the plugin is sadly rather useless. (for me)

check this at src/Components/BackupDestinationListRecords.php
im not sure about the specific permission required, but it would be better if it is removeable or customizable

@stuartcusackie  @Dieter91
If you are using a package such as filament shield, you should be able to generate the policies to allow assigning the necessary permissions. If not, you can create custom gate and define who can access.

In boot method of your AppServiceProvider, add the following

in your .env,

BACKUP_MANAGERS=email<EMAIL_ADDRESS>

same here
when i check in code i found this    visible(auth()->user()->can('download-backup'))
when i commit them it worked
How to make without policy or gate !


Scaling resources

How much additional would it cost to add an extra node just on Thursdays between 5-8 PM? We're having resource issues, especially between:

Kelly, who teaches 3 sections of ~35 from 3-6 PM
Logan, who teaches 3 sections of ~45 from 5-8 PM.

I think that we're maxing out the cluster between 5-7 PM.

@dlsun Not substantially more.. I'll adjust things this evening.


Support for PHP 7.2 in 3.x branch

Since INTL_IDNA_VARIANT_2003 variant has been deprecated in PHP 7.2, using Payum which uses League/Uri which uses this library is impossible on that version (I've listed the details here: https://github.com/Sylius/Sylius/pull/8771#issuecomment-335422273).
The thing I'd like to introduce in 3.0.1 release is to change idn_to_ascii and idn_to_utf8 function calls with something like:
Either:
@idn_to_ascii($part)

Or:
if (defined('INTL_IDNA_VARIANT_UTS46')) {
  $part = idn_to_ascii($part, 0, INTL_IDNA_VARIANT_UTS46);
} else {
  $part = idn_to_ascii($part);
}

Or:
if (version_compare(PHP_VERSION, '7.2.0', '>=')) {
  $part = @idn_to_ascii($part);
} else {
  $part = idn_to_ascii($part);
}

All I need to fix this is a branch based on 3.0.0 version tag available, the choice of the suitable solution, then merging a PR and releasing 3.0.1. It really would help anyone using Payum with the most recent PHP version and I'll be grateful for help :)

I don't see why we can't backport 7.2 support. @nyamsprod Thoughts?

I could do it  but v4 code is really old 👎 I'll give it a try .. I need to look into it we will label this as a security patch :) also it means upping to v4 for domain parser too .

Upping to v4? Adding that conditional will cause a BC break in php-domain-parser?

Looks like thephpleague/uri can use 4.0.3-alpha without any other changes in the patch release so changes here are not really needed then :)

Not further needed since thephpleague/uri#105 was solved.


Getting error from running in windows container versions.

isql -U sa -P myPassword -S MYSYBASE
CT-LIBRARY error:
ct_connect(): network packet layer: internal net library error: Net-Lib protocol driver call to connect two endpoints failed
ps -aef
UID        PID  PPID  C STIME TTY          TIME CMD
root         1     0  0 18:58 ?        00:00:00 /bin/sh /sybase-entrypoint.sh
root         7     1  0 18:58 ?        00:00:00 /bin/sh /opt/sybase/ASE-16_0/install/RUN_MYSYBASE
root         8     7  1 18:58 ?        00:00:08 /opt/sybase/ASE-16_0/bin/dataserver -d/opt/sybase/data/master
root        10     0  0 18:59 pts/0    00:00:00 /bin/bash
root        53    10  0 19:07 pts/0    00:00:00 ps -aef

Same here.

same here


Add support for bent normals

Bent normals can be enabled via the bentNormal property of a material. When a bent normal is specified, it is used as the sampling direction for diffuse indirect lighting.
When used with specularAmbientOcclusion is improves the quality of specular AO. The new specular AO is computed using an intersection of spherical caps which is more expensive than the regular specular AO. It would be cheaper to bake the intersection computations in a LUT instead of doing it analytically but we need to limit the number of samplers used by our shaders. This is a high quality feature that should be limited to a few assets.

Amazing before / after shots.


Update SHAs for r11.1.6

What version (commit) do you encounter this issue on?
r11.1.6
What type of issue is this (bug, feature, documentation, regression)?
Minor release
What is the expected behavior?
N/A
What is actually happening?
N/A
How can we reproduce this issue?
N/A
How can we verify your issue is addressed?
N/A
If this is a large issue, what can be done immediately to alleviate the issue while working on a longer-term solution?
N/A
What is your evaluation on the importance of this issue, and why?
High
What branches / milestones do you believe this issue should target?

[ ] kilo

this is waiting on OSA 11.2.12 to be tagged.


feat: session setup page

Description
We need a page after the landing page and before the session page where the user sets up the session.
This is the page where the user can select a prompt from a list, or write one themselves.
Landing Page (/) => Sesssion Setup Page (/setup) => SessionPage (/session/some_session_id_from_firestore)

Closed with #34


FIX: getBlocks optional params

fix #3

Nice fix @jaonoctus !
Just change the "Line Break" of the file for CRLF and commit it again! 👍

I'll create a new PR


Idea for extension: wrap

I just made an extension that makes an invisible wrapper around any block. Contents are parsed as usual. It wraps any other text in a div so you have more possibilities with CSS and JS.
For example, in our CMS I want our writers to be able to add a setlist when writing a concert review:
     ...setlist
     Intro
     Song 1
     Song 2
     ...

I know this could have been done using
     ```setlist
     Intro
     Song 1
     Song 2
     ```

but the following could not. I wanted our writers to be able to add an image gallery.
     ...gallery
     * ![](some-url)
     * ![](some-url)
     * ![](some-url)
     ...

I could not have a list of images inside en fenced code block since the images would not be parsed. And having images in a list is not enough, since a list could be used someplace else as well.
So I needed an invisible wrapper with a class. Now I can have CSS and JS targeting the .gallery ul.
Using a wrapper with a class I can save some time finding extra codes and extensions. That way I keep ParsedownExtra smaller and put more control into CSS and JS.
Maybe this is interesting in some way for ParsedownExtra. Most code was copied from the blockQuote and blockQuoteContinues methods.
    public function __construct()
    {
        // add a new block type: tripe period plus class name
        $this->BlockTypes['.'] = array('Wrap');
    }

    protected function blockWrap($Line)
    {
        // check for the triple period (or more) plus class name
        if (preg_match('/^\.{3,}[ ]?(.*)/', $Line['text'], $matches)) {
            $Block = array(
                'element' => array(
                    'name' => 'div',
                    'handler' => 'lines',
                    'attributes' => ['class' => $matches[1]],
                ),
            );

            return $Block;
        }
    }

    protected function blockWrapContinue($Line, array $Block)
    {
        if ($Line['text'][0] === '.' and preg_match('/^\.{3,}[ ]?(.*)/', $Line['text'], $matches)) {
            if (isset($Block['interrupted'])) {
                $Block['element']['text'] []= '';
                unset($Block['interrupted']);
            }

            $Block['element']['text'] []= $matches[1];

            return $Block;
        }

        if ( ! isset($Block['interrupted'])) {
            $Block['element']['text'] []= $Line['text'];

            return $Block;
        }
    }

Just realized that this is not a fenced block. The block ends when there is a blank line. Hm, still having a problem with the wrapper, then. I'd prefer a wrapper being fenced but with the contents being parsed.

Similar was suggested in michelf/php-markdown#191


Target to be removed

"geographic subpopulation" in the target column, all JH records.
Example IDs:
JH_HIT_141929
JH_HIT_141947
JH_HIT_141948

"entire population" in the target column, all JH records.
Example IDs
JH_HIT_141938
JH_HIT_141930

"General"
example id: OXCGRT_188251

Looks like some of these are still in place from previous weeks. Should they be removed with a find & replace in the master file?

These have now been removed from the newest data and previous weeks.


How to use AR?

If I want to use Anticipation Reward(AR), should I set reward_type = map_accuracy ?
But I found it wasn't set in
https://github.com/facebookresearch/OccupancyAnticipation/blob/aea6a2c0d9/configs/exploration/gibson_train_w_ar.yaml

@GuoPingPan  - It is set in the baseline config, not the task config.
https://github.com/facebookresearch/OccupancyAnticipation/blob/aea6a2c0d9701336c01c9c85f5c3b8565d7c52ba/configs/model_configs/occant_rgbd/ppo_exploration.yaml#L24-L25

Thanks you so much! But I got another question which have the multi-gpu trainning failed. Have you ever meet the error:
Process ForkServerProcess-74:
Traceback (most recent call last):
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/supervised/map_update.py", line 325, in map_update_worker
    losses = map_update_fn(ps_args)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/supervised/map_update.py", line 219, in map_update_fn
    mapper_outputs = mapper(mapper_inputs, method_name="predict_deltas")
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 168, in forward
    outputs = self.parallel_apply(replicas, inputs, kwargs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/parallel/data_parallel.py", line 178, in parallel_apply
    return parallel_apply(replicas, inputs, kwargs, self.device_ids[:len(replicas)])
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 86, in parallel_apply
    output.reraise()
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/_utils.py", line 457, in reraise
    raise exception
RuntimeError: Caught RuntimeError in replica 0 on device 1.
Original Traceback (most recent call last):
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/parallel/parallel_apply.py", line 61, in _worker
    output = module(*input, **kwargs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/rl/policy.py", line 633, in forward
    outputs = self.predict_deltas(*args, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/rl/policy.py", line 316, in predict_deltas
    pu_outputs = self.projection_unit(pu_inputs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/rl/policy_utils.py", line 49, in forward
    x_full = self.main(x)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/occant.py", line 453, in forward
    return self.main(x)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/occant.py", line 51, in forward
    gp_outputs = self._do_gp_anticipation(x)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/occant.py", line 278, in _do_gp_anticipation
    x_enc = self.gp_depth_proj_encoder(
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/unet.py", line 107, in forward
    x1 = self.inc(x)  # (bs, nsf, ..., ...)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/unet.py", line 41, in forward
    x = self.conv(x)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/workspace/OccAnt/occant_baselines/models/unet.py", line 31, in forward
    x = self.conv(x)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/container.py", line 141, in forward
    input = module(input)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 447, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "/home/yzc1/miniconda3/envs/occ/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 443, in _conv_forward
    return F.conv2d(input, weight, bias, self.stride,
RuntimeError: cuDNN error: CUDNN_STATUS_INTERNAL_ERROR

And I only can use one gpu and ensure that they are the same between mapper_copy and MapLargeRolloutStorageMP, as bellow
if mapper_cfg.use_data_parallel and len(mapper_cfg.gpu_ids) > 0:
    self.mapper_copy.to(self.mapper.config.gpu_ids[0]) # cuda:1
    self.mapper_copy = nn.DataParallel(
        self.mapper_copy,
        device_ids=self.mapper.config.gpu_ids, # device = 1, 2, 3, 4, 5, 6, 7
        output_device=self.mapper.config.gpu_ids[0],
        # device_ids=[self.mapper.config.gpu_ids[0]]
    )

...

if ans_cfg.MAPPER.use_data_parallel and len(ans_cfg.MAPPER.gpu_ids) > 0:
    mapper_device = ans_cfg.MAPPER.gpu_ids[0]
    # mapper_device = torch.device("cuda:1")
mapper_rollouts = MapLargeRolloutStorageMP(
    ans_cfg.MAPPER.replay_size,
    mapper_observation_space,
    mapper_device,
    mapper_manager,
)

But I found that the MapLargeRolloutStorageMP, which will easily cause OOM Error.
The most importance thing is how to use multi-gpu or it will be very slow for training


Kernel 4.14.x EOL in January 2024

Kernel 4.14.x versions used by Burmilla OS 1.9.x versions will reach end of life on January 2024 https://kernel.org/category/releases.html
Kernel 5.10.x versions used by Burmilla OS 2.0.x versions looks to be supported until December 2026 so I think that it is time to try get release version out of it during this spring and then people have half of the year update their systems.

Great plan - thank you for taking care of us!

Closing because v2.0.0-rc1 was released.


add support php8.0

i use laravel 9 and php8.0
this pull request add support for php8.0

Hi @jhonoryza
I'm so sorry, but only php8.1 or higher will be supported.
Feel free to fork the project and support PHP 8.1.
Thanks for contributing


Support Layer-wise Adaptive Rate Scaling(LARS)

This PR is proposal for supporting a new optimizer-hook function based on Layer-wise Adaptive Rate Scaling.
Deteil is here.
https://arxiv.org/abs/1708.03888
https://arxiv.org/abs/1801.03137
Usage is as follows.
optimizer = optimizers.SGD(lr=0.01)
or
optimizer = optimizers.MomentumSGD(lr=0.01, momentum=0.9)
optimizer.setup(model)
optimizer.add_hook(chainer.optimizer.GradientLARS(weightdecay=0.0005))
lr(in chainer) = γ * η(in paper)

Please advise me.  😢

Thank you for your comment. 😄

Please refer https://arxiv.org/abs/1801.03137 (as well as https://arxiv.org/abs/1708.03888) because implementation is based on that paper.

Thank you for your comment.
To avoid confusion I add many comments.
Please check them.

Could you rebase the latest master branch?

Thank you for your comments. Please review again.

Could you add GradientLARS here so that this module is available in the document.

Thank you for your comments. I modify comment in GradientLARS so that this module is available in the document. Please review again.

jenkins, test this please.

LGTM, I launched CI to for final check.

The following warning occured in testing the document in the CI.
13:16:43 /home/user/.local/lib/python3.5/site-packages/chainer-4.0.0rc1-py3.5.egg/chainer/optimizer_hooks/gradient_lars.py:docstring of chainer.optimizer_hooks.GradientLARS:None: WARNING: more than one target found for cross-reference 'eps': chainer.optimizers.SMORMS3.eps, chainer.optimizers.AdaGrad.eps, chainer.optimizers.Adam.eps, chainer.optimizers.RMSpropGraves.eps, chainer.optimizers.RMSprop.eps, chainer.optimizers.AdaDelta.eps

As we treat a warning in generating the document as an error, so I find a way to resolve this warning. If you can do it by yourself, please fix the code.

@tohmae Thank you! I'll run the CI again.

jenkins, test this please.

Thank you for your comment.

LGTM


Radius normalization issue

Beam radius sharply changes between the sections with different wavelengths

Fixed in 02/05 version


channel_subscribe: Use IDs instead of emails when processing results.

As part of our todo in the code, we want to use the unique user IDs instead of emails when processing the results of subscribing users to a channel. These changes apply those changes and streamlines the use of IDs.

Screenshots and screen captures:
Help Center

Before:

After:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Has this had an API design discussion? I'm worried about breaking backwards-compatibility here.

Oh yeah, I should probably start one about it.

I did a few more tweaks to the API documentation, such as capitalizing "ID" and generally copy-editing, and merged this, thanks for cleaning this up @Joelute!


document: quick start for windows

What this PR does:
Add document which introduces  how to quickly start Pixiu for windows.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #258 (77fa621) into develop (3a15866) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #258   +/-   ##
========================================
  Coverage    39.51%   39.51%
========================================
  Files           50       50
  Lines         2584     2584
========================================
  Hits          1021     1021
  Misses        1452     1452
  Partials       111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a15866...77fa621. Read the comment docs.


Allow new-style hashes in addition to old-style ones

This removes the footgun awaiting anyone who edits model-keyword-user.txt using the hash ids the webui uses now.
TODO:

[x] Adding a prompt should replace the new-style hash entries the way it replaces the old style ones.

Thank you for the PR.
There is a UI to add custom mapping now. It takes care of the hash, so users don't need to copy hash from webui.
I think it's better to use one hash algorithm.

Fair enough -- obviously this won't be a long term issue, new users will see your new UI. It's only existing users who keep working with it the way they always head who get burned by this.


Version Update

updated JPCM dependency to v1.0. Updated Baboon version to v1.0

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Requirements for Python

For Python projects, and to be able to debug and use breakpoints, you should take into consideration additional requirements:

Python Visual Studio Code extension
Docker, to build and deploy (with the command line, not extension)
On the command line, activate your projects' virtual environment, and install or reinstall:
python -m pip install --upgrade pip
python -m pip install --upgrade ptvsd #To debug
python -m pip install --upgrade pylint #To check code style

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04c9d43d-5bd2-87c6-2ccf-0c65ef193760
Version Independent ID: 6bf46ebc-481f-e4ef-b269-99bf99434601
Content: Create your first function in Azure using Visual Studio Code
Content Source: articles/azure-functions/functions-create-first-function-vs-code.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Note also that we recently published a longer tutorial for VS Code with Python, https://docs.microsoft.com/en-us/azure/azure-functions/tutorial-vs-code-serverless-python. It wasn't integrated into this present quickstart, however, due to its length (and the current preview status).

It sounds like some of this guidance applies regardless of the dev tools.
@kulkarnisonia16 to verify this additional information and where it should best be added.


Watched Indicator

Add An Indicator Button For Each Episode To Mark It As Watched Or Not On All Platforms.

Completed In Release: 1.2
Commit: https://github.com/markydoodled/DW-Episode-Guide/commit/5268b882ba5affb358704710b906e3a99a57509c


cmd/cue: cmd fails to report errors in task names

What version of CUE are you using (cue version)?

$ cue version
cue version v0.4.1 linux/amd64

Does this issue reproduce with the latest release?
yes
What did you do?
cat > test_tool.cue
package test

import (
	"tool/cli"
)

command: {
	write: task: {
		"\(*"a"|*"b")": cli.Print & {
		  text: "TEST1"
		}
	}
}

cue cmd  write ./...

What did you expect to see?
an error about the disjunction not being valid
What did you see instead?
no output, silent failure

Confirmed with d4d0f142.
This has overlap with our plans for cuerun insofar as the method of declaring commands might change. Nonetheless, regardless of how commands are specified, we should better surface errors.

This is independent of the decision about cuerun.


formValues names with dash issue

Are you submitting a bug report or a feature request?

bug report
What is the current behavior?

formValues('name', 'name-with-dash') name is ok, but cannot be get name-with-dash anyhow...
tried formValues({name: 'name', 'name-with-dash': 'nameWithDash'}) did not work.
What is the expected behavior?
some of the way to work.
What's your environment?

React 16.
React form 7.2.0.

Please provide a sandbox that reproduces your issue.
This sandbox here works fine: https://codesandbox.io/s/j4plwr93kw

@gustavohenke thanks for the sandbox, I do not know why but it just started working... I would not write here if it worked.


Provide a 'Download METS' link from AIP view template

One thought about this @peterVG is that keeping more data in another place starts to become a bit of an information management problem. Even though we do have the METS, I wonder if it would be better to construct the METS URL and simply provide that back to the user? (Do we record it as the source in the database?) We have a couple of ways too where we could also prettyfy the URL for getting the METS so that AIPScan just becomes a router to get that information form the storage service as-is.
That would free us up to clear-down the METS exports and keep the data we hold in AIPscan focused on the database where we have a larger number of options to clean that up - redact it etc.

@ross-spencer yes, I like that approach. It was always my intention to add a task to clear out the local METS cache. I only thought of a new use for it off-the-cuff during the meeting discussion. However, I agree it's better housekeeping and avoiding an info mgt burden to clear them out and provide a dynamic link to METS download via the SS API.

Fixed merged (which proxies the METS data from the storage service).


Issue #181: Set next jobInstanceID to last jobInstanceId + 1

This fixes Issue #181
It finds the highest jobInstanceId and increments by 1.  This way all jobInstances will sill be in chronological (ascending) order and later transactions will not conflict with earlier transactions after partially clearing some of the earlier jobInstances.

@bsaylor -- thanks for the PR!
Can you please also add a unit test for the change you made in the getNextJobInstanceId() method so that we can have the bug fix documented in the tests?

@sagarsane Unit tests added.

@bsaylor thanks for adding the tests! Can you please squash the commits?
I created #183 for some of the discussions in this PR @jdigger @jbornemann ...

@sagarsane commits have been squashed.

Seems to be an improvement. @sagarsane @jdigger okay with us merging?

@jbornemann I'm ok with merging!

merged. Thanks for taking the time to fix this @bsaylor !


Use module load esmvaltool on DKRZ

https://github.com/ESMValGroup/ESMValCore/issues/989#issuecomment-845997846

The command module load esmvaltool is now working at DKRZ as well

It would be nice to update the kernel instructions here, since that should be much simpler!

Currently we already explain two options: a 'default' install, and a 'development' install. We could make the default use the module load esmvaltool, and keep the development notes for more complex use cases.


Security vulnerabilities in dependencies of latest release

Looking at https://deps.dev/go/github.com%2Fcloudfoundry%2Fgosigar this shows a few issues with dependencies that seems to be fixed after v1.3.4 was released. It might be good to release a new version with these improvements.

Thanks for the pointing this out, will create a story on our backlog to work on this.

Story created: https://www.pivotaltracker.com/story/show/184270420 (private project, but here as a cross reference for people who can access the tracker project).

We now have a v1.3.5 and v1.3.6!  Our pipeline should automatically tag new versions as dependency bumps come in.


compress all deps which are noted in the schema to archive

@bitwalker conform 0.15.0 is not published to hex? I think, it should be published before, and conform dependency changed back to hex.

@0xAX 0.15.0 is now on hex, could you update your PR to change the dependency back to use hex? Then I can merge.

@bitwalker I've updated it


card head_text_color doesn't seem to change color

I have a custom theme in iced 0.12.1.
#[derive(Debug, Clone, Copy, Default)]
pub enum Card {
    #[default]
    Default,
    Error,
}

impl iced_aw::style::card::StyleSheet for Theme {
    type Style = Card;

    fn active(&self, style: &Self::Style) -> iced_aw::style::card::Appearance {
        match style {
            Card::Default => iced_aw::style::card::Appearance {
                background: iced::Background::Color(self.background),
                head_background: iced::Background::Color(self.node_background),
                head_text_color: self.primary,
                border_color: self.border,
                ..iced_aw::style::card::Appearance::default()
            },
            Card::Error => {
                iced_aw::style::card::Appearance {
                    background: iced::Background::Color(self.background),
                    head_background: iced::Background::Color(self.error),
                    head_text_color: self.error,
                    border_color: self.border,
                    ..iced_aw::style::card::Appearance::default()
                }
            }
        }
    }
}

Changing the head background color for Default and Error both work as expected. However, attempting to change head_text_color to anything doesn't seem to have any affect. In the Error code above, the head_background and head_text_color should both be self.error which is red, but the text is still white. Trying other colors also seems to not have any affect.

we are currently slowly working on migrating the theme system to the latest one found in iced master. This might fix some of these issues.

Excellent thanks. Should I wait for the release to close if it's fixed?

If you can switch over to the main branch and give it a try. That also means switching to iced main branch too. If it's fixed let me know, and we can close this, otherwise leave it open.


Add shim to accommodate refactoring.

As title.

This is to create a bit of a time buffer for users of Numba internals (as discovered here https://github.com/numba/numba/issues/5214) to make the move to the new Numba code base layout. Anything that was on the summary list here https://github.com/numba/numba/issues/5214#issuecomment-593611360 has been re-exported irrespective of whether it's a good idea or something that will be supported in the future.
Discussion items:

What sort of warning should be given to users importing from legacy locations? Some deprecation warning with messaging along the lines of "This module (X) has moved to location (Y), please update your code. Numba 0.50 will not support import from the currently attempted location".
Should 1. be switch-off-able via numba.config/environment variable? Customers/downstream users and projects of libraries consuming Numba internals probably won't want to see this warning/it has no benefit to them.
General discussion about what is reasonable to assume as public/stable. Perhaps for another time/PR.
How to test that the shim is ok?! Ask users/use numba-integration-testing?

Marking ready for review, discussion items need resolving as part of the process.

Is it worth trying something like using module __getattr__s to DeprecationWarning about accessing through the shim?

yes
probably
yeah, that is a whole 'nother discussion altogether.
yes, i'll create a test branch to test against this PR now to help with that.

Note to self. Update deprecation docs.

Preliminary shim testing is up here: https://github.com/numba/numba-integration-testing/pull/32

Thanks @esc.

Quick report from the first round of testing: umap continues to be unaffected and is good and pydata-sparse will probably be O.K. with the shim.

fastparquet and librosa will probably be fine also and pygbm is back to segfaulting (no more import errors).

Won't __getattr__ only work if people import the module and then access names as attributes? It would probably be better to just add the deprecation to the top level of the file so it always happens when you import it.

@asmeurer: it's also triggered by a direct import of those names. But yes, perhaps in this case a module-level warning is perfectly adequate.

I think that doing both may be necessary, given removal of this patch in 0.50 will break people's non-updated code when removed, I'm inclined for it to be noisy.

It looks like awkward is still failing over (https://github.com/numba/numba-integration-testing/pull/34):
==================================== ERRORS ====================================
_____________ ERROR collecting tests/test_0118-numba-cpointers.py ______________
tests/test_0118-numba-cpointers.py:15: in <module>
    awkward1_numba_arrayview = pytest.importorskip("awkward1._numba.arrayview")
awkward1/_numba/arrayview.py:77: in <module>
    class LookupModel(numba.datamodel.models.StructModel):
E   AttributeError: module 'numba' has no attribute 'datamodel'

Seems downstream projects sometimes assume these modules are preimported

I propose adding something like:  https://github.com/stuartarchibald/numba/commit/f5744a2c95fe20c0247f1b2e1fb1601574fa7b08
With that enabled, this:
from numba import analysis
from numba.analysis import ir_extension_usedefs

produces:
$ python test_shim1.py
test_shim1.py:1: NumbaDeprecationWarning: An import of was requested from a module that has moved location.
Import requested from: 'numba.analysis', please update to use 'numba.core.analysis' or pin to Numba version 0.48.0.
  from numba import analysis
test_shim1.py:2: NumbaDeprecationWarning: An import of was requested from a module that has moved location.
Import requested from: 'numba.analysis', please update to use 'numba.core.analysis' or pin to Numba version 0.48.0.
  from numba.analysis import ir_extension_usedefs

That change isn't quite correct, but I think the idea is sound. If you ping me when you turn that into a PR I'll review it.

That change isn't quite correct, but I think the idea is sound. If you ping me when you turn that into a PR I'll review it.

Thanks for looking, I'm going to pull that onto this PR, so please just comment on the patch and I'll make changes. I really want this all to go in as one patch so it's trivial to revert in 0.50. Thanks!

/AzurePipelines run

https://github.com/stuartarchibald/numba/tree/wip/refactor_shim_1_backup is the same as this branch, am going to flatten all this into one patch now. 9858302 will get force pushed to a single patch.


--dart2js-optimization=O0 appears to be totally broken

Steps to reproduce

Write the following app:
import 'package:flutter/material.dart';

@pragma('vm:entry-point')
void main() async {
  runApp(const LoadingScreen());
}

class LoadingScreen extends StatelessWidget {
  const LoadingScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return const ColoredBox(
      color: Color(0xffcc0000),
      child: Center(
        child: CircularProgressIndicator(),
      ),
    );
  }
}

Compile the app using flutter build web --web-renderer=canvaskit --dart2js-optimization=O0

Try to run the app in the browser

Expected results
You expect to see a red page with a loading indicator
Actual results
A lot of errors appear in the console, and the page doesn't load.
flutter.js:368 Exception while loading service worker: Error: prepareServiceWorker took more than 4000ms to resolve.

Looks similar to https://github.com/flutter/flutter/issues/120787, but this one has no external dependencies.
cc @sigmundch

@tvolkert - I'm curious to learn more about the context for which you need to use -O0.
Practically speaking, dart2js's -O0 is  meant for the dart2js team to debug and isolate issues and it is maintained in a best-effort basis. It is not intended to be used directly in app development. We usually recommend using -O1 or higher.
cc @rakudrama

I just wanted to see fully unoptimized JS to make it easier to debug in Chrome devtools. 🙂
That said, if this isn't meant for end-users, we shouldn't allow its usage (it is a documented flag in the flutter tool).

We should probably remove the documentation for -O0 from dart compile js --help and elsewhere.
  -O<0,1,2,3,4>   Set the compiler optimization level (defaults to -O1).
     -O0          No optimizations (only meant for debugging the compiler).
     -O1          Default (includes whole program analyses and inlining).
     -O2          Safe production-oriented optimizations (like minification).
     -O3          Potentially unsafe optimizations (see -h -v for details).
     -O4          More agressive unsafe optimizations (see -h -v for details).

The intention is that -O1 and -O2 implement the Dart language as close to the specification as possible.
@christopherfujino Can you update the flutter tool text to not mention O0? We didn't really expect -O0 to be advertised in flutter.
    --dart2js-optimization                                   Sets the optimization level used for Dart compilation to JavaScript. Valid
                                                             values range from O0 to O4.
                                                             (defaults to "O4")

s/O0/O1/.
Is there a way to pass other arguments to dart2js from the flutter CLI?
@tvolkert Do you get what you want with -O1 --disable-inlining ? That is the set of disabled optimizations most likely to work. We don't test that, but disabling inlining is supported via @pragma.

I'll give it a shot - thanks!

The intention is that -O1 and -O2 implement the Dart language as close to the specification as possible.
@christopherfujino Can you update the flutter tool text to not mention O0? We didn't really expect -O0 to be advertised in flutter.

SGTM

--profile should be useful for debugging too. Frequently I can spot issues without disabling inlining.