HBASE-24788: Fix the connection leaks in hbase

Fixing the connection leaks in hbase due to closing hbase admin without closing connection.

@bharathv  @apurtell @xcangCRM Can you please review this ?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 35s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-mapreduce: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

39m 52s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d3f2a032873b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 58s
master passed

+1 :green_heart:
compile
1m 42s
master passed

+1 :green_heart:
shadedjars
7m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 24s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
7m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

_ Other Tests _

-1 :x:
unit
148m 31s
hbase-server in the patch failed.

+1 :green_heart:
unit
10m 33s
hbase-mapreduce in the patch passed.

193m 24s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 45de78d865be 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/testReport/

Max. process+thread count
4674 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
7m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 47s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 23s
hbase-mapreduce in the patch failed.

_ Other Tests _

-1 :x:
unit
183m 25s
hbase-server in the patch failed.

-1 :x:
unit
14m 34s
hbase-mapreduce in the patch failed.

233m 13s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d922f07ff096 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/testReport/

Max. process+thread count
3806 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 47s
master passed

+1 :green_heart:
checkstyle
1m 49s
master passed

+1 :green_heart:
spotbugs
3m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 47s
the patch passed

-0 :warning:
checkstyle
1m 23s
hbase-server: The patch generated 1 new + 28 unchanged - 1 fixed = 29 total (was 29)

+1 :green_heart:
checkstyle
0m 21s
hbase-mapreduce: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m 35s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux bd8b429f8451 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 45s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 38s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
shadedjars
5m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
1m 21s
the patch passed

+1 :green_heart:
javac
1m 21s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
the patch passed

_ Other Tests _

-1 :x:
unit
173m  9s
hbase-server in the patch failed.

-1 :x:
unit
100m 35s
hbase-mapreduce in the patch failed.

303m 18s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d47f629fc725 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/testReport/

Max. process+thread count
4947 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
compile
2m  8s
the patch passed

+1 :green_heart:
javac
2m  8s
the patch passed

+1 :green_heart:
shadedjars
7m 57s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 56s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 25s
hbase-mapreduce in the patch failed.

_ Other Tests _

-1 :x:
unit
179m 26s
hbase-server in the patch failed.

-1 :x:
unit
101m 19s
hbase-mapreduce in the patch failed.

317m 48s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4ef4c81afa4a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4471a644f6

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/testReport/

Max. process+thread count
3846 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Changes look good, +1.
Test failures seem relevant? Failures are present for the updated tests. Triggered another build, let's wait for it.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
master passed

+1 :green_heart:
checkstyle
1m 22s
master passed

+1 :green_heart:
spotbugs
2m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
checkstyle
1m  3s
hbase-server: The patch generated 0 new + 28 unchanged - 1 fixed = 28 total (was 29)

+1 :green_heart:
checkstyle
0m 18s
hbase-mapreduce: The patch generated 0 new + 5 unchanged - 2 fixed = 5 total (was 7)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
3m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

35m 50s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a826924fbfb3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7974a1e9bf

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m 37s
the patch passed

+1 :green_heart:
javac
1m 37s
the patch passed

+1 :green_heart:
shadedjars
6m 10s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-mapreduce in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
131m  2s
hbase-server in the patch passed.

+1 :green_heart:
unit
9m 59s
hbase-mapreduce in the patch passed.

170m 10s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fd028cba390e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5480f350c2

Default Java
2020-01-14

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/testReport/

Max. process+thread count
4627 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
compile
1m 31s
master passed

+1 :green_heart:
shadedjars
6m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 51s
the patch passed

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
shadedjars
6m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
158m  4s
hbase-server in the patch passed.

+1 :green_heart:
unit
15m 50s
hbase-mapreduce in the patch passed.

203m 37s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2162

JIRA Issue
HBASE-24788

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff1970b0e75e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5480f350c2

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/testReport/

Max. process+thread count
4399 (vs. ulimit of 12500)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2162/6/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Cookies?

How do I set a cookie?

I didn't implement a cookies interface.  But the current framework can support it if you utilize the Header setter.  Create a Header key with the name of Cookie and the value needs to be a comma delimited string of key/value pairs.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cookie


Failed to Deploy hetzner-k3s

Dear @vitobotta
I've attempted to install k3s with Hetzner and failed with the following:
=== Setting up Kubernetes ===
Deploying k3s to first master siliconcloud-cpx21-master1...
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
Waiting for the control plane to be ready...
Saving the kubeconfig file to /mnt/c/repos/SiliconDali/Administration/12. Servers/hertzner-k3s/kubeconfig...
...k3s has been deployed to first master siliconcloud-cpx21-master1 and the control plane is up.
Deploying k3s to master siliconcloud-cpx21-master2...
Deploying k3s to master siliconcloud-cpx21-master3...
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
[INFO]  systemd: Starting k3s
...k3s has been deployed to master siliconcloud-cpx21-master3.
...k3s has been deployed to master siliconcloud-cpx21-master2.

=== Deploying Hetzner drivers ===

Creating secret for Hetzner Cloud token...
Unable to connect to the server: EOF
Failed to create Hetzner Cloud secret:
Unable to connect to the server: EOF

cluster.yaml
---
hetzner_token: <REDACTED>
cluster_name: siliconcloud
kubeconfig_path: "./kubeconfig"
k3s_version: v1.25.5+k3s1
public_ssh_key_path: "~/.ssh/id_ed25519.pub"
private_ssh_key_path: "~/.ssh/id_ed25519"
use_ssh_agent: false
ssh_allowed_networks:
- <REDACTED>
api_allowed_networks:
- <IP_ADDRESS>/0
schedule_workloads_on_masters: true
enable_encryption: true
masters_pool:
  instance_type: cpx21
  location: nbg1
  instance_count: 3
worker_node_pools:
- name: autoscaled-nbg1-cx21
  instance_type: cpx21
  location: nbg1
  instance_count: 0
  autoscaling:
    enabled: true
    min_instances: 0
    max_instances: 2

Please note that i've tried versions  v1.25.5+k3s and v1.26.1+k3s1

Can you please share your config file? (remove the token)

Hi @vitobotta   it's shared in this top issue under section cluster.yaml

Oops, sorry. Does it still happen if you re-run the same create command? If yes, please run
export KUBECONFIG=kubeconfig

from the directory where the kubeconfig is saved, and try a kubectl command like
kubectl get nodes

Does that work?

hetzner_token:
cluster_name: siliconcloud
kubeconfig_path: "./kubeconfig"
k3s_version: v1.25.5+k3s1
public_ssh_key_path: "~/.ssh/id_ed25519.pub"
private_ssh_key_path: "~/.ssh/id_ed25519"
use_ssh_agent: false
ssh_allowed_networks:

api_allowed_networks:

<IP_ADDRESS>/0
schedule_workloads_on_masters: true
enable_encryption: true
masters_pool:
instance_type: cpx21
location: nbg1
instance_count: 3
worker_node_pools:
name: autoscaled-nbg1-cx21
instance_type: cpx21
location: nbg1
instance_count: 0
autoscaling:
enabled: true
min_instances: 0
max_instances: 2

Hi @vitobotta
This still fails in the exact same way.
Let me give you some contexts, you can get a better idea of what's happening.
The Cluster is not able to connect to start with as the LoadBalancer is unhealthy.

Upon looking as to why, I realize that the k3s services are failing to start.
I'm connecting to the master1 to check:
root@siliconcloud-cpx21-master1:~# kubectl get all -A
NAMESPACE     NAME                           READY   STATUS    RESTARTS   AGE
kube-system   pod/coredns-597584b69b-p5sh7   0/1     Pending   0          4m49s

NAMESPACE     NAME                 TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)                  AGE
default       service/kubernetes   ClusterIP   <IP_ADDRESS>    <none>        443/TCP                  5m3s
kube-system   service/kube-dns     ClusterIP   <IP_ADDRESS>   <none>        53/UDP,53/TCP,9153/TCP   5m

NAMESPACE     NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
kube-system   deployment.apps/coredns   0/1     1            0           5m

NAMESPACE     NAME                                 DESIRED   CURRENT   READY   AGE
kube-system   replicaset.apps/coredns-597584b69b   1         1         0       4m49s
root@siliconcloud-cpx21-master1:~#

Here we can see the pod is "Pending" and rest are not yet spawned due to this as well...
 This is the n.Spec.PodCIDR>
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:12Z" level=info msg="Wrote flannel subnet file to /run/flannel/subnet.env"
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:12Z" level=info msg="Running flannel backend."
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.110735    2048 wireguard_network.go:78] Watching for new subnet leases
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.123178    2048 iptables.go:270] bootstrap done
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.133545    2048 iptables.go:270] bootstrap done

checking journalctl
root@siliconcloud-cpx21-master1:~# journalctl -xeu k3s
Feb 06 18:18:10 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:10.913311    2048 shared_informer.go:262] Caches are synced for ReplicaSet
Feb 06 18:18:10 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:10.936779    2048 event.go:294] "Event occurred" object="kube-system/coredns-597584b69b" fi>
Feb 06 18:18:10 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:10.997420    2048 shared_informer.go:262] Caches are synced for resource quota
Feb 06 18:18:10 siliconcloud-cpx21-master1 k3s[2048]: W0206 18:18:10.998814    2048 actual_state_of_world.go:541] Failed to update statusUpdateNeeded field i>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030258    2048 shared_informer.go:262] Caches are synced for taint
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030426    2048 node_lifecycle_controller.go:1443] Initializing eviction metric for zone:
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: W0206 18:18:11.030518    2048 node_lifecycle_controller.go:1058] Missing timestamp for Node siliconclou>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030714    2048 node_lifecycle_controller.go:1259] Controller detected that zone  is now >
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030873    2048 taint_manager.go:204] "Starting NoExecuteTaintManager"
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030928    2048 taint_manager.go:209] "Sending events to api server"
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.030995    2048 shared_informer.go:262] Caches are synced for GC
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.031146    2048 event.go:294] "Event occurred" object="siliconcloud-cpx21-master1" fieldP>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.031181    2048 shared_informer.go:262] Caches are synced for persistent volume
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.031289    2048 shared_informer.go:262] Caches are synced for TTL
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.041820    2048 shared_informer.go:262] Caches are synced for resource quota
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.048525    2048 shared_informer.go:262] Caches are synced for node
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.048563    2048 range_allocator.go:166] Starting range CIDR allocator
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.048569    2048 shared_informer.go:255] Waiting for caches to sync for cidrallocator
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.048581    2048 shared_informer.go:262] Caches are synced for cidrallocator
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.052668    2048 range_allocator.go:367] Set node siliconcloud-cpx21-master1 PodCIDR to [1>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:11Z" level=info msg="Flannel found PodCIDR assigned for node siliconcloud-cpx21->
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:11Z" level=info msg="The interface enp7s0 with ipv4 address <IP_ADDRESS> will be use>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.056140    2048 kube.go:126] Waiting 10m0s for node controller to sync
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.056154    2048 kube.go:431] Starting kube subnet manager
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.061075    2048 shared_informer.go:262] Caches are synced for endpoint_slice
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.080920    2048 shared_informer.go:262] Caches are synced for daemon sets
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.081761    2048 shared_informer.go:262] Caches are synced for attach detach
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.135056    2048 kuberuntime_manager.go:1050] "Updating runtime config through cri with po>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.136214    2048 kubelet_network.go:60] "Updating Pod CIDR" originalPodCIDR="" newPodCIDR=>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:11Z" level=info msg="Starting the netpol controller version v1.5.2-0.20221026101>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.161948    2048 network_policy_controller.go:163] Starting network policy controller
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.206312    2048 network_policy_controller.go:175] Starting network policy controller full>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.430080    2048 shared_informer.go:262] Caches are synced for garbage collector
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.430120    2048 garbagecollector.go:163] Garbage collector: all resource monitors have sy>
Feb 06 18:18:11 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:11.432330    2048 shared_informer.go:262] Caches are synced for garbage collector
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.056842    2048 kube.go:133] Node controller sync successful
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.103126    2048 kube.go:452] Creating the node lease for IPv4. This is the n.Spec.PodCIDR>
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:12Z" level=info msg="Wrote flannel subnet file to /run/flannel/subnet.env"
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: time="2023-02-06T18:18:12Z" level=info msg="Running flannel backend."
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.110735    2048 wireguard_network.go:78] Watching for new subnet leases
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.123178    2048 iptables.go:270] bootstrap done
Feb 06 18:18:12 siliconcloud-cpx21-master1 k3s[2048]: I0206 18:18:12.133545    2048 iptables.go:270] bootstrap don

Moving forward to checking why the Pod is pending:
root@siliconcloud-cpx21-master1:~# kubectl get pods -A
NAMESPACE     NAME                       READY   STATUS    RESTARTS   AGE
kube-system   coredns-597584b69b-p5sh7   0/1     Pending   0          7m41s
root@siliconcloud-cpx21-master1:~# kubectl describe pod coredns-597584b69b-p5sh7 -n kube-system
Name:                 coredns-597584b69b-p5sh7
Namespace:            kube-system
Priority:<PHONE_NUMBER>
Priority Class Name:  system-cluster-critical
Service Account:      coredns
Node:                 <none>
Labels:               k8s-app=kube-dns
                      pod-template-hash=597584b69b
Annotations:          <none>
Status:               Pending
IP:
IPs:                  <none>
Controlled By:        ReplicaSet/coredns-597584b69b
Containers:
  coredns:
    Image:       rancher/mirrored-coredns-coredns:1.9.4
    Ports:       53/UDP, 53/TCP, 9153/TCP
    Host Ports:  0/UDP, 0/TCP, 0/TCP
    Args:
      -conf
      /etc/coredns/Corefile
    Limits:
      memory:  170Mi
    Requests:
      cpu:        100m
      memory:     70Mi
    Liveness:     http-get http://:8080/health delay=60s timeout=1s period=10s #success=1 #failure=3
    Readiness:    http-get http://:8181/ready delay=0s timeout=1s period=2s #success=1 #failure=3
    Environment:  <none>
    Mounts:
      /etc/coredns from config-volume (ro)
      /etc/coredns/custom from custom-config-volume (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-x5qbx (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  config-volume:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      coredns
    Optional:  false
  custom-config-volume:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      coredns-custom
    Optional:  true
  kube-api-access-x5qbx:
    Type:                     Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:   3607
    ConfigMapName:            kube-root-ca.crt
    ConfigMapOptional:        <nil>
    DownwardAPI:              true
QoS Class:                    Burstable
Node-Selectors:               beta.kubernetes.io/os=linux
Tolerations:                  CriticalAddonsOnly op=Exists
                              node-role.kubernetes.io/control-plane:NoSchedule op=Exists
                              node-role.kubernetes.io/master:NoSchedule op=Exists
                              node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                              node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Topology Spread Constraints:  kubernetes.io/hostname:DoNotSchedule when max skew 1 is exceeded for selector k8s-app=kube-dns
Events:
  Type     Reason            Age    From               Message
  ----     ------            ----   ----               -------
  Warning  FailedScheduling  7m51s  default-scheduler  0/1 nodes are available: 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
  Warning  FailedScheduling  2m34s  default-scheduler  0/1 nodes are available: 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
root@siliconcloud-cpx21-master1:~#

Additional Info:
root@siliconcloud-cpx21-master1:~# k3s check-config

Verifying binaries in /var/lib/rancher/k3s/data/691f04419e1d8a92fa96d43d6c1ad05162cda6e445ba30bc5eac758bf7597063/bin:
- sha256sum: good
- links: good

System:
- /usr/sbin iptables v1.8.7 (nf_tables): ok
- swap: disabled
- routes: ok

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

modprobe: FATAL: Module configs not found in directory /lib/modules/5.15.0-56-generic
info: reading kernel config from /boot/config-5.15.0-56-generic ...

Generally Necessary:
- cgroup hierarchy: cgroups V2 mounted, cpu|cpuset|memory controllers status: good
- /usr/sbin/apparmor_parser
apparmor: enabled and tools installed
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_IPVS: enabled (as module)
- CONFIG_IP_NF_NAT: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_IP_NF_TARGET_REDIRECT: enabled (as module)
- CONFIG_IP_SET: enabled (as module)
- CONFIG_IP_VS: enabled (as module)
- CONFIG_IP_VS_NFCT: enabled
- CONFIG_IP_VS_PROTO_TCP: enabled
- CONFIG_IP_VS_PROTO_UDP: enabled
- CONFIG_IP_VS_RR: enabled (as module)
- CONFIG_EXT4_FS: enabled
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
      Optional (for encrypted networks):
      - CONFIG_CRYPTO: enabled
      - CONFIG_CRYPTO_AEAD: enabled
      - CONFIG_CRYPTO_GCM: enabled
      - CONFIG_CRYPTO_SEQIV: enabled
      - CONFIG_CRYPTO_GHASH: enabled
      - CONFIG_XFRM: enabled
      - CONFIG_XFRM_USER: enabled (as module)
      - CONFIG_XFRM_ALGO: enabled (as module)
      - CONFIG_INET_ESP: enabled (as module)
      - CONFIG_INET_XFRM_MODE_TRANSPORT: missing
- Storage Drivers:
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)

STATUS: pass

journalctl -u k3s
k3s.log

Those pods being pending is normal, it's because it needs to install the cloud controller manager before other pods can be scheduled. But this shouldn't affect the API, which should be running, as confirmed by the fact that from inside the master you can run kubectl commands.
Something is wrong with the load balancer. Can you please try deleting it from the Hetzner console, and re-running the cluster create command so it creates a new one?

same problem here

same problem here

Same thing with the load balancer not ready?

same problem here

Same thing with the load balancer not ready?

yes, the load balancer is unhealthy and when I run kubectl get nodes on master1 I only see master1 and the workers (master2 and master3 are missing)

OK, I will take a look tomorrow. I am still working and it's getting late here :)

Here are a few details about my deployment and failures.
I have already recreated the load balancer and also several times the whole project.

Deployment:
$ hetzner-k3s create --config testcluster.yaml
Validating configuration......configuration seems valid.

=== Creating infrastructure resources ===
Creating network...done.
Creating firewall...done.
Creating SSH key...done.
Placement group test-masters already exists, skipping.
Placement group test-small-static already exists, skipping.
Creating server test-cpx21-pool-small-static-worker2...
Creating server test-cpx11-master3...
Creating server test-cpx11-master1...
Creating server test-cpx21-pool-small-static-worker1...
Creating server test-cpx21-pool-small-static-worker3...

Waiting for server test-cpx11-master3...
Waiting for server test-cpx11-master2...
Waiting for server test-cpx21-pool-small-static-worker1...
Waiting for server test-cpx21-pool-small-static-worker3...
Waiting for server test-cpx11-master1...
Waiting for server test-cpx21-pool-small-static-worker2...
...server test-cpx21-pool-small-static-worker1 is now up.
...server test-cpx11-master1 is now up.
...server test-cpx21-pool-small-static-worker3 is now up.
...server test-cpx11-master3 is now up.
...server test-cpx11-master2 is now up.
...server test-cpx21-pool-small-static-worker2 is now up.

[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
Waiting for the control plane to be ready...
Saving the kubeconfig file to /xxx/kubeconfig...
...k3s has been deployed to first master test-cpx11-master1 and the control plane is up.
Deploying k3s to master test-cpx11-master2...
Deploying k3s to master test-cpx11-master3...
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
[INFO]  systemd: Starting k3s
...k3s has been deployed to master test-cpx11-master2.
...k3s has been deployed to master test-cpx11-master3.
Deploying k3s to worker test-cpx21-pool-small-static-worker1...
Deploying k3s to worker test-cpx21-pool-small-static-worker2...
Deploying k3s to worker test-cpx21-pool-small-static-worker3...
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.25.5+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.25.5+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  Verifying binary download
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  systemd: Starting k3s-agent
[INFO]  systemd: Starting k3s-agent
[INFO]  systemd: Starting k3s-agent
...k3s has been deployed to worker test-cpx21-pool-small-static-worker3.
...k3s has been deployed to worker test-cpx21-pool-small-static-worker2.
...k3s has been deployed to worker test-cpx21-pool-small-static-worker1.

=== Deploying Hetzner drivers ===

Creating secret for Hetzner Cloud token...
Unable to connect to the server: EOF
Failed to create Hetzner Cloud secret:
Unable to connect to the server: EOF

testcluster.yaml
---
hetzner_token: xxx
cluster_name: test
kubeconfig_path: "./kubeconfig"
k3s_version: v1.25.5+k3s1
public_ssh_key_path: "/xxx/id_rsa.pub"
private_ssh_key_path: "/xxx/id_rsa"
use_ssh_agent: false
ssh_allowed_networks:
  - <IP_ADDRESS>/0
api_allowed_networks:
  - <IP_ADDRESS>/0
schedule_workloads_on_masters: false
# image: rocky-9 # optional: default is ubuntu-22.04
image: debian-11
masters_pool:
  instance_type: cpx11
  instance_count: 3
  location: nbg1
worker_node_pools:
- name: small-static
  instance_type: cpx21
  instance_count: 3
  location: fsn1
- name: big-autoscaled
  instance_type: cpx21
  instance_count: 2
  location: hel1
  autoscaling:
    enabled: true
    min_instances: 0
    max_instances: 3

Load Balancer:

Master 1:
master1:~# kubectl get nodes
NAME                                   STATUS   ROLES                       AGE     VERSION
test-cpx11-master1                     Ready    control-plane,etcd,master   5m11s   v1.25.5+k3s1
test-cpx21-pool-small-static-worker1   Ready    <none>                      4m26s   v1.25.5+k3s1
test-cpx21-pool-small-static-worker2   Ready    <none>                      4m26s   v1.25.5+k3s1
test-cpx21-pool-small-static-worker3   Ready    <none>                      4m26s   v1.25.5+k3s1

master1:~# kubectl get all -A
NAMESPACE     NAME                           READY   STATUS    RESTARTS   AGE
kube-system   pod/coredns-597584b69b-zb4cl   0/1     Pending   0          10m

NAMESPACE     NAME                 TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)                  AGE
default       service/kubernetes   ClusterIP   <IP_ADDRESS>    <none>        443/TCP                  10m
kube-system   service/kube-dns     ClusterIP   <IP_ADDRESS>   <none>        53/UDP,53/TCP,9153/TCP   10m

NAMESPACE     NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
kube-system   deployment.apps/coredns   0/1     1            0           10m

NAMESPACE     NAME                                 DESIRED   CURRENT   READY   AGE
kube-system   replicaset.apps/coredns-597584b69b   1         1         0       10m

Master 2 & 3:
master2:~# kubectl get nodes
The connection to the server localhost:8080 was refused - did you specify the right host or port

Update: I have now set schedule_workloads_on_masters to true and it works.
Load balancer is healthy and all masters are available.

@vitobotta  @fbrettnich
It seems there must have been an incident with the Hetzner Load Balancer.
With no change to my configuration, and no change to the deployment method, everything magically works today.
Conclusion, there is no issue with the setup scripts, and in fact a Hetzner incident instead.

Closing this issue, and thank you both for your prompt support.
@vitobotta  I really love what you have done with your provisioner of k3s with this tool.
If you like, we can also collaborate to enhance for full blown k8s (if that makes sense to you)...
I would help to contribute to that.
Best Regards
Panayiotis Savva
CKAD / CKA Certified

Thanks @psavva, weird but it can happen. @fbrettnich can you try again as well and confirm if it works for you too?

Thanks @psavva, weird but it can happen. @fbrettnich can you try again as well and confirm if it works for you too?

yes, now everything is working
Thank you

Awesome, thanks


Isaac Gym is replaced by Isaac Lab now, could you please offer a new version for Isaac Lab?

There are numerous changes in the ways to operation. So it is not easy to move from the former platform to the new one. Would you please consider rewrite this repo?
The note on the website is as follows.
Note: This is legacy software. Developers may download and continue to use it, but it is no longer supported. Please consider using Isaac Lab, an open-source lightweight and performance optimized application for robot learning built on the Isaac Sim platform.

Isaaclab has officially provided training for g1, h1, go2. Please visit Isaaclab for more information
https://isaac-sim.github.io/IsaacLab/main/source/overview/environments.html


Testing ci

i am having trouble finding a logical reason why this test fails in bitrise but not locally. the only thing i can think of is to remove the test.


adding an event/callback on mouse clicks

Hi,
How do I add an event/callback for mouse clicks?  I've tried adding dispatch and would see the console logs inside the functions, but unable it is unable to see my component variables.
In the code below, i could see console logging, but the setting of displayData is not done.  I've also tried calling a function inside dispatch, but the browser says it is undefined.  What I want to is to be able to call my own function on a mouse click event.
  displayData: string = "abc";  ngOnInit(){     this.options = {       chart: {         type: 'historicalBarChart',         height: 70,         color: ["#2BBED8"],         margin : {           top: 0,           right: 10,           bottom: 10,           left: 10         },       dispatch: { //container of event handlers                   elementMousemove: function(e){                      console.log("mousemove"+ JSON.stringify(e));                     this.displayData = "xyz"                   },                   elementMouseout: function(e){ console.log('mouseout'+ JSON.stringify(e)) },                   chartClick: function(e){ this.displayData = "xyz"; console.log('chartClick'+ JSON.stringify(e)) },                   elementClick: function(e){ console.log('elementClick'+ JSON.stringify(e)) },                   elementDblclick: function(e){ console.log('double click' + JSON.stringify(e)) }               },
Thanks,

I think we're having the same issue here...
http://stackoverflow.com/questions/38392390/bind-ng2-nvd3-chart-with-component-in-angular-2-using-dispatch


Added Bundle tasks to raw package.json

Once the user runs the eject command, these tasks can be used to bundle release files for android and ios. This is something I keep as an command alias. If this is helpful for others please accept.

Thanks for the pull request! This looks like a useful addition to the plain RN eject.
The eject code now lives in the Expo CLI repository:

packages/expo-cli/src/commands/eject.js
packages/expo-cli/src/commands/eject/Eject.js.

I invite you to re-open the pull request in the Expo CLI repo. Thanks for contributing!


Laravel 6.0 Shift

This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the shift-19113 branch.
Before merging, you need to:

Checkout the shift-19113 branch
Review all pull request comments for additional changes
Update your dependencies for Laravel 6.0
Run composer update (if the scripts fail, add --no-scripts)
Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

:x: Shift could not upgrade your HTTP Kernel because it differed from the default version. You will need to compare this file against the default Laravel 6.0 version and merge any changes.

:warning: Shift defaulted the following configuration files. This was done in the Default config files commit so you may easily review and backfill your customizations. If you have a lot of customizations, you may also undo this commit with git revert and upgrade these files manually.

[ ] config/database.php
[ ] config/mail.php
[ ] config/services.php

:information_source: Laravel 6.0 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.
However, if possible, consider switching to phpredis to gain the performance of its PHP extension and avoid using the deprecated predis dependency which will be removed in Laravel 7.0.

:information_source: Shift makes an effort to update your dependencies for Laravel 6.0. While many of the popular packages are reviewed, you may have to update additional packages or version constraints in order for your application to be compatible with Laravel 6.0. Watch dealing with dependencies for tips on handling package incompatibilities.

:warning: In Laravel 6.0, the update method of the BelongsTo relationship no longer provides mass assignment protection or fires Eloquent events. If you wish to preserve this behavior, you should call update on the model itself.
// no mass assignment protection or events...
$post->user()->update(['foo' => 'bar']);

// mass assignment protection and events...
$post->user->update(['foo' => 'bar']);

Shift found potential uses of the update method in:

[ ] app/Repositories/Frontend/Access/User/UserRepository.php

:information_source: The Eloquent model's toArray() method will now cast any attributes that implement Illuminate\Contracts\Support\Arrayable to an array. While unlikely to impact your application, this change could effect code which relies upon the previous data type or output.

:warning: Previous versions of Laravel would use parameters passed to the route() helper as URI values even if the parameter had no matching placeholder within the route path. In Laravel 6.0, values not matching placeholders are attached to the query string instead.
Shift detected the following uses of the route() helper you should review to ensure the route parameter key and route placeholder name match.

[ ] app/Helpers/helpers.php
[ ] app/Http/Breadcrumbs/Backend/Access/Permission.php
[ ] app/Http/Breadcrumbs/Backend/Access/Role.php
[ ] app/Http/Breadcrumbs/Backend/Access/User.php
[ ] app/Http/Breadcrumbs/Backend/Blog.php
[ ] app/Http/Breadcrumbs/Backend/Blog_Category.php
[ ] app/Http/Breadcrumbs/Backend/Blog_Management.php
[ ] app/Http/Breadcrumbs/Backend/Blog_Tag.php
[ ] app/Http/Breadcrumbs/Backend/Faqs.php
[ ] app/Http/Breadcrumbs/Backend/Menu.php
[ ] app/Http/Breadcrumbs/Backend/Page.php
[ ] app/Http/Breadcrumbs/Backend/Setting.php
[ ] app/Http/Controllers/Backend/Access/User/UserPasswordController.php
[ ] app/Http/Controllers/Backend/Settings/SettingsController.php
[ ] app/Models/Access/Role/Traits/Attribute/RoleAttribute.php
[ ] app/Models/Access/User/Traits/Attribute/UserAttribute.php
[ ] app/Models/Faqs/Traits/Attribute/FaqAttribute.php
[ ] app/Models/ModelTrait.php
[ ] app/Models/Page/Traits/Attribute/PageAttribute.php
[ ] app/Notifications/Frontend/Auth/UserNeedsConfirmation.php
[ ] app/Notifications/Frontend/Auth/UserNeedsPasswordReset.php
[ ] resources/lang/en/exceptions.php

:information_source: Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.
/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

:information_source: The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6.0. If you were using these drivers, you may adopt a community maintained package which provides the driver.

:information_source: Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

:information_source: Shift detected you are using a Laravel package which has its own assets or views which may need to be regenerated after upgrading. Be sure to use artisan to publish these as well as php artisan view:clear to avoid any errors.

:tada: Congratulations, you're now running the latest version of Laravel.
The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:

Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
Laravel Fixer automates many of the suggestions found by the Linter and other Shifts.
Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans.


Bug: customer reported cannot create a Table with kafka connector in DEBEZIUM AVRO format

Describe the bug
customer reported cannot create a Table with kafka connector in DEBEZIUM AVRO format.
CREATE TABLE data_item  WITH ( CONNECTOR = 'kafka', TOPIC = 'data_item', PROPERTIES.BOOTSTRAP.SERVER = 'xxx', SCAN.STARTUP.MODE = 'earliest' )  FORMAT DEBEZIUM ENCODE AVRO (schema.registry='xxx');

Error message/log
SQL ERROR: ExecuteError: Protocol error: Avro schema parse error One union type Date must match the `default`'s value type Long

To Reproduce
The schema which is suspected to be causing this problem:
{
	"name": "first_insert_dt",
	"type": [
		{
			"type": "int",
			"connect.version": 1,
			"connect.default": 0,
			"connect.name": "org.apache.kafka.connect.data.Date",
			"logicalType": "date"
		},
		"null"
	],
	"default": 0
},

Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
risingwave:nightly-20231102
Additional context
No response

Yet another upstream (apache_avro) bug: #12562 / #13030
It has been fixed in v0.14.0

I am working on migration from our fork to the official version.

we introduce our crate to handle ref type in Avro, without handling cycle dependency. I am not sure the official sdk has fixed that.

we introduce our crate to handle ref type in Avro, without handling cycle dependency.

Yes. I have a prototype solution for both ref type and decimal, using the official version rather than our fork.


refactor: cursor API in prep for blocking on I/O and multi-update

Gets rid of a bunch of code that was unnecessary for the dummy (test) cursor implementation.
Should not be considered final, just roughly what I mapped out as needing for the update, plus the skeleton in #42

#46  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Apr 3, 2:44 AM EDT: @pepyakin started a stack merge that includes this pull request via Graphite.


Using aBoolean() in response generates null on consumer side

I'm using Spring Cloud Contract 2.1.2-RELEASE and have a contract that returns a JSON response body containing a boolean field
response {
		status OK()
		headers {
			contentType applicationJson()
		}
		body (
                  foo: value(consumer(aBoolean()), producer(true))
		)
	}

The generated mapping file contains a body that assigns null to foo:
"response" : {
    ...
    "body" : "{\"foo\":null}",
    ...
  },

This is not what I was expecting - I would expect a random non-null boolean value.
If I've understood this correctly the cause seems to be in this code in PatternValueDslProperty.java:
       @Override
	T aBoolean() {
		return createAndValidateProperty(RegexPatterns.TRUE_OR_FALSE)
	}

It feels to me that this should be passing random.nextBoolean() as the second parameter to the function.
Is there a workaround in lieu of a fix?

That's because in the response side the consumer needs to be a concrete value and the producer can be a regex

Hi @marcingrzejszczak
Apologies if I have misunderstood the workings of Spring Cloud Contract; I thought consumer()-side responses could be wildcarded but I can see now that's misguided,
I did notice that doing e.g.
response {
		status OK()
		body (
                   foo: value(consumer(anyOf('Bar1', 'Bar2', ...)), producer("Bar10")),

Generated the mapping
   body" : "{\"foo\":\"Bar1\"}"

But perhaps that's an (un)happy accident?


Fix FHIR to Weight Transform

@gcorvera,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:shipit:


Don't log enabling/disabling

I think it's more professional that way. That's just my opinion though.

Just removed it myself. Thanks for the effort though. :)


[WIP]test c/common config pkg

Vendor in c/common config pkg for containers.conf https://github.com/containers/common/pull/20
Set OCIRunime if runtime from c/common config is empty
Vendor in branch from build replace buildah/unshare with common/pkg/unshare to avoid unshare redefined both in buidlah&common under vendor folder error
Remove libpod/pkg/config

Signed-off-by: Qi Wang<EMAIL_ADDRESS>

@rhatdan @vrothberg @TomSweeneyRedHat PTAL

@baude @mheon PTAL
config management will now be in c/common

Changes LGTM, but we may want to hold until after the next release.

Agree - I don't want this landing before a 1.7.x

This will not go in until 1.8 most likely.  It needs to get merged into Buildah fist to make sure Buildah and Podman do the correct thing on podman build.
Hopefully we can roll forward with this in Buildah soon.  Although I am not sure if everything works correctly without a config file, and that the config files merge properly yet.
We want the default to be everything commented out if possible, and then only have /usr/share/containers/containers.conf has specific settings for a distribution.
/usr/share/containers/containers.conf, /etc/containers/containers.conf and ~/.config/containers/containers.conf need to be able to be merged correctly for this to fully work.
Also containers.conf format has to be fully agreed upon before we release.


Report modifiers of classes and methods

Sometimes it is useful to know whether it's an abstract class or a private method/etc.

Hi, @jazzmuesli! Thanks for this very useful PR!
Before merging it, can I ask you to write a few words about this new modifier attribute in the README? And, more specifically, how one can interpret this integer number (a reference to the javaassist.Modifier javadoc should work!)

Autocomplete was wrong to suggest javaassist.Modifer, java.lang.reflect.Modifier can be used - I've updated references and ModifiersTest.

Now that you said it, should we use org.eclipse.jdt.core.dom.Modifier? This is the JDK one, right?

After talking to you in person, I checked CK's codebase, and we are using Eclipse's Modifier in other classes. Although they do basically the same thing, just so that we have a standard way of doing it, would you mind changing the current code to use the Eclipse's one?

After talking to you in person, I checked CK's codebase, and we are using Eclipse's Modifier in other classes. Although they do basically the same thing, just so that we have a standard way of doing it, would you mind changing the current code to use the Eclipse's one?

Done.

Hi @mauricioaniche, could you deploy the latest version to mvnrepository as 0.3.2 ? I'll try to build/ deploy my ck-mvn-plugin. Thanks!


Draw track ties

A small change that makes the rails actually look like rails

It draws the sleepers slightly below the rails so they don't intersect.
they use 'SMALL_OFFSET/2' instead of 'SMALL_OFFSET' for the y offset.

Wondeful! It even has the wood texture!


CORS Error

Hello Matt,
using jhipster 8 beta gateway app run on docker and generate ionic app with  generate-jhppster-ionic(jhipster 7.9.3) and set cors origin in application.yaml (http://localhost:8100)  but this error exists before and after login .
but  signup and authenticate is ok .
for /api/account :::
[Error] XMLHttpRequest cannot load http://localhost:8080/api/account due to access control checks.
[Error] Failed to load resource: Origin http://localhost:8100 is not allowed by Access-Control-Allow-Origin. Status code: 401 (account, line 0)
thanks alot

Are you sure you added CORS information in the correct part of application.yml? You might look at the application-dev.yml template to see where it should be.

I believe I found the issue. Can you try adding .cors(withDefaults()) to your SecurityConfiguration class. Like this:
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
    http
        .cors(withDefaults())

This solves the problem for me. If it does for you, too, I'll create a PR to update JHipster.

Looks like the problem still exists.

Can you please share the output from jhipster info in your backend project? I did not test with WebFlux.

@mshima If I copy the .yo-rc.json file to an empty directory and run jhipster, it doesn't create the project for me. Instead, it prompts me for the baseName. This is new behavior with v8. Is it expected?

.yo-rc.json

I was able to fix it by changing from CorsWebFilter to CorsConfigurationSource. Can you try this:
@Bean
public CorsConfigurationSource corsConfigurationSource() {
    UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource();
    CorsConfiguration config = jHipsterProperties.getCors();
    if (!CollectionUtils.isEmpty(config.getAllowedOrigins()) || !CollectionUtils.isEmpty(config.getAllowedOriginPatterns())) {
        log.debug("Registering CORS filter");
        source.registerCorsConfiguration("/api/**", config);
        source.registerCorsConfiguration("/management/**", config);
        source.registerCorsConfiguration("/v3/api-docs", config);
        source.registerCorsConfiguration("/swagger-ui/**", config);
        source.registerCorsConfiguration("/*/api/**", config);
        source.registerCorsConfiguration("/services/*/api/**", config);
        source.registerCorsConfiguration("/*/management/**", config);
    }
    return source;
}


Local mutual tail recursive optimization

In translated code for local mutually tail-recursive functions, switch case is incorrectly falling over instead of terminating with a break and continuing the while loop.
Failing example:
let tailRecursionOptimizerBug() =
    let rec f x =
        if x = 0 then g x 1 else f (x - 1)
    and g x y =
        x + y
    f 5

Should return 1 but returns NaN.

Another bug: arguments are not copied when in mutual tail-recursive calls a later argument needs the current value.
Failing example:
let mutualLetRecArgCopying() =
    let rec f x y z =
        if x = 0 then
            if y = 0 then g z else y + z
        else f (x - 1) y z
    and g x =
        f 0 1 x
    f 5 0 5

g loops to f with states 0, 1, 0 in translated code because the value of x is not copied before being overwritten.


Implement Harris score

fix: drawCircle options were not optional
feat: implement getCirclePoints
feat: implement isFastKeypoints
fix(isFastKeypoint): all compare values the same
feat: implement getCornerScore
fix: isFastKeypoint uses predefined points
refactor: rename getCornerScore to getKeypointScore
fix(getFastKeypoints): remove duplicate keypoints
test: add getFastKeypoints tests
docs: enhance functions doc
fix(getFastKeypoints): add nonMaxSuppresssion option
test: enhance tests
chore: fix eslint issues
docs: add getFastKeypoints demo
fix: correct things for review
refactor: rename getKeypointScore to getFastScore
fix(getCirclePoints): return ordered points
fix(getFastKeypoints): add fastRadius as parameter
fix: getCirclePoints loop
chore: fix eslint error
docs: fix level doc
feat: implement getHarrisScore
test: add getHarrisScore test
fix(getHarrisScore): x and y inverted
feat(getFastKeypoints): add scoreAlgorithm option
test(getFastKeypoints): test harris scoring
feat(getFastKeypoints): add normaliseScores option
chore: add test script for harris
test: fix harris test
test: enhance coverage

I wonder if there's a simple way to delete old image snapshots from the project. I see that your last commit adds new images (because of the rename of "normalize") but doesn't delete any.

I wonder if there's a simple way to delete old image snapshots from the project. I see that your last commit adds new images (because of the rename of "normalize") but doesn't delete any.

I was thinking the same, I also noticed the old ones were not deleted so I did it by hand for a few of them but forgot to do it this time.

I suppose that without a better idea we can do rm -rf **/__image_snapshots__ and regenerate all of them.


Peer-To-Peer Code Review

Peer-To-Peer Code Review

Nice work on your capstone project!

Thanks 😊

From: Mavericks Balitaan @.>
Sent: Friday, April 22, 2022 7:09 AM
To: IshmaelKargbo/code4easy @.>
Cc: Subscribed @.***>
Subject: [IshmaelKargbo/code4easy] Peer-To-Peer Code Review (Issue #2)
Peer-To-Peer Code Review
[giphy]https://user-images.githubusercontent.com/98527559/164624472-c655b3c5-90f3-49bf-98e7-2a87d4b068e6.gif
Nice work on your capstone project!
—
Reply to this email directly, view it on GitHubhttps://github.com/IshmaelKargbo/code4easy/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQJT5FQSHFRLC35DS43Z6U3VGJGDDANCNFSM5UBMFUXA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Use our own github topic

I suppose we have enough popularity now that we should probably add our own topic, like "spicetify-marketplace-theme" and "spicetify-marketplace-extension". That should cut down on all the 404s logged to the console from it picking up people just using the spicetify tags, when they don't have a manifest.json.

Should do it over time not immeaditey (make announcements about the transition and such)

Any news when this will come into effect?

Any news when this will come into effect?

Nope. Nobody has made any effort on this.

Not really relevant anymore.


Group capstone: set up your Kanban board

https://github.com/Kaiserabbas/Fusion-Bites/projects/1
We are a total of two people working on this project.
1 - @Kaiserabbas
2- @misikir21

Hi @Kaiserabbas , @misikir21
Approved 🍏 🟢
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Kanban board setup correctly✔✔
Cards are assigned to students :heavy_check_mark:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


support load model locally

🚀 The feature, motivation and pitch
I have downloaded the llama3-8B model from huggingface into local dir as below

But I can't run python3 torchchat.py generate --checkpoint_dir /home/Meta-Llama-3-8B-Instruct --prompt "It was a dark and stormy night, and"  since it's not a single pt file.
How should we run the pre-downloaded model in torchchat?
Alternatives
No response
Additional context
No response
RFC (Optional)
No response

Can you try to generate a .pth with this: https://github.com/pytorch/torchchat/blob/1566512baa889ef044231595b593749231ab0170/.ci/scripts/convert_checkpoint.sh#L16

Thanks a lot.
Follow the code, I found that only ".bin" files are supported in torchchat, so I have to modify the code to support ".safetensors", and I can run the local model now.

@irasin would you be able to submit a PR for docs/ADVANCED-USERS.md how to recognize and navigate this issue? Also any other issues/errors/unclear instructions you encountered?


When I do logout with wipeResources and invalidateConfiguration, I expect cache to be cleaned, but it is not

I have following service API configuration:
class MyAPI {

    static let sharedInstance = MyAPI()

    private let service = Service(baseURL: "http://localhost:9000/ws/rest/service", standardTransformers: [.text, .image])

    private init() {
        let jsonDecoder = JSONDecoder()
        service.configure("/beacons") {
            $0.expirationTime = 60 * 60 // 1 hour
        }
        service.configure("**") {
            $0.headers["Authorization"] = self.basicAuthHeader
        }
        service.configureTransformer("/beacons") {
            try jsonDecoder.decode(SearchResults<Beacon>.self, from: $0.content).ibeacons
        }
    }

    func beaconList() -> Resource {
        return service.resource("/beacons")
    }
}

basicAuthHeader & Log In / Out functionality are both implemented one-to-one like in the official Siesta GitHub browser example. So, whenever basicAuthHeader is set I wipe all service resources and invalidate configuration:
    func logIn(username: String, password: String) {
        if let auth = "\(username):\(password)".data(using: String.Encoding.utf8) {
            basicAuthHeader = "Basic \(auth.base64EncodedString())"
        }
    }
    func logOut() {
        basicAuthHeader = nil
    }
    var isAuthenticated: Bool {
        return basicAuthHeader != nil
    }
    private var basicAuthHeader: String? {
        didSet {
            service.wipeResources()
            service.invalidateConfiguration()
         }
    }

Issue is following:
I perform following list of calls:

MyAPI.sharedInstance.beaconList => 401 Unauthorized => OK
MyAPI.sharedInstance.logIn => OK
MyAPI.sharedInstance.beaconList => JSON list => OK
MyAPI.sharedInstance.logOut => OK
MyAPI.sharedInstance.beaconList => JSON list (from cache) => WRONG - my expectation that cache have to be cleaned independent from expirationTime 1 hour.

After deeper research I have found that issue was on the server side as the server first check if the session is valid and if not only then verify presents of Authorization header. As result, after logout and wiping all resources, 5th call from above sequence has finished successfully because the session was still valid. So, I got response results cached for another one hour.
Solution is to reset URL session. NOTE: that will still keep session valid on the server side. If you want to invalidate server session as well then you have to call server logout method first if it is available.
To fix my issue I have performed following changes in the code:
class MyAPI {

    static let sharedInstance = MyAPI()

    private let urlSession: URLSession  // NEW keep urlSession to have chance for reset
    private let service: Service        // MOVE initialization into init()

    private init() {

        // NEW: Init session as you like. Ephemeral is default by Siesta
        let config = URLSessionConfiguration.ephemeral
        config.timeoutIntervalForRequest = TimeInterval(60)
        config.timeoutIntervalForResource = TimeInterval(30)
        urlSession = URLSession(configuration: config)

        // NOTE: provide urlSession into Service constuctor
        service = Service(baseURL: "http://localhost:9000/ws/rest/service", standardTransformers: [.text, .image], networking: urlSession)

        // rest part of the init() code
    }

    private var basicAuthHeader: String? {
        didSet {
            urlSession.reset() {} // NEW: From Apple doc: Empties all cookies, caches and credential stores, removes disk files, flushes in-progress downloads to disk, and ensures that future requests occur on a new socket.
            service.wipeResources()
            service.invalidateConfiguration()
        }
    }

    // rest part of the class

}

Proposal:

Add to Service class session reset method;

I’m glad to hear you figured this out.
 Is your server using cookie-based sessions? Was URLSession caching your credentials somehow? Or was the problem something else?
(I’m wondering whether there’s anything here that needs to be documented better.)

Our Java server uses embedded Jetty. First class which comes to the game is AuthenticationFilter, which makes following in doFilter:
        if (httpSession != null && httpSession.getAttribute(USER_CONTEXT_KEY) != null) {
            // already authorized, nothing to do anymore
            chain.doFilter(req, resp);
            return;
        }

        if (!checkAuthorization(request, response, chain)) {
                return;
        }

So, the Authorization header is not validated so far that special key is stored in a session.
In Siesta URLSession class is hidden inside and there is not much control over it.
YES, it would be nice to have either better documentation around session management or small set of functions to manipulate with it without keeping its own reference in ServerAPI class as in my workaround above.

Without knowing your particular Jetty configuration, we can’t know for sure how you’re told it to track your httpSession — but it’s probably cookie-based, in which case it’s up to you to configure your URLSession to store or not store the cookie as you want it to. (Alternatively, you can disable URLSession cookie handling entirely and then manually manage the Cookie header yourself.)
I’ll add a note in the documentation about cookies being managed by the underlying network provider.


[Auto-generated] Update dependencies

Update dependencies
Automatically created PR from ci/dependency-updates.
The PR is based on the 'CI - Update dependencies PR' workflow in SINTEF/ci-cd.
To do

[ ] Check that the diff is sensible, and that tests and builds pass with the new dependency versions.
[ ] Make sure that the PR is squash merged, with a sensible commit message.

Codecov Report

Merging #151 (36e9e7e) into main (3644b7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   76.19%   76.19%
=======================================
  Files          15       15
  Lines         605      605
=======================================
  Hits          461      461
  Misses        144      144

Flag
Coverage Δ

linux
76.19% <ø> (ø)

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.


Cataract Disease detection using Machine learning

Is your feature request related to a problem? Please describe.
Cataract is an eye disease (called Motiyabindu in Hindi Language) is a disease frequently seen in old age people frequently as well as in some middle age people. Early remedial measures are necessary to cure it, otherwise human may loss their entire eyes and this may lead to anger and depression. Hence this new project feature involves detecting cataract earlier by simple image or webcam input of eye images .
Describe the solution you'd like
The model will be trained using CNN or YOLO V8 model using given Kaggle dataset on Cataract :
https://www.kaggle.com/datasets/sheemazain/cataract-classification-dataset-in-ds
i will prepare a proper Ipynb notebook using all data science and DL steps, EDA and visualizations and insights
please assign this issue (new feature ) to me as a GSSoc'24 contributor along with Gssoc label and level

@RajKhanke  assigned!


WIP: Add log messages to frames (2)

In my opinion, there is no need for PR #115 to be blocking the implementation of this feature.
So as a first step, I've taken the work done in PR #119 and made it independent of PR #115. The work done in PR #115 can be completed at a later time.

[x] Fix the tests
[ ] Test and check that everything works as expected with the CLI (and maybe add some tests?)
[ ] Add support for log messages in log and report command
[ ] Add documentation

Please note that I do not use watson with the CLI at all and mainly use watson through the Watson and Frame classes. So any help and review to improve this part of the implementation is very welcomed.

@jmaupetit @jnsebgosselin  For the last year this feature has become stalled a few times and is having trouble getting merged.  In light of that, what do you think about merging this as-is?  It looks good to me.
The critical parts are here: basic tests, documentation, and the parameter on stop.  People can follow up with separate PRs for the other features, like enhancing log and report.
I feel like merging this basic functionality will help us gain momentum on this feature, as opposed to waiting for one giant pull request that addresses everything (perfect tests, complete documentation, all commands enhanced to support messages).

I do not agree with this strategy. If @jnsebgosselin agrees (and you have time & motivation for this), why not taking the lead on this?

I'm 100% OK if someone want to take the lead with this!
The thing is, I do not use the CLI at all. I use Watson inside a GUI I've made, in which I expanded Watson with the features proposed here. So the motivation to work on the CLI and its documentation is not very high for me.

@jnsebgosselin Ok.  I will fork this draft and add support for the report and log commands.  Thanks for letting me use your initial work as a starting point.
I'm not sure how soon I'll be able to find the time, but this is highest on my of enhancements I'd like to see to watson.

@jmaupetit I've copied @jnsebgosselin 's branch and duplicated this PR in #337 .  More discussion and questions are over in issue #93


Has this logic been added?

Above you write: "During the delay calculation, new logic will be added" - has this happend to date? From what version on is that available?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08f6ecb2-3b60-ec64-f1ae-66fe973dfb14
Version Independent ID: bf15ecc2-7f3c-eaff-f872-77c19d83130d
Content: Safety stock fulfillment for items - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/master-planning/safety-stock-replenishment.md
Service: dynamics-ax-applications
GitHub Login: @roxanadiaconu
Microsoft Alias: roxanad

@ConradVAva, thanks for posting this! In the meantime, to get product help you can contact Support using one of the options described here: Support contact options. In particular, you might want to go to the Dynamics 365 for Finance and Operations community page to get help with your questions from the Dynamics community.
@FrankDahl, please review this feedback and provide updates, if needed.

Bug 298713 has been logged to track this issue.

Yes, this functionality is in the current version of F&O. The functionality was added with 8.0 for sure, might also be available with 7.3 - would require some investigation to find the exact version number.


Add draft order validation in DraftOrderComplete mutation

Do not allow to perform DraftOrderComplete mutation for not draft orders.
Running DraftOrderComplete for normal order was raising an error.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4734 Draft order finalize can raise IntegrityError


Null values failing string validation rules such as 'max'

Hi,
Not sure if this is expected behaviour but when I validate against null values, tests such as "max" fail.
For example if I validate an address, which has an optional address line 2 (null in the database) and give it a max:255 rule, it will fail the test and return "the field must be max 255 characters" (when it is clearly empty/null).
I would still like to validate the field if there happens to be something there, but also somehow treat null strings as empty when it comes to these tests? Any suggestions?

Hi @neutralrockets
Thanks for bringing this to my attention.
Apologies for the delay in response.
Ideally, I think, a flag might be appropriate to tell a test to ignore null values.
I'll fix the issue and respond A.S.A.P.

Added ignoreNull property for handling null values.
Usage:
Test will pass
var rules = {
    required: true,
    email: true,
    ignoreNull: true
};

var result = approve.value(null, rules);

Test will fail
var rules = {
    required: true,
    email: true
};

var result = approve.value(null, rules);


Pin flutter version to 3.13.3 in integration test

#skip-changelog
:scroll: Description

On linux an expected file app.so is missing in the integration test. Last successful check was with flutter 3.13.2. Check if the flutter version was the culprit.
:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

The flutter version was not the culprit, closing.


Date cut-off issues

Analyse page: practices start at Feb 13 (as they should) but with no data for first 2 months. CCGs start at Aug 13.
Dashboards: for practices, standard measures go back to May 2012 (though the low-priority measures are OK).

Notes so far (am currently stymied by server being offline)
Practices analyse page makes requests for:

https://openprescribing.net/api/1.0/spending_by_practice/?format=json&code=0703021Q0BB&org=99P

This returns no data from 2013_02 or 2013_03, but does for remaining 58 months up to 2018_01

https://openprescribing.net/api/1.0/org_details/?format=json&org_type=practice&keys=nothing&org=99P

This returns data for all 60 months up to 2018_01

The spending_by_practice endpoint queries frontend_prescription, and it looks like we're missing some (but not all) data from 2013_02 and 2013_03:
# select min(processing_date) from frontend_prescription where pct_id = '99P';
┌────────────┐
│    min     │
├────────────┤
│ 2013-04-01 │
└────────────┘

but:
select min(processing_date) from frontend_prescription;
┌────────────┐
│    min     │
├────────────┤
│ 2013-02-01 │
└────────────┘

In BigQuery, we don't have any data older than 2013_04 for CCG 99P:
SELECT
  min(month)
FROM
  hscic.prescribing
WHERE
  pct = '99P'
~~~
2013-04-01 00:00:00.000 UTC

And yes: this CCG was formed in April 2013:
>>> PCT.objects.get(pk='99P').open_date
datetime.date(2013, 4, 1)

So nothing to worry about here.  (There may be a separate issue about how we communicate CCG opening/closing on the analyse page.)

The CCG page makes requests to:

https://openprescribing.net/api/1.0/spending_by_ccg/?format=json&code=0703021Q0BB
https://openprescribing.net/api/1.0/org_details/?format=json&org_type=ccg&keys=nothing

Both these endpoints return data for all 60 months from 2013_02 to 2018_01.
So is the JS deciding only to show 55 months?

Notes from me:

There shouldn't be any data before a certain date in 2013 for any CCGs (they were all created in 2013)
so that is expected behaviour (see e.g. here, though I can't remember why CCGs were created in April but no data expected til August, according to that code...)
Although CCGs were only formed in April, the practices existed before that, so we should still expect data for the first two months in, say, this chart
On the CCG page linked to in the issue, I can see data for 60 months as expected, so don't understand your reference to 55 months?

There shouldn't be any data before a certain date in 2013 for any CCGs (they were all created in 2013) so that is expected behaviour

Yes, all data in frontend_prescribing with processing_date < '2013-04-01' are for PCTs.

see e.g. here, though I can't remember why CCGs were created in April but no data expected til August, according to that code...

When we discussed this on the train, @sebbacon wasn't sure whether August 2013 was doing in the code, and whether it was a mistake (and that we'd meant April 2013).  Seb, should I change August to April?

Although CCGs were only formed in April, the practices existed before that, so we should still expect data for the first two months in, say, this chart.

There's no data before April in that chart.  Presumably this is because the CCG has no data from before April.  This is a bug -- we should be able to show a practice's data from its old PCT or CCG, and I'll try to make sure it's fixed as part of #739.

On the CCG page linked to in the issue, I can see data for 60 months as expected, so don't understand your reference to 55 months?

In this chart, data begins at 2013_08 and ends at 2018_01, which is 55 months.

This is a bit more of a big deal now, as with the merged practices, the data doesn't go back before May 2013, but the rest of the deciles do, making it more obvious:

https://openprescribing.net/ccg/14Y/

This is a new problem, and I've opened #907 to discuss.

I think the only outstanding problem discussed here is that analyse queries that highlight a CCG or CCGs only show data going back to August 2013, while all other queries (now) show data going back five years.
I've created #920 to track this.


Don't stop everything on stderr

Hey there! So I'm sure there is a more elegant way to handle this, but I'm seeing that having "compiler warnings" is enough to cause the provider to stop, and it won't start again until I reload vscode. So ideally we'd just log that something bad happened, but keep trying/not stop everything, right?

hey thanks @zachdaniel I'll look into it in the evening or tomorrow morning, thanks for you contribution


Error logged during startup

Platform
Raspberry Pi 5 running Bookworm
Node.js Version
18.19.0
MagicMirror Version
2.25.0
Module Version
ac9856b37c5729631c23b8e628543c7a44433481
Description
After starting MagicMirror error shows in the log and there is no radar, just the map
Expected behavior
Radar overlay should show on map
Current behavior
Radar layer is missing
Possible solution
No response
Steps to reproduce
Start MagicMirror
Wait for everything to load
Review RAIN-MAP
Missing radar layer
Check Log and see error
Log
MMM-RAIN-MAP.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead rename MMM-RAIN-MAP.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in /home/vvrangler/MagicMirror/modules/MMM-RAIN-MAP/package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead).

config.js
{
			module: "MMM-RAIN-MAP",
			//position: "bottom_right",
			position: "middle_center",
			//position: "fullscreen_below",
			hiddenOnStartup: true,
			config: {
				animationSpeedMs: 300,
				invertColors: true,
				colorScheme: 4,
				colorizeTime: true,
				defaultZoomLevel: 9,
				displayTime: true,
				displayTimeline: true,
				displayClockSymbol: false,
				displayHoursBeforeRain: 4,
				extraDelayLastFrameMs: 1000,
				extraDelayCurrentFrameMs: 1000,
				markers: [
					{ lat: 38.673110, lng: -120.997270, color: "red" },
					{ lat: 38.658850, lng: -121.150120, color: "blue" },
					{ lat: 38.732590, lng: -120.703780, color: "blue" },
					{ lat: 37.679350, lng: -121.042760, color: "blue" },
					{ lat: 39.523260, lng: -121.577750, color: "blue" },
				],
				mapPositions: [
					{ lat: 38.673110, lng: -120.9972707, zoom: 10, loops: 4 },
					{ lat: 38.673110, lng: -120.9972707, zoom: 9, loops: 3 },
					{ lat: 38.673110, lng: -120.9972707, zoom: 8, loops: 3 },
				],
				mapUrl: "https://a.tile.openstreetmap.de/{z}/{x}/{y}.png",
				mapHeight: "2500px", // must be a pixel value (no percent)
				mapWidth: "1440px", // must be a pixel value (no percent)
				maxHistoryFrames: -1,
				maxForecastFrames: -1,
				substitudeModules: [],
				updateIntervalInSeconds: 300,
			}
		},

Additional info
Thank you

Hi @vvrangler
which Node.js version do you use?
npm -v

I don't have that problem here with Node.js version 20.4.0
Can you try to upgrade your version?

Updating to 20.4.0 worked. Thank you!


Reorder arguments for future enhancements

Realized last night it would make more sense to have the application as the first argument such that this could be easily augmented for additional configuration.

Coverage remained the same at 100.0% when pulling 15b76dc01a275f3f052a65477692baf98371af69 on argument_order into 6917f9cbe4a1314447235d4a123fbbd592517862 on master.


Remove schema.rb

This project has used schema_format = :sql since 52dd99fbe955490a6959b4404998b3984835ff36 (#151), so having schema.rb in addition to structure.sql is really confusing.

Coverage remained the same at 99.368% when pulling d83884f70e59c292d6cc7187cec2772789eebd67 on appropriate:remove-schema-rb into fbdd8054493a1afec4e359c56de909b06c1e20c1 on codeforamerica:master.

Agreed. Thanks!