GAT2021 Followup Overhaul

Bugfixes for https://github.com/galaxyproject/training-material/issues/2274
Admin Training: Automated
This branch includes numerous fixes for the admin training topic, collected from GAT2021:Online, but it also starts the project of automating GAT.

We now use diffs throughout the admin training series
These can be pulled out and added together, to build the full admin training playbooks
This is automated in https://github.com/hexylena/git-gat
From this we're generating screencasts of the GAT tutorials https://github.com/hexylena/auto-gat
Which will be (somehow) included back into the GTN
And then from that we'll be generating videos.

add mod_zip, thanks @mvdbeek @lldelisle  https://docs.galaxyproject.org/en/latest/admin/nginx.html#creating-archives-with-mod-zip

update tiaas role if not done already

Update: There is a new Github Action which automatically rebuilds https://github.com/hexylena/git-gat on any commit to the admin topic. Neat. Now we don't have to worry about keeping that up to date.

Proposal
Instead of a fancy button that makes diff 'fixed' for copying one by one, how about we just "fix" them all, automatically. It won't be proper diff format anymore (but is anyone really using those directly and running patch?)
$("div.language-diff pre code .gi,div.language-diff pre code .gd").each((x, e) => {
  var fixed = $(e).text().split('\n').map(q => { return q.slice(1) }).join('\n');
  $(e).text(fixed);
})

fixes all of the snippets:

before
after

do I want a button that does it? yes. But will this also work on short notice? Also yes.

Ok, I think we've got most everything addressed from https://github.com/galaxyproject/training-material/issues/2274
There's a couple of remaining things in there that can be pushed to later, but it's time to start reviewing and testing, and getting this pr merged.
Please try and note which tutorials you think need to be re-recorded. By my estimate:

ansible-galaxy (we dropped a whole step)
pulsar (we use vault now)
singularity (this is the one that gave EVERYONE problems)
ephemeris (a number of tools changed)

Reviewers

There have been very few text changes in the tutorials, I would encourage focusing on the automatically extracted git-gat, does everything work there
Ignore the video scripts until the future.

ansible-galaxy's tests are passing!!!!!!

singularity's playbooks run (without a test case),  also we hit https://github.com/sylabs/singularity/issues/68 so which fork do we use? I'm confused.

tutorial
playbooks
tests

ansible-galaxy
:heavy_check_mark:
:heavy_check_mark:

singularity
:heavy_check_mark:
missing

tool management
n/a
missing

cvmfs
:heavy_check_mark:
added + passing

data libs
:heavy_check_mark:
missing

connect-to-compute
:heavy_check_mark:
missing

job-destinations
:heavy_check_mark:
missing

pulsar
:heavy_check_mark:
missing

but I did something dumb with the galaxy systemd, it doesn't behave nicely if you just want to e.g. set the env, rather than also setting that it should be mules. That's what I get for using dictionaries instead of just a bazillion variables.

@natefoo @Slugger70 that's all I have energy for, hope y'all can get the ball across the line on this one.

@Slugger70 would you be up for re-recording singularity + pulsar (since we use vault now)?
@natefoo would you be up for recording the ansible-galaxy tuto?
@cat-bro since you've made a couple changes, do you want to re-record ephemeris? Is it worth doing?

(or any other mixture of people recording but yeah.)

@hexylena I'll be rerecording the ephemeris stuff
A note on git-gat: I'm currently running it on one of the gat machines and I needed to update the cache before it was able to install packages.  I'm not sure if this belongs in the playbook or the bootstrap.
A note on the ephemeris tutorial: I'm currently failing to install things on my gat machine with bioblend.ConnectionError: HTTPSConnectionPool(host='gat-2.oz.training.galaxyproject.eu', port=443): Max retries exceeded with url: /api/tools?in_panel=True&key=45fc909559337090b1969c4abcb80e9c (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)'))), 0 attempts left:. I don't think this came up in January.  I'll have a go at troubleshooting this later on today.

@cat-bro amazing, thank you!
Weird about the cache update. I had to switch the machines to the Ubuntu
repos in NZ again, the Aussie ones didn't work for me again and I don't
know why.
Weird to see that error. Galaxy-wait worked after I added the updated LE
fake root certs, I would have expected bioblend to, too.
Op vr 4 jun. 2021 06:51 schreef cat-bro @.***>:

@hexylena https://github.com/hexylena I'll be rerecording the ephemeris
stuff
A note on git-gat: I'm currently running it on one of the gat machines and
I needed to update the cache before it was able to install packages. I'm
not sure if this belongs in the playbook or the bootstrap.
A note on the ephemeris tutorial: I'm currently failing to install things
on my gat machine with bioblend.ConnectionError:
HTTPSConnectionPool(host='gat-2.oz.training.galaxyproject.eu', port=443):
Max retries exceeded with url:
/api/tools?in_panel=True&key=45fc909559337090b1969c4abcb80e9c (Caused by
SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED]
certificate verify failed: unable to get local issuer certificate
(_ssl.c:1123)'))), 0 attempts left:. I don't think this came up in
January. I'll have a go at troubleshooting this later on today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/galaxyproject/training-material/pull/2371#issuecomment-854356299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADP7O2TFLET6CGS5F3HWKTTRBLVBANCNFSM4XUUJJ4Q
.

Looking through the scrollback I can see that galaxy-wait did work perfectly during the run of .scripts/1-ansible-galaxy-run.sh but no longer does.
ubuntu@gat-2:~/git-gat$ galaxy-wait -g https://gat-2.oz.training.galaxyproject.eu -v
[00] Galaxy not up yet... HTTPSConnectionPool(host='gat-2.oz.training.galaxyproject.eu', port=443): Max retries exceeded with
[01] Galaxy not up yet... HTTPSConnectionPool(host='gat-2.oz.training.galaxyproject.eu', port=443): Max retries exceeded with

Galaxy is running and logs look fine

@cat-bro fixed, something was wrong with the certificates but can't tell what. The LE fake roots x1 and x2 were there (one had an unexpected filename, .pem.crt, both should have been .crt) so I'm suspicious that they didn't get deployed properly. I re-ran that task from bootstrapping and it works now.

I cannot explain it working initially, that's,, interesting.

@hexylena thanks for fixing!  scripts/1 was run, followed by scripts/2, followed by my installing ephemeris in a virtual environment.  Whatever went wrong happened sometime after the end of scripts/1.  That .pem.crt file is a fake one that I added to try to fix it.

The problem seems to arise from installing ephemeris in a virtual environment when it is already installed globally.  This time it's only broken within the virtual environment.  The first time it broke globally as well, no idea why.

Ahhhh that could make sense. It was installed globally as part of the testing process.
Should we just install it globally? skip the venv step then?

Would it be safer if git-gat had a venv for its requirements?  If it's installed globally there's a chance that a student would create the ephemeris_venv and break it.  The ephemeris_venv is also part of the data libraries tutorial

@natefoo @Slugger70 that's all I have energy for, hope y'all can get the ball across the line on this one.

@Slugger70 would you be up for re-recording singularity + pulsar (since we use vault now)?
@natefoo would you be up for recording the ansible-galaxy tuto?
@cat-bro since you've made a couple changes, do you want to re-record ephemeris? Is it worth doing?

(or any other mixture of people recording but yeah.)

Hey @hexylena - I will re-record singularity and pulsar as soon as this PR is merged.

@Slugger70 approved so I'm going to merge this. We'll put everything else in a new PR(s) but should be easier to contribute once this huge chunk is meged.

Nice job @hexylena 🥇


LPBA Dice score

Hello, the code to calculate Dice simply uses "eg1 > 128 and seg2 > 128" (in function 'mask_metrics'), but the LPBA dataset has 56 segmented anatomical structures. How could I calculate the Dice for LPBA?

See these lines for the evaluation code on LPBA.


Windows download link please..

Required prerequisites

[X] I have read the documentation https://nvitop.readthedocs.io.
[X] I have searched the Issue Tracker that this hasn't already been reported. (comment there if it has.)
[X] I have tried the latest version of nvitop in a new isolated virtual environment.

Questions
Windows download link please..

Hi @Drhicom, you could install a Python distribution and install nvitop via pip.
choco install python --yes
python3 -m pip install --upgrade pip setuptools
python3 -m pip install nvitop
python3 -m nvitop


Multiple gifts

Need an advanced option on the create gift screen where you can enter a number. E.g. 5 for 5 gifts. The amount will remain the same that is entered on the main screen. The entry modal can be as simple as for custom priority
Once a number is entered, it shows on the gift screen like a simple indication that this is 5 gifts being created.
On the next success modal also an indication of how many of those gifts are created. And when user clicks send, it is only one of the gift that is picked up for send.

We will be creating 100 gifts of 10k each. The app should be able to do that. @Parsh @cakesoft-shashank

https://xd.adobe.com/view/e8259038-6a8a-4b4f-b88f-780e311438a5-bd76/screen/7b80e533-289b-466c-ab83-88825bcb68e1/

Verified this issue on staging app v2.0.5(382)


Update peer-dependency for upcoming Ionic2 beta 12

Mainly:
Angular2@rc6 => rc7
<EMAIL_ADDRESS>beta 11 => beta 12
zone.js @0.6.17 => 0.6.21
Which Ionic Version?  for upcoming 2.0 beta 12

Hello! Thanks for using Ionic! This is actually already being handled on the ngmodule-build branch.


Cannot validate array elements

I can validate nested objects, and I can make sure that certain property is an array. However, the validator does not care if the elements in the array are valid or not. What am I forgetting here?
export class Album {
  @IsString()
  @Expose()
  @IsDefined()
  name!: string;
}

export class Photo {
  @IsNumber()
  @Expose()
  @IsDefined()
  id!: number;

  @Expose()
  @IsDefined()
  @IsArray()
  @Type(() => Album)
  albums!: Album[];
}

const object = {
  name: "Juan Ramon Riquelme",
  albums: [{
    noName: "Felipe"
  }]
}

// This line succeeds, but it should fail!
transformAndValidate(Photo, object, {
    transformer: { excludeExtraneousValues: true },
    validator: { forbidUnknownValues: true }
  }).then(console.log).catch(console.error);

I have written a complete reproducer and pushed it here: https://gitlab.com/albertodiazdorado/class-transform-validator-issue
To reproduce:
git clone https://gitlab.com/albertodiazdorado/class-transform-validator-issue.git
pushd class-transform-validator-issue
yarn install # or npm install
yarn start   # or npm start

Search for class-validator solution like each: true or @ValidateNested

@MichalLytek that was the solution, thank you very much!
I fixed the example by adding the decorator
@IsInstance(Album, {each: true})

to the albums field. Works like a charm.
PS: And thank you very much for the quick answer!! :D


Any ideas on subspacing components with render props?

I have certain components that have render props. Here's an example:
<SubspaceProvider mapState={state => state.myTable} namespace="MY_TABLE">
  <Table
    rows={[...]}
    renderRow={data => {
      return (
        <TableRow>
          <FooCell foo={data.foo}>
          <BarCell bar={data.bar}>
        </TableRow>
      );
    }}
  />
</SubspaceProvider>

My table component is in a subspace, so that it has a reducer which can handle its own selection logic, but those rows are being rendered inside the subspace, and they need to have their parents redux context.
Right now I subspace each row using subspace((_, rootState) => rootState), but this clearly sucks. For one thing it makes the strong assumption that the parent state selector is the root state selector, which is rather limiting. For a second, there's no way to do anything similar with action namespaces.
Do the authors have any thoughts as to how this might be supported, or if it is worth supporting?

I am aware that the obvious answer is that if the parent component itself does the rendering the components will be in its subspace, which is by far the cleanest thing from subspace's perspective. There are however plenty of good reasons to use render props, and in this case it's indispensable to the table patterning.

Seems like it should be easy enough to copy the rootStoreEnhancer patterning to create something like a parentStoreEnhancer, and then offer some sort of container that grabbed parentStore and used it for everything (getState and dispatch)

Hey @conartist6,
As you are aware, this is not something that is currently supported.
This sounds a bit similar to the desired outcome of #83.  In that proposal, you could mark a SubspacProvider with a transparent={true} prop and any children subspaces would skip it and use its parent as the parent store.  This feature would be ideal for components that need a bit of state for their own purposes but doesn't make sense to introduce a whole extra layer to the state tree.
The main difference that I can see between the scenario in the #83 and your is that the children you are passing as render props aren't necessarily wrapped in SubspaceProviders themselves.  You could fake it with something like:
<SubspaceProvider mapState={state => state.myTable} namespace="MY_TABLE" transparent={true}>
  <Table
    rows={[...]}
    renderRow={data => {
      return (
        <SubspaceProvider mapState={state => state}>  // because it's parent is `transparent` the state would be the the state you want
          <TableRow>
            <FooCell foo={data.foo}>
            <BarCell bar={data.bar}>
          </TableRow>
        </SubspaceProvider>
      );
    }}
  />
</SubspaceProvider>

I'm not a big fan of this as faking the subspace structure is what led to the #83 proposal in the first place.
Your suggestion of adding a parentStoreEnhancer and effectively a reverse subspace is interesting.  The parentStoreEnhancer is something that has existed in many branches before as it's almost been required a few times during development, so I'm more than happy for something like that to exist.  The reverse subspace container (ParentSpaceProvider?) is not something I've considered before, but on the surface, it sounds like an ok escape hatch in these situations. I'm imagining something like:
<SubspaceProvider mapState={state => state.myTable} namespace="MY_TABLE">
  <Table
    rows={[...]}
    renderRow={data => {
      return (
        <ParentSpaceProvider>
          <TableRow>
            <FooCell foo={data.foo}>
            <BarCell bar={data.bar}>
          </TableRow>
        </ParentSpaceProvider>
      );
    }}
  />
</SubspaceProvider>

Or perhaps Table would use it internally when calling the render prop?
As you suggested, parentStoreEnhancer would be more or less the rootStoreEnhancer but just sticking the store into a parentStore key.  The ParentSpaceProvider component would also be very similar to the SubspaceProvider component, but instead of creating a subspace to pass down the context, it would just grab the parentStore off the store and pass that down (probably falling back to the original store if there is not parentStore value).
Feel free to think up a better name for ParentSpaceProvider.
I guess my only concern is whether or not this actually fits with design goals of the library.  This introduces some knowledge into the child component that it exists within a subspace.  In the case of render props, this is less of a concern as the parent is specifying which of its children belong to the subspace and which don't but the existence of the component means that it will be abused by people wanting to just traverse up and down the tree at will to find the exact piece of state they're after.  One could argue that this is already possible with the rootStore parameter of the mapState function (to traverse down at least), so maybe this is not a big issue.
I'd be interested get @jpeyper's take on it.  He's usually pretty good at whether something feels right in these situations.  He's on holiday at the moment and may not get to this soon though, so if you want to take a run at it in the meantime and get a PR up, I think it should be fine.

I wrote the PR and I should have time to polish it up and submit it today. The second example in your response above is almost exactly what I wrote in the documentation for what I called ParentSubspaceProvider. I agree that in the example Table shouldn't know that it's in a subspace, which means that the render prop would definitely have the parent provider at its top level.

Are you ever truely on holiday in this world?
My feeling is that you hit the nail on the head, this doesn't fit the design goals.
But those design goals are utopia, and in the same vein as global actions, sometimes the child needs to be subspace aware. In these scenarios, it

Sorry, accidental close. My phone and holiday brain are a bit clunky.

Thanks @jpeyper, that reflects my thoughts quite nicely as well.  @conartist6, consider this the green light on the feature.  Can't wait to see a PR 😄


1.2 only: add a note to manually move pods if necessary

Summary and Scope
Add manual check before we rebuild/upgrade a worker node.  Note that this is only for 1.2 and in future releases, this issue would be addressed by code.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMINST-4748
Change will also be needed in <insert branch name here>
Future work required by [issue id](issue link)
Documentation changes required in [issue id](issue link)
Merge with/before/after <insert PR URL here>

Testing
List the environments in which these changes were tested.
Tested on:

<development system>
Local development environment
Virtual Shasta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

/backport main


AVRO-2979: Pin PHP dependency tools to specific versions

Make sure you have checked all steps below.
Jira

[X] My PR addresses the following Avro Jira issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"

https://issues.apache.org/jira/browse/AVRO-2979
In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason: Fixes the build.

Commits

[X My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain Javadoc that explain what it does

Included in https://github.com/apache/avro/pull/987


More than one bracketed var on the same line shows as a error

Steps to reproduce
Using a buffer with ft=tmux assign a var something like the follow:
var4=${_var1}${_var2}
See the error.   This appears to be valid syntax.
Also, see screenshot with the above, valid syntax assignments, and  other valid failing lines.
var1=$_var3
var2=$_var3$_var4
var3=${_var1}$_var2
var4=${_var1}${_var2}    # not an error
var4=${_var1}${_var2     # valid error
var5=foo
var6=bar
var7=${_var3***}         # valid error
var8=${_var3}

# vi: set ft=tmux:

Init. guess is this too greedy? https://github.com/ericpruitt/tmux.vim/blob/master/vim/syntax/tmux.vim#L40
Expected behaviour
For  var4=${_var1}${_var2}  to not show as an error.
Version of Vim
9.1.703
Environment
kitty (913ce58fe) via macOS 14.6.1 ssh'ed to FreeBSD 14.1 inside tmux with TERM=screen using bash 5.2.32.
Logs and stack traces
No response

try this
https://bit.ly/4e4zLlq
select the desired compiler in the installer

have you reported it upstream? @ericpruitt please

@derekschrock, I don't understand why you filed the bug here. You clearly found my canonical repository since you've linked to it, and since that's where the canonical code is, that's where the issue should've been opened. This is also outlined in Vim's contribution guidelines:

If you find a problem with one of these files or have a suggestion for improvement, please first try to contact the maintainer directly. Look in the header of the file for the name, email address, github handle and/or upstream repository. You may also check the MAINTAINERS file.

Please open this issue in the appropriate repository, and I will follow-up there.

closing here then.

Doh. Sorry I was half asleep. I thought I was in the correct repo. Would explain why I was confused with vim/vim popping up.


UsingDecl  -> TsUsingDecl

Describe the bug
Using swc from a Rust project, complains that UsingDecl isn't handled.
Expected behavior
If it is a typescript-specific type, would it make sense to name it *Ts*UsingDecl to be in line with the current naming scheme of prefixing these types with Ts?
Version
0.75.46 -> 0.76.7
Additional context
cc @l4yton
Related issue: #7322

https://github.com/swc-project/swc/issues/7316


fix: lint only staged files

Type of change (Remove other not matching type)

Bug fix (non-breaking change which fixes an issue)

Describe the changes you have made in this PR -
The typescript compiler currently checks all ts files on pre-committing. This should just be the staged files.

nit: I guess it's a chore not fix, but great you took care of it

Changed that, gotta get used on when to use chore  :p

@pavanjoshi914 fyi


xsens_driver: 2.2.1-0 in 'indigo/distribution.yaml'

Increasing version of package(s) in repository xsens_driver to 2.2.1-0:

upstream repository: https://github.com/ethz-asl/ethzasl_xsens_driver.git
release repository: https://github.com/ethz-asl/ethzasl_xsens_driver-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.6
previous version for package: 2.2.0-0

xsens_driver
* fix frame reorientation (only for orientation and linear velocity)
* fix skip-factor command line (#80 <https://github.com/ethz-asl/ethzasl_xsens_driver/issues/80>)
* Contributors: Francis Colas

this looks superseeded by https://github.com/ros/rosdistro/pull/18708. Please close outdated PRs in the future. Thanks!


Queue

Related Issue
Info about the related issue
Different operations related to binary search tree added
✅DevIncept Participant
Contributor
Closes: #29
Describe the changes you've made
Added Queues program code in Python
Type of change
What sort of change have you made:
Bug fix (non-breaking change which fixes an issue)
✅ New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Code is run multiple times with different inputs and test cases and output is verified.
Checklist:
My code follows the guidelines of this project.
✅ I have performed a self-review of my own code.
✅ I have commented on my code, particularly wherever it was hard to understand.
✅ I have made corresponding changes to the documentation.
✅ My changes generate no new warnings.
✅ I have added test cases that prove my fix is effective or that my feature works.

It's been 5 days since the changes had been requested, Kindly do the changes. @priyankav0107

Its been 13days since PR is created, but you haven't addressed the changes asked. I shall wait for 2 more days, if not corrected or interacted, I have no other way than to close this PR. You can't hold up a PR for so long. @priyankav0107


crashes with flexget 2.17 and deluge-client

Expected behaviour:

add magnet link to deluge. use option to rename file
Actual behaviour:
does download file, but it retains original file name. also crashes when unhandled error occurs
Steps to reproduce:

Step 1: start daemon
Step 2: flexget downloads on scheduler
Step 3: file is not renamed

Config:
tasks:
  shows:
    rss:
      url: '{? feed ?}'
      all_entries: no
    include: shows.yml
    deluge:
      path: '{? downloads ?}'
      content_filename: "{{series_name}} {{series_id|pad(2)}}"
      movedone: '{? downloads ?}/temp/'

  move-shows:
    filesystem:
      recursive: yes
      retrieve: files
      regexp: '.*\.(mp4|mkv)$'
      path: '{? downloads ?}/temp/'
    accept_all: yes
    disable: builtins
    move:
      to: '{? downloads ?}/series/'
      clean_source: 100

schedules:
  - tasks: shows
    schedule:
      minute: "*/30"
  - tasks: move-shows
    schedule:
      minute: "*/15"

Log:

(click to expand)
2018-10-18 22:30 INFO     deluge_client.client showrss         Connecting to localhost:58846
2018-10-18 22:30 CRITICAL task          showrss         BUG: Unhandled error in plugin deluge:
Traceback (most recent call last):
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/deluge_client/client.py", line 214, in call
    return self._receive_response(self.deluge_version)
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/deluge_client/client.py", line 141, in _receive_response
    d = self._socket.recv(READ_SIZE)
  File "/usr/lib/python3.5/ssl.py", line 914, in recv
    return self.read(buflen)
  File "/usr/lib/python3.5/ssl.py", line 791, in read
    return self._sslobj.read(len, buffer)
  File "/usr/lib/python3.5/ssl.py", line 577, in read
    v = self._sslobj.read(len)
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/flexget/plugins/clients/deluge.py", line 465, in on_task_output
    self._set_torrent_options(added_torrent, entry, modify_opts)
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/flexget/plugins/clients/deluge.py", line 585, in _set_torrent_options
    big_file_name = unused_name(big_file_name)
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/flexget/plugins/clients/deluge.py", line 541, in unused_name
    if self.client.call('is_localhost'):
  File "/home/$user/.venv/flexget/lib/python3.5/site-packages/deluge_client/client.py", line 218, in call
    raise FailedToReconnectException()
deluge_client.client.FailedToReconnectException

Additional information:

FlexGet version: 2.17
Python version: 3.5.2
Installation method: virtualenv pip
Using daemon (yes/no): yes
OS and version: Ubuntu 16.04.5 LTS

more info:
I was using 2.14.20 with python 2.7.12 and virtualenv install using --system-site-packages for deluge compatibility
when I saw that 2.17 supported deluge-client, I switched to using python 3.5.2 (newest available on 16.04 LTS in default repo). it does download the file but doesn't rename it. looks like deluge options are broken/not supported in deluge-client.
I am going to try install python 3.6.5 and creating a new virtualenv install with that version. it does restart the daemon as the service is supposed to restart on crash and the download finishes, it moved to the folder, but just keeping the original name.

confirmed today new entries are being renamed properly and daemon is not crashing. Flexget 2.17.1, python 3.5.2 with virtualenv.


nixos/akkoma: Do not warn under sudo-rs

Description of changes
Updated the warnings in the akkoma module, following #256491 splitting sudo-rs support into a separate module.
cc @illdefined
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux

[x] Tested, as applicable:

NixOS test akkoma, ran as-is and modified to use sudo-rs.

[x] Fits CONTRIBUTING.md.

This looks good to me.
I am not sure if it makes sense to add another test variant – the pleroma_ctl wrapper does not rely on any sudo features not implemented by sudo-rs –, but I don’t have a strong opinion on it.


Parralell processing

Implement parallel processing of multiple subjects.
Maybe with a check if things were already run?
Look at Pipelines.jl and JobScheduler.jl

as discussed, I would put this on low priority for now, given that we have parallelization already in the solver in Unfold.

Anyway, there are two main ways:

Threading (shared memory) with @threads for sub = 1:nsub or so
Distributed, where you spawn new julia processes that run a certain program.


Add small note about the period arg in snippet

Proposed changes
Was going through the tutorial, and missed some information that wasn't easily caught by the eye. I think adding a small little note could greatly improve user experience for people who are looking for a seamless introduction to docker.
Unreleased project version (optional)
Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit d0b263ca74785a635854544af14ccd07a302fc2c
https://deploy-preview-7668--docsdocker.netlify.com

@brianzhou13 I addressed your doc feedback via https://github.com/docker/docker.github.io/pull/7936. I couldn't add a commit to your PR directly since it looks like your fork of docker.github.io has been deleted.


Why implement tabbing if already trapping focus?

I’m curious why you are writing your own implementation of tabbing:
https://github.com/edenspiekermann/a11y-dialog/blob/master/a11y-dialog.js#L112
https://github.com/edenspiekermann/a11y-dialog/blob/master/a11y-dialog.js#L263-L265
https://github.com/edenspiekermann/a11y-dialog/blob/master/a11y-dialog.js#L357-L374
If you are trapping focus:
https://github.com/edenspiekermann/a11y-dialog/blob/master/a11y-dialog.js#L111
https://github.com/edenspiekermann/a11y-dialog/blob/master/a11y-dialog.js#L275-L281
And expecting a hide-able DOM structure:
https://github.com/edenspiekermann/a11y-dialog#expected-dom-structure
Why not just let native tabbing work? Also, remember that keyboard navigation is not limited to tabbing (VoiceOver uses CMD+Option+Arrow), which is also covered by your DOM structure + trapping focus.
Could this script be simplified, or is this solving another problem?

Hey,
We have 2 situations here: one is that we want to make sure the focus flow loops within the dialog. That is, when reaching the focusable element and pressing tab, getting back to the first, or when reaching the first focusable element and pressing shift + tab, going to the last. This is a mandatory behavior for a proper dialog.
The “maintain focus” thing is more like a safety net in case the focus leaves the dialog element. I can’t find a case from the top of my head. This makes sure the focus can’t be outside of the dialog while it being open.
Does it make sense?


Add back CLI guides

Preview is available here:http://developers-pr982.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr982.previews.kube001.services.stellar-ops.com

Preview is available here:http://developers-pr982.previews.kube001.services.stellar-ops.com

Yes, please merge so that we can compile! 💜


[Question]: Programming Opentitan with Jatg

I am trying to program opentitan using GDB and jtag interface. But when I run load command on gdb it gets failed. So, my question is can we program opentitan using jtag.?? Right now am testing it on verilator.

Hello,
Thank you for raising this question. For DV testing, I have not tested on TOP_LEVEL, but I think JTAG works on LC_controller (i have a pending PR here for jtag driver updates： https://github.com/lowRISC/opentitan/pull/5439). Could you share more on what kind of error you see on Verilator?
@msf for visibility.
Cindy

Hi @sajjadahmed677,
Thanks for trying out OpenTitan.
As described in the documentation, it is indeed possible to connect to OpenTitan via OpenOCD/GDB:
https://docs.opentitan.org/doc/ug/getting_started_verilator/
However, the programs are executed from the embedded flash, and write accesses to the flash memory are not memory mapped. That means that a special SW driver is be needed on the device to actually reprogram what is located in the flash memory region (basically programming word by word using the register interface of the flash controller).
Hence I would not expect GDB to be able to directly load a program into the flash region via the JTAG (@imphil @tjaychen please correct me if I am wrong).
You should still be able to debug the program via GDB, though.
Best regards,
Michael

yeah that's right. Flash cannot be directly written via memory map.
You can take a look at sw/device/lib/flash_ctrl.c to get an idea how to
actually write to it.
Although, you should be able to load the program into sram and execute from
there if that's what you want.
How does load program decide where to write..? sorry i'm not too familiar
with this area.
On Mon, Apr 12, 2021 at 6:05 PM Michael Schaffner @.***>
wrote:

Hi @sajjadahmed677 https://github.com/sajjadahmed677,
Thanks for trying out OpenTitan.
As described in the documentation, it is indeed possible to connect to
OpenTitan via OpenOCD/GDB:
https://docs.opentitan.org/doc/ug/getting_started_verilator/
However, the programs are executed from the embedded flash, and write
accesses to the flash memory are not memory mapped. That means that a
special SW driver is be needed on the device to actually reprogram what is
located in the flash memory region (basically programming word by word
using the register interface of the flash controller).
Hence I would not expect GDB to be able to directly load a program into
the flash region via the JTAG @.*** https://github.com/imphil
@tjaychen https://github.com/tjaychen please correct me if I am wrong).
You should still be able to debug the program via GDB, though.
Best regards,
Michael
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/5833#issuecomment-818350205,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSXKU5GOXFN3HLCPRATTIOKG3ANCNFSM4Z4WBHFA
.

Thank you all for your response!
the syntax of command that i am trying to run is as
load filename offset
we know that gdb reads symbols from elf file so if i give offset in this command it will add the offset value to the base address that is defined in elf file and load the file into that address.
i have tried this command on opentitan but as you mentioned flash is not physically writable yet.
i have also tried this command on my scaled down version of opentitan where i have a physically writable memory but the same issue.
 load command failed
so, my question is do i need any additional driver for writing memory through jtag or i am missing something??

this issue is resolved now. after setting proper connections to the targeted memory.


Write out an id file with ed25519 key if id_file flag is set. #415

This adds the flag and config option id_file / IDFileLocation
If set, a ed25519 pub/private keypair will get written out to the specified location. On reload of the program, a short signed message also in this file will get verified. Not doing anything with the id yet, but it should be persisted across runs.
Note with docker / k8s its up to the user to do the right thing and set this file somewhere which will persist.
Closes #415.

Is there a reason why not to just use a UUID?  Is it to validate the ID or perhaps a future config?


Issues with check-class-attributes and properties, as well as 'private' class variables

I stumbled over two problems with pydoclint 0.5.3 recently (occurs on Python 3.12 but not 3.10).
pyproject.toml:
[tool.pydoclint]
style = "google"
arg-type-hints-in-docstring = false
check-return-types = false
check-yield-types = false

mre.py:
class MinimalReproducibleExample:
    """
    Define a minimal reproducible example of check-class-attributes.

    Args:
        value: A string value.

    Attributes:
        value: A string value.

    """

    _HIDDEN = 23

    def __init__(self, value: str) -> None:
        super().__init__()
        self._value = value
        self._hidden = self._HIDDEN

    @property
    def value(self) -> str:
        return self._value

Loading config from user-specified .toml file: pyproject.toml
Found options defined in pyproject.toml:
{'style': 'google', 'arg_type_hints_in_docstring': False, 'check_return_types': False, 'check_yield_types': False}
Skipping files that match this pattern: \.git|\.tox
mre.py
mre.py
    1: DOC603: Class `MinimalReproducibleExample`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [_HIDDEN: ]. Arguments in the docstring but not in the actual class attributes: [value: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)

In my opinion:

"Private" class attributes [_HIDDEN] should be ignored just like "private" instance attributes [self._hidden].
I very much think that a property method should be documented just like an attribute.

Hi @Midnighter , thank you for your suggestion!
I've implemented both your suggestions into a new version, 0.5.4 (diff).
In 0.5.4, two new options are added:

An option --should-document-private-class-attributes (if False, private class attributes should not appear in the docstring)
An option --treat-property-methods-as-class-attributes (if True, @property methods are treated like class attributes and need to be documented in the class docstring)

Fantastic, thank you!

Hey, @Midnighter , @jsh9 , I would like to know, why properties needs to be treated as class attributes?
Is it common practice any pep for that? if anybody knows please let me know, because for now I set this new parameter to false, since it looks strange for me but I am not sure.
Thanks in advance!

Hi @kesmik ,
I've also been re-thinking about this over the past few days.  Oftentimes properties are not to be considered class attributes, because their values are not known unless we instantiate an object from it.
Therefore, I'll make a code change today to set the default value of this config option to False. (This will also restore backward compatibility.)

My point is that from a class interface/usage perspective, they are indistinguishable from attributes in most cases. How do you suggest to document properties?

My point is that from a class interface/usage perspective, they are indistinguishable from attributes in most cases. How do you suggest to document properties?

Before you made a suggestion, I used to treat them just as a method, and then I document them below the method signature.


No access to docker.sdelements.com

Hi. I have been trying to use your repository to set up a moodle container.
Using
docker-compose --file docker-compose.yml up --force-recreate --no-deps --detach
I get
Pulling nginx-php-moodle (docker.sdelements.com:443/moodle/nginx-php-moodle:7.2-3.5.1)...
ERROR: Get https://docker.sdelements.com:443/v2/moodle/nginx-php-moodle/manifests/7.2-3.5.1: no basic auth credentials
If the repo is meant to be private, I do apologize. I would suggest stating that in the repo description.

@oaeide
Apologies for the late reply, I completely missed this note.

Do you still use this container? If so, I can try to find some time to publish a version on Docker hub
Where do you suggest putting the note? I don't see any existing reference to our docker registry except in the CI configuration

Hey! No problem. I'm using the one from bitnami or moodle directly I think, so no need to stress about it :)

Thanks for the update!
I'll close this for now.


support ie 9

Hello, guys!
I need some help in the finalization of the plugin for IE 9. When I open the page in IE9 with the connected plug-in there is an error «Fail to receive the value "add" link, which is not defined or is NULL» (look at screenshot).

Thank you! Have a nice day!

If you change the line that contains classList.add('cr-boundary') to
if (boundary.classList) {
    boundary.classList.add('cr-boundary');
}
else {
    boundary.className += ' cr-boundary';
}

Does that fix the issue? I don't have IE 9, otherwise I'd test it myself.

The change corrects that mistake, but then everything went wrong. All lines with method "add" call error.

If you grab the latest from master, those utility functions should take care of your class list problems.  I wouldn't be surprised if there are other issues though.

This commit solved all class list problems, there are no more errors in logs, and my scripts work! But, as I know, ie9 does not support filereader api, and plugin displays a message about this. Thanks for your help!


x/vuln: govulncheck reports "undeclared name" for global variable declared in _test.go file

What version of Go are you using (go version)?

$ go version
go version go1.19 linux/amd64

Does this issue reproduce at the latest version of golang.org/x/vuln?
Yes (I ran go install golang.org/x/vuln/cmd/govulncheck@latest a few minutes ago).
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
...
GOARCH="amd64"
...
GOHOSTARCH="amd64"
GOHOSTOS="linux"
...

What did you do?
I ran govulncheck ./... on a more-complicated version of the code in https://github.com/derat/bugs/tree/main/golang/govulncheck-global-in-test-file.
What did you expect to see?
I expected govulncheck to run successfully and maybe print some vulnerabilities.
What did you see instead?
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
govulncheck: Packages contain errors:
.../test/lib.go:4:36: undeclared name: bar

A function in test/lib.go references a global variable declared in test/foo_test.go. The function is only called by foo_test.go.
In the real-life scenario where I saw this, the test package contains tests that exercise code across a multi-language project. foo_test.go contains the actual tests and initializes global variables needed for testing, while lib.go and other files contain helper functions that are called by foo_test.go and that reference the global variables.
I'm aware that this setup is strange (or wrong?), so this might be working as intended:

Probably the helper files should be named e.g. lib_test.go; the shorter names were used to make it clear that they don't contain the actual tests.
Perhaps the global variables should be declared in a non-_test-suffixed file.

I'm just filing an issue since go vet seems to be able to handle this scenario without printing an undeclared name error:
% go vet ./...
%

govulncheck is failing due to a type checking problem while loading.
What you are describing should be a type checking error for compiling the package test when compiling outside of go test. Say go build yourmod.com/dir/test should fail. You may want to take a look at https://pkg.go.dev/cmd/go#hdr-Test_packages .

'Go test' recompiles each package along with any files with names matching the file pattern "*test.go". These additional files can contain test functions, benchmark functions, fuzz tests and example functions. See 'go help testfunc' for more. Each listed package causes the execution of a separate test binary. Files whose names begin with "" (including "_test.go") or "." are ignored.
Test files that declare a package with the suffix "_test" will be compiled as a separate package, and then linked and run with the main test binary.

There are actually up to 4 ways a directory can define Go packages once you take into account testing and binaries. Your definitions appear to be split over 2 of these. If the test package is a testing utility package that only used from go test, you might be avoiding seeing this as as a problem.
go vet ./... not complaining is a bit surprising to me. I am guessing that the go command is sending a different list of .go files than I would expect. Speculating though.  File contents + directory structure would help here.
My general advice for you though (that does not improve govulncheck) is to make sure test makes sense as a package on its own.

Thanks for the quick reply! The test package is never compiled outside of go test, which is why this hadn't caused problems, but yes, I was surprised that the results were different between go vet and govulncheck.

 File contents + directory structure would help here.

Are you able to repro the error using the repo/directory in the initial report (https://github.com/derat/bugs/tree/main/golang/govulncheck-global-in-test-file)?
% govulncheck ./...
govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
govulncheck: Packages contain errors:
.../bugs/golang/govulncheck-global-in-test-file/test/lib.go:4:36: undeclared name: bar

% go vet ./...
%

If I add an additional reference to a variable that isn't declared anywhere, then go vet also fails:
% go vet ./...
# github.com/derat/bugs/golang/govulncheck-globals/test
vet: test/lib.go:4:29: undeclared name: baz

Are you able to repro the error using the repo/directory in the initial report (https://github.com/derat/bugs/tree/main/golang/govulncheck-global-in-test-file)?

I was. Apologies for the reading comprehension issues on my side.
For reference for others here are the relevant files.
--- test/foo_test.foo ---
package test

import "testing"

var bar = "bar"

func TestFoo(t *testing.T) { doSomething() }

--- test/lib.go ---
package test

// govulncheck fails on the next line with "undeclared name: bar"
func doSomething() string { return bar }

--- main.go ---
package main

func main() {}

On this go vet -x ./... only shows one action being taken on this snippet:
	"GoFiles": [
		"/Users/taking/tmp/i55016/bugs/golang/govulncheck-global-in-test-file/test/lib.go",
		"/Users/taking/tmp/i55016/bugs/golang/govulncheck-global-in-test-file/test/foo_test.go"
	],

If this is the only action it is not surprising that go vet is silent.
Right now govulncheck is run with packages.Config.Tests == *testFlag (false by default). This effectively treats this as only having test/lib.go. I confirmed we are only loading one x/tools/go/packages.Package for test with this config. This will not type check.
If we turn packages.Config.Tests on we will inspect the package as both [test/lib.go] and [test/lib.go, test/foo_test.go]. The first of these will crash.
The code in question is being written in a way that it does not typecheck under all usages by not considering all of the ways a test package can be loaded (See https://pkg.go.dev/cmd/go#hdr-Test_packages). The simplest solution for users is to write code that conforms to all of the ways a package can be loaded. (In this case, the test package should either always use "_test.go" or do not mix ".go" with "_test.go" for the same conceptual package.)
go vet is being appropriately generous on code that does not type check. govulncheck should print an error on [test/lib.go]. It not printing an error and silently suppressing diagnostics would not helpful.
I am somewhat tempted to just consider this as "Unfortunate" and close. The only candidate alternative I can see is to change go/packages so that it can load [test/lib.go, test/foo_test.go] to match go vet ./....

Thanks for the investigation! For whatever it's worth, I'm glad that govulncheck printed an error here since it got me to fix some weird code.

I am going to close as Unfortunate for now. We will keep an eye out for this impacting others.
I'll try to add some internal documentation about what is going on in the meantime.


Using FastText subword embeddings with Gluon

I am trying to understand how to use FastText embeddings in a Gluon model. I've been looking at this section of the documentation, but it does not address how to use the gluon.nn.Embedding layer when you have out-of-vocab words and want to take advantage of FTs subword functionality.
I do realize that I could grab the embeddings first and then feed that as input data to the model, but I would like to be able to fine-tune the embeddings during the training process as well.
Thank you for your help!

You can use the respective Block: https://gluon-nlp.mxnet.io/api/modules/model.train.html#gluonnlp.model.train.FasttextEmbeddingModel
Note that this Block takes a "Sparse array containing weights for every word and subword index." as an input. So if a your input word has index i and subword indices x, y, z, the corresponding row of the CSRNDArray should be 0 everywhere but at index i, x, y and z. At those fore indices it should be set to 0.25.
If you want to load some pretrained fasttext embeddings available via https://gluon-nlp.mxnet.io/api/modules/embedding.html#gluonnlp.embedding.create you should set load_ngrams=True and the FasttextEmbeddingModel Block will be exposed as the unknown_lookup attribute of the resulting object.
Please let me know if you have further questions.

https://github.com/dmlc/gluon-nlp/blob/5d25058a2b61fb06f6a18e39608d15a51db144d3/scripts/word_embeddings/data.py#L376-L427 provides an example how to construct the array.

Thank you for the response!
When calling FasttestEmbeddingModel.hybrid_forward via __call__, what should the weight parameter be? FasttestEmbeddingModel.weight?

Hi @charlieyou, the weight parameter will be automatically passed by the HybridBlock. You can just ignore it. It's an artifact of how HybridBlock currently distinguishes between the mx.sym and mx.nd API (which we plan to clean up in the coming months). weight will be (automatically) passed as FasttestEmbeddingModel.weight.data(ctx) or FasttestEmbeddingModel.weight.var() depending on if the Block is hybridized or not.

Great thanks! I will try this and get back to you if I have any issues

Hi @charlieyou, indeed you need to "flatten" to 2D and reshape back to 3D. For efficiency, you likely want to pad each training sample in a batch to have the same number of embeddings. For the "pad" embeddings, the CSRNDArray can just contain a completely empty row.
If you feel this work could be supported by some GluonNLP API, you would be very welcome to contribute such helper function.
Btw, instead of the SkipGram training code snippet linked above (https://github.com/dmlc/gluon-nlp/issues/879#issuecomment-522349864), this one is more appropriate:
https://github.com/dmlc/gluon-nlp/blob/5d25058a2b61fb06f6a18e39608d15a51db144d3/src/gluonnlp/model/train/embedding.py#L375-L422


Instruction differs from the lab sheet

Module: 02-Explore-developer-tools
Lab/Demo: 02
Task: Review your job history in the Azure Machine Learning studio
Step: 4, 5
Description of issue:
In the instruction file:

When the job is completed, you can find the AUC and Accuracy of the model under Metrics.
Under Outputs + logs, you'll find:

The model pickle file in the folder outputs.
The output of the script in user_logs/std_log.txt. Output from print statements in the script will show here. If there's an error because of a problem with your script, you'll find the error message here too.

However, the script does not utilize mlflow.sklearn or other equivalent logging systems to log or store models, so the Metrics and model pickle do not exist. So there is a discrepancy between the worksheet and the actual output. These concepts are only introduced in lab03 and lab10.
I could implement a fix once I go through the whole repo.

Thanks. Fixed the instructions


Update docs to use data check action methods rather than manually cleaning data

Closes #3004. Docs here: https://feature-labs-inc-evalml--3050.com.readthedocs.build/en/3050/user_guide/data_actions.html
Main docs here: https://evalml.alteryx.com/en/stable/user_guide/data_actions.html
Q: In the documentation, there's a section where we manually address errors and later show that not addressing warnings leads to worse performance. However, data check actions don't differentiate between warnings/errors and severity of the action.
We could either:

Remove this section. Reasoning being that we're showcasing actions, and this is manual cleaning
Keep as is. It's lame that the error-cleaning section is manual, but there's still a point we get across that data check warnings are important and useful to address to increase model performance
Add functionality to actions to only address / return components if we'll error out in search. I'm not fully convinced about the usefulness of this method outside of this case.

haven't taken a look at the PR itself but the string for null_row_indices is ginormous, could we alter the dataset to prodouce less null rows or truncate the list somehow?

@jeremyliweishih Yah, that's what https://github.com/alteryx/evalml/issues/3000 addresses! I'll probably pick that up this sprint too :)

@freddyaboulton @chukarsten @bchen1116 It sounds like there's no clear consensus on what's the better option here. Here are my thoughts after reading your comments:
I agree with @chukarsten's comment that we want to highlight what EvalML can bring to the table. I think adding the section about manual cleaning detracts from this since it doesn't get straight to the point of what we can provide. I'm going to move the section about addressing via make_pipeline_from_actions above the manual cleaning section.
However, we can still keep the manual cleaning section, since it could provide users with an idea of how they could address comments by looking at the output of data check actions.
LMK if you have any objections :)


Cannot find module '../cordova/metadata/ios_parser'

Dear,
when i build for iOS platform, console shows files being encrypted but in the end fail with that message:
Error: Cannot find module '../cordova/metadata/ios_parser'
Am i doing something wrong?

Same problem here!

Also getting this

Houston we have a problem!!! ;)
Same problem here!

It's a problem since the cordova v7 release as it's working fine on 6.5.0.
They decided to refractor some platform specific stuff and removed the ios_parser file.

Fixy fix #51

Merged #51. Thanks for s-s.

Shouldn't you upgrade the version number ?
After removing the plugin and installing it again I still got the old code.

Sorry. I forgot to npm publish. Please run cordova plugin add again.

Awesome, thank you !


Duet AI ML data processing prompts (no links)

Adding 3 prompts for ML data processing

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@dariabezkorovaina could you please open this PR?

@damccorm thank you, implemented! :)


Fixes some sonar issues

SonarQube analysis reported 4 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 OslpChannelHandler.java#L311: Refactor this code to not nest more than 3 if/for/while/switch/try statements.
 OslpChannelHandler.java#L394: Refactor this method to throw at most one checked exception instead of: java.io.IOException, org.opensmartgridplatform.webdevicesimulator.exceptions.DeviceSimulatorException
 OslpChannelHandler.java#L460: The Cyclomatic Complexity of this method "handleRequest" is 27 which is greater than 10 authorized.
 OslpChannelHandler.java#L1065: This block of commented-out lines of code should be removed.

All is well.

SonarQube analysis reported 4 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 OslpChannelHandler.java#L311: Refactor this code to not nest more than 3 if/for/while/switch/try statements.
 OslpChannelHandler.java#L394: Refactor this method to throw at most one checked exception instead of: java.io.IOException, org.opensmartgridplatform.webdevicesimulator.exceptions.DeviceSimulatorException
 OslpChannelHandler.java#L460: The Cyclomatic Complexity of this method "handleRequest" is 27 which is greater than 10 authorized.
 OslpChannelHandler.java#L1065: This block of commented-out lines of code should be removed.

All is well.


⚠ Bofrost.at has degraded performance

In e74383d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2867 ms

Resolved: Bofrost.at performance has improved in 9910a62.


Bancard Connector Python

I added the Bancard Connector Python SDK and its tests. It works with Python 3.4.
Also, it has already been uploaded to the PYPI repository: https://pypi.python.org/pypi/bancardconnectorpython/
Future features:

Python 2.5, 2.6, 2.7 support.
Check if it already works on all versions of Python 3.x
Integration to VPOS 2.0

Hi @vcajes, thanks for your contribution! We'll review your PR as soon as possible

Hey @vcajes, the PR has been approved. Now we're going to test the code in order to verify that it works correctly. I'll keep you in the loop! Thanks!


Error: Unexpected Token

/node_modules/markdown-it-decorate/index.js:71
  omissions.forEach((idx) => { tokens.splice(idx, 1) })
                           ^
 SyntaxError: Unexpected token >

Maybe you added coffeescript directly into an javascript file!
Should that better be:
omissions.forEach((function(_this) {
  return function(idx) {
    return tokens.splice(idx, 1);
  };
})(this));

That's what coffeescript will make out of it.

Maybe you added coffeescript directly into an javascript file!

es6 :) node 4.0 supports it.

but alright, fine, let's make it compatible for older node versions.

okay, done, released as v1.2... even node v0.10 should be able to use it.
btw: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions — upgrade your node.js ;)

That's great my production machine is debian 7 with node 0.10. I will look if it is possible to upgrade sometime.

yeah man... v0.10 is ancient by 2016 standards :p


Some clients have errors

So on a couple of my players on our SWRP server, the weapons are showing as errors, it's not every user, for example they show fine for me, but some have the issue. Not sure if the update caused this, or if something isn't downloading for everyone.

@microw111690  please supply a screenshot of the issue. Also please link your server collection.

#4


expo packages installed are not compatible with Android Gradle 7

The version of expo-linear-gradient that gets resolved through tamagui ends up being 11.2.0 which does not have the maven --> maven-publish fix in 11.0.2 (see: https://github.com/expo/expo/issues/12774 )
$ yarn why expo-linear-gradient
├─ tamagui@npm:1.0.0-alpha.68
│  └─ expo-linear-gradient@npm:11.2.0 (via npm:^11.0.2)
│
├─ tamagui@npm:1.0.0-alpha.68 [23952]
│  └─ expo-linear-gradient@npm:11.2.0 [8ac96] (via npm:^11.0.2 [8ac96])
│
└─ tamagui@npm:1.0.0-alpha.68 [50cbc]
   └─ expo-linear-gradient@npm:11.2.0 [8ac96] (via npm:^11.0.2 [8ac96])

In tamagui's package json, the rule for linear gradient's version should be ~11.0.2 to fix this for now

Thanks - fix is in https://github.com/tamagui/tamagui/pull/41, can follow that to see it.

Let me know if fixed, can try with create-tamagui-app


feature request: CardService Random()

Hi
Is it maybe possible to make a Random() method, that when applied on the CardService returns a random Card from a random Set (so just a random card)?
I saw this in a Scryfall C# library and I thought it would be nice for this library too.
Thx

Would most likely need the web API to support this, in order for this library to do this I would need to get all cards then get the random card

If you take a random set and inside that set you take a random card, then the resulting card is random too, right?
Then only all cards for that random set must be read.


Can not install lndconnect via go get

I used to install lnd via binnary release in my rapsberry Pi, which use Raspberry Pi OS.
Now I try to install lndconnect via go get ... as read.me describted. But I get an error like below:
pi@raspberrypi:~ $ go get -d github.com/LN-Zap/lndconnect
go: downloading github.com/LN-Zap/lndconnect v0.2.1
go get<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>verifying go.mod<EMAIL_ADDRESS>reading<EMAIL_ADDRESS>410 Gone
	server response: not found<EMAIL_ADDRESS>invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required

I get some information here: https://giters.com/lightningnetwork/lnd/issues/5624#issuecomment-897512230
But I stilll don't know how to fix it.

I find that the answer in issue#20 is really useful: https://github.com/LN-Zap/lndconnect/issues/20#issuecomment-825211584.
I follow the command described int this answer and every time I try go build the terminal will tell me which dependencies is lack and I will use 'go mod download' to install them.
To my surprise, the last command to which the terminal tell me is exactily go get github.com/LN-Zap/lndconnect. So it seems that the command is the last one step rather than the first step.
I strongly recommend to clone this repository with 'git clone' at first and try 'go build' at that folder. Let the terminal tell you which dependencies is needed.


NIFI-1393 Providing the ability to send using gzip Content-Encoding

NIFI-1393 Providing the ability to send using gzip Content-Encoding in PostHTTP if the endpoint server supports it regardless if the processor is configured to send as a FlowFile

Reviewing...

@mcgilman Refactored this a bit to adjust given your commentary and avoided making some of those determinations when we are not sending a flowfile.

Looks good!

Thanks!


DataSet

Hello, how is your data set labeled? I used the 1 classification task data set, labeled as: background 0, target 1. After the processing in your way, it becomes background 255, target 0. Then it is used for training, but it seems that the training result is faulty

If you are referring to semantic segmentation, a label of 255 is usually ignored in most dataset (see ignored_label).


[$125] Scroll bar is on the left side on Wallet page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.30-15
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725796844406159
Action Performed:

Go to Wallet page on ios native
Scroll down

Expected Result:
Scroll bar on right side
Actual Result:
Scroll bar on left side
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021832849619299247163
Upwork Job ID:<PHONE_NUMBER>299247163
Last Price Increase: 2024-09-08
Automatic offers:

hoangzinh | Reviewer | 103885982

Issue OwnerCurrent Issue Owner: @hoangzinh

I tested the Wallet page on version 9.0.30-15 and the scroll bar appears correctly on the right side on the simulator. It’s possible that the scroll bar positioning issue might be related to specific device settings on the tester’s end
https://github.com/user-attachments/assets/6c3389ef-29b3-4223-aac7-e0066fd49553

The scroll bar on the Wallet page is appearing on the left side instead of the right, which is not the expected behavior. This affects user experience, as most users expect the scroll bar to be on the right side of the screen.
Root Causes:
The issue is likely caused by incorrect layout or styling configurations, particularly with the direction property in the React Native code. It could be due to an unintended use of right-to-left (RTL) layout direction.
Proposed Changes:
Check for RTL Settings: Ensure that the layout direction is set to left-to-right (LTR). If any RTL setting is applied (e.g., via I18nManager), it should be disabled for this page.
`import { I18nManager } from 'react-native';
componentDidMount() {
if (I18nManager.isRTL) {
I18nManager.allowRTL(false);
}
}
`
Adjust Scroll Bar Styling:
Use platform-specific styling to ensure the scroll bar is rendered correctly on the right side on all platforms (iOS, Android, Web).
Test Across Platforms:
After applying the changes, thoroughly test the Wallet page on iOS, Android, and Web to confirm the scroll bar behaves as expected.
Alternative Solutions (Optional):
Implement a CSS fix specifically for web platforms using ::-webkit-scrollbar to ensure the scroll bar appears correctly.
Looking Forward to your response.
Have a Great Day!!!

Ah right, I can see this only in the hybrid app 9.0.30-15 while the same version in NewDot is not repro

Now it was even weirder

Oh sorry for not updating you here 🤦
I'm Marcin from Software Mansion, an expert agency, and I'd be glad if you assigned me here 🙏

📣 @thezeeshanhassan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

I am Added My account details

I think we can close this now, the pr was merged and nothing to pay or to make regression testing


"Cannot open input file" error

I'm not able to write disk images with the latest Mac build. I get this error with any image I try to open from the "write disk" button. I am able to open disk images for browsing the file system, but opening one for writing to a disk seems to be broken.

This is a known bug with the current GUI, being addressed by throwing it away and rewriting it from scratch --- it's a fundamental design issue. Sorry. You'll need to use the command line.


Not compatible with later versions of sass...

Bundler could not find compatible versions for gem "sass":
In snapshot (Gemfile.lock):
sass (3.4.19)
In Gemfile:
breakpoint (= 2.4.2) ruby depends on
sass (~> 3.3.0) ruby
Running bundle update will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

You may install the npm package instead and use
https://github.com/strarsis/sass-include-paths (with gulp-ruby-sass).

The latest version of the gem should work with any version of Sass >= 3.3 and < 4. That looks like it's a problem with your Gemfile.lock file.


Sanitze filename before calling ffmpeg

This sanitizes the filename ahead of throwing it in the cmd.
It closes issue #3

Added the new dep manually to setup.py. If you have this project setup in another way, feel free to point me to it.

Thanks looks very good.


Window 10 x64, cannot install

Hi!
I'm using windows 10 x64.
My node version is 6.9.4.
I tried to install mapnik

npm install tilelive-mapnik --save

but it gives me error

node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/mapnik/v3.7.1/node-v48-win32-x64-Release.tar.gz

Is version for windows not ready?
Thanks!

Looks like you would have to build it yourself if it's not prebuild:
https://github.com/mapnik/node-mapnik/issues/728

We dropped support for pre-built binaries for windows, I am sorry our reasons are explained in #848


Add branch-specific premerge jenkinsfile

Signed-off-by: Peixin Li<EMAIL_ADDRESS>To support run premerge w/ branch-specific jenkinsfile

build

build

Please allow me to merge this one, thanks!
I will merge it after all internal and github action setup got updated~


improve Chinese localization readability in description of /site command

ai m confused when i was looking at the description and using this command, i think it better follow the same search behavior as searching on google restricted within a domain. so i name it 網站 -> 網站（域名）

Thanks!


ud-dismiss.js ERR_ABORTED

I noticed there's a dependency issue with the wp-stateless plugin.
Once it's installed and I access wp-admin I see two 404 errors that are caused by your plugin.
GET {{ path to my theme }}/{{ path to my plugins }}/plugins/wp-stateless/vendor/usabilitydynamics/lib-wp-bootstrap/static/scripts/ud-dismiss.js?ver=4.8.1 net::ERR_ABORTED
Kindly fix this issue.

@ewsopp So far, I can not replicate the issue on my local server. So, I have the following questions:

Which server is the site being run on? (Windows/Linux)
Which version of WP-Stateless user mentioned about?
Did it happen on first WP-Stateless activation or after upgrading plugin to new version.
If it happened on plugin upgrade: which old version of plugin? which new version of plugin?
ud-dismiss.js script is being loaded only when Admin Warning is shown. Which Admin Warning was shown on WP-Stateless activation/upgrade ?

Thank you.

One more question, regarding the invalid link:
{{ path to my theme }}/{{ path to my plugins }}/plugins/wp-stateless/vendor/usabilitydynamics/lib-wp-bootstrap/static/scripts/ud-dismiss.js?ver=4.8.1
{{ path to my theme }}.. is invalid path... The link must be:
{{ path to my plugins }}/plugins/wp-stateless/vendor/usabilitydynamics/lib-wp-bootstrap/static/scripts/ud-dismiss.js?ver=4.8.1
Does the plugin installed to plugins directory or to some custom directory ( e.g. it's integrated to theme )?

More details from user:

I’m using bedrock as Wordpress stack https://github.com/roots/bedrock and run it on Linux. I run a fresh installation of wp-stateless v2.0.1 and the plugin doesn’t show any warnings when I access the settings.
Without bedrock this issue does not occur. However, I suspect the way you detect the plugin file path causes the issue and I have not experienced a similar behaviour with other plugins.

@ewsopp It's fixed and included to v2.0.2 release.


Multiplayer extension missing 'array of all players' block

Describe the bug
builtin multiplayer extension is missing 'array of all players' that lets you 'for each' over players
To Reproduce
Steps to reproduce the behavior:

Go to editor and add built in multiplayer extension
See / missing block

Expected behavior
should have the array of all players block so you can 'foreach' over it / user math pickrandom to get a random player

@abchatra We do have a player API/selector block, it's just at the very bottom of the toolbox in the Utilities section. This works:

Sorry missed the block. Makes sense.

It should be higher up in the list. We can add the player selector and array of all blocks to their own subcategory, and sort it just below Sprites.


First attempt at autodoc for core/ and operator/controllers/ only

Change description
First attempt at documentation auto-generation using openAI.
This PR is not meant to be merged, but is merely a nice shareable view for what was generated.
Bug: sometimes a type struct gets generated in the middle of new doc blurbs

Another bug is that "init" functions were deleted from all files


New game is added

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #1601

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

@kunjgit @Arun9739 please have a look and suggest changes if any

Thank you  @shraddha761 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Hey @shraddha761,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

@kunjgit  already done in different project https://github.com/GameSphere-MultiPlayer/GameSphere/pull/356


AllSky software installation failed

Raspberry Pi 4 Model B Rev 1.5  4GB
RPi-HQ-camera
on the command -> tail -n 4 /proc/cpuinfo :
Hardware: BCM2835
Revision: c03115
Serial: 10000000ff82110c
Raspberry Pi OS with desktop
Release date: October 10th 2023
System: 32-bit
Kernel version: 6.1
Debian version: 12 (bookworm)

Bug Description
Hi, I'm new to Github and also making my first experience with the Raspberry Pi.
I'm on loan for everything this is about.
I would like to get an AllSkyCam up and running, but am failing with the AllSky software installation.
The OS installation works. After OS installation I always make an update with:
sudo apt-get update
sudo apt-get dist-upgrade
That works also well.
Then I download the software from Github and start the installation.
But the installation aborts every time with errors like this:
*** Welcome to the Allsky Installer! ***

RPi camera found.
Using RPi camera.
Size of current swap (100 MB) is sufficient; no change needed.
mount: (hint) your fstab has been modified, but systemd still uses
the old version; use 'systemctl daemon-reload' to reload.
/home/sttie/allsky/tmp is now in memory.
*** NOTICE:
Installing the web server.
Installing dependencies.
Preparing Allsky commands.

*** ERROR:
Compile failed

The full log file is in /home/sttie/allsky/config/installation_logs/make_all.log
Log file content:
make[1]: Entering directory '/home/sttie/allsky/src'
Building capture_ZWO.o ...
cc1plus: error: '-mfloat-abi=hard': selected architecture lacks an FPU
make[1]: *** [Makefile:131: capture_ZWO.o] Error 1
make[1]: Leaving directory '/home/sttie/allsky/src'
make: *** [Makefile:24: all] Error 2

I also tried Bookworm 64bit lite, the result was:
…

Installing the web server.
Installing dependencies.
Preparing Allsky commands.
Modifying locations for WebUI.
Setting up WebUI options and default settings for RPi cameras.
Making new settings file '/home/sttie/allsky/config/settings.json'.
Keeping 'en_GB.UTF-8' locale.
Setting permissions on /var/log/allsky.log and /var/log/allskyperiodic.log.
Failed to restart rsyslog.service: Unit rsyslog.service not found.
Installing PHP modules.
Installing other PHP dependencies.
Installing Python_dependencies:
=== Package #  1 of 15: [numpy>=1.25.0]

*** ERROR
Python_dependencies [numpy>=1.25.0] failed

The full log file is in /home/sttie/allsky/config/installation_logs/Python_dependencies.1.log
content of the file is:

sttie@pi:~/allsky/config/installation_logs $ nano Python_dependencies.1.log
GNU nano 7.2                Python_dependencies.1.log
error: externally-managed-environment
× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
python3-xyz, where xyz is the package you are trying to
install.
If you wish to install a non-Debian-packaged Python package,
create a virtual environment using python3 -m venv path/to/venv.
Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
sure you have python3-full installed.
For more information visit http://rptl.io/venv

note: If you believe this is a mistake, please contact your Python installation>
hint: See PEP 668 for the detailed specification.
Do I need to try any other OS version?
Would be great if somebody could help me.
Please consider I’am a very beginner.
Thank you! Stefan

I have the same problem. New Pi4b and new install of Pi OS. HElp !

I tried another install and got further, but it still crashed. Now I get as far as Python stuff and it stops at #11. Here is the log file. Thanks for any help.
Mark
Python_dependencies.11.log

Ok, tried to reinstall and all went well. Sorry for the trouble.

Bookworm isnt supported yet, We have a release in testing that supports Bookworm so you can wait for that, hopefully wont be too long or use Bullseye in the emantime
Cheers
Alex

@Markh129, would you please run
cat /etc/os.release
uname -a

on your Bookworm system and let me know the results?  It'll help us support Bookworm.
Thanks - Eric

@Alex-developer, I think we should update the "master" install.sh to check for Bookworm, and print a message and exit.  Once Point Release 4 is out that check will go away.
Agree?

@Alex-developer, I think we should update the "master" install.sh to check for Bookworm, and print a message and exit. Once Point Release 4 is out that check will go away. Agree?

Excellent idea :-)

hello, I tried a new OS version:
Raspberry Pi OS (Legacy) with desktop
•	Release date: May 3rd 2023
•	System: 32-bit
•	Kernel version: 6.1
•	Debian version: 11 (bullseye)
•	Size: 872MB
after installation I made the updates as before.
I changed some points in the config.
-> Interface options -> I1 Legacy Camera -> Enable
-> Performance Options -> P4 Fan -> GPIO 14 -> 60°C
I started the installation, camera was found.
I confirmed all the points at the beginning of the installation.
Success!  The issue is solved. Thank you!

Good to hear!


Update consul to 0.5.2

broken because master is currently broken, issue is:
NOTIFIED: [consul | restart consul] *******************************************
failed: [*****] => {"cmd": "/usr/local/bin/consul-rolling-restart.sh", "failed": true, "rc": 2}
msg: [Errno 2] No such file or directory


Is there an automatic way to remove the original file(s) after uploading to the Azure blob storage?

It's basically a move operation, instead of a sync.


Integrated RuboCop as part of the build.

Something discussed in https://github.com/solnic/virtus/pull/343.
For a contributing developer the build would fail on something like what is being added as part of feedback in #343. This also removes any conversation about style, Rubocop just enforces those automagically. I first ran rubocop -a, then rubocop --auto-gen-config and reviewed some infrequent violations and fixed them by hand.

Btw, @envygeeks @Bartuz I didn't mean to start too many debates :) I just wanted the person who made a PR, #343 to catch the style issue they were asked to fix before someone had to look at the code and waste time. So please tell me what you'd like me to change in this PR for it to be merged or whether you'd rather not, I am happy to help!

For me, the keyword style hashes has to go, it promotes inconsistency and I am very consistent with my code in that aspect in that I always explicitly do { :key1 => :val1, "key2" => "val2" } for absolute consistency in all my hashes, def(keyword: val) so there is a very clear distinction in my code as to what it's doing.  Ruby introduced code inconsistency in 1.9 with that and it's been an emacs vs. vim war ever since, I never intervene unless one is thrust upon me, meaning if you wish to do { key: val } in your code when submitted, I'll never ask it to change, as I don't ask you to ask me to change.
And the fail part.

I've merged https://github.com/dblock/virtus/pull/1 from @Bartuz, so the or in the control flow is no longer flagged.

@envygeeks I undid a few things in this PR:

Hash rockets are enforced. Most code here was hash rockets, so be it. I think we can all agree that consistency is better than inconsistency, so some places were auto-corrected from Ruby 1.9 syntax to hash rockets.
Raise is back instead of fail everywhere.
Or in control flow is allowed, thx @Bartuz.
Hash values in a table layout must align.

I care more about having an automatic style in Virtus than what the style is, so LMK what else needs to go for this to be merged.

Yay, :heart: thanks for the changes.  I'm happy with it if @booch , I don't know if he's had time to review.

Bump @booch ?

Sorry, I thought I had commented on this. Not sure if I never hit Enter, or if it got eaten.
I really like RuboCop, but I'd really prefer that we use it a bit less aggressively. For example, some of us (myself, and likely @solnic) prefer to keep extra blank lines to aid readability. And I'd prefer RSpec let to consistently use {} instead of do/end, instead of the 1-line versus multi-line rule.
I'm gonna sit on this for just a bit. I might just rework it to be a bit less aggressive, then accept it. I would prefer to keep RuboCop and most of these settings.

What is the status of this?

I think it's up to @booch but I am happy to help with whatever!

I'm :+1: on this, we can adjust whatever we need to later.  No reason to block this pull.
/cc @booch


Increase Overall Unit Test Coverage

Unit Test cases to address include:
src/utils/selectors/monitoringPlanSystems.test.js
src/utils/api/easeyAuthApi.test.js
src/utils/api/monitoringPlansApi.test.js

src/utils/selectors/monitoringPlanSystems.test.js - 100%
src/utils/api/easeyAuthApi.test.js - 91.5%
src/utils/api/monitoringPlansApi.test.js - 100%
Approved for closing


Ignore build and dist directories in linters

These directories are typically the output of python build tools. The are already ignored in .gitignore.

Do we really need to ignore them here if they are ignored in .gitignore? Doesn't pre-commit already respect .gitignore automatically? 🤔

I did not know pre-commit did that. But I did have pylint-odoo problems without this.


Update fs2-core, fs2-io to 2.5.4

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 2.2.2 to 2.5.4.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-minor

Superseded by #119.


How to disable the creation of new tags

Hi!
Im trying to use ngTagsInput like a select with suggesting existent data.
How to disable the creation of new labels ?

$scope.loadTags = function(query) {
	 	return $http.get('/api/users?conditions={ "name": { "$regex": "' + query + '" } }', config);
	};

Hi.
Try set property  add-from-autocomplete-only="true" for your tags-input

hi @oleksiyo did try that but folks can still type things inside the input box, what i want to do instead is have it such that only the pre-populated tags appear and nothing more can be manually entered - curious, how can I make this happen?

@playUruguay Set the add-from-autocomplete-only option as true, as suggested by @oleksiyo, and the user will be able to add tags only by selecting a suggestion from the autocomplete list.
@codefullon ngTagsInput supports Angular's ngDisabled directive. If you do the following the tags-input element will be disabled and the user won't be able to neither add nor remove any tags.
<tags-input ng-model="tags" ng-disabled="true"></tags-input>

excellent, thanks @mbenford, that worked :-)

Can this issue be closed?

absolutely :-)


process exited with code 9009

Environment
Windows build number: Microsoft Windows [Version 10.0.18363.592]
Windows Terminal version (if applicable): Version: 0.8.10091.0

Any other software?

Steps to reproduce

split screen (ALT+SHIFT+-)
type 'exi'
type 'exit'

Expected behavior
the Pane should close normally?
Actual behavior

@DHowett-MSFT , what does that mean? Just because they do it this way then Windows Terminal will follow them? Why?

This behavior exists to stop an error message printed out by a program from disappearing instantly when it exists. There is a class of applications for which that is extremely important. We're following this behavior because it is the right brhavior to follow, and because you can turn it off with a config option very easily.

The config option is: "closeOnExit": "always"

This behavior exists to stop an error message printed out by a program from disappearing instantly when it exits. There is a class of applications for which that is extremely important. We're following this behavior because it is the right brhavior to follow, and because you can turn it off with a config option very easily.
Thank you so much for clarifying! ;)


Problem with rtl direction

When I use rtl direction for container sort is not working correctly
demo: https://jsfiddle.net/eckfano0/2/
video: https://www.useloom.com/share/03959b86fb3447b39248a4ff4721e0f2
.item {
  cursor: move;
  padding: 8px;
  border: 1px solid red;
}

.container {
  display: flex;
  flex-direction: row;
  direction: rtl;
}

Is there any way to support rtl direction?

+1

+1

+1

+1

+1

+1

Hi, I needed this option for my project, So I solve it for myself and create this PR.
But I was sure this would not be reviewed as fast as I expect or may not be accepted,
I put rtl version here to use it, it works completely fine, and works with latest version on that date (I think 0.8.4)
float based
flex based
I change and use this CSS code in this file https://github.com/PersianArt/react-sortable-hoc/blob/master/index.html
html, body, #root {             width: 100%;             height: 100%;             direction: rtl;         }         body {             background-color: #cdcdcd;             display: table;             color: #333;             font-family: 'Montserrat', 'Helvetica Neue', Helvetica, arial, sans-serif;             margin: 0;         }         #root {             display: table-cell;             vertical-align: middle;         }        .sortable-container {             padding: 0;             width: 1200px;             margin: 0 auto;             display: block;             overflow: hidden;             white-space: nowrap;         }         .sortable-item {             float: right;             display: inline-block;             list-style: none;             width: calc(25% - 10px);             height: 200px;             margin: 5px;             background-color: #fff;             text-align: center;             line-height: 200px;         }
for flex only add these codes at end of .sortable-container
display: flex;   flex-direction: row;
Hope this is useful.
If you want this option add to project,
Please ask the author to review this PR

@PersianArt  thank you it's worked fine


Link to python packages for NavX

NavX support is now included in RobotPy as of 2016.1.1, in the robotpy-wpilib-utilities package. Documentation can be found on our readthedocs website.
I haven't ported all of the samples over yet, BUT the one I did port over (the rotate to angle sample) works in simulation too, so you can see the robot rotating when you hit the button and such. Very cool demo.

It would be very useful if the support would extend to NavX Micro on USB port.


Stacked in mobile

Thank you for sharing this very good work. It is helpful.
One question: In the mobile mode, the sidebar is "covering up" the map (hovering on top it). Would it be possible to make sidebar go above / below the map (in the mobile mode) so that both map and sidebar content can be viewed simultaneously (at-least partially).
The reason I am asking is, I have objects moving on the map, while their related info (such as speed etc.) are present in the sidebar. This works great in the desktop mode, to display info side-by-side with moving objects on the map. In the mobile mode, the map disappears below the sidebars. Thought it would be great if the sidebar instead of covering up the map, goes above / below the map (like in typical bootstrap grid system).

you should be able to prevent this by setting the threshold-sm variable in https://github.com/Turbo87/sidebar-v2/blob/master/scss/_base.scss#L3 to 0px, but due to the narrow screens on those mobile devices I'd highly recommend rethinking the user interface instead.


Python validation doesn't work for arrays...

In #287 I added an array to handle capturing an array of file names in the field data_processing_files...
After a number of contortions as to figuring out what was wrong, it looks like the python validator doesn't handle array fields properly. See the error message airr.schema.ValidationError: Internal error: array field data_processing.data_processing_files in schema not handled by validation. File a bug report.
I suppose this is the bug report... 8-)
@schristley it looks to me like this might not be too hard to fix, but wasn't sure... Can you comment??? The other case where an array of strings exists in the spec is handled as a special case (see schema.py, line 370).
FAIL: test_load_repertoire (tests.test_interface.TestInferface)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/airr-community/airr-standards/lang/python/tests/test_interface.py", line 78, in test_load_repertoire
    data = airr.load_repertoire(self.rep_good, validate=True)
airr.schema.ValidationError: Internal error: array field data_processing.data_processing_files in schema not handled by validation. File a bug report.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/airr-community/airr-standards/lang/python/tests/test_interface.py", line 80, in test_load_repertoire
    self.assertTrue(False, 'load_repertoire(): good data failed')
AssertionError: False is not true : load_repertoire(): good data failed
======================================================================
FAIL: test_repertoire_template (tests.test_interface.TestInferface)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/airr-community/airr-standards/lang/python/tests/test_interface.py", line 52, in test_repertoire_template
    result = airr.schema.RepertoireSchema.validate_object(rep)
airr.schema.ValidationError: Internal error: array field data_processing.data_processing_files in schema not handled by validation. File a bug report.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/airr-community/airr-standards/lang/python/tests/test_interface.py", line 55, in test_repertoire_template
    self.assertTrue(False, 'repertoire_template(): repertoire template failed validation')
AssertionError: False is not true : repertoire_template(): repertoire template failed validation

This is fixed as part of  #287, correct?

This is fixed as part of #287, correct?

Yes, for the python library, the validation routine for repertoires for R hasn't been written yet.


Bug - CoL - CoLDP exporter is attaching species synonyms to parent ranks instead of species

Describe the bug
In the CoLDP exports, species and lower ranked synonyms are being attached to all of their parent taxa including higher ranks. In the below example the synonym, Rhizophagus (Anomophagus) wagae, is being attached to the subfamily Rhizophaginae, genus Rhizophagus, and subgenus Rhizophagus (Anomophagus), but not to the accepted name Rhizophagus (Anomophagus) puncticollis Sahlberg, 1837.
To Reproduce
Steps to reproduce the behavior:

When I export Monotomidae to CoLDP
Synonyms are attached to their parent taxa

Data exported from TaxonWorks:
Name.csv

ID
scientificName
authorship
rank
genus
specificEpithet
infraspecificEpithet
cultivarEpithet
appendedPhrase
publishedInID
publishedInPage
publishedInYear
original
code

448407
Rhizophagus
Herbst, 1793
genus

46810
pls 44–59, J–N + 392
1793
true
ICZN

448406
Rhizophaginae
Redtenbacher, 1845
subfamily

1845
true
ICZN

448410
Rhizophagus (Anomophagus)
Reitter, 1907
subgenus
Rhizophagus

47159
27-30
1907
true
ICZN

448421
Rhizophagus (Anomophagus) wagae
Wankowicz, 1865
species
Rhizophagus
Rhizophagus (Anomophagus)

47213
297-300
1865
true
ICZN

Synonym.csv

taxonID
nameID
status

86577
448421
synonym

86576
448421
synonym

86580
448421
synonym

86591
448421
synonym

Taxon.csv

ID
parentID
nameID

86577
86576
448407

86576
85906
448406

86580
86577
448410

86591
86580
448421

Screenshots

Expected behavior
Species and lower ranked synonyms should be attached the species that they are a synonym of, and not the parent higher ranks.
Environment (please identify where you experience this bug:

sfg.taxonworks.org
https://dev.col.plus/dataset/2061/taxon/86576 (temporary)

Ping: https://github.com/Sp2000/colplus-repo/issues/76

@gdower Will fix, but for the record the model that overloads parenthood with synonymy is not the best idea in the long run. Discuss later.

@gdower Can you confirm that the value that needs to change is the parentID in Taxon.csv?

Actually all synonyms should be removed from Taxon.csv and it's the taxonID in Synonym.csv that should be changed to the taxon that the synonym is associated with. Currently, species-level synonyms are being attached to all of the parent uninomials of a species-level taxon instead of the species-level taxon.
Hopefully that makes sense? If not, I could meet with you sometime this week or next week.

Fix confirmed


Exclude operator indices that haven't been released

Operator index can exists in Pyxis even the product has not been
released, these indices should be excluded. By checking Product
Page, we can get release date of an OpenShift version, and then
can compare the release date with current date to know whether
the product is released.
JIRA: CLOUDWF-4084

Looks good +1

Hi @mprahl , all your comments have been addressed except one about using urljoin, PTAL.

Patch is updated to address the last 2 comments from Matt.

Hi @apaplaus @gnaponie could you help to review this? I'm trying to merge this before our sprint close, Matt has two minor comments, and have been addressed in the latest version.

Looks nice

+1


refactor: ferry

Use ferry to handle GitHub GraphQL API

Hi @pd4d10 I wanted to try out this on my local machine. It seems more easy to use than artemis (I'll open another PR after you merge this to migrate the remaining REST implementations to GraphQL).
Each time I run this: flutter pub run build_runner watch --delete-conflicting-outputs it takes around 15 minutes after making a change to github.graphql. Is this normal? Or should I execute something else after the initial run so it executes faster?

Hi @pd4d10 I wanted to try out this on my local machine. It seems more easy to use than artemis (I'll open another PR after you merge this to migrate the remaining REST implementations to GraphQL).
Each time I run this: flutter pub run build_runner watch --delete-conflicting-outputs it takes around 15 minutes after making a change to github.graphql. Is this normal? Or should I execute something else after the initial run so it executes faster?

Yeah, sometimes it is slow in my machine, but not long as 15min. I also have no idea about how it works
Found an issue that could include some clues
https://github.com/dart-lang/build/issues/1414

Yeah, sometimes it is slow in my machine, but not long as 15min. I also have no idea about how it works
Found an issue that could include some clues
https://github.com/dart-lang/build/issues/1414


AutoCompletion from imported files

I am using scss files and I am seeing autocompletion for variables defined in the same file; But not for variables defined in other files in the project imported. Is it not possible to get autocomplete for variables defined in separate files?

You can use SublimeCodeIntel or AllAutocomplete packages for your specific purpose