Bootstrap 5 version available, feedback needed

I've added a Bootstrap 5 source to our code, there are some minor changes to DATA API, for instance data-toggle="tooltip" => data-bs-toggle="tooltip", and other markup changes not interfering with our code base.
I'm expecting the usual:

bug reports, also documentation related
suggestions on improvements
any and all feedback

BSN for Bootstrap 5 changes (compared to V4):

[x] ES6+ class declarations for components, the implementation keeps methods/properties private for increased security; all instances expose only public methods and nothing else; we use a cool prototype pattern to save as much space as possible
[x] Rework all shorter-js utilities we use on BSN for ES6+
[x] Carousel methods changed: added next() and prev() methods, while the slideTo() have been renamed to to()
[x] Dropdown automatic positioning on scroll/resize, a feature similar to Tooltip/Popover and is implemented in a way that it uses the Bootstrap 5 classes (Eg: dropup, dropend) to show the dropdown menu in the viewport, however dropdown nesting is no longer supported
[x] Dropdown inconsistencies with dismissing related event handlers have been eliminated
[x] ScrollSpy performance optimizations: now the component will update the targets only when HTMLCollection is updated or the offsets change due to window resize
[x] ScrollSpy ability to activate last item at maximum scrollHeight even when not in "scroll range" #353, initially believed to be impossible
[x] ScrollSpy has a much better event handling capability; while you can have multiple instances, all event listeners are grouped and properly handled on both initialization and the .dispose() call
[x] Popover & Tooltip have new methods: .enable(), .disable() and .toggleEnabled()
[x] Popover & Tooltip now support aria-describedby
[x] Popover & Tooltip no longer null their generated popover / tooltip on .hide() calls, a much needed performance improvement; to update their contents you must re-initialize them with fresh new options values / contents
[x] Popover & Tooltip now always use a template, saves a lot of space
[x] Popover & Tooltip now support more container and target positions
[x] Popover & Tooltip now support mousemove event for Media elements like <svg>, , <video> (demo updated), for instance a large image initialized with Tooltip/Popover would display its tip outside the viewport even with the automatic repositioning OR transparent images (both SVG and PNG) might cause issues with displaying a tip; the "follow the cursor" feature currently only works with hover triggering option
[x] Popover & Tooltip automatic repositioning on resize / scroll, previously not supported, now we're on par with original plugins
[x] Collapse will block any click when a sibling collapse part of an accordion is in isAnimating state
[x] Popover & Tooltip sanitize function option
[x] Modal can do the zoom in transition when you click a static modal
[x] Modal no longer supports content option and .setContent() instance method
[x] Code cleanup (replace old codebase with modern code, EG: indexOf => Array.prototype.incudes)
[x] Applying fixes (#398 #401 #402 done) and any other problem reported during the next period until Bootstrap 5 is stable
[x] Added a normalizeOptions utility to save even more space
[x] Reworked the BSN.initCallback()
[x] Reworked Button component to support state toggle and removed all its previous functionality
[x] Documentation and WIKI updates
[ ] improve performance, security and simplicity

Thanks and have fun testing.

Thanks for this. I will put effort to contribute.
To admit honestly, your responses created a chain of thoughts - and - I am confident that they will result in my active participation in open source.

Thanks for this. I will put effort to contribute.
To admit honestly, your responses created a chain of thoughts - and - I am confident that they will result in my active participation in open source.

good ieda

good ieda

@thednp Thank you for your work! I need more time to check and compare everything. For now, I will create 1 issue. It is associated with a modal window and data-bs-backdoor= "static".

@thednp Thank you for your work! I need more time to check and compare everything. For now, I will create 1 issue. It is associated with a modal window and data-bs-backdoor= "static".

At the moment, "bootstrap.native" is 86% smaller, and I am happy about it.

At the moment, "bootstrap.native" is 86% smaller, and I am happy about it.

@cvaize hey there. I'm looking into ways to make it even smaller.

I'm looking for a way to change the class Alert declaration to Alert.prototype compile options, something to store the prototype into a variable like alertProto = Alert.proto, this takes a huge chunk of space
I'm also considering creating a BS specific string library for all those data-bs-toggle attributes
anything we can do to improve

Other contributors, @xHeinrich @picasticks @jakubboucek @TheCodeExorcist @stepheny and anyone else, help is still needed :)

@cvaize hey there. I'm looking into ways to make it even smaller.

I'm looking for a way to change the class Alert declaration to Alert.prototype compile options, something to store the prototype into a variable like alertProto = Alert.proto, this takes a huge chunk of space
I'm also considering creating a BS specific string library for all those data-bs-toggle attributes
anything we can do to improve

Other contributors, @xHeinrich @picasticks @jakubboucek @TheCodeExorcist @stepheny and anyone else, help is still needed :)

@cvaize there you go, BSN for Bootstrap 5, same size minimized, more features added, this should be even more awesome.
Everyone else, enjoy the testing ;)

Sorry for not responding for a while.
In the last months I've migrated my only BS 5 site to original JS plugins due lack of BSN support. TBH I don't care so much about reduced file size. What is more important to me is how I can use individual components (Carousel, Collapse, etc) of each library without having the need to bundle them separatelty (or via a loader).
This is what I simply do in my BS 5 project webpack main.js file:
import Button from 'bootstrap/js/dist/button';
import Carousel from 'bootstrap/js/dist/carousel';
import Collapse from 'bootstrap/js/dist/collapse';
import Dropdown from 'bootstrap/js/dist/dropdown';
import Tab from 'bootstrap/js/dist/tab';

^So I can grab only JS components I need.
How would I do it with BSN5?

import Button from 'bootstrap-native/src/components/button-native';
import Carousel from 'bootstrap-native/src/components/carousel-native';
import Collapse from 'bootstrap-native/src/components/collapse-native';
import Dropdown from 'bootstrap-native/src/components/dropdown-native';
import Tab from 'bootstrap-native/src/components/tab-native';

init your way

@midzer the latest version is on npm, you can give it a try and let us know what's up :)

Should Dropdown keyboard navigation work? v5.html says yes, but it's failing for me.
Version 3.0.14f
With the default official v5 BS js, with popperjs, it works - loaded in my app.js like so:
import Collapse from "bootstrap/js/dist/collapse";
import Dropdown from "bootstrap/js/dist/dropdown";

This gives me a dropdown that highlights items with up/down arrow keys.
But if I uninstall popper, install bootstrap.native, and replace my app.js lines like so:
import BSN from "bootstrap.native/src/index-v5";

Then the dropdown opens and closes, and if I open it with keyboard, ESC works to close it, but up/down arrows do nothing.

Thanks for dropping by. The up + down should work when you focus on the dropdown menu.

@apiontek can you confirm that for me?

No, it doesn't work for me. Not sure if I'm supposed to do anything different but I can say that, with:
import BSN from "bootstrap.native/src/index-v5";

as the only thing I'm doing to load BSN, a Dropdown menu works, but up/down doesn't.
To be more specific, on page load, when I start pressing Tab on my keyboard, it cycles through elements on the page, including the dropdown menu. I press Enter to activate the dropdown menu and it appears as desired, but then following that with Down or Up does nothing.
Is there an extra step to "focus on the dropdown menu?"

Another tab key?

OK, yes, I can confirm that another Tab after the Enter to open the menu brings me into the menu, and then up/down work.

You can also hit SPACE bar to open the dropdown ;)

Space bar doesn't work for me to open the dropdown :'(

Works for me on Chrome browsers, if you're on a MAC, I don't.....

I'm testing in Chrome, Firefox, and Chromium based MS Edge, all on Windows. It's fine, just reporting feedback!

bootstrap v5 beta3 added offcanvas component.

Thanks, will have a look when I get the time.

@newyhj Offcanvass added, please check and test the latest master. After some revisit I will also add to npm.
@cvaize you can also have a look at the V5 new codebase.

@thednp
can't use bootstrap-native-v5.js or bootstrap-native-v5.min.js merge and minifier with other js files to single file.
maybe there is a problem with the native js file code.
i'm sure other js no problem,please check it.

The code is in ES6+ flavor in those files, just like the original Bootstrap 5. Maybe that's why.
If that is the case, you may need to configure an ES5 compiler.

I've solved the merge problem

Hello, i get error when i require either the compiled lib or the src for v5

  function hasClass(element, classNAME) {
    return element.classList.contains(classNAME); // this is line 1942
  }

Something that noticed in bootstrap's js, when i have dropdown if i have  data-bs-display this gets applied to the dropdown-menu as data-bs-popper="static" when opened, with bootstrap-native-v5 this doesnt work
data-bs-toggle="dropdown" data-bs-display="static"

@dyanakiev thanks for dropping by.
First, we're now packaging BSN in ES6+ flavor, perhaps that's why your require doesn't work? I don't exactly know what's in your setup. So I took a quick guess.
Secondly as for the new display option for Dropdown, it's not 100% tested in all cases, you can provide a sample code we can have a look.
Thanks

@thednp
Im requiring the package that way:
window.BSN = require('bootstrap.native/dist/bootstrap-native-v5')
or
window.BSN = require('bootstrap.native/src/index-v5')

With both i get the error.
Here is the sample for the dropdown

                    test

                    test

Thanks

That markup works perfect for me, with the display option as well. I think a demo site with the error would be much more helpful.

Everybody!
Bootstrap 5 is now stable, our library has switched V5 as the default package bootstrap-native.js, V4 is now bootstrap-native-v4.js.

@thednp I don't want to sound ungrateful because this is amazing & much appreciated, but I wish you'd made a major version bump to communicate that we needed to change our imports for Bootstrap 4 with this release. The patchlevel bump shouldn't necessarily indicate any breaking changes, so I was surprised when I discovered that the js was no longer working on my site.

Thanks for the suggestion.

I second @swrobel, a major version bump would have been the correct way to go. Semver makes our lives easier.
I had the same problem, the dropdown component stopped working when upgrading to 3.0.15, still works on 3.0.14.
This was the error I was having
Cannot read property 'map' of undefined
Don't take me wrong, I really appreciate your hard work and love the project.

Do you guys consider a major version bump for a github releases as well or just npm/cdn?

Semver says:

..
MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards compatible manner, and
PATCH version when you make backwards compatible bug fixes.

Regardless of the place where the release is posted.
semver.org

@pjcarly & @swrobel guys, I found some time to take care of this, I'm sorry for the confusion I've caused, I've updated my entire JavaScript codebase on github in the last few months or so, and completely forgot about semver, I hope I didn't cause too much trouble, though I've put much effort into this task.
As usual, please update your stuff, test and provide feedback.
Cheers :)

We are now fully into Bootstrap 5 and we're most likely OK to close this one down.
Thanks for everyone's feedback.

Luckily for me it was a quick, edit package.json back to previous version, run yarn, commit, and let the CI/CD do the deploy. A few minutes work.
Still @thednp, thanks for your hard work.

Thanks for the hard work @thednp. I work with phoenix LiveView - so got into some issues in making the Toast work. Otherwise, both documentation and implementation are extremely user friendly.
I was working with Bootstrap 5 directly from the time I came to know of your library. So, did not get any issues.
Thanks and keep up the work.

@thednp thanks for bumping the major version. This is a step in the right direction. I think to fully rectify this, you should push a 3.0.16 version that is basically a copy of 3.0.14, as 3.0.15 is the version that breaks the previous default behavior, and that is still the latest in the 3.x series. For example, my previous package.json line was "bootstrap.native": "^3.0.13" which I then changed to "bootstrap.native": "3.0.14" to avoid having it grab 3.0.15, if that makes sense. I realize this is a time-suck of a task, so no pressure to do it! That's just my two cents on how to really fix the whole SemVer issue.

@swrobel I wish this kind of feedback would have come earlier before we switched V4 official to V5 official. But hey can't keep track of a million things :)

@swrobel I wish this kind of feedback would have come earlier before we switched V4 official to V5 official. But hey can't keep track of a million things :)

It breaks semver. That's unusual for a patch version to introduce breaking changes, given the inner-working of npm/yarn versioning notation.


SingleStore icon is missing

I'm using OpenMetata up to commit 647712c39772f54c43f5f0b0d8ae5a37c14ac837 and SingleStore doesn't have an icon.

@sanketbambulkar Please provide an icon for new services.
cc: @darth-coder00


Bugfix set_field_values

input datas structure has changed.
it was   {"0"=>{ "untitled-text-box"=>{"id"=>"262",
"values"=>{"0"=>"33333"}}} }
now it is : { "untitled-text-box"=>{"id"=>"262",
"values"=>{"0"=>"33333"}}}

Maybe there is an issue with different versions of this file.
still failing to update custom field values

Tested in rails 4 and rails 5 using 2.3.2 and works well, please confirm me this.


fix[cartesian]: DaCe array access in tasklet

Found some incompatible tasklet represention while upgrading to dace v0.15.1. Array access inside tasklet with partial index subset worked in v0.14.1, although not valid.
Added view or transient array in case of memlet slice, to ensure that tasklet uses explicit indexes for the full array shape.
This fix is covered by the following test cases, which would otherwise fail with dace v0.15.1:
tests/cartesian_tests/integration_tests/multi_feature_tests/test_code_generation.py::test_higher_dimensional_fields
tests/cartesian_tests/integration_tests/multi_feature_tests/test_suites.py::TestNon3DFields::test_generation
tests/cartesian_tests/integration_tests/multi_feature_tests/test_suites.py::TestTypedTemporary::test_generation
tests/cartesian_tests/integration_tests/multi_feature_tests/test_suites.py::TestMatrixAssignment::test_generation
tests/cartesian_tests/integration_tests/multi_feature_tests/test_suites.py::TestMatmul::test_generation

cscs-ci run

I have found one case for which this solution won't work. If you consider this test:
tests/cartesian_tests/integration_tests/multi_feature_tests/test_code_generation.py::test_higher_dimensional_fields
and this part of the SDFG generated by baseline:

it is not equivalent to the SDFG generated by the fix:

The memlet from the transient __mat_field_t is copying 4 elements (subset [2,2]) to mat_field, while the original intention is to only write 2 elements.
I got a clue from the compiler warnings:
.../copy.h:153:40: warning: '__mat_field_t' may be used uninitialized [-Wmaybe-uninitialized]
  153 |                 *(vec<T, VECLEN> *)dst = *(vec<T, VECLEN> *)src;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
.../computation.hpp: In function '_Z26__program_stencil_internalP15stencil_state_tPdS1_S1_iiiiiiiiiiiiiii._omp_fn.1':
.../computation.hpp:109:12: note: '__mat_field_t' declared here
  109 |     double __mat_field_t[4] DACE_ALIGN(64);
      |            ^~~~~~~~~~~~~

I have resolved the issue I reported yesterday, by avoiding use of transients. However, I have some dace compilation errors now which look like issues in dace itself.

cscs-ci run

All problems have been fixed. Coding done, ready for review.


refactor: update file mount path to conform with schema store regex

Signed-off-by: James Milligan<EMAIL_ADDRESS>

This PR

updates file mount path to conform with schema store regex

Related Issues

Notes

Follow-up Tasks

How to test

Codecov Report

Merging #331 (dd32e9f) into main (312e91e) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   61.06%   61.06%
=======================================
  Files           4        4
  Lines         524      524
=======================================
  Hits          320      320
  Misses        184      184
  Partials       20       20

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Turd Caravan missing translation key in Caravan Manager

Mod source
Factorio Mod Portal
Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[x] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
When picking the incubation turd (for faster creatures), the description in the caravan manager is missing a key for the 2nd button:

Steps to reproduce
No response
Additional context
No response
Log file
No response

fixed https://github.com/pyanodon/pyalienlife/commit/9e9304d077543f88c464f8f29dd634a204c6c88d


add languages to the :common list

Discussion here.
https://github.com/highlightjs/highlight.js/issues/1119
Once we're decided I can type up a nicer changelog message.

And what about coffeescript?

I say leave it, it's small. These files are all so small. :-)  Powershell is the only pseudo-popular annoying sized package, but even it blends in decently.

I am worried a bit by lack of a clear criterion though. Maybe we can/should get access to some statistics from github or something like that?

Sure, whatever. :-)  Suggestion?

We don't even have SQLPL or HCL. :-)

I am worried a bit by lack of a clear criterion though. Maybe we can/should get access to some statistics from github or something like that?

Sure, whatever. :-) Suggestion?

Just a thought for the future. It requires some research and I don't feel like doing it now. I'm personally fine with the list you suggested.

Would you want to go ahead and add Powershell (because it's popular) and bump the minimal build from 70kb to 105kb or so?

Honestly I have no definite opinion on this. It's up to you (:


BC sope

hi,
I am not a GO expert but played around with your code i noticed that by replacing "react-component-researcher-target-groups"  to ".cc-rewards-link-table__endpoint" in bugcrowd.go yields more results, kindly have look.
thanks

Thanks for opening this issue, appreciate it!
I'll check it out shortly :)

Hi again @ipk1, apologies for the delay.
I tried to change the code according to what you said but now it's not finding anything at all.
Just to make sure, you changed like 91 to something like this, right?
doc.Find(".cc-rewards-link-table__endpoint").Each(func(index int, s *goquery.Selection) {

Did you change anything else to make the code work?
Thanks

Hey,
yeah i changed that to ".cc-rewards-link-table__endpoint" , it works for me however i changed in the forked version, you can have a look at https://github.com/ipk1/test/ , I might have changed something else not sure exactly ... sorry
thanks

Hey there, apologies for not replying earlier.
I took a look at the code and I believe that now it works much better for bugcrowd, finding more scope elements.
Let me know if you still have issues or not :)
Thanks


Edit mode clears previous queries

Using Grafana 4.6.1 and OSI 1.0.1, switching to edit mode clears out the previous query.

What browser version and operating system are you using? I am able to switch between edit and selection mode without issues.
One possible scenario I can think of is if the element does not exist, when switching back to select mode it could the nodes in the hierarchy that cannot be found.

@ritchiecarroll @EEParker I think latest version (tag v1.1.0) this is fixed. Can you check?

Fixed by v2.0.0-beta - https://github.com/GridProtectionAlliance/osisoftpi-grafana/tree/v2.0.0-beta


feat: update versions checked

Update to remove 19 and add 20.
Update to remove 14 as it goes EOL.

Update to remove 19 and add 20. Update to remove 14 as it goes EOL.

Technically Node.js 19 doesn't reach End-of-Life until 2023-06-01. I don't know if it matters for the checker, but it does technically mean that if we end up doing releases to address anything found during May we would also need to consider v19.x.

We could leave in 19.x for now. Updated to do that.

Going to land this now that 14.x is EOL


I2S audio demo - ESP32-P4-NANO (IDFGH-14251)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
Hello, I am creating an issue post about this because it seems the only related issues are long closed. I am attempting to test out the speaker function of the new P4 kit, but when running this example I am getting no sound.
I (174110) i2s_es8311: [music] i2s music played, 640000 bytes are written.
is printing out over and over but nothing from the speaker. I saw an issue related to the P4 board about switching the DI and DO pins but that issue was fixed and closed. I tried it anyway, still nothing.
Is there anything I am missing that I could try?
ESP-ROM:esp32p4-eco1-20240205
Build:Feb  5 2024
rst:0x1 (POWERON),boot:0x30f (SPI_FAST_FLASH_BOOT)
SPI mode:DIO, clock div:1
load:0x4ff33ce0,len:0x18e4
load:0x4ff2abd0,len:0xd74
load:0x4ff2cbd0,len:0x322c
entry 0x4ff2abda
I (25) boot: ESP-IDF v5.3.2 2nd stage bootloader
I (26) boot: compile time Dec 17 2024 13:12:01
I (26) boot: Multicore bootloader
I (30) boot: chip revision: v0.1
I (32) boot: efuse block revision: v0.1
I (37) boot.esp32p4: SPI Speed      : 80MHz
I (42) boot.esp32p4: SPI Mode       : DIO
I (46) boot.esp32p4: SPI Flash Size : 2MB
I (51) boot: Enabling RNG early entropy source...
I (57) boot: Partition Table:
I (60) boot: ## Label            Usage          Type ST Offset   Length
I (67) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (75) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (82) boot:  2 factory          factory app      00 00 00010000 00100000
I (91) boot: End of partition table
I (94) esp_image: segment 0: paddr=00010020 vaddr=40020020 size=a8260h (688736) map
I (218) esp_image: segment 1: paddr=000b8288 vaddr=30100000 size=0000ch (    12) load
I (219) esp_image: segment 2: paddr=000b829c vaddr=3010000c size=00038h (    56) load
I (225) esp_image: segment 3: paddr=000b82dc vaddr=4ff00000 size=07d3ch ( 32060) load
I (239) esp_image: segment 4: paddr=000c0020 vaddr=40000020 size=1d534h (120116) map
I (261) esp_image: segment 5: paddr=000dd55c vaddr=4ff07d3c size=0834ch ( 33612) load
I (270) esp_image: segment 6: paddr=000e58b0 vaddr=4ff10100 size=01b2ch (  6956) load
I (276) boot: Loaded app from partition at offset 0x10000
I (276) boot: Disabling RNG early entropy source...
I (290) cpu_start: Multicore app
W (300) clk: esp_perip_clk_init() has not been implemented yet
I (306) cpu_start: Pro cpu start user code
I (307) cpu_start: cpu freq: 360000000 Hz
I (307) app_init: Application information:
I (309) app_init: Project name:     audio_test
I (315) app_init: App version:      1
I (319) app_init: Compile time:     Dec 17 2024 13:11:15
I (325) app_init: ELF file SHA256:  3146e8a7b...
I (330) app_init: ESP-IDF:          v5.3.2
I (335) efuse_init: Min chip rev:     v0.1
I (340) efuse_init: Max chip rev:     v1.99
I (345) efuse_init: Chip rev:         v0.1
I (349) heap_init: Initializing. RAM available for dynamic allocation:
I (357) heap_init: At 4FF13320 len 00027CA0 (159 KiB): RAM
I (363) heap_init: At 4FF3AFC0 len 00004BF0 (18 KiB): RAM
I (369) heap_init: At 4FF40000 len 00060000 (384 KiB): RAM
I (375) heap_init: At 50108080 len 00007F80 (31 KiB): RTCRAM
I (381) heap_init: At 30100044 len 00001FBC (7 KiB): TCM
I (388) spi_flash: detected chip: generic
I (392) spi_flash: flash io: dio
W (396) spi_flash: Detected size(16384k) larger than the size in the binary image header(2048k). Using the size in the binary image header.
W (409) i2c: This driver is an old driver, please migrate your application code to adapt `driver/i2c_master.h`
I (420) main_task: Started on CPU0
I (430) main_task: Calling app_main()
i2s es8311 codec example start
-----------------------------
I (430) i2s_es8311: i2s driver init success
I (460) ES8311: ES8311 in Slave mode and I2S format
I (470) i2s_es8311: es8311 codec init success
I (470) main_task: Returned from app_main()
I (10380) i2s_es8311: [music] i2s music played, 634240 bytes are written.
I (21300) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (32210) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (43130) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (54050) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (64950) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (75870) i2s_es8311: [music] i2s music played, 640000 bytes are written.
I (86790) i2s_es8311: [music] i2s music played, 640000 bytes are written.

Have you set the correct GPIO according to your P4-Nano board? https://www.waveshare.net/w/upload/9/97/ESP32-P4-NANO.pdf
ESP32P4 I2S_DO_IO is connected ES8311 PIN9-SDIN, from the schematic it's GPIO9, so please set it correctly in the example_config.h.
Please note, esp-idf example doesn't contain any BSP package, there's no guarantee that it can run out of the box for all boards on the market. We expect the user will read the README before trying the example.

This issue probably caused by the PA (Power Amplifier) is not enabled. According to the schematic from the link above:

The PA_CTRL (which is connected to GPIO53) need to be at high level to enable the PA. You can either set GPIO53 to high in the example, or just connect GPIO53 to VCC with a jump wire.
BTW, P4-EV board also uses GPIO53 as the PA_CTRL, PA is not enabled by default on these P4 board, please take care when using P4 dev kit~
Back to the example, the example can't ensure whether the PA on board is enabled by default or connect to a particular GPIO. So, the PA enable step won't be added into the example. But I think we can add some hints since this issue is pretty common for P4 boards

I appreciate the assistance here, still new to the ESP world so figuring things out as I go along. I will try what has been posted here and provide an update. Thank you!


[ADR] Supported API-Gateway configurations

Supported API-Gateway configurations
Date: 2022-12-08
Status
Accepted
Context
While having different configuration options for APIRule we specify which combinations of path + accessStrategies.handler are allowed for API-Gateway component. Additionally we will provide validation based on this.
More information on the current test coverage and validation you may find on:
https://github.tools.sap/xf-goat/knowledge-hub/tree/master/api-gateway-handlers
Decision
After having a meeting today and discussed the issue within the team, we decided on the following:
Handlers matrix based on a rule with 1 path and any 2+ handlers

First/Second handler
allow
noop
oauth2
jwt (ory)
jwt (istio)

allow

noop

oauth2

jwt (ory)

jwt (istio)

Handlers matrix based on a rule with any 2+ paths and a handler

First/Second path
allow
noop
oauth2
jwt (ory)
jwt (istio)

allow

noop

oauth2

jwt (ory)

jwt (istio)

Legend

Type
Description

Supported

Not supported

Consequences
Having specified supported configurations we can improve our unit test coverage in API-Gateway and add the needed validation for APIRules.

This ADR was accepted on 2022-12-08. Closing.


Incorrect computation of perturbation budget in BIM / PGD with random init

Describe the bug
When running FGM with random init, the random initialization step is applied, followed by an eps pertubation attack. This results in a final attack budget larger than eps, which is incorrect
To Reproduce
Steps to reproduce the behavior:

Run FastGradientMethod on MNIST with, e.g. eps=0.3 and random_init=1.
Measure L_inf of perturbation introduced and observe that it is larger than 0.3.

This issue was reported by Albin.

FIxed in #74


Get Data from the Internet

URL of codelab:
https://developer.android.com/codelabs/basic-android-kotlin-compose-getting-data-internet?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-5-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-getting-data-internet#7
Specify the language of the codelab if it is not English:
It's English
In which task and step of the codelab can this issue be found?
Update MarsApiService and MarsViewModel
Describe the problem
import com.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory
import kotlinx.serialization.json.Json
import okhttp3.MediaType

private val retrofit = Retrofit.Builder()
    .addConverterFactory(Json.asConverterFactory("application/json".toMediaType()))
    .baseUrl(BASE_URL)
    .build()

I have never applied okhttp to gradle in the course of this codelab. So I could see an error on toMediaType()
So in the before part Add kotlinx.serialization library dependencies here, it should be added the code below.
implementation 'com.squareup.okhttp3:okhttp:4.10.0'

Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hello @myhency,
Thank you for reaching out to us and sharing your concern. The code block is updated:


cookie bug

HI guys :
here has a cookie bug, when my cookie Expires is "Sat, 19-Sep-2015 14:39:37 GMT", follow is error information ：
Invalid cookie header: "Set-Cookie: cuid="jLjjym5xXIgnOy5+xMs/yw=="; Version=1; Max-Age=2592000; Expires=Sat, 19-Sep-2015 14:39:37 GMT; Path=/". Unable to parse expires attribute: Sat

I consider this closed with 1.4.9 using upstream 4.3.3 HttpClient, which implements fix for https://issues.apache.org/jira/browse/HTTPCLIENT-1077 which is directly related to lower versions (or non-upstream versions) of HttpClient


Lifecycle journaling broken

On passives, since client source information was not propagated, lifecycle operations are not journaled.  As a result, resent lifecycle operations can give the wrong answer.
TODO: add testing.

Is this to address that problem we were talking about, yesterday evening?  Does this imply that the duplicated entity instance in the the state dump was a red herring or can this actually cause that to happen?


high concurrency scenario

Scheduling too many tasks at the same time will result in the loss of some tasks, about 1%.
Individual tasks are small and fast. The average single execution time is about 10 seconds, with about 20+ task commits per second.
Is this a platform exception? How to optimize it?
Server resource utilization is less than 50% and there are no resource issues.

At present, DS can't support such high concurrency tasks friendly

you can try the newest version. has support your scenario


Update hardcoded secrets/passwords to be dynamically created/set by user

there's some hardcoded data, like openwhisk host ip and auth key, rabbitmq username/password, openfaas, just name a few.
we should allow users to configure them with the help of k8s secrets.

only rabbit password remains


widen reader environment

Unless I'm missing a trick somewhere, there's not an easy way to widen the E in ReaderTaskEither<E, L, A>. It seems like this is a natural thing to want to do, e.g.

db library exports a query function that is (sql: string) => ReaderTaskEither<{ db: DbConnection }, Error, Row[]>
logging library that exports a function like (msg: string) => ReaderTaskEither<{ log: LogService }, Error, string>

You might want to use these two functions in the same function and export a single merged reader environment. I think something like:
export const widen = <E, L, A, F extends E>(f: (a: A) => ReaderTaskEither<E, L, A>) => (a: A): ReaderTaskEither<F, L, A> => {
  return new ReaderTaskEither<F, L, A>(f(a).value)
}

Giving:
interface Environment {
  db: DbConnection;
  log: LogService;
}

const queryAndLog = () =>
  readerTaskEither
    .of<Environment, Error, object[]>([])
    .chain(widen(() => query('select * from customers')))
    .chain(widen((rows: object[]) => logInfo(`found ${rows.length} rows`).map(() => rows))) // have to annotate rows here to guide the inference

Is that something you would be interested having a PR for? Or is there a more elegant solution that I'm not seeing? (there normally is 😅 )

I'm using the following approach with overloadings:
function combine<E, P>(a: Reader<E, CT<P>>): Reader<E, [CT<P>]>;
function combine<E1, P1, E2, P2>(a: Reader<E1, CT<P1>>, b: Reader<E2, CT<P2>>): Reader<E1 & E2, [CT<P1>, CT<P2>]>;
function combine<E1, P1, E2, P2, E3, P3>(
	a: Reader<E1, CT<P1>>,
	b: Reader<E2, CT<P2>>,
	c: Reader<E3, CT<P3>>,
): Reader<E1 & E2 & E3, [CT<P1>, CT<P2>, CT<P3>]>;
function combine<E1, P1, E2, P2, E3, P3, E4, P4>(
	a: Reader<E1, CT<P1>>,
	b: Reader<E2, CT<P2>>,
	c: Reader<E3, CT<P3>>,
	d: Reader<E4, CT<P4>>,
): Reader<E1 & E2 & E3 & E4, [CT<P1>, CT<P2>, CT<P3>, CT<P4>]>;
function combine<E, P>(...readers: Reader<E, CT<P>>[]): Reader<E, CT<P>[]> {
	return asks((env: E) => readers.map(reader => reader.run(env)));
}

This allows you to compose different environments just using structural typing:
type AEnv = {
	a: string;
};
type BEnv = {
	b: number;
};
const a = asks((e: AEnv) => `A${a}`);
const b = asks((e: BEnv) => `B${b}`);
const ab: Reader<AEnv & BEnv, string> = combine(a, b).map(([a, b]) => `A&B: ${a} ${b}`);

I think this could be generalized for any ADT with a Reader interface.

I'm using the following approach with overloadings:
function combine<E, A>(a: Reader<E, A>): Reader<E, [A]>;
function combine<E1, A, E2, B>(a: Reader<E1, A>, b: Reader<E2, B>): Reader<E1 & E2, [A, B]>;
function combine<E1, A, E2, B, E3, C>(
	a: Reader<E1, A>,
	b: Reader<E2, B>,
	c: Reader<E3, C>,
): Reader<E1 & E2 & E3, [A, B, C]>;
function combine<E1, A, E2, B, E3, C, E4, D>(
	a: Reader<E1, A>,
	b: Reader<E2, B>,
	c: Reader<E3, C>,
	d: Reader<E4, D>,
): Reader<E1 & E2 & E3 & E4, [A, B, C, D]>;
function combine<E, P>(...readers: Reader<E, CT<P>>[]): Reader<E, CT<P>[]> {
	return asks((env: E) => readers.map(reader => reader.run(env)));
}

This allows you to compose different environments just using structural typing:
type AEnv = {
	a: string;
};
type BEnv = {
	b: number;
};
const a = asks((e: AEnv) => `A${e.a}`);
const b = asks((e: BEnv) => `B${e.b}`);
const ab = combine(a, b).map(([a, b]) => `A&B: ${a} ${b}`); //Reader<AEnv & BEnv, string>

I think this could be generalized for any ADT with a Reader interface.

Slightly related:
I've read quite a bit online that seems to suggest that the local function should be able to change the environment type, however fp-ts's implementation of local does not support this. Note that implementations of local that do support changing the environment type do not require the new environment type to be a super type of the current.
I guess what I'm saying is that while I agree that we should have a means to widen the environment type, we could also consider updating the local function to support arbitrary (making no assumptions about sub/super types) changing of the environment type.
Thoughts? Admittedly, this is probably a separate issue.

@tbrisbane Agree, I already have const mapE = <E, E2>(f: (e: E2) => E) => <A>(fa: Reader<E, A>): Reader<E2, A> => asks(e2 => fa.run(f(e2))); which is essentially local. I don't see any reasons to restrict the env type.

Between the new definitions of local and functions like mapE above I think this issue can be closed. 👍


Print in main prints twice

Not sure if this is a bug or not but, as a user, I think it is unexpected behaviour. Running the program
func int main ([string] args) impure {
  print(5)
  return 0
}

main([])

gives the result
❯ ../FloydLang/floyd/floyd run ./test.floyd
5
5

Yes, that's wrong. Will fix.

No, that's correct. main() is always called automatically by the runtime, after all your global statements have executed. Remove the main([]) call and you will be fine.

Close this issue if you agree.

Aha, that's why the examples used test_main. My bad -- closing this. Thanks for the heads up!


dominantTaxa bugfix: when there are multiple dominant taxa with equal counts

Hi,
I did not make any changes to regular cases where only one dominant taxon was found per sample.
When sample contains multiple dominant taxa

In these cases, we could take only one dominant taxon --> another dominant taxa would be missed --> this cannot be done

Now we have more dominant taxa that there are samples.

We could create a list or a vector. I think a vector is better output since it is the output in cases where there are not multiple dominant taxa.

data("GlobalPatterns")
tse <- GlobalPatterns
tse1 <- tse
assay(tse1)[1, 1] <- max(assay(tse1)[, 1])

> perSampleDominantTaxa(tse1)
     CL3      CL3      CC1      SV1  M31Fcsw  M11Fcsw  M31Plmr  M11Plmr  F21Plmr  M31Tong  M11Tong LMEpi24M SLEpi20M   AQC1cm   AQC4cm
"549322"  "36155" "256977"  "71074" "331820" "331820"  "98605" "484436"  "64396" "360229" "114821" "279599" "329744" "549656" "549656"
  AQC7cm      NP2      NP3      NP5  TRRsed1  TRRsed2  TRRsed3     TS28     TS29    Even1    Even2    Even3
"549656" "557211" "534609"  "12812"  "87194" "319044" "319044" "331820" "189047" "550960" "550960" "550960"

> perSampleDominantTaxa(tse)
     CL3      CC1      SV1  M31Fcsw  M11Fcsw  M31Plmr  M11Plmr  F21Plmr  M31Tong  M11Tong LMEpi24M SLEpi20M   AQC1cm   AQC4cm   AQC7cm
 "36155" "256977"  "71074" "331820" "331820"  "98605" "484436"  "64396" "360229" "114821" "279599" "329744" "549656" "549656" "549656"
     NP2      NP3      NP5  TRRsed1  TRRsed2  TRRsed3     TS28     TS29    Even1    Even2    Even3
"557211" "534609"  "12812"  "87194" "319044" "319044" "331820" "189047" "550960" "550960" "550960"

Because we have vector whose length is greater than there are rows in colData, we have a problem.

To solve this problem, the vector is converted into a list that has as many elements as there are samples.

This cause problems in both countDominantTaxa and addPerSampleDominantTaxa.

countDominantTaxa creates a data.frame from dominant taxa and colData which is fed into function that summarizes dominant taxa.
addPerSampleDominantTaxa adds dominant taxa information to colData

> countDominantTaxa(tse1)
# A tibble: 20 × 4
   dominant_taxa     n rel.freq rel.freq.pct
   <chr>         <int>    <dbl> <chr>
 1 331820            3     11.1 11%
 2 549656            3     11.1 11%
 3 550960            3     11.1 11%
 4 319044            2      7.4 7%
 5 114821            1      3.7 4%
 6 12812             1      3.7 4%
 7 189047            1      3.7 4%
 8 256977            1      3.7 4%
 9 279599            1      3.7 4%
10 329744            1      3.7 4%
11 360229            1      3.7 4%
12 36155             1      3.7 4%
13 484436            1      3.7 4%
14 534609            1      3.7 4%
15 549322            1      3.7 4%
16 557211            1      3.7 4%
17 64396             1      3.7 4%
18 71074             1      3.7 4%
19 87194             1      3.7 4%
20 98605             1      3.7 4%

> countDominantTaxa(tse)
# A tibble: 19 × 4
   dominant_taxa     n rel.freq rel.freq.pct
   <chr>         <int>    <dbl> <chr>
 1 331820            3     11.5 12%
 2 549656            3     11.5 12%
 3 550960            3     11.5 12%
 4 319044            2      7.7 8%
 5 114821            1      3.8 4%
 6 12812             1      3.8 4%
 7 189047            1      3.8 4%
 8 256977            1      3.8 4%
 9 279599            1      3.8 4%
10 329744            1      3.8 4%
11 360229            1      3.8 4%
12 36155             1      3.8 4%
13 484436            1      3.8 4%
14 534609            1      3.8 4%
15 557211            1      3.8 4%
16 64396             1      3.8 4%
17 71074             1      3.8 4%
18 87194             1      3.8 4%
19 98605             1      3.8 4%

> head(colData(addPerSampleDominantTaxa(tse1))$dominant_taxa, 5)
$CL3
     CL3      CL3
"549322"  "36155"

$CC1
     CC1
"256977"

$SV1
    SV1
"71074"

$M31Fcsw
 M31Fcsw
"331820"

$M11Fcsw
 M11Fcsw
"331820"

> head(colData(addPerSampleDominantTaxa(tse))$dominant_taxa, 5)
     CL3      CC1      SV1  M31Fcsw  M11Fcsw
 "36155" "256977"  "71074" "331820" "331820"

Is the output of perSampleDominantTaxa ok? There are still some additional code that I have commented out.
Issue: https://github.com/microbiome/mia/issues/208
-Tuomas

Ok to me but curious to hear comment from @FelixErnst  - -
This problem is rare in practice, and there is stochasticity in measurements at least when we look at read counts from sequencing experiments. In such case it would not make much practical difference to simply choose the dominant taxon randomly, from the two (or more) top candidates because the reads have some inherent stochasticity. Then there could be just a warning (which would be triggered very rarely).
On the other hand there might be other cases where the exact counts do matter and there might be more reason to provide exact solutions. If this is something that should be readily implemented, or left for the informed user to decide about, I am not sure.


error 0x80096019

I could create the appx file and everything went well. But when I try to install the app, this is the error I get:
error 0x80096019: Opening the package from location myapp.appx failed.
This is how I created the certificates in case the problem is related to that:
makecert -r -pe -n "CN=mycompany.com" -ss CA -sr CurrentUser -a sha1 -sky signature -cy authority -sv CA.pvk CA.cer

pvk2pfx -pvk "CA.pvk" -spc "CA.cer" -pfx "mycompany.com.pfx" -pi mypassword

Hello, did you manage to resolve your problem since then ? If yes, how ?

@learchamba You can use create-self-signed-cert command to generate pfx file. I solved it.

Hi, I can't find any resources on create-self-signed-cert, could you be more accurate?

@AlexandreSi Try install windows SDK.
https://github.com/microsoft/node-pty#windows
npm install --global --production windows-build-tools

You could find it in some path. Use everything search it.


Ignore commented YT channels

If a comment contains an entire user/channel (e.g. http://www.youtube.com/user/eurovision) or even a search query (e.g. https://www.youtube.com/results?search_query=hit+that), the Syncer will download the entire channel if no meta-tags are present.
The YT regex for valid single song URLs should exclude user/channels.

20c424752bccb5f12a4f6a1027a0e4e649b9b0af

Can this be linked to #135  (as in closes when pr is merged?)

Correct that it is linked in a commit, however it doesn't show up in the issue list. You can link these by using the "Development" on the right of this issue

See for example #136

This way it's faster recognizable which items are already done and which aren't.
Another way to indicate it is to use labels


Please invite me to the Infraform Community

Name
Jyotsna
Additional Context
As, I want to contribute to some real world projects with other people.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for developing solutions and enhancing creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn about development, DevOps, tech, and contribute together and with us 👉💜👈


Attachments view and a attachment downloading

I was needed it for migration from confluence to something other wiki-engine

@turbotankist Please fix it to pass CI and we will merge it.

Codecov Report

Merging #10 into develop will decrease coverage by 1.36%.
The diff coverage is 7.69%.

@@             Coverage Diff             @@
##           develop      #10      +/-   ##
===========================================
- Coverage    23.24%   21.88%   -1.37%
===========================================
  Files            2        2
  Lines          271      297      +26
===========================================
+ Hits            63       65       +2
- Misses         208      232      +24

Impacted Files
Coverage Δ

confluence/confluence.py
19.79% <7.69%> (-1.21%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2d799...82f3632. Read the comment docs.


iRODS status badge displayed for landing zones in CREATING state

Shouldn't be displayed as, of course, there's no stats to show at this point.

Fixed. Also did a bit of refactoring for the landingzones app.


Incorrect name of router generated from Ingress

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Assume we have an Ingress as:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: bar-name
  namespace: foo-namespace
  annotations:
    traefik.ingress.kubernetes.io/router.entrypoints: web
spec:
  rules:
  - host: example.org
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: example
            port:
              name: http

Expected name of this router:
foo-namespace-bar-name-example-org-example@kubernetes.
What did you see instead?
Actual name of this router in dashboard:
bar-name-foo-namespace-example-org-example@kubernetes.
The name and namespace are misplaced.
What version of Traefik are you using?
Traefik: 2.8.0
Installed by Helm chart: traefik-10.24.0
What is your environment & configuration?
providers:
  kubernetesCRD:
    enabled: true
  kubernetesIngress:
    enabled: true

If applicable, please paste the log output in DEBUG level
No response

Closed by #9221.


Start up Issue

I keep getting this when I start it up http://prntscr.com/ej5ycy . This is my config

<IP_ADDRESS>
root

purecp

Is there a password on the root user?

Yeah, I saw. I set a password for root and boom! It worked xD

This is a password issue, if you're not using a password, change the string in MySQL.pm to:
Mojo::mysql->new('mysql://' . $strUsername .  '@' . $strHost . '/' . $strDatabase)
from
Mojo::mysql->new('mysql://' . $strUsername . ':' . $strPassword . '@' . $strHost . '/' . $strDatabase)


onLayout is not getting triggered when view is transforming using Animated.View

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
I am trying to get the current View y position when my view is translating, but the onLayut is not getting triggered when the transform value change.
React Native version:
System:
OS: macOS 10.15.4
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 47.71 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 13.6.0 - /usr/local/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.13.4 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
Android NDK: 17.2.4988734
IDEs:
Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
Xcode: 11.4/11E146 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.4 => 0.61.4
Expected Results
Expect to get current Y value from onLayout function when it is translating.

It's because layout process not involved in transformations at all. Actually Animated can't change any properties that can change layout of component tree.

Have the same problem bro? Did you fix it?

@vovkasm In that case do you happen to know a method to deal with getting the size and position of elements with a transform or a parent that has a transform?
Does that also mean that if you use a transform on a parent element the .measure and onLayout nativeEvent.layout will always be wrong by the amount the parent is transformed?
If this is the case -- that all children of transformed elements have incorrect onLayout and .measure results -- then it certainly needs to be put in the documentation!

So here's all of the undocumented or buggy behavior I've encountered with onLayout and .measure so far:

onLayout doesn't get called in some conditions (seemingly when an element is moved by a parent resizing)
measure returns undefined on android unless there's an onLayout or collapsible: false on the view
onLayout doesn't take transforms into account, it returns the "internal" size of the view not the size displayed on the screen
onLayout doesn't fire for animations of transforms (which is pretty much all animations since only transforms and opacity can use native driver) -- that's this issue
measure returns different values for width and height than onLayout. It returns scaled values if any parent is scaled as opposed to the raw values. Docs suggest the opposite.
onLayout Will return wrong/random values during component mount in some (maybe all?) cases if the view or any parent is being animated.

These add up to big frustrations. I don't know how many hours I've lost at this point writing stuff that should work per the docs only to eventually figure out the above list and work around it. These things should at least be documented so others don't have to go through the same thing.
Here's an issue on the documentation repo collecting some of these things: https://github.com/facebook/react-native-website/issues/2056

hello @AndrewMorsillo thanks for sharing this. I was wondering if it could be posible to share this singleton you created? Thanks in advance

hi @AndrewMorsillo, that was really helpful, I am facing the same issues. I'd be interested too in the singleton and also what edge cases you could not solve with it (and how did you solve these?). Based on you said "I've worked around it mostly"...

I experience the same issue with onLayout. Maybe someone has a snippet of workaround? here's my code...
onLayout={() => {
                    map.current.animateCamera({
                        center: { latitude: location?.coords?.latitude, longitude: location?.coords?.longitude },
                        zoom: zoomLevel,
                        heading: 50,
                        pitch: pitchLevel,
                        altitude: 5,
                    })
                }}


Improve tessellator performance by delaying calls ofisIntersectingPolygon

Description
This method iterates over all the remaining edges of a polygons to check if a given edge intersects any of them .Currently the method is called when curing local intersections or splitting the polygon  which is iterating over the polygon edges so it is potentially a O(n^2) on the edges of the polygon.
The calls are performed on a big conditional but currently the calls are not done in the last position. So just moving the call to the last position brings a very nice performance improvement. For example for the polygons shared on https://github.com/apache/lucene/issues/11777:
FE-24544446.txt:
without change:  542.682 seconds
with change: 229.524 seconds
ORG-24132378.txt:
without change: too long, I did not have patience to let it finish.
with change:  1416.57 seconds

closed in https://github.com/apache/lucene/pull/11786


[v8] Could not find package configuration file

I have successfully installed v8:x64-windows and am trying to use the package in a CMake project in VS 2019. Running vcpkg list shows the package fine and there were no errors during the install:
icu:x64-windows                                    67.1-3           Mature and widely used Unicode and localization ...
v8:x64-windows                                     <IP_ADDRESS>       Google Chrome's JavaScript engine
zlib:x64-windows                                   1.2.11#9         A compression library

vcpkg is used as a Git submodule. CMakeLists.txt has the following:
cmake_minimum_required (VERSION 3.8)

set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake CACHE STRING "Vcpkg toolchain file")

project ("HelloWorldV8_vcpkg")

find_package(v8 CONFIG REQUIRED)

CMake reports this error:
1> [CMake] CMake Error at vcpkg/scripts/buildsystems/vcpkg.cmake:478 (_find_package):
1> [CMake]   Could not find a package configuration file provided by "v8" with any of
1> [CMake]   the following names:
1> [CMake]
1> [CMake]     v8Config.cmake
1> [CMake]     v8-config.cmake
1> [CMake]
1> [CMake]   Add the installation prefix of "v8" to CMAKE_PREFIX_PATH or set "v8_DIR" to
1> [CMake]   a directory containing one of the above files.  If "v8" provides a separate
1> [CMake]   development package or SDK, be sure it has been installed.

The vcpkg directory tree does not contain either v8Config.cmake or v8-config.cmake.
When installing the package, output ends with the "Total elapsed time" line, there is no "The package provides CMake targets..." like in other packages.
Contrary to what's mentioned in https://github.com/microsoft/vcpkg/pull/12687#issue-461463078 the package's tools folder does not exist.
/cc @Kwizatz

Hi @mganss , the original PR was changed a lot, all manual generation of import targets was removed in favour of a pkg-config configuration, what you need to do instead is something like this:
find_package(PkgConfig) pkg_check_modules(V8 REQUIRED IMPORTED_TARGET GLOBAL v8 v8_libplatform) target_link_libraries(<target> PkgConfig::V8)
The tools folder was probably removed with the manual imported targets as well, do you need a specific executable?

find_package(PkgConfig) is failing for me as well. I don't need tools, just found it suspicious that they were missing. What's needed, though, is the snapshot_blob.bin file. I can see this only in the buildtrees directory.

find_package(PkgConfig) is failing for me as well. I don't need tools, just found it suspicious that they were missing. What's needed, though, is the snapshot_blob.bin file. I can see this only in the buildtrees directory.

Right, I don't see it as part of the portfile either 😒.
I have a new PR to update to version 8.5, I'll address these issues in there, In the meantime, I think you can recover the snapshot from buildtrees, use find_library() to get v8, v8_libbase and v8_libplatform and then use "-DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH" to your compile flags.
Sorry for the inconvenience, and thanks for your feedback 😁

@Kwizatz wish your PR can fix this.

Hi @JackBoosY, It does, as it is it supports the shared build, but I still need to add support for the static versions.
find_package(V8 CONFIG REQUIRED)
Should provide V8::V8, V8::V8LIBBASE and V8::V8LIBPLATFORM targets as well as some other cmake variables.

@Kwizatz
I also just installed v8 with vcpkg.exe install v8:x86-windows-static
and get the error as @mganss  is there any easy was to fix pkg-config tool not found ?
I thought that vcpkg will automatically download pkg-config if required.

Hi @S0PEX , easiest fix would be to cherry pick the PR from #13355, that PR is ready to merge but for some reason there's been no action from the vcpkg side.
You can see examples on how to detect v8 from cmake here, you probably will just need to use find_package(V8 REQUIRED) and then add the targets V8::V8, V8::V8LIBBASE and V8::V8LIBPLATFORM to your target_link_libraries.

@Kwizatz
Thanks for your help.
I just rebuild v8 with your port files and are now getting an error:
1> [CMake] CMake Error at D:/Git/vcpkg/scripts/buildsystems/vcpkg.cmake:496 (_find_package):
1> [CMake]   Found package configuration file:
1> [CMake]
1> [CMake]     D:/Git/vcpkg/installed/x86-windows-static/share/v8/V8Config.cmake
1> [CMake]
1> [CMake]   but it set V8_FOUND to FALSE so package "V8" is considered to be NOT FOUND.`

which is weird as the .lib files are existing in /lib/v8_monolith.lib and /debug/lib/v8_monolith.lib do you have any ideas why this error occurs ?

@S0PEX did you set VCPKG_TARGET_TRIPLET to x64-windows-static?
cmake -DVCPKG_TARGET_TRIPLET:string=x64-windows-static

So, there is a problem with the portfile.
Just so you don't have to rebuild the whole thing, copy V8Config-static.cmake to vcpkg\installed\x86-windows-static\share\v8\V8Config.cmake, overwriting it. Then open the file and change set(V8_COMPILE_DEFINITIONS "") to set(V8_COMPILE_DEFINITIONS " ") notice the space, that should fix it, I'll fix the PR.

@S0PEX did you set VCPKG_TARGET_TRIPLET to x86-windows-static?
cmake -DVCPKG_TARGET_TRIPLET:string=x86-windows-static

Hey, yeah I have the target_triplet set. For some reason he doesn't find the library right now.
When I applied your changes and now I am getting V8_LIBRARY is missing.
Did you changed something in the V8Config.cmake after your commit in PR ?

@S0PEX I fixed the PR yesterday, I also posted a fix so you don't have to rebuild the whole thing, it does work for me now.

@Kwizatz
The issue was that, v8 was written capital and therefore failed. Thanks for your help.

Fixed in #13355.


1.1.0 RC1 breaks existing 1.0.1 app

Just as a heads up. I swapped out 1.1.0 RC1 in an existing application, which broke functionality.
At a first glance it seems that none of the events are firing any longer. Going back to 1.0.1 for the time being.
Rainer

Hi,
I've tried the 1.1.0-rc.1 version with jquery 1.7.1 and everything seems to work fine (you had me scared to death for a while! eheh).
Could you please test again or provide an example?
Thank you

@azicchetti : Sorry for scaring you to death, that wasn't my intention.Just wanted to give a heads up of a potential issue.
As requested I've updated my require.js/backbone.js example to use 1.1.0RC1 https://github.com/RainerAtSpirit/jquerymobile-router/tree/1.1.0RC1-RequireJS-Backbone and all is  working as expected.
Good news is that jqm-router is still working, bad news is that something in my app code is preventing a successful upgrade.
Thanks for looking into it.
Rainer

Don't worry, I was just kidding!
It was important to test out the 1.1.0 preview before it's actually released, so that we have time to patch our code if necessary.
I've based a lot of work projects on jquery mobile, backbone, jqm router, the datebox plugin, photoswipe and a couple of persistence plugins, and when a new jquery mobile version is released it takes a while to test the whole stack anew.
I'm glad that someone can do these tests and report potential issues when I'm busy at work, so thank you again for your time, you're helping a lot.


test(iter): add invariant iter should only run once

All the methods provided should make sure that Iter is only ran once.
Counter example: tap #1371

Pull Request Test Coverage Report for Build 4355
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 83.252%

Files with Coverage Reduction
New Missed Lines
%

builtin/array.mbt
1
96.08%

result/result.mbt
2
74.14%

Totals

Change from base Build 4354:
-0.05%

Covered Lines:
4633

Relevant Lines:
5565

💛  - Coveralls

My best guess is that the reduction in result.mbt comes from a rare name clash in coverage data output, as I can't reproduce it in my local environment. A PR there is under way: https://github.com/moonbitlang/moon/pull/538


[BUG] PUBLISH_CONFIGURATION_ARTIFACTS setting is ignored

Release version
v4.10.3
Describe the bug
The documentation at publisher doc states that we can use the following variable to specify which artifacts actually publish from the whole /artifact folder in the git repo.
PUBLISH_CONFIGURATION_ARTIFACTS  = If set to true, publisher will publish artifacts that are defined in configuration and exist in the artifacts directory.
Based on a failed test and actually taking a look at the code, it seems that this variable not even read from the code.
Expected behavior
When specifing both CONFIGURATION_YAML_PATH and PUBLISH_CONFIGURATION_ARTIFACTS the publish operation should only take in account the resources specified in the yaml configuration file.
Actual behavior
The CONFIGURATION_YAML_PATH  just affect the values override but all the resources in the /artifact folder are always published.
Reproduction Steps

Extract from a source APIM a bunch of resources
Prepare a publisher configuration file that just specifies one of them
Configure the publish pipeline with both the CONFIGURATION_YAML_PATH and PUBLISH_CONFIGURATION_ARTIFACTS=yes
run the pipeline

@andrea-migliaccio good catch. At one point we enabled a feature on the publisher to allow it to pick up changes in the configuration file. This led to some complexities so we had to revert it back. We just forgot to update the docs. I will go ahead and take care of it right now.

@zcarroll4 - as you mentioned, the CONFIGURATION_YAML_PATH variable still works and is used for overrides.
Regarding PUBLISH_CONFIGURATION_ARTIFACTS, here is the old behavior.

In the current behavior, configuration artifacts are purely used for overrides:
If no commit ID is passed
We take all artifacts from the artifacts folder. They get overridden with configuration properties if applicable, then published to APIM.
If a commit ID is passed
We take all artifacts in the artifacts folder that were modified in the commit. Deleted artifacts get deleted from APIM. New/modified artifacts get overridden with configuration properties (if applicable), then published to APIM.


Add -no-relative-path: flag to control indexing of generated files

Previously, the SemanticDB compiler plugin errored when indexing auto-generated files outside of the configured -sourceroot directory (which is automatically inferred for Bazel builds). This behavior was undesirable because:

There's no good workaround for the issue
The error message was cryptic making it difficult to understand what went wrong

For some cases, we were able to detect this situation for Bazel and ignore the indexed file while printing an informative message, but this behavior was also undesirable because we skipping these files means that we can't render hover messages for symbols in those generated files.
This PR fixes the issue by adding a configurable -no-relative-path: flag with the following valid options:

index_anyways (default): indexes the file but with no guarantee that it's possible to recover the location of the original generated file. This allows us to display accurate hover tooltips for symbols in these files even if "Go to definition" won't work.
skip: silently ignored these files.
warning: ignore these files and print a message explaining it was skipped.
error: fail the compilation process (old default).

Test plan
Manually tested this in the example Bazel workspace with the following commands:
❯ cd examples/bazel-example
❯ bazel build //... --@scip_java//semanticdb-javac:enabled=true
INFO: Analyzed 4 targets (0 packages loaded, 0 targets configured).
INFO: Found 4 targets...
INFO: Elapsed time: 0.102s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
❯ find bazel-bin/ -type f -name '*.semanticdb'
bazel-bin//src/main/java/example/example.semanticdb/META-INF/semanticdb/src/main/java/example/Example.java.semanticdb
bazel-bin//src/main/java/example/_javac/example/libexample_classes/META-INF/semanticdb/src/main/java/example/Example.java.semanticdb
bazel-bin//src/main/java/source-generator-example/animal.semanticdb/META-INF/semanticdb/src/main/java/source-generator-example/Animal.java.semanticdb
bazel-bin//src/main/java/source-generator-example/_javac/animal/libanimal_classes/META-INF/semanticdb/bazel-out/darwin_arm64-fastbuild/bin/src/main/java/source-generator-example/_javac/animal/libanimal_sources/AutoValue_Animal.java.semanticdb
bazel-bin//src/main/java/source-generator-example/_javac/animal/libanimal_classes/META-INF/semanticdb/src/main/java/source-generator-example/Animal.java.semanticdb

Observe that the generated file does not use the no-relative-path/NUMBER.FILENAME.semanticdb logic in this PR. To be sure, I manually tested that code path by changing the implementation a bit and confirmed that it generates valid relative paths under META-INF/semanticdb/no-relative-path/....

I will address the unresolved comments separately


FYI, kernels 5.14+ removed drm_irq.h and compat_alloc_user_space().

As a heads-up  evdi cannot build on kernels at or beyond 5.15.  Looks like drm_irq.h actually isn't used, but I don't know my ioctls well enough to poke at the compat_alloc_user_space() issue.
Really wish this were upstream.  Really wish I had done the research to find the binary blob issue.  sigh.

I got it to build under 5.15, but I am soooo not qualified to properly fix it or debug if it actually works. Kinda need this to work on 5.15 (fixes some issues with my hardware)

@infinytum:
I am running Slackware64-current.  I tried building evdi-kernel under 5.15 and was not able to do so.  The error message is the following:
evdi-1.9.1/module/evdi_drm_drv.h:23:10: fatal error: drm/drm_irq.h: No such file or directory
23 | #include <drm/drm_irq.h>
What did you have to modify for it to build for you?  I also downloaded the zip file from your evdi fork and still had the same issue

@infinytum:
I am running Slackware64-current. I tried building evdi-kernel under 5.15 and was not able to do so. The error message is the following: evdi-1.9.1/module/evdi_drm_drv.h:23:10: fatal error: drm/drm_irq.h: No such file or directory 23 | #include <drm/drm_irq.h>
What did you have to modify for it to build for you? I also downloaded the zip file from your evdi fork and still had the same issue

Are you sure you tried my repo? I removed that import from the file...
https://github.com/infinytum/evdi/commit/273fbb0a67eca5f60fd2aaab0e25076dae4d8a3a#diff-c00b60aa62f1d5ca62e486eff56f6f9a22e5659f0fcd1731e8cf83c95c409bc7L23

@infinytum:
Thank you for your guidance.  Somehow, even though the files were in the tar.gz file, as you mentioned, the /tmp for the build was pulling the files from some other location and overwriting them.  I copied the three files manually and evdi-kernel was able to build successfully

@FBobbioC Glad that worked out for you!

@infinytum Thanks for your repo, are you interested in other merges as well? Does seem the current developers don't really seem to care.

@infinytum Thanks for your repo, are you interested in other merges as well? Does seem the current developers don't really seem to care.

What merges would you have in mind?

@infinytum #315
However I still think they should do more about the performance issues everyone has when using this module.

@francoism90 Merged that PR into my repo.

Thank you everyone here! I just made forked package for arch user with kernel 5.15+ which  use the @infinytum fork for source.
https://github.com/aaronrancsik/evdi-arch

@aaronrancsik Awesome! Obligatory I use arch BTW, will take a look at it :)

@infinytum Would you be interested in merging this change: https://github.com/DisplayLink/evdi/compare/devel...francoism90:devel#diff-00c032df40cc677be61873c4a5fba0d6851007e96613f598524e74c212a1472a
It seems to mostly fix the logging issues when using options evdi initial_loglevel=0, they are still being reported elsewhere, but my knowledge about these kind of things is limited.

@displaylink-emajewsk @displaylink-mlukaszek @displaylink-dkurek @lspintzyk Could we have these changes merged? Currently broken in Arch Linux.

Hi All, we are planning to refresh the branch here on GitHub and we are indeed planning to include key PRs - sorry for the delay, the team have been occupied with other work and could not pick this up earlier.

For me, it is now broken with Arch LTS kernel 5.15.2-arch1-1. I used @aaronrancsik package and i'm back to a working system.

Hello, could you merge the patch soon ? All Arch users are blocked and need to use the fork of francoism90.
Thanks

I can compile the Kernel for 5.14 and 5.15, but the Module doesn't work.  It doesn't work for me at all on Xorg, but it does work fine on Wayland.

@francoism90 @robmaster2016
It does work for me. Build for linux 5.15.2. In x11 it works as expected, I created 20-evdo.conf as Arch Wiki says.
On wayland on amd card when I disable one of the monitors (mine displaylink has two ports), then the screen goes black. When they are both enabled, then it works. To avoid phantom space, I just dragged that phantom monitor onto another one.

Hello @displaylink-mlukaszek, many thanks for your input regarding this.
Do you have any estimation for when this could be available?
evdi is unfortunately not working for Linux 5.15 at the moment.

Can confirm it works with the latest Debian kernel upgrade (5.15.3)

It would be helpful to know the platform (CPU, graphic card) that does run the upgraded code.

There is only one real Debian platform (amd64) ;)
Intel Corporation CoffeeLake-H GT2 [UHD Graphics 630]
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz

This is something that the team is actively working on. You should see PRs getting verification and getting landed, so evdi itself would let you be compatible with fresh kernels again soon. We are currently targeting to release a full driver update in December, this requires much more testing that just evdi.

@displaylink-mlukaszek Thanks for the update, I'm looking forward to the new improved evdi module. :)

@infinytum:
I am running Slackware64-current. I tried building evdi-kernel under 5.15 and was not able to do so. The error message is the following: evdi-1.9.1/module/evdi_drm_drv.h:23:10: fatal error: drm/drm_irq.h: No such file or directory 23 | #include <drm/drm_irq.h>
What did you have to modify for it to build for you? I also downloaded the zip file from your evdi fork and still had the same issue

Are you sure you tried my repo? I removed that import from the file...
infinytum@273fbb0#diff-c00b60aa62f1d5ca62e486eff56f6f9a22e5659f0fcd1731e8cf83c95c409bc7L23

This worked for me on kernel 5.15.4, I hope new releases for Kernel 15+ are coming soon.

I ran into this on Ubuntu 21.10 Impish. I use https://github.com/AdnanHodzic/displaylink-debian to manage display link, which is basically a big shell script to run a bunch of commands I don't quite understand that gets all the kernel modules and systemd stuff in place.
For reference, this is what I did to get my monitors working again after updating to kernel 5.15.4.

ran the displaylink-debian script to uninstall everything

reboot, unplug the dock

ran displaylink-debian to install the latest versions of evdi and friends, reboot and plug the dock back in.
At this point, my docked keyboard/mouse work, but the monitors are blank. The displaylink-driver.service systemd service is constantly restarting itself (can see that in /var/log/syslog or running systemctl status displaylink-driver.service). The service is trying to ensure the evdi module is installed, and then if needed, runs dkms install evdi/1.9.1. That dkms is failing due to the drm_irq.h problem this issue is about.

gave myself permission to the evdi source code: sudo chown -R $USER /usr/src/evdi-1.9.1

edited those files to apply the changes mentioned earlier by @nilathedragon at https://github.com/nilathedragon/evdi/commit/273fbb0a67eca5f60fd2aaab0e25076dae4d8a3a#diff-c00b60aa62f1d5ca62e486eff56f6f9a22e5659f0fcd1731e8cf83c95c409bc7L23
At this point, the constant restarts of displaylink-driver.service finally succeed in running dkms install evdi/1.9.1, and the service is up and running. However, my monitors still didn't work.

Remove /etc/X11/xorg.conf.d/20-displaylink.conf, and reboot. This file was created by displaylink-debian, and didn't do the right thing for me.

If you're not using displaylink-debian, then patching /usr/src/evdi-1.9.1 and running sudo dkms install evdi/1.9.1 might be sufficient.

So I use fedora 35 and for me the simplest solution is this:

Install the displaylink driver rpm from https://github.com/displaylink-rpm:
wget https://github.com/displaylink-rpm/displaylink-rpm/releases/download/v5.4.0-1/fedora-34-displaylink-1.9.1-1.x86_64.rpm
sudo dnf install ./fedora-34-displaylink-1.9.1-1.x86_64.rpm
(Maybe) Install the source files for the current kernels:
sudo dnf install kernel-devel
Clone the fork of evdi from nilathedragon:
git clone https://github.com/nilathedragon/evdi
Copy the contents of evdi/modules to /var/lib/dkms/evdi/1.9.1/source/
sudo cp -r ./evdi/module/* /var/lib/dkms/evdi/1.9.1/source/

With this steps, on each kernel upgrade the dkms autocompiles the module and you don't have to worry about the version magic error and because of the great work of nilathedragon, it also works on the newer kernels.

Please, please push this upstream in a meaningful way.    Some OEM somewhere must be demanding this as well.

@jasonriedy I'm running evdi on Linux 5.15 using this repo. What are you missing?

Full integration with systems.  The semi-automatic compatibility with internal API changes that comes with being in-kernel.

I am fully with you. Basically upon upgrading each new Linux kernel, the battle begins to bring the monitor(s) back again. I must say, I cannot recommend anyone to buy a device which requires this driver.

Sorry to break anyone's bubble, but real Linux users normally do not
whine about doing some work.  This package needs to be compiled and
installed since it is not part of the kernel.  I use three external
monitors with the Dell D3000 USB 3.0 docking station and understand that
the extra work needs to be done after any kernel upgrade
On 12/4/21 19:52, Olof wrote:

I am fully with you. Basically upon upgrading each new Linux kernel,
the battle begins to bring the monitor(s) back again. I must say, I
cannot recommend anyone to buy a device which requires this driver.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DisplayLink/evdi/issues/308#issuecomment-986150417,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKMHD5JOCV7OGRDPKDMMFDUPLAUDANCNFSM5D4JPXJQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hello, I've been doing this "dance" the last 5 years and learned a bit about Kernel modules which I don't mind but can understand the frustration felt by others since it hasn't always been easy. I wanted to ask the group if there is any issue with the suggestion by @bprfh to benefit from the dkms autocompile. I've tested it with the recent 5.15.6 Kernel update and worked like charm.

@jasonriedy This is because evdi isn't part of the Linux-kernel (yet).
It would indeed be better to have this merged upstream, so users don't have to worry about building this themselves with DKMS, etc.
For now, package managers can use the latest commit, hopefully they do release a stable version this month.

@jasonriedy  Do you know if there are any plans to get this merged upstream?
I would gladly like to help to get it done (but did not done it before).

@wvdakker We'd like nothing more than to be merged upstream. However, for various reasons, that doesn't seem to be in the cards in the near future.
Until then we officially support only Ubuntu LTS kernels.

So from a casual outsider where does this sit? No support for any other kernel than Ubuntu LTS? I picked up a display link device and seeing the issue described trying to run on Pop!_OS 5.15.5-76051505-generic

So from a casual outsider where does this sit? No support for any other kernel than Ubuntu LTS? I picked up a display link device and seeing the issue described trying to run on Pop!_OS 5.15.5-76051505-generic

Yeah, I just happened to upgrade my System76 machine today as it was overdue and now my DisplayLink is also broken. I'm feeling like I need to just invest in a different dock and stay away from DisplayLink. And I'm not saying this is the DisplayLink developers fault.
At the end of the day I just need things to stay working.

@timnolte Have you tried my instructions?
If it doesn't work, try checking out this repo with the devel branch and then do the same steps again

@bprfh I just don't have time right now as I have a lot of work to get done. This happened on my work machine and fortunately it had a built-in external monitor connection I could use to at least get me by for now.

Sorry to break anyone's bubble, but real Linux users normally do not whine about doing some work.  This package needs to be compiled and installed since it is not part of the kernel.  I use three external monitors with the Dell D3000 USB 3.0 docking station and understand that the extra work needs to be done after any kernel upgrade
…
On 12/4/21 19:52, Olof wrote: I am fully with you. Basically upon upgrading each new Linux kernel, the battle begins to bring the monitor(s) back again. I must say, I cannot recommend anyone to buy a device which requires this driver. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#308 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKMHD5JOCV7OGRDPKDMMFDUPLAUDANCNFSM5D4JPXJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Such claims are the reason why Linux never made it as a mainstream Desktop system. My work requires me to actually "use" my computer for tasks that pay my bills. Fiddling around with displaylink stuff on every kernel upgrade does not pay my bills....

To be clear I did finally get it working with the adapter I had bought, but I had terrible ghosting on all my displays and just "broken" looking rendering. Sub-optimal at best and definitely not usable for day to day work. Will be returning the adapter unfortunately.
Took a chance hoping for the best, but it just didn't work out for my current setup.
Followed steps listed here in combination with displaylink-debian in case it helps anyone else.

To be clear I did finally get it working with the adapter I had bought, but I had terrible ghosting on all my displays and just "broken" looking rendering. Sub-optimal at best and definitely not usable for day to day work. Will be returning the adapter unfortunately.
Took a chance hoping for the best, but it just didn't work out for my current setup.
Followed steps listed here in combination with displaylink-debian in case it helps anyone else.

This did not do the trick for me. Now it is complaining about missing drm/drm-drv.h
In file included from /var/lib/dkms/evdi/1.9.1/build/evdi_platform_dev.c:30:
/var/lib/dkms/evdi/1.9.1/build/evdi_drm_drv.h:20:10: fatal error: drm/drm_drv.h: Aucun fichier ou dossier de ce type    20 | #include <drm/drm_drv.h>
Running Debian Sid with follwing kernel :
5.15.0-2-amd64 #1 SMP Debian 5.15.5-1 (2021-11-26) x86_64 GNU/Linux

displaylink-debian.sh downloads and extracts the contents of the official DisplayLink Ubuntu driver.

@chriscarpenter12  If this is correct (I cannot verify, not running Debian), this would overwrite the evdi files each time. When do you overwrite the files? Think @F4FXL keeps getting the old one.
Better would be DisplayLink just releasing a new evdi module.

If this is correct (I cannot verify, not running Debian), this would overwrite the evdi files each time. When do you overwrite the files?

After running dkms build evdi/1.9.1 the debian installer script seemed to detect it was already available ¯_(ツ)_/¯

Better would be DisplayLink just releasing a new evdi module.

Can't agree more. I was just trying to get something working.

I ran into this on Ubuntu 21.10 Impish. I use https://github.com/AdnanHodzic/displaylink-debian to manage display link, which is basically a big shell script to run a bunch of commands I don't quite understand that gets all the kernel modules and systemd stuff in place.
For reference, this is what I did to get my monitors working again after updating to kernel 5.15.4.
1. ran the `displaylink-debian` script to uninstall everything

2. reboot, unplug the dock

3. ran `displaylink-debian` to install the latest versions of `evdi` and friends, reboot and plug the dock back in.
   At this point, my docked keyboard/mouse work, but the monitors are blank. The `displaylink-driver.service` systemd service is constantly restarting itself (can see that in `/var/log/syslog` or running `systemctl status displaylink-driver.service`). The service is trying to ensure the `evdi` module is installed, and then if needed, runs `dkms install evdi/1.9.1`. That `dkms` is failing due to the `drm_irq.h` problem this issue is about.

4. gave myself permission to the `evdi` source code: `sudo chown -R $USER /usr/src/evdi-1.9.1`

5. edited those files to apply the changes mentioned earlier by @nilathedragon at [nilathedragon@273fbb0#diff-c00b60aa62f1d5ca62e486eff56f6f9a22e5659f0fcd1731e8cf83c95c409bc7L23](https://github.com/nilathedragon/evdi/commit/273fbb0a67eca5f60fd2aaab0e25076dae4d8a3a#diff-c00b60aa62f1d5ca62e486eff56f6f9a22e5659f0fcd1731e8cf83c95c409bc7L23)
   At this point, the constant restarts of `displaylink-driver.service` finally succeed in running `dkms install evdi/1.9.1`, and the service is up and running. However, my monitors still didn't work.

6. Remove `/etc/X11/xorg.conf.d/20-displaylink.conf`, and reboot. This file was created by `displaylink-debian`, and didn't do the right thing for me.

If you're not using displaylink-debian, then patching /usr/src/evdi-1.9.1 and running sudo dkms install evdi/1.9.1 might be sufficient.

This worked for me! PopOS update broke my display, this was the 3rd fix I tried and it works perfectly so far :)
Pop!_OS 21.10 - 5.15.5-76051505-generic

@amija004 did you do all of those steps or just

If you're not using displaylink-debian, then patching /usr/src/evdi-1.9.1 and running sudo dkms install evdi/1.9.1 might be sufficient.
On you Pop!_OS? I'm also on Pop!_OS, but using an actual System76 machine, so i don't really want to install a much that is not included and risk future update issues.

When I try to just patch the EVDI 1.9.1 source on my Pop!_OS 21.04 system(System76 hardware), and then run sudo dkms install evdi/1.9.1 I get an error the following error:
ERROR (dkms apport): kernel package linux-headers-5.15.5-76051505-generic is not supported
Error! Bad return status for module build on kernel: 5.15.5-76051505-generic (x86_64)

@wvdakker We'd like nothing more than to be merged upstream. However, for various reasons, that doesn't seem to be in the cards in the near future.
Until then we officially support only Ubuntu LTS kernels.

GA or HWE Kernel?

So I use fedora 35 and for me the simplest solution is this:
1. Install the displaylink driver rpm from https://github.com/displaylink-rpm:
   `wget https://github.com/displaylink-rpm/displaylink-rpm/releases/download/v5.4.0-1/fedora-34-displaylink-1.9.1-1.x86_64.rpm`
   `sudo dnf install ./fedora-34-displaylink-1.9.1-1.x86_64.rpm`

2. (Maybe) Install the source files for the current kernels:
   `sudo dnf install kernel-devel`

3. Clone the fork of evdi from nilathedragon:
   `git clone https://github.com/nilathedragon/evdi`

4. Copy the contents of evdi/modules to /var/lib/dkms/evdi/1.9.1/source/
   `sudo cp -r ./evdi/module/* /var/lib/dkms/evdi/1.9.1/source/`

5. Compile & Install the the new module  manually for the first time:
   `sudo dkms autoinstall`

With this steps, on each kernel upgrade the dkms autocompiles the module and you don't have to worry about the version magic error and because of the great work of nilathedragon, it also works on the newer kernels.

Devel branch already has the proper fixes for Kernel 5.15.

@amija004 did you do all of those steps or just

If you're not using displaylink-debian, then patching /usr/src/evdi-1.9.1 and running sudo dkms install evdi/1.9.1 might be sufficient.
On you Pop!_OS? I'm also on Pop!_OS, but using an actual System76 machine, so i don't really want to install a much that is not included and risk future update issues.

@timnolte I patched the notes according to the diff files.  I'm pretty sure these changes would be overwritten by a relevant update

When I try to just patch the EVDI 1.9.1 source on my Pop!_OS 21.04 system(System76 hardware), and then run sudo dkms install evdi/1.9.1 I get an error the following error:
ERROR (dkms apport): kernel package linux-headers-5.15.5-76051505-generic is not supported
Error! Bad return status for module build on kernel: 5.15.5-76051505-generic (x86_64)

I got this until I overwrote the evdi files. I needed to chown them and apply the changes manually. That was really the only step in the process necessary for me to get the dkms install to work.

@amija004 interesting, I tried patching the EVDI files and still got an error.

@amija004 interesting, I tried patching the EVDI files and still got an error.

@timnolte I'm running through my history to figure out what I did, sorry for the lack of clarity. I used the ubuntu installer instead of the debian. I completely uninstalled evdi as I had tried to use the APT version, ran the ubuntu installer, grabbed the EVDI from the given source, modified the files in the manner described, and then dkms install evdi/1.9.1.
It works, but I have to manually power down, software shutdown hangs. Small price to pay for working screens imo.

@amija004 huh, I think I may just bite the bullet and find a new dock that doesn't require DisplayLink, and hopefully also no EVDI. I'm not really OK with a buggy solution in my work machine. If it was just a personal machine that wasn't used as much I'd be OK dealing with some buggy issues but not when my time is going to cost either my company or my clients time or money.

@amija004 huh, I think I may just bite the bullet and find a new dock that doesn't require DisplayLink, and hopefully also no EVDI. I'm not really OK with a buggy solution in my work machine. If it was just a personal machine that wasn't used as much I'd be OK dealing with some buggy issues but not when my time is going to cost either my company or my clients time or money.

I was thinking the same too, I am tired of having to fiddle around and will look for a more turnkey solution.

From similar discussions (and conclusions, ie. to buy a different device), here's a non-displaylink recommendation from @GraemeDBlue
https://github.com/DisplayLink/evdi/issues/262#issuecomment-810614261

So it's possible that the DisplayLink team are keeping this relatively quiet because there may be further work in-progress, but after running into this same issue today, and for anyone curious to try it out:
288f4b62b5ee2ed9b4430c32a875da85d03c1a24 (within this repository) has resolved the drm_irq.h include issue, and I've been able to build an evdi module from aef6790272fce5d64d36d191dcb79d97021bfda7 that (after signing) loads correctly and provides DisplayLink support.

This has been fixed in evdi 1.10

why is this closed when it's still an issue?

This has been fixed in evdi 1.10

apt info evdi-dkms
Package: evdi-dkms
Version: 1.9.0+dfsg-1
Priority: optional
Section: kernel
Source: evdi
Maintainer: Hanno Stock<EMAIL_ADDRESS>Installed-Size: 160 kB
Depends: dkms (>= <IP_ADDRESS>)
Recommends: libevdi0
Homepage: https://github.com/DisplayLink/evdi
still has this issue

apt info evdi-dkms
Package: evdi-dkms
Version: 1.9.0+dfsg-1

As you can see your version is 1.9 and not 1.10. We don't maintain the "evdi-dkms" package, its updates rely on a third party.

for the records, on Debian side :
https://tracker.debian.org/pkg/evdi
1.10 tar gz available, not yet packaged
I installed from these packaged source and it works fine.

apt info evdi-dkms
Package: evdi-dkms
Version: 1.9.0+dfsg-1

As you can see your version is 1.9 and not 1.10. We don't maintain the "evdi-dkms" package, its updates rely on a third party.

you mentioned that you have your own repo. Can you send me the details?

you mentioned that you have your own repo. Can you send me the details?

I don't believe I did. For now, the only official way to get the software is here: https://www.synaptics.com/products/displaylink-graphics/downloads/ubuntu
If the company lets me set up actual repos, I'll tell you. 😋 I'd be happy to do it.

for the records, on Debian side :
https://tracker.debian.org/pkg/evdi
1.10 tar gz available, not yet packaged
I installed from these packaged source and it works fine.

Thank you very much man!! It worked perfectly for me.


[ISSUE #3888]Optimize xml file License

Fixes #3888
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications

Optimize xml file License

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Conflict resolution, please.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.93%. Comparing base (e1e9aca) to head (70485dd).
 Consider uploading reports for the commit 01c6426 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3890   +/-   ##
=========================================
  Coverage     13.93%   13.93%
  Complexity     1291     1291
=========================================
  Files           570      570
  Lines         28847    28847
  Branches       2811     2811
=========================================
  Hits           4019     4019
  Misses        24455    24455
  Partials        373      373

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mxsm Please fix conflicts.


Full support the macOS Big Sur

Have to modify the Engine 4.24 and 4.25 by https://github.com/EpicGames/UnrealEngine/commit/1d252ee345cdf6c232b20c3b4bf14f13bb569c9d.

Fixed


output: Summary is concise

Also include some other minor spacing fixes for the overall output

Okay. Fwiw this isn't immediately apparent to me as a user, seems
potentially more confusing than helpful. we should workshop this UI.
On Fri, Sep 14, 2018 at 11:50 AM, Han Yu<EMAIL_ADDRESS>wrote:

@yuindustries commented on this pull request.
In internal/summary/summary.go
https://github.com/windmilleng/tilt/pull/332#discussion_r217758911:

// K8s info

k := svc.k8sData

if len(k.Name) > 0 {

	ret += fmt.Sprintf("→ `kubectl get deploy %s` ", k.Name)

You mean, why do we say the whole "kubectl get deploy..."? Dan's idea is
that this is a hint to our users that they can find out more about the
deployed K8s service using that one-liner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/windmilleng/tilt/pull/332#discussion_r217758911, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGCg6BaR2Koz4NHtGHz52ooqAgAGZlVfks5ua9AtgaJpZM4WoIDt
.


not clear how to install visualstudio2017buildtools to use with node-gyp

choco install nodejs-lts python2 visualstudio2017buildtools -y

then
npm install a package that needs a native module built
get this error
    gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools"
    gyp ERR! find VS - "Visual Studio C++ core features" missing
    gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use

not sure what extra parameter i was supposed to pass at install time / why it isn't the default

i was missing the visualstudio2017-workload-vctools package as well


Support Podman in docker-compose setup

The "docker compose" subcommand to run docker-compose does not work when "docker" is a symlink to "podman" and "docker-compose" is a symlink to "podman-compose".
Use "docker-compose" instead of the subcommand to support running with Podman and give a hint in the docs on podman-compose.
How to use
With the mentioned symlinks.
Testing done
Tested make test-service-up

For podman-compose compatibility please also take this into account: https://github.com/kinvolk/nebraska/pull/627/files#diff-91315b4cf15177fd76e06ff8c63ccad1721d8ec2d518a82252aef2bda6b95f49R38-R39


Fixed a grammatical error in Unit docs

Fixed a grammatical from "a run time" to "at run time"
Please take a look.

Thanks. Can you send another PR with the commit message "A+C: add Bailey Lissington", adding yourself to AUTHORS and CONTRIBUTORS? When that's done, I'll merge this.

@llamington The second commit should be in a separate PR. We will need to fix up the commit message for the first commit and we cannot do this with the GitHub UI when there is more than one commit.

All sorted

Codecov Report
Patch coverage has no change and project coverage change: +0.88% :tada:

Comparison is base (88cd7bd) 73.94% compared to head (6becd39) 74.82%.
Report is 11 commits behind head on master.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
+ Coverage   73.94%   74.82%   +0.88%
==========================================
  Files         526      513      -13
  Lines       63135    66372    +3237
==========================================
+ Hits        46685    49664    +2979
- Misses      13884    14158     +274
+ Partials     2566     2550      -16

see 25 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


.github: workflows: probably shouldn't skip tests when PR found

Hey @rofrol. Thanks for all the nice work on zighelp.
I noticed that it looks like tests currently don't run on push to master if the merged commit came from a PR (follow up from commit https://github.com/zighelp/zighelp/commit/e9766e6638d077076ce0db85de3f5fb884dae3ad):
https://github.com/zighelp/zighelp/blob/febf8d2317fd630ea19257faa7a9058ebb735661/.github/workflows/push_on_master.yml#L30-L39
I couldn't immediately see in 8BitJonny/gh-get-current-pr when pr_found is false, but this looks suspicious to me. We can only be confident that testing the PR branch produces the same outcome as the master branch if both of these are true:

The PR is up to date with master at merge time. That is, the PR branch needs to either be based on the latest master commit, or have a merge commit with the latest master state. There are GitHub repo settings that enforce this, and that CI must pass on the PR branch.
The testing workflow is fully deterministic. This requires e.g. the version of every dependency to be pinned, such that running the same workflow at a later date should produce the same outcome. This is difficult to fully achieve on GitHub unless you run the tests in a container, because the contents of e.g. the ubuntu-22.04 image change constantly.

Does needs.pr.outputs.pr_found evaluate to true, and therefore cause the tests to be skipped, when the merged PR was not up to date with master?
Even if not, skipping tests could still produce a problem with item 2 above. It looks like CI in this repo only takes a minute or two, so I'd suggest just running tests unconditionally on push to master.
Thoughts?
Edit: Oh, sorry - I just saw that the last few PRs were merged via the merge queue. Maybe that's sufficient if it's guaranteed that every PR is merged via the queue.

Thanks.
Maybe I will also replace this push_on_master.yml with pr_merged.yml and then run deploy.
The problem with Github Actions is that you cannot have info if merge if from PR at the workflow level.
So now the docker vms are started for tests when there is no need for that. But I can't check that earlier.
Also Github Actions don't have downstream pipelines, so that I can decide what workflow would be next.
So anyway, this push_on_master.yml was only for me when I was pushing directly to master, but there are some nice upside with merge queue, so it is better to have every commit going through PR.
Thanks again :)


Chart runs out of colors when there are too many organizations

At the bottom of https://crfm.stanford.edu/helm/mmlu/latest/#/models

wontfix: Daisy only allows using the baked-in color names in this pie chart, so we can't specify our own hexadecimal colors, which means we're limited to as many colors as Daisy allows.


[service-bus] surface disconnect errors to streaming receiver error handler

/azp run js - servicebus - tests


Improved the type of the declaration to make things clearer

Hi @Atila-M-Schrieber thanks for contributing, I will review, test, and publish soon.


Add width constraint to content

Issue: https://github.com/thoughtbot/design-sprint-guide/issues/75
Constrains the content so it's not wider than 80rem.

Before
After

Looks good to me!


Use tabs to differentiate between API & CLI versions

I suggest that we use tabs instead. Makes it easier to read.

Agreed! Will make the tabs for them!