Improve documentation for the command line

I am trying to run model testing from a doi.
In the docs it said I should do  bioimageio test-model -m <MODEL>
But it said -m is not an option:
(bioimageio.core) weiouyang@europa:~$ bioimageio test-model -m 10.5281/zenodo.6224243
site.config.json: 5.69kiB [00:00, 2.26MiB/s]
...
bioimageio.spec 0.4.5post2
implementing:
        collection RDF 0.2.2
        general RDF 0.2.2
        model RDF 0.4.5
bioimageio.core 0.5.1
Usage: bioimageio test-model [OPTIONS] MODEL_RDF
Try 'bioimageio test-model -h' for help.

Error: No such option: -m

Remove the -m option works though.
For future improvements, from the command line, it also prints:
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/raw.githubusercontent.com/bioimage-io/bioimage.io/main/site.config.json. Skipping download of https://raw.githubusercontent.com/bioimage-io/bioimage.io/main/site.config.json.
  warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/bioimage-io.github.io/collection-bioimage-io/collection.json. Skipping download of https://bioimage-io.github.io/collection-bioimage-io/collection.json.
  warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")

A full log looks like this:

Click to expand!
(bioimageio.core) weiouyang@europa:~$ bioimageio test-model 10.5281/zenodo.6224243 --devices cpu
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/raw.githubusercontent.com/bioimage-io/bioimage.io/main/site.config.json. Skipping download of https://raw.githubusercontent.com/bioimage-io/bioimage.io/main/site.config.json.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/bioimage-io.github.io/collection-bioimage-io/collection.json. Skipping download of https://bioimage-io.github.io/collection-bioimage-io/collection.json.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
bioimageio.spec 0.4.5post2
implementing:
collection RDF 0.2.2
general RDF 0.2.2
model RDF 0.4.5
bioimageio.core 0.5.1
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/rdf.yaml. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/rdf.yaml.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/schema.py:46: ValidationWarning: tags: Missing tags for categories: [{'modality': ['electron-microscopy', 'cryo-electron-microscopy', 'fluorescence-light-microscopy', 'transmission-light-microscopy', 'super-resolution-microscopy', 'x-ray-microscopy', 'force-microscopy', 'high-content-imaging', 'whole-slide-imaging', 'other']}, {'dims': ['2d', '3d', '2d-t', '3d-t']}, {'content': ['cells', 'nuclei', 'extracellular-vesicles', 'tissue', 'plant', 'mitochondria', 'vasculature', 'cell-membrane', 'brain', 'whole-organism']}, {'framework': ['tensorflow', 'pytorch', 'tensorflow.js']}, {'software': ['ilastik', 'imagej', 'fiji', 'imjoy', 'deepimagej', 'n2v']}, {'network': ['unet', 'densenet', 'resnet', 'inception', 'shufflenet']}, {'task': ['semantic-segmentation', 'instance-segmentation', 'object-detection', 'image-classification', 'denoising', 'image-restoration', 'image-reconstruction', 'in-silico-labeling']}]
warnings.warn(msg, category=ValidationWarning)
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/schema.py:46: ValidationWarning: weights:torchscript: missing 'pytorch_version'
warnings.warn(msg, category=ValidationWarning)
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/fixed_zero_mean_unit_variance.ijm. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/fixed_zero_mean_unit_variance.ijm.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/hpaseg-cover.png. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/hpaseg-cover.png.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/README.md. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/README.md.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/sample_input_0.tif. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/sample_input_0.tif.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/sample_output_0.tif. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/sample_output_0.tif.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/test_nuclei_input.npy. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/test_nuclei_input.npy.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/test_nuclei_output.npy. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/test_nuclei_output.npy.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
/home/weiouyang/miniconda3/envs/bioimageio.core/lib/python3.8/site-packages/bioimageio/spec/shared/_resolve_source.py:349: UserWarning: found cached /tmp/bioimageio_cache/https/zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/nuclei_model.pt. Skipping download of https://zenodo.org/api/files/9f580ca7-5f85-41ac-be2b-201172ed09b3/nuclei_model.pt.
warnings.warn(f"found cached {local_path}. Skipping download of {uri}.")
code/torch/torch/nn/functional.py:21: UserWarning: Implicit dimension choice for softmax has been deprecated. Change the call to include dim=X as an argument.
Model test for 10.5281/zenodo.6224243 using torchscript weight format has passed.

While the outputs looks long, the line really matters is the last line said the test has passed.
Would it be possible to make these warning messages more cleaner? (I also see the message when running bioimageio test-model -h)

The docs are outdated. I will update them.

For the rest: I agree, I have complained with @FynnBe about all these warnings already but there is some reason for it...

Yes the cache warnings are annoying, but I am afraid of just removing them without updating the cache mechanism.
we currently simply go by url, which is very dangerous; thus the warnings. (see https://github.com/bioimage-io/spec-bioimage-io/issues/289)


samba: 4.19.5 -> 4.20.0, ldb: 2.8.0 -> 2.9.0

Description of changes
https://www.samba.org/samba/history/samba-4.20.0.html

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build samba

Result of nixpkgs-review pr 300156 run on aarch64-darwin 1

43 packages marked as broken and skipped:

anilibria-winmaclinux
arcan
booster
kaffeine
kodiPackages.inputstream-adaptive
kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.joystick
kodiPackages.libretro
kodiPackages.libretro-2048
kodiPackages.libretro-fuse
kodiPackages.libretro-genplus
kodiPackages.libretro-mgba
kodiPackages.libretro-nestopia
kodiPackages.libretro-snes9x
kodiPackages.pvr-hdhomerun
kodiPackages.pvr-hts
kodiPackages.pvr-iptvsimple
kodiPackages.pvr-vdr-vnsi
kodiPackages.steam-controller
kodiPackages.vfs-libarchive
kodiPackages.vfs-rar
kodiPackages.vfs-sftp
kodiPackages.visualization-fishbmc
kodiPackages.visualization-goom
kodiPackages.visualization-matrix
kodiPackages.visualization-pictureit
kodiPackages.visualization-projectm
kodiPackages.visualization-shadertoy
kodiPackages.visualization-spectrum
kodiPackages.visualization-starburst
kodiPackages.visualization-waveform
kphotoalbum
ldb
ldb.dev
python311Packages.python-vlc
python311Packages.python-vlc.dist
python312Packages.python-vlc
python312Packages.python-vlc.dist
qemu_full
sanoid
xarcan
zpool-auto-expand-partitions

1 package failed to build:

legba

14 packages built:

enum4linux
enum4linux-ng
enum4linux-ng.dist
python311Packages.pysmbc
python311Packages.pysmbc.dist
python312Packages.pysmbc
python312Packages.pysmbc.dist
samba (samba4)
samba.dev (samba4.dev)
samba.man (samba4.man)
sambaFull (samba4Full)
sambaFull.dev (samba4Full.dev)
sambaFull.man (samba4Full.man)
termscp

Hello Samba team!
This PR broke the build of sssd, because it is incompatible with Samba 4.20.
Could someone review my PR to fix the sssd build, please? :pray:


Selector for section references in Toc needs to be fixed

After recent changes there has been some regression appeared in toc references selector:

Related PR (#286) has been merged.


[WIP]Update dlpack implementation for PbTensor

This PR updates DLPack implementation for PbTensor according to Array API and DLPack v0.8 requirements.
Major changes:

Added __dlpack__ and __dlpack_device__ implementations according to Array API standard

Python Specification for DLPack
[Array API specification] (https://data-apis.org/array-api/latest/API_specification/index.html)

Current implementation is backward-compatible, i.e. PbTensor.from_dlpack() accepts PyCapsule (as before) and external tensor directly. PbTensor::FromDLPack takes care of that. Former PbTensor::FromDLPack -> PbTensor::FromDLPackCapsule
PbTensor::DLPack, which is bind to __dlpack__(self, Optional[Union[int, Any]] stream) make sure to synchronize streams, if needed (passed stream is not a default stream, not -1, and not a legacy stream). Since PbTensor does not support async execution, if DLPack receives default stream, sync is not needed.
I've implemented some refactoring, i.e. separated switch into PbTensor::DeviceType, because I realized I need this for DLPackDevice
DLPackDevice has returned type std::pair<int32_t, int64_t> with the following in mind. This isn't finished yet. When it is done, a more elegant type description can be put instead. For now I used types, which are indicated in the code. Open to any suggestions/alternatives
Added bool support

Fixes issue: 3944

My issue is, it is quite enforcing and may have an impact on the speed, as an example in BLS cases probably? As an alternative, we can make this sync conditional on either an environment label, or parameter, set with --backend-config flag. Let me know what you think

I was curious why the sync was required. Did you observe a failing test without synchronization?

@Tabrizian Yes, in the case of multi-gpu multi-stream, when streams are non - blocking, I encountered, that without synchronization, this test fails and we don't get an expected data.

@Tabrizian I found out that an issue in observed failing tests maybe not to the lack of synchronization in the from_dlpack method, but rather something is impacting tests, when they ran together. In isolation each test is passing without device sync. Currently investigating an issue

@Tabrizian It's ready for re-review. The only time we need synchronization is when we need to change context and there is a pending work on the default stream. Since standard does not say to sync on default stream, not everyone does. Then in this case we can return earlier, than work is done, thus cudaStreamSync(0) is added. I've also filed a ticket to investigate a strange behavior with cupy , multi-gpu non-blocking streams : DLIS-4887. For now, I run this test on a different second GPU.

Note for this PR: there is a necessity to follow up with CuPY and PyTorch to investigate why they do not (?) handle stream=1, i.e. do not convert it to the default stream (legacy stream)


replace tokenize_with_phrases with phrases and added tests

This PR will replace tokenize_with_phrases with phrases. I added unit tests as well for phrases.
This is the result of running ./tests.sh:
..............................................................................................................................................................
----------------------------------------------------------------------
Ran 158 tests in 9.798s

OK

This is the result of running ./format.sh:
All done! ✨ 🍰 ✨
6 files left unchanged.
All done! ✨ 🍰 ✨
6 files left unchanged.

Hey @cedricconol, thank you for your PR! 🎉
If you look under "Files Changed" you will notice how it's very hard to see your changes as it appears you replaced the whole file ... this is not optimal as we cannot see clearly what you changed in the code.
If you look at other PR, for instance #96, you will see that generally, only the code that has been changed is underlined: "Files Changed"
As it is, I cannot accept the PR, apologize! I encourage you to repeat the process and change only the relevant parts. I cannot help you more than this as I don't know really what happened ...
If you need further assistance, please let me know.
Regards,

hi @jbesomi, yeah you're right, my bad. This was because I copied and pasted the files from a sandbox directory. Will make adjustments as per your comments. Is it better if make another PR?

No problem @cedricconol! Yes, opening a PR might work as well or you can just add a new commit, as you prefer.
Regards,

Please check my latest commits @jbesomi, i hope i did it right this time :smile:

Hey Cedric!
Well done! 🎉
Some minor comments:

test_index: it's probably not necessary to create a new list. You can just add the test under test_cases_preprocessing
In the docstring, the word "frequrncy" is misspelled. We can also put backtick (`) around min_count
if not isinstance(s.iloc[0], list) or not isinstance(s.iloc[0][0], str):      raise ValueError("Input series should be a list of string.")
--> look under representation/term_frequency for a slightly better approach to deal with that. The idea is that we tell the user the input should be already tokenized. If not, we tokenize it for him but raise a Warning. If you look at the test_representation you can see how to check if the warning is raised correctly.

hey @jbesomi, kindly check my new commits, i have addressed your comments

Hey @cedricconol, thank you! This seems all good! 💯  I'm about to leave for a short trip, I will look into that again tomorrow evening or Monday and then merge it!

Hey Cedric, this seems very good to me!
Review:

Why are you doing delimiter = symbol.encode("utf-8"), is that necessary?
Limit the length of the docstring to 88 characters

Hey Cedric, this seems very good to me!
Review:

Why are you doing delimiter = symbol.encode("utf-8"), is that necessary?
Limit the length of the docstring to 88 characters

Thanks Jonathan!

I have to convert the symbol parameter from string to byte string because PhrasesTransformer requires the delimiter to be a byte string.
From #102, this should be 75 characters right? Should I only do this for phrases?

Hey @cedricconol,
Review:

There are still some conflicts to fix before I can merge it, can you take care of that?
Great you added the test to check for different symbols, that's why unit-test is so crucial ...
Unit-test:

test_phrases the name implicate we are testing to see if phrases are made, but as the default, min_count is 5 we see no changes from input and output.
I would propose to have four test (or something similar):
a.test_phrases with min_count=2 or 3 to test phrases
b. test_phrases_min_count to check min_count is respected
c. test_phrases_threshold to check threshold is respected
d. test_phrases_symbol with min_count=2 or 3 and a different symbol

Sorry for the confusion 75/88. Basically, black auto-format maximum line length to 88 characters (for the code), whereas numpy docstring requires 75 characters (for the docstring, but there is no check/auto-formatting for that) ... (I will try to make it more clear in the CONTRIBUTING) and see if we can find a way to check the max length is respected (couldn't find yet)

Hi @jbesomi,

Done fixing the conflicts.
I added more tests for phrases following your suggestion.
Although you haven't mentioned, I kept test_phrases_not_tokenized_yet.

Thank you, Cedric, awesome!! 🎉


 Yes

Version: 1.75.1 (user setup)
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
Date: 2023-02-08T21:32:34.589Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

OS Version: Windows 11

Steps to Reproduce:

Open VS Code
Sign in to Settings Sync with Microsoft account and wait for it to sync
Restart VS Code or Reload Window

Same issue in VS Code Insiders as well. I see #171904, but wasn't sure if this has the same underlying issue.
Setting log level to trace did not persist when restarting VS Code, so I tried reproducing the bug with Developer: Reload Window instead and luckily the same issue occurs.
Here are the log files when reloading the window:
Microsoft+Github Authentication.log
Settings Sync + Window.log

VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i5-12600K (16 x 3686)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.78GB (12.19GB free)

Process Argv
--crash-reporter-id 675bd63f-db50-4599-9021-04c9a555bb87

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaat:30438848
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
3biah626:30602489
pyind779cf:30657577
89544117:30613380
pythonsymbol12cf:30657549

Do you also see ton of vscode* credentials if you open (Windows') Credentials Manager?
I have similar problem. Deleting all of them helped for short time but problem reappear again for me.

Oh wow that actually works. Yeah I had 30+ entries of vscode* stored and deleting all of that fixes the issue, but seeing how it came back for you I'll leave this issue open and wait myself.

I have 159 entries. Took me more than 5 minutes to delete them all. Didn't get logged out at next restart.

Looks like related to #130893 but I've never saw mentioned error message.
And one-liner to clear keys can be found in https://code.visualstudio.com/docs/editor/settings-sync#_windows (thanks to lovettchris for mentioning this one in https://github.com/microsoft/vscode/issues/174290#issuecomment-1428783308)

@IllusionMH thanks for linking the doc and issue. I'll mark this as a duplicate as https://github.com/microsoft/vscode/issues/130893
and I'll update that issue with some details on our plan

/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Memory gradually grows and some data in a static table/collection is lost.

Influx version 1.7.7
Ubuntu 18.04
I am logging http responses of ~50 api endpoints with a cron job. It checks healths of urls.
5 columns in table, time and request_url is tag.
Start up ram usage is 300mb but after ~5 hours ram usage become 5gb and more.
I think, because of this problem, Influx is randomly deleting some data in table where i store urls.

@aliberatcetin can you post logs?


FYI it doesn't work with the latest version of  Keras (v. 0.3)

Error log:
python trainMLP.py
Using Theano backend.
loaded vgg features
loaded word2vec features...
Compiling model...
Compilation done...
Training started...
   128/215375 [..............................]Traceback (most recent call last):
  File "trainMLP.py", line 116, in <module>
    main()
  File "trainMLP.py", line 108, in main
    progbar.add(args.batch_size, values=[("train loss", loss)])
  File "/root/anaconda2/lib/python2.7/site-packages/keras/utils/generic_utils.py", line 143, in add
    self.update(self.seen_so_far+n, values)
  File "/root/anaconda2/lib/python2.7/site-packages/keras/utils/generic_utils.py", line 112, in update
    avg = self.sum_values[k][0] / max(1, self.sum_values[k][1])
TypeError: unsupported operand type(s) for /: 'list' and 'int'

Thanks for reporting this. I have not upgraded yet, but the following change should fix this particular error:
108: progbar.add(args.batch_size, values=[("train loss", loss[0])])


gendata format

Hello! First thanks for the code. Can you explain the format of  train_data,npy and train_label.pkl? Thanks a lot!

Hi,
train_data.npy is a Numpy array with the shape of (N,C,T,V,M), where:
N: number of samples
C: number of channels
T: number of video frames/ length of the sequence
V: number of human joints
M: number of persons
train_label.pkl is a tuple which has two elements, the first one is the name list of N samples,
the second one is the action label index of N samples.

what is "number of channels"?? we know about one image,3 channels means RGB ,but in this .npy file what is the meaning? @sjtuxcx @yysijie

@yanqian123, it usually means spatial coordinates 'x,y,z' of each joint.


Update DGPmap.sh

This update creates functions as wrappers for pipeline scripts to be invoked and allows for the ability for checking for files within each subdirectory. This minimizes compute times in the events of failures on computation.

Closed as was superceded with a new hotfix.


add code coverage

Signed-off-by: Augustin Husson<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ce9cf24). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage          ?   71.97%
=========================================
  Files             ?       11
  Lines             ?      578
  Branches          ?      131
=========================================
  Hits              ?      416
  Misses            ?      103
  Partials          ?       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9cf24...096a892. Read the comment docs.


Evil corp katas from step 5 onwards are empty files

Somehow, the files from step 5 onwards are empty.

This is correct as stated by @artkpv

No issue. Some katas end early.


Made some small changes as suggested by FSharpLint.

Thank you for the PR, but we would like to leave the expanded form for now.


Transparent with Opacity not working

Describe the bug
A window with transparent background and opacity 0.5 got a window in white background only on Windows 11.
To Reproduce
Steps to reproduce the behavior:
Please use the code for MainWindow.axaml after created a new Avalonia Cross-platform UI App and run.
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="Transparent.MainWindow"
		Background="Transparent"
		TransparencyLevelHint="Transparent"
		TransparencyBackgroundFallback="Black"
		Opacity="0.5"
	    ExtendClientAreaToDecorationsHint="True"
        Title="Transparent">
    Welcome to Avalonia!
</Window>

Expected behavior
A window with 0.5 opacity transparent window should come out
Screenshots
Actual result I got:

But in the designer, actually it seems like got some transparent effect.

Desktop (please complete the following information):

OS: Windows 11
Version 0.10.18

Same issue

OS: Windows 11
Version:	10.0.22000 Build 22000

As of today I am also seeing the same issue.

VS 2022
Avalonia 0.10.18
Windows 11 10.0.22621 Build 22621

Iirc you need to build/publish with win7-x64 modifier, otherwise a needed dll is not copied to the output. Can you try it and double-check if it solves your issue?


Re-enable support for download-status

On 4.x.x, support for download-status was removed, so now there's no way to have a feedback of the current progress. Since now several files can be downloaded at once, it would be ok, if the download progress is the total of all the files, but a better option is to have support for an independent progress for each file if they don't interfere in the screen.

Yup, just need https://github.com/sindresorhus/got/pull/41 to be merged.

Thank you.


update: use gauge in leaf split

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#233
#232
#231  👈
#229
#228
#227
#226
#225
#224
#223
#221
#220
#219
#218 : 1 other dependent PR (#222 )
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Aug 12, 11:33 AM EDT: @rphmeier started a stack merge that includes this pull request via Graphite.


M3-1770 Group Import CTA

Group Import CTA
Description
This PR adds a CTA on the Dashboard to import Groups and convert them to tags.

Included is a memoized selector (using Reselect) needed to get Linodes with eligible groups to import. This selector can be reused in the Group Import Drawer.
To test

Have a Linode with a display group (via Classic Manager) without a corresponding tag.
Go to the Dashboard.
Observe: the CTA will be displayed.
Add the name of the display group as a tag for your Linode.
Refresh the application.
Go to the Dashboard.
Observe: the CTA will NOT be displayed.

Notes:
Step 5 (refreshing the application) is necessary because the selector is memoized, meaning it won't re-run unless there is a change to the appropriate piece of Redux state (__resources.linodes.entities). When adding/deleting tags are refactored as events updating Redux state, this step won't be necessary.
New Library:
Reselect (it's awesome).
New Component:
src/features/Dashboard/GroupImportCard
New directory:
src/store/selectors <-- where Reselect selectors will live

Coverage increased (+0.07%) to 32.437% when pulling d622bd4de718071c0c57abec3a1811a1e8a4fb16 on johnwcallahan:M3-1770-group-import-cta into 30ddf5d79617cad12c1ec6afeebec45b5c28f814 on linode:feature/group-tags.


Type promotion failure in for loop with type parameters

The following code:
void f<T>(Iterable<T> Function() g, void Function(T) h) {
  for (var x in g()) {
    if (x is String) {
      h(x);
    }
  }
}

Produces the analyzer error:
error • The argument type 'String' can't be assigned to the parameter type 'T'. • .../test.dart:4:9 • argument_type_not_assignable

There should be no error; the type of x should be inferred to be T, and the if test should promote it to T & String, which is a valid subtype of h's parameter type, T.
The problem bisects to 7c1fa846cdc2830149b43bb35a847f8e3f326683.
This bug is blocking an internal roll, so we're considering it blocking for D27.

Found the problem.  When inferring the type of the loop variable, we were failing to account for the fact that the iterable expresion might be rewritten during analysis (in this case, it is being rewritten from a method invocation to a function expression invocation), so we were losing the inferred type; hence x's type was being inferred to be dynamic, and so it was being promoted to String, which is indeed not assignable to T.
Fix is out for review: https://dart-review.googlesource.com/c/sdk/+/123483


Dev/navigation skeleton

Added navbar, navigation items, and basic file-based routing hierarchy.

~spooky skeleton~
structure looks good. it'd be a good idea to have detailed requirements in readme.md
it might also be a good idea to add the paths to major pages and their assets in the readme itself, something along the lines of "The landing page | Path: "path to landing page" etc...

~spooky skeleton~
structure looks good. it'd be a good idea to have detailed requirements in readme.md
it might also be a good idea to add the paths to major pages and their assets in the readme itself, something along the lines of "The landing page | Path: "path to landing page" etc...

This is a great idea! Could you create a branch that adds these requirements to the readme for the repo?


Successful JS response shows no flash message

Hey guys,
First of all, responders is great.
But let's get down to business.
I'm working with default responder gem settings. I've got responders setup for a create action and a :js response. On a successful object creation, it's rendering my javascript response just fine. But...it's not showing the flash message.
Here's my create method:
def create
  @adult = Adult.find(params[:adult_id])
  @note = @adult.adult_notes.create(note_params)
  respond_with @note
end

I pry'ed the gem open and noticed that the code ran through this method twice, with a nil value first and the desired flash message second. So it appears that the logic to set the flash is sound, but sending that logic to Rails is breaking somewhere. Here's the method:
def set_flash(key, value)
  return if value.blank?
  flash = controller.flash
  flash = flash.now if set_flash_now?
  flash[key] ||= value
end

I got around the issue by explicitly stating the flash.
def create
  @adult = Adult.find(params[:adult_id])
  @note = @adult.adult_notes.build(note_params)
  flash[:notice] = "Your note has been added." if @note.save
  respond_with @note
end

Gotta have my flash! Thoughts?

^ I posted that from the wrong account....I'm a real person!
Is this a bug?

Can you please provide a sample application that reproduces the error?

Thanks for the response @nashby. Frankly, I'd rather not.
I appreciate your helpfulness, though. Please close this.


added autoscaling describeScalingActivities support

The ID here is a guid (maybe I'll get un-annoyed by this one day):
{
activityId: "c1111e1e-1b11-11fe-1da1-fd11a111e1cf",
autoScalingGroupName: "asgname",
cause: "At 2013-11-11T11:11:11Z a monitor alarm asg-alarm-name in state ALARM triggered policy asg-policy-up changing the desired capacity from 1 to 2. At 2013-11-11T11:11:11Z an instance was started in response to a difference between desired and actual capacity, increasing the capacity from 1 to 2.",
class: "com.amazonaws.services.autoscaling.model.Activity",
description: "Launching a new EC2 instance: i-abcdef78",
details: "{"InvokingAlarms":[{"Region":"US - N. Virginia","OldStateValue":"OK","AWSAccountId":"blahblah","AlarmName":"asg-alarm-name","AlarmDescription":null,"StateChangeTime":1385746272474,"NewStateReason":"Threshold Crossed: 1 datapoint (85.679) was greater than or equal to the threshold (85.0).","NewStateValue":"ALARM","Trigger":{"Period":300,"Statistic":"AVERAGE","MetricName":"CPUUtilization","Threshold":85,"EvaluationPeriods":1,"Dimensions":[{"name":"AutoScalingGroupName","value":"asgname"}],"Namespace":"AWS/EC2","ComparisonOperator":"GreaterThanOrEqualToThreshold","Unit":null}}],"Availability Zone":"us-east-1d"}",
endTime:<PHONE_NUMBER>000,
progress: 100,
startTime:<PHONE_NUMBER>644,
statusCode: "Successful",
statusMessage: null
}

Also, Details looks like it's being mapped as a string which I'd like to parse out to seperate fields but I'm not sure how dynamic that data is yet or if it's usable as is.

Scaling activities added in #84


Remove errors from some function signatures

io.BufBinWriter actually can never encounter errors. This means that e.g. BlockBase.GetHashableData will never return an error. This in turn lowers our test coverage and makes code unnecessary verbose.
I suggest to make it and similar functions to return no error.
Thoughts? @roman-khimov @volekerb

We probably can do that, although it requires very careful review in each of the cases. It might also require Bytes() simplification to not put error into the bw.Err (just following regular bytes.Buffer semantics wrt Bytes() and read/writes), it needs to be documented (and commented in every case of buffer usage that doesn't check for error). But yes, that would be a nice simplification.


NCT38xx GPIO interrupt driver never enabled

Describe the bug
The Kconfig symbol that enables the gpio_nct38xx_alert.c driver is never set.
The Kconfig symbol is missing a depends statement to automatically enable the symbol based on a devicetree node with status OK.
Snippet from Kconfig.nct38xx
config GPIO_NCT38XX_INTERRUPT
	bool "NCT38XX GPIO interrupt"
	help
	  Enable interrupt support in NCT38XX driver.

Cmake snippet
zephyr_library_sources_ifdef(CONFIG_GPIO_NCT38XX_INTERRUPT gpio_nct38xx_alert.c)

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/61438


Refactor DocumentDb Factory, fix #202.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

Codecov Report

Merging #203 into master will decrease coverage by 0.44%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage    80.5%   80.05%   -0.45%
==========================================
  Files          40       40
  Lines        1026     1018       -8
  Branches      139      140       +1
==========================================
- Hits          826      815      -11
- Misses        130      131       +1
- Partials       70       72       +2

Impacted Files
Coverage Δ

.../spring/data/cosmosdb/core/DocumentDbTemplate.java
84.64% <100%> (-0.07%)
:arrow_down:

...smosdb/config/AbstractDocumentDbConfiguration.java
100% <100%> (ø)
:arrow_up:

.../azure/spring/data/cosmosdb/DocumentDbFactory.java
90.47% <83.33%> (-9.53%)
:arrow_down:

.../spring/data/cosmosdb/config/DocumentDBConfig.java
92.3% <0%> (-7.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c81152...68fe6fe. Read the comment docs.


Allow Table zebra lines to be optional

Detailed description

Describe in detail the issue you're having.

Table rows are always in zebra background colors, allow all white backgrounds.

Is this a feature request (new component, new icon), a bug, or a general issue?

general issue

Is this issue related to a specific component?

Table

What did you expect to happen? What happened instead? What would you like to see changed?

'bx--data-table-v2--zebra' class is optional

What browser are you working in?

All

What version of the Carbon Design System are you using?

5.29.4

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM Cloud
Additional information

Hi @nicoxxie! Would defer to this article which recommends using zebra stripes due to the following rationale:

The recommendation
The results of the three studies conducted to date suggest that the safest option is to shade the alternating, individual rows of your table with a single color. Taking this approach is likely to ensure that:

task performance is better, or at least no worse, than with other table styles, and
the aesthetic sensibilities and subjective preferences of the majority of your users are catered for.

If zebra striping of this type cannot be done easily, then ruling a line between each row may be the next best option.

@joshblack I see your point, bringing up to our designer.

@joshblack @alisonjoseph Was a decision made on this? Mh team would also like the zebra rows to be optional. I see that they are currently optional in the DataTableSkeleton component but are still not optional on for the Table itself.

Hi @bellsworth13! 👋 Any chance the designers could weigh in based off of the feedback in that article?

@joshblack @bellsworth13 I believe the zebra stripes used to be optional and were used less frequently than the plan white rows. On the dashboard in particular I feel that they add unnecessary visual complexity, especially now that we have the blue row hover.
Most importantly when there is blue link text or anything at all lightweight in a dark zebra row, the blue hover makes it dark enough as to be inaccessible. I guess that's something to look into fixing, but I definitely think in general designers should have the option to not have zebra stripes.

@joshblack Re: the article above - the tables without zebra stripes do have those thin rules between rows that the article mentions

Makes sense, thanks for the explanation @vsnichols! 👏

If I made a PR to address these changes, would it be accepted or is there still further discussions to be had?

Go for it @bellsworth13!

#1207 seems to address this problem. Don't hesitate to speak up if anybody sees otherwise - Thanks!


Particle size and camera FOV

First of all, congrats for this awesome work.
Now the problem ...
The particles size (on screen) depends on the camera field of view.
This is a known issue, nothing to do about that.
However, if you change the emitter sizeStart and sizeEnd at runtime, you don't get any change on screen.
Example:
you start with camera.fov = 45, sizeStart = 0.5, sizeEnd = 1.0
at runtime you set camera.fov = 22.5, sizeStart = 1.0, sizeEnd = 2.0
The camera fov is changed ( camera.updateProjectionMatrix(); ), but the new sizeStart & sizeEnd values are ignored.
Result: you'll get smaller particles on the screen.
cheers

Well, I found a workaround:
		onParticleSpawn: function( attributes, particleIndex ) {
			attributes.size.value[ particleIndex ].set( 0.4 * zoom, 0.7 * zoom, 1.0 * zoom );
			attributes.size.needsUpdate = true;
		}

But it doesn't work for the already existing particles.
cheers

Sadly this is quite normal as we're working with a TRHEE.Material here. You have to update materials when you make changes.
Also, this looks to be an anti-pattern. The point of a an engine is to define target states and remove responsibility of transition from the user.

Hi Alex,
The main problem is that the ShaderMaterial is embedded into the ShaderParticles.js package
and there is no way to pass the "size" value (sizeStart & sizeEnd) at runtime.
Or maybe I'm missing something here ...
cheers

You probably don't mean this:
var particleEmitter = new SPE.Emitter({
    sizeStart: 10,
    sizeEnd: 0,
});

Emitters aren't supposed to change much. But I see what you mean about embedding.
group.material;

Material is exposed via "Group", you can access attributes there, maybe this will help.

Here is the "onParticleSpawn":
http://necromanthus.com/Test/html5/testA.html
Take a look at the "steam" and press the right mouse button (a few times).
The result is not bad, but it can be better if the already existing particles would be scaled as well.
cheers

You probably don't mean this:

var particleEmitter = new SPE.Emitter({
sizeStart: 10,
sizeEnd: 0,
});

Emitters aren't supposed to change much.

In fact emitter.sizeStart and emitter.sizeEnd need to be changed at runtime.
You don't want to change the size thousands of times (for every particle).
You need to change the size only once (for the current and upcoming particles).
But this is not possible with the current ShaderParticles.js package.
cheers

And here is the best workaround (with perfect results):
			for (var p = 0; p < emitter.attributes.size.value.length; p++) {
				emitter.attributes.size.value[ p ].set( 0.4 * zoom, 0.7 * zoom, 1.0 * zoom );
			}
			emitter.attributes.size.needsUpdate = true;

But you need to change the sizeStart, sizeMiddle & sizeEnd for all the current particles!
Instead of changing those values only once ...
http://necromanthus.com/Test/html5/testA.html
cheers

The reason you wouldn't want to change it at run-time is because of GPU access, re-binding attribute arrays takes some time. I'm not sure how much though. It's not the same as rebuilding shader, but it's not free. Re-binding attributes of single value is also likely to be a lot cheaper than things like large arrays, such as in case of particles we have here. Just a word of caution; if this doesn't impact you enough - then i'm glad you found a good solution for yourself.
To clarify "rebinding" - when you set "needsUpdate = true", you request that GPU-bound values are to be scrapped and current data from javascript be written instead. If your array has 1000 elements and you just change 1 of them - still all 1000 will be written.
As much as I care about performance - depending on your use-case it's likely not an issue.

Alex,
You miss the main point here.
With that "workaround" I don't get any performances drop for 1500 particles.
Besides, you don't have to run it every frame!
You run it only when camera.fov is changed.
In any case, the solution to all of these is very simple:

all the emitter.attributes need to be passed at runtime
inside of the "tick" function: if an emitter parameter was updated, all the current particles must be updated
So depending on the emitter.attributes.parameter, that loop is performed for all the current particles.
That's all and nothing more.

cheers

1500 particles is not much. Maybe fov handling souls be done in shader, that's the gist odd my point. Glad you're problem is solved :)

Maybe fov handling souls be done in shader, that's the gist odd my point.

If that's faster and it gives the same good results, I totally agree.
The bottom line:
the users must be able to pass at runtime the particle "size" ( in fact v3(sizeStart, sizeMiddle, sizeEnd) )
to the shader or to the emitter.
And all the current (and upcoming) particles must be updated after that.
But only once!
best regards

Hey @RemusMar / @Usnul,
Only just caught up on this (out of the country at the moment).
@Usnul: many thanks for getting involved! As a little aside, v2 of this lib is still floating around in an... interesting state, but it does allow for runtime changes at least. One day... One day it will see a release!
@RemusMar: It looks like a solution has been found, but I have to agree that its not ideal. Runtime changes should really be an allowed thing, so I'll see what I can bake into the library for the next (minor, possibly major if the API changes as a result [something I will try damn hard to avoid!]).
I have an idea milling around in my head for this (thinking about getters/setters via Object.defineProperty), but it will require a fair amount of internal changes to do it "correctly"; it's not something I just want to hack in. It might also save a few cycles when respawning particles, which can only be a good thing.
I'll start playing around with some ideas soon and let you know how progress goes soon.

as an aside. @squarefeet put some code up - I will get involved. It'll never be perfect :)

I have an idea milling around in my head for this (thinking about getters/setters via Object.defineProperty), but it will require a fair amount of internal changes to do it "correctly"

Hi Luke,
It sounds like a good idea.
cheers

@Usnul: It's been a while since I last looked at it, but I'll have a gander tomorrow and see what state it's in. If it ain't too bad, I'll send you an invite to it so you can hack away as well. If it's a dire mess, I'll tidy it up a little and then do that.
@RemusMar: cool cool - I'll keep you informed on this thread :)

Hi all, I am really new to using THREE js and Particle Shader . I am currently creating a particle effect using this Shader Particle Engine.I want to change couple of variables during runtime  .I could change particlecount,velocity ,acceleration,type,blending,speed  but could not change colorStart,colorEnd along with startSize,endSize.I saw this thread and would like to ask if its a similiar issue with changing  color as well?or am i missing anything simple.
Thanks!

could not change colorStart,colorEnd along with startSize,endSize

Probably the only workaround is the following:
	for (var p = 0; p < emitter.attributes.colorStart.value.length; p++) {
		emitter.attributes.colorStart.value[ p ].setRGB( 0.3, 0.2, 0.1 );
		emitter.attributes.colorMiddle.value[ p ].setRGB( 0.45, 0.3, 0.15 );
		emitter.attributes.colorEnd.value[ p ].setRGB( 0.6, 0.4, 0.2 );
	}
	emitter.attributes.colorStart.needsUpdate = true;
	emitter.attributes.colorMiddle.needsUpdate = true;
	emitter.attributes.colorEnd.needsUpdate = true;

You need to replace the RGB vaues with yours.
cheers

@RemusMar  : Thanks a lot ..it works for now :) ..appreciate your quick help.

Hi all,
I'm making some decent progress on being able to change parameters at runtime, so hopefully I'll have something in a branch for you to take a look at soon!

Hi again,
I've pushed a new branch called runtime that you're welcome to check out. There's a new example called runtimeChanging.html that uses DAT.Gui to let you change parameters at runtime.
I've not done a huge amount of testing across various devices yet, but from what I can tell I've managed to accidentally speed things up ever-so-slightly, so that's never a bad thing.
Let me know if you have any issues/bugs with it.
Cheers!
PS. This branch also includes fog support, so if you get any shader compilation errors, let me know as that will be the source for that. Changing attributes at runtime doesn't affect the underlying GLSL, so any GLSL errors will be due to the still-in-progress fog support.

@Usnul - Just tagging you; if you have a spare sec would you mind giving this a whirl? Cheers buddy :)

I've pushed a new branch called runtime that you're welcome to check out.
There's a new example called runtimeChanging.html that uses DAT.Gui to let you change parameters at runtime.

Well done Luke!
However ... changing at runtime emitter.sizeStart, emitter.sizeMiddle & emitter.sizeEnd works for the UPCOMING particles only.
The size of the current particles is not changed (so they need to "die" to get the right results).
From this point of view, my workaround is still the best solution.
cheers

Ah - it wasn't made clear that you wanted immediate updates. I'll think about adding in more direct support for this, that will take care of emitter attribute offsets and whatnot (your solution doesn't do that, so if you have more than one emitter in a group, you'll affect all that group's particles).

Ah - it wasn't made clear that you wanted immediate updates.

Luke, it's not about what I want.
Just try to imagine that in some cases the particles do not die at all, so your solution does not work at all.
In my opinion, that loop with emitter.attributes.size.value[ p ].set( ... ); is a the only solution.
http://necromanthus.com/Test/html5/testA.html
Take a look at the "steam" source and press the right mouse button several times.
This is the perfect result using my workaround.
I want the same result using
	steamEm.sizeStart = 0.4 * zoom;
	steamEm.sizeMiddle = 0.7 * zoom;
	steamEm.sizeEnd = zoom;

cheers

I'm well aware of that; it's just a use case that didn't cross my mind, but my point still applies: your solution doesn't take into account that there may be more than one emitter (with different settings) per group - you update all the attributes for all of a group's emitters with the same values.
I've almost got something in place that will allow you to do what you need.

PS. Once I finish this, you'll be able to do this:
steamEm.sizeStart = 0.4 * zoom;
steamEm.sizeMiddle = 0.7 * zoom;
steamEm.sizeEnd = zoom;
steamEm.attributesNeedUpdate = true; // Forces all attributes to be updated immediately

It's a bit of a mess at the moment (not very DRY!), but I'll refactor it once it's stable and works as expected. Will let you know when the runtime branch is ready for you to pull.

steamEm.attributesNeedUpdate = true; // Forces all attributes to be updated immediately

I don't think you need to update ALL the emitter attributes.
It will run faster with:
		steamEm.attributes.size.needsUpdate = true;

cheers

attributesNeedUpdate is specific to this library, I just followed the naming convention from THREE.js. It just notifies a few functions in SPE.Emitter that all the attributes that have been changed for that emitter need to be updated, not just ones that are being respawned.

Okay, runtime branch is ready for you to pull. There's a fair bit of optimisation and whatnot to do, but it seems to be working as you'd like:
steamEm.sizeStart = 0.4 * zoom;
steamEm.attributesNeedUpdate = true;

Well done Luke!
Clear the browser history and try again this link:
http://necromanthus.com/Test/html5/testA.html
		steamEm.sizeStart = 0.4 * zoom;
		steamEm.sizeMiddle = 0.7 * zoom;
		steamEm.sizeEnd = zoom;
		steamEm.attributesNeedUpdate = true;
		camera.zoom = zoom;
		camera.updateProjectionMatrix();

cheers

So it's all working fine, yeah? No bugs that you've seen?


Right click menu closes on right click release

Issue Type: Bug
I am using VS Code on ubuntu 20.04.1LTS 5.8.0-43-generic, x86_64.
VS Code is installed using deb file, not snap.
I am developing in C++ (linux-gcc-arm).
Problem:
In the editor window, when I right click (to find all references, or whatever), the right click menu is only shown for as long as I hold the right button down - releasing the button behaves as if I had left clicked whichever menu item the pointer is currently over.
I have confirmed behaviour is normal outside VS Code.
I have read of a similar issues with GitLense, so I have disabled that extension, which had no effect.
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:44.518Z)
OS version: Linux x64 5.8.0-43-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10810U CPU @ 1.10GHz (12 x 3291)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
30.97GB (14.66GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id b83f6678-03cd-4f96-a387-0f2fce063f0e

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (25)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.2.0

systemd-unit-file
coo
1.0.6

vscode-great-icons
emm
2.1.64

shell-format
fox
7.0.1

gc-excelviewer
Gra
3.0.41

vscode-back-forward-button
gri
0.1.4

easy-icons
jam
0.3.1

theme-dark-plus-contrast
k3a
0.1.101

ruby-rubocop
mis
0.8.5

prettify-json
moh
0.0.3

vscode-docker
ms-
1.9.1

python
ms-
2021.1.502429796

jupyter
ms-
2020.12.414227025

remote-containers
ms-
0.158.0

cpptools
ms-
1.2.0

deepdark-material
Nim
3.3.0

ruby
reb
0.28.1

c-cpp-definition-generator
rei
0.0.2

code-spell-checker
str
1.10.2

sort-lines
Tyr
1.9.0

vscode-icons
vsc
11.1.0

debug
web
0.25.0

vscode-ruby
win
0.28.0

linkerscript
Zix
1.0.1

vscode-proto3
zxh
0.5.3

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstry914:30256638
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

This might be a duplicate of https://github.com/microsoft/vscode/issues/113175.

Yes, it looks like a duplicate - should I just close this one or is there some way to mark it as a duplicate?


Use proto3 JSON mapping for web requests [phab:D571]

Created by schroederc at 2015-10-21 20:59:58:
For our APIs, this only changes the way enums are encoded.  They are now
strings of each enum value's name instead of integers.  However,
integers are still acceptable during decoding so this shouldn't break
anything.
Context: https://developers.google.com/protocol-buffers/docs/proto3#json

schroederc wrote at 2015-10-21 21:06:06:
Remove unnecessary dependency

shahms accepted this revision at 2015-10-21 21:15:47

schroederc closed via commit 21fe9f710c8426a2dfc3e251a088c4b91d736b2d at 2015-10-21 21:37:54


Add some more conditional styling and transitions to the image feed

I think it could still use some work.
Resize on change instead of input to avoid input jank when changing the size at left or right
I think if the controls were in a menu instead of on the component that would fix the issue.
The interaction between feed size and image size also still feels unintuitive to me.

scrnli_7_17_2023_3-21-37 PM.webm

Do you have any other ideas for how this could be improved?

Sorry for lack of feedback on this!
I'm not really sure... I personally like the resizing done on input rather than change as when swapping between different image sizes/browser sizes I like to resize it to the "perfect" point which is hard to do without instant feedback
Maybe as you said moving the inputs into a menu would be the best fix for it, a little settings cog that when you hover over it pops up a menu with the two sliders on in a fixed position based on where it opened.
Agreed about the feed and image size behavior, but I couldn't get anything that didnt feel a bit weird working!

Or it could be the image size is a width, the number of columns (left/right) or rows (top/bottom) would define the size of the feed.

Okay, I think this is a bit nicer.
https://github.com/pythongosssss/ComfyUI-Custom-Scripts/assets/448862/6f3f567d-28f3-467e-b8c7-2d11176da244

I still think making the image size a discrete "number of columns" would be cleaner.

Yeah, I like this one, works really well - good job, thank you.
I'm not opposed to it being a number of columns if that works better, but what you've got here is nice


[ci skip] add -pre to README This fixes #191 issue

As a temporary solution before release for newcomers
(As for me, it was really frustrating when i tried old stable release, see #191 issue for detailed explanation)

I don't really want to change the instructions everywhere, but I've added a known issue in the readme:

Ruby 2.2 / SMTP not working
MailCatcher does not currently support Ruby 2.2. EventMachine added support in 1.0.4, but regressed other things so is unuseable, even on earlier rubies.
Please use Ruby < 2.2 and EventMachine < 1.0.4. You can gem install mailcatcher --pre for a version which restricts to eventmachine < 1.0.4.


[FEATURE] Allow default value to be returned as fallback for Adapter#get being undefined.

Is your feature request related to a problem? Please describe.
Checking for a value to exist or .get being undefined required additional logic. Simply that logic for the workflow.
Describe the solution you'd like
await adapter.get('key', { defaults: "some object or value" })

Describe alternatives you've considered
N/A
Additional context
N/A

Closed by #22. The feature has been implemented in the future v1.2.0 release.

Closed by #22. The feature has been implemented in the future v1.2.0 release.


500 Error while minting with a redeemer

I'm getting an error while trying to mint some token, I'm not sure the root cause of this, but removing the redeemer argument from the mintAssets function call does fix this issue (ofc it introduces another error when I try to submit the tx, MissingRedeemer), so the issue seems to be related to the redeemer.
So the error comes from an API POST call to https://cardano-preprod.blockfrost.io/api/v0/utils/txs/evaluate, the payload is
84a500818258209cf09788720d113a3d8bf0d0bb4809c81e0047257caffc6e1e6bbad9c17e11cc010182825839005d095b0f1065d61f245975cd8e1ec032e6242e3c0cbef2b48e3c889a58e2dff1e88b7e57bf6265bf684c0ca487b0dbc06e094a0a59d518c9821a00111958a1581c919d4c2c9455016289341b1a14dedf697687af31751170d56a31466ea1400182583900171b921e6e00004953b196e1ddd2e2434b1f41af1fe5e84ad2d422dfa5fd2a798a0961963400cb396605bd4dacddbbcb2279164d297ff0951b000000024b257cf7021a00029ee509a1581c919d4c2c9455016289341b1a14dedf697687af31751170d56a31466ea140010b58205b09f3819069340313c5e997b112443db61871cce52e43c2abf133b9f60c5936a20581840100d8798082000006814746010000224981f5f6

This is the smallest example I managed to replicate. And I receive a 500 error with the content of
{
    "error": "Internal Server Error",
    "message": "An unexpected response was received from the backend.",
    "status_code": 500
}

Here's my source code
const tx = await lucid
    .newTx()
    .mintAssets(
      {
        [testPolicyId]: 1n,
      },
      Data.void()
    )
    .attachMintingPolicy(testMintingPolicy)
    .payToAddress(
      "addr_test1qpwsjkc0zpjav8eyt96umrs7cqewvfpw8sxtau453c7g3xjcut0lr6yt0etm7cn9ha5ycr9ys7cdhsrwp99q5kw4rrysk7fd7x",
      {
        [testPolicyId]: 1n,
      }
    )
    .complete({ nativeUplc: false });

and the minting policy is just an always success minting policy.

@jeffhappily do you mind to try now, please?

It seems to be working now! May I know what's the issue?

@jeffhappily one of the Blockfrost's Ogmios instances on preprod were misbehaving. We are sorry for the trouble it has caused.

No worries, thanks for helping with this!


reserved macro definitios

Hello, first of all, thank you for your library! I look through AT_Definitions.h and looks like you prefer using reserved definitions.

<IP_ADDRESS>.2 Global names [lib.global.names]

Certain sets of names and function signatures are always reserved to the implementation:

    Each name that contains a double underscore (__) or begins with an underscore followed by an uppercase letter (2.11) is reserved to the implementation for any use.
    Each name that begins with an underscore is reserved to the implementation for use as a name in the global namespace.165

165) Such names are also reserved in namespace ::std (<IP_ADDRESS>).

I know, this maybe doesnt make sense with arduino but i use your library with small changes without arduion :)

Hi,
Thanks for your advice we may change the library on next release.
Thanks.


Set Controls maps as default

Default Editor to Control_Small and Server to Control_Medium
Also change default gamemode to Control.

Please link your CHANGELOG entry.


bump yq version

Signed-off-by: eifrach<EMAIL_ADDRESS>Description
bump YQ version to support index change
PR #414
Type of change
Please select the appropriate options:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change is a documentation update

:tada: This PR is included in version 1.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


JSON field does not work anymore in MySQL 5.7+

Solves the issue #91
Undocumented option mysql was replaced by documentFieldType. The mysql still supported if documentFieldType it is not present.

@nielsgl take a look plz
:D

I don't see documentFieldType anymore on master
I've created a pull request to document the mysql option


add mass fractions to stellarcollapse

PR Summary
This is a feature needed by NGP code Phoebus, which provides additional astrophysical data tabulated in the stellar collapse table. It should have no effect unless a user specifically pulls a StellarCollapse equation of state out of the variant.

PR Checklist

[x] Adds a test for any bugs fixed. Adds tests for new features.
[x] Format your changes by using the make format command after configuring with cmake.
[x] Document any new features, update documentation for changes made.
[x] Make sure the copyright notice on any files you modified is up to date.
[x] After creating a pull request, note it in the CHANGELOG.md file
[ ] If preparing for a new release, update the version in cmake.

LGTM assuming CI passes.


Devtools are included in Vite bundle

The devtools aren't excluded and end up adding 1mb to my bundle size.

What bundler are you using?

I think Vite uses Rollup under the hood

We're investigating similar issues for CRA and NextJS. Could you try wrapping the <DevTools/> component like below and see if that does the trick?
const DevOnlyJotaiDevTools = () => process.env.NODE_ENV !== 'production' ? <DevTools/> : null;

That does fix it

Hey @Xenfo
Could you help us test this build? We're expecting tree-shaking to automatically work without needing to wrap the component with process.env on userland.
yarn add jotai-devtools@https://pkg.csb.dev/jotaijs/jotai-devtools/commit/2b2603e6/jotai-devtools/_pkg.tgz

Sure, I'll test it out in a few days. Thanks.

That's great news! We'll release the fix as part of 0.5.0


Update .travis.yml

Current coverage is 93.72%

Merging #36 into master will not affect coverage as of 06256e5

@@            master     #36   diff @@
======================================
  Files            6       6
  Stmts         2120    2120
  Branches         0       0
  Methods          0       0
======================================
  Hit           1987    1987
  Partial          0       0
  Missed         133     133

Review entire Coverage Diff as of 06256e5

Powered by Codecov. Updated on successful CI builds.


Changed testNamePattern behavior breaks IntelliJ / WebStorm (vitest 0.34.4)

Describe the bug
testNamePattern format  has been changed in vitest 0.34.4 (#4071). Unfortunately, it broke running a single test/suite in IntelliJ / WebStorm (WEB-62946).
The difference is that, previously, testNamePattern had a leading space always. Now, testNamePattern doesn't have a leading space, but previously released versions of IntelliJ / WebStorm still pass testNamePattern starting with a space.
Unfortunarely, it will be hard to release a hotfix of IntelliJ/WebStorm quickly, because of the release schedule. Even if we would release it, our users would be required to upgrade their IDEs (which would be inconvenient for the users).
Sorry, may I ask you to restore the leading space in testNamePattern for now? I'll fix IntelliJ / WebStorm in the next version (2023.3) to support both formats of testNamePattern. I guess it would be OK to drop the leading space completely in 2024 Q1 - once WebStorm 2024.1 is released, to have two major WebStorm versions supporting both testNamePattern formats.
What do you think? @sheremet-va @Dunqing @jaswrks
Reproduction
For example, to run basic test only in vitest 0.34.3, one should use the following command line:
./node_modules/.bin/vitest --run '--testNamePattern=^ basic$' test/basic.test.ts

 RUN  v0.34.3 /Users/sergey.simonchik/sandbox/vitest-basic

 ✓ test/basic.test.ts (3)
   ✓ basic
   ↓ my suite (2) [skipped]
     ↓ foo [skipped]
     ↓ bar [skipped]

 Test Files  1 passed (1)
      Tests  1 passed | 2 skipped (3)
   Start at  12:14:49
   Duration  142ms (transform 23ms, setup 0ms, collect 15ms, tests 1ms, environment 0ms, prepare 41ms)

Using the same command line doesn't work with vitest 0.34.4:
➜  vitest-basic git:(master) ✗ ./node_modules/.bin/vitest --run '--testNamePattern=^ basic$' test/basic.test.ts

 RUN  v0.34.4 /Users/sergey.simonchik/sandbox/vitest-basic

 ↓ test/basic.test.ts (3) [skipped]
   ↓ basic [skipped]
   ↓ my suite (2) [skipped]
     ↓ foo [skipped]
     ↓ bar [skipped]

 Test Files  1 skipped (1)
      Tests  3 skipped (3)
   Start at  12:43:12
   Duration  136ms (transform 24ms, setup 0ms, collect 13ms, tests 0ms, environment 0ms, prepare 40ms)

System Info
System:
    OS: macOS 13.5.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 3.46 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.6.1 - ~/.nvm/versions/node/v20.6.1/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v20.6.1/bin/npm
    pnpm: 7.14.0 - ~/.nvm/versions/node/v20.6.1/bin/pnpm
  Browsers:
    Chrome: 116.0.5845.179
    Safari: 16.6
  npmPackages:
    vitest: 0.34.4 => 0.34.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think reverting it is fine until you can support it.

Can we fix it in a different webstorm-compatible way?
E.g. by removing the leading space returned by getTaskFullName?
https://github.com/vitest-dev/vitest/blob/070bc9e6df68ba478f73b198aa22a69ea5097d21/packages/runner/src/utils/collect.ts#L30

@Dunqing I think any fix supporting leading space in the passed testNamePattern would work.

I've opened a simple PR #4104. Please take a look. Would be great to release a new vitest version with the fix included.

No objection from me either way. Big thanks to those who worked on this.
I will say, @segrey, it would be nice if someone acknowledged the following ... Submitting a PR that reintroduces a bug into an open source package they depend on is less than ideal. Particularly since it seems like (I can't be sure), but it seems like a PR that fixed this bug when you originally encountered it would have been a far better path to have taken vs. now needing to open a PR that reintroduces a bug they worked around. Contribute to open source ftw!

@jaswrks Thanks for the feedback. I think reintroducing bugs is not ideal in any project. Actually, PR #4104 with a straightforward revert was a starting point to discuss better solutions. No better solutions were suggested => the PR was merged.
For completeness, I've opened #4119 aiming to keep #4045 closed, but the new solution is not ideal either.


Add support for ElasticSearch username and password for ElasticSearchEventHandler

pr for https://github.com/open-metadata/OpenMetadata/issues/911

@rongfengliang Thanks for handling this.


Failed to load resource: the server responded with a status of 404

Any ideas what to do?
Ghost version - last
New instalation

Please make sure to download the right file, you have to download the file liebling.zip, not the source code. You can download it from the releases page: https://github.com/eddiesigner/liebling/releases

I will close this since it should be solved by doing what I said above ;)


Prevent concurrent spin plugin update commands

This is in support of the plugin badger; it provides protection in case a badger tries to kick off an update while an update triggered by a previous badger is still running.  (It is built into spin plugins update rather than the badger, because it is probably wise for users not to accidentally do it either.)
User experience:
$ spin plugins update
Error: Another plugin update operation is already in progress

Changed the Result wrappers to custom enums to hopefully address feedback.

Can I get either a LGTM or guidance on changes still required please?  Thanks!


master -> dev

Coverage decreased (-0.8%) to 70.708% when pulling 1d58b55a909826514852f92c65aea8f591f8b5c0 on master into 6a38f3b0277e418b5038defc904668488e1939d3 on dev.


multiple videos

Hi! Thanks fo great plugin!
Can you tell me how to initialize multiple videos on page?
If I add same  class="covervid-video" - only first one is working...

If you are using jQuery I'd suggest wrapping it as an each function,like this...
$(''.covervid-video").each(function(){
$(this).coverVid(1920, 1080);
});
Although this would mean every video needs to be 1920 x 1080.
The alternative would be to have a different class name for each one and call each individually.
I will be looking into a way to call multiple videos at once more conveniently.


Use the Python 3 kernel for the notebooks

Notebook lenet.ipynb wanted to use a Python 2 kernel, but lenet.py uses a Python 3 construct (print with a file argument).

thanks
On Mon, May 2, 2016 at 4:04 PM, Felix Abecassis<EMAIL_ADDRESS>wrote:

Notebook lenet.ipynb wanted to use a Python 2 kernel, but lenet.py uses a
Python 3 construct (print with a file argument).
You can view, comment on, or merge this pull request online at:
https://github.com/nouiz/Theano-Docker/pull/1
Commit Summary

Use the Python 3 kernel for the notebooks

File Changes

M notebook/Exercices.ipynb
https://github.com/nouiz/Theano-Docker/pull/1/files#diff-0 (10)
M notebook/Introduction.ipynb
https://github.com/nouiz/Theano-Docker/pull/1/files#diff-1 (10)
M notebook/lenet.ipynb
https://github.com/nouiz/Theano-Docker/pull/1/files#diff-2 (10)

Patch Links:

https://github.com/nouiz/Theano-Docker/pull/1.patch
https://github.com/nouiz/Theano-Docker/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/nouiz/Theano-Docker/pull/1


Dotnet allocation profiler design

Parent #778
Document design of dotnet allocation profiler integration with dotnet-monitor

Done with #1164


Illegal Instruction when initializing simsoptpp classes

Hi,
I'm trying to use simsopt 0.19.0 from pypi and get an Illegal Instruction error. (also seems to be the case with 0.18.1).
This is not an issue when using the official hiddensymmetries/simsopt docker container which seems to have simsopt version 0.19.0.post29+gb8c08d5d installed.
An example line which triggers the error is: https://github.com/hiddenSymmetries/simsopt/blob/b8c08d5dd2c4fc7a946af017a5545c9a61a5ed88/src/simsopt/geo/surfacerzfourier.py#L73
To reproduce:
docker run -it --rm continuumio/miniconda3

Then (bash inside docker):
conda create -n test -c conda-forge python==3.10.12
conda activate test
pip install simsopt==0.19.0
python3

Then (python):
from simsopt import geo
geo.SurfaceRZFourier()

Thanks!

@mrtnkb Can you tell us exactly what hardware you are running on? @mbkumar is the guru to ask about installation and build issues like this. Typically "illegal instruction" means the compiled bits of simsopt were compiled assuming a specific processor architecture which differs from the one you are actually running on. If the precompiled binary from pypi gives this error on your system, you can try building from source (i.e. clone the repo and pip install .), or try the simsopt conda package.

Hi @smiet not running on a Mac unfortunately. But if you run the steps in that docker on your machine you don't get the same failure?
Hi @landreman The host OS is Ubuntu 22.04.3 LTS and the CPU is 12th Gen Intel(R) Core(TM) i7-12700H
Building from source works, but it causing some pain in our CI setup to not be able to use the pypi compiled wheel.
Version 0.13.0 seems to be the most recent version which works fine

Any luck reproducing this error?

You can install from the source by pointing the pip to GitHub repo. Simsopt
requires only a C++ compiler. Your workflows should not be any more
complex.
Its very hard to debug these errors. But I'll check what changed in the
build from v0.13
Bharat
On Sat, Sep 30, 2023, 7:38 AM mrtnkb @.***> wrote:

Any luck reproducing this error?
—
Reply to this email directly, view it on GitHub
https://github.com/hiddenSymmetries/simsopt/issues/352#issuecomment-1741746809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA62VEFD6LPMXOOSY5XA673X5AAEPANCNFSM6AAAAAA44KZ2OQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi, thanks for looking into it! Building from source works, but its too expensive for ephemeral environments unfortunately. Another data point is that the version compiled in the hiddensymmetries/simsopt docker container works fine.

I have been able to reproduce the error on my laptop which also has an i7.
This might indicate that it is an issue with the architecture.
I do not know enough about this to get any further, but I am uploading the output of lscpu on both systems so someone who does might get further.
not-working [Arch Linux]:
[Placeholder]
Working [OpenSuse Leap 15.4]:
lscpu.txt

I did a preliminary check of what changed after v0.13.0. In v0.14.0, I
pushed a lot of changes to support PowerPC. I don't see any major changes
in the build process and the CMakeLists.txt that can change the
architecture. However, there are some changes and then there are major
changes to the C++ code. Let me do more debugging to identify the
problematic part.
Bharat Medasani
On Mon, Oct 2, 2023 at 4:51 AM Chris Smiet @.***> wrote:

I have been able to reproduce the error on my laptop which also has an i7.
This might indicate that it is an issue with the architecture.
I do not know enough about this to get any further, but I am uploading the
output of lscpu on both systems so someone who does might get further.
not-working [Arch Linux]:
lscpu.txt
https://github.com/hiddenSymmetries/simsopt/files/12781123/lscpu.txt
Working [OpenSuse Leap 15.4]:
lscpu.txt
https://github.com/hiddenSymmetries/simsopt/files/12781116/lscpu.txt
—
Reply to this email directly, view it on GitHub
https://github.com/hiddenSymmetries/simsopt/issues/352#issuecomment-1742629621,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA62VEBYRTPBVRPTM6HKA4LX5J6ATANCNFSM6AAAAAA44KZ2OQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7ecgkd7ejs/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_7ecgkd7ejs/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_7ecgkd7ejs/clone/recipe/meta.yaml:27: has_imports_and_run_test_py: Imports and python test file cannot coexist.
ERROR: /tmp/abs_7ecgkd7ejs/clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_7ecgkd7ejs/clone/recipe/meta.yaml:46: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


Profiles Editor: align with form layout/settings UI

Testing #217139
Related to other feedback I've given, here's a quick sketch of what I think gets us more aligned with things like the settings UI. Ideally we could even reuse the basic settings UI under the hood, but I don't know how portable it is off the top of my head. This isn't totally thought through but hopefully conveys the general idea I had in mind.
Main talking points:

Name and icon inputs are clearly labeled and have their own rows
Descriptions are added where needed
Actions are consolidated on the list item for each profile
Form actions are moved to the bottom
Table gets a name/description

Thanks for the feedback. I like it is aligned with Settings UI and will incorporate these changes in the next milestone.

Regarding primary actions on the profile in the LHS, I think New Window should be the only primary action and other should be in the overflow.


Check your key and signing method. AWS S3 JDK Java

AWSCredentials l_credentials = new BasicAWSCredentials(
        <Access Key>,
        <Secret Key>
    );

AmazonS3 amazonS3Cleint  = AmazonS3ClientBuilder
        .standard()
        .withRegion(Regions.AP_SOUTHEAST_1)
        .withCredentials(new AWSStaticCredentialsProvider(l_credentials))
        .build();

URI fileToBeDownloaded = new URI("https://s3-ap-southeast-1.amazonaws.com/bucket-name/private/service/entity/19/04/1554190039-first%20last.csv");
      AmazonS3URI s3URI = new AmazonS3URI(fileToBeDownloaded);

      S3Object l_object =  amazonS3Cleint.getObject(s3URI.getBucket(), s3URI.getKey());

gives me
com.amazonaws.services.s3.model.AmazonS3Exception: The request signature we calculated does not match the signature you provided. Check your key and signing method. (Service: Amazon S3; Status Code: 403; Error Code: SignatureDoesNotMatch; Request ID: 621B7DD7DDCA0734; S3 Extended Request ID: HLjCevVe8qEEbcn0X4p5CvLGEF5traDzXviP1NzuA3vN10GpDfe60vw7eIUN13Z/JedEowAcYMc=), S3 Extended Request ID: HLjCevVe8qEEbcn0X4p5CvLGEF5traDzXviP1NzuA3vN10GpDfe60vw7eIUN13Z/JedEowAcYMc=

Looks like wrong repo.


Issue with relative URLs

I just upgraded from 0.4.0 to 0.5.0 and suddenly I get this error:
Liquid Exception: both URI are relative in _includes/head.html, included in _layouts/default.html
jekyll 3.1.2 | Error:  both URI are relative

I figured out that it's because you need to have http:// in front of your URL before, however you didn't need to in 0.4.0. Just curious if this was a intended change.

I figured out that it's because you need to have http:// in front of your URL before, however you didn't need to in 0.4.0.

Before what?
How can I reproduce this error? What does your _includes/head.html contain?

Sorry, now you need to have your URL include http:// in front of the URL in _config.yml whereas before 0.5.0 you didn't need. All you need to do to reproduce is add jekyll-feed, add the feed meta and then have your URL be url: www.example.com or url: http://www.example.com. Before the new version the first way to write your URL worked.

I have figured it out!
We are now using 'URI.join' to join config["url"] and config["baseurl"] which won't work if neither contains a scheme.
This shouldn't have worked to begin with. If you don't at least include a // in the URL, it will not resolve properly.
I agree with you that the error message (Liquid Exception: both URI are relative) does not contain enough information to understand how to fix the problem. Maybe a try catch with a more helpful warning would make things easier?

Thanks, good to know :)


Build MIT license from template

Currently, we enforce the provision of an MIT license, but the cookiecutter template does not create one by default.

Yes, I removed this after having questions from small companies who wanted to use the template and thought that they couldn't as it generated the MIT licence. I intended to add this back with a cookiecutter question / logic, but it wasn't trivial and so I skipped it.
I think now that it's fine to add this file in and just add a bit to the readme about it, saying that it's an example template file and can be removed.

Nooo, i just wanted to submit a PR

I think, in the context of nf-core, it makes sense, as we made MIT as requirement. And lint test should pass for the template IMO.

:smile:

I’m certainly happy for this now that this repo is part of nf-core.. :)
Previous stuff was when it was stand-alone and no policies attached..