Adds null checks for document and case conversation flows.

Adds null checks for document and case conversation flows.

Preferably we'd raise custom exceptions here instead of returning None for special cases. That way callers don't need to check the return value and can assume that if no exception is raised, the return value is valid.  If an exception is raised, it should be handled appropriately by the caller. Also, the None could be interpreted incorrectly in conditional statements.
Here's what it could look like:
class ConversationUpdateException(Exception):
    """Base exception for all errors related to updating conversations."""
    pass

class NoConversationRelationError(ConversationUpdateException):
    def __init__(self, case_id):
        self.case_id = case_id  # custom property
        super().__init__(
            f"No relationship between case {case_id} and a conversation."
        )

def update_conversation(case: Case, db_session: SessionLocal) -> None:
    """Updates external communication conversation.

    Raises:
        NoConversationRelationError: If there is no relationship between the case and conversation.
        NoActivePluginError: If no conversation plugin is enabled.
    """
    if not case.conversation:
        log.exception("Conversation not updated. No relationship between case and conversation.")
        raise NoConversationRelationError("No relationship between case and conversation.")

    ....


Improve Logging Output

Added some simple logging colours to the ConsoleCallbackHandler along with a utility for Chalk. Have also improved the formatting of the log outputs to create consistent newlines and trim leading / trailing whitespace.

@agola11 to get this in we'd want to move the ConsoleCallbackHandler to a separate entry point to avoid including this dependency for everyone, thoughts?

Thanks a lot for this @more-by-more I've made a few updates for latest changes in main, and replaced chalk with a lighter dependency.


Document does not match current UI dialogs

It looks like the portal UI has been updated and the steps in the article no longer match the steps in the portal, which makes it very confusing.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9cde75a6-0a4d-8405-4b6d-f7e3cfd33094
Version Independent ID: fa2a94bb-7a6f-1ca4-ce74-8bcd8a6929f7
Content: Device activation of a customized Modern POS - Commerce | Dynamics 365
Content Source: articles/commerce/dev-itpro/retail-POS-activation-changes.md
Service: dynamics-365-retail
Product: ****
Technology: ****
GitHub Login: @jashanno
Microsoft Alias: jashanno

@RobvanB, thanks for the feedback. @jashanno, please review.

@RobvanB, thanks for the feedback. @jashanno, please review.

Bug 546530 logged to track this issue.

Bug 546530 logged to track this issue.

This topic has been updated.


[Bug]: version 4.4.2 post empty form in low version browser

Which packages are impacted?

[X] remix-validated-form
[ ] @remix-validated-form/with-zod
[ ] @remix-validated-form/with-yup
[ ] zod-form-data

What version of these packages are you using?

"remix-validated-form": "4.4.2"

Please provide a link to a minimal reproduction of the issue.
todo
Steps to Reproduce the Bug or Issue

Using low version browser, like chrome 69.0
This bug is brought in version remix-validated-form 4.4.2.

Expected behavior
form post empty form body.
Screenshots or Videos
No response
Platform

OS: Window
Browser: Chrome
Version: 69.0

Additional context
No response

Hi! Thanks for filling the issue. Could you provide some more details? It's not really clear what the issue is that's occurring.

Hi! Thanks for filling the issue. Could you provide some more details? It's not really clear what the issue is that's occurring.

In my project, without changing the code, 4.4.1 works properly and 4.4.2 does not work. This may be related to other libraries, and I'm figuring out exactly what triggers it.

Hi! Thanks for filling the issue. Could you provide some more details? It's not really clear what the issue is that's occurring.

In my project, without changing the code, just the remix-validated-form version, 4.4.1 works fine, 4.4.2 doesn't work. Creating a simple new project does not reproduce it, it may be related to other libraries, I'm trying to find out exactly what triggers the problem.

The form post payload is empty and occurs in a low version browser.

#chore:
The submitter is empty for some reason.

I have already updated my project to remix 1.4.3, it works well with remix-validated-form 4.4.1, but not 4.4.2.
And I create a new project only have remix-validated-form 4.4.2, it works well too.

Does it when when using only the Form from remix?

Tagging relevant commits / code in remix itself.

https://github.com/remix-run/remix/pull/3094/files
https://github.com/remix-run/remix/blob/dev/packages/remix-react/components.tsx#L922-L935

Looks like this change hasn't been released in remix itself yet. It may be worth reverting for now, but I do want to keep this in-line with what remix is doing. Once they release that change, it would be good to file an issue with remix to see what their response is.

remix 1.5.1 +   ， works

2 . remix 1.5.1 + remix-validated-form 4.4.3， not work

I see https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent/submitter, the submitter in Form Submit Event only works above chrome 81. But why does remix still work, I am figuring out.

@airjp73 I know why, before chrome 81, submitter will be null so it will fallback to use event.currentTarget.
But in remix-validated-form event.currentTarget is null, this may be related to event bubbling, currentTarget  will change!!!

Oh, good debugging! I know what the problem is in that case. Where we differ from remix is that our onSubmit is asynchronous. So we need to capture the value of event.currentTarget right away at the start of the event handler. If we wait until we actually need it, React will have already moved on and repurposed the event object.

Should be fixed in the latest beta<EMAIL_ADDRESS>Can install with npm install remix-validated-form@beta.

Yes, it's fixed.

Fix released in 4.5.0


Only focus the active pane once initialization is complete

Summary of the Pull Request
Since the days immemorial of the Terminal, the TermControl has auto-focused itself when it finalizes its layout. This has led to the problem that wt ; sp ; sp ; sp... ends up focusing one of these panes at random.
This PR fixes this issue by getting rid of the auto-focusing. Panes now manually get focused when created. We manually focus the active pane when a commandline is dispatched. since we're internally tracking "active" separate from "focused", this ends up working as you'd hope.
References
PR Checklist

[x] Closes #6586
[x] I work here
[ ] Tests added/passed
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments
I also had to turn the cursor off by default. Most TermControls would never get the LostFocus event, so their cursors would get left On, and that's not right.
Validation Steps Performed
I've run the following things a bunch of times to make sure they work:

wtd sp ; sp ; sp
wtd sp ; sp ; sp ; fp -t 0
newTab
splitPane
use the command palette to do the above as well

Where the result used to be random (cases 1 & 2), the result is exactly what you'd expect now.
It doesn't work at all for
wtd sp ; sp ; sp ; mf left

Presumably because we can't move-focus directionally during startup. However, that doesn't work today either, so it's not making it worse. Just highlights that single scenario doesn't work right.

I'm curious, why doesn't the directional movement work in startup? Is it because the actual controls don't have a size yet? I will happily report that mf {next,previous}InOrder does work during startup should you need the functionality.

Is it because the actual controls don't have a size yet?

Exactly that. See for example, Pane::PreCalculateAutoSplit. During startup, none of the panes have actually been added to the UI tree yet, so they don't have ActualHeight/ActualWidths yet. There's some work that we do to try and figure out where the actual positions of panes will be, based off of how big the window is, and roughly how much the pane will take of that window.  Rosefield@003125e If so I can clean it up and make a separate PR with it.

Oh my god it works fantastically. :shipit: Thanks!


User Friendly improvement checklist.

This was performed on hunterz test server, Unsure if it's a result of possible permissions missing.
If a case of missing permissions, some system of default permissions should be used, probably using PermissionDescriptions if supported by the PermissionsService.

[ ] Commands should give helpful messages or prompt, guessing what the player might want next.

[ ] Tab completion only completes so far. makes it impossible to guess what the command wants.

[ ] Whilst /gp help may be descriptive (I currently can't test, don't have permission) /help gp and /help GriefPrevention isn't very useful at all. Consider adding better support for the default help system, as it's likely what users will turn to first due to familiarity with sponge/bukkit.

@ryantheleach I've added original /slash commands from bukkit so this should be more user friendly to the end user. The '/gp' command definitely could use some work.

Latest build no longer uses the /gp command and all commands support tabbing.


refactor(data-table): update story structure

Updates the story structure for DataTable. cc @asudoh
Changelog
New
Changed

DataTable now has a stories directory where all the stories have been separated into

Removed

@asudoh honestly just convenience rather than doing static imports and figuring out a way to name all the stories 👍


try:: command not found

command script import voltron/entry.py
output try import not found

Add line
"#!/usr/bin/env python"
in the  entry.py  at before line


curl for insert row in table doesn't work

[
quotes should be escaped
curl http://<IP_ADDRESS>:8080 --header "Content-Type: application/json" --request POST -d "{"description":"configuration-3","details":"congratulations, you have set up R2DBC correctly!","done": "true"}"
]
[in my case following imports needed to be add to DemoApplication.java
import io.r2dbc.spi.ConnectionFactory;
import org.springframework.context.annotation.Bean;
import org.springframework.core.io.ClassPathResource;
import org.springframework.data.r2dbc.connectionfactory.init.ConnectionFactoryInitializer;
import org.springframework.data.r2dbc.connectionfactory.init.ResourceDatabasePopulator;
Overwise compilation failed with ConnectionFactory creation and initialization errors. ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c05b955d-5688-f2c3-5c7e-30d269fc6f48
Version Independent ID: 83b6c7bf-8693-71c0-c933-b36610f7b4c2
Content: Use Spring Data R2DBC with Azure SQL Database
Content Source: articles/java/spring-framework/configure-spring-data-r2dbc-with-azure-sql-server.md
Service: sql-database
GitHub Login: @bmitchell287
Microsoft Alias: judubois

@jdubois, can you take a look? Thanks!

The quotes don't need to be escaped, I use a mix of single quotes and double quotes to avoid that issue:
curl --header "Content-Type: application/json" \
    --request POST \
    --data '{"description":"configuration","details":"congratulations, you have set up R2DBC correctly!","done": "true"}' \
    http://<IP_ADDRESS>:8080

@KarlErickson for me this issue is invalid, unless there is something OS-specific that would replace the single quotes by double quotes

@itahirov this may be an environmental issue on your end. The topic shows the snippet as:
curl --header "Content-Type: application/json" \
    --request POST \
    --data '{"description":"configuration","details":"congratulations, you have set up R2DBC correctly!","done": "true"}' \
    http://<IP_ADDRESS>:8080

Can you confirm whether this version works on your setup?
@jdubois can you comment on the includes issue?

@KarlErickson the include issue is the same as https://github.com/MicrosoftDocs/azure-dev-docs/issues/194 so it will be fixed by https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/794

Hi Karl, thanks for updating, I guess, single quotes is better than
escaping. Thank you.
On Fri, Jul 3, 2020 at 11:21 AM Karl Erickson<EMAIL_ADDRESS>wrote:

@itahirov https://github.com/itahirov this may be an environmental
issue on your end. The topic
https://docs.microsoft.com/azure/developer/java/spring-framework/configure-spring-data-r2dbc-with-azure-sql-server#test-the-application
shows the snippet as:
curl --header "Content-Type: application/json"
--request POST
--data '{"description":"configuration","details":"congratulations, you have set up R2DBC correctly!","done": "true"}'
http://<IP_ADDRESS>:8080
Can you confirm whether this version works on your setup?
@jdubois https://github.com/jdubois can you comment on the includes
issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-dev-docs/issues/195#issuecomment-653594375,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJEMXS5PEG6C6LCNN56J3TDRZXZQ5ANCNFSM4NZXWIYA
.

--
Best regards,
Ismayil Tahirov
phone:: +1(240) 701-6335
skype: scarabek1


Added the possibility to use 3 different kind of shapes

With this update, you can use 3 different shapes: circle, square or the current shape (square with borders rounded).
I updated the readme file too, to reflect this changes and show how to customize the mask shape.

Thank you for this. Great job!


More TF2OpenAPI Unit Tests

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Add more TF2OpenAPI Unit Tests
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is

/assign @ellis-bigelow
/cc @jiwang576
/uncc @bhupc
/uncc @jinchihe

/ok-to-test

/lgtm
/approve


Add Docker Image Build Files

Dockerfile
.github/workflows/docker-publish.yml

References:

https://stackoverflow.com/questions/42352841/how-to-update-an-existing-conda-environment-with-a-yml-file

Implemented with: 88f0fb802808fffb3908cff66836311c1cdc5710


the guy stealing your work

i tried to report him but it did not work i will not let him do dat.

Yeah, I've got github working on it.


Interface classes

All classes have the same functions, but Event, which can create time series as well


Midburn association button needs to be removed

The feature which updating whether or not your a Hamuta member is not active and does not have any database. In addition, the form is not really sent.
In the meanwhile, we need to remove the button from the menu until it will be fixed.

@amotenko  Can we do that?

Going down today!
pandamichal<EMAIL_ADDRESS>schrieb am Mo., 26. Feb. 2018, 17:20:

@amotenko https://github.com/amotenko Can we do that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Midburn/spark/issues/592#issuecomment-368537505, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHHcKPJnPrT8Y8rZO6yb3hm30ZKaroYgks5tYsvAgaJpZM4Rs_h1
.

Hey :-) the button is still there...

yes. hence the issue is still open. 😉
On Mar 1, 2018 13:55, "pandamichal"<EMAIL_ADDRESS>wrote:

Hey :-) the button is still there...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Midburn/spark/issues/592#issuecomment-369569110, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAkWjP9BKaOQZSRdVypY5WbYfJ5WARYcks5tZ-GigaJpZM4Rs_h1
.

Luckily @enoodle is assigned to it :)


Unbatch / Split

Hello and first of all, awesome library. Making my life a lot easier already. But I seem to missing something. I batched results to perform database lookups efficiently (I don't want 500 db looksup, I want 5 queries that fetch 100 rows each). Now I want to split them back out. But I can't seem to find how to do this.
Am I missing or overlooking something? Is there a pattern to do it (return IAsyncEnumerable<T>)? Or is there no extension to easily do this?

I may not understand your use-case exactly, but 'unbatch' = .Join.  Which allows for any IEnumerable<T> to be the type of the contents within a channel. You can simply call .Join() on a ChannelReader<T[]> (for example) to convert to a ChannelReader<T>.
Another thing to consider is that if this doesn't solve your problem, then .Pipe and .PipeAsync methods might be what you need.

I also think that if .Join(), .Pipe(), or .PipeAsync() can't do it, then you might simply need another channel to act as the batch receiver with an intermediate consumer that creates the batches.

You are completely correct. I misunderstood the Join transform. I thought it was to join everything in one list, but that is what the ReadAll transform is for. So Join is the inverse of Batch. That is what I indeed want to do. 🤦
Thank you for your time. ❤


Particle to letter

It would be nice to have a sort of "particle -> letter" or some other "ultrashort representation" conversion interface, to make generating process strings like "ke -> ke" easy.
I  suggest
electron -> e
positron -> p
photon -> k

Something like this could also be used in reverse to parse process strings into processes.


Morph Targets

Looking at the feature chart and the code it seems that morph target animations are supported. But I can't manage to export Shape Keys (ie, morph targets in Blender) without animation. Just shape keys, without any keyframe set, and all weights at 0. I checked all options in the "Animation" group of the exporter. Maybe an "Export shapes keys"  in the "Attributes" group would be needed?. Thanks!

Just got back from a business trip. Will check this tomorrow and I mark it as a bug for now.

Hmm, works on my side. Can you please send me the file?

I've just made a simple test. A plane, with a shape key that raises one vertex. Sorry if I'm doing something wrong..
planemorph.zip

When I export the file, I do get the follwoing glTF output:
{
    "accessors" : [
        {
            "bufferView" : 0,
            "componentType" : 5121,
            "count" : 6,
            "max" : [
                3
            ],
            "min" : [
                0
            ],
            "type" : "SCALAR"
        },
        {
            "bufferView" : 1,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                1.0,
                0.0,
                1.0
            ],
            "min" : [
                -1.0,
                0.0,
                -1.0
            ],
            "type" : "VEC3"
        },
        {
            "bufferView" : 2,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                0.0,
                1.0,
                -0.0
            ],
            "min" : [
                0.0,
                1.0,
                -0.0
            ],
            "type" : "VEC3"
        },
        {
            "bufferView" : 3,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                0.0,
                0.0,
                0.0
            ],
            "min" : [
                0.0,
                0.0,
                0.0
            ],
            "type" : "VEC3"
        },
        {
            "bufferView" : 4,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                0.0,
                0.0,
                0.0
            ],
            "min" : [
                0.0,
                0.0,
                0.0
            ],
            "type" : "VEC3"
        },
        {
            "bufferView" : 5,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                0.0,
                1.4260201454162598,
                0.0
            ],
            "min" : [
                0.0,
                0.0,
                0.0
            ],
            "type" : "VEC3"
        },
        {
            "bufferView" : 6,
            "componentType" : 5126,
            "count" : 4,
            "max" : [
                -0.3183344900608063,
                -0.10706871747970581,
                -0.3183344900608063
            ],
            "min" : [
                -0.3183344900608063,
                -0.10706871747970581,
                -0.3183344900608063
            ],
            "type" : "VEC3"
        }
    ],
    "asset" : {
        "generator" : "Khronos Blender glTF 2.0 exporter",
        "version" : "2.0"
    },
    "bufferViews" : [
        {
            "buffer" : 0,
            "byteLength" : 6,
            "byteOffset" : 0,
            "target" : 34963
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 8,
            "target" : 34962
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 56,
            "target" : 34962
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 104,
            "target" : 34962
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 152,
            "target" : 34962
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 200,
            "target" : 34962
        },
        {
            "buffer" : 0,
            "byteLength" : 48,
            "byteOffset" : 248,
            "target" : 34962
        }
    ],
    "buffers" : [
        {
            "byteLength" : 296,
            "uri" : "planemorph.bin"
        }
    ],
    "cameras" : [
        {
            "name" : "Camera",
            "perspective" : {
                "aspectRatio" : 1.703595982340029,
                "yfov" : 0.5033799409866333,
                "zfar" : 100.0,
                "znear" : 0.10000000149011612
            },
            "type" : "perspective"
        }
    ],
    "meshes" : [
        {
            "name" : "Plane",
            "primitives" : [
                {
                    "attributes" : {
                        "NORMAL" : 2,
                        "POSITION" : 1
                    },
                    "indices" : 0,
                    "targets" : [
                        {
                            "NORMAL" : 4,
                            "POSITION" : 3
                        },
                        {
                            "NORMAL" : 6,
                            "POSITION" : 5
                        }
                    ]
                }
            ],
            "weights" : [
                0.0,
                0.0
            ]
        }
    ],
    "nodes" : [
        {
            "camera" : 0,
            "name" : "Correction_Camera",
            "rotation" : [
                -0.7071067690849304,
                -0.0,
                0.0,
                0.7071067690849304
            ]
        },
        {
            "children" : [
                0
            ],
            "name" : "Camera",
            "rotation" : [
                0.48170700669288635,
                0.3342514932155609,
                -0.21292175352573395,
                0.7816000580787659
            ],
            "scale" : [
                1.0,
                1.0,
                0.9999999403953552
            ],
            "translation" : [
                7.481131553649902,
                5.34366512298584,
                6.5076398849487305
            ]
        },
        {
            "mesh" : 0,
            "name" : "Plane"
        }
    ],
    "scene" : 0,
    "scenes" : [
        {
            "name" : "Scene",
            "nodes" : [
                2,
                1
            ]
        }
    ]
}

I double klick and open your file and export. Are u using a Mac Computer? Will try on a Mac later this day.

oh, that is weird! I must be selecting the wrong export parameters. Could you paste a screenshot of the export panel?

Oh, I got it! I was exporting with "Apply Modifiers" on. It has sense if you consider shape keys as modifiers of the base mesh, although many would like to apply 'common' modifiers but also preserve and export the shape keys..

At the moment, applying the modifieres is more or less a function call.
I agree, it makes sense to have it somehow selective, where e.g. you apply subdivision but not the morph targets.
I marked it as an enhancement, as it can already achieved manually. Let's collect more cases like this.

Hi!
I have seen this thread and I see that it has to do with some problem that I have to export a basic animation with shape keys.
I have taken the flamingo that someone recently uploaded, and that is exported without problems.
In the same file I inserted Suzanne and I did a basic distortion using only one key.
The result when exporting is that the flamingo is still moving, but the distortion in Suzzane is not observed.
Maybe it's a mistake because of my lack of experience with Blender. I apologize for that.
But do I urgently need to know how shape keys should be prepared to be successfully exported in gltf format?
I attached my blender file.
Thanks in advance!
flamingo_monkey.zip

Which glTF loader and viewer are you using?

Hi!
I'm using this: https://gltf-viewer.donmccurdy.com/

Can you please try your model here:
http://sandbox.babylonjs.com/
Also, can you please investigate, if this is an exporter or viewer problem?

On "babylonjs.com" Suzanne is animated, but not flamingo!
But I have an error on my console:
BJS - [01:07:58]: Mesh is incompatible with morph targets. Targets and mesh must all have the same vertices count.
So, I think the problem is the viewer or my blend scene.
Could you help me know what the real cause is? (from my blend file attached earler)
My goal is to use the gltf file in Threejs. Can you tell me where I find the best GLTF loader for Threejs?

The strange thing is, that the glTF validator says, that the exported file is okay (the warning comes from the lamp node):
[
    {
        "uri": "flamingo_monkey.glb",
        "mimeType": "model/gltf-binary",
        "warnings": {
            "NODE_EMPTY": [
                {
                    "type": "NODE_EMPTY",
                    "path": "#/nodes/3",
                    "message": "Empty node encountered."
                }
            ]
        },
        "resources": [
            {
                "id": "#/buffers/0",
                "mimeType": "application/octet-stream",
                "GLB": true,
                "byteLength": 1046296
            }
        ],
        "info": {
            "version": "2.0",
            "generator": "Khronos Blender glTF 2.0 exporter",
            "hasAnimations": true,
            "hasMaterials": true,
            "hasMorphTargets": true,
            "hasSkins": false,
            "hasTextures": false,
            "hasDefaultScene": true,
            "primitivesCount": 6,
            "maxAttributesUsed": 4
        }
    }
]

@donmccurdy Can you please investigate, why the file is not properly loaded/rendered/animated?

Okay, I'll try with several loaders and later I'll send my comments.
Thank you very much for your support.

@bghgary
Gary, could you check that error output from Babylon? This asset contains a mesh with multiple morphed primitives.

@lexaknyazev A mesh with multiple primitive with morph targets is currently broken in the glTF loader in BabylonJS. I noticed this two weeks ago. I have a backlog item to fix it.

It looks like the morph targets are intact in three.js, but playback is broken?

Also @mrdoob was able to convert a fair number of models with shape keys successfully (example, and all models). I'm not sure what steps were necessary to do that export.

Hi!
After a day reviewing every detail, I have discovered that Suzanne's animation is not shown because the corresponding "Shape Key" has the "Bezier" value in the type of interpolation.
When I change its value to "Linear", then the animation is reproduced.
I have tested it with other values (not all) and the animation is also achieved.
I really do not know the processing done by the GLTF exporter or its corresponding loader in Threejs, but I think this detail can help optimize it.
Thank you all.

Yes, seems the Bezier import/data loading is somehow broken.
Works fine with Babylon JS:

Sample file with bezier animation:
01_cs_translate.zip

There is a problem with the THREE.GLTFLoader handling of cubic spline interpolation. Currently tracking this in https://github.com/aframevr/aframe/issues/3036.

Fixed upstream in threejs.


Changed return behavior of Context#eval from 19.0.2 to 19.1.0

Did the return behavior of Context#eval change from 19.0.2 to 19.1.0 (I could not find anything in the release notes)?
What I'm observing:
In 19.0.2, calling eval() with
class myClass { myMethod() {}}

returns (in the Java debugger)
class myClass { myMethod() {}}

In 19.1.0
class myClass { myMethod() {}}

returns
undefined

However,
class myClass { myMethod() {}}
myClass

returns
class myClass { myMethod() {}}

I would expect the behavior of 19.0.2. Is the change intended?

Yes, this is an intentional change. https://github.com/graalvm/graaljs/commit/056c6cb8495bca4fc011148ea90aa9d36f412030 is responsible for this change. Note that this is a small bug-fix. That's why you don't find anything about it in release notes. The change is related to the fact that eval('class C {}') should be undefined according to the ECMAScript specification (but was class C {} in 19.0.2 incorrectly).
Note that class C {} is class declaration (that's why no value is returned). If you want to get the class then you should turn it into an expression that evaluates to this class (using (class C {}) or class C {}; C, for example.


Adds default clause to Column Definitions

I noticed that default worked when including it in the column definition but was missing in the docs.

Thanks!


Feature Request: Get state when plug is switched manually or by SIRI

Hello,
the Nodered implementation is very good, but only oneway out. When the state of the unit is changed by the local button or the apple Home App or SIRI, the node does not output that change as an event.
That would be very helpful to update the dashboard, when state has changed, to prevent from polling the device often, to see changes.
Thank you.

Using the right nodes there is no need to poll the state frequently. E.g. you might use redmatic-homekit nodes to accomplish state changes from and to HomeKit:
[{"id":"132f2560.410c23","type":"redmatic-homekit-universal","z":"9e75ae4f.7f9cf","g":"fc11753.de3a788","bridgeConfig":"95aa15d5.582478","name":"SmartPlug","services":[{"subtype":"0","service":"Outlet","name":"SmartPlug"}],"x":540,"y":280,"wires":[["153377da.a99b98"]]},{"id":"153377da.a99b98","type":"smartplug-control","z":"9e75ae4f.7f9cf","g":"fc11753.de3a788","confignode":"d9dc372f.d15f08","name":"SmartPlug","ip":"<IP_ADDRESS>","x":540,"y":320,"wires":[["adfb23df.9881f","132f2560.410c23"]]},{"id":"95aa15d5.582478","type":"redmatic-homekit-bridge","name":"RedMatic Bridge","username":"00:00:00:00:00:00","pincode":"123-45-678","port":"12345"},{"id":"d9dc372f.d15f08","type":"meross-config","name":"Meross","key":"abcdef0123456789abcdef0123456789"}]

Thank you! But I didn't get it work to read state messages from state changes
Q1: Which Bridge is to configure in Universal Node?
Q2: What Name is to configure in Universal Mode (output field)?
Q3: I have coupled the plug direct to the Home App (without a bridge) to avoid pseudo devices. How can I connect the Universal node?
Thanks!

Well, directly from within HomKit there is no possibility to get devices state. This would only be possible while publishing smart plug as described above. So you would create a HomeKit bridge from within node-red. This is documented very well at https://github.com/rdmtc/RedMatic-HomeKit.


deployment name is too long. 12 character limit

Why is this a limitation? This is a deployment on GCP where I can't change the name of the project.

The deployment name is used when creating the name of various components via Terraform, and the concatenation of those with the deployment name means we can't have deployment names greater than 12 characters. GCP has a significantly lower limit than AWS - although off the top of my head, I can't remember which component it is exactly that has the shortest name length limit. We can find out if you like, but it won't change the behaviour of the tool.
I hope that explains things.

No worries thanks for the explanation
On Thu, Mar 21, 2019 at 5:15 PM Daniel Jones<EMAIL_ADDRESS>wrote:

The deployment name is used when creating the name of various components
via Terraform, and the concatenation of those with the deployment name
means we can't have deployment names greater than 12 characters. GCP has a
significantly lower limit than AWS - although off the top of my head, I
can't remember which component it is exactly that has the shortest name
length limit. We can find out if you like, but it won't change the
behaviour of the tool.
I hope that explains things.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EngineerBetter/concourse-up/issues/103#issuecomment-475405301,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYeeUaAizludnyYzIV2gK-XETXt9Jytks5vY_ZagaJpZM4cCXN4
.

--
Thanks,
Henri M.B. van den Bulk
(c)<PHONE_NUMBER>

To go into more detail the limitation comes from terraform's creation of a GCP service account for BOSH to use. According to the docs the service account name can be maximum 30 characters long to comply with RFC1035 (I haven't read that one).
In Concourse-up the service account name will be concourse-up-<your deployment name>-bosh so the maximum deployment name size is 30-18=12. We made Concourse-up error out early if the name exceeds this because the alternative is a gnarly terraform regex error partway through the apply.
We do have a spike in the backlog to further investigate these limits and how we could address them but there's unfortunately not much room for improvement.

The deployment name being used is the project-name on GCP. Would it help to
shorten the concourse-up part (12)
On Thu, Mar 21, 2019 at 6:18 PM Colin Simmons<EMAIL_ADDRESS>wrote:

To go into more detail the limitation comes from terraform's creation of a
GCP service account for BOSH to use. According to the docs
https://www.terraform.io/docs/providers/google/r/google_service_account.html#account_id
the service account name can be maximum 30 characters long to comply with
RFC1035 (I haven't read that one).
In Concourse-up the service account name will be concourse-up--bosh so the maximum deployment name size is 30-18=12. We
made Concourse-up error out early if the name exceeds this because the
alternative is a gnarly terraform regex error partway through the apply.
We do have a spike in the backlog to further investigate these limits and
how we could address them but there's unfortunately not much room for
improvement.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EngineerBetter/concourse-up/issues/103#issuecomment-475424578,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYeeY4Snvc4_3u3ouR8umO72Yp_ZVquks5vZAU7gaJpZM4cCXN4
.

We have considered that in the past; the downside is that when Terraform renames entities it recreates some of them, meaning that folks could lose state (RDS is a culprit here, I seem to recall). This would require maintaining two code paths for old/new deployments.
Thanks for letting us know that this is causing problems for you - we're running a lean operation, so user feedback is vital in letting us know which features to prioritise.

The deployment name in this case should just be whatever you provide in concourse-up deploy --iaas gcp <deployment-name>. Are you able to use a shorter name when you deploy? This name is just used for naming the various components related to the Concourse within your project.


Faulty HUI-Audio-Corpus-German/huiAudioCorpus/sttInference/README.md

Many thanks for your work. The German TTS community appreciates academic work like this.
The above readme says 'sttInference We can execute text to speech with this Project' but it should be speech to text, right?
By the way, do you plan to publish your TTS models demonstrated here http://narvi.sysint.iisys.de/projects/tts and an interference script? Bernd Ungerer sounds nasal but quite natural.

Hi, sorry for the late answer, I have just recently become a repository maintainer.
You are right, the readme will be corrected in an upcoming commit.
Regarding your question concerning the provision of the models: In this or the next week it is planned to publish the whole webservice in another github repository, including the trained models as well as the phoneme dictionary.
If you are interested in speech synthesis for the German language, also check out a followup publication for these models, as we have evaluated them: https://www.thinkmind.org/index.php?view=article&articleid=centric_2021_2_30_30009.


Add --no-cache-clean and --no-cache-flush options

To maintain backwards compatibility, I added two options and both commands are still executed by default
Altthough, my recommendation would be to only use cache:clean by default
Solves #45

Accepted and merged.


Slash command shortcut.

Something like /erf to open the configuration options? :)

Yeah I can add that


Add YAML parsing to moduleloader_builder.py

It has been suggested that YAML might be a better language to use in the module definition files. A YAML parser could be added to the python script, with the choice of which parser to use depending on the file extension.

The python YAML module does not ship with the default python distribution (unlike JSON and XML). Making users download and install a whole extra python module just to compile the model is, I think, not justifiable.


[WIP] CouchDb Service and Ticket registry support

Adds support for CouchDb as backend store for CouchDb
Ensure that you include the following:

[x] Brief description of changes applied
[x] Any documentation on how to configure, test
[x] Any possible limitations, side effects, etc
[x] Reference any other pull requests that might be related.

I'm going to save committing the rest until it's passing here. The ticket registry will look very similar.

Just looking for spots that need tweaking currently.

Coverage increased (+0.06%) to 64.679% when pulling 2922db2077bcbe3914a540a58679f7c130111598 on tduehr:couchdb into 74674b3bc323e938708ed147538f75887a47cb30 on apereo:master.


Health Check must gracefully handle creating an Account failing

a user reported they have a validation rule on Accounts that causes Health Check to fail to run (rather than logging an error).  Hub post here: https://powerofus.force.com/0D58000002AGcF2
the culprit is STG_PanelRDCustomInstallment_CTRL.verifyRDSaving(this) which creates a temp account assuming it will always succeed.  this needs to be in a try/catch and handled gracefully with an error log entry.

**lurch: add

Tracking W-008311

Included in beta release version 3.57 (Beta 6) and higher

Included in production release version 3.57


Lower deregistration delay on target groups to 30 seconds for faster ECS deploys

This lowers the deregistration delay on target groups for ECS services from its default value of 5 minutes, to 30 seconds. The long delay before deregistration occurs causes ECS deploys to feel very slow, as any keep alive connection will cause a 5 minute delay before old tasks get stopped. Lowering the delay will greatly speed up deploying an update to an ECS service.
Pull Request Checklist

[ ] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[ ] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[ ] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

This is a breaking change that also goes against a service default. Therefore, at the very least this will need more explicit documentation.
ref: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#deregistration-delay

Closing for now. I agree that changing it across the board would be a breaking change, and exposing it as an option in the LoadBalancedFargateService is safer


app:First person view in mirror appears without neck

In latest master, first person view in mirror appears without neck. after Zooming out it is fine.
https://user-images.githubusercontent.com/35926530/153222889-77a49c19-8eae-4e7f-930c-b39f57a32a19.mp4

Regressed with https://github.com/webaverse/app/pull/2335, which was reverted.
Thanks!


Required: lightning support for basic commands

[x] CONNECT
[x] GETINFO
[ ] GETINVOICE
[ ] PAY
[ ] FUNDCHANNEL

CONNECT should support connecting to URI


[📑 Docs]: new producer concept doc

What Dev Docs changes are you proposing?
What Dev Docs changes are you proposing?
NEW /producer concept doc
As part of gsod, we need to build out the new Concepts section in our docs.

Each concept page should be planned w/ an agnostic outline
To get an idea started, perhaps the outline could be...

Producer definition
Why do we need producers?
Where do producers fit within AsyncAPI’s EDA architecture?

Each concept page should include at least 1 engineering diagram that helps users visualize each spec term
We'll team with design contributors such as @mcturco (current core maintainer design contributor) for this step.
It's the TW's responsibility to first get sign-off on having a technically accurate diagram before they ask for a design contributor to help beautify it according to the AsyncAPI branding style guide.
Contributors should be able to start their rough draft of the diagram for free on FigJam.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Here's your first gsod issue @nelsonmic! ⭐

awesome, let's get to work


Fix hardcoded Azure regions

The Azure SubscriptionResource.GetAvailableLocationsAsync() method does not appear to be working; it always returns an empty collection.  This may be permissions problem, but I would have expected to see a security exception instead of en empty list.
I'm going to temporarily workaround this by having AzureHostingManager use a hardcoded list of known regions.  This should work OK for clusters deployed to the public cloud, but will cause problems for government and other private-ish clouds and of course won't support new regions.
We need to come back and fix this.

I've reported this to Azure: https://github.com/Azure/azure-sdk-for-net/issues/28914

Azure closed this issue, saying I should use this instead: GetLocationsAsync()

That was the problem.  We're now using the API and it looks like Azure has added 2-3 regions since I hardcoded this a year ago.


Clean up settings branch

Cleaned up https://github.com/jwkvam/jupyterlab-vim/pull/40 to only include the functional "enable" setting and to resolve merge conflicts with master.

Any chance of getting this merged? I've been successfully using it for the past year to disable the extension by default in my shared jupyter hub installation and only enable it in my personal configuration instead.

If this works, is there any chance we can get this merged?  As I work on a shared jupyterhub install, I can't actually use this unless I have the ability to turn it off for some users.


DB_Vet-Clinic-project

In this project apply the following features :
-Create a Schema

INSERT data into the table

Fetch the data according to the below questions
Write queries for the following quests:
1-  Find all animals whose name ends in "mon".
2- List the name of all animals born between 2016 and 2019.
3- List the name of all animals that are neutered and have less than 3 escape attempts.
4- List the date of birth of all animals named either "Agumon" or "Pikachu".
5- List name and escape attempts of animals that weigh more than 10.5kg
6- Find all animals that are neutered.
7- Find all animals not named Gabumon.
8- Find all animals with a weight between 10.4kg and 17.3kg (including the animals with the weights that equals precisely
10.4kg or 17.3kg)

Anwsers:
1- select * from animals where name like '%mon';

2- select name from animals
where  year(date_of_birth) between 2016 and 2019

3- select name from animals
where neutered=1 and escape_attempts<3

4- select date_of_birth from animals
where name= 'Agumon' or name='Pikachu'

5- select name,escape_attempts  from animals
where w

eight_kg >10.5
6- select * from animals where neutered =1

7- select * from animals where name ='Gabumon'

8 - select * from animals
where weight_kg between 10.4 and 17.3

Thanks for the review


Re-add the HeifInput valid_file check

Description
valid_file was commented out, comment reffered to missing definitions. These defs are not missing currently.
Checklist:

[x] I have read the contribution guidelines.
[x] If this is more extensive than a small change to existing code, I
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

Sorry for the spamming of the CI system, I only just found the make clang-format...... d'oh

Sorry for the spamming of the CI system, I only just found the make clang-format...... d'oh


Move docker api usage to the new import

The old engine-api import is deprecated.
More into @ https://github.com/docker/engine-api
We use these for tests.

Two tests need to be enhanced

https://github.com/vmware/docker-volume-vsphere/blob/c95d9a3775b4ba804f63de8c8140722df23e2030/vmdk_plugin/sanity_test.go#L28
https://github.com/vmware/docker-volume-vsphere/blob/0241cae8b7c091a9510754bc5d544530c74cdfeb/vmdk_plugin/utils/refcount/refcnt.go#L82

Not an urgent issue - moving to P2.

Pulling to spiderman, at the least this should be resolved/dropped by spiderman.


copy scripts from the bin into the deploy bin so that we don't duplicate code

some of the bash scripts in the deploy directory are duplicated from the /bin of the main repo. ideally these would be imported together

Obsolete


Merge the two diverged repositories

@knife982000 with low priority please add a task to test that everything works as expected. The first part of the main readme (I believe, need to check) should contain the right instructions for which we care about, other readmes/pieces of code can be ignored

@kuzeko, regarding the readme, I followed these instructions to deploy and run the project. I think they are fine, maybe I could clean them.
Regarding a task to test the repo, are you referring to a GitHub action that automatically runs the test?

@knife982000  no, no github actions just manually on a server  (I like your thinking but that is not necessary for this one), @mutandon  had access to a server called djllama


Add Logos in Top Page

ref. Bottom of https://www.inlg2019.com/

Supported by ACL (Logo) SIGGEN (Logo)
Organized by AIRC (Logo)
Collocated with SIGDIAL (Logo)


Feat/text input screen

great pr - love the input stuff.
however, we won't do the validation inside the textinputs - I prefer to compose those behaviors; so we'll update that api. Can you make that driven by an errorMessage field, please?
We can move the validation code you wrote, into a ValidationUtil class and use that from the TextInputScreen
Last, I'd rather just have one text value on the textinput, too; so instead of updatedText, just have text.


ansible-lint: 6.16.1 -> 6.17.0

Description of changes
Missing ansible-compat

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Stumbled across this after submitting https://github.com/NixOS/nixpkgs/pull/236841 :innocent:
The other PR covers the ansible-compat requirement, though. orfborg spotted those here, too. Should I contribute to @Et7f3 patch and close mine or are we closing this one? :rocket:


It is always safe to open a file using "with" because then we don't n…

…eed to explicitly close the file.  Signed-off-by: Divy Garg<EMAIL_ADDRESS>

@muratkars Why is the DCO failing?

@divygarg PR for this is already raised and merged. (https://github.com/openebs/openebs-docs/pull/229). It is not in master branch currently, but soon that will be merged here.
and answer to your question

Why is the DCO failing?

DCO is failing because you added the Signed-off line in the title of the commit message. You should write that in the body of the commit.


Recurrent PPO Not Training Well on a Very Simple Environment

🐛 Bug
I've adapted the environment from this blog post, exact code of the env shown below. They implemented a recurrent A3C agent in TF1 (it was written a while ago).
It's a very simple "contextual bandit" environment where, for each episode, there are two random colors given as the observation, the order of which is randomly flipped at each timestep. There are two actions, each corresponding to a particular color. The reward is associated with a particular color, and the agent has to employ a strategy where they figure out which color leads to reward and select the action based on that color. Upon environment reset, the task structure stays the same but new pixel colors are chosen.
I figured SB3 Recurrent PPO should be able to solve this environment pretty easily. There is work showing that a recurrent policy network trained with A2C can solve a more complex 3d version of this task.
I have tried training for 1e6-1e8 timesteps and optimizing hyperparameters with Optuna (my ranges can be found below). I'm wondering whether this task uncovers a hidden issue with Recurrent PPO in SB3 or if this is just a deceptively difficult task? I have yet to try to run this environment with other packages as well to see if its specific to recurrent ppo.
Any thoughts/insights?
Hyperparameter ranges:
gamma = trial.suggest_categorical("gamma", [0.9, 0.95, 0.98, 0.99, 0.995, 0.999, 0.9999])
n_steps = trial.suggest_categorical('n_steps', [2,4,6,8,10,12,14])
learning_rate = trial.suggest_float("learning_rate", 1e-5, 1,log=True)
lr_schedule = trial.suggest_categorical('lr_schedule', ['linear', 'constant'])
ent_coef = trial.suggest_float("ent_coef",0, 1,log=False)
vf_coef = trial.suggest_float("vf_coef", 0, 1,log=False)
 n_lstm=trial.suggest_categorical('n_lstm',[10,30,90,120])
num_layers=trial.suggest_categorical('num_layers',[0,1,2,3])
activation_fn = trial.suggest_categorical("activation_fn", ["tanh", "relu"])

clip_range_vf=None
batch_size=n_steps
gae_lambda=1
n_epochs=1
clip_range=0.2
normalize_advantage=False
max_grad_norm = 0.5

Code example
class ContextualBanditEnv(gym.Env):
    metadata = {'render_modes': ['human','rgb_array']}
    def __init__(self):
        self.num_actions = 2
        self.action_space=Discrete(self.num_actions)
        self.observation_space=Box(low=0,high=1,shape=(9,),dtype=np.float64)
        self.prev_action=np.zeros(self.num_actions)
        self.prev_reward=0
        self.num_correct=0
        self.num_trials=100

        self.reset()

    def get_state(self):
        self.internal_state = np.random.permutation(self.choices)
        self.state = np.concatenate(np.reshape(self.internal_state,[2,1,1,3]),axis=1)
        return np.concatenate([self.state.reshape((6,)),self.prev_action,[self.prev_reward]])

    def reset(self,seed=None,options={}):
        self.timestep = 0
        color = [np.random.uniform(),np.random.uniform(),np.random.uniform()]
        a = [np.reshape(np.array(color),[1,1,3]),np.reshape(1-np.array(color),[1,1,3])]
        self.true = a[0]
        self.choices = a
        self.prev_action=np.zeros(self.num_actions)
        self.prev_reward=0
        self.num_correct=0
        return self.get_state(),{'t':self.timestep}

    def step(self,action):
        self.timestep += 1
        if (self.internal_state[action] == self.true).all() == True:
            reward = 1.0
            self.num_correct+=1
        else:
            reward = 0.0
        new_state = self.get_state()
        self.prev_action=np.zeros(self.num_actions)
        self.prev_action[action]=1
        self.prev_reward=reward

        if self.timestep > self.num_trials:
            done = True
            #print("ACCURACY: ",float(self.num_correct)/self.timestep,self.timestep)
        else:
            done = False

        return new_state,reward,done,False,{'t':self.timestep}

Relevant log output / Error message
No response
System Info
No response
Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the documentation
[X] I have provided a minimal and working example to reproduce the bug
[X] I have checked my env using the env checker
[X] I've used the markdown code blocks for both code and stack traces.

Same here


x/tools/internal/imports: TestModeGetmodeVendor failing due to vendoring change

What version of Go are you using (go version)?

$ go version
go version devel +46b7557836 Thu Oct 10 13:56:58 2019 +0000 darwin/amd64

golang.org/x/tools checked out at 0337d82405ff9ebcb2638658c98761e12f51693e

Does this issue reproduce with the latest release?
no, only tip
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/jayconrod/Code/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/jayconrod/Code/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/go/src/golang.org/x/tools/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build395310348=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
go test golang.org/x/tools/internal/imports -run=TestModeGetmodeVendor

What did you expect to see?
test passes
What did you see instead?
--- FAIL: TestModeGetmodeVendor (0.25s)
    mod_test.go:235: loading package name for rsc.io/quote: running go: exit status 1 (stderr:
        go list -m: can't list modules with -mod=vendor
        	use -mod=mod or -mod=readonly to ignore the vendor directory
        )
    mod_test.go:235: package name for rsc.io/quote = , want quote
    mod_test.go:235: scan failed: running go: exit status 1 (stderr:
        go list -m: can't list modules with -mod=vendor
        	use -mod=mod or -mod=readonly to ignore the vendor directory
        )
    mod_test.go:235: scanning for quote did not find rsc.io/quote
    mod_test.go:235: import path rsc.io/quote not found in active modules
    mod_test.go:240: package name for rsc.io/quote = , want quote
    mod_test.go:240: import path rsc.io/quote not found in active modules
FAIL
FAIL	golang.org/x/tools/internal/imports	0.291s
FAIL

https://build.golang.org/log/4ca136788f50edc4878fe80c76f1ec376539a9b2

Argh, sorry for the lack of advance warning. I ran the x/tools tests with the vendor change but forgot to look at the output. 😞

Caused by some combination of:

CL 199821 - cmd/go/internal/list: disallow 'list -m' with '-mod=vendor'
CL 198319 - cmd/go: automatically check and use vendored packages

(I'm putting together a CL right now that skips the test while we figure out what to do)

Considering the test name, it's probably 199821.
I'm guessing that most of x/tools/internal/imports is actually interested in packages rather than modules per se. If so, the fix is probably to switch from something like
go list -f '{{with .Module}}{{.Path}} {{.Dir}}{{end}}'

More generally, though, go list -m is somewhat nonsensical in vendor mode: the vendor directory doesn't contain the entire module and may interleave packages from different modules.

No, it very specifically needs modules, I'm afraid. Listing packages is too slow. I'll talk it through with Jay.

-mod=vendor does not have accurate module information — and never did, unfortunately.
(It previously reported incomplete module information in vendor mode, but we probably shouldn't build tooling around that.)
If you're detecting vendor mode explicitly, the easy way to list out the available modules is to snag the vendor/modules.txt file. But that won't get you directories for individual modules, because the vendor directory intentionally flattens the modules into an interleaved directory structure.

@bcmills, why did you remove the Soon label?
This is actively annoying people, making Trybots in x/tools useless.


fix psreadline not working with shell integration

This PR fixes #142161

This ended up causing the prompt to continually print, had to revert:

This ended up causing the prompt to continually print, had to revert:

how?

That's what happens with no changes in my profile on Windows and mac

oh i know, for psreadline 2.1 it should be
$tmp = [Microsoft.PowerShell.PSConsoleReadLine]::ReadLine($host.Runspace, $ExecutionContext)

i have a better idea of how to do this

@Tyriar github.dev kinda broke so heres the new thing

$__VSCodeOriginalPSConsoleHostReadLine = $function:PSConsoleHostReadLine

# TODO: Gracefully fallback when PSReadLine is not loaded
function Global:PSConsoleHostReadLine {
	$tmp = $__VSCodeOriginalPSConsoleHostReadLine.Invoke()
	# Write command executed sequence directly to Console to avoid the new line from Write-Host
	[Console]::Write("`e]133;C`a")
	$tmp
}

Works, thanks!


KAFKA-7636: Allow consumer to update maxPollRecords value

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@kcirtap7  We need to go through KIP process for any public API changes.
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals


Fix token 'aud' verification logic

The audience parameter that can be set during initialisation is not passed correctly during token verification and logout.

Hey, thanks for the PR.
I have not dealt with OpenID for a couple of years now, and I have lost my ability to determine if this PR should go in or not.
In general, this plugin was made for my simple use-case of login/logout, as noted in the README:

The OpenID specification is rather large (and confusing) and this extension tries to abstract the complicated parts away and makes the fair assumption that your web application wants some basic OIDC features, mostly: login and logout. Undoubtedly you may use Keycloak in various other exotic ways but this limited scope ensures the extension stays maintainable. Please keep that in mind when submitting a pull-request.

Merging code I do not fully understand is tricky, as it has security implications. For now, ill just leave this open.


a problem about traineddata

hello,
i want to ask if the traineddata trained in linux can't use in windows? it seems that it alwasys crash when i try to use the traineddata from api in windows. it always crash when i run to the code api->end();
thank you!
ps:
the version i set in linux is tesseract 4.0.0-beta.1-228-gd057
the version i set in windows is tesseract 4.0.0-beta.1

Traineddata is the same for Windows and Linux. Please note that this is not the support forum and close this issue.


[Event Request] Report 99001015 "Calculate Subcontracts" - OnBeforeValidateUnitCost

Hi, would it be possible to modify the OnBeforeValidateUnitCost event in report 99001015 (Calculate Subcontracts) by adding ProdOrderLine, ProdOrderRoutingLine parameters, like this:
    local procedure InsertReqWkshLine()
    var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeInsertReqWkshLine("Prod. Order Routing Line", "Work Center", ReqLine, IsHandled, ProdOrderLine);
        if IsHandled then
            exit;

        ProdOrderLine.CalcFields("Total Exp. Oper. Output (Qty.)");

        with ReqLine do begin
            SetSubcontracting(true);
            BlockDynamicTracking(true);

            Init;
            "Line No." := "Line No." + 10000;
            Validate(Type, Type::Item);
            Validate("No.", ProdOrderLine."Item No.");
            Validate("Variant Code", ProdOrderLine."Variant Code");
            Validate("Unit of Measure Code", ProdOrderLine."Unit of Measure Code");
            Validate(Quantity, QtyToPurch);
            GetGLSetup();
            IsHandled := false;
            // New Event begin
            // OnBeforeValidateUnitCost(ReqLine, "Work Center", IsHandled);
            OnBeforeValidateUnitCost(ReqLine, "Work Center", ProdOrderLine, "Prod. Order Routing Line", IsHandled);
            // New Event end
            if not IsHandled then
                if Quantity <> 0 then begin
                    if "Work Center"."Unit Cost Calculation" = "Work Center"."Unit Cost Calculation"::Units then
                        Validate(
                            "Direct Unit Cost",
                            Round(
                                "Prod. Order Routing Line"."Direct Unit Cost" * ProdOrderLine."Qty. per Unit of Measure",
                                GLSetup."Unit-Amount Rounding Precision"))
                    else
                        Validate(
                            "Direct Unit Cost",
                            Round(
                                ("Prod. Order Routing Line"."Expected Operation Cost Amt." - "Prod. Order Routing Line"."Expected Capacity Ovhd. Cost") /
                                ProdOrderLine."Total Exp. Oper. Output (Qty.)",
                                GLSetup."Unit-Amount Rounding Precision"));
                end else
                    Validate("Direct Unit Cost", 0);
            "Qty. per Unit of Measure" := 0;
            "Quantity (Base)" := 0;
            "Prod. Order No." := ProdOrderLine."Prod. Order No.";
            "Prod. Order Line No." := ProdOrderLine."Line No.";
            "Due Date" := "Prod. Order Routing Line"."Ending Date";
            "Requester ID" := UserId;
            "Location Code" := ProdOrderLine."Location Code";
            "Bin Code" := ProdOrderLine."Bin Code";
            "Routing Reference No." := "Prod. Order Routing Line"."Routing Reference No.";
            "Routing No." := "Prod. Order Routing Line"."Routing No.";
            "Operation No." := "Prod. Order Routing Line"."Operation No.";
            "Work Center No." := "Prod. Order Routing Line"."Work Center No.";
            Validate("Vendor No.", "Work Center"."Subcontractor No.");
            Description := "Prod. Order Routing Line".Description;
            SetVendorItemNo();
            OnAfterTransferProdOrderRoutingLine(ReqLine, "Prod. Order Routing Line");

            // If purchase order already exist we will change this if possible
            PurchLine.Reset();
            PurchLine.SetCurrentKey("Document Type", Type, "Prod. Order No.", "Prod. Order Line No.", "Routing No.", "Operation No.");
            PurchLine.SetRange("Document Type", PurchLine."Document Type"::Order);
            PurchLine.SetRange(Type, PurchLine.Type::Item);
            PurchLine.SetRange("Prod. Order No.", ProdOrderLine."Prod. Order No.");
            PurchLine.SetRange("Prod. Order Line No.", ProdOrderLine."Line No.");
            PurchLine.SetRange("Routing No.", "Prod. Order Routing Line"."Routing No.");
            PurchLine.SetRange("Operation No.", "Prod. Order Routing Line"."Operation No.");
            PurchLine.SetRange("Planning Flexibility", PurchLine."Planning Flexibility"::Unlimited);
            PurchLine.SetRange("Quantity Received", 0);
            if PurchLine.FindFirst() then begin
                Validate(Quantity, Quantity + PurchLine."Outstanding Quantity");
                "Quantity (Base)" := 0;
                "Replenishment System" := "Replenishment System"::Purchase;
                "Ref. Order No." := PurchLine."Document No.";
                "Ref. Order Type" := "Ref. Order Type"::Purchase;
                "Ref. Line No." := PurchLine."Line No.";
                if PurchLine."Expected Receipt Date" = "Due Date" then
                    "Action Message" := "Action Message"::"Change Qty."
                else
                    "Action Message" := "Action Message"::"Resched. & Chg. Qty.";
                "Accept Action Message" := true;
            end else begin
                "Ref. Order No." := ProdOrderLine."Prod. Order No.";
                "Ref. Order Type" := "Ref. Order Type"::"Prod. Order";
                "Ref. Order Status" := ProdOrderLine.Status.AsInteger();
                "Ref. Line No." := ProdOrderLine."Line No.";
                "Action Message" := "Action Message"::New;
                "Accept Action Message" := true;
            end;

            if "Ref. Order No." <> '' then
                GetDimFromRefOrderLine(true);

            OnBeforeReqWkshLineInsert(ReqLine, ProdOrderLine);
            Insert;
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeValidateUnitCost(var RequisitionLine: Record "Requisition Line"; var WorkCenter: Record "Work Center"; ProdOrderLine: Record "Prod. Order Line"; ProdOrderRoutingLine: Record "Prod. Order Routing Line"; var IsHandled: Boolean)
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Authoritative flag in NS answers

Hi, thanks for the plugin!
I noticed that k8s_gateway doesn't set an Authoritative flag for all answers on authoritative zones.
At least:
in answer to NS record request (this is the main issue, bind9 waits for this flag when I delegate subzone to k8s_gateway):
# dig NS example.domain @<IP_ADDRESS> -p 1053

; <<>> DiG 9.10.6 <<>> NS example.domain @<IP_ADDRESS> -p 1053
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 63945
;; flags: qr rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 2
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;example.domain.			IN	NS

;; ANSWER SECTION:
example.domain.		60	IN	NS	exdns-k8s-gateway.exdns.example.domain.

	 IN	A

;; AUTHORITY SECTION:
example.domain.		60	IN	SOA	exdns-k8s-gateway.exdns.example.domain. hostmaster.exdns-k8s-gateway.exdns.example.domain. 12345 7200 1800 86400 60

;; Query time: 0 msec
;; SERVER: <IP_ADDRESS>#1053(<IP_ADDRESS>)
;; WHEN: Mon Jan 23 22:02:47 GMT 2023
;; MSG SIZE  rcvd: 201

k8s_gateway is the authoritative server for the full zone and should set Authoritative flag.
What do you think?
Config is
k8s_gateway example.domain {
      apex exdns-k8s-gateway.exdns
      ttl 300
    }

yep, makes sense. Looks like a bug.

Looks good,
but for apex it is still not authoritative
 dig exdns-k8s-gateway.exdns.example.domain.  @<IP_ADDRESS> -p 1053

; <<>> DiG 9.10.6 <<>> exdns-k8s-gateway.exdns.example.domain. @<IP_ADDRESS> -p 1053
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 35471
;; flags: qr rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;exdns-k8s-gateway.exdns.example.domain.		IN A

;; ANSWER SECTION:
exdns-k8s-gateway.exdns.example.domain.	60 IN A	<IP_ADDRESS>

;; Query time: 1 msec
;; SERVER: <IP_ADDRESS>#1053(<IP_ADDRESS>)
;; WHEN: Thu Jan 26 16:56:09 GMT 2023
;; MSG SIZE  rcvd: 121

cool. I'll include this in the next release


Frames for pictures

What do you want added or changed?
Maybe add borders to the pictures you place? I think that it would be nice if right shift right clicking on the picture like planks for a wooden frame, gold for a furnished fancy frame etc, it could use any ores and I think it'd be a nice touch, because the image without any border looks a little flat especially in buildings like a museum or something :P

Ooh that's a really interesting idea, I'll think about it!


publish to diffrent targets via vs code C# devkit

Hi there, It would be a good feature to add a feature in C# devkit to enable us to have a publish profile and publish to the docker hub and different targets exactly like what we have in Visual Studio.

Please file an issue here - https://github.com/microsoft/vscode-dotnettools/issues.


Very tiny font size.

The font size looks like a blurry tiny line it's so tiny, it's literally unreadable. Any solution? I am running on Jailbreak.

Fixed


Automated cherry pick of #4634: huawei image delete bugfix

Cherry pick of #4634 on release/2.13.
#4634: huawei image delete bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@6ddd8c0). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #4643   +/-   ##
==============================================
  Coverage                ?   6.87%
==============================================
  Files                   ?     523
  Lines                   ?   88961
  Branches                ?       0
==============================================
  Hits                    ?    6118
  Misses                  ?   82337
  Partials                ?     506

Flag
Coverage Δ

#aFlag
6.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddd8c0...4cb7d03. Read the comment docs.

/lgtm

/approve


parse types properly, not as expressions

such that 1 | 2 == Union[1, 2], not 3

is this something we can even do in basedtyping? is it more like a basedmypy issue

This is definitely a basedtyping issue, look at the impl of typing.ForwardRef._evaluate, it uses eval to just execute the type which will cause runtime errors. We need to make a impl that treats it as types, not normal python exprs.


4G icon cann't display

iPhone8P
ios13.2.3
4G icon cann't display

This issue has been fixed with version 1.1


[MRTK3] PressableButton missing SetToggled() function

Describe the problem
MRTK3's PressableButton does not provide SetToggled() or equivalent function/property that allows developers to set toggle state through code or inspector. .MRTK2 provided SetToggled() so that application logic can control the toggle state.
Example
In Near Menu, when the user grabs the manipulation bar, moves it then releases it, we disable tag-along behavior and set Pin button state's toggle state on. Without SetToggled() function, there is no way to change the toggle state of the Pin button.

@Zee2 Is there a new way to do this or this is a gap?

This is already possible. ForceSetToggled(value, fireEvents). https://docs.microsoft.com/en-us/dotnet/api/microsoft.mixedreality.toolkit.statefulinteractable.forcesettoggled?view=mrtkcore-3.0#microsoft-mixedreality-toolkit-statefulinteractable-forcesettoggled(system-boolean-system-boolean).

This may need a single-variable override to be able to be invoked from a UnityEvent, though.

@Zee2 Right, it would be helpful to have one that can be used in the Inspector as well. Shall I reopen this issue with an updated title?

@Zee2 Right, it would be helpful to have one that can be used in the Inspector as well. Shall I reopen this issue with an updated title?

I'll open a new one (specific to adding an overload).
Thanks!


any way for Custom Error Messsage

i have  two doubt

i got the point of implementing all the functions but where function getAccessToken and getRefreshToken utilized or called ?? i get the point from your comment How to implement.
2.when ever i pass an error in any function like

model.saveAccessToken = function (accessToken, clientId, userId, expires, callback) {
callback({'error':'invalid response'},false);
};
then it will give the response
{
code: 503
error: "server_error"
error_description: "server_error"
}
if there is any custom mistake or error then can i change this response to some thing else manually .can i customize error message using this library??

old issue but i have a case - maybe you can provide a quick workaround.
I use JWT which required me to rewrite the model.getAccessToken implementation. I use a try/catch block to decode the JTW. If it fails this is usually due to a decoding error, and hence a "invalid_token" error. However it produces a "server_error" - any suggestions?

Any updates on this?


WIP: [#SUPPORT] Log error if authentication failed

What
If there is any error during credential verification, we log it
so we can troubleshoot it as needed.
How to review
Code review
Who can review
not me

Actually there is a more deep bug here... auth fails if there are multiple keys in UAA. I will do a new PR.


Update terraform.tfvars.ci to be consistent with documentation

We noticed that https://registry.terraform.io/modules/claranet/data-factory/azurerm/latest shows the attribute managed_virtual_network_enabled is not required, and defaults to true but the code itself had set the default value to false.
Fixing this to make the implementation consistent with the documentation.
Fixes #1  .
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

Changes proposed in this pull request
Changes the default value for managed_virtual_network_enabled from false to true so that it matches the documentation.
@claranet/fr-azure-reviewers

Hello,
Is it normal that you've edited only the terraform.tfvars.ci ?


Please support custom TTS engine options or support more google tts language

Hi
I am using my samsung phone, they provide me with a Samsung tts engine, It will be great if we can choose different TTS engine in our phone. Also Google tts engine support cantonese tts, I hope the app support more tts language instead of the whisper provided.
Thanks

TTS has native implementation into SpeakGPT.


Add Qt 6.2 to test suite

This adds Qt 6.2.0 to the test workflow.
I am using #119 as a base for this because I am not certain that aqt 1.2.5 installs modules properly. I think v1.2.5 can install the qtwebengine module if you call it addons.qtwebengine, but that solution is not so nice. With aqt v2 you can just call it qtwebengine.
I have observed that when you run qmake on a project that requests the webengine module, it doesn't work on Qt 6, no matter what modules are installed. I believe that the solution is to use webenginewidgets or webenginecore in the test .pro file. See Qt WebEngine Examples and a specific example. Accordingly, I have modified tests/TestWithModules/TestWithModules.pro. I have also observed that the configuration step fails when you use the qtwebengine module without having qtpositioning and qtwebchannel installed, so I have conditionally added them to .github/workflows/test.yml.
I have excluded Qt 6.2.0 from the Ubuntu 18.04 builds, thanks to https://github.com/jurplel/install-qt-action/issues/95#issuecomment-939599149.
I think that this fixes #95. Perhaps a note should be added to README.MD, stating that Ubuntu 20.04+ is required for Qt 6+?

I think I need to comment on this, since I changed the code that prints the contents of %Qt5_DIR%/lib/cmake. This is a run of the action that should print the contents of the directory:
https://github.com/ddalcino/install-qt-action/runs/3944003013?check_suite_focus=true#step:8:1
I'm not sure what's going on here. It looks like the master branch has this issue as well, so I don't think that this is a result of anything that I wrote.
Relevant environment variables:
    Qt6_DIR: D:/a/install-qt-action/Qt/6.2.0/msvc2019_64
    QT_PLUGIN_PATH: D:/a/install-qt-action/Qt/6.2.0/msvc2019_64/plugins
    QML2_IMPORT_PATH: D:/a/install-qt-action/Qt/6.2.0/msvc2019_64/qml

I would speculate that the vcvars64.bat script is trying to run some commands, but install-qt-action is being interpreted as a command switch because it is preceded by /, rather than the canonical \. This would explain the Invalid switch - "install-qt-action". error message. However, I don't understand why this does not cause the workflow to fail.


where is "embedding" being trained?

Hi, thanks for sharing nice work.
I guess embedding of each font should be trained somewhere.
init_embedding() creates the embedding variable under scope "embedding" but I cannot find it being used in any optimizer.
d_optimizer trains variables with prefix "d_" and g_optimizer trains "g_" where none of both includes "embedding" or "E".
Could you provide some explanation?

I think it's  discriminator
fc2 = fc(tf.reshape(h3, [self.batch_size, -1]), self.embedding_num, scope="d_fc2")

Thanks for your prompt reply.
fc2 is for classification regarding id of fonts, i.e., Mingchao/Cursive/Brush.
What I meant by embedding is their respective embedding space.
Something like https://www.tensorflow.org/images/linear-relationships.png
For font domain, yellow and red in tense corresponds to Mingchao and Cursive in fonts.
Have I mistaken something?

The embedding is immutable during the training. In a sense it is not embedding per say, functionality wise it is closer to a one-hot vector indicating the id.

Thank you so much :)


Json example

Now json is default. So I prefer to add _example/json to learn how to manipulate json in go-sqlite3.

Codecov Report

Merging #1056 (5131ffb) into master (43dcd31) will decrease coverage by 0.13%.
The diff coverage is n/a.

:exclamation: Current head 5131ffb differs from pull request most recent head bc62412. Consider uploading reports for the commit bc62412 to get more accurate results

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   46.17%   46.04%   -0.14%
==========================================
  Files          11       11
  Lines        1490     1490
==========================================
- Hits          688      686       -2
- Misses        666      667       +1
- Partials      136      137       +1

Impacted Files
Coverage Δ

sqlite3.go
52.97% <0.00%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43dcd31...bc62412. Read the comment docs.

@mattn The SQLite docs themselves include details about all the json functionality. https://www.sqlite.org/json1.html
As there isn't really anything interesting about this feature as far as this Go wrapper is concerned (like there is for, say, dealing with vtables), I would think that referring people to the official docs would be more useful in general.

Sure


Remove the quanta reference instant

We can always pass a 0 (which stands for an arbitrary point in time, but so does the original reference) to delta, which means there's one fewer 64 bit integer to keep around per RateLimiter.

bors merge


bug(rust): Tries to require() mason-registry even when mason is not enabled

I have neither mason nor codelldb/dap enabled (no Mason because Nix), but lazyvim tries to require("mason-registry") anyway:
https://github.com/LazyVim/LazyVim/blob/b2f750558a3737879f8151e741e7a3988886e37f/lua/lazyvim/plugins/extras/lang/rust.lua#L99-L100
Error trace:
   Error  13:38:03 notify.error lazy.nvim Failed to run `config` for rustaceanvim

...im/lazy/LazyVim/lua/lazyvim/plugins/extras/lang/rust.lua:100: module 'mason-registry' not found:
	no field package.preload['mason-registry']
cache_loader: module mason-registry not found
cache_loader_lib: module mason-registry not found
	no file '/nix/store/hxcwr8j33p9m437a7jyzwbzxhsyj5dh4-luajit-2.1.1713773202-env/share/lua/5.1/mason-registry.lua'
	no file '/nix/store/hxcwr8j33p9m437a7jyzwbzxhsyj5dh4-luajit-2.1.1713773202-env/share/lua/5.1/mason-registry/init.lua'
	no file '/Users/frath/.local/share/nvim/lazy-rocks/telescope.nvim/share/lua/5.1/mason-registry.lua'
	no file '/Users/frath/.local/share/nvim/lazy-rocks/telescope.nvim/share/lua/5.1/mason-registry/init.lua'
	no file '/nix/store/hxcwr8j33p9m437a7jyzwbzxhsyj5dh4-luajit-2.1.1713773202-env/lib/lua/5.1/mason-registry.so'
	no file '/Users/frath/.local/share/nvim/lazy-rocks/telescope.nvim/lib/lua/5.1/mason-registry.so'
	no file '/Users/frath/.local/share/nvim/lazy-rocks/telescope.nvim/lib64/lua/5.1/mason-registry.so'

# stacktrace:
  - /LazyVim/lua/lazyvim/plugins/extras/lang/rust.lua:100 _in_ **config**
  - /nix/store/x137yfpy63v4mkn68fkaj5ky8yv53xwf-neovim-unwrapped-0.10.2/share/nvim/runtime/filetype.lua:36
  - /nix/store/x137yfpy63v4mkn68fkaj5ky8yv53xwf-neovim-unwrapped-0.10.2/share/nvim/runtime/filetype.lua:35
  - /fzf-lua/lua/fzf-lua/fzf.lua:284

Mason should be optional though, I think:
https://github.com/LazyVim/LazyVim/blob/b2f750558a3737879f8151e741e7a3988886e37f/lua/lazyvim/plugins/extras/lang/rust.lua#L44-L55
Explicitly the optional = true.
I used the "Reference in new issue" option btw., which didn't give me an issue template:

Just wanted to let you know.

feel free to create a PR

Should probably check the path to see if they're available and if not only if mason is enabled use it?

I believe you could wrap that whole path logic using mason-registry in a
if LazyVim.has("mason.nvim") then
  ....
end

I don't use Nix, so you can test it out locally and create a PR if it works correctly.

I believe you could wrap that whole path logic using mason-registry in a
if LazyVim.has("mason.nvim") then
....
end
I don't use Nix, so you can test it out locally and create a PR if it works correctly (which I think it should).

Thank you very much, that was exactly what I needed (didn't know how to limit the logic to be dependent on mason.nvim being available)!
Opened a PR: https://github.com/LazyVim/LazyVim/pull/4963 👍
Btw., I spent a few minutes looking for a guide on how to set up a development environment for LazyVim, before I realized that I can work in ~/.local/share/nvim/lazy/LazyVim.

For local development, I just did the following in my ~/.config/LazyVimDev/lua/config/lazy.lua
  dev = {
    path = "~/projects/plugins",
    patterns = { "LazyVim" },
  },

I also have a different LazyVim installation for this. So, I created a dir ~/.config/LazyVimDev and then inside that directory I did git clone https://github.com/LazyVim/starter.git . and just invoke Neovim with NVIM_APPNAME=LazyVimDev nvim (you can make this into an alias in your shell). And then you just clone the LazyVim repo into the config.dev.path that you have defined. Or you can do it in your normal configuration as is currently in ~/.config/nvim/ by just adding the above code snippet in your lazy.lua and then just comment out pattern = { "LazyVim" } if you want to use the LazyVim installed as a plugin or don't comment it out if you want to use the local git repo that you have cloned.
It's up to you which workflow fits best your needs.


Angular Universal Error: window is not defined

Angular Universal Error:
window is not defined
at
device-detector.service.ts
Line number: 113
this.orientation = window.matchMedia('(orientation: landscape)').matches
      ? OrientationType.Landscape
      : OrientationType.Portrait;

Can you please add an undefined check before accessing the window object (e.g. typeof window !== 'undefined')?
if it is, set a default value for orientation.
Note: this error occurs on the server despite using ngx device detector on the browser only.
Thank you for this awesome library.

I get the same error.
Angular: 10.1.0
"ngx-device-detector": "^2.0.1"
I created the universal-device-detector.service and provided it in app.server.module the same as docs but I'm using that service in my component.

Facing the same issue. Any solution or workaround for this?

@AbraamNader , @Parsa-Sedigh
Closed by https://github.com/KoderLabs/ngx-device-detector/pull/183
Thanks to @pritamgb for the PR.
New version 2.0.2 released with the fix

Thanks - @AhsanAyaz , @pritamgb
On my side, there is a new error : ERROR TypeError: window.matchMedia is not a function
(before, it was window is not defined)
I think the fix to test the window object should be the same than you used in the code :
if (isPlatformBrowser(this.platformId) && typeof window !== 'undefined')
Unfortunately, I don't know how to the PR stuff by myself and so on :-)
In the meantime, will downgrade to 2.0.0 :)
Thanks you guys.

@vroussel35 a new version 2.0.3 has been released with the fix.
If you still find it as an issue, please comment and reopen the ticket :)


Using a url property in a resource response

I get an error when the response of a resource contains a property named url
Reproduced here:
https://codesandbox.io/s/weathered-meadow-46fmn
Go to resource.js and uncomment the commented line.
I still didn't check why this could be happening but will try to take a look in these days

Ah yes, the error thrown is "TypeError: setting getter-only property "url""
What's going on is there's a convenience getter that returns an items url. However, in cases where they have their own member it tries to set which doesn't work. I'll look into a fix for this.

Nice, i just went through this trying to do the "hello world" using the SWAPI api, was just unlucky with the response containing a url property, the example on the docs is awesome, but probably having an easier or less complex one would be nice to let the idea sink

Are you referring to this example in the docs: https://resthooks.io/docs/guides/resource-types as being too complex? My plan is to create a really simple forum api to build a new demo with (the github api is quite complex so it makes first intro kinda overwhelming). Then I could probably change most of my examples to actually match the demo api and then you could just go into the demo page yourself. How does that sound?

Fix released in https://github.com/coinbase/rest-hooks/releases/tag/2.0.2

@ntucker no, my bad, not an example but a demo. I think this one https://codesandbox.io/s/rest-hooks-hinux?fontsize=14&module=%2Fsrc%2Fpages%2FIssueList.tsx is really complex as a first impression of the library. Me as a new user landed on https://resthooks.io/ clicked demo before reading anything and saw dozens of files and that shocked me a little bit. Probably seeing a minimal example first is better for newcommers.

Gotcha. Ok, having a simpler demo example to not overwhelm people. I'll put that on my future work; makes sense to me.


Issue with react-query and react-router calling the query again before navigating away from the page.

To Reproduce
Steps to reproduce the behavior:
I am using react-query v.3.16.0  with react-router-dom. I am having an issue when I navigate from a component with a sibling component using match params.
For example I have a page with a list of Football Leagues (Leagues component in code sandbox) When I go to this page and navigate to an individual league if you check the console you can see that the useQuery gets recalled in the Leagues component gets called again, although it shouldn't as this component has unmounted and the individual League component is visible.
See codesanbox here which will demonstrate the problem more clearly.
Expected behavior
I would expect when I navigate to a component (League) that is not the component (Leagues) where the useQuery exists that that query should not be called again before navigating away from that component.
**Desktop **

OS: osx
Browser: chrome
Version: 91.0.4472.114

Let me know if any more information is required.

Looks like a standard background update because queries are immediately marked as stale and a new observer mounts. This is the desired default behaviour of react-query (stale-while-revalidate).
please see:

https://react-query.tanstack.com/guides/important-defaults
https://react-query.tanstack.com/guides/caching
https://tkdodo.eu/blog/practical-react-query

adding refetchOnWindowFocus: false seems to prevent it, but this seems slightly odd, as it's not really a window focus and I don't necessarily want to get rid of this behaviour.

refetchOnMount is what you are looking for, or even better, customize a staleTime on the query.

refetchOnMount doesn't seem to fix the issue

I see the same issue on my project, when I'm navigating to another page, react-query refetches the queries from the page I'm leaving before fetching the queries for the new page. I'm using react-router too.

@ggregoire are you focusing between the browser and devtools? That was what I was doing, and is what made me believe that this bug was occurring.

If you see a refetch that you are not expecting, it is likely because you just focused the window and React Query is doing a refetchOnWindowFocus
[...]
During development, this will probably be triggered more frequently, especially because focusing between the Browser DevTools and your app will also cause a fetch, so be aware of that.

@Pau1fitz  My devtools was open on the Network panel but I was not focusing it. Perhaps the focus automatically switches between both? Or maybe some weird interaction with a Chrome extension, not sure.
Anyway, there was also a refetch when I clicked on a input file (which opens a new window to select a file) and I didn't understand why, but now with your reply it totally makes sense. 😉
Thanks!

yeah it had me pretty stumped also 😀
you can add refetchOnWindowFocus: false globally which prevents this. Or else you can do it on an individual query level. There are instructions here.

refechOnWindowFocus: process.env.NODE_ENV !== 'development'
I have this also as a potential gotcha in my first part of react-query related articles: https://tkdodo.eu/blog/practical-react-query#the-defaults-explained

@TkDodo should this be added to the official docs? seems to be catching quite a few people out.

I’d say it’s mentioned on this page, but if you’d like to extend that, I’ll gladly accept a PR: https://react-query.tanstack.com/guides/important-defaults

@TkDodo created a PR explaining that re-fetches could occur more often during development due to focusing on the devtools  #2413

refechOnWindowFocus: process.env.NODE_ENV !== 'development'
I have this also as a potential gotcha in my first part of react-query related articles: tkdodo.eu/blog/practical-react-query#the-defaults-explained

Thanks for the blog! I just read the entire series about React Query and learned a lot!


Adding e2e travis tests

Seems to be dying on SSL errors sometimes, might need to add a timeout/wait for the SSL certificate provisioning


reason: fix build with OCaml < 4.07

Description of changes
#184390 has been merged without review, so reason (similarly to all dependent packages) is currently broken for OCaml versions below 4.07.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 184985 run on x86_64-linux 1

#184390 has been merged without review

Untrue. I have reviewed it. Do you mean my review does not count?
Notice: Reason has tests. Tests passed. This problem did not show in nixpkgs-review. Which I did run. And yes, I did not test some ancient version in an ad-hoc manner.

so reason (similarly to all dependent packages) is currently broken for OCaml versions below 4.07.

Thanks for pointing out. I don't mind correcting any problem as long as I am aware of it.
I think the underlying issue here is the method of testing older versions of OCaml.
Still, if you think my contributions are not being positive, I can stop. Just let me know.

My apologies for the rude comment. Thanks for your work.

My apologies for the rude comment. Thanks for your work.

@vbgl Thanks for pointing out the problem I caused. I'm sorry for making you upset on this issue. I also would like to take the opportunity and thank you for all the feedback you have provided me over time. I have learned a lot. And I'm still improving. I wish i had answered you this earlier (which I did not). I hope that in future I will be able to fulfill your expectations here fully.

My apologies for the rude comment. Thanks for your work.

@vbgl Thanks for pointing out the problem I caused. I'm sorry for making you upset on this issue. You have been kind to me by giving me all the feedback I needed. I have learned a lot from you, and I still have more to learn. I will seek to improve. I esteem you highly, not only for your competence, diligence, but also because you care. I hope that in future I will be able to fulfill your expectations fully. I wish you all the best. Also I wish I had answered you this earlier (which I did not). I'm sorry for that too.