Babel 6

Babel 6 was just released and has a new plugin API. Assuming this plugin will need to be updated to support it (otherwise can just close this issue).

:+1:  want this

:+1:

+1

Please, don't +1 the issue, it doesn't help at all.
I'm aware Babel 6 is out and I'll support it in the next release.
If you feel like making a PR or temporarily maintaining a Babel 6-compatible fork, please do.
I will get back to this (and React 0.14 full support) in a week or two, in the meantime please be patient.

I'm trying to make a PR, but can't for the life of me figure out where babel-plugin has gone.
It's used by the build npm script, but is no longer part of babel. It doesn't seem to be part of babel-core, babel-cli, or even babel-runtime, and there's no package called just babel-plugin. Am I missing something obvious?
As you can probably tell, this is my first attempt at babel plugins, so I'm not familiar with the ecosystem...

It's not really important, from what I remember. I just copied it because that's what other plugins were using, but I think it can be replaced by simple babel CLI call. You can take inspiration from any Babel plugin here: https://github.com/babel/babel/tree/development/packages.

Thanks, will look into it and report back if/when I have something.

I've made some progress on this
branch: https://github.com/chicoxyzzy/babel-plugin-react-transform/tree/babel-6
commit: https://github.com/gaearon/babel-plugin-react-transform/commit/292e5ad3c825d98ed4116cb56fb3fc722df5460f
If you npm link my babel-6 branch you can see that visitor's exit method still returns result of t.program. I can't find any docs on how to fix this method to work proper.
Also tests are still on Babel 5 so they won't work either.
@theneva do you have any progress on this?

options should be passed like so
          presets: ['es2015', 'react'],
          plugins: [
            ['transform-object-rest-spread'],
            ['transform-class-properties'],
            ['react-transform', {
              transforms: [
                {
                  transform: 'react-transform-hmr',
                  imports: ['react'],
                  locals: ['module'],
                }, {
                  transform: 'react-transform-catch-errors',
                  imports: ['react', 'redbox-react'],
                },
              ],
            }],
          ],

@chicoxyzzy thanks , I didn't know how to add extra before

Nice, @chicoxyzzy. I haven't been able to get very far, no – and I unfortunately can't get around to look any more into it before tomorrow. Please keep up your good work :smile:

We should make a Babel 6 preset for HMR + error catching.

Just threw it together and haven't test yet but: https://github.com/danmartinez101/babel-react-hmre
Is this on the right track, @gaearon ?

Yep @danmartinez101 it looks ok.
But first of all we need to:

migrate build step to Babel 6
update tests
fix Program.exit

I'll try my best to fix it but I'll be very busy next two weeks. Anyway feel free to ping me if you think I can help.

I've created a pull request on chicoxyzzy/babel-plugin-react-transform#babel-6 which updates the tests to use babel 6. All but the Vanilla test on that branch now throw an error
Unexpected return value from visitor method function (path) {
        return fn.call(state, path, state);
      }

@buildmaster I just checked your PR. If you will rm -rf node_modules and then npm install you'll see error
><EMAIL_ADDRESS>build /Users/Chico/Projects/babel-plugin-react-transform
> babel-plugin build

sh: babel-plugin: command not found

that's because there is no babel-plugin in node_modules/.bin directory anymore. So we should fix build script in package.json somehow

ok I've copied the command from the old babel-plugin bin, but means a dev requirement on babel-cli as well.

ok made a couple of updates, but I think I'm at the limit of my knowledge, so might have to wait for someone who knows how the plugin actually works to pick up the fix

@buildmaster @chicoxyzzy I think this is the easiest way to do it, yeah – that's how I did it in my (still unpushed) branch too. Not sure you need the --copy-files option, though?
At any rate, this will be quite a bit bigger than simply changing the plugin export… especially due to fixing the tests, which I don't have any experience with.
Is anyone close to having a complete PR on this?

Hi I updated some files based on @chicoxyzzy 's and @buildmaster 's work.  PR is at chicoxyzzy/babel-plugin-react-transform/2 .
since the generated sources changed, need experts to review.
three of four test cases look fine, but test/fixtures/classic is still failed. If enabling decorator in babel, the error message is same as babel/babel#2645 and babel/babel#2801 .

Good work @TaopaiC and @buildmaster! I've merged your commits! Now we should fix Program.exit and failing test for modern classes

@gaearon should I create WIP PR so everyone will be able to help and track progress more comfortably?

is any news in here?

Please feel free to create a PR.
I will be able to review in a couple of weeks and no sooner due to my current workload.

Please feel free to create a PR.

here it is #48

I have no idea how babel or this plugin work so I'm going to start hacking away in a different fork for now.
You can find it here: https://github.com/danmartinez101/babel-plugin-react-transform/tree/unit-tests
This is the approach I'm planning on taking:

Write granular unit tests for the existing plugin (with Babel 5)
Upgrade to Babel 6
Fix the granular unit tests
Update the fixtures
Hope that the fixture-based tests pass because the unit tests covered all the logic

Once I get through all or most of this, I can either apply what I've learned to the branch created above, or we can just go with this one ( assuming that it actually works, of course... and that is a big assumption :P )

Just throwing in this amazing new reference: https://github.com/thejameskyle/babel-plugin-handbook
We did some things in a wrong way because I didn't know any better.
While we're at it, we can learn to use scope correctly, etc.

I started reading that last night; it has help a lot already :D :D I was planning on seeing if parts of the plugin could be improved, but want to get through tests and upgrade first to make sure I really understand it. I'm hoping to get it wrapped up tonight.

I'm also thinking that https://github.com/babel/babel/tree/master/packages/babel-template is going to be useful here.

@danmartinez101 for sure—babel-template is being used to create the core HOCs (as a workaround for decorators) in #48 and there are definitly some other areas i think templating could simplify things
@gaearon what do you think is wrong with respect to scope?

how's it going?

any luck with this?

Please track #50 instead. I will soon have time to release it & related packages.

I've met issue with missing extra option for react-transform, but I found out how to fix it. Hope this can help
{
  "presets": [
    "es2015",
    "react"
  ],
  "env": {
    "development": {
      plugins: [
        ['react-transform', {
          transforms: [
            {
              transform: 'react-transform-hmr',
              imports: ['react'],
              locals: ['module'],
            }, {
              transform: 'react-transform-catch-errors',
              imports: ['react', 'redbox-react'],
            },
          ],
        }],
      ]
    }
  }
}


HAP returning subscriptions to the pool

Description
In order to reduce the number of subscriptions being used for creating clusters and remove old, assigned ones, we would like to have a functionality that will return empty subscriptions back to the pool for reusing them in the future. After the last cluster in the subscription is removed it should be unassigned from the given tenant and returned back to the pool of subscriptions that are available for the new tenants to provision their clusters.
Acceptance Criteria

After the last cluster in the subscription is removed it should be unassigned from the tenant who used it before
Unassigned subscriptions are available for new tenants who want to provision a cluster

Another thing to note - we would need to also make sure that the subscriptions are completely empty when unassigning them from a previous tenant.

@janmedrek Did you accept the story? Can you close it?


installation instructions don't work with go1.18

Scratch/oci % go version
go version go1.18.1 darwin/amd64
Scratch/oci % go get -u github.com/opcr-io/policy
go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

@srenatus which platform is this on?
I do not see the same issue on linux/amd64 using ubuntu or alpine, or darwin/arm64.
❯ git clone https://github.com/opcr-io/policy.git
❯ cd policy
❯ go version
go version go1.18.1 linux/amd64
❯ go run mage.go generate build

MacOS x86, but the building from source steps aren't the issue, they work just fine. What I meant is if I just want the dev binary, the one call instruction here doesn't seem to work: https://github.com/opcr-io/policy#installation

I was able to reproduce on go1.18.1 linux/amd64


controller: refactor ApplyVolumeRequestOnVMISpec

What this PR does / why we need it:
This commit extracts the different functionalities
performed in ApplyVolumeRequestOnVMISpec to separate functions,
hopefully making it easier o read and understand.
Signed-off-by: alonsadan<EMAIL_ADDRESS>Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/ok-to-test

/ok-to-test

made @ezrasilvera requests:
https://github.com/kubevirt/kubevirt/compare/af960aecd8ec850eca296751f64f4d13532956fe..cee860e5989af83970d259f2288524e1f7cbc70e
https://github.com/kubevirt/kubevirt/compare/d7d0d9543f45b3ef2a9744c8279c1873beae4dce..af960aecd8ec850eca296751f64f4d13532956fe


Duplicate Results

It appears the search is returning duplicate results, usually in 12's (11 duplicates and 1 original), at least for cityofboston.gov.

Closed as, ironically, a duplicate of #18. :)


Hybrid Buffer Pool and 'enlightenment'

A bit confused about the difference between Hybrid Buffer Pool and 'enlightenment'. Are they two different things?
I read a quite good article (http://nedotter.com/archive/2019/06/sql-2019-pmem-enlightenment-and-the-hybrid-buffer-pool/) which tells HBP and enlightenment are different. It says HBP is just PMEM extension of normal buffer pool and enlightment is putting data file on PMEM. Is this right? If yes, the doc page here should probably be clearer and not confuse the two concepts (especially the sentence 'The mechanism to copy the file from the PMEM device to DRAM is direct memory-mapped I/O (MMIO) and is also referred to as the enlightenment of data files within SQL Server.').

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85310dff-ada2-9b02-f8ac-758ca538be6c
Version Independent ID: dec86687-bdc5-6c69-b4be-d6179fefd5bf
Content: Hybrid Buffer Pool - SQL Server
Content Source: docs/database-engine/configure-windows/hybrid-buffer-pool.md
Product: sql
Technology: configuration
GitHub Login: @briancarrig
Microsoft Alias: brcarrig

@karldodd -- thank you for your feedback.
@briancarrig -- please look into updating the documentation.
cc: @MightyPen

@karldodd Thanks, again for this questions. I'm looking into this further, and I appreciate your patience.

@rothja Thanks. SQL2019 seems very close to GA, so maybe we need to get this clear before the release :)
Another question related to the issue is, whether we can put data files (not buffer pool cached pages) directly on PMEM device. Since it is not easy to get a machine with PMEM today, it is hard for users to test and find out. More T-SQL samples here in the doc would help a lot.

I agree this feature needs additional clarification and I am working to address shortly. Both Data and Log File Enlightenment and Hybrid Buffer Pool make use of a DAX (Direct Access) enabled file system (like NTFS or XFS) and require database files to be on byte addressable storage such as PMEM. The clean cached index leaf pages in the Hybrid Buffer Pool will be on the PMEM module with the data files without consuming any additional capacity (memory mapping). I understand the difficulty in obtaining such modules for testing purposes and we are exploring some options to present in this space. I worked with Ned on his blog post so will seek to address any discrepancies there too. Can you advise what kind of additional T-SQL examples would be helpful? I will be happy to work on getting them added.

Can you advise what kind of additional T-SQL examples would be helpful?

@briancarrig Thanks for your help. Hybrid Buffer Pool is something transparent, so I guess examples are not necessary. But for 'enlightenment', if my imagination is correct, maybe we can add some T-SQL to show how to actually put a data file or file group on PMEM device (e.g. in a create database statement? ).
Looking forward to the doc update and examples.

@briancarrig Thanks a lot for your help.

Both Data and Log File Enlightenment and Hybrid Buffer Pool make use of a DAX (Direct Access) enabled file system (like NTFS or XFS) and require database files to be on byte addressable storage such as PMEM.

Sorry but still a bit confused.. Let me put my question this way: (1) Can a database file live on a regular normal hard drive and some of its cache pages go to PMEM part in the Hybrid Buffer Pool? (2) Can a database file itself (not cache page) live on PMEM directly?

Can you advise what kind of additional T-SQL examples would be helpful?

Hybrid Buffer Pool is something transparent, so I guess examples are not necessary. But for 'enlightenment', if my understanding is correct, maybe we can add some T-SQL to show how to actually put a data file or file group on PMEM device (e.g. in a create database statement? ).
Looking forward to the doc update and examples.

I fear we failed to enlighten with the concept of enlightenment :-) I will attempt to clarify more in my next PR (landing tomorrow hopefully). The normal file I/O used for copying pages from disk to the DRAM buffer pool and writing them back out again gets replaced with interactions with a memory mapped file. The buffer pool continues to behave as it normally has, only when you enable Hybrid Buffer Pool do we expand the buffer pool scope to include PMEM.

No this is not possible currently although I am intrigued by the suggestion and would love to hear more about scenarios. Perhaps you could add a feedback item to https://aka.ms/sqlfeedback to explore more? It would be good to find out why PMEM might be more useful in this scenario than DRAM.
Yes, you store data files on the PMEM storage device file system. The files can be accessed through regular file APIs for the OS. Once you enable Hybrid Buffer Pool, on start up SQL Server requests a memory map of the file and can interact with this mapped file using memory functions as though it was a region of DRAM. This way it avoids making regular file API calls which traverse the kernel stack. Instead of block I/O calls to read from the device and copying pages to DRAM to associate buffer pool objects with a data page, the same buffer pool object can be associated with a region in the memory mapped file.

I can certainly add T-SQL to demonstrate but essentially the T-SQL will be no different than creating database files on normal block storage.

@briancarrig Thanks for the detailed explanations. Did you get a chance to update the explanation in the article? Thanks!
@karldodd Thank you for your questions. I believe that Brian has answered them and he either has (or plans to) update the content to clarify. We appreciate you asking so we can make the docs better. I am going to close now, but please feel free to respond on this thread with any more clarification you need on this question. Thank you!


Documentation of react components?

Hello,
can you please point to the documentation of the ReactJs components of coreUI. I looked around (https://coreui.io/docs) but there is no mention of the react components.

I also need the documentation for the reactjs version.
I check in the documentation page, but there is only common javascript version.

Yeah would be handy, we paid for the Pro version, but have to look at both the standard docs and the source code of the example admin template in order to figure out how to do it. Would be good to have proper documentation.

Hi. Is there an update on it?

At the start, we thought the template was self-explanatory. Apparently it's not, and it lacks proper docs.
We are working hard to bring the new CoreUI v3 with full-blooded documentation.
In the meanwhile:

for CoreUI v2 for React components see: https://github.com/coreui/coreui-react/blob/master/src/README.md
for Reactstrap: https://reactstrap.github.io/components/

Best regards.

Any update on this? I still can't seem to find anything useful in the obvious places

Version 3 of the library is much better documented: https://coreui.io/react/docs/

with the version "@coreui/react": "^2.5.1", it's ok

CoreUI v3

https://coreui.io/react/docs/

CoreUI v2

https://github.com/coreui/coreui-react/blob/v2/src/README.md

Hey guys. I have a question.
 Or the document is same with the above link page?
I've read document page of above link. But they seems to have too short explanation for use this library.


Script to get statistics on tag movements

I would combine the functionality here with the script to filter tag movement events.  So as an optional parameter you can choose to output these statistics.


New Crowdin updates

Fixes #166

@etuleu  can you please provide more details to verify this task,
Is it possible that can we get Crowdin credentials to check locals in app.


Teach ChatCraft how to get more context for certain URLs

Let's say that I'm wanting to discuss a pice of code with ChatCraft.  Further, let's say that this code is available on GitHub.  Maybe this file:
https://github.com/tarasglek/chatcraft.org/blob/main/src/lib/summarize.ts
I can easily grab that file using the GitHub REST API in the browser like so:
// Regex to extract parts from URL TODO...
const owner = 'tarasglek';
const repo = 'chatcraft.org';
const path = 'src/lib/summarize.ts';

fetch(`https://api.github.com/repos/${owner}/${repo}/contents/${path}`)
  .then(response => response.json())
  .then(data => {
    // File contents are base64 encoded in data.content
    const fileContent = Buffer.from(data.content, 'base64').toString('utf8');
    console.log(fileContent);
  })
  .catch(error => console.error(error));

Now I have the raw text content of that file, and can use it as part of my chat.
I wonder if we should automate this, such that ChatCraft can do this automatically.  Maybe I use a special syntax, like @github:https://github.com/tarasglek/chatcraft.org/blob/main/src/lib/summarize.ts or @github:tarasglek/chatcraft.org/blob/main/src/lib/summarize.ts etc and when I include that in a prompt, ChatCraft automatically downloads the file and adds it to the context of the chat.
There are probably a bunch of places where this would be useful:

PRs
Issues
Files (like above)
Gists

We could also do it automatically (maybe pref it?) so you don't need to prefix these URLs, but that might also lead to unexpected behaviour.
Which other URLs/domains would be useful to do this for?
You could also do it for @url:... and write a Pages Function to download the content and get the content (HTML) or text content.
Thoughts?

I'm not usually a fan of copilot, but I think they are onto something with /commands, see their latest release notes and create workspace demo https://code.visualstudio.com/updates/v1_81#_github-copilot
btw.
I think we should copy their little demo and release notes style :)
Maybe we should have a feature for /commands for fav functions. It's very IRC, very chat-ui

Can you say more about what you mean?  Are you suggesting we add something like /github ...?

You've got me thinking about all kinds of things now, this idea is brilliant!  I wouldn't have thought to do it, but it's so obvious now that you describe it.
Where functions are custom JS functions called by LLMs, commands would be called by user's via prompts.  Here are some I can already imagine:

/new creates a new chat (like going to chatcraft.org/c/new)
/clear clears all messages in the current chat
/summary or /summarize or /summary 500 creates a summary of the current chat, optionally taking a number of words (e.g., 500)
/shorten same idea as /summary, but deletes all messages and leaves you only with the summary
/github <github-url-or-part-thereof> calls the GitHub REST API to get raw text content for a given URL or part of a GitHub URL (gist, issue, pr, code)
/get like /github but for regular URLs.  Could also do /json to download the result as json
/share shares current chat and gives you the share URL
/help or /help <cmd> gives help

etc.  What other ones can you think of?

transcribe is one i want badly for youtube
there are commands and also bots like @fn:ssh to run commands or maybe invoke rest apis
/summarize @youtube http-youtube-link
would be pretty fly.

/translate would be another cool command for ESL users to replace whats entered with english

I don't have concrete ideas for these :)
translate should probably translate lass message to some preferred lang if run without prompt, eg /translate -lang ua
/translate <type sentence in ukrainian> would probably just translate the prompt
Re transcribe, yes, would be some rest api call probably  to something that can pull down youtube, transcribe it and return text
key here would be composability with summarize

I've never seen composable slash commands in any app I've used before.  I'm not sure you you'd do it, tbh.  Have you seen this?
I feel like the Chat and its messages give you the context for composition (i.e., /translate dumps text into the chat, /summary acts on it, etc).

Your simpler suggestion makes sense.

/translate could be made to work in browser via a worker running an ONNX model using https://huggingface.co/spaces/Xenova/react-translator (code is https://github.com/xenova/transformers.js/tree/main/examples/react-translator).
As with a Speech-to-Text model, you need to download and cache it first.  So maybe we'd need a way to do that in the Settings dialog, so users can opt into waiting on a big download.


Added code for LCA of a tree using binary lifting in c++

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
Added code for  Lowest Common Ancestor using binary lifting in c++.
Checklist

[✅] I've read the contribution guidelines.
[✅] I've checked the issue list before deciding what to submit.
[✅] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Added #2247
(Write your answer here.)

Add README updates and format your Code using a C++ Formatter. Thanks!

Add README updates and format your Code using a C++ Formatter. Thanks!

Done with all the required  changes

@krishmurarka Add sample input-output, space and time complexity for preprocessing the tree and for each LCA query.

@krishmurarka Add sample input-output, space and time complexity for preprocessing the tree and for each LCA query.

done with the changes, Thank you.

@krishmurarka Add sample input-output, space and time complexity for preprocessing the tree and for each LCA query.

done with the changes


[Feature Request] Add mask pattern like imask.org into input component

Is your feature request related to a problem? Please describe.
I am a web developer utilizing your library for my projects. I have a suggestion for adding a new feature that could enhance the user experience.
I need the input component in your library to support patterns, particularly by incorporating the functionality provided by imask.org. This feature would enable us to accept various formats for input, such as different country phone number formats, Jalali dates, or even various banking patterns, and validate these inputs accordingly.
I believe incorporating this feature into your library would greatly assist developers and improve the form-building experience.
Thank you.
Resources:

Date Range Field
IMask

Describe the solution you'd like
I would like the input component in NextUI to integrate support for patterns, leveraging the functionality available in imask.org. This enhancement would allow developers to specify and enforce specific input patterns for fields, enabling validation of various formats such as different country phone number formats, Jalali dates, or diverse banking patterns.
Ideally, the solution should provide a simple and configurable way for developers to define these input patterns, ensuring flexibility and ease of use. Additionally, it would be beneficial if the library includes built-in validation mechanisms to ensure that the entered data adheres to the specified patterns.
In summary, the solution I envision involves seamless integration of pattern support into the NextUI input component, offering developers a versatile tool to manage and validate diverse input formats.
Describe alternatives you've considered
In exploring alternatives for pattern support in the NextUI input component, I considered the following options:
Custom Input Components:
Developers could create custom input components for specific patterns. However, this approach might lead to code duplication and increased complexity, especially when dealing with various formats.
Third-Party Libraries:
Recommending the use of third-party libraries, like imask.js, was another option. While these libraries offer extensive pattern support, relying on external dependencies might introduce compatibility and maintenance challenges.
Regex-Based Validation:
Developers could implement pattern validation using regular expressions. However, this approach might be less intuitive for those not familiar with regex and could be more error-prone.
Callback-Based Validation:
Implementing a callback-based validation system where developers define custom validation functions. While this offers flexibility, it may not be as straightforward as having a built-in pattern support feature.
After considering these alternatives, integrating native pattern support into the NextUI input component emerged as the preferred solution. This approach ensures a standardized, user-friendly experience for developers without relying on external dependencies or complex custom implementations.
Screenshots or Videos

Hey @kindslayer you can use any mask library to control the input value, here's an example
[


UX: Should it use CardView or MaterialCardView for list?

If a GardenPlanting starts to contain more information in its RecyclerView I could see it using a Material CardView.  For now, both Plant list and the GardenPlanting should follow the MDC guidelines for an image list.


FIle Upload error

Hello,
I've already gone through the existing issue about multipartfile, but now I'm facing a new issue (it was working a few months back)
I'm stuck with
NoSuchMethodError: Class 'FormData' has no instance method '[]'.
Receiver: Instance of 'FormData'
Tried calling: []("query"))

any idea why this might be?

please share more information about your setup, you queries, isolate client or standard client, fetchpolicy, etc.

closed because of inactivity


get-stage3.sh: Replace non-POSIX ${FILE/${DATE}/current} with sed

${parameter/pattern/string} isn't in POSIX 2013, which leads to:
43: ./get-stage3.sh: Bad substitution

when folks run a strictly-POSIX shell.  Replace it with command
substitution invoking echo and sed.
An alternative to #5.

Thanks! LGTM.


Add ImportSectionView

Ruby and Python import by file rather than by type. Additionally, they group imports by standard, external (thrid party), and app. This PR updates import handling to account for importing by file and grouping file imports.
Part of the Ruby MVVM migration

Add CommentReformatter
Add BundlingDescriptorView
Add GrpcDocView
Add ImportSectionView
Break ApiMethodTransformer into DynamicLangApiMethodTransformer and StaticLangApiMethodTransformer
Add ParamDocTransformer
Ruby MVVM migration

Codecov Report

Merging #1003 into master will increase coverage by 0.04%.

@@             Coverage Diff              @@
##             master    #1003      +/-   ##
============================================
+ Coverage     85.24%   85.28%   +0.04%
- Complexity     3367     3376       +9
============================================
  Files           341      344       +3
  Lines         13415    13452      +37
  Branches       1532     1534       +2
============================================
+ Hits          11435    11472      +37
  Misses         1545     1545
  Partials        435      435

Impacted Files
Coverage Δ
Complexity Δ

...m/google/api/codegen/viewmodel/FileHeaderView.java
80% <ø> (ø)
4 <ø> (ø)
:x:

...en/transformer/php/PhpGapicSurfaceTransformer.java
98.4% <ø> (ø)
15 <ø> (ø)
:x:

...ansformer/csharp/CSharpGapicClientTransformer.java
98.7% <ø> (ø)
36 <ø> (ø)
:x:

...sformer/csharp/CSharpGapicSnippetsTransformer.java
98.24% <ø> (ø)
31 <ø> (ø)
:x:

...le/api/codegen/discovery/viewmodel/SampleView.java
100% <ø> (ø)
3 <ø> (ø)
:x:

...com/google/api/codegen/viewmodel/InitCodeView.java
100% <ø> (ø)
2 <ø> (ø)
:x:

...nsformer/java/JavaGapicSurfaceTestTransformer.java
90.18% <ø> (ø)
31 <ø> (ø)
:x:

...m/google/api/codegen/transformer/SurfaceNamer.java
79.51% <ø> (ø)
147 <ø> (ø)
:x:

.../transformer/StandardImportSectionTransformer.java
100% <100%> (ø)
4 <4> (?)

.../transformer/java/JavaGapicSurfaceTransformer.java
98.76% <100%> (+0.01%)
43 <ø> (ø)
:x:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e7cc2...b4da6ed. Read the comment docs.

LGTM


models not recognized

Looks like models o1, o4 e gpt-4 do not work (I've premium account and set up the api key as in the markdown)
2024-12-18 00:16:52.025 26751-26782 AndroidRuntime          com.example.inventorymapper          E  FATAL EXCEPTION: Thread-3 (Ask Gemini)
                                                                                Process: com.example.inventorymapper, PID: 26751
                                                                                com.openai.errors.NotFoundException: 404: OpenAIError{additionalProperties={error={message=The model `gpt-4o` does not exist or you do not have access to it., type=invalid_request_error, param=null, code=model_not_found}}}
                                                                                at com.openai.core.handlers.ErrorHandler$withErrorHandler$1.handle(ErrorHandler.kt:69)
                                                                                at com.openai.services.blocking.chat.CompletionServiceImpl.create(CompletionServiceImpl.kt:65)
                                                                                at com.openai.services.blocking.chat.CompletionService.create$default(CompletionService.kt:28)
                                                                                at com.openai.services.blocking.chat.CompletionService.create(Unknown Source:7)
                                                                                at com.example.inventorymapper.OpenAIService.run(OpenAIService.java:36)
                                                                                at com.example.inventorymapper.MainActivity$2.run(MainActivity.java:80)
                                                                                at java.lang.Thread.run(Thread.java:1012)
---------------------------- PROCESS ENDED (26751) for package com.example.inventorymapper ----------------------------
---------------------------- PROCESS STARTED (26870) for package com.example.inventorymapper ----------------------------
2024-12-18 00:20:57.548 26870-26870 OpenAI                  com.example.inventorymapper          D  Sending message
2024-12-18 00:20:59.029 26870-26902 AndroidRuntime          com.example.inventorymapper          E  FATAL EXCEPTION: Thread-3 (Ask Gemini)
                                                                                Process: com.example.inventorymapper, PID: 26870
                                                                                com.openai.errors.NotFoundException: 404: OpenAIError{additionalProperties={error={message=The model `gpt-4` does not exist or you do not have access to it., type=invalid_request_error, param=null, code=model_not_found}}}
                                                                                at com.openai.core.handlers.ErrorHandler$withErrorHandler$1.handle(ErrorHandler.kt:69)
                                                                                at com.openai.services.blocking.chat.CompletionServiceImpl.create(CompletionServiceImpl.kt:65)
                                                                                at com.openai.services.blocking.chat.CompletionService.create$default(CompletionService.kt:28)
                                                                                at com.openai.services.blocking.chat.CompletionService.create(Unknown Source:7)
                                                                                at com.example.inventorymapper.OpenAIService.run(OpenAIService.java:36)
                                                                                at com.example.inventorymapper.MainActivity$2.run(MainActivity.java:80)
                                                                                at java.lang.Thread.run(Thread.java:1012)
---------------------------- PROCESS ENDED (26870) for package com.example.inventorymapper ----------------------------
---------------------------- PROCESS STARTED (26961) for package com.example.inventorymapper ----------------------------
2024-12-18 00:21:39.567 26961-26961 OpenAI                  com.example.inventorymapper          D  Sending message
2024-12-18 00:21:40.781 26961-26992 AndroidRuntime          com.example.inventorymapper          E  FATAL EXCEPTION: Thread-3 (Ask Gemini)
                                                                                Process: com.example.inventorymapper, PID: 26961
                                                                                com.openai.errors.NotFoundException: 404: OpenAIError{additionalProperties={error={message=The model `o1` does not exist or you do not have access to it., type=invalid_request_error, param=null, code=model_not_found}}}
                                                                                at com.openai.core.handlers.ErrorHandler$withErrorHandler$1.handle(ErrorHandler.kt:69)
                                                                                at com.openai.services.blocking.chat.CompletionServiceImpl.create(CompletionServiceImpl.kt:65)
                                                                                at com.openai.services.blocking.chat.CompletionService.create$default(CompletionService.kt:28)
                                                                                at com.openai.services.blocking.chat.CompletionService.create(Unknown Source:7)
                                                                                at com.example.inventorymapper.OpenAIService.run(OpenAIService.java:36)
                                                                                at com.example.inventorymapper.MainActivity$2.run(MainActivity.java:80)
                                                                                at java.lang.Thread.run(Thread.java:1012)

Btw is possible with this api to send and receive images from o4? I need it for a UNI small android application in Java

Can you double check that you have access to these models by calling the new model listing endpoint?
client.models().list(ModelListParams.builder().build())
    .autoPager().forEach(model -> System.out.println(model.id()));

This should help us verify which models your account has access to.

It is not yet possible to send and receive images, but that's on the roadmap for the beta SDK release (it's currently in alpha).


Remove crypto request sign -> SIGNATURE

Could you also remove any uses of the constants related to the signature (the key and the version) in constants.ts and state.ts as well as any now unused functions/getters like Request#sign().

I can confirm that, the signature of signed_body got replaced with the constant SIGNATURE


ipynb files doesent open

Type: Bug
Since the update, in my ubuntu 22.04 i cant open any notebook. I reinstall de file, reinstal de complements.
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:08:25.066Z)
OS version: Linux x64 6.5.0-28-generic
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 5 5600X 6-Core Processor (12 x 4199)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
1, 1, 1

Memory (System)
31.22GB (20.02GB free)

Process Argv
--crash-reporter-id 4fde2844-528d-4ffe-b270-a8a8356bdfda

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (11)

Extension
Author (truncated)
Version

copilot
Git
1.186.0

copilot-chat
Git
0.15.0

vscode-docker
ms-
1.29.1

debugpy
ms-
2024.6.0

python
ms-
2024.6.0

vscode-pylance
ms-
2024.4.1

jupyter
ms-
2024.4.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaac:30438847
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:31000449
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
ccp2r3:30993541
dsvsc020:30976470
pythonait:31006305
chatpanelt:31018789
dsvsc021:30996838
jg8ic977:31013176
pythoncenvptcf:31022791
dwnewjupytercf:31035177

@DonJayamanne I wonder if it could be our changes in ipynb extension.

@jocastrocUnal Sorry you are running into this issue.
Are you still running into this problem?
Please can you share a screenshot of the error you get when you try to open the ipynb files
Can you open dEv tools using Toggle Developer Tools, and then go into the Console window and see if there are any errors once you've tried to open ipynb files, if there are any please share the screenshot of logs of the errors.
@rebornix Unlikely, it should not cause anything to fall over, besides I would have expected a lot more users to report issues.

Wen the file has big outputs, the file size is also big (100 - 200 mb). We i clear the outputs and reopen the notebook the error is solve.


Named export

Any reason for the named export in addition to the default export?
Getting the following ESlint error:
eslint-plugin-import: Using exported name outdent as identifier for default export.
The error is caused because the variable name outdent in import outdent from 'outdent'; is used by a named export from the "outdent" package.

Yeah, named exports are a great way for code editors/language services to write import statements automatically.  Refer to outdent in your code and the editor will offer to import {outdent} from 'outdent'; automatically.
As you probably realized, the fix is simple: import {outdent} from 'outdent'; or turn off that linter rule since it seems not to be helping.

Gotcha. Thanks for the prompt explanation.
FYI I use ST3, and it doesn't make that recommendation to me.
Might be worth evaluating the cost-benefits of duplicating exports like this.
I haven't seen this convention before and I can imagine it confusing other forms of static analysis (eg. autocompletes that attempt to derive the default export name from package name).

Which plugin are you using to enable automatic imports?
Sublime leans on plugins for this type of functionality and doesn't bundle any sort of language intelligence, so your experience will depend on the quality of plugin you're using.  Fortunately the JS language service can be embedded in any editor, which allows us to say with some confidence that the experience between decent editors will be similar.

Ah thanks for going out of your way to show me that.
I deliberately opt of IDE features like this but maybe I'll try it out this week.
Thanks 🙏


feat(serialization): Bringing over the DataStream class from UTP

This PR brings in a copy of the DataStream class from the UTP package with some modifications. It removes the NetworkCompressionModel support as well Packed support.
While yes this is code duplication, the DataStream class in UTP is about 100x faster in testing than the current BitWriter/Reader and is job/thread safe and doesn't do any sort of managed allocations or boxing. The reason we are wanting to copy this over instead of putting it into a collection package or something is the DataStream is part of UTP which is also used for DOTS Netcode which would require a bunch of work on new packages and moving things around and bring in Network specific code into Collections which is not going to happen in the near-term. So for now to get the major perf gains this will result in code duplication for the march release as we work towards a more perm place for this code to be used across different packages without needing to bring in all of UTP. (potentially a share networking package between DOTS/Current Unity)
For follow up task to Unify see: DST-188
Changelog
com.unity.multiplayer.mlapi

Added: DataStream class is now part of the package

Testing and Documentation

Includes unit tests.
No documentation changes or additions were necessary.

@mattwalsh-unity I went ahead and created DST-188 in the Server teams backlog item to figure out a path to Unify the two.


Regularized Gaussian extension: RegularizedUniform and Constraints/Nonnegative Gaussian/GMRF alternatives

Closes #436
Sub PR from #424

Added RegularizedUniform implicit prior
Added ConstrainedGaussian/GMRF and NonnegativeGaussian/GMRF as simplified alternatives

Explanation of RegularizedUniform:
Consider a regularized Gaussian posterior of the form:
$\min_{x} \text{likelihood}(x, \hat{b}) + \frac12  ||x - \hat{\mu}||_{\Sigma^{-1}}^2 + f(x)  $.
In various cases, we might not want the randomized linear least squares term from the RegularizedGaussian prior, but only the penalty $f(x)$. To make the randomized prior term disappear, we let $\Sigma^{-1} = 0$, or more precisely, $\Sigma^{-\frac{1}{2}} = 0$, such that the posterior takes the form:
$\min_{x} \text{likelihood}(x, \hat{b}) + f(x)  $.
This, the RegularizedUniform can be interpreted as a RegularizedGaussian with infinitely flat underlying Gaussian, i.e., a uniform "distribution" on the unbounded parameter space.
By letting the RegularizedUniform inherit from RegularizedGaussian, set the sqrtprec to zero, RegularizedLinearRTO will accept this implicit prior without modification.
To-do:

[x] Add tests

Hi @nabriis ,
I've added an explanation as to why I have designed the RegularizedUniform class as such above, hope it helps.

PS, should this PR remain a draft or be changed?

Thanks for the comment @jakobsj ,
I have now updated all the documentation and added some tests.

I have now renamed RegularizedUniform to RegularizedUnboundedUniform

Thanks @jeverink. I've rerequested review from Nicolai.


Whisper Model

Model description
Whisper is the actual most used ASR Model on the hub.
Since Idefics as multimodal model joined the tgi server I wondered if whisper could be interesting too.
Is this out of scope or would it be interesting ?
Open source status

[X] The model implementation is available
[X] The model weights are available

Provide useful links for the implementation
No response

Fully out of scope.
ASR solutions are indeed interesting, and may warrant their own docker solution.
Whisper by itself to be "good" requires a lot of fiddling and custom code in order to provide "good" results (there's a lot of things trying to prevent it from hallucinating, like dynamic temperature, custom logits decoder, no batching on long files and instead serialized decoding etc...).
IMHO wav2vec2 is still highly competitive in the ASR market just because the runtime costs are basically nil compared to whisper, and it's not a decoder model (single forward pass)
Idefics was added because we needed an efficient running solution short term and it was the easiest place to add it. But it's still far from perfect nor optimized all the way. If multimodal starts to pick up a lot, we'll definitely revisit the decision and depending on usage patterns and models we see coming up we'll consider our options.
We'd rather have a few different containerized solutions which are highly efficient at what they do, rather than forcing everything into TGI and be stuck for adding features because of the already pretty large feature set which all have to work together.

Sounds reasonable
Will have an eye on huggingface org to see when tgi brothers reach github ;)


[WIP] Try setting to c++20 again

This requires some custom logic in the meson.build file, but we should be able to remove it at some point in the near future.

@TwnKey : If the .pro file modification doesn't work for you, then please change it back and commit it.


docs: Add BentoML deployment doc

Hi vLLM team,
I would like to contribute a BentoML doc in the "Serving" section. Please let me know if you have any questions. Thanks!

@zhuohan123 @Yard1 @simon-mo Could you please help review this when you have some time? Thanks!


defaultInitialNodes appears to be ignored

When starting bmd for the first time with --nodnsseed, bmd should boostrap using the list of peers in defaultInitialNodes. however it never attempts to connect to any of them.

Fixed! https://github.com/DanielKrawisz/bmd/commit/7d114c25c4daf5660d51bf17f62b2ff16fbf5168


Parallelization and LXD timeouts

cleanupOrphanedGithubRunners() now uses errgroup to parallelize and report errors when removing runners from the provider.
retryFailedInstancesForOnePool() now uses errgroup
Removed some setPoolRunningState which should be treated in the loop where those errors eventually bubble up and can be handled.
Added a number of timeouts in the LXD provider for delete and list instances. This provider should be converted into an external provider.

Updated to this PR - let's see 😄

Hey @gabriel-samfira,
looking really good:
# lxc list | grep garm- | wc -l
20

🥳 Not seen any ghost container since this branch!

awesome! Will merge it. Thanks for testing!


cleanup: remove io/ioutil

The package about io/ioutil has been deprecated from go 1.16: https://go.dev/doc/go1.16#ioutil
We should remove it for go version 1.18 which used by tekton/pipeline.
We can clean up by directory in batches, like:https://github.com/tektoncd/pipeline/pull/5864

I don't see any more usage of "io/ioutil" outside of our vendor directory so I'm going to go ahead and close-- thanks @my-git9 for your contributions! Feel free to reopen if there's something I missed.


feature: kubefile CMD support ENV values with "${...}" and "$..." format

🤖 Generated by Copilot at b065a77
Summary
🆕🛠✅

This pull request adds new syntax options for variable expansion in the expansion package and the getGuestCmd function. It also updates the expand.go file and adds tests to the guest_test.go file to reflect the changes. The new syntaxes allow more flexibility and convenience for users who want to use variables in their cluster commands or mount images.

getGuestCmd tests
new syntax for variables
autumn of expansion

Walkthrough

Rename constants and add new ones to support two variable expansion syntaxes: $() and ${} (link)
Modify tryReadVariableName to use the renamed constants and handle the new syntaxes (link, link)
Add test functions to check getGuestCmd with different variable expressions in pkg/guest/guest_test.go (link)

refer to #3853

i have test it  and it's work
# cat Kubefile
FROM scratch
ENV VERSION=v1.0
CMD ["echo VERSION=${VERSION}"]

The result
root@kube001:~# sealos run registry.cn-shenzhen.aliyuncs.com/cnmirror/test:v1.0
2023-09-15T17:01:19 info start to install app in this cluster
2023-09-15T17:01:19 info Executing SyncStatusAndCheck Pipeline in InstallProcessor
2023-09-15T17:01:19 info Executing ConfirmOverrideApps Pipeline in InstallProcessor
2023-09-15T17:01:19 info are you sure to override these following apps?
registry.cn-shenzhen.aliyuncs.com/cnmirror/test:v1.0
Yes [y/yes], No [n/no]: y
✔ Yes [y/yes], No [n/no]: y█
2023-09-15T17:01:21 info Executing pipeline MountRootfs in InstallProcessor.
2023-09-15T17:01:21 info Executing pipeline MirrorRegistry in InstallProcessor.
2023-09-15T17:01:21 info Executing UpgradeIfNeed Pipeline in InstallProcessor
VERSION=v1.0
2023-09-15T17:01:21 info succeeded install app in this cluster
2023-09-15T17:01:21 info no nodes that need to be scaled
2023-09-15T17:01:21 info
      ___           ___           ___           ___       ___           ___
     /\  \         /\  \         /\  \         /\__\     /\  \         /\  \
    /::\  \       /::\  \       /::\  \       /:/  /    /::\  \       /::\  \
   /:/\ \  \     /:/\:\  \     /:/\:\  \     /:/  /    /:/\:\  \     /:/\ \  \
  _\:\~\ \  \   /::\~\:\  \   /::\~\:\  \   /:/  /    /:/  \:\  \   _\:\~\ \  \
 /\ \:\ \ \__\ /:/\:\ \:\__\ /:/\:\ \:\__\ /:/__/    /:/__/ \:\__\ /\ \:\ \ \__\
 \:\ \:\ \/__/ \:\~\:\ \/__/ \/__\:\/:/  / \:\  \    \:\  \ /:/  / \:\ \:\ \/__/
  \:\ \:\__\    \:\ \:\__\        \::/  /   \:\  \    \:\  /:/  /   \:\ \:\__\
   \:\/:/  /     \:\ \/__/        /:/  /     \:\  \    \:\/:/  /     \:\/:/  /
    \::/  /       \:\__\         /:/  /       \:\__\    \::/  /       \::/  /
     \/__/         \/__/         \/__/         \/__/     \/__/         \/__/

                  Website: https://www.sealos.io/
                  Address: github.com/labring/sealos
                  Version: untagged-0ed82702

root@kube001:~#


Update default blockwise token to avoid DataFrame column name clash

Our current default blockwise token prefix ("_") can interact poorly with DataFrames that have column names like _0, _1, etc. The PR proposes we update our default token prefix to something more unique ("__default__") that's less likely to clash with user inputs.
cc @jcrist for review if you get a moment
Closes https://github.com/dask/dask/issues/6540

[x] Tests added / passed
[x] Passes black dask / flake8 dask

This seems like a very reasonable low-impact solution to me. And I think __dask_default__ or __dask_blockwise__ would be fine names.

@jrbourbeau did you want to get this one in today?

Let's hold off on this one to rock the boat before releasing. But after 2.30.0 is out, this should be good to go

@jrbourbeau mind if I pick this up and finish it off?

Yeah, feel free to 👍 I'm curious if @rjzamora's recently blockwise HLG work will be impacted by this or not

I'm curious if @rjzamora's recently blockwise HLG work will be impacted by this or not

I certainly hope changing the default string doesn't break anything, but anything that breaks shouldn't be depending on the "_" default anyway :)

Tests pass for me locally. My plan is to merge when green, unless there are any last comments.


Black grid fade in the distance

On worlds with larger terrain generation, the faint black outline on textures merge and create a black grid of sorts seen in the example below.

In the example, the world's size is set to

This also happens with the original textures. I have my textures scaled up to 4096x4096.

This is a frequently reported bug, see #39 for more details.

might be off-topic, but did you know that the world shouldn't be more than 254x254 in size, so picking blocks can work properly?


Fix preallocation of V

Ok, so now there's a conflict which you can fix by rebasing against the remote master branch:
git checkout [yourlocalbranch]
git fetch source/master
git rebase -i source/master
# it will show you some conflict and asks you to fix it
# go to your editor and fix the conflict in run.jl
# go back to your terminal and do
git add src/run.jl
git rebase --continue

then push again with git push remote [branchname] -f


Use Velox Build Type for Arrow Build

This fix helps with debugging Arrow integrations.

For some reason thrift is not built by the time we build arrow_bridge?

I also feel the Velox CI image should contain the Thrift dependency to save CI build time. CC @kgpai

@Yuhta Adding a dependency did not help.

I built this locally. The thrift library name is libthriftd.a

@Yuhta all checks are passing. Can you please import and merge this? Thanks.


Update _index.md

Hello Team,
This is Sarang from control center team. We are planning to move Billing accounts section from control center documentation to basic package section. As we are removing Billing account navigation from control center, hence this change is required. I already raised one pull request for adding billing account section to basic package with name 'Renew Payment Method' Please feel free to get in touch with me on slack if anything is required.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create a release tag for 0.13.1

We rely on the release tags to deploy versions of Empire to our infrastructure; we'd like to use 0.13 but as 0.13.1 contains what appears to be a fairly critical bug fix for emp run (which we use extensively) would it be possible to get a tag created for this release so that we can target it?

Looks like no new release in over a year. Is the project EOL? =)

@ejholmes thanks for the added context! =)


Add status information and method, to api

I am 95% sure I will merge this as is.   I kind of prefer to set baseline values explicitly during init and not depend on another function to do it, but you method avoids redundant code and handles the external case.

100% your call! And funny as it is - was just pushing a minor update as your post rolled in => slight tweak, added "scan" mode for the api ... checks all tuners, doesn't stop on one being available. Tested it with the Ceton UI, RTP on and off for Tuner 4 ... detects it.
Thanks!
PS: can't wait for your PCIe 6 card ... hoping this all works great for you!

Thanks! And as always, scream if you see issues in your setup. Will fix any problems 👍

BTW, if you have the urge, check out (and comment on!)
https://github.com/arrmo/fHDHR/tree/hwaccel
https://github.com/arrmo/fHDHR_plugin_stream_ffmpeg/tree/hwaccel
Using it here - hevc HW accel running, so I reduce the BW to my "clients" (i.e. VLC, Plex, etc.). And no Plex postprocessing script, to get my HDD space back ... LOL!

Sweet.  I started to look a few days back, but the profiles were all reducing resolution, so I did not actually test.  The custom HVEC profile definitely is something I will want to play with...

All but the last one were already in the code - I just kept them. I have been fiddling here with the "custom" profile. And it's set up that if you set that in config.ini ... the file is read whenever ffmpeg is started. So no need to restart fhdhr => just change parameters, stop and restart your stream, and new parameters are in use.

FYI, couple interesting notes ...
https://developer.nvidia.com/blog/nvidia-ffmpeg-transcoding-guide/
https://www.reddit.com/r/ffmpeg/comments/euiwtv/scale_cuda_vs_scale_npp/

BTW, one little thing I still want to figure out => nvenc is limited, to 3 simultaneous instances. So after that ... fallback to SW encoding. I can see a way to do it, looping through codecs, but that seems a bit ugly to me. Not sure if there is a better way, to know when there are no GPU engines left. Something to noodle on 😜

Have you patched you Nvidia drivers?  I have a low-end 1650 (no fans or additional power connector) and with the patch it is rumored to be good for a dozen or so HD transcodes.

No, haven't heard about that - got any more info! I have an even lower end 960 ... LOL. But the 3 I was referring to comes from here. Perhaps though this is a SW limited stop? Does seem odd to me that all the way to a 3090 the limit is the same?

Nvidia limits lower end devices to I thought 2.  The patch is on github, google 'nvidia driver patch'
There are a list of supported drivers, and a patch script.   If it falls back cleanly to software, then adding a warning to the docs that the user needs to know their system limits.  We could track in in tunerstatus and skip transcoding if we exceed official limits, but I'm not really in favor of that.

Will check for that, thanks! But I do find that I get to 3 ... just not to 4 (tuner count) - and that seems to match Nvidia info?

We could track in in tunerstatus and skip transcoding if we exceed official limits, but I'm not really in favor of that.

Yes, agreed. I'd like to fall back to another transcoding (e.g. libx265), if no GPU HW left. => use the GPU until full, then CPU.

You had it right! Check this out, https://www.tomshardware.com/news/patch-boosts-video-encoding-for-nvidias-consumer-gpus
=> and, https://github.com/keylase/nvidia-patch
Checked it, running 8x parallel encodes right now 🕺. No need for a fallback!

And there is no magic in the patch.  It simply removes a static limit in the code from Nvidia, and that limit was there just to encourage people to buy the 3x more expensive Pro card...

That's crazy, just in some firmware. Thanks for the pointer!

BTW, when you have HW encoding going on, just me - or do you always get 0 from this?
nvidia-smi --query-gpu=encoder.stats.sessionCount --format=csv,noheader

Thanks!

I planned to use HW acceleration, but all my devices are high bandwidth and have modern codec support, so I almost never actually have the system transcoding.  I do recall early on while testing that just 'nvidia-smi' would indicate that there were active sessions.  I'll try and setup a test to force transcoding and see what happens...

And with very limited testing, yes I get zero.  Even when just nvidia-smi indicates there is a session...

And with very limited testing, yes I get zero. Even when just nvidia-smi indicates there is a session...

OK, thanks! They say that nvidia-smi may be limited. I do find that telegraf will capture utilization, that works as well 😄

I'll try and setup a test to force transcoding and see what happens

If you want, let me push my latest updates to my repository - then you can try those out.

OK, updated. You need to pull top level (fHDHR), and the ffmpeg plugin if you want to check out the updates. And once fHDHR is up and running => if you change transcode.json, it will take effect on the next ffmpeg start (i.e. "dynamically" reads the file, on ffmpeg startup).
If you don't specify a transcoding, or remove transcode.json => it just falls back to the original default (copy).
Thanks!

Thanks, will take a look on Monday...

No panic. Have a nice weekend!

And also a question - no panic here as well! I'm looking to add channel + SNR to the API => I use it to write to influx, then get a daily report. If SNR degrades, go check cables, etc.
Add that info to the current status method, or add a new method? I'm good with either, whatever you prefer.
Thanks!

If you mean adding those to the tunerstatus dict, then yeah that is a reasonable bit of into to include there...

Exactly! Will do.

Done! #39
Thanks!


Terminal Window does not scroll

Terminal window does not allow scrolling up to previous output. Previous to 1.4, this was an intermittent problem, now its a permanent problem.

VSCode Version: 1.4
OS Version: OS X v10.11.6
zsh

Steps to Reproduce:

Open prompt window
Enter a few commands to create more output than the window size
Attempt to scroll up or down

Duplicate of https://github.com/Microsoft/vscode/issues/7817, the upstream issue is https://github.com/sourcelair/xterm.js/issues/151


Multipass-alignment

This performs multiple passes on alignment, ensuring that requested versions for aligned transitive dependencies are reflected.

This hasn't resulted in any increase in our test times, so that bodes well for the performance impact, but we'll definitely want to test this against our more pathological projects internally.

Our worst case project internally adds an additional 3 seconds per pass, so 10 -> 16 seconds in for dependencies --configuration compile for instance.


[irods/irods#7220] update externals (4-3-stable)

In service of irods/irods#7220
Merge irods/irods#7527 first

#'d


Support for literal translations (map type !programming_language)

This issue specifically focuses on defining how mappings in a return in the DSL should be handled for different programming languages. Currently, TESTed relies on heuristics to determine whether a mapping is intended for translations or programming languages.
A potential solution is to explicitly specify this in the return statement within a test suite, as illustrated below:
return: !programming_language
  "python": "{1, 2, 3}"
  "javascript": "new Set([1, 2, 3])"

To my knowledge, TESTed actually has no heuristic at the moment. I think, if a YAML map is encountered with return:

If the map has !oracle, it is an explicit oracle.
Else the map is considered a literal map as the return value.

I don't think there is currently support for specifying a return value in multiple languages. If added, I think an explicit tag is probably the way to go. I experimented a bit, and for example, the following:
return:
  "python": "{1, 2, 3}"
  "javascript": "new Set([1, 2, 3])"

Is interpreted as a testcase where return value must be a map with the two keys "python" and "javascript".
I do think the explicit requirement makes sense if adding other map types.
However, adding support specifically for language literals also requires adding support for actually comparing these values. This would probably involve implementing a new oracle that supports comparisons in a target programming language, similar to how the programming-language-specific oracles work (or this is how I would implement it at least).

Probably the only place where TESTed-DSL currently allows to specify programming-language specific values is in statement and expression. So for statement and expression we either have a string or a map (differentiation by programming language) as a value, so explicit typing of the map is not needed there to resolve the type of the map (there is only one map). However, explicit typing will become necessary if we also introduce the option to translate the statement and expression in multiple natural languages: to resolve !programming_language maps from !natural_language maps.
I would not introduce programming_language differentiation for return values for now, as there is no direct need for it (I updated my above comment, as I was mistaken that we already supported this). However, translating the return value (and other input and output channels) in multiple natural languages is something we would like to introduce. So resolving YAML-maps as literal maps, oracles or translations in natural language will also be needed for return values.
Good to hear that we don't use heuristics for map-resolution in TESTed yet. This is good design and we have to make sure that we keep it this way.

@BrentBlanckaert: Is it clear for you that we don't want the !programming_language extension for return. We only want to keep it for statement and expression , but allow to make it explicit there to differentiate between !programming_language and !natural_language translations. Since TESTed treats maps at that place as !programming_language maps, this should remain the default for untyped maps.

So !programming_language for returns will no longer be implemented and it's already present in in statement and expressions.
So the next step would be to to introduce !natural_language for statements, expressions, returns, stdout and `stdin?

I'm a bit confused by seeing natural language pop up here. We had a meeting where we decided that we would keep natural languages outside of tested itself and first solve this in preprocessing.

As I understood it the plan was to build in support in TESTed for translations using multiple files. Eg. suite.nl.yaml and suite.en.yaml.
This should require minimal changes in tested, simply selecting the relevant file based on the provided language.
In a next step we would write a preprocessing step to be able to write these two files in a single file.
In this format for preprocessing, the above discussion might still be relevant, as that format should also be unambiguous.

This is not about ergonomics. The end result  experience for the user should be the same.
This is about separation of concerns. TESTed is already a rather complex project. Adding language support as a preprocessing step makes this a separate maintainable package, without increasing the complexity of the current tested project.

We could actually keep everything out of the hands of TESTed. Since Dodona is calling the judge, we could also have a separate config.en.json and config.nl.json to specify separate locations for an English or a Dutch test suite (with all the other configuration settings shared). This would completely take i18n out of the hands of TESTed, and leave it up to the calling party. Would that be a good user experience (in terms of maintaining config files)?
As an author of multilingual programming exercises I'm definitely concerned about my experience as a user. Having to maintain separate test suites for each individual language is not a good user experience for me, as 99% of these test suites is shared content in my experience. The part that is translated is only a thin layer, so why not keep it that way?

This would completely take i18n out of the hands of TESTed, and leave it up to the calling party.

I would not be against this idea, actually. As it is probably better to call the preprocessor in Dodona on exercise change, instead of on every judge run.
This preprocessor step could also be used to support multi programming language descriptions and configs for exercises if desired.
But the prepocessor itself will always be judge specific as the desired output format is judge specific, so we'll have to think on how to properly design this.

If there was a meeting where we decided that we would keep natural languages outside of TESTed itself, I wasn't in that meeting.

This was brought up by Bart and me in the meeting where you showed us the detailed analysis of your 916 exercises to convert.
But since you have a different recollection of that meeting, I'll try to reiterate my takeaways from that meeting. I think the solution I took away would also resolve your needs.
From your presentation:

There is a very large numbers of exercises that support translations, we need to somehow support this in TESTed before they can be converted.
These translations often translate a very small set of keys, which are reused a lot (eg function names). We would ideally have some sort kind of templating system to support this and avoid repetition.
An ideal templating system would also be able to reduce other repetition often present in TESTed specifications

Bart and I agreed that such a templating system could be relevant for advanced users. Other university courses could also benefit from auto translations in exercises. But we also had some hesitations:

We also want to keep the current simple config for non advanced users
We do not want to bloat TESTed with non essential features

This is when the preprocessing step was suggested as a solution.
The solution would be to specify a new format that supports templating and translations.
A preprocessing step could then be written to convert this new format to the existing format.
Ideally this preprocessing step should happen in such a way that the end user doesn't have to deal with it.
We didn't discuss implementation details, leaving this to you. But for clarity this is how I imagined the next steps:

Write a way for TESTed to accept a different config based on language (I was thinking of #571 but your Dodona suggestion might also work)
Write a preprocessor program that creates a config for each supported language
Integrate this preprocessor in such a way that it is hidden from the user (such as running before tested or running after every pull on dodona or creating and publishing a github action)

I think this solution solves all of our requirements.
If you think it doesn't we should schedule another meeting to further discuss this.

You were in that meeting Peter, but you are misinterpreting the implications. We're explicitly saying you should not maintain 2 separate files.
The conclusion was that we don't want to complicate TESTed itself with natural language support since that would distract from what TESTed does well and because it would add a maintenance burden to already complicated code. The proposed solution was indeed to feed TESTed a specific test suite file based on the natural language. This would allow novice users to easily benefit from translated output without having to learn new syntax and would require minimal changes to our code.
For advanced users who don't want to maintain separate suite files, we proposed to use a template system that runs as a preprocessor. You basically write a single test suite file tests.yaml.template and the preprocessor outputs a tests.nl.yaml and tests.en.yaml. The templating system could both handle multiple natural languages as well as complex repetitions like you explained and suggested during that meeting. This preprocessor would thus be a separate script.
Since you would be the primary user, we suggested that you would propose a format and see what works and what doesn't from the experience in converting the old Python exercises. Initially, you could run the preprocessor yourself when committing and if it becomes a more mature format, we could run it on Dodona when processing exercise updates or as part of test execution.


are pydantic BeforeValidator and AfterValidator annotations supported?

Thanks!

Hi, from my testing this is not working when you load data with polars and then validate the polars.DataFrame with the pre-defined model, e.g.:
data = polars.read_csv("data.csv", has_header=True)
try:
    Model.validate(data)
except Exception as e:
    print(e)

It doesn't work either with:
data = Model.DataFrame.read_csv("data.csv", has_header=True)

It looks like this is resolved now?

https://github.com/JakobGM/patito/issues/49

It looks like this is resolved now?

[Feature] Add pre/post validators #49

I did another way but they aren't included in the patito package. I coded the application of the validators myself using polars method as much as possible in the loading methods I created to load data and validating it.


Move column threshold option

Could we add a moving column threshold option so that column moving does not start until the threshold is met?
Short description of our case: Because the column menu button is quite small for using with a tablet or mobile device, we decided that we want to add a custom header template that makes the whole header act as a button for the menu. This causes problems while trying to access the menu because not every mouse click is perfectly still, sometimes the user triggers a move action on that. Therefore we thought that adding a threshold option for when moving a column should start could fix this.
Are there any alternative solutions for this?

Yeah, there are a bunch of move things to look at, this one makes sense too.

I think this would solve #3333 also


Adding adelina to meet the team

@aaronhans the github action bot that creates PR preview links doesn't seem to be working anymore. Did I do something wrong? 😬

@kmbrlygl sorry I temporarily disabled it because I am migrating the publishing from Azure to AWS, I should have notified the team. Let me check and re-enable it

No worries. Thank you @aaronhans !


Windows project support for Flutter 3.7.7

Creating a windows project using flutter 3.7.7 changes the way the main.cpp file is generated and therefore the code to replace the app name in the cpp file had to be adjusted.
Also i removed the pubspec.lock file from the project, as it is a bad practice according to the flutter team.
Version bump to 1.2.1

Yo @obemu, thanks for the PR. But there are some changes I would like to be done here. I'll be linking them down.

I checked and found out that there are 8 more unique changes to be done from android, iOS, macOS and windows.


jetbrains.rider: 2019.1.2 -> 2019.2

Motivation for this change
New major version of the IDE.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers

cc @Mic92 (also in maintainers)

Also tested that it build and run on nixos on linux on unstable as of c1966522d7d5fa.


Fix press save in Import Defaults did not save the changed setting

Fixes #84248

Why do we have a Save button in that dialog in the first place?

I guess we have to ask reduz for that. Personally I think save property changes automatically is fine as .project file won't be too large.

Thanks!

This is a regression from https://github.com/godotengine/godot/pull/80450, in 4.1 we still have the old signal and it should work fine. So a cherry-pick is not needed.


Not able to get Poll response through new message event

I am using this for new message and its working fine but when user response for Poll message its not triggered
whatsapp.MsgStore.on('add', (msg) => {console.log(msg)})
basically I want to catch the users response on Poll

You can use the chat.poll_response event - https://wppconnect.io/wa-js/interfaces/ev.ChatEventTypes.html#chat_poll_response


Formatting: Opportunity to use a JIT trick

Looking for usages of Span found CompositeFormattingExtensions.AppendUntyped method.
It is an interesting way to check the type of generic value and gets its value - never seen that before.
But turns out the codegen for it is not the best.  If we check not values but generic argument JIT can eliminate all the parts not related to the particular type argument. It could look like this:
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
        static void AppendUntyped2<T>(T value)
        {
            if (typeof(T) == typeof(int))
            {
                Process((int)(object)value);
                return;
            }

            if (typeof(T) == typeof(long))
            {
                Process((long)(object)value);
                return;
            }

            if (typeof(T) == typeof(Guid))
            {
                Process((Guid)(object)value);
                return;
            }

           if (typeof(T) == typeof(string))
            {
                Process((string)(object)value);
                return;
            }

            throw NewNotSupportedException();
    }

Now  AppendUntyped2 called with long arg:
; Assembly listing for method CoreClrTest.Program:TestGenerics()

       4883EC38             sub      rsp, 56
       B90A000000           mov      ecx, 10
       E802D4FFFF           call     CoreClrTest.Program:Process(long)
       90                   nop
       4883C438             add      rsp, 56
       C3                   ret

The same is for other value types for which there is a branch.
With string arg code is more verbose but still good
; Assembly listing for method CoreClrTest.Program:TestGenerics()
       4883EC38             sub      rsp, 56
       48B9603015D91D020000 mov      rcx, 0x21DD9153060
       488B11               mov      rdx, gword ptr [rcx]
       488BCA               mov      rcx, rdx
       4885C9               test     rcx, rcx
       741A                 je       SHORT G_M54421_IG03
       48B8902FA9ECFD7F0000 mov      rax, 0x7FFDECA92F90
       483901               cmp      qword ptr [rcx], rax
       740B                 je       SHORT G_M54421_IG03
       488BC8               mov      rcx, rax
       E800DEAE5E           call     CORINFO_HELP_CHKCASTCLASS_SPECIAL
       488BC8               mov      rcx, rax
       E8F8D7FFFF           call     CoreClrTest.Program:Process(ref)
       90                   nop
       4883C438             add      rsp, 56
       C3                   ret

Only IBufferFormattable left to handle. And it must be done without boxing.
Turns out there is a way! EqualityComparer's one.
        interface IBufferFormattable  { }

        struct FormattableStruct : IBufferFormattable { }

        class FormattableClass : IBufferFormattable { }

        [MethodImpl(MethodImplOptions.NoInlining)]
        static void Process<T>(T i)  where T : IBufferFormattable
        {
             // process  value..
        }

        abstract class BufferFormattableDirector<T>
        {
            static BufferFormattableDirector<T> s_single;

            internal static BufferFormattableDirector<T> Single
            {
                get { return s_single ?? (s_single = Create()); }
            }

            private static BufferFormattableDirector<T> Create()
            {
                if (!typeof(IBufferFormattable).IsAssignableFrom(typeof(T)))
                    throw NewNotSupportedException();

                return (BufferFormattableDirector<T>)Activator.CreateInstance(typeof(BufferFormattableDirectorConcrete<>).MakeGenericType(typeof(T)));
            }

            public abstract void ProcessValue(T value);
        }

        class BufferFormattableDirectorConcrete<T> : BufferFormattableDirector<T>
            where T: IBufferFormattable
        {
            public override void ProcessValue(T value)
            {
                Process(value);
            }
        }

        [MethodImpl(MethodImplOptions.AggressiveInlining)]
        static void AppendUntyped2<T>(T value)
        {
            //....

            if (typeof(T) == typeof(string))
            {
                Process((string)(object)value);
                return;
            }

            BufferFormattableDirector<T>.Single.ProcessValue(value);
        }

Finally the code at all site of AppendTyped2(new FormattableStruct()) looks like this
; Assembly listing for method CoreClrTest.Program:TestGenerics()
       4883EC48             sub      rsp, 72
       33C0                 xor      rax, rax
<PHONE_NUMBER>           mov      qword ptr [rsp+40H], rax
       C644244000           mov      byte  ptr [rsp+40H], 0
       480FBE442440         movsx    rax, byte  ptr [rsp+40H]
       88442438             mov      byte  ptr [rsp+38H], al
       E801F4FFFF           call     BufferFormattableDirector`1[FormattableStruct][CoreClrTest.Program+FormattableStruct]:get_Single():ref
       488BC8               mov      rcx, rax
       480FBE542438         movsx    rdx, byte  ptr [rsp+38H]
       488B00               mov      rax, qword ptr [rax]
       488B4048             mov      rax, qword ptr [rax+72]
       FF5020               call     qword ptr [rax+32]BufferFormattableDirector`1[FormattableStruct][CoreClrTest.Program+FormattableStruct]:ProcessValue(struct):this
       90                   nop
       4883C448             add      rsp, 72
       C3                   ret

Fast, small, no boxing :muscle:
That's it.
@KrzysztofCwalina

Watch out that if the JIT refuses to inline AppendUntyped the code generated for the string case gets messy, the value type checks are no longer eliminated. That said, the result is probably still better than the original code.

Watch out that if the JIT refuses to inline AppendUntyped the code generated for the string case gets messy, the value type checks are no longer eliminated.

Probably should move the string to be the first test for this reason?

Probably should move the  string  to be the first test for this reason?

Sounds like a good idea.
In any case, it would be best to test with the actual code to see exactly what happens.

Watch out that if the JIT refuses to inline  AppendUntyped  the code generated for the  string  case gets messy, the value type checks are no longer eliminated.

And if I remember it correctly that was not the case in the past.
Interesting to see how NGEN and .NET Native handle such code?

And if I remember it correctly that was not the case in the past.

I'm not sure if I understand. The cases I looked at in the past only involved value types. Only recently I run myself into a case that involved both value and reference types and noticed the issue.

Interesting to see how NGEN and .NET Native handle such code?

NGEN probably behaves exactly the same. .NET Native is an entirely different compiler, in theory it should be able to generate the same or better code but in practice there's a good chance that it will generate worse code.

@mikedn
If not mistaken JIT used to generate optimal code for ref args. The last time I used the technique it was .net 3.5 probably.
Is there smth that prevents JIT from removing all the value type branches? The method is not going to be called for boxed value types. Why does it keep the code for them there?

Is there smth that prevents JIT from removing all the value type branches? The method is not going to be called for boxed value types. Why does it keep the code for them there?

I don't know, I only noticed this recently since I needed it in a project of my own. I was planning to take a closer look at the JIT code and possible open an issue about it but I've yet to find the time to do so.

Is there smth that prevents JIT from removing all the value type branches? The method is not going to be called for boxed value types. Why does it keep the code for them there?

Generics have a per ValueType implementation and a shared implementation for reference types - unless the function is inlined when it becomes a concrete implementation; as a wrinkle it can't inline a virtual or interface method.
So a a value type generic will eliminate all the branches as it is for a specific valuetype; but a reference type generic won't eliminate the branches as it is for all reference types (unless inlined).
In theory it could eliminate all the valuetype checks as that would have its own method and just leave the reference type checks; though I don't know if it does that.
I recently did some benchmarking around this while is relevant https://gist.github.com/benaadams/c6c109982f50c6f69af2#gistcomment-1660491

It would be great as well if JIT could make JIT time constants from calls like typeof(T).IsValueType, typeof(a_type).IsAssingnableFrom(typeof(T)) etc.

Generics have a per ValueType implementation and a shared implementation for reference types - unless the function is inlined when it becomes a concrete implementation; as a wrinkle it can't inline a virtual or interface method

What I'm talking about is different. The type checks cannot be eliminated in the following case:
if (typeof(T) == typeof(ReferenceType1)) ...
else if (typeof(T) == typeof(ReferenceType2)) ...

That's normal because the same code is used for both instantiations.
The case here is:
if (typeof(T) == typeof(ValueType1)) ...
else if (typeof(T) == typeof(ReferenceType2)) ...

For T = ValueType1 you get the expected code, all checks are eliminated. But for T = ReferenceType2 the first check isn't eliminated even though it seems like it should be because the instantiation that's used for reference type can't also be used for any value types. AFAIK generic type arguments cannot represent boxed types.

For T = ValueType1 you get the expected code, all checks are eliminated. But for T = ReferenceType2 the first check isn't eliminated even though it seems like it should be because the instantiation that's used for reference type can't also be used for any value types.

I think we were saying same thing?

Maybe, it's clear with examples :smile:


Change o to <leader>o

Fixed in https://github.com/kdheepak/panvimdoc/commit/6810dafc9b8af291974e882864b8d4420679490e


media station link broken

https://100r.co/site/the_media_station.html not working

Where was this page linked from?

Found it thanks :)


CharacterBody2D template inconsistency for GDScript vs. C#

Godot version
4.0.2.stable.mono.official
System information
Ubuntu 23.04, Intel Core i9-9880H × 16, NVIDIA Quadro T2000
Issue description
I found an inconsistency in templates for CharacterBody2D. Differences were found between the files basic_movement.gd and basic_movement.cs. In case of gdscript template the calculation for direction is made by function GetAxis
var direction = Input.get_axis("ui_left", "ui_right")
unlike in case of csharp template, where the calculation is made by function GetVector
var direction = Input.GetVector("ui_left", "ui_right", "ui_up", "ui_down");
GetVector takes in count two axes instead of one and therefor calculated movement speed is different than in case of GetAxis.
In my opinion - implementation in the C# script is the correct one.
Steps to reproduce

Create CharacterBody2D with default templates for both gdscript and csharp
(optional) change in code input key for jump from ui_accept to 'ui_up'
Test both scripts and see how horizontal movement is affected when vertical axis is included

Minimal reproduction project
PixelDemo.zip

Does vertical movement make sense in 2D when you have gravity and no support for ladders?


Add Tests for Fish commands

eg FishAdd, FishDelete

Fish add ... lfd/01/01/0000 .. threw an uncaught exception:
java.time.format.DateTimeParseException: Text '01/01/0000' could not be parsed


Unable to set empty or blank values in metadata.

The meta-data set command is documented to

Set arbitrary data on a build using a basic key/value store.

A limit of 100 kilobytes and a recommendation of less than 1kb for value size are documented elsewhere.
However, I have been unable to set values of "", " ", "\t", or "\n\n\n" using this command. Attempts to run commands like
buildkite-agent meta-data set cluster-config-names ' '

result in errors like
2023-05-03 08:52:19 WARN   POST https://agent.buildkite.com/v3/jobs/0187e0ce-81e6-4c53-af13-2b5eecff6ed2/data/set: 400 Value is missing (Attempt 1/10 Retrying in 5s)

no errors are produced when using a similar command to set a non-blank value.
Ideally, I'd like to be able to set arbitrary (but small) values in metadata. Failing that, I'd like to know what the limits are on the contents of metadata values.

hi @plobsing! as you've discovered, we only allow non-whitespace strings to be set as metadata. this is a restriction that's imposed serverside.
under the hood on the serverside, we use Rails' Object#blank? method to check for value presence, which will fail if the given string is either empty, or composed of only whitespace characters.
i'll add some docs to the agent on this, and possibly add a nicer agent-side error.
if you're looking for a blank-ish thing to cram into meta-data, might i suggest the string "null"?

Hey, thanks for confirming the behaviour. The doc and error message fixups look great; it certainly would have saved me some time if I'd know this was intentional.
Unfortunately, "null" will not work well for my purposes; the readers of this metadata are interpreting it as the output of a select-multiple block step, which is being replaced with a programmatic selection. These readers use Python's str.split to interpret the content as a list, that function will produce an empty list (the desired effect in this case) when its input is empty or all blanks, but "null" will produce ['null']. If I have to update all the readers up-front anyways (e.g. to give them special handling for "null"), I think I'd probably better off switching the entire system to something more general purpose - either propagating info as artifacts rather than metadata (even though it is small), or wrapping everything in JSON, or both.


feat: add isFixed method

Added an isFixed (aliased as fixed, as well) method to the gulp-eslint instance.
Code from #122
Tests pass, although I did have to install estraverse-fb to get some of tests to pass, so I've added that as an optional dependency.

-1. Just what the current example does is enough. https://github.com/adametry/gulp-eslint/blob/412098fe32dda7e4adf34c360ec3744e9ddcad25/example/fix.js#L9-L12

Why would you not want to include something (simple) that simplifies a process? It's a few lines of code that saves (everyone) from writing a few lines of code.

-1. Just what the current example does is enough. https://github.com/adametry/gulp-eslint/blob/412098fe32dda7e4adf34c360ec3744e9ddcad25/example/fix.js#L9-L12

+1 why duplicate this function across every repo that uses eslint. this would have saved me some typing just now (&multiple other times I have setup eslint). plus if anything changes, the change only needs to be in one place.

All the other methods of this plugin have enough reason to exist, in particular returning streams or vinyl-based, but isFixed is doesn't.
Read [the plugin guidelines](Your plugin should not do something that can be done easily with an existing node module):

Your plugin should not do something that can be done easily with an existing node module

isFixed method does just what the guideline forbids. Instead you can create a separate npm module like is-gulp-eslint-fixed and require it at the top of your gulpfile.

done - https://github.com/lukeapage/gulp-eslint-if-fixed
@shinnn would you accept a PR to use this in the example?

The example is as much a demonstration of the fixed property. So, I think it's important to show that method. However, I would like to link to your repo from the "Gulp-Eslint Extensions" section of the ReadMe.


fix: strip path in release tar

Issue #, if available:
Fixes: #1007 #1010
Update the create tar release from
tar -czvf "$RELEASE_DIR"/"$dynamic_binary_name" "$OUT_DIR"

to
tar -czvf "$RELEASE_DIR"/"$dynamic_binary_name" -C "$OUT_DIR" .

after the change, when I tried to do make RELEASE_TAG=v0.4.1 release, I will get the following

Description of changes:
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can we squash the commits?

Can we squash the commits?

squashed.

Thanks, will merge now. And thanks for the fix, it's much appreciated!


Make sure update operations are covered

Ops which trigger cdms sync:

obj.save()

Currently not implemented:

Clazz.objects.filter(...).update()
Clazz.objects.select_for_update()

Skipping cdms sync supported with:

obj.save(skip_cdms=True)
Clazz.objects.skip_cdms().filter(...).update()
Clazz.objects.skip_cdms().select_for_update()

Clazz.objects.filter(...).update() not supported as in case of multiple
cdms update, we can't undo those changes that already happened if an
error occurs.

@danielquinn code review?


SAK-29916 - change startup message from warn to error

The ICLA is on file. Thank you!

Thanks Neal - I will merge this.  Perhaps this might be something to talk about with the Duke class.


Fix - Update stores to use library_pools type when getting libraries via pools

Required due to changes in the service around LibraryResource and LibraryPoolResource
Changes proposed in this pull request

Update stores to use library_pools type when getting libraries via pools

Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Yep. Sharing data fixtures across cypress and vitest would also be a nice refactor.


chore: fix slice_regex name in Nargo.toml

Description
Problem
CI is failing for all PRs.
Summary
Additional Context
I wonder if we should have a CI script to check these? It's also strange that they go through CI.
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Nevermind, I pushed a similar fix in https://github.com/noir-lang/noir/pull/5607 which was already approved and is in the merge queue already.


Remove refresh method from status call

Summary
fixes #575
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.0001%) to 50.211%

Files with Coverage Reduction
New Missed Lines
%

qiskit_ibm_provider/job/ibm_circuit_job.py
1
48.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.0001%

Covered Lines:
2973

Relevant Lines:
5921

💛  - Coveralls


Add build checks

Summary
MSBuild introduced the "build check" capability: https://github.com/dotnet/msbuild/blob/main/documentation/specs/BuildCheck/BuildCheck.md and we could benefit from it to help our users.
Background and Motivation
Some properties are only available starting from a specific version of MSTest, only available when using MSTest.Sdk or only when the runner are enabled and by MSBuild nature user could set the properties and they would be ignored.
Proposed Feature
Let's use this feature to provide some strong typing, static build analysis.
Alternative Designs
None.

I haven't looked into the doc or capabilities of BuildCheck, but one thing we could consider is https://github.com/microsoft/testfx/issues/4192