skip workflow run on forks

Signed-off-by: Suryashankar Das<EMAIL_ADDRESS>Description
This PR fixes some of the files for issue #3429
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #3432 (9e8acae) into master (8f76091) will decrease coverage by 1.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3432      +/-   ##
==========================================
- Coverage   12.30%   10.62%   -1.68%
==========================================
  Files          37       37
  Lines        3162     3162
==========================================
- Hits          389      336      -53
- Misses       2690     2759      +69
+ Partials       83       67      -16

Flag
Coverage Δ

gointegrationtests
?

unittests
10.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/check.go
1.58% <0.00%> (-21.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f76091...9e8acae. Read the comment docs.

I did not know that secrets.GO_VERSION was just a config value which could be configured in the forks too. I was just going through all the files with secrets.<variable> in them. So I'll not do anything to those jobs with only secrets.<language>_version in them. So am I correct to assume that the other secrets will not be configurable/present in the forks?

I did not know that secrets.GO_VERSION was just a config value which could be configured in the forks too. I was just going through all the files with secrets.<variable> in them. I'll not do anything to those jobs with only secrets.<language>_version in them. So am I correct to assume that the other secrets will not be configurable/present in the forks?

Good points - it took me a while to figure that out. When you fork a repo, neither secret definitions (like GO_VERSION) nor their values (like 1.15) are propagated. But you're free to create and set their value. Also user names, passwords, tokens if you have access to the target, and/or the target can be configured to one where you have access. It often make sense not to deploy artifacts from forks, though.
So I think as a rule of thumb jobs that require tokens etc probably in general do not make sense to run in forks.
And tests, static code analysis etc  should run also in forks.

Now the PR is only skipping jobs when they are using some token like GLOBAL_TOKEN or GH_ACCESS_TOKEN and is not skipping any tests. This should be ready for review now.

Actually this issue is being done by two people as both of us had started working on it. After a discussion on slack it was decided to divide the work. So this PR only partially fixes the issue and the build-and-release-edge part should be resolved in the other PR.

@mgfeller Thanks for taking a look into this. Here is the other PR: https://github.com/meshery/meshery/pull/3431

@ramrodo would you like to have a look here too?

Actually this issue is being done by two people as both of us had started working on it. After a discussion on slack it was decided to divide the work. So this PR only partially fixes the issue and the build-and-release-edge part should be resolved in the other PR.

It seems like the other PR got merged with changes to only a single file and i believe two other files/jobs are still left:

.github/workflows/slack.yml
.github/workflows/release-drafter.yml

Should I add the changes for these files in this PR or should I make a separate PR?

Actually this issue is being done by two people as both of us had started working on it. After a discussion on slack it was decided to divide the work. So this PR only partially fixes the issue and the build-and-release-edge part should be resolved in the other PR.

It seems like the other PR got merged with changes to only a single file and i believe two other files/jobs are still left:
* `.github/workflows/slack.yml`

* `.github/workflows/release-drafter.yml`

Should I add the changes for these files in this PR or should I make a separate PR?

@iamsdas I think it's ok to add them here, as they address the same issue, and there is one fewer PR to review, but it's up to you two of course.

Made the changes

I think we need to build the Preview site also in Forks (those PRs that will be merged to meshery master), don't we?

I may be wrong, but aren't the PRs considered a part of the main repo and not the fork?

They are considered a part of the main repo but also, part of the fork. This is useful for us to see the changes in the Netlify site before merging the PR to master. Or let me know if this change you're suggesting considers this case also?

@ramrodo, The Netlify preview should work when creating pull requests to the main repo. The changes I have made should prevent creating a preview for pull requests to the forked repos as the forked repos do not the have the required secret tokens and end up failing as said in the original issue.

Ok, sounds good. Sorry for the misunderstanding. We can merge this and see what happens then and to know if we need to update something. Thanks for the contribution :)


Variable branch in serverbot.sh

During development it's handy when serverbot can gather resources from other branches than the master branch. Now I edit it by hand when I want to test the complete flow, but this would be easier with a variable. It may make it easier in the future to use channels (i.e. stable, testing) as well.

Fixed in https://github.com/nozel-org/serverbot/commit/11a33a3eefddea8a3f7d727a0c6cbba02437c24a.


fix: use of depreciated DynamoDB property "serverSideEncryption"

Updated the code to use the newer "encryption: TableEncryption.AWS_MANAGED" instead of depreciated "serverSideEncryption: true".

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hey @mrglover same as the other issue, if you could have a semantic commit message that would be great 😄


Update log metric filter checks to latest AWS CIS Foundations Benchmarks

Update log metric filter checks to latest AWS CIS Foundations Benchmark and provide hints on how to remediate.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toniblyx I've opened a new PR


unused allocation in from_base_le

https://github.com/recmo/uint/blob/192e5f5d5ec792383ec298fcae60a8d957edfb65/src/base_convert.rs#L67-L73
Unsure if the iterator was supposed to be reversed before collecting, but as it is right now the allocation is completely useless.

Closing as fixed in #255

Only part is fixed, the method still allocates when it could be avoided


removing moz-appearance command which is replaced by webkit-appearance

Just removing moz-appearance statements to webkit-appearance. Since moz-appearance isnt in use

-moz-appearance used by Firefox see :  http://caniuse.com/#feat=css-appearance

Ref: #22002

Closing in favor of #22039.


Set theme jekyll-theme-minimal

@ProfessorCoal I'm assuming this was unintentional? Please shout if not :)


Minor doc changes

List of changes:

fix typos
disable warnings on readme on doc references
remove $ from shell code block when click and copy

Thank you!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Check the render method of App. See https://reactjs.org/link/warning-keys for more information.

I'm trying to get list of employees from SQL server using .net core 6.0 controller and i see that call is made and data is fetched.
but, while displaying i am getting the above error and no data is displayed / rendered.
please help.
Error:
**react_devtools_backend_compact.js:2367 Warning: Each child in a list should have a unique "key" prop.
Check the render method of App. See https://reactjs.org/link/warning-keys for more information.
at tr
at App (http://localhost:44407/static/js/bundle.js:31:84)**
App.js
import { useEffect, useState } from "react";

const App = () => {

    //1 create useState
    const [employees, setEmployees] = useState([]);

    //2 call api
    useEffect(() => {
        fetch("api/employee/GetEmployees")
            .then(response => { return response.json() })
            .then(responseJson => {
                setEmployees(responseJson)
            })
    }, [])

    //3 create div and table
    return (

Employees

                                EmployeeID
                                Employee Name
                                Type
                                Email Address

                            {
                                employees.map((item) => (

                                        {item.EmployeeID}
                                        {item.FirstName}
                                        {item.Type}
                                        {item.EmailAddress}

                                ))
                            }

        )
}

export default App;

index.js
import 'bootstrap/dist/css/bootstrap.css';
import React from 'react';
import { createRoot } from 'react-dom/client';
//import ReactDOM from 'react-dom/client';
import App from './App';

const root =  createRoot(document.getElementById("root"));

root.render(

    <App/>

)

Your question is unrelated to this project. You can find the answer to your question by following the link in the error you posted: "See reactjs.org/link/warning-keys for more information." I recommend reaching out to the appropriate channel or forum for help with your query.


Inconsistent Behaviour of duk_is_primitive

Hello,
I'm the author of Crystal bindings to Duktape over at duktape.cr.
As I was writing (basic) test cases for the public api, I noticed that duk_is_primitive does not behave as advertised in the api documentation when the index is invalid. The documentation states that the call should return 0 on an invalid index.
Currently, it appears that duk_is_primitive returns 1 on an invalid index. You can see my test case here.
I don't think this is a major issue, but I just wanted to report the inconsistency.
Thanks for making Duktape!

Seems like a clear bug - I'll fix it for 1.3.0, should be easy to fix.
Thanks for reporting! :-)

Ok, the fix is now in master and is going into Duktape 1.3.0 release.
I also extended the testcase for duk_is_xxx() calls to cover each for an invalid index. This didn't reveal any similar bugs.

I'll add this to a 1.2.5 maintenance release too.

Thanks for getting to this so quickly! Awesome!


Add monitoring manager

This is the first item of https://github.com/ManageIQ/manageiq-providers-kubernetes/issues/39

@simon3z @blomquisg @Ladas please take a look

@miq-bot assign @blomquisg
looks good in overall, just need the specs fixed

Thanks @Ladas I'll probably have a few more changes to this PR once I finish the event collection that uses the new managers.

@Ladas @cben I think this is ready can you please review this?

@Ladas @cben @simon3z please review

@Ladas @simon3z please review

@Ladas @simon3z @cben please review

This is is now slightly confusing to read by itself — it's unclear where monitoring_manager is defined.

added a comment

There is a test failure[1] that does not seem related, restarting...
[1] ./spec/models/miq_report_spec.rb:151

@simon3z please take a look

LGTM :+1: cc @blomquisg

I'm seeing spec/models/miq_report_spec.rb:151 failing on master locally.

I should probably change ensure_manager to ensure_X_manager.

Done


Add Humairah-Mujawar's file

created a branch, created a file and made a commit, and opened a pull request

pull request merged


add gitops information for acm

Related Issue: stolostron/backlog#<ISSUE_NUMBER>
Resolves: https://issues.redhat.com/browse/ACM-4748
Description of Changes:
Add openshift-gitops information
What resource is being added: | N/A
gitopscluster
argocd
applicationsets
managedclustersetbinding
managedclusterset
Is this a Hub or Managed cluster change?:
Hub Cluster | Managed Cluster | N/A
Hub Cluster
Notes:

@mikeshng could be a good one for you to review?

/lgtm

@jlpadilla could you please approve this PR? Thanks.


Print per evaluator run summary at the end of Evaluate API call

Description
In a batch run, Promptflow generates detailed logs for each evaluator in some temporary folder. These logs are essential for troubleshooting why specific rows may have failed. However, when multiple evaluators are run in parallel, the log file paths printed in the console can get mixed up, making it difficult for customers to locate the correct links.
To address this, the proposal is to print a run summary at the end of the evaluate API call. Below is one example:

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/check-enforcer override

/check-enforcer override


magento2:generate:class-child should resolve types on constructor or pull in use statements

<?php
namespace Pulsestorm\Helloworld\Block;

class Template extends \Magento\Framework\View\Element\Template
{
    function __construct(Template\Context $context, array $data = [])
    {
        parent::__construct($context,$data);
    }
}

See Template\Context?  That's not going to work in this class unless a fully qualified name is used, or we pull in the same use statements as the parent constructor.


Fix build system

Description
Fix build system of project.
Tasks

[x] Setup .gitignore file
[x] Remove auxiliary files.
[x] Make Visual Studio automatically restore Nuget packages.

Will not remove "app.config". Now, this is really weird. The "app.config" file does not do anything except detail what framework our application should be using to the SimConnect SDK. So it is needed for the purposes of telling SimConnect "hey the project is using .NET 48 framework". Really weird.
We will keep "app.config" although it could technically be removed by moving its contents in to the ".csproj" file. But I am currently done wanting to fidget around with Visual Studio build system stuff. The build currently works on my end, so I will merge this pull request so we can present it for tomorrows sprint review.


validate type/child_type use on parent fields

Often, API authors will annotate a parent field with a type reference to the resource that is actually the child_type. Using either type or child_type references is allowed for a parent field, but they would have different values. If possible, such references on parent fields should be linted to verify that either the type is not the child resource OR child_type is the resource that it should be `i.e. in ListBooksRequest, the child resource is Books as indicated by the message name and as the only repeated message (that is annotated with a google.api.resource) in the response).

@apasel422 @shwoodard WDYT?
An example:
message ListBooksRequest {
  string parent = 1 [(google.api.resource_reference).type = "library.googleapis.com/Book"];
}

The above is a bad reference, because it uses a direct type reference for a parent field to the Resource that is actually the child. This should be either be child_type = "library.googleapis.com/Book" (preferred), or type = "library.googleapis.com/Shelf" (acceptable, but if Book gets another parent resource i.e. Publisher, the reference will need to be updated the child_type flavor).
This can be linted for Create via  the response message type (because CreateBook returns a Book, which contains the google.api.resource annotation for comparison) and for List via the repeated resource message in the response message being annotated with the google.api.resource message.

Changing type and priority as I am seeing this more and more internally (and that's just in my own reviews). We should fix this asap.


some questions about the result

Hi,
Thanks for your great work. #Sorry to bother you. I noticed some differences between the repo and the paper.
In repo:

In paper:

Maybe I overlooked something else, but i really can not understand the reasons. Could you please explain this？

Mainly because there was an bug when writing the paper, but some time later, it was fixed.

Thank you for your reply. I understand it. Thanks!


Regarding Error tags & Error Properties column in unindexeditems.csv file

Testing shows that the Error tags & Error Properties column is always blanks and doesn't show the error why these items could not be indexed.
Yes, Using the PowerShell script PartiallyIndexedItems.ps1, it possible to find these items.
Information in the docs states "When you export eDiscovery search results or a search report using one of these options, the export includes a report named Unindexed Items.csv. This report includes most of the same information as the ResultsLog.csv file; however, the Unindexed Items.csv file also includes two fields related to partially indexed items: Error Tags and Error Properties" , which I feel needs to be corrected.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6580cdcf-280e-215c-f4a0-d778b501946f
Version Independent ID: 3f88be2e-6413-c8e7-f234-f62a74075a2d
Content: Investigating partially indexed items in eDiscovery - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/investigating-partially-indexed-items-in-ediscovery.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@vikassou Thanks for your feedback! New issues and pull requests for this content are closed while we update this content to support upcoming feature improvements.


Support multi-resource yaml specs

Feature request:
cli currently doesn't support multi-resource yaml files, temporary using https://github.com/mogensen/kubernetes-split-yaml
Example yaml file:
https://github.com/istio/istio/blob/master/manifests/charts/base/crds/crd-all.gen.yaml

it does support, closing: crd2pulumi --nodejsPath=src/ crds/crd-all.gen.yaml crds/crd-operator.yaml


Add "Forum: WIP Mods ↗" on header.html

IMO it should be left as-is.  There's also a WIP category for Subgames but these aren't really recommended as content in that category is experimental, has licensing issues, or has other reasons to not be suitable for the main categories.


Make footer sticky.

Technique from https://developer.mozilla.org/en-US/docs/Web/CSS/Layout_cookbook/Sticky_footers
Before:

After:

Even though only the 404 page is affected at present, since it is the only short page, I moved the footer on the landing page and on the caselaw page, so that on every page, it is a sibling of main instead of a child of main, so that this CSS would work properly there, had they been shorter. (The footer was already a sibling of main on the gallery and about pages).
With this change, an empty page,
	<body>
		<cap-nav></cap-nav>
		<main id="main"></main>
		<cap-footer></cap-footer>
	</body>

looks like

instead of

Assigning to @tinykite because I'm way out of my element! (HTML pun intended)

@mdellabitta Yeah, CSS grid is pretty great! Observe that this literally only took one line: grid-template-rows: auto 1fr auto;!

This is great! My only suggestion would be the move the global root selector classes you wrote (for body and html) to global.css


cant not install with centos7

OS : CentOS7.9
install steps:

install postgresql
install irods and irods data base plugin with commands from (https://irods.org/download/)
setup with the python file in beginner_training_2019
install storage tiering plugin with command "yum install -y irods-rule-engine-plugin-tiered-storage"
then I just got the output below:
Error: Package: irods_rule_engine_plugin-data_movement-2.6.0-1.x86_64 (renci-irods)
Requires: irods-server = 4.2.6
Installed: irods-server-4.2.8-1.x86_64 (@renci-irods)
irods-server = 4.2.8-1
Available: irods-server-4.2.0-1.x86_64 (renci-irods)
irods-server = 4.2.0-1
Available: irods-server-4.2.1-1.x86_64 (renci-irods)
irods-server = 4.2.1-1
Available: irods-server-4.2.2-1.x86_64 (renci-irods)
irods-server = 4.2.2-1
Available: irods-server-4.2.3-1.x86_64 (renci-irods)
irods-server = 4.2.3-1
Available: irods-server-4.2.4-1.x86_64 (renci-irods)
irods-server = 4.2.4-1
Available: irods-server-4.2.5-1.x86_64 (renci-irods)
irods-server = 4.2.5-1
Available: irods-server-4.2.6-1.x86_64 (renci-irods)
irods-server = 4.2.6-1
Available: irods-server-4.2.7-1.x86_64 (renci-irods)
irods-server = 4.2.7-1
Error: Package: irods_rule_engine_plugin-data_movement-2.6.0-1.x86_64 (renci-irods)
Requires: irods-runtime = 4.2.6
Installed: irods-runtime-4.2.8-1.x86_64 (@renci-irods)
irods-runtime = 4.2.8-1
Available: irods-runtime-4.2.0-1.x86_64 (renci-irods)
irods-runtime = 4.2.0-1
Available: irods-runtime-4.2.1-1.x86_64 (renci-irods)
irods-runtime = 4.2.1-1
Available: irods-runtime-4.2.2-1.x86_64 (renci-irods)
irods-runtime = 4.2.2-1
Available: irods-runtime-4.2.3-1.x86_64 (renci-irods)
irods-runtime = 4.2.3-1
Available: irods-runtime-4.2.4-1.x86_64 (renci-irods)
irods-runtime = 4.2.4-1
Available: irods-runtime-4.2.5-1.x86_64 (renci-irods)
irods-runtime = 4.2.5-1
Available: irods-runtime-4.2.6-1.x86_64 (renci-irods)
irods-runtime = 4.2.6-1
Available: irods-runtime-4.2.7-1.x86_64 (renci-irods)
irods-runtime = 4.2.7-1

is that just a temporary error or I did something wrong above.
Thank you

sorry, I figure out my mistake
thank you

sorry, I figure out my mistake
thank you


Reproduce Passage MS MARCO Passage Ranking

Environment

MacBook Pro M1 Chip, 16GB RAM, Monterey 12.3.1
Apache Maven 3.9.1, Java version: 20.0.1
Started cloning repo in London, ran first build and replicated experiments in China
Had really slow download speed for pretty much all resources (recurring theme lol)

Comments

Ran smoothly, instructions were easy to follow.

Codecov Report
Patch and project coverage have no change.

Comparison is base (44dc9db) 58.93% compared to head (eca6d1c) 58.93%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2110   +/-   ##
=========================================
  Coverage     58.93%   58.93%
  Complexity     1188     1188
=========================================
  Files           194      194
  Lines         11328    11328
  Branches       1486     1486
=========================================
  Hits           6676     6676
  Misses         4170     4170
  Partials        482      482

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add French translations

Here is the French translation of Writer :smile:
You can notify me when you want me to update them.
Note: Some strings in Spreadsheet are not so good. I think a little of rework is necessary. Some strings where hard to translate because their context was not clear.
This PR is ready for review

Hmm yes I understand. I'll do that. However you will have to merge this PR first (French translation) ans then Fix Misspelling because the second one impacts the first one 😉

OK, I'm going to merge this PR first.
@BaptisteGelez I'm sorry to bother you, but would you review this PR?

@NathanBnm Would you do git pull to fetch the latest changes from remote to your local and update/review your translation files, since we changed some original string in #67 and #68?

@NathanBnm Would you do git pull to fetch the latest changes from remote to your local and update/review your translation files, since we changed some original string in #67 and #68?

Sure I'll do that

Should be okay now :+1:

@BaptisteGelez Thank you for reviewing!!


Rename options.options

We have the choice between:

user column
Custom column

Custom column has been selected


Laravel 8.83.12 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v8.83.12 branch.
Before merging, you need to:

Checkout the shift-ci-v8.83.12 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:warning: The Shift build servers run PHP 8. If you are still running PHP 7.4 or lower you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP 7 environment.

:information_source: Shift detected your application only has the default tests. You may quickly start adding tests by using the Test Generator to automatically create the model factories, test classes, and sample tests cases for your Laravel application.

Rebased, fixed a few composer issues, and added some build assets in public/js and public/css to the ignore list.
I also updated the Forge deploy script to use our recommended steps for Tighten projects, which now builds the assets on the server instead of relying on locally-built assets being committed.


Add new MetroHeaderControl control

The MetroHeaderControl can contains any other content and can display a header on top of this content.
So you can do something like this:
with HeaderTemplate
<Controls:MetroHeaderControl Margin="2" Header="TextBox Header">
    <Controls:MetroHeaderControl.HeaderTemplate>
        <DataTemplate>
            <StackPanel VerticalAlignment="Center" Orientation="Horizontal">
                <iconPacks:PackIconMaterial VerticalAlignment="Center" Kind="FaceProfile" />
                <TextBlock Margin="2 0 0 0"
                           VerticalAlignment="Center"
                           Text="{Binding}" />
            </StackPanel>
        </DataTemplate>
    </Controls:MetroHeaderControl.HeaderTemplate>
    <TextBox Text="Enabled" />
</Controls:MetroHeaderControl>

or

This PR (control) is ispired by #1825 Header, headers, headers
Closes #1825

/cc @thoemmi

heavy breathing

@thoemmi You are the naming specialist ;-)
MetroHeaderControl or MetroHeader ?
What do you think?

@punker76 I'm not @thoemmi , but to me, since items like Badged don't have "control" in the name, this shouldn't either for consistency

@punker76, looking through the controls that have already been designed / implemented, there seems to be a blend of those containing "Control" in the name (example: MetroAnimatedTabControl) and those that do not (example: DateTimePicker)  Perhaps, related to #2384, this might be a good time to nail down whether or not "Control" should be included throughout the library.  My vote is no, simply because Microsoft doesn't follow that convention - they named it a TextBox, not a TextBoxControl.  In my opinion, we should follow their naming template for consistency.
Obviously, my input doesn't amount to much at the end of the day - it's totally up to you and @thoemmi! :smile:

Agree with @amkuchta, besides, it´s the namespace that tells that an certain component is an control.
MetroAnimatedTabControl is inside the namespace MahApps.Metro.Controls giving the full qualified name MahApps.Metro.Controls.MetroAnimatedTabControl, which is pretty redundant.
Just MahApps.Metro.Controls.MetroAnimatedTab would be all right.

@MurariAlex I ended up changing my example... Microsoft calls it a TabControl as well :laughing:

@MurariAlex @amkuchta MetroAnimatedTabControl is a TabControl, so it should named xyzTabControl.

@MurariAlex @amkuchta The FlyoutsControl controls the Flyouts, so it should names xyzControl.
@thoemmi I'll update the name from MetroHeaderControl to MetroHeader. It's derived from GroupBox, so we should give it also a name without the Control suffix.

@punker76 the FlyoutControl makes sense. I just think that even Microsoft has it wrong - it should be something like TabController or FlyoutController.
But we aren't here to discuss/fix that particular thought :smile:

Thanks for this entertaining discussion :lol:
First I wanted to suggest to derive from GroupBox instead of HeaderedContentControl, but you already changed that 😉 And I agree on naming it MetroHeader, without Control. It's like GroupBox, TextBox, you name it.
:shipit:

@thoemmi

@punker76, any plans to create another pre-release so we can try out the headers?

@amkuchta You can eat the always the latest nuget pre-release from this appveyor feed: https://ci.appveyor.com/nuget/mahapps.metro without any guaranty...


pdblp BDH Overrides with CDR

Hello! i am looking to try and do this with pdblp. In Excel, =bdh(ticker,field,start,end, "CDR =   #A&#L") but im not sure what the equivalent should be for pdblp....
pdblp.bdh("SPX Index", "PX LAST", 20190101,2020101,elms = [("calendarCodeOverride","#A")])
So the above line works for just 1 override but if I want the Union of another code, thats where i'm sure how to do it, just like the one in Excel, return historical price with all trading days in exch code #A&#L
Thanks for any help given in adv!

https://data.bloomberglp.com/labs/sites/2/2013/12/blpapi-developers-guide-1.38.pdf
seems like page 164 of pdf (166 actual guide) sheds some light...is there a way to incorporate this into the pdblp module? Or how to write the correct syntax if I want the same trading days for my example, say SPX Index on both US and EN trading days?
Thanks a lot!

I am unsure how the Excel backend works, but have been informed previously that the backend service for the python API and the Excel API are different. pdblp is just a wrapper around the Bloomberg libary blpapi, so any overrides supported through blpapi should be possible in pdblp. As you wrote in your example above, these can be passed to bdh either via elms or ovrds parameters. I would confirm with Bloomberg or possibly on StackOverflow with tag blpapi on how to structure the right blpapi request.

I am unsure how the Excel backend works, but have been informed previously that the backend service for the python API and the Excel API are different. pdblp is just a wrapper around the Bloomberg libary blpapi, so any overrides supported through blpapi should be possible in pdblp. As you wrote in your example above, these can be passed to bdh either via elms or ovrds parameters. I would confirm with Bloomberg or possibly on StackOverflow with tag blpapi on how to structure the right blpapi request.

Understood thanks! will keep at it and see if I can come to a solution


[Communication Identity] Smoke tests failing

The samples for each package is used in our smoke tests, and some from the Communication Identity package have been failing since #13819 got merged
2021-02-18T20:41:57.0892703Z =========================================
2021-02-18T20:41:57.0893746Z SMOKE TEST FAILURES
2021-02-18T20:41:57.0894851Z Exception: TypeError: client.issueToken is not a function
2021-02-18T20:41:57.0902208Z ##[error]Test Failed - Package: communication-identity - Sample File:issueToken.js
2021-02-18T20:41:57.0904808Z {
2021-02-18T20:41:57.0905728Z   sample: {
2021-02-18T20:41:57.0907094Z     entrypoint: [AsyncFunction: main],
2021-02-18T20:41:57.0908548Z     name: 'communication-identity',
2021-02-18T20:41:57.0909823Z     sampleFile: 'issueToken.js',
2021-02-18T20:41:57.0911384Z     directory: '/home/vsts/work/1/s/sdk/communication/communication-identity/dist-samples/javascript'
2021-02-18T20:41:57.0912603Z   },
2021-02-18T20:41:57.0913518Z   result: {
2021-02-18T20:41:57.0914703Z     success: false,
2021-02-18T20:41:57.0915858Z     exception: TypeError: client.issueToken is not a function
2021-02-18T20:41:57.0917657Z         at Object.main [as entrypoint] (/home/vsts/work/1/s/sdk/communication/communication-identity/dist-samples/javascript/issueToken.js:34:34)
2021-02-18T20:41:57.0919382Z         at processTicksAndRejections (internal/process/task_queues.js:93:5)
2021-02-18T20:41:57.0920993Z         at async executeSample (/home/vsts/work/1/s/common/smoke-test/run.js:84:5)
2021-02-18T20:41:57.0922572Z         at async main (/home/vsts/work/1/s/common/smoke-test/run.js:42:18)
2021-02-18T20:41:57.0923707Z   }
2021-02-18T20:41:57.0924579Z }
2021-02-18T20:41:57.0925605Z Exception: TypeError: client.issueToken is not a function
2021-02-18T20:41:57.0926658Z {
2021-02-18T20:41:57.0927523Z   sample: {
2021-02-18T20:41:57.0928556Z     entrypoint: [AsyncFunction: main],
2021-02-18T20:41:57.0929821Z     name: 'communication-identity',
2021-02-18T20:41:57.0931261Z     sampleFile: 'revokeTokens.js',
2021-02-18T20:41:57.0932845Z     directory: '/home/vsts/work/1/s/sdk/communication/communication-identity/dist-samples/javascript'
2021-02-18T20:41:57.0934177Z   },
2021-02-18T20:41:57.0935095Z   result: {
2021-02-18T20:41:57.0936199Z     success: false,
2021-02-18T20:41:57.0937463Z     exception: TypeError: client.issueToken is not a function
2021-02-18T20:41:57.0940617Z         at Object.main [as entrypoint] (/home/vsts/work/1/s/sdk/communication/communication-identity/dist-samples/javascript/revokeTokens.js:35:42)
2021-02-18T20:41:57.0942411Z         at processTicksAndRejections (internal/process/task_queues.js:93:5)
2021-02-18T20:41:57.0944217Z         at async executeSample (/home/vsts/work/1/s/common/smoke-test/run.js:84:5)
2021-02-18T20:41:57.0947203Z         at async main (/home/vsts/work/1/s/common/smoke-test/run.js:42:18)
2021-02-18T20:41:57.0948302Z   }
2021-02-18T20:41:57.0949378Z }
2021-02-18T20:41:57.0950589Z Exc

Looks like in #13819, we only updated the TS samples
The above failures are due to the corresponding JS samples not getting updated.
Created #14058 to fix this


Implement message selectors via unique hashing

Currently we simply generate message IDs of messages generated by pdsl_lang via a simple counter increment. While this is very compute friendly and very easy to implement it has several downsides. First, the ID of a message is depending on its order in which it appears in a smart contract definition. This is super bad since this is effectively disables smart contract refactoring even on a syntactic level.
What we want from a message ID is the following:

It must be unique across all messages for all states.
It must be independent of the internal implementation and its order in the source file.
It must be dependent on the messages signature so that the external environment (and remote smart contracts) can safely rely on that for calling it.

For this we want to implement a hashing scheme.
The hashing function is not required to be cryptographically safe.
For creating a unique message ID hash that fulfills the above stated properties we need to take its signature into consideration.
Further research required!

Some lifting of restrictions.
For every contract! invocation there can be only one smart contract state dropping the necessity to make message IDs unique for that.
Also since we do not support function/message overloading like in C++ or Java it is enough to just take the message's name into consideration for creation of the unique message ID.
This simplifies generation of unique message IDs a lot.

Commit https://github.com/Robbepop/pdsl/commit/64051226fd8e9c363db363941a4f0dd3c974dcf6 implements this by just hashing the name of the message. This is sufficient as long as we only have one contract per contract! macro and file and as long as we do not allow message overloading which we won't.


Input caret isn't properly updated for Restricted type

When 'backspace' key and/or range selection are involved in Restricted input, sometime input caret will jump to the end, and sometime it will be locked to the front.

Yeah, its a tricky tricky thing.  You may want to use MaskedInput see the
https://github.com/subschema/subschema-external-component-example for how
to do that.
On Thu, May 5, 2016 at 7:25 PM Yu Wu<EMAIL_ADDRESS>wrote:

When 'backspace' key and/or range selection are involved in Restricted
input, sometime input caret will jump to the end, and sometime it will be
locked to the front.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/subschema/subschema/issues/38


Unable to do aio app deploy due to SocketException

Describe the bug
While doing aio app deploy, certain machines are throwing SocketException. Verbose logs shared below:
It's happening always, used to work earlier. But now getting this error despite system restarts while it works fine on some machines for same codebase.
Verbose Logs for aio app deploy
$ aio app deploy --verbose

Building actions
√ Building actions
Building web assets
i bundling C:\Symphony\Code\adobe-content-symphony\web-src/index.html
Building web assets
√ Building web assets
Build success, your app is ready to be deployed 👌
Deploying actions
i Info: Deploying package [ContentAtScale-0.0.1]...
Deploying actions
i Info: package [ContentAtScale-0.0.1] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/aio-lib-state-read]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/aio-lib-state-read] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/workfront-action]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/workfront-action] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/workfront-project-upload-handle]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/workfront-project-upload-handle] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/adobe-stock-search-action]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/adobe-stock-search-action] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/creative-cloud-search]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/creative-cloud-search] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/bookmark-action]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/bookmark-action] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/__secured_aio-lib-state-write]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/__secured_aio-lib-state-write] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/__secured_aem-assets-search]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/__secured_aem-assets-search] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/__secured_aem-projects-action]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/__secured_aem-projects-action] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/__secured_aem-assets-api]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/__secured_aem-assets-api] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/aio-lib-state-write]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/aio-lib-state-write] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/aem-assets-search]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/aem-assets-search] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/aem-projects-action]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/aem-projects-action] has been successfully deployed.
Deploying actions
i Info: Deploying action [ContentAtScale-0.0.1/aem-assets-api]...
Deploying actions
i Info: action [ContentAtScale-0.0.1/aem-assets-api] has been successfully deployed.
Deploying actions
i Success: Deployment completed successfully.
Deploying actions
√ Deploying actions
Deploying web assets
i warning: an existing deployment will be overwritten
Deploying web assets
i deploying index.html
Deploying web assets
i deploying index.2a507c18.css
Deploying web assets
i deploying index.fd6ebe80.css
Deploying web assets
i deploying index.fd6ebe80.css.map
Deploying web assets
i deploying index.2a507c18.css.map
Deploying web assets
i deploying index.8c624348.css
Deploying web assets
i deploying index.8c624348.css.map
Deploying web assets
× Deploying web assets
RequestTimeout: Your socket connection to the server was not read from or
written to within the timeout period. Idle connections will be closed.
Code: RequestTimeout

Hi @shellygoelisobar , thanks for opening the issue.
We'll have a look and come back to you. Expect some delay as we are focusing on the last steps of an important release.

Hi @shelly-goel , we cannot reproduce the issue on our side. Is it still happening for you?

@meryllblanchet  Yes it was consistently happening on one of the dev machine. Now the dev is not there on the team anymore. I would reach out in case we face the same issue again.

Thanks @shelly-goel - it looks like an unfortunate issue on the underlying cloud storage to which the SPA files get deployed from the CLI. I'll close the issue for now, please reopen it as you propose, in case you would face it again.


Metamask sets gas limit to block gas limit

Title/Description
Sometimes, Metamask sets the gas limit to the block gas limit for Safe transactions as well as Safe creations
Environment

Browser: ?
Safe: ?
Wallet: Metamask
App Version: ?
Environment:

production (mainnet)

Steps to reproduce
??
Expected result
Gas limit is properly set
Obtained result
Gas limit is set to 11M
Screenshots

Misc

Metamask sets the gas limit to the block gas limit on estimation failure.
Yes, this seems like a Metamask issue, still it happens regularly.
This ticket is to collect steps to perhaps make this reproducible.

Report:
Create a Spending limit for 10GNO (monthly, recurring) on Chrome, incl. enable module.

Add owner, (approveHash): https://gnosisinc.slack.com/archives/C63LQTGNB/p1606327619373700
Safe creation: https://gnosisinc.slack.com/archives/C63LQTGNB/p1606383472379200?thread_ts=1606383316.378900&cid=C63LQTGNB

I'm putting the on hold label as @pablofullana suggested until we find a way to replicate/implement the fix

Just had a user complain about this issue during a Safe creation, but this user was using the Desktop App with Portis. So it seems this is not even necessarily related to the web app, a specific browser or Metamask.

@Agupane the problem is, we cannot reproduce this 😬
Is there anything else we can do?
Are we setting the gas limit which is then used in the owner wallet (e.g. Metamask)? Or is it Metamask that is doing the estimation and then setting the gas limit?

As fas I investigated we are not setting manually a limit for the transactions, seems that MM (or the wallet) it's doing the estimation automatically, we can set the gasLimit manually, but I'm not sure if that would be expected, can you confirm this?
CC: @rmeissner

If there is a reliable way for us to estimate the transactions, I'm in favor of setting the gasLimit that is being used in the owner wallet (e.g. Metamask) manually. Seems to me like that would be more reliable than what Metamask does. Don't we already do that for e.g. hardware wallets? Or how does it work there?
For technical judgement etc I would follow whatever @rmeissner or @dasanra think here though.

We are not setting any gasLimit, seems that every wallet do his own estimation, same for hardware wallet

Seems to me like that would be more reliable than what Metamask does

Yes there have always been cases where MM messed it up but the recent cases (that triggered this issue) kind of make it required that we start providing an estimate. I am not sure how these estimates are handled by other smart contract wallets. I know that the legacy mobile app just ignored them. In any case it should not harm to provide a gas limit estimate (e.g. eth_estimateGas * 1.2 -> this is what MM does). Also we could do more advanced logic like trying to check at what gas limit execTransaction is successfull (aka returns true)

@Agupane do we also do our own estimation for Safe creation txs? Or is this feature just for "regular" Safe txs?

@Agupane do we also do our own estimation for Safe creation txs? Or is this feature just for "regular" Safe txs?

@Agupane do we also do our own estimation for Safe creation txs? Or is this feature just for "regular" Safe txs?

Not now, I'm working on it, the pr should be ready today

@Agupane do we also do our own estimation for Safe creation txs? Or is this feature just for "regular" Safe txs?

Not now, I'm working on it, the pr should be ready today


Allow switching to Font Awesome

Could you allow the user to specify to use Font Awesome over Glyphicons?

I was not able to use the LESS method from @stramel - I believe from reading the extend docs that it requires the original glyphicon.less file to be present which it is not in my case. However it was easily resolved by adding this anywhere after my Font Awesome imports:
.glyphicon {
  .fa-icon();
}
.glyphicon-chevron-left:before { content: @fa-var-chevron-left; }
.glyphicon-chevron-right:before { content: @fa-var-chevron-right; }
.glyphicon-chevron-up:before { content: @fa-var-chevron-up; }
.glyphicon-chevron-down:before { content: @fa-var-chevron-down; }

:100: for allowing Font Awesome configuration!

:+1:  for font-awesome simple configuration support !

I would much prefer a configuration to a hack. It makes using icons very, very tedious.

Would using the icon-less version of the Bootstrap CSS work? It' is mentioned here.

.glyphicon {
display: inline-block;
font-family: FontAwesome !important;
font-style: normal;
font-weight: normal;
line-height: 1;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
.glyphicon-chevron-left:before {
content: "\f053";
}
.glyphicon-chevron-right:before {
content: "\f054";
}
.glyphicon-chevron-up:before {
content: "\f077";
}
.glyphicon-chevron-up:before {
content: "\f077";
}

still hoping core support for font awesome

@phuyem, most, if not all, of our templates can now be overridden.  If you want font awesome, just switch out the templates.

@phuyem I thnk you can also switch them out like in this post http://stackoverflow.com/questions/26638215/how-to-replace-glyphicons-with-fontawesome-in-bootstrap-3-without-changing-html#26638216

I adapted the less solution for Icomoon, here how it looks like for those who in need:
@import (less, reference) 'icomoon.css';
.glyphicon:extend([class^="icon-"] all) {
  &.glyphicon-chevron-right:extend(.icon-chevron-right all) {};
  &.glyphicon-chevron-left:extend(.icon-chevron-left all) {};
  &.glyphicon-chevron-up:extend(.icon-chevron-up all) {};
  &.glyphicon-chevron-down:extend(.icon-chevron-down all) {};
  &.glyphicon-calendar:extend(.icon-calendar52 all) {};
}

I made this Gist to map all glyphicon icons to font-awesome.
I'd estimate it has around 95% accuracy and coverage (glyphicon has some useless icons that font-awesome doesn't).
https://gist.github.com/blowsie/15f8fe303383e361958bd53ecb7294f9


Incompatible mod set!

Ever since installing the latest version of wynntils (0.0.2-alpha.374), I've been unable to launch Minecraft due to the latest version using 0.14.18 fabric loader. I've launched the mod launcher and there was some form of update button, clicked it, went to updates etc. and nothing seemed to change.
Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
	 - Replace mod 'Fabric Loader' (fabricloader) 0.14.11 with version 0.14.18 or later.
Unmet dependency listing:
	 - Mod 'Wynntils' (wynntils) 0.0.2-alpha.374 requires version 0.14.18 or later of mod 'Fabric Loader' (fabricloader), but only the wrong version is present: 0.14.11!
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Fiixed


Add possibility to configure connection options in MQTT output plugin

Hi,
When connecting to an external MQTT broker, additional information is usually required on top of broker url and port, like credentials for example.
It would be great to be able to pass the "options" object in the MQTT output plugin configuration which would be taken into account by the mqtt.connect function according to the mqtt.js doc:
https://www.npmjs.com/package/mqtt#client

Hi, it makes sense to add all options to the config.
What happens when you add credentials in the URL? e.g.
mqtt://user:password@<IP_ADDRESS>:1883

This could be a workaround until we have a new release.

Changes are made in commit https://github.com/sematext/logagent-js/commit/186930b425ac44505c6eb0a4160498d930932cc4
Please try by installing logagent from git sudo npm install -g https://github.com/sematext/logagent-js.git before we make a new release.

It works great. Thank you very much for the quick fix!


Is there a way to improve coverage (or ignore) autogenerated code of kotlinx.serialization?

So currently if you use serialization all the generated classes got reported as not covered :(

Is there a way to automatically exclude such autogenerated helper classes from coverage?
(Intellij engine is a bit better than JaCoCo but still not perfect)

Relates #121

Thanks for looking into this.
I have a suggestion: if possible don't replicate jacoco feature where they require to add @Generated annotation to the code you want to ignore.
Instead I'd suggest to allow to configure the list of annotations to ignore in build.gradle.
Thanks

maybe this?
    filters {
        classes {
            // ignore autogenerated classes generated by 'kotlinx.serialization'
            excludes += listOf("**.*\$\$serializer")
        }
    }

Since version 0.6.1, it has become possible to ignore classes marked with the specified annotations. You can add an exclusion of the annotation kotlin.serialization.Serializable like this example.


Add Project to AssetLib

If this project works it would be great to have it on the AssetLib so everyone can know it exists and use it.

Hi i moved your issue to the new project - https://github.com/RevoluPowered/one-voip-godot-4/issues/6


Indicate unsaved tabs that are not shown

When you say move a file and imports are updated, you'll get bunch of unsaved files/tabs. It's easy to save them all, but if you don't, it's not immediately obvious there are unsaved files/tabs if the tab bar is overflow.
Come up with a way to indicate in the tab bar that there are unsaved tabs/files out of view.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

A few things you can already do:

Have the Open Editors view visible. Even when collapsed the header will tell you how many unsaved files there are.
Set "workbench.editor.wrapTabs": true so all your tabs remain visible.
Use an extension such as https://marketplace.visualstudio.com/items?itemName=wraith13.unsaved-files-vscode to add a Status Bar panel.

I would like to amend this request; there is already a means to show any unsaved editors, but it would be useful for it to show as some sort of popup when you make a refactoring change that affects multiple files.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


feat: add a Gaussian probability distribution over ℝ

Create a new Distributions folder for particular probability distributions.
Define a Gaussian distribution over ℝ by its pdf

Co-authored-by: Lorenzo Luccioli
From a project started at LftCM 2023.

[ ] depends on: #7544

@eric-wieser most of your comments are about #7544 : I'll mark them resolved here and answer over there.

An alternative parametrization of the Gaussian would be with mean and standard deviation s, with value in the reals rather than the nonnegative reals. Since the pdf depends only on s^2, a negative value would be the same as a positive value.
Drawback: gaussianReal 0 (-1) looks like nonsense (a Gaussian with std dev -1?).
Advantage: if X has law gaussianReal m s, then c*X has law gaussianReal (c*m) (c*s), no matter the sign of c. With the current parametrization with a variance in NNReal, if X has law gaussianReal m v, then c*X has law gaussianReal (c*m) (⟨c^2, sq_nonneg _⟩ * v), which is not as nice. See #7674 .

bors r+


Extra Spaces in CSV header names

I dont know if this space in the CSV headers has a specific purpose but it took a while to figure out there was extra space in the Label while trying to handle data using pandas.
DSE_csv_writer.hpp

Hello @gannaramu,
Yes, you are right. There are some spacing in the current CSV header. There is no specific purpose. You could ignore it.


[Enhancement] Enable generation of synthetic metrics in analytics service

Is your feature request related to a problem? Please describe.
Currently, metrics mock is a tedious process. First, it requires an extra service (metrics-mock), and YAML files for its configuration, and more YAML files for its deployment.
This seems too much work to generate synthetic metrics.
Simplify this by builtin synthetics within the analytics service and by extending the metrics CRD.
Why is the feature useful for Iter8 users?
This will eliminate the need for metrics-mock in A/B testing tutorials. Metrics mock can be substantially simplified, leading to easier tutorial creation and also easier explanations / ways to exercise the tutorial.
Describe the solution you'd like
apiVersion: iter8.tools/v2alpha2
kind: Metric
metadata:
  name: user-engagement
  namespace: iter8-istio
spec:
  mock:
  - name: sample-app-v1 # name is the name of the version
    level: 25.0 # metric value will converge to 25.0 over time for this version
  - name: sample-app-v2
    level: 50.0 # metric value will converge to 50.0 over time for this version

Note: mock is an optional field with a list of versions and their levels; when this field is present, analytics service will ignore other parts of the metrics resource, and generate random values for metrics instead of performing queries to databases.

Note: Gauge is the default type for metrics, including builtin and mock metrics.

Describe alternatives you've considered
Use current metrics-mock. Significantly complicated.
Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
Yes. Please see example above.
How will this feature be tested?

[ ] Unit tested within Iter8-analytics service
[x] Unit tested within etc3
[ ] Integration tested as part of all A/B testing tutorials

How will this feature be documented?

[ ] metrics documentation at Iter8.tools will be extended with this synthetics feature.
[ ] since the idea is combine this issue with #751, documentation needs to reflect this as well.

Looking at this issue when reviewing https://github.com/iter8-tools/etc3/pull/210, a Metric with a defined synthetic field is a bit confusing to look at because it now contains 2 fields: i) to query real systems, and ii) to return synthetic numbers. Using the above example, would it be more clear to say
  type: Synthetic
  provider: Iter8
  params:
  - name: sample-app-v1 # name is the name of the version
    level: 25.0 # metric value will converge to 25.0 over time for this version
  - name: sample-app-v2
    level: 50.0 # metric value will converge to 50.0 over time for this version

and remove some of the other fields that are not relevant. The exact fields might not be what are stated above, but hopefully you get the idea.

I was a bit careless about the optional fields... and am cleaning up the example above in the spirit of what you said.
I want to make the CRD changes non-breaking for this feature... currently, type is an enum that can be counter or gauge; I agree in the future, it can evolve to include builtin and synthetic. Further, URL is currently a required field. I also agree that in the future it can evolve to become  optional (and both of these will be non-breaking changes to the CRD).

It suggests to users that they need to modify the metric for every experiment.

How?
It suggests to users that they can get started with mock metrics, get the rest of their experiment right, and then get to real metrics. In other words, change in metrics happens once,  when going from mock to real.

Other solutions (like the one proposed in the comments above -- to modify an experiment to specify these on an experiment by experiment basis) are more work. But that should not be a reason to dismiss them if they have merit in terms of clarity and use over the current proposed approach.

We don't want to dismiss any suggestion. However, as I described above, the design alternative is more work, breaks important abstractions, and is less clear compared to the proposed approach, all at once.

Putting the mock within objectives as suggested above has the following disadvantages.

Agreed. It is not ideal and may not be the right approach.

Re: migration path, the user does get to retain the same experiment.yaml

Probably true though I expect the referenced metric names will change. I expect users will not modify mocked metrics but replace them with new ones. In any case, in the process of replacing/redefining a metric it may also be necessary to add variables to the versionInfo of an experiment.

there is a clear separation of concern between the following aspects of experimentation...

This is a valid separation that clearly defines the implementation principles behind the analytics engine. However, there is another dimension to separation that exists between that which is general and that which is experiment specific. In particular, we isolate version specific details to the experiment; indeed to the versionInfo section of the experiment spec. Version specific information is accessed via placeholders in actions and in metrics.
Both proposed solutions violate this principle. In one, version specific information (the name of the version) is placed in the Metric resource. In the other in the criteria section of the experiment. I prefer a solution which keeps the metric resource version independent; that just defines where the analytics engine will get its values. I agree with the limitations of the second solution (replication, need for change). However, it has the benefit of keeping information specific to a specific set of versions in a common object.
Perhaps we can find a third approach?
I looked at metrics-mock (which I have never really looked at before; I am not familiar with its implementation so likely forsee  any difficulties in modifying it. As you pointed out originally, it has the disadvantage that is is complicated to create the configuration file.  In part, this is because it requires the simulation of other databases. Could we for example, have a notion of a mock service that allows a very simple version, value kind of specification? A metric might look like:
spec:
params:
  - name: version
    value: $name
jqExpression: “.”
urlTemplate: http://metrics-mock.iter8-system.svc.cluster.local:8080

In terms of migration/development, this allows a user to gradually complicate the Metric specification while continuing to mock if desired (taking advantage of the current capabilities of metrics-mock). Or to replace as needed with a real standard definition.

Both proposed solutions violate this principle. In one, version specific information (the name of the version) is placed in the Metric resource.

I disagree. When you mock metrics for versions, you need some way of specifying how to mock metrics for a specific version. This information needs to go somewhere. The metrics object itself is the obvious and natural place for it to go.
The reason behind the mock field of metric spec is to avoid the need of a third service, the metrics-mock.
@kalantar I wrote the metrics mock. I understand the difficulty in creating it and maintaining it. From the end-user perspective it is downright horrible.
While it allowed for initial mocking in our current A/B testing experiments, it has the disadvantage of complicating tutorials needlessly. It creates extra YAMLs for deployment, and more cognitive load for the user in terms of understanding.
I am glad you're starting to look in the metrics-mock service, but the third proposal does nothing to mitigate the above issues, exactly the type of issues which metrics-mock overcomes easily.

IMO, the primary purpose of this metrics mock feature is learning purposes (learn about experimentation without the complexity of a real database or yet-another service to be configured).
The secondary purpose of this metrics mock is migration. Get started with an experiment without the complexity of a real database or yet another service to be configured.
IMO, the mock field in metrics serves both these purposes well.
I just do not understand  the need to complicate what is essentially a simple feature (I wish I had this understanding at the time of creating metrics-mock service... creating and trying to use that service definitely informed the proposed design).

Summarizing the proposals so far:
Proposal described on top: Introduce a single mock field in metrics CRD. This change is non-breaking and already handled by this etc3 PR. Analytics service needs further changes to produce mock values for metrics.
Proposal number 2: Change objectives, reward, and indicators portion of the experiment CRD. All the reasons why this is not a desirable change is discussed here.
Proposal number 3: Don't change anything. Continue to maintain the metrics-mock service instead. This thread started with the purpose of eliminating the complexity of this additional mock-service, first from the end-user (i.e., the person exercising a tutorial) point of view, second from the tutorial creator point of view, and third from the Iter8 maintainer point of view. The proposed third alternative is actually what is happening today already in our tutorials.

I think we are both concerned with a users learning process as they move from running a sample application on minikube to running their own application in their own cluster. We both want this process to be as straightforward and understandable as possible. I suspect that we have different conceptions of how this happens. It may be useful to try to sketch this out together. Identifying general steps and what needs to be changed. A shared understanding will certainly resolve this.

Fixed.


Error:Failed to load bower.json

Hey thanks for this awesome project,but am running into an error.
Failed to load bower.json
Error: watch ENOSPC
What could be the cause,the bower.json seems to be ok in the project.

Hi! I think this error is caused in gaze process for watching bower.json file.
I found similar situation and its solution here:
gruntjs - Grunt watch error - Waiting...Fatal error: watch ENOSPC - Stack Overflow
Please run the command carefully because it updates your system configuration.
I hope this will help you...


Aop

Convenient way of loading of environment variables defined in .env file
JWT authentication as part of Aspect Oriented Programming functionality

@sergey-moiseyenko this branch should be rebased on ws.layer (PR #6) before review and rebase.

@sergey-moiseyenko this PR is ready for the review. Thx


HHH-9915 - test fail on Oracle (long identifier name)

Oracle DB has max size of table name 30 chars
https://hibernate.atlassian.net/browse/HHH-9915

Thanks @hsvabek ,
rebased & merged into master


Think about benchmarking of linear and unlifted data

For benchmarking of linear functions there are two options. One approach is to make nf and friends multiplicity-polymorphic. This does not require any implementation changes, just tweaking of type signatures and CPP around it. Not convinced that it's worth it. The second options is more a workaround: if you have a linear function f, which you wish to benchmark, you can benchmark \x -> f x instead, which is no longer linear and thus does not need any special support. I'm currently leaning to say that the second option is good enough. Cf. https://github.com/haskell/criterion/pull/263
More interesting is how to benchmark functions, whose inputs and outputs are not in Type. I can very well imagine someone wishing to use Int# as an input and an unlifted type as an output, so that no time is wasted for pointer chasing and tag checking. While this is doable for every specific RuntimeRep, I have not found an ergonomic way to be levity-polymorphic here. And type signature grows to be quite scary.

Closing:

\x -> f x trick is sufficiently good for linear functions.
Representational polymorphism is too immature to worry about at the momemnt.


Forward slash in CREATE REPOSITORY secret_key parameter causes exception

Environment:
Crate 1.0.5
Amazon Linux AMI 2<IP_ADDRESS>60923 x86_64 HVM GP2
3 AWS c4.large nodes
CrateDB version 1.0.5
Problem description:
Attempting to create a new snapshot repository with a forward slash in the secret_key parameter causes an exception.
Example CREATE REPOSITORY script:
CREATE REPOSITORY repository_name TYPE s3 WITH (   bucket='bucket-name',    base_path='/repository_path',    access_key='A_VALID_ACCESS_KEY',    secret_key='9SF9+V7ETk/hTQR/9' );
Causes the following exception:

RepositoryException[[] [repository_name] path [repository_path] is not accessible on master node]; nested: RepositoryVerificationException[[repository_name] path [repository_path] is not accessible on master node]; nested: IOException[Unable to upload object repository_path/tests-ZZ_aT5sRTx2JTpIG7kB1vA/master.dat-temp]; nested: AmazonS3Exception[The request signature we calculated does not match the signature you provided. Check your key and signing method. (Service: Amazon S3; Status Code: 403; Error Code: SignatureDoesNotMatch; Request ID: ECA7F4AE5675C4B7)];

hi @tellezb, we'll check that.

@tellezb
Cannot reproduce the issue. The / in the secret_key is definitely not the issue as I've tried with a couple of secret_keys all of them containing /.
Are you sure you have the correct bucket_name, base_path,  region, endpoint ?

@matriv
Yes, all of the other properties were correct. We generated and used a new secret_key without modifying any other properties and had success. I assumed it was the / that caused the issue ... could it have been the +? Those were the only 2 special characters in the secret_key.

@tellezb Tried now again also with + and also with a secret key containing both + and / and still works. Could be the case that the old access key pair was de-activated?

@tellezb Closing this, since couldn't be reproduced and generating a new Access/Secret key solved the issue.


Blazor/ServerRendering: Child Component does not render page property in the way I would expect.

Describe the bug
A child component in blazor is not rendering a property that is set from a parent page. It wont even compile in my sample and even then it does not work in my parent project when it does compile.
Why is this not simple?
Why dont the docs reflect the "right way"?
Not sure what I am doing wrong here but the docs are telling me I have done everything right. What have I done wrong? Any help here would be much appreciated.
To Reproduce
git clone git@github.com:RealOrko/aspnet-blazor-component-rendering-issue.git
cd aspnet-blazor-component-rendering-issue
dotnet restore
dotnet build
dotnet run

Further technical details
.NET Core SDK (reflecting any global.json):
 Version:   3.1.100
 Commit:    cd82f021f4

Runtime Environment:
 OS Name:     fedora
 OS Version:  31
 OS Platform: Linux
 RID:         fedora.31-x64
 Base Path:   /usr/share/dotnet/sdk/3.1.100/

Host (useful for support):
  Version: 3.1.0
  Commit:  157910edee

.NET Core SDKs installed:
  3.1.100 [/usr/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.1.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.1.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

GHLink: https://github.com/RealOrko/aspnet-blazor-component-rendering-issue

Hi. It looks like this is a question about how to use ASP.NET Core. While we do our best to look through all the issues filed here, to get a faster response we suggest posting your questions to StackOverflow using the asp.net-core-blazor tag.


Update yenwalert.toml

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

Prev PRs
https://github.com/anoma/namada-testnets/pull/1160
https://github.com/anoma/namada-testnets/pull/2223

Successfully validated transactions.toml file for commit hash 2026a20


🐞 - isAsync is not working as expected

Which ngx-ui-tour-* package is the source of the bug?
ngx-bootstrap
Please provide a link to a minimal reproduction of the bug
No response
Description
Hi,
I'm having an issue when I add a tourAnchor on an element that is displayed only after getting the result of an HTTP request.
For the first few steps (on elements that are present on the page without having to wait for a request response), no problem.
But when I do next() in order to show the step related to this async element, the backdrop stays on the previous step, the previous popup disappears and no new popup appears.
I tried adding isAsync: true to this step, but it almost does not change anything (only the "Can't attach to unregistered anchor with id XXX" error is not displayed anymore).
I also tried adding delayAfterNavigation, but it does no seem to change anything either.
This is a problem I have on every route/page containing data displayed based on the result of an HTTP request : adding a tour step on any element displayed asynchronously results in an "empty step" when running the tour.
Do I miss something obvious here? Or could this be related to the version of ngx-ui-tour I use?
Angular version
9.1.15
Ngx UI Tour version
7.0.2
Which browsers have you used?

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[x] Windows
[ ] Linux
[ ] iOS
[ ] Android

Making the step async should solve your issue.

Did you import TourNgxBootstrapModule in the module where you added your missing tourAnchor?
Did you import TourNgxBootstrapModule.forRoot() in your app module?
Is the tourAnchor on the html element spelled exactly the same like the anchorId in step definition?
Can you see if the tourAnchor is registered after your data is loaded by listening to anchorUnregister$ event?

Oh no...
I had a typo in the anchorId.
So now it works...
Thanks!

Awesome :)


update dependencies version

What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #16
Special notes for your reviewer:

/cc @sids-b @qizha

/lgtm

/approve


feat: accept --body argument

Why
I wanted to post body as well as title.
What
--body is now a valid flag.
gh p2 create ... --body 'string can contain newlines'
Thank you for the useful tool!
Test
I tested with self built binary.
go build -v cmd/p2/main.go
./main create ... --body '...'

Thanks for the tests and implementation! This is something I've been wanting to do for a long time. Nice job!
Will release as version v0.1.0 after the merge!

Release is now live 🎉  You can update with the following command!
gh extension upgrade shuntaka9576/gh-p2
# gh p2 -v
# p2 version 0.1.0 (rev:4957f34)


Documentation in the Pipelines page 404 not found

What is version of KubeSphere DevOps has the issue?
3.3.0
How did you install the Kubernetes? Or what is the Kubernetes distribution?
No response
Describe this feature
The documentation in the Pipelines page(red marker) is not found.

The documentation address is https://kubesphere.io/docs/v3.3/devops-user-guide/how-to-use/pipeline-settings/
Additional information
No response

Considering this is not a feature request. I'm going to change the label.
/kind-remove feature
/kind bug
/area console

/good-first-issue

I think this should be the link - https://kubesphere.io/docs/v3.3/devops-user-guide/how-to-use/pipelines/pipeline-settings/
But I'm not able to find the Learn more tab.

I think this should be the link - https://kubesphere.io/docs/v3.3/devops-user-guide/how-to-use/pipelines/pipeline-settings/ But I'm not able to find the Learn more tab.

You can find the front-end source code from https://github.com/kubesphere/console

you can find the link address from https://github.com/kubesphere/console/blob/master/server/config.yaml#L620

you can find the link address from https://github.com/kubesphere/console/blob/master/server/config.yaml#L620

So I have to make changes in this file and make PR in console repo?

So I have to make changes in this file and make PR in console repo?

Yes.

I'm going to close this issue due to it's fixed. Thanks for your time. @PrajwalBorkar
/close


Grade scaling fix to 1-100 for LTI Assignments

First checkout to the lms-lti branch and run CircuitVerse locally

Login to your account
Go to the Group page by clicking on My-Groups
Click on any existing group (if you haven't any create one)
Click on the +Add Assignment
After Clicking you will see the screen shown below

Expected Feature
If the checkbox shown above is clicked then the grading scale should be automatically be fixed at 1-100 scale and the field should be disabled. Add corresponding checks in the controller if necessary.

Reference Code
https://github.com/CircuitVerse/CircuitVerse/blob/261533d00b386dc7721636561c5f91d42384543a/app/views/assignments/_form.html.erb#L15
Note

Please make PR against lms-lti branch
Please comment below if you are starting work on this issue

I would like to work on this issue. Kindly assign this to me.

I would like to work on this issue. Kindly assign this to me.

Yah go ahead,  you can start working

@akshatvirmani hi are you still working on the issue ?

Yes Sir, But I don't know how to setup the project locally on VS Code. I read the README.md file but was still not able to set it up. I messaged you yesterday regarding the same on discord as I did not have permission to join the Slack channel.

Yes Sir, But I don't know how to setup the project locally on VS Code. I read the README.md file but was still not able to set it up. I messaged you yesterday regarding the same on discord as I did not have permission to join the Slack channel.

You can join slack from here https://circuitverse.org/contribute, and also you can use Gitpod environment if you are facing difficulties In stepping locally , look here for Gitpod working https://github.com/CircuitVerse/CircuitVerse/wiki/Development-on-Gitpod

Closing via #2375


Refresh Canvas/Portal classes, feeds, etc. when URLs are updated

When url data is updated, invalidate all information that relied on these feeds.

what part of the code is this in?

Route for changing Canvas URL: https://github.com/MyMICDS/MyMICDS-v2/blob/c2812a543aefa2ae71212f4b1309cd137de7836d/src/routes/canvasAPI.ts#L20
Route for changing Portal URLs: https://github.com/MyMICDS/MyMICDS-v2/blob/c2812a543aefa2ae71212f4b1309cd137de7836d/src/routes/portalAPI.ts#L29-L57
Function for refreshing Canvas cache: https://github.com/MyMICDS/MyMICDS-v2/blob/c2812a543aefa2ae71212f4b1309cd137de7836d/src/libs/feeds.ts#L13


Add performance testing blog post

Preview: https://deploy-preview-3470--opentelemetry.netlify.app/blog/2023/perf-testing/

@chalin Thank you for the review! I have made the changes based on your suggestions.

The TEXT linter is failing because it wants to capitalize java in SpanBenchmark.java

I've submitted a fix (#3492). We'll need to wait for that to land so that you can rebase.

REFCACHE check, I tried running npm run test-and-fix, but it's not updating anything

Hmm, test-and-fix works for me. I've submitted the updated refcache file.

@cartersocha agreed, this can be post-kubecon. E_TOO_MANY_BLOG_POSTS

All checks are ✅

Hrm. Did https://github.com/open-telemetry/opentelemetry.io/pull/3492 not fix the issue, or is there just some git branch fuckery going on causing the textlint check to fail again?

Hrm. Did #3492 not fix the issue, or is there just some git branch fuckery going on causing the textlint check to fail again?

Seems that the changes from that PR got not carried over when we switched from JSON to YAML

Will be published on Monday.


Jayfoad patch 1

Typos.

OMG, a pull request, never had to deal with one of them before! I shall see what I can do.
From: jayfoad<EMAIL_ADDRESS>Sent: 01 August 2016 11:38
To: mkromberg/aplx<EMAIL_ADDRESS>Subject: [mkromberg/aplx] Jayfoad patch 1 (#1)
Typos.

You can view, comment on, or merge this pull request online at:
https://github.com/mkromberg/aplx/pull/1
Commit Summary

Fix some typos.
Fix some more typos.

File Changes

M Differences.md https://github.com/mkromberg/aplx/pull/1/files#diff-0  (10)
M README.md https://github.com/mkromberg/aplx/pull/1/files#diff-1  (8)

Patch Links:

https://github.com/mkromberg/aplx/pull/1.patch
https://github.com/mkromberg/aplx/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/mkromberg/aplx/pull/1 , or mute the thread https://github.com/notifications/unsubscribe-auth/ACq1xZa781SGIZz9WFU4GcV9os48kmOrks5qbb5tgaJpZM4JZaUc .  https://github.com/notifications/beacon/ACq1xZpPB1gfbEI7cmjQYeiiOnuTetLFks5qbb5tgaJpZM4JZaUc.gif


All lh_stats functions were deprecated not just some

Since you had to touch macros.h anyway, would you mind to also cherry-pick 4d5cfb229be8a52cdf961d9b7c5f6c1c0fa3b4f7? Since it was just a typo in the comment, it wasn't backported.
~/src/openssl/3.1$ git diff gh-22248 gh-22247  --  include/openssl/macros.h
diff --git a/include/openssl/macros.h b/include/openssl/macros.h
index a614cd66e3..e9ef938747 100644
--- a/include/openssl/macros.h
+++ b/include/openssl/macros.h
@@ -158,7 +158,7 @@
 /*
  * Define macros for deprecation and simulated removal purposes.
  *
- * The macros OSSL_DEPRECATED_{major}_{minor} are always defined for
+ * The macros OSSL_DEPRECATEDIN_{major}_{minor} are always defined for
  * all OpenSSL versions we care for.  They can be used as attributes
  * in function declarations where appropriate.
  *
@@ -169,6 +169,7 @@
  * 'no-deprecated'.
  */

+# undef OPENSSL_NO_DEPRECATED_3_1
 # undef OPENSSL_NO_DEPRECATED_3_0
 # undef OPENSSL_NO_DEPRECATED_1_1_1
 # undef OPENSSL_NO_DEPRECATED_1_1_0

would you mind to also cherry-pick 4d5cfb229be8a52cdf961d9b7c5f6c1c0fa3b4f7

Alternatively, you can just do the simple fix yourself without a cherry-pick.

Since you had to touch macros.h anyway, would you mind to also cherry-pick 4d5cfb2? Since it was just a typo in the comment, it wasn't backported.
~/src/openssl/3.1$ git diff gh-22248 gh-22247 -- include/openssl/macros.h
diff --git a/include/openssl/macros.h b/include/openssl/macros.h
index a614cd66e3..e9ef938747 100644
--- a/include/openssl/macros.h
+++ b/include/openssl/macros.h
@@ -158,7 +158,7 @@
 /*
  * Define macros for deprecation and simulated removal purposes.
  *
- * The macros OSSL_DEPRECATED_{major}_{minor} are always defined for
+ * The macros OSSL_DEPRECATEDIN_{major}_{minor} are always defined for
  * all OpenSSL versions we care for.  They can be used as attributes
  * in function declarations where appropriate.
  *
@@ -169,6 +169,7 @@
  * 'no-deprecated'.
  */

+# undef OPENSSL_NO_DEPRECATED_3_1
 # undef OPENSSL_NO_DEPRECATED_3_0
 # undef OPENSSL_NO_DEPRECATED_1_1_1
 # undef OPENSSL_NO_DEPRECATED_1_1_0

I was not touching the macros.h on 3.1 branch yet. Are these changes really worth it?

I was not touching the macros.h on 3.1 branch yet.

My fault, I looked at the change set of #22248.

Are these changes really worth it?

Nah, it's ok, no need to do it.

Merged, thanks.


feature request:  dependsOnCallback

Firstly thank you for maintaining this component and adding the Nova 4 support.  Much appreciated!
I would like to request a feature to allow for more flexible dependsOn logic.  We have various scenarios where the check does not fit any of the provided dependsOnX methods available.  Instead of adding all these variations, it would be great if I can specify a callback and then handle the specific logic.
I would expect the callback to receive the value of the dependsOn field, and you can expect the callback to return true/false.
Something like
->dependsOnCallback('my_field',function($value) {
//add business logic

return true; //if I want it to show
return false; //if I do not want it to show

}

+1 here

+1

+1


Select between ssh/http in make-repos

It is not clear whether clone_url returns the SSH or HTTP url in this line of code.
Need to:

Find the RubyDocs for clone_url
Figure out an elegant way for configuring which URL to use

With the commit above, we can now specify the protocol in the .gitomator as follows:
hosting:
  provider: github
  access_token: YOUR-GITHUB-ACCESS-TOKEN
  organization: YOUR-GITHUB-ORGANIZATION
  default_protocol: ssh  # Optional config, can be either https or ssh

ci:
  provider: travis_pro
  access_token: YOUR-TRAVIS-CI-ACCESS-TOKEN
  github_organization: YOUR-GITHUB-ORGANIZATION


Extend core components

Hello.
I'm playing a bit with custom components but i have a little issue with it.
Let say i've created a custom component <epic-section>, that is the <mjml-section> base code with some modifications.
How can i tell to core components ( <mjml-column> for example ) it can now be in a parent epic-section and not only in mj-section, mj-group or mj-navbar ?

Hi @maximeparisse !
Well, I have no real answer for that, did you try to import mjml-column and push your tagName it to .parentTag ? I think this could work.
In MJML4 this will be way easier to push new dependencies to the core, you'll be able to inject them with a simple API.

Hummm, thanks for the answer @iRyusa, i will try that even if i'm not really expert with jsx and react components.
By any chance, do you have an approximative release date for mjml4 ?

Well we're working to get as many components ready to release a minimal beta with base components ( like section column image text divider ... ). So no date yet, but a beta should be available this month.
Directly in your components, you may have to add the package mjml-column to your package.json

i have the same Problem:

      ...

is this supposed to be working? The Compiler tells me that it does not work by design:
> Line 111 (mj-text) — mj-text cannot be used inside robo-speechbouble, only inside: mj-column, mj-hero-content
Is there a update-save way to extend the parent-tag of a core comp?

As said, dependencies are hard coded into components in MJML3. You can try to edit the MjText.parentTag @Laslo89 but I don't know if it works
Note that validation is completely and purely optional, your document will render fine in a skip/soft level.
In MJML 4 it will be completely different, components are independent and you'll have to define dependencies explicitely

👆 Closing the issue because it's available in the Beta. Feel free to reopen if you have any issue with it !


Update ntlm-user-authentication.md

Updating Windows password paragraph to correct that MD4 is a hash function, not an encryption algorithm. According to the RFC (https://datatracker.ietf.org/doc/html/rfc1320), there's also no dash in MD4.

@dkontyko : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Support DotNet CLI

It would be nice if Ionide-Paket could be configured to use dotnet paket ... instead of the outdated .paket/paket.exe call.
OS: Windows 10
Ionide version: 4.5.0
Ionide-Paket version: 1.12.0
VSCode version: 1.42.1
dotnet SDK version: 3.1.101

Fixed in 2.0


Fix Typo: group instead of groups

Fix typo in API discovery roles. Both system: authenticated and system: unauthenticated have kind as a group instead of groups. as shown below:
subjects:
- apiGroup: rbac.authorization.k8s.io
  kind: Group
  name: system:authenticated
- apiGroup: rbac.authorization.k8s.io
  kind: Group
  name: system:unauthenticated

Hi @deads2k @liggitt
COuld you please take a look!

/sig auth
/kind cleanup
LGTM

When 'group' is given in all lowercases, it means the general term. Only when we capitalize the first character (Group), we mean the API resource kind. Does this make sense?

Hi, @sftim  @tengqm Thanks for looking at this.
@tengqm yes, I think group, user is used as a API resource kind in the following sub-topic of RBAC Authorization:
API discovery roles, User-facing roles, Core component roles, Other component roles
Should i change group to Group and user to User service account  to ServiceAccount for uniformity of the docs. what do you suggest?

@Shubham82 this is the English word “group” which we write here as “groups” because it is plural.

Thanks, @sftim,
I'm closing this issue.

/close


Feature request: can customize connection path as with edge path

I have customized the edge path (more curved bezier path) to fit my needs of how nodes & edges look in my graph.
However, I cannot do that with the connection line, so when I drag the connection it doesn't look like an unfinished edge, and when I release the mouse button, it becomes an edge and changes to a different curve.
Can you provide some way to customize the connection path or just unify it with the edge path?
Thanks in advance.

Hey @buitrung
we can't unify it with the edge path, because we don't know which type of edge you are going to create. What we could do is to offer a customConnectionLine option. I will see how we can implement this feature.

I added a connectionLineComponent option in v5.10.0. You can find an example of how the implementation in the custom connection line example.

Apologize for late response, I've updated to 5.10.0 and cannot be more content with the feature.
Really appreciate your work!


Some code cleanup and optimizations when writing data from Jersey

More details:

Improve code to copy write buffers coming from Jersey
Let Netty re-schedule writes on the correct NIO thread
Do not use latches to synchronize Jersey and Netty threads

Although all tests are passing we should keep an eye for any regressions resulting from these changes. Note that all these changes are exclusive to Jersey and Helidon MP.

@barchetta Completed some manual testing with payloads over 5 MB without seeing any problems. Once the functional tests are in place, we should used those to further stress test these changes.