Fix windows tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3bcce14) 73.80% compared to head (60da39d) 74.19%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   73.80%   74.19%   +0.38%
==========================================
  Files           7        7
  Lines         775      775
==========================================
+ Hits          572      575       +3
+ Misses        162      160       -2
+ Partials       41       40       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Audio input and output

Please only submit reproducible issues.
If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt
Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting
When submitting a new issue, please supply the following information:
Platform: Place your platform here... give us your web browser/Electron version and your hardware (Raspberry Pi 2/3, Windows, Mac, Linux, System V UNIX).
Node Version: Make sure it's version 0.12.13 or later.
MagicMirror Version: Now that the versions have split, tell us if you are using the PHP version (v1) or the newer JavaScript version (v2).
Description: Provide a detailed description about the issue and include specific details to help us understand the problem. Adding screenshots will help describing the problem.
Steps to Reproduce: List the step by step process to reproduce the issue.
Expected Results: Describe what you expected to see.
Actual Results: Describe what you actually saw.
Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!
Additional Notes: Provide any other relevant notes not previously mentioned. This is optional.

Hi . I am almost done with my Smart mirror project but I have issue with the audio input and output.
I'am using ras pi 3 onboard 3.5mm jack for audio output and usb microphone  as audio in.
both are working individually  absolutely fine  but when I record something using usb microphone I am unable to get the output on the 3.5 mm microphones.
so I would really appreciate some help  as soon as possible.I have a demonstration of the project  within few days.

sorry, don't understand...
 I am unable to get the output on the 3.5 mm **microphones**

do you mean speakers?
if you use
arecord somefile.wav

to record from the usb mic
then
aplay somefile.wav
could play to the output device (called default)..

do you get system sounds from the analog device port?

note the cable matters and powered speakers
https://www.raspberrypi-spy.co.uk/2014/07/raspberry-pi-model-b-3-5mm-audiovideo-jack/

and look at raspi-config
https://raspberrypi.stackexchange.com/questions/61298/force-sound-over-3-5mm-jack-and-video-over-hdmi/61304#61304

By 3.5mm i mean earphones which can be plugged on to 3.5mm port of ras pi 3.
Here's my .asoundrc file :-
cm.!default{
type asym
playback.pcm{
type hw
card 0
}
capture.pcm{
type plug
slave.pcm "hw:1, 0"
}
}
ctl.!default{
type hw
card 0
}
The command for audio input through usb microphone is :-
1.For recording
pi@raspberrypi:~ $ arecord --format=S16_LE --duration=5 --rate=16000 --file-type=raw out.raw
2.For playing the recorded data
pi@raspberrypi:~ $ aplay --format=S16_LE --rate=16000 out.raw
so now my issue is when I play the recorded data there is no output in earphones which is connected to 3.5 mm jack of ras pi 3.
But when I play youtube in pi I am able to get the sound output in earphones.

do aplay -l (lowercase L) to list the output devices..   make sure your .asoundrc file is right
should be able to specify device too on aplay commandline -D xx:yy

sudo aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: ALSA [bcm2835 ALSA], device 0: bcm2835 ALSA [bcm2835 ALSA]
Subdevices: 7/7
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
Subdevice #3: subdevice #3
Subdevice #4: subdevice #4
Subdevice #5: subdevice #5
Subdevice #6: subdevice #6
card 0: ALSA [bcm2835 ALSA], device 1: bcm2835 ALSA [bcm2835 IEC958/HDMI]
Subdevices: 1/1
Subdevice #0: subdevice #0

see this topic.. links to PI config
https://forum.magicmirror.builders/topic/10285/no-sound-from-my-rpi-3-b?page=1

Hi could I get your email please.
Because nothing is working out for me.

HI I have started over with new Os.
pi@raspberrypi:~/MagicMirror/modules/MMM-Hotword $ npm install
npm WARN deprecated<EMAIL_ADDRESS>This module moved to @hapi/hawk. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated<EMAIL_ADDRESS>This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated<EMAIL_ADDRESS>This module moved to @hapi/sntp. Please make sure to switch over as this distribution is no longer supported and may contain bugs and critical security issues.

<EMAIL_ADDRESS>install /home/pi/MagicMirror/modules/MMM-Hotword/node_modules/snowboy
node-pre-gyp install --fallback-to-build

[snowboy] Success: "/home/pi/MagicMirror/modules/MMM-Hotword/node_modules/snowboy/lib/node/binding/Release/node-v57-linux-arm/snowboy.node" is installed via remote
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN<EMAIL_ADDRESS>No repository field.
added 216 packages from 133 contributors and audited 565 packages in 213.194s
found 11 vulnerabilities (8 moderate, 3 high)
run npm audit fix to fix them, or npm audit for details
Is this ok can I proceed.

come find me on discord and I will give you my email there..
as for hotword, it depends, if u start MagicMirror does it work or fail?

sure I will.
well I had a other query as well .
pi@raspberrypi:~/MagicMirror/modules/MMM-AssistantMk2 $ ./node_modules/.bin/electron-rebuild
⠧ Building module: grpc, Completed: 0
This build is taking quite long.

Yes. One took 30 minutes for me

so should I wait for it to complete.

Yes

Please refer to http://forum.magicmirror.builders for support and troubleshooting.
I'm closing this issue for now. If you feel this issue should remain open, please let me know.


WIP: respect kubic when configuring the pause image

feature#kubic-integration
Signed-off-by: Maximilian Meister<EMAIL_ADDRESS>

i wasnt aware this is already done at build time on caasp-container-manifests - it's likely a devsetup only issue with our injected manifests ... closing


porting this project to a browser-based JS version

I will port this project to develop a version that works in the browser.

I working on here.
https://github.com/t-cool/English-to-IPA

@mphilli
I've finished porting this project to JavaScript.
I hope you like it!
https://github.com/t-cool/English-to-IPA


Add tests for warnings when passing block to creation of new IO object

I think these were all IO subclasses, which means I probably missed half of them.
I used the syntax IO::open instead of IO.open in the descriptions of the tests, since that is what the warnings say.

There is a change in the TCP server spec where I have no idea how it has gotten into this pull request, I will fix that tomorrow

Looks good.
It seems this case is missing also for TCPSocket and StringIO classes

https://github.com/ruby/spec/blob/master/library/stringio/new_spec.rb
StringIO already has this test (which I did not know until 10 seconds agon).

Added TCPSocket (the specs for new are in initialize_spec, that's why I missed it at first glance). I updated the StringIO spec to match the style of the other ones, and added a raise in the block to verify that the block is not used.


listener-manager: Correct typo in internal docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.689%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1385

Relevant Lines:
2141

💛  - Coveralls


Assigning IP workflow is unworkable. No matter the direction it is done.

Issue type
[x ] Feature request
[x ] Bug report
[ ] Documentation
Environment

Python version:  3.4.5-4
NetBox version:  2.2.7

Description
Currently, adding an IP to an interface requires two active tabs (One in the target prefix to identify an available IP and one on the device to assign the IP.) It requires cutting and pasting and simply isn't efficient or workable. It has made Netbox nearly unusable for my shop.
The old method was set up so that you could create the IP from/within the prefix and assign that IP to a device and interface either by searching or using the drill down method (there was a form for this until recently).
In 2.2.5, the ability to add the next available IP within the prefix was added to the Add IP option within the prefix but that really serves no purpose because you still have to have a second window open to assign the IP you just created.
In short, my request is two fold.

When creating an IP within a given prefix using either the add IP method or by selecting from an available block (x available) within the IP list, the ability to assign the created or selected IP to a device be added back. Both the device search and drill down methods were useful and should be included.

When adding an IP to a device from the device screen, the ability to select an prefix, and an available IP (or next available within the prefix) within that prefix be added.

Honestly, this is such a big deal for my company that we are willing to resort to flat out bribery to get this functionality back. Scotch? Rye? Beer? Steaks? Say the word.

Please see the discussion in #1512. If the current workflow is not sufficient for your needs, NetBox may not be the right solution for you.

Have you tried adding an IP to a device? Seriously. Just go through the process and tell me that is an efficient use of clicks and time. It takes twice as long as it did before and is so prone to errors that the entire point of the software flies out the window. Beyond that, there is no capability for bulk IP add either now with this method. This is a regression. Sure, it works with some fooling around but is a regression.


Convert all links to HTTPS

Thank you for contributing to A Field Guide to Elephpants. To speed up approval of your contribution, please review the following checklist:

[x] I have read the CONTRIBUTING guide
[x] All text and photographs included are licensed under CC:BY-NC-SA or a compatible license.
[x] (If Needed) New subspecies have been added to sculpin_site.yml following the naming convention.

This PR converts all http:// links to https:// except for:

source/index.html: http://www.elroubio.net/ (site has open port 443 but SSL handshake failed)
source/_elephpants/2015-10-13-multicolored-haphpy.md: https://github.com/afup/haphpy-birthday is using GitHub Pages but is not configured to serve via the haphpy-birthday.net domain
various links in composer.lock from 3rd party libraries

@Wilkins do you still have the original files?  These links are dead
https://github.com/philipsharp/afieldguidetoelephpants/blob/504d874e269dd3aa407075cf7c80718096f30065/source/_elephpants/2014-09-05-red-laravel.md#L12
https://github.com/philipsharp/afieldguidetoelephpants/blob/504d874e269dd3aa407075cf7c80718096f30065/source/_elephpants/2014-09-05-red-laravel.md#L16

Hello @cookieguru 😄
I do have the files.
In fact the links are OK with www :
http://www.wilkins.fr/elephpants/IMG_4326.JPG
http://www.wilkins.fr/elephpants/IMG_4325.JPG
and the small versions :
http://www.wilkins.fr/elephpants/IMG_4326_SMALL.JPG
http://www.wilkins.fr/elephpants/IMG_4325_SMALL.JPG
But my local hosting is not handling HTTPS right now.
If you have a place to put them on an HTTPS hosting, you are welcome to copy them.
Ping me if you need anything else 😄


bump Babylon contracts

TODO before merging

[x] wait until https://github.com/babylonchain/babylon-contract/pull/163 and https://github.com/babylonchain/babylon-contract/pull/162 are merged

CI is not passing, btw.

CI is not passing, btw.

CI for this repo is broken as github action could not fetch private repositories. Asked infra team for help and they will do sth depending on the priority


chore: Simplify scheme to use clientgoscheme

Fixes #N/A
Description
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"INFO","time":"2024-06-27T21:15:33.025Z","logger":"controller","message":"found provisionable pod(s)","commit":"7bc4aad-dirty","controller":"provisioner","namespace":"","name":"","reconcileID":"5806b37b-aa33-46b3-8074-9cc6717e8b62","Pods":"default/inflate-66fb68585c-bzb8w, default/inflate-66fb68585c-ftqdf, default/inflate-66fb68585c-zt8cg, default/inflate-66fb68585c-rdvkn, default/inflate-66fb68585c-8xkjp","duration":"109.481202ms"}
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"INFO","time":"2024-06-27T21:15:33.025Z","logger":"controller","message":"computed new nodeclaim(s) to fit pod(s)","commit":"7bc4aad-dirty","controller":"provisioner","namespace":"","name":"","reconcileID":"5806b37b-aa33-46b3-8074-9cc6717e8b62","nodeclaims":1,"pods":5}
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"INFO","time":"2024-06-27T21:15:33.060Z","logger":"controller","message":"created nodeclaim","commit":"7bc4aad-dirty","controller":"provisioner","namespace":"","name":"","reconcileID":"5806b37b-aa33-46b3-8074-9cc6717e8b62","NodePool":{"name":"default"},"NodeClaim":{"name":"default-tvtbh"},"requests":{"cpu":"5150m","pods":"8"},"instance-types":"c3.2xlarge, c4.2xlarge, c4.4xlarge, c5.2xlarge, c5.4xlarge and 55 other(s)"}
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"DEBUG","time":"2024-06-27T21:15:33.265Z","logger":"controller","message":"created launch template","commit":"7bc4aad-dirty","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"default-tvtbh"},"namespace":"","name":"default-tvtbh","reconcileID":"88bbeef4-70e0-4f88-a3f2-078fb3820613","launch-template-name":"karpenter.k8s.aws/4200942649942437247","id":"lt-0fb57ebc3b219f221"}
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"DEBUG","time":"2024-06-27T21:15:33.467Z","logger":"controller","message":"created launch template","commit":"7bc4aad-dirty","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"default-tvtbh"},"namespace":"","name":"default-tvtbh","reconcileID":"88bbeef4-70e0-4f88-a3f2-078fb3820613","launch-template-name":"karpenter.k8s.aws/4597386029746389270","id":"lt-00e0140db47db54e1"}
kube-system karpenter-d46cbcdf8-4pzt5 controller {"level":"DEBUG","time":"2024-06-27T21:15:33.597Z","logger":"controller","message":"created launch template","commit":"7bc4aad-dirty","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"default-tvtbh"},"namespace":"","name":"default-tvtbh","reconcileID":"88bbeef4-70e0-4f88-a3f2-078fb3820613","launch-template-name":"karpenter.k8s.aws/15110344588232523498","id":"lt-0f404dd30dfa32753"}

How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

18 of 20 (90.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 79.157%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cloudprovider/cloudprovider.go
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.56%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
5784

Relevant Lines:
7307

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

18 of 20 (90.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 79.171%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/cloudprovider/cloudprovider.go
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
5785

Relevant Lines:
7307

💛  - Coveralls


Print absolute paths when file not found

Description
Printing absolute paths is helpful when debugging why files won't load. By printing the whole path we're making it more clear to the user exactly what file is failing to load instead of simply repeating the relative path they already wrote in their code.
Here's some more info on std::filesystem::absolute. If a path isn't already absolute, it creates an absolute path. This means our APIs still work whether users use relative or absolute paths. I don't believe a change like this would have been feasible before switching over to std::filesystem.
Tasks

[ ] Tested on Linux
[ ] Tested on Windows
[x] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
For an easy example of this, build the master branch then try to run ./examples/tennis/tennis from the CMake binary directory. This will fail with an error that looks like this:
AL lib: (EE) FillCPUCaps: Failed to open /proc/cpuinfo, cannot check for NEON support
Failed to open sound file "resources/ball.wav" (couldn't open stream)

After this PR, the error instead looks like this:
AL lib: (EE) FillCPUCaps: Failed to open /proc/cpuinfo, cannot check for NEON support
Failed to open sound file "/Users/thrasher/Projects/sfml/build/resources/ball.wav" (couldn't open stream)

The first output is a bit unclear because there is certainly a file called ball.wav in the resources directory which lives next to the source file where that code is written. However the second output shows the real truth that I'm actually attempting to load a file from the CMake binary direction which doesn't exist.

On the other side, printing the absolute path when you specified a relative path, can also be confusing and potentially misleading. Like why is it printing the absolute path when I explicitly specified the relative path? Or a confused user may think that they need to use an absolute path, because that's what the error message returned.
I'm okay with the change, just wanted to open a discussion from another point of view, to ensure we aren't making things worse on a broader spectrum.

On the other side, printing the absolute path when you specified a relative path, can also be confusing and potentially misleading. Like why is it printing the absolute path when I explicitly specified the relative path? Or a confused user may think that they need to use an absolute path, because that's what the error message returned.

We could raise the abstraction level even further and create a helper function which given a std::filesystem::path will simply print the path if it's already absolute or if it's relative print both the relative and absolute paths. I avoided this mostly in the name of maintaining a simple implementation but something like this is certainly possible.

Just brainstorming -- a third option might be the path relative to the executable. (Is this always the one the user specifies? What about different working directories?)
Path transformations can quickly get fiddly though, as soon as things like symlinks are involved. Paths are non-trivial...
If clarity is a concern, it's also possible to provide both user-provided and absolute path in the error message:
Error: Failed to open sound file (couldn't open stream).
   path:       /to/file.ogg
   absolute:   /user/absolute-path/to/file.ogg

Just brainstorming -- a third option might be the path relative to the executable. (Is this always the one the user specifies? What about different working directories?)

I don't think there is a 3rd path to reason about. There is just the user-provided relative path (which is implicitly relative to where the executable is run, not where it is compiled) and the absolute path equivalent of that. If the user provides an absolute path then there is only one path to reason about.

If clarity is a concern, it's also possible to provide both user-provided and absolute path in the error message:
Error: Failed to open sound file (couldn't open stream).
   path:       /to/file.ogg
   absolute:   /user/absolute-path/to/file.ogg

This is easy to implement so I'd support doing it in this PR. I tried it out locally and it looks good.

Edit: no matter what we choose, I'd actually appreciate extracting the "context data" (such as path, filename, error details, etc) from the message itself. With something like
Error: Failed to open sound file C:/Users/Me Who Has a Long Name/Documents/SFML/Projects/XY/Audio/File.ogg (couldn't open stream).
it's very easy to miss the "(couldn't open stream)" part.

Good point. Irrespective of this PR, it's worth taking a closer look at all uses of sf::err() to make sure the wording of the errors is as clear as possible.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

I quite like @Bromeon's suggestion with showing both. It also helps people understand where their file is expected to be and what relative path they've entered. So it might actually lead to fewer "can't load image" support requests 🙂

I quite like @Bromeon's suggestion with showing both. It also helps people understand where their file is expected to be and what relative path they've entered. So it might actually lead to fewer "can't load image" support requests 🙂

I took a crack at providing more info. Now when an operation involving a path fails, the output looks like this:
Failed to open sound file (couldn't open stream)
    Provided path: "resources/ball.wav"
    Absolute path: "/Users/thrasher/Projects/sfml/build/resources/ball.wav"

I like how "Provided" and "Absolute" have the same number of characters. I wanted to make it clear that we're showing the user the path they themselves provided to the API whether not that path was already absolute.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

Thanks for opening this idea and I hope we'll soon see the benefit from it 🙂


Opening PCB file

Hi Scotty,
I made some changes to your project so that everyone can open and modify your PCB because the old path was set to yours which was absolute.
I also propose a gitignore file to prevent adding of unwanted file after opening Schematics and linking to symbol components in Eeschema.
Regards,
Steve

Hello, I'm still waiting for it

Hello, I'm still waiting for it


SNAP-1656 Security support in snappydata

Changes proposed in this pull request
Security support in SnappyData.
Patch testing
precheckin in-progress
ReleaseNotes changes
NA
Other PRs
https://github.com/SnappyDataInc/snappydata/pull/731

LGTM. Minor comments.


feat: deletes the machine pool created during oc registration

Closes #
Verification Steps

Do x
Do y

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

LGTM 👍


stm32f4 i2c bug fixes for 1.14

With the STM32F4 I2C driver I ran into two problems;

the bug described in #22751
EMC spikes cause the driver to hang so bad only a device reset can fix it.

Especially the resetting of the device is tricky, because it also resets all settings like bitrate.
The fixes in these commits fix my problem, the hardware ran more than 300 hours nonstop with 10 I2C transactions per second. Without the fixes it doesn't last more than a few minutes before it hangs.
The EMC problem only happened about every 30 hours, so a pain to debug, until I found out short circuiting SDA to GND will trigger it on command.
Fixes #22751.

^^ @ABOSTM

@lowlander has this been fixed in master?

@lowlander has this been fixed in master?

@carlescufi I don't know, the project I need it for still is on 1.14.  I can check after I get this patch done.

@lowlander has this been fixed in master?

@carlescufi I don't know, the project I need it for still is on 1.14. I can check after I get this patch done.

CCB input: Before we can merge this PR we would need to know if this indeed requires a PR to master as well.

@erwango  does this issue exist also in master?

@carlescufi, @nashif, This issue is not fixed in master.
Some of the changes are there (timeout in first commit), but not the core of the fix.
Also, it could be noted that files have diverged, so fix has to be reworked.
Btw, on master, I think implementation of https://github.com/zephyrproject-rtos/zephyr/issues/23441 would be a solution to reported issue (using parts of this change).
@lowlander, one question, do you know if error is anyhow specific to v1?

I encountered a similar issue on NXP Kinetis a while back. The NXP LPSPI controllers supports an idle timeout, which I implemented support for here: #20626

@erwango will you please update this issue? will it get fixed in master?

Hey All, sorry that I didn't find more time to move this PR forward. Our system now has been in use for a while and we had no complains about I2c anymore. But I must say I have build in a "hard-reset" in our system, where I use GPIO to reset the I2C bus. Building that into the 1.14 driver isn't that easy because the driver doesn't have easy access to the GPIO's.
I have not been able to test master since then I would first have to port master to our hardware :-/
So not really sure how to move forward with this, would be good if there are some other 1.14/I2C users that could test it if it at least doesn't break anything.

@MaureenHelm I updated this fix for master in #27291 can you give it a look ?

@MaureenHelm I updated this fix for master in #27291 can you give it a look ?

Thank you!

Hey All, sorry that I didn't find more time to move this PR forward. Our system now has been in use for a while and we had no complains about I2c anymore. But I must say I have build in a "hard-reset" in our system, where I use GPIO to reset the I2C bus. Building that into the 1.14 driver isn't that easy because the driver doesn't have easy access to the GPIO's.

@lowlander Based on this comment, and that master has already merged your fix, do you need this in 1.14 anymore or can we just close it?
There're enough changes between this and the original and master that I'm not really comfortable approving without testing, and I don't have hardware for this variant.  So if we don't need it backported that'd be great.

@lowlander Based on this comment, and that master has already merged your fix, do you need this in 1.14 anymore or can we just close it?

@pabigot I moved my projects to master, so personally I will not need it on 1.14 anymore, but it might bite others.


Running the GitHub action with  scorecard: verbose fails with error failed to enrich scorecard: expecting []ScorecardCheck

TL;DR
Running the action with scorecard: verbose throws an error. Running with scorecard: yes works.
   steps:
      - name: Legitify Action
        uses: Legit-Labs/legitify@main
        with:
          github_token: ${{ secrets.GH_PAT }}
          analyze_self_only: true
          scorecard: verbose

Expected behavior
A working scan
Observed behavior
The error seems that to be the issue: failed to enrich scorecard: expecting []ScorecardCheck
Version
main
On which operating system are you using legitify?
Linux
Relevant log output
execute legitify analyze: [
  'analyze',
  '--scorecard',
  'verbose',
  '--repo',
  '<org>/<repo>',
  '--ignore-policies-file',
  './ignored-policies',
  '--output-format',
  'json',
  '--output-file',
  'legitify-output.json'
]
execute legitify convert sarif: [
  'convert',
  '--input-file',
  'legitify-output.json',
  '--output-format',
  'sarif',
  '--output-file',
  'legitify-output.sarif'
]
Error: The process '/home/runner/work/_actions/Legit-Labs/legitify/main/legitify' failed with exit code 1 | stderr: Error: failed to parse flattened scheme: failed to parse aux for violation: failed to enrich scorecard: expecting []ScorecardCheck

Error: Error: The process '/home/runner/work/_actions/Legit-Labs/legitify/main/legitify' failed with exit code 1

Additional information
No response

Fixed in v1.0.4 - https://github.com/Legit-Labs/legitify/releases/tag/v1.0.4


Update to latest SDK version & include query client

This updates to use the latest versions of the SDKs (5.0.0) and also includes use of the query client. Tested with Android Studio and run on an actual Nexus 5X; confirmed that I was able to both post events and issue queries.
@dkador this probably doesn't merit a super thorough review, but would you mind giving it a quick glance and letting me know if you have questions/concerns?

looks good! 👏  :shipit:

Thanks for the review!


Cannot copy depth buffer

Hey,
I am trying to copy a depth image to an buffer so that I can export it as an image.
Issue
I have a depth buffer/image with format D32_SFLOAT (D16_UNORM leads to same issue).
When calling copy_image_to_buffer with my depth buffer as a source I get the following error
this format cannot accept pixels', .../vulkano-0.29.0/src/command_buffer/validity/copy_image_buffer.rs:154:10

The code fails because I cannot get the block size for the format:
https://github.com/vulkano-rs/vulkano/blob/de1147589eefc678b95885671ed10052bebcd690/vulkano/src/command_buffer/validity/copy_image_buffer.rs#L154
But D32_SFLOAT has a defined block size in the specs and also the xml file used to generate the format code:
 <format name="VK_FORMAT_D32_SFLOAT" class="D32" blockSize="4" texelsPerBlock="1">
      <component name="D" bits="32" numericFormat="SFLOAT"/>
  </format>

Why is the block size not defined and how can I work around this issue?
Thanks!
Version of vulkano: 0.29.0

Is this issue fixed in the new Vulkano 0.30 release?


msrh_sec reader should have more sensible tstamp default

I've entered tstamp=1 before, but that may soon crash, see https://github.com/ixdat/ixdat/pull/148#discussion_r1427048243
Since users of this reader don't care about the absolute timestamp, anything that doesn't crash is fine. Could use time.time().

I've tried to fix that. But, just for future reference, we could have an agree upon datetime that is used everywhere if no tstamp is given, which is just slightly away from the epoch.

@KennethNielsen , your fix works! No problems.
And looking at it again, it actually defaults to a prompt. I've left that default, but added an option to put tstamp="now" to get time.time()


Bot joke regex generation

Bot answers on wh joke, even when another command is issued

Closed, due to change of joking system


Enhance the Chinese translation

Package version eg. v8, v9:
v9
Enhancement:
Could I add the zh-tw translation to the translations package??
Because there is only zh translation for Chinese words.
There are such different between the zh and zh-tw
Actually the zh translation in the package is zh-cn, it's for China area (Simplified Chines).
The zh-tw is for Taiwan area (Traditional Chinese).
I can make a pull request for the zh-tw translation. Thank you.

@kanozec yes by all means please add, the underlying locales package should support that :)


WIP: Building on Neutrino155 master: debug petsc -3.10 build

Just trying to isolate the problem to 3.10 -- eliminate all other versions, remove serial tests.

@Chiffafox any ideas here? 😁

Okay, I have localized it to a version change in pip: with pip version 23.0.1, petsc install works no problem. However the version used with python=3.10 appears to be pip version 23.1.2, which does not drop down to legacy install mode: I confirm this locally as well. I imagine the problem is the same for later Python versions.
Tl;DR is we need to version-lock pip to 23.0.1 or lower.

It's really spooky that some random change somewhere can totally break our installation. Not that I know how to fix it but honestly it should not be this difficult.
@Chiffafox wild idea: any way we can install PETSc from source or something? Would that be easier?


Support special mapping of dtypes when preparing device map

This PR will go along with [PR to come in Transformers] that fixes big model inference for T5 models. T5 models now have some weights that are kept in float32, which interferes with the computation done by infer_auto_device_map. On my setup, it gets me OOM when trying to load any big T5 model.
To fix that, on the Accelerate side we now accept a new argument special_dtypes which maps weight names to dtypes to use (and for the others we use the dtype provided).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Old Twitter logo is in OpenCollective page

Describe the bug
Old Twitter logo is present in https://opencollective.com/opencollective and it needs to be changed to X logo
To Reproduce
Steps to reproduce the behavior:

Go to https://opencollective.com/opencollective
See error

Expected behavior
New Twitter logo or X logo must be used
Screenshots

Triage Template (core team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

@Betree I can change the logo an make a PR. Also the open collective page in OpenCollective-frontend and https://opencollective.com/opencollective are not matching.
Localhost:

Actual webpage:

Is there any different repo?

Something was started in https://github.com/opencollective/opencollective-frontend/pull/9527, and we provided some instructions on how to solve it in the PR.

I can change the logo an make a PR. Also the open collective page in OpenCollective-frontend and https://opencollective.com/opencollective are not matching.

The default dev environment points to https://staging.opencollective.com (or your local API if configured), not https://opencollective.com.

Thanks a lot, Can I make the logo change to the footer as well?

@MayaSatishRao Sure

@Betree I have made the PR. Please review it.


BiDi: Design of _WD_BidiGetContextID needs to be reevaluated

Bug report
Describe the bug
_WD_BidiGetContextID should return the Context ID of the currently active browser context. The assumption was that the active browser context would appear at the top of the results from browsingContext.getTree, but that doesn't appear to be the case.
How to reproduce
Steps to reproduce the behavior (e.g.):

Go to '...'
Click on '...'
Scroll down to '...'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
System under test
Please complete the following information.

OS: [e.g. Windows 10]
OS Arch.: [e.g. X64]
Browser [e.g. firefox]
Browser version [e.g. 96.0.3]

Fixed in a7fbaa55f5948a1d9015ea2d9c7b33e1629827f8


nixos/collectd: put extraconfig before plugins

this is necessary to override the global option Interval.
If set after the plugins, it has no effect.

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Not sure if my comment is relevant here (I'm not familiar with this software) but you might consider taking a look at how extraConfig is handled in our SSH module. The module allows you to call mkBefore and mkAfter if you need config to go in specific order.
If this comment is not relevant please ignore and accept my apologies for the noise 😆

thanks for the suggestion, it's actually a very nice trick I didn't know about.
@GrahamcOfBorg test collectd

Awesome! Yeah, a neat little trick we could probably make more use of in NixOS.
LGTM 👍


Add RGB color to units

Before:

^ Note how the Archer and the Captive had the same color due to the algorithm that was used to select colors for them automatically.
After:

(In the CLI, unit colors are downsampled from RGB to 256 color ANSI for greater uniformity.)

Codecov Report

Merging #165 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   92.35%   92.32%   -0.03%
==========================================
  Files          83       83
  Lines        1060     1056       -4
  Branches      177      176       -1
==========================================
- Hits          979      975       -4
  Misses         66       66
  Partials       15       15

Impacted Files
Coverage Δ

packages/warriorjs-units/src/Wizard.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-units/src/Archer.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-units/src/Sludge.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-units/src/Warrior.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-units/src/ThickSludge.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-units/src/Captive.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-core/src/loadLevel.js
92.59% <100%> (ø)
:arrow_up:

packages/warriorjs-cli/src/ui/printLogMessage.js
100% <100%> (ø)
:arrow_up:

packages/warriorjs-core/src/Unit.js
100% <100%> (ø)
:arrow_up:

packages/warriorjs-core/src/Warrior.js
100% <100%> (ø)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c62cf...c8a5ac2. Read the comment docs.


Exception when running as container and printing help

Running with docker as per the example in the readme results in an exception after printing the help information.
`--> sudo docker run \

--interactive
--rm
--tty
senzing/stream-producer
usage: stream-producer.py [-h]
{avro-to-azure-queue,avro-to-kafka,avro-to-rabbitmq,avro-to-sqs,avro-to-sqs-batch,avro-to-stdout,csv-to-azure-queue,csv-to-kafka,csv-to-rabbitmq,csv-to-sqs,csv-to-sqs-batch,csv-to-stdout,gzipped-json-to-azure-queue,gzipped-json-to-kafka,gzipped-json-to-rabbitmq,gzipped-json-to-sqs,gzipped-json-to-sqs-batch,gzipped-json-to-stdout,json-to-azure-queue,json-to-kafka,json-to-rabbitmq,json-to-sqs,json-to-sqs-batch,json-to-stdout,parquet-to-azure-queue,parquet-to-kafka,parquet-to-rabbitmq,parquet-to-sqs,parquet-to-sqs-batch,parquet-to-stdout,sleep,version,docker-acceptance-test}
...

Queue messages. For more information, see https://github.com/Senzing/stream-
producer
positional arguments:
{avro-to-azure-queue,avro-to-kafka,avro-to-rabbitmq,avro-to-sqs,avro-to-sqs-batch,avro-to-stdout,csv-to-azure-queue,csv-to-kafka,csv-to-rabbitmq,csv-to-sqs,csv-to-sqs-batch,csv-to-stdout,gzipped-json-to-azure-queue,gzipped-json-to-kafka,gzipped-json-to-rabbitmq,gzipped-json-to-sqs,gzipped-json-to-sqs-batch,gzipped-json-to-stdout,json-to-azure-queue,json-to-kafka,json-to-rabbitmq,json-to-sqs,json-to-sqs-batch,json-to-stdout,parquet-to-azure-queue,parquet-to-kafka,parquet-to-rabbitmq,parquet-to-sqs,parquet-to-sqs-batch,parquet-to-stdout,sleep,version,docker-acceptance-test}
Subcommands (SENZING_SUBCOMMAND):
avro-to-azure-queue
Read Avro file and send to Azure Queue.
avro-to-kafka       Read Avro file and send to Kafka.
avro-to-rabbitmq    Read Avro file and send to RabbitMQ.
avro-to-sqs         Read Avro file and print to AWS SQS.
avro-to-sqs-batch   Read Avro file and print to AWS SQS using batch.
DEPRECATED: Use avro-to-sqs and set
SENZING_RECORDS_PER_MESSAGE
avro-to-stdout      Read Avro file and print to STDOUT.
csv-to-azure-queue  Read CSV file and send to Azure Queue.
csv-to-kafka        Read CSV file and send to Kafka.
csv-to-rabbitmq     Read CSV file and send to RabbitMQ.
csv-to-sqs          Read CSV file and print to SQS.
csv-to-sqs-batch    Read CSV file and print to SQS using batch.
DEPRECATED: Use csv-to-sqs and set
SENZING_RECORDS_PER_MESSAGE
csv-to-stdout       Read CSV file and print to STDOUT.
gzipped-json-to-azure-queue
Read gzipped JSON file and send to Azure Queue.
gzipped-json-to-kafka
Read gzipped JSON file and send to Kafka.
gzipped-json-to-rabbitmq
Read gzipped JSON file and send to RabbitMQ.
gzipped-json-to-sqs
Read gzipped JSON file and send to AWS SQS.
gzipped-json-to-sqs-batch
Read gzipped JSON file and send to AWS SQS using
batch. DEPRECATED: Use gzipped-json-to-sqs and set
SENZING_RECORDS_PER_MESSAGE
gzipped-json-to-stdout
Read gzipped JSON file and print to STDOUT.
json-to-azure-queue
Read JSON file and send to Azure Queue.
json-to-kafka       Read JSON file and send to Kafka.
json-to-rabbitmq    Read JSON file and send to RabbitMQ.
json-to-sqs         Read JSON file and send to AWS SQS.
json-to-sqs-batch   Read JSON file and send to AWS SQS using batch.
DEPRECATED: Use json-to-sqs and set
SENZING_RECORDS_PER_MESSAGE
json-to-stdout      Read JSON file and print to STDOUT.
parquet-to-azure-queue
Read Parquet file and send to Azure Queue.
parquet-to-kafka    Read Parquet file and send to Kafka.
parquet-to-rabbitmq
Read Parquet file and send to RabbitMQ.
parquet-to-sqs      Read Parquet file and print to AWS SQS.
parquet-to-sqs-batch
Read Parquet file and print to AWS SQS using batch.
DEPRECATED: Use parquet-to-sqs and set
SENZING_RECORDS_PER_MESSAGE
parquet-to-stdout   Read Parquet file and print to STDOUT.
sleep               Do nothing but sleep. For Docker testing.
version             Print version of program.
docker-acceptance-test
For Docker acceptance testing.
optional arguments:
-h, --help            show this help message and exit
Traceback (most recent call last):
File "/app/stream-producer.py", line 2795, in
do_sleep(args)
File "/app/stream-producer.py", line 2712, in do_sleep
config = get_configuration(args)
File "/app/stream-producer.py", line 712, in get_configuration
new_key = key.format(subcommand.replace('-', '_'))
AttributeError: 'NoneType' object has no attribute 'replace'
`

Pull request:

https://github.com/Senzing/stream-producer/pull/101


Use apiversion networking.k8s.io/v1 for ingress in example

There is a warning deprecation message for kubernetes v1.19:
Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

Switched apiVersion in the example to networking.k8s.io/v1

/assign @xiangpengzhao

@miry 分三个 PR提交，不同语言一个 PR

@markthink I am ok with your suggstion. I have not changed translations so far.
In this case it could have different examples depends on language, that would create confusion.
Possible reason why it could have discrepensy, that different pr merged in different time.
I am going to split pr and will try to link them.

@markthink I have split to 3 PRs changes. Pls verify this PR.

/lgtm
/approve


Remove use of window.name as a channel for localStorage messages

window.name was used to decide what item key would be used for a popup's message to the parent. This is nor reliable, as some browsers leak the fact that Facebook (and other popups) may set a window name that destroys the one set by Torii.
Instead, this patch uses a global key set by torii, identifying a "current channel" that expects to receive the message. This is not perfect, as a window opening a torii request after an different window
may receive the completed auth from the window of the first request. However in a practical sense it means the last window starting auth will receive the messages from auth popups, and old windows that may have started auth will receive none.
See https://github.com/Vestorly/torii/pull/195#issuecomment-119669300

@aaronrenner could use a sanity check.
@OrKoN if you can give this a real-world smoke test that would be awesome. I believe it addresses your issues in Chrome and FF.

@mixonic Thanks a lot. Worked in my case.


⚠ Mitsubishi has degraded performance

In bab2110, Mitsubishi (https://mitsubishimotorsid-mobileapp.com/app/login) experienced degraded performance:

HTTP code: 200
Response time: 5232 ms

Resolved: Mitsubishi performance has improved in 1e9bb16 after 1 minute.


Python 3 support

With the latest set of commits Python3 seems to be working. Getting mutagen working was the biggest challenge. Migrating over most of the dependencies to PIP packages and making them easily updated took a large portion of the effort out of things.
Python 3 should offer better unicode support, which will be a welcome change.
The goal is to make the script compatible with both Python 2 and 3 simultaneously, and it looks like at this point the majority of features are working under Python 3, at least on my setup. Feel free to drop any new issues or problems here as people begin testing.

Known issue: manual.py progress bar doesn't work.

Has the manual.py progress bar bug been addressed?

Not yet. Low on my priority list and been busy
Sent from my iPhone

On Mar 5, 2016, at 10:08, Jadik<EMAIL_ADDRESS>wrote:
Has the manual.py progress bar bug been addressed?
—
Reply to this email directly or view it on GitHub.


 I was hoping it'd do the same for other Byzantium tests, but that doesn't seem to have been the case.

Actually, the runtime for Byzantium tests on travis varies wildly (from 30min up to 40min), on the same branch, so it's tricky to evaluate any performance improvements using just the times from a travis run. But it may also be that the bottleneck when running the tests on travis is something else (as they run in a VM on a probably high-load host) so I guess our only hope is to evaluate the performance improvement of those changes locally

I have been thinking that a simple account cache could improve performance.  Simply caching the most recently accessed accounts and using the cache for read operations should be reasonably simple to implement and reduce database reads by some non-trivial amount.

I implemented the cache on State._get_account(), but it seems to have reduced the runtime of the Byzantium tests only by a few minutes (on travis, confirming locally now), which is less than what I was hoping. Although it probably makes sense as not all tests make tons of _get_account() calls like the slowest ones.
Is this what you had in mind for the caching of accounts or were you thinking of something else?
Also, I've experimented with other caching libraries (repoze.lru and fastcache), as well as invalidating individual cache entries (as opposed to the whole cache) on _set_account(), but the run times I saw locally (for one of the slow tests) was similar so I think it's best to stick with functools.lru_cache, unless you know of any others?

So, these are my local runtimes for the Byzantium tests:

36.2 minutes on master
32.9 minutes with<PHONE_NUMBER>4ed86aca56cd19243343647742ebbc
29.5 minutes with both<PHONE_NUMBER>4ed86aca56cd19243343647742ebbc and 51e8cb99ec987b6155613c2487caa951c0fb3558

I tried some other methods for caching but wasn't able to get any noticeable speed improvements over what's currently present in this pull request.


added binary search and updated css

I've added the binary search algorithm, which is a basic yet essential concept of DSA. Additionally, I've included more information on CSS animations to make it visually appealing.

pls accept my request


Documentation for ngFabEnsureExpression

Documentation for ngFabEnsureExpression added

Coverage remained the same at 98.17% when pulling 786e19cfd27f2e8b1fbbad66646fea065654580f on tushariscoolster:master into 6df71daf88d794d8f38def23d61128feea986c73 on johannesjo:master.

Thank you very much! :)


only show top 10 vulnerabilities in information page

Coverage decreased (-0.05%) to 36.723% when pulling 004a94395d9b5d4c206a8c3a64b40286873862e8 on 40huo:master into 349d6f0d335247c589037ad6739ebc90116af4de on wufeifei:master.


Infinite Loop in ie11

Related issue: https://github.com/soyguijarro/react-storage-hooks/pull/7
reproducible case:
const Potato = () => {
  console.log("hello");
  const [state, dispatch] = useStorageReducer(
    window.sessionStorage,
    "potato",
    () => {},
    {},
  );
  return
Potato
;
};

ReactDOM.render(
  <StrictMode>
    <Potato />
    <Potato />
  </StrictMode>,
  document.getElementById('root'),
);

you will get an infinite amount of "hello"s in the console. Only reproducible on ie11.

Closing as I'm no longer working with this library.


How to update influxdb server in Centos7.9?

I want to update my influxdb from 2.1.1 to 2.4.0 in my centos7.9,
How to update it in my centos7.9? and if I update it, will the previouse data lost?

will my influxdb service abort or interrupt when updating?

There will be a short period of interruption while the service is updated and specifically while it is restarted. As for data loss, I constantly upgrade and have not lost any data yet.

@kbensch Thank you so much!


pull request for e2e test at 12/28/2016 15:56:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add onRef prop to Input component for passing ref to rn text input

This would provide a solution for #74 by enabling accessing a ref on the react-native TextInput component that's the child of the Galio Input component via the proposed new onRef prop, while still enabling using the ref prop on the galio component itself.

Hi @sam1463 ! Thanks for opening up this PR. I'm going to review it when I got more time. This should be really helpful for Galio.
Thanks 🤙🏽


Update resolver

Hello :-)
The DOI foundation recommends this new resolver. Yes, a bit ironic, but it's now encrypted and the old links with the dx subdomain continue to work.
Cheers!

Thanks Katrin for pointing it out.

You're welcome, and thanks for merging :-)


Minor cleanup for Build Task

Remove .fsi files
re-align some methods, trim some redundant spaces
Always build in runningonmono rather that using #if
We don't support Itanium .... no really we don't

@dotnet-bot test Windows_NT Release_ci_part1 Build please


Adding astronomy schema option

As discussed in https://github.com/mantrajs/mantra-cli/issues/67

@PolGuixe can you add me to https://github.com/Zetoff/mantra-cli? I want to push some fixes.

Let's continue on #73. I fixed some bugs on astronomy branch.

@sungwoncho I've added you as a collaborator in https://github.com/Zetoff/mantra-cli


SWARM-944 - Improve swarm.swagger.conf handling.

Motivation
We didn't really handle swarm.swagger.conf well, especially
if hand-written by someone.
Modifications
Look in META-INF/ and WEB-INF/classes/META-INF for it. Deal with
whitespace better. If we find it somewhere, keep it in that location
instead of creating another.
Result
Less buggy?  Maybe?

[X] Have you followed the guidelines in our Contributing document?
[X] Have you created a JIRA and used it in the commit message?
[X] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[X] Have you built the project locally prior to submission with mvn clean install?

Yes, good catch!
On Fri, Mar 24, 2017 at 1:47 PM, Ken Finnigan<EMAIL_ADDRESS>wrote:

@kenfinnigan commented on this pull request.
In fractions/swagger/src/main/java/org/wildfly/swarm/swagger/deployment/
SwaggerServiceActivator.java
https://github.com/wildfly-swarm/wildfly-swarm/pull/443#discussion_r107961998
:

     if (in == null) {

       in = Thread.currentThread().getContextClassLoader().getResourceAsStream("WEB-INF/classes/" + SwaggerArchive.SWAGGER_CONFIGURATION_PATH);

Should this have another check before return one wasn't found?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wildfly-swarm/wildfly-swarm/pull/443#pullrequestreview-28969308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA-TxoakoPCoAgMp4RX5fMT7JKCrca1ks5rpAGygaJpZM4MokpD
.


allow script tags with src to reference esm modules

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

i'm not sure... you could consider it a new feature as well. With jQuery 3.x in place i would consider it more of a bugfix because it makes sure that script tags with and without src attribute behave the same...
Proposed changes
to allow loading of external esm modules this patch will preserve type="module" of script tags with a src attribute.
see the discussion in the forum
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

no test yet, sorry. if you really need a test for this line, i will probably have some time to write one tomorrow.

ohhh... sorry formatting got really messed up on this one...


Removed listnav and background for tagging screens

https://bugzilla.redhat.com/show_bug.cgi?id=1180654

@h-kataria please, review

@dclarizio With the Patternfly layout merge, this PR is no longer needed upstream. Closing.


[ALLUXIO-2327]udate javadoc with active voice "@nogod1995"

https://alluxio.atlassian.net/browse/ALLUXIO-2327
学号：MG1633061

Can one of the admins verify this patch?

Jenkins, add to whitelist

alluxio-bot, check this please

ok to test

Also, could you remove "@nogod1995" from the title?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12060/
Test PASSed.

I have changed the PR title and remove the blank notes in shell/src/main/java/alluxio/cli/AlluxioShell.java, thanks for your advice

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12067/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12091/Build result: FAILURE[...truncated 2553 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/pom.xml to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/hdfs/target/alluxio-underfs-hdfs-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-hdfs/1.4.0-SNAPSHOT/alluxio-underfs-hdfs-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/pom.xml to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/swift/target/alluxio-underfs-swift-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-swift/1.4.0-SNAPSHOT/alluxio-underfs-swift-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/pom.xml to org.alluxio/alluxio-underfs-s3a/1.4.0-SNAPSHOT/alluxio-underfs-s3a-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-s3a/1.4.0-SNAPSHOT/alluxio-underfs-s3a-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/s3a/target/alluxio-underfs-s3a-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-s3a/1.4.0-SNAPSHOT/alluxio-underfs-s3a-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.4.0-SNAPSHOT/alluxio-examples-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/pom.xml to org.alluxio/alluxio-core-server/1.4.0-SNAPSHOT/alluxio-core-server-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server/1.4.0-SNAPSHOT/alluxio-core-server-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server/1.4.0-SNAPSHOT/alluxio-core-server-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/target/alluxio-core-server-1.4.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-server/1.4.0-SNAPSHOT/alluxio-core-server-1.4.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/pom.xml to org.alluxio/alluxio-keyvalue-common/1.4.0-SNAPSHOT/alluxio-keyvalue-common-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-keyvalue-common/1.4.0-SNAPSHOT/alluxio-keyvalue-common-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.4.0-SNAPSHOT/alluxio-keyvalue-common-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/pom.xml to org.alluxio/alluxio-underfs/1.4.0-SNAPSHOT/alluxio-underfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.jar to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/underfs/glusterfs/target/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-underfs-glusterfs/1.4.0-SNAPSHOT/alluxio-underfs-glusterfs-1.4.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/pom.xml to org.alluxio/alluxio-integration/1.4.0-SNAPSHOT/alluxio-integration-1.4.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/pom.xml to org.alluxio/alluxio-keyvalue/1.4.0-SNAPSHOT/alluxio-keyvalue-1.4.0-SNAPSHOT.pomchannel stopped
Test FAILed.

@nogod1995 Are you planning on reopening this? It looks like the latest build failure was caused by trailing whitespace

@aaudiber Thanks for your attention. I have try to fix this problem but things become worse，so I start from the beginning,and create a new PR. Thanks again!


Remove hooked and importFrom ability from link nodes

This is a proposal that needs further discussion before implementing.

Currently, the importFrom attribute of link nodes such as DefinedTypeLinkNode enable users to opt-out of defining the type using TypeNodes and instead grab them from a hooked folder or a named module (such as a package for JS or a crate for Rust using a dependency map).
Whilst this enables renderers to inject "custom types" into the generated code, it is a hole in the information tree and something that will affect explorer or anyone else requiring that information.
This issue propose that we no longer allow link nodes to "link outside of the tree" to avoid information loss.
As for enabling custom type injection for renderers, this could be achieved using special renderer options that lets the visitor know which defined type should be replaced by a custom one. This may even be a better outcome as it'll allow each renderer to decide if they want to inject custom code or not.

Merged in upcoming 0.22 version.


Request: exclude tinybench overhead from the benchmark results

Hi thank you for creating such an amazing benchmarking tool! However the benchmarking result is not exactly what I want.
I have read these issues

https://github.com/tinylibs/tinybench/issues/46
https://github.com/tinylibs/tinybench/issues/65
https://github.com/tinylibs/tinybench/issues/61
https://github.com/tinylibs/tinybench/issues/42
https://github.com/tinylibs/tinybench/issues/143

I think i'm requesting another feature so i write this issue.

For example we write this code to benchmark:
function noop() {}

function fibonacci(n) {
    if (n === 1 || n === 2) return 1;
    let a = 1;
    let b = 1;
    let c = 2;
    for (let i = 4; i <= n; i++) {
        a = b;
        b = c;
        c = a + b;
    }
    return c;
}

const bench = new Bench({ time: 500 });
bench
    .add('noop', () => noop())
    .add('fibonacci 4', () => fibonacci(4))
    .add('fibonacci 20', () => fibonacci(20));
await bench.run();
console.table(bench.table());

and the result is
┌─────────┬────────────────┬──────────────────────┬─────────────────────┬────────────────────────────┬───────────────────────────┬──────────┐
│ (index) │ Task name      │ Latency average (ns) │ Latency median (ns) │ Throughput average (ops/s) │ Throughput median (ops/s) │ Samples  │
├─────────┼────────────────┼──────────────────────┼─────────────────────┼────────────────────────────┼───────────────────────────┼──────────┤
│ 0       │ 'noop'         │ '44.29 ± 0.22%'      │ '0.00'              │ '17078062 ± 0.02%'         │ '22579347'                │ 11289676 │
│ 1       │ 'fibonacci 4'  │ '44.47 ± 0.34%'      │ '0.00'              │ '17019036 ± 0.02%'         │ '22488750'                │ 11244377 │
│ 2       │ 'fibonacci 20' │ '48.05 ± 0.35%'      │ '0.00'              │ '15692678 ± 0.02%'         │ '20812354'                │ 10406179 │
└─────────┴────────────────┴──────────────────────┴─────────────────────┴────────────────────────────┴───────────────────────────┴──────────┘

Refer to this example to reproduce the result.
Hmm I don't think this simple fibonacci algorithm would take that long to run. Or even a noop function takes 44 ns to run. A noop function should take zero time, or less than 1 ns due to the direct function call if it's not inlined.
Let's assume the tinybench overhead is 44.29 ns. By excluding 44.29 ns the benchmarking results will be:

noop: 0 ns
fibonacci 4: 0.18 ns
fibonacci 20: 3.76 ns

I cannot say this results are correct because I don't know if we can just consider the noop benchmark result as tinybench overhead. But at least it shows how we can get close to the correct result.

I tried other benchmarking tools and here're the benchmarking results:

C# BenchmarkDotNet (refer to this example to reproduce the result)

noop: 0.0002 ns
fibonacci 4: 0.1536 ns
fibonacci 20: 8.0300 ns

go built-in benchmark (refer to this example to reproduce the result)

noop: 0.2455 ns
fibonacci 4: 0.9764 ns
fibonacci 20: 8.760 ns

Rust criterion (refer to this example to reproduce the result)

noop: zero time
fibonacci 4: 1.7134 ns
fibonacci 20: 2.4494 ns

Those results are significantly different from the tinybench results.
If we look into the BenchmarkDotNet logs, we will see "OverheadActual", "WorkloadActual", for example:
L286: OverheadActual  15: 53370432 op, 72714400.00 ns, 1.3624 ns/op
L311: WorkloadActual  15: 53370432 op, 500232200.00 ns, 9.3728 ns/op

If we subtract them we can get WorkloadActual - OverheadActual = 8.0104 ns/op, it's pretty close to the average result 8.0300 ns/op.
What BenchmarkDotNet actually does is slightly different from that. You can read How it works. It says BenchmarkDotNet gets the result by calcualting Result = ActualWorkload - <MedianOverhead>.

Before we go any further i have a question:
What's the difference between "bench 1" and "bench 2", is "bench 2" correct? or is there a way to benchmark a super fast code by tinybench?
function fn() {
  // a small fn that only runs for a few nanoseconds
}

function bigFn() {
  // a big fn that runs for a few milliseconds
  for (let i = 0; i < 100_000_000; i ++) {
    fn()
  }
}

const bench = new Bench({ time: 500 });
bench
    .add('bench 1', () => fn())
    .add('bench 2', () => bigFn());
await bench.run();

It's two different experiments that have nothing in common.
I'm not going to explain again here what I have already explained in the link given. Please read it.

OK I understand what you mean now.


Adds assisted-installer-app

The assisted-installer-app is the front-end project for the Assisted Installer.

/ok-to-test

/retest


Refactor networks

This PR makes progress toward refactoring the TransitionNetwork objects to make them easier to understand and easier to reuse for constructing user-defined networks. The changes here are driven both by things that will improve the CodeClimate score, as well as things that will make facilitate some projects (involving new networks) that I'm currently working on.

This is ready for review. It mainly involves

refactoring to reuse code
making many methods private

It also adds some comments about a number of things that don't seem to be used anymore.
Finally, I changed the input file for the tutorial_storage notebook. The was occasionally failing with an error about floats not being subscriptable. This was (I think) fixed by always using a pre-written file, which will be the same on every run (instead of using a file generating during testing.)
I'll give this one 72 hours for review, and will merge on Sunday if no comment.


Add watchdog for gateway services

Use watchdag to monitor and restart caddy/cloud-init and dnsmasq of the gateway

it sometimes works, and sometimes not , may it relate to https://github.com/zero-os/0-orchestrator/issues/666

still same not always work

it still not  stable
Software Version
5cfc4d99b8c58fce0596a1e9551e1a2fefcac1d7

Software Version
012719ca7375c9a5ba500bc403a61a15b0873b53


[style]: Responsive Homepage

What's the style idea?
We need to improve on the homepage in tablet view to make it responsive
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

assigned to you

What's the style idea?
We need to improve on the homepage in tablet view to make it responsive
Add screenshots

Code of Conduct

[x]  I agree to follow this project's Code of Conduct

Please update your branch

Hello , dear admin assign me this one for smashing this issue.


Strange ip coneection

I created an executable for the client computer (ip x.x.10.23) and called it portable.exe
When I connected to the server (ip x.x.10.5) I noticed that it opens a connection with the ip <IP_ADDRESS>
But I do not recognize this ip and it is from outside my country.
Could you tell me what it is about? I don't see it in the source code

https://www.ip-tracker.org/locator/ip-lookup.php?ip=<IP_ADDRESS>

This has been answered several times. It is for geolocation so server can display your clients general location. Read the code its opensource....

This has been answered several times. It is for geolocation so server can display your clients general location. Read the code its opensource....

Thank you for the explanation.

Thank you for the explanation.


Mocks in constructor

I have classA that has constructor dependency on classB.

classB is class, does not have interface and is annotated with Mockable annotation (REEDME instructions) and has its own constructor.

Now I have test for classA but test can't be compiled because problems with automatically generated mock for classB.

Why I need mocks for classB when they are not subject of test for classA?

It works when I create Mock from newly created custom interface.

CI pipelines are ok, and problem is local and flaky.

Usual errors:

Unresolved reference: Function0Mock

Base declaration of supertype 'CoroutineDispatcher' needs opt-in. This is an internal kotlinx.coroutines API that should not be used from outside of kotlinx.coroutines. No compatibility guarantees are provided. It is recommended to report your use-case of internal API to kotlinx.coroutines issue tracker, so stable API could be provided instead. The declaration override must be annotated with<EMAIL_ADDRESS>or '@OptIn(kotlinx.coroutines.InternalCoroutinesApi::class)'

Hi @DavidGrygar
When Mockative generates a mock for a class with a constructor that has dependencies on other classes, then mocks are recursively generated for those dependencies in order to generate a primary constructor for the class.
In your case, since Mockative has to work for all possible classes, then a mock class for classB with a primary constructor is generated, which is used in the constructor for the mock-class for classA.

Mocking an interface is of course much easier, as this does not have any dependencies, and therefore the dependencies are not generated.

Right now the constructor selected by mockative is not necessarily the primary constructor. See https://github.com/mockative/mockative/issues/115#issue-2295572819.

Correct, it is always generated.

I have updated my comment above as I misunderstood your first comment.

@kris098e so it is not bug but feature right?

@DavidGrygar
It is working as intended yes.
But of course, if you think it can be improved I/we are open for discussing other solutions - but not necessarily coding it ourselves 😃


add check method for redis

check.yml is missing. this check does just a redis ping - pong. no master / slave checks are done.

Thank you for contributing to openstack/kolla-ansible!
openstack/kolla-ansible uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Changes for SANTUARIO-555

Changes for SANTUARIO-555: made order of output processors in a chain deterministic and intuitive.

This PR needs the corresponding PR for SANTUARIO-555 for santuario-xml-security-java in order to compile.


ChatGTP failed to refresh auth token 403

from https://chat.openai.com/chat cookie get token , but not refresh auth token

Same! Any solution?

I was facing the same issue, I fixed it by using reload option in command pallete.

I was facing the same issue, I fixed it by using reload option in command pallete.
Do you mean "Reset token" option?

I've tried resetting my 3 tokens multiple times now (just in-case I was missing a section of one when I copied+pasted), but I still keep encountering this 403 error.

I was facing the same issue, I fixed it by using reload option in command pallete.

I keep encountering the same issue, despite using "ChatGPT: Reset token" to refresh my 3 tokens.

I have now tried this using Chrome, Firefox, Edge, and Brave browsers with an associated SSO account. I also created a new account, signed in without using the SSO option, on the Brave browser. I encounter this same issue every time.

I updated to node v18.12.1 and am still encountering the same issue (an old version of node was implicated in one of the closed issues about this 403 error). Used the Brave browser.
E.g. useragent key-value pair:
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

Same here guys

bump

Same here, guys

same here

Same here, guys

Sameeeeeeeeeee

Same here

Same 😢

Hi every body I'm using neovim also, and i was tying to use chatgpt plugin there aswell and i'have problems to make it work aswell. The answer that I was getting is that I don't have enough credits in my chatgpt account. Any way it's wierd also coz I've check it and I didn't use anything but maybe this lead can help someone.

same here

same here

Fixed using official API in v2 release.

Fixed using official API in v2 release.

Where can I download v2 version?


feature: Document what are the derived things, where they are stored, and how a contributor updates them

Feature Description
Document how a contributor updates the derived files under git control.
Document the container image(s) involved and how a contributor updates them.
Document the Helm chart(s) involved and how a contributor updates them.
Document the KubeFlex PostCreateHook(s) involved and how a contributor updates them.
Any other kinds of things?
Document the dependencies among the above.
Proposed Solution
Do it.
Want to contribute?

[ ] I would like to work on this issue.

Additional Context
No response

@MikeSpreitzer isn't  this now addressed in packaging.md and release.md ? can we close this?


Base64-encode CSV

I was experiencing an issue exporting a CSV that included the pound symbol #. The document would clip everything after the first occurrence of the symbol and looks like the browser was interpreting everything after it as a URL fragment.
URL encoding the string didn't seem to work but base64 encoding solved the issue for me.
Any thoughts on either always base64 encoding or adding an option to switch between encoded and and non-encoded?
Thanks for your work on this project!

buildURI has changed a bit since this PR, for example now using blob. Can you take a look at this PR and update with the latest master? @Stanback

@Stanback @mccabemj I've adressed this issue in this PR, please LTMK WYT
https://github.com/react-csv/react-csv/pull/308


Redacting unwanted location information from file pages

This will not be done in Android code but a (Python) script that works on Wikimedia Commons. Comments are welcome. I plan to work on this alone, but if someone is interested, please contact me. (Since it's a one-off job and contains potentially sensitive data collected, I don't want to publish it in the repo.)
In #1599 we agreed to redact file pages that contain location information published inadvertently. I'm working on redacting the information from file pages.

[x] Create a list of the file pages whose first version contain a location template but no EXIF-embedded GPS data. (and categorized as uploaded via the app)
[x] Create a list of the revisions where the first location information remains in those file pages
[x] Prepare a sysop bot to perform the redaction (and get approval)
[x] Edit and remove the first location information where it still remains in the latest version of the page
[x] Redact the revisions from non-sysops
[ ] Ask oversighters of Wikimedia Commons to redact the revisions from sysops (unnecessary?)
[ ] Do above again for new (post-June) uploads
[ ] Create a list of affected people and files and send a mass message.

So far, it appears to involve 938 pages, 3294 revisions and 351 users.

I submitted https://commons.wikimedia.org/wiki/Commons:Bots/Requests/Whymbot. Inputs are welcome. (As always, this is not a vote and we don't exactly need a large number of "supports".)

Is this done now? I saw the related incident wiki page and found the status of this as "on going".

Almost. But I never managed to work on the last item (mass message) mentioned above. It would have been nicer to do that, but after more than one year, I suspect it might be merely confusing than helpful to the receivers of such a message now. I can still try doing that, though.

@whym You are right. I too believe it would be merely confusing if we do it now.
Do you think we can just mention that we never did the mass message part in the incident wiki page and close this as done?

@sivaraam I think that makes sense, and we can probably point to the discussion on this thread for the reason, too.

@sivaraam I think that makes sense, and we can probably point to the discussion on this thread for the reason, too.

Done. I've created https://github.com/commons-app/documentation/pull/12 for this.

@sivaraam Thanks a lot. I'll close this as well.
(Another thing - I never got a response from my request for oversight (which is like deletion of a higher level) by email. The last message I got was an automated one saying my email "awaits moderator approval". I think not oversighting is a reasonable outcome, as it's only for severe cases.)


next-intl does not output index.html file

Description
how to with default language have index.html, i am using azure static web app and it requires that

Verifications

[X] I've verified that the problem I'm experiencing isn't covered in the docs.
[X] I've searched for similar, existing issues on GitHub and Stack Overflow.
[X] I've compared my app to a working example to look for differences.

Mandatory reproduction URL
app router
Reproduction description
how to with default language have index.html, i am using azure static web app and it requires that

Expected behaviour
default language have index.html

I fixed it, for anyone having this problem
import {redirect} from 'next/navigation';
// Redirect the user to the default locale when / is requested
export default function RootPage() {
redirect('/en');
}

I fixed it, for anyone having this problem
import {redirect} from 'next/navigation';
// Redirect the user to the default locale when / is requested
export default function RootPage() {
redirect('/en');
}

@tvone Hi, which file did you add the redirect ?
Since, I moved page.tsx & layout.tsx to folder app/[locale],  there is no page.tsx under folder app.
In static export,  out will missing index.html, I don't how to fix it.

@tvone Hi, which file did you add the redirect ? Since, I moved page.tsx & layout.tsx to folder app/[locale], there is no page.tsx under folder app. In static export, out will missing index.html, I don't how to fix it.

Please create additional files page.tsx and layout.tsx in the app folder

Thank you for your reply. I tried, and fixed it


Change graphql tag after build

Hi, first of all thanks for awesome library, really enjoy it by far.
I have question is there a way to modify output of graphql query?
I really want to remove any require statements from my .bs.js file.
Right now my query look like this:
/* Me_Query.re */
[%graphql {|
  query Me {
      me {
        firstName
        id
        lastName
        ...
      }
  }
|}];

and builded file like this
/* Me_Query.bs.js */

import * as ApolloClient__React_Hooks_UseQuery from<EMAIL_ADDRESS>
var Raw = {};

var query = (require("@apollo/client").gql`
  query Me  {
    me  {
      __typename
      firstName
      id
      lastName
    }
  }
`)

Is there any way I can from
require("@apollo/client").gql
change it to something like this:
import {gql} from 'graphql-tag'
var query = gql...
Thanks in advance.

That is the only way to do the template literal (as far as I know) with ReScript. To do your version we need a change in the ReScript compiler to allow for this, I discussed this with Hongbo multiple times, and he said that it's going to land at some point.
See:
https://github.com/rescript-lang/rescript-compiler/issues/4294
https://github.com/rescript-lang/rescript-compiler/issues/4070

@jfrolich thanks for quick response!
Oh cool, glad to hear.
So if by any chance someone else want to use snowpack and reason-apollo-client with graphql-ppx and encounter "Uncaught error" caused by 'require' in .bs.js file.
Here is what I did - but use it at your own risk we violate lot's of best practices here 😅
In my project I store mutations and queries in folders
/src/mutations
/src/queries

And files with mutations and queries are just [%graphql {| ... |}]; without any additional logic in it.

Add graphql-tag yarn add graphql-tag - right now is the newest is 2.11.0
Add to bsconfig js-post-build (it will execute after compiling every single .bs.js - so this is not good, but works)

//bsconfig.json
 "package-specs": [
    {
      "module": "es6",
      "in-source": true
    }
  ],
  "graphql": {
    "apolloMode": true,
    "extendMutation": "ApolloClient.GraphQL_PPX.ExtendMutation",
    "extendQuery": "ApolloClient.GraphQL_PPX.ExtendQuery",
    "extendSubscription": "ApolloClient.GraphQL_PPX.ExtendSubscription",
    "templateTagReturnType": "ApolloClient.GraphQL_PPX.templateTagReturnType",
    "templateTagImport": "gql",
    "templateTagLocation": "@apollo/client"
  },
  "js-post-build": {
    "cmd": "./graphql-tag.sh"
  },

Create file in /src called graphql-tag.sh
https://gist.github.com/Faliszek/d66449c8a6837a013e59143b5f92df0f

Right now I have like 5 queries and 5 mutations and i didn't notice any slowing down in build.
It is risky but it is only to developing and having super fast rebuild in browser with snowpack ;p

Yes the problem is that you cannot have multiple queries in one file and no code before the query. Probably it can also be solved using a babel plugin.
Another solution is to not use the template tag, but just a plain string for the query. That worked before. I am not sure if reason-apollo-client requires the template tag?

Perhaps I can add configuration to call a function on the query instead of the template tag (gql can also be called as a function). That will definitely work. You lose some performance benefits etc. of the possible gql babel plugin if you don't use the template tag.

Another solution is to not use the template tag, but just a plain string for the query (remove all template tag configuration). That worked before. I am not sure if reason-apollo-client requires the template tag? (I guess it requires it because otherwise it needs to wrap the string query in a gql function at runtime).

We do require the template tag right now. Perhaps I could do some magic and inspect what's coming in as query and dynamically run through gql if necessary.

Perhaps I can add configuration to call a function on the query instead applying a template tag (gql can also be called as a function). That will definitely work. You lose some performance benefits etc. of the possible gql babel plugin if you don't use the template tag.

Yes, that would probably be better than my proposal

Ok I created a configuration option:
See:
https://github.com/reasonml-community/graphql-ppx/commit/5d92a6bd8802049141511c809b75087ecd121823
You can add the "templateTagIsFunction": true to your bsconfig.json or ppxConfig in a query.
It will be automatically pushed to npm under 1.0.2-ca56c96.0

Thanks, i will give it a shot in couple days, see if it works, awesome work

@jfrolich sorry for late response.
Your fix works perfectly.
So here is what i did

Remove hacky solution from bsconfig.json
Update graphql-ppx to 1.0.2-ca56c96.0
3 .Add to bsconfig.json, "graphql": { "templateTagIsFunction": true}
and after bsb -clean-world and bsb -make-world -w

I get result
import * as Client from "@apollo/client";
import * as ApolloClient__React_Hooks_UseMutation from<EMAIL_ADDRESS>
var Raw = {};

var query = Client.gql("mutation UpdateClient($clientId: Int!,  ...");

So i would say, it works perfectly! Thanks for your help.

@Faliszek: It has been released as 1.0.2, see changelog here: https://graphql-ppx.com/docs/changelog

@Faliszek: It has been released as 1.0.2, see changelog here: https://graphql-ppx.com/docs/changelog


[Android] zeroconf.watch Error

Hi . . .I am trying to use this plugin in an Android app, but whenever I start to watch for server, i get an error saying "Error: setsockopt failed: ENODEV (No such device)" . . . What does it mean and how to fix it ?? By the way, for the server part I'm using cordova-plugin-websocket-server . . . Thanks in advance.

did you solve this? is this related to wifi not enbaled?

Not yet . . . I have been busy with other things lately . . . Will get back to it soon .

are you in Android AP Mode? https://github.com/jmdns/jmdns/issues/120?

Please upgrade to 1.2.8 and let me know if it's better

No . . .  Not in Android AP mode . . . I'll try using 1.2.8 very soon . . . I'll be sure to let you know . . .

@Dipayon3D also try disabling cellular data (https://github.com/jmdns/jmdns/issues/116)

Closing old issue. Feel free to reopen.


Pipeline fix

Mark actual code commits and merge commits and maven release commits - this change is in core and github collector
In build job, identify which repo and which branch is getting built - this is in Jenkins collector as well as Jenkins plugin
In program dashboard don't show merge commits and maven release commits on the flow
When a build is collcted, move all the commits from commit stage to build statge if (a) the repo and branch matches and (B) build time is greater than commit time - I am still not sure if I should do this. This is needed when github collector collects commits after the build is collected

LGTM

LGTM


update index.html

Why:
Closes [issue link]
What's being changed:

Check off the following:

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

I want to get a new git

Git.patch


Add ContainerFilesystems to ImageFsInfoResponse

Opening a PR against the master branch as discussed in the original PR https://github.com/Mirantis/cri-dockerd/pull/407#issuecomment-2440421743
Note:
The k8s.io/cri-api version in the master branch is at v0.30.1 following recent changes in commit 3921bcd. This version remains as is, while the v0.3 branch has k8s.io/cri-api at v0.29.10.
Issue
https://github.com/Mirantis/cri-dockerd/issues/408

@nwneisen Could you help rerun the build?

Looks like a problem with GH runner,
Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v1`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/


rf: fix example program to build

This way we can use this program to try out the examples later in the
docs.

I've rebased for the build check update.
Sounds like we can just leave the testing as-is for now.


Ability to remove pages instead of moving them to the book when removing a chapter

Describe the feature you'd like
Currently, when you remove a chapter, all the pages inside are moved to the book. I would like a way to choose whether I want them moved up or actually removed (a checkbox with a clear description).
Describe the benefits this feature would bring to BookStack users
When you want to clean up some stuff, it's really annoying to have to delete all the pages of a chapter before removing the chapter.
Additional context

Hi @bendem,
Thanks for the suggestion.
To be honest, I'd prefer not to have an option as these kind of options can quickly complicate things.
As of v0.31 and the inclusion of the recycle bin, the default logic will be changing here. Deleting a chapter will now also delete the pages within (All get sent to the recycle bin).
This means that within v0.31 (Once released):

If you want to delete the chapter and all pages within, you just delete the chapter.
If you want to keep the pages, you could go to the book sort screen first (Where you can multi-select for quick re-organising) then come back and delete the chapter.

Does that sound like it'd suit your flow?

That's perfect. Better than the original idea.

@bendem Great, Thanks for confirming. In that case I'll close this off since the new functionality has been implemented and will be part of v0.31 which should be released before the end of the year.


fix(olHelpers.js): use HTTPS Mapbox URL

This addresses issue #337. It is a one-character change, changing the protocol from http to https.

:+1: awesome, thx!


[test-operator] Move away from Jobs to Pods

With this PR [1] the test operator dropped the usage of OCP Jobs for
spawning of the test pods.
This change updates the test-operator role so that it works with the
new version of the test-operator that spawns test pods directly through
the OCP Pods object.
[1] https://github.com/openstack-k8s-operators/test-operator/pull/266

/hold
This PRs need to be merged at the same time. The idea is to first get /approved and /lgtm for both of them and then remove /hold at the same time:
Move away from Jobs to Pods  #266
https://github.com/openstack-k8s-operators/ci-framework/pull/2604

recheck


DSRDTR not working

SerialPort version: 4.0.1
NodeJS Version: 4.2.6
Operating System and Hardware: GalliumOS 2.0 (16.04.1)
Are you using Electron/Atom/NwJS?: no
Summary of Problem
RTSCTS flow control is working for a machine interface, but not DSRDTR
Expected Behavior
Actual Behavior
Steps and Code to Reproduce the Issue
From a browser client for rapid-prototyping workflows, e.g.:
http://mods.cba.mit.edu/?program=programs/machines/Roland/mill/MDX-20/PCB
I open a connection to a machine serial server:
http://mods.cba.mit.edu/js/serialserver.js
This opens the serial port with the appropriate flow control:
  if ((flow == 'none') || (flow == 'dsrdtr'))
     port = new SerialPort(device,{baudRate:baud})
  else if (flow == 'rtscts')
     port = new SerialPort(device,{baudRate:baud,rtscts:true})
  port.on('open',function() {
     ws.send('serial port opened')
     if (flow == 'dsrdtr') {
        port.set({dsr:true,dtr:true})
        port.set({rts:false,cts:false})
        }
     })

Characters are then written out one at a time to be able to follow and interrupt progress:
port.write(msg.contents[count],function(){
port.drain(function(err){
if (err)
ws.send('error '+err.message)
else {
ws.send((count+1)+'/'+msg.contents.length)
count += 1
if (count < msg.contents.length)
write_char()
else {
console.log('done')
ws.send('done')
}
}
})
})
With an RTSCTS machine interface this properly starts and stops based on the machine's progress. But with a DSRDTR machine interface the output never pauses.
In a pyserial version:
http://fabmodules.org/mod_server/mod_serial.py
this is handled by manually checking is DSR line:
if (flow == "dsrdtr"):
while (s.getDSR() != True):
time.sleep(0.001)
Is port.set imposing DSR flow control, or does it just set the lines? If the latter, how are they read as well as written?

If you can set DTR but not read DSR, there's no way to implement DSRDTR
flow control, which is required in this case for a machine interface.
If you're already using the tty ioctls, that input should be easy to add.
Neil
On Wed, Oct 5, 2016 at 12:51 PM, Francis Gulotta<EMAIL_ADDRESS>wrote:

Closed #939
https://github.com/EmergingTechnologyAdvisors/node-serialport/issues/939
.

On Wed, Oct 5, 2016 at 12:49 PM, Francis Gulotta<EMAIL_ADDRESS>wrote:

Is port.set imposing DSR flow control, or does it just set the lines?
If I understand you correctly, we just set the lines. Currently we can't
read the DSR lines.


Feature/bullet per shot fix

Abrams shoots 9 bullet per left click, 9x'ing his dps

As we add more and more weapon data, should we consider nesting it under "Weapon"?
And thinking about the future, I have a feeling they will let you change weapons on a char, so could have a DefaultWeapon field that references weapons.json

Will look into this for future PR, as it will require a decently sized rework


Wrapping the gallery inside a grid

It would be fine to provide GridView integration to display gallery fist time

The example app has an awesome sample of a case integrating the gallery with a holistic view of images in the gallery. Therefore, this integration would be awesome as an external screen.

What can be done is an screen in teh exmple app where a GridView in a screen similar to this one.
PRs are welcome 😁.

I will close this issue for now. If you think that your doubt/request has not been understood, feel free to reopen it. Thanks.


use a macro to simplify the 'merge' operation

Codecov Report

Merging #150 (2098ea2) into master (82b946c) will increase coverage by 0.00%.
The diff coverage is 91.42%.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   70.41%   70.41%
=======================================
  Files          88       88
  Lines        8074     8012   -62
=======================================
- Hits         5685     5642   -43
+ Misses       2389     2370   -19

Impacted Files
Coverage Δ

src/serialization/builtin_data_serializer.rs
89.97% <91.42%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b946c...2098ea2. Read the comment docs.

Oh, this is a good one!
Is there a straightforward way to do this operation so that the compiler would check that all the struct fields are merged?

Oh, this is a good one!
Is there a straightforward way to do this operation so that the compiler would check that all the struct fields are merged?

i think the most robust way would be to use a derive macro.
that's probably something that already exists.


feat(List): Use new Braid component

The visual changes include left-aligned numbering and minimised spacing between numbering and content.
BREAKING CHANGE: ListItem, OrderedList and UnorderedList are removed. Use the new List component in Braid 29.1.

There's a regression in .loki/reference/chrome_laptop_MdxProvider_Combination.png with the code block overflowing the list. I'm not sure if this is fixable in Scoobie itself.


Fix typo: and -> any

@veblush

Hi @yueshuaijie, it seems this slipped through the cracks. If you'd like to move this forward, I think you'll need to set your git user identity and amend your commit, then force-pushing the branch. If not, I can close this PR and make this change on your behalf. Let me know!


Proxy with /appzip

Proxying on an application served as appzip does not work.

/proxy/ means nothing in a local setting
remote requests w/o proxy don't work either

Because it's file:///data/data/com.adobe..... all the restrictions of file:// apply.

With the developer app using content-sync plugin, proxying is no longer needed for that case. Closing this down. If you feel like this is still a legitimate issue, feel free to re-open.


MAC M1

Hi, that not usable on mac M1. And also after installing oracledb with rosetta npm.

Hi, i'm not familiar with things that how mac M1 works and will try to figure it out tomorrow, but i think it has something to do with the install path.  In the Edit connection page,  you can click the TEST CONNECTION button and maybe can see more info. Thanks.

Hi, maybe you can try to install oracledb manually, first try to find the path by search vscode-sqltools with searching tool. And then in the data directory, install it.

I try some things

Hi, from https://github.com/oracle/node-oracledb/issues/1349 I guess it won't work for nodejs 18, so maybe you need to install nodejs14 from homepage directly.

mm, ok and that possible to use the right version only for oraclecdb ?

Hi, is it still not resolved ?

obviously not

sorry for not being helpful, if you have any other questions, please let me know.

Can you bump up the version of oracledb to 6?
(Here)[https://github.com/oracle/node-oracledb/issues/1349] it is stated that it works fine with version 6 for arm64 :)

Hi, i have update oracledb to 6.0.1 and please see if it works.

It works :)


The status of this port

Hi,
I notice that this repo hasn't been updated for a while, and wonder what the porting progress into mainline is?
Actually I have a patch, aiming at completing the missing relocation types in current src/debug/elf/elf.go.  But I am still trying to figure out the usage of GerritHub. :)
Thanks.

This port is being upstreamed. It will hopefully be available as part of Go 1.14.


Angular SSR support

Core Library
MSAL.js (@azure/msal-browser)
Wrapper Library
MSAL Angular (@azure/msal-angular)
Public or Confidential Client?
Public
Description
Hello,
As for today MSAL doesn't support SSR for Angular 17 / 18.
I think most of the modren frameworks are heading to SSR and partial hydration solutions.
What are your plans for this topic in the future ? Are you going to work on a solution ?
Also, can you please elborate why this is issue is hard to support ?
Thank.
Tal
Source
External (Customer)

@tnorling any news about this ?