[TS migration] Migrate 'withLocalize.js' HOC to TypeScript

Details
Migration of 'withLocalize.js' to Typescript.

Test code
type ComponentProps = WithLocalizeProps & {
    something: string;
};

function Component(props: ComponentProps) {
    const addressLine = props.translate('common.addressLine', {lineNumber: 2});
    return (
        <Text>
            {addressLine}
            {props.something}
        </Text>
    );
}

const WrappedComponent = withLocalize(Component);

<WrappedComponent something="something" />;

Fixed Issues
$ https://github.com/Expensify/App/issues/24966
PROPOSAL: N/A
Tests

Click and interact with the whole app - withLocalize is used everywhere so any regression will be immediately visible
Test general flows of the app (sending messages, requesting money, logging in)
Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/46095609/ac5cd9cc-63c6-4741-9eb5-6137f9826700

Mobile Web - Chrome
android-web.webm

Mobile Web - Safari
https://github.com/Expensify/App/assets/46095609/79e677f7-bffd-4b56-8c85-2b49609c9ef3

Desktop
https://github.com/Expensify/App/assets/46095609/8ceebe51-ff7e-44a2-9701-ff180a5ff79a

iOS
https://github.com/Expensify/App/assets/46095609/c0b10788-edb3-49df-9e0b-4b13b5b9788b

Android
android.webm

We can start reviewing process & move on with this PR! @blazejkustra @MaciejSWM

@blazejkustra Don't forget to remove HOLD from PR title :)

@hoangzinh Would you be able to work on reviewer checklist asap? This issue blocks >20 other migration PRs, I would highly appreciate your help here! 😄

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


NIC Aliases are not removed when updating the template in Sunstone

Description
When a VM template is updated using Sunstone and you remove an alias, it isn't removed at the end.
To Reproduce
Have a template with alias, remove one of them and click on update. Finally check the template and the alias is there.
Expected behavior
The alias should be removed from the template.
Details

Affected Component: Sunstone
Version: 5.10.x and master.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PRs to merge:
• one: #4180
• docs: waiting for release


Implemented Customised Floating Action Button

Description
Implemented Floating Action Button as required.
Fixes #22
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Manual testing
[ ] Widget testing
[ ] Unit testing

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Congrats @AdiAr11 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐
SignIn / SignUp in ClueLess Website .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

@Debajyoti14 Thank you!


New Extension: Title

Description

Enter your title to get it capitalized properly according to the The Chicago Manual of Style
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

This is a duplicate of https://github.com/raycast/extensions/pull/3491 :/

closing in favor of https://github.com/raycast/extensions/pull/3491


Test

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Steps to reproduce

Expected behavior
Tell us what should happen
Actual behavior
Tell us what happens instead
Crashlog
If something causes an exception paste full stack trace + Exception here
Configuration
Version of the Plugin: e.g. 1.0.0 / 1.0.1-alpha3
Platform: e.g. iOS 10.1 / Android 4.4 / ... (including version!!! e.g. Android 5.1 / i0S 10)
Device: e.g. HTC Sensation /i Phone 7 ...

Hi @smstuebe,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.


Sybase: wrong database for procedures

System information:

Windows 10
5.3.2
jdk-11.0.2
None

Connection specification:

SAP ASE 16.0
jconnect
ssh tunnel

Describe the problem you're observing:
Creating a new ER diagram. The wrong set of procedures is shown for a user database. The procedure names are from the master database. Tried with and without the user database as the actual database.
Steps to reproduce, if exist:
ER Diagrams
Create new ER diagram
choose a server
choose a database
choose a owner
choose procedures
Include any warning/errors/backtraces from the logs

This is not related to ER diagrams. It is wrong procedure reading function (it doesn't use database name in query).
Thanks for the bug report


Update getMetricsFromPort to infer port number

Problem: The getMetricsFromPod function assumes that metrics are exposed
on port 8080. This function fails to retrieve metrics from the olm or
catalog operator when the port is changed.
Solution: Name the port in each of the deployments and update the
getMetricsFromPod function to infer the port number from the
deployments.

/lgtm

/lgtm


ConfigurationManager.GetConfigurationAsync() doesn't return JsonWebKeySet in 6.8.0

We recently upgraded Microsoft.IdentityModel.JsonWebTokens 5.5.0 to 6.8.0, and noticed that the ConfigurationManager object no longer populates the JsonWebKeySet property of the OpenIdConnectConfiguration. This is the code:
var configurationManager = new ConfigurationManager<OpenIdConnectConfiguration>(
                metadataAddress: this.AuthorityUri + "/.well-known/openid-configuration",
                configRetriever: new OpenIdConnectConfigurationRetriever());

var configuration = await configurationManager.GetConfigurationAsync();
var configJson = JsonConvert.SerializeObject(configuration);

This is the serialized configuration object we get back in 5.5.0:
{
    "authorization_endpoint": "https://my-service:52044/not-implemented",
    "issuer": "https://my-service.com",
    "jwks_uri": "https://my-service:52044/keys",
    "JsonWebKeySet": {
        "keys": [
            {
                "e": "foo",
                "kid": "foo",
                "kty": "RSA",
                "n": "foo",
                "use": "sig",
                "x5t": "foo"
            },
            {
                "e": "foo",
                "kid": "foo",
                "kty": "RSA",
                "n": "foo",
                "use": "sig",
                "x5t": "foo"
            }
        ],
        "SkipUnresolvedJsonWebKeys": true,
        "signing_key": "foo"
    },
    "SigningKeys": [
        {
            "HasPrivateKey": false,
            "PrivateKeyStatus": 1,
            "KeySize": 2048,
            "Parameters": {
                "D": null,
                "DP": null,
                "DQ": null,
                "Exponent": "foo",
                "InverseQ": null,
                "Modulus": "foo",
                "P": null,
                "Q": null
            },
            "Rsa": null
        },
        {
            "HasPrivateKey": false,
            "PrivateKeyStatus": 1,
            "KeySize": 2048,
            "Parameters": {
                "D": null,
                "DP": null,
                "DQ": null,
                "Exponent": "foo",
                "InverseQ": null,
                "Modulus": "foo",
                "P": null,
                "Q": null
            },
            "Rsa": null
        }
    ],
    "token_endpoint": "https://my-service:52044/token"
}

This is what we get in 6.8.0:
{
    "AdditionalData": {
        "additionalData": {},
        "authorizationEndpoint": "https://my-service:52044/not-implemented",
        "claimsParameterSupported": false,
        "httpLogoutSupported": false,
        "jwksUri": "https://my-service:52044/keys",
        "logoutSessionSupported": false,
        "requestParameterSupported": false,
        "requestUriParameterSupported": false,
        "requireRequestUriRegistration": false,
        "tokenEndpoint": "https://my-service:52044/token"
    },
    "AuthorizationEndpoint": null,
    "CheckSessionIframe": null,
    "ClaimsParameterSupported": false,
    "EndSessionEndpoint": null,
    "FrontchannelLogoutSessionSupported": null,
    "FrontchannelLogoutSupported": null,
    "HttpLogoutSupported": false,
    "IntrospectionEndpoint": null,
    "Issuer": "https://my-service.com",
    "JwksUri": null,
    "JsonWebKeySet": null,
    "LogoutSessionSupported": false,
    "OpPolicyUri": null,
    "OpTosUri": null,
    "RegistrationEndpoint": null,
    "RequestParameterSupported": false,
    "RequestUriParameterSupported": false,
    "RequireRequestUriRegistration": false,
    "ServiceDocumentation": null,
    "TokenEndpoint": null,
    "UserInfoEndpoint": null
}

Looks like the objects serialize entirely differently between the two versions now, but the main concern here is that "JwksUri" is null in 6.8.0 which I believe is why "JsonWebKeySet" is null.
This is how the configuration object is being populated on the server side:
/// <summary>
/// Get the OpenID Configuration.
/// </summary>
/// <returns>The Configuration.</returns>
[HttpGet(Name = "ConfigurationController.GetConfiguration")]
[ProducesResponseType(StatusCodes.Status200OK)]
public IActionResult GetConfiguration()
{
    var requestedUrlBase = $"{this.Request.Scheme}://{this.Request.Host}/";

    var configuration = new OpenIdConnectConfiguration
    {
        Issuer = this.tokenIssuer.Issuer,
        TokenEndpoint = requestedUrlBase + Routes.Token,
        AuthorizationEndpoint = requestedUrlBase + Routes.NotImplemented,
        JwksUri = requestedUrlBase + Routes.KeySet,
    };

    return this.Ok(configuration);
}

Is there anything extra needed to get the keysets back?

@arianmotamedi this is related to using an internal version of newtonsoft.
We are working on a fix.
see: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1516

@arianmotamedi closing as we think #1516 will solve the issue.
Please re-open if this is not the case.

I can't reopen the issue, but this is still happening in 6.15.1 😞

@arianmotamedi if you write:
string configJson = OpenidConnectConfiguration.Write(configuration);

instead of
var configJson = JsonConvert.SerializeObject(configuration);

You will see better results.

I did a workaround and was able to fix the issue
`    var configurationManager = new ConfigurationManager(
issuer + "/.well-known/jwks.json",
new OpenIdConnectConfigurationRetriever(),
new HttpDocumentRetriever());
var discoveryDocument = configurationManager.GetConfigurationAsync().Result;

if (discoveryDocument.SigningKeys.Any())
{
    keys = discoveryDocument.SigningKeys.ToList();
}
else
{
    foreach (var keyValPair in discoveryDocument.AdditionalData)
    {
        var signingKeysData = JArray.Parse(keyValPair.Value.ToString());

        foreach (JToken rsaKey in signingKeysData)
        {
            JsonWebKey jsonWebKey = new(rsaKey.ToString());
            keys.Add(jsonWebKey);
        }
    }
}

return keys;

}`

This is a workaround not a fix though

I've got the same issue in 7.5.2 and the workaround works but looks ugly.

I also have this issue in 7.6.0

I'm definitely setting it


Convert Groovy gradle files to Kotlin DSL

Hey!
This is just a suggestion and I wanted to know what you guys thought about it. Feel free to close it, if it does not make sense.
I noticed that all the gradle files are in Groovy, what do you guys think about converting it to Kotlin DSL?  I saw that the NowInAndroid app has this, but for instance Accompanist does not. Is there a reason for not converting? :)

I'm for it.
I use kotlin build files exclusively on own projects. Our build came from accompanist, so that's why.
But let's wait for others to weigh in.

That makes sense! Will gladly help and contribute if this is something we want :) I agree, let's wait for others to weigh in.

I'm in! :)

Are there more people that needs to weigh in on this? :)
I guess this is something that would be nice to do in multiple PRs?  Is there anything that should be considered when doing this? :)

I'd recommend reading this doc first, there is a suggestion for first migration step.
Multiple small PRs sounds good, if possible, maybe module by module after taking the first migration steps?

That sounds great! I think the first step docs you sent me was gold! 🙏😊

Cc @alexvanyo in case you want to share approach for accompanist.


Apply json transformation with ReplaceToken

I've successfully managed my token replace inside the web.config, now in the same application I've a appsettings.json with only one entry that's used from a module that's cross from  MVC / .NET Core
The structure is the following

{
  "ConnectionStrings": {
    "default": "server=xxx;database=xxx;user id=sys.xxx;password=123456;Application Name=ABC;"
  }
}

How can I tell the token replacer to subtitute it?
I've tought of

{
  "ConnectionStrings": {
    "default": "__default__"
  }
}

And to put inside the parameters.xmls
parameter name="default" description="doesn't matter" defaultvalue="default" tags=""
parameterentry kind="jsonFile" scope="\appsettings.json" match="/configuration/default/add[@key='default']/@value"/
lt&;/parameter
But I'm not sure of kind and if this's the right approach
Consider I've in the drop folder just the compressed file as you've specified inside the guide
Thanks and please excuse me if I bothered you

Yes, you can do exactly that (with the parameters.xml file). The tricky part is getting the XPath to work. If you're using the latest Azure DevOps (VSTS) "IIS Deploy Task" or "Azure Web App Deploy Task" then you actually can do json and xml substitutions inline without needing the tokens at all. See this post for how this works.


Presentation software

Description to follow

Hello, I think this is the correct issue.

This is why it is always worth been a bit cheeky and asking for 20-30 minute experimental slot.
I'd be really grateful if I could do a practice run/talk through format in early August online if people are around. It is based on previous talk here with statistics and core-physics developments.
https://www.aber.ac.uk/en/is/it-services/elearning/networks-and-events/networks-and-events-learning-teaching-conference/conferencearchive2020/
Journeys in live polling: Using Mentimeter in reverse gear to explain physical science concepts
Dr Maire Gorman (She/her), University of Bristol, University of Sussex
<EMAIL_ADDRESS>Mentimeter is one of many versatile online teaching tools which can be used by educators to ask a variety of question types to provide them with real-time feedback of students evolving comprehension of new concepts and overall engagement.
In this workshop, I will guide participants through a series of interactive activities to demonstrate how Mentimeter can be used as a vehicle for actually explaining concepts in the first place i.e. using in reverse gear.
I will give examples of how Mentimeter can be used to a) gauge student attitudes, b) facilitate inter and intra-cohort sharing of ideas and student-inspired content to invigorate and increase motivation, c) create real-time visualisation of student-generated data and d) showcase abstract computational methods used in cutting-edge atmospheric modelling using gamification principles. I will demonstrate how to use principles of neuroscience to develop incremental series of questions which delineate and reinforce fundamental concepts.
I will share some of the harsh (!) lessons I’ve learned with pragmatic tips for incorporating into both small, large and mixed cohort teaching.
My new email is<EMAIL_ADDRESS>

Hi @DrMaireGorman I think this would make for a great meeting! I will open a separate issue to track this, and please update me with a date in August that suits when you know one.


automated testing with Jest

Automated testing and can be added to the GitHub actions.
Referencing discussion #33.

@WarenGonzaga for this issue, does this only include the installation of jest or all the tests for all https apis?

Installing the JEST and testing the HTTP APIs support.

Hi, @princejoogie is this added to your last PR or not? Are you still working on this?

Hello @WarenGonzaga, changes are in my local although its not yet finished. been busy with work still

Hello @WarenGonzaga, changes are in my local although its not yet finished. been busy with work still

Thanks, I assigned it to you ;)

Update on this @princejoogie? ✨

Closing this now as per #39


F3D final alpha blending is incorrect

A proper alpha blending must pre-multiply the colors by the alpha value and do the compositing in the linear color space.
A comment have been added in the render pass code. More investigation is needed.

Do you have a screenshot to illustrate the bug ? I have no idea how to recognise it.

Any news on this @Meakk ?

It's not urgent, I don't plan to work on it anytime soon

@Meakk care to improve the issue description so that help-wanted label could be added ?

I need time to clarify that, what about a label workflow: investigation or workflow: research?

Indeed, that seems needed, I will finish my current pass on issues and think about a complete workflow.


Implement datafile permission checking

Extend data file model+controller to allow granular access to the various files

Self braindump - the two object model for permissions is nice because it gives us the ability to do user access to a whole file class as well as individual files, but probably having two DB tables is overkill and I should refactor to a generic permission table that has a column for file id and a column for file class and both are optional - with validation to make sure at least one is set happening app-side

This will also make permission checking a lot easier as we can do select user from permissions where user_id = X and (file_id = Y or file_class = Z) instead of making a query with a join between the two tables

Done as of https://github.com/datacite/saluki/commit/e14ad700ae04b758251ef0cba9d61b97f2465bc4
Will move the comments above to a new issue


NO-ISSUE: Remove duplicated version of @patternfly/react-core from the lock file

A PR has introduced a second version of @patternfly/react-core in the lock (4.276.12) and set this version for some packages. This version (4.276.12) breaks the UI of SLWT.
Considering that we already had 4.276.6 being used, I'm not sure why the lock has included this new version.
To fix that, I simply ran pnpm bootstrap from the version of the lock file before the PR.
Now, all packages are back to 4.276.6.
Anyway, I opened an issue to investigate why SLWT UI breaks on 4.276.12. See https://github.com/apache/incubator-kie-tools/issues/2095

The version specified in the package.json files was correct. syncpack does not look at the lock file, does it?
Now, why did bootstrap choose to install a new version instead of using the one we already had?

@thiagoelg do you remember doing anything differently that could have resulted in that behavior?

Not really, but my PR took a while, and multiple merges with main... maybe in one of those merges a conflict was not solved properly :confused:

@tiagobento @caponetto @thiagoelg I had changed the version of this dependency from 4.276.12 to 4.276.6 during my PR migrating components from kogito-apps. So if this task was started before its merge and some conflicts happened, that might have been the issue indeed.


Use the get_dummies function in numpy instead of pandas

At the StudentAdmission notebook: it said that "Use the get_dummies function in numpy in order to one-hot encode the data" ,but I it's available on Pandas

Thanks, fixed.


onSuccess not called in SupaSocialsAuth

Bug report
Describe the bug
onSuccess not called in SupaSocialsAuth
Accoding to the readme https://github.com/supabase-community/flutter-auth-ui#social-auth
this was intended to work as the other auth flows do.
To Reproduce

Set a function to SupaSocialsAuth(onSuccess)
Set a breakpoint or print something in the function body.
Run login flow
Breakpoint/print is never triggered.

Expected behavior
onSuccess should be called in the case of SupaSocialsAuth as it is with the other auth flows.
Additional context
This appears to be due to  signInWithOAuth being implemented as an extension to GoTrueClient and therefore not being able to call notifyAllSubscribers. The pkce flow to the external provider is also kind of opaque from the perspective of signInWithOAuth, we're just launching the url so there's not a great way to know for sure that it succeeded from that point in the code.

The onSuccess handler should get called after you complete the authentication flow and come back to the app as long as you go back to the same page.
If anything is not working, could you provide more details on how to reproduce the issue? What platform are you running the app on? Do you have an active session after completing the OAuth login flow and not see a onSuccess handler being called, or are you not signed in at all after completing the OAuth flow?

Yea, no problem!
Platform is Flutter/Dart and I do have an active session after completing. No trouble grabbing the session information with supabase.auth.onAuthStateChange.listen, it's just onSuccess is never called.

@dannypurcell
Thanks for the info, and I wanted to ask what platform as in it is on Android, iOS, web or desktop.

Ah, my build targets are all three plus Windows and Linux, but in this case I've been testing on Web.
And I think I see what you're getting at there.
Looking in to the code flow further, I think what may be happening is just that the SocialsAuth widget is not mounted at the point in time when Supabase.instance.client.auth.onAuthStateChange has a session.
When I first logged this issue I was under the impression that the /authorize call was somehow "out of band" as it were, that the Stream registration was still valid after we started the login prompt process, which would be the case if we were using a popup dialog, I think. At least on the Web platform though, I see the launchUrl call is targeting _self which is what makes the tab navigate off and therefore unload the app.
Once we have the auth code and get redirected back to the app domain, we're on a fresh load of the app so the subscription to the onAuthStateChange stream has been garbage collected already and my GoRouter redirect, which is set up to send the user to the /login route whenever Supabase.instance.client.auth.currentSession is null, sees that we have a session now so the SocialsAuth widget is not loaded in a context where that subscription would ever see the initialSession event.
I actually put that check in the router after logging this but I must have been doing something else to end up not loading the login widget again earlier, I've been doing a lot of experimenting and learning Supabase with this app.

Thanks for looking in to this with me and for asking good questions! I appreciate it!


Wrong send friend request icon?

The icon for sending people a friend request through the popup modal resembles a settings icon
Go to a server, select any member and view their profile. On the left side the 2nd to last button resembles a settings wheel. Was that intentional?
Discord channel: Stable
OS: Windows
Mod: Better Discord
Discord language: English

Nope, Discord doesn't provide any information to differentiate between "Send Friend Request" and "Send Message".
So I placed a cog icon instead.


Feature/data grid custom sorting

What does the pull request do?

Adds Sorting event that allows to change SortDescriptions before sorting or replace Items source with sorted by custom algorithm and set Handled to "true". Event API is same as in WPF and WCT (WindowsCommunityToolkit), sorting implementation is a bit different though.
Adds ICompare argument to DataGridSortDescription.FromPath method, so it is easier to define sorting without creating custom DataGridSortDescription.
Changed DataGridSortDescription.Descending (bool) to DataGridSortDescription.Direction (ListSortDirection) to be in-line with WPF. In WCT they have custom enum with same values.

What is the current behavior?
It is impossible to define custom sorting algorithm.
What is the updated/expected behavior with this PR?
It is possible to define custom sorting algorithm.
Checklist

[ ] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

Breaking changes
DataGridSortDescription.Descending is now obsolete - "Use Direction property to read or override sorting direction."
DataGridSortDescription.FromPath(string, bool, CultureInfo) is now obsolete - "Use overload taking a ListSortDirection."

@grokys test is failing "Avalonia.LeakTests.ControlTests.Attached_ContextMenu_Is_Freed [FAIL]".
It doesn't seem to be related to this PR.

Should we make DataGridSortDescription.SwitchSortDirection public as well?

@MarchingCube done.

@maxkatz6 Thanks for this feature. But I tried to use it and found that it lacks one thing:
If you want to fully override sorting you have to handle multi-column sorting cases. To do this PointEventArgs is needed to understand Ctrl/Shift modifier keys are pressed. There is no such issue in WPF, because we have static Keyboard.IsKeyDown(), but in Avalonia we don`t have it.
Do you have an idea how about good solution here?

@stepangovorko it's not always possible to get current keyboard state in crossplatform environment, but you can handle keydown events and save previous state, that you cab handle. You probably will need to register handler in Tunnel mode instead of Bubble (alternative to PreciewKeyDown).


It's hard to implement the Dymamic Multi-Pooling

I have reviewed the code and it's very cool. But the Dymamic Multi-Pooling is not implemented in the code. I'm trying to work it out but I found it's hard to implement.

I have reviewed the code and it's very cool. But the Dymamic Multi-Pooling is not implemented in the code. I'm trying to work it out but I found it's hard to implement.

When I run the python Script.py 2 1 (argument identification),an error occured:
Argument IDENTIFICATION start.
2021-11-18 10:33:16.364114: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance-critical operations:  AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-11-18 10:33:16.381871: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x1ae761c7fc0 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2021-11-18 10:33:16.384746: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
Traceback (most recent call last):
File "Script.py", line 39, in
model = Model(sentence_length=hp.max_sequence_length,
TypeError: init() got an unexpected keyword argument 'pos_tag_max_size'
after I commented the pos_tag_max_size ,another assertion error occured:
TRAIN START
epoch: 1/20
39 39 20 39 20 25
Traceback (most recent call last):
File "Script.py", line 168, in
x, t, c, y, pos_c, pos_t, _ = dataset.next_train_data()
File "D:\pythonProject\event-extra-DMCNN-others\Dataset.py", line 169, in next_train_data
assert len(words) == len(marks) == len(pos_taggings) == len(index_words) == len(pos_candidate) == len(pos_trigger)
AssertionError
the  39 39 20 39 20 25 represents the assert items respectively
After I commented the assert len(words) == len(marks) == len(pos_taggings) == len(index_words) == len(pos_candidate) == len(pos_trigger):
TypeError: int() argument must be a string, a bytes-like object or a number, not 'list'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "Script.py", line 169, in
argument_train_step(input_x=x, input_y=y, input_t=t, input_c=c, input_c_pos=pos_c,
File "Script.py", line 129, in argument_train_step
_, loss, accuracy = sess.run([train_op, model.loss, model.accuracy], feed_dict)
File "D:\anaconda2020\lib\site-packages\tensorflow\python\client\session.py", line 957, in run
result = self._run(None, fetches, feed_dict, options_ptr,
File "D:\anaconda2020\lib\site-packages\tensorflow\python\client\session.py", line 1150, in _run
np_val = np.asarray(subfeed_val, dtype=subfeed_dtype)
File "D:\anaconda2020\lib\site-packages\numpy\core_asarray.py", line 85, in asarray
return array(a, dtype, copy=False, order=order)
ValueError: setting an array element with a sequence.
Looking forward for your reply,appreciate it!

一样的问题

都是怎么复现的啊？太难了，整了好长时间了。还是弄不出来啊，太废物了

**huyankun2020022098 ** commented on 20 Mar

我也是！！崩溃了


Can't compile project with Xam.Plugin.Geolocator

Bug Information
Hi guys,
I'm trying to use Xam.Plugin.Geolocator to get user's current location.
I've installed following:
==> Xam.Plugin.Geolocator
==> Plugin.Permissions
==> Plugin.CurrentActivity
I've added following code snippet in MainActivity.cs
    public override void OnRequestPermissionsResult(int requestCode, string[] permissions, Permission[] grantResults)
    {
        PermissionsImplementation.Current.OnRequestPermissionsResult(requestCode, permissions, grantResults);
    }

There is a MainApplication.cs class in Android project too.
I'm compiling against Android API 26 (also tried with API 25)

But while building the entire project, I'm getting following errors:

CS0115 'MainActivity.OnRequestPermissionsResult(int, string[], Permission[])': no suitable method found to override
CS0104 'Permission' is an ambiguous reference between 'Plugin.Permissions.Abstractions.Permission' and 'Android.Content.PM.Permission'

Interestingly, I was able to compile and run that sample project. But I can't make it work for my own project.
I must doing something wrong or missing something... What am I missing?
Version Number of Plugin:
Device Tested On:
Simulator Tested On:
Version of VS:
Version of Xamarin:
Versions of other things you are using:
Steps to reproduce the Behavior
follow your github readme.txt
Expected Behavior
Able to compile my project
Actual Behavior

CS0115 'MainActivity.OnRequestPermissionsResult(int, string[], Permission[])': no suitable method found to override
CS0104 'Permission' is an ambiguous reference between 'Plugin.Permissions.Abstractions.Permission' and 'Android.Content.PM.Permission'

Code snippet
Screenshotst

I suggest posting on the https://forums.xamarin.com/ as this seems more to be a configuration issue than a bug :)
At first glance I would guess you have an issue with your implementation of the permissions plugin where you are not handling the fact that a permission doesn't exist on the version of android you are running

Remove:
using Plugin.Permissions.Abstractions;
from main activity.

or change to this:
public override void OnRequestPermissionsResult(int requestCode, string[] permissions, Android.Content.PM.Permission[] grantResults)
{
    Plugin.Permissions.PermissionsImplementation.Current.OnRequestPermissionsResult(requestCode, permissions, grantResults);
}

I have updated my docs/readme.txt

The problem is the version of Plugin.Permissions, only works with 2.2.1.  It doesn't work with version > 2.2.1


Fix launch warnings for MTC tutorial

Description
This PR fixes the following warnings when launching the MTC demo:
[ERROR] [1678136118.485318346] [moveit.ros_planning_interface.moveit_cpp]: Failed to initialize planning pipeline 'trajopt'.

[ERROR] [1678136118.493854644] [moveit.ros_planning_interface.moveit_cpp]: Failed to initialize planning pipeline 'lerp'.

These two errors are caused by MoveIt Configs Utils trying to load all files that match the *_planning.yaml files available in MoveIt Resources (see #521). The fix for this is to specify the desired planning pipelines (OMPL, CHOMP, and Pilz), similarly to how it is done in the Quickstart launch.
[rviz2-1] [WARN] [1678136119.251836273] [moveit_ros.robot_model_loader]: No kinematics plugins defined. Fill and load kinematics.yaml!

This is caused by not providing RViz with robot_description_kinematics, which this PR intends to fix.

As a side note, I believe there are some issues with the tutorial as is, as I'm currently only seeing planning failures from the tutorial. That, however, is an independent issue than this PR (which is just to fix some warnings when running ros2 launch moveit2_tutorials mtc_demo.launch.py. Just thought I'd mention it here as a word of warning if anyone tests the tutorial.

e issues with the tutorial as is, as I'm currently only seeing planning failures from the tutorial. That, however, is an independent issue than this PR

@stephanie-eng Can you open an issue to track this?


New Release

Hey,
Sorry to bug you again, but the last release of this package has been at the beginning of this year and there were few issues closed since then, could you make a release to pypi? That would allow us to package your application, rather than our fork
Of course, this could be done in CI manner with Travis or something else in order not to require your time.

I did it.


IKEA STARKVIND air purifier E2007

Is it possible that this device is supported in the plugin? Now messages in Domoticz
2022-01-14 11:39:31.945 Error: Zigbee2MQTT: 0xcc86ecfffe666905: can not process numeric item "fan_speed"
2022-01-14 11:39:31.945 Error: Zigbee2MQTT: 0xcc86ecfffe666905: can not process numeric item "pm25"
2022-01-14 11:39:31.946 Error: Zigbee2MQTT: 0xcc86ecfffe666905: can not process binary item "led_enable"
2022-01-14 11:39:31.946 Error: Zigbee2MQTT: 0xcc86ecfffe666905: can not process binary item "child_lock"
2022-01-14 11:39:31.946 Error: Zigbee2MQTT: 0xcc86ecfffe666905: can not process binary item "replace_filter"
2022-01-14 11:39:36.257 Error: Zigbee2MQTT: 'onMessage' failed 'TypeError':'string indices must be integers'
ZIgbee2Mqtt:
fan (state, mode), fan_speed, pm25, air_quality, led_enable, child_lock, replace_filter, linkquality

Thanks!

Yes, sure, just create a ticket with a request for feature support and fill in all required details


Redesign JSON builder APIs and add validation.

Please focus on reviewing the az_json_builder.c changes (along with the  corresponding az_json.h API and documentation changes).
Changes:

Added validation to make sure users cannot unknowingly build invalid JSON.

This can move to precondition checks to reduce overhead since the intent is to catch dev time bugs.

Modified the API to avoid reliance on building az_json_token and added append_container_end API so callers don't have to think about array vs. object.
Make sure strings that the user passes to the APIs are properly escaped according to the JSON RFC.
Updated documentation.
Updated the token kind enum and included a NONE, which is the initial value where no token is written.
Moved the "stack" logic into a single place for easy debugging (az_json_private.h), following single responsibility.

TODO (in subsequent PRs):

[ ] Support for non-contiguous buffers
[ ] Add more unit tests, including negative testing.
[ ] Remove az_json_pointer.
[ ] Post-preview: Decide whether we want to add support for writing an existing JSON within an az_span, raw, without any validation.
[ ] Post-preview: Decide whether we want support for writing formatted JSON or otherwise if we should remove the options.
[ ] Post-preview: Add base64 encoding support for adding byte arrays.

/check-enforcer reset

/check-enforcer evaluate

/check-enforcer evaluate

FYI, responding to comments/threads within a bulk PR review breaks threading and ordering of things. It also displays the comment twice. I suggest avoiding responding to GitHub conversation threads while doing a bulk review of a PR, and come back later to respond to threaded conversations after you are done with the review.


Breadboard mount

An STL file to be 3D printed. Holds the person sensor PCB and jam-fits into the center slot of a normal breadboard. Holds the sensor at a good angle for hands free testing.

Photos here: https://www.thingiverse.com/thing:5783358


Revert "Unpoison thread_local variables for MSAN (#228)"

This reverts commit e2d3d0bf24884e948e7e3e14888d921d4ad7e808.
This change is causing lots of MSAN failures in chromium.

FYI @tanderson-google


Add jwt keys handler

What
Added jwt keys handler
How to review
Check jwt-keys endpoint  working as expected.
Who can review
@franmoore05

I get an error message when I try to access the /jwt-keys endpoint which says "open static/keys/jwt-keys.json: no such file or directory".
Are there some additional instructions required to decrypt the relevant files before running, or some automated script we could add to do this as part of running the service?

Added make prep command in the makefile to decrypt all the necessary files.

Added make prep command in the makefile to decrypt all the necessary files.

Could this also be added to when the application is run in the docker stack to make this easier to use?  Currently I have to run this separately in the app and then refresh the docker container.  It should all be available when the make up command is run in the docker stack also.


Sometimes GUI elements desapear

Randomly, all GUI elements desapear and they don't come back even after I restart the app. The weird thing is that all elements (list of devices, sliders, context menu) still work, I just can't see what I'm clicking on.
Edit: Windows 7 64

this is the most magical bug to date :+1:
I'll need some more info on that, if you're using any windows UI customization, like custom themes with modified uxtheme etc

Nevermind. This is probably a problem with my system since It's happening with other apps.
Thanks!


How to delete fragment in backStack?

Hey I have a problem in my stack I want to delete to fragments which are not on the top of the stack, while I push onto a different. How would you do this?

val firstSuggestion = fragmentManager.fragments.first { it.javaClass.name == SuggestionSearchFragment::class.java.name }
val firstSearchResult = fragmentManager.fragments.first { it.javaClass.name == GreenSearchResultsFragment::class.java.name }
val indexFirst = fragmentManager.fragments.indexOf(test)
fragmentManager.beginTransaction().remove(firstSuggestion).commitNow()
fragmentManager.beginTransaction().remove(firstSearchResult).commitNow()
fragmentManager.fragments[indexFirst] = null

it removes the fragment, but then when i pop back the hole stack, I see empty pages on the positions, where the fragments were before removing

If your Fragment is already in the backStack, you can't delete the Fragment by remove().
And you can only delete Fragment from the top of the stack.

mhh yeah already read that it is only allowed to delete fragments from top of the stack, but I thought there is maybe an option to update the backstack after deleting fragments, which is possible....only the backstack is the problem :(
but thanks I will search for a workaraound or solution for my problem


update Swift Package of HLPDialog

good day
I add new localization (Arabic Language) to the project , but when I add the swift package to the IOS project , the Arabic localization is not available ,
after checking the project page , I found that the swift package is not updated as master .
is there any way to update it ?
thank you

Sorry for the late reply.
Assuming you are using the NavCog master branch.
It refers to the swift-package branch of HLPDialog, so we need to add the Arabic language support to the branch too.

I have merged changes in master into swift-package branch.
Could you try it?

hello , when I add it again , I didn't found the arabic .

thorough add package in Xcode

How about trying File -> Packages -> Update to Latest Package Versions ?

thank you , its updated now .


Wait for adjustCarryType to complete before considering execute complete

WeaponAuxiliaryAction.execute calls Actor.adjustCarryType (which is async) but doesn't wait for it to complete. This means that if we call WeaponAuxiliaryAction.execute programmatically, even with an await, then Actor.adjustCarryType will not have completed by the time execute's returned Promise is resolved, and there is no way to determine when the adjustCarryType operation has actually completed.
This change makes WeaponAuxiliaryAction.execute await the completion of Actor.adjustCarryType before continuing.

Is there a concrete issue being addressed?

I'm trying to write a macro which, will draw a weapon (if it's not already) posting to chat just as if the player had clicked the "Draw" button, and then do things with the weapon that require the weapon be in a "held" state.
At the moment I've no way of waiting until the weapon is drawn before continuing with my operations.


flutter has exited unexpectedly when the debugging target is iOS

here are the details.
same setup works fine with android.
on iOS app launches fine but, flutter exists with below error and loses connection with the target.
command
flutter run --debug
exception
ArgumentError: Invalid argument(s): Cannot find executable for null.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:113)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:41)
#2      runCommand (package:flutter_tools/src/base/process.dart:115)
#3      _IOSDevicePortForwarder.forward (package:flutter_tools/src/ios/devices.dart:518)
<asynchronous suspension>
#4      ProtocolDiscovery._forwardPort (package:flutter_tools/src/protocol_discovery.dart:93)
<asynchronous suspension>
#5      ProtocolDiscovery._handleLine (package:flutter_tools/src/protocol_discovery.dart:82)
#6      _rootRunUnary (dart:async/zone.dart:1134)
#7      _CustomZone.runUnary (dart:async/zone.dart:1031)
#8      _CustomZone.runUnaryGuarded (dart:async/zone.dart:933)
#9      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:330)
#10     _DelayedData.perform (dart:async/stream_impl.dart:578)
#11     _StreamImplEvents.handleNext (dart:async/stream_impl.dart:694)
#12     _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:654)
#13     _rootRun (dart:async/zone.dart:1126)
#14     _CustomZone.run (dart:async/zone.dart:1023)
#15     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:949)
#16     _microtaskLoop (dart:async/schedule_microtask.dart:41)
#17     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)
#18     _runPendingImmediateCallback (dart:isolate-patch/dart:isolate/isolate_patch.dart:113)
#19     _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:166)

flutter doctor
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.2 17C88, locale en-IN)
    • Flutter version 0.5.1 at /Users/hari/development/flutter
    • Framework revision c7ea3ca377 (3 months ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/hari/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] VS Code (version 1.26.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected devices (1 available)
    • iPad • 4474fd3c94589784543185ceefc47173d59e2b5f • ios • iOS 9.3.5

! Doctor found issues in 1 category.

same problem even with recent dev channel
exception
ArgumentError: Invalid argument(s): Cannot find executable for null.
#0      _getExecutable (package:process/src/interface/local_process_manager.dart:113:5)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:41:7)
#2      runCommand (package:flutter_tools/src/base/process.dart:115:25)
#3      _IOSDevicePortForwarder.forward (package:flutter_tools/src/ios/devices.dart:547:23)
<asynchronous suspension>
#4      ProtocolDiscovery._forwardPort (package:flutter_tools/src/protocol_discovery.dart:89:54)
<asynchronous suspension>
#5      ProtocolDiscovery._handleLine (package:flutter_tools/src/protocol_discovery.dart:78:27)
#6      _rootRunUnary (dart:async/zone.dart:1132:38)
#7      _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#8      _CustomZone.runUnaryGuarded (dart:async/zone.dart:931:7)
#9      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11)
#10     _DelayedData.perform (dart:async/stream_impl.dart:584:14)
#11     _StreamImplEvents.handleNext (dart:async/stream_impl.dart:700:11)
#12     _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:660:7)
#13     _rootRun (dart:async/zone.dart:1124:13)
#14     _CustomZone.run (dart:async/zone.dart:1021:19)
#15     _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#16     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#17     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#18     _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:114:13)
#19     _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:170:5)

flutter doctor
[✓] Flutter (Channel dev, v0.5.8, on Mac OS X 10.13.2 17C88, locale en-IN)
    • Flutter version 0.5.8 at /Users/hari/development/flutter
    • Framework revision e4b989bf3d (7 days ago), 2018-08-09 09:45:44 -0700
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.0.0-dev.69.5.flutter-eab492385c

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/hari/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.26.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.17.1

[✓] Connected devices (1 available)
    • iPad • 4474fd3c94589784543185ceefc47173d59e2b5f • ios • iOS 9.3.5

• No issues found!

It looks like iproxy may be missing. What happens if you run iproxy and which iproxy from the terminal?
I think iproxy is supposed to come from libimobiledevice which you probably installs with brew. Can you post the output of brew list?

@DanTup indeed it was iproxy issue. it doesn't seem to come from libimobiledevice now. i tried reinstalling multiple times. using locate i found it installed in /usr/local/Cellar/usbmuxd/1.0.10_1/bin/iproxy. for some odd reason, brew didn't symlink it.
after symlink the has been resolved.
thanks for the help.

Ah, I wasn't sure exactly where it came from but I found other issues suggesting it was libimobiledevice.
Glad it's sorted. If this turns out not to be a one off (if you're reading this and have the same issue - please add a comment!) we may want to reopen and investigate.

I am having this issue as well. how do I symlink it?[ if the solution above worked]

this is my output for 'brew list'
autoconf                gettext                 libidn2                 libtasn1                libusb                  openssl                 python@2                usbmuxd
automake                ideviceinstaller        libimobiledevice        libtool                 libxml2                 pkg-config              readline                wget
gdbm                    ios-deploy              libplist                libunistring            libzip                  python                  sqlite                  xz

What fixed it for me was brew link libimobiledevice.

I had the same issue with Flutter command-line tools and Visual Studio Code tools.
You can get this error both through command line flutter emulator --create flutteremu or using Flutter: Launch Emulator in Visual Studio Code.
Oops; flutter has exited unexpectedly: "Invalid argument(s): Cannot find executable for null.".

You get this error despite flutter doctor telling you that everything is in order.
There is a log file, which details the error here.
If you dig deeper you fill find out that the following Android command line tool does not work:
avdmanager

No Java runtime present, requesting install.

Turns out that avdmanager is quite a tricky to get running on macOS, as it seems to be fall short on the default Android SDK installation.  You need to have an external java installed and then you need to make sure all environment variables are wired correctly. Plus pinning down a correct Java version was not that easy.
I wrote a detailed instructions how to get this fixed on this StackOverflow answer.
The correct bug fix would be that flutter doctor detects the condition when the user cannot run avdmanager and tells the user that this needs to be fixed.


State in react

We currently don't handle state in React.
Let's think about it - we have:
Unstated
Precompose
Redux
Mobx
React.Component (internal state)
Think about:
https://github.com/rofrischmann/fela

@davidpmccormick @gestchild maybe a suggestion here is to go away and build a quick search and crop tool, each choosing a method(s) and reporting back?

Another thing to pay attention to:
https://github.com/reactjs/rfcs/blob/master/text/0002-new-version-of-context.md

One to the mix for fun:
https://github.com/jamesknelson/govern#two-out-of-three-types-of-state


Move gnomAD link to "other links" section for consistency

https://genetics.opentargets.org/gene/ENSG00000099800
Raised at Director level via email on 18Dec2018.

This issue has been resolved by this PR https://github.com/opentargets/genetics-app/pull/106


[feat] allow to change outDir in saofile.js

Is there a way to change the output dynamically acording to the anwser?
Maybe provide a changeOutDir function will be nice in generator instance?

Now my solution:
action () {
  this.sao.opts.outDir = this.answers.outputPath
}


[Legend SQL] - Add metrics and tracing

What type of PR is this?
Improvement

What does this PR do / why is it needed ?
Enable metrics and tracing via Open Telemetry/Zipkin

Which issue(s) this PR fixes:

Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?

Looks good to me.


All pages are retrieved for calls to Run but not for calls to RunAsync

This results in only the first page of results being returned when calling RunAsync instead of Run. The code that handles downloading the pages can be found here:
https://github.com/neuecc/LINQ-to-BigQuery/blob/4f445553d5d5edf94a91ca23997cb53819ece30e/BigQuery.Linq/BigQueryContext.cs#L365
In reality, due to the possibility of memory issues if there are a large number of pages, control over how to handle paging should be exposed. However, care must be taken to not change the current default behaviour, which is to download all pages.

Got a good idea of how to approach exposing page control, will submit a PR when ready.

Fixed in ede8ed7


fix/import

fixed wrong multithread shared counter - sometimes task doesn't increment it after finishing and importing process just froze at the end with couple books remaining;
check inpx file existence before trying to read from it;
added logging exceptions during import;
clarify import arguments.

Thanks!


Help with Lookup filter by current field in form

Hi, I have a form with a field "CompanyId" and  other field named "Site" with a LookupEditor.
What I need is to be able to only show on "Site" options that are related (in database) to "CompanyId".
Example:
CompanyId = 1; (this value should come from the form)
only show in "Site" options that in the database have a specific column (CompanyId) with the value 1.
So far I have this:
[LookupScript("Information.Sites")]
 public class SitesLookup : RowLookupScript<SitesRow>
    {
        protected override void PrepareQuery(SqlQuery query)    {
            base.PrepareQuery(query);
            query.Where(SitesRow.Fields.CompanyId == 1);  /*Here I need something like this.form.CompanyId*/
        }
  }

Thanks.

You can use cascadeFrom option in lookup attribuite. Search in basic sample.

Thanks!

Any chance thefitar, you have sample of code. I have exactly same request and having hard time with CascadeFrom Syntax.


The Links scheduled workflow is triggered by the schedule event.

Should be disabled in forks
Fixes https://github.com/containerd/containerd/issues/9701

@roman-kiselenko Can you retitle the PR to match the change being done.


[Feature Request] Move ArcType to ISAJson type conversion member to ISAJson type

Currently this is part of the ArcAssay:
    /// Transform an ArcAssay to an ISA Json Assay.
    member this.ToAssay() : Assay =
        let processSeq = ArcTables(this.Tables).GetProcesses()
        let assayMaterials =
            AssayMaterials.create(
                ?Samples = (ProcessSequence.getSamples processSeq |> Option.fromValueWithDefault []),
                ?OtherMaterials = (ProcessSequence.getMaterials processSeq |> Option.fromValueWithDefault [])
            )
            |> Option.fromValueWithDefault AssayMaterials.empty
        let fileName =
            if ISA.Identifier.isMissingIdentifier this.Identifier then
                None
            else
                Some (ISA.Identifier.Assay.fileNameFromIdentifier this.Identifier)
        Assay.create(
            ?FileName = fileName,
            ?MeasurementType = this.MeasurementType,
            ?TechnologyType = this.TechnologyType,
            ?TechnologyPlatform = this.TechnologyPlatform,
            ?DataFiles = (ProcessSequence.getData processSeq |> Option.fromValueWithDefault []),
            ?Materials = assayMaterials,
            ?CharacteristicCategories = (ProcessSequence.getCharacteristics processSeq |> Option.fromValueWithDefault []),
            ?UnitCategories = (ProcessSequence.getUnits processSeq |> Option.fromValueWithDefault []),
            ?ProcessSequence = (processSeq |> Option.fromValueWithDefault []),
            ?Comments = (this.Comments |> List.ofArray |> Option.fromValueWithDefault [])
            )

    // Create an ArcAssay from an ISA Json Assay.
    static member fromAssay (a : Assay) : ArcAssay =
        let tables = (a.ProcessSequence |> Option.map (ArcTables.fromProcesses >> fun t -> t.Tables))
        let identifer =
            match a.FileName with
            | Some fn -> Identifier.Assay.identifierFromFileName fn
            | None -> Identifier.createMissingIdentifier()
        ArcAssay.create(
            identifer,
            ?measurementType = a.MeasurementType,
            ?technologyType = a.TechnologyType,
            ?technologyPlatform = a.TechnologyPlatform,
            ?tables = tables,
            ?comments = (a.Comments |> Option.map Array.ofList)
            )

i would suggest moving this function to the isa json type Assay. It is not recommended for the standard api user to use this function, instead it is mainly used from ARCtrl.ISA.Json.

Moving to json type is not feasible, maybe add to type extension?

Maybe we could move the functions to a whole new module altogether.

Yes, let's do that!


Show current working dir in file tree

We should be able to provide some custom icon and use the tree-view API to show the working dir if it is in the file tree.
If not that way, some indication of the current working dir would be nice anyways, I think.

Great idea, I'm definitely on board with this.

For inspiration: https://github.com/platformio/platformio-atom-ide/blob/7dae357bb512e7936c371cd7f35ccbd1a8349605/lib/maintenance.js#L228
Not quite sure how to handle updating the working dir properly just yet though.


test: :bug: fix test failures after Django removal

Description
The tests were still failing, because the lock file needed to be updated and there was a left over Django file in the test folder.

This PR needs a quick/an in-depth review.
Checklist

[x] Added or updated tests
[x] Tests passed locally
[x] Linted and formatted code
[x] Build passed locally
[x] Updated documentation

Yea, after the merges. It was because of that db_ file and a left over dependency.


Malmo Sweden dataset needs rehosting

I am attempting to update the Malmo dataset in Sweden to the latest version but the json has an extra column on some of the features which is breaking the build process.
I've converted the json to a csv to get around the issue and attached it here for rehosting. malmo_adresser.csv
I have a draft PR related to this dataset here. https://github.com/openaddresses/openaddresses/pull/7446
Here is also the data source for posterity. https://ckan-malmo.dataplatform.se/dataset/140830ba-9850-4f01-a1a3-a7e79821a2b7/resource/caf1cee8-9af2-4a75-8fb7-f1d7cb11daeb/download/adresser.json

This is complete now


WebSockets Support?

Hi,
First of all great work you have done here.
Would it be possible to use WebSockets with the network interface?

Hi @DroneMesh,
thank you for your feedback!
What do you exactly mean by using WebSockets in this context? AFAIK WebSockets are for server-browser communication.
However, anything more than standard HTTP(S) which is implemented right now, would require moving to using PPoS first (see PR https://github.com/pythings/Drivers/pull/5), which reduce compatibility across the MicroPython ecosystem.
Maybe we could create an extended version of the driver to support these features as well.

I also have similar query. I am trying to establish Webscoker connection using TCP connections. I am unable to do it but. I can get TCP connected but at server side, i am not getting any message. Can you guide how can i do websocket messaging here?


Display toggle fields without outline or background

Removing the background and outline from the toggle fields results in a cleaner look.
Current state in Oceanfront:

Proposal:

Related Links:

Checkbox component in vuetify
Switch component in vuetify

We will check this. I agree that it looks better without outline.

I'm currently planning to make this border style an attribute of the field type which can be overridden, but defaults to invisible for certain field types like the checkbox and slider. I think in some contexts it may be more appropriate to keep the border.


Hi there!! Screen share not working in flutter using native code implementation

I have implemented the native code for share screen in android according to below example code
https://github.com/AgoraIO/API-Examples/blob/master/Android/APIExample/app/src/main/java/io/agora/api/example/examples/advanced/SwitchCameraScreenShare.java
code executes successfully for screen share but when I start screen sharing it shows reconnecting on other side and screen share not working.
Is there any suggestion or idea about it, that what is the issue?
Thanks in advance.

what do you mean reconnecting? are you seeing sth?

I mean when I start screen share the connection state change to Reconnecting

If you still face issues, please try upgrading to the new version to see if it works for you.


if I use domain ,get panic: no active connection found: no Elasticsearch node available

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?

elastic.v5 (for Elasticsearch 5.x)

Please describe the expected behavior
connect to es successfully.
Please describe the actual behavior
panic: no active connection found: no Elasticsearch node available
Any steps to reproduce the behavior?
var client *elastic.Client
//use domain
//var host =<EMAIL_ADDRESS>// use ip
var host = "http://user:password@<IP_ADDRESS>:9200"
If I use domain, connect to es failed.
if I use ip, successfully.

From the example code, it looks like you forgot the port number in the host variable. Just a typo?

forgot the port number in the host variable.
if I forgot the port number in the host variable, which port number will be used by default?

If you specify the host by yourself, you’re responsible for passing the correct details, including the port. If you don’t pass the URL, http://<IP_ADDRESS>:9200 is used by default.

Am 16.02.2019 um 14:58 schrieb Jack<EMAIL_ADDRESS>forgot the port number in the host variable.
if I forgot the port number in the host variable, which port number will be used by default?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

If you specify the host by yourself, you’re responsible for passing the correct details, including the port. If you don’t pass the URL, http://<IP_ADDRESS>:9200 is used by default.
…
Am 16.02.2019 um 14:58 schrieb Jack @.***>: forgot the port number in the host variable. if I forgot the port number in the host variable, which port number will be used by default? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

I mean, if my domain name is followed by a SLB that helps me forward to the ES node, does this package support this usage?

If you use a Load Balancer, you should disable sniffing (see the Wiki). Otherwise it will pick up the node IPs returned by the cluster and do round-robin.

If you use a Load Balancer, you should disable sniffing (see the Wiki). Otherwise it will pick up the node IPs returned by the cluster and do round-robin.

That works for me!
Thanks!


Is automatic1111 working?

This morning a1111 stopped working and I can't get anything in the notebook to run - not even the first step where it connects to my google drive.  I've reloaded the page and restarted my computer but nothing seems to help.  I've tried safari and chrome.  no luck.  I can get other colab notebooks to run (e.g. kohya_ss).  Is this down for others?

After 4 hours of not working of course it started working again 2 minutes after I wrote this "issue"


Support Rust keywords in the schema

Raw identifies will be used.
Fixes https://github.com/davidpdrsn/juniper-from-schema/issues/92.

@jiemme2 This should fix your issue. Are you able to build your project with this PR and see if everything works?
juniper-from-schema = { git = "https://github.com/davidpdrsn/juniper-from-schema.git", branch = "support-keywords-in-schema" }

Should do the trick.

@davidpdrsn
ok I’ll test it and tell you if it works

I just tested with the schema below
schema {
  query: Query
  mutation: Mutation
}

type Query {
  currentBlock: String! @juniper(ownership: "owned")
  current: Block @juniper(ownership: "owned")
}
type Block {
  version: Int!
  type: String!
  currency: String!
  number: Int!
}

There are no more compilation errors
But i get this error at the opening of graphiql
Error: Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "r#type" does not.     at exports.assertValidName (https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:688857)     at https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:633660     at Array.forEach (<anonymous>)     at defineFieldMap (https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:633596)     at GraphQLObjectType.getFields (https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:641830)     at typeMapReducer (https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:676101)     at https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:676343     at Array.forEach (<anonymous>)     at typeMapReducer (https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.11/graphiql.min.js:1:676135)     at Array.reduce (<anonymous>)

So close 😜 Thanks for the report. I'll look into it.

Apparently juniper doesn't handle raw identifiers very well. I've submitted a patch that fixes that https://github.com/graphql-rust/juniper/pull/450
So we're currently blocked on that being merged.

My patch has been merged. Waiting on the next version to be shipped. I imagine the next version is going to include async/await support so not sure when that'll be.

Ok thank you for you patch !

My juniper patch has now been released. I’ll look into getting this merged and shipped.

This landed in https://github.com/davidpdrsn/juniper-from-schema/pull/122.


Java heap space issues

The issue of running out of Java Heap Space, results when scenarios are loaded sequentially. A scenario is loaded, data is retrieved from the scenario (no checkout/commit is performed), data is then processed. (details below). A maximum of 12 scenarios can be processed, before memory issues are encountered. For each scenario which is loaded, more memory is required as opposed to memory being freed up when the routine for one scenario is completed, which would be available for the next scenario which is processed.

Code sample or context
I have made a small program (module_x) that uses some functions from the "old" reporting in message_data.
Module_x process (python):

imports message_ix/ixmp
load ixmp.Platform() -> assigned to variable "mp"
loads a scenario (without cache) -> assigned to variable "scen"
retrieves 3 dataframes using "old" reporting functions.
loads 1 variable stored as a timeseries with the scenarios object.
performs a simple data manipulation.
close mp
set variable "scen" = None
set variable "mp" = None

Module_x is called from an ipynb (>160 scenarios).  The jupyter notebook loops over the scenario list and does nothing else except loop over scenario names and for each scenario

import module_x
call module_x passing some variables (all strings)
del module_x

Problem description
Memory issues occur after approx. 10-12 scenarios.
Versions
ixmp:        3.2.1.dev80+g40fc589
     40fc589 (HEAD -> master, origin/master, origin/HEAD) Merge branch 'master' of https://github.com/iiasa/ixmp
message_ix:  3.2.1.dev67+ga20ffb0
     a20ffb0 (HEAD -> master, origin/master, origin/HEAD) Merge branch 'master' of https://github.com/iiasa/message_ix
message_data: installed
     3bfb76b (HEAD -> RES_add_5_year_timesteps2, origin/RES_add_5_year_timesteps2) added configuration files for ENGAGE submission 20210331 (ENGAGE 4.1.7)

click:       7.1.2
dask:        2020.12.0
graphviz:    0.13.2
jpype:       1.2.1
… JVM path:  C:\Program Files\Java\jre1.8.0_231\bin\server\jvm.dll
openpyxl:    3.0.5
pandas:      1.1.3
pint:        0.11
xarray:      0.15.1
yaml:        5.3.1

iam_units:   installed
jupyter:     installed
matplotlib:  3.3.2
plotnine:    0.7.0
pyam:        0.7.0+4.gc1ed1f8
     c1ed1f8 (HEAD -> master, origin/master, origin/HEAD) Add a tutorial how to read data from GAMS gdx to pyam (#424)

GAMS:        33.1.0

python:      3.7.9 (default, Aug 31 2020, 17:10:11) [MSC v.1916 64 bit (AMD64)]
python-bits: 64
OS:          Windows
OS-release:  10
machine:     AMD64
processor:   Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
byteorder:   little
LC_ALL:      None
LANG:        None
LOCALE:      None.None

This may be related to iiasa/ixmp#227, which was closed via iiasa/ixmp#298. See the latter for extensive discussion & records of various tests and diagnostics. See also iiasa/ixmp#215, still open re: performance tests.
Jupyter might be one culprit (the description says “Module_x is called from an ipynb”). To wit:

ixmp aggressively garbage-collects objects when they are deleted, i.e. no longer referenced by any other Python object/variable. This in turn allows the Java objects to be GC'd.
Jupyter/IPython retain references to output of previous commands/cells, e.g. _23 is a special variable referring to the output of a notebook cell numbered [23].
Even if a cell is re-run, producing output, these references are not automatically cleared.
These would prevent Python/ixmp from GC'ing objects.

As usual, in order to isolate the issue in message_ix or ixmp, diagnose it, and check that a fix works, it would be necessary to reproduce the issue. One way would be to construct a minimal test case with "Module_x" and the notebook in question. In the process, it should be checked if the issue only occurs under Jupyter (per the above).


fix(techdocs): remove footer overlay on large screen

Uses static positions on the child links instead of the container
Resolves #15653

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi @agentbellnorm,
Yes, it's a better solution, thanks - PR updated.

@oodamien Nice! I made another comment (sorry, should have mentioned it immediately).
To fix the DCO check, make sure all commits are made with the -s flag e.g. git commit -s -m "<message>". Or check out this thread: https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

@agentbellnorm,
Thanks for the feedbacks, PR updated.


Xray property missing from local, remote and federated repo types

Describe the bug
The Xray property type is missing from from all local, remote and federated dedicated repository types.
Affected versions
v2.3 and above
Expected behavior
The old local_repository and remote_repository types accepted a property called xray_index. This is a valid property that can be should be managed by the repository types and is listed in the spec [1]. By removing this, we have a hard blocker on migrating to the new dedicated repository types in v6 of the provider. For now the highest version we can upgrade to is v5.
This property can be set regardless of Xray being enabled and does not require special Xray permissions. In addition, even if we were using the Xray provider, which we're not, nothing exists in it to manage it. In addition, even the plan is to never support this, the current implementations override it instead of ignoring it.
resource "artifactory_remote_alpine_repository" "this" {
    id                                    = "external-alpine-main"
  ~ list_remote_folder_items              = true -> false
  ~ property_sets                         = [
      - "artifactory",
    ]
  ~ xray_index                            = true -> false
    # (26 unchanged attributes hidden)

    # (1 unchanged block hidden)
}

Additional context
[1] Repository API spec: https://www.jfrog.com/confluence/display/JFROG/Repository+Configuration+JSON

@jamestoyer As far as I can see from the code, xray_index attribute is supported in v6. This may be a combination of this attribute missing from documentation and a code bug that not getting the value correctly from HCL.
We will take a look.

@jamestoyer  ... I was able to use "xray_index" attribute for my test remote repo without issues.
Following is my hcl block.
resource "artifactory_remote_alpine_repository" "test-alpine-remote-repo" {
  key              = "test-alpine-remote-repo"
  url               = "http://dl-cdn.alpinelinux.org/alpine"
  xray_index = true
}

I could see the plan having the value for this attribute and REST calls passing the json payload accordingly.
Used Provider version: 6.1.3 (latest) and Artifactory version 7.35.2.
Would like to know the sequence of operations in your setup that causes the issue. Thanks.

@maheshjfrog it looks like my issue was a documentation issue. On other providers, e.g. AWS, TFE, all the acceptable arguments are listed in the "Argument Reference" section of the documentation. When looking at the alpine repository, I saw that there were only four arguments and assumed that these were the only four accepted. On re-reading the docs, I noticed this:

Arguments for remote Alpine repository type closely match with arguments for remote Generic repository type.
Whilst this is a fair comment, it doesn't follow the expectations built by other providers in listing out the full arguments. If the docs aren't going to do this, may I suggest this is made more prominent, for example in an info box, and a link to the generic repo equivalents is added? This would save the confusion going forward.

Thanks @jamestoyer ... Sure. We have similar requests like #398).
We are working on the documentation update story.

@jamestoyer - we do our best to support the community. We would love a ⭐  on the repo from you and your friends

I am closing this issue as a new one re: documentation has been openned


WIP: Update duckdb to 0.10.0

Will fix https://github.com/huggingface/datasets-server/issues/2413
This PR will include the following changes:

Add a new job runner that will compute duckdb files with 0.10.0 -> Temporal cache kind split-duckdb-index-010
Still have the old job runner that will compute duckdb files with 0.8.1 (Will use duckdb CLI to support two different duckdb versions, it was not possible with poetry) -> Cache kind is still split-duckdb-index to allow /search and /filter service working as usual while split-duckdb-index-010 is being computed
Will point the new job runner  split-duckdb-index-010 to /refs/convert/duckdb instead or refs/conver/parquet
Will add a new field in split-duckdb-index-010 to specify the duckdb version used
Is it ok to copy the executable duckdb-081 in the Dockerfile? It could also be a download/unzip but since it will be removed, I thought any related logic should be as simple as possible.

Deploy plan - Once this PR is merged, deployed,  and all split-duckdb-index-010 entries have been computed, send another PR to:

Migration to delete all previous split-duckdb-index cache entries
Migration to rename all cache entries with kind split-duckdb-index-010 to split-duckdb-index
Update the duckdb version in /search service
Remove old code (I put TODOs to easily identify which parts need to be removed from the old job runner)
Refresh all entries for config-duckdb-index-size, split-is-valid, dataset-duckdb-index-size, config-is-valid, dataset-is-valid, dataset-hub-cache (Maybe increase job runner version and backfill?)
Stop workers when deploying

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (40c53e4) 86.86% compared to head (a06651e) 86.96%.

Files
Patch %
Lines

libs/libapi/tests/test_duckdb.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   86.86%   86.96%   +0.09%
==========================================
  Files          53       47       -6
  Lines        1500     2401     +901
==========================================
+ Hits         1303     2088     +785
- Misses        197      313     +116

Flag
Coverage Δ

jobs_cache_maintenance
94.43% <ø> (?)

jobs_mongodb_migration
?

libs_libapi
87.10% <0.00%> (?)

services_api
85.99% <ø> (?)

services_search
80.95% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I don't know much about subprocesses. How would we handle a failure in the duckdb CLI? will it be exactly the same as now?

It will raise a RuntimeError in the worker. I would instead not go deeper into the kind of exceptions this process can throw because I would like to remove the whole 0.8.1 job runner as soon as the 0.10.0 cache entries are computed.

Is it ok to copy the executable duckdb-081 in the Dockerfile? It could also be a download/unzip but since it will be removed, I thought any related logic should be as simple as possible.

Sounds good to me ! Better have it as a download/unzip to not make this git repo too big IMO

For unit tests: maybe duckdb download is missing in .github/workflows/_unit-tests-python.yml ?

After ten tries, I was able to have it working for the unit test. It is ready for review.
I didn't find a way to download/unzip the CLI only for worker tests. I would really like to remove all the "parallel" code for 0.8.1 after 0.10.0 entries are computed.


Feature/blue pagination

Made the hitboxes bigger, exchanged the pagination icons and made the clickable parts link blue.

Codecov Report

Merging #66 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #66   +/-   ##
========================================
  Coverage    94.65%   94.65%
========================================
  Files          124      124
  Lines         1982     1982
========================================
  Hits          1876     1876
  Misses         106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375279a...cb654ec. Read the comment docs.


Laravel 6 support?

Having issues with string helper functions

Any updates about Laravel 6?

Would it be possible to have a separate branch in addition to master to support the ongoing changes to Laravel 6? Possibly a dev branch or unstable branch?

Please add the laravel 6 support. i am trying to install but its showing below error
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install brozot/laravel-fcm v1.2.6
    - Conclusion: don't install brozot/laravel-fcm v1.2.5
    - Conclusion: don't install brozot/laravel-fcm v1.2.4
    - Conclusion: don't install brozot/laravel-fcm v1.2.3
    - Conclusion: don't install brozot/laravel-fcm v1.2.2
    - Conclusion: don't install brozot/laravel-fcm v1.2.1
    - Conclusion: remove monolog/monolog 2.0.0
    - Installation request for laravel/framework (locked at v6.0.3, required as ^6.0) -> satisfiable by laravel/framework[v6.0.3].
    - Installation request for brozot/laravel-fcm ^1.2 -> satisfiable by brozot/laravel-fcm[v1.2.0, v1.2.1, v1.2.2, v1.2.3, v1.2.4, v1.2.5, v1.2.6].
    - Conclusion: don't install monolog/monolog 2.0.0
    - brozot/laravel-fcm v1.2.0 requires monolog/monolog ^1.19 -> satisfiable by monolog/monolog[1.19.0, 1.20.0, 1.21.0, 1.22.0, 1.22.1, 1.23.0, 1.24.0, 1.25.0, 1.25.1, 1.x-dev].
    - Can only install one of: monolog/monolog[1.19.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.20.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.21.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.22.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.22.1, 2.0.0].
    - Can only install one of: monolog/monolog[1.23.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.24.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.25.0, 2.0.0].
    - Can only install one of: monolog/monolog[1.25.1, 2.0.0].
    - Can only install one of: monolog/monolog[1.x-dev, 2.0.0].
    - Installation request for monolog/monolog (locked at 2.0.0) -> satisfiable by monolog/monolog[2.0.0].

Installation failed, reverting ./composer.json to its original content.

Please add Support for Laravel 6

+1

+1

+1

+1 !

+1

+1

+1

+1

+1

+1

If you have gone through the upgrade guide then you must know that
String and Array
Helpers are removed from Core Framework
So if if You need to still use the helper install the package
composer require laravel/helpers
and all the helpers are moved to this package

+1

If you have gone through the upgrade guide then you must know that
String and Array
Helpers are removed from Core Framework
So if if You need to still use the helper install the package
composer require laravel/helpers
and all the helpers are moved to this package

@anhtt57 Still, you can't upgrade to Laravel 6.x. First package dependency should be updated to work with Laravel 6.x.
"illuminate/support": "5.*|^6.0"

Hi all,
A new version has been release, this version should bring the support of Laravel 6
https://github.com/brozot/Laravel-FCM/releases/tag/1.3.0

Hi @brozot I am still experiencing the monolog issue with v1.3.0

+1

It seems that the version of monolog used by laravel-fcm is more strict that the one used by laravel 6"monolog/monolog": "^1.12|^2.0", I will try to make the package compatible with version of monolog 1.12 and 2.0" that should solve this issue

Hi @richardkeep,
I have updated the composer file: Could you please try with "brozot/laravel-fcm": "dev-master " if it solves the problem, I will create a version 1.3.1

Hi @richardkeep,
I have updated the composer file: Could you please try with "brozot/laravel-fcm": "dev-master " if it solves the problem, I will create a version 1.3.1

The issue has been resolved. Tested with Laravel 6.6.0

Thanks @richardkeep


Map same binding for different modes

I would like to have different bindings for different modes.
Example: I would like that on java, I can run test with dap, but on dart-mode run flutter tests...
dap binding: https://github.com/ericdallo/dotfiles/blob/master/emacs/.doom.d/+bindings.el#L118
dart test binding: https://github.com/ericdallo/dotfiles/blob/master/emacs/.doom.d/+bindings.el#L137
What happens is that one override the other, so when I'm on java, it keeps showing to run flutter tests on the binding :/
Am I doing something wrong?

Yes. :leader keys are global, not buffer/mode local. What you want is :localleader:
(map! :localleader
      (:map java-mode-map
       "t" #'dap-java-run-test-method)
      (:map dart-mode-map
       "t" #'flutter-test-current-file))

This puts the key on SPC m t, because SPC m is the local leader.

Thanks! @hlissner do you know if can bind in separated map! functions?
Like this:
(map! :after dap-java
      :localleader
      :prefix ("m" . "tools")

      :desc "Run method test"
      "t" #'dap-java-run-test-method)

(map! :after dart-mode
      :localleader
      :prefix ("m" . "tools")

      :desc "Run current file test"
      "t" #'flutter-test-current-file)

It gives me the error:
Error in private config: +bindings.el, (error Key sequence SPC m m t starts with non-prefix key SPC)

Hum, I fixed adding :map:
(map! :after dap-java
      :map dap-mode-map
      :localleader
      :prefix ("m" . "tools")

      :desc "Run method test"
      "t" #'dap-java-run-test-method)

(map! :after dart-mode
      :map dart-mode-map
      :localleader
      :prefix ("m" . "tools")

      :desc "Run current file test"
      "t" #'flutter-test-current-file)

But it looks like it's adding a m prefix and using the dap-mode-map yet :/

Not sure i understand. You have :prefix "m", so it's going to bind under <localleader> m t, and <localleader> is SPC m, therefore SPC m m t.
If this is not what you want, remove the :prefix.

Yeah, I didn't know that localleader is SPC m, sorry.
Ok, but I'm on a dart-mode and it's showing the dap bindings yet :/ It should show the dart-mode-map bindings, not the dap-mode-map.

That implies you have dap-mode enabled in both buffers, in which case they are behaving correctly. Minor modes keymaps (dap-mode) have higher precedence than major mode keymaps. Perhaps instead of binding the key to dap-mode-map, why not java-mode-map?

yeah! I realized that now :man_facepalming:
It works now, thank you very much!

Glad I could help!


Upgrade terraform resource to 0.12.12

This will break the pipeline (temporarily) and allow us to plan https://github.com/alphagov/gsp/pull/705

Plan:

Approve and merge this first
Hijack the sandbox-deployer/deploy job
Patch https://github.com/alphagov/gsp/pull/705 in (git format-patch and patch -p1)
Terraform plan (from pipelines/deployer, filling out all the variables based on the cluster-config file)

If we're happy with the result we approve and merge https://github.com/alphagov/gsp/pull/705, and repeat the process in verify.
If not we can revert this.

how about setting the plan_only: true param on the put for any use of this resource in this PR ... and which will make the terraform upgrade less scary and block any actual changes in the follow up PR until the plan looks good?
https://github.com/ljfranklin/terraform-resource <-- search for "plan_only"

Sounds like we should do that (but in #705), as well as removing the Dockerfile comment discussed. It sounds like plan_only will produce a file, but I guess it will output stuff to stdout/Concourse too?


Improve error reporting: provide better literal suffix description

What
let foo = 1up

This is not a valid numeric literal. Sample formats include 4, 0x4, 0b0100, 4L, 4UL, 4u, 4s, 4us, 4y, 4uy, 4.0, 4.0f, 4I
Why
It is difficult to remember:

the valid suffixes
what exact type they correspond to (despite they are kind of logical, if I made a mistake, better remind me the type as well)
I was looking for decimal but it isn't there

How
Bonus point if we instead of 4 we show 42 or the actual value.
Invalid numeric literal. Valid format samples: 1, 0x1, 0b0001 (int), 1u (uint32), 1L (int64), 1UL (uint64), 1s (int16), 1y (sbyte), 1ui (byte), 1.0 (float), 1.0f  (float32), 1.0m (decimal), 1I (BigInteger)
#1103

note also that let a = 0m works but let a = 0f doesn't which I think is inconsistent.

Question: why do UL and L need  to be uppercased while others are all lowercase only?

Question: why do UL and L need to be uppercased while others are all lowercase only?

About l vs L, my guess is that's something like 21l is very hard to read. I'm not sure about u vs U though.

@vasily-kirichenko I see, what about the one for BigInteger? 21i vs 21I I guess Big Integer = Big I :)

We should not question the syntax here. That is pretty much fixed. This
should only be about the error messages
On Apr 28, 2016 12:24 PM, "Gauthier Segay"<EMAIL_ADDRESS>wrote:

@vasily-kirichenko https://github.com/vasily-kirichenko I see, what
about the one for BigInteger? 21i vs 21I I guess Big Integer = Big I :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/1129#issuecomment-215379495

@forki: do you think the proposed error message (check on github itself due to edits) is an enhancement?

Adding the samples is ok, but please keep the style of the original wording where sentences are used, rather than phrases:
This is not a valid numeric literal. Valid numeric literals include 1, 0x1, 0b0001 (int), 1u (uint32), 1L (int64), 1UL (uint64), 1s (int16), 1y (sbyte), 1ui (byte), 1.0 (float), 1.0f (float32), 1.0m (decimal), 1I (BigInteger)

It's important to say "include" because the numeric literals are extensible through the QZRING feature.

@dsyme updated, thanks for feedback, maybe you should consider putting some guidelines on #1103 regarding how to word those messages.
I still think the final messages should be created/edited by MS with concern at consistency, comprehensibility and conciseness.

PR at https://github.com/Microsoft/visualfsharp/pull/1148
Regarding "bonus points": we failed to parse the numeral so we can't say what the "actual value" is here.

In the error message the byte literal is wrong: should be 1uy, not 1ui.