feat(locale): add Ukrainian locale

Proposed Changes
Added Ukrainian locale

Isn't the country code for Ukraine the UA?
link to ISO 3166 codes

For country yes it's "ua". But for language it's "uk" in ISO 639-1.
https://en.m.wikipedia.org/wiki/Ukrainian_language

thanks


not working properly [BUG]

after running "SamPicker.exe" the application opens as normal and the games list shows up, but after selecting a game, it does not open the achievements list for that game, it just re-opens the same window that shows a list of all the games. i have tried everything, including trying to get other forks to open the achievement list, for whatever reason, it will not open the achievements list. i have tried disabling every windows security feature including memory integrity, and adding the program as an exception in the windows security settings, and it still wont open achievements list.

That's pretty weird, SAM.Game.exe only spawns SAM.Picker.exe if it received no arguments on the command-line. You're using standard Windows and such?

im using the latest version of windows 11

any fix for it yet?

That's pretty weird, SAM.Game.exe only spawns SAM.Picker.exe if it received no arguments on the command-line. You're using standard Windows and such?

does it require .NET? if so, the only version i have is the latest version of .net, i was unable to install .net4

That's pretty weird, SAM.Game.exe only spawns SAM.Picker.exe if it received no arguments on the command-line. You're using standard Windows and such?

hey i think i figured out the issue, i currently do not have ".NET SDK 4.5.2" framework installed which i think could be causing the program to malfunction, i only have .NET SDK 7.0.306(x64) installed, do you think you can update it to support this framework?

I have also been getting this same problem. I use the latest version of Windows 11 aswell and wish to know if you have found a solution to this.

I have also been getting this same problem. I use the latest version of Windows 11 aswell and wish to know if you have found a solution to this.

i figured out the issue, i had some issues with audio so i reset my pc and selected "keep files"(note: this will delete all of your apps and their settings{if you do this please back up your saved firefox passwords/profile date. look online to figure out how to back up these files}) anyway, when i was updating windows 11 to the latest version i noticed an optional optimization update for ".NET 3&4" in the additional/optional update section of windows update, do not install this optional update, as for some reason it seems to break steam achievement manager, SAM is currently working for me again.

How can I contact you?

Can you give me your contact information?


Update Infomation

Describe the enhancement

Move Senior Front-end Engineer at Jabil to Work Experience.
Move Notebook back to Relevant Projects

Add Docker as the skill used for Notebook

git fetch origin
git checkout 114-update-infomation


deps: bump ZLint dependency to v2.2.1.

This also requires changing the import path in main.go to match the v2 major release.
Resolves https://github.com/zmap/zcertificate/issues/15

Travis is taking forever to queue this build. I'll check back on this branch after dinner and merge if green.


📐 Add Comments to Implementation of a Custom Form

📐 Add Comments to Implementation of a Custom Form
Work with a partner to add comments describing the functionality of the code found in Unsolved/assets/css/style.css.

🏆 Bonus
If you have completed the activity and want to further your knowledge, work through the following challenge with your partner:

What are ARIA attributes, and when would you need to use them?

Use Google or another search engine to research this.

© 2022 Trilogy Education Services, LLC, a 2U, Inc. brand. Confidential and Proprietary. All Rights Reserved.

done


radicle-upstream: 0.2.9 -> 0.2.10

Motivation for this change
Bump versions
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 136245 run on x86_64-linux 1

1 package built:

radicle-upstream


Cannot download temporal_adapter.ckpt (fatal: temporal_adapter.ckpt: smudge filter lfs failed)

When I run the command git clone https://huggingface.co/ymzhang319/FoleyCrafter checkpoints/ I get the following.
Does anyone know how to fix this?

Cloning into 'checkpoints'...
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (20/20), done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 24 (delta 3), reused 0 (delta 0), pack-reused 4 (from 1)
Unpacking objects: 100% (24/24), 6.50 KiB | 30.00 KiB/s, done.
Downloading temporal_adapter.ckpt (4.3 GB)| 93.49 MiB/s
Error downloading object: temporal_adapter.ckpt (4c269a0): Smudge error: Error downloading temporal_adapter.ckpt (4c269a0c1a4aef7c2e015535e60d86b00d83f0e8dc77f26ef3227d5dbb00e066): expected OID 4c269a0c1a4aef7c2e015535e60d86b00d83f0e8dc77f26ef3227d5dbb00e066, got 54575474c69a0c949bddbdc85fc9d5c2e560eb9cf0b3bed749da4538f62262f5 after<PHONE_NUMBER> bytes written
Errors logged to '/my/path/FoleyCrafter/checkpoints/.git/lfs/logs/20240831T141401.606401786.log'.
Use git lfs logs last to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: temporal_adapter.ckpt: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

yeah. get the file by hand. put it in the place.


feat: exchange

Add implementation of the exchange construct.
I had to make various changes throughout, starting from the creation of new message types and their corresponding handling, both in the network and the Aggregate Context. I've added tests for the 'exchange' feature and removed the old constructs of 'sharing,' 'neighbouring,' and 'repeating,' which will need to be implemented using 'exchange'. As a result, it's highly likely that the CI will break temporarily because the associated tests won't compile.

A little note on the KDoc:
do not use the @param keyword but instead use the [<param_name>] syntax.
For example:
/**
 * Sends a [message] of type [T] to a [receiver].
 */
fun <T> send(receiver: Int, message: T): Unit

As can you see, the doc is written in natural language embedding the reference to the variables directly in the sentences.

I suggest using a consistent test style: in some tests StringSpec is used, and in other tests use FreeSpec.


Cookie value set from API is URL Encoded twice from deployed SWA

When setting a cookie in a C# API, cookie value is URL encoded twice from an SWA deployed to Azure, but once (as expected) when running locally. Problem observed running in Microsoft Edge. This causes a problem for reading the cookie from the API - namely that the API must conditionally URL decode the cookie value.
To Reproduce
Steps to reproduce the behavior:

See sample repository for code: https://github.com/jwarner00/swa-cookie-repro
Alternativly, create a API function that sets a cookie, and an API funciton that reads that cookie:

set function - see https://github.com/jwarner00/swa-cookie-repro/blob/main/api/CookeFunctions.cs
// ...
var payload = new SamplePOCO()
{
    Name = "Bob Smith",
    Age = 32
};

var cookieText = JsonConvert.SerializeObject(payload);

req.HttpContext.Response.Cookies.Append(CookieName, cookieText, new CookieOptions()
{
    Expires = DateTime.Now.AddMinutes(60)
});
// ...

get function - see https://github.com/jwarner00/swa-cookie-repro/blob/main/api/CookeFunctions.cs
// ...
try
{
    var foundCookie = req.Cookies.TryGetValue(CookieName, out var cookieText);
    if (!foundCookie)
    {
        return new OkObjectResult($"Could not find cookie with name {CookieName}");
    }

    log.LogInformation(cookieText);
    var cookieObj = JsonConvert.DeserializeObject<SamplePOCO>(cookieText);

    return new OkObjectResult(cookieObj);
}
catch (Exception ex)
{
    log.LogError(ex, "Unhandled error in GetCookie");
    return new OkObjectResult($"Error: Unhandled exception in GetCookie: {ex.ToString()}");
}
// ...

Run the application locally. Navigate to /api/setcookie to set the cookie. Navigate to /api/getcookie to read the cookie. You should get an OK response with the text "{"name":"Bob Smith","age":32}"
Deploy the application to a new Azure Static Web App. Use deployment task that follows or see https://github.com/jwarner00/swa-cookie-repro/blob/main/pipelines/deploy.yml

      - task: AzureStaticWebApp@0
        inputs:
          skip_app_build: true
          api_location: 'api/'
          app_location: 'src/'
          azure_static_web_apps_api_token: $(dev_deployment_token)

Once the application is deployed, navigate to the deployed application at /api/setcookie to set the cookie. Navigate to /api/getcookie.

Expected: See "{"name":"Bob Smith","age":32}" as in local development
Actual: Exception was thrown. Sample code generates this output:

Error: Unhandled exception in GetCookie: Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: %. Path '', line 0, position 0.
at Newtonsoft.Json.JsonTextReader.ParseValue()
at Newtonsoft.Json.JsonTextReader.Read()
at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
at Repro.Function.CookeFunctions.GetCookie(HttpRequest req, ILogger log) in /working_dir/api/CookeFunctions.cs:line 66

Compare cookie from running locally and in deployed code in browser dev tools. Note that if you URL decode the cookie that is set by the deployed function, you get the value of the cookie set by the local function. Deployed funciton appears to be URL Encoding the value again somewhere.

Source Repository: https://github.com/jwarner00/swa-cookie-repro
Device info (if applicable):
Issue tested in browsers: Microsoft Edge, Firefox

Hi @jwarner00, we located the problem and the issue will be fixed with the next release.


aria

integrate radix primitives into components for keyboard navigation

@abernier I'd use react-aria-components instead of radix

why rac over radix-primitives ?

@abernier radix-ui hard to test sometimes, composition is a bit tricky in some cases, react-aria/react-aria-components better composition and accesibility

https://argos-ci.com/blog/react-aria-migration
https://syntax.fm/show/751/ui-components-shadcn-tailwind-ui-headless-react-aria-radix-ui

did you used them both already?

although I'm considering RAC for search... (which radix-primitives does not seem to have components for)

@abernier I've used both

wip https://github.com/pmndrs/docs/pull/329


libcdio-0.82 not building

Issue description
Relevant-looking bit of stderr:
Making all in cdio++
make[3]: Entering directory '/tmp/nix-build-libcdio-0.82.drv-0/libcdio-0.82/lib/cdio++'
/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash ../../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include/ -I../../include    -g -O2 -c -o iso9660.lo iso9660.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include/ -I../../include -g -O2 -c iso9660.cpp  -fPIC -DPIC -o .libs/iso9660.o
In file included from ../../include/cdio++/iso9660.hpp:29:0,
                 from iso9660.cpp:24:
../../include/cdio/iso9660.h:277:45: error: flexible array member 'iso9660_dir_s::filename' not at end of 'struct iso9660_pvd_s'
   char             filename[EMPTY_ARRAY_SIZE];
                                             ^
../../include/cdio/iso9660.h:310:20: note: next member 'char iso9660_pvd_s::root_directory_filename' declared here
   char             root_directory_filename;      /**< Is '\\0' or root
                    ^~~~~~~~~~~~~~~~~~~~~~~
../../include/cdio/iso9660.h:283:8: note: in the definition of 'struct iso9660_pvd_s'
 struct iso9660_pvd_s {
        ^~~~~~~~~~~~~
../../include/cdio/iso9660.h:277:45: error: flexible array member 'iso9660_dir_s::filename' not at end of 'struct iso9660_svd_s'
   char             filename[EMPTY_ARRAY_SIZE];
                                             ^
../../include/cdio/iso9660.h:424:20: note: next member 'char iso9660_svd_s::root_directory_filename' declared here
   char             root_directory_filename;      /**< Is '\\0' or root
                    ^~~~~~~~~~~~~~~~~~~~~~~
../../include/cdio/iso9660.h:392:8: note: in the definition of 'struct iso9660_svd_s'
 struct iso9660_svd_s {
        ^~~~~~~~~~~~~
../../include/cdio/iso9660.h:277:45: error: flexible array member 'iso9660_dir_s::filename' not at end of 'class ISO9660::PVD'
   char             filename[EMPTY_ARRAY_SIZE];
                                             ^
../../include/cdio/iso9660.h:310:20: note: next member 'char iso9660_pvd_s::root_directory_filename' declared here
   char             root_directory_filename;      /**< Is '\\0' or root
                    ^~~~~~~~~~~~~~~~~~~~~~~
In file included from iso9660.cpp:24:0:
../../include/cdio++/iso9660.hpp:43:9: note: in the definition of 'class ISO9660::PVD'
   class PVD  // Primary Volume ID
         ^~~
make[3]: *** [Makefile:407: iso9660.lo] Error 1
make[3]: Leaving directory '/tmp/nix-build-libcdio-0.82.drv-0/libcdio-0.82/lib/cdio++'
make[2]: *** [Makefile:296: all-recursive] Error 1
make[2]: Leaving directory '/tmp/nix-build-libcdio-0.82.drv-0/libcdio-0.82/lib'
make[1]: *** [Makefile:427: all-recursive] Error 1
make[1]: Leaving directory '/tmp/nix-build-libcdio-0.82.drv-0/libcdio-0.82'
make: *** [Makefile:322: all] Error 2
builder for ‘/nix/store/8jh3yvc2g7y706ggrg0b4r9m6ci4acdf-libcdio-0.82.drv’ failed with exit code 2
error: build of ‘/nix/store/8jh3yvc2g7y706ggrg0b4r9m6ci4acdf-libcdio-0.82.drv’ failed

Steps to reproduce
cd nixpkgs
nix-bulid . -A libcdio082

This version is required by, amongst other things, cmus and abcde.
Technical details

system: "x86_64-linux"
host os: Linux 4.9.80, NixOS, 18.03.git.e860b65 (Impala)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.16
channels(root): ""
nixpkgs: /home/james/nixpkgs

For reference, this broke on updating gcc: 6.x -> 7.x.

I looked into this a bit and it seems that both cmus and abcde can be built with newer libcdio (the libcdio attribute) however doing so requires packaging additional dependency https://github.com/rocky/libcdio-paranoia (which I assume was split off into a separate project / package at some point?). And since nothing else in the nixpkgs tree seems to depend on libcdio082 it could perhaps be dropped entirely?

Implemented in https://github.com/pbogdan/nixpkgs/tree/libcdio082-removal in case anyone finds it useful but not sure how to test properly beyond checking things build (I don't actually use any of the affected packages).

Thanks for getting this done so quickly. I'll test both cmus and abcde in the next day or so.

Okay, they both work.

Pushed the commits to master: cc4677c36ee8 and ancestors.


outfit is not saved

outfit is not saved.
I followed the documentation exactly.
I've read several times that it doesn't work.

Everything is in the documentation and it works if you follow the docs properly


Fix Travis CI integration

Right now all pull requests are failing because of the current configuration at Travis CI. A basic jekyll build should be enough that the template is not fundamentally broken.

@TaylanTatli could you please merge this, or comment if necessary? I'd like your repository to include this fix as well.


Configuration dataflow

Currently, the configuration for the model is

Stored as defaults
Stored in the config files, the names of which are passed as command line arguments
Read from command line arguments as ultimate overrides

This works fine as the model currently stands, but needs to be more sophisticated as the model gets more complex and users begin to need to save, restore and inspect the settings of a given model run.
Some command line help information wouldn't go amiss either.

I have included Anton as someone who has had something to say on such matters in the past.

The current status you describe above is the same as we have for Lagrangian neXtSIM, and I think it works well.
In addition, we also write out a log into the output directory which contains all options and the git revision used. This has been indispensable for me, personally, when trying to figure out what changes what. So, I would say such a log, plus simply copying the config file to the output directory (as we also do now) should be sufficient for the user to be able to go back and see what options etc. were used in a run. I agree that putting this into the output files is overkill.
We now also want the config options to be put into the restart file, which I think is a good idea. In that case, we have the following priority for options:

Defaults in the code
Overridden by options read in from restart file
Overridden by options read in from config file
Overridden by options read in as command-line options

How does that sound? I guess the log should contain a list of overrides, in an easily parseable way. Not sure what that would look like yet.
As for keeping track of changes to options and defaults, then it gets a bit hairy. Changing defaults, option names, etc, is an interface change which will lead to unexpected changes in results if you're not paying attention. So, if we do that we should bump the major version of the whole model ... which is not feasible. Not sure what's best here(!)

A thought on versioning - which is becoming a bit removed, but ok: We could have a versioning of w.x.y.z, where
w: Major physics changes like new rheology or thermodynamics or discretisation is now the default
x: Interface changes (new default options for configs, basically)
y: New features, but they're not the default
z: Bug fixes
The difference between w and x is largely subjective, but I think it may be needed anyway.

I don't think we have to or should stick rigidly to Semantic Versioning and its rules. Especially since the first rule is

Software using Semantic Versioning MUST declare a public API.

We certainly don't do that. So we could change config defaults without changing the major version number, if that's what we say we are doing. And keep documenting changes in comprehensive changelogs.
My suggestion is a year.build (or year.release) version system.

Two things that are required from the configuration that are not currently possible:

A list of all current configuration options in a running model, to be output at metadata to the restart file.
Help text and options for all possible module implementations, their configuration options and sub-modules, to be available as help text on the command line.

If the help text used in point 2 can be used to generate offline documentation, then all the better.
This means that the configurations passed in on the command line and in the configuration files needs to be cached in some structure which has knowledge of the current or total available configuration.
But without it all being written in one big ol' file.

Test of the configuration option help markdown output:

CCSMIceAlbedo
CCSMIceAlbedo.iceAlbedo
numeric    range: 0—1  (default = 0.538000)
Albedo of snow-free ice.
CCSMIceAlbedo.snowAlbedo
numeric    range: 0—1  (default = 0.825600)
Albedo of snow.
FiniteElementFluxes
nextsim_thermo.drag_ocean_q
numeric    range: 0—∞ ?? (default = 0.001500)
Coefficient for evaporative mass flux calculation.
nextsim_thermo.drag_ocean_t
numeric    range: 0—∞ ?? (default = 0.000830)
Coefficient for sensible heat flux calculation.
nextsim_thermo.drag_ice_t
numeric    range: 0—∞ ?? (default = 0.001300)
Ice drag coefficient for heat fluxes.
nextsim_thermo.albedoW
numeric    range: 0—∞  (default = 0.070000)
Shortwave albedo of open ocean water.
nextsim_thermo.I_0
numeric    range: 0—∞  (default = 0.170000)
Transmissivity of ice.
HiblerSpread
Hibler.h0
numeric    range: 0—∞ m (default = 0.250000)
The thickness of newly frozen ice.
Hibler.phiM
numeric    range: 0—∞  (default = 0.500000)
Power-law exponent for melting ice.
IceGrowth
nextsim_thermo.min_conc
numeric    range: 0—1  (default = 0.000000)
Minimum allowed ice concentration.
nextsim_thermo.min_thick
numeric    range: 0—∞ m (default = 0.010000)
Minimum allowed ice thickness.
MissingData
model.missing_value
numeric    range: -∞—∞  (default = -2³⁰⁰)
Missing data indicator used for input and output.
Model
model.start
string
Model start time, formatted as an ISO8601 date. Non-calendretical runs can start from year 0 or 1.
model.stop
string
Model stop time, formatted as an ISO8601 data.  Will be overridden if a model run length is set.
model.run_length
string
Model run length, formatted as an ISO8601 duration (P prefix). Overrides the stop time if set.
model.time_step
string
Model physics timestep, formatted a ISO8601 duration (P prefix).
model.init_file
string
The file path to the restart file to use for the run.
Modules
Modules.Nextsim::IVerticalIceGrowth
module [Nextsim::ThermoIce0]
The module which calculates the one-dimensional ice thermodynamics.
Modules.Nextsim::ILateralIceSpread
module [Nextsim::HiblerSpread]
The module for calculating the freezing and thawing of ice on the ocean surface.
Modules.Nextsim::IFluxCalculation
module [Nextsim::FiniteElementFluxCalc]
The module for calculating surface-atmosphere exchange fluxes.
Modules.Nextsim::IIceAlbedo
module [Nextsim::SMUIceAlbedo, Nextsim::SMU2IceAlbedo, Nextsim::CCSMIceAlbedo]
The module for calculating the albedo of the ice surface.
Modules.Nextsim::IIceOceanHeatFlux
module [Nextsim::BasicIceOceanHeatFlux]
The module for calculating the ice-ocean heat fluxes.
Modules.Nextsim::IDiagnosticOutput
module [Nextsim::SimpleOutput]
The module controlling the output of NetCDF files containing diagnostic model data.
Modules.Nextsim::AtmosphereState
module [Nextsim::DummyAtmosphereState]
The module selecting how the state of the atmosphere is obtained.
Modules.Nextsim::OceanState
module [Nextsim::DummyOceanState]
The module selecting how the state of the ocean is obtained.
ThermoIce0
thermoice0.ks
numeric    range: 0—∞ W K⁻¹ m⁻¹ (default = 0.309600)
Thermal conductivity of snow.


Update configure-self-sign-up.md to reflect the repositioning of the self signup pane

Purpose

$subject

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix Bugs, Refractor EditPersonDescriptor, Implement Test Cases and Code Quality

Fix bugs in EditEmployee
Refractor EditPersonDescriptor to EditEmployeeDescriptor
Implement test cases for DeleteEmployee, DeleteTask, EditEmployee, MarkTask and UnmarkTask
Review Javadocs and code quality for DeleteEmployee, DeleteTask, EditEmployee, MarkTask and UnmarkTask
Make minor edits to spacing and code comments in PersonListPanel.java and TaskListPanel.java
Improve code quality of TaskCard.java

Codecov Report

Merging #309 (259780b) into master (8b900e2) will increase coverage by 1.98%.
The diff coverage is 71.87%.

@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
+ Coverage     69.56%   71.55%   +1.98%
- Complexity      785      820      +35
============================================
  Files           107      107
  Lines          2645     2654       +9
  Branches        321      318       -3
============================================
+ Hits           1840     1899      +59
+ Misses          721      671      -50
  Partials         84       84

Impacted Files
Coverage Δ

...rc/main/java/manageezpz/commons/core/Messages.java
0.00% <ø> (ø)

...nageezpz/logic/commands/DeleteEmployeeCommand.java
84.21% <ø> (ø)

...ava/manageezpz/logic/commands/MarkTaskCommand.java
100.00% <ø> (+100.00%)
:arrow_up:

...a/manageezpz/logic/commands/UnmarkTaskCommand.java
100.00% <ø> (+100.00%)
:arrow_up:

src/main/java/manageezpz/ui/PersonListPanel.java
0.00% <ø> (ø)

src/main/java/manageezpz/ui/TaskCard.java
0.00% <0.00%> (ø)

src/main/java/manageezpz/ui/TaskListPanel.java
0.00% <ø> (ø)

...a/manageezpz/logic/commands/DeleteTaskCommand.java
50.00% <50.00%> (+50.00%)
:arrow_up:

...manageezpz/logic/commands/EditEmployeeCommand.java
85.71% <100.00%> (+0.20%)
:arrow_up:

...geezpz/logic/parser/EditEmployeeCommandParser.java
100.00% <100.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b900e2...259780b. Read the comment docs.


Allow easy linking to news items

The anchors have IDs but it's not obvious.

I've fixed the news archive page so that the links in the left-hand menu now work sensibly.
So to get a link to a news item, click on it in the left hand menu, then copy and paste the URL from the location bar.


Block commenting?

Does Light Table have the ability to highlight a block and convert it all to a comment (or uncomment if it's already commented). I forgot to mention it, but in the survey you just conducted which asked what is keeping you from using Light Table as your primary editor, this is a big one for me.

For future generations, this one way to accomplish pressing pmeta (command on OSX) + / while text is highlighted in order to toggle highlighting.
[:editor.active "pmeta-/" :toggle-comment-selection]

(add this line through Light Table by pressing ctrl+space, then choosing "Settings: User keymap")
Is this possibly too much hand-holding for developers; for sure. But I would have appreciated this post when working to make it happen myself.
Granted, I'm a newbie.


Powershell integrated terminal issue on Windows Server 2016

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.59.0
OS Version: Windows server 2016

Steps to Reproduce:

When I try to rerun the debugger in vs code using powershell integrated console, the bar at the bottom does not turn orange. I cannot run the debugger again. I need to restart the powershell session. So far this is only happening on Windows server 2016. This is a recent issue and happened after I update VS code to 1.59.0

What debugger are you using?

I am using the debugger in VS code. I have Powershell launch current file selected. What specific info do you need and where can I find it?

VS Code's only built-in debugger is for JavaScript/TypeScript. All other debuggers are separate extensions.
Are you using the built-in JavaScript debugger?

Hello,
This is the code in my launch.json file. Does this help?
{
"version": "0.2.0",
"configurations": [
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch Current File",
"script": "${file}",
"args": [],
"cwd": "${file}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch Current File in Temporary Console",
"script": "${file}",
"args": [],
"cwd": "${file}",
"createTemporaryIntegratedConsole": true
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch Current File w/Args Prompt",
"script": "${file}",
"args": [ "${command:SpecifyScriptArgs}" ],
"cwd": "${file}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch DebugTest.ps1",
"script": "${workspaceRoot}/DebugTest.ps1",
"args": ["-Count 55 -DelayMilliseconds 250"],
"cwd": "${workspaceRoot}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Interactive Session",
"cwd": "${workspaceRoot}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Pester Tests",
"script": "Invoke-Pester",
"args": [],
"cwd": "${workspaceRoot}"
},
{
"type": "PowerShell",
"request": "attach",
"name": "PowerShell Attach to Host Process",
"processId": "${command:PickPSHostProcess}",
"runspaceId": 1
}
]
}

Please note this happens even I don't use the debugger. I can't run the scripts regularly twice in a row. I need to keep having to restart the current PowerShell.

You seem to use the PowerShell debugger (which is not part of VS Code but a separate extension).
Please file the issue against the PowerShell extension.

/extPowershell


Microsoft.Compute/virtualMachines/extensions Resource Not Found

I'm getting an error when trying to pull the additional metrics from the VM Extensions namespace:
esponse:Object
error:Object
code:"ResourceNotFound"
message:"The Resource 'Microsoft.Compute/virtualMachines/extensions' under resource group '****' was not found."
Doesn't look like a permission issue as Datadog was able to pull these using the same credentials.

I'm seeing something similar. Can you see any metrics for vm extensions in the azure portal?

Yes I can see the extension metrics in the portal - I could also see them when using another tool - datadog.

I think this and #46 are related. Diagnostics data is stored in Table storage and can be accessed only via Storage API.

Hello, i am having the same problem i am using azure grafana plugin to see metrics, but then i want to see disk space in / and for that i have installed LinuxDiagnostics to my VM  version 3.0, then from grafana i get Resource Not found.

How can i visualise that kind of metrics in grafana, is it possible at all?

I gave up on this extension and installed telegraf on the VMs to extract the metrics I need

Hello, i am having the same problem i am using azure grafana plugin to see metrics, but then i want to see disk space in / and for that i have installed LinuxDiagnostics to my VM version 3.0

Then from grafana i get Resource Not found.

How can i visualise that kind of metrics in grafana, is it possible at all?

Any updates about this issue? I have the same problem :(

Sorry mate...
the guys seems focused on other issues... support seems very low... better
look for workaround bro... this aint getting done to work :/
Regards
Valentin
On Thu, Sep 27, 2018 at 7:28 PM Andre Minelli<EMAIL_ADDRESS>wrote:

Hello, i am having the same problem i am using azure grafana plugin to see
metrics, but then i want to see disk space in / and for that i have
installed LinuxDiagnostics to my VM version 3.0
[image: screen shot 2018-06-22 at 22 26 09]
https://user-images.githubusercontent.com/10477248/41797866-e5b72756-766b-11e8-8bc0-4fbef4f54971.png
[image: screen shot 2018-06-22 at 16 57 29]
https://user-images.githubusercontent.com/10477248/41783559-66ec422c-763d-11e8-92b0-9c52814e20fe.png
Then from grafana i get Resource Not found.
[image: screen_shot_2018-06-22_at_16_55_52]
https://user-images.githubusercontent.com/10477248/41793770-6dc28b90-765d-11e8-8b98-60160a1aeaec.png
How can i visualise that kind of metrics in grafana, is it possible at all?
Any updates about this issue? I have the same problem :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/grafana/azure-monitor-datasource/issues/41#issuecomment-425157695,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ_ewIe_ApNeyyjEHCb_S_B-FVZKNIFDks5ufPzFgaJpZM4Sv0gN
.

I just installed the telegraf client on the machine and collected my metrics that way

@oxie

i hate it how they promote grafana as the No1 Tool for
monitoring and then its so sucky at parts

Hey, this is open source - it didn't cost you a cent. The rest of your comment doesn't make much sense. Not sure who "they" is or what you mean by no db etc.
@bleep-io telegraf is a great solution - sounds like a very reliable way to collect metrics.
I never really got any good data in this thread to help me troubleshoot this. This stuff is totally undocumented.
I'm looking at a virtual machine with a couple of extensions:

And I don't see any of those metrics in the Azure Portal which makes it hard to reverse engineer the api.


library not found for -lphp7

I use Mac OS. I got php7 installed.
 /usr/bin/php -v
PHP 7.1.16 (cli) (built: Mar 31 2018 02:59:59) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies

but when i execute "go get github.com/deuill/go-php" i getting this error:
# github.com/deuill/go-php
ld: library not found for -lphp7
clang: error: linker command failed with exit code 1 (use -v to see invocation)
# github.com/deuill/go-php
engine.c:43:10: warning: enumeration values 'SAPI_HEADER_DELETE_ALL' and 'SAPI_HEADER_SET_STATUS' not handled in switch [-Wswitch]
engine.c:43:10: note: add missing switch cases
engine.c:97:2: warning: incompatible pointer types initializing 'void (*)(char *, int)' with an expression of type 'void (char *)' [-Wincompatible-pointer-types]
# github.com/deuill/go-php
receiver.c:79:1: warning: control reaches end of non-void function [-Wreturn-type]
# github.com/deuill/go-php
value.c:121:47: warning: incompatible pointer types passing 'unsigned long *' to parameter of type 'zend_ulong *' (aka 'unsigned long long *') [-Wincompatible-pointer-types]
../github.com/deuill/go-php/include/php7/_value.h:14:87: note: passing argument to parameter 'num_index' here

Hi, in general, most PHP packages do not include the necessary libraries that Go needs to link against. Your best bet is either using the included Docker container (which you can build with make docker-image) for as your compilation environment, or compile PHP for Mac OS X with --enable-embed provided to the ./configure script.
You can also build go-php and link against a static version of the PHP library with the STATIC variable, and can also provide a specific PHP version to build against with the PHP_VERSION variable, e.g. make docker-build STATIC=true PHP_VERSION=7.1.22.
Hope this helps.


Process.fork has dangerous semantics

forkall(Current)
Process.fork currently has forkall semantics with respect to fibers. What this means is that all the fibers which were alive during the Process.fork call remain alive in the forked process.
Advantages

no deadlocks possible due to locked mutexes in contrast to when only a single fiber survives the fork

Disadvantages
Since fd/sockets are shared across forks, fibers which were doing writes will do double writes which will cause:

broken http responses
duplicated data in files
corrupted db queries

Similarly, fd/sockets reads may get divided across forks. So, both processes will see

partial http requests
partial db responses
partial file data

An example of double writes:
spawn do
  5.times do |i|
    sleep rand
    puts "line #{i}"
  end
end
process = Process.fork do
  sleep 10
end

process.wait

Expected output:
line 0
line 1
line 2
line 3
line 4

Actual output:
line 0
line 0
line 1
line 2
line 1
line 3
line 4
line 2
line 3
line 4

IMO, these are really severe disadvantages so these semantics ought to change.
Alternatives
1. fork like semantics (linux/unix)
In this scenario, only the fiber invoking Process.fork lives on in the forked process. Rest of the fibers are either collected(majority of them) and a few core runtime fibers like SignalHandler loop are recreated.
Advantages

no unintentional socket/fd corruption
easy to reason about
similar to how threads would behave once thread-support lands

Disadvantages

Deadlocks: Any attempt to lock a mutex which was locked in non forking Fiber will result in a deadlock. This is manageable when you own the mutexes but if mutexes belong to stdlib/shard then deadlocks are more or less imminent. pthread_atfork like api for fibers may help here though i am not sure how successful that will be.

2. Disable fork without exec (go/erlang)
This approach is in line with what go and erlang takes. They find fork too difficult to implement correctly in a multi-threaded/multi-fiber/multi-actor environment that they don't even bother implementing it.
Disadvantages

won't be able to daemonize the process using the double fork technique but can definitely use a C binary which exec()s to a crystal binary.

Conclusion
Personally, I would prefer that fork without exec be removed from the stdlib so there's no risk of deadlocks or data corruption.
PS: I've been implementing a supervisor clone in crystal which gave me an opportunity to look deeper into Crystal's internals.
#6416  is also caused by forkall behaviour. I'll provide a root cause analysis in that thread.

Yes, I'd like that too. We have fork because we had it before we went with non-blocking IO and fibers like Go. Now that did that, it's probably time to remove fork (which also doesn't exist in Windows...)

Another reason: the experiments on trying to bring multithread support to Crystal were difficult to achieve, and getting fork to work was one of the reasons (not the reason, but one of them).

I used your example and ran it... got a similar input... I have scanned over the source code to see what's going on.
I do kind of see what you are suggesting, and how it's possibly happening. I agree with the fact that the implementation of fork needs to be improved, but I don't think that we have to throw it away either.
I tweaked your example and ran a comparable in Ruby for expected output.  I am fearful of runaway processes, so I will always use a wait.
`
chan = Channel(Nil).new
spawn do
10.times do |i|
sleep rand
puts "line #{i}"
end
chan.send(nil)
end
t = Process.fork do
sleep 1
end
chan.receive
t.wait
`
I didn't quite the same output:
line 0 line 0 line 1 line 1 line 2 line 3 line 4 line 5 line 6 line 7 line 8 line 9
Do you think that the differences my be OS related?

Ah, the output was from 5.times and not 10.times. Edited my original post to reflect that. Also added process.wait.
@98-f355-f1  You are only getting line 0 twice because your forked process is only sleeping for 1 sec. Increase it to see similar output.
I think the only way to improve fork while keeping it would be implement forkone semantics but then we'll have to worry about mutexes and deadlocks. I am not sure if that will be considered an improvement.
So removing it is the safest choice.
see
https://thorstenball.com/blog/2014/10/13/why-threads-cant-fork/
https://news.ycombinator.com/item?id=8449164

Random idea: can we allow it only before any user fibers, or generally any fibers not explicitly marked as safe for fork, are created?

I'm leaning towards both positions (keep or remove) but I still lean a bit on the keep it side.
Yes, fork is dangerous, it can lead to disasters if invoked at whatever time; you should never have to use it; except for some rare edge cases where it makes sense on a POSIX system in a controlled environment (e.g. zero downtime binary reloads) without requiring C.
Just like daemonizing, I believe we should have a proper fork handling (that fixes a few bolts, like reseeding rand), mark it as unsafe and document it as very dangerous. Maybe remove the global ::fork and keep only Process.fork. I think it's better than having users just call LibC.fork manually (never do that).
I think it's possible to keep fork with a multithreaded event loop. The GC must signal all threads to stop before it can start collecting memory, fork must do the same (unless it's a fork/exec).

fork is need for example here: https://github.com/kostya/curl-downloader, i not find any efficient ways except fork. just write some danger comment for all who wants to use fork.

I think we should remove plain Process.fork from the stdlib.
fork is not supported on win32 at all. That makes it a very platform-specific feature which we would like to avoid in stdlib.
On other platforms, there are difficulties with fibers and it's entirely unsupported with multithreading enabled. AFAIK this can't work reliably ever. In a forked process only one thread continues which makes it error-prone. So with MT moving forward, future use cases look very slim.
This answer on SO explains the issues with fork in Golang, which should apply exactly to Crystal as well: https://stackoverflow.com/a/28371586/7401689
As a replacement, fork could be made available in a platform-specific shard which can be added as a dependency for the few use cases where you would really want to use bare fork behaviour.
fork immediately followed by exec would obviously still be required as implementation for Process.exec on POSIX platforms.

fork can be kept under a platform-specific module. This modularization is common in other languages.

I think we can keep platform depended apis along with their logical modules but mark them as so. If someone uses them he should know about consequences (i.e non-portability). See my proposal about this concept - #8524.

I finally changed my mind on fork. Keeping support would require a lot of work and lots of bugs to fix, especially with MT (we already had a bunch with a single thread) but... for what purposes?

Daemonizing a process? There are many tools specialized to spawn, monitor and log processes starting from init systems themselves nowadays. They'll do a better job, and lets users use whatever they prefer, rather than each application re-doing everything (that probably won't be used because users will use external tools).
Sharing a server socket? This is a legit use-case (and performance easily beat MT), but we can create the socket with SO_REUSEPORT and just start multiple processes.
Take advantage of multiple cores, then communicating in some ways (e.g. through sockets)? Use an IPC protocol (e.g. ZMQ, AMQP server) and start multiple processes, or plain UNIX sockets.

Let's not bother.

The only concevable use of fork would be to insert safe privilege-dropping commands like a chroot or setrlimit between the fork and the exec. This would be useful for a container scheduler for example.
I would support an unsafe non-documented API to make these happen if someone was interested in the capability, but otherwise i'm fully in support of pulling fork.

I would support an unsafe non-documented API to make these happen if someone was interested in the capability, but otherwise i'm fully in support of pulling fork.

That would certainly be better placed in a documented API of a dedicated shard.

@straight-shoota well Process.exec needs to be part of the stdlib, and it can't be obvious or documented how to use the post-fork exec callback since it's very unsafe. I don't see how this could be a shard.


Miscellaneous proof taming

Proposed changes
Hi. I'm working on switching the default Z3 version to the latest master and making sure our projects still verify. This is part of the tweaks I had to do to HACL* to get it to work with the newest Z3.
I have some more locally, but some of them are slightly suspect and I would like to confirm they are not Z3 regressions. The ones here however seems like all around improvements, and still verify with Z3 4.8.5.
Types of changes
What types of changes does your code introduce to HACL*?
Put an x in the boxes that apply

[x] Proof maintenance (non-breaking change which fixes a proof regression)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New algorithm or feature (non-breaking change which adds functionality)
[ ] Improved performance (fix or feature that would improve performance of some algorithm on some platform)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CODE_OF_CONDUCT.md doc
[x] I have read and agree to submit my changes under the LICENSE
[ ] I have added necessary documentation (if appropriate)
[ ] I have edited CHANGES.md (if appropriate)

Hi Jonathan. I think it's just that the new Z3's heuristics are slightly different, and then proofs that are "close to edge" can just fail, and need some tweaking. (The F* I'm using for the SMT upgrade is exactly the current master, just flipping the default Z3 version.) Most of this PR is just rlimit tweaks and some sanity assertions.
Some good practices I try to follow when stabilizing are:

Never use #set-options/#reset-options, use #push-options/#pop-options instead. Unless it's something that must apply to the whole file, if so #set-options is OK. This is just to make it easier to follow the current rlimit/fuel/smtopt settings.
Keep --hint_info on to see what's happening with the queries.
If a definition is generating hundreds of queries, the auto split may have kicked in to report a better error location. I find it's usually better to keep --split_queries no or --split_queries always. (Some related info here)
Use --quake 1/10/k while proof taming to get an estimate of stability, it will try every query 10 times and report the success rate, accepting it if at least one succeeded.
Using that and the "sliding admit style", it's usually easy to find the hard assertions in a proof. For those, attempt assert_spinoff to try to prove them in a separate query, and assert_norm.
If one particular assertion requires more rlimit/fuels, set them for that assertion only using a tactic, like this (from this PR):

        assert (state_eq_S true s1_orig s2_orig /\ state_eq_S true s1 s2)
            by (let open FStar.Tactics in
                set_rlimit 100;
                ());

The "global" rlimit should ideally remain small.

If all else fails, using --retry 5 can help advance.

Not really deep insights... but it's most of the procedure I use to make stuff more robust.
I'm thinking of adding a quake variant that will create a logfile with some robustness info, which we can then pick up and summarize for each project (similar to the resource monitoring stuff). Maybe we can have a nightly/weekly job that tries everything 20 times and reports the least stable proofs.

I'm a bit worried about the additions of --retry 5, it seems like unstable proofs would fly under the radar more easily.

Yes, totally reasonable. If you prefer, we can drop that commit from this PR and wait for the next set of changes for the new Z3.

To be superseded soon :-)


If you try to import from data-library and fails, disappear from the list

Problem
I've trying to import a dataset from data-library without connection and failed. After that I don't have the datasets imported and has disappear from the data-library list
Solution
If there is an import error we should not add to external_data_import so we could re-import the dataset

Note to self: Fix at #https://github.com/CartoDB/cartodb/blob/master/app/models/data_import.rb#L646


Nextjs can't import minimal bundle

Version
5.1.1
Steps to reproduce
import * as echarts from 'echarts/core' got SyntaxError: Unexpected token 'export'
What is expected?
I hope to enter echart from core
What is actually happening?
But I got error: SyntaxError: Unexpected token 'export'
environment:

Nextjs 10.2.0
Typescript
No next config file

My tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "baseUrl": "./",
    "paths": {
      "@/*": ["src/*"]
    }
  },
  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
  "exclude": ["node_modules"]
}

Echarts-for-react fault
If I import together it will get an error

Next.js currently doesn't support import es module
related discussion:

https://github.com/vercel/next.js/issues/9607
https://github.com/vercel/next.js/issues/25423 (possible workarounds)


123

321

Hi, we are working on a way more recent branch here https://github.com/kivy/kivy3/tree/development


Issue #401: support aggregation query from elasticsearch

See #401 . Support aggregation query like sum, average and etc.

@errordaiwa : #846 is in. Which are the differences/improvements that this PR provides? Is this PR still needed/can be closed?


feat: implement eliasfano32.Min()

feat: implement eliasfano32.Min()
feature:

implement eliasfano32.Min() by calculating lower/upper bits.

refactor:

fix miscalculate of superQSize Annotation

relevant Issue in erigon: https://github.com/ledgerwatch/erigon/issues/5623

Looks great. Most important: "how much % of bytes we touch - and how random distributed they are". If let's say we have MMAP with EliasFano of size: 16 * pageSize - how much pages will we touch? (in average) can it be improved somehow?


是否又评估过OCR能力？

目前看起来，中文的幻觉十分严重。

7B的模型

速度真快！英文OCR咋样？

Thank you for using our model. Currently, DeepSeek-VL only support English OCR. Chinese OCR is planned for our next version update. Please stay tuned and have fun~

If I understand correctly, pretrain and fientune data used in deepseek vl already contains OCR data, especially added Chinese ocr data.
What's the reason why it just learn English OCR ability? I am very cruosity about this.

Thank you for using our model. Currently, DeepSeek-VL only support English OCR. Chinese OCR is planned for our next version update. Please stay tuned and have fun~

Can OCR recognize text coordinates？

If I understand correctly, pretrain and fientune data used in deepseek vl already contains OCR data, especially added Chinese ocr data.
What's the reason why it just learn English OCR ability? I am very cruosity about this.

I also have the same question.


Support @@ to call the last macro

Simply call AtomKeyboardMacros.call_last_kbd_macro() if the 'name' of the macro selected is @ to support the @@ functionality of vim.

Thanks!


Stub out a User Documentation section in the wiki

Start with using https://github.com/facebook/Docusaurus to dump into https://pages.github.com. Publish within the COINSTAC repo, not a separate repo. The pages become code as part of our existing workflow.


chore(pre-commit/flake8): remove entry to avoid running flak8 only on diff

What's the reason behind doing this? This will run flake8 over all the files now right? Seems fine, I'm just interested what the reasoning is.

What's the reason behind doing this? This will run flake8 over all the files now right? Seems fine, I'm just interested what the reasoning is.

e.g: if you remove some code that was using an import and run this, it will not complain because it's running it on the diff, on the other hand flake that's part of CI will and that results in some lint fix commits

Gotcha, ok, thanks.


Add option to generate unformatted XML

Except for debug purpose, pain.001 files should not contains formatted XML in order to take the least possible space on disk.

Thank you for the PR. The space savings are quite significant indeed (almost 50%). I disabled pretty-printing for everyone in 62e53383. If someone really needs it, just use asDom() or use an external service.


Hyrax 2 9

Resolves #217

Coverage increased (+0.0002%) to 98.179% when pulling c5af2cfabeded026a2750e897cd29c208bebd7fe on hyrax-2-9 into 92f433013dee9978a36c06c5a36ee54c0ecd174c on master.


Cancellation Tokens

Please have a look at how I've done this.
I've added cancellation tokens with default tokens as default parameters.
Then, I've added a cancellation token parameter to the algorithm base. I understand this is not intended as a public interface and it does not, therefore, offer a default parameter.
At each stage I've amended the unit tests to compile, however I do not have a plan for unit testing the cancellation tokens themselves.
You might notice at this point most code is not observing the tokens. According to Microsoft's guidelines, a method is not required to act on the token's state, and it is specifically not advised to abort after the primary workload has completed.
With the interfaces in order, various persons can then add code to observe the tokens in strategic points.
My third commit here ("Observe cancellation token in SearchClosestEdge") evaluates the cancellation token (with .ThrowIfCancellationRequested) at the start of two loop bodies in HilbertExtensions.SearchClosestEdge. This is because these loops are where the bulk of the time is spent in the default Router's TryResolve implementation.
If I have time (unconfirmed) I would like to go find a good spot to check for cancellation in Router.TryCalculateRaw, but we should sync up first.

Hey, thanks for having a look through this. At a glance, it looks like you’re right on all points. Furthermore if you or anyone claims to use a given method from outside Itinero, than unless a default parameter is provided, it is a breaking change and therefore incorrect. When I’m in the office on Tuesday I’ll put in a new commit.
Sent from my iPad

On 30 Mar 2018, at 14:46, Joe Amenta<EMAIL_ADDRESS>wrote:
@airbreather requested changes on this pull request.
I understand not adding a default to the AlgorithmBase.DoRun(CancellationToken) method, but why not the public IAlgorithm.Run(CancellationToken) and AlgorithmBase.Run(CancellationToken) methods? When I was actively experimenting with Itinero, I would regularly find myself going a layer down from the static helper methods to re-connect the different pieces for various reasons. It feels awkward having to make all such situations explicitly tell it (in their source code anyway) that they don't care about cancellation.
especially if all it takes to it that way is adding defaults on exactly those two lines
One note about default parameters... using them like this instead of adding overloads is fine for source compatibility, but will break binary compatibility (i.e., downstream consumers will have to target the new library and recompile). I don't know how much binary compatibility matters at this stage, but I wanted to make sure to bring it up.
I also saw a few public static methods where a default was not added (called out on line comments)... not sure if that was intentional, but I didn't see any notes about them.
Regarding usage of ThrowIfCancellationRequested(), it looks like a good start to me in the place you added it. I agree with not adding too much of it right away before syncing up.
In src/Itinero/Algorithms/AlgorithmBase.cs:

@@ -79,19 +80,19 @@ public void CheckHasRunAndHasSucceeded()
///
/// Runs the algorithm.
///

   public void Run()

   public void Run(CancellationToken cancellationToken)

This one feels like it can have a default, eh? See also: comment in IAlgorithm.
In src/Itinero/Algorithms/Contracted/Dual/RouterExtensions.cs:

@@ -32,7 +33,7 @@ internal static class RouterExtensions
/// Calculates a many-to-many weight matrix using a dual edge-based graph.
///
internal static Result<T[][]> CalculateManyToMany(this ContractedDb contractedDb, RouterDb routerDb, Profile profile, WeightHandler weightHandler,

       RouterPoint[] sources, RouterPoint[] targets, T max) where T : struct

       RouterPoint[] sources, RouterPoint[] targets, T max, CancellationToken cancellationToken = new CancellationToken()) where T : struct

In case we have access to C# 7.1 features, CancellationToken cancellationToken = default is less verbose and repetitive.
I think you can do this all at once with a find/replace "CancellationToken cancellationToken = new CancellationToken()" to that, and then repeat for the places where you used "CancellationToken token = new CancellationToken()".
In src/Itinero/Algorithms/IAlgorithm.cs:

@@ -42,7 +44,7 @@ bool HasSucceeded
///
/// Runs the algorithm.
///

   void Run();

   void Run(CancellationToken cancellationToken);

This feels like it could accept a default too... see also: comment in AlgorithmBase.
If you do this (and the counterpart in AlgorithmBase) then I think you can find-replace ".Run(new CancellationToken())" with ".Run()" and shrink the diff down a lot at the end there.
In src/Itinero/Algorithms/Matrices/WeightMatrixAlgorithm.cs:

@@ -104,6 +105,12 @@ protected sealed override void DoRun()
this.HasSucceeded = true;
}

   // Whereas the sample presents this class as a public interface, I have provided this wrapper.

This would probably be unnecessary if Run had a default.
In src/Itinero/Algorithms/Routes/CompleteRouteBuilder.cs:

@@ -470,36 +470,36 @@ private void AppendRoute(Route route, IAttributeCollection shortcutMeta)
///
/// Builds a route.
///

   public static Route Build(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, EdgePath<float> path)

   public static Route Build(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, EdgePath<float> path, CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/CompleteRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>

   public static Result<Route> TryBuild<T>(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, EdgePath<T> path)

   public static Result<Route> TryBuild<T>(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, EdgePath<T> path, CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/CompleteRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>

   public static Route Build(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, List<uint> path)

   public static Route Build(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, List<uint> path, CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/CompleteRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>

   public static Result<Route> TryBuild(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, List<uint> path)

   public static Result<Route> TryBuild(RouterDb db, Profile profile, RouterPoint source, RouterPoint target, List<uint> path, CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/FastRouteBuilder.cs:

@@ -391,37 +392,40 @@ private Speed GetSpeedFor(ushort profileId)
///
/// Builds a route.
///

   public static Route Build(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, EdgePath<float> path)

   public static Route Build(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, EdgePath<float> path,

       CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/FastRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>

   public static Result<Route> TryBuild(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, EdgePath<float> path)

   public static Result<Route> TryBuild(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, EdgePath<float> path,

       CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/FastRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>

   public static Route Build(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, List<uint> path)

   public static Route Build(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor, RouterPoint source, RouterPoint target, List<uint> path,

       CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Routes/FastRouteBuilder.cs:

     }

     /// <summary>
     /// Builds a route.
     /// </summary>
     public static Result<Route> TryBuild(RouterDb db, Profile profile, Func<ushort, Profiles.Factor> getFactor,

       RouterPoint source, RouterPoint target, List<uint> path)

       RouterPoint source, RouterPoint target, List<uint> path, CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Search/Hilbert/HilbertExtensions.cs:

@@ -634,7 +635,8 @@ public static long Distance(this RoutingNetwork graph, int n, uint vertex)
///
///
public static uint SearchClosestEdge(this GeometricGraph graph, float latitude, float longitude,

       float latitudeOffset, float longitudeOffset, float maxDistanceMeter, Func<GeometricEdge, bool> isOk)

       float latitudeOffset, float longitudeOffset, float maxDistanceMeter, Func<GeometricEdge, bool> isOk,

       CancellationToken cancellationToken)

Missed defaulting here?
In src/Itinero/Algorithms/Shortcuts/RouterDbExtensions.cs:

@@ -30,7 +31,7 @@ public static class RouterDbExtensions
///
/// Adds multiple shortcut db's at the same time.
///

   public static void AddShortcuts(this RouterDb routerDb, params ShortcutSpecs[] shortcutSpecs)

   public static void AddShortcuts(this RouterDb routerDb, CancellationToken cancellationToken = new CancellationToken(), params ShortcutSpecs[] shortcutSpecs)

I'm not in love with how this makes the callers look... maybe this is one of those cases where it makes sense to add an overload with the cancellation token at the cost of the cancellation-aware overload's shortcutSpecs not being params?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@airbreather I've changed a bit based on your comments, although I'm putting off using default until @xivk confirms we can use C# 7.1 in this project. What do you think about the interface in Shortcuts/RouterDbExtensions now?

What do you think about the interface in Shortcuts/RouterDbExtensions now?

Hmm, this works just fine for me:
        /// <summary>
        /// Adds multiple shortcut db's at the same time.
        /// </summary>
        public static void AddShortcuts(this RouterDb routerDb, params ShortcutSpecs[] shortcutSpecs) => AddShortcuts(routerDb, shortcutSpecs, new CancellationToken());

        /// <summary>
        /// Adds multiple shortcut db's at the same time.
        /// </summary>
        public static void AddShortcuts(this RouterDb routerDb, ShortcutSpecs[] shortcutSpecs, CancellationToken cancellationToken = new CancellationToken())
        {

That's nice. I didn't know you could do that. I'll stick that in there now.

That looks good now.
One thing to point out is that now the only two files under the test folder that need to change are:

test\Itinero.Test\RouterMock.cs
test\Itinero.Test\Algorithms\Search\MockResolver.cs

It appears that all other changes under test\ could be reverted... I determined this by doing a mass find/replace of Run(new CancellationToken()) to Run(), then comparing the test\ folder to what it was before, and observing that the only remaining changes outside those two files were in the using blocks.

I'll evaluate that now. Thanks for the heads up.

I've gone ahead and reverted the changes to the unit tests.

Looks like 'default' is already in use, in Algorithms/Collections/BinaryHeap.cs line 191. I'm going to go ahead and use it.

If you merge JoeCooper/routing#1, then the number of files touched in this PR should go back down, such that after this PR gets merged, all those files don't show this as their last change...
I did a little trick to revert all of them at once:

Check out original version
Copy test folder off
Check out your branch
Replace the test folder with the copy
Undo changes to the two I identified above
Commit and push to my fork

This looks fine to me now :+1:.
The C# 7.1 default vs. new CancellationToken() thing would be nice to have, but I don't care and it could happen later.

It does tell me explicitly that the project is not configured to use 7.1, but if @xivk allows it than we're good to go on that point too.

Oh, you can approve the PR? I didn't realize you had that relationship to the project. Can you approve a move to 7.1?

Approval just means I reviewed it and I'm OK with it.  I did leave some commentary on #156 endorsing this approach, so I thought it only appropriate that I give feedback on the implementation.

All clear.

For example, one thing I mentioned during my review was overloads vs. default parameters... I'm OK with this myself, but that's only because I don't have any backwards compatibility concerns (my company still isn't using Itinero yet)... @xivk may have other opinions, heh.

Yes, that makes sense. I brought them up in the issue thread because default parameters break the ABI, but Ben decided this was acceptable.

I was out for a week. For various reasons I might not have an opportunity to add more cancellation tests, but if the interfaces are updated, others can add them on their own critical paths on an as needed basis and the feature will accumulate over time.

OK I left some obsolete comments above, I should have read everything first.
This looks really good, it has minimal impact and adds a valuable feature. Thanks a lot!
About the C# 7.1, let's go for it.
About the binary compat issue, what would it take to guarantee this? I guess replacing defaults with overloads everywhere? Most usecases I know of don't upgrade without rebuilding so I don't think it's a big issue but perhaps something to aim for in the future? How do other (well-managed) .NET packages handle this?

@xivk can we use this C# 7.1 feature?

I think so, any downside to using C# 7.1 features at this point? I guess it stops people from using older VS versions?

Yeah, using C# 7.1 features pretty much just makes it so it won't build in VS2017 15.2 and below.  You also have to enable it specifically by putting <LangVersion>X</LangVersion> into a PropertyGroup in the .csproj file where you want to use the stuff, where X is one of:

latest (assuming you're on a new enough VS2017 version)
7.1 (VS2017 15.3 and above)
7.2 (VS2017 15.5 and above)
7.3 (VS2017 15.7 and above, still in preview at the time of writing)

At work, I've advised that we use an explicit version number instead of latest, because it kills builds much earlier and offers a more helpful message if the compiler doesn't support that version instead of just a generic syntax error.  YMMV.

About the binary compat issue, what would it take to guarantee this? I guess replacing defaults with overloads everywhere? Most usecases I know of don't upgrade without rebuilding so I don't think it's a big issue but perhaps something to aim for in the future? How do other (well-managed) .NET packages handle this?

As far as I know, yes, adding overloads is the way to go for this kind of change to ensure both binary and source compatibility.  Adding optional parameters feels like it can be a pretty hard breaking change since it can cascade downstream: assuming perfect NuGet version specs, then in the best case, any packages depending on Itinero that have their own downstream dependents would have to mark their own packages as depending on "pre-CancellationToken" (maximum) or "post-CancellationToken" (higher minimum) versions of Itinero to ensure that applications can't break things simply by bumping up their own version of Itinero, so the default-parameter approach is technically not semver-compliant if this happens before a major version bump (1.x to 2.x).

The correct way to handle this must be overloads, then. When I did this, that did not occur to me.
I will find some time this week to make another commit.

I can pick this up... I don't think there's a sane way to avoid breaking external stuff that adds their own subclasses of AlgorithmBase, but everything else should be easy enough (just tedious, which I'm fine with, since I have some time to kill).

Hmm, right, that brings up an interesting problem: some of the static methods have their own optional parameters other than CancellationToken, e.g.:
public static void SplitLongEdges(this RouterDb db, Action<uint> newVertex = null, CancellationToken cancellationToken = new CancellationToken())

It can't tack on the CancellationToken at the end while still keeping optional values for those other parameters.  So those other optional parameters would become required when calling the method with a CancellationToken overload.
I'm going to go with having callers give explicit values when using a CancellationToken overload for 1.x, with the idea that 2.x can make this specific thing nicer.

My branch cancellation-overloads is more-or-less the size of the approach that uses... I still need to do a bit of self-review on it.
That feels like too much code just to ensure binary compatibility, though.

That feels like too much code just to ensure binary compatibility, though.

I feel like that all the time when adding new features, the technical debt keeps growing. That's why a v2 is long overdue.
That being said the cancellation-overloads branch looks good, if we can bring that in then this is done.

I've made a few updates and created JoeCooper/routing#2... once @JoeCooper merges that into his branch, this PR should automatically update to have the overloads instead of the optional parameters.

I've merged in the updates from @airbreather. Sorry it took a while. April has been an absolute clusterfrack. I'm back in the office though.

Merged again.

:+1: this looks good to me now.

Thanks @JoeCooper @airbreather :+1:

Thanks everyone

On 3 May 2018, at 21:31, Ben Abelshausen<EMAIL_ADDRESS>wrote:
Thanks @JoeCooper @airbreather 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


ExtendedKryptonMessageBox.TopMost

Helle @Wagnerp,
I'm working on program that uses the KryptonToolkit.
By default the ExtendedKryptonMessageBox is displayed TopMost, which means it is on the top of any other application. This behavoir is different to the standard MessageBox and all other none .Net programms and I don't like it.
I would like to ask you if it is possible to add a static property TopMost to the ExtendedKryptonMessageBox class which will be used in InitializeComponent?
By default this property should be initialized with true to be backward compatible.
Best regards

http://frasergreenroyd.com/c-gui-make-a-child-window-stay-on-top-at-all-times/


Added Flow.CubicDecimeterPerMinute

Sorry @anjdreas i'm not so keen with github yet.
Rebasing, Branching, Contributing makes me crazy at the moment.
Here's a new pull request. Sorry for inconvenience.

I understand, git and github has a bit of learning curve, but it gets better with practice :-)
PR looks good, thanks!

Nuget 3.36 out.
To confuse you even further, you could have reused the previous pull request #169 and simply force-pushed your feature branch after rebasing it, so that you overwrote the PR commits with new ones. This way you avoid creating a number of pull requests when fixing up mistakes.
Happy learning :-)


qt6.qtwebengine: apply userscript mgmt patch

This commit can be reverted when we bump qt to 6.5.1.
It fixes a fairly annoying UI bug in qutebrowser, so I believe a hotpatch is warranted. https://github.com/qutebrowser/qutebrowser/issues/7662#issuecomment-1520674002
Leaving in draft until I have time to build and test. I built and tested with the patch, and the qutebrowser issue is resolved.
Should be ready to merge.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

No longer needed, hopefully, after bump to 6.5.1


change PostEditNonblock to take either message ID or outbox ID CORE-9152

Patch aims to solve the problem of editing pending messages behaving strangely in current builds (normally generates two sends of the same message, slightly altered). cc @chrisnojima @buoyad
1.) Add a new parameter to PostEditNonblock, called Target which can be used to specify either a message or outbox ID. The frontend just aims to send whatever it has for the message being edited.
2.) If we get a message ID, then just operate as normal. If we get an outbox ID, we attempt to update the message in the outbox. If we find the outbox ID in the outbox, we update the contents.
3.) If we can't find the outbox ID in the outbox, we fetch the thread and try to find a message with that outbox ID on it, and post an edit.
4.) If we find the outbox ID, but when we update we don't do anything, then do the fetch thread thing as well.
5.) Add a new method to Deliverer, called UpdateInFlight, which will update the outbox item as well as cancel any outstanding send (in case we are updating the thing we are sending). Note this phase isn't perfect, since we are trying to solve a race between the UI, service, and server.

Ok @joshblum this is ready for another look with the new method I described.


Support debugging IW using Jupyter protocol

Fixes #10037
Todo:

Add tests

Codecov Report

Merging #10105 (1df9d10) into main (760d61e) will increase coverage by 0%.
The diff coverage is 100%.

:exclamation: Current head 1df9d10 differs from pull request most recent head dd05b78. Consider uploading reports for the commit dd05b78 to get more accurate results

@@          Coverage Diff          @@
##           main   #10105   +/-   ##
=====================================
  Coverage    64%      64%
=====================================
  Files       203      203
  Lines      9239     9241    +2
  Branches   1488     1488
=====================================
+ Hits       5925     5932    +7
+ Misses     2853     2851    -2
+ Partials    461      458    -3

Impacted Files
Coverage Δ

src/platform/serviceRegistry.node.ts
98% <100%> (+<1%)
:arrow_up:

src/platform/errors/errorHandler.ts
63% <0%> (+<1%)
:arrow_up:

src/platform/common/cancellation.ts
74% <0%> (+6%)
:arrow_up:


Extend horizontal axis of the bar chart from a timeline to fixed distances

It should be possible to extend the horizontal axis of the bar chart used for the evaluation comparison from a timeline:

to a representation with a fixed distance between the bars:

On the horizonal axis we can not show a number yet, instead we will show a date/time label (tilted).
Definition of Done:

[ ] A switch is provided that allows changing the horizontal axis.

On the x-axis, we will use the label buildId. If it is not there, we will use the datetime.
{
     "...": "...",
     "labels": {
          "buildId": "1234"
     }
}


Form Stepper: step of -1 doesn't show the first page on page load

Info
Issue raised by Bing on July 24 / 2024.
The code provided below used to work with web-components v1.20.5 and stopped working as of v1.21.0. The key part of the code below that prevents it from working is step = -1, if you set step = 1 it works, but you can no longer access each step without the use of the Next button, as that enables Controlled Navigation.
The issue is the content on page 1 no longer loads on page load, instead you're forced to click a form stepper step to load anything, even the first page.
This issue was created by one of the following commits:
Commit #1
Commit #2
Commit #3
Commit #4
Commit #5
Code
Current step {{step}}
<goa-form-stepper ml="s" mr="s" [step]="step" (_change)="updateStep($event)">
  <goa-form-step text="Personal details" [status]="status[0]"></goa-form-step>
  <goa-form-step text="Employment history" [status]="status[1]"></goa-form-step>
  <goa-form-step text="References" [status]="status[2]"></goa-form-step>
  <goa-form-step text="Review" [status]="status[3]"></goa-form-step>
</goa-form-stepper>
<goa-pages [current]="step">

Page 1 content with status: {{status[0]}}

Page 2 content with status: {{status[1]}}

    Page 3 content with current status: {{status[2]}}

    Page 4 content with current status: {{status[3]}}

</goa-pages>

  <goa-button (_click)="setPage(step - 1)" type="secondary"
  >Previous</goa-button
  >
  <goa-button (_click)="setPage(step + 1)" type="primary">Next</goa-button>

step = -1;
status = ["incomplete", "incomplete", "incomplete", "incomplete"];

updateStep(event: Event) {
  this.step = (event as CustomEvent).detail.step;
}

setPage(page: number) {
  if (page < 1 || page > 4) return;
  this.step = page;
}

Acceptance Criteria:

Form Stepper using step set to -1 should load the first page correctly and allow unfettered access to all steps via the clickable step elements instead of the Next button.

:tada: This issue has been resolved in version 1.17.0-alpha.96 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.17.0-alpha.38 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.25.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 4.24.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0-alpha.5 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Starting verged doesn't open the rpc port

i've have a linux machine that i want to use to min (not using this machine to mine buse using this machine as verged server), i've started verged but from the debug.log i can see that the rpc port is not opening, but the port is open, also if i try with nc to connect it doesn't reply and when i start stratum it can not connect;
so just to be clean i've this config:
rpcuser=vergeuser
rpcpassword=[removed]
rpcallowip=<IP_ADDRESS>
rpcport=20102
port=21102
gen=0
daemon=0 (i'm using another tool to start the process as daemon)
algo=x17
am i doing something wrong ?
so from this example only the port 21102 is open no the other one

can you paste the debug log where it says the rpc port isn't opening? i've never heard of anything like this.

i don't receive any error in the debug log just it say opening port 21102 , but not opening port 20102 (the one configured for rpc) also i get connection failed in the stratum process (running in the same machine as verged)

i would remove daemon=0. also if that doesn't help, please paste some stratum error codes. could be something simple like a permission issue accessing the port when you run the stratum.

ok, i've re checked the permission and i think ive made a mistake there, also i see that doesn't seems to write any log for opening the rpc port (also i took a lot of time to load the chain that maybe have created some problem)
so thanks for the support

yeah  you wont be able to open a stratum until the chain is synced. if you're running a public mining pool feel free to make a pull request on the website and add it to the list of pools


DS-4291 Properly show results for 0-9 link in browse

When browsing by Author, if you click the "0-9" link at the top, it is only showing results for 0 instead of 0-9.
Currently, only a facet query prefix for "0" is being used, so no other results are shown. Because facet query prefixes don't support ranges, the simplest solution is to perform separate queries and combine the results for 0-9. This fix performs the additional queries and combines their results and totals.

My previous implementations was missing some fixes we had made for a client. This new implementation supports both asc/desc orders and reports proper counts as well


VuePopper: add test

Please makes sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's Contributing Guide.
[x] Rebase before creating a PR to keep commit history clear.
[x] Add some descriptions and refer relative issues for you PR.

Coverage increased (+1.5%) to 37.301% when pulling 0cb98686b76c51c8130d48e47e0a5da29c6fa42e on QingWei-Li:test/util/popper into 9d46c428bb5931947a6b425ffb20683e0bacd879 on ElemeFE:master.


Diff of PCMs

Provide a new operation in the API to compute the difference of 2 PCMs

Implemented in https://github.com/gbecan/PCM/commit/95b382afc1d2a3a3c5cedee86db36a8011e2f0f3


ASC Morphology loading issue when using gcc

Issue
Morphology loading of a test .asc file leads to: Error in python': free(): invalid pointer:`.
Problem doesn't seem to present itself if intel compiler is used instead.
Full backtrace is included at the end.
Steps to reproduce

source spack configuration script;
load python-dev/03 gcc cmake boost py-morphio neurodamus-neocortex
create and activate virtual environment and installing dependencies
run the code

The code I was trying to run can be found here: https://bbpcode.epfl.ch/code/#/c/49899/
Error is signaled on line 36 of circuit_indexer.py when running python setup.py test
###Full Backtrace
tests/test_index_mvd.py::test_serial_exec *** Error in `python': free(): invalid pointer: 0x00007fffcb84e1a0 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x81609)[0x7fffec2f8609]
/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/_spatial_index.cpython-37m-x86_64-linux-gnu.so(_ZNSt6locale5_ImplD1Ev+0x7d)[0x7fffcb551ccd]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/compilers/2020-02-01/linux-rhel7-x86_64/gcc-4.8.5/gcc-8.3.0-r24zbv3waz/lib64/libstdc++.so.6(_ZNSt6localeD1Ev+0x34)[0x7fffcaf276b4]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/applications/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-morphio-2.3.4-hk245asvbb/lib/python3.7/site-packages/morphio.cpython-37m-x86_64-linux-gnu.so(_ZN7morphio10MorphologyC1ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEj+0xaeb)[0x7fffcab9281b]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/applications/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-morphio-2.3.4-hk245asvbb/lib/python3.7/site-packages/morphio.cpython-37m-x86_64-linux-gnu.so(+0x7fc24)[0x7fffcab68c24]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/applications/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-morphio-2.3.4-hk245asvbb/lib/python3.7/site-packages/morphio.cpython-37m-x86_64-linux-gnu.so(+0x9afcb)[0x7fffcab83fcb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyMethodDef_RawFastCallDict+0x132)[0x7fffed43f7a2]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyCFunction_FastCallDict+0x25)[0x7fffed43f9f5]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyObject_Call_Prepend+0xcd)[0x7fffed43fd3d]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(PyObject_Call+0x75)[0x7fffed440f45]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0xee076)[0x7fffed499076]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0xea6b2)[0x7fffed4956b2]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyObject_FastCallKeywords+0xd3)[0x7fffed43f3d3]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x5bdd)[0x7fffed419d5d]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0x67feb)[0x7fffed412feb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x7995)[0x7fffed41bb15]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0x67feb)[0x7fffed412feb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x7995)[0x7fffed41bb15]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0x67feb)[0x7fffed412feb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x7995)[0x7fffed41bb15]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalCodeWithName+0x97e)[0x7fffed51447e]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyFunction_FastCallKeywords+0x93)[0x7fffed43ecf3]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x7995)[0x7fffed41bb15]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0x67feb)[0x7fffed412feb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x79aa)[0x7fffed41bb2a]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(+0x67feb)[0x7fffed412feb]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyFunction_FastCallDict+0x2d2)[0x7fffed43ec52]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalFrameDefault+0x2dbf)[0x7fffed416f3f]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyEval_EvalCodeWithName+0x97e)[0x7fffed51447e]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0(_PyFunction_FastCallDict+0xae)[0x7fffed43ea2e]
/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/libpython3.7m.so.1.0Fatal Python error: Aborted

Current thread 0x00007fffedad7740 (most recent call first):
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/circuit_indexer.py", line 36 in _load
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/circuit_indexer.py", line 48 in get
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/circuit_indexer.py", line 58 in process_cell
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/circuit_indexer.py", line 80 in process_range
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/spatial_index/circuit_indexer.py", line 106 in main_serial
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/tests/test_index_mvd.py", line 17 in test_serial_exec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/python.py", line 170 in pytest_pyfunc_call
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 86 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 92 in _hookexec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/python.py", line 1423 in runtest
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 125 in pytest_runtest_call
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 86 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 92 in _hookexec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 201 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 229 in from_call
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 201 in call_runtest_hook
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 176 in call_and_report
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 95 in runtestprotocol
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/runner.py", line 80 in pytest_runtest_protocol
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 86 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 92 in _hookexec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/main.py", line 256 in pytest_runtestloop
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 86 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 92 in _hookexec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/main.py", line 235 in _main
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/main.py", line 191 in wrap_session
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/main.py", line 228 in pytest_cmdline_main
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/callers.py", line 187 in _multicall
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 86 in <lambda>
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/manager.py", line 92 in _hookexec
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pluggy-0.13.0-wo7mj37ztp/lib/python3.7/site-packages/pluggy/hooks.py", line 286 in __call__
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-pytest-5.2.1-wwksimpf7d/lib/python3.7/site-packages/_pytest/config/__init__.py", line 90 in main
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/.eggs/pytest_runner-5.2-py3.7.egg/ptr.py", line 220 in run_tests
  File "/gpfs/bbp.cscs.ch/home/bellotta/proj/SpatialIndex/.eggs/pytest_runner-5.2-py3.7.egg/ptr.py", line 209 in run
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/python3.7/distutils/dist.py", line 985 in run_command
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/python3.7/distutils/dist.py", line 966 in run_commands
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/external-libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/python-3.7.4-tfxecymrkn/lib/python3.7/distutils/core.py", line 148 in setup
  File "/gpfs/bbp.cscs.ch/ssd/apps/hpc/jenkins/deploy/libraries/2020-02-01/linux-rhel7-x86_64/gcc-8.3.0/py-setuptools-41.4.0-ooqzubldp5/lib/python3.7/site-packages/setuptools/__init__.py", line 145 in setup
  File "setup.py", line 146 in setup_package
  File "setup.py", line 151 in <module>
[1]    50986 abort      python setup.py test

Hi @st4rl3ss ,
I have tried to reproduce the problem but failed to even run the tests.
Here is what I tried:
git clone ssh://bbpcode.epfl.ch:22/hpc/SpatialIndex
cd SpatialIndex
git review -d 49899
spack build-env spatial-index bash
python -m venv test-env
. ./test-env/bin/activate
pip install morphio
python setup.py test

Can you give me the exact steps you ran ?
Thank you !

The steps I followed are almost the same as yours with some modification:
git clone ssh://bbpcode.epfl.ch:22/hpc/SpatialIndex cd SpatialIndex git review -d 49899 git submodule update --init --recursive spack build-env spatial-index bash python -m venv test-env . ./test-env/bin/activate module load unstable py-morphio neurodamus-neocortex pip install numpy-quaternion python setup.py test
I am sure this is the exact same commands I used but at the moment I can't reproduce the bug as well. Maybe something changed in morphio or spack that already fixed this.

Thanks! I will try on my side and see how goes then.

Seems fixed.


add distignore file

Sorry about that @freekmurze, vendor file seems to be still excluded from the deployment to Wordpress svn.
I have now added a distignore file. This seems to be used in this repo too (with same GitHub action for deployment).
Version is now 1.7.2.
Hopefully it works now! 🤞

🤞
No worries, I know it takes a few passes to get something like this right.
Thanks for your work on this!


feat(frontend): show endpoint.name in page title

fixes #3613

/azp run

@pull-dog up

@deviantony Yes sure will fix it.

/azp run

Thanks @TimvdEijnden 👍