Old versions of Android SDK & tools will be removed from images on January, 8

Breaking changes
Android SDK & tools v19 through v30 will be removed from Windows 2019 image.
Android SDK & tools v27 through v30 will be removed from Windows 2022 and all Ubuntu and macOS images.
Target date
The images rollout process will start on January 8 and take 3-4 days.
The motivation for the changes
We would like to remove some obsolete versions and free up more disk space on runner agents.
Possible impact
If your workflows or pipelines depend on these older version of components, they may be broken.
Platforms affected

[X] Azure DevOps
[X] GitHub Actions

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[X] macOS 11
[X] macOS 12
[ ] macOS 13
[X] Windows Server 2019
[X] Windows Server 2022

Mitigation ways
Nothing specific is required. All the components can still be installed using Android's sdkmanager.

I successfully configured GitHub Actions hosted agents to enable the .NET MAUI Android build by adding the following snippet to the YAML file:
- name: Setup Android SDK
  uses: android-actions/setup-android@v3
  with:
    cmdline-tools-version: 9477386

Now, I need assistance with Azure DevOps pipelines. Unfortunately, I couldn't find any suitable task in the marketplace for this purpose. If I decide to use sdkmanager to achieve this, could you guide me on the parameters to pass to its install command?
Regarding PR #4301, is it intended to resolve the issue? I'm concerned about potential disruptions to CI/CD pipelines for projects relying on Microsoft's recommended approach for building Android apps with .NET MAUI /-:
@tronical

Based on official .NET MAUI docs It's relying on cmdline-tools v7

For those who are struggling with this in .NET MAUI, run this command and you're good to go:
-t:InstallAndroidDependencies -f:net8.0-android -p:AcceptAndroidSDKLicenses=True

https://github.com/actions/runner-images/blob/a89e382279a91339e9afe0d7477a8bb1f087670f/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L258 mentioned that platform tools 34.0.5 is included in this image.
We use /usr/local/lib/android/sdk/platform-tools/adb, and I see that version 34.0.5 still has it in the platform-tools dir, but now we are getting the error
System.ComponentModel.Win32Exception (2): An error occurred trying to start process '/usr/local/lib/android/sdk/platform-tools/adb' with working directory '/home/runner/work/out'. No such file or directory
Is this temporary because of the migration, or do we need to install adb ourselves?

For those who are struggling with this in .NET MAUI, run this command and you're good to go: dotnet build -t:InstallAndroidDependencies -f:net8.0-android -p:AcceptAndroidSDKLicenses=True -p:AndroidSdkPath="/usr/local/lib/android/sdk/"

Also successed with temporary solution below.
      - name: Set Up Android tools
        run: |
          ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
          --sdk_root=$ANDROID_SDK_ROOT \
          "platform-tools"

      - name: Build
        run: |
          dotnet build <project> \
          -f:net8.0-android

For .NET Xamarin, this is what I did for a windows-2022 pipeline to fix it.
Add this Command Line task before your Xamarin.Android task
steps:
- script: |
   C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager "platforms;android-28"

   C:\Android\android-sdk\cmdline-tools/latest/bin/sdkmanager "build-tools;28.0.3"

  displayName: 'Install Android API 28'

Removed.

Also successed with temporary solution below.
      - name: Set Up Android tools
        run: |
          ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
          --sdk_root=$ANDROID_SDK_ROOT \
          "platform-tools"

      - name: Build
        run: |
          dotnet build <project> \
          -f:net8.0-android

Thanks a lot! This was what worked for me. The solution described by @ysmoradi in https://github.com/actions/runner-images/issues/8952#issuecomment-1882923510 didn't work, because I get the error described by @hansmbakker in https://github.com/actions/runner-images/issues/8952#issuecomment-1884552362 every single time ("The Android SDK directory could not be found").
To @mikhailkoliada or whomever it may concern: This unexpected change cost me several hours of work. Firstly, it would be great if there were pipeline warnings (visible on the main build result page) for a long sunset period before such changes occur, to increase the chance that devs pick this up and can prepare for it, instead of finding out only when trying to build a (possibly urgent) app update. Secondly, it would be great if the official solution actually worked. 😅

The Android SDK Platform-Tools got removed completely. Was this on purpose? it was only announced that old APIs and tools are to be removed. The platform-tools were up2date and should IMHO not be removed.

@Falco20019 would https://github.com/android-actions/setup-android help with installing/finding the sdkmanager or is that broken too?

@Hanmac I would assume that this should still work since according to the description, it should install the SDK and platform-tools even if nothing was pre-installed.
I can give it a try later today, but just calling the already installed sdkmanager was the quickest solution. I can compare the time it takes using the action. Using the sdkmanager, it currently adds only 12 seconds to the build time.

For .NET Xamarin, this is what I did for a windows-2022 pipeline to fix it.
Add this Command Line task before your Xamarin.Android task
- script: |
   C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager "platforms;android-28"

   C:\Android\android-sdk\cmdline-tools/latest/bin/sdkmanager "build-tools;28.0.3"

  displayName: 'Install Android API 28'

Getting this warning that I did not notice after fixing the failing pipeline.
C:\Program Files (x86)\Android\android-sdk\tools\proguard\proguard-android.txt(0,0): Warning XA4304: ProGuard configuration file 'C:\Program Files (x86)\Android\android-sdk\tools\proguard\proguard-android.txt' was not found.

Has Proguard been removed or moved? How can I fix this?
This is causing the built APK to crash when rendering animations from the AirBnb Lottie package.
Azure DevOps

Ok, so you removed older Android SDK, but did you actively go out of your way try to make it had to manually install them. ;-)
It seems the latest Android Studio and SDK no longer install sdkmanager.bat by default under $ANDROID_HOME/tools
It looks like these are all now an optional package called cmdline_tools
unfortunately, you did not install this optional tools package when you removed the older SDKs and since the SDKManager command line is now one of the missing tools, it is not possible to fix this without using the SDK manager UI in Android studio to install the tools package or the missing android platform packages...
The only way I could work around this was to CURL download the latest cmdline_tools zip file from google, and then upzip it to where is should be under "$ANDROID_HOME/cmdline-tools", and then use sdkmanger commandline to install the needs Android SDKs.
It would be very helpful and kind if you installed the optional cmdline-tools package so that users can use sdkmanager to install the platform API levels that you removed from the default agent images...
Thanks,

OK, this is nasty. I'm running dotnet workload restore MySolution.sln just before building my solution in Azure Pipelines ubuntu-latest, and even though getting this:

##[error]/usr/share/dotnet/packs/Microsoft.Android.Sdk.Linux/33.0.95/tools/Xamarin.Android.Tooling.targets(70,5): error XA5300: The Android SDK directory could not be found. Install the Android SDK by following the instructions at: https://aka.ms/dotnet-android-install-sdk [/home/vsts/work/1/s/src/AvaloniaSyncer.Android/AvaloniaSyncer.Android.csproj]

I assume that restoring workloads should care about installing the required Android SDK and everything. Why is the Android application different from any other when it comes to building? If it requires something, install it.
That's common sense, isn't it?
BTW, none of the solutions above applies to my scenario because I'm using Nuke build. I'm building withi this code: https://github.com/SuperJMN/AvaloniaSyncer/blob/8dbcd7de17e7b890a5071a5accdcdb674dafa7bf/build/Build.cs#L40
Please, fix this ASAP.

@SuperJMN The path to the SDK is /usr/local/lib/android/sdk, you should be able to call it also there als Shell command

Anyone have a solution for the C:\Program Files (x86)\Android\android-sdk\tools directory now missing in windows-2022 image?

Need the Proguard folder to exist.
My Xamarin Forms Android build now gets this warning:
C:\Program Files (x86)\Android\android-sdk\tools\proguard\proguard-android.txt(0,0): Warning XA4304: ProGuard configuration file 'C:\Program Files (x86)\Android\android-sdk\tools\proguard\proguard-android.txt' was not found.

Which results in a run-time crash of the built APK 😨

@Blue101black According to https://developer.android.com/build/shrink-code ProGuars was replaced by R8. You might need to adjust your tooling accordingly.

I am having to change my Xamarin.Forms application to target a later version of the Android SDK because of this removal.  I've changed nothing other than the "Target Android version", from "API Level 29" to "API Level 34".  The vm image is "windows-2022" and the XamarinAndroid@1 step fails with "An exception has occurred in the compiler (1.8.0_392). Please file a bug against the Java compiler via the Java bug reporting page"
I've changed the build yml to use the "windows-2019" vm image and that hangs on the same step.  After an hour, DevOps cancels the build
Don't know where I go from here, any suggestions will be much appreciated

@Blue101black you are a star, thank you
Adding

script: |
C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager "platforms;android-29"
displayName: 'Install Android API 29'

As the step before my XamarinAndroid@1 step sorted it for me
No ProGuard issues for me

@SuperJMN The path to the SDK is /usr/local/lib/android/sdk, you should be able to call it also there as Shell command:
/usr/local/lib/android/sdk/cmdline-tools/latest/bin/sdkmanager --sdk_root=/usr/local/lib/android/sdk "platform-tools"
I also find it frustrating that Android builds have some more dependencies not dealt with by the workload. There is a dotnet global tool that helps with setting up prequisites that we use on our machines. But was not necessary on the runners so far: https://github.com/Redth/dotnet-maui-check

I'm sorry. I can't understand what you suggest. This issue mentions that "Android SDKs and tools" are deleted, so no longer available as part of the runner images. That is breaking my Android builds. So, how to install those tools manually to make my Android builds work again?
I guess it's a matter of installing it manually, but how?
Thank you!

@Blue101black you are a star, thank you
Adding

script: |
C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager "platforms;android-29"
displayName: 'Install Android API 29'

As the step before my XamarinAndroid@1 step sorted it for me
Need to run it now and see if there are any proguard errors

What's the equivalent in "powershell" so it can run in whatever image?
Thanks!

@Blue101black I'm not getting any proguard errors, everything runs fine for me
@SuperJMN I think in the powershell script you should just be able to run
C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager.exe "platforms;android-29"

@SuperJMN This will not work for you as it's for Windows. According to your error message you use Ubuntu.
They did not mention that Android SDKs and tools are removed. Only OLD are removed. But they seem to have also deleted one of the tools accidentally (platform-tools) which is needed by most of us... So the only thing missing for you is to install them.
I never worked with Nuke, but I would assume, that it should look something like this for you:
    Target RestoreAndroidPlatformTools => td => td
        .Executes(() =>
        {
            StartShell(@"/usr/local/lib/android/sdk/cmdline-tools/latest/bin/sdkmanager --sdk_root=/usr/local/lib/android/sdk \"platform-tools\"").AssertZeroExitCode();
        });

Just make sure to have RestoreAndroidPlatformTools as dependency before you try to run your build.

@Blue101black you are a star, thank you
Adding

script: |
C:\Android\android-sdk\cmdline-tools\latest\bin\sdkmanager "platforms;android-29"
displayName: 'Install Android API 29'

As the step before my XamarinAndroid@1 step sorted it for me
Need to run it now and see if there are any proguard errors

Thanks, that fixed my Xamarin Android build issue!

How does this relate to Appcenter? Does it use the same agent?
I noticed builds with Android sdk < 31 don't work there as well.

Cleaned up.

Success with this solution (GitHub Actions)

name: Setup Android SDK 27, 28, 29 and 30
uses: android-actions/setup-android@v3
with:
cmdline-tools-version: 9123335

run: sdkmanager tools "platforms;android-27" "platforms;android-28" "platforms;android-29" "platforms;android-30"

Is this temporary because of the migration, or do we need to install adb ourselves?

@shichen85, did you ever receive an answer to your question?
I'm also seeing /usr/local/lib/android/sdk/platform-tools/adb: No such file or directory .

Is this temporary because of the migration, or do we need to install adb ourselves?

@shichen85, did you ever receive an answer to your question?
I'm also seeing /usr/local/lib/android/sdk/platform-tools/adb: No such file or directory .

I don't think I have gotten a reply. I ended up installing adb myself as many other suggested with something similar to:
      - name: Set Up Android tools (non-windows runner only)
        if: ${{ !startswith(inputs.runner, 'windows') }}
        run: |
          ${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
          --sdk_root=$ANDROID_SDK_ROOT \
          "platform-tools"


Can't get it to work?

I'm writing a simple .NET Core 3.1 console application to test out your library, I've done everything your home page says to do and it compiles and runs just fine it's just that it never hits the interception code.
public partial class BasicClass
{
    [Interception]
    public string LastName;
}

It never hits my Interception Attribute code:

    internal class InterceptionAttribute : Attribute, IPropertyGetterInterceptor, IPropertySetterInterceptor
{
    public InterceptionAttribute()
    {
        int i = 9;
    }

    public bool OnException(PropertyInterceptionInfo propertyInterceptionInfo, Exception exception)
    {
        //Do Something on Error
        return false;
    }

    public void OnExit(PropertyInterceptionInfo propertyInterceptionInfo)
    {
        //Do Something on Exit
    }

    public void OnGet(PropertyInterceptionInfo propertyInterceptionInfo, object currentValue)
    {
        //Do Something on Get
        int i = 9;
    }

    public bool OnSet(PropertyInterceptionInfo propertyInterceptionInfo, object oldValue, object newValue)
    {
        //Do Something on Set
        return true;
    }
}

Ok, there are 2 possible problems here.
First the property you are applying your attribute on must be protected or private and should start with a lowercase letter.
The generator will then generate a public property with the same name but an uppercase letter.
You should try to change your example to this:
public partial class BasicClass
{
    [Interception]
    private string lastName;
}

Second the support for source-generators in .NetCore3.1 or C#8 isn't that good. Thats probably why you don't get any errors while  compiling the project. If you use .NET 5 or greater you can actually see the output of the generator under Solution ->Dependencies->Analyzers ->PropertyInterception.


Removed Dead code

Merging @amakhaba branch into initial branch of the py2 to py3 migration.
Definition of Done Checklist

[x] Code meets our python style guidelines?
[x] Unit tested (coded, passed, included)?
[x] Requested at least 2 reviewers?
[x] Commented code, particularly in hard-to-understand areas?
[x] Made corresponding changes to the documentation (e.g. Python documentation, System Engineering Documentation, version description updates, README file, etc)?

JIRA: MT-738

@mmphego
this PR addresses

Merging @amakhaba branch into initial branch of the py2 to py3 migration.

Should I rather branch off master? I am currently using the previous py2topy3 branch as I worked with it yesterday and I am continuing with getting the tox file and coverage to use enable the nose-xunitmp settings.

@mmphego
this PR addresses

Merging @amakhaba branch into initial branch of the py2 to py3 migration.

Should I rather branch off master? I am currently using the previous py2topy3 branch as I worked with it yesterday and I am continuing with getting the tox file and coverage to use enable the nose-xunitmp settings.

@amakhaba and I are currently preparing the branch for futurize stage 1. See PR#105.
Can you please look into futurize stage 2 PY2 tests, as soon as that PR is merged we will do stage 1 -> black and then tackle stage 2.
We are trying to follow the wiki as we update and improve it

sure and thanks. I will close this PR so long.


fix flutter issues

info • 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/src/pages/home/home.dart:214:12 • deprecated_member_use
info • 'WillPopScope.new' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/src/pages/home/home.dart:214:12 • deprecated_member_use
info • 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/src/pages/leaderboards/monthly_leaderboard.dart:78:12 • deprecated_member_use
info • 'WillPopScope.new' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/src/pages/leaderboards/monthly_leaderboard.dart:78:12 • deprecated_member_use

Hii @DonnieBLT ill look into this issue.
/assign

Thanks!

@Uttkarsh-raj Sorry I actually forgot to assign myself and start working on it because it was a quick fix and raised a PR too

@Dante291 oh ok ...


Why does the new peerDependency check make sense for development dependencies?

Type of Issue
[x] Question
[ ] Bug Report
[ ] Feature Request

Description
With 2.3.0 the build fails if I have devDependencies that are not whitelisted. Why does this make sense? In the devDependencies I need to list all dependencies that I need for the build and test cycle, that includes e.g. jest or extra tools only required for development. Isn't this the default setup? It adds a lot of churn to have to whitelist each of these dependencies.

It's good to go through this discussion.
When I wrote it, I had a set up in mind where you have a root package.json (with devDependencies) for the workspace/project and another package.json for the library.
There are several issues that could go down misaligned dependencies set-up like the is not a NgModule error. They are really hard to track down. These issues usually occure only in the consuming app and sometimes it's possible to reproduce reliably. Thus, I think the build should be more rigid and try to catch those issues early in the build process. Filipe gave an explanation here: https://github.com/dherges/ng-packagr/pull/715#issue-177247845
devDependencies are problematic for locally installed packages. Afaik npm install path/to/dist would install devDependencies too.

I see, so it's probably my setup that is not ideal, then. Can you give an example how the suggested split between a root level project and the library project looks like, so you can

run testcases for the library and probably also start a local test app as a shell for the library for testing
build the library using ng-packagr without having to whitelist the dev dependencies

I checked npm install path/to/dist again:
$ cat package-lock.json
{
  "requires": true,
  "lockfileVersion": 1,
  "dependencies": {
    "folder-with-devDependencies": {
      "version": "file:../path/to/dist"
    }
  }
}

$ ls -al node_modules/
folder-with-devDependencies -> ../../path/to/dist

It didn't install the devDependencies listed in the package.json - so it would be fine to not fail the build for devDependencies.
Still symlinking a local package is horribly broken. let's say there is a path/to/package.json as workspace directory. Then path/to/node_modules ends up in the module resolution strategy and then module loaders will try to resolve from there which is... broken.
We can't solve that issue with the devDependencies whitelist. So the whitelisting for devDependencies should probably go away.

The only reliable way for local packages seems to be npm install path/to/dist.tgz
$ ls -al node_modules/
drwxr-xr-x  @sample
drwxr-xr-x  tslib
coala:foo david$ cat package-lock.json
{
  "requires": true,
  "lockfileVersion": 1,
  "dependencies": {
    "@sample/comments": {
      "version": "file:../ng-packagr/integration/samples/comments/dist.tgz",
      "integrity": "sha512-xoO7WpXSRUJTo6aso+WH2XU049qFVhNHfiVdoQz/rbRHYIMYO/vH0GNB5V151rboCMQCmm0gGwB9BRn9v7xAOA==",
      "requires": {
        "tslib": "1.9.0"
      }
    },
    "tslib": {
      "version": "1.9.0",
      "resolved": "https://registry.npmjs.org/tslib/-/tslib-1.9.0.tgz",
      "integrity": "sha512-f/qGG2tUkrISBlQZEjEqoZ3B2+npJjIf04H1wuAv9iA8i04Icp+61KRXxFdha22670NJopsZCIjhC3SnjPRKrQ=="
    }
  }
}

@CarstenLeue AN example is shown in nx-packaged, one of the libs: https://github.com/dherges/nx-packaged/tree/master/libs/one-lib


P03-C01 / P03-C02 - Moving Loss / Hyperparameters

I have two overall comments:

It would helpful to explain the moving loss calculation and why it is important. The moving loss calculation is not entirely intuitive and may seem arbitrary to beginners. I think it is important to frame it from the perspective that it helps SGD. In addition, here we've focused on a momentum based approach, but I think it would be good to introduce learning rate decay as well (we should also explain the learning rate).

It would be helpful to understand how to choose the appropriates value for the hyperparameters introduced (e.g., learning rate and smoothing constant). It is difficult choosing the appropriate value for your hyperparameters, and here they are chosen for you without any explanation to why they make sense. This is especially confusing when you use different learning rates when implementing the neural network using Gluon versus defining from scratch (0.1 versus 0.001).

gluon version uses a smaller learning rate because its gradients are divided by the batch size, which is specified by trainer.step(batch_size)


model.evaluate() is giving the same result for different numpy arrays

Hello,
I am currently evaluating DeepFace Emotion model as follows:
import tensorflow as tf
DeepFace_Model.compile(optimizer='adam', loss=tf.keras.losses.CategoricalCrossentropy() ,metrics=['accuracy'])
evaluation = DeepFace_Model.evaluate(norm_x_test_batch,y_test_enc)
norm_x_test_batch is a batch of images which were processed as deepface does and y_test_enc are the true labels for those images.
When I run DeepFace_Model.evaluate the result is always the same even if I change the batch of images.

Those are different experiments.

whwn you compile the model, then it loses the pre-trained weights.

Hello, thank you for your answer.
Although, when I run model.evaluate() without compiling it, it yields an error that says:

What I'm trying to evaluate is the performance of DeepFace Emotion model with a customized test dataset of mine.

I recommend you to write your own evaluator. Built model will be able to return predictions with .predict command for your data set.

Okay thank you :)


Add dontBindEventsOnBody param

Related to issue #4

@LucusWebsites, I just created a new release including your changes.


Add YouTube links to community-resources.json

fixes #9037

Oh alright
I will fix it
On Wed, 13 Sep 2023 at 6:54 PM, Eddie Jaoude @.***>
wrote:

@.**** commented on this pull request.
In config/community-resources.json
https://github.com/EddieHubCommunity/BioDrop/pull/9053#discussion_r1324872728
:

@@ -98,5 +98,15 @@
"name": "Maximising Your Job Prospects in Tech with BioDrop",
"url": "https://loftwah.medium.com/maximising-your-job-prospects-in-tech-with-BioDrop-2fea408301cc"
}

},
{
"name": "Nafisa Faruna",

The name here should be the creator of the resource
⬇ Suggested change

"name": "Nafisa Faruna",

"name": "Kim McMahon",

—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/BioDrop/pull/9053#pullrequestreview-1625120803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPFC72SDXKFN6SZEJ7H7ALX2HXLZANCNFSM6AAAAAA4WYYHOI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for the feedback!
On Wed, 13 Sep 2023 at 6:55 PM, Eddie Jaoude @.***>
wrote:

@.**** requested changes on this pull request.
Thank you for the contribution 👍
I have left 2 small inline comments
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/BioDrop/pull/9053#pullrequestreview-1625126748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPFC7ZHGFLMT55PG4T5LM3X2HXSTANCNFSM6AAAAAA4WYYHOI
.
You are receiving this because you authored the thread.Message ID:
@.***>

No worries, you can push more commits to your fork branch and GitHub will add it to this open pull request

@Nenepo do you need help with making these changes?

Hyyyyy
Not at the moment, I would have to go back and check it out
I did the push already and sent in an email
I had no idea it did not work
Sorry about that

@Nenepo https://github.com/Nenepo do you need help with making these
changes?
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/BioDrop/pull/9053#issuecomment-1732407025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPFC72C3PJLVKPEN3ZM3ODX35D27ANCNFSM6AAAAAA4WYYHOI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Nenepo do you need help with making these changes?

Hyyyyy I realized I didn’t open a pull request
I just opened it

No worries, you can push more commits to your fork branch and GitHub will add it to this open pull request

I will close this PR as you have created a new one https://github.com/EddieHubCommunity/BioDrop/pull/9153

Thank you,I had to open another branch because I kept pushing and it was
not reflecting on GitHub but I could see the commit on my local server
I got tired of trying to figure it out😫

No worries, you can push more commits to your fork branch and GitHub will
add it to this open pull request
I will close this PR as you have created a new one #9153
https://github.com/EddieHubCommunity/BioDrop/pull/9153
—
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/BioDrop/pull/9053#issuecomment-1732477416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPFC7ZBZXKLOKWC5YSHDI3X364QBANCNFSM6AAAAAA4WYYHOI
.
You are receiving this because you were mentioned.Message ID:
@.***>


[HybridApp] Clicking expense violation notifications cause the iOS app to crash

@AndrewGable @trjExpensify
Problem
Clicking expense violation notifications cause the iOS HybridApp to crash. NewDot users should not be receiving OldDot notifications.
Reproduction
I only have HybridApp installed, I think it’s:

Have a workspace on New Expensify that has violations enabled
SmartScan a receipt that has violations (e.g. our limit is $10 and this SmartScan was $100)
Click on push

Solution
Figure out if this should block the upcoming HybridApp release.
Fix.

I'm struggling to locate the crash in Firebase.
The higher frequency crashes exist in pre-hybrid releases, or seem very unrelated (shadowview example).

I have been reporting this via the TestFlight crash dialog, I am not sure Firebase is initialized yet

So for now would our desired solution to be stop sending the notification for NewDot violations, rather than implementing NewDot violation handling?
Secondly, is the desired behaviour to only send push notifications for the experience the user is set to? For example, a NewDot user would not receive a notification for an OldDot violation, and a NewDot user would not (currently) receive any violation notification.

I think we want to stop sending and we will figure out how to handle violation push notifications in a different solution. I think we are discussing them here: https://expensify.slack.com/archives/C06ML6X0W9L/p1728408150428299

What's a "NewDot violation", and what's an "OldDot violation", just so I'm clear?
I'm not aware of a system message to notify when a receipt upload contains workspace violations in NewDot. @JmillsExpensify is this supposed to exist?
I know there's a system message for a failed SmartScan that should be added to the transaction thread that would notify the submitter when it fails. It looks like this:

But interestingly, I just tested that, and it seems to not be added anymore? 🤔

Secondly, is the desired behaviour to only send push notifications for the experience the user is set to? For example, a NewDot user would not receive a notification for an OldDot violation, and a NewDot user would not (currently) receive any violation notification.

On this, yes.. if you're set to the NewDot experience you shouldn't receive push notifications for the OldDot experience and the same the other way around. Otherwise, you would get pulled into the wrong experience when tapping the notification.

Code for SmartScan failure is here, I believe: https://github.com/Expensify/Auth/blob/44606fb94035b15742c95973346b3d468269e4bc/auth/command/EditMoneyRequest.cpp#L431-L445

What's a "NewDot violation", and what's an "OldDot violation", just so I'm clear?

I wasn't sure where they originated from (are the OldDot notifications coming from a NewDot violation request?) -- but your answer has cleared this up.

On this, yes.. if you're set to the NewDot experience you shouldn't receive push notifications for the OldDot experience and the same the other way around.

Okay thanks. Our logic assumes otherwise as I thought we wanted to avoid dropping OldDot notifications when users first switch to NewDot. Currently we'll send OldDot styled notifications (receipt needs approval, violation) to NewDot users and we can simply switch this off.
Do we have any issues or plans to re-introduce NewDot notifications though? As we ramp up NewDot redirection users are going to be blissfully unaware of violations, ect.

Yeah, I can't see any. So I think what we need to do is:

Get that actionable system message when SmartScan fails sending again (which will then send a push notification to the submitter and open the transaction thread)
Send an actionable system message when there's a policy violation (which will then send a push notification to the submitter and open the transaction thread)
Keep sending the Expensify Card push notification(s) at the point of sale, but if you're set to the NewDot experience, open the camera/transaction view in NewDot.

Do you guys agree with that?

That sounds good to me as a starting point.

Alright, so what's the next step here and who's taking it on?

First lets solve the crash:

Currently we'll send OldDot styled notifications (receipt needs approval, violation) to NewDot users and we can simply switch this off.

I'll happily do this, but need to finish up attendee tracking first.

Okay, does that block defaulting new sign-ups to the NewDot experience though? If so, I think it's higher priority than attendee tracking in terms of priority, as these final issues to get this done come into #convert now.

Okay, does that block defaulting new sign-ups to the NewDot experience though?

Yeah, it probably should. But as both are critical WhatsNext tasks associated with deadlines, I think I should finish what I started before picking up this task -- attendee tracking has already missed one deadline, and this would risk missing a second.

After catching up with the new prioritisations, I can pick this up once I have wound down attendee tracking and left it in a good place.

Great stuff!

Jules, are you good with the plan of action here? Which I think is:

Solve the crash. Stop sending the OldDot styled notifications when there's a violation on the receipt uploaded when the user is defaulted to the NewDot experience.
Add the NewDot system messages to the transaction thread, so they notify the submitter incl. bringing back the SmartScan failure one.

SmartScan failure:

Expensify Today at 10:49AM
receipt scanning failed, please enter the details manually.

Violation on receipt upload:

Expensify Today at 09:02AM
that %merchant% receipt you just added needs your attention, please take a look. 👀

Check Expensify Card "point of sale" notifications are still delivered and don't crash on open, make them open the camera/transaction view in the NewDot experience when applicable.

Yeah, this all seems fine. I was planning to solve the crash first (1), and plan the remaining tasks (2,3) for later. But I could continue to working on these if we're okay delaying DevX/making HybridApp external. A couple of clarifications:

Add the NewDot system messages to the transaction thread

I might have to configure the notification title/grouping. This would be minor text formatting though.

Check Expensify Card "point of sale" notifications are still delivered

To be 100% sure, we still will send the OldDot POS notification to users on NewDot but won't yet build out the NewDot POS notifications.

I might have to configure the notification title/grouping. This would be minor text formatting though.

We had a system message for SmartScan failures already that we should bring back (or figure out why it's not there anymore), so I don't think this would be too hard to follow for this NewDot paradigm.

But I could continue to working on these if we're okay delaying DevX/making HybridApp external.

I think these items are probably more important as they impact customers using the NewDot experience on HybridApp. Ecard transactions POS notifications have a fraud component to them as well really, so I think this is the right priority personally. 👍

To be 100% sure, we still will send the OldDot POS notification to users on NewDot but won't yet build out the NewDot POS notifications.

Yeah, I view the Expensify Card POS notifications as being a feature of the Expensify Card not OldDot specifically. If you receive one, it should open in the right experience depending on which one that is.

Focusing on a more critical HybridApp issue first.

Picking this up again as the higher-priority HybridApp task was resolved.

I'm struggling a bit to reproduce. It seems that not all violations trigger the notification or cause the crash.
WIP Steps

Create NewDot account
Create workspace
Upgrade and enable 'Rules', set low receipt required limit
NVP.set('tryNewDot', {classicRedirect: {dismissed: "true"}});
On HybridApp ensure app is set to OldDot
On Web upload bad receipt
OldDot notification received
Tap notification
Expense shown in OldDot and doesn't crash 😕

I'm App deployer this week so progress is likely to be slow. In the meantime, I am asking QA to reproduce and provide detailed reproduction steps.

No crash, but the notification does not lead to ND, OD with an error instead
https://github.com/user-attachments/assets/3cd8c441-b686-48ed-a30d-abb613456f0f

Create NewDot account
Create workspace
Upgrade and enable 'Rules', set low receipt required limit
NVP.set('tryNewDot', {classicRedirect: {dismissed: "true"}});
On HybridApp ensure app is set to OldDot
On Web upload bad receipt
OldDot notification received
Tap notification
Expense shown in OldDot and doesn't crash 😕

Out of curiosity Jules, why did you set classicRedirect to true and set to OldDot here? Isn't the bug that you're set to NewDot and still receiving the OD notification which crashes when clicked. 🤔

Clicking expense violation notifications cause the iOS HybridApp to crash. NewDot users should not be receiving OldDot notifications.

I'll need to try again, but I believe I tried both cases -- Initially I wasn't receiving the notification when set to NewDot, so I switched to these steps.

Thanks @kavimuru. So as of right now the crash isn't reproducable. Please anyone correct me if they disagree.
I'm too busy with daily App Deploy to pick this up yet but I my next step will be to make sure NewDot users aren't sent OldDot violation notifications.

Solve the crash. Stop sending the OldDot styled notifications when there's a violation on the receipt uploaded when the user is defaulted to the NewDot experience.

@trjExpensify if the crash isn't occurring then there's nothing blocking our *final HybridApp production deploy.

@trjExpensify if the crash isn't occurring then there's nothing blocking our *final HybridApp production deploy.

That's awesome news, let's confirm and ship!

I confirmed that this is no longer crashing for Andrew or myself. Here's the final HybridApp release for reference.

Finishing up other tasks. The priority might come below other tasks now that the crash isn't occurring.


question on equation

Hi I'd like to understand what is the regression when we do .over("column")
This would not be analogous to one hot, but would be running a regression for each group, is this correct? Do you have any reference on what would be the equation that you are running?

Hi @HPicatto, you are exactly right in your thinking: running regression in a .over context is  akin to partitioning the data into separate chunks and computing fits / predictions on each.
to achieve one hot encoding over some categorical column you would need to use something like https://docs.pola.rs/py-polars/html/reference/dataframe/api/polars.DataFrame.to_dummies.html then pass those expanded columns as features. Notice the polars ols library supports regex for column selection in case you have many encodings
please let me know if that makes sense

Hi @mat-ej, unfortunately nothing immediate comes to mind that’s natively supported by the package. That being said, given the model fitting and prediction are lazy one should be able to write cross validation logic which shuffles, assigns partition groups, and computes fit and predict over k groups with polars expressions. It should run pretty fast but would take some effort to write such function
The answer here is a step in that direction but it does break the lazy eval so it would need to be optimized further to make the most out of polars
https://stackoverflow.com/questions/76564697/polars-shuffle-and-split-dataframe-with-grouping


Improve Path2D editing

When adding or splitting a point in Path2D, it was creating 2 undo actions: for creating the point and moving it. This PR merges it into one undo action.
https://github.com/godotengine/godot/assets/2223172/4282d88c-173b-4166-9b62-4275d9f4873d

I'm wondering if this is also needed for Path3D

I tested Path3D and it didn't seem to have this problem.

Thanks!


Allow HiddenAttribute to decorate classes

Summary of the new feature / enhancement
And exclude decorated classes from type name completion
Proposed technical implementation details (optional)
No response

The Engine WG discussed this (as part of the discussion for #13465) and agree that it would be useful

/cc @MartinGC94

(wouldn't be mad at throwing in #18642 while we're at it)

The hidden keyword is used for class members. Wouldn't it feel more natural to extend its usage to class definitions as well? So the syntax would look like this: hidden class MyClass {}.
The same goes for the other request for functions where the keyword would allow you to leave out a param block in the function definition.

For this particular issue the use case is primarily for classes written in C# so the keyword wouldn't necessarily be applicable.
For functions/variables/etc keep in mind we'd have to make hidden a keyword outside of classes. I don't think the benefit is worth the potential breaks (functions named hidden for example). But allowing HiddenAttribute to decorate classes doesn't exclude the possibility of adding a hidden keyword in the future, and the implementation would likely be simply decorating with the attribute anyway.


CDXML cmdlet doesn't work correctly on PSCore

Steps to reproduce
start pscore on Windows
ipmo C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\NetAdapter\NetAdapter.p
sd1
get-netadapter

Expected behavior
Name                      InterfaceDescription                    ifIndex Status       MacAddress             LinkSpeed
----                      --------------------                    ------- ------       ----------             ---------
Ethernet                  Broadcom NetXtreme 57xx Gigabit Cont...       6 Up           BC-30-5B-9D-D3-A8       100 Mbps
vEthernet (Ethernet)      Hyper-V Virtual Ethernet Adapter #2          12 Up           BC-30-5B-9D-D3-A8       100 Mbps
vEthernet (HNS Interna... Hyper-V Virtual Ethernet Adapter              4 Up           00-15-5D-05-B2-EF        10 Gbps

Actual behavior
Name                      InterfaceDescription                    ifIndex Status       MacAddress             LinkSpeed
----                      --------------------                    ------- ------       ----------             ---------
                                                                        6 Up           BC-30-5B-9D-D3-A8
                                                                       12 Up           BC-30-5B-9D-D3-A8
                                                                        4 Up           00-15-5D-05-B2-EF

Environment data

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
SerializationVersion           <IP_ADDRESS>
CLRVersion
PSEdition                      Core
BuildVersion                   <IP_ADDRESS>
PSRemotingProtocolVersion      2.3
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
GitCommitId                    v6.0.0-alpha.12
WSManStackVersion              3.0

Some CDXML modules contains .psm1 files that need to be refactored to work with powershell core.
For NetAdapter module, the formatting is done with some helper functions from 3 .psm1 files included in the module. Some refactoring was done to make those .psm1 files work with powershell core. The NetAdapter module from NanoServer works fine with our open source powershell core:
PS:375> $PSVersionTable

Name                           Value
----                           -----
PSEdition                      Core
GitCommitId                    v6.0.0-alpha.16
CLRVersion
PSVersion                      6.0.0-alpha
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
BuildVersion                   <IP_ADDRESS>
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}

PS:376> Get-NetAdapter

Name                      InterfaceDescription                    ifIndex Status       MacAddress             LinkSpeed
----                      --------------------                    ------- ------       ----------             ---------
vEthernet (External)      Hyper-V Virtual Ethernet Adapter #2          18 Up           D4-BE-D9-A0-07-6A       100 Mbps
vEthernet (PSOnCSS_Int... Hyper-V Virtual Ethernet Adapter              5 Up           00-15-5D-92-49-00        10 Gbps
Ethernet                  Intel(R) 82579LM Gigabit Network Con...      10 Up           D4-BE-D9-A0-07-6A       100 Mbps

@SteveL-MSFT @joeyaiello I think we need a plan to publish the altered CDXML modules that are shipped in NanoServer, to powershell gallery maybe.

@daxian-dbw does the same changes work with Windows PowerShell?  seems like it should be owned by the feature team.  agree on publishing to the gallery.

does the same changes work with Windows PowerShell?

Nano PS team worked on most of the refactoring work of those CDXML modules, especially @Francisco-Gamino. Francisco, do you know if the altered CDXML modules work on Windows PowerShell?

@Francisco-Gamino were these reduced in functionality in any way?
If not, we should maybe find a way to get the inbox module revved.

We're tracking this internally now to try and get the NetAdapter module revved


Suggestion (Not on Trello): Make a browser inside of brackets

Well, I want to suggest this, because it would be really cool.  Instead of needing to open your browser at all, you could just have one in brackets.

A duplicate of #10766

Oh, sorry, next time I'll look harder, when I searched I didn't see it.

@StephenSantilli9 strictly speaking, #10766 talks about doing LivePreview within Brackets. If you want to view an arbitrary pages in Brackets, then I doubt it will ever be implemented since Brackets is the code editor, not a browser replacement. It's just a no-goal for us. It can be done via an extension, though, you could try it and see how popular it will become.
If you're interested in doing LivePreview in Brackets, then please upvote https://trello.com/c/YG0BBlrl . I'm going to close this issue for these reasons.


Implement CheckBase32 more efficiently for slices

#17 introduces the CheckBase32 trait which allows to check if all values of a [u8] are in the range 0..32 and returns the values of the slice as T: AsRef<[u5]>. Currently this can only be implemented for T=Vec<u5> because of uncertainties of the memory layout of u5 (see discussion). Hopefully rust-lang/rust#43036 will resolve this uncertainty.
If [u8] and [u5] would be guaranteed to have the same memory layout we could do a simple cast from &'f [u8] to &'f [u5] after checking that all values are in range and save an allocation.

@sgeisler Is this issue still relevant. The code has changed a bit since April of '18 😄

I guess not. The only place where the trait is used in the library itself is in tests and the only thing it would be useful for otherwise is communicating with bech32 but not u5 aware libraries (which don't exist afaik since it's so easy to just get the u5 type from this lib). Although the language feature I referenced is now stable it would probably take an eternity until our oldest supported rust version can use it. So I guess we can close it, if anyone feels a need for it in the future it can be reopened.


Add WebsocketServer auto_restart parameter

The ability to auto-restart is only supported when using the start/stop API for now, not the context manager.
It does so by catching exceptions and re-creating a new task group.

This looks good to me @davidbrochart.

 Great work!

this looks good, @davidbrochart. I propose we merge here and work on getting #30 to follow this pattern. If we notice any changes needed here in that PR, we can fix there.
I'll work with @jzhang20133 to get these two aligned.

Sounds good.


Added toBool method in String

whats the use case here? maybe it should return false when the string is not true? maybe it should return nil? depends on the use case


fail to insert some tables into clickhouse

What happened:
The err log is :
Code: 76. DB::Exception: Received from localhost:9000. DB::ErrnoException. DB::ErrnoException: Cannot open file /data/jfs/store/369/369b25e4-92c5-4d83-a8bf-b2687850135f/tmp_insert_1997_41_41_0/primary.idx, errno: 4, strerror: Interrupted system call.
What you expected to happen:
Data was inserted successfully.
How to reproduce it (as minimally and precisely as possible):
Follow the github action https://github.com/juicedata/juicefs/runs/6882779832?check_suite_focus=true .
Anything else we need to know?
No
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
release-1.0-rc1

Possible cause: CH process consumes a lot of CPU (160%+), while the action host has only 2 cores. It makes juicefs slow to write data. Reducing the threads of CH process or size of test tables may help.

Maybe fixed by #2324 , need confirmation

Not reproduced for more than 2 weeks.


Select fixes

Bump select version
Fixes #41 Unable to select on options change - Trigger bindOptions() when options change
Fix #38 BrowserModule is imported into Select Component - CommonModule should be imported instead as described on https://angular.io/docs/ts/latest/cookbook/ngmodule-faq.html#!#q-browser-vs-common-module

Coverage remained the same at 92.254% when pulling ef2112c5b975cace70e66db76ffb5567762a3cfa on tb:select-fixes into<PHONE_NUMBER>790107e988bfcf3177d22a89108c99 on mseemann:master.


Missing libs

you added extra files (the bck)
I'll run locally.
Still think we should invest on a last layer for a safe RUN ffmpeg --buildinfo ;-)


Disable routing channels

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Allows a user to Disable a routing channel. When a channel is disabled, it is neither readable nor writable, which means it will not be accessible from the Screen/Workspace. No messages are created for the channel in the engine, so no changes to the hardware will be made.
If a user tries to read or write the channel from an API outside the Screen/Workspace, an error will occur, just as it would if the channel did not exist, except the message will say the channel is not readable. This error does not cause an error in the custom device. The custom device will continue executing.
Why should this Pull Request be merged?
Routing channel configurations can be very complex. During testing or debugging, it may be desirable to just test a few channels/connections in isolation.
Also, because of the complexity, some channels may have invalid configurations, but are not needed at the moment. It is nicer to disable the channel than have to delete and re-add when that channel is needed.
What testing has been done?
Manual testing with Workspace and Screen to ensure the custom device engine continues executing as it should without error when channels are disabled.
Ran unit tests.

[ ] Chain error in false case.

Chain error in false case.

I don't want to chain the error. One of the checks will always result in an error, but that shouldn't result in an error out. By wrapping this code in the error check case structure, I'm ensuring there is no error coming in. The only error I want to go out is if both checks result in an error.


Vertically center masthead title lockup

With the addition of the masthead navigation bar, the masthead title lockup feels too close to the bottom.

This was resolved with lonelyplanet/rizzo-next/pull/360.


IFrame version of webchat provides the same user id

I am using the IFrame version of the web chat (https://webchat.botframework.com/embed/{bothandle}?s={secret}) and am trying to count the number of users. The messages always show that they are from the same user "LnCq57Xe5Zd".

Hi @rosskyl, if a user id is not specified in the embed code, the user id will be generated and saved to the browser's cookies. The next time the bot is loaded in the browser, the user id will be recycled. If you need to work around this please feel free to generate a new user id every time.
BotChat.App({
    directLine: { secret: direct_line_secret },
    user: { id: generatedID },
}, document.getElementById("bot"));

How do I specify the user id with an iframe though? I am adding it using the below code.

My apologies, I totally provided you the wrong code >.<
You can specify the user id through embed like so:

Please keep in mind that for security reasons we don't recommend this since anyone could find the userID and impersonate the original user.

Thank you. I still feel this should be fixed. At least with v4 of webchat if you don't specify a user id it generates one randomly.

If you are able to bump to v4 I absolutely recommend it! Please let us know if we can support you in doing so.
Thanks for the feedback. Unfortunately v3 is in sunset right now, and most of our resources are being spent on improving v4.

Do you know if or when the iframe version will be switched to v4?

That's one of our major ticket items for the next release. Please keep an eye on #1086 to track this issue. We're very excited about it!

Has this issue been solved? @corinagum

i am experiencing the same issue. I am saving user chat in a table and every time I get the User id hence it is difficult to differentiate between chats. I do not experience this issue if I use Direct Line


fix(YARA-630): add conditionals to alerts

https://issues.redhat.com/browse/YARA-630

Looks good to me. Verified on stage preview.


uploads: Allow uploads to set storage class.

Uploads are well-positioned to use S3's "intelligent tiering" storage class.  Add a setting to let uploaded files to declare their desired storage class at upload time, and document how to move existing files to the same storage class.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks great, merged, thanks @alexmv!


Update to ungoogled-chromium 108.0.5359.99-1

Builds and runs fine, no patch updates required.

@Nifury Publishing on winget has failed, can you please have a look what went wrong?

 ! [remote rejected]       master -> master (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/spellCheck.yaml` without `workflow` scope)
I guess I'll have to create a new PAT with proper permissions. Could @networkException or @PF4Public make me admin for a moment so that I can update the secret?

Yep, given you admin

@networkException Done 😀


The functionality for a UITabBarController subclass is provided via protocols

But this protocol methods are super error prone as they can be overridden easily. What would be a better approach so that these functions could be marked as final, Maybe creating a subclass of UITabBarController and people who use this functionality must subclass that class for their custom tab bar controllers?

Now it is implemented as a class


Deeplab training framework crashes on mxnet 0.11.1 version

Training framework for DeepLab using Deformable convolutions crashes on mxnet 0.11.1.
In Deformable-ConvNets-master/deeplab/train.py line no 158.
train_net(args, ctx, config.network.pretrained, config.network.pretrained_epoch, config.TRAIN.model_prefix,
config.TRAIN.begin_epoch, config.TRAIN.end_epoch, config.TRAIN.lr, config.TRAIN.lr_step)
Kindly help me since my job is under trouble
Below is the error
Traceback (most recent call last):
File "/usr/share/pycharm/helpers/pydev/pydevd.py", line 1591, in
globals = debugger.run(setup['file'], None, None, is_module)
File "/usr/share/pycharm/helpers/pydev/pydevd.py", line 1018, in run
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/home/Softwares/Testing_DC/experiments/deeplab/deeplab_train_test_DC.py", line 21, in
train.main()
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/train.py", line 159, in main
config.TRAIN.begin_epoch, config.TRAIN.end_epoch, config.TRAIN.lr, config.TRAIN.lr_step)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/train.py", line 153, in train_net
arg_params=arg_params, aux_params=aux_params, begin_epoch=begin_epoch, num_epoch=end_epoch)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/module.py", line 948, in fit
for_training=True, force_rebind=force_rebind)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/module.py", line 841, in bind
for_training, inputs_need_grad, force_rebind=False, shared_module=None)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/module.py", line 396, in bind
state_names=self._state_names)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/DataParallelExecutorGroup.py", line 183, in init
self.bind_exec(data_shapes, label_shapes, shared_group)
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/DataParallelExecutorGroup.py", line 283, in bind_exec
shared_group))
File "/home/Softwares/Testing_DC/experiments/deeplab/../../deeplab/core/DataParallelExecutorGroup.py", line 500, in _bind_ith_exec
arg_shapes, _, aux_shapes = self.symbol.infer_shape(**input_shapes)
File "/usr/local/lib/python2.7/dist-packages/mxnet-0.11.1-py2.7.egg/mxnet/symbol/symbol.py", line 962, in infer_shape
res = self._infer_shape_impl(False, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/mxnet-0.11.1-py2.7.egg/mxnet/symbol/symbol.py", line 1058, in _infer_shape_impl
"but '%s' is %s." % (k, type(v)))
TypeError: Arguments need to be shapes (tuple), but 'label' is <type 'list'>.

MXNet changed the interface. Please use MXNet's commit version 62ecb60

thanks.....


feat(daffio): add api docs button to table of contents in main package pages

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Fixes: #2970
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@griest024 Need your help linking the button to the correct main api pages. It should also be hidden if the page is not a /docs/packages/ page.


Adds basic rsyslog listener and allows for multiple logstash configs

Hi, great container!  Not sure if this PR interests you, but thought I would submit anyway.
We use a lot of syslog, and for demo purposes we need a way to send some live syslog traffic to the container.
This commit also adds a folder logstash-conf which can contain multiple configs, which are parsed in lexicographical order.

@rtrauntvein, it's been a long time coming, but supporting multiple download types is finally next on deck. If interested, you can track issue #49. Thanks again for helping with the initial legwork.


Alter the schema to hold multiple Auth0 IDs.

This is a PR that alters the schema in order to allow the storage of multiple user_ids, one per method used.

This needs some more work to update the authentication to reflect these changes.

Closing this one after #1831


Refactor for overwriting permission

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #719 719
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #718 (224c1e1) into master (9a6beef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   16.72%   16.72%
=======================================
  Files          69       69
  Lines        3013     3013
=======================================
  Hits          504      504
  Misses       2458     2458
  Partials       51       51

Impacted Files
Coverage Δ

pkg/ddc/alluxio/transform_permission.go
62.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6beef...224c1e1. Read the comment docs.


Eloquent\Model->getConnection should use getConnectionName

I don't have a good use case for the moment, but I just think that since Model::$connection has a getter (Model::getConnectionName()), the getter should be used instead of direct accessing Model::$connection. Am I wrong?

Please send to 5.2m or even 5.1.


Do not assert(n == 0) in combinations and return empty iterator instead

Consider a case like this:
it.flat_map(|v| (0..v).combinations(x))

This iterator panics if it happens to yield a 0. I feel like it would be much more convenient if the combinations iterator just didn’t yield anything (i.e. was the same as an iterator that always yields None).

Your example code is showing the input iterator being empty (0..v with v = 0) if I understand correctly, and combinations is already yielding None there.

Oh, I swapped variables mistakenly.
It was supposed to be
it.flat_map(|v| (0..x).combinations(v))

instead. For all its worth, Python returns one empty tuple in this case:
list(itertools.combinations([1, 2, 3], 0))
[()]

A precedent is worth something

If we do this, it breaks the documented promise of panicking for n == 0 in .combinations(). It seems the reasonable thing is to emit one empty vector for n == 0, not no iterator elements?

It seems the reasonable thing is to emit one empty vector for n == 0, not no iterator elements?

Yes. This behaviour would also retain the fact that number of distinct combinations is equal to a binomial coefficient (n choose 0 = 1, for any n).


Strange character in log samples and non-conformant samples with RFC5424

I’ve been reviewing it and I could see a strange character (ï»¿) in the log samples. On the other hand, I'm missing the Structured Data before the MSG part. Could you clarify that? As in the samples it seems to me that these logs are not conformant with RFC5424.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4ff82a4d-1c0d-7d05-f383-78a5506dda02
Version Independent ID: 02bd7bc8-76ca-2511-93cb-f3f3de46337d
Content: Microsoft Defender for Identity SIEM log reference
Content Source: ATPDocs/cef-format-sa.md
Service: microsoft-defender-for-identity
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thank you for your comment. We'll investigate and get back to you.

@pablocantos  - Thanks for your comment. We removed the strange characters that you noticed. Regarding your other points, the log samples are just examples, and therefore it's not a documentation issue. This is how the messages will appear in your syslog.
If you have further issues, please open a support ticket.

Thanks for your reply @dcurwin. I could see the documentation updated the strange character disappeared, thanks for that. However, the Syslog is still a non-conformant Syslog RFC5424.
This is a real log that I could see in my systems and I've anonymized it to share here:
1 2023-01-19T01:14:59.958551+00:00 SOMEHOST CEF 12345 PassTheTicketSecurityAlert 0|Microsoft|Azure ATP|2.196.16033.30643|PassTheTicketSecurityAlert|Suspected identity theft (pass-the-ticket)|5|start=2023-01-19T00:02:14.061254Z app=Kerberos suser=someuser msg=some message from externalId=2200 cs1Label=url cs1=https://example.atp.azure.com/securityAlert/00000000-1111-2222-3333-444444444444 cs2Label=trigger cs2=new cs3Label=mSecUrl cs3=https://security.microsoft.com/alerts/aaaaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee
And this is not RFC5424 conformant because it doesn't have a "structured data" section. According to the RFC5424, to be conformat it should be this way (added a dash before the MSG):
1 2023-01-19T01:14:59.958551+00:00 SOMEHOST CEF 12345 PassTheTicketSecurityAlert - 0|Microsoft|Azure ATP|2.196.16033.30643|PassTheTicketSecurityAlert|Suspected identity theft (pass-the-ticket)|5|start=2023-01-19T00:02:14.061254Z app=Kerberos suser=someuser msg=some message from externalId=2200 cs1Label=url cs1=https://example.atp.azure.com/securityAlert/00000000-1111-2222-3333-444444444444 cs2Label=trigger cs2=new cs3Label=mSecUrl cs3=https://security.microsoft.com/alerts/aaaaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee

@pablocantos  - As I wrote, this is not a documentation issue. I suggest you open a support ticket to see if the issue can be resolved to your satisfaction.

Thank you David!


C/CPP: Next Greater Element using stack in CPP

Description
Documentation along with code sample for Next Greater Element Problem using Stack in CPP.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


add tests github workflow to run linting, type-checking and unit test…

…s via CI

Codecov Report

Merging #4 (7cf6713) into main (985c812) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          197       197
  Branches        27        27
=========================================
  Hits           197       197

Impacted Files
Coverage Δ

outreach_sdk/resources/types.py
100.00% <ø> (ø)

outreach_sdk/resources/resources.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985c812...7cf6713. Read the comment docs.


Add RunAsUser to spec, defaults to 33

Increase flexibility on how one can run their containers.

Closing since is exposing a low-level implementation detail.


TypeScript added when not requested

Describe the bug
When I create a new SvelteKit Library project using npm create svelte@latest <name>, I specifically request to have no TypeScript, but the package.json file has typescript and tslib as dev dependencies. Very annoying to have to remove them.
Reproduction
create a new SvelteKit library project, requesting no typescript.
Logs
$ npm create svelte@latest temp

create-svelte version 2.0.1

Welcome to SvelteKit!

√ Which Svelte app template? » Library skeleton project
√ Add type checking with TypeScript? » No
√ Add ESLint for code linting? ... No / Yes
√ Add Prettier for code formatting? ... No / Yes
√ Add Playwright for browser testing? ... No / Yes
√ Add Vitest for unit testing? ... No / Yes

Your project is ready!

Install community-maintained integrations:
  https://github.com/svelte-add/svelte-adders

Next steps:
  1: cd temp
  2: npm install (or pnpm install, etc)
  3: git init && git add -A && git commit -m "Initial commit" (optional)
  4: npm run dev -- --open

To close the dev server, hit Ctrl-C

Stuck? Visit us at https://svelte.dev/chat

System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 8.60 GB / 15.77 GB
  Binaries:
    Node: 18.3.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.2.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.963.0), Chromium (108.0.1462.46)
    Internet Explorer: 11.0.22621.1

Severity
annoyance
Additional Information
No response

When I attempt to package my library, I get the error message: Failed to locate tsconfig or jsconfig. At first, I thought that the problem was that I had removed typescript and tslib via npm uninstall typescript tslib. But when I rebuilt the entire project (it's quite small) by not asking for TypeScript, but then not uninstalling typescript and tslib, I encountered the very same error message when trying to package it via npm run build. I'm going to try including TypeScript from the start, even though I don't want it as part of my project.

If TypeScript is included when the library is originally set up, then npm run build runs without error.

Novice to learn

It would be a terrible thing to add TypeScript by default in just a skeleton if the user do not explicits asks for it. Terrible.
TypeScript adds complexity and has a lot of cons and one of those cons are code complexity. A lot of it. You may have forgotten the basic things, but as most typed programming languages, types are not free. The code get more complicated and the developer must know more stuff. The Development time increases with TS as well (Google typed vs not typed programming language and compare it to development speed, but this discussion is at least 40 years old). You may love it, and want everyone to use your new lover (TypeScript), but it will increase the complexity and make sveltekit harder to use.
Of course, I don´t think you want it and I am sure you don´t think TypeScript makes it harder, but it 100% does. TypeScript is the new C#/Java. In 5 years will everyone says it is too bloated anyway. It has all the signs for it already were it is heading.


hyper: mark as broken

Description of changes
Marks hyper as broken because of runtime error.

Log
innerError Error: Cannot find module '../build/Debug/pty.node'
Require stack:
- /nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js
- /nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/index.js
- /nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/session.js
- /nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/ui/window.js
- /nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/index.js
-
    at Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at n._resolveFilename (node:electron/js2c/browser_init:245:1105)
    at Module._load (node:internal/modules/cjs/loader:785:27)
    at c._load (node:electron/js2c/asar_bundle:5:13343)
    at Function._load (/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/plugins.js:103:37)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js:30:15)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1175:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/unixTerminal.js',
    '/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/node_modules/node-pty/lib/index.js',
    '/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/session.js',
    '/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/ui/window.js',
    '/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/index.js',
    undefined
  ]
}
A JavaScript error occurred in the main process
Uncaught Exception:
Error: `node-pty` failed to load. Typically this means that it was built incorrectly. Please check the `readme.md` to more info.
    at createNodePtyError (/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/session.js:39:34)
    at Object.<anonymous> (/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/session.js:46:11)
    at Module._compile (node:internal/modules/cjs/loader:1120:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1175:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:829:12)
    at c._load (node:electron/js2c/asar_bundle:5:13343)
    at Function._load (/nix/store/s6fcai3kfzf3a6ds7zdvgfc79g8xins5-hyper-3.4.1/opt/Hyper/resources/app.asar/plugins.js:103:37)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at require (node:internal/modules/cjs/helpers:102:18)

Fixes test timeout nixos.tests.terminal-emulators.hyper:
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.terminal-emulators.hyper.x86_64-linux
According to that test error started from hyper build on 2023-04-12:
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.terminal-emulators.hyper.x86_64-linux/all?page=15
https://hydra.nixos.org/build/215757444
Last good run:
https://hydra.nixos.org/build/215468671
First bad run:
https://hydra.nixos.org/build/215718591
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

hyper maintainers:
@puffnfresh
@FabianGD


[ RFC ] Global color modifiers

I've discussed with @filrak about creating common modifiers for components globally (as Bulma does), at least for colors.
So, some classes like has-bg-primary and has-text-primary should be created and available for all convenient components, then these components shouldn't have BEM modifiers specifically for the primary color.
Imo we should create these modifiers for primary, secondary, danger, warning, info and success colors, wdyt? The respective modifiers should be removed from components, we should use the global ones instead.

imho it's certainly the way to go. Could you propose the modifiers list @leomp12? Also I would love to hear opinions from @mayashavin @przspa @patzick @lauragift21 (even a short ones)

@leomp12 @filrak I agree on the global ones. We should have a global palettes and global sizes, this way we don't need to define again specific modifiers and make it harder to control the styling. You can check the implementation of the size in SfIcon. I would suggest we define something more specific rather than pink-primary and pink-secondary also.

This is a great idea @leomp12. I also believe this is the right way to go it helps us manage all color modifiers in one place.

@filrak sure, I'll take care of it.
@mayashavin about sizes, I think it may be available for almost all atoms, right?
Although, I think it would be component specific, we can use modifiers with the same class names, but imo .sf-price.lg should apply different styles than .sf-button.lg for example, wdyt?

@leomp12 Indeed. Forgot that it need to be specific per component :)


could not find function "TrainKNN"

After running the first commands for Figure 1 (01_human_clustering.R), which completed without errors, the second script (02_human_cluster_mapping.R) generates errors. Please advise

Rscript 02_human_cluster_mapping.R

Error in TrainKNN(ref.norm.counts, genes.use, ref.ident, pcs.use = pcs.use) :
could not find function "TrainKNN"
Execution halted

Rscript 02_human_cluster_mapping.R

Attaching SeuratObject
Loading required package: S4Vectors
Loading required package: stats4
Loading required package: BiocGenerics
Loading required package: parallel
Attaching package: 'BiocGenerics'
The following objects are masked from 'package:parallel':
clusterApply, clusterApplyLB, clusterCall, clusterEvalQ,
clusterExport, clusterMap, parApply, parCapply, parLapply,
parLapplyLB, parRapply, parSapply, parSapplyLB

The following objects are masked from 'package:stats':
IQR, mad, sd, var, xtabs

The following objects are masked from 'package:base':
Filter, Find, Map, Position, Reduce, anyDuplicated, append,
as.data.frame, basename, cbind, colnames, dirname, do.call,
duplicated, eval, evalq, get, grep, grepl, intersect, is.unsorted,
lapply, mapply, match, mget, order, paste, pmax, pmax.int, pmin,
pmin.int, rank, rbind, rownames, sapply, setdiff, sort, table,
tapply, union, unique, unsplit, which.max, which.min

Attaching package: 'S4Vectors'
The following object is masked from 'package:base':
expand.grid

Warning messages:
1: replacing previous import 'stats::sd' by 'S4Vectors::sd' when loading 'CellMapper'
2: replacing previous import 'stats::var' by 'S4Vectors::var' when loading 'CellMapper'
calculating variance fit ... using gam [1] 3428
ref.ident
AT1 Cell
163
AT2 Cell
2008
Acinar cell
818
Adiocyte cell
15
Adipocyte
370
Adipocyte\302\240
64
Alveolar bipotent progenitor
32
Alveolar macrophage
535
Antral mucous cell
217
Astrocyte
199
Astroglial cell
30
Atrial cardiomyocyte
271
B Cell
697
B cell
8556
Basal epithelial cell
344
Basophil
538
Basophils
244
Brown adipose tissue
433
CXCL12-abundant reticular cell
66
Cardiac muscle cell
54
Cartilage cell
2223
Cell in cell cycle
1
Chondrocyte
165
Ciliated cell
106
Clara Cell
150
Columnar epithelium
266
Conventional dendritic cell
373
Cumulus cell
1283
DPT cell
1012
Decidual stromal cell
103
Dendritic Cell
66
Dendritic cell
2439
Dendrtic cell
113
Distal collecting duct principal cell
185
Distal convoluted tubule
553
Dividing T cells
53
Dividing cell
647
Dividing cells
44
Dividing dendritic cells
33
Dividng cell
184
Dopaminergic neurons
256
Ductal cell
381
Ductal luminal cell
2109
ES
9991
Elongating spermatid
4326
Endocrine cell
307
Endocrine progenitor cell
51
Endodermal cell
80
Endothelial Cell
14
Endothelial cell
3807
Endothelial cells
342
Enteric muscle cell
353
Enterocyte progenitor
1633
Enteroendocrine
22
Eosinophil granulocyte
261
Eosinophil progenitor cell
180
Eosinophils
86
Ependymal cell
71
Epithelia cell
99
Epithelial cell
3737
Epithelium of small intestinal villi
1401
Erythroblast
10180
Erythrocyte
76
Erythrocyte progenitor
1071
Erythrocytes
925
Erythroid Cell
98
Fenestrated endothelial cell
192
Fibroblasts
333
G cell
51
Ganglion cell
169
Gastric mucosal cell
46
Glandular epithelium
362
Glial cell
71
Glomerular epithelial cell
2
Granule neurons
555
Granulocyte
570
Granulocyte monocyte progenitor cell
124
Granulocyte monocyte progenitors
86
Granulosa cell
477
HSPC
39
Hematopoietic stem progenitor cell
16
Hepatocyte
217
Hepatocyte-Like Cell
13
Hippocampus neurons
228
Hypothalamic ependymal cell
9
Ig\342\210\222producing B cell
29
Immunocyte
183
Intercalated cells of collecting duct
535
Interstitial macrophage
224
Invasive spongiotrophoblast
607
Keratinocyte
86
Kuppfer cell
1046
Labyrinthine trophoblast
23
Large luteal cell
206
Left ventricle cardiomyocyte
1139
Leydig cell
462
Luminal cell
347
Luminal progenitor
56
Lymphatic vessel endothelial cell
14
Lymphoid progenitor cell
32
MEF
854
MSC
82
Macrophage
7544
Marcrophage
35
Marginal zone B cell
1024
Mast cell
531
Megakaryocyte
79
Megakaryocyte progenitor cell
451
Melanocyte
34
Mesenchymal cell
634
Mesenchymal stem cell
7319
Mesenchymal stromal cell
357
Metanephric mesenchyme
3
Microglia
417
Monocyte
827
Monocyte progenitor
2374
Monocyte progenitor cell
4858
Multipotent progenitor
1596
Muscel cell
3
Muscle
228
Muscle  cell
11
Muscle cell
2479
Muscle progenitor cell
87
Myelinating oligodendrocyte
3150
Myeloid leukocyte
140
Myoblast
62
Myoepithelial cell
94
NK
183
NK Cell
275
NK cell
1614
NKT cell
33
Natural kill cell
10
Neural progenitor cell
325
Neuron
1456
Neuronal Cells
152
Neuronal Progenitors
27
Neuronal cell
448
Neutrophil
18484
Neutrophil
460
Neutrophil granulocyte
65
Neutrophil progenitor
114
Nuocyte
151
Oligodendrocyte
26
Oligodendrocyte precursor cell
72
Osteoblast
1335
Osteoblasts
470
Osteoblast\302\240
1120
Osteoclast
22
Ovarian surface epithelium cell
84
Ovarian vascular surface endothelium cell
153
PE lineage cell
503
Pan-GABAergic
26
Paneth cell
203
Parietal cell
88
Pericentral
119
Periportal
26
Pit cell
383
Plasma cell
21
Plasmacytoid dendritic cell
295
Postmitotic neurons
207
Pre T cell
18
Pre-Sertoli cell
564
Pre-pro B cell
68
Preleptotene spermatogonia
637
Preosteoblast/Osteoblast/Bone cell/Cartilage cell
5205
Proerythrocytes
1522
Progenitor cell
296
Progenitor trophoblast
437
Proliferating thymocyte
403
Prostate gland cell
1719
Proximal tubule brush border cell
960
Proximal tubule cell
428
Purkinje cell
76
Pyramidal neuron cell
347
Radial glia
622
Reproductive tissues
17
S cell
53
S1 proximal tubule cells
275
S3 proximal tubule cells
255
Schwann cell
649
Secretory alveoli cell
1874
Sertoli cell
269
Skeletal Muscle
70
Skeletal muscle cell
136
Small luteal cell
557
Smooth muscle cell
920
Spermatids
2570
Spermatocyte
3686
Spermatogonia
1167
Spiral artery trophoblast giant cells
283
Spongiotrophoblast
258
Stem and progenitor cell
319
Stomach cell
1157
Stroma cell
484
Stromal Cell
548
Stromal Cell Cldn11 high
28
Stromal cell
18662
T Cell
460
T cell
8273
T-cells
157
TS
18635
Tendon stem/progenitor cell
185
Thecal cell
473
Thick ascending limb of the loop of Henle
418
Trophoblast progenitor
68
Tuft cell
30
Umbrella cell
75
Ureteric epithelium
41
Urothelium
315
Vascular endothelial cell
395
Vascular smooth muscle progenitor cell
13
Ventricle cardiomyocyte
81
abT cell
237
gdT cell
77
luteal cells
523
\316\262-cell
104
Error in TrainKNN(ref.norm.counts, genes.use, ref.ident, pcs.use = pcs.use) :
could not find function "TrainKNN"
Execution halted

Can you fix the code so the workflow is reproducible?  There are multiple errors throughout. For example, library(cellMapper) doesn't work because it should be library(CellMapper)

Ah I think you have the wrong library it should be: https://github.com/yanwu2014/cellMapper
Install with: remotes::install_github("yanwu2014/cellMapper")
I did test the code before I pushed it but let me know if you run into any other issues!

Updated the readme so that the specific libraries required are a bit more clear, let me know if that helps!


Additional labels for 240 NPSP

Critical Changes
Changes
Additional labels from the latest update
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

@lparrott One thing I noticed here is that our cleanup script is stripping out several of the quickActions elements that have been translated, even the new quick actions we've added for 240 like Refund. The newer Paused quick action is stripped as well. It looks like the part of the script that does this is in the screenshot below. @force2b, was there any reason why we would want to strip quick actions or do we just need to fix this in the script? The script stripped the following quick actions:

npe03__Recurring_Donation__c.Pause
npe03__Recurring_Donation__c.New_Opportunity
npe01__oppPayment__c.Refund
npe03__Recurring_Donation__c.Quick_Update
npo02__Household__c.Update_Household
Address__c.Update_Address
npe03__Recurring_Donation__c.Close_Recurring_Donation
npe01__OppPayment__c.Quick_Update

@daniel-fuller Those lines are removing translations with a double underscore in the name field, which I think is intended to target underlying packages, though I'm not sure why.
It could be time to retire that part of the script, because we definitely want the Quick Action Label translations included!

@daniel-fuller Those lines are removing translations with a double underscore in the name field, which I think is intended to target underlying packages, though I'm not sure why.
It could be time to retire that part of the script, because we definitely want the Quick Action Label translations included!

@lparrott Agreed. I just won't push up those script changes. Those were the only changes the script made for these labels so this is ready for a final review to push into the parent localization branch

I suspect removing that is fine. There was a metadata bug at one point where QuickAction labels were not translatable, so that may have been why it was stripping them out.

@lparrott I added https://github.com/SalesforceFoundation/NPSP/pull/7070/commits/44abca055d31fc861dd6b331bd92b1a1fa8c944d to remove the xpath syntax that was stripping the quick actions. This should be ready for a final approval before we merge into the parent branch


Document environment variables from dockerfile

Hello! Can you write a comment about what and why you did that please.

Hello @lauriejim.
The Dockerfile is the first thing you examine when setting up a container.
by setting the ENV variables in the Dockerfile instead of the strapi.sh file, you get self-documenting environment variables.

ENV vars are visible in the Dockerfile
ENV vars are visible with docker inspect
ENV vars are listed as definable, even without being set per user, or being documented via a README.md file:

Okay
Here is travis issue.
$ docker build -t strapi/strapi .
Sending build context to Docker daemon  8.192kB
Error response from daemon: ENV must have two arguments
The command "docker build -t strapi/strapi ." exited with 1.

I think it's for database username and password

HI,
We just released a full rebuild of our docker image 🎉
We are closing the issues and open PRs to start fresh.
If you feel like something is missing or want to add things feel free to open new PRs ! 💯


Minor fixes and cleanings

Before this merge opl_driver should be failing unit tests due to tdf being function argument here but input_tdf being referenced inside function body. Please verify this before merge.
Please review changes here

Fixing above bug and in general tidying up create_opl_mod_text
Creating seperate diagnostic routine create_opl_mod_output_text and exporting both routines as public ticdat functions.
opl_run references new utils.development_deployed_environment before twiddling environmental variables.
development_deployed_environment also used to determine whether or not a unique working directory needs to be created for passing files around. (Otherwise multiple solves on the same server could collide on deployment).

fixes look good, test verified broken before merge. Am merging then will make sure tests work (then I will close #1634)


added chat application

heroku link : http://bikas-chat-application.herokuapp.com/

@abhishekjha812 , have a look on my project


Inconsistent file path format

On this page it recommends an example file path for the certs, in the config.yaml, like "C:/x/y/z.pem" but in the actual config.yaml file on my edge device, I see these comments:
Note:
The values of all of these fields must be specified as a
"file" scheme URI such as "file:///path/cert_key.pem"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94792ff1-5976-90f4-5092-0d8d8ff01635
Version Independent ID: d65482d2-64cc-56b1-c52a-b3ddde07b205
Content: Manage device certificates - Azure IoT Edge
Content Source: articles/iot-edge/how-to-manage-device-certificates.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

Sorry, my quote from this article's format should have been "c:\\device-ca.cert.pem"

@rgamage Thanks for the feedback! We are currently investigating and will update you shortly.

@rgamage I have assigned the issue to the content author @kgremban  for further review and update the doc as appropriate.

@rgamage Correct, with the 1.0.9 release the config file switched from using absolute paths to file URIs. I will update this reference. Thank you for flagging it.

Since this was a straightforward fix, I'll have GitHub automatically close this issue once the pull request with the changes gets merged. Thanks again.