[Draft] oneOf support for query strings

As mentioned in gitter this tackles the oneOf support for query string. But I'll need some help with a couple bits.

OpenApi Generation: I am unsure what the correct way to flatten out nested options is.
Testing. I haven't quite found in which endpoints definition to hook this in (besides openapi) to make sure it works for all the implementations
Sealed Trait encodings? Is there a sensible way to have those in headers or is it strictly enums? Currently the encoding doesn't stop you from doing it since it's a simple "find first success" decoding strategy. So it has no tagging support or anything like that. I am unsure what exactly we need here.

Formatting and cleaning is not done yet as it's still a draft.
I also added a possible encoding of Alternative and anolog to Tupler that could help people have less issues with heavily nested eithers. If we decide to retain this I'll probably use it for a bit more sizable test for query string enums.

In particular what is going to need some design-elbow-grease is the question if we want to do this fallback strategy.
Right now there's nothing stopping you from doing something like this:
sealed trait Foo
case class Bar(value:String) extends Foo
case class Baz(value:String, value2:Int) extends Foo

Note that in terms of structural subtyping (depending on the particular encoding you choose for the case classes) we have Baz <: Bar so with a simple fallback decoding, without type tagging, assuming we try Bar first, any valid value of Foo will be decoded to Bar. This is quite the pitfall (though arguable you probably shouldn't encode something like this in a query string anyway). But the question remains how we want to deal with. If we want this to be as safe as JsonSchema we'll need an algebra of similar expressive power I think.

In most cases the usecase is really just straight up enums. So in particular we have a search endpoint where we'd like to have the search parameters in the URL so that this search can easily be bookmarked or shared by users.
Most of the parameters are e.g. TYPE=x where x oneOf (A,B,C) so fixed values enumerations. That should be easily doable in a way that also lends itself to generating openapi spec (which is what we're very interested in).
The other much harder case is e.g. DATE=IS_BETWEEN(lower, upper) where lower and upper are ISO date strings. And here is the scenario where you'd have a sealed trait that is decoded from a query string because DATE=IS_NULL is also fine for us. I'm not even sure if it's possible to have this automatically derived in openapi.
Right now we just work with a stringly types query string that we xmapPartial but that suppresses any structural info on the openapi

Most of the parameters are e.g. TYPE=x where x oneOf (A,B,C) so fixed values enumerations. That should be easily doable in a way that also lends itself to generating openapi spec (which is what we're very interested in).

For that use case, an approach similar to enumeration in JsonSchemas should work. What do you think?

The other much harder case is e.g. DATE=IS_BETWEEN(lower, upper) where lower and upper are ISO date strings. And here is the scenario where you'd have a sealed trait that is decoded from a query string because DATE=IS_NULL is also fine for us. I'm not even sure if it's possible to have this automatically derived in openapi.

Here, I am not even sure there is a way to express that in JSON Schema. It seems that “ranges” are supported for numeric values only. I think the only solution is to indicate in the description of the query parameter what are the validation constraints.

I think you're right. I'll probably start from scratch again and restrict it to "true" enums. Maybe it would be interesting to explore to "derive" documentation for query params that actually carry data (so like the DATE) In our case we have in the backend a filter ADT that we decode from the query strings in an xmap. My current idea is to use the structure of that ADT to dervive the documentation text block explaining what goes into each possibility.
So I think I'll restrict this MR purely to enums and then internally develop the documentation block derivation, if it pans out I'll upstream it.


Build a Docker container that builds all the various pieces of Funcatron and test them

Create a docker container that

Takes the parent directory of the Funcatron projects
Ensure's there's no uncommitted code in the projects
installs intf
installs starter
installs devshim
Builds tron
starts a Tron instance and a Runner instance
builds each of the samples and uploads them to the tron
Tests that each sample runs
Creates a project with starter
Compiles and uploads the starter project and insures it can run
Kills the Tron and Runner instances
Starts a dev-mode Tron instance
Ensures that starter project works in devmode

Closed with https://github.com/funcatron/funcatron/commit/b136cf40cc0ba97c3167957a65bc8430ae3d57cf


Zoom::ParameterMissing ([:user_id])

Using user_id instead of hots_id in fixes this issue, is the README file not updated?

zoom_client.meeting_list(host_id: user_id)
zoom_client.meeting_list(user_id: user_id)

Most likely not, sorry. If you want to submit a PR with the changes that would be awesome!


Smoke tests

This PR consists of two smoke tests, 1) testGrid, and 2) testDataMgr
Like all of our test applications, compiling these tools need BUILD_TEST_APPS to be switched ON with ccmake.
See the headings of testGrid.cpp and testDataMgr.cpp for what the tests are exercising.
Both tools have flags that can be listed with the -help option.  Issuing -help for testGrid yields the following:
cisl-farmington:build pearse$ bin/testGrid -help
    OPTION          NUM_ARGS    DEFAULT
    ------          --------    -------
    -arrangements   1           Constant:Ramp:Triangle
        Colon delimited list of data arrangements to test synthetic grids with
    -bs             1           64:64:64
        Internal storage blocking factor expressed in grid points (NX:NY:NZ)
    -dims           1           8:8:8
        Data volume dimensions expressed in grid points (NX:NY:NZ)
    -extents        1           0:0:0:1:1:1
        Colon delimited 6-element vector specifying domain extents of synthetic
        grids in user coordinates (X0:Y0:Z0:X1:Y1:Z1)
    -grids          1           Regular:Stretched:Layered:Curvilinear
        Colon delimited list of grids to test
    -help           0           false
        Print this message and exit
    -maxValue       1           1
        The maximum data value to be assigned to cells in synthetic grids
    -minValue       1           0
        The minimum data value to be assigned to cells in synthetic grids

Copyright 2007 The National Center for Atmospheric Research

Version: 3.2.0 (2020-03-09T21:46:32Z) www.vapor.ucar.edu

@clyne Sorry John, I was not clear on how to use the driver.
Now that issue #2252 is fixed, I've added baseline files to this PR that we can use to compare test results with.  If the Grid or DataMgr tests differ from the baseline, the test will exit -1.
I've also added logic to automatically generate baseline files if none are detected.
You will need to download the test data linked here: https://drive.google.com/open?id=1w8CLOohQuVrhcDbmIyU68whvqaoiCx9t
smokeTests.py will also need you to pass two arguments: --testDataRoot and --binaryRoot.  Passing the --help flag yields the following:
`cisl-farmington:VAPOR_gridTests pearse$ ./test_apps/smokeTests/smokeTests.py --help
usage: A test driver for the DataMgr and Grid classes [-h]
[--makeBaseline false]
[--testDataRoot /path/to/data]
[--binaryRoot /path/to/binaries]
optional arguments:
-h, --help            show this help message and exit
--makeBaseline false  Boolean that makes these test results the baseline on
which future tests will be compared. If no baseline
file exists, this will automatically be set to true.
--testDataRoot /path/to/data
Directory where DataMgr test data is stored.
--binaryRoot /path/to/binaries
Directory where binary test programs (testGrid,
testDataMgr) are stored.`

@clyne After rebuilding the baseline files, I believe another bug has arisen.  See #2259.
We shouldn't accept this PR until we have good baseline files to compare future changes with.


ssl_verify_test: clang-analyzer fix to account for null sni_name

clang-analyzer was upset due to a debug statement using a char* that could potentially be null.  This should resolve the error.

Cherry-picked to v9.2.x

Thanks for the fix, please remember to mark for the appropriate release branches (10-Dev is not relevant here, since this is not a compatibility issue)


panicked at 'dispatch dropped without returning error' with hyper

I get this error:
 panicked at 'dispatch dropped without returning error', /home/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.14.20/src/client/conn.rs:329:35
when I do call JsonRpcClient::call(), it happens at random, not always constant. Checking around seems I get this similar issue posted on hyper's github https://github.com/hyperium/hyper/issues/2892, they recommend making the client shareable, also this other project has similar issues: https://github.com/ydb-platform/ydb-rs-sdk/issues/92

The repo I use that causes: https://github.com/Borwe/near-exchanges
Running the tests individually doesn't cause this problem for some reason.

Hi there, so here's the thing. If you're dealing with multiple runtimes, you should not use the same JsonRpcClient connector. So, swap out JsonRpcClient::connect which uses a default, global connector for a manual connector.
- JsonRpcClient::connect(URL);
+ let connector = JsonRpcClient::new_client();
+ let client = connector.connect(URL);

If this helps you, feel free to close the issue.

@Borwe, please let me know if this helps you. Otherwise, I'll be closing this issue in 4 days if there's no update.

Closed. Feel free to reopen if you think your issue is unresolved.


Add CONTRIBUTING.md

Contributing
XXX is an open source, community-driven project.
If you'd like to contribute, please read the following documents:

Reviewing issues/pull requests
Reporting a Bug
Submitting a Patch
XXX Core Team
Security Issues
Running XXX Tests
Our Backwards Compatibility Promise
Coding Standards
Conventions

validation :

[ ] Reviewing issues/pull requests
[ ] Reporting a Bug
[ ] Submitting a Patch
[ ] XXX Core Team
[ ] Security Issues
[ ] Running XXX Tests
[ ] Our Backwards Compatibility Promise
[ ] Coding Standards
[ ] Conventions


soroban-docs: Revisit a way to automate and/or verify the soroban-rpc docs

What problem does your feature solve?
We might forget to update the docs to match as we change soroban-rpc.
What would you like to see?
Automatic generation or at least verification that the docs match the API as expected. This is an "eventually" wishlist item following on from https://github.com/stellar/soroban-docs/issues/247, where there is some previous work linked.
What alternatives are there?
Do it manually

@paulbellamy I see that this was described as fixed in this comment. Would you mind providing feedback as to whether on not this issue still live or can we close it out?
Thanks

No, the other PR was just about adding some docs at all. This is about using swagger/openapi/openrpc or some other tool to automatically generate (or verify) the api docs are up-to-date.

Related: https://github.com/stellar/soroban-tools/issues/508


Hot Fix - Changes for RPP ASAN, License file pkging

Proposed Changes:

Enable ASAN Packaging (component based split for dev, runtime and asan)
Add LICENSE file to RPP package
Cherry Pick Changes 056632e5367b81b102aa52acb2162b7f12de46df, 6445456e5e0c2aeba5e7832f455795b7000f8308, 0be915d2423280f06237bbaf27fe141e6f0d0e8c, 0a79f85308d260f0ce39d9178130a6ceaab7f25e, 9686f177258baf117f5a88e6b82d9418a862c0a3
from https://github.com/GPUOpen-ProfessionalCompute-Libraries/rpp/pull/235/commits

@kiritigowda  hope, we will put this PR in master branch also.
SWDEV-429959 is originally filed for mainline.

@pramenku - This PR is available on TOT master. We need to use latest for mainline.

@pramenku - This PR is available on TOT master. We need to use latest for mainline.

Hi @kiritigowda , When we can expect all the changes to be in "master" branch?

@pramenku - This PR is available on TOT master. We need to use latest for mainline.

Thanks @kiritigowda . I guess, https://github.com/GPUOpen-ProfessionalCompute-Libraries/rpp/pull/235 is the PR for master.


Add back shebang in generated assembly

Fixes #160

The generated djinni artifact or this PR  is used in this generator branch.
When we have merged this change, and merge this change into the support lib, it will be possible in the support lib to select for a PR which generator to choose, release, pre-release, from a PR.  (successful PRs must run with release, but it will be possible to fully test the build)

FYI @mutagene ^^ ,  this will be the way to get in #157 with a tested support lib that shows it's using your generator


readme changes

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@storage_readme#subdirectory=src/$EXT&egg=$EXT"


add provisions for incremental encode/decode

This looks like an interesting new serialization strategy and I am looking for a new storage backend. Could the library be used for serializing lists of X incrementally via streams or would the top-level schema interfere with that?

That is not supported by the library itself because it makes sense only on top level, and the functions operates on strict ByteStrings. I think it's easy to implement it orthogonally; the winery command line tool uses a format where payloads are prefixed by their length, in decimals.


NetBox and IPF Config

Hi, where/how do you define the ip, credentials etc for each platform?
For NetBox I see a setup.env in devtest-env but not sure how that is used once configured. There is also a const.py but also doesn't have the IPF defined. So actually not sure what to actually configure and where.
Please can I get some quick and dirty instructions for configuring/using please?
Thanks
Mark

@Mark32 - my apologies for the delay responding.  This tool requires a TOML based configuration file; the same as in the netcfgbu project.  The additional section for ipf-netcfgbu is:
[ipfabric]
    server_url = "$IPF_ADDR"
    credentials.username = "$IPF_USERNAME"
    credentials.password = "$IPF_PASSWORD"

The environment variables can be of your choosing; I just happen to name them as above.
Hope this helps!


Change from Google workspace

Hello @Mohamedmouniranwar. It looks like your feedback didn't come through fully. Can you please tell us to which article it applies, and tell us what's needed? Thank you!


Hitting rate limits when testing with imageAllowRules.

acorn version v0.6.0-98-g871782ee+871782ee
Steps to reproduce the problem:
I had been deploying few apps in projects that have imageAllowRules.
Images are from docker hub.
After some attempts , i start seeing rate limits .
I have seen this happen twice so far with using 2 different authenticated dockerhub users.

@iwilltry42  When apps get deployed in a project with imageAllowRule , is there a constant check made for the images ? If so, how often is this done?
I am already rate limited in my setup that was fresh from about 1 hour back, so 100 pulls consumed . I barely have 3 -4 apps running out of which 1 of them is auto-upgrade format.
May be the autoupgrade is making this happen so fast. But wanted to know if regular images (no autoupgrade) is also doing any images pulls at regular intervals ?

acorn version v0.6.0-106-g09f636a2+09f636a2
I am still hitting ratelimit issues when testing with  imageAllowRules.
Would deploying apps with auto-upgrade tag and public images hosted in docker ( I am not using private images in docker hub) result in ratelimit issues ?
I had about 3-4 apps running with images  in auto-upgrade format with --interval set to 15s before I hit rate-limit issue.
acorn apps -j acorn
NAME                     IMAGE                                                                                HEALTHY   UP-TO-DATE   CREATED     ENDPOINTS                                                                    MESSAGE
check1                   index.docker.io/sangeetha/myfirstacorn:v6.0.0                                              1         1            18m ago     http://nginx1-check1-762ea864.local.on-acorn.io => nginx1:80                 [image-pull: GET https://index.docker.io/v2/sangeetha/myfirstacorn/manifests/v6.0.0: TOOMANYREQUESTS: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit]
mytestauto1              index.docker.io/sangeetha/testautoupgradedeploy1:v0.0.2                                    1         1            19m ago     http://nginx-mytestauto1-fe277915.local.on-acorn.io => nginx:80              [image-pull: GET https://index.docker.io/v2/sangeetha/testautoupgradedeploy1/manifests/v0.0.2: TOOMANYREQUESTS: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit]
mytestauto                                                                                0         0            20m ago                                                                                [image-allowed: waiting for image to satisfy auto-upgrade tag v#.#.#] [image-pull: waiting for image to satisfy auto-upgrade tag v#.#.#]
testautoupgradedeploy1   index.docker.io/sangeetha/testautoupgradedeploy1:v0.0.2                                    1         1            21m ago     http://nginx-testautoupgradedeploy1-750c70b1.local.on-acorn.io => nginx:80   [image-pull: GET https://index.docker.io/v2/sangeetha/testautoupgradedeploy1/manifests/v0.0.2: TOOMANYREQUESTS: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit]

@sangee2004 I did more thorough debugging now.
The check for 404s returned by the initial HEAD request failed.
I fixed that locally, but I also see the second error you get there on image-pull.. though that's probably unrelated to imageAllowRules :thinking:

Here we go again @sangee2004 !
I'm sorry for this back and forth. Seems like the Debugger and Network inspection betrayed me last time :roll_eyes:

@iwilltry42 I fixed that locally, but I also see the second error you get there on image-pull.. though that's probably unrelated to imageAllowRules ==> This was an app that was deployed with autoupgrade tag were there is no matching tags that are signed. Thats the only difference between the 2 apps that were deployed. The first one had few matching tags that satified the imageAllowRules but the 2nd app has none.

Tested with acorn version v0.6.0-132-gdc73d55a+dc73d55a
Remaining pulls - 84 @ ~1:22 PM
Remaining pulls -  66. @ ~1:26 PM
Remaining pulls - 38: @ ~1:34 PM
I am still seeing the docker rate-limit being consumed steadily when testing when deploying apps in autoupgrade format in projects that have imageRuleAllow:
These are the 2 apps I have running with 15s interval in auto-upgrade format:
 acorn apps
NAME      IMAGE                                           HEALTHY   UP-TO-DATE   CREATED   ENDPOINTS                                                       MESSAGE
mytest2   index.docker.io/sangeetha/mydeletecheck         1         1            12m ago   http://myweb1-mytest2-75092b32.local.on-acorn.io => myweb1:80   [image-allowed: failed to check if image is allowed: error ensuring references for image index.docker.io/sangeetha/mydeletecheck: failed to ensure signature artifact: no matching signatures: expected signature artifact index.docker.io/sangeetha/mydeletecheck:sha256-47a8d83df3aef36b48a15415549e6487ddb94075c77e0d7f33894685e8bcce4e.sig not found]
mytest1   index.docker.io/sangeetha/myfirstacorn:v0.0.2   2         2            13m ago   http://nginx-mytest1-6ee78f86.local.on-acorn.io => nginx:80     OK

I see the same behavior of docker rate-limit being consumed steadily when  deploying apps in autoupgrade format in projects that have  NO imageRuleAllow.
This issue is tracked in - https://github.com/acorn-io/acorn/issues/1398

I will leave this in open state until https://github.com/acorn-io/acorn/issues/1398 gets addressed and try these usecases as well.

Tested with acorn version v0.6.0-136-gc2c4989d+c2c4989d
Did not encounter Rate limit issues when testing the following apps:

Apps deployed in autoupgrade format with --interval=15s  for public images hosted in docker hub
Apps deployed in autoupgrade format with --interval=15s  for private images hosted in docker hub
Apps deployed in autoupgrade format with --interval=15s  for public images hosted in docker hub in projects that have ImageAllowRules.
Apps deployed in autoupgrade format with --interval=15s  for public images hosted in docker hub in projects that have ImageAllowRules and dont have any version that matches the ImageAllowRules.

This is the best thing I've read in a while, thank you 😁


Seems we loose types on feature specific clusters

Add a new test to the Clusterfactorytest.ts like
it("creates clusterserver with a feature and handlers", () => {
            const fullCluster = ClusterServer(
                TestExtensibleCluster.with("Extended"),
                {
                    attr1: 1,
                    attr2: 2,
                },
                {
                    cmd1: ({ attributes: { attr1, attr2 }, session, endpoint}) => {
                        if (attr1 == undefined || attr2 == undefined || session === undefined || endpoint === undefined) throw new Error("Missing attribute");
                    },
                    cmd2: ({ request: { cmdField1 },  attributes: { attr1, attr2 }, session, endpoint}) => {
                        if (cmdField1 === undefined || attr1 == undefined || attr2 == undefined || session === undefined || endpoint === undefined) throw new Error("Missing attribute");
                        return { cmdRet1: 5 };
                    },
                    getAttr1: ({ attributes: { attr1, attr2 }, session, endpoint}) => {
                        if (attr1 == undefined || attr2 == undefined || session === undefined || endpoint === undefined) throw new Error("Missing attribute");
                        return 5;
                    }
                },
                {
                    ev1: true,
                    ev2: true,
                }
            );
        })

including one adkjustment:
const ELEMENTS2 = {
    attributes: {
        attr2: Attribute(4, TlvUInt8)
    },
    commands: {
        cmd2: Command(5, TlvObject({ cmdField1: TlvField(1, TlvUInt16)}), 5, TlvObject({ cmdRet1: TlvField(1, TlvUInt16)}))
    },
    events: {
        ev2: Event(6, EventPriority.Debug, TlvNoArguments)
    }
}

All the attributes and request options are all considered "any" which is wrong. Interestingly enough the return type is interfered correctly.
After tracking it down I ended in the fact that the method extendCluster in CLusterfactory does an "inplace" upgrade for the operative data of the clusters but the typing extension do not seem to work correctly.
Also in BLE branch (in matter-node.js/-examples/DevcieNode.ts we have a Wifi Networking cluster. here it is the same but the typing error also points to something more as it seems:
So adjust to like

and you get
src/examples/DeviceNode.ts:180:21 - error TS2322: Type '({ request: { ssid, breadcrumb }, attributes: { lastNetworkingStatus }, endpoint }: { request: { ssid: any; breadcrumb: any; }; attributes: { lastNetworkingStatus: any; }; endpoint: any; }) => Promise<{ networkingStatus: NetworkCommissioningStatus; wiFiScanResults: { ...; }[]; }>' is not assignable to type '(args: { request: any; attributes: AttributeServers<{ maxNetworks: FixedAttribute<number, any>; networks: Attribute<TypeFromFields<{ networkId: FieldType<Uint8Array>; connected: FieldType<...>; }>[], any>; interfaceEnabled: WritableAttribute<...>; lastNetworkingStatus: Attribute<...>; lastNetworkId: Attribute<...>; ...'.
  Types of parameters '__0' and 'args' are incompatible.
    Type '{ request: any; attributes: AttributeServers<{ maxNetworks: FixedAttribute<number, any>; networks: Attribute<TypeFromFields<{ networkId: FieldType<Uint8Array>; connected: FieldType<boolean>; }>[], any>; interfaceEnabled: WritableAttribute<...>; lastNetworkingStatus: Attribute<...>; lastNetworkId: Attribute<...>; las...' is not assignable to type '{ request: { ssid: any; breadcrumb: any; }; attributes: { lastNetworkingStatus: any; }; endpoint: any; }'.
      Types of property 'attributes' are incompatible.
        Property 'lastNetworkingStatus' is missing in type 'AttributeServers<{ maxNetworks: FixedAttribute<number, any>; networks: Attribute<TypeFromFields<{ networkId: FieldType<Uint8Array>; connected: FieldType<boolean>; }>[], any>; interfaceEnabled: WritableAttribute<...>; lastNetworkingStatus: Attribute<...>; lastNetworkId: Attribute<...>; lastConnectErrorValue: Attribut...' but required in type '{ lastNetworkingStatus: any; }'.

180                     scanNetworks: async ({
                        ~~~~~~~~~~~~

This brings me to https://github.com/project-chip/matter.js/blob/main/packages/matter.js/src/cluster/server/ClusterServer.ts#L41 where an arg is in and the error "Types of parameters '__0' and 'args' are incompatible." could match to that ?!
So something is lost on the road ...
It seems to work in general for base clusters because we have sevewral such clusters workig including access, so my assumptions went the "Extend" direction that it comes from there.
For me it seems that after Extend the linked Type "CommandHandler" can not infer the types of the command and so ends in the "never" case ... becuse it works with empty method.

PS: One assumption goes a bit into the deviciioon of  Attriutes, Commands and such as
export interface Attributes {
    [key: string]: Attribute<any, any>
}

But the extend method is just adding types.
In other places we use Merge type function that respects the original structure ... maybe the reason is this?

On the other hand it also starts to happen diretcly with ... so maybe we already loose soemthing when "converting" BaseClusterComponent into Cluster
it("creates clusterserver with no just base and handlers", () => {
            const ext = createCluster({ extended: false, fancy: false, absolutelyFabulous: false });
            const cluster = ClusterServer(
                ext,
                {
                    attr1: 1,
                },
                {
                    cmd1: ({ attributes: { attr1 }, session, endpoint}) => {
                        if (attr1 == undefined || session === undefined || endpoint === undefined) throw new Error("Missing attribute");
                        return { cmdRet1: 5 };
                    },

                    getAttr1: ({ attributes: { attr1 }, session, endpoint}) => {
                        if (attr1 == undefined || session === undefined || endpoint === undefined) throw new Error("Missing attribute");
                        return 5;
                    }
                },
                {
                    ev1: true,
                }
            );
        })

Turns out this wasn't a bug per se but there was a typing issue that made diagnosis difficult.  Fixed w/ PR #238


Refactor tests for improved reporting, part 2

Signed-off-by: Kevin Earls<EMAIL_ADDRESS>

@objectiser @pavolloffay @jpkrohling please review


add a test suite

here's some tests for #7.
i couldn't test RegisterHtmlTemplate.register (there are two branches to test in there) because jsdom's importNode apparently can't be mocked/spied upon.
also if the inline templates and expectations are nasty, i could throw them all into separate files maybe?
a couple of tests also probably do overlap too due to each internal method always running.
p.s. I used jest because it was already in there...

FYI tests fail in CI because of path separators! will probably fix tomorrow, maybe have to use the system's separator in my expected strings :/

@michael-ciniawsky this is updated now to remove the package alteration and fix the path separator issues in tests.
don't suppose you happen to know how we can get coverage working? i guess because the source is transpiled (babel), the coverage check doesn't quite work...

@43081j I think the tests should just be in a test folder. See https://github.com/webpack-contrib/css-loader for an example.

@ChadKillingsworth this seems to be because some loaders are using a combo of mocha/should, whereas some are using jest (and its own assertion methods).
Here we're using the default jest directory for tests (a nasty looking __tests__), whereas mocha's default is test.
This also why the package.json line i reverted confused me, as it was ignoring src/**/*.test.js which won't ever exist in this repo.

I'll ask about this ...

Also jest was lying around in our package deps already, so I used that. I actually began installing mocha before realising that, as i haven't used jest before.
I can rewrite them in mocha and use chai or should if you'd prefer that.

the tests have been moved to test/ now.
it seems jest looks in __test__ and for *.test.js.

and finally i've moved to snapshots rather than those questionably-looking inlined expected strings.


[+XWATCH√Trending!] Full One Girl One Frog Viral Leaked Video 2024 Link On Social Media X Twitter [FULL07R]

07 sec ago Full One Girl One Frog Leaked Video Viral On Social Media. [+XWATCH√Trending!] Full One Girl One Frog Viral Leaked Video 2024 Link On Social Media X Twitter [FULL07R]

Full One Girl One Frog latest video has taken the internet by storm, sparking widespread discussions across various social media platforms. The rising digital creator, known for her engaging content—particularly her latest Spiderman-themed clip—has experienced a remarkable surge in popularity, with fans eagerly searching for the full version. Viewers are flocking to platforms like Instagram, X (formerly Twitter), and Discord to engage with her latest work.
As the excitement continues to grow, fans are actively sharing their reactions online, highlighting the crucial role that social media plays in boosting creators like Full One Girl One Frog. With her unique style and creative approach, she has quickly made a significant mark in the digital space, leaving many curious about her future projects. The viral success of her video underscores the powerful influence of social media in enhancing visibility and fostering direct relationships between creators and their audiences.
...
....
....
...
...
...
....
....
...
...
....
...
...
....
....
...
...
....
...
...
....
....
...
...
....
...
...
....
....
...
...
....
...
...
....
....
...
...
....
...
....
...

thank you

Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link
Watch 🟢 ➤ ➤ ➤ 🌐 Click Here To link (Full Viral Video Link
🔴 ➤►DOWNLOAD👉👉 (Full Viral Video Link)


Auto-update mipmaps for render targets

Hi, I was trying to use mipmapped images with render targets & noticed that mipmaps aren't generated for those. I was able to make it work by adding this snippet:
if (img->cmn.render_target && (img->cmn.num_mipmaps > 1)) {
  glGenerateMipmap(GL_TEXTURE_2D);
}

to _sg_gl_create_image (right after the for (int slot = 0; slot < img->cmn.num_slots; slot++) { loop) and _sg_gl_apply_bindings (right after _sg_gl_cache_bind_texture).
I verified it works on macOS (SOKOL_GLCORE33) and webgl (SOKOL_GLES3, chrome, firefox, safari and MS edge). Would be cool if this could be supported, it's a cheap way to downsample render targets.

IME glGenerateMipmaps() is one of those GL functions which can cause trouble in poorly implemented GL drivers (e.g. on mobile), but maybe this has improved. Just something to keep in mind (for instance currently there is this unfixed crash on macOS Catalina: https://twitter.com/Akien/status/1459120447228989440)
IFIR there are a number of similar requests though... I think the consensus was that the best solution would be to add a boolean flag to sg_image_desc, and that glGenerateMipmaps (or the equivalent for D3D11 and Metal) would be called "when needed" (e.g. for render targets at the end of their render pass, and for immutable textures once during creation).
I'll work on smaller things next, and this would be a good candidate.


why !isnothing(basisfunction) here?

I dont get why one checks for !isnothing(basisfunction) => a basisfunction exists, but at the same time type <: UnfoldLinearMixedModel
=> this case shouldnt even exist - a UnfoldLinearMixedModel never has a basisfunction, and a UnfoldLinearMixedModelContinuousTime always has one. So whcih is it?
https://github.com/unfoldtoolbox/Unfold.jl/blob/61e6d4e87811910cfb517dfb4142229d337d565f/src/designmatrix.jl#L232

a) the following line of code is never reached and can be removed
b) UnfoldLinearMixedModelContinuousTime doesnt currently work (but there are tests)


Added spanish (es_es) localization file

Added spanish (Spain) localization

@naulacambra @JavierOrellanaR I'm adding multilingual support to dayspan so everything will be localized. Here's a document you could fill out when you have time!
https://docs.google.com/document/d/1OIntOhA8LdEdZ2S9nn1zlqHBWqySQvkWUZnkuvRPDXs/edit?usp=sharing


Make it easy to use usethis

Most R users are going to want to import this action with usethis.
This follows the pattern set up in https://github.com/r-lib/actions to get users quickly started with their action.

Closes #20


A docs update with production guide + restructured advanced guide

Describe changes
Creating this branch early to get visibility and early reviews if neccessary. Here are the changes I have planned:

[x] Restructured the advanced guide into new sections

[x] Environment management is now split up into  infrastructure management and  configuring ZenML
[x] Use the hub is now in Pipeline feature
[x] Use the client is now in references  and is called Python Client

[x] The production guide  section is now developed:

[x] Starts off with a basic deploying zenml page
[x] Goes on to building an understanding of stacks
[x] Goes to a step by step guide on connecting remote storage
[x] Goes to connecting a container registry and skypilot orchestrator
[x] Goes to the basics of configuring a pipeline
[x] Talks about the code repository and how to connect it
[x] Ends with a end to end project that points to the e2e template

[x] Deploying ZenML now has a dedicated section on explaining the concepts behind ZenML server. This used to be Understanding stacks before. This complements this new page in advanced guide that talks about how to connect to a deployed zenml + the usage of service accounts
[x] Need to rework the Stack Deployment section and make it more up to date -> Moved minimal GCP stack to the advanced guide infrastructure management section
[x] Reworking the settings mega docs
[x] Adding a new managing steps refactored from old configure-steps-pipelines
[x] Adding a new settings page refactored from old configure-steps-pipelines
[ ] Maybe add gitflow somewhere?

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@bcdurak @strickvl This is now 99% there (except on TODO in the PR description)... Please go over it. IF you see grammar or spelling mistakes please correct at will. Thank you!


Full runtime fixes

I did a partial merge by cherry-picking commits that had changes not already made on the compiler branch and added one commit with your #![deny(warnings)] change with you as author. I'd start a new branch from compiler and cherry pick any local changes/commits you have on to that branch for any subsequent PRs against #554


Update zap and image version blocking pull/17848

Problem
What is being fixed?  Examples:

New zap CI is failing because image is out of sync with the submodule.

This will be our signal to update the images moving forward

Change overview

Update zap docker commit and update images version
Once the new image is out I will update pull/17848 to use it; may create a helper script to increase version in build files if there isn't one already.

I just noticed pull/17856; it may be wise to block on that.


Chore: reset script

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Workflow improvement

What is the new behavior (if this is a feature change)?
By running yarn reset, all of the installed modules, dependencies and build-artifacts are removed.
This is useful if you (the developer) gets a very strange install/build error.

Other information:

Status

[ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report

Merging #586 (296f8ee) into release37 (1555b09) will increase coverage by 32.85%.
The diff coverage is 100.00%.

:exclamation: Current head 296f8ee differs from pull request most recent head 4d8fc2b. Consider uploading reports for the commit 4d8fc2b to get more accurate results

@@               Coverage Diff               @@
##           release37      #586       +/-   ##
===============================================
+ Coverage      67.14%   100.00%   +32.85%
===============================================
  Files            262         2      -260
  Lines          17951        49    -17902
  Branches        3843        17     -3826
===============================================
- Hits           12054        49    -12005
+ Misses          5856         0     -5856
+ Partials          41         0       -41

Impacted Files
Coverage Δ

packages/blueprints-integration/src/context.ts
100.00% <100.00%> (ø)

meteor/lib/api/user.ts

meteor/lib/api/playout.ts

meteor/server/api/ingest/cache.ts

meteor/server/migration/1_3_0.ts

meteor/server/security/rundownPlaylist.ts

meteor/server/migration/0_26_0.ts

meteor/server/api/ingest/mosDevice/diff.ts

meteor/server/api/profiler.ts

meteor/server/migration/1_12_0.ts

... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1555b09...4d8fc2b. Read the comment docs.


Wrong "monospace" font fallback for CJK characters in raw block

Description
The following text are rendered wrongly on most Windows. This is because typst usually makes font fallback to "LiSu", an ancient chinese font, or even fails to fallback to any font.
运行结果：

```
请输入一个整数：16
该整数的平方根为： 4.0
```

Though Chinese users already have to style their documents with a template overriding many default settings, I believe it deserves to make our settings more sensible. I suggest to extend this fallback list for different systems:
https://github.com/typst/typst/blob/9f69709a2a554c3a1555b3069ec878ceac62993f/crates/typst/src/text/raw.rs#L434

#show raw: set text(font: (
  "DejaVu Sans Mono",
  "Microsoft YaHei", // for Windows users
  "PingFang SC", // for macOS users
  "...", // for Linux users
))

Reproduction URL
No response
Operating system
Windows 11
Typst version

[x] I am using the latest version of Typst

Reference: https://www.tug.org/texlive//Contents/live/texmf-dist/tex/latex/ctex/fontset/

It's not wise to hard encode fallback font list. It's better to detect the fallback list according to system interfaces. On MacOS this can be achieved using CTFontCopyDefaultCascadeListForLanguages, and on Linux we can use fontconfig.


Fixing locking issue

Already merged in master, but we need it in v1.0.0
Related Github tickets

https://github.com/VolumeFi/paloma/issues/193

Background
Pigeon is getting stuck in a lock state because there's a path that on error doesn't unlock.  Now, the locks are closer and don't allow for paths that escape unlocking unless there's a panic

Tighten the space between locking and unlocking
Don't bother locking for messages that just query.  These won't affect ordering

Testing completed

[x] Tested this on birdlady in the public testnet

I'm not sure why tests aren't kicking off, but the tests have already run against main.  I'm going to bypass and merge this PR.


Atmel pin 24 is named A0/15 which is not good

That pin should be A1/15 I think ?
Very useful drawing, I have it laminated below the keyboard :-)
Regards,
Ben

Pin 24 - ( A0/15 ) should be ( A1/15 ) as zanco previously noted.
Excellent drawing of course!

Pin 24 - ( A0/15 ) should be ( A1/15 ) as zanco previously noted.
Excellent drawing of course!


chore: bdd-spring-1578099504 to 0.0.1

chore: Promote bdd-spring-1578099504 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Compile time key checking

Rustc has built-in support for compile-time index checking for statically sized arrays.
The following example doesn't compile, and prints an error that 2 is an out-of-bounds index for MAP.  It seems in principle that this would be possible to do with static PHF maps as well.
#![feature(proc_macro_hygiene)]

use phf::{ phf_map };

static ARR: [i32; 3] = [1, 2];
static MAP: phf::Map<&'static str, i32> = phf_map! {
    "one" => 1,
    "two" => 2,
};

fn main() {
    println!("arr[0] = {}", ARR[2]);
    println!("MAP[\"one\"] = {}", MAP["three"]);
}

There is no way to do that in the language.

I suspect it may be somehow possible, but probably require a complete redesign of PHF, and definitely requires proc_macro (probably requires using a macro instead of the subscript operator).  Of course, I'm not all that experienced in Rust macro programming.

I'll close this for now


strictNullCheck: flow analysis doesn't mix well inside lambdas

TypeScript Version: 2.0.3 compiled with the flag strictNullCheck to true
Code
class Fruit { color: Color | null; }
class Color { name: string; }

function filterNotCompiling(colors: Color[], fruit: Fruit | null) {
    if (fruit && fruit.color) {
        return colors.filter(color => color.name === fruit.color.name);
        //                                                   ^ Object is possibly 'null'
        //                                                   fruit.color detected as 'Color | null'
    }
}

function filterCompiling(colors: Color[], fruit: Fruit | null) {
    if (fruit && fruit.color) {
        const colorPredicate = fruit.color;
        return colors.filter(color => color.name === colorPredicate.name);
    }
}

Expected behavior:
After the guard if (fruit && fruit.color), the type of fruit.color should be Color.
Both function should compile fine.
Actual behavior:
After the guard if (fruit && fruit.color), the type of fruit.color is Color | null.
The function filterNotCompiling doesn't compile
Edit: after some more migration of code, the problem appears in all code embedded in a lambda, this happens especially in my project for code inside a Promise.then(). I guess this issue is certainly a duplicate but I can't find one issue approaching this problem.

This is working as intended. In this function
function filterNotCompiling(colors: Color[], fruit: Fruit | null) {
    if (fruit && fruit.color) {
        return colors.filter(color => color.name === fruit.color.name);
    }
}

we do indeed detect that there are no assignments to fruit anywhere and we therefore consider the first truthy check (fruit) to be in effect in the lambda. For example, this works:
function filterNotCompiling(colors: Color[], fruit: Fruit | null) {
    if (fruit) {
        return colors.filter(color => fruit.color && color.name === fruit.color.name);
    }
}

However, in the original example we can't safely assume that the second truthy check (fruit.color) is in effect in the lambda since properties can be freely mutated in a number of different ways. The only way to do that is to use a const intermediary, as in the filterCompiling function in the OP.
@mhegazy Did you have something else in mind when you marked this as a bug?

Thank you @ahejlsberg , I've make an example to illustrate why the type cannot be infer to not undefined in this example, which uses a lambda into an asynchornous call.
The design of this feature is much more clear now.
class foo {
    bar?: string;

    makeSomeNoiseUnsafe(promise: ng.IPromise<any>) {
        if (this.bar) {
            // can't infer this.bar is defined, it could have be changed
            promise.then(_ => console.log(this.bar.length));
        }
    }

    makeSomeNoiseSafe(promise: ng.IPromise<any>) {
        if (this.bar) {
            // save the current state
            const bar = this.bar;
            // work with the saved state
            promise.then(_ => console.log(bar.length));
        }
    }
}

What tricks me is that .filter() is a synchronous call, but that's ok, I understand that the compiler has no way to distinguish between synchronous/asynchronous call.


(Global) logger prematurely disposed when ILogger is resolved directly from a child lifetime scope

I think this still happens if you use RegisterLogger(builder, logger, dispose: true). I think that the issue is that LoggerProvider is registered per-dependency instead of singleton:
builder.Register(c =>
                {
                    LoggerProvider provider = new LoggerProvider(_logger);
                    return provider;
                })
                    .AsSelf()
                    .AutoActivate()
                    .OnRelease(c => c.Release());

(https://github.com/nblumhardt/autofac-serilog-integration/blob/dev/src/AutofacSerilogIntegration/ContextualLoggingModule.cs#L44)

Thanks @srogovtsev - I think you're right 👍

I think I can take this, but there's one thing I'd like to understand: is there any reason you don't want LoggerProvider to be single-instance?
(actually, this mirrors the Microsoft.Extensions.Logging integration, where it is single-instance)

I think single-instance would be correct, here (though it's been a while since I've worked in this codebase...). Thanks for the offer of help! :+1:


Update the pytest instructions

I've pushed a new version. @ktlim do you want to sign off on this version?


Relax limit on calling methods on unbound modules

Inspired by #636, relax the limitation on calling methods on unbound modules.
While at time users may be confused about when setup is run, hopefully
the new docstring we have on setup clarifies things. If users want
to write a method that doesn't depend on any attributes defined during
setup (e.g. submodules or variables), that should be fine.

Codecov Report

Merging #653 (77f3ab7) into master (fbd3aec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   80.59%   80.61%   +0.02%
==========================================
  Files          56       56
  Lines        4241     4241
==========================================
+ Hits         3418     3419       +1
+ Misses        823      822       -1

Impacted Files
Coverage Δ

flax/linen/module.py
95.25% <100.00%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd3aec...77f3ab7. Read the comment docs.


Halve the period of time until an issue is considered stale

Description
I propose halving the time required to flag and close an issue due to inactivity. The new time period would be 90 days (~3 months), at which point the bot will flag an issue as stale. This starts the second timer, where if the issue sees no further activity within 30 days, it will be closed by the bot.
Extra: Do not automatically mark as stale issues labeled as regressions or "Help Wanted"
Why?
Currently, an issue must see no activity for 180 days (~six months), at which point it is labeled stale. It will then take a further 60 days of inactivity before the issue is closed.
Take for example issue 9773. It was opened in September 2016, and closed for inactivity in November 2016. It was then resurrected February 2018. Three months later, no activity has occurred. This is, in my opinion, too lenient and the issue should be closed.
History
Last year, we reached a point where the repo has over 1,500 open issues. After finding some of these issues had no activity for over a year, I enabled a Stale bot on the repository which took care of closing any issue that saw no activity over a two week period. This helped us get to 200 open issues after some time.
After hearing feedback from the community that the bot was too aggressive on new issues, and considering that 200 open issues on such a broad project as React Native is not too high of a number, I dialed down the Stale bot so that it would take up to ~8 months to close a stale issue. In hindsight, I believe this was too big of an over-correction on my part. With open issues now topping 600, I think it's about time the Stale bot starts closing inactive issues again.
Closing inactive issues help us focus on what matters
My view is that closing an issue does not indicate the issue is invalid. Closing an issue for inactivity is a sign that the issue is not problematic enough to inspire a member of the community to followup and/or propose a fix through a PR. Closing stale issues as soon as possible should help maintainers surface active issues with the greatest impact on users of the library.
Test Plan
None, configuration change.
Release Notes
[INTERNAL] [MINOR] [stale.yml] - Update Stale bot to halve stale closing times.

Locking stale issues is now in place.


interaction of SET GRID and dynamic grids

Reported by ansley b manke on 11 Jun 2012 18:43 UTC
Patrick Brockmann reports this bug. It goes back to at least Ferret v5.81.  The script defines a regridded variable, "uwnd2", plots it using a map projection, and then uses mp_land_detail.jnl to draw the continent outlines on the plot. This far, everything works correctly.
Now repeat the script again. The script hangs at the point of finding the grid of the regridded uwnd2. If we plot the file variable unwd, instead of uwnd2 then all is well.
I have simplified mp_land_detail.jnl so that it doesn't issue its own "SET GRID" commands, and so it doesn't have complex IF THEN ELSE variable definitions. This makes the scripts work correctly together, but certainly  there is a bug somewhere in the use of dynamic grids and "set grid".
I'll attach a tar file containing Patrick's example scripts and the previous version of mp_land_detail.jnl.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1946

Attachment from ansley.b.manke on 11 Jun 2012 18:44 UTC
scripts to demonstrate the bug.
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_1946_GIT_1218/ticket1946.tar


backboardd crash

backboardd keeps crashing on my iPhone 6 on 10.2. While my phone is locked, the display turns on, all my notifications disappear, and CrashReporter says "backboardd has crashed". Is this related to the unstable jb in general or to a tweak I have installed? Pastebin: http://pastebin.com/JDuyeFnd

The Jailbreak itself doesn't cause this issue (I don't have this crash) So better ask on /r/jailbreak and update MakeRespringsGreatAgain, RespringProgress and SpringChanger.
For me only dataaccessd crashes after JB sometimes.


Drop Python < 3.6

Drop py27/py35
Begin shifting to pytest
Shift to testing tox externally, rather than in-process
This will impact the coverage % in a decently significant way, as the
calls into the actual hooks will be done in a separate process. I don't
know if it is possible to grab that info with coverage, but I don't know
a simple way.

This is preparation both for the move to including mypy and to ease the process of adding tests for when we tackle #13

Codecov Report

Merging #15 into master will decrease coverage by 19.45%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
- Coverage   95.51%   76.05%   -19.46%
===========================================
  Files          18       18
  Lines         401      401
===========================================
- Hits          383      305       -78
- Misses         18       96       +78

Impacted Files
Coverage Δ

src/tox_ansible/hooks.py
0.00% <0.00%> (-91.18%)
:arrow_down:

src/tox_ansible/tox_helper.py
33.33% <0.00%> (-60.01%)
:arrow_down:

src/tox_ansible/options.py
86.36% <0.00%> (-13.64%)
:arrow_down:

src/tox_ansible/tox_lint_case.py
87.09% <0.00%> (-12.91%)
:arrow_down:

src/tox_ansible/tox_test_case.py
94.28% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbea0ff...edcb9fe. Read the comment docs.

@greg-hellings Nice! Btw, if you can remove the comment from codecov it would be great. We should have no PR comments from bots, that is why we have checks that can fail.

@greg-hellings Nice! Btw, if you can remove the comment from codecov it would be great. We should have no PR comments from bots, that is why we have checks that can fail.

I can remove the comment, but I don't see a way to disable the bot from posting it again in the future. That might be an organization level thing you would need to take care of?


d3-3.x api-reference links to d3 v4 example

The Image on https://github.com/d3/d3-3.x-api-reference/blob/master/Force-Layout.md links to http://bl.ocks.org/mbostock/4062045 which uses d3 v4.
PS: Issue concerns the v3 api docs so I opened the issue here (I am aware of https://github.com/d3/d3/issues/2994#issuecomment-255180780)

The examples are not versioned, so this will necessarily be the case as I update the examples to v4. You can find the old v3 examples if you dig through the history on gist.github.com, but I will not be explicitly fixing the links in the v3 archive to point to old versions.


GA: Free/Pro and Enterprise users can add a single repo to Cody's chat context

done via enhanced context selector


Folder structure still seen

Resolved in https://github.com/microsoft/sqltoolsservice/pull/1056/files


When choosing a provider, does the plugin check for internet access on the wifi or just connection?

Just wondering if the plugin checks for an active internet connection on the wifi or just a connection when choosing a provider to grab the user's location. This problem came about from using the plugin on a phone in a car that has built in wifi but no internet access.
If the plugin doesn't check is there is a way to force the geolocator to only use GPS and ignore the phone network data/WiFi. I've seen the closed post issue 230, but didn't fully understand if that was asking the same question. Thanks in advance.

The plugin itself just interfaces with Apple's and Google's location API and does not check for an Internet. I'm not sure about Android, but on Apple devices, the system decides under the hood which location technology it will use (GPS, WiFi, cel tower triangulation, etc.) There is no outward facing API that allows input into which location technology to use.


Migrate custom-import-map build script to plugin component path

Signed-off-by: Junqiu Lei<EMAIL_ADDRESS>Description
Migrate custom-import-map build script to plugin component path from OpenSearch-build scripts/components/customImportMapDashboards/build.sh. The build script have less two ../ since moved plugin since we changed the plugin to repo root path.
Note
Need to hold this PR to be merged after 2.4.1 release out
Issues Resolved
https://github.com/opensearch-project/dashboards-maps/issues/83
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Since 2.4.1 release sent out, merging this PR to main, and will also make same update to 2.x, 2.2, 2.3, 2.4 branches


When geopandas is available, pyogrio expects pyproj to be available

Since geopandas 1.0, geopandas-base doesn't imply anomore that pyproj will be installed as well.
But, pyogrio now expects it to be.
Noticed in #452.

Good point, we should update our importing of pyproj and provide a better error message if it is not available.

Although https://github.com/geopandas/pyogrio/pull/452 already updates the one place where we import pyproj?

Yes, after making this issue I noticed it was easy to just remove the import...

Back to the drawing board... I added pyproj previously to the environment file to focus the test on the switch to libgdal-core and hadn't removed it yet. Now I removed it again in #452 quite some tests are failing because pyproj not being available leads to different behaviour in geopandas...

When we allowed geopandas without pyproj, we had to change quite a lot of tests as the expected value for CRS changes to None.
If we want to properly do it here, we might need to follow the same model.
We should allow pyogrio without pyproj to support this model in geopandas so I wouldn't add it necessarily as a conda dependency.

The tests that failed when pyproj was not available anymore in #452 pass again...


Register BlockDelimiters offense with attribute assignment

Update Style/BlockDelimiters to handle attribute assignment.
Fixes #7305 by recognizing that blocks as arguments of assignment methods can safely be mutated from one block delimiter style to the other.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

(I'm working on the checkboxes.)

All done. Ready for review.

Thanks!


Example

Thanks for your hard work creating this module. Would it be possible to create a working example for us newbies?

It would be really helpful if a working example is attached or referred.


tighten rent account regex

The current regex for detecting rent accounts for auto resolving is a bit loose. It would be nice to be able to create accounts with rent in the name without auto resolving as the system program. Example: rentPayer. This PR tightens it up a bit.

Oh! TIL that /^rent|rentSysvar|sysvarRent$/ is interpreted as /^rent/ OR /rentSysvar/ OR /sysvarRent$/ instead of the desired /^(rent|rentSysvar|sysvarRent)$/.
I'll create a new PR that changes all of them because that's definitely a bug. Thanks for raising this.


Add a method to easily get your devices path

something like:
Automaton.active_device()

Automaton will later try to use all devices at once, so there is no need for this method


Initial redirect appears wrong.

So using the default .env or even editing the DOCKER_FRIEND_DOMAIN variable, accessing the container on port 6502 will always cause a redirect to
http://localhost/webclient/index.html
this of course is wrong because no port is included. The redirect should be to
http://$domain:6502/webclient/index.html
It is curious also that he above variable  is not being passed through either.

You need to include the port with the environment variable when you plan connecting to the port directly. Otherwise you use a apache reverse proxy or a nginx reverse proxy to access FriendUP.

Closed due to no reply within 3 days


HADOOP-19291. RawLocalFileSystem to allow overlapping ranges

ChecksumFileSystem creates the chunked ranges based on the checksum chunk size and then calls readVectored on Raw Local which may lead to overlapping ranges in some cases.

Description of PR
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 37s

trunk passed

+1 :green_heart:
compile
20m 37s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
19m 57s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 47s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
2m 41s

trunk passed

+1 :green_heart:
shadedclient
42m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
20m  9s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
20m  9s

the patch passed

+1 :green_heart:
compile
20m  6s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
20m  6s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 14s

the patch passed

+1 :green_heart:
mvnsite
1m 43s

the patch passed

+1 :green_heart:
javadoc
1m 14s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
2m 49s

the patch passed

+1 :green_heart:
shadedclient
42m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 14s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

272m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7101

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint xmllint

uname
Linux d61c8cfa2b09 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dacf85d14fa341f9cdb1116352743d0f8ed3f69f

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/1/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cc @dongjoon-hyun

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 58s

trunk passed

+1 :green_heart:
compile
21m  2s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
19m 45s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 46s

trunk passed

+1 :green_heart:
javadoc
1m 19s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
2m 42s

trunk passed

+1 :green_heart:
shadedclient
41m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
20m 10s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
20m 10s

the patch passed

+1 :green_heart:
compile
19m 52s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
19m 52s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 16s

the patch passed

+1 :green_heart:
mvnsite
1m 45s

the patch passed

+1 :green_heart:
javadoc
1m 12s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
2m 50s

the patch passed

+1 :green_heart:
shadedclient
42m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 21s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

255m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7101

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint xmllint

uname
Linux 770cb0a1c896 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f6c7bda1de5bb326fff0c9dc0185114c90c459c0

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/2/testReport/

Max. process+thread count
1263 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7101/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Design Menu Structures and UI System

Design the Menu Structure and the general UI paradigm and approach. Mockups also should be included.

Fonts suggestion :

Gentium Plus (SIL Open Font License). Useful to have a lot of differents characters. Also used by Lexicanter

Noto Sans (SIL Open Font License). Clear, easy to read.

Both look good, we can use Noto Sans for the application text, and Gentium for the content


How to debug into bform js when delete one row data?

I am not good at front-end, but I want to study further into bforms.*.js.I did not use amd module js before,at that time ,I used to browser F12 dev tool , and make a breaking point.Actually, I can not find the entrance for debug js in BForms,when I want to know how the delete action work.I am very sorry to pose this personal question,but I really want your help.Thanks.

Maybe Console.Log is the best method for this problem.


Added local api configuration

PR for Project.clj.
PR Status
READY
Changes proposed in the pull request:

Add run-local alias
Rename local-dev to run-dev

Breaking changes?

Yes, alias has changed to run the app.

@emilyseibert @oconn @dehli

I'm gonna go ahead and merge this all the way up to master to see if it fixes the netlify issue.


SelectableText not compatibility flutter for web

I build GitHub Pages and Mobile App using the flutter for web，but I've found SelectableText Widget not compatibility web.

import 'package:bga_issue_blog/page/blog_detail_page.dart';
import 'package:bga_issue_blog/utils/route_util.dart';
import 'package:flutter/material.dart';

class IssueItem extends StatelessWidget {
  const IssueItem({Key key, this.issue}) : super(key: key);

  final issue;

  @override
  Widget build(BuildContext context) {
    return Container(
      child: ListTile(
        title: GestureDetector(
          child: SelectableText(issue['title']),
          onTap: () => RouteUtil.routeWithFadeTransition(context, BlogDetailPage(number: issue['number'])),
        ),
        trailing: SelectableText(DateTime.tryParse(issue['created_at']).toString().substring(0, "yyyy-MM-dd HH:mm".length)),
      ),
      decoration: BoxDecoration(
        border: Border(bottom: BorderSide(color: Color.fromARGB(255, 238, 238, 238))),
      ),
    );
  }
}

Does not behave properly in the browser

It works fine on the phone

Source Code
PreView

@bingoogolapple Thank you for the report and example. I'm going to close the issue in favour of #40663 to avoid duplication. Please follow it there and upvote.


[Settings] Implement Dialog for folder selection

Implements #26

This will stay open for a while, moved the issue to the next milestone.


[Feature Request] Show what cards of the deck are you missing in your collection

A lot of times i watch a deck and i wonder what cards of it i have and what i dont. it would be cool to have a filter to show only the cards currently in the deck and all their versions

The X Button in the Deck view Shows the missing Cards, but it is broken in the current Update.

ok. Nice to know that its going to come in the future

Should work since quite a while ago, I just forgot to close the thread.


Unable to run example directly from terminal, works from IDE (RustRover)

I'm a newbie to Rust, so I probably did something stupid and should have done differently.
I have cloned the project and wanted to run:
/Users/kino/.cargo/bin/cargo run --color=always --package tray-icon --example tao

If I run this through IDE (RustRover), I'm able to run it properly, and the tray icon shows as expected.
When I do the same from the terminal, I receive bus error. I was able to track down that the problem is https://github.com/tauri-apps/tray-icon/blob/67b873b1e03be371a629fed870e0ab54e0cb2f56/examples/tao.rs#L48 .  It does not matter what example I try to run. The bus error is always received when the try icon itself tries to build.
/Users/kino/.cargo/bin/cargo run --color=always --package tray-icon --example tao
    Finished dev [unoptimized + debuginfo] target(s) in 0.14s
     Running `target/debug/examples/tao`
[1]    34852 bus error  /Users/kino/.cargo/bin/cargo run --color=always --package tray-icon --example

./target/debug/examples/tao
[1]    35415 bus error  ./target/debug/examples/tao

Cargo/rust is installed with rustup
cargo --version
cargo 1.77.2 (e52e36006 2024-03-26)

rustc --version
rustc 1.77.2 (25ef9e3d8 2024-04-09)

rustup --version
rustup 1.27.0 (2024-03-08)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.77.2 (25ef9e3d8 2024-04-09)`

edit: I'm using MacOS 14.4.1 with M1 cpu aarch64-apple-darwin toolchain default

Are you using mac's default terminal? It works completely fine for me on the default terminal on macos 14.4.1 but with M2 pro 🤔

I was able to track it down...
I had
export DYLD_LIBRARY_PATH=/opt/homebrew/lib

in my .zshrc, because of the different tools I'm using. When I removed this, all started to work.


Can't mount a host directory if the container directory exists and contains a file

When using Windows containers, you can mount a host directory and overlay an existing container directory.
An error occurs when trying to start the container:

docker: Error response from daemon: container db565702e017c2680415b7cd5681a3467d8bd3c769ce7f4499de9f429927ad45 encountered an error during Start: failure in a Windows system call: The connection with the Virtual Machine hosting the container was closed. (0xc037010a).

Information
λ docker version
Client:
Version:      1.12.3
API version:  1.24
Go version:   go1.6.3
Git commit:   6b644ec
Built:        Thu Oct 27 00:09:21 2016
OS/Arch:      windows/amd64
Experimental: true
Server:
Version:      1.12.2-cs2-ws-beta
API version:  1.25
Go version:   go1.7.1
Git commit:   050b611
Built:        Tue Oct 11 02:35:40 2016
OS/Arch:      windows/amd64
Steps to reproduce the behavior
Example Dockerfile:
FROM microsoft/nanoserver

WORKDIR c:/temp
COPY a.file c:/temp/a.file

Build and then run:
docker run -v c:/temp:c:/temp foo-image cmd

docker: Error response from daemon: container 3952c075b90fb85ff79b9616626e3b7b8acc1056a33b7e7546ffa801a094976c encountered an error during Start: failure in a Windows system call: The connection with the Virtual Machine hosting the container was closed. (0xc037010a).

Linux containers allow mounting under this scenario. The host directory would overlay the container directory, but would not remove the pre-existing content.
Interestingly, it's fine if there is no file in the existing container directory, e.g.:
FROM microsoft/nanoserver

WORKDIR c:/temp

docker run -v c:/temp:c:/temp foo-image cmd

Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.

C:\temp>

I am having the same issue on this version:

Same here.

Unfortunately this is a limitation of the platform (Windows); a note has been added to the documentation; https://github.com/docker/docker/pull/28778, but there's nothing we can do in Docker's source code to fix this  https://github.com/docker/docker/pull/28778#discussion_r89413902, https://github.com/Microsoft/Virtualization-Documentation/issues/497#issuecomment-262636687
For that reason, I'm closing this issue


Tao + Wry KeyboardInputs don´t trigger the WindowEvent

Describe the bug
When using a webview with tao 0.28.1 and wry 0.41.0 (both latest) all done KeyboardInput-WindowEvents won´t get triggered. Still other events like on startup work as expected. The only KeyboardInput-Event that can be triggered is if the user has the Window hidden and presses TAB to focus -> as a result the keypress is registert.
Steps To Reproduce
The following code shows the behaviour:
use std::env;
use tao::{
    event::{Event, StartCause, WindowEvent},
    event_loop::{ControlFlow, EventLoop},
    window::WindowBuilder,
    dpi::{PhysicalPosition, PhysicalSize, Size, Position},
    keyboard::KeyCode,
};
use tao::event::{ElementState, KeyEvent};
use wry::{
    WebViewBuilder,
    raw_window_handle::HandleError,
};

struct Margin {
    top: u32,
    bottom: u32,
    left: u32,
    right: u32,
}

impl Margin {
    fn new(top: u32, bottom: u32, left: u32, right: u32) -> Self {
        Margin {top, bottom, left, right}
    }
}

fn main() -> wry::Result<()> {
    let args: Vec<String> = env::args().collect();
    let url = match args.get(1) {
        Some(arg) => arg.clone(),
        None => "https://google.com/".to_string(),
    };

    let event_loop = EventLoop::new();

    let margin = Margin::new(16, 80, 16, 16);
    let monitor_size = event_loop.primary_monitor().ok_or(wry::Error::WindowHandleError(HandleError::Unavailable))?.size();
    let width = (monitor_size.width / 2) - margin.left - margin.right;
    let height = monitor_size.height - margin.top - margin.bottom;
    let size = Size::Physical(PhysicalSize::new(width, height));
    let position = Position::Physical(PhysicalPosition::new(((monitor_size.width / 2) + margin.left) as i32, margin.top as i32));

    let window = WindowBuilder::new()
        .with_inner_size(size)
        .with_position(position)
        .with_title("Hello World")
        .build(&event_loop)
        .unwrap();

    let _webview = WebViewBuilder::new(&window)
        .with_url(url)
        .build()?;

    event_loop.run(move |event, _, control_flow| {
        *control_flow = ControlFlow::Wait;

        match event {
            Event::WindowEvent {event, ..} => match event {
                WindowEvent::CloseRequested => *control_flow = ControlFlow::Exit,
                WindowEvent::KeyboardInput {
                    event: KeyEvent {
                        physical_key: KeyCode::Space,
                        state: ElementState::Released,
                        ..
                    },
                    ..
                } => {
                    println!("KEYPRESS");
                }
                _ => {}
            }
            _ => (),
        }
    });
}

Expected behavior
All keyboard-inputs should be able to trigger the event.
Platform and Versions (please complete the following information):
OS: Windows 11 (Pro) 10.0.22635 Build 22635
Rustc: 1.78.0 (9b00956e5 2024-04-29)

This is because wry's webview will process the keyboard input and will not pass it to the tao window at all. You will either need to handle your keyboard input in JS code, or listen for device events.


Valid complex regex doesn't match valid commit message

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
I have a complex regex ^(fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+\)(, (fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+?\))+(:\ .*)$ that matches commit message doc(repo), setup(ci): improve PR naming section in CONTRIBUTING

But for some reason, commit parser { message = '^(fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+\)(, (fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+?\))+(:\ .*)$', group = "TEST", default_scope = "other"} doesn't match this commit message when using this regex.
Steps To Reproduce
Config
[changelog]
body = """
{% if version %}\
    # [{{ version | trim_start_matches(pat="v") }}] - {{ timestamp | date(format="%Y-%m-%d") }}\
{% else %}\
    # [unreleased]\
{% endif %}\
{% for group, commits in commits | group_by(attribute="group") %}\
    \n
    ## {{ group | upper_first }}\
    {% for group, commits in commits | group_by(attribute="scope") %}\
    	\n
        ### {{ group | upper_first }}\n\
        {% for commit in commits | unique(attribute="message") %}\
            \n- {{ commit.message | split(pat="\n") | first | trim }}\
              {% if commit.github.username %} by @{{ commit.github.username }}{% endif %}\
              {% if commit.github.pr_number %} in #{{ commit.github.pr_number }}{% endif %}\
    	{% endfor %}\
    {% endfor %}\
{% endfor %}\
\n
## First-time contributors 🥳\n\
{% for contributor in github.contributors | filter(attribute="is_first_time", value=true) %}\
    \n- @{{ contributor.username }} made their first contribution in #{{ contributor.pr_number }}\
{% endfor %}\
"""

trim = true

[git]
conventional_commits = true
filter_unconventional = false
split_commits = false

commit_parsers = [
    { message = '^(fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+\)(, (fix|feat|setup|doc|refactor|test|optimization)\([A-Za-z0-9_-]+?\))+(:\ .*)$', group = "TEST", default_scope = "other"},
    { message = "^feat", group = "✨ Features" },
    { message = "^fix", group = "🪲 Bug Fixes" },
    { message = "^doc", group = "📚 Documentation" },
    { message = "^optimization", group = "🚀 Performance" },
    { message = "^refactor", group = "🧹 Refactor" },
    { message = "^setup", group = "⚙ Configuration" },
    { message = "^test", group = "✅ Testing" },
]

protect_breaking_commits = false
filter_commits = false
tag_pattern = "v[0-9].*"
skip_tags = ""
ignore_tags = ""
topo_order = false
sort_commits = "oldest"

Expected behavior
The commit message doc(repo), setup(ci): improve PR naming section in CONTRIBUTING is visible in TEST section in the Other group
Screenshots / Logs
No response
Software information

Operating system: Linux
Rust version: idk, I'm using Arch linux package https://archlinux.org/packages/extra/x86_64/git-cliff/
Project version: git-cliff 2.1.2

Additional context
No response

If I remove $ end match symbol from regex - it matches the commit message as expected 🤔 Is it related to the additional \n or spaces at the end of the commit message?

Hi, thanks for the response. It's actually the tough one.
I think the process should start from research why there is \n at the end of common commit message without body and without \n at the end. Maybe this is how GitHub sends it. If so, probably the tool should trim this kind of new line character.
If this is something that Git do for some reasons and the tool can't automatically remove new line character because of reasons or edgecases or complex implementation - it should definitely appear in the documentation so users be aware of it.

I decided to always trim it: #573
The commit message originally has a newline at the end because of git2 and I already trimmed that in #403
So doing this won't hurt I reckon :)


Fix: Issue 2721 : binary function should not panic but return error w…

…hen array lengths are unequal
Which issue does this PR close?

Closes #2721.
Rationale for this change

What changes are included in this PR?

The binary and binary_opt do not panic when the input arrays have unequal length.
Are there any user-facing changes?

Thanks for the contribution @aksharau! This looks great.
CI is failing due to an internal error in the Rust compiler :disappointed:
error: internal compiler error: no errors encountered even though `delay_span_bug` issued

Re-trigger the cargo doc as the failure has been fixed


Issue using MemGPT with AutoGen

When I try to run the sample code demonstrating how to use MemGPT with AutoGen, I get a runtime error:
"RuntimeError: asyncio.run() cannot be called from a running event loop".
I cannot seem to figure out what I am doing wrong.
Sample code: https://github.com/cpacker/MemGPT/discussions/65

Sorry if I am not smart.

See the new example introduced by #123, we did some refactoring that should have solved this.

@hframa which jupyter notebook are you referring to? We didn't publish any notebooks, just an example code snippet which is now also checked into the git repo here.
Or do you mean the example linked above works when you just run the python file, but fails when you try to take the code out into a Jupyter notebook? If that's the case, can you share the contents of the notebook eg via a google colab link so we can try to debug it?

Thank you, and sorry.
I think I messed up something on my part, which I cant seem to figure out.
Following is the link to the Jupyter Notebook: https://colab.research.google.com/drive/1boC1Ghsla8AISAy8nbgSWNZzX6xPLmgK?usp=sharing

can you open view access on the notebook?


IS-5.7 authentication EP's UI fields validation lacks emtpy input validations.

IS : 5.7.0
WUM :<PHONE_NUMBER>897
Issue :
Authentication endpoint's login window's UI input validation fails as below.

User name enter, Password not enter: validation working
Username not enter, Password enter: validation not working
Username not enter, Password does not enter: validation not working.

Expected :
Should check for empty inputs from the UI level rather than doing an authentication attempt.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Missing types-metadata.json

Some packages that have been updated recently are missing type-metadata.json. For example, @types/graphlib and @types/color. I believe this might have to do with the change in directory structure in DefinitelyTyped.
I am not sure if related, but the npm pages for these packages also seem off. For example, https://www.npmjs.com/package/@types/graphlib. On the left it says that the package was published 3 days ago, but the Details section says that the last update was January. Also the link to the exported files in DefinitelyTyped leads to a 403 (because of the lacking types directory in the URL).

We got rid of this in #306.
Other issue fixed by #324.


Full Xcode IDE needed for building?

This is more of a question rather than an issue. Sorry if this is obvious for experienced Mac devs.
Is it possible to compile the gather-cli executable with only the Command Line Tools installed? The Command Line Tools come with the swift and the swiftc command. In fact, I have successfully compiled very simple sample programs in Swift already. When I try to compile gather-cli though, using the instructions in the README, I get the following error:
xcrun: error: unable to find utility "xctest", not a developer tool or in PATH
Unfortunately I don't have enough space currently to install the full Xcode IDE.

I have the Xcode IDE installed (version 13.4.1) and am having the same issue.

OK, I was able to get it installed, but it did require the IDE.
$ xcode-select -p
/Library/Developer/CommandLineTools

sudo xcode-select -r
Password:
$ xcode-select -p
/Applications/Xcode.app/Contents/Developer

After this, installation worked.

I saw it, too: having just the Command Line Tools is not enough. I'd love to avoid installing XCode if possible.

gather-cli: A full installation of Xcode.app 10.0 is required to compile this software. Installing just the Command Line Tools is not sufficient.
Xcode can be installed from the App Store. Error: gather-cli: An unsatisfied requirement failed this build.

I might eventually figure out how to offer a Homebrew bottle, but in order to do so I need in compiled for every possible OS it will work on and I haven't figured out how to do that yet. So it's build-from-source only for now.
There's always the package installer if you can't handle installing Xcode for now...

You could also always try cloning the repository and running
swift build -c release
cp ./.build/apple/Products/Release/gather /usr/local/bin/

Not sure if it will work without xcrun swift build... but worth a shot. Then you can update just by pulling the latest git repo (which is updated with every release) and compiling your own.

There's a make file to make it as easy as make install, which will build and install in one step.

I have the full Xcode IDE installed but receive the following warning:

swift build -c release --disable-sandbox
warning: Failed creating default cache locations, Error Domain=NSCocoaErrorDomain Code=513 "You don’t have permission to save the file “org.swift.swiftpm” in the folder “Caches”." UserInfo={NSFilePath=/Users/pahles/Library/Caches/org.swift.swiftpm, NSUnderlyingError=0x7fd2674076c0 {Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"}}
warning: Failed creating default config locations, Error Domain=NSCocoaErrorDomain Code=513 "You don’t have permission to save the file “org.swift.swiftpm” in the folder “Library”." UserInfo={NSFilePath=/Users/pahles/Library/org.swift.swiftpm, NSUnderlyingError=0x7fd277421580 {Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"}}
warning: Failed creating default cache locations, Error Domain=NSCocoaErrorDomain Code=513 "You don’t have permission to save the file “org.swift.swiftpm” in the folder “Caches”." UserInfo={NSFilePath=/Users/pahles/Library/Caches/org.swift.swiftpm, NSUnderlyingError=0x7fd267607370 {Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"}}
/private/tmp/gather-cli-20220904-83199-enjbie: error: package at '/private/tmp/gather-cli-20220904-83199-enjbie' is using Swift tools version 5.6.0 but the installed version is 5.5.0
make: *** [build] Error 1

This is the same issue I encountered above. Turns out I needed to use xcode-select to point to the full IDE rather than the CLI tools. https://github.com/ttscoff/gather-cli/issues/2#issuecomment-1232307929

This is the same issue I encountered above. Turns out I needed to use xcode-select to point to the full IDE rather than the CLI tools. #2 (comment)

Which I did:
$ sudo xcode-select -p
/Applications/Xcode.app/Contents/Developer

Still get the error as mentioned in https://github.com/ttscoff/gather-cli/issues/2#issuecomment-1236278238, which is not the same error as you got.

Turns out, because I'm still on Big Sur, installing with homebrew will not work. According to Package.swift Swift 5.6 is needed. The most recent Xcode on Big Sur is 13.2.1, which ships with Swift 5.5.

Same issue as /u/pahles. I edited the Package.swift in Library/Caches/Homebrew/gather-cli--git to make the minimum swift usable as 5.5.0, ie swift-tools-version: 5.5.0.
But the code was too smart for me :)
/Users/languid/Library/Caches/Homebrew/gather-cli--git/.build/checkouts/swift-argument-parser/Sources/ArgumentParser/Parsable Types/AsyncParsableCommand.swift:23:23: error: concurrency is only available in macOS 12.0.0 or newer
  mutating func run() async throws

Ah well, looks like I do need to pull the trigger on that M1 Air is was looking (seems a better value than an M2, and I love the form factor) - my 2014 MBA has done some sterling service though.

There's a make file to make it as easy as make install, which will build and install in one step.

Not having enough space to add Xcode, I tried this, and sadly gives similar errors to others reporting it.
error: terminated(72): /usr/bin/xcrun --sdk macosx --find xctest output:
    xcrun: error: unable to find utility "xctest", not a developer tool or in PATH

Perhaps for now you could put a note on the main Gather page saying it needs full Xcode and that is a download of at least 12GB (according to macupdates.com). I don't know how much space it expands to after that.

There’s an 8 MB PKG download with recompiled binaries. See the release page.
Thanks,
Brett
On Sep 12, 2022, 2:41 AM -0500, Jonathan Clark @.***>, wrote:

There's a make file to make it as easy as make install, which will build and install in one step.
Not having enough space to add Xcode, I tried this, and sadly gives similar errors to others reporting it.
error: terminated(72): /usr/bin/xcrun --sdk macosx --find xctest output:
xcrun: error: unable to find utility "xctest", not a developer tool or in PATH
Perhaps for now you could put a note on the main Gather page saying it needs full Xcode and that is a download of at least 12GB (according to macupdates.com). I don't know how much space it expands to after that.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

yeah, I was also a bit irritated having to install 12GB of Xcode just to built this cli 🙈
But can confirm, simply using the package installer works just fine and makes this whole process easier...

Turns out, because I'm still on Big Sur, installing with homebrew will not work. According to Package.swift Swift 5.6 is needed. The most recent Xcode on Big Sur is 13.2.1, which ships with Swift 5.5.
I guess it's time to bite the bullet, hoping the rest of my development stack won't come to a stop.

Updated to Monterey this week. After updating Xcode I was able to install gather the homebrew way.


custom version

Hi.
You responded recently to my excited YouTube comment saying to write here with an explanation of what i need the unit to achieve.
I am needing the midi box to analyse in Realtime incoming midi cc messages and then by pressing a button save all of the cc values as a preset. Ideally being able to name those files too but a number would suffice.
When i want to retrieve these presets i would like to be able to skip through them using 2 buttons and the send all of the midi cc values with a gap between each back to my hardware at the single press of a button.
Hope this makes sense and i hope you can help!
Cheers. Tom

I meant to also say that i need to be able to save lots of presets so would like it to be able to save them to SD card.

Hi Tom,
Sorry for the delay. The main change for your application is that you need the preset-box to not only send MIDI signals, but receive midi signals as well. This means that your effect box/instrument/keyboard needs to send those MIDI CC messages out to the preset box.
Unfortunately, the Moogerfoogers only read MIDI messages, they do not send the current CC message settings. Although, if you are targeting an instrument that has both MIDI out and input for the CC messages, then this should be possible to do! What MIDI devices are you targeting?


Update dependencies and Actions

Update to Grafana 10.3.1 dependencies.
Update Actions to use Node 20.

@asimonok @vitPinchuk Is it ready? Please comment for me to review and merge updates.


Add a Cancel Button to app.py

Add a button which will cancel all running requests (NSE downloads/processes, hodographs, etc.), clear out directories, and re-enable access to all input buttons and dropdowns.

This Pull Request added initial cancel bar functionality. Closing this enhancement. Bugs or subsequent issues can be addressed with bug tickets.


Remove offline timeout shutdown

Remove the code that starts a shutdown timer when a node is Offline.
Tested that the sync status still updates with client status on a local network.
Closes #7970.

We discussed adding an error log in place of the shutdown.

Yes, can put that in.

@nholland94 @deepthiskumar Made requested changes, I believe.

I really prefer this something that can be enabled/disabled from coda client CLI. Other than the unique edge case bootstrapping a new network, when is this actually valuable? I prefer termination to hanging out offline relatively quietly. Why is it good to stay up, offline?

I really prefer this something that can be enabled/disabled from coda client CLI. Other than the unique edge case bootstrapping a new network, when is this actually valuable? I prefer termination to hanging out offline relatively quietly. Why is it good to stay up, offline?

Having nodes crash after 15 minutes of inactivity on the network has the effect that the entire network can crash if no one is producing blocks or sending transactions for 5 slots. That's a bad thing, and we never want that to happen, but this behavior means that the network will just shut down if that happens, which only makes things worse. Note that your node will still crash if it cannot connect to peers. It's only that now it will not crash if the network has been silent for a few slots.

!approved-for-mainnet


[Monitor] az monitor metrics alert: refine several help messages

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S169

add to S170

/azp run CLI Automation Full Test


lstm + ctc for ocr?

Sorry to bother you.
Can you push your lstm_ocr.py in this repository? I really want to know the struct of rnn before you Integrate warpctc in mxnet,so I could rewrite it in tensorflow.

It disturbs me : [mx.sym.WarpCTC] (https://github.com/dmlc/mxnet/blob/master/example/warpctc/lstm.py#L77)

https://github.com/dmlc/mxnet/tree/master/example/warpctc
mx.sym.WarpCTC is implemented in https://github.com/dmlc/mxnet/tree/master/plugin/warpctc

Thank you .  [It https://github.com/dmlc/mxnet/tree/master/plugin/warpctc)(https://github.com/dmlc/mxnet/tree/master/plugin/warpctc) help me a lot!

复杂系统实验室（自动化大厦1023）   王春恒老师