Return gridpool trades

What's needed?
Currently there is no way to retrieve individual gridpool level trades data. The difference between trades and orders is that an order can result into multiple trades each having its own status, price and quantity. Also an order has its own initial quantity.
Proposed solution
Introduce two new RPC endpoints:
// Service providing operations related to order management.
service ElectricityTradingService {

  // ....

  // Lists all trades for a given Gridpool.
  rpc ListGridpoolTrades(ListGridpoolTradesRequest)
      returns (ListGridpoolTradesResponse);

  // Stream trades for a given Gridpool.
  rpc ReceiveGridpoolTradesStream(ReceiveGridpoolTradesStreamRequest)
      returns (stream ReceiveGridpoolTradesStreamResponse);

  // ....

}

Note on TradeState: see this related issue here
// Enum for the state of a trade.
enum TradeState {
   // ...
}

// Represents a private trade in the electricity market.
//
// !!! note
//     This represents either the buy or sell side of a trade which is different to
//     public trade information which always represents both sides of a market.
message Trade {
  // ID of the trade.
  uint64 id = 1;

  // ID of the order.
  uint64 order_id = 2;

  // Indicates if the trades order was on the Buy or Sell side of the market.
  MarketSide side = 3;

  // Delivery area of the trade.
  frequenz.api.common.v1.grid.DeliveryArea delivery_area = 4;

  // The delivery period for the contract.
  frequenz.api.common.v1.grid.DeliveryPeriod delivery_period = 5;

  // UTC Timestamp of the trades execution time.
  google.protobuf.Timestamp execution_time = 6;

  // The price at which the trade was executed.
  frequenz.api.common.v1.market.Price price = 7;

  // The executed quantity of the trade.
  frequenz.api.common.v1.market.Energy quantity = 8;

  // Current state of the trade.
  TradeState state = 9;
}

// Parameters for filtering Gridpool trades.
//
// !!! note
//     Multiple filters can be used in combination to narrow down the returned
//     results. For example, you can apply both state and side filters
//     simultaneously to list only the trades on the buy side of the
//     market.
message GridpoolTradeFilter {
  // Optional filter for the trade state.
  repeated TradeState states = 1;

  // Optional filter for the given order id´s.
  repeated uint64 order_id_list = 2;

  // Optional filter for the trades order side.
  optional MarketSide side = 3;

  // Optional filter for delivery period.
  frequenz.api.common.v1.grid.DeliveryPeriod delivery_period = 4;

  // Optional filter for delivery area.
  frequenz.api.common.v1.grid.DeliveryArea delivery_area = 5;
}

// Request to retrieve a list of trades for a specific Gridpool.
message ListGridpoolTradesRequest {
  // The Gridpool to retrieve the trades for.
  uint64 gridpool_id = 1;

  // Optional Gridpool trades filter.
  GridpoolTradeFilter filter = 2;

  // Pagination parameters.
  frequenz.api.common.v1.pagination.PaginationParams pagination_params = 3;
}

// Response from listing trades for a given Gridpool.
message ListGridpoolTradesResponse {
  // List of all listed trades with their details.
  repeated Trade trades_list = 1;

  // Metadata for pagination, including token for next page to retrieve.
  frequenz.api.common.v1.pagination.PaginationInfo pagination_info = 2;
}

// Subscribe to the stream of gridpool trades.
// This method provides real-time updates on newly executed gridpool trades,
// making it useful dynamic analytics and real-time decision-making.
message ReceiveGridpoolTradesStreamRequest {
  // Optional filter to specify which trades should be included in the stream.
  TradeFilter filter = 1;
}

// Response to a subscription request for a stream of Gridpool trades.
// Real-time information on trades is pushed through this response.
message ReceiveGridpoolTradesStreamResponse {
  // The trade that has been executed and is being broadcasted in
  // real-time.
  Trade trade = 1;
}

Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

message Trade {

Maybe PrivateTrade

// ID of the trade.
uint64 id = 1;

Is this the ID matching the one from the public order book (in public trade)?

// Delivery area of the trade.
frequenz.api.common.v1.grid.DeliveryArea delivery_area = 4;

Is this the area of the gridpool, or the one where the energy is being "delivered"?

// UTC Timestamp of the trades execution time.
google.protobuf.Timestamp execution_time = 6;

I wonder why private trades have only execution time and public trades only modification time. Maybe both Trade types should have both times?

message GridpoolTradeFilter {

Could be convenient to also filter on execution time.

message ReceiveGridpoolTradesStreamRequest {
// Optional filter to specify which trades should be included in the stream.
TradeFilter filter = 1;
}

Don't we need gridpool_id here?

Could be convenient to also filter on execution time.

True, could be useful but in this case it should be implemented as bounds then because execution times are down to the milisecond.

Maybe PrivateTrade

hmm I don't think the distinction is super necessary, but in case we wanna do this then we'd also have to change how we define Order.

Is this the ID matching the one from the public order book (in public trade)?

No I don't think so

// ID of the trade.
  uint64 id = 1;

This could maybe be trade_id, since the id of the orders are named order_id

True, could be useful but in this case it should be implemented as bounds then because execution times are down to the milisecond.

If there is no immediate use case lets please postpone this.


feat: add support for quadlet, secrets

Feature: Add support for quadlets.  User can pass in quadlet units using
podman_quadlet_units.  Add support for secrets.  User can pass in
Ansible Vault encrypted secrets using podman_secrets.
Reason: quadlets are the new way to implement applications in podman that
use systemd services.  quadlets allow you to specify everything you need
to run your application - containers, services, volumes, networks, and
more - using simple, systemd style unit files.  Secrets such as passwords,
tokens, keys, etc. are an important part of application configuration, so
the role now allows those to be specified.
Result: Users can deploy entire, complex applications using the podman
system role using quadlet units.

[citest]

[citest]

[citest]

[citest]

@vrothberg @ygalblum the quadlet demo is not working on EL8 - looks like podman there was recently updated to podman-3:4.5.1-5.module+el8.9.0+19106+3ac0000c.x86_64  - EL9 works fine with podman-2:4.5.1-4.el9.x86_64
Here is the error - from podman logs the-wordpress-container:
Warning: mysqli::mysqli(): php_network_getaddresses: getaddrinfo failed: Name or service not known in - on line 22
Warning: mysqli::mysqli(): (HY000/2002): php_network_getaddresses: getaddrinfo failed: Name or service not known in - on line 22
MySQL Connection Error: (2002) php_network_getaddresses: getaddrinfo failed: Name or service not known

all other pod logs/journalctl look fine
I'm willing to chalk this up to a bug that snuck into the podman update in EL8 that is hopefully known and will be fixed shortly

@richm a bug with a reproducer would be great. Thank you!

[citest]

[citest]

@ygalblum looks like installing podman-plugins works on all platforms - ok to leave it in?  Or will the podman package in rhel8 be fixed to require this?

LGTM for the code.
As for podman-plugins, I think @Luap99 knows better than me

LGTM for the code. As for podman-plugins, I think @Luap99 knows better than me

I cannot comment on whenever RHEL 8 is supposed to install it by default or not. I think fedora had a recommends before we switched to netavark.
Also I have no idea what adding podman-plugins here does, is this only installed for CI testing or by default for all users? This package should no longer be installed by default on distros who ship netavark/aardvark-dns. And also this is not even a general package name by any means. Every distro decided to name the dnsname plugin package differently, if this role only targets fedora/centos/rhel it is fine but if you need support for other distros it would fail there.

LGTM for the code. As for podman-plugins, I think @Luap99 knows better than me

I cannot comment on whenever RHEL 8 is supposed to install it by default or not. I think fedora had a recommends before we switched to netavark.
Also I have no idea what adding podman-plugins here does, is this only installed for CI testing or by default for all users?

I am proposing that this will be the default for runtime - any user using this role will have podman-plugins installed.  I suppose I could change it so that it only installs podman-plugins if using any of the quadlet features, but that seems unnecessarily complex.

This package should no longer be installed by default on distros who ship netavark/aardvark-dns. And also this is not even a general package name by any means. Every distro decided to name the dnsname plugin package differently, if this role only targets fedora/centos/rhel it is fine but if you need support for other distros it would fail there.

The problem is that the RHEL8 package podman-3:4.5.1-5.module+el8.9.0+19106+3ac0000c.x86_64 does not have a dependency on podman-plugins, and attempting to use quadlet networking without podman-plugins fails.  The RHEL9, Fedora, and rhcontainer copr podman packages do not have this problem.  I do not know if they have an explicit dependency on podman-plugins, or otherwise do not have this problem because DNS is handled in a different way on RHEL9 and later.
I am currently not worried about supporting platforms other than RedHat OS family, but if we do decide to support those platforms, we can easily do that, and have different packages for different distro/version combinations.

Can you make it conditional on a podman command output podman info --format {{.Host.NetworkBackend}}?
If this says CNI you will need podman-plugins installed for dns, if it says netavark you need aardvark-dns installed (that should be default on RHEL 9 newer).
I think it is worth to file a bz against RHEL 8 and ask for a recommends on podman-plugins there. I am not aware of any reason why it should not be installed.

Can you make it conditional on a podman command output podman info --format {{.Host.NetworkBackend}}? If this says CNI you will need podman-plugins installed for dns, if it says netavark you need aardvark-dns installed (that should be default on RHEL 9 newer).

Do we ask RHEL customer who want to use podman + quadlet to do this?  If so, then I can add this to the role.  If not, then I don't think the role should do this, it should be handled by a podman package dependency?

I think it is worth to file a bz against RHEL 8 and ask for a recommends

Why a recommends instead of a requires?

on podman-plugins there. I am not aware of any reason why it should not be installed.

I guess what I am asking is - is this a bug in the podman packaging on RHEL8?  It seems like it to me, unless we are going to tell our RHEL8 podman users that they must first install podman-plugins if they want to use quadlet features?

I guess what I am asking is - is this a bug in the podman packaging on RHEL8? It seems like it to me, unless we are going to tell our RHEL8 podman users that they must first install podman-plugins if they want to use quadlet features?

That seems like a fair expectation to me.

[citest]

[citest]

[citest]

ETA for this?  We'd hoped to have it delivered for July 17 if possible.


Add Pokemon Mini to MiSTer

https://github.com/MiSTer-devel/PokemonMini_MiSTer

you'll need to rebase against testing in the future


NIFI-5600 - Restore node location display on queue listing

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mcgilman @scottyaslan - friendly ping to be sure I didn't do something against the purpose of NIFI-5208 (#2740)

Sorry for missing the mention... Will review

@pvillard31 Thanks for the PR! I can see what is happening here and I think a slightly different solution is required. With the introduction of NIFI-5208 we should be watching the cluster status actively so we can track the disconnected state. Because this state can change, I think we need to reconsider the columns we show when the listing is opened (not when the UI is bootstrapped). We actually have the same issue showing component state. I am going to open up another PR with this alternate solution.

Provided an alternate solution here: https://github.com/apache/nifi/pull/3055

Thanks much @mcgilman !


"Install Plugin" via GUI fails to add plugin to plugins.txt correctly for first plugin

Please verify that this bug has NOT been raised before.

[X] I checked and didn't find a similar issue

Describe the bug*
When trying to install a plugin via the GUI function "Install Plugin" without any prior installed plugins, the plugin is appended to the first line of the plugins.txt.
As the first line is already populated with # InvenTree Plugins (uses PIP framework to install) the result is e.g. # InvenTree Plugins (uses PIP framework to install)inventree-zebra-plugin@git+https://github.com/SergeoLacruz/inventree-zebra-plugin  # Installed 2023-04-28 06:55:40.146423+00:00 by xyz thus ignoring the plugin in a docker env restart because of the #.
Subsequently installed plugins are correctly placed in an empty line of the plugins.txt.
Steps to Reproduce

Have a fresh install without installed plugins.
Go to "Settings" > "Plugin Settings" > "Plugins" > "Install Plugin"
Fill "Package Name" with inventree-zebra-plugin
Fill "Source URL" with git+https://github.com/SergeoLacruz/inventree-zebra-plugin
"Submit"
Check plugins.txt file

Expected behaviour
The installed plugin should be added below the comment such that it actually will be parsed by the plugin management.
Deployment Method

[X] Docker
[ ] Bare metal

Version Information
Version Information:
InvenTree-Version: 0.11.0
Django Version: 3.2.18
Commit Hash: 593a716
Commit Date: 2023-04-18
Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Active plugins: [{'name': 'InvenTreeBarcode', 'slug': 'inventreebarcode', 'version': '2.0.0'}, {'name': 'InvenTreeCoreNotificationsPlugin', 'slug': 'inventreecorenotificationsplugin', 'version': '1.0.0'}]
Relevant log output
No response

Thanks for the report; looking into it


Can't find configurations in the solution by patterns: Installer

Dear @Nice3point
Currently i am getting this error with config, can you give me some hint info for this, even though i have already added config.
Thanks you.
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
       <Optimize>true</Optimize>
       <DebugType>none</DebugType>
   </PropertyGroup>

@chuongmep did you create a project based on a template?

by default, the Installer solution configuration is created, you apparently do not have it

@Nice3point yes i have, let see https://github.com/chuongmep/RevitAddInManager/tree/dev_NET6
i am making msi installer for addinmanager tool, can you take a look at it ?

by default, the Installer solution configuration is created, you apparently do not have it

oh, i miss that, thanks so much

@chuongmep  there are no configured configurations in the project at all

and there is no need to manually copy the code from the RevitLookup project
create a new project with Visual Studio 2022 or use the command line
dotnet new revit-sln -n RevitAddInManager
dotnet new revit-addin -n RevitAddInManager

i messed up with release config and project name, thanks a lot, problem resolved.


Select should show selected_value in readonly/disabled mode

If readonly or disabled is set on the select component, initial selected_value is not displayed. It would be great to display this in one of these states (or add a third one).
For sure it would be possible to use e.g. a div and only displaying the selected_value label for a readonly representation. But than I have to rebuild the whole logic of mapping value to label (could be an effort in a filtered list with non unique values).
In the moment I am solving this with an ugly workaround:
Added a new option "unselectable" and use it in select.js:
activate = () => {
    if(this.unselectable !== true) {
        dom_el(this.clickArea).addEventListener('click', (e) => {
            unhide(this.itemsContainer);
        });
    }
    .................................................

Please provide your version of BladewindUI

Please provide your version of BladewindUI

Sorry, forgot this.
composer.lock says: v2.6.4

Hey @printpagestopdf this was reported in #299 and been fixed since then. Please composer update to get the latest version of BladewindUI. Let me know if the problem still exists after the update.

Ups sorry, my fault with the old Version, but I am working on an installation that somebody else made (and controls). Please close this.


Introduce sharing scope property on Subnet

SharingScope property on a subnet is used to indicate if the subnet can be shared for Injection. Customer can set the enum value to 'Tenant' to start creating compute (VM/VMSS/Flex) on different subscriptions (under the same AAD tenant) while consuming IP Address from the subnet hosted on a different subscription.
Changelog

What's the purpose of the update?

[ ] new service onboarding
[X] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month - Server-side changes are already rolled out and enabled in 9 regions.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
February
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[X] I commit to follow the Breaking Change Policy of "no breaking changes"
[X] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run


Move the default location for installer logs

Change
Moves the default log location for installer logs to be the same as the location for winget logs, which on a default install is:
%LOCALAPPDATA%\Packages\WinGetDevCLI_8wekyb3d8bbwe\LocalState\DiagOutputDir

This will allow reports through Feedback Hub to gather those logs to better help us diagnose issues with specific installers.
Additionally, winget --info will now also show this log location.
Microsoft Reviewers: Open in CodeFlow

can we add tests to validate location?

There are tests that validate the location, and I even forgot to update them and they failed.  So they are doing their job 😄


[SPARK-14013][SQL] Proper temp function support in catalog

What changes were proposed in this pull request?
Session catalog was added in #11750. However, it doesn't really support temporary functions properly; right now we only store the metadata in the form of CatalogFunction, but this doesn't make sense for temporary functions because there is no class name.
This patch moves the FunctionRegistry into the SessionCatalog. With this, the user can call catalog.createTempFunction and catalog.lookupFunction to use the function they registered previously. This is currently still dead code, however.
How was this patch tested?
SessionCatalogSuite.

Test build #54238 has started for PR 11972 at commit 238d392.

cc @yhuai
I took a quick look and it looks good -- but I didn't look at the details.

Test build #54238 has finished for PR 11972 at commit 238d392.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54238/
Test FAILed.

Merged build finished. Test FAILed.

Overall looks good.

Test build #54341 has started for PR 11972 at commit 2f53330.

Test build #54341 has finished for PR 11972 at commit 2f53330.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54341/
Test FAILed.

retest this please

Test build #54362 has started for PR 11972 at commit 2f53330.

Test build #54362 has finished for PR 11972 at commit 2f53330.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54362/
Test PASSed.

OK thanks, I'm merging this to unblock progress on other issues.

Test build #54383 has started for PR 11972 at commit 271227c.

Test build #54383 has finished for PR 11972 at commit 271227c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54383/
Test PASSed.

Merged build finished. Test PASSed.


Error with vue2:  export 'toRefs' (imported as 'toRefs') was not found in 'vue-demi'

my sollution: npm i @vue/composition-api

@scil This is not a bug. Vue 2 users have to install composition-api as it's a peer dependency that is not needed in vue3.
As mentioned in docs: Vue Query is compatible with Vue 2.x + composition API or 3.x.
You might want to check the Vue2 example for a proper project setup: https://github.com/DamianOsipiuk/vue-query/tree/main/examples/2.x-basic

@scil This is not a bug. Vue 2 users have to install composition-api as it's a peer dependency that is not needed in vue3. As mentioned in docs: Vue Query is compatible with Vue 2.x + composition API or 3.x.
You might want to check the Vue2 example for a proper project setup: https://github.com/DamianOsipiuk/vue-query/tree/main/examples/2.x-basic

I not mention it as a bug. I just think the doc not clear enough.
with vue2, I  npm install vue-query  @vue/composition-api
then
import { VueQueryPlugin } from "vue-query";
import { VueQueryDevTools } from "vue-query/devtools";
Vue.use(VueQueryPlugin);

But I do not know how to do next to use vue-query in a html page.  Is there any example to use vue-query with vue2?


Suspicious code. Is there a missing '+' on the previous line? "use strict";

Hi @kmmbvnr ,
I get a warning when compiling of materialize.components.js.
Here is an issue: https://github.com/google/closure-compiler/issues/2046#issuecomment-250036627
From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#invoking_strict_mode:

Strict mode applies to entire scripts or to individual functions. It doesn't apply to block statements enclosed in {} braces; attempting to apply it to such contexts does nothing. eval code, Function code, event handler attributes, strings passed to setTimeout(), and related functions are entire scripts, and invoking strict mode in them works as expected.

'use strict' doesn't make sense in this case so.?

materialize.components.js file is already compiled from many sources
"use strict" looks like completely legitimate construct

Seems most of "use strict" added by babel
https://stackoverflow.com/questions/33821312/how-to-remove-global-use-strict-added-by-babel
Probably material build process could be improved to fix this

materialize.components.js file is already compiled from many sources
"use strict" looks like completely legitimate construct

'use strict' doesn't make sense as a directive unless it's the first line of a file or the first line of a function.
The correct use is then:
(function () {
  'use strict'; ⬅ HERE
  if ( // No Reflect, no classes, no need for shim because native custom elements
  // require ES2015 classes or Reflect.
  ...
})();


Kubernetes Third-Party Security Audit for 2023-24 (tracking issue)

Tracking issue for the Kubernetes third-party security audit for 2023-2024:

[ ] Define audit scope
[ ] Create RFP

[ ] Finalize dates: RFP opening and closing dates, question period, vendor selection
[ ] Complete question period and publish questions & replies to RFP

[ ] Vendor assessment

[ ] Assemble vendor assessment group
[ ] Create private Google group

[ ] Release vendor selection
[ ] Coordinate SME as contacts for vendor
[ ] Vendor conducts audit
[ ] Send findings to SRC
[ ] Findings review with SIG Security
[ ] Publish findings

/sig security

xref: https://github.com/kubernetes/sig-security/pull/105 add windows to scope

also include the new threat model refresh @raesene

Aside: how about adding /area audit (label and associated Prow command)?


HTML / Web Clipping in Subconscious and multi-line quotes

I'd like to easily be able to clip and quote web content into my Subtext-flavoured Subconscious notes.
Here's an example

Which I put into my notes with the title and then the link:

And then I want to quote that whole chunk of text. As I understand it, Subtext should be "single line", but this is a multi line quote.
As well, there are links embedded there, which go to other articles by the same author. Right now, I would have to cut and paste each of those links and somehow include them on their own lines.
So, two issues:

how to do multi-line quotes (visually aesthetic) in a way that the whole quote is treated as a block
how to extract / keep those links as I paste content, ideally automatically on paste.

Thread in Discord https://discord.com/channels/1003419732516552724/1118921779734393022


My location button doesn't work on iOS

I use nativescript-google-maps-sdk in my application with Nativescript at 6.1.2 version.
The button to go to my position doesn't works on iOS.
The same problem is in the demo application.
On Android all works fine.

Good day. Im also having this issue, some help could be good. My workspace is:
Nativescript 6.2.0
Platform IOS 6.2.0
nativescript-google-maps-sdk 2.8.1
As described before by ebiscardi, it works on Android but on ios doesn't.

the same for me

I am experiencing the same issue. It might be related to iOS 13.
For the time being I can offer you a small workaround:
if (isIOS) {
    this.map.on("myLocationTapped", event)=> {
        geolocation.isEnabled().then(enabled => {
            if (enabled) {
                geolocation.getCurrentLocation({
                    maximumAge: 5000,
                    timeout: 20000
                }).then(location => {
                    this.map.gMap.animateToLocation(location);
                });
            }
        });
    });
}

You will need to use the geolocation plugin tho.

Can I know whether this issue is fixed or not yet?


Support Accept/Reject All with minimal TCF

Closes PROD-2777
Description Of Changes
Today, the “minimal” TCF banner can display the banner but the “Accept All” and “Reject All” actions are not enabled until the “full” experience is loaded. This can take several seconds to do on a low-speed connection, which creates a window where users can see a banner but are unable to opt-in.
These changes are set up for handling a new scenario in which a minimal version of experience.gvl is provided as part of the minimal TCF experience response.
If no GVL is included, we'll at least show some spinners during the loading of the full experience to not appear "broken" during that time.
Code Changes

[x] New Spinner component (very small, css only)
[x] Show spinner on the Modal button (Manage Preferences) while the full experience finishes loading
[x] Show spinner on Accept/Reject buttons if the gvl object is not included with the minimal experience (for backwards compatibility mostly)
[x] Update/create several of the utilites that support "Accept All" from the full experience to also support it from the minimal experience, which only supplies IDs
[x] Remove any blockers from letting users Accept/Reject all from the minimal experience

Steps to Confirm

visit the Fides.JS demo site with TCF enabled (eg. http://localhost:3001/fides-js-demo.html?geolocation=eea)
In browser's dev tools, enable throttling in the Network tab to mimic a slow network
Clear any existing cookie and reload the page

If the response is slow enough with the throttling, you should see a spinner on the Manage Preferences button until the full experience has loaded
If the backend task for including a minimal gvl isn't finished yet, you should see a spinner on all 3 buttons while the full experience loads
If you attempt to click Accept All or Reject all before the full experience has loaded (the spinner is still spinning), it should work as expected and close the banner. This behavior should be exactly the same as clicking the respective buttons after the full experience loads. (Cookie set with same fides_string, payload for saving the preference api should be the same, CMP Validator should report the same)

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
[x] Issue Requirements are Met
[x] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md

If the response is slow enough with the throttling, you should see a spinner on the Manage Preferences button until the full experience has loaded

This is working, I see the spinner. We don't want to draw attention to the Manage Preferences button though since we want them opting in. I suggest we only show the spinner if the button is clicked before layer two is loaded.

If the backend task for including a minimal gvl isn't finished yet, you should see a spinner on all 3 buttons while the full experience loads

I was never able to see a spinner on all three?

If you attempt to click Accept All or Reject all before the full experience has loaded (the spinner is still spinning), it should work as expected and close the banner. This behavior should be exactly the same as clicking the respective buttons after the full experience loads.

The spinner was not showing but I could see the network calls had not completed when I clicked accept all, the banner closed, and the ticket was created!

@Kelsey-Ethyca

I was never able to see a spinner on all three?

Are you using the backend with Dawn's latest changes or not yet?

@Kelsey-Ethyca

I was never able to see a spinner on all three?

Are you using the backend with Dawn's latest changes or not yet?

I am!

@Kelsey-Ethyca

I was never able to see a spinner on all three?

Are you using the backend with Dawn's latest changes or not yet?

I am!

Cool. Then you shouldn't see all 3 spinners. That was for backwards compatibility :)


Clarify about placement of onSelect() method

As a beginner to Angular, it was unclear from the instructions where the placement of the onSelect() method should go.  I propose clarifying that it should be placed in the export statement.

I signed it!

I do not understand. The OnSelect method is added to AppComponent. And there is a code snippet immediately after that sentence that illustrates.
Meanwhile, I have no idea what "placed in the export statement" means. There is no such thing as an "export statement" (there are two export declaration, neither of them involving this method).
We're also about to refresh the tutorial in the next few months.
For all of these reasons, with regret I must reject this PR.


My win7 environment, always prompt: debug adapter process has been unexpectedly terminated

环境：windows7 + iis7 + fastcgi + php5
PHP version:  5.5
XDebug version:  2.5.5
Adapter version:  没有
Your launch.json:
{     "version": "0.2.0",     "configurations": [         {             "name": "Listen for XDebug",             "type": "php",             "request": "launch",             "port": 9800         },         {             "name": "Launch currently open script",             "type": "php",             "request": "launch",             "program": "${file}",             "cwd": "${fileDirname}",             "port": 9800         }     ] }
XDebug php.ini config:
xdebug.remote_enable = 1
xdebug.remote_autostart = 1
XDebug logfile (from setting xdebug.remote_log in php.ini):
Adapter logfile (from setting "log": true in launch.json):
Code snippet to reproduce:

Same issue here

Same on Ubuntu

@kingkrausel @djgreg13 please see #203

Same issue on Ubuntu 17.10, vscode 1.18.1.


another module with an equal name warning - need more info

There is warning sometimes:
(webpack)/buildin/module.js
There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

/Code/app/~/webpack/buildin/module.js
There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

it would useful to have additional info what does this warning mean and what causes it.
In my case this is caused by linked packages that require module with the same name from different locations. But it would be nice to have this conflicting module name in the warning message and probably some additional some details.

Same issue. I have no idea why or where it came from.

do you use some npm linked modules?

@whitecolor I got this warning with the exactly same module names: (webpack)/buildin/module.js and ~/webpack/buildin/module.js. Which modules caused it in your case?

It turns out, this happens only if I run webpack-web-server via npm run ....
If I run it as node_modules\.bin\webpack-dev-server, everything is OK.

that is strange =) btw I don't use webpack-dev-server cli because problems with hot reload I meat https://github.com/webpack/webpack/issues/2424

@whitecolor What's your OS?

(Windows 10 x64, Node v5.5.0)

Something tells me these issues are Windows-specific.

I'm not sure, but might be.

The warning is windows and mac. In linux the same combination would cause a module not found error. Linux users are usually more aware for file system casing...

@sokra If i'm correct I had this problem with linked modules (modules with the same name where take from different locations on the disk) could it be the issue?

@sokra I understand the original meaning of this error message. The thing is that it's caused by something else in this case, not by a file name casing issue. As I wrote, it happens only if I run webpack-web-server via npm run. So I'm almost sure it's some kind of Windows-specific path conversion issue.

Sorry, I forgot that when I run the dev server via npm run, I run it with --inline. So that's the difference, that's what leads to this warning: the inline mode.

This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

WARNING in (webpack)/buildin/module.js
There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.
webpack: bundle is now VALID.

Tested this configuration on Mac OS X 10.9.5. The issue doesn't exist there. module.js is included only once.

d:\dev\foo vs D:/dev/foo
not sure why...

So it's actually caused by the fact that Node's builtin functions aren't consistent in what case they use for the drive letters on Windows. __filename, __dirname, and require.resolve return it in upper case (D:\dev\foo) whereas path.resolve and process.cwd in lower (d:\dev\foo).
webpack-dev-server uses require.resolve here, which leads to the bug I described above.
I think the best workaround here would be to make webpack internally consider D:\file.js and d:\file.js exactly same files.

For me, process.cwd() returns "C:\\Users\\sokra" in with an uppercase letter and correct slashes. How do you call node? (from cmd?) What's the result of echo %cd%?

For me, it returns lower case only for drive D. All the other drive letters are uppercase. And it happens not only in Node. It's something on the OS level:
C:\>echo %cd%
C:\

C:\>D:

d:\dev>echo %cd%
d:\dev

d:\dev>

Yes, I called Node from cmd. And in the properties of the shortcut for cmd.exe, the "Start in" folder was specified with a lowercase "d".

test.js:
var exprs = ['__dirname', '__filename', 'require.resolve("./test")',
    'require("path").resolve("test.js")', 'process.cwd()'];
for (var expr of exprs) {
    console.log(expr, eval(expr));
}

In cmd:
d:\dev\foo>node test
__dirname D:\dev\foo
__filename D:\dev\foo\test.js
require.resolve("./test") D:\dev\foo\test.js
require("path").resolve("test.js") d:\dev\foo\test.js
process.cwd() d:\dev\foo

If I change the case of the drive letter in the "Start in" field of the shortcut for cmd, everything becomes consistent.
D:\dev\foo>node test
__dirname D:\dev\foo
__filename D:\dev\foo\test.js
require.resolve("./test") D:\dev\foo\test.js
require("path").resolve("test.js") D:\dev\foo\test.js
process.cwd() D:\dev\foo

hmm weird...
I've checked how node.js behaves, and it also returns two modules for different drive letters. So webpacks behavior is equal to node.js.
So this should be discussed/fixed on node.js level.

@thorn0 This was it, thanks! It's the weirdest thing, though. I usually type cd **c:**dev\projectname into my console and get going. Typing cd **C:**dev\projectname fixed it. I didn't even know it was possible, or made a difference.

I've got a like warnings for style loader (actually loading less)

WARNING in ./client/~/style-loader/addStyles.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:

D:\Code\app\client\node_modules\style-loader\addStyles.js
d:\Code\app\client\node_modules\style-loader\addStyles.js

WARNING in ./client/~/css-loader/lib/css-base.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:

D:\Code\app\client\node_modules\css-loader\lib\css-base.js
d:\Code\app\client\node_modules\css-loader\lib\css-base.js

Any advice how to get rid of this?

@whitecolor It turns out it makes a difference for Node on Windows whether you run cd d:\foo or cd D:\foo before running Node. So just use upper case everywhere in your paths. :trollface:

@thorn0 well but I don't set explicit name anywhere inside webpack.config I use __dirname and path.resolve and __dirname and path.resolve come with D:/ where this small d: can appear from?

@whitecolor As I wrote it comes from the properties of the shortcut or from the cd command.

I run npm run webpack-dev from command line. No any shortcut or cd commands.
I require some module from node_modules and it contains file that requires .less file inside this module, probably this cases to require d:\Code\app\client\node_modules\css-loader\lib\css-base.js. instead of 'D:/....'

No any shortcut or cd commands.

So how do you get to the command line then? How does your command prompt look? d:\Code\app\client or D:\Code\app\client?

D:\Code\app\client

It even may be something inside LESS itself that changes the case.

Yes you are right. it is again about linked modules, that where linked using d: path. Thanks)

Another Windows user here, experienced the same issue. Again it was a drive letter that was the culprit--fixed it in webpack.config.js by changing my entry point from path.join(__dirname, 'src') (which uses a capital drive letter) to a hardcoded string c:\\Users\\....\\src

may by we can disable this warning ?

In my case this was an index.js file actuallly names 'Index.js` and im on unix/linux
So be careful with
import myModule from 'path/to/my/module/folder'
rather then
import myModule from 'path/to/my/module/folder/index.js'

Windows users, for me replacing __dirname with variable holding __dirname.toLowerCase() and using it consistently across webpack's config did the trick. No more warnings.
I'm using Cmder for everything console related and pwd command results in something like: c:\node\my-project. (lowercase C) However, no matter how I had cd'd in to that directory, __dirname was holding "C:\node\my-project" (UPPERCASE C) and I got plethora of warnings.
It's a workaround, but I'm not quite sure if one should be forced to use hacks like this...

In the same vein as @mkontula , I am using this:
path.join(__dirname, 'src').replace(/^([A-Z]:)/, v => v.toLowerCase())
This prevents errors in Windows when __dirname contains capital letters elsewhere from the drive letter.

I have similar issue on Mac OS X, but in my case it seems like it starts happening after I've renamed my file (View.vue to view.vue). It looks like webpack thinks both file are exists, which isn't true.
WARNING in ./src/story/view.vue
There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

WARNING in ./src/story/View.vue
There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

I ran into this issue too. It behaves differently between PowerShell and cmd.exe.
Result of @thorn0 's test.js in PowerShell:
PS F:\dev\foo> node .\test.js
__dirname F:\dev\foo
__filename F:\dev\foo\test.js
require.resolve("./test") F:\dev\foo\test.js
require("path").resolve("test.js") F:\dev\foo\test.js
process.cwd() F:\dev\foo

In cmd.exe:
f:\Dev\foo>node test.js
__dirname f:\Dev\foo
__filename f:\Dev\foo\test.js
require.resolve("./test") f:\Dev\foo\test.js
require("path").resolve("test.js") f:\Dev\foo\test.js
process.cwd() f:\Dev\foo

@AKFish What version of Node do you use?
On Aug 28, 2016 4:00 AM, "AKFish"<EMAIL_ADDRESS>wrote:
I ran into this issue too. It behaves differently between PowerShell and
cmd.exe.
Result of @thorn0 https://github.com/thorn0 's test.js in PowerShell:
PS F:\dev\foo> node .\test.js
__dirname F:\dev\foo
__filename F:\dev\foo\test.js
require.resolve("./test") F:\dev\foo\test.js
require("path").resolve("test.js") F:\dev\foo\test.js
process.cwd() F:\dev\foo
In cmd.exe:
f:\Dev\foo>node test.js
__dirname f:\Dev\foo
__filename f:\Dev\foo\test.js
require.resolve("./test") f:\Dev\foo\test.js
require("path").resolve("test.js") f:\Dev\foo\test.js
process.cwd() f:\Dev\foo
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webpack/webpack/issues/2362#issuecomment-242949537,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFwfldx3bBUVfsTJhobdzhBnCpWxuilks5qkN3AgaJpZM4ILNIT
.

@thorn0 I'm using node 6.4.0
PS version:
PS F:\dev> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.0.10586.494
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.494
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

It has nothing to do with PowerShell itself. See my last comment in nodejs/node#6624.

@thorn0
Try running foo.bat:
@echo off
echo %CD%
echo %~dp0
echo %0

In PowerShell:
"F:\dev\foo.bat"
PS F:\dev> .\foo.bat
F:\dev
F:\Dev\
"F:\dev\foo.bat"

In cmd.exe:
f:\Dev>foo.bat
f:\Dev
f:\Dev\
foo.bat

So it should have something to do with powershell. But I agree node.js should have normalized the drive letter.

It has to do only with the way you start PowerShell and cmd (e.g. the 'Start in' property of the shortcut).

@thorn0 Not for powershell. It will normalize the drive letter to uppercase.

Yep, played a bit with PowerShell and was going to write the same.

If PowerShell does so, it's a good argument for Node to do so as well.

@thorn0 Yep.

Using a capital letter in the drive of the path works for me. C:\ rather than c:
Either change Your "start in" path, or from console:
cd C:\mypath     (the drive will not change)
d:                    (switch to another drive)
c:                   (switch back, and it's changed)

Just ran into this on one of my machines with Node 6.4, upgrading to 7.1 fixed the issue. Just a heads up for anyone who gets this far without fixing it :)

I'm struggling with this, I've used .replace("c:\", "C:\") in several place but still it doesn't work.
I think @thorn0's suggestion is right one:

I think the best workaround here would be to make webpack internally consider D:\file.js and d:\file.js exactly same files.

This juggling with C: vs c: is maddening, the webpack should detect we are using Windows and deal with it.

Here is a emergency monkey patch:
E.g. top of your webpack.dev.server.js:
var WarnCaseSensitiveModulesPlugin = require('webpack/lib/WarnCaseSensitiveModulesPlugin');
WarnCaseSensitiveModulesPlugin.prototype.apply = function () {};

I fixed this by removing unnecessary capitol letters in my  'import {} from "HERE"' strings
In some cases i had written
import { Observable } from "rxjs/Rx"
and
import { Observable } from "rxjs/rx"
fixed it.
I went through my project removing all caps where i did not need them and the errors went away. some camel case imports still just remain as is such as "mergeMap"
hope this helps someone.
Ryann,

To beat a dead 🐴
I had this issue on Mac OSX where I inadvertently imported a file from a location and capitalized the directory name i.e. import ReactTableWrapper from '../../Components/ReactTableWrapper'. It was happily imported however my directory name is components, not Components.
After I realized this, I looked more carefully at the warnings which happily tell you there's a case difference i.e. WARNING in ./src/containers/App/actions.js WARNING in ./src/Containers/App/actions.js <-- see the difference? I fat fingered the folder name again and made it proper-case instead of lowercase. Now 💯  of those warnings are gone! :)

To get rid of problems with lowercase drive letter on Windows you can try this https://www.npmjs.com/package/driveup as a hotfix for this issue. It changes the drive letter the UpperCase:
e:\your_project_path>driveup

E:\your_project_path>

or to launch your shell:
e:\>startcmd cmder e:\your_project_path

You can setup cmder launching to always have uppercase drive letter

I had that issue with NODE_PATH environment variable set to c:... while path.join in webpack.config.js was using C:... . Changed NODE_PATH to uppercase & problem went away.

Or you can open a command window with shift-right mouse button => Open command window here .. from explorer

I was getting these warnings during ng build where the only difference is in the case of the drive letter (Windows 10):
WARNING in<EMAIL_ADDRESS>There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:
*<EMAIL_ADDRESS>    Used by 9 module(s), i. e.
    D:\my-project\node_modules\@ngtools\webpack\src\index.js!D:\my-project\src\app\app.module.ts
*<EMAIL_ADDRESS>    Used by 2 module(s), i. e.
<EMAIL_ADDRESS>
This would mean that it has nothing to do with import statements containing capital letters (e.g. @angular/Core).
Also, I get warnings both in Command Prompt and PowerShell.
Even the way I switch directories made no difference: cd /d d:\my-project or cd /d D:\my-project.
Finally, I deleted the project's node_modules folder, and issued npm install, and ng build again -
there were no warnings.
Could it have something to do with how NPM installs the dependencies, especially if dependencies were not added all in one go (i.e. days apart) and the drive letter case somehow changed in that time (e.g. cd /d d:\my-project and cd /d D:\my-project)?

Removing node_modules and installing deps again helped me.

We improve the errors in v5. Closing due to inactivity. Please test with latest version and feel free to reopen if you faced with this problem again or something will be misleading for you. Thanks!


Revert project text search to previous behavior

What did you expect to happen?
Project text search should search normal files.
Project text search should search hidden files with the universal argument.
What actually happened?
Project text search searches hidden files by default.
Additional details:
Revert commit a904b718f888bb94207035c6599688a05c72507e
rg searches text in hidden files only with an explicit flag. Doom should do the same to keep user expectations in line.  Searching hidden files when invoked with the universal argument aligns with user expectations.
Steps to reproduce:
In a project with hidden files:

SPC /
Note --hidden on the command line.

System information:
SYSTEM  type       darwin
        config     x86_64-apple-darwin19.6.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
        path       (~/.local/share/virtualenvs/pynet-analysis/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /Library/TeX/texbin /usr/local/munki /opt/X11/bin ~/Library/Python/Current/bin /usr/local/sbin ~/.local/bin ~/bin /usr/local/go/bin ~/projects/go/bin ~/projects/personal/go/bin)
EMACS   dir        ~/.emacs.d/
        version    28.0.50
        build      Oct 28, 2020
        buildopts  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp<EMAIL_ADDRESS><EMAIL_ADDRESS>--with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained
        features   JPEG TIFF GIF PNG RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2
        traits     (server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        build      HEAD -> develop 57ef63d6 2020-10-29 05:42:10 -0400
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo indent-guides minimap modeline ophints (popup +defaults) treemacs vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold (format +onsave) snippets word-wrap :emacs dired electric undo vc :term eshell :checkers syntax :tools ansible docker (eval +overlay) lookup (lsp +eglot) (magit +forge) pass terraform :lang emacs-lisp (go +lsp) (haskell +dante) json markdown (org +journal) plantuml (python +lsp) sh yaml :email mu4e :config (default +bindings +smartparens))
        packages   ((base16-theme) (auto-virtualenv) (pyvenv) (kubernetes) (groovy-mode))
        unpin      (n/a)
        elpa       (n/a)

I agree that --hidden plus a blacklist for common VCS directories (.git, .svn, .hg etc.) would be a good default. Project search in my dotfiles is mostly useless now because everything is inside of .config or .local directories, and using -uu or plain --hidden will also search all git objects which is probably never what you'd actually want to do.

I can't put is more succinctly than this:

Text search tools (rg, the GNU grep family, and so on) skip hidden files unless they are explicitly included.
User expectation with any search tool is that it will behave similarly to other tools used in the past.
Searching hidden files by default is not how similar tools behave, so user expectation is violated.
Violating user expectations is a UX design flaw.

Putting --hidden behind C-u would be The Emacs Way.
If you want to change the project file search to use --hidden by default, there's a better argument there b/c tools like find look directly at inodes and don't care about shell-based semantics like hidden files.  However, this discussion is specific to text searching.

While that is the default behaviour of grep and ripgrep, when doing a project search you'd expect that to search the entire project, right? No other text editors or IDEs I've used with a 'Find in project...' option ignore dotfiles.

when doing a project search you'd expect that to search the entire project, right?

No, I wouldn't expect it to search in my git history at least. It is sometimes convenient to search in dotfiles (e.g. .env files), but these cases are rare compared to the normal search. Dotfiles are hidden for reason, one doesn't need them too often.
Now I tend to fall back to using rg in the shell because the new behavior adds too much garbage to the results (mostly from .git). I believe the proposed 'C-u' for '--hidden' is the right approach, but even if '--hidden' is going to stay as the default, it should at least be configurable via an option. At the moment it's hardcoded in +ivy-file-search. I'm not an elisp expert, but I believe with the current approach the only way to get rid of '--hidden' is to override the whole function.

My $0.02: On various occasions, I was confused because my CI configurations in .github/workflows/ (for GitHub Actions) weren't being searched - so +1 on using --hidden but ignoring VCS directories (like @robbert-vdh said, that's what I'd expect from a "project search" in a text editor or IDE).

I agree that --hidden plus a blacklist for common VCS directories (.git, .svn, .hg etc.) would be a good default.

ripgrep already reads .gitignore (even with --hidden), so I think things like node_modules would be covered (also, note that --hidden won't have changed anything about node_modules. While that's git-specific, it also reads .ignore which seems to be a standard between different search tools (also supported by e.g. ag).
Thus, I'd say the only thing which would need to be ignored by default with --hidden are directories which are hidden but not in a .gitignore by default - from what I can see, that means only .git. If you use another VCS, I think it's okay to assume you'd have an .ignore file to use search tools, and that file would then already contain .svn or so - but someone correct me if I'm wrong, I've used git wherever possible for the past 8 years or so.
Thus, I'd propose a commandline like ag ... --hidden --glob='!.git' - does that sound sensible enough, with my rationale about not including other VCS directories above? If so, I can try submitting a PR. If the commandline gets longer, I guess it'd make sense to share the commandline arguments between the two places somehow, but I don't speak enough Lisp to do that.

A temporary workaround for this that has been working for me is to add a /.git line to each project's .gitignore (from what I can see there aren't any side-effects of this, but I didn't do any actual research).

Sorry for the delay. As others have mentioned, there are dotfiles that we may want to search; particularly configuration files, but searching .git is unanimously undesirable, so I've omitted it explicitly. As of 51744ce this issue should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!


Change AccountService from Go to DotNet (auto)

Changes
Fixes #589
Changes AccountingService from Go to .NET service.
Uses OpenTelemetry .NET Automatic Instrumentation.
NOTE: It's a first preview of demo app that is instrumented with OpenTelemetry .NET Automatic instrumentation. Some parts are still TBD. Please review and add comments about improvements and missing parts / docs.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[x] CHANGELOG.md updated to document new feature additions
[x] Appropriate documentation updates in the docs
[ ] Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Example Jaeger traces:

CC: @lachmatt @Kielek Should parentless Kafka consume requests be filtered? Seems without additional context these just trash the output.

After removing EOF

@RassK Can you add a Chanlog entry for this? Also, we will need to update docs and the Helm chart for this. If you need help to prep a PR in those areas, please let us know.

@puckpuck thanks for helping to guide the last steps missing. I have updated the changelog. Would be glad to accept some help with other missing parts as well. It's my first PR to this repo.

LGTM, I think this can be merged as the PR to opentlemetry.io is ready.
As I understand, helm charts should not be affected. We are changing just one type of service to another.

We will need to bump up the memory for the service in the Helm chart, but nothing beyond that. We can merge this before having to do anything in Helm, since Helm is bound to a release and not nightlies.
I want to keep the label on this PR so we can track all items that need to be updated when doing our next release.

When I run this branch, I notice clock skews with the accounting service, which causes issues with the trace waterfall. I'm not sure what this service does differently than our other .NET service (cart), but we don't see the same clock skew there. @RassK can you take a look at this?

@lachmatt could you recheck that kafka instrumentation, I think that is the source of this issue.

@puckpuck So consulted with @lachmatt and we reached conclusion that it is not the issue with clock skew.
In the .NET the Kafka span's instrumentation start time is the start of the polling. Previously we had issues with the amount of spans, so every poll (even an empty one) created a span. Now as we by default filter such spans, I could lower the polling max timeout to default (100ms), so accounting service's Kafka consume spans could be now <100ms, which can be still huge compared to some other services reporting processing time around 1ms. The default setting now renders the Jaeger UI in more understandable way... but we cannot make the UI look more beautiful just because of the messaging behaviour, it still has to reflect the actual logic.
I see it more like Jaeger could improve theirs's UI by using more dynamic time axle and collapse big portions like this (10s wait time).
Here is the improved look >

@RassK wouldn't that be better handled in a linked span, instead of a child span?
We did that for fraudDetectionService.

@julianocosta89 that's unfortunately not configurable in auto instrumentation.

Something is wrong with the .NET SDK here. No other SDKs start the span when you start polling.

@puckpuck
I don't think this is related to .NET SDK, but rather Kafka client instrumentation library which is part of OTel .NET Autoinstrumentation.
Semantic conventions for messaging recommend to create receive spans for pull-based scenarios.
Most of the existing instrumentations for Kafka client are creating process spans, but these were problematic, as explained in OTEP, and in PR.

We should investigate doing this so the trace doesn't look like accounting service is starting before everything else, which looks like this should be done with a process consumer span. In its current state, this makes the consumption of the PlaceOrder trace very hard to do and will only raise questions from users about why the accounting service started before the request itself.

@RassK wouldn't that be better handled in a linked span, instead of a child span?

Creation context is used as a parent, in addition to being added as a link. This scenario is described in OTEP and was discussed when working on the instrumentation.

We should investigate doing this so the trace doesn't look like accounting service is starting before everything else, which looks like this should be done with a process consumer span. In its current state, this makes the consumption of the PlaceOrder trace very hard to do and will only raise questions from users about why the accounting service started before the request itself.

@pyohannes What would be the recommendation from Messaging SIG side in such scenario?

Creation context is used as a parent, in addition to being added as a link. This scenario is described in OTEP and was discussed when working on the https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/3055#discussion_r1399074286.

This part is correct: you can use the creation context both as parent and link in "Receive" or "Process" operations.
The problem lies more in the duration of the "Receive" operation, which also includes the time spent in polling (which technically isn't part of this trace). I see you achieve this by starting a span only after a message was finally received, but by explicitly setting the start time of the span to the start of the polling operation.
I'll put this on the agenda for discussion in this week's messaging SIG meeting. While what is happening here doesn't really violate the semantic conventions, I think the "Receive" duration should only start after a message was received from the broker. This would result in more meaningful traces.
I submitted https://github.com/open-telemetry/semantic-conventions/issues/1050 to track related discussions.

This was discussed in the messaging workgroup:

The duration of "Receive" spans should include the time spent for polling.
"Receive" spans by default should link to the creation context, but shouldn't use it as parent.

See a more detailed summary here.

I'll update the solution when a newer version of otel auto is available.

@RassK should we keep this PR as a Draft then?

@RassK should we keep this PR as a Draft then?

Sure, I have no preferences there.

Updated solution (OTel Auto 1.7.0) >

Hey @RassK it looks good, before approving would you mind explaining those log entries?
Accounting service started
[CORECLR_ENABLE_PROFILING, 1]
[CORECLR_PROFILER, {918728DD-259F-4A6A-AC2B-B85E1B658318}]
[CORECLR_PROFILER_PATH, /app/OpenTelemetry.AutoInstrumentation.Native.so]
[DOTNET_RUNNING_IN_CONTAINER, true]
[DOTNET_STARTUP_HOOKS, /app/OpenTelemetry.AutoInstrumentation.StartupHook.dll]

That's a quick startup diagnostics (by AccountingService.Helpers that filters relevant environment variables). Due automatic instrumentation is configured mostly by envs, then this could be helpful for a quick diagnosis.
Ideally a built in diagnostics (OTEL_LOG_LEVEL=debug) should do the similar but instead logs to the file.

I've updated the tracetest to reflect the change, hope you don't mind. 😅
This should be good to go, I'll just wait to see if any other maintainer/approver has something to say.
Thanks for taking care of it 🤩

Just need to increase mem limit in helm chart left? Can anyone help / explain where, I have had 0 connection to helm charts so far 😬

the Helm chart will not be updated till next version release.
If you want to update it, you can do the memory limit here:
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-demo/values.yaml#L165
Then you need to bump a minor version here: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-demo/Chart.yaml#L4
And last you need to run the: make generate-examples CHARTS=opentelemetry-demo.
You could also sync with @rogercoll and add it to his opened PR:
https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1232
Whenever you add it, you will still need to run the make generate command above.

I tested again, and all looks fine using a linked span here instead. I will make another PR so the frauddetectionservice goes back to creating a child span instead of a linked span. This will allow us to showcase both examples with a message queue.


Add bindgroup cache in wgpu

avoid recreating them every frame
closes #97

I've been meaning to test this PR properly since it's more involved than the widgets you've PR'd. I'll let you know as soon as I can and I'll have a good review for you!

Updated to main and clear the cache every frame to avoid dealing with invalidation for now.
Still huge wins. On my (now quite big) yakui scene with a bunch of text and textures tracy says update_buffers goes from 0.5ms to 0.1ms
Yakui's overhead is still 0.8ms (down from 1.2ms)

I wonder if the previous frame's paint data could be reused somehow but that's a whole new thing.

Also of interest: 95% of the wins come from the default texture and the glyph cache texture bindgroups. However the glyph cache is handled in yakui-widgets and therefore is not easily cached with a simple variable.


Add Result.requireTrue to take second parameter as a function

Currently Result.requireTrue takes second parameter as a value, would it make sense to add an overloaded version or new extension method to allow it to take a function. This can be used in following scenarios
let trn = con.BeginTransaction()
let! result = cmd.AsyncExecute() |> Result.requireEqualTo 1 (fun x -> trn.Rollback(); "Error executing.")
trn.Commit()

I think I need to use teeError.


Export functionality in .pdf

Laravel Version: 7.10.3
PHP Version: 7.4.4
Laravel-admin: 1.7.16

Description:
Hello there. I am using exporting data in .csv format, but also i want to add possibility to export in .pdf format. Is it possible? I checked the documentation but did not found any info about .pdf.
Steps To Reproduce:

Hi,
Here is another solution, you can add the package Maatwebsite /
Laravel-Excel (https://github.com/Maatwebsite/Laravel-Excel) to your project, it not only supports exporting to excel files, but also supports exporting pdf.
The above is my personal suggestion, I hope it will help you.

@chris-mao thanks for suggestion. I am using export functionality that comes with laravel-admin also it creates front-end functionality, generates button for export, filters for different amount of data and the problem is here that i can not setup this - add another format to the end file and possibility to choose in which format to download. But anyway thanks.

You are welcome. As far as i know, the export functionality of laravel-admin only supports CSV format currently.


[C] Fixes for Windows

This fixes various things on Windows, and makes the CMake build and tests pass with VS 2019.
Every commit message explains the introduced changes in more detail.

BTW would you accept a PR which adds a Windows CI, using something like GitHub Actions for instance (so it won't require you to setup any external account)?
If yes, would you like to also migrate the Linux CI from Travis to GitHub Actions for consistency?

Migrating to GitHub Actions is on my list of things to try. Travis has been very frustrating.

I've reverted so it can done in parts which are easily agreed.

Everything but the DllMain and the removal of aeron_free from the test are OK.


Presentation: Fix getting nodes when child specs use different vars

Fixes https://github.com/iTwin/imodel-native/issues/202.
Also, turns out our performance tests have been producing this issue for a while now:
INFO     Performance.RulesEngine   Ruleset: VisibilityTree.json
INFO     Performance.RulesEngine     Loaded all hierarchy with 3976 nodes in 18.10 s
INFO     Performance.RulesEngine     Loaded all hierarchy with 2 nodes in pages with cold cache in 0.16 s
INFO     Performance.RulesEngine     Loaded all hierarchy with 2 nodes in pages with warm cache in 0.02 s

The PR contains a change to perf tests to verify counts of nodes that we get when requesting them in different ways.

@mergifyio backport release/3.x


Applying YARN-1982

https://issues.apache.org/jira/browse/YARN-1982

Can one of the admins verify this patch?


Fix some crashes dealing with nil pointers

Fixes https://github.com/hashicorp/terraform/issues/8100

Looks great. Thanks!


[WIP] Replace hardcoded CarrierWave::Storage::Fog::File that causes crashes

Fixes #802
Hyrax should not have to sniff classes that are not included in its dependencies.

Thanks for taking this on, @atz.

@mjgiarlo ready

Thx, @atz!


Dev server doesn't update local plugin served in Zeplin

I scaffolded a project using zem init and now I want to use npm start, (ie: zem start) to have a hot-reloading plugin in Zeplin as I build.
Unfortunately, "Reload Local Extensions" appears to require that the manifest reports a different version number in order to actually reload.

Hey, Ashley!
Sorry for the late answer. Sadly, I couldn't reproduce the behavior where reloading local extension through Extensions -> Reload local extension menu item do not reload the local extension. In all my tries, I've been able to reload local extension by clicking to that menu item or pressing cmd + shift + r. Can you give more detail about the issue? (which app and version you are developing the extension, the source code of the example extension etc.)
Thank you.


translation of some sentences into French

Translation of some sentences into French

@hugo-syn
Please do not edit translation files manually! You translate here

@shuashuai
Can be closed too


popover should not cover the bubble menu

Describe the bug

To Reproduce

create a paragraph in editor middle place
select text
hover to turn into button
popover will cover bubble menu

Expected behavior
popover should be a scrollable menu and it can not cover bubble menu
Additional context
No response
Logs/tracebacks
No response

This issue has been fixed when adjusting popover behavior

Previously misunderstood, the menu expanded submenu should not obscure itself. It is mainly for aesthetic reasons, not an obstructive issue

Current popover capability limitations, need a new popover implementation, temporarily put this on hold


--Do not Merge-- Updated GCP IAM code to handle projects in batch processing

Required items, please complete
Change(s):

Updated GCP IAM code to handle projects in batch processing

Reason for Change(s):

Bug Fix

Version Updated:

N/A

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @devikamehra, @rushriva,
Can you please review and share your feedback.
Thanks

Hi @Devika, @rushriva,
Can you please review the changes and share your feedback.
Thanks

Hi @devika, @rushriva,
Can you please review the changes and share your feedback.
Thanks

Hi @anki-narravula - Thanks for reviewing the changes and feedback.
@mkchiliveri - Can you please accommodate the requested changes.
Thanks

Hi @VenkataPrathibha,
If you are done with all the changes please request for review.
Thanks

Hi @mkchiliveri,
Can you please confirm and request for review once you are done with the requested change
Thanks

Hi @mkchiliveri,
Can you please provide an update on this.
Thanks

Hi @mkchiliveri,
Please provide an update on this.
Thanks

Hi @mkchiliveri,
It would be great if you could provide an update on the progress.
Thanks

Hi @mkchiliveri,
It would be great if you could provide an update on the progress.
Thanks


_createDataStoreWithProps._createDataStoreWithProps

Eventually this API should be removed in favor of using DataObject flow.
But as a staging, we should at least change its return type from IFluidDataStoreChannel to IFluidRouter to disallow direct manipulations on it, including calling bindToContext().
All attachment processes should be automatic, not manual.
Please note that this is breaking change, so we might need to stage it properly.

Addressed in https://github.com/microsoft/FluidFramework/pull/4292


Add more metadata for stSOL

Add CoingGecko id (https://www.coingecko.com/en/coins/lido-staked-sol)
Add Coinmarketcap url (https://coinmarketcap.com/currencies/lido-for-solana/)
Add GitHub link to the contract that manages the mint (https://github.com/ChorusOne/solido)
Add invite link for the #solana channel of the Lido Discord

I can help resolve automerge issues.
Feel free to check out J-a-m-e-s-o-n/token-list#1


Remove subs-dummy module

Task/Issue URL: https://app.asana.com/0/488551667048375/1206887289998460/f
Description
Remove subs-dummy module
Steps to test this PR
NA, app builds

#4336  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Weird Chrome Disappear bug

Hey guys,
i have a weird bug with chrome and chartjs.
I try to explain the problem:
I have my Chart.js on Test.com. Then i opening in a new Tab an Image Test.jpg and i'll save this image. My Chrome makes on the bottom a Bar with "All Downlods".
Then when going back to my Chart.js Test.com. The Chart.js is invisible. Only happens, after Chrome creating own downoad Bar.
I dont know if this is a Chart.js or Chrome bug. I try to do  a fiddle in the next Minutes.
Edit1: In Fiddle this bug dont appear, i dont know why.
Edit2: I created a Test .html file where the problems appear every time:
http://pastebin.com/uSwXxexM
if i change from responsive true to false the problem dont appear, but the size of the chartjs then wrong.
Edit3: Here a upload of the Example: http://<IP_ADDRESS>/chartjs.html

I think the cause might be the position: relative. Try putting a div inbetween and see what happens

Inbetween where?

    <canvas id="mychart" width="100%" height="100%"></canvas>

no difference

Duplicate of #3185?

@Endzeitlive, see this comment, can you confirm that's fixed with latest Chrome?

@simonbrunel yes chrome 53 fix this problem. Thanks!


[Epic]: :scissors: Sequencer-prover separation

We want to split up sequencers and provers, as they are two different entities in the system. With the changes to block building, sequencers no longer need to upload a proof along their block to L1. Instead, provers group together multiple (32) blocks and submit a proof for several of them.
More context and discussion in this hackmd.
### Implementation
- [ ] #8210
- [ ] https://github.com/AztecProtocol/aztec-packages/issues/8716
- [ ] [prover] Update prover-node to schedule epoch proofs
- [ ] [prover] Update e2e tests to prove epochs instead of blocks
- [ ] [prover] Handle epochs with 0-1 blocks
- [ ] [prover] Remove the flow for block proofs
- [ ] #7925
- [ ] #8489
- [ ] #8490
- [ ] #8491
- [ ] #8493

### Tests
- [ ] Prover node can orchestrate proving of one epoch of blocks at 1 TPS (proving disabled first, enabled then)
- [ ] Prover node can orchestrate concurrent proving of N=10 epochs of blocks at 1 TPS (proving disabled first, enabled then)
- [ ] Prover node can recover from a crash in each of the four scenarios above without losing executed proving work

### Attic
- [x] Remove the proof and aggregation object from the L1 contract `process` method.
- [x] Have the L1 contract accept proofs in a separate method. Uploading a proof emits a `ProofSubmitted` event.
- [x] Remove the prover from the sequencer.
- [x] Have the `L2BlockSource` monitor `ProofSubmitted` events and track the last proven block number.
- [x] Tweak the `ServerWorldStateSynchronizer` so it can be configured to only process proven blocks, and to optionally fast-forward to a given block.
- [x] Tweak the `TxPool` so that, when it sees a tx included in a block, it persists it to a store so it can be later consumed from the prover node.
- [x] Create a new `prover-node` package that references the `prover-client`, `world-state`, and the public tx processor.
- [x] Implement the `prove(l2blockrange)` method on the `prover-node`, which should get the tx hashes to prove from an `L2BlockSource`, the individual tx objects from a tx db backed by a modified `TxPool`, process them using a `PublicProcessor` backed by a `world-state` pointed to the first block in the range, sends the jobs to the `prover-client`, and uploads them to L1.
- [x] Allow the `prover-node` to handle multiple simultaneous proving jobs by introducing a queue. The node should move onto the next job once the current one has finished tx processing.
- [x] Add a switch to the `prover-node` so it continuously proves unproven blocks in batches of N blocks.
- [x] Update the merge rollup circuits so they can accept txs from more than one block.
- [x] Update the merge and root rollup circuits so they output the block range proven.

Definitely not completed!

woops unsure how a release PR closed it sorry!

@spalladino @alexghr Is this epic still relevant? If so, is it up to date?


Node.js 16 actions are deprecated

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: softprops/action-gh-release@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This was fixed in #406. There is no tag yet containing this fix, but you can use it with uses: softprops/action-gh-release@4634c16e79c963813287e889244c50009e7f0981.

This was fixed in #406. There is no tag yet containing this fix, but you can use it with uses: softprops/action-gh-release@4634c16e79c963813287e889244c50009e7f0981.

Thanks for letting me know.


Can't install on ubuntu 12.04 lts

npm install command fails with :
 verbose raw, before any munging watchify
 verbose url resolving [ 'https://registry.npmjs.org/', './watchify' ]
 verbose url resolved https://registry.npmjs.org/watchify
 http GET https://registry.npmjs.org/watchify
 ERR! Error: failed to fetch from registry: ejs
 ERR!     at /usr/share/npm/lib/utils/npm-registry-client/get.js:139:12
 ERR!     at cb (/usr/share/npm/lib/utils/npm-registry-client/request.js:31:9)
 ERR!     at Request._callback (/usr/share/npm/lib/utils/npm-registry-client/request.js:136:18)
 ERR!     at Request.callback (/usr/lib/nodejs/request/main.js:119:22)
 ERR!     at Request.<anonymous> (/usr/lib/nodejs/request/main.js:212:58)
 ERR!     at Request.emit (events.js:88:20)
 ERR!     at ClientRequest.<anonymous> (/usr/lib/nodejs/request/main.js:412:12)
 ERR!     at ClientRequest.emit (events.js:67:17)
 ERR!     at HTTPParser.onIncoming (http.js:1261:11)
 ERR!     at HTTPParser.onHeadersComplete (http.js:102:31)
 ERR! You may report this log at:
 ERR!     <http://bugs.debian.org/npm>
 ERR! or use
 ERR!     reportbug --attach /home/<user>/websync/npm-debug.log npm
 ERR!
 ERR! System Linux 3.10.23-xxxx-std-ipv6-64
 ERR! command "node" "/usr/bin/npm" "install"
 ERR! cwd /home/<user>/websync
 ERR! node -v v0.6.12
 ERR! npm -v 1.1.4
 ERR! message failed to fetch from registry: ejs
 verbose exit [ 1, true ]

username was replaced by
I found this ticket with same error (related to raspberry pi though)
https://bugs.launchpad.net/raspbian/+bug/1480668

Ok, that was a npm version problem. I had to add repository :
curl -sL https://deb.nodesource.com/setup_0.12 | sudo bash -

(see http://doc.ubuntu-fr.org/nodejs )
The install could go further but fails after :
npm WARN install Couldn't install optional dependency: Unsupported
npm WARN install Couldn't install optional dependency: Unsupported
npm ERR! Linux 3.2.0-91-virtual
npm ERR! argv "node" "/usr/bin/npm" "install"
npm ERR! node v0.12.7
npm ERR! npm  v3.3.5

npm ERR! Cannot read property 'localeCompare' of undefined

Maybe another version problem

New try after updating node.js through npm
New error
npm WARN install Couldn't install optional dependency: Unsupported
npm WARN install Couldn't install optional dependency: Unsupported
npm ERR! Linux 3.2.0-91-virtual
npm ERR! argv "/usr/local/bin/node" "/usr/bin/npm" "install"
npm ERR! node v4.0.0
npm ERR! npm  v3.3.5

npm ERR! Cannot read property 'localeCompare' of undefined

Are you sure you tested install on bare Ubuntu 12.04 ? : p

Yes I am very sure :P

i have these problem too.

Yeah, doesn't work on basically any distro including newer ones. Always ends up with errors because the install processes uses 2-4 year old dependencies.


Bump the 4.10 version to latest stable

Which issue this PR addresses:
This version should include the fix for: https://access.redhat.com/solutions/6844091.  Additionally, bumps the default install version to latest stable 4.10 version.
What this PR does / why we need it:
Note: we have to maintain the 4.10.40 version as a valid install target until the RP is rolled out.  We have to do that since we need to run the update_ocp_version pipeline first.  We have to run that first because there's a discrepency in the way the backend and frontend handle the default version.

The frontend will always ensure the default version is available for consumption, even if it's not present in the database
The backend will allow the default version as a valid target if and only if there are no versions in the database, therefore since there are versions in the database already, we have to maintain "backwards" compatibility until it's fixed.

Test plan for issue:
e2e tests
Is there any documentation that needs to be updated for this PR?
Nope

We don't actually have to run update_ocp_versions first, but still probably should if https://github.com/Azure/ARO-RP/pull/2743 is merged in.


Create pi-actuator.hi.md

Kindly change rat ki Roshni to nightlight or रात का चिराग़ or something more understandable and comfortable

Sorry @AdityaGarg00, By mistake your previous review got dismissed because of adding another PR as I was unaware of split or unified PR.


licenseplate detection  tests poorly in my dataset

@HouBiaoLiu  Obviously, the data distribution is not the same.


feat: added poseidon2 hash function to barretenberg/crypto

Preliminary work to add Poseidon2 hash function as a standard library primitive (https://eprint.iacr.org/2023/323.pdf)
Adds Poseidon2 to crypto module, following paper + specification at https://github.com/C2SP/C2SP/blob/792c1254124f625d459bfe34417e8f6bdd02eb28/poseidon-sponge.md
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
Metrics with a significant change:

circuit_simulation_time_in_ms (base-rollup): 2,085 (+18%)
l2_block_processing_time_in_ms (32): 8,753 (+17%)
l2_block_processing_time_in_ms (128): 34,443 (+17%)
note_trial_decrypting_time_in_ms (32): 39.0 (-43%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 6c20b459 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,948
868,172
3,449,480

l1_rollup_execution_gas
842,035
3,595,280
22,204,849

l2_block_processing_time_in_ms
2,318 (+15%)
:warning: 8,753 (+17%)
:warning: 34,443 (+17%)

note_successful_decrypting_time_in_ms
291 (-2%)
824 (-4%)
3,012 (-4%)

note_trial_decrypting_time_in_ms
91.0 (-11%)
:warning: 39.0 (-43%)
137 (+2%)

l2_block_building_time_in_ms
14,655 (+11%)
58,096 (+12%)
232,530 (+12%)

l2_block_rollup_simulation_time_in_ms
13,332 (+13%)
52,843 (+13%)
211,235 (+13%)

l2_block_public_tx_process_time_in_ms
1,284 (+1%)
5,132 (+1%)
20,833 (+2%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
24,642 (+14%)
48,131 (+14%)

note_history_successful_decrypting_time_in_ms
1,842 (-8%)
3,586 (-8%)

note_history_trial_decrypting_time_in_ms
120 (-2%)
144

node_database_size_in_bytes
1,631,485
1,096,097

pxe_database_size_in_bytes
27,188
54,187

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
82.1 (+14%)
61,697
18,841

private-kernel-ordering
50.6 (+16%)
24,233
8,089

base-rollup
:warning: 2,085 (+18%)
656,309
811

root-rollup
89.4 (+15%)
4,072
1,097

private-kernel-inner
58.8 (+11%)
81,504
18,841

public-kernel-private-input
46.5 (+12%)
41,455
18,841

public-kernel-non-first-iteration
28.8 (+9%)
41,497
18,841

merge-rollup
0.877 (-1%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,723
27,240

Since the poseidon code is not comformant with the reference implementation, it probably makes sense to thoroughly review the changes outside of the poseidon2 module and the API of poseidon2.
Once we make poseidon2 conformant with a chosen reference implementation using test vectors, then it will become glaringly obvious if the implementation is "correct".
@zac-williamson what are your thoughts?

Would also say that while its not conformant we likely don't want to integrate it into other parts of the system as it may cause breaking changes once we make it conformant

Would also say that while its not conformant we likely don't want to integrate it into other parts of the system as it may cause breaking changes once we make it conformant

Yes I agree. I think we should get all of the hash structures implemented and working (i.e. have stuff in the stdlib, ideally also have ACIR opcodes working), but to not actually use Poseidon downstream until we've made it conformant

Since the poseidon code is not comformant with the reference implementation, it probably makes sense to thoroughly review the changes outside of the poseidon2 module and the API of poseidon2.
Once we make poseidon2 conformant with a chosen reference implementation using test vectors, then it will become glaringly obvious if the implementation is "correct".
@zac-williamson what are your thoughts?

I think this works and should be plan A, but it works only as long as we can get independent test vectors. The best I can find use t = 3 and we have t = 4. We might have to collaborate with another team to get an independent implementation that we can compare against

Can we try using an existing implementation with t=3, and modify it so that it uses t=4?


sam2 image ml backend installation error

Is anyone else getting an issue when trying to set up sam2 image ml backend?
I get this after I modify model.py to match my checkpoints and other environmental variables.
(test-environment) % label-studio-ml start ./segment_anything_2_image
Traceback (most recent call last):
  File "/media/***/sam-2-test-v2/label-studio-ml-backend/label_studio_ml/examples/././segment_anything_2_image/_wsgi.py", line 33, in <module>
    from model import NewModel
  File "/media/***/sam-2-test-v2/label-studio-ml-backend/label_studio_ml/examples/segment_anything_2_image/model.py", line 12, in <module>
    from sam2.build_sam import build_sam2
  File "/media/***/sam-2-test-v2/label-studio-ml-backend/label_studio_ml/examples/segment_anything_2_image/sam2/sam2/build_sam.py", line 25, in <module>
    raise RuntimeError(
RuntimeError: You're likely running Python from the parent directory of the sam2 repository (i.e. the directory where https://github.com/facebookresearch/sam2 is cloned into). This is not supported since the `sam2` Python package could be shadowed by the repository name (the repository is also named `sam2` and contains the Python package in `sam2/sam2`). Please run Python from another directory (e.g. from the repo dir rather than its parent dir, or from your home directory) after installing SAM 2.

Rename sam2 directory (the one you git cloned) to segment-anything-2.


[P3] Fix whitespace consistency in JavaScript + CoffeeScript

Summary
Our ESLint config uses the Airbnb JavaScript style guide, which requires two-space indentation instead of tabs. Many files are still using inconsistent whitespace, which is dangerous in CoffeeScript (which is whitespace-sensitive).
Let's use the linters to automatically resolve this, and then enable linting for files which are currently ignored in ESLint or CoffeeLint.
See .eslintrc.json, .eslintignore, coffeelint.json, and .editorconfig.

JavaScript linting done in #160.
CoffeeScript linting has a few paths forward:

Manually fix things based on the output from CoffeeLint (which can't automatically fix things)
Upgrade CoffeeScript to 2.5.0+ and use eslint-plugin-coffee
Push forward on #4 to remove CoffeeScript entirely

Will take a look at these in this order.


USB passthrough

https://qemu-project.gitlab.io/qemu/system/devices/usb.html
Is it possible to passthrough USB devices? This is a common requirement for developing really hardware and something QEMU supports well. It's also some WSL currently lacks ☺

QEMU doesn't seem to support USB passthrough for macOS hosts

Funny enough, I couldn't a good USB device for passthrough. But I was able to verify with a USB Serial device on an Intel macOS. For example, I passed in -chardev serial,path=/dev/cu.SLAB_USBtoUART,id=esp32 -device usb-serial,chardev=esp32 and was able to communicate with the device from the guest.
Is there a way to pass QEMU flags in the config?

Is there a way to pass QEMU flags in the config?

It is only meant for debugging, but you can stuff additional arguments into QEMU_SYSTEM_X86_64, e.g.
QEMU_SYSTEM_X86_64="qemu-system-x86_64 -display cocoa" limactl start


[Task] Add documentation for Mongo form

Create usage reference for each field
Add examples for which use cases are solved, and which ones are not

@mohanarpit @ayushpahwa Hey team! Can you please add your planning poker estimates with ZenHub

@nidhi-nair can we close this, since the doc now shows usage wrt the form : https://docs.appsmith.com/datasource-reference/querying-mongodb ?


Add light size to Sky Shaders

This allows Sky Shaders to access the DirectionalLight3D's size from within the shader. This also modifies the ProceduralSkyMaterial and PhysicalSkyMaterial to use LIGHTX_SIZE instead of a uniform or fixed size respectively.
I also removed the awkward blue/brown gradient default sky at reduz' request.

Thanks!


Artist tag will return false positive if the name is short and "generic" enough

Steps to recreate:

Go to "Manage Tag", tab "Artist" and select (in my case) "sen"
Cross check with <nhentai.net/artist/sen>

The tag will also list results which title/circle contain the substring "sen"
The same bug can be triggered if you go to the doujin "Ame Ni Yadorite" (nothing special, the only doujin by sen that I remember the name) and click "sen" in the artist tag

Now it works on 1.9.1, but only if you only have one tag and you select all languages


Close previous listener port when mssql_ha_firewall_configure: true

[citest pending]

[citest pending]

When working on this functionality, a bumped into an SQL Server limitation - it is not supported to change the LISTENER PORT of a configuration-only replica.
I tried running the following query on the primary replica to alter AG to update the port number for a configuration-only replica:
      ALTER AVAILABILITY GROUP ag1 MODIFY REPLICA ON
        N'kvm-02-guest02' WITH (
          ENDPOINT_URL = N'tcp://[kvm-02-guest02.rhts.eng.brq.redhat.com:5033](http://kvm-02-guest02.rhts.eng.brq.redhat.com:5033/)'
        );

This resulted in this error:
Msg 47112, Level 16, State 1, Server kvm-01-guest25, Line 89
Only the SESSION_TIMEOUT property can be modified for a configuration-only replica.

I confirmed with MS folks and such functionality is not supported. When users need to change a port, they need to re-create the AG.
MS folks also told me that this is not a common scenario, and they didn't have customers who needed such functionality. #91 would add a note about this to the README.


enhance nav bar and footer

nav bar and footer are very basic and there is also text alignment problem @maniyaom pls assign me this

@Amankr200 Both are in progress; I've already assigned these issues to other contributors. You can work on any other issues on the website.

please assign me with this task @maniyaom

Feature Description:
Can make a better by enhacing nav-bar and footer
Provide a detailed description of the feature
By adding the better nav-bar and footer  that  enhances the UI and glow of website were website becomes more user friendly.
Please assign this to me , I am ready for this
Thankyou!
By submitting this issue, you agree to
I agree to follow this project's Code of Conduct
I’ve read all the issues in the issue section,
Other Information

[ ]  I'm a GSSoC '24 Extended contributor
[ ]  I'm a Hacktoberfest '24 contributor
[ ]  I am willing to work on this feature


When the default export is a function, other exports are undefined

I'm running into an error when importing redux, and am not sure if this is the right place to report it, but it's my best guess.
The commonjs version of redux code is exporting both a function(default), and another property.
When importing using rollup, the function is there, but the property is undefined.
When importing using Browserify, it's returning the function with the property tacked onto it.
Here's what the code in question is doing:
main.js
var test = require("./test.js");

console.log(test.one); // undefined  -   expected:1

test.js
exports.one = 1;
exports.default = function(){};

@Ryan-McMillan Try 3.2.0 release.