404 when using --web

With the --web adapter it happens that we get 404 because it might be just too fast for some hosters to create the file and access it through the web near-instantaneously.
I guess this is related to their storage and file system caches, maybe also PHP stat cache?
Current workaround: It will usually succeed after some tries...
./cachetool stat:clear --web=SymfonyHttpClient --web-url=https://.../ --web-path=./public/ --web-host
It is currently holding us a bit back on systems where we can't use --fcgi.
Splitting this off from #199 which is about retrying the whole procedure which can probably mostly be avoided in this case.

This patch mostly succeeds with executing commands now (stat:clear and opcache:reset).
Yet our problems (post-symlink-switching-deployment PHP thinks some files are there which are not) remain and are well described by the linked article by Julien Pauli in the README. It is about the PHP realpath cache most probably.
Yet there is one catch with what is written in that article: I do not have any problems with the realpath/stat cache on systems where I can use cachetool with --fcgi - this seems to catch all php-fpm threads. Can somebody confirm that?
Unfortunately on those 2 problematic hosters we do not have access from the web container to the php-fpm socket/port.
It can be explored by looking at
<?php
var_dump(realpath_cache_get());
clearstatcache(true);

which shows how that cache is thread-local and cache-clearing only acts on the current thread. (On some systems it is necessary to send No-Cache headers (by using CTRL+F5 to reload)).
So I am a bit at a loss here.
Should we say that not having the possibility to use --fcgi means that deployment using symlink-switching is not doable in a stable way?
Is anybody aware how someone could deactivate the PHP realpath cache?

Should we say that not having the possibility to use --fcgi means that deployment using symlink-switching is not doable in a stable way?

This is very likely.
Can you run the following command and display the results?
cachetool php:eval -vvv -r \
  'return var_export([ini_get("realpath_cache_size"), ini_get("realpath_cache_ttl"), ini_get("open_basedir"), ini_get("safe_mode"), ], true);'

Is anybody aware how someone could deactivate the PHP realpath cache?

It's not a good idea to deactivate the cache, but for testing you can always set
realpath_cache_size=0
realpath_cache_ttl=0

Thank you.
For the shared hosting in question (Hetzner Level 19) this shows:
https://gist.github.com/jonaseberle/996d2a7dc930f89b2241bdef9706c3b7
I looked into deactivating the realpath cache: Unfortunately that's not possible on that shared hosting because the realpath_cache_.. settings are php.ini only and only some select values from php.ini (plus all that are changeable via .htaccess php_value_...) are configurable.
It would of course be possible to clear the realurl cache at runtime in the application. <- This is an option we consider to do for the default 120s cache lifetime after a deployment.


broot: 1.2.9 -> 1.3.0

Motivation for this change
package update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121012 at 493a8e41 run on aarch64-linux 1

1 package built successfully:

broot

1 suggestion:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '"/bin/' doesn't match anything in file 'src/verb/builtin.rs'
Near pkgs/tools/misc/broot/default.nix:73:0:
   |
73 |     description = "An interactive tree view, a fuzzy search, a balanced BFS descent and customizable commands";
   | ^


style: 💄 simplify coloured banner using negative margin values

Description
I'm in the proces of making the landing page for Sprout and I was (re-)annoyed with how complex the css for creating a coloured banner ended up, when I created the landing page for Seedcase.
So I looked into it again and found a simpler and (in my opinion) better solution 🥳
Note: I will create a PR using this in the seedcase-website repo, since the landing page will be broken by removing landing-page-banner and landing-page-banner-content.
Reviewer Focus

This PR needs a quick review.
Focus on CHANGES.
Checklist

[X] Rendered website locally

I will merge this without reviews, so I can use these changes in an upcoming PR.


Implement pretty anchors

In DevSite, I can just use the following syntax to define an explicit anchor for each section:
## Name of section {: #name }

And then you link to that section via https://example.com/page#name.
Jekyll just auto-generates section anchors from the text, which often creates really ugly and long anchors. Also, if you change the text, the anchor fragment is no longer valid. This is a big problem for me, because I do change the text often, and I often link directly to sections for maximum usability

Does the above not work at the moment?

Just looked into this and you need to add a new line to do this
## Name of section
{: #name }


Error 404 while fetching file: Not Found

Hi !
I'm using phpdoc 2.8.1 version. When I generate documentation, I can't see the file description. I can see this error "Error 404 while fetching file: Not Found"
If I watch in my fireBug, I can see that "NetworkError: 404 Not Found - http://domain/job/Trombi Tumblr/javadoc/files/Appli/Bundle/TumblrsBundle/Controller/TumblrController.php.txt". So the file is not generated.
How can I fix that ?

The problem can be solved by making a change to Twig.php - see #1461, and making the following change to file.html.twig, class.html.twig and interface.html.twig in the template directories (based on clean)
At the bottom of each file you will see the following block

The path name needs to be filtered to handle space characters to create a valid URL.

Note that I've seen suggestions about applying the URL Twig filter, but I've found this causes problems with handling the "" character with references to %2F in file names.  With #1461 implemented, the correct folder structure is generated for the source files.

I am sorry to close this issue in favor of #1461; I am pruning the issue list and having duplicates will impact the amount of time spent


Line wrapping in composer does not adjust when window is resized

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Type a message that's multiple lines long.
Resize your window to increase or decrease the number of lines that are required to display the message

Expected result:
The height of the composer should dynamically adjust to show the full message (up to the existing max height of the composer component).
Actual result:
The message is clipped and because the height of the composer does not adjust.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  1.2.68-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675896812677069
View all open jobs on GitHub

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01bbf9fa7b286f05cb

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

Going to look into this one!

Love the quick turnaround here @francoisl @rushatgabhane @puneetlath 👏🏼

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.70-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15020

If no regressions arise, payment will be issued on 2023-02-20. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rushatgabhane / @francoisl] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rushatgabhane / @francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rushatgabhane / @francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@rushatgabhane] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sorry for the delayed payment! @rushatgabhane fyi I invited you to the Upwork job, please accept when you have a moment.
@rushatgabhane @francoisl could you please help complete the BugZero checklist in the previous comment?

Proposed in Slack updating TestRail steps.

I went ahead and paid out the contract.
Before closing this GH issue, we still need to complete that BugZero checklist above, and I'm still waiting for feedback in Slack around proposed regression steps.

@rushatgabhane @francoisl could one of you please help finish the checklist? I'd love to close this issue out.

The team didn't agree on regression steps, so I'm going to go ahead and close out.


Made transcript output to a text file

Trying to print transcript in console gave encoding errors so to avoid
it I made it so the transcript prints out to a file called log.txt

I realize you could pipe it, but I was on a Windows machine so. shrug

Thank you very much for your contribution. But I don't think I can merge it; I would like my tools to work consistently within the UNIX philosophy, hence I'd prefer them to deal with I/O from standard input/output instead of dealing with files directly.
(I realize this is inconsistent with the design of some (though not all) of the scripts in this repo. To that end, I can only say that I would prefer to remove the file I/O from them, not add it to this one.)


Make grid-based simulations easier to do

A lot of models will be fundamentally about a grid of a map, with each cell in some collection of states. We should make those much easier. #15 and #20 are related

And we also want it to be easy not only for grids, but also agents.
There should be a notion of cells. Each cell has user-definable properties, and these might change.
There are also a list of agents. These are items that at each time step will be asked to update themselves.
Agents will typically have a row/column location of where they currently exist.
There is logic that goes through and for each agent dispatches to a method on the simulator called TYPENAMETick (e.g. spiderTick) that is provided the agent blob and the state of the whole other map at that moment. If it wants to change the agent, it should clone the object, tweak it, and return that. So then tick() will go through each agent in turn, and ask each agent to tick. If there is no specific override, it will call agentTick() which is a generic catch all override point that does nothing by default.
Then the frame will also be given a two-d grid of cells, where each cell has agents: which is a list of agents that are currently in that cell, as well as values: which is the underlying values of the cell. That two-D grid is actually pointers back into the same objects in the canonical grid for convenience.

Make a simple game like agent-demo or something that has ants walking around and seeking out food

there should be helpers for e.g. finding the direction of the cell with the highest rank on some custom function within some area of drop off

2D rectangular grids should just be a special case of a general graph structure.
There should be a Graph type that has getters for adjacency of different cells to other cells. The structure is a list of edges:
{
  from: 'point1',
  to: 'point2',
  //Optional, defaults to 1
  strength: 1.0,
  //optional, defaults to 'point1:point2',
  id: 'point1:point2'
}

If there are duplicates of from/to, the last one is waht will be used.

If all graphs are the same type of graph, even rectangular ones, then that allows us to do generic graph adjacency, e.g. Graph.neighbors(nodeOrID, ply). And also do things like BFS, A*, etc.

[ ] Create RectangleGraph
[ ] Test RectangleGraph

A RectangleGraphRenderer, which knows how to render a RectangleGraph, with override points for different types of nodes and a generic node renderer.
An AgentElement that is given an agent, and can be positioned, with logic to select an emoji, and rotation and opacity that can be driven off of each agent.


Document performance benchmarks

Document all the performance benchmarking including how to run Jenkins.

https://github.com/frmscoe/docs/pull/85
https://github.com/frmscoe/docs/pull/81
Task completed.


prominence presentAudio=False

When the presentAudio false is set to False on a prominence page, it fails to advance.

Thanks for the heads up!  This should be fixed now in version 2.5.5: https://github.com/timmahrt/LMEDS/releases/tag/v2.5.5
Please let me know if it resolves your issue.

Thanks, Tim!  We thought it was fixed (it was working great on the local server), but now that we're upload it to nearlyfreespeech we get a 500 error.  I checked permissions for .cgi file, output folder and individual sequences folder.

You should have a folder tests/<<experiment_name>>/output/<<sequence_output_name>>/ and it needs to have permissions 777. I had to make that change to be able to progress.

It that still doesn't work and you're comfortable doing so, you can send me your whole lmeds folder (with just a representative sample of your test folder) and I can try to run it on my account.

I double-checked and that directory had the right permissions also.  Thanks for the offer to share!  Here's a copy with all but a few of the items removed.  https://drive.google.com/file/d/13u-VjVEXn5eBUL5swB4E8vLjbryhZmZs/view?usp=sharing

I've requested permissions to access it.
One more question: did you overwrite your previous /lmeds directory or did you start from a clean folder.  If you overwrote your previous /lmeds directory, its possible that there is some conflict between old and new files that causes the problem. It might be worth trying from a clean folder, if you haven't yet already.

After changing the permissions on the cgi file and the output directory, I was able to run the experiment snippet until the end. Hmmmm

Can you try using this sequence file?
https://drive.google.com/file/d/1pTDUQ0bXmWICkGGZpOA4KfvvIXnuC78a/view?usp=sharing
You may need to adapt it a bit for your experiment.  With this file, if there are any errors, they will be dumped to /tmp/lmeds.log which I was able to access on my server.  In the logs folder, there was already a log file I hadn't seen before which had some error information that probably would have been useful if I had checked it at the time (it was called nfsn_cgi.log).

It works!  What's different?

The new sequence file works?  It shouldn't have fixed anything, I just added some logging to it.
I guess that either your original cgi file was modified and broke things or the previous permission error was cached and still being displayed even though the root problem was resolved.  🤔


Updated documentation for operations

The documentation did not previously include the proper path
for operations. This was updated along with the updates to
path cache information.

[Current coverage][cc-pull] is 32.27%

Merging [#172][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #172   diff @@
==========================================
  Files            35         35
  Lines          1878       1878
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            606        606
  Misses         1206       1206
  Partials         66         66

Powered by Codecov. Last updated by [22292c9...570da33][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/libstorage/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/libstorage/compare/22292c9c129d8bd26f64593a611ad520e912005f...570da3349bea03c027e81a79bb5145afc2ffc06e
[cc-pull]: https://codecov.io/gh/emccode/libstorage/pull/172?src=pr


(doc) Remove explicit final modifier

https://maven.apache.org/shared/maven-filtering/pmd.html#org-apache-maven-shared-filtering-filteringutils-java

As for

Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.

I got:
[WARNING] The requested profile "run-its" could not be activated because it does not exist.

Following this checklist to help us incorporate your
contribution quickly and easily:

[x] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without
pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [MSHARED-XXX] - Fixes bug in ApproximateQuantiles,
where you replace MSHARED-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[ ] In any other case, please file an Apache Individual Contributor License Agreement.

@pzygielo Thanks, didn't even know that final is implicit here.


feat: specialist url updates - LESQ-504

Description
Music year: 2007

Adds url config for specialist routes

Issue(s)
Fixes #
How to test
This cant be tested atm, the specialist pages do not exist.
Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.323.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add a simplemap.json that only maps keywords to characters

For modules that get shipped to the browser, emojilib can be quite hefty (~128k uncompressed). :weary:
This adds:

A simplemap.json file that simply maps keywords to characters. It's 20k (~15% of the original uncompressed size).
A small build script that builds simplemap.json using emojis.json as the source.
An npm task npm run build to kick off this build task.
An npm task for the prepublish lifecycle event that gets kicked off when the module is published.

This is the way I personally would do things, but I'm totally understanding if you don't think this belongs or could be implemented differently. The simplemap.json file could be gitignored if you don't want accidental modification or contributions to that file, since it's generated anyway. If bower has a similar lifecycle event we could add the build step there too (but I don't think it does since it doesn't even have a publish step since it works over git -- boo :ghost:)
Either way, thanks for the amazing module :tada:

quick followup! here's the savings on the gzipped counterparts:
$ cat emojis.json | gzip -9 | wc -c
   21540

$ cat simplemap.json | gzip -9 | wc -c
    6718

So about 69% savings over the original for this usecase :smile_cat:

Sorry for the late response, this is how I'd do it as well. Thank you so much!


feat: support for scheduled functions

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Please open an issue first for new features so we can discuss the problem we are trying to solve and how we want to solve it.
A few notes on this particular PR, separate from that:

We use camelCase for externally visible APIs, not snake_case.
Conversely, we use snake_case for internal APIs and variable names, not camelCase.
@netlify/functions should not be a required peer dependency of this adapter.
You checked the box indicating that you included a changeset, but there is no changeset.

@Conduitry Sorry for the mistakes, this is my first time contributing to a major open source project.

I am working on opening an issue about the problem, but the rough idea is to add support for Netlify scheduled functions in the @sveltejs/adapter-netlify.

I believe I have fixed the snake_case and camelCase issues, but I may have missed some.

@netlify/functions should not be a required peer dependency of this adapter.

I will check if it is possible to do without it, but I was running into issues with Netlify when schedule wasn't directly imported from @netlify/functions. Perhaps re-exporting it from @sveltejs/adapter-netlify could work as a workaround.

I accidentaly didn't initially push the commit containing the changeset. This should now be fixed.

@Conduitry Sorry for the mistakes, this is my first time contributing to a major open source project.

I am working on opening an issue about the problem, but the rough idea is to add support for Netlify scheduled functions in @sveltejs/adapter-netlify.

I believe I have fixed the snake_case and camelCase issues, but I may have missed some.

@netlify/functions should not be a required peer dependency of this adapter.

I do not think this is possible. Netlify seems to only detect a function as scheduled if it is wrapped in the schedule function imported directly from @netlify/functions. Based on my experiments, re-exporting it or bundling it seems to prevent correct identification from Netlify.

I accidentaly didn't initially push the commit containing the changeset. This should now be fixed.

This would need to update the README.md for adapter-netlify. It's hard for me to understand this PR without docs or a corresponding issue describing how it would be used
Also, you will need to run pnpm format to fix the lint failure

@Samuel-Martineau you haven't responded to any of the comments here. Are you still interested in pursuing this?

@benmccann Sorry for the delayed response, I was away from my messages for personal reasons. I still think that it would be very interesting for Svelte Kit to have built-in support for scheduled functions on compatible platforms, but I don't have a lot of experience with open-source software and I am unsure what the next steps should be. This would require a new convention and modifications to most adapters, this PR was just an experiment of a Netlify prototype.

My suggestion would be to have something like a special src/+cron folder that would contain folders whose name are cron rules. Each folder would contain a +server.js with a POST endpoint to be executed at the schedule time.

Ah, I see the issue you created now: https://github.com/sveltejs/kit/issues/10477. Thanks for the details


Make includes directory configurable

This implements the possibility of configuring the includes directory proposed in #111:

Adds a new --includes CLI option.
Adds site.options.includes.
Adds site.includes(), similar to site.src().
Replaces the hard coded include paths with site.includes().

@oscarotero, what do you think? Do we need this?
We should also decide what should happen if the specified includes directory doesn’t start with _ (or .). Should we throw an error or just ignore the directory (like site.ignore(site.includes()))?

Nice approach. One thing that I have thought about was including the possibility to configure different includes. For example, it may be more practical for some users if the css files are in /_css instead _includes/css, and the same for layouts, etc. This requires to have this option at the plugin level, not site level. For instance:
site.use(postcss({ includes: "_css" });

In fact, it's something already implemented for postcss, but not other plugins like nunjucks, eta or pug.
I think this is a more flexible solution. The plugins can have the _includes folder by default (and maybe this folder can be configured in the site, using your changes here), but with the possibility to change them.
To me, the --includes argument in CLI is a bit excesive, I can't think of a use case for that.
About the directories that doesn't start with _ or ., good point.

I think site.ignore(site.includes()) is an easy and clean solution.
But, in the other hand, the user may not want to ignore this folder for any reason:

Because the includes files is in a subdirectory
Because she want to reuse a page as a template (crazy idea)
Because mixes pages and layouts in the same folder, and use _ to ignore the layouts. For example:pages/
  page-1.md
  page-2.njk
  _layout.njk

So, maybe the best approach is doing nothing? Just include in the documentation a text indicating that the includes folder/files should be ignored someway.
What do you think?

I agree the --includes option is probably useless, so I removed it. I’m fine with doing nothing with include directories not starting with _ or ..
It’s good idea to have the includes option at the plugin level too. For example, should I

add a new argument to Nunjucks template engine’s constructor that contains the includes directory
// plugins/nunjucks.js:17
const nunjucksEngine = new NunjucksEngine(site, options.includes, options.options);

// engines/nunjucks.js:7
constructor(site, includes, options) {

pass the full includes object to the constructor that contain both options.includes and options.options?
// plugins/nunjucks.js:17
const nunjucksEngine = new NunjucksEngine(site, options);

// engines/nunjucks.js:10
const loader = new nunjucks.FileSystemLoader(options.includes);
this.engine = new nunjucks.Environment(loader, options.options);

Probably, I'd create the nunjucks instance out of the NunjucksEngine constructor. I like the idea of having the engines as much light as possible, so they can be reused with a custom instance if you want (for example, creating your different nunjucks plugin but reusing the same engine).
This is something that I did with markdown engine: https://github.com/lumeland/lume/blob/master/engines/markdown.js (the markdown-it instance is created in the plugin file and passed to the engine in the constructor).

Okay, I’ll try that later, but feel free to push commit(s) here if you like.

Added a plugin-level includes option for the nunjucks and eta plugins, but not really for pug, because the include path is set in the engine instead of the plugin.

Nice! I just commited a change to configure the pug engine, including the basedir (includes) from the plugin.


🐛 Constant ordering for agent args

Summary
This PR makes the manager use a constant ordering for the agent's command line flags. Before this, it was non-deterministic and the manager was thrashing the agent Deployment object badly.
Related issue(s)
Fixes #

In my own testing this stabilized the Deployment object. I ran the E2E test then started watching that Deployment object in the managed cluster, and have seen no changes.


Folia support

SimpleVoiceChat supports Folia
LibertyBans supports Folia
So, it would be natural if this plugin also supports Folia

Folia support is available on the master branch as of 8075ea4. If you know how to compile plugins using gradle, feel free to experiment with it.


Nit: French date format off in app

The strftime result in the app is off for French. Instead of:
Samedi 27 Février 2016 le
it should read more like:
Samedi, le 27 Février 2016

@pierresauvignon found this one, maybe quick to fix...


A better structure?

I'm a little bit confused by subsections Secure Deep Learning and General Research - I think it would make sense to split the awesome-list subsections into current research directions. I propose to split it up into following research directions (partly inspired by the Berkeley view Section 4.2)

Secure Enclaves / Trusted Hardware
Differential Privacy
Adversarial Learning
Kryptographie
Shared Learning on confidential data

What do you guys think?

I think restructuring could make the list easier to understand. The reason secure deep learning is separated out from the rest of the research is because that is the main focus of this list and having easy access to those papers is important. Splitting up the research section would make it easier to find papers by topic class but we should make sure to keep the secure dl stuff front and center.

Thanks for the response, I am curious about the difference between Secure Deep Learning and papers in General Research such as The Secret Sharer: Measuring Unintended Neural Network Memorization & Extracting Secrets and Differentially Private Generative Adversarial Network ? I might be mistaken but are you referring to Secure Deep Learning as used by OpenMined?

So the secret sharer paper is more on a theoretical level for describing how neural networks, encrypted or not, leak data. It is not a secure deep learning implentation. The dpgan paper is also on model memorization and not on train on secure data. Typically secure deep learning refers to running deep learning models on data which the model cannot see in plaintext

I see! Would it make sense to rename secure deep learning into encrypted deep learning and have it on the same level as all subsections? I am concerned that it's not a good idea to emphasize one research direction (secure deep learning) from others (e.g privacy-preserving deep learning)


New package: GSDFormat v0.1.0

Registering package: GSDFormat
Repository: https://github.com/ywitzky/GSDFormat.jl
Created by: @ywitzky
Version: v0.1.0
Commit: 4a663606dc8d738a7610f4ac45616ef7104328be
Reviewed by: @ywitzky
Reference: https://github.com/ywitzky/GSDFormat.jl/commit/4a663606dc8d738a7610f4ac45616ef7104328be#commitcomment-143726718
Description: Wrapper of GSD file format

Pull requests #109760 and #110148 can be closed if this gets accepted. They are duplicates before name change

[noblock] I've closed the other pull requests, although https://github.com/JuliaRegistries/General/pull/110148 would also have been viable.
Note that you will have to edit your comment to include [noblock], or it will prevent automatic merging.


Missmatch MM current account with the one connected

Enter into the Prod env and my Mainnet MM account is connected by default, but my chrome extension is connected with a Rinkeby account I was using the previous day.
The app itselfs recognizes that my Chrome extension is currently with a rinkeby account (given the notification and the blur on the page) but the top bar shows the account I was connected with the last time which was the mainnet account

Probably this has to do with the changes that MM did to its extension.
We should make a check on which wallet we are connected currently with than just remember which one were connected last time we used the app

than just remember which one were connected last time we used the app

why?

For the account part: this is a duplicate of https://github.com/gnosis/safe-react/issues/1180
For the network part: this is a duplicate of https://github.com/gnosis/safe-react/issues/1152

than just remember which one were connected last time we used the app

why?

It was more a suggestion, to not keep having this mismatch going on. If there is a better way to make sure that the site and the top bar both are in synchrony then I'm all for it.


Updating Contributing.md

The contributing.md can be updated with commands for beginners to git and github, for easy cloning , forking and creating a pull request.

I would like to work on this issue under Hacktoberfest.
Kindly assign it to me. @dharmelolar

@Csrivastava003 Assigned!


Add Pilight light support

Description:
Support for lights in pilight. This will add dimmer functionality which the current switch lacks off.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
I don't have an envoirement now to setup rake, is there anyone who can copy the switch documentation and edit it for light? Only change is that 'dimmable' (optional) has been added for dimmer support.
Example entry for configuration.yaml (if applicable):
light:
  - platform: pilight
    devices:
      test2:
        dimmable: true
        on_code:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          'on': 1
        off_code:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          'off': 1
        on_code_receive:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          state: 'on'
        off_code_receive:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          state: 'off'

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @KennieNL,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I think this should be refactored as it basically copies the whole pilight-switch code and adds the dimlevel.

Agreed, but I dont have the python skills do to so, I'm not very familiar with it. Though I did needed the dimmer support, and did feel like sharing.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


I want to be able to collapse/expand all sets in the folder structure in the left panel

Is your feature request related to a problem? Please describe.
I want to be able to collapse/expand all sets in the folder structure in the left panel
Describe the solution you'd like
Allow option click to expand/collapse all, like the token categories.
Additional context

Slack chat: https://figmatokens.slack.com/archives/C02JAL48UDN/p1661870915270529

This request has been moved to our new feedback tool. Go check out https://tokensstudio.featurebase.app/ to create a free account. You can upvote and comment on existing posts, make a new request, and subscribe to be notified when requests move into our roadmap.

Added to Featurebase Roadmap : 🪙 Token organization enhancements


user docs: Add workflow instructions for using Zulip via email.

Added workflow instructions for using Zulip via email.
Testing plan:
Manual testing.
GIFs or screenshots:

I fixed the fact that several of the links were broken due to missing the /help/ prefix, and also the linter errors, and then merged this after some light copy-editing.
Reading this makes me feel pretty strongly that we should have a top-level "Email notification settings" article that we can link to in the "Related articles" section etc. from this page.


Generate Method Details

Added option -M / --method-details to generate method details.
i.e:
DisplayImage(Device device, string imagePath, byte brightness)
Writes image to device's framebuffer

Param
Description

device
Target device

imagePath
Path to image file, image will be scaled to match device display resolution

brightness
Set display brightness, 0 to turn display off

For consistency constructors should be documented as well.

I'll merge this request and do some changes.

Hi, Could i bother you with something? The merged pull replace accidentally leaked my work email. Can you rewrite history and remove the mention of my work email and leave only my actual email<EMAIL_ADDRESS>

Never needed to overwrite git history before. If you could get me the list of commands to execute I could do it.

But you should know it's dangerous.
Since you will be overwriting the history of your last 3 commits, anyone
who might have forked you repository in this time, might have problems when
they will try to merge / pull from you again.
Anyway, the commands are as follows:
git rebase -i HEAD~3
In the editor, change 'pick' to 'edit' on this line only:
pick 0da568d Generate Method Details (#15)
save and exit.
git commit --amend
change the commit message, remove the co-authored line (thanks)
git rebase --continue
And now you need to force this changes on github:
git push -f
Thanks.
On Sun, Sep 27, 2020 at 4:39 AM LoxSmoke<EMAIL_ADDRESS>wrote:

Never needed to overwrite git history before. If you could get me the list
of commands to execute I could do it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/loxsmoke/mddox/pull/15#issuecomment-699570902, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABSNLBISQJDO6JDWB7LWBTSH2JVDANCNFSM4QUTWN2Q
.

--
If you can't explain it simply, you don't understand it well enough. -
Albert Einstein

I just checked, you have 5 forks on this repository, but none are recent.
So it's kinda safe. Unless someone forks right now ;)
On Sun, Sep 27, 2020 at 4:56 AM Vladimir Vainer<EMAIL_ADDRESS>wrote:

But you should know it's dangerous.
Since you will be overwriting the history of your last 3 commits, anyone
who might have forked you repository in this time, might have problems when
they will try to merge / pull from you again.
Anyway, the commands are as follows:
git rebase -i HEAD~3
In the editor, change 'pick' to 'edit' on this line only:
pick 0da568d Generate Method Details (#15)
save and exit.
git commit --amend
change the commit message, remove the co-authored line (thanks)
git rebase --continue
And now you need to force this changes on github:
git push -f
Thanks.
On Sun, Sep 27, 2020 at 4:39 AM LoxSmoke<EMAIL_ADDRESS>wrote:

Never needed to overwrite git history before. If you could get me the
list of commands to execute I could do it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/loxsmoke/mddox/pull/15#issuecomment-699570902, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABSNLBISQJDO6JDWB7LWBTSH2JVDANCNFSM4QUTWN2Q
.

--
If you can't explain it simply, you don't understand it well enough. -
Albert Einstein

--
If you can't explain it simply, you don't understand it well enough. -
Albert Einstein


Check that git, bazaar, and mercurial are installed before running tests that require them

This is just a quality-of-life thing as a contributor.
Fixes #184.

Perfect :)

I'm kinda surprised and concerned that this would've resulted in a coverage decrease - that would seem to suggest more effects than this should really have. And this is based on the merge result of #185, which is more reasonable to have had those effects...hmm.
Well, not the end of the world.
One nit, though, before I merge - please limit the first line of git commit messages to 50 chars. I'm not as exacting as Tim Pope about his rules, but I do prefer following them.

Yeah, the coverage decrease seems pretty weird. I've never used codecov, but I'm trying to figure out where the coverage decrease could have come from.
If you like, I'd be happy to amend the commit message and make a new PR to keep the history clean, I'd prefer to be a good citizen 😄

I appreciate it 😄  - just amending the commit and force-pushing to this PR would be fine. No need for a new one.

This looks it could be a flaky test failure, maybe?
	manager_test.go:809: time to send signal: 13.449µs
	manager_test.go:812: time to return from Release(): 96.1µs
	manager_test.go:815: finished too fast (96.1µs); the necessary network request could not have completed yet
	manager_test.go:850: Expected error on statting what should be an absent lock file```

It is - it's a really hacky way of trying to approximate whether or not the signal handling is occurring correctly. Fails maybe 1/50 times. (I had to move on to other things, so went with the crappy heuristic)
Kicking it, should work on the next run...

OK, we're good.


AB#86039 removed references to font-weight 1/300/light

Fixes #0000
Checklist

[ ] Includes tests
[ ] Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

I don't see the font file itself being removed here? https://github.com/thepensionsregulator/react-components/tree/develop/packages/theming/src/assets/fonts

I don't see the font file itself being removed here? https://github.com/thepensionsregulator/react-components/tree/develop/packages/theming/src/assets/fonts

gone.


Animation gone after toggling appearance / dark mode on iOS

Description
Animation gone after toggling appearance / dark mode on iOS. Toggling back to the previously working appearance mode doesn't bring it back.

Actual behavior: [What actually happened]
Animation/graphics are completely gone.
Versions
"lottie-react-native": "5.0.1"
"expo": "~44.0.6"
"react": "17.0.2"
"react-dom": "17.0.2"
"react-native": "https://github.com/expo/react-native/archive/sdk-44.0.0.tar.gz"

+1

+1

+1

The same thing happens when switching to the browser and back.
https://user-images.githubusercontent.com/6774813/193740267-24c1ac97-d030-4e9d-b8b6-d04b69a0677e.MP4

Any updates on this? Is it possible to fix by downgrading to a previous working version?


Jitpack build fail after updating to Gradle 7.0

Issue 1: Gradle 7.0 build requires JDK 11, but Jitpack default is is 8.
Fix: Add jitpack.yml file with the following
# configuration file for building snapshots and releases with jitpack.io
jdk:
  - openjdk11

Issue 2: Maven plugin failure?
This plugin was not previously required and I am not using directly in the library.

https://stackoverflow.com/questions/68941441/maven-gradle-plugin-is-unavailable-after-andoird-gradle-upgrade-to-7-0-0

Fix: Added maven-publish to library gradle file
Issue 3: ERROR: No build artifacts found
Fix: Had to add following maven publication details to work with plugin:
// Because the components are created only during the afterEvaluate phase, you must
// configure your publications using the afterEvaluate() lifecycle method.
afterEvaluate {
    publishing {
        publications {
            // Creates a Maven publication called "release".
            release(MavenPublication) {
                // Applies the component for the release build variant.
                from components.release

                // You can then customize attributes of the publication as shown below.
                groupId = 'com.steamclock.steamclog'
                artifactId = 'release'
                version = 'v2.0'
            }
        }
    }
}

Not sure why these are now required with the Gradle 7.0 plugin - possible in the future we can remove the publication details since the Github -> Jitpack link seemed to cover this previously...

Nothing to QA; testing complete as long as Jitpack build is successful.


How do I indoctrinate an new user when using a pubring.kbx file?

My system is using GPG2.1 which uses a new Keybox file format pubring.kbx.
So I can't run gpg --import keyrings/live/pubring.gpg.
And if I try gpg --import keyrings/live/pubring.kbx it doesn't work.
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0

Even though gpg --homedir=keyrings/live --list-keys shows the keys I expect.
It turns out that --import doesn't work with the kbx format.
How are users of Blackbox dealing with this? Is there an alternative mechanism for importing keys or should I downgrade/start-over in a way that ensures the older .gpg file format is used?

The newest version of gpg uses a new filename and format for pubring. Sadly this breaks blackbox. Until there's a patch, please install the older gpg.  The gpg2 docs say that if the old filename exists gpg2 will continue to use it, so this won't affect old repos.
This change caught me off guard.

It seems that a patch has already been merged a while ago https://github.com/StackExchange/blackbox/pull/82
The issues being that it seems that you cannot import keybox keyrings like with the old format.
I do not know what would be the way to do so.

Another way to work around that issue would be to create manually the pubring.gpg before, then gpg2 would fallback into compatibility mode, and use this file.
But it is not future proof as we don't know for how long the pubring.gpg file format will be supported by gpg

We do know how long the old format will be supported but it's not long. From the project homepage for GPG (https://www.gnupg.org/):

2.0.30 is the stable version from an often used branch. This branch will reach end-of-life on 2017-12-31

After some playing around and a bit of reading I think I may have the right combination of commands to import new keys from Blackbox into the local keybox if using GPG 2.1+
gpg2 --keyring keyrings/live/pubring.kbx  --export | gpg2 --import

The trick is to export the keys and then pipe them into the import
This mailing list email has some good insights into the difference mechanism for import/exports between keyrings and keyboxes
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790665;msg=7

Please try this again.  I believe this was fixed in 4bc97049abb07fcc11cee6ca71daf9375d8137da

I ran into this today with the latest version of blackbox on Ubuntu LTS 16.04 while adding a new admin
Solved the issue as follows.
Importing the key (thanks @Binarytales!):
gpg2 --keyring keyrings/live/pubring.kbx  --export | gpg2 --import

To re-encrypt the files, I had to prefix blackbox_update_all_files with GPG=gpg2:
GPG=gpg2 blackbox_update_all_files

Ran into this and  @Binarytales solutions works on macOS X works with
gpg --keyring keyrings/live/pubring.kbx  --export | gpg --import
blackbox_update_all_files

A better form of the workaround is:
gpg --no-default-keyring --keyring .blackbox/pubring.kbx  --export -a | gpg --import`

--no-default-keyring prevents gpg from also exporting the default keyring, which is pointless and noisy for this operation.

Thanks a lot for your solution

It's 2020, can we make a push to update the README with this information?
Also, is there any reason this isn't included and automated into blackbox? Why can't the commands try to import these keys on each run, or at the very least before blackbox_update_all_files?

I've managed to add myself to a blackbox repo that is using the old GPG using this
GPG=gpg blackbox_addadmin ....

I am not sure if GPG=gpg is obeyed by blackbox_addadmin script or by gpg itself.


As a user, I want to be able to view my agenda for the day, so that I know what tasks to work on.

Done on V0.1 but have minor bug. Issue created.


Bump version to 0.10.2

Thank you very much for your contribution!

Thank you! Will you update PyPi as well?


Task managger

Describe the bug
Task managger takes ages to actually close
To Reproduce
Steps to reproduce the behavior:
Just did the desktop checkbox without oo and backup
Expected behavior
Task manager should close insatnt like before O.o

Seems like a issue of the "Disable Services" Tweak.

Copied from
Hello, i was looking all over the internet trying to find a solution for this and found nothing, so I took action on the matter. The thing is, when you do the "Set Services To Manual" tweak, between those tasks there's one called "NDU" which stands for "Windows Network Data Usage Monitoring Driver". I looked in the powershell to see which services were being set to manual start. Then i began to start each service one by one, until i found the root of the problem.
All you have to do is:
1- Do the "Set Services To Manual" tweak.
2- Open registry editor and go into HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Services\Ndu
3- Inside Ndu there is a dword named "Start"
4- Change "Start" value to 2. (3 and 4 is for disabling it i think)
5- Restart and done.

@ChrisTitusTech if that fixes it maybe remove the services from the manual list :3

Thanks commited this 4a9cdda


NIFI-10497: UI updates for making RegistryClient an extension point

This PR contains UI changes around Add/Edit Registry dialogs as a result of changes in https://github.com/apache/nifi/pull/6433.
A quick summary of the work in this PR:

Previously, we utilized one dialog for both adding and editing a registry. Because we need to support adding/editing/deleting properties, the two dialogs have much less in common now. I've separated the dialogs into two distinct .jsp files.
I removed the url input in the Add Registry dialog and added a combo dropdown for class type selection.
I added tabs to the Edit Registry dialog. One of these tabs contains a table for adding/editing properties. I'm currently waiting to see if #6433 will support dynamic properties. If it doesn't, I'll need to update this work to conditionally show/hide the add property button. It currently does not work in this PR.
This PR contains all the changes from #6433. I'm unable to start NiFi with latest work on that branch due to some java errors, which @simonbence is aware of. I'm going to open this PR as a draft until that's resolved.

Summary
NIFI-10497
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Will review...


I am facing the same dynamic loader issue you had please help !

Hi @mattjennings  !
I want to say that this repo has been an amazing learning tool for me ! thank you so so much for the time you spent creating it!
I am facing the dynamic loader issue you had in Dynamic imports fail to load in dev SSR. I tried to look at how you solved it in this repo but cant make it out for the life of me ! Surprisingly your code here works like a charm . I am am trying to figure what you did to circumvent the issue.
I created a repo to reproduce the issue in here. This is the output i get from that repo when i do yarn build.
Could you please kindly take a look or explain how i would aork around this issue. It has been almost a year and i imagine maybe that bug is fixed by now.

I think i figured what was going on ! please ignore :-)


Fix undefined variable in SSR spread

Had this show up in a build on my own project the other day (ReferenceError: results is not defined) and it looked easy enough to fix, I also added a simple test case to recreate the error/verify the fix.

Thanks. No clue how I missed that but thank you.


Fix #718, add user-specified extra modules to build

Describe the contribution
Add a new setting that can be set in targets.cmake, to enable users to add extra custom functions/modules to CFE core executable.
This can be used, among other things, for future support of a modular/customizable message header structure.
Fixes #718
Testing performed
Build and execute CFE, confirm normal operation/sanity check.
Build and execute all unit tests, confirm passing.
Expected behavior changes
Any user-supplied library can be added to the build.
System(s) tested on
Ubuntu 20.04
Additional context
This general concept can also be used to provide replacement implementations of core modules (e.g. TBL, FS) with some additional tweaking to exclude those modules from the subsequent build of CFE core.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Withdrawing this one, see PR #740 instead which also includes this and some other things.


[tests] test updating SRP host address

Test if we can update the host address.

For completeness, should we also verify that advertising proxy could respond the right/updated address when the host on the infrastructure link want to query and talk with the service provider?

@librasungirl  Thanks! Makes sense to me, will add the same case for Advertising Proxy soon.


Shared mailboxes?

Is the report-mesasge-add-in supported with the usage of shared mailboxes?
If not, how can users report suspicious emails that they received in a shared mailbox?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 445892a6-5948-33e4-ce60-72670829d8ef
Version Independent ID: a7407a6f-6563-9a4b-4a95-7ed908ab322b
Content: Enable the Report Message add-in - Office 365
Content Source: microsoft-365/security/office-365-security/enable-the-report-message-add-in.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@sebhe Thank you for your feedback. The add-in is available via the web version of outlook  The report-message add-in is not available for shared/delegate mailboxes when accessed via outlook. This has been added to the user voice section - https://office365.uservoice.com/forums/289138-office-365-security-compliance/suggestions/36313066-report-message-additional-mailbox which is addressed by the engineering team. Hopefully, this feature will be added soon.
Hope this helps!
@yogkumgit  There are no changes required in the document. Please close this issue.
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @sebhe Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Increase body font weight for readability

This was brought up on HN (Also more feedback in there regarding scrolling), and I think I have to agree that the body text has reduced readability on non-retina displays at least. Here's the status quo:

And here's with this change:

We import weights 300,400,600 from Google Fonts right now, and if we're sure 300 is used nowhere else, I'll update the PR to remove this weight for performance.

LGTM
Cant find 300 anywhere else in the .styl's which should make that weight removable.

Alright, removed the 300 weight.


CTE/WITH clause not working in .moor file

I have a select statement in my .moor file that includes a CTE. When I run the generator I get the following warning and the method is not included in the generated database.
[WARNING] moor_generator:moor_generator on lib/database.dart:
Error while generating APIs for worksByComposer
type 'CommonTableExpression' is not a subtype of type 'Table' in type cast

I also tested it using the example from the parser test:
WITH RECURSIVE
cnt(x) AS (
    SELECT 1
    UNION ALL
    SELECT x+1 FROM cnt
    LIMIT 1000000
)
SELECT x FROM cnt;

...which gives me the same warning. Are CTEs supposed to work in custom select statements?

Thanks for the report! This is a bug in moor_generator, so the parsing test didn't cover it unfortunately. It should be fixed now, I'll release an update later today.

This is great news! Thanks a lot for the instant fix and in general for your outstanding work!

Thanks! I've just published moor_generator version 2.1.1 which contains the fix.


improve hostname detection in loader

It looks like you were looking for the Location.hostname property.

@jdoubleu could you provide some motivation for this change? Does it fix a specific bug, or address a specific need? If possible could you rebase your work and fix the conflicts as well? Thanks!

Merged in 681fdf1512282cc6014ae27914ff276074d5a573

@jdoubleu could you provide some motivation for this change? Does it fix a specific bug, or address a specific need? If possible could you rebase your work and fix the conflicts as well? Thanks!

I'm not entirely sure, anymore. But I think it had to do with IPv6 support (see https://github.com/thgh/rollup-plugin-livereload/issues/69)


Unable to compile release with clang under ubuntu 17.10

Issue is #143 related.
Building without -DCMAKE_BUILD_TYPE=Release is fine.
infactum@dev-vm:~/develop/td/build$ uname -a
Linux dev-vm 4.13.0-37-generic #42-Ubuntu SMP Wed Mar 7 14:13:23 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
infactum@dev-vm:~/develop/td/build$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 17.10
Release:	17.10
Codename:	artful

infactum@dev-vm:~/develop/td/build$ CXX=clang++-5.0 CC=clang-5.0 cmake -GNinja -DCMAKE_BUILD_TYPE=Release ..
-- The CXX compiler identification is Clang 5.0.0
-- The C compiler identification is Clang 5.0.0
-- Check for working CXX compiler: /usr/bin/clang++-5.0
-- Check for working CXX compiler: /usr/bin/clang++-5.0 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/clang-5.0
-- Check for working C compiler: /usr/bin/clang-5.0 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Use link time optimizations: -flto=thin
-- Found ccache
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.0.2g")
-- Found OpenSSL: /usr/include /usr/lib/x86_64-linux-gnu/libssl.so;/usr/lib/x86_64-linux-gnu/libcrypto.so
-- Performing Test HAVE_STD14
-- Performing Test HAVE_STD14 - Success
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Performing Test HAVE_CXX_FLAG_WALL
-- Performing Test HAVE_CXX_FLAG_WALL - Success
-- Performing Test HAVE_CXX_FLAG_WEXTRA
-- Performing Test HAVE_CXX_FLAG_WEXTRA - Success
-- Performing Test HAVE_CXX_FLAG_WIMPLICIT_FALLTHROUGH_2
-- Performing Test HAVE_CXX_FLAG_WIMPLICIT_FALLTHROUGH_2 - Failed
-- Performing Test HAVE_CXX_FLAG_WPOINTER_ARITH
-- Performing Test HAVE_CXX_FLAG_WPOINTER_ARITH - Success
-- Performing Test HAVE_CXX_FLAG_WCAST_QUAL
-- Performing Test HAVE_CXX_FLAG_WCAST_QUAL - Success
-- Performing Test HAVE_CXX_FLAG_WSIGN_COMPARE
-- Performing Test HAVE_CXX_FLAG_WSIGN_COMPARE - Success
-- Performing Test HAVE_CXX_FLAG_WDUPLICATED_BRANCHES
-- Performing Test HAVE_CXX_FLAG_WDUPLICATED_BRANCHES - Failed
-- Performing Test HAVE_CXX_FLAG_WDUPLICATED_COND
-- Performing Test HAVE_CXX_FLAG_WDUPLICATED_COND - Failed
-- Performing Test HAVE_CXX_FLAG_WALLOC_ZERO
-- Performing Test HAVE_CXX_FLAG_WALLOC_ZERO - Failed
-- Performing Test HAVE_CXX_FLAG_WLOGICAL_OP
-- Performing Test HAVE_CXX_FLAG_WLOGICAL_OP - Failed
-- Performing Test HAVE_CXX_FLAG_WTAUTOLOGICAL_COMPARE
-- Performing Test HAVE_CXX_FLAG_WTAUTOLOGICAL_COMPARE - Success
-- Performing Test HAVE_CXX_FLAG_WVLA
-- Performing Test HAVE_CXX_FLAG_WVLA - Success
-- Performing Test HAVE_CXX_FLAG_WNON_VIRTUAL_DTOR
-- Performing Test HAVE_CXX_FLAG_WNON_VIRTUAL_DTOR - Success
-- Performing Test HAVE_CXX_FLAG_WUNUSED_PARAMETER
-- Performing Test HAVE_CXX_FLAG_WUNUSED_PARAMETER - Success
-- Performing Test HAVE_CXX_FLAG_WCONVERSION
-- Performing Test HAVE_CXX_FLAG_WCONVERSION - Success
-- Performing Test HAVE_CXX_FLAG_WSIGN_CONVERSION
-- Performing Test HAVE_CXX_FLAG_WSIGN_CONVERSION - Success
-- Performing Test HAVE_CXX_FLAG_WCXX14_COMPAT_PEDANTIC
-- Performing Test HAVE_CXX_FLAG_WCXX14_COMPAT_PEDANTIC - Success
-- Performing Test HAVE_CXX_FLAG_QUNUSED_ARGUMENTS
-- Performing Test HAVE_CXX_FLAG_QUNUSED_ARGUMENTS - Success
-- Performing Test HAVE_CXX_FLAG_WODR
-- Performing Test HAVE_CXX_FLAG_WODR - Success
-- Performing Test HAVE_CXX_FLAG_FLTO_ODR_TYPE_MERGING
-- Performing Test HAVE_CXX_FLAG_FLTO_ODR_TYPE_MERGING - Failed
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Found ZLIB: /usr/include /usr/lib/x86_64-linux-gnu/libz.so
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Could NOT find Readline (missing: READLINE_INCLUDE_DIR READLINE_LIBRARY)
-- Could NOT find Readline
-- Configuring done
-- Generating done
-- Build files have been written to: /home/infactum/develop/td/build
infactum@dev-vm:~/develop/td/build$ ninja
[18/328] Linking CXX executable td/generate/generate_c
FAILED: td/generate/generate_c
: && ccache /usr/bin/clang++-5.0  -pthread -std=c++14 -fno-omit-frame-pointer -fno-exceptions -fno-rtti -ffunction-sections -fdata-sections -Wall -Wextra -Wpointer-arith -Wcast-qual -Wsign-compare -Wno-tautological-compare -Wpointer-arith -Wvla -Wnon-virtual-dtor -Wno-unused-parameter -Wconversion -Wno-sign-conversion -Wc++14-compat-pedantic -Qunused-arguments -Wodr -O3 -DNDEBUG -flto=thin  -rdynamic td/generate/CMakeFiles/generate_c.dir/generate_c.cpp.o  -o td/generate/generate_c  tdtl/libtdtl.a && :
tdtl/libtdtl.a: error adding symbols: Archive has no index; run ranlib to add one
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[23/328] Building C object sqlite/CMakeFiles/tdsqlite.dir/sqlite/sqlite3.c.o
ninja: build stopped: subcommand failed.

Did you use apt install clang to install the clang?
Could you attach contents of CMakeCache.txt files created by CMake inside build directories for Debug and Release builds?

I've used clang 5.0 from official apt. Using default clang 4.0 from apt install clang will lead to the same issue.
CMakeCache.txt files are quite same except CMAKE_BUILD_TYPE:STRING= value.
CMakeCache_Release.txt
CMakeCache.txt

If you manually replace CMAKE_BUILD_TYPE:STRING=Release with CMAKE_BUILD_TYPE:STRING=
in CMakeCache_Release.txt, the build succeeds?

Could you also try to disable LTO by commenting line 26:
https://github.com/tdlib/td/blob/6c706f45e7a73c936b9f2f267785092c8a73348f/CMakeLists.txt#L26 ?

Manual replace of CMAKE_BUILD_TYPE:STRING= helps. Same for LTO disable.

It is likely to be LTO + -O3 issue. You can also try to re-enable Release and change in CMAKE_CXX_FLAGS_RELEASE O3 to O2, but disabling LTO should be enough to compile the code successfully.

Or it is a bug in our CMakeLists.txt.
Could you also try to uncomment line 26 and add
      string(REPLACE ";" " " CXX_LINK_FLAGS_IPO "${CMAKE_CXX_LINK_OPTIONS_IPO}")
      message(STATUS "Use link time optimization linker options: ${CXX_LINK_FLAGS_IPO}")
      set(CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE} ${CXX_LINK_FLAGS_IPO}")

If the build succeeds, than it is our bug.

-- Use link time optimization linker options:
Doesn't help.

Thanks for investigations.

FYI on clang 10 this issue is still happening, removing -DTD_ENABLE_LTO=ON works.


Conceptual Questions about BinsFormer

Thanks for a great repo!
I have a question about BinsFormer architecture especially about 'auxiliary classification.'
From your code, I found that there are variables called class_num and n_bins.
In my initial understanding from AdaBins is correct, I think AdaBins classifies the network output by n_bins, but it seems that BinsFormer's classification is done by class_num, where class here represents specific type of indoor scene (like bedroom, bathroom) in nyu.
But if so, why do we need such class in BinsFormer and how class contributes to 'auxiliary classification'?
If you need more clarification, I appreciate if you let me know.

Close it for now.


feat: hot-reload in oas-utils

Added hot reloading to oas-utils since we make SO many changes in here when working on the client.
Converted to draft because it doesn't seem to be working with commonjs
Update: we are so close!

the world was not ready for this


Reduce allocations in Array#pack with buffer arg and frozen string

Cuts allocations in half:
before
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
    103572  (95.0%)      103572  (95.0%)     Upstream::TrunkItem#_encode
    108505  (99.5%)        4933   (4.5%)     Upstream::Vehicle#_encode
    108977 (100.0%)         465   (0.4%)     Upstream::ParkingFloor#_encode
    108993 (100.0%)          14   (0.0%)     Upstream::ParkingLot.encode
    108511  (99.5%)           6   (0.0%)     Upstream::ParkingSpace#_encode

after
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
     51786  (95.0%)       51786  (95.0%)     Upstream::TrunkItem#_encode
     54253  (99.5%)        2467   (4.5%)     Upstream::Vehicle#_encode
     54495  (99.9%)         235   (0.4%)     Upstream::ParkingFloor#_encode
     54511 (100.0%)          14   (0.0%)     Upstream::ParkingLot.encode
     54259  (99.5%)           6   (0.0%)     Upstream::ParkingSpace#_encode

Speeds yjit-bench by 2% for me.
Unfortunately this can't make use of opt_newarray_send (both the buffer: keyword and the "D".freeze are barriers to use)

Maybe change the generated code to use frozen_string_literal: true? I think we set it to false because submessages needed a new buffer. But now that we're reusing the same buffer defaulting to frozen again might be the best thing.

Makes sense

I'm seeing a ~2% speedup on 3.3 and 3.4


Improve test_post_process_urls_adds_decorator

Use function as the return value of fake_decorator.
Refs: https://github.com/django-oscar/django-oscar/pull/3518/commits/5a10e17b8c3b38f10fe6f4241f1f38f249f2726a#r515003098

Looks good. Please add more descriptive commit message, explaining motivation to do this change (e.g. how you got to it and why fixed this way).

@sasha0 commit message updated.


try fix

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.70%. Comparing base (226f7f2) to head (09f9473).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   94.86%   94.70%   -0.17%
==========================================
  Files          47       47
  Lines        2434     2434
==========================================
- Hits         2309     2305       -4
- Misses        125      129       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove linkcheck ignore repo & cleanup conf.py

Re: https://github.com/openmicroscopy/sphinx-ignore-links/issues/1
This PR removes use of the sphinx-ignore-links repo for OMERO & contributing docs, in favour of just using ignore lists in the conf.py of each individual doc set.
Also cleaned up the OMERO command role as we already removed its use in the code to be compatible with new sphinx (see #1745)

https://ci.openmicroscopy.org/job/OMERO-DEV-merge-docs/917/ :+1:


Failed to install Julia: Access Denied

When I use winget to install Julia I get the following error:
PS C:\Users\Azure> winget install julia
Found Julia [Julialang.Julia]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://julialang-s3.julialang.org/bin/winnt/x64/1.4/julia-1.4.1-win64.exe
  ██████████████████████████████  64.9 MB / 64.9 MB
Successfully verified installer hash
Installing ...

[Error]
[Access Denied.]
[Ok]
Installer failed with exit code: 1

The installer command line is "C:\Users\Azure\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\TempState\WinGet\Julialang.Julia.1.4.1.exe" /SILENT /LOG="C:\Users\Azure\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\TempState\WinGet\Julialang.Julia.1.4.1.log"
But I can't find any logs under that directory. Process Monitor indicates that a CreateFile call which attempts to open the log file failed with ACCESS DENIED error. I tried to run the installer under ~\Download manually with that command line and it succeeded (with a log created at that destination).
PS C:\Users\Azure> winget show julia
Found Julia [Julialang.Julia]
Version: 1.4.1
Publisher: Julialang
AppMoniker: julia
Description: Julia is a high-level, high-performance, dynamic programming language
Homepage: https://julialang.org/
License: MIT
License Url: https://github.com/JuliaLang/julia/blob/master/LICENSE.md
Installer:
  SHA256: 953090cf2a3690791df7550175a8969e8de15cbd84d815975b6495cc884deab6
  Download Url: https://julialang-s3.julialang.org/bin/winnt/x64/1.4/julia-1.4.1-win64.exe
  Type: Inno
PS C:\Users\Azure> winget -v
v0.1.41331 预览
PS C:\Users\Azure> systeminfo /fo csv | ConvertFrom-Csv | select OS*, 系统* | Format-List

OS 名称   : Microsoft Windows 10 专业版
OS 版本   : 10.0.18363 暂缺 Build 18363
OS 制造商  : Microsoft Corporation
OS 配置   : 独立工作站
OS 构建类型 : Multiprocessor Free
系统启动时间  : 2020/5/21, 1:30:26
系统制造商   : LENOVO
系统型号    : 20C5A08JCD
系统类型    : x64-based PC
系统目录    : C:\WINDOWS\system32
系统区域设置  : zh-cn;中文(中国)

@davidanthoff

Already reported in different repository https://github.com/microsoft/winget-cli/issues/189


pack-ops mixing doesn't work

name
version

MacOS Sierra
v10.12.5

Node
v8.1.3

Npm
5.3.0

My package.json lists "js-git": "^0.7.8" as a dependency.
I define my repo like this:
var modes = require('js-git/lib/modes');

// Create a repo by creating a plain object.
var repo = {};

require('js-git/mixins/mem-db')(repo);
require('js-git/mixins/create-tree')(repo);
require('js-git/mixins/pack-ops')(repo);
require('js-git/mixins/walkers')(repo);
require('js-git/mixins/read-combiner')(repo);
require('js-git/mixins/formats')(repo);

Then I create some blobs, a tree, and a commit. Now what I want to do is make a pack from this.
First I tried the following (as stated in the documentation):
repo.pack(commitHash, {}, (err, stream) => {
	if (err) throw err;

	stream.read(onRead);
	function onRead(err, item) {
		if (err) throw err;
		console.log(item);
		if (item) stream.read(onRead);
	}
});

However, that complains that read isn't defined/a function. Doing a console.log(stream) shows me that it only contains a function called take. So my new code looks like this:
repo.pack(commitHash, {}, (err, stream) => {
	if (err) throw err;

	console.log(stream);
	stream.take((err, buffer) => {
		console.log(buffer);
	});
});

This, however, complains that onError is not defined.
{ take: [Function: take] }
<Buffer 50 41 43 4b 00 00 00 02 00 00 00 28>
node_modules/js-git/mixins/pack-ops.js:187
    if (err) return onError(err);
                    ^

TypeError: onError is not a function
    at onData (node_modules/js-git/mixins/pack-ops.js:187:21)
    at node_modules/js-git/mixins/pack-ops.js:158:27
    at node_modules/js-git/mixins/mem-db.js:93:5
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickCallback (internal/process/next_tick.js:161:9)

Seems that the pack-ops code is referencing a onError function that does not exist.

applyParser seem to need a onError argument, but is called without one here:
return callback(null, applyParser({ take: take }, encodePack));
I also don't understand how to use the stream.take that I get from calling repo.pack;

This seems to work:
repo.pack(hashes, {}, (err, stream) => {
	if (err) throw err;

	function readStream() {
		stream.take((err, data) => {
			if(err) throw err;
			if(data === undefined) return;
			process.stdout.write(data);
			readStream();
		});
	}
	readStream();
});

Perhaps the documentation should be updated.

Yep you're right.  Thanks for digging in.  I completely forgot about this and wouldn't have been able to help.
https://github.com/creationix/js-git/blob/master/mixins/pack-ops.js#L16-L18

I am confused

If you could check the modified version in the README, let me know if it works.


Table : updated styling of inline editing error messages (date-picker)

Description

References
Fixes #2542
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@coliff @ElishaSamPeterPrabhu Kindly review the PR


In Debezium iceberg, unable to Convert the uppercase_underscore to lowercase_underscore in Oracle connector.

Hi Team,
We wanted to inform you about an issue we faced with our Iceberg consumer component. It was not accepting schema names, usernames, and table names in UPPERCASE_UNDERSCORE format.
To solve this, I created a dummy Oracle database on my local system and converted these names to lowercase_underscore format, which worked well. However, the real challenge we now face is that our actual source Oracle DB uses the UPPERCASE_UNDERSCORE format.
We need to convert these names directly within Iceberg without using Kafka. We attempted to use SMT (Single Message Transforms), but it appears that SMT requires Kafka, making it unsuitable for our needs.
Could someone suggest a better solution for this conversion?
Thank you,
DnT

anyone ?

Good Morning everyone, anyone?

this option is now implemented in 0.6.0.Final release

Hi @ismailsimsek,
Thank you For this release now our problem has been resolved.
Thank you,
DnT


Vbumping STS to get latest Query Plan code

@alanrenmsft and @Charles-Gagnon do the changes look okay to bring in.

what changes are you introducing, please include a screenshot

@aasimkhan30 changes as of 'new sql parser' are already in ADS.

@aasimkhan30  hygiene build failed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.239%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
14797

Relevant Lines:
29107

💛  - Coveralls


<EMAIL_ADDRESS>require is not defined

Hi there,
After upgrading from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>the following lines are injected into the browser code, causing a reference error:
require('@prefresh/vite/runtime');
const { compareSignatures } = require('@prefresh/vite/utils');

This can be reproduced by running the following:
$ yarn create vite-app test --template preact && cd test
$ yarn && yarn upgrade --latest && yarn dev

Everything works fine when pinning the version to 0.8.1. Thanks! 👍
Kind regards,
Hampus Kraft.

Hey,
Thanks for the issue report, I can see why this issue is popping up, the prepublishOnly step translates from ESM --> CJS but it seems to also translate the code within the string-literal which isn't needed. I'll see what I can do

Oh, I upgraded my Node version using nvm and opened a new shell without setting a new default! My bad, it works now. Thanks!

Hi there, it's me again, sorry. Looks like it temporarily worked again for some reason, but I now can reproduce the same error again, despite using Node 14.4.0 🤔

Hey @pnfcre I published @prefresh/vite v0.8.3 which should fix this issue! Thanks for notifying me about this and we'll try to upstream it to bundt/rewrite-imports asap


Debug statement issue in production and QA

View simulation does not display complete debug statement.

Resolution:
Updated the libZRBackEnd_64.so file at /usr/lib
I moved simulation from simulation server to compilation server.  Compilation server always had old libZRBackEnd_64.so file because we never used it for compilation.  So, I collected libZRBackEnd_64.so file from old simulation server and then replaced the old library on all four production servers and QA with the good one.


call back query send duplicate messages

Whenever inline button clicked by user call back query send duplicate messages so what type of changes I need to do to not send duplicate messages.

`
movieRatingList.map((movie, idx) => {
var movieRating = Math.round(movie.rating * 10) / 10;
if (movieRating == bestRating) {
var firstName = movieList[idx].firstName;
keyboard.push([{ text: firstName, callback_data: idx }]);
}
});
      bot.sendMessage(userChatId, userText, {
        reply_markup: JSON.stringify({
          resize_keyboard: true,
          inline_keyboard: keyboard,
        }),
      });

      bot.on("callback_query", (callBackData) => {
        var idx = Number(callBackData.data);

        var fileID = movieList[idx].file_id;
        var firstName = movieList[idx].firstName;
        console.log(fileID);
        console.log(firstName);
        bot.sendDocument(userChatId, fileID, { caption: firstName });

      });

`

I do it in the following way and there is no duplication of messages.
I think that in your case duplicity is produced by adding it inside the same function where you send the message.
function send_message(){
    // Listeners
    let listenerCallback;
    let listenerCommand;

    // Actions listeners
    listenerCommand = ((responseCommand) => {
        let {chat, from, message_id} = respondeCommand;

        // More code or send_message with buttons

    });

    listenerCallback = ((responseCallback) => {
        let {id, from, message, data} = responseCallback;

        // More code or actions to buttons

    });

    // Commands
    bot.onText(/^\/start/, listenerCommand);
    bot.on("callback_query", listenerCallback);

};

The only drawback I see is that this .on() event will be active listening for all buttons and not just specific buttons.

@IscoV thank you for help . I make changes according to your suggestions and my issue got solved.


Can't resolve lifetimes with with_FIELD

For example:
#[self_referencing]
struct Thing {
  head: String,
  #[borrows(head)]
  tail: &'this str
}

impl Thing {
  fn tail(&self) -> &str {
    self.with_tail(|tail: &&str| *tail)
  }
}

I think this should be fine because the returned &str lifetime should be the same as &self.
However, this fails to compile with
error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements
  --> src/main.rs:12:39
   |
12 |          self.with_tail(|tail: &&str| *tail)
   |                                       ^^^^^
   |
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the body at 12:25...
  --> src/main.rs:12:25
   |
12 |          self.with_tail(|tail: &&str| *tail)
   |                         ^^^^^^^^^^^^^^^^^^^
note: ...so that the expression is assignable
  --> src/main.rs:12:39
   |
12 |          self.with_tail(|tail: &&str| *tail)
   |                                       ^^^^^
   = note: expected `&str`
              found `&str`
note: but, the lifetime must be valid for the anonymous lifetime #1 defined on the method body at 11:5...
  --> src/main.rs:11:5
   |
11 |     fn tail(&self) -> &str {
   |     ^^^^^^^^^^^^^^^^^^^^^^
note: ...so that reference does not outlive borrowed content
  --> src/main.rs:12:10
   |
12 |          self.with_tail(|tail: &&str| *tail)
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

I think this is because the signature is:
        pub(super) fn with_tail<'outer_borrow, ReturnType>(
            &'outer_borrow self,
            user: impl for<'this> ::core::ops::FnOnce(&'outer_borrow &'this str) -> ReturnType,
        ) -> ReturnType {
            user(&self.tail)
        }

and the compiler can't work out that the lifetime in ReturnType should be the same as 'this.
Would with_tail_contents have avoided this problem?

Part of the kludginess that makes the crate work is the signature of the with_ functions. Since Rust has no syntax to accurately describe a self-referencing lifetime, the with_* function instead requires that you pass a function that could work with any possible lifetime. This prevents you from storing self-references outside the struct or moving non-self-references into the struct. For some kinds of fields like plain references (including your &'this str), the macro knows it can generate an additional borrow_* function which correctly restricts the lifetime of the result to the lifetime of the initial borrow. You could use borrow_tail() in your example. If you have a field where that is not available, you can directly use self.with_tail(|tail| *tail) like so:
fn main() {
    let thing = Thing::new(
        String::from("Hello world!"),
        |head_ref| head_ref,
    );

    let head_ref = thing.with_tail(|tail_ref| *tail_ref);
    println!("{}", head_ref);
}

Hello world!

It is unfortunately not possible to wrap this usage of with_* in its own function, again being an unfortunate effect of the fact that Rust has no way to actually describe self-referencing lifetimes.

Part of the kludginess that makes the crate work is the signature of the with_ functions. Since Rust has no syntax to accurately describe a self-referencing lifetime, the with_* function instead requires that you pass a function that could work with any possible lifetime. This prevents you from storing self-references outside the struct or moving non-self-references into the struct. For some kinds of fields like plain references (including your &'this str), the macro knows it can generate an additional borrow_* function which correctly restricts the lifetime of the result to the lifetime of the initial borrow. You could use borrow_tail() in your example. If you have a field where that is not available, you can directly use self.with_tail(|tail| *tail) like so:
fn main() {
    let thing = Thing::new(
        String::from("Hello world!"),
        |head_ref| head_ref,
    );

    let head_ref = thing.with_tail(|tail_ref| *tail_ref);
    println!("{}", head_ref);
}

Hello world!

It is unfortunately not possible to wrap this usage of with_* in its own function, again being an unfortunate effect of the fact that Rust has no way to actually describe self-referencing lifetimes.


added bill summary and migration

Coverage increased (+0.09%) to 90.86% when pulling db332ee5a31aa80d9f2dd904b68f8372b3bc1b6d on crdunwel:master into<PHONE_NUMBER>eaaed823ac64833a073a85cdbcb34e on opencivicdata:master.

Coverage increased (+0.09%) to 90.86% when pulling db332ee5a31aa80d9f2dd904b68f8372b3bc1b6d on crdunwel:master into<PHONE_NUMBER>eaaed823ac64833a073a85cdbcb34e on opencivicdata:master.

:eyes: @paultag made it through tests :sunglasses:

@crdunwel isn't this in as BillAbstract? - Under http://docs.opencivicdata.org/en/latest/proposals/0006.html#implementation
Also, with field changes, we usually also update the OCDEP first :)

@paultag ahhh. I wasn't looking at the Enhancement Proposals. There was summaries attribute in the original (outdated) spec and it wasn't reflected in the current models. I'll submit a new pull request for adding a date attribute to BillAbstract per your suggestion.

:+1: thanks, @crdunwel !


Configure Vibration and Noise

It would be nice if it was possible to leave regular notifications (The popup bubble) on, but silence the vibrations of Vector.

I would think it would be best if you could (like Hangouts and several other apps do) configure which notifications fire for Vector in general, but it would also be nice if you could configure it per-room, if possible (if no custom setting is specified for a room, fall back to the general configuration, if that's missing fall back to the system configuration).


add eyebrows

Inside AvatarFace Tab:

Derive a MonsterEyebrow from AnimatedFeature class.
Define constructor for  MonsterEyebrow class, call close() by default (eyebrows down).
Define open()& close() methods for MonsterEyebrow, to create up & down eyebrows shapes.
Add leftBrow& rightBrowattributes to AvatarFace class.

20 min. story


Showing Error msg "Something went wrong. Please try again." on LocationPickerActivity on particular device

I have test on 5 device  , among that 3 device run successfully without any error ,but in 2 device get same error "Something went wrong. Please try again."
can you help me ?

Hi @jigs94!
I need more info to try to know what's happening. Please, could provide which version of Android have the devices that were showing that error? Also, are showing logs related on the device monitor?
Many thanks

version is lollipop

@jigs94 I'm sorry but with only that info is not enough for me to reproduce the problem. Please, could you give me more info?

Which version of the library do you actually use?
Do you have the localization permission granted?
Are you sending to the activity parameters through the bundle?
Could you describe what are the actions do you make to raise that error?
Android monitor shows any log related to the library when the error is shown?
Any other thing that could help me to reproduce the error?

Many thanks

Sorry @jigs94 but I'm closing the issue because I have not received any answer from you in 1 month. If you still experience the issue feel free to re-open it and give me more info to try to reproduce the error.

Hello, I get the same error message as a Toast: "Something went wrong. Please try again." This equals the string key "load_location_error". I can start the intent. I can press the "GPS"-FAB to move to my current location. I can write into the Search bar and speak into the microphone. But: I don't have the Confirmation-FAB to actually get the chosen location and return to my previous activity. When typing into the Search bar, on every key press a new "Something went wrong. Please try again." spawns, as well as after finishing a voice input. If it put this into the intent:
intent.putExtra(LocationPickerActivity.BACK_PRESSED_RETURN_OK, true);
And I press back, it does NOT return OK, but instead RESULT_CANCELED.
My Google Developer Console shows the incoming requests for "Google Maps Android API", without any errors.
Important parts of my AndroidMainfest.xml:
     <meta-data             android:name="com.google.android.gms.version"             android:value="@integer/google_play_services_version"/>         <meta-data             android:name="com.google.android.maps.v2.API_KEY"             android:value="@string/google_maps_key"/>         <activity             android:name="com.schibstedspain.leku.LocationPickerActivity"             android:label="@string/title_activity_location_picker"             android:parentActivityName=".view.activity.PreInfoActivity"             android:theme="@style/AppTheme"             android:windowSoftInputMode="adjustPan">             <intent-filter>                 <action android:name="android.intent.action.SEARCH"/>             </intent-filter>             <meta-data                 android:name="android.app.searchable"                 android:resource="@xml/searchable"/>             <meta-data                 android:name="android.support.PARENT_ACTIVITY"                 android:value=".view.activity.PreInfoActivity"/>         </activity>
My module-level build.gradle:
buildscript {     repositories {         maven { url 'https://maven.fabric.io/public' }     }     dependencies {         classpath 'io.fabric.tools:gradle:1.+'     } } apply plugin: 'com.android.application' repositories {     maven { url 'https://maven.fabric.io/public' }     jcenter() } android {     compileSdkVersion 25     buildToolsVersion '25.0.2'     defaultConfig {         applicationId "my.application.name.id"         vectorDrawables.useSupportLibrary = true         minSdkVersion 21         targetSdkVersion 25         versionCode 1         versionName "1.0"         multiDexEnabled true     }     buildTypes {         release {             minifyEnabled false             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'         }         debug {             debuggable true         }     } } dependencies {     compile 'com.android.support:appcompat-v7:25.1.0'     compile 'com.google.android.gms:play-services-auth:10.0.1'     compile 'com.android.support:design:25.1.0'     compile 'com.android.support:support-v4:25.1.0'     compile 'com.android.support:cardview-v7:25.1.0'     compile 'com.android.support:gridlayout-v7:25.1.0'     compile 'com.android.support:support-vector-drawable:25.1.0'     compile 'com.android.support:animated-vector-drawable:25.1.0'     compile 'com.android.support:percent:25.1.0'     compile 'com.google.code.gson:gson:2.6.2'     compile 'com.squareup.retrofit2:retrofit:2.1.0'     compile 'com.squareup.retrofit2:converter-gson:2.1.0'     compile 'com.schibstedspain.android:leku:3.0.0'      [...] } apply plugin: 'com.google.gms.google-services'
Screenshot:

Devices: LG G3 (API 21) as well as Nexus 5X API 25 Emulator.
Also, I don't really get how SEARCH_ZONE works exactly. If I don't pass it as an Extra, is this equal to a global search zone? And what exactly does the search zone do? I want the user to be able to choose a location globally.
I hope it is just a stupid, obvious mistake.


Add REVOL-E-TION

Insert URLs to the project here: https://github.com/TUMFTM/REVOL-E-TION

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@rosphil @bdietermann @marcelbroedel