Set ChainId and GasePrice in storage

Define ChainId and GasPrice storage values.
Set an optional genesis config or fallback to default (ChainId 42 and GasPrice zero).

I can see why you want to configure this is chain spec but this is going to add performance penalty for extra storage reads on every transactions

I can see why you want to configure this is chain spec but this is going to add performance penalty for extra storage reads on every transactions

As far as I understand runtime accessing it's state for a StorageValue is very cheap, do you think this will add any noticeable overhead when processing a transaction?
Anyway, this change is directly related to the frontier PR you are aware of, and in that case the discussion is more on runtime spawn overhead VS. statebackend query on RPC calls that are unlimited and totally free. This change will open a way of making those requests much more cheaper.

Both of chain ID and min gas are constants that I don't feel it make sense to make them into storage.
Shouldn't the Frontier RPC handler able to cache the value to avoid the overhead?

Both of chain ID and min gas are constants that I don't feel it make sense to make them into storage.

Again, all this makes sense in the context of the https://github.com/paritytech/frontier/pull/175.

Shouldn't the Frontier RPC handler able to cache the value to avoid the overhead?

Although I talked with @sorpaas about the above Frontier PR and this one before opening them and he seemed OK with the changes, I'm open to switch to a more flavoured option like the one you suggested there - enabling both runtime and storage APIs - if he thinks that's more reasonable. If that's the case, a cache strategy for ChainId and Gasprice in the RPC side may be preferable, as it'd support both API flavours without the overhead of accessing the StorageValue.

In memory cache should always give your better performance (except for the first call) if that's the purpose, especially for constant data.
But I am not too against on this as we are considering on fork pallet-evm anyway to experiment some ideas like state renting.

Before this PR, pallet evm used the Get trait to obtain a chainId. That design is strictly more flexible, and in my opinion should be kept. It allows the simplicity and performance that @xlc described by simply using the parameter_types! macro. It also allows the flexibility of storing the chainId in a storage item, we just need to introduce a simple auxiliary pallet that stores the chainId.
IMO putting the storage item into pallet-evm forces everyone to make the same decision, while using the Get trait allows the decision to be configured.

Closing this. Rel https://github.com/paritytech/frontier/pull/199


Add a template for reporting issues

Github now supports issue templates via a markdown file called issue_template.md in your repo!
See https://github.com/samccone/issue-template

I posted an issue-reporting guide on the discourse board a month ago and nobody's said a word about it. (http://discuss.phantomjs.org/t/draft-troubleshooting-and-reporting-bugs-in-phantomjs/22/1)

Some more info: https://github.com/blog/2111-issue-and-pull-request-templates.
@Vitallium Reading the above blog post, I think it's now time to put those "meta" Markdown files under .github/ directory to reduce top-level clutter.
@zackw Go for it.

Similarly, I'd suggest closing old issues. 1000+ are too many to be manageable. Just write a few lines telling people that they can ask to have an issue re-opened if it's still an issue. And that providing steps to reproduce + a failing test-case increases the likelihood of someone looking at it.
Here is some inspiration:
https://github.com/btford/github-prune-issues
https://github.com/tombatossals/khan-exercises/blob/master/build/close-old-issues.py

@sandstrom thanks. But we can't close all old issues. A lot of them are still presented in current version of PhantomJS. I'd rather close all issues for 1.9 version.

Landed in https://github.com/ariya/phantomjs/commit/2267b2643f55e7a4d3ffe67e5ad68c6394969bba

@Vitallium I see. Totally up to you guys! Jus trying to suggest ways of cutting down the numbers.
Many issues is also a hinderance to new contributors. If someone wants to dig in, it's hard to know where to start and it feels like an insurmountable mountain of issues. It's like it's not even worth trying (I know that's not true, but easy to get that feeling).
Some repos use bots, to e.g. auto-close issues or prompt the next step. Perhaps that's a good idea?

https://github.com/rails/rails-bot [greeting new contributors]
https://github.com/twbs/no-carrier [auto-close when no response is given]


Windows Trojan in R packages

My computer got infected by virus when installing R packages from R mirror 2 times under WSL 1.0.
One using http, giving the wsl program admin privilege on windows, one using https and with no admin. In both cases, I run R without root permission and install packages inside home.
The packages I installed are tidyverse, data.table, stringr, stringi and devtools. Detailed of the instructions I used for the second installation can be seen in here. The first installation only differs in that it does not configure R to use https in ~/.Rprofile.
The first installation
During the first installation, it looked fine at first until kaspersky warned me that /usr/bin/R/exec/R was a windows32 Trojan which it did not warn after I installed R using apt (the installation of packages took more than 5 mins and kaspersky should have finished scanning R). Since I installed R from official source in linux not windows, I was very confident at what I was doing and did not click ‘disinfect now and restart’ and just ignore it.
After that, the packages installation quits with some strange errors which I did not record (sorry about that).
Then when I tried to find out what happened, all command in linux failed with no permission. After a while, my chrome cannot access network and a windows core is damaged. I cannot even open settings or WSL. Windows shell crashed with the same error as chrome.
Attempted to disinfect my computer manually, I deleted /usr/bin/R/exec/R from windows explorer.
After I restarted the computer, my login is also partly corrupted with message:

C:\Windows\system32\wbem\wbemprox.dll is either not
designed to run on Windows or it contains an error. Try
installing the program again using the original installation
media or contact your system administrator or the software
vendor for support. Error status 0xc0000022.

It was a late night so I turned off the computer. When I restarted, probably due to my “manual disinfection” and the power of kaspersky, my computer restored with the consequence that WSL is not working properly.
The second installation
I reset WSL in windows app and tried to reinstall R in WSL. This time I run bash from cmd.exe to prevent giving wsl any privilege to mess up with my system (an advice from one friend) and configure R to use https in ~/.Rprofile.
I also modified windows security level to prompt for every request for admin privileges so that no privilege is given accidentally.
This time the same problem appeared again, except that when kaspersky prompted me that it has detected a virus, I immediately clicked “disinfect” and the system restarted. Just before the restart, I recalled that the same windows dll is missing.
After the restart, the system is working just fine and kaspersky detected no virus and my WSL misbehaved again.
As I have personally experienced this twice, I highly doubt this is a coincidence or just simple wifi hiject to because I was in two different location: one in my home, one in my university.
System info:
Device specifications:
Device name HP_OMEN
Processor      Intel(R) Core(TM) i7-8750H CPU@ 2.20GHz 2.21 GHz

Windows specifications
Edition    Windows 10 Education
Version   1903
OS build 18362.476

WSL:
4.4.0-18362-Microsoft
Debian buster 10.2

R:
3.5.2-1

This is not the appropriate or responsible venue to report security issues.
The front page of the project page states up top: "Do not open Github issues for....security issues. Please direct all ...security issues to<EMAIL_ADDRESS>You should report suspected WSL vulnerabilities there.
You should report a security issue with R to the R Project via R-Help but be sure to consult the Posting Guide first. If you believe a specific R dependency has been compromised, you should private contact the maintainer of that dependency. If you know which R Project mirror you connected to, you should privately contact the admin of that mirror as well.
I downloaded the binaries for Debian buster unpacked them and ran them through VirusTotal with no positive hits.
It is very possible that the detection of the R executable by Kaspersky was a false positive. If you search this issues section you will see Kaspersky can cause a number of odd behaviors with WSL.
It is possible that one of the R project mirrors was compromised and is dishing out bad binaries, though that is unlikely as R project signs their repo files. It is also possible that your system was already injected with a trojan which infected WSL executable files on access. It is likely that editing WSL filesystem manually in Explorer also caused some of the erratic behavior.
Anti-virus software uses wbemprox.dll to load third-party .dlls and it's possible wbemprox.dll was corrupted by Kaspersky crashing your system. I would break out DISM /Online /Cleanup-Image /RestoreHealth after uninstalling Kaspersky.
The fact is we don't really know and reporting security issues like this is dangerous. Please report them privately to the appropriate parties and give them adequate time to investigate before disclosing them publicly.


purescript tests failing

Originally opened as purescript/purescript#1336.
Test suite tests: RUNNING...
tests: npm: callProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Test suite tests: FAIL
Test suite logged to: /home/stackage/work/logs/nightly/purescript-<IP_ADDRESS>/test-run.out
Test suite psci-tests: RUNNING...
^MCases: 37  Tried: 0  Errors: 0  Failures: 0^MCases: 37  Tried: 1  Errors: 0  Failures: 0^MCases: 37  Tried: 2  Errors: 0  Failures: 0^MCases: 37  Tried: 3  Errors: 0  Failures: 0^MCases: 37  Tried: 4  Errors: 0  Failures: 0^MCases: 37  Tried: 5  Errors: 0  Failures: 0^MCases: 37  Tried: 6  Errors: 0  Failures: 0^MCases: 37  Tried: 7  Errors: 0  Failures: 0^MCases: 37  Tried: 8  Errors: 0  Failures: 0^MCases: 37  Tried: 9  Errors: 0  Failures: 0^MCases: 37  Tried: 10  Errors: 0  Failures: 0^M                                            ^M### Failure in: completionTests:10
expected: [":l psci/tests/data/Sample.purs"]
 but got: []
^MCases: 37  Tried: 11  Errors: 0  Failures: 1^M                                            ^M### Failure in: completionTests:11
expected: [":module psci/tests/data/Sample.purs"]
 but got: []
^MCases: 37  Tried: 12  Errors: 0  Failures: 2^MCases: 37  Tried: 13  Errors: 0  Failures: 2^MCases: 37  Tried: 14  Errors: 0  Failures: 2^MCases: 37  Tried: 15  Errors: 0  Failures: 2^MCases: 37  Tried: 16  Errors: 0  Failures: 2^MCases: 37  Tried: 17  Errors: 0  Failures: 2^MCases: 37  Tried: 18  Errors: 0  Failures: 2^MCases: 37  Tried: 19  Errors: 0  Failures: 2^MCases: 37  Tried: 20  Errors: 0  Failures: 2^MCases: 37  Tried: 21  Errors: 0  Failures: 2^MCases: 37  Tried: 22  Errors: 0  Failures: 2^MCases: 37  Tried: 23  Errors: 0  Failures: 2^MCases: 37  Tried: 24  Errors: 0  Failures: 2^MCases: 37  Tried: 25  Errors: 0  Failures: 2^MCases: 37  Tried: 26  Errors: 0  Failures: 2^MCases: 37  Tried: 27  Errors: 0  Failures: 2^MCases: 37  Tried: 28  Errors: 0  Failures: 2^MCases: 37  Tried: 29  Errors: 0  Failures: 2^MCases: 37  Tried: 30  Errors: 0  Failures: 2^MCases: 37  Tried: 31  Errors: 0  Failures: 2^MCases: 37  Tried: 32  Errors: 0  Failures: 2^MCases: 37  Tried: 33  Errors: 0  Failures: 2^MCases: 37  Tried: 34  Errors: 0  Failures: 2^MCases: 37  Tried: 35  Errors: 0  Failures: 2^MCases: 37  Tried: 36  Errors: 0  Failures: 2^M                                            ^MCases: 37  Tried: 37  Errors: 0  Failures: 2
Test suite psci-tests: FAIL

Apparently npm, bower, and node are needed by purescript's testsuite.
For the moment I let it fail with fe56d8a but would be nice to sort this out so that the tests run correctly.
Not sure if there is anyway else needed from purescript/purescript#1336 ?

With current purescript master (yet unreleased) only node and npmare needed. Versions in debian or ubuntu stable package repositories should be recent enough.

0.7.3 is out, tests should work now.

This also seems to be the reason purescript installation fails in nixos (at least on my machine).
...
Running 2 test suites...
Test suite tests: RUNNING...
tests: npm: callProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Test suite tests: FAIL
...
Does this belong in this thread or here:
https://github.com/NixOS/nixpkgs/issues/8965  ?

<IP_ADDRESS> test suite seem to work as long as you have (node or nodejs) and npm in path

nodejs and npm have been added to the Stackage environment (thanks Dan!),
but so hopefuly should be okay now but I guess we won't know if it working now
for sure until next time purescript gets built/rebuilt.

:+1:

I guess npm needs some user setup?
Test suite tests: RUNNING...
npm ERR! Error: EACCES, mkdir '/home/stackage/.npm'
npm ERR!  { [Error: EACCES, mkdir '/home/stackage/.npm'] errno: 3, code: 'EACCES', path: '/home/stackage/.npm' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! System Linux 3.13.0-40-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /tmp/stackage-build1/purescript-<IP_ADDRESS>/tests/support
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path /home/stackage/.npm
npm ERR! code EACCES
npm ERR! errno 3
npm ERR! stack Error: EACCES, mkdir '/home/stackage/.npm'
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /tmp/stackage-build1/purescript-<IP_ADDRESS>/tests/support/npm-debug.log
npm ERR! not ok code 0
tests: callProcess: npm "install" (exit 3): failed
Test suite tests: FAIL
Test suite logged to: /home/stackage/work/logs/nightly/purescript-<IP_ADDRESS>/test-run.out
Test suite psci-tests: RUNNING...
npm ERR! Error: EACCES, mkdir '/home/stackage/.npm'
npm ERR!  { [Error: EACCES, mkdir '/home/stackage/.npm'] errno: 3, code: 'EACCES', path: '/home/stackage/.npm' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! System Linux 3.13.0-40-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! cwd /tmp/stackage-build1/purescript-<IP_ADDRESS>/tests/support
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path /home/stackage/.npm
npm ERR! code EACCES
npm ERR! errno 3
npm ERR! stack Error: EACCES, mkdir '/home/stackage/.npm'
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /tmp/stackage-build1/purescript-<IP_ADDRESS>/tests/support/npm-debug.log
npm ERR! not ok code 0
psci-tests: callProcess: npm "install" (exit 3): failed
Test suite psci-tests: FAIL

It seems npm wants to write into $HOME/.npm. I'll investigate if it can be avoided

Could stackage build by done with HOME=/tmp/some-temp-dir environment? or if we are paranoid, with HOME=/tmp/some-temp-dir and only HOME=/tmp/some-temp-dir/.npm writable (configurable option).
This would workaround this and https://github.com/fpco/stackage/issues/726 issues.
I can hack that together, if given pointers how stackage build is actually made.

I can't find anything which would prevent npm from trying to write to $HOME in npm docs.

(untested) Something like  npm config set prefix tmp/ may also be an option

@bergmark that writes $HOME/.npmrc

The referenced issue is closed so I'll re-enable the test-suite and try again.

Ouch wrong ticket number again :/ 34b6192


Add some assertions

It should be considered a fatal error If the scheduler allows multiple clients to run on the same GPU at the same time, to confirm that this is not happening, we should add some assertions in the scheduler.

closed by #106


Not receiving items that the server is giving

On my first launch, I received items/stages, got a nice visual on screen. But I launched the game a second time, connected to the same server and used the same save slot, but every time I interacted with a secret, V2 boss drop, I received nothing. The server sent a message saying I received the item, but I didn't receive the item in-game. I tried generating a new game and I still got the same problem.
Another thing is I put the music randomizer on, and it still seems to work.

The new update that just got released seems to have broken some things in Archipelago. I'm working on fixing them right now


affter depositing

affter depositing, steam bot consolo accepting offert, and nothing pass in web, inspect element and error:
Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('http://steamcommunity.com') does not match the recipient window's origin ('http://www.facilpot.com').
solution?

add me http://steamcommunity.com/id/aaaaaKung/ i maybe know :)

		"BotWebsiteURL":"http://csgo-rolling.com", Be sure to have that correct in your bot file

@eliasferreyra
how did you do this with this "Add FACILPOT.COM to your STEAM nickname and get 5% bonus to your win amount!"?
Can you help with the code?

i dont work greyzz,, is decoration for now

@eliasferreyra
okay
BTW I like the design

help please, affter deposit, bot accepting trade, and error
http://subefotos.com/ver/?c1f49c7eee3ddd67ede07175cfb1fe9bo.png

@eliasferreyra
I had the same problem in the past, I re-compiled the bot and re-setup the whole
site and it worked

"BotWebsiteURL":"http://facilpot.com",
"BotWebsiteName":"FACILPOT",
"BotDBPassword":"??",
that I have to put password?? in setting.  bot

@eliasferreyra
Yes the password of your database so the bot can access to the database
and add the items deposited to "currentPot"


Feature to allow importing samples from S3

If the user has fastq data sitting in s3, we could imagine having a feature where they provide their s3 bucket credentials and Millstone imports from that location.  I haven't thought about the security implications of such a feature, so just a thought for now.

Added to wish list.

Definitely on my wishlist, esp. because it would mean that one wouldn't
have to have two copies of the data on the server (pre-load, and
post-load). The python S3 api is pretty good.
On Wed, Jun 15, 2016 at 1:31 PM Gleb Kuznetsov<EMAIL_ADDRESS>wrote:

Added to wish list.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/churchlab/millstone/issues/375#issuecomment-226260419,
or mute the thread
https://github.com/notifications/unsubscribe/AAfcBIW-4o_IlqEt7WH_GUUHDZ2Kte1cks5qMDbigaJpZM4CBMGl
.


Nazrhom/fee escrow

Part of #267

@uhbif19 this is currently hardcoded to be hydraNodeActors in https://github.com/mlabs-haskell/hydra-auction/pull/297/files#diff-845d2a2cc5430818b2ff390b4bac10a80f1ebb2ada8af17b27e08fd915b82deaR84

this is currently hardcoded to be hydraNodeActors

I understand. I meant real CLI. We can separate CLI fixing for that stuff in another issue, which probably requires delegates list returining, and merge this.


Failed jobs leave files in the raw folder

Is your feature request related to a problem? Please describe.
Failed jobs result in the raw folder never being cleared.
Describe the solution you'd like
Have ARM check previously failed jobs and remove matching folders from the raw folder
Describe alternatives you've considered
Have ARM correctly handle failures
Are you able to help code/implement this feature ?
Yes
Additional context
N/A

This will require calling a cleanup function at every spot a job could be cancelled and any exception that the program throws to exit. I'll put it on the list of things to do for v2.7. It'll be easier to implement after the application flow logic is refactored


Streaming extension: Please provide package-lock.json or lockdown on all versions

Versions
Node 12
Describe the bug
If package-lock.json is not provided, running npm install on the client box will be undeterministic. That means, in the future, anyone running npm install will be installing packages that are significantly more updated than today.
In that case, the build will break and we will not be able to reproduce the build because we don't exactly know what version we were using when building.
Please either, include package-lock.json (recommended), or make sure all the versions are locked down at least.
Locking down the version is not recommended because transient packages are still not locked down. That means, we are still susceptible to the problem mentioned above for transient packages (indirect dependencies). So I would highly recommend to use package-lock.json to shrinkwrap it down.
Repro steps

Fresh clone, make sure no node_modules folder

Easiest is run git clean -fdx if you have a dirty repo

Run npm ci

It should work as expected.
npm ci is npm install but for CI pipeline to verify build quality. If it can run successfully, it guarantees a reproducible build in any of time in the future (given no packages are unpublished).
[bug]

We explicilty deleted all the package-lock files. The lockdown approach is worth discussion.

Discussed offline, we are doing the right thing already. Closing :)


Is there an asynchronous API to render after some times to wait data of stateful components to load?

I have stateful components that do work before being ready (wait some data to load, rendering into canvas and then in a base64 image, etc..).
I don't want to move my state in top of the tree because it loses the modularity of components. (and it wouldn't be easy in my usecase anyway)
is it possible we can do this with Oy ?
If not, what is the difference between Oy.renderTemplate and doing ReactDOM.render(vdom,container) and then container.innerHTML? (can I do the extra stuff that Oy.renderTemplate is doing but using ReactDOM.render ?)
Thanks

Hi @gre, Oy adheres to the same constraints as React server-side rendering. To my knowledge, there is no way to wait for events from individual components to be "ready", and there is no concept of stateful components with React server-side rendering.
To address your use case, I think you'll have to wait for the necessary data to load at the top level, then pass that data in as props to your component tree root.
ReactDOM.render wouldn't work on the server, since there's no DOM to attach the rendered raw HTML to. Oy.renderTemplate uses ReactDOMServer.renderToStaticMarkup(...), injects that string into a basic HTML4 email template string, then returns that string, which is a full email template.
Hope that helps!


[Migration Tools] Research where exactly to add the the UI wizard for XS app migrations

It could be provided either as standalone application (running on XSK/Dirigible) or as standard Dirigible Perspective/View.
Sample Perspective and View could be found here: https://github.com/StanZGenchev/ide-gmn

As discussed internally, the UI would be implemented as a standard Perspectiv.


gremlin-http + titan fails to start due to duplicate instance id

Hi,
We have an image of gremlin-http with titan and deploy this image to our production. Sometimes graph object fails to bind with following error
Caused by: com.thinkaurelius.titan.core.TitanException: A Titan graph with the same instance id [0a8102e51-bayesian-gremlin-http-1-xsjni1] is already open. Might required forced shutdown.
    at com.thinkaurelius.titan.graphdb.database.StandardTitanGraph.<init>(StandardTitanGraph.java:146)
    at com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:94)
    at com.thinkaurelius.titan.core.TitanFactory.open(TitanFactory.java:74)
... 13 more

We have observed this behavior now 2 times in our production setup. Is there anyway where we could handle the instance id ourselves?

We could use http://s3.thinkaurelius.com/docs/titan/1.0.0/titan-config-ref.html#_graph to set the instance_id property. Closing this issue, as does not seem relevant to dynamodb. Thanks again.


Text composables: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-text-composables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-text-composables#1
In which task and step of the codelab can this issue be found?
[2. Set up a Happy Birthday app] > Create activity ... > Step 2
Describe the problem
The instruction say "In the New Project dialog, select Empty Activity and then click Next."
It should specify that the Empty Activity must be an Empty Compose Activity. Otherwise the user can open an Empty Activity making the rest of the steps really hard to follow.
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hi @TSa3eed
Thank you for writing in with this issue.
The latest stable version of Android Studio (Currently Giraffe) has them listed as "Empty Activity" and "Empty Views Activity". In prior versions, they were listed as you stated.
As you did not state your Android Studio version, I do not know which one you are using.
If you are on Giraffe and this is still an issue, please create a new ticket and provide a screen shot of the templates shown and also a screenshot of your Android Studio version so we can investigate further.
Hope you are enjoying the course!
Regards.


Pre-trained weights only for English text?

Thank you for the great work.
I want to use your code for text super-resolution of some very noisy/blurry text images. However,
I noticed that since the pre-trained weights are generated based on Chinese and English text, I get incorrect results for some characters due to high distortions. By any chance, do you have any pre-trained weights using only English text? If not, how can I retrain the model for English only, and should I retrain from scratch, or only fine-tune?
Here is a sample result for your reference.
Input:

Output:

Thank you for your interest in our work.
While the IDM model was not pretrained solely on English datasets, it was trained on a mixed dataset with Chinese, English, and numbers, allowing it to generalize to English text images in most cases.  However, if you want IDM to perform optimally on text images in specific scenarios, such as document or web text, fine-tuning on these particular datasets would be beneficial.
Additionally, I noticed that the images you provided may suffer from quality issues due to potential bias in the TDM model's distribution.  To address this, you may consider fine-tuning TDM or replacing it with a text recognition model better suited to your requirements.

Thank you for your reply.


[WIP] Incorrect insert position of inline:auto code

This PR contains a failing test for issue #320

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

          1 Warning

:warning:
PR is classed as Work in Progress

  Generated by :no_entry_sign: Danger

@Liquidsoul I'm a bit confused with the result of the CI 😄

Success with a failing test, nice! 🤣

@Liquidsoul let me check it locally on my machine 😄

Hm, and CI in the web interface shows an error:

@Liquidsoul @Antondomashnev #323 should resolve this issue


emission-line amplitudes are modified by resampling and convolution in unexpected ways

Work on #137 has led to the discovery of a significant bug which impacts the reported emission-line amplitudes in a way which depends on the line-width (and therefore the error can be unexpectedly large for very narrow emission lines).
In retrospect, the issue should have been obvious, but the bug has been in place since the first versions of the code.
This is what I currently do in the emission-line fitting portion of the code:

Initialize each emission line as a Gaussian profile of a given line-center (in km/s, relative to the Redrock redshift), intrinsic line-width (in km/s), and peak amplitude;
Build the redshifted model emission-line spectrum with constant-velocity pixels at much higher sampling resolution than DESI spectroscopy (currently $\Delta v$=5 km/s);
Resample the model spectrum to match the extracted DESI wavelength vector (here I use the sample flux-conserving trapezoidal resampling algorithm used by Redrock);
Take the dot product of the data with the resolution matrix in order to account for the line-spread function;
Use non-linear least-squares to optimize the parameters of each emission line.

The problem is that the model emission-line amplitude (which I report as an output parameter, e.g., OII_3726_AMP) is the value of the initial model, but resampling and convolution change the amplitude in a way that depends on the line-width, as illustrated in the figure below.
In this figure I show a hypothetical single-line galaxy with a fixed intrinsic (input) peak-amplitude of 5.0 (arbitrary units) and varying line-width between 100 km/s and 5 km/s. I use a constant model pixel size of $\Delta v$=5.0 km/s and I show the initial model (blue squares) and the effect of resampling (orange points) and convolution (green xs). In each panel I also report the input theoretical flux, $A\sqrt{2\pi}\sigma\lambda_{z}/c$, where $A$ is the line-amplitude, $\sigma$ is the line-width (in km/s), $\lambda_z$ is the redshifted line-wavelength (in Angstrom), and $c$ is the speed of light (in km/s); it is this flux that is reported in the output tables (e.g., OII_3726_FLUX).  The legend then shows the percent error in the flux after each step in the algorithm.
At the moment I am uncertain how to proceed, so suggestions from anyone are welcome.

For the record there's no data in the figure above, but I am using a real resolution matrix from TARGETID=39627835538672534 on $DESI_ROOT/spectro/redux/iron/healpix/main/dark/273/27333/coadd-main-dark-27333.fits (see https://github.com/desihub/fastspecfit/pull/137#issuecomment-1650280434).
And the hypothetical emission line I'm investigating is [OIII] 4363 at a redshifted (z_RR=0.0594807) wavelength of 4624.0348. In the data this line should have an amplitude of ~0.4, but the code reports a totally incorrect amplitude of ~3.8, which is how this issue was discovered. Note that the line-width for this object is ~4.0 km/s.

This issue was a conceptual, not a computational error.
In essence, the (emission-line) velocity width and amplitude are measured in model space, before resampling and convolution. This is what we want for the line-width, because we want to know the intrinsic width of the line. However, for the purposes of determining if a line is significant (relative to the scatter in the continuum pixels), we want the observed line-amplitude, after resampling and convolution.
In #137 we address this issue by reporting the model amplitude in a new {LINENAME}_MODELAMP parameter and measuring the observed amplitude and reporting it in the {LINENAME}_AMP column of the data model (and so this change should not impact any existing code, which should continue to use {LINENAME}_AMP*np.sqrt({LINENAME}_AMP_IVAR} to assess the significance of an emission line.
Closing.


Use dns name for nodes

https://github.com/RocksLabs/kvrocks_controller/blob/ef4a9453ea1a0adb84232769b4187ea0813687b0/server/cluster.go#L44
There is restriction - cluster's nodes should set by ip in config. But in k8s env kvrocks more often run as statefulset with static DNS name and dynamic IP address.
So, it would be cool if the controller could use dns names instead if ip addresses.

Hi @paragor
Thanks for your feedback, will fix this in the next version.

can i do it?

@MateSousa Definitely yes, thanks for your interest.


[SPARK-33277][PYSPARK][SQL] Use ContextAwareIterator to stop consuming after the task ends.

What changes were proposed in this pull request?
As the Python evaluation consumes the parent iterator in a separate thread, it could consume more data from the parent even after the task ends and the parent is closed. Thus, we should use ContextAwareIterator to stop consuming after the task ends.
Why are the changes needed?
Python/Pandas UDF right after off-heap vectorized reader could cause executor crash.
E.g.,:
spark.range(0, 100000, 1, 1).write.parquet(path)

spark.conf.set("spark.sql.columnVector.offheap.enabled", True)

def f(x):
    return 0

fUdf = udf(f, LongType())

spark.read.parquet(path).select(fUdf('id')).head()

This is because, the Python evaluation consumes the parent iterator in a separate thread and it consumes more data from the parent even after the task ends and the parent is closed. If an off-heap column vector exists in the parent iterator, it could cause segmentation fault which crashes the executor.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests, and manually.

Test build #130388 has started for PR 30177 at commit b34805c.

Test build #130389 has started for PR 30177 at commit ac42502.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34991/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34991/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34991/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34992/

cc @BryanCutler for another look if you find some time.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34992/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34992/
Test PASSed.

Is this only for Apache Spark 3.1 and 3.0, @ueshin and @HyukjinKwon ?

I believe this is a long standing bug even for 2.4 releases ..

Thanks. Could you update SPARK-33277 accordingly?

Test build #130388 has finished for PR 30177 at commit b34805c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130388/
Test PASSed.

Test build #130389 has finished for PR 30177 at commit ac42502.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ContextAwareIterator[IN](iter: Iterator[IN], context: TaskContext) extends Iterator[IN]

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130389/
Test PASSed.

I am pretty sure this is the best effort we can make with a minimized change for now. I am merging it in, but please let me know if you guys have a different thought.
Merged to master.
@ueshin seems like it has a conflict. Would you mind opening a PR for branch-3.0 and 2.4?

@ueshin, seems the test can be flaky for the reason we discussed at https://github.com/apache/spark/pull/30177#discussion_r513898999, see https://github.com/apache/spark/runs/1338412158:

Shall we revert the test cases for now? I think the reproducer in the PR description is good enough for now.

Sure, could you revert it for now? I'll take a look later.

Let me monitor a bit more before reverting it. I just saw it once.

@ueshin, for some reasons, the tests became pretty flaky .. I will just revert as you said.

Thank you for reverting, @HyukjinKwon !

@HyukjinKwon Thanks, I'll include the reverted changes in #30242.


Add edit token functionality

Adds the ability to edit a MigToken from the tokens table. Currently, the only editable field is SA token until oauth is implemented. When you open the edit modal, all other fields are disabled including the ability to change the token type.
Closes #974
Closes #973

TODO:
#974
#973
#972

@ibolton336 are you thinking we should merge this as-is or are you planning to address those TODO issues in the same PR?

Aside from my couple of questions above, this code looks good to me! I'm having a bit of trouble getting my environment to play nice with your cluster though @ibolton336 so I can't test it... I sent you details on slack :(


Android: NoClassDefFoundError / 2.0.0-rc2

I am experiencing many crashes in the last time:
io.branch.referral.Branch.<clinit> (Branch.java:359)
com.MYAPP.MainApplication.onCreate (MainApplication.java:91)
android.app.Instrumentation.callApplicationOnCreate (Instrumentation.java:1013)
android.app.ActivityThread.handleBindApplication (ActivityThread.java:4889)
android.app.ActivityThread.access$1600 (ActivityThread.java:174)
android.app.ActivityThread$H.handleMessage (ActivityThread.java:1381)
android.os.Handler.dispatchMessage (Handler.java:102)
android.os.Looper.loop (Looper.java:146)
android.app.ActivityThread.main (ActivityThread.java:5752)
java.lang.reflect.Method.invokeNative (Method.java)
java.lang.reflect.Method.invoke (Method.java:515)
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1291)

ReactNative version 0.46.3
Android API Level 19-25
Package version 2.0.0-rc2
This is quite a random bug which I cannot yet reproduce.

@eneskaya Thanks for the bug report. I'm sorry you're having this problem. You say you cannot reproduce it. How do you know about it? Is there something like a Crashlytics report you could share? Did this happen after an upgrade to the latest version of react-native-branch, or is this the first time you've integrated the SDK? (In other words, have you also seen the problem with earlier releases?) It appears that the Branch SDK jar is not being found, but it's not clear why that would happen.

I see it in Firebase Crash Reporting:

(It's in German but you'll get the idea 😁)
I'm fairly new to Android, maybe I missed something here. But this seems quite crazy (70 crashes with 22 users)

Hi @eneskaya. The 2.0.0 release is out now in NPM. It's probably a good idea to update, but if you can't reproduce the problem, that doesn't tell you much immediately.
Did this start happening after an upgrade to the latest version of react-native-branch, or is this the first time you've integrated the SDK?
Does Firebase give you any more information about the device environment? It's not at all clear why it would not find the Branch jar.

Actually, what I believe by now is that it may be a general problem in our project. I have seen the same error with other libraries. Will check and report back.

Am 05.09.2017 um 23:14 schrieb Jimmy Dee<EMAIL_ADDRESS>Hi @eneskaya. The 2.0.0 release is out now in NPM. It's probably a good idea to update, but if you can't reproduce the problem, that doesn't tell you much immediately.
Did this start happening after an upgrade to the latest version of react-native-branch, or is this the first time you've integrated the SDK?
Does Firebase give you any more information about the device environment? It's not at all clear why it would not find the Branch jar.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok, I really have no clue what's going on here. And also, I looked into the crash reports more detailed and it's just the Branch SDK which causes the problem:
Exception java.lang.NoClassDefFoundError: io.branch.referral.Branch$CUSTOM_REFERRABLE_SETTINGS

If anyone has any experience with that I'd be very thankful for advice on how to troubleshoot this problem.

@eneskaya Do you still have this issue with latest versions ?

I have exactly the same problem problem with running on API 16 (works fine on later API's such as 25, 26). I'm running React Native version 0.53.3 and the branch package 2.3.0.

OK. Good to hear that it is working in latest versions.Thanks.

this issue still happening on latest branch unity sdk, android 4.4 crash with a NoClassDefFoundError.

In case anyone is still looking, this might be relevant https://github.com/BranchMetrics/android-branch-deep-linking/issues/493


Collapsible filter [ModelAdmin]

For example, i have Product model, and Vendor model. And of course, i want to filter Products by Vendor, on ProductAdmin page,
It's ok when you have like, 10 vendors, but when there is 100 of them, its a problem. Especially on mobile devices.

Hi @sourenaraya.
If you wanted a workaround for the meantime, last time I checked, Wagtail's modeladmin app supported custom Django filters in list_display, just like Django's equivalent does ( https://docs.djangoproject.com/en/dev/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_filter), so you could try giving that a go?
This behaviour isn't documented though, so best to use with caution.


problem in commit

in this commit on stable branch:
https://github.com/alexbers/mtprotoproxy/commit/73592c4f72632c5261dbba2d15b1f85c6d00088e
this line:
IPV4_URL1 = "http://v4.ident.me/)"
has a an extra ")" in it
the correction would be:
IPV4_URL1 = "http://v4.ident.me/"

Good catch! Fixed in https://github.com/alexbers/mtprotoproxy/commit/830d55fe7759871c7b0722a78522670b616c4001. Thank you!


Upstream features to the native Django backend

I'd like to try and upstream as much of this backend as possible to the native Django pylibmc backend.
From what I can tell the main django-pylibmc features that might want to be upstreamed, are:

[x] Binary mode support

Django ticket: https://code.djangoproject.com/ticket/15815
PR: https://github.com/django/django/pull/7160

[x] Username/password support

This requires binary mode support in addition
Discussion: https://groups.google.com/d/topic/django-developers/a6fACRkRCHQ/discussion
PR: https://github.com/django/django/pull/7160

[ ] Graceful catching/logging of the pylibmc exceptions to match the python-memcached behaviour

Django ticket: https://code.djangoproject.com/ticket/28342
PR: https://github.com/django/django/pull/8681

[ ] Support for compression

No Django ticket filed yet

Things that I don't think should be upstreamed:

Automatic handling of the MEMCACHE_* environment variables

these are likely best suited to something like https://github.com/rdegges/django-heroku-memcacheify or https://github.com/joke2k/django-environ (the latter being possible once this is upstreamed, since it doesn't support non-native backends at present)

Overriding the timeout handling

this is now redundant for the reasons mentioned in #35 / #36, so should be removed from django-pylibmc and not upstreamed

Edit: Have updated the list above to account for recent Django changes.

binary mode support
username/password support

Both of these are now supported with Django master (will be 1.11), as of django/django#7160.
I've also added support for comma-delimited LOCATION strings (currently handled by django-heroku-memcacheify).

FYI, since the old pull request has gone stale for a couple years, I have published a new pull request that seeks to resolve "Graceful catching/logging of the pylibmc exceptions to match the python-memcached behaviour": https://github.com/django/django/pull/12893.


[Diagnostics] Suggest platform correction based on known platforms edit distance

Use string similarity to suggest correct know platform in diagnostic and fix-it.

Resolves https://github.com/apple/swift/issues/61237

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test and merge


Share the psd for the icon?

It would be really nice if you could share the psd or the sketch you used to create that tool bar icon. Thanks.

this was done by @tborychowski in #8


BarCodeScanner: Get warning when calling from nested NavigationPages

Hello,
first of all thank you for your efforts. Great work!
I have a problem with the BarCodeScanner part of your library. I set all things up on the first page of my app (is the fastest to test the bahavior). There was all working well, so I transfered the code to a part of the app, which is in the deeper nested. I replace the normal NavigationPage with a new modal one. In this NavigationPage environment I call the scanner and get the following warning:
Warning: Attempt to present <ZXing_Mobile_ZXingScannerViewController: 0x201ee9e0> on <Xamarin_Forms_Platform_iOS_PlatformRenderer: 0x18847750> whose view is not in the window hierarchy!

The scanner page isn't shown.
I search for the problem and found the following StackOverflow message: http://stackoverflow.com/questions/20731716/monotouch-zxing-presenting-zxingscannerviewcontroller-failed.
It seems, that there are problems with the different NavigationPages I use. I use 1.3.3-pre2 and the NuGet version from today of your library. The problem exists on iOS.
Is there a workaround for this problem?
Thanky you very much in advance for your help.
Best regards,
Dirk

I haven't come across this issue myself.  Can you submit a gist with the issue?

It seems, that it is not a problem from your library, but from ZXing.Net. If you create a first NavigationPage and place a button on this page, which creates another NavigationPage, that is than modal pushed onto the first NavigationPage (with PushModalAsync) than you get this error.
It is enough to create the ZXing.Net object with the active UIViewController as parameter. I will send you some code and detailed explanations, if I turned the Mac on later :)

Internally, I suspect zxing is trying to find the top level window/view controller to present on.  This isn't an exact science unfortunately.
If you are using the user dialog library, can you try running a loading dialog on the page where barcode scanner is attempting to launch from.  It means that my "top scanner" works and could be applied to zxing.net.mobile.

I use only parts, but the functions to get the GetTopView() are the same as in your library. And yes, I could display ActionSheets on the modal NavigationPage.
I created a workaround. I call in the Read method of the BarCodeScanner object the following code:
		var controller = ((UIViewController)((ExtendedNavigationPage)App.GameNavigation).ViewController);
		var scanner = new MobileBarcodeScanner(controller);

The ((ExtendedNavigationPage)App.GameNavigation).ViewController)is a extension of a normal NavigationPage. On iOS I get the ViewController by
	protected override void OnElementChanged(VisualElementChangedEventArgs e)
	{
		base.OnElementChanged(e);

		((ExtendedNavigationPage)Element).ViewController = this.ViewController;
            }

This works.

This was fixed in Acr.BarCodes

Hi, I have the same problem, I'm using your var controller = ((UIViewController)((ExtendedNavigationPage)App.GameNavigation).ViewController);
But what is the ExtendedNavigationPage, GameNavigation and the .ViewController? Its a classo what? Can you pass me the code? Please


The express example does not work

Clone the project
run npm install
cd examples/express
node app
visit http://localhost:5000/

TypeError: connect-mincer-master/examples/express/views/home.ejs:5
   3| <head>
   4|   <meta charset='utf-8'>
>> 5|   <%- css('all.css') %>
   6|   <%- js('modernizer.js') %>
   7| </head>
   8| <body>

[LessEngine] Cannot set property 'asset_data_uri' of undefined (in connect-mincer-master/examples/express/assets/css/all.css.less)

Likewise, going to http://localhost:5000/assets/reset.css renders the reset.css file fine, but going to http://localhost:5000/assets/all.css throws a less compilation error.
[LessEngine] Cannot set property 'asset_data_uri' of undefined  (in connect-mincer-master/examples/express/assets/css/all.css.less)

Mincer Less engine seems to use internal structures of Less compiler to insert local functions (like asset_data_uri) to context (file engines/less_engine.js:166). The Less compiler code have changed recently so that 'less.tree' doesn't have the 'functions' field the Mincer less engine refers to anymore.
Would the maintainers of Mincer update the less_engine to handle newest Less compiler properly?

Seems this is a known issue with Mincer. Currently one must use an older Less (< 2.0.0) to make Mincer work.

where is the manifest.json or dose it still working with current mincer?


Feature/re add get provider address

Re-add DataServiceProvider.get_provider_address

How can you differentiate 2 assets, published by 2 providers which are using the same c2d backend ?


Become a TypeScript Dark Magician

Learning TypeScript
My playground.
Resources
Some interesting resources
Lectures

[x] How to TypeScript

Videos

[x] Template Strings

Challenges
TypeChallenges and their explained solutions.

This is too abstract, but I think I'm on the right track.


Create pipeline.tf

Moving model compilation and testing to a ImageBuilder pipeline will allow for reusable components and testing.
I hashed out a simple mockup of this in TF and have some additional tasks to complete before it'll be up and running:

[ ] Update account numbers
[ ] Add model scripts to components
[ ] Add components to Pipeline
[ ] Add tests after model compilation
[ ] Update Headnode resource to use Imagebuilder Pipeline image once it passes tests

Optional:
need to discuss components using EFS and not the root disk, I'll chat with Patrick about this.

@ZacharyWills Thanks.  I assume based on the comments this is still a WIP and not ready for review?

Yeah, for some reason it won't let me mark it as a draft PR. If you could do that it would be great!

Merged, sorry, I should have read your last comment first.


Windows defender Blocking install when installing Pglet

So this is how you repay us, Windows. Pglet isn't @beartype, though? Moreover, pglet doesn't internally leverage @beartype – yet, anyway. :smirk:
Did you mean to submit this to pglet's issue tracker instead, @da-geek-incite? Kinda feel like there's some cross-chatter in the line here. So, let's just quietly close this and pretend Windows Defender never saw nuthin'.
If this is indeed an actual @beartype issue, please reopen and we'll reassess the looming crisis of Pythonic malware at that point. :+1:


calamity overhaul messes with infernum skeletron primes ai

im unsure if this happens to other bosses but multiple people have confirmed it only happens with calamity overhaul enabled

Yes, this is indeed an issue that needs to be fixed. Please wait for the June 10th update


Remove warning about deprecated

changed is_cuda and type methods.
Error examples
/home/user/vision/torchvision/csrc/ROIPool.h:41:17: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
   if (grad.type().is_cuda()) {

/home/user/vision/torchvision/csrc/cpu/ROIAlign_cpu.cpp:410:50: warning: ‘at::DeprecatedTypeProperties& at::Tensor::type() const’ is deprecated: Tensor.type() is deprecated. Instead use Tensor.options(), which in many cases (e.g. in a constructor) is a drop-in replacement. If you were using data from type(), that is now available from Tensor itself, so instead of tensor.type().scalar_type(), use tensor.scalar_type() instead and instead of tensor.type().backend() use tensor.device(). [-Wdeprecated-declarations]
   AT_DISPATCH_FLOATING_TYPES_AND_HALF(input.type(), "ROIAlign_forward", [&] {

Codecov Report

Merging #2064 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2064      +/-   ##
=========================================
- Coverage    0.48%   0.48%   -0.01%
=========================================
  Files          92      92
  Lines        7411    7413       +2
  Branches     1128    1128
=========================================
  Hits           36      36
- Misses       7362    7364       +2
  Partials       13      13

Impacted Files
Coverage Δ

torchvision/utils.py
0.00% <0.00%> (ø)

torchvision/models/mnasnet.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61538c...9a20d55. Read the comment docs.


Rule: SA1009

Rule summary

Value

Title
SA1009ClosingParenthesisMustBeSpacedCorrectly

CheckId
SA1009

Category
Spacing Rules

Link
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1009.md

What is the problem
This rule sounds very nice as a starting point.
But in practice, there are many situations where it can not be done due to nested method call or general formatting for space optimization. Furthermore, after C # 8 with the nullable suppression operator !, this rule creates a lot of noise.
Example 1:
var myData = JsonSerializer.Deserialize<TEntity>(data!.ToString()!);

Then the rule says .ToString()! need a space like this .ToString() !. And this space is removed by the default Visual Studio's document formatter. And the use of the nullable suppression operator need to stick close to the type.
Example 2:
.ReturnsForAnyArgs((Entities.User?)null)

Then the rule says .ReturnsForAnyArgs((Entities.User?)null) need a space like this .ReturnsForAnyArgs((Entities.User?) null).
Furthermore, a solution with SuppressMessage attribute is overkill, therefore I recommend to suppress this rule since is obsolete in relation to C # 8 with nullable check activated.
Suggestion
disable this rule in root .editorconfig with dotnet_diagnostic.SA1009.severity = none

https://github.com/atc-net/atc-coding-rules/blob/main/documentation/CodeAnalyzersRules/StyleCop/SA1009.md


[ButtonGroup] docs not rendering.

This is not rendering. However, this works fine.
Maybe #56 is the problem?

It is because there is some error in mdx file. We need to debug this!

Currently resoved. See this for details.


Error detection in mergeEffects

I have not tested it but if a function that is decorated with the @Effect decorator does not return an observable the call to Observable.merge will error.
So maybe the call should be wrapped in a try catch block and a meaningful error should be thrown.

Should be fixed in v2.0.0

If not open up a new issue.


fix: return user already exists message on signing up more than once …

fixes: https://github.com/supabase/gotrue-js/issues/55
This issue occurs because of the SMTP frequency limit, so instead of showing the limit error (which occurs only when we execute the signup function more than once in a minute), we can show a message which says the user already exists (as the mail is just sent a minute before.)

hey @harshithpabbati, thanks for taking a closer look at this! Hmm, I feel that we shouldn't make this change because a registered user is a user that is already confirmed. The users table has a column called ConfirmedAt which is null if a user hasn't clicked on the confirmation link yet. I think it's also better to return an explicit error message so that the developer can tell what's the error at a glance.
Will keep this open for now in case you have a better suggestion! 🙂

Thanks for the PR @harshithpabbati !
if we check for MaxFrequencyLimitError then we should probably return an error message saying it has been rate limited. Also I think the original issue is for the case where email confirmations are disabled: supabase/gotrue-js#55

yeah, makes sense, I just changed it to throw an error saying too many requests, now I will look into the issue when email confirmations are disabled.

When email auto-confirmation is disabled then it tries to send the mail again and which will eventually throw a rate-limiting error (if they try to signup second time within a minute), when auto-confirmation is enabled there's no issue over there.


Use go's time library more consistently in RevInfo.

This change is

Review status: all files reviewed, 1 unresolved discussion (waiting on @kormat)

go/lib/ctrl/path_mgmt/rev_info.go, line 92 at r1 (raw file):

func (r *RevInfo) String() string {
	return fmt.Sprintf("IA: %s IfID: %d Link type: %s Timestamp: %s TTL: %ds", r.IA(), r.IfID,

Why did you remove the seconds unit?

Comments from Reviewable

Review status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

go/lib/ctrl/path_mgmt/rev_info.go, line 92 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
Why did you remove the seconds unit?

Because time.Duration has its own formatting, and it will handle it. E.g. 3 * time.Second produces 3s, 90 * time.Second produces 1m30s, etc.

Comments from Reviewable


Adding support for specifying loop/recursion unroll bounds

We have made (mainly @liammachado) some traction on integration symbooglix into the SMACK toolflow. One annoying issue that we identified is that symbooglix does not support specifying loop/recursion unroll bounds as a command line argument.
This was already discussed here:
https://github.com/smackers/smack/pull/155/files/98852f442e711acc042ad7285d7b2864754e127f#r58845496
This is quite inconvenient since at this point we do not have the same (or at least very similar) unroll semantics between Corral and symbooglix. So I am wondering if someone could maybe implement this features, it would be really helpful.

@zvonimir I should have some time this week to take a look at this.

@delcypher I noticed you've been playing with symbooglix recently (thanks!), and so maybe you could take a look at this issue as well. Thx!

@zvonimir Yes sorry. I haven't forgotten this issue but it's been hard to find time to look at it. I'm trying to fix failing tests right now. The test pass on my machine™ but don't seem to pass in TravisCI. Once I get the tests working again I'll hopefully find some time to implement the loop bound.

@zvonimir I've now implemented support for a loop bound. This supports nested loops. The loop bound is off by default but can be enabled with the new --max-loop-depth= flag.
Sorry this took so long. I've been very busy with paper deadlines until recently. This feature also required quite a bit of thought to get the design right.
There may be bugs in the implementation because it hasn't been heavily tested so please report any issues you hit.

Thanks @delcypher! We'll give it a try ASAP and let you know if we find any bugs.


As an end-user, it should be possible to specify a "default" input file in Setup(), to simplify automated tests.

For example, instead of:
// If the file name changes, then the entire code base will have to be updated
var filePath = new Expected().AsString("GenericBaseline.log");

you could:
var filePath = new Expected().AsString(Context.GlobalDefault);

Implemented by:

#6


Resizing window width does not refresh handles position

If the slider's width is relative to the window's width, resizing window width does not refresh handles position. For example, handles can be left outside the range of the ribbon if the window width is reduced.

Any updated on this bug would be appreciated!

I will try allocate time at this weekend for fixing this bug.

Kind of the same problem is when slider changes its position. For example if you move slider with css left attribute after its initialization the handle start jumping on drag.


first attempt for amazon science

Card preparer  for   AmazonScience/massive
a variation on theme  ethos.py

Created a new pull request, without the yaml file and all the card files,
Please approve the new one: #300


Extended vehicle API resources

Can you please add the Extended vehicle API resources for the non electric mild hybrids with AAOS, with the distance to empty and other resources. Thnx.

Please describe precisely which resources you need.  Link

Okay! Would you please send me your response from https://api.volvocars.com/extended-vehicle/v1/vehicles/{vin}/resources

Sorry for the question cause I'm new to this..
Do I need to publish my application so I can obtain the client_id and a client_secret, so i can then obtain the access-token for the query to get my resources response? Or there is another way without me publishing the app which is not needed for obtaining the vcc-api-key?

I figured it out..
This is the response:
"resources" : [ {
"version" : "1.0",
"name" : "averageFuelConsumption",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/averageFuelConsumption"
}, {
"version" : "1.0",
"name" : "averageSpeed",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/averageSpeed"
}, {
"version" : "1.0",
"name" : "brakeFluid",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/brakeFluid"
}, {
"version" : "1.0",
"name" : "carLocked",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/carLocked"
}, {
"version" : "1.0",
"name" : "distanceToEmpty",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/distanceToEmpty"
}, {
"version" : "1.0",
"name" : "engineCoolantLevel",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/engineCoolantLevel"
}, {
"version" : "1.0",
"name" : "engineHoursToService",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/engineHoursToService"
}, {
"version" : "1.0",
"name" : "frontLeftDoorOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontLeftDoorOpen"
}, {
"version" : "1.0",
"name" : "frontLeftTyrePressure",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontLeftTyrePressure"
}, {
"version" : "1.0",
"name" : "frontLeftWindowOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontLeftWindowOpen"
}, {
"version" : "1.0",
"name" : "frontRightDoorOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontRightDoorOpen"
}, {
"version" : "1.0",
"name" : "frontRightTyrePressure",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontRightTyrePressure"
}, {
"version" : "1.0",
"name" : "frontRightWindowOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/frontRightWindowOpen"
}, {
"version" : "1.0",
"name" : "fuelAmount",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/fuelAmount"
}, {
"version" : "1.0",
"name" : "hoodOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/hoodOpen"
}, {
"version" : "1.0",
"name" : "kmToService",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/kmToService"
}, {
"version" : "1.0",
"name" : "odometer",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/odometer"
}, {
"version" : "1.0",
"name" : "oilLevel",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/oilLevel"
}, {
"version" : "1.0",
"name" : "rearLeftDoorOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearLeftDoorOpen"
}, {
"version" : "1.0",
"name" : "rearLeftTyrePressure",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearLeftTyrePressure"
}, {
"version" : "1.0",
"name" : "rearLeftWindowOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearLeftWindowOpen"
}, {
"version" : "1.0",
"name" : "rearRightDoorOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearRightDoorOpen"
}, {
"version" : "1.0",
"name" : "rearRightTyrePressure",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearRightTyrePressure"
}, {
"version" : "1.0",
"name" : "rearRightWindowOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/rearRightWindowOpen"
}, {
"version" : "1.0",
"name" : "serviceWarningStatus",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/serviceWarningStatus"
}, {
"version" : "1.0",
"name" : "serviceWarningTrigger",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/serviceWarningTrigger"
}, {
"version" : "1.0",
"name" : "sunRoofOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/sunRoofOpen"
}, {
"version" : "1.0",
"name" : "tailGateOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/tailGateOpen"
}, {
"version" : "1.0",
"name" : "tankLidOpen",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/tankLidOpen"
}, {
"version" : "1.0",
"name" : "tripMeter1",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/tripMeter1"
}, {
"version" : "1.0",
"name" : "tripMeter2",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/tripMeter2"
}, {
"version" : "1.0",
"name" : "washerFluidLevel",
"href" : "https://api.volvocars.com/extended-vehicle/v1/vehicles/YV1XZK7V0P2982574/resources/washerFluidLevel"
} ]

Sorry for the question cause I'm new to this.. Do I need to publish my application so I can obtain the client_id and a client_secret, so i can then obtain the access-token for the query to get my resources response? Or there is another way without me publishing the app which is not needed for obtaining the vcc-api-key?

No, you only need your vcc-api-key. After you created the volvo app, your vcc-api-key exists.

Thhnx for the reply.. I figured it out. I got the test access token and got the resources listed (see above).
When I try to get the resources needed from the API I see that Average fuel consumption, Average speed and External temperature are not available cause the response is not valid yet..
but distanceToEmpty, Washer fluid level and Carlocked are valid!

Are you able to lock/unlock the car at this time ?
And are some of the connected-car api sensors working ?

Yes I'm able to lock/unlock the car. Haven't tried the AC switch yet.
Other sensors of the connected-car api that are working:

door sensors
window sensors
odometer (x10)
tyre sensors
fuel level

I'm mostly happy with the location api working now cause prior to that i had to use the airtag to get the location.. and to get the airtag into homeassistant there is an app for the MacOS but it needs to be open all the time.. so it was a hassle to use.

Nice, If those work, I will add only distanceToEmpty and washerFluidLevel as car lock status is available via the connected car api. Okay ?

Done with v1.6.1!

Hi again,
I installed the v1.6.1. but it doesnt work..
The log says:
Failed, Average Speed is unfortunately not supported by your vehicle.
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/distanceToEmpty
Failed, Distance to Empty is unfortunately not supported by your vehicle.
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/washerFluidLevel
Failed, Washer Fluid Level is unfortunately not supported by your vehicle.
But when When I try to get these resources directly from the API I can get them.
What may be the problem?

Please enable debug and send me the log

Where can I find the log? I have it installed as addon on HAOS .

This is the log file from HA Logs..
982ee2c4_volvo2mqtt_2023-06-29T17-25-30.555Z.log

Nothing. The log is truncated by the webinterface. Until now, I do not have a solution for this.
BUT, the two new sensors are the last. So the startup log should contain the necessary data for me.

And, pls show me your output from
https://api.volvocars.com/extended-vehicle/v1/vehicles/{vin}/resources/distanceToEmpty

This is from the startup log..
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/distanceToEmpty
Failed, Distance to Empty is unfortunately not supported by your vehicle.
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/washerFluidLevel
Failed, Washer Fluid Level is unfortunately not supported by your vehicle.
The output from:
curl -X GET 'https://api.volvocars.com/extended-vehicle/v1/vehicles/{vin}/resources/distanceToEmpty'
-H 'accept: application/json'
-H 'authorization: Bearer '
-H 'vcc-api-key: '
is
{
"distanceToEmpty" : {
"value" : "390",
"unit" : "kilometers",
"timestamp" :<PHONE_NUMBER>572
}
}%

Which return code does the API deliver ? 200 ? 201 ?

Would you please try this:
curl -X GET 'https://api.volvocars.com/extended-vehicle/v1/vehicles/{vin}/resources/distanceToEmpty' -H 'accept: */*' -H 'authorization: Bearer <your-access-token>' -H 'vcc-api-key: <your-vcc-api-key>'

it only gives me this response
{
"distanceToEmpty" : {
"value" : "390",
"unit" : "kilometers",
"timestamp" :<PHONE_NUMBER>572
}
}%

btw i´m doing it on terminal

I don't know what's wrong here. As my car is not allowed to communicate with the extended API, I can't test anything.
I will build a version with more logging later today to see what's going on here....

ok.. thnx

I managed to get this from your deubug log..
Starting GET call against https://api.volvocars.com/connected-vehicle/v2/vehicles/{0}/statistics
{
"status" : 200,
"operationId" : "7ae013b8-5e72-4e79-9567-c5a3b1754311",
"data" : {
"tripMeter1" : {
"value" : "0",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"tripMeter2" : {
"value" : "0",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"averageFuelConsumption" : {
"value" : "0.0",
"unit" : "liters_per_100_kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"distanceToEmpty" : {
"value" : "390",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"averageSpeed" : {
"value" : "1",
"unit" : "kilometers_per_hour",
"timestamp" : "2023-06-29T16:52:39Z"
}
}
}
Failed, Average Fuel Consumption is unfortunately not supported by your vehicle.
{
"status" : 200,
"operationId" : "7ae013b8-5e72-4e79-9567-c5a3b1754311",
"data" : {
"tripMeter1" : {
"value" : "0",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"tripMeter2" : {
"value" : "0",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"averageFuelConsumption" : {
"value" : "0.0",
"unit" : "liters_per_100_kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"distanceToEmpty" : {
"value" : "390",
"unit" : "kilometers",
"timestamp" : "2023-06-29T16:52:39Z"
},
"averageSpeed" : {
"value" : "1",
"unit" : "kilometers_per_hour",
"timestamp" : "2023-06-29T16:52:39Z"
}
}
}
Failed, Average Speed is unfortunately not supported by your vehicle.
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/distanceToEmpty
Failed, Distance to Empty is unfortunately not supported by your vehicle.
Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/washerFluidLevel
Failed, Washer Fluid Level is unfortunately not supported by your vehicle.
As you can see the..
https://api.volvocars.com/connected-vehicle/v2/vehicles/{0}/statistics
returns also the distanceToEmpty value correctly so we can get it from there..
I also see that in my Volvo API  when I select the Connected Vehicle API I have v1 in the request address (not v2 as in yours)
https://api.volvocars.com/connected-vehicle/v1/vehicles/{vin}/statistics'
so I think everything has to do with the version of API (v1 vs v2) which depends of type of vehicle (Recharge or PHEV or Mild Hybrid - MHEV)

I think I found the problem.. maybe.. ))
In your code you check for the  response
"status" : 200
from the server to check if something is supported or not.. am I right?
but in  extended-vehicle resources the server doesn't return the
"status" : 200
it only returns
{
"distanceToEmpty": {
"value": "300",
"unit": "kilometers",
"timestamp":<PHONE_NUMBER>633
}
}
so you get the
Failed, Distance to Empty is unfortunately not supported by your vehicle
and maybe you only have to bypass the "status" : 200 check for those resources?

Sure.. Those are http codes. I'm building a new version right now. Please wait a few more minutes.

So, please updat to v1.6.2, enable debug and send me your log from \\<Your HA IP>\addons\volvo2mqtt\log\volvo2mqtt.log.

ok.. done.. here the log..
volvo2mqtt.log

yes i figured it and deleted them.. my bad.. here the log again if you need it
volvo2mqtt.log

The api returns
`Jun 30 11:40:33 volvo2mqtt [79] - INFO: Failed, Distance to Empty is unfortunately not supported by your vehicle.
Jun 30 11:40:33 volvo2mqtt [79] - DEBUG: Starting GET call against https://api.volvocars.com/extended-vehicle/v1/vehicles/{0}/resources/washerFluidLevel
Jun 30 11:40:33 volvo2mqtt [79] - DEBUG: https://api.volvocars.com:443 "GET /extended-vehicle/v1/vehicles/XXXXXXXXXXXXXXX/resources/washerFluidLevel HTTP/1.1" 403 None
Jun 30 11:40:33 volvo2mqtt [79] - DEBUG: Response status code: 403
Jun 30 11:40:33 volvo2mqtt [79] - DEBUG: {
"exveErrorId" : "403",
"exveErrorMsg" : "Access is denied"
}`
This is the reason why the sensors are not coming up.
It looks like the token I recive from the api, is not valid for the extended-vehicle api. Maybe there is nothing I can do at this time.

ok.. but can you please add at least distanceToEmpty from the statistics part of connected-vehicle api
its showing the distanceToEmpty as you can see in the log..

Yes, this is the reason. With the test API token from the volvo developer page, the requests are working.
I'm planning to move to the "real" oauth2 authentication, but not yet. So at this time, there is nothing I can do for you, except add distanceToEmpty to the connected-vehicle API.

ok.. thnx again.. you are great!

Please try v1.6.3. And don't forget to disable debug ;)

ok. i'll try now and let you know.. ))

Success! Distance to Empty is supported by your vehicle.
You can now finally close this issue! ))

Nice!


:sparkles: add optional wandb logging

Quick patch to add optional wandb logging.
Haven't run this yet, so setting PR as draft for now.

I'd prefer to have a Logger interface so we could have 0-many loggers at once, including our print logging. But probably not worth the energy. @technillogue what do you think?

Worth investigating...perhaps a key not needed this way, then.
https://docs.wandb.ai/guides/app/features/anon


Redux-Toolkit Init?

Implementation of the Redux-Toolkit solves the major thing in the Frontend.Makes Frontend flow to next level

[ ] Making store makes easy access of values

Any Comments?
I am asking this question because we are not having that much nested components

I think we should just use useReducer, Context API, etc. and custom hooks and make use of what react gives us out of the box before we add more stuff to the project especially when theres still quite a bit to add.
Oh and this is better as a discussion in Discussion tab


temp: temp commit for PR testing

closing PR as generate-cache.yml workflow is working and cache is accessible in PRs from new branches


vector: fix compatibility with Rust 1.80

Description of changes
Rust 1.80 broke a lot of crates (https://github.com/NixOS/nixpkgs/issues/332957), including Vector. Upstream is working on a proper upgrade (https://github.com/vectordotdev/vector/pull/20949), but for now we can get it to build again by turning off the offending lint (the behaviour is as legal as it was before, it's just not declared to be intentional).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

All NixOS tests pass except for syslog-quickwit, which fails to compile quickwit because it is still using an old time (https://github.com/NixOS/nixpkgs/issues/332957).


Provisioning HA-Proxy on SSH creds (password) fails

When trying to install ha-proxy though the "proxy install" tab i get the following error.
The serves are set up for ssh authentication over user/password and i tested the connection though the "Check" button on the servers page. It apears to not be re-using the password for sudo access for anything on the site.
fatal: [<IP_ADDRESS>]: FAILED! => {"msg": "Missing sudo password"}

A password isn't re used for sudo. There is notice, that user must have sudo without password


fatal error: 'libelf.h' file not found #include <libelf.h>

wenhui-2:sim WenhuiZhang$ brew link<EMAIL_ADDRESS>Linking<EMAIL_ADDRESS>25 symlinks created
wenhui-2:sim WenhuiZhang$ brew install --HEAD osx-cross/avr/simavr
==> Installing simavr from osx-cross/avr
==> Cloning https://github.com/buserror/simavr.git
Updating /Users/WenhuiZhang/Library/Caches/Homebrew/simavr--git
==> Checking out branch master
==> make install DESTDIR=/usr/local/Cellar/simavr/HEAD-1ae1912 HOMEBREW_PREFIX=/usr/local RELEASE=1
Last 15 lines from /Users/WenhuiZhang/Library/Logs/Homebrew/simavr/01.make:
/Applications/Xcode.app/Contents/Developer/usr/bin/make libsimavr run_avr
CC sim/sim_cmds.c
CC sim/sim_cycle_timers.c
CC sim/sim_avr.c
sim/sim_elf.c:32:10: fatal error: 'libelf.h' file not found
#include <libelf.h>
         ^
1 error generated.
make[2]: *** [obj-x86_64-apple-darwin16.4.0/sim_elf.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CC sim/sim_hex.c
CC sim/sim_core.c
CC sim/sim_gdb.c
make[1]: *** [all] Error 2
make: *** [install] Error 2

Please always follow these steps:

[ ] Confirmed this is a problem with Homebrew/brew and not one or more formulae? If it's a formulae-specific problem please file this issue at https://github.com/Homebrew/homebrew-core/issues/new
[ ] Ran brew update and retried your prior step?
[ ] Ran brew doctor, fixed as many issues as possible and retried your prior step?
[ ] Ran brew config and brew doctor and included their output with your issue?

To help us debug your issue please explain:

What you were trying to do (and why)
What happened (include command output)
What you expected to happen
Step-by-step reproduction instructions (by running brew commands)

Please note we may immediately close your issue without comment if you do not fill out the issue template and provide ALL the requested information.
Or propose a feature:
Please replace this section with a detailed description of your proposed feature, the motivation for it and alternatives considered.
Please note we may close this issue or ask you to create a pull-request if it's something we're not actively planning to work on.

osx-cross/avr/simavr

report this to that tap.

Got it, thanks @MikeMcQuaid


Add delete and list functions

Add two functions, "delete_promotion" and "list_promotions", in route.py
Add two tests in test_route.py
Update README.md with information on current commands
Some update to be more aligned to PEP8 Python standard

ShengSiang, it seems like I need to be a Reviewer in order to review your pull request.


[Fix] Unify camera poses

Replace calib['K'] and calib['Rt'] with img_meta['depth2img'] for SUN RGB-D to be like img_meta['lidar2img'] for outdoor datasets. More discussion can be found in #620#issuecomment-859664418.
This PR affects visualization on SUN RGB-D and ImVoteNet model. I tested these 2 things. Validation mAP for SUN RGB-D improved from 64.04 to 64.61.

Sorry, will think about failed tests later.

Also the CI is broken. Probably not by my commit.

Also the CI is broken. Probably not by my commit.

Yes it's because of MMSeg version. Will raise a PR to fix it.

Hi @Wuziyi616 ,
I checked browse_dataset as you requested and fixed calib there. Now ImVoteNet visualization and browse_dataset visualization are the same for master and current branch. The results are in https://disk.yandex.ru/d/d_22eIbR_2yJyA .

Hi @filaPro, please merge master so that the CI failure caused by MMSeg version incompatibility will be solved. Then we can run CI to check your PR's correctness. Thanks.

@Wuziyi616 Done.
@THU17cyz Fixed your comments.


style fix for button class

Description of PR
a.button was given wrong flex property. Corrected it.
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
NA
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots

Patched :)


hyperion-webos/PicCap not capturing

Rooted with latest HBC, PicCap and HyperHDR
"board_type": "O22_DVB",
"product_id": "OLED42C24LA",
"core_os_release": "7.3.0-20",
"webos_manufacturing_version": "03.30.45",

Same issue here - solved with the following config:
{
    "vsync": true,
    "nogui": true,
    "nohdr": true,
    "quirks": 256,
    "fps": 30,
    "priority": 150,
    "height": 180,
    "nopowerstate": false,
    "width": 320,
    "backend": "auto",
    "address": "<IP_ADDRESS>",
    "port": 19400,
    "unix-socket": false,
    "autostart": true,
    "uibackend": "auto",
    "novideo": false
}

My tv has a similar Os version:
   "board_type": "LM21A_DVB",
    "hardware_id": "HE_DTV_W22A_AFADATAA",
    "product_id": "75UQ9000PSD",
    "core_os_release": "7.3.0-2407",
    "webos_manufacturing_version": "03.30.72",

@linton85: You should try to higher the resolution. As far as I've seen most of the libvtcapture TVs should use 320x - lower resolutions are only working for some video formats, but not all.
Furthermore capture will only start if a non drm protected video is playing. For the meantime it's possible, that you are receiving such kind of error. Capture init will be tried until a video is playing:
https://github.com/webosbrew/hyperion-webos/blob/10b638fffcb2dde62060f9cd64aad2d406278e73/src/backends/libvtcapture.cpp#L264-L267


Twl23 week5

You deleted the init.py inside postr and moved it to the main directory. That breaks everything, and it has to be undone.


[SPARK-8753][SQL][WIP] Create an IntervalType data type

We need a new data type to represent time intervals. Because we can't determine how many days in a month, so we need year-month interval type and day-time interval type, like hive did.
However, we need a further discussion to decide the detail of interval type syntax. Hive support interval '30-0' year to month and interval '3 0:0:0' day to second. Oracle has a detail definition of interval syntax, which is very similar to hive's.
Because we use number of 100ns as value of TimestampType, so it may not makes sense to support nano second unit.
TODO:

complete the syntax of interval literal.
improve doc and test.

cc @rxin

Merged build triggered.

Merged build started.

Test build #36544 has started for   PR 7226 at commit 0502af9.

Test build #36544 has finished for   PR 7226 at commit 0502af9.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36547 has started for   PR 7226 at commit 1adbae1.

Test build #36547 has finished for   PR 7226 at commit 1adbae1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

We should add a way to cast interval into string and string to interval too. That can go in a separate pull request though.

Merged build triggered.

Merged build started.

Test build #36572 has started for   PR 7226 at commit 9129ab0.

Test build #36572 has finished for   PR 7226 at commit 9129ab0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@cloud-fan actually upon further thought, I think it makes more sense to have a single IntervalType and internally represent it as a 12-byte value (1 long + 1 int). We can create a new class for it.

Merged build triggered.

Merged build started.

Test build #36683 has started for   PR 7226 at commit 3c641a0.

Test build #36683 has finished for   PR 7226 at commit 3c641a0.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36684 has started for   PR 7226 at commit 296dfb6.

Test build #36684 has finished for   PR 7226 at commit 296dfb6.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36685 has started for   PR 7226 at commit 504456c.

Test build #36685 has finished for   PR 7226 at commit 504456c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36691 has started for   PR 7226 at commit b1fc20f.

Test build #36691 has finished for   PR 7226 at commit b1fc20f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Interval(months: Int, microseconds: Long)

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36757 has started for   PR 7226 at commit ac348c3.

Test build #36757 has finished for   PR 7226 at commit ac348c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Interval(months: Int, microseconds: Long) extends Serializable

Merged build finished. Test PASSed.

looks good otherwise.

Merged build triggered.

Merged build triggered.

Merged build started.

Merged build started.

Test build #36789 has started for   PR 7226 at commit 632062d.

Test build #36787 has started for   PR 7226 at commit 43ccc80.

Test build #36787 has finished for   PR 7226 at commit 43ccc80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #36789 has finished for   PR 7226 at commit 632062d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public final class Interval implements Serializable

Merged build finished. Test PASSed.

Thanks - merging this in.

Should we make IntervalType an AtomicType?

hi @liancheng , I didn't make it extend AtomicType, as I haven't figured out how to compare intervals. 30 days and 1 months may have different compare result in different context.

@cloud-fan Thanks for the explanation :)


Prevent shuffling of data throughout featurewiz

Is it possible to prevent data shuffling throughout the featurewiz process?
My data has a temporal component (time series effectively) and shuffling doesn't make sense.
Perhaps there is a parameter already I can use to disable shuffling?
Thanks fro a great library.

Hi @markdregan:
This is a good question. 👍
I have now disabled shuffling for all Regression and TimeSeries problems. So if your target variable is float, then you should see that the order of rows is preserved. Please upgrade version 0.1.993 via:
 !pip install featurewiz --ignore-installed --no-deps --upgrade

Then you can try it  and if it works, close this issue!
AutoVimal

Thanks for the quick response and fix. 👍


incus/client: make platform list more permissive

Description of changes
Up until now the incus client inherited meta from incus "server", which was unnecessarily restrictive.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build incus.client

aarch64-darwin
/nix/store/6nn3rnvnlf5r6hwpmhwpyng3mvvci1zk-incus-client-6.0.0


add connection pool to sqlalchemy

this might be dumb, but I changed to using fastapi's app.state to provide access from a request object


Update js reference to fix the issue #5

👍 Ty qiansen1386

:smiley:

It's fixed in the latest release.


Stopped containers with sidekicks not showing up on host page

Rancher Version: v1.2.0-pre2
Steps to Reproduce:

Deploy a catalog with a service that contains a sidekick & an upgrade that upgrades the primary service
Upgrade the Stack

Results: The stopped primary Service is not showing up on the host page, but is showing up on main stack page and container page.
Expected:  Should be consistent and show up on host page as well.

Version - master 12/20
Now the stopped container from upgrade is showing up as a sidekick which is confusing.

#6998


リザルト画面の画像の位置を自由に変更可能に

段位道場やタワーはまだ出来てません

Hello, sorry for the late reply,
There is a text alignment issue on the Dan-i dojo's default values :

Would it be possible to keep the Left => Right alignement (And centred for the score) for the text values in all Ensou/Dojo/Tower results screen, as the numbers can get relatively big, to avoid overlapping with the adjacent textures ?

修正しました


wstool fails on ros_tutorials

Running
wstool init src melodic-ros_comm.rosinstall
proceeds fine until:
Exception caught during install: Error processing 'ros_tutorials' : [ros_tutorials] Checkout of https://github.com/ms-iot/ros_tutorials.git version init_windows into C:\ros_catkin_ws\src\ros_tutorials failed.
ERROR in config: Error processing 'ros_tutorials' : [ros_tutorials] Checkout of https://github.com/ms-iot/ros_tutorials.git version init_windows into C:\ros_catkin_ws\src\ros_tutorials failed.
The next step:
C:\ros_catkin_ws>rosdep install --from-paths src --ignore-src --rosdistro melodic -r -y
fails for every entry:
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
test_rosbag: No definition of [bzip2] for OS [windows]
python_qt_binding: No definition of [qtbase5-dev] for OS [windows]
nodelet: No definition of [uuid] for OS [windows]
....

Hi there,
We don't have a fork of ros_tutorials. We have upstreamed all of the work there, so it should use the mainline rosintall instructins.
We need to fix the documentation - where did you find instructions where it says to use ms-iot?

Hi Lou,
It’s on:
https://ms-iot.github.io/ROSOnWindows/Build/source.html
Should I use other instructions?
The following failure I mentioned is not related to tutorials, is it? But I thought that there might be something AFTER the tutorials that lead to failure in the next step.
Thanks,
Yuri

===============================================================================
Yuri Rzhanov
Center for Coastal and Ocean Mapping/Joint Hydrographic Center
University of New Hampshire
Tel: 1-603-8620075
Let go all your heartaches, it's as easy as being free
You don't have to wait a while
From: Lou Amadio<EMAIL_ADDRESS>Sent: Tuesday, May 5, 2020 1:41 PM
To: ms-iot/ROSOnWindows<EMAIL_ADDRESS>Cc: yrzhanov<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [ms-iot/ROSOnWindows] wstool fails on ros_tutorials (#216)
Hi there,
We don't have a fork of ros_tutorials. We have upstreamed all of the work there, so it should use the mainline rosintall instructins.
We need to fix the documentation - where did you find instructions where it says to use ms-iot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ms-iot/ROSOnWindows/issues/216#issuecomment-624203537 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCLEFA3LQPWKU4ZXLH3XPTRQBFRBANCNFSM4MZYTIRQ .  https://github.com/notifications/beacon/ABCLEFAIEMQAEJN5ESKKNPLRQBFRBA5CNFSM4MZYTIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEU2JOEI.gif

Hi @yrzhanov,
I haven't been able to repro this issue while using those instructions. I think the solution here is to find here is to find where you have a dependency on the no longer existent ms-iot fork of ROS tutorials.
Can you provide more information on how you set up your environment? What steps did you run before the ones described on https://ms-iot.github.io/ROSOnWindows/Build/source.html?
Thanks,
Lior

Hi Lior,
I repeated all the steps, and now running:
wstool init src melodic-ros_comm.rosinstall
returns:
Error: There already is a workspace config file .rosinstall at "src". Use wstool install/modify.
This file indeed exists and contains entries like:

git:
local-name: actionlib
uri: https://github.com/ros/actionlib.git
version: melodic-devel

However, the next step:
rosdep install --from-paths src --ignore-src --rosdistro melodic -r -y
gives the same:
C:\ros_catkin_ws>rosdep install --from-paths src --ignore-src --rosdistro melodic -r -y
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
nodelet: No definition of [uuid] for OS [windows]
tf2_bullet: No definition of [bullet] for OS [windows]
desktop: No definition of [ros_tutorials] for OS [windows]
....
Which definitions rodsep is looking for?
Thanks,
Yuri

@yrzhanov Thank you for the prompt reply.
There are a couple of things to be aware of.

Windows release for ROS includes many sub-packages contained within the metapackage. Because of this, rosdep can't see them. Some errors are actually not missing (like bullet).
the ROS ecosystem contains thousands of packages, not all have been enabled or released on Windows.
If a package hasn't been released as a chocolatey package (either by Microsoft or the package owner), then you can check the sources out and build them in your environment. For uuid, you can clone https://github.com/ros-geographic-info/unique_identifier into your workspace.

We are working on expanding the number of binary deployments by using github actions to build packages, and a rosdep extension which will extract the binaries off github.

Closing the issue. This should be a warning, not an error.
rosdep is not informed of how ROS is packaged on Windows, so issues errors. We are not planning on repackaing to eliminate these errors.


Automated Package Upgrade

:tada: This PR is included in version 12.4.34 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Populate OPA error messages in CloudWatch and CloudFormation

Right now when the hook fails all we see is: The following hook(s) failed: [Styra::opa::Hook] is it possible to populate the error messages generated in DAS back to CloudWatch and CloudFormation?

What kind of error are we talking about here?
If OPA responds with violations, we do log that to CloudWatch. If OPA responds with an error code, we log that as well.

ahh then it might be broken then. This is what I'm seeing in CloudWatch
Exception caught sequence item 0: expected str instance, dict found
Traceback (most recent call last):
  File "/var/task/cloudformation_cli_python_lib/hook.py", line 273, in __call__
    raise error
  File "/var/task/cloudformation_cli_python_lib/hook.py", line 262, in __call__
    caller_sess, request, invocation_point, callback, type_configuration
  File "/var/task/cloudformation_cli_python_lib/hook.py", line 100, in _invoke_handler
    return handler(session, request, callback_context, type_configuration)
  File "/var/task/styra_opa_hook/handlers.py", line 123, in pre_handler
    return opa_query(request, session, type_configuration, action)
  File "/var/task/styra_opa_hook/handlers.py", line 93, in opa_query
    message = " | ".join(body["violations"])
TypeError: sequence item 0: expected str instance, dict found

Alright :) Looks like we do log the error then, even if somewhat obtuse. Since the error message is the same as reported here, let's close this one in favor of that.