uses waiter principal in async status check requests

Changes proposed in this PR

adds the required waiter-principal settings
uses waiter principal in async status check requests

Why are we making these changes?
Ensures requests to the backend from Waiter have a valid principal in the request.

We should also update Kitchen to reject empty x-waiter-auth-user headers.

We need to handle authentication=disabled case, e.g. with a new start-up flag to bypass auth.


Rockstar Games Social Club has been logged out / Se ha cerrado la sesion en el Social Club de Rockstar Games

when i start the game this happens

When i get off Scripthook dot net of the main folder, the game starts correctly but the mods doesnt load
please help.

GTA 5 online doesn't work

GTA 5 online doesn't work

GTA 5 online

GTA 5 online doesn't work
Remove dinput8.dll from your GTAV folder. Either move it to a different folder, or delete it. This is not SHVDN's fault.


generate_captions.py errors!

Thanks for your excellent work. When I run your code I get the following error :
** File "/mnt/data/anaconda3/lib/python3.9/site-packages/clip_interrogator/clip_interrogator.py", line 85, in load_caption_model
caption_model = BlipForConditionalGeneration.from_pretrained(model_path, torch_dtype=self.dtype)**
OSError: We couldn't connect to 'https://huggingface.co' to load this file, couldn't find it in the cached files and it looks like Salesforce/blip-image-captioning-large is not the path to a directory containing a file named config.json.
Checkout your internet connection or see how to run the library in offline mode at 'https://huggingface.co/docs/transformers/installation#offline-mode'.
This should be a problem with my network. I tried to load the model manually, but I couldn't find a download link for the pre-trained Salesforce/blip-image-captioning-large model at huggingface.

Hi, you can try to clone the BLIP repository with their provided models via: https://huggingface.co/Salesforce/blip-image-captioning-large?clone=true.

Is it downloading the whole blip-image-captioning-large project locally and then loading it manually? Thanks for your help!

Is it downloading the whole blip-image-captioning-large project locally and then loading it manually? Thanks for your help!

Thanks, I have solved this problem.


Detect errors in Manim startup command

With the code from #33, the Starting Manim... command is currently run indefinitely when an error occurs in the Python terminal. I think we should definitely tackle this before the release to avoid frustrated users, e.g. when they don't already have Manim installed and click on Preview Manim Cell. Or when any other error occurs during the startup. Otherwise, we end up with an indefinite, non-cancellable notification.

Additionally, we could just open the terminal in this case, such that users directly see the error message if they didn't have the terminal opened beforehand.

I can tackle this once the current PRs until #33 are reviewed and merged.


Do not localize coordinate in info panel

IMO the whole use of the structured coordinate in the info pane is to reuse in search or wikipedia.
But the German number format "51,8852685, 8,478078"  is not parsable with its three comma.
ref #4672

Parsing the info panel might not be optimal, maybe there is a better alternative. What is the use case?

Ah this makes sense that people expect the coordinates to be copy-pastable into other systems.
@1ec5 does this sound ok?

I see. What if we omit the comma between latitude and longitude?

I always thought of the panel as being populated with human-readable text as opposed to machine-readable text. I’ve used some software (particularly on the Mac) that expects localized number input even for coordinates, but it’s true that this behavior is rare on the Web.
I’m not really opposed to unlocalizing this particular label, since the degree-minute-second label is still localized. On the other hand, if we figure out how to allow localized coordinates as input in the search bar, would it be confusing if this panel used unlocalized numbers?

Ok I ended up unlocalizing the decimalCoordinatePair function.
I don't think anybody would be likely to be confused by the output, which is my main concern.
We can revisit later if people want to.
(For example, removing the comma from the German translation on Transifex would also be an equally ok solution).


Allow to specify the json decoder

Thank you so much for strawberry-graphql! :cake:
With #2272, response JSON can be configurably encoded by overloading json_encode, likely meeting the needs of #1796.
It seems natural to offer a json_decode which might garner some additional throughput/memory gains, especially for large mutation payloads, etc.
Feature Request Type

[ ] Core functionality
[x] Alteration (enhancement/optimization) of existing feature(s)
[ ] New behavior

Description
Replace uses of json.loads with self.json_decode.
Sometimes json.JSONDecodeError are checked in try/except blocks: at least orjson subclasses this exception, but other integrations might need to be wrapped to overload them.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Great suggestion! I think we can do something like this, definitely worth thinking about the error handling part.
I also want to see us having one single HTTP (or two, one for async) class that does most of the processing and then our integrations delegate to that class so we can make it much easier to implement these kind of things in multiple integrations at once

I might do a POC for this HTTP class tonight, or maybe tomorrow 😊

I think this may now be addressed by overriding strawberry.http.base.BaseView.parse_json?
https://github.com/strawberry-graphql/strawberry/blob/04936fdd58f8fca058cc68fea5c5e46c82ac60ad/strawberry/http/base.py#L41-L45
For example:
from strawberry.fastapi import GraphQLRouter
import orjson

class MyRouter(GraphQLRouter):
    def parse_json(self, data: Union[str, bytes]) -> Any:
        try:
            return orjson.loads(data)
        except orjson.JSONDecodeError as e:
            raise HTTPException(400, "Unable to parse request body as JSON") from e

(Just commenting in case that helps to close it out 😄 )

@huonw yes, you're correct, thanks!


BwTree memory leak fix

From @wangziqi2013 in https://github.com/mbutrovich/terrier/pull/2

Problem Statement
We observed memory leaks while worker threads are inserting and scanning on the same leaf node. The leaked memory is always reported as being allocated inside the constructor of ForwardIterator, in which we perform a down traversal of the tree with the scan key. It seems that memory chunks allocated during this process is not properly added into the garbage chain or not properly released by the GC.
Solution
The current solution is to avoid adding memory chunks into the garbage chain while performing scans. This is made possible by switching to TraverseReadOptimized(), which ignores SMOs and over-sized nodes on its down traversal path. No consolidation, node split, and completion of partial SMO will be considered during this process.
Currently I have identified a problem with AtomicStack which is the lock-free implementation of a stack structure used for recycling node IDs of deleted nodes. It seems that this structure has subtle bugs that only occur under heavy contention. I have disabled AtomicStack, and replaced it with a deque from the standard library protected by a mutex also from std. The memory leak disappears for now, but I am not sure whether it may emerge in the future.

@wangziqi2013 do we need to make any changes to the comments around the modified code? Otherwise I'll probably merge this today. Thanks in advance!


A mixin class must have a constructor with a single rest parameter of type any[] => this is wrong

🔎 Search Terms
None
🕗 Version & Regression Information
Tested on the nightly build.
⏯ Playground Link
Playground Link
💻 Code
type Cstr<T> = {new(...args: any[]): T};

function mixins<T extends Cstr<any>>(klass: T) {

    return class Foo extends klass {

        readonly foo: number;

        constructor(foo: number, ...args: any[]) {
            super(...args);
            this.foo = foo;
        }
    }
}

🙁 Actual behavior
This raises the following error :
A mixin class must have a constructor with a single rest parameter of type any[]

🙂 Expected behavior
No TS errors should be raised.
Additional information about the issue
Instead of asking for a single rest parameters, TS should ask the last parameters to be a rest parameters.
Also, when #59812, is fixed, it should also be possible to do more complex constructor signatures, without relying on any[] :
type Cstr<T> = {new(...args: any[]): T};

type InferCstrParams<T> = T extends {new(...args: infer U): T} ? U : never;

function mixins<T extends Cstr<any>>(klass: T) {

    return class Foo extends klass {

        readonly foo: number;

        constructor(foo: number, ...args: InferCstrParams<T>) {
            super(...args);
            this.foo = foo;
        }
    }
}

Indeed, the constraints should be on the super() call, NOT on the mixins constructor.
This would also enable to generate the constructor parameters when the mixins e.g. has a type restrictions on klass, e.g. :
type Cstr<T, U extends any[]> = {new(...args: U): T};
function mixins<T extends Cstr2<any,[number]>>(klass: T) {

    return class Foo extends klass {
        constructor(a: number, b: number) {
            super(a+b);
        }
    }

}

This would also enable to create mixins taking many classes as parameters, etc.

You didn’t provide any search terms. Did you search for existing issues before filing this?
If you search for mixin constructor in:title there are lots of hits.
Duplicate

From #14126
It seems a simple cast removes the error :
return class Foo extends (klass as { new(...args:[]): any }) {
    constructor(foo: number, b: boolean) { /* ... */ }
}

Note: if we want to add the base class parameters to the mixins class, we need to do another cast, cf the issue.
Playground Link
Seriously, why are we forced to do such black magic found only in the darkness of the git issues, for such simple code ?


Application Crashing on Mac

At random times the application will crash while I am tracing. It has been happening for a while now with all the versions and I've tried to work around it, but it is now becoming very annoying because I will be in the middle of working on the nucleus and it crashes and doesn't save that work. I am on the most current version (18) and it seems the issue has become worse compared to version 17.

Sorry to hear that. If you can provide any more details on what specific operations you were performing leading up to the crash(es), I can try to look into it.

Hey, David! In the most recent versions (16-18), the crashes weren't really caused by a specific operation; I am usually just tracing and it suddenly crashes, resulting in lost work. When I first started tracing (version 12 or 13), I noticed it would crash when I pressed redo/undo a couple times, so I stopped using those functions entirely to avoid the crashing. Other people with Macs on the team have also experienced these crashes. I'm sorry I couldn't be of much help explaining, but if it would be useful I can screen record from the moment I open the application to when it crashes? Let me know if you want me to do that.

That would be useful, thanks. I'll also look into logging user interactions to a file which should help in debugging these types of problems.

Can you let me know the specs on the computer you are using (mostly care about RAM)?

I've uploaded a picture that shows all my computer's specifications

Thanks. Specs look good.

https://drive.google.com/file/d/197Ahx7-4YuFIEDeLKhHhdMAIi9Otodt3/view?usp=sharing
I finally caught a crash on recording! The url will take you to the 25 minute video showing from the moment I opened the image and segmentation to when it crashed.

Prior to this crash, it happened twice within the hour. I have a theory that they happen when working on nuclei near the edges of images (this is based the 3 times it happened recently).

Ok, thanks. I'll take a look.

@talafar can you also send me the input data you were using (image fileand segmentation/json file if any) for this? You can just slack it to me. Thank.

Hey @talafar, I'm looking into this some more now. I noticed that you were editing in the 3D view at the edge of the volume when the crash happened. Is that normal, or does it also happen in other situations?

@talafar I think I fixed this in the most recent release (v0.3.0). It was due to the 3D highlight circle which could cause the program to try to lookup data outside of the volume.


chore(docs): Update internal jsdoc for components and functions throughout

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant
[x] README.md has been updated with your changes, if relevant

Describe your PR
This updates all the jsdoc in the boilerplate app to be proper syntax with params and returntypes.
I also updated all internal documentation links to point to docs.infinite.red
This shouldn't interfere with other ongoing docs changes like #2624

:tada: This PR is included in version 9.4.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(client): Fix queryRaw methods within itx when extensions are used

Stop passing MergedExtensionList property through itx proxy.
Fix #19651

I continued your PR here https://github.com/prisma/prisma/pull/19691


perf(table): Slightly improve speed of adding/remvoing sticky styles

In the longer run, it'd be nice to remove the addition of inline styles entirely (and have some simple CSS attached to CdkTable).

@kseamon can you rebase this PR?


SuccessStory 3.4

Hi! I just discovered your fork of SuccessStory, and I love it ! Thanks for your amazing work. 😊 However, the latest version of SuccessStory includes a really handy feature: sorting trophies by unlock date (ascending or descending) in fullscreen mode. Do you think it would be possible to update your fork to include this option ?

Hi! I just discovered your fork of SuccessStory, and I love it ! Thanks for your amazing work. 😊 However, the latest version of SuccessStory includes a really handy feature: sorting trophies by unlock date (ascending or descending) in fullscreen mode. Do you think it would be possible to update your fork to include this option ?

Hi, not sure but believe you’re talking about my fork?
I have merged all the changes already but there’s a slight problem with Xbox360 achievements atm. I will get this sorted this week and will release the new update.
The new update will also include ShadPS4 achievements


Very Minor misleading instruction.

In stage 2, on step 13. It says to click OK. this should be on 14. Its minor and wouldn't probably give most people a hard time but as somebody who never uses VS Mac It had be wasting a good 20-25 Mintues looking for compiler settings everywhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e40fbe03-a099-3b24-4654-162103003d6a
Version Independent ID: 01e8c667-ed94-7054-758d-2399e879714a
Content: Use C/C++ libraries with Xamarin - Xamarin
Content Source: docs/cross-platform/cpp/index.md
Product: xamarin
GitHub Login: @mikeparker104
Microsoft Alias: miparker

I confirmed that the "Click OK" line is too early and made the necessary edit in https://github.com/MicrosoftDocs/xamarin-docs/compare/live...lobrien-patch-2?quick_pull=1


fix: unbreak nested sets (CSS-229)

Description
The nested sets block was missing for a few Radio Button tokens
Related Issue
https://jira.corp.adobe.com/browse/CSS-229
Motivation and Context
Bug
How Has This Been Tested?
Rebuilt CSS, problem gone
Screenshots (if appropriate):
Before

After

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@lazd did you mean to make this pr to the beta branch?

:tada: This PR is included in version 12.0.0-beta.44 :tada:
The release is available on:

GitHub release
npm package (@beta dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Why is it not possible to connect Python/R to Power BI through WSL 2?

I'm currently on a new learning journey, recently upgraded to Windows 11 and discovered WSL 2. As a Power BI beginner user, I've tried to set both the Python and R home directories to the bin folders I already have in WSL 2 and it refuses to open them.
Can you please explain how Power BI interfaces Python and R so a connection through WSL 2 is not possible? I couldn't find an answer in the documentation.
In 'Create a Python/R script', it's not mentioned that WSL 2 directories can't be used.

Thanks for your comment, @vasilygrz. This issue has been assigned to the doc author for review.

Thanks for your comment, @bishalgoswami.
This looks like a support request or product question rather than documentation feedback.
You might find a solution in the Power BI Community. If not, try our support page.


[Feature]: Click to add a new row in the table

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Allow users to add a new row in the table with the data.
Link to PRD - https://www.notion.so/appsmith/Adding-a-new-row-in-the-table-0ec90544d26c4c25ab1f9b2504e919a1
Link to design - https://www.figma.com/file/aJ2Hwz9gH5AK6zaRYtZV8a/Table-widget-update?node-id=2119%3A132071
Why should this be worked on?
This will make tables support building full fledged apps

Checked DP, Issued added in PR @sbalaji1192

tested and looks good . This was fixed by 17515


Test another wallet with lightwalletd + Zebra

Motivation
Same rationale as #4450, but since ZecWallet might get deprecated, we might want to test with another wallet.
Specifications

Designs
Choose/experiment with other wallets, and test it. One natural choice would be Nighthawk, but it's mobile-only, which may make testing awkward (though you can run it in an Android emulator)
Related Work

I tested successfully with Nighthawk android with upstream lightwalletd. It showed my balance, and allowed me to send transaction and showed received transactions.
Since it connects to HTTPS, you'll need a certificate for the lightwalletd server.

I created one with mkcert :

mkcert <YOUR_IP> <IP_ADDRESS> localhost

(Substitute with the IP of the machine you're running lightwalletd.)

Rename the cert and key to cert.pem and cert.key, put them in the same folder you will run lightwalletd (or point to the files using the lightwalletd CLI, check its help)
Start the lightwalletd server WITHOUT ----no-tls-very-insecure

Then run Nighthawk:

Checkout source and follow the README instructons (install Android Studio).
If an Gradle error shows up, accept the fix
Change the build variant (bottom left tab) to zcashtestnetDebug
Change the manifest per these instructons (e.g. add a android:networkSecurityConfig="@xml/network_security_config" and create a xml/network_security_config.xml file with the contents in the link
Copy the root CA from mkcert (it's in the path reported by mkcert -CAROOT) to raw/debug_cas (i.e. debug_cas is the name of the file)
Pair your phone on the device manager (a simulator doesn't work; the app shows an error if you use one)
Run the app
Change the lightwalletd server to your IP

Done, someone reproducing the steps is not needed at this time, Adi might help us test this further


Crash when trying to travel to Embark Beach on lvl 4 Canthan character

For any other ineligible destinations it just gives the usual error message in chat without crashing.
(Reproduced it multiple times on the same character, but when I tried on another character, my lvl 10 Tyrian one managed to travel to Embark even though he's still in Ascalon and doesn't have access to the boat icon. I don't have any other characters that shouldn't be able to travel there, nor free slots to make another Canthan, so can't really test it further.)
GitHub doesn't let me upload dmp files, so I zipped them.
3.8.1-20200922-022347-11124-6980.zip
3.8.1-20200922-022429-4400-11236.zip

#426

#426

Fixed in dev https://github.com/HasKha/GWToolboxpp/commits/ea6da7876ff1261d0c8b62bcf5e194c5f68b0d70


Added Subtract Quantity Test

Description of the Change
Added a subtract asset quantities test for error free working of the same command.

Benefits
Error free deletion of asset quantities.

Possible Drawbacks
None.

Usage Examples or Tests [optional]

Alternate Designs [optional]

Closing due to lack of activity. You are welcome to reopen the pull request when the requested changes are made.


native support for running as a Windows service?

@zaher successfully wrapped Oragono on Windows with nssm; there's also https://github.com/kohsuke/winsw. However, we may want to add native support for running as a Windows service, with something like https://github.com/judwhite/go-svc.
If we decide against this, we may want to write a manual entry describing how to configure one of the wrappers like nssm.

We used Oragono for year as Debian services worked stable, then our company moved to use Windows server, Installed it using nssm, it is easy for owner of company, but still make it not easy that we need to install 2 projects instead of one,
with nssm we it is running stable for another year too, supporting clients inside a real project.
With built in service for windows Oragono will be completed beside a full of features that we need.


Imageloader loads from internet before disk cache

When in airplane mode the phone loads all the photos from disk cache, when connected to the internet it tries to reload them from the internet. It gives the error Image cant be decoded whether or not im connected to the internet, then gives a false url with a size with the error. I am using the display image method.
here is the error
07-09 15:01:58.241  23458-24032/com.myapp.myapp I/System.out﹕ (HTTPLog)-Static: isSBSettingEnabled false
07-09 15:01:58.241  23458-24032/com.myapp.myapp I/System.out﹕ KnoxVpnUidStorageknoxVpnSupported API value returned is false
07-09 15:01:58.761  23458-24032/com.myapp.myapp E/ImageLoader﹕ Image can't be decoded [https://mysite_1440x640]
These are my configs
DisplayImageOptions defaultOptions = new DisplayImageOptions.Builder()
            .cacheInMemory(true)

            .cacheOnDisk(true)

            .resetViewBeforeLoading(true)

           .bitmapConfig(Bitmap.Config.RGB_565)

            .build();
    ImageLoaderConfiguration config = new ImageLoaderConfiguration.Builder(getApplicationContext())
            .defaultDisplayImageOptions(defaultOptions)
            .memoryCache(new WeakMemoryCache())

           .threadPoolSize(5)

            .build();
    ImageLoader.getInstance().init(config);

https://github.com/nostra13/Android-Universal-Image-Loader/wiki/Useful-Info Item 9

@nostra13 But my question is, why is it only loading from disk cache while in airplane mode, otherwise it reloads them from the internet? It just doesnt load them from the cache while it has an internet connection. It used to, before i updated the JAR.

It should load from disk cache if there is cached image.
Are you sure UIL loads from disk if no internet and loads from network if it has internet?

@nostra13
Yes, if i have 3g, the images stay blank for a few seconds while trying to load them and making data requests and eventually they load in (obviously i saved them to the disk cache before testing this), and if the phone is in airplane mode, they all load instantly from the cache. I tested it by storing them as specific sizes, if the size is less than 200 x 200 it is from cache otherwise it is from the internet. While it has internet all photos are their original sizes, while it does not have internet, they are all the scaled down versions stored in the cache.

Or rather, any internet connection, i just used 3g to demonstrate that I could see the images loading too slow to possibly be from the disk cache.

maybe you can ask to this website www.smspromedia.com


cmd/link: unexpected trampoline when cross-compiling to ppc64le

What version of Go are you using (go version)?

$ go version
1.16.3

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOVERSION="go1.16.3"

What did you do?

Cross compile OpenShift's oc command from x86_64 to ppc64le.
git clone https://github.com/openshift/oc.git && pushd oc
make cross-build-linux-ppc64le

What did you expect to see?
Program builds.
What did you see instead?

The issue was not seen prior to upgrading openshift/oc to use kubernetes 1.21.
The issue also occurs in Go versions 1.15.8 through 1.15.10, which are the only versions of 1.15 I've tested.  However, it produces the error against different oc functions in Go 1.15 vs. Go 1.16.
Interestingly, 1.16 and 1.16.1 seem unaffected.  The issue appears again in 1.16.2, and seems to be triggered by https://github.com/golang/go/commit/a9547ad8adc72d245dac4408eaaef33aa331478a#diff-aa02dd8eebb2420ba09bee48832b239fc5f612a07cb7b1709595511fa1d8d0ca.  This commit might just uncover the issue rather than be it's direct cause, though, I'm not certain.

CC @cherrymui @mdempsky via https://dev.golang.org/owners

It is on my plan to rework trampoline insertion in the linker, that should address this. Hopefully I can get it in for 1.17.

Thanks for the quick feedback!
I'm curious if there might be also a possibility for an interim patch to 1.16 in the meantime.  One thing that does seem to get the linker past the issue is adjusting this condition to check for ctxt.IsExternal(), to closer match the earlier conditional here.  I'm not sure if this is the correct thing to do though.  I think it depends whether it's valid for the linker to arrive at line 706 with any of those configuration options when using internal linking.

@dbenoit17 thanks for the comment. I'll take a careful look.

@dbenoit17 sorry for the delay. As you said, I don't think we use internal linking for any of those configurations. I.e. IsExternal should always be true at that point.
Could you share how the "go" command or the linker is invoked in your build process, and what build mode are you building for? Thanks.

This seems to be caused by the combination of:
CGO_ENABLED=0 and something in openshift/installer using the plugin package causing canUsePlugins to be set, which causes (*Link).DynlinkingGo() to evaulate true, and causes the panic noted above.
Given that plugins are effectively disabled in the above case, shouldn't canUsePlugins also be set to false when linking?

To hit the issue, go build  is called against openshift/oc commit 90af8a5d7a1ae91e3e675607c4f76a403e6ec817 by the Makefile using CGO_ENABLED=0, with the invocation:
go build -mod=vendor -tags 'include_gcs include_oss containers_image_openpgp' -ldflags "-X github.com/openshift/oc/pkg/version.versionFromGit="v4.2.0-alpha.0-1048-g90af8a5" -X github.com/openshift/oc/pkg/version.commitFromGit="90af8a5d7" -X github.com/openshift/oc/pkg/version.gitTreeState="clean" -X github.com/openshift/oc/pkg/version.buildDate="<date>" -X k8s.io/component-base/version.gitMajor="1" -X k8s.io/component-base/version.gitMinor="21" -X k8s.io/component-base/version.gitVersion="v0.21.0-beta.1" -X k8s.io/component-base/version.gitCommit="90af8a5d7" -X k8s.io/component-base/version.buildDate="<date>" -X k8s.io/component-base/version.gitTreeState="clean" -X k8s.io/client-go/pkg/version.gitVersion="v4.2.0-alpha.0-1048-g90af8a5" -X k8s.io/client-go/pkg/version.gitCommit="90af8a5d7" -X k8s.io/client-go/pkg/version.buildDate="<date>" -X k8s.io/client-go/pkg/version.gitTreeState="clean"" -o '_output/bin/linux_ppc64le/oc' github.com/openshift/oc/cmd/oc

I think this is using using buildmode=default since there is no buildmode specified.
As a follow-up, I've had a chance to test https://golang.org/cl/314449 and can confirm it resolves the issue.

I think this is using using buildmode=default since there is no buildmode specified.

It was originally thought that the messages about dynamic linking were due to a buildmode setting, but that turned out not to be the case. Code that uses plugins is usually compiled as PIC (i.e., like shared or dynamic linking) but if CGO_ENABLED=0 then plugins are disabled and then not compiled as PIC so that led to confusion in the linker and the errors.

@gopherbot please consider a backport to 1.16. This seems to a be a regression from go 1.16.1 to 1.16.2.
I don't think a backport to earlier versions is necessary since the issue likely affects all 1.15 releases. It might be possible to workaround by not disabling cgo, or using external linking.


Server crashes every 5min/nobody is able to join it

Issue description:
After the server starts up it wont let anyone join it and crahses shortly after. We are using addons with RS so that might be an issue too?
What happens:
Server wont respond after startup.
What you expected to happen:
Steps to reproduce:

Start server
Try to join/do anything in console
Wait till it crashes

Version (make sure you are on the latest version before reporting):

Minecraft: 1.12
Forge: 1.12.2-<IP_ADDRESS>05
Refined Storage: 1.6.3

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:
https://pastebin.com/VcuUC3SZ
[pastebin/gist/etc link here]

Are you using QuantumStorage disks?

https://github.com/gigabit101/QuantumStorage/issues/154


Contributing: feedback from the embedded feedback form

@galaxyproject/training-contributing
Notes for all tutorials in this topic (16.09.2019):

Details per tutorials:

Contributing with GitHub via command-line

Pro:

It's easy to understand (26/08/2019)
Every thing was great especially the graphics. Thanks for all the help!! (30/08/2019)

Con:

More diagrams (26/08/2019)
Every thing is fine and up to date though I am not an expert! (30/08/2019)

Creating a new tutorial

Pro:

the option to automatically extract all steps of my workflow instead of typing them all is sooooo increadibly helpful!!! (16/02/2019)

Including a new topic

Running the Galaxy Training material website locally

Pro:

Very very straightforward ! (22/10/2018)
Clear wording. (08/02/2019)
Clearly explained.  (19/06/2019)

Con:

Nothing... (22/10/2018)
As a Windows user, I was not able to install requirements successfully. (08/02/2019)
In the first step (install requirements) - does there need to be an extra step before step 5, that says "conda activate galaxy_training_material" ?  (19/06/2019)

Now moved here: https://training.galaxyproject.org/feedback


Cache is not invalidated correct after updating an item

Summary of the issue
We use the EFCoreSecondLevelCacheInterceptor together with EasyCaching since some month an in the last time we had often the problem, that updated data are not displayed correct. The data get updated in the SQL database but the frontend shows the old data. It happens in most cases if the software runs some days and after a restart everything works correct again.
After some testing and debugging it looks like that the cache key gets not invalidated if the data are updated.
But the error was only reproducable if I reduce the SizeLimit.
I used also your source to debug and what I found out was the following:
I started the software and clicked around in one table that every data are cached (The number of requests was about 15; Cache sizelimit was 10). Then I switched the page, loaded the data (one request) and switch back to the previous page. Then I updated something and sometimes the "ClearDependencyValues"-Method in the EFeasyCachingCoreProvider was called with all the dependencys (cached requests) for the table and they were removed --> everything works correct.
But sometimes in the "ClearDependencyValues"-Method where only two or three dependenyKeys even if I clicked on much more items before (about 15). Then the update was done but the old data where still displayed. In the Method "ProcessExecutingCommands" from DbCommandInterceptorProcessor I saw that the CacheKey for loading the data still exists with the old data (it was not deleted). If I updated again something the "ClearDependencyValues"-Method was in most cases called without any dependency for this table and the old data were loaded again because the key still exists in the cache.
Sometimes it helps to click around in the application (I think because then the old cacheKeys were deleted regarding the sizelimit) but otherwise the data were not displayed correct (still the old ones).
So my assumption is that cacheKey for the table with all dependenies was deleted from cache because of sizeLimit but the cacheKey with the data was not deleted. Than if the data are updated the cacheKey with the old data can not be deleted because the mapping to the table was deleted through the deletion of the table-cachekey. This is why it loads the old data until also the "old" cachekey for the data was deleted from the cache.
But that's only a guess from myside. For sure it can be something else...
It would be nice if you can check it.
Environment
.NET (Core) SDK version: .NET Core 3.1
Microsoft.EntityFrameworkCore version:  5.0.8
EFCoreSecondLevelCacheInterceptor version: 3.8.1
Database: (e.g. SQL Server, SQLite, etc.) SQL Server 2017
Cache provider: (e.g. in-memory, redis, etc.) EasyCaching.InMemory 1.7.0

Example code/Steps to reproduce:
That was my configuration for testing.
For production we use the default values of InMemoryCachingOptions.
            const string CachingProvider = "InMemoryCachingProvider";
            services.AddEFSecondLevelCache(options =>
                options.UseEasyCachingCoreProvider(CachingProvider)
                .DisableLogging(true)
                .UseCacheKeyPrefix("EF_")
                .CacheAllQueries(CacheExpirationMode.Sliding, TimeSpan.FromDays(3))
            );

            services.AddEasyCaching(options =>
            {
                // use memory cache with your own configuration
                options.UseInMemory(config =>
                {
                    config.DBConfig = new InMemoryCachingOptions
                    {
                        // scan time, default value is 60s
                        ExpirationScanFrequency = 10,
                        // total count of cache items, default value is 10000
                        SizeLimit = 10,
                        // enable deep clone when reading object from cache or not, default value is true.
                        EnableReadDeepClone = true,
                        // enable deep clone when writing object to cache or not, default value is false.
                        EnableWriteDeepClone = false,
                    };
                    // the max random second will be added to cache's expiration, default value is 120
                    config.MaxRdSecond = 120;
                    // whether enable logging, default is false
                    config.EnableLogging = true;
                    // mutex key's alive time(ms), default is 5000
                    config.LockMs = 5000;
                    // when mutex key alive, it will sleep some time, default is 300
                    config.SleepMs = 300;
                }, CachingProvider);
            });

I should be able to reproduce a problem. I can't turn your story to a test.
SizeLimit = 10 and ClearDependencyValues didn't work. Yes, it won't work. It needs more space.
Don't use easy-caching if you are going to use a memory cache. It was added to support Redis and nothing else. Use the built-in one for memory caching.

Thanks a lot for your fast response!
Then we will switch to the build-in memory caching and hope the errors will not occure any more.
And if it is not recommended to use the inmemory cache from easy-caching I would remove this from your description
Here you can use the EasyCaching.Core, as a highly configurable cache manager too. To use its in-memory caching mechanism, add this entry to the .csproj file:
Or add a hint that the SizeLimit has to be greater then the expected CacheKey count.


routes support

Description
add Route configurations for OpenShift
Related Issue

Fixes #652

How Has This Been Tested?

test environment: k8s,oc

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[x] Documentation generated (make docs) and committed
[ ] Documentation ticket raised:
[ ] Documentation PR created:

@case0sh could you please check drone. The CI checks fail currently: https://drone.owncloud.com/owncloud/ocis-charts/1861/2/6

@case0sh @d7oc I was looking at some Grafana and Bitnami Helm Charts and didn't find any Chart that supports OpenShift Routes. Can you please check if you can find a reputable Chart that has it? I always prefer to have a look at how it's done in reputable charts before adding our homebrewed variant of it.

From what I remember, we'll not gonna add routes to the oCIS chart. They can be included via https://github.com/owncloud/ocis-charts/blob/c6ef3d2de98ec5caccf00f367a42047e931e0596/charts/ocis/values.yaml#L845-L847


Forever loop syntax......?

I just wrote something like this:
import "stdlib/io.jou"

def main() -> int:
    cnt = 0
    flag = True
    for i = 2;;i++:
        for j = 2; j <= i; j++:
            if not flag:
                break
            for k = 1; k < j; k++:
                if i == j * j - k * k:
                    cnt++
                    flag = False
                    break
        flag = True
        if cnt == 2023:
            printf("%d", i)
            break
    return 0

I think
for i = 0;;i++: # This is a forever loop!

But
compiler error in file "test.jou", line 6: expected an expression, got ';'

So, should we add a forever loop syntax...?

Jou is explicit: if you want the condition to always be True, you should write True. So for i = 2; True; i++.

thanks


Make it possible to remove "Move to a new file" from code actions

Hi! Is it possible to make it possible to remove "Move to a new file" from code actions as it is with "Add missing imports" etc?
Make it possible to remove/hide "Mobe to a new file" option:

My setup:

Full config: https://github.com/jonasnilsberg/nvim-config

+1 🙏
Extremely annoying that it's always a the top. I use a completion ui with preview and sometimes the preview result covers the entire screen + causes lag due to diff size.

it's the last code action on typescript-language-server, it could be great to do the same as it's usually not what you want to do (in my case at least); I ended up calling it unintentionally

Is this still an issue? If so can you provide your config and some reproduction code? I don't have this Move to a file in my code_actions

on this branch, the move to a new file option is present
https://github.com/basti-n/nvim-lazy/blob/use-typescript-tools-as-ts-lsp/lua/plugins/typescript-tools.lua

Hey, I was looking to find the default remap to open code actions with typescript-tools, ca is not working. Is this an issue with my config or is the default remap something else?

Is this still an issue? If so can you provide your config and some reproduction code? I don't have this Move to a file in my code_actions

For me, the action is permanently available on a variable or anywhere inside a scope, any file type(.js/.jsx/.ts/.tsx)

My config ins't doing anything unordinary, see https://github.com/GNRSN/dotfiles/blob/main/dot-config/nvim/lua/plugins/lsp/typescript-tools.lua
I wanted to try implementing a custom handler but I can't get a function added for textDocument/codeAction to do anything (e.g. log hello world) while everything works as expected for textDocument/publishDiagnostics as per the example in the readme. Is this expected? @KostkaBrukowa would you mind giving me some pointers?


Share more of our work on snomed - BNF codes

To discuss!
We have a lot of code/material on converting/mapping between BNF codes and SNOMED. There are some users who have a need for some more files primarily to work different databases who are snomed/bnf.
Specifically they work with PCA data and would like to map it to other places with snomed.
As an immediate first step could we

Provide the code and probaly a file for VTM -> BNF codes (jupyter notebook might be best that could be updated infrequently)
Document this file a bit better https://github.com/ebmdatalab/openprescribing/tree/main/openprescribing/frontend/management/commands/presentation_replacements
see what else we have in the long term trends work that Helen manages that we could share.

I think output could be a blog with linked notebooks

I've now created a notebook with attached csv to map VTM -> VMP/AMP -> BNF code which has gone to NHS England for review.
https://github.com/ebmdatalab/bnf-code-to-dmd

Need to write a blog, summarising what we've done as a one-off.

would want to update before writing, but need Jupyter to BQ fix first

Blog written, including validation and link to download: https://www.bennett.ox.ac.uk/blog/2023/11/bnf-to-dictionary-of-medicines-and-devices-dm-d-map-now-available/


Creation of term: healthy volunteer

For new term requests, please provide the following information:
Preferred term label
Healthy Volunteer
Synonyms
Healthy Participant, Healthy Patient, Healthy Person
Textual definition
This is a healthy person serving as a control in a research study.
Suggested parent term
MeSH Heading: Healthy Volunteers
https://meshb.nlm.nih.gov/record/ui?ui=D064368
Attribution
https://orcid.org/0000-0002-1382-4768

I think this can be closed. Please reopen if needed.


docs: Fix admonition rendering

Fix https://github.com/heartexlabs/label-studio/issues/4538
How to QA
These should all work now:
https://deploy-preview-4541--label-studio-docs-new-theme.netlify.app/guide/install.html#Install-with-Docker-on-nix
https://deploy-preview-4541--label-studio-docs-new-theme.netlify.app/guide/signup.html#Create-an-account

Hey @huguestennier!
I spot also this other line. After that looks good to me.
Thanks!

LGTM

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@huguestennier can we resolve the conflicts here?


ls: fix for gnu test case quote-align compatibility

This pr tries to solve  #6554

one thing I noticed while writing tests is that when c quoting style is given gnu ls tries to escape ':', I couldn't understand why they're doing this, but I think I matched the behavior.

The test cases alone make #6559 a better PR, so I'm closing this in favor of #6559.


changing pixel_ring.wait() color

hello, trying some mods, but I don't find how to change color of the pixel_ring.py wait mode.
I'd like to add in pixel_ring.py some functions like  wait_blue, wait_red.... (actual is green) and perhaps, if possible, change speed.
An idea ?

If you are using the respeaker core, you can modify the arduino code to change the code. But if you are using the respeaker usb mic array, the color can't be changed yet.

Oh, Ok !
Perhaps one day ?!
Thanks xiongyihui.


[docs] Navigation secondary

Moving comments on a merged PR to a new issue.
@zeroedin Some notes:
Overview tab

Sample component header, image needs to be in white container with gray border (denoted in Google doc, the file name is inside a one-cell table with a white background and gray border)
Repo status table not showing

Style tab

Using the expandable menu header, table broken
Small breakpoints heading, image looks blurry, do I need to export another?
Spacer images in table are still 2x

Guidelines

Responsive design header, I re-exported the Slot 2 visible and Slot 2 hidden subheader images because they included text which they should not have (they are on Dropbox now)

Small breakpoints heading, image looks blurry, do I need to export another?

I personally don't see the blurriness.  If you want to provide a new image let me know and I'll add it.


HDFS-17364. Configurably use WeakReferencedElasticByteBufferPool in DFSStripedInputStream

Description of PR
Follows the pattern of existing striped and hedged read shared resources. Moves the singleton BUFFER_POOL from DFSStripedInputStream into DFSClient and handles synchronized initialization of that pool.
How was this patch tested?
I've deployed it to a few of my company's production hbase regionservers. The config works, and the WeakReferencedElasticByteBufferPool helps reduce stable memory usage by 1.5GB (would be load dependent).
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m  9s

trunk passed

+1 :green_heart:
compile
1m 10s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 57s

trunk passed

+1 :green_heart:
shadedclient
41m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-project/hadoop-hdfs-client: The patch generated 2 new + 72 unchanged - 0 fixed = 74 total (was 72)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
39m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

152m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6514

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 22fcf026cad4 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a5e19d015e30bea9a0343cd33f90a2840a428c71

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/1/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 11s

trunk passed

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 59s

trunk passed

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 37s

trunk passed

+1 :green_heart:
shadedclient
33m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 47s

the patch passed

+1 :green_heart:
compile
0m 50s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 50s

the patch passed

+1 :green_heart:
compile
0m 44s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-project/hadoop-hdfs-client: The patch generated 2 new + 72 unchanged - 0 fixed = 74 total (was 72)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
33m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 26s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

131m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6514

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 68789558e2de 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 36954d34bac56942b8827587a13fed7893b51efa

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/2/testReport/

Max. process+thread count
613 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6514/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @zhangshuyan0 Thanks for your reviews. I realized there's also an ElasticBufferPool in DFSStripedOutputStream. I'm thinking of handling that here as well. What do you think?

@Hexiaoqiao @zhangshuyan0 Thanks for your reviews. I realized there's also an ElasticBufferPool in DFSStripedOutputStream. I'm thinking of handling that here as well. What do you think?

+1 from my side.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 01s

No case conflicting files found.

+0 :ok:
spotbugs
0m 00s

spotbugs executables are not available.

+0 :ok:
codespell
0m 00s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
107m 55s

trunk passed

+1 :green_heart:
compile
6m 03s

trunk passed

+1 :green_heart:
checkstyle
5m 16s

trunk passed

+1 :green_heart:
mvnsite
6m 32s

trunk passed

+1 :green_heart:
javadoc
5m 41s

trunk passed

+1 :green_heart:
shadedclient
172m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 44s

the patch passed

+1 :green_heart:
compile
3m 00s

the patch passed

+1 :green_heart:
javac
3m 00s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 21s

the patch passed

+1 :green_heart:
mvnsite
3m 25s

the patch passed

+1 :green_heart:
javadoc
2m 50s

the patch passed

+1 :green_heart:
shadedclient
185m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
6m 11s

The patch does not generate ASF License warnings.

494m 11s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6514

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 6320a162bf26 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 36954d34bac56942b8827587a13fed7893b51efa

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6514/1/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6514/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


SwiftLint integration

This PR introduces SwiftLint to the project and fixes majority of lint warnings. SwiftLint is integrated as Xcode Plugin to ensure every contributor is using it.
Resolves #86

When it comes to auto formatting the code in Xcode for example on save. Is it possible with SwiftLint only or do we need something like SwiftFormat for that? We can add auto formatting in a separate PR but Im not that familliar with Swift tooling

When it comes to auto formatting the code in Xcode for example on save. Is it possible with SwiftLint only or do we need something like SwiftFormat for that? We can add auto formatting in a separate PR but Im not that familliar with Swift tooling

It's possible for sure. There are two ways of doing it, both will require to use binary and some small shell script in Xcode project itself.

Use binary available on developer machine and throw error if it's missing. Biggest downside, folks will have to install exact version, which could be tricky for Homebrew users (there is no notion of pinned versions). Different versions also might have different set of rules (in many cases new rules are added).
Add binary to the repository so we always have the right version. Problem? Well, we will have binary file in the repository, which is not a big of an issue overall.


Support "project" as a synonym for "application"

As we move wskdeploy more towards supporting higher order "project" build/integration pipelines we need to move away from the term "application" which was arbitrarily selected earlier on in the specification design.
Mark "application" as deprecated, support "project"

See related issue: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/618 for discussion which may impact the coding of this feature.

Can not update title to indicate Priti working on it ...


Re-indexing Office Locations

Hi, I stupidly pushed the Get-Started button on the Floor Plans before the office locations were properly synchronised.
I have since updated the office locations of 15 people and can confirm that they appear in Bing.
So right now the  correct office locations are in AzureAAD, the O365 Admin Center and in Bing, but the floor plan wizard still complains that there are "No office locations found in AAD".
Do I just have to wait or is there any way I can re-start the process that stood behind the "Get Started" button?
MY office Locations are in following Format XX/#### where the first part identifies the building and the rest the floor and room. I.e. TW/401 = Thalwil Office Floor 4 Room 01. But I simply can't get pas the Specify Location Patterns Screen

Took an exrta 48h. now index has updated. False Alarm


=221.6 freezes on app launch

Discord update broke everything again.
It is not an injection issue as I've directly replaced the script with (() => {})() and Discord runs fine which means it's something that we need to fix in this repository.

@Covkie do you use a pixel? if so, did you update recently?


Possible improvement for U-Turns

Ok, so I was thinking about solving #1064. While doing that I realized that in most cases GraphHopper won't actually lead you back on the same edge that you were coming. So the idea proposed in #1064 might actually not really work. After giving this some more thought I think it makes sense to add the heading of direction for every continue after a via point (including the first continue). That way the client can decide for himself if a u-turn is necessary at this position or not.
WDYT? Does this make sense? This does not solve more complex u-turns like this. But it would solve routes like this, where a u-turn after via point 1 would be necessary. Since GH does the instruction calculation from waypoint to waypoint, this case is not easily doable during instruction creation.

A heading per instruction is not a bad idea as e.g. the very first continue after every via or start point could need something like "go north" which the client then could at least create on its own.
But before exposing this into the public JSON response lets thing twice or more about the "if" and "how" :)

While doing that I realized that in most cases GraphHopper won't actually lead you back on the same edge that you were coming

What do you mean here? With a via point it is not that unlikely (?)

What do you mean here? With a via point it is not that unlikely (?)

Yes exactly, the typical case would be a via-point. But GrapHopper calculates the instructions independently for every path between waypoints (see PathMerger). So Having a route a->b->c, GH calculates instructions for a->b and b->c. Therefore, it is not easy to create a u-turn instruction at b. One solution could be to pass some contextual information about the last path (a->b) into the creation of the next path (b->c). Another idea could be to merge the instructions by adding a u-turn if necessary. This could be done by adding the orientation for the last part of the edge in every last instruction and the orientation for every first instruction, so the merger could see if they are opposite and add a u-turn. If they are 90° the merger could add a regular turn instruction (might be the case when placing a waypoint on an intersection.

A heading per instruction is not a bad idea as e.g. the very first continue after every via or start point could need something like "go north" which the client then could at least create on its own.

Yes, so I only added it for the first instruction after a waypoint, but we could also do this for every instruction (not sure if that would be needed).

After thinking about this a bit more, we could also create a u-turn instruction as the first instruction if the first heading is going into the opposite way of the requested heading. This should be actually quite easy as well. This could be done in the PathMerger or in a new class "InstructionMerger"?

Yes it could be done in PathMerger or if necessary in a new class.

Another idea could be to post-process the instructions after their generation.
Then knowing them all, can do such things as skip / merge / u-turn?

Ok, I updated the code.
I create a u-turn instruction for waypoints, this means if we are going from a->b->a, there will be u-turn instruction at b. I do a heading check, if the difference between the two headings is very small (currently I have 1°, which could be further improved).
I also added an initial u-turn if there was a heading for the first point and if the heading is pointing in the other direction than the heading of the first edge. (Diff > 170°)
After giving this some more thought I am not sure if it is a good idea to do this on the server side. Think about a user is parked in his garage and plans a route. The heading might be completely off at this point. Once the route is calculated he wants to start the navigation and starts riding. The first instruction would be "turn around", which is a bit weird. Probably we should add some logic on the client side for this, as the client knows the initial heading of the continue instruction.

Something I just came up with could solve case 1). But this would require extra computation power. We could add the starting and end heading of every instruction. Essentially this would require 2 azimut calculations per instruction. This would allow us to check the instruction list for short instructions with repeating turn signs, like it would appear for u-turns in case 1).
E.g.
>----- Turn right
                |
<----- Turn right

We also need an icon for the front end here.

Note that in your example, being parked and planning a route, the GPS could return 0° location bearing, which essentially won't participate in route initial direction.
(GPS bearing would become accurate when device moves, not when it's stationary)

Note that in your example, being parked and planning a route, the GPS could return 0° location bearing, which essentially won't participate in route initial direction.
(GPS bearing would become accurate when device moves, not when it's stationary)

Yes, I had the same thought, see my comment above:

After giving this some more thought I am not sure if it is a good idea to calculate an initial u-turn on the server side. Think about a user is parked in his garage and plans a route. The heading might be completely off at this point. Once the route is calculated he wants to start the navigation and starts riding. The first instruction would be "turn around", which is a bit weird. Probably we should add some logic on the client side for this, as the client knows the initial heading of the continue instruction.

So I think we should remove it again. Let me know what you think.

Sorry, I'm a bit late with this ... would you mind updating the PR? probably just recreate the translation files.

Probably we should add some logic on the client side for this, as the client knows the initial heading of the continue instruction

The heading variable is already something where the client can and should pass this information - or is this already solved (?)

Essentially this would require 2 azimut calculations per instruction.

Isn't one of those calculations already done in the instruction creation code?

Ok, so I updated this PR.

The heading variable is already something where the client can and should pass this information - or is this already solved (?)

Yes, this is how I implemented it :). However, I am not sure if it wouldn't simply work better to do this on the client side. Here we could also check if the user is moving or not and all that.
We could also add this to GH though. We could add a speed or is_moving variable. It the user is moving, we could create a bigger penalty for a u-turn, whereas when being parked, performing a u-turn is often easier.
I am really not sure what we should do here? WDYT @devemux86, would you see this on the client or server side, and why?

Isn't one of those calculations already done in the instruction creation code?

Yes, well we could add the heading for every instruction and not just for via instructions which would make this easier in the end. Probably the best would be to solve this case during the instruction creation and not in a post processing step. Will try if it's possible.

We could add a speed or is_moving variable

Why would this be necessary? Why not just omit the heading if it is unknown? (and then no u-turn instruction is created)

would you see this on the client or server side, and why?

What exactly do you want to see on the client side?

Probably the best would be to solve this case during the instruction creation and not in a post processing step. Will try if it's possible.

Sounds good!

What exactly do you want to see on the client side?

Indeed what's the actual use case or do we complicate things?
GPS bearing exists after some device movement, at that point the instructions were already calculated.

Why would this be necessary? Why not just omit the heading if it is unknown? (and then no u-turn instruction is created)

Ok, maybe I was thinking too complicated then :). Let's leave it as it is currently.

What exactly do you want to see on the client side?

The initial U-turn when being parked parallel to a street and needing to start in the other direction as currently facing. I was just thinking that it might be easier/better to do this on the client side.

The initial U-turn when being parked parallel to a street and needing to start in the other direction as currently facing. I was just thinking that it might be easier/better to do this on the client side.

That could very easily fail by GPS accuracy.. :slightly_frowning_face:
GPS can shows us some meters away in other direction, GraphHopper will retrieve that as start point, snap position to reverse lane and we'll have unwanted routing.

Ok, I updated this PR. It contains 3 features:

U-turns for Via points
U-turns for start if heading points in the opposite direction
U turns for turning between two separated one-way lane roads that belong to the same road, if the connection between the two is short (<35m) and is only one edge. This only works if there are instructions, like two left turns. The second instruction will be ignored and the first will be converted to a u-turn. This could be further improved when we solve #1048.

Let me know what you think.

And what kind of problems do you see with the current state? (Just to be sure I understand all caveats properly :))

And what kind of problems do you see with the current state? (Just to be sure I understand all caveats properly :))

IMHO this PR works already pretty good and I feel quite confident to merge it.
It's just that sometimes a u-turn instruction is missing, because we miss the second turn. This happens quite often for u-turns as they appear when turning around on a 2-lane separated road. It's not a big problem, but I would believe that some people would feel confused.
I planned a couple of routes with this PR and checked if the u-turns appeared correctly, which worked good. Give it a try :).

Thanks, will do!
Will still have to wait ~2 week before merging, and then also merge #1075 (due to the same reasons)

FYI: I think the instruction thing is just one side of the problem with those u-turns, in general we should be able to add the u-turn penalty. See this example and this is related to #446 where we completely want to exclude these u-turns (that then have a way as 'via' member)

BTW couldn't have left & right u-turns like all other "turn" instructions?

What do you mean?

U-turns can be left or right depending on left/right-hand traffic rules. Wondering if we could have that information in instruction sign, instead of a common id (like with roundabouts).

Ah, yes. For me this would make sense.

U-turns can be left or right depending on left/right-hand traffic rules. Wondering if we could have that information in instruction sign, instead of a common id (like with roundabouts).

The issue with this, that we cannot know the direction of a u-turn, created after a via-point or due to the heading, as they don't have a direction. The u-turns that are created inside InstructionsFromEdges have a direction and we could add a direction to them. Furthermore we could find out the direction using the SpatialRuleIndex to check if the u-turn happens in a country with left-hand traffic, if yes the u-turn usually goes to the right, otherwise it usually goes to the left. But I am not sure if this will work and if the overhead justifies this?

It would be a nice to have feature as u-turns (and roundabouts) come in response as generic sign / symbol / instruction.
Or to overcome that could need clients to be aware of country traffic rules where routing is performed, though that wouldn't be optimal for cross-country routes.

BTW I understand the technical difficulties, just wondering if extra improvements are possible. :slightly_smiling_face:

BTW I understand the technical difficulties, just wondering if extra improvements are possible. :slightly_smiling_face:

As I said, I could try to check the location using the SpatialRuleIndex to check the usual traffic side in that country. This would solve the roundabout and u-turn issue.

I merged the current master into this PR. Should be mergeable now? Or should we still wait?

What is the performance impact on the instructions? Would you mind to measure this?

What is the performance impact on the instructions? Would you mind to measure this?

The current master showed routingCH.mean=2.60|259 (two different measurements), this pr showed routingCH.mean=2.69|2.65|2.61 (3 different measurements), so there an impact, but it's <3%.

I just slightly updated this PR. We are now more generous when it comes to slightly different orientations of the roads before and after the turn.
One example I found where the orientation change was too big for the previous check can be found here. I don't think that we increased our false positive rate here (showing u-truns where there are none), because we are also assuming, that there has to be two very close turns in the same direction and that the street names have to be similar before and after. I could not find any false positive so far.
Will continue testing bike and foot and report if I find any issues.

Ok, this was a bit too generous I think. This turn was recognized as u-turn.

Let's wait with this PR a bit. I think I should do some more manual testing with different encoders to fine-tune this feature. Will do this soon.

I updated this PR. Now I am quite happy with the results. When running measurement this PR was even a bit faster than the current master (well it shouldn't actually be faster, but the performance impact is not that huge). I updated the first comment to contain the relevant information.

Should we differentiate left and right U-turns (and adapt the signs accordingly) like @devemux86 mentioned?

We could, but I am not sure if the cost use factor makes sense.
The benefit would be to be able to create u turns in a certain direction. But I am not sure how often u-turns would be done in the "wrong" direction.
The downside of this would be that we need a spatial rule index to check if we are in a left hand traffic country.
An alternative would be to differentiate between turn around and u-turn. U turns would have a direction and would be calculated in the instruction class. Turn around would be calculated for via points in the path merger.
I think differentiating between u turns and turn around would be a nice addition. WDYT?

Btw I think "turn around" and "u turn" is a synonym, so we might need a different name :).

The downside of this would be that we need a spatial rule index to check if we are in a left hand traffic country.

That would be a benefit for other cases in the library too.
Like mentioned above, if having that information, could use it also in roundabouts.
BTW is there the thought to allow setting the rule of the road externally by the apps, instead to calculate it inside the library, or it's better to have it always inside?

Like mentioned above, if having that information, could use it also in roundabouts.

Yes true :). I am still not 100% sure if this wouldn't be easier done on the client side? Also the benefit for roundabouts is not that huge IMHO.
I think for roundabouts it would interesting to calculate the exiting angle (we got that already, maybe we need a bit more info) and create a turn instruction image on demand. For example if we know that we exit 80° to the left and the we go right around (might be possible to calculate from the edge geometry) we could generate a perfectly matching image. Might be easy to do with on demand SVG creation? Just a crazy thought :), but that would be really cool.

BTW is there the thought to allow setting the rule of the road externally by the apps, instead to calculate it inside the library, or it's better to have it always inside?

Isn't it enough to have it on the client side? I think besides the direction of roundabouts the changes for the routing are not that big and this could be easily done on the client side?

Isn't it enough to have it on the client side?

Client can calculate or simply request users to set the rule of the road for their region.
But then need to declate it to any routing library, so that library can generate the proper instructions.

I just pushed a change. We now have U_TURN_LEFT, U_TURN_RIGHT (these are calculated for u-turns that use an intermediate short connecting road in between), and U_TURN_UNKNOWN (which would be used for generic, please turn around instructions, e.g. at waypoints etc. where GH does not calculate the actual turn movement).
Icon wise we could now use directed u-turn icons for the specified u-turns. For the unknown we could also create a more generic turn around icone, for example like this.
WDYT?

For the unknown we could also create a more generic turn around icone, for example like this.

That icon is for right-hand traffic roundabouts, not u-turns.
For a generic u-turn without known direction, the usual icon without the arrow could work.

That icon is for right-hand traffic roundabouts, not u-turns.
For a generic u-turn without known direction, the usual icon without the arrow could work.

Yes, this was just an example :). We could also just turn around the continue straight arrow, so that it points in the other direction. Another option would be a u-turn symbol without an arrow head, yes.

I just updated this PR and resolved the merge conflict. This should be mergeable now?

I think afterwards we should compare measurement with 3 points, currently there are just 2 and then the PathMerger is probably not activated.

Thanks for merging this :). I couldn't follow your comment, sorry. What do you mean by that?

In the measurement class we use 2 point for querying so there won't be any u-turn calculation. If we use 3 points we could better see the performance impact of this change.

In the measurement class we use 2 point for querying so there won't be any u-turn calculation. If we use 3 points we could better see the performance impact of this change.

Ah, ok, now I understand what you mean by that. There are still u-turns, but no "via-point u-turns". Sounds good, should I create a PR that creates multi point routes?

Just mean to do the perf comparison in this case. Not sure if such a thing is necessary in the long run.


Expose secureview as 'X' in dav permissions

When a file or folder can be securely viewed we now add an X to the permissions.

ocis tests are green https://drone.owncloud.com/owncloud/ocis/35318/1/1


conference app update 5-7

added speaker names to schedule

@andrewhemans The merge target should be sencha/kitchensink, not master.  Closing this.  Please open a new PR targeting the kitchensink branch.


Uninstall of Java failing

I installed the most current version of java using caskroom today, and seconds later realized our office standard is to use an older version to match what is currently in production. When I ran brew cask uninstall java, it failed with the following error:
==> rmdir: /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/pt.lproj: Not a dir
Error: Command failed to execute!

==> Failed command:
["/usr/bin/sudo", "-E", "--", "/bin/rmdir", "--", "#<Pathname:/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/pt.lproj>"]

In this case, the file in question is a symlink to another directory. Looks like maybe the install should be capturing that info and using rm instead. Alternately, maybe the uninstall code could just use rm -d?

Something weird happened there. /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/pt.lproj is too specific, it should be trying to remove /Library/Internet Plug-Ins/JavaAppletPlugin.plugin directly.
I can’t reproduce the error on a clean VM. @radeksimko @alebcay @fanquake can you?

Something weird happened there. /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/pt.lproj is too specific, it should be trying to remove /Library/Internet Plug-Ins/JavaAppletPlugin.plugin directly.
What does brew cask cat java show?

Closing on account of no reply. If it is still an issue, please report back.

I'm having the same issue on 10.9. brew cask cat java says: https://gist.github.com/703936665a9b55f49db0

@dpo Please open up a new issue so we can get all the necessary information to help you, see https://github.com/caskroom/homebrew-cask#reporting-bugs

It seems the problem comes from having a previous install of Java (not using homebrew cask). I followed the instructions https://www.java.com/en/download/help/mac_uninstall_java.xml and http://docs.oracle.com/javase/7/docs/webnotes/install/mac/mac-jdk.html to uninstall everything. Installing/uninstalling the cask happens cleanly after that.

Good to hear the issue was resolved. If anyone else stumbles upon this issue, to clean up java, do:
sudo rm -fr /Library/Internet\ Plug-Ins/JavaAppletPlugin.plugin
sudo rm -fr /Library/PreferencePanes/JavaControlPanel.prefpane

and delete old versions from /Library/Java/JavaVirtualMachines
(running /usr/libexec/java_home -verbose should show nothing at this point)
and you can finish with brew uninstall java && brew install java if so desired


use hm-pyhelper to pull in device specific params?

Pull from hm-pyhelper:
https://github.com/NebraLtd/hm-block-tracker/blob/1a5a104935b541ef9e541de286446ae30e30ac73/miner_config/generate_config.py#L64-L67
And audit any other similar stuff in this repo that can be replaced with hm-pyhelper stuff

Also we should update our configs to include the onboarding key slot and the key address so that we can override this as needed by https://github.com/NebraLtd/helium-syncrobit/issues/2
   {key, {ecc, [{key_slot, 0}, {onboarding_key_slot, 15}, {bus, "i2c-1"}, {address, 16#60}]}}, %% don't make this the last line in the stanza because sed and keep it on one line

Ref - https://github.com/helium/miner/blob/6739b568e195ef0c66f0b4db3fece0eefde4d873/config/sys.config#L55


Homebrew support?

I'm very glad to see recent cool updates in gomi 👍
BTW, do you have a plan to support distribution by Homebrew? Some macOS users (sure, including me) will get benefit. And also it's available by GoReleaser so you don't need to take a big effort (or I'll do if you want).
You may already know... https://goreleaser.com/customization/#Homebrew

Thank you for the opening issue!
Yeah I know that GoReleaser feature. And also I have a plan to support Homebrew tap. It’s next task in this tool. Of course pull request is also welcome. Thanks

Understood. Thank you!

As you already know,
Now you can install it via homebrew!
$ brew install b4b4r07/tap/gomi
...
...
==> Tapping b4b4r07/tap
Cloning into '/usr/local/Homebrew/Library/Taps/b4b4r07/homebrew-tap'...
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 8 (delta 0), reused 0 (delta 0), pack-reused 4
Unpacking objects: 100% (8/8), done.
Tapped 1 formula (32 files, 25KB).
==> Installing gomi from b4b4r07/tap
==> Downloading https://github.com/b4b4r07/gomi/releases/download/v1.1.1/gomi_darwin_x86_64.tar.gz
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/34890657/37949a00-47c0-11ea-8302-5e1608ef08e6?X-Amz-Algorithm=AWS4-HMAC-S
######################################################################## 100.0%
🍺  /usr/local/Cellar/gomi/1.1.1: 4 files, 8.2MB, built in 16 seconds

Cool! Thank you for notification😄


How to use delayed stub with RxTest.TestScheduler?

Moya version: 11.0.1
Context:
Hi! I'm reasonably new to Moya so I may be overlooking this, hence this is just a question. I've recently migrated to RxTest and all tests using immediatelyStub worked perfectly, but I'm having trouble with the cases where I need delayedStub. I'd really like to simulate network work in my unit test (while still using stubs) and count on the perfect precision of RxTest when it comes to comparing events timestamps, however the delayedStub seems (in a first look) stuck to real world time units instead of being able to use TestScheduler's virtual time.
So when I noticed that the following code is inside an open-declared method, my first thought was to subclass MoyaProvider:
case .delayed(let delay):
    let killTimeOffset = Int64(CDouble(delay) * CDouble(NSEC_PER_SEC))
    let killTime = DispatchTime.now() + Double(killTimeOffset) / Double(NSEC_PER_SEC)
    (callbackQueue ?? DispatchQueue.main).asyncAfter(deadline: killTime) {
        stub()
    }

But subclassing doesn't feel right, given that Moya 9.0 deprecated the old RxMoyaProvider in favor of extension methods, so maybe I should be only extending as well. Also I have problems even for getting to a compilable version when subclassing MoyaProvider without having to add more code than just the only method I'd like to override, but that's a side subject that we can move to a whole new issue if desired 😃
▶ Question:
So is there a way to use TestScheduler to delay (in virtual time) responses when using stubs?
If not, then I'm willing to help with this because RxTest is a must to me, just please let me know your constraints for this implementation so I can start thinking about an architecture that doesn't break your purposes. For example, possibly #1502 would change how to address this (for better or for worse, I don't know right now).
Thank you very much!

Hey @gobetti. That's a great question. So I didn't really use delayed stubs in combination with TestScheduler in RxSwift, but I know that people who did, subclassed MoyaProvider.
If there is a way of introducing this to Moya without creating additional subclasses it would be awesome. If not, maybe just adding an example of subclassing to our docs would be sufficient? What do you think?

Hi @sunshinejr , thanks for the fast and kind answer!
If subclassing is still considered a good practice after RxMoyaProvider got deprecated, then I'm all for it. An example may help, but I can anticipate that currently there is a single method in MoyaProvider handling all StubBehavior cases and I'd like to override only the delayed one (the one where a scheduler will make sense since there's timing embedded). This method has the following signature:
open override func stubRequest(_ target: Target, request: URLRequest, callbackQueue: DispatchQueue?, completion: @escaping Moya.Completion, endpoint: Endpoint, stubBehavior: Moya.StubBehavior) -> CancellableToken

Internally, it does this:
let callbackQueue = callbackQueue ?? self.callbackQueue
However notice that callbackQueue is internal in MoyaProvider, so given that I want to keep this code, I need to create another of that property in my subclass.
Also, my TestScheduler needs to be injected in my MoyaProvider subclass via its initializer, so that I don't modify the signature of the overridden method. But here again I had problems because I wanted to keep all the same parameter default values, and some won't work at least not in a first naive attempt.
So in brief, an example that:

Overrides stubRequest by replacing the code for one of the stub behaviors
Exposes a new initializer with an additional parameter, while keeping all the same parameter default values from the MoyaProvider subclass

will definitely be all I need! 😄
Thank you again!

Oh, I thought that you wanted to take a stab at it and create a PR with the example, @gobetti 😄 My time is limited right now so maybe you could try to do it and I could help you with your questions in a PR?

Hi guys! I'm sorry, but for my purposes, it ended up being a simpler approach to write a new network layer on top of RxCocoa, whereas Moya does it from scratch and provides reactified versions via extensions, making it fully decoupled from RxSwift/RxCocoa - which is a great point, but not something I'm taking benefit from given that I don't want to decouple my project anyway :)
Thanks for your time and attention, and feel free to close this discussion as stale or however fits best for you. If I ever need to dig into this again, I'll surely dedicate some time and contribute!

@gobetti No problem 👍 Glad you found a solution
Sent with GitHawk


Sending non-blocking requests to GCM

I noticed that I had to wait for the json_request call to return before I could be able to send my next messge to GCM.  In other words, the following call is a blocking call.
    res = gcm.json_request(registration_ids=reg_ids, data=data,)

It would be nice to have an async_json_request function that sends the message to GCM and returns immediately so that we can send our next message.
I think there might be need to to use CCS (XMPP) for this instead of HTTP based GCM, but I am not completely aware of the implementation details.

@pramttl what is Message Queuing API's? what service is that google's or rackspace?

I wrote this. Take a look at it.


Known failure texts

Just a short list of Project Gutenberg files that are known failures:
00ws110.txt (and a lot of the other early William Shakespeare texts.)
zncli10.txt
zen10.txt
25019-0.txt
25012-8.txt
As a general rule, numbered files seem to be standardized enough to pass, mostly, while the earlier files with letters in the file name are more hit-or-miss. Non-English files also tend to fail for some reason. Also, books with names too long to fit on one line tend to fail.

The non-English books failing may be because the ones I was looking at had really long German titles, because the Chinese ones I glanced at seem to be fine.

Handling titles that extend over 2 lines should definitely be fixed, if it can be (it probably can.)
I suspect some of these listed might be "old" texts.  zncli10.txt for example, I eventually did find, but I had to use a web search instead of Gutenberg's search.  It does indeed fail on it because the "produced by" regexp is inadquate.
I'll see what I can do for it, and the other ones, shortly.
Is the boilerplate on non-English books in English?  If not, ... there's going to be tough going there and I may just cop out and disclaim that this tool is only suitable for English works...

Yes, these are from the April 2010 DVD. I believe that Gutenberg has modernized some of the old texts since then, but they seem to frown on me downloading the entire site at once.
The boilerplate on non-English works appears to be universally in English, at least for the ones I looked at. If this holds true, I imagine that it would be substantially easier to detect, say, where a Chinese or Cyrillic text begins and ends.

I realized I could run the script on every text file I've downloaded from Gutenberg like so
cd my_gutenberg_texts
mkdir tmp
guten-gutter --output-dir=tmp/ *

and it will report which ones it fails on.  So I'll add them here (I've renamed them for my own convenience but retained the original filename at the end):
ProducedByStripper failed to clean 'A_Princess_of_Mars_pg62.txt'
ProducedByStripper failed to clean 'Around_the_World_in_80_Days_pg103.txt'
ProducedByStripper failed to clean 'The_Island_of_Doctor_Moreau_pg159.txt'
ProducedByStripper failed to clean 'The_Time_Machine_pg35.txt'
ProducedByStripper failed to clean 'War_and_Peace_pg2600.txt'

zen10.txt = http://www.gutenberg.org/cache/epub/34/pg34.txt = "This is a COPYRIGHTED Project Gutenberg eBook, Details Below" = WONTFIX... or at least NOTINCLINEDTOFIX... because I think the primary purpose of this tool is to extract the public domain contents of PG texts.  I'll clarify this in the README.

Note, for those wishing to sort out only the public domain texts: copyright information is included in the metadata in Project Gutenberg's RDF catalog: https://www.gutenberg.org/wiki/Gutenberg:Feeds

Have added some commits (https://github.com/catseye/Guten-gutter/commit/c593b4dd6cf8f28842c63a1d20c89f18b0ec58e3 , https://github.com/catseye/Guten-gutter/commit/35c6f40f88cc9b117409e70224f14ecce81a2917) that handle zncli10.txt and pg159.txt (and maybe others like them, as a side-effect.)
For pg62.txt and others listed in https://github.com/catseye/Guten-gutter/issues/1#issuecomment-158035094 the problem is that they don't have a "Produced by" line.  In fact, they are cleaned fine by the script, it's just that they produce this warning message when it tries to remove this line, and it can't find it.
Not 100% sure of the best way to handle this, because there is no general way to distinguish between having no "produced by" line, and having a "produced line" in a format that we don't recognize.


Move headlamp tutorial to pyfluent-examples repo

The headlamp example is computationally intensive (requires 22 min on CI/CD machines) so it is being moved to the pyfluent-examples repository (see PR here: https://github.com/ansys/pyfluent-examples/pull/82).
This PR deletes the example script and the corresponding image files from the PyFluent repository.

@raph-luc I'm actually not sure, I don't recall making that change.


only add StatefulSession on RDS when PersistentSessionFilter is enabled

Please provide a description of this PR:
cc @ramaraochavali

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
607c1756ad7f670ad7b2e96c558e5752e6d9af5b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
607c1756ad7f670ad7b2e96c558e5752e6d9af5b
link
true
/test unit-tests-arm64

unit-tests_istio
607c1756ad7f670ad7b2e96c558e5752e6d9af5b
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
607c1756ad7f670ad7b2e96c558e5752e6d9af5b
link
true
/test unit-tests

unit-tests-arm64_istio
b793192561ad4ec3839561deefdea88b6b953e36
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b793192561ad4ec3839561deefdea88b6b953e36
link
true
/test unit-tests-arm64

unit-tests_istio
b793192561ad4ec3839561deefdea88b6b953e36
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Create test.txt

Why:
Closes [issue link]
What's being changed:

Check off the following:

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

not me


20230728 UX

add Device meta fields to UI
fix dashboard not redirecting correctly

Codecov Report

Merging #69 (ddf34aa) into prep-release (3e18a0d) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@              Coverage Diff              @@
##           prep-release      #69   +/-   ##
=============================================
  Coverage         25.75%   25.75%
=============================================
  Files                54       54
  Lines              2458     2458
=============================================
  Hits                633      633
  Misses             1825     1825

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


The pass "pass.pkpass" could not be opened

I keep getting this error: The pass "pass.pkpass" could not be opened. Below's my code. I've re-done the cert process like 3 times. Not sure where it's failing because the package seems intact.
def show
   pass = Pass.find(params[:id])
   pass_path = ENV['passes_folder_path'] + "/passes/#{pass.id}"
   pass_json = File.read(pass_path + "/pass.json")
   pkpass = Passbook::PKPass.new pass_json
   files = []
   Dir.foreach(pass_path) do |file|
     next if file == '.' or file == '..' or file == '.DS_Store'
     files << file
   end
   pkpass.addFiles files
   send_data(pkpass, type: 'application/vnd.apple.pkpass', disposition: 'attachment', filename: 'pass.pkpass', status: 201, location: [:api, pass])
 end

You can not send pkpass as is in send_data
You have to call pkpass.file.path which will return the temporary pkpass file path
Sorry it could be a little bit more documented. Will update doc in order to get that a bit more clear.
Let me know if it solved your issue.

WOW! thanks for the prompt response. That still returns nil for me.

This time it is something different. You are only giving the filename and not the file path.
Dir.foreach(pass_path) do |file|
  next if file == '.' or file == '..' or file == '.DS_Store'
  files << File.join(pass_path, file)
end

This should solve this other issue.

ah! okay. I'll. Worked like a charm! BTW, I'd love to help with documentation and contributing.

I'm sending pkpass responses like this:
pkpass = Passbook::PKPass.new # ... initialize & add files
send_data(pkpass.stream.string, filename: "pass.pkpass", content_type: "application/vnd.apple.pkpass")


Configurable queue settings for bound_to exchange queues

The settings of bound_to_exchange queues are not configurable. It is currently hard coded as explicit, non durable and auto deleted. Can this be made configurable by getting the values from the settings?
If the queue is exclusive, queue mirroring is not happening in rabbitmq cluster environment. So during failover of rabbitmq nodes, the queues are getting deleted and never created again.
The fix can be to get the settings of bound_exchange queues also from config properties so that these can be set based on the environment.

@ritu-p As the contributor for the AMQP module, can you please help with this?

Hi @msdhivya , the bound queue settings can be made configurable. please raise a PR for this fix.

Thank you @apanicker-nflx, @ritu-p .
PR: https://github.com/Netflix/conductor/pull/1796
Can you please review?