Allow Symfony 4.0 in composer.json

Q
A

Bug fix?
No

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

#SymfonyConHackday2017

Do not forget to add notes about your changes to CHANGELOG.md

Add description under added/changed/fixed section.
Add reference to closed issues [#000].
Add link to issue in the end of document.

Does symfony 4.0 introduce BC?

It theoretically could. All BC are first introduced as deprecations in the previous versisions (e.g. 3.*). If deployer do no raise any deprecation notice with the 3.4 symfony components, it should be ok.

Okay, will release new major v7 and will merge it there — more save approach.

Besides these obvious changes, please also consider the few rather subtle changes that come with Symfony 4:

The default log directory is now %kernel.project_dir%/var/log (note the missing "s" at the end compared to previous versions). We should default to Symfony's default conventions (see the corresponding Symfony Flex recipe https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/src/Kernel.php).
The environment-based configuration makes prepending SYMFONY_ENV=<...> or appending --env=<...> to the CLI invocations unnecessary. As for the part of loading the application environment during Deployer deployments: we have found explicitly sourceing the variable declarations before the Symfony CLI commands to be much more reliable than to rely on the target shell to load the destination profile correctly. This might be a system configuration issue, though. However, it might generally be a good idea to provide a mechanism that allows arbitrary files on the deployment target to be sourced into Deployer's SSH session and to allow this to be configured in the server inventory. This saves from overriding most of the base Deployer tasks ;)

The environment-based configuration makes prepending SYMFONY_ENV=<...> or appending --env=<...> to the CLI invocations unnecessary. As for the part of loading the application environment during Deployer deployments: we have found explicitly sourceing the variable declarations before the Symfony CLI commands to be much more reliable than to rely on the target shell to load the destination profile correctly. This might be a system configuration issue, though. However, it might generally be a good idea to provide a mechanism that allows arbitrary files on the deployment target to be sourced into Deployer's SSH session and to allow this to be configured in the server inventory. This saves from overriding most of the base Deployer tasks ;)

@tehplague can you be more specified on this one. Maybe you can show some examples?

Sure. Well, my current implementation is rather "hacky" but works very well.
We have inventory entries of the following form:
.base: &base
  repository: 'git@gitlab.com:some/project.git'
  identity_file: identityFile
  forwardAgent: true
  bin/php: /usr/bin/php7.1

staging:
  <<: *base
  hostname: some.host.name
  user: someuser
  deploy_path: /path/to/application
  http_group: somegroup
  stage: staging
  env_cmdline:  'source /etc/someapp/app_profile &&'

and have the following Deployer configuration:
<?php

use function Deployer\{
    commandExist, server, task, run, runLocally, set, get, add, before, after, inventory, input, upload
};

use Symfony\Component\Yaml\Yaml;

require 'recipe/symfony3.php';

// Servers
inventory('build/build.properties.yml');

// Used to replace lots of set() invocations
task('load:config', function () {
    $input = input();
    $stage = $input->hasArgument('stage') ? $input->getArgument('stage') : -1;

    // Configuration
    $settingsContent = Yaml::parse(file_get_contents('build/settings.yml'));
    $settings = isset($settingsContent[$stage]) ? $settingsContent[$stage] : $settingsContent['.base'];

    foreach ($settings as $key => $config) {
        set($key, $config);
    }
})->desc('Load settings.yml');

// Make sure that settings are loaded
before('deploy', 'load:config');

task('deploy:vendors', function () {
    if (!commandExist('unzip')) {
        writeln('<comment>To speed up composer installation setup "unzip" command with PHP zip extension https://goo.gl/sxzFcD</comment>');
    }
    run('cd {{release_path}} && {{env_cmdline}} {{bin/composer}} {{composer_options}}');
});

task('frontend:build', function () {
    runLocally('yarn install');
    runLocally('yarn run build');
    runLocally('rsync -azP public/dist {{user}}@{{hostname}}:{{release_path}}/public');
})
    ->desc('Build frontend assets');

task('fpm:restart', function() {
    run('sudo service php7.2-fpm reload');
});

/**
 * Clear Cache
 */
task('deploy:cache:clear', function () {
    run('{{env_cmdline}} {{bin/php}} {{bin/console}} cache:clear {{console_options}} --no-warmup');
})->desc('Clear cache');
/**
 * Warm up cache
 */
task('deploy:cache:warmup', function () {
    run('{{env_cmdline}} {{bin/php}} {{bin/console}} cache:warmup {{console_options}}');
})->desc('Warm up cache');
/**
 * Migrate database
 */
task('database:migrate', function () {
    run('{{env_cmdline}} {{bin/php}} {{bin/console}} doctrine:migrations:migrate {{console_options}} --allow-no-migration');
})->desc('Migrate database');

/**
 * Main task
 */
task('deploy', [
    'deploy:info',
    'deploy:prepare',
    'deploy:release',
    'deploy:update_code',
    'deploy:clear_paths',
    'deploy:create_cache_dir',
    'deploy:shared',
    'deploy:vendors',
    'frontend:build',
    'deploy:cache:clear',
    'deploy:cache:warmup',
    'database:migrate',
    'deploy:symlink',
    'fpm:restart',
    'cleanup',
])->desc('Deploy application');

No, this is already handled by our settings.yml which allows per-stage configurations. We needed to be able to prepend some command to both Composer and the Symfony CLI which is why I needed to override all the tasks.
The result works practically as a "server-side version" of the env() function since by using .env the contents of the env variables are no longer known to the CI server but only to the target.

Another possibility would be a sane approach to load a user profile on the destination host which would need the inventory and the SSH client interface to be extended. This would enable other features such as setting umask limits, etc. during deployments.

@antonmedv To be clear: Symfony moved towards an environment-based configuration since 3.3. They have dropped the parameters.yml file in favor of several environment variables. In development environment, you put all of them in an local .env file and Symfony will automatically load them for convenience. But when it comes to production servers, you have to define these variables before executing any composer or console command. (I do not want to discuss whether this design choice is good or not, I just describe it).
Hence we need a way to easily define a lot of environment variables before executing every local or remote command. The first that come in mind is the "source" shell built-in.
(And more generally a way to prepend some string before every single command would be welcome, IMO)

(And more generally a way to prepend some string before every single command would be welcome, IMO)

Now you can do it only for env vars.
Let's think of how we can create more robust deployment script for symfony.
So symfony requires a lot of environment params? Why not to create .env on server too?

I'm not absolutely sure about the rationale behind not recommending Dotenv for production (which is officially discouraged: http://symfony.com/doc/current/components/dotenv.html). It might be due to performance considerations (manually parsing the env file on each request/invocation is slower than taking them directly from the process environment).
Nevertheless, the Dotenv component is generally unavailable on production since it is installed as a dev dependency by default. So do not expect many projects to have it available for that purpose.

So symfony requires a lot of environment params?

Any sensitive (like passwords) or platform specific parameters usually go there.

What about creating .env file in {{release_path}} and prepending each command with
source .env && ...

It is created automatically with composer install from .env.dist if not exists
But if you put it in shared files (like in https://github.com/deployphp/deployer/pull/1440) it created before and stay blank... But anyway you should put proper parameters there.
Simple source does not help coz vars should be axported. You should do something like this https://unix.stackexchange.com/a/79077
set -a; source . env; set +a probably. Need to test.

@zorn-v I still don't consider moving DotEnv to require as a valid option here, even if it worked for you. This would go against Symfony's recommendations. We should try to deploy Symfony applications according to their conventions. At least Deployer should come with the recipe to do so which you can then customize/override if needed.

So now Deployer has env param. Can we describe all needed config there?

@tehplague I did not say that my solution is right. I just do it coz it was convenient for me (using DotEnv in prod instead of duplicate all vars in webserver and console).
@antonmedv Yes. You can get all vars locally from some file that not under version control (to not push sensitive data to repo) for example.

@antonmedv I imagine something like this:
# Load environment variable from '/path/to/.env/file'
set('symfony_env_file', '/path/to/.env/file');

Resulting in prepending set -a; . {{ symfony_env_file }}; set +a;  to every symfony and composer commands.
I cannot remember if source is a bash-specific built-in or not, so . should work in most case.

@Adirelle: . is POSIX-compliant while source is not mandated.

It's okay - deployer posix dependent.

@antonmedv I think . is better just because it should work everywere (as people says). Not at windows anyway 😄

Deployer supports windows only as client machine, not target.

What's the current state with this pull request? I would love to use deployer with my new Symfony 4 application. Can I support in something?

I ended up installing the Deployed phar from deployer.org to avoid any conflict. Unfortunately, the provided SHA1 cannot be easily extracted, which prevents secure automated scripting.
It would be nice to have Deployer available through something like https://phar.io/ (But maybe it is another issue.)

@Adirelle Def a work around! thnx for pointing out phar.io.

See https://deployer.org/manifest.json for sha hashes

Closing this issue (#1559 was merged).


success alert on the top does not collapse itself

Describe the Issue
Success alert below the navbar(e.g. after updating profile) does not collapse itself which can be inconvenient for the user.
Affected Page
https://www.freecodecamp.org/learn
Steps to Reproduce

Go to 'Profile'
Update anything on your profile
A success alert will appear on screen
4.It does not collapse and stays on all pages until the website has been refreshed for another session

Expected behavior
All types of alerts should automatically collapse after some time and shouldn't have to be closed by the user.
Screenshots

System

Browser: [e.g. Microsoft Edge, ]

Additional context
No response

Could you expand on the reasons why do you think such change should be made?
While I'm not able right now to find specifics, I'm fairly sure that's an intentional design decision.

@gikf there's no need for a change, it was intensional.

Yes, this is an intentional design decision to allow learners as much time as they need to read and understand an alert message.


[D3D11] Sleeping Dogs: Definitive Edition incorrect resolution while in Exclusive Fullscreen

The games resolution is incorrectly increased when played in Fullscreen (Exclusive). (This game does not have a Borderless Fullscreen option).
This results in part of the image being cut off, which you can't see in the image directly.
See the 2 images for comparison. Also, the incorrect resolution while in fullscreen is reported in the d3d11 log file.
Tested on Windows 10 2004 (Not sure if this issue also occurs on linux)
Native DirectX 11, correct resolution (2560x1080)

DXVK 1.7, incorrect resolution (2576x1100) which results in a zoomed in view since part of the game is rendered outside of my monitors supported resolution.

Software information
Sleeping Dogs: Definitive Edition, All graphical settings on highest possible, except for motion blur (disabled) and anti aliasing (normal = FXAA)
System information

GPU: Radeon RX 5700
Driver: 20.7.1
Wine version: -
DXVK version: 1.7

Log files
SDHDShip_d3d11.log
SDHDShip_dxgi.log

Friendly reminder that Windows is not our primary target platform and not really supported.
Probably has something to do with window style crap that isn't really documented anywhere so I have no idea how to fix this. Maybe @Joshua-Ashton does.

This problem doesn't occur on Linux.
Probably has something to do with window style crap that isn't really documented anywhere

I figured as much, thanks anyway.

@lextra2 Friendly necro ping. Is this still an issue?

IIRC this is general issue for ultra-wide monitors, saw this in many games. Also some games sometimes count something looking like games window title and borders size.
This is from other SD:DE issue's attached dxgi log file:

Buffer size:  1928x1092

Well, for such games I usually prefer to use 16:9 wine virtual desktop or gamescope (when I need fully hide my screen original resolution/aspect_ratio). Good if it can be fixed in dxvk, but can be wine issue.

@Blisto91 I'll let you know later when I'm home

Unfortunately this is still an issue with 1.10.3

Buffer size:  2576x1100
SDHDShip_d3d11.log
SDHDShip_dxgi.log

I fixed the problem with aspect ratios by downloading the Borderless Gaming program.
Step 1 - press Alt + Enter to make the game in window mode;
Step 2 - In Borderless Gaming, move the file with the name Sleeping Dogs: Definitive Edition[PC64-Ship...] to the right with the arrow;
Step 3 - click on the last button in the center (the fourth button).
These steps probably need to be done every time you start the game.

@lextra2 Can you try again with this build? https://github.com/doitsujin/dxvk/actions/runs/12008516626

I can, in January. I have no desktop until then.

@lextra2 No need anyway. I was given a explainer of the issue and it isn't directly related to exclusive fullscreen functionality itself.


 I think each letter might be there, but somehow without any x offset. Don't spend too much time on this; it could also be an issue in lyon or my code somewhere.

Can you provide the source SVG?

<svg width="9999" height="9999" viewBox="0 0 9999 9999" xmlns="http://www.w3.org/2000/svg"><text x="0" y="0" font-size="21" font-family="Overpass"><tspan fill="#5B5B5B">Community Proposals</tspan></text></svg>

This is what I'm feeding in, but viewing standalone (with ristretto or firefox), this is actually seemingly empty.
The issue is only happening for one user with an unknown platform; I can get more info from them before spending more time on this. Thanks for the fast response!

Ah, and worth mentioning that the Overpass font is definitely not missing

It's empty, because y on text corresponds to baseline. So the text is above the image.

Installed the Overpass font - everything works fine. The main culprit is harfbuzz. Or some math rounding/overflow issue.
If the user uses linux - we can check what harfbuzz produces for this font. Otherwise...
Also, if he has access to usvg/resvg CLI, he can try to generate a preprocesses SVG, to see what usvg actually produces.
And also, maybe there were some warnings in the log. usvg prints a warning for almost every situation.

A later pass of my code handles the y offset -- although actually I didn't realize this issue before; I think I understand why I have some hacks in place now. :)
They are on Linux; I gave instructions to see what usvg does: https://github.com/dabreegster/abstreet/issues/76#issuecomment-648331883
Thanks so much for the help debugging this!

diff.zip
Running usvg on my system vs theirs produces very different results. So is the likely explanation that harfbuzz on their system is somehow broken or configured differently?

The latest release uses it's own harfbuzz fork, so it should work out of the box. Unless the bug was actually in resvg.

Confirmed fixed in https://github.com/dabreegster/abstreet/issues/76, thank you for solving this!

Nice!


Send Slack notification for resource upvotes 🔼

More context coming soon...

@ramiAbdou i would love to work on this, it would be my first issue regarding slack integration

You got it, @BeteabTefera!

@BeteabTefera just updated the description here! Let me know if you need clarification anywhere!

Going to open up this issue!

call it

@Boris713 are you still working on this? all good if not

yes i am

I would like to take on this issue!

@niaanderson-po sorry for the delay, you've got it!

Working on this issue this weekend!

@niaanderson-po are you still working on this issue? No worries if not, looking to open this one up!

I'm not. You can open the issue!

I would like to take on this issue!

@AbdulmajeedKabala unfortunately @ciaracade had already reached out to me about this issue a few days ago, so I'm going to assign her

Hi, thanks!! Nudging @aphillps123

I can take this!

is this issue still being worked on? would love to help if not

@Boris713 I believe @aphillips123 and @ciaracade are using this for a school project


Update HockeyApp IOS SDK to 3.8.5

Also removes the bitcode warnings as this version of the sdk supports bitcode.
@dlevine82 @Chuxel @lostintangent

LGTM!

I take it we got confirmation that its fixed in the SDK, if so great!
So did you upgrade the SDK?  If so, did you also make sure the symlinks are blown out to files in the plugin?  (I can't tell very well from the PR.)

BTW - An alternate solution here that would prevent you from having to blow out the contents of the symlinks under sub-folders would be to add a hook with my symlink reconstruction code in it.  This is what Sergey did in a PR to the Facebook Connect plugin.  That can help on Windows with the max path limit.  See https://github.com/Wizcorp/phonegap-facebook-plugin/pull/1022

Looks like when i unzipped the SDK on linux, it filled in the symlinks for me, so this is taken care of already. Thanks Chuck!


Upgrade (or remove) node-addon-api?

Hey @pyramation @benasher44, hope you're well!
The<EMAIL_ADDRESS>dependency is pretty ancient by now:
https://github.com/launchql/libpg-query-node/blob/badd4c85da02e8a7badfb050632e7d8010e8ec73/package.json#L30-L34
The current version is<EMAIL_ADDRESS>(released 5 Mar 2024)
The old version of node-addon-api can cause weird conflicts - eg. running pnpm install on a project that has both libpg-query and sharp leads to this confusing error (../common.cc:12:10: fatal error: 'napi.h' file not found) in the sharp build:
➜  preflight-test-project-next-js-passing git:(main) ✗ pnpm i
Packages: +638
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 707, reused 622, downloaded 17, added 638, done
<EMAIL_ADDRESS>Running install script, failed in 4.6s
<EMAIL_ADDRESS>install$ node install/check
│ sharp: Detected globally-installed libvips v8.15.2
│ sharp: Attempting to build from source via node-gyp
│ sharp: Found node-addon-api
│ sharp: Found node-gyp version 10.1.0
│ sharp: See https://sharp.pixelplumbing.com/install#building-from-source
│ gyp info it worked if it ends with ok
│ gyp info using<EMAIL_ADDRESS>│ gyp info using<EMAIL_ADDRESS>| darwin | arm64
│ gyp info chdir src
│ gyp info find Python using Python version 3.12.2 found at<EMAIL_ADDRESS>│ gyp info spawn<EMAIL_ADDRESS>│ gyp info spawn args [
│ gyp info spawn args '/Users/k/.cache/node/corepack/v1/pnpm/9.0.0-beta.1/dist/node_modules/node-gyp/gyp/gyp_main.py',
│ gyp info spawn args 'binding.gyp',
│ gyp info spawn args '-f',
│ gyp info spawn args 'make',
│ gyp info spawn args '-I',
│ gyp info spawn args<EMAIL_ADDRESS>│ gyp info spawn args '-I',
│ gyp info spawn args '/Users/k/.cache/node/corepack/v1/pnpm/9.0.0-beta.1/dist/node_modules/node-gyp/addon.gypi',
│ gyp info spawn args '-I',
│ gyp info spawn args '/Users/k/Library/Caches/node-gyp/20.12.0/include/node/common.gypi',
│ gyp info spawn args '-Dlibrary=shared_library',
│ gyp info spawn args '-Dvisibility=default',
│ gyp info spawn args '-Dnode_root_dir=/Users/k/Library/Caches/node-gyp/20.12.0',
│ gyp info spawn args '-Dnode_gyp_dir=/Users/k/.cache/node/corepack/v1/pnpm/9.0.0-beta.1/dist/node_modules/node-gyp',
│ gyp info spawn args '-Dnode_lib_file=/Users/k/Library/Caches/node-gyp/20.12.0/<(target_arch)/node.lib',
│ gyp info spawn args<EMAIL_ADDRESS>│ gyp info spawn args '-Dnode_engine=v8',
│ gyp info spawn args '--depth=.',
│ gyp info spawn args '--no-parallel',
│ gyp info spawn args '--generator-output',
│ gyp info spawn args 'build',
│ gyp info spawn args '-Goutput_dir=.'
│ gyp info spawn args ]
│ <string>:114: SyntaxWarning: invalid escape sequence '\/'
│ gyp info spawn make
│ gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
│   CC(target<EMAIL_ADDRESS>│   LIBTOOL-STATIC Release/nothing.a
│ warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: archive library: Release/nothing.a the table of contents is empty (no object file members in t…
│   TOUCH Release/obj.target/libvips-cpp.stamp
│   CXX(target) Release/obj.target/sharp-darwin-arm64/common.o
│ ../common.cc:12:10: fatal error: 'napi.h' file not found
│ #include <napi.h>
│          ^~~~~~~~
│ 1 error generated.
│ make: *** [Release/obj.target/sharp-darwin-arm64/common.o] Error 1
│ gyp ERR! build error
│ gyp ERR! stack Error: `make` failed with exit code: 2
│ gyp ERR! stack at ChildProcess.<anonymous> (/Users/k/.cache/node/corepack/v1/pnpm/9.0.0-beta.1/dist/node_modules/node-gyp/lib/build.js:209:23)
│ gyp ERR! System Darwin 23.4.0
│ gyp ERR! command<EMAIL_ADDRESS>"/Users/k/.cache/node/corepack/v1/pnpm/9.0.0-beta.1/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--directory=src"
│ gyp ERR! cwd<EMAIL_ADDRESS>│ gyp ERR! node -v v20.12.0
│ gyp ERR! node-gyp -v v10.0.1
│ gyp ERR! not ok
└─ Failed in 4.6s at<EMAIL_ADDRESS>node_modules/.pnpm/libpg-query<EMAIL_ADDRESS>Running install script...
 ELIFECYCLE  Command failed with exit code 1.

Removing libpg-query and running pnpm install resolves the issue with building sharp.
History
node-addon-api was introduced in a commit by @ethanresnick in July 2019:

https://github.com/launchql/libpg-query-node/commit/fc6fa68fd8a009059d7c11a38099479026d4da40

Seems like node-addon-api was updated to ^7.0.0 recently in @gregnr's PR:

https://github.com/launchql/libpg-query-node/pull/34

This PR was merged, but it appears from the commit history that it was then reverted.
Seems like this is the new PR for WASM, which also upgrades to<EMAIL_ADDRESS>
https://github.com/launchql/libpg-query-node/pull/48

Don't think it was reverted, my branch was just merged into a wasm-feature branch instead of latest so that it could be tested before a final merge (#48). IIRC we were just waiting on pre-gyp binaries to be uploaded for that branch in order to test everything together. But other than that it should be good to merge.

We're upgrading this hopefully today! Stay tuned!

Thanks for the<EMAIL_ADDRESS>release @pyramation ! 🙌
I can see that node-addon-api has been upgraded to<EMAIL_ADDRESS>(still not the newest at 8.0.0, but it's probably more compatible).


Improve readme

Improve readme:

add examples on how the PredicateBuilder simplifies the query construction
fix typos
construction of sentences

Closed by #6


Table of Contents component does not support Chinese

Current Behavior

The component will scan the target region and query all matching headings. If a heading has an ID set, that will be used as the scroll target, otherwise an ID will be auto-generated and assigned.

If the title is in Chinese and no id is specified, the automatic generation will fail, and the display and scroll positioning of this component will be abnormal. Simple solution, should automatically assign a random character id.
Expected Behavior
No response
Steps To Reproduce
No response
Link to Reproduction / Stackblitz
No response
More Information
No response

Given the refactor will handle this I'll go ahead and close this out as a duplicate. Thanks for reporting though!


Possible to write to files?

When I saw in the readme that PUT and POST requests are supported, I expected that to mean the underlying JSON files can be written to via HTTP. Is that the case?
If not, wouldn't that be cool?!

Hi Zeke,
It's the case (or else it's a bug).
When you provide a JSON file, changes are persisted to it:
$ json-server file.json # will write

But in other cases, it won't
$ json-server file.js # won't write
$ json-server http://somewhere.com/file.json # won't write

You can always, type s to save current database state.

awesome. Can't wait to give this a try.


Add Indexes for TimeStampedModel on created and modified fields.

By default indexes should be added inside the Meta of abstract class.

Can you provide a PR?

Also in the future please provide a little bit of reasoning behind the request or PR :-)
I assume this is because that way if one overrides the class you can easily change the indexes to your liking.
Happy to accept a PR for this.

Yes, I have almost every model in my project inherit from TimeStampedModel. So it would be nice to have indexes in AbstractModel itself.
I was waiting to raise a PR.

@anudeepsamaiya if you submit a PR I will try to much it as fast as I can and make a new release for you. (Next month I will be traveling a lot and probably not get to it.)

TimeStampedModel seems to have a design flaw: it adds two non-indexed fields (created and modified) and at the same time it defines a default ordering on those fields. That results in a full table scan each time a query is run on any model that inherits from TimeStampedModel.
Since explicit is better than implicit I would simply remove the default ordering from the TimeStampedModel.

TimeStampedModel seems to have a design flaw: it adds two non-indexed fields (created and modified) and at the same time it defines a default ordering on those fields. That results in a full table scan each time a query is run on any model that inherits from TimeStampedModel.
Since explicit is better than implicit I would simply remove the default ordering from the TimeStampedModel.

Not sure if it's a design flaw per see, but at the least it can be surprising to people implementing the abstract class.
I agree... seems that explicitly defining ordering on the model using the TimeStampedModel is a better approach.
Thinking that indexes might be similar and one can always make a small base abstract class of their own if it's used a lot; eg: IndexedOrderedTimeStampedAbstractModel(TimeStampedModel) :-)
For now I have removed the default ordering and will close this issue for now.
If there is enough need in the world to add a subclass with index support I'm happy to add that put please first make you get some decent number of developers / users to support your change before submitting a PR.
Thanks to everybody contributing to this issue !


\param and \return not generated for method

When creating a doxygen comment for the method in a header file, param and return wont get generated for Foo(). However generations works on the above static function. and in the defining cpp file.
All settings for the plugin are on default, tried reinstalling it.
What should I do?
namespace A::B
{
	class DP_API MyClass
	{
	private:
		static HMODULE DLLModule;

		MyClass() {}

	public:
		/**
		 * Desc.
		 *
		 * \param dllModule
		 */
		static void SetDLLModule(HMODULE dllModule) { DLLModule = dllModule; }

		/**
		 * Desc.
		 */
		bool Foo(HMODULE aValue);
};

Hi @LostInCompilation ,
I'm sorry that you're experiencing these issues.
Could you please provide a screencap of what you're doing?
Currently I can not reproduce your problem:
https://user-images.githubusercontent.com/2466365/126681731-dfc8d623-852c-4b03-a055-5f0cd1e3949e.mov

Thanks for testing. Well now it is working for me too after two days of normal development...
Do you request the function signature somehow from VisualStudio/IntelliSense for generating the comments? Maybe my IntelliSense was broken because I'm not able to reproduce the error now.

No, the file is parsed as text.
The addon not working is ususally the case when VSCode detects the wrong language of the file but working on one method and not the other is very strange.
I will close this for now, feel free to open a new issue if you experience any further issues.


(General) Write Documentation

Write documentation pages for each of ESD's options. Ideally each page should be as thorough as possible and use images and examples when needed.

Short video tutorials for each option via YouTube would probably also be a nice thing to have.


Downloading installer tries to download a non existing tag

Today the downloader fails with the following error.
Downloading Dependency Check latest installer from GitHub..
Cannot read property 'find' of undefined
##[error]Cannot read property 'find' of undefined
##[error]Unhandled error condition detected.

When analyzing the code it seems that it tries to download https://api.github.com/repos/jeremylong/DependencyCheck/releases/tags/vlatest but that tag "vlatest" doesn't exist.

Not sure if anyone is still interested in this issue, but we've been encountering it for the last few days, but it has since gone away again - most frustrating!
The code may have changed since the issue was originally created, as I can see that at the following line, if the version is set to its default, 'latest', then it uses a different URL to what is cited when this issue was created: https://github.com/dependency-check/azuredevops/blob/ec3d0e53f8be4feeb48eb97be9df71b01767baed/src/Tasks/dependency-check-build-task/dependency-check-build-task.ts#L284
It is instead https://api.github.com/repos/jeremylong/DependencyCheck/releases/latest, which I've confirmed does indeed exist, and following the code through it should be able to successfully locate the asset with content-type == 'application/zip':
https://github.com/dependency-check/azuredevops/blob/ec3d0e53f8be4feeb48eb97be9df71b01767baed/src/Tasks/dependency-check-build-task/dependency-check-build-task.ts#L288
It's hard to tell as there's not a lot of error handling, but you'd assume that the code is successfully retrieving something from that URL, it just can't locate the correct asset. Given it occurs sporadically, I did wonder also whether it may be hitting some kind of GitHub API rate limit, but then I'd probably expect a different error i.e. the HttpClient wouldn't receive a 200 OK back in that case, but given there's no code explicitly checking the HTTP status code of the response, I don't know if the HttpClient being used throws an error for a non-200 response, or whether this is actually something that should be being explicitly checked - or at least logged?
Anyway, a bit more information for if/when this occurs again in the future.

Encountering this issue pretty frequently of late, I've done some more digging. It looks like the client used here doesn't throw for non-200 status codes:

https://www.npmjs.com/package/typed-rest-client
Which tracks with what's coming back from the API when a non-existent version tag is requested:

Rate limiting seems to make some amount of sense I think? Given the intermittent nature and the fact that it will work and then not work for the exact same pipeline for seemingly no reason.

Does anyone of you still have this issue? If so I'll look into it - otherwise I'll close this issue.

Does anyone of you still have this issue? If so I'll look into it - otherwise I'll close this issue.

I'm getting intermittent failures with the dependency check extension from the Visual Studio Marketplace in the Azure DevOps pipeline.
Here is the output:
Starting: Run dependency security checks
Task : OWASP Dependency Check
Description : Dependency Check is a Software Composition Analysis (SCA) tool that attempts to detect publicly disclosed vulnerabilities contained within a project's dependencies.
Version : 6.1.3
Author : Dependency Check
Help : More Information
Starting Dependency Check...
Setting report directory to /azp/_work/16/s/depedancy-check-results/
Creating report directory at /azp/_work/16/s/depedancy-check-results/
Downloading Dependency Check latest installer from GitHub..
Cannot read property 'find' of undefined
##[error]Cannot read property 'find' of undefined
##[error]Unhandled error condition detected.
Ending Dependency Check...
Finishing: Run dependency security checks

Will take another look at this once we get the new pipeline for our build up and running.


Azcopy is failing. See the error.

User is an administrator on the machine. But Azcopy with my personal id which is an admin on the machine works.  I am trying it from cmd prompt
Unhandled Exception: System.Runtime.Serialization.SerializationException: End of Stream encountered before parsing was completed.
at System.Runtime.Serialization.Formatters.Binary.__BinaryParser.Run()
at System.Runtime.Serialization.Formatters.Binary.ObjectReader.Deserialize(HeaderHandler handler, __BinaryParser serParser, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream serializationStream, HeaderHandler handler, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream serializationStream)
at Microsoft.WindowsAzure.Storage.DataMovement.StreamJournal.Initialize()
at Microsoft.WindowsAzure.Storage.DataMovement.TransferCheckpoint..ctor(Stream journalStream)
at Microsoft.WindowsAzure.Storage.DataMovement.TransferContext..ctor(Stream journalStream)
at Microsoft.WindowsAzure.Storage.AzCopy.DirectoryTransferLauncher..ctor(ILocation source, ILocation dest, CommandLineParameters parameters)
at Microsoft.WindowsAzure.Storage.AzCopy.TransferLauncherBuilder.BuildTransferLauncher()
at Microsoft.WindowsAzure.Storage.AzCopy.BlobFileTransfer.DoTransfer()
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.ExecuteTransfer()
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.Execute(String[] args)
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.Main(String[] args)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1141c265-4aea-c6be-4d61-3566fe8474b8
Version Independent ID: 3cb0f2ba-cf8b-7fdd-414b-b8d95dca004c
Content: Copy or move data to Azure Storage with AzCopy on Windows
Content Source: articles/storage/common/storage-use-azcopy.md
Service: storage
GitHub Login: @seguler
Microsoft Alias: seguler

@Skarakkattil Thanks for your feedback! We will investigate and update as appropriate.

@Skarakkattil Could you post your question in https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=windowsazuredata
This question requires in depth troubleshooting and additional questions. It will be more appropriate for the forums channel since it's not related to the documentation.

@Adam-Smith-MSFT has any resolution been found? I believe we are experiencing something similar.

@EmmaZhu can you take a look at this ?
@gbstan92 are you trying to copy a whole drive ? AzCopy /Source:C:\ /Dest:...

Hi @seguler ! It is just a folder.This is the script used:
Set-Location "C:\Program Files (x86)\Microsoft SDKs\Azure\AzCopy"
.\AzCopy.exe /Source:C:*Inetpub*\logs /Dest:https://**//bc/ /DestKey:== /Y /XO /S

@EmmaZhu can you help ?

@Skarakkattil  @gbstan92  Could you share version of AzCopy you are using?

@Skarakkattil  We do have issue on reading file/directory without access that we're working on a fix. But the error you shared, seems it's caused by trying to read a corrupted journal file.
AzCopy supports to resume last failed transfer, it keeps a journal file on the local disk. If last AzCopy process is killed or crashed, it may leave some corrupted journal file. It can report the error you meet when it tries to resume from the corrupted journal file.
Thanks
Emma

I think what  you  said is correct.  I got a failure today due to corrupted journal file.  The error I got is given below. Once I removed the journal file, it worked.
Unhandled Exception: System.Runtime.Serialization.SerializationException: End of Stream encountered before parsing was completed.
at System.Runtime.Serialization.Formatters.Binary.__BinaryParser.Run()
at System.Runtime.Serialization.Formatters.Binary.ObjectReader.Deserialize(HeaderHandler handler, __BinaryParser serParser, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream serializationStream, HeaderHandler handler, Boolean fCheck, Boolean isCrossAppDomain, IMethodCallMessage methodCallMessage)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Deserialize(Stream serializationStream)
at Microsoft.WindowsAzure.Storage.DataMovement.StreamJournal.Initialize()
at Microsoft.WindowsAzure.Storage.DataMovement.TransferCheckpoint..ctor(Stream journalStream)
at Microsoft.WindowsAzure.Storage.DataMovement.TransferContext..ctor(Stream journalStream)
at Microsoft.WindowsAzure.Storage.AzCopy.DirectoryTransferLauncher..ctor(ILocation source, ILocation dest, CommandLineParameters parameters)
at Microsoft.WindowsAzure.Storage.AzCopy.TransferLauncherBuilder.BuildTransferLauncher()
at Microsoft.WindowsAzure.Storage.AzCopy.BlobFileTransfer.DoTransfer()
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.ExecuteTransfer()
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.Execute(String[] args)
at Microsoft.WindowsAzure.Storage.AzCopy.AzCopy.Main(String[] args)
From: EmmaZhu-MSFT<EMAIL_ADDRESS>Sent: Thursday, April 12, 2018 9:33 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Skarakkattil<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Azcopy is failing. See the error. (#6356)
@Skarakkattilhttps://github.com/Skarakkattil We do have issue on reading file/directory without access that we're working on a fix. But the error you shared, seems it's caused by trying to read a corrupted journal file.
AzCopy supports to resume last failed transfer, it keeps a journal file on the local disk. If last AzCopy process is killed or crashed, it may leave some corrupted journal file. It can report the error you meet when it tries to resume from the corrupted journal file.
Thanks
Emma
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/6356#issuecomment-381002904, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AhKnVYC8wEkaPJf168XcXA_xZGYhdVK_ks5toA5agaJpZM4S9Quf.

Hi @Skarakkattil . The version is 7.0.25.
After clearing the journal, we are now getting a different error:
[2018/04/13 15:38:40][ERROR] Error parsing destination location "https://mylocation/myfolder": The underlying connection was closed: An unexpected error occurred on a receive. For more details, please type "Az
Copy /?:Dest" or use verbose option /V.
We use the same container for other log backups so the storage is definitely working fine.

@gbstan92  The error message shows an error from network to me. Can you share the account name to me to take a look if it's OK? My email address is<EMAIL_ADDRESS>

Hi @EmmaZhu
Very sorry for the late reply. I've done some additional troubleshooting and found out that whenever I run the script the following System Error (Event 36871) gets generated:
"A fatal error occured while creating a TLS client credential. The internal error state is 10013"
This is a WS2016 box that has TLS 1.0 and 1.1 disabled. I understand that AzCopy might be using TLS 1.1. Any chance we can force it to use TLS 1.2?

Can someone answer @gbstan92 query?
"I understand that AzCopy might be using TLS 1.1. Any chance we can force it to use TLS 1.2?"

AzCopy 7.0 is built against .NET Framework 4.5. You can set the TLS version it uses by a registry, Please refer to
https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls#schusestrongcrypto for details.

@EmmaZhu
Thanks for the reply. I assume the same for version 8.1 and 10?
I was actually coming here to post that I had found the below thread. I appreciate the information.
https://github.com/microsoft/azure-pipelines-tasks/issues/10337
@TheJayMann AzCopy shipped with the Azure File Copy task should work fine with TLS 1.2. Refer this.


file extension fixes. Fixes #2275 #2273

Fixes #2275 #2273

Coverage decreased (-0.02%) to 96.713% when pulling c3f051edb295c0d49d040fed81a52f5f588a3a6e on graingert:prevent-defaults-overriding-config into<PHONE_NUMBER>167317593c0896420651c46114b135 on jscs-dev:master.

Coverage decreased (-0.02%) to 96.713% when pulling 1da372ca8c1372eef888a837cb57cd077bbf3796 on graingert:prevent-defaults-overriding-config into<PHONE_NUMBER>167317593c0896420651c46114b135 on jscs-dev:master.

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec092a72c198858b972f397ad6a3c351fbe on graingert:prevent-defaults-overriding-config into<PHONE_NUMBER>167317593c0896420651c46114b135 on jscs-dev:master.

Coverage increased (+0.003%) to 96.733% when pulling 72a2aec092a72c198858b972f397ad6a3c351fbe on graingert:prevent-defaults-overriding-config into<PHONE_NUMBER>167317593c0896420651c46114b135 on jscs-dev:master.

Decided to fix this a bit differently, would appreciate a second look though - https://github.com/jscs-dev/node-jscs/commit/0d027a7b4a95c7c349f57ffd37f10e497d66a5d4

@markelog this doesn't fix #2273

It's not supposed to

Can you reopen #2273 so I can recreate the PR to fix it?
On 21 Jun 2016 9:18 pm, "Oleg Gaidarenko"<EMAIL_ADDRESS>wrote:

It's not supposed to
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-227558703,
or mute the thread
https://github.com/notifications/unsubscribe/AAZQTCeZNE9t6IyTqursHEg1WQnxRjMrks5qOEb0gaJpZM4I5kA1
.

I don't know man, everywhere i looked, like https://en.wikipedia.org/wiki/File_format#Filename_extension,  https://en.wikipedia.org/wiki/Filename_extension https://docs.python.org/2/library/os.path.html#os.path.splitext,
path.extname of node.js,
http://ruby-doc.org/core-2.2.0/File.html#method-c-extname,
https://golang.org/pkg/path/filepath/#Ext
and others... give me the same result

You can probably workaround it with something like this though -
"excludeFiles": ["**/!(*.es2015.js)"]

@markelog nope, that seems to exlude all files.

It should ignore all files which ends with .es2015.js

@markelog I know. But it seems to exclude all files

Oh shoot, typo there, it shouldn't ignore files which ends with  .es2015.js

Sorry I doubled the mistake and thought that's what you said originally. It still ignores all files

Weird, works for me

Maybe you could illustrate it with test repo?

Yeah will do
On 28 Jun 2016 9:25 pm, "Oleg Gaidarenko"<EMAIL_ADDRESS>wrote:

Maybe you could illustrate it with test repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jscs-dev/node-jscs/pull/2276#issuecomment-229171838,
or mute the thread
https://github.com/notifications/unsubscribe/AAZQTKtKVU7youjy8hV-pMdOROWO0-5-ks5qQYNMgaJpZM4I5kA1
.


Incorrect version in module.json

Describe the bug
The module.zip file of the 0.5.7 release has a module.json file with an incorrect version specified: v0.5.7.
To Reproduce
Fetch https://github.com/kandashi/Active-Auras/releases/download/v0.5.7/module.zip, read module.json of the downloaded zip file and see version: v0.5.7
Expected behavior
module.json should have version: 0.5.7

Should be fixed in v0.6.0


Use only positive size value in the new function to prevent panics

fixes: #42

Thanks as always ;)


Update Firefox versions for api.HTMLFieldSetElement.name

17380

 Quality gate: Passed
 Everything looks good
Details

 Quality gate: NA
Details

 Quality gate: NA
Details


feat: rework build docs (WIP)

This is a work in progress.
Rework much of new contributor documentation.
Remaining Work

[ ] Add run guide for k8s
[x] Add test guide
[x] Run user acceptance test

I asked @amanjeev to do some user acceptance testing for me and they report it went well. I've ticked that box.

This should be ready.
I note after https://github.com/openebs/Mayastor/pull/669 is merged so we can update with the new images/services.


Improve output stats

@LisaHollstein

Hi @LisaHollstein I've added a dev branch and tried to only output mapped reads to the SAM file, instead of all reads as previously done. Please test.

Hi!
I think it works. When I tested it the bt.test.sam file was empty despite the lines with headers, which makes sense since there are 0 lines with 3 Ns after masking accordins to the stats.
(The stats say there is 1 line in the file without a header. Is @HD a header or does it mean something else?)

Sounds good. You can check the Sam file with less for a header called @hd and exclude with the grep -v cmd in the shell script.


Fonts don't work from the .dmg

http://news.ycombinator.com/item?id=2039031

This is pretty much just not going to work. We have to write a file when pango initializes, and we can't on the .dmg.


wpaperd: 0.3.0 -> 1.0.1 & mv to by-name

Description of changes
update src to 1.0.1
use cargoHash over including the lock
include egl and wayland-client deps for build
add nu-nu-ko to maintainers
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux

- [ ] Tested, as applicable: no tests.

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[x] Tested basic functionality of all binary files (usually in ./result/bin/)

24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

oh oops I always forget something like that when moving to by-name

@nbraud Hopefully that last force push works. I'd just like to point out another PR from r-ryantm that currently depends on this change but is otherwise ready to merge (https://github.com/NixOS/nixpkgs/pull/305629),
thank you.


Assassin's Creed III Remastered: no rendering

Hello,
When I launch this game, I only have a black screen. Game seems working since I can hear sounds. If I launch it from Win 10, running fine.
I made apitrace files from Win10 and Wine (without dxvk)
Thanks for your work.
Software information
Assassin's Creed III Remastered
System information

GPU: GeForce GTX 970
Driver: 430.40.0
Wine version: 4.13
DXVK version: 1.3.2-5-g1999ca9d

Apitrace files
apitrace.zip
Log files

d3d11.log:
ACIII_d3d11.log

dxgi.log:
ACIII_dxgi.log

I did test this game at some point with DXVK and it was working fine.
Can you please test DXVK 1.2.3 (and maybe 1.1.1) to find out if this is a regression?

The Windows 10 apitrace replays fine, the trace recorded on Wine just doesn't actually draw anything. This isn't a DXVK bug, you probably just need some extra libraries (d3dcompiler?).
Please post the full wine log.

@K0bin
since 4 months of testing, I always had a black screen with wine and dxvk.
Perhaps my Wine apitrace are bad. On Win10, game is very slow when launching with apitrace. With wine and black screen, I perhaps stopped the game too early.

Still works perfectly fine for me. Yes, that is the remaster.

Perhaps my Wine apitrace are bad. On Win10, game is very slow when launching with apitrace. With wine and black screen, I perhaps stopped the game too early.

No, you did that correctly.

I have a file ACIII.dxvk-cache in directory.

That doesn't matter.

What log do you want?

The Wine terminal output from running the game. Ideally with WINEDEUBG=+loaddll or more logging. It should show whether the game needs D3DCompiler (and which version) which is likely the issue here.

@doitsujin
I made another apitrace with wine, more longer:
ACIII_d3d11.log
ACIII_dxgi.log
ACIII.cache.zip
Wine_ACIII.log
@K0bin
You run it from Windows 10 (driver 431.60). Works fine for me too on it. That confirm this is wine related.

You run it from Windows 10 (driver 431.60). Works fine for me too on it. That confirm this is wine related.

That proves DXVK works perfectly fine with the game and the bug is caused by Wine.
 Installing Microsofts d3dcompiler (don't know if 43 or 47, just try both) should fix the issue for you.

002f:err:d3dcompiler:compile_shader HLSL shader parsing failed.

This confirms that this is a d3dcompiler issue. Running winetricks d3dcompiler_43 and winetricks d3dcompiler_47 on your prefix should fix the issue.

Works fine now, Thanks


Change font weight of menu items to 400 instead of 200, improves readability

Fixes #9828.
Things to consider:

May not be the only place in the UI that this error happens.
Should the font weight used (400) be put into a LESS variable? If so, how should that variable be named?

We already have @font-weight-semibold: 500 and @font-weight-light: 200.

@ingorichter Do you want to get this in 1.2? While I'm not a Linux user, this does fix a visibility issue (which can effect usability), and know it if affected me I'd want this in as soon as possible.

Yes please.

With lighter font

With heavier font


After installing subutai getting - NOT_JSON_DOC_ERROR notification

Notification appears every ~10 second

Try updated version. Was some changes in REST on HUB so tray wasn't able to authorize.


Make it easy for pub packages to ship binaries that can be added to my path easily

When I install a gem from ruby today, and if it has binaries/scripts, they get added to my path. This is awesome. I'm sure I did a one-time setup but every other gem can supply util scripts that I can run easily.
I wanted to ship a simple util written in Dart, and it would be awesome if I could use pub to ship it. I would need pub packages to dump (or link or whatever) everything in bin/ to some well-known location that ends up on my PATH.
I searched and didn't find this issue, so here we are. Sorry if it's a dupe, I know we've talked about this before.

This issue has been moved to dart-lang/pub#407.


No app under "MY HOME"

Can you please clarify last app configuration step:
"Open your SmartThings app and go to My Home"
after adding device handler and smart app, i do not have an option in my app to select the Ring app and configure security as noted in your steps.
Please advise.

I use smart things classic app Here is the screenshot from the app.


MSBuild.ExtensionPack.VisualStudio.TfsSource does not work with TFS2015

I have in my code the usage of the TfsSource, and when the server was migrated to TFS2015 the code below started failing:
<MSBuild.ExtensionPack.VisualStudio.TfsSource TaskAction="Checkout" ItemPath="$(ProjectDir)myfile.wxs" Version="2013" WorkingDirectory="$(SolutionRoot)" />
Error message:
Error : Exit Code 100. Nothing Succeeded: Unable to determine the workspace. You may be able to correct this by running 'tf workspaces /collection:TeamProjectCollectionUrl'.
It failed for task-based builds and XAML based builds.

Hi Fabio, I cant repo this. works fine for me. Are you sure the WorkingDirectory is correct?

@fabiostawinski @mikefourie : I'm having the exact same problem with TFS 2017.1 now, but it might be related to this issue here.
What I found out is, that tf.exe seems to have problems with workspaced that where created with a newer version of tf.exe.
So in @fabiostawinski 's case: TFS 2015's build agents create the workspace and the TfsSource task tries to do a checkout using a 2013 version of tf.exe
In my case TFS 2017.1 build agent creates the workspace and when the TfsSource task is called with version 2015 it does fail with exit code 100.
@fabiostawinski You could probably solve the problem by installing VisualStudio 2015 on your build machine and setting the Version property to 2015, so that TfsSource uses the same version of tf.exe as the build agent when creating the workspace.
In my case this doesn't work since MSBuild.ExtensionBack does not support Visual Studio 2017 yet.
@mikefourie Is it possible to influence the path to the used tf.exe other than providing the Version property?


byteLength error when uploading video

Bug Report
Requirements

[X] I've searched the Issues
[X] I've read the basic concepts
[X] I'm using the latest version
[ ] I've debugged my code using the DEBUG variable.

Platform

[X] I'm using Node.js version v10.16.0)
[ ] I'm using electron
[ ] I'm using the browser YOUR_BROWSER_AND_VERSION
[ ] I'm using some other environment YOUR_ENV

YOUR DESCRIPTION HERE
When uploading a normal video, tried quite a lot. Even videos from Instagram and so on. It just errors this:

Code
    } else if (extension == "mp4") {
        console.log(`[?] Posting the video: "${content}":`);
        const publishResult = await ig.publish.video({ video: await fs.readFileSync(`./content/${content}`), /*coverImage: '',*/ caption: options.caption });

        console.log(publishResult);

        fs.unlinkSync(`./content/${content}`);

You need to add a cover image.

You need to add a cover image.

Thanks


Latest Atom release fails to build correctly

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
Latest update fails to build itself after newest release - 1.2 is not installed and trying to open 1.19.xx throws error:
The code execution cannot proceed because node.dll was not found. Reinstalling the program may fix this problem.
Steps to Reproduce

Install Atom 1.19xx on Windows 7, Windows 10
Check for updates
Close Atom
Try to re open atom from shortcut

Expected behavior: Opens newest atom version
Actual behavior: Atom.exe has been moved, and atom 1.20 has not been installed
Reproduces how often: Tried on two machines, one windows 7 and one windows 10 happened 100% of the time
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
C:>atom --version
C:>apm --version
module.js:471
throw err;
^
Error: Cannot find module '../build/Release/git.node'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (C:\Users\SQ-47\AppData\Local\atom\app-1.19.2\resources\app\apm\node_modules\git-utils\lib\git.js:8:16)
at Object. (C:\Users\SQ-47\AppData\Local\atom\app-1.19.2\resources\app\apm\node_modules\git-utils\lib\git.js:371:4)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Looks like 1.20 is a beta and shouldn't have been released?
Closing Issue as the release is no longer in the stream


Hyperlinks

The spreadsheet breaks if parts are named using hyperlinks rather than just the id

I ran some tests and read up a bit on this issue and it seems that read_excel() does not actually read hyperlinks but only plain text, so I am unsure where the error came from.


Update synth.tcl

this creates a useful dot file to examine the techmap process. It's done before too much optimisation so the results are understandable for small designs.

Looks good. Thanks Matt.


Need guidance on removing devices from Distribution Group

I've been unable to find a way to remove associated devices through the AppCenter menus and also don't see any documentation about it. This is making it impossible to use the automatic management and/or the automatic provisioning.
I have n iPhones on the distribution group, but only n-5 remaining allocations for those types of devices.
I can't remove any devices.
If I try to use AppCenter's handy dandy auto-registration it fails due to insufficient open spots, and doesn't register any of them.
I got around this by creating a new distribution group with only myself in it, but eventually I'm going to need to add other people, and I don't want every single device associated with them, we don't even support all of them.

Thanks for filing this report & sorry that you haven't heard back from us. It sounds like this issue for technical support, but this repository isn't monitored by our support team.
If you need technical help, you can contact support by:

Going to https://appcenter.ms/apps
Selecting ? > Contact Support (in the upper right corner).
Reference this issue for context if needed.

If you've already resolved your issue/still want us to document this, give us an update of your current observations. We're catching up on our backlog here.


ASUSWRT doesn't support ipv6

Home Assistant release (hass --version):
0.26.0
Python release (python3 --version):
Python 3.4.2
Component/platform:
ASUSWRT
Description of problem:
ASUSWRT component fails to decode ipv6 rows from the ip neigh command, and generates lots of warnings.
Expected:
ipv6 rows should be parsed if possible.
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: asuswrt
  host: <IP_ADDRESS>
  protocol: ssh
  username: xxx
  password: xxx

Traceback (if applicable):
16-08-13 18:29:02 homeassistant.components.device_tracker.asuswrt: Could not parse neighbor row: b'fe80::f6f5:e8ff:fe8d:7bc1 dev vlan2 lladdr f4:f5:e8:8d:7b:c1 router STALE\r'

Additional info:
As far as I can tell, https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/device_tracker/asuswrt.py#L49-L54 expects ipv4-only ips.  I'm assuming the regex just needs updated to support ipv6.  It might be possible to use something like https://docs.python.org/3/library/ipaddress.html instead of regex to validate the IP vs long regex patterns that can get messy.
Here's what part of my ip neigh looks like with one ipv6 local and the rest ipv4.
fe80::f6f5:e8ff:fe8d:7bc1 dev vlan2 lladdr f4:f5:e8:8d:7b:c1 router STALE
<IP_ADDRESS> dev br0  FAILED
<IP_ADDRESS> dev br0 lladdr 00:23:54:a1:ae:4a REACHABLE

Note: this doesn't break anything, it just generates several warnings per minute.

When you get a fix, a PR is welcome
On Sat, Aug 13, 2016, 16:41 Justyn Shull<EMAIL_ADDRESS>wrote:

Home Assistant release (hass --version):
0.26.0
Python release (python3 --version):
Python 3.4.2
Component/platform:
ASUSWRT
Description of problem:
ASUSWRT component fails to decode ipv6 rows from the ip neigh command,
and generates lots of warnings.
Expected:
ipv6 rows should be parsed if possible.
Problem-relevant configuration.yaml entries and steps to reproduce:

platform: asuswrt
host: <IP_ADDRESS>
protocol: ssh
username: xxx
password: xxx

Traceback (if applicable):
16-08-13 18:29:02 homeassistant.components.device_tracker.asuswrt: Could not parse neighbor row: b'fe80::f6f5:e8ff:fe8d:7bc1 dev vlan2 lladdr f4:f5:e8:8d:7b:c1 router STALE\r'
Additional info:
As far as I can tell,
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/device_tracker/asuswrt.py#L49-L54
expects ipv4-only ips. I'm assuming the regex just needs updated to support
ipv6. It might be possible to use something like
https://docs.python.org/3/library/ipaddress.html instead of regex to
validate the IP vs long regex patterns that can get messy.
Here's what part of my ip neigh looks like with one ipv6 local and the
rest ipv4.
fe80::f6f5:e8ff:fe8d:7bc1 dev vlan2 lladdr f4:f5:e8:8d:7b:c1 router STALE
<IP_ADDRESS> dev br0  FAILED
<IP_ADDRESS> dev br0 lladdr 00:23:54:a1:ae:4a REACHABLE
Note: this doesn't break anything, it just generates several warnings per
minute.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/2814, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYJ2tqo1cJOu8v3cOX0ASRMEGaXdOdOks5qflYagaJpZM4JjyQq
.

In the meantime, you can also adjust the log level for the asuswrt platform:
# Example configuration.yaml entry
logger:
  default: warn #I believe this is the default setting anyways?
  logs:
    homeassistant.components.device_tracker.asuswrt: error


Dotnet

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/create
Operating System: Windows 10

Files not created/Found? Is there a fix??

What part of the instructions are you seeing this with? It looks like you're opening up a file from command line.

Closing out, please re-open if you can provide more detail.


Adapter.transaction is required and optional at the same time

We recently removed the Ecto.Adapter.Transaction behaviour and merged the functions with the main Ecto.Adapter. This makes it required for all adapters to implement the transactions in some way (most probably raising if not supported). Relevant commit: https://github.com/elixir-ecto/ecto/commit/e4e8fe8d16b596d0f72764e2b84d91b35706c943.
At the same time, in the Ecto.Repo.Schema module, we preserved the old behaviour of checking if the transaction function is exported, to decide if transactions are supported by the adapter. Relevant line: https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/repo/schema.ex#L672
This leads to a difficult situation for adapters that don't support transactions - they either need to skip the function, emitting warnings at compile-time or implement some form of emulating transactions, which is something we're trying to avoid.

The initial issue that was solved by the problematic change: https://github.com/elixir-ecto/ecto/issues/1530

Reverted in master.


Create "Alexandrie-Cairo-Freetype" for cairo code that is only for freetype

Cairo doesn't necessarily need the use Freetype API. There is Harfbuzz-Cairo API which could avoid talking to Freetype directly from Alexandrie, to load fonts and render them.
It's not much code for this new package:

class is AeCairoFreetypeFontFace
a method extension referencing it (AeFTFace>>#newCairoFontFace)
check more

Additionally, there are FFI bindings to functions that belong to hb-ft.h. In the case we decide to remove those bindings, we could avoid a circular dependency Freetype <-> Harfbuzz. Explained here: https://github.com/harfbuzz/harfbuzz/issues/2524#issuecomment-2492067541 (this can be interesting for @tesonep).
There are bindings to functions that begin with hb_tf_:


Mask inputs

The mask inputs should be in bandwidth (or natural frequency) instead of time response for the PLL and current control

It has been corrected in the last release


add 2KEY token

https://www.coingecko.com/en/coins/2key
https://coinmarketcap.com/currencies/2key-network/

Hi @4tal - can you resolve conflicts, please?

@xrn Sure, done.


Don't start kernel daemon for non-python kernels.

Request is to hide the "Jupyter: Debug Cell" command for .NET Nb.
Just had a user try to use it while using C# in a notebook and it completely broke their setup :(
We want to make sure users don't think they can use this debugging feature to the point where they are completely broken.

I think the user in your scenario was actually using a .NET kernel from Jupyter (not .NET interactive). We should make sure to disable debug cell for non python kernels.

The command on the dropdown is already hidden:
            "notebook/cell/execute": [
                {
                    "command": "jupyter.runAndDebugCell",
                    "when": "notebookType == jupyter-notebook && jupyter.ispythonnotebook && notebookCellType == code && isWorkspaceTrusted && !jupyter.notebookeditor.runByLineInProgress"
                }
            ],

The command itself isn't flagged with a when clause though:
            {
                "command": "jupyter.runAndDebugCell",
                "title": "%jupyter.command.jupyter.debugCell.title%",
                "icon": "$(debug-alt-small)",
                "category": "Jupyter"
            },

Just experienced an issue where my workflow was affected right after choosing "Jupyter: Debug Cell".
Whenever I tried to open a notebook, I got the following error:
Error: The kernel died. View Jupyter [log]() for further details. Error: Unhandled exception: System.IO.IOException: The process cannot access the file 'C:\Users\<UserName>\AppData\Local\Temp\tmp-4836JTB1GoV0BpKh.json' because it is being used by another process.
Things I tried

Deleting the file manually -- doesn't work since the Code.exe process still is holding on to it.
Closing VSCode and reopening -- doesn't fix it .. just creates a different tmp file in C:\Users<UserName>\AppData\Local\Temp
Closing the notebook and reopening leads to the same error.

To debug, I first looked up which process was holding the tmp file using ProcessExp and figured out it was a python process whose parent was a VS Code instance with the following command line args: "C:\Users<UserName>\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node --inspect-port=0 "c:\Users<UserName>\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork" --type=extensionHost --skipWorkspaceStorageLock

This gave me a hint that it must have been the Jupyter extension. And so I uninstalled the .NET Interactive VS Code Extension, uninstalled the Jupyter extension and then reinstall both and that fixed it.
A symptom of the issue was that I could put breakpoints in my notebook cells:
The full call stack is:
jupyter error.txt

What's the command line for the python process that was started?

I think I am able to repro this issue. Whenever the kernel is changed to .NET (C#) dotnet from .NET Interactive, I am unable to execute the cells of the notebook and the aforementioned issue shows up:

The python command line args are:
C:\Users\<Username>\AppData\Local\Microsoft\WindowsApps\python3.7.exe -m vscode_datascience_helpers.daemon --daemon-module=vscode_datascience_helpers.kernel_interrupt_daemon -v --ppid 1508

I am convinced that choosing the "Jupyter: Debug Cell" automatically changed the Kernel to .NET C# and at this point, all the badness began.
The fix was to simply change the selected kernel and update all the cells to now point to the ".NET Interactive" flavor of C#.

We may be starting the interrupt daemon for non python kernels. That would be bad. I'll have to double check that. That's the python process you show in your command line args. Although not sure how it would have the file open? Maybe it's through file handle inheritance from the old kernel.

@mrsharm can you verify we've fixed your problem?
To verify:

Install VS code insiders
Install the latest 'prerelease' jupyter extension
Repro the steps you had before

Verify your kernel doesn't immediately die.
Thanks.

@rchiodo, just tried this out and seems like the "Jupyter: Debug Cell" option is still there, however, it doesn't break my workflow i.e. no issue with executing the cells after the selection.
Thanks for the help!


OpenJDK 11: ELF file OS ABI invalid on SLES 11

OpenJDK 11 LTS 11.0.4+11
SUSE Linux Enterprise Server 11
Running java -version
Error: dl failure on line 597
Error: failed /usr/java/jdk-11.0.4+11/lib/server/libjvm.so, because /usr/java/jdk-11.0.4+11/lib/server/libjvm.so: ELF file OS ABI invalid

It works fine on SUSE Linux Enterprise Server 11.3
Have tried the BellSoft OpenJDK 11.0.4 and that works fine on both SLES 11.0 and SLES 11.3

I believe this is a similar issue to https://github.com/AdoptOpenJDK/openjdk-build/issues/698
It may be that between 11.0.4+11 and 11.0.4 support has stopped for SLES11.0, however I can't find any documentation to support this.

@DJViking Can you try 11.0.7 please?


Add ACCOUNT_DELETE_CONFIRMED webhook event.

Adds ACCOUNT_DELETE_CONFIRMED event sent after accountDelete mutation.
Resolves https://github.com/saleor/saleor/issues/13473
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases

I think you could add another test to saleor/graphql/account/tests/test_account.py that will check if the webhook is triggered

Some actions are called "action_requested" and there is a following action confirming that it happened, in this case, the pair of these webhooks are called "action_requested" and "action_request_confirmed".

@korycins We can simplify the names and have:

ACCOUNT_DELETED
ACCOUNT_EMAIL_CHANGED (in the other PR)


Update New Orbit Deployments

Summary of changes

Update new Orbit deployments
Update new token addresses on the faucet
Add Tangle to supported EVM network on the walletsConfig

Proposed area of change
Put an x in the boxes that apply.

[x] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[ ] apps/webbsite
[x] apps/faucet
[ ] apps/tangle-website
[ ] libs/webb-ui-components

I am going to merge this without approval, as it only updates the anchor addresses and the faucet token to the new address. There are no breaking changes. This is necessary for the release of new apps.


clock.setTicknumber(0) will leave ticklabels at the min and max clock values.

Describe the bug
It's not possible to have 0 ticklabels.
To Reproduce
When setting Ticknumber to 0, to prevent displaying ticks, it will still display 2 tick labels:
clock.setTicknumber(0)

When setting the number to 1, only  the lowest value is shown (which is to be expected):

It will never display 0 ticklabels. I have to admit.. the placement of the 2 labels is beautiful and actually nicer than what I have when I enabled the 9 ticks. ;-)
(for completeness, here's the view with 9 ticks on)

Currently I solved it by setting the tickColor to transparent when I want to have it disabled.
** Other **
Great work. Using this repository on a daily  basis in my app. I would love to do some sponsoring, but the sponsoring-link in the wiki sends me back to the main page.

Hi @jilleb
You shouldn't face this issue if you were using ImageSpeedometer.
Anyway, this issue caused by drawDefMinMaxSpeedPosition, this method draw the very old position of static tow ticks (at min and max position). And I keep it for old users and as you said it's at a better position.
Setting the color to transparent is a good workaround, also you can change the the tick's label to empty like so:
speedometer.onPrintTickLabel = { _, _ -> "" }

Thanks for willing to sponsor this project, but sponsoring option isn't allowed in my country, not even e-payment.
Have a good day 😄.

That's actually a beautiful solution!
I hope to be able to buy you a drink some day !


Fix profile avatars on notifications

@lazynina @tijno
I noticed also profile avatars on profile pages will display both the default avatar and the users avatar over it if it is transparent, I can open another PR for a fix if needed?

@lazynina @tijno
I noticed also profile avatars on profile pages will display both the default avatar and the users avatar over it if it is transparent, I can open another PR for a fix if needed?

Makes sense if the background is transparent, just need to make sure that the default profile photo is used correctly in components such as the notifications list.

@lazynina @tijno
I noticed also profile avatars on profile pages will display both the default avatar and the users avatar over it if it is transparent, I can open another PR for a fix if needed?

Makes sense if the background is transparent, just need to make sure that the default profile photo is used correctly in components such as the notifications list.

Maybe needs some more logic I would think within the setAvatar() to check if avatar is transparent or not to load in default...or maybe if set at all do not load in default

would better solution be to let backend return default avatar, or 302 redir to default if none is set @lazynina


Default config_key for Plugins

Allow Plugins to default their config_key appropriately based on class name.
fixes #131
Signed-off-by: Josep M. Blanquer<EMAIL_ADDRESS>

Coverage increased (+0.07%) to 92.501% when pulling 1c54a655e8f68070a38efda24b14ad5ccd7551be on 131_plugins_without_config_key into 7bb81acaeb286f3d3a6da6e934b993cf00ca240a on master.

LGTM


Goes Black when using NavigationPage

Only way atm to use the components is by setting the MainPage manually, when pushing and poping using navigation it will cause the component not to initialize.

Any workaround?

It works with Android 12/sdk 31+

It does not work even with Android 12/sdk 31+ when it is used inside navigation page. Is there a workaround

Has someone found a solution or workaround?
It is still not working for me. Works fine when i set the MainPage. But if i use it with NavigationPage, i only see a black screen.

I dot the same problem using AppShell and tabbed pages. When tabbing to another page and going back, the camera disappears. The camera object is probably destroyed when changing to another tab, and not reinitialized when the page gets in focus.
Could be that the MainPage get initialized before it get focused, and when it get focused it is never properly initialized.
It was easy to reproduce in the BigIslandBarcode project
			             //			MainPage = new MainPage();             MainPage = new NavigationPage(new MainPage());

This is still an issue. The issue lies here:
https://github.com/Redth/ZXing.Net.Maui/blob/71a6ea2114b9f1412dccedee36ad1721e06e5a4a/ZXing.Net.MAUI/Platforms/Android/CameraManager.android.cs#L100-L102
When using a FlyoutPage (for example), Context.Context is not a Lifecycle owner.

Hello,
I am try ZXing.Net.Maui on .NET 6 Framework and sometimes the camera just turns black. Is anyone know what is the fix for this issue?
I have also noticed an other preview version of ZXing.Net.Maui on NuGet supporting NET 7, do you know if the black screen issue will be addressed on that version ?
Thank you

When using a FlyoutPage (for example), Context.Context is not a Lifecycle owner.

If you understand the bug, don't you know how to fix it upstream? (i.e. propose a PR?)

Same issue here, with a NavigationPage the view is Black.
.NET 6, Android 12

I found a fix for this, you need to recreate and re-assign the camera view with something like the following:
Add to Page Init: Appearing += Page_Appearing;
    private void Page_Appearing(object sender, EventArgs e)
    {
        RecreateCameraView();
    }
    private void RecreateCameraView()
    {
        // Create a new instance for CameraBarcodeReaderView
        var newCameraView = new CameraBarcodeReaderView()
        {
            Options = new BarcodeReaderOptions
            {
                AutoRotate = true,
                Multiple = false,
                TryHarder = true,
                TryInverted = true,
                Formats = BarcodeFormat.QrCode
            },
            CameraLocation = CameraLocation.Rear
        };

        newCameraView.BarcodesDetected += cameraView_BarCodeDetected;

        var index = CameraGrid.Children.IndexOf(CameraView);
        CameraGrid.Children.Remove(CameraView);
        `CameraGrid.Children.Insert(index,newCameraView);`

        // Assign your new instance to CameraView.
        CameraView = newCameraView;
    }

Replace the name "CameraView" with whatever your CameraBarcodeReaderView's x:Name is and adjust the Options and listeners etc to whatever you are needing.

This is still an issue. The issue lies here:
https://github.com/Redth/ZXing.Net.Maui/blob/71a6ea2114b9f1412dccedee36ad1721e06e5a4a/ZXing.Net.MAUI/Platforms/Android/CameraManager.android.cs#L100-L102
When using a FlyoutPage (for example), Context.Context is not a Lifecycle owner.

QuickWatch: ContentPage Snipping Tool: FlyoutPage

I found a workaround for this, you need to recreate and re-assign the camera view with something like the following:
Add to Page Init: Appearing += Page_Appearing;
    private void Page_Appearing(object sender, EventArgs e)
    {
        RecreateCameraView();
    }
    private void RecreateCameraView()
    {
        // Create a new instance for CameraBarcodeReaderView
        var newCameraView = new CameraBarcodeReaderView()
        {
            Options = new BarcodeReaderOptions
            {
                AutoRotate = true,
                Multiple = false,
                TryHarder = true,
                TryInverted = true,
                Formats = BarcodeFormat.QrCode
            },
            CameraLocation = CameraLocation.Rear
        };

        newCameraView.BarcodesDetected += cameraView_BarCodeDetected;

        var index = CameraGrid.Children.IndexOf(CameraView);
        CameraGrid.Children.Remove(CameraView);
        `CameraGrid.Children.Insert(index,newCameraView);`

        // Assign your new instance to CameraView.
        CameraView = newCameraView;
    }

Replace "CameraView" with the name of your CameraBarcodeReaderView, Replace "CameraGrid" with the name of the Parent container. Adjust the Options and listeners etc to whatever you are needing.

Thank you for the workaround. It worked for me.

Can someone propose a PR instead of posting workarounds? :)

Can someone propose a PR instead of posting workarounds? :)

I agree, I can take a look at this this weekend if you all want


[Tokenizers] Patch FrontEnd Init With Extension

CVS-129660

Could you please port to 2023/3?

@ilya-lavrenov  https://github.com/openvinotoolkit/openvino_contrib/pull/829


refactor(dfget): add log module

Codecov Report

Merging #107 into master will increase coverage by 6.28%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   75.26%   81.55%   +6.28%
==========================================
  Files          10       11       +1
  Lines         279      374      +95
==========================================
+ Hits          210      305      +95
+ Misses         63       55       -8
- Partials        6       14       +8

Impacted Files
Coverage Δ

dfget/cli/cli.go
62.5% <66.66%> (+58.5%)
:arrow_up:

dfget/config/config.go
84% <84.61%> (-0.62%)
:arrow_down:

dfget/util/log.go
89.7% <89.7%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3c882...830e781. Read the comment docs.


Add order argument to chainerx::Array::to_device

To grantee transferred array is C contiguous.
And remove device argument from chainerx.ascontiguous to follow numpy API.

Is this issue open? I want to contribute on this issue.


Update readme

What this PR does / why we need it:
Update the documentation for the build process as it stands today

As these changes are already outdated, I will close this PR
/close


[BUG] Command tgenv upgrade not working propertly

TL & DR
From any path at terminal shell
$ tgenv upgrade
fatal: not a git repository (or any of the parent directories): .git

From inside TGEnv directory
$ tgenv upgrade
fatal: cannot change to '* master': No such file or directory

Upgrade source file

/libexec/tgenv-upgrade

I think we have the main branch. But yes that script has several issues. I resisted refactoring it but I think it can be much simpler.
Also, consider that command only makes sense if the user installed it using the bash method but if we get a homebrew formula working we will need to consider how we support that


Request of the competition in codalab

Hi, I sent a request to your competition in codalab several days ago. May you have a look at it?
competition link

Hi @UnendingGlory, I have approved your request, please check. Thanks!


ComboBox bug, manual text entry is overwritten when item was previously selected

Detailed description

Describe in detail the issue you're having.
<ComboBox
items={}
itemToString={item => (item ? item.value : this.state.myStateVariable)}
onChange={this.selectOption}
onInputChange={this.inputOption}
placeholder="placeHolderText"
/>

where:
onInputChange sets the typed value to myStateVariable
onChange will take the selectedItem.value and set it to myStateVariable
The bug I found is:
If you select an item from the list (say "Option 1") and you backspace couple of chars and rewrite part of it (say, you want to customize/override and use "Option 5" which does not exist in the list). then you click away from the box or go to a different field, it will revert back to the previously selected item (goes back to "Option 1").
If the ComboBox was NOT previously selected an item, and you type in some custom text and then go to next field, the text remains properly. So this works fine.
So it seems the problem is.. it saves the item when selected (unless you clear with the "x" button), and even though manual input is entered, it thinks it is invalid and reverts back to the previous item value

Is this a feature request (new component, new icon), a bug, or a general issue?
A bug

Is this issue related to a specific component?
ComboBox

What did you expect to happen? What happened instead? What would you like to see changed?
Manual text entry is expected to be the same if an item was or was not previously selected, it should accept the manual text entry without reverting back to previous item

What browser are you working in?
Google Chrome

What version of the Carbon Design System are you using?
carbon-components v8.16.8
carbon-components-react v5.31.1
carbon-icons 6.3.2

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
DataFusion

Steps to reproduce the issue

Define ComboBox, such as:
let items=[ {  id: "option-1",  text: "Option 1" }, {  id: "option-2",  text: "Option 2" } ]; <ComboBox items={items} itemToString={item => (item ? item.text : this.state.myStateVariable)} onChange={this.selectOption} onInputChange={this.inputOption} placeHolder="PlaceHolderText" />

Define onChange= and onInputChange= event handlers:
selectOption() is to set the text value directly from one of the pre-defined item options
inputOption() is basically setting the text to a new entry (whatever the user wants it to be)
`
selectOption(event) {
this.setState({
myStateVariable: event.selectedItem.text
});
}

inputOption(event) {
this.setState({
myStateVariable: event
});
}
`

Run the code.

Scenario 1:

On the empty ComboBox, start typing something like "Option 5". Since Option 5 is not a pre-defined item, no actual item is selected from drop down and becomes a new entry.
Click away from the ComboBox (or move to a different input field)
-> The Text will remain "Option 5" (which is set in myStateVariable)

Scenario 2:

On the empty ComboBox, first select an item from the list, such as "Option 1". Since Option 1 exists as a predefined item, it uses that item (and saves/caches it)
Start overwritting the existing item text (Don't click the "x" to clear existing text), such as backspace and type in something new like "Option 5", or add to it so it becomes like "Option 15"
Click away from the ComboBox (or move to next input field)
-> The Text will revert back to the previous item

Bug: in scenario 2, it would be expected to remain as the new/custom text instead. It doesn't make sense for a user to clear/backspace-all and retype just to get a new entry value

Hi @David-Yuen! 👋 Thanks so much for taking the time to make this issue 😄
One thing that would help out a ton here is if you could provide a sample gif that demonstrates the issue that you're highlighting. On our end, we'll try to follow along with your steps to reproduce as well to get the bottom of this.

What tool do you use to capture a gif?
Just to add, i switched from ComboBox and tried Downshift.. realizing Downshift does the same thing. And also i remember you (Josh) mentioned to me that Downshift was being used in ComboBox? so maybe that's the root cause?
Currently switched again to another Component, React-Autocomplete and havn't had this issue

Sounds good! Going to close this, then. Glad to hear you found something that worked!


wrong code: context vs app

current page says:
context = msal.ConfidentialClientApplication(
    service_principal_id, service_principal_secret, authority
    )

token = app.acquire_token_silent([scope])

however, the app object does not exist. it should refer to the context variabe. so, improvement:
app = msal.ConfidentialClientApplication(
    service_principal_id, service_principal_secret, authority
    )

token = app.acquire_token_silent([scope])

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bf934017-cfcd-3887-8b4d-fb830b199cd4
Version Independent ID: d52aedf8-5759-74b8-8e03-530c0a5bd6df
Content: Azure SQL and SQL Server - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @eskot
Microsoft Alias: eskot

@indexample
Thanks for your feedback! We will investigate and update as appropriate.

@indexample
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Captions associated with a video

After this change, we can do something like this
v = Yt::Video.new(id: "8ompJkDKEEI")
c = v.captions.first
c.language
# => "es"

closes #413

Yes, I ran test with those env variables and it passed. As you may know I couldn't run as_content_owner test because I don't have access to any content owner on YouTube. By the way, that test actually currently disabled like https://github.com/nullscreen/yt/blob/master/.rspec#L2 so I was able to simply run rspec


Device network issues

See https://github.com/DeltaV-Station/Delta-v/pull/57
Invalid entity ids still get serialized and looks like shutdownsubscribers just dupes devices anyway.
Ideally devices would just get tracked with no need for 2 separate implementations I think.

Those are not 2 separate implementations for the same thing. ShutdownSubscribers is a property inside DeviceNetworkComponent which is used to notify other systems when a device is removed. Like the device list or device link systems.
It looks duped because one is the ShutdownSubscribers list inside the  DeviceNetworkComponent and the other is the list of devices saved inside the DeviceListComponent.
The list of shutdown subscribers in the screenshot isn't actually the "important" part. Important is the shutdown subscriber list on the devices that are saved inside the DeviceListComponents device list.
Like this one:
  - uid: 2740
    components:
    - rot: 1.5707963267948966 rad
      pos: -7.5,43.5
      parent: 2
      type: Transform
    - ShutdownSubscribers:
      - 5 #This is the air alarms entitiUid
      type: DeviceNetwork
    - enabled: False
      type: AmbientSound
    - nextSound: 4074.8548356
      type: EmitSoundOnCollide

The shudown subscriber list is "bidirectional".
The actual bug is that a device got removed without being removed from the shutdown subscriber list.

Also this is causing issues with PVS logging is trying to send the invalid entities.


Test failure when attempting to build latest master

(Sorry about the contentless initial post)
When attempting to build latest master (633f3cc33bc04a9b38cd503b36a3f571c7756a0d), I get the following error message due to a failing test:
:test

com.github.tomakehurst.wiremock.PostServeActionExtensionTest > providesServeEventWithResponseFieldPopulated FAILED
    java.lang.AssertionError:
    Expected: is <418>
         but: was <0>
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at com.github.tomakehurst.wiremock.PostServeActionExtensionTest.providesServeEventWithResponseFieldPopulated(PostServeActionExtensionTest.java:128)

773 tests completed, 1 failed
:test FAILED

I haven't looked into this test in details, but it seems to fail consistently, I'm running OpenJDK 1.8.0_121 on Ubuntu 16.10.

I have the same issue. It seems that tests are not deterministic when runnin ./gradlew clean test  locally. Sometimes, the build passes and sometimes it fails. I have found two tests with this non-deterministic behavior:

PostServeActionExtensionTest > providesServeEventWithResponseFieldPopulated
PostServeActionExtensionTest > triggersActionWhenAppliedToAStubMapping

Thanks. I see this myself occasionally. I have a rough idea why, just haven't had a chance to fix yet.

Also seeing tests sometimes passing, sometimes failing, with 2.5.1 and 2.6.0. In my case multiple test methods run the same GET query one, and verify(1, ...) sometimes results in
Expected exactly X requests matching the following pattern but received X + 1

Setup is:
@ClassRule
    public static final WireMockClassRule MOCK = new WireMockClassRule(wireMockConfig().dynamicPort().dynamicHttpsPort());

@Before
    public void setUp() {
        MOCK.resetAll();
    }

@tkruse  - this doesn't look like the same issue as the one described above. Would you mind opening a new one and posting your full test code (or a test case the reliably reproduces the problem)?

Not seen this failure for quite a while so I'm assuming it's gone


GitHub runners changes causes the root reserve argument to be non-functional

After a recent GitHub runner change, which changed the file structure of the runners to remove /mnt, the root-reserve-mb flag no longer changes how much storage remains in the root directory.
Old filesystem:

Cleaner results on the old filesystem:

New filesystem:

Cleaner results on the new filesystem:

Arguments:

Note that the arguments we used with the old file system is identical to this except root-reserve-mb was set to 30000.

Oh, that is unfortunate. GitHub has been changing runners quite a lot in the recent past.
TBH, without the second partition, this action is not very useful anymore. The main aspect was to join the free space on / and /mnt. Without a /mnt, there is nothing to add.
The second feature (removing unused software using rm -rf) is something everybody can do way more flexible without the action.
I will try to dig into this, but without a second partition, I guess this action can be trashed...

This is sad to hear, your action has been useful and reliable all this time.
Thanks for responding, I'll close this issue but we'll see if they ever bring back /mnt on another unannounced update.


Implement camera input for qr code on Send Funds

This was in the v1 design as another "action button" next to "Choose File", but I de-prioritized it for MVP.
Code interface needs to be platform agnostic (see FilesystemUI / Choose File)
Obviously makes a lot of sense to implement for mobile under Cordova
How to implement camera under Electron: http://ourcodeworld.com/articles/read/134/how-to-use-the-camera-with-electron-framework-create-a-snapshot-and-save-the-image-on-the-system

This like a potentially great plugin for this use-case.
Seems to support both electron and cordova, need additional testing/doc review to confirm.

I've started working on this, and I have an initial implementation done here: https://github.com/dternyak/mymonero-app-js/tree/qr_scanner_v3
Things we need before this can be merged:

Error handling if user says No once.
Error handling if user says No permanently.
Error handling if QR Scanning succeeds but is not a Monero URI.
Disallow locking when app asks for permission (see line 1615 on SendFundsView.web.js)

self.context.Cordova_disallowLockDownOnAppPause += 1 // place lock so Android app doesn't tear down UI and mess up flow

Ability to cancel scanning once it has begun.
Figure out if there's a better way to show the camera then the current, hacky way making the entire app transparent so the camera can be seen behind it, and then un-making it transparent.

Implemented with https://github.com/mymonero/mymonero-app-js/blob/master/local_modules/QRScanningUI/QRScanningUI.cordova.js


cv2pdb returns error code 127 when handling a fairly large DLL file

We started to use cv2pdb in the project blueCFD-Core a few days ago and it works very well... with only one exception, hence this report.
The build option -gdwarf has been used with g++ with over 300 different binaries (108 DLL and 228 EXE) and cv2pdb worked without problems on all of them, except for one.
This one is an 829 MB DLL file which results in cv2pdb to give an error code of 127, after what it seems to have generated a partial PDB file of 2.9 MB. Download link on DropBox for the file cv2pdb.bug.libfiniteVolume.7z (94 MB), which provides the file libfiniteVolume.dll that triggers this issue, is as follows: https://www.dropbox.com/s/68xaxtmmahxkqs1/cv2pdb.bug.libfiniteVolume.7z?dl=0
Currently our workaround has been to simply ignore the error and strip the debug data from the DLL with strip --strip-unneeded, (edit) which results in a DLL file with only 23 MB.
We are using:

MSys2 software stack with the MinGW64 installation (last updated on the 29th of September, 2017), which comes with GCC 7.2.0.
cv2pdb which was downloaded from the AppVeyor link provided here, on the 6th of October 2017.

I haven't managed to get the time needed to build cv2pdb myself from source code, therefore I haven't tried debugging it.

It seems this is just an out-of-memory problem due to the size of the DLL. cv2pdb currently expects it can hold 2 copies of the image in memory. With /LARGEADDRESSAWARE enabled, the DLL is processed without error. For even larger DLLs you will have to compile cv2pdb as a 64-bit executable (an appropriate configuration exists).
The new AppVeyor build should include this change.

Excellent! Many thanks for the quick reply and fix!
I've tested this just now and it's working perfectly with the latest build from AppVeyor.
I'll make a note regarding the need to build cv2pdb in 64-bit, if we start getting DLL files larger than 1GB.


Windows app blocked by windows defender and Crowdstrike AV

When installing the windows app (both from the msi and the exe installer), the unrecognized app blue warning screen appears (Microsoft Defender SmartScreen).
If you ignore it and install the app, the app itself is blocked by crowstrike AV.
I don't have control over crowdstrike since it was installed by my company.

Hey yeah so sadly the signing certificates for windows are quite expensive so we cant sign the windows builds.. I think Microsoft SmartScreen starts trusting the app after a certain number of installs but this resets when we release a new version.. But as you said it can just be ignored. As for crowdstrike, I don't know why they also block us but I don't think there is much we can do about it. Maybe you we can somehow upload the app for analysis or something.

I think Microsoft SmartScreen starts trusting the app after a certain number of installs but this resets when we release a new version...

submit the program as a false positive on https://www.microsoft.com/en-us/wdsi/filesubmission

I think Microsoft SmartScreen starts trusting the app after a certain number of installs but this resets when we release a new version...

submit the program as a false positive on https://www.microsoft.com/en-us/wdsi/filesubmission

Done (queued, not yet scanned i guess), let's see if something changes.


clean up

Clean up master branch.
some changes were made for old ALKA and should be removed.
@rav4kumar can you confirm the siren changes? make sure it works as intent.
config.py were removed in comma's master so I removed it too.

Oh no, not the siren!!! We should add toggle it is so loud and scary


From Julian (Author): Velocity.js + UI pack updates coming tomorrow.

Oh, and while I have your attention, you can now pre-order the upcoming Velocity.js book: https://twitter.com/Shapiro/status/559572916560343041.

Congrats! :tada:

Anyone would think you knew something about animating things on the web... :-P

Also, a huge thanks to @ydaniv  for all his support with GitHub issues. @Rycochet  and @MattyBalaam  have also been total gentlemen.