ml-online example error

Hi, when I installed miniconda, and then executed as follows :
cd projects/ml-online/

conda env create --file environment.yml --force

conda env export --no-build --file environment.lock.yml

conda activate ml-online

cp soopervisor.yaml soopervisor.yaml.bak

soopervisor add training --backend argo-workflows

When I execute the soopervisor add training --backend argo-workflows command, an error occurs:

Traceback (most recent call last):
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 475, in _auto_load
spec = cls(path, env=env, lazy_import=lazy_import, reload=reload)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 271, in init
Meta.initialize_inplace(self.data)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 618, in initialize_inplace
data['meta'] = Meta.default_meta(data['meta'])
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 651, in default_meta
meta['source_loader'] = SourceLoader(**meta['source_loader'])
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/placeholders/SourceLoader.py", line 65, in init
raise ValueError('Could not locate module "{}"'.format(module))
ValueError: Error initializing SourceLoader with {'module': 'ml_online'}. Error message: Could not locate module "ml_online"
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/guodong/miniconda3/envs/ml-online/bin/soopervisor", line 8, in
sys.exit(cli())
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/click/core.py", line 1137, in call
return self.main(*args, **kwargs)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/click/core.py", line 1062, in main
rv = self.invoke(ctx)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/click/core.py", line 1668, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/click/core.py", line 763, in invoke
return __callback(*args, **kwargs)
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/soopervisor/cli.py", line 52, in add
Exporter('soopervisor.yaml', env_name=name).add()
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/soopervisor/abc.py", line 120, in init
self._dag = DAGSpec.find(lazy_import=True).to_dag().render(
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 523, in find
spec, _ = DAGSpec._auto_load(to_dag=False,
File "/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py", line 485, in _auto_load
raise exc from e
ploomber.exceptions.DAGSpecInitializationError: Error initializing DAG from /home/guodong/projects/ml-online/src/ml_online/pipeline.yaml

Looks like you're missing installing the local package:
# run this in the ml-online folder
pip install --editable .

Let me know if that works.

Thanks, When the pip install --editable . command is executed, this command can run normally.
soopervisor add training --backend argo-workflows
================================== Adding /home/guodong/projects/ml-online/training/Dockerfile... ===================================
=============================================================== Done ================================================================

but When I execute the soopervisor export training command, an error occurs:
soopervisor export training
/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py:312: UserWarning: The following placeholders are declared in the environment but unused in the spec: {'product_root'}
  warnings.warn('The following placeholders are declared in the '
/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py:312: UserWarning: The following placeholders are declared in the environment but unused in the spec: {'product_root'}
  warnings.warn('The following placeholders are declared in the '
100%|███████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:00<00:00, 12671.61it/s]
============================================== Packaging code: python -m build --sdist ==============================================
/home/guodong/miniconda3/envs/ml-online/bin/python: No module named build
Error: An error occurred when executing command: python -m build --sdist
Original error message: Command '('python', '-m', 'build', '--sdist')' returned non-zero exit status 1.

I found that executing the python setup.py build sdist command alone can be successful, but when executing the python -m build --sdist command alone, an error occurs.
what should I do?

Ah, good catch! Looks like I missed adding that dependency!
Try this:
pip install build

That should make python -m build --sdist work.

thank you very much。
When I continued to execute the soopervisor export training command,  an error occurred during the process of building the image，what should I do?
/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py:312: UserWarning: The following placeholders are declared in the environment but unused in the spec: {'product_root'}
  warnings.warn('The following placeholders are declared in the '
/home/guodong/miniconda3/envs/ml-online/lib/python3.8/site-packages/ploomber/spec/dagspec.py:312: UserWarning: The following placeholders are declared in the environment but unused in the spec: {'product_root'}
  warnings.warn('The following placeholders are declared in the '
100%|███████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:00<00:00, 11935.98it/s]
============================================== Packaging code: python -m build --sdist ==============================================
Found existing installation: setuptools 56.0.0
Uninstalling setuptools-56.0.0:
  Successfully uninstalled setuptools-56.0.0
Collecting wheel
  Using cached wheel-0.36.2-py2.py3-none-any.whl (35 kB)
Collecting setuptools>=40.8.0
  Using cached setuptools-57.1.0-py3-none-any.whl (818 kB)
Installing collected packages: wheel, setuptools
Successfully installed setuptools-57.1.0 wheel-0.36.2
WARNING: You are using pip version 21.1.1; however, version 21.1.3 is available.
You should consider upgrading via the '/tmp/build-env-87r_7tpv/bin/python -m pip install --upgrade pip' command.
/tmp/build-env-87r_7tpv/lib/python3.8/site-packages/setuptools/dist.py:484: UserWarning: Normalizing '0.1dev' to '0.1.dev0'
  warnings.warn(tmpl.format(**locals()))
running egg_info
writing src/ml_online.egg-info/PKG-INFO
writing dependency_links to src/ml_online.egg-info/dependency_links.txt
writing requirements to src/ml_online.egg-info/requires.txt
writing top-level names to src/ml_online.egg-info/top_level.txt
reading manifest file 'src/ml_online.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/ml_online.egg-info/SOURCES.txt'
/tmp/build-env-87r_7tpv/lib/python3.8/site-packages/setuptools/dist.py:484: UserWarning: Normalizing '0.1dev' to '0.1.dev0'
  warnings.warn(tmpl.format(**locals()))
running sdist
running egg_info
writing src/ml_online.egg-info/PKG-INFO
writing dependency_links to src/ml_online.egg-info/dependency_links.txt
writing requirements to src/ml_online.egg-info/requires.txt
writing top-level names to src/ml_online.egg-info/top_level.txt
reading manifest file 'src/ml_online.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/ml_online.egg-info/SOURCES.txt'
running check
warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

creating ml_online-0.1.dev0
creating ml_online-0.1.dev0/src
creating ml_online-0.1.dev0/src/ml_online
creating ml_online-0.1.dev0/src/ml_online.egg-info
creating ml_online-0.1.dev0/src/ml_online/notebooks
creating ml_online-0.1.dev0/src/ml_online/tasks
copying files to ml_online-0.1.dev0...
copying MANIFEST.in -> ml_online-0.1.dev0
copying README.md -> ml_online-0.1.dev0
copying setup.py -> ml_online-0.1.dev0
copying src/ml_online/__init__.py -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/env.yaml -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/infer.py -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/io.py -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/model.pickle -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/pipeline-features.yaml -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/pipeline.yaml -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online/service.py -> ml_online-0.1.dev0/src/ml_online
copying src/ml_online.egg-info/PKG-INFO -> ml_online-0.1.dev0/src/ml_online.egg-info
copying src/ml_online.egg-info/SOURCES.txt -> ml_online-0.1.dev0/src/ml_online.egg-info
copying src/ml_online.egg-info/dependency_links.txt -> ml_online-0.1.dev0/src/ml_online.egg-info
copying src/ml_online.egg-info/requires.txt -> ml_online-0.1.dev0/src/ml_online.egg-info
copying src/ml_online.egg-info/top_level.txt -> ml_online-0.1.dev0/src/ml_online.egg-info
copying src/ml_online/notebooks/__init__.py -> ml_online-0.1.dev0/src/ml_online/notebooks
copying src/ml_online/notebooks/fit.py -> ml_online-0.1.dev0/src/ml_online/notebooks
copying src/ml_online/tasks/__init__.py -> ml_online-0.1.dev0/src/ml_online/tasks
copying src/ml_online/tasks/features.py -> ml_online-0.1.dev0/src/ml_online/tasks
copying src/ml_online/tasks/raw.py -> ml_online-0.1.dev0/src/ml_online/tasks
Writing ml_online-0.1.dev0/setup.cfg
Creating tar archive
removing 'ml_online-0.1.dev0' (and everything under it)
======================================= Building image: docker build . --tag ml_online:0.1dev =======================================
Sending build context to Docker daemon  15.87kB
Step 1/7 : FROM condaforge/mambaforge:4.10.1-0
 ---> 05e3542d3437
Step 2/7 : COPY environment.lock.yml project/environment.lock.yml
 ---> Using cache
 ---> 7b7a0089698b
Step 3/7 : RUN mamba env update --name base --file project/environment.lock.yml && conda clean --all --force-pkgs-dir --yes
 ---> Running in 4d1e9dc0a309
anaconda/pkgs/main/linux

# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<

    Traceback (most recent call last):
      File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1079, in __call__
        return func(*args, **kwargs)
      File "/opt/conda/lib/python3.9/site-packages/conda_env/cli/main.py", line 80, in do_call
        exit_code = getattr(module, func_name)(args, parser)
      File "/opt/conda/lib/python3.9/site-packages/conda_env/cli/main_update.py", line 123, in execute
        result[installer_type] = installer.install(prefix, specs, args, env)
      File "/opt/conda/lib/python3.9/site-packages/mamba/mamba_env.py", line 45, in mamba_install
        index = load_channels(
      File "/opt/conda/lib/python3.9/site-packages/mamba/utils.py", line 93, in load_channels
        index = get_index(
      File "/opt/conda/lib/python3.9/site-packages/mamba/utils.py", line 74, in get_index
        is_downloaded = dlist.download(True)
    RuntimeError: Download error (28) Timeout was reached [https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge/noarch/repodata.json]
    Failed to connect to mirrors.tuna.tsinghua.edu.cn port 443: Connection timed out

`$ /opt/conda/bin/mamba update --name base --file project/environment.lock.yml`

  environment variables:
                 CIO_TEST=<not set>
  CONDA_AUTO_UPDATE_CONDA=false
                CONDA_DIR=/opt/conda
               CONDA_ROOT=/opt/conda
           CURL_CA_BUNDLE=<not set>
                     PATH=/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin
                          :/bin
       REQUESTS_CA_BUNDLE=<not set>
            SSL_CERT_FILE=<not set>

     active environment : None
       user config file : /root/.condarc
 populated config files : /opt/conda/.condarc
          conda version : 4.10.1
    conda-build version : not installed
         python version : 3.9.2.final.0
       virtual packages : __linux=3.10.0=0
                          __glibc=2.31=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /opt/conda  (writable)
      conda av data dir : /opt/conda/etc/conda
  conda av metadata url : https://repo.anaconda.com/pkgs/main
           channel URLs : https://conda.anaconda.org/conda-forge/linux-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /opt/conda/pkgs
                          /root/.conda/pkgs
       envs directories : /opt/conda/envs
                          /root/.conda/envs
               platform : linux-64
             user-agent : conda/4.10.1 requests/2.25.1 CPython/3.9.2 Linux/3.10.0-957.27.2.el7.x86_64 ubuntu/20.04.1 glibc/2.31
                UID:GID : 0:0
             netrc file : None
           offline mode : False

An unexpected error has occurred. Conda has prepared the above report.

The command '/bin/sh -c mamba env update --name base --file project/environment.lock.yml && conda clean --all --force-pkgs-dir --yes' returned a non-zero code: 1
Error: An error occurred when executing command: docker build . --tag ml_online:0.1dev
Original error message: Command '('docker', 'build', '.', '--tag', 'ml_online:0.1dev')' returned non-zero exit status 1.

There's some issue with your network:
    RuntimeError: Download error (28) Timeout was reached [https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge/noarch/repodata.json]
    Failed to connect to mirrors.tuna.tsinghua.edu.cn port 443: Connection timed out

There's little I can do to help. Just ensure that conda works. Try installing some virtual environment, see if you get the same error. Otherwise, try with a different network.

Thanks, I switched a server host and slove it, an error occurred during the process of Testing File client，How should I troubleshoot the problem？
     Product       Doc (short)    Location
----------  ------------  -----------  ------------  -------------  ------------
get         Has not been  Source code  File('/mnt/s  Get training   /opt/conda/l
            run                        hared-folde.  data           ib/python3.8
                                       ..ts/raw/get                 /site-packag
                                       .parquet')                   es/ml_online
                                                                    /tasks/raw.p
                                                                    y:5
sepal-area  Has not been  Source code  File('/mnt/s  Compute        /opt/conda/l
            run           & Upstream   hared-folde.  sepal area     ib/python3.8
                                       ..sepal_area                 /site-packag
                                       .parquet')                   es/ml_online
                                                                    /tasks/featu
                                                                    res.py:4
petal-area  Has not been  Source code  File('/mnt/s  Compute        /opt/conda/l
            run           & Upstream   hared-folde.  petal area     ib/python3.8
                                       ..petal_area                 /site-packag
                                       .parquet')                   es/ml_online
                                                                    /tasks/featu
                                                                    res.py:13
features    Has not been  Source code  File('/mnt/s  Join raw       /opt/conda/l
            run           & Upstream   hared-folde.  data with      ib/python3.8
                                       ..s/features  generated      /site-packag
                                       .parquet')    features       es/ml_online
                                                                    /tasks/featu
                                                                    res.py:22
fit         Has not been  Source code  MetaProduct(  Script         /opt/conda/l
            run           & Upstream   {'model': Fi  trains a       ib/python3.8
                                       le('/mnt/sh.  model          /site-packag
                                       ..model.pick                 es/ml_online
                                       le'), 'nb':                  /notebooks/f
                                       File('/mnt/s                 it.py
                                       h.../report.
                                       html')})
======================================================== Testing File client ========================================================
Error: Missing File client
Hint: Run "docker run -it ml_online:0.1dev /bin/bash" to to debug your image. Ensure a File client is configured.

cat env.yaml
sample: False
product_root: /mnt/shared-folder

cat soopervisor.yaml
training:
  backend: argo-workflows
  repository: null
  mounted_volumes:
    - name: shared-folder
      spec:
        nfs:
          server: 10.xxx.xxx.19
          path: /home/data/nfs

Ah, sorry about that! I introduced that recently and forgot to update the example, try this:
soopervisor export training --skip-tests

Thank you for your patient guidance，this example has been able to run normally。

argo submit -n argo training/argo.yaml

Name:                ml-online-t6ng9
Namespace:           argo
ServiceAccount:      default
Status:              Pending
Created:             Wed Jul 14 08:50:50 +0800 (now)
Progress:
This workflow does not have security context set. You can run your workflow pods more securely by setting it.
Learn more at https://argoproj.github.io/argo-workflows/workflow-pod-security-context/

argo logs -n argo ml-online-t6ng9

100%|██████████| 5/5 [00:00<00:00, 11155.06it/s]
100%|██████████| 5/5 [00:00<00:00, 10597.03it/s]
100%|██████████| 5/5 [00:00<00:00, 11293.23it/s]
100%|██████████| 5/5 [00:00<00:00, 11125.47it/s]
100%|██████████| 5/5 [00:00<00:00, 10527.87it/s]
Executing: 100%|██████████| 11/11 [00:05<00:00,  2.18cell/s]

NFS:
tree products

products
├── features
│   ├── features.parquet
│   ├── petal_area.parquet
│   └── sepal_area.parquet
├── model.pickle
├── raw
│   └── get.parquet
└── report.html

I have two more questions:

This example only has the training pipeline. Currently, no prediction pipeline is found on the official website to deploy to kubernetes. Is there currently support for deploying inference services in kubernetes?
In the soopervisor.yaml file, does the storage mount mounted_volumes  support PV/PVC? If so, what should I do?

In the soopervisor.yaml file, does the storage mount mounted_volumes  support PV/PVC? If so, what should I do?

I have solved the second problem, from the google cloud (https://soopervisor.readthedocs.io/en/latest/tutorials/kubernetes.html#optional-mounting-a-shared-disk ) document.

Glad you were able to solve the PV/PVC thing.
Regarding deployment. The example you have been working on (ml-online), contains the code to export an online API via Flask, but we haven't written the example code to deploy that to Kubernetes. If you are willing to do so, I'd be happy to incorporate some code of yours into this repository. I think it'd be great to show how to take the sample Flask app and deploy it in Kubernetes.
There is another example (ml-intermediate) that shows batch deployment. Since the batch deployment pipeline is similar to the training pipeline, the steps for running it on Kubernetes are pretty much the same, although we haven't written a tutorial yet.
If you haven't done so already, please show your support with a star on our main repository. Thanks!

Thanks for your answer. Recently, I am investigating related frameworks of mlops, and the work tasks are relatively heavy. I will try to write examples and deploy to k8s in my spare time.

Awesome! Feel free to reach out if you have more questions. I'll close this issue.


Refine index segment

Wrap SealedIndexSegment related code to one inner class.

Codecov Report
Base: 73.22% // Head: 14.47% // Decreases project coverage by -58.75% :warning:

Coverage data is based on head (6e110d5) compared to base (53033a9).
Patch coverage: 91.72% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2376       +/-   ##
=============================================
- Coverage     73.22%   14.47%   -58.75%
+ Complexity    10694     2305     -8389
=============================================
  Files           767      767
  Lines         59564    59590       +26
  Branches       7298     7302        +4
=============================================
- Hits          43614     8624    -34990
- Misses        13553    50455    +36902
+ Partials       2397      511     -1886

Impacted Files
Coverage Δ

...main/java/com/github/ambry/store/IndexSegment.java
86.51% <91.72%> (-0.07%)
:arrow_down:

.../src/main/java/com/github/ambry/router/Router.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/com/github/ambry/store/Message.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/named/PutResult.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaMode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/quota/QuotaName.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...rc/main/java/com/github/ambry/rest/RestMethod.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/commons/Notifier.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/KMSConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...c/main/java/com/github/ambry/config/SSLConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 599 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Amazon's Skill Builder (BETA) Causing Issues (Warning)

Please make sure you do not use the new beta, skill builder, in order to update your code.  Using this builder caused me to be unable to upload Intent Schema and Sample Utterances , essential to the skill. The cause of this is that skill builder COMBINES the two, so attempting to upload Intent Schema through this tool will only lead to error messages.
Thanks,
Camden

Hi @talk2camden, what do you use instead? I don't seem to be given another option than using the Skill Builder Beta.

Hey @titus-j! If you're stuck on the Skill Builder Beta, here's how to disable it:

Go To Amazon Developer Portal, head to the Alexa section, and then find your skill.

Click that skill's edit button.

Choose the Interaction Model/Builder Beta tab on the left-hand side.

Once you arrive at the dashboard page, scroll down to the bottom of the page.

Under the Opt-Out of Beta Preview section, select the Leave Beta Preview button. (pictured below)

You're done! Now you'll be back to that friendly old page, where you can do your copying and pasting again.

Please feel free to message me if you have any more questions!
P.S.: I have sort of given up on Amazon, as the last 5 or so skills/apps/updates I've submitted to them have all been rejected for no good reason. It was obvious that they were trying to nitpick every detail, including their own tool flaws and blaming it on me. Things like similar or repeated intents stopped me from being published. They didn't use to be like this at all. Not sure what happened. Notice how Amazon's monthly developer rewards get harder and harder to qualify for? That's purposeful. Just don't get your hopes up too high, as I have been denied for apps that were approved on other markets.
--Camden

Thanks @talk2camden . Worked like a charm for me.


[example] using Hamilton with duckdb

idea
https://duckdb.org/ is a hot new tool. It could be a nice way to load data for people. We should show some ways people could use it with Hamilton. IIRC duckdb does predicate push down when querying files like parquet, which can be faster than loading them via pandas and then doing some filters.
Rough sketch:

data_loaders module that connects with duckdb
feature_logic module(s) that works from the output of the data_loaders

Could I be assigned this issue?

@shrey231 sorry I didn't see this!! I would love some thoughts -- I've built out some basic SQL adapters, but I'd love to see more + transforms 🙏

@shrey231 if you're still interested, let me know and we can assign it to you.

#195 did this.


Can u support more examples in  difference language such as JAVA?

Can u support more examples in  difference language such as JAVA?

Yes.
Ok, I'll add one in Java.

I added Java example under package com/labo/kaji/relativepopupwindow/example/java.
It behaves the same way as Kotlin example.


JSON editor not opening

System information:

Operating system (distribution) and version:
Microsoft Windows 10 Pro, Version 10.0.16299 Build 16299
DBeaver version: Version <IP_ADDRESS>002151353
Additional extensions: no

Connection specification:

Database name and version: PostgreSQL 11.1 x64
Driver name: don't know
Do you use tunnels or proxies (SSH, SOCKS, etc)? : no

Describe the problem you're observing:
Error after open editor to edit json column
The error looks like another issues:
https://github.com/dbeaver/dbeaver/issues/6738
https://github.com/dbeaver/dbeaver/issues/2880
Steps to reproduce, if exist:
see screenshots below:

I can't reproduce it. Perhaps something went wrong right before opening editor.
Please attach error/debug logs (https://github.com/dbeaver/dbeaver/wiki/Log-files)

It's strange but I don't reproduce bug this day.
But I reproduce bug with clean inline editor for json field in select result window.

cannot reproduce last mentioned issue
is it still actual against v7.0.0?

No, thanks


Adds image to autodiff article.

Website build
Commit: 7de6c90a9ffe43c13c8a2e8118f4e914426febc1
Circle build number: 639
Website zip: https://639-214003948-gh.circle-artifacts.com/0/tmp/qml_html.zip
Website url: https://639-214003948-gh.circle-artifacts.com/0/_build/html/index.html
Please double check the rendered website build to make sure everything is correct.


Update SvelteToastOptions type

First, thank you for this component.
I get this error : Argument of type '{ target: string; }' is not assignable to parameter of type 'SvelteToastOptions'.
when trying to toast.push('Hey!', { target: 'new' })
Also this  toast.push({ msg: 'Yo!', duration: 2000 }) results in an error. Argument of type '{ msg: string; duration: number; }' is not assignable to parameter of type 'string'.
SvelteToastOptions and push should be updated.
Thank you

Hi @LucianVoju - thanks for raising this. I've corrected the typescript declarations file that should fix your issues. 🤞
Could you update svelte-toast to v0.4.1 and try again? Thanks!

@LucianVoju - Shifting your comment https://github.com/zerodevx/svelte-toast/issues/25#issuecomment-889036326 here.
I can't replicate the errors you're seeing. Your editor might be picking up the old declaration file? Can you ensure that you're updated to the latest v0.4.1 release and perhaps reset your editor workspace?

Hello,
I have made your suggestions and now everything works fine. No more Ts errors.
Thank you

Glad it's sorted out. Closing this for now.


[Snyk] Upgrade @loopback/boot from 7.0.2 to 7.0.7

Snyk has created this PR to upgrade @loopback/boot from 7.0.2 to 7.0.7.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 5 versions ahead of your current version.

The recommended version was released on 2 months ago.

Release notes

Package name: @loopback/boot

7.0.7 - 2024-10-15<EMAIL_ADDRESS>

7.0.6 - 2024-09-12

7.0.5 - 2024-08-14

7.0.4 - 2024-07-09

7.0.3 - 2024-06-11

7.0.2 - 2024-05-17

    from @loopback/boot GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Done in https://github.com/sourcefuse/loopback4-ratelimiter/pull/202


bug: AADSTS50147: Invalid size of the code challenge parameter.

Bug Report
Version:
Version <IP_ADDRESS>
Current behavior:
During the authentication and clicking on Reload List, the following error pops up. AADSTS50147: Invalid size of the code challenge parameter.
Expected behavior:
I am using the tool for the 1st time and I expect it to load the managed identities without any pop ups.
Steps to reproduce:
Not sure, it happens continuously n my device against my developer tenant.
Related code:
N/A
![image](https://github.com/user-attachments/assets/6dc9b8d9-089b-4c9b-8eee-97685ed171a8)

Other information:

Thanks for reporting this.
That is strange - never seen that and have tested on diffrent tenants here and a lot of other people have tested it.
And I cant find so much for that error...
What versions of the MS Graph modules have you installed?

I have seen if I could find more about this, but no 😓
In the Entra ID signin logs in your dev tenant, can you see something there is failing?

@michaelmsonne,
Thank you for following up. I encountered an error the first time I used your application, and I had never seen this error before, either in production or on my developer tenant. Interestingly, I kept experiencing the error afterward. I decided to clear the Windows Credential Manager and tried again, and this time it worked! It seems that some sort of caching issue was the problem.

Hi @ghdineshs ,
Haha okay fun - thanks for the update here and the fix for it 👍
I will close this one here, and if other, let me know.


Insert replacement characters like node does when converting UTF8 bytes to String

Possible fix for #66

Will review today

Cool, thanks. I just installed node@3 and I see now it is replacing things in the surrogate pair range - pushing a test and fix for that now..

LGTM. Waiting for @dcousens. Feel free to merge when it looks good. Then I'll do a release.

LGTM.  Nice implementation,  I might break down down some of the indentation through the use of continue/break.

Published as 3.4.2.


removing title link

removing title link so that Network info, deployed contracts, and block explorers article doesn't link out to Node Providers article part-way down the page.

I believe these are false negatives. Going to merge. Thank you, @sammysango !


Roll Flutter Engine from 73c3135cc3be to 2f8c752768f7 (1 revision)

https://github.com/flutter/engine/compare/73c3135cc3be...2f8c752768f7
2024-08-13<EMAIL_ADDRESS>Roll Dart SDK from 9a6ec6cc9627 to 44635f897535 (2 revisions) (flutter/engine#54536)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


RKE1 etcd snapshot trying too frequently

Describe the bug

The rke-tools image will retry the etcd snapshot four times, and rancher will retry the run of the rke-tools container 5 times. In situations where the etcd snapshot will never succeed (i.e. when etcd is not running), this causes the logs to be inundated with error messages.
To Reproduce

Provision a Rancher instance with a three all role node custom cluster attached
Stop etcd on first downstream node docker stop etcd
Trigger a snapshot for the cluster within Rancher
Observe looping attempts to perform etcd-snapshot on the node with etcd container stopped

Result
Rancher will try 20 times on the node with etcd stopped, before moving on to the next node, printing logs every second.
Expected Result

RKE should see that etcd isn't running on the node, and attempt to retry with backoff so as not to saturate the logs. When etcd is running but there is another problem, the retry with backoff should still be performed.
Additional context

SURE-3513

Root cause
This issue had multiple root causes:

The rke1 docker interface prints container logs every second. During cluster up, these logs are useful, but certain operations (such as taking a snapshot) do not have many unique logs and last a while, which clutters the rancher logs.
Taking a snapshot had retry for things that were not possible to recover from, such as the etcd container not running.
Snapshot with invalid s3 credentials would try to take the snapshot, and then upload to s3. If this upload failed, the local snapshot would be deleted and recreated, and then rancher would reattempt the upload multiple times.
If any of the nodes failed to take a snapshot, the remaining nodes would not take a snapshot. Since only one nodes is required to have the snapshot in order to restore, this wasn't too impactful, but realistically there was no barrier for the nodes having said snapshot
On s3 buckets without versioning enabled, every node would upload the snapshot. Although there is currently no mechanism for choosing which version to restore, and the last one will (and always would) take precedence, now if the s3 bucket does not have versioning enabled, only one snapshot is uploaded.

What was fixed, or what changes have occurred

Made a configurable option to only print unique container logs.
Stop trying to take a snapshot on a node if it cannot succeed (etcd is not running: this almost always indicates outside intervention).
Attempt the s3 upload 3 times and do not delete the local snapshot.
If a bucket doesn't have s3 bucket versioning enabled, first check if the snapshot exists in the bucket, and overwrite if it does not. If s3 bucket versioning is enabled, then upload regardless. This is a small change, but should improve performance for large etcd clusters without bucket versioning.

Areas or cases that should be tested

Cluster with invalid s3 credentials (create the cluster with valid credentials, then delete the s3 bucket)
s3 bucket without versioning should only upload once
s3 bucket with versioning should upload once per node
3 node etcd cluster where one node has etcd stopped should not have a snapshot on the node with the stopped etcd container. The other two nodes should have it. Attempting to restore should populate the snapshot onto the node that did not have the snapshot. This snapshot should also show as Active in the UI.

What areas could experience regressions?
N/A
Are the repro steps accurate/minimal?
:heavy_check_mark:

Test Environment:
Rancher version: v2.6-head a678d0e
Rancher cluster type: HA
Docker version: 20.10
Downstream cluster type: RKE1

Testing:
Tested this issue with the following scenarios:
P0

provision an rke1 custom cluster
Stop etcd on first downstream node docker stop etcd
Trigger a snapshot for the cluster within Rancher
Observe looping attempts to perform etcd-snapshot on the node with etcd container stopped

Other scenarios:

Cluster with invalid s3 credentials

Create the cluster with valid credentials
Then delete the s3 bucket)

s3 bucket without versioning should only upload once
s3 bucket with versioning should upload once per node
3 node etcd cluster where one node has etcd stopped should not have a snapshot on the node with the stopped etcd container. The other two nodes should have it. Attempting to restore should populate the snapshot onto the node that did not have the snapshot. This snapshot should also show as Active in the UI.

Result - Pass
All scenarios are Pass


WIP Backend rework, adding compile and execute

Removing more of the sdk from the quantum program and fleshing out the backends more

Description

Examples

hello_quantum.py -> Made to use qiskit.execute
using_qiskit_level_1.py -> Using compile
using_qiskit_level_2.py -> Using execute
added execute -- takes a list of quantumCircuits and gets the results
added compile -- takes a list of quantumCircuit and gets a qobj (old style)
pretty sure openquantumcompiler calls compile correctly but i think this can be made obsolete
pretty sure we made quantumprogram backward compatible
added name to quantumCircuit
added api wrapper for api object
ali added the device schema and qobj schema

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@ajavadia i dont mind either way for your suggestions. I will let you and the team decide.
My preference for going lower in numbers for more control is it is like lower level in the stack. But i have to omit that i did it they way you are proposing first.
As for unpacking i dont mind -- my concern is that as we extend and add openpulse and extensions i dont want to force configs to have options that are not used. A simple example is why do we give the seed to a compile for a real device. I know i am stilling doing this but with a dictionary we can envision making this nice in the future.


Changing device name doesn't work

I tried changing the device name by using the following configs in the app.toml file:
default_device = "macos-terminal"

[device]
name = "macos-terminal"

But when running spotify_player with this config no audio comes out of my system, I able to see though that something is playing on a device called macos-terminal from the spotify client.
Am I missing something, or is it not possible to configure the device name?

Works perfectly fine for with 0.16.3. Can you provide any logs or backtraces? Refer to https://github.com/aome510/spotify-player?tab=readme-ov-file#logging for more details

@Giuliopime let me know if it still doesn't work for you. Otherwise, I'll close this issue.


[Feature Request] Upgrade to k8s/go-client 1.10 or later

FEATURE REQUEST
/kind feature
k8s/client-go includes some recent fixes kubernetes/kubernetes#58141 that significantly impact how GCP service accounts interact with RBAC. Specifically, that fix is needed in order to be able to authenticate to GCP using a service account and have the email of the service account be used to match RBAC role bindings.
ksonnet 0.9.1 is using
client-go version: 1.8
It looks like its pinned here to this version.
Would it be possible to upgrade client-go in the next release to pick up the latest fixes?
Thanks.

It would be possible. Client-go is difficult because major releases are difficult to integrate. I haven't taken a look at it it yet, but I will investigate what it would take to get this upgraded in the next three weeks.


chore(package): v2.0.5

Coverage remained the same at 98.584% when pulling 0416cd7e9775f737988eb4e3517dced459c41506 on release-2.0.5 into bd15913dcb7f07b96f14fd64d1b908eba17dc411 on 2.x.


Plugin does not add front matter to newly created note

I have started using this plugin a few weeks ago, but it looks like the plugin does not add the front matter to notes at all.

Reloading all plugins helped.
Sorry!


Fix issue with esbuild class transform

If you set this.#props and call super() in both if blocks, when using esbuild it will transform them and put the this call first causing runtime failure.

esbuild haven't covered this scenario as they feel it is very uncommon and hard to implement on their side: https://github.com/evanw/esbuild/issues/1918

For a bit more background -- this tweak will allow folks using the built-in Lambda creation with AWS CDK to use Kysely out of the box without custom JS builders.

I'm ok with this fix, but the implementation could be better. _super and _props have the type any. Also variables that start with an underscore are used nowhere in kysely's codebase, so maybe just give more descriptive names for them:
let superProps: QueryProps | undefined
let props: KyselyProps | undefined

You could also move the freeze call to the last line.

All fixed up, let me know if that works for you or not.

Perfect!

I'll release a new version soon.

0.16.0 is out with this fix


Add download directory selection

Prompt the user to select a download directory instead of downloading it in the working directory

#54


Use base state from core

With this PR, QEDprocesses should use base_state and all particles from QEDcore, not from QEDbase.
This is part of the general restructuring of QED.jl, see https://github.com/QEDjl-project/QED.jl/issues/35 for details.

@AntonReinhard ping 😄


Convert project to C++?

ImGui.NET has a ton of issues and it might be worthwhile to convert the project to C++
the alternative would be to try and fix up ImGui.NET which would require me to test on all platforms and learn how assembly/native library loading works in C#

imgui net works correctly now it seems


Maven project - "war" pom packaging type prevents java sources from being read

From issue in moderne-help: https://github.com/moderneinc/moderne-help/issues/2
The project murdos/OpenCyclos fails to ingest.
The cause is in rewrite-maven, we only allow pom packing types of jar and bundle.

cc / @murdos . A fix for this is incorporated into the in-progress Maven resolution work going on now.


Fix flaky spec: trigger updates instead of rely on sleeps

WHAT is this pull request doing?
The should resume flow when disk is no longer full flow spec is flaky on macos. This PR try to fix the specs by triggering disk update instead of relying on sleeps and fiber work.
HOW can this pull request be tested?
Run specs. For me it failed locally with seed 73372 before this patch.

Ok, good, but makes me think that System.system_metrics should have a better name, reflecting what it's actually doing, eg. System.update_system_metrics (and with default parameters).

👍
I think we should move flow control out of the stats loop  (maybe it's own loop with a shorter sleep? Or actually check disk space every time we open a new file?). I don't think it makes sense to do flow control in the stats loop at least!

👍
I think we should move flow control out of the stats loop (maybe it's own loop with a shorter sleep? Or actually check disk space every time we open a new file?). I don't think it makes sense to do flow control in the stats loop at least!

I agree that it is more clear to separate the flow control from stats loop.. but lets make a separate issue for that :)


Allow for picker without input

Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Id like to be able to use a popup picker without a related text field (and conversely the wrapper that surrounds the text field(s).
Describe alternatives you've considered
Right now I have no way of hiding/removing (or styling) the MuiPickersDateRangePickerInput-rangeInputsContainer if I want to use the popup purely on a button with no text field related. This is a problem in grid layouts if I want only to have the button.
Additional context
Add any other context or screenshots about the feature request here.

This is an example of where it places the empty text field (by passing renderInput as <></> or another hidden element) and it messes with the layout.
I know this would be difficult with positioning the popup relative to the parent but an option to hide the input or not use it would be great for enabling it to be able to be called only on button press

You should be able to implement this with the Static version of the components. Let us know if you face any issues with this approach.


Hierarchies: Enhancements incl. nested levels

Gitlab Issue:

https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/367

[x] Show hierarchies inside left filters

[x] Show hierarchies inside legend

[x] Select only leaves as the default when segmenting to avoid 200% problem (see Gitlab issue)

[x] Fix hierarchies in maps #596

For me the majority of this issues has been done.

Yes you're right, this task was already big and I think it would be better to split those improvements out of the main improvements of the hierarchies. I had kept it in my head though but thanks for reminding me, I am creating a new issue to track this.

I created this https://github.com/visualize-admin/visualization-tool/issues/643

OK


Move cuffcompare temp files out of working dir in cuffmerge

I was running multiple instances of cuffmerge in the same working directory and all but one exited with the following error:
IOError: [Errno 2] No such file or directory: 'tmp_meta_asm.combined.gtf'

It appears that the calls to cuffcompare within cuffmerge are using temporary files with static names in the working directory, and the file had been moved by one of the processes (the one that succeeded).
This pull request fixes this issue by using tmp_dir instead of tmp_meta_asm.

Note that I realize right now that this problem was already discussed in issue #33.


Betterlockscreen 3.2.0 -> 4.0.0

Motivation for this change
I've mainly joined/revived the Betterlockscreen project about three months ago. Today after a beta-phase I released the next stable major-release prepared the last months :)
Things done
Updated version, adjusted dependencies according the shell.nix (also provided in the project), Added as maintainer for the package and so added to maintainers
I will also fix a back-port if the bot isn't getting it :)

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133306 at 2f59b54e run on x86_64-linux 1

1 package built successfully:

betterlockscreen

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook postInstall.
Near pkgs/misc/screensavers/betterlockscreen/default.nix:33:3:
   |
33 |   installPhase =
   |   ^


Surround ternary with parens to ensure correct operator precedence

Without the parentheses, my_value.variance was being appended to ret instead
of the entire conditional.
Motivation
Fixes #2693, which caused srb rbi to fail for gems with a bundled .rbi that contained type members (namely, sorbet-rails - see related issue https://github.com/chanzuckerberg/sorbet-rails/issues/275 ).
Test plan
No tests written. I would appreciate guidance as to how to test this - I'm new to this code base and I'm applying a very tactical "fix" to a large piece of code that I do not pretend to understand.

Can I get a merge from a commiter please? Thanks!


provider-azure bootDiagnostics for VM not working

What happened?
VM can't be created from a simple k apply -f vm.yaml , it errors out with the following:
LinuxVirtualMachine in version "v1beta1" cannot be handled as a LinuxVirtualMachine: strict decoding error: unknown field "spec.forProvider.bootDiagnostics.storageAccountUri"
How can we reproduce it?
Create a vm with bootDiagnostics enabled
What environment did it happen in?
Crossplane version:
latest 1.14.5
kube vesion 1.28.3 on microk8s Ubuntu 22.04 LTS
apiVersion: compute.azure.upbound.io/v1beta1
kind: LinuxVirtualMachine
it is set correctly but for some reason, API does not recognize it as such
API docs on the website clearly show this option
bootDiagnostics:
storageAccountUri:
k get providers
NAME INSTALLED HEALTHY PACKAGE AGE
provider-azure-compute True True xpkg.upbound.io/upbound/provider-azure-compute:v0.40.0 8d
provider-azure-storage True True xpkg.upbound.io/upbound/provider-azure-storage:v0.40.0 8d

Update:
So pretty sure this is a bug. I have investigated further, enabled boot diagnostics manually from the portal (bad idea but appropriate for this test), and then looked at how the VM looked from crossplane perspective (or kubectl rather).
It was fine and running but the entries for bootDiag revealed this:
bootDiagnostics:

storageAccountUri: ""

So, the first one according to the manual is an array, fine. The storageAccuntUri is a string but here is the catch it cannot be empty field or it will bark about a bad value. One would think that not existing string and an empty string would be the same thing but it ain't. (at least in my brain it was)
So for those who stumbled upon this the same way I did the answer is: Include the quotes " " and define an empty stirng and viola, you will have your bootDiag enabled and be able to see any error messages  if you need to.
In the end, I'm still not sure what is the proper value of this field. I tried the short name of the storage account from the same yaml, then full resourceID : /subscriptions/xxx-xxx-xxx/resourceGroups/xxx/storagename to no avail.
it would be nice to have storageAccountRef here...
Long story short, the docs should specify in more detail what this should be, and if there is no value treat it as an empty string and maybe use some regex like s//""/g or something.
Anyway, hope this will help someone. Feel free to do as you wish with this ticket.

@techny210, could you please give us the used MRs and reproduction steps so we can reproduce the bug?

There was no MR per se. You can reproduce it by creating a vm with bootDiagnostics enabled. I could not.

Could you please share the sample manifest of the resource you are trying to create, as follows:
apiVersion: compute.azure.upbound.io/v1beta1
kind: LinuxVirtualMachine
metadata:
  annotations:
    meta.upbound.io/example-id: compute/v1beta1/linuxvirtualmachine
  labels:
    testing.upbound.io/example-name: example
  name: example
spec:
  forProvider:
    adminSshKey:
    - publicKey: <....>
    adminUsername: adminuser
    location: West Europe
    networkInterfaceIdsRefs:
    - name: example
    osDisk:
    - caching: ReadWrite
      storageAccountType: Standard_LRS
    resourceGroupNameSelector:
      matchLabels:
        testing.upbound.io/example-name: example
    size: Standard_F2
    sourceImageReference:
    - offer: UbuntuServer
      publisher: Canonical
      sku: 16.04-LTS
      version: latest

kind: LinuxVirtualMachine
metadata:
  annotations:
    meta.upbound.io/example-id: compute/v1beta1/linuxvirtualmachine
  labels:
    deployment-name: crossplane-test
  name: testvm
spec:
  forProvider:
    adminSshKey:
    - publicKey: ssh-rsa ...
    username: mgn
    adminUsername: mgn
    allowExtensionOperations: true
    availabilitySetId: ""
    bootDiagnostics:
    - storageAccountUri: ""   # <--- This is the part that MUST be here, found it the hard way
    location: East US
    networkInterfaceIdsRefs:
    - name: testvm-nic
    osDisk:
    - caching: ReadWrite
      storageAccountType: Standard_LRS
    resourceGroupNameSelector:
      matchLabels:
        deployment-name: crossplane-test
    size: Standard_B1ms
    sourceImageReference:
    - offer: 0001-com-ubuntu-server-jammy
      publisher: Canonical
      sku: 22_04-lts-gen2
      version: latest
    userData:...

@techny210, I cannot reproduce the error with the information you provided:
> k get linuxvirtualmachine.compute.azure.upbound.io/example -o yaml -w
apiVersion: compute.azure.upbound.io/v1beta1
kind: LinuxVirtualMachine
metadata:
  annotations:
    ...
  labels:
    testing.upbound.io/example-name: example
  name: example
  resourceVersion: "127892"
  uid: 2988e613-87c2-4a5b-9f7c-089db79ca991
spec:
  deletionPolicy: Delete
  forProvider:
    adminSshKey:
    - publicKey: ssh-rsa ...
<EMAIL_ADDRESS>      username: adminuser
    adminUsername: adminuser
    allowExtensionOperations: true
    bootDiagnostics:
    - storageAccountUri: ""
    computerName: example
    disablePasswordAuthentication: true
    extensionsTimeBudget: PT1H30M
    location: West Europe
    maxBidPrice: -1
    networkInterfaceIds:
    - /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/example/providers/Microsoft.Network/networkInterfaces/example
    networkInterfaceIdsRefs:
    - name: example
    osDisk:
    - caching: ReadWrite
      storageAccountType: Standard_LRS
    patchAssessmentMode: ImageDefault
    patchMode: ImageDefault
    priority: Regular
    provisionVmAgent: true
    resourceGroupName: example
    resourceGroupNameRef:
      name: example
    resourceGroupNameSelector:
      matchLabels:
        testing.upbound.io/example-name: example
    size: Standard_F2
    sourceImageReference:
    - offer: UbuntuServer
      publisher: Canonical
      sku: 16.04-LTS
      version: latest
  initProvider: {}
  managementPolicies:
  - '*'
  providerConfigRef:
    name: default
status:
  atProvider:
    ...
    ..
    .
  conditions:
  - lastTransitionTime: "2024-01-22T06:36:12Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-01-22T06:37:11Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-01-22T06:37:03Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation

Please try with v0.41.0 and let us know.

Old issue, upgrade fixed it


added a right hand

just mirrored the left hand.glb in blender and put it back in with a new animtree same as the left and the same script as in left

Thanks!
Can you delete the .DS_store files and then add .DS_store to the .gitignore file (surprised it's not there). These are files macOS makes that we really don't want in the repo. I'm surprised I've left it out of the ignore file..

Cheers!

Dangit, wrong place :) this should have been done on godotVR. I shall fix


3244 restrict TermLike test data generator

Fixes #3244
Scope:
Restricts the TermLike generator inside ConsistentKore to avoid generating terms that should only be present in a predicate (\bottom, \exists, \forall, \iff, \implies, \not, \mu, \nu).

\top was kept because otherwise the generator would fail on terms of sort otherTopSort and was at times looping (which should be investigated separately).
(term-typed) \and and \or were kept as requested but are restricted to not occur within terms inside a predicate.

Estimate:

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

Still getting some errors at times, but very infrequent now (I ran 200 stack test without any errors):
        ┏━━ test/Test/Kore/Internal/TermLike.hs ━━━
    722 ┃ test_toSyntaxPattern :: TestTree
    723 ┃ test_toSyntaxPattern = Hedgehog.testProperty "convert a valid pattern to a Syntax.Pattern and back" . Hedgehog.property $ do
        ┃ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        ┃ │ ━━━ Exception (ErrorCall) ━━━
        ┃ │ Cannot generate terms for SortActualSort (SortActual {sortActualName = InternedId {getInternedId = "mapSort", internedIdLocation = AstLocationTest}, sortActualSorts = []})
        ┃ │ CallStack (from HasCallStack):
        ┃ │   error, called at test/Test/ConsistentKore.hs:229:20 in main:Test.ConsistentKore
    724 ┃     -- generate a consistent (internal) pattern to turn into a (general) term

It looks like we do not provide an implementation for terms of mapSort. Also, I discovered Test.Kore.termLikeGen which is older but used in some tests, too.

LGTM but should we support the mapSort stuff or make a new issue?

should we add support the mapSort stuff and if so, do it in this PR or make a new issue?

We definitely should add support for the Map type (IIUC we never generate it at the moment), and probably revisit the entire generator setup (comparing to the one in Test.Kore). I'd say at least a new issue.


Test case for anonymous nuget list command

Task Description
s-w-i-t has test case for nuget list command, it should be able to list packages without credentials.
Task Relationships
This task:

Relates to: https://github.com/strongbox/strongbox/issues/1662

Useful Links

https://github.com/strongbox/strongbox-web-integration-tests

Help

Our chat
Points of contact:

@carlspring
@fuss86
@sbespalov
@steve-todorov

That would be a great to have! Eventually when chocolatey/choco#1827 gets merged we should create a docker image with choco as well, since choco doesn't work very well with recent mono versions (which is why we don't have it in s-w-i-t)

@anki2189 thanks for the issue, I was thinking to do the same but you got ahead of me :+1:

Hey guys,
chocolatey/choco#1827 has finally been merged! :)

Awesome! :)
@anki2189 I'm currently working on other tasks. Would you be interested in playing around with some docker? Essentially a new image based on Dockerfile.alpine.jdk(8|11)-mvn3.6-mono5-nuget3.4 needs to be created. You can checkout this image which is similar to what we'd need (but using alpine).

Sure.

Can I attempt this?

Hi @ykabusalah , thanks for your interest in this task. @anki2189 are you working on this task right now? AFAIK you're working on #1709 only, right?

Right @steve-todorov , I am working #1709. @ykabusalah feel free to pick this task. :)

Thanks for confirming! @ykabusalah If you are still interested let me known so I can assign this task to you.

@ykabusalah Are you working on this task ?

@anki2189 ,
Feel free to pick it up.

@anki2189 ,
Could this now be closed?

Yes, we can close this now.

Thanks for confirming! :)


🍌create bootstrap project chart🍌

Move bootstrap charts to create projects, bindings and sa here 🌱

works in CI so merging in


feat: add giscus comment

You can't just add the giscus template or its entire configuration into Minima for the reasons below:

When switching to the dark/light mode, giscus needs to be notified and changes as well.
Users, as lazy as they are, need us to make some simple and usable presets of any plugin's configuration.

So I'm closing this PR.

So...
Is there a simpler way to add <script> or <style> into my page without editing the minima theme? Maybe I can do the configuration edit straightly in template html file.
祝好

应该是没有的，你要加 giscus 吗，我打算加但还没时间弄。

我去看看文档，想想弄怎么简单一点


update individual annotations

Changes to annotation list to avoid full refresh of the list
Create separate functions and signals for add/update/delete annotation and trigger signals accordingly
Create interface for common signals between AnnotationSource and MultiscaleAnnotationSource

Looks great! I just removed two lines -- one commented out code and the other the unused id for annotations. Nice work!

This resolves #250.
@akhileshh Would you mind creating a PR targeting Googles neuroglancer:master branch as well?


Convert Adobe casks to be multilingual.

Checklist

[x] The commit message includes the cask’s name and version.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

@caskroom/maintainers, any objections to merging these? They only ever have one URL, so there aren't any maintenance problems.

LGTM

This pull request was merged in 3a74b70fb1e3c786dc2115a05497cc6b03d93fef...03f9d7926f443603ff3b8f17fda730d55220ed75.


Bring across @cloudflare/kv-asset-handler

Adds @cloudflare/kv-asset-handler to workers-sdk.
A slightly wonky #4315.
# /path/to/filter.sh
#!/bin/sh

mkdir -p packages/kv-asset-handler
rsync -avC --remove-source-files . ./packages/kv-asset-handler

# in kv-asset-handler
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --tree-filter '/path/to/filter.sh'
git filter-repo --tag-rename '':'@cloudflare/kv-asset-handler@' --force
git filter-repo --tag-rename '@cloudflare/kv-asset-handler@v':'@cloudflare/kv-asset-handler@' --force

# in workers-sdk
git remote add kv-asset-handler-remote /path/to/kv-asset-handler
git fetch kv-asset-handler-remote
git checkout -b kv-asset-handler
git cherry-pick ..kv-asset-handler-remote/main --strategy-option theirs -m 1
# then spam `git cherry-pick --skip`

The only interesting commits are these four:

https://github.com/cloudflare/workers-sdk/pull/4782/commits/b97d7b1f28f546ef39ec29831beb08b653bf5f03
https://github.com/cloudflare/workers-sdk/pull/4782/commits/dff495acf1eddff589234ce6188a251b173c9be1
https://github.com/cloudflare/workers-sdk/pull/4782/commits/4df8de8da9486381724c71e2aced38bce7fcdf74
https://github.com/cloudflare/workers-sdk/pull/4782/commits/c3faba192df5e973d4ff4fb7c5b4df8cee390b42

Nice to see this!! Is there any way to bring over the commit history like in https://github.com/cloudflare/workers-sdk/pull/4315 - I feel there's a lot of nuance and history there that would be good to keep?

Yup, absolutely can do. That's a good shout, thanks! :)

It does indeed. That was the primary motivation for it actually, since @cloudflare/kv-asset-handler is solely managed by wrangler-publisher in npm, but no human has the keys to that.
I have magical admin powers to merge this PR and archive the repo once this one is in.
I'll bring across all issues and label them with kv-asset-handler.


Would it support android target api 33?

Google has sent this warning to apps that does not target API 33
To provide users with a safe and secure experience, Google Play requires all apps to meet target API level requirements.
From 31 Aug 2023, if your target API level is not within one year of the latest Android release, you won't be able to update your app.
So, I was wondering if this plugin would work ok with this upgrade from api 31 to 33?

@degroundshaker support 33


Add a custom @_spi kind to expose BumpPtrAllocator from SwiftSyntax to ASTGen.

Mark BumpPtrAllocator as @_spi(BumpPtrAllocator) and change @_spi(RawSyntax) import SwiftSyntax in ASTGen.swift to @_spi(BumpPtrAllocator) import SwiftSyntax.
That way, ASTGen doesn’t need to import SwiftSyntax with @_spi(RawSyntax).

hello, I am a total newbie to open source. Would be great if I could start woking on this. just confirming, i just need to find and replace right?.
thank you

Yes, should be quite straightforward. Just note that the apple/swift side of this issue depends on https://github.com/apple/swift/pull/67111 being merged.

what does that mean? sorry if this is a very basic doubt. should I fork the repo and start to work now then? or wait?

I think it’s probably easiest if you just wait until https://github.com/apple/swift/pull/67111 is merged.

ah that's great. thank you so much. will keep an eye out

Can I work on the issue?

@ChiduAnush Are you still keen to work on this?

Yes, would be great if you could assign it

Yes, would be great if you could assign it

You're already assigned!

@veryharsh123 Do you mind deferring this issue to @ChiduAnush since he was already assigned?

can you tell me what exactly do you mean by Mark BumpPtrAllocator as @_spi(BumpPtrAllocator)?

Sure. swift/main depends on swift-syntax/main, so you need 2 simultaneous pull requests to pull this off: one in https://github.com/apple/swift-syntax that marks the BumpPtrAllocator class as @_spi(BumpPtrAllocator) instead of @_spi(RawSyntax), and a second one in this repository that updates the import declaration in ASTGen.swift.

please check and let me know if everything is all right.

I think you also need to change the import of SwiftSyntax in ASTGen.swift to be @_spi(BumpPtrAllocator)
https://github.com/apple/swift/blob/95330bcc5bf95a1bf1ff3a00d71d701101af57eb/lib/ASTGen/Sources/ASTGen/ASTGen.swift#L7

I already did that. There are 2 pull requests.

Oh, sorry. I didn’t see your PR to apple/swift. In general, if you have two PRs that are linked like that, it’s good practice to reference the accompanying PR in the other repo in the PR’s description.


Use bsgs_v4_gmp.py for multiple public key search

Dear Sir,
Have a nice day and hope you are well.
Thanks for your nice private key Search program; it is work as per the requirements. Could you please generate multiple public key search option at bsgs_v4_gmp.py. I have test with at bsgs_algo_modified_multi.py; it is slower to bsgs_v4_gmp.py as below command.
python3 bsgs_algo_modified_multi.py -n<PHONE_NUMBER>00000 -keyspace<PHONE_NUMBER>00000000000000000000:FFFFFFFFFFFFFFFFFFFFFFFFFFFFFF -rand
Kind Regards,
Md. Ashraful Alam

Thanks for trying.
Yes this is the plan. I will add this and will delete old versions script.


initial support for external redis and gcs ha

Why are these changes needed?
Initial support for GCS HA in kuberay.
Related issue number
#290
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[X] Manual tests
[ ] This PR is not tested :(

cc @iycheng @Jeffwan @scarlet25151

To be clear, does it work for 1.12.1?

To be clear, does it work for 1.12.1 or just nightly version?

Right now it is for nightly because @iycheng 's changes are only available in nightly build. It might be available later in 1.13 or later versions. This need confirmation from Yi Cheng's side.

@wilsonwang371 please help rebase the master. BTW, is it PR ready for review? I say [WIP] is still in the title?

To be clear, does it work for 1.12.1 or just nightly version?

Ray HA only works for Ray 1.13.0 and later versions.

The Redis 3.5.3 Python module is now in Ray nightly!

The Redis 3.5.3 Python module is now in the Ray nightly image!

I will make the necessary change

@wilsonwang371  we should also set this OS env https://github.com/ray-project/ray/blob/master/src/ray/common/ray_config_def.h#L617
With this two ray clusters will be able to share a common redis db. @brucez-anyscale suggest to use cluster id for this.

https://github.com/ray-project/ray/blob/master/src/ray/common/ray_config_def.h#L617

Is it RAY_external_storage_namespace environment variable?

@wilsonwang371  yes, it's an os environment.

@DmitriGekhtman for this.

@brucez-anyscale ,
@DmitriGekhtman for what? :)

To justify the complexity of the readiness probe and event handling, we should probably plan soon what kind of recovery logic we want to implement (besides deleting the head pod).

Are we good to merge this yet?

I think we can merge this and have followup prs to improve it

@DmitriGekhtman @brucez-anyscale waiting for a test fix. I am asking @wilsonwang371 to help fix it and then we can merge. It should be good by this noon

@iycheng it seems like external storage namespace has some issue. I temporarily disabled this, we may need to do some debug later on this.

@iycheng it seems like external storage namespace has some issue. I temporarily disabled this, we may need to do some debug later on this.

@iycheng @wilsonwang371 Let's follow up and solve it.

@iycheng it seems like external storage namespace has some issue. I temporarily disabled this, we may need to do some debug later on this.

@iycheng @wilsonwang371 Let's follow up and solve it.

I have posted a new MR. https://github.com/ray-project/kuberay/pull/406


fix: links to incorrect pull request when updating

closes #142
github api doc: https://developer.github.com/v3/pulls/#list-pull-requests

Thanks @sinchang great catch!


Move samples to x.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.04%. Comparing base (844d0da) to head (d99a5a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   92.04%   92.04%
=======================================
  Files          53       53
  Lines        3807     3807
  Branches      352      352
=======================================
  Hits         3504     3504
  Misses        302      302
  Partials        1        1

Flag
Coverage Δ

unittests
92.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding JFrog Distribution

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test

/assign
/lgtm

/assign

/retest

/lgtm


Adding new textured ball

Description
The PR aims to add the new textured ball for the new virtual competition.

moved to #284


Add FhirPath API

Purpose

This PR includes the changes for the FhirPath API
Related Issues: https://github.com/wso2-enterprise/open-healthcare/issues/931

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update workbook.rb

Add support to fill colors that are picked using theme colors.

As of now, fill colors chosen as indicated above are not detected by get_fill_color.

As I'm reading the code, the tinting functionality has been implemented since.


feat: [IDP-3253]: Added docs on account variable support in idp yaml

Added docs on account variable support in idp yaml
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://669695fc0dc8454ea74dbd8b--harness-developer.netlify.app


[Accordion Menu/Drilldown] Feature request/suggestions

I love the new menu system as a whole but would love to see a few enhancements to the accordion menu/drilldown menu for menus that have sub navigation to make it possible to click the sub-menu parent links - its the one thing stopping me using both of them.
Drilldown
I would love to see an option (data-options?) that added the parent menu link as a link (copy?) in the sub-menu, so that it was clickable.
Accordion Menu
Similar issue - it would be great if we could have an option to keep the link on the parent item and make the sub-menu toggle a separate element so that the parent link still works.
An example of what I mean is here. There's also a writeup about it here if that helps.
I'd love to discuss this further and any other ideas! Unfortunately my JS skills are very limited so I can't do much to help in that area yet :disappointed:

Wondered if this had ever been discussed at any point? (during planning for F6 or after release) I really wish I had the JS skills to write a PR! This would be a massive help for usability for me atleast (and I'm sure others too as they seem to be common patterns).

I am wondering that they dont have this feature for the drilldown/accordion menu in F6. They had in the old topbar menu since Foundation 4. This is the code from the topbar of F5:
    if (!$dropdown.find('.title.back').length) {
          $titleLi = $('

');

      // Copy link to subnav
      if (settings.custom_back_text == true) {
        $('h5>a', $titleLi).html(settings.back_text);
      } else {
        $('h5>a', $titleLi).html('« ' + $link.html());
      }
      $dropdown.prepend($titleLi);
    }

I agree with you this feature is very essential. I am working on a new project atm where i wanted to use F6s menu plugins for the navigation, but because this feature is missing I have to watch for another solution :(

Hmm. Good idea. For now, you could roll your own with Toggler.

Not a bad idea @andycochran, though I don't think it will particularly easy to do within WordPress (the context where I would be using it). I might explore this route if the Zurb team say this is a dead end though.

I had a quick play around with the toggler plugin on Codepen and made this: http://codepen.io/brettsmason/pen/BjmOoZ
Not usable, but shows what I'd love to achieve in one form or another. Unfortunately I have very little chance in writing the needed JS for a custom solution :disappointed: so having it as an option within the accordion menu would be a complete lifesaver.
As for the drilldown menu, I managed to get the parent link to display through a bit of messing with the drilldown.js code, but again I doubt I'd be able to create something usable without guidance.

I've having a look at the drilldown plugin (as that seems a slightly easier place to start) and have a working parentLink option. However The code isn't very good and probably all over the place!
First I added parentLink as an option:
    /**
     * Appends the parent link to the submenu.
     * @option
     * @example false
     */
    parentLink: false,

And edited the _prepareMenu function:
  Drilldown.prototype._prepareMenu = function(){
    var _this = this;
    // if(!this.options.holdOpen){
    //   this._menuLinkEvents();
    // }
    this.$submenuAnchors.each(function(){
      var $sub = $(this);
      var $link = $sub.find('a:first');
      $link.data('savedHref', $link.attr('href')).removeAttr('href');
      $sub.children('[data-submenu]')
          .attr({
            'aria-hidden': true,
            'tabindex': 0,
            'role': 'menu'
          });
      if(_this.options.parentLink){
        var $parentLink = $link.parent().clone();
        $parentLink.removeAttr('class');
        $parentLink.find('ul').remove();
        $sub.children('[data-submenu]').prepend($parentLink);
      }
      _this._events($sub);
    });
    this.$submenus.each(function(){
      var $menu = $(this),
          $back = $menu.find('.js-drilldown-back');
      if(!$back.length){
        $menu.prepend(_this.options.backButton);
      }
      _this._back($menu);
    });
    if(!this.$element.parent().hasClass('is-drilldown')){
      this.$wrapper = $(this.options.wrapper).addClass('is-drilldown').css(this._getMaxDims());
      this.$element.wrap(this.$wrapper);
    }

  };

As I said it works, but I know its all wrong. I would love to get working correctly so I can submit a PR, then maybe look at the accordion.
@zurbchris if you get a minute your advice/guidance on this would be great! :smile:

Hi - I'd just like to add my voice to this. I suggested the same thing on the foundation forum:
http://foundation.zurb.com/forum/posts/37851-musing-on-menus-for-mobile-f6sites
and Rafi Benkual referred me here. The example accordion menu that @brettsmason refers to is exactly what I am after and it would be great to have an accordion menu where parent or child could be selected. Unfortunately I doubt I could be much help in developing it from the technical standpoint, but I would certainly like to add my voice to say - yes, this is most definitely worth doing.

I have a UI enhancement suggestion for Drilldown. Instead of a single "back" link, why not an arrangement of small circular button links that represent menu layers?

@paxperscientiam Have you seen an example like this? Would love to know more.
In F5 it looked like

Drilldown has been merged and should make it into the next 6.2 rc.  Accordian is still outstanding.  @brettsmason do you want to take a look at that one too?

@kball The accordion menu seems a lot more complicated to make it work how I'd like (separate toggle and parent link still works) and I dont think I have the JS skills. I suppose one option, but not ideal, would be adding a similar option that I added to drilldown - prepend the parent link to the accordion submenu. Would like to hear thoughts on that though - as it adds an extra click.

@rafibomb That is close to what I had in mind, though I was thinking of something a bit more aesthetic. I will try to put together a simple mock-up and then report back here.

Here are two Examples with link to page and fold button in one menu line:
Accordion: http://www.dresden-central.de
Drilldown: https://www.ecointense.de
Would be nice to have this in Foundation Menus.

So I've worked out how to add a button that toggles the sub-menu and keep the parent link intact. However having difficulty working out the keyboard navigation changes needed. Can anyone offer any help with what I would need to change? Also any guidance on toggle styling - I'm thinking it should be very simple, but provide a decent sizes tap target.
@gakimball If I upload this somewhere/create a PR(?) would you and the Zurb guys be able to advise on style choices/keyboard navigation?

I've uploaded an early example here.
Any feedback/advice on styling would be appreciated! Now I need to work out the keyboard navigation stuff...

@brettsmason looking awesome!

@JeremyEnglert Thanks! I'd love to get this included I'm not sure where to go with the styling.
Any thoughts? I think the toggle needs to be separated some how visually from the parent link, but styling kept as minimal as possible.

I like the styling. The only other way I can see it being styled is without the border - but then it may not be clear that it is (essentially) a button.

Adding this feature, we'll also need to keep the functionality of menu items toggling sub-menus. So there needs to be visual distinction between when the menu item is a link or a sub-menu toggle.
In your example, covering up the link's arrow with a sub-menu toggle arrow makes sense if every menu item is a link. It'd be awkward to use both kinds in one menu, but both need to work.
Maybe the way to style "link + sub-menu toggle" is like split buttons. Not a border all the way around, but just a vertical line between the text and arrow.
And maybe the current (sans-link) sub-menu toggles should have their arrows inline with the text instead of shoved to the opposite side. That could help imply that the text triggers a dropdown instead of linking to something.
You'll also need to remove the ::after arrow on menu items that are links—which are currently showing through your transparent sub-menu toggle buttons.

Thanks @andycochran and @JeremyEnglert.
I agree that a split button approach might be the best way - this is what I originally had planned. However split buttons work because of the background colour - the accordion doesn't have this so I'm not sure how we could visually split it up. Any ideas?
I'm not sure how I feel about mixing an accordion menu, some with parent links and some without (that is what you mean right?). Surely you would only enable this feature if your menu had links on all parent items? The same applies for the drilldown menu - I wouldn't enable the parentLink feature on that unless I had links on all the parents. I'm happy to discuss this further though as I would rather do what the general opinion is happy with.
If we could all agree on the right way to progress this I'll crack on and try and get it finished :smile:
Also thanks for pointing out the ::after styling - it was only at base camp on styling at the moment so I could test it!

I was hoping to use the accordion plugin to handle a hierarchy browsing interface for an administrative backend, where each "row" was a whole series of content: title, template, status, edit button, delete button. The edit and delete buttons need to click through to their various actions, the title needs to click through to a display template and the row might need to reveal a sub-menu of child pages.
I wanted the disclosure triangle to be in left-aligned, in front of the item, rather than right-aligned.
Each "row" is a
 with a series of columns for the page attributes.
When I read "any  paired with a nested
..." were the conditions for triggering the accordion behavior, I tried this:

...

And made some CSS adjustments to absolutely position the disclosure-toggling a that the accordion plugin adds, and to add padding-left to the .row to give the triangle some room.
The blank a creates the disclosure triangle, and the subsequent a tags work as expected. Seems to work like a charm so far.
Now to see if I can get it to work with a hierarchy-savvy nestedSortable plugin to allow re-ordering by drag-n-drop...!

Is here something going on? I would hope to see the suggested split button approach in the next release cause we really want to use the accordion menu in our project. We know that having split buttons is not the best approach for every project so giving the user the control to activate/disable this feature via config would be really nice.
In my opinion the visual separation (css) doesn´t need to be part of the Foundation core. But Foundation should offer the functionality and the styling can be done by the user cause it depends on the project. For example: in my project I am using background colors for the accordion menu so it would be easy to seperate the toggle and the link visually on hover.

@Baedda I'm still working on adding the accordion menu with split button. However my priorities have had to shift a bit to help with bug fixes etc. I do have a working version with the split button approach though, I just need some help with the keyboard navigation changes to make it work fully.
@Owlbertz Do you mind giving me a bit of assistance in finishing this maybe later this week if you have time? I just need some guidance on what I need to change and the best approach etc!

@brettsmason Sure. For me end of the week (or even the weekend?) would fit best.

@Owlbertz No problem I'll try and sort out what I need to ask you in the next few days, but there's no rush at all, whenever you get a few minutes!

About drilldown.
Would be nice to have method, something like "_show",
to "drill" to level of menu with item marked ".active"
And show to user that level of menu.
Here's JsFiddle

The accordion menu plugin attaches the click event to the immediate li child anchors. You can keep the parent link clickable if you wrap it in a container and add another anchor tag to open the submenu.
Here is an example:

    I am clickable!
    And I open the submenu!

Item 1A

Item 1B

Item 2

I'd still love to get the accordion menu with seperate submenu buttons into 6.3, but I unfortunately dont have the JS knowledge to get it over the finish line. If anyone wants to assist let me know.

I'm still wondering if this should just be done with Toggler and live in a Building Block.

I wrote a little patch fo the accordion menu for my own purposes which offers an option whether the submenus should be closed or the parent link should be followed. See it here here..
What do you think?

Hmm. There's no way of knowing if the second click on the parent item will collapse its children or follow its link. There should be some type of feedback so the user know what will happen. And it would be nice to be able to follow the parent link without first uncollapsing its children.

I agree. There is this approach which is far better.

Here's the issue with visual cues… We basically need split buttons to work within a accordion menus. Split buttons work well because their clickable areas are visually distinct. But there are no visual cues that distinguish the clickable area of menu items. Imagine if an accordion menu was styled similar to a button group. Then it'd be easy to incorporate a split button into that group.
I'm once again, pointing out the overlap in menus and button groups. 😁

So there has been progress with this. A branch has been added on the Zurb repo so a few other contributors can assist ing etting it ready for 6.3. See here: https://github.com/zurb/foundation-sites/tree/accordion-submenu-toggle
There are 2 issues left - the keyboard navigation and a decision on how we style it.

Here is the quick fix I found.
  jQuery('.menu-item-has-children > a').click(function(){
    jQuery(this).unbind('click');
  });

This will allow the parent link to be clickable on the second attempt.
Details:
1st click - Open the accordion
2nd click  - Open the link
It is natural response for everyone to try clicking it second time, if the first attempt is not working.
Drawback:
User cannot close the accordion in which acceptable in my case

brettsmason commented on Mar 17, 2016
I've uploaded an early example here.
Any feedback/advice on styling would be appreciated! Now I need to work out the keyboard navigation stuff...

Brett on Mar17 has the best solution! Any progress on getting the sub-level-2 menu arrows to toggle?


Analytic table name ArrayIndexOutOfBoundsException

Called without a default parameter will result in
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 2
at org.apache.kylin.storage.hbase.util.DeployCoprocessorCLI.main(DeployCoprocessorCLI.java:118)
In 100 lines to determine if the first parameter of the command line is default, curIdx has ++, if the first parameter is not the default line 103, curIdx is re-++, resulting in the parameter misalignment.

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3111

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 23.956%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/DeployCoprocessorCLI.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

Totals

Change from base Build 3108:
0.03%

Covered Lines:
14357

Relevant Lines:
59931

💛  - Coveralls

Codecov Report

Merging #130 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master    #130      +/-   ##
===========================================
+ Coverage     21.88%   21.9%   +0.02%
- Complexity     3889    3896       +7
===========================================
  Files           994     994
  Lines         59931   59931
  Branches       8645    8645
===========================================
+ Hits          13115   13129      +14
+ Misses        45593   45576      -17
- Partials       1223    1226       +3

Impacted Files
Coverage Δ
Complexity Δ

...kylin/storage/hbase/util/DeployCoprocessorCLI.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

.../java/org/apache/kylin/common/KylinConfigBase.java
16.12% <0%> (+1.22%)
37% <0%> (+2%)
:arrow_up:

...rg/apache/kylin/storage/hbase/HBaseConnection.java
13.08% <0%> (+1.57%)
6% <0%> (+2%)
:arrow_up:

...main/java/org/apache/kylin/common/KylinConfig.java
32.35% <0%> (+1.68%)
21% <0%> (+1%)
:arrow_up:

...org/apache/kylin/rest/util/QueryRequestLimits.java
40.47% <0%> (+4.76%)
6% <0%> (+1%)
:arrow_up:

...e/kylin/common/KylinConfigCannotInitException.java
100% <0%> (+100%)
1% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7540cbd...1e8010b. Read the comment docs.

You're correct, thanks Gao Ping!


Choice prompts are disabled if there's a ~/.cookiecutterrc

Seems I don't get the nice prompts from https://github.com/audreyr/cookiecutter/pull/455 if I have a ~/.cookiecutterrc

Hi @ionelmc :wave:
It works on my machine running Mac OS X. I'll see if it works on my Win 7 and Ubuntu... :confused:
Which template are you using and what are the contents of your rc?
(testchoices)[raphael@hackebook choicekivy]$ cat ~/.cookiecutterrc
default_context:
    full_name: "Raphael Pierzina"
    email<EMAIL_ADDRESS>    github_username: "hackebrot"
abbreviations:
    cookiedozer: https://github.com/hackebrot/cookiedozer.git
    gh: https://github.com/{0}.git

(testchoices)[raphael@hackebook choicekivy]$ cookiecutter gh:hackebrot/cookiecutter-kivy
Cloning into 'cookiecutter-kivy'...
remote: Counting objects: 148, done.
remote: Total 148 (delta 0), reused 0 (delta 0), pack-reused 148
Receiving objects: 100% (148/148), 24.04 KiB | 0 bytes/s, done.
Resolving deltas: 100% (88/88), done.
Checking connectivity... done.
full_name [Raphael Pierzina]:
email<EMAIL_ADDRESS>
github_username [hackebrot]:
project_name [Kivy Project]:
repo_name [kivyproject]:
project_short_description [Cookiecutter template for applications built upon the kivy-framework.]:
release_date [2014-05-15]:
year [2014]:
version [0.1.0]:
minimum_kivy_version [1.8.0]:
Select orientation:
1 - all
2 - landscape
3 - portrait
Choose from 1, 2, 3 [1]: 4
Error: invalid choice: 4. (choose from 1, 2, 3)
Select orientation:
1 - all
2 - landscape
3 - portrait
Choose from 1, 2, 3 [1]: 2

(testchoices)[raphael@hackebook choicekivy]$

@hackebrot try adding orientation in your cookiecutterrc, the prompt will disappear then.

Yes, you are right. User config takes precedence over the context that is built from the template.
It works if you have a list in ~/.cookiecutterrc though.
Hmmmm :no_mouth:

Is that "Hmmmm :no_mouth:" short for "hard to fix, lots of painful refactoring"? :grin:

Nope! :joy_cat:
There is not "hard to fix, lots of painful refactoring" on Cookiecutter.
I'm on it.

Please review #542, thanks :bow:


1.19.4?

Could you possibly port this to 1.19.4?

Done (that wasn't too hard).

Oh my goodness thank you so much


Develop

feat: support REF wrapped in ${}

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #3   +/-   ##
=======================================
  Coverage       100%   100%
- Complexity       23     28    +5
=======================================
  Files             2      2
  Lines            43     48    +5
=======================================
+ Hits             43     48    +5

Impacted Files
Coverage Δ
Complexity Δ

src/Loader.php
100% <100%> (ø)
19 <6> (+5)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7741f...995f6ae. Read the comment docs.


Added a function to sandbox which multiplies a number by eight

Final step of software onboarding process.

[X] Passes unit test
[X] Has a unit test
[X] Adheares to code style and formatting

This change is

@wendi-yu Changes have been implemented.


License

It would be great if a license could be added to this repository.

Hi there, thanks for your interest. I added the MIT license. Best, Jérémy


Actual: Markwon sometimes skips image loading on scrolling.
The issue manifests itself in following conditions:

Have a RecyclerView with lots of items
Have TextView with markdown content and images in all of them
Wait for first image to get loaded

It's quite weird bug, but I noticed that when first item image gets loaded, the second RecyclerView item gets hidden below the bottom, i.e. it's not visible anymore as first item is now expanded because of image.
Then RecyclerView tries to hide it. Reasonable, because it's not visible anymore, right? Unfortunately this stops async drawable loading and never restarts it again.
Carefully set up conditional breakpoints network gave me this stacktrace, so you can see why it happens:
	  at java.lang.Thread.interrupt(Thread.java:949)
	  at java.util.concurrent.FutureTask.cancel(FutureTask.java:146)
	  at ru.noties.markwon.image.AsyncDrawableLoaderImpl.cancel(AsyncDrawableLoaderImpl.java:51)
	  at ru.noties.markwon.image.AsyncDrawable.setCallback2(AsyncDrawable.java:94)
	  at ru.noties.markwon.image.AsyncDrawableScheduler.unschedule(AsyncDrawableScheduler.java:53)
	  at ru.noties.markwon.image.AsyncDrawableScheduler$1.onViewDetachedFromWindow(AsyncDrawableScheduler.java:35)
	  at android.view.View.dispatchDetachedFromWindow(View.java:15463)
	  at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3216)
	  at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3216)
	  at android.view.ViewGroup.removeDetachedView(ViewGroup.java:5006)
	  at androidx.recyclerview.widget.RecyclerView.removeDetachedView(RecyclerView.java:4206)
	  at androidx.recyclerview.widget.RecyclerView$LayoutManager.removeAndRecycleScrapInt(RecyclerView.java:9066)
	  at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4063)
	  at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:3718)
	  at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4260)
	  at android.view.View.layout(View.java:17523)

So the image loading gets interrupted.
The obvious fix for me seems to be in adding schedule(textView) into AsyncDrawableScheduler -> schedule -> listener -> onViewAttachedToWindow.
For now I workaround this by adding another OnAttachStateChangeListener to my text view with AsyncDrawableScheduler.schedule(label).

Hello @Adonai !
This is an interesting problem. As you correctly noticed AsyncDrawableScheduler adds an OnAttachStateChangedListener for all AsyncDrawableSpans. This is done to cancel ongoing requests when a TextView is no longer attached to a window. And this works good when TextView is in a regular layout. Things change when a TextView is in RecyclerView. Because RecyclerView recycles views, so they go through attach/detach events multiple times. And AsyncDrawableScheduler listens for detach events to release span from referencing by removing callbacks (in order to prevent memory leaks), but do not listen for subsequent attach events. So, once a TextView is recycled (aka detached) it won't be able to invalidate an AsyncDrawableSpan, even if it would be attached again at some point in future.
As a work-around, AsyncDrawableScheduler indeed can listen for subsequent attach events. I think it's relatively safe to do so (not 100% sure though, I think we better run some tests to validate that this won't cause memory leaks or break current implementation).
Also, are you using recycler artifact? It short -> it splits resulting Document into independent nodes and renders each in an individual TextView. As it applies markdown on each onBindViewHolder, image loading is still triggered. It still cancels loading when a TextView is detached, but at least resumes the loading when TextView becomes attached again. I'm not saying you should jump into using this artifact, but maybe inspect it for implementation details that could help you with your use-case. There is also a simple sample application if you wish to know how to use it. And do not forget the documentation that also has some explanations.

No, I'm not using recycler. I'll give it a try, I think, but in my application there are "spoiler" spans which unwrap more text (and spans) on click and I'm not sure multi-textview recycler can handle this.
I should say that workaround with scheduling on attach works pretty well for my purposes. I'll post here if I find any bugs.

I'm going to close it now, but feel free to reopen it if you find anything else