Configuration via Environment Variables

The Terraform provider expects nested configuration or environment variables.
However, setting environment variables does not work and we get a configuration error from the Terraform provider (https://github.com/bpg/terraform-provider-proxmox/blob/main/proxmoxtf/provider.go#L210).
Hence, we need to work-around like this:
const provider = new proxmox.Provider('proxmoxve', {
  virtualEnvironment: {
    endpoint: process.env.PROXMOX_VE_ENDPOINT,
    insecure: process.env.PROXMOX_VE_INSECURE,
    username: process.env.PROXMOX_VE_USERNAME,
    password: process.env.PROXMOX_VE_PASSWORD
  }
});

It would be great if we can pass through environment variables configuration to the provider.

Hi @muhlba91 -
Pulumi resource providers are run as plugins on your local system, so any environment variables set on your system are usually available to your provider.
How did you try setting the nested environment variables, and what behavior did you expect? It may well be that this is not currently supported, but I want to make sure I fully understand :)

Hi @guineveresaenger,
thanks for getting back to me here. Let me give you a short overview of my assumptions and tries so far. :)
First, the terraform provider defines it's configuration schema here: https://github.com/bpg/terraform-provider-proxmox/blob/main/proxmoxtf/provider.go#L71 - as you can see it generates a nested schema with - for example - those environment variables:

PROXMOX_VE_ENDPOINT
PROXMOX_VE_INSECURE
PROXMOX_VE_PASSWORD
PROXMOX_VE_USERNAME

Those I define in my environment variables like:
export PROXMOX_VE_USERNAME="root@pam"
export PROXMOX_VE_PASSWORD="<password>"
export PROXMOX_VE_ENDPOINT="https://<ip_address>:8006/"
export PROXMOX_VE_INSECURE="true"

Based on the schema generated by the terraform bridge, the configuration is picked up correctly.
See https://github.com/muhlba91/pulumi-proxmoxve/blob/main/provider/cmd/pulumi-resource-proxmoxve/schema.json#L1474 for the nesting, and https://github.com/muhlba91/pulumi-proxmoxve/blob/main/provider/cmd/pulumi-resource-proxmoxve/schema.json#L1395 for the nested schema.
If I now execute Pulumi using this provider, I receive error: You must specify the virtual environment details in the provider configuration (defined here: https://github.com/bpg/terraform-provider-proxmox/blob/main/proxmoxtf/provider.go#L210).
Hence, my conclusion that the environment variables are not passed through to the provider configuration properly. To me it looks like the nested configuration for the provider is initialised (empty) and passed, leading to the terraform provider not calling the initialisation functions (default functions for each variable).
Then I thought I can simply define the configuration in the resources.go file like:
Config: map[string]*tfbridge.SchemaInfo{
			"virtualEnvironment": {
				Type: makeType("virtualEnvironment", "VirtualEnvironment"),
				Elem: &tfbridge.SchemaInfo{
					Fields: map[string]*tfbridge.SchemaInfo{
						"endpoint": &tfbridge.SchemaInfo{
							Type: makeType("endpoint", "Endpoint"),
							Default: &tfbridge.DefaultInfo{
								EnvVars: []string{"PROXMOX_VE_ENDPOINT", "PM_VE_ENDPOINT"},
							},
						},
						"insecure": &tfbridge.SchemaInfo{
							Type: makeType("insecure", "Insecure"),
							Default: &tfbridge.DefaultInfo{
								EnvVars: []string{"PROXMOX_VE_INSECURE", "PM_VE_INSECURE"},
							},
						},
						"otp": &tfbridge.SchemaInfo{
							Type: makeType("otp", "OTP"),
							Default: &tfbridge.DefaultInfo{
								EnvVars: []string{"PROXMOX_VE_OTP", "PM_VE_OTP"},
							},
						},
						"password": &tfbridge.SchemaInfo{
							Type: makeType("password", "Password"),
							Default: &tfbridge.DefaultInfo{
								EnvVars: []string{"PROXMOX_VE_PASSWORD", "PM_VE_PASSWORD"},
							},
						},
						"username": &tfbridge.SchemaInfo{
							Type: makeType("username", "Username"),
							Default: &tfbridge.DefaultInfo{
								EnvVars: []string{"PROXMOX_VE_USERNAME", "PM_VE_USERNAME"},
							},
						},
					},
				},
			},
		},

Apart from the fact that I would expect it to work without such addition, I think I did something wrong here since I receive the following error when using the plugin now error: could not load plugin for proxmoxve provider 'urn:pulumi:dev::pve-test::pulumi:providers:proxmoxve::default_0_0_1_alpha_1637516154_bcc93c62_dirty': could not read plugin [/Users/daniel/go/bin/pulumi-resource-proxmoxve] stdout: EOF.

@guineveresaenger bumping this thread for support.

Hi again - apologies for the long delay.
To the best of my knowledge, our tooling does not have this capacity at this point, since every provider is ever so slightly different and may expect different settings/nesting.
We recommend the following:

Continue with the workaround as listed in your README.
File an issue in the pulumi-terraform bridge  so that we can triage and track this issue properly at the source and see if it's feasible.
As with anything, we of course welcome pull requests and you may find a fair bit of assistance on our community slack from other community members as well.

Moved to https://github.com/pulumi/pulumi-terraform-bridge/issues/423.


Option to avoid the R__ checksum check

For reasons, we're looking to schemachange to run batch SQL scripts, because, well, snowflake wont. We have a team used to writing multiple SQL statements in one script which would normally hit a stored proc, but, well, you know the rest.
I've wrapped a CLI app around this and its working pretty well, but we're looking to trigger R__ scripts (as alternatives to multi-statement stored procs) via lamda, and the checksum test quite rightly skips R__ scripts it thinks match the last time it ran.
If I submitted a PR with --no-checksum-check would you accept it?

Hi there @shaundodimead, thanks for raising the issue. snowchange already supports the use-case you're describing, with the "A"lways scripts (A__ scripts). Please see the schemachange documentation for more details.

Yup that is exactly what I need, I even read over that bit of the docs. It was late... !


MC 1.20.2 Support (v1_20_R2)

Please add support for v1_20_R2.

https://github.com/hakan-krgn/hCore/releases/tag/<IP_ADDRESS>


Tesseract 4 migration

After hours it is finally working!!!
I will send you by mail (in the one in your profile) an example of the result with base 64 for open-ocr v1 and v2

Thanks for the contribution @gmuselli

YW :) thanks to you


Consider making pyopencl an optional dependency.

This plugin is really useful for simple lazy loading of tiff series, (without the deskewing for LLS files). I'd like to include it with cellfinder so users can easily view their raw data along with results.
However, pyopencl seems to have issues on Windows, and I'd rather not introduce potentialpyopencl build issues when it's not required for my purpose (and napari-nftiffs can fall back to scipy if needed).
It would be great if napari-ndtiffs could make pyopencl optional (e.g. pip install napari-ndtiffs[opencl]). If you want to keep pyopencl as a requirement, no worries, I can release a fork without the requirement.
Thanks!

Fine with me!  Would you be able to submit a PR adding the opencl extra?

No problem, I'll do it tomorrow.

thanks!  while we're chatting.  Feel free to make any other suggestions that you think would make this more general purpose.  One I've (passively) planned on eventually implementing was a way to accept some sort of filename pattern template that would let the user more easily parse arbitrary filename patterns (e.g. to extract the various axes of the dataset).  Generally curious to hear how you've been using it...

So for now, I've just been using it so I didn't have to make my own plugin for lazy loading.
I'm making a plugin to visualise cellfinder results (detected cell positions, brain region segmentation borders). Typically users will have their raw data (100-1000GB) and their processed data (100MB-10GB) in different places. It makes more sense for them to load the raw data using this plugin, then load the analysis results separately, so I don't have to do anything clever with file links etc.
For this specific purpose, we don't need anything clever with filename patterns. There are no timepoints, just very big structural images. Recursive loading of sub-directories (each with a separate channel) could be useful though.

Added in #2

thanks again @adamltyson.  I released v0.1.1 on PyPI with your updates.


[MAINT, MRG] Fix read-only error

This just fixes a read-only view file error.

Okay, now this should be good to go. For whatever reason, upon upgrading their OS, the GUI code didn't work for a collaborator and it said cannot assign to read-only destination. Maybe they had an old version of numpy, not sure but this fixes it now.

Thanks @alexrockhill


Bug between BES and HR-monitor!

Many unnecessary Requests are sent between the BES and HR-monitor, send Request to BES even if the data are already sent before.

Done!


Update : Quantum MCWF method and QuDynamics.

Update on Monte-Carlo Wave Function method.

Oh sorry the example got mixed up ! Send in the commit changes soon !

@acroy done with the changes ! Hope this is ready.

Sorry, I obviously forgot to merge this PR.


Improve affiliation normalization

An author might have several affiliations and raw affiliations, but currently we assign all affiliations of the author based on a single raw affiliation. This might cause "phantom" affiliations to be added, coming from the other affiliations of the matched author that have nothing to do with the raw affiliation in question. For example, in https://inspirebeta.net/api/literature/1985763, the third author has among its raw affiliations

Helmholtz Forschungsakademie Hessen für FAIR (HFHF), GSI Helmholtzzentrum für Schwerionenforschung, Campus Frankfurt, Max-von-Laue-Str. 12, 60438 Frankfurt, Germany

which gets mapped to
[{u'record': {u'$ref': u'https://inspirebeta.net/api/institutions/902780'},
  u'value': u'Dubna, JINR'},
 {u'record': {u'$ref': u'https://inspirebeta.net/api/institutions/1850857'},
  u'value': u'Helmholtz Res. Acad. Hesse for FAIR'},
 {u'record': {u'$ref': u'https://inspirebeta.net/api/institutions/903807'},
  u'value': u'Darmstadt, GSI'}]

of these, only the second one is correct.
We can improve the current situation by counting raw_affiliations and affiliations in the matched literature record. There are two clear situations:

len(raw_affiliations) == len(affiliations): we can assume that a single raw affiliation maps to a single affiliation in the same order, and assign that affiliation only
len(raw_affiliations) == 1: we can assume, as we do currently, that all affiliations correspond to that single raw affiliation, and assign all of them.

In other cases, it's ambiguous and we should avoid assigning the affiliation based on this match, and use the next match instead.

TECH
In here add the check if len(raw_affiliations) == len(affiliations) or len(raw_affiliations) == 1 and assign affiliations only in that case.

I have no idea how the aff normalization works in detail. From my naive perspective it would be interesting to understand why this happens. By this heuristic approach you might remove some good matches and nevertheless some bad matches slip through.

Sorry, I hadn't reviewed the PR and I realize right now that the implementation is not correct, so I'm reopening it for next sprint.

Instead of looking at number of affs and raw affs of the matched author, it looks at the current author after matching, which is not the same thing.
It doesn't take the next match if the current match doesn't satisfy the criteria, but instead doesn't assign affiliations at all.


Seg fault when running decompile.sh

Running OpenSuse Tumbleweed.
decompile.sh is in /retdec/bin/
cmake .. -DCMAKE_INSTALL_PREFIX=<path>
make && make install
Installed without issues
But when running decompile.sh on a hello world C program
Running phase: Initialization ( 0.00s )
Running phase: LLVM ( 0.01s )
Running phase: Providers initialization ( 0.01s )
Running phase: Input binary to LLVM IR decoding ( 0.88s )
Running phase: Assembly instruction optimization ( 0.95s )
Running phase: LLVM ( 0.95s )
Running phase: (Un)Volatilize optimization ( 0.95s )
Running phase: LLVM ( 0.95s )
Running phase: (Un)Volatilize optimization ( 0.95s )
Running phase: Control flow optimization ( 0.95s )
Running phase: Control flow function detection optimization ( 0.96s )
Running phase: Main function identification optimization ( 0.96s )
Running phase: Assembly register optimization ( 0.96s )
Running phase: Stack optimization ( 0.96s )
Running phase: Control flow optimization ( 0.97s )
Running phase: Conditional branch optimization ( 0.97s )
Running phase: Syscalls optimization ( 0.97s )
Running phase: Libgcc idioms optimization ( 0.97s )
Running phase: Constants optimization ( 0.97s )
Running phase: Function parameters and returns optimization ( 0.98s )
Running phase: Register localization optimization ( 0.98s )
Running phase: Data type conversions optimization ( 0.98s )
Running phase: Simple types recovery optimization ( 0.98s )
Running phase: Disassembly generation ( 0.99s )
Running phase: Assembly mapping instruction removal ( 0.99s )
Running phase: Selected functions optimization ( 0.99s )
Running phase: Unreachable functions optimization ( 0.99s )
Running phase: Data type conversions optimization ( 0.99s )
Running phase: Stack protection optimization ( 0.99s )
Running phase: LLVM ( 0.99s )
Running phase: Never-returning-functions optimization ( 1.01s )
Running phase: C++ adapter methods optimization ( 1.01s )
Running phase: C++ class hierarchy optimization ( 1.01s )
Running phase: LLVM ( 1.02s )
Running phase: Simple types recovery optimization ( 1.03s )
Running phase: Stack pointer operations optimization ( 1.03s )
Running phase: Data type conversions optimization ( 1.04s )
Running phase: Instruction idioms optimization ( 1.04s )
Running phase: LLVM ( 1.04s )
Running phase: Global to local optimization ( 1.04s )
./decompile.sh: line 900: 15396 Segmentation fault      (core dumped) $BIN2LLVMIR "${BIN2LLVMIR_PARAMS[@]}" -o "$OUT_BACKEND_BC"
Error: Decompilation to LLVM IR failed

Edit: I doubt it is of any significance but when I submit the hello world program to the online decompiler it is successful.

Thank you for the report. Could you please provide the input binary file so we can investigate this? Also, can you please specify what Linux distribution and GCC version do you use?

Hi,
I was having the same issue but I have sorted out. My problem was I passed LTO (Link Time Optimization) parameters to the compiler which shouldn't be a problem for many programs, and after removing the related flags, the problem was solved.

@RyanWarnock Could you please try the following?

Ensure that you do not pass any additional variables to the RetDec build, as suggested above.
Try removing the build directory and try to re-build and install RetDec from scratch.

I believe that the problem you have reported is a result of an incorrect build.

After doing what liushuyu and s3rvac suggested everything now works. Thank you both for your time.
@s3rvac If you still want the details you asked for previously let me know, otherwise all is well!

Great! I am glad you got it working.


gh-99 added the remaining BotAPI Object Methods

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] I have included in this PR's description the statement closes #xx or fixes #xx where #xx is the number of the issue being addressed.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This pull request fixes a bug / feature in the autobot/telegram/api.y and **autobot/telegram/objetcs/forumtopic.py** files

What is the current behavior? (You can also link to an open issue here)
The Bot API Object was missing some methods, and the ForumTopic Module missed the ForumTopic Object

What is the new behavior (if this is a feature change)?
All the missing objects and methods have been added in autobot/telegram/objects/forumtopic.py and  autobot/telegram/api.py respectively

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This pull request might change Object tests

Other information:
This PR associated with gh-99

@ht-thomas hope this pushes us somewhere.

@ushergodwin you can go ahead and merge if this PR is correct. I cannot review correctly at this point


Arecord error when try execute the script

I try to run script on brand new os installation (pi 4) with anker s330 but get always same error
arecord: main:831: audio open error: No such file or directory
have no trouble to play sound for example with this command: aplay /usr/share/sounds/alsa/Front_Cen er.wav
Any idea how can i solve it?

Solved by adding --mic-device plughw:CARD=S330,DEV=0 --snd-device plughw:CARD=S330


Chapters: merge with ChaptersApp JSON

Let's work with @bjoreman to integrate the ChaptersApp JSON format.  Maybe a good place to start would be to figure out what to do with "startTime" vs "startMs".

Posted over on #55 before I noticed this issue existing:
I'm all for adjusting the format used to what we arrive at here.
For context, my thinking for the property name and unit is that it minimizes the risk of misunderstanding (not least by myself) to have the unit used right in the name, and it feels good to have a unit not in need of the fraction side of the world. Floats always seem to bite me, sooner or later :-) …

includeInTableOfContents, if we decide to include that, is definitely open for renaming as well :-) …
The name pretty much only makes sense from the viewpoint of the ID3 chapter standard's internals, and I mostly picked it because it makes the true/false state match what's written inside the ID3 tag.

I'm going to write up a rough draft to give us something to hack on.

Internally dealing with floats is painful, but providing an integer for ms gets verbose fast. We just dealt with this in transcripts as well. I would suggest startSeconds. This allows the value to be 35 vs 35000 but still leaves freedom for 25.123 vs 25123 for chapter markers that are captured in ms. I don't feel that strongly, but wanted to put this out there. Keep in mind that we already use seconds for duration as well as timestamps for transcripts.

This is good info Tom.
@bjoreman, do you have a problem with this change?
"startMs" (milliseconds) being changed to "startSeconds" (float) containing the time as seconds if just a whole number, or milliseconds if given as a decimal.

I don’t have a very strong opinion either, if there are other places seconds are already used I guess it makes sense.

26 okt. 2020 kl. 14:41 skrev Dave Jones<EMAIL_ADDRESS>This is good info Tom.
@bjoreman https://github.com/bjoreman, do you have a problem with this change?
"startMs" (milliseconds) being changed to "startSeconds" (float) containing the time as seconds if just a whole number, or milliseconds if given as a decimal.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Podcastindex-org/podcast-namespace/issues/91#issuecomment-716553303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOU3MWEJBTN7L366MRQDTSMV4BDANCNFSM4S6QWKVA.

Ok, I kept startTime as the name since it already matches what's in transcripts.  Look at the new draft document here and let me know what yall think.
@bjoreman I think the way it's written it would be three changes on your side:  the time format/name, changing the table of contents property name to toc and changing hasArtwork to be the name of the file rather than a boolean, to allow for it to be used even if no chapter id string is present.
On our side, we can now use the relative artwork links for more complexity if wanted.

Please, let's move away from title being required!
That would

enable showing multiple images within the same chapter.
Mean we have no use for the toc, since not providing a title would mean you do not want it in the ToC.

also if id is optional, I am not sure I see the great value in it?

Not requiring a title makes sense to me, but I think that should be separate from denoting if we want the chapter hidden/in the ToC or not. In part because it’s nice to be explicit, but mainly because this is supported by the ID3 chapters standard and thus presently handled by chapter-supporting podcast apps.

26 okt. 2020 kl. 18:20 skrev Martin Mouritzen<EMAIL_ADDRESS>Please, let's move away from title being required!
That would
enable showing multiple images within the same chapter.
Mean we have no use for the toc, since not providing a title would mean you do not want it in the ToC.
also if id is optional, I am not sure I see the great value in it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Podcastindex-org/podcast-namespace/issues/91#issuecomment-716700939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOU3JPYZ5MMVFB7TFL2OTSMWVVVANCNFSM4S6QWKVA.

Sounds sensible to me.
Unless there are additional reasons to keep it, I think I’m in favor of dropping hasArtwork altogether. It was the most convenient way of doing things for Podcast Chapter’s particular use case, but if that’s the only motivation I don’t think that should be preserved in a standard.

26 okt. 2020 kl. 18:12 skrev Dave Jones<EMAIL_ADDRESS>Ok, I kept startTime as the name since it already matches what's in transcripts. Look at the new draft document here x-msg://4/chapters/jsonChapters.md and let me know what yall think.
@bjoreman https://github.com/bjoreman I think the way it's written it would be three changes on your side: the time format/name, changing the table of contents property name to toc and changing hasArtwork to be the name of the file rather than a boolean, to allow for it to be used even if no chapter id string is present.
On our side, we can now use the relative artwork links for more complexity if wanted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Podcastindex-org/podcast-namespace/issues/91#issuecomment-716695950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOU3IA3IVSABOK5U6ZQYLSMWUYXANCNFSM4S6QWKVA.

Are you thinking you would just use "img" instead and write the image name as a relative url?

That was my thought, yes. But perhaps that won’t improve anything? I freely admit to still being a bit stuck in the viewpoint of my app’s original use case 🤔☺.

26 okt. 2020 kl. 22:23 skrev Dave Jones<EMAIL_ADDRESS>
Are you thinking you would just use "img" instead and write the image name as a relative url?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

It does make sense that way.  If the img is ch1.img it should work fine in the embedded player.  And if it's a FQDN it would work externally too.  Seems to simplify things.  And, hasArtwork is implicit in having the img there or not.
Ok, about to post a new version for review.

title also optional now.  But encouraged for clarity.

@tomrossi7 Is this looking like something that would be workable for you guys?  Want to make sure it won't break what you're working on.  I don't think it will from what I see.

I don't see any technical issues with this. What do you think @snookfin?

Good suggestions all around. I think this will work nicely.

@bjoreman Are you good with this as a version 1.1 format for the initial release?  I think the code change you'll have to make should be fairly minor.

Yes, sounds good to me!
Vänliga hälsningar,
Fredrik Björeman

28 okt. 2020 kl. 20:56 skrev Dave Jones<EMAIL_ADDRESS>
@bjoreman Are you good with this as a version 1.1 format for the initial release? I think the code change you'll have to make should be fairly minor.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Success:  https://apps.apple.com/us/app/podcast-chapters/id1070963477?mt=12&ign-mpt=uo%3D4
Thanks @bjoreman !!


Animation direction

Is there a way for animation to be set from 0 to the progress level or vice-versa?

I have the same issue. The animation starts half full to the requested value. But it should start from 0.


allow param to value for transition-property

CLA is valid!

Coverage remained the same at 100.0% when pulling be72389ec2af1a521d2305f77ab2c811dabef6c7 on transition-property into 1ca4175d08dc8d03822d14c6e50e63dcf0673b5a on master.

Coverage remained the same at 100.0% when pulling be72389ec2af1a521d2305f77ab2c811dabef6c7 on transition-property into 1ca4175d08dc8d03822d14c6e50e63dcf0673b5a on master.

:+1: yes please!


Problem with HypreBoomerAMG

Hi,
I cam calling HypreBoomerAMG for solving the equation,
where the right hand side is given by:
HypreParVector trueRhs_g(blocks(0,0)->GetComm(), blocks(0,0)->GetGlobalNumRows(),
                               trueRhs.GetBlock(0).GetData(), blocks(0,0)->GetColStarts());

and the matrix is the following:
      HypreParVector r1=trueRhs_g, r2=trueRhs_g;
      r1=0;
      r2=0;
      HypreBoomerAMG A_inv(*blocks(0,0));
      A_inv.SetTol(1e-7);
      A_inv.Mult(trueRhs_g, r1);

I got the following running information:

Num MPI tasks = 4

 Num OpenMP threads = 1

BoomerAMG SETUP PARAMETERS:

 Max levels = 25
 Num levels = 1

 Strength Threshold = 0.250000
 Interpolation Truncation Factor = 0.000000
 Maximum Row Sum Threshold for Dependency Weakening = 0.900000

 Coarsening Type = HMIS

 No. of levels of aggressive coarsening: 1

 Interpolation on agg. levels= multipass interpolation
 measures are determined locally

 No global partition option chosen.

 Interpolation = extended+i interpolation

Operator Matrix Information:

             nonzero            entries/row          row sums
lev    rows  entries sparse   min  max     avg      min         max
======================================================================
  0     729     9097  0.017     4   17    12.5   8.138e-05   2.279e-03

Interpolation Matrix Information:
                    entries/row        min        max            row sums
lev  rows x cols  min  max  avgW     weight      weight       min         max
================================================================================

     Complexity:    grid = 1.000000
                operator = 1.000000
                memory = 1.000000

BoomerAMG SOLVER PARAMETERS:

  Maximum number of cycles:         1
  Stopping Tolerance:               1.000000e-07
  Cycle type (1 = V, 2 = W, etc.):  1

  Relaxation Parameters:
   Visiting Grid:                     down   up  coarse
            Number of sweeps:            1    1     1
   Type 0=Jac, 3=hGS, 6=hSGS, 9=GE:      8    8     8
   Point types, partial sweeps (1=C, -1=F):
                  Pre-CG relaxation (down):   0
                   Post-CG relaxation (up):   0
                             Coarsest grid:   0

but also I got the error message:

Verification failed: (!err_flag) is false:
 --> Error during solve! Error code: 256
 ... in function: virtual void mfem::HypreSolver::Mult(const mfem::HypreParVector&, mfem::HypreParVector&) const
 ... in file: linalg/hypre.cpp:3660

Can anyone have some ideas on fixing memory issue?  Many thanks.

You probably want to wrap AMG as a preconditioner into a Krylov method as PCG or GMRES, see Example 1p.


Deserializing a Map fails with DeserializeUnexpectedEnd

I don't know if "I'm holding it wrong" or anything, but I can't deserialize a map with postcard. The error is DeserializeUnexpectedEnd, which does not really give me a clue on what the problem is.
Minimal example:
use heapless::LinearMap;
use postcard::{from_bytes, to_vec};

fn main() {
    let mut map: LinearMap<&str, &[u8], 4> = LinearMap::new();
    map.insert("a", b"asdf").unwrap();
    map.insert("b", b"as1df").unwrap();
    map.insert("c", b"as2df").unwrap();

    println!("map: {map:?}");

    let m: heapless::Vec<u8, 64> = to_vec(&map).unwrap();
    println!("m: {m:?}");

    let m2: (LinearMap<&str, &[u8], 4>, usize) = from_bytes(&m).unwrap();
    println!("m2: {m2:?}");
}

Output:
> cargo run
   Compiling serde-test v0.1.0 (/tmp/serde-test)
    Finished dev [unoptimized + debuginfo] target(s) in 0.38s
     Running `target/debug/serde-test`
map: {"a": [97, 115, 100, 102], "b": [97, 115, 49, 100, 102], "c": [97, 115, 50, 100, 102]}
m: [3, 1, 97, 4, 97, 115, 100, 102, 1, 98, 5, 97, 115, 49, 100, 102, 1, 99, 5, 97, 115, 50, 100, 102]
thread 'main' panicked at src/main.rs:15:65:
called `Result::unwrap()` on an `Err` value: DeserializeUnexpectedEnd
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Cargo.toml:
[package]
name = "serde-test"
version = "0.1.0"
edition = "2021"

[dependencies]
heapless = { version = "0.7", features = ["serde"] }
postcard = "1.0.8"
serde = { version = "1.0.*", default-features = false }

Ok, apparently the error is, that a trailing 0 in the vector m is missing. The above example works if m.push(0).unwrap(); is added before the from_bytes(&m).

That shouldn't fail anyway. The library shouldn't need a 0 to be added on a map by the developer.

Opening this to take a look at it

The issue was in @jounathaen's code:
This line:
let m2: (LinearMap<&str, &[u8], 4>, usize) = from_bytes(&m).unwrap();

Should have been
let m2: LinearMap<&str, &[u8], 4> = from_bytes(&m).unwrap();

The signature for from_bytes is fn from_bytes<'a, T>(s: &'a [u8]) -> Result<T>, meaning that postcard was trying to deserialize the type (LinearMap<&str, &[u8], 4>, usize), however deserializing the LinearMap<&str, &[u8], 4> consumed all bytes, meaning that when then trying to deserialize the additional usize, that there were no bytes remaining to be taken.
With this fixed, I get the correct output:
map: {"a": [97, 115, 100, 102], "b": [97, 115, 49, 100, 102], "c": [97, 115, 50, 100, 102]}
m: [3, 1, 97, 4, 97, 115, 100, 102, 1, 98, 5, 97, 115, 49, 100, 102, 1, 99, 5, 97, 115, 50, 100, 102]
m2: {"a": [97, 115, 100, 102], "b": [97, 115, 49, 100, 102], "c": [97, 115, 50, 100, 102]}


Slack Integration - Variable Substitution of Pre-canned Trigger Examples Does Not Appear to Fully Work

When creating triggers that alert in to Slack, the pre-canned example does not seem to produce meaningful output.
Here is the out seen in Slack:

Here is the default event definition for a network update event:

Here is the trigger/event info:

Looking at this, it looks like the correct event variables just need to be used. The pre-canned trigger definitions look like they just need updating.
This definition worked well for a network config update:
The configuration of the network "{{Ssid}}" was updated at location: {{Location_Name}} (Update made at by {{Username}})

Can we keep similar issues together, easier to track. Going to close and keep in this one: https://github.com/cucumber-tony/cucumber-frontend/issues/49
Referencing so we don't miss these.


MINOR: Fix wrong import control declaration

More detailed description of your change
IntegrationTestHelper is not right.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mumrah ,Hello, PTAL.

Also, #10126 is opened to fix this issue.

Thank you @kamalcph , Will close and review #10126


pci-pci brige header

I added some minimal code to handle enumerating pci bridges, and also made the header enum a real enum

Thanks for the contribution!


TestEdsCache is flaky

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/37722/unit-tests_istio/1499786654670393344/build-log.txt

@howardjohn could this be related to push context change? I am seeing this since two days?

Probably so, need to look into it

I don't think it is, I can reproduce with and without it

1.13: 1053 runs so far, 0 failures (100.00% pass rate). 4.69240598s avg, 6.792750143s max, 1.860541828s min
master: 522 runs so far, 2 failures (99.62% pass rate). 4.825105477s avg, 10.393853101s max, 2.02398546s min

Some findings is in master the update is a full push but in 1.13 its a incremental push. IDK why this results in the bug though. I think the diff occurs when we reflect.DeepEquals the services, but its unclear why right now. related to auto alloc

cc @hzxuzhonghu

// to make sure the eds update run in serial to prevent stale ones can override new ones
// There are multiple threads calling edsUpdate.
// If all share one lock, then all the threads can have an obvious performance downgrade.
edsQueue queue.Instance


[4.3] RenderingDevice split caused TextureArray Mipmap rendering artifact

Tested versions
Bisecting reveals:

First caused by https://github.com/godotengine/godot/pull/83452
Improved by https://github.com/godotengine/godot/pull/86855
Still present in Godot 4.3-dev5
Not present in Godot 4.2.2

System information
Windows 11/64, RTX 3070, Vulkan
Issue description
4.3 introduced a rendering artifact in Terrain3D (the blue). sampler2DArray + Mipmaps causes the problem. Regular sampler, or disabling mipmaps (in import or sampler texture filtering) removes the artifact. Problem PRs found by bisecting.

Terrain3D uses a sampler2DArray with mipmap filtering to render the terrain. Here it is displaying in 4.2.2 with a flat terrain and a minimal shader.

PR https://github.com/godotengine/godot/pull/83452 caused two rendering artifacts, the green up close and dark far away. Changing UV scale moves the artifacts closer or farther from the camera.

PR https://github.com/godotengine/godot/pull/86855 improved the artifact by fixing the foreground.

The texture used here is stored in a TextureArray.

It is a PNG imported with VRAM Compressed HQ as BPTC. DXT5 RGB also tested. No difference between them.

With and without mipmaps have been tested. Disabling mipmaps removes the artifact.

The shader in the three pictures above has been simplified down to this minimal example.

shader_type spatial;
render_mode blend_mix,depth_draw_opaque,cull_back,diffuse_burley,specular_schlick_ggx;

uniform sampler2DArray _texture_array_albedo : source_color, filter_linear_mipmap_anisotropic, repeat_enable;

void vertex() {
	vec3 v_vertex = (MODEL_MATRIX * vec4(VERTEX, 1.0)).xyz;
	UV = round(v_vertex.xz);
}

void fragment() {
	ALBEDO = texture(_texture_array_albedo, vec3(UV*.05, 0.)).rgb;
}

Using this shader, but changing the sampler filtering to linear or nearest without mipmaps removes the artifact, though it's noisy.
Using this shader, but changing the texture import settings to not generate mipmaps removes the artifact, though it's noisy.

Creating a large meshinstance plane 20k x 20k and the same albedo texture file as on the terrain, using the Standard Material and linear filtering with mipmaps does not produce the artifact.
Using a shadermaterial on the plane with the above shader, with linear filtering w/ mipmaps, but making it a regular Sampler2D instead of a texture array does not produce the artifact.
Using this sampler2D version of the shader on our terrain meshes does not produce the artifact.

Conclusion, it shows the artifact when using sampler2DArray and textures with mipmaps.
Steps to reproduce

Download the release of Terrain3D https://github.com/TokisanGames/Terrain3D/releases/tag/v0.9.1-beta
Open the demo project in Godot 4.2.2 to see it normally, or 4.3-dev to see the artifact.
Restart when prompted, then again after Godot imports to get setup.
Under Terrain3D/Material, enable Shader Override and overwrite it with this minimum shader to see the artifact.

shader_type spatial;
render_mode blend_mix,depth_draw_opaque,cull_back,diffuse_burley,specular_schlick_ggx;

uniform sampler2DArray _texture_array_albedo : source_color, filter_linear_mipmap_anisotropic, repeat_enable;

void vertex() {
	vec3 v_vertex = (MODEL_MATRIX * vec4(VERTEX, 1.0)).xyz;
	UV = round(v_vertex.xz);
}

void fragment() {
	ALBEDO = texture(_texture_array_albedo, vec3(UV*.05, 0.)).rgb;
}

This variation uses sampler2D and does not show the artifact. Attach one of the demo textures to the texture_albedo slot.

shader_type spatial;
render_mode blend_mix,depth_draw_opaque,cull_back,diffuse_burley,specular_schlick_ggx;

uniform sampler2D texture_albedo : source_color, filter_linear_mipmap_anisotropic, repeat_enable;

void vertex() {
	vec3 v_vertex = (MODEL_MATRIX * vec4(VERTEX, 1.0)).xyz;
	UV = round(v_vertex.xz);
}

void fragment() {
	ALBEDO = texture(texture_albedo, UV*.05).rgb;
}

Minimal reproduction project (MRP)
See above.
cc: @RandomShaper, @Calinou, @clayjohn

Taking a look in Renderdoc, I can see that the final mipmap levels of the ArrayTexture are not being filled (2x2 and 1x1) so garbage data is being used. The solution is going to be ensuring that the full mipmap data is transferred to the GPU

Okay, after some investigation, I have created an MRP for this issue.
terrain3dmrp.zip

Okay, here is a diff that appears to work. Please give this a try. I'm going to double check it in the morning, but I think this should be good:
diff --git a/drivers/vulkan/rendering_device_driver_vulkan.cpp b/drivers/vulkan/rendering_device_driver_vulkan.cpp
index 1906d168fe..aeeacafc6e 100644
--- a/drivers/vulkan/rendering_device_driver_vulkan.cpp
+++ b/drivers/vulkan/rendering_device_driver_vulkan.cpp
@@ -1703,7 +1703,7 @@ void RenderingDeviceDriverVulkan::texture_get_copyable_layout(TextureID p_textur
                uint32_t bw = 0, bh = 0;
                get_compressed_image_format_block_dimensions(tex_info->rd_format, bw, bh);
                uint32_t sbw = 0, sbh = 0;
-               r_layout->size = get_image_format_required_size(tex_info->rd_format, w, h, d, 1, &sbw, &sbh);
+               r_layout->size = get_image_format_required_size(tex_info->rd_format, MAX(w, bw), MAX(h, bh), d, 1, &sbw, &sbh);
                r_layout->row_pitch = r_layout->size / ((sbh / bh) * d);
                r_layout->depth_pitch = r_layout->size / d;
                r_layout->layer_pitch = r_layout->size / tex_info->vk_create_info.arrayLayers;
diff --git a/servers/rendering/rendering_device.cpp b/servers/rendering/rendering_device.cpp
:...skipping...
diff --git a/drivers/vulkan/rendering_device_driver_vulkan.cpp b/drivers/vulkan/rendering_device_driver_vulkan.cpp
index 1906d168fe..aeeacafc6e 100644
--- a/drivers/vulkan/rendering_device_driver_vulkan.cpp
+++ b/drivers/vulkan/rendering_device_driver_vulkan.cpp
diff --git a/drivers/vulkan/rendering_device_driver_vulkan.cpp b/drivers/vulkan/rendering_device_driver_vulkan.cpp
index 1906d168fe..aeeacafc6e 100644
--- a/drivers/vulkan/rendering_device_driver_vulkan.cpp
diff --git a/drivers/vulkan/rendering_device_driver_vulkan.cpp b/drivers/vulkan/rendering_device_driver_vulkan.cpp
index 1906d168fe..aeeacafc6e 100644
--- a/drivers/vulkan/rendering_device_driver_vulkan.cpp
+++ b/drivers/vulkan/rendering_device_driver_vulkan.cpp
@@ -1703,7 +1703,7 @@ void RenderingDeviceDriverVulkan::texture_get_copyable_layout(TextureID p_textur
                uint32_t bw = 0, bh = 0;
                get_compressed_image_format_block_dimensions(tex_info->rd_format, bw, bh);
                uint32_t sbw = 0, sbh = 0;
-               r_layout->size = get_image_format_required_size(tex_info->rd_format, w, h, d, 1, &sbw, &sbh);
+               r_layout->size = get_image_format_required_size(tex_info->rd_format, MAX(w, bw), MAX(h, bh), d, 1, &sbw, &sbh);
                r_layout->row_pitch = r_layout->size / ((sbh / bh) * d);
                r_layout->depth_pitch = r_layout->size / d;
                r_layout->layer_pitch = r_layout->size / tex_info->vk_create_info.arrayLayers;
diff --git a/servers/rendering/rendering_device.cpp b/servers/rendering/rendering_device.cpp
index 2b6644e893..855eeabfd5 100644
--- a/servers/rendering/rendering_device.cpp
+++ b/servers/rendering/rendering_device.cpp
@@ -1350,6 +1350,9 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye
                thread_local LocalVector<RDD::BufferTextureCopyRegion> command_buffer_texture_copy_regions_vector;
                command_buffer_texture_copy_regions_vector.clear();

+               uint32_t block_w = 0, block_h = 0;
+               get_compressed_image_format_block_dimensions(tex->format, block_w, block_h);
+
                uint32_t w = tex->width;
                uint32_t h = tex->height;
                uint32_t d = tex->depth;
@@ -1365,8 +1368,8 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye
                        copy_region.texture_region_size.z = d;
                        command_buffer_texture_copy_regions_vector.push_back(copy_region);

-                       w = MAX(1u, w >> 1);
-                       h = MAX(1u, h >> 1);
+                       w = MAX(block_w, w >> 1);
+                       h = MAX(block_h, h >> 1);
                        d = MAX(1u, d >> 1);
                }

@@ -1395,8 +1398,6 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye
                for (uint32_t i = 0; i < tex->mipmaps; i++) {
                        uint32_t width = 0, height = 0, depth = 0;
                        uint32_t tight_mip_size = get_image_format_required_size(tex->format, w, h, d, 1, &width, &height, &depth);
-                       uint32_t block_w = 0, block_h = 0;
-                       get_compressed_image_format_block_dimensions(tex->format, block_w, block_h);
                        uint32_t tight_row_pitch = tight_mip_size / ((height / block_h) * depth);

                        // Copy row-by-row to erase padding due to alignments.
@@ -1408,8 +1409,8 @@ Vector<uint8_t> RenderingDevice::texture_get_data(RID p_texture, uint32_t p_laye
                                wp += tight_row_pitch;

I checked out master and applied these. Though the first one is a really odd diff. I couldn't apply it automatically with patch nor git apply. It includes changes across multiple commits, even a duplicate one. I applied it manually.
I see no change to the far dark artifact. I also regenerated the ctex files going to DXT and a new BPTC generation and see no difference.

Hmmm, maybe something went wrong applying the diffs. Here is a proper patch file with all the changes after rebasing:
terrain3d.patch.txt

This patch applied fine and resolved the artifact, thank you!
btw unrelated but I noticed that on the current master, loading Godot (win/3070) the editor viewport won't render any models until the camera is moved. Wasn't a problem on 4.3dev-5.


Add mipmaps to sf::Texture

I think not having mipmaps in SFML is something that needs to be changed, because it helps when using setScale and when putting a larger texture onto a smaller sized shape.
As I liked to have it myself I added this to sf::Texture and it should also fix Issue #123 .
I made it such that its backwards compatible and keeps deactivated until used. When not used it just adds a check of a status variable on some method calls. Its possible to use all underlying modes in combination with the smooth setting.
This uses the texture parameter to generate the mipmaps.
It looks like its working for me, but you would probably want to test it before applying.
PS:
I also put some effort into adding code for using the newer glGenerateMipmapExt and glGenerateMipmap and making mipmaps available for the internal texture of sf::RenderTexture. You can view those other commits in my forked repository at https://github.com/wintertime/SFML/tree/mipmaps .
I did not include those here, because I get graphical glitches sometimes although other times it looks like it works. I think there is either something wrong with the order of calls to the OpenGL functions or I experienced the driver bug mentioned on http://www.opengl.org/wiki/Common_Mistakes#Automatic_mipmap_generation .
Here is a small test program for trying it out, you can change a few parameters in the code and then look at a larger area of the texture squeezed into the window by pressing Numpad6 so you can watch the effect of mipmaps:
#include "SFML/Graphics.hpp"
#include <vector>

int32_t windowx(512);
int32_t windowy(512);
bool fullscreen(false);

void CreateTexture(sf::Texture& tex,int sz,int w,int b) {
  std::vector<sf::Uint8> pix;
  pix.resize(sz*sz*4);
  for(int y(0);y<sz;y+=w+b) {
    int ty(0);
    for(;ty<w && y+ty<sz;++ty)
      for(int x(0);x<sz;x+=w+b) {
        int tx(0);
        for(;tx<w && x+tx<sz;++tx) {
          int index=((y+ty)*sz+(x+tx))*4;
          pix[index  ]=255;
          pix[index+1]=0;
          pix[index+2]=0;
          pix[index+3]=255;
        }
        for(;tx<w+b && x+tx<sz;++tx) {
          int index=((y+ty)*sz+(x+tx))*4;
          pix[index  ]=0;
          pix[index+1]=255;
          pix[index+2]=0;
          pix[index+3]=255;
        }
      }
    for(;ty<w+b && y+ty<sz;++ty)
      for(int x(0);x<sz;x+=w+b) {
        int tx(0);
        for(;tx<w && x+tx<sz;++tx) {
          int index=((y+ty)*sz+(x+tx))*4;
          pix[index  ]=0;
          pix[index+1]=0;
          pix[index+2]=0;
          pix[index+3]=255;
        }
        for(;tx<w+b && x+tx<sz;++tx) {
          int index=((y+ty)*sz+(x+tx))*4;
          pix[index  ]=0;
          pix[index+1]=0;
          pix[index+2]=255;
          pix[index+3]=255;
        }
      }
  }
  sf::Image img;
  img.create(sz,sz,&pix[0]);
  tex.loadFromImage(img);
}

int main(int argc,char* argv[]) {
  sf::RenderWindow window(sf::VideoMode(windowx,windowy),"Test",
                    fullscreen ? sf::Style::Fullscreen : sf::Style::Default,
                    sf::ContextSettings(0,0,0,2,1));
  window.setVerticalSyncEnabled(1);

  sf::Texture tex;
  float scale(1.0f);
  int sz(512);
  int w(128);
  int b(128);

  //tex.setSmooth(true);
  tex.setUsedMipmaps(2);
  tex.setRepeated(true);
  CreateTexture(tex,sz,w,b);

  sf::Event event;
  while(window.isOpen()) {
    window.clear();
    sf::RectangleShape shape(sf::Vector2f(512,512));
    shape.setTexture(&tex);
    shape.setTextureRect(sf::IntRect(0,0,sz*scale,sz*scale));
    window.draw(shape);
    window.display();

    while(window.pollEvent(event)) {
      if(event.type==sf::Event::Closed)
        window.close();
      else if(event.type==sf::Event::KeyPressed) {
        switch(event.key.code) {
        default:
          continue;
        case sf::Keyboard::Numpad6:
          scale*=1.1f;
          continue;
        case sf::Keyboard::Numpad5:
          scale=1.0f;
          continue;
        case sf::Keyboard::Numpad4:
          scale/=1.1f;
          continue;
        case sf::Keyboard::Numpad9:
          sz*=2;
          break;
        case sf::Keyboard::Numpad3:
          sz/=2;
          if(sz<1)
            sz=1;
          break;
        case sf::Keyboard::Numpad7:
          if(w<sz/2)
            w*=2;
          break;
        case sf::Keyboard::Numpad1:
          w/=2;
          if(w<1)
            w=1;
          break;
        case sf::Keyboard::Numpad8:
          if(b<sz/2)
            b*=2;
          break;
        case sf::Keyboard::Numpad2:
          b/=2;
          if(b<1)
            b=1;
          break;
        }
        CreateTexture(tex,sz,w,b);
      }
    }
  }

  return 0;
}

Note: this is (really) old and cannot be used as is.

Superseded by #973.


onAuthorizationDidChange not called (and never called) on specific flow

Environment:

Version 1.1.1
Swift 3
iPhone 4S 8.4

I am displaying a alert to open the app settings when the status is different than the one required (.alwaysInUse). The handler is being called when I swap between an incorrect value (!= .alwaysInUse) and (.alwaysInUse) but is not called between two incorrect values. This is important because I am using the handler to open an alert.
Reproduce:

Open app and authorise location
Go to settings app (app suspended and change to when in use or never)
Go to app and the handler onAuthorizationDidChange is called
Go to settings app and change to the other non-always option
Go back to app and the handler is not called
From now on, the onAuthorizationDidChange event handler is never called

Hi @bphenriques,
This not seems a bug; in fact when an error occurs while performing a request the request itself is aborted and removed from the queue.
You should re-add it manually.

I'm working around it in order to provide a recovery on error feature. I'll update this thread soon as I can.

Hey @malcommac , that behaviour was not clear for me. I will attempt to re-observe on viewWillAppear and see if it solves the issue

So if I want to ignore errors and keep updated I should start another request in the error callback ?
Isn't simple that the request shouldn't be discarded unless we cancel it in the error callback ?

That was the behaviour I was expecting as well (cancel on viewWillDisappear/deInit)

Since  2.x branch you can observe the authorization status for each request:
let request = Location.getLocation...
// callback is called on main thread by reporting previous and current authorization status
request.register(observer: LocObserver.onAuthDidChange(.main, { (request, oldAuth, newAuth) in
    print("Authorization moved from \(oldAuth) to \(newAuth)")
}))

Please notice: while the overall behaviour is the same, since 2.x branch some API names are changed. Nothing dramatic 👍

perhaps the readme could be updated:
https://github.com/malcommac/SwiftLocation/#observe-authorization-status-changes


Add an option to disable statistics in menu

Hi. Firstly thank you for that app. I want to little thing from you. Seeing shaky presses statistics makes me sad. Therefore I don't want to see the counter. I would be very happy if you could add such an option to the settings. Thank you
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Remove counter
Describe alternatives you've considered
None
Additional context


 For example, update kovan faucet links. Please check the CONTRIBUTING doc for more details on commits naming.

We are still holding off on this change. Please stand-by.


Fix Start-PSBuild on WSL if repository was already built on Windows

To fix #5194: Use the first 3 characters of the passed -Runtime parameter for the .inc file (the full runtime name could not be used since the separation characters ike e.g. the the hyphen would make dotnet crash when building).
A separate issue is that the runtime does not get determined if is not being passed (which is OK since dotnet takes then care of choosing the right one) but maybe given this scenario would it make sense to determine and set it as a convenience?

This should slot in nicely with my tweak to build.psm1 #5341

I think you need to update this .gitignore file to make it handle the platform specific inc files:
40:121ms> gc .\src\TypeCatalogGen\.gitignore
powershell.inc

I was noticing that Git thought I had a new file with powershell_win.inc.

Thanks. Well spotted, I updated it to ignore now powershell*.inc. I find it a bit odd that there is a special .gitignore file in this folder and am wondering if we can move this to the top level .gitignore file?

@bergmeister Because this ignore rule doesn't apply to anywhere else in the repository, just keeping it simple 😄

@andschwa My thinking is rather that if there will never be any other .inc files somewhere else, it would be nice to put it into the top one to have a more central place, especially since there is only one entry in it. But this is probably more of a stylistic preference with no 'right' answer depending on how big the central place can become (to me the output of gci -Recurse .gitignore | % {cat $_} did not seem to be too long)... But I'll leave it then as it is if that's your preference.

NB: The build was read because NuGet has a global outage (see here)

I'd prefer to fix the issue more natively like #3870.
Also I'm not sure that's the only runtime addiction. Should we clean up if our files contains "#if UNIX"?

I'll address the comments next Monday when I'm back from travelling.

@daxian-dbw Thanks for your useful feedback. I have addressed all issues and left comments there. But basically the 2 remaining questions are:

Should we be strict about string interpolation (i.e. use $()) since there are gotchas as I pointed out?
Should Start-TypeGen have a default value for the new $IncFileName parameter or should we automatically determine it in there similarly as in Start-PSBuild?

@bergmeister For the two questions, I answered them in the corresponding comment threads: https://github.com/PowerShell/PowerShell/pull/5346#discussion_r150988197 and https://github.com/PowerShell/PowerShell/pull/5346#discussion_r150988544

@daxian-dbw Thanks for the review. I have addressed your comments.


Docs WTF?

As a developer, I would expect API documentation to include at a minimum a list of endpoints and HTTP verbs.  I see none of that on this repo.  As such, it fails in its primary purpose.  The examples?  Nothing but YAML files.  What are these YAML files and what do they tell me about theGrid's API?  Nothing.  You have JSON Schema?  Wonderful!  But there's only one (?) and there's zero relevant information as to how data in the structure described by this schema fits into the API.... is that describing a request format?  Is it a response format?  If so, which one?  In other words, the basic litmus test here fails: I expected to find something usable describing the API, but instead there is this mysterious collection of documents that I wouldn't think had anything to do with an API if that were not present in the title.
Small note re the link to the JSON Schema site, it must be http, not https: http://json-schema.org/
I'm sure you guys have worked very hard on the architecture of the services and on your app.  I know writing docs can be difficult and time-consuming, but I would encourage you to put a commensurate amount of thought and effort into these API docs, otherwise we the developers cannot make use of any of your labors.

Hello. This repository contains the source for the API documentation. Did you have a look at the output, hosted at https://developer.thegrid.io ? There you will find the list of endpoints and methods, for instance most of the API related to content and sites is here: https://developer.thegrid.io/api.html

The comment was directed at https://developer.thegrid.io/ specifically -- that page is more or less useless from an API perspective for the reasons stated in the original post.
https://developer.thegrid.io/api.html is what I was after, thank you.
I would consider this issue if the https://developer.thegrid.io/ page were refactored to prominently link to the https://developer.thegrid.io/api.html page (e.g. use a left-menu title for "Endpoints" or similar) since that is ultimately what visitors are expecting to see on a page titled "The Grid API".  Or, preferably, have the api.html live at the https://developer.thegrid.io/ page and have the current page on a sub-page that is geared more for introductory talk about the api.
I would open a pull request for this type of change, but I don't see a CONTRIBUTING.md file that would explain whatever system is used to render the docs.

Glad you found what you wanted.
The link in question was second one from the top. I added a header to the secion, so it gets a left-menu entry now. Also reduced the amount of fluff on frontpage a bit, hopefully making things easier to find.
Missing contribution docs tracked here: #89


Automatic SQL script generation during build process

@CarstenHollmann Hi, I want to contribute can you give some issues


host-api v0.26.0

Cant be merged bc of the dns fqdn issue. not sure if fixing that means a new hsot-api release, so leaving open


闪退崩溃（我已安装必要组件）

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.05.16
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
https://user-images.githubusercontent.com/85213740/120428699-babf0380-c3a6-11eb-8e3c-59027f210cf0.mp4

youtube-dl is a command line program. https://github.com/ytdl-org/youtube-dl#description
I guess you are trying to open the application icon.

Windows版本的exe应用程序，但是打不开，有错误提示（图片）
------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2021年6月2日(星期三) 下午3:14
收件人: @.>;
抄送: "HUC @.>; @.>;
主题: Re: [ytdl-org/youtube-dl] 闪退崩溃（我已安装必要组件） (#29193)
Youtube - dl 是一个命令行程序。https://github.com/ytdl-org/youtube-dl#描述
我猜你是想打开应用程序图标。
—
您正在接收此消息，因为您创建了该线程。
直接回复此邮件，在 GitHub 上查看或取消订阅.

That is not how youtube-dl works. You must use the Command Prompt or PowerShell to enter a command with parameters and flags. The documentation on the front page at https://github.com/ytdl-org/youtube-dl shows everything you need to know.

The vast majority of the old M$-DO$ commands are still equally valid in Command Prompt, which is a subset of M$-DO$ 7, with later Window$ versions introducing some new things. So, the comparison is something like 98.99999% valid.
PowerShell, on the other hand, is like Bash in that you can do so much with the integral stuff, but is a completely diff thing from Command Prompt, and Bash, as far as syntax goes.

老铁，你需要从命令行执行这个程序，基本就是youtube-dl 空格 跟上你要下载的视频网页地址。


Skip vis map instantiation and request it when dataviews are generated

Basically, this PR is using the code of this PR from CartoDB.js.
cc @viddo @javisantana @acanimal @alonsogarciapablo @javierarce

[ ] Need to point to the latest CartoDB.js commit.


[SPARK-44751][SQL] XML FileFormat Interface implementation

What changes were proposed in this pull request?
This is the second PR related to the built-in XML data source implementation (jira).
The previous PR ported the spark-xml package.
This PR addresses the following:

Implement FileFormat interface
Address the review comments in the previous XML PR
Moved from_xml and schema_of_xml to sql/functions
Moved ".xml" to DataFrameReader/DataFrameWriter
Removed old APIs like XmlRelation, XmlReader, etc.
StaxXmlParser changes:

Use FailureSafeParser
Convert 'Row' usage to 'InternalRow'
Convert String to UTF8String
Handle MapData and ArrayData for MapType and ArrayType respectively
Use TimestampFormatter to parse timestamp
Use DateFormatter to parse date

StaxXmlGenerator changes:

Convert 'Row' usage to 'InternalRow'
Handle UTF8String for StringType
Handle MapData and ArrayData for MapType and ArrayType respectively
Use TimestampFormatter to format timestamp
Use DateFormatter to format date

Update XML tests accordingly because of the above changes

Why are the changes needed?
These changes are required to bring XML data source capability at par with CSV and JSON and supports features like streaming, which requires FileFormat interface to be implemented.
Does this PR introduce any user-facing change?
Yes, it adds support for XML data source.
How was this patch tested?

Ran all the XML unit tests.
Github Action

License-wise there is no problem because I wrote them. I filed CCLA/ICLA when I became a committer.
Through SPIP, we have reached a lazy consensus including PMC votes.
IP clearance is for an external project but this is really a plugin that has very small codebase. We haven't done that for Avro, CSV, cloudpickle for example in which the codebase is really small, and we reviewed them line by line.
In addition, we're NOT just porting it as is but release a modified version per Sparks internal interface that will allows a lot of features such as parttioned table. TBH it's more work and code to modify them than just portint it.

Thanks for the explanation @HyukjinKwon. I'm OK with it if we already have precedents like arvo and csv

Thanks for the explanation @HyukjinKwon. I'm OK with it if we already have precedents like arvo and csv

@yaooqinn @HyukjinKwon has addressed your concern. Can you please approve?

Let me get this in first because @sandip-db seems like working on another followup. Let's address them in a followup.

The tests passed.
Merged to master.


Retry-Delay does not appear in help text

APIM-CLI version
1.13.3
API-Management version
7.7
Bug description
A retry-delay option was added in https://github.com/Axway-API-Management-Plus/apim-cli/issues/213 but it does not appear to be mentioned in the help text.
Steps to reproduce
Run apim api import help
Relevant log output
>apim api import help
2023-02-16 16:28:09,378 [APIManagerCLI] INFO : API-Manager CLI: 1.13.3
2023-02-16 16:28:09,380 [APIManagerCLI] INFO : Module: API - I M P O R T (1.13.3)
usage: API-Import [-ignoreCache] [-clearCache <ALL>] [-apimCLIHome </home/chris/apim-cli>] [-force] [-p <changeme>] [-u <apiadmin>] [-port
       <8181>] [-returncodes] [-h <api-host>] [-s <preprod>] [-a <swagger_file.json>] -c <api_config.json> [-ignoreQuotas] [-updateOnly]
       [-useFEAPIDefinition] [-clientOrgsMode <ignore|replace|add>] [-clientAppsMode <ignore|replace|add>] [-quotaMode <ignore|replace|add>]
       [-detailsExportFile <APIDetails.properties>] [-forceUpdate] [-enabledCaches <applicationsQuotaCache,*API*>] [-stageConfig
       <my-staged-config.json>] [-apimanagerUrl <https://manager.domain.com>]
 -ignoreCache                                    The cache for REST-API calls against the API-Manager isn't used at all.
 -clearCache <ALL>                               Clear the cache previously created, which will force the CLI to get fresh data from the
                                                 API-Manager.
                                                 Examples: 'ALL', '*application*', 'applicationsQuotaCache,*api*'
 -apimCLIHome </home/chris/apim-cli>             The absolute path to the CLI home directory containing for instance your conf folder.
                                                 You may also set the environment variable: 'AXWAY_APIM_CLI_HOME'
 -force                                          Optional flag used by different modules to enforce actions. For instance import breaking
                                                 change or delete API(s).
 -p,--password <changeme>                        Password used to authenticate
 -u,--username <apiadmin>                        Username used to authenticate. Please note, that this user must have Admin-Role
 -port <8181>                                    Optional parameter to declare the API-Manager port. Defaults to 8075.
 -returncodes                                    Print the possible return codes and description.
 -h,--host <api-host>                            The API-Manager hostname the API should be imported
 -s,--stage <preprod>                            The API-Management stage (prod, preprod, qa, etc.)
                                                 Is used to lookup the stage configuration file.
 -a,--apidefinition <swagger_file.json>          (Optional) The API Specification either as OpenAPI (JSON/YAML) or a WSDL for SOAP-Services:
                                                 - in local filesystem using a relative or absolute path. Example: swagger_file.json
                                                 Please note: Local filesystem is not supported for WSDLs. Please use direct URL or a
                                                 URL-Reference-File.
                                                 - a URL providing the Swagger-File or WSDL-File. Examples:
                                                 [username/password@]https://any.host.com/my/path/to/swagger.json
                                                 [username/password@]http://www.dneonline.com/calculator.asmx?wsdl
                                                 - a reference file called anyname-i-want.url which contains a line with the URL
                                                 (same format as above for OpenAPI or WSDL).  If not specified, the API Specification
                                                 configuration is read directly from the API-Config file.
 -c,--config <api_config.json>                   This is the JSON-Formatted API-Config containing information how to expose the API. You may
                                                 get that config file using apim api get with output set to JSON.
 -ignoreQuotas                                   Use this flag to ignore configured API quotas.
 -updateOnly                                     If set, an existing actual API will be updated. If no actual API is found, the CLI stops.
 -useFEAPIDefinition                             If this flag is set, the Actual-API contains the API-Definition (e.g. Swagger) from the
                                                 FE-API instead of the original imported API.
 -clientOrgsMode <ignore|replace|add>            Controls how configured Client-Organizations are treated. Defaults to add!
 -clientAppsMode <ignore|replace|add>            Controls how configured Client-Applications are treated. Defaults to add!
 -quotaMode <ignore|replace|add>                 Controls how quotas are managed in API-Manager. Defaults to add!
 -detailsExportFile <APIDetails.properties>      Configure a filename, to get a Key=Value file containing information about the created API.
 -forceUpdate                                    If set, the API is Re-Created even if the Desired- and Actual-State are equal.
 -enabledCaches <applicationsQuotaCache,*API*>   By default, no cache is used for import actions. However, here you can enable caches if
                                                 necessary to improve performance. Has no effect, when -gnoreCache is set. More information
                                                 on the impact: https://bit.ly/3FjXRXE
 -stageConfig <my-staged-config.json>            Manually provide the name of the stage configuration file to use instead of derived from
                                                 the given stage.
 -apimanagerUrl <https://manager.domain.com>     Instead of using host and port, you can set the entire API-Manager URL. Host and Port will
                                                 be ignored if set.

ERROR: Missing required option: c

----------------------------------------------------------------------------------------
How to import APIs
Import an API including the API-Specification using environment properties file: env.api-env.properties:
scripts\apim.bat api import -c samples/basic/minimal-config-api-specification.json -s api-env
scripts\apim.bat api import -c samples/basic/minimal-config-api-specification-filtered.json -s api-env
scripts\apim.bat api import -c samples/basic/odata-v2-northwind-api.json -s api-env

scripts\apim.bat api import -c samples/complex/complete-config.json -a ../petstore.json -h localhost -u apiadmin -p changeme

For more information and advanced examples please visit:
https://github.com/Axway-API-Management-Plus/apim-cli/tree/develop/modules/api-import/assembly/samples
https://github.com/Axway-API-Management-Plus/apim-cli/wiki
2023-02-16 16:28:09,397 [APIImportApp] ERROR: Missing required option: c
com.axway.apim.lib.errorHandling.AppException: Missing required option: c

Also, looks like it is also parsing required parameters when it should be displaying the help text.
"ERROR: Missing required option: c"


Adding retries to look for flakiness

I was unable to reproduce this issue #86 in my CI run (See screenshot below of successful run with all tests passing), but just in case I added retries to look for flakiness in the tests. This has been super helpful for us on Luma since Luma is so heavy JS based and sometimes a script just takes too long to load and messes up a test.
https://docs.cypress.io/guides/guides/test-retries.html

@Vinai maybe we could make this setting dependent on the specSuite? For Hyva, 0 retries. For Luma, 3 retries (by default)?

Sounds like an appropriate workaround.

Ah, no, that's not enough. If the config.specSuite is defined, applySpecSuiteToSpecPattern isn't called.

Merging this to see whether it fixes #93 . Also Hyvä tests are flaky for some reason.


Cannot run it for some reason, it says: "Entry Point Not Found" every time

I opened when FFXIV was running, tried alot of things such as disabling anti-virus, downloading the file again, and restarting PC
https://i.imgur.com/70Tq1VH.png

Ah, I only tested on Windows 10, and that API is only available on W10. I'll fix that later today.

I am running Windows 10 albeit a very old version, it is version 1607

https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setthreaddescription
Microsoft claims that the API is available fron 1607, but apparently it's not. As the usage for the API is purely for debugging, I'll just make the program not use the API if it's not found

Fixed with b0c5847e40445b6f0cb01c31c9365ae3f0974a28. Try again after downloading the new release.

Hi, I'm writing again to say that i was able to run it fine with the new release and it worked wonders. I'm so amazed that this is the power of people with low ping been having.


aws_cognito_identity_pool_id missing in the final aws-exports.js

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
NEW_APP
AWS Region
us-east-1
Amplify Hosting feature
Environment variables, Frontend builds
Describe the bug
While documenting the Cognito setup flow for my project documentation I stumbled upon an issue where using CLI for initial setup with social providers fails to include the aws_cognito_identity_pool_id in the final aws-exports.js output.
Below I included the images of choices I made while settings up the environment from scratch.
Funny thing is that last week, when running the wizard,  the final output did include the aws_cognito_identity_pool_id. I didn't document the flow that, but I am sure I was using the social provider auto setup as well, I would it expect to always include the id in the final config object
Expected behavior
Instead of aws-exports looking like this:
const awsmobile = {
  aws_project_region: 'us-east-1',
  aws_cognito_region: 'us-east-1',
  aws_user_pools_id: ':Redacted',
  aws_user_pools_web_client_id: ':Redacted',
  oauth: {
    domain: ':Redacted',
  },
  aws_cognito_username_attributes: ['EMAIL'],
  aws_cognito_social_providers: [],
  aws_cognito_signup_attributes: ['EMAIL'],
  aws_cognito_mfa_configuration: 'OFF',
  aws_cognito_mfa_types: [],
  aws_cognito_password_protection_settings: {
    passwordPolicyMinLength: 8,
    passwordPolicyCharacters: [
      'REQUIRES_LOWERCASE',
      'REQUIRES_UPPERCASE',
      'REQUIRES_NUMBERS',
      'REQUIRES_SYMBOLS',
    ],
  },
  aws_cognito_verification_mechanisms: ['EMAIL'],
}

it should look like (include aws_cognito_identity_pool_id: ':Redacted',:
const awsmobile = {
  aws_project_region: 'us-east-1',
  aws_cognito_region: 'us-east-1',
  aws_user_pools_id: ':Redacted',
  aws_user_pools_web_client_id: ':Redacted',
  aws_cognito_identity_pool_id:
    ':Redacted',
  oauth: {
    domain: ':Redacted',
  },
  aws_cognito_username_attributes: ['EMAIL'],
  aws_cognito_social_providers: [],
  aws_cognito_signup_attributes: ['EMAIL'],
  aws_cognito_mfa_configuration: 'OFF',
  aws_cognito_mfa_types: [],
  aws_cognito_password_protection_settings: {
    passwordPolicyMinLength: 8,
    passwordPolicyCharacters: [
      'REQUIRES_LOWERCASE',
      'REQUIRES_UPPERCASE',
      'REQUIRES_NUMBERS',
      'REQUIRES_SYMBOLS',
    ],
  },
  aws_cognito_verification_mechanisms: ['EMAIL'],
}

Reproduction steps
amplify init
amplify add auth

and afterwards running:
amplify env checkout dev

Build Settings
No response
Log output

# Put your logs below this line

Additional information
No response

update 2: (success)
Going with manual configuration: User Sign-Up, Sign-In, connected with AWS IAM controls (Enables per-user Storage fea tures for images or other content, Analytics, and more) ended with federated pool id being present in the end.
remarks:

Why do you ask for facebook app id just to ask for it again couple of questions later?
Questions are frased differently, you have this feeling it's slightly different process overall + the number of deployed resources seems to be higher as well (not confirmed with data, subjective)

By default you mean default with or without the social provider? It's kind of weird if it's for bare default, cause I would assume that that's a scenario where you don't need federated sign in 🤔

Hey @mkbctrl by "default" I am referring to the first prompt for amplify add auth where it prompts for "default config", "default with social...", or "manual configuration". In the path you posted, when choosing "manual configuration" we must specify the option that is "connected with IAM controls"
As an example, using the "default with social provider" option will create the identity pool and associated ID in src/aws-exports.js
 Do you want to use the default authentication and security configuration? Default configu
ration with Social Provider (Federation)
 Warning: you will not be able to edit these selections.
 How do you want users to be able to sign in? Email
 Do you want to configure advanced settings? No, I am done.
 What domain name prefix do you want to use? 12520a5f00760-a5f00760
 Enter your redirect signin URI: http://localhost:3000/
? Do you want to add another redirect signin URI No
 Enter your redirect signout URI: http://localhost:3000/
? Do you want to add another redirect signout URI No
 Select the social providers you want to configure for your user pool: Facebook

 You've opted to allow users to authenticate via Facebook.  If you haven't already, you'll
 need to go to https://developers.facebook.com and create an App ID.

 Enter your Facebook App ID for your OAuth flow:  fakeappid
 Enter your Facebook App Secret for your OAuth flow:  fakeappsecret
✅ Successfully added auth resource 12520a5f00760 locally

Thank you @josefaidt for explaining it in detail. I have much better understanding of the overall solution right now. I followed the same flow as you "default with social provider", and it did create one user pool, and one federated identities pool.

When visiting federated identities pool settings you can notice that the connection to user pool is established:

but for the facebook, there is nothing. I would expect otherwise:

especially that, when trying to sign in using Facebook I am getting the following error:
Error during federated sign-in: NotAuthorizedException: Token is not from a supported provider of this identity pool.

Not sure whether it's a bug or a feature, but as an end user I would expect it work out of the box, or get notified in the end of the process what should I do next.
After entering the id manually in the federated identities pool settings, next sign in was successful.

but the problem I am currently stuck with is the difference in the response shape between the regular signIn and federatedSignIn. The idToken is missing in the federated response, which makes my api calls return 401 status (unauth)
I think I understand (thanks to: https://github.com/aws-amplify/amplify-js/issues/703), that Cognito User Pool is technically speaking very similar to Federated Identities Pool, and they are entirely separate things. If I sign in with facebook, the user will be added to federated pool, and the cognito user pool won't be aware about the fact.
However (I can't find the source atm), I googled, that when you connect the Cognito User Pool and Federated Identities User Pool, the federatedSignIn should return you idToken same as with regular signIn method (which I also believe happen when you are using you hosted UI - in my project I can't do that). Also I read that Cognito will handle cases like creating a user inside the Cognito User Pool if an email that just popped out through federated sign in does not exist yet.
After checking up the federated pool settings (screens above) I consider those user pools as connected. Am I wrong to assume that?
The attribute mapping is set as well:

Here the chunk of code handling this process (I am using next-auth to setup FB):
// profile and tokens come from next-auth
async profile(profile, tokens) {
        try {
          if (!tokens.expires_at || !tokens.access_token) {
            throw new Error('Facebook provider error: missing tokens')
          }

          const response = await Auth.federatedSignIn(
            'facebook',
            { token: tokens.access_token, expires_at: tokens.expires_at },
            { name: profile.name, email: profile.email }
          )

          const user = await Auth.currentAuthenticatedUser()

          console.log('user', user)
          console.log('response', response)

user:
{
  id: 'us-east-1:redacted',
  name: 'redacted',
  email: 'redacted',
  token: 'redacted'
}

response
{
  identityId: 'us-east-1:redacted',
  accessKeyId: 'ASIAredacted',
  secretAccessKey: 'yroredacted',
  sessionToken: 'redacted',
  expiration: 2023-05-15T11:07:53.000Z,
  authenticated: true
}

So my question to you @josefaidt , can you confirm it? And if that's the case, what my current setup is missing to make it work? (The only thing added as an extra on top of default output was the FB app id)
Thinking out loud:

Should I setup a lambda, that will create Cognito User Pool if I sign up with facebook?
Should I setup HUB listener and catch and event that will have the idToken in the payload?

Hey @mkbctrl what were the steps taken prior to noticing the Facebook credentials were missing? I was not able to reproduce that behavior when updating an existing auth resource with the social config and fake Facebook credentials

From the code snippet, are you using next-auth on top of Cognito by chance?
// profile and tokens come from next-auth

Since I was documenting the entire flow for my team all my steps were recorded. I started from scratch by running amplify init:

afterwards I checked if the app exist:

once I was sure the project was initiated I run all the steps mentioned above, which is running the next development server locally, trying the facebook sign in by hand, running into issue that it's not supported (NotAuthorizedError mentioned above as well), fixing it by adding the FB app id to the Identity Pool, and trying again.
Once I noticed I have different sets of tokens (again), and that idToken is still missing, I decided to post my findings here hoping your knowledge and experience will unstuck me :)
Regarding next-auth, you are correct. I am running it on top of Cognito. Here is my next-auth configuration file:
export const authOptions: NextAuthOptions = {
  debug: process.env.NODE_ENV !== 'production',
  session: {
    strategy: 'jwt',
    maxAge: getAuthSessionLength(),
  },
  // https://next-auth.js.org/configuration/providers/oauth
  providers: [
    CredentialsProvider({
      id: 'credentials',
      name: 'Sign in with email',
      credentials: {
        username: { label: 'email', type: 'text' },
        password: { label: 'Password', type: 'password' },
      },
      authorize: authAuthorizeCredentials,
    }),
    CredentialsProvider({
      id: 'credentials-auto-login',
      name: 'Create session from token',
      // @ts-ignore
      authorize: authAuthorizedAutologin,
    }),
  // WIP
   FacebookProvider<FacebookProviderProps>({
      clientId: 'redacted',
      clientSecret: 'redacted',
      async profile(profile, tokens) {
        try {
          if (!tokens.expires_at || !tokens.access_token) {
            throw new Error('Facebook provider error: missing tokens')
          }

          // await Auth.signOut()

          console.log(profile)

          const response = await Auth.federatedSignIn(
            'facebook',
            { token: tokens.access_token, expires_at: tokens.expires_at },
            { name: profile.name, email: profile.email }
          )
          const user = await Auth.currentAuthenticatedUser()
          const session = await Auth.currentSession()

          console.log('user', user)
          console.log('response', response)
          console.log('session', session)

          const { sessionToken, expiration } = response

          if (!expiration) {
            throw new Error('Facebook provider error: missing expiration date')
          }

          return {
            email<EMAIL_ADDRESS>            id: profile.id,
            uid: profile.id,
            idToken: sessionToken,
            idTokenExpiryDate: Date.now() + expiration.getTime() * 1000,
            refreshToken,
            // TODO: handle onboarding check
            isOnboarded: true,
            error: undefined,
          }
        } catch (error) {
          console.error('Error during federated sign-in:', error)
          return null
        }
      },
    }),
  ],
  pages: {
    signIn: PublicPath.SignIn,
    signOut: PublicPath.SignIn,
    error: PublicPath.SignIn,
  },
  // docs: https://next-auth.js.org/configuration/callbacks
  callbacks: {
    signIn: authCallbackSignIn,
    jwt: authCallbackJwt,
    session: authCallbackSession,
  },
  events: {
    signOut: authEventSignOut,
  },
}

authAuthorizeCredentials is using Cognito signIn (and works well), whereas authAuthorizedAutologin creates session based on Hub autologin event and creates the session on the fly.
Having Google and Facebook on top of that is currently my dream :D

As per you suggestion, running it empty would require me to create entirely different setup. Currently the place where I am executing the code is server-side (nextjs api endpoint), and federatedSignIn requires a window to be operational.
Still, just for experiment sake I attached function Auth.federatedSignIn() to a button and clicked it. Hosted UI opened, I was able to click on the Facebook button, and I got succefully redirected back to my app with the following query params attached to the url:
http://localhost:3000/access/sign-in?code=redacted-ceed-4c7c-b20b-9d32ba0ac82d&state=redactedKMUn4kA8wG9YbmbMO6KWUCJyC#_=_

surprise, surprise I also found a new arrival in my Cognito User Pool users list:

How is that possible?! 🤔 🤔 🤔
So basically running federatedSignIn() with params produces entirely different outcome than running it empty 🤔

I tried to use Hub listener in hopes to catch some events, unfortunately after upon redirect the Post 400 call is sometimes issued before the Hub listener is initiated (I am doing it inside _app.tsx so at the very top) , which leads to sometimes catching an event and sometimes not.
The events I  was able to listen to were about failure when getting back from cognito hosted UI.

Hey @mkbctrl wanted to follow up and mention that I am still investigating this use case with next-auth/auth.js on top of Cognito, but I touched base with our friends over at amplify-js and it is confirmed that when manually passing the user credentials as the second and third arguments of federatedSignIn it will not create a Cognito-native user. However, it is possible to link these federated identities to Cognito-native users, which I believe next-auth does by default when using a database provider. Creating the federated users and linking to Cognito-native users is what I am investigating for this use case.

Hey @josefaidt, thanks for your effort. Do you have any news maybe? I will investigate the account linking as you suggest. Will keep you posted about any findings.

Hey @mkbctrl apologies for the delay here! Have you found success with next-auth on Cognito? I noticed there is also now auth.js, however this would typically be used on top of a database in place of Cognito. Out of curiosity, what is the intended use case for using next-auth/auth.js on top of Cognito? Would you mind filing an issue in our docs repo requesting a guide for this with those details? https://github.com/aws-amplify/docs/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Closing due to inactivity


Config dependency problem

src/Illuminate/Notifications/resources/views/email.blade.php contains a reference to the global config function, which only occurs in the whole framework, thus breaking the notations package when used outside of the framework.

The same is true of src/Illuminate/Mail/resources/views/markdown/message.blade.php.

Hmm, you're right. We should try to find another way for this.

Couldn't we practically use the @inject blade directive for this?

I've been looking at this again but don't see any feasible way to solve this. If people want to use the mail component outside Laravel they can provide a custom message.blade.php file without the config helper.

I was already looking into this earlier, hence the changes I made to the app.url stuff not in the views. I was thinking we could pull the same trick for the views. I just never got around to making a PR. If nobody else does it within a couple of weeks, I will do it. It's not urgent anyways. :)

@GrahamCampbell okay

I was already looking into this earlier, hence the other changes I made relating to reading app.url from config. I was thinking we could pull the same trick for the views. I just never got around to making a PR. If nobody else does it within a couple of weeks, I will do it. It's not urgent anyways. :)

Hi Graham - I saw that you reopened this issue but I didn't understand the solution you were suggesting. What did you mean by "pull the same trick for the views". I would like to help with this issue and can send a PR with the changes :) Thanks!

Closing this as there is no actual "bug" reported by end users atm. It's just a hypothetical dependency problem that has been open for over a year.

The bug is that you get a fatal error if you use the component outside of the framework.

@GrahamCampbell they can overwrite the views if they want to.

Yeh, but it shouldn't be broken out of the box. That's like saying they can fork the repo if they want and make it work. 😆


Fix posteo recipe logging out at reload

Pre-flight Checklist
Please ensure you've completed all of the following.

[ ] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.

Description of Change
Fixes https://github.com/ferdium/ferdium-app/issues/953

I cannot check since I am not using this service, but since it seems you posted about that problem a while ago and you're happy with this fix, I guess that's working. Thanks for making this PR to fix it!

@all-contributors please add @magnouvean for code


Incorrect information in README.md

FILE: README.md
CONTEXT: "...a programming puzzles contest is published every day for twenty-four days."
SUGGESTED CHANGE: Advent of Code is 25 days long, may want to replace twenty-four with twenty-five.
From adventofcode.com/2023/day1 (most recent event):

"You've been doing this long enough to know that to restore snow operations, you need to check all fifty stars by December 25th.
Collect stars by solving puzzles. Two puzzles will be made available on each day in the Advent calendar; the second puzzle is unlocked when you complete the first. Each puzzle grants one star. Good luck!"

From adventofcode.com/2015/day1 (first event):

"Santa was hoping for a white Christmas, but his weather machine's "snow" function is powered by stars, and he's fresh out! To save Christmas, he needs you to collect fifty stars by December 25th.
Collect stars by helping Santa solve puzzles. Two puzzles will be made available on each day in the Advent calendar; the second puzzle is unlocked when you complete the first. Each puzzle grants one star. Good luck!"

I didn't think this minor issue warranted a fork + PR, but if this is incorrect, I am happy to go through that process.

Thanks!


feat(MeasureTheory/Integral/Lebesgue): add set_lintegral_subtype

Add MeasureTheory.set_lintegral_eq_subtype and
MeasureTheory.set_lintegral_subtype.
Add MeasurableEmbedding.comap_map,
MeasurableEmbedding.comap_restrict, and
MeasurableEmbedding.restrict_comap.
Drop measurability assumption in MeasurableEmbedding.comap_preimage.
Remove some empty lines.

Thanks!
bors r+


Search on Translatable model

Someone can give me a hint for the scenario where my model is in two language, the default data is saved on the main model and the translated data is saved in a another model which store many translations of different models.
I would like to know how to implement search with this solution and also when someone is searching he can see only data of his language,
Thank you

Hi @donmbelembe, you can use toSaerchableArray method and add all translations to the index.
It will enable searching in different languages. The second part of your question is more tricky, but I think you can use highlighting to get the field content in related language.


[Feature] Add Extended Attributes blog post

What are you changing in this pull request and why?
This PR adds a blog post covering Extended Attributes and related features for configuring more unique Environment and User connections in dbt Cloud.

features that allow cloud to be more flexible in ways that meet user needs.
and i'm interpreting this roughly as the overall intent of the article

@ericbaumann yea that's right, sorry it's confusing that i was referring to it as an EAT blog, just was originally scoped as that and stuck in my head that way, but yes, one of the pivots was understanding that the ask was really more to cover these features and how they have a common theme around enabling unique connections/environments in new ways. I'll do a pass at making that more clear! Thanks!


[Bug]: Wallet CLI does not allow full amount to be staked

Issue description
Wallet "alias": begin-staking 0xb8f540d46a9ebddc6bec85dafbe157f56d4aac033c3d216f115242a6512eb0e8<PHONE_NUMBER> 2
Stronghold password: [hidden]
Begin staking for 0xb8f540d46a9ebddc6bec85dafbe157f56d4aac033c3d216f115242a6512eb0e8.
`invalid stakes amount`
2024-04-26 07:49:47 (UTC) wallet::wallet_cli                         ERROR `invalid stakes amount`

The account in question has exactly<PHONE_NUMBER> tokens. Only after lowering it to 100000 did it work.
Version
Branch from #2235.
Expected behaviour
I should be able to stake the full amount in an account.
Actual behaviour
The command failed with invalid stakes amount.
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue

Create an account with account id id with X tokens.
Run begin-staking id X 1.

Errors
See above.
Duplicate declaration

[X] I have searched the issues tracker this issue and there is none

This may be related to the missing requirement in the staking calls that is being fixed in #2235

Sorry, I noted the wrong commit I was using. I actually used the branch from the #2235 PR for testing this, so it's still present there. Updated the description.


Fix linting error introduced in a4a38495

Sorry, I didn't see this PR and ended up fixing it in another commit. Thanks a lot though @Munter!


Sourcegraph commands are missing after exit

https://github.com/sourcegraph/sg.nvim/assets/69403093/a2dbc47d-fefd-4f11-bfe5-df8e5c668b9f
:checkhealth sg before exit:
==============================================================================
sg: require("sg.health").check()

sg.nvim report ~
- Machine: arm64, sysname: Darwin
- OK Valid nvim version: table: 0x010539ff18
- WARNING Unable to find valid cargo executable. Trying to build sg.nvim locally will fail. Instead use `:SourcegraphDownloadBinaries`
- OK Found `sg-nvim-agent`: "/Users/hamidreza4dev/.local/share/nvim/lazy/sg.nvim/dist/sg-nvim-agent"
- OK Found `node` (config.node_executable) is executable.
  Version: '20.11.0'
- OK Found `cody-agent`: /Users/hamidreza4dev/.local/share/nvim/lazy/sg.nvim/dist/cody-agent.js
- OK   Authentication setup correctly
- OK     endpoint set to: https://sourcegraph.com
- OK Found correct binary versions: "1.1.0" = "1.1.0"
- OK   Sourcegraph Connection info: {
  access_token_set = true,
  endpoint = "https://sourcegraph.com",
  sg_nvim_version = "1.1.0",
  sourcegraph_version = {
  build = "267416_2024-04-03_5.3-363bc9682621",
  product = "267416_2024-04-03_5.3-363bc9682621"
  }
  }
- To manage your Cody Account, navigate to: https://sourcegraph.com/cody/manage
- OK Cody Account Information: {
  chat_limit = 0,
  chat_usage = 64,
  code_limit = 0,
  code_usage = 5105,
  cody_pro_enabled = true,
  username = "hamidreza4dev"
  }
- OK sg.nvim is ready to run

:checkhealth sg after exiting neovim:
sg:

- ERROR No healthcheck found for "sg" plugin.

after exiting neovim I cant access to sourcegraph commands like SourcegraphLogin or SourcegraphDownloadBinaries

Logs:
[ERROR Thu Apr  4 12:57:02 2024] /Users/hamidreza4dev/.local/share/nvim/lazy/sg.nvim/lua/sg/vendored/vim-lsp-rpc.lua:211: client_error: INVALID_SERVER_MESSAGE {
  code = 1,
  message = "Failed to discover repo: Failed to access a directory, or path is not a directory: ''"
}

Previously, I used NvChad for my configuration, but the problem disappeared after I switched from it. I also tested my previous configuration, and the problem persisted. However, you can review my configuration here.

I'm having the same problem too.. I'm using LazyVim
For me I have to call :CodyChat or any Cody command so that sg.nvim will be enabled and after that I can already use it again but when I exit neovim I have to do it again. I thought it was just me.

I've had the same problem and just resolved it by deactivating lazy loading for the sg.nvim plugin.
 {
    "sourcegraph/sg.nvim",
    lazy = false,
    dependencies = "nvim-lua/plenary.nvim",
    config = function()
      require("sg").setup()
    end,
  },

So the issue was that sg.nvim just wouldn't load at startup. I have no idea whether there are any triggers that would load the plugin at runtime though.


update cloudflared to 2018.11.0

Codecov Report

Merging #119 into 0.6.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            0.6.x     #119   +/-   ##
=======================================
  Coverage   57.37%   57.37%
=======================================
  Files          15       15
  Lines        1004     1004
=======================================
  Hits          576      576
  Misses        409      409
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3772bbd...3f5ede5. Read the comment docs.


Version 3 support

Currently halo only supports version 2.
That'll be nice if we add version 3 support for halo.
Best of luck.

Hi Amir, I believe Python 3 is already supported. I've tested it as well (see https://travis-ci.org/ManrajGrover/halo). Please let me know if you're facing any issue using the library on Python 3.

@AmirZero I installed this through pip, and found it doesn't work in Python 3, but if you grab the latest version (git clone ... ) it works.
For example:
from halo import Halo
import time
spinner = Halo(text='Loading', spinner='dots')
spinner.start()
i = 0
while i < 100:
    i = i + 1
    time.sleep(1)
spinner.stop()

using the pip version:
$ python3 spin.py
Traceback (most recent call last):
File "spin.py", line 3, in
spinner = Halo(text='Loading', spinner='dots')
TypeError: init() got an unexpected keyword argument 'text'
using latest version:
$ python3 spin.py
⠦ Loading

@strattner  Version of halo using pip to install is 0.0.5. So it doesn't support __init__ using keyword argument like Halo(text='Loading', spinner='dots'). Anyway, pip version is working in Python 3 :)

@strattner This should have been fixed now. Please reinstall the package and set version as 0.0.6. Let me know if you are still facing any issue.

@ManrajGrover looks good, thanks

FWIW I just installed via pip and works great under Python 3.5.2 --  :heart: this project!
@ManrajGrover thanks for creating and sharing this, you're a :star2:

@massenz @strattner Thank you for confirming. ❤
@JungWinter Thank you for helping in handling some of the issues. ❤
@massenz Thank you for your kind words! 😄
Closing this issue!


⚠ Bofrost.lu has degraded performance

In e55b26d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1216 ms

Resolved: Bofrost.lu performance has improved in d0d4a65 after 38 minutes.


nextest: support cancel libtest-mimic tests

Currently they cannot be cancelled in a timely manner.

should be fixed by https://github.com/nextest-rs/nextest/pull/465

Oh wait I didn't test libtest-mimic


Separate release versions for Core Modules

Core modules, including:

Desktop Broker
.Net client
JS client
Metadata (Language/Grammar/Validation)
must have separate versioning with sermver compliant releases

Hi @udalmik,
Can you have a conversation with @paulwhitby on whether this is a dependency for FINOS activation or whether can be placed on the Plexus-Interop backlog as a future roadmap item.
Many thanks,
James.

I have reduced the priority to medium until a conversation with @paulwhitby takes place to re-prioritise according to FINOS activation criteria.

I have added @paulwhitby and @kryusvy to this story.

This item is not a blocker for activation, we can release 1.0 during activation and add separate versioning on top of that later.


New issues in this repo should get an untriaged label

Is your feature request related to a problem? Please describe.
New issues that haven't been looked at cannot be distinguished. I manually added an untriaged label for this one, but this should be automatic.
Describe the solution you'd like
Similar to other plugins, change templates to create issues with "untriaged" label to sort through what's new.

@dblock - Added missing label as part of this PR: https://github.com/opensearch-project/cross-cluster-replication/pull/260
Closing this issue.


Add toleration with toleration seconds condition

This PR adds the condition that the tolerations with toleration seconds.
Ref: https://github.com/kubernetes/kubernetes/issues/92170#issuecomment-696137048

/assign @alculquicondor

ping for the last review comments

ping for the last review comments

Sorry I have to say, with my poor english, I can't do Other than that, we have to stress the fact that, even with "tolerationSeconds", this is still a toleration, and for that reason the Pod can get scheduled in the same node again. in a standard format.
I'll leave this to other contributors :)

Thanks for the progress @zhouya0

Hi @zhouya0 .
Thanks for contributing!
What do you think about accepting the suggested changes?

/close
No response from author for a long ... time.