[SPARK-16436][SQL] checkEvaluation should support NaN

What changes were proposed in this pull request?
This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons.
How was this patch tested?
This is a test harness change.

cc @cloud-fan

Test build #61955 has started for PR 14103 at commit 0278dea.

Test build #61955 has finished for PR 14103 at commit 0278dea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61955/
Test PASSed.

Merged build finished. Test PASSed.

Test build #61966 has started for PR 14103 at commit ea0e91b.

Test build #61966 has finished for PR 14103 at commit ea0e91b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61966/
Test PASSed.

thanks, merging to master!


Create tool to import HRDF text files into DB

schema to be defined
for HRDF 5.40
Python? (via Docker)
SQLite as DB

If useful for you and the following work, the OK for me.

Works for me. I think we will need an internal representation for some analysis and tools.

Added also Docker support, also updated documentation for HRDF DB importer in https://github.com/openTdataCH/OJP-Showcase/tree/develop/hrdf-tools => closing as DONE

Added also Docker support, also updated documentation for HRDF DB importer in https://github.com/openTdataCH/OJP-Showcase/tree/develop/hrdf-tools => closing as DONE


Getting OpenMP with vcpkg?

How do I get OpenMP using vcpkg. I have searched online ,but haven't found the answer to my question. I'm trying to build something that requires the following and I have all of them but OpenMP. Or is this something that can't be get with vcpkg?
Dependencies

Require: Boost, GLM, Eigen Optional: TBB, OpenMP

OpenMP is not a third party library. A such it is not available in vcpkg.
OpenMP is something which the compiler you intend to use must support.
(It is basically a language extension using a lot of #pragmas)
see https://www.openmp.org/
or https://en.wikipedia.org/wiki/OpenMP

OpenMP is integrated with Compiler(gcc, clang, MSVC...). It is not a third party library. So it is could not get by vcpkg.

How do I get OpenMP using vcpkg. I have searched online ,but haven't found the answer to my question. I'm trying to build something that requires the following and I have all of them but OpenMP. Or is this something that can't be get with vcpkg?
Dependencies

Require: Boost, GLM, Eigen Optional: TBB, OpenMP

Just add  in CMakeLists.txt
find_package(OpenMP REQUIRED)


Support DelayedCloseTimeout

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

The delayed close timeout is for downstream connections managed by the HTTP connection manager.
 It is defined as a grace period after connection close processing has been locally initiated
 during which Envoy will wait for the peer to close (i.e., a TCP FIN/RST is received by Envoy
 from the downstream connection) prior to Envoy closing the socket associated with that
connection.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

/assgin

/assign

hey @bjlhlin please wait until the help-wanted has been added to assign yourself to the issue
this issue will need to be triaged first


Expose more functions at API for bodies

The following functions aren't exposed and the body can't change these unless destroyed and recreated.
void b2Body::SetBullet(bool flag);
bool b2Body::IsBullet() const;
void b2Body::SetAwake(bool flag);
void b2Body::SetFixedRotation(bool flag);
bool b2Body::IsFixedRotation() const;

Duplicate of #111


Waiting for afterEach in BeforeAndAfter and friends?

Hi.
I'm currently trying to implement log redirection to files for our test suites, based on Scalatest 3.2.2. The redirection replaces System out and err, and also replaces the two Console streams.
I'd like to do this by overriding TestSuite.runTest, since I can then do something like
set System out/err
set Console via withOut/Err
super.runTest
reset System out/err

I seem to hit an issue doing this, where some afterEach logs end up in the console instead of my file, and I suspect it is because afterEach is being run asynchronously as an withAfterEffect, rather than just having it be invoked directly.
https://github.com/scalatest/scalatest/blob/df4981ed793b66576d8f634443fe4aa91a971908/jvm/core/src/main/scala/org/scalatest/BeforeAndAfterEach.scala#L245-L248
As far as I can tell, if the test is sufficiently short that it finishes before the afterEach is registered for execution, the afterEach will run after the test status is marked completed. This means there is no way for me to wait for the afterEach'es to complete before I reset the streams. waitUntilCompleted will return too early, since the afterEach may run after the status is completed.
Is there a hook I'm missing that will allow me to wait for all queued tasks to complete, before I continue to line 4 in my snippet?

Relevant snippets:
The latch is counted down before some tasks are executed
https://github.com/scalatest/scalatest/blob/df4981ed793b66576d8f634443fe4aa91a971908/jvm/core/src/main/scala/org/scalatest/Status.scala#L620-L624
waitForCompleted only waits for the latch to count down.
https://github.com/scalatest/scalatest/blob/df4981ed793b66576d8f634443fe4aa91a971908/jvm/core/src/main/scala/org/scalatest/Status.scala#L713-L714
Would it be an option to make waitForCompleted wait for the latch to count down, and also for the queue to be empty?

@srdo the afterEach code should not be executed until after each test completes, so if it doesn't that's a bug. But one other thing to check is since there's just one Console, you need to make sure you are running both tests and suites sequentially. The default in sbt is to run suites in parallel. Can you check whether perhaps more than one test is running at a time in parallel, either with ParallelTestExecution or just the default behavior of sbt?

I am running a single test suite with 1 test case in it.
Here's my runTest in a BeforeAndAfterEach subclass:
  protected override def runTest(testName: String, args: Args): Status = {
    if (!sys.env.contains("REDIRECT_TEST_OUTPUT_TO_FILES")) {
      super.runTest(testName, args)
    } else {
      val oldStdOut = System.out
      val oldStdErr = System.err
      val outputDir = Paths.get("target/test-output")
      Files.createDirectories(outputDir)
      val outPath = outputDir.resolve(s"${suiteName}-'${testName.replace("'", "'\''")}'-output.txt")

      Using.resource(new PrintStream(new FileOutputStream(outPath.toFile, false), true, StandardCharsets.UTF_8)) { outStream =>
        try {
          System.setOut(outStream)
          System.setErr(outStream)
          Console.withOut(outStream) {
            Console.withErr(outStream) {
              val status = super.runTest(testName, args)
              status.waitUntilCompleted()
              status
            }
          }
        } finally {
          System.setOut(oldStdOut)
          System.setErr(oldStdErr)
        }
      }
    }
  }

What I am seeing is that if the test case is fast, I will sometimes end up running the System.setOut part before afterEach executes, observable as some log lines from afterEach ending up in the console and not in the file. If I put a sleep in after status.waitUntilCompleted(), the log lines consistently go in the file.

@srdo withFixture may be a better lifecycle method to override in this case. Did you try overriding withFixture rather than runtTest? In the case of runTest you have a Status, so you would want to register on the Status a task of execution of code to run after the test completes.

@bvenners withFixture is probably a better fit, but as far as I can tell, the fixture runs after beforeEach/afterEach. Wouldn't I have to rewrite all my test classes to use withFixture instead to make this work?
The ordering appears to be:
beforeEach
withFixture
afterEach

so that doesn't really work for this use case.
Regarding registering a task on Status, the issue is that since afterEach is also registered as a task and there is no ordering guarantee between tasks, I can't ensure that the stream reset runs only once afterEach has completed.

Oh, I finally understand what you're after. Could you perhaps change Console in beforeAll and afterAll instead, by mixing in BeforeAndAfterAll? The other thing is you can do this in one trait  that extends SuiteMixin and declares Suite as a self type, then just mix that trait into all of your test classes.

I can definitely do that for System, but as far as I know Console does not allow setting the streams in an unbounded scope. It is only possible to set the streams for a limited scope using the withOut/Err methods.
https://www.scala-lang.org/api/current/scala/Console$.html
I might be able to live with not redirecting Console, but it's a little unfortunate. It seems like Console binds the current values of System.out and System.err when created, so switching those streams doesn't directly affect Console (i.e. it will keep writing to stdout even if you change System.out)

The other thing is you can do this in one trait that extends SuiteMixin and declares Suite as a self type, then just mix that trait into all of your test classes

Could you elaborate? I don't think I follow.

I see, I think the way to achieve what you want given Status are async, and there's no order guaranteed for tasks, si to use withFixture for all your fixtures rather than beforeEach and afterEach. Then you can compose in a trait that does the console redirecting around those test suite specific withFixtures.
An example of creating a mixin trait, these for overriding withFixture, is here:
https://www.scalatest.org/user_guide/sharing_fixtures#composingFixtures

Ok, I guess we will have to do that. Thanks for your help :)
Just to pick a bit more at an earlier question before we go with this solution: Would it be an option to make Status.waitForCompletion also wait for the queued tasks to finish? That would make it possible to implement this via runTest, and I'm not sure there is a downside?

@srdo I'll think about that, but I don't think we can't tell when tasks complete on Scala Future, without a lot of extra machinery.

Would something like
def waitUntilCompleted(): Unit = {
    latch.await()
    setCompletedMutex.synchronized {
      require(queue.isEmpty)
    }
    ...

work? I think if the latch is counted down, and it is possible for us to acquire the setCompletedMutex lock, then the queue will be empty, and it is guaranteed that any other tasks that might be submitted after that will run on the submitting thread.
This would guarantee that afterEach will have run by the time waitUntilCompleted returns in my example code above, since it will have been submitted prior to the call to waitUntilCompletion.


Use relative tokenUrl parameter for JWTAuthentication (and docs)

Currently the JWTAuthentication docs page doesn't document the tokenUrl parameter, although it does document all its other parameters.
When/if this gets added, it would be worth mentioning that the tokenUrl must be relative (i.e. no prefixing '/') if a custom root_path is being used within the FastAPI app.  This is because, if an absolute tokenUrl is used instead, then the URL of the token route will be relative to the root_path, but the URL in the OpenAPI spec (which is derived from tokenUrl) will instead be relative to the base of the URL.  Then any front-end which parses the OpenAPI spec for authentication (e.g. Swagger) won't be able to find the correct URL.
This is currently documented in the FastAPI docs (see first tip), but would be worth mentioning in the FastAPI-Users docs as well.
Also, I think it would be worth changing the default value of tokenUrl from "/token" to "token", because the relative URL works both without and with a custom root_path.  In addition, the full examples could be changed to reflect this too.

Thank you for pointing this out, @eddsalkield! I wasn't aware of that subtlety; it seems it has been introduced around July 2020, but I never saw that.
That's indeed something we should mention in the docs!

@eddsalkield I've put up some changes in #636. Would you mind have a look at it and tell me if it sounds okay for you? 🙂

Thanks for this - I think this looks good overall.  However, I've left a couple of minor comments in a review for the PR.


fio: KeyError: 'fio_run_for_minutes' after flag define was removed

PR #1066 removed the flag fio_run_for_minutes but all the references were not removed.
Specifically in this line:
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/linux_benchmarks/fio_benchmark.py#L133
Now WarnOnBadFlags() fails with a KeyError when --fio_jobfile is set due to fio_run_for_minutes not being defined.

Thanks for catching this - I verified that the above PR fixes this behavior


wordWrapColumn setting behaves weirdly with Toggle Wordwrap

VSCode Version: Code 1.10.0 (49129d126e2c3c5592cfc8a509d872067b69d262, 2017-03-01T15:59:13.140Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions: All extensions disabled

Steps to Reproduce:

In user/workspace settings, set "editor.wordWrap": "wordWrapColumn" and "editor.wordWrapColumn": 120
Pressing ALT+Z to toggle word wrap will toggle between no wrapping at all, and wrapping at viewport width. It is only possible to go back to wrapping at 120 columns by reopening the file

I'd expect that with wordWrap set to wordWrapColumn, Toggle Word Wrap would toggle between no wrapping, and wrapping at wordWrapColumn

Similar problem happens on macOS Sierra 10.12.3 with Code 1.10.2.
I have tested it on a fresh VM. No extensions were installed.
Steps to reproduce:

Make two plain text files containing long lines.
Select one text file and press 'Option + Z' shortcut to wrap lines. It seems to works.
Select the other text file. The word-wrap is suddenly turned off.
Select the text file on setp-2 again. The word-wrap is also turned off.

@ghjang I am also seeing this on Windows 7, with source code files and with plain text files.


Promote gallery element keys into their wrapper divs

Unless every direct child of the gallery has a key element, every time the set of children changes, every child will be re-rendered, which leads to scroll state confusion and bad performance of the gallery.
So, let's promote up the child's key if one is set. As the html! macro lacks a way to only set a property conditionally (as for optional props like key), this requires rewriting the wrapping logic to use the virtual DOM directly.
Fixes #148

I think there may be a few more places in yew where child elements are wrapped like this; I'm not fixing those in this PR but I think a pass through the various places that do would improve performance & behavior of those elements too.

Want me to perform a new release?

I've got a follow-up PR to this, where we use wrapper_div_with_attributes in the other child-wrapping components. Should have it ready in the next few hours!


About pytorch-lightning version

Thanks for the good work!
I tried the code but found that "from lightning import LightningModule" does not work. I changed it to "from pytorch_lightning import LightningModule" and it worked for me. Not sure if it is a bug or not.

Thanks for your comment!
PyTorch Lightning has been renamed to Lightning after 2.0, while PyTorch Lightning can still be installed as a standalone framework for backwards compatibility with Lightning 2.0.
For more details, please refer to https://github.com/Lightning-AI/pytorch-lightning/discussions/16688

Thanks for your comment!
PyTorch Lightning has been renamed to Lightning after 2.0, while PyTorch Lightning can still be installed as a standalone framework for backwards compatibility with Lightning 2.0.
For more details, please refer to https://github.com/Lightning-AI/pytorch-lightning/discussions/16688

Thanks for the reply!
May I ask what is the similarity computation method used for kTrans?
I implemented kTrans to generate function embeddings, and use cosine similarity to calculate distance:
import torch.nn.functional as F
...
F.cosine_similarity(vector1, vector2, dim=1)
vector1 and vector2 are the generated embeddings.
However, I found that the similarity tends to be very high. Particularly, two completely unrelated functions can have similarity above 0.9. Is it the problem with my similarity computation method? What is the similarity computation method used in the paper, or what is the recommended similarity metric?
Many thanks!

Thanks for your comment!
PyTorch Lightning has been renamed to Lightning after 2.0, while PyTorch Lightning can still be installed as a standalone framework for backwards compatibility with Lightning 2.0.
For more details, please refer to https://github.com/Lightning-AI/pytorch-lightning/discussions/16688

Thanks for the reply!
May I ask what is the similarity computation method used for kTrans?
I implemented kTrans to generate function embeddings, and use cosine similarity to calculate distance:
import torch.nn.functional as F ... F.cosine_similarity(vector1, vector2, dim=1)
vector1 and vector2 are the generated embeddings.
However, I found that the similarity tends to be very high. Particularly, two completely unrelated functions can have similarity above 0.9. Is it the problem with my similarity computation method? What is the similarity computation method used in the paper, or what is the recommended similarity metric?
Many thanks!

We use dot product in kTrans and jTrans, which should be equivalent to cosine similarity. You can check the code here.
While this problem could have multiple reasons such as  the calculation method of similarity, architecture or code optimization, etc.

Thanks for your comment!
PyTorch Lightning has been renamed to Lightning after 2.0, while PyTorch Lightning can still be installed as a standalone framework for backwards compatibility with Lightning 2.0.
For more details, please refer to https://github.com/Lightning-AI/pytorch-lightning/discussions/16688

Thanks for the reply!
May I ask what is the similarity computation method used for kTrans?
I implemented kTrans to generate function embeddings, and use cosine similarity to calculate distance:
import torch.nn.functional as F ... F.cosine_similarity(vector1, vector2, dim=1)
vector1 and vector2 are the generated embeddings.
However, I found that the similarity tends to be very high. Particularly, two completely unrelated functions can have similarity above 0.9. Is it the problem with my similarity computation method? What is the similarity computation method used in the paper, or what is the recommended similarity metric?
Many thanks!

We use dot product in kTrans and jTrans, which should be equivalent to cosine similarity. You can check the code here. While this problem could have multiple reasons such as the calculation method of similarity, architecture or code optimization, etc.

Noted with thanks! I will try your code as well. : )


Remove warmings, cleanup & DRY up scripted commands

To validate this pull request against other sbt modules, please visit this link.

To validate this pull request against other sbt modules, please visit this link.

This is failing because using LList I can't read
{
  "projects": [
    {
      "name": "use",
      "scalaVersion": "2.12.1"
    },
    {
      "name": "dep",
      "scalaVersion": "2.12.1"
    }
  ]
}

Enhancement proposed in https://github.com/eed3si9n/sjson-new/pull/61.

To validate this pull request against other sbt modules, please visit this link.


YouTube video

[Enter feedback here]
Great document!
Just wanted to share that I've recorded a video on building this for three envs on YouTube https://youtu.be/8ZIt_DlNCoo
If you'd like you could put a reference to it in this page

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6fe11cd6-407f-3dd5-ba44-6a3a51e32943
Version Independent ID: 6fe11cd6-407f-3dd5-ba44-6a3a51e32943
Content: Automated API deployments using APIOps - Azure Architecture Center
Content Source: docs/example-scenario/devops/automated-api-deployments-apiops.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @rishabhsaha
Microsoft Alias: risaha

Thank you Hussein for creating community content!  It's great to see folks taking content like this and repackaging and retelling the story in other mediums.  We have an editorial policy that prevents us from linking to content like this, but please feel free to share in your network on LinkedIn or even on places like Microsoft Q&A if you can find a question that can benefit from your video as an answer.
Cheers
#please-close


Check for existence to avoid throwing an error when there is no default signature

Looks good, think you could write us a test as well? If you need help hop in the Gitter channel and we'll help ya with it :D

The existing test has been fixed to fail on error.  I verified that the test failed without my fix and passes with it.

Thanks for the PR!

Np.  Thanks for the merge.


PoS Validator Constants and Network Changes

Current dependencies on/for this PR:

feature/pos-networking-and-syncing

PR #876   👈

PR #768

PR #857

PR #858

PR #859

PR #860

PR #861

PR #792

PR #793

This stack of pull requests is managed by Graphite.


Cross-Namespace Service Discovery issue

Describe the bug
I am trying to invoke from serviceA in namespace1 to my serviceB in namespace2 in my k8 env. It works fine when I use SPRING_CLOUD_KUBERNETES_DISCOVERY_ALL_NAMESPACES: true(with clusterRole, clusterRoleBinding to the ServiceAccount they use)
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: cross-namespace-service-discovery
rules:
- apiGroups: [""]
  resources: ["pods", "services", "endpoints"]
  verbs: ["get", "list", "watch"]

  -----

  apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: cross-namespace-service-discovery-binding
subjects:
- kind: ServiceAccount
  name: default
  namespace: namespace1
roleRef:
  kind: ClusterRole
  name: cross-namespace-service-discovery
  apiGroup: rbac.authorization.k8s.io

  -------

  apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: cross-namespace-service-discovery-binding
subjects:
- kind: ServiceAccount
  name: default
  namespace: namespace2
roleRef:
  kind: ClusterRole
  name: cross-namespace-service-discovery
  apiGroup: rbac.authorization.k8s.io

but when i turn it off and use specific namespaces like below then it doesn't work and i see an error Service Instance cannot be null, serviceId: serviceB
- name: SPRING_CLOUD_KUBERNETES_DISCOVERY_ALL_NAMESPACES
   value: "true"
- name: SPRING_CLOUD_KUBERNETES_DISCOVERY_NAMESPACES_0
   value: namespace1
- name: SPRING_CLOUD_KUBERNETES_DISCOVERY_NAMESPACES_1
   value: namespace2

spring-cloud-starter-kubernetes-fabric8 version is : 3.0.5
However with specific namespace, I do see logs says but somehow the restTemplate returns this error.
2024-07-08T08:51:59.290Z DEBUG [retail-onboarding,,] 1 --- [nio-8080-exec-3] .c.k.f.d.Fabric8DiscoveryServicesAdapter : searching in namespaces : [namespace1, namespace2] with filter : null

2024-07-08T08:51:59.336Z DEBUG [retail-onboarding,,] 1 --- [io-8080-exec-10] o.s.c.k.f.d.KubernetesDiscoveryClient    : will return services : [serviceA, serviceB, ingress-nginx-controller, ingress-nginx-controller-admission, kubernetes,]

2024-07-08T08:52:22.099Z ERROR [retail-onboarding,,] 1 --- [nio-8080-exec-9] c.b.f.i.a.RunWithoutAuthorizationAspect  : Exception thrown when invoking join point

com.backbase.audit.client.exceptions.InternalServerErrorException: java.lang.IllegalArgumentException: Service Instance cannot be null, serviceId: audit-service                                                                                Caused by: java.lang.IllegalArgumentException: Service Instance cannot be null, serviceId: serviceB

@ryanjbaxter I actually tried it locally with minikube and very small application setup(not the one above and also latest version) and it did worked there. However I noticed when it worked on my local i see these log lines from o.s.c.k.f.l.Fabric8ServicesListSupplier but no such logs on my client server when it fail actually to find that server id

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Unclear instructions

Below the line:
Then, add the following line to your $middleware array under app/Http/Kernel.php:
There is nothing in the docs on github.

The following code was probably accidentally removed in the latest commit:
\MagicTest\MagicTest\Middleware\MagicTestMiddleware::class

Seems like they inject it with:
$this->app['router']->pushMiddlewareToGroup('web', MagicTestMiddleware::class);

So this isn't necessary anymore.

You're correct. It no longer requires you to add a middleware :-)


ampy run doesn't work on Mac

Just setting up my Mac for working with the ESP32, and everything works great, except for ampy run /flash/test.py
Can anyone tell me what am I doing wrong?
Works perfectly on my windows machine

I figured it out... It's a "problem" with the "/flash" directory
ampy put test.py # puts test.py in the "/flash/test.py" folder of the esp32
ampy ls /flash # outputs "boot.py" and "test.py"
ampy run test.py # runs test.py from "/flash/test.py"
BUT
ampy put test.py /flash/test.py # looks like it puts test.py inside "/flash/test.py"
ampy ls /flash # outputs "boot.py" and "test.py"
Here's the BUT
ampy run test.py # fails with "FileNotFoundError: [Errno 2] No such file or directory: '/flash/test.py'"
same goes for
ampy run /flash/test.py
Another BUT:
ampy put main.py /flash/main.py, has the same behavior as described above, put it actually does run as a normal main.py file on bootup
Can be a little confusing

Should maybe change the title to reflect, that it is not a Mac problem, but more a problem with the "/flash" folder on the esp32?


[Feature]: Slurm run_cluster.sh launcher instead of just Ray

🚀 The feature, motivation and pitch
As much as I like Ray, is there any plans to support launching with SLURM too? on most clusters, only have slurm & aren't ray clusters
Alternatives
continue only supporting ray with this script
Additional context
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

It is possible to run Ray on Slurm using this guide: https://docs.ray.io/en/latest/cluster/vms/user-guides/community/slurm.html


aws: tag_all should be excluded in the generated resource

It looks like currently in the generated the resource it has tag_all ready only attribute. So instead of having
resource "aws_vpc" "example" {
  # ... other configuration ...

  tags = {
    Name = "MyVPC"
  }

  tags_all = {
    Name = "MyVPC"
  }
}

The generated resource would be like this:
resource "aws_vpc" "example" {
  # ... other configuration ...

  tags = {
    Name = "MyVPC"
  }

}

This may be linked to workaround https://github.com/hashicorp/terraform-provider-aws/issues/18311

I am a fan of seeing a distinction of the source of the tags by resource items vs tags_all which is based upon the provider's default_tags and the resources tags (but prioritizes the items within default_tags) - perhaps indicating in the generated resource it is read only may do the trick?
Also re-naming default_tags to something more descriptive based upon the nature of what it does maybe wise; such as enforced_tags - though last I checked some resources that have a tags input do not always get default_tags items.


The extension doesn't work in the latest version fo Brackets, 1.8

I get the following error:

I tried uninstalling and reinstalling and got the same error.

Try restarting brackets after installing.
What's the error in error console? (F12)

https://github.com/adobe/brackets/issues/12897

Fix this after reinstall brackets and brackets-git

Same issue. Win10 Brackets1.8
I can't uninstall it neither.

I tried to delete the extension manually in C:\Users\YOURNAME\AppData\Roaming\Brackets\extensions\user
But after, reinstall, I had the same issue.
Note:
I guess you're working more on Brackets-Electron now, and not on this king of compatibility problems... :(
With Brackets-Electron, you are making a EXELLENT job, it is way more FASTER on windows than the normal Brackets (at least, 2 times less to open or switch file) this is so great.
I hope normal Brackets will follow your updates more closer !
Just wanted to say !

@profstein @Cactusx09 @AgamlaRage This is not a problem of Brackets-Git, but of Brackets itself when upgrading. Multiple people reported that clearing cache folder helps to get it running. Try deleting these:

I deleted the Brackets cache like you said
This is insane, that fix my problem with brackets-git and my files are now loading as fast as in Brackets-Electron.
Thank you so much ! <3

Resetting the Cache didn't solve my problem.
When I looked at the developer tools I saw this error (Emmet was not loading either):

I had a couple of other errors there node related. So I tried to update node and found out that I didn't have XCode Command Line tools (MAC). I think that the latest MAC OS Upgrade changed something. So I Installed the command line tools again and then updated node. Then I opened Brackets and restarted with extensions and everything (Brackets Git and Emmet) seem to be working now.
Not sure if it was the command line tools or node or both but it seems that my problem stems not from Brackets or the extension but from the OS upgrade which I just happened to do just before the Brackets upgrade.

Thanks a lot @profstein , that might help some people!

I am getting similar issue and noticed that thirdparty/urijs.browser.js and few other files are missing in the downloaded 'brackets-git-master.zip'.

You can't just download zip file from github, that's not a valid installation procedure. Use extension registry.

I've unchecked "Remove BOM" option and checked "Add endline after eof", but Brackets still remove BOM and doesn't add line. What am I doing wrong?

@Dimonasdf can't replicate your problem and also that's another issue not related to above. Closing this thread.


Add activation flow preference test

Add a test tom for the preferred activation flow query params
https://github.com/OpenConext/Stepup-SelfService/pull/336

These changed are merged with: https://github.com/OpenConext/OpenConext-devconf/pull/22


Fix semicolon rule on last line without EOF line.

PR checklist

[x] New bugfix

[x] Includes tests

Overview of change:
Currently when using "semicolon": [true, "never"] rule if semicolon is used in last line without next EOF line then linting fails with error:

Warning: Cannot read property 'kind' of undefined

because here util.getNextToken() return value is not tested for undefined.
I put tests in separate directory and not in semicolon/never/test.ts.* to avoid accidental appending to that files that will ruin this test.
CHANGELOG.md entry:
[bugfix] semicolon

@mxl Thank you for taking the time to analyse and fix this bug.
Unfortunately that has already been done as part of a bigger change in #2655. That one also includes similar regression tests.

@ajafff Glad to hear that!


Add tab support in structuredd lg

fix: #2712

Pull Request Test Coverage Report for Build 82877

0 of 0   changed or added relevant lines in 0 files are covered.
764 unchanged lines in 102 files lost coverage.
Overall coverage remained the same at 77.283%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Twilio/TwilioAdapter.cs
1
85.71%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
95.45%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs
1
96.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs
1
96.5%

/libraries/Microsoft.Bot.Builder/BotStateSet.cs
1
85.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs
1
46.15%

/libraries/Microsoft.Bot.Builder.Dialogs/Memory/Scopes/MemoryScope.cs
1
88.37%

/libraries/Microsoft.Bot.Builder.Dialogs/PersistedStateKeys.cs
1
60.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/PromptValidatorContext.cs
1
82.35%

Totals

Change from base Build 82871:
0.0%

Covered Lines:
7583

Relevant Lines:
9812

💛  - Coveralls


Modin do not casts 'int' to 'str' at read_csv when Pandas do

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Any
Modin version (modin.__version__): 0.8.0
Python version: 3.7.5
Code we can use to reproduce:

if __name__ == "__main__":
    import pandas
    import modin.pandas as pd
    from modin.pandas.test.test_io import (
        TEST_CSV_FILENAME,
        df_equals,
    )

    pandas.DataFrame({"col": ["str", 0, 1, 2]}).to_csv(TEST_CSV_FILENAME)

    md_df = pd.read_csv(TEST_CSV_FILENAME)
    pd_df = pandas.read_csv(TEST_CSV_FILENAME)

    try:
        df_equals(md_df, pd_df)
    except Exception as e:
        print(e)  # numpy array values are different (75.0 %)

    print(type(md_df["col"].iloc[1]), md_df["col"].iloc[1]) # <class 'numpy.int64'> 0
    print(type(pd_df["col"].iloc[1]), pd_df["col"].iloc[1]) # <class 'str'> '0'

Describe the problem
When any string value appears in column Pandas casts all values to a string then, but Modin don't do that, so we're getting mismatch with Pandas

This still seems to be a problem on master. See the output:
DataFrame.iloc[:, 1] (column name="col") are different

DataFrame.iloc[:, 1] (column name="col") values are different (75.0 %)
[index]: [0, 1, 2, 3]
[left]:  [str, 0, 1, 2]
[right]: [str, 0, 1, 2]
<class 'numpy.int64'> 0
<class 'str'> 0

The problem seems to be associated with dataframe partitioning.
For example, if we use the dataframe pandas.DataFrame({"col": ["str", 0, 1, 2, 3, 4, 5]}). We save it as a csv and load it into python using md_df = pd.read_csv(TEST_CSV_FILENAME). Given that the dataframe is split into 3 partitions in modin, it would look like this:
A = index    col        B = index    col        C = index    col
        0  'str'                0      2                0      4
        1    '0'                1      3                1      5
        2    '1'

Pandas usually casts all values in a column to strings if at least one value is a string. Using modin, all values in a column are cast to strings if at least one value in the same partition is a string. Otherwise values are left as is.
I attempted to implement a naive solution by iterating through all columns of all partitions and casting the column with astype() if the partition dtype and modin dataframe dtype were different. However, this resulted in significantly slower speeds for read_csv()
read_csv on modin with no changes: 231 seconds
read_csv csv on modin with changes: 282 seconds
read_csv on pandas: 331 seconds
A more efficient solution should be achievable by running the column type casting in parallel.

Works on latest master for me so closing.


Hard to differentiate NewApp from OldApp logs

Problem

Native logs for New Expensify app are prefixed with [mobile] for some reason
This can make it hard to tell if the log is from OldApp or NewApp

Solution
Use some other kind of prefix for logs coming from NewApp - maybe [app-native] instead of [mobile]

on production and much easier to tell the difference now!


importNmModData does not seem to handle (format) option

File https://github.com/MangoTheCat/RNMImport/blob/master/tests/unittests/testdata/subprob1.mod contains a sub-problem where the $DATA record includes information about the FORTRAN format specification. This information is parsed into the filename statement which is incorrect.
$PROB ESTIMATION
$INPUT ID TIME DOSE DV
$DATA simulation (4E12.0) NRECS=500 NOOPEN

Note that the NOOPEN option is also not parsed.


Eslint + Prettier +Airbnb Style issue#10

Summary
Tools like ESLint and Prettier makes it easier for developers to enforce their team's chosen coding standards.
Describe the solution you'd like

[x] Setup Eslint
[x] Setup Prettier
[x] Airbnb Style

Extras
We could try adding husky and lint-staged, we are already discussing it here.
Author
@ditsuke @KshitijDarekar

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

Additional Info
This PR closes issue#10

Make sure to pull recent changes from origin:main. Consider using pull on your forks to make they're up to date

Make sure to pull recent changes from origin:main. Consider using pull on your forks to make they're up to date

Fixes out in a PR to the parent branch!

Merge ready!

Merge ready

Rebased to 67d8e8b

Sorry, I forgot to squash the commits and had to revert this merge! We'll need a PR for this again!


Parsing Error When Defining Scenario After Scenario Outline

Adding a scenario or scenario outline after an existing scenario outline generates a parser error.  For instance, the following feature file runs successfully when defined in this order
Feature: Launching applications
As an electronic hobbyist
I want to launch the serial bridge
In order to send data to the component server
Scenario: Abort when no worker is specified
Given the application is called without specifying a worker
Then an error indicating a worker needs to be specified is displayed
Scenario Outline: Launch the target worker
Given the application is called invoking the "" worker
Then the "" worker runs
Examples:
| target    |
| server    |
| bridge    |
| simulator |
if the order of the scenario and scenario outline is changed, then parser errors are generated
Feature: Launching applications
As an electronic hobbyist
I want to launch the serial bridge
In order to send data to the component server
Scenario Outline: Launch the target worker
Given the application  is called invoking the "" worker
Then the "" worker runs
Examples:
| target    |
| server    |
| bridge    |
| simulator |
Scenario: Abort when no worker is specified
Given the application is called without specifying a worker
Then an error indicating a worker needs to be specified is displayed
Parser errors generated
scenario: Abort when no worker is specified
Error: Did not expect line: Scenario: Abort when no worker is specified
Launching applications
   Given the application is called without specifying a worker

Error: Did not expect line: Given the applicaiton is called without specifying a worker
Launching applications
   Then an error indicating a worker needs to be specified is displayed

Error: Did not expect line: Then an error indicating a worker needs to be specified is displayed
Run has finished

Thanks for reporting @TheLandlord - I have added this to the mixed specifications test case and fixed the problem. Let me know if you have any problems with the fix, which is in v2.0.0.
Please note v2.0.0 has the breaking change of using decorators, not static step registration methods. This basically makes things more natural, but leans on the experimental decorators feature.
You can enable experimental decorators in your tsconfig.json
    "experimentalDecorators": true,


Title: Footer fix

Is your feature request related to a problem? Please describe.
Yes, the feature is related to the problem. Your footer is not not the exact place as it has space beneath it.
Describe the solution you'd like.
I will add the required CSS to put it in its place.
Describe alternatives you've considered.
N/A
Add any other context or screenshots about the feature request here.

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Already assigned before


gatsby-source-prismic - invalid plugin options

I get the error below when trying to run a build. Working in dev is fine.
gatsby-source-prismic - invalid plugin options

Failed to validate error Error [ValidationError]: child "type" fails because ["type" must be one of [GRAPHQL, CONFIG, WEBPACK, PLUGIN]]
    at Object.exports.process (/Users/elliotkidd/projects/kick-snare/node_modules/@hapi/joi/lib/errors.js:202:19)
    at internals.Object._validateWithOptions (/Users/elliotkidd/projects/kick-snare/node_modules/@hapi/joi/lib/types/any/index.js:763:31)
    at internals.Object.validate (/Users/elliotkidd/projects/kick-snare/node_modules/@hapi/joi/lib/types/any/index.js:797:21)
    at constructError (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby-cli/lib/structured-errors/construct-error.js:52:32)
    at Reporter.error (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby-cli/lib/reporter/reporter.js:135:59)
    at Reporter.panic (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby-cli/lib/reporter/reporter.js:75:34)
    at Object.webhookBody [as panic] (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby/src/utils/api-runner-node.js:201:16)
    at Object.exports.sourceNodes (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby-source-prismic/src/gatsby-node.ts:160:8)
    at runAPI (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby/src/utils/api-runner-node.js:460:22)
    at Promise.catch.decorateEvent.pluginName (/Users/elliotkidd/projects/kick-snare/node_modules/gatsby/src/utils/api-runner-node.js:611:13)
    at Promise._execute (/Users/elliotkidd/projects/kick-snare/node_modules/bluebird/js/release/debuggability.js:384:9)
    at Promise._resolveFromExecutor (/Users/elliotkidd/projects/kick-snare/node_modules/bluebird/js/release/promise.js:518:18)
    at new Promise (/Users/elliotkidd/projects/kick-snare/node_modules/bluebird/js/release/promise.js:103:10)
    at /Users/elliotkidd/projects/kick-snare/node_modules/gatsby/src/utils/api-runner-node.js:609:16
    at tryCatcher (/Users/elliotkidd/projects/kick-snare/node_modules/bluebird/js/release/util.js:16:23)
    at Object.gotValue (/Users/elliotkidd/projects/kick-snare/node_modules/bluebird/js/release/reduce.js:166:18) {
  isJoi: true,
  details: [
    {
      message: '"type" must be one of [GRAPHQL, CONFIG, WEBPACK, PLUGIN]',
      path: [Array],
      type: 'any.allowOnly',
      context: [Object]
    }
  ],
  _object: {
    context: {},
    value: undefined,
    type: 'string',
    path: [],
    branch: [ undefined ],
    failures: [Function: failures],
    pluginName: 'gatsby-source-prismic',
    text: 'There was an error',
    level: 'ERROR',
    stack: [],
    docsUrl: 'https://gatsby.dev/issue-how-to'
  },
  annotate: [Function (anonymous)]
}

What is child "type" that is causing this?
In my gatsby.config I have:
{
	resolve: 'gatsby-source-prismic',
	options: {
		repositoryName: process.env.PRISMIC_REPOSITORY_NAME,
		accessToken: process.env.PRISMIC_ACCESS_TOKEN,
		linkResolver: ({ node, key, value }) => (post) => `/${post.uid}`,
		schemas: {
			blog: require('./src/schemas/blog.json'),
		},
	},
},

Returning to Version 3.3.0 removed the error for me. At least temporarily :)

hmm, that hasn't seemed to help in my case.

I'm having the same problem, tried version 3.3.0 and 3.2.1. Any suggestions?

I managed to solve my issue, it was an error in my config.

Could you share your config @tudor2004? I've probably done the same thing...

Yes, so I had this in the config:
{
      resolve: "gatsby-source-prismic",
      options: {
          repositoryName: "myrepo",
          accessToken: `${process.env.API_KEY}`,
          linkResolver: () => prismicLinkResolver,
          htmlSerializer: () => prismicHtmlSerializer,
    },
    schemas: {
       // all the schemas here
    }
}

instead of this:
{
      resolve: "gatsby-source-prismic",
      options: {
          repositoryName: "myrepo",
          accessToken: `${process.env.API_KEY}`,
          linkResolver: () => prismicLinkResolver,
          htmlSerializer: () => prismicHtmlSerializer,
          schemas: {
             // all the schemas here
          }
    }
}

notice the "schema" block not being inside the "options" block.

I have the  same problem when i try to deploy on Netlify

I have the  same problem when i try to deploy on Netlify

I ran into this issue when migrating from the @prismico/gatsby-source-prismic-graphql plugin to this one. In the process of migrating my htmlSerializer.js file from es6 to CommonJS (because of where it's now used), I mistakenly exported it as:
exports = function htmlSerializer(type, element, content, children) {
    ...
}

instead of
module.exports = function htmlSerializer(type, element, content, children) {
    ...
}

So it turned out to be a config problem on my part because I'm a lil rusty with CommonJS 😅 Changing my default exports to the latter resolved my issue.

I ran into this issue when migrating from the @prismico/gatsby-source-prismic-graphql plugin to this one. In the process of migrating my htmlSerializer.js file from es6 to CommonJS (because of where it's now used), I mistakenly exported it as:
exports = function htmlSerializer(type, element, content, children) {
    ...
}

instead of
module.exports = function htmlSerializer(type, element, content, children) {
    ...
}

So it turned out to be a config problem on my part because I'm a lil rusty with CommonJS 😅 Changing my default exports to the latter resolved my issue.

FYI, missing .env.production during build can cause this too :)

Invalid plugin options for "gatsby-source-prismic":

gatsby-source-prismic(ellipsis-drive) - JSON model for "episode" is missing. If the Custom Type is no longer in use, you
may provide "{}" as the JSON model.
gatsby-source-prismic(ellipsis-drive) - JSON model for "article_cta" is missing. If the Custom Type is no longer in use,
you may provide "{}" as the JSON model.


Incremental templating

Idea : allow the same template to be applied several times on different models based on the template name matching.
For example: a template matching all @DataObject would be able to generate all cheatsheets in a single file instead of multiple files.
When rendered a template would be notified of:
1/ the first invocation
2/ the last invocation
The template state would be maintained over calls, except the state created by the model (vars) that would be overwritten.

it could also be used in Ceylon to generate module.ceylon from the various class models to generate the correct module imports.


Evidence of higher steering torque for Honda's

After speaking with @rbiasini yesterday about recent observations in my Accord, I performed a simple test and captured a datalog (here).  In the log, from 0:42 - 0:46 the stock system overrides OpenPilot's steering commands somehow, and generates a much stronger steering result.  During that time, the steer_torque_motor parameter becomes much more significant, and its phase shifts ahead of the steer_torque_sensor parameter.  The steer_angle_rate also becomes much larger.
I suspect that there is more than 1 data stream that the EPS responds to, with different torque limits.  I think that Road Departure Mitigation might be the system in control here, since my HUD was flashing yellow lane lines.

There are lots of unmapped frames from the camera, but 0xE5 seems related.

Thanks for digging in to this!
The Cabana link you posted is only accessible by yourself. If you want everyone to be able to see it, when viewing the drive in Cabana, click "Copy Share Link" and then paste the URL from your clipboard. The URL should be much longer and have a url parameter in it.

e5 is indeed related (for Bosch only it seems). From my research, it appears to only control the wheel wobble during a LDW/Correction event. The radar combines e4 and e5 from the camera into a single e4 frame that gets sent to the EPS. (Look at e4 on bus 0)
On civic, the wobble occurs while e5 is active and the corrective torque is applied through e4 immediately after.
Regardless, we could make the wheel wobble part of the driver monitoring inattentive alert. I am experimenting with how to get wheel wobble and OP command torque, but without the warnings on the hud.

re Link" and then paste the URL from

Big oops ... I've updated the cabana link...  Thanks for pointing it out!

That is really good to know about the combination of the messages, but I think there's more to it than just the wobble.  The wobble seems like a first stage (Lane Departure Warning), but the next stage is much more impact-full and harder to reproduce.  I wouldn't necessarily consider this particular event to be second stage, but I do have a few cabana drives that capture it.  I've shared them on Slack, but they are long gone from history.  I'll see if I can dig them up again.

I found the most significant example(s) of apparent RDM intervention that I've ever experienced (here).  There were several episodes over a few minutes between 16:00 - 22:00 while I was on the highway.  Traffic was about as high as it could be at this speed.  The sun was in a very non-optimal position, and the lane markings on the highway suck.

This was the most intense episode, which resulted in a very fast 16+ degree adjustment in steering before I could grab the wheel.

I was able to capture better data (here) by putting OpenPilot into Passive mode, so that I could observe the stock RDM behavior more clearly.  This is with LKAS disengaged, but with the RDM set to "Narrow".
During this drive, I found that the steering system did "wobble" at first, then applied significant steering force back toward my lane.  There's a clear relationship between e4 and e5, and it appears that some bits currently defined as SET_ME_X00 and an undefined bit may change the EPS gain or mode.
Below is a screenshot of my dashboard, showing the binary view of 0xe4 and 0xe5 during a couple RDM engagements.  Note that the data has been down-sampled to 10 frames per second.

From cabana

Which e4 are you looking at? CAN 0 or 1/2?

The evidence in the original post is completely bogus. The signal identified as STEER_TORQUE_MOTOR is actually identical to STEER_ANGLE_RATE inverted. The rest of the data presented does not show anything conclusive and probably doesn't belong in a github issue. Feel free to discuss further in discord and submit a PR if you find something that works!

The data provided in the original post was not "bogus", but the DBC at the time did have incorrect labels for some signals (including STEER_TORQUE_MOTOR).
I'm circling back to this issue now, just to see if I can make any sense of the behavior, since I still believe there is a higher level of torque available for request by VSA.  Techinfo describes several VSA parameters that the EPS uses.

I specifically said the evidence in the original post was bogus, sure the data was real, but it was clearly interpreted incorrectly (since it was mislabeled and it is not torque) and this was specifically mentioned as the evidence.
Please use other places such as discord to discuss your theories, and I look forward to a PR if you find something useful!


fix partition prune

wrong case:
create table t (a DateTime, b UInt32) engine=BaseStorage partition by toYear(a)
insert into t values ('2020-01-01:08:00:00',1),('2021-01-01:08:00:00',1)
TensorBase :) select * from t where toYear(a)<>2020
SELECT *
FROM t
WHERE toYear(a) != 2020

Query id: d986e108-ea6a-42dc-8d18-3f261fa6e516

Ok.

0 rows in set. Elapsed: 6.991 sec.

also fix a related test case in integ_test.

@nautaa you find two problems here in fact:

what I said about datetime handling problem in part expr calculation. you can skip this(about lightjit, a little hard)
new fill_copainfos_int_by_ptk_range has bugs but the pruning result is right.

@nautaa your PR is a great catch for null partition logic handling! Thanks!


add option to turn warnings into errors

In my project whenever I build haddocks I seem to have many warnings of the form
Warning: Some.Module: could not find link destinations for:
Every once in a while I go through and fix them all, but I would prefer if I could have my continuous integration prevent these sort of regressions from going in in the first place. Is it currently possible to turn these warnings into errors? If not, what would it look like to add an option to enable this?

If I could get some guidance on this I'd be happy to contribute a patch.

Thanks for the feature request!
The particular warnings you mention come from here:
https://github.com/haskell/haddock/blob/1868443b01232d57ec11dfc831ac0a6915a2b337/haddock-api/src/Haddock/Interface.hs#L112-L114
But there are also warnings coming from here:
https://github.com/haskell/haddock/blob/1868443b01232d57ec11dfc831ac0a6915a2b337/haddock-api/src/Haddock/Interface.hs#L191
It would be quite nice to have a better reporting mechanism than a direct putStrLn. That mechanism could then be configured with a flag to error out when it encounters warnings (and perhaps even carry along more information with it than just a string). Since all warnings are emitted from inside Ghc, we might even be able to re-use some of GHC's machinery.

Here is what would be nice:

we add a new Opt_WarnMalformedHaddock constructor to GHC's WarningFlag for Haddock related warnings (perhaps we'll be able to re-use a future GHC warning for misplaced Haddocks)

Haddock can then generate warnings in any GhcMonad monad with
let msg = makeIntoWarning (Reason Opt_WarnMalformedHaddock) $
          mkWarnMsg dflags loc unqual $
          text "Looks like you might've done something wrong..."
logWarnings (unitBag msg)

We'd get two things for free: nicely coloured error messages (matching GHC's!) and the ability to set -Werror=malformed-haddock. This is also a good opportunity to add locations to error/warning messages.

@harpocrates, I submitted a new pull request at #969 that approaches this in the way we discussed on IRC.


Do not send local notifications if preference states so

~Hold on https://github.com/Expensify/Web-Expensify/pull/30875~
Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/161779
Tests
None yet, can I test this given we are not saving these yet?
QA Steps
None yet, can I test this given we are not saving these yet?
Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Bump!

@yuwenmemon added the test

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


NO-JIRA: CAPA: use v1beta2

Switch to using v1beta2 types for CAPA.
Also switch to using Ignition 3.4 + plain user data in AWS e2e tests.

Ran this in combination with https://github.com/openshift/cluster-capi-operator/pull/151
AWS CAPI E2Es passed successfully:
https://github.com/openshift/cluster-api-provider-aws/pull/499#issuecomment-1978489397

/test ci/prow/e2e-aws-ovn-serial

/test e2e-aws-ovn-serial

/hold
For controlling the merge

/assign @vincepri

/approve

ci/prow/e2e-aws-capi-techpreview is expected to fail until https://github.com/openshift/cluster-api-provider-aws/pull/499
Merges.
But https://github.com/openshift/cluster-api-provider-aws/pull/499 depends on this one to pass its tests.
Hence we'll accept ci/prow/e2e-aws-capi-techpreview failing and merge it so then 499 can start passing and merge to fix things.
/override ci/prow/e2e-aws-capi-techpreview
/unhold

/override ci/prow/e2e-aws-capi-techpreview

/tide refresh


Navigation: Home Page

@jhlink Oh I think I forgot to change the template name in views.py
I have made the changes now. Can you review them again?


[fix] [client] Fix Consumer should return configured batch receive max messages

Fixes #22618
Motivation
The consumer doesn't consider batch-receive policy and doesn't return number of batch-receive messages based on user configured number when max-batch messages are higher than internal queue size because consumer stops consuming messages when it hits internal receiver queue size and application always receives incorrect number of messages which can impact user application. Users are not aware of the internal client implementation and consumer client should work based on consumer configuration values.
Modifications
When user configures batch-receive max messages higher than the internal queue size then to support batch-receive configuration consumer should adjust the internal queue size accordingly to return expected batch-receive messages.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

test failure:
  Error:    ConsumerBatchReceiveTest.testBatchReceiveAndRedeliveryNonPartitionedTopic:381->testBatchReceiveAndRedelivery:563->batchReceiveAndRedelivery:633 expected [140] but found [100]

btw. The Pull Request Labeler has been fixed in master branch.

Error:    ConsumerBatchReceiveTest.testBatchReceiveAndRedeliveryNonPartitionedTopic:381->testBatchReceiveAndRedelivery:563->batchReceiveAndRedelivery:633

Batch-receive tests were failing because now test receives same number of messages as configured max-batch-messages instead having cap of queue-size. fixed tests with similar number of queue-size and batch-size as test assetion has hard-coded values in most of the tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.72%. Comparing base (bbc6224) to head (d537eac).
Report is 217 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22619      +/-   ##
============================================
- Coverage     73.57%   72.72%   -0.86%
+ Complexity    32624    32554      -70
============================================
  Files          1877     1887      +10
  Lines        139502   141005    +1503
  Branches      15299    15477     +178
============================================
- Hits         102638   102545      -93
- Misses        28908    30603    +1695
+ Partials       7956     7857      -99

Flag
Coverage Δ

inttests
27.09% <0.00%> (+2.51%)
:arrow_up:

systests
24.56% <0.00%> (+0.23%)
:arrow_up:

unittests
71.50% <100.00%> (-1.34%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...apache/pulsar/client/impl/ConsumerBuilderImpl.java
87.11% <100.00%> (+0.17%)
:arrow_up:

... and 341 files with indirect coverage changes


STYLE: Remove unused jacjjacj variable from ComputeUsingSearchDirection

The unused local jacjjacj variable appears to be introduced with commit e9de4b1281a07d2fdbaa96db865f3c7aaaf4e5d2 "ENH: manual syncing with the performance branch", 25 May 2016.
In other cases, such a variable is (post-)initialized by vnl_fastops::ABt(jacjjacj, jacj, jacj), but in this case, it was left uninitialized.

@mstaring FYI, I'll just merge this PR now, but if we ever want to have this unused variable (jacjjacj) back here (and actually use it), it's easy to put it back any time later.


Uglify Preserve Comments

Addresses suggestion: Preserve comments in d3.js (issue #2554)
https://github.com/mbostock/d3/issues/2554

This adds the --comments argument after the -o argument, causing an error. But more importantly, the --comments argument isn’t passed to UglifyJS because of our custom wrapper script. The correct fix is probably something like this in bin/uglify:
-    output = uglify.OutputStream({ascii_only: true}),
+    output = uglify.OutputStream({ascii_only: true, comments: true}),

That didn’t seem to do anything, though, and I’m not going to investigate it any further at the moment. Because…
D3 4.0 has a new build process using Rollup. This preserves comments and formatting (for the most part) in the generated file.


Config Editor page

Add a page that will show all installed config files and and allow for easy editing of those config files

Annoyingly, BepInEx seems to use a slightly modified version of the TOML config file standard meaning I will have to write a custom parser.
The only difference I've found so far is that BepInEx doesn't require quotes around value strings


update: python

Name: python
CVEs: CVE-2023-6597, CVE-2024-0450, gh-81194, gh-102388, gh-113659, gh-114572, gh-115243
CVSSs: 7.8, 6.2, n/a, n/a, n/a, n/a, n/a
Action Needed: update to >= 3.12.3, 3.11.9
Summary:

CVE-2023-6597: An issue was found in the CPython tempfile.TemporaryDirectory class affecting versions 3.12.2, 3.11.8, 3.10.13, 3.9.18, and 3.8.18 and prior. The tempfile.TemporaryDirectory class would dereference symlinks during cleanup of permissions-related errors. This means users which can run privileged programs are potentially able to modify permissions of files referenced by symlinks in some circumstances.

<EMAIL_ADDRESS>

CVE-2024-0450: An issue was found in the CPython zipfile module affecting versions 3.12.2, 3.11.8, 3.10.13, 3.9.18, and 3.8.18 and prior. The zipfile module is vulnerable to “quoted-overlap” zip-bombs which exploit the zip format to create a zip-bomb with a high compression ratio. The fixed versions of CPython makes the zipfile module reject zip archives which overlap entries in the archive.

<EMAIL_ADDRESS>

gh-81194: a crash in socket.if_indextoname() with a specific value (UINT_MAX) was fixed. Relatedly, an integer overflow in socket.if_indextoname() on 64-bit non-Windows platforms was fixed
gh-102388: iso2022_jp_3 and iso2022_jp_2004 codecs no longer read out of bounds
gh-113659: .pth files with names starting with a dot or containing the hidden file attribute are now skipped
gh-114572: ssl.SSLContext.cert_store_stats() and ssl.SSLContext.get_ca_certs() now correctly lock access to the certificate store, when the ssl.SSLContext is shared across multiple threads
gh-115243: Fix possible crashes in collections.deque.index() when the deque is concurrently modified.

See also https://discuss.python.org/t/python-3-10-14-3-9-19-and-3-8-19-is-now-available/48993.
refmap.gentoo:

CVE-2023-6597, CVE-2024-0450, gh-81194, gh-102388, gh-113659: https://bugs.gentoo.org/927299
gh-114572, gh-115243: https://bugs.gentoo.org/929045

Added gh-115243.
BTW according to a Gentoo maintainer's comment, some of the CVEs/gh issues might be already included in older versions, confusing, but I did not check it myself.


CodelistItem.eq isn’t quite right

Should do a value comparison first before checking value.code

I think this might have been fixed in 734d186f98ef330a9e2effce43d0b8d9ae669bce?


ChromeCast support?

Hi,
Do you know if there are any known issues/restrictions to using TextureVideoView in a ChromeCast app? I'm writing a presenter app that displays images, text and videos and I'm using TextureVideoView for the videos but they're not displaying anything on the ChromeCast. I can hear definitely the video playing but the view itself remains a blank box. It's definitely working when playing videos in a regular Activity on my tablet device, it's just when using a CastPresentation it isn't working.
BTW TextureVideoView is a fantastic component, I was having so many problems with videos before finding it.
Cheers!

Glad you like TextureVideoView! 😄
Unfortunately, we don't have any experience using it with ChromeCast. I'd expected that it just works. Do you know if Android's original VideoView works correctly?
I could imagine that there are issues with TextureView and ChromeCast, but I really don't know, though. You might do a bit of research in this direction and report back. Maybe that helps us sorting the issue out....

After a fair bit of experimentation I've discovered that actually TextureVideoView does work with ChromeCast! The problem is with my test devices (two Lenovo Tab 2 A10-30s), for some reason they refuse to send any video to ChromeCast including when using the regular VideoView.
I tried my Nexus 7 and another cheap unbranded tablet I've got and they both work, so this appears to be a bug in Lenovo's implementation of video playback.
Thanks for your help and sorry for the false alarm!
Cheers!

Everything's fine, glad you found the cause! Good luck with your project, closing issue now...


edited syntax to make grammar consistent

I edited some minor syntax to make this excellent description more readable.
There is still one section that would benefit from a review: on line 10 "as  aort or poor persons browser extension"

Looks good to me!
My guess re :

Currently it is used as the core as aort or poor persons browser extension

"Currently it is used as the core as a sort of poor person's browser extension"


Frame of Reference in Transformation

In the aitviewer.utils.utils.py
There is a method local_to_global
def local_to_global(poses, parents, output_format="aa", input_format="aa"):
    """
    Convert relative joint angles to global ones by unrolling the kinematic chain.
    :param poses: A tensor of shape (N, N_JOINTS*3) defining the relative poses in angle-axis format.
    :param parents: A list of parents for each joint j, i.e. parent[j] is the parent of joint j.
    :param output_format: 'aa' or 'rotmat'.
    :param input_format: 'aa' or 'rotmat'
    :return: The global joint angles as a tensor of shape (N, N_JOINTS*DOF).
    """
    assert output_format in ["aa", "rotmat"]
    assert input_format in ["aa", "rotmat"]
    dof = 3 if input_format == "aa" else 9
    n_joints = poses.shape[-1] // dof
    if input_format == "aa":
        local_oris = aa2rot(poses.reshape((-1, 3)))
    else:
        local_oris = poses
    local_oris = local_oris.reshape((-1, n_joints, 3, 3))
    global_oris = torch.zeros_like(local_oris)

    for j in range(n_joints):
        if parents[j] < 0:
            # root rotation
            global_oris[..., j, :, :] = local_oris[..., j, :, :]
        else:
            parent_rot = global_oris[..., parents[j], :, :]
            local_rot = local_oris[..., j, :, :]
            global_oris[..., j, :, :] = torch.matmul(parent_rot, local_rot)

    if output_format == "aa":
        global_oris = rot2aa(global_oris.reshape((-1, 3, 3)))
        res = global_oris.reshape((-1, n_joints * 3))
    else:
        res = global_oris.reshape((-1, n_joints * 3 * 3))
    return res

There is a two options for apply transformation matrix.
global_oris[..., j, :, :] = torch.matmul(parent_rot, local_rot) (1. multiply left)
global_oris[..., j, :, :] = torch.matmul(local_rot, parent_rot) (2. multiply right)
Normally, option2 is applied. but aitviewer uses the first convention.
Could you explain why? I think many dataset like AMASS uses the second convention.
Also, I found aitviewer uses roma as an angle-handling library which uses second convention.

My fault, I misunderstood between transformation for the frame and transformation for the obejects


Release v0.1.0

This issue is a tracker of things we need to implement before we can tag v0.1.0.

[x] Support verifying RSL states (#62)
[x] Support file policies (#82)
[x] Add syncing functionality to push/pull refs/gittuf/* between remotes (#56)
[x] verify-commit and verify-tag functionality (#15)

https://github.com/gittuf/gittuf/releases/tag/v0.1.0


refactor(refunds): refactor refunds create to check for unintended 5xx

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

In this PR comments are added at places where code is not clear. Some minor code changes made wherever appropriate. No major logical changes made. Comments are added in code for more context. After the review the comments will be removed.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compiles
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Same comment as @SanchithHegde other than that LGTM, also please remove the comments


fix(curriculum): Add solutions to Bootstrap challenges

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Related to #35753

@RandellDawson @ojeytonwilliams @moT01 Thanks for the reviews, guys! Sorry, I've been away for a bit due to uni stuff, but I'm back now, so I'll take care of this one tonight.

@Manish-Giri Thanks for sorting this out!


Better defaults for createdDate

Is your feature request related to a problem? Please describe.
I'm always frustrated when I move/copy pictures I received in Whatsapp to albums because they always get the createdDate as the day I am moving them instead of the day I received them. In the gallery I see them at the date they were sent to me, as soon as I move/copy them the date changes.
Describe the solution you'd like
I am guessing this happens because Whatsapp removes any EXIF data when sending the image, perhaps using the same way to figure out the date would be good which is used to show the images in the gallery.
Describe alternatives you've considered
I've considered remembering to move images to albums as soon as I receive them, but its too hard to follow this.
Additional context
None.

I don't use Whatsapp, but I guess it behaves the same way like all the other social app, e.g
, removes EXIF before sending pictures. Could you give me an example of what's the picture filename you received? Or even better, send me a file you received to my email<EMAIL_ADDRESS>

The images are named like IMG-20240203-WA0001.jpg and videos are named like VID-20240203-WA0001.mp4.

Obviously only date coded in. It will be hard to guess the time. Is the filename pattern customizable in whatsapp?

I don't think there is a way to customize the filename pattern. For me using the date without the time (or defaulting that to midnight) would already be an improvement.

Ok. Fix will be included in next release.


how to edit crop cultivar parameters

Dear author, I was pleasantly surprised to find a repository targeting apsim python versions.
When using it, I want to modify the variety parameter of maize in the replacement module.
I found the edit_cultivar function in the api.py but not in the apsim.py file. Is there an incompatible difference between the two files. Can I use edit_cultivar in api.py.
Looking forward to the update on modifying the cultivar parameter.
And looking forward to better documentation and building apsim from source.

Thank you for your interest in the APSIM Python library. The apsim.py file contains the ApsimModel class, which inherits from the APSIMNG class defined in api.py. This inheritance means that ApsimModel encompasses all the methods available in api.py. When you create an instance of the ApsimModel class, it allows you to modify the cultivar. We will include a documentation of how to build APSIM from source, but apsimNGpy can also run using your installed APSIM. All you need is to include the bin path to the python path.

Thank you very much for reminding me that I did not notice the inheritance relationship between apsimModel and apsimNg before. Now I have solved the problem of editing the crop parameters.
Keep looking forward to building apsimNG from source~


[Crash] Crash with Xamarin Android

http://pastie.org/9823032

wow, looks like https://bugzilla.xamarin.com/show_bug.cgi?id=17257
Could you please give more details: device and Android version?
Thanks.

Phone:
LG-VS980
Android 4.4.4
Build:
Compile API 16 (4.1)
Minimum API 16 (4.1)
Target API 20 (4.4.87)

Actually, with API 16 I get a nullpointer which looks like this: http://pastie.org/9823440


Update libtool-version to 2.4.7 from 2.4

timeout on build

Build is still running - https://<IP_ADDRESS>:8443/job/Port-Build/2614/console

/run tests

Error related to getenv,
In file included from libltdl/lt__argz.c:38:
In file included from libltdl/libltdl/lt__argz.h:35:
/jenkins/zopen/usr/local/zopen/zoslib/zoslib-main.20240110_084622.zos/include/stdlib.h:79:18: error: conflicting asm label
__Z_EXPORT char* getenv(const char*) __asm("@@A00423");
                 ^
/usr/include/le/stdlib.h:436:18: note: previous declaration is here
    #pragma map (getenv,      "\174\174A00181")
                 ^
1 error generated.
Error while processing libltdl/lt__argz.c.

/run tests


Use symbols, not strings, for component object keys

This shouldn't be merged until https://github.com/alphagov/static/pull/601 is merged and deployed
We should only use one style of keys for objects used in components,
to avoid reduce confusion when using components. Consistency is good.
After discussion with @edds we agreed to use symbols as this makes
more sense in a ruby/rails environment.
The first step was to support both, as clients of those components
will still be sending string key'd objects and can't be updated
at the time as this app, so we have to;

Support both kinds of keys on components that expect strings
Update clients sending string keys to use symbols instead
Remove support for string keys from those components

This PR is step 2. for options_select, but also needs doing in
manuals-frontend for previous_and_next_navigation.
Step 1 is: https://github.com/alphagov/static/pull/601

:+1:


Custom attributes

There are a lot of use cases (e.g. #1604, https://github.com/MichalLytek/type-graphql/issues/476, https://github.com/prisma-labs/nexus-prisma/issues/584, ...) which would benefit from the Prisma schema allowing the definition of "custom attributes" which should be exposed through the Prisma SDK.

At my company we are currently implementing a custom attribute system for the typegraphql-prisma generator as it looks like Prisma doesn't have yet a native way to extend it for generator consumers.
We would like to be alienated with the Prisma team in the long run so our extension system maybe could work as a base to what could be brought back to Prisma as a native way to do it.
We have currently an RFC with our proposal that we are already implementing it, but if posible we would like to get feedback from the Prisma team about it.

In a lot of applications I have used custom attributes to do a few common things ranging from:

Defining things like Description Name  and other basic attributes that may help describe how it is displayed in a UI or for Documentation from the API.
Going beyond simple properties we have defined things like SelectBox or DateBox to go in more detail of how to show these.

An example in .Net we have used is something like this
[TextBox("Middle Name")]
public string MiddleName { get; set; }

I have used similar patterns in other projects where we allowed this to build up a definition of what a model looks like to the application. This allows models to be consistent across multiple UIs and the model definition contains everything the UI would need to know about how to display the model.

Is there anything here in this issue not covered by https://github.com/prisma/prisma/issues/3102? Otherwise I think we should close this one and focus on #3102.

I think #3102 has everything that I have asked for.


camel-etcd: Lets see if CI tests can pass this

Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-test camel-etcd3

@otavioprado okay so here is a potential fix to let this use the 110 version and see CI passes

@otavioprado okay so here is a potential fix to let this use the 110 version and see CI passes

Thanks for looking at this!


Azure Service Bus - Not able to publish the message to service bus in azure using node SDK

Packages: "@azure/service-bus": "^7.7.2", @azure/identity": "^3.0.0"
Operating System: MacOs Monterey Version 12.6.1
Node Version: v18.12.1
Environment Setup
Running the service bus in Private VNET with the private end point configured and trying to access it from local machine with VPN.
Describe the bug
Not able to publish the message using connection_string (shared access policies) to the service bus, but able to do all the management level activities (creation of topic, creation of subscription)
Observed error message:
ServiceBusError: [connection-4] Sender "testtopic3-9b192bd4-5991-3b4f-837b-38886eedd68f" with address "testtopic3", was not able to send the message right now, due to operation timeout.
retryable: true,
code: 'ServiceTimeout'
ServiceBus Explorer
Tried connecting to Service Bus via Service Bus explorer using connection_string, able to list the topic, subscriptions created and able to publish the message to topic and receive the message the message from subscription through service bus explorer successfully, facing the issue while publishing the message through SDK (attached the screenshot of error).
Reproducible Example:
Service Bus client
const sClient = new ServiceBusClient(connection_string);

Publish Message to Topic
const publishMessageToTopic = async () => {
  try {
    const sender = sClient.createSender(topic_name);
    const message = {
      body: {
        firstName: "Albert",
        lastName: "Einstein",
      },
    };
    const res = await sender.sendMessages(message);
    sender.close();
  } catch (error) {
    console.log(error);
  } finally {
    sClient.close();
  }
};

publishMessageToTopic();

Service Bus Explorer Screenshot

Error Message Screenshot

@SarathKumarVelusamy Thank you for reporting this issue! We will have a look at it.

@SarathKumarVelusamy could you please try with websockets and see if it works?
import WebSocket from "ws";

// ...[omitted]

const sClient = new ServiceBusClient(connectionString, {
  webSocketOptions: {
    // No need to pass the `WebSocket` from "ws" package if you're in the browser
    // in which case the `window.WebSocket` is used by the library.
    webSocket: WebSocket,
  },
});


Update proofs-of-concept

Some fixes to the proofs-of-concept; preparation for splitting them off into their own repository for maintenance purposes.

Freshen README.md
Fix checkstyle/Spring Boot error with indexing triplestore
Fix Docker build for Docker Engine 1.12.1

@emetsger @birkland, at this point, please feel free to just remove the Amherst POC. If there is a need to revive it, one can look through the git history. (Or would you prefer that a "Remove Amherst POC" PR came from me?)

So removing the Amherst POC would involve updates to:

Maven poms
docker-compose.yml
Vagrantfile
README.md (it's mentioned as a verification step)

I agree It'd be OK to remove it at this point.  As far as logistics @emetsger Do you have any opinion or feeling either way on whether this should happen now, in this PR, or a separate PR?

I don't mind doing it in this PR @acoburn @birkland

Thanks @emetsger, that would be great


When are the newest commits going to be released to PyPi?

Just as the title says. The latest "keep" feature in the renderer is very useful and would like it to be available without having to download directly from github.
Regards.

The keep option is indeed something extremely useful, would definitely justify a (minor?) release just for that!

@noahmorrison: I am also looking forward to keep. Do you plan to release a new PyPI version soon-ish? Are there some issues that currently prevent a release?

How about this ? I'm waiting for keep options too.


Fix GitHub test action

What does this change?
This PR attempts to fix our github actions.
Decisions / Choices I made
With the puppeteer update to 19, it stores browsers to globally cache browsers between installation.
This caused problems with our github actions, because it moved while caching leading to "[ ERROR ]  Could not find Chrome" like this one: https://github.com/openHPI/xikolo-video-player/actions/runs/5443573491/jobs/9946467813?pr=79#step:4:22
They could be fixed by deleting the cache and re-running the action, but I hope it's fixed now.
See: https://pptr.dev/guides/configuration#changing-the-default-cache-directory

Nope, my first attempt did not do the trick. I'll keep investigating.

As discussed, as our future plans are to get rid of puppeteer, I think switching to v18.2.1 is an acceptable solution 👍


[macOS] Window with HasSystemDecorations="False" can't be maximized

Maximizing a window with WindowState = WindowState.Maximized; fails silently on macOS if HasSystemDecorations is set to False. If it's set to True, maximizing from code works.
Although, the window does move around when attempted, but doesn't resize, so maybe related to #3834?
macOS 10.13 / cibuild0006821

I can't access cibuilds prior to 6492, but I have 6058 cached locally. Maximizing works on 6058, but not 6492, so it was broken sometime in between those builds.

fixed in https://github.com/AvaloniaUI/Avalonia/pull/3849


6.0 Feedback:  Labware section needs custom labware category

Overview
General Background and ask
We have a great labware tab (which I have used a lot). It does make it more difficult to find what custom labware has been loaded on my OT-2. Would it be possible for us to add a "Custom Labware" category?
Why would we do this?
From a customer's perspective, I have seen them load several versions of the same labware if they don't have a technical drawing and need to make them better.
Scrolling through gets pretty difficult. Also, if you want to copy and paste the names it's easier if they're all in one place.
Current Behavior
You have to scroll to find any custom labware that you have.
Expected Behavior
We should have a designated custom labware section
Steps To Reproduce
N/a
Operating system
Mac
Robot setup or anything else?
No response

This might be a better ticket to track this request: https://github.com/Opentrons/opentrons/issues/10141


Hide vulnerabilities ignored in app

All vulnerabilities retrieved from the API are now filtered based on their statuses. Ignored vulnerabilities are no longer shown in the text/JSON outputs, for SCA scan all/diff commands.
The implementation is mostly similar to the one for IAC in #800.

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9a74668) 91.81% compared to head (0b7d36f) 91.77%.

Files
Patch %
Lines

ggshield/verticals/sca/output/json_handler.py
0.00%
4 Missing :warning:

ggshield/verticals/sca/collection/collection.py
80.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   91.81%   91.77%   -0.04%
==========================================
  Files         167      168       +1
  Lines        6975     7007      +32
==========================================
+ Hits         6404     6431      +27
- Misses        571      576       +5

Flag
Coverage Δ

unittests
91.77% <85.36%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, I tested it using staging and it works perfectly ! I only have some small comments regarding the tests.


Adding Portfolio - Hacktoberfest - 24

Hi, I would like to add my portfolio. Could you please assign this issue to me and add the Hacktoberfest label?

I'm happy to contributing in this repository to add the portfolio, assign me.
Thank you!

Hello, I would Like to contribute by Inserting my Portfolio

I hope this message finds you well.
I wanted to inform you that I will be creating a new pull request for the
project. Please take a look at it once it's submitted, and let me know if
there are any changes required in my repository.
Thank you for your guidance!
On Fri, 25 Oct 2024 at 21:52, Tanmay Waghmare @.***>
wrote:

Hey, I created A Pull Request but a message came "Deployment has Failed".
How can I fix that
—
Reply to this email directly, view it on GitHub
https://github.com/avinash201199/Portfolio-Collection/issues/289#issuecomment-2438254061,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3SBJBZLPVSSLY2ZPZD4MU3Z5JV6BAVCNFSM6AAAAABP3BPL6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGI2TIMBWGE
.
You are receiving this because you were assigned.Message ID:
@.***>

hey @avinash201199 is something wrong in my portfolio? I am not able to fix the pr problem


Agent prioritize bash

Previously, when the LLM response included both bash commands and a conclusion, we ignored the bash command and compiled the fuzz target in the conclusion alone. This approach is suboptimal, as conclusions may be premature, and the bash command often provides useful context to refine them.
To improve accuracy, we should prioritize the bash command when both are present in a response.
A more robust solution would involve structuring tasks to prevent mixed responses (e.g., using task-focused agents). But until then, prioritizing bash commands in mixed responses provides a fallback/default solution.

/gcbrun exp -n dg -ag

/gcbrun exp -n dg -ag

/gcbrun exp -n dg -ag

Something weird with gcb exps causing exps not requested.


Weakest Energy Blast - Using it against Spire Shield breaks the VFX or not?

Yes, it breaks it a bit. No, I'm not fixing it.


Output file

If we are going to operate over directories we want some output file for all the reports to be put in

No problem, i'll make an output file within the specified directory

if you have time could you add an option for the user to specify an output file on the command line?

Did you do it?


HierClustering not defined.

https://github.com/ajgates42/clusim/blob/4c6251836689be3e15e93fbe8b5da10123a9b5fa/clusim/clugen.py#L122

HierClustering has now been subsumed by the Clustering class.


Certificate error causes silent haproxy reload failures

Rancher versions:
rancher/server: 1.6.10
rancher/agent:
Infrastructure Stack versions:
healthcheck: rancher/healthcheck:v0.3.3
ipsec: rancher/net:holder
network-services: rancher/network-manager:v0.7.8
scheduler: rancher/scheduler:v0.8.2
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
17.09.0-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
$ uname -r
4.9.0-5-amd64
$ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 9 (stretch)"
NAME="Debian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=debian
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Bare-metal
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:

Upload a certificate with mismatching public/private keys
Modify haproxy rules in loadbalancer
Save loadbalancer changes

Results:

Haproxy fails to restart, no visual feedback or alerts
Details only visible in loadbalancer logs after service instance restart

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


a few modes got code and available to play,a few,can't

Big City:Capture
available to play,but no completed,it will NOT load character stats like the games it still here itself,NO objective on the map ALL the people spawn in same area
Ghost Mode:
code:CONTENTS_GHOST
Normal Working,available to play,but NOT night map,so it'd better play with more people and find a way that set the map to night
Battle Royale(Mad City)
code:madcity = 61
map code=mad_city
Avaliable,Normal working,but sometimes no crate spawn,BUG
Eventmode02:
RPG game mode,Normal Working, available to play
TDM(DIY)
code: = 42
NOT AVAILBLE,can't join ANYONE,if you start the game,the host will force flash quit the game,without ANY notice
Weapon Upgrade Mode(Death Match)
code: = 15
haven't test yet
Casual Compeletive
FLASH QUIT
Mad City(2-Man Mode)
just like normal mad city
Zombie Craft
Host FLASH QUIT
that's pretty much all the game mode that can and can't play,a few haven't test yet,but most of them is still can to play,but need to find each

New:Heroes Mode
a normal PVE mode,random pick a heroes character for player,20 waves,but you can't play it,it said"this mode is not support now",I think it can be play if you change some code

sorry for my friend's expression first. I successfully started those "deleted gamemodes" through CE, but there were some bugs in them, here is a list of the gamemodes with bugs:

the game can not be start, because the current mode is not available (text "#CSO2_ModFileDoesnotExist")
Heroes (number 24)
PS: it currently only happens on Heroes, but, of course, the schema that some developers use to test it doesn't work either: number 9, 10, 13(I guess this is the mode for Source TV), 16.
the rules of the game were not loaded correctly:
Rubik H&S (number 43), Ice H&S (number 41)
when you start loading, you return to the room before the progress reaches 5%:
Zombie Commander (number 26 and 48), TeamDM DIY (number 42), Foot(GUN!!!)ball (number 51)

AND, I successfully started a big city game, but it need to request too much data from the server, and the current server could not recognize that data, which caused the BC mode to become RP mode (more like stroll, or, TK mode? hahahahaha)
if you don't trust me, go to the imgur and find out if i'm lying:
FUCK THE IMGUR
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
anyway, BC mode recovery is a long way off, so I have some good news here, there are some gamemodes can works:
OLD GunDM (number 5), Pig (number 8), P&H&G DM (number 21), RPG!!!! (number 25), Female Ghost (number 38), MM H&S (number 40), Daily PVE (number 44, 45, 46), Casual (number 49), Small TDM and Competitive (number 54 and 55), Mad City (number 61), Mad City Double (number 67)
if you've never seen these modes before, check out the details below:
8. when the round starts, everyone is 1000 health. you gain health by attacking enemies. when you reach 3000 you become a big pig! (the amount of health depends on the size of the character)
21. Pig, Human, Ghost all in one DM. (human will get random weapons)
25. they are all enemies, random spawn location, all hold rpg, kill 10 people to win. (loses 3 kills if you has been killed)
38. female ghost, ghost has noclip, human need flashlight to find female ghost, if a human is attacked by a female ghost and loses all of his health, that human will become a female ghost.
it's not really a question post, it's more like an information post, I just want to show all of us that modes that are not available are actually playable (though about half of them are BUGGED XD)
GL & HF!

oh, I forgot something, please forgive me, because there are too many things to write
when you encounter problem 3, you will get the following error:
Host_Error: Mod_LoadCubemapSamples: funny lump size in maps/|mapname|.bsp
so and what about "Duel"? actually, I didn't test it because it require at least 4 players (this mode can only stay 4 players), and when I tried to start with 1 player 3 BOTs, it told me the same thing through notifications
if I think of anything, and I think it's worth posting here, I'll update it here unless it's closed

So how can I play these "deleted mode"?

Heroes mode is not normally played because the monster and boss files are removed inside the client after the event ends.

Offtopic: dounai2333, can you tell me please how did you make your game to show not only your fps, but also ping? I checked in settings and there is only "show fps" button. I want to see ping too

Offtopic: dounai2333, can you tell me please how did you make your game to show not only your fps, but also ping? I checked in settings and there is only "show fps" button. I want to see ping too

Set cl_showfps to 2 throuh console

cso2_modlist.zip
You can put the file in custom\scripts to create a mode that is not used.

cso2_modlist.zip
You can put the file in custom\scripts to create a mode that is not used.

thank you,we have already done with it,now we can just creat the unused game modes with this already,but we don't know how to show this image of the game modes


Fixed BUG 3612

This PR will close the issue 3612
The links of the options mentioned in the sidebar.md file was not working. Now it will work.

@eddiejaoude I am new in contributing to open source. Kindly review this PR. Thanks!

Thank you for making the changes 👍
It looks good, but CI is failing due to a formatting error
./docs/_layout/sidebar.md:22:51 MD047/single-trailing-newline Files should end with a single newline character

I made some changes. Now it is not showing any lint error. Thank you for your patience.


Complete UI Overhaul

Pull Request: UI Changes
Changes:

Renamed old files to .old
Added new style.css
Added new index.html and base.html
Closes issues #47 and #52

Description:
These changes aim to update the UI with the following enhancements:

Renamed old files to maintain versioning and organization.
Introduced new style.css to enhance the styling of the UI components.
Added new index.html and base.html to incorporate updated layouts and features.

How to Test:

Clone this branch locally.
Navigate to the project directory.
Review the changes made to the file structure and the introduction of new files.
Open index.html and base.html to verify the new layouts.
Ensure that the styling is consistent and aligned with the UI requirements.
Verify that issues #47 and #52 have been addressed.

Additional Notes:
These changes have been thoroughly tested locally and are ready for review and deployment. Please provide feedback or suggestions for further improvements.

Before

After


Panda class usbdevice

fixed 2 bugs:

control_transfer missed parameters data & length
no need to check transferred after bulk read. (the transferred is 0 after bulk read)


New flags

Added new flags to support

recursive download of children pages (-r --recursive)
chance to download also image and PDF files from notion (-a --all-files)

Also chance to use it, of course, programmatically.

Had to reopen it as #8 to make the changes.