BREAKING CHANGE: MSFT_DFSNamespaceRoot/MSFT_DFSNamespaceFolder: DFSNamespace Support for ReferralStatus (State) Modification

Pull Request (PR) description
BREAKING CHANGE:

Add support for setting a DFS Namespace root target's referral status (state) to be either Online or Offline
in MSFT_DFSNamespaceRoot. State is now a required parameter.
Add support for setting a DFS Namespace folder target's referral status (state) to be either Online or Offline
in MSFT_DFSNamespaceFolder. State is now a required parameter.
Update examples to support new required parameter.

This Pull Request (PR) fixes the following issues
This pull request does not fix any issues.
Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Hi,
is there any plan make this feature available  in future releases?

Hi, I did not spot this PR before, but it looks like it'd need some tests setup unless I'm not reading the codcov report rights.
I know @PlagueHO is busy these days so he won't be able to make this PR work soon if it does not pass the tests.
I'm happy to review and merge if and when the test passes if Dan is busy, or to assist if someone need help.
@heimdallreport feel free to fork his branch and continue the work in a new PR, or ask @thesmall if you can help getting this PR to pass the tests.

Hey all. @gaelcolas you're correct in the assessment that there are no tests present. Truth of the matter is that, while I can write the code to actually make the DSC Resource work, I have almost no idea how to write the appropriate and necessary tests.
If someone would be willing to work with me on getting the tests written, I would be grateful and would be happy to further facilitate getting this branch merged.

Hi @heimdallreport - not sure how I missed this. And apologies to @thesmall. I suspect it was during the transition to the new CI pipelines.
I'd love to get this through, so if you're still working on this @thesmall, keen to get the conflicts resolved.

@PlagueHO FYI This merge can be discarded since it was included in #126

Thanks @Borgquite - closing as addressed in #126.


Undefined method `elements' for nil:NilClass on 'Invoke-Command'

Thanks for developing this library!
I was just testing it whether it would be of use in our environment and found the following bug:
Given the following script:
require 'winrm'
conn = WinRM::Connection.new(endpoint: 'http://HOST:5985/wsman', user: 'USERNAME', password: 'PASSWORD')
conn.shell(:powershell) {|shell| shell.run('Invoke-Command HOST {Get-Service LanManServer}') {|so, se| p [so, se]}}

The following Ruby error is thrown:
NoMethodError: undefined method `elements' for nil:NilClass
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/message_data/error_record.rb:53:in `property_hash'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/message_data/error_record.rb:31:in `invocation_info'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/powershell_output_decoder.rb:106:in `render_exception'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/powershell_output_decoder.rb:87:in `decode_error_record'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/powershell_output_decoder.rb:39:in `decode'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/receive_response_reader.rb:63:in `block (2 levels) in read_output'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/receive_response_reader.rb:45:in `block in read_message'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:66:in `block in read_response'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:121:in `block in read_streams'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:119:in `each'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:119:in `read_streams'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:65:in `read_response'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/receive_response_reader.rb:41:in `read_message'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/receive_response_reader.rb:60:in `block in read_output'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/wsmv/receive_response_reader.rb:75:in `with_output'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/psrp/receive_response_reader.rb:59:in `read_output'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/shells/base.rb:82:in `block in run'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/shells/base.rb:132:in `with_command_shell'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/shells/base.rb:81:in `run'
        from (irb):1:in `block in irb_binding'
        from /home/thomas/.rvm/gems/ruby-2.4.2/gems/winrm-2.2.3/lib/winrm/connection.rb:44:in `shell'
        from (irb):1
        from /home/thomas/.rvm/rubies/ruby-2.4.2/bin/irb:11:in `'

On investigating I found that WinRM::PSRP::MessageData::ErrorRecord#doc has the following value:
<?xml version="1.0"?>
<Obj RefId="0">
  <TN RefId="0">
    <T>System.Management.Automation.ErrorRecord</T>
    <T>System.Object</T>
  </TN>
  <ToString>[HOST] Connecting to remote server HOST failed with the following error message : Zugriff verweigert For more information, see the about_Remote_Troubleshooting Help topic.</ToString>
  <MS>
    true
    <Obj N="Exception" RefId="1">
      <TN RefId="1">
        <T>System.Management.Automation.Remoting.PSRemotingTransportException</T>
        <T>System.Management.Automation.RuntimeException</T>
        <T>System.SystemException</T>
        <T>System.Exception</T>
        <T>System.Object</T>
      </TN>
      <ToString>System.Management.Automation.Remoting.PSRemotingTransportException: Connecting to remote server HOST failed with the following error message : Zugriff verweigert For more information, see the about_Remote_Troubleshooting Help topic.</ToString>
      <Props>
        <I32 N="ErrorCode">5</I32>
        <S N="TransportMessage">Zugriff verweigert _x0000_</S>
        <S N="ErrorRecord">Connecting to remote server HOST failed with the following error message : Zugriff verweigert For more information, see the about_Remote_Troubleshooting Help topic.</S>
        false
        <S N="Message">Connecting to remote server HOST failed with the following error message : Zugriff verweigert For more information, see the about_Remote_Troubleshooting Help topic.</S>
        <Obj N="Data" RefId="2">
          <TN RefId="2">
            <T>System.Collections.ListDictionaryInternal</T>
            <T>System.Object</T>
          </TN>
          <DCT/>
        </Obj>
        <Nil N="InnerException"/>
        <Nil N="TargetSite"/>
        <Nil N="StackTrace"/>
        <Nil N="HelpLink"/>
        <Nil N="Source"/>
        <I32 N="HResult">-2146233087</I32>
      </Props>
    </Obj>
    <S N="TargetObject">HOST</S>
    <S N="FullyQualifiedErrorId">AccessDenied,PSSessionStateBroken</S>
    <Nil N="InvocationInfo"/>
    <I32 N="ErrorCategory_Category">1</I32>
    <S N="ErrorCategory_Activity"/>
    <S N="ErrorCategory_Reason">PSRemotingTransportException</S>
    <S N="ErrorCategory_TargetName">HOST</S>
    <S N="ErrorCategory_TargetType">String</S>
    <S N="ErrorCategory_Message">OpenError: (HOST:String) [], PSRemotingTransportException</S>
    <S N="ErrorDetails_Message">[HOST] Connecting to remote server HOST failed with the following error message : Zugriff verweigert For more information, see the about_Remote_Troubleshooting Help topic.</S>
    <S N="ErrorDetails_RecommendedAction"/>
    false
    <Nil N="PSMessageDetails"/>
  </MS>
</Obj>

It seems that the ErrorRecord class can't currently handle this kind of situation and raises an exception. However, even if the access is denied, it shouldn't result in an exception.

Yeah definitely looks like you hit a scenario where the error record parser cant handle the PSRP message its passed.
However an access denied will certainly produce an exception. It just needs to be parsed correctly so that the user gets a legible message. We probably just need to do a nil check on the Invocation Info and handle cases where that is empty.
To work around this, you might try ommiting the HOST arg and just pass the script block since you are invoking the command on the same host.

Thanks for getting back and for the work around!

This appears to have been fixed in https://github.com/WinRb/WinRM/commit/d7ecaccdf956e998b8fc61d077cd9bdd44f8f898 . But the patch is not included in a release.

That commit is now released in v2.3.4


⚠ Bofrost.lu has degraded performance

In db82d2e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1842 ms

Resolved: Bofrost.lu performance has improved in eb84a84 after 9 minutes.


missing secretKeyRef

error logs:

2020-12-04T09:08:45.572Z        ERROR   harbor-operator.controller      Cannot deploy resource  {"controller": "registry", "request": "cluster-sample-ns/harborcluster-sample-harbor-harbor", "resource.apiVersion": "apps/v1", "resource.kind": "Deployment", "resource.name": "harborcluster-sample-harbor-harbor-registry", "resource.namespace": "cluster-sample-ns", "error": "Deployment.apps "harborcluster-sample-harbor-harbor-registry" is invalid: spec.template.spec.containers[0].env[3].valueFrom.secretKeyRef.key: Required value: Deployment.apps "harborcluster-sample-harbor-harbor-registry" is invalid: spec.template.spec.containers[0].env[3].valueFrom.secretKeyRef.key: Required value"}

It seems Pierre has fixed this issue. Creating for future tracking.

Check PR: https://github.com/goharbor/harbor-operator/pull/266


face_recognition_model _v1 different input face sizes and boundary boxes

Hello
Can i feed face images with boundary boxes and resolutions from other face detectors  into the DLIB's face_recognition_model _v1  to get the embedding vectors ?
For example 40*40 face with boundary boxes  from OpenCV cv2.dnn.readNetFromCaffe  ?
If it is possible , how would the embedding vectors of the same image with different resolutions  i,e 40*40   ,  80*80  differ?

Yes it worked fine :

Detect faces in frames with OpenCV cv2.dnn.readNetFromCaffe
Rearrange the output from [(startX, startY, endX, endY)] to [(startY, endX, endY, startX)]
Feed the new output to  DLIB's face_recognition_model _v1

The embedded vectors had negligibly small difference from that of DLIB detector
Thanks


[SPARK-46698][CORE] Replace Timer with single thread scheduled executor for ConsoleProgressBar.

What changes were proposed in this pull request?
This PR propose to replace Timer with single thread scheduled executor for ConsoleProgressBar.
Why are the changes needed?
The javadoc recommends ScheduledThreadPoolExecutor instead of Timer.

This change based on the following two points.
System time sensitivity
Timer scheduling is based on the absolute time of the operating system and is sensitive to the operating system's time. Once the operating system's time changes, Timer scheduling is no longer precise.
The scheduled Thread Pool Executor scheduling is based on relative time and is not affected by changes in operating system time.
Are anomalies captured
Timer does not capture exceptions thrown by Timer Tasks, and in addition, Timer is single threaded. Once a scheduling task encounters an exception, the entire thread will terminate and other tasks that need to be scheduled will no longer be executed.
The scheduled Thread Pool Executor implements scheduling functions based on a thread pool. After a task throws an exception, other tasks can still execute normally.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Manual tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.

ping @srowen @dongjoon-hyun @LuciferYang

Looks OK, just rerun tests

Merged to master. I verified manually the console progress bar. It looks working without any issue as expected.

@dongjoon-hyun @srowen @LuciferYang Thank you!


Role types are off

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
E.g.

OpenAI.Chat.ChatCompletionAssistantMessageParam - is saying that role 'system' is not a valid role and that only user or assistant is
The enum for role is gone

To Reproduce
NA
Code snippets
nA

OS
macOs
Node version
Node v20
Library version
openai v.4.2.0

Just going to add some more as I see them:
OpenAI.Chat.ChatCompletionCreateParamsNonStreaming

Property 'content' does not exist on type 'ChatCompletionCreateParamsNonStreaming'
when accessing messages[0] of OpenAI.Chat.ChatCompletionAssistantMessageParam

ok, will join the community now


Populate timeVisible for Fingers on the OpenXR provider

Summary
Correctly populates the timeVisible property for fingers on the OpenXR Provider.
Contributor Tasks

[ ] Pair review with a member of the QA team.
[ ] Add any release testing considerations to the MR for the next release.
[x] Check any relevant CHANGELOG files have been updated.
[x] Ensure documentation requirements are met e.g., public API is commented.
[ ] Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
[ ] Add any relevant labels such as breaking to this MR.
[x] If this MR closes a Jira issue, make sure the fix version on the JIRA issue is set to the correct one.

Reviewer Tasks

[x] Code reviewed.
[x] Non-code assets e.g. Unity assets/scenes reviewed.
[x] Documentation has been reviewed. Includes checking documentation requirements are met and not missing e.g., public API is commented.
[x] Checked and agree with release testing considerations added to MR for the next release.

Code looks good, tested in the OpenXR example scene with a script that logged all the fingers 'timevisible' value and it correctly mapped to the time in seconds since the hand had been found for every finger


Some MP3s don't stream well, allow download first?

The Issue
Some mp3s (test: lbry://mp3large), when initially played, will only show that only 1:27 is available when it's really 28 minutes long. Not sure if this is an issue with this specific MP3, but other larger ones like lbry://@FeralLogic#e46c575bb4b77ff3f26cd8e85aa2908d76e9972d/six also have a similar issue - it shows the correct length but you can't scrub past a few minutes.
If you refresh the app, it shows the correct time/scrubs normally. Not sure why when leaving the page/coming back this is not the case (does it use the old stream?).  This would be good to test with the new video player as well. In the meantime, just allowing full download before trying to play the mp3.
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Fixed


Is it possible to use Eject key for ejecting external optical drive?

Hi!
I have a Mac Pro with an extended Magic keyboard.
Until now I am using Karabiner Elements to change the brightness of my monitor with F1 and F2, which is working very nice!
Normally I can use the Eject key together with Opt-Cmd to let the Mac sleep or Ctrl-Opt-Cmd to shut down the Mac.
Is it possible to get a disc in an external USB optical drive to eject when pressing the Eject key?
I can not find anything about such a thing in the documentation.

Is no one here who can answer this?


post-conf changes: Update video IDs

Description

@Benjie asked me to update the video IDs to the new "GraphQL Foundation Talks" channel. I've also updated a couple of the talk titles, and noticed that the composite schema panel was listed twice.

looks good! @jemgillam can you please run pnpm format to fix prettier errors?

Whoops, yes, that's been fixed 👍

thanks @jemgillam!


Avoid extra spritesheet preparation step

We're currently doing an extra manual step to convert our SVG spritesheets into a differnt format that the Pixi asset loader likes.  Once they've made it through asset loader, we just pack them into the texture atlas anyway.
We still do need to keep the SVG spritesheets for the non-WebGL parts of the user interface - like toolbar and sidebars and stuff.
I think instead we can just load all these svg icons into images and pack them into the Pixi texture atlas as soon as the SVG spritesheets have been loaded.  The code to do this wouldn't be any different than what we already do with background imagery.
cc @Bonkles , @mvexel

I played around with this yesterday and got it kind of working!
Some useful links:
https://stackoverflow.com/questions/3975499/convert-svg-to-image-jpeg-png-etc-in-the-browser
<EMAIL_ADDRESS>https://levelup.gitconnected.com/draw-an-svg-to-canvas-and-download-it-as-image-in-javascript-f7f7713cf81f
https://stackoverflow.com/questions/7650587/using-javascript-to-display-a-blob
Here are some icons loaded from the community spritesheet..
The black one is the original <svg> icon, like we use throughout the user interface.
The red ones are actually <img> tags, which should be able to get a context to read the pixels.  Then I'll pack these pixels into the sprite atlas.

I tried 2 methods for setting image source, using data: url and using blob: url
The data url is consistently a lot faster, as there is overhead in creating the Blobs just for tiny images that we're going to throw away immediately, so I'll stick with data urls.
Pasting my test code and timing results here for posterity:
 selection.selectAll('symbol')
   .each((d, i, nodes) => {
     if (spritesheetID !== 'community-sprite') return;

     const symbol = nodes[i];
     const iconID = symbol.getAttribute('id');
     const viewBox = symbol.getAttribute('viewBox');
     console.log(`found icon ${iconID}`);

    const icon = context.container()
      .append('div')
      .call(uiIcon(`#${iconID}`));

    // Make a new <svg> container
    const svg = document.createElementNS('http://www.w3.org/2000/svg', 'svg');
    svg.setAttribute('xmlns:xlink', 'http://www.w3.org/1999/xlink');
    svg.setAttribute('height', '32');
    svg.setAttribute('width', '32');
    svg.setAttribute('color', '#f00');
    svg.setAttribute('viewBox', viewBox);

    // Clone children (this is essentially what <use> does)
    for (const child of symbol.childNodes) {
      svg.appendChild(child.cloneNode(true));  // true = deep clone
    }

    const svgStr = (new XMLSerializer()).serializeToString(svg);

 console.time('as data url');
    const dataURL = `data:image/svg+xml,${encodeURIComponent(svgStr)}`;
    context.container()
      .append('img')
      .attr('width', '32px')
      .attr('height', '32px')
      .attr('src', dataURL);
 console.timeEnd('as data url');

 console.time('as blob url');
    const blob = new Blob([svgStr], { type: 'image/svg+xml;charset=utf-8' });
    const blobURL = window.URL.createObjectURL(blob);
    context.container()
      .append('img')
      .attr('width', '32px')
      .attr('height', '32px')
      .attr('src', blobURL);
 console.timeEnd('as blob url');

found icon community-aparat
as data url: 0.2041015625 ms
as blob url: 2.464111328125 ms
found icon community-discord
as data url: 0.048095703125 ms
as blob url: 0.4248046875 ms
found icon community-discourse
as data url: 0.039794921875 ms
as blob url: 0.685791015625 ms
found icon community-facebook
as data url: 0.0419921875 ms
as blob url: 1.925048828125 ms
found icon community-forum
as data url: 0.053955078125 ms
as blob url: 0.517822265625 ms
found icon community-github
as data url: 0.0478515625 ms
as blob url: 0.51318359375 ms
found icon community-gitlab
as data url: 0.045166015625 ms
as blob url: 0.50732421875 ms
found icon community-group
as data url: 0.058837890625 ms
as blob url: 0.439208984375 ms
found icon community-irc
as data url: 0.084716796875 ms
as blob url: 0.69091796875 ms
found icon community-linkedin
as data url: 0.0400390625 ms
as blob url: 0.52783203125 ms
found icon community-mailinglist
as data url: 0.0791015625 ms
as blob url: 1.10791015625 ms
found icon community-mastodon
as data url: 0.05712890625 ms
as blob url: 0.669921875 ms
found icon community-matrix
as data url: 0.052978515625 ms
as blob url: 0.59912109375 ms
found icon community-meetup
as data url: 0.05810546875 ms
as blob url: 0.44189453125 ms
found icon community-newsletter
as data url: 0.0380859375 ms
as blob url: 0.509033203125 ms
found icon community-osm
as data url: 0.06689453125 ms
as blob url: 0.56103515625 ms
found icon community-osm-lc
as data url: 0.04296875 ms
as blob url: 0.6787109375 ms
found icon community-reddit
as data url: 0.048828125 ms
as blob url: 0.623046875 ms
found icon community-signal
as data url: 0.364013671875 ms
as blob url: 0.905029296875 ms
found icon community-slack
as data url: 0.076171875 ms
as blob url: 1.348876953125 ms
found icon community-telegram
as data url: 0.15185546875 ms
as blob url: 0.635986328125 ms
found icon community-twitter
as data url: 0.048828125 ms
as blob url: 0.43896484375 ms
found icon community-url
as data url: 0.0400390625 ms
as blob url: 0.588134765625 ms
found icon community-wiki
as data url: 0.06298828125 ms
as blob url: 1.35888671875 ms
found icon community-xmpp
as data url: 0.07177734375 ms
as blob url: 0.761962890625 ms
found icon community-youthmappers
as data url: 0.056884765625 ms
as blob url: 0.843994140625 ms
found icon community-youtube
as data url: 0.050048828125 ms
as blob url: 0.435791015625 ms
found icon community-zulip
as data url: 0.041015625 ms
as blob url: 0.6640625 ms

This was done!  🎉
Was a bit of a journey but it sets us up to have much better texture management across the whole app.  The TextureManager now manages the atlases for not just the icons and symbols (this issue), but also the tiles and text too.
481a6d5b5 Restore the Mapillary objects and signs
5cad331ef Restore the pattern textures
dd24e912f Use Symbol Atlas to manage SVG icons now, they convert on the fly
d065e3309 Make uiDefs a class component, allow spritesheets to load dynamically
c9e8cd31c Use the texture manager for the label atlas too
31fed4351 Cleanups, free resources used by minimap, destroy unused textures
387ed093b WIP: continuing to debug issues with atlas shared between main/mini map
cb66d556b WIP: Move AtlasAllocators from tiles layer to textures class
4404a6feb Simpify code and implement refcounting - use a single Map for storing the textureData
78940aa98 Rework PixiTextures to be the owner of the textures and atlases
324d3b0db WIP on packing svg icons into the Pixi texture atlas


bucket deletion should cascade as index deletions

And, it's ok for any index aliases to have broken pointers to deleted indexes.

Going to close this one here in couchbaselabs/cbft issues, as it's now being tracked here: https://issues.couchbase.com/browse/MB-17015


Is it possible to inject(using plugin) Instrument Template in Project using BluePill ?

Hi,
Is there any plugin to Insert  Instrument Template in project.

I'm not sure what are you looking for... @duttaz more detail?

Thanks for quick response. I want track leaks in project using Bluepill

i don't think it is a good idea to bundle Bluepill (a test tool) with instrument tool (similar as in Xcode, you can't test & instrument in the same time), but if you figured out an easy way to do them in same time, feel free to propose and send pr.


Avoid opening/closing PRs which are already merged (#25883)

Manually backport #25883
Related to #25902

Needs 🪄 merge.


RFC: remove blanket ext implementations

Rendered
Previous discussions:
https://github.com/rust-lang/rust/issues/19435#issuecomment-65443991
https://github.com/rust-lang/rfcs/pull/445#issuecomment-65433687
https://github.com/rust-lang/meeting-minutes/blob/master/weekly-meetings/2014-11-25.md#extension-traits
Considering that I cannot get a good answer on how to work around issues with the new system, I think this is worth revisiting.
http://stackoverflow.com/questions/27267767/working-around-the-limitations-of-extension-traits

@skade
I'm sorry for taking so long to get back to you on this RFC; I've gotten quite behind.
While I think the concern here is legitimate for sure, I agree with the comments @thestinger made in your links above: the right way to solve this problem, in general, is through "specialization". That is, we clearly need a way to provide blanket implementations that can also be overridden for more specific types. This is a frequently requested feature, and I suspect it will be investigated soon after 1.0.
On the other hand, the downside of your proposal here is not too serious, since the extra impl is easy to write, and if you forget it, you will quickly be reminded when you try to use your iterator. Moreover, even if you've published an API without the IteratorExt impl, it can always be added backwards-compatibly.
So, this is a balance between locking into a solution that's better short-term (as proposed here) or long-term (banking on specialization). Given that specialization is almost certain to happen, I personally lean toward the long-term approach here.

My proposal for handling the iterator optimizations can be done without any new language features. There's no need to have an ugly design with both duplicated implementations and absolutely no way of handling methods like skip that are implemented with adaptors. I don't think making these real default methods and overriding them makes any sense at all.

@thestinger Ah, sorry, I missed your second comment on the thread and assumed you were talking about specialization.

@aturon I'd also like to note that the linked stackoverflow question has a solution: if the function is implemented on the struct, it will be preferred to the trait. This helps in this case at least.

@skade it wouldn't be preferred in generic code. For example:
fn count_iter<T: Iterator>(t: T) -> usize { t.count() }

#[derive(Copy)]
struct MyItr;
impl MyItr {
    fn count(self) -> usize { println!("MyItr.count was called!"); 0 }
}

impl Iterator for MyItr {
    type Item = bool;
    fn next(&mut self) -> Option<bool> { None }
}

fn main() {
    let it = MyItr;
    println!("{}",count_iter(vec![1,2,3,4].into_iter()));
    println!("{}",count_iter(it));
    println!("{}",it.count());
}

Will only print the silly message once, for the last statement.

@thiez Right. I didn't express that properly, updated the comment. Thank you!

FWIW, it's looking likely that we'll be able to merge back in IteratorExt regardless.

Excellent, that should solve this issue nicely.

I'm going to go ahead and close this RFC for now; once the where Self: Sized treatment of object safety is in place, we plan to remove the extension trait here.


Error installing Jira when SITEURL is too long

@AGMETEOR there seems to be an additional issue with this.
The code change you have made to the key length is working. When I look in the .json I can see that it now matches the end of the URL and the key length is now well below the max of 80.
However, this still does not allow me to install the app in Jira. We seem to be hitting a different validation in Jira where it is looking not at the key but the whole URL.
/name: string "Mattermost Plugin (https://longurltotestjirawithfirurllength.test.mattermost.cloud)" is too long (length: 83, maximum allowed: 80)

Please let me know if you see a solution to this issue. I'm not sure why it cares what the URL is. Maybe it's looking at the address the .json is being provided from?

@DHaussermann I am making some research on why this happens. Hopefully, will get back with a solution.
----> Update
Looking at the error closely, the problem is the name field in the atlassian-connect.json file. It consequently becomes too long as a side effect of the SITEURL being really long. Good thing is this is something we can control.
We just need to agree on a format of how the name should be, and I am 3/5 we run a validation similar to the one we have done on the key field. I would prefer a new ticket created for this and then assigned to me :)
Originally posted by @AGMETEOR in https://github.com/mattermost/mattermost-plugin-jira/pull/465#issuecomment-596180187

@AGMETEOR, for some reason, I cannot assign the ticket to you. If you would like to take it, please assign to yourself :)

@jfrerich I think we need to discuss what the name should look like. A format where it still remains unique to the cloud app.
Cc: @levb


External reference to image.complete property

As discussed in https://github.com/xsleaks/wiki/issues/104 I added an external reference to an "article" which collects all the points raised in the issue.

"it only have the peculiarity that timers aren’t needed: this could lead to an advantage if will come a moment in which browser vendors decide to change the resolution of the performance.now() return value"
I think setTimeout is a timer and it already gets throttled. no idea if the execution order has memory cache check before running the next line.

If its only checking ram that might make it easier to purge.
I know I should stop complaining it does have dark mode.


Possible to change dependency to flask-cors?

Comment:
There are currently both flask-cors and flask_cors packages in conda-forge.  This is inconvenient in case they get out of sync.  There are only a few packages that have flask_cors as a dependency, and this package is one of them.  I just spoke with the maintainer of the flask_cors package and he suggested trying to get other packages to use the flask-cors package instead.

This is fixed in https://github.com/conda-forge/terracotta-feedstock/pull/23


ord wallet --name create is broken

After the update that introduced the wallet --name {walletName} instead of --wallet {walletName} wallet command, the wallet create functionality is broken.
ord wallet --name block999 create fails with:
[2024-01-03T16:07:05Z INFO  ord::options] Connecting to Bitcoin Core at bitcoin:8332/
error: JSON-RPC error: RPC error response: RpcError { code: -19, message: "Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path).", data: None }

What version of ord are you referring to?

ord 0.13.1

ord13 % ./ord --version
ord 0.13.1
ord13 % ./ord --help
Usage: ord [OPTIONS] <COMMAND>

Commands:
  balances  List all rune balances
  decode    Decode a transaction
  epochs    List the first satoshis of each reward epoch
  find      Find a satoshi's current location
  index     Index commands
  list      List the satoshis in an output
  parse     Parse a satoshi from ordinal notation
  preview   Run an explorer server populated with inscriptions
  runes     List all runes
  server    Run the explorer server
  subsidy   Display information about a block's subsidy
  supply    Display Bitcoin supply information
  teleburn  Generate teleburn addresses
  traits    Display satoshi traits
  wallet    Wallet commands
  help      Print this message or the help of the given subcommand(s)

Options:
      --bitcoin-data-dir <BITCOIN_DATA_DIR>
          Load Bitcoin Core data dir from <BITCOIN_DATA_DIR>.
      --bitcoin-rpc-pass <BITCOIN_RPC_PASS>
          Authenticate to Bitcoin Core RPC with <RPC_PASS>.
      --bitcoin-rpc-user <BITCOIN_RPC_USER>
          Authenticate to Bitcoin Core RPC as <RPC_USER>.
      --chain <CHAIN_ARGUMENT>
          Use <CHAIN>. [default: mainnet] [possible values: mainnet, testnet, signet, regtest]
      --config <CONFIG>
          Load configuration from <CONFIG>.
      --config-dir <CONFIG_DIR>
          Load configuration from <CONFIG_DIR>.
      --cookie-file <COOKIE_FILE>
          Load Bitcoin Core RPC cookie file from <COOKIE_FILE>.
      --data-dir <DATA_DIR>
          Store index in <DATA_DIR>.
      --db-cache-size <DB_CACHE_SIZE>
          Set index cache to <DB_CACHE_SIZE> bytes. By default takes 1/4 of available RAM.
      --first-inscription-height <FIRST_INSCRIPTION_HEIGHT>
          Don't look for inscriptions below <FIRST_INSCRIPTION_HEIGHT>.
      --height-limit <HEIGHT_LIMIT>
          Limit index to <HEIGHT_LIMIT> blocks.
      --index <INDEX>
          Use index at <INDEX>.
      --index-runes
          Track location of runes. RUNES ARE IN AN UNFINISHED PRE-ALPHA STATE AND SUBJECT TO CHANGE AT ANY TIME.
      --index-sats
          Track location of all satoshis.
  -r, --regtest
          Use regtest. Equivalent to `--chain regtest`.
      --rpc-url <RPC_URL>
          Connect to Bitcoin Core RPC at <RPC_URL>.
  -s, --signet
          Use signet. Equivalent to `--chain signet`.
  -t, --testnet
          Use testnet. Equivalent to `--chain testnet`.
      --wallet <WALLET>
          Use wallet named <WALLET>. [default: ord]
  -h, --help
          Print help
  -V, --version
          Print version

help still says to use --wallet in 13.1... am i missing a change?

@so7ow change is introduced in https://github.com/ordinals/ord/commit/d791800fa438469ac8102f8f972e2a1e99b16bd4 where --wallet command is replaced with wallet --name. technically it went into v0.14. but issue is there.

@so7ow change is introduced in d791800 where --wallet command is replaced with wallet --name. technically it went into v0.14. but issue is there.

got it. thx.

Thanks! We passed in the wrong client to the descriptor import function. Tests didn't catch it because they were running against a mocked Bitcoin Core. Should be fixed in #2943

Made a new release as well


AMBARI-25787: upgrade gson version to 2.9.0

[AMBARI-25787]

@sandeep318kumar thanks for reporting.  can you please update commit with JIRA id.

@sandeep318kumar thanks for reporting. can you please update commit with JIRA id.

Done.

Can you extract the version to parent pom so maintenance wise will be easy.

Good point.. How about handling in another jira where we can check for all other packages and unify.?

Sounds good 👍

Can you extract the version to parent pom so maintenance wise will be easy.

Good point.. How about handling in another jira where we can check for all other packages and unify.?

Sounds good 👍

thanks

+1 on the latest branch.


Can h1 etc not include full length bold

Just because the
h1 is bold
I want it to come out like this:
# is bold
not like this:
# **is bold**
If I want good Markdown then I do not want the whole of the text in any header to have bold markup. I want my final process to do that if needed.
Can there be an option to strip the bold off headers?

You may have explicitly styled a heading as bold using the B button. In general, GD2md-html only adds bold, italic, etc. if it's been added explicitly in the Doc. For example, this is a conversion of a doc that has one standard h2 and one that's been selected and bolded:
gd2md-html demo/test doc
Standard H2 (style is not bold)
some text
H2 explicitly bold (using B button)
some more text

I understand it is behaving as expected. I'd just like an option to remove bolding or italic or underline when all the text is styled that way in a header. I don't know how to make this a feature request.
The main reason to go to Markdown is to get rid of hidden junk and have simplified markup.
In this case it is making the junk visible. So that is good.
I appreciate this neat tool and writing the text in the sidebar.
I don't need a reply.

I'm going to close this for now. There are many ways to abuse formatting in Google Docs and other word processors. Docs to Markdown cannot anticipate all of them (not easily at least).


Fixed Table of Scores

Moved from calculated scores to fixed table of scores. This allows us to align different scale systems that dont' have the same number / scale of steps along the way.
Reference Table & How I aligned the scores:
Also the CSV are checked in, as well as the file to convert the csv to json in case we want to update how the scores line up.
https://docs.google.com/spreadsheets/d/1c0cZDNnj77UqXfJzvSE1MlwtTxmueqdlXG_RpcSzvqU/edit
The logic for "normalizing" the scores to fit into the acceptable score list (ie. 5.10- == 5.10a) is total spaghetti code but I'm sick of working on this.
Follow up tickets:

Add more testing (I let the app do a lot of the testing for normalizing the yds scores)
Clean up normalization function and maybe pull it out into the exported api
Add French
Add conversion between grades (technically i started it but I didn't test it at all)

@all-contributors please add @gibboj for code & ideas


feature/custom volume for committed cache

Thanks @johnnyaug for making this happen!

Thanks @johnnyaug for making this happen!


Can't match this string "\u001b[?1049h\u001b[?1h\u001b="

"man" command in Linux will produce many escape codes. All of escape codes but this first string "\u001b[?1049h\u001b[?1h\u001b=" can be matched by ansi-regex.
I use strip-ansi to trim "\u001b[?1049h\u001b[?1h\u001b=" ,and get this result "=", not "".

\u001b[?1049h is not a common ANSI code. Neither is \u001b=. Where are they coming from?

In linux, use "man ping" command.  I get the output as following. The string is in the first line. Other ANSI code can be ansi-regexed.
\u001b[?1049h\u001b[?1h\u001b=
\r\nTRACEROUTE(8)             BSD System Manager's Manual            TRACEROUTE(8)\r\n\r\n\u001b[1mNAME\u001b[0m\r\n     \u001b[1mtraceroute\u001b[0m -- print the route packets take to network host\r\n\r\n\u001b[1mSYNOPSIS\u001b[0m\r\n     \u001b[1mtraceroute\u001b[0m [\u001b[1m-adeFISdNnrvx\u001b[0m] [\u001b[1m-A\u001b[0m \u001b[4mas_server\u001b[24m] [\u001b[1m-f\u001b[0m \u001b[4mfirst_ttl\u001b[24m] [\u001b[1m-g\u001b[0m \u001b[4mgateway\u001b[24m]\r\n                [\u001b[1m-i\u001b[0m \u001b[4miface\u001b[24m] [\u001b[1m-M\u001b[0m \u001b[4mfirst_ttl\u001b[24m] [\u001b[1m-m\u001b[0m \u001b[4mmax_ttl\u001b[24m] [\u001b[1m-P\u001b[0m \u001b[4mproto\u001b[24m] [\u001b[1m-p\u001b[0m \u001b[4mport\u001b[24m]\r\n                [\u001b[1m-q\u001b[0m \u001b[4mnqueries\u001b[24m] [\u001b[1m-s\u001b[0m \u001b[4msrc_addr\u001b[24m] [\u001b[1m-t\u001b[0m \u001b[4mtos\u001b[24m] [\u001b[1m-w\u001b[0m \u001b[4mwaittime\u001b[24m]\r\n                [\u001b[1m-z\u001b[0m \u001b[4mpausemsecs\u001b[24m] \u001b[4mhost\u001b[24m [\u001b[4mpacketsize\u001b[24m]\r\n\r\n\u001b[1mDESCRIPTION\u001b[0m\r\n     The Internet is a large and complex aggregation of network hardware, con-\r\n     nected together by gateways.  Tracking the route one's packets follow (or\r\n     finding the miscreant gateway that's discarding your packets) can be dif-\r\n     ficult.  \u001b[1mtraceroute\u001b[0m utilizes ...

Can't reproduce; the following all show me expected results
$ man traceroute
$ man traceroute > /tmp/mtr && vim /tmp/mtr
$ man traceroute | cat
$ man traceroute | strip-ansi
$ man traceroute | strip-ansi > /tmp/mtr && vim /tmp/mtr

What system are you on? What version of man do you have? Do you have troff or groff installed? What versions are they?

Aha, I think I know what the deal is. \u001b[?1049h seems to be a terminal clear buffer code, though I'm not sure which one. Probably something specific to your termcap entry - also probably why it's one of the first in your man implementation.
Very interesting, thanks for the issue. I'll submit some code for it here in a bit.

Sorry, I make a mistake in OS system. I use OS X10.10.5.
$man -v
man, version 1.6c
I'm write a program for using c language get OSX/linux command output, and put output to JSON. This JSON string will be parsed by javascript. After I tested "man" command, I found this issue.
This issue can be found in every "man traceroute" command. I think the first output line "man traceroute" have invisible characters.

$ groff -v
GNU groff version 1.19.2
Copyright (C) 2004 Free Software Foundation, Inc.
GNU groff comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of groff and its subprograms
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
called subprograms:
GNU grops (groff) version 1.19.2
GNU troff (groff) version 1.19.2
$ troff -v
GNU troff (groff) version 1.19.2a

I have tested "man ping". "\u001b[?1049h\u001b[?1h\u001b=" is still existed.

Interesting, they appear to be standard. Well definitely add this in here in a bit :)
:+1: thanks for the report :D

@Qix- Might want to check if it's an issue in Node.js core too and open an issue about it there if so.

@sindresorhus would it be at all beneficial to beef up our own regex and then somehow PR it back into theirs? The one over at node is, well... a mess.

@Qix- Sounds like a good idea, but seeing how little tests they have for it in Node.js core I think they're going to be resistant to major changes. Still worth a try though.

Well tests are easy to write, and we have the mother of all ANSI tests in this (though I found another resource that has quite a few more codes to it).

Just an FYI: The \u001b[?1049h is a CSI sequence supported by (at least) xterm, rxvt-unicode, st, and even the Windows console when ANSI escape codes are enabled. This sequence activates the alternate screen buffer. On those and similar terminals (or when faking those terminals), getting the smcup capability from terminfo will give you that sequence. (\u001b[?1049l is the corresponding code for deactivating the alt screen buffer) There are several other terminals which also support the alternate screen buffer, but which use different codes to activate/deactivate it.
They are a specific instance of the ANSI-standard "Set Mode" and "Reset Mode" sequences detailed in the VT102 User Guide. As mentioned there, the ? is used to denote "ANSI private parameters".

The reason @wahaha88 is seeing these and @Qix- is not is probably because of the terminal being used (or, more directly, the value of the TERM variable). In the future, it might be worth having a look at the ncurses terminfo database for other possible escape codes that may have been missed.

In the future, it might be worth having a look at the ncurses terminfo database for other possible escape codes that may have been missed.

Great idea; I had that idea today too and figured it wasn't the first time someone proposed that.
You're absolutely right. I'll add this to my list to get to in the near future.

Closing this I believe this is fixed. Let me know if that isn't the case.
Thanks for everyone's input!


obstacle avoiding logic interfere with the lighting logic

obstacle avoidance and lighting logic is OK when tested saperately, but one of them not work if both functions are in the same loop. This can be caused by the delay(); function which block the following codes or it can be caused by other unknown issues

It starts working when the delay of the lighting is tweaked to 100ms.


Remove duplicate keybindings

ctrl-enter is duplicated in the same schema.
shift-enter is duplicated in Darwin.
ctrl-shift-backspace is duplicated in Windows/Linux editor.
I'm not an expert on Coffeescript or Atom config, so if there's a valid reason for the duplicates to exist, please let me know.

cleaning up now that Atom is sunsetted


Release 0.8.2 breaks Python 3 compatibility

See https://travis-ci.org/blue-yonder/storefact/jobs/348147545

Closed as Invalid.


FAST.Farm

Dear：
Q1:

Above is my field turbine situation, I set the simulation time to 3600s, and this problem appeared when running to 261s, how should I solve it?
Q2:

The second image is the main file and the third image is the incoming wind file. This error occurs, if I shrink the NY_Low in the main file, my wind field is out of bounds; but if I use the settings of the main file in the picture, I get the error in the first picture, so where should I adjust it?
Your answers are much appreciated！

In the second question, how to adjust the Y-boundary value [-500,500]? I read the manual that it says to adjust those low-resolution quantities in the main file, but adjusting these quantities can only change the boundary of the wind field, how to adjust this Y-boundary value [-500,500]?

Dear @Yongbyon,
It looks like you asked a similar question in a separate OpenFAST issue: https://github.com/OpenFAST/openfast/issues/1907.  I've now responded there.
Best regards,


Updated Elasticsearch support for v.6.0

Documentation ticket: https://mattermost.atlassian.net/browse/MM-37742
Updated:

Install, Deploy, Upgrade, and Scale > Scale Mattermost > Elasticsearch

Updated the overview to specify minimum supported versions for Mattermost v.6.0 versus supported versions for releases prior to 6.0

@wiersgallak - Here is an example of splitting out minimum version support between 5.38 and earlier vs. 6.0 based on my comment in this PR. Thoughts?


Loading dictionary stored as .npz fails

I store a dict (python) using Numpy as follows :
a = {'asd':[1,2,3], 'as':[1,2], 'd':1}
np.savez('temp',a)

However, on trying to load the file in torch, I get the following error :
th> npy4th = require 'npy4th'
                                                                      [0.0950s]
th> arr = npy4th.loadnpz('temp.npz')
array type unsupported[string "arr = npy4th.loadnpz('temp.npz')"]:1: unsupported data type at /users/mohit.jain/torch/npy4th/npy4th.cpp:122
stack traceback:
	[C]: in function 'loadnpz'
	[string "arr = npy4th.loadnpz('temp.npz')"]:1: in main chunk
	[C]: in function 'xpcall'
	...rs/mohit.jain/torch/install/share/lua/5.1/trepl/init.lua:669: in function 'repl'
	...jain/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
	[C]: at 0x00406670

Is there something wrong with what I am doing or is this a bug?

The issue is that you are storing the dictionary object with "np.savez".
When you load this with "np.load", you will find the following:
>>> b=np.load('temp.npz')
>>> b.keys()
['arr_0']
>>> b['arr_0']
array({'as': array([ 1.,  2.], dtype=float32), 'd': array([ 1.], dtype=float32), 'asd': array([ 1.,  2.,  3.], dtype=float32)}, dtype=object)

You end up having the dictionary stored as an array of type "object", and currently npy4th right now has no way of dealing with object types.
Save your npz file as follows:
>>> a=  {'asd':[1,2,3], 'as':[1,2], 'd':[1]}
>>> np.savez('temp', **a)

Notice that for 'd'=[1], I specified the value inside a list, which would cause to get converted into a numpy array or size 1, so it can be read correctly.
Also, you need to unpack the dictionary with **, when you pass it to "np.savez"
th> npy4th.loadnpz('temp.npz')
{
  d : LongTensor - size: 1
  asd : LongTensor - size: 3
  as : LongTensor - size: 2
}

Makes sense. Thank you! :)


wtclient shouldn't connect to tower over tor despite on <IP_ADDRESS>

Background
LND node with Tor enabled and watchtower enabled. Trying to add the local tower results in trying to connect over tor, which obviously fails. I see hree ways to address this:

Easy trivial: Don't route connections to local subnet over tor
Global: Add configuration field --tor.ignore=, listing subnets to not route over tor
Specific: Add configuration field --wtclient.tor_ignore=, listing subnets to not route over tor for wtclient

The node connects to bitcoind on localhost, so this seems to be wtclient-specific
config:
[tor]
tor.active=true
tor.socks=<IP_ADDRESS>:9050
tor.dns=<IP_ADDRESS>
tor.streamisolation=true
tor.control=<IP_ADDRESS>:8989
tor.v3=true
tor.privatekeypath=....
tor.watchtowerkeypath=...

[watchtower]
watchtower.active=true
watchtower.listen=<IP_ADDRESS>:9911
watchtower.externalip=<IP_ADDRESS>
watchtower.readtimeout=15s
watchtower.writetimeout=15s

$ lncli tower info
{
    "pubkey": "deadbeef",
    "listeners": [
        "<IP_ADDRESS>:9911"
    ],
    "uris": [
        "deadbeef@<IP_ADDRESS>:9911"
    ]
}

$ lncli wtclient add deadbeef

{

}

$ lncli wtclient towers
{
    "towers": [
        {
            "pubkey": "deadbeef",
            "addresses": [
                "<IP_ADDRESS>:9911"
            ],
            "active_session_candidate": true,
            "num_sessions": 0,
            "sessions": [
            ]
        }
    ]
}

Log:
2021-08-21 04:27:16.550 [DBG] WTCL: (anchor) Attempting session negotiation with tower=deadbeef
2021-08-21 04:27:16.550 [DBG] WTCL: (legacy) Attempting session negotiation with tower=deadbeef
2021-08-21 04:27:16.578 [DBG] WTCL: (anchor) Request for session negotiation with tower=deadbeef@<IP_ADDRESS>:9911 failed, trying again -- reason: socks connect tcp <IP_ADDRESS>:9050-><IP_ADDRESS>:9911: unknown error general SOCKS server failure
2021-08-21 04:27:16.578 [DBG] WTCL: (anchor) Session negotiation with tower=deadbeef failed, trying again -- reason: session negotiation unsuccessful
2021-08-21 04:27:16.580 [DBG] WTCL: (legacy) Request for session negotiation with tower=deadbeef@<IP_ADDRESS>:9911 failed, trying again -- reason: socks connect tcp <IP_ADDRESS>:9050-><IP_ADDRESS>:9911: unknown error general SOCKS server failure
2021-08-21 04:27:16.580 [DBG] WTCL: (legacy) Session negotiation with tower=deadbeef failed, trying again -- reason: session negotiation unsuccessful

Your environment

version of lnd: v0.13.1-beta

In an attempt to connect over the HS instead, it doesn't seem like the WT HS is initialized properly. Removing the following from config:
watchtower.externalip=<IP_ADDRESS>

Still after restart:
$ lncli tower info
{
    "pubkey": "deadbeef",
    "listeners": [
        "<IP_ADDRESS>:9911"
    ],
    "uris": [
    ]
}

Oddly enough, i see no logs at all from WTWR itself despite setting the level to trace:
[INF] LTND: Version: 0.13.1-beta commit=v0.13.1-beta, build=development, logging=default, debuglevel=debug,PEER=info,SRVR=info,DISC=info,WTWR=trace
The configuration settings for it  obviously do take effect, though

I think this'll be addressed by https://github.com/lightningnetwork/lnd/pull/5410?

God damn it I swear I was looking for issues before submitting - but yes, it should.

@Roasbeef Almost, but not quite. I just want connections to <IP_ADDRESS> to skip tor

The node connects to bitcoind on localhost, so this seems to be wtclient-specific

If this is the case, then you likely don't need to mess with the main Tor behavior at all, and can instead just examine the two connection sites to see why one uses the Tor path and the other doesn't.

Check out this documentation for reaching the tower over a hidden service: https://github.com/lightningnetwork/lnd/blob/master/docs/watchtower.md#tor-hidden-services
You can drop most of the config options you've specified above.

Check out this documentation for reaching the tower over a hidden service: https://github.com/lightningnetwork/lnd/blob/master/docs/watchtower.md#tor-hidden-services
You can drop most of the config options you've specified above.

For sure. I did have this working; the idea here is to not expose it at all in interest of preserving resources and minimize exposure area.
As you note my PR goes way beyond the specific issue here (which was intended as a bug report as opposed to a feature request) but while I was mucking around the code I thought I might as well fill in some missing functionality that I need myself and assume will be useful for others :)

Ah actually, re-reading this again, this just seems to be an general issue in that we should always skip localhost for outbound connections when Tor is active. IIRC, we resolved this issue when trying to to DNS resolutions over Tor, but I guess I thought this was addressed there as well.

Appears to be related to: https://github.com/lightningnetwork/lnd/issues/4191

@Roasbeef Yes, but also in general it can be desirable to do the same for local subnets (e.g. for nodes or services on the local LAN, when using software-defined networking, etc)
I think #5651 should cover any scenario with unsurprising defaults (skip tor only for localhost, 127.*.*.*. ::1).

Just making a note here about the same issue when trying to connect to a neutrino node over the localhost or LAN.
the tor.skip-proxy-for-clearnet-targets=true will be very useful for the not privacy oriented nodes which just want access to the Tor network as well, but it poses the problem of revealing the IP addresses for regular home users.
Being able to specify services (like the wtclient or neutrino) to skip the Tor proxy could be a solution.

@openoms If you patch with #5651 you could just add tor.no-proxy-target=$NEUTRINO_IP/32.
I don't really see a scenario where you would actually want to skip tor for a given IP only for certain services/modules but not for others, and I think users who want to selectively skip tor will know which IPs/subnets are intended statically.
Or do you have some case you feel is not covered?

thanks @3nprob that covers my usecase. Agree that the tor/clearnet connection should be selective to IP addresses rather than services. Great PR!

Thanks 3nprob fixed for me too ..


Allow python::version to contain a point (e.g. python3.7)

Pull Request (PR) description
This worked before #489.
This Pull Request (PR) fixes the following issues
Fixes #508.

@baurmatt Hello, I upgraded to 4.0.0 of this module as I see the bug for containing a point has been fixed - thanks for this.
However, I think there may still be issues here. Using 'python3.7' in this field causes apt to search for 'python3.7-pip'. This produces:
Unable to locate package python3.7-pip
As far as I can tell from research, this package does not exist, and instead people have installed python3-pip along with Python 3.7.
Do you know anything about this?

Shouldn't you be using just 3.7?

My bad, this was the issue. Replacing python3.7 (Who knows why I had this here!) with 3.7 fixed the problem. Thanks @tonythomas01.


support for react 15.5 and higher

Please add support for react 15.5 and higher by replacing in index.js
import React, { PropTypes} from 'react';
with
import PropTypes from 'prop-types'
And use PropTypes directly in DraftJsText.js, UnorderedListItem.js, BlockQuote.js, OrderedListItem.js and TextStyled.js
import PropTypes from 'prop-types'

DraftJsText.propTypes = {
  text: PropTypes.string,
  customStyles: PropTypes.any,
  inlineStyles: PropTypes.array,
};

Thanks, Adri

Hi @Yoruba!
We'll add this support it soon.
Thanks for your contribution.

hey @Yoruba!
We are going to release a react 15.5 compatible version on the next couple days and another version (probably next week) compatible with react-native 0.47.2 + react 16.0.0-alpha12.

Hi @Yoruba!
The first release compatible with React 15.5 is available at NPM (e0cd4c1).


[qt5-base[core]:x64-osx] build failure

Host Environment

OS: macOS 10.14.4
Compiler: Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)

To Reproduce
Steps to reproduce the behavior:
./vcpkg install qt5
Failure logs
Console output:
Building package qt5-base[core]:x64-osx...
-- Figuring out qt target mkspec. Target arch x64
-- Target mkspec set to: macx-clang
-- Host mkspec not set. Qt's own buildsystem will try to figure out the host system
-- Using cached /Users/thor/Development/vcpkg/downloads/qtbase-everywhere-src-5.12.5.tar.xz
-- Using source at /Users/thor/Development/vcpkg/buildtrees/qt5-base/src/5.12.5-009d7e4128
-- Detected OSX SDK Version: 10.15
-- Major.Minor OSX SDK Version: 10.15
-- Enviromnent OSX SDK Version: 10.15
-- Configuring x64-osx-dbg
-- Configuring x64-osx-dbg done
-- Configuring x64-osx-rel
-- Configuring x64-osx-rel done
-- NUMBER_OF_PROCESSORS is 8
-- Cleaning before build x64-osx-dbg
-- Building x64-osx-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: /usr/bin/make -j8
    Working Directory: /Users/thor/Development/vcpkg/buildtrees/qt5-base/x64-osx-dbg
    Error code: 2
    See logs for more information:
      /Users/thor/Development/vcpkg/buildtrees/qt5-base/build-x64-osx-dbg-out.log
      /Users/thor/Development/vcpkg/buildtrees/qt5-base/build-x64-osx-dbg-err.log

Call Stack (most recent call first):
  ports/qt5-base/cmake/install_qt.cmake:91 (vcpkg_execute_required_process)
  ports/qt5-base/portfile.cmake:265 (install_qt)
  scripts/ports.cmake:90 (include)

Error: Building package qt5-base:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: qt5-base:x64-osx
  Vcpkg version: 2020.02.04-unknownhash-external

Contents of the build error log:
ld: warning: directory not found for option '-L/Users/thor/Development/vcpkg/installed/x64-osx/debug/lib/manual-link'
ld: warning: directory not found for option '-L/Users/thor/Development/vcpkg/installed/x64-osx/debug/lib/manual-link'
ld: warning: direct access in function 'QHash<QString, int>::insert(QString const&, int const&)' from file '/Users/thor/Development/vcpkg/buildtrees/qt5-base/x64-osx-dbg/lib/li$
ld: warning: direct access in function 'QHash<QString, int>::insert(QString const&, int const&)' from file '/Users/thor/Development/vcpkg/buildtrees/qt5-base/x64-osx-dbg/lib/li$
ld: warning: direct access in function 'QHash<QString, int>::insert(QString const&, int const&)' from file '/Users/thor/Development/vcpkg/buildtrees/qt5-base/x64-osx-dbg/lib/li$
ld: warning: direct access in function 'QCommandLineParserPrivate::~QCommandLineParserPrivate()' from file '/Users/thor/Development/vcpkg/buildtrees/qt5-base/x64-osx-dbg/lib/li$
ld: warning: directory not found for option '-L/Users/thor/Development/vcpkg/installed/x64-osx/debug/lib/manual-link'
Sorry, "rcc" can not be run on this version of macOS. Qt requires macOS 10.15.0 or later, you have macOS 10.14.4.
make[2]: *** [.rcc/qrc_mimetypes.cpp] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [sub-corelib-make_first] Error 2
make: *** [sub-src-make_first] Error 2

Additional context
I did update vcpkg to the latest version and I've also installed the latest version of Xcode and the CLI tools.
When I installed vcpkg I ran into this issue: https://github.com/microsoft/vcpkg/issues/9029
I fixed it by installing it with the command "CXXFLAGS="-D_CTERMID_H_" ./bootstrap-vcpkg.sh". Don't know if this might be related.

@Neumann-A Could you take a look?
Thanks.

@JackBoosY : Since I don't have an OSx system I can not say a lot about this error. But according to the error message:
Sorry, "rcc" can not be run on this version of macOS. Qt requires macOS 10.15.0 or later, you have macOS 10.14.4.
I qmake/configure somehow detects the wrong SDK version while building.
On the other hand the logic I implemented within the portfile detected 10.15:
-- Detected OSX SDK Version: 10.15
So the trick is here to figure out why there is a version mismatch between the logic in the portfile and the internal build of qt. Probably a search for "can not be run" in the source and builddir can shed more light on the error. And also having the configure logs could help.

Thanks for you comment, it gave me enough clues to figure it out.
In "portfile.cmake" the command "xcrun --show-sdk-version" is executed to determine the macOS sdk version. The QMAKE_MACOSX_DEPLOYMENT_TARGET environment variable is set with this value.
However, this command only returns the macOS sdk version number, which is not necessarily the version of the currently installed OS. In my case it returns 10.15 while my OS is on 10.14.
I fixed it by adding "set(VCPKG_OSX_DEPLOYMENT_TARGET "10.14")" to the x64-osx triplet file.
Perhaps the xcrun command should be replaced by something like "sw_vers -productVersion | cut -d '.' -f 1,2"? This does return the currently installed macOS version.

How to solve this problem?

Use command sw_vers -productVersion can show the macOS system version.

Hi guys, I'm trying to fix this issue in https://github.com/microsoft/vcpkg/pull/21486, can anyone test that?
Thanks.

Fixed by #21486.


Add hi and goodbye

Pull request

[x] I have read and agreed to the code of conduct.
[x] I have read and complied with the contributing guidelines.
[x] What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
[x] I have tested all of my changes.

So I think we should have hello and goodbye messages that are sent when we are added/removed from a guild. This will allow us to include things like:

Links to our panel
A removal survey
Awareness on things people need to be aware of
Etc etc

This is just an example, we'll come up with a lot better one in future. And imo we should always act if we have done something wrong from a marketing angle (Because if we've lost a server, we've failed 😂 )

Im against the idea of using DM's to convey these types of things. if people leave, so be it. they dont want to be pestered by surveys or messages. they just want to leave since they are done investigating the server. having a welcome message in a text channel to show the rules and welcome them is something I like tho.

Im against the idea of using DM's to convey these types of things. if people leave, so be it. they dont want to be pestered by surveys or messages. they just want to leave since they are done investigating the server. having a welcome message in a text channel to show the rules and welcome them is something I like tho.

This is for when the bot is removed or added from a guild, not when a person leaves or joins

Im against the idea of using DM's to convey these types of things. if people leave, so be it. they dont want to be pestered by surveys or messages. they just want to leave since they are done investigating the server. having a welcome message in a text channel to show the rules and welcome them is something I like tho.

This is for when the bot is removed or added from a guild, not when a person leaves or joins

erhm, shush. I knew that 😓

@mrjvs Opinion on sending in the first available channel if DMs not available?

@mrjvs Opinion on sending in the first available channel if DMs not available?

dont, dm's are disabled for a reason. and on big servers you dont want bots to randomly send messages.

@mrjvs Opinion on sending in the first available channel if DMs not available?

@binaryoverload I know I wasn't asked but I think it should just DM, not send to first available channel

@binaryoverload
I know I was not involved but:
What if we searched for a channel named something like "bot-channel"
If channel don't exist just leave it?

@binaryoverload
I know I was not involved but:
What if we searched for a channel named something like "bot-channel"
If channel don't exist just leave it?

We would have to do a lot of research to effectively put this in place, because loads of people call it loads of different things

True

@binaryoverload
I know I was not involved but:
What if we searched for a channel named something like "bot-channel"
If channel don't exist just leave it?

We could do that but like @JamesHawkinss said people call them loads of different things. I'll just remove it :D


implemented a unit test for check valid postcode query handler

worked on the issue #785

@samqty, thanks you your contribution. Nice use of test theories here! This unit test really does test every possible combination of data coming into the handler on the message to run through the LINQ query in the handler.
There are some weird white-spacing issues with [], (), and <> signs.
private List< PostalCodeGeo > _postalCodeGeos;
_postalCodeGeos[ 0 ].City
new CheckValidPostcodeQueryHandlerAsync( Context )

can you fix these spacing issues? Once that done, we can accept this PR.

@tonysurma @MisterJames this PR looks good :shipit:
Thanks for the contribution @samqty!


Custom scroll bar added

Please fill out the template below

Did you read the instructions in README ?
Yes
Solves which issue ?
Fixes #366
Give discription.
[Write Here. Be Specific]
Checklist
(To mark the checkboxes use x within the box brackets)

[x] Signed the code of conduct.

[x] Have you added yourself to the participants.

[x] Joined opencode zulip server.

https://rattlecode17sh.github.io/Opencode-Collaborative-19/
@ananya-agrawal please review


GroceryList

Good morning Nathanael
I need help, I could provide the code of GroceryList3.png that has fluentreports in its repository.

The code is part of demo6.js:
https://github.com/NathanaelA/fluentreports/blob/master/examples/demo6.js#L72


Sourcecode fmus

@dafred94 can you provide a minimal doc-string and minimal test?
Would be much appreciated!

closes #3

Codecov Report

Merging #4 (6ec62ed) into main (d3efd1e) will increase coverage by 1.08%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   55.73%   56.81%   +1.08%
==========================================
  Files           3        4       +1
  Lines          61       88      +27
==========================================
+ Hits           34       50      +16
- Misses         27       38      +11

Impacted Files
Coverage Δ

src/FMIZoo.jl
75.00% <ø> (ø)

src/util.jl
55.07% <41.17%> (-5.72%)
:arrow_down:

src/mosGenerators.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3efd1e...6ec62ed. Read the comment docs.


Remove "Skip to Nav" Link

Andrew recommends we remove our "skip to nav" link, as a screen reader can't read it and it isn’t keyboard focusable (uses display:none).
This is a WCAG 2.0 2.4.7 failure (where no focus is visible)

I wanted to ask @awkawk: Until we move the nav to the top, shouldn't we restyle this instead of removing it? Restyle it to be invisible, but screen-reader accessible, I mean.

Options:

Leave it and make it screen reader accessible. This also opens the possibility of measuring whether anyone every clicks on this link, which would be interesting.
Leave it and not only make it SR accessible but make it work for keyboard users also (possibly it appears when the previous item is blurred due to tabbing so the focus lands on it only when a keyboard user might need it.  Also allows for measurement.
Remove it  -  Screen reader users can access a list of regions (ctrl+insert+r in JAWS, NVDA+F7 in NVDA) so this may not be needed. We haven't had any complaints (have we?) and we're planning to fix the structure so there is an argument to be made that if anyone needs it it is sighted keyboard-only users.

Ok cool. I’m fine removing it if that’s your preference, just wanted to make sure!

On May 4, 2015, at 10:37 AM, Andrew Kirkpatrick<EMAIL_ADDRESS>wrote:
Options:

Leave it and make it screen reader accessible. This also opens the possibility of measuring whether anyone every clicks on this link, which would be interesting.
Leave it and not only make it SR accessible but make it work for keyboard users also (possibly it appears when the previous item is blurred due to tabbing so the focus lands on it only when a keyboard user might need it. Also allows for measurement.
Remove it - Screen reader users can access a list of regions (ctrl+insert+r in JAWS, NVDA+F7 in NVDA) so this may not be needed. We haven't had any complaints (have we?) and we're planning to fix the structure so there is an argument to be made that if anyone needs it it is sighted keyboard-only users.

—
Reply to this email directly or view it on GitHub https://github.com/alistapart/AListApart/issues/173#issuecomment-98731308.

Ahh, actually, @awkawk, @mikepick just reminded me that the Skip to Nav link actually serves as the hook for our hamburger menu.
So, I think I will go with option #1, and we will visit making it keyboard accessible when we do the same for the nav.
Does that work?

Sure.


[Template Submission]

Important:
Please make sure to first read and sign the agreement at ahoy.twilio.com/code-exchange-community before proceeding here.
What's the use case for the template?
This template helps users send text message reminders to themselves. Specifically, this template was used to send a daily text message reminder to user to feed their sourdough starter. A full tutorial and more on what sourdough starter can be found in my blog post, So You Forgot to Feed Your Sourdough Starter Baby? 🍞👶
What's the programming language?
JavaScript/Node.js

For any Twilio Function templates please submit them via a pull request to github.com/twilio-labs/function-templates
N/A

Template GitHub URL:
https://github.com/sophi-li/sourdough-timer
Author Information (please fill out):

Author name (or organization if submitted on behalf of a company): None
Author GitHub organization/user:https://github.com/sophi-li
GitHub username you used to sign the Agreement: sophi-li

Additional dependencies:
Azure Timer Function
Checklist:

Please check every part of this checklist for us to process your request. You can do this by marking them with [x] instead of [ ].

[x] I've filled out the form at ahoy.twilio.com/code-exchange-community
[x] My sample application is open source and has a permissive license such as MIT or Apache-2
[x] There are no known security vulnerabilities and I'm following security best practices
[x] I've read Twilio's best practices coding guidelines for my project
[x] I agree and adhere to the Code of Conduct
[x] The template has been authored by me / or my organization and will be kept up-to-date. If the template will not longer be maintained, I'll notify this project.

Sorry for the delay @sophi-li but congratulations you are now on the Twilio CodeExchange and you are the first community member to be published there 🎉
https://www.twilio.com/code-exchange/automatic-sms-reminders


Add find_task_logs function

Request Type
Feature Request
Problem Description
This function allows searching for task logs

@nadouani I've found this issue when searching for a solution, after I've discovered get_task_logs() method only returns 10 results, with no option to change it.
I already wrote the version that behaves just like get_case_tasks() (allows you to pass params and additional query criteria).
I would happily sent it as a pull request, just want to discuss one thing -- name of the method.
I believe this should replace existing get_task_logs() implementation, for the sake of naming consistency.
I mean, if get_case_tasks() returns all the tasks, why does get_task_logs() not return all the logs? I'd say it's even more useful, as I think there's higher probability of having > 10 log entries in a task, than having > 10 tasks in the case. Isn't it?
Also, this woudn't break compatibility, because if you don't provide params, nor query, you'd call the method exactly the way it is now.
But, if you prefer other name (find_task_logs()?), and you want to keep existing get_task_logs() as is, I'm OK with that as well.
Thank you!

I had to delete the original PR, because I've messed something up when doing the rebase. This issue is now addressed in the following PR: https://github.com/TheHive-Project/TheHive4py/pull/200

Hello @jnahorny https://github.com/TheHive-Project/TheHive4py/pull/200 is perfect.
could you provide two functions:

find_tasks_logs(**attributes): generic function to search for logs
get_task_logs(task_id, **attributes) that calls find_tasks_logs by specifying the ParentId` criteria

If you don't have time, I can make it too by using your PR.

Hello @jnahorny #200 is perfect.
could you provide two functions:

find_tasks_logs(**attributes): generic function to search for logs
get_task_logs(task_id, **attributes) that calls find_tasks_logs by specifying the ParentId criteria

If you don't have time, I can make it too, using your PR.

@nadouani  It's not that I don't have time, but I'm not sure how to do it. I guess it would be probably faster for you to do it, instead of explaining to me how to do it. But I'm open to both scenarios :)

Sounds good, I'll do it using your PR ;)

Sounds good, I'll do it using your PR ;)

Thank you! I can't wait for it to be in production!

@jnahorny take a look to b009365 to understand what I meant.
Thanks for your contribution


Add book and Label class, Attributes and Implement methods

In this PR I added the Label class associated with the Item class and the Book class which is a child of the Item class. I also implemented the methods.
Below are the highlights
Create a Book class in a separate .rb file.
Create a Label class with an association to the Item class (in a separate .rb file).
Book class properties visible in the diagram defined and set up in the constructor method.
Label class properties visible in the diagram defined and set up in the constructor method.
Implement methods:

add_item method in the Label class
should take an instance of the Item class as an input
should add the input item to the collection of items
should add self as a property of the item object (by using the correct setter from the item object)

can_be_archived?() in the Book class

should override the method from the parent class
should return true if parent's method returns true OR if cover_state equals to "bad"
otherwise, it should return false

Cheers and Happy Reviewing!

Hi @businesskaniki , thank you for the review!


Spell check adjustments

1. Issue, if available:
2. Description of changes:

two typo fixes (found while clearing things out)
lots of pattern additions (a number are simple copy paste from https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns that I should have done initially)
limit running the action on aws/karpenter (and check-spelling/karpenter) per @ellistarn
promoting the items that remained from expect.txt to allow.txt -- this effectively moves them into the "dictionary" -- check-spelling doesn't prune dictionary entries.
switching to only checking the spelling of files changed since the last push -- note that this may result in surprises, each additional push to a branch will only result in the files changed for that push being checked and not files only changed in commits previously pushed on the same branch. -- If you perform a force-push that goes backward, the files considered will be those changed between the new head and the previous head (which is potentially no longer part of the standard graph) and not the based of the branch.

3. Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: link to issue
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing for now. Let's stay in touch on the latest w/ check-spelling!


Add OAuth callback support

Extends the authentication service to add custom OAuth callback support. As described here: https://www.etsy.com/developers/documentation/getting_started/oauth

@maxim-skuvault no organization in particular. But I worked/work on an Etsy integration into a proprietary product and used your library for that. During development I noticed some bugs and missing features that I wanted to contribute back so we don't have to rely on a separate and modified copy of your library.

Closing. This repo will no longer be updated due to our migrating to a different Etsy library for Etsy V3 API


Error: Expected identifier, string or number (Nuxt 12.15.0)

Versions

nuxt: v2.15.0
node: v14.15.4
OS : Windows 10 20H2
browser: Edge 18

Reproduction
Expected identifier, string or number
After upgrading Nuxt to version 2.15.0 in Edge 18 and IE 11, I got an error like this which blocks the application

@Sendoo Would you try adding 'ufo' to build.transpile?

@Sendoo Would you try adding 'ufo' to build.transpile?

It helped, thanks.
There is no more error.
Will this be fixed in future releases? 🙂

This is just a temporary fix, I am getting other errors after fixing UFO. The promise polyfill is not added anymore.


[BugFix] Fix use-after-free when graceful exit

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：
Fixes https://github.com/StarRocks/StarRocksTest/issues/906
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run all

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


NIFI-4534 Choose Character Set for CSV Record Read/Write streams

I've been trying to read UTF-8 BOM CSV files with occasional Chinese in them. I've been running into a lot of trouble with the strings being read as junk characters.
The strange thing is, though I added two unit tests, these tests pass without this code change in place in my environment (I know... not great tests). But with this code change in place CSV now works great on my actual server.
According to the docs, if you don't explicitly specify UTF-8 then the read/write streams will use the environments default encoding. It feels likely that my default environment for my unit tests is UTF-8, but is something different when I run NiFi. Not exactly sure.
With this change in place, the code now matches the example code from Apache Commons CSV documentation on how to handle files with a BOM. The BOM was being handled already through the use of a BOMInputStream, but no encoding was being explicitly set. https://commons.apache.org/proper/commons-csv/user-guide.html#Handling_Byte_Order_Marks
I've made the default value UTF-8, but users are free to pick any encoding.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31 Centralizing the property sounds good. Done.

Thanks @patricker, full build with contrib check raised two issues:
[WARNING] src/main/java/org/apache/nifi/csv/CSVReader.java[36:8] (imports) UnusedImports: Unused import - org.apache.nifi.processor.util.StandardValidators.
[WARNING] src/main/java/org/apache/nifi/csv/CSVRecordSetWriter.java[32:8] (imports) UnusedImports: Unused import - org.apache.nifi.processor.util.StandardValidators.

I fixed the checkstyle issues while merging into master. LGTM. +1


[Experiments] Wait for user to finish input

Wait for user to finish input in the QuickPick's Inputbox for performance reasons. Throttle the number of handler triggers.


Various small frontend bugs

Describe the bug

[ ] completed games are not rendered in the dashboard cards (probable due to index OOB error)
[ ] game page displays game ID instead of game name
[ ] email verification should link to deployment website instead of localhost
[ ] game page should have a button to copy game invite id or link
[ ] after game creation or join, redirect to that game's page instead of the dashboard
[ ] make sure users can't join the same game twice

Screenshots
None, feel free to add
Additional context
Mostly from Tony's email after MVP presentation. Feel free to move into separate individual issues if anything seems too big to be compiled here.

@tomatocat do you want to fix the OOB error from the canvas component, or should I fix it on my end?

I think this relates to the dashboard cards on your end. Once the index is equal to the size of the player array, we know the game is over. In that case we should directly display on the card that the game is ending without even entering the logic that tries to index into the player array.


Error in playback issue

com.sedmelluq.discord.lavaplayer.tools.FriendlyException: Something broke when playing the track.         at com.sedmelluq.discord.lavaplayer.tools.ExceptionTools.wrapUnfriendlyExceptions(ExceptionTools.java:40)         at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:102)         at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayerManager.lambda$executeTrack$1(DefaultAudioPlayerManager.java:348)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalStateException: Must find action functions from script: /yts/jsbin/player-vflBjp0_H/en_US/base.js         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeSignatureCipherManager.extractTokensFromScript(YoutubeSignatureCipherManager.java:185)         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeSignatureCipherManager.getCipherKeyFromScript(YoutubeSignatureCipherManager.java:141)         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeSignatureCipherManager.getValidUrl(YoutubeSignatureCipherManager.java:100)         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.loadBestFormatWithUrl(YoutubeAudioTrack.java:99)         at com.sedmelluq.discord.lavaplayer.source.youtube.YoutubeAudioTrack.process(YoutubeAudioTrack.java:60)         at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.execute(LocalAudioTrackExecutor.java:90)         ... 4 common frames omitted
Whenever I try to play a song I get this error, but when i try to play anything else that isn't a song it works fine.

Update lavalink


Kmod compilation is failing on Debian

Describe the bug
I have attempted to install Falco on Debian 12, and it appears that the kmod compilation is failing.
[POST-INSTALL] Call 'falco-driver-loader --compile module':
* Running falco-driver-loader for: falco version=0.36.2, driver version=6.0.1+driver, arch=x86_64, kernel release=6.1.69-1-amd64, kernel version=1
* Running falco-driver-loader with: driver=module, compile=yes, download=no

================ Cleaning phase ================

* 1. Check if kernel module 'falco' is still loaded:
- OK! There is no 'falco' module loaded.

* 2. Check all versions of kernel module 'falco' in dkms:
- OK! There are no 'falco' module versions in dkms.

[SUCCESS] Cleaning phase correctly terminated.

================ Cleaning phase ================

* Looking for a falco module locally (kernel 6.1.69-1-amd64)
* Filename 'falco_debian_6.1.69-1-amd64_1.ko' is composed of:
 - driver name: falco
 - target identifier: debian
 - kernel release: 6.1.69-1-amd64
 - kernel version: 1
install: /usr/lib/gcc/x86_64-linux-gnu/12/
* Trying to dkms install falco module with GCC /usr/bin/gcc
Sign command: /usr/lib/linux-kbuild-6.1/scripts/sign-file
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
Creating symlink /var/lib/dkms/falco/6.0.1+driver/source -> /usr/src/falco-6.0.1+driver
* Running dkms build failed, couldn't find /var/lib/dkms/falco/6.0.1+driver/build/make.log (with GCC /usr/bin/gcc)
install: /usr/lib/gcc/x86_64-linux-gnu/12/
* Trying to dkms install falco module with GCC /usr/bin/gcc-12
Sign command: /usr/lib/linux-kbuild-6.1/scripts/sign-file
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
* Running dkms build failed, couldn't find /var/lib/dkms/falco/6.0.1+driver/build/make.log (with GCC /usr/bin/gcc-12)
* Trying to load a system falco module, if present
Consider compiling your own falco driver and loading it or getting in touch with the Falco community
dpkg: error processing package falco (--configure):
 installed falco package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 falco
E: Sub-process /usr/bin/dpkg returned an error code (1)

After some debugging, it seems that the problem is caused by incorrect kernel version detection in the falco-driver-loader -> get_target_id() -> Debian section on line 169:
if [[ ${DRIVER_KERNEL_VERSION} =~ ([0-9]+\.[0-9]+\.[0-9]+\-[0-9]+) ]];`

DRIVER_KERNEL_VERSION is getting the version from the command uname -v, which results in the following output on Debian 12:
#1 SMP PREEMPT_DYNAMIC Debian 6.1.69-1 (2023-12-30)

However, the correct parameter for dkms is that from uname -r, which in this case is:
6.1.0-17-amd64

So, if I replace DRIVER_KERNEL_VERSION with DRIVER_KERNEL_RELEASE on line 169 in falco-driver-loader, it will compile without a problem.
Tested on Debian 11 and 12.
How to reproduce it

Install falco acording to offic docs https://falco.org/docs/install-operate/installation/ on Debian 12
Select kmod
DKMS compilation will fail with an error above

Expected behaviour
Seccessfull installation and kmod compilation.
Environment

Falco version:

Tue Jan  9 10:54:24 2024: Falco version: 0.36.2 (x86_64)
Tue Jan  9 10:54:24 2024: Falco initialized with configuration file: /etc/falco/falco.yaml
Falco version: 0.36.2
Libs version:  0.13.4
Plugin API:    3.1.0
Engine:        26
Driver:
  API version:    5.0.0
  Schema version: 2.0.0
  Default driver: 6.0.1+driver

System info:

  "machine": "x86_64",
  "nodename": "debian",
  "release": "6.1.0-17-amd64",
  "sysname": "Linux",
  "version": "#1 SMP PREEMPT_DYNAMIC Debian 6.1.69-1 (2023-12-30)"

OS:

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian

Kernel:

Linux debian 6.1.0-17-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.69-1 (2023-12-30) x86_64 GNU/Linux

Installation method:

DEB

Hi! Thanks for opening this issue! Can you try using latest packages from Falco master?
Falco now makes use of the new driver loader implementation within falcoctl that should fix your issue!

or maybe if you don't care about the driver used you can try to use the modern-bpf driver, it should work out of the box, without downloading anything

I strongly encourage the modern-bpf.  I wrote the docs for rpm kmod in uefi mode, just use the modern-bpf, i think it's a stable choice now.

Yes, modern-bpf works fine. We are using kmod on centos/rocky linux in production, so it was the first thing that we tried. I suppose now, there shouldn't be much of a difference between kmod and bpf in terms of performance. We will test it on debian-based machines and might even switch to the bpf driver on rocky-based machines later. Thanks.

The Kmod should be a little bit more efficient because there is no overhead from the BPF virtual machine, but the modern-bpf should work fine in many cases, maybe just give it a try and see if it can work for your use-case :)

I will close this! Feel free to reopen if this is still an issue


Feature: support SimGrid

This issue is just to track an already existing PR #16

PR #16 was incorporated via PR #51 . However, there must be some work done to proceed to SimGrid simulations, as SimGrid threads fight for resources with Python threads and simulations are way slower, than real computations.


is there a way to use pylxd.client talk to specific api url directly, like we use requests?

is there a way to use client.api  to send GET request to cluster host within pylxd  client.
such as:
send GET to https://<IP_ADDRESS>:8443/1.0/cluster/members,  then we will have 3.0 api response directly.

Unfortunately, clustering is not yet supported in the pylxd API.  Please see #292.
Unfortunately, the API is not flexible enough to enable arbitrary endpoints to be accessed, although that is something that I'm considering with a new major version (but I've only got a proposal for that at present: #283.


Include StringDecoder implementation

Please offer a StringDecoder so that the send & receive API are more similar.

To be honest, the Encoder interface and StringEncoder don't actually provide all that much benefit, so I'm planning to eventually remove them and have both send and receive use []byte directly. This is a breaking API change however, so it is tracked at https://github.com/Shopify/sarama/wiki/Ideas-that-will-break-backwards-compatibility.


[WIP] Fix image metadata for social media sites

Currently there's a variety of issues that will cause the posts we put on social media to have problems with the included images:

[x] Fix issue with default thumbnail being the wrong aspect ratio (closes #148)

I've put together a modified version of the default thumbnail in commit c3454b8 but this is merely a quick fix for the aspect ratio, I just increased the canvas size of the image so it had the right dimensions. We could likely make something better that's using the newer aspect ratio.

Going to defer #147 until later


Not able to drag-scroll vertically

Hi.
Is there any necessary css that needs to be applied to the container that i'm making drag-scrollable?
So far I've only added "drag-scroll" and [drag-scroll-disabled]="disabled" to my container div, and I am only able to scroll horizontally.
I can see that these cssproperties have been applied to the container :
overflow: auto;
white-space: nowrap;
display: block;
Also, my horizontal scrollbar disappears as soon as i add the drag-scroll to my div. However the vertical scroll-bar remains.

Hi @paw1 thanks for reporting this, can you give me the flavour of your OS and some code about your drag-scroll component?

Hi @bfwg , I'm running chrome 59 on windows 10. I'm using ng2-admin template to build my webapp. I also found that setting scrollbar-hidden to true messed up my page (snapshot attached).

With scrollbar-hidden = TRUE :  (notice the extra container div that is applied just outside of the div with drag-scroll)

Code :

Withscrollbar-hidden = FALSE

Code :

In
, have you declared disabled and false in your component class? If not, it should be written this way.

*note: no square brackets.

Hi @bfwg , I have indeed defined a boolean variable 'disabled' in the component class. As for scrollbar, i think you we need to define "false", but I went ahead and changed it to [scrollbar-hidden]="scrollHidden" and defined a boolean variable scrollHidden.
I have a suspicion that the problem lies somewhere near  the extra container div that is applied just outside of the div with drag-scroll (shown in the first image).

Hi @paw1 , have you applied any css on id "kanban-board"? What happen if you wrap "kanban" in another div like the below?

    ...

Or wrap kanban around a div like:

    ...

Hi @bfwg , let me get back to you in some time. Currently upgrading old code to support angular 4.

@paw1 no rush 😄


Extensions search is including non validated extensions

Open Extensions viewlet and search for nox
🐛 Results include non validated extension Nox Caleo which is not found in Marketplace

I can no longer repro this. So closing.

@sandy081 - this might not be reproducing since the extension is now validated. You would need an extension which fails the version validation on Marketplace.
I believe #82746 is also related to this.

@kesane-msft It would be great if you can help me coming up with such an extension?

@sandy081 - try having an SVG badge from the non-whitelisted sources. That should endup giving you a version validation error.

I came up with a vsix that has non-whitelisted svg path in the read me and I cannot publish it from Marketplace website has it is says invalid manifest.
@joaomoreno @kesane-msft it would be great if you can suggest a way to publish such an extension.

Fixed by https://github.com/microsoft/vscode/issues/98366


how to draw a model with dynamic input

Hi from Thailand.
just getting start with maker.js and new to Github too.
I want to make web app that can create box with finger joint for Laser cut in DXF file.
I try draw a easy rectangle.
Output normal when I define width and height and code like width=300, height=500 .
https://jsfiddle.net/parinya_pusree/mb2a5kyo/
but
when get values from input box. Output always be in "L" shape.
I don't know what is going on.
Here is my code  https://jsfiddle.net/parinya_pusree/z5y70vw4/1/
Any help would be appreciate. Thanks.

Hello, and welcome to Maker.js :)
Your input values are coming in as strings. Maker.js will require these to be numeric.
I changed your code by coercing to numeric with the + operator:
var w = +document.getElementById("boxwidth").value;
var h = +document.getElementById("boxheight").value;

Of course, this only works when the values within the textbox are actually numbers. Here is a great article showing several other ways of converting to number and their outcomes:
https://medium.com/better-programming/what-is-the-best-way-to-convert-a-string-to-a-number-in-javascript-67052a1706c6

Hello, and welcome to Maker.js :)
Your input values are coming in as strings. Maker.js will require these to be numeric.
I changed your code by coercing to numeric with the + operator:
var w = +document.getElementById("boxwidth").value;
var h = +document.getElementById("boxheight").value;

Of course, this only works when the values within the textbox are actually numbers. Here is a great article showing several other ways of converting to number and their outcomes:
https://medium.com/better-programming/what-is-the-best-way-to-convert-a-string-to-a-number-in-javascript-67052a1706c6

It is work. Thank you very much.


Current Locale

I'd been trying to determine the current language used by Lingua (so I can show it in my View), but i have found only 2 complicated ways:
1.- Replicate some of the existing code in lingua.js#lingua(req, res, next)
2.- Read the cookie and store the value somewhere
Did I miss something?

Sorry, just found lingua.locale


fixed syntax error in cookiecutter.json

Noticed there was a missing comma in this file, thanks for a good base template!

@blarghmatey can you or @bdero review this?

@BadgerOps Thanks for the fix! I'm glad you like the template. If you don't mind my asking, how did you find it?

My google-fu is strong ;) - I was searching for a base template that included some testing stubs, as I'm looking to tinker around with pyobjects and testing before pushing code up.

You might be interested in checking out the work I did to create a TestInfra state module. It is currently not very well documented but you can take a look at some example usage in the mitodl/rabbitmq-formula
I'm happy to answer questions on its use and suggestions are welcome :)

Awesome, I'll take a look - thanks!