Adding a new api to fetch the health details of the resource "vault". Apart form this this PR also contains some fixes based on  some new rules added in the auto rest linter tool.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@mukum,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Sorry to bother, but reopening PR to test CI builds.

@mukum,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ravbhatnagar please take a look, thanks!

@veronicagg - This may need to be reviewed in person with the Azure API review board. The newly added properties and models are not are not self explanatory. The API that is being added is fine and feedback has been provided on that.

@ravbhatnagar thanks! will wait for API review board sign off.

@mukum @ravbhatnagar have you been able to sync on ARM feedback?

@veronicagg - No, we haven't been able to agree on the right design for this API yet. We are close though and should be able to close today or Monday. @mukum - FYI.

@ravbhatnagar once you're good with the changes on this PR, please label it and let me know, thanks!

@mukum - The change for the new API looks good now. However, as discussed earlier it seems that there are new properties in this swagger that were already added on the service side but getting added to swagger now. Please confirm if thats the case. Because in such cases, an api-version update is required.
@veronicagg - SDK can start reviewing.

thanks @ravbhatnagar.
@mukum have you been able to look into the errors from CI that I pointed out before? Feel free to let me know if you have questions.

@veronicagg
Hi Veronica,
I went through the errors from CL, all the errors are for camel casing of the property name(for the older set of properties name). We have this as one of the backlog items once we move to the newer api version.
One other is the Job object which has few properties other than Id type and Location at the top level. I talked with my colleague regarding the same and as per him we had got exception for this last time. Since we are not upgrading the version of the API we are not fixing it, will take it in the next iteration when we move to the newer api version.

@ravbhatnagar  as discussed earlier, since we have the get and put object schema completely different, hence adding a new property in the get object schema doesn't require a version update.

@mukum there looks to be some model validation errors too, please review: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/264396943#L657

@ravbhatnagar please add the sign-off label once you approve this PR. I see that there are breaking changes being introduced, so I'd like have confirmation on sign-off from ARM team.

@veronicagg - from what I can see in the PR, jobs is an existing model. So issues in the model are older issues. As discussed we will get issues with existing APIs/models fixed in a separate cycle. Other property additions have already happened in the service and these are being added to swagger now.
@mukum - please note that the jobs model will need to be fixed since it contains some top level properties which are not allowed as per ARM RPC. These properties will need to be moved inside the properties bag in your next api-version rev.

Thanks @ravbhatnagar.
@mukum Please add the pending example and open & link the issue we talked about tracking the update of the examples that are failing (due to bug fixes in our tool). With those, I can approve. Thanks!

@mukum any updates?

@mukum please respond to the feedback to avoid  closing this PR due to lack of activity
Thanks
Samer

Thanks @mukum for addressing the issues.
Samples are compliant, though it's good idea to consider making them specific, so that you get more coverage on the properties, you may want to add this to the issue you linked.
Regarding the removed operation, if it's implemented on the service time, it may get reported as not in the swagger by the ARM team, just so that you're aware - FYI @ravbhatnagar

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-python


iOS nesting DrawerNavigator inside StackNavigator creates anomaly when popped

In my app i have three components inside my main stack navigator, something like this.
export default (StackNav = StackNavigator({
  Login: { screen: Login },
  Home: { screen: Home },
  BlankPage: { screen: BlankPage }
}));

Now, my Home screen is in turn a DrawerNavigator object. When i go-back to previous screen from home screen, the Sidebar Drawer component also pops from the stack and looks something like the GIF below. This is not desirable in my app.
I also tried to reset the router when going back from Home screen something like this
DrawerNav.dispatch(
                  NavigationActions.reset({
                    index: 0,
                    actions: [NavigationActions.navigate({ routeName: "Home" })]
                  })
                );

However the same problem persists. Is there a way to get this working?
Thanks in advance :)

Hi, i struggled with this as well, this set up did the trick for me
first in you StackNavigator set:
navigationOptions: {
gesturesEnabled: false
}
then in your HomeScreen set:
const Drawer = DrawerNavigator({
Home: {
screen: MyHomeScreen,
},
Notifications: {
screen: MyNotificationsScreen,
},
});
export default class MyDrawer extends React.Component {
render () {
return (

)
}
}
you may configure you drawer as you desire but export it as part of another class,

@morgerardo That doesn't work.
Here's the example app https://github.com/start-react/native-starter-kit with this issue.

Any update on this?
I have been waiting for this fix

Pinging OP @Jasbir23 since this issue has not been active for a while, and it's related to an old version of the lib. Moreover I think this got fixed via https://github.com/react-community/react-navigation/commit/e6505054bd765f0771aec8c328238b0b4d8ddab9
Please let me know if you want this to remain open, because if I get no answer in the next 7 days I will close it.

@kelset i will check with latest release
but since it has dependency over RN version, i need to think

Hi there @Jasbir23,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue with the latest version (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.


Automatic update of packages in the Docker image

In the Dockerfile, both APK and NPM packages are pinned to specific versions as per best practice. We need to devise a way to keep these packages up to date.
https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/Dockerfile#L9
For NPM, perhaps we can use package.json and package-lock.json to move the packages out of the Dockerfile and then use Renovate to keep package-lock.json up to date.
https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/Dockerfile#L3
For APK packages, a possible solution is described in https://github.com/renovatebot/renovate/issues/5422#issuecomment-645947041.

I've started digging into this and think I've hit a couple of snags. If we start using package.json and package-lock-json to install packages during docker build, we can't install packages globally. That makes the following line fail for obvious reasons:
https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/entrypoint.sh#L10
I can replace remark with npx remark-cli, but npx remark-lint doesn't work and I can't figure out how to execute remark-lint when it's installed locally. Ideas?
The other snag that may be a problem is that the following lines may conflict with the package.json file from the user?
https://github.com/reviewdog/action-remark-lint/blob/e16cd952fa1e8d24f95e3aee266fbd55e1470b0a/entrypoint.sh#L13-L16
Thoughts?

Actually, running npm remark-lint --version locally only returns the version number of npm and not that of remark-lint. It seems like passing --version to npm will ignore everything in between and just return the version of npm. Example:
$ npm non-existent-package-being-ignored --version
7.20.3

@asbjornu Good point, I also overlooked that. Some solutions can be found here (https://stackoverflow.com/questions/14657170/installing-global-npm-dependencies-via-package-json). I liked the PATH solution the most, but I could not get it to work on my local environment (i.e., I didn't spend enough time trying to get it to work).
If we however are planning to use renovate, I think it already provides us with the tools to upgrade npm packages inside docker files without using a  package.json file (see https://github.com/renovatebot/renovate/issues/3717#issuecomment-792652444).

Thanks again for working on this! If implemented, I think it is a good feature to also use in the other actions. Let me know if you run into any problems. I haven't worked with these more advanced features of renovate features, but I’m happy to read up.


Feature request: support "http(s) request" from raw request file

From https://httpie.io/docs#offline-mode,

Generating raw requests that can be sent with any other client:
▶ RUN# 1. save a raw request to a file:
$ http --offline POST httpbin.org/post hello=world > request.http
▶ RUN# 2. send it over the wire with, for example, the fantastic netcat tool:
$ nc httpbin.org 80 < request.http

Expected
one can run http request.http or https request.https to reproduce some results.

so sorry, I don't know why there have two duplicate issues :cry: :sob:

so sorry, I don't know why there have two duplicate issues :cry: :sob:

No problem :)

No problem :)


Fix const param defaults being yeeted out of code

Fixes #4816

closed/reopened as the GitHub UI was being buggy about the workflow runs

CI failures are unrelated (wrong toolchain, old issue)

awesome!! thanks for reviewing :) :tada:


[Scorecard Viewer] Feature: show grayed out the checks whose results aren't available

Motivation
Currently if a project doesn't use the Scorecard action, the Scorecard Viewer will only display the checks that are evaluated at the cron job(which excludes some important checks like Dependency-Update-Tool or Contributors), but this is not transparent for the user.
In fact, the lack of those checks will end up with an overall score that is different from the one got by the Scorecard API or got when you install Scorecard actions. That can be very frustrating as some maintainers like to have a preview of their score before installing Scorecard.
If we make clear that using the Scorecard Action would enable the other inspections, it could also motivate the adoption of the tool.
Purposed Solution
I've thought of these two actions:

The viewer displays all Scorecard checks, but greys out the checks that could not be evaluated.
A note is displayed above the viewer, explaining the situation. Such as "Some of the checks could not be evaluated and are grayed out -- their exclusion might affect the overall Score of the project. To include them on the analysis, please install Scorecard Action on the analyzed repository, or run Scorecard through our Command Line Client"

Note:  there's no easy way to determine if the API result comes from the cron or from the action. So it may not be possible to try and push people towards the action.

Although having missing checks would be a pretty good indication it's from the cron. As we can't currently customize which checks the action runs.

Makes sense... Does the missing checks come as -1? We could just show all "-1"s as greyed out, and adapt the note to  indicate that some of the greyed out checks may be because of lack of permissions, and using the Action or running at the CLI might include other checks. If some -1 keep appearing at the CLI/action evaluation because of other reasons, at least the overall score would be coherent.


TextureSystem and ImageCache they are never shared

Hi Guys,
I noticed that, If you specify a textureSystem shared and an ImageCache shared too, when you request the same image from both; the image is allocated twice.
Is this a bug or imageCache and TextureSystem cannot be shared?
Many Thanks
Gianluca

I think this has been fixed recently. Closing.


Ubuntu 22.04 support amd64/aarch64

Upgrading aarch64 platform to ubuntu 22.04 led to the following unstable problem, which cannot start CNI (flannel/weave) deployment as expected.
root@tomoyafujita-HP-Compaq-Elite-8300-SFF:/home/tomoyafujita/DVT/github.com/fujitatomoya/ros_k8s/yaml# kubectl logs -n kube-flannel kube-flannel-ds-8zr2k
Defaulted container "kube-flannel" out of: kube-flannel, install-cni-plugin (init), install-cni (init)
I0414 06:34:54.014798       1 main.go:211] CLI flags config: {etcdEndpoints:http://<IP_ADDRESS>:4001,http://<IP_ADDRESS>:2379 etcdPrefix:/coreos.com/network etcdKeyfile: etcdCertfile: etcdCAFile: etcdUsername: etcdPassword: version:false kubeSubnetMgr:true kubeApiUrl: kubeAnnotationPrefix:flannel.alpha.coreos.com kubeConfigFile: iface:[] ifaceRegex:[] ipMasq:true ifaceCanReach: subnetFile:/run/flannel/subnet.env publicIP: publicIPv6: subnetLeaseRenewMargin:60 healthzIP:<IP_ADDRESS> healthzPort:0 iptablesResyncSeconds:5 iptablesForwardRules:true netConfPath:/etc/kube-flannel/net-conf.json setNodeNetworkUnavailable:true useMultiClusterCidr:false}
W0414 06:34:54.015087       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0414 06:34:54.046028       1 kube.go:144] Waiting 10m0s for node controller to sync
I0414 06:34:54.046165       1 kube.go:485] Starting kube subnet manager
I0414 06:34:54.052649       1 kube.go:506] Creating the node lease for IPv4. This is the n.Spec.PodCIDRs: [<IP_ADDRESS>/24]
I0414 06:34:55.047254       1 kube.go:151] Node controller sync successful
I0414 06:34:55.047812       1 main.go:231] Created subnet manager: Kubernetes Subnet Manager - ubuntu
I0414 06:34:55.048088       1 main.go:234] Installing signal handlers
I0414 06:34:55.048991       1 main.go:542] Found network config - Backend type: vxlan
I0414 06:34:55.049164       1 match.go:206] Determining IP address of default interface
I0414 06:34:55.051469       1 match.go:259] Using interface with name eth0 and address <IP_ADDRESS>
I0414 06:34:55.051589       1 match.go:281] Defaulting external address to interface address (<IP_ADDRESS>)
I0414 06:34:55.051872       1 vxlan.go:140] VXLAN config: VNI=1 Port=0 GBP=false Learning=false DirectRouting=false
E0414 06:34:55.061475       1 main.go:334] Error registering network: operation not supported
I0414 06:34:55.061615       1 main.go:522] Stopping shutdownHandler...

could be related https://stackoverflow.com/questions/52098214/kube-flannel-in-crashloopbackoff-status

This is duplicated issue, see the following related issues.

https://github.com/k3s-io/k3s/issues/4188
https://github.com/k3s-io/k3s/issues/4234
https://github.com/flannel-io/flannel/issues/1747

the reason is vxlan kernel module will not be loaded by default Ubuntu 21.10 or later. this leads CNI operation to fail.
how to fix this issue is simple, just load the vxlan module to raspi4 kernel.
sudo apt install -y linux-modules-extra-raspi

I confirmed that this solves my problem here.

addressed by https://github.com/fujitatomoya/ros_k8s/commit/001cf1aec3bf36c83d3d5194ec4f0ade352c2231


Backend: LocalSimulator

Summary
Add support for braket.device.LocalSimulator.
Details and comments
Part of #1

@Morcu FYI moved your branch here.


I can't start godot. Got an error

Hello!
I can't start godot.
I got this error in console
http://joxi.ru/82QEzEaIwz60o2

There was an issue template, please fill it. We can't help without information on your system, GPU, Godot version, etc.

I think you are using a newer project (e. g. from master) on an old Godot build (Godot 3.1.1) because of the condition !version is true.

I think you are using a newer project (e. g. from master) on an old Godot build (Godot 3.1.1) because of the condition !version is true.

No this message originates in the shader compiler, it's not related to the engine version.
In any case, we can't solve this issue with so little detail, so closing.

As per https://community.khronos.org/t/opengl-does-not-allow-mediump-after-inout/67417
Your drivers are probably old, and support a non-standard version of OpenGL (on in which inout and precision modifiers are swapped around). Try updating them.


Carousel noPause="true" does not work

  does not seem to work. I want to keep the carousel going even if mouse is hovered over images.
My understanding is the default behavior is to stop the rotation when mouse over image, but that noPause="true" is supposed to keep it going no matter what.
Thanks
Mike

Please provide a plunkr showing the issue so we can have a look and help you.

See the referenced plunk.  I simply took the angular UI sample code and added the noPause="true" to the carousel tag.
To test this, mouse over the pictures of the kittens. The carousel will stop. My understanding is that the noPause="true" will keep it running, but it does not.
I

@MagicN thanks for the plunkr.
Here is a fixed plunkr: http://plnkr.co/edit/dfG946ib7govfqdosYNb?p=preview
You have to use no-pause in markup.
Here is the explanation from ngdoc:
Angular normalizes an element's tag and attribute name to determine which elements match which directives. We typically refer to directives by their case-sensitive camelCase normalized name (e.g. ngModel). However, since HTML is case-insensitive, we refer to directives in the DOM by lower-case forms, typically using dash-delimited attributes on DOM elements (e.g. ng-model).

closing the issue.
rgds


Adding ability to modify and delete metadata

This add the ability to modify modify metadata and completely delete objects in the object store.

Did you decide what you wanted to do about checking back before going through with the deletion (e.g. via a input or with a keyword)? I couldn't see if that was included within the code but please do point me to it if I missed it.

No but I think tha could be useful, I'll add an input prompt if a force keyword isn't used.

Having a look at the notebook at the moment. Getting this error from the second code cell
site = "TMB"
network = "LGHG"
height = "10m"
domain = "EUROPE"
model = "test_model"

Footprints.read_file(
    filepath=fp_path,
    site=site,
    model=model,
    network=network,
    height=height,
    domain=domain,
    period="monthly",
    high_spatial_res=True,
)

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Cell In [2], line 8
      4 domain = "EUROPE"
      5 model = "test_model"
      7 Footprints.read_file(
----> 8     filepath=fp_path,
      9     site=site,
     10     model=model,
     11     network=network,
     12     height=height,
     13     domain=domain,
     14     period="monthly",
     15     high_spatial_res=True,
     16 )

NameError: name 'fp_path' is not defined


[ServiceBus] add drainCredit timeout when suspending receiver

There are cases where the service doesn't respond to our drain-credit request, or the response comes back after a long and unexpected time. Since we are blocking on the receiver_drained event before resolving, application code is could be blocked indefinitely when suspending/closing.
This PR adds a timeout around credit draining, and if the timeout limit expires we close the receiver then returns.

/azp run js - service-bus - tests

API change check
API changes are not detected in this pull request.

Is https://github.com/Azure/azure-sdk-for-js/pull/25355 a duplicate of this PR?

/azp run js - service-bus - tests


refactor(tools): remove reference of table from utils

KAG-3138

full matrix tests: https://github.com/Kong/kong/actions/runs/9056770720/job/24879982725?pr=12487

Please merge this PR after merging https://github.com/Kong/kong/pull/13026

CI tests after removing most exported functions of kong\tools\table.lua
https://github.com/Kong/kong/pull/12487/files#diff-288ad830a31e2aee02e9bdb68009d2ee3daab8e4ff39247113e598a02a7640f6R20-R37
https://github.com/Kong/kong/actions/runs/9072658583/job/24928507132?pr=12487


Helidon Tracing configuration Paths

When adding Tracing and HealthChecks a Helidon 4.X appplication, traces are logged for health checks by default and cannot be disabled in configuration.
Environment Details

Helidon Version: 4.0.1
Helidon SE
JDK version: Zulu21.30+15-CA (build 21.0.1+12-LTS, mixed mode, sharing)
OS: macOS Sonoma 14.2
Docker version (if applicable): N/A

In io.helidon.webserver.observe.tracing.TracingObserverConfig.BuilderBase#pathConfigs the paths for /metrics/* and /health/* are by default disables - but in 4.X the path for the ObserveFeature was updated to /observe/* - so health becomes /observe/health/*.
This means that when deploying an Helidon 4.X application to Kubernetes we get a lot of traces from the health checks running.
Further, trying to disable this path by providing a path config in application.yaml does not work. The documentation suggests the configuration key tracing.paths - but this doesn't seem to do anything. The code seems to suggest the key path-configs
tracing:
  path-configs:
    - path: /observe/*
      traced-config: DISABLE

But that results in

Exception in thread "main" io.helidon.config.ConfigMappingException: Mapping of value stored under key 'tracing.path-configs.0' to type 'interface io.helidon.webserver.observe.tracing.PathTracingConfig' has failed: No mapper configured

Steps to reproduce
Create a Helidon 4.X application with both Tracing and HealthChecks enabled. Call /observe/health and see that a trace is logged. Try and disable in the config according to the documentation and also by looking at TracingObserverConfig (generated from blueprint).

Thanks for the thorough description and reproducer.
There are a number of bugs wrapped up in this.

In fact, we intend to automatically disable tracing for the Helidon built-in services by default. But the code incorrectly does not include the new /observe prefix when it sets up the paths for the metrics, health, and openapi services. So you should not even have to turn off tracing for those services yourself.
IMO, the config key should be as in the doc--paths--not path-configs as you correctly surmised from the code.
Regardless of the config key, the config mapping is not set up properly as the exception describes.


remove UUID5 conversion, as it generates collisions

After all it was not such a great idea to standardize this field, as UUID5 generates way too many collisions for this.
Let's stick to the original checksum

/cc @osherdp


0.2.5 Windows Installer fails to install

http://i.imgur.com/3N8XLKt.png

Make sure you're not accessing that folder with anything and run as admin.

I tried to run as admin, not accessing the folder too ( I have nothing to do in it, so not gonna open it ^^', even editing files I don't have the skills !  )
Tried to disable my antivirus ( Eset Smart Security ) not working too.

You could try the node installer package

Is it up to date ? its version 0.2.3 and the win installer is 0.2.5


Cannot build when scss enabled

Build failed when scss enabled
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

clone git clone --depth 1 https://github.com/mgechev/angular-seed.git
cd to angular-seed
run npm install
open add this line to tools\config project.config.ts and this line just after super()
this.ENABLE_SCSS = 1;
unzip attahed file to src/client.
css.zip
run npm start.
Expected behavior

The seed project should start successfully
Minimal reproduction of the problem with instructions

I got this error:

What is the motivation / use case for changing the behavior?

Project request scss
Please tell us about your environment:

Window 10, Visual Studio Code
node: 6.11.5
os: win32 x64
angular: 4.4.4
typescript: 2.5.3

Angular Seed Version: 8d78fa95ee1f322c0028c699b0db291efaa3eeb8

Node: node --version =6.11.5

I did further investigation and found the issue is related the folder scss/bootstrap no matter main.scss refers to anything in scss/bootstrap or not.
The problem will be gone if I delete bootstrap.
Any help will be much appreciated.

I worked out the problem was caused by the file scsss/bootstrap/_variables.scss. It has a line to import font by URL: @import url(http://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,400,300,600);
Everything is good after I remove this line.


Refactor UI to use GraphQL for creating user

With the closing of https://app.zenhub.com/workspace/o/dpopp07/bartop/issues/106, the UI needs to refactor createUser

Or nah


Bump the versions of the wasm-pack-plugin

There is no need to specify extraArgs anymore, otherwise this works perfectly fine.

Thanks!


Make it possible to add a branding to a section

[x] rogerthat-backend (API & CAPI)
[ ] oca-backend (dashboard)
[x] rogerthat-ios-client
[ ] rogerthat-android-client

https://github.com/our-city-app/mobicage-backend/commit/fe4621572d17cbf9d7bf0bebba5a969bb781ba7b
https://github.com/our-city-app/mobicage-ios-client/commit/4654f23c7ed91d0987b097a85028a4e2842921d3


kit.text_to_handwriting() can have notebook with lines Background(Good for Students) instead of white background

Hi,
Just wondering if we can add Lines in Background . so that it will help students for their hand written assignments.
attaching sample for your reference.

Ofcourse it is possible, but it's a time consuming task, I will try to add this feature when I get time. :-D


Audubon Core Maintenance Group call 20:00 UTC, Wednesday, January 13, 2021

The Audubon Core Maintenance Group will have an online meeting at 20:00 UTC Wednesday, 2021-01-13. That is the only magical time that does not involve the middle of the night for potential participants from North America, Europe, Hawaii, and Australia and corresponds to 3:00 PM Wednesday Eastern (US) Standard Time (New York), 2:00 PM Wednesday Central (US) Standard Time (Chicago), 10:00 AM Hawaii Standard Time (Honolulu), 8:00 PM Wednesday, GMT (London), 9:00 PM Wednesday, Central European Time (Stockholm), and 7:00 AM Thursday Australian Eastern Daylight Time (Canberra).
At this meeting we will make plans for what we want to achieve in 2021. In particular, we will scope out possible enhancements related to video and talk about next steps for completing a best-practices guide for sound. The topic of annotations will probably be common to both of these media types, so we can talk about that as well.
Meeting details:
Join Zoom Meeting
https://vanderbilt.zoom.us/j/98948334153
Meeting ID: 989 4833 4153
Find your local number: https://vanderbilt.zoom.us/u/adeKXTTVsi
Add to Google Calendar
Download Outlook .ics calendar invitation

Don't forget that the Audubon Core Maintenance Group call is coming up on Jan 13 at 20:00 UTC. See this issue: https://github.com/tdwg/ac/issues/188 for local times and the Zoom link.

Don't forget that the Audubon Core Maintenance Group call is coming up on Jan 13 at 20:00 UTC. See this issue: https://github.com/tdwg/ac/issues/188 for local times and the Zoom link.

2021-01-13 Audubon Core Maintenance Group meeting notes have been posted at https://github.com/tdwg/ac/blob/master/historical/2021-01-13-meeting-notes.pdf

2021-01-13 Audubon Core Maintenance Group meeting notes have been posted at https://github.com/tdwg/ac/blob/master/historical/2021-01-13-meeting-notes.pdf


Color Inconsistency (Grab has bugfix)

Summary
Ensure same color rendering results between style, layer and annotation.
Grab has bugfix
The original author of this bug report is Grab. They have a bug fix and would like to upstream it to MapLibre GL Native.

Following, it could be what I have here: https://twitter.com/cbed32/status/1596533172350484480?s=20&t=globat9csUMQbP21x7fI6Q

Sorry for the false report, This issue happened when I tried to make the color consistent with the style and programmable. In Mapbox when you create a color with an alpha value(not 1), then the style color is the normal color, for example, the fill color :
        {
            "id": "a-fill-layer",
            "type": "fill",
            ....
            "paint": {"fill-color": "rgba(1.0,0.0,0.0,0.5)"}
        },

But when you create the layer manually the color must be the pre-multiplied color: Color.premultiply = (Color.rgb * color.a, color.a);
Your code in Objective C should be like this(@cbeddow your issue may be related to this):
    MGLFillStyleLayer *fillLayer = [[MGLFillStyleLayer alloc] initWithIdentifier:@"test" source:source];
    fillLayer.fillColor = [NSExpression expressionForConstantValue:[UIColor colorWithRed:1.0*0.4 green:0.0*0.5 blue:0.0*0.5 alpha:0.5];

I deprecated this using method in GrabMap, the fill color needn't use pre-multiply color, and this issue happened when I solve this I miss the uniform color value interpolating. So if Maplibre still wants to use pre-multiply color in the core, shouldn't care about this, it's no issue with premultiply color.

@alanchenboy I'm closing this as it was a false report


Can’t find “iOS update”

I can’t find the “iOS update” in my iPhone Storage

be more descriptive... There were instructions on how to make a post, follow them next time. What iOS/unc0ver version are you on, could it be a tweak removing it?


Create Tables page

[x] Create page
[x] Add description of what is being covered
[x] Add description of checks required on this content, compiled from current protocol documents
[x] Add examples covering correct and incorrect scenarios, as required to support checks
[x] Populate with schematron messages
[x] Provide explanations for how to fix schematron errors and warnings
[x] Review house style document to ensure all requirements are covered by GitBook and schematron
[ ] Review schematron messages related to this topic to ensure they are user friendly
[ ] Becky approved page
[ ] Melissa approved page
[ ] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Share page with Exeter and invite feedback
[ ] Revise with Exeter's suggestions

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?
[ ] Assign Fred to update the Schematron

I think that it might make sense to fold all the table header stuff into one section, even when it's cells in the body. The controls in Kriya don't, to my knowledge, distinguish between headers at the top and headers in the body, so it probably doesn't make sense to split them out, even though there is an XML distinction.
It might make sense to rephrase the descriptions of table footnotes to start with blank/uncited footnotes, then say something like 'these can be linked to the text in the table using . . .'  Just for clarity, and because I'm not sure which one we get more of.
Does it make sense to include a screenshot of the allowed colours in tables?
Are non-breaking spaces still a problem for the checks on labels?
Probably worth stating outright which of the 'table-report' tests fire at pre and post author stages.
distinct-label-conformance - would suggest putting (e.g. Table 1 and Table 1) just to ram home the point.
text-v-object-cite-test - "text should be added as a citation instead." -> suggest "text should be changed to a linked citation."
xref-column-test - for clarity, I'd suggest including the heading names for the 1st, 2nd and 4th columns.
doi-link-test - "This will fire if a table cell in a Key resources table contains a doi." Shouldn't that specify an unlinked DOI?
table-wrap-test-3 - does this only fire if the table isn't intended to be inline? If not, might be worth including multiple examples.
[I've not finished, but now Kriya is sort of working again!]

Is there a reason the source data/code examples in Associated source data/code files is formatted with the code formatting? Is it because it refers to the XML?
'It's very unusual, but possible, that a header might need to contain normal, rather than header table cell' - I think an example might be useful here
Tables with multiple headers - I think the second screenshot can be deleted because I was a little confused - the 'Data collection statistics' as a header still makes some sense on page 2, but the problem is clearer on page 3 so it should be ok to just include that example.
'In some articles, Key resources tables will be captured in a supplementary file instead.' - I can't remember if we have now moved to including these as appendices instead. Not sure whether we decided on a date to start doing this though!
Should the checklist be the first thing at the top?
Is the action for table-fn-label-test-1 correct? The first sentence seems to relate to app-table-label-test-2.

Out of curiosity - why is the ID value not baked into kr-table-wrap-test-1?

This query -
"This Key resource table is not in the correct format. Please provide a revised table in the required format using this guide - https://cdn.elifesciences.org/author-guide/key_resources_table.xlsx. The table can be provided as an editable file (such as word or excel) in response to the proofing email. We regret that this was not brought to your attention earlier and apologise for the inconvenience."
I would suggest editing it to:
"This Key resource table is not in the correct format. Please provide a revised table as a Word or Excel file in response to the proofing email. A template for the table can be found at https://cdn.elifesciences.org/author-guide/key_resources_table.xlsx. We regret that this was not brought to your attention earlier and apologise for the inconvenience.

table-test-2 - just going off the warning, I don't think it's clear how a user is supposed to identify a missing header as a mistake. Maybe needs to refer them back to the original article file?

Thinking about headers in the body and tr-test-3, I'm not sure it's fair to call it unusual to have headers in tables. That's a fairly normal way to structure complex or detailed tables, and we allow it.

Thanks Both!
Adding the link to the page here for ease for next time:
https://app.gitbook.com/@elifesciences/s/productionhowto/article-details/content/tables

I think that it might make sense to fold all the table header stuff into one section, even when it's cells in the body. The controls in Kriya don't, to my knowledge, distinguish between headers at the top and headers in the body, so it probably doesn't make sense to split them out, even though there is an XML distinction.

I didn't do this because I didn't want to make it too Kriya specific - but I also didn't know how to make it not XML specific when trying to not make it too Kriya specific. I'm happy to change if the distinction isn't helpful for anyone else (it is for me - but that's just me) - perhaps we can discuss on Thursday.

Are non-breaking spaces still a problem for the checks on labels?

Yes they will be. I'll add this to the actions so it's explicit.
I've addressed your other points in this comment.

rrid-test, org-test, code-test and related - these aren't specific to the context of tables, right? Shouldn't these be on another page about general styling/content tests?

Likewise, I think citation tests should be on a separate page from table content ala references.

table-xref-test-4 - should state what to do if there is no Table 1—source data 1!

@naushinthomson

Is there a reason the source data/code examples in Associated source data/code files is formatted with the code formatting? Is it because it refers to the XML?

Changed to bold formatting.

'It's very unusual, but possible, that a header might need to contain normal, rather than header table cell' - I think an example might be useful here

I can't find an appropriate example in the archive because there isn't one. Maybe I'll just change the text to say that it's never appropriate...

Tables with multiple headers - I think the second screenshot can be deleted because I was a little confused - the 'Data collection statistics' as a header still makes some sense on page 2, but the problem is clearer on page 3 so it should be ok to just include that example.

I'll find a better (different) example of what I mean. In this case it just happens to be that that is correct because the same heading is repeated.

'In some articles, Key resources tables will be captured in a supplementary file instead.' - I can't remember if we have now moved to including these as appendices instead. Not sure whether we decided on a date to start doing this though!

As I recall, we were going to implement this once we've fixed the display of appendices in the PDF.

Should the checklist be the first thing at the top?

I can put it there (happy to if you think it's better), but will it make sense without the context of the stuff above it?

Is the action for table-fn-label-test-1 correct? The first sentence seems to relate to app-table-label-test-2.

Thanks I've corrected it.

@JGilbert-eLife

Thinking about headers in the body and tr-test-3, I'm not sure it's fair to call it unusual to have headers in tables. That's a fairly normal way to structure complex or detailed tables, and we allow it.

tr-test-3 is about normal cells in the header. Is that the right warning you mean? I've changed the wording in th-row-test:

This will fire if a table row contains a mixture of table header cells and normal table cells. This is relatively unusual, although there are a some cases where this would be appropriate.

but this is unusual since it's only one cell. I can't find any other places where I've referred to headers in the body as being unusual.

rrid-test, org-test, code-test and related tests to do with content mistakes - these aren't specific to the context of tables, right? Shouldn't these be on another page about general styling/content tests? We don't want to have to repeat them, since then we'd have the ID/link going to two places.

Good point. I've moved them to a separate page, General Content for now. @naushinthomson, could you have a think about how you want this captured/what the name for this should be? Thanks!

Likewise, I think citation tests should be on a separate page from table content ala references.

These are specific to table citations (rather than general citations). Perhaps we should discuss on Thursday.

table-xref-test-4 - should state what to do if there is no Table 1—source data 1!

Thanks for catching that. I've updated the action.

'It's very unusual, but possible, that a header might need to contain normal, rather than header table cell' - I think an example might be useful here

@JGilbert-eLife, @naushinthomson, what are your thoughts on me saying that this is not allowed, and making tr-test-3 an error instead of warning?
I can't find any instances where this has been appropriately done in the archive.

table-fn-label-test-1 should the action be ' If this warning fires, it is because a footnote has an indicator and it isn't one of the allowed symbols.'?
colour-check-table - Is there a scenario where we might see this message as well as the pre/final colour-check-table-2 in the same article, in which case how do we resolve the difference between the two Kriya queries - one which asks the authors to remove formatting and the other which asks the authors to pick a colour?
kr-table-header-3 - Should we also add to the action (just to be absolutely clear) that the thing to do is typeset the table according to the template?
th-row-test - For the second case, is it worth clarifying that the decision to make 'Map resolution' span the entire row is just by looking at the rest of the table? Or did you compare with the original document in which case would it be worth adding a screenshot of that?
I think that's all from me in terms of comments!

'It's very unusual, but possible, that a header might need to contain normal, rather than header table cell' - I think an example might be useful here

@JGilbert-eLife, @naushinthomson, what are your thoughts on me saying that this is not allowed, and making tr-test-3 an error instead of warning?
I can't find any instances where this has been appropriately done in the archive.

Fine by me!

Sorry if I repeat any of the above.
"In Decision letters and Author responses the title is optional'
For completeness, can we add that if a legend is present then a title is required?

"Note that an object labelled as one table (with one label and optional title/caption), can actually be made up of multiple tables. This is avoided, where possible in eLife content (see also XML structure)."
Why? Why would an author do this and we is it avoided?

Authors requesting tables as figure supplements? I haven't finished reading but just adding this in case this is not covered

"All footnotes that have indicators should follow this sequence , †, ‡, §, ¶, , ††, ‡‡, §§, ¶¶, , †††, ‡‡‡, §§§, ¶¶¶, **, ††††, ‡‡‡‡, §§§§, ¶¶¶¶, etc. in accordance with house style"
I don't entirely understand what you mean by 'this sequence' and the symbols (maybe sleepy brain). Are these the only symbols we use? Could we include a screenshot of good usage?

Those outside of Decision letters and Author responses display in both the HTML and in the PDF.

I think this would clearer if it said

Tables display in both the HTML and in the PDF. Decision letters and Author responses are not added to the PDF so their tables only appear in the HTML version of the article.

Or something like that. It stumped me when I read it :-)

Is Associated source data/code files a common term? If not, would Supporting source data/code files be more suitable?

Allowed table colours - why do we only allow these ones?

Table body section:

(by default roman)

Please add comma after default or change to (by default this is roman)

Table footnotes, there is a house style order and some more info missing from the GitBook:
Order: Designated footnotes, p value footnotes (*p<0.05; **p<0.01; ***p<0.001), undesignated footnotes and abbreviations last. All abbreviations used in tables must be defined in footnotes (unless on list of not required definition).
https://docs.google.com/spreadsheets/d/1tC0mva-zPZcnJXk3PMwYOZsq1ZXmrE9NjTT0DT28f9c/edit#gid=823351812

Associated source data/code files

Is it worth showing s display example of the HTML version too? Not just PDF

Would it be good to mention the troubles we sometimes have when adding citations in tables or trying to add text after a URL?

Tables can be placed in the body of an article, in appendices, in Decision Letters and in Author responses.

Worth mentioning boxes here for the non pure XML understanders ;-)

Can more be said about inline tables, ie examples, were allowed or not allowed.

In the schematron warnings "Error: XXXXXX - Table label does not conform to the usual format." it would be useful to explicitly mention the full stop is required inside the label
eg "Please ensure that there are no typos, missing or extra spaces, that the capitalisation is correct, and that the character between 'Appendix X' and 'table X' is an em dash." mentions everything else except the full stop

table-fn-label-test-1
Warning: Footnote starts with label which is not in line with house style - XXXXXX. Footnote symbols should be in the order: *, †, ‡, §, ¶, **, ††, ‡‡, §§, ¶¶, etc.
Action: Footnote indicators should be in the following sequence , †, ‡, §, ¶, , ††, ‡‡, §§, ¶¶, , †††, ‡‡‡, §§§, ¶¶¶, **, ††††, ‡‡‡‡, §§§§, ¶¶¶¶, etc. If this warning fires, it is because a footnote has an indicator and it isn't one of the allowed symbols. The indicators should be changed in line with the sequence above.

Does this allow for the following scenario, which is allowed:
*p<0.05; **p<0.01; ***p<0.001
I assume it does as it only looks at the first symbol, but wanted to check

Action: This will fire when a Table label occurs twice in the same article for example there is a Table 1 and a Table 1. Table labels must be distinct. If this fires, action should be taken to ensure that this label is not used more than once.

This would read better as:

Action: This will fire when a Table label occurs twice in the same article for example are two 'Table 1.'s. Table labels must be distinct. If this fires, action should be taken to ensure that this label is not used more than once.

Action: This will fire at pre-author stages when a table is placed out of sequence in the body of an article (such as Table 1 being placed after Table 2). If this warning fires, and there is no citation for that table, please add the following author query:

Is this tagged table citations? Does it allow for untagged citations? I don't see them mentioned anywhere as a solution to this problem, which would be useful?

If the table citation is obviously a reference to a table from another article or piece of work (e.g. Table 1 from Smith et al., 2020), then this can be ignored.

Please change to

If the table citation is obviously a reference to a table from another article or piece of work (e.g. Table 1 from Smith et al., 2020), then this should be ignored.

'should', or 'must' would be good!

Action: This will fire at a pre-author stage if a table cell in a table has a style attribute with an unallowed value. Usually this will be because the colour formatting is not a supported colour. If it is one of the supported colours and this message fires this is a problem - it means that the content has not been typeset correctly.

and following message too.
Is it true that it's not been typeset correctly, or should this state that it's not been tagged correctly?

I don't understand table-wrap-test-3
and table-wrap-test-4
Sorry! I don't think they are clear

pre-table-wrap-cite-1
Warning: There is no citation to XXXXXX. Ensure to query the author asking for a citation.
Action: This will fire at pre-author stages for tables (which are not Key resources tables) with labels, in articles which are not corrections or retractions. If this fires (and there are no issues with labelling or the table id), then the following author query should be added:
Conditions for corrections or retractions are here but not mentioned anywhere else above. Should this be added to the main explanation text that these article types have different conditions?

feat-table-wrap-cite-1
Warning: There is no citation to XXXXXX. Is this correct?
Action: This will fire at all stages for tables (which are not Key resources tables) with labels, in feature content (insights or feature articles).
If this fires at a pre-author stage (and there are no issues with labelling or the table id), then the following author query should be added:

New conditions that are different for feature content - not mentioned above in main explanation part

Action: This will at all stages fire if a table has all the KR table headings but does not have an  id keyresource. If this fires, ensure that the Table is captured as a Key resources table (with the correct id, label and no title or caption).

Style issue - for other ones you've done this:

Action: This will at all stages fire if a table has all the Key resources table headings but does not have an id keyresource. If this fires, ensure that the Table is captured as a KR table (with the correct id, label and no title or caption).

Action: This will fire at all stages if a table has a title containing the text 'Key resource'. If it is a key resources table, then this should be captured as a Key resources table (with the correct id, label and no title or caption). If it is not (i.e. just a normal table, without the standard KR table headings, which happens to have the text 'Key resource' in it's title), then this message can be ignored.

Style issue, please change to:

Action: This will fire at all stages if a table has a title containing the text 'Key resource'. If it is a Key resources table, then this should be captured as a KR table (with the correct id, label and no title or caption). If it is not (i.e. just a normal table, without the standard KR table headings, which happens to have the text 'Key resource' in it's title), then this message can be ignored.

Please s&f Key resources table and ensure capitalisation on consistent thorughout doc

Action: This will fire at all stages if a KR table does not have the correct number of headings. All KR tables should have 5 headings/columns. If the table is typeset correctly (please check this carefully), as the author provided it, then the following author query should be added:
This Key resource table is not in the correct format. Please provide a revised table as a Word or Excel file in response to the proofing email. A template for the table can be found at https://cdn.elifesciences.org/author-guide/key_resources_table.xlsx. We regret that this was not brought to your attention earlier and apologise for the inconvenience.

Change to:

Action: This will fire at all stages if a Key resources table does not have the correct number of headings. All KR tables should have 5 headings/columns. If the table is typeset correctly (please check this carefully), as the author provided it, then the following author query should be added:
This Key resource table is not in the correct format. Please provide a revised table as a Word or Excel file in response to the proofing email. A template for the table can be found at https://cdn.elifesciences.org/author-guide/key_resources_table.xlsx. We regret that this was not brought to your attention earlier and apologise for the inconvenience.

There is no mention of column alignment and normal expectations. Should there be? This is something that comes up.
is there a choice? decimal, left etc

Action: This will fire if a  element does not have a child  element. If this fires, it has been typeset incorrectly and steps should be taken to correct it.

Does this mean there is a table wrapper but no table?
Perhaps the message could say that?ie there is no table present, but there is table wrapping XML

Action: This will fire if a  element more than one a child  element. If the table has two or more sections in it with differing numbers of columns, but it has the same label (and title), then this warning can be ignored. If it does not, the table should be collated so that there is only one table element.

Presumably only Exeter can do that action? Is it worth saying that...

Action: This will fire if a  element does not have a child  element. This means that something has gone wrong with the typesetting and the table will need to be corrected.

Does this mean there is a table tag in the XML but no table content?
Perhaps the message could say that?ie there is no table present, but there is table wrapping XML

Could the XML structure section be moved up to the main explanation?
When reading this page sequentially that would be super useful to hit that sooner :-)

@bcollins14

Allowed table colours - why do we only allow these ones?

These are the only ones supported by Continuum, and I imagine they have been picked with accessibility in mind. Do we need to add this info?

@Melissa37

Associated source data/code files

Is it worth showing s display example of the HTML version too? Not just PDF

I already included an embedded link in "Here is an example from published content:". Is that OK or do you still want a screenshot?

table-fn-label-test-1
Warning: Footnote starts with label which is not in line with house style - XXXXXX. Footnote symbols should be in the order: *, †, ‡, §, ¶, **, ††, ‡‡, §§, ¶¶, etc.
Action: Footnote indicators should be in the following sequence , †, ‡, §, ¶, , ††, ‡‡, §§, ¶¶, , †††, ‡‡‡, §§§, ¶¶¶, **, ††††, ‡‡‡‡, §§§§, ¶¶¶¶, etc. If this warning fires, it is because a footnote has an indicator and it isn't one of the allowed symbols. The indicators should be changed in line with the sequence above.

Does this allow for the following scenario, which is allowed:

*p<0.05; **p<0.01; ***p<0.001

I assume it does as it only looks at the first symbol, but wanted to check

All the test itself checks for is that, if a footnote starts with a superscript symbol, that it is one of those symbols. It doesn't actually check that the sequence itself is correct. I can add one to do that but it's complicated by the fact that we do not use label and instead just add superscripted text.
The upside is that it will not fire for the use case you provide.

@Melissa37

I don't understand table-wrap-test-3
and table-wrap-test-4

Sorry! I don't think they are clear

Is the revised wording any clearer?

Move Tables with multiple header after table header section.
Include info on accessibility - maybe update author queries.
Include info on how colours will not display downstream. Also add the query to the allowed colours section.
Move checklist to the top
Both colour checks firing - update action
kr-table-header-3 - add example to action
Add example of multiple table with authors original.
Add a screenshot of good footnote indicators
Would it be good to mention the troubles we sometimes have when adding citations in tables or trying to add text after a URL?
Mention box text per Melissa's comment
Add section of inline tables, add info on these.
Add section on citations out of sequence/those left unlinked.
Add section on Corrections/Retractions
Feature content
Add section on alignment.
table-test-1 - deal with action


ESP32-S3 Crash on transmitting TCP packet

Every time when I will try to transmit from KLINE via TCP (IP RAW layer), then LWIP appears to crash on ECU response of 1A9B.
 Exception was unhandled.

Core  1 register dump:
PC      : 0x40382165  PS      : 0x00060e33  A0      : 0x80382b0c  A1      : 0x3fce1ad0
A2      : 0x3fcf0014  A3      : 0x9704cd80  A4      : 0x00000280  A5      : 0x3fc9fea9
A6      : 0x000005a0  A7      : 0xfffffffc  A8      : 0x3fcf7334  A9      : 0x3fcf7348
A10     : 0x00000003  A11     : 0xfffffffc  A12     : 0x3fcf7350  A13     : 0x3fcf733c
A14     : 0x57355a48  A15     : 0xfffffffc  SAR     : 0x0000001c  EXCCAUSE: 0x0000001d
EXCVADDR: 0x9704cd80  LBEG    : 0x40056f5c  LEND    : 0x40056f72  LCOUNT  : 0x00000000

Backtrace:0x40382162:0x3fce1ad00x40382b09:0x3fce1af0 0x40375ce1:0x3fce1b10 0x40375d09:0x3fce1b30 0x40375d35:0x3fce1b50 0x4038343d:0x3fce1b70 0x42018bbc:0x3fce1b90 0x42018c3b:0x3fce1bb0 0x42018ca9:0x3fce1bd0 0x4201e535:0x3fce1bf0 0x4201eb06:0x3fce1c20 0x4202a43a:0x3fce1c90 0x4202b17c:0x3fce1cb0 0x42017fd5:0x3fce1cd0 0x42018078:0x3fce1cf0 0x4037fc35:0x3fce1d20

Then after I have increased memory of tcpwsraw_thread from 4096 to 8192 bytes, error has changed on
----

E (23908) Task_Tcp_Wireshark_Raw.c: Error occurred during sending: errno 5
W (23908) Task_Tcp_Wireshark_Raw.c: Socket closed

assert failed: lwip_netconn_do_delconn IDF/components/lwip/lwip/src/api/api_msg.c:1161 (netconn state error)

Backtrace:0x40375b8e:0x3fce1b500x4037c9f1:0x3fce1b70 0x4038342d:0x3fce1b90 0x4202ac13:0x3fce1cb0 0x42017fd5:0x3fce1cd0 0x42018078:0x3fce1cf0 0x4037fc35:0x3fce1d20

I am not sure what exactly is a cause. It might be related to length of a TCP packet. I will need to better pinpoint it and see if it is the issue on ISO15765 and VWTP2.0 and on older ESP32

pvPortMalloc(sizeof(length)) allocating only 4 bytes for a whole frame instead of allocating length amount of bytes


Target expression error

I'm trying to use an expression in DNS Measurement Target and i get an error: Invalid target format: https://={{ $json['domain'] }}

Hey we're looking into this

Please check now

Hi, after updating the plugin I got the same type of error:
{
  "errorMessage": "Invalid target format: https://={{ $json.domain }}",
  "errorDetails": {},
  "n8nDetails": {
    "n8nVersion": "1.68.0 (Self Hosted)",
    "binaryDataMode": "default",
    "stackTrace": [
      "Error: Invalid target format: https://={{ $json.domain }}",
      "    at parseMeasurementTarget (/home/node/.n8n/nodes/node_modules/@globalping/n8n-nodes-globalping/nodes/Globalping/GenericFunctions.ts:68:3)",
      "    at Object.execute (/home/node/.n8n/nodes/node_modules/@globalping/n8n-nodes-globalping/nodes/Globalping/v1/GlobalpingV1.node.ts:145:45)",
      "    at Workflow.runNode (/usr/local/lib/node_modules/n8n/node_modules/n8n-workflow/dist/Workflow.js:722:42)",
      "    at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:704:66",
      "    at /usr/local/lib/node_modules/n8n/node_modules/n8n-core/dist/WorkflowExecute.js:1134:20"
    ]
  }
}

testing Workflow: GlobalpingTest.json

Hi @sqlmiles, I'll recommend you to completely remove the node at settings/community-nodes, then install it again, it will be 1.0.4

then restart the n8n instance.
The issue somehow related to n8n unable to update community nodes issue. https://github.com/n8n-io/n8n/issues/11840
it will be solved in the 1.69 n8n version.

Before posting my previous comment I did an uninstall-install update but did not restart the n8n instance. After restarting everything works fine.
Thanks for that and for the great software you created.


The Terraform module given for ip reservation is not idempotent

The example Terraform script provided is using a bash script that invokes reservation endpoint and it allocates new IP every time the Terraform is run.
We constantly run the Terraform scripts and would like this to be idempotent. Is there a get existing IP reservation by tag so we can first query its existence and create a new one if it doesn't.

Hi @jeevanions, there is another Azure IPAM customer whom created a proper Terraform provider. We worked closely with them on the creation and maintenance of this provider and you can find more details and usage examples here:
https://registry.terraform.io/providers/XtratusCloud/azureipam/latest/docs
We'll keep the very basic examples we have in the examples folder for now as some customers might want to use the script components of that for other processes, but you'll definitely want to use the official Azure IPAM Terraform provider by XtratusCloud for true idempotency.
Hope you enjoy!

Perfect. Thank you


running on raspberry pi os lite

I'm trying to have a raspberry pi act as a server on a local network with raspberry pi os lite 32bit,
I go through the steps in the documentation but when I get to the
inv migrate
step it tells me
ImportError: libopenjp2.so.7: cannot open shared object file: No such file or directory
can anyone help???

Have you searched on Google?
A simple search leads to this solution:
https://stackoverflow.com/questions/48012582/pillow-libopenjp2-so-7-cannot-open-shared-object-file-no-such-file-or-directo

Your right Francois
I ran sudo apt-get install libopenjp2-7
that wasn't enough so I also ran
sudo apt-get install libtiff5
then it told me I needed Cairo so I went to
https://www.cairographics.org/download/
where I found sudo apt-get install libcairo2-dev
then it told me I needed libpango1.0-0
I googled it and found https://ubuntu.pkgs.org/18.04/ubuntu-universe-amd64/libpango1.0-0_1.40.14-1_amd64.deb.html
and I ran sudo apt-get install libpango1.0-0
then I did inv migrate and I'm up and running on raspberry pi lite.
thanks for you help I'm really new to coding and command line.
I really appreciate your patience.

Glad to know that you are up and running!


highlight bond/torsion

Hi, quick question: how can we do above? thanks.

you mean for forcefields?
you could use a ball+stick representation (selecting the atoms involved the bond/torsion atoms) that is transparent and slightly bigger than the 'non highlight' ball+stick representation

thanks.
cc @proteneer


Lambda Layer for Multiscale Training

Does Lambda Layer support multiscale training, it seems like that you have to specify n?

@Lufan111 if you mean whether you can train a lambda layer to be agnostic to the image size, you will want to use the version with the localized context (keyword r)

@Lufan111 if you mean whether you can train a lambda layer to be agnostic to the image size, you will want to use the version with the localized context (keyword r)

Thanks for reply. Well, I mean if I can use the global context version for different image sizes while multiscale training, since the H*W is actually different per batch. Does the current code version support this?

@Lufan111 it won't work for global context if the images differ in size across batches, only for local context

@Lufan111 it won't work for global context if the images differ in size across batches, only for local context

Okay~ I see... As for Appendix D "Experimental Details" COCO object detection part, "apply multi-scale jitter of [0.1, 2.0] during training", so you just use different arg 'r' for local context right? not for multi-scale global images?

@Lufan111 yup, so if you look at the beginning of Appendix D, the author(s) detail the architecture they settled on. they use  a local context of 23x23 unless if the intra-depth dimension is greater than 1, in which case they lower that to 7x7


FR: Docker image for linux/arm/v6 architecture

Is your feature request related to a problem? Please describe.
I tried to install nginx-proxy-manager on a Raspberry Pi Zero W but cannot download a fitting image. The error message is: no matching manifest for linux/arm/v6 in the manifest list entries
Describe the solution you'd like
As suggested by the docs I would like to raise a feature request to provide a fitting image for the Pi Zero architecture.
Describe alternatives you've considered
Buying a newer Pi probably solves the problem, but I have no other use case for the Pi Zero and would like to use it.
Additional context
Nothing relevant can be provided here.

👍


Nodoc: Config File

Issue Label:

[ ] Bug
[ ] New feature
[x] Enhancement

Description:
I'm new to this cryptowatch script, and I have no clue on how to actually create that portfolio file, what format it should be in. IMO a little bit of documentation would add a ton of traction to this script.
I tried to edit the configuration, but it's little to no use: having to supply one address per crypto is pointless as most people will have several receive addresses, and also I don't see how to add cryptos (Stratis, Peercoin, Dogecoin, IOTA, ADA all seem to be good candidates). A small doc about how to add an API endpoint allowing to monitor this or that would be great.

I will definitely put a little documentation but for now if you run cryptowatch --config it will actually create a template config file for you.
Mine now looks like this

You can put more than one address for each type of crypto by separating them with a comma and  a space.
Right now those coins are not supported, but as I am adding new coins now to support more, I would definitely add the later three of the five but I have not heard of the first two, I will look into them :+1:

Let me know if ef728c41823a4feb89c5f8d6ec4ddcfe14f08748 is enough for you. Otherwise I will look to add more!


Add delete page types mutations

Add PageTypeDelete mutation
Add PageTypeBulkDelete mutation

⚠  Contains changes from https://github.com/mirumee/saleor/pull/6307
Linked task: SALEOR-1174

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1174 Add mutations to delete page types


email-info

Can one of the admins verify this patch?

ok to test

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please


Bump dependency bounds.

Support GHC-9.8 - cabal test and stack test succeed (not tested against older GHC versions). Maybe time to create a new revison on hackage? Thanks for providing this library!
(cc @F-Joachim)

Would also resolve #7 and #8.

And also a new release/revsion on hackage would semi-automatically re-enable the package in stackage nightly.

I've uploaded 0.3.4 which includes this.


fix: correctly update styles

fix #12901
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the main branch for v2.x (or to a previous version branch)
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803 the new styles are always set, 这样改有一个问题，比如el-dialog通过指令去改变dom的宽度，然后包含el-dialog组件的响应式变量更改，就会重新渲染，el-dialog 的宽度被重置了

@yyx990803 the new styles are always set, 这样改有一个问题，比如el-dialog通过指令去改变dom的宽度，然后包含el-dialog组件的响应式变量更改，就会重新渲染，el-dialog 的宽度被重置了

我们升级2.7.16也出现了这样的问题，破坏性改动


Edit doctors

Resolves #47

Codecov Report

Merging #73 (31aa012) into master (6d7a8f5) will increase coverage by 1.81%.
The diff coverage is 92.59%.

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     71.66%   73.47%   +1.81%
- Complexity      535      563      +28
============================================
  Files            95       97       +2
  Lines          1648     1753     +105
  Branches        171      190      +19
============================================
+ Hits           1181     1288     +107
+ Misses          417      410       -7
- Partials         50       55       +5

Impacted Files
Coverage Δ

...in/java/seedu/plannermd/commons/core/Messages.java
0.00% <ø> (ø)

...logic/commands/editcommand/EditPatientCommand.java
95.06% <ø> (ø)

...annermd/logic/parser/EditPatientCommandParser.java
93.33% <0.00%> (ø)

.../seedu/plannermd/logic/parser/PlannerMdParser.java
74.07% <50.00%> (+6.07%)
:arrow_up:

...lannermd/logic/parser/EditDoctorCommandParser.java
92.85% <92.85%> (ø)

.../logic/commands/editcommand/EditDoctorCommand.java
96.00% <96.00%> (ø)

.../main/java/seedu/plannermd/model/ModelManager.java
95.83% <0.00%> (+4.16%)
:arrow_up:

src/main/java/seedu/plannermd/model/PlannerMd.java
87.50% <0.00%> (+7.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7a8f5...31aa012. Read the comment docs.

LGTM, testing was quite comprehensive as well. One thing to note is that I find EditDoctorDescriptor and EditPatientDescriptor to be quite similar since they have a lot of common functionality related to Person. Perhaps, we can consider making an abstract EditPersonDescriptor class and have the doctor and patient descriptor extend from it.

Thanks, I learnt from your test files. Jia Yi and I have considered to make a superclass too but we realised that we still have to rewrite the codes for withName, withPhone etc since the return type has to be the specific type of the two different classes. We could look for possible solutions later.


Fix wheel build

Added build dependencies into pyproject.toml
Added runtime dependencies to install_requires
Moved lap version info into lap/version.py so it will be available in setup.py without importing lap
Removed import lap form setup.py
Removed __LAP_SETUP__ logic because it is not needed anymore

Now you can build lap wheel normal way (not only in editable mode) and deploy it to PyPI.

@gatagat , looks like this PR resolves both build and install dependencies on numpy. It also elimiminates the need to import lap from setup.py, which produced wheel build error.

For some reason APPVEYOR build fails on Python 3.8 configuration with scipy compilation errors.

Hi @vlad-nn, lap (0.5.12) now builds and uploads wheels to pypi from github actions.


Mouse Without Borders is not working

Microsoft PowerToys version
0.74.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Mouse Without Borders
Steps to reproduce
It's connecting the other device but mouse is going to other computer.

✔ Expected Behavior
mouse is should go to other computer
❌ Actual Behavior
mouse is staying the same computer
Other Software
No response

I'm also facing the same issue

In my installation I can switch the computers with the default CTRL-WIN-ALT-F1 and switch back with CTRL-WIN-ALT-F2 and then operate the mouse and keyboard on the appropriate machine, but the mouse doesn't move across to the other machine as it would from one screen to the other when both screens are connected to the same computer. Also the clipboard and file copy/paste doesn't work.
I have followed the advice to add a firewall rule, but which firewall is being modified? I run Norton, but there's always the Windows Defender playing in the background.

Hi there! Thanks for reporting this bug. I'm currently aggregating all of the similar bugs to help us track this moving forward -- please continue the conversation on the parent issue! /dup #31578


Should certain Work Types be available for per admin set?

Given admin sets:

theses for architecture
theses for other schools
articles

We only want the Thesis work type to go into the first two admin sets.

Given admin sets:
I do not want to be required to create a separate admin set for each work type,
but I do want to be able to indicate which work types are allowed - one, some or all --  for each admin set.

Discussion in this and tickets #678 and #675 are related and seem to ask whether the selection of admin set for a work should:

show a default admin set choice based on work type
limit the other available admin set choices based on work type

Obviously both of those would involve configuration. I think they would be reasonably straightforward to add from the UI point of view but we need discussion from a technical implementation and product point of view. @jcoyne @mjgiarlo @hannahfrost

@ggeisler @jcoyne @newmanld 👍 optional configuring certain work types per admin set.

@jeremyf I can get behind that use case. But that means de-coupling workflows from admin sets, correct? What are the ramifications of that?

Do we need a wiki page for use cases?
Is it perhaps not de-coupling workflows from admin sets, but allowing admin sets to bring together choices on work types, participants, workflows (and workflow roles) - and potentially display sets?
Does an admin set need to support more than one workflow?  (For example, my use case did not extend to being able to assign a different workflow for each work type within a single admin set,  but to be able to allow a particular work type (or work types) within a given admin set and that set’s workflow.)
Where do groups fit in?  How do we use our identity management systems to tie ‘all registered users’ or groups of users by status, to a default admin set, for the use case of a self-submission repository where all users (or all ‘faculty’ users) should have rights to at least the default admin set without requiring a repository manager to explicitly assign each user as a participant with a workflow role? (@jeremyf this was the group issue that I think you volunteered to document at LDCX)

@hannahfrost The ramifications will be:
We need a UI for saying which Work Types are available for an AdminSet.
We need a UI for choosing which Workflow is active for a Work Type within the AdminSet.
When a work type is created, we need to change the actor that assigns its workflow (from AdminSet based decision to AdminSet & Work Type)
There are then considerations for AdminSet roles and how those cascade to Admin Set & WorkType workflow roles.
@newmanld Ah yes, groups…it's coming back to me. We (@laritakr and I) are working through a Group Adapter at Notre Dame to wrangle together the wild and wooly group behavior. This would provide a point for you to implement the UC group logic. That work is being scheduled and vetted.

@jeremyf Got it. Thanks.

@vantuyls and all, trying to catch up on these discussions and I wanted to see if the outcome here is solving something we talked about a while ago. What we'd really like to do is have a work type like "Senior Honors Thesis" where upon submission, the only place it can submit to is: "Honors Thesis Admin Set".  So in this case, we do not want the student to have to select any Admin Set, but it is selected for them as designated by the work type and workflow. There a lot of reasons we don't want to have students selecting Admin Sets, which I could elaborate on.
Is that how others see this working? @hannahfrost

@julesies  - your description fits one of our use cases, where we would like certain users (unless they are acting as a proxy for someone else) to be limited to a specific admin set, and have a work type uniquely authorized for that admin set.
And when there is only one admin set available to users (when not acting as someone else’s proxy), not give them a choice – make the choice for them.

@newmanld we are planning that all users can submit to the "default" admin set. So a user like a Senior Theses submitter, would actually have at least 2 admin sets that they should be able to submit to. That is why I was hoping a student submitter would never have to chose an admin set but that by just selecting the work type "Honors Thesis" they would never have to go the sharing and relationships tabs. Mostly I'm worried about 1-time users like students having a good experience.

@julesies – That’s completely consistent with what we want to do, and I agree with the goal of presenting no choice of admin set to the user if the UI can make the choice for the user (based on other selections by that user such as work type).
I’m not sure what use cases we have committed to having Admin Sets in Hyrax address.  Given a use case, I’m not sure that the choice of work type will always be the only determinant of what admin set is applicable.  It could be a choice of collection, or it could simply be based on the user’s status (their departmental membership, faculty/staff/student, etc.?)  I think this relates to #675 and #678.

Below are some mockups that I think might address the use cases brought up in the comments above. The mockups suggest:

changing the title of the Administrative Sets > Workflow tab to "Work Types"
moving the renamed tab to be between Participants and Release and Visibility (minor issue I don't feel too strongly about, but seems slightly more appropriate there to me)
redesigning the content of the Work Types page to enable selection of work types valid for the admin set and, for each work type, selection of the workflow to be used for that work type

Combined with the proposal in #695 to show but disable the Admin Set menu choice for users depositing a work when there is only one Admin Set available for the work being deposited, I think this might address all of the concerns raised in #695, #678, and this ticket (thought it is also very possible that I've overlooked or misunderstood some of those concerns!).
Default state of Work Types tab
As an admin configuring a new (or editing an existing) admin set, when I get to the Work Types tab I would see all configured work types listed and selected by default:

Assigning a workflow to a work type
For each selected work type, I can see the default workflow is assigned, but I can change that assignment (below I have clicked Change for the Thesis work type to reveal the workflow selection options):

Disabling a work type
If I don't want a given work type to be deposited to this admin set, I can uncheck that work type. The workflow selection for an unchecked work type is disabled:

@ggeisler I think this has a lot of promise.
I assume that the choices of work type that a depositor sees - before they get to the individual or batch work create form -  would then be limited to the work types authorized by that depositor's participant status in admin sets (unless all work types are authorized for all admin sets).
The choice of work type by the depositor could determine the choice of admin set - relates I think to some of the discussion in #675 and #695.  But, if a work type is included in more than one admin set (maybe due to differences in desired workflow or visibility), and a participant is a depositor in more than one of those admin sets, then they would still have a choice of admin set.
Given all the discussion re Admin Sets, I hope others will also comment.

@newmanld:

I assume that the choices of work type that a depositor sees - before they get to the individual or batch work create form - would then be limited to the work types authorized by that depositor's participant status in admin sets (unless all work types are authorized for all admin sets).

Yep, I believe so.

The choice of work type by the depositor could determine the choice of admin set - relates I think to some of the discussion in #675 and #695. But, if a work type is included in more than one admin set (maybe due to differences in desired workflow or visibility), and a participant is a depositor in more than one of those admin sets, then they would still have a choice of admin set.

Yep. Which is what we want, I think? If I, as as depositor, have ability to deposit my image work in more than one admin set, presumably I know which is the appropriate one. The potential downside is if I'm a one-time or very occasional user, maybe I don't pay proper attention to the admin set selection and just hit Save and get the current admin set selection without explicitly choosing. But hopefully many one-time or very occasional users will be restricted to a single admin set (e.g., the default set or the "Thesis" admin set) and thus won't be in this situation (because the admin set selection will be disabled for them).

I wonder if it would be a good and informative exercise for institutions to mock up their repository under these set up? Kind of like when the PCDM group was modeling real examples to see if their base model worked on real examples?

Here's a use case that I'm not sure how it would work in this mockups.

The general goal is to prevent ever having to have users of any role select which AdminSet to place a work into. For certain roles, WorkType X is only offered as an option. Generic users don't get it. Any work added to WorkType X goes in an AdminSet with different permissions/workflows. The key is that we want the assigning of admin sets to be automatic without requiring the user to select one or the other.

I'm assuming that you would do this in the mockups by turning off WorkType X in one AdminSet and then making it the only one active WorkType in the other AdminSet? That would work but is a bit of a backwards to manage it. I'd almost expect there to be a similar interface where you can define which AdminSets each WorkType can belong to.
Related to this, if a WorkType has multiple AdminSets it can be placed into, can you define a default one for that WorkType?
We'll also need to consider how any of this decisions interact with the current setting option of whether AdminSets can be selected.

@mjgiarlo has there been any more conversation about this ticket? We are now setting up our Hyrax repo and this is an issue we are trying to figure out. Would be interested in figuring out how to get this done and where we might participate.

@julesies Negative. We can consider this for the 2.x series roadmap, of course, especially if y'all or others are inclined to take a hack at it. It may benefit from a conversation -- the above conversation is so long that the issue may be hard for someone to pick up and act on.

Just documenting here another reason this is a problem (which we found in testing nurax). If there are any admin sets with restricted visibility and release and that admin set is the last one created (thus the default dropdown admin set), the depositor doesn't realized that and is prevented from entering the visibility and embargo settings they want/need (if that does meet the vis requirements of the particular admin set). You can try a deposit at https://demo.curationexperts.com where there are many admin sets with various settings. In addition, if any admin set with mediated workflow is accidentally chosen, the work goes into the queue.

I think some larger scale admin set discussion is appropriate, but let's close this one out and re-raise this in SIGAHR, if appropriate.


How to deal with webp images

I'm trying to post webp images but I get the following error:
headers, post_data = API._pack_image(filename, 4883, form_field='media', f=f)
raise TweepError('Invalid file type for image: %s' % file_type)
tweepy.error.TweepError: Invalid file type for image: None

My code works fine with jpg's and png's but not with webp's
#1298 mentions the use of imhdr to handle webp as a fallback, but have no idea how to implement it.

I can see that is already a fix for 3.9.0 in 3733fd6 is there anything I can do to get it to work with 3.8.0 I'm using a google-cloud-function to build my Tweets is kinda of a bummer, because I built my converter assuming webp availability.

Released in 17700c6

This was indeed resolved with https://github.com/tweepy/tweepy/commit/3733fd673b04b9aa193886d6b8eb9fdaf1718341 as part of v3.9.0 and is a duplicate of #1298.


Custom request/response headers in IIS via server variables

https://www.iis.net/learn/extensions/url-rewrite-module/url-rewrite-module-20-configuration-reference#Note_about_request_headers_

PR: https://github.com/aspnet/BasicMiddleware/pull/184


Expected rewards and expected costs for p_reveal_content are hardcoded

Reward hardcoded to 1, cost to 0

all rewards and costs should be set through params, not hardcoded.
We currently have one op_costs bucket, which we might slightly rework. Can discuss before implementation

Currently modular, with an issue here #311 for implementing a basic profitability thing from parameters


Node v6 support

I am getting below error when I try to use Node v6.
(node:32838) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
done

Closing this as node v6 is now out of LTS


[Regression]: Cooperative Intercept Handlers should execute even when a handler throws an exception

Bug description
@jschfflr I believe https://github.com/puppeteer/puppeteer/pull/7722/files#diff-2fedf4b9325c81a1652c274473daa03e99b58f353e1bba42da48d43f15a4f527R232 introduces two regressions with respect to Cooperative Intercept Mode:

Uncaught/unhandled exception when handler throws
Handler exception stops subsequent handlers from executing

In the below TS playground example, you can see the importance of .catch(handleError). Without it, handler3 is never executed. This is undesirable in any cooperative scenario because it means your handler is not guaranteed to run. See https://github.com/puppeteer/puppeteer/blob/v11.0.0/docs/api.md#cooperative-intercept-mode-and-legacy-intercept-mode which states In Cooperative Mode, all intercept handlers are guaranteed to run and all async handlers are awaited.
const handler1 = async () => {
  console.log('handler 1 success')
}

const handler2 = async () => {
  throw new Error(`Handler 2 failed`)
}

const handler3 = async () => {
  console.log('handler 3 success')
}

const handleError = (e:Error)=>{
  console.log(`Caught error ${e}`)
}
const interceptActions = [handler1, handler2, handler3]

const finalizeInterceptions = async () => {

  await interceptActions.reduce(
    (promiseChain, interceptAction) => promiseChain.then(interceptAction).catch(handleError),
    Promise.resolve()
  );
}

finalizeInterceptions()

Puppeteer version
master
Node.js version
14
npm version
8
What operating system are you seeing the problem on?
macOS
Relevant log output
No response

I think https://github.com/puppeteer/puppeteer/pull/7020/files#diff-2fedf4b9325c81a1652c274473daa03e99b58f353e1bba42da48d43f15a4f527L233 contributed to this regression because the comment about the reasoning for catching the error was removed.

Tagging:
#7020
#7722

While we're on the topic, I think removing the catch here (https://github.com/puppeteer/puppeteer/pull/7020/files#diff-3280fbae5b6189c9b87a76ea21a5da3e10140467e29532e0b7b72608036f5070L391) might be unwise. I remember something about future versions of nodejs exiting for unhandled exceptions rather than just reporting them. Not sure what the Puppeteer team's policy is regarding unhandled exceptions, but I thought I'd mention it.


Character Build updates

Hi, when will the page be updated with the newly released characters? Emilie, Mualani and Kachina?

The site has been updated with content up to patch 5.0!


List Structure

Add basic structure to the to-do list

Hello @mrjuda, please I accidentally approved your pull request, when I intended  requesting for changes, please kindly implement the requested changes and ask for a  re-review.

Hello @mrjuda, please I accidentally approved your pull request, when I intended requesting for changes, please kindly implement the requested changes and ask for a re-review.

No problem, all requested changes were applied. Thank you :-)


Metrics alarms widgets created with Composite alarms

I am working with BasicServiceMultiAZObservability class to create a basic dashboard. The current deployment creates all the resources without errors, but I found the following problems:

The alarm widgets are created with AlarmWidget (metric alarm type), but the alarm type configured in the widget is a composite alarm. So the widget stay in error mode saying that it doesn't find the alarm, and that is because is looking for a metric alarm type.
The piece of code where the alarm widgets are added to the dashboard tries to set a widget per AZ, but the var availabilityZoneId is static in that loop. So, the widgets are created for the same AZ.

I did the following changes local to make it work in the file src/multi-az-observability/lib/dashboards/BasicServiceDashboard.js in the methods createLoadBalancerWidgets and createNatGatewayWidgets
static createLoadBalancerWidgets(alarms, metrics) {
        let widgets = [];
        widgets.push(new aws_cloudwatch_1.TextWidget({
            markdown: "Load Balancer Fault Count Metrics",
            height: 2,
            width: 24,
        }));
        let rowTracker = 0;
        Object.keys(alarms).forEach((availabilityZoneId, index) => {
            widgets.push(new aws_cloudwatch_1.GraphWidget({
                height: 6,
                width: 8,
                title: availabilityZoneId + " Load Balancer Faults",
                region: aws_cdk_lib_1.Fn.sub("${AWS::Region}"),
                left: [metrics[availabilityZoneId]],
                statistic: "Sum",
                leftYAxis: {
                    min: 0,
                    label: "Fault Count",
                    showUnits: false,
                },
            }));
            //We're on the third one for this set, add 3 alarms
            //or if we're at the end, at the necessary amount
            //of alarms, 1, 2, or 3
            // if (index % 3 == 2 || index - 1 == Object.keys(alarms).length) {
            //     for (let k = rowTracker; k <= index; k++) {
            //         widgets.push(new aws_cloudwatch_1.AlarmWidget({
            //             height: 2,
            //             width: 8,
            //             region: aws_cdk_lib_1.Fn.sub("${AWS::Region}"),
            //             alarm: alarms[availabilityZoneId],
            //         }));
            //     }
            //     rowTracker += index + 1;
            // }
        });
        //Add bottom load balancer alarms widgets
        Object.keys(alarms).forEach((availabilityZoneId, index) => {
            widgets.push(new aws_cloudwatch_1.AlarmStatusWidget({
                height: 2,
                width: 8,
                title: availabilityZoneId + " Load Balancer Isolated Impact Alarm",
                alarms: [alarms[availabilityZoneId]],
            }));
        });
        return widgets;
    }

This should be fixed now with the latest release.


[FRG] - Ability to add multiple sub-reports

Right now it seems like you can only have one sub-report to a report, since there's only a subReport property which accepts one object.

Can you give me an instance where you need another sub-report?    Sub-reports are created based on the data you send in.   So if you send in:
Master
  -> Detail

It creates a "Detail" subreport.    I haven't tested it but if you sent in:
Master
   -> Detail 1
   -> Detail 2

I believe you should get two sub-reports.

Say my data looks something like this:
{
    type_a_tests: [
        {
            type_a_name: 'A Test'
        }
    ],
    type_b_tests: [
        {
            type_b_name: 'B Test'
        }
    ]
}

I know I can make a sub-report for one of these with a report structure like this:
{
    name: 'test.pdf',
    subReport: {
        type: 'report',
        dataType: 'parent',
        data: 'type_a_tests',
        detail: [
            {
                type: 'print',
                field: 'type_a_name'
            }
        ]
    }
}

but how can I make two sub-reports, one for each?

Yeah, I see your problem.    I'll look into updating the engine to support an array of subreports.

Fixed in the latest release.


Add tests for codemap

mod foo {
    pub fn x(y: isize) { log(debug, y); }
    //~^ ERROR cannot find function `log` in this scope
    //~| ERROR cannot find value `debug` in this scope
    fn z(y: isize) { log(debug, y); }
    //~^ ERROR cannot find function `log` in this scope
    //~| ERROR cannot find value `debug` in this scope
}

fn main() { foo::z(10); } //~ ERROR function `z` is private

Example https://github.com/rust-lang/rust/blob/master/src/test/ui/export.rs
Maybe one could take code generation approach? Not sure how rust did that but it generates .stderr files to show the snapshot of the exact error.

This exists as https://crates.io/crates/compiletest_rs

But that only works for rust projects, sometimes it would be useful for non-rust projects to use codemap. I see this may be useful in https://github.com/connorskees/grass

This library is just utilities for storing and manipulating spans, and does not have any error reporting to test. Maybe you're thinking of codemap-diagnostic? There are basic unit tests for the functionality of this library already, but please open a PR if you see a place to improve test coverage.


Fix type 3 png's (indexed color) without alpha crashing

Merge AFTER #158 and #163!!
currently even pngs of type 3 WITHOUT an alpha channel are treated as if they had an alpha channel.
Since png's of type 3 require a tRNS chunk for alpha, we check for said chunk first and only if that one is found is this type of PNG considered alpha png.
Fixes #107

Fully working now.
Note to make ""proper"" 8bit indexed alpha images you have to pipe it as GIF a second time to imagagick.
(At least that's the only way I found that works.. /shrug)
See also: https://www.imagemagick.org/discourse-server/viewtopic.php?t=18011
Example:
 convert input.png -depth 1 -trim -colors 256 -type palettematte GIF:-  | convert - -depth 1 "output.png"```
Test results:
Before my Initial fix:

crash on type3 png's with alpha.

Final (now):
Click to show

Before (with initial/first fix(-attempt):
Click to show


Proposal for RPC tokens

This is the proposal for using RPC tokens to isolate rings from improperly setup instances.
The PR is large, but github doesn't let me stack changes. I suggest looking through the individual commits which I've split out.
The gist is this:

We identify the Raft related RPCs are that done automatically by kuduraft, such as

UpdateConsensus
RequestConsensusVote
RunLeaderElection

We then stamp each request and each response with a field: raft_rpc_token
In ConsensusService, in enforce mode, we reject outright all such requests without a matching token
In PeerProxy we hijack the response callback and replace responses with errors if the response token is wrong

This way, we intercept all RPC communication without a proper token before it hit any part of raft_consensus.
Couple of design explanations:
Rejecting responses
Initially I only rejected requests. However, there are edge cases. A bad instance joining a ring with a higher term and is itself not enforcing for request tokens will happily accept RPCs from the leader and respond. Based on the Raft protocol the higher term in the response will cause the current leader to step down. If the bad instance keeps doing this, even with request tokens a bad instance can still destabilize the ring. This is why we need to discard responses from the bad instance too.
Enforcement
Currently we have 2 levels, on or off. When it's ON will actively generate errors to interrupt the RPC flow. When it's OFF we currently just log a WARNING log and pretend nothing has happened. Either way tokens are compared.
This needs to be improved to bump counters, but this PR is huge as it is so that'll be a next step.
Token storage
Tokens are stored in persistent_vars, which will survive a restart. They can be set via public APIs of RaftConsensus. persistent_var is not thread safe.
Tokens are used in the critical Raft replication path, so I designed them to be lock free on reads by using atomic ops on a shared ptr. Writes are synchronized by the various locks in RaftConsensus and Peers but we
We don't allow tokens to change when we're enforcing. It's technically possible for one or two rpcs to miss the new token if we set a new token and turn on enforcement immediately (which is not really an intended use case anyway, we should set the token, do verifications, then enforce). However, even in such a case the next RPC will know of the new token since it's read from the ptr every time.

topology_config automatically persists on disk. Since ring_uuid is already part of topology_config, why not just use it?

topology_config automatically persists on disk. Since ring_uuid is already part of topology_config, why not just use it?

topology_config is used for bootstrapping, and I believe it's only persisted on init. We need something that persists on the fly. Persistent_vars already gives us that for free.
Another point is that if we do it in topology_config, it'll be passed to kuduraft as a server_opt. server_opt will eventually be copied to actual object properties when we bootstrap. Most likely this will live in RaftConsensus. But we need to reference this in ConsensusQueue as well, and if it's changed, we'll have to thread it into ConsensusQueue.
 This makes it easier to set and read from multiple places without having to do extra threading.

But on the destination side this is already what I'm doing. If the destination finds a mismatch it already sends back RING_TOKEN_MISMATCH as an RPC error and no rpc information.
The response checking is for another real scenario I saw during testing:
I started a ring, set the token and made one node bad. I turned on enforcement for everyone else.
The leader reached out to the bad node. The bad node didn't care about the token (because it's not enforcing), and just gave a reply with a higher term. The leader gets this higher term and immediately stepped down. In other words, even though the leader is enforcing on requests, it didn't reject a bad response. And since leader step down is an action we take on receiving a response, just checking when we get a request is insufficient. So a bad instance, even if the leader enforces requests checks, can still destablize the ring.
So the case I'm guarding here is when a destination (in the config) acts in bad faith and did not enforce the contract. I'm adding the requirement that followers present their own token on a response, so that if the follower is misconfigured, the leader will not care about their responses.


CI fails to create PR comment when output is too long

Example: https://github.com/charliermarsh/ruff/actions/runs/4820701572/jobs/8585562172
As per GitHub documentation, this might be occurring because:

Outputs are Unicode strings, and can be a maximum of 1 MB. The total of all outputs in a workflow run can be a maximum of 50 MB.

If so, the solution would be to comment using a filePath instead of passing it to the message key.
But then comes the limitation of the comment itself which is 65536 characters (tested it out on my own repo):
Error: Validation Failed: {"resource":"IssueComment","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

Now, the solution would be:

Move the output to a file (could use GITHUB_WORKSPACE)
Use the filePath to post the content of PR checks
Truncate the content to limit it to < 65536 characters and add a link to the summary page

This now gets truncated.


Dump parse result to Quint

Each task on quint should have an output to help debugging. We should implement a sort of pretty printer for the IR which translates every node to Quint normal form, and then use that to dump an indented version of the module to a .QNT file. The main purpose is to manually check whether a successful parse actually did the right thing while debugging.

Do we basically have this in place now?