[WIP] Add compiled package symbol enter initial phase

Purpose
This is to add new Symbol enter phase for bir files.
Fixes #
Part of https://github.com/ballerina-platform/ballerina-lang/issues/15084
Approach
Save the BIR in the balo zip file along with the current balo(this is for the time being, should remove the balo later), then use that bir for the symbol enter when some other package depends on this package. For the time being, we use --jvmTarget flag to differentiate these two flows (like when u build some package with --jvmTarget flag, then it will look bir files for dependent packages as well.
Samples
Remarks
This PR also modifies the build process as well, change is as follows,
if you build a project with --jvmTarget flag, then it will generate bir (and include that for every balo zip libraries) and generate jar files where applicable (for packages with entry points)
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15238 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #15238      +/-   ##
============================================
- Coverage     23.25%   23.06%   -0.19%
  Complexity     5065     5065
============================================
  Files          1336     1343       +7
  Lines         67438    67972     +534
  Branches       9179     9240      +61
============================================
  Hits          15680    15680
- Misses        50020    50554     +534
  Partials       1738     1738

Impacted Files
Coverage Δ
Complexity Δ

...erinalang/compiler/FileSystemProjectDirectory.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...wso2/ballerinalang/compiler/tree/BLangPackage.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ng/compiler/packaging/converters/URIConverter.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...mpiler/semantics/model/symbols/BPackageSymbol.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../org/ballerinalang/repository/CompiledPackage.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...allerinalang/programfile/ProgramFileConstants.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...java/org/wso2/ballerinalang/compiler/Compiler.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../ballerinalang/compiler/BIRPackageSymbolEnter.java
0% <0%> (ø)
0 <0> (?)

...2/ballerinalang/compiler/util/CompilerOptions.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...llerinalang/compiler/bir/writer/BIRTypeWriter.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1817fa2...e70d6f7. Read the comment docs.


Change in models

These errors or improvements in the backend should be available as soon as possible because the frontend is requesting that.

Limit the character maximum length in some fields. To prevent typing a longer text than requested. (In the fields that have sense)
Enable the schedule model and CRUD.
Enable a field in the user to save if the user has agreed on the terms and conditions and which version. (Enable only using the app to the ones that have accepted the last version of it)
The email verification should be resolved in the backend. That means creating a HTML page to verify the account without involving the frontend. (Check if it's possible or if it should only be managed in the frontend because of CORS and Allowed Hosts policy)

Revise and update the populate to keep it working after the new changes.

Story Points: 5
See the discussion in Backend S3
Powered by Parabol


Can't build ssd-mobilenet caffe model to tensorrt

Hello @dusty-nv .
I train my custom dataset object detection caffe model SSD-Moblienet from https://github.com/chuanqi305/MobileNet-SSD.
I test a simple is working for me. but when I try build tensorrt with command line didn't work.
/detectnet-camera --model=/home/phanith/MobileNet-SSD/dataset/output/mobilenet_iter_3500.caffemodel --prototxt=/home/phanith/MobileNet-SSD/dataset/prototxt/MobileNetSSD_deploy.prototxt --labels=/home/phanith/MobileNet-SSD/dataset/list/labels.txt --input-blob="data" --output-bbox="detection_out" --mean-pixel=127.5 csi://0 --input-flip=rotate-180
-Error:
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
Warning: Flatten layer ignored. TensorRT implicitly flattens input to FullyConnected layers, but in other circumstances this will result in undefined behavior.
[TRT]    mbox_loc: all concat input tensors must have the same dimensions except on the concatenation axis (0), but dimensions mismatched at index 1. Input 0 shape: [19,19,12], Input 1 shape: [10,10,24]
[TRT]    mbox_loc: all concat input tensors must have the same dimensions except on the concatenation axis (0), but dimensions mismatched at index 1. Input 0 shape: [19,19,12], Input 1 shape: [10,10,24]
Caffe Parser: Invalid axis in softmax layer - TensorRT expects NCHW input. Negative axis is not supported in TensorRT, please use positive axis indexing
error parsing layer type Softmax index 186
[TRT]    device GPU, failed to parse caffe network
[TRT]    device GPU, failed to load /home/phanith/MobileNet-SSD/dataset/output/mobilenet_iter_3500.caffemodel
[TRT]    detectNet -- failed to initialize.
detectnet:  failed to load detectNet model

Hi @SokPhanith, I haven't tried SSD-Mobilenet through Caffe before.  I recommend to use this PyTorch version here, which is known to be working:  https://github.com/dusty-nv/jetson-inference/blob/master/docs/pytorch-ssd.md

I used to Re-train on it https://github.com/dusty-nv/jetson-inference/blob/master/docs/pytorch-ssd.md but I saw /detectnet-camera support with caffe model too. Can you give me Github source or caffe model that SSD-Mobilenet can build with  /detectnet-camera

That is only the older 'detectNet' DNN architecture trained with DIGITS that worked with caffe.   The newer SSD-Mobilenet model that works with TensorRT is trained with PyTorch.  I don't know of SSD-Mobilenet from Caffe that works with TensorRT.


Updates

@homu r+

:pushpin: Commit c46f163 has been approved by kbknapp

:hourglass: Testing commit c46f163 with merge 43a5413...

:sunny: Test successful - status


Fix 1836

make both lists start with 5 element
Fixed via datatables config

filter user study list to not contain public studies
Fixed in qiita_pet/handlers/study_handlers/listing_handlers.py by removing public studies from the list

check why everything in the user study list is awaiting approval
This one was trickier than expected: (1) there was an error in the SQL, we were retrieving all available statuses vs. all statuses of all the artifacts in that study; and (2) the infer_status method was expecting a list of list with one string element but it really returned a list of strings, we were comparing against the first letter. Had to change some of the tests.

Note that this was tested in the test environment and it works as expected, still deploy if you want to take a look.

Coverage decreased (-0.06%) to 84.454% when pulling 59f0ba3281fe8f6441139d64782341dd4eee207c on antgonza:fix-1836 into 4b74d5144b956e6ac08e1dd3ba3c5e7ba2a611ef on biocore:master.

It all looks good to me! Just kinda surprised that none of the tests changed with the changes to util.py. 👍


Classification and Pre-trained Weights

Thank you for your outstanding contributions! I would like to know if modifying the final head layer would be sufficient to adapt the model to a classification task, and whether there are any plans to provide pre-trained weights for the model on large-scale datasets.

Hi, please refer to this repo for the pre-trained checkpoint

Hi, There are only checkpoints for Timer but not Timer-XL in the link above. Will you release Timer-XL checkpoints?

Of course, we will release the checkpoint of Timer-XL. Please stay tuned.


Various accessibility fixes for Syntax Visualizer

Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1580007
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1579500
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1579508

How to use this thing from VS? The "Syntax visualizer" windows only triggers for C# files for me (VS v17.3 Preview 4)

@DoctorKrolic in case you're still wondering, the VS command to open the syntax visualizer is called "View.RazorSyntaxVisualizer". Easiest way to open it is to go to the Command Window (View, Other Windows, Command Window) and type that command name in, but you can also customize your VS menus and put the command anywhere you like, or assign a keyboard shortcut to it.


Voice.Hypha Deployment

Native Ballots / New HVOICE Token

[x] Step 1: deploy contract to voice.hypha @josejulio
[x] Step 1.a: create the HVOICE token itself (issuer: dao.hypha, decay time: 1 week, decay %: 1%) @josejulio
[x] Step 1.b: sync the balances - voice.hypha contract  @josejulio

parameters (dao-contract, trailservice)

[x] Step 2: update settings - add HVOICE_TOKEN_CONTRACT  - @dappdever
[x] Step 3: uncomment out HVOICE issuance from HVOICE-payer and member.enroll methods - @dappdever
[x] Step 4: update voice.hypha permissions  - @josejulio (@dappdever will provide the command)
[x] Step 5: write spec for UI to pull token balance from new location
-- cleos get table voice.hypha hyphanewyork accounts

The steps on the lists are done. Missing details are to:

Use voice.hypha to determine the voting power & quorum (all in proposal class)


noImplicitAny on single file

Is it possible to enable noImplicitAny for a single file? This would help us as we are gradually migrating and, when a file is complete, we can begin to use noImplicitAny.

Is it possible to enable noImplicitAny for a single file

Individual file compiler flags aren't supported at the moment. Figuring out how different files compiled with different flags interact would be a problem.
You probably want something like disable certain errors per file. There is an issue request for that somewhere (I'm on a train) :rose:

You could patch the existing CompilerHost or create your own that suppresses arbitrary diagnostics from arbitrary files, but I don't believe there's anything in-built.

@basarat we're incrementally adopting TypeScript - a use-case I imagine is shared by many! There opt-in is preferable. We start off files as noImplicitAny and would like to move them out of that state one by one.

The issue here is that types could leak into the compilation context. there is no grantee that an implicit any has a local effect. and thus there are no guarantees about refactoring, find all refes, etc..
in general if it is a point-in-time, e.g. migrating to TS or from implicit anys to noImplicitAny, etc, i would recommend doing it all in one shot, or splitting the compilation into two chunks, each with a different flag, and moving files/modules from one chunk to the other.
You can see a similar response for --strictNullChecks in https://github.com/Microsoft/TypeScript/issues/8405#issuecomment-219782002.

i would recommend doing it all in one shot, or splitting the compilation into two chunks, each with a different flag, and moving files/modules from one chunk to the other.

This is really difficult for a large code base sadly :-( We did think about maintaining two graphs, one strict and one unstrict, however this means modules can't be shared between the two which makes it hard.
 I only want `noImplicitAny` to apply for `strict.ts,` not `unstrict.ts`. Any tips how I might go about this? My instinct is to try and parse the error output from tsc (split by new line??) and filter out that way
<OliverJAsh> Should I be using some Node API instead to receive parsed errors instead of trying to parse them myself?```

Does https://github.com/Microsoft/TypeScript/issues/8855#issuecomment-222880027 not work for you?

@Arnavion
Great, that works! See below. Now I am wondering how I could wrap/configure IDE plugins so they give they filter errors in the same way. Any ideas on how I might do that? Seems ambitious…
// main.ts
// ts-node --project main.ts
// https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API

import ts = require('typescript');

const options: ts.CompilerOptions = {
	// TODO: Consume project config somehow
	// project: `server/tsconfig.json`,
	outDir: 'tmp',
	// Strict only
	noImplicitAny: true
};
const program = ts.createProgram([`main.ts`]);
const emitResult = program.emit();

const allDiagnostics = ts.getPreEmitDiagnostics(program).concat(emitResult.diagnostics);

// We only care about no implicit any errors on "strict files"
const strictFiles = [
	'strict-file.ts'
].map(str => `${__dirname}/${str}`)

const errors = allDiagnostics
	.filter(diagnostic => {
		const isStrictFile = strictFiles.indexOf(diagnostic.file.fileName) !== -1;
		const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');
		const isImplicitAnyError = / implicitly has an 'any(\[\])?' type.$/.test(message);
		return isStrictFile ? true : (isImplicitAnyError ? false : true);
	});

const errorStr = errors
	.map(diagnostic => {
		const { line, character } = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start);
		const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');
		return `${diagnostic.file.fileName} (${line + 1},${character + 1}): ${message}`;
	})
	.join('\n');

if (errorStr) {
	process.stderr.write(errorStr);
	process.stderr.write('\n\r');
	process.exit(1);
}

How about doing it on a per-type basis See #18540. It avoids the need to create two graphs, and now the check becomes a property of the type. A potential suggestion is to use comments to indicate strictness.
/* @strict */
interface MyType {
....
}
At any point during compilation, the use of type implicitly converts to any or vice versa, throw a compiler error.


Found a possible security concern

Hello 👋
I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@krizzsk) has found a potential issue, which I would be eager to share with you.
Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.
Looking forward to hearing from you 👍
(cc @huntr-helper)

Hello,
Thank you so much for giving your attention.
I have created a SECURITY.md with a short of necessary information how do you report the security issue.
Looking forward to hearing from you soon.
Thank you again


treat measure double NaN

Description

treat measure double NaN
Related Issue : #3342

How Has This Been Tested?

Create a dashboard with sales datasource
Create a user-defined field field created with NaN values. (ex: Divide by zero)
Create a line chart with the user-defined field
Check if it is displayed normally without infinite loading.

Need additional checks?
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have added tests to cover my changes.

Additional Context

deploy to 2


chap 5 - add file input to code interpreter

File upload:
import streamlit as st

st.title('File Upload 📁')
uploaded_file = None
if 'toggle_file' not in st.session_state:
    st.session_state.toggle_file = False

def toggle_on():
    if not st.session_state.toggle_file:
        st.session_state.toggle_file = True

def toggle_off():
    if st.session_state.toggle_file:
        st.session_state.toggle_file = False

st.button('upload file', on_click=toggle_on)

if st.session_state.toggle_file:
    uploaded_file = st.file_uploader("Choose a file")

st.write(uploaded_file)

if prompt := st.chat_input():
    with st.chat_message('user',avatar='user'):
        st.write(prompt)
        if uploaded_file:
            st.write(uploaded_file.name)
    toggle_off()


Support writing multi files of single partition to improve speed in HDFS storage

What changes were proposed in this pull request?

Introduce the PooledHdfsShuffleWriteHandler to support writing single partition to multiple HDFS files concurrently.

Why are the changes needed?
As the problem mentioned by https://github.com/apache/incubator-uniffle/issues/378#issuecomment-1342637715, the writing speed of HDFS is too slow and it can't write concurrently. Especially when huge partition exists, this problem will cause other apps slow due to the slight memory.
So the improvement of writing speed is an important factor to flush the huge partition to HDFS quickly.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?

UTs

Codecov Report

Merging #396 (649acd3) into master (3ec3f41) will decrease coverage by 1.04%.
The diff coverage is 34.37%.

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
- Coverage     58.77%   57.73%   -1.05%
+ Complexity     1602     1400     -202
============================================
  Files           193      174      -19
  Lines         10939     9255    -1684
  Branches        955      819     -136
============================================
- Hits           6429     5343    -1086
+ Misses         4132     3573     -559
+ Partials        378      339      -39

Impacted Files
Coverage Δ

...org/apache/uniffle/storage/common/HdfsStorage.java
0.00% <0.00%> (ø)

.../storage/handler/impl/HdfsShuffleWriteHandler.java
87.09% <ø> (ø)

...le/storage/handler/impl/LocalFileWriteHandler.java
75.51% <ø> (ø)

...ge/handler/impl/PooledHdfsShuffleWriteHandler.java
0.00% <0.00%> (ø)

...rage/request/CreateShuffleWriteHandlerRequest.java
71.42% <80.00%> (+0.59%)
:arrow_up:

...org/apache/uniffle/server/ShuffleFlushManager.java
82.90% <100.00%> (+4.89%)
:arrow_up:

...a/org/apache/uniffle/server/ShuffleServerConf.java
99.24% <100.00%> (+0.01%)
:arrow_up:

...torage/handler/impl/AbstractClientReadHandler.java
12.00% <0.00%> (-8.00%)
:arrow_down:

...rg/apache/uniffle/server/buffer/ShuffleBuffer.java
89.06% <0.00%> (-4.33%)
:arrow_down:

.../java/org/apache/uniffle/server/ShuffleServer.java
63.76% <0.00%> (-3.63%)
:arrow_down:

... and 39 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is there any read side related changes should be applied for this PR?

There is no need to do any compatible change in read client, because the original logic has covered the different partition files due to the prefix of retry times.

And, if possible, please add an integration test for spark3 with concurrent writer enabled?

It's OK. But the spark client test may be not accurate, because it's hard to control the concurrent write. And I think the integration test is enough and accurate.

Do you have other comments? @jerqi


[Django] Requests from iOS time out when raven is enabled

I am having an issue with requests from iOS timing out when Raven is enabled. Any endpoints from my project will time out, but not endpoints that are included from third party apps. The issue disappears when excluding Raven from installed apps. This issue only occurs when sending a request from an iOS app. The same requests made using httpie or Postman are successful.
To make things more complicated, the request only times out on the iOS side. As soon as it times out, Django (or rather runserver) happily reports that the request was successful with a 200 status code.
I apologize for the lack of detailed information or a stack trace, but I have not been able to produce an actual error from the Django application. Please let me know if further information is needed or if you have ideas on things I should investigate further.
URL Structure
As mentioned above, requests for URLs from third-party apps succeed, but any requests to URLs from my project fail.
Base URL File
# project/project/urls.py

urlpatterns = [
    url(r'^foo/', include('foo.urls'),    # Third party application works fine
    url(r'^my-app/', include('my_app.urls'),    # Application defined in my project fails
]

App URL File
# project/my_app/urls.py

app_name = 'my-app'

urlpatterns = [
    url(r'^bar/$', BarView.as_view(), name='bar-detail'),
]

Views
The views from the project are mostly based on DRF's generic views (eg generics.ListCreateView). I don't believe the issue lies here, since some of the third-party apps used utilize the same generic views.
Dependency Versions

Django 2.0.3
Django Rest Framework 3.7.7
Raven 6.6.0

Downgrading to 6.1.0 causes the requests to work, but constantly logs errors about URLConf, which I believe is related to the Django 2 support that was 6.2.0 addresses.
Upstream Issue
For reference, the upstream issue I'm trying to fix is knowmetools/km-api#298

@cdriehuys Hi Chathan. mind installing a version that doesn't instrument drf to pinpoint the problem?

I'm working on setting up a test project without DRF, but we might not be able to test against it until after the weekend.
On the topic of DRF though, we utilize some third-party apps built on top of DRF that work just fine. Any ideas on why only endpoints from our project are failing?

Hi @ashwoods. We tested against a test project without DRF, but came across the same behavior. The API doesn't respond until after the connection has timed out or ended, and then responds as expected as soon as that happens.

[26/Mar/2018 15:22:50] "GET /my-app/foo/ HTTP/1.1" 200 18

No additional information comes back regarding the request.

The test project, for reference.

The hanging behavior in Raven 6.2.0 and higher occurs when an empty set of parameters are provided for the http body.
request.httpBody = try? JSONSerialization.data(withJSONObject: parameters)

A little extra clarification thank to @cdriehuys . This is happening when the body is set for an endpoint that isn't expecting it. This occurs if the body is empty or not. In our case, it just happened to be empty because of the default value for parameters.

Thx. I’m not entirely sure why, but I can fix it.
On Wed 28. Mar 2018 at 19:20, Brandogs<EMAIL_ADDRESS>wrote:

A little extra clarification thank to @cdriehuys
https://github.com/cdriehuys . This is happening when the body is set
for an endpoint that isn't expecting it. This occurs if the body is empty
or not. In our case, it just happened to be empty because of the default
value for parameters.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/raven-python/issues/1215#issuecomment-376966621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4tWyQ_AjcWXbXviuUPucd5oNPjUXqks5ti8ZigaJpZM4S5TcM
.


Massive unwind + Issue #5024 + Weirdness

Describe the bug

Some context: I don't imagine this is reproducible, but I wanted to document it here. I use Arch Linux. Prior to starting up my node I had to run fsck, because my drive was corrupted. So on a fresh install of reth + lighthouse, I started to sync a node
Everything was going fine, I finished the headers + totalDifficulty stages. During Sender Recovery stage, I hit #5024. I commented that I hit it on that issue, restarted my node, and it seemed to have fixed itself. Sender Recovery finishes and execution starts. I go to bed and overnight my internet shuts off. Check on sync progress and see execution had stopped, the db had been unwound to the blockheight of the latest executed block (4604449). Sender Recovery drops from 18m to 4604449. A number of hours later Bodies, followed by TotalDifficulty, followed Headers, all drop to 4.6m.
I reset my internet in the AM and it starts redownloading headers, and is currently redownloading bodies.
So a few things:

#5024
Massive unwind?
All could be related to a dying nvme drive

Steps to reproduce

Maybe have a broken drive, run fsck
Start Node
Hit #5024
Restart Node
Finish Sender Recovery, start execution
Lose internet connection
Undergo the massive unwind

Node logs
Unfortunately logs were overwritten when I restarted the node.

Platform(s)
Linux main 0.5.9-arch2-1 (Arch Linux)
What version/commit are you on?
2d315c2f
What database version are you on?
1
What type of node are you running?
Archive (default)
What prune config do you use, if any?
None
If you've built Reth from source, provide the full command you used
RUSTFLAGS="-C target-cpu=native" cargo build --profile maxperf --features jemalloc
Code of Conduct

[X] I agree to follow the Code of Conduct

@brockelmore was this due to bit flip? or is this something we should look into


Add bundle specific route config demo

Fixes #28
Depends on vlukashov/vaadin-demo-helpers#7

This change is

Review status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @web-padawan)

demo/vaadin-router-code-splitting-demos.html, line 127 at r1 (raw file):
Quoted 7 lines of code…

children: function(context) {
  return new Promise(function(resolve) {
    Vaadin.Demo.import(`${Vaadin.Demo.componentsRoot}/users-routes.js`).then(module => {
      resolve(module.default);
    });
  });
}

What do you think about shortening this down to a one-liner children: () => import('/users-routes.js').then(module => module.default)?

demo/demo-elements/users-routes.js, line 6 at r1 (raw file):

  Vaadin.Demo.moduleStorage = Vaadin.Demo.moduleStorage || [];

  const userRoutes = [

Is it intentional that the module name is userRoutes (singular) and the file name is users-routes (plural)?

Comments from Reviewable

Review status: 0 of 26 files reviewed, 4 unresolved discussions (waiting on @web-padawan)

demo/vaadin-router-code-splitting-demos.html, line 97 at r2 (raw file):

Bundle Specific Route Config

How about calling this demo something like Splitting and Lazy-Loading the Routes Configuration? Now that there is no config property maybe it does not have so much sense to call this feature "bundle-specific config".

demo/vaadin-router-code-splitting-demos.html, line 99 at r2 (raw file):

Vaadin.Router supports code splitting for the config object

I suggest Vaadin.Router supports splitting the routes configuration object into parts and lazily loading them on-demand, ...

demo/vaadin-router-code-splitting-demos.html, line 101 at r2 (raw file):

without a central coordination

I suggest to change this to highlight the benefits and remove the no central coordination part - I think it sounds too negative.
It could be something like without all teams having to merge their changes into the same file.

demo/vaadin-router-code-splitting-demos.html, line 107 at r2 (raw file):

      array of the route objects. It may return a Promise, which allows to dynamically import
      the configuration file, and return the children array exported from it.

Let's add a link to the API docs describing the children callback in more details.

Comments from Reviewable

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 23 of 23 files at r3, 7 of 7 files at r4, 2 of 2 files at r5.
Review status: all files reviewed, 4 unresolved discussions (waiting on @web-padawan)

Comments from Reviewable


Custom input size in VGG

Hi. I'm quite new to machine learning. After some performance issues with Tensorflow, I'm transferring my code to Pytorch.
The question I want to ask is more of a question about Pytroch itself.
I have images with a different size than 224x224x3. At the moment it's 50x250x1 (or x3 if I decide) but it may change. I'm not sure how to modify the code of https://github.com/pytorch/vision/blob/master/torchvision/models/vgg.py in lines 29 & 31 to match the requirements.
Do I really need to calculate the sizes for the avgpool and the first classifier's layer? Can it somehow be done automatically as it's done in Tensorflow?
EDIT: One additional question. How batch_size is incorporated into the dimensions of layers? Should I be worried or is it done automatically?

I used the below code to calculate pool input size:
def top_output_shape(self):
        m_count = 5 # the number of max pools in the model

        return (
            int(self.input_shape[1] / 2**m_count),
            int(self.input_shape[2] / 2**m_count)
        )


General implementation recommendations?

Hi,
I'm a noob on NodeJs development, so please forgive me for asking this here. It just happens I'm building an app using the harmonyhubjs-client. My app needs to send commands to the hub, but also receive triggers when the current hub activity changes. My app would be running 24/7.
I'd like some advise on whether to go for one global client instance and use that for everything (so reusing one connection over and over) or to instantiate a client whenever the app is requested to execute an action (e.g. change the current activity) and immediately close the client (connection) afterwards.
Any advice would be greatly appreciated!
Cheers,
Raymond

hi raymond
there is no correct or wrong answer. it really depends on how you are gonna structure your application.
having a "global" client for everything should not be a problem i guess. you can model your system into various sub modules and let them all use the global instance. or you could pick the opposite extreme and let each module connect to a hub on its own. though i'm not sure how logitech limits the max. connection count on their hardware.
i personally would prefer the "many modules, one client instance" approach for getting started. you could easy switch to isolated clients this way if needed sometime in future.
make sure you have a look at orchestra-jsapi. it builds upon harmonhubjs-client and harmonhubjs-discover and abstracts away some low-level stuff for you.
this may make things more easy for you if you're not that experienced with nodejs yet.
happy hacking & let me know how things work out :)


vue-select async search

Hi,
I see that you are extending the plugin vue-multiselect on the component vue-select. I wonder if that component is making use of the async search? or should I use it directly from multiselect component?

Hi,
Please be more explicit.

What I need to do is to load the dropdown menu with data asynchronously, instead of loading the whole collection at once. Every search will perform a query.

VueSelect is a wrapper for vue-multiselect that adds among other features what you are looking for.
You can use vue-multiselect w/o using the wrapper and make a simple implementation for the async fetch yourself. Find more details here https://vue-multiselect.js.org/#sub-asynchronous-select

Yes!
I have been thru vue-multiselect already, but I was wondering if your wrapper was supporting w/o
Thanks for ur feedback 👍


how to support chinese

if the data value is chinese, now the package does not support。

Additional information is required, perhaps an example?

基金交易业务申请表-new.pdf

基金交易业务申请表-new.pdf


Errors in set_value internals reference identifier that does not exist in scope

https://github.com/jamalex/notion-py/blob/master/notion/collection.py#L372
throws
  File "/home/adjective/.local/share/virtualenvs/notion-strip-7FiIVxN3/src/notion/notion/collection.py", line 373, in set_property
    path, val = self._convert_python_to_notion(val, prop)
  File "/home/adjective/.local/share/virtualenvs/notion-strip-7FiIVxN3/src/notion/notion/collection.py", line 392, in _convert_python_to_notion
    .format(val, identifier, valid_options))
NameError: name 'identifier' is not defined

Fixed in https://github.com/jamalex/notion-py/pull/22, which will soon be released in 0.0.21

Version 0.0.21 has now been released to PyPI! Please give it a try and see how it works for you. Thanks for reporting issues!


#745 fix '0' printing in slides

fix #745 issue

Thanks for the contribution @roman1bondarenko
However, i'm leaving text as a string type only as that's been the design for a while and matches TableCell text property type as well.


Notifications, subscriptions and feeds

See https://github.com/ontola/atomic-data-docs/issues/28 for spec discussion.
WebHooks
One potential solution for dealing with notifications is to add WebHook support.

Send notifications to chat apps like Discord / Slack

There is https://www.standardwebhooks.com/ which could be used as a standard. Not sure if this means these webhooks can instantly be used in Chat apps.
Naive implementation idea

A collection has a webhooks property. Each item in that array represents a webhook URL.
When an items is added or removed from that array, we send a request to each of these webhooks

A use case @Polleps mentioned : rebuild a website when content is updated by calling a webhook on a platform like netlify


CI Failing

CI is currently failing. There are two known issues

The CLA bot checking isn't working. Work on this is in progress with the CNCF
e2e tests are failing. I think the PR at https://github.com/kubernetes/test-infra/pull/8749 will fix it

We're shooting to fix these in short order. Sorry for the CI issues we've been having lately.

This has been fixed so closing.


Fix aspect ratio of slides

Slide ratio dynamically changes based on browser size -- this unexpectedly is cutting out contents. We should have it fixed or use like min-width and min-height.

Aspect ratio should be 16:9 for fixed.


cmd/cue: select best quoting mechanism when importing

Imagine the yaml below:
cmds:
  - printf "%s" $FOO

This will end up something like "printf \"%s\" $FOO". It would be nicer if it instead avoided the backslashes, like #"printf "%s" $FOO"#.
Perhaps it could do the same for multi-line strings and other common scenarios. This isn't about saving bytes, but about readability.
/cc @rogpeppe

A general "pretty quoter" is somewhat non-trivial, which is why I haven't done it yet.
But I agree this would be better.

This issue has been migrated to https://github.com/cue-lang/cue/issues/124.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


All Resolver's methods should receive instance of StorIO

At the moment, users have to make some hacks to make it work…

+1


readthedocs doesn't trigger automatically anymore

Describe the bug
Webhooks are failing: https://readthedocs.org/dashboard/speechbrain/integrations/149555/
Expected behaviour
The webhooks should be set up from scratch again. See https://blog.readthedocs.com/security-update-on-incoming-webhooks/
This needs admin access on the GH side to manage webhooks so I can't do it.
To Reproduce
No response
Environment Details
No response
Relevant Log Output
No response
Additional Context
No response

Potentially fixed, will see on next push to develop

I see some webhooks passing without HTTP authorization errors anymore. FWIW I had to recreate the integration entirely.
That being said, builds themselves might still be failing to update due to #2614, but the webhook integration should be ok, so this issue is closed.


Container Apps 2022-01-01-preview and 2022-03-01 managedEnvironmentId is returned with incorrect casing

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json#L489
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L491
Returns the Container App's Managed Environment ID with the Microsoft.App/managedEnvironments segment incorrectly cased as Microsoft.App/managedenvironments.

This was fixed in the RP and the correct casing is used now.


Migrate web demo to more recent tooling

When we create the first version of demos based on vuejs (https://github.com/eclipse-leshan/leshan/pull/977),  the recommended version to use was :

vuetify 2 (only stable one available, only compatible with vue 2)
vue 2
vue-cli (default scafolding tooling for vuetify 2)
yarn classic (to be easily used with maven-frontend-plugin)

One day, we should migrate to more recent version of this :

vuetify 3 (compatible with vue 3)
vue 3
vite which replace vue-cli
yarn modern (v3 or v4)

Looking quickly at documentation this will not be straightforward migration.
Hoping this could improve build performance issue. (see : https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3429#note_1199991)

From
To
Issue

:construction:
vue-cli
Vite
https://github.com/eclipse-leshan/leshan/issues/1540

☐
yarn-classic
Yarn 4

☐
Vue 2 Vuetify 2
Vue 3  Vuetify 3

Maybe this could also have impact on : https://github.com/eclipse-leshan/leshan/issues/1016

About migrating from vue-cli to vite:

https://vueschool.io/articles/vuejs-tutorials/how-to-migrate-from-vue-cli-to-vite/
https://kingyue737.github.io/vitify-docs/guide/migration.html (vuetify 2)
https://blog.boot.dev/javascript/migrating-vue-webpack-to-vitejs/
https://moiva.io/blog/the-missing-migration-guide-from-vue-cli-to-vite/

Trying to move from vue-cli to vite and didn't succeed for now.
Also disover that Vue 2 will reach End of Life (EOL) on December 31st, 2023.
And I didn't really get what is HeroDevs’ NES (Never-Ending Support) for Vue 2.
Note that vuetify 2 is only compatible with vue2 and vuetify 3 is only compatible with vue3 (so both should be migrate together)
vite should works with both.

I created dedicated issue about migrating from vue-cli to vite  : https://github.com/eclipse-leshan/leshan/issues/1540

I create dedicated issue about migration from yarn-classic to yarn stable (4) : https://github.com/eclipse-leshan/leshan/issues/1550

I created dedicated issue about migrating from vue2 to  vue3 : https://github.com/eclipse-leshan/leshan/issues/1665

This is done. (even if there is maybe more polish work about : https://github.com/eclipse-leshan/leshan/issues/1665#issuecomment-2536097358)


Notebook Jobs UI does not render

Issue Type: Bug
When I click the "New Notebook Job" button, the form is empty with two buttons at the bottom. Those two buttons are Ok and Cancel.
Extension version: 0.49.0
Azure Data Studio version: azuredatastudio 1.39.1 (7553f799e175f471b7590302dd65c997b838b29b, 2022-08-30T01:11:13.047Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.60GB (2.62GB free)

Process Argv

Screen Reader
no

VM
0%

![Screenshot 2022-10-12 144321](https://user-images.githubusercontent.com/26484126/195423001-a544a6d2-8f48-43f1-a3c6-9e6351b901f7.png)

I downloaded an older version .37, and it works fine there. Meaning some recent changes broke this functionality.

@sqlworldwide the issue has been fixed now, the fix will be included in the December release.

Thank you


homebrew suggests running an upgrade command that doesn't upgrade

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
Upgrade from a previously installed version of qri (0.7.3) to the latest (0.9.6)
What happened (include command output)

Command output

$ brew install qri-io/qri/qri
Updating Homebrew...
==> Auto-updated Homebrew!
Updated Homebrew from 30c4383e8 to 776e8fd37.
No changes to formulae.
==> Installing qri from qri-io/qri
Error: qri 0.7.3 is already installed
To upgrade to 0.9.6, run brew upgrade qri.
$ brew upgrade qri
Warning: qri 0.7.3 already installed

What you expected to happen
homebrew suggests running brew upgrade qri but then only prints a warning that 0.7.3 is already installed
Step-by-step reproduction instructions (by running brew commands)
brew install https://raw.githubusercontent.com/qri-io/homebrew-qri/78d8e7b67dee8b159c7fbef9956db6d25f573d34/qri.rb

brew upgrade qri

Output of brew config and brew doctor commands

HOMEBREW_VERSION: 2.2.10-20-g776e8fd
ORIGIN: https://github.com/Homebrew/brew
HEAD: 776e8fd37378b63e31799e4c693f85c626215b4d
Last commit: 7 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: cae58c2e8f4652b2520d17f11ef66fe11c522984
Core tap last commit: 71 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GITHUB_API_TOKEN: set
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
Clang: 11.0 build 1100
Git: 2.25.1 => /usr/local/bin/git
Curl: 7.64.1 => /usr/bin/curl
Java: 9.0.1, 1.8.0_172
macOS: 10.15.4-x86_64
CLT: <IP_ADDRESS>
Xcode: N/A

I still cannot reproduce this using your instructions (including with my own additions).

brew install https://raw.githubusercontent.com/qri-io/homebrew-qri/78d8e7b67dee8b159c7fbef9956db6d25f573d34/qri.rb

==> Consider using `brew extract qri ...`!
This will extract your desired qri version to a stable tap instead of
installing from an unstable URL!

######################################################################## 100.0%
==> Downloading https://github.com/qri-io/qri/releases/download/v0.7.3/qri_darwi
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws
######################################################################## 100.0%
🍺  /usr/local/Cellar/qri/0.7.3: 3 files, 46.2MB, built in 13 seconds

This presents a "Consider using" warning that could be more strongly worded, I'll admit. Improved in https://github.com/Homebrew/brew/pull/7155

brew upgrade qri

Warning: qri 0.7.3 already installed

This is expected because you've installed from a URL.
If I run brew tap qri-io/qri and then brew upgrade qri:
==> Upgrading 1 outdated package:
qri-io/qri/qri 0.7.3 -> 0.9.6
==> Upgrading qri-io/qri/qri 0.7.3 -> 0.9.6
==> Downloading https://github.com/qri-io/qri/releases/download/v0.9.6/qri_darwi
Already downloaded: /Users/mike/Library/Caches/Homebrew/downloads/b5544cf49efb4ae05c8898372437b6654ecb812ce6210970f3b9bdbec97d8aa2--qri_darwin_amd64.zip
🍺  /usr/local/Cellar/qri/0.9.6: 4 files, 61.3MB, built in 4 seconds
Removing: /usr/local/Cellar/qri/0.7.3... (3 files, 46.2MB)
Removing: /Users/mike/Library/Caches/Homebrew/qri--0.7.3.zip... (22.5MB)
==> Checking for dependents of upgraded formulae...
==> No dependents found!

This upgrades as expected.

Output of brew config and brew doctor commands

What did/does brew doctor output?
Was this how you originally installed qri? Can you still reproduce the originally issue somehow on your machine?

I had not originally installed 0.7.3 from a commit, when I originally installed it last year, it was with brew install qri-io/qri/qri, but i couldn't find any other way to be able to install the older version to make this reproducible.
I didn't originally report it because I knew it would be difficult to reproduce.
Brew doctor said everything was fine: Your system is ready to brew.
Weird thing I get when listing brew info qri now:
$ brew info qri
qri: stable 0.7.3
Global dataset version control system built on the distributed web
https://qri.io/
/usr/local/Cellar/qri/0.7.3 (3 files, 46.2MB) *
  Built from source on 2020-03-11 at 12:03:55
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/qri.rb

Same result after uninstalling qri 0.7.3 and attempting again:
$ brew uninstall qri
Uninstalling /usr/local/Cellar/qri/0.7.3... (3 files, 46.2MB)
$ brew cleanup
Warning: Skipping composer: most recent version 1.10.0 not installed
Warning: Skipping python: most recent version 3.7.7 not installed
$ brew install https://raw.githubusercontent.com/qri-io/homebrew-qri/78d8e7b67dee8b159c7fbef9956db6d25f573d34/qri.rb
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
==> Updated Casks
cocktail                                 zoho-mail

==> Consider using `brew extract qri ...`!
This will extract your desired qri version to a stable tap instead of
installing from an unstable URL!

######################################################################## 100.0%
==> Downloading https://github.com/qri-io/qri/releases/download/v0.7.3/qri_darwi
Already downloaded: /Users/andrewnesbitt/Library/Caches/Homebrew/downloads/52a5bba0e9445f7e49161290817b26b5d1d868fc737c27d11fee26f0268e7013--qri_darwin_386.zip
🍺  /usr/local/Cellar/qri/0.7.3: 3 files, 46.2MB, built in 4 seconds
$ brew tap qri-io/qri
$ brew upgrade qri
Warning: qri 0.7.3 already installed

@andrew Can I see the output of cat /usr/local/Cellar/qri/*/INSTALL_RECEIPT.json and brew tap-info --installed? Thanks!

And also: find /usr/local/Homebrew/Library/Taps -name qri.rb

$ cat /usr/local/Cellar/qri/*/INSTALL_RECEIPT.json
cat: /usr/local/Cellar/qri/*/INSTALL_RECEIPT.json: No such file or directory

$ brew tap-info --installed
brewsci/science: unpinned, 414 formulae
/usr/local/Homebrew/Library/Taps/brewsci/homebrew-science (469 files, 1.3MB)
From: https://github.com/brewsci/homebrew-science

homebrew/bundle: unpinned, 1 command
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle (453 files, 651.8KB)
From: https://github.com/Homebrew/homebrew-bundle

homebrew/cask: unpinned, 1 command, 3494 casks
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask (3,764 files, 92.7MB)
From: https://github.com/Homebrew/homebrew-cask

homebrew/cask-versions: unpinned, 156 casks
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask-versions (1,992 files, 60.9MB)
From: https://github.com/Homebrew/homebrew-cask-versions

homebrew/core: unpinned, 2 commands, 4928 formulae
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core (5,660 files, 104.5MB)
From: https://github.com/Homebrew/homebrew-core

homebrew/services: unpinned, 1 command
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-services (267 files, 296.2KB)
From: https://github.com/Homebrew/homebrew-services

qri-io/qri: unpinned, 1 formula
/usr/local/Homebrew/Library/Taps/qri-io/homebrew-qri (28 files, 28.8KB)
From: https://github.com/qri-io/homebrew-qri

$ find /usr/local/Homebrew/Library/Taps -name qri.rb
/usr/local/Homebrew/Library/Taps/qri-io/homebrew-qri/qri.rb
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/qri.rb

/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/qri.rb

This is your problem. That's a file you've created somehow in homebrew/homebrew-core which confuses things because it's what you installed from (and brew upgrade won't try to upgrade you from a homebrew-core package to a random one in a tap for security reasons).

Ah, I guess that must be left over from when I helped qri write their tap last year, it doesn't show up as an untracked file in git for the homebrew directory (looks like its .gitignored).
I wonder if there's a way brew doctor can help diagnose that?
Still very confusing that brew told me to upgrade but they wouldn't actually do the upgrade though.

Still very confusing that brew told me to upgrade but they wouldn't actually do the upgrade though.

Tweaking the messaging in https://github.com/Homebrew/brew/pull/7159

I wonder if there's a way brew doctor can help diagnose that?

Good idea, done in https://github.com/Homebrew/brew/pull/7160


[HOLD for payment 2023-07-05] [$1000] FEATURE REQUEST: Increase the size of composer a bit bigger and easier to tap

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
The size of the composer is smaller than standard button size
Solution:
Increase the size of our composer just slightly so that the send button becomes 40px tall, which is a standard button size and is a bit bigger and easier to tap
Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678380227758669
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0114ab49b58fd19b29
Upwork Job ID:<PHONE_NUMBER>749805056
Last Price Increase: 2023-06-15

This issue has not been updated in over 15 days.  eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

I feel like we still want to do this. Do you agree @JmillsExpensify @trjExpensify ? I think I'll slap External on it so we can get this through the process.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Increase the size of composer a bit bigger and easier to tap
What is the root cause of that problem?
componentSizeNormal variable value is set to 40px
What changes do you think we should make in order to solve the problem?

componentSizeNormal variable value is set to 40px so for composer we can redefine a new variable with value 48px and use it to style composer
Furthermore, we will proceed with implementing the required modifications to the styles.js file, specifically for components such as chatItemSubmitButton and chatItemEmojiButton.
Additionally, if necessary, we can also consider adjusting the width and height of the emoji button to enhance its usability
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
<!---
ATTN: Contributor+

You are the first line of defense in making sure every proposal has a clear and easily understood problem with a "root cause". Do not approve any proposals that lack a satisfying explanation to the first two prompts. It is CRITICALLY important that we understand the root cause at a minimum even if the solution doesn't directly address it. When we avoid this step we can end up solving the wrong problems entirely or just writing hacks and workarounds.

Instructions for how to review a proposal:

1. Address each contributor proposal one at a time and address each part of the question one at a time e.g. if a solution looks acceptable, but the stated problem is not clear then you should provide feedback and make suggestions to improve each prompt before moving on to the next. Avoid responding to all sections of a proposal at once. Move from one question to the next each time asking the contributor to "Please update your original proposal and tag me again when it's ready for review".

2. Limit excessive conversation and moderate issues to keep them on track. If someone is doing any of the following things please kindly and humbly course-correct them:

- Posting PRs.
- Posting large multi-line diffs (this is basically a PR).
- Skipping any of the required questions.
- Not using the proposal template at all.
- Suggesting that an existing issue is related to the current issue before a problem or root cause has been established.

Yeah, nice! Much easier to smash that send button!

Not overdue, @daraksha-dk was just assigned.

Awesome, thanks @daraksha-dk

bump @sobitneupane and @MariaHCD on reviewing the PR, any updates here?

I see this is labeled "not a priority" should we make this weekly not daily?

I am heading OOO shortly, so assigning another bug0 team member to help watch over this issue whilst I am OOO! Thanks!

Tested quickly and I think this feels pretty good to me.

I am unassigning myself because I'm going OOO until July 5. @zanyrenney is the original assignee, so I will leave her assigned to the issue.

I was assigned this bug . Were we changing the size of the FAB button in this issue to be 32x40?
I see in the tests for the PR here that this is the expected size, but curious if we meant to change that in this issue.

I don't think that's a bug, I think it's fine as-is.

Cool cool, ty!

@sobitneupane and @daraksha-dk I have invited you to the job on upwork. there is no reporting bonus here as this was reported internally.
Please accept the job for payouts.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

This is a feature request not a bug. So, I don't think BugZero Checklist applies here.

Requested money on Expensify.

Brilliant thank you @sobitneupane - I'll view your payment as complete then!

@daraksha-dk can you confirm if you'll be doing the same, and requesting money on Expensify instead?

@zanyrenney @daraksha-dk It is only being used (internally) by few Contributor+ now. More context: https://expensify.slack.com/archives/C02NK2DQWUX/p1686871517189609

hey @daraksha-dk offer sent, please accept.
no bonus due

Paid @daraksha-dk
@sobitneupane will be managing payment through Expensify.
there is no reporting bonus as it was an internal report.
Good to close here!


Submission Service - include Exceptions from TAN verification in DeferredResult (closes #417)

Checklist

[x] Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
[x] Make sure mvn install runs for the whole project and, if you touched any code in the respective service, submission and distribution service can be run with spring-boot:run

Description
This PR makes sure to handle exceptions thrown by all code executed in the ForkJoinPool's Runnable task by handing them to the DeferredResult. As a result, the offending Exception will be logged, rather than a generic AsyncRequestTimeoutException as was reported in the linked issue.
Now, for example, an unhandeled Exception occurring from contacting the verification service will not be swallowed, but rather included in the log for easier error tracing.

@MKusber please review the implications of this PR - I attached a sample Exception trace above that would result in case of a failure to contact verification service. Note that no TAN is logged, but rather we get much more information about the cause of the failed call to submission service, rather than the error being swallowed (as shown in the linked ticket) which I think would be beneficial for error tracing purposes.


onScroll animation with useNativeDriver on iOS doesn't work after re-render

Repro: https://snack.expo.io/SkkqUA4KG
Possibly same as: #12543
The conditions to reproduce seem to be:

You have a ScrollView and are using an Animated.event onScroll
You are on iOS with useNativeDriver: true
A parent of a Animated.View that uses the animated contentOffset value re-renders (in this case, resulting in the child being unmounted and mounted again)

Expected result is that the Animated.View always animates based on the Animated.Value which is linked to the scroll position.
Actual result is that the scroll-linked animation works initially, but after the component that uses the animated value is destroyed and recreated, it doesn't work.  This only happens with the native driver.  It also doesn't happen if the same animated value is used continuously elsewhere (see comment in repro), so that could be a potential clue and workaround.
Environment
Environment:
  OS: macOS High Sierra 10.13.3
  Node: 9.6.1
  Yarn: 1.5.1
  npm: 5.6.0
  Watchman: Not Found
  Xcode: Xcode 9.1 Build version 9B55
  Android Studio: Not Found

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: https://github.com/expo/react-native/archive/sdk-25.0.0.tar.gz => 0.52.0

Are there known gotchas about sharing Animated.Values between components?  If component A gives Animated.Value X to component B, and then B goes away and A gives X to C, is there some kind of teardown that happened, and now X is "dead"?

So far, I've learned that if you are in the buggy state, where onScroll isn't animating, anything that causes _detachNativeEvents() and _attachNativeEvents() to be called on the ScrollView will give it the "kick" it needs to start working again, including calling forceUpdate() on the ScrollView, a re-render of the parent, etc.

@dgreensp Could you share some code snippets to workaround this issue? Thanks

Sure, glad to.  While it seemed to work at first to assign the AnimatedValue in question (the global variable SCROLL in the repro) to any old prop on a component (the ScrollView being a convenient component to slap it on, because then the workaround can live inside my scrolling component), when I tried applying this workaround in my actual app, I got an invariant exception saying an animation node didn't have a native tag.  For some reason, driving a component's props but not style with a native driver caused the problem.
Here's the workaround I ended up with, using the repro as context for this snippet:
export default class App extends Component {
  onScroll = Animated.event(
    [{ nativeEvent: { contentOffset: { y: SCROLL } } }],
    {useNativeDriver: true}
  );

  render() {
    return <View style={{flex: 1}}>
      <Animated.ScrollView
        style={{
          flex: 1,
          opacity: Animated.add(1, Animated.multiply(0, SCROLL))
        }}
        scrollEventThrottle={1}
        onScroll={this.onScroll}
        >

Basically, you make opacity or transform depend on whatever AnimatedValues you want to protect from being detached.

We actually use const AnimatedFlatList = Animated.createAnimatedComponent(FlatList) and attach onScroll prop with
          onScroll={Animated.event(
             [{ nativeEvent: { contentOffset: { y: this.state.scrollY } } }],
             {
               useNativeDriver: true,
               isInteraction: false
             }
           )}

so it will do the trick if set an opacity style like you do, right?
        style={{
          flex: 1,
          // this line is the workaround:
          opacity: Animated.add(1, Animated.multiply(0, this.state.scrollY))
        }}

Yup, give it a shot
On Tue, Mar 13, 2018 at 6:25 PM fxwan<EMAIL_ADDRESS>wrote:

We actually use const AnimatedFlatList =
Animated.createAnimatedComponent(FlatList) and attach onScroll prop with
      onScroll={Animated.event(
         [{ nativeEvent: { contentOffset: { y: this.state.scrollY } } }],
         {
           useNativeDriver: true,
           isInteraction: false
         }
       )}

so it will do the trick if set an opacity style like you do, right?
    style={{
      flex: 1,
      // this line is the workaround:
      opacity: Animated.add(1, Animated.multiply(0, this.state.scrollY))
    }}

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/18347#issuecomment-372873278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJgpoGpfVgmTHFLnW837otuY1Aj84JMks5teHFngaJpZM4SoFgn
.

I was able to reproduce this issue with RN 0.55.4 on Android

I ran into something similar which I think is the same root cause. In my case, my Animated.Values tracking scroll position are used by some other views which can be created, mounted & unmounted many times in the life time of the scroll view. After the first unmount, __detach is called on the scroll Animated.Values and they don't work properly after that (the JS value is out of sync with the native value, and change events no longer get through).
I can work around this by calling __addChild on the scroll Animated.Values (and __removeChild when my scroll view unmounts). The proposed workaround is essentially doing the same thing.
I think that a reasonable fix would be for Animated.event to become a child of the values it populates while it's attached to an event emitter. I don't think this would introduce cycles into the Animated.Value graph, but I'm not sure...


Fix the example error message for retryable transactions.

Addresses the docs part of #646.

This change is

. Thanks, @knz.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Add support for starting catchup subscriptions in the background when using @Subscription annotation

For example, if you have many events or a subscription whose processing is very slow:
@Subscription(id = "LogWhenGuessTooSmall",startAt = BEGINNING_OF_TIME)
void logWhenGuessTooSmall(PlayerGuessedANumberThatWasTooSmall e) {
    log.info("Player {} guessed a too small number in game {}", e.playerId(), e.gameId());
    try {
        Thread.sleep(1000);
    } catch (InterruptedException ex) {
        throw new RuntimeException(ex);
    }
}

then the Spring application won't start until all events have been consumed. This is not good! Instead, start the subscription in another (virtual?) thread. Should this be configurable in the annotation?

Maybe by setting a startUpMode = BACKGROUND or startUpMode = FOREGROUND. If the latter, call waitUntilStarted on the subscription

The problem is that the CatchupSubscriptionModel always does "catch-up" when calling subscribe. Instead it should start in the background, and only "synchronize" if waitUntilStarted is called.


feat: onboarding p7

:tada: This PR is included in version 1.39.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


implement Rust client

goals (open to discussion):

enable easier testing and invocations from Rust

non-goals:

reinvent all of the options of sending a mesasge (i.e. send_delayed, send_from_reservation, send_bytes_with_gas)

The thing is that I'm re-building the entire server side code generation which means this client will require re-implementation. As we discussed it has to be built using idl which remains unchanged even I after I reimplement the way server side is generated

changes will be ported to another PR


A typo in README

There is a typo in README.md:

print log messages with timstamp, file name, method name, line number, path or call stack

Fixed. Thank you for reading.


Update H3 header

@NextTurn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update.
@NextTurn Thanks for submitting this fix.


Fix createTestNetwork bug

fix issue: https://github.com/docker/libnetwork/issues/181
Signed-off-by: Bao Yonglei<EMAIL_ADDRESS>

LGTM
But I see Pull #212 is also resolving this as part of a bigger change.
Since you brought up this issue time ago, if @mrjana is ok in rebasing his change, he can decide to merge yours first.
Thanks for your contribution.

LGTM. I will merge this first and will rebase #212 on top of this.

Little question,  I find that  I am not in the contributors list after committed the code, can anyone tell me why?


How can we display two widget at the same time?

How can we display two widgets at the same time? right now if I try to do so it will blurred first image. any suggestions?

Hey, did anyone find a way to display multiple coach-marks at once?


Unable to copy my file to the host

when I use the following command to copy my file to the host server, I got some "UndeclaredException".
D:\tools\pai-fs>python pai-fs.py -cp -r d:\code\GameAI hdfs://code/ruyang
d:/code/GameAI/.gitignore -> code/ruyang/GameAI/.gitignore

Progress: Traceback (most recent call last):
File "D:\tools\pai-fs\fsimpl\HadoopFs.py", line 232, in touch_file
self.hdfs.create_file(fd.abspath, 0, overwrite=True)
File "C:\Users\v-ruyang\AppData\Local\Continuum\anaconda3\lib\site-packages\pywebhdfs\webhdfs.py", line 106, in create_file
init_response.status_code, init_response.content)
File "C:\Users\v-ruyang\AppData\Local\Continuum\anaconda3\lib\site-packages\pywebhdfs\webhdfs.py", line 722, in _raise_pywebhdfs_exception
raise errors.PyWebHdfsException(msg=message)
pywebhdfs.errors.PyWebHdfsException: b'{"RemoteException":{"exception":"UndeclaredThrowableException","javaClassName":"java.lang.reflect.UndeclaredThrowableException","message":null}}'

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "pai-fs.py", line 447, in
exitCode=cp_command(cmdLineArgs.myArgs, cmdLineArgs.recursive, cmdLineArgs.force)
File "pai-fs.py", line 243, in cp_command
srcFileSystem.cp_file(currentFile, dstRootFileDescriptor, dstFileSystem, force)
File "D:\tools\pai-fs\fsimpl\BaseFs.py", line 284, in cp_file
self.remote_cp_file(src, dst, dstFs)
File "D:\tools\pai-fs\fsimpl\BaseFs.py", line 208, in remote_cp_file
dstFs.touch_file(dst)
File "D:\tools\pai-fs\fsimpl\HadoopFs.py", line 241, in touch_file
raise Errors.FsException("An exception happened during HDFS create file: {0}, exc={1}".format(fd.abspath, e))
fsimpl.Errors.FsException: An exception happened during HDFS create file: code/ruyang/GameAI/.gitignore, exc=b'{"RemoteException":{"exception":"UndeclaredThrowableException","javaClassName":"java.lang.reflect.UndeclaredThrowableException","message":null}}'
I've created the parent directory and it's empty.
Or Is there anyone that I should send email to?

Hi @RchalYang , have you configured pai-fs using pai-fs --config host=ip port=50070 user=... before as mentioned in readme?

@abuccts We've fixed this problem. There is something wrong with the WebHDFS deployment. Thanks for replying.


Github Dark in Light Logo

Github Dark in Light Logo

Thanks @Paptoos - do you have a link to the logo?

https://github.com/logos
download mark from this link
then go to png folder and see GitHub-Mark-Light-120px-plus.png
If it is hard , I upload it to a cloud storage
https://mega.nz/file/n4tFWC5K#Ogzh_Zoo34OrCmbu-sQrKSMOsI0wPie_i0v5tF9oWLA


Include JS/TS Tooling Configuration in Extension

Issue https://github.com/Shopify/shopify-cli-extensions/issues/246

[x] Copy existing configuration files into our templates:

[x] .eslintrc.js.tpl
[x] .prettierrc.tpl
[x] .vscode/extensions.json.tpl
[x] .vscode/settings.json.tpl

[x] Update package JSON to have all necessary development dependencies

Based off of https://github.com/Shopify/checkout-ui-extensions-template
delta of tmp/

This approach is error-prone: Superceded by https://github.com/Shopify/shopify-cli-extensions/pull/261

Superseded by https://github.com/Shopify/shopify-cli-extensions/pull/276


Carthage support

It would be great if I could just add github "mxcl/PromiseKit" ~> 1.2.2 to my Cartfile and directly get going with PromiseKit.
Possibly the only thing needed is to share our xcode schemes.

Carthage will only build Xcode schemes that are shared from your .xcodeproj. You can see if all of your intended schemes build successfully by running carthage build --no-skip-current, then checking the Carthage/Build folder.

If an important scheme is not built when you run that command, open Xcode and make sure that the scheme is marked as “Shared,” so Carthage can discover it.

I don't know how it will handle the objc and swift folders thought...
Thanks!

Yes, I've been pondering Carthage support for a couple weeks. I think I can get it working, this ticket will motivate me.

Nice! I could really use it. You know you been doing too much Node.js programming when your swift code looks like this: :laughing:
typealias Callback = (NSError?, AnyObject?) -> Void

func send(method: NSString, params: NSDictionary?, cb: Callback) {
    ...
}

Carthage can now import the Swift version of PromiseKit.

Nice! Thank you so much for the quick update :+1:


Update Chris Profile

Docs Build status updates of commit 142f792:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/christopher-maneu.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a17a9e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/christopher-maneu.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[🚀esl-core]: extend ESLEventListener api to have more control over auto-behaviour

As a ESL consumer, I want to be able control phases to auto subscribe/unsubscribe events
Proposal:
  auto?: boolean | 'all' | 'bind' | 'unbind';

Originally posted by @ala-n in https://github.com/exadel-inc/esl/pull/878#discussion_r830993170

Closed as non-actual for now


[Bug] Item Recharge Formula not sticking.

With all modules off and using Foundry v11.306 and DnD5e 2.2.2, items with charges won't keep the recharge formula on the item sheet. I type it in, close the sheet, have the character take a long rest, and the item recharges. But then, the recharge formula disappears and it won't recharge any more with long rests, unless I input the formula again. This is with both new, fresh items and items that have been in my world for some time. Also created a new test world, and saw same behavior.

Duplicate of #2362


Problem with DownLoad OSM Data (XAPI)

Hello,
As I already noted for version 10.2 of the toolbox, this tool still doesn't works.
So I tested the script by modifying, replacing the variables by constants and testing every step of the program.
It seems that the problem comes from the interpretation of variables that the different functions are unable to recover the form of strings. So I forced this conversion by adding the str () function each time for :
in_xapi_url = str(arcpy.GetParameterAsText(0))
request_extent = str(arcpy.GetParameterAsText(1))
request_type = str(arcpy.GetParameterAsText(2))
request_predicate = str(arcpy.GetParameterAsText(3))
It seems that it works.
I made a pdf document to explain my approach (in French but I think that's understandable with screenshots). How can I send it?

hi, please feel free to fork the code, apply the fix you describe and submit a pull request!

I've just submit a pull request.

Hello,
I have a problem with the script XAPI.
When I want to import the roads relations ("type = associatedStreet"), the relations table is filled well but the associated objects aren't downloaded. Is there a way to proceed to recover the relations and related objects in the same time ?

Good question Tony - when you say "associated objects", do you mean other objects that are outside the extent of the download area but have a relationship to the streets within the download area? If that's correct, then the answer is 'no'; the existing tools do not have a mechanism for getting the related associated objects, only the data that is in the extent requested from the XAPI endpoint.
Also on a different note - thanks for submitting the pull request! Will you change the request to pull to our 'dev' branch instead of master? Then we can test before pushing to master. The dev version of the 'download_using_xapi.py' file is the same as master, so you shouldn't have to reconcile any differences in the code.

No, I mean data belonging to the relation within the extent of the download. In fact, only the table "relation" fills. The data set of associated features remains empty.
How can I change the request to pull to our 'dev' branch instead of master?


PHP docs reference wrong function or wrong class

Much of what the template asked for was N/A.
There's the following doc section for WorkerInterface::registerActivity():
https://github.com/temporalio/sdk-php/blob/d28e626710c07f5d5c3c3656a0a72308f89c8053/src/Worker/WorkerInterface.php#L70-L74
Let me bring your attention to line 74 which instructs the developer to use a callback function that accepts a ReflectionClass instance, and to call getClass() on the concrete object inside the callback. Where is getClass() coming from? The primitive PHP ReflectionClass doesn't have this method. Was $class->getName() the intended method, if one should be passing the fully qualified name of the class?
I searched the codebase to rule out whether the instance of ReflectionClass being passed is actually a child class that implements getClass() but couldn't find such implementation, and if I missed it, then perhaps the docs should suggest using the child class instead of ReflectionClass to avoid any issues with the IDE which currently complains that getClass() doesn't exist.
Additional context
>>> $r = new \ReflectionClass(\App\User::class)
>>> $r->getClass()
PHP Error:  Call to undefined method ReflectionClass::getClass() in Psy Shell code on line 1
>>> $r->getName()
=> "App\User"

Hi @the-invisible-man! Yes, you are absolutely right 👍 I have created a PR with a fix for - https://github.com/temporalio/sdk-php/pull/159

Thanks for the prompt fix @seregazhuk!

Also, created a fix for official documentation - https://github.com/temporalio/documentation/pull/1055


Create Spurious symptoms as objects

This is part 1 of 2 of the new and tested spurious symptoms/ covid testing PR.
Note that the open pull requests 26 and 27 have been included here, hence the massive number of commits included in this.
This pull request introduces the spurious symptom framework as an object which is created for each person at a given rate. Once created this object will show an "exposed" behaviour node for a week and then revert to a "susceptible" behaviour node. From this point, existing nodes can remain dormant (susceptible) or flare up again.
There is now also a spurious symptom testing suit which is now working.
I should have stopped at just creating these spurious symptoms but i have gone on a bit to include covid testing. The covid testing files are probably subject to change and not worth spending to much time on for now.

To help with review:
Files that have had a small change:
Pom xml - just changed a build requirement that caused the maven build to fail for java 8
Demography - created and used a ticks per year parameter
Movement behaviour - changed an import
Location - changed an import
CoronavirusBehaviourFramework - changed a name of a variable
Infection - changed an import
Bulkrun - changed the simulation object to have an extra boolean
ImportExport - changed an import
Params: created new parameters (not imported)
Runmosttravelled: changed the simulation object to have an extra boolean
Singlerun: changed the simulation object to have an extra boolean
All testing files except Covid spurious symptom/testing tests: changed simulation object to handle an extra boolean
Files that need a review:
Person: created properties that determine who has symptoms and who should be tested. Also created corresponding getters and setters
CoronavirusSpuriousSymptom: creates the spurious symptom object class
InfectiousBehaviourFramework: attempted to create a way to generalise disease behaviour frameworks. I didn't manage to do this actually so probably best to discuss
SpuriousSymptomBehaviourFramework: creates the behaviours exhibited by the spurious symptom object
CovidSpuriousSymptoms: handles the steppable functions which control the creation and removal of symptoms
CovidTesting: handles the covid testing administration
DiseaseTesting: an interface for general disease testing, implementation didn't seem to be the best, would be good to discuss
Logging: created an output file for covid testing
SpuriousSymptoms: generalised interface for symptoms
WorldBankCovid19Sim: just changes things to handle spurious symptoms and testing
CovidSpuriousSymptomTesting: test suite for covid symptom objects
CovidTestingTesting: test suite for covid testing


Autosave not working

I installed auto-save to Sublime Text Build 3126 a few months back and it randomly stopped working.
"save_on_focus_lost" is set to true in user settings.

I think it's better to run your own plugin for this like mentioned in https://forum.sublimetext.com/t/auto-save-on-every-keypress/6055/13.

I'm using Sublime Text 3 Build 3126, and it works fine here.
Do you get any errors in the console?
Note that auto-saving on every keypress can make the editor quite slow. The nice thing about this auto-save package is that is registers all keypresses, but only saves once per predefined time interval.

@Avinash-Bhat Sorry I haven't been able to give this project the attention it deserves. It's been fairly stable with a few improvements made over the past year and half by community members @scholer so I wouldn't consider it abandoned :)
@tiffanyhaltom What errors do you see in the ST console?


do not provide structured streaming for kafka

Following the guide at:
https://spark.apache.org/docs/latest/structured-streaming-kafka-integration.html
When I add the spark-sql-kafka-0-10 as a component, it gets
automatically provided.
When I add the package as a depdendency, I get the error that "Please
add any Spark dependencies by supplying the sparkVersion and
sparkComponents."


Characters get cut off

What browser?
On Thu, Sep 8, 2016, 11:21 AM Saji Champlin<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-09-08 at 11 19 38]
https://cloud.githubusercontent.com/assets/9110284/18357350/4d0c8de6-75b6-11e6-9806-74bc69902359.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kincaidoneil/beartime-web/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGIxptv6q0ycsDI4TMgQ5sn2Ojp_brrYks5qoDXsgaJpZM4J4Ltp
.

Chrome Latest. Happens on Safari and Firefox as well.

Also this.

I should add this is a low priority bug, so we should only take it up when we're sure it is stable.

Could you give me some steps to reproduce?
I'm not experiencing it.

Fixed by 3977c951d083ecdbced2abbdd188124ea98a9ec8.


DS-182: Convert Blockquote to latest renderer

Jira
DS-182
Summary
Convert Bolt-Blockquote to the latest renderer.
Details
In an attempt to unify and improve components, I am updating Blockquote to use the latest web component renderer as well as updating, adding, and changing some other relevant concepts.

Note: Updating the mutation observer in the Blockquote component required a change to Slotify. When building the slotMap Slotify now checks to see if an element is already present in the array before adding it. Previously, it would add duplicates if re-run.

How to test

Open the blockquote portion of pattern-lab and compare with the origional.
Review code changes to confirm the conversion is a success.

@remydenton @cjwhitedev I had to comment out many tests.
We're running into a problem we've seen on other tests, once we upgrade to the new base class. The Promises that tell us the component is ready are not working inside Puppeteer. Since we cannot wait for the component to be ready, render, and return the HTML we want to snapshot, the HTML it returns is essentially the exact same HTML we feed into it. So, there's no point in having these tests. Note: these tests are not VRT - they are the snapshots of Web Components once they've booted up.
The testing helper renderWC was supposed to solve this problem for us but it is not working. It times out, never resolving the promise that tells us the component is ready.
I've spent a lot of time, now and in the recent months, debugging this and haven't solved the issue. For now, I'm just commenting out these tests.


Handling Stretch alignment in AlignmentDialogPopupPositioner

This is an attempt to fix issue #28

This breaks display of some dialogs. For example "Pass model" dialog in demo:

Thanks, it works for me now

Yep, seems like it works fine now. Thanks!


Run using Coral accelerator

Would it be possible to run this using a Coral Accelerator to offload the work from the CPU, or does the model include operations not supported by the Coral TPUs?

Unfortunately, the core audio embedding model of openWakeWord uses a [Leaky ReLU activation function which does not appear to be compatible with the Coral Accelerator based on this page.

@dscripka do you think there would be any advantage over using Coral? It seams it should be pretty easy to replace Leaky ReLU with Parameterized ReLU

It would depend on the type of deployment scenario. Currently the entire openWakeWord stack of models can run easily on a single core of a Raspberry Pi3. This is not as efficient as it could be, but I wouldn't consider this computationally intensive either.
If you have a workload that requires many simultaneous instances of openWakeWord, something like the Coral could be beneficial. However, a more powerful CPU or simple GPU is likely substantially more cost efficient and much easier to implement in practice.


Download specific game rather than search for name

Hello,
I'm trying to download a specific game, but when I run the following command:
lgogdownloader --game army_men --no-platform-detection --language en --no-subdirectories --exclude extras,patches,languagepacks --platform win --directory ~/Downloads/19980430.army.men
the application downloads all 5 of the titles whose names include the string "army_men" in them, rather than just the first title in the series. How can I specify just the first game for my download?
Thanks in advance.

It expects a regular expression.
I use this shell function instead of invoking lgogdownloader directly:
gogd () {
        local IFS=\|
        lgogdownloader --download --game "^($*)\$"
}

If I type gogd foo_bar baz, it runs lgogdownloader lgogdownloader --download --game "^(foo_bar|baz)\$".
In your case, the important thing is to use ^army_men$ rather than army_men. (The ^ matches the beginning of the string and the $ matches the end of the string, preventing it from performing a substring match on longer names.)

Worked perfectly. Thank you!


Allow user to set api gateway endpoint type

Fixes #121
Allow users in AWS regions where Edge optimized API gateway endpoints aren't supported to use this within the CDK workshop

Build is failing on attempted self-mutation to forked repo. I checked the "allow maintainers to adjust" box when submitting.
Anything I'm doing wrong with this?


chrome test workaround, fixed warnings for Rust 1.37

I haven't solved all issues with PR https://github.com/David-OConnor/seed/pull/199.

If you haven't done it yet, upgrade to Rust 1.37 (rustup update) because pattern ... is deprecated and Rust 1.37 has a better algorithm for resolving extra muts in code.

Problems with Chrome tests are because of incompatible chromedriver and Chrome. I'll write more details to related issue in wasm-pack repo.
I've written workaround to .travis.yml. If you want to run cargo make test_h chrome in your local PC, just download version compatible with your Chrome from https://chromedriver.chromium.org/downloads and move downloaded chromedriver into the folder that is registered in your PATH environment variable.

related issue in wasm-pack repo

https://github.com/rustwasm/wasm-pack/issues/611


setup-repos.sh: warn users before clearing the cache

setup-repos.sh will clean repo cache: line 64 # Setup OS dependent
Since some users may want to keep the downloaded packages from other repos in the dnf/yum cache, so if clearing the cache is necessary, it's better to warn the user before cleaning repo data.

@iliajie do we really need to clear the repo cache when setting up new repositories?

No, we don't need to do it.

I will remove this from setup-repos.sh then

Hold on, we still need to clean for Debian.


Ensure the work chooser block preserves selected page order

Follow up to #251
Description of Changes Made
Fixes an issue where the chosen work pages in the work chooser block would lose their order
How to Test
Add a work block with several pages. They should show in the chosen order
Screenshots

Expand to see more

MR Checklist

[x] Add a description of your pull request and instructions for the reviewer to verify your work.
[ ] If your pull request is for a specific ticket, link to it in the description.
[x] Stay on point and keep it small so the merge request can be easily reviewed.
[x] Tests and linting passes.

Unit tests

[x] Added
[ ] Not required

Documentation

[ ] Updated build docs
[ ] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[ ] Updated field spec (https://docs.google.com/spreadsheets/d/1v1yqcSC54Vag4mxmTp8e6ZrnxITqzbjCA4A9XPQdXk8/edit?usp=sharing)
[x] Not required

Browser testing

[ ] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[x] Not required

Data protection

[x] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[ ] Automated WCAG 2.1 tests pass
[ ] HTML validation passes
[ ] Manual WCAG 2.1 tests completed
[ ] I have tested in a screen reader
[ ] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[x] Not required

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[x] Not required

Pattern library

[ ] The pattern library component for this template displays correctly, and does not break parent templates
[ ] The styleguide is updated if relevant
[x] Changes are not relevant the pattern library

@zerolab although this all worked fine when I tested it locally, on staging it caused a 500 error - you can see it in sentry here: https://torchbox.sentry.io/issues/5359617913/?project=1221893&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=90d&stream_index=0

@helenb something, something, unpublished pages


Correct select dialog items' SelectedOptions type

According to https://api.slack.com/dialogs#select_default_values, this field can't be a string: it may hold an array with at most one value, giving an option that comes pre-selected on a select field with an "external" data source.
I tried sending just a value (as I would expect from the string type), but slack returns a validation error when you do that. Using this type (and a single element on it) does work.
This is an API change, but I don't expect that anyone using SelectOptions on that struct has seen it work. Insofar, it might be a "breaking" change in the sense of "fixing things incompatibly" (:
I didn't add a test, but can't quite tell if we test struct fields here. Let me know if you want one!

@asf-stripe Could you please fix dialog_test.go?

Whoops, sorry for missing these tests, @rizzza! Fixed now.

Whoops, sorry for missing these tests, @rizzza! Fixed now.

Hey thanks! I'm not a maintainer though... I hit this bug yesterday. 😉


setNext changes

As discussed on Slack, this adds a new event to signify successful completion of setNext calls.

Two small questions that I hope are not dumb.
1. What does it mean successful completion of setNext exactly?
If it means after loading the PlaybackInfo, same as when we do a load, then this new event on iOS might take a while, because we don't start to load the next item it until the current item is fully loaded. (Either fully downloaded because it is an offlined file, or fully cached by the player while streaming it)
If it means as soon as we internally set the self.nextItem property of PlayerEngine, then we should clarify what can cause the event to not be sent, right?
On iOS I see 3 possible conditions:

Player state is IDLE
setNext is called for the same MediaProduct we already have (I guess we could still send the event here..)
setNext is called with a nil MediaProduct

2. I consider this event an optional event for the consumers of our SDK. Do we need to clarify that in the spec or is that up to each platform?

My intent was that the meaning of successfully setting next refers to setting the property only. Also, regarding the conditions in which the event fails to be sent, I would think that for the last 2 bullet points you mention it is sent, leaving the IDLE case as the only condition where it does not get sent. I'd rather this not be specified in the documentation as it does not look to me like the value of the information it adds is worth having to update it if we change the internal implementation, but I can live with it.
What does this mean? Are there any events that are not optional for consumers to listen to?

I did not mean to specify it in the documentation, just that we synced on it. But that can be done through other channels.
Probably specific to iOS, but we have some events that are optional and others that are not. For those that are not optional, the Compiler will complain if the consumer does not define the listener to those events. They can of course be no-ops... But this can also be something up to each platform, or not defined at the spec level at least.

The ones that are not optional on iOS are:

stateChanged(to state: State)
ended(_ mediaProduct: MediaProduct)
mediaTransitioned(to mediaProduct: MediaProduct, with playbackContext: PlaybackContext)
failed(with error: PlayerError)

I see. All events on Android are optional currently, and changing things to force consumers to treat some specifically would require changing the API from an event stream that the consumer hooks up to to more of a listener which the consumer implements and "installs" into Player, which I'm not sure respects the spec. Let's take this internally.


USB connection with a GoPro

Greetings,
I am willing to use the GoProCam API to control a GoPro HERO 9 but I would like to do so through USB. Not particularly tech saavy here and I couldn't find this information directly: to use GoProCamera.getWebcamIP() I should connect the camera to computer using an USB-C/Ethernet converter, right? I've suceeded in controlling the camera through Wi-Fi, but I don't know if to use it with USB I should connect the USB directly to the computer or get an ethernet adapter. I have a feeling I must be missing something very essential.
The results I've gotten by connecting it directly are the IP <IP_ADDRESS> and "waking up...", without the connection confirmation. When I imagine the IP we get should be X.Y.Z.51.
Kind regards.

You have to connect the gopro without the ethernet adapter, just usb

The entire process should be, then:

turning camera on;
setting USB connection as "GoPro Connection";
connecting the GoPro to the computer via USB;
attempting to connect to the camera through the right commands in the code.

Right?
I guess I will have to try to downgrade the firmware as the documentation suggests (currently using 1.60 and result is what is described above) and see if it works then, assuming this is right. I will return to this thread and share my results once I do it. Thank you for the answer, it is immensely helpful.

Right.

Thanks guys, managed to obtain video from the GoPro through USB thanks to you both. Just stating that I was unable to downgrade from 1.60 once both 1.21 and 1.22 ended making my camera virtually useless because the back screen goes off, but using 1.60 I still managed to get the image feed I needed (and just installing 1.60 again was enough to fully restore the GoPro's functionalities, in case someone who ever reads this goes through the same issue). That was very helpful!
Trying to make the best use for the thread before having it closed: to power the camera on through a command my only path would be via BLE, and my only path of using BLE would be by using gopro-ble-py, right? Having this webcam stream through USB and the ability of powering the camera on remotely (an alternative would be the operator simply using the Quik app to power on but we'd like to avoid such a solution) would pretty likely be all I need for this project.
Thanks again!


Add Sleet to hosting-packages doc

This change adds Sleet to hosting-packages doc. It is a static feed generator that creates NuGet v3 feeds which can be hosted on a web server, azure storage, or amazon s3.
The approach of Sleet is different from other feeds in the list, I think users exploring their options on this page would find it useful.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/hosting-packages/Overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Invalid projectHealth - lombok/tests

Hi,
I wanted to use a plugin in a project. The output I got is:
Unused annotation processors that should be removed:
  testImplementation 'org.projectlombok:lombok:1.18.26'
  testAnnotationProcessor 'org.projectlombok:lombok:1.18.26'

I guess it's because I have:
  implementation 'org.projectlombok:lombok:1.18.26'
  annotationProcessor 'org.projectlombok:lombok:1.18.26'

After removal - test breaks.

Thanks for the report. Do you have a minimal reproducer?

I need more information than that. What does the source look like? If I added such dependencies to an empty project I would not be surprised to be told to remove them.

Closing as nonreproducible.


Add reference assembly as requirement for crams

Follow up steps to make production pipeline know to use this reference.

Codecov Report

Merging #242 (d5622e5) into dev (bb5f516) will decrease coverage by 0.45%.
The diff coverage is 56.00%.

@@            Coverage Diff             @@
##              dev     #242      +/-   ##
==========================================
- Coverage   57.18%   56.72%   -0.46%
==========================================
  Files          64       64
  Lines        4681     4703      +22
==========================================
- Hits         2677     2668       -9
- Misses       2004     2035      +31

Impacted Files
Coverage Δ

sample_metadata/parser/generic_metadata_parser.py
73.82% <52.38%> (-2.49%)
:arrow_down:

sample_metadata/parser/cloudhelper.py
56.97% <66.66%> (ø)

sample_metadata/parser/sample_file_map_parser.py
73.80% <100.00%> (+0.63%)
:arrow_up:

test/test_parse_generic_metadata.py
89.51% <0.00%> (-10.49%)
:arrow_down:

sample_metadata/parser/generic_parser.py
79.87% <0.00%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5f516...d5622e5. Read the comment docs.


Improve tests for AggregateStorage

This PR improves testing of AggregateStorage.
The following test cases were added:

History reading until the most recent snapshot.
Sorting of event records by version.
Sorting of event records by version rather than by timestamp. Behavior of in-memory implementation was fixed according to this scenario.

The version was increased to 0.9.76-SNAPSHOT.

@armiol PTAL.