null instead if undefined in apply of companion object

Looking at typings.antd.libButtonButtonMod.ButtonProps, the trait looks like this
trait ButtonProps extends js.Object {
  var about: js.UndefOr[String] = js.undefined
  var accessKey: js.UndefOr[String] = js.undefined
  var `aria-activedescendant`: js.UndefOr[String] = js.undefined
  var `aria-atomic`: js.UndefOr[Boolean] = js.undefined
[...]

But the companion object looks like this:
object ButtonProps {
  @scala.inline
  def apply(
    about: String = null,
    accessKey: String = null,
    `aria-activedescendant`: String = null,
    `aria-atomic`: js.UndefOr[Boolean] = js.undefined,

So most parameters default to null (except for Boolean type) instead of js.undefined. I guess they should all be js.Undef.Or[T] = js.undefined ?

Hi there, and thanks for your interest :)
What you see here is as designed, though I'm definitely open to suggestions if any of it is cumbersome/wrong somehow.
If you look further down in the method you'll see
val __obj = js.Dynamic.literal()
if (about != null) __obj.updateDynamic("about")(about)
...

In other words we only set the value if it's not null. The scala optimizer/inliner ensures that all the parameters which are defaulted to null (as well as the method itself) are erased from the final javascript code.
I spent some effort making sure these traits are newable, as long as they're not annotated with @js.native. Creating javascript objects with new is very flexible, but somewhat irritating (different syntax for vars/vals, handling overrides, type inference is not always what you want).
For that reason I came up with these creator methods, which ensures normal method syntax for creating objects. In order to make them as user-friendly as possible (and to ensure the inliner can do it's part), I chose to use null rather than js.UndefOr. The reason is that this avoids a bunch of common type inference issues, especially those caused by needing two implicit conversions. It also looks cleaner in your IDE when you query which types things are and so on. When you see that for instance Boolean falls back to js.UndefOr it's because null is not a valid value for primitives on the JVM.
The creator methods in their current form have some drawbacks as well.

Primarily if you already have an val about: js.UndefOr[String] and you want to create an ButtonProps in this particular case, there is no way to use them. This is thought to be uncommon enough that it's ok to fallback to new ButtonProps{...} in that case.
Heavy use of creator methods will probably cause some pressure on the optimizer (causing longer compiles), and you might bump into JVM limits of method body length(!) because all the null parameters are kept there. All in all it's a fairly difficult compromise, especially for traits like ButtonProps which has insanely many props.

As a final note, there is always the fallback option of using js.Dynamic and casting.
Hope this helps, I'll try to rewrite this and put it into the documentation in the readme file.

Hi! Thanks for the quick reply. It looks a bit strange at the first look at the method parameters but after playing around myself it seems to make sense (especially due to the two implicit conversions). The whole JS interop especially for big libraries like Ant is a complex beast. Ticket can be closed, thanks!


Validation error message thrown when trying to commit to multiple disasters in the same date range is not capitalized properly

Create an account
Login as the newly created account
Select "Fake Cluster 1" in the Volunteer for Disaster field
Select "On Site" for Location field
Click Volunteer button
Select "Fake Fake Cluster" in the Volunteer for Disaster field
Select "On Site" for Location field
Click Volunteer button

Expected Result: Validation error message thrown saying "There is already a commitment for this date range"
Actual Result: Validation error message thrown saying "there is already a commitment for this date range".  The 't' is lower cased but should be capitalized.

I think this bug might be outdated...
I've scanned the code for the message you have supplied, but I can't find it (even when searching by fragments) anywhere in the codebase. With that in mind I have gone through the steps you have supplied, and the message I am getting is "You already have a commitment for this date range."
I therefore suspect we may be able to close this issue, but that's a decision for @mchan948 or @tonysurma .
Martin.


Unknown error generating the configuration. Cannot read property 'mkdir' of undefined

I am trying to set up a mainnet symbol node in my VM.
I have installed the symbol-bootstrap with the commands below:
sudo apt update
sudo apt install nodejs npm docker docker-compose
node --version
Since I was facing EACCESS error, I followed the steps from https://docs.npmjs.com/resolving-eacces-permissions-errors-when-installing-packages-globally
And followed the below steps to proceed further:
npm install -g symbol-bootstrap
mkdir my-networks
cd my-networks
Now while running:
symbol-bootstrap start -p mainnet -a dual
I am facing the below error after providing the password:
Symbol_admin@Symbol-Maninet-Node:~/my-networks$ symbol-bootstrap start -p mainnet -a dual
_             _         _                    _         _
___  _   _  _ __ ___  | |__    ___  | |       | |__    ___    ___  | |_  ___ | |_  _ __  __ _  _ __
/ || | | || '  _ \ | '_ \  / _ \ | | _____ | '_ \  / _ \  / _ \ | __|/ __|| __|| '__|/ _ || '
__ | || || | | | | || |) || () || ||_____|| |) || () || () || |_ __ | |_ | |  | (| || |) |
|/ _, ||| || |||./  _/ ||       |./  _/  _/  _||/ _|||   _,|| ./
|/                                                                                ||
? Enter password to use to encrypt and decrypt custom presets, addresses.yml, and preset.yml files. When providing a password, private keys will be encrypted. Keep this password in a secure place! ********

2021-05-13T14:42:17.395Z info     Password has been provided
2021-05-13T14:42:17.442Z info     Generating config from preset 'mainnet'
2021-05-13T14:42:17.443Z info     Using assembly 'dual'
2021-05-13T14:42:17.487Z info     Generating Main account...
2021-05-13T14:42:17.503Z info     Generating Transport account...
2021-05-13T14:42:17.509Z info     Generating Remote account...
2021-05-13T14:42:17.516Z info     Generating VRF account...
2021-05-13T14:42:17.522Z error    Unknown error generating the configuration. Cannot read property 'mkdir' of undefined
2021-05-13T14:42:17.522Z error    The target folder 'target' should be deleted!!!
TypeError: Cannot read property 'mkdir' of undefined
at Function.mkdir (/home/Symbol_admin/.npm-global/lib/node_modules/symbol-bootstrap/lib/service/BootstrapUtils.js:313:29)
at ConfigService.run (/home/Symbol_admin/.npm-global/lib/node_modules/symbol-bootstrap/lib/service/ConfigService.js:98:51)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
TypeError: Cannot read property 'mkdir' of undefined
FYI:
I am running :
Symbol_admin@Symbol-Maninet-Node:~/my-networks$ symbol-bootstrap --version
symbol-bootstrap/1.0.5 linux-x64 node-v8.10.0

Hi @subhasisbanik , your node version 8 is too old, try installing a node 12+


Document Attachment - Provide Access to the NumberOfRecords variable

Describe the request
We would like to have the NumberOfRecords variable on the "Document Attachment Factbox" either as a protected var that we could update from a Page Extension or an event to update the NumberOfRecords.
old code:
    trigger OnAfterGetCurrRecord()
    var
        CurrentFilterGroup: Integer;
    begin
        CurrentFilterGroup := Rec.FilterGroup;
        Rec.FilterGroup := 4;

        NumberOfRecords := 0;
        if Rec.GetFilters() <> '' then begin
            if Evaluate(Rec."VAT Report Config. Code", Rec.GetFilter("VAT Report Config. Code")) then;
            NumberOfRecords := Rec.Count;
        end;
        Rec.FilterGroup := CurrentFilterGroup;
    end;

    var
        NumberOfRecords: Integer;

new code could be:
OPTION 1
    trigger OnAfterGetCurrRecord()
    var
        CurrentFilterGroup: Integer;
    begin
        CurrentFilterGroup := Rec.FilterGroup;
        Rec.FilterGroup := 4;

        NumberOfRecords := 0;
        if Rec.GetFilters() <> '' then begin
            if Evaluate(Rec."VAT Report Config. Code", Rec.GetFilter("VAT Report Config. Code")) then;
            NumberOfRecords := Rec.Count;
        end;
        Rec.FilterGroup := CurrentFilterGroup;
    end;

    protected var
        NumberOfRecords: Integer;

OPTION 2
    trigger OnAfterGetCurrRecord()
    var
        CurrentFilterGroup: Integer;
        IsHandled: Boolean;
    begin
        OnBeforeCalculateNumberOfRecords(Rec, NumberOfRecords, IsHandled);
        if IsHandled then
            exit;

        CurrentFilterGroup := Rec.FilterGroup;
        Rec.FilterGroup := 4;

        NumberOfRecords := 0;
        if Rec.GetFilters() <> '' then begin
            if Evaluate(Rec."VAT Report Config. Code", Rec.GetFilter("VAT Report Config. Code")) then;
            NumberOfRecords := Rec.Count;
        end;
        Rec.FilterGroup := CurrentFilterGroup;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeCalculateNumberOfRecords(DocumentAttachment: Record "Document Attachment"; var AttachmentCount: Integer; var IsHandled: Boolean)
    begin
    end;

    var
        NumberOfRecords: Integer;

Additional context
we need this request because we have built a connector to SharePoint where the attachments are stored. However, we had the need for an extra table to hold extra attachments that need to be added to the the total number of attachments (which is still shown on the top of the page as a sum of the Document Attachments, the Links and the Notes).

Internal work item: AB#492626

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14309.


GraphQL variables have wrong format in query

See GraphQLHub:
GraphQL Tour: Variables

How do we set the values for variables? The GraphQL spec doesn’t impose any constraints, similar to how it does not specify the mechanics of GraphQL requests in general. The GraphQL-JS ecosystem generally uses a separate JSON blob

Following Apollo's documentation and using:
const withUserFromId = graphql(GET_USER_WITH_ID, {
  options: (ownProps) => ({ variables: { id: ownProps.userId } })
});
const MyComponentWithData = withUserFromId(MyComponent);

The query should be:
{"query":"query getUser(id: $ID!) { user { name } }\n}\n","variables":"{\n  \"id\": \"1\"\n}","operationName":"getUser"}
but it is:
{"query":"query getUser(id: $ID!) { user { name } }\n}\n","variables":{"id":"1"},"operationName":"getUser"}
The value of "variables" is not in quotes as it should be. It is JSON and not a JSON blob.
Therefore the GraphQL server that I am using does not find the variables when executing the query.

I investigated more and it seems that the issue is with the Apollo Client and not only with React Apollo:
Apollo Client issue

Let's close this one in favor of the other


updae sha2 to 0.10 for check feature

@Nemo157 Hello! Can you please take a look?

bors r+

bors retry


Fixed deprecations, warnings and missing return types

Enabled -deprecation compiler option
Fixed deprecations, warnings and missing return types

@lolgab A review would be nice, thanks.

Thanks Lorenzo!


Chore/12 24 upgrades

Description
staying hip
Other changes

codecov npm is sunset and not actually used. instead the github action we have does the work
truffle/contract appears unused

Tested
Related issues

PR-Codex overview
This PR focuses on updating various package dependencies, modifying import paths to use node:path, and improving code formatting for better readability. It also involves the removal of obsolete documentation files.
Detailed summary

Deleted index.md and ledger_to_account.md from packages/docs/viem-account-ledger/modules/.
Updated rimraf version from 3.0.2 to 6.0.1.
Updated google-libphonenumber version from 3.2.27 to 3.2.40.
Updated @ethereumjs/util version from 8.0.5 to 8.1.0 across multiple packages.
Changed import paths from path to node:path in several files.
Reformatted constructor parameters for better readability in various classes.
Updated viem version from ~1.5.4 to ~2.21.55.
Improved transaction receipt retrieval code for clarity.
Updated GitHub actions and workflow configurations.
Increased @changesets/cli version from 2.26.2 to 2.27.10.

The following files were skipped due to too many changes: yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

closing for #492


bigtable: no way to view current GC policy

There is currently no way via the bigtable API to view what GC policy is currently set on a given column family.  Seems like this would be nice to add to the TableInfo struct.  I don't have a strong opinion what form this data should come in - for my current purposes just a string would be fine as I only envision using it for human consumption.
Also would be great to add this to the cbt tool.

This is fixed by dac7754.
I'll close the issue when it has been released through gcloud.


Feature/fix-nested-program-error

Just a workaround that seems to be more stable than the previous version. Might still need more investigation in the future.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Testing Notes

@jstvz Can you please approve this PR ? It's not a great solution, but for the moment, I think its more stable than the current master version.

@jstvz Never mind this PR. I created this before I knew the issue was a mismatch between local and MetaCI org. So this solution is anyway going to fail at one of the locators. I'm closing this PR and will create another one just to mark the scripts as unstable (until we resolve this issue).


bb_serial_read_open doesn't clear receive buffer

Hello...
When issuing  "bb_serial_read_open(user_gpio, baud, bb_bits)" the receive buffer is not cleared.
I had issue in my app as I need to open/close that beacouse I run rx/tx with different baudrates.
when I get data I needed with "bb_serial_read(user_gpio)" I close receiver with "bb_serial_read_close(user_gpio)".
But as there are lattency in mean time some other (garbage) bites are already received betwen read and close.
when I again open with "bb_serial_read_open(user_gpio, baud, bb_bits)"
and read with "bb_serial_read(user_gpio)" I got that garbage bits too.
As bitrate is high and lattency is longer than few bytes there is no way to know which byte is the correct (first) one.
I see solution that when  "bb_serial_read_open(user_gpio, baud, bb_bits)" or "bb_serial_read_close(user_gpio)" is issued the receive buffer should be cleared.

Are you sure?  The receive buffer is allocated from the stack in the open (and emptied) and free'd in the close.  I think you are seeing something else.

Actually I'm wrong here.
Indeed the buffer IS cleared when bb serial is opened. But there is hack!
As I do open bb serial in script (to have as low lattency as possible) I discovered that when serial is opened they capture data from past!
For test I do wave chain to transmit byte 1,2,3 and another with byte 4,5.
The pigs script start bb receiving when see waveform (4,5) started.
and I receive bytes 3,4,5 often, or even garbage as receiving seems to start somewhere in midbyte of byte 2 or 3.
This is probably caused by some buffering and probably not solvable at all.
For finding that it take me few days. So please just add in manual that when receiver is started the data capture start around 200-400us in past!

With more deep observing I find that start point where capture begin is very random. As I observed for now it can be around half milisecond earlier or late.

It will depend on the sampling rate and the buffer size specified for pigpiod.  This is not a bug.

Should be nice if that is in documentation.


GHSA-m8rp-vv92-46c7 has mangled content and formatting since 58f1bbf

Since https://github.com/github/advisory-database/pull/4768 was merged and changes applied in https://github.com/github/advisory-database/commit/58f1bbfff2a4c5fab770f11e3db1c47cb9666422, the global https://github.com/advisories/GHSA-m8rp-vv92-46c7 advisory is broken.
Code blocks and code spans have spurious backslashes added to them and, in some cases, literal newlines: literal \ is converted to \\; literal \n sequences converted into a \ followed by a literal newline; literal tabs are converted to single spaces; leading spaces are added in some places where not present; and other changes.
The affected portions of the advisory include its proof-of-concept instructions that, if followed as currently presented, could result in readers assuming they have a patched version when they do not.
This advisory pertains to a vulnerability that is itself about improper handling of backslash-based escape sequences. Consequently, it may be very hard for readers to understand what the advisory is trying to say, even if they are aware of the problem.
There are some problems outside code blocks and code spans, and I am not confident that I have spotted them all, but they include omitted leading spacing for a second paragraph in a numbered list item, causing the list to be broken into two, with the second paragraph outside both lists. This is less of a problem than the changes in preformatted code blocks.
Using this diff tool...

...on the changes shown in https://github.com/github/advisory-database/pull/4768/files verifies that the actual diff of #4768 does not include these breakages.
...on changes shown in https://github.com/github/advisory-database/commit/58f1bbfff2a4c5fab770f11e3db1c47cb9666422?diff=split&w=0 reveals that the actual diff of https://github.com/github/advisory-database/commit/58f1bbfff2a4c5fab770f11e3db1c47cb9666422 does contain the breakages.

Therefore:

This breakage is similar to (though far more extensive than) the breakage observed in connection with an older unrelated advisory GHSA-2mqj-m65w-jghx, where it was manually corrected. However, in #4768 the involvement of the security curation team was not as visible, such that there is not a specific individual I would know to ping.
Because the problem is introduced separately from and after a PR s is merged, I do not think I can correctly fix this myself via the improve link or by opening a pull request. Even if there is a change that would restore the old rendering while defensively avoiding mangling, I don't think I have the means to figure out what that change would be, for the reasons described here.

The repo-local advisory remains correct and is usable as a reference.

Hi @EliahKagan, I tried manually correcting the formatting of the text in https://github.com/advisories/GHSA-m8rp-vv92-46c7 according to https://github.com/Byron/gitoxide/security/advisories/GHSA-m8rp-vv92-46c7. Does it look correct to you now?

@shelbyc Thanks!! This is mostly correct now, but there are three remaining problems that I have been able to identify.
Backslashes are doubled in code spans
There are actually no intended occurrences of \\ in the advisory (and \\ does not appear in the advisory at https://github.com/Byron/gitoxide/security/advisories/GHSA-m8rp-vv92-46c7), so this can possibly be solved efficiently with search and replace, I am not sure. But in case it is useful, these are the places with \\ that should be \.
I'm presenting them in diff-like form for readability, but these diffs cannot actually be applied as patches because they don't show full lines, and also because they are diffs of Markdown and not of JSON.
-For example, `é` is transformed to `\\303\\251`, with literal backslashes.
+For example, `é` is transformed to `\303\251`, with literal backslashes.

-Its user profile directory is assumed to be `C:\\Users\\Renée`.
+Its user profile directory is assumed to be `C:\Users\Renée`.

-Its user profile directory is assumed to be `C:\\Users\\Ren`.
+Its user profile directory is assumed to be `C:\Users\Ren`.

-Install Git for Windows in the default location for non-systemwide installations, which for that user account is inside `C:\\Users\\Renée\\AppData\\Local\\Programs`.
+Install Git for Windows in the default location for non-systemwide installations, which for that user account is inside `C:\Users\Renée\AppData\Local\Programs`.

-correspondingly modified path components in place of `AppData\\Local\\Programs\\Git`
+correspondingly modified path components in place of `AppData\Local\Programs\Git`

-where attacks such as those shown in the Windows proof-of-concept above can be performed due to the status of `\\` as a directory separator
+where attacks such as those shown in the Windows proof-of-concept above can be performed due to the status of `\` as a directory separator

Subsequent paragraphs in list items are outside the list
In the numbered list under "As Renée:", the first item has a second paragraph, which in the repo advisory is kept as part of the list item by three leading spaces. But in the global advisory, it is a break in the list between the first and second items, rendering unindented.
It should be possible to fix it by re-adding the spaces that had been lost:
-(The scenario can be modified for any location the attacker can predict.
+   (The scenario can be modified for any location the attacker can predict.

Likewise, in that same list, the third item has both the code block and the paragraph after the code block as part of the list, in the repo advisory. But in the global advisory, they are outside the list. This is the same kind of problem as in the first item.
 3. Open a PowerShell window...

-```pwsh
-gix clone ssh://localhost/myrepo.git
-```
+   ```pwsh
+   gix clone ssh://localhost/myrepo.git
+   ```

-At least one, and usually two, instances of the Windows calculator...
+   At least one, and usually two, instances of the Windows calculator...

A spurious double quote mark appears at the end of the "Impact" section
A literal " appears at the very end of the last paragraph.
-because the necessary conditions are uncommon and challenging to predict."
+because the necessary conditions are uncommon and challenging to predict.

It is possible that there are other discrepancies, but I have tried to identify all unintentional differences.
Thanks again for all your help!

Thank you so, so much for the specific examples that I was able to use when going back and correcting extra \ characters and re-adding removed spaces. If there was a gold star emoji available in the comment reaction menu, that's what I would've given you. Thanks again for reaching out and providing specific examples of discrepancies to fix!

Thanks! Everything looks great in https://github.com/advisories/GHSA-m8rp-vv92-46c7 now, so I'm closing this issue as completed. I will also keep in mind that the specific diffs, even though they cannot be automatically applied as such, are useful for problems like this. In hindsight, I might've been able to produce a full set of those initially.
If it would be helpful, I can open a new issue for the general problem of broken formatting, especially in the presence of backslashes, that this and https://github.com/github/advisory-database/pull/3290 were special cases of. (Other options including not having any public issue for that at this time, and editing and reopening this issue to cover it.)


Error in readme

just mistake :)
For copy/pase purposes)

var pug = requrie('gulp-pug');

Should be
require

Thanks, my bad.  I can go ahead and fix that.


fix : Update ConsoleControl.cpp

Summary of the Pull Request  :-
Updating Console Control.
References and Relevant Issues :-
1.Microsoft Windows API Documentation
2.Pseudoconsole (ConPTY)
3.Console Window Management
Detailed Description of the Pull Request / Additional comments : -
It allows you to set various properties and operations for the console window, such as notifying a console application, setting foreground status, ending tasks, and setting the window owner.
Validation Steps Performed
PR Checklist

[x] Closes #14196
[x] Tests added/passed
[x] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[x] Schema updated (if necessary)

I'm genuinely curious why you and others spam repositories with code that's clearly AI/LLM generated. Why do you do this? It doesn't even compile and just makes maintainers ban you from contributing again.


Testing Support?

It's disappointing not to see a test harness considered a first class citizen of a 'quick start' project.

People have strong opinions about testing. If we were to bake in the use of a particular test framework (for example, Jest, which we use internally at Facebook), then the decision would harm at least as many people as it helped (because they would need to go to additionally lengths to remove the set-up and configuration and replace it with their own).
Thanks for the input though. I share your conviction that testing is important. Maybe we should add a note to this effect — why there is no testing baked in, but referring to a list of the top 2 or 3 (or 4) test libraries that users may wish to integrate — to the readme?
In the meantime, going to close this as we don't have any plans to add testing. Feel free to submit a PR for the docs as outlined above though. Thanks once again for bringing this up!


seeds file and arabic sentiment analysis

Hello, i'm working on Arabic sentiment analysis, and i'm wondering if these codes will work for me ? and i'm looking from where you got seeds file ? and how can i make one ?
and from where you get this files :
FREQ_DIST_FILE = '../train-processed-freqdist.pkl'
BI_FREQ_DIST_FILE = '../train-processed-freqdist-bi.pkl'
TRAIN_PROCESSED_FILE = '../train-processed.csv'
TEST_PROCESSED_FILE = '../test-processed.csv'
GLOVE_FILE = './dataset/glove-seeds.txt'

It should work for any language in theory. However, as far as I know, Arabic doesn't have word boundaries as good as English so I cannot really say how much you need to change. Seeds are the glove word vectors available from StanfordNLP group's website. If you want to generate for Arabic, you'll have to use Word2Vec or Glove on a huge dataset of Arabic tweets.
For all the other files, please read the Readme file.


Add script to check size stats in bundle

This will allow us to check for changes that might suddenly bloat the size of this library.
$ npm run size

<3


Initial work on resizing deployments with replicas > 1

This is just an initial draft:
I want to discuss:

what are the exact points where on Dropping or on exiting mirrord should resize the replicas back to its original number after downsizing, for example when the connection is dropped, or when the library constructor exits
how do we go about doing the above when a simple call to exit() happens, do we hook exit()?
do we install signal handlers for signals like SIGINT
what kind of patch strategy are we looking to follow: https://docs.rs/kube/latest/kube/api/enum.Patch.html

When connection is dropped, which should happen on library exit.
I think we have a graceful shutdown, but might be wrong about it that we need to hook exit to accomplish it (maybe as a prior PR)
Can you write down the differences? not sure what are the effects.
I know it's a draft, so just making sure we're aligned that this feature is a flag and not a default.

When connection is dropped, which should happen on library exit.
I think we have a graceful shutdown, but might be wrong about it that we need to hook exit to accomplish it (maybe as a prior PR)
Can you write down the differences? not sure what are the effects.
I know it's a draft, so just making sure we're aligned that this feature is a flag and not a default.

I think we have a graceful shutdown, but might be wrong about it that we need to hook exit to accomplish it (maybe as a prior PR)

i thinking hooking exit should be right

Can you write down the differences? not sure what are the effects.

what happens when a user sends an interrupt signal to the process, in that case there is no graceful shutdown
i thinking we should have a mask of signals we can handle and install a handler for them which will result in a graceful exit along with downsizing the replica set

I know it's a draft, so just making sure we're aligned that this feature is a flag and not a default.

yes we are on the same page, this will be a flag

When connection is dropped, which should happen on library exit.
I think we have a graceful shutdown, but might be wrong about it that we need to hook exit to accomplish it (maybe as a prior PR)
Can you write down the differences? not sure what are the effects.
I know it's a draft, so just making sure we're aligned that this feature is a flag and not a default.

I think we have a graceful shutdown, but might be wrong about it that we need to hook exit to accomplish it (maybe as a prior PR)

i thinking hooking exit should be right

Can you write down the differences? not sure what are the effects.

what happens when a user sends an interrupt signal to the process, in that case there is no graceful shutdown i thinking we should have a mask of signals we can handle and install a handler for them which will result in a graceful exit along with downsizing the replica set

I know it's a draft, so just making sure we're aligned that this feature is a flag and not a default.

yes we are on the same page, this will be a flag

interrupt should still call exit..

what happens when a user sends an interrupt signal to the process, in that case there is no graceful shutdown i thinking we should have a mask of signals we can handle and install a handler for them which will result in a graceful exit along with downsizing the replica set

interrupt should still call exit..

sorry, can you elaborate? i was saying that the handler will do a graceful exit.. could be through a common function for exiting

sorry, can you elaborate? i was saying that the handler will do a graceful exit.. could be through a common function for exiting
AFAIK if a signal handler causes the process to exit, it will call exit hence if we hook exit we'll do it gracefully.

what kind of patch strategy are we looking to follow: https://docs.rs/kube/latest/kube/api/enum.Patch.html

do we lose the containers from the pods once we patch? does that not affect any files that existed on a particular container? if we use Merge we can merge containers but what happens when we scale back?

what kind of patch strategy are we looking to follow: https://docs.rs/kube/latest/kube/api/enum.Patch.html

* do we lose the containers from the pods once we patch? does that not affect any files that existed on a particular container? if we use `Merge` we can merge containers but what happens when we scale back?

The strategy doesn't affect what happens in the containers themselves, it's merely how the patch is applied "yaml" wise. What happens in case of conflict, who applies, etc.


WAITING: Content: Student: Post Submission

Placeholder
@astridSABC this will likely need to expanded to 5 smaller tickets when completed but will advise

Ticket no longer required.


Fix videoservice

Fixes for restarting of camera

@spiderkeys what's the story here? Is this tested and ready to merge?


feat: statistical the traffic of reused peer

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Statistical the traffic of reused peer.

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1816 (9c480e9) into main (abd11a2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   43.78%   43.78%   -0.01%
==========================================
  Files         128      128
  Lines       16021    16026       +5
==========================================
+ Hits         7015     7017       +2
- Misses       8470     8471       +1
- Partials      536      538       +2

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
43.78% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

scheduler/resource/seed_peer.go
17.47% <0.00%> (-0.90%)
:arrow_down:

...ent/daemon/peer/peertask_piecetask_synchronizer.go
50.15% <0.00%> (-0.94%)
:arrow_down:

client/daemon/peer/peertask_piecetask_poller.go
51.36% <0.00%> (+2.73%)
:arrow_up:


About Page - Shop Link Should Open a New Page

Please edit this line in /server/views/resources/about.jade. The 'shop' link should open a new page when clicked. Similar to the link to Quincey's Quora page.
Be sure to follow the Contributor's Guide. If you need any help, head over to the HelpContributors chat room.
Good luck and thanks for contributing :tada:

May I try this?

@manish-giri I would like someone who hasn't contributed to FreeCodeCamp before to give it a go. If it is still here tomorrow, then sure.
There are plenty of issues to choose from. If you need help and guidance with an issue, try the HelpContributors chat room on gitter.im

Can I have a go?

Yes @zk433 certainly, I look forward to it

I haven't seen a pull request for this yet, can i try? I haven't been able to contribute yet, and I could use the practice.

@jarenescueta731 I'm already working on it but it's a weekend so I haven't had enough time to finish setting things up.
@Bouncey are you in a hurry with this? I should have it finished by tomorrow.

@zk433 alrighty, the first-time setup for contributing to FreeCodeCamp is still confusing me anyways

@jarenescueta731 Hi Jaren, if you still want to, go for it. I'm taking too long setting things up, I may have taken on way too much at this point of my learning journey.

may I try this?
I haven't contributed yet

Hello
Could you please specify which part of the text you want to link to which page. I don t see any error and checked Quincey s page for any new shop but couldn t find it. Thanks

Should be fixed in #9416

+1

:+1:


Do updates, related to RHBQ 3.15.1 release

Summary

Remove daily runs
Use Quarkus 3.15.1 for PRs
Use fixed versions of external applications

Based on https://github.com/quarkus-qe/quarkus-test-framework/blob/main/CONTRIBUTING.md#branches
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Dependency update
[ ] Refactoring
[ ] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Also split into 2 commits would be better - one for GH action changes and one for code changes


Fix spec_helper version check for Windows

On Windows, there are two issues preventing spec/spec_helper.rb from running correctly:

the --version of Chrome on Windows actually starts a new window, which is preventing the rest of the spec from running as this is a blocking process. So this adds the --headless -no-gpu options to the call so that they can run without blocking the test.
Chrome default installation path is in C:/Program Files (x86)/Google/Chrome which means that parenthesis must be taken into account, so this simply quote the path so that it runs smoothly without too much care for spaces or special characters. This has been tested on both Mac and Windows

Thank you, looks like on Linux it works as well!


[BUG] My icons are not loading correctly they don't look good.

Acknowledgement of preliminary instructions

[x] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.0
What problem did you encounter?
My icons are not loading correctly they don't look good.

Bloxstrap Log
N/A

Have you tried manually setting the texture quality in Bloxstrap's engine settings?

I don't know how to.
On Thu, Oct 31, 2024 at 6:15 AM pizzaboxer @.***> wrote:

Have you tried manually setting the texture quality in Bloxstrap's engine
settings?
—
Reply to this email directly, view it on GitHub
https://github.com/bloxstraplabs/bloxstrap/issues/3579#issuecomment-2449501180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMR2AK5ED5DZUFJS5LXC6X3Z6H7K5AVCNFSM6AAAAABQ5H4PXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGUYDCMJYGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Difficult to work next weeks

Hi all,
On Sunday, I dislocated my shoulder and I am having difficulty working ...
Forgive me if I cannot give support. If you can do the pull-requests

Ouch, get well soon!

Get well soon

At least it is not coronavirus.  Get well soon.


Update codebase from CommonJS to ESM

This was already done by Igor when he helped us try to find the memory leak #13, thanks man you rock!

Closed by #15


Provide OSGi bundle

This cool library deserves a OSGi bundle. I'm currently creating a bundle by wrapping  the library with its not-so-common dependencies embed [0]. I kept the groupId and will keep the version aligned with the library.
I successfully tested this bundle on Adobe CQ 5.6.1 as-is. I'm also planning to write instructions for Apache Felix which might need the installation of some dependencies.
Feel free to comment commits, create issues. Feedback will be really appreciated.
[0] https://github.com/acollign/github-api-osgi

Hi @kohsuke , I'm suggesting to manage the OSGi bundle with a different artifact mainly because github-api has many dependencies that doesn't offer OSGi bundles at the minute.
It is therefore easier to embed those dependencies in a wrapper while keeping in mind that it has some drawbacks. Btw, I followed the instructions of the Apache Felix documentation [1].
[1] https://felix.apache.org/documentation/subprojects/apache-felix-commons/creating-bundles-using-bnd.html

You can shade jar.

Hi @KostyaSha ,
Shading the jar is  another option but I'm not sure it makes more sense than the current approach.

Closing as stale.


Add extension recommendations

Addresses issue #1093
skuba init now creates a .vscode folder and inserts extension recommendations. Implementation written here will overwrite recommendations if they exist already however as it's part of init I think that's ok.
I have opted for a patch changeset as per contribution guidelines of minor change involving init.

Hey! Thanks for the PR! I love the attempt
I think a slightly simpler option may be just to create the files under our base folder section. I think that should work.
eg.
https://github.com/seek-oss/skuba/blob/main/template/base/.github/CODEOWNERS

Thanks!
That's definitely a simpler idea.
The issue I'm running into at the moment is the inclusion filter is excluding .vscode/* as it's in the .gitignore
Some possible solutions I've identified:

Don't use the .gitignore in the filter but filter based on an exclusionFilter file or similar for more granular control

Less code change but feels more hacky

Modify the inclusion filter function itself to allow exceptions (i.e files in gitignore that we do actually want to copy)

This is potentially too big of a change for a small feature, but may come in handy later?
I also don't think this would classify as a patch anymore

I have done the latter in commit 97b487c87b7691778a8519d42490aaab964b19c4

Hey @GeordieEK - I'm liking the direction!
I wonder if rather than modifying the code - could we get away with explicitly allowing this file?
For example, adding !.vscode/extensions.json after the .vscode/ignore* in the _.gitignore template?

I think so - struggling to see a huge downside, though open to opinions of course

Yeah I think it's unlikely anyone will really be bothered by that inclusion.
I would say the level of change to the codebase fits the utility of the improvement better.
Changing a utility function for this small of a benefit is a bit extreme... fun first issue though!

I think including extensions.json in the git makes sense. The main reason the vscode folder is ignored is mostly to stop user settings from constantly being committed, however, this isn't really one of those files

Simplified implementation implemented at #1556


Updates for main with no exports

The current message is quite confusing to me because exports doesn't have anything to do with ESM. You can use it with CJS as well. This updates it to apply whether the code is CJS or ESM.

I think this PR changes the intent though. The idea was that if you have main but no exports, you should use exports instead. It looks like I didn't check this right, it should be if (expectFormat === 'ESM' && !exports) { 😦
I think we should fix it and keep it that way for now. The message needs an update too. I can fix this myself too.
With that said, I think the idea of this PR is good too, but it'd need to be a new rule, and maybe apply to module field too.

Aight that's fixed at 57fdc43b0ec7db4687e99bc936de06f523141395. Sorry for the new conflicts and thanks for spotting the bug 😬

I'll close this one for now and write a new issue so we keep track of this.


why recalculate pi and v?

Hello, in game_ac_network.py,  def prepare_loss(self, entropy_beta), you have:
  # temporary difference (R-V) (input for policy)
  self.td = tf.placeholder("float", [None])

  value_loss = 0.5 * tf.nn.l2_loss(self.r - self.v)

But td == self.r-self.v, right?
So, why not use self.td directly instead of recalculating self.v ? Also for pi, why not pass it as placeholder?
Hope reply thanks.

Because self.td is a fed in number(s) used in the policy gradient. You use self.r - self.v to calculate critic losses.


use new token for new package name

Pull Request summary:
Cannot rename old token so we introduce new CATALYSTWAN_PYPI_TOKEN and use it in build pipeline.
Old PYPI_TOKEN could be still used if vmngclient package needs to be built.

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/456


Add rule element to Eternal Bane

Adds a rule element to Eternal Bane that adds aura that applies Bane spell effects to enemies in 15 feet, as per Player Core.

Duplicate of #11374 and #15529


Feature/rock threading

SoftLock needs to be public now that it is in its own assembly.

Looks good. 👍


App Crashes on Load with iOS 10

Hi All,
We have been using this plugin for a while.  We recently upgraded Cordova and our app is using 4.3.1 version.
But now our app crashes on iOS 10 when Accessibility is turned on.
Resetting plugins due to page load.
*** Terminating app due to uncaught exception 'DOMException', reason: '*** DOMException 105'
Seems to be something with this:
#21	0x000000019759ed70 in -[UIView(UIAccessibilityElementTraversal) _accessibilitySubviewsForGettingElementsWithOptions:] ()
#22	0x000000019759f8b4 in -[UIView(UIAccessibilityElementTraversal) _addAccessibilityElementsAndOrderedContainersWithOptions:toCollection:] ()
#23	0x000000019759f920 in -[UIView(UIAccessibilityElementTraversal) _addAccessibilityElementsAndOrderedContainersWithOptions:toCollection:] ()
#24	0x000000019759f920 in -[UIView(UIAccessibilityElementTraversal) _addAccessibilityElementsAndOrderedContainersWithOptions:toCollection:] ()
#25	0x000000019759fd90 in +[UIView(UIAccessibilityElementTraversal) _accessibilityElementsAndContainersDescendingFromViews:options:sorted:] ()
#26	0x00000001975a016c in -[UIApplication(UIAccessibilityElementTraversal) _accessibilityViewChildrenWithOptions:referenceWindow:] ()
#27	0x000000019f0899ec in -[UIApplicationAccessibility _accessibilityResponderElement:] ()
#28	0x000000019f0901c4 in -[UIApplicationAccessibility accessibilityAttributeValue:] ()
I removed the plugin and I am still having the issue.
It works fine on iPhone 5 with iOS 10.2.1.  But crashes consistently on iPhone 6 running iOS 10.2.1 which does not make sense to me.
It crashed right after Cordova starts to reset the plugins.
Is anyone else having this issue?   If so, how did you resolve it?
Thanks,
Chris

Hi @chrisschmidtmoven
I'd like to see what the origin of the issue is, and possibly fix it if I can pinpoint where it happens. Firstly, I would need to reproduce it.
Can you provide repro steps (cli commands, Settings.app settings you turned on, etc) so we can get to the same page? Start with a new clean Cordova project. Thanks!


Terminal crashes when clicking or dragging over full-width characters in the scrollback buffer

Environment
Windows build number: 10.0.18362.175
Windows Terminal version (if applicable): latest store build (0.2.1715.0) and github build

Steps to reproduce

Type in one or many full-width unicode characters or emoji. For example, ｔｈｉｓ or ⚡.
Press enter enough times to put the characters into the scrollback buffer.
Scroll up and click on one of the full-width characters. Or start a selection from elsewhere and drag your mouse over one of the full-width characters. Basically (LMB down + mouse over a full width character in the scrollback buffer).

Expected behavior
Nothing special should happen.
Actual behavior
Terminal crashes.

Surprised this is occurring. My guess is that this is related to #1317. The call stack sounds like it's from Terminal::_ExpandWideGlyphSelectionRight() or Terminal::_ExpandWideGlyphSelectionLeft().
To fix this, we need to modify Terminal::_GetSelectionRects() to prevent selecting a part of the buffer that doesn't exist.
Adding "Help-Wanted" tag for anybody to hop on this.


Users don't see the folders created by other users

I'm using this component on a Community and it looks great but if I login with one user and create a couple of folders and then I login with another member of the Same community they see the uploaded files but they don't see the folders even after Refresh.

Same issue here where community users are not able to see folders and files created from internal users.
I had to change Sharing Settings to Public ReadOnly for Community users on objects because we cannot create appropriate Sharing Sets on them:

File Explorer File
File Explorer Folder

Same issue here where community users are not able to see folders and files created from internal users.
I had to change Sharing Settings to Public ReadOnly for Community users on objects because we cannot create appropriate Sharing Sets on them:

File Explorer File
File Explorer Folder

Thanks that did the trick, not sure why I haven't though of it


Ingestion: Bigquery Epic

Add Support for bigquery related enhancements:

[ ] Primary, Foreign, and Unique Constraints.
[ ] Fetch column description for views

Hi, I would like to take up this task.


Opening Scripts by default in the SQL Editor

I have a problem with my install of DBeaver.
Originally when I clicked on files in the Projects Window, they opened in the SQL Editor.
Now when I click on files in the Projects Window, they open in the Projects Window instead of the SQL Editor.
I would like to know how to get them to open by default in the SQL Editor.
I have searched forums and the web but haven't found any solutions.
I have also asked other users, but they don't seem to know either.

@unlysted , which dbeaver version do you use? could you provide a screenshot or video with an issue?


Fix empty metadata.annotations causing sync issues

Switching this component to server-side has the side effect that the last known state is no longer tracked in the metdata.annotations field. If using a library to create resources, like kube.libsonnet, will create empty metadata.annotations fields. Which will then cause a sync issue with argocd.
Checklist

[x] The PR has a meaningful title. It will be used to auto-generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
[x] PR contains a single logical change (to build a better changelog).
[ ] Update the documentation.
[x] Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
[ ] Link this PR to related issues or PRs.

What bugs me about this solution is that if kube._Object ever adds more fields in metadata, they'll be missing from those objects.
A possible solution would be to just wrap calls to kube._Object in std.prun:
  std.prune(kube._Object('argoproj.io/v1beta1', 'ArgoCD', n.name)) {
    metadata+: {
      namespace: n.namespace,
    },
...

What bugs me about this solution is that if kube._Object ever adds more fields in metadata, they'll be missing from those objects.
A possible solution would be to just wrap calls to kube._Object in std.prune:
  std.prune(kube._Object('argoproj.io/v1beta1', 'ArgoCD', n.name)) {
    metadata+: {
      namespace: n.namespace,
    },
...

This will also prune other fields under spec, sometimes those empty fields have meaning.


Add option to disable rate-limited request retry

Some requests are time sensitive and become stale if not completed quickly. It's better to let the library user choose how to handle a rate limit being exceeded in those cases. ShouldRetryOnRateLimit is a session option which disables automatic retry and instead returns an error the user can use to handle retry manually.
Closes #1011.

Thanks for your contribution!


chore: remove the superflous NormedSpace.toModule' and NormedAlgebra.toNormedSpace'

This was relevant in Lean 3, but everything just works now.

!bench

!bench


Add ARM64 arch support for serving runtimes

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2989
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Added ARM64 arch support for serving runtimes

Thanks, the update looks straightforward to me. FWIW, I stumbled upon the same issue when cross-compiling (however, I "just" installed  gcc which seemed good enough to compile the native parts in the dependencies, but I think the solution here is cleaner and more comprehensive even when it might add a bit more to the build times).
I wonder whether it would make sense to combine this with #3042 (if this makes sense to add), so that only one version bump would be required?

Thanks for the suggestion @ckadner. I agree with you. It would be nice to remove the duplicates. Let's handle it in a separate PR.

@rhuss Thanks for the suggestion. But I think it is better to keep it as a different PR since, both are two different features.

@yuzisun Currently, Paddle does not have support for ARM64.

@yuzisun @ckadner Currently, Paddle does not have support for ARM64.

I think that's okay. We could keep track of that in a separate issue.


RSC15b

Implemented TO3k6 and RSC15b from v0.9 spec.
Please review and merge if everything looks good.

As per discussion in client-libraries - disable all fallback hosts if an array fallbackHosts is empty but not nil.
Please review and merge if everything looks good.

LGTM

LGTM


To make it clearer that there are 3 scripts to include

Hi. The README currently says: Include three.xr.js & aframe-xr after A-frame.... But the code example currently looks like this:
<script src="../../../vendor/aframe-master.js"></script>
<script src='aframe-xr.js'></script>

So I thought I just needed to include aframe-master.js and aframe-xr.js.
Also, taking a look at the xr-basic example caused me some temporary further confusion, because the aframe-master.js script tag is off-screen, over the right-hand side, after the origin trial tag.
So this PR is my recommendation for extra newbie-friendliness:

README.md: add three.xr.js script include
README.md: remove ../../../vendor/ path, to make the 3 includes consistent and more general
xr/basic/index.html: move the script tag onto its own line

WDYT? :)

Looks good!  (sorry about the script tag being on the end of the line with the origin trial script, that was my recent flub, thanks for catching it.)

Thanks!


Script not waiting for Ajax request completion on the page

I am not able to find a way to wait for all the ajax request get complete before dumping the content. Does Phantom support page.onCallback method like Phantomjs

See https://github.com/amir20/phantomjs-node/issues/427#issuecomment-203502313


Kamal fails to detect docker on Synology NAS

On a lark I attempted to deploy an app to my NAS and have had zero luck. Docker -v fails no matter what I do for both root and admin accounts, so it attempts to reinstall docker unsuccessfully (it says distro is not supported). If I ssh in directly both as root and as an admin user, docker -v works as expected, as do any other docker commands. I’ve read the relevant source, as far as I can tell it should be sshing in under the correct context but perhaps I’m mistaken? I can deploy it successfully to a Ubuntu VM within the nas but I’d love to deploy natively if possible since as far as I can tell it should behave like any other amd64 box.

It seems to be related to the pseudo terminal flag for ssh.

Nevermind, it's because PATH is very limited for ssh command invocations. This article covers the issue: https://qmacro.org/blog/posts/2021/06/12/remote-access-to-docker-on-my-synology-nas/


[SPARK-27112][CORE] : Create a resource ordering between threads to r…

…esolve the deadlocks encountered when trying to kill executors either due to dynamic allocation or blacklisting
Closes #24072 from pgandhi999/SPARK-27112-2.
Authored-by: pgandhi<EMAIL_ADDRESS>Signed-off-by: Imran Rashid<EMAIL_ADDRESS>What changes were proposed in this pull request?
There are two deadlocks as a result of the interplay between three different threads:
task-result-getter thread
spark-dynamic-executor-allocation thread
dispatcher-event-loop thread(makeOffers())
The fix ensures ordering synchronization constraint by acquiring lock on TaskSchedulerImpl before acquiring lock on CoarseGrainedSchedulerBackend in makeOffers() as well as killExecutors() method. This ensures resource ordering between the threads and thus, fixes the deadlocks.
How was this patch tested?
Manual Tests

cc @squito

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Test build #103606 has started for PR 24134 at commit 29a0481.

Test build #103606 has finished for PR 24134 at commit 29a0481.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103606/
Test PASSed.

thanks @pgandhi999 , merged to branch-2.4 & 2.3.
Can you please close this?

Sure, will close it. Thank you @squito.


long async job logs are too huge

For testnet 0.0.10, during magical hours, too many long async job happens. And those long async job logs occupies most of the log file space. Currently, the maximum size for a log file is 500 MB, and the long async job log itself constitutes ~470MB and there's only 23 of them in 1 file. And that log file only contains ~30 min of log. Those long async jobs are not too long in terms of time (most of those are less than 4s, only 1 is 9s), but their backtrace is enormous. This happens to every block producer in our testnet. We should reduce the size of the backtraces in some way if we want to keep other useful logs.

This commit solves it. https://github.com/CodaProtocol/coda/commit/f089b073743e33da56683ad17b7e0403594bd68b


Added document area component.

The document area, which should appear next to the sidebar and under the nav bar on the dashboard has been added. It uses a placeholder image which will probably be replaced eventually.

good job

GUI placeholder and PDF loader looks good!!

Good job with the responsive resizing!


Xamarin.iOS Unified API Support

This is at least a start to adding Xamarin.iOS Unified API support to the Xamarin Component.

XamarinVS 3.6.x is required (in the Beta channel as of writing)
NuGet 2.8.3 Alpha is required to be installed (just released on nuget.codeplex.com)

Basically, the iOS.csproj is now the Unified API (this should be the default going forward).  There is a copy named iOS-Classic.csproj which is for the old, unchanged classic API.  component.yaml has been updated to reflect the new ios-unified target.  The Xamarin.Auth submodule has also been updated to include its update for Unified API support.
I may be missing some things, I think there may be tooling to build this that is not in the repo.  Also I did not port the Sample app to Unified (we can leave it as a Classic API sample for now, and eventually we should just convert it and drop the classic sample going forward).  I didn't port the Tests either, you may want to do that.
The important thing for now is to get the component updated with Unified support so users of these new project types are not left in the dark!
Thanks!

Latest version of this work is tracked under pull request https://github.com/Azure/azure-mobile-services/pull/545

Version 1.0.1 of the WindowsAzure.MobileServices.SQLiteStore package and version 1.3.1 of the WindowsAzure.MobileServices package both support the unified API.


Project Name
Knative
Project Website
https://knative.dev/
Contact Details 1
@aliok
Contact Details 2
@nainaz
Links to communication channels
https://cloud-native.slack.com/archives/C04LGHDR9K7
Reason for governance review request
Application for moving levels from Incubation to Graduation
Are there any sub-projects, plugins, and related?
Knative has 4 modules:

Serving: https://knative.dev/docs/serving/
Eventing https://knative.dev/docs/eventing/
Functions: https://knative.dev/docs/functions/
CLI: https://knative.dev/docs/client/

Governance model
Knative governance is based on the "The Steering Committee" governance model: https://contribute.cncf.io/maintainers/templates/governance-elections/
Governance documents

Project purpose (partial):

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/README.md#introduction

Maintainer list: (No employer affiliation exist in these files)

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/OWNERS
https://github.com/knative/community/blob/main/peribolos/knative.yaml
https://github.com/knative/community/blob/main/peribolos/knative-extensions.yaml

How your project is making decisions:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/GOVERNANCE.md
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/CONSENSUS.md

How and when contributors are moving through the contributor ladder (e.g. becoming a maintainer)

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/ROLES.md

Maintainer life cycle with information about how and when maintainers are demoted

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/ROLES.md#involuntary-removal-or-demotion

Code of Conduct:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/CODE-OF-CONDUCT.md

Contributor Guide:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/CONTRIBUTING.md

How your community conduct communication and meetings:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/CALENDAR.MD
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/SLACK-GUIDELINES.md,
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/STEERING-COMMITTEE.md#committee-meetings
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/TECH-OVERSIGHT-COMMITTEE.md#committee-meeting
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/README.md#meetings-and-work-groups
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/working-groups/WORKING-GROUPS.md

How your community handles security reporting and response:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/SECURITY.md

Who owns what code and docs:

Each repository has its own owner definition. These are groups. For example, the knative/community repository is owned by the steering committee: https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/OWNERS#L4

Additional:

Project and community values:

https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/VALUES.md
https://github.com/knative/community/blob/7e7b3c26cee0986ef70c46004af3b877c0afb14c/TEAM-VALUES.md

Governance Execution Examples
Election examples:

https://github.com/knative/community/tree/7e7b3c26cee0986ef70c46004af3b877c0afb14c/elections

Voting example (decision making):

https://docs.google.com/document/d/16Rpd2nhmLWrkFJUfpJ31Ox2PpultJ-bYIhqaiWQff_I/edit#heading=h.jlesqjgc1ij3

Promoting a contributor:

https://github.com/knative/community/pull/1414

Demoting a maintainer:

We don't have an example of demoting somebody e.g. because of inactivity
People do voluntarily leave their roles though: https://github.com/knative/community/pull/1395

Security response:

TO BE PROVIDED LATER

Meeting recordings:

TO BE PROVIDED LATER

Governance Evolution
Governance model is the same since I've joined the project.
I believe there has been some changes for the vendor seat cap when Knative joined CNCF, but not sure how relevant it is right now.
There were some WGs that were created and then closed.
The Trademark committee has been dissolved recently. It was created to handle the trademark issues before Knative joined CNCF.
Any specific aspects of your governance structure are you seeking feedback on?
Nothing specific.
Do you have any concerns or specific areas where you feel your governance could be improved?
I personally believe there are a few major things right now:

The Docs WG has been closed, but there is no overarching entity that takes care of the docs. This will be an issue soon.
Maintainer list needs to have employer affiliation.
Some governance docs are outdated (can't give an exact list, but I sometimes see outdated content).
Community calendar has some outdated entries (e.g closed Docs WG meeting)
Meetings are not recorded anymore (or they're not uploaded)
Inactive approvers / WG leads / committee members are not removed. They're kept in the owner files forever.

Not really about governance improvements, but there are a few issues in the community health. We need some governance improvements too, to address these problems:

Red Hat dominance
Not collaborating with CNCF TAGs (App Delivery etc.)
No new contributors

Additional notes and resources
There's also these web pages:

https://knative.dev/docs/community/
https://knative.dev/docs/community/contributing/
https://knative.dev/docs/community/governance/

I'm putting this on hold while we have some discussions with Knative about governance updates

Is this still blocked?  I think the discussion was about consolidating Steering and TOC, which was accomplished in September.

Also FYI a new steering committee election has started.


IP Filtering and Page Not Found package

Feature summary
Hi Nik
Not sure if this is a feature request or a bug.
I have IP filtering set up in the web config of a Umbraco 13.5.2 site. The aim of this is to prevent unauthorized access to the umbraco backoffice. We do not want the public to even see the backoffice login page, we only want vpn access to the backoffice.
I think that the ip filtering, because it is in the webconfig occurs first in the pipeline before your package is loaded and configured in the pipeline.
The package works perfectly as expected except when trying to call the /umbraco directory. It then presents a generic .net style 404 page.
I hope this make sense I can clarify further if required.
Additional details
No response

Ohh, interesting idea.
Yeah currently this wouldn't be possible with the Page Not Found Manager as it's using the Umbraco Content Routing pipeline.
If you used your IP block for the Umbraco back office to redirect to "/not-found" or something like that it would be a work around.
Alternatively you could use a "rewrite" as opposed to a redirect, so it masks it a bit more.
That might help you out, but I'm not sure how PNFM could be modified to do this for you.

No worries Nik,
I can work around it I basically needed to confirm my hypothesis.
Thanks for looking into it.
Excellent package by the way.


bug: Current Prisma singleton doesn't support typings for .$extends

Provide environment information

standard stack setup with Prisma

Describe the bug

current Prisma singleton always infers the Prisma client as PrismaClient
this is problematic when models are extended as it won't pick up on typings for custom methods
the Prisma docs detail a more versatile solution
let me know if there are any objections, otherwise I'll open up an MR

Solution:
import { PrismaClient } from '@prisma/client'

const prismaClientSingleton = () => {
  return new PrismaClient()
}

declare global {
  var prisma: undefined | ReturnType<typeof prismaClientSingleton>
}

export const prisma = globalThis.prisma ?? prismaClientSingleton()

if (process.env.NODE_ENV !== 'production') globalThis.prisma = prisma

Reproduction repo
main
To reproduce

extend the singleton with .$extends
try to access the newly created method
you'll receive a TS error

Additional information
No response

PRs accepted

@andrewpeters9 I just wanted to personally thank you, been looking for a type-safe solution for this everywhere.. 👍🏻


Groups endpoint is providing different information then apps endpoint

I did the same as in #4897 described in the animation. But I actually clicked on cancel. Now the Groups endpoint is delivering me with instances: 2 for the app /test and the apps endpoint of the app is providing me with instances: 0. This is how the marathon UI handles this issue:

Tested locally on current master and both endpoints (groups and apps) give back the right instance count.

In 1.4.0-RC4 This issue seems to be fixed it occurred to me in 1.4.0-RC3


Add option to avoid guiding layout with todos

Trying to solve https://github.com/rubyatscale/visualize_packs/issues/47.

@shageman I'm not super happy with my wording here. Maybe you prefer something different. Let me know if you have something else in mind to solve #47.

Dropping this in favor of https://github.com/rubyatscale/visualize_packs/pull/51. I like that one better because it's opt-in instead of opt-out as this one.


Run build-container on c4xlarge with buildah-remote

Run build-container on c4xlarge with buildah-remote

/retest

/retest

/approve


Change "Multiple" to "Mixed"

Summary

Relevant Technical Choices

To-do

[x] Tests

User-facing changes

Testing Instructions

Fixes #2088

As only one of the text fields has a background color, that color is listed as the background color in both text fields. That seems wrong somehow though?
Edit: I know this is not directly related to this PR, so it could be also just be filed as a new bug.

I now see bug #2338, which kind of capture this, so maybe we don't need to do anything more about this at this point. It's a minor bug, so it's fine to just have it filed.

I now see bug #2338, which kind of capture this, so maybe we don't need to do anything more about this at this point. It's a minor bug, so it's fine to just have it filed.

Addressing #2338 should indeed fix this issue as well. Will send to QA as-is.

Verified in QA


Should "emit -points" stamp points with time if none is present?

Currently if you generate some timeless points with emit -points, time is added to them.
juttle:
emit -points [ { a: 1 }, { a: 2 } ]

output:
┌────────────────────────────────────┬──────────┐
│ time                               │ a        │
├────────────────────────────────────┼──────────┤
│ 2015-12-29T03:52:42.593Z           │ 1        │
├────────────────────────────────────┼──────────┤
│ 2015-12-29T03:52:43.593Z           │ 2        │
└────────────────────────────────────┴──────────┘

I don't think we want to be mutating points the user specified.
Thoughts?

@dmajda please weigh in on this. The behavior of adding timestamps to -points array was surprising to me when I was playing around with join like a new user might. When I thought about it, it made sense since emit always generates points with time... and yet, the initial reaction was consternation.
If we want to keep the behavior, let's make the docs very clear. The current emit doc says
-points	An array of points to stream

with no mention of adding time to them.

It seems to me the default should be to emit timeless points, but if the user specifies a -every option, then emit should timestamp accordinvgly.

-every with -points could also mean emit all of these points every -every seconds instead of one of these points every -every seconds serially. Not sure which is more common/intuitive, just bringing it up.

I agree the behavior is unintuitive. I think its rationale was that -points was mostly used in tests (it replaced old demo ticker there) where the auto-add behavior helped with creating meaningful point sequences.
I tried to comment-out the relevant code and only 8 test failures popped-up, 1 of which was in emit tests. So we don’t depend on the behavior much and I’d vote for changing it. As long as we support timeless points (which I’m not a fan of at all, as some may remember from old discussions), let’s just emit what is in -points verbatim (but still disallow a mix of timestamped and non-timestamped points).

It seems to me the default should be to emit timeless points, but if the user specifies a -every option, then emit should timestamp accordinvgly.

This is little bit too magical. I’d say -every and -points should be mutually exclusive. And if we really have a strong use case for time auto-add, let’s invent a dedicated option to enable that.

@dmajda That sounds good to me.

OK, morphing into a task.

Judging by the issue @dmehra is seeing in her followup comment in https://github.com/juttle/juttle/issues/76#issuecomment-174596640, we should also not emit ticks and if possible, emit all points at once instead of one every second (though the scheduler will probably be in charge of this). From my understanding, whether we emit all the points at the same time or not shouldn't have an effect on the results of any downstream merges and joins since they will wait for an EOF from this stream before proceeding (because all points are timeless).

Agreed with not emitting ticks and emitting all points at once.
@bkutil Could you maybe look at implementing this (if it makes sense before finishing the scheduler work)?


Week 2-Arya Learning Nihongo

Week 2- Day 2- Arya Learning Nihongo

Good Job @AryaCodesAI !!

Good Job @AryaCodesAI !!

Thanks for the support, Shubhi!!


luciferdonghua.in is shutting down soon and starts a new site called  misterdonghua.com

Source information
aniyomi-en.luciferdonghua-v14.6.apk
Source language
English
Source new URL
https://misterdonghua.com/
Other details
luciferdonghua.in is shutting down and starts  a new site called
misterdonghua.com
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL is not updated yet.
[X] I will fill out all of the requested information in this form.

They already shut it down

The domain link works correctly


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/908 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 9a60bff:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-06-11-06-11-13 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Unable to work with React 16.0.0

React-Splitter don't work with React 16.0.0. This throw a new => Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null at Splitter.getSize.

Hello, that is odd. I tried it in React 16 without any issue. I will try to investigate this issue later today. Thank you :)

Hello, thanks for your quick answer. Ok, strange, because impossible for me to run with react 16.0.0 and when I downgrade to 15.6.1 that's good. Thanks

Hello again, I tried splitters with React 16 and it seems ok. Could you please provide some example branch where I could try it? Thank you

Getting same error on this line:
var primaryPane = ReactDOM.findDOMNode(this.panePrimary).getBoundingClientRect();
Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
at Splitter.getSize (Splitter.js:45)
at Splitter.handleMouseDown (Splitter.js:117)
at onMouseDown (HandleBar.js:22)

I will have a look at this later today, thank you

Please install new version of this package

I still see this issue, with latest package v1.2.0, using React 16.7.
See issue: https://github.com/martinnov92/React-Splitters/issues/20

I'm also facing the same issue that can't read property 'getBoundingClientRect' of null. Whenever I click on the section separator/resize the panels.
I'm using following versions:
"m-react-splitters": "^1.2.0",
"react": "^16.6.3"
Please provide me the solution or case handling as soon as possible.

Thank You

Hi @martinnov92 here is my sample snippet also which properties i'm using.

Whenever I even clicked on the separator it generates an error, also when resize the panel.
One more thing, especially when I'm on other page and then visit on this particular page, it generates the above mentioned error of 'getBoundingClientRect' of null.


fontconfig didn't create the folder

Hi again,
Yesterday I've made a horrible mistake of corrupting my filesystem and had to re-install with using same configurations.
One thing I've realized with my user, after switching the new home-manager generation, didn't have .config/fontconfig folder, so I've copied over my backup. But later realized next generations are touching files under it:
lrwxrwxrwx 1 gurkan gurkan 105 Apr 29 08:42 .config/fontconfig/conf.d/10-hm-fonts.conf -> /nix/store/z0lzl9cf4lzv2h4zj23120l7ll0i7ws5-home-manager-files/.config/fontconfig/conf.d/10-hm-fonts.conf

After checking saw the file is defined here and wanted to ask if this is expected or not.
https://github.com/rycee/home-manager/blob/master/modules/misc/fontconfig.nix#L85
P.s. thanks for home-manager again, my whole desktop was basically ready after re-installation :smile:

Forgot to mention, I have following line in the HM config:
fonts.fontconfig.enable = true;

Sorry to hear about the corrupted file system and glad to hear you like Home Manager 🙂
If I understand the issue correctly you have fonts.fontconfig.enable = true in your configuration but home-manager switch did not create ~/.config/fontconfig/conf.d/10-hm-fonts.conf? Could you run home-manager -v switch and check if 10-hm-fonts.conf shows up in the output?

Hmm, yeah it actually shows up and whatever I delete (file or parent folder) it replaces.
Closing this one, I'll re-open if I can see something reliably failing :thinking: Sorry for the confusion.


npm package containing coverage report html files causes issues with building

NPM packages for recent version 5.3.0 and 5.3.1 seem to include coverage reports under node_modules/redux-form/coverage/lcov-report/ which cause build issues on Meteor:
node_modules/redux-form/coverage/lcov-report/src/events/__tests__/createOnBlur.spec.js.html:1:    Can't set DOCTYPE here.  (Meteor sets <!DOCTYPE html> for you)
Work around is to manually remove coverage folder, but is there specific reason why this is included in the package ?

Oops. Sorry about that.


Radio field marks all radio options with red asterisk when required

Bug report
What I did
When I use radio buttons options for a required field, backpack adds asterisk to all options.

??
What I expected to happen
It should add asterisk to the title only.
??
What happened
But, It adds asterisk to all options along with title.
??
What I've already tried to fix it
??
Backpack, Laravel, PHP, DB version
backpack/crud": 4.1

Thanks @zobay
I could confirm the error.
I'v submited #3469 to fix it.
Wish you the best,
Pedro

Thanks @zobay
I could confirm the error.
I'v submited #3469 to fix it.
Wish you the best,
Pedro

@zobay the PR that fixes this have been merged into master and will soon be tagged. When it does, you need to update backpack and republish assets:
https://backpackforlaravel.com/articles/tips-and-tricks/once-in-a-while-re-publish-backpack-s-css-and-js-assets
Best,
Pedro

@zobay the PR that fixes this have been merged into master and will soon be tagged. When it does, you need to update backpack and republish assets:
https://backpackforlaravel.com/articles/tips-and-tricks/once-in-a-while-re-publish-backpack-s-css-and-js-assets
Best,
Pedro


Multiple independent instances of the ordering software can operate simultaneously

There will be multiple versions of this software running on different tablets simultaneously. Different users will be making different orders and therefore should not affect each other byond stock totals diminishing upon finalization.
Acceptance Criteria

[ ] Independent instances on different hardware can be in progress simultaneously
[ ] Credit deductions in one instance do not affect the credits of another instance.

@bglusman Should this be in review now?


Gitlab CI is always using gcc even when asked for Clang!

See https://lc.llnl.gov/gitlab/smith/serac/-/jobs/161492/raw

Are you talking about printing out the spec? uberenv has always done that.  If you scroll down its using clang to do the actual compiles.

Are you talking about printing out the spec? uberenv has always done that.  If you scroll down its using clang to do the actual compiles.

... but why? Why "uberenv has always done that"?

... but why? Why "uberenv has always done that"?

All that time using Uberenv and I wouldn't have noticed... ?

All that time using Uberenv and I wouldn't have noticed... ?

Dunno. it should be fixed but it just does? =)

Dunno. it should be fixed but it just does? =)

Closing since the build indeed uses Clang.

Closing since the build indeed uses Clang.

@white238 I think I found something:
There are in facts 2 calls to uberenv in the build script, on with --create-mirror, but an empty spec, and then a second one with the spec. For some reason (nested processes?) the second call does not print the spec.
So this is not uberenv, it's the serac build script.

@white238 I think I found something:
There are in facts 2 calls to uberenv in the build script, on with --create-mirror, but an empty spec, and then a second one with the spec. For some reason (nested processes?) the second call does not print the spec.
So this is not uberenv, it's the serac build script.

ah yea... we could add that to the build_tpls.py script.  That explains why i always see it and you didnt. I rarely call uberenv directly

ah yea... we could add that to the build_tpls.py script.  That explains why i always see it and you didnt. I rarely call uberenv directly

not shame, responsibility maybe ;)

not shame, responsibility maybe ;)


atom-fsharp Package Configuration

[x] Toggle Error Panel
[x] Toggle Type Info Toolbar

Released in 0.10.0


SSH jump server: Can't change destination host port (always uses 22)

I just tried the new "jump server" option in the connections settings and hit a bug. The client always tries to connect to port 22 on the final server, regardless what I try to set as Port.
The connection to the jump server uses the correct IP/Port combination, which I enter in the settings page, but the next hop always tries to connect to Port 22. Or do I have to enter the changed port of the final destination server in another configuration field?

Verified


Add regression test for GH-1647

Closes #1686.
This asserts that the package is cached to avoid the problem with the prior test (where it passed when it should have failed—see https://github.com/jazzband/pip-tools/pull/1649#discussion_r939591090).
Contributor checklist

[x] Provided the tests for the changes.
[ ] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[ ] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Rebased onto master, (hopefully) fixed the Windows incompatibility, and force pushed.

Rebased onto master, (hopefully) fixed the Windows incompatibility, and force pushed.

I rebased onto master and fixed the Windows incompatibility.


Interpolate table values without if-else statements

The recommended way of using an if-else check in ModellingToolkit is to use the IfElse.ifelse function.
However, this is not possible in our interpolate function, because we can potentially evaluate a position outside of the range. If this is the case, we get a BoundsError.
Currently, our workaround is to use Tuples, which allows the interpolate function to be called only after the variables were already evaluated.

In b45cd29, I created a branchless version of interpolate using a boolean mathematical expression. This solves the problem, but the solution now is very very slow.

Using explicit types in the moment of registration, as done in ab2c0e8, gives us a huge speed-up.

I wonder if, instead of using a loop as in b45cd29, construting the linear interpolation by building the expression with Meta.parse and then feeding it into Meta.eval could improve.

@natema Since the problem was effectively solved, I'm closing this issue. It would be great if you can create a new issue for the suggestion of using metaprogramming.


Products - Add feature to limit the seat count globally

Feature Request
Is your feature request related to a problem or unsupported use case? Please describe.
Currently, for a product, we do not limit the number of seat but we have use case where we want to block purchase once a number of orders has been reached.
Describe the solution you'd like
To add this feature, we could add a PositiveSmallIntegerField called max_validated_orders to the CourseProductRelation model:

[ ] Add a PositiveSmallIntegerField called max_validated_orders to the CourseProductRelation model. The field should be required and should default to 0 (no maximum)
[ ] Add a check to ensure that we never exceed the max number of validated orders for a product on a given course.Secure it with a test.
[ ] Make sure the API returns a 400 if the client tries to validate an order for a product on a course that already exceeds the limit. Pending orders (waiting for payment) should count in the max so that we are sure an order can be validated after payment! Secure it with a test.

Hi.
If max_validated_orders is set to 0, would that mean that no order can be filled at all, or would it be a special value meaning that there is no limit ?

Hi @samy-aitouakli.
If the value is 0, it means there is no limit.

Thanks @jbpenrath
I forgot to ask, through which query should max_validated_orders be set ?

Not quit sure to understand exactly what you mean by which query ?
Within the scope of this issue, the max_validated_orders will be set through django admin in the edit change view of CourseProductRelation.

Closed by #301


Support import gzip json file

In terms of implementation I have some concerns about isGzip variable passed through all classes. not sure yet is this a best way or there is another better one. @mvar @murnieza ?

First, I did, I named it 'dataType', it could be XML, GZIP or any format. Then I thought 'isGzip' could reflect directly our expectation. For further extension, I think 'dataType' is OK.

@saimaz me too. What if in the future we need to add more options? Maybe we should pass $options array here?
@ndinh215 have you noticed, that you created this PR in your fork?

@mvar, this branch is based on the newest master in my repo. I still wait for the reviewing the issue https://github.com/ongr-io/ElasticsearchBundle/pull/535, then I will merge and then create new PR for this issue.

I also think that all options (should we call it context?) should be passed around in one array but not separately.

So now, there are many names: 'options', 'context', 'params' ... for options array.
So which name do you prefer? @saimaz

Maybe function should look loke this: protected function getReader($manager, $filename, $convertDocuments, $options)

OK, thks @saimaz

I complemented this with the param 'options'. Could you please review again these changes?@saimaz


update validation icons, tooltip, and behavior

update validation icons, tooltips, and behavior.

closing in favor of #590


Help with NUTEditor

How do I use NUTEditor, like, how do I even open it?

https://github.com/marcussacana/SacanaWrapper
or
https://marcussacana.github.io/Sermone/


No error reported when sync fails due to full harddrive.

Bug description:
Failure when synchronizing with full harddrive produces no error or indication that synchronization failed.
Actual Behavior:
When HD is full when syncing, no apparent issues are being reported, but the graph is missing the latest updates. Only tested when previous synchronizations are available locally.
Expected Behavior:
Error message or notification when latest activities does not get synced properly.
Steps to Reproduce:
Fill up HD with junk and windows update-garbage.
Resync.
Chrome version
Version 62.0.3202.9 (Officiell version) dev (64 bitar)
Plugin version:
Don't know. Latest as of september 9th.

@theed Thanks for report
I would say that this warning has to come from windows, MacOS or linux before this web plugin :)


Added render prop component suggestions

Added suggestions for the render prop components, along with some (naive) implementations. This can serve as a starting point for discussion.

@EECOLOR Agreed, we're accessing multiple values from multiple forms so useFieldsValues makes sense.
I'll see if I have some time to update the docs this week.

@EECOLOR Is see I missed a rename earlier: useFieldState should be useFormFieldState to be consistent with the naming of other hooks. Since they are undocumented, can we rename them? Maybe as a separate PR.

@EECOLOR What happens if you want to render 0 as a value? Right now it would return null. Should we change the check here?
export function FormFieldValue({ field, render }) {
  const value = useFormFieldValue(field)
  return render(value) || null
}

Since they are undocumented, can we rename them? Maybe as a separate PR.

Yes, separate pull request and major version change.

What happens if you want to render 0 as a value? Right now it would return null. Should we change the check here?

Yes, we should


Is NamedExec a transaction?

Hello. Is sqlx.DB.NamedExec() a transaction? Is there a case where only part of the data is inserted? Or is it either all or none of it inserted? Looking forward to your reply, thank you!

After testing, I think it is transaction operation. However, id self-growth has been completed.


Added enrol and expel functionality for CCAs

Closes #50
However, no way to save PID and CID yet, and pid and cid are not displayed in UI

LGTM


Lag while exiting full screen for a particular epub file

Setup or portable version of the app?
Portable
Steps to reproduce
A couple issue I found while reading.

Open the epub files in the acutal behavior and expected behavior.
Enter and exit full screen.
The second epub file is causing lag while exiting full screen.

✔ Expected Behavior
First EPUB - Grandmster of demonic v01
https://github.com/mienaiyami/yomikiru/assets/127277950/722c8f65-9170-41d7-b846-7779912bab71
❌ Actual Behavior
Second EPUB - File causing the title behavior
https://github.com/mienaiyami/yomikiru/assets/127277950/dfefa032-6000-4e3d-bac4-808c81e1fe00

Cant be fixed.


Delete plutus-prototype

I maintain that there's no reason for us to have this.

We're not referring to it for future work, since we've now diverged pretty far from the version of Plutus it implements.
We're not planning to ever work on it in future, so there is no point keeping it compiling.
Nobody who's not looking for it specifically is going to be interested in it, and for those who do want it we can easily point them at a commit where it exists.

The Cardano folks do mysteriously depend on it, but they have their own fork that is anyway pinned to an ancient commit, so they're effectively pulling it from history anyway.

(This would be green if we removed plutus-protoype from the required checks, which of course we would do if we were going to do this :) )


global: fix require order.

Fixes https://github.com/Homebrew/brew/issues/17723

@MikeMcQuaid unfortunately it's not quite a complete fix. I'm getting:
> brew upgrade
==> Auto-updating Homebrew...
Adjust how often this is run with HOMEBREW_AUTO_UPDATE_SECS or disable with
HOMEBREW_NO_AUTO_UPDATE. Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/extend/kernel.rb:288:in `which': uninitialized constant Kernel::PATH (NameError)
        from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/os.rb:71:in `<module:OS>'
        from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/os.rb:7:in `<top (required)>'
        from <internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from <internal:/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
        from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/global.rb:118:in `<top (required)>'
        from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:18:in `require_relative'
        from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:18:in `<main>'

from this now.

I think, on line 288 in extend/kernel.rb you want:
path.new(path).filter_map do |p| not PATH.new(path).filter_map do |p|

@ianchesal should be fixed by https://github.com/Homebrew/brew/pull/17737


IPv6 doesn't do throttling

The throttle functionality is triggered based on a uint32_t variable. Therefore it doesn't work with IPv6.

I am in the process of merging in one of my existing IPv6 libraries which I used for properiatary projects. and relicense it to MIT This library allows for conversions between IPv6 and a struct of two uint64_t values which together represent an 128 bit IPv6 address. Unfortunately uint128_t support is not universal yet which would make it a lot easier. The library also supports transparant IPv4 use in the ::FFFF:0:0/96 range and several compressed and uncompressed string notations of IPv6 addresses. All IP address level functionality in LibHTTP should be converted to using the two uint64_t struct to use it to manage throttling and access control.


[Plot] Improve right axis support

This PR improve right axis support:

Closes #253
Fix right axis support in pixelToData, dataToPixel methods
Add support of aspect ratio for right axis

It also make mpl backend use getDataRange (instead of duplicate internal method) and it fixes getDataRange under certain conditions: image scale < 0, log axes.
It still misses non-regression tests.

Add tests, thanks @dnaudet!
Ready for review

Ok for me


MGDOBR-466: Update keycloak configuration to use rh sso

https://issues.redhat.com/browse/MGDOBR-466
The integration with rh sso is completed. Updating keycloak config accordingly.
Steps to test it:

npm run start
rh login screen appears instead of our keycloak one

Thank you for a PR. Is it expected, we do not remove any settings related to previously used user - kekkobar?

Hi @jomarko, we'll not use the kekkobar user anymore. So it's safe to remove any settings related to it.

@jomarko couldn't you use the mocked version of the app for E2E tests? then you could skip the authentication part entirely.

@kelvah well, probably yes. It is more question for @sjamboro as she is preparing the "first version" of a test. For me, yes, lets skip keycloak in tests if that is possible. @kelvah is that done by some single system property?

we can have single tests that check SSO work. I mean

login
wait home screen is loaded

@kelvah @jomarko, I was waiting on the start:mocked script. Now, it is used see https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox-ui/pull/32/commits/4a900f7e755c54459a6c70296b613ea6b5a05464
I saw some ERRORs around keycloak. I will investigate it and rebase my branch on the top of main.


[android demo] Fix applicationId to 'org.tensorflow.demo'

For nativeBuildSystem == 'cmake' change applicationId = 'com.tensorflow.demo' to applicationId = 'org.tensorflow.demo'
Otherwise Android system treat bult app (com.tensorflow.demo) as separate one and install it alonside to org.tensorflow.demo

Can one of the admins verify this patch?


The get requests to aspenone from BaseHandlerWeb.fetch does not work with Swedish characters

I can not fetch data for tags which contains Swedish characters.
I get warnings like below and do not get out any data for requests like c.read(tags=["åäö"],start_time=start_time, end_time=end_time, ts=1):
2024-03-12 16:07:59 WARNING  awt             API error for åäö: Tag Name %C3%A5%C3%A4%C3%B6 is invalid params: <Q f="d" allQuotes="1"><Tag><N><![CDATA[åäö]]><[/N](http://localhost:8889/N)><D><![CDATA[IP21]]><[/D](http://localhost:8889/D)><F><![CDATA[VAL]]><[/F](http://localhost:8889/F)><HF>0<[/HF](http://localhost:8889/HF)><St>1710169584000<[/St](http://localhost:8889/St)><Et>1710255984000<[/Et](http://localhost:8889/Et)><RT>1<[/RT](http://localhost:8889/RT)><S>0<[/S](http://localhost:8889/S)><P>10<[/P](http://localhost:8889/P)><PU>3<[/PU](http://localhost:8889/PU)><[/Tag](http://localhost:8889/Tag)><[/Q](http://localhost:8889/Q)>

I have created my client like this:
c = tagreader.IMSClient(datasource="IP21",
                       url="http://my.domain/ProcessData/AtProcessDataREST.dll",
                       imstype="aspenone",
                       auth=auth,
                       tz=pytz.timezone("UTC"))

I have notices that when playing with the queries that is handles Swedish characters on post requests where the parameters as sent as data and not in the URL. So that kind of post requests seems to be more robust. I have verified that it works with post requests by hacking a bit in the tagreader code in  web_handler.py  - BaseHandlerWeb.fetch to something like below (but the sample code only works when params is a string). The encoding is needed to get correct size of the payload:
        res = self.session.post(
            url,
            data=params.encode("utf-8"),
            timeout=(
                None,
                timeout,
            ),
        )  # Noqa. Read timeout, No connect timeout.

I created some minor code changes which works better for me regarding Swedish characters in tags:
https://github.com/daha/tagreader-python/commit/8f7277a9c4adf17ffa4848be75c4e59565da1edf

Hello Daha,
I apologize for the late answer. Tagreader has been on the back-burner for a while as the responsibility for it has jumped around a bit internally.
Considering this software was initially built for Equinor who has all their tags in English, it might be an issue that went under the radar during development. It is not a priority fix for us, as we have to prioritize our tasks based on our budget, but I am happy you found a workaround. If we get some time to fix the issue in the future I will update you, until then I will close the issue.