Random auto-create address | Can't delete address | Renaming label issues

1)I just did my first transfer from Binance to QT wallet to an address (labelled "XY" for example), and the wallet created automatically another address without label.
2)If i rename the "XY" label, the automatically created address i wrote in point 1 get automatically renamed with the same name... (usually after 2 renames).
3)I can't see a way to remove/delete an address.

钱包经常提示病毒

I confirmed issue 2 and 3 against e544296b (latest)

There were issues with the older versions of wallets , and according to #235  it was resolved.  @justinvforvendetta can close this .. or @ciuccia can close too please!


refactor(SplitPanel): Reduce the box metrics usage to reduce browser reflow

Just made some refactoring to reduce the usage of box metrics properties.
It will reduce browser layout reflows
https://gist.github.com/paulirish/5d52fb081b3570c81e3a
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks


Workaround for extension errors not shown during initial render

Background
Address issue https://github.com/Shopify/ui-extensions/issues/325
Solution
This PR is a port of @marvinhagemeister done at the source.
https://github.com/Shopify/checkout-web/pull/11674
I've also set the same logs in the customer-account-ui-extensions-react which is a recent copy of the Checkout render function.
Checklist

[x] I have :tophat:'d these changes
[x] I have updated relevant documentation

@jffortier Thank you so much for adding these workarounds here too! Wasn't aware that we had similar codepaths here 👍


Boostrap for 1.29.0 fails with "Unknown flag --manifest-path"

I am trying to boostrap rustc 1.29.0 with the 0.9 release of mrustc.
I can build mrustc just fine. I have aliased minicargo as cargo to ease a bit of the plumbing in our rust boostrap code.
Whenever I try to start building rust 1.29.0 it fails building the "real" cargo with the below output. I am wondering why nobody else every ran into this since it seems pretty "normal" for 1.29.0:
Unknown flag --manifest-path
failed to run: /nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mrustc-0.9/bin/cargo build --manifest-path /build/rustc-1.29.0-src/src/bootstrap/Cargo.toml --frozen

Looking at TestRustcBootstrap.sh I don't see an obvious difference in how things are being build.
Complete log:
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/bhcydl21b28x9rynd8v1wvc5gkl8rp2k-rustc-1.29.0-src.tar.gz
source root is rustc-1.29.0-src
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file rustc-1.29.0-src/src/vendor/winapi-i686-pc-windows-gnu/src/lib.rs
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
patching script interpreter paths in src/etc
src/etc/generate-deriving-span-tests.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/496hlkwcniy4yi3nix0cps43a3ll2c11-python-2.7.17/bin/python"
src/etc/generate-keyword-tests.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/496hlkwcniy4yi3nix0cps43a3ll2c11-python-2.7.17/bin/python"
src/etc/indenter: interpreter directive changed from "/usr/bin/env python" to "/nix/store/496hlkwcniy4yi3nix0cps43a3ll2c11-python-2.7.17/bin/python"
src/etc/cat-and-grep.sh: interpreter directive changed from "/bin/sh" to "/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/sh"
src/etc/rust-lldb: interpreter directive changed from "/bin/sh" to "/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/sh"
src/etc/rust-gdb: interpreter directive changed from "/bin/sh" to "/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/sh"
src/etc/installer/pkg/postinstall: interpreter directive changed from "/bin/sh" to "/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/sh"
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
configure flags: --prefix=/nix/store/9jlwjhrnyiqnl976wv9wd0mdlj8ryhrp-rustc-1.29.0 --release-channel=stable --set=build.rustc=/nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mrustc-0.9/bin/rustc --set=build.cargo=/nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mrustc-0.9/bin/cargo --enable-rpath --enable-vendor --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu --target=x86_64-unknown-linux-gnu --set=target.x86_64-unknown-linux-gnu.cc=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.cc=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.cc=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.linker=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.linker=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.linker=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/cc --set=target.x86_64-unknown-linux-gnu.cxx=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/c++ --set=target.x86_64-unknown-linux-gnu.cxx=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/c++ --set=target.x86_64-unknown-linux-gnu.cxx=/nix/store/l2sqva7kzr8y68lji2aajk2s8017jyq4-gcc-wrapper-8.3.0/bin/c++ --enable-llvm-link-shared --set=target.x86_64-unknown-linux-gnu.llvm-config=/nix/store/gr4154kyvnx3fjs07mz4lxxpakxw51s8-llvm-9.0.0/bin/llvm-config --set=target.x86_64-unknown-linux-gnu.llvm-config=/nix/store/gr4154kyvnx3fjs07mz4lxxpakxw51s8-llvm-9.0.0/bin/llvm-config --set=target.x86_64-unknown-linux-gnu.llvm-config=/nix/store/gr4154kyvnx3fjs07mz4lxxpakxw51s8-llvm-9.0.0/bin/llvm-config --enable-profiler
configure: processing command line
configure:
configure: llvm.link-shared     := True
configure: build.rustc          := /nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mr ...
configure: build.cargo          := /nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mr ...
configure: target.x86_64-unknown-linux-gnu.cc := /nix/store/l2sqva7kzr8y68lji2aaj ...
configure: target.x86_64-unknown-linux-gnu.cc := /nix/store/l2sqva7kzr8y68lji2aaj ...
configure: target.x86_64-unknown-linux-gnu.cc := /nix/store/l2sqva7kzr8y68lji2aaj ...
configure: target.x86_64-unknown-linux-gnu.linker := /nix/store/l2sqva7kzr8y68lji ...
configure: target.x86_64-unknown-linux-gnu.linker := /nix/store/l2sqva7kzr8y68lji ...
configure: target.x86_64-unknown-linux-gnu.linker := /nix/store/l2sqva7kzr8y68lji ...
configure: target.x86_64-unknown-linux-gnu.cxx := /nix/store/l2sqva7kzr8y68lji2aa ...
configure: target.x86_64-unknown-linux-gnu.cxx := /nix/store/l2sqva7kzr8y68lji2aa ...
configure: target.x86_64-unknown-linux-gnu.cxx := /nix/store/l2sqva7kzr8y68lji2aa ...
configure: target.x86_64-unknown-linux-gnu.llvm-config := /nix/store/gr4154kyvnx3 ...
configure: target.x86_64-unknown-linux-gnu.llvm-config := /nix/store/gr4154kyvnx3 ...
configure: target.x86_64-unknown-linux-gnu.llvm-config := /nix/store/gr4154kyvnx3 ...
configure: build.vendor         := True
configure: build.target         := ['x86_64-unknown-linux-gnu']
configure: rust.channel         := stable
configure: rust.rpath           := True
configure: build.host           := ['x86_64-unknown-linux-gnu']
configure: build.profiler       := True
configure: install.prefix       := /nix/store/9jlwjhrnyiqnl976wv9wd0mdlj8ryhrp-ru ...
configure: build.build          := x86_64-unknown-linux-gnu
configure: build.configure-args := ['--prefix=/nix/store/9jlwjhrnyiqnl976wv9wd0md ...
configure:
configure: writing `config.toml` in current directory
configure:
configure: run `python /build/rustc-1.29.0-src/x.py --help`
configure:
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: SHELL=/nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/bash
Unknown flag --manifest-path
failed to run: /nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mrustc-0.9/bin/cargo build --manifest-path /build/rustc-1.29.0-src/src/bootstrap/Cargo.toml --frozen
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:28: all] Error 1

That looks supisciously like /nix/store/55vdqaa8jh1zbpy6pz4wm7bh2zkxyg6y-mrustc-0.9/bin/cargo is actually mrustc's minicargo
minicargo is not a drop-in replacement for cargo (just like mrustc isn't a drop-in replacement for rustc), What script are you using to build? TestRustcBootstrap.sh should be using a mrustc-built copy of rustc/cargo (not directly using mrustc/minicargo)

Oh! I guess I'll have to build cargo first then. Some how I had the impression minicargo would be suitable to build cargo but not all the complicated cases cargo supports.

There are makefiles in run_rustc that build rustc and cargo, which are then used to do the full 1.30 bootstrap.


[Admin] (links) Fix broken links.

Addresses #586, #587.

Docs Build status updates of commit cc6ddb4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/security-requirements.md
:white_check_mark:Succeeded

docs/add-ins/outlook-addin-design.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Prevent RedHat supported icon on application card title from being alone on a line

Description

Fix: https://github.com/opendatahub-io/odh-dashboard/issues/879
Split application card title string so that the last word is always on the same line as the RedHat supported icon.
How Has This Been Tested?

Hard coded sample titles to test edge cases

Short title (title less than card width)

icon should be inline with title with no overflow

Long title (title 1.5 times the card width)

icon should be inline with the overflowed text on the second line

Goldilocks title (title exactly the width of the card)

this previously caused the icon to overflow to the next line alone
now the last word in the title and the icon should overflow to the next line

Compare with previous build to verify title and icon alignment is the same

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

FWIW -- I am not a huge fan of the padding override -- I have followed up with PF here: https://patternfly.slack.com/archives/C4FM977N0/p1676392165096129


Deprecated CRD_beta1 API is used

Describe the bug
use of deprecated API:

https://github.com/knative-sandbox/eventing-camel/blob/master/config/300-camelsource.yaml#L15

Expected behavior
use of v1
Knative release version
all
Additional context
Starting w/ k8s 1.22 the v1beta1 of the CRD API is no longer around

Closing this as per https://github.com/knative-sandbox/eventing-camel/pull/97.


Update Kusto to 0.5.2 RC1

This PR fixes #
Link to build containing VSIX
https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=99724&view=results

@abist I uploaded the VSIX since I'm doing the insiders update right now so you can just update the gallery when you get a chance


Fixed erroring issue with security/mk-cacerts.sh

This allows us to run security/mk-cacerts.sh from the curl project without needing to modify mk-ca-bundle.pl manually to avoid error

nvm: realized that there is a version of 'mk-ca-bundle.pl' within the adopt project which works fine


TypeError involving margins when to_streamlit() is used

Thank you for the amazing package.
I'm trying to reproduce the code under the Streamlit usage section and I'm getting a TypeError: convert() missing 1 required positional argument: 'margins'.
I tried to overcome this by passing the margins as an argument to the to_streamlit() function. But, I found that margins is not supported as an argument. I went through the code in idendrogram-streamlit and saw that margins is Optional and that defaults are defined. But, I'm not sure how or why the error occurs.
Code to reproduce the error:
import idendrogram
import scipy.cluster.hierarchy as sch
from idendrogram.targets.streamlit import to_streamlit

from sklearn.datasets import load_iris
data = load_iris()

#cluster the data
linkage_matrix = sch.linkage(
    data['data'], method='single', metric='euclidean'
)
threshold = 0.8
flat_clusters = sch.fcluster(
    linkage_matrix, t=threshold, criterion='distance'
)

#wrap clustering outputs / parameters into a container
cl_data = idendrogram.ClusteringData(
    linkage_matrix = linkage_matrix,
    cluster_assignments = flat_clusters
)

#pass to idendrogram and create a dendrogram object
idd = idendrogram.idendrogram()
idd.set_cluster_info(cl_data)
dendrogram = idd.create_dendrogram(truncate_mode='level', p=10)

#visualize in streamlit and get the data object behind the selected node
selected_node = to_streamlit(dendrogram=dendrogram, height=200, width=629)

Any help on how to solve this would be extremely appreciated! Thanks!!

@sowmyamanojna - thank you for reporting this. It seems I forgot to update the main package to reflect the changes in the Streamlit component API. I'll fix and release an updated version, but in the meantime, you can get it working by replacing the to_streamlit method with a bit more boilerplate code. Here's your example that should work:
import idendrogram
import scipy.cluster.hierarchy as sch
from idendrogram_streamlit_component import StreamlitConverter
import streamlit as st

from sklearn.datasets import load_iris

data = load_iris()

# cluster the data
linkage_matrix = sch.linkage(data["data"], method="single", metric="euclidean")
threshold = 0.8
flat_clusters = sch.fcluster(linkage_matrix, t=threshold, criterion="distance")

# wrap clustering outputs / parameters into a container
cl_data = idendrogram.ClusteringData(
    linkage_matrix=linkage_matrix, cluster_assignments=flat_clusters
)

# pass to idendrogram and create a dendrogram object
idd = idendrogram.idendrogram()
idd.set_cluster_info(cl_data)
dendrogram = idd.create_dendrogram(truncate_mode="level", p=10)

# visualize in streamlit and get the data object behind the selected node
converter = StreamlitConverter(release=True)
selected_node = converter.convert(
    dendrogram,
    height=500,
    width=500,
    scale="linear",
    key="idendrogram",
    orientation="top",
    show_nodes=True,
    margins={"top": 50, "bottom": 50, "left": 50, "right": 50},
)

st.write(selected_node)

The issue is now fixed. Upgrading to version 0.2.5 of idendrogram-streamlit-component  will resolve it and the previous code should work as intended, too.

That's amazing. Thank you so much!


Dependencies - always include Flask

Fixes #5468

Codecov Report

Merging #5471 (c1a4d05) into master (5675994) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5471   +/-   ##
=======================================
  Coverage   96.09%   96.10%
=======================================
  Files         724      724
  Lines       71996    72000    +4
=======================================
+ Hits        69188    69192    +4
  Misses       2808     2808

Flag
Coverage Δ

servertests
35.82% <ø> (+<0.01%)
:arrow_up:

unittests
96.03% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/cloudfront/responses.py
100.00% <0.00%> (ø)

moto/cloudformation/parsing.py
97.28% <0.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I agree with the comment left on the issue raised about the Flask missing in moto: https://github.com/spulec/moto/issues/5468#issuecomment-1257920045
Having the flask dependency in the main moto package looks weird to me as it is not supposed to run any HTTP server. The moto[server] package is the one needed for that. Maybe a documentation fix would be the correct fix. WDYT?

Thanks for the feedback @marcaurele - as of moto >= 4.0.6.dev9, this change is reverted. If someone starts the MotoServer without having the correct dependencies, a warning will be raised to inform them to use moto[server].


Add "ActivityType" property to "Activity" model to support new Activity workflows

Fixes #505.
Note: This PR may need to be merged into a feature branch instead of Master
This PR  is a pre-requisite for issues #506, #507 & #508 and provides the following:

[x] Add "ActivityTypes" enum with entries for the different activity types (ActivityManaged, TaskManaged, DeploymentManaged).  Note that per @tonysurma in #504 these names may be changed.
[x] Add "ActivityType" property to "Activity" model
[x] Create database migration script
[x] Add "ActivityType" to  admin add/edit dialog for Activity

If this were merged into "master" the only functionality change in the app visible to the user would be the "ActivityType" field appearing in the admin add/edit for Activity.  This property is not yet acted on by the rest of the app.  If this needs to be merged into a feature branch and I need to submit a different PR, please advise.

Looks good to me. :shipit: The AppVeyor failure is just more spurious errors from the scenario tests.

I kicked off a fresh build

@BillWagner @MisterJames @dpaquette @mheggeseth I pushed a change, here, that attempts to fix the scenario test issue with "Test: The Org Admin can create activies".  The test now runs successfully on my local machine, but is timing out when appveyor runs it.  I have pretty much reached my level of knowledge on this scenario test issue.  Assistance would be appreciated.

I feel like the scenario tests get a bit fussy when you instruct it to interact with the UI via element text content rather than by CSS selector. See the change I made in #491. Maybe try something similar here.

@BillWagner @MisterJames @dpaquette @mheggeseth Per @mheggeseth's suggestion above I changed the click function on the failing test to use a class selector, but the test still runs successfully, but times out when run by appveyor.
Could this have anything to do with the fact that this PR introduces a model change that necessitates a database migration?  When the app is kicked off in order to run the scenario tests does the database migration execute?

Hello all, I want to merge this PR but not sure on the test failure.  As for the migrations statement the appveyor build creates a new instance and all migrations run so that shouldn't be the issue

@BillWagner @mheggeseth etc. what say we on merging despite error.  Sounds like we should be okay to merge but want to double check.  thx

The error is a timeout. I'll merge, and let's see what happens. If the build keeps failing, let's either fix the conveyor tests, or disable them for the moment.


Add cfon/cfoff commands

To turn on/off cf-ps1, I added cfon/cfoff commands like kubeon/kubeoff (implemented in jonmosco's kube-ps1) respectively.

Thanks!!


Undefined Symbols when importing with SwiftPM

Xcode 2.5 (12E262)
Swift 5.4
SwiftPM - Xcode's Bundled version
Project Minimum iOS Version: 13
filestack-ios: 2.7.2
When importing the library using Xcode's UI for adding Swift Packages to our iOS Target, we add the following code:
import Filestack
import FilestackSDK

extension ViewController {
  private func doSomething() {
    let client = Client(apiKey: "")
    print(client)
  }
}

when we build, Xcode gives us the following errors:
Undefined symbols for architecture arm64:
  "type metadata accessor for FilestackSDK.Client", referenced from:
      Peek_Pro.PKViewOrderViewController.(doSomething in _0192BE462E8B9F880CB09CA425A161D1)() -> () in PKViewOrderViewController.o
  "FilestackSDK.Client.__allocating_init(apiKey: Swift.String, security: FilestackSDK.Security?) -> FilestackSDK.Client", referenced from:
      Peek_Pro.PKViewOrderViewController.(doSomething in _0192BE462E8B9F880CB09CA425A161D1)() -> () in PKViewOrderViewController.o
ld: symbol(s) not found for architecture arm64

Undefined symbol: type metadata accessor for FilestackSDK.Client
Undefined symbol: FilestackSDK.Client.__allocating_init(apiKey: Swift.String, security: FilestackSDK.Security?) -> FilestackSDK.Client

I've narrowed it down to only receiving build errors when importing FilestackSDK, importing Filestack itself is fine

Hmm, I see what's going on:
BothFilestackSDK and Filestack define the symbol Client and because both Filestack and FilestackSDK are being imported in your code, Client is being resolved to FilestackSDK.Client and it is failing to build since your target is not linking explicitly against FilestackSDK.
To resolve this issue, you may want to:

Add the FilestackSDK (https://github.com/filestack/filestack-ios.git) dependency explicitly to your target.
Make sure to prefix the Client class with either Filestack. or FilestackSDK. depending on what Client class you intend to use.

Let me know if this works for you and we'll add this extra step to our SPM installation procedure in the README.md.
Thanks!

This no longer reproduces with the latest version of the SDK, and Xcode 15.2 (Swift 5.9)


WIP: Enhancement/refactor js files

i'am using a lot of variables type "any", when the "mappers" be implemented I will change it


Need more instructions to run the code

Hi, @Sachin19, thanks to share your interesting work.
I think the idea of continuous optimization for controllable text generation is great, but when I'm going to run your code, I find there is no dataset and model checkpoint available.
I noticed that there are some code comments in the file decode_example.sh, #L29-21. But I still have no idea how to download the model checkpoint and dataset?
It would be grateful if you could add more instructions on how to download your training data and primary model(or classification model).

I have the same issue. Is there any workaround?

Hi, thanks for your interest in this code! Apologies for not updating the checkpoints yet, I am currently in the process of reorganizing the code with some additional experiments. This will take a few weeks after which I plan to include all the trained models and more instructions in the repository.
All the experiments we run are done on top of hugging face models or sentence-transformer models. In the meantime, to train your own constrained models,
(1) For huggingface-based models (classifiers), you can follow the instructions here (and dataset and hyperparameter details from the paper).
(2) For sentence transformer models (similarity models), you can follow the instructions here (by fine-tuning a GPT2 based model).
For both cases, I ran the exact codes from these links with the hyperparameter details provided in the Appendix of the paper.
Hope that helps.

Thanks for the clarification. My main question is about the pertained models you used for each task. Could you please let me know where I can download the following models that you used for your training?
PRIMARYMODEL=path/to/primary/model
STSMODEL=path/to/usim/model
CLASSIFIERMODEL=path/to/formality/classifier


[REST] "List requested reviewers for a pull request" does not paginate

Follow up to https://github.com/octokit/rest.js/issues/1978 /cc @nikclayton-dfinity
What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/rest/reference/pulls#list-requested-reviewers-for-a-pull-request
What part(s) of the article would you like to see updated?
Remove per_page and page parameters
Additional information
I didn't verify that the parameters do not have any effect, because it's rather hard to setup a pull request with multiple review requests without bothering anyone else. If you could check in with the API team I'd appreciate it

Hi @gr2m 👋🏻
Thanks for flagging this issue and for including the link to the detailed information in the Octokit repository. 🙇🏻♀
I checked with the ecosystem API team and they agree with you. The source files for the API docs are maintained in a different repository, so I'm going to open an internal issue for this change and close this.

Hi @gr2m 👋🏻
Thanks for flagging this issue and for including the link to the detailed information in the Octokit repository. 🙇🏻♀
I checked with the ecosystem API team and they agree with you. The source files for the API docs are maintained in a different repository, so I'm going to open an internal issue for this change and close this.

@felicitymay the docs still include the per_page and page parameters. Will these be removed eventually? I still have an open issue at https://github.com/octokit/rest.js/issues/33 and I'd like to give the Octokit user an update on their question


Default [] for a few fields to make them not required in the TF declarations

Description of the change

Write a brief description of your change here.

Checklist

[ ] I performed a self-review of my code
[ ] I manually tested my code change (please list details in description)
[ ] I added unit tests
[ ] I updated the changelog
[ ] I updated the public facing docs

#104  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


accelerator.prepare(    hangs without returning

System Info
- `Accelerate` version: 0.26.1
- Platform: Windows-10-10.0.22631-SP0
- Python version: 3.9.9
- Numpy version: 1.23.5
- PyTorch version (GPU?): 1.10.0+cu113 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- System RAM: 15.84 GB
- GPU type: NVIDIA GeForce RTX 2070 Super
- `Accelerate` default config:
        Not found

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
...
opt = torch.optim.Adam(model.parameters(), lr=0.001)  # or SGD
scheduler = torch.optim.lr_scheduler.LinearLR(opt, total_iters=5)
from accelerate import Accelerator
accelerator = Accelerator(mixed_precision="fp16")
device = accelerator.device
print(dir(accelerator), device)
#print(accelerator.env())
data_loader = accelerator.prepare_data_loader(data_loader, device_placement=True)
print('preparing model...')
model,optimizer,dataloader,scheduler = accelerator.prepare(model,opt,data_loader,   scheduler)
Expected behavior
call to  accelerator.prepare   hangs without returning and produces no messages

How are you launching the code?

Dear Zach
thanks for looking at this issue.
I am running the code from IDLE.
I have also successfully run the Accelerator example
'complete_cv+example.py'
Now I ran my code from windows console and after several minutes got my
'epoch 0' response.
So maybe I hadn't been waiting long enough.
Some kind of earlier progress message would have been nice.
Anyway I think we can close the problem
regards
Nick
On Sun, 18 Aug 2024 at 15:32, Zach Mueller @.***> wrote:

How are you launching the code?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/accelerate/issues/3026#issuecomment-2295283921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYVMFP5LCMUCSVD2I5DIN3ZSCWANAVCNFSM6AAAAABMWFMUGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGI4DGOJSGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Nick "Mac" McElwaine

sorry my previous reply was bad (using the example code).
when I run from the windows console, I do see a result  (but which is
strange because I have not asked for multiprocessing)
preparing model...
Traceback (most recent call last):
File "", line 1, in
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 116, in
spawn_main
exitcode = _main(fd, parent_sentinel)
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 125, in _main
prepare(preparation_data)
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 236, in
prepare
_fixup_main_from_path(data['init_main_from_path'])
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 287, in
_fixup_main_from_path
main_content = runpy.run_path(main_path,
File "C:\Python\Python39\lib\runpy.py", line 268, in run_path
return _run_module_code(code, init_globals, run_name,
File "C:\Python\Python39\lib\runpy.py", line 97, in _run_module_code
_run_code(code, mod_globals, init_globals,
File "C:\Python\Python39\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "D:\OurStuff\AI\Algorithms\accelerated_binary pima.py", line 87, in

for step, batch in enumerate(dataloader, start=1):
File "C:\Python\Python39\lib\site-packages\accelerate\data_loader.py",
line 448, in iter
dataloader_iter = super().iter()
File
"C:\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line
359, in iter
return self._get_iterator()
File
"C:\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line
305, in _get_iterator
return _MultiProcessingDataLoaderIter(self)
File
"C:\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line
918, in init
w.start()
File "C:\Python\Python39\lib\multiprocessing\process.py", line 121, in
start
self._popen = self._Popen(self)
File "C:\Python\Python39\lib\multiprocessing\context.py", line 224, in
_Popen
return _default_context.get_context().Process._Popen(process_obj)
File "C:\Python\Python39\lib\multiprocessing\context.py", line 327, in
_Popen
return Popen(process_obj)
File "C:\Python\Python39\lib\multiprocessing\popen_spawn_win32.py", line
45, in init
prep_data = spawn.get_preparation_data(process_obj._name)
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 154, in
get_preparation_data
_check_not_importing_main()
File "C:\Python\Python39\lib\multiprocessing\spawn.py", line 134, in
_check_not_importing_main
raise RuntimeError('''
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

On Tue, 20 Aug 2024 at 09:42, Nicky Mac @.***> wrote:

Dear Zach
thanks for looking at this issue.
I am running the code from IDLE.
I have also successfully run the Accelerator example
'complete_cv+example.py'
Now I ran my code from windows console and after several minutes got my
'epoch 0' response.
So maybe I hadn't been waiting long enough.
Some kind of earlier progress message would have been nice.
Anyway I think we can close the problem
regards
Nick
On Sun, 18 Aug 2024 at 15:32, Zach Mueller @.***>
wrote:

How are you launching the code?
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/accelerate/issues/3026#issuecomment-2295283921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYVMFP5LCMUCSVD2I5DIN3ZSCWANAVCNFSM6AAAAABMWFMUGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGI4DGOJSGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Nick "Mac" McElwaine

--
Nick "Mac" McElwaine

Generally we advise against doing distributed stuff on windows and recommend using WSL to get things done if possible.

thanks. I know windows is an inferior platform, but I generally find ways
of getting my python code to run OK.  I need to look harder at why
Accelerator is trying to multiprocess when I have workers=1.
I am very happy with you directing me to execute in the console and not in
IDLE.
On Tue, 20 Aug 2024 at 13:43, Zach Mueller @.***> wrote:

Generally we advise against doing distributed stuff on windows and
recommend using WSL to get things done if possible.
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/accelerate/issues/3026#issuecomment-2298767460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYVMFIGXBVXM4CKIOJDR23ZSM2VLAVCNFSM6AAAAABMWFMUGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYG43DONBWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Nick "Mac" McElwaine

I have found the answer in https://stackoverflow.com/questions/60101168    where datatloader(,num_workers) implies multiprocessing will be used.   Plus using accelerate.print()  instead of print()  gives me accelerate output in my IDE.
Problem solved.


does not handle urls correctly

http://google.com/some/path/guy.zip?hello=world#foo=bar
will return
zip?hello=world#foo=bar
which is incorrect.
you can use filename = require('url').parse(filename).pathname to easily strip everything from url but the path (/some/path/guy.zip)

I'd say this is working as intended. You're not supposed to feed URLs directly into this module. In your case, you could first test for an URL, like /.+:\/\/.+/.test(string) and if it matches, feed url.pathname to this module.


Add pre-commit/push hook for tests/lint

To improve the workflow of code delivery and help contributors we should utilize our tests/lint/prettier script to be a pre-commit/push hooks so issues are resolved before they even get to the PR stage

addressed in https://github.com/TBD54566975/dwn-server/pull/56


configuration change for sqlite.lua to work on windows system

Describe the bug
On windows system, sqlite.lua failed to load because of lack of sqlite3.dll.  To solve this problem, one can change the line locate in lua/modules/tools/config.lua:
vim.cmd [[packadd sqlite.lua]]
to:
vim.cmd [[
let g:sqlite_clib_path = 'path/to/sqlite3.dll' (NOTE: Users need to download precompiled sqlite from https://www.sqlite.org/download.html)
packadd sqlite.lua
]]

Would you mind close my issues. They are two corner cases which are insignificant. Thank you for this awesome lua configuration, i have learned a lot.

Thanks for your feedback, I will add it to wiki.


CPU load 100%

When run as a service, it increases the CPU load to 100%

I solved it myself
I used a ev_sleep() in the onmessage event and it worked


Inefficient use of downloading entire pivnet product

In order to extract the product name (and get the corresponding product GUID from the opsman), we're downloading the entire product from pivnet & looking at the metadata. Do we have to do this? Considering all we need is the product name?

Somewhat related: when uploading a stemcell, if opsman detects the version is already uploaded, it won't upload the stemcell again. Unless you pass in a "--force" flag.
https://github.com/pivotal-cf/om/blob/16d387b8beb661f20fc5cd5d8af5ff878b597282/commands/upload_stemcell.go#L19

Can we just pass around the metadata.yml file as input/output so we don't have to re-download the pivot product? That way we don't have to pass down the entire pivot product? Because all I need is the exact product_version.

Can we use some external store to save the tile metadata? Like a git resource? This might help #4 ...?

https://network.pivotal.io/docs/file_download_api

How can we best use the metadata of a product? https://github.com/pivotal-cf/pivnet-resource/tree/master/metadata


GEODE-8227: Updates CMake to 3.16.8.

Is this to update the minimum required version also?  Or just to get packer things updated?  The Jira issue doesn't go into detail

Is this to update the minimum required version also? Or just to get packer things updated? The Jira issue doesn't go into detail

Little of both... The current images have a really old CMake. There are some ACE removal branches that need newer CMake.

Little of both... The current images have a really old CMake. There are some ACE removal branches that need newer CMake.

Thanks for the information.  My request would be to update https://github.com/apache/geode-native/blob/develop/CMakeLists.txt#L16 to new required version of cmake

Thanks for the information. My request would be to update https://github.com/apache/geode-native/blob/develop/CMakeLists.txt#L16 to new required version of cmake

Chicken and egg problem. If you make that change in this PR the CI fails because the images aren't updated with the new version of CMake. Technically our CMake files are currently compatible with older versions of CMake. Though that will change soon.

Chicken and egg problem. If you make that change in this PR the CI fails because the images aren't updated with the new version of CMake. Technically our CMake files are currently compatible with older versions of CMake. Though that will change soon.

No problem 😄 Just want to make sure stuff comes to eventual consistency


Confusing Build Process

Create Pi MusicBox.rst seems very outdated, I see a makeimage.sh that looks like it does all the heavy lifting, but it's unclear from the comments.
I'd love to build this and maybe also contribute, but until I can figure out how to even start there's no chance.
Could you find a little time to update the docs to explain setup process, use of makeimage, and maybe add come comments to your code to explain what it's deploying as it goes? With that much in place people could more simply navigate the project and adapt and update it.
Thanks!

I believe the script has been updated and should work. I'll leave this issue open as there is still scope to improve the documentation and explain how the various bits fit together.


[Question] How to build machine-rancheros.iso or update to latest docker version

Hi,
I would like to use docker v 1.8.2
How can I build machine-rancheros.iso for virtualbox to trunk/master or how do I ugprade to the latest docker version ?
Thank You

Never mind.  The current build will be able to handle virtualbox.
Thank you


Remove beyla metrics and traces

When we switched to the OpenTelemetry collector SDK for generating traces we ended up accidentally enabling Beyla internal metrics and traces. This PR reverts that setting. We should consider adding this back under an option.

Codecov Report
Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (cd4f89d) to head (9681265).

Files
Patch %
Lines

pkg/internal/export/otel/traces.go
87.50%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #910       +/-   ##
===========================================
- Coverage   78.93%   35.96%   -42.98%
===========================================
  Files         131      130        -1
  Lines        9742     9688       -54
===========================================
- Hits         7690     3484     -4206
- Misses       1553     5817     +4264
+ Partials      499      387      -112

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
35.96% <87.50%> (-0.18%)
:arrow_down:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ng update fails on latest angular cli

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [x] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
N/A

Description
ng update --all fails on a new project

🔬 Minimal Reproduction

install latest angular cli yarn global add @angular/cli
create a new project ng new projectname
cd into project
run ng update --all
observe

We shouldn't have any incompatible peer dependencies.
We have two:

Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.9.1", would install "0.10.2").
Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=3.4 <3.6", would install "3.6.4").

🔥 Exception or Error

Angular CLI: 8.3.14
Node: 10.17.0
OS: linux x64
Angular: 8.2.12
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.14
@angular-devkit/build-angular     0.803.14
@angular-devkit/build-optimizer   0.803.14
@angular-devkit/build-webpack     0.803.14
@angular-devkit/core              8.3.14
@angular-devkit/schematics        8.3.14
@angular/cli                      8.3.14
@ngtools/webpack                  8.3.14
@schematics/angular               8.3.14
@schematics/update                0.803.14
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.9.1", would install "0.10.2").
                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=3.4 <3.6", would install "3.6.4").
Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.

Distributor ID: Ubuntu
Description:    Ubuntu 18.04.3 LTS
Release:        18.04
Codename:       bionic

$ node --version
v10.17.0

$ npm --version
6.12.0

$ yarn --version
1.19.1

Since TypeScript 3.7 is in RC now, is there any plan on when that will be supported? This ng update problem will resurface once 3.7 is released, right?

I'm experiencing this updating from 7.
Angular CLI: 7.3.9
Node: 12.13.0
OS: linux x64
Angular: 7.2.15
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.9
@angular-devkit/build-angular     0.13.9
@angular-devkit/build-optimizer   0.13.9
@angular-devkit/build-webpack     0.13.9
@angular-devkit/core              7.3.9
@angular-devkit/schematics        7.3.9
@angular/cli                      7.3.9
@ngtools/webpack                  7.3.9
@schematics/angular               7.3.9
@schematics/update                0.13.9
rxjs                              6.5.3
typescript                        3.6.4
webpack                           4.29.0

ng update --all
                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=3.4 <3.6", would install "3.6.4")
                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.9.1", would install "0.10.2")
                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.9.1", would install "0.10.2").
                  Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript" (requires ">=3.1 < 3.6", would install "3.6.4")

Any solution so far ?

ok just created a new angular project to see if this bug is still outstanding and yes it is because rxjs

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 8.3.17
Node: 12.13.0
OS: linux x64
Angular: 8.2.13
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.17
@angular-devkit/build-angular     0.803.17
@angular-devkit/build-optimizer   0.803.17
@angular-devkit/build-webpack     0.803.17
@angular-devkit/core              8.3.17
@angular-devkit/schematics        8.3.17
@angular/cli                      8.3.17
@ngtools/webpack                  8.3.17
@schematics/angular               8.3.17
@schematics/update                0.803.17
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

1$ ng update
Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
    We analyzed your package.json, there are some packages to update:

      Name                               Version                  Command to update
     --------------------------------------------------------------------------------
      rxjs                               6.4.0 -> 6.5.3           ng update rxjs

$ ng update --all
Using package manager: 'yarn'
Collecting installed dependencies...
Found 30 dependencies.
                  Package "codelyzer" has an incompatible peer dependency to "tslint" (requires "^5.0.0", would install "6.0.0-beta0").
                  Package "@angular/core" has an incompatible peer dependency to "zone.js" (requires "~0.9.1", would install "0.10.2").
                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=3.4 <3.6", would install "3.7.2").
Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.

Please follow the official update instructions provided here: https://update.angular.io
The -all option is not recommended for general update usage.  It will update all dependencies found to their absolute latest version regardless of compatibility.
If any issues are encountered when following the recommended instructions, please open a new issue with additional details.

@clydin  Can we show this text (or something like it) when someone runs ng update --all? It would be very helpful.
The --all option is not recommended for general update usage. It will update all dependencies found to their absolute latest version regardless of compatibility.

I'm still seeing the following:
Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript"
  (requires ">=3.6 < 3.7", would install "3.7.2")
Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript"
  (requires ">=3.6 <3.7", would install "3.7.2")

When running ng update @angular/core @angular/cli --next as per the instructions at https://update.angular.io

@despian I was getting a similar error except it was telling me it required ">=3.1 < 3.6". I ran the following:
npm install<EMAIL_ADDRESS>< 3.6"
Once i ran that, @angular-devkit/build-angular and @angular/cli updated just fine but it's obviously saying that my typescript version is out of date. Project seems to be building fine as well, but I'm anxiously awaiting typescript errors since I dropped from 3.7.2 to 3.5.3.... I'll keep you posted...

@davidshanline so my issue was due to the fact I had the following in my package.json:
    "typescript": "^3.5.3",

This was allowing the latest version of typescript ("3.7.2") to be installed which was causing the problem.
I changed my package.json to:
    "typescript": "~3.6.4",

and this solved the problem for me.


harmonic init doesn't install the theme automatically

This means a fresh harmonic init will fail to build/run as the theme is not installed, and will leave most users clueless.

fixed by e20d315fdefc156abcf0fb879136302600d7c0e3


minlength is impacted by required attribute in json schema

I used below schema to generate C# code using CSharpGenerator. But there is no validation for the length if the field marked as required. The validation ( [System.ComponentModel.DataAnnotations.StringLength(int.MaxValue, MinimumLength = 1)]) is correctly generated if the field is not marked as required.

{
"$schema": "http://json-schema.org/draft-04/schema#",
"type": "object",
"properties": {
"files": {
"type": "string",
"minlength": 1
}
},
"required": [
"files"
]
}

Is this intentional?  I am using version: 9.10.67 on nuget.

This is probably missing at the moment...

Any workaround for this?


DNS Requests failing to hit node-local-dns-cache (LRP appears to not address it)

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
We're attempting to roll out Cilium 1.10 on all managed cloud k8s providers with settings that are as similar across clouds as possible, so we're testing with VXLAN, and generic IPAMs in order to limit differences. All application workloads currently work fine, but because we run batch jobs, we're highly sensitive to DNS bursts, and without node-local-dns-cache working we tend to run into problems with our central DNS.
We began to test node-local-dns-cache specifically in GKE with this set of config
helm template cilium cilium/cilium --version 1.11.0 \
  --namespace kube-system \
  --set ipam.mode=kubernetes \
  --set tunnel=vxlan \
  --set egressMasqueradeInterfaces=eth+ \
  --set nodeinit.enabled=true \
  --set nodeinit.reconfigureKubelet=true \
  --set nodeinit.removeCbrBridge=true \
  --set cni.binPath=/home/kubernetes/bin \
  --set hubble.tls.auto.method="cronJob" \
  --set hubble.listenAddress=":4244" \
  --set hubble.relay.enabled=true \
  --set hubble.ui.enabled=true \
  --set upgradeCompatibility="1.9" \
  --set encryption.enabled=true \
  --set encryption.nodeEncryption=false \
  --set encryption.type=ipsec \
  --set prometheus.enabled=true \
  --set operator.prometheus.enabled=true \
  --set hubble.metrics.enabled="{dns,drop,tcp,flow,icmp,http}" \
  --set labels="k8s:io.kubernetes.pod.namespace k8s:k8s-app k8s:app k8s:name"

When we make requests to fetch public DNS results (e.g. dig google.com), we did not see the node local cache request counter increment.
We also tested with localredirectpolicy enabled (using the config from here) and got the same results. Specifically, all of the coredns_dns_requests_total counters remained the same.
Cilium Version
1.11.0
Kernel Version
Linux version 5.4.144+ (builder@7d732a1aec13) (Chromium OS 12.0_pre408248_p20201125-r7 clang version 12.0.0 (/var/tmp/portage/sys-devel/llvm-12.0_pre408248_p20201125-r7/work/llvm-12.0_pre408248_p20201125/clang f402e682d0ef5598eeffc9a21a691b03e602ff58)) #1 SMP Sat Sep 25 09:56:01 PDT 2021
Kubernetes Version
v1.21.6-gke.1500
Sysdump
cilium-sysdump-20220124-105037.zip
Relevant log output
There don't appear to be any obvious logs related to this

Anything else?
I did see this issue, not totally clear if it's related or not. I tried to check the settings they were using there to see if there were differences I could apply to get the same results shown here, but the link to apply yaml didn't show any of the actual config.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for the report!
Going over the sysdump, it seems to me that indeed DNS requests are forwarded to kube-dns (instead of going over the node-local-dns).
Could you add what is the output of hubble-observe for a client pod that performs DNS requests (see https://docs.cilium.io/en/v1.10/operations/troubleshooting/#observing-flows-of-a-specific-pod) as well as the output of cilium monitor for the corresponding endpoint (see https://docs.cilium.io/en/v1.10/contributing/development/debugging/#monitor-events).

cc @aditighag

Did you follow these instructions - https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache? Also, I don't see kube-proxy replacement being enabled in your helm config.

We began to test node-local-dns-cache specifically in GKE with this set of config

AFAIK, you need to enable node-local dns plugin on GKE clusters, else GKE control plane deletes the manually deployed node-local dns pods. /cc @Weil0ng

It seems like the node-local-dns pods are deployed in host network namespace? Can you confirm that? If so, please follow instructions here https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache to deploy node-local-dns pods and see it if resolves the problem.

Could you add what is the output of hubble-observe for a client pod that performs DNS requests

Jan 25 20:20:55.466: default/my-shell:58407 -> kube-system/kube-dns-599484b884-7fbnl:53 to-stack FORWARDED (UDP)
Jan 25 20:20:55.469: default/my-shell:58407 <- kube-system/kube-dns-599484b884-7fbnl:53 to-endpoint FORWARDED (UDP)
Jan 25 20:21:07.844: default/my-shell:34621 -> kube-system/kube-dns-599484b884-7fbnl:53 to-stack FORWARDED (UDP)
Jan 25 20:21:07.845: default/my-shell:34621 <- kube-system/kube-dns-599484b884-7fbnl:53 to-endpoint FORWARDED (UDP)

as well as the output of cilium monitor for the corresponding endpoint

-> stack flow 0x0 , identity 35195->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:52770 -> <IP_ADDRESS>:53 udp
level=info msg="Initializing dissection cache..." subsys=monitor
-> endpoint 1894 flow 0x0 , identity 17190->35195 state reply ifindex lxce4ac913d99eb orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:52770 udp
-> stack flow 0x0 , identity 35195->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:50997 -> <IP_ADDRESS>:53 udp
-> endpoint 1894 flow 0x0 , identity 17190->35195 state reply ifindex lxce4ac913d99eb orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:50997 udp

Did you follow these instructions - https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache? Also, I don't see kube-proxy replacement being enabled in your helm config.

So I actually didn't realize the node local dns cache setup was different, but reading through that I'm seeing some of the changes, I'll go ahead and give that a try. As far as kube-proxy replacement, we're using kube-proxy-replacement:  "probe" (defaulted by helm). I briefly tried full (strict) kube-proxy replacement, but I ran into problems because that's not compatible with transparent encryption, which is one of the core features we wanted out of Cilium. At least it's not compatible according to the docs, the error it threw at runtime was a little more specific, from daemon/cmd/kube_proxy_replacement.go#95, IPSec can't be used with bpf nodeport. Do you have any clarity on whether LRP relies on full strict kube-proxy replacement?
I'll set up a test with an updated version of node-local-dns cache without host networking and see if that works.

So a couple issues, if I remove the node-local dns plugin from gke my pods aren't killed, I get errors like this on boot
listen tcp <IP_ADDRESS>:28080: bind: cannot assign requested address

Initially these were complaining about a dummy stub-zone we define, but after removing that it just complained about binding on that address.
With the node-local-dns plugin in place it almost immediately resets changes to the DS config, so I can't change the node-local-dns daemonset to remove hostnetwork, modify the command line arguments, or add the cilium annotation for port 53. I did try changing the label addonmanager.kubernetes.io/mode=Reconcile to addonmanager.kubernetes.io/mode= EnsureExists, but it was also reset back by the system immediately.
Any ideas? I'm open to shifting from encapsulation to native routing if that might fix this, but it seems like this should work.

If you are working with GKE's nodelocaldns addon, then no you cannot change its config without all changes being reconciled away, so there are 2 options:

Using OSS Cilium, then deploy OSS nodelocaldns per the instructions
Using GKE's bundled DPv2 + nodelocaldns addon

So I was able to get OSS nodelocaldns running but it doesn't work with custom stubZones because it fails to bind on the kube-dns IP
Listen: listen tcp <IP_ADDRESS>:53: bind: cannot assign requested address

It's picking up upstream stubZones and producing a bind on the default local DNS IP
google.com:53 {
    errors
    cache 30
    bind <IP_ADDRESS> <IP_ADDRESS>
    forward . <IP_ADDRESS> <IP_ADDRESS>
}

I'll keep testing and see if I can find a way around this.
Before that though I'll figure out if LRP works with this setup (without stubZones) to at least address this specific issue, and open a separate issue if there's other problems that come up.

Do you have any clarity on whether LRP relies on full strict kube-proxy replacement?

LRP relies on socket-based load balancing. KPR=probe setting should be fine with your cluster to get node-local dns use case working with LRP - https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#node-local-dns-cache.
$ cilium status --verbose
:
KubeProxyReplacement Details:
  Socket LB Protocols:    TCP, UDP

Alright, so I've gone back through, enabled LocalRedirectPolicy and followed the full localredirectpolicy directions for node-local-dns to the letter and I'm still not seeing dns request counts going up on the local cache pod.
For what it's worth I was able to get node-local-dns to run while there were upstream stubZones on coredns by changing to -localip=<IP_ADDRESS>, but I did change that back to -localip=<IP_ADDRESS>,$KUBE_DNS_IP for the test results I'm showing below. I also made sure to restart all pods involved to ensure everything was tracked.
They're all stuck at 1
root@my-shell:/# curl http://<IP_ADDRESS>:9253/metrics | grep coredns_dns_request_count_total
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP coredns_dns_request_count_total Counter of DNS requests made per zone, protocol and family.
# TYPE coredns_dns_request_count_total counter
coredns_dns_request_count_total{family="1",proto="udp",server="dns://<IP_ADDRESS>:53",zone="."} 1
coredns_dns_request_count_total{family="1",proto="udp",server="dns://<IP_ADDRESS>:53",zone="cluster.local."} 1
coredns_dns_request_count_total{family="1",proto="udp",server="dns://<IP_ADDRESS>:53",zone="in-addr.arpa."} 1
coredns_dns_request_count_total{family="1",proto="udp",server="dns://<IP_ADDRESS>:53",zone="ip6.arpa."} 1

For thoroughness sake I've added a new sysdump, observe, and monitor results. For each of these, I ran dig google.com and nslookup api.default.svc.cluster.local, both of which returned just fine in my test pod.
❯ kubectl exec -n kube-system cilium-7lg46 -- hubble observe --since 3m --pod default/my-shell
Defaulted container "cilium-agent" out of: cilium-agent, mount-cgroup (init), wait-for-node-init (init), clean-cilium-state (init)
Jan 28 03:36:09.727: default/my-shell:57635 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.728: default/my-shell:57635 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:09.728: default/my-shell:48787 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.729: default/my-shell:48787 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:09.729: default/my-shell:46482 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.730: default/my-shell:46482 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:09.730: default/my-shell:56749 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.734: default/my-shell:56749 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:09.734: default/my-shell:47732 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.737: default/my-shell:47732 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:09.737: default/my-shell:55108 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:09.738: default/my-shell:55108 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)
Jan 28 03:36:14.082: default/my-shell:57620 -> kube-system/kube-dns-599484b884-5xnxc:53 to-stack FORWARDED (UDP)
Jan 28 03:36:14.085: default/my-shell:57620 <- kube-system/kube-dns-599484b884-5xnxc:53 to-endpoint FORWARDED (UDP)

level=info msg="Initializing dissection cache..." subsys=monitor
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:50259 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:50259 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:54660 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:54660 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:33066 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:33066 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:60324 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:60324 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:50671 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:50671 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:41389 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:41389 udp
-> stack flow 0x0 , identity 57552->17190 state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:49491 -> <IP_ADDRESS>:53 udp
-> endpoint 3330 flow 0x0 , identity 17190->57552 state reply ifindex lxc48b007061457 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:53 -> <IP_ADDRESS>:49491 udp

cilium-sysdump-20220127-193520.zip

What's the output of cilium lrp list when run from the cilium pods? Have you tried tracing DNS packets to see if they are being sent to the node-local dns cache pods or not?

I noticed the following in the agent log:
2022-01-27T15:47:15.860241015Z level=info msg="  --enable-local-redirect-policy='false'" subsys=daemon

Can you confirm how did you enable LRP? Seems like the config change was not picked up by agent, did you restart the agent after changing the config?

Restarting the cilium agents fixed it!!!! Thank you all so much for your help!
I'll do a bit more testing to verify that it works as expected, but given what I found about setting -local-ip=<IP_ADDRESS> in order to have this setup be compatible with private DNS zones I'd be happy to make a PR to update the yaml referenced in the docs to use that instead of -localip=<IP_ADDRESS>,$KUBE_DNS_IP in case that helps someone else who has to deal with private DNS servers from their clusters.

Great to see that you were able to get the node-local dns use case working with LRP. Can we close this bug if your issue is fully resolved?

but given what I found about setting -local-ip=<IP_ADDRESS> in order to have this setup be compatible with private DNS zones I'd be happy to make a PR to update the yaml referenced in the docs to use that instead of -localip=<IP_ADDRESS>,$KUBE_DNS_IP

I don't think these instructions are relevant for the LRP-based node-local dns documentation.


[state sync] raise standards for recovering from multicast/failover mode

Motivation
In vfn failover cluster test experiment, the VFN makes progress fine when its upstream validator goes down by syncing with its failover VFNs. However, when the upstream validator comes back up, in the current code, the VFN immediately stops casting to its failovers and reverts back to casting to its validator only. However, because when the validator is coming back up, it is still catching up/behind the VFN's state, so the VFN's long poll requests to V have to timeout before the VFN fails back over to the failover VFNs. While this is not technically a bug because the VFN does eventually continue to make progress, the timeout before the failover distracts the VFN's sync progress, which isn't ideal.
This PR changes the meaning of multicast_level to indicate the largest preference of the network (defined by UpstreamConfig) to multicast to, not the number of first live networks available to multicast to. When we select peers to broadcast to in all upstream networks with preference <= multicast_level, we will failover to the next available network with live peers to broadcast to and increase multicast_level accordingly.
Test Plan
Above issue is resolved in vfn failover cluster test experiment - the validator coming back up and catching up does not interrupt/distract the VFN's state sync efforts, and VFN makes uninterrupted progress by continuously sending requests to failover VFNs even when V is up but still catching up.

/land


🐛 [firebase_auth] userChanges() stream old data after linkWithCredential on chrome

Bug report
Describe the bug
userChanges is streamed when we call linkWithCredential on the user, and it works fine on android, but when on chrome it streams data before the link happens, so if you check if the user isAnonymous on a listener you will see it will still be anonymous
Steps to reproduce

Initialize firebase as you would
Listen to the userChanges stream FirebaseAuth.instance.userChanges().listen((event) { print("User updated: ${event}"); });
SignIn anonymously auth.FirebaseAuth.instance.signInAnonymously();
Link the anonymous account auth.FirebaseAuth.instance.currentUser!.linkWithCredential(EmailAuthProvider.credential(email<EMAIL_ADDRESS>password: "dasdsadsa",),);
Now build for android and see it working as expected
Then build for chrome and see that after linking the account you will receive an update on the stream but the account they give you on the stream will still not be linked

Expected behavior
For the stream be updated after the user get linked not before
Sample project
Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
PASTE OUTPUT INSIDE HERE

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
PASTE OUTPUT INSIDE HERE

Thanks for the report @Kirchesch. I think your case is same / similar to https://github.com/firebase/flutterfire/issues/3356. Can you check that and confirm ?

It appears to be related
But i am not having the issues they do, i receive only one update on each listener as it should, and it sinks with the right data, the only problematic one ( Of the ones i use ) is when i link an account with credentials, then it sinks in the userChanges() before actually updating the user, so:
Line 1: await auth...linkWithCredentials(...) // Right here at some point the userChanges is called and it provides old data, data before linking the account
Line 2: print(auth...currentUser) // Right here the user has been linked already and you can see its not anonymous anymore
So the problem is that the logic for handling userChanges is in the delegate bound to userChanges and not in the specific area who calls linkWithCredentials

Thanks for the update. Can you provide a minimal reproducible code sample that we can use directly to analyze this further ?

@darshankawar forgot to mention you last comment, in case you haven't been notified im just letting you know i created a repository to test this issue: https://github.com/KircheschContributions/FlutterIssues

Thanks for the repo. I cloned it and first ran it on mobile which gave me below result:
flutter: user state updated AsyncSnapshot<User?>(ConnectionState.active, User(displayName: null, email<EMAIL_ADDRESS>emailVerified: false, isAnonymous: true, metadata: UserMetadata(creationTime: 2022-06-09 12:01:56.552, lastSignInTime: 2022-06-09 12:01:56.552), phoneNumber: null, photoURL: null, providerData, [], refreshToken: , tenantId: null, uid: 0LvswJ1Ys9dUz5tgoH6lSYMR7t52), null, null)
That shows email<EMAIL_ADDRESS>Then I ran the same on chrome which gave me below:
user state updated AsyncSnapshot<User?>(ConnectionState.active, User(displayName: null, email: null, emailVerified: false, isAnonymous: true, metadata: UserMetadata(creationTime: 2022-06-09
06:34:10.000, lastSignInTime: 2022-06-09 06:34:10.000), phoneNumber: null, photoURL: null, providerData, [], refreshToken:
AIwUaOmqT8u1g20OJuzK-WIzZNQ7oX08CTJqMLc_FLcZeMWKKt0bvc8Y8de5znEWuH5RA8-xISQIQminEnzUARDZhslOi-GWEqe8fKekJRhFLgSv_QgHLFtntH1aA5eDD-Mz_VU3F-YISe8hgAxvk-E879kwThyhldqpqWgHTrV5gzxsNqaJMOzG-uqWtKY
rS0SRtATArIzsIc4UC3rQBpsIiWrw3npgznJ069fXfX3WIDEu96EcIc8, tenantId: null, uid: xHdvGu8aTEgjJ7IwxfYGwZfGYXD2), null, null)

that shows email: null, but the expected result is that web should capture the current email being logged in, as shown in mobile. Is this a correct interpretation of the issue ?

yes, that is correct

Thanks for the update. Based on my findings https://github.com/firebase/flutterfire/issues/8856#issuecomment-1150730647, keeping this issue open and labeling.

We fixed a difference between native and web in https://github.com/firebase/flutterfire/pull/10028
It will be released today, let us know if it solves your issue


Clean up d2l-my-courses

Similar to #335, but for d2l-my-courses.html instead. Broken into another PR to not cause too much eye bleeding. The changes are are quite a bit less significant than the all-courses one; other files could be similarly organized I guess, but none are as large/complex, so probably not as important.

Ah blerg - US84675 could do with this being in first - any objections to merging?

Totally missed @jstefaniuk-d2l's :+1: on the comment above. Just checked this out, rebased it, and tested it, all seems good so going to merge.


Great Error messaging. Using<EMAIL_ADDRESS>

Seriously, this is great. Thanks for taking the time. Good work, sir.
  1 │<EMAIL_ADDRESS>jsConverter]
  2 │ [@decco] type response_type = [ |<EMAIL_ADDRESS>"code"] `Code |<EMAIL_ADDRESS>"toke
      n"] `Token];
  3 │
  4 │ [@decco] type config = {

  This syntax is not yet handled by decco

I have this type need to model that look like this in ts:
export interface ICognitoUserPoolData {
		UserPoolId: string;
		ClientId: string;
		endpoint?: string;
	}

Using deriving abstract it looks like this:
<EMAIL_ADDRESS>abstract]
type t = {
<EMAIL_ADDRESS>"UserPoolId"]
  userPoolId: string,
<EMAIL_ADDRESS>"ClientId"]
  clientId : string,
  endpoint: option(string),
};

How would I create this with decco?
If I had a decco identifier like this:
[<EMAIL_ADDRESS>abstract]
type t = {
<EMAIL_ADDRESS>"UserPoolId"]
  userPoolId: string,
<EMAIL_ADDRESS>"ClientId"]
  clientId : string,
  endpoint: option(string),
};

I get this error:
  We've found a bug for you!
  (No file name)

  The record field userPoolId can't be found.

  If it's defined in another module or file, bring it into scope by:
  - Annotating it with said module name: let baby = {MyModule.age: 3}
  - Or specifying its type: let baby: MyModule.person = {age: 3}

Is there a way to get the capitalized field names into decco? Thanks.

Thanks, glad you find it useful!
Unfortunately [@decco] isn't compatible with<EMAIL_ADDRESS>abstract] because<EMAIL_ADDRESS>abstract] doesn't create real Reason records.
To get the equivalent<EMAIL_ADDRESS>functionality in decco you can use<EMAIL_ADDRESS>[@decco]
type t = {
<EMAIL_ADDRESS>"UserPoolId"]
  userPoolId: string,
<EMAIL_ADDRESS>"ClientId"]
  clientId : string,
  endpoint: option(string),
};


Continuous testing of neuroimaging results across pipelines and datasets

Title
Continuous testing of neuroimaging results across pipelines and datasets
Leaders
Jacob Sanz-Robinson (Mattermost: @jacobsanz).
Collaborators
Jacob Sanz-Robinson  (Mattermost: @jacobsanz).
Brainhack Global 2021 Event
Brainhack Montreal
Project Description

What are you doing, for whom, and why?
Neuroimaging results are sensitive to variations in processing pipelines, contributing to scientific result reproducibility issues. In general, there is no ground truth and it is unclear which pipeline should be applied to data when they yield different results. This project is a software framework capable of helping neuroscientists test whether neuroimaging results are robust across pipelines and replicable across datasets.

What makes your project special and exciting?
It is, to the best of my knowledge, the first attempt at a generalized framework for performing distributed computations in a Continuous Integration setting. This will help scientists systematically evaluate result variability in their experiments. Users can pinpoint biases and discrepancies caused by processing methods and datasets, and quantify their impact on results. In areas where result reproducibility is a concern, the uptake of this novel tool could aid in consolidating knowledge and explaining the uncertainty in the field.

How to get started?
Have a gander at the project repo!
Any additional functionality is welcome in a Pull Request. If you are familiar with any neuroimaging pipelines, building Boutiques descriptors for them is extremely useful. Functions to visualize the data or retrieve/process summary statistics are also welcome!

Where to find key resources?
The project repo (readme) is a good place to start. Otherwise feel free to message me by e-mail, Mattermost, or homing pigeon (if it's clean).

Link to project repository/sources
https://github.com/jacobsanz97/NDR-CI
Goals for Brainhack Global
My personal efforts will be directed at a mechanism to repopulate the cache files by querying the CBRAIN distributed computation system in case they become corrupted or lost.
If there is additional time I will work on making prettier data visualizations and including statistical summaries.
If other people join, then hopefully we can containerize a pipeline or two, and make more progress on the visualizations.
Good first issues

Issue one: Create a Boutiques descriptors for any neuroimaging pipeline of your choice!

Issue two: Create visualizations that could help us compare results across pipelines and datasets.

Issue three: Any additional functionality you may deem useful!

Issue four: cache file repopulation/retrieval (this is what I will be working on).

Communication channels
https://mattermost.brainhack.org/brainhack/channels/neuro-repro-ci
Skills

Python
Command line/bash
Any neuroimaging pipelines! (I have been dealing with FSL and FreeSurfer so far...If you are familiar with ANTs, MINC tools, CIVET, or SPM, you will be extremely useful!)
Containers/Boutiques.
Data visualization (You don't need to be advanced! Some basic experience in matplotlib/seaborn/plotly or the desire to learn these is more than enough!)

Onboarding documentation
See readme: https://github.com/jacobsanz97/NDR-CI
What will participants learn?
If you wish to learn about containerization, running neuroimaging pipelines, or data visualization...This is a good project to pick up the basics of one or more of these :) .
Data to use
No response
Number of collaborators
more
Credit to collaborators
Contributors will be listed in the project ReadMe.
Image

Type
coding_methods
Development status
1_basic structure
Topic
reproducible_scientific_methods
Tools
AFNI, ANTs, Datalad, Freesurfer, FSL, other
Programming language
Python
Modalities
other, not_applicable
Git skills
2_branches_PRs
Anything else?
For Tools: Any and all tools and/or neuroimaging pipelines are useful to integrate into the project! At the same time, none are strictly necessary if you wish to focus your development efforts on another aspect of the framework.
Things to do after the project is submitted and ready to review.

[X] Add a comment below the main post of your issue saying: Hi @brainhackorg/project-monitors my project is ready!
[ ] Twitter-sized summary of your project pitch.

@jacobsanz97
Will put this on the website.
One small suggestion would be to create actual issues on your repo to provide a "forum" to help guide new comers.
The 2 first issues you listed here seem quite good candidates for that.


Added University of Minnesota

Added University of Minnesota. Followed instructions according to "Add your school to JetBrains" page.
Let me know if structure should be modified or anything, happy to make changes.

@Themis3000 I am sorry, the domain umn.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


May selma supports generics ?

Hi,
In my project, I had some custom mapper. I wanted to harmonized all of them by using generics. But If I don't override the generics method one the interface, selma doesn't find them.
I made an example: https://github.com/BenoitCharret/selma-test/tree/case_4
Let's try to explain:
I define an interface that define how to map generic type:
public interface IListMapper<E,D> {
E asEntity(D dto);
D asDto(E entity);

}
When defining custom mapper,  I only want to have :
@Mapper(
withCustomFields = {@Field({"src", "field"})}
)
public interface MyListMapper extends IListMapper<SrcString,DstString>{
}
But, In this way, selma complains about the type of the method :
Error:java: Failed to generate mapping method for type D to E not supported on com.test.IListMapper.asEntity(D) !
--> Add a custom mapper or 'withIgnoreFields' on @Mapper or @Maps to fix this ! If you think this a Bug in Selma please report issue here [https://github.com/xebia-france/selma/issues].
If I just override the method, selma compile.
@Mapper(
withCustomFields = {@Field({"src", "field"})}
)
public interface MyListMapper extends IListMapper<SrcString,DstString>{
@Override
SrcString asEntity(DstString dto);
@Override
DstString asDto(SrcString entity);

}
I think, the code could be cleaner if we could find those method without override them.
Thanks

This is maybe a duplicate of #63 second comment.

This is now supported ax fixed with #63.


How to use it for Nextjs typescript ?

Hello bro,
Can u help me use it for Nextjs, I have a issue. Thank for help

I have issue with Next.js 13, but in Next.js 12 works

Yes, do you think you have to add "use client" for nextjs 13

I don't think so, for the Next.js I usually use next/dynamic with {ssr: false} to resolve almost related issues SSR. Maybe use client for Next.js 13

Well, I expect a new fix for nextjs typescript from you. Thank you


Error in the demo project, can't do the first run with npm.

Describe the bug
The raw project isn't running after the creation:
`
events.js:170
throw er; // Unhandled 'error' event
^
Error: spawn /usr/bin/chromium ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
at onErrorNT (internal/child_process.js:429:16)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
Emitted 'error' event at:
at Process.ChildProcess._handle.onexit (internal/child_process.js:253:12)
at onErrorNT (internal/child_process.js:429:16)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: react-scripts start
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/otavio/.npm/_logs/2019-07-08T11_25_15_561Z-debug.log
`
Log of this erros:
0 info it worked if it ends with ok 1 verbose cli [ '/usr/bin/node', 1 verbose cli   '/usr/lib/node_modules/npm/bin/npm-cli.js', 1 verbose cli   'run', 1 verbose cli   'start', 1 verbose cli   '--scripts-prepend-node-path=auto' ] 2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ] 5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true 8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/otavio/dfm-front/node_modules/.bin:/home/otavio/.local/bin:/home/otavio/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl 9 verbose lifecycle<EMAIL_ADDRESS>CWD: /home/otavio/dfm-front 10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'react-scripts start' ] 11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null 12 info lifecycle<EMAIL_ADDRESS>Failed to exec start script 13 verbose stack Error<EMAIL_ADDRESS>start:react-scripts start13 verbose stack Exit status 1 13 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16) 13 verbose stack     at EventEmitter.emit (events.js:193:13) 13 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14) 13 verbose stack     at ChildProcess.emit (events.js:193:13) 13 verbose stack     at maybeClose (internal/child_process.js:999:16) 13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:266:5) 14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /home/otavio/dfm-front 16 verbose Linux 5.1.16-arch1-1-ARCH 17 verbose argv "/usr/bin/node" "/usr/lib/node_modules/npm/bin/npm-cli.js" "run" "start" "--scripts-prepend-node-path=auto" 18 verbose node v11.15.0 19 verbose npm  v6.10.0 20 error code ELIFECYCLE 21 error errno 1 22 error<EMAIL_ADDRESS>start:react-scripts start22 error Exit status 1 23 error Failed at the<EMAIL_ADDRESS>start script. 23 error This is probably not a problem with npm. There is likely additional logging output above. 24 verbose exit [ 1, true ]
Did you try recovering your dependencies?
I tried all the steps suggested however, nothing change. Same error as reported above.
I'm using ONLY npm.
npm --version = 6.10.0
create-react-app 3.0.1
Which terms did you search for in User Guide?
npm ERR! code ELIFECYCLE
Error: spawn /usr/bin/chromium ENOENT
Environment
System:
OS: Linux 5.1 Antergos Linux
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
Node: 11.15.0 - /usr/bin/node
Yarn: Not Found
npm: 6.10.0 - /usr/bin/npm
Browsers:
Chrome: Not Found
Firefox: Not Found
npmPackages:
react: ^16.8.6 => 16.8.6
react-dom: ^16.8.6 => 16.8.6
react-scripts: 3.0.1 => 3.0.1
npmGlobalPackages:
create-react-app: 3.0.1
Steps to reproduce

remove chromium from your system.
npx create-react-app anyapp
cd anyapp
npm run start

Expected behavior
Start the application fine with the demo page in localhost.
Actual behavior
It's happening the error posted above.
Reproducible demo
https://github.com/OtavioLara/dfm-frontend

I fix my error.
Its a little bit stranger: Chromium must be installed to make React works.
I suggest adding the dependence of Chromium for the newest projects.

I get an error with (likely) the same cause.
Starting the development server...

events.js:170
      throw er; // Unhandled 'error' event
      ^

Error: spawn google-chrome-unstable ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:253:12)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/arodenius/.npm/_logs/2019-07-08T22_07_33_494Z-debug.log

I get an error with (likely) the same cause.
Starting the development server...

events.js:170
      throw er; // Unhandled 'error' event
      ^

Error: spawn google-chrome-unstable ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:253:12)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/arodenius/.npm/_logs/2019-07-08T22_07_33_494Z-debug.log

I think our tooling can definitely be improved here; failing to open the browser shouldn't be a fatal error.

I get an error with (likely) the same cause.
Starting the development server...

events.js:170
      throw er; // Unhandled 'error' event
      ^

Error: spawn google-chrome-unstable ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:253:12)
    at onErrorNT (internal/child_process.js:431:16)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/arodenius/.npm/_logs/2019-07-08T22_07_33_494Z-debug.log

Try to install Chrome Albert, maybe it is the same solution.

@heyimalex I would very much consider this a bug; not only does chrome need to be installed, it must be the dev branch (at least on CentOS). Running on a headless server, this seems useless, considering that instance of Chrome won't even open. Preventing failure due to an unnecessary dependency seems like more than a proposal.

@Californian You're right. We have a bunch of issues on this, it's a bug in an underlying library that we're working to get fixed.

Ah so sorry, I didn't realize there were other issues. I searched, but
maybe too specifically.
On Mon, Jul 22, 2019, 13:54 Alex Guerra<EMAIL_ADDRESS>wrote:

@Californian https://github.com/Californian You're right. We have a
bunch of issues on this, it's a bug in an underlying library that we're
working to get fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/create-react-app/issues/7337?email_source=notifications&email_token=AAIHR4Z2TCARXGUU3FXFTWLQAYNBJA5CNFSM4H63FMUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2REBXY#issuecomment-513949919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIHR43377K6JDBVEZFMGDDQAYNBJANCNFSM4H63FMUA
.

Is there a way to disable opening the browser? Is there a configuration for this. I don't think it's a good idea to have magic numbers in terms of the browser that may be missing on the system where it is running. I use google-chrome on Fedora and I'm not able to run an application that was created with create-react-app because it tries to open in chromium-browser.
Starting the development server...

node:events:371
      throw er; // Unhandled 'error' event
      ^

Error: spawn chromium-browser ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19)
    at onErrorNT (node:internal/child_process:480:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (node:internal/child_process:288:12)
    at onErrorNT (node:internal/child_process:480:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn chromium-browser',
  path: 'chromium-browser',
  spawnargs: [ 'http://localhost:3000' ]
}

Installing the browser for the library is like requiring to build new airport just because there is this small plain that try to land.

Just as a workaround, at least on GNU/Linux and probably on MacOS ~/bin/ needs to exist and be in $PATH env variable.
ln -s /usr/bin/google-chrome-stable ~/bin/chromium-browser

@jcubic You can set the BROWSER env var to none.

@heyimalex Thanks, this is probably the best solution. What about catching the error that showing proper error message:
"Browser not found try to set a BROWSER environment variable to none"


Features/enforce response type

Use a Generic[T] box to avoid cast in code.
By the way, the ResourceBox could also be used to change the behavior of the response schema validation/deserialization.

Codecov Report

Merging #2 (ab9e3e5) into master (7addbf3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           19        19
  Lines          552       570   +18
=========================================
+ Hits           552       570   +18

Impacted Files
Coverage Δ

src/aioli/__init__.py
100.00% <100.00%> (ø)

src/aioli/domain/exceptions.py
100.00% <100.00%> (ø)

src/aioli/domain/model.py
100.00% <100.00%> (ø)

src/aioli/domain/registry.py
100.00% <100.00%> (ø)

src/aioli/service/client.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7addbf3...ab9e3e5. Read the comment docs.


Changed the timeout number

test for kernel validation pipeline test

@paulli2017 hi, are you planning to update this pull request?

This change is not needed anymore


Front-facing camera will darken

hi,
i run this sample and no change any code. The Back-Facing camera is normal, but Front-facing camera will darken in the preview. I cant find any question. Any body Can help me?
The Question GIF:
https://github.com/lilincpp/MyCameraDemo/blob/master/camera.gif

Facing same Issue...
Though it happens in some devices like it is darken in Redmi Note 4, but works fine on some other devices...

Did you find the solution?

Changing the capture request to TEMPLATE_PREVIEW instead of TEMPLATE_RECORD in startRecording() solves this issue. Not sure how it will affect the video quality though.
previewBuilder = cameraDevice.createCaptureRequest(CameraDevice.TEMPLATE_PREVIEW);

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


feat: Making polling delay configurable via Manifest

Description
This will make testing easier for QA
Links
SDKCF-1346
Checklist

[x] I have read the contributing guidelines.
[ ] I wrote/updated tests for new/changed code
[x] I ran ./gradlew check without errors

Codecov Report

Merging #15 into master will decrease coverage by 0.47%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   73.94%   73.46%   -0.48%
==========================================
  Files          15       15
  Lines         307      309       +2
  Branches       17       17
==========================================
  Hits          227      227
- Misses         76       78       +2
  Partials        4        4

Impacted Files
Coverage Δ

...ch/mobile/remoteconfig/RemoteConfigInitProvider.kt
0% <0%> (ø)
:arrow_up:

...om/rakuten/tech/mobile/remoteconfig/ConfigCache.kt
96.87% <100%> (+0.1%)
:arrow_up:

...om/rakuten/tech/mobile/remoteconfig/AsyncPoller.kt
71.42% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ca43c...f1d06f5. Read the comment docs.

Codecov Report

Merging #15 into master will decrease coverage by 0.47%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   73.94%   73.46%   -0.48%
==========================================
  Files          15       15
  Lines         307      309       +2
  Branches       17       17
==========================================
  Hits          227      227
- Misses         76       78       +2
  Partials        4        4

Impacted Files
Coverage Δ

...ch/mobile/remoteconfig/RemoteConfigInitProvider.kt
0% <0%> (ø)
:arrow_up:

...om/rakuten/tech/mobile/remoteconfig/ConfigCache.kt
96.87% <100%> (+0.1%)
:arrow_up:

...om/rakuten/tech/mobile/remoteconfig/AsyncPoller.kt
71.42% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ca43c...f1d06f5. Read the comment docs.


Offer Duck Typing Fallback for X509TrustManagerExtensions on pre-Android N

On API Level 23 and below, X509TrustManagerExtensions only works if the X509TrustManager supplied to the X509TrustManagerExtensions constructor is the internal TrustManagerImpl implementation. Otherwise, it throws an IllegalArgumentException, with a message of tm is an instance of ... which is not a supported type of X509TrustManager. The Android N implementation uses duck typing, so it can correctly handle any X509TrustManager that supports the required methods (e.g., four-parameter checkServerTrusted()).
Right now, CertificateChainCleaner.get() tries to create an X509TrustManagerExtensions, and if that throws any Exception, falls back to BasicCertificateChainCleaner. Since the X509TrustManagerExtensions constructor fails for anything other than a TrustManagerImpl, this means that CertificateChainCleaner.get() falls back to BasicCertificateChainCleaner for anything other than a TrustManagerImpl.
I am trying to create a backport of the Android N network security configuration code. That requires a custom X509TrustManager called RootTrustManager. This works on N, because of the duck typing. It fails on Android 6.0, because RootTrustManager is not a TrustManagerImpl, and so OkHttp3 does not use the AndroidCertificateChainCleaner, since it fails to create the X509TrustManagerExtensions.
The only way that I can see of getting this to work is if CertificateChainCleaner.get() had an intermediate fallback option. If the X509TrustManagerExtensions constructor fails, try creating an instance of an alternative X509TrustManagerExtensions, forked from the Android N source, that implements the duck typing bit without the references to TrustManagerImpl (since that's an internal class). If that fails, use BasicCertificateChainCleaner. This way, CertificateChainCleaner.get() and AndroidCertificateChainCleaner could handle any X509TrustManager, not just TrustManagerImpl.

While this might matter to others, it turns out that my real problem was another spot in Android where Android wants to work with TrustManagerImpl instead of any X509TrustManager. I have a prototype icky workaround using interceptors to allow for hostname-based checks from a regular X509TrustManager via the two-parameter checkServerTrusted().
I'll leave this open in case you think the issue might matter to others. Sorry to have bothered you prematurely.

Yeah, these APIs are really awkward to deal with. They’re overly general, incomplete, and difficult to use correctly. Happy to chat if you have ideas on how to make it work better. Mostly our goal is to make it do the right thing without any configuration, which as you can see requires a lot of work on our end.


add form data, index not showing

hi,
i dont get why:

wont give me the index for the multiple upload form.
firsst time im usign this plugin, so any help is appreciated
thx
im using this snippet:

Please don't open multiple issues with the same question:
https://github.com/blueimp/jQuery-File-Upload/issues/893