Resize the parent navigation subtitle of IOU report header

Details

Resize the parent navigation subtitle of IOU report header
Fixed Issues

$ https://github.com/Expensify/App/issues/33907
PROPOSAL: https://github.com/Expensify/App/issues/33907#issuecomment-1876310541
Tests

Create a money request
Click on the report preview to open the IOU report
Click on the blank space of the parent navigation subtitle in the IOU header
Verify that the detail page appears
Click on the parent navigation subtitle and verify that we go back to the parent report

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Create a money request
Click on the report preview to open the IOU report
Click on the blank space of the parent navigation subtitle in the IOU header
Verify that the detail page appears
Click on the parent navigation subtitle and verify that we go back to the parent report

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/129500732/9f704d9d-a4d7-4625-9928-1174104ab0db

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/c1e2df6a-ae71-428f-9e57-9bb224d82008

iOS: Native
https://github.com/Expensify/App/assets/129500732/933a45eb-7b9c-4f9b-ac78-8d3858863aab

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/468d8857-003f-4ec7-a9a8-f86c500fc46e

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/d69db69f-ffcf-4c8c-adc9-25abee0d6738

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/12cb4419-f17e-400e-be3b-24e7a9830b7b

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Where to put the dataset or config the dataset?

Where to put the dataset or config the dataset in order to run the code? Thanks a lot!

did you figure out what to modify and how to do it? @scottcali @nothinglo


Feature/gsk 1243 project export doesnt work

Description

[x] Fixed recursive issues
[x] Export tests/slicing/transformation
[x] Fix issue with parameters

Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[x] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[ ] I've read the CODE_OF_CONDUCT.md document.
[ ] I've read the CONTRIBUTING.md guide.
[ ] I've updated the code style using make codestyle.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.

Is this still WIP?
I could review if it's ready and up-to-date

@Inokinoki This PR needs to be updated with main, the export might be broken due to modification of database schema. It was initially on hold due to ongoing refactor of artifacts but we can merge it.

@Inokinoki I've updated the branch and the export seems to be working with latest modification

LGTM
Tested locally, working perfectly!
In addition, should we display something like "export failed" when getting 500 in frontend side? I can add it if you do not have time

I tried to improve the code smell stuff from SonarLint. But I am not sure how to implement the comparison in the remaining one.

I tried to improve the code smell stuff from SonarLint. But I am not sure how to implement the comparison in the remaining one. Could @kevinmessiaen please review them?

Sure I fixed the error. In this case we had to override it to make sure two instance of Callable with same uuid but a different class (eg. SlicingFunction and TransformationFunction) are not interpreted has equals.

LGTM


Improvements for ASR module

Improvements Methods
We can use the 3-gram modules from nemo_toolkit[asr] to avoid the mismatch between words meanings. It can avoid to have incomprehensible words in the transcription of an audio file during ASR steps and improve the understating of rasa NLU.
Steps

Transcripts with log probability mode logits = asr_model.transcribe(files, logprobs=True)[0]
Download 3-gram modules import gzip
import os, shutil, wget

lm_gzip_path = '3-gram.pruned.1e-7.arpa.gz'
if not os.path.exists(lm_gzip_path):
    print('Downloading pruned 3-gram model.')
    lm_url = 'http://www.openslr.org/resources/11/3-gram.pruned.1e-7.arpa.gz'
    lm_gzip_path = wget.download(lm_url)
    print('Downloaded the 3-gram language model.')
else:
    print('Pruned .arpa.gz already exists.')
uppercase_lm_path = '3-gram.pruned.1e-7.arpa'
if not os.path.exists(uppercase_lm_path):
    with gzip.open(lm_gzip_path, 'rb') as f_zipped:
        with open(uppercase_lm_path, 'wb') as f_unzipped:
            shutil.copyfileobj(f_zipped, f_unzipped)
    print('Unzipped the 3-gram language model.')
else:
    print('Unzipped .arpa already exists.')
lm_path = 'lowercase_3-gram.pruned.1e-7.arpa'
if not os.path.exists(lm_path):
    with open(uppercase_lm_path, 'r') as f_upper:
        with open(lm_path, 'w') as f_lower:
            for line in f_upper:
                f_lower.write(line.lower())
print('Converted language model file to lowercase.')

Setup Beam Search Decoder with LM  beam_search_lm = nemo_asr.modules.BeamSearchDecoderWithLM(   vocab=list(asr_model.decoder.vocabulary),
 beam_width=16,
alpha=2, beta=1.5,
 lm_path=lm_path,
 num_cpus=max(os.cpu_count(), 1),
 input_tensor=False)
Use it for the probabilistic distribution of the likelihood terms on the 3-gram model application  beam_search_lm.forward(log_probs = np.expand_dims(probs, axis=0), log_probs_length=None)

Output is an in-order array of tuples which the first element is the confidency of the "correct words" and the second one is the correct sentence.
Source: https://colab.research.google.com/github/NVIDIA/NeMo/blob/main/tutorials/asr/Offline_ASR.ipynb

Done


Make Context builder use local files in both Prod and Development

Fixed in #28 branch
Both test and production is now based on static http files.
Building context and rendering is quick for the sites size.
Locally for test http-server is used to expose pages.


[BUG] tsx fails to resolve .tsx file when imported with .js extension in Typescript ESM project

Bug description
tsx is able to resolve to .js and .ts files but fails to resolve .tsx files when trying to import using a .js extension in a Typescript ESM project.
For example:
import { MyComponent } from './MyComponent.js'

The import statement above should resolve to ./MyComponent.ts or ./MyComponent.tsx as per this discussion and the official TS docs. Typescript will not rewrite import statements (specifically the extension) when transpiling, so the .js extension is required in import statements inside ESM projects. This is so the transpiled code can correctly resolve to the final target file.
However, I'm geting this error when using tsx:
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '<REDACTED>/MyComponent.js' imported from <REDACTED>/index.ts

It works perfectly fine when using ts-node (specifically ts-node-esm) and also when building with tsc
Reproduction
https://stackblitz.com/edit/stackblitz-tsx-esm-bug?file=index.ts
Environment
System:
    OS: Linux 5.19 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 7.20 GB / 31.24 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.16.0 - ~/.volta/tools/image/node/18.16.0/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 9.5.1 - ~/.volta/tools/image/node/18.16.0/bin/npm
    pnpm: 8.6.9 - ~/.local/share/pnpm/pnpm
  npmPackages:
    tsx: ^3.12.7 => 3.12.7

Can you work on a fix?

[ ] I’m interested in opening a pull request to address this issue.

Closing as a duplicate of https://github.com/esbuild-kit/tsx/issues/112


@tailwindcss/forms not working with @nuxtjs/tailwindcss:^5.1.2

Version
@nuxtjs/tailwindcss: 5.1.2
nuxt: 2.15.5
What is Expected?
reset for input styles provided by this plugin, like this

What is actually happening?
Nothing, these styles do not exist
This worked fine with version 4.1.1, but after upgrading to version 5.1.2 it no longer works

Can you please provide a reproduction and re-open the issue?


Face detection Issue in different device orientaion and preview orientation

Currently this plugin does not respond to device orientation change and preview orientation change, and thus detection is not proper if device is holded in different orientation other than potrait (max rollAngle for detection goes up to 100deg ) . Need feature like passing arguments with frame which accounts for angle rotation

without reproducible code I can't help


fix pytorch_default_init()

torch.nn.init.trunc_normal_() defaults to truncation at (a, b), not (a * std, b * std). So to conform to JAX's variance_scaling(..., distribution="truncated_normal", ...) we need to multiply by std ourselves. We can see this by initializing a test model. Here is the repo's JAX ViT-S/16:
>>> import jax.numpy
>>> import jax.random
>>> from algorithmic_efficiency.workloads.imagenet_vit.imagenet_jax.models import ViT
>>> from algorithmic_efficiency.workloads.imagenet_vit.workload import decode_variant
>>> vit = ViT(**decode_variant('S/16'))
>>> x = jax.numpy.zeros((1, 224, 224, 3), jax.numpy.float32)
>>> params = vit.init(jax.random.key(0), x)
>>> for w in [params['params']['conv_patch_extract']['kernel'], params['params']['pre_logits']['kernel']]:
...   print(w.min(), w.max())
...
-0.08204417 0.08203908
-0.11602508 0.116011634

Here is the repo's PyTorch ViT-S/16 before the fix:
>>> from algorithmic_efficiency.workloads.imagenet_vit.imagenet_pytorch.models import ViT
>>> from algorithmic_efficiency.workloads.imagenet_vit.workload import decode_variant
>>> vit = ViT(**decode_variant('S/16'))
>>> for w in [vit.conv_patch_extract.weight, vit.pre_logits.weight]:
...   print(w.min(), w.max())
...
tensor(-0.2119, grad_fn=<MinBackward1>) tensor(0.1907, grad_fn=<MaxBackward1>)
tensor(-0.2749, grad_fn=<MinBackward1>) tensor(0.2512, grad_fn=<MaxBackward1>)

Here is the repo's PyTorch ViT-S/16 after the fix:
>>> from algorithmic_efficiency.workloads.imagenet_vit.imagenet_pytorch.models import ViT
>>> from algorithmic_efficiency.workloads.imagenet_vit.workload import decode_variant
>>> vit = ViT(**decode_variant('S/16'))
>>> for w in [vit.conv_patch_extract.weight, vit.pre_logits.weight]:
...   print(w.min(), w.max())
...
tensor(-0.0820, grad_fn=<MinBackward1>) tensor(0.0820, grad_fn=<MaxBackward1>)
tensor(-0.1160, grad_fn=<MinBackward1>) tensor(0.1160, grad_fn=<MaxBackward1>)

Affected current workloads include imagenet_vit, imagenet_resnet, fastmri, and ogbg, along with (retired? test?) workloads cifar and mnist.
I hope this bug doesn't drastically upend the results so far but I don't know 😬

recheck

Hi Jason, thanks for sending this PR in. This is a very interesting and good catch!
Did you sign the CLA with your github email and username to unblock the CLA check?
It's hard to say at the moment what the final effect is of this difference in initialization. My guess is that it is probably not going to upend the result but we can double check this.

Hi Jason, thanks for sending this PR in. This is a very interesting and good catch! Did you sign the CLA with your github email and username to unblock the CLA check?
I have signed and emailed the CLA. I think the system has identified me as a signee, just not rerun the pull_request_target automatically.


/sethome and /home Issue

So when a player uses /sethome it says "Home  set."
But when the player moves somewhere and types /home it says "Teleported to you home " but actually teleports you to the same coordinates in ..
This is frustrating a lot of good players on my server.
I use AdminCMD for these commands. But I know for a fact that it is Multiverse that is causing the issue.
Would it possibly be because the world I'm trying to set home in is not the original spawn world?

It HAS something to so with Multiverse ....
other example:
I tried to use /home.
Before i used multiverse it worked for me and all others on server.
But after
installing multiverse -> importing the worlds -> deleted the New worlds it HAS created (mistake in config) --> goin online
.... cool ... the old worlds were loaded ...
i tried to use /home ... it told me: Wrong world. ...
after this i tried /home [Name_of_World] [Name_of_Home]
but there was a unexpected text in chat:
"Homes: home, hier, da, Lager, Spawn, bed"
it only shows me the names of homes but didnt teleport me there ....
And u want to say me, that the /home command isnt affected by multiverse???
go lost !

The only possibility that Multiverse has something to do with this is that you're using Multiverse-Inventories. Even then, there's probably nothing we're doing wrong. It's likely a conflict between the way Multiverse-Inventories works and AdminCMD works. You can disable home sharing in MV-Inv. I'll leave that as an exercise for the reader.


Automated cherry pick of #2305: Fix wrong types and missing field selectors in legacy APIs

Cherry pick of #2305 on release-1.0.
#2305: Fix wrong types and missing field selectors in legacy APIs
For details on the cherry pick process, see the cherry pick requests page.

Codecov Report

Merging #2314 (2569723) into release-1.0 (2fdf854) will decrease coverage by 19.50%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-1.0    #2314       +/-   ##
================================================
- Coverage        60.81%   41.30%   -19.51%
================================================
  Files              270      131      -139
  Lines            20393    16461     -3932
================================================
- Hits             12402     6800     -5602
- Misses            6700     9079     +2379
+ Partials          1291      582      -709

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.30% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


[BUG] 16.1 reports (Avira grabbed as threat DROP.WIN64.MemTaskProcess)

Hi, first hour usage report.
please review.

IMPORTANT!!! FLAGGED and put in quarantine by antivirus. please check what kind of memory task the app intrude into the system that triggers the antivirus protocols?

Tensor.Art Json data is still not recognized.

custom Hotkeys    (let us use keyboard shortcuts for hotkey usage)

Prompt section is still not opening thumbnails to full screen or find in explorer or expand to folder.
each section should have common system of usage. otherwise, what is the usage of the prompt section?

I will report further soon.
regards
Dan

It would be great if you could report this to Avira as I am sure I don't do any memory modification. I can't spend all the time trying to remedy antivirus issues when practically no other users have reported it. I will not follow up on virus reports.

I have to fix and implement things one at a time.  Please be patient.

This is not a priority for me. I would like to focus on functionality and bugs before other things. Realize that everything takes time, and this is just a hobby for me. It takes A LOT of my time. I have a normal job, and other responsibilities.

Again, I'm working on this. There are a lot of features I would like to implement and I have to prioritize them. Please be patient.

It would be good if you could limit your language to reporting issues and requesting and not demanding features.
The purpose of creating an issue such as you did before for Tensor.Art is so that is can be talked about there and not repeatedly demanded in separate issues.
A lot of issues here have been sitting for months before I can prioritize them.
Please be patient.

ChatGPT
"drop.win64.memtaskprocess" is a detection name used by Avira antivirus software to identify a potentially malicious file or behavior related to memory manipulation or exploitation on the Windows 64-bit platform.
When Avira flags an app with this detection name, it means that it has detected suspicious behavior or characteristics in the app that could indicate a threat to the security of your system. This could include actions such as attempting to access sensitive system resources, modifying system memory, or executing code in a suspicious manner.

Does this have the same issue?
https://github.com/RupertAvery/DiffusionToolkit/actions/runs/7886310992/artifacts/1241357022

using the link above,
so far so good.
nothing to report yet.
apologies if i sounded rushing. just excited. and wanted to help.
take your time.
Cheers.


Generate config with JWT key on first startup

As of Kolide 1.0.4, the server will not start up without a JWT key specified in
the config. This PR adds support for that by generating a random JWT key.

Tested this with the 1.0.4 release and it seems to work.


ciao-image: Add delete image support

This commit makes the proper changes for enabling functional image delete operation.
Signed-off-by: Munoz, Obed N<EMAIL_ADDRESS>

Coverage increased (+0.05%) to 66.459% when pulling 1963c28d63ba983b9a66e1f46e791a92247d452c on obedmr:ciao-image into 63e71843443cb74433cbc29fe00f53193d05095a on 01org:master.

Coverage increased (+0.05%) to 66.459% when pulling 0784955ad7b14f9c793e2c3e6376aab3a60ecc5b on obedmr:ciao-image into 63e71843443cb74433cbc29fe00f53193d05095a on 01org:master.

Coverage increased (+0.03%) to 66.435% when pulling 0784955ad7b14f9c793e2c3e6376aab3a60ecc5b on obedmr:ciao-image into 63e71843443cb74433cbc29fe00f53193d05095a on 01org:master.

@obedmr Code looks okay to me.  Could you add a description to your commit message?
@sameo, @kaccardi is this one okay for you?

Coverage decreased (-0.01%) to 66.46% when pulling 5f5de7b8edd0dec286a96f85858607e8898a952d on obedmr:ciao-image into dd91b0ed001bc365953537a5a4aa8b7742010693 on 01org:master.

@kaccardi, @markdryan @sameo, it's updated. When you have a chance could you take a look on it?

Coverage decreased (-0.05%) to 66.953% when pulling b8a880cd5e3aa9a3ab026d4ccd2ba0d9e283d3ca on obedmr:ciao-image into 2f601f6a3e022e421af9d6ebc8e53aca0baf1d51 on 01org:master.

@kaccardi, when you have a chance, could you take a look on it? I just added the missing test.


Changed user defined role names

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like this applies to version 1.1 and later. Will this change be backported to the 1.1 docs?

Yes, I'll backport it to 1.1 as well.


I made a package generator with gui

https://github.com/brutalzinn/NetSparkle-Generator-Package
thanks for the library.

Hi @brutalzinn! Apologies for the slow reply. Thank you for making a package generator GUI; however, it appears that your repo is down or otherwise closed, so I will be closing this issue. Thanks for your participation in the NetSparkleUpdater repo!


Add Profile: Meet Jain

Profile Submission
Please paste a screenshot of your GitHub profile here.

Profile Category
Please select one or more categories for your profile:

[ ] Badge 🎖
[ ] Minimalistic ✨
[ ] Dynamic 🔄
[ ] Icons 🎯
[ ] Backgrounds 😎
[ ] GIFS 🖼
[ ] Game Mode 🚀
[ ] Code 👨💻

Next Steps
Once you've filled out the information, please comment below:
@all-contributors please add @<username> for review

@Meetjain1 please add ""@all-contributors please add @ for review"" this comment

@all-contributors please add @Meetjain1 for review


React 18

npm fails to install React 18 with react-avatar as it wants React 17. Could you please release a version that relaxes this requirement? Thank you in advance.

Resolved by https://github.com/ambassify/react-avatar/pull/236


Continue #86: Test of merge process: DO NOT MERGE!

This is the continuation of PR #86.

This was a test. Closing without merging.


[ENG-660] Update Maya's testimonial image

Purpose
Now that we have a new image of Maya, we should replace the old image with the new one.
Summary of Changes

Remove the old image of Maya and replace it with the new one
Move testimonial images from assets/images/dashboard to assets/images/new-home with the other static images
Remove unused stying from css

Side Effects
N/A
Feature Flags
N/A
QA Notes
This will replace the old image in the testimonials carousel on the new logged-out homepage.  Please make sure that this works on all devices/browsers and that the image sizing doesn't do anything weird.
Ticket
https://openscience.atlassian.net/browse/ENG-660
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 3115

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.495%

Totals

Change from base Build 3110:
0.0%

Covered Lines:
6327

Relevant Lines:
7881

💛  - Coveralls


Update version to 1.2.94-0 on staging

Update version to 1.2.94-0

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!


More VM registers!

While working on this tiny all-in-one-voice song/program, I managed to run out of VM registers. (That's why the song is wrapped by a parent voice. The 'fbdelay' unit didn't fit!)
Unless I'm forgetting something, both opcode and register index fields are now at least 8 bits everywhere, so it should be safe to just bump A2_REGISTERS from the current 32 to anything below or equal to 256.
Just check that any 8 bit indices are actually unsigned if going >= 128! And of course, check that A2_REGISTERS is actually used everywhere it should be.

Things to keep in mind:

The register arrays in voices and stack entries are fixed size!
Performance impact on local function calls and message handling. Push/pop copy ALL registers that are not used as unit control registers! (Because the compiler doesn't tell the VM how many registers a function will use, or the VM is too lazy to check; don't remember...)
Unit control registers are NOT saved in calls, so R[0] in a A2_stackentry actually maps to the first non-control VM register.
Current struct sizes (32 registers):

A2_stackentry: 144 bytes
A2_voice: 976 bytes


Debugger hags on s.client.mu.RLock()

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[x] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
If using debugger and there is no elastic instance - ping results to hang of debugger.
The line of hang is https://github.com/olivere/elastic/blob/release-branch.v7/ping.go#L122
s.client is nil in this case and debugger can`t proceed for some reason.
Please describe the expected behavior
Code flow goes forth
Please describe the actual behavior
Debugger hangs.
Any steps to reproduce the behavior?
OS: MacOS Catalina
Go: go1.13.3 darwin/amd64
Make sure there is no elastic instances reachable.

If client is nil, there is something wrong with initialisation. How do you create and access the Ping API. Can you share a code snippet?

Ok, I found the issue in my codebase, but I think you should check pointers for nil everytime you call them to avoid panics.

No. It’s an error if the caller passes a nil.


OHRI-988 Fix search box

@kajambiya  @ODORA0  does this closes the pending work in the ticket?
If yes @kajambiya assign for review


Pass branch name from codebuild to e2e tests

Description of changes:
BRANCH_NAME env var is already available in codebuild runs and the e2e tests understand T_BRANCH_NAME and are able to use to determine the prior available release.
This just closes the bridge, passing the value to the e2e test runner binary and from them to the e2e tests through the ssm command. It defaults to main when not set.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

Testing the cherrypick command
/cherrypick release-0.7

/cherrypick release-0.7

/cherrypick release-0.7


Latest commit crashes with Failed to initialize EGL on NixOS using an Nvidia GPU.

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 7ce781e87cf7cf789a54d37af7d78f1c11d66dbc  ().
Date: 2024-03-02
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: naiad
Release: 6.7.6-xanmod1
Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue Jan  1 00:00:00 UTC 1980

GPU information:
08:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP104 [GeForce GTX 1080] [10de:1b80] (rev a1) (prog-if 00 [VGA controller])

os-release: ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240229.1536926"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

plugins:

Bug or Regression?
Regression
Description
Crashes on startup after updating from 7ce781e87cf7cf789a54d37af7d78f1c11d66dbc to fcd9d77b642c0cd45cae61cf10ed1924f2e7945b. As the crash is instant I cannot run hyprctl on the broken build. The information above is from the latest working build I have.
@fufexan
How to reproduce
Run Hyprland from fcd9d77b642c0cd45cae61cf10ed1924f2e7945b on NixOS with an Nvidia GPU.
Crash reports, logs, images, videos
hyprland.log
hyprlandCrashReport8569.txt

git bisect please

Any news on this? I just installed NixOs and tried to use Hyprland. I also have a Nvidia gpu

You can try using vulkan (Not supported)
To do this add: env = WLR_RENDERER,vulkan to you hyprland.conf

it doesn't do anything.

C'mon man, at least he's trying to help us here.
Anyways, I "fixed" the problem my Nvidia GPU was causing (it's more like a workaround). It seems there's some issues with the stable release of the Nvidia drivers.
I'll leave my current solution here in case it helps.
This didn't work for me (not right now)
# configuration.nix
hardware.nvidia.package = config.boot.kernelPackages.nvidiaPackages.stable; # --> points to version 550

This actually worked
# configuration.nix
hardware.nvidia.package = config.boot.kernelPackages.nvidiaPackages.mkDriver {
    version = "535.129.03"; # --> older but working version
    sha256_64bit = "sha256-5tylYmomCMa7KgRs/LfBrzOLnpYafdkKwJu4oSb/AC4=";
    sha256_aarch64 = "sha256-i6jZYUV6JBvN+Rt21v4vNstHPIu9sC+2ZQpiLOLoWzM=";
    openSha256 = "sha256-/Hxod/LQ4CGZN1B1GRpgE/xgoYlkPpMh+n8L7tmxwjs=";
    settingsSha256 = "sha256-QKN/gLGlT+/hAdYKlkIjZTgvubzQTt4/ki5Y+2Zj3pk=";
    persistencedSha256 = "sha256-FRMqY5uAJzq3o+YdM2Mdjj8Df6/cuUUAnh52Ne4koME=";
};

As I said, it's just a workaround. I guess this issue won't last for long.
Okay bye!

C'mon man, at least he's trying to help us here.

No, it's misleading and I have repeated 100 times that there is no vulkan renderer in hyprland, no matter what env you set.

Went through git bisect and found no broken Hyprland commits. Currently using 81766647f2dc34013a62066edd191426b8f16a42 along with the closed source nvidia 550.54.14 driver. These are pinned to their versions and work. However updating the lockfile with these two pinned to working versions still result in Hyprland crashing with the same log posted above. Therefore it seems to me like the culprit is another package (wlroots?) entirely.
Regardless, this is about as far as my ability to debug goes. Hopefully someone more knowledgeable can chime in.

likely a wlroots issue so I will close this


Feature/fix location listener crashes

Fix for #40 and #33 (and also an edge case for #24 that has already been closed)

This PR requires some more work

@xni06 currently I am not able to test it, can you please confirm if I can accept the PR?

I'll reply this weekend once I'm back from holiday.
On Thu, 12 Mar 2020, 10:03 igaurab<EMAIL_ADDRESS>wrote:

@xni06 https://github.com/xni06 currently I am not able to test it, can
you please confirm if I can accept the PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/igaurab/user_location_plugin/pull/41#issuecomment-598078244,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7NFWQHNWGOFT44JRCIA6DRHCQM3ANCNFSM4LD4JX3Q
.

Upon touching the location button, there was an error log - fixed
Upon touching the location button then navigating back, an error would be logged continuously - fixed

These were confirmed during regression testing in both dev and release mode.
In addition, this PR has been positively commented on in https://github.com/igaurab/user_location_plugin/issues/37#issuecomment-598436110


Missing install_windows_package matcher

Using the windows_package resource we are getting the below errors when running spec tests.
Chef::Exceptions::NoSuchResourceType
------------------------------------
Cannot find a resource for windows_package on chefspec version 0.6.1

Doing some research I can see that this same issue was addressed in issue https://github.com/sethvargo/chefspec/issues/372 but at the time windows_package was only included in the Windows cookbook.  It appears that windows_package was added as a Chef resource shortly after https://tickets.opscode.com/browse/CHEF-5087?page=com.atlassian.jira.plugin.system.issuetabpanels:changehistory-tabpanel.
Searching through this repo, I don't see any results for windows_package.  Should this be added or is it still out of scope?
If it helps, I'm using Chef 12.4.1 and Chefspec 4.3.0.

Thanks for adding this @sethvargo!!

Issue's closed, but I'm seeing this error in ChefDK 0.10.0 (i.e. chef-client 12.5.1, chefspec 4.4.0) when my recipe includes the 'env' resource:
env 'FOO' do
  value 'bar'
end

--> "Cannot find a resource for env on chefspec version 0.6.1"
Tried adding platform/version opts to the SoloRunner constructor, but that didn't seem to matter. Specs for the recipe's remaining resources (service, cookbook_file, remote_file, template) all pass if I comment out the 'env' resource block.

Same issue here using the windows_package  resource:
Chef::Exceptions::NoSuchResourceType
------------------------------------
Cannot find a resource for windows_package on chefspec version 0.6.1

...

  1:  # Download and installs the package
  2>> windows_package 'AWS Command Line Interface' do
  3:    source    node['awscli']['installer_url']
  4:    checksum  node['awscli']['installer_checksum']
  5:    version   node['awscli']['version']
  6:    action    :install
  7:  end  8:

chef-dk Version 0.10.0
chef-client Version: 12.5.1
chefspec Version: 4.4.0


TypeError: 'coroutine' object is not subscriptable

I tried to read the consumption and since the script was not responding I broke the execution. Now I get these errors.  ("TypeError: 'coroutine' object is not subscriptable" and "Unclosed client session")
I understand that the unclosed client session is a matter of time but the other one I don't have any idea of what can it be solved.
line 108, in watthourmeter
return await self.measurement()["consumption"]
TypeError: 'coroutine' object is not subscriptable
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fca57225ed0>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x7fca575ecad0>, 1.628017473)]']
connector: <aiohttp.connector.TCPConnector object at 0x7fca575af450>
thanks for the tool!

Fixed in version 1.3.1


CDIConfig resource - 1991

[Auto generated]
Number: [#1991]

openshift-python-wrapper[pull_request][4f1b-11ef-9e45-ee3e5a55c575][PR 1991]: Closing issue for PR: CDIConfig resource.
PR was closed.


Custom Commands

Allows users to define custom commands that can change their contents based on various conditions, such as supplied arguments or the name or roles of the command's user. Major time investment, since it's basically writing a miniature programming language.

7c4a2b0d2132ce5e90baedf6959c5b3a1ce8c39f makes this complete enough to close.


Interface with property is kept in minified code in advanced mode

I have an interface with a property:
/**
 * @interface
 */
class Interface {
    get property() {}
    method() {}
}

Then I implement it:
/**
 * @implements Interface
 */
class Implementation {
    constructor(property) {
        this.property = property;
    }
    method() {
        return this.property;
    }
}

And compile it with advanced mode (v20151216.2.0):
Object.defineProperties(function(){}.prototype,{a:{configurable:!0,enumerable:!0,get:function(){}}});function a(c){this.a=c}window.b=a;alert((new a("test")).a);

The strange thing is that the interface is kept even though it isn't directly used. If I use a getter instead, I get the following code:
function b(c){this.a=c}window.a=b;alert((new b("test")).a);

Which is what I would have expected from the interface with a property as well. I will just use getters for now, but thought it's worth reporting.

Which version of the compiler?

v20151216.2.0

Seems to repro at head too.
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%250A%2520*%2520%2540interface%250A%2520*%252F%250Aclass%2520Interface%2520%257B%250A%2520%2520%2520%2520get%2520property()%2520%257B%257D%250A%2520%2520%2520%2520method()%2520%257B%257D%250A%257D%250A%250A%252F**%250A%2520*%2520%2540implements%2520%257BInterface%257D%250A%2520*%252F%250Aclass%2520Implementation%2520%257B%250A%2520%2520%2520%2520constructor(property)%2520%257B%250A%2520%2520%2520%2520%2520%2520%2520%2520this.property%2520%253D%2520property%253B%250A%2520%2520%2520%2520%257D%250A%2520%2520%2520%2520method()%2520%257B%250A%2520%2520%2520%2520%2520%2520%2520%2520return%2520this.property%253B%250A%2520%2520%2520%2520%257D%250A%257D%250A%250Aalert((new%2520Implementation('')).property)%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26DEAD_ASSIGNMENT_ELIMINATION%3D1%26FOLD_CONSTANTS%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26REMOVE_DEAD_CODE%3D1%26REMOVE_UNUSED_CLASS_PROPERTIES%3D1%26REMOVE_UNUSED_PROTOTYPE_PROPERTIES%3D1%26REMOVE_UNUSED_PROTOTYPE_PROPERTIES_IN_EXTERNS%3D1%26REMOVE_UNUSED_VARIABLES%3D1%26TRANSPILE%3D1

We can probably just warn about getters/setters in interfaces.

We just need to get @blickly fix for smart name removal relanded.


Specify class (or set of classes) as attribute

It would be very handy to be able to set a specific tag or class name as the "attribute" to search against.

By default, the results are based on the text inside the list elements, but, you can change this by setting the attribute you want with the option "attribute". E.g. If you have a list of logo images (for example a list of brands) you can set the option "attribute" to "alt".


401 Client Error: Unauthorized for url

Hi. I'm using your storage as a default file storage. I'm reading file content in some celery tasks and everything works ok, but after some moment I'm starting to get HTTP 401 Error. After restarting celery the error disappears but on the next day it's come back.
It's looks like your Auth class for some reason doesn't reauthenticate after token expired. It's weird because the container is public and file content can be accessed without authentication.
Stacktrace (most recent call last):

  File "mail/tasks.py", line 46, in send_email
    content = attachment.file.read()
  File "django/core/files/utils.py", line 16, in <lambda>
    read = property(lambda self: self.file.read)
  File "django/db/models/fields/files.py", line 43, in _get_file
    self._file = self.storage.open(self.name, 'rb')
  File "queued_storage/backends.py", line 172, in open
    return self.get_storage(name).open(name, mode)
  File "django/core/files/storage.py", line 36, in open
    return self._open(name, mode)
  File "django_selectel_storage/storage.py", line 13, in _open
    return base.ContentFile(self.container.open(name).read())
  File "django_selectel_storage/selectel.py", line 110, in open
    stream=True).raw
  File "django_selectel_storage/selectel.py", line 106, in perform_request
    **kwargs)
  File "django_selectel_storage/selectel.py", line 79, in perform_request
    resp.raise_for_status()
  File "requests/models.py", line 941, in raise_for_status
    raise HTTPError(http_error_msg, response=self)

401 Client Error: Unauthorized for url: https://144411.selcdn.ru/3dplitka_media/uploads/organizations/requisites/Hafizova.docx

I'm using Python 3.7.6 with Django 2.2.12 and django-selectel-storage 1.0.0

Suppose, you're right in your point about it could not refresh the token. Gonna research it deeply.

It's weird because the container is public and file content can be accessed without authentication.

I think it's because the token is wrong. If you provide the correct one or just drop it off,  it would work as expected. At least, I clicked on the link from the traceback and got a .docx file

Thanks for a fast reply. Looking forward for a fix, now I'm just catching 401 exceptions and reauthenticate your storage manually but it's a dirty way.

Well, if it works, who cares? :)
BTW... Maybe if you have some time for that, can you please fork the app and put some loggers there to get what's happening there? What data is sent, timestamps, etc.
After all, you have a working stand reproducing an error :) Not sure if I can repeat it fast.

Well, if it works, who cares? :)

My inner perfectionist :)  I'll try to investigate this problem deeper in the next days and send you a pull request with fix

Would be great!

23 апр. 2020 г., в 18:41, idealatom<EMAIL_ADDRESS>написал(а):
Well, if it works, who cares? :)
My inner perfectionist :) I'll try to investigate this problem deeper in the next days and send you a pull request with fix
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

After some debugging I didn't found any reason why I'm getting those 401 errors. So I just added a check to reauthenticate and repeat request if needed.


Mobile menu overlay

added mobile menu
removed flip right from languages
added javascript touch to the navigation in mobile version

please don't ask me to fix that bottom horizontal scroll bar already spend a lot of time there

due to  that scroll bar my navbar wobble around
and I don't know from where I need to put the 45000 px margin in about me I think that is the one creating the problem
I try to fix the width of 100%
I tried margins 0 as well nothing works there
It was like this before the animation  think so i don't think that is the problem
also this problem is only for the mobile version

@PowerLevel9000  there is nothing wrong with your horizontal scrollbar 😄 so no need to panic 😉
cheers 🥂


Another syntax for Pack()

This keyword is bad. Perhaps we can allow for both list() and dict() to do the same thing that Pack() is doing now. This also caters for both Python and R users.

How about Bind()?

i kind of prefer the idea of using both dict() and list()
Matthew
On Thu, Jan 12, 2017 at 3:26 PM, gaow<EMAIL_ADDRESS>wrote:

How about Bind()?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stephenslab/dsc2/issues/40#issuecomment-272288444,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABt4xXZsRJs3HPxyxqxyqpV_1aWZRjxbks5rRppqgaJpZM4Kln2D
.


Do not render templates when decrypting neededForUsers secrets

This fixes https://github.com/Mic92/sops-nix/issues/659
In https://github.com/Mic92/sops-nix/pull/649, we started rendering templates twice:

When rendering neededForUsers secrets (if there are any neededForUsers secrets).
When decrypting "regular" secrets.

This alone was weird and wrong, but didn't cause issues for people until https://github.com/Mic92/sops-nix/pull/655, which triggered https://github.com/Mic92/sops-nix/issues/659. The cause is not super obvious:

When rendering neededForUsers secrets, we'd generate templates in /run/secrets-for-users/rendered.
However, the path for these templates is in /run/secrets/rendered, which is not inside of the /run/secrets-for-users directory we're dealing with, so we'd generate a symlink from /run/secrets/rendered/<foo> to /run/secrets-for-users/rendered/<foo>, which required making the parent directory of the symlink (/run/secrets/rendered/).
This breaks sops-nix's assumption that /run/secrets either doesn't exist, or is a symlink, and you get the symptoms described in https://github.com/Mic92/sops-nix/issues/659.

Reproducing this in a test was straightforward: just expand our existing template test to also have a neededForUsers secret.
Fixing this was also straightforward: don't render templates during the neededForUsers phase (if we want to add support for neededForUsers templates in the future, that would be straightforward to do, but I opted not do that here).

@mergify queue


docs(playwrighttesting): dotnet namespace fix and CHANGELOG update

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Feature: $util.map methods

Map helpers in $util.map
$util.map contains methods to help with common Map operations, such as removing or retaining items from a Map for filtering use cases.
$util.map.copyAndRetainAllKeys(Map, List) : Map
Makes a shallow copy of the first map, retaining only the keys specified in the list, if they are present. All other keys will be removed from the copy.
$util.map.copyAndRemoveAllKeys(Map, List) : Map
Makes a shallow copy of the first map, removing any entries where the key is specified in the list, if they are present. All other keys will be retained in the copy.

See PR https://github.com/skyhookadventure/appsync-template-tester/pull/7


failed to apply patch when I compile the firmware

Hi, I am trying to compile the firmware but I got the following errors:

Sorry if this is a dumb question, I followed the procedures listed in /coordinator/Z-Stack_3.x.0/COMPILE.md, I placed the firmware.patch under workspace_v12 as shown below:

Then I modify the Minimal Poll Period (ms) to 1000 ( without saving), and then change it back to 100 and save the file.
I also checked the versions, I am using SIMPLELINK-CC13XX-CC26XX-SDK <IP_ADDRESS>, but for the Code Composer Studio, I am using  Version: <IP_ADDRESS>09

It fails on syscfg, did you do step 5 from https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/COMPILE.md ?

It fails on syscfg, did you do step 5 from https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/COMPILE.md ?

"I did follow step 5, and then apply the patch and built the firmware with the command git apply --reject firmware.patch --ignore-space-change. The firmware I built works for the CC2652R1, which is great! However, I also want to test the firmware on the CC2652R7. Unfortunately, not only does the firmware I built not work on the R7, but the hex file extracted from 'coordinator/Z-Stack_3.x.0/bin/CC2652R_coordinator_20221226.zip' doesn't work either.
I then built a firmware based on the znp_LP_CC2652R7_tirtos_ticlang and flashed it to the R7. At least the LED turned on this time, but I got an error from Z2M, as shown below:

Zigbee2MQTT:error 2023-04-10 10:28:58: Failed to start zigbee
Zigbee2MQTT:error 2023-04-10 10:28:58: Check https://www.zigbee2mqtt.io/guide/installation/20_zigbee2mqtt-fails-to-start.html for possible solutions
Zigbee2MQTT:error 2023-04-10 10:28:58: Exiting...
Zigbee2MQTT:error 2023-04-10 10:28:58: Error: SRSP - SAPI - readConfiguration after 6000ms
at Timeout._onTimeout (/app/node_modules/zigbee-herdsman/src/utils/waitress.ts:64:35)
at listOnTimeout (node:internal/timers:569:17)
at processTimers (node:internal/timers:512:7)
Using '/app/data' as data directory

My question is, does the firmware.patch supports CC2652R7? If not, can I reuse most parts of the patch, as the R1 and R7 are very similar?

Hello
I spent plenty of time trying to fix this issue. I finaly made it work by using the patch system directly from code composer studio.
go to the project root, right click ->Team->apply patch, select the firmware.patch file and then run. it worked perfectly for me and remove issues from git bash.
I am now facing a different challenge as the generated hex file is a bit bigger than the one provided (410k vs 388K), i will try to find wich option make this change...
hope it helps


Move api cred acquire to getting started page, simplified Payment page

Api credentials were also set to be stored in localStorage to be available to other components. Also added error checking in the Payment page to reject attempt if credentials are blank.


More tests ported

We need to port more tests from File::Which. Namely the following tests:
https://metacpan.org/source/PLICEASE/File-Which-1.21/t/03_simple.t
and
https://metacpan.org/source/PLICEASE/File-Which-1.21/t/02_all.t

I've looked at these tests and they define a slightly different behavior of the library. As a really quick example: first test stands for returning an undef (or Any in Perl 6) for a null-length strings, while this library just throws an exception.
I can write them, but it will cause changes to the library itself from me. Is it okay?

Go for it :+1:

Just see the latest PR.

Windows tests fixed in https://github.com/azawawi/perl6-file-which/commit/51a1412052cc9cd990a7ca4686705fefc76736d8. Thanks for your contribution. Please add your name in README :+1:


Update bom to 2950.va_633b_f42f759

updates the bom to 2950.va_633b_f42f759 to pick up https://github.com/jenkinsci/subversion-plugin/pull/284

Testing done

Submitter checklist

[ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[ ] Ensure that the pull request title represents the desired changelog entry
[ ] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord #129 has the enhancement label so there should be a release with both in a few minutes.


Queue multiple calls

My client side app needs to do multiple calls (sometimes even 100s of calls) to the server. This slows things down dramatically even when the server processing time is fast enough.
What is the recommended way to do it?

Do you have to trigger the requests in some specific order?

@charlesrochati not necessarily but I do wonder if queueing them will help?

I don't think that queueing the requests will make any relevant performance improvement (if you're doing it with axios.all).
Can't you just take those hundreds of requests and refactor them into 5 or 10? Even if those 5 or 10 requests transfer more data, it would be better, once it is not creating lots of process for the client to take care of.

For general programming questions please use StackOverflow or any other forum platform. We're trying to maintain this only to report bugs or request features in axios.


Prototype of implementing SAI DMA on ChannelA/B compound types

Implement as wrapper type instead, which allows us to pretend this is a smart pointer type and make use of deref coercion
This is actually backwards compatible, so the old fixed mapping (write on channel A, read on channel B) still works

ref #329

bors r+


Remove plugins list from cobalt.conf

Remove plugins list from cobalt.conf, add class paths to web code and send them with the plugin event. Comme ça on a juste les modules web/android/ios à charger et rien de + à faire.

@ggendre You're still working on it?

yes. here is a status :

[x] load classes and name from JS event on Android
[ ] load classes and name from JS event on iOS in progress GG

Web plugins :

[x] appInfos
[x] actionPicker
[x] batteryStatus
[x] networkStatus
[x] share
[x] pdf
[x] geolocPicker
[x] locationPlugin
[x] snackbar
[x] signature vincent : manque apperçu image
[ ] assetCache vincent
[ ] FCM
[ ] FirebaseAnalytics

Android plugins :

[x] appInfos
[x] actionPicker
[x] batteryStatus
[x] networkStatus
[ ] share plugin buggé : fiche contact avec email et image distante telechargement impossible
[ ] pdf plugin buggé, téléchargement impossible
[x] geolocPicker
[x] locationPlugin
[x] snackbar
[x] signature vincent
[ ] assetCache vincent
[ ] FCM
[ ] FirebaseAnalytics

iOS plugins :

[ ] appInfos
[ ] actionPicker
[ ] batteryStatus
[ ] networkStatus
[ ] share
[ ] pdf
[ ] geolocPicker
[ ] locationPlugin
[ ] snackbar
[ ] signature vincent
[ ] assetCache vincent
[ ] FCM
[ ] FirebaseAnalytics

TODO native side:

[ ] remove also refs to Activities/Fragments/Controllers
[ ] add a callbackChannel to onMessage
[ ] on iOS gather onMessage within onMessageFromWebView:(WebViewType)


Update chart victoria-metrics-k8s-stack to 0.33.1

This PR contains the following updates:

Package
Update
Change

victoria-metrics-k8s-stack
patch
0.33.0 -> 0.33.1

Release Notes

VictoriaMetrics/helm-charts (victoria-metrics-k8s-stack)
v0.33.1
Compare Source
Release notes for version 0.33.1
Release date: 24 Dec 2024

updated common dependency 0.0.35 -> 0.0.36
updates operator to v0.51.2 version

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Dark / bright theme switch via prefers-color-theme CSS

Summary
Currently we can only use one theme and theme switching is annoying problem. Looks like will be good to have support for new CSS media query rule : prefers-color-theme for applying theme styles.

What is the change?
Possibility to switch theme at runtime
Why should it go in Clarity?
Better UX for users
Does this change impact existing behaviors? If so how?
Yes, looks like need to change styles to support it
If this change introduces a new behavior, is this behavior accessible?

Use case
Possibility to switch theme without problems via CSS
Examples
Any popular application possible to switch theme
Workarounds
Has workaround

':prefers-color-theme` has no support in IE or Edge 18, so we cannot introduce a feature into the library to use it to switch between dark and light theme.
If your product does not need to support current Microsoft browsers, you can use this on the product side by building the dark theme CSS (ng serve dev -c dark) in terminal and then grab the generated CSS and apply it in your own app.
We will be introducing an easier way to theme (and switch between themes) in 3.0 and ultimately drop the current SASS-based theming in 4.0.


[SPARK-18523][PySpark]Make SparkContext.stop more reliable

What changes were proposed in this pull request?
This PR fixes SparkContext broken state in which it may fall if spark driver get crashed or killed by OOM.
How was this patch tested?

Start SparkContext;
Find Spark driver process and kill -9 it;
Call sc.stop();
Create new SparkContext after that;

Without this patch you will crash on step 3 and won't be able to do step 4 without manual reset private attibutes or IPython notebook / shell restart.

Can one of the admins verify this patch?

cc @joshrosen @zsxwing

I'm not sure we want to silently swallow all Py4J errors on sc.stop() - at least we should probably warn about the situation (since it seems like it might be possible the JVM process is stuck or another issue has broken the py4j bridge).

I don't see why you wouldn't warn()? otherwise there's no indication that stop() failed.

@srowen
I was thought I pretty well described that above. TL;DR this information is not useful and you cannot do anything with it, but ignore, imho.
But if you insist, I'll add a warning, that's not a problem. Just want to make sure that this is really reasonable to do.

I can't think of any code I've seen that would fail to log a failure like this. Why do you say it's so completely unactionable that nobody should know about it? what's the downside to giving this information versus making it impossible to tell that the JVM failed to shut down?

@srowen

Why do you say it's so completely unactionable that nobody should know about it?

That's just from my experience: in all the cases when drivers dies, it dies in the middle of something, when you do some computations. In this case you already get the Py4J exception on the next operation that triggers communication with JVM process.  So additional reminder on sc.stop() was looked redundant for me.

what's the downside to giving this information versus making it impossible to tell that the JVM failed to shut down?

Perfect question! Well, I don't have any strong argument here. It seems like a matter of taste about logging information usefulness.
Ok, I'll add a warning. Does the following looks good for you?:
warning.warn(RuntimeWarning,
             'Unable to stop JVM process. Probably, it was crashed or externally killed')

I think that warning gives a false sense of security - as I indicated above this swallows all of the Py4J errors and there are a host of things which could cause the Py4J bridge to break down. The warning text I would choose would be more along the lines of: "Unable to cleanly shutdown Spark JVM process. It is possible that the process has crashed or been killed, but may also be in a zombie state."
This way the end user know to take a look and verify that the previous Spark JVM did indeed exit.
I'm still not sure that we want to do this though - if the Spark JVM has failed stopping and restarting the Spark context is going to have all of the previous references to Java objects invalid (not just the RDDs/DataFrames which happens on a stop/start of the Scala Spark context normally). It seems like the correct action for the user to take when the Py4J bridge breaks is starting over from scratch, either by exiting and re-running their notebook or otherwise re-submitting there job.

@holdenk
Thanks for a warning message text. Nice one!

I indicated above this swallows all of the Py4J errors and there are a host of things which could cause the Py4J bridge to break down.

Suddenly, as you may see in issue's traceback, it's py4j who raises too general exception on such kind of problem. I was too expected to see there Py4JNetworkError since it's network communication issue, but this didn't happen. The really good exceptions are get swallowed somewhere in the middle and get just printed to stderr via logging, but I'm not sure how to reraise them and how much things this will break.

It seems like the correct action for the user to take when the Py4J bridge breaks is starting over from scratch, either by exiting and re-running their notebook or otherwise re-submitting there job.

Yes, that's what happens now: in case of failure we have to shutdown notebook, start it and re-run all the cells again. If we're not running in notebook - crash whole the script. Here comes two issues:

Usability. If you made some mistake or Spark job eventually fails, you wouldn't restart whole the notebook, but run cell with sc.stop and else cleanup stuff and re-run your Spark cells. That's simple procedure. But when Spark context stop fails, you have to follow plan B: restart all the things and re-run all the cells. That's could be quite boring and actually it is.

Correctness. SparkContext is a global shared mutable object and if we cannot correctly reset it state to default to start over that feels like something really wrong here. Should we run all the code that uses SparkContext in subprocesses just to be able to implement retry logic otherwise?

@holdenk @srowen
Added a warning message, please take a second look.

This looks good to me pending @rxins proposed wording change. I think restarting a stopped SparkContext which has been killed by an OOM killer or other issue is probably not a good thing to generally do and the warning text makes it clear enough that the machine may be in a bad state so the user can investigate if necessary.
While I'm unlikely to use this, it sounds like it could make life easier for some notebook users to avoid having to restart their notebook kernel. Thanks for taking the time on this PR @kxepal :)
Note: that if you do have automatic retry logic that likely should not be implemented this way - there is a chance this might lead to a very bad state (hence the warning message). [Just mentioning this since it was mentioned as one of the possible uses in our discussion].

@holdenk
Agree with you here. The message is fixed, PR rebased.

Great, can you maybe rebase one more time? For some reason in the PR dashboard its showing up as not mergeable even though github thinks it is.

Test build #3441 has started for PR 15961 at commit 518e31b.

@holdenk
Sure, done.

hm you didn't need to do that. It was just a transient issue with github's own api.

Test build #3442 has started for PR 15961 at commit b47f12d.

Test build #3442 has finished for PR 15961 at commit b47f12d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merging in master/branch-2.1.

Thanks!

Hooray! 🎉 Thank you all for help here! (:


index.js not working

index.js not working

@banan4ik103 Can you please provide more detail on this one?


Valid regex lookahead not working on folder search

VSCode Version: 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b - 2018-02-07T17:10:15.949Z)
OS Version: Ubuntu 17.10 4.13.0-32-generic

VScode project wide search is not working with valid regex look ahead - both negative and positive look ahead doesn't work.

Steps to Reproduce:

Create a new folder and open VSCode on it.
Create a new file
Type "this is a test string" as the file content and save
Press Ctrl + F and search for "test(?=\s?string)" with regex active - see that this works
Try the same search on the project search tab (Ctrl + Shift + F), an error about invalid flag is displayed.

Does this issue occur when all extensions are disabled?: Yes

These are not supported, because folder search uses ripgrep which doesn't support these regex features https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options


Only look for lockable users on a POST.

Resolves #205.

Not quite sure how to go about writing a test for #205, since it requires DB changes. However, I did test it against a database with NULLABLE usernames, and it allows doing a GET, and then correctly locks out a user when conditions are met.

Coverage decreased (-0.1%) to 86.135% when pulling c94e381bb7a7a0c7fee94522e2e0c33e62d5b913 on schinckel:only-check-on-post into ef3d527bee81e10455f73e57aaea13a222c9b792 on jazzband:master.

I'm not actually sure this will wash, as I believe subsequent attempts to do a GET from a page that is already locked will be permitted: I suspect this is not the desired behaviour.

Coverage decreased (-0.08%) to 86.177% when pulling 68c71288857e78b3f722779ff3a8c8460688b2a0 on schinckel:only-check-on-post into ef3d527bee81e10455f73e57aaea13a222c9b792 on jazzband:master.

Coverage increased (+0.03%) to 86.294% when pulling 90bf691e17fa3064cf573d28e08fd0e85db3ff36 on schinckel:only-check-on-post into ef3d527bee81e10455f73e57aaea13a222c9b792 on jazzband:master.

Thank you


log4j security issue: update to log4j version 2.16

Regarding the follwing source, its recommended to switch to the version 2.16 , to be protected against the log4j Root Shell
https://www.heise.de/news/Neue-Probleme-Log4j-Patch-genuegt-nicht-6295343.html?wt_mc=rss.red.security.alert-news.rdf.beitrag.beitrag

Fix in v0.51.5


Log exceptions as telemetry for AppDesigner

See https://github.com/dotnet/roslyn-project-system/pull/274 for more context.

Tagging @dotnet/project-system for review

Your build is broken.

Any further feedback?

Ping..

:+1:


Fixed children and adjustment done #6709

Issue Reference
Link: https://github.com/bagisto/bagisto/issues/6709

@devansh-webkul
It is working fine.


Vignettes: Creating an Obesity ADVS

Base the vignette on the BDS Findings vignette from {admiral} (also uses ADVS – lucky us!) but don't duplicate sections that would be identical. See {admiralpeds} ADVS vignette as an example.
Suggestion on contest/structure:

Explain what the common obesity endpoints are.
Explain how to add them to ADVS using {admiral} tools. Could consider criterion flags - we have a brand-new function in {admiral}, derive_vars_crit_flag().

Hi @kathrinflunkert  , after our discussion in our last meeting, I think we can include the following in our vignette.

Adding derive_param_bmi. The reason is that "BMI collected on CRF" / "system calculated BMI" is not considered and we again calculate BMI in ADVS, so it will be good to have this in vignette as well.
Additional parameters that we have added , WSTCIR, HIPCIR and BMI.
Categorical variables

CHGCAT for Change in SYSBP, DIABP, PULSE
BASECAT for BMI baseline categories ( Underweight, Overweight, Obese class I, Obese class II )
AVALCAT for BMI categories , same as above.

The new derive_vars_crit_flag  for >= 5%, >= 10%, >= 15% and so on weight reduction

Let me know what you think of the above and if there is anything we missed


Rethink/add tests for empty includes when provided.

We should stop loading nested associations when nil provided, and add separate test for this
We should load  associations to parent resource when empty hash/array provided

https://github.com/aglushkov/jat/commit/145f0337f1594b24aec771daad773e979df3569e


Trouble exporting styles as default

I have a "Title" component that looks like this:
import style from './styles';

const Title = ({ children = '' }) => (
  <header className="title">
    <style jsx>{style}</style>
    <h1>
      {children}
    </h1>
  </header>
);

and a styles.js file that looks like this:
export const styles = `
  .title {
    color: red !important;
  }
`;

export default `
  .title {
    color: red !important;
  }
`;

For some reason this doesn't work: import style from './styles' and I get no data-jsx tag,
but this does work: import { styles } from './styles' and I get the data-jsx-ext tag.
(I also change to <style jsx>{styles}</style> then ofc)
I looked through the issues and according to this comment it should work with default exports?
https://github.com/zeit/styled-jsx/issues/215#issuecomment-304621954

did you try to give the default export a different name?

@giuseppeg Sorry my bad. I must have done something else wrong because I can't reproduce this anymore...


Allow to close tabs to the left

Hey guys, thanks for making this great software!
I just recently moved completely over to vscode, but one feature I really miss from my old editor was a "close tabs to the left" button. It comes in real handy when you've got a lot of tabs open and you want to isolate some in the middle.
Sorry if this is a duplicate request, I searched and couldn't find it anywhere.
Thanks again!

As of May 2018 this has been implemented.
Simply add the following to your User Settings JSON:
"workbench.editor.tabCloseButton": "left",

@data83 That setting just moves the actual close button for the tab to the left. This feature request is asking for the ability to close all of the tabs to the left of a tab (the inverse of "Close to the right" button when you right click on a tab).

@thatbignerdguy did you see there is a command to do this:

@bpasero Yes, thank you. This feature request is to add it to the context menu of the tabs, next to the "Close to the Right" button:

Should I edit the title and/or description of the top comment?
Thanks!

An extension should be able to provide this!

@bpasero I tried writing this as an extension before, but I was unable to get the context menu item to appear in the correct place. I could only get it to appear in a new group before or after all of the other context menu groups. I couldn't get it to be placed within the "close" grouping next to the "Close to the Right" button.
Do you know if this is possible with the current extension API?
Thanks again!


Implement persist on rename

Adds a new flag to rename, persist which determines whether or not the file should be persisted after the rename operation. This can greatly improve the performance of compute frameworks using Hadoop commit protocols.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3168/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3169/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3178/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3180/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3217/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3218/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3227/
Test PASSed.

alluxio-bot, merge this please.


http2: move http.request_header keyword to new test

Replaces #1153 with creating a new S-V test instead of reusing other ones to test for the keyword
https://redmine.openinfosecfoundation.org/issues/5780

Merged in #1238, thanks!


feat(#3): implement sandbox infrastructure

As a front-end developer, I need to be able to create pull requests to the main branch and see my new features and fixes on the sandbox environment.
Description

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] You have only one commit (if not, squash them into one commit).

Hi from GitHub CLI

@coderabbitai full review

@coderabbitai review

@coderabbitai full review

@coderabbitai full review

@coderabbitai full review


Add psrBatchLogger to logging step

https://cloud.google.com/php/getting-started/logging-application-events
We should show how to use psrBatchLogger here!

FYI @tmatsuo @ryanmats

Closing as this has been added to the new bookshelf


Does it work with Node 4.2 ?

I'm having issues with exercise "mission impossible: part two", apparently node-gyp cannot download some files.
Jacopos-MacBook-Pro:~ utente$ goingnative verify myaddon
✓ package.json contains `"gypfile": true`
✓ binding.gyp includes a "myaddon" target
✓ binding.gyp includes "myaddon.cc" as a source file
✓ binding.gyp includes a correct NAN include statement
✗ Compile mock C++ to test JavaScript: node-gyp configure: 404 status code downloading SHASUMS.txt

# FAIL

Your solution to MISSION POSSIBLE: PART TWO didn't pass. Try again!

googling, I found that it is likely a problem with a file which changed name with the recent version of nodejs.
I tried to remove my ~/.node-gyp folder and myaddon/node_modules, reinstall node-gyp and install the latest version of nan and bindings removing them from the package.json and reinstalling them from npm, but the problem persists.
Does goingnative 2.0.4 supports Node 4.2 ? I have no idea where to look to see which version of the files node-gyp is being asked to download.

@jacopofar Yeah, I'm facing the same problem too. I believe it might because of the repo itself.
https://github.com/workshopper/goingnative/blob/master/package.json#L30
I cloned the repo and bumped up the version to the latest version of node-gyp. Running goingnative locally works fine.

you can also just bump up the node-gyp version in the node_modules dir and do npm install.
$ npm install goingnative
$ cd node_modules/goingnative/
$ vi package.json

change the node-gyp version to the 'latest' "node-gyp": "~3.0.3"
Then in the same node_modules dir, just install npm install
You can then validate your add-on! woohoo

Thanks, with this edit I'm not stuck anymore. I had installed goingnative globally, so the file for me was in /usr/local/lib/node_modules/goingnative/package.json, but it worked nonetheless.
I'm still stuck with "Error: Could not locate the bindings file" but at least it's a different error

I solved the bingings file error, the binding name was spelt wrong


setOpacity is not working on the Node

devices test on: Any device (Android or IOS)
developing environments

NDK version: r23c
Xcode version: 15.0
Steps to Reproduce:

Create a Node
Create a sprite and add this sprite in to node
Use setOpacity function on the node and check the result, Opacity will not work on the node

NOTE:
Opacity is working on the sprite. Issue is with the Node.
It is also not working on the Axmol demo project
Test Code:
ax::Node* testNode = Node::create();
    testNode->setPosition(100, 100);
    Sprite* testSprite = Sprite::create("LaunchScreenBackground.png");
    testNode->addChild(testSprite);
    testNode->setOpacity(100);
    addChild(testNode);

Your code is missing a call to setCascadeOpacityEnabled(). The cascading of the opacity value is false by default, so add this line to check if it fixes your issue:
testNode->setCascadeOpacityEnabled(true);

It is also not working on the Axmol demo project

What demo project? If you meant cpp-tests, then specifically which test are you referring to?

This will work for newly created node but it will not work for a full project. I checked on cocos-2dx (previous) and their Cascading is off and opacity is working there without adding any additional code.
I can't use setCascadeOpacityEnabled on my project bcoz I updated my project and previously it was working Fine and now why I need to do setCascadeOpacityEnabled?
Yes cpp-tests. I added my own node to check bcoz All the tests are using setOpacity on Sprite or other component but not using directly on the node.

Is there any way to not adding any additional line like
testNode->setCascadeOpacityEnabled(true);
For more Info:
If I set Opacity in Cocos2d-x editor of any node it also not reflect on the game.

Yes cpp-tests. I added my own node to check bcoz All the tests are using setOpacity on Sprite or other component but not using directly on the node.

Any modification to the cpp-tests project should always be mentioned, since stating that the test project didn't work without any context confuses things.
Regardless of that, just because something works a certain way in Cocos2d-x doesn't mean that it was working correctly.  You can check what has changed between Cocos2d-x v4 to Axmol to figure out why it, apparently, has different behavior.

I got the point, I am going through all the places to find out the solution or reason of "Why we need to enable the cascading to use opacity on node?"
If we need to set the cascading to enabled then why it's default value is false, why shouldn't we set it's value to true by default?

Regardless of that, just because something works a certain way in Cocos2d-x doesn't mean that it was working correctly. You can check what has changed between Cocos2d-x v4 to Axmol to figure out why it, apparently, has different behavior.

I compared the both codes, code is similar, I'm confused when I use opacity on editor and then run my code with the updated .csb file, it also not shown opacity on the phone but when I call node->getDisplayedOpacity() it returns 0.
On game UI, it's opacity seems 255.

Yes It's Cocos Studio. So, As far as I understand, to use the opacity on node, we have to use setCascadeOpacityEnabled(true);, right?

The opacity of a specific node is set by setOpacity(), but, if you need that opacity to cascade to child nodes of that node, then yes, you need to call setCascadeOpacityEnabled(true); on that parent.  That goes for any node that has child nodes, so if you have a tree of nodes, then you need to make sure all nodes with child nodes also have cascade opacity set to true.


libdns is missing in focal docker image

Describe the bug
The focal docker image is missing libdns.

Relevant apt package is not installed:

Expected behavior
Same as for the bionic image:

@deimi , are you using the Docker Hub images?
https://openthread.io/guides/border-router/docker#get_the_otbr_docker_image

@jwhui yes

hmmm ok, it seems that libdns_sd.so is in the focal image, despite the apt package is not installed. So the problem probably is somewhere in our own image.
I will update this issue as soon as I found out more

@jwhui Sorry for the inconvenience, it was basically a fault in our image


SPERR seems to be memory inefficient

According to the Memory Consumption analysis by VTune. Need to look into it.

I think it's greatly improved already! Closing!


In stickHeader I have a button, but on response.

My recyclerview adapter implements StickyRecyclerHeadersAdapter, and in onBindHeaderViewHolder, I can set button text, but when i btn.setOnClickListener, the result is on response, btn.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
Toast.makeText(getContext(), "ddddd-----", Toast.LENGTH_SHORT).show();
}
});
how can i do? sorry my english is just so so.

I meet this too。

hi, gzfgeh. did u fixed this issue? i too having the same problem...what is the solution?

I am also facing same prob please help me...?Thankns

Hope some one can give a solution

Is some one fix this? This puzzle me too...


Does blocking metadata server ip cause istio-proxy sidecar container to fail

Hello,
we are usinng istio 1.13.5 in our clusters.
in one of the clusters in GCP we see behavior, where pods with configured istio-proxy sidecars (for mtls) fail to start with readiness check failing:
Warning FailedPostStartHook pod/workspaces-ws-7q8dm-deployment-659c5b85cf-6kjrl Exec lifecycle hook ([pilot-agent wait])
for Container "istio-proxy" in Pod "workspaces-ws-7q8dm-deployment-659c5b85cf-6kjrl_ws-ns-devoted-wildcat(c9614831-4e43-4ff0-b7be-a5264d97a5f4)" failed -
error: command 'pilot-agent wait' exited with 255: Error: timeout waiting for Envoy proxy to become ready.
Last error: Get "[http://localhost:15021/healthz/ready":](http://localhost:15021/healthz/ready%22:) dial tcp [::1]:15021: connect: connection refused...

when checking istio-proxy container startup logs we see the following:
Jul 17, 2022 @ 19:42:44.610	2022-07-17T16:42:44.609890Z	error	accept tcp [::]:15020: use of closed network connection
Jul 17, 2022 @ 19:41:44.515	2022-07-17T16:41:44.514245Z	info	cache	Root cert has changed, start rotating root cert
Jul 17, 2022 @ 19:41:44.515	2022-07-17T16:41:44.514267Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:0 Version:
Jul 17, 2022 @ 19:41:44.515	2022-07-17T16:41:44.514325Z	info	cache	returned workload trust anchor from cache	ttl=23h59m59.485679302s
Jul 17, 2022 @ 19:41:44.514	2022-07-17T16:41:44.514195Z	info	cache	generated new workload certificate	latency=175.923907ms ttl=23h59m59.485822392s
Jul 17, 2022 @ 19:41:44.341	2022-07-17T16:41:44.340962Z	info	sds	Starting SDS grpc server
Jul 17, 2022 @ 19:41:44.337	2022-07-17T16:41:44.337216Z	info	ads	All caches have been synced up in 45.497274ms, marking server ready
Jul 17, 2022 @ 19:41:44.337	2022-07-17T16:41:44.337475Z	info	sds	SDS server for workload certificates started, listening on "etc/istio/proxy/SDS"
Jul 17, 2022 @ 19:41:44.337	2022-07-17T16:41:44.337507Z	info	xdsproxy	Initializing with upstream address "istiod.istio-system.svc:15012" and cluster "Kubernetes"
Jul 17, 2022 @ 19:41:44.310	2022-07-17T16:41:44.310119Z	info	citadelclient	Citadel client using custom root cert: var/run/secrets/istio/root-cert.pem
Jul 17, 2022 @ 19:41:44.302	2022-07-17T16:41:44.302316Z	error	error in getting aws info for iam/info : Get "http://[fd00:ec2::254]/latest/meta-data/iam/info": dial tcp [fd00:ec2::254]:80: connect: network is unreachable

now in the pod's namespace we have a networkpolicy that blocks access to metadata server ip <IP_ADDRESS> (for security reasons), which aparently causes the network unreachable error above, when we remove this rule container starts successfully.
Is this the expected behavior ? does istio-proxy container requires access to metadata server, and fails to start without it ?
Thanks in advance for your help.
Sergey

cc @zirain

@seastranger can you share how you install istio? the iop file or values.yaml for helm chart.

here you go:
apiVersion: v1
items:
- apiVersion: install.istio.io/v1alpha1
  kind: IstioOperator
  metadata:
    annotations:
      helm.sh/hook-weight: "1"
    finalizers:
    - istio-finalizer.install.istio.io
    generation: 3
    labels:
      app.kubernetes.io/instance: istio
    name: appstudio
    namespace: istio-system
  spec:
    components:
      ingressGateways:
      - k8s:
          affinity:
            podAntiAffinity:
              preferredDuringSchedulingIgnoredDuringExecution:
              - podAffinityTerm:
                  labelSelector:
                    matchLabels:
                      app: istio-ingressgateway
                  topologyKey: topology.kubernetes.io/zone
                weight: 100
              requiredDuringSchedulingIgnoredDuringExecution:
              - labelSelector:
                  matchLabels:
                    app: istio-ingressgateway
                topologyKey: kubernetes.io/hostname
          hpaSpec:
            maxReplicas: 3
            minReplicas: 3
          resources:
            limits:
              cpu: "3"
              memory: 20Gi
            requests:
              cpu: 50m
              memory: 384Mi
        name: istio-ingressgateway
      pilot:
        k8s:
          affinity:
            podAntiAffinity:
              preferredDuringSchedulingIgnoredDuringExecution:
              - podAffinityTerm:
                  labelSelector:
                    matchLabels:
                      app: istiod
                  topologyKey: topology.kubernetes.io/zone
                weight: 100
              requiredDuringSchedulingIgnoredDuringExecution:
              - labelSelector:
                  matchLabels:
                    app: istiod
                topologyKey: kubernetes.io/hostname
          env:
          - name: PILOT_PUSH_THROTTLE
            value: "1"
          - name: PILOT_DEBOUNCE_AFTER
            value: 10s
          hpaSpec:
            maxReplicas: 3
            minReplicas: 2
          resources:
            limits:
              cpu: "3"
              memory: 15Gi
            requests:
              cpu: 10m
              memory: 128Mi
    meshConfig:
      accessLogFile: /dev/stdout
      accessLogFormat: |
        [%START_TIME%] "%REQ(:METHOD)% %REQ(X-ENVOY-ORIGINAL-PATH?:PATH)% %PROTOCOL% %DOWNSTREAM_TLS_VERSION%" %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS% %CONNECTION_TERMINATION_DETAILS%"%UPSTREAM_TRANSPORT_FAILURE_REASON%" %BYTES_RECEIVED% %BYTES_SENT% %DURATION% %RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)% "%REQ(X-FORWARDED-FOR)%" "%REQ(USER-AGENT)%" "%REQ(X-REQUEST-ID)%""%REQ(:AUTHORITY)%" "%UPSTREAM_HOST%" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME%
      rootNamespace: istio-root
    profile: default
    values:
      global:
        hub: build-releases-external.common.cdn.repositories.cloud.sap/istio
        imagePullSecrets:
        - istio-pull-secret
        logging:
          level: default:error
        proxy:
          holdApplicationUntilProxyStarts: true
          logLevel: error
      sidecarInjectorWebhook:
        enableNamespacesByDefault: false
        objectSelector:
          autoInject: false

@seastranger I can not reproduce this with following config:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: test-network-policy
spec:
  podSelector: {}
  policyTypes:
  - Egress
  egress:
  - to:
    - ipBlock:
        cidr: <IP_ADDRESS>/0
        except:
          - <IP_ADDRESS>/32

there's something odd in your logs:

Jul 17, 2022 @ 19:42:44.610	2022-07-17T16:42:44.609890Z	error	accept tcp [::]:15020: use of closed network connection

do you block port 15020?

Not as far as i know
here is excerpt from our networkpolicy:
  spec:
    egress:
    - to:
      - ipBlock:
          cidr: <IP_ADDRESS>/0
          except:
          - <IP_ADDRESS>/11
          - <IP_ADDRESS>/16
          - <IP_ADDRESS>/13
          - <IP_ADDRESS>/16

if we remove the  - <IP_ADDRESS>/16 range, container successfully starts

specifically events we see in the describe of failing pod:
 Warning  FailedPostStartHook  16s   kubelet             Exec lifecycle hook ([pilot-agent wait]) for Container "istio-proxy" in Pod "workspaces-ws-fpfmb-deployment-bcbd94dd6-7ppzl_ws-ns-rare-wallaby(284a379b-aeef-465d-8a02-ee3571d4f570)" failed - error: command 'pilot-agent wait' exited with 255: Error: timeout waiting for Envoy proxy to become ready. Last error: Get "http://localhost:15021/healthz/ready": dial tcp [::1]:15021: connect: connection refused
, message: "2022-07-24T10:34:07.814168Z\tinfo\tWaiting for Envoy proxy to be ready (timeout: 60 seconds)...\n2022-07-24T10:35:07.951570Z\terror\ttimeout waiting for Envoy proxy to become ready. Last error: Get \"http://localhost:15021/healthz/ready\": dial tcp [::1]:15021: connect: connection refused\nError: timeout waiting for Envoy proxy to become ready. Last error: Get \"http://localhost:15021/healthz/ready\": dial tcp [::1]:15021: connect: connection refused\n"
  Normal  Killing  16s  kubelet  FailedPostStartHook

specifically events we see in the describe of failing pod:
 Warning  FailedPostStartHook  16s   kubelet             Exec lifecycle hook ([pilot-agent wait]) for Container "istio-proxy" in Pod "workspaces-ws-fpfmb-deployment-bcbd94dd6-7ppzl_ws-ns-rare-wallaby(284a379b-aeef-465d-8a02-ee3571d4f570)" failed - error: command 'pilot-agent wait' exited with 255: Error: timeout waiting for Envoy proxy to become ready. Last error: Get "http://localhost:15021/healthz/ready": dial tcp [::1]:15021: connect: connection refused
, message: "2022-07-24T10:34:07.814168Z\tinfo\tWaiting for Envoy proxy to be ready (timeout: 60 seconds)...\n2022-07-24T10:35:07.951570Z\terror\ttimeout waiting for Envoy proxy to become ready. Last error: Get \"http://localhost:15021/healthz/ready\": dial tcp [::1]:15021: connect: connection refused\nError: timeout waiting for Envoy proxy to become ready. Last error: Get \"http://localhost:15021/healthz/ready\": dial tcp [::1]:15021: connect: connection refused\n"
  Normal  Killing  16s  kubelet  FailedPostStartHook

which basically means that istio-proxy is not listening to health api

can you share the pod yaml and logs of istio-proxy container?

maybe same as https://github.com/istio/istio/issues/39950, hope can be fixed by https://github.com/istio/istio/pull/40105

@zirain the PR #40105 is merged that logs an error when the metadata endpoint is not accessible and executes the requests concurrently. This fixes this issue which is the same as #39950

fixed by https://github.com/istio/istio/pull/40105


Setting background drawable

First of all I would like to thank you for this amazing library, it's SO easy to use and the results are marvellous. It's also very easily customizable. Now for this issue, when I try to set a background drawable the particles don't appear. I tried setting the background colour to transparent and have a drawable somewhere behind, but instead of transparent, it's black. Do you have any idea how to solve this? It would be greatly appreciated!

I am having the same issue

También tengo el mismo problema.

Same issue here, the background is black

Same issue here, the background is black

#helpinghands
init {
obtainStyledAttributes(attrs, defStyleAttr)
if (holder != null) holder.addCallback(this)
hasSurface = false
setZOrderOnTop(true)
holder.setFormat(PixelFormat.TRANSLUCENT)
}

是的 我也有相同的问题 即使将background属性去掉了之后依旧如此 but whatever thanks guys

This works if you do not have something on top of the SurfaceView, otherwise the SurfaceView will show on top of everything due to setZOrderOnTop set to true. An example would be the ParticleView library and a button in a middle (the button won't show).
An alternative would be to change the SurfaceView implementation to TextureView:

Change the listener to TextureView.SurfaceTextureListener and implement the methods accordingly (mainly the onSurfaceTextureAvailable and onSurfaceTextureDestroyed
Create a Surface instance so you can get the canvas and draw. Should be initialized in onSurfaceTextureAvailable and released in onSurfaceTextureDestroyed


New package: Gawindx.WinNUT version 2.0.7722.30975

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest .\manifests\g\Gawindx\WinNUT\2.0.7722.30975\?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Verify:


Alias TrueZen-nvim is still in vim-plugins

Describe the bug
Building the TrueZen-nvim plugin on nixpkgs master leads to the evaluation error:
error: Alias TrueZen-nvim is still in vim-plugins

Steps To Reproduce
Steps to reproduce the behavior:

nix build '.#vimPlugins.TrueZen-nvim'

Expected behavior
TrueZen-nvim builds.
Additional context
It seems that the TrueZen-nvim attribute is deprecated, but the new attribute (true-zen-nvim) does not exist in generated.nix. I'm not sure what's going on here.
The change originates from https://github.com/NixOS/nixpkgs/pull/183091, but TrueZen-nvim was updated automatically.
Notify maintainers
@teto since it seems like an update script issue?
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.55, NixOS, 22.05 (Quokka), 22.05.20220727.d9536b9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - channels(root): `"nixos-22.05"`
 - channels(minijackson): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I've got my hands full at the moment so feel free to take a stab at it.


Release Google.Cloud.NetworkSecurity.V1Beta1 version 1.0.0-beta02

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Cloud.NetworkSecurity.V1Beta1-1.0.0-beta02


Bitcoin Core 24.0

Add release pages for 24.0.
Waiting for binary upload & still need to fill in magnet link.
Similar to #869.

didn't run it, had a quick read,
compared with the 23.0 release post and release pages,
lgtm

I whitelisted the torrent on my tracker.

Hello, how I can help?

Binaries are now available, and magnet link has been added.


Disabling "Show outline view" doesn't work

I disabled "Show outline view" because it always opens above the project pane whenever I open atom.

But this setting has no effect. The outline pane still opens all the time.

I think here is a if (val == true) missing so the outline will be shown after the config load regardless of the value.
https://github.com/dart-atom/dart/blob/201ee1804483277b9e5c7833b7a3cbccf40991fb/lib/impl/outline.dart#L38-L40


Fix issues with latest Go and generics

This PR builds on top of #177 from @Egor3f with few more fixes for remaining issues, some of them mentioned in issues: #197, #201.

Thanks! This works for me!


fix(curriculum): allow hex triplets for red and green colors to pass …

…tests
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #38521

@Czespo Thanks for letting me know. Overlooked

Fixed both triplet hex codes. Rebased and pushed


Server Error when USD amount changed was fixed

When the user change the USD amount while withdraw, it was given underflow error about decimals.

Gonna yolo this as it looks good!


Questioning initialization recommendation

Currently in the documentation, the recommendation for express
applications is to set the Bookshelf instance onto your application.  I
find this to be not only an odd choice, but also a limiting one.
In Node, if you want something memoized easily, the best way to achieve
that is through a module.  They are cached after the first invocation
and provide the exact solution described.
My problem with the current recommendation is that you create a
completely unnecesary dependency on the express app from your model
definition.  This is limiting in so many ways, especially with regards
to testing.
I don't think it hurts to attach the bookshelf instance to your app, and
that may make sense for a lot operations, but for Model definitions I
don't see why you'd ever want this.
What do you think?

Yep - been meaning to change this. Thanks!


bugfix: no more 'fatal' on detached HEAD repositories

There you go. It only took a few minutes to fix. (#15)
I simply copied the code from oh-my-fish/plugin-vcs/functions/git/vcs.branch.fish.
And if we're already mentioning it, I highly recommend that you check out @derekstavis's plugin-vcs. It seems to work great so far and supports git, hg (mercurial) and svn, with almost no effort on your side.

I'm using neither hg nor svn so will not venture to add them through copy/paste (cc @rafaelrinaldi). PR are always welcome though.


CI Working Group

Hi @jfpanisset - confirming you are ready to present the annual review today - LMK

I've completely zoned out on this, thought I had set a calendar reminder to prep for this but I didn't. Will need to reschedule, apologies for last minute scramble...

@jfpanisset Confirming you are ready to present the annual review on Wednesday - let me know if that is ok for you.

I am not ready yet but I will be ready and not forget this time!

Renewal approved 5/29


Add a config item to skip the harvesting if the player just left-click the crop

The problem

There is no way to remove the seed on the farmland without manually turning the harvesting off.
There is no way to make harvesting right click only while maintaining the vanilla behavior of the left click.

Changes
Added a left-click-replant config item. You can make the plugin fully disabled, or only enabled for left/right click, or both by using different config combinations.

Thanks! Didn't think about this lol

https://modrinth.com/plugin/scythe/version/5.1


@mention list doesn't work

When i try to mention user by @username, i do not see a list of users from my board. This problem occurs with all fields.

Same here