Incorrect calculation of the container height in the case of dynamic rendering of table rows

In this issue shows an example of how to use the RectList in table rendering (https://github.com/coderiety/react-list/issues/47)
In the current implementation does not take into account the height of the <thead> tag that is not included in the items array
Real container height:

Сalculated container height

@Zveroboev have find a way to fix this ? I met the same question

@aih8 no :(


Don't declare helper app as a protocol handler. Closes #219

cf. #219 for the issue & research :star2:

I'm guessing it's not reasonable to have a test case for this?
Could someone more familiar with how Mac apps work take a look at the PR and associated research that @fasterthanlime did?

I'm guessing it's not reasonable to have a test case for this?

Well... Travis has OSX machines, and afaict testing the above doesn't require any root privileges but having a fixture mac app that handles protocol properly seems like a lot of work :unamused:
To me the most important question is why was it coded that way in the beginning, was it tested (even manually, once) to begin with, and does changing this break it for the person who originally added it in ?

I can confirm that this PR fixed it for us (in production, for http://itch.io/app), and I can't wait to switch away from our fork and back to the upstream electron-packager.
Not sure who you'd like confirmation from — blame brings up @kfranqueiro for this line, maybe they can help?

I'm pretty sure blame only lists me because I touched that (and a lot in general) when refactoring for what became 5.0.0.  As far as I can tell, this logic even pre-dates that, and it might even pre-date who touched it last at that point too.
Mac bundles are mostly a mystery to me.  Your research sounds plausible but I don't have any other knowledge to confirm/deny it.

OK, I'm inclined to merge this and wait for any further bug reports to be filed. :smile:

refactor

Ah, I see.
The research really is pretty straight-forward, even though it was annoying to do, because it involves digging up the OSX commands to reset the right cache.
If both apps are registered as protocol handlers, and you're out of luck, the Helper will be called to handle some of your URLs, and since the Helper really isn't meant to be opened by anything other than the main app itself.. it just doesn't do anything (fails with various negative-integer error codes)
If you're lucky and somehow the main app takes precedence in OSX's cache (wasn't able to pinpoint what exactly determines that..), then things work fine.
As far as I can tell, the helper should never have been registered as protocol handler, if it was tested once and worked it was sheer luck, and that fix fixes it for us and our users (22K mac downloads & counting) 100% of the time.
I'm really not sure what other steps to take to move this issue forward :panda_face:

[...] that fix fixes it for us and our users (22K mac downloads & counting) 100% of the time.

Good enough for me.

OK, I'm inclined to merge this and wait for any further bug reports to be filed.

:dancers: there's already evidence that few people actually used it: I'm the only one pushing for a fix :)

digging up the OSX commands to reset the right cache.

took me a few minutes of googling to find it again, but for the curious/posterity, the tool in question is lsregister, found at:
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister

You can call it with -kill to reset protocol associations — reopening apps directly will start to reassociate protocols.

Thanks for the bugfix and the associated research!

OK i'll try and cut a new release

ok 5.2.1 is out

:+1: thanks a bunch!


Would not be it better if message object returned the name of the author also?

The message object currently returns uid, text and other data. I guess it would be great if it also returned the name of the sender.
'<Message ({}): {}, mentions={} emoji_size={} attachments={}>'.format(self.uid, repr(self.text), self.mentions, self.emoji_size, self.attachments)
Problem I faced :
When using Client Class's onMessage() function, it is hard to retrieve the name of the sender of the message, hence new message received displays by uid. Is there any alternate solution to find the name of the sender when receiving a message?

Use
client.fetchUserInfo(author_id)[author_id].name
Returning name of the sender requires sending another request

I'm planning on making the system more user friendly in v2.0.0, where the message object automatically will contain a cached User object, where you can get this information


Updated to version 2.1

Hi,
Version 2.1 of rspamd was released last month and I have updated the .spec file.

Thank you :tada:


Set a unique ID value in generated metadata

Description
When generating SAML metadata, the ID created in the EntityDescriptor element is generated based on the issuer value.  The intent of the ID value is to be unique for a document so if you were to change properties of your SP, the different metadata versions should not have the same ID.   While it is unlikely that this ID is being used as a cache control mechanism, it should change if the metadata changes.  Most common implementations generate a new ID each time metadata is generated, and this change does the same.
SAML core spec 1.3.4 ID and ID Reference Values:

Any party that assigns an identifier MUST ensure that there is negligible probability that that party or
any other party will accidentally assign the same identifier to a different data object

Checklist:

Issue Addressed: [x]
Link to SAML spec: [x]
Tests included? [x]
Documentation updated? [n/a]

@cjbarth thank you.  Can I get another beta build published to npm so I can pick this up?

@zoellner, @barryhagan is asking for another beta release. We are getting close to a final 4.0 release; we just have some outstanding PRs awaiting review.


Automated cherry pick of #2483: fix: zstack reset passworkd with username

Cherry pick of #2483 on release/2.12.
#2483: fix: zstack reset passworkd with username

/approve
/lgtm


Updates script to copy .resx file and synchronize coreFx websockets.

Fix for #198 and syncing.

@jkotalik,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Stonecutter is renamed in English?

Hey, apparently stonecutter is named "Bench Saw" in US English, with this mod installed. I'm not sure whether this is a bug or a feature?

Yes, this is intentional since you can use wood it with my mod, I thought it would make more sense to name it Bench Saw.

May I suggest a config option to enable/disable this?

Seconding this.  I understand the logic, but practically it just makes it harder to find (via JEI or the creative menu).  It seems particularly confusing for people new to 1.14+, who might only be vaguely aware that the stonecutter even exists.
As an alternative to renaming (or a config option), you could also consider a separate wood-cutting block (similar to the ones added by Charm and Druidcraft).  Or, even more ideally, it would be amazing to see compatibility with the aforementioned mods:  if Charm is installed, use the woodcutter, otherwise use the stonecutter.

Seconding this.  I understand the logic, but practically it just makes it harder to find (via JEI or the creative menu).  It seems particularly confusing for people new to 1.14+, who might only be vaguely aware that the stonecutter even exists.
As an alternative to renaming (or a config option), you could also consider a separate wood-cutting block (similar to the ones added by Charm and Druidcraft).  Or, even more ideally, it would be amazing to see compatibility with the aforementioned mods:  if Charm is installed, use the woodcutter, otherwise use the stonecutter.

Third.  Would like this to be configurable also.


the given project path does not appear to exist

Hi,
I a newer to  sigProfiler, I tried to use sigProfilerExtractor to run build-in example data, errors occurred, I don't know how to handle this issue, as following:
sig.sigProfilerExtractor("vcf", "results", "~/software/SigProfilerMatrixGenerator/21BRCA/21BRCA_vcf", reference_genome="GRCh37", minimum_signatures=1, maximum_signatures=10, nmf_replicates=100)
************** Reported Current Memory Use: 0.31 GB *****************
The given project path does not appear to exist. Please check that the specified path exists before proceeding...
~/software/SigProfilerMatrixGenerator/21BRCA/21BRCA_vcf
Traceback (most recent call last):
File "", line 1, in
File "/home/ug0416/.conda/envs/cnvkit/lib/python3.9/site-packages/SigProfilerExtractor/sigpro.py", line 600, in sigProfilerExtractor
genomes = pd.DataFrame(data[m])
TypeError: tuple indices must be integers or slices, not str
However, I have defined absolut path to input vcf file

Dear @stroke1989
I hope you are doing great, and thanks for your interest in our tool. As the error message shows, could you please check that you have your vcf files in that specific path? Also, please use the importdata function as described in the README for using the built-in example data.
I would also recommend checking out the video tutorials available to help you with this and other potential issues.
Please let us know if you have any further problems.
Marcos

Thank you for your reponse. I could proceed. However, another issue happened. I finished extration of de novo signature, but the ID83 graph was wierd, the legend overlapped, so I tried to use  SigProfilerPlotting plot ID83 by myself, I run as following:
plotID("/home/ug0416/software/SigProfilerExtractor/SigProfilerExtractor/results/ID83/Suggested_Solution/ID83_De-Novo_Solution/Signatures/" + "ID83_De-Novo_Signatures.txt", "/home/ug0416/software/SigProfilerExtractor/SigProfilerExtractor/results/ID83/Suggested_Solution/ID83_De-Novo_Solution/Signatures/", test, "83", percentage=FALSE)
Error in "/home/ug0416/software/SigProfilerExtractor/SigProfilerExtractor/results/ID83/Suggested_Solution/ID83_De-Novo_Solution/Signatures/" +  :
non-numeric argument to binary operator
I thought that  the ample_matrices_path and output_path was set incorrectly. I don't know how to handle this issue. Hope your reponse! Appreciate!

Hi again!
The issue of the legend overlapping is probably due to a well-known issue of matplotlib. Please try to follow the instructions in that issue, as well as install the appropriate fonts in your system.
Regarding your problem with SigProfilerPlotting, I think it can be related to the command you used. Please use absolute paths without + operators. Also, you should check the use of R-style FALSE instead of Python False. If you have further questions, @ebergstr can help you more if you open a new issue in SigProfilerPlotting.
I hope this helps and thanks for your interest!

Please reopen this issue or a new one if you are encountering any problems.


Data Ingestion stage

[x] Update config.yaml
[x] research or analysis
[x] Update the entity
[x] Update the configuration manager in src config.
[x] Update the components
[x] Update the pipeline

Dry run successful for stage 01


Add diags to documentation

This PR follows #1840 to add cupyx.scipy.sparse.diags to the reference.

Jenkins CI test (for commit 8abed28c838a2b5895a1df0f725fd9f53aa03a82, target branch master) succeeded!

LGTM!


Register species from MICM

Registers constituents and sets needed constituent properties from MICM configuration.
Additionally:

returns error codes and messages from MUSICA functions using new error handling in MICM
creates a musica_ccpp module to act as a the CCPP interface and moves existing functionality to a musica_ccpp_micm module in preparation for adding TUV-x (we will use musica_ccpp_ as a prefix for all the MUSICA modules in this repo to prevent naming conflicts with MUSICA Fortran library modules)
updates build scripts for changes to MUSICA and CCPP framework
adds memory checking to MUSICA tests

closes #74

@mattldawson this PR looks good to me! However I'll hold off on approving until we can get it working in CAM-SIMA (i.e. fix the dependencies issue in the framework). Of course if you'd like this PR in sooner than that just let me know. Thanks!

That's fine by me. There are some TUV-x-related developments in the pipeline, but hopefully the CAM-SIMA updates will be in before these are ready.

closing and reopening on development branch


Enable returning a message back from the dead  to the queue

issue: https://github.com/wework/grabbit/issues/102
do not merge yet, tests are still missing

Coverage decreased (-0.2%) to 74.212% when pulling f52ede81f6ed4f8c476d2ab68b56665697242f09 on enable_sending_raw_message into 403cd5e501ee258db3e35ba71e41357b2788a948 on v1.x.


Style scrollbars in dark mode

Chrome (and probably other webkit based browsers) doesn't automatically darken scrollbars.
Before:

After:

I was seeing it when switching between dark and light mode (on any page): the switched would jump because of the width style that only applied in one of the modes.


decrease width of the accordion component on mobile

pull update from upstream, reopening PR for issue #318

Great job @undefined-box!!!


add logrotate profiles for openstack projects

example logrotate file:
$ cat /etc/logrotate.d/glance

/var/log/glance/*.log
{
  daily
  missingok
  rotate 7
}

I'm not sure how the openstack services handle a file rotation, if we need to alert them at all or truncate, etc? Did you pull these from an upstream recommended example?

Confirmed this config works:
user@host:~$ sudo logrotate -v /etc/logrotate.d/nova
reading config file /etc/logrotate.d/nova
reading config info for /var/log/nova/*.log

Handling 1 logs

rotating pattern: /var/log/nova/*.log
 after 1 days (7 rotations)
empty log files are rotated, old logs are removed
considering log /var/log/nova/nova-api.log
  log needs rotating
considering log /var/log/nova/nova-cert.log
  log does not need rotating
considering log /var/log/nova/nova-compute.log
  log does not need rotating
considering log /var/log/nova/nova-conductor.log
  log does not need rotating
considering log /var/log/nova/nova-consoleauth.log
  log does not need rotating
considering log /var/log/nova/nova-manage.log
  log does not need rotating
considering log /var/log/nova/nova-scheduler.log
  log does not need rotating
rotating log /var/log/nova/nova-api.log, log->rotateCount is 7
dateext suffix '-20150115'
glob pattern '-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]'
renaming /var/log/nova/nova-api.log.7 to /var/log/nova/nova-api.log.8 (rotatecount 7, logstart 1, i 7),
old log /var/log/nova/nova-api.log.7 does not exist
renaming /var/log/nova/nova-api.log.6 to /var/log/nova/nova-api.log.7 (rotatecount 7, logstart 1, i 6),
old log /var/log/nova/nova-api.log.6 does not exist
renaming /var/log/nova/nova-api.log.5 to /var/log/nova/nova-api.log.6 (rotatecount 7, logstart 1, i 5),
old log /var/log/nova/nova-api.log.5 does not exist
renaming /var/log/nova/nova-api.log.4 to /var/log/nova/nova-api.log.5 (rotatecount 7, logstart 1, i 4),
old log /var/log/nova/nova-api.log.4 does not exist
renaming /var/log/nova/nova-api.log.3 to /var/log/nova/nova-api.log.4 (rotatecount 7, logstart 1, i 3),
old log /var/log/nova/nova-api.log.3 does not exist
renaming /var/log/nova/nova-api.log.2 to /var/log/nova/nova-api.log.3 (rotatecount 7, logstart 1, i 2),
old log /var/log/nova/nova-api.log.2 does not exist
renaming /var/log/nova/nova-api.log.1 to /var/log/nova/nova-api.log.2 (rotatecount 7, logstart 1, i 1),
old log /var/log/nova/nova-api.log.1 does not exist
renaming /var/log/nova/nova-api.log.0 to /var/log/nova/nova-api.log.1 (rotatecount 7, logstart 1, i 0),
old log /var/log/nova/nova-api.log.0 does not exist
log /var/log/nova/nova-api.log.8 doesn't exist -- won't try to dispose of it
renaming /var/log/nova/nova-api.log to /var/log/nova/nova-api.log.1


small datasets

Hi,
Scanpy are designed to handle big datasets, while how about the performance on small datasets ? (such as as few as 50 cells from early embryo)

Dear @wangjiawen2013,
what is the interest behind your question? Do you have many datasets with very few cells?
Scanpy itself can easily work with very small datasets, but you should always be aware of statistical limitations when performing statistical tests etc on very few cells.

We knocked out a gene, then wanna to reveal the difference between KO embro cells and wild type embryo cells and illustrate the function of the gene in development process. The single cell data was generated using Smart-seq2 technology, which is a low throughput technology. And besides, there were only a few cells in eary embros because they are very small.

All right. Guess my answer would be the same. Technically yes, but be aware of statistical limitations.


Can't use ASE interface

Dear developers,
thanks for sharing this project. I'm having trouble to use the ASE interface.
I'm trying to use the example script $REANN_FOLDER/ASE/test/ase_eann.py provided as example but is gives the following error:
Atoms(symbols='Cu8Ce16O32', pbc=True, cell=[[15.304599762, 0.0, 0.0], [-7.652299881, 13.2541721886, 0.0], [0.0, 0.0, 17.5620002747]], constraint=FixAtoms(indices=[8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55]), calculator=EANN(...))
Traceback (most recent call last):
  File "/home/fabio/Software/REANN/ASE/test/ase_eann.py", line 36, in <module>
    dyn = LBFGS(atoms,trajectory='atom2.traj')
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/lbfgs.py", line 65, in __init__
    Optimizer.__init__(self, atoms, restart, logfile, trajectory, master,
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/optimize.py", line 234, in __init__
    self.set_force_consistent()
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/optimize.py", line 325, in set_force_consistent
    self.atoms.get_potential_energy(force_consistent=True)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/atoms.py", line 728, in get_potential_energy
    energy = self._calc.get_potential_energy(
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/calculator.py", line 711, in get_potential_energy
    energy = self.get_property('energy', atoms)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/calculator.py", line 739, in get_property
    self.calculate(atoms, [name], system_changes)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/eann.py", line 100, in calculate
    force=pes(period_table,cart,tcell,species)[1]
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript, serialized code (most recent call last):
  File "code/__torch__/pes/PES.py", line 14, in forward
    cell: Tensor,
    species: Tensor) -> Optional[Tuple[Tensor, Tensor]]:
    _0 = (self.neigh_list).forward(period_table, cart, cell, )
          ~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
    neigh_list, shifts, = _0
    output = (self.nnmod).forward(cart, neigh_list, shifts, species, True, )
  File "code/__torch__/pes/get_neigh.py", line 22, in forward
    _2 = torch.slice(coordinates, 0, 0,<PHONE_NUMBER>854775807, 1)
    _3 = torch.slice(_2, 1, 0,<PHONE_NUMBER>854775807, 1)
    _4 = torch.copy_(_3, _1, False)
         ~~~~~~~~~~~ <--- HERE
    _5 = self.cutoff
    _6 = torch.mul(torch.reciprocal(torch.abs(cell)), _5)

Traceback of TorchScript, original code (most recent call last):
  File "/home/scms/jlchen20/software/2021_05_10/eann/pes/get_neigh.py", line 30, in forward
        deviation_coor=torch.round(inv_coor-inv_coor[0])
        inv_coor=inv_coor-deviation_coor
        coordinates[:,:]=torch.einsum("ij,jk -> ik",inv_coor,cell)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
        #represent a,b,c project on x,y,z
        #num_repeats = torch.ceil(torch.stack([self.cutoff/torch.max(torch.abs(cell[:,i])) for i in range(3)]))
RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.

It fails whne calling "LBFGS(atoms,trajectory='atom2.traj')"
Can you run the same exact script? I've been able to run train.py.
Thanks in advance,
Maxi

Dear developers,
thanks for sharing this project. I'm having trouble to use the ASE interface.
I'm trying to use the example script $REANN_FOLDER/ASE/test/ase_eann.py provided as example but is gives the following error:
Atoms(symbols='Cu8Ce16O32', pbc=True, cell=[[15.304599762, 0.0, 0.0], [-7.652299881, 13.2541721886, 0.0], [0.0, 0.0, 17.5620002747]], constraint=FixAtoms(indices=[8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55]), calculator=EANN(...))
Traceback (most recent call last):
  File "/home/fabio/Software/REANN/ASE/test/ase_eann.py", line 36, in <module>
    dyn = LBFGS(atoms,trajectory='atom2.traj')
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/lbfgs.py", line 65, in __init__
    Optimizer.__init__(self, atoms, restart, logfile, trajectory, master,
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/optimize.py", line 234, in __init__
    self.set_force_consistent()
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/optimize/optimize.py", line 325, in set_force_consistent
    self.atoms.get_potential_energy(force_consistent=True)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/atoms.py", line 728, in get_potential_energy
    energy = self._calc.get_potential_energy(
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/calculator.py", line 711, in get_potential_energy
    energy = self.get_property('energy', atoms)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/calculator.py", line 739, in get_property
    self.calculate(atoms, [name], system_changes)
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/ase/calculators/eann.py", line 100, in calculate
    force=pes(period_table,cart,tcell,species)[1]
  File "/home/fabio/miniconda3/envs/reann/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
    return forward_call(*input, **kwargs)
RuntimeError: The following operation failed in the TorchScript interpreter.
Traceback of TorchScript, serialized code (most recent call last):
  File "code/__torch__/pes/PES.py", line 14, in forward
    cell: Tensor,
    species: Tensor) -> Optional[Tuple[Tensor, Tensor]]:
    _0 = (self.neigh_list).forward(period_table, cart, cell, )
          ~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
    neigh_list, shifts, = _0
    output = (self.nnmod).forward(cart, neigh_list, shifts, species, True, )
  File "code/__torch__/pes/get_neigh.py", line 22, in forward
    _2 = torch.slice(coordinates, 0, 0,<PHONE_NUMBER>854775807, 1)
    _3 = torch.slice(_2, 1, 0,<PHONE_NUMBER>854775807, 1)
    _4 = torch.copy_(_3, _1, False)
         ~~~~~~~~~~~ <--- HERE
    _5 = self.cutoff
    _6 = torch.mul(torch.reciprocal(torch.abs(cell)), _5)

Traceback of TorchScript, original code (most recent call last):
  File "/home/scms/jlchen20/software/2021_05_10/eann/pes/get_neigh.py", line 30, in forward
        deviation_coor=torch.round(inv_coor-inv_coor[0])
        inv_coor=inv_coor-deviation_coor
        coordinates[:,:]=torch.einsum("ij,jk -> ik",inv_coor,cell)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <--- HERE
        #represent a,b,c project on x,y,z
        #num_repeats = torch.ceil(torch.stack([self.cutoff/torch.max(torch.abs(cell[:,i])) for i in range(3)]))
RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.

It fails whne calling "LBFGS(atoms,trajectory='atom2.traj')"
Can you run the same exact script? I've been able to run train.py.
Thanks in advance, Maxi

I can reproduce this error in PyTorch-1.10. According to my experience, this may be due to the incompatible of the Torch version. I believe the model "file" is generated in the torch-1.90? Is that right? @chen-jialan.  So you can try it using torch-190 or you can use training code to generate your model file in torch-1.10 and then invoke the interface in 1.10.

Thanks for using this package,
I am sorry, because EANN is the old version, and the version of pytorch is suitable in 1.8.X, not in 1.9 or high version.
I'll submit the exmaple based on REANN.
Thanks for giving this deficiency.
Jialan chen,
2022.03,

Thank you very mucho for your answers @zhangylch and @chen-jialan
I tried the REANN model using the ASE implementation and it works perfectly!!!


Handle PreDestroy Exceptions in LifeCycleManager

Handle catch and log exceptions thrown from @PreDestroy methods inLifeCycleManager::stop() so that other stop behaviors have a chance to run.

Test failures seem unrelated and likely due to a racy assertion, tests pass locally for me. This implementation chooses to swallow exceptions raised by @PreDestroy methods and just log them, but they could be re-thrown at the end of LifeCycleManager::stop() as well. If that's preferred, here's a diff of that implementation: https://github.com/airlift/airlift/compare/master...pettyjamesm:handle-predestroy-exceptions-and-rethrow

I've added a new commit to put the exception handling mechanism during stop() behind an interface so that log / suppressing exceptions can be done in whatever mechanism makes sense. This also enables calling @PreDestroy methods on instances that fail during their @PostConstruct phase, which I added as well.

Re: "log ^ throw" -- I already expressed my opinion in https://github.com/airlift/airlift/pull/739#discussion_r300422597
I am deferring to @electrum and @dain on a decision.

@findepi any feedback / opinions on the new commit added? I was trying to strike a balance for how to handle that "log ^ throw" problem and saw the opportunity to clean up instances that fail to @PostConstruct cleanly

@pettyjamesm from engineering perspective this is well done. I am not convinced yet, however, that we need this flexibility.
I would prefer to settle on one simple option and revisit the decision when some real-life situation demands this.

@findepi still waiting on a review follow up from @dain or @electrum, but regarding your concern about it being over complicated- I both agree and unfortunately don't see a way to accomplish this more simply. Ignoring the fact that this enables "arbitrary" implementations of LifeCycleStopFailureHandler to be provided by the caller, we have 3 use cases internal to this class alone:

Stop and log errors immediately, throw a LifeCycleStopException at the end if any occurred but without any reference to the already logged exception(s)
Stop and attach all errors as suppressed to a parent LifeCylceStopException without logging
Stop a single instance that failed to fully @PostConstruct successfully and attach all exceptions as suppressed to the exception raised from start-up logic.

I played around trying to find a simpler way to handle the cases mentioned above without resorting to a full blown interface type, but was ultimately unsuccessful. Whether we choose to make the LifeCycleStopFailureHandler interface and stop(LifeCycleStopFailureHandler) method public is another matter- I'll gladly make them private if that's preferable.

@electrum thanks for the review, I've combined the two commits into one and addressed all your CR feedback.

This is great! Thanks a lot for improving this and putting up with several rounds of review.


Adding Text Write option that atomically replaces the text content.

Fixes #124

Pull Request Test Coverage Report for Build 757

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 90.616%

Totals

Change from base Build 755:
0.02%

Covered Lines:
5002

Relevant Lines:
5520

💛  - Coveralls


Wrong page transition effect when changing direction e.g. from topToBottom to bottomToTop.

If I do a number of topToBottom transitions, everything works great, but when I switch to bottomToTop, the page that is being left moves in the wrong direction. It moves as if I was doing another topToBottom. Unfortunately this is a critical feature for my team.  This effect is true for the leftToRight and the rightToLeft.

Same problem here

It looks like the secondaryAnimation is not being created the first time the transition is called. But I have no clue as to why. Any help from @kalismeras61 on this one?
When I add print statements in, I see this for the first time I call it. Logging animation, curve, and secondaryAnimation
(▶ 0.056; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.083; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.111; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
...
(▶ 0.917; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.944; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.972; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 1.000; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
the second time I run it (when it works ) the log looks like this
You can see the second screen transitioning on this one, the first time it appears to use a default animation?
Question is how to you get the animation to run on the departing screen the first time?
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
I/flutter (17162): topToBottom animation: kAlwaysCompleteAnimation➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.000; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.056; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.056; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.083; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.083; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
...
(▶ 0.889; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.917; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.917; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.944; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.944; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.972; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.972; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation

It looks like the secondaryAnimation is not being created the first time the transition is called. But I have no clue as to why. Any help from @kalismeras61 on this one?
When I add print statements in, I see this for the first time I call it. Logging animation, curve, and secondaryAnimation
(▶ 0.056; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.083; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.111; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
...
(▶ 0.917; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.944; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 0.972; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(▶ 1.000; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
the second time I run it (when it works ) the log looks like this
You can see the second screen transitioning on this one, the first time it appears to use a default animation?
Question is how to you get the animation to run on the departing screen the first time?
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
I/flutter (17162): topToBottom animation: kAlwaysCompleteAnimation➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.000; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.056; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.056; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.083; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.083; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
...
(▶ 0.889; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.917; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.917; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.944; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.944; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(▶ 0.972; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(▶ 0.972; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: AnimationController#927f4(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation➩ProxyAnimation
(⏭ 1.000; paused; for PageTransition)➩ProxyAnimation curve:_Linear secondaryanimaition: kAlwaysDismissedAnimation➩ProxyAnimation➩ProxyAnimation

@robertflesch i add fix for that. Can you  test with version 1.1.7+6

@robertflesch i add fix for that. Can you  test with version 1.1.7+6

Hi Yasin Ilhan
Thanks for responding and putting in a fix. My team was giving me a very
hard time with this bug.
So the fix eliminates the problem with the black screen. But it also kills
the nice two screens working as one transition.
The second screen just sits there and the new screen comes over it. Better
than the black screen, but not as nice as the two screens moving together
when it works.
thanks again for the fix
bob
On Wed, Jan 13, 2021 at 2:37 AM Yasin ilhan<EMAIL_ADDRESS>wrote:

@robertflesch https://github.com/robertflesch i add fix for that. Can
you test with version 1.1.7+6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kalismeras61/flutter_page_transition/issues/36#issuecomment-759265412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJBUMQIA7TNNXKVKCDO2RTSZVETVANCNFSM4U6TSDMQ
.

Hi Yasin Ilhan
Thanks for responding and putting in a fix. My team was giving me a very
hard time with this bug.
So the fix eliminates the problem with the black screen. But it also kills
the nice two screens working as one transition.
The second screen just sits there and the new screen comes over it. Better
than the black screen, but not as nice as the two screens moving together
when it works.
thanks again for the fix
bob
On Wed, Jan 13, 2021 at 2:37 AM Yasin ilhan<EMAIL_ADDRESS>wrote:

@robertflesch https://github.com/robertflesch i add fix for that. Can
you test with version 1.1.7+6
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kalismeras61/flutter_page_transition/issues/36#issuecomment-759265412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJBUMQIA7TNNXKVKCDO2RTSZVETVANCNFSM4U6TSDMQ
.

Hi there - still having this issue, anyone find a work around?

Should be fixed latest version


[drone] import should translate invalid characters in secret IDs

Similar to what we did in https://github.com/drone/go-convert/pull/108, the import command for Drone should translate invalid characters to safe characters allowed in Harness secret IDs.
For example, MY-SECRET is valid in Drone, but it is an invalid Harness secret ID. In the Harness API call, MY-SECRET should convert to MY_SECRET (the name of the secret can remain MY-SECRET).

It seems this work is still required.
The secret name and ID are created from just the secret name, which can have invalid characters since it comes directly from the export.
https://github.com/harness/harness-migrate/blob/master/internal/migrate/import.go#L101C23-L101C23
https://github.com/harness/harness-migrate/blob/master/internal/util/util.go#L32-L33


Config API: Config Verification is not strictly enforced

After the config API generates configs, there is supposed to be a step where users pass around config hashes out-of-band and verify them before running consensus:
https://github.com/fedimint/fedimint/blob/ea1ab1a84b2913ccfe7b072d4a924f252d4b729a/fedimint-core/src/api.rs#L1028-L1031
But if you restart fedimintd at this point, it notice that configs have been generated and start running consensus even though the config verification never completed.

https://twitter.com/simulxxx/status/1686102480512319488?s=20


add (optional) reviewer in addition to comment

could we add "add as reviewer" on issues in addition to comment?
usecase is that comments you need to catch "as they come on" and is done for docs on https://github.com/quarkusio/quarkus/pull/44597;
However, if users are added as reviewers, they can query and find them explicitly.
that could be used for code prs in general too, but specific ask is from idea from docs (cc @MichalMaler )
to catch issues sooner.

Currently, we have two docs labels in GitHub.

area/documentation -> This label creates an email notification by using a Quarkus bot tag in a PR.

Possible Usacases:
** Label is added automatically by making a change in the docs folder -> writers are notified about everything that happens in that folder.
** Label is added manually -> Writers are notified when their opinion or attention is needed.
The question is, which one of these two options is more useful?

area/docstyle -> This label needs to be added automatically when any of the files from the watchlist are edited. As a result, members of the Quarkus docs team are automatically added as Reviewers to jump in quickly and provide a review.


[SSP-2881] Add InProgress in refresh states

Add a new InProgress to the source's refresh states and mark it when refresh is started.
https://issues.redhat.com/browse/SSP-2881

Should we merge this PR as is and rework the i18n issue in another PR? We have state/status constants in a few models.


fix: Staking blank screen (poor network)

Waiting product feedback
example2-dialog.webm

closing the PR, keeping the branch until Product definition.


Update request: vscode 1.94.2 → 1.95.0

Package name: vscode
Latest released version: 1.95.0

Current version on the unstable channel: 1.94.2
Current version on the stable/release channel: 1.92.0

[x] Checked the nixpkgs pull requests

Notify maintainers
@eadwu @Synthetica9 @bobby285271 @Enzime @ninelore

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

PR: #352348


Alternate syntax for defining state machine by state

Provides a syntax more suitable for defining workflows (similar to the workflow gem). It may be useful to provide this so users of state_machine can choose the syntax that suits their need without having to switch to another gem.
Instead of,
event :park do
  transition :idling => :parked, :if => :emergency_brake?
end

Do,
state :idling do
  event :park, :to => :parked, :if => :emergency_brake?
end

You can mix and match syntaxes like,
state_machine :state, :initial => :parked, :syntax => :alternate do
  state ... do
  end
end

state_machine :state, :initial => :parked do
  event ... do
  end
end

and they will augment the same state machine. Things like after_transition and before_transition apply the same in both syntaxes.
I've also added :if and :unless conditions to graphviz drawing so it's obvious why one branch is being taken over another.
Thanks!

Hey @obrie, thanks for working on this! Sorry, I totally pulled and forgot, but I'm glad to see this syntax in mainline :)


workspaces: overzealous native library dependency conflicting

Problem
I have a workspace with multiple crates, but for brevity purposes, consider this workspace:
[workspace]
members = [
    "brand_new",
    "old_rusty",
]

These two output a binary executable and don’t depend on each other at all. They have the following dependencies:
brand_new: ring v0.16
old_rusty: ring v0.13

And both versions of ring, in turn, specify links="ring-asm".
Trying to cargo update this workspace will then fail with the following error:
error: failed to select a version for `ring`.
    ... required by package `brand_new v0.0.1 (/tmp/foo/brand_new)`
versions that meet the requirements `^0.16` are: 0.16.11, 0.16.10, 0.16.9, 0.16.7, 0.16.6, 0.16.5, 0.16.4, 0.16.3, 0.16.2, 0.16.1, 0.16.0

the package `ring` links to the native library `ring-asm`, but it conflicts with a previous package which links to `ring-asm` as well:
package `ring v0.13.5`
    ... which is depended on by `old_rusty v0.0.1 (/tmp/foo/old_rusty)`

failed to select a version for `ring` which could resolve this conflict

There's no actual conflict here, however, and not using a workspace would make it work just fine. Whether that’s a good-enough of a workaround is dubious, though.
Steps

Copy the setup from this gist: https://gist.github.com/nagisa/ca95a787c25ba27a73eb3662c85016b2
Run cargo update

Possible Solution(s)
Do not conflict when a particular workspace crate links to just one links dependency. Care must be taken, however, to ensure that we still do conflict when we’d end up pulling multiple links crates into the same binary.
Notes
Output of cargo version: not relevant

Consolidating some similar reports of links and workspaces:
#8550: A duplicate in a dev-dependency causes an error with another crate.
#8636: Independent build-dependencies collision.

I've also run into this issue in https://github.com/knurling-rs/defmt/issues/426, where I tried to support multiple incompatible versions of a library by means of Cargo features. It seems that it is impossible to do so because of this bug, which makes upgrading that library very painful (the whole ecosystem needs to do so in a coordinated fashion, and it requires a breaking change in every single downstream library).

I think the defmt issue is similar, but ultimately quite different. This issue is entirely about two different, independent, workspace members each having a different links-conflicting crate in their dependency tree conflicting despite not having any reason to conflict.
A single crate depending (optionally) on two links-conflicting crates feels much less clear cut to me.

We are facing a similar issue on https://github.com/SeaQL/sea-query/pull/388 where we have two different packages depending on two versions on sqlite and it fails to build. This is very annoying because like it is mentioned above the whole ecosystem needs to keep in sync for us to be able to upgrade even though the dependencies have nothing in common.


⚠ Redacted has degraded performance

In 0cd9ad4, Redacted ($RED) experienced degraded performance:

HTTP code: 200
Response time: 3314 ms

Resolved: Redacted performance has improved in 904adc5.


Add tests for provisioning after account reset

They all passed, so no issues were found, except the merkled poke issue which only affects single-run tests.
r? @maxtaco

A few comments but otherwise :+1:

Hmmm appveyor is weirdly dying...

Apparently the docker image is only updated every 24 hours, not when new keybase/keybase code is pushed.  A manual update is happening now.  Then I'll redo the CI tests for a third time...


Error in epr config

Condition was incorrect, i suppose it shoud check if there are two elemnts in array, not if first element is at least 2 characters long.
Also, i suppose the epr config values are supplied in base10. Here it expects base16. Even though in docs is not much about it written, there is exaple with 59000-59100 values. So it must be base10.
Really great project, took me hours to get ports changed and then I found this!

lgtm


[FR] Add support for loading data in HDF5 format

This was a request from a recent webinar.
One option to supporting this would be to ingest the data from HDF5 format and write images/other media to an internal FiftyOne directory in a standard individual file format at dataset creation time. This is analogous to how we support loading data in TFRecords format, for example.
There is an h5py package on github for working with HDF5 formatted data.

Any progress?

We haven't had time to add "native" HDF5 support yet.
FiftyOne currently requires access to each individual image via the filepath field of each sample, which must be an image format that web browser's can display (png, jpg, tiff` -- possibly with a browser extension installed, etc.)
The way to work with HDF5 data currently would be to unpack it using h5py into regular images on disk so you can construct a FiftyOne dataset.
It would be awesome to have a custom importer contributed that would automate this unpacking, similar to how TF records can be imported, for example 🤗

Using the library you mentioned, unpacking an hdf5 is like:
HDF5_FILE = "data.h5" with h5py.File(HDF5_FILE, 'r') as f:     for img in f["images"]:         cv2.imwrite("filename.png", img)
So, would it be useful if we simply

implement a foud.UnlabeledImageDatasetImporter?
take hdf5 file path and key("images" in the example) as input?
setup method includes a code piece similar to the one above?

The rest would be very similar to unlabeled version of this.

Hello, I also encountered the same problem. Is there any progress? I have a large amount of image data, but read them from disk is very slow. It would be great if we can read image from formats such as HDF5 or LMDB.


Create content area for authenticated users

For publishing minutes, budgets etc. in a confidential manner, we would like to have content which is only accessible to authenticated members.

This would be faily easy to implement, at least from the blueprint side: Just add some view using login_required:
@login_required
@bp.route('/internal/<file>')
def internal_documents():
    return "Giving you {}".format(file)

Another question is how to “mark” internal documents. I see two possibilities:

Using a folder called “internal” or similiar.
Pro: Easy to implement, nothing can go wrong
Con: Not very dynamical.
Adding a switch in the metadata of a file/directory
Pro: Dynamical
Con: Harder to implement, Plus, if you mis-write the header data, an internal document may appear visible.

I personally root find possibility one more convincing, since it does the job and we don't really need more complexity to it – the main category would be our meeting minutes, and they can be grouped in such a folder without any disadvantage.

Is this page (https://agdsn.de/sipa/pages/legal/minutes) then still needed? I think we should replace this page with a new "documents" page.

Btw, I'm heavily in favor of option 1, since it's much more user-friendly and makes it much harder to make mistakes and leak files. We could implement very strict checks for that special directory (e.g. in our monitoring), to continually check that it is not publicly accessible (think webserver misconfiguration etc.).
Please keep in mind that the content repo was public so far. Will we use a different repo for internal documents, or do we need to change that?
Another idea: We could restrict access so that the internal documents are only accessible via obfuscated URLs to further protect us against leaking documents by mistake/oversight. This would of course make the most sense if the internal document listing (containing all the links) is only accessible to authenticated users as well, but as a mitigation measure against guessing/crawling it would be helpful in any case.

If serving static files is the only thing, that's needed, all the hard work can and should be delegated to Flask, which provides the send_from_directory helper function.
This function is used by Flask itself for its own static file mechanism.

That should be all, that's needed:
@login_required
@bp.route('/internal/<file>')
def download_internal_file(filename):
    return send_from_directory(app.config['INTERNAL_FILES_FOLDER'],
                               filename, as_attachment=True)

The function handles caching, unicode normalization, content-type, uses the sendfile optimization if the web server supports etc. So please use it, instead of reinventing stuff.

It would be nice if it supports subdirectories like the current /documents.

It would be nice if it supports subdirectories the same as the current /documents.

What makes you assume, it doesn't?

I already tried a bit around and used send_from_directory. My plan was to create a directory contentArea (like content for news). In this directory is a directory minutes which contains directories for network, computing, services, ... containing the PDFs.
So the minutes-section on the documents-page can be implemented by looking which files are in the several directories, returning a list like this one:

network

2018-02-06
2018-01-23

computing

2018-01-16
2017-12-19

Other stuff like budgets could be handled similar by using other subdirectories of contentArea.

Sorry for jumping in so late, but let me remind you of PR #319 by @fgrsnau. It's just missing some tests IIRC.

I rebased the work of @fgrsnau and found out the reason it was not working. With that in mind, I want to clear up things a bit.
What sipa does not do on the frontend side is to provide a “content” section that handles content, documents, et cetera. content/ is only special in that the update hook
On the frontend side, the following entities exist:

pages/<category_id>/<article_id>  asks the categorized_flatpages extension, which is configured to use app.config['FLATPATES_ROOT'] for the rendered and localized markdown file.
documents/<path> looks in the documents subdirectory of the flatpages root, but that is actually independent of the flatpages extension.
images/<path> does the same, only for images

What @fgrsnau did was the following, (almost) trivial addition:

override the documents/restricted/<path> endpoint to reference files under <flatpages_root>/documents/restricted with the caveat that a login is required.

In the context of this architecture, the simple thing to do is not to introduce a “separate content section”, but to introduce a separate view in SIPA. Granted, this has the drawback that we would not be able to introduce pages (i.e., markdown files) that wuold be internal, but I personally don't even consider that a feature to be desired. In any case, this is a feature orthogonal to the restricted documents section.
Having cleared that up, I will finish the restricted documents section and would like some feedback on wether or not a restricted flatpages section is required.

I'd be much happier, if the restricted documents would be in a separate root directory, that is not a subdirectory of the regular directory, both in the file system namespace and the URL namespace.
This limits the potential impact of programming and configuration errors exposing restricted documents trough the normal documents mechanism.
I assume this shouldn't be too hard to do.

fixed by 99ed21ae4c298b4afd335ee973e4c19a2de17f53

Have you tried annotating the view function returned by as_view the login_required decorator? That would safe you from doing checks yourself in the StaticFiles view class.
login_required(StaticFiles.as_view(…))

@sebschrader no I have not, no Idea if this would work.

This is not finished. Afaik there is no way to get the content repo to SIPA in a confidential manner, rendering this feature unusable.

@toothstone this is a false assesment, since the GIT_SSH environment variable can use a custom script instead of ssh, which in essence can call ssh -i <custom-ssh-deploy-key>.
I've deployed that to our current setup already.


Bulk Actions - Shared Link Expiry

[X] I have checked that the [CLI documentation][cli-docs] and [API documentation][api-docs] doesn't solve my issue

Description of the Issue
I'm trying to update existing shared links on files with an expiry date in bulk. I have two CSV files, one for the file IDs and one for the corresponding expiry date in 'YYYY-MM-DD' format with a header called unshared-at, but I get an error when trying to execute (see below in Error Message). Executing individually with the same user ID, file ID, and date format works as expected.
Versions Used
Box CLI: @box/cli/2.3.0 darwin-x64 node-v11.13.0
Operating System: Mac Mojave
Steps to Reproduce
Create two input CSV files, one with file IDs, one with expiration dates in 'YYYY-MM-DD' format. Try to execute in bulk using: box files:shared-links:update --bulk-file-path=[path] --unshared-at=[path2] --as-user=[userid] -v
Error Message, Including Stack Trace
box files:shared-links:update --bulk-file-path=/Users/zszabo/Documents/Customers/XXXX/input-files-remaining-to-expire.csv --unshared-at=/Users/zszabo/Documents/Customers/XXXX/expiration-dates-files.csv --as-user=26668XXXX -v
  box:@box/cli:hooks:init done +0ms
  box init version<EMAIL_ADDRESS>argv: [ 'files:shared-links:update', '--bulk-file-path=/Users/zszabo/Documents/Customers/XXXX/input-files-remaining-to-expire.csv', '--unshared-at=/Users/zszabo/Documents/Customers/XXXX/expiration-dates-files.csv', '--as-user=26668XXXX', '-v' ] +0ms
  box-cli:init Initializing Box CLI +0ms
  box-cli:init Preparing for bulk input +0ms
  box-cli:execute Running framework error handler +0ms
  box-cli:execute Handling re-thrown error in base command handler +18ms
Cannot parse date format "/Users/zszabo/Documents/Customers/XXXX/expiration-dates-files.csv"

@zsofiaszabo sorry about the trouble you're having!  We'll get back to you ASAP to look into this for you.  Thanks!

@zsofiaszabo To use bulk commands, you can only use one csv. In that CSV, you must include both the file Ids and the unshared-at links times. An example of this would be the picture below of a CSV.

I hope this solves your issue! If you have any questions regarding this issue, you can re-open this.


Add CII Best Practices Badge

Get a CII Badge
https://bestpractices.coreinfrastructure.org/en

I and @rdimitrov are taking over the self-certification process for the Core Infrastructure Initiative Best Practices Badge. We'll use this as a master issue and spawn subissues to further track needed work refering back to this one.
At the beginning we would like to cover the basic "passing" criteria, as follows:

Have a stable website, which says:

what it does
how to get it
how to give feedback
how to contribute and
preferred styles

Explicitly specify a
FLOSS license
Support HTTPS on the project sites
Document how to install and run (securely),
and any API
Have a distributed
public version control system,
including changes between releases:

Give each release a unique version, using
semantic versioning format
Give a summary of changes for each release,
identifying any fixed vulnerabilities

Allow bug reports to be submitted,
archived and
tracked:

Acknowledge/respond to bugs &
enhancement requests, rather than
ignoring them
Have a secure,
documented process for
reporting vulnerabilities
Respond within 14 days,
and fix vulnerabilities,
within 60 days if they're public

Have a build that works, using
standard
open-source tools

Enable (and fix)
compiler warnings and lint-like checks
Run other static analysis tools and
fix exploitable problems

Have an automated test suite that
covers most of the code/functionality, and
officially
require new tests for new code
Automate running the tests on all changes,
and apply dynamic checks:

Run memory/behaviour analysis tools
(sanitizers/Valgrind etc.)
Run a fuzzer or web-scanner over the code

Have a developer who understands secure software
and common vulnerability errors

The project was added to CII best practices:
https://bestpractices.coreinfrastructure.org/en/projects/2725


TV shows multiple file and episode merger

Hi dularion,
I'm in the process of adding my TV shows and the files are organised like this
Show_Name_Folder

Season_Folder
-- Episode1.mp4
-- Episode2.pm4
-- etc

So basically all the episodes for one Season are in one folder.
I would like to have feature like this:
You select tv show and a Season
Then there is a button: "Match all episodes files to this show"
The button lets you select the master season folder and then lists the fetched episodes files and you can choose what file represents what episode in the season you chooese to match in streama. This could be with a virtual drag and drop. Or a list with numbers and you match the numbers.
Another way would be to let you select a file like now but then not close the file chooser insted inform the user that now episode 2 or whatever is in the pipeline and the next file he selects will be matched to this episode and so on.
This would speed up episode adding a great deal :-)
What do you think?

I believe to remember  you work on a solution like this.
In the mean time look at this: https://github.com/dularion/streama/issues/403


Add hacktoberfest label to easy issues

In order to be discoverable by everybody who are contributing to the hacktoberfest event, the maintainers should mark up some issues with the hacktoberfest label.
https://hacktoberfest.digitalocean.com/
would this be somehow interesting?

@laysauchoa since you are a contributor, can you check if you can add a label? :beginner: is a japanese (iirc) symbol for beginner, so that might be well suited to go into a label like  :beginner: / hacktoberfest

I created the label

thanks, it was too fast :)


error in line 5

Any more details than that?

I am using 18.04 Ubuntu mate desktop environment, during compilation it
shows an error in line 5
On Fri 31 Aug, 2018, 12:18 PM Nils Winkler<EMAIL_ADDRESS>wrote:

Any more details than that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Bash-it/bash-it/issues/1229#issuecomment-417569024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfX1Ohl3xWIuHI1GLlbsLdl-KlYYo1qcks5uWNw2gaJpZM4WS-Ks
.

Sorry, but we'll need more details. What compilation are you talking about? Can you please post a screenshot or a log of what you're trying to do that leads up to the error? And how is this related to Bash-it?

@harsh-anand1999 use  ./install.sh not sh ./install.sh
That fixed the issue for me


Core: validate AbstractConstant name

Currently, the AbstractConstantImpl constructor allows name to be for any String. This creates a problem when converting from vLog Strings that represent terms, to vlog4j Constant objects, and causes VLogToModelConverter#toConstant(String vLogConstantName) to have undesired behaviour for certain AbstractConstant names.
For example, for Expressions.makeAbstractConstant("\"Pragerstraße13\""), VLogToModelConverter#toConstant(String vLogConstantName)  throws IndexOutOfBoundsException, as it expects String "\"Pragerstraße13\"" that starts with quotation symbol " to either be surrdounded by "<" ">", or end in ">", or contain "@".

To encourage the use of Expressions class instead of Entity implementations, one could make their constructors package-protected, and move Expressions in the same package. Then, the validations could occur in Expressions instead of the Entity constructors.


feat: preserve search and filters in URL

✅ Closes: #23

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #23
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

It preserves the filters on the URL and merges them correctly when the same filter changes, but cannot figure out why when opening the link on another tab, it loses the search param and retains only the state param as before.

It preserves the filters on the URL and merges them correctly when the same filter changes, but cannot figure out why when opening the link on another tab, it loses the search param and retains only the state param as before.

Testing it right now!

Based on my understanding that's due to Angular not allowing nullvalue for queryParams.
As this.searchControl.valueChanges starts with a default value, it evaluates '' || null as null.

What was the motivation to use startWith('') ?

Working like a charm, thanks for your contribution!


Auth on laravel 5.7 not working normally

This is the user model
<?php

namespace SomeApp;

use Illuminate\Notifications\Notifiable;
use Illuminate\Contracts\Auth\MustVerifyEmail;
// use Illuminate\Foundation\Auth\User as Authenticatable;
use Jenssegers\Mongodb\Auth\User as Authenticatable;

class User extends Authenticatable //implements MustVerifyEmail
{
    use Notifiable;
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'email', 'password',
    ];
    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password', 'remember_token',
    ];
}

This is the error
Symfony \ Component \ Debug \ Exception \ FatalThrowableError (E_RECOVERABLE_ERROR)
Argument 1 passed to Jenssegers\Mongodb\Query\Builder::__construct() must be an instance of Jenssegers\Mongodb\Connection, instance of Illuminate\Database\MySqlConnection given, called in `\vendor\jenssegers\mongodb\src\Jenssegers\Mongodb\Eloquent\Model.`

if i implements must verify email
class User extends Authenticatable implements MustVerifyEmail

it will cause the following error
Class SomeApp\User contains 3 abstract methods and must therefore be declared abstract or implement the remaining methods (Illuminate\Contracts\Auth\MustVerifyEmail::hasVerifiedEmail, Illuminate\Contracts\Auth\MustVerifyEmail::markEmailAsVerified, Illuminate\Contracts\Auth\MustVerifyEmail::sendEmailVerificationNotification)

can you implement the 3 missing methods that are mentioned in the exception you got?

yeah, of course you need to add your own business logic here..

of course you need to create a mongodb connection..

@drmmyx Did you manage to get this working? I am having the same trouble here: https://github.com/jenssegers/laravel-mongodb/issues/1678

Below Its Work For me
Please use this in User.php
use Illuminate\Contracts\Auth\MustVerifyEmail;
use Illuminate\Notifications\Notifiable;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Contracts\Auth\MustVerifyEmail as MustVerifyEmailContract;
class User extends Authenticatable implements MustVerifyEmail
{
use MustVerifyEmail, Notifiable;

use Illuminate\Contracts\Auth\MustVerifyEmail;
have to
use Illuminate\Auth\MustVerifyEmail;


Move code generation into subcrate

Rebirthing the idea from #161, this moves the Rust code generation into a separate crate within the repository, rusoto_codegen, just to keep its dependencies more clearly isolated from rusoto, and to allow us to use a normal module hierarchy as needed instead of putting hundreds of lines of code in rusoto's build script.
Building on stable Rust is still just cargo build, and building on nightly Rust is cargo build --no-default-features --features nightly, although the latter doesn't actually work because of the ongoing issues with the quasi crate:
$ cargo doc --no-default-features --features "all nightly"
   Compiling quasi_macros v0.7.0
 Documenting quasi_macros v0.7.0
   Compiling rusoto_codegen v0.1.0 (file:///Users/redacted/Code/rusoto)
/Users/redacted/.multirust/cargo/registry/src/github.com-88ac128001ac3a9a/quasi_macros-0.7.0/src/lib.rs:19:29: 19:32/Users/redacted/.multirust/cargo/registry/src/github.com-88ac128001ac3a9a/quasi_macros-0.7.0/src/lib.rs:19:29: 19:32  errorerror: : mismatched types:
 expected `&mut syntex::Registry`,
    found `&mut rustc_plugin::registry::Registry<'_>`
(expected struct `syntex::Registry`,
    found struct `rustc_plugin::registry::Registry`)mismatched types:
 expected `&mut syntex::Registry`,
    found `&mut rustc_plugin::registry::Registry<'_>`
(expected struct `syntex::Registry`,
    found struct `rustc_plugin::registry::Registry`) [E0308 []E0308]

/Users/redacted/.multirust/cargo/registry/src/github.com-88ac128001ac3a9a/quasi_macros-0.7.0/src/lib.rs/Users/redacted/.multirust/cargo/registry/src/github.com-88ac128001ac3a9a/quasi_macros-0.7.0/src/lib.rs::1919      quasi_codegen::register(reg);    quasi_codegen::register(reg);

                                                                                ^~~                                                                                ^~~

/Users/redacted/.multirust/cargo/registry/src/github.com-88ac128001ac3a9a/quasi_macros-0.7.0/src/lib.rs:19:29: 19:32 help: run `rustc --explain E0308` to see a detailed explanation
error: aborting due to previous error
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `quasi_macros`.

To learn more, run the command again with --verbose.

That's not a new issue as it already happens on master trying to build against nightly. I have no idea what to do about it other than hope @erickt can help us. But this works for stable is as!

Diggin' the separation, very nice!  Ran a couple cargo build commands to test all features compile and s3 integration tests work. :+1:

And dat single Travis run. :heart_eyes:


State stack alignment requirements

Thus looks good to me from the perspective that it accurately and clearly describes the status quo for rv64, and describes a sensible alternative to the current rv32 stack alignment convention. Probably need more feedback on the rv32 change before merging.

I've modified the PR to reflect the present requirement (128 bits for RV32I and RV64I, or 32 bits for RV32E), and I'm going to merge it.  The debate about RV32I's stack alignment can continue separately.


Fixing squid: S1166 Exception handlers should preserve the original exception part 2

This pull request is focused on resolving occurrences of Sonar rule
squid:S1166- “ Exception handlers should preserve the original exception”.
This PR will reduce 60 min TD.
You can find more information about the issues here:
https://dev.eclipse.org/sonar/rules/show/squid:S1166
Please let me know if you have any questions.
Fevzi Ozgul

There is some strange exception in the tests in travis.

Let me have a look at it again.
On Wed, Jun 15, 2016 at 4:41 PM, Alex Voronov<EMAIL_ADDRESS>wrote:

There is some strange exception in the tests in travis.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexvoronov/geonetworking/pull/37#issuecomment-226190456,
or mute the thread
https://github.com/notifications/unsubscribe/AR09BH-mcuFcXQ6JH-5bwKulBPYK4568ks5qMAEmgaJpZM4Izzv-
.


[BUG]:Typo in README.md

Description of the bug
Many place in README.md typo 'svlete-lucide'
You should correct it
Steps To Reproduce
Correct to "svelte-lucide" or "svelte-lucide"
Additional Information
No response

Thanks. I updated the docs.


remove HostNetwork:true and DNSpolicy on csi node

Openshift certification indicates that pod.spec.hostNetwork:true on the csi node is not recommended.
I tested it without hostNetwor:true (which means its by default false) and it works well (tested it via the original yamls in the driver PR -> https://github.com/IBM/ibm-block-csi-driver/pull/94).
Since hostNetwork dropped then we can also drop the DNSpolicy setting as well.

@27149chen no touch on the node_agent per your request. waiting for your LGTM


Update CouponCode.php

Removed requirement of native PHP function str_rot13() as this function is used by hackers a lot when obfuscating malicious PHP and worth disabling for security.

Hey @pau1phi11ips thanks for suggesting the change, but that function by itself is in no way a security issue.


palatal taste bud terms

Consider adding:
abnormal palatal taste bud morphology (a child of abnormal soft palate morphology MP:0003154)
DEF: any structural anomaly of the taste bud, a specialized receptor organ consisting of a group of clustered sensory cells, located on the soft palate, in the roof of the mouth; palatal taste buds lack supporting papilla structures and are directly embedded in the epithelium of the soft palate
SOURCE: PMID:25299669
SOURCE: UBERON:0034670
absent palatal taste bud
DEF: absence of the palatal taste bud that normally develops in the epithelium of the soft palate without associated papilla structures
SYN: absent palatal taste buds
Annotations from J:112945

Added new terms:
abnormal palatal taste bud morphology MP:0031466
absent palatal taste bud MP:0031467
Also, currently, the EQ for abnormal soft palate morphology MP:0003154 uses 'quality' and 'characteristic of'. Changed EQ to use:
'has part' some
(morphology
and ('characteristic of part of' some 'soft palate')
and ('has modifier' some abnormal))
Need to review abnormal taste bud morphology MP:0001002 def refers specifically to the tongue but this appears to be the same as its child term abnormal gustatory papillae taste bud morphology MP:0006260

To Do:

[ ] obsolete existing abnormal taste bud morphology
[ ] create a new abnormal taste bud morphology that is NOT specific to tongue
[ ] move existing term annotations to MP:0006260 and update synonyms
[ ] place palate taste bud term under new abnormal taste bud morphology

Obsoleted existing abnormal taste bud morphology MP:0001002

Created new term for abnormal taste bud morphology that is NOT specific to tongue MP:0031468.

Moved existing term annotations to abnormal gustatory papillae taste bud morphology MP:0006260 and updated synonyms

Placed palate taste bud terms MP:0031466 and MP:0031467 under new abnormal taste bud morphology MP:0031468

Placed abnormal gustatory papillae taste bud morphology MP:0006260 under abnormal gustatory papillae morphology MP:0006256 as an additional parent


Todo list ?

Hi Alisdair,
Lucinda at AmbiClimate just pointed me in your direction, I had been working on a homebridge plugin for Ambi climate too. I had approached from quite a different direction, adapting a precious netatmo plugin to work with AmbiClimate. I just got it functioning yesterday, but now I have seen your code, I prefer your approach.
My implementation includes a function, to obtain the authorization code. I've refactored it, and prepared it for your review through a pull request.
I'd be more than happy to collaborate with you on the project. Do you have a list of things you'd like to do, perhaps I can pick one or two, so we avoid working on the same things in parallel.
Cheers
Guy

Guy,
Happy to collaborate.  I was in the process of trying to resolve the oauth2 client, and frankly hadn't given too much thought past that point.  Any thoughts you have are welcome.
As you would have seen I have two distinct projects:

node-ambiclimate: a wrapper for the API and
homebridge-ambiclimate: the homebridge plugin

(I am happy to collaborate on both)
At the moment the plugin exposes the current temperature and relative humidity and provides a mechanism for turning the AC on (in comfort mode) and off.
As an immediate action I will incorporate your pull-request and fix the current homebridge-ambiclimate implementation.
Alisdair

That's great. Next thing I'd propose to contribute is my attempt at a ThermostatService as a home bridge Platform. I'll need to refactor somewhat to match your much cleaner structure, so it will take a few days or so...

Thanks for the acknowledgement in the README :)

Ambi just added a /device/mode call to the api !
Details on the api doc page
G

Added mode function - available in npm v2.1.0

I'm almost ready to commit my proposed changes to provide a ThermostatService. I ran in to a couple of issues with the ambi API (not matching docs). I've reported them, and hopefully will be able to finalise by next week. I also made a couple of feature requests which would help improve integration with HomeKit for a future version.
I decided not to attempt to integrate the Platform code just yet, and plan to move to that as a second step, once the Thermostat code is agreed.

I look forward to seeing what you have done.
One thing I noticed after you pointed me at the new Mode endpoint was that there was an inconsistency between the modes in the App and the API. e.g. turning a device off with the App is reported as Manual through the API.

Yes, the Off mode is not correctly reported, the Comfort mode returns Climate not Comfort as per docs and the Away upper and lower seem to have been swapped. I think they knocked up the interface quickly for us and didn't have a chance to test much.
I wrote to them but I guess they are on vacation this week due to Chinese new year.
I also requested visibility of the AC mode, the AC fan and louver state, and an event stream. I expect they'll be back to the office next week.
Cheers
Guy

Any feedback from the folks at Ambi Climate?

Hi Alisdair,
apologies for the silence, I've been away on vacation for a couple of weeks then catching up at the office.
Yes the bug in the Ambi API is now fixed, I've been working on the homebridge interface today and have added regular polling to keep it updated (until Ambi add an event api). I'm fairly happy with result, and once I have a chance to clean up the debugging code later in the week, I will upload to my repository for you to take a look.

Sounds good.
Is it your intention to submit a pull request on the homebridge-ambiclimate project?

Hello. Is there an update on the new API working with smartthings? I'd love to integrate mine.

@aaronfisher - I'd love to integrate mine with SmartThings also, but have not identified a way to integrate with Ambi Climate's oauth2 implementation within SmartThings Groovy.

Copied from the current Kickstarter campaign for Ambitious 2.0 ...

If you help us reach HK$1,170,000 we'll get going on "Connected Everything" - various smart home integrations such as Homebridge & SmartThings. We know this is a hot topic and we'll make sure to run a special survey to find out the top integrations on your wishlist!

I saw that. I hope that they are able to produce one but I imagine it is a few months away, at best.


Farming plugin disease false positives

If the user nears a farming spot (Experienced with fruit trees, not noticed the behaviour on other types of plot) then the tracker will false-positive the plot into a diseased state.
Thus far I've noticed this behaviour with both pineapple, and papaya trees at both the brimhaven and catherby spots.
Diseased plant -

False Positive -

Noticed locations -
Running towards catherby fruit tree from allotments
Brimhaven boat, after arriving, but before taking a single step

As an addition that I previously didn't notice at time of posting, not only is the state suffering from a false positive in displaying diseased but it also shows the plot, which contains a fully grown papaya sapling, as being a banana tree

I've run into the same bug, where orange trees at catherby are shown as dragonfruit


Access from other activity

Hello guys! I've a problem... what if I want to decrypt the string from other activity/fragment/etc?
As far as I can see, I need the CipherTextIvMac and keys, the same ones used for encrypt. Wouldn't be a best option to set a key value, pass it and the encrypted string for decrypt?
That way we can move around the data and keep it safe/secure.

To decrypt the data (CipherTextIvMac), you need the decryption keys. AES is a symmetric algorithm, so the same keys used for decryption are also used for encryption.
There is already a function to pass the key value and the encrypted strings for decrypt.
Can you clarify your request, please?

Let's just say I've generate my key and I've encrypted my string. Now, that string I've storage on a SharedPreference (keep encrypted and can be move around anywhere any time)... when I return the Shared would be just a string encrypted from another Activity, any other way where I didn't generate the keys and encrypted the string. Maybe the sample didn't get me a clear idea... but key are not generated random? how to get the same key value from other place? and the CipherTextIvMac? Maybe an example of how to do it would be great.

Hi mkiisoft,
You do indeed need the key to decrypt the ciphertext, so if you are at a part of the code where that key is not available, you have to find a way to share or generate the same key. That's just how symmetric crypto works.
There are two ways to generate keys in our library:

Randomly
Based on passwords

If you use method 1, you definitely will need to store the key somewhere. Sadly there aren't too  many good options for that on Android.
For 2, you can re-generate the same key with the same password every time; just use the obviously-named function.


[Enhancement]: Improving UI and Rectifying Errors

Description

Would like to contribute by improving the UI and styling of your Website
Would like to work on header
Filter and Sort Selective buttons
Glow Effect of Heart Icon

sure @hariketsheth. You can create a PR for it.


Trying to run via docker but not successful

When starting docker via "docker compose up -d" I see those errors and app will not start:
immich-duplicate-finder  |
immich-duplicate-finder  | Collecting usage statistics. To deactivate, set browser.gatherUsageStats to False.
immich-duplicate-finder  |
immich-duplicate-finder  |
immich-duplicate-finder  | Traceback (most recent call last):
immich-duplicate-finder  |   File "/usr/local/bin/streamlit", line 8, in <module>
immich-duplicate-finder  |     sys.exit(main())
immich-duplicate-finder  |              ^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
immich-duplicate-finder  |     return self.main(*args, **kwargs)
immich-duplicate-finder  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1078, in main
immich-duplicate-finder  |     rv = self.invoke(ctx)
immich-duplicate-finder  |          ^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
immich-duplicate-finder  |     return _process_result(sub_ctx.command.invoke(sub_ctx))
immich-duplicate-finder  |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
immich-duplicate-finder  |     return ctx.invoke(self.callback, **ctx.params)
immich-duplicate-finder  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/click/core.py", line 783, in invoke
immich-duplicate-finder  |     return __callback(*args, **kwargs)
immich-duplicate-finder  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/web/cli.py", line 234, in main_run
immich-duplicate-finder  |     _main_run(target, args, flag_options=kwargs)
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/web/cli.py", line 270, in _main_run
immich-duplicate-finder  |     bootstrap.run(file, is_hello, args, flag_options)
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/web/bootstrap.py", line 386, in run
immich-duplicate-finder  |     _install_pages_watcher(main_script_path)
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/web/bootstrap.py", line 362, in _install_pages_watcher
immich-duplicate-finder  |     watch_dir(
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/watcher/path_watcher.py", line 151, in watch_dir
immich-duplicate-finder  |     return _watch_path(
immich-duplicate-finder  |            ^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/watcher/path_watcher.py", line 126, in _watch_path
immich-duplicate-finder  |     watcher_class(
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/watcher/event_based_path_watcher.py", line 95, in __init__
immich-duplicate-finder  |     path_watcher.watch_path(
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/streamlit/watcher/event_based_path_watcher.py", line 173, in watch_path
immich-duplicate-finder  |     folder_handler.watch = self._observer.schedule(
immich-duplicate-finder  |                            ^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/api.py", line 323, in schedule
immich-duplicate-finder  |     emitter.start()
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/utils/__init__.py", line 92, in start
immich-duplicate-finder  |     self.on_thread_start()
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify.py", line 125, in on_thread_start
immich-duplicate-finder  |     self._inotify = InotifyBuffer(path, self.watch.is_recursive, event_mask)
immich-duplicate-finder  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify_buffer.py", line 37, in __init__
immich-duplicate-finder  |     self._inotify = Inotify(path, recursive, event_mask)
immich-duplicate-finder  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify_c.py", line 174, in __init__
immich-duplicate-finder  |     self._add_dir_watch(path, recursive, event_mask)
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify_c.py", line 380, in _add_dir_watch
immich-duplicate-finder  |     self._add_watch(path, mask)
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify_c.py", line 401, in _add_watch
immich-duplicate-finder  |     Inotify._raise_error()
immich-duplicate-finder  |   File "/usr/local/lib/python3.12/site-packages/watchdog/observers/inotify_c.py", line 413, in _raise_error
immich-duplicate-finder  |     raise OSError(errno.ENOSPC, "inotify watch limit reached")
immich-duplicate-finder  | OSError: [Errno 28] inotify watch limit reached
immich-duplicate-finder exited with code 0

This is not a bug of this software.
Try this on your docker host: https://unix.stackexchange.com/questions/13751/kernel-inotify-watch-limit-reached and close this Issue

@Fclem is right. If you use unRAID use the Tips and Tweaks plugin and increase your Max user instances value. The default is 128 and I increased it to 40000 as I have enough left. This is maximum number of inotify instances that a user can create.


feat(loadLanguageAsync): Support promises return in lang files

Based on this feature request that I opened myself:
https://github.com/nuxt-community/nuxt-i18n/issues/60

Nice! thanks @ezypeeze !

Hello, you can provide an example

Hi all! First of all, thank you for all your hard work!
In example above we fetching all data of one language for all app, but, if we have a lot of data?
Is there any proper way to load data, lets say some local GlobalData (Header and Footer) and data of only one page (local) wich is loading? Or maybe, better solution is to use middleware and mutations build in nuxt-i18n config (I18N_SET_MESSAGES).
In my new project, I geting data from firebase and it works great, but project is growing and I looking for better solution for fetching data, so to say, by small piece. Code example:
import axios from 'axios';
import Vue from 'vue';

Vue.use(axios);

export default () => {
  return axios.get('https://bla-bla-bla.firebaseio.com/en.json')
  .then(function (response) {
    return response.data;
  })
  .catch(function (error) {
    error;
  });
}


When pasting in multi-line values, it pastes twice

Codesandbox: https://codesandbox.io/s/cranky-waterfall-7p4px8?file=/src/App.js
Copy the following:
[lib]
crate-type = ["cdylib"]

As you can see, the code pastes twice for some reason.

I am wondering if this has something to do with recoil...

Hey @jonathon-neoswap ,
I am new to this repo and was just going around the issues.
I just went through your code.
If we paste anything, the code pastes it twice.
This error can be removed by removing/commenting line number 55.
Here is the code that is changed:
<CodeMirror
        value={theCode}
        className="rounded-tl-lg rounded-bl-lg"
        height="100%"
        theme="dark"
        extensions={[
          EditorView.lineWrapping,
          FontSizeThemeExtension,
          rust(),
          // readOnlyRangesExtension(getReadOnlyRanges)  --> change
        ]}
        onChange={onChange}
        editable={isDisabled}
      />

By doing this, we don't get the same error.
Also as I am new to this repo, can you explain why we even need readOnlyRangesExtension.
Thank you!


Add null_value_pattern and null_empty_string option for LabeledTSVParser, CSVParser, TSVParser.

Hello.
Cannot express NULL in LTSV.
ltsv library for Ruby blank to NULL.
https://github.com/condor/ltsv/blob/master/lib/ltsv.rb#L97
I use LTSV with apache.
Apache log is If value not exists with hyphen('-').
I think hyphens to null, any of the following methods.

LabeledTSVParser add parameter with @null_value
※this PR

settings example.
<source>
  type tail
  path /var/log/httpd/access_log
  format ltsv
  time_key time
  null_value -
  time_format %d/%b/%Y:%H:%M:%S %z
  tag td.apache.access
  pos_file /var/log/td-agent/apache_access.pos
</source>

specifications similar to the Ruby library(blank to null)
Make your own filter plugin.

Which one is good?

I think 1. is good and it is good enough for now.
I may want to use using 1. and 2. together occasionally. So, alternative idea is to add null_value_pattern: pattern option instead of null_value to accept a regexp, or add null_empty_string: true option in addition to null_value.

I think this PR is simple enough and good to merge. Any concerns, @repeatedly?

@frsyuki
Thank you for your reply!

I may want to use using 1. and 2. together occasionally. So, alternative idea is to add null_value_pattern: pattern option instead of null_value to accept a regexp, or add null_empty_string: true option in addition to null_value.

I see.
Please wait a moment...

Thank you for advice!
I add null_value_pattern and null_empty_string option for LabeledTSVParser.
settings example.
<source>
  type tail
  path /var/log/httpd/access_log
  format ltsv
  time_key time
  null_value_pattern ^(-|null|NULL)$
  null_empty_string true
  time_format %d/%b/%Y:%H:%M:%S %z
  tag td.apache.access
  pos_file /var/log/td-agent/apache_access.pos
</source>

null_value_pattern

default is nil.
regular expression syntax.

null_empty_string

default is false.
empty string to null.
this is same behavior.

Why don't we add these options for super class (ValuesParser)?

@sonots
thank you!
Oh, ValuesParser definition, affects CSVParser and TSVParser.
Null in regular expression definition, I think Good idea!
But empty to NULL casting is LTSV specification.
@repeatedly
I think no problem, Is it OK?

Certainly, in the format like below with MySQL restore
"1";"2";"3";"4";NULL

empty to NULL casting is LTSV specification.

Is it official LTSV specification? I thought it is just a custom.

Is it official LTSV specification? I thought it is just a custom.

That's right!
No such process in other languages.
java
https://github.com/making/ltsv4j/blob/master/src/main/java/am/ik/ltsv4j/LTSVParser.java
python
https://github.com/hekyou/python-ltsv/blob/master/ltsv/_reader.py

Why don't we add these options for super class (ValuesParser)?
I'll fix fix in this way.
Please wait a moment.

fixed.
add null_value_pattern and null_empty_string option, support format is tsv,csv,ltsv.

reviewed

thank you for review.
I 'll fix it.

Apply this review.
scrub Referenced filter-grep-plugin.
thanks.

added Fluent::StringUtil, filter-grep-plugin and this feature common procesing.
thanks.

Looks good to me. Any concerns? > @repeatedly

Nothing.

Merged!

@repeatedly @sonots @frsyuki thank you for many advise! :blush:

Released v0.12.16!

:blush:

I found that log is not defined in Fluent::StringUtil.match_regexp. So this rescue block will raise NameError every time.

@tagomoris Sorry and Thanks. I will check it.

Changes Unknown when pulling 0ec1c5316b7166549769fb1fa6dc2e9202251ac2 on toyama0919:master into ** on fluent:master**.


PEM: Make PEM_write_bio_PrivateKey_traditional() handle provider-native keys

PEM_write_bio_PrivateKey_traditional() didn't handle provider-native
keys very well.  Originally, it would simply use the corresponding
encoder, which is likely to output modern PEM (not "traditional").
PEM_write_bio_PrivateKey_traditional() is now changed to try and get a
legacy copy of the input EVP_PKEY, and use that copy for traditional
output, if it has such support.
Internally, evp_pkey_copy_downgraded() is added, to be used when
evp_pkey_downgrade() is too intrusive for what it's needed for.

This is a follow-up on #12728, and currently includes its commits.  Only the last commit belongs here.

Now that #12728 is in, this is no longer WIP

If I rebase #8743 on top of this and run openssl genrsa -traditional, I get an invalid free.

Thanks, that clarified something.  Fix coming up

okie, I believe the added fixup fixes things.  At least, ./util/wrap apps/openssl genrsa -traditional now works for me without complaints, when merged with #8743...

Hmmm, I do have a modified test/endecode_test.c...  somewhere.  I'll add that here as soon as I find it.

Hmmm, I do have a modified test/endecode_test.c... somewhere. I'll add that here as soon as I find it.

Done

This pull request is ready to merge

Merged
4ce1025a8ac37d255f569147116dd776f9267cce PEM: Make PEM_write_bio_PrivateKey_traditional() handle provider-native keys
1251cddf8d413af3747e81e39141f34318f92cd6 TEST: modify test/endecode_test.c to not use legacy keys


Performance regression bisected to 65f6f99a4220d81785fb31a0f64feca02265e106

Newsboat version (copy the output of newsboat -v or the first line of git show):
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
https://github.com/polyzen/dotfiles/blob/master/workstation/.config/newsboat/config
Steps to reproduce the issue:

Have feed with ridiculous amount of articles (eg. 4282 articles)

Hold down key to scroll

newsboat lags and pegs out a core until it's done scrolling

Other info you think is relevant:
Bisected: "65f6f99a4220d81785fb31a0f64feca02265e106 is the first bad commit"
https://github.com/newsboat/newsboat/commit/65f6f99a4220d81785fb31a0f64feca02265e106

cc @dennisschagt

Thank you for the report! I bisected to the same commit with an empty config. I don't yet understand how this commit causes the regression, but I'm looking into it.

I traced this down to ItemListFormAction::do_redraw being constantly true, which makes the following if call invalidate_list() on each iteration, which in turns means Newsboat has to go through all items in the list and "format" them:
https://github.com/newsboat/newsboat/blob/fad9cc0b58fd257c9422bd2f8e5aab2e55acdf20/src/itemlistformaction.cpp#L1006-L1009
This is fixed by #1374.
I don't feel like this is quite catastrophic enough to warrant a bugfix release. @polyzen, do you agree? Does your workflow rely heavily on fast-scrolling through the item list?

Just normal scrolling, though I should definitely clean out my articles. This is on a desktop with an i5-3570k, so it may affect users on slower systems with smaller article counts.
Before:
https://user-images.githubusercontent.com/3533182/102935315-d04a0c00-449d-11eb-999e-698751983cb0.mp4
After:
https://user-images.githubusercontent.com/3533182/102934934-0aff7480-449d-11eb-8f61-a46edee1ceb0.mp4

Okay, okay, I'll release 2.22.1, say, on the 9th January 2021 — I'd like to wait a bit for 2.22 to get into distros and for people to report any more critical bugs.


New option to exclude preload files and rewriting ScriptFileStorage.listScripts

I have added a new option --preload-exclude.  Sometimes I don't want  node_modules to preload, because that files all preload together will cause my debug efficiency.
Example - preload exclude all node_modules.
node-inspector  --preload-exclude .*\\/node_modules\\/.*

But I found that even though I blocked these files, still very slow startup times.   I rewrote listScripts in ScriptFileStorage.js.
Now It can be very fast startup times, and even if  did not use --preload-exclude .*\\/node_modules\\/.*

@shitiven I added an option you may want to look at.
It adds an option that will ignore the directories and files that you pass in using glob notation.
Example.
node-debug --ignore "**/node_modules/**" <filename>
I use it to ignore node_modules which makes my debug startup time go from close to a minute down to a few seconds.

Thank you for contribution!
In node-inspector 0.12.6 released alternative solution which solves this problem


answers: Remove singleton data holder DATA & adapt

Closes https://github.com/coala/corobo/issues/236
Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

ack https://github.com/coala/corobo/pull/237/commits/bed50bf63453312200ba05b67c3243f23e5b58a6

ack https://github.com/coala/corobo/pull/237/commits/b35e91b0f1cca607cc7e6d1ebbd5475462f9b2e1

ack https://github.com/coala/corobo/pull/237/commits/317d77b088a6df7715b5061253e30b726dda3ae9

ack https://github.com/coala/corobo/pull/237/commits/bc81dbd284039b2e3bc439433deab6eca394a493

Weird gitmate bug.

reack ea07f6b2fe795a2d5b1d27bca603391f79df7002

reack 0c4cf36dab700b27b242ecdd3451874299cafd7a
reack 29003636f66db09e47feea85c5d0286109b821dd
ack  b5787623a80d60dcd043d29e7f50ab24f1b17b1b
ack 7f1b9ccafce6861d1364b5ba911547ad9b119fd3

lgtm

ack b9a84aa9

@rultor merge

@rultor merge

@meetmangukiya OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@meetmangukiya Done! FYI, the full log is here (took me 2min)


Jobs do not stream to client with 0.17.0 server

Steps to reproduce:

Start a 0.17 Zeebe server. For example: docker run -p 26500:26500 camunda/zeebe:0.17.0
Transpile the client library: npm i && tsc
Run the example worker: cd example && node worker.js
Start some workflow instances: cd example && node start-workflow-instance.js

Expected Behaviour:
See jobs being serviced by worker.
Actual Behaviour:
The worker does nothing.
Further Information

Starting a 0.17 Zeebe instance with the Simple Monitor running shows no workers in the Simple Monitor worker listing.
Workflow instances and tasks are created, but no workers service them.
The call to activateJobs() in the client executes and returns a stream, but the returned stream's on('data') handler is never called.

Narrowed it down. The new .proto file I pulled in to support setVariables is the cause. Investigating.