systemd-networkd fails when using physical(!) Incus network

To be honest, I'm not sure where to file this bug... lxc, Incus, or systemd? Would love to hear your thoughts on the issue. For now I have a usable workaround (using ifupdown, details below), but it would be helpful if this bug would be fixed, so everybody can benefit from things working out-of-the-box.
EDIT: I probably should've filed this under lxc/incus instead of zabbly/incus. Sorry!
EDIT2: Incus version: 6.0.1 LTS
Background:
I'm running an Incus host in QEMU/KVM. Hence, I've added multiple virtual NICs to the Incus host, so I can give each container its own NIC, in order to avoid running into issues related to things like 'port security' and multiple MAC addresses originating from the same NIC (as would be the case with macvlan).
On the Incus host:
incus network create testphys0 -t physical parent=enp9s0
Then I assigned the physical 'testphys0' Incus network to a regular Debian 12 (bookworm) system container.
Or, in one step (ignoring the above):
incus config device add testcontainer eth0 nic nictype=physical parent=enp9s0
The problem:
In the container:
The systemd-networkd daemon is NOT assigning an IP address to the eth0 interface.
I've tried using a static IP as well as DHCP. There's no difference in symptoms.
The eth0 interface is UP but is NOT being assigned an IP address.
The networkctl command shows the following:
  IDX LINK TYPE     OPERATIONAL SETUP
    1 lo   loopback carrier     unmanaged
    6 eth0 ether    degraded    pending

  2 links listed.

The ip -br a command shows:
  lo               UNKNOWN        <IP_ADDRESS>/8 ::1/128
  eth0             UP             fe80::5054:ff:fecc:ef0a/64

(Disabling IPv6 doesn't matter either.)
I've also included the systemd-networkd logs (with debugging output).
See further below.
A dirty, undesirable workaround is to run the container in privileged mode, but for security reasons that's NOT a viable solution. For those interested in a better (safer) workaround, see below.
Now the question:
Is this a bug in systemd-networkd or somewhere else?
Workaround (or solution), for others reading this:
This is a workaround which does NOT require the container to be in 'privileged mode':
This will disable systemd-networkd and it will remove the systemd-resolved package. The systemd-resolved package is removed by installing resolvconf (which we will need if we want to configure DNS settings via the ifupdown interfaces config file).
  $ systemctl disable --now systemd-networkd.service
  $ systemctl disable --now systemd-networkd.socket
  $ apt install ifupdown resolvconf
  $ cat <<EOF > /etc/network/interfaces.d/eth0
  auto eth0
  iface eth0 inet static
          address <IP_ADDRESS>/24
          gateway <IP_ADDRESS>
          # Space-separated list of DNS servers.
          dns-nameservers <IP_ADDRESS>
          # Search suffix for DNS lookups having fewer
          # than 'ndots' dots (default 1).
          dns-search example.localdomain
  EOF

Note, it seems you must use 'auto eth0' and NOT 'allow-hotplug eth0', otherwise it won't work. That might be because ifupdown's networking scripts won't actually be triggered by the hotplug (udev) event because the interface is being renamed when the container is starting up, meaning the hotplug event was missed (the interface had a different name at the moment of the udev event).
Other debugging details:

If we give the container a bridged Incus network, like 'incusbr0', there's no issue at all.
The problem only occurs if we assign a physical Incus network to the container, as shown at the beginning of this post.

I've read lxc issue #2278 and that made me check AppArmor.
For completeness sake: installing apparmor and running 'aa-teardown' doesn't make a difference; if we subsequently run 'systemctl restart systemd-networkd', the symptoms stay the same.

Just to rule it out, I tried changing the Incus VM's virtual NIC driver from virtio to e1000e, without any noticeable difference.

Logs:
Logs from the (non-privileged) container, with SYSTEMD_LOG_LEVEL=debug enabled:
# journalctl -eu systemd-networkd
Jul 09 19:50:05 example systemd[1]: Stopping systemd-networkd.service - Network Configuration...
Jul 09 19:50:05 example systemd[1]: systemd-networkd.service: Deactivated successfully.
Jul 09 19:50:05 example systemd[1]: Stopped systemd-networkd.service - Network Configuration.
Jul 09 19:50:05 example systemd[1]: Starting systemd-networkd.service - Network Configuration...
Jul 09 19:50:05 example systemd-networkd[523]: SELinux enabled state cached to: disabled
Jul 09 19:50:05 example systemd-networkd[523]: Failed to increase receive buffer size for general netlink socket, ignoring: Operation not permitted
Jul 09 19:50:05 example systemd-networkd[523]: Bus bus-api-network: changing state UNSET → OPENING
Jul 09 19:50:05 example systemd-networkd[523]: sd-bus: starting bus bus-api-network by connecting to /run/dbus/system_bus_socket...
Jul 09 19:50:05 example systemd-networkd[523]: Bus bus-api-network: changing state OPENING → AUTHENTICATING
Jul 09 19:50:05 example systemd-networkd[523]: Registering bus object implementation for path=/org/freedesktop/network1 iface=org.freedesktop.network1.Manager
Jul 09 19:50:05 example systemd-networkd[523]: Registering bus object implementation for path=/org/freedesktop/network1/link iface=org.freedesktop.network1.DHCPServer
Jul 09 19:50:05 example systemd-networkd[523]: Registering bus object implementation for path=/org/freedesktop/network1/link iface=org.freedesktop.network1.Link
Jul 09 19:50:05 example systemd-networkd[523]: Registering bus object implementation for path=/org/freedesktop/network1/network iface=org.freedesktop.network1.Network
Jul 09 19:50:05 example systemd-networkd[523]: Registering bus object implementation for path=/org/freedesktop/LogControl1 iface=org.freedesktop.LogControl1
Jul 09 19:50:05 example systemd-networkd[523]: sd-device-monitor(n/a): No permission to stat PID1's netns, unable to determine if we are in host netns, ignoring: Permission denied
Jul 09 19:50:05 example systemd-networkd[523]: sd-device-monitor(n/a): Failed to increase receive buffer size, ignoring: Operation not permitted
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Saved new link: ifindex=6, iftype=ETHER(1), kind=n/a
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Saved original MTU 1500 (min: 68, max: 65535)
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Saved hardware address: 52:54:00:cc:ef:0a
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Saved IPv6 link-local address generation mode: eui64
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Flags change: +UP +LOWER_UP +RUNNING +MULTICAST +BROADCAST
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Link UP
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Gained carrier
Jul 09 19:50:05 example systemd-networkd[523]: eth0: link pending udev initialization...
Jul 09 19:50:05 example systemd-networkd[523]: lo: Saved new link: ifindex=1, iftype=LOOPBACK(772), kind=n/a
Jul 09 19:50:05 example systemd-networkd[523]: lo: Saved original MTU 65536 (min: 0, max:<PHONE_NUMBER>)
Jul 09 19:50:05 example systemd-networkd[523]: lo: Saved hardware address: 00:00:00:00:00:00
Jul 09 19:50:05 example systemd-networkd[523]: lo: Saved IPv6 link-local address generation mode: eui64
Jul 09 19:50:05 example systemd-networkd[523]: lo: Flags change: +LOOPBACK +UP +LOWER_UP +RUNNING
Jul 09 19:50:05 example systemd-networkd[523]: lo: Link UP
Jul 09 19:50:05 example systemd-networkd[523]: lo: Gained carrier
Jul 09 19:50:05 example systemd-networkd[523]: lo: udev initialized link
Jul 09 19:50:05 example systemd-networkd[523]: lo: State changed: pending -> initialized
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Received new foreign QDisc (configured): handle=0:0, parent=ffff:ffff, kind=fq_codel
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign QDisc (configured): handle=0:0, parent=ffff:ffff, kind=noqueue
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Received new foreign address (configured): fe80::5054:ff:fecc:ef0a/64 (valid forever, preferred forever), flags: permanent, scope: link
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Gained IPv6LL
Jul 09 19:50:05 example systemd-networkd[523]: eth0: link_check_ready(): link is in pending state.
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign address (configured): ::1/128 (valid forever, preferred forever), flags: permanent, scope: host
Jul 09 19:50:05 example systemd-networkd[523]: lo: link_check_ready(): link is in initialized state.
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign address (configured): <IP_ADDRESS>/8 (valid forever, preferred forever), flags: permanent, scope: host
Jul 09 19:50:05 example systemd-networkd[523]: lo: link_check_ready(): link is in initialized state.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received non-static neighbor, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received non-static neighbor, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received non-static neighbor, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received non-static neighbor, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received non-static neighbor, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Received new foreign route (configured): dst: ff00::/8, src: n/a, gw: n/a, prefsrc: n/a, scope: global, table: local(255), proto: kernel, type: multicast, nexthop: 0, priority: 256, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Received new foreign route (configured): dst: fe80::5054:ff:fecc:ef0a/128, src: n/a, gw: n/a, prefsrc: n/a, scope: global, table: local(255), proto: kernel, type: local, nexthop: 0, priority: 0, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign route (configured): dst: ::1/128, src: n/a, gw: n/a, prefsrc: n/a, scope: global, table: local(255), proto: kernel, type: local, nexthop: 0, priority: 0, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: eth0: Received new foreign route (configured): dst: fe80::/64, src: n/a, gw: n/a, prefsrc: n/a, scope: global, table: main(254), proto: kernel, type: unicast, nexthop: 0, priority: 256, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign route (configured): dst: <IP_ADDRESS>/32, src: n/a, gw: n/a, prefsrc: <IP_ADDRESS>, scope: link, table: local(255), proto: kernel, type: broadcast, nexthop: 0, priority: 0, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign route (configured): dst: <IP_ADDRESS>/32, src: n/a, gw: n/a, prefsrc: <IP_ADDRESS>, scope: host, table: local(255), proto: kernel, type: local, nexthop: 0, priority: 0, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: lo: Received new foreign route (configured): dst: <IP_ADDRESS>/8, src: n/a, gw: n/a, prefsrc: <IP_ADDRESS>, scope: host, table: local(255), proto: kernel, type: local, nexthop: 0, priority: 0, flags: n/a
Jul 09 19:50:05 example systemd-networkd[523]: Remembering foreign routing policy rule (configured): priority: 32766, ::/0 -> ::/0, iif: n/a, oif: n/a, table: main(254)
Jul 09 19:50:05 example systemd-networkd[523]: Remembering foreign routing policy rule (configured): priority: 0, ::/0 -> ::/0, iif: n/a, oif: n/a, table: local(255)
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received rule message with invalid family 129, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: rtnl: received rule message with invalid family 128, ignoring.
Jul 09 19:50:05 example systemd-networkd[523]: Remembering foreign routing policy rule (configured): priority: 32767, <IP_ADDRESS>/0 -> <IP_ADDRESS>/0, iif: n/a, oif: n/a, table: default(253)
Jul 09 19:50:05 example systemd-networkd[523]: Remembering foreign routing policy rule (configured): priority: 32766, <IP_ADDRESS>/0 -> <IP_ADDRESS>/0, iif: n/a, oif: n/a, table: main(254)
Jul 09 19:50:05 example systemd-networkd[523]: Remembering foreign routing policy rule (configured): priority: 0, <IP_ADDRESS>/0 -> <IP_ADDRESS>/0, iif: n/a, oif: n/a, table: local(255)
Jul 09 19:50:05 example systemd-networkd[523]: Enumeration completed
Jul 09 19:50:05 example systemd[1]: Started systemd-networkd.service - Network Configuration.
Jul 09 19:50:05 example systemd-networkd[523]: Bus bus-api-network: changing state AUTHENTICATING → HELLO
Jul 09 19:50:05 example systemd-networkd[523]: Sent message type=method_call sender=n/a destination=org.freedesktop.DBus path=/org/freedesktop/DBus interface=org.freedesktop.DBus member=Hello cookie=1 reply_cookie=0 signature=n/a error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Sent message type=method_call sender=n/a destination=org.freedesktop.DBus path=/org/freedesktop/DBus interface=org.freedesktop.DBus member=RequestName cookie=2 reply_cookie=0 signature=su error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Sent message type=method_call sender=n/a destination=org.freedesktop.DBus path=/org/freedesktop/DBus interface=org.freedesktop.DBus member=AddMatch cookie=3 reply_cookie=0 signature=s error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=method_return sender=org.freedesktop.DBus destination=:1.17 path=n/a interface=n/a member=n/a cookie=1 reply_cookie=1 signature=s error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Bus bus-api-network: changing state HELLO → RUNNING
Jul 09 19:50:05 example systemd-networkd[523]: lo: Failed to get driver, continuing without: Operation not supported
Jul 09 19:50:05 example systemd-networkd[523]: lo: Saved permanent hardware address: 00:00:00:00:00:00
Jul 09 19:50:05 example systemd-networkd[523]: lo: Link state is up-to-date
Jul 09 19:50:05 example systemd-networkd[523]: lo: Unmanaging interface.
Jul 09 19:50:05 example systemd-networkd[523]: lo: State changed: initialized -> unmanaged
Jul 09 19:50:05 example systemd-networkd[523]: Sent message type=signal sender=n/a destination=n/a path=/org/freedesktop/network1/link/_31 interface=org.freedesktop.DBus.Properties member=PropertiesChanged cookie=4 reply_cookie=0 signature=sa{sv}as error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=signal sender=org.freedesktop.DBus.Local destination=n/a path=/org/freedesktop/DBus/Local interface=org.freedesktop.DBus.Local member=Connected cookie=4294967295 reply_cookie=0 signature=n/a error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=signal sender=org.freedesktop.DBus destination=:1.17 path=/org/freedesktop/DBus interface=org.freedesktop.DBus member=NameAcquired cookie=2 reply_cookie=0 signature=s error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=signal sender=org.freedesktop.DBus destination=:1.17 path=/org/freedesktop/DBus interface=org.freedesktop.DBus member=NameAcquired cookie=3 reply_cookie=0 signature=s error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=method_return sender=org.freedesktop.DBus destination=:1.17 path=n/a interface=n/a member=n/a cookie=4 reply_cookie=2 signature=u error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Successfully acquired requested service name.
Jul 09 19:50:05 example systemd-networkd[523]: Got message type=method_return sender=org.freedesktop.DBus destination=:1.17 path=n/a interface=n/a member=n/a cookie=5 reply_cookie=3 signature=n/a error-name=n/a error-message=n/a
Jul 09 19:50:05 example systemd-networkd[523]: Match type='signal',sender='org.freedesktop.login1',path='/org/freedesktop/login1',interface='org.freedesktop.login1.Manager',member='PrepareForSleep' successfully installed.

PS:
You've been doing good work Stéphane! Much love :heart:

What container image are you using for this?
Can you check if udevd is running inside the container?


Use more inclusive verbiage

This is made in reference to point 1 of the code manifesto, really, and updates documentation accordingly.
This might sound like nitpicking, but I think we'd probably be better off avoiding these references to mental health; thoughts?

The context is not regarding a person. In this case sane would mean something more like reasonable/sensible and has nothing to do with mental health.

I totally understand what the word means in this context, and my point is just that there are better ways of phrasing it that don't have any potential to be exclusionary :) This same reasoning is why we avoid words like "retarded" and "dumb" - the context might not have anything to do with humans, but they're needless slurs, and there are plenty of other ways to say the same thing.

The wording we use is verbatim from the code manifesto; if you have suggestions on wording, please make them against its own repository, and we will pull them in if merged.

This PR is against our text not the text of the code manifesto.

On 3 May 2016, at 00:17, weierophinney<EMAIL_ADDRESS>wrote:
The wording we use is verbatim from the code manifesto; if you have suggestions on wording, please make them against its own repository, and we will pull them in if merged.

This is what comes of me reading PRs on my phone... Re-opening, and will re-evaluate. Thanks for the PR, @i-am-tom !

I back-ported the changes to the documentation source files, which are under the doc/book/ tree of the master and develop branches, and written in markdown. Documentation rebuilds after pushes to master, so you'll see your change show up shortly.
Thanks for the patch, @i-am-tom !


[Spring Security Support] Make sure all features are included in reference doc. @chenrujun

Closing in favor of https://github.com/microsoft/spring-cloud-azure/pull/880


Add password prompt when keystore-password option is not supplied. This closes #44

This will resolve #44


NativeScript samples site is down

When I follow the link to http://docs.nativescript.org/angular/code-samples/overview.html it says 404,

I think they have changed up paths. I was going to put in an issue, too.
Try: https://market.nativescript.org/?tab=samples&framework=angular&category=all_samples

Hi all,
The broken links in the ReadMe file are already fixed. The https://docs.nativescript.org/angular/ui/components is the link, which should replace the overview.


AsterNet ManagerConnection

I can succesfully establish connection with Astersik by using ManagerConnection but in the Asterisk server I can view the peers list by using sip show peers CLI command as
Name/username             Host                                    Dyn Forcerport Comedia    ACL Port     Status      Description
1006                      (Unspecified)                            D  Yes        Yes         A  0        UNKNOWN
1007                      (Unspecified)                            D  Yes        Yes         A  0        UNKNOWN
2 sip peers [Monitored: 0 online, 2 offline Unmonitored: 0 online, 0 offline]
Why the Host name is still Showing as unspecified?

Sounds more like a question for the Asterisk forums then AsterNET, this issue tracker is for issues specific to AsterNET, and by the sounds of it, the question you're asking relates to informaiton being output by Asterisk. Correct?
If so, please see: http://forums.asterisk.org/

I hopefully expecting it is not a problem of AsterNet.


Write function to interpret additional customisations in SAG plots

this is a major development as it affects both the labels of the plots (which might be incorrect at the moment) and the data visualised (for example shaded bars in the recruitment plot).
@colinpmillar is working un the updates of the SAG package and once that is done we will integrate Colin's work with the ices theme function I worked on.

Most of the SAG plot settings have been implemented.
Issues that still need fixing:

[ ] Add Industrial bycatches (IBC) to the landings/discards plot using the new web service developed by Laura (ex https://sag.ices.dk/SAG_API/api/SummaryTable?assessmentKey=14386)
[ ] For stock categories 3 and 5, there is a problem with the SSB plot. When plotting a variable that is not SSB (like relative biomass etcc) the legend still reports erroneously "SSB" (in SAG,  these stocks have the legend empty)


Documentation

In the section "Build the documentation" in doc_conf/index.rst, it missing the mention of some packages.
I list the packages and my first impression of their usage:
"memory_profiler>=0.61.0",            // for showing the memory usage of example
"sphinx-bootstrap-theme>=0.8.1", // for integrating the css
"sphinxcontrib-bibtex>=2.6.2",        // for managing some citations
"numpydoc>=1.7.0",                          // for managing some citations and more
"sphinx-gallery>=0.16.0",                 // for create the documentation from example
"matplotlib>=3.9.0",                          // for examples
"nilearn>=0.10.4",                              // for example: plot_fmri_data_example.py
"mne>=1.7.1",                                     // for example: plot_meg_data_example.py (not used)
"pillow>=10.4.0",                                // for example: plot_meg_data_example.py (not used)
"PyQt5>=5.15.10",                             // for example: plot_meg_data_example.py (not used)
"pyvista>=0.44.0",                              // for example: plot_meg_data_example.py (not used)
"pyvistaqt>=0.11.1",                          // for example: plofor the package distutils removes in python 3.12)

setuptools (for the distutils package removed in python 3.12)

Some needs perhaps to be removed depending of the choice of example and the way to cite paper (#38)

Moreover, the building documentation contains some warning which could be fix (see the attach files).
In particular the warning for the examples from docutils and the warning of numpydocs for the python file documentation.

Additionally, the conf.py file contains the commented lines which can be removed and/or updates.
Some of the link in this file require to be updates:
"matplotlib": ("https://matplotlib.org/stable/", None),
"numba": ("https://numba.readthedocs.io/en/stable/", None),

I think that the actual documentation (hidimstat/doc) shouldn't be committed in git because some files contains date of creation which create non necessary track of modifications.

OK had a look
so you are using github pages to deploy: which means that your doc MUST be committed somewhere to be deployed
but committing it on the default branch of the package repo is not ideal
what I would suggest is to only commit the newly generated files on a branch called gh-pages and deploy from this branch
for nilearn we actually deploy the main branch from another repo that only contains the doc: https://github.com/nilearn/nilearn.github.io
you can tweak which branch to deploy from in: Settings --> Pages

OR you can decide to host the doc on read the docs so you don't have to worry about all this
read the docs also allows you to easily preview the doc for each PR

you have some examples but the build time does not look like too crazy to host on read the docs


Change to TZIP-024

[ ] The current implementation assumes TZIP-024 means tzprofile. Depending on the result of the conversation in #58 it will need to be tweaked.
[ ] Publish the new version of the SDK

Let’s see if we can hold off on this...there have been some deployments with tzip-23

The metadata URL stays the same so old contracts will continue working

I'm running into several issues testing this, one is that the created credentials get downloaded as undefined rather than the JSON file. Secondly, don't see existing profiles.
I'm going to do some more testing to figure out what the exact parameters of the problem are.


"Waiting to take filesystem lock" takes a long time

Very often vcpkg gets stuck trying to acquire the filesystem lock. Takes minutes at a time, maybe even forever sometimes, but I didn't have patience to wait long enough in some cases.
Environment

OS: [macOS]
IDE: [Clion]

To Reproduce
Steps to reproduce the behavior:

Install vcpkg to /Users/username/.vcpkg
Add vcpkg toolchain file as project's toolchain file
Use manifest mode
Configure the project

Expected behavior
Lock is acquired quickly
Failure logs
-- Running vcpkg install
waiting to take filesystem lock on /Users/username/.vcpkg/.vcpkg-root...

Additional context
I can see two vcpkg processes in the Activity Monitor, launched each time I configure the project (after killing the processes, restarting the computer etc). Why exactly two are launched I do not know and also I don't know if that causes the problem, but it wouldn't be surprising. Overall, the wait time appears to be random. Sometimes it's not long, sometimes it is. Today (at the time of posting the issue) it's been especially bad.

A vcpkg instance can only be used by one process at a time. So the other processes have to wait and while they are waiting you see waiting to take filesystem lock on /Users/username/.vcpkg/.vcpkg-root.... If you use vcpkg as a submodule you don't have this problem.
Or you determine why multiple vcpkg processes are started at the same time. If you open the information of a process in activity manager you see the parent process.

So the issue was a bunch of try_compile calls that lead to numerous toolchain file inclusions. We have a custom toolchain file that includes the vcpkg toolchain. In any case, multiple inclusion like that lead to multiple runs and instantiations of vcpkg. To avoid this I check if a vcpkg.json file exists in the current cmake dir, if not, then return early.


v2.0.0

STABLE 2.0.0 Road Map

[x] Queue
[ ] Saving / Like videos

E2 Specific

[ ] Change log
[x] Updated name to show the current playing song
[ ] Media Controls??????

Queue added and updating name added in v1.0.0-stable


add -server-debug-listen flag to enable pprof

It seems to add a bit of confusion with the existing -debug flag. What about either of them:

simply enable pprof is -debug flag is set
name it-server-pprof-listen

I tend to prefer 1. because it seems to achieve the goal without any additional config?
These are just my quick thoughts. Do let me know if I am missing any details.

You are right, I was not sure  which way to go.
I am thinking that the if possibly future HTTP enabled debug tools could be enabled using the same -server-debug-listen. It would already be very bad to enable this towards the public internet so adding more powerful (dangerous) debug tools to it isn't a big issue.
-debug does to be targeted at local development because it changes things like log formatting while pprof is valuable on its own in production/staging to measure how imagor behaves under production load.

Maybe debug isn't a good name for it at all. I would personally prefer to put stuff like metrics exporters on that HTTP listener rather than the default one.

I'm closing this for now. Not sure how the most commonly useful way to go about it would be.  It is probably useful for some people to have this built in but I have done my initial profiling already with a patched version of imagor and don't expect to need it again soon.


Feature Request: wildcards in filters

Currently, I have 100s of tables in my database, all under different schemas.
I want to anonymize around 5 - 10 of my tables. I am able to achieve this using the following config
.....
filter:
  data:
    only:
      - "default$default.Profile"
      ...

Potentially, this creates another issue as it copies over the other schema, which I don't want to copy.
When I try to use the following config:
.....
filter:
  schema:
    only:
      - "default$default.Profile"
      ...

Only the tables selected get copy but not their dependencies, for e.g. ENUMs used in those tables.
So I would like to request for a feature in which filter accepts wildcard * for anything under a schema.
something like:
filter:
  schema:
    only:
      - "default$default.*"
    except:
      - "public.*"

Thank you in advance.

Also I tried using the pgdump cli options, --exclude-schema=pattern and --schema=pattern from docs, to achieve this. But I think, datanymizer cli is overriding those values or not using them.

Hello!
We will try to implement something that solves this issue.


Update to Bevy 0.9

Also, formatted and updated examples to be more consistent

Wow, so fast, thank you!


v3.4.10

+1
On Sat, Mar 31, 2018 at 7:37 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/ManiacalLabs/BiblioPixel/pull/717
Commit Summary

v3.4.10

File Changes

M CHANGELIST.md
https://github.com/ManiacalLabs/BiblioPixel/pull/717/files#diff-0
(6)
M bibliopixel/VERSION
https://github.com/ManiacalLabs/BiblioPixel/pull/717/files#diff-1
(2)

Patch Links:

https://github.com/ManiacalLabs/BiblioPixel/pull/717.patch
https://github.com/ManiacalLabs/BiblioPixel/pull/717.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/717, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6jXXf6YCjHtvqlOGM9vaB7crsBglks5tj2qJgaJpZM4TCbwo
.


Add trailer 3 : Percy Jackson and the Olympians

@mitchiemt11 Please review this PR when you have a chance."

resolve conflicts, I will merge asap.

conflicts resolved


Preparation for GIMP 2.10

Motivation for this change
Since a string freeze occurred recently, 2.10 will be released soon. I have packaged the unstable version in https://github.com/NixOS/nixpkgs/compare/master...jtojnar:gimp-2.10 but these changes make sense on their own.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval
(sorry for the noise, master was broken by a merge)


[Broken] Youtube download not working

Checklist

[ x] I'm reporting a broken site support
[ x] I've verified that I'm running youtube-dlc version 2020.10.26
[ x] I've checked that all provided URLs are alive and playable in a browser
[ x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x] I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=HRHVJPFKCqE']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dlc version 2020.10.26
[debug] Python version 2.7.18 (CPython) - Linux-5.4.0-52-generic-x86_64-with-Ubuntu-20.04-focal
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4
[debug] Proxy map: {}
[youtube] HRHVJPFKCqE: Downloading webpage
[youtube] HRHVJPFKCqE: Downloading embed webpage
ERROR: Unable to extract JS player URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dlc/youtube_dlc/extractor/youtube.py", line 1966, in _real_extract
    yt_initial_data['contents']['twoColumnWatchNextResults']['conversationBar']['liveChatRenderer']['continuations'][0]['reloadContinuationData']['continuation']
KeyError: u'conversationBar'
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dlc/youtube_dlc/YoutubeDL.py", line 830, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dlc/youtube_dlc/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dlc/youtube_dlc/extractor/youtube.py", line 2066, in _real_extract
    ASSETS_RE, embed_webpage, 'JS player URL')
  File "/usr/local/bin/youtube-dlc/youtube_dlc/extractor/common.py", line 1010, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract JS player URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.

Description

Im simply trying to download a youtube video. Every video that I try including the one mentioned above returns with the stated error. Some other options work like --write-sub or --list-formats but download of the video fails. I had youtube-dl previously installed. Is there some cache I need to clear or is the issue something else? Thank you very much for your help!

It was fixed in the #35


added maven support

no problem with grandle but i have done the work using maven. if you want to merge it ok do otherwise i will continue with my fork code ;-)

Well, you could but I do not see a reason to fork because of the build system.
If you want me to eventually take into account a switch to maven you need to provide something that replace what it is included as today, like:

OSGi support
Publish the artifacts to sonatype snapshot and release to maven central
Continuous build with travis-ci

OK @lburgazzoli no problem :-)


Style base map layer

Mapbox GL ftw?

While we're not on Mapbox GL yet, we've switched to an updated Mapbox Light version plus added other base map layers with a switcher. Reopen if we want to revisit the default base map style.

What's the deal with the difference? The plain Mapbox JS version is missing a lot of the API methods from the Mapbox GL version, which seems much more feature-rich and maintained...

Yeah I concur but I think we had started down the path of switching to Mapbox GL but scrapped it. I can't remember the reason nor find a ticket documenting the change cc @danielfdsilva?

Oh right, makes sense. Well anyway I'd certainly vote for the upgrade, but appreciate it's a biggy, so should be put on the long term lists.

To reference, there is a mapbox-gl branch: https://github.com/hotosm/oam-browser/tree/feature/mapbox-gl

Changing to mapbox gl is definitely no easy task.
The main reason why we stopped was that mapbox gl doesn't support div markers, which we use to show the count of images per square, and we didn't find any suitable alternative back then.
I think creating the grid was also problematic, but I'm not sure about this one

Ah, that's a good reason. Well it's good to have this on record. Is this closed issue good enough for the records then? Maybe it should stay open, but just as long-term, non-urgent thing?

Perhaps a separate new ticket since the gl refactor goes beyond just a base map style?

Or change the title here? The comments here will be useful for the future dev tackling this.


Adding travis and semantic-release

Travis is a CI that could automate processes when push a commit. Semantic-release allow you to generate change-logs and versioning automatically by formatted commits.
https://www.conventionalcommits.org/en/v1.0.0-beta.4/
I think this could be very helpful.

Hey Rogger, thanks for the pull request!!! I really love this change but we're already using circleci. It seems redundant to use multiple CI tools for a project. It would be amazing if we can port this to circleci or move everything to GitHub (Github Actions) and don't use any 3rd party dependencies. Thoughts?

Hey @muratsu, I search for circleci:
https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/circleci-workflows.md
I was working with semantic-release in some of my project and travis, but I guess this commit should be work on circleci.

We definitely want this but it's a bit involved. Do you want to merge this together over the weekend or sometime next week?
Feel free to book some time on my calendar:
https://calendly.com/muratsutunc


Use only one Vulkan pipeline cache

Share only one pipeline cache between all pipelines. According to best practices.

Vulkan::pipelineCache


ODIS Query

Description
Check that the respective mandatory properties are present for each signer type.
Tested
Unit tests

Closing in favor of changes added in https://github.com/celo-org/celo-monorepo/commit/67d44cf116cdcb8adf141abcae380515ba774348


[GSSOC'23] Number of Fingers Shown using OpenCV

Aim
To create a script that shows number of fingers shown
Details
It use OpenCV library to detect number of fingers shown by user

Go Ahead @sohil1234


Add SkipCaller(int) to support helper function around errtrace

Absolutely not a priority ;)
Quoting: "It's important that the errtrace.Wrap function is called inside the same function that's actually returning the error. A helper function will not suffice."
It will be nice to be able to support helper functions, and mutating the idea from zap.Logger (AddSkipCaller) it should be possible.

Hey, thanks for the issue!
This is definitely possible on the safe path, but much more difficult on the unsafe path.
If there's need for this functionality, we could probably change the unsafe path to fall back to the slow path if skip > 0.

Well, it will be a nice to have, but I don't think it is a must to have functionality.
Anyway thanks for taking it in consideration.
Checking the performance comparison, with the safe approach errtrace will still be comparable with FmtErrorf... so much slower but still (I think) a more than acceptable compromise... and anyway there are no free lunch :)

Thanks! I think this is a valid feature request, and I do think we should do it at some point.
It allows folks to write helpers for error building use cases that we haven't accounted for.
(e.g., if we didn't include errtrace.New, someone couldn't write their own errors.New wrapper that has the correct positioning.)
Out of curiosity, did you have a specific case where you were hoping to use this ability?

I'm just adopting errtrace, so in total honesty I don't have any real use case yet, everything is still in a WIP.
I'll most probably work on something around the lines of adding the trace plus a string/annotation/extra value to simplify the life of other users
for example (or something something around this  lines):
return errtracePlus.wrap(err, <format>, args ...any)
or the capability to join 2 or more errors and add the trace.
Note: I'm not join to call it errtracePlus ;)
The overall point is to make the life as easy as possible to my collegues to lower the entry bar for adoption.

@theFong Thanks for dropping that in. I think more data points on this issue helps.
I'm curious about the wrappers: if you're implementing your own wrappers, are you not auto-instrumenting your code? While that's not absolutely required for errtrace, we were under the impression that that was highly convenient.

I did see the automatic instrumentation feature(should try it out). But I don't like the idea of having to review the diff across our entire codebase haha. Maybe I misunderstood how this feature works.
We already have a helper wrap function implemented. Our helper api accepts a string(s) and want to keep that functionality by appending it to the error string.
func WrapAndTrace(err error, messages ...string) error

Wanted to follow up here. We've ended up adopting errtrace with manual instrumentation and have simply refactored out codebase to use Errorf when adding a message to the error.


Line Feed and new line characters in response

Hi John,
Using your collection I am trying to pull some messages from RabbitMQ queue via Postman and noticed that messages have line feed and new line characters like below. Is there any way to fix the response to make it more readable in JSON format :-
{\n "StatusId" : "Closed"\n },\n "UpdatedTimestamp" : "2018-04-03T16:16:04.644",\n "CreatedBy" : "LBilley@everythingbutwater.com",\n "InvoiceLine" : [ {\n "ShipToAddress" : null,\n "InvoiceLineSubTotal" : -84.0,\n "ParentLineCreatedTimestamp" : "2018-03-20T16:00:31.81",\n "CreatedTimestamp" : "2018-04-03T16:15:57.123",\n "IsTaxIncluded" : false,\n "OrderedItemId" : "00000101183770",\n "InvoiceLineId" : "15227721571234911195",\n "ShipFromLocationId" : null,\n "InvoiceLineTaxDetail" : [ {\n "RecordedTaxAmount" : 0.0,\n
Is there a way to fix it in postman ?

Hey Kumar4sun, that is a good question. I will take a look and get back to you. Thanks for pointing this out!

@johnlonganecker you collection is awesome. I wish i can get a cleaner output from JSON.


Be able to provide an own feed for offline usage

Description of the new feature/enhancement

Allow the usage of own feed servers. That will help companies that are disconnected from the internet or has a slow internet connection. The principle should be like the Powershell repositories, that are based on NuGet. So you can easily provide a lokal copy of the Public feed or setup your own for your company applications.
Proposed technical implementation details (optional)

To implement this feature the current concept of the yaml files won't work anymore. There must be a more complex solution. For example Visualstudio, is currently only provided as online installer. To provide an offline feed you must download the visual studio installer to an lokal server and create your own yaml with the right link.
So I think the paths to the installers must be realtiv in the yaml for this feature. Maybe somebody has an better idea.
P. S. By the way this tool is super cool! 💪👌

I would like to be able to mirror a feed in something like Nexus so the feed can be available inside my company so employees can install tools without needing internet access.

@paule96 you just described exactly what Chocolatey supports, does, and well, is. I'm not sure if winget will lean in this direction since it is covered so well by Chocolatey but you never know.

Related issues:

#160
#203
#213
#226

@ferventcoder yes but I think this is a base requirement to get this used in enterprise environments. If you can't provide this, I think winget won't be popular, because it has no advantages that for example chocolatey or SCCM don't have. They both have more or less feeds. WinGet doesn't. It has only metadata.
This makes it hard to use in big environments where more then 10 people use the same tools. Maybe we can just add a NuGet feed features or something like this. or merge the two projects chocolatey and winget to one big thing. They are very similar. Just think about. Also chocolatey has a very big feed of a wide range of tools.

@paule96 exactly. I'm not sure this is targeted for enterprise environments. At least that's my general understanding and why there are collaborations in place with other package managers. Use what makes sense in the environment you are in.

Also while other package managers may provide the feature already, getting chocolatey approved for use in an enterprise closed classified network is a no go. Winglet is part of windows so it’s already part of approved software. This is the reasoning behind my request of this feature. Right now Everyone has to write custom powershell scripts for WDM or SCCM to perform this and it’s a pita.

Also while other package managers may provide the feature already, getting chocolatey approved for use in an enterprise closed classified network is a no go.

Not in my experience. I can't share due to NDAs but I can tell you b/c Chocolatey works fully offline and has zero call home, it is being used in such areas.

It could be a conflation of Chocolatey the tool and framework and Chocolatey.org packages (aka the community repository). The latter would never be approved in organizations such as that, but that's okay b/c that is not Chocolatey itself.

Well all depends on varying approving environments, but its not across the board or guaranteed like something built into windows. Also to be able to do that last time I checked required the licensed model.  So that's increased cost as well if still true.

Nothing about offline use for choco requires a licensed model - we try to be super clear on that. But either our docs lean the wrong way or some folks misread. Any ideas on how to clarify that for folks?

@ferventcoder Reviewing https://chocolatey.org/compare there are a few items that would prevent Choco use in a fully closed off environment that are not support in open source. But yes it does state internal private feeds are supported under Open Source.

Package Internalizer - Convert existing packages for complete offline / reliable use (removes need for internet access from existing packages)!

So then if you are stating that Choco can be used fully offline, is your proposed model that a developer of admin requires the use of the pro license to create the packages for offline use but on user level desktops and servers that simply need the deployment capability they can run the open source using packages build from the pro model? That would be one thing that would have made it feasible to use and request for say a large govt. UAV program with security approval. I can get 10-15 licenses approved for developers and convince the customer to purchase licenses for their developers if they take over support. But I can't convince them that 40 plus hosts need a license and continuous support.
So if that use case is true, I recommend adding use cases like that on the compare editions page, so architects and leads can quickly see cost impacts to make decisions. That would be helpful for some of the other features if included with a license level to clearly state this is for developing packages easier but no license is required to utilize a package build with those features.

@binarylandscapes
You are close and I think I see your confusion here. Target in on the word "existing" in that statement - Internalize existing packages. You can create offline packages all day long with choco new and you can internalize manually.
I think adding a blurb about manual internalization above that might be helpful, pointing to the article at https://chocolatey.org/docs/how-to-recompile-packages#how-to-internalizerecompile-an-existing-package-manually. I know that at the top we have Create packages as listed from open source on, but I sense there is confusion about what that means. I've just ensured that was updated - https://chocolatey.org/compare

@paule96 we've implemented a reference implementation for the REST API. You could stand up your own private repository and host packages "offline" in your own environment. I'm going to close this issue as I believe this is what you requested. If that's not the case, feel free to reopen so we can discuss the scenario further.
Thank you for contributing!


:wrench: Add external reg enable to slices

Hi,
this PR is a proposal to add an external register enable, overriding the local register enables generated from the internal valid and ready handshake signals, to the slice modules (fpnew_opgroup_[multi]fmt_slice) and the underlying opgroup modules.
The motivation for an external register enable is a better separation between control flow and data flow. Concretely, an external register enable would allow for the following:

When a CVFPU slice module is instantiated as part of an ALU pipeline that also hosts another unit, such as an integer ALU, the external register enable can be used to avoid splitting the pipeline into an integer and a floating-point part and then merging them back together, but instead allows to control the individual pipeline stages of the CVFPU opgroups as well as the integer pipeline stages with a single main pipeline. This also solves the problem of re-ordering the output of individual pipeline branches in case the pipeline requires all operations to remain in order.
An external register enable allows to run the control logic ahead of the dataflow, with the register enable signals passing through one or several FF buffers, which may help timing closure by separating the often critical ready signal path from the register enables of the FFs in the dataflow path.

The changes are intended to be as minimal as possible, with an additional reg_ena_i port added to the slice modules and each opgroup module, which supplies the external register enable signals. This input port can be tied to '0 if the external register enable shall not be used. Otherwise, the external register enable signals can be provided via this port and the in_valid_i be tied to '0 to disable the local register enables generated by the internal handshake signals.
The width of this reg_ena_i port corresponds to the number of pipeline stages - however, an additional parameter ExtRegEnaWidth is required to catch the case where the number of stages is 0. Finally, the slice modules also gained a parameter ExtRegEna which must be set to 1'b1 to avoid Nan-boxing all outputs in the absence of internal valid signals.
Note that the external register enables are only available when directly instantiating the fpnew_opgroup_[multi]fmt_slice modules or an individual opgroup module. The fpnew_opgroup_block disables the external register enables by tying reg_ena_i to '0 and leaving the ExtRegEna at its default value of 1'b0. We have used the formality tool to verify that instantiating fpnew_top with these changes is still formally equivalent (using Synopsys formality) to the same instantiation without these changes.

@stmach or @lucabertaccini can either one of you guys take a look? Imho that change shouldn't be too controversial because the interface outside doesn't change and the change is LEC with the original FPU. What do you think?

Hi @michael-platzer @zarubaf. Thanks for contributing! The PR looks good tom me as well

@stmach @lucabertaccini Thanks for reviewing! Is there anything else you need from my side to merge this?


Rebuild action cache bug

add-on to #217. The build record is not being updated when the user clicks "rebuild" via the UI. This results in the view cache being stale for a while until the build attempt gets picked up by a worker.

LGTM


Extend the File Type

Hi it is posible that you can extented the File Types.
So we can also search in Powershell Files (.ps1 and .psm)
Your Search is really grate because it search for Fiel Name and File Content.
Best regards
Ralf

Thanks.
Do you want to search in all powershell content (variable names, etc) or
only in comments?
On Wed, 30 Aug 2023, 16:15 rako999-sys, @.***> wrote:

Hi it is posible that you can extented the File Types.
So we can also search in Powershell Files (.ps1 and .psm)
Your Search is really grate because it search for Fiel Name and File
Content.
Best regards
Ralf
—
Reply to this email directly, view it on GitHub
https://github.com/AlexandriteSoftware/markdown-search/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7MKWOWZZLYAOMPIQHZLLXX5KILANCNFSM6AAAAAA4EV67FI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

In all powershell content will be nice
Thanks

After careful consideration and looking through alternatives I've decided that right now implementing search over other types of files in this extension does not going well along with its original purpose: full text fuzzy search in markdown-formatted knowledge bases.
There are other extensions that simplify working with PowerShell scripts, e.g. https://marketplace.visualstudio.com/search?term=powershell&target=VSCode&category=All categories&sortBy=Relevance

Hi,
it's ok thank you for your efforts.
Best regards
Ralf


Unit Tests Passed for Recent Changes

Hello,
I've made some modifications to the code and ensured that all unit tests are passing successfully. Here are the key changes I made:

Added PIDController::compute function and other modifications
Updated github workflow
Updated readme (with my Codecov credentials)

I've run the unit tests on my fork, and all tests have passed. I believe these changes will enhance the functionality/performance of the project. Please review the changes and let me know if any further modifications are required.
Thank you for considering my contributions.
Best regards,
Tarun Trilokesh

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

Please remove the changes in the Readme file.

As requested the Readme file has been updated.


[bug] invisible underscore in integrated-terminal

Couldn't see underscore in integrated-terminal. Other symbols are visible, but underscore is just empty space
f.e.: npm run migrations_down
visible like npm run migrations down

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T12:44:48.751Z)
OS Version: Linux x64 4.4.0-98-generic
Ubuntu 16.04

Duplicate of #35901

Same problem here.  But if you zoom out (Ctrl- -) or in (Ctrl +) the underscore becomes visible!

Got the same issue. Ubuntu-Mate. Appeared first on VSCode 1.18.0.  Only one specific size, only on command-line ($> cd _posts_ for example), not in listings (ls) for some reason.
Quick work around: Copy editor.fontFamily to your user settings, remove first Family, thus remaining is:
"editor.fontFamily": "'monospace', monospace, 'Droid Sans Fallback'"

Possibly came through this PR?

Add "window.zoomLevel": -0.001 for workaround

It's worth noting, it's far more likely to happen on comannd line entry than output for some reason.

(So, perhaps something is not about character rendering itself but something related to line-height?  Lineheights chosen too small sometimes clip typo (all the way from word to css...) and the underscore would be the first victim here...)

Same issue here. I used @suonto workaround

#35901


Update akmadian author page

Description
Since I wrote my original bio, I've turned one year older, and my taste in tea changed :) (among other things) This PR updates my author page to reflect that.
Other information

Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I added tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

No more rooribos? 😛

Nope, still going on the rooibos, have just been more into black and silver needle lately :) Also tried some pu 'erh and oolong recently! @kgodey


fix: The organisation setting page is broken locally

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes

Added the plans key in the project_local file

How did you test this code?

Locally go to the Organisation setting page in the main branch (See the error)
Locally go to the Organisation setting page in this branch (No error)

These don't look right to me based on our conversation @kyle-ssg ?

@matthewelwell , I'm sorry, maybe I'm missing something, but this is not related to the announcement flag. It's related to changes in the Payment file, for example:
data-cb-plan-id={Project.plans.startup.annual}


Commit - Core Service - 24-09-2024 - POM file jar generation changes …

…and gihub actions branch change

gihub actions branch change


make NotebookContentProvider parameter consistent

This PR fixes an issue found while testing: https://github.com/microsoft/vscode/issues/103883

We are getting rid of notebook content provider api in favor of notebook serializer.


Camera2Session: Error: Camera device could not be opened because there are too many other open camera devices.

I am trying to send video feed of the android tablet camera (galaxy tab s6) in which arfoundation is running. In another scene where there is no rtc operation, camera feed is displayed perfectly on the ui. However, when rtc is enabled and communication starts with the peer, then the camera image is complete black on both peers' devices.
I tried to debug the problem using android studio and noticed the below error:
"29959-31814/? E/org.webrtc.Logging: Camera2Session: Error: Camera device could not be opened because there are too many other open camera devices."
As far as I understand, the library is having difficulty sharing camera with arcore, but this is just an assumption.
Is there any way to solve this problem? Thanks in advance.

Have You Ever try to get permission first ?
I had this problem for sound and i got permission then it fixed ☻

I acquire all permissions at the start. And as mentioned before, camera feed is actually rendered when rtc is not enabled.

You should force it with java classes. i dont know exactly for camera but i set this for microphone issue.

By the way , do you know anything about multiple connections ? for example three or ten person in a room

I haven't worked in multiple connections use case. But there is an asset other than this called webrtc video chat in assetstore. I guess it supports multi user but has no uwp support.
How did you force getting permissions with java classes inside unity?

`try
{
AndroidJavaClass unityPlayer = new AndroidJavaClass("com.unity3d.player.UnityPlayer");
AndroidJavaObject activity = unityPlayer.GetStatic("currentActivity");
AndroidJavaObject audioManager = activity.Call("getSystemService", "audio");
// bool isSpeakers = audioManager.Call("isSpeakerphoneOn");
audioManager.Call("setSpeakerphoneOn", speaker);
bool res = audioManager.Call("isSpeakerphoneOn");
        Debug.Log("Speakers are now set to: " + res);
    }
    catch (Exception ex)
    {
        Debug.Log(ex.ToString());
    }`

Like This

    `Debug.Log("Speakers are now set to: " + res);

 } catch (Exception ex) { Debug.Log(ex.ToString()); }`

private static void RouteToSpeaker(bool speaker)
    {
#if UNITY_ANDROID
        try
        {
            AndroidJavaClass unityPlayer = new AndroidJavaClass("com.unity3d.player.UnityPlayer");
            AndroidJavaObject activity = unityPlayer.GetStatic<AndroidJavaObject>("currentActivity");
            AndroidJavaObject audioManager = activity.Call<AndroidJavaObject>("getSystemService", "audio");
            // bool isSpeakers = audioManager.Call<Boolean>("isSpeakerphoneOn");
            audioManager.Call("setSpeakerphoneOn", speaker);
            bool res = audioManager.Call<Boolean>("isSpeakerphoneOn");

            Debug.Log("Speakers are now set to: " + res);
        }
        catch (Exception ex)
        {
            Debug.Log(ex.ToString());
        }
#endif
    }

Like This


gltfio: Use JobSystem to compute tangents and AABB's.

On a Pixel 3a, this reduces load time for Bistro from ~6.5 seconds to ~2.5 seconds, where "load
time" is the time between app launch and the first mesh being rendered.
After these optimizations, we still see some low CPU utilization during the load, which appears
to be due to AssetManager usage on the Java side. It might be possible to optimize this too.
Note that AABB computation is optional since glTF has built-in min/max values, but we currently
enable it by default for robustness. In a future PR I would like to change this from opt-out to
opt-in.

(using glb instead of gltf would make this faster too)


refactor: add interfaces

Motivation
Minor, but this should make it easier to build on top of the various registries. Allows for it to be an easy reference for the interfaces and can be pulled into other projects to use, rather than needing to redefine it per project.
Change Summary
Simply adding interfaces. Main change is around where structs are located.
There are two options, not sure which one you prefer:

Structs within the interface
Structs in a *Structs.sol file and imported into the interface and implementation.

Merge Checklist

[x] The PR title adheres to the conventional commits standard
[x] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
[x] The PR's changes adhere to all the requirements in the contribution guidelines
[x] All commits have been signed

PR-Codex overview
This PR focuses on introducing interface contracts and updating function signatures in several contracts.
Detailed summary

DeployL2.s.sol:

Import IBundler interface in addition to Bundler contract.

StorageRegistry.sol:

Implement IStorageRegistry interface in addition to existing contracts.

IdRegistry.sol:

Implement IIdRegistry interface in addition to existing contracts.

DeployL2.t.sol:

Update signers variable to use IBundler.SignerData struct instead of Bundler.SignerData.
Update function call from bundler.trustedRegister to bundler.trustedRegister.

KeyRegistry/KeyRegistry.integration.t.sol:

Import IKeyRegistry interface in addition to KeyRegistry contract.

Bundler.sol:

Import IBundler interface in addition to Bundler contract.

interfaces/IBundler.sol:

Introduce IBundler interface with new structs and functions.

Bundler/Bundler.gas.t.sol:

Update signers variable to use IBundler.SignerData struct instead of Bundler.SignerData.
Update function call from bundler.trustedRegister to bundler.trustedRegister.

KeyRegistry.sol:

Import IKeyRegistry interface in addition to KeyRegistry contract.

The following files were skipped due to too many changes: src/KeyRegistry.sol, test/KeyRegistry/KeyRegistry.t.sol, src/interfaces/IIdRegistry.sol, src/interfaces/IStorageRegistry.sol, src/interfaces/IKeyRegistry.sol, test/Bundler/Bundler.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Thanks for this @Slokh. We have some CI config issues with fork PRs into the main, so I'm going to merge this to an in-repo branch and reopen this against main.


⚠ Bofrost.be has degraded performance

In 80ff869, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1600 ms

Resolved: Bofrost.be performance has improved in 5d942bd after 20 minutes.


Street names are cut off on higher zoom levels

I was able to successfully build a planet.mbtiles on my machine. When rendering the tiles with tileserver-gl I can see that on higher zoom levels the tiles borders are cutting of the highway numbers. Or at least neigbhoring tiles are not matching the cut off.
Is this to be expected due slicing that is being done for compartmentalizing the mbtile generation?

On second thought I think this might actually be a problem with tileserver-gl when serving png's instead of vector files.
I will do some research if this might have to do something with the tileserver-gl version that I'm using.

Thanks for letting me.
I have checked on a couple of mbtiles files which I have generated using the programme and cannot replicate your issue with labels being cut off. I suspect (as you have alluded to above) that it may be a tileserver-gl style issue.
Please see below some screenshots which I have gathered using tileserver-gl for serving and MapLibre (similar to MapBox) for rendering the vector tiles on the front end. Images show various levels of increasing zoom.

Are you able to paste here a copy of the style.json you are using? I can put this against my own tiles and see if that replicates the issue.

In reference to your point re the slicing causing the issue - I don't think this is the case since any duplicate roads or areas are overwritten (rather than written next to) the data already there (thus leaving only one copy).
The last image in the post above is taken directly at a split line which goes straight through the middle of jungingen.
Whilst it looks okay to me, I am not local to that area and cannot confirm that it looks totally accurate - if you are more knowledgeable of the area and are able to let me know if it looks okay or otherwise - I would very much appreciate your input! :D


Update GOV.UK elements to use Express 4

This was updated for the prototype kit in October 2015.
This one is to be merged first. cc. @joelanman, @robinwhittleton.

odd - this hasn't got the update to express in package.json:
https://github.com/joelanman/govuk_elements/pull/3/commits/bc642b74ebce0672b9bfde667c18432f86614662

This needed to be included, my mistake, i'll open in a a new branch.


Fail to run test in Pytest.

Describe the bug

Python from Microsoft Store.
Steps to Reproduce

Create Python Application Project.
Add test_1.py file with code

def test_passing():
    assert 42 == 42
def test_failure():
    assert 42 == -13

Set Test framework as "pytest" in python project properties page.
Open TE with the Test > Windows > Test Explorer menu command
Run Tests.

Expected behavior
Tests can be run successfully.
Additional context and screenshots
The test was skipped.

Logs

Output for General in the Output panel

========== Starting test run ==========
cd C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\
set PYTHONPATH=C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\
"C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.3568.0_x64__qbz5n2kfra8p0\python3.9.exe" "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py" C:\Users\vting\source\repos\PythonApplication6\PythonApplication6\ pytest "" 0 "" "" dummyfilename .\test_1.py::test_failure .\test_1.py::test_passing --junitxml=C:\Users\vting\source\repos\PythonApplication6\TestResults\junitresults_c9d7473e-b54e-4c9e-b97a-aff866df4e4a.xml --rootdir=C:\Users\vting\source\repos\PythonApplication6\PythonApplication6 -o junit_logging=all -o junit_family=xunit1
Traceback (most recent call last):
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 189, in <module>
    main()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 30, in main
    run(testRunner, coverage_file, test_file, args)
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 119, in run
    patch_translate_non_printable()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 136, in patch_translate_non_printable
    translate_non_printable =  getattr(_pytest.compat, "_translate_non_printable")
AttributeError: module '_pytest.compat' has no attribute '_translate_non_printable'
Results for pytest not found C:\Users\vting\source\repos\PythonApplication6\TestResults\junitresults_c9d7473e-b54e-4c9e-b97a-aff866df4e4a.xml
========== Test run finished: 2 Tests (0 Passed, 0 Failed, 2 Skipped) run in 395 ms ==========

Seems like the version of pytest you installed is missing pytest.compat._translate_non_printable. What version of pytest do you have? Can you try updating the version and see if it repros?

@StellaHuang95 The Python installed from Microsoft Store.

I am now able to repro it. It's an issue within the pytest 8.1.0. This version has been yanked, see https://doc.pytest.org/en/latest/changelog.html#pytest-8-1-0-yanked.
Once I revert back to 8.0.2, I was able to run tests without any issues.

This is still broken in pytest v8.1.1.

This appears to be back with pytest 8.3.2 (python 3.11) in visual studio 17.11.1.
Did anyone have a permanent fix for this?
Traceback (most recent call last):
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 189, in <module>
    main()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 30, in main
    run(testRunner, coverage_file, test_file, args)
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 119, in run
    patch_translate_non_printable()
  File "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\EXTENSIONS\MICROSOFT\PYTHON\CORE\testlauncher.py", line 136, in patch_translate_non_printable
    translate_non_printable =  getattr(_pytest.compat, "_translate_non_printable")
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module '_pytest.compat' has no attribute '_translate_non_printable'

Microsoft Visual Studio Community 2022
Version 17.11.1
VisualStudio.17.Release/17.11.1+35219.272
Microsoft .NET Framework
Version 4.8.09032
Python - Profiling support   17.0.24138.2
Python with Pylance   17.0.24138.2


mMXKRoomViewController: Prepare room preview support

Add 'autoJoinInvitedRoom' property to enable/disable auto join on invitation.
Patch room data source to disable bubbles display on room preview.

LGTM


Refactored validation

Related issues
Refs: #445
(For autoclosure of issues when PR is merged use Fixes #<issue-number> syntax)
Describe the changes made in this pull request
This PR simplifies the validation of the test files. There is now just one version of the schema that is being tested (i.e. the latest, typically unreleased version, whose changes are not testable with cffconvert yet). Also there is just one test, which uses pytest.parametrize  to cycle through all CITATION.cff files.
The resulting output looks something like this:
$ pytest tests -v
=========================================== test session starts ===========================================
platform linux -- Python 3.10.12, pytest-7.4.2, pluggy-1.3.0 -- /home/user/github/citation-file-format/citation-file-format/venv/bin/python3
cachedir: .pytest_cache
rootdir: /home/user/github/citation-file-format/citation-file-format
collected 39 items

tests/test_cff_files.py::test_cff_files[pass:reference-conference-paper] PASSED                     [  2%]
tests/test_cff_files.py::test_cff_files[pass:entity-author-with-affiliation] PASSED                 [  5%]
tests/test_cff_files.py::test_cff_files[pass:software-without-a-doi] PASSED                         [  7%]
tests/test_cff_files.py::test_cff_files[pass:bso-toolbox] PASSED                                    [ 10%]
tests/test_cff_files.py::test_cff_files[pass:pcmid8] PASSED                                         [ 12%]
tests/test_cff_files.py::test_cff_files[pass:software-without-a-doi-closed-source] PASSED           [ 15%]
tests/test_cff_files.py::test_cff_files[pass:reference-art] PASSED                                  [ 17%]
tests/test_cff_files.py::test_cff_files[pass:reference-report] PASSED                               [ 20%]
tests/test_cff_files.py::test_cff_files[pass:ls1-mardyn] PASSED                                     [ 23%]
tests/test_cff_files.py::test_cff_files[pass:reference-blog] PASSED                                 [ 25%]
tests/test_cff_files.py::test_cff_files[pass:reference-edited-work] PASSED                          [ 28%]
tests/test_cff_files.py::test_cff_files[pass:nonunique-contributors] PASSED                         [ 30%]
tests/test_cff_files.py::test_cff_files[pass:reference-book] PASSED                                 [ 33%]
tests/test_cff_files.py::test_cff_files[pass:poc] PASSED                                            [ 35%]
tests/test_cff_files.py::test_cff_files[pass:nonunique-authors] PASSED                              [ 38%]
tests/test_cff_files.py::test_cff_files[pass:entity-author-with-ror] PASSED                         [ 41%]
tests/test_cff_files.py::test_cff_files[pass:bjmorgan_bsym] PASSED                                  [ 43%]
tests/test_cff_files.py::test_cff_files[pass:esalmela_haplowinder] PASSED                           [ 46%]
tests/test_cff_files.py::test_cff_files[pass:reference-article] PASSED                              [ 48%]
tests/test_cff_files.py::test_cff_files[pass:xenon-middleware_xenon-adaptors-cloud] PASSED          [ 51%]
tests/test_cff_files.py::test_cff_files[pass:short] PASSED                                          [ 53%]
tests/test_cff_files.py::test_cff_files[pass:nonunique-contact] PASSED                              [ 56%]
tests/test_cff_files.py::test_cff_files[pass:simple] PASSED                                         [ 58%]
tests/test_cff_files.py::test_cff_files[pass:minimal] PASSED                                        [ 61%]
tests/test_cff_files.py::test_cff_files[pass:isbn10] PASSED                                         [ 64%]
tests/test_cff_files.py::test_cff_files[pass:software-executable] PASSED                            [ 66%]
tests/test_cff_files.py::test_cff_files[pass:software-container] PASSED                             [ 69%]
tests/test_cff_files.py::test_cff_files[pass:software-with-a-doi] PASSED                            [ 71%]
tests/test_cff_files.py::test_cff_files[pass:reference-thesis] PASSED                               [ 74%]
tests/test_cff_files.py::test_cff_files[pass:key-complete] PASSED                                   [ 76%]
tests/test_cff_files.py::test_cff_files[pass:software-with-reference] PASSED                        [ 79%]
tests/test_cff_files.py::test_cff_files[pass:software-with-a-doi-expanded] PASSED                   [ 82%]
tests/test_cff_files.py::test_cff_files[fail:invalid-author-array] PASSED                           [ 84%]
tests/test_cff_files.py::test_cff_files[fail:url-trailing-spaces] PASSED                            [ 87%]
tests/test_cff_files.py::test_cff_files[fail:invalid-date] PASSED                                   [ 89%]
tests/test_cff_files.py::test_cff_files[fail:ls1mardyn_ls1mardyn] PASSED                            [ 92%]
tests/test_cff_files.py::test_cff_files[fail:orcid-trailing-chars] PASSED                           [ 94%]
tests/test_cff_files.py::test_cff_files[fail:orcid-trailing-spaces] PASSED                          [ 97%]
tests/test_cff_files.py::test_cff_files[fail:additional-key] PASSED                                 [100%]

Review checklist

[x] Please check if the pull request is against the correct branch
(format/schema/semantic documentation changes: develop; typos, meta files, etc.: main)
[x] Please check if all changes are recorded in CHANGELOG.md and adapt if necessary.
[x] Please run tests locally.

cd $(mktemp -d --tmpdir cff.XXXXXX)
git clone https://github.com/citation-file-format/citation-file-format .
git checkout <branch>
python3 -m venv env
source env/bin/activate
pip install --upgrade pip wheel setuptools
pip install -r requirements.txt
pytest
<do other things>

[ ] <do other things>

TODOs:

[ ] We could consider simplifying the validation of cff snippets in schema-guide.md, currently the test tries to iteratively improve the snippet until it passes, a bit difficult to maintain
[ ] some example files were harvested from the internets, and their origin is reflected in the name. this may come across like we're picking on people (we're not, of course), but perhaps we can rename to something that reflects the type of error
[ ] I didn't delete the examples/ directory just yet, but I am in favor of doing so.

Update:
I also added a new way of testing the snippets from schema-guide.md using a parameterized test, which I hope is a bit more maintainable. Its output looks like this:
tests/test_snippets_from_schema_guide.py::test[L379-L379] PASSED                                   [ 20%]
tests/test_snippets_from_schema_guide.py::test[L382-L382] PASSED                                   [ 20%]
tests/test_snippets_from_schema_guide.py::test[L385-L385] PASSED                                   [ 21%]
tests/test_snippets_from_schema_guide.py::test[L399-L405] PASSED                                   [ 21%]
tests/test_snippets_from_schema_guide.py::test[L415-L435] PASSED                                   [ 21%]
tests/test_snippets_from_schema_guide.py::test[L445-L445] PASSED                                   [ 21%]
tests/test_snippets_from_schema_guide.py::test[L455-L455] PASSED                                   [ 22%]
tests/test_snippets_from_schema_guide.py::test[L465-L465] PASSED                                   [ 22%]
tests/test_snippets_from_schema_guide.py::test[L475-L475] PASSED                                   [ 22%]
tests/test_snippets_from_schema_guide.py::test[L486-L486] PASSED                                   [ 23%]
tests/test_snippets_from_schema_guide.py::test[L489-L489] PASSED                                   [ 23%]
tests/test_snippets_from_schema_guide.py::test[L499-L499] PASSED                                   [ 23%]
tests/test_snippets_from_schema_guide.py::test[L509-L509] PASSED                                   [ 23%]
tests/test_snippets_from_schema_guide.py::test[L512-L512] PASSED                                   [ 24%]
tests/test_snippets_from_schema_guide.py::test[L515-L515] PASSED                                   [ 24%]
tests/test_snippets_from_schema_guide.py::test[L531-L533] XFAIL (deliberately incorrect snippet)   [ 24%]
tests/test_snippets_from_schema_guide.py::test[L536-L539] XFAIL (deliberately incorrect snippet)   [ 25%]
tests/test_snippets_from_schema_guide.py::test[L542-L544] PASSED                                   [ 25%]
tests/test_snippets_from_schema_guide.py::test[L582-L584] PASSED                                   [ 25%]
tests/test_snippets_from_schema_guide.py::test[L594-L596] PASSED                                   [ 25%]
tests/test_snippets_from_schema_guide.py::test[L606-L608] PASSED                                   [ 26%]
tests/test_snippets_from_schema_guide.py::test[L618-L618] PASSED                                   [ 26%]
tests/test_snippets_from_schema_guide.py::test[L621-L621] PASSED                                   [ 26%]
tests/test_snippets_from_schema_guide.py::test[L880-L882] PASSED                                   [ 27%]
tests/test_snippets_from_schema_guide.py::test[L885-L888] FAILED                                   [ 27%]
tests/test_snippets_from_schema_guide.py::test[L898-L898] PASSED                                   [ 27%]
tests/test_snippets_from_schema_guide.py::test[L901-L903] FAILED                                   [ 27%]
tests/test_snippets_from_schema_guide.py::test[L906-L908] FAILED                                   [ 28%]
tests/test_snippets_from_schema_guide.py::test[L911-L913] FAILED                                   [ 28%]
tests/test_snippets_from_schema_guide.py::test[L916-L918] FAILED                                   [ 28%]
tests/test_snippets_from_schema_guide.py::test[L921-L925] FAILED                                   [ 29%]
tests/test_snippets_from_schema_guide.py::test[L935-L935] PASSED                                   [ 29%]
tests/test_snippets_from_schema_guide.py::test[L945-L947] PASSED                                   [ 29%]

I mostly like this approach:

the way of running tests is completely idiomatic, no custom stuff
the id for each snippet corresponds to the line numbers in schema-guide.md, which is intuitive
running just one test  is also possible, e.g. with pytest tests/test_snippets_from_schema_guide.py::test[L945-L947]

There are still a whole lot of errors, which are almost exclusively due to missing required properties from references examples. I'm planning to do some more work on this.

TODOs:
* [ ]  some example files were harvested from the internets, and their origin is reflected in the name. this may come across like we're picking on people (we're not, of course), but perhaps we can rename to something that reflects the type of error

I can do that in a separate PR.

* [ ]  I didn't delete the `examples/` directory just yet, but I am in favor of doing so.

Yes.

* [ ]  Update _Testing_ section in `README.dev.md`

Yes.


Update to version 1.2.31

Update feedstock for pyub2 v1.2.31

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


External signatures

Hello!
I am trying to make a digital signature on PDFs and ive been doing some tests with pdfbox-android. First ive tryed to add a external signature on desktop environment with success using the :
ExternalSigningSupport externalSigning =  document.saveIncrementalForExternalSigning(fos);
byte[] cmsSignature = Files.readAllBytes(pathToSignedHash);
externalSigning.setSignature(cmsSignature);
So this is where the problem comes now, i dont have the required classes on the android pdfbox and i cant seem to find a way around it. Any way to make an external signature work in this actual version of android pdfbox or in any soon release?
By the way great work so far :)

This class was introduced in v2.0.3 and this library is currently up to date with v1.8.9, so it will be some time before this library will be caught up. I haven't had a chance to take a look at the code for ExternalSigningSupport yet, but I"ll see what it does and if it can easily be replicated easily.

I believe I've added the functionality you need if that's the only part that's giving you trouble. I've attached an aar with the necessary changes.
pdfbox-android-<IP_ADDRESS>.aar.zip

Hello Tom!
First of all , thanks for the quick response !
I´ve tryed the .aar you uploaded but i have a problem with the implementation. It seems that the methods saveIncrementalForExternalSigning(OutputStream output) and addSignature(PDSignature sigObject) from the PDDocument class do not exist to complete an external signature successfully.

I must have missed PDDocument, Try this one.
pdfbox-android-<IP_ADDRESS>.aar.zip

Hey Tom,
I´ve been around the code for a while and i keep getting  an java.lang.ArrayIndexOutOfBoundsException on the COSWriter.doWriteSignature method that the saveIncrementalForExternalSigning(fos) uses. I´ve tryed many things and i think i have nothing wrong with my code.
The code sample i am using is the following:
`package com.example.joao.pdfboxtests2;
import android.os.Environment;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import com.tom_roush.pdfbox.pdmodel.PDDocument;
import com.tom_roush.pdfbox.pdmodel.interactive.digitalsignature.ExternalSigningSupport;
import com.tom_roush.pdfbox.pdmodel.interactive.digitalsignature.PDSignature;
import java.io.BufferedInputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.Calendar;
public class MainActivity extends AppCompatActivity {
final String signedHashLoc = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/hashSignature-2.sign";
final String pdfToSignLoc = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/pdftosign.pdf";
final String pdfSignedLoc = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/pdfsignedAndroid.pdf";
//PDDocument document;
FileInputStream docToSignIS, signedHashIS;
FileOutputStream docSignedOS;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
    try {
        docToSignIS =new FileInputStream(pdfToSignLoc);
        signedHashIS =new FileInputStream(signedHashLoc);
        docSignedOS =new FileOutputStream(pdfSignedLoc);
    } catch (FileNotFoundException e) {
        e.printStackTrace();
    }

    //criar o signature dictionary
    PDSignature signature = new PDSignature();
    signature.setFilter(PDSignature.FILTER_ADOBE_PPKLITE);
    signature.setSubFilter(PDSignature.SUBFILTER_ADBE_PKCS7_DETACHED);
    signature.setName("Example User");
    signature.setLocation("Los Angeles, CA");
    signature.setReason("Testing");
    //data da assinatura
    signature.setSignDate(Calendar.getInstance());
    System.out.println("Sign externally...");
    try {
        PDDocument document = PDDocument.load(docToSignIS);
        document.addSignature(signature);
        ExternalSigningSupport externalSigning =document.saveIncrementalForExternalSigning(docSignedOS);
        externalSigning.setSignature(getSignedDigest());
        document.save(docSignedOS);
        document.close();
        docSignedOS.close();
        docToSignIS.close();
        signedHashIS.close();
    } catch (IOException e) {
        e.printStackTrace();
    }

}
public byte[] getSignedDigest(){
    File file = new File(signedHashLoc);
    int size = (int) file.length();
    byte[] bytes = new byte[size];
    try {
        BufferedInputStream buf = new BufferedInputStream(signedHashIS);
        buf.read(bytes, 0, bytes.length);
        buf.close();
    } catch (FileNotFoundException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    } catch (IOException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
    return bytes;
}

}`
The error it gives is the following:

Thanks in advance

I too get the same error 👍
..
java.lang.RuntimeException:
...
Caused by: java.lang.ArrayIndexOutOfBoundsException: length=20732; index=767721
at com.tom_roush.pdfbox.pdfwriter.COSWriter.doWriteSignature(COSWriter.java:722)
at com.tom_roush.pdfbox.pdfwriter.COSWriter.visitFromDocument(COSWriter.java:1114)
public ExternalSigningSupport saveIncrementalForExternalSigning(OutputStream output) throws IOException {
if(this.pdfSource == null) {
throw new IllegalStateException("document was not loaded from a file or a stream");
} else {
COSWriter writer = new COSWriter(output, this.pdfSource);
writer.write(this); *****************
this.signingSupport = new SigningSupport(writer);
return this.signingSupport;
}
}
The error is here ** in the write(this)
public void write(PDDocument doc) throws IOException {
this.write(doc, (SignatureInterface)null);
}
is the null correct ?

Seems like this is more difficult than I hoped. Would it be possible for either of you to share a test signature file that fails that I could use for testing?

Hey Tom,
Can i have an email to send you the files im using for testing? Some of them are kind of private :)

Never mind, I managed to get the error again with my signature.

Hello Tom,
I could not find another way to contact you and i have some questions to ask .I depend on this lib on Android and i would like to contribute in some way to this port but i am a Junior Developer. What do i need to know to start contributing ?
My personal email is<EMAIL_ADDRESS>if you wish to speak outside git.
Thanks in advance!

Hello Tom,
I have been analyzing the error and i believe i have found the solution by comparing code between the original PDFBox (https://github.com/apache/pdfbox/tree/2bf48eed0223118c22b19c53cff20a2c5ba5fb95) and PDFBox-Android, since i had a external signature solution working on the original one.
By comparing what was added to the original one i have found that by switching the code long inLength = incrementalInput.available(); for long inLength = incrementalInput.length(); at the COSWriter.java class it seems to work fine.

That's great. I can't check right now, but if everything works as it should, feel free to make a pull request.

Sorry if this is a nub question but I do not find ExternalSigningSupport class when I add this line in build.gradle dependencies -
implementation 'com.tom_roush:pdfbox-android:<IP_ADDRESS>'
This class is not available -
import com.tom_roush.pdfbox.pdmodel.interactive.digitalsignature.ExternalSigningSupport;
Why?


feat(cli): exit codes

Alright, I took a stab at implementing https://github.com/Boshen/oxc/issues/50
Some things of interest:

I refactored the lint and lint_path methods a little bit to access the diagnostics in main.rs
Clippy complains about the println!() in main.rs, but I dont know how to make it happy 🙃
In lib.rs, I get a compiler warning that the path and diagnostics never get used, even though I assign them in line 35 in Cli, I'm guessing thats because the diagnostic already gets printed in lint_path, maybe I should move the printing of the diagnostics over to main.rs as well? What do you think?

I think what's cool about passing data into PathNotFound and LintResult is that we can combine common errors and print them here.
So something like
            Self::PathNotFound { path } => {
                println!("Path {} does not exist.", path.to_string_lossy());
                ExitCode::from(1)
            }
            Self::LintStats {
                run_duration,
                number_of_diagnostics,
            } => {
                if number_of_files == 0 {
                    println!("No files found.");
                    ExitCode::from(0)
                } else {
...

Because once we get multiple commands such as oxc lint / minify / prettier, print and then exit will become super messy. It's a lot cleaner to delegate these kind of common printing logic here.

Clippy complains about the println!() in main.rs, but I dont know how to make it happy 🙃

Let me guess it wants you to do println!("{variable}") instead of println!("{}", variable)?

maybe I should move the printing of the diagnostics over to main.rs as well

I think this sounds good, or you can print them in the report method, since we are going to get other commands that emit diagnostics, which'll end up with the same printing logic.

Because once we get multiple commands such as oxc lint / minify / prettier, print and then exit will become super messy. It's a lot cleaner to delegate these kind of common printing logic here.

That makes sense, let me try to refactor that

Let me guess it wants you to do println!("{variable}") instead of println!("{}", variable)?

TIL, will fix

I think this sounds good, or you can print them in the report method, since we are going to get other commands that emit diagnostics, which'll end up with the same printing logic.

Yep, makes sense

This kind of Rust takes a while, but I think you are getting the hang of it!

This kind of Rust takes a while, but I think you are getting the hang of it, I hope you are having fun!

For sure, this is great practice 🙂
I think I covered all the review feedback, could you take another look and let me know what you think? Thanks!

Do you mind squash and rebase your commits? It's almost ready to go!

When you get a "[Merge branch 'main' into feat/exit-codes]" commit, it means you haven't pulled the main branch yet so git start merging your branch.
Can you try:
git checkout main
git pull
git checkout -
git rebase main
git push --force

Sorry, I had to update my fork, should be rebased correctly now

You may want to setup auto format, it's better than what we have in js ;-)

Thank you!

Thanks for bearing with me! 🙂 Would love to hack on something else if you have any other good first issues popping up!

Thanks for bearing with me! 🙂 Would love to hack on something else if you have any other good first issues popping up!

Checkout all the issues I created :-)


Crash while looking for green signal

I was trying to find all the places where a green signal was being generated. Factorio 1.1.59 win64
The mod Factory Search (1.5.3) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event FactorySearch::on_gui_checked_state_changed (ID 3)
Unknown fluid name: signal-green
stack traceback:
	[C]: in function 'get_fluid_count'
	__FactorySearch__/scripts/search.lua:343: in function 'find_machines'
	__FactorySearch__/scripts/ui.lua:555: in function 'start_search'
	__FactorySearch__/scripts/ui.lua:596: in function <__FactorySearch__/scripts/ui.lua:589>

Thanks for the report - this was fixed in v1.6.0, so please update to the latest version (v1.6.1).


create frontend for submitting and displaying recruitment promo media

Checkout OrganizationRecruitmentPage where the media will be displayed and recruitment form where it will be submitted.
Backend is done in #1121

Is backend done for submitting a promo video? I did not see it in the model for recruitment


Feature Request: Add flag to turn off Vibration

It would be nice to have to open to turn off vibration.

Got it.

You already have this feature?  I don't see a boolean in any constructor for it?

Unhandled Exception: MissingPluginException(No implementation found for method hasVibrator on channel vibration), any solution ?

Unhandled Exception: MissingPluginException(No implementation found for method hasVibrator on channel vibration)
any solution ?


FE Improvement

@atolopko-czi @dsadgat  I have some FE eng excellence tickets I'd like to pull in in Q4, what's the best way to slot the work in the roadmap? Thank you!


get token from moodle with admin user + autogen files

Added functionality to get token from Moodle using Admin account credentials.

@eshin2 fixed the tests, just had to change from Provider to ChangeNotifierProvider in each test set up because in your PR you changed the User class to extend ChangeNotifierProvider.
This PR just includes a hardcoded username and password, and a hardcoded moodle url - If we want to use this style of logging in, we need to provide the user a way to set this information, like "username", "password", and "moodle url" inputs above the login with moodle button.
Alternatively, we can use OAuth like @WhitneyMeulink was suggesting - however this poses a new set of problems, including but not limited to: we would need a way for the user to set the client_id, client_secret, and base Moodle URL. This plus extra configuration on the part of moodle seems like maybe we should go back to option 1 (log in with username and password) as described above. I won't approve for now, but the changes to the UserProvider and Login Page look good considering we change the things described here.


Expand Shape system into Layer system

Currently, LiterallyCanvas maintains a list of shapes to render. This could easily be expanded to a more general layer system allowing for a wider variety of use cases to be addressed.

How about the layer system?


Basic: adjust aliasing annotation (NFCI)

GCC -fpermissive flagged this annotation as being discarded as it is
being applied after the definition.  Move the annotation to the
re-definition to which it appertains.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


[release-4.12] Upgrade multicloudopen module paths

/cherrypick release-4.11

/cherrypick release-4.10

/test integration

/test integration


HMC-NUTS for VALD3

@chonma0ctopus is now working on the capability of HMC-NUTS for VALD3, which was not available in v1.0.

Done by #218