docker on qnap x64 possible?

Hello Jocelyn :)
I have acquired a new QNAP TS-228A, trying to configure this, and the Container won't even start. I click the Start option, it seems to start for a split second, and immediately quits.
Console repeatedly lists:
standard_init_linux.go:187: exec user process caused "exec format error"
I know now that it s because of the different architecture,  but even new synology Nas devices have arm processors and x64. Is it possible to change this image to make it compatible or do I have to buy an older Nas system? I just bought it to use it with your docker app..

See this issue https://github.com/jlesage/docker-crashplan-pro/issues/107. This container is compiled for x86 (which stands for intel). Also, this TS-228A has too little memory, so even if it started you would not have enough memory to run crashplan. If you want to use this container, find a nas with intel processor and at least 4 Gb internal memory (but preferably 8Gb or even more).

Also note that CrashPlan is not open source and there is no ARM binaries available...

So, is it possible to run CrashPlan on a QNAP Nas? I have the TVS-872XT which should be more than capable. Any ideas? Thanks!

Yes, it's possible.  Only arm-based models can't run it.

Closing this issue.  Please re-open if needed.


fix: file does not exist

fixed these:
error client file does not exist: */vuepress-theme-gungnir/packages/theme/src/client/clientAppEnhance.js
error error in hook clientAppEnhanceFiles from vuepress-theme-gungnir
Related ISSUE

Input follow ISSUE URL address

Type Of Change

[x] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 📝 Document (This change requires a documentation update)
[ ] 🎨 Theme style (Theme style beautification)
[ ] ⚠  Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 🔨 Workflow (Workflow changes)

Clear Describe

A clear and concise description of what update for target.

Description

Please enter detailed relevant motivation, background and implementation ... descriptive information.

Test Case

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test case.

Hi, I think the file paths here should be ../client/xxx.js, since these paths are referred to the compiled .js files (will be generated in packages/theme/lib after running yarn dev or yarn build) instead of .ts files. Thus making such changes would cause "file does not exist" errors (as you can see: Vercel – v2-vuepress-theme-gungnir — Deployment has failed).

这次可真是丢人丢到家了 跑到vuepress仓库提了这个pr  已经知道问题答案了😂😂😂


create account new error

When I was trying to create a new account I got this new error

I think the error occurs because the submission of create account form doesn't work any more
I hope you check this very soon please.
EDIT: ERROR APPEARS IN CHANGE PASSWORD TOO.
EDIT: ERROR APPEARS IN LOGIN

I could skip these problem using selenium:
from typing import Dict, List
from selenium import webdriver
from selenium.webdriver.common.by import By
from selenium.webdriver.support.wait import WebDriverWait
from selenium.webdriver.chrome.service import Service
from webdriver_manager.chrome import ChromeDriverManager
from time import sleep

def login(email: str, password: str) -> str:
    service = Service(ChromeDriverManager().install())
    driver = webdriver.Chrome(service=service)
    wait = WebDriverWait(driver, 30)
    driver.get("https://www.facebook.com")
    wait.until(
        lambda client: client.execute_script("return document.readyState")
        == "complete"
    )
    driver.find_element(By.XPATH, "//input[@id='email']").send_keys(email)
    driver.find_element(By.XPATH, "//input[@id='pass']").send_keys(password)
    driver.find_element(By.XPATH, "//button[@name='login']").click()
    sleep(30)
    if "login" in driver.current_url:
        return ""
    return cookie_to_str(driver.get_cookies())

def cookie_to_str(cookies: List[Dict]) -> str:
    return ";".join([f"{cookie['name']}={cookie['value']}" for cookie in cookies])```


Incompatibility with Postgres running on non-default port

The default port number for Postgres, 5432, is hard-coded in lib/DBSteward/sql_format/pgsql8/pgsql8.php:
cbbrowne% grep 5432 ////* | uniq
lib/DBSteward/sql_format/pgsql8/pgsql8.php:    pgsql8_db::connect("host=$host port=5432 dbname=$database user=$user password=$password");
This prevents using the "slurp" capabilities on a database running on a non-default port.
It is suggested that a --dbport option be added

agreed. an oversight on my part.
implemented in
504be33cd655ef67a0eef4049eb73311348bb4d3
fc191925978e92bfba36918ba572b2d8b1ace68a


Can you provide me a project sence ?

Hello, Think you for your repositories. I want to relize your project like your video, but I can not find an available   sence.Can you provide me your project sence ?
thanks very much.

Sure, I'll update the repo with the projects. Thanks for the issue.

thanks for you reply and look forward to your update.
------------------ 原始邮件 ------------------
发件人: "J Van<EMAIL_ADDRESS>发送时间: 2019年7月9日(星期二) 凌晨0:54
收件人<EMAIL_ADDRESS>抄送: "WU Mulun"429055295<EMAIL_ADDRESS>主题: Re: [Xhiwankur/A_Star_Unity] Can you provide me a project sence ?(#1)
Sure, I'll update the repo with the projects. Thanks for the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Typeguard version in requirements

When using newer typeguard versions like 4.0.0 I encountered an error while the code runs fine with an older typeguard version like 2.11.1. Maybe the requirements file should be changed from typeguard -> typeguard==2.11.1.

Hi @NiclasGoering ,
You seems to get this code working. May I ask as a deepspeed newbie:
In the code, the language model is loaded on CPU, while the data, and also other model parts seems to be on GPU device. Wouldn't that cause a problem like RuntimeError: Expected all tensors to be on the same device? Or magical ```Deepspeed`` has its way of handling it?

I've had the same issue.
I think this change (and fixing exact versions of all the other dependencies in requirements.txt) is of utmost importance.

Hi,
thanks for notifying, I will look into it and probably pin the typeguard version.
Best,
Constantin


Add support for the new Presto task

JIRA - https://jira.lyft.net/browse/AVSW-41872

This PR addresses the following -

Presto task SDK
This is dependent on https://github.com/lyft/flyteidl/pull/45/files
Once the above PR is merged, we can finish the integration and do unit test

@matthewphsmith - The PR is just to understand the task. this is not a final PR, needs cleanup and unit test.

@wild-endeavor @EngHabu can you guys take a look? It's pretty much what we pair-programmed together but I cleaned it up. It's ready for review

@wild-endeavor @matthewphsmith @EngHabu Thank you all for the great feedback! I went ahead and made changes from your comments. Please take another look at your earliest convenience :)

Two more comments in response to Haytham's and Matt's comments above - tiny things, but would feel more comfortable testing it one more time.

Alright, I went ahead and applied the last of the suggestions and tested locally and everything appears to work well.
When routing_group is not specified, flyteplugins provides the default value of adhoc which will target the various adhoc clusters that the routing group points to. In the case of catalog and schema, these values  are optional because a  user can also  specify them directly in their query such as:
SELECT * FROM {catalog}.{schema}.{table_name}

e.g.
SELECT * FROM hive.city.foo_bar

In this case, user's wouldn't need to set the catalog nor the schema and so we shouldn't set any default for them. If their query  looked something like:
SELECT * FROM fact_airport_sessions

and neither catalog nor schema is specified, then the query will result in an error and users will have to set these values directly  in the query or as parameters.
This is what the Presto UI shows when catalog and  schema are specified directly in the query:

In Flyte, this is what the inputs will look like (notice that none of the explicit routing_groupg, catalog, and schema inputs are there and that the implicit inputs are all empty):

And the output will show the external location along with the schema that the user specified:

I await a final look-over  :)

@EngHabu could you take one final look when you get a chance?


Don't consider query string as part of method name

Use the rack method that returns the path without querystring.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'm not sure that twirp as a protocol cares about this or really allows query strings, but some quick testing suggests that this matches how routing works for the go twirp library.

Hi, Thanks for the contribution. Could you add this to statement to your pull request:
"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license."
Thanks!

Done

Thanks for the contribution.


kernel: simple part of _current / _current_cpu optimizations

I figured I should split out the simple/straightforward parts of the _current / _current_cpu optimizations into their own PR.
See also: #32709, #32806.
This PR:

inlines k_current_get where appropriate.
const-ifies k_current_get.
pure-ifies arch_curr_cpu.
Marks arch_curr_cpu as always returning a valid pointer (instead of e.g. NULL).
Removes a couple of unnecessary asm volatiles.

The changes and rationale make sense. Do you have some benchmark data that shows how much can be gained by these changes?
Also, we need to ensure the changes (attribute pure, etc.) work with other toolchains (e.g. ARC MetaWare).

The changes and rationale make sense. Do you have some benchmark data that shows how much can be gained by these changes?

~20% on a non-swapping k_yield on AArch64 SMP. Mind you we were spending about 50% of the total time in k_current_get  (each call is cheap, but when you're calling it 15x per k_yield it adds up quickly.)
Less in other cases for the most part.

Also, we need to ensure the changes (attribute pure, etc.) work with other toolchains (e.g. ARC MetaWare).

Sure; who can do so?
Alternatively, any idea how to do "if GCC-like, use this definition, otherwise use a default nop definition"? I'd normally drop in a default null definition and put the __attribute__((const)) / pure in the GCC and Clang includes, but it doesn't seem like Zephyr has GCC or Clang-specific includes - gcc.h is included from other toolchains.
In particular, quickly playing around, gen_syscalls.py doesn't appear to support anything other than __attribute__ on syscall declarations...

Also, we need to ensure the changes (attribute pure, etc.) work with other toolchains (e.g. ARC MetaWare).

Sure; who can do so?
Alternatively, any idea how to do "if GCC-like, use this definition, otherwise use a default nop definition"? I'd normally drop in a default null definition and put the __attribute__((const)) / pure in the GCC and Clang includes, but it doesn't seem like Zephyr has GCC or Clang-specific includes - gcc.h is included from other toolchains.
In particular, quickly playing around, gen_syscalls.py doesn't appear to support anything other than __attribute__ on syscall declarations...

Sure; who can do so?

I'll do testing for ARC MWDT toolchain tomorrow.

Hm. Who owns the documentation generator? It's not properly parsing
static ALWAYS_INLINE _cpu_t * arch_curr_cpu (void)

it seems to be treating ALWAYS_INLINE as a type...

Error: /home/runner/work/zephyr/zephyr/doc/_build/rst/doc/guides/porting/arch.rst:884: WARNING: Error in declarator or parameters
Invalid C declaration: Expecting "(" in parameters. [error at 28]
  static ALWAYS_INLINE _cpu_t * arch_curr_cpu (void)
  ----------------------------^

@jharris-intel will you follow-up with the fixes required to get this merged?


suthesh/setup-storybook

Changes:

setup storybook

Type of change

[ ] Bug fix
[x] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Could you address the 1 code smell? 🙏


Possible race conditions in podman system integration tests

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
While running the podman system integration tests, we found that the /no such/command test has issues tearing down networks for containers:
not ok 11 podman run - basic tests
# (from function `is' in file /usr/share/podman/test/system/helpers.bash, line 289,
#  in test file /usr/share/podman/test/system/030-run.bats, line 30)
#   `is "$output" "$expected_output" "podman run $cmd - output"' failed
# $ podman rm --all --force
# $ podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
# docker.io/library/fedora:latest   55dc61afd232
# $ podman run docker.io/library/fedora:latest true
# $ podman run docker.io/library/fedora:latest false
# [ rc=1 (expected) ]
# $ podman run docker.io/library/fedora:latest sh -c exit 32
# [ rc=32 (expected) ]
# $ podman run docker.io/library/fedora:latest echo tpLOfp4uurtZMhlopsIMQvSqBxJXeW
# tpLOfp4uurtZMhlopsIMQvSqBxJXeW
# $ podman run docker.io/library/fedora:latest /no/such/command
# time="2019-08-01T11:11:08-04:00" level=error msg="Error deleting network: running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists
# "
# time="2019-08-01T11:11:08-04:00" level=error msg="Error while removing pod from CNI network "podman": running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists
# "
# time="2019-08-01T11:11:08-04:00" level=error msg="unable to cleanup network for container 671a288c67b03346a36282a6a68b0d9168046b4405d76059779fba447b6e648a: "error tearing down CNI namespace configuration for container 671a288c67b03346a36282a6a68b0d9168046b4405d76059779fba447b6e648a: running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists\n""
# Error: container_linux.go:345: starting container process caused "exec: \"/no/such/command\": stat /no/such/command: no such file or directory"
# : OCI runtime error
# [ rc=127 (expected) ]
# #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
# #|     FAIL: podman run /no/such/command - output
# #| expected: 'Error: .*: starting container process caused .*exec:.*stat /no/such/command: no such file or directory'
# #|   actual: 'time="2019-08-01T11:11:08-04:00" level=error msg="Error deleting network: running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists'
# #|         > '" '
# #|         > 'time="2019-08-01T11:11:08-04:00" level=error msg="Error while removing pod from CNI network "podman": running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists'
# #|         > '" '
# #|         > 'time="2019-08-01T11:11:08-04:00" level=error msg="unable to cleanup network for container 671a288c67b03346a36282a6a68b0d9168046b4405d76059779fba447b6e648a: "error tearing down CNI namespace configuration for container 671a288c67b03346a36282a6a68b0d9168046b4405d76059779fba447b6e648a: running [/usr/sbin/iptables -t nat -N CNI-b2e1e81e05eb3f27a3925a5b --wait]: exit status 1: iptables v1.8.2 (nf_tables): Chain already exists\n"" '
# #|         > 'Error: container_linux.go:345: starting container process caused "exec: \"/no/such/command\": stat /no/such/command: no such file or directory"'
# #|         > ': OCI runtime error'
# #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# # [teardown]
# $ podman pod rm --all --force
# $ podman rm --all --force
# 6163795ff8c6ed18097f6462f8246a0bae963c12f61be2ab0a3a4c3bdba32a22
# be61a80cf5a18fd19491a0c37c551b8ce5f3b08aee1d053defc28f4f45213707
# 671a288c67b03346a36282a6a68b0d9168046b4405d76059779fba447b6e648a
# e032d3953d3aa28cf8435073b8f2f02a35ebc080b8c2af61fec0919278720865
# f4e687f6d5cb84c44ce99dc1b7551451a4881df85d905e66ed873ba91c6bc8e8

Steps to reproduce the issue:

bats /usr/share/podman/test/system

Describe the results you received:
The test failed with network teardown issues.
Describe the results you expected:
I expected the test to pass.
Additional information you deem important (e.g. issue happens only occasionally):
We see this issue more often on aarch64 and ppc64le than we see it on x86_64.
Output of podman version:
podman version 1.4.2

Output of podman info --debug:
(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):
This issue happens most often on RHEL 8 on ppc64le/aarch64.

@edsantiago PTAL

FWIW I am bringing Fedora 30's podman-1.4.4-4.fc30 down to RHEL 8 on ppc64le to see if anything changes there.

Um, looks like the usual iptables thing, no?

Oh. Oops. Agree.
I'm going to poke the CNI folks again about an update. I think we have fixed builds going into 8.1, so we really need to get them in elsewhere as well.

Thanks for looking into this! I'll be happy to test whenever something is ready.

Note: Realizing a fix for the CNI 'chain already exists' race, requires rolling new VM images with updated packages.  I've got two PRs open which will do this, but are blocked by other problems they uncovered.  I expect that drain to un-clog shortly, and they can move forward next week.  Otherwise if someone else wants to do this in a separate PR, that's fine too.

This ought to be fixed now that CNI 0.8.1 is available


ModuleNotFoundError: No module named 'official.wide_deep'

URL(s) with the issue:
https://www.tensorflow.org/tutorials/estimators/linear
Description of issue (what needs changing):
https://github.com/tensorflow/models has wide_deep in official.r1.wide_deep but the documentation says it's in official.wide_deep.

Issue fixed.


Background color doesn't work

The background color option doesn't seem to work.
I have tried it on a local docker environment with no success and the example online have the same issue.
https://oi.flyimg.io/upload/r_45,w_400,h_400,bg_red/https://raw.githubusercontent.com/flyimg/flyimg/master/web/Rovinj-Croatia.jpg

Thank you for submitting the issue, I'll close it due to the duplication.
see #145

Sorry for the duplicate !

no worries, we'll try to fix it asap.

Fixed in the latest release.


Update documentation / wiki images automatically via integration testing

Related to #144

Ideally we would want a way to test the data without the backend, or the ability to spin up a backend server and some test data for testing.  For right now though we should be able to utilize the Viame.kitware.com web server with puppeteer to grab specific images.
Furthermore if we do this inside of the wiki repository we could make it even smarter.  We could store a result of the images and compare them with currently tested images.  If the images are signficantly different we could search through the wiki files and find any references and note to the user that they should update those wiki entries to reflect the newer images.
This would mean we run the script to create the test images and get back a list of items that have changed as well as where in the Wiki those images are referenced.

Do we really need this? I usually think of documentation as an activity where automation doesn't help very much or can even hurt. I nominate this issue for closing, but if someone can explain the rationale for tackling this instead, I'm listening.


Bump Documenter compat

This is a bit premature. Also, there will likely not be a 0.28 (the plan is to tag master as 1.0.0).

Ok I'll close this. My workflow is apparently not quite perfect for juggling dev branches...


PlayerWebView event return status is abnormal.

In the test, we found that abnormal event returns, the video is always in the loading state.


fix: create intermediate nodes when needed

Towards: https://github.com/paradigmxyz/reth/issues/12129

Fixed intermediate node creation: create nodes with the appropriate tree mask and state mask when the current path is more than 1 nibble longer than the current prefix. As the tests here showed https://github.com/paradigmxyz/reth/pull/12080, we had issues with a path like 0b060502, the node at 0b has tree mask<PHONE_NUMBER>000000 (expects child at position 6), there is no node at 0b06 but there is a node at 0b0605. These changes fix the creation of the missing intermediate node.
Added unit tests for new functionality, specifically for intermediate node creation with different setups and verification of tree mask is a subset of state mask
Added unit test to cover https://github.com/paradigmxyz/reth/issues/12129 with data from the case described above.

this PR introduces branch node retention that violates MPT structure


Add Audit Log reason support

Via X-Audit-Log-Reason header

Maybe you can add a bit more context here on what you want, how it improves the library, and maybe a bit more detail on how you're envisioning it being implemented?

Well, just add a reason parameter to every auditable action. It allows the end user to specify reasons and state who does things, which eliminates the need for a modlog.

The implementation is described here: https://discordapp.com/developers/docs/resources/audit-log
And here an example how it looks in action:

It's useful for Bots so they can attach who actually caused the, for example, kick.

Ban and Kick already have a function for adding a Reason. Is there a list with all endpoints that support audit log reasons?

That's a pretty good question and I'm not sure I know the answer even at this point.  I'll try to research it a bit though and see - or anyone else that already knows off the top of their head are free to jump in :)

Here 356 days later, I tested this and this is what I have:
When adding X-Audit-Log-Reason in the request header and giving someone a role through a bot it also adds the reason in the audit log, it seems it also has no inpact on a endpoint like getting channel data.
I don't know though what would be a good way to implement this, I think we should avoid adding a ton of WithReason functions unless there is no other way.

If I'm correct #785 implemented this, so maybe this issue can be closed?

I don't believe this has been fully addressed. While functions such as Kick and Ban have a separate WithReason, functions such ChannelMessagePin and GuildMemeberRoleAdd do not. Not sure if I should make it a separate issue.

@Cyb3r-Jak3 If you can, lets just make a ticket specific to what you've found.


No idea

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 294, in data
display = to_text_string(value)
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\py3compat.py", line 123, in to_text_string
return unicode(obj)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 0: ordinal not in range(128)
Traceback (most recent call last):
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 294, in data
display = to_text_string(value)
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\py3compat.py", line 123, in to_text_string
return unicode(obj)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 0: ordinal not in range(128)
Traceback (most recent call last):
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 294, in data
display = to_text_string(value)
File "C:\Users\apbar\Anaconda2\lib\site-packages\spyder\py3compat.py", line 123, in to_text_string
return unicode(obj)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 0: ordinal not in range(128)
T

What were you doing when you got this error?

Closing because of lack of response.


Fix building android_tensorflow_lib.

This commit fixes a build time failure of the Android TF library that is
missing some dependencies since they have been made more fine-grained.
For reference, the relevant errors (one per required dep) look something
like:
ERROR: tensorflow/tensorflow/core/BUILD:663:1: Couldn't build file tensorflow/core/_objs/android_tensorflow_lib/tensorflow/core/kernels/softsign_op.o: undeclared inclusion(s) in rule '//tensorflow/core:android_tensorflow_lib':
this rule is missing dependency declarations for the following files included by 'tensorflow/core/kernels/softsign_op.cc':

ERROR: tensorflow/tensorflow/core/BUILD:663:1: undeclared inclusion(s) in rule '//tensorflow/core:android_tensorflow_lib':
this rule is missing dependency declarations for the following files included by 'tensorflow/core/kernels/maxpooling_op.cc':

ERROR: tensorflow/tensorflow/core/BUILD:663:1: undeclared inclusion(s) in rule '//tensorflow/core:android_tensorflow_lib':
this rule is missing dependency declarations for the following files included by 'tensorflow/core/kernels/ctc_decoder_ops.cc':

ERROR: tensorflow/tensorflow/core/BUILD:663:1: undeclared inclusion(s) in rule '//tensorflow/core:android_tensorflow_lib':
this rule is missing dependency declarations for the following files included by 'tensorflow/core/kernels/avgpooling_op.cc':

Can one of the admins verify this patch?

@andrewharp since he's been dutifully maintaining this target
@damienmg because I don't understand why our Android test target is fine but according to Jenkins but users still run into this problem :)

I'd add a patch to make this show up in your default CI builds but I'm not sure what your build steps are. tools/ci_build doesn't seem to be the right place to be looking.

@darrengarvey Hi, are you building tensorflow/core:tensorflow_android_lib directly (as opposed to //tensorflow/examples/android:tensorflow_demo)? If so, you need to tell Bazel to actually build for Android, e.g. with the flag --fat_apk_cpu=armeabi-v7a
@vrv There's a select in android_tensorflow_lib_lite that nullifies attempts to build for non-Android, but not for android_tensorflow_lib. This is probably what's causing the misleading errors people are seeing. Jenkins always builds in an Android configuration so it's not catching this. I'll send a CL to fix this.

@darrengarvey You'll need a couple more flags in addition to fat_apk_cpu if you want to build the library by itself. Here's what worked for me:
bazel build -c opt tensorflow/core:android_tensorflow_lib --crosstool_top=//external:android/crosstool --cpu=armeabi-v7a --host_crosstool_top=@bazel_tools//tools/cpp:toolchain

Note that if you are building this for an app you'll probably want to wrap the cc_library in a cc_binary (see tensorflow/examples/android/BUILD for an example) so that unused code can be stripped out. Otherwise you'll end up with over 200mb of unnecessary size. Just make sure you export the symbols you want to reference so they don't get stripped as well.

@andrewharp - Thanks for the tips. I can build it using the command line above.
I replicated the switch in srcs from android_tensorflow_lib_lite and that also prevented the errors I was seeing while building correctly for android when I asked for that. I can raise a PR for that if you want / haven't already?
While this change makes it better, it might be more intuitive for users (like me) if this target failed to build with a message saying it should be built with android tools explicitly. Does it makes sense to build android_tensorflow_lib for anything except an android target? Then again I'm only new to bazel so it may well be just right as it is given the trade-off between build system complexity and user-friendliness.
Btw. I didn't have a problem building an app for Android using the docs and the android/BUILD example. I came across this error when trying to understand what steps bazel was doing internally in the android_binary command, just for curiosity's sake really.
I'm happy to close the PR if we can replace it with another as suggested by @andrewharp.

I've submitted an internal patch that will nullify the src for android_tensorflow_lib in the same way as android_tensorflow_lib_lite. I agree that an informative error message might be ideal, but I'm worried about erroneous failures in automated builds and tests (not everything we run TF through seems to respect manual and notap at this point). As a compromise I added a comment on the targets specifying the targets must be built for Android, and how to do so.

Sounds good to me. Thanks for the help @andrewharp and @vrv.


Use Python 3.8 instead of 3.9 for upload

Total shot in the dark here. Not sure why conda package upload is failing, but I'm going to try to use Python 3.8 instead of the default 3.9 install and see if that makes any difference.

Pull Request Test Coverage Report for Build 634023278

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.268%

Totals

Change from base Build 633917206:
0.0%

Covered Lines:
106

Relevant Lines:
339

💛  - Coveralls


Pilaf - WIP : Figma design for Room + Android fix design

WIP
Improving Room UI based on Figma.
Fixing tag alignement Issue
Fixing multi avatar z index issue
Fixing issue with Android.

@emerciercontexeo asked me to merge this (even though he can)


Progressbar stutter in Chrome 69

Bug, feature request, or proposal:
Bug.
What is the expected behavior?
Progressbar should not stutter (like in Chrome 68 for example).
What is the current behavior?
Progressbar stutters like going back and forward, when low interval is set.
Chrome 69.0.3497.81 (stutter):
https://webmshare.com/play/zBggW
Chrome 68.0.3440.106 (normal):
https://webmshare.com/play/NynnR
What are the steps to reproduce?
https://stackblitz.com/edit/progressbar-stutter
What is the use-case or motivation for changing an existing behavior?
N/A
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 6.4.7
Chrome 69.0.3497.81 (64-bit)
Is there anything else we should know?
I wasn't sure where to report this issue, here or Chromium tracker.

I could reproduce the issue. A couple of the quick standard solutions to these types of issues (using a 3d transform or adding will-change) didn't help.

+1


License file is corrupt in Next Major build.

Describe the issue
License file is corrupt in Next Major build.
Current and Next Minor are working as expected.
Scripts used to create container and cause the issue
AL-Go Action "Test Next Major" was used.

Full output of scripts
  Using license file 'c:\run\my\license.flf'
  Import License
  The license file is corrupt. Error Code: Unknown error.
  at <ScriptBlock>, C:\Run\SetupLicense.ps1: line 29
  at <ScriptBlock>, C:\Run\navstart.ps1: line 196
  at <ScriptBlock>, C:\Run\start.ps1: line 384
  at <ScriptBlock>, <No file>: line 1

Has the flf file type been deprecated?

Yes,
In 22 only bclicense works.

Thanks.
Maybe a better error would help?
My guess, I wont be the last not to have gotten the memo.
I've im wrong feel free to close the issue.

You are also not the first:-)
I will add a warning to container if you are trying to add a .flf in 22

Instead of a warning - next version will fail early if .flf is specified.

Shipped in 4.0.6


References have no date

A number of references have no date, and the citation shows "n.d." in the text. Any way to fix this?

Are they mine? Lmk which ones and I’ll fix   Otherwise if for other authors
then the only way to fix is for them to go and get the bib citation again.
On Sat, Feb 15, 2020 at 1:07 PM Brian Kim<EMAIL_ADDRESS>wrote:

A number of references have no date, and the citation shows "n.d." in the
text. Any way to fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Coleridge-2DInitiative_big-2Ddata-2Dand-2Dsocial-2Dscience_issues_26-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAD63AO5O7EAFRCBTDFFB5MDRDAVIBA5CNFSM4KV24V4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INZHLTA&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=NqIXSo-Qd97y4aHtYQuMl9sKuktVP8V4GWSmXuTypbw&s=dBtrINqsDXT2CVYoMS2zu5nRnBF-2V_7K64zEK-i6hI&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD63AO4SD3CDUYSGD2R5ECDRDAVIBANCNFSM4KV24V4A&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=NqIXSo-Qd97y4aHtYQuMl9sKuktVP8V4GWSmXuTypbw&s=58u0VZR3DUMx1_Cop8S0JHir2LoUtX8MdWrctaDArSE&e=
.

--
Julia Lane
Professor, Wagner School and Center for Urban Science and Progress
Provostial Fellow
Cell Phone<PHONE_NUMBER>

There's a few in the introduction. Looking at the first few paragraphs, there's (Kopf, n.d.), (Office of Management and Budget, n.d.),  (Hart, n.d.), at the end there's (SOSP, n.d.).

Ok.  Will find them and fix.   Thanks for finding. Is first thing tomorrow
ok?
On Sat, Feb 15, 2020 at 1:22 PM Brian Kim<EMAIL_ADDRESS>wrote:

There's a few in the introduction. Looking at the first few paragraphs,
there's (Kopf, n.d.), (Office of Management and Budget, n.d.), (Hart,
n.d.), at the end there's (SOSP, n.d.).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Coleridge-2DInitiative_big-2Ddata-2Dand-2Dsocial-2Dscience_issues_26-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAD63AOYSTGUYEF2LUBEHLUDRDAXEXA5CNFSM4KV24V4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3TUPQ-23issuecomment-2D586627646&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=LJ2hpxXRbJhsW1cUw2VNqB34Ytpj20cwVbZhFkR6fd4&s=LC24qeDaFkrnusti58GsmUje4YKcTY-o5L9e5CRUSL4&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD63AO67J6YT3UANAGLU5NDRDAXEXANCNFSM4KV24V4A&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=LJ2hpxXRbJhsW1cUw2VNqB34Ytpj20cwVbZhFkR6fd4&s=uTZ9rv9rt_PHOWo-iNY9rNa8Nr_WNJj0NJZYhKBaL1c&e=
.

--
Julia Lane
Professor, Wagner School and Center for Urban Science and Progress
Provostial Fellow
Cell Phone<PHONE_NUMBER>

I fixed some, but there are still a couple of "n.d."s left. They broadly fall into two categories:

Links to websites (that we might want to include as links rather than as references)
Software packages (for which we might find better references that do include a year).
For those we can't fix, however, "n.d." seems to be the proper APA solution:
https://apastyle.apa.org/learn/faqs/cite-website-material

Thank you so much
Yes, I think put just links to websites – and for software, just also
provide a link
Thanks, Christoph
Julia Lane
Professor, Wagner and CUSP, NYU
Cell phone:<PHONE_NUMBER>
https://coleridgeinitiative.org
From: Christoph Kern<EMAIL_ADDRESS>Sent: Tuesday, February 18, 2020 1:13 PM
To: Coleridge-Initiative/big-data-and-social-science <
<EMAIL_ADDRESS>Cc: Juliaingridlane<EMAIL_ADDRESS>Comment <
<EMAIL_ADDRESS>Subject: Re: [Coleridge-Initiative/big-data-and-social-science]
References have no date (#26)
I fixed some, but there are still a couple of "n.d."s left. They broadly
fall into two categories:

Links to websites (that we might want to include as links rather than
as references)
Software packages (for which we might find better references that do
include a year).
For those we can't fix, however, "n.d." seems to be the proper APA
solution:
https://apastyle.apa.org/learn/faqs/cite-website-material
https://urldefense.proofpoint.com/v2/url?u=https-3A__apastyle.apa.org_learn_faqs_cite-2Dwebsite-2Dmaterial&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=ONFZVzm2FEGbWNGRnCKxedh5oCOV9cJc7-Tza9qthvw&s=pyM6lXPil8E6HziyD6QU3S-Ncj6JZv_MX46uPpABlGU&e=

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Coleridge-2DInitiative_big-2Ddata-2Dand-2Dsocial-2Dscience_issues_26-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAD63AO3ZWIT2CCX2XS7UYVDRDQQKPA5CNFSM4KV24V4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDA4EI-23issuecomment-2D587599377&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=ONFZVzm2FEGbWNGRnCKxedh5oCOV9cJc7-Tza9qthvw&s=5uRb6izl3jUhSqVyhM2WN9fZadlBw8qxAIcayauhzBQ&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD63AOYIICQHNHCUABFXYDLRDQQKPANCNFSM4KV24V4A&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=omwcNBUqPba9pikmkXZXk2bFQ7zxZPhI5OH9dd8lFDA&m=ONFZVzm2FEGbWNGRnCKxedh5oCOV9cJc7-Tza9qthvw&s=KJdPSj4XSxfrqbEGCU5ihDY20-3CvObb1Z3EA9YXCeo&e=
.


Rough draft of StarCraftEnv client

Opening a PR on my own fork of gym so that we have a place to talk about the code.
This is a rough draft, not ready for public consumption
It's basically implementing the StarCraft Environment Spec that we put together last week.
You can try it out by running the mock server:
python examples/scripts/mock_remote_env_server.py

And the example agent:
python examples/agents/mouse_keyboard_agent.py;

Test using a mock API live in /gym/envs/starcraft/tests/test_starcraft_env.py with:
Would love feedback!

Oh, the C++ StarCraftEnvServer lives in another repo, will package it up over the next week or so.

Closed in favor of https://github.com/nottombrown/gym/pull/2


Update README.md

comment 123 213

leaving comment for sync

leaving comment for automatic sync

Hi

leaving comment for automatic sync 7/13 [1]

sync pleaseee 🤞

check sync

check after renaming repo

heyy check Jaxon 7/27 [3]


Beginner mode for "for" loops

Embedders can now specify beginner mode with a flag in the "categories" option:
//...
modeOptions: {
  categories: {
    loops: {
      color: "green",
      beginner: true
    }
  }
}
//...

This will make for loops of this form mark only "b":
for (var i = 0; i < b; i++) {
  //...
}

It is currently very picky about which loops it chooses to do this with; they must be exactly of the form (/*var*/ a = x; a < b; a++) and a must be the same identifier in all three expressions.

Oops, hang on, this has some extraneous changes. I'll make a new PR.


Add I Lo ozorkow

The school's website is lo-ozorkow.pl
The school offers cybersecurity classes.

@Niepper Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Get a Red Hat pull secret (optional)

TLDR
Update the page to indicate the red hat secret pull is important to ensure full cluster functionality.
Some clarification needs to be added to Get a Red Hat pull secret (optional). If you do not do this, since its optional, you cannot user the OperatorHub. The community-operations and redhat-marketplace pods will not deploy due to ImagePullBackOffs. The reason this occurs is due to a lack of authorization which appears to come from the red hat secret pull. This is a poor first experience and its not ever hinted that full functionality will not be available.
Additionally if its possible to do the pull after cluster creation instructions on how to get it working again should be outlined.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93aa980e-1970-235c-228a-7b19880171b8
Version Independent ID: 6f7937a4-12e0-d61c-3bd8-c6347ec48385
Content: Tutorial - Create an Azure Red Hat OpenShift 4 cluster
Content Source: articles/openshift/tutorial-create-cluster.md
Service: azure-redhat-openshift
GitHub Login: @sakthi-vetrivel
Microsoft Alias: suvetriv

@D3athByMonkey, Thanks for taking time to share your valuable feedback for Azure doc improvements! We are taking a look into this and will get back to you soon.

@D3athByMonkey Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.We will update you accordingly.

@sakthi-vetrivel Can you please check and add your comments on this doc update request as applicable

yes, help page should be more specific what features are missing if not providing a RH pull secret.
without a RH pull secret we are missing the catalog sources for the operator hub
tilo@TSDell:/mnt/c/ocp6$ oc get catalogsource -A
NAMESPACE               NAME                   DISPLAY                TYPE   PUBLISHER   AGE
openshift-marketplace   certified-operators    Certified Operators    grpc   Red Hat     101d
openshift-marketplace   community-operators    Community Operators    grpc   Red Hat     101d
openshift-marketplace   redhat-marketplace     Red Hat Marketplace    grpc   Red Hat     101d
openshift-marketplace   redhat-operators       Red Hat Operators      grpc   Red Hat     101d

also see https://github.com/Azure/OpenShift/issues/200

#reassign: @joharder

It looks like this is an older request. The current page specifies "A Red Hat pull secret enables your cluster to access Red Hat container registries along with additional content. This step is optional but recommended." Is a specific call-out for operator hub what is requested?
Also, we have instructions for adding the pull secret later here: https://learn.microsoft.com/en-us/azure/openshift/howto-add-update-pull-secret


swipe multiple sliders simultaneously

Describe the feature you'd like:
I'm currently implementing a feature with multiple synced carousels.
The problem is, that the swipe event for the other carousels only gets fired when the drag is over.

it would be nicer if the carousels would stay in sync while dragging (like it's implemented for the next / back button)

@pascaltan Is this figured out? I'm running into the issue, could you share a solution if possible? :)


[webview_flutter] add gesture navigation for iOS

Description
This introduces a boolean for the allowsBackForwardNavigationGestures setting of the WKWebView in iOS. It has no effect on Android.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Hi @wwwdata - thank you for the PR!
It seems like useful addition to the web view plugin.
Could you please rebase & also add a e2e test. You can find the existing e2e test suite in example/test_driver/webview_flutter_e2e.dart.
Once both done, we can proceed to the next step. Thank you once again!

@ened thanks for the fast response. I am a bit confused about the e2e tests. As far as I see it currently, they are basically running some quick unit tests but using the real platform for that, correct? What could I in my case add as a test? In order to test whether it works, I would really have to launch a WebView in iOS then find a link to tap on, which navigates forward, after that use a swipe gesture to navigate back again.
For now, I just added a test that is launching the WebView with my new feature to see that nothing crashes

@wwwdata That will do it for the moment. Among other behaviour, the key issue is to check whether the native component will load properly and received the right configuration.
Something I'm not sure yet is whether it's ok to no-op the test on Android. Understood it's a non-supported feature on Android, but if it ever will be in the future, the test may be missed.
Besides, the underlying platform implementation should not ignore parameters it doesn't know about.

Something I'm not sure yet is whether it's ok to no-op the test on Android. Understood it's a non-supported feature on Android, but if it ever will be in the future, the test may be missed.

You're right will remove the no-op. It should go through and really test that nothing bad happens.

@wwwdata After reading this a few more times, would you agree that gestureNavigationEnabled is more concise & clear to the developer that will use the webview widget?
It also seems to be in line with debuggingEnabled.

I agree with @ened that gestureNavigationEnabled works better as a cross-platform name.

Ok. New name makes sense! Thanks for already making the change.


Allow application type migration to be reversed

The migration to add the type of application to Application includes a
data migration through the RunPython operation. By
default, these operations are irreversible. Since reversing the
migration would drop the column, there's no harm in making the reverse
of the data migration a noop.

This will unblock #36.


Add CoinCat.in to the list of merchants

What's the name of your business?
CoinCat
What's the URL of the website?
https://coincat.in/
Write a brief description of your business/service (max 50 characters)
Buy and sell crypto in minutes.
Enter the URL where a Monero mention can be found
https://coincat.in/
https://coincat.in/en/exchange-CARDRUB-to-XMR
https://coincat.in/en/exchange-XMR-to-CARDRUB
How do you accept Monero? (choose only one option)

[ ] Monero integrations (github.com/monero-integrations)
[ ] Globee
[x] Native wallet
[ ] Other payment gateaway (Coinpayments, Morphtoken, etc. Please specify)

How would you categorize your business? (choose only one option)

[x] Exchange
[ ] Block Explorer
[ ] Payment Gateway
[ ] Web Hosting
[ ] Tool
[ ] Service
[ ] Goods
[ ] Entertainment

Comment

We offer fast crypto to fiat exchange service (at the moment for Russian users only)

Looks ok. Since the website is Russian only we should probably add something like (Ru) near the name.

#1525


Ideas for full ImGui docking branch support

Since 2018 ImGui has had support for viewports and docking.
Currently rlImGui, supports docking if you enable it like so:
ImGuiIO& io = ImGui::GetIO();
io.ConfigFlags |= ImGuiConfigFlags_DockingEnable;

However multiple viewports would be a challenge to implement:

You need to detect if multi-viewport support is wanted, maybe with a #define ENABLE_VIEWPORTS?
Using some surgry you can get raylib to use multiple windows!
Using the FLAG_WINDOW_UNDECORATED flag for SetConfigFlags we can remove the title bar of the new windows (for the full effect).

Finally, we will have full support of the docking branch. It won't be as simple as it looks, but it would be useful for many rlImGui users.
Maybe rlImGui can have its own docking branch which is used to experiment with viewports?

I am very aware of the docking branch of ImGui, and yes rlImGui supports it by using that exact code.
I do not intend to support multiple viewports in rlImGui in any way.
Since raylib does not and will not have a multi-window API, any support for viewports would be based on a specific fork. Those instructions are a general guideline and are not an official API. The actual implementation of multiple windows in raylib can vary.
If someone is going to maintain a fork of raylib with a multi-window API, they can also maintain a fork of rlImGui that uses that fork.
There is no benefit to having code that is reliant on a specific hacked up version of raylib inside of this repository. This is what forks are for. Doubling the maintenance cost of rlImGui for no clear benefit is not worth it.


Input label not floating when value is zero

Upgraded to v17 of Angular from v15, and now i see on my text inputs that the material label do not float/shrink
any longer when value is set to zero. Anything i forgot or missed that i need to do? Thank you.
NOTE: only happens when field is untouched

Angular version: 17x
Formly version: 6x

Hi,
could you please provide a reproduction, here is our stackblitz starter example:
https://stackblitz.com/edit/ngx-formly-ui-material
Thanks!


[Documentation] Code review guidelines & learning resources

Add GPokT to the main README
Add a foundation "code guidelines" only containing examples of comments
Add details on tending resolving comments and reviewing PRs
Add resources related to trees

@red-0ne @0xRampey @dylanlott @h5law Friendly bump on this.


Travis dies from vet and lint errors since #207 was merged

The command "make setup-gotools test" exited with 2.
Automated builds are broken until this issue is fixed.
/cc @michelleN, @sgoings

Automated builds are broken until this issue is fixed.

Isn't quite a correct statement. The reality is that current master is stable and still happily building in Travis. This build: https://travis-ci.org/kubernetes/deployment-manager/builds/107148732 is the build on master with @michelleN's change merged into master.
The issue I think you're referring to is that certain PR builds are failing due to the fact that the changes within PRs are cause some complaint from go vet/lint. An example would be this PR build: https://travis-ci.org/kubernetes/deployment-manager/builds/107360379#L408-L410
On lines 408 - 410 go vet is complaining about:
repository/persistent/persistent.go:35: struct field tag "_id" not compatible with reflect.StructTag.Get: bad syntax for struct tag pair

It's possible to teach vet to be less strict on some things... however I personally feel like it'd probably be best to stick with golang's vet suggestions.

@sgoings yes, I realized that. Fixed all the vet and lint errors in master. Then rebased persistence.

Just following up...
go lint is a tool that suggests changes but doesn't return non-zero exit codes when it finds things.
go vet is a tool that enforces change. It returns non-zero exit codes when it finds things.
go lint was producing lots of output + suggestions which you fixed up via #224 (Thanks! :+1:) but wasn't actually hindering the build process... just maybe being a bit too chatty :smile:. The go vet errors are still in existence with PR #224. go vet isn't happy in particular with:
persistence.go lines: 35 40 45
Which are changes in a new file introduced in that PR.

Yes, thanks.
Jack Greenfield | Google
On Fri, Feb 5, 2016 at 6:02 PM, Seth Goings<EMAIL_ADDRESS>wrote:

Just following up...
go lint is a tool that suggests changes but doesn't return non-zero exit
codes when it finds things.
go vet is a tool that enforces change. It returns non-zero exit codes
when it finds things.
go lint was producing lots of output + suggestions which you fixed up via
#224 https://github.com/kubernetes/deployment-manager/pull/224 (Thanks! [image:
:+1:]) but wasn't actually hindering the build process... just maybe
being a bit too chatty [image: :smile:]. The go vet errors are still in
existence with PR #224
https://github.com/kubernetes/deployment-manager/pull/224. go vet isn't
happy in particular with:
persistence.go lines: 35
https://github.com/kubernetes/deployment-manager/pull/170/files#diff-18acdc1aadcd8a42d3ce6fdf6f7d80c6R35
40
https://github.com/kubernetes/deployment-manager/pull/170/files#diff-18acdc1aadcd8a42d3ce6fdf6f7d80c6R40
45
https://github.com/kubernetes/deployment-manager/pull/170/files#diff-18acdc1aadcd8a42d3ce6fdf6f7d80c6R45
Which are changes in a new file introduced in that PR.
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/deployment-manager/issues/223#issuecomment-180658215
.


Yarn build fails

When I build the project, my js compile fails with the following error:
$ ./run yarn:build js_1        | ./run: line 111: /app/node_modules/.bin/esbuild: cannot execute binary file: Exec format error js_1        |  js_1        | Task completed in 0m0.024s error Command failed with exit code 126. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Manually reverting package.json to call "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds" successfully compiles.

Hi,
You should technically never need to run ./run yarn:build manually. It only ever gets called in the package.json file. It's meant to be something that gets run directly inside of the js container, not from your terminal outside of Docker.
That is also brought up with its comment of: # Build JS assets, this is only meant to be referenced from your package.json
But since that works differently than the other run commands, maybe I should turn both yarn:build and yarn:build:css into private functions by prefixing them with an underscore. That could get also get equally weird tho because they would be referenced in the package.json file which implies they're not private.

Hi,
You should technically never need to run ./run yarn:build manually. It only ever gets called in the package.json file. It's meant to be something that gets run directly inside of the js container, not from your terminal outside of Docker.
That is also brought up with its comment of: # Build JS assets, this is only meant to be referenced from your package.json
But since that works differently than the other run commands, maybe I should turn both yarn:build and yarn:build:css into private functions by prefixing them with an underscore. That could get also get equally weird tho because they would be referenced in the package.json file which implies they're not private.

Sorry, to clarify, I wasn't running them manually. This was with a docker compose up --build

Sorry, to clarify, I wasn't running them manually. This was with a docker compose up --build

Did you make any modifications to the Dockerfile or project?
Just asking because /app/node_modules/.bin/esbuild: cannot execute binary file isn't a path that should exist. This project installs your Node modules to /node_modules not /app/node_modules.

Did you make any modifications to the Dockerfile or project?
Just asking because /app/node_modules/.bin/esbuild: cannot execute binary file isn't a path that should exist. This project installs your Node modules to /node_modules not /app/node_modules.

No, the Dockerfile is the same as you have in master. A search through my project for '/app/node_modules' yields no results.

No, the Dockerfile is the same as you have in master. A search through my project for '/app/node_modules' yields no results.

What OS are you using and what version of Docker / Docker Compose do you have?
I can't reproduce this here on both Windows and macOS by following the instructions in the readme:
nick@kitt ~ $ git clone https://github.com/nickjj/docker-rails-example /tmp/hellorails
Cloning into '/tmp/hellorails'...
remote: Enumerating objects: 718, done.
remote: Counting objects: 100% (718/718), done.
remote: Compressing objects: 100% (460/460), done.
remote: Total 718 (delta 394), reused 539 (delta 224), pack-reused 0
Receiving objects: 100% (718/718), 655.57 KiB | 10.57 MiB/s, done.
Resolving deltas: 100% (394/394), done.

nick@kitt ~ $ cd /tmp/hellorails

nick@kitt /tmp/hellorails (main) $ cp .env.example .env

nick@kitt /tmp/hellorails (main) $ cp docker-compose.override.yml.example docker-compose.override.yml

nick@kitt /tmp/hellorails (main) $ docker-compose up --build

At this point everything comes up successfully and I can access the site in a browser.

What OS are you using and what version of Docker / Docker Compose do you have?
I can't reproduce this here on both Windows and macOS by following the instructions in the readme:
nick@kitt ~ $ git clone https://github.com/nickjj/docker-rails-example /tmp/hellorails
Cloning into '/tmp/hellorails'...
remote: Enumerating objects: 718, done.
remote: Counting objects: 100% (718/718), done.
remote: Compressing objects: 100% (460/460), done.
remote: Total 718 (delta 394), reused 539 (delta 224), pack-reused 0
Receiving objects: 100% (718/718), 655.57 KiB | 10.57 MiB/s, done.
Resolving deltas: 100% (394/394), done.

nick@kitt ~ $ cd /tmp/hellorails

nick@kitt /tmp/hellorails (main) $ cp .env.example .env

nick@kitt /tmp/hellorails (main) $ cp docker-compose.override.yml.example docker-compose.override.yml

nick@kitt /tmp/hellorails (main) $ docker-compose up --build

At this point everything comes up successfully and I can access the site in a browser.

MacOS with Docker Desktop 3.5.2, Engine 20.10.7, Compose 1.29.2.
This is a project that I updated to Rails 7 then merged with your recent updates.

MacOS with Docker Desktop 3.5.2, Engine 20.10.7, Compose 1.29.2.
This is a project that I updated to Rails 7 then merged with your recent updates.

What happens if you follow the steps in my previous comment? Does it work?

What happens if you follow the steps in my previous comment? Does it work?

Yes, installing clean from the repo works. I must have missed something in the update.

Yes, installing clean from the repo works. I must have missed something in the update.

I would check your .yarnrc file to make sure /node_modules is set and then diff your Dockerfile vs mine.

Dockerfile is exact. .yarnrc contains --modules-folder /node_modules, as is should.

I'm not sure then, it's still installing things in a way where that .yarnrc doesn't seem to have an effect because it's using /app/node_modules. I'd carefully comb through the commit where I upgraded to Rails 7 https://github.com/nickjj/docker-rails-example/commit/2a8580a7dcfca7f278a55cd6ab6bd03838e7275e although I did change the run script a bit after that commit, all of which are listed at https://github.com/nickjj/docker-rails-example/commits/main.

I've combed, no difference between my project configuration and the changes made in 2a8580a through 1071f7b.
Perplexing.

If you're able to clone this repo and spin up the app successfully I think it's safe to say there's something in your app which is preventing this from working?
You could always do a docker-compose down && docker-compose build --no-cache && docker-compose up on your end to give yourself a clean slate except for named volumes which will stick around such as for postgres. I don't think that will make a difference but it'll at least remove any notion that Docker is causing an issue with your custom app.
When in doubt you could diff the whole app too, not just the configuration looking for differences.

Fixed. For some reason, I had a hidden node_modules folder in the root directory of my project. Removing that quickly solve my issue. Thanks for you help. Closing.

No problem, thanks for including what the resolution was.

Just to add some more info for people who might be here in the future: I found myself facing this issue after using yarn locally to mess with running markdownlint outside of Docker. This created the /node_modules folder that caused issues. Be weary of doing something similar.


Support Range values

https://github.com/intridea/grape/pull/899

Yes, please contribute!

#209

Supplying a range to the :values option in grape v0.10.1, so maybe need to update grape version to v0.10.1 .

Closed via https://github.com/tim-vandecasteele/grape-swagger/pull/210.


detach() torch-based TensorMaps before saving them

When trying to save a TensorMap whose block values are torch.Tensor objects, an equistore error is raised if the values of the block have not been detached from their computational graph:
from equistore import io
...
# tmp is a torch-based TensorMap
equistore.io.save("tmp.npz", tmp)

gives error:
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
File /opt/miniforge3/envs/rho/lib/python3.10/site-packages/equistore/utils.py:31, in catch_exceptions.<locals>.inner(*args, **kwargs)
     30 try:
---> 31     function(*args, **kwargs)
     32 except Exception as e:

File /opt/miniforge3/envs/rho/lib/python3.10/site-packages/equistore/data/array.py:138, in _eqs_array_data(this, data)
    134     # `.numpy()` will fail if the data is on GPU or requires gradient
    135     # tracking, and the resulting array is sharing data storage with the
    136     # tensor, meaning we can take a pointer to it without the array being
    137     # freed immediately.
--> 138     array = array.numpy()
    140 if not array.data.c_contiguous:

RuntimeError: Can't call numpy() on Tensor that requires grad. Use tensor.detach().numpy() instead.

The above exception was the direct cause of the following exception:

EquistoreError                            Traceback (most recent call last)
Cell In[23], line 6
      2 from rholearn import utils
      4 tmp = utils.tensor_to_torch(input, True, torch.float64, torch.device("cpu"))
----> 6 equistore.io.save("tmp.npz", tmp)

File /opt/miniforge3/envs/rho/lib/python3.10/site-packages/equistore/io.py:61, in save(path, tensor, use_numpy)
     59 else:
     60     lib = _get_library()
---> 61     lib.eqs_tensormap_save(path.encode("utf8"), tensor._ptr)

File /opt/miniforge3/envs/rho/lib/python3.10/site-packages/equistore/status.py:37, in _check_status(status)
     35 e = LAST_EXCEPTION
     36 LAST_EXCEPTION = None
---> 37 raise EquistoreError(last_error(), status) from e

EquistoreError: external error: calling eqs_array_t.data failed (status -1)

Ideally, as saving destroys pointers to the graph anyway, the equistore.io.save function should detach block values tensors before serialization, using Tensor.detach().

After discussion in the dev meeting today, we have decided to introduce to_torch() and to_numpy() functions. These should also be included as inplace class methods of TensorMap and TensorBlock.
Linked to #70.


Will this work for a ReactJS  SPA ?

Hi,
I'm trying to get a token for the ACS API dynamically, instead of going to Azure Portal and using the "Identities & User Access Tokens" generate button and pasting them in the apps.
I already have a ReactApp that uses Azure AD and MSAL...
ReactDOM.render(
    <React.StrictMode>
        <MsalProvider instance={msalInstance}>
            <App />
        </MsalProvider>
    </React.StrictMode>,
    document.getElementById("root")
);

Trying to find out what are the next steps I saw this code that is for node in JS.  Think that something like this can be implemented on the App.js and pass it as a props to all the other controls.
async function createIdentityAndIssueToken(resourceEndpoint) {
    const client = new CommunicationIdentityClient(resourceEndpoint, credential);
    return await client.createUserAndToken(["chat"]);
}

Is there any example or clear documentation on how to create a Token based on an Azure AD identity?
Thanks for the great work!

Azure Communication Services requires developers to generate user and access token credentials inside of a trusted authentication service.
Here's how you can build a trusted service using:

Azure Functions
Node.js

Related GitHub repository

.NET

Related GitHub repository

Please never try to run code that requires access to secrets  (CLIENT_SECRET or connection string) from the client-side JavaScript. Any implementations of the TokenCredential that access secrets (e.g. EnvironmentCredential, ClientSecretCredential, etc.) are considered unsafe to be used from the client side. InteractiveBrowserCredential is not yet supported by ACS.
async function createIdentityAndIssueToken(resourceEndpoint) {
    // Don't use this from client-side JS
    const client = new CommunicationIdentityClient(resourceEndpoint, credential);
    return await client.createUserAndToken(["chat"]);
}

Is there any example or clear documentation on how to create a Token based on an Azure AD identity?

Azure Communication Services is identity-agnostic, to learn more check out our conceptual documentation. Specifically, pay attention to the section about Identity mapping.
If your Azure AD identities have MS Teams licenses assigned, you can use ACS<->Teams interoperability. Please follow this tutorial.

Closing this issue as @petrsvihlik  as provided a response above. @fpereiramapfrepr  feel free to re-open if you have any additional comments or questions pertaining to this github issue.

Thanks for the information! Already working on an Azure Function to build a trusted service.


Are there any examples to show how to use this library?

The otc library implements a simple oblivious transfer (OT) protocol and relies on oblivious; there is a short tutorial/overview of otc here: https://medium.com/nthparty/privacy-preserving-information-exchange-using-python-1a4a11bed3d5. The oprf library also uses oblivious, and one example of a real-world application of OPRFs (using a similar JavaScript OPRF library) is this paper: https://dl.acm.org/doi/10.1145/3209811.3212699.
More generally, this library's target audience is developers (1) who are already familiar with the underlying mathematics and (2) who want to quickly implement for full-stack and/or cloud-based environments published MPC protocols (or their own protocol variants) that rely on elliptic curve primitives. It is not intended as a general-purpose library for implementing secure computation workflows, though with some work that is certainly possible to do.
We hope this helps!


New: Install VS Code debugger extensions

Install automatically VS Code debugger extensions for Chrome an Edge

Ref: #46

love it, thanks!

why do you need to refreshenv?

@gep13 can say more, but I believe it's because code will not be in the path after doing choco install -y vscode and it is required in order to install the extensions.

That is what I suspect it required yes. I ran into this during a demo I was given.
Also, here in this package:
https://chocolatey.org/packages/vscode-powershell
A refresh is required, or at least, it was.

One Thought,  just have choco vs code and the vs packages to refresh. Where does one submit a PR for those?

@crutkas said...
One Thought, just have choco vs code and the vs packages to refresh. Where does one submit a PR for those?

I am not sure that I follow your train of thought here.  Can you please elaborate?

sorry, if we need to do a refresh for the environment, wouldn't the better spot to do the adjustment is actually in the choco package?  that way everyone gets the update versus only someone that uses our scripts

sorry, if we need to do a refresh for the environment, wouldn't the better spot to do the adjustment is actually in the choco package? that way everyone gets the update versus only someone that uses our scripts

@crutkas unfortunately Windows doesn't quite work that nicely. Even if those packages call Update-SessionEnvironment (aka refreshenv for PowerShell.exe), it won't matter once the choco.exe process exits and it moves back up to the powershell.exe process. A subprocess can update the environment variables all it wants in that process, and when it exits, the parent process won't see the changes. If it makes permanent changes to User/System environment variables, that also won't be seen in command shells until the shell is closed and reopened.
Chocolatey however has a concept of refreshenv, that will review the changes in the registry and update the process environment variables with the changes. There is refreshenv.cmd for cmd.exe command shells, and there is Update-SessionEnvironment, which is aliased to refreshenv when the Chocolatey PowerShell profile is installed. As you can guess, running refreshenv in PowerShell without that profile loaded, it's going to call refreshenv.cmd, starting a cmd.exe subprocess, updating those environment variables in that subprocess, and then exiting and having no changes to the current PowerShell.exe command shell.
Does all of that make sense?

@ferventcoder so if I've understood correctly I have to replace refreshenv with Update-SessionEnvironment in this PR?

@molant since everything here is running in PowerShell, yes, that would be the safest thing to do.


SDK 0.17.x is very chatty logging Service Bus messages

Hi,
I'm wondering if this is the intention of the new auto-dependency collection code or not, but the Azure Service Bus Node.js library uses REST for long polling; I'm processing hundreds of thousands of service bus messages, including trying to see if messages are available, and now the general App Insights views are useless to me since all I see are service bus dependency events.

Thoughts on what the right approach might be? You can see the uptick in the picture when I turned on the new message bus processing code.
I'm happy to ignore the dependency view, but it feels like maybe that is not right... or do I need to configure in my app insights options that I have no interest in the service bus domains logging all of its goo?

another example, now with 30-day time window

This is definitely not a good experience out of the box, we will review it.
As a workaround for now you can create a telemetry processor that will filter out all dependency calls made to this domain: https://github.com/Microsoft/ApplicationInsights-node.js/blob/33a7e7406db020fb4568d303fc2ca08307257f05/README.md#telemetry-processor

#156 allows adding a Service Bus URL to a list of excluded domains for dependency calls auto-collection.
Do you think Azure Service Bus should be added to the excluded list by default, similar to Azure Storage?

Thanks - thinking about this more, while I clearly would want to exclude it, I do not think all users would - and the behavior of app insights dependency work does not impact service bus or break it, so it's a different situation. Many users might want that data...

Sorry, I misunderstood the issue. The #156 will only disable the correlation headers, which were breaking Azure storage communication.
This won't help in your case. I think the only solution is to use a telemetry processor as @SergeyKanzhelev suggested.

I think a telemetry processor was the correct solution here. These were all valid dependency calls, any of which could have failed or taken a strange duration (which is valid telemetry). We can try to be smart about detecting potential long polls or edge cases of well-known dependencies, but that seems like it has the potential to eliminate valid data that autocollection was intended to collect.
If this isn't good OOB, perhaps this should be fixed at the UI level? @SergeyKanzhelev  @KamilSzostak thoughts? Okay to close?

Recently was reviewing our monthly bill and noticed that we have about $1,000/mo. currently of data overage coming from logging these Service Bus events as well as Redis dependencies.
The Redis dependencies are easy enough to configure away with the environment variables, but for Service Bus, I'm having a hard time... if I use a telemetry processor that just logs/outputs all data from the envelope, I am not seeing the outgoing HTTP requests being sent to the telemetry processor at all. Does this sound like something you would expect, or a bug?
As a result, I'm having a hard time figuring out how to skip logging these outgoing HTTP requests to Service Bus...
Appreciate any insights!

Every telemetry item should be routed through all registered telemetry processors before transmission (unless any telemetry processors in the chain reject the item of course), If you are seeing any telemetry that the SDK is able to send without calling your telemetry processor, that is definitely a bug.
This logic is handled at the track method (https://github.com/Microsoft/ApplicationInsights-node.js/blob/develop/Library/Client.ts#L296). I don't see anything obvious that would let any items make it past the telemetry processor stage and still make it to transmission (the call to channel.send).
Could you share your logging telemetry processor?

Thanks for your response. I haven't been able to look into this but will get on it soon. Appreciate you taking the time!

Closing for now. @jeffwilcox, please reactivate with the code for telemetry processor, if you are still seeing the issue.


Error HH205: Tried to call runSuper from a non-overridden definition of task hhgas:start

This happens if the test task is run with --parallel or if the reporter is enabled when solidity-coverage runs.
The handling for those cases should just return and allow the test task to continue.
https://github.com/cgewecke/hardhat-gas-reporter/blob/98168761bf5d771940c9f00fd5ad53ddeb5b214f/src/index.ts#L110-L120

Fixed in 2.0.2


nixos-artwork: make the standard nixos grub background default

Motivation for this change
2 reasons really:

the current desktop experience is not particular uniform - grub will show a background with the Nix logo after which sddm will then proceed to show the stock KDE background. In this first iteration, it will be the same image all the way from grub over sddm to KDE splash.

I am personally not a fan of the stock KDE look. The feedback on various fora indicates that
I'm not alone in this.

The package does its work by creating modified versions of Breeze for SDDM and Plasma that has the default grub background image instead of the default KDE backgrounds. We then replace a few names, but otherwise it's same as regular breeze to avoid having to maintain a full theme.
I understand that it can be controversial due to changing a default setting (the SDDM theme), but the changes to the Plasma theme only take effect for a new user/profile.
This is the first step towards a slightly more uniform look.
Things done

[X] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS

[X] Fits CONTRIBUTING.md.

I actually like the Plasma artwork! But, I have no problem making the default adhere to the NixOS artwork better. My one request is to add a NixOS configuration option to use the stock artwork (if for no other reason than testing) like services.xserver.desktopManager.kde5.stockArtwork which would default to false, but disable the modifications if true.
As far as consistency, there is a Plasma GRUB theme, but I haven't figured out how to apply it yet!

My intention is to have a single option that sets a background image which will then carry all the way through grub/systemd -> plymouth -> sddm -> kde for consistency.
I'll add in the setting you requested.
Any thoughts on simply patching the provided themes instead of having a proper fork of them?

Having a real fork of the themes would make it easier to track upstream changes. Also, if it's a true fork and a standalone package, we can just have an artwork NixOS option that takes an artwork package, opening users up to (potentially) more than just the two options presented here!

KDE is doing a similar thing:
https://community.kde.org/KDE_Visual_Design_Group/Unified_Login

As the new KDE look is MUCH nicer, there isn't a point to maintain a fork of the theme.


update Firefox add on page

old screenshots being used of I2P site https://addons.mozilla.org/en-US/firefox/addon/i2p-in-private-browsing/

I2P Java logo being used here - change to I2P in private browsing mode icon:

Updated the logo, uploaded new screenshots, have to replace on both site and AMO page before they can go live


Fixed error when Regex matching

The regex match function will return the whole match, you will need to iterate over it with .exec()  in order to get multiple matched groups. The javascript will throw an exception if you try to get [1] as urls will only match once.
Working demo: http://jsfiddle.net/kus3ow4e/
Source: https://stackoverflow.com/questions/19913667/javascript-regex-global-match-groups
Changes
-Removed jQuery, it's too heavy and not necessary, replaced with vanilla JS
-Added style, animation and fonts to header and buttons
-Replaced multiple buttons with a single and stylish dropdown
-Header is now a link for your repository
-Fixed regex match operation so it will work properly

Thanks for your work @arthurgeron, really appreciated. I will grab this tonight and have a look and merge it if everything is alright.

Changed buttons Spacing, shadow size, as well as the extension size itself.
Removed JSECoin from blacklist.

On second thoughts, I do not really like the style of too rounded buttons. I would rather see something similar to Github's buttons (slightly rounded and a bit more padding). Regarding the whitelist button, I would suggest making it a dropdown button kind of like Bootstrap's one.
Regarding the other changes, could you split them up in different PRs? It makes it hard to track and merge, and there is some overlapping work on my side with your changes. I have by the same occasion added a wiki page regarding contribution guidelines:  https://github.com/keraf/NoCoin/wiki/Contributions
I will also be in touch with you shortly regarding the Opera Store extension ownership.

Hey, I've made the changes you requested.
I really don't have much free time now, I'm being overwhelmed by work and college assignments and I'm about to get my Bachelor degree.
Separating functionalities into separate branches and doing separate PRs would take a lot of effort and time, time I do not have now, so I hope you're able to verify and test the changes and take your own conclusions. Have a great day/night 💃

Thanks for the changes. Unfortunately I'm quite busy too and it would take me some time mergining the changes in. I would suggest you to maybe re-fork the repo to have a clean base, while still keeping your changes on the side, and submit PRs for the changes you want to get in (for example the design changes). Good luck with your work and studies!


Prevent the creation of Loggers in the Hotpath.

Pull Request type

[x] Bugfix
[ ] Feature
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
This PR moves all loggers to be available through a companion object.
This will prevent instances of loggers to be created as part of the request execution/hotpath.
Although this was initially identified in the DataFetcherInvoker, via a JFR analysis, we are also
favoring consistency and apply the same pattern across all components.
From the image below the time associated with creating the logger per DataFetcherInvoker is visible on the right.

Nice find!

@berngp the above analysis was done w/ JFR? Anything special to get that going - or just follow their docs? I have been interested in looking into JFR more and the above reminds me about it. Thx for that.

@bono007 the specific graph above is generated by an internal tool we have. That said, I use JMC to do some further analysis on generated JFR files for jvms that I run locally or remote instances in test. There is a decent guide here. Note that in Mac OS you will most likely need to start JMC from the command line. Tip, use JDK 11+.
JMC can attach to running instance and do Flight Recording or you can use jmcd to create a jfr and then open it in JMC.
You could attach to a running JVM, jps -f to see the instances running.
jcmd <pid> JFR.start duration=60s filename=myrecording.jfr settings=profile

You could also have the JVM generate a JFR at startup time if you are interested on how the jvm looks like when its booting up.
-XX:+FlightRecorder -XX:FlightRecorderOptions=stackdepth=1024 -XX:StartFlightRecording=duration=30s,filename=/some/path/to/mystartuprecording.jfr

My 2¢, to analyze the request path you want...

Have a jvm that has been already running and in a steady state.
Be able to generate the request you intend to analyze.
Be ready to capture a flight recording which time window is sufficient to capture that particular request and doesn't extend too much. This will avoid noise in your JFR.
Coordinate when you start sampling/capturing for you JFR and send the request(s). Attempting to minimize noise in the jvm by stopping other things that are not related with that particular request you intend to analyze. If possible isolate the jvm and have only one request go through or have requests go trough in sequence where you wait for the previous to complete before you generate a new one.


Type conflict / Update to unified v10

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
<EMAIL_ADDRESS>Link to runnable example
No response
Steps to reproduce
I've tried to update @types/unist to v3 from v2, but that causes a type error when trying to give Remark a list of plugins:
Type '() => (tree: Node) => Node' is not assignable to type 'Pluggable<any[], Settings>'.
  Type '() => (tree: Node) => Node' is not assignable to type 'Plugin<any[], Settings>'.
    Type '(tree: Node) => Node' is not assignable to type 'void | Transformer'.
      Type '(tree: Node) => Node' is not assignable to type 'Transformer'.
        Type 'Node' is not assignable to type 'void | Error | Node<Data> | Promise<Node<Data>> | Promise<void>'.
          Type 'Node' is not assignable to type 'Node<Data>'.
            Types of property 'data' are incompatible.
              Type 'import("[...]/node_modules/.pnpm/@types+unist@3.0.0/node_modules/@types/unist/index").Data | undefined' is not assignable to type 'import("[...]/node_modules/.pnpm/@types+unist@2.0.6/node_modules/@types/unist/index").Data | undefined'.
                Type 'import("[...]/node_modules/.pnpm/@types+unist@3.0.0/node_modules/@types/unist/index").Data' is not assignable to type 'import("[...]/node_modules/.pnpm/@types+unist@2.0.6/node_modules/@types/unist/index").Data'.
                  Index signature for type 'string' is missing in type 'Data'.

178       remarkPlugins={[remarkEntityLinks]}
                          ~~~~~~~~~~~~~~~~~

This seems to be, because react-remark is still using<EMAIL_ADDRESS>which intern is still depending on<EMAIL_ADDRESS>Expected behavior
The types work with the most up to date versions of @types/unist
Actual behavior
There is a type conflict in the Node type between @types/unist@2 and @types/unist@3
Runtime
No response
Package manager
No response
OS
No response
Build and bundle tools
No response

Thanks for reaching out @reckter! 👋
This is a duplicate of #50
The next major release will support unified 11 and remark 15 (currently in the process of being released) based off the work in https://github.com/remarkjs/react-remark/pull/39
As noted in https://github.com/remarkjs/react-remark/issues/54 there are a few higher priority releases that need attention before I'll finish this.
If you are interested feel free to work on any of the checklist of planned changes in https://github.com/remarkjs/react-remark/pull/39 to help accelerate that time-line.


no response from backend

Hi,
I've got a problem, installing librephotos on my NAS. It's a Synology with an Atom.
I installed it using your compose-file. All containers are running. I just need to add the proxy to my brdige network and i was able to connect to the frontend over port 3000.
CONTAINER ID        IMAGE                                      COMMAND                  CREATED             STATUS                PORTS                  NAMES
10f9de80d73b        reallibrephotos/librephotos-proxy:dev      "/docker-entrypoint.…"   12 minutes ago      Up 12 minutes         <IP_ADDRESS>:3000->80/tcp   librephotos-proxy
5ed6c2be6935        reallibrephotos/librephotos-frontend:dev   "/bin/sh -c ./run.sh…"   12 minutes ago      Up 12 minutes         3000/tcp               librephotos-frontend
0c9743f502b2        reallibrephotos/librephotos:dev            "/bin/sh -c ./entryp…"   13 minutes ago      Up 13 minutes         80/tcp                 librephotos-backend
6fdf7bc647a6        postgres                                   "docker-entrypoint.s…"   15 minutes ago      Up 15 minutes         5432/tcp               librephotos-db
9a049db72a7b        redis                                      "docker-entrypoint.s…"   15 minutes ago      Up 15 minutes         6379/tcp               librephotos-redis

When I try to login, i've got the following error message. The browser never receives a response for the call to *:3000/api/auth/token/obtain/.

I checked the log of the backend container and got the following:
 * Restarting nginx nginx
   ...done.
./entrypoint.sh: line 29:    52 Illegal instruction     (core dumped) /miniconda/bin/python manage.py shell <<EOF
from api.models import User

if User.objects.filter(username="$ADMIN_USERNAME").exists():
    admin_user = User.objects.get(username="$ADMIN_USERNAME")
    admin_user.set_password("$ADMIN_PASSWORD")
    admin_user.save()
else:
    User.objects.create_superuser('$ADMIN_USERNAME', '$ADMIN_EMAIL', '$ADMIN_PASSWORD')
EOF

Running backend server...
[2020-12-10 08:23:25 +0000] [56] [INFO] Starting gunicorn 20.0.4
[2020-12-10 08:23:25 +0000] [56] [INFO] Listening at: http://<IP_ADDRESS>:8001 (56)
[2020-12-10 08:23:25 +0000] [56] [INFO] Using worker: gevent
[2020-12-10 08:23:25 +0000] [60] [INFO] Booting worker with pid: 60
[2020-12-10 08:23:25 +0000] [61] [INFO] Booting worker with pid: 61
[2020-12-10 08:23:27 +0000] [62] [INFO] Booting worker with pid: 62
[2020-12-10 08:23:28 +0000] [63] [INFO] Booting worker with pid: 63
[2020-12-10 08:23:30 +0000] [64] [INFO] Booting worker with pid: 64
[2020-12-10 08:23:30 +0000] [65] [INFO] Booting worker with pid: 65
[2020-12-10 08:23:32 +0000] [66] [INFO] Booting worker with pid: 66
[2020-12-10 08:23:32 +0000] [67] [INFO] Booting worker with pid: 67
[2020-12-10 08:23:34 +0000] [68] [INFO] Booting worker with pid: 68
[2020-12-10 08:23:34 +0000] [69] [INFO] Booting worker with pid: 69
[2020-12-10 08:23:37 +0000] [70] [INFO] Booting worker with pid: 70
[2020-12-10 08:23:37 +0000] [71] [INFO] Booting worker with pid: 71
[2020-12-10 08:23:39 +0000] [72] [INFO] Booting worker with pid: 72
[2020-12-10 08:23:39 +0000] [73] [INFO] Booting worker with pid: 73

Any idea whats going wrong?
BTW: Thanks for reviving the project!!! 😃

It looks like the backend server can't connect to the db, because it can't execute the command in the entrypoint.sh to create the admin user. Maybe it is a linking issue within the Synology Os? I would try updating the Synology docker add-on and trying it again. Do you use other services that are linked with docker-compose?
No Problem! :D

just checked db and redis
admin@NAS:~$ sudo docker logs librephotos-db
PostgreSQL Database directory appears to contain a database; Skipping initialization

2020-12-10 08:20:38.517 UTC [1] LOG:  starting PostgreSQL 13.1 (Debian 13.1-1.pgdg100+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit
2020-12-10 08:20:38.519 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2020-12-10 08:20:38.519 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2020-12-10 08:20:38.636 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2020-12-10 08:20:38.643 UTC [25] LOG:  database system was shut down at 2020-12-10 08:20:36 UTC
2020-12-10 08:20:38.654 UTC [1] LOG:  database system is ready to accept connections

admin@NAS:~$ sudo docker logs librephotos-redis
1:C 10 Dec 2020 08:20:37.796 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 10 Dec 2020 08:20:37.797 # Redis version=6.0.9, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 10 Dec 2020 08:20:37.797 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
1:M 10 Dec 2020 08:20:37.799 * Running mode=standalone, port=6379.
1:M 10 Dec 2020 08:20:37.799 # WARNING: The TCP backlog setting of 511 cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of 128.
1:M 10 Dec 2020 08:20:37.799 # Server initialized
1:M 10 Dec 2020 08:20:37.799 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
1:M 10 Dec 2020 08:20:37.800 * Loading RDB produced by version 6.0.9
1:M 10 Dec 2020 08:20:37.800 * RDB age 3 seconds
1:M 10 Dec 2020 08:20:37.800 * RDB memory usage when created 0.77 Mb
1:M 10 Dec 2020 08:20:37.800 * DB loaded from disk: 0.000 seconds
1:M 10 Dec 2020 08:20:37.800 * Ready to accept connections

seems to work fine.
docker and compose are the "latest" versions from synology. but they are old...
admin@NAS:~$ sudo docker -v
Docker version 18.09.8, build bfed4f5
admin@NAS:~$ sudo docker-compose -v
docker-compose version 1.24.0, build 0aa59064

I was able to manual update the binaries to the real latest ones.

Okay it seems to be an old issue: https://github.com/hooram/ownphotos/issues/10
Will push an update soon. It is wrong in the dockerfile.

I created a new image.  It should work now. If it does close the issue :)

Seems to work. I was able to login and browse through the frontend. 👍
But the Backend does not scan photos. My volumes are
      - /volume3/docker/librephotos/photos:/data
      - /volume3/docker/librephotos/media:/code/protected_media
      - /volume3/docker/librephotos/logs:/code/logs

I put some photos to the photos folder und click on:

backend-log show on click:
<IP_ADDRESS> - - [2020-12-10 20:58:51] "POST /build/ HTTP/1.1" 200 139 0.001794

You need to log in as the demo user and set up the directory for the demo user. To do this, click the top right button, and go to "Admin Area". On this page, it will show a list of users. Set the "Scan Directory" for the demo user by clicking the editing button:

After that you can go to Dashboard - Library and click the green "Scan photos (file system)" button.

now it works!
sorry for my mistake. i thought i had scanned the entire interface for settings. 😄

do you need some help with docs?
like "how to add a folder to scan to"? 😄
or how to install librephotos on a Synology NAS?

Yes that would be great! Open a pull request or write me on discord if you have some docs :)

You probably missed the step renaming librephotos.env to .env

Você provavelmente perdeu a etapa de renomeação de librephotos.env para .env

I ran the process of copying librephotos.env to .env and changed the folder variables and nothing. I don't know where I saw that the user is admin and the password is admin and that it could be changed in the .env but in the env there is nothing mentioning the user and password of the interface


added the TOML Spec link to the documentation

The issue
https://github.com/pypa/pipenv/issues/3629
The fix
Added a link to the TOML Spec under General Recommendations & Version Control to clarify how Pipfiles should be written.

The changes look good to me. Would you mind adding a file at news/3629.doc describing this change?

@NicholasSurmava I'm OK with this PR but a little tweek that news name should be 3629.doc.rst

@NicholasSurmava I'm OK with this PR but a little tweak that news name should be 3629.doc.rst

I actually named the file as such but did left out the .rst extension in the commit message... Slight oops.

@NicholasSurmava I meant doc not docs

I just went ahead and renamed it

Awesome. Thank you. I missed the typo...


[Bug]: Issues with the Cart!

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Cannot add or remove a particular product. The quantity is not visible either. Also, there is no total being displayed at the checkout.
Add Screenshots / Video Clip
[
https://github.com/user-attachments/assets/0428a6f4-e290-40ce-a29f-b6f52a385cb6
](url)
What browsers are you seeing the problem on?
Chrome
Agreements

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC contributor
[ ] I'm a Hacktoberfest contributor
[ ] I want to work on this issue [Optional]
[X] I'm willing to provide further clarification or assistance if needed.

Did not realise that the screen recording was not proper, here is the proper one!
https://github.com/user-attachments/assets/88e76ebb-e0ca-4b2b-9247-9af047ff19a6

Proceed!

Please assign me this issue.

Any update?