Functional test to exhibit bug: strategy="atomicSet" does not atomically update a database record

Beta13 introduced @malarzm 's https://github.com/doctrine/mongodb-odm/pull/1096 which helps make Doctrine ODM atomically insert and update records.
I was just checking my application and in which I have been experiencing data loss & corruption but I see the problem is still not fixed, even with atomicSet enabled using beta13.
I believe the problem may be that the solution introduced in https://github.com/doctrine/mongodb-odm/pull/1096 does not correctly handle embedMany's that are nested inside each other when changes are made to the embedded collection which is 2 levels down.
In this PR, I demonstrate this problem by creating a Book object which has 1 Chapter .. and where the chapter has 1 Page.  (book->chapters->pages) When I save the object using strategy="atomicSet", everything is saved in a single atomic operation - this is very very good.
However, when I load the object from the database and try to add a new Page to the chapter, Doctrine executes two separate queries. For me, this means continued data loss & corruption.
Here's how to reproduce the failing test:
phpunit --filter testAtomicSetWorksAsExpected

output:
PHPUnit 4.1.6 by Sebastian Bergmann.

Configuration read from /mongodb-odm/phpunit.xml

F

Time: 1.44 seconds, Memory: 21.25Mb

There was 1 failure:

1) Doctrine\ODM\MongoDB\Tests\Functional\VersionTest::testAtomicSetWorksAsExpected
Despite use of atomicSet, 2 queries were detected when flushing this change. We expected only one query.
Failed asserting that 2 matches expected 1.

/mongodb-odm/tests/Doctrine/ODM/MongoDB/Tests/Functional/VersionTest.php:77

FAILURES!
Tests: 1, Assertions: 2, Failures: 1.

@blockjon for reasons unknown to me yet your test passes if the parent document is not versioned

Ok, I have found what goes wrong but I'm still wondering what versioning has to do with that

@blockjon So summing up yes, this is my oversight that deeply nested collection is excluded from update. Most probably I will be able to fix it by tomorrow, or if you are willing to do this on your own the problem lies here as we should check all the way up to top level document if the collection isn't deeply embedded within atomic one.

@malarzm Wow thank you for responding so quickly to this. Since you know the ins and outs of this far better than me, I would prefer to wait and have you triage if that's ok.

@blockjon you can also try calling $this->uow->scheduleCollectionUpdate($book->getChapters()); by yourself if you know that collection within atomic collection neds to be updated. It's dirty but should be working, at least the test is passing :)

@malarzm Thanks for your idea above.. the app I'm hacking on has too many cases where that would need to be done... I think I would prefer to opt for something that handles this automagically.

@blockjon I'm sorry but I'm still fighting with dragons and releases and I'm not sure if I will be able to fix this today (and because I'm out of town tomorrow, Friday is first possible day I will have a computer nearby)

@malarzm Thanks for the update. I've waited this long I can wait until Monday for sure. Basically I'm seeing about 1 terrible data corruption per week at my current levels. So, worst case I get one this weekend but if you can possibly get this fixed, you will instantly make my life better after Monday. Thank you for all of you attention with this so far!!!

@blockjon: We copied your test case into #1118, which is now fixed and merged.


Question

Very nice!
Tho I'd like to ask something directly, since you're more familiar with the code.
If I wanted to not receive duplicate frames when there's no change, how should I go about altering the functions so it'd return just the new data and a value of number of how many frames have been the same so far ? Thanks in advance :)

The Windows Desktop Duplication API itself doesn't return duplicate frames. I added that functionality to have a consistent buffer where frames are tied to time. Thankfully, it should be easy to modify for your use case since it's handled in Python and not the DLL sections.
Check this out: https://github.com/SerpentAI/D3DShot/blob/master/d3dshot/d3dshot.py#L279
Just adapt the else clause to your needs.

Oh, the timing is even in the same call. Thanks o/. Cheers.


Wait for descriptor write complete on start notifications / Wait for callback

Android:Start notifications on android fails sometimes, a cause might be that we are not waiting for the descriptor write to complete (check gatt callback).
iOS: wait for event UpdatedNotificationState after start/stop notifications
Linked to #94

Closed in 1.1.0-beta3


Latest version number discrepancy

In tags/npm, it's referred to as v3.4.2, but in the changelog it's referred to as v3.4.1

yes, I made a small mistake while publishing the 3.4.1 version and had to re-release it as 3.4.2… I forgot to update the version number on the changelog :see_no_evil:  thanks for the hint


Is it possible to minimize the used request to download posts by providing an index of the last downloaded post?

My Idea is:

I am downlaoding posts from a profile but this profile has too many posts for the Rate Limits of Instagram.
Instaloader returns an index of the currently loaded posts
If I let the Instagram Limits settle I can restart Instaloader and provide the Index from before so I dont need to waste requests for the other already downloaded posts.

Is this possible to realize?

Is it something like the resume iterator which is already available?
Have a look at the manual:
https://instaloader.github.io/module/nodeiterator.html and
https://instaloader.github.io/cli-options.html#cmdoption-resume-prefix


Correctly remove/re-enroll device from Azure AD

I have a couple of Devices that where erroneously joined to both On-prem local domain AND Azure AD (MS bug?) now devices where not connected properly to any of the domains (local was deprecated) and trying to remove old domain logins and re-adding Azure AD fails. Deleted Azure AD object and tried to re-enroll. Error 8018000a unable to re-enroll objects already exists (well not in my portal) and neither MsolDevice or Get-AzureADDevice shows the device anywhere ? how do i connect these devices, without resetting windows (seems to be a workaround to get new Obejct Ids to enroll device)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad8e93b0-2d8b-68c0-62ee-be44831b1557
Version Independent ID: b55939f9-e552-9818-80b7-535601d4bc7b
Content: How to manage stale devices in Azure AD
Content Source: articles/active-directory/devices/manage-stale-devices.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@Cisvhenriksen
Thanks for your feedback! We will investigate and update as appropriate.

If you are using Intune you will need to delete the device in Azure and unenroll it from Intune.
If the option to delete is greyed out, make sure that you have also clicked "remove company data" prior to deleting the device.
If you still having issues I would recommend checking out the troubleshooting guide. https://docs.microsoft.com/en-us/intune/troubleshoot-windows-enrollment-errors

Since this is not specifically a documentation issue, please move this thread to MSDN and I will happily troubleshoot with you. https://social.msdn.microsoft.com/Forums/en-US/home?forum=WindowsAzureAD


lnd crash (SIGSEGV) with sendtoroute

Been experimenting with sendtoroute and got lnd to crash a total of 3 times so far.
lnd: lnd-linux-amd64-v0.5-beta
bitcoind: bitcoin-0.16.3-x86_64-linux-gnu
Log snippets:
Oct 20 04:53:09 X lnd[12930]: 2018-10-20 04:53:09.218 [INF] DISC: Broadcasting batch of 6 new announcements
Oct 20 04:53:18 X lnd[12930]: 2018-10-20 04:53:18.198 [ERR] RPCS: Unable to get link for channel f5c22b0a2f318899097af3a163625b230f7f7844616b754fb282d126e3cfc19e: channel link not found
Oct 20 04:53:18 X lnd[12930]: 2018-10-20 04:53:18.320 [ERR] CRTR: Attempt to send payment<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000 failed: payment is in transition
Oct 20 04:53:32 X lnd[12930]: 2018-10-20 04:53:32.226 [ERR] RPCS: Unable to get link for channel f5c22b0a2f318899097af3a163625b230f7f7844616b754fb282d126e3cfc19e: channel link not found
Oct 20 04:53:32 X lnd[12930]: 2018-10-20 04:53:32.378 [ERR] CRTR: Attempt to send payment<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000 failed: payment is in transition
Oct 20 04:53:39 X lnd[12930]: 2018-10-20 04:53:39.218 [INF] DISC: Broadcasting batch of 2 new announcements
Oct 20 04:53:54 X lnd[12930]: 2018-10-20 04:53:54.196 [ERR] RPCS: Unable to get link for channel f5c22b0a2f318899097af3a163625b230f7f7844616b754fb282d126e3cfc19e: channel link not found
Oct 20 04:53:54 X lnd[12930]: 2018-10-20 04:53:54.327 [ERR] CRTR: Attempt to send payment<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000 failed: payment is in transition
Oct 20 04:54:09 X lnd[12930]: 2018-10-20 04:54:09.218 [INF] DISC: Broadcasting batch of 3 new announcements
Oct 20 04:54:34 X lnd[12930]: 2018-10-20 04:54:34.499 [INF] RPCS: [listchannels] fetched 115 channels from DB
Oct 20 04:54:37 X lnd[12930]: 2018-10-20 04:54:37.590 [INF] RPCS: [listchannels] fetched 115 channels from DB
Oct 20 04:54:39 X lnd[12930]: 2018-10-20 04:54:39.218 [INF] DISC: Broadcasting batch of 4 new announcements
Oct 20 04:54:39 X lnd[12930]: 2018-10-20 04:54:39.352 [ERR] RPCS: Unable to get link for channel f5c22b0a2f318899097af3a163625b230f7f7844616b754fb282d126e3cfc19e: channel link not found
Oct 20 04:54:39 X lnd[12930]: panic: runtime error: invalid memory address or nil pointer dereference
Oct 20 04:54:39 X lnd[12930]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x60 pc=0xcecf21]
Oct 20 04:54:39 X lnd[12930]: goroutine 47539422 [running]:
Oct 20 04:54:39 X lnd[12930]: main.unmarshallRoute(0xc00680db40, 0xc021efda00, 0x4, 0xc008bbe5e0, 0x4)
Oct 20 05:14:22 X lnd[25594]: 2018-10-20 05:14:22.539 [ERR] RPCS: Unable to get link for channel f5c22b0a2f318899097af3a163625b230f7f7844616b754fb282d126e3cfc19e: channel link not found
Oct 20 05:14:22 X lnd[25594]: 2018-10-20 05:14:22.549 [INF] CRTR: New channel discovered! Link connects 022b662aa03cf4db4820bcf4f47f1006d2bfae9bee416a926fb8bdba16e088d7f6 and 037b7cd33aada9dd91ccb95857d8f71c34fd31c426057016f28f48b0633ae844cd with ChannelPoint(31e41b09b91a55a6c4233de98008e773df920995dc09d110404a8e970f59322d:0): chan_id=564768545677639680, capacity=0.00002 BTC
Oct 20 05:14:22 X lnd[25594]: 2018-10-20 05:14:22.665 [INF] CRTR: New channel discovered!  It'd be nice to identify which channel this is for. If it's a private channel, then unfortunately the channel update is only being sent once and it would require the remote party (in this case, you) to be online while they're sending it (see #1347).
This patch should allow your node to no longer hit this crash:
index 9fcaa75d..0f63b08a 100644
--- a/rpcserver.go
+++ b/rpcserver.go
@@ -3353,12 +3353,16 @@ func unmarshallRoute(rpcroute *lnrpc.Route,
 		var channelEdgePolicy *channeldb.ChannelEdgePolicy

 		switch {
-		case bytes.Equal(node.PubKeyBytes[:], c1.Node.PubKeyBytes[:]):
+		case c1 != nil &&
+			bytes.Equal(node.PubKeyBytes[:], c1.Node.PubKeyBytes[:]):
 			channelEdgePolicy = c2
 			node = c2.Node
-		case bytes.Equal(node.PubKeyBytes[:], c2.Node.PubKeyBytes[:]):
+
+		case c2 != nil &&
+			bytes.Equal(node.PubKeyBytes[:], c2.Node.PubKeyBytes[:]):
 			channelEdgePolicy = c1
 			node = c1.Node
+
 		default:
 			return nil, fmt.Errorf("could not find channel edge for hop=%d", i)
 		}

Does your node have any non-advertised channels?

Seems that patch above should be committed as well, in the scenario that we actually don't have an edge for the target route.

This is fixed in master, as it accesses edgeInfo and not the individually policies. We'll be releasing 0.5.1 which packages this fix, and several other bug fixes as well in the next few weeks.

I see this is closed already but just in case: the routes were constructed from lnd's public graph data, so there should be no private channels there. The data could very well have been a bit outdated though, so I guess some channels could have become inactive or removed already when sendtoroute was run. If there's still need I'd be happy to give the exact routes JSON that was used, but I don't want to put it in public here.

It was closed as the latest version of lnd can't hit this code path, the
version to be released soon.
On Fri, Oct 26, 2018, 8:54 PM jogc<EMAIL_ADDRESS>wrote:

I see this is closed already but just in case: the routes were constructed
from lnd's public graph data, so there should be no private channels there.
The data could very well have been a bit outdated though, so I guess some
channels could have become inactive or removed already when sendtoroute was
run. If there's still need I'd be happy to give the exact routes JSON that
was used, but I don't want to put it in public here.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lightningnetwork/lnd/issues/2101#issuecomment-433588115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA87Lrt1k04N1aO7U8v2xo3B5k1TB8H6ks5uo9j5gaJpZM4X8Iuh
.

Aight. Thank you :)


Corrupt frame fixup

This pull request resolves an issue causing images with corrupt frames to crash FLAnimatedImage, specifically images like this. The reason for this crash was that frames were attempting to be injected into the cachedFrames at indexes that were out of bounds. As a simplification, I converted cachedFrames and delayTimes to dictionaries, which are more tolerant of nulls. I also made it so that frames lacking delays are skipped in https://github.com/Flipboard/FLAnimatedImage/commit/178b714357fef62c38c7aec5ba65d41ca2cf069e.
A simple way to test this is to change the URL on this line to https://dl.dropboxusercontent.com/s/duveng0hqjc263t/scotus-gay-marriage-decision copy-6-26-2015.gif.

Does the move from array to dictionary storage have a functional impact? Or did you make the change to make it easier to work with than an array with [NSNull null] entries?

:shipit: no blocking feedback

Sweet, thank you.

Does the move from array to dictionary storage have a functional impact? Or did you make the change to make it easier to work with than an array with [NSNull null] entries?

It should not have a functional impact, it was done as a simplification. At some point I'd like to support more dynamic loading of delay times and frames, it's also conducive to that.

:+1:

Added to CHANGES
  * Improve resilience against GIFs with corrupt frames (Tim Johnson)

  * Turn on -Wundef warning flag (Tim Johnson)

(Please ignore the whole assigning business here, I have no idea how this "troybrant was unassigned by raphaelschaad 9 minutes ago" happened and to reassign everybody on GH appears in the list, but Troy, hah.)

:+1:


Handle as many formats as possible when parsing dates

Based on real world testing on data from the early 2000's we need to replace the following code
https://github.com/nlnwa/warchaeology/blob/ab32b5f0340bc6b44ded32960c8fe1dbbcefe29c/nedlibreader/nedlibreader.go#L58-L66
with a function that can parse as many date formats as possible.

I have started working on this in  this branch.

In addition to https://pkg.go.dev/time#pkg-constants we need to create custom layouts to be able to parse custom date formats. I am going to add testcases with formats that we currently do not handle.

Closed by #150


Improve template with Doxygen and GTest

Description of contribution in a few bullet points

Add GTest support
Add config folder with default parameters
Add launcher
Add Doxyfile
Improve README.md

Future work that may be required in bullet points

Use ament_lint_auto_find_test_dependencies()

We should incorporate all the basic ament_tests, including the use of uncrustify instead of clang_format


Hardcoded Strings

There are still hardcoded strings in some java files. They should be extracted to string- and plurals-resources in oder to be translated.
Some examples:
https://github.com/intrications/intent-intercept/blob/master/app/src/main/java/uk/co/ashtonbrsc/intentexplode/Explode.java#L625
https://github.com/intrications/intent-intercept/blob/master/app/src/main/java/uk/co/ashtonbrsc/intentexplode/SettingsUtil.java#L45

Hope no one minds, I've started to work through these.  Won't be able to do values-de though.

@laurencemeynell
Feel free to extract more strings. Once your work has been merged, the German translation can easily be done.


Add cookie support

Purpose: Add support for specifying cookies added to requests
Background: Needed to add cookies to be able to follow some steam pages.
This seems to work for me, let me know if some tests are needed (not sure I followed how the tests are implemented)

Just use the existing request headers field
Specify "cookie: xyz"


Bugfix sonos

Description:
I change the sonos from internal wlan to home wireless and have now the same problem, that if I use
media_player:
  - platform: sonos

will it discover by config and later with autodiscovery. So I have the same device twice.
Related issue (if applicable): fixes #3317

I will make a refactoring of sonos platform, but at the moment should that fix the bug...

done and local tested 👍

Hmm the new update hide comments....
"I can't use the test only on EntityComponent while sonos would add this also to DEVICES. But the unique_id is a greate idee."

The question is if you actually need DEVICES or that you can get the entities from the EntityComponent when the service gets called. However, that's for a future PR and this is fine as is.


Validation fails for sitemap input

Trouble validating sitemaps has been reported by Bioschemas community member Alisdair Gray.

The first sitemap I tried (https://disprot.org/sitemap.xml) is an index of sitemaps.
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <sitemap>
    <loc>https://disprot.org/sitemap1.xml.gz</loc>
  </sitemap>
  <sitemap>
    <loc>https://disprot.org/sitemap2.xml.gz</loc>
  </sitemap>
</sitemapindex>

This returned an error
TypeError: 'FileNotFoundError' object is not subscriptable
Traceback:
File "/usr/local/lib/python3.10/site-packages/streamlit/scriptrunner/script_runner.py", line 443, in _run_script
    exec(code, module.__dict__)
File "/validator/website_st.py", line 102, in <module>
    markdown_text = report.generate_report_summary(result)
File "/validator/web/report.py", line 10, in generate_report_summary
    ##### {fmt.header("Against profile:")}  {result['Profile Name']} {result['Profile Version']}

I then tried one fo the nested sitemaps which is a sitemap of URLs. This eventually timed out with no error from what I could see.


[WFLY-13381] At EJB3 remote AssociationImpl, we need to take into acc…

…ount the possibility of identity being null before setting up connection in SecurityActions.
With EJB over Remoting, it is always true that the identity won't be null because of Sasl anonymous user. But the same does not apply to EJB over HTTP. In this
case, security identity is null if http-remoting-connector lacks the security-realm attribute (at remoting subsystem model config):

Jira: https://issues.redhat.com/browse/WFLY-13381
EAP Jira: https://issues.redhat.com/browse/JBEAP-16383

Thanks for the feedback, @darranl !


[CI] rename pre-commit action

As discussed this renames the action to code quality checks / run pre-commit

Also here: precommit is in a waiting state...

Because it was renamed and is still listed as required. But the rename is done in the rules by Patrick.


[BUG] I am getting FullSizeRender image name.

@AlexV525 Using latest version of library still getting FullSizeRender.jpg instead HEIC image and original file name. This happens when i use portrait image in iOS.


JS syntax error with CDATA and comment

What is your Scenario?
I'd like to test a page which has the following partial content. This content will be transformed by hammerhead with incorrect output which cause runtime javascript syntax errors.
<script type="text/javascript"><!--

//<![CDATA[<!--

var a = "test";

//-->]]>

//--></script>

What is the Current behavior?
When starting the test, there is an error in browser console.
Uncaught SyntaxError: Unexpected token ']'

The content would be transformed to:
<script type="text/javascript"><!--

//<![CDATA[<!--

var a = "test";

]]>

//-->//--></script>

You can see the structure is different from the original one. ]]> is moved before the //-->.
What is the Expected behavior?
The content should be transformed with correct structure:
<script type="text/javascript"><!--

//<![CDATA[<!--

var a = "test";

//-->]]>

//--></script>

What is your public website URL? (or attach your complete example)
https://codesandbox.io/s/jovial-glitter-4o6e1f?file=/index.html
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <title>Sandbox</title>
    <meta charset="UTF-8" />
  </head>

  <body>
<script type="text/javascript"><!--

//<![CDATA[<!--

var a = "test";
console.log(a);

//-->]]>

//--></script>
  </body>
</html>

What is your TestCafe test code?
const BASE_URL = `https://4o6e1f.csb.app/`;

fixture(`test`).page(BASE_URL);

test('Test', async (t) => {
  await t.navigateTo(`/`);
});

Your complete configuration file
No response
Your complete test report
Make changes to the source files or press Ctrl+R to restart the test run.

The sources have changed. A test run is starting...
 Running tests in:
 - Chrome <IP_ADDRESS> / macOS 10.15.7

 test
 ✖ Test

   1) A JavaScript error occurred on "https://4o6e1f.csb.app/".
      Repeat test actions in the browser and check the console for errors.
      If you see this error, it means that the tested website caused it. You can fix it or disable tracking JavaScript errors in TestCafe. To do the latter, enable the "--skip-js-errors" option.
      If this error does not occur, please write a new issue at:
      "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      SyntaxError: Unexpected token ']'

      Browser: Chrome <IP_ADDRESS> / macOS 10.15.7

         1 |const BASE_URL = `https://4o6e1f.csb.app/`;
         2 |
         3 |fixture(`test`).page(BASE_URL);
         4 |
         5 |test('Test', async (t) => {
       > 6 |  await t.navigateTo(`/`);
         7 |});
         8 |

         at Object.<anonymous> (/Volumes/DATA/SynologyDrive/project/MINE/tiger-grid/controller/private/crawler/banking/test.ts:6:11)
         at <anonymous> (/Volumes/DATA/SynologyDrive/project/MINE/tiger-grid/controller/private/crawler/banking/test.ts:7:71)
         at __awaiter (/Volumes/DATA/SynologyDrive/project/MINE/tiger-grid/controller/private/crawler/banking/test.ts:3:12)
         at <anonymous> (/Volumes/DATA/SynologyDrive/project/MINE/tiger-grid/controller/private/crawler/banking/test.ts:5:26)
         at processTicksAndRejections [as null] (node:internal/process/task_queues:95:5)

 1/1 failed (1s)

Make changes to the source files or press Ctrl+R to restart the test run.

Screenshots
No response
Steps to Reproduce

Running the test code

TestCafe version
1.9.1
Node.js version
18.12.0
Command-line arguments
testcafe chrome test.ts
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Hi @fred104,
Thank you for the shared example. I've reproduced the issue.

Hi @fred104,
This issue is not reproduced with combination of<EMAIL_ADDRESS>and the Google Chrome browser. Feel free to reopen this issue if you encounter it in other browsers.


Information about the Video Dataset

Hi @LukeForeverYoung @MAGAer13 ,
I am working on a project for which I am finetuning mplugowl-video. I aim to report information about the video data used to finetune the mplugowl model. Can you please provide information (dataset name and links to them) with some data statistics?
Thanks!

The authors replied over email. They are using Video-Chat dataset for mplugowl-video: https://arxiv.org/pdf/2305.06355.pdf


Macro: extendsType freezes analyzer

Macro definition:
macro class Foo implements ClassTypesMacro {
  const Foo();

  @override
  FutureOr<void> buildTypesForClass(ClassDeclaration clazz, ClassTypeBuilder builder) async {
    final Identifier statelessWidget = await builder.resolveIdentifier(
      Uri.parse('package:flutter/src/widgets/framework.dart'),
      'StatelessWidget',
    );
    builder.extendsType(NamedTypeAnnotationCode(name: statelessWidget));
  }
}

Macro application:
@Foo()
class Bar { }

The usage of builder.extendsType seems to just make the analysis server get stuck. It stops reporting any issues and it also doesn't update the augmentation file anymore. Commenting out that line gets the analyzer back into a good state.

CC @scheglov

Thanks for taking a look! I just tried it again on 3.5.0-222.0.dev and I am still seeing the same hanging behavior. In case it is helpful, the full code I am using is here: https://github.com/goderbauer/scratchpad/tree/main/macros_playground and when I comment in this line it just hangs: https://github.com/goderbauer/scratchpad/blob/a980fd66fdda138d72b7a04731a2537dd7f1fa47/macros_playground/lib/src/macro.dart#L157

Interesting: I tried to reproduce the hang in a fresh project with just the code given in the first comment and it doesn't repro there. But when I insert that code into my other project at https://github.com/goderbauer/scratchpad/tree/main/macros_playground it reliably hangs...

I was able to reproduce it, and have a unit test that shows it.
https://dart-review.googlesource.com/c/sdk/+/371781
I believe this is a bug in the implementation that generates merged macro code.
It does not preserve the order of partial macro results.
@jakemac53

This is not quite the analyzer bug, but the shared implementation issue.
So, I un-assign it from myself.
@jakemac53

Thanks @scheglov for taking a look, and thank you @jakemac53 for checking it out for us!

@scheglov can you clarify why the specific ordering matters here?
I believe the intention today is we always put new types first, because that should always be valid, and any augmentations of those types must come after the original type declaration.
We could try and do something different, but it would be a very large change so I want to make sure it is actually required.

I would not say that it strictly matters, maybe more like my expectations. As we run macro applications, we generate transient *.macroX.dart files, build CompilationUnitElements for them, and at the end merge partial elements into the single *.macro.dart file unit element. So, my implicit expectation was that if we get partial files
augment library 'test.dart';

augment class B extends prefix0.A {
}

and then
class C {}

Then in the merged file we get declarations in the code in the same order.
And it is important to have elements and AST declaration to correspond each other in order.
Is this wrong? Your answer implies that it is wrong :-)
Theoretically one macro augmentation can both generate a new type, and augment existing, right?
So, we cannot just reorder partial library augmentations, right?
We need to merge first new types, then augmentation of classes, then functions, then augmentations of functions?
I guess I don't know if there is any better documentation of the order than the merge implementation code :)

It looks to me that the best option would be for me to write multiple tests in the analyzer that cover the merging order, as well as I understand the existing implementation of AugmentationLibraryBuilder.

It looks to me that the best option would be for me to write multiple tests in the analyzer that cover the merging order, as well as I understand the existing implementation of AugmentationLibraryBuilder.

I wouldn't focus too much on the existing behavior if possible. @johnniwinther made a lot of changes to that code to I think help with a similar issue in the CFE, attaching special identifiers to certain parts of the code? I don't fully understand the details tbh, but maybe he can help.

The tests are probably still useful. Whatever order we do, the order of elements and declarations in merged code inside the analyzer must be the same. If the order changes, we will need to update the tests. How we ensure that they are consistent, is a separate question :-)

OTOH, given that we don't know anymore what and how macros will generate, maybe I should just fix this specific issue and don't waste time doing more general solution.

I was able to confirm that extendsType now works flawlessly in my prototype. Thank you!
I am running into the same freezing problem at another place now and I am wondering if its related or something different. I want the macro to generate a private class (_Foo), but when I replace the \$ in the line linked below with _ everything freezes up again.
https://github.com/goderbauer/scratchpad/blob/9ea949bed426c6c9cc7e61ec15104a79bce3e659/macros_playground/lib/src/macro.dart#L17
This is what I would like that line to be (unless there's another trick to generating private classes):
String _toStatefulWidgetClassName(ClassDeclaration clazz) => '_${clazz.identifier.name}';

There is a different crash in the analyzer, augmentation libraries are not fully implemented yet.
I opened a new issue https://github.com/dart-lang/sdk/issues/56184


[Fix] convert BF16 tensor to float before calling .numpy()

.numpy() in PyTorch only supports limited scalar types: aten_to_numpy_dtype.
When running BF16 with autocast, an error will be thrown here when calling .numpy(): TypeError: Got unsupported ScalarType BFloat16.
Convert BF16 tensor to float before calling .numpy() to fix this error.

cc @jgong5, @Guobing-Chen, @leslie-fang-intel

@chunyuan-w see: https://github.com/mindee/doctr/pull/1344
In your PR you can do the same for PyTorch and we are fine to merge :hugs:

@chunyuan-w see: #1344
In your PR you can do the same for PyTorch and we are fine to merge 🤗

Thanks for the reference. Let me further refine this PR following #1344.

Thanks for the fix @chunyuan-w 👍
Could please add a short comment that it fixes the issue in torchbench ? :) @odulcy-mindee mypy fix applied in #1344

Thanks for merging it!
I just submitted a draft PR to torchbench to update the doctr version in torchbench to include this fix.


[MS, MSR, MSL, MSM] Feature needs to be implemented in Switch

Feature description
...
The following feature has to be implemented in the Switch
1. MS	- Momentary Switch
2. MSR	- Momentary Switch Release
3. MSL	- Momentary Switch LongPress
4. MSM	- Momentary Switch MultiPress

Platform
All Platform
Test plan impact:
TC-SWTCH-1.1, TC-SWTCH-2.1, TC-SWTCH-2.2 and TC-SWTCH-3.2
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/switch.adoc
Reference :
Spec : https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/Switch.adoc

Those features should generally work, I would think: you just set them in the feature map, and then emit the events as needed.  That all happens in the application.
What's the SDK-side work that this is actually asking for, @Survensa ?


Login error

Visual Studio Code Version : 1.31.0
Code Sync Settings Version : 3.2.4
Operating System : Windows 10 x64 1803 build 17134.523
Occurs On: Upload
Proxy Enabled: No
I had this extension installed from some time and then it stopped working, I didn't care at the time because I had everything synchronized. Now I need it again, even after updating vscode and reinstalling the extension it doesn't work.
I deleted some leftover files from the extension uninstall so when I install it again it asks me again fro the token, when I enter the token it throws the error in the dev console:

I'm new to this extensions but I'm seeing the same error. It works on the laptop that I did the initial upload of settings from but if I try to add a new system this error gets triggered

I'm new on this extension too, and i get this error.

The error it's on a Windows 10 Pro x64 1809 build 17763.316 and try to get the settings to Ubuntu laptop. I change token in files and the error it's steel there.

I am seeing this error too when trying to sync download for the first time on a new machine?

Can you update the extension and let me know same error persists ?
See this Not found usually caused by GitHub
https://github.com/shanalikhan/code-settings-sync/wiki/Troubleshooting#invalid-gist-id-or-invalid--expired-github-token

I updated but the errors persisted. I managed to get it working using the troubleshooting link.


docs: document byte order in parse() and stringify(). fixes #503

Should we mention though that this is the byte order recommended by the RFC

Let's not.  Between the note and the examples, it's clear what we're doing.  I don't think we need to go into the "why" behind it.


GEOMESA-896 Exception thrown in Point2Point process when a linestring…

… is created by multiple points in the exact same location

If a grouped set of points are all in the exact same location, then an
exception was being thrown.
Allow the ability to filter out these singular points.

Signed-off-by: Anthony Fox<EMAIL_ADDRESS>

f7bedc32a3b040b175b20dde0202a074531c2a6b


adding tensorflow and singularity examples

hey @raphtown ! I just worked on this (slightly modified) example that will load up the same python 2 or 3 notebook, but also with tensorflow! I have a matching tutorial to post along with it, to give a bit more context. --> https://vsoch.github.io/lessons/jupyter-tensorflow/
Also, I think I just got a wicked idea - it's pretty annoying to need to load sherlock modules (then half the time something still doesn't work) so how cool would it be to just provide things in containers? And then the user can pick / share containers with things ready to go? There is also a thing called repo2docker that would make it totally seamless to go from a jupyter notebook, to docker container, to singularity container (for sherlock). So - after this post, how about I'll give a go at "the container version?" I'd want to also include the repo2docker as part of the tutorial, so these two guys would need to be merged first:

https://github.com/binder-examples/continuous-build/pull/4
https://github.com/jupyter/repo2docker/pull/351

okay I just added an example to do the same with a Singularity container! Here is the corresponding tutorial:
https://vsoch.github.io/lessons/sherlock-singularity/
The container version is much nicer because dependencies that the user might want can be totally packaged here (although the container I provided is pretty simple :O) ) and the user doesn't have to generate a token in advance (the container generates and provides it):

I'm working on a bug now wrt permissions of writing new files - it might need to warrant a change to the singularity container build. I'll change the title of the post (removing the WIP) when this is done and the PR is ready for review.

okay I figured out the issue! And we have writable notebooks!

The issue was that the default repo2docker container sets the user home to be /home/username, which is fine for Docker (we can write everywhere) but not for Singularity. So the fix was to enforce the user's home being... the user's home for the container at runtime.
I also added a bit to the end of start.sh to show the user how to get logs to their screen, as I noticed sometimes that the notebook doesn't output its token to the terminal, and the attempt to cat the logs doesn't catch it either. The entire execution workflow now looks like this:
vanessa@vanessa-ThinkPad-T460s:~/Documents/Dropbox/Code/srcc/forward$ bash start.sh singularity-jupyter
== Checking for previous notebook ==
No existing singularity-jupyter jobs found, continuing...
== Getting destination directory ==
== Uploading sbatch script ==
singularity-jupyter.sbatch                                                                          100%  898     0.9KB/s   00:00
== Requesting GPU ==
== Submitting sbatch ==
sherlock sbatch --job-name=singularity-jupyter --partition=gpu --gres gpu:1 --output=/home/users/vsochat/forward-util/singularity-jupyter.out --error=/home/users/vsochat/forward-util/singularity-jupyter.err --mem=20G --time=8:00:00 /home/users/vsochat/forward-util/singularity-jupyter.sbatch 56143 ""
Submitted batch job 22399485
== Waiting for job to start, using exponential backoff ==
Attempt 0: not ready yet... retrying in 1..
Attempt 1: not ready yet... retrying in 2..
Attempt 2: not ready yet... retrying in 4..
Attempt 3: not ready yet... retrying in 8..
Attempt 4: not ready yet... retrying in 16..
Attempt 5: not ready yet... retrying in 32..
Attempt 6: not ready yet... retrying in 64..
Attempt 7: resources allocated to sh-112-05!..
sh-112-05
sh-112-05
notebook running on sh-112-05
== Setting up port forwarding ==
ssh -L 56143:localhost:56143 sherlock ssh -L 56143:localhost:56143 -N sh-112-05 &
== Connecting to notebook ==
== View Logs Like This ==
ssh sherlock cat /home/users/vsochat/forward-util/singularity-jupyter.out
ssh sherlock cat /home/users/vsochat/forward-util/singularity-jupyter.err
Container is /scratch/users/vsochat/share/repo2docker.simg
Notebook directory is /scratch/users/vsochat
[I 10:49:19.524 NotebookApp] Writing notebook server cookie secret to /tmp/jupyter/notebook_cookie_secret
/srv/venv/lib/python3.6/site-packages/IPython/paths.py:68: UserWarning: IPython parent '/home/username' is not a writable location, using a temp directory.
  " using a temp directory.".format(parent))
[I 10:49:20.123 NotebookApp] JupyterLab alpha preview extension loaded from /srv/venv/lib/python3.6/site-packages/jupyterlab
[I 10:49:20.123 NotebookApp] JupyterLab application directory is /srv/venv/share/jupyter/lab
[I 10:49:20.129 NotebookApp] nteract extension loaded from /srv/venv/lib/python3.6/site-packages/nteract_on_jupyter
[I 10:49:20.133 NotebookApp] Serving notebooks from local directory: /scratch/users/vsochat
[I 10:49:20.133 NotebookApp] 0 active kernels
[I 10:49:20.133 NotebookApp] The Jupyter Notebook is running at:
[I 10:49:20.133 NotebookApp] http://<IP_ADDRESS>:56143/?token=aaaaaaaaaaabbbbbbbbbbbbbbccccccccccc
[I 10:49:20.133 NotebookApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 10:49:20.133 NotebookApp]

    Copy/paste this URL into your browser when you connect for the first time,
    to login with a token:
        http://<IP_ADDRESS>:56143/?token=aaaaaaaaaabbbbbbbbbbbbbbcccccccccc
Open your browser to http://localhost:56143

I'm pretty excited about this :) Let me know when you've had a look - I'd love to share the post soon!! If people want containers with other setups ready to go, we can get feedback on this and I can provide them in my shared folder.

Heyo! Do you have an ETA of when you can look this over? I'd like to start on a set of containers with scientific packages ready to go, and want to share this and get feedback from users first. Wod be greatly appreciated thank you discuss soon! If you would like help to manage the code and push it's early development, or don't want me to PR here, I am ok working just on my fork but I'd much rather do it here with you!

Hey @vsoch! I am going to take a look at this tomorrow (Monday).
Cheers.

Awesome!

Ok these all look great!  Merging!

woohoo awesome!
I'm making the little registry of containers now (so other users can find/share and use forward) I'll ping you when I have something to play with.


Future of picture and srcset polyfilling

You all might already know this. But I think with upcoming Safari supporting picture it is time to include this idea:
I believe that best practices and most wanted default implementation of polyfilling/using responsive images will change in the near future.
While most people should omit the src attribute, if they use srcset in combination with pf. More and more people will want to simply use the default src as a fallback strategy.
Reason all major browsers now support srcset and sizes. And for all others the fallback src might be good enough.
At the same time, this progressive enhancement strategy doesn't work with art directed picture, because of two things:
a) picture isn't supported as widely as srcset
b) and more important: art direction is a crucial part of the layout and not always open to a progressive enhancement strategy
This means people will want to include picturefill for polyfilling picture, but they don't want picturefill to interfere with their fallback src strategy.
Another problem might be, that people might use different plugins with different strategies (polyfilling with no src attribute, polyfilling with low quality src or not polyfilling with medium sized src).
To serve these use cases, I would like to introduce a change in picturefill 3.1, which gives more respect to the initially set src by the developer.
The goal is to avoid double download, if the developer has set an initial src, that is not a low quality image and has no art direction or is from the same set.
If the developer has set an initial src, picturefill does not run the normal source selection, it simply just checks, whether the current src is a) from the same set and b) is over 0.9x on 1x. devices or over 1.2x on 2x devices. If this is the case the current image candidate won't be changed.
Of course if the developer uses a) art direction or b) leaves out the src (as we currently recommend) or has chosen a dramatic low resolution image as src, picturefill works with the normal source selection algorithm.
So here are some code examples:

<picture>
  <source srcset="..." media="..." />

</picture>

With this mechanism. Different image embed techniques (use img with fallback src) as also use picture or srcset only with polyfill can coexist friendly on the same side and picturefill adapts automatically to those different patterns.
Note: If picture is implemented the way, we recommend it currently there is no change, picturefill will work the exact same way it already works. Only if people do include pf differently (do add a "fallback" source the algorithm kicks in).

Still think this is a good idea :+1:

This is great. I will try to put something together until next Monday.

Sorry, I have so much to do, that I couldn't work on this little change. I will give it a try until next monday.


Dual punishers on water units

Would it be possible to change the poison, burn and para res to 99 or even 100% to mirror how it is on the twins? I keep seeing dual punishers in the custom sim for water units and it makes things difficult to optimise due the fact dual punishers aren't viable on twins.

You can set poison resist under condition.


Allow getter/setter calls to be inlined if the object is polymorphic but the identity of the getter/setter is consistent.

Add helpers to get accessors directly from the object if the accessor inline cache misses. Delete all the machine-specific lowerings related to accessor inline caches and use a shared lowering.

@pleath are you still planning to merge this?

I may. I need to see if it still contributes to perf now that we share types with accessors.


v0.8.6 fails to show proper error on invalid schema

Detailed description
The latest 0.8.6 version fails to print proper advice on invalid specs:
> speccy lint swagger.json

./node_modules/speccy/lint.js:83
        const { context, lintResults } = _options;
                ^

TypeError: Cannot destructure property `context` of 'undefined' or 'null'.
    at validator.validate (./node_modules/speccy/lint.js:83:42)
    at ./node_modules/call-me-maybe/index.js:13:28
    at process._tickCallback (internal/process/next_tick.js:61:11)

whereas version 0.8.5 properly hints at the underlying issue:
> speccy lint swagger.json

Specification schema is invalid.

#/paths/~1api<hidden>/post/parameters/0
path parameters must appear in the path

Context
I'm working on linting both v2 (using swagger2openapi) and v3 files from an older project. Some of the existing v2 files had not been linted before, and seems they are not even spec compliant.
The nodejs exception does not help finding out where the error actually lies, it looks to a user as if speccy is having an issue, instead of parsing an invalid spec.
Your environment

Node Version: Both latest v8 & v10 via nvm
Operating system and version: Debian 9.6

Actually, when comparing the output of this to the older swagger-tools validate, it seems to stop at the first error, whereas swagger-tools shows all errors in a single pass. Is it possible to obtain something like that? I think it's much nicer for the user:
API Errors:

  #/paths/~1api<hidden>/post/parameters/0/<hidden>: API path parameter could not be resolved: <hidden>
  #/paths/~1api<hidden>/post/parameters/1/<hidden>: API path parameter could not be resolved: <hidden>
  #/paths/~1api<hidden>/get: API requires path parameter but it is not defined: <hidden>
  #/paths/~1api<hidden>/get: API requires path parameter but it is not defined: <hidden>

4 errors and 0 warnings

Thanks for the awesome work!

This will be fixed when version 2.0.1 of oas-validator is released and updated in speccy.


jsx-wrap-multiline does not check nested JSX

Possible duplicate of #185, but I couldn't quite understand what error that issue was reporting.
When using the rule jsx-wrap-multiline = true, no nested JSX is checked. The outer JSX is checked correctly, but no insertion of JS in the JSX via {} is checked. Example:
const myCondition = true;
const component = () => (

        I am correctly wrapped in () and don't report an error.

        {myCondition &&

            I should, but I don't report an error.

}

        {myCondition && (

            I don't report an error either.

)}

        {myCondition
            ?

                Neither do I.

            :

                Nor me.

        }

);

I would expect any nested JSX inside {} tags to also be checked with this rule.
Hope this can be addressed, as it's a common pattern in many of our/my projects :)
Keep up the great work with TSLintReact<3!

Probably a bug, but formatting rules are low priority because of https://github.com/palantir/tslint/issues/4534

Perfectly understandable. Great if it gets fixed, but I understand if it won't at this time. Thanks!


MRG: Ensure plot_ica_sources() always plots traces of rejected ICs on top

This fixes a regression that I believe was introduced via  #9444. The below picture demonstrates the issue:

Rendered tutorial:
https://35566-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/40_artifact_correction_ica.html?highlight=repairing#using-an-eog-channel-to-select-ica-components

CI failures are unrelated DeprecationWarnings.


CI: Add check-requirements job

Add back the check for requirements files, but this time as a separate job so that its result can be ignored if it starts to yield problems again.

Codecov Report

Merging #387 (4c5e104) into main (aaabbce) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   90.12%   90.13%
=======================================
  Files         336      337    +1
  Lines       11983    11993   +10
  Branches      854      855    +1
=======================================
+ Hits        10800    10810   +10
  Misses       1047     1047
  Partials      136      136

see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[NEW ICON] blockchain

Skill Name
Blockchain
Why?
It's popular for web development
Reference Images (optional)
Example.

"Blockchain" has no unified logo, and would probably be better fit by Solidity, as seen in #5.


New Cars DLC

Add cars from new DLC. I'm not intending to buy it yet, so some help would be nice. Extracting the new DLC cars and tracks can be done using the tools/extractor.go "script". It's important to add the new cars and tracks, not to delete existing ones. So either the extracting user must have all DLCs or add the cars/tracks manully from the extracted tracks.json/cars.json to the repository.

cars.zip
This has all DLC's as well as a few mod cars in my cars list. (229 cars in total)
When I run for tracks I get the following error
2017/10/22 10:52:55 invalid character 'ï' looking for beginning of value
exit status 1
Is there anyway I can see what track is causing this issue? I have 68 tracks (inc a few mod ones)

The tracks/cars json should only contain official DLCs for acweb and extended with mods for you own needs. So everyone can add the stuff they need.
Your error looks like AC cannot handle the ï character? Maybe one of the tracks you got has a strange name? acweb should be able to handle unicode characters, but I don't know what AC is doing.

I just bought all DLCs, so I'm able to update the config.

Done.


Allow ContextMenus to show when "ContextMenu" key is pressed while widget is focused

Started some work on this one, but the question is how do we close the context menu when the contextmenu key is used?. I think Instead of forcing a key like this I should instead expose a OpenContextMenu and CloseContextMenu function on the widget.


Rename repository from heroku/builder to heroku/cnb-builder-images

We should rename this repository to heroku/cnb-builder-images, since:

This repo is in the general heroku org, rather than a CNB-specific org, so "builder" on its own doesn't have enough context (to me it suggests some build tool or build system, rather than a set of images)
It would be more consistent with the heroku/stack-images repo

The repo has now been renamed:
https://github.com/heroku/cnb-builder-images
I'll leave this issue open whilst I update the URLs everywhere (GitHub will redirect from the old repo URL, but might as well use the new URL where possible).

https://github.com/heroku/cnb-builder-images/pull/400
https://github.com/heroku/languages-github-actions/pull/150
https://github.com/heroku/languages-team/pull/147
https://github.com/heroku/buildpacks-go/pull/167
https://github.com/heroku/buildpacks-nodejs/pull/672
https://github.com/heroku/buildpacks-ruby/pull/215
https://github.com/heroku/buildpacks-inline/pull/1
https://github.com/heroku/maple/pull/203

I've updated the GitHub repo URL in the Docker Hub image repo descriptions here:
https://hub.docker.com/r/heroku/builder
https://hub.docker.com/r/heroku/builder-classic
https://hub.docker.com/r/heroku/buildpacks

https://github.com/Qovery/engine/pull/739
https://github.com/coollabsio/documentation/pull/31
https://github.com/architect-team/documentation/pull/42


[AMQ-5137] make networkConnector decreaseNetworkConsumerPriority="true" the default

[x] Create PR for code change
[ ] Update website network of brokers page to document the change

This change itself seems fine but I'm not sure if any existing network bridge tests will break. So you need to check all the network tests and run them to see if anything doesn't work now that the default changed.
Also, yes the change is trivial but again, all changes should have tests. You don't need to write anything crazy but you could at least write a test to verify the new default is true (could just check the network connector/bridge or even use the JMX NetworkConnectorView after start up) to prevent getting broken in the future.

@cshannon yep. Plan to. I kicked in these PR’s to get the tests running in parallel to see fallout. I’ll be going through the unit test failures and adding the default value tests next

Note-- first test run failed on a StompTransport test (appears unrelated). Kicking off fresh run of tests


🚀 -  Font Size input option

Which @codeimage/* package(s) are relevant/releated to the feature request?
No response
Description
Add an option to increase or decrease code font size. Thank you

Hi, yes i was already planning to allora editing font size 😄 I think it will be added in the January update

Thank you🚀


block_confidentials.sh -hook script in git is not working properly even after reverted the changes

I used below pre-receive script for blocking the developers from committing the secrets insides the files.
followed the below steps to set up this in GitHub Enterprise Appliance.

created a repo in github, cloned to local desktop. saved the copied script (https://github.com/github/platform-samples/blob/master/pre-receive-hooks/block_confidentials.sh ) from the site as .sh file and committed and pushed.

in GitHub as site admin , created a hook from admincenter and pointed to previously created hookscriptone.

and after that i tested a scenario wit creating a new repo and adding a example.conf file to this.

When i did first commit with the simple content (without any secrets), its allowed me to commit .

in second scenario, i committed with a keyword "CONFIDENTIAL" in it, but it blocked as expected.

so for confirming the hooks functionality, i removed the "Confidential" word and tried to commit back.. but its still not allowing me to commit.

Any helps pls...

How are you pushing back?
Are you using the git command line?

(This hook will check on all the commits that you are pushing on the command line.)

yes, am using git bash.  Below are the process which i followed.
first step, in the cloned directory created a file without any secrets in it,, committed and pushed successfully.
in the second step i added a word "CONFIDENTIAL" in the file  and committed and pushed, so as expected it gave me error as expected.
so again i removed the word "CONFIDENTIAL" from the file and again committed and pushed. However its not allowing ang giving the same error as second step..

As one of your commits contains the word CONFIDENTIAL the whole push is rejected.
What you could do is un-comment line 69 in the hook script to show this:
# echo -e "${match}\n"

@vivuu1989, another way would be to amend the first push (the one being rejected) by removing the CONFIDENTIAL info and then push again, result will be only one commit in the push.
Otherwise, as @mzzmjd stated, there will be two commits in your push, first one with the "blocked" CONFIDENTIAL information and the second which removed that information.
ℹ https://help.github.com/en/articles/changing-a-commit-message and https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend

So the file with the word CONFIDENTIAL is in your git history.
When you are doing the push now, you are pushing 2 commits:
1. First commit contains the word CONFIDENTIAL

2.

As one of your commits contains the word CONFIDENTIAL the whole push is rejected.
What you could do is un-comment line 69 in the hook script to show this:
# echo -e "${match}\n"

Didnt help this.. the same error even after uncommenting that in the hook script

@vivuu1989, another way would be to amend the first commit (the one being rejected) by removing the CONFIDENTIAL info and then push again, result will be only one commit in the push.
Otherwise, as @mzzmjd stated, there will be two commits in your push, first one with the "blocked" CONFIDENTIAL information and the second which removed that information.
ℹ https://help.github.com/en/articles/changing-a-commit-message and https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend

but usually once the the developers notified with secrets in their code by the hook script, they might be directly changing the secrets and committing again .. But i think this wont help here in that scenarios..

@vivuu1989, when amending the rejected code the developer will change the content of the committed file(s) and will not be blocked again, unless they still have content.confidential information in the code.

@vivuu1989, when amending the rejected code the developer will change the content of the committed file(s) and will not be blocked again, unless they still have content/confidential information in the code.

i think i got confused here, so here you are asking me to do a git commit --amend in the second step, after i got notified with the  confidential data in the code ?

Yes, changing your code, git add and got commit —amend will change the content of your commit to not include any proprietary data in your push.

again facing same issue. If the user committed first with secret file and once its blocked, even after removing the file followed by amend, the push is not allowing... Could you please advise me here.
Once we committed with some secrets, how can we go back to previous commit after removing the secrets.. tried with git commit --amend --allow-empty, but not succeded.. dont know where i am getting stuck

You really need to remove the commit, from your local repository, that is causing the problem.
Easiest way might be with git rebase -i SHA
See
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
https://git-scm.com/docs/git-rebase

What is te reason for that.


http://diamond.readthedocs.org/ returning 404

Hi, I manage the diamond project and it seems that for some reason we're getting a 404 for our docs: http://diamond.readthedocs.org/.
I tried deleting and re-creating the project without any luck. Is there any way someone can help?
Thanks

Maybe the index.html file is missing or named incorrectly like in this situation?
https://github.com/rtfd/readthedocs.org/issues/737

@loweryaustin: Seems like your inital hunch was correct. I think this was likely due to the mkdocs version bump. Trying to fix up my config accordingly

Okay seems that mkdocs didn't like that index.md was a symbolic link. Must be a changed behaviour or regression. Thanks for the help, the docs are fixed now.


example ReadMe is incorrect.

should be subscriptions.ini not subscription.ini for
bitcoinexchangefh -sqlite -sqlitepath bitcoinexchangefh.sqlite -instmts subscription.ini

I don't believe this has been updated yet?


implement hover style for WebsiteTabs

Closes https://github.com/carbon-design-system/carbon-website/issues/1219
changes:

implement hover style for tabs in a WebsiteTabs component

Actually, it looks like we're not using the motion package anywhere in the website. @shixiedesign, is there any issue in the backlog to change the motion on the website?

@tw15egan to your point i'd love to talk about this more! i've been noticing a few little details on the website that we could improve the motion on, and i'd like to make sure to be up to date on this

@lovemecomputer sweet! I'll keep you in the loop. Going to create an issue now

FYI: https://github.com/carbon-design-system/carbon-website/issues/1564


ToJson() fails on HashTable

when calling .ToJson() on hash table in sample, it throws an error:
Self referencing loop detected for property 'Host' with type 'BeetleX.Redis.RedisDB'. Path 'DB'.

There is no internal data in the hash table, and the data operates on the Redis Server.
Copy data to the Dictionary using Keys() and Get() methods


Add docs for @vx/point. Issue #9

I can combine more things into one pull request if you would like. I wanted to make sure that this was the right sort of style that you wanted for docs. Let me know if there's anything I can do to make it better. ❤

Looks great, thank you!


Documentation of connect

Hi. The connect functionality seems most useful, but after looking at the docs I was left very confused. After a little experimenting, I maybe figured out some things. I am asking to please elaborate the docs on this part to make it more understandable for an outsider.
An example;

# System is A -> B -> C
# no feedback for simplicity

my_named_tf = (tf, name) -> named_ss(ss(tf), x = Symbol("x_$name"), u = Symbol("u_$name"), y = Symbol("y_$name"))
a = my_named_tf(tf([1], [1, 0]), :a)
b = my_named_tf(laglink(10^-1, 10^0.5), :b)
c = my_named_tf(leadlink(10^0, 10^1, 1.0), :c)

# the docs do not describe such straightforward 1:1 connection
# actually I dont understand why the docs would have a connection :yC => :yC ?
connections = [b.y[1] => c.u[1], a.y[1] => b.u[1]]

# I want to be able to access my block diagram from any input and any output
yy = vcat([sys.y for sys = [a, b, c]]...)

# also I want to be able to access from any input
uu = vcat([sys.u for sys = [a, b, c]]...)

# create the graph
# note the docs dont really mention the z parameter which I found useful
block_diagram = connect([a, b, c], connections, w1 = uu, z1 = yy)

# now use the block diagram for different purposes
bodeplot(block_diagram[:y_c, :u_b])
bodeplot(block_diagram[:y_c, :u_a])
bodeplot(block_diagram[:y_b, :u_a])

The code above makes sense to me...

Also, no examples of using splitter or any docs that I can find

The code you post looks mostly correct, on master, you can use the Colon operator to denote "all signals". Here's an example using this
using ControlSystemsBase, RobustAndOptimalControl

a = named_ss(ss(tf([1], [1, 0])), :a)
b = named_ss(ss(laglink(10^-1, 10^0.5)), :b)
c = named_ss(ss(leadlink(10^0, 10^1, 1.0)), :c)

connections = [b.y[1] => c.u[1], a.y[1] => b.u[1]]

# I want to be able to access my block diagram from any input and any output
yy = (:)

# also I want to be able to access from any input
uu = (:)

block_diagram = RobustAndOptimalControl.connect([a, b, c], connections, w1 = uu, z1 = yy)

# now use the block diagram for different purposes
plot(
    bodeplot(block_diagram[:cy, :bu]),
    bodeplot(block_diagram[:cy, :au]),
    bodeplot(block_diagram[:by, :au]),
)

actually I don't understand why the docs would have a connection :yC => :yC

in the example, there is one output and one input both named yC so the connection becomes :yC => :yC

The z1 parameter is mentioned in the docstring

I realize its possible to make this work, and even work better. My issue was just that even though the information is maybe there, it would benefit the average person who wanted to try this out to explain the details of the code a bit more... I could suggest some docs, but right now I'm not sure what to write.

help?> splitter
search: splitter splitext splitpath

  No documentation found.

  RobustAndOptimalControl.splitter is a Function.

  # 2 methods for generic function "splitter":
  [1] splitter(u::Symbol, n::Int64) in RobustAndOptimalControl at /Users/tallakt/.julia/packages/RobustAndOptimalControl/nd5G8/src/named_systems2.jl:470
  [2] splitter(u::Symbol, n::Int64, timeevol) in RobustAndOptimalControl at /Users/tallakt/.julia/packages/RobustAndOptimalControl/nd5G8/src/named_systems2.jl:470

I don't know what aspects of the docs you find confusing, I of course know how the function works so it's hard for me to see what's not clear for someone. This tutorial goes into a bit more depth of creating a block diagram, does that help?
https://juliacontrol.github.io/RobustAndOptimalControl.jl/dev/hinf_connection/

in the example, there is one output and one input both named yC so the connection becomes :yC => :yC

This is an example of something that is quite confusing to me. It seems there are two namespaces, one for inputs and one for outputs? But I don't understand why I need to connect?
Also, what is the first argument to connect? Should it include splitters?
This code has a lot going on, but the docs seem very sparse to explain whats going on between the lines.

Do these additional instructions help?
https://github.com/JuliaControl/RobustAndOptimalControl.jl/commit/e50bfcec83cc5e1088ca8b4a21e97f142e3b36f9


Automapper 4.2 API changes has broken self config

Recent changes have broken the self mapping:
https://lostechies.com/jimmybogard/2016/01/21/removing-the-static-api-from-automapper/
https://lostechies.com/jimmybogard/2016/02/24/automapper-4-2-1-released-static-is-back-limited-edition/
https://github.com/AutoMapper/AutoMapper/releases/tag/v4.2.1
Need to use Initialize instead of CreateMap

Fixed with 7403b1a
Will be part of release 0.10.0


Make gradle test print stacktrace on test failure

It helps to see the stacktrace on the console when tests fail. Currently gradle does not print that. We could add the -i option but that is very verbose. Instead, following the instruction from here: https://docs.gradle.org/current/dsl/org.gradle.api.tasks.testing.logging.TestLoggingContainer.html
With this change, we get the following on test failure (induced error):
com.github.ambry.router.PutManagerTest > testLaterChunkFailure FAILED
    java.lang.AssertionError: Exactly one chunkFiller thread should be running before the router is closed expected:<1> but was:<12>
        at org.junit.Assert.fail(Assert.java:91)
        at org.junit.Assert.failNotEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:126)
        at org.junit.Assert.assertEquals(Assert.java:470)
        at com.github.ambry.router.PutManagerTest.assertCloseCleanup(PutManagerTest.java:773)
        at com.github.ambry.router.PutManagerTest.submitPutsAndAssertFailure(PutManagerTest.java:607)
        at com.github.ambry.router.PutManagerTest.testLaterChunkFailure(PutManagerTest.java:350)

Tested on OS X and Linux.

Verified this.
com.github.ambry.frontend.AmbryBlobStorageServiceFactoryTest > getAmbryBlobStorageServiceFactoryWithBadInputTest FAILED
    java.lang.IllegalArgumentException: Null arguments were provided during instantiation!
        at com.github.ambry.frontend.AmbryBlobStorageServiceFactory.<init>(AmbryBlobStorageServiceFactory.java:59)
        at com.github.ambry.frontend.AmbryBlobStorageServiceFactoryTest.getAmbryBlobStorageServiceFactoryWithBadInputTest(AmbryBlobStorageServiceFactoryTest.java:98)

Very useful change. Merging


os-git-backup DNS resolution.

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] The title contains the plugin to which this issue belongs

Describe the bug
Dear,
I have successfully configure DNS to my private DNS Servers and I can resolve my private gitlab from >> Interfaces: Diagnostics: DNS Lookup.
However os-git-backup seems to not use the firewall configuration.
Thank you for your help.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Expected behavior
DNS Resolution from the plugin as firewall do
Screenshots
Relevant log files
git-backup unknown error, check log for details (ssh: Could not resolve hostname XXXXXX: Name does not resolve\x0d fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. )
Additional context
Environment
OPNsense 22.1.10-amd64
FreeBSD 13.0-STABLE
OpenSSL 1.1.1q 5 Jul 2022
Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz (1 cores, 1 threads)

Dear,
Any information missing ?


Add single point NLL calculation for MultiDimFit

It would be useful to have the option to check what the deltaLogLikelihood is between the best fit and some specified point (eg, debugging, calculating pulls etc).
This can be engineered using --algo grid but for >1 dimensional fits it is tricky.

I think this can be closed since there is now the option to run a fixed point (and the deltaNLL wrt the initial best fit is saved in the output)


reopen #30

#30 should be reopened (merged), that the initial report was against 1.9 has nothing to do with what version it's needed for. in comments 2.1 was also reported. and please actually LOOK and  READ at the ticket description and commit diff what problem the merge request tries to solve!

please merge it instead of just closing
it helps for ruby's which are built with: ./configure --disable-rubygems


Fix test packages ambiguous throws

Hides throws from 'package:test/expect.dart'.
Critical for main branch.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 88.925%

Files with Coverage Reduction
New Missed Lines
%

lib/src/subscription.dart
1
90.48%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
3051

Relevant Lines:
3431

💛  - Coveralls


Excludes javadoc and source from zipkin-ui (static asset) publishing

javadoc and source jars don't make sense in terms of static asset jars.. I noticed this when browsing snapshot repo http://oss.jfrog.org/artifactory/oss-snapshot-local/io/zipkin/zipkin-ui/1.36.1-SNAPSHOT/
cc @eirslett @abesto

merging to test (by looking at jfrog)

reverted by https://github.com/openzipkin/zipkin/commit/4f75efe852319c49bc34ecbba2b6ec38bb0a109b
Basically, this is an unnecessary thing required by maven central policy. Easiest thing is just to ignore the extra assets. http://central.sonatype.org/pages/requirements.html#supply-javadoc-and-sources


[UI] - Paginitation regression

Setup

Rancher version: 2.6.5
Browser type & version: All

Describe the bug
From 2.6.5 the UI list doesn't respect the "Table row per page" but always use 10 as default value
This is a regression compare to previous 2.6.5
In 2.6.4 with 100 in the settings

Now in 2.6.5 with 100 in the settings

I had a quick look on our latest 2-6.head and this looks like it was resolved. We need to confirm this.
@sebastienroul Could you confirm what the per-page value is when you load <rancher url>/v1/userpreferences in your browser? Does it get updated when you change the table row per page preference in the UI (and refresh v1/preferences)?

@richard-cox
I confirm : 100

And it is updated when using UI

Hi @richard-cox
Just upgrade to 2.6.6, and the problem is still there.
Here is my /v1/userpreferences

and the result

Let me know if there any hack cause it's very painful.
Best regards

I can't find the PR, but this was related to the select issue that was apparent with the log streaming timeframe setting and was resolved by the same fix.
I couldn't reproduce in 2.6-head, so moving to QA to validate for the next release

Hi @richard-cox
Your're right, it's the same "kind of" issue - to fix it : /v3/preferences/per-page pressing the delete button on the right of the page and then send request in the modal that pops up.
The stange point is that my rancher install (2.6.6) is totally new (from yesterday) - so the rootcause of this wrong setting is not found.
Hope it helps.

@richard-cox Could you please add a QA template for this ticket when you get a chance? Thanks!
CC: @AndrewHoffmanQA

QA Template
Root cause
See https://github.com/rancher/dashboard/issues/5984#issuecomment-1132511208
What was fixed, or what changes have occurred
See https://github.com/rancher/dashboard/issues/5984#issuecomment-1132511208
Areas or cases that should be tested

Navigate to a Clusters Workloads page, ensure there are over 25 rows in the table
Navigate to the User Preferences page and change the Table Rows per Page setting to 10
Navigate back to the Clusters Workloads page and observe the the pagination controls at the bottom of the list state 1 - 10 of <x> workloads and only 10 rows are showing
Navigate back to the User Preferences page and change the Table Rows per Page setting to 25
Navigate back to the Clusters Workloads page and observe the the pagination controls at the bottom of the list state 1 - 25 of <x> workloads and only 25 rows are showing

What areas could experience regressions?
All lists
Are the repro steps accurate/minimal?
See steps above

tested in 2.6.7-RC1, UI now correctly shows 1-100 is set in the user profile and a page has 100+ line items.

Tagging original issue https://github.com/rancher/dashboard/issues/5984


Define a way to improve NER installation through adding new cases and retraining it

Want to contribute to DeepPavlov? Please read the contributing guideline first.
What problem are we trying to solve?:
In production systems, it is important to have a simple and non-obtrusive way to extend capabilities on NER to recognize new objects or fix recognition of the existing ones

How can we solve it?:
Web interface for adding new cases

Are there other issues that block this solution?:

I suppose a good NER Service should cover the following use cases through web interface:

Annotate requests with NER entites (as any NER tool must do) via REST API
Allow Admins to view log of requests for annotation and produced results
Allow Admins to add new training cases into the dataset (which will fine-tune NER model instantly or via button).

It seems to be a quite simple web app.

I agree. The 3rd point seems to be interesting. But, we cant expect the model to fine-tune in real-time. Did you mean transfer learning where we transfer the weights of the new data to the existing trained model?


Device Not Supported

Followed the instructions at https://drive.google.com/file/d/1ZCtu3rviCAtireOT1E2ooCOeSVK-Bidu/view and got "Device not supported" when I got to the add integration part. Yes, the IP is correct.
Although, I did the modbus style installation previously, but removed it after the first failed attempt.
2024-03-07 11:00:41.872 ERROR (MainThread) [custom_components.linknlink.config_flow] Unsupported device: 0xac7b. If it worked before, please open an issue at https://github.com/home-assistant/core/issues

Same issue here...

I have fixed it. Please try again.

Had to reload the integration in HACS, but it works now. But, now am getting no motion.

Also getting this issue (downloaded at 23:47 UTC 9-Mar). Hadn't had any Mobus integration:
`This error originated from a custom integration.
Logger: custom_components.linknlink.config_flow
Source: custom_components/linknlink/config_flow.py:39
integration: LinknLink (documentation)
First occurred: 8 March 2024 at 23:54:22 (4 occurrences)
Last logged: 20:07:28
Unsupported device: 0xac99`

The motion function of the ehub has been repaired.

Also getting this issue (downloaded at 23:47 UTC 8-Mar). Hadn't had any Mobus integration:
`This error originated from a custom integration.
Logger: custom_components.linknlink.config_flow Source: custom_components/linknlink/config_flow.py:39 integration: LinknLink (documentation) First occurred: 8 March 2024 at 23:54:22 (4 occurrences) Last logged: 20:07:28
Unsupported device: 0xac99`

'0xac99' is not in the supported list. We only support LinknLink devices, such as eHub eTHS and eMotion.

Also getting this issue (downloaded at 23:47 UTC 8-Mar). Hadn't had any Mobus integration:
This error originated from a custom integration. Logger: custom_components.linknlink.config_flow Source: custom_components/linknlink/config_flow.py:39 integration: LinknLink (documentation) First occurred: 8 March 2024 at 23:54:22 (4 occurrences) Last logged: 20:07:28 Unsupported device: 0xac99

'0xac99' is not in the supported list. We only support LinknLink devices, such as eHub eTHS and eMotion.

Is there anything on the road map to support the universal remote? https://shop.linknlink.com/products/linknlink-smart-wifi-universal-remote-ir-blaster-for-tv-aircon-stb-featuring-bluetooth-ble-smart-home-hub-compatible-with-alexa-google-home

We plan to launch this device in the next version.

Any news when the eHub will be supported please?

Any news when the eHub will be supported please?

Almost there, just a bit more.

Any news?

Dead keen here!

I've upgraded it. Please update and try again.
Given that I am using the latest version of the hardware development, there may be problems with older devices.
If you have any questions, please contact me.


project error

when i run the project and after i upload the generated api key , then when i click on start quiz its showing failed to fetch, is it a program error or an issue with api key

Are you sure that you are running the backend server? Can you show the request details using your browser's developer tools?


add strided assignment

This is supposed to speed up broadcasting and assignment of views by a good margin.

reminder to add tests for strided view reverse iteration (was broken before latest commit)

besides a warnings pass I think it's done now :)

Really nice work, congrats! Some minor changes required, but I really love this PR ;)

ok, there have to be some adjustments to how broadcasting speedup works in column major mode

Hi @ukoethe
I just wanted to update you on some of our recent work:

we've made views (both xview and strided_view) faster with this PR by adding another assign loop based on strides
as well as broadcasting, which has a speed up thanks to this PR as well
we've made assignment of ones and zeros faster by adding an assign_to method and dispatching on it if it is availble -- making assignment of ones and zeros equivalent to std::fill
we're in the process of making the strides a signed integer #760

Some performance improvements are still outstanding, and we also haven't forgotten on the idea of making the shape method return a xexpression :)
Just wanted to let you know what we've been working on in the past couple of month, and would be interesting to see if your benchmarks have gotten any improvement!

This sounds very promising, I'll certainly have a look. However, I can probably return to this project only after the lecture and exam periods.


Make local leaked globals, fix XP bar flicker issue

So I've found this addon is causing the XP and Reputation bars to flicker, while RHT is trying to initialize. During setup, RHT will clear existing toybox filters, look for hearthstones, then reset the existing toybox filters.
Every time it changes the toybox filters, the XP and Reputation bars flicker. I don't know why, I certainly don't see any connection. Probably a bug on Blizzards end.
The problem is, if any of these situations happens:

The player has no Hearthstones, or
The local game hasn't cached data about hearthstone toys yet, or
The player has Expansion/Source filters setup that filter out all their hearthstones,

then RHT keeps trying over and over every second, checking the toybox again and again. This causes the XP and Rep bars to keep flickering every second until the toybox finally works, which probably won't happen until the player opens their toybox and resets all the filters.
The change I've made here is to not reset back to the player's original filters if a hearthstone is not found.

Actually theres more to this that I can't find. This change stops the issue happening, but doesn't seem to be the true cause.
I setup tickers that turn the filters on and off every second, but the flickering isn't happening.

Okay I got it. Its to do with watching a frame's OnUpdate. The flicker doesn't happen if I switch that whole RHT.to to a C_Timer.NewTicker.

this ticker change looks like a great improvement thanks.
Later tonight I'll test this and merge :D

Quick script to demo the problem. Track a reputation then:
/run local f,a=CreateFrame("Frame"),0 f:SetScript("OnUpdate", function(_,e) if a>-1 then a=a-e return end a=0 C_ToyBox.SetCollectedShown(not C_ToyBox.GetCollectedShown()) end)
If you swap that timer based on OnUpdate out for a C_Timer, no flicker.


License secret not injected sometimes

In some sessions the user does see "Invalid license". The license does not get injected in the right way.

We faced this issue today again with one container - the /opt/capella/capella.ini was completely empty.

Should be an easy fix: https://stackoverflow.com/a/47083974


Save functions in separate folder and reference by a custom function name

Would be awesome to do this. I can even see a marketplace coming out of this where people pay for functions written by other people.

Benefits of this is that:

the code takes up less space / is more asthetic while in edit mode
you can replace the code in one place and it'll be updated everywhere it's used, saving a huge amount of time

what comes to my mind is:

There is a hardcoded path to a TS file with functions (to be configurable in settings in a future; also might be MD with codeblocks in a future too)
In that file user can add anything to some.globalObjectFor.customUserDefinedStuff (alternatively, register functions like some.dataviewApi.registerCustom('userDefinedStuff', () => { … })).
Dataview evaulates that file first, before evaulating any dataviewjs block (OK, here I have totally no idea if it's possible in an efficient manner or at all)

Yes, a "plugin API" is one potential, where you specify a "plugin folder" in the dataview settings which it executes and hands some API for registering junk (as well as an API for executing against dataview).
So you would do something like:
registry.register("niceify", (dv, arg1, arg2, ..., argn) => arg1.toLocaleUpperCase());

And could call it from dataviewJS via dv.func.niceify or from dataview via niceify().
We have an existing flag which disables DataviewJS, so we would likely add one to disable this custom loading for people who don't want to risk it.

After some thought, I think @nkoder has a good approach, so I'll probably pursue it that way. Dataview will probably watch the directory and automatically reload "plugin functions" when the directory changes for a more seamless Plug N Play experience.

What do you think about recently added CustomJS plugin? I just created my first function with it and used in my dataviewjs block.
On the other hand, it will work in dataviewjs blocks only, as I understand, and not in dataview ones.

^^^^ AMAAAZING yussss

What do you think about recently added CustomJS plugin? I just created my first function with it and used in my dataviewjs block.
On the other hand, it will work in dataviewjs blocks only, as I understand, and not in dataview ones.

That's right - I think it's great for DataviewJS, though there is still reason to add additional dataview-specific support so you can write Dataview functions.

Anyone get started on this? I got some pretty gnarly functions that are being duplicated all over the place... daily notes, etc. Would be very nice to edit in one file, and all files that reference them are updated :)

dv.view() allows code reuse and the predominant method has been to use CustomJS. Sadly, no support for the QL.


Adding backtick to commit throw error

git commit support backticks to highlight some parts of the text as code but using it with mct throw an error and also commits regardless; excluding text inside backticks.

I have tried to reproduce the error. It's does not show any error and displays the message with backticks as it should.

it works now, I'm closing the issue


What's the recommend way for upstream systems to fetch the user identifier?

We're experimenting with oauth2_proxy v3.2.0 in front of some ruby web applications to ensure all access is by authenticated users. We're using the OIDC provider, linked to auth0.
The proxy is started like this:
oauth2_proxy \
--provider=oidc \
--oidc-issuer-url=https://<subdomain>.auth0.com/ \
--upstream=http://localhost:5000 \
--http-address=<IP_ADDRESS>:4180 \
--cookie-secret=xxx \
--email-domain=* \
--skip-provider-button \
--pass-authorization-header

It works perfectly. Users loading the site over HTTP are redirected to auth0 to login, and then back to site where they gain access.
However, our ruby services are also interested in knowing who the user identified as. For that we need an email or other unique identifier. What's the recommended way to do so? We can see a few possibilities, but worry that if we guess we might get something that works but is insecure.

Incoming requests have a _oauth2_proxy cookie set, which has some base64 JSON objects. The values of the JSON object appear to be encrypted though. Can we decrypt them somehow (maybe using the --cookie-secret)?

--pass-authorization-header means the incoming request has the IDToken embedded in the Authorization header. That IDToken is a JWT, which has the relevant details from auth0. Does oauth2-proxy automatically verify the signature of the IDToken (can we just decode the JWT and trust it)?

The incoming request has a X-Forwarded-Email header added to it. Can we just trust that value?

thanks!

Yes, you can use use and trust the X-Forwarded-Email (and X-Forwarded-User) headers.

Thanks.
auth0 provide a unique user identifier in the IDToken that we might prefer to use over email address. Is Option (2) in my list safe as well, and do we need to validate the IDToken signature ourselves?

You may have a service that can provide (via a auth0 management API) additional features like password resets/bla bla.. for Auth0 for example the user_id is what u want (to start with) for sure.
I'm no expert but I think yes. Passing the JWT is quite a common.. its not uncommon to want that for several reasons..

auth0 can have external connections (EG: azure AD).. you might want to embed meta-data about which groups the user is in (inside the JWT)
at the application level itself (not just the transports... like nginx) its probably good security if u validate the JWT token.. (takes time to integrate/smooth over the first time)
you may have a service in your application stack that do additional validations against the JWT

..eg.. unpack the JWT, look for "some" data and then check it with OPA to see what policies are applied.. (EG.. "what data can customer X see" etc)..  that'll give really fine grained powers to you.
(just stumbled over this issue as I was reading up on an auth0/oidc example... thanks for that, you saved me some time...)

Thanks! I'll close this issue for now, I think we have enough context to continue integrating auth0 and oauth2 proxy


Add error handling.

Add more validity checks for assumptions: i.e. calculations only valid for positive Julian Day numbers. We should fail openly and gracefully. Utilize Result<> and Option<> types.

[ ] Do not return any raw AstroTime structs
[ ] Remove all calls to unwrap ( except from unit tests )
[ ] Add tests that check the error conditions
[ ] Add error messages or types indicating the type of error.


Update link for HPA object to point to API docs instead of old design doc

The HPA has been around for quite some time and now has two new beta versions of its object. This link update makes it easier to find the acutal object spec instead of the outdated design doc.

Thanks. Pointing to the GA version of API object is the right thing to do.
/lgtm
/approve


Isolate modules internally

This is recommended to flatten the curve and for Babel builds. We won't promote this to the default config just yet.

This is apparently less great than I thought: https://github.com/microsoft/TypeScript/issues/18232#issuecomment-380104366


BART included twice

Hi,
Thanks for this exciting work. Both the dataset and analysis will be very useful!
It looks like BART is listed as both extractive (#8) and abstractive (#13). I believe the files are also identical. It also appears twice in the pickle files with the scores, both under the system name "bart_out".
Is this a mistake or is there a misunderstanding on my part?
Thanks!

looks like they have different summaries (one is abstractive, the other is extractive)  if you check the two bart files in human_annotations
https://github.com/neulab/REALSumm/blob/master/human_annotations/SCUs_and_annotations/SCU_rating_results_abs_systems/bart_out_Batch_crowd_3.csv
and  https://github.com/neulab/REALSumm/blob/master/human_annotations/SCUs_and_annotations/SCU_rating_results_ext_systems/bart_out.csv
However, in the pickle files, they are indeed identical. Looks like they both are the extractive summaries from https://github.com/neulab/REALSumm/blob/master/human_annotations/SCUs_and_annotations/SCU_rating_results_ext_systems/bart_out.csv.
So I guess they might make a mistake when compiling pickle files?


build rdkit in macosx using brew without conflict with macport

I can build rdkit on yosemite using :
http://blog.matt-swain.com/post/58327973320/homebrew-cheminformatics
brew tap mcs07/cheminformatics
brew install rdkit

@thegodone -
What is the request here?

we can close it


data-acquisition: design schema for PoolConfig, PoolInfo, Transactions and Agents

schema should resemble columns in json output produced by the current pipeline
Agents should store address & also their agent id

Agents:
Metadata? (not priority)
Wallet information (use web3 to get balance of address, or get deltas from transaction receipts)

User to agent mapping


Ground Items Plugin - Hide items that don't belong to the player

Is your feature request related to a problem? Please describe.
When playing ironman mode, it is a hassle to sort through loot on the ground and determine what you can and cannot pick up. This is especially obnoxious during slayer at areas like Kurasks where many players will leave valuable herbs on the ground that they cannot carry.
Describe the solution you'd like
I would like a toggled option within the ground items plugin to hide text for items that do not belong to the player. I would also like to remove them from the left click option if possible, so that the user can walk over other player's items without using the right click menu.
Describe alternatives you've considered
Just hiding the item name or "greying it out" as the "hide items below x value" option does would be great by itself if that could be done.
Additional context
The game knows who a ground item belongs to, if it's dropped by them or from a monster - hence the delay of dropped items appearing for others, and ironman's inability to loot other player's things. I'm hoping the client has that information as well, this would be a huge QoL feature for ironman players. Especially when doing slayer-like activities in crowded areas.
An alternate use case might include any account type turning this on to hide other player's dropped skilling items such as players mass dropping fish or logs, while still keeping those items visible on the ground items list for other purposes. Nonetheless, most ironman players would want to keep this option on at all times.

For what it's worth, the game is aware of what items are owned by whom, but I don't think the client is. I can't say with certainty as I've only skimmed the source code, but I believe the client simply sends a request to pick something up and the server tells them whether or not they can, which makes it difficult or impossible to implement a feature like this.

For what it's worth, the game is aware of what items are owned by whom, but I don't think the client is. I can't say with certainty as I've only skimmed the source code, but I believe the client simply sends a request to pick something up and the server tells them whether or not they can, which makes it difficult or impossible to implement a feature like this.

Could you not do this in a different way, the loot tracker plugin knows which loot you have earned from kills, etc. So is it not possible to have everything hidden, then only show things which the loot tracker would have tracked? I'm not sure of the inner workings of the client, but is this possible?

Hmm, it's a shame it's not accurate. But a way to sort of get around this would be to hide all items under a certain alch value, this way bones from other places, etc, wouldn't be shown. And you wouldn't miss valuable drops.

that actually sounds like a pretty good compromise to the not complete accuracy of the loot tracker

Would be great to have this functionality, it's annoying that Jagex didn't implement this in the first place.

That's a good point, but personally that would be a sacrifice worth making, as it's frustrating being an ironman with the way it currently works. If I wanted to see these items at a later point, I could just disable the plugin temporarily.

I've created a working implementation of the feature based on the discussion in this thread and submitted a pull request here #6757
If you'd like to use the feature immediately, you can clone my fork and build it.

Fixed by #6816?


attemp to call field 'nvim__redraw'

Neovim version (nvim -v | head -n1)
NVIM v0.10.0-dev
Operating system/version
ubuntu20.04
How to reproduce the issue

use the following config with lazy;

return {
    "kevinhwang91/nvim-hlslens",
    event = "VeryLazy",
    enabled = false,
    keys = {
        { "n",  [[<cmd>execute('normal! ' . v:count1 . 'n')<cr><cmd>lua require('hlslens').start()<cr>]] },
        { "N",  [[<cmd>execute('normal! ' . v:count1 . 'N')<cr><cmd>lua require('hlslens').start()<cr>]] },
        { "*",  [[*<cmd>lua require('hlslens').start()<cr>]] },
        { "#",  [[#<cmd>lua require('hlslens').start()<cr>]] },
        { "g*", [[g*<cmd>lua require('hlslens').start()<cr>]] },
        { "g#", [[g#<cmd>lua require('hlslens').start()<cr>]] },
    },
    config = true,
}

open the nvim with a file
the error is:

Expected behavior
no errors
Actual behavior
the above-mentioned error occurs when opening the file.

@kevinhwang91

Only this error appeared for the first open?

I am experiencing this issue too. As of now, I've seen it appear when entering buffers.

What's the lua =vim.api.nvim__redraw output? Is the result is <function 1> ? Look like the lazy issue.

experiencing the same issue since an update

I encountered a similar problem. But with the same config, the problem only occurred on the remote server when i open a file, and no error was reported in nvim on my local machine.
outputs are as follows
Error in decoration provider ufo.end:
Error executing lua: ...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:132: attempt to call field 'nvim__redraw' (a nil value)
stack traceback:
    [C]: in function 'error'
    ...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:143: in function <...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:140>
    [C]: in function 'nvim_command'
    ....local/share/nvim/lazy/nui.nvim/lua/nui/popup/border.lua:624: in function '_relayout'
    ...4/.local/share/nvim/lazy/nui.nvim/lua/nui/popup/init.lua:390: in function 'update_layout'
    ...4/.local/share/nvim/lazy/nui.nvim/lua/nui/popup/init.lua:158: in function 'init'
    .../.local/share/nvim/lazy/nui.nvim/lua/nui/object/init.lua:132: in function <.../.local/share/nvim/lazy/nui.nvim/lua/nui/object/init.lua:130>
    ....local/share/nvim/lazy/noice.nvim/lua/noice/view/nui.lua:92: in function 'create'
    ....local/share/nvim/lazy/noice.nvim/lua/noice/view/nui.lua:271: in function 'show'
    ...local/share/nvim/lazy/noice.nvim/lua/noic
Error in decoration provider ufo.end:
Error executing lua: ...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:132: attempt to call field 'nvim__redraw' (a nil value)
stack traceback:
    [C]: in function 'error'
    ...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:143: in function <...24/.local/share/nvim/lazy/nvim-ufo/lua/ufo/decorator.lua:140>

Only this error appeared for the first open?

Only this error appeared for the first open?

It seems to happen when read a new buffer or toggle a fold. And :lua =vim.api.nvim__redraw outputs nil

Only this error appeared for the first open?

It seems to happen when read a new buffer or toggle a fold. And :lua =vim.api.nvim__redraw outputs nil

I guess it is lazy issue. nlua_init -> nlua_state_init -> nlua_add_api_functions.  vim.api.nvim__redraw never become nil after nvim initialized except other plugins make it to be nil.
https://github.com/neovim/neovim/blob/aa853f362addded400d52d8fdfe5247c300c0e89/build/src/nvim/auto/lua_api_c_bindings.generated.h#L8981-L8982

I tried the latest nvim v0.10.1 just now, and the error seems disappeared.
Before that, my nvim version is NVIM v0.10.0-dev-2999+g38b9c322c.
Thank you very much for your reply!


Executed tasks should not pollute the environment

Any temporary file that is created during the execution should be removed.

Already closed by #15


English Translation

Hi there, I am wondering if there is an English translation of this project?
If there is not, what are your thoughts on me creating an actively maintained fork for the sole purpose of providing the documentation in English?

Welcome, I really hope to see the English version of the vulhub.
I had 2 idea about the translation before:

You don't have to translate exactly as the original.
You can rename the Chinese version of "README.md" to "README.zh.md", and make English the default language.

If everything goes well, I will merge your work into vulhub in the future.

Hi there,
Thanks for the feedback.
As per your suggestion I will rename the files as I translate them.
I've created an "english" branch on GlitchWitchIO/vulhub-en and will update this issue when I have completed all the translations.

If there is not, what are your thoughts on me creating an actively maintained fork for the sole purpose of providing the documentation in English?

@GlitchWitchIO I imagine actively maintaining a fork just for the purpose of translation would be a lot of hassle. We would be happy to merge your translations into the this repo, if you don't mind 😄

@sfdye Sorry I haven't worked on this project in a while as I have been busy!
I have only translated roughly 5% of the project, but I'd be happy to see my translations merged into this repo!

@GlitchWitchIO Awesome, I saw your PR, 5% is good start!

We are doing the translation work at the same time to make the vulhub to use English by default. maybe you can join us :) @GlitchWitchIO
https://github.com/vulhub/vulhub/wiki/如何参与翻译
(emm..still Chinese version =_=)