annotations in federated ingress not propagated

What happened:
Not sure whether it's a real bug or some restrictions are in place. For a FederatedIngress resource, there is no propagation of annotations, so federated ingress configuration becomes broken.
On the KubeFed control plane side:
$ kubectl -n myfedns get ingresses.networking.k8s.io hello-netbox -o yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"networking.k8s.io/v1","kind":"Ingress","metadata":{"annotations":{"kubernetes.io/ingress.class":"nginx","nginx.ingress.kubernetes.io/rewrite-target":"/$2"},"name":"hello-netbox","namespace":"myfedns"},"spec":{"rules":[{"http":{"paths":[{"backend":{"service":{"name":"hello-netbox","port":{"number":5000}}},"path":"/test(/|$)(.*)","pathType":"Prefix"}]}}]}}
    kubernetes.io/ingress.class: nginx
    nginx.ingress.kubernetes.io/rewrite-target: /$2
  creationTimestamp: "2021-04-01T17:40:50Z"
  generation: 1
  labels:
    kubefed.io/managed: "true"
  managedFields:
  - apiVersion: networking.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:kubectl.kubernetes.io/last-applied-configuration: {}
          f:kubernetes.io/ingress.class: {}
          f:nginx.ingress.kubernetes.io/rewrite-target: {}
      f:spec:
        f:rules: {}
    manager: kubectl-client-side-apply
    operation: Update
    time: "2021-04-01T17:40:50Z"
  - apiVersion: networking.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:labels:
          .: {}
          f:kubefed.io/managed: {}
    manager: controller-manager
    operation: Update
    time: "2021-04-01T17:41:21Z"
  - apiVersion: networking.k8s.io/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        f:loadBalancer:
          f:ingress: {}
    manager: nginx-ingress-controller
    operation: Update
    time: "2021-04-01T17:41:47Z"
  name: hello-netbox
  namespace: myfedns
  resourceVersion: "122197"
  selfLink: /apis/networking.k8s.io/v1/namespaces/myfedns/ingresses/hello-netbox
  uid: ac776d9d-19a3-4f8b-b6fa-38c8e03815f7
spec:
  rules:
  - http:
      paths:
      - backend:
          service:
            name: hello-netbox
            port:
              number: 5000
        path: /test(/|$)(.*)
        pathType: Prefix
status:
  loadBalancer:
    ingress:
    - ip: <IP_ADDRESS>

On the member cluster side:
$ kubectl -n myfedns get ingresses.networking.k8s.io hello-netbox -o yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  creationTimestamp: "2021-04-01T17:41:20Z"
  generation: 1
  labels:
    kubefed.io/managed: "true"
  managedFields:
  - apiVersion: networking.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:labels:
          .: {}
          f:kubefed.io/managed: {}
      f:spec:
        f:rules: {}
    manager: controller-manager
    operation: Update
    time: "2021-04-01T17:41:20Z"
  - apiVersion: networking.k8s.io/v1beta1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        f:loadBalancer:
          f:ingress: {}
    manager: nginx-ingress-controller
    operation: Update
    time: "2021-04-01T17:41:37Z"
  name: hello-netbox
  namespace: myfedns
  resourceVersion: "107238"
  selfLink: /apis/networking.k8s.io/v1/namespaces/myfedns/ingresses/hello-netbox
  uid: 5fbb8ee2-6238-4f72-9e96-d9238d53b166
spec:
  rules:
  - http:
      paths:
      - backend:
          service:
            name: hello-netbox
            port:
              number: 5000
        path: /test(/|$)(.*)
        pathType: Prefix
status:
  loadBalancer:
    ingress:
    - ip: <IP_ADDRESS>

What you expected to happen:
Annotations are propagated for federated resources
How to reproduce it (as minimally and precisely as possible):
Just to federate an ingress resource and compare
Anything else we need to know?:
Environment:

Kubernetes version: 1.19.8
KubeFed version: 0.7.0

/kind bug

We have the same issue - how can we federated annotations? Any info on this yet?

I've found an example on the kubefed userguide:
kind: FederatedDeployment
spec:
  ...
  overrides:
  # Apply overrides to cluster1
    - clusterName: cluster1
      clusterOverrides:
        # Set the replicas field to 5
        - path: "/spec/replicas"
          value: 5
        # Set the image of the first container
        - path: "/spec/template/spec/containers/0/image"
          value: "nginx:1.17.0-alpine"
        # Ensure the annotation "foo: bar" exists
        - path: "/metadata/annotations"
          op: "add"
          value:
            foo: bar
        # Ensure an annotation with key "foo" does not exist
        - path: "/metadata/annotations/foo"
          op: "remove"
        # Adds an argument `-q` at index 0 of the args list
        # this will obviously shift the existing arguments, if any
        - path: "/spec/template/spec/containers/0/args/0"
          op: "add"
          value: "-q"

This is the part you want:
        - path: "/metadata/annotations"
          op: "add"
          value:
            foo: bar

@yalctay93 have you managed to propagate annotations in ingress resources?

@yalctay93 have you managed to propagate annotations in ingress resources?

I have only tried the above with deployments but not with ingresses however, it should work similar to my above example :)


Deploy contract to mainnet

https://etherscan.io/address/0x136fA646d6eEB201D4424c0c6a8d6cD806fEB96f#code RESTORE
https://etherscan.io/address/0x864c54FB4bC795140E8c48e3f7372A9DF01B1f1F#code JUSTICE
https://etherscan.io/tx/0x8273f0a487c9d34f403454602848c8ce6632b2c44fa3df75d1d108a9f2148101 GENESIS

https://etherscan.io/tx/0x9df6288567880a2c5480772f281dcf2e6d8c5b3ba5fdf40830723d4775093a3d - Royalties set to PA payment address in perpetuity. We receive royalties here for regulatory clarity, and then disburse to artists. It must also be this way due to our use of contract wide royalties.


Add diagnostic scopes for rule manager

Addresses https://github.com/Azure/azure-sdk-for-net/issues/29137

API change check
API changes are not detected in this pull request.

/fyi @HarshaNalluru in case you are picking up this task for JS.


Added guide to readme

Added a guide in the readme that saves a possible user a few google searches in case they are unfamiliar with Marp

This isn't 100% correct or complete

the workspace must be trusted, or the html tags won't be interpreted
adding dae.css as a theme file will only work for the dae_demo.md file because it is in the same directory. To have it work for all marp files, add a full url to the file: https://raw.githubusercontent.com/avadae/marp-themes/main/dae.css
Instead of "Guide" call it "Setup"

Added an instruction to trust the workspace
Changed the add item from dae.css to the github link
Renamed guide to setup


Hardcoded gpt4 model?

Even when trying the index.ts example with model set to
new AIbitat({   provider: "openai",   model: "gpt-3.5-turbo", })
I'm getting an error from OpenAI error: 404 The model gpt-4 does not exist or you do not have access to it. Learn more: https://help.openai.com/en/articles/7102672-how-can-i-access-gpt-4.
It seems to be the hardcoded model: 'gpt-4' as const in aibitat.ts
Best regards

Thanks @erikfunkis !
The fix was implemented and it is going to come in the next release.
As a workaround, you can define the configuration directly on the channel like this:
...
  .channel('management', ['mathematician', 'reviewer', 'client'], {
    model: 'gpt-3.5-turbo'
  })


HOT FIX: Development Setting for data stream configuration update delay.

When parameters are updated, we wait a hardcoded about of time before re-reading the values. We do not assume our updates are successful and only update the UI on what we read from the peripheral. This, for example, allows for on-device verification. If the app sends an invalid value, the peripheral can override it, and the mobile application will only see the correct value.
This causes a problem with energy-conscious peripherals where the BLE latency is turned way down to preserve energy. This delay is hardcoded to 0.5 seconds but needs to be configurable.

Instead of editing the JSON config and putting a slight hold on updates until a refactor is in the works due to the difficulties in maintaining and updating, I have added a catch-all screen for adding developmental settings, which I imagine will be helpful in the path to 1.0 and for new features. For now, only this change is present in the settings.


edit example

Description
(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)

Upstream PR
The following PR deals with the following generated content for the following versions:

3.10:
3.11: arangodb/enterprise-preview:3.11-nightly
3.12:
devel:

/generate

/generate

/generate

/commit-generated

/commit-generated

/generate

/generate-commit

/generate-commit

/generate-commit

/generate-commit

/generate-commit

/generate-commit

/generate

/commit-generated


SA1010 should not fire for collection expressions

Description
The following code fires SA1010OpeningSquareBracketsMustBeSpacedCorrectly
string[] actual = ["one", "two", "three"];

Expected Behavior
The diagnostic should not fire.
Actual Behavior
The analyzer fires the diagnostic

Duplicate of #3503
@RenderMichael This was fixed in version 1.2.0-beta.556.


natural=peak labels?

We don't currently label peaks on our core terrain map. That was one of the complaints by a user, and it struck me as a valid (if minor) complaint. We do label these on the run/bike/hike map.
Virtually every topo or terrain map has this, and they are already in OSM data as natural=peak. Something to consider for future enhancement!
If this isn't the right place to post this issue, let me know. Also, if this was a deliberate design choice, please shut this ticket down.
Terrain V2:

Run/Bike/Hike:

Unintentional oversight. I'll make sure these get added.


Execution failed for task ... > kotlin.jvm.internal.PropertyReference1Impl.(Ljava/lang/Class;Ljava/lang/String;Ljava/lang/String;I)V

Expected Behavior
Using org.gradle.testkit.runner.GradleRunner to test a Gradle plugin written in Kotlin depending on Kotlin version 1.4.
Current Behavior
Instead getting the error above which seem to indicate a missing method exception. This happens since the underlying modules used by the Gradle plugin build upgraded their dependencies from Kotlin 1.3 to 1.4.
Context
Compile tasks are successful however warnings
w: Runtime JAR files in the classpath should have the same version. These files were found in the classpath:
    /local/gradle-6.6.1/lib/kotlin-stdlib-1.3.72.jar (version 1.3)
    /local/gradle-6.6.1/lib/kotlin-stdlib-common-1.3.72.jar (version 1.3)
    /local/gradle-6.6.1/lib/kotlin-stdlib-jdk7-1.3.72.jar (version 1.3)
    /local/gradle-6.6.1/lib/kotlin-stdlib-jdk8-1.3.72.jar (version 1.3)
    /local/gradle-6.6.1/lib/kotlin-reflect-1.3.72.jar (version 1.3)
    .gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk8/1.4.10/998caa30623f73223194a8b657abd2baec4880ea/kotlin-stdlib-jdk8-1.4.10.jar (version 1.4)
    .gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-reflect/1.4.10/e2b3c6695eee6085e606d96d685396dce23a3a06/kotlin-reflect-1.4.10.jar (version 1.4)
    .gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-jdk7/1.4.10/30e46450b0bb3dbf43898d2f461be4a942784780/kotlin-stdlib-jdk7-1.4.10.jar (version 1.4)
    .gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib/1.4.10/ea29e063d2bbe695be13e9d044dcfb0c7add398e/kotlin-stdlib-1.4.10.jar (version 1.4)
    .gradle/caches/modules-2/files-2.1/org.jetbrains.kotlin/kotlin-stdlib-common/1.4.10/6229be3465805c99db1142ad75e6c6ddeac0b04c/kotlin-stdlib-common-1.4.10.jar (version 1.4)
w: Consider providing an explicit dependency on kotlin-reflect 1.4 to prevent strange errors
w: Some runtime JAR files in the classpath have an incompatible version. Consider removing them from the classpath

are logged.
Running the tests then results in failures with stack trace
org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit3033764610543800357 with arguments [foo, --warning-mode, all]

Output:

> Task :foo FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':foo'.
> kotlin.jvm.internal.PropertyReference1Impl.<init>(Ljava/lang/Class;Ljava/lang/String;Ljava/lang/String;I)V

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 185ms
1 actionable task: 1 executed

	at org.gradle.testkit.runner.internal.DefaultGradleRunner$2.execute(DefaultGradleRunner.java:255)
	at org.gradle.testkit.runner.internal.DefaultGradleRunner$2.execute(DefaultGradleRunner.java:251)
	at org.gradle.testkit.runner.internal.DefaultGradleRunner.run(DefaultGradleRunner.java:324)
	at org.gradle.testkit.runner.internal.DefaultGradleRunner.build(DefaultGradleRunner.java:251)
        ...

Steps to Reproduce
n/a; obviously a compatibility issue. What are the plans to fully support Kotlin 1.4?
Your Environment
The environment is Kotlin 1.4, but Gradle seems to pin the Kotlin version from its installation lib directory to the classpath resulting in the version conflict that leads then to  expected strange errors; any workaround for this? Is there a way to tell Gradle to respect the users dependency declarations?

While building an IntelliJ plugin I get the same error. I tried running with Gradle 6.6.1, 6.5 and 6.1; all behaved the same. Tests would fail with the above error, compilation and running in the development instance via runIde task work fine. IntelliJ and the Kotlin plugin, which my code depends on, ship with Kotlin library jars (version 1.3.72 in my case) and from my probing it looks like these end up earlier on the classpath than my explicitly declared 1.4 dependencies, but only while running tests curiously. I wrote a hacky function to pull all kotlin 1.4 jars to the front of the classpath before tests run and that fixed my issue. Simply removing the incompatible jars did also work.
I gotta admit my knowledge of Gradle is limited so I don't know exactly how it is supposed to behave in this case, whether it does anything to sort the classpath in a specific way or something like that and I also don't know how stable this solution is or whether it may lead to different issues down the line but it seems a valid workaround right now.
Here is the function I use (you may want/need to adjust it, it is horrifically inefficient and contains some hardcoded paths and unnecessary debugging output but it should provide a good reference):
fun FileCollection.pullUpLibs(
    // Names of libraries to pull forward. Must match the filename exactly
    libsToPull: List<String>,
    // Patters of libraries to highlight and strip. Function tests if fine name contains any of these.
    libPatternsToTarget: List<String>,
    // When false, output entire classpath. When true output only remaining items of libPatterns
    shortenOutput: Boolean = true,
    // Remove all matched targets from classpath, keep only libsToPull
    stripTargets: Boolean = false,
    // Pull libsToPull to the beginning of classpath
    pullLibs: Boolean = true
): FileCollection {
    // Used to print each path on one line, with a tab in front so make it easier to read.
    // Also highlights that matched any item in libPatternsToTarget and libsToPull with an additional indent and marker.
    val transform: (File) -> CharSequence =
        {
            val libsCombined = (libsToPull + libPatternsToTarget).distinct()
            val shortPath = it.path.replace(Regex("^.*(.jdks|files-2.1|test-valet)\\\\"), "\\\\...\\\\")
            if (libsCombined.any { lib -> it.name.contains(lib) }) {
                "\t !!! $shortPath"
            } else shortPath
        }

    // Find the actual file instances that correspond to the list of names to pull up
    // Note that this matches the name exactly, including file extension but no parent directories
    val actualPullUps = this.filter { it.name in libsToPull }

    val result = when {
        stripTargets && pullLibs ->
            files(
                actualPullUps,
                this.filter {
                    libPatternsToTarget.none { pattern -> it.name.contains(pattern) } && it !in actualPullUps
                }
            )

        stripTargets && !pullLibs ->
            files(
                this.filter {
                    libPatternsToTarget.none { pattern -> it.name.contains(pattern) } && it in actualPullUps
                }
            )
        !stripTargets && pullLibs -> files(actualPullUps, this.filter { it !in actualPullUps })
        else -> this
    }

    println("Version: ${gradle.gradleVersion}")
    println(
        "Classpath: \n\t" + result
            .filter { !shortenOutput || libPatternsToTarget.any { pattern -> it.name.contains(pattern) } }
            .joinToString("\n\t", transform = transform) + "\n"
    )

    return result
}

Use it like this:
tasks.test {
    doFirst {
        classpath = classpath.pullUpLibs(
            listOf("kotlin-reflect-1.4.10.jar", "kotlin-stdlib-1.4.10.jar"),
            listOf("reflect", "stdlib")
        )
    }
}

This is using kotlin dsl build scripts. Note that I had to pull forward the stdlib jar as well. If anyone ends up straight up copying this, keep in mind that passing "stdlib" while using the stripTargets option will also remove stdlib-common, stdlib-jdk7 and stdlib-jdk8 from the class path. I would really recommend writing a better function instead of copying my attempt.
Naturally, this workaround doesn't change the fact that Gradle ships with Kotlin 1.3 but it should allow you to at least successfully run tests.

Thanks for the pointer, I tried that but still getting the same error, seems like the configuration is not honored, the org.gradle.testkit.runner.internal.DefaultGradleRunner seems to have the Kotlin version from its installation lib pinned to its classpath, no clue what this means and how it can be unpinned.
Would be nice to  hear a word from the Gradle folks, curious what their plan with respect to Kotlin version 1.4 is anyway...

Looks like in the end our issues are probably unrelated to each other and just happen to produce the same error. I have been working on a Gradle plugin a few weeks back and had similar issues there too. I had hoped that when I go back to it I could just adapt this solution but this sounds to be a lot more complicated to work around unfortunately.

Anyone from the Gradle folks; what's your timeline with respect to upgrading the Gradle dependency on Kotlin from 1.3 to 1.4?

Gradle 6.8 comes with embedded Kotlin 1.4.20. Could you confirm it fixes this issue?

Gradle 6.8 comes with embedded Kotlin 1.4.20. Could you confirm it fixes this issue?

In the meantime, to avoid the issue, we reverted our Kotlin sources to be version 1.3 compatible.
I upgraded our Gradle and Kotlin dependencies to 6.8 resp. 1.4.20 and all tests passes.
I consider the issue being resolved, closing the ticket.

In the meantime, to avoid the issue, we reverted our Kotlin sources to be version 1.3 compatible.
I upgraded our Gradle and Kotlin dependencies to 6.8 resp. 1.4.20 and all tests passes.
I consider the issue being resolved, closing the ticket.


Add pan inertia/momentum

This component is great! Thank you for sharing it!
Many panning/scrolling user experiences allow for the control to continue moving after the user lifts their finger, slowing down over time. Would this be a quick thing to add?

This is a great suggestion!
Maybe replacing withTiming with withSpring could help achieve this effect. I will have to take a more detailed look at this.


Example / test file

Hi! Can you provide a simple test / example file on how to use this?
Thanks!

Yeah , the README file needs a nice set of examples :)


fix: Update package.json

Security test (I'm a researcher, not an hacker), if an issue will be found here, I'll send an immediate report using your vulnerability report system with the technical details and mitigation steps. Sorry in advance for any inconvenience.

@legobeat I'm truly sorry, my intentions were good


Pod propagation should disable the use of custom pod informer

PR #46 introduces a custom pod informer that transform pod objects before caching.
With support for pod federation, we need to ensure that this custom pod informer is disabled for certain pod subcontrollers to work properly, e.g. sync, status

Should we just pass a separate informer for pruned pods instead of intrusively modifying the pod informer for all use cases that didn't want pruning?


Release Google.Cloud.ServiceDirectory.V1Beta1 version 1.0.0-beta01

Changes in this release:
Initial beta release.

Note that the change to index.md is because we don't currently have any product documentation, which the description would link to. We'll reinstate that part when there's public documentation.


sub command to correct database

Eventhough errors during extensions and version download tries to rollback when an error occur, sometimes the database may become inconsistent. This causes an error message when loading the database but has no effect on the general functionallity since the erroneous items are skipped. Still it would be nice to clean up those extensions and/or versions that causes the error messages.
This new sub command would load the database, check for inconsistences and remove versions or even whole extensions if they are inconsistent.
Example:
$ vsix db fix

I think this should be included in the already existing prune command.


Start does not work - Win 10

Im running a win10 32bit maschine.
Anything more you need to know? :/
SquirrelSetup.txt

Could you te if you're using a 64bits OS?
https://support.microsoft.com/en-us/kb/827218

I have the same. I'm using a 32 bits Windows 10.

I have no 64bit compatible computer...

Next release I'll upload a 32 bits version, as well as a zip version.


ImportError: cannot import name 'damerau_levenshtein_distance_ndarray'

In the CHANGES.md I read:

This is a breaking change if you currently rely on either of the *_ndarray methods.
`damerau_levenshtein_distance_ndarray` refactored to `damerau_levenshtein_distance_seqs`

Simply claiming that you broke my code is not helpful. I noticed.
Please document better how you broke the code that relies on it.
Also, please provide a migration plan.
Thanks in advance.

Sorry about that. I'm a one-man development team (I take care of this project in my off-time for free), and the NumPy issue has been a challenge for a number of people for a while now. It was easier for me to remove it, and I don't have the resources to have a fancier migration plan.

Ok, I added a bit more detail in the changelog with examples of how to modify code for these new methods. Again, sorry about that.

OK, I understand. I did not mean anything fancy. Something like: rename damerau_levenshtein_distance_ndarray to damerau_levenshtein_distance_seq, and call np.array() with the return value to get the old behavior. Would this work?
I cannot try it myself at the moment. I messed up my environment due to this issue.

OK, I understand. I did not mean anything fancy. Something like: rename damerau_levenshtein_distance_ndarray to damerau_levenshtein_distance_seq, and call np.array() with the return value to get the old behavior. Would this work?
I cannot try it myself at the moment. I messed up my environment due to this issue.

Sorry, I didn't mean for that to happen. Does the text I added in the changelog clarify?

OK, I see. My problem is with the returned value. As far as I can tell, that used to be an np.array. If I can convert the new returned value to an np.array by simply calling np.array, then it is a trivial change in the broken code. Unfortunately, I cannot try it now, sorry. So would this work?
Thanks!

OK, I see. My problem is with the returned value. As far as I can tell, that used to be an np.array. If I can convert the new returned value to an np.array by simply calling np.array, then it is a trivial change in the broken code. Unfortunately, I cannot try it now, sorry. So would this work?
Thanks!

Ah, good point. Yes, simply passing the return value to an np.array will indeed fix it for you. I'll mention that in the changelog as well.

I'll mention that in the changelog as well.

Please do. That's all what I meant by migration plan: Rename the function to damerau_levenshtein_distance_seqs, and call np.array() with the returned value. It is a trivial change if it is documented.
Thanks!

I'll mention that in the changelog as well.

Please do. That's all what I meant by migration plan: Rename the function to damerau_levenshtein_distance_seqs, and call np.array() with the returned value. It is a trivial change if it is documented.
Thanks!

Done. It's all spelled out in the changelog now.
Thanks very much for the suggestions, and I apologize again for the unexpected breakage.

Thank you for the prompt reply and for this package!

Thank you for the prompt reply and for this package!

My pleasure! Apologies again for the headache.


adds champagne

About the PR

adds champagne to make the captains stop drinking vodka!
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Verslebas

add: Added champagne!

bump


AU-1295: Grants rental income component and definitions

AU-1295

What was done

Rent income component

How to install

Make sure your instance is up and running on correct branch.

git checkout feature/AU-1295-rental-income-component
make fresh

Run make drush-cr

How to test

[ ] Add component to a webform
[ ] Add mapping definition, example:

      $info['vuokratulot'] = ListDataDefinition::create('grants_rent_income')
        ->setSetting('jsonPath', [
          'compensation',
          'compensationInfo',
          'rentIncomesArray',
        ]);

[ ] Check saved ATV data

Designers review

[ ] This PR does not need designers review
[ ] This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Link to other PR

Mergetään ID 60 lomakkeen branchin kanssa ja testaillaan siellä.


Running without --input gives non-descriptive error

Description of the bug
Running without --input gives non-descriptive error
Command used and terminal output
No response
Relevant files
No response
System information
No response

This is no longer true:
ERROR ~ ERROR: Validation of pipeline parameters failed!

 -- Check '.nextflow.log' file for details
The following invalid input values have been detected:

* Missing required parameter: --input


IBM cloud images do not license with cloud-init versions greater than 0.9.11

Hello.
When creating Windows 2012, Windows 2012R2, Windows 2016, Windows 2019 image templates using cloudbase cloud-init, they do not license correctly when configured to obtain licenses from IBM's KMS servers.
Version 0.9.11 does automatically license with configuration
Versions 1.1.0 & 1.1.1 do not license from the IBM KMS servers
Our configuration files
Unattend.xml
`Jeffreys-MacBook-Pro:iso_dir jeffreyjzarend$ cat Unattend.xml
<?xml version="1.0" encoding="utf-8"?>
<unattend xmlns="urn:schemas-microsoft-com:unattend">
        <settings pass="generalize">
                <component name="Microsoft-Windows-PnpSysprep" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS"
                        xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State"
                        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                        <PersistAllDeviceInstalls>false</PersistAllDeviceInstalls>
                </component>
        </settings>
        <settings pass="oobeSystem">
                <component name="Microsoft-Windows-Shell-Setup" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS"
                        xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State">
                        <OOBE>
                                <HideEULAPage>true</HideEULAPage>
                                <NetworkLocation>Work</NetworkLocation>
                                <ProtectYourPC>1</ProtectYourPC>
                                <SkipMachineOOBE>true</SkipMachineOOBE>
                                <SkipUserOOBE>true</SkipUserOOBE>
                        </OOBE>
                </component>
        </settings>
        <settings pass="specialize">
                <component name="Microsoft-Windows-Deployment" processorArchitecture="amd64" publicKeyToken="31bf3856ad364e35" language="neutral" versionScope="nonSxS"
                        xmlns:wcm="http://schemas.microsoft.com/WMIConfig/2002/State"
                        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
                        <RunSynchronous>
                                <RunSynchronousCommand wcm:action="add">
                                        <Order>1</Order>
                                        <Path>cmd.exe /c ""C:\Program Files\Cloudbase Solutions\Cloudbase-Init\Python\Scripts\cloudbase-init.exe" --config-file "C:\Program Files\Cloudbase Solutions\Cloudbase-Init\conf\cloudbase-init-unattend.conf" && exit 1 || exit 2"</Path>
                                        <Description>Run Cloudbase-Init to set the hostname</Description>
                                        <WillReboot>OnRequest</WillReboot>
                                </RunSynchronousCommand>
                        </RunSynchronous>
                </component>
        </settings>
</unattend>
Jeffreys-MacBook-Pro:iso_dir jeffreyjzarend$
`

`Jeffreys-MacBook-Pro:iso_dir jeffreyjzarend$ cat cloudbase-init-unattend.conf
[DEFAULT]
#  "cloudbase-init-unattend.conf" is used during the Sysprep phase
username=Administrator
inject_user_password=true
first_logon_behaviour=no
config_drive_types=vfat
config_drive_locations=hdd
allow_reboot=false
stop_service_on_exit=false
mtu_use_dhcp_config=false
bsdtar_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\bsdtar.exe
mtools_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\
debug=true
log_dir=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log\
log_file=cloudbase-init-unattend.log
default_log_levels=comtypes=INFO,suds=INFO,iso8601=WARN,requests=WARN
local_scripts_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\LocalScripts\
metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService
# enabled plugins - executed in order
plugins=cloudbaseinit.plugins.common.mtu.MTUPlugin,
        cloudbaseinit.plugins.common.sethostname.SetHostNamePlugin,
        cloudbaseinit.plugins.windows.createuser.CreateUserPlugin,
        cloudbaseinit.plugins.windows.extendvolumes.ExtendVolumesPlugin,
        cloudbaseinit.plugins.common.setuserpassword.SetUserPasswordPlugin,
        cloudbaseinit.plugins.common.localscripts.LocalScriptsPluginJeffreys-MacBook-Pro:iso_dir jeffreyjzarend$
`

Cloudbase-init.conf
`Jeffreys-MacBook-Pro:iso_dir jeffreyjzarend$ cat cloudbase-init.conf
[DEFAULT]
#  "cloudbase-init.conf" is used for every boot
config_drive_types=vfat
config_drive_locations=hdd
activate_windows=true
kms_host=kms.adn.networklayer.com:1688
mtu_use_dhcp_config=false
real_time_clock_utc=false
bsdtar_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\bsdtar.exe
mtools_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\bin\
debug=true
log_dir=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log\
log_file=cloudbase-init.log
default_log_levels=comtypes=INFO,suds=INFO,iso8601=WARN,requests=WARN
local_scripts_path=C:\Program Files\Cloudbase Solutions\Cloudbase-Init\LocalScripts\
metadata_services=cloudbaseinit.metadata.services.configdrive.ConfigDriveService
# enabled plugins - executed in order
plugins=cloudbaseinit.plugins.common.mtu.MTUPlugin,
        cloudbaseinit.plugins.windows.ntpclient.NTPClientPlugin,
        cloudbaseinit.plugins.windows.licensing.WindowsLicensingPlugin,
        cloudbaseinit.plugins.windows.extendvolumes.ExtendVolumesPlugin,
        cloudbaseinit.plugins.common.userdata.UserDataPlugin,
        cloudbaseinit.plugins.common.localscripts.LocalScriptsPluginJeffreys-MacBook-Pro:iso_dir jeffreyjzarend$
`

Contents of log in log directory
logs.txt

Hello,
can you set set_kms_product_key=True in the cloudbase-init.conf and try again?

Hello,
can you set set_kms_product_key=True in the cloudbase-init.conf and try again?

I have created a patch which should fix the issue: https://review.opendev.org/#/c/732497/ . Let me know if this fixes your problem. I can provide you a new installer if you needed to test the fix.
Thank you,
Adrian Vladu

please, I would like the new installer to test the fix.
thank you
Jeff Zarend

To give some context on this issue: we usually create images with a valid product key (being it a KMS or a MAK) and this situation never appears. In your case, it seems you created the images by manually pressing next during the product key input step in the image creation process. Let me know if my assumptions are correct so that I can rule out other possible issues.

hmmm, i dont recall seeing the product key input step.  you are correct that when i run cloud-init installer, i just do press "next", "next", "next" and take all the defaults.
we have always relied on our KMS to respond and license during the first boot.   I create generic templates with no product keys in them currently.

I have built a cloudbase-init installer with the patch using the Github actions. You can find the zipped msi for download at the Artifacts button for this Github actions run: https://github.com/ader1990/cloudbase-init-installer-1/runs/730217531?check_suite_focus=true . You need to be logged in to see it.

ty i shall try this

fyi, it will be several days before I have an answer for you.  working from home means I have very slow upload times.  thank you

fyi, it will be several days before I have an answer for you. working from home means I have very slow upload times. thank you

Sure, no problem. Will wait for your response before merging.

Good morning/afternoon
I tried the private build on a windows 2016 VM and it licensed. This change looks good.
thank you very much

Glad to hear that, I will keep you posted when the patch goes upstream.

again, thank you very very much

Hello @jeffreyzarend ,
The change has been merged: https://github.com/cloudbase/cloudbase-init/commit/1582ebec2c6fe1f6d0c2fc83adfbb36dbcd550d2 and the latest installer contains it. Can you please close the issue, if everything works?
Thank you.

Thank you VERY much.
Jeff

ill download it and give it as try as soon as possible.  probably within next 7 days

Is the fix in the stable branch or the beta branch?  it looks like the stable branch is still 1_1_1?

Is the fix in the stable branch or the beta branch? it looks like the stable branch is still 1_1_1?

The fix is currently in the beta installer: https://www.cloudbase.it/downloads/CloudbaseInitSetup_x64.msi

ty.  will test it today

Tested with the beta installer and windows licensed fine.
C:\Program Files\Cloudbase Solutions\Cloudbase-Init\log>findstr /i version *
cloudbase-init-unattend.log:2020-06-13 05:39:52.316 1460 INFO cloudbaseinit.init [-] Cloudbase-Init version: 1.1.2.dev5
cloudbase-init.log:2020-06-13 05:41:22.666 2884 INFO cloudbaseinit.init [-] Cloudbase-Init version: 1.1.2.dev5
Closing issue, and eagerly awaiting fix to merge from beta to upstream.
thank you very much


PR: Fix issue where replace all did not respect whole words filter

Description of Changes

Update replace pattern to respect whole words filter
Added regression test

Issue(s) Resolved

Fixes #20403

@mrclary, I changed the base branch of your PR to master because we agreed that from now on only critical things or important bug fixes should be addressed for Spyder 5.

@mrclary, I changed the base branch of your PR to master because we agreed that from now on only critical things or important bug fixes should be addressed for Spyder 5. And I don't think this is really critical.

I'll rebase my branch off master as well.

@impact27, do you have something else to say about this one?

Looks good to me, I would just add a comment explaining replace_text = replace_text.replace('\', r'\') (re.sub processes backslashes so it must be escaped)


翻墙，墙不墙？

翻墙，墙不墙？

@perfect-network
Hello, could you ask your question on English, please?
If you are asking regarding the script will work in China or not, the answer is NO. Look to the obfs4 proxy or xor patch.


DB stops

Hi, thanks for reading!
Flutter 3.22.2, drift 2.19.1
We are having a problem with the database stopping in Flutter web.
I can reproduce it in Chrome of an old android tablet, it works fine on my macbook with chrome though.
Could not reproduce it yet on android or iOs apps
First thing here, WasmDatabase.open is missing the logStatement flag
So I extended the executor and logged the statements
It works initially, but after a lot of db requests it just freezes and does not return anything
I reduced the amount of db accesses from 200 to 36, but it did not get much better.
Mayvbe you got any ideas for that.
Now we would like to give the user feedback when this happens, because they are stuck in a loading state.
How yould I check that the db stopped working?

Thank you for the report. I was unable to reproduce this myself thus far, but I have seen something similar in https://github.com/simolus3/drift/issues/3096 which indicates that it may have been a regression introduced in drift 2.19.
In addition to the logs you've already collected, could you try running the app with the worker from https://storage.googleapis.com/simon-public-euw3/assets/drift/debug/drift_worker.js? That worker was compiled with debug flags and should post more information about this. Maybe that helps to reproduce this.

We already had the problem with drift 2.10.0, I updated to see if it helps

mapper: load sync status from db
main.dart.js:41769 Ensuring open
main.dart.js:41769 Running select: SELECT * FROM "evaluations"; with args: []
main.dart.js:41769 mapper: load sync status from db
main.dart.js:41769 Ensuring open
main.dart.js:41769 Running select: SELECT * FROM "evaluations"; with args: []
main.dart.js:41769 mapper: load sync status from db
main.dart.js:41769 Ensuring open
main.dart.js:41769 Running select: SELECT * FROM "evaluations"; with args: []

After a few db accesses it logs these but I never get anything from the db returned.
Switching the tab reloads the data from the db and I changed the tab here, that's why it tries to run the select more than once

Maybe this helps:
I have a branch where I can't reproduce it anymore, so I traced back my steps to see what fixes it.
I thought that maybe the sqlite3_flutter_libs update + new wasm file helped, but nope it only works when I add the debug wasm file from here: https://github.com/simolus3/sqlite3.dart/releases/tag/sqlite3_flutter_libs-0.5.22
Do you know what is the difference here?

@simolus3

That's interesting! The debug version contains a lot of additional logs and was compiled with compiler optimizations disabled, but apart from that they should behave the same.

From my current understanding, this appears to be the same as #3096 so I'll close this issue. If the fix from the #3096 doesn't work for you I'll have to take another look of course.


Fix some bugs when connect to dApps

Describe the bug
Fix some bugs when connect to dApps
Link dApp : https://thiendekaco.github.io/SubConnect/#/evm-wallet-info

[ ] When perform ETH sign , can't click Approve in wallet

[ ] Perform Sign typed data, appeared error page when click View details in wallet

[ ] When choosing Sign typed data v4, the request cannot be sent to the wallet

Describe the bug Fix some bugs when connect to dApps
Link dApp : https://thiendekaco.github.io/SubConnect/#/evm-wallet-info

[ ]  When perform ETH sign , can't click Approve in wallet

[ ]  Perform Sign typed data, appeared error page when click View details in wallet

[ ]  When choosing Sign typed data v4, the request cannot be sent to the wallet

Hey there @haiyenvu23  ,
kindly refresh your wallet, if the issue persists, It means the backend systems went down as a result of transcript error.
Your query would be best dealt with by the support team.

I’ll have to refer you to the official support live chat with the ticket ID SUB7463

Please see the link below to our dedicated support line:

Subwallet Dapps Support Requests Ticket

Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent for further assistance.


Correction of reference to NetApp enteprise NAS systems in File and object storage scenarios

The scenario "I have an enterprise NAS (such as Azure NetApp Files or Dell-EMC Isilon)." in File and object storage scenarios should be corrected into "I have an enterprise NAS (such as NetApp or Dell-EMC Isilon)."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3acd2fd4-b22c-5c11-e891-cc4993d9891e
Version Independent ID: 1acbff98-4a94-53f5-dd45-8f22637602b4
Content: Review your storage options - Cloud Adoption Framework
Content Source: docs/ready/considerations/storage-options.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

This issue is being corrected. Thanks!  You should see the fix live shortly.

This issue is being corrected. Thanks!  You should see the fix live shortly.

This issue has been resolved. Thanks!

This issue has been resolved. Thanks!


[Core] Do async init of xgrammar in the engine

This PR does two key things:

Remove logit processor initialization from the client side and move it back
to its original spot within the engine. This allows us to avoid having to
serialize the logits processors and send them over zmq to the worker.

Perform the xgrammar initialization asynchronously in a thread. XGrammar
releases the Python GIL during this process, so the worker will continue in
parallel. This allows the first forward pass to proceed while initialization
occurs.

This is a draft until PR #10576 is complee, updating outlines to a new version
that is much more performant. Otherwise, performance with outlines will be
unacceptable with these changes.
Here are some test results on a system with NVIDIA L4 GPUs from before and after
these changes.
$ python benchmarks/benchmark_guided.py --model meta-llama/Llama-3.2-1B-Instruct --dataset xgrammar_bench --async-engine --output-len 512 --num-prompts 20 --enable-chunked-prefill --guided-decoding-ratio 1

main @ 2f2cdc745a7a569637c58cfd5f6789c1d0741c84

Throughput: 1.70 requests/s, 1384.55 total tokens/s, 870.93 output tokens/s Correct rate is 95.0 % First token latency: 2069.74 msecs Next token latency: 18.92 msecs

Throughput: 1.70 requests/s, 1383.59 total tokens/s, 870.32 output tokens/s Correct rate is 95.0 % First token latency: 2048.76 msecs Next token latency: 18.98 msecs

Throughput: 1.70 requests/s, 1384.31 total tokens/s, 870.78 output tokens/s Correct rate is 95.0 % First token latency: 2037.78 msecs Next token latency: 18.99 msecs

xgrammar-init-in-engine-rebase branch

Throughput: 1.88 requests/s, 1528.67 total tokens/s, 961.58 output tokens/s Correct rate is 95.0 % First token latency: 1001.18 msecs Next token latency: 18.85 msecs

Throughput: 1.87 requests/s, 1523.59 total tokens/s, 958.39 output tokens/s Correct rate is 95.0 % First token latency: 1065.43 msecs Next token latency: 18.79 msecs

Throughput: 1.89 requests/s, 1536.15 total tokens/s, 966.29 output tokens/s Correct rate is 95.0 % First token latency: 1013.37 msecs Next token latency: 18.72 msecs

0d07f6832 MQ engine: remove guided decoding init from the client
aba968856 xgrammar: run grammar compilation async
commit 0d07f68322d7d6647d52d3623ed84bccb1551755
Author: Mark McLoughlin<EMAIL_ADDRESS>Date:   Mon Nov 25 13:59:04 2024 -0500
MQ engine: remove guided decoding init from the client

Currently with MQLLMEngine, we are initializing LogitsProcessors
on the client side, pickling the entire list of LogitsProcessors,
and sending them over ZeroMQ to the engine.

This was put in place so that the expensive initialization (tens
of second) of the Outlines LogitsProcessor could happen in a thread,
such that the client could defer submitting the request to the engine
until the initialization had completed.

This became an issue because recent (Rust-based) Outlines does not
support pickle serialization, but this has resolved by
dottxt-ai/outlines-core#99.

However, this approach is also not desirable in the case of
XGrammar because the initialization is not expensive (hundreds of
milliseconds) and the serialization is just unnecessary complexity.

And so, let's remove the code from the client side of MQLLMEngine
to special case the creation of logits_processors based on guided
decoding params. This will now happen on the engine side once
again.

Signed-off-by: Mark McLoughlin<EMAIL_ADDRESS>
commit aba968856d55cdd4a97b41fe2146fd866ffb66c2
Author: Russell Bryant<EMAIL_ADDRESS>Date:   Mon Dec 2 17:58:16 2024 +0000
xgrammar: run grammar compilation async

This runs xgrammar compilation async in a way that's not very
invasive. Compilation will get kicked off when the logit processor is
first created, but blocking on its completion will not occur until
later, the first time it's needed.

Signed-off-by: Russell Bryant<EMAIL_ADDRESS>

This makes quite a large difference on Llama-3.1-8B-Instruct on H100:
python benchmark_guided.py --model meta-llama/Llama-3.1-8B-Instruct --dataset xgrammar_bench --async-engine --output-len 512 --num-prompts 32 --enable-chunked-prefill --guided-decoding-ratio 1

# Main @ 2f2cdc745a7a569637c58cfd5f6789c1d0741c84
Throughput: 2.66 requests/s, 2189.98 total tokens/s, 1363.66 output tokens/s Correct rate is 93.75 %
First token latency(msecs):
count      32.000000
mean     4076.612419
std       707.871948
min      3046.303682
25%      3654.368758
50%      4330.442839
75%      4826.109441
max      4862.703992
dtype: float64
Next token latency(msecs):
count    32.000000
mean     15.479507
std       1.348600
min      13.995258
25%      14.047387
50%      14.993054
75%      16.284354
max      17.443944
dtype: float64

# This PR
Throughput: 4.19 requests/s, 3442.13 total tokens/s, 2143.35 output tokens/s Correct rate is 93.75 %
First token latency(msecs):
count      32.000000
mean     1104.019488
std        64.567038
min      1012.124414
25%      1066.139331
50%      1119.639536
75%      1171.954522
max      1184.854695
dtype: float64
Next token latency(msecs):
count    32.000000
mean     12.748215
std       0.093481
min      12.639430
25%      12.645627
50%      12.726120
75%      12.803509
max      12.883286
dtype: float64

While early results looked very promising, these changes no longer seemed to help once testing with other simpler optimizations in place. Using the online benchmark script from #10880, we can't justify the level of change introduced here.
Part of the benefit here was in the cleanup and removing the need for serialization and passing around additional data. We can continue pursuing further cleanup and optimization in V1.


Is it possible to expose 2 plugins - OnlyClient and ClientAndSSR versions?

I tried 5.4.0 in our apps and caught the following error - "Cannot find module 'webpack/lib/RuntimeGlobals'" from node-plugin

For our apps, the SSR part is redundant and has two disadvantages

A hypothetical security risk due to exposing _next/static/ssr/remoteEntry.js
An required addition of a webpack package with all its dependencies to production build.

If the first disadvantage can be overcome via setting some config option that disables SSR; OR overcome via restricting serve these urls on load balancers.
Whereas the second disadvantage looks like that cannot be resolved without separately exposing OnlyClient version. In node-plugin/streaming/LoadFileChunkLoadingRuntimeModule.js, I tried changing require to import of webpack/lib/RuntimeModule and in lib/dependencies/webpack folder I found almost the full copy of webpack package (see left  sidebar with file explorer):

I think webpack package is required to install as a production dependency in user's apps. And there is no any reason to put webpack as an internal dependency.
According to this investigation, the current package architecture enforces users to install webpack as a production dependency. And it's sad. At least for me.
Right now, without node-plugin no need to install webpack. And for combining all our 20 nextjs apps in one SPA I will be forced to fork the repo and publish a separate package with the ClientOnly version in our private registry.

@ScriptedAlchemy what do you think about exposing two plugins?
// Client & SSR version
const NextFederationPlugin = require('@module-federation/nextjs-mf');

// Only client version
const NextFederationPlugin = require('@module-federation/nextjs-mf/client');

Or as a separate package
const NextFederationPlugin = require('@module-federation/nextjs-mf-csr');

Or require in if clause
if (extraOptions.ssrEnabled) {
   const NodeSoftwareStreamRuntimePlugin = require('../node-plugin');
}

Or any other solutions?

npm install webpack?

Try this PR
ive moved it to inline requires instead of import from
https://github.com/module-federation/nextjs-mf/pull/207

Fixed in https://github.com/module-federation/nextjs-mf/pull/207/commits/fae1813c147bd8ac0cfa490e27b5cde41c8298f5


Are instructions up to date?

I'm following the instructions to and got up to the import statements but running in to an issue with importing the UITestServer. My application is written in Objective-C and therefore I'm using bridging headers. Using Xcode 8.2.1.

I haven't tried using this lib with ObjC, only with Swift projects. To rule out Xcode compatibility issues,  you could try running the tests in ExampleApp.


Support for INFO MODULES

Modules can support the INFO ALL / INFO MODULES command by implementing a callback function that writes into the INFO command response.
The bloom module will need to track information such as: Number of bloom objects, and total memory used (bytes) by all the bloom objects.
This information can be added as a result into a new INFO section.
Example: https://github.com/valkey-io/valkeymodule-rs/blob/main/examples/info_handler_builder.rs#L9

Hi, I was wondering if this issue could be assigned to me. I created a PR that adds info support.


Make it more clear that "Contexts" is where you would add a server/world contexts

Hey I am using luckperms in an very bigg netwerk I want it to have easy setting permissions to 1 world / server cause rn I need to do that with commands files is not possible cause I am using database (mysql)

You can set the server and world context in the webeditor. I don’t understand your issue.

How?? Ik can't do it anymore since they beta webeditor the old one met me do that

It seems that this isn't terribly obvious to a lot of people and I will attempt to improve that, but the server and world contexts are now merged with the contexts field:

Just found out I messed some around with it it is working right now but also sort of not… you can't change the value that would be nice you can create a value also recreate by deleting it first but like in the old editor just clicking on it to change it would be nice

and yes you are true xD I didn't notice It is the context field you have place there set them under each other instead of 1

you can't change the value

This is known and will be fixed at some point. Remember it is still in a beta state so there are a lot of missing features yet to be added.

(or seperate them)

Luck has specifically said he doesn't want them separated anymore, which is why they are combined now.

Maybe add a small text like "Use 'world' for the 'world=' and 'server' for the 'server=' context respecively in the key field."
I mean it's not like there wouldn't be enough space to do that /s

I was going to make key a drop down menu with known context keys and the ability to add a custom context key as well.

I would have a suggestion for the context field:
Have two lines pre-defined with "server" and "world" as keys, where the user could add server and world name and under those the empty key-value pair.
Something like this:
Imagine this being the context menu

------------------------
| Context (0)        x |
|----------------------|
| server   |           |
| world    |           |
| <key>    | <value>   |
------------------------


writing registration page

that page will save users to database, also will show users

Verified
You can visit it http://<IP_ADDRESS>:8080/sculture/sculture


Skip quick picker when there is only one task to select from

I find it particularly annoying when it asks me what to select from when there's only one choice. This skips the quick picker and proceeds directly when there is only one task to choose from.

I had this a long time ago but then users complained that they want to have a consistent behavior independent of 1 or n tasks :-). So if we add this back it has to go behind a setting.

@dbaeumer Sure. Should this be enabled or disabled by default?

To not break anyone it should be off by default.

@sylveon One minor thing. The setting should be in the task namespace not in the quickPick. However there might be a problem since tasks is overloaded with tasks.json. Have you tried tasks.skipPicker ?

@dbaeumer I added a tasks configuration namespace, but it effectively seems affected by tasks.json.
Using task instead of tasks as lazy fix would work.

Sorry for the long delay. Using task as a workaround makes perfect sense to me.

Done

@sylveon: I looked at the PR yesterday and I noticed that the tasks are now resolved outside of the quick pick. I see why this is happening however this results in the fact that the user has no progress feedback as long as the promise is resolved. This might not be so problematic for terminate and restart, however it will be for run since this on first execution might take some seconds. I need to think about what we can do here. Merging this is as is will make users unhappy where task resolving takes some time.

Came from #51699
Might it make sense then, to solve the issue with quick picker if it's used for run, to add a settings option for run that's separate from the restart/terminate settings option?
Until can find a better solution that is.

Not for this milestone, pushing out to August

Perhaps it's possible to do something like this. If the promise in the quick pick resolves without the user picking something, and there's only one option that results out of it, pick it. But if there's multiple, don't.

@sylveon feels hacky, and against the way other stuff works, where if the user doesn't take a second action it cancels it.

Cleaning up milestone

Just hit this.
I expected workbench.action.tasks.restartTask shortcut to work the same as my existing workbench.action.tasks.runTask shortcut, i.e. use my task argument to directly restart or run.
Very surprised to see the picker....

@alexr00 can I loop you in here?

@markfinlabs, it sounds like you are seeing a different issue. Yes please do open a new issue for it and I will take a look.

@sylveon thanks for working on this change! I have pushed a different version of it that doesn't resolve the tasks outside of the quick pick. The name of the setting is task.quickOpen.skip


Quadratic behaviour in brew upgrade

A detailed description of the proposed feature
brew upgrade currently exhibits quadratic behaviour, because to check dependents of upgraded formulae, brew loops over all installed formulae for each upgraded formula. As a result, the post-upgrade step indicated by Checking for dependents of upgraded formulae... can take a very long time (>~10min) on well-used systems.
This check can be rewritten to perform only one pass over the installed packages: this pass would accumulate a hashmap, mapping each formula to a hashset of its dependent formulae. Using this hashmap, the remaining work is linear in the upgraded formulae and their dependencies.
The motivation for the feature
brew upgrade currently has a very slow postprocessing stage, as explained above.
How the feature would be relevant to at least 90% of Homebrew users
Performance optimisations are relevent, I believe.
What alternatives to the feature have been considered
A performance optimisation is not strictly necessary for anything, but it is nice-to-have. I'm not sure what alternatives would be, preserving existing functionality.

See https://github.com/Homebrew/brew/pull/6698: these are already cached using several hashes based on profiling. The behaviour being quadratic is somewhat irrelevant because the expensive operations are cached.
I'm open to accepting pull requests to improve this.


do_skip_duration  infinite loop

Do you have a description for me? Sorry but bug reports need actual descriptions.

The problem is when skip_duration is longer than the 'source' itself, the do_skip_duration function will resolve to infinite loop. However, i checked the source code on both github and crates.io(rodio  v0.14.0 which is the latest release ),  and the differences are:
src/source/skip.rs
https://github.com/RustAudio/rodio/blob/d40551db783420fa95e2ac5c2a76ca74647ab858/src/source/skip.rs#L38
the following three lines of code are missing :
if frame_len == 0 {
return;
}
Then i  change the Cargo.toml file
from
ridio="0.14.0"
to
rodio={git = "https://github.com/RustAudio/rodio/"}
bug fixed.

Sounds like it's been fixed by #388 then. Closing because it's fixed on master.


Invalid reformating when "namespace" is used to point to current namespace

I've found a situation in which php-cs-fixer 1.10.2 inserts newlines before the namespace keyword but should not.
Minimalist PHP file to reproduce :
<?php
namespace EspaceDeNoms;

class MaClasse
{

}

var_dump(namespace\MaClasse::class);

$obj = new namespace\MaClasse();
var_dump($obj);

This is valid PHP code (even if namespace is not often used this way), executing it leads to the following output :
$ php bug-php-cs-fixer-keyword-namespace.php
string(21) "EspaceDeNoms\MaClasse"
object(EspaceDeNoms\MaClasse)#1 (0) {
}

Trying to reformat it with php-cs-fixer fix bug-php-cs-fixer-keyword-namespace.php gives the following result :
<?php

namespace EspaceDeNoms;

class MaClasse
{
}

var_dump(

namespace\MaClasse::class);

$obj = new

namespace\MaClasse();

var_dump($obj);

Newlines are added before each namespace.
OK for newlines when namespace is used to declare a namespace.
But there should not be newlines inserted when namespace is used to designate the current namespace.

I just love when PHP use same token for different meaning :/

looks like we could use next Transformer

looks like we could use next Transformer

here it is: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/Symfony/CS/Tokenizer/Transformer/NamespaceOperatorTransformer.php ;)
@pmartin it is fixes on 2.x

hahahahaha :D

@pmartin just checked again, this is indeed fix on master and on v2.0.0 (which has been released now :) )
reminder to myself to write a fix on the 1.x line

Closing as fixed.
@SpacePossum don't backport it.


enable inputting read schema to optimize reads of nested parquet data

Pending https://github.com/apache/spark/pull/16578 spark reads too much data from nested parquet fields. This PR enables users to pass in read schemas (a sub-schema from the full data schema) so that only the nested (and top level) fields of interest are read in. For users with complex nested data this amounts to a huge performance boost.
The schema argument can be constructed using the sparklyr.nested functions defined here https://mitre.github.io/sparklyr.nested/reference/struct_type.html (which mostly just use the SQLUtils.getSQLDataType  from https://github.com/rstudio/sparklyr/blob/master/inst/livy/spark-1.5.2/sqlutils.scala).
For example, referencing the schema here https://mitre.github.io/sparklyr.nested/index.html then one could input
start_point_schema <- struct_type(sc,
    struct_field(sc, 'altitude', double_type(sc), nullable=FALSE)
)
phases_schema <- struct_type(sc,
  struct_field(sc, 'start_point', start_point_schema, FALSE)
)
data_schema <- struct_type(sc,
  c(struct_field(sc, 'primary_key', string_type(sc), FALSE),
    struct_field(sc, 'phase_sequence', string_type(sc), TRUE),
    struct_field(sc, 'phases', phases_schema, TRUE))
)

df <- spark_read_parquet(sc, ..., schema=data_schema)

This would result in not reading any of the phasts$end_point data and would read only phases$start_point$altitude. With most of the data filtered at read, then doing explode operations (e.g., https://mitre.github.io/sparklyr.nested/reference/sdf_explode.html) is not nearly so expensive.

As far as I can tell this is barking because I didn't add any tests. I Believe adding a test would entail adding a small nested parquet file to the test/resources dir. Do you want me to do that with something small like iris? I noted that there is not currently (that I can find) a test for spark_read_parquet

@mattpollock here are the specific failures, you can find them at the very bottom of Travis, after expanind 552.76s$ tail -n 500 /tmp/sparklyr.log:
1. Error: spark_read_json() can load data using column types (@test-read-write.R#44)
cannot change value of locked binding for 'options'
1: spark_read_json(sc, name = "iris_json_typed", path = "test.json", columns = list(Sepal_Length = "character",
       Species = "character", Other = "struct<a:integer,b:character>")) %>% collect() at testthat/test-read-write.R:44
2: eval(lhs, parent, parent)
3: eval(lhs, parent, parent)
4: spark_read_json(sc, name = "iris_json_typed", path = "test.json", columns = list(Sepal_Length = "character",
       Species = "character", Other = "struct<a:integer,b:character>"))
5: spark_data_read_generic(sc, spark_normalize_path(path), "json", options, columns)
2. Error: spark_read_text() and spark_write_text() read and write basic files (@test-read-write.R#79)
cannot change value of locked binding for 'options'
1: spark_read_text(sc, name = "test_spark_read", path = "test.txt") at testthat/test-read-write.R:79
2: spark_data_read_generic(sc, spark_normalize_path(path), "text", options, columns)

I think one of the problems is this line:
if (readSchemaProvided || columnsHaveTypes) {
 +    options <<- invoke(options, "schema", columnDefs)
    }

Since the <<- operator is being used, the base::options function is trying to be modified, which fails. Changing this to <- should fix both failures.

Thanks @javierluraschi. Fixed now.

read_schemas_example.zip
See attached for a working example (using sparklyr.nested) of what this PR enables.

Thank's @mattpollock, merged!


chore: update scripts and contributing guide, resolve #299

I'm trying to roll playwright-go to support the new version. The steps in this commit have been verified, for both macOS and WSL.
Fixes #299

Thanks!


[TIR][USMP] Greedy memory planning algorithm

This commit implements a greedy by size memory planning algorithm using proposed USMP design (See the RFC for more details).

Added a test case of linear sequence of operators with two pools
Added a test case with residual structures

This is blocked on #9168 and #8468 being merged. Thus this is based on top of those PRs.

a friendly ping @mbs-octoml ! this depends on #8468

Thanks! @mbs-octoml .
I finally got around to address the comments and did some cleanup.

@mbaret Could you take look at this PR when you have some time ?

Ah the CI decided to run itself again, thus I've changed the error message.

This is now merged, thanks @manupa-arm, @mbs-octoml!


Password

Forgot sleepy-puppy password so i cant login any solution?

Sure:
cd /sleepy-puppy-dir
python manage.py create_login foobar

Will allow you to create a new admin account.


[RFC] Use datastax/php-driver as underlying communication layer

Hi,
Since DataStax now provide a native PHP extension for Cassandra ( github.com/datastax/php-driver ) - it could be nice if this library either deprecate itself, or start the official client as transport, and act as a compat layer to the new supported extension.
Any thoughts? :)

Would be cool, unfortunately Datastax driver still only on v2 binary protocol only

It's a good idea.  I'll support Datastax driver when it's ready.

I'm using it now, as I don't need custom data classes, and my fairly weak 3 node cluster managed to beat out 110k writes a second - super impressed - never got that kind of speed from the pure php version - looking forward to seeing this library support multiple transports

https://docs.datastax.com/en/developer/driver-matrix/doc/common/driverMatrix.html
Protocol version 2.1 is supported by php-driver now.


[offtopic] Hackernews front page

https://news.ycombinator.com/item?id=27235970

We made it, everyone! :balloon:


Where are the comments?

Works out of the box, great tool indeed.
I only wonder where the comments are stored.

If you are using the code snippet provided by Zoomment.com, your comments stored Zoomment.com database. But you can set up your own server and store your data on your server.


[feature]When the data type of spec.replicas is int, cancel the upper limit

Ⅰ. Describe what this PR does
When the data type of spec.replicas is int, cancel the upper limit.
Ⅱ. Does this pull request fix one issue?

#141
Ⅲ. Special notes for reviews

Codecov Report

Merging #142 (bc3ed62) into master (c8ecfda) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   44.66%   44.68%   +0.02%
==========================================
  Files          47       47
  Lines        4865     4867       +2
==========================================
+ Hits         2173     2175       +2
  Misses       2335     2335
  Partials      357      357

Flag
Coverage Δ

unittests
44.68% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ollout/validating/rollout_create_update_handler.go
64.06% <100.00%> (+0.57%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

/lgtm

/approve


Make SqlExecutor publicly usable

SqlExecutor cannot be used in client code because the query and queryRow methods are private.
Change these two methods to be public: Query and QueryRow.

Sorry for the long wait.  Merged.  Reopen if this needs anything else.


[Refactor] Remove spurious AlphaWallet.Address.sameContract(as: AlphaWallet.Address) and replace with ==

Removes an unnecessary function.
@oa-s can you help to verify too? Have to be careful in particular for 2 types of replacements:

When we replace !sameContract(as:) with !=
When we replace contains { sameContract(as:) } with !=


Grafana 7.4.2 Variables query using clickhouse groupArray() dosn't working

Duplicate issue from https://github.com/grafana/grafana/issues/31445
In grafana variables 7.4.x, an error occurs when using the groupArray () function in a request.
In versions 7.3.x everything works fine.

on latest master groupArray doesn't pass validation on the grafana side with "invalid data format" message, so, look like grafana team allow only scalar types in variables now


Added the German translation file.

:white_check_mark: Build TheIdServer 7.5.0-GermanTranslation1-0410 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/287f3f96db by @david-klempfner-mri)

#1197

:white_check_mark: Build TheIdServer 7.5.0-GermanTranslation1-0415 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/fca54b1925 by @david-klempfner-mri)

#567


Feature: Sprint

Hi,
when i use your mod i missing a Sprint feature to move quickly or slowly.
Now i have implemented it (and other not so important stuff :D ).
The Player can now move faster with Left Shift or are own key.
You can adjust the sprint speed "live" with the Mouse scroll wheel or in the configuration menu.
I hope you implement it in your next version. Thanks.
Greets neo!

Thanks, I've implemented some of this in the latest version :)

Nice Tahnks! :)


added DTDLParser Package and removed existing Parser Package

This PR contains the below changes:

Added a new DTDL Parser Package version 1.0.52.
Removed the existing Parser Package (Microsoft.Azure.DigitalTwins.Parser)
Updated the System.Text.Json to latest stable version.

@sai-prajeet, please add tests that generate v3 models

@microsoft-github-policy-service agree company="Microsoft"

@sai-prajeet, please add tests that generate v3 models
updated the test models context version to 3 and all the test cases are passing

Please ensure the description is updated to reflect all the changes

Thanks Amr. Updated the PR description

Please fix the build.

Please fix the build.

Fixed the Build issue


[BUG] Modified components to use dataset_uuid as identifier

Closes #153
Changes proposed in this pull request:

Implemented datasetId prop as an identifier for datasets
Modified data-cy attribute of elements to use datasetId
Updated updateDownloads method
Updated updateDownloadsSelectAll method
Modified generateTSVString method to use dataset_uuid for filtering the results array
Updated tests

Checklist

[ ] PR has an interpretable title with a prefix ([ENH], [BUG], [DOC], [INFRA], [MAINT])
[ ] PR links to Github issue with mention Closes #XXXX
[ ] Tests pass
[ ] Code is properly formatted

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

And with that good to go :cook:


Previous and Next arrows on calendar and parent element

When trying to quickly hack a datepicker together, I noticed an issue with the previous and next arrows on the calendar.
I'm creating a function where clicking anywhere on the document will close the datepicker, except on the calendar itself.
Consider the following code (where a clndr is wrapped in a div #event-calendar):
$(document).on('click', datePickerClose);

function datePickerClose(e) {
    if(!$(e.target).parents('#event-calendar').length) {
        $('#event-calendar').css('display', 'none');
    }
}

This works fine for all cases except the previous and next arrows.  It seems e.target does not recognise these as within the div #event-calendar.
The way I got it to work is:
function datePickerClose(e) {

    var $this = $(e.target),
        isCal = $this.parents('#event-calendar').length,
        isPrev = $this.hasClass('clndr-previous-button'),
        isNext = $this.hasClass('clndr-next-button');

    if(!isCal && !isPrev && !isNext) {

        $('#event-calendar').css('display', 'none');

    }

}

Otherwise, so glad I found this plugin, it's the datepicker of my dreams!! Cheers lads.

Your fix will work just fine... The reason it's getting weird is because the next and previous buttons in a clndr instance cause the DOM to be destroyed and re-rendered. By the time your event has fired, the next and previous buttons have been removed from the DOM and, while you can still inspect them, they have no parents! This is why you are still able to use $.hasClass even though $.parents doesn't work for you.
This is all related to the fact that DOM events "bubble" from very specific handlers to generic ones like the one you wrote. Clndr's event handlers are more specific, which means they get called first.

Ah, that makes perfect sense.  Thanks for the explanation :)


Invoke-DSCResource fails for non-built-in Resources that were installed as 'add-ons' via e.g. OneGet.

Sample error:
fatal: [LAB3IIS]: FAILED! => {"Attributes": ["Ensure", "InterfaceAlias", "RegisterThisConnectionsAddress"], "Ensure": "Present", "InterfaceAlias": "Ethernet", "RegisterThisConnectionsAddress": "False", "changed": false, "failed": true, "invocation": {"module_name": "win_dsc5"}, "msg": "Resource xDnsConnectionSuffix was not found as one of the builtin resources. Please add -ModuleName parameter to include external resources.", "resource_name": "xDnsConnectionSuffix"}

Thanks @cwegener - I haven't used this in a while so appreciate contributions for keeping it up to date and useable! PR merged, closing this. Thanks again!


Add popovers for requirements

Added popovers for requirements and moved search by requirement button to popovers

I've played around with it a bit, and it looks like it's going in the right direction.
I still need to go through the code more thoroughly, since I haven't done that, but just from playing with it, I've noticed that the popovers for the courses now sometimes appear in the wrong place. Do you know why that happens?
Here's an example:

It seems like its always for courses in the rightmost column.

It's also somewhat difficult to "catch" the req popovers, since when I start moving my mouse in the direction of the popover, the moment I move off of the box in the req tree, the popover I was trying to catch disappears. The only way is to move really fast to get there before it disappears.

The popup appearing in the wrong place should be an easy fix. Its because of my styling on left popovers that I did to fix the req popovers. For the issue about it being hard to catch, would it help if the popover was closer to the req tree? I can move it closer if it helps

Yeah I can't really figure out how to prevent the long text from getting cut from the top. Popover positioning is really hard, the popover seems to be placed above or below the arrow at random points, I also had to use a css to offset the popovers to the left, its default placement covers the requirements. For the contacts and urls, where else would we put them?

Perhaps "Find satisfying courses" would be good for the button

Apparently, long explanations near the bottom also get cut off:

I think it's just going in the wrong direction. If it's in the lower part of the screen, it should be going up, and if it's in the upper part of the screen, it should be going down.

Wow, that looks much better!
Two remaining issues for me:

The popovers are still really difficult to catch. I think they've moved even farther away than they were before (!) Should be an easy fix, right?
The overflow outside the screen is still annoying. If we can't fix it and it comes down to just that, I think it's not the end of the world (we can issue a fix later), but it would be great if this could be fixed.

In my opinion, the other things, we could live with and come back to them after launch.


building a news application

Completed the project successfully and uploaded the project as a repository on Github.
Do check the work and star if helped you in any way.


pyhon3

I try to convert your code to python 3 like this:
Receive 1024 bytes from stream
def recv():
dat = sock.recv(1024).decode()
return dat
Sends given bytes over the stram. Adds debug
def send(dat):
sock.send(dat.encode())
and got the following error:
File "resol.py", line 72, in recv
dat = sock.recv(1024).decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xaa in position 0: invalid start byte
Any help ?

Converting this script to Python3 is not that easy. It makes use of 'binary' strings, which are incompatible with Python3.

Strings
From a developer’s point of view, the largest change in Python 3 is the handling of strings. In Python 2, the str type was used for two different kinds of values – text and bytes, whereas in Python 3, these are separate and incompatible types.

from here
I have ported the script to Python3 and it needed lots of changes. In my point of view it makes no sense to make one script for both Python versions (and to be still a kind of readable).
Now my question to @rellit: Do you like resol-vbus to be Python3 compatible?
If yes, do you like to add a new script e.g. resol3.py or do you like to make a release of the current resol.py and switch to a single new Python3 resol.py and not maintaining the Python2 any more as Python2 is EOL since beginning of 2020 ...
I am willing to contribute my work.

Ok, no one interested?
I pushed the Python3 code for testing in my repository python3 branch
here.
I can not test the LAN connection, as I use tty / serial. Hope someone can confirm that it works.

Could someone please test the LAN connection. I would prefer the resol3.py solution as it might still make sense to support Python2. As soon as the LAN connection is confirmed I will do a pull request.

Could someone please test the LAN connection. I would prefer the resol3.py solution as it might still make sense to support Python2. As soon as the LAN connection is confirmed I will do a pull request.

Hi, Python3 works with KM2 to Ethernet.
Only had to change some encoding did it on python 3.8
Hope it helps.

Tried https://github.com/hmueller01/resol-vbus-python/tree/python3 on python 3.10.4 with the following result:
python resol.py
Traceback (most recent call last):
File "/home/jmueller/Scripte/resol-vbus-python-python3/resol.py", line 261, in
load_data()
File "/home/jmueller/Scripte/resol-vbus-python-python3/resol.py", line 49, in load_data
send("DATA\n")
File "/home/jmueller/Scripte/resol-vbus-python-python3/resol.py", line 87, in send
sock.send(dat)
TypeError: a bytes-like object is required, not 'str'

I'm using LAN connection
telnet <IP_ADDRESS> 7053
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.
+HELLO

I have a Deltasol MX (no spec file yet, but i was hoping to get at least some results using DeltaSolBXPlus.json) connected to KM2 with Firmware 1.2.0

Exactly the same here. DeltaSolMX connected via LAN - messages as following:
Traceback (most recent call last):   File "/usr/local/bin/resol.py", line 261, in <module>     load_data()   File "/usr/local/bin/resol.py", line 49, in load_data     send("DATA\n")   File "/usr/local/bin/resol.py", line 87, in send     sock.send(dat) TypeError: a bytes-like object is required, not 'str'
I think there are more type errors. I tried send("DATA\n".encode()) but no success. It would be nice if the script runs on python3.

@df8oe
Have you tried https://github.com/hmueller01/resol-vbus-python/tree/python3 ?

Yes - that is the version my report is related to. Sadly there is no issue report possible.

I investigated more (but I am not a Python specialist at all):
There are alredy strings which are send via LN. Especially the login process uses strings. I have added some prints to look what happens and after the login line
send("PASS %s\n" % config.vbus_pass)
Resol answers with
ERROR: Not authorized to start data mode

I worked it out:
https://github.com/hmueller01/resol-vbus-python/pull/1

It is working now via LAN stable - PR is nor merged yet...

Tx @df8oe. I just created PR #13.


first open not work properly

my component.ts
`
import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-sidebar',
templateUrl: './sidebar.component.html',
styleUrls: ['./sidebar.component.css']
})
export class SidebarComponent  {
headerLogoImage : string;
constructor() {
this.headerLogoImage = './src/app/imgPath/fuel.svg'
}
private _opened: boolean = true;
private _autoCollapseWidth: number = 500;
private _autoCollapseHeight: number = 500;
private _closeOnClickOutside: boolean = true;
private _showBackdrop: boolean = true;
private _toggleSidebar() {
this._opened = !this._opened;
}
}
`
my template
`

  <ng-sidebar
   [(opened)]="_opened"
   [mode]="'push'"
   [autoCollapseHeight]="_autoCollapseHeight"
   [autoCollapseWidth]="_autoCollapseWidth"
   [closeOnClickOutside]="_closeOnClickOutside"
   [showBackdrop]="_showBackdrop">

home

prezzi

carico

contatori

fatture

impostazioni

  </ng-sidebar>

 `
when i run the first time the _opened works but it take all page size and backdrop not works. if i close and open -> sidebar works correctly.

Did you put it inside an <ng-sidebar-container>?

my  complete template

I just published v4.1.1, which should at least fix the backdrop not showing the first time. I'm not sure what the page size issue is though, that could be related to your specific content and styles.

yes, i try sidebar in a simple test project, size is correct. thanks :)


Inverted FlatList rotates ListEmptyComponent

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
inverted FlatList rotates ListEmptyComponent
React Native version:
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 29.80 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.0.0 - ~/.nvm/versions/node/v12.0.0/bin/node
Yarn: 1.22.10 - ~/.nvm/versions/node/v12.0.0/bin/yarn
npm: 6.9.0 - ~/.nvm/versions/node/v12.0.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods: Not Found
SDKs:
iOS SDK:
Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 12.3/12C33 - /usr/bin/xcodebuild
Languages:
Java: Not Found
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz => 0.63.2
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

create ListEmptyComponent
pass it as a prop to FlatList
pass "inverted" prop to FlatList

Expected Results
Describe what you expected to happen.
Snack, code example, screenshot, or link to a repository:
import React from "react";
import { FlatList, Text, View, StyleSheet } from "react-native";
const ListEmptyComponent = () => {
return This is ListEmptyComponent;
};
const ListFooterComponent = () => {
return (

Hey it is a footer

);
};
const ListHeaderComponent = () => {
return (

Hey it is a header

);
};
export const TestFlatList = () => {
const renderItem = ({ item, index }) => {
return (

{item.title} with idx {index}

);
};
return (

<FlatList
ListHeaderComponent={ListHeaderComponent}
ListFooterComponent={ListFooterComponent}
ListEmptyComponent={ListEmptyComponent}
data={[]}
renderItem={renderItem}
keyExtractor={(item) => item.id}
inverted
/>

);
};
const styles = StyleSheet.create({
container: {
width: "100%",
},
footer: {
backgroundColor: "blue",
},
header: {
backgroundColor: "green",
},
});

Duplicate of https://github.com/facebook/react-native/issues/21196, please use this issue to track this bug thanks!

Duplicate of https://github.com/facebook/react-native/issues/21196, please use this issue to track this bug thanks!


Can Veracode issues, reported for NPOI, be fixed?

We are using NPOI for excel/csv files generation in our project. We are using latest NPOI nuget version i.e. 2.5.4. Our code needs to pass Veracode security scan. Veracode is complaining some issues w.r.t NPOI. Please find attached the screenshots of Veracode issuies reported for NPOI(NPOI Veracode Issues.docx). Can these issues be fixed in the next release and when is the next release?
NPOI Veracode Issues.docx

Can you tell me what these flaw ids in Veracode exactly means? According to the screenshots, I cannot get enough information about what's wrong in these code. Can you summarize what's the exact issues in NPOI 2.5.4?

I also don't have much idea what those specific flaw Id means. As per the attached doc, we have some category of flaws(e.g. Use of Hard-coded Password (CWE ID 259) ) followed by actual code issue places screenshots where this flaw is happening and we generally google "veracode" + the flaw(e,g. "Use of Hard-coded Password (CWE ID 259)") to understand the flaw. Do you need some link explaining each flaw ID(e.g. Use of Hard-coded Password (CWE ID 259))?

Please find attached the updated NPOI Veracode Issues doc having a relevant link for the flaw Ids.
NPOI Veracode Issues.docx

If you don't have idea, I cannot help. Sorry!

@sandipray63in  For the cwe-482, it report the method GetTempFilePath. And it's false positive. Please make sure you find a problem then file a new issue.
https://www.cvedetails.com/cwe-details/482/
https://cwe.mitre.org/data/definitions/482.html
   public static string GetTempFilePath(String prefix, String suffix)
        {
            if (dir == null)
            {
                dir = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), "poifiles")).FullName;
            }
            Random rnd = new Random(DateTime.Now.Millisecond);
            Thread.Sleep(10);
            //return prefix + rnd.Next() + suffix;
            return Path.Combine(dir, prefix + rnd.Next() + suffix);
        }


LE Audio: MCS optional notification support

Is your enhancement proposal related to a problem? Please describe.
Most of the MCS characteristics only optionally support notifications. This should be reflected in the MCS and MCS client implementations, and configurable by either Kconfigs or on a per-instance (if dynamically registered) approach.
Describe the solution you'd like
Each characteristic where notification are optional should be optional in the implementation of MCS. The MCS client should also only optionally subscribe to the notifications, and then only if the server supports it.
Describe alternatives you've considered
N/A
Additional context
N/A

This is still valid


docs(javascript): update examples link

It was broken during the repository migration from gluesql-js to gluesql.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.09%) to 98.845%

Files with Coverage Reduction
New Missed Lines
%

core/src/data/value/convert.rs
5
99.49%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
40214

Relevant Lines:
40684

💛  - Coveralls


Add unit test for LSTM

There's currently no unit test for the LSTM layer, which is a bit uncomfortable given that we're now using an LSTM in ATLAS flavor tagging.

There also is no GRU layer unit test. Will add them both.

Actually this tests it:
https://github.com/lwtnn/lwtnn/blob/master/tests/test-ipmp.sh
but maybe it should be renamed or something to make what it's testing more clear.

aha, it does indeed. Well, I probably should have looked at that file anyways to make sure, and it's pretty obvious then.

I guess in the future we should name tests to reflect what they actually do. A file called test-ipmp.sh doesn't really accomplish that, so it's my mistake. Something like test-keras-lwtnn-gru-maxout-highway.sh would probably be more clear.

Ok, I can change the names. Similarly, for DL1 test then.

This can probably be closed by the way.
See the new naming conventions here: https://github.com/lwtnn/lwtnn/tree/master/tests

We have coverage for GRUs, but do we have LSTMs? I don't see which test covers these.

Good point... don't close yet. :)

Can we close this now?

Yup!


At train AnoGAN with MNIST data, Does the train set and test set all contain only normal data?

Hi, @LeeDoYup
In the case of Anomaly Gan, I knew that it trained with only normal datasets.
At train AnoGAN with MNIST data, Does the train set and test set all contain only normal data?
Or are both normal + abnormal divided into folders?
I wonder.
form @bemoregt.

도엽님, 감사합니다.
그러면 님의 아노갠에는 최대 이미지 사이즈가 얼마까지 들어가나요?
256x256 ??
from @bemoregt

The input image is resized into 64 x 64 image.


Update references about string interning

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.25%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
61

Relevant Lines:
80

💛  - Coveralls


apply Cookiecutter

Which issue(s) are closed by this pull request?
Closes #
Changes proposed in this pull request:

apply https://github.com/pyfar/cookiecutter-pypackage/pull/4

there had been changes in the cookiecutter, so this pr will be replaced soon.


Don't display outdated warning if a new version of a package is installed than the latest version

Is your feature request related to a problem? Please describe.
If a new version of a package is installed than the latestVersion defined in the package.yaml the update warning gets displayed, but this is incorrect.
Describe the solution you'd like
Be aware of semantic versioning and only display the warning if applicable.
Describe alternatives you've considered
An alternative warning / note can be displayed if a newer version is installed.
Additional context
Related to: https://github.com/glasskube/glasskube/issues/308
Depends on: https://github.com/glasskube/glasskube/issues/311

Hey, I would like to work on this issue. Can you please guide me to recreate this scenario.

Hi, I think right now this is too intertwined with our work on the dependency management #112. The logic whether we show the outdated warning or not will have to be adapted and we would run into too many conflicts.

Done in https://github.com/glasskube/glasskube/pull/401 and https://github.com/glasskube/glasskube/pull/404


"Play" an album/playlist/artist/radio

Is your feature already implemented in the latest master?
tbf selecting a song from a context (ChooseSelected) already does this but (1) you still can't play an artist's entire discography and (2) you need to pick the first song when you want to shuffle (big nitpick)
Is your feature request related to a problem? Please describe.
I use this feature on the official client in a daily basis and my first-time experience using this app was a bit frustrating because i can't just pick a playlist/artist to play
Describe the solution you'd like
a.k.a this button on spotify

The button would just clear Queue (and Next up, which probably needs distinction like in the official client) and fill them with songs from whatever context it's on
i would propose it to be added on ActionsOnSelectedItem
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

can i work on this issue?

I would also love to see this being added, I use it all the time on my phone with the official client.
I don't feel I'm capable enough of adding it myself though.
Maybe one day.


Add license for ruby2_keywords gem

Signed-off-by: Seth Chisamore<EMAIL_ADDRESS>

Closing this as the underlying issue was fixed in another way: https://github.com/chef/chef-server/pull/2174


Should not chmod 777 /var/tezos

In config-generator.sh we run:
https://github.com/oxheadalpha/tezos-k8s/blob/4f3488153c5b2f8990552c45eab46e832b33c061/utils/config-generator.sh#L8-L9
The node on its initial creation will create files/dirs with default perms set by the Tezos docker image:
~ $ ls -l /var/tezos/ /var/tezos/node /var/tezos/node/data/
/var/tezos/:
total 24
drwxrwxrwx    2 root     users         4096 Feb 23 15:18 client
drwxrwxrwx    2 root     users        16384 Feb 23 15:18 lost+found
drwxr-xr-x    3 tezos    nogroup       4096 Feb 23 15:18 node

/var/tezos/node:
total 4
drwx------    4 tezos    nogroup       4096 Feb 23 15:19 data

/var/tezos/node/data/:
total 20
drwxr-xr-x    3 tezos    nogroup       4096 Feb 23 15:19 context
-rw-r--r--    1 tezos    nogroup        300 Feb 23 15:19 identity.json
-rw-r--r--    1 tezos    nogroup          1 Feb 23 15:18 lock
drwxr-xr-x    4 tezos    nogroup       4096 Feb 23 15:19 store
-rw-r--r--    1 tezos    nogroup         22 Feb 23 15:18 version.json
~ $

Only the /var/tezos/client is 777 because we create it in the script and then immediately run chmod 777. The node data dir doesn't exist yet and hence the less privileged perms.
If the node never restarts, these permissions will remain. If the pod restarts, now that the data dir does exist the chmod 777 will give unnecessary perms. It will also change the group from nogroup to users:
 ~ $ ls -l /var/tezos/ /var/tezos/node /var/tezos/node/data/
/var/tezos/:
total 24
drwxrwxrwx    2 root     users         4096 Feb  1 02:41 client
drwxrwxrwx    2 root     users        16384 Feb  1 02:41 lost+found
drwxrwxrwx    3 tezos    users         4096 Feb  1 02:41 node

/var/tezos/node:
total 4
drwxrwxrwx    4 tezos    users         4096 Feb 18 19:58 data

/var/tezos/node/data/:
total 1508
drwxrwxrwx    3 tezos    users         4096 Feb  1 02:41 context
-rwxrwxrwx    1 tezos    users          300 Feb  1 02:41 identity.json
-rwxrwxrwx    1 tezos    users            1 Feb 18 20:07 lock
-rwxrwxrwx    1 tezos    users      1522573 Feb 18 19:58 peers.json
drwxrwxrwx    4 tezos    users         4096 Feb  1 02:41 store
-rwxrwxrwx    1 tezos    users           22 Feb  1 02:41 version.json

There should not be this inconsistency of the file perms. They aren't necessary and are a potential security risk. I also don't believe that /var/tezos/client should need 777 perms.

We should also confirm mkdir -p in the snapshot downloader https://github.com/oxheadalpha/tezos-k8s/blob/8c0b449ce3/utils/snapshot-downloader.sh#L55 doesn't give more perms than what the tezos node does give by default.
Essentially, any time we create files/dirs that the tezos node would create by default, we should give the exact same perms.

closed via #547


Unable to connect to Hipchat

I am using a ubuntu machine hubot and my hipchat is installed in another server..I have started hubot adapter.I receive the following error
devuser@177:~/myhubot$ bin/hubot --name CRIS --adapter hipchat
[Thu Mar 09 2017 02:29:54 GMT-0800 (PST)] ERROR Error: listen EADDRINUSE <IP_ADDRESS>:8080
at Object.exports._errnoException (util.js:907:11)
at exports._exceptionWithHostPort (util.js:930:20)
at Server._listen2 (net.js:1250:14)
at listen (net.js:1286:10)
at net.js:1395:9
at nextTickCallbackWith3Args (node.js:522:9)
at process._tickCallback (node.js:428:17)
CRIS> [Thu Mar 09 2017 02:29:54 GMT-0800 (PST)] WARNING Loading scripts from hubot-scripts.json is deprecated and will be removed in 3.0 (https://github.com/github/hubot-scripts/issues/1113) in favor of packages for each script.
Your hubot-scripts.json is empty, so you just need to remove it.
[Thu Mar 09 2017 02:29:54 GMT-0800 (PST)] ERROR hubot-heroku-alive included, but missing HUBOT_HEROKU_KEEPALIVE_URL. heroku config:set HUBOT_HEROKU_KEEPALIVE_URL=$(heroku apps:info -s  | grep web-url | cut -d= -f2)
[Thu Mar 09 2017 02:29:55 GMT-0800 (PST)] INFO hubot-redis-brain: Using default redis on localhost:6379
[Thu Mar 09 2017 02:29:55 GMT-0800 (PST)] INFO hubot-redis-brain: Initializing new data for hubot brain
I am able to do the following :
CRIS> CRIS PING
CRIS> PONG
But in hipchat CRIS user is offline.

you have something else running on port 8080 so hubot can't start
$ sudo lsof -i :8080

Thanks Anthillmob,
How to make my hubot run on other port???
Also , ishipchat JID and password enough to connect to Hipchat becuase we havent stored the username or url of hipchat anywhere.


Add prefix filter

If you add ?prefix=mesh into the URL, it will filter based on that. It's not showing it in the UI right now.
I implemented this because I wanted to finish up some of the smaller lists, like uniprot.chain. I curated the last two and found that mapping to protein ontology should be done very carefully, since protein ontology's entries are species-specific and it mapped Dengue proteins in PRO to SARS-CoV-2 proteins in UniProt

Great, thanks! Yes, I had to change the script to be more strict about species for pr vs uniprot.chain but there were some bad predictions that still made it through. I hope all the mappings I added manually or curated are correct.