Attempted to call an undefined method named "getCasts"

This error is being thrown in a bundle with no association to anything regarding to the WouterJEloquentBundle
Fatal error: Uncaught Symfony\Component\Debug\Exception\UndefinedMethodException: Attempted to call an undefined method named "getCasts" of class "Content\PollBundle\Entity\PollVersion". in /var/www/html/vendor/wouterj/eloquent-bundle/src/Form/EloquentModelTypeGuesser.php on line 23
Symfony\Component\Debug\Exception\UndefinedMethodException: Attempted to call an undefined method named "getCasts" of class "Content\PollBundle\Entity\PollVersion". in /var/www/html/vendor/wouterj/eloquent-bundle/src/Form/EloquentModelTypeGuesser.php on line 23
This is occurring in a couple of our bundles

Thank you for reporting this issue!
It appears there was a bug in the form type guesser (I somehow assumed it was only called for eloquent models). This should be fixed by in 1.0.3. Please let me know if you still have this error after updating.


Merge 3.15 into 3.16

Issue
https://github.com/gravitee-io/issues/issues/7388
Description
Merge 3.15 into 3.16

Final diff looks nice


Update readme.md

Hello,
I improved the spelling within the README.
Great project! Keep up the good work!
Peace and Love.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: helloausrine sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Feat vis flux compression

Codecov Report

Merging #111 (8ecbadd) into master (ad9526c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   84.87%   84.91%   +0.04%
==========================================
  Files          46       46
  Lines        3471     3481      +10
==========================================
+ Hits         2946     2956      +10
  Misses        525      525

Impacted Files
Coverage Δ

stixcore/processing/decompression.py
100.00% <100.00%> (ø)

stixcore/tmtc/tm/tm_21.py
72.27% <100.00%> (+2.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9526c...8ecbadd. Read the comment docs.


URI encoded path param handled differently in SPA and Server

Describe the bug
If I have a route /config/[id] and the value of id is encodeURIComponent('/test/a/path') then the value of $page.params.id differs depending on if you are accessing it during SPA or from a server reload:
console.log($page.params.id)

%2Ftest%2Fa%2Fpath // within SPA
/test/a/path // Page reload from server

Reproduction
Unfortunately my environment is limited to node 14 and I don't seem to be able to npm create<EMAIL_ADDRESS>If you could advise how to create a sveltekit app at a particular release I will provide a repo.
Logs
No response
System Info
System:
    OS: Linux 4.14 Amazon Linux 2
    CPU: (2) x64 Intel(R) Xeon(R) CPU E5-2665 0 @ 2.40GHz
    Memory: 1.21 GB / 16.73 GB
    Container: Yes
    Shell: 4.2.46 - /bin/bash
  Binaries:
    Node: 14.18.3 - /usr/bin/node
    Yarn: 1.22.19 - ~/.npm-global/bin/yarn
    npm: 8.13.2 - ~/.npm-global/bin/npm

Severity
serious, but I can work around it
Additional Information
No response

Sounds like a duplicate of #4629. Going to close this one to keep the discussion in one place.


'System.AggregateException' in mscorlib.dll

running mvc 6 in 1.0.0-rc1-final also have a Class Library added as reference in this project to maintain sqlserver data model with identity. after creating relationship between models and updating database every thing works fine. and then when i created a mvc form which has 3 entities one parent entity (Advertisement) and other two (Contact) and (CellPhone) both of them has  one-to-one relationship with entity (Advertisement)
builder.Entity<Advertisement>()
.HasOne(u => u.Contact)
.WithOne(t => t.Advertisement)
.HasForeignKey<Contact>(b=> b.pubID).IsRequired()
.OnDelete(Microsoft.Data.Entity.Metadata.DeleteBehavior.Cascade);
builder.Entity<Advertisement>()
.HasOne(u => u.CellPhone)
.WithOne(u => u.Advertisement)
.HasForeignKey<CellPhone>(b => b.pubID).IsRequired()
.OnDelete(Microsoft.Data.Entity.Metadata.DeleteBehavior.Cascade);
when i submitted a create form with this 3 entities its working fine. but when i try to edit with it. i getting an error.
A database operation failed while processing the request.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
AggregateException: One or more errors occurred.
InvalidCastException: Specified cast is not valid.
There are pending model changes for ApplicationDbContext
Scaffold a new migration for these changes and apply them to the database from the command line:
> dnx ef migrations add [migration name]
> dnx ef database update

i run a trace with Sql Server Profiler. The query executing perfectly ok and getting the result as i expected but some how i getting this error. i don't under the reason behind it.
in my edit controller i run this command to get the data.
Advertisement advertisement = await _context.Advertisements.Include(s=> s.CellPhone).Include(s=> s.Contact).SingleAsync(m => m.ID == id);
and here is my Sql Server Profiler trace file
AggregateExceptionTxt.txt
when i  Include the contact entity in this query i getting this error if i only Include the CellPhone entity its working fine

@himadrinath can you post the full stack trace from the error? The easiest way to get this is to comment out the app.UseDatabaseErrorPage(); call in Startup.cs so that you get the full exception details.

@rowanmiller  An unhandled exception occurred while processing the request.docx

Stack trace copied out of the Word doc
InvalidCastException: Specified cast is not valid.
lambda_method(Closure , ValueBuffer )
Microsoft.Data.Entity.Query.EntityLoadInfo.Materialize()
Microsoft.Data.Entity.Query.Internal.QueryBuffer.GetEntity(IKeyValue keyValue, EntityLoadInfo entityLoadInfo, Boolean queryStateManager)
Microsoft.Data.Entity.Query.Internal.QueryBuffer.<>c__DisplayClass14_0.<<IncludeAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
System.Linq.AsyncEnumerableExtensions.AsyncSelectEnumerable`2.AsyncSelectEnumerator.<MoveNext>d__3.MoveNext()

System.InvalidCastException: Specified cast is not valid.
   at lambda_method(Closure , ValueBuffer )
   at Microsoft.Data.Entity.Query.EntityLoadInfo.Materialize()
   at Microsoft.Data.Entity.Query.Internal.QueryBuffer.GetEntity(IKeyValue keyValue, EntityLoadInfo entityLoadInfo, Boolean queryStateManager)
   at Microsoft.Data.Entity.Query.Internal.QueryBuffer.<>c__DisplayClass14_0.<<IncludeAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at System.Linq.AsyncEnumerableExtensions.AsyncSelectEnumerable`2.AsyncSelectEnumerator.<MoveNext>d__3.MoveNext()
AggregateException: One or more errors occurred.

AggregateException: One or more errors occurred.
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Microsoft.Data.Entity.Query.Internal.QueryBuffer.<IncludeAsync>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.Data.Entity.Query.AsyncQueryMethodProvider.<>c__DisplayClass20_0`1.<<_Include>b__2>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
System.Linq.AsyncEnumerableExtensions.AsyncSelectEnumerable`2.AsyncSelectEnumerator.<MoveNext>d__3.MoveNext()

AggregateException: One or more errors occurred.

AggregateException: One or more errors occurred.
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Microsoft.Data.Entity.Query.Internal.TaskResultAsyncEnumerable`1.Enumerator.<MoveNext>d__3.MoveNext()

AggregateException: One or more errors occurred.
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Microsoft.Data.Entity.Query.Internal.AsyncLinqOperatorProvider.ExceptionInterceptor`1.EnumeratorExceptionInterceptor.<MoveNext>d__5.MoveNext()

AggregateException: One or more errors occurred.
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
Linklookr.Mvc.Controllers.CreateController.<Edit>d__7.MoveNext() in CreateController.cs
303.
Looks like the error occurs while running this query:
Advertisement advertisement = await _context.Advertisements
    .Include(q=> q.Contact)
    .Include(s=> s.CellPhone)
    .SingleAsync(m => m.ID == id);

@rowanmiller
ApplicationDbContext.txt
Advertisement.txt
Contact.txt
CellPhone.txt

@rowanmiller did u find something?

@himadrinath I am not able to reproduce the issue. Here are the steps I followed:

Created a new ASP.NET 5 web app (RC1) with Individual authentication enabled
Replaced the existing ApplicationDbContext code with the code from ApplicationDbContext.txt
Added Advertisement, Contact, and CellPhone entities from the code you supplied
I had to add a public List<Advertisement> Advertisement { get; set; } property to the ApplicationUser class to get things to compile
dnx ef migrations add Customization
dnx ef database update
Run the app and register a new user
Create an Advertisement in the database (I used the following script)

SET IDENTITY_INSERT [commercial].[advertisement] ON
GO

INSERT INTO [commercial].[advertisement]
           ([id]
		   ,[brand]
           ,[commercial]
           ,[condition]
           ,[description]
           ,[i_category]
           ,[ii_category]
           ,[ii_categoryID]
           ,[iii_category]
           ,[iii_categoryID]
           ,[price]
           ,[model]
           ,[proposal]
           ,[publisher]
           ,[terms_condition]
           ,[title]
           ,[user_id])
     VALUES
           (1
           ,'abc'
           ,'abc'
           ,'abc'
           ,'abc'
           ,'abc'
           ,'abc'
           ,1
           ,'abc'
           ,1
           ,1.45
           ,'abc'
           ,'abc'
           ,'abc'
           ,1
           ,'abc'
           ,(SELECT TOP 1 Id from dbo.AspNetUsers))
GO

Modify HomeController constructor and Index action as follows

    public class HomeController : Controller
    {
        private ApplicationDbContext _context;

        public HomeController(ApplicationDbContext context)
        {
            _context = context;
        }

        public async Task<IActionResult> Index()
        {
            var id = 2;

            Advertisement advertisement = await _context.Advertisements
                .Include(q => q.Contact)
                .Include(s => s.CellPhone)
                .SingleAsync(m => m.ID == id);

            return View();
        }

...

Run the app (hits the code in the Index action by default)

This succeeds for me and the Advertisement is correctly returned from the database. Can you provide a set of detailed steps (similar to the ones above) that we can use to reproduce the issue.

If it is easier.. then a project that we can use to reproduce the issue is fine too.

Closing as we have not heard back. Feel free to reopen if you are able to provide code to reproduce.

@rowanmiller
https://onedrive.live.com/redir?resid=59E7053C8A397BB0!3765&authkey=!APGsit2pCEQJDgc&ithint=folder%2Csln
Database attached with it.
Go to Create and try to edit

Hey,
Contact.Longitude and Contact.Latitude are defined as the .NET float type, which by default EF would map to a column with the SQL Server real type. The problem is that you have explicitly set the data type of the column to the SQL Server float type, but that is not compatible with the .NET float type (see this post for more details).
If you specify an explicit column type then EF will just trust you and try to do the conversion. The error you get is the same error if you try and use SQL Client to put the value of a SQL Server float column into a .NET float variable.
If I change the properties in the Contact class to be double (the .NET equivalent of SQL Server's float) then everything works as expected.
~Rowan

@rowanmiller
Thank you.......

Opened https://github.com/aspnet/EntityFramework/issues/4289 to look at providing better errors in a way that does not adversely impact perf.


New emails aren't syncing

What operating system are you using?
Windows 10
What version of N1 are you using?
0.4.19

Bug?
Do you have any third-party plugins installed?
No
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
Outlook
Outlook does not sync past a specific date, in my case the 31st March. I have tried uninstalling Nylas along with deleting the .nylas folder and doing a full re-install then re-adding the Outlook account and syncing again however it only syncs all emails before this date and none of the latest.

I am having the same issues on OS X El Capitan 10.11.3 using Nylas v0.4.19-d41e72c

Same here under Windows 10 Insider Build 14295 x64. No third-party plugins installed, seems to happen with Outlook provider. My folders are blank...

Hi all, could you email<EMAIL_ADDRESS>with the email address of the affected account so we can look into it? Thanks!

@jstejada I did on the 3rd April but haven't received any response, mine has since started working again but no doubt it'll stop again, maybe they can check my logs from when I was experiencing the issue to see what maybe was going wrong.

Another incidence: https://nylas.zendesk.com/agent/tickets/3592

Another incidence: https://nylas.zendesk.com/agent/tickets/3066

Another incidence: https://github.com/nylas/N1/issues/1868

Another incidence: https://nylas.zendesk.com/agent/tickets/3736

Another incidence: https://twitter.com/laurentupit/status/750771058068877313

Another incidence: https://nylas.zendesk.com/agent/tickets/3997

Another incidence: https://nylas.zendesk.com/agent/tickets/4409

Another incidence: https://nylas.zendesk.com/agent/tickets/4400

Another incidence: https://nylas.zendesk.com/agent/tickets/4450

Another incidence: https://nylas.zendesk.com/agent/tickets/3913

Another incidence: https://nylas.zendesk.com/agent/tickets/3998

Another incidence: https://nylas.zendesk.com/agent/tickets/4737

Another incidence: https://nylas.zendesk.com/agent/tickets/4548

+1 for this issue, I can send email but all folders are empty

Another incidence: https://nylas.zendesk.com/agent/tickets/4975

Another incidence: https://nylas.zendesk.com/agent/tickets/4080
This one is particularly interesting. The sync problem started when the user deleted an "Archive" folder from Outlook's Deleted Items folder, and resolved itself when they created a new folder in the same spot with the same name.

Hi guys, do to this unexpected problem with hotmail syncing I am forced to give up and move to another email client. Such a pitty!
Hopefully we'll see us again in the future. Until then, all the best with your work and effort!

hi, i cleaned my mailbox on gmail July 4th and i have about 12 Gb's of email. I've reinstalled Nylas on several systems and it's still show July 4th as the last time it was updated. i also updated to pro. i can see it doing curl request for updates but i'm not seeing an update. can you guys reset my account?

No updates for my exchange account too! It has just stopped. Linux Manjaro.

Same things here. All stuck whichever is the platform I use: Mac or Windows 10.

Same problem with exchange under Antergos.

Same here. Not syncing anymore.

Same problem, started this morning. No change that I know of since yesterday.

@ashole patience solved it for me :)

I had the same problem. New emails does not sync in. I already re-authenticated with GMail and tried removing the account and adding it again. But it still does not sync.
I'm using a macOS Sierra v10.12.1 by the way.
Thanks!

I am not sure what the resolution is, I am on Mac Sierra v10.12.1 and the sync is very spotty, I have tried to remove and add the account along with reathenticating and it syncs and then goes out of sync again.
Can't believe its almost 2017 and still don't have a reliable mail client.

can you guys have a priority label like critical for this ? @bengotow
can't believe you have develop so many features and new plugins but leave such an important bug for more than half year.

Same situation here since Dec 7. Creating support ticket doesn't help as well.

Same here since yesterday. Partial sync, and one SMTP account does not sync at all. No problem on Spark that I have to use as backup...

Experiencing the same issue as of 1/14. Did anyone ever come up with a fix for this?

I am also experiencing this with 2 gmail accounts, one imap account, and one outlook.com account. Relaunching app, re-authenticating, and using the developer "Reload" option is not working for me. Aso of 2/8/2017 this is my "newest" fetched email:

I am experiencing the same problem. Date is Feb 7 for me on an hotmail account. Worked correctly in Nylas Pro, I recently switched to Nylas Mail. Tried to Remove and add back the account.
Looked in the console for errors, havent seen any. Activity show sync seems to be working correctly:

Is there something else I can do to debug this?

thanks for the info! can you follow the steps in https://github.com/nylas/nylas-mail/issues/3232#issuecomment-275729794?
If its the same issue I'll merge this into #3232

@jstejada I read trough @3232, and it doesn't seem to be the same issue. I see no errors at all in the  activity window console, and no "syncing mailboxes" notification at the bottom of the sidebar. The initial sync completed and emails worked for my hotmail account for a couple of days before stopping. Both my gmail accounts are still working correctly.

Hmm, interesting. Restarting the app has no effect?

No effect.

Same error with custom IMAP account (mail.com) , my emails used to be synced OK but since few days I do not see any new mails anymore. No error shown in the Activity window, it looks like Nylas Mail thinks it's up to date. I have multiple email accounts in Nylas (all custom IMAP) and only one is experiencing this problem (mail.com).
Interestingly I had the same problem in the past with the same account with older version of Nylas N1 + custom sync engine. I thought the problem was solved by switching to Nylas Mail, but apparently not.
I think resetting the email cache database will fix this but it's cumbersome and I'm pretty sure the problem will appear again.

operating system : Mac - Sierra OS 10.12.3
Nylas Mail version : v1.0.26. did have the same problem with Nylas N1 and custom sync-engine.
third-party plugins installed : none
issue related to a specific email provider : happens only on my mail.com account (IMAP). I have other IMAP accounts with a different provider and emails are synced correctly.
issue reproducibility : I don't know the cause of this bug as it used to work alright.

Some news: An hour ago, Nylas Mail decided it wasn't able to authenticate my hotmail account.

I'm using two factor auth, so I have an application password set up for Nylas. It obviously hasn't changed since I created it. Using the "Check again" button does not resolve the problem. Nor does restarting Nylas.
This is the error that is going on in loop since then in the activity console.
breadcrumbs.js:53<EMAIL_ADDRESS>🔃  SyncWorker: Errored while syncing account IMAPAuthenticationError: Error in sync loop: Error: LOGIN failed.
    at NylasError (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/src/errors.js:2:1)
    at IMAPAuthenticationError (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/src/imap-errors.js:16:1)
    at convertImapError (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/src/imap-errors.js:109:15)
    at Connection._imap.once.err (imap-connection.es6:178:16)
    at Connection.g (events.js:286:16)
    at emitOne (events.js:96:13)
    at Connection.emit (events.js:188:7)
    at reentry (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Connection.js:1610:12)
    at Connection.checkCaps (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Connection.js:1635:22)
    at Connection._resTagged (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Connection.js:1535:22)
    at Parser.<anonymous> (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Connection.js:194:10)
    at emitOne (events.js:96:13)
    at Parser.emit (events.js:188:7)
    at Parser._resTagged (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Parser.js:179:10)
    at Parser._parse (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Parser.js:143:16)
    at Parser._tryread (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Parser.js:86:15)
    at TLSSocket.Parser._cbReadable (/Applications/Nylas Mail.app/Contents/Resources/app.asar/internal_packages/local-sync/node_modules/isomorphic-core/node_modules/imap/lib/Parser.js:57:12)
    at emitNone (events.js:86:13)
    at TLSSocket.emit (events.js:185:7)
    at emitReadable_ (_stream_readable.js:432:10)
    at emitReadable (_stream_readable.js:426:7)
    at readableAddChunk (_stream_readable.js:187:13)
    at TLSWrap.onread (net.js:543:20)
    at Socket.ondata (_stream_wrap.js:58:20)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at TCP.onread (net.js:543:20) (anonymous function) @ breadcrumbs.js:53

same error on 1.0.29

Thanks for the additional details! We are going to look into this

problem still there with Nylas Mail v1.0.30

problem still there with Nylas Mail v1.0.45

And v1.0.48

Thanks for the updates! This should be fixed in our upcoming Nylas Mail release.


Extending Custom Navision Table

We currently have a product that is only in C/AL and will eventually be transitioned
to AL.  We have a second product in AL.  I wanted to create another app that would be dependent on the AL app, but extend the product the is still in C/AL.  When I go to create the page extension for that app
I get the error message "The target Page "CBS Setup" for the extension object is not found."  I see the Tables are not in the Microsoft_Application.app file.  Is there a way to use custom table/pages in your app that are stil in C/AL?

Hi @MatthewMcCarthy7, this should answer your question: Running C/SIDE and AL Side-by-Side.

Thanks! That worked, and this ticket can be closed.


Return 404 when static file is not found

When whitenoise do not found a match, it passes the request to the application provided, so I passed a wsgi app that return a 404.
fixes #283 #185

Thanks @taoufik07


Rule "Skip" doesn't skip Workers

Which Cloudflare product does this pertain to?
WAF
Existing documentation URL(s)
https://developers.cloudflare.com/waf/custom-rules/skip/
Section that requires update
A note or tip.
What needs to change?
The documentation doesn't mention that "Skip" will always result in Workers running anyway (given there's a Workers Route of course)
How should it change?
Add a tip or a note.
Additional information
No response

Web Application Firewall

Hi @wolruf
We say in the documentation that the skip action allows you to skip security features, and Workers is not a security feature. In the skip options reference page, we specifically call out that skip rules do not skip Bot Fight Mode or Super Bot Fight Mode because those are in fact security features, so customers could wonder if these features would also be skipped.
Did we get questions from customers about Workers not being skipped with a skip rule?

Yes, I had customers asking for it.


DRILL-5716: Queue-driven memory allocation

Please see DRILL-5716 for an overview.
This PR provides five commits that implement a method of allocating memory to queries based on ZK-based queues. The key concept is that the system has a fixed amount of memory. Suppose all queries need the same amount of memory. In that case, if we want to run n queries, each gets an amount that is the total memory divided by n.
This raises two questions:

Queries don't need the same amount of memory, so how do we handle this?
How do we know how many queries, n, are to run within Drill?

The solution is to leverage an existing feature: the Zookeeper (ZK) based queueing mechanism. This mechanism limits (throttles) the number of active queries. If we set the limit to n, then we know that Drill won't run more than n queries, and we can apply the above math.
But, not all queries are the same size. The ZK-based throttling mechanism addressed this by allowing two queues: a "large query" queue and a "small query" queue. The idea is that the cluster might run a single large ETL query, but at the same time, run five or 10 small interactive queries. The numbers are configurable via system options. The existing mechanism uses query cost to decide when a query is "small" vs. "large." The user sets a threshold in terms of cost. Queries split into the two queues accordingly.
Resource Manager Layer
The first commit introduces a new resource management layer with a number of concepts:

A pluggable, global resource manager configured at boot time. The code offers three versions: the null manager (no throttling), the ZK-based one discussed above, and a test-only one used in unit tests that uses a simple in-process queue.
A Per-query resource allocator created by the resource manager to work with a single query through the query lifecycle.

Since the default manager does no queueing, queues themselves are internal to the resource manager. The model assumes:

A query queue that manages the Drillbit's view into the distributed queue state.
A queue "lease" that represents a grant of a single slot within a queue to run a query.

The design handles the current resource managers, and allows creating custom schedulers as needed for specific distributions or applications.
Prior to this PR, the Foreman worked with the ZK-based queues directly inline in the Foreman code. With the above framework in place, this PR refactors the Foreman to extract the ZK-based queue code into a resource manager implementation. Functionality is identical, just the location of the code moves to allow a cleaner design.
One interesting design issue is worth pointing out. The user can enable and disable ZK-queues at run time. However, the resource manager is global. To make this work, a “dynamic” resource manager wraps the ZK-based implementation. The dynamic version periodically checks system options to see if the ZK-based version is enabled. The dynamic version calls to either the ZK-based version or the default (non-throttled) version depending on what it finds in the system options.
When a switch occurs, queries already queued will stay queued. Only new queries use the new setting. This provides a graceful transition to/from throttled mode.
Specifics of Memory Planning
The core of this change is a new memory planner. Here's how it works.

The user enables queues using the existing exec.queue.enable session option.
The user decides the number of "small" vs. "large" queries to run concurrently by setting exec.queue.small and exec.queue.large respectively. (The original numbers for these settings were far to high, this PR changes the defaults to much lower values.)
Decide how to split memory across the two queues by specifying the exec.queue.memory_ratio value. The default is 10, which means that large queries get 10 units of memory while small queries get 1 unit.
Decide on the planner cost threshold that separates "small" vs. "large" queries using exec.queue.threshold.
Decide on the maximum queue wait time by setting exec.queue.timeout_millis. (Default is five minutes.)
Not all operators participate in the memory allocation system (exchanges, hash join and Top-N, for example, still make unlimited use of memory.) To reserve memory for these operators, choose a value for the new config parameter, exec.queue.memory_reserve_ratio which sets aside a slice of total memory "unmanaged" operators. The default is 20% testing will tell us if that value should be larger or smaller.

The memory planner then does the following:

Determine the number of “memory units” as the number of concurrent small queries + the number of concurrent large queries * the memory ratio.
Determine the amount of memory available by taking the total system memory and multiplying it by 1 - the reserve ratio.
Suppose this is a small query. Compute actual memory as available memory / number of memory units.
Traverse the plan. Find the buffering operators grouped by node. (Buffering operators, in this release, are sort and hash agg.)
Suppose we find that, on node X, we have two sorts and a hash agg. This is three operators on that node.
Determine the number of minor fragments running on that node. Suppose there are 10.
Divide the per-node memory across the operators on each node and each minor fragment. Here, we divide our total memory by 3 * 10 = 30 to get the per-operator memory amount.

The above is more complex than the existing memory allocation utilities. The extra behavior handles a special case seen in several production environments: the case in which a query runs only in the root fragment on a single node, so that there is only a single minor fragment. The existing code still divides memory by the possible number of fragments, even if the actual number is 1. The new code gracefully handles this case and will give all memory to the single fragment in this case.
Planner and Foreman Changes
Memory planning now depends on the resource manager. The default manager assigns memory using the existing MemoryAllocationUtilities. The ZK-based version uses the math outlined above.
As a result, the third commit reworks the parallelizers to shift memory planning into a separate memory planning stage managed by the resource manager. As a result, we must shift creation of the JSON form of the query plan until after memory allocation is done.
We assume that some future resource manager may learn of available memory only after a queue lease is granted. So, we shift memory planning until after a queue slot is available; but before launching fragments.
Web UI Enhancements
Early testing revealed that a major limitation of the existing ZK-based queues is that they are opaque: the user can't tell what is happening. To address this, two UI changes were made:

If ZK-based queues are enabled, information about them now appears on the main Web UI page for the Drillbit.
The main query profile page shows, for each query, the query cost (used to select the "small" vs. "large" queue) and the name of the selected queue: "small" or "large."

In addition, system/session options are now sorted by name to make it easier to find the queue-related options.
The above required changes to the query profile definition Protobuf (in commit 2) as well as changes in the various "models" and "templates" used by the Web UI. Note that the new information also automatically appears in the corresponding JSON REST API calls.
Code Cleanup
Commit 5 has a large number of code cleanup items found while doing the above work. These do not affect functionality.
Limitations and Future Improvements
The change in this PR is far from perfect; but it is the best we can do given the limitations of the existing ZK-based queues. In particular:

There is no way to determine the total queue length: the number of queries waiting in the queue.
There is no good way to cancel a query stuck in the queue.
JDBC/ODBC clients won’t know that their queries are queued, or be able to cancel queued queries.
The two-queue model is highly simplistic; real applications need a variety of queues and the means to categorize queries into queues.
The ZK-queues allow no prioritization.
The queueing mechanism does not limit CPU use, only memory use.
The planner number used to split queries into queues is not very accurate or intuitive.
No provision is made to understand that some queries need little memory, others need a huge amount. Instead, all queries are either “small” or “large.”
Several operators still make unlimited use of memory. It will be hard to set aside a proper reserve for these operators, somewhat limiting the usefulness of this feature until those operators are fixed.

All that said, the present PR is a (small) step in the right direction and lays the groundwork for additional, future efforts.

Responses to the general comments:

I think we need to limit the number of queries waiting for queues.

Please see the detailed notes. The ZK-based mechanism does not (AFAIK) provide the means to limit queue size. This is why this feature is preliminary, and may be why it has been disabled, though it has been available in the code for several years.

For short queries, this feature might add more overhead/latency (going to zookeeper, extra synchronization mechanisms added etc.). This will be a problem with high concurrency. Did we quantify that ?

This is not a feature for situations of very high concurrency (= very small queries). It is a feature for situations in which a cluster runs enough distributed queries that the cluster becomes overloaded. For the case with 1000s of small, single-node queries, a app could use the framework provided to implement an in-process queue. In fact, one exists, but it is intended for unit tests.

Not being to cancel once enqueued is also a problem. Can we do that by having cancel release the semaphore ?

Yes, cancelation is an issue. Since the ZK-based queues were an existing feature, I didn't dive too deeply into how they handle query cancellation. This would be a good area for QA to exercise.

Also, does semaphore count give an indication how many are waiting in the queue ?

There is no ready means to determine this, though I suspect that something could be put together that queries the internal znode and counts the ephemeral nodes that represent waiting processes. Doing so would be handy to display queue size in the Drill web UI. This would be a good enhancement once we prove that the basic mechanism works.

@jinfengni, can you take a quick look at the Foreman changes? Especially the bits that muck about with the physical plan: some of the work is moved from one place to another. Thanks!

@paul-rogers could you please resolve the conflicts?

Looks like significant changes where made to the UI since this PR was first posted. Will need to rework my changes in that area. Please review the other bits while that rework is in progress.

Rebased onto the latest master.
The profile UI in master had changed since this PR was first posted. Reworked the query overview information to use the much better style added recently in master.

The "Queued" field for duration appears only if queues are enabled.
The overview line includes query cost and queue if queuing is enabled.

@paul-rogers please don't forget to resolve conflicts.


Cat emojis

Domestic felines are already available as a 🐱 Cat Face and a 🐈 full-fody Cat emoji. There are also several facial expressions 😺😸😹😻😼😽🙀😿😾, but not different breeds of cats.
Large cats are kind of misaligned: 🐯 Tiger Face and 🐅 Tiger, but 🦁 Lion Face and 🐆 Leopard.
Some people would also like the cat face to gain additional emotions or accessories. #278
Petitions

change.org
Emoji Request: Black cat

Proposals

L2/17-161 = N4794 includes a ballot comment by the Irish NSB that suggest a Sabre-Toothed Cat (and Mammoth #360 and Dodo #143) emoji should also be encoded if select dinosaurs #99 are added.

🐈⬛ Black Cat


Make installation more portable

In this patch I make two significant changes:
First, I use the installed dune dt binary to calculate the dependencyTree of a Node.js module. This change is accompanied by introduction of the Bos library to call subprocesses in a more declarative manner.
The big change above assumes that the dt was installed correctly in the change introduced in 3516167. This commit requires npm to be configured correctly. Here I add the conf-npm package to try and do this automatically, but some systems may require more manual configuration. Regardless, if compilation succeeds then everything will be ok.
Lastly, I create a share/config site for the ast_gen package to install the default config.json file. This extension makes the installation more portable as sites are managed by dune, and are configured in the Auxiliary.Share module.

I'm merging as it's passing the CI. I don't think I broke anything, but let's see :sweat_smile:


Selecting indicators UI. Mark it Clear what is on or off

It would be good to show what is on in the dropdown list + allow you to select multiple indicators/studies.
Currently uses background colour to show selected.

https://blueprintjs.com/docs/#select/multi-select has a pattern for multi select that has a stronger hint that something is on or off.

Would you mind filing this in Console? I expect to take a look at the chart controls later this week.


Empty div.form__field-description causes visual gaps

We are not checking via React to see if there is actually any description within the div, there is a margin-bottom applied to the div which is visible. This issue would potentially be visible with other divs also, but haven't checked.
Bug coming from .form__field-description in FieldHolder.js
I will probably apply styles to hide empty divs as a precaution.
eg.
.form__field-description:empty {
display: none;
}

This has been fixed @tractorcow with this commit ad18c29.
    ...
    renderDescription() {
      if (this.props.description === null) {
        return null;
      }
      ...


Failing 'Scheduled Tests' actions

I noticed failures again in the 'Scheduled Tests' :(
https://github.com/metoppv/improver/actions/runs/6608679269/job/17947741415#step:3:1277

Try ensuring separation between env. for mamba and improver env. (mamba docs).

All seems to work now.
I'll apply the same changes to the scheduled actions to hopefully apply the same 'fix' there.

OK they all seem to pass now.


Reject 203 responses

Microsoft (Azure) proxies return a 203 response when unathenticated.
The response contains html code that prompts the user to login.
In this the pull request there's also code that propagates the auth realm to downstream functions.

Thanks for opening this!
At first I'm a bit wary to enable this by default… My understanding of the 203 status code is that the body may have been modified by a proxy, but is still valid… (My guess is it could be used if a proxy reformats checksum files or directory listings for example, while preserving their actual value.) It seems the Azure servers are faulty here.
If this feature were to be added, I think it'd be better to enable it manually, either for specific repositories or all requests.
That said, it seems tweaking the User Agent may just solve that, per https://github.com/sbt/sbt/issues/5483. I'd like to preserve the default Java user agent, as clearing it has been a problem in other contexts (see https://github.com/coursier/coursier/issues/1969). Maybe that'll just solve the issue here. It could be made customizable too.

@markoutso Is there a public repository that could be used to reproduce that?

I understand your hesitation.
Having this as an opt-in feature was my initial intention but after some thought I ended up believing that it's a bad thing when an artifact proxy is telling you that the payload is not the original one.
In any case, I will update the pull request.
I don't think it's a matter of user-agent though.
If you configure the repository with the correct authentication then you can download without any problems as I described here.

@alexarchambault Any news on this?


TextFormField - cursor stay at the start of the line on IOS.

I am using the simple TextFormField widget from flutter/material . Unfortunately on some ios devices the cursor not moving while the user starts writing. I know it is hard to reproduce this issue, but maybe somebody already knows the solution.
Here is the video about the problem.
TextFormField(
          focusNode: focusNode,
          decoration: InputDecoration(
              border: InputBorder.none,
              hintText: AppLocalizations.of(context)!.type_something),
          controller: widget.textController,
          scrollPadding: const EdgeInsets.all(20.0),
          keyboardType: TextInputType.multiline,
          minLines: 20,
          maxLines: 99999,
          autofocus: false,
        ),

@kovilevi98
Can you provide flutter doctor -v and the device details on which you are seeing this behavior ?

hintText: AppLocalizations.of(context)!.type_something)

Does this also occur without app localization ? ie, with simple plain English ?

Thank you for the fast reply, yes the problem is still there with a sample string as well. Unfortunately, it is tough to reproduce because, it is not a constant issue, sometimes it appears on the same device sometimes it is not. (And with a physical keyboard almost every time, I can accept that problem). i.e device: Iphone 12 mini with IOS 15.1.1.
flutter doctor:
[✓] Flutter (Channel unknown, 3.1.0, on Microsoft Windows [Version 10.0.19044.2251], locale hu-HU)
    • Flutter version 3.1.0 at C:\Users\Levi\Documents\flutter
    • Upstream repository unknown
    • Framework revision bcea432bce (7 months ago), 2022-05-26 09:05:34 -0700
    • Engine revision 44e5b38ee8
    • Dart version 2.18.0 (build 2.18.0-44.1.beta)
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Levi\AppData\Local\Android\sdk
    • Platform android-33, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.10)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.11.32126.315
    ✗ Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop
      development with C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK

[✓] Android Studio (version 2021.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2021.2.2
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at C:\Users\Levi\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.2251]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 108.0.5359.96
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 105.0.1343.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Channel unknown, 3.1.0,

Thanks for the update. Can you upgrade to latest stable or master version and try the same use case again to know if it still persist or not ?

(And with a physical keyboard almost every time, I can accept that problem)

Do you mean with physical keyboard it replicates often ?

Unfortunately, the issue is still there. And yes based on the user's reports with the physical keyboard it replicates more often.

Thanks for the update. Are you able to replicate this behavior consistently at your end or is this coming from production ?
If so, is there a way to get the device details on which it occurs consistently ?

Unfortunately, non of the users could reproduce this consistently. I have just started receiving bug reports from production and am trying to collect as much data as possible from them. But still, the video is the most helpful information.

I am unable to replicate this using physical keyboard that I used to input in simulator. The cursor moves as expected.
Based on the report and video shared earlier, I am keeping this issue open for team's attention and insights.
There's a related issue but with emojis though: https://github.com/flutter/flutter/issues/50563

Can you share a runable code sample that showcases the issue?


allocate some dummy variables to pass debugging mode

In debugging mode,  the subroutines need allocated arguments.

This PR addresses  #414 too

@weiyuan-jiang: Once we have confirmation that the nightly tests pass, I'm ok with merging this PR.  Thanks!
cc: @biljanaorescanin

I think everything has been passing at night. I haven't noticed any fails.

I think everything has been passing at night. I haven't noticed any fails.

@mathomp4: This PR hasn't been merged yet, so the successful nightly tests don't tell us about the 0-diff nature of the branch associated with the PR.
@weiyuan-jiang: Did you test this branch?  Or should @biljanaorescanin do it?  We need only one of you to test it, but so far we don't have confirmation of a successful test.  Perhaps I missed it?

@gmao-rreichle  I am testing it right now...submitted test at 10am so I will know in an hour or a bit less.

@gmao-rreichle Well I feel dumb. Thankfully it's Friday 😄

Thanks, @biljanaorescanin.  Are you also running the "assim" cases with in "debug" mode?  The failure of the "assim" cases to run in "debug" mode is what prompted the PR.
I think @weiyuan-jiang was able to run after inserting allocate(xxx(1)) statements, but we agreed to try allocate(xxx(0)) instead.  Before we can merge the PR, we also need to make sure that the branch runs for the "assim" cases in "debug" mode.  I'm not sure if we have a baseline/reference for this case, but that's not a problem.  The important point is to be able to run "assim" in "debug" mode.

@gmao-rreichle, I understood @weiyuan-jiang has run that, and I need to run just regular nightly tests. @weiyuan-jiang am I right?

@biljanaorescanin : I haven't heard from Weiyuan that he has successfully run the "assim" "debug" case after changing to allocation of 0-size arrays, nor have I heard that he's run the nightly test.  He probably got side-tracked with other things, and he's on leave this afternoon.  There's no urgency.  Please do not merge the PR until we hear back from Weiyuan.

@biljanaorescanin : I haven't heard from Weiyuan that he has successfully run the "assim" "debug" case after changing to allocation of 0-size arrays, nor have I heard that he's run the nightly test. He probably got side-tracked with other things, and he's on leave this afternoon. There's no urgency. Please do not merge the PR until we hear back from Weiyuan.

Sure

All tests passed for this PR. @weiyuan-jiang also confirmed that he has successfully run the "assim" "debug" case after changing to allocation of 0-size arrays.


Get test framework and local display site running

DuyHai has already setup a test framework and a generated UI for viewing test results.  This task is to setup and configure the capability locally to build upon it as I move forward.

Even though I technically have this running I have run into some stability and config issues.  Instead of banging my head more I am switching to getting an initial core C* driver snippet going to help shake up some grey matter and make forward progress.  For now I will leave this task In Progress until I get it solid.

I now have the local test suite and integration tests working with both positive and negative tests (I purposefully invalidated some services to force tests to fail).  I will use these moving forward as I make changes to ensure things are working properly.


Stronger typing for Archetype

Hello, I'm playing around with this library for a game project and enjoying it so far ✌. I ran into a few hiccups with the typings for Archetype and I think these changes make sense - let me know if I misunderstood something.
– Entities emitted by onEntityAdded can have their type narrowed by the query
– But I think those in onEntityRemoved can't, because they may have been removed for no longer matching the query?
– first can return null, but the inferred type didn't know that
– and I also added an assertion to entityIsArchetype so Archetype.indexEntity no longer needs to use any.

Hi, thanks for the PR! I'm going to play around with it today, but I think the changes are sane. May I ask you to exclude the changes to yarn.lock and the addition of package-lock.json from this PR? Thanks!

yes!

Hi, can you change this PR so it does not delete package.json?

Oof 😮💨 - wrong file! sorry, that's amended and squashed.

Thank you! \o/


Nuget package hasn't been updated since 2018, will it be updated soon?

The Xbox.Live.SDK.UWP nuget package hasn't been updated in 3 years. Is it likely to be updated any time soon, or has Microsoft dropped support for UWP apps?

@jplafonta Will this be addressed at some point?

UWP is still supported and 2018.6.* UWP nuget package is the latest that UWP titles are shipping with

@jplafonta That is great to hear. Do Microsoft provide any C#/.NET sample projects that show it all working? I tried compiling the C++ sample projects in VS2019 and it wouldn't even build and has 47 errors, so I couldn't test it using that either.

@jplafonta the other issue with this old nuget is that it doesn't support ARM64 devices natively. These nugets only contain ARM support, AFAICT.

That's right, ARM64 isn't supported in these UWP nugets.
Be aware of this if you are working on a Creator's title:
https://github.com/microsoft/xbox-live-unity-plugin#2021-update-more-accessible-creators-program-no-longer-requires-xbox-live

@jasonsandlin what about C# samples showing best practices for using the nugets??


add Skynet Api Key support

PULL REQUEST
Overview
Adds custom_opt for adding Skynet-Api-Key
Note: I tried modifying the tests, but something about my environment is causing various warnings and mocks to fail. Fileportal.org seemed to break tests as well without an API Key.
Issues Closed
Closes #8

Note: I tried modifying the tests, but something about my environment is causing various warnings and mocks to fail. Fileportal.org seemed to break tests as well without an API Key.

@dghelm You were missing the default option in order to make this work. Whenever I add a new option, in any SDK, I always grep an existing option to see where and how it's implemented, and add the new option there. I also look for an existing test and copy or update it for the new option.


Include smallDevTools website for code sharing

Hey Shlomi,
Thank you for writing this detailed guide, very helpful.
Please add this tool smallDevTools for easy one-click code sharing of codes with syntax highlight & title option.
https://smalldev.tools/share-bin

Closing due to lack of reply.


Problem solved

My problem was solved & I figured it out. You can delete issue if needed. Thanks!

Ok, I close the issue, have a nice day :)


How to pass an access token

Hello!
Your package looks great! However, I'm having some trouble using it. How do I pass my authentication token?
Thanks in advance for your response. I plan to use the package seriously and would be happy to contribute to the documentation.

What is your goal here?
To set a auth header/cookie or to send a WS message with this?

This package don't support authentication, you cloud get it in README. But I think it will be popular package after adding auth

The consumers do support permission classes https://djangochannelsrestframework.readthedocs.io/en/latest/mixins.html
Such as
class LiveConsumer(ListModelMixin, GenericAsyncAPIConsumer):
    queryset = models.Test.objects.all()
    serializer_class = serializers.TestSerializer
    permission_classes = (permissions.IsAuthenticated,)


tests: Use allow to suppress warnings.

let's fix the warnings instead of suppressing them #354

Agree that that is better.


Removed logic that filtered out any server name except 'signalk-serve…

…r'.  This was preventing the app from responding to SignalkK streams originating from iKommunicate which can have user defined server names specified

Merged. Will push a new app to Google Play and Apple App Store over the weekend.


Support of exceptions raised in context of the others

When following code is used:
raise Exception('foo') from another_exception
better_exception shows only the last exception. It would be beneficial if it could show another_exception too. This can be implemented by looking at __context__ and __suppress_context__ attributes of the exception. For example:
https://hastebin.com/doyozafeji.py

yes, this would be very useful! I was bitten by this recently and couldn't figure out why it was happening

Yeah, I have implemented this in my fork, hopefully I will find some time to merge it upstream in the next few months...


enter title

test_build_training_sample_fasterrcnn was incorrectly named  test_build_training_sample_maskrcnn: duplicated name

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   56.00%   56.00%
=======================================
  Files          55       55
  Lines        1714     1714
=======================================
  Hits          960      960
  Misses        754      754

Flag
Coverage Δ

#unittests
56.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f5488...c93db31. Read the comment docs.

Thanks for the PR!!


Move ruby to use cmd not entrypoint and add test.

i like this change. it's least surprise when switching from the official ruby image.

@amouat Just double-checking about the test mentioned in the PR title

good point @luhring ! One sec...

The test does very little - just runs with irb and ruby with --version. It will pick up if the entrypoint is changed (unless something clever is done with a script).


Plug-in that lists which items in your bank can go into the costume room

A simple plug-in that searches your bank and lists which items will go in PoH the costume room. There's way too many items, it's hard to keep track and search your entire bank. Also, some items that you'd expect to go in the costume room actually don't (such as blessings, vestment cloaks, many other clue items).

I can work on this the way I would go about it personally would just show it on the tooltip EG: Storage: Costume Room (Cape Rack)

Lookup "Costume Room Highlight"


Process Relaunch Fails

Since upgrading from v1 to v2 of Tauri, relaunch fails after installing an update fails with: Command plugin:process|restart not allowed by ACL .
I had a look at the permissions for the process plugin and tried adding either allow-restart or process:allow-restart to the capabilities/default.json file, but I get a warning that the "value is not accepted" and then a list of valid values that does not include any process values.
JS Versions:

"@tauri-apps/cli": "^2.0.0-rc.10"
"@tauri-apps/plugin-process": "^2.0.0-rc.1"

Rust Versions:
[[package]]
name = "tauri-plugin-process"
version = "2.0.0-rc.1"
source = "git+https://github.com/tauri-apps/plugins-workspace?branch=v2#51819c601f863cbfbd11809a1c4cf9df5a20b1e0"
dependencies = [
 "tauri",
 "tauri-plugin",
]

Actually apologies, I was not registering the process plugin with the tauri builder .plugin(tauri_plugin_process::init()), doing that fixed the warnings from the capabilities files.


CM-552: How to Run an Async Method Synchronously in .NET

Hello @aineaTheSecond, I've noticed that the folder name has a typo can you fix that as well as the solution file name.

I had not noticed before, but I've made the change. Please check.
Thanks.


uniref100 external record links to uniprot.org are broken, getting 404s

e.g. at /data/uniref100/106975085/ external URL is:
https://www.uniprot.org/uniref/UniRef100_A0A4Q5W1V4

So A0A4Q5W1V4 (the example) above got de-listed by uniprot, so proble here, we're just out of date.  Many ur100 links resolve fine, so the URL formatting is good.
Now, e.g. http://localhost:8000/data/uniref100/129620947/ has another issue, the A0A1B3PZB3 is member (but not seed & representative) of 100% cluster UniRef100_G4CXR9.  So, our link fails but we don't have G4CXR9 in UMRAD.  Is this a data-model issue or are we just out-of-date?

Issue will be addressed at the time when the UMRAD part of GLAMR gets updated (sometime in 2025?)


Toyota: OP occasionally releases brakeHold when pressing resume button

Describe the bug
If brakeHold is active and OP has already been activated prior. While at a stop w/ brakeHold active, OP occasionally releases the brakeHold when pressing the resume button. When at a stop w/ brakeHold active OP should either continue holding the brakeHold or resume OP selfdrive when the resume button is pressed.
Release of brakeHold by OP while pressing resume may confuse the driver into thinking OP is active when it is not. This presents a particular issue in tight stop and go traffic. When the user expects to resume OP after some type of long issue forced them to disengage. Pressing resume at a small distance w/o OP activating but releasing the brakeHold could in theory cause an accident to an unfamiliar user.
Stock Toyota ACC requires driver to press resume twice (initial + confirm) or press gas pedal (picture below) in order to enable stock ACC while brakeHold is active.

Which car does this affect?
Toyota Corolla Hatchback 2019, many tss2 Toyotas
Provide a route where the issue occurs
4ecfcac756318cbf|2023-08-05--18-43-56--2
openpilot version
0.9.4
Additional info
Allowing OP to resume in a brakeHold state like the stock Toyota ACC does would be matching industry standards. When brakeHold is active, the car is already in a state of selfdrive. Since no one is pressing the brake or controlling the car, other than the car.
Issue started in 0.8.11 when brakeHold event was classified as a human pressing the brake.

duplicate of https://github.com/commaai/openpilot/issues/23095


Mixing up JSON and CSV

Hi,
It's ambiguous calling a JSON file a CSV file.  You should explain why the incorrect naming, or just stick with calling JSON JSON, and CSV CSV unless this is converting a CSV to JSON (which might be a nice opton)
Thanks!
Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96e6e3c8-bc3b-900b-ff9a-fd56b33afab7
Version Independent ID: f6423be1-2491-f53f-2344-b3f630e441fe
Content: Set up a connector to import physical badging data - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/import-physical-badging-data.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@lkchild Thanks for the feedback. The use of CSV is step 5 in this article is a copy and paste error. I will fix this so we're just calling JSON JSON.


Same comment is shown in multiple places

Expand https://github.com/Microsoft/vscode/pull/40176 in the GitHub Pull Request viewlet.
Open port.ts

When I click the first blue decoration on the right I get:

By clicking the blue decorations on the left I get:

Now I have comment "33" three times on the screen and I have no idea where it actually belongs to.

Oh, and when I close the editor and open v8-inspect-profiler.d.ts instead I get bonus sticky "33" comments (i.e. they don't scroll with the rest of the window.


Add Code of Conduct

We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md

I want to work on with this. Assign me this

I would like to work on this issue. Please assign me this task.

we already have code of Conduct file

@satyaveni299 @suhanipaliwal Please raise any other issue, i'll assign you
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


Add Ed25519 algorithm for signing

Is your feature request related to a problem? Please describe.
We should add more algorithms for signing, so Ed25519 is a great choice for extension.
Describe the solution you'd like
We can simply add Ed25519 structure interfacing with SignatureAlgorithm interface implementing Ed25519 algorithm.

@pkosilo, I'd like to work on it myself too.

@pkosilo, I'd like to work on it myself too.


Swiper Element breaks touch events

Check that this is really a bug

[X] I confirm

Reproduction link
https://codepen.io/Tattoo4861/pen/eYLvwjO
Bug description
When using Swiper Element all touch events on the page are broken. Swiper takes over touch and pointer events and re-emits a invalid touchStart event that is missing many expected attributes, such as TouchEvent.touches (see https://developer.mozilla.org/en-US/docs/Web/API/Element/touchstart_event).
In the reproduction codepen we listen to touchStart which should have a touches attribute. When loading swiper the event is missing touches (among other things). If one removes the swiper script-tag the event works as expected again.
The code that is responsible for this is:

https://github.com/nolimits4web/swiper/blob/2533493de8cb776a8965096f021cddfdb7d088b8/src/core/events/onTouchStart.js#L141
https://github.com/nolimits4web/swiper/blob/2533493de8cb776a8965096f021cddfdb7d088b8/src/core/events/index.js#L22

Swiper should

not create events does not exist, such as touch-events from pointer-events
if emitting a touchStart event make sure it is a valid TouchEvent

Expected Behavior
No response
Actual Behavior
No response
Swiper version
9
Platform/Target and Browser Versions
Win10+Chrome
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Why was it closed? It is clearly a bug that prevents swiper from being used together with other libraries that listens to touch events (such as MUI).

Yes, I need to touch events on Android 5. x/6. x。Touch Events is not supported。

I have the same issue.
Adding pointer-events: none; to the elements inside swiper-slide solves the issue but isn't ideal for clickable content:
swiper-slide > * {
  pointer-events: none;
}


🌐 feat(i18n): add Odia language

Summary

Odia Language support added

Related issue

Changes

or.toml file added

Accessibility

Not Applicable
Screenshots

Type of change

[ ] Bug fix (fixes an issue without altering functionality)
[x] New feature (adds non-breaking functionality)
[ ] Breaking change (alters existing functionality)
[x] UI/UX improvement (enhances user interface without altering functionality)
[ ] Refactor (improves code quality without altering functionality)
[x] Documentation update
[ ] Other (please describe below)

Checklist

[x] I have verified the accessibility of my changes
[x] I have tested all possible scenarios for this change
[ ] I have updated theme.toml with a sane default for the feature
[x] I have made corresponding changes to the documentation:

[ ] Updated config.toml comments
[ ] Updated theme.toml comments
[x] Updated "Mastering tabi" post in English
[x] (Optional) Updated "Mastering tabi" post in Spanish
[x] (Optional) Updated "Mastering tabi" post in Catalan

Thank you for your time and effort!
Merging~


Inputs & Outputs docs for Go aren't finished

Problem description
The language chooser on the "Programming Model" page still isn't quite complete. If you look at the "working with strings" section, the Go example doesn't show a complete apply:
https://www.pulumi.com/docs/intro/concepts/programming-model/#outputs-and-strings
var hostname pulumi.StringOutput
var port pulumi.NumberOutput

url := // ?

In addition to this, the accessing properties of an output section is also not complete:
https://www.pulumi.com/docs/intro/concepts/programming-model/#lifting
// Helpers for accessing properties are not yet available in Go.

The first one is just the setup for the below examples. Python and others are similar:

For the second one, this is accurate as we don't currently support property lifting in Go and have no plans to do so as far as I'm aware. I guess we have the Index() functions on Map and Array outputs, that could be documented here, but I'm not sure this is a 1:1 mapping of the lifting feature.

I think the former is the same across all languages. It’s part of the narrative way of introducing the concept. No doubt a little awkward - but I believe not Go-specific.
For the latter - we could show off the accessor methods that are conventional on strongly typed Output structs here. They aren’t quite the same - but could make sense to highlight in this context.

Relatedly, this came up again in the case of Index on output types in Go for ArrayOutputs and not having great documentation for that.


Uncaught TypeError: n.map is not a function

When trying to use this package, I got the following error in the Chrome console: Uncaught TypeError: n.map is not a function.
Below is a screenshot of the code I was using:

I have the following dependencies related to this project:
"react-slideshow-image": "^3.4.3"
"react": "^17.0.2"
"react-dom": "^17.0.2"
"css-loader": "^5.2.0"
"style-loader": "^2.0.0"
Any help would be much appreciated

Ignore the underlined Slide import - this is just an editor feature.

@slatifi you're seeing the error because you only have one direct child. A quick fix will be something like this
const Slideshow = () => {
    return (

        <Slide easing="ease">
          {[1].map(() =>

            <div style={{'backgroundImage': `url(${slideImages[0]})`}}>
              Slide 1

)}
        </Slide>

    )
};

I'll release a new version soon that will effectively solve this

@slatifi I've released a new version v3.4.5 you can re-install the package


Ensure that MySQL is stopped before Puppet runs

Unfortunately because the upstream module manages the MySQL service there's no good way of disabling it to start on boot. If it does try to start on boot, it will likely fail because the /var/lib/mysql dir won't have been initilised, however it will still place some ibdata stuff inside of it.
We do not want anything shadow mounted, so using the on-boot cron job, stop the mysql service (if it's already stopped then the exit code will be 1 thus the break), delete the directory and run puppet. Puppet will then create the directory, mount in tmpfs and do everything else.

This isn't required because the changes in /etc/fstab will ensure the directory is mounted before the MySQL service even tries to start on boot.


feat(parameters): Allow settings boto3.client() arguments

Fixes https://github.com/awslabs/aws-lambda-powertools-python/issues/1079
I didn't add it to dynamoDB parameter becuase i'm not sure it's possible there.
Fixed also the docs.

View rendered docs/utilities/parameters.md

@heitorlessa  not really sure how to add tests for the client init, didnt see any tests for the session either

not really sure why codecov doesnt show an updated version. I added tests

thanks for that @ran-isenberg - fixed the title as I see this as a bug as customers can't use the functionality we provide.
The pull request body is missing our required acknowledgements: are you okay if I edit the content to add them back as I can't review PRs without it?
Thanks a lot!

@heitorlessa  after all this time, do you really need to ask? :)
go for it

Two minor changes - 1/ Make use of forward reference for type annotation ( "SSMClient" from mypy_boto3_<service), and 2/ refactor branching logic into a static method to prevent logic discrepancy in a future change.
I ran out of time to look into the tests and DynamoDB, but I will as soon as I'm able.
Side note: Secrets Manager and SSM seem to be the only ones supporting endpoint_url according to this doc, yet boto3_client will benefit everyone's testing: docs.aws.amazon.com/vpc/latest/privatelink/integrated-services-vpce-list.html

@heitorlessa @ran-isenberg - should we be bundling boto3-stubs as part of the python runtime?

Haven't forgotten @ran-isenberg. I'll look into as soon as I can this week.

When this is released as is and it has to include a new runtime dependency for internal typing.
Can we include a warning in the changelog for customers like me at FiServ, who needs to scan for upstream issues and resolve conflicts if using a conflicting boto stubs.
Or change this make this optional dependency

maybe 2 PRs

154 lines to fix just #1079
430 lines or more for the mypy stubs and what ever other packages could use it. Like Idempotency, Batch, Parameters, Data Class (code_pipeline_job_event)

@ran-isenberg thanks for making those changes. I've made code change suggestions along with explanations about why they're needed - let me know if they don't make sense.
For the DynamoDB and parent static method piece, GitHub seems to have swallowed the review thread and I can't make comments anymore. I understand you concern about having a static method in the parent that's applicable to two clients (SSM, SecretsManager) but DynamoDB. I'd like to propose a solution to unblock this PR, as we still need to address DynamoDB regardless.
Suggestion: Add the same boto3_client in DynamoDB with an explicit resource type definition, plus doc strings as well as docs stating that we expect a DynamoDB resource client. I thought about boto3_resource_client but ultimately it will come down to practicality at this point, hence the suggestion of keeping boto3_client, as resource is also a client (high level vs low level).

Great work in finding an alternative of doing typing checking during development time and not make a required runtime dependency.
But does this make sense as part of this pull request? At a minimum just the added client parameter is needed to resolve #1079

@heitorlessa  @michaelbrewer  I pushed the changes you wanted.
I didnt do the dynamodb changes as I dont fully understand what you suggested. DynamoDB already gets an optional boto session, so not really sure what the client has to do with anything. We create a table from the session.
Feel free to make the changes yourself or explain them again :)

@heitorlessa @michaelbrewer I pushed the changes you wanted. I didnt do the dynamodb changes as I dont fully understand what you suggested. DynamoDB already gets an optional boto session, so not really sure what the client has to do with anything. We create a table from the session.
Feel free to make the changes yourself or explain them again :)

Thanks a lot for making those changes, Ran! I'll push the other changes and ping you for review later this week

@ran-isenberg @heitorlessa - in case you want a dumbed down version of this PR see #1197 . It just focuses on the original request and docs updates. This might make review easier.

feel free to kill #1197 if it does not fit

@heitorlessa @michaelbrewer I pushed the changes you wanted. I didnt do the dynamodb changes as I dont fully understand what you suggested. DynamoDB already gets an optional boto session, so not really sure what the client has to do with anything. We create a table from the session.
Feel free to make the changes yourself or explain them again :)

Thanks a lot for making those changes, Ran! I'll push the other changes and ping you for review later this week

As promised, I've transferred what I had in my local branch and made additional fixes. This is now ready to be review.
@gshpychka - @sthulb will review and once approved we should release it ASAP to unblock the VPC private endpoints. We had a delay in getting this out to you due to a larger operational and internal work.

@heitorlessa @michaelbrewer I pushed the changes you wanted. I didnt do the dynamodb changes as I dont fully understand what you suggested. DynamoDB already gets an optional boto session, so not really sure what the client has to do with anything. We create a table from the session.
Feel free to make the changes yourself or explain them again :)

Thanks a lot for making those changes, Ran! I'll push the other changes and ping you for review later this week

As promised, I've transferred what I had in my local branch and made additional fixes. This is now ready to be review.
@gshpychka - @sthulb will review and once approved we should release it ASAP to unblock the VPC private endpoints. We had a delay in getting this out to you due to a larger operational and internal work.

Would this be a major release update? Have you done integration testing (due to the large number of changes)

Would this be a major release update? Have you done integration testing (due to the large number of changes)

As per semver, this would require a minor release. 1.x.0, this doesn't remove any functionality or fundamentally change anything for users.

so a feature release ie: 1.25.0. I never expect this to be a 2.0.0 release.


SW-4761 Create OrganizationRouter and put organization related views into the scenes directory

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #2050

PR #2061

PR #2062

PR #2063

PR #2064

PR #2065

PR #2066   👈

PR #2067

This stack of pull requests is managed by Graphite.

I will do this in a follow up PR

Merge activity

Jan 25, 3:38 PM: @sgrimm started a stack merge that includes this pull request via Graphite.


Added option to render lightbox on the root node

When trying to added ModalImage in certain div's it can cause the lightbox to be constrained to the parent styles.  This just allows you to add/remove the lightbox on the root node.  I suppose it could be a configurable node instead of just the root, but this worked great for me.

@ac3d912 thank you for this! I'll review the changes during the weekend and merge them 👍

in certain div's it can cause the lightbox to be constrained to the parent styles

@ac3d912 would you provide an example of a situation where this happens?
I've reviewed the pull request. Portals are not available in React 15. I'd like to keep backward compatibility with React 15 and thus I'd be interested to understand the problem a bit more.

I was using it with slick-carousel (https://github.com/kenwheeler/slick/) and bootstrap.  When the lightbox popped up it was being constrained to the slick-carousel area.
The portals in 16 work great, but I understand wanting to keep backwards compatibility. Not sure how else to get out of any parent styles...rendering on root was just the easiest solution.
import 'slick-carousel/slick/slick.css';
import 'slick-carousel/slick/slick-theme.css';
import Slider from 'react-slick';
import ModalImage from 'react-modal-image'

...
    this.createdImages = Object.keys(this.props.images).map((image, index) => {
      // eslint-disable-line arrow-body-style
      /* istanbul ignore next */
      return (

          <ModalImage
            small={this.props.images[image][0]}
            large={this.props.images[image][1]}
            alt=''
            className='slider-image'
            renderRoot={true}
            hideDownload={true}
          />

      );
    });
...
  _get_slick_carousel() {
    var settings = {
      centerMode: true,
      //centerWidth: '10px',
      //variableWidth: true,
      dots: false,
      infinite: true,
      speed: 500,
      slidesToScroll: 1,
      slidesToShow: 2,
      initialSlide: 0,
      draggable: false,
      responsive: [
        {
          breakpoint: 1024,
          settings: {
            centerMode: true,
            slidesToShow: 1,
          },
        },
        {
          breakpoint: 980,
          settings: {
            centerMode: false,
            slidesToShow: 1,
          },
        },
      ],
    };

    return (

        <Slider {...settings}>{this.createdImages}</Slider>

    );
  }
...

.slider-image {
  padding-left: 0px;
  padding-right: 0px;
  margin: auto;
}

Here's a screenshot of the result without rendering it on root:


loadable/component - loadableReady doesn't work on webpack 5

🐛 Bug Report
Method loadableReady throws errors on every version of Webpack 5. The same code and config works on Webpack 4.
On client side:
import React from 'react';
import { hydrate } from 'react-dom';
import { loadableReady } from '@loadable/component';

loadableReady().then(() => {
  hydrate(<App />, document.getElementById('app'));
});

It throws
loadable-components: failed to synchronously load component, which expected to be available {fileName: "../ui/src/views/history/index.tsx", chunkName: "history", error: "Cannot read property 'call' of undefined"}

and
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

 You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

 You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

 You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

 You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `InnerLoadable`.
    at createFiberFromTypeAndProps (react-dom.development.js?ef6f:25051)
    at createFiberFromElement (react-dom.development.js?ef6f:25079)
    at reconcileSingleElement (react-dom.development.js?ef6f:14045)
    at reconcileChildFibers (react-dom.development.js?ef6f:14105)
    at reconcileChildren (react-dom.development.js?ef6f:16983)
    at finishClassComponent (react-dom.development.js?ef6f:17504)
    at updateClassComponent (react-dom.development.js?ef6f:17428)
    at beginWork (react-dom.development.js?ef6f:19066)
    at HTMLUnknownElement.callCallback (react-dom.development.js?ef6f:3946)
    at Object.invokeGuardedCallbackDev (react-dom.development.js?ef6f:3995)

Details
## System:
 - OS: Windows 10 10.0.19041
 - CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor

 - Memory: 8.38 GB / 15.95 GB
## Binaries:
 - Node: 12.16.3 - C:\Program Files\nodejs\node.EXE
 - Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD - npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
## npmPackages:
 - @loadable/babel-plugin: ^5.13.2 => 5.13.2
 - @loadable/component: ^5.14.1 => 5.14.1
 - @loadable/server: ^5.14.0 => 5.14.0
 - @loadable/webpack-plugin: ^5.14.0 => 5.14.0
 - webpack: > 5.0.0

The only know method for webpack5 is to replace async scripts by defer scripts. Which is not supported by loadable itself, and you have to replace strings manually :(
The problem is on webpack side.
Closing this issue as a duplicate of https://github.com/gregberge/loadable-components/issues/636

confirm replacing async with defer for scriptTags works. Thanks.

confirm replacing async with defer for scriptTags works. Thanks.

where did you change that option ?

Someone please pull request it 🙏

where did you change that option ?
@joacub

when you do ssr and doing something like
const extractor = new ChunkExtractor({
  statsFile,
  entrypoints: ['app'],
});
const root = React.createElement(App, {
  BrowserRouter: Router,
});
const jsx = extractor.collectChunks(root);
//...

then you can collect scripts by running
const scriptTags = extractor.getScriptTags();

so on this point you have to replace async with defer
const scriptTags = extractor.getScriptTags().replace(/async/gi, 'defer');

or if you are using node15+
const scriptTags = extractor.getScriptTags().replaceAll('async', 'defer');

That doesn’t work, problem is the collector stats are wrong does not have the correct stats file. Is getting the server compilation i dont know why... and does not get the right assets for browser...

@joacub then you are experiencing different issue)) I assume you are trying to do ssr, and then you have 2 webpack configs with 2 different settings, and you should have 2 different stats file. so when you collect chunks using root element from one folder, stats file you should import from another. but this is only my assumption - you haven't put any details of your problem.

@joacub then you are experiencing different issue)) I assume you are trying to do ssr, and then you have 2 webpack configs with 2 different settings, and you should have 2 different stats file. so when you collect chunks using root element from one folder, stats file you should import from another. but this is only my assumption - you haven't put any details of your problem.

Yes you are completely right, I don’t know why it’s getting the server stats file maybe a doing something wrong, i will check and come back to you

Is working now, i forgot put writetodisk option. Is working great again, thanks


Proposal: Fixed size thunk pool support

As today's game consoles are very strict when it comes to any kind of JIT FEATURE_RX_THUNKS is not an option. But even the Fallback that tries to use a thunk template is not possible. Therefore I need to fall back even more to a thunk pool that have a fixed number of thunks pregenerated set a compile time. The data part could be allocated dynamically but the code needs to be always there.
While my current implementation only works for the switch I noticed that parts of it could be make platform and cpu neutral by using the abstractions layers that are already there.
Would you be interested on an implementation for a general "FEATURE_FIXED_POOL_THUNKS" that should only require an additional assembler file (or two if .S and .asm are needed)  per CPU architecture?
I will most likely do it anyway to share more code between the different game consoles but I can make it a PR if there is general interest for it

Yes, I think having an option to build with a fixed number of thunks that avoids the memmapping could be useful for some platforms. AFAIK this is how thunkpool actually started, back in .NET Native, but the "you ran out of thunks" exception got old pretty quickly.

Would you be interested on an implementation for a general "FEATURE_FIXED_POOL_THUNKS" that should only require an additional assembler file (or two if .S and .asm are needed)  per CPU architecture?

Is the idea that we would set the fixed number of thunkpool thunks at the time the native portion of the runtime is built (i.e. we would need to recompile the runtime if more thunks are needed)?
We could potentially build the specified number of thunks within the AOT compiler (same as we e.g. generate the ReadyToRun assembly helpers).

The number of thunks is currently set in one single assembler file that generated the thunks and contains some helper functions. The idea I had was to assemble this file as part of the final executable and link it there. This way the runtime doesn't need to be rebuild every time the number of thunks change. But generating the thunks as part of the AOT compiler sounds like a good idea, too.

That would work too. Doing it in the compiler has the advantage of not needing an extra tool, but I guess this is enough of a corner case scenario that it doesn't matter - people who target consoles need to have all sorts of tools installed.

I like the idea to let the compiler do this work. This would eliminate one more step that could go wrong. Writing games for Game Consoles with C# should be easier not more complicated than with the regular C++ based SDKs.


Do not use defaults channel in environments

Fixes #158
Changes made in this Pull Request:

Do not use defaults channel in environments

PR Checklist

[ ] Tests?
[ ] Docs?
[ ] CHANGELOG updated?
[x] Issue raised/referenced?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.28%. Comparing base (98dd835) to head (77a0c97).

:exclamation:  There is a different number of reports uploaded between BASE (98dd835) and HEAD (77a0c97). Click for more details.
HEAD has 147 uploads less than BASE

Flag
BASE (98dd835)
HEAD (77a0c97)

151
4

Additional details and impacted files

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


chore(primitives): Update keccak256 implementation

re-use keccak256 from ethers_core::utils
PS. excited for this :)

Some code was using ethers_core::keccak256 while other the primitives version, which is essentially the same code with an extra .into(); I can revert back to the current implementation of keccak256 while keeping the other changes

sg, ideally everything should use the primitves fn

Codecov Report

Merging #563 (fada16d) into main (82197d0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   72.92%   72.92%
=======================================
  Files         243      244    +1
  Lines       24688    24690    +2
=======================================
+ Hits        18003    18006    +3
+ Misses       6685     6684    -1

Flag
Coverage Δ

unit-tests
72.92% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/primitives/src/transaction/util.rs
100.00% <ø> (ø)

crates/primitives/src/header.rs
93.92% <100.00%> (ø)

crates/primitives/src/lib.rs
100.00% <100.00%> (ø)

crates/primitives/src/transaction/mod.rs
89.79% <100.00%> (ø)

crates/net/rpc-api/src/admin.rs
0.00% <0.00%> (ø)

crates/net/discv4/src/lib.rs
51.66% <0.00%> (+0.09%)
:arrow_up:

crates/net/network/src/session/active.rs
82.96% <0.00%> (+0.20%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.