refactor: Remaining commits of moving to internal functions

Breaking change
These are the PRs from the 2nd and 3rd PR combined
Functionality in this PR

Move input_boolean helper entities to switch entities
Move input_number to number entities
Move input_datetime to datetime or time entities
Store coordinator data to disk and restore on HA restart
Build Code Slot active logic
Move applicable automations and scripts to listeners
Add boltchecked/retry lock function
Add auto-lock timer function
Ensure new and change configurations work properly

To Do in future PRs

Add button entity to reset (lock and each code slot?)
Rebuild lovelace code generator
Rebuild HA actions/services
Build a best effort migration from the current version to this one
Remove prior keymaster package files in the migration

Prior to release, I'll remove a lot of the logging and remove the actual PIN/Usercodes from the logs.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[x] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR is related to issue: #393

@firstof9 should be good to go


"Context access might be invalid" warning thrown for repository variables and secrets

Describe the bug
After upgrading to 0.25.8, a "Context access might be invalid" warning is thrown for all repository variables and secrets in the workflow file. Refreshing the secrets/vars in the extension has no effect.
Expected behavior
Secrets/vars should not throw a "Context access might be invalid" warning.
Screenshots

Extension Version
v0.25.8
Additional context
Add any other context about the problem here.

Also seeing this issue still with the latest release.
Previous issues #47 #61 and #67 stated the issue would be fixed with the next release, but issue continues to persist into release v0.25.8 and the change log seems to make no mention of a fix being deployed.

Any update on this?

I still see this as well; the extension version is v0.25.8

Seeing the same here constantly with v0.25.8

Just wanted to confirm that the issue continues to persist in 0.25.8 (and it's feeling really annoying)

also seeing this constantly in v0.25.8 with env variables, but not secrets

Same here. A bit annoying indeed 👍

Still persists kind of embarrassing for GH

ah, i see this is an actual issue. i was going mad with this. Let´s hope it´s fixed soon.

Yep, its a bug. Moved to triage. No ETA on a fix, if someone makes a PR to fix, I'm happy to review it.

I uninstalled, reinstalled and restarted VSCode and then the warnings went away.

I was receiving this error after installing the extension. Simply running the "Developer: Reload Window" command fixed it for me without needing to reinstall. So far it hasn't seemed to return yet.

I was receiving this error after installing the extension. Simply running the "Developer: Reload Window" command fixed it for me without needing to reinstall. So far it hasn't seemed to return yet, at least for repo secrets.

I tried this but it came back :(

Okay, at least in my instance, the issue seems to be because I have a setup like this:
organization/repo - Main repository. Secrets/vars are done on this.
myuser/repo - Fork which I do my work on before creating a merge to push to upstream/main. Therefore in actions, its thinks the vars/secrets don't exist because they existing the main repo not my fork. There should at least be a way of ignoring this specific error if this is the case.

👋 Reporting in, still happening on v0.26.1.

There should at least be a way of ignoring this specific error if this is the case.

Agreed, there should at least be a # github-actions-extension ignore comment one can use.

I get this warning for any environment variable exported in a previous step via foo=bar >>$GITHUB_ENV

I uninstalled, reinstalled and restarted VSCode and then the warnings went away. v0.25.8

This worked for me.

This seems to only happen when environment property is dynamic.

I get this error for all of my secrets, am I missing something?

Expected behavior
Secrets/vars should not throw a "Context access might be invalid" warning.

I actually like this warning. Because our YAML file has no access to production environment variables when we're editing it, it's a nice reminder to double-check our variable names.

Expected behavior
Secrets/vars should not throw a "Context access might be invalid" warning.

I actually like this warning. Because our YAML file has no access to production environment variables when we're editing it, it's a nice reminder to double-check our variable names.

That's one way of looking at it. I would say a more realistic view is that it will condition you to ignore the warnings which causes the opposite effect of what you described.

I'm seeing this same behavior when pulling an output from a previous step through needs "Context access might be invalid". Is this being triggered by the value not being available to read because the previous step has not run? Just wondering as you'd think it could see the output it'd be pulling the value from is in the previous needed step.

I had this error on secrets. Turns out I wasn't properly signed in on github inside Vscode. Signing in and reloading fixed the issue.

I had this error on secrets. Turns out I wasn't properly signed in on github inside Vscode. Signing in and reloading fixed the issue.

How does one "sign in to GitHub inside VS Code"?
And I'd argue this is a bug regardless; if you're not signed in, then it should just assume all variables are fine, not spam you with spurious warnings.

However, this will cause VSCode to color this folder yellow, override source control's color. I can't tell if any project is committed or not as all my project folders are alway marked yellow. I might forget to commit changes for that reason.

Saw this error after installing and signing in. Uninstalled it and reinstalled it, and it worked properly.

I signed in to github after installing the extension and saw the secrets errors. I completely quit VS Code and re-opened it again and the secrets were no longer throwing any warnings. :)

I signed in to github after installing the extension and saw the secrets errors. I completely quit VS Code and re-opened it again and the secrets were no longer throwing any warnings. :)

Yeah, this happened to me too. I think I just clicked the "refresh current branch" button in the sidebar and the errors went away.

Same here. Restarting VS Code after install and login fixed the issue for me!

V0.26.2 - as long as you are logged in and have given access to the extension, make sure you execute Developer: Reload Window (or restart VSCode). I also had this issue until performing both these steps. Hope that helps someone.

Didn't saw it mentioned, so... dump workaround if anyone needs:
${{ fromJSON(toJSON(secrets)).MY_LITTLE_SECRET }}

Easy to restore proper syntax when/if fix comes.

v0.26.2 it does not work for me using Developer: Reload Window (or restart VSCode).
Context access might be invalid: PERSONAL_TOKEN

Here are my steps to resolve the warning "Context access might be invalid: TOKEN":

Install the GitHub Actions extension in VS Code.
Open the GitHub Actions tab and ensure that you are logged in and have fetched the action info for your Git repository.
In the SETTINGS section, verify the presence of the variables you have set under "Environments" and "Secrets".
If the warning persists, try running "Refresh current branch" from the Command Palette. Alternatively, you can restart VS Code.

Here are my steps to resolve the warningContext access might be invalid: TOKEN:

Install the GitHub Actions extension in VS Code.
Open the GitHub Actions tab and ensure that you are logged in and have fetched the action info for your Git repository.
In the SETTINGS section, verify the presence of the variables you have set under "Environments" and "Secrets".
If the warning persists, try running "Refresh current branch" from the Command Palette. Alternatively, you can restart VS Code.

Yeah, this worked for me, thanks for sharing.
I'm using Github Actions v0.26.2.

With the Github Actions VSCode Extension (i really recommend to use this if you intend to keep using GitHub Actions), in the "GitHub Actions" tab in left sidebar menu, (ensure that you're already logged in with your GitHub account), you can see which environment you env-variable is:
In my case, TEST(Environment) > TESTEE (Variable)

With that in mind, you have to set you environment in your job before calling the enviroments variables, just like this:
run-program:
  runs-on: ubuntu-latest
  needs: build

  environment: TEST # set environment
  env:              # and then... call your variables
    TESTEE: ${{ vars.TESTEE }}

  steps:
    - name: Check out repository code
      uses: actions/checkout@v4

    - name: Run main file
      run: python app/main.py

I hope this can help you, have a nice day! 😄

Hey guys, i think some of you are forgetting to set the environment before setting environment variables...
With the Github Actions VSCode Extension (i really recommend to use this if you intend to keep using GitHub Actions), in the "GitHub Actions" tab in left sidebar menu, (ensure that you're already logged in with your GitHub account), you can see which environment you env-variable is:
In my case, TEST(Environment) > TESTEE (Variable)
With that in mind, you have to set you environment in your job before calling the enviroments variables, just like this:
run-program:
  runs-on: ubuntu-latest
  needs: build

  environment: TEST # set environment
  env:              # and then... call your variables
    TESTEE: ${{ vars.TESTEE }}

  steps:
    - name: Check out repository code
      uses: actions/checkout@v4

    - name: Run main file
      run: python app/main.py

I hope this can help you, have a nice day! 😄

Thanks for posting this! I was able to resolve this in my repo using some of the information here. Adding environment kept giving me errors, but by adding
env:
  MY_VAR:

to the job in my workflow file, I was able to get the plugin to stop flagging my variable. Not sure if this is a hack, but it worked for me

Here are my steps to resolve the warningContext access might be invalid: TOKEN:

Install the GitHub Actions extension in VS Code.
Open the GitHub Actions tab and ensure that you are logged in and have fetched the action info for your Git repository.
In the SETTINGS section, verify the presence of the variables you have set under "Environments" and "Secrets".
If the warning persists, try running "Refresh current branch" from the Command Palette. Alternatively, you can restart VS Code.

This comment above in combination with running "Developer: Reload window" worked for me.

In case someone else has the same problem, I used the remote name origin for my personal fork and upstream for the org fork (which has the secrets), so I had to update this setting:

Unfortunately, even if the GitHub Actions extension is successfully logged in and Environments/Secrets/Variables are visible in the sidebar, I'm still having the issue. The lint warnings still appear if the variable is defined in a previous step via >> $GITHUB_ENV, such as in this example:

(I'm using version 0.26.2 if it matters)

Unfortunately, even if the GitHub Actions extension is successfully logged in and Environments/Secrets/Variables are visible in the sidebar, I'm still having the issue. The lint warnings still appear if the variable is defined in a previous step via >> $GITHUB_ENV, such as in this example:  (I'm using version 0.26.2 if it matters)

I have exactly the same issue as yours. Quite annoying.

Is there a way to disable this warning in VSCode?

Uninstalling / Installing again seems to have worked for me (so far)

How should this work for callable workflows? The plugin obviously can't know if necessary secrets/vars are in place in the repository which invokes my callable workflow.
There should definitely be a enable/disable for this feature.

Thanks @iuritorres for writing this up! I was able to resolve this in my repo using some of the information here. Adding environment kept giving me errors, but by adding
env:
  MY_VAR:

to the job in my workflow file, I was able to get the plugin to stop flagging uses of env.MY_VAR. Not sure if this is a hack, but it worked for me
edit: clarity

This worked for me.

For me I had to log into Github in the GithubActions plugin, and Developer: Reload Window and then it worked.

As a side but important note, it does seem that the GItHub Actions extension does not handle the secret contexts when working in a multi-project workspace. That is the context for which I find this error occurring. When I open a single Git repository in a new window there are no errors.
And the GitHub Actions panel looks like:

The GitHub extension meanwhile handles this perfectly fine in multi-project workspaces.

Here are my steps to resolve the warningContext access might be invalid: TOKEN:

Install the GitHub Actions extension in VS Code.
Open the GitHub Actions tab and ensure that you are logged in and have fetched the action info for your Git repository.
In the SETTINGS section, verify the presence of the variables you have set under "Environments" and "Secrets".
If the warning persists, try running "Refresh current branch" from the Command Palette. Alternatively, you can restart VS Code.

This didn't work for me. My difference is I'm using environment secrets/variables, not repository. This also only happens for variables for me and not secrets.

This seems to only happen when environment property is dynamic.

Same issue. My environment is dynamic. v0.26.2

How should this work for callable workflows? The plugin obviously can't know if necessary secrets/vars are in place in the repository which invokes my callable workflow.
There should definitely be a enable/disable for this feature.

Same, I have environment variables set in another callable workflow / action dynamically and of course it's no able to see it. I just would like to disable this warning, is this possible ?

This was fixed for me by opening the GitHub actions side panel, making sure its logged in, refreshing, then opening the Secrets dropdown. Then after that, I ran the vscode command > Developer: Reload Window.
Now it is working fine.

Would be great if this could work without requiring github login. I would be completely fine with it assuming the required secrets exist when it doesn't know otherwise.

I have found a solution that works at least for me.
SECRET squiggles and ENVIRONMENT squiggles have had different causes (in my case at least).

In order to get rid of SECRET warning squiggles I had to properly login and then reload the screen (that was resolved easy, thanks to comments before). Secrets are defined in same repo, where this workflow .yaml file is located.
To remove warning squiggles from ENVIRONMENT variables, I had to add env: statement with definition of each Environment variable I was about to use in particular Step. Example:

This Step definition causes warning squiggles to appear under env.TAG_VERSION (BAD):
- name: Build x86 Image
        uses: docker/build-push-action@v3
        with:
          context: .
          file: DockerfileAMD
          platforms: linux/amd64
          tags: username/image_name:${{ env.TAG_VERSION }}

How this warning looks like in IDE:

Now, this Step definition REMOVES warning squiggles under env.TAG_VERSION (GOOD):
- name: Build x86 Image
        uses: docker/build-push-action@v3
        env:
          TAG_VERSION: ${{ env.TAG_VERSION }}
        with:
          context: .
          file: DockerfileAMD
          platforms: linux/amd64
          tags: username/image_name:${{ env.TAG_VERSION }}

How this looks like now:

How my Environment variables are defined (in previous prior to Build x86 Image Step ):
echo "TAG_VERSION=12345" >> $GITHUB_ENV

There is no other place in whole repository where I would somehow mention to use this Environment variable; the mentioned definitions were enough for me.
Although my workflow was working well even without adding this env: property, adding it have resolved my issue with warning squiggles.

@davecaplinger I am having a related issue with steps.action-id.outputs.*  where I get "Context access might be invalid." if the * is being dynamically set by the github action (i.e action-id) based on user input.

If you're still experiencing this issue, try using a fromJSON(toJSON(env | vars | secrets).[...]
An example of how it'd look:
${{ fromJSON(toJSON(secrets)).GITHUB_TOKEN }}`

This method's not the best of solutions, though it works if your local repository is unable to fetch / verify whether the specified environment variable or secret is really present.
I still wouldn't rely on this, rather go for this method of trying to resolve it, as it worked for my latest repository.

If you're facing the "Context access might be invalid" warning for repository variables and secrets. The reason is our YAML file does not have access to production environment variables when we're adding it. The warning is simple and here is what worked for me.

Add the required secrets in your GitHub repository settings.
After adding secrets, perform a developer reload in VS Code.

This should make the warning disappear.

@maksims-terjohins - thanks, this solved the problem for me too.

+1 to @BertelBB and @larouxn for a way to ignore this warning for certain repos or secrets.
For context, we have a setup where secrets are managed by a separate team. Most users aren't able to access that part of the repo settings so there's no way to validate presence.
Being able to supply a list of presumed-available secrets via an in-repo settings file would probably do the trick in our case.

Hello everyone,
After signin in the Github Actions extensions, I alos had to tick the "Use-enterprise" option in the Github Action extension settings.
Repo belongs to an organization account.
Hope this will help someone.

You need to understand how this works. it fetches variables name from your GitHub account if you have created a variable there it will not give any warning.
- Context access might be invalid: PHPSESSID
- Contains the names and values of secrets that are available to a workflow run. For more information

If the warning persists even after adding the variable in GitHub, consider reloading VS Code.

Are you using MacOS? I had to restart VS Code with ⌘ + Q, and it went away after checking I did have the secrets correctly set in my repository settings.

@franccesco No, I'm using windows.

How do I surpress such warnings when reading secret values with env as the key?

@promid After adding the env, can you restart the VS code. (Developer:Reload Window)

@promid After adding the env, can you restart the VS code. (Developer:Reload Window)

Thanks for the reply, @SyedSibtainRazvi. I forgot to say that the envs are set by echo aaa=bbb >> $GITHUB_ENV.

Is there any way to disable this warning when using a dynamic environment?

Relogging into Actions and reloading window fixed the warning for me too!

Joining the club asking about this - I've got dynamic environment variables and VS Code extension won't shut up about me referencing them

You need to understand how this works. it fetches variables name from your GitHub account if you have created a variable there it will not give any warning.

We do have all variables "in our GitHub account", still getting VS Code warnings.

@jivea

After signin in the Github Actions extensions, I alos had to tick the "Use-enterprise" option in the Github Action extension settings. Repo belongs to an organization account. Hope this will help someone.

That just logs me out, without being able to log back in ("Sign in" button no longer works). I suspect that's because now the Github-enterprise Uri is missing. (We do run a GitHub organization, but not GitHub enterprise).

This is my experience:
After opened .yml file for the first time, VS Code Askme to install the Github Action Extension, i get access to my secrets and variables in the lateral panel but in config i get the same warn message, but i restarted the VS Code Programm and the warn message dissapeared

This worked for me after carefully adding GitHub Secrets, pushing/pulling my repo, and then pressing Ctrl + Shift + P and selecting "Developer: Reload Window.

I want to use the language server for GHA without having the sidebar enabled but apparently that is required in order to access the secrets.
I would rather have an option to disable messages like this as they are distracting and incorrect. They should appear only when the extension can access secrets and fails to find them, not when it does not have access to them.

Restarting the VSCode Window doesn't seem to be working here.

The reload trick does not seem to do it when in a devcontainer. Can't get rid of the warnings, very annoying.

Hello everyone,
After signin in the Github Actions extensions, I alos had to tick the "Use-enterprise" option in the Github Action extension settings. Repo belongs to an organization account. Hope this will help someone.

This did it for me. Thank you!!

Restarting worked for me.

Hello everyone,
After signin in the Github Actions extensions, I alos had to tick the "Use-enterprise" option in the Github Action extension settings. Repo belongs to an organization account. Hope this will help someone.

This worked for me!

Use-enterprise worked for a while until it stopped working. Downgrading to 0.25.7 got it working again.
Something changed between 0.25.7 and 0.25.8 that broke the extension.

Here is my workaround, I switched from SSH to HTTPS and the warning disappeared. I hope this helps.

@boonyarit-iamsaard thanks for the suggestion but I run into the same problem using HTTPS as I do for SSH auth.
@ssbarnea I don't understand why they are still upgrading it at this point. They broke it in 0.25.8 and just keep releasing broken versions.

I am using a mixed environment - Github Enterprise for our codebase and Github for external resources. When I select Use-Enterprise, external resources are shown to be unavailable and when I deselect this option, internal resources are unavailable

In the first screenshot, it shows invalid token warnings - A simple developer reload window + sign back into Github is enough to resolve these, but the Sonar action from github.com cannot be found
In the second screenshot, the secrets seem to be detected correctly (despite being in the Enterprise repo), but the action located in the enterprise git cannot be found (even though I am authenticated to both enterprise and public githubs, action resolution appears to be linked to the Use-Enterprise toggle, while secrets resolution seems to always work - albeit with some bugs)

If you installed the GitHub Actions extension, all you have to do is perform a Developer reload in VS code 'Developer: Reload Window' and the error should go away.

Not working

@jivea

After signin in the Github Actions extensions, I alos had to tick the "Use-enterprise" option in the Github Action extension settings. Repo belongs to an organization account. Hope this will help someone.

That just logs me out, without being able to log back in ("Sign in" button no longer works). I guess that's why you don't see the warnings - you're logged out. I suspect that's because now the Github-enterprise Uri is missing. (We do run a GitHub organization, but not GitHub enterprise).

This worked for me

I have two actions for test and production branch. What helped me:

git switch to test branch in vs code UI
Developer: Reload window
git switch to production branch in vs code UI
Developer: Reload window

Still an issue almost 2 year later what is the github team doing

This issue is also triggered by using a supported feature in which one passes an environment variable as the environment name for a reusable job eg:
jobs:
  reusable_job:
    name: Reusable job for ${{inputs.environment}}
    runs-on: ubuntu-latest
    environment:
      name: ${{inputs.environment}}

This causes all references to environment variables to display the warning message, even if they have been properly defined in their respective environments.

When are we getting a suppression setting, seeing this sight every single time while contributing to open source for the past several years has been to the point of irritation.

I had to sign in via the side using the GitHub Actions extension and do a full reload.
If you are on an enterprise repo, Enable Github-actions: Use-enterprise

This is completely unable to handle dynamic output parameters, such as the ones from aws-actions/amazon-ecr-login@v2.
I'd be grateful for an ability to completely turn this particular validation off. It degrades my experience significantly more than it does provide any value.

Still an issue almost 2 year later what is the github team doing

Serving the board of directors who serve the investors who staked all their money on AI


Add chassis cooling fault and drive fault metrics

Recently we started using ipmi_exporter and found out that there is no metrics for cooling fault and drive fault.
So we added some.
Link to the issue: https://github.com/prometheus-community/ipmi_exporter/issues/144

Gotta love the capitalization consistencies of FreeIPMI output :shrug:
Thanks a lot, this seems quite useful!


Segfault scraper::Html::parse_fragment

I encountered a segmentation fault with the parse_fragment function.
Code:
let html = page.get_html();
println!("Scraping page");
let document = scraper::Html::parse_fragment(&html);
println!("Document scraped");

Result:
Scraping page
Segmentation fault (core dumped)

Sometimes I also get:
Scraping page
double free or corruption (fasttop)
Aborted (core dumped)

I ran the program and captured the corresponding HTML. The segmentation fault occurs on documents that sometimes work. .

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

The above link appears to be malware, don't click it.
Can you share the minimal html that causes the issue? Delete elements and rerun it several times for each, undoing the change if it doesn't crash.

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."

This contains the Lumma Stealer spyware, report: https://app.any.run/tasks/abb4419a-a8cb-4707-946d-e73a9d3561bb


Add New Web UI and Desktop Mode

All New WebUI
This PR brings in the new design for the new WebUI.

The new redesign presents a simple and easy to use GUI for anyone. The main options that are required for prompt generation are readily available with the more detailed settings presented to you as advanced options.
The New WebUI currently supports text to image generation, image to image generation, image upscaling, face restoration, variations, progress images and seamless tiling with more being worked on.
Currently only the Text to Image tab is populated. However you will find other tabs in the UI. These tabs will be released in future patches. These tabs will provide dedicated UI's for image to image, inpainting, outpainting , node workflow and post processing.
Usage
New dream.py arguments.

--web - Launches WebUI on a local server
--host - To set the host of your server
--port - To set the port of your server
--cors - To white list your server and port if you are getting CORS errors

Example usage:
dream.py <other arguments> --web

Desktop Mode
You can now run the WebUI as a desktop app on your computer. This will launch using your systems browser as a desktop window instead of inside a regular browser.
To use desktop mode, you will need to install pip install flaskwebgui
Usage
dream.py <other_arguments> --gui

Notes

If you have tested previous version of the WebUI, it is recommend you delete your LocalStorage. Sometimes this might cause some issues with persistence. You just need to do this once. You can do this manually by deleting it from the developer tools of your browser or from Settings > Reset Web UI.

Rebased #879
Co-Authored-By: psychedelicious<EMAIL_ADDRESS>

It's looking good. One thing I noticed is that if you are using an image as an init image and then delete it from the gallery, the GUI will fail to generate until you push the trash can icon on the init image. Inactivating "Init Image" doesn't do it.

It's looking good. One thing I noticed is that if you are using an image as an init image and then delete it from the gallery, the GUI will fail to generate until you push the trash can icon on the init image. Inactivating "Init Image" doesn't do it.

Oh we forgot to fix that. We'll fix it in one of the next patches.
@psychedelicious

I inadvertently tried to generate a 2048xx2048 image. It took a long time for the cancel button to take effect!

I inadvertently tried to generate a 2048xx2048 image. It took a long time for the cancel button to take effect!

Yes. That's a threading issue. Unfortunately there's no easy bypass for this. I'm looking into asynchronous solutions but don't have one right now. If we fix this, then it'll also be in a future patch.

Really nice work. I noticed a few minor glitches, noted in the comments, but I'm going to go ahead and merge into development.

Thank you. I'm nearly done with the img2img tab too. I should have a PR for it in a day or two. Maybe faster if I can find time.


Accept file types doesn't restrict type

Hi,
I have followed your example but when I upload a file I want to restrict different type, but it doesn't work.
Here my js:
 $('#fileupload').fileupload({
        dataType: 'json',
        acceptFileTypes: /(.|\/)(gif|jpe?g|png)$/i,
        url: 'jqueryUploadFile/php/index.php,
        done: function (e, data) {

             }
    });

Have an idea?
Thanks
Sam

It seemed you forget type 'option'. Try this:
$('#fileupload').fileupload('option', {
dataType: 'json',
acceptFileTypes: /(.|/)(gif|jpe?g|png)$/i,
url: 'jqueryUploadFile/php/index.php,
done: function (e, data) {
         }
});

It doesn't work...


Use CDN in API calls

As mentioned in #6, the API should probably take advantage of CDN functionality (e.g., caching) rather than pulling directly from raw.githubusercontent.com.
jsDelivr seems to offer free, drop-in solution. Example below:
https://cdn.jsdelivr.net/gh/ishaberry/Covid19Canada/vaccine_administration_cumulative.csv

There is a file size limit of 20 mb but this will only impact cases.csv, which requires rethinking/a re-write anyway.

The only data not being delivered by jsDelivr is the individual-level data, which is temporarily disabled per (#5).
It may be useful to have a separate repository/separate directory for individual-level data split by day? This would make the files small and convenient to deliver. It would also avoid the issue of GitHub file size limits.

The only data not being delivered by jsDelivr is the individual-level data, which is temporarily disabled per (#5).
It may be useful to have a separate repository/separate directory for individual-level data split by day? This would make the files small and convenient to deliver. It would also avoid the issue of GitHub file size limits.

I had a couple of thoughts here.

do you know how often jsdelivr updates its latest tree? Surely with all of github to mirror there must be a substantial delay?
it would be pretty straightforward to add the data repo as a git module of this one and draw the data locally, using a cron job on your heroku instance to git-pull every 20 minutes. I don't know much about computation and data limits on heroku  but it doesn't seem that would be especially demanding.

Let me know if the latter sounds good and I can prepare a PR

I had a couple of thoughts here.

do you know how often jsdelivr updates its latest tree? Surely with all of github to mirror there must be a substantial delay?
it would be pretty straightforward to add the data repo as a git module of this one and draw the data locally, using a cron job on your heroku instance to git-pull every 20 minutes. I don't know much about computation and data limits on heroku  but it doesn't seem that would be especially demanding.

Let me know if the latter sounds good and I can prepare a PR

@titaniumbones You're right that cached old versions of the data being served could be an issue.
Thanks for your assistance. This is all new to me, so I'm still figuring things out as I go.
Git pull (presumably shallow since all we need is the latest version of every file) could be a good solution. I know the contents of the repo compress extremely well. A pull request would be appreciated---I'll give it a test afterwards.

@titaniumbones You're right that cached old versions of the data being served could be an issue.
Thanks for your assistance. This is all new to me, so I'm still figuring things out as I go.
Git pull (presumably shallow since all we need is the latest version of every file) could be a good solution. I know the contents of the repo compress extremely well. A pull request would be appreciated---I'll give it a test afterwards.

@titaniumbones You were correct that jsDelivr was not the right solution due to the unacceptable delay in returning new data. I've reverted the commit.

@titaniumbones You were correct that jsDelivr was not the right solution due to the unacceptable delay in returning new data. I've reverted the commit.

It's probably a mistake to read all files automatically into memory automatically and as the data module currently does. Instead, it should read into memory only what is necessary within the scope of what is requested for each response.

It's probably a mistake to read all files automatically into memory automatically and as the data module currently does. Instead, it should read into memory only what is necessary within the scope of what is requested for each response.

Data module has been rewritten and deployed. All that remains to confirm that the nightly data update goes smoothly.

Data module has been rewritten and deployed. All that remains to confirm that the nightly data update goes smoothly.

Confirmed working.

Confirmed working.


Variable scoping error for named exports when doing minimal babel transpilation

Our goal was to use babels transpilation only for the import/export statements and let the browser handle features such as classes /  async natively.
Therefore we used the following options:
var defaultBabelOptions = {
  modularRuntime: true,
  sourceMaps: true,
  es2015: false,
  stage3: false,
  stage2: false,
  stage1: false,
  compact: false,
  comments: true
};

This works reasonably well, but we found the following issue. The class Foo is not in the scope the exported function greet.
export class Foo {
  static greet() {
    return "Hi"
  }
}
export function greet() {
  return Foo.greet()
}

Because it gets transpiled to:
(function(System, SystemJS) {System.register([], function (_export, _context) {
  "use strict";

  function greet() {
    return Foo.greet();
  }

  _export("greet", greet);

  return {
    setters: [],
    execute: function () {
      class Foo {
        static greet() {
          return "Hi";
        }
      }

      _export("Foo", Foo);
    }
  };
});
})

This will result in a runtime error when calling greet.
Uncaught (in promise) ReferenceError: Foo is not defined
    at ModuleNamespace.greet (tanspilationbug.js:7)
    at System.import.then.m (eval at resolve (juicy-ace-editor.js!transpiled:NaN), <anonymous>:1:55)

Thanks for posting. This is a known bug in the Babel system transformer unfortunately! See https://github.com/babel/babel/issues/4701.


manifests: add support for kustomization

Use kustomize in order to deploy sample-device-plugin.
This will allow an easier deployment (all in one keystroke) and more flexible device configuration which is going to be added in a following commit.
We left the old configuration for now, but it can be removed if we decide that we're happy with this change.

/hold

We cannot inherit files that are not present in or below the overlay. I am getting the following error:
$ kubectl apply -k deployment/overlays/default
error: loading KV pairs: file sources: [../devicepluginA/example_com_deviceA.yaml]: security; file '/home/swsehgal/go/src/github.com/k8stopologyawareschedwg/sample-device-plugin/deployment/overlays/devicepluginA/example_com_deviceA.yaml' is not in or below '/home/swsehgal/go/src/github.com/k8stopologyawareschedwg/sample-device-plugin/deployment/overlays/default'

I guess the best way to overcome this is to provide the configs files within the overlay itself. I believe it is a reasonable approach given that a specific overlay leads to a specific deployment  .
We also need to provide the specific base directories explicitly in case of default overlay:

-resources:
-  - ../../base
+bases:
+- ../../base/devicepluginA-ds
+- ../../base/devicepluginB-ds
+- ../../base/devicepluginC-ds

 configMapGenerator:
   - name: device-a-configmap
     files:
-      - ../devicepluginA/example_com_deviceA.yaml
+      - example_com_deviceA.yaml
   - name: device-b-configmap
     files:
-      - ../devicepluginB/example_com_deviceB.yaml
+      - example_com_deviceB.yaml
   - name: device-c-configmap
     files:
-      - ../devicepluginC/example_com_deviceC.yaml
+      - example_com_deviceC.yaml

@swatisehgal let's merge the current PR and create a separate one for could-infra-vendor-specific environments


Fixing bug initializing the ManufacturerDataMask

Bytes of the DataMask are initialised with 0b00000001 instead of
0b11111111, hence only the least significant bit of the DataMask and the
result data are being compared. Effectively the current FilterMask is just an
even/odd filter for the selected bytes.
Also added the iBeacon type identifier (0x02) as well as length byte
(0x21) to the filter mask. I understand this is done in the
onScanResult method @ScannerScanCallback, however, as type byte and
length are fixed this will reduce unnecessary callbacks.

Thanks for sharing this! I'll review and merge this in our upcoming release.


Unexpected "problems" reported for Django model attributes.

Environment data

VS Code version: 1.46
Extension version (available under the Extensions sidebar): v2020.5.86806
OS and version: Windows 10 Pro
Python version (& distribution if applicable, e.g. Anaconda): 3.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): XXX
Value of the python.languageServer setting: XXX

Expected behavior
I am using Django and when I use my models in my views it shows some errors that I think are not valid. Actually it says that this model has no objects member but the code works fine but the editor shows it as an error. I can even share the screenshots with you.
if you want further information I can give you that. Other than that the extension is working correctly and this error doesn't show in PyCharm.

@fahadmalik-creator, thanks for letting us know about this.  Do you have this problem when using the language server?  Make sure the following is in your settings.json:
{
    "python.jediEnabled": false,
    "python.langaugeServer": "Microsoft"
}

@fahadmalik-creator, thanks for letting us know about this. Do you have this problem when using the language server? Make sure the following is in your settings.json:
{
    "python.jediEnabled": false,
    "python.langaugeServer": "Microsoft"
}

I have checked but it has not removed the error.

@fahadmalik-creator, please provide the content of the "Python" output panel and the "Python Language Server" output panel.

@fahadmalik-creator, please provide the content of the "Python" output panel and the "Python Language Server" output panel.

it doesn't show error in output panel it shows error only in the editor and here is a screenshot of my code but my code runs perfectly fine.

Understood.  The content of the "Python" and "Python Language Server" output panels will still be helpful though.

Do You want this content of the python server?

if this is not please clarify me what exactly i have to give.

@fahadmalik-creator, sorry for any confusion.  In the "View" menu click on "Output".  Then, in the "OUTPUT" panel, click on the pull-down menu on the right (it probably defaults to "Tasks").  In that menu click on "Python".  Paste the content (text, not image) here.  Then do the same for "Python Language Server".  Thanks.

@fahadmalik-creator, sorry for any confusion. In the "View" menu click on "Output". Then, in the "OUTPUT" panel, click on the pull-down menu on the right (it probably defaults to "Tasks"). In that menu click on "Python". Paste the content (text, not image) here. Then do the same for "Python Language Server". Thanks.

Here You Go...
User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'DebugAdapterFactory - experiment'
User belongs to experiment group 'PtvsdWheels37 - experiment'
User belongs to experiment group 'UseTerminalToGetActivatedEnvVars - control'
User belongs to experiment group 'LocalZMQKernel - control'
User belongs to experiment group 'CollectLSRequestTiming - control'
User belongs to experiment group 'CollectNodeLSRequestTiming - experiment'
User belongs to experiment group 'EnableIPyWidgets - experiment'
User belongs to experiment group 'RunByLine - control'
User belongs to experiment group 'CustomEditorSupport - control'

conda --version
pyenv root
conda info --json
python3.7 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python3.6 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python3 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python2 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -3.7 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -3.6 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -3 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -2 c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
python c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import jupyter"
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import jupyter"
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import notebook"
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import notebook"
Starting Jedi Python language engine.
Python interpreter path: ~\AppData\Local\Programs\Python\Python38\python.exe
conda --version
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.prefix)"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.prefix)"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py site --user-site
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py site --user-site
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\urls.py
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\urls.py
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py jupyter kernelspec --version
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py jupyter kernelspec --version
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\completion.py
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\completion.py
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\views.py
cwd: d:\Famzaa
~\AppData\Local\Programs\Python\Python38\python.exe c:\Users\Dell.vscode\extensions\ms-python.python-2020.6.89148\pythonFiles\pyvsc-run-isolated.py pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\views.py
cwd: d:\Famzaa
##########Linting Output - pylint##########

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
##########Linting Output - pylint##########
************* Module home.views
19,15,error,no-member:Class 'newsletterSubscription' has no 'objects' member
23,13,error,no-member:Class 'newsletterSubscription' has no 'objects' member
141,15,error,no-member:Class 'newsletterSubscription' has no 'objects' member
145,13,error,no-member:Class 'newsletterSubscription' has no 'objects' member
169,15,error,no-member:Class 'Comming' has no 'objects' member
173,13,error,no-member:Class 'Comming' has no 'objects' member
211,15,error,no-member:Class 'Blog' has no 'objects' member
214,15,error,no-member:Class 'Blog' has no 'objects' member

Your code has been rated at 6.97/10 (previous run: 6.97/10, +0.00)

The following line from the log indicates that you are using Jedi instead of the Language Server:

Starting Jedi Python language engine.

The log also indicates that you have pylint set up and it is what is reporting the "problems".  So using the language server would not make a difference.
The question is, why is pylint complaining about your project?  What happens when you run pylint manually?  Use the following command (which is what the extension runs):
~\AppData\Local\Programs\Python\Python38\python.exe -m pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text d:\Famzaa\home\views.py

Also, please provide your settings (d:\Famzaa\.vscode\settings.json).
Also, how is your workspace files structured?  Is there a link to a repo you could provide?

This is my settings.json file content...
{
"python.pythonPath": "C:\Users\Dell\AppData\Local\Programs\Python\Python36\python.exe"
}
yes, there is a repository but it is personal so that is why I can't give link to you.

Is this issue still happening with the latest version of the extension?

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


API documentation	link Broken

"Node.js API reference documentation" => http://azure.github.io/azure-documentdb-node/DocumentClient.html
this link is broken.
maybe the following link is good.
https://docs.microsoft.com/en-us/javascript/api/documentdb/?view=azure-node-latest

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c4a8032-6aa3-4833-0fb4-02312a0b534f
Version Independent ID: eb89b624-ffcc-9d27-27de-6b514ae489d3
Content: Azure Cosmos DB: SQL Node.js API, SDK & resources
Content Source: articles/cosmos-db/sql-api-sdk-node.md
Service: cosmos-db
GitHub Login: @rnagpal
Microsoft Alias: rnagpal

@Mike-Ubezzi-MSFT can you assign this issue to me?

@danny8002 Thanks for pointing, this issue is now fixed. We will proceed to close it.
#please-close


   C o n t a c t   y o u r   p r o d u c t   v e n d o r .
<IP_ADDRESS>

NOTE: CHEF CLIENT BUGS ONLY
This issue tracker is for the code contained within this repo -- chef-client, base knife functionality (not
plugins), chef-apply, chef-solo, chef-client -z, etc.

Server issues
ChefDK issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

shouldn't this issue get cut against knife-windows?

@lamont-granquist Whoops, wrong repo!  Closing this after filing one here: https://github.com/chef/knife-windows/issues/382


.NET framework version not match with v4.8 but i already installed 4.8 runtime

Hello, i was trying to run the program in the portable version but everytime that i try to open it it says
.NET framework version does not match with v4.8! Debug info: 4.7.2
Al the other apps detect 4.8 fine. I tried reinstalling windows and use the setup version, uninstalling and installing, Cleaning Appdata, I tried to modify Moto_Boot_Logo_Maker.exe.conf to set a lower version and Using a hex editor to edit the Binary.exe
Im currently runing windows 10 ltsb, i tried with ltsc, 7 and wine too

i fixed by edit .net framework ver of the exe file with dns spy to another version

Hey! sorry, im not maintaining anymore this tool, and the code is a mess lol 😬


Bugfix/Unwanted GPU Execution

fixes LocalCluster initialization
task_handler now uses Client specifications (e.g., GPU usage flag) to determine which method to use as default

@SerodioJ could you regenerate the commit messages with signoff? I think you just need to pass -s and configure you name and email.

LGTM :-)


Method whenLoaded() return an empty array

Laravel 8.12,
PHP 8.0.0,
MySQL 5.7
Description:
{
"id": 1,
"title": "Web Dev",
"level": "senior",
"category": {
"id": 1,
"name": "IT"
},
"locations": []
},
Steps To Reproduce:
//Job Model:
public function locations()
    {
        return $this->belongsToMany(Location::class);
    }
 //Job Resource
 public function toArray($request)
    {
        return [
            'id' => $this->id,
            'title' => $this->title,
            'level' => $this->level,
            'category' => new CategoryResource($this->category),
            'locations' => LocationResource::collection($this->whenLoaded('locations')),
          ];
    }

    //Response
    $jobs = Job::with('locations')->get();
    return JobResource::collection($jobs);

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

It's all nice, but no one has an answer why the method doesn't work :)


Undo Redo GUI not highlighted when command should be enabled

When using GUI and mouse to undo redo, command is not available for use even tho on CLI it works (undo/redo)

Is a different command tho, one is for undo the copy and paste, one is for undo previous command

Out of scope.


Add libusb driver

Add a USBTMC driver (usbtmc/driver/libusb) for the github.com/gotmc/libusb Go-based libusb driver.

Closed in c1c452b


New version: Mozilla.Firefox.DeveloperEdition.kn version 132.0 (132.0b4)

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Verify by proxy: https://github.com/microsoft/winget-pkgs/pull/179431#issuecomment-2400690391


fix: do not use ValidationInterface

Description
Fixes #6224
BaseModel uses the 3rd param of $this->validation->run($data, null, $this->DBGroup).
So it depends on Validation, not ValidationInterface.
Ref: https://github.com/codeigniter4/CodeIgniter4/pull/5909#issuecomment-1179518692
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Let's see where the big PR takes this conversation. I'm fine with this one following from that - I do think that this is pretty likely to break some projects and libraries since Model constructors are likely to be extended.

If we can change the ValidationInterface, we have an option to change it instead.

You know that's not a bad idea. If I had to guess I would say there are probably more developers extending Model::__construct() than making their own Validation driver (since the driver can be "extended" via rules already).

there are probably more developers extending Model::__construct() than making their own Validation driver

I agree. I guess so.
It seems changing ValidationInterface makes less apps break.

I sent another PR #6253

#6253 was merged.


Suggestion: Inline-editing

I couldn't find any other mention of this, so I just thought I'd create an issue to track this....
Is inline-editing something that could be added in a later version? I imagine a lot of people would find it useful, especially with the recently announced official support in Meteor, inline-editing, reactive tables would be very cool!

Hi! Thanks for the suggestion. Unfortunately, this feature is outside of the scope of the table - you must provide the table with data and components, and how you manage that data is up to you! The table otherwise takes care of virtualizing the rows to maintain high performance scrolling.
This decision keeps the table flexible enough to allow you to choose whatever you'd like to go in the cell, so you can adjust it to your use case.
If you would like inline-editing, you can look into creating a component that does that by using cellRenderer and cellDataGetter.

Thanks for the quick response @ehzhang! While I think it's a shame that it's not something that would be officially supported, at least you have given us enough tools to write something to do it ourselves.

You're welcome :)
I'll be closing this issue now, but if you feel the need you can re-open it. Thanks!

@ehzhang Would I be able to use the cellRenderer and/or cellDataGetter to attach X-Editable (http://vitalets.github.io/x-editable/) to the contents such that when the data changed the X-Editable was reinitialised or whatever? Sorry if it's a dumb question, I'm only looking into React for the first time, so I'm not sure how it all ties together at the moment.

@Siyfion sorry for not seeing this sooner! Looking through the link you provided, I don't anticipate too much issue in terms of rendering if you used the inline version, but you'd probably have trouble with the pop-over. Also, because of the way that cells are routinely destroyed/rerendered, it may actually be a bit tricky to actually initialize each row with jQuery.

Hmm... as I thought! Hence why I was asking whether it was something you guys might think about supporting :tongue:

@ehzhang Perhaps an example could be added to the example list with a cell that has a simple numeric input, with two-way updates/bindings, just to show people how it could be done?


$ionicView.beforeEnter is not fired

after the update from
ionic 1.3.0 to 1.3.1
the $ionicView.beforeEnter is not fired any more as before
I have this controller:
class MyCtrl {
 static $inject = [
    "$scope"
  ];
  constructor(
    private $scope
  ) {
    $scope.$on("$ionicView.beforeEnter", (event, data) => {
      this.activate();
    });
  }
}

in version 1.3.0 the activate() method is called as expected
in version 1.3.1 the activate() method is not called
the fix is to roll back to version 1.3.0

Hello! Thanks for opening an issue with us! Would you mind making a plunker demonstrating this issue please? That would be a huge help!

I have this problem too. See plunker that reproduces: http://plnkr.co/edit/IBFQTuvARTBC9bExU3uq?p=info
(Change from ionic 1.3.1 to 1.3.0 to see working version)
Could it be something with the routing like in https://forum.ionicframework.com/t/ionicview-events-not-firing/19825/14 ?

In my testing it appears this was broken in commit d63733350b73c0084f99fe285dda96f0204b2cd7
Specifically the following line returns null (thus it then has no scope to emit events to)
var enteringScope = getScopeForElement(enteringEle, enteringData);

From further testing it appears it returns null because inside of getScopeForElement
    if ( attributeValue !== "true" ) {
      // it's not an abstract view, so make sure the element
      // matches the state.  Due to abstract view weirdness,
      // sometimes it doesn't. If it doesn't, don't dispatch events
      // so leave the scope undefined
      if ( stateValue === stateData.stateName ) {
        return angular.element(element).scope();
      }
      return null;
    }

The condition if ( stateValue === stateData.stateName ) is false because stateValue is null. (At least in my particular case)
In case anybody is interested (and/or needs these events to fire like myself) for now I've patched it simply by merging the original with the new (inside of the emit function in "$ionicViewSwitcher"), i.e.
var enteringScope = getScopeForElement(enteringEle, enteringData) || enteringEle.scope();

I also have this problem
$ionicView.enter is not fired
when I use code by @darthdie ,It work.tks.

Hi all,
I'll take a look at this.
Thanks,
Dan

Hi @asmund1,
When I use your Plunkr, I do see the issue.  However, it is because your template is not a container.  That's an edge case, so I'm not going to make a change right now to support that.  If you change your template to the following, it works correctly.
<ion-view>

View one

</ion-view>

@rxnh8255, @darthdie, Please help me out with what is unique with your apps.  Can you make a plunkr or a codepen demonstrating the issue?  I cannot recreate it presently.  Please let me know.  Thanks for the details @darthdie.  Why is your stateValue null?
Please let me know and I'll get it resolved.
Thanks,
Dan

@danbucholtz
http://plnkr.co/edit/dOXTj7
Look this.
When I add this <button ng-click="add()" class="button"></button> at the end.It not works
When I delete the button,it works good.

http://plnkr.co/edit/dOXTj7?p=preview

Hi @rxnh8255,
Well, I understand why it doesn't work with the button.
Due to some challenges with ui-router, we need to look-up the element to get the correct scope to dispatch the life cycle events.  Since your template is not inside of a container like

 or <ion-view></ion-view>, we have more than one child, which means the logic does not execute correctly.
See  if (containerEle.children.length === 1) { below.
createViewEle: function(viewLocals) {
      var containerEle = $document[0].createElement('div');
      if (viewLocals && viewLocals.$template) {
        containerEle.innerHTML = viewLocals.$template;
        if (containerEle.children.length === 1) {
          containerEle.children[0].classList.add('pane');
          if ( viewLocals.$$state && viewLocals.$$state.self && viewLocals.$$state.self['abstract'] ) {
            angular.element(containerEle.children[0]).attr("abstract", "true");
          }
          else {
            if ( viewLocals.$$state && viewLocals.$$state.self ) {
              angular.element(containerEle.children[0]).attr("state", viewLocals.$$state.self.name);
            }

          }
          return jqLite(containerEle.children[0]);
        }
      }
      containerEle.className = "pane";
      return jqLite(containerEle);
    }

Please wrap your template in an ion-view or a div and see if that fixes your issue.  I will discuss with the team members what we want to do with this code, whether we change it, or just document it better.  Typically, you want a template to be one container, though.  That is the best practice.
Thanks for your help!
Thanks,
Dan

@danbucholtz is right, ensuring there is only 1 root element in your template fixes this issue.
I had this issue occur when I had the following:
<ion view>
  stuff here
</ion-view>

Moving the


[0.8.4] SVG load of Hidden Text objects causes pop-up

I have an SVG file which has text objects which are hidden - because I duplicated them and converted the duplicates to paths (keeping the original text objects in case I want to edit them and reconvert to paths).
However despite all Text objects being hidden, when I load the file I get:

In Preferences/General I have:

IMO this warning should only be shown if there are visible features and hidden features should be ignored.

Hm. That does seems to be a bit less than useful. I see why it would do that though. I think if rather than hidden you set them to disabled it might not load them at all. In theory it removes it completely from the render tree which has the result of not parsing them. Svgelements by default will access hidden but won't even touch disabled or whatever. Though I think a flag to let you do that got added a year or so back.
Doesn't really fix this issue. I guess we'd just check for the post-process and not perform it on hidden objects. I don't see a clever way other than checking.

I am getting this pop-up with "clipping" as the reason when loading a design which has no clip paths.

I just got a similar warning about "clipping" and "mask" for a file which doesn't use clipping or masking.
I suspect that there are some clip or mask defs (in the defs xmls section) even though these are not actually used.

The difference between hidden and disabled is generally that the render tree isn't invoked for the latter, which actually means it won't show up for svgelements.
I assume this is loading and running through inkscape. I'll have to look at that some more. I'm not really sure when that kicks on and the rest of the code needs to be checked. It worked and was off by default so I didn't check much beyond that since it was somewhat defacto harmless.
I was pretty sure it checked for unsupported elements or something during loading but I'll add it to the list of things to check after I get 0.9.x more fully working

I am not sure how these checks for unsupported SVG elements are done, but I suspect that they are done when such things are read rather than when such things are used.
Because I know what MK can and cannot handle, I generally click the Load Original button and the file loads fine, so I do NOT load it through Inkscape using the Convert button. My point is not that there is a bug, but rather that this warning pop-up has false positives.

Okay, the inkscape.py routine in extras, registers a check_for_features routine as a preprocessor./.,svg in the kernel. This is always checked during the elements.py/load() routine. And merely executes, taking the pathname and returning potentially a new pathname. This API seems pretty solid.
So the important routine is just the check_for_features, https://github.com/meerk40t/meerk40t/blob/acd0a39a03cd97b9790e5c7667823d17072fe46f/meerk40t/extra/inkscape.py#L384
The routine to check for these features isn't an XML parser. It's actually just searching for the words "<text", "<clipath", "<mask" or "<lineargradient"/"<radialgradient" anywhere in the svg.
            features = {
                "text": [False, ("<text",), METHOD_CONVERT_TO_OBJECT],
                "clipping": [False, ("<clippath",), METHOD_CONVERT_TO_PNG],
                "mask": [False, ("<mask",), METHOD_CONVERT_TO_PNG],
                "gradient": [
                    False,
                    ("<lineargradient", "<radialgradient"),
                    METHOD_CONVERT_TO_PNG,
                ],
                "pattern": [False, ("<pattern",), METHOD_CONVERT_TO_PNG],
            }

            with open(source, mode="r", encoding="utf8", errors="surrogateescape") as f:
                while True:
                    line = f.readline().lower()
                    if not line:
                        break
                    for feat, entry in features.items():
                        for candidate in entry[1]:
                            if candidate in line:
                                entry[0] = True
                                if entry[2] > needs_conversion:
                                    needs_conversion = entry[2]

If it finds that it sets the given method, and performs the given call.
So your file apparently contains the word "<text" or "<clippath" or "<mask" somewhere in there. That seems about right. And we should, rather than parse the file line by line, parse it tag by tag, and turn on if we detect these otherwise disallowed functions and calls them.
So the reason the hidden stuff will still cause the pop-up is because it searched the file and found the relevant tags. This would actually still trigger regardless how it's processed. Even if you set it to disabled this would process since there is no valid tag here.

To avoid this issue, we'd basically need to parse the svg before we parse the svg. This seems prohibitively hard for a supplemental feature.

It seems to me that there might also be a logic issue in this and some usability issues:

LOGIC: If the file contains both "text" and one of ("clipping", "mask", "gradient", "pattern") then you need to do CONVERT_TO_PNG (which is bruter than CONVERT_TO_OBJECT), but whatever comes last in the file will be the single conversion done.
Note 1: The Inkscape action is to convert the TEXT OBJECT to a path - so the option should probably be named CONVERT_TEXT_TO_PATH.
Note 2: The pythonesque approach would be to have separate methods / functions for convert_text_to_path and convert_to_png and to assign the method / function object to a variable and then later call that method.

USABILITY: Convert (only) text objects to paths is relatively benign to the burn because they will remain as paths with fill which will still be classified in the same raster operation(s) whereas converting the entire design to a PNG potentially screws the entire burn because the whole thing will be rastered including everything that would previously have been vector burned (and it will be in an Image operation rather than the existing Raster operation). IMO the difference between these is so great that they need to be presented to the user differently - and indeed have more preference options to e,g, automatically convert text objects to paths but not automatically convert the entire design to PNG.

I am assuming that there is not an Inkscape option to convert only elements with clippaths, masks, gradients or patterns to PNGs? whilst leaving everything else as vectors and this is why you have to convert the entire design? Also, even if you can convert only these elements to images, the clippaths etc. can be applied to things that are vectors rather than images, and so the above comment about it being a change with massive implications would still hold true.

That is what parsing is. A simple search is one thing, but when you're tracking hidden/disabled and tracking parentage of hidden/disabled -- that's literally parsing.
Regardless, Tat marked it accepted. I agree--those are good points you make.
I would assume that if we did parse the svg, then we could selectively send certain elements to inkscape to be converted.
So the question is -- can we delay this check until the svg is parsed?

Yeah, literally to figure out whether a branch would have a visible element it would require parsing the data. Currently the parse looks for tags <clippath et al, by a simple line-by-line check. To see where it falls in the tree with the given property would require that we do basically a normal svg parse.  We could do that with svgelements.
It's marked as accepted since it's at least clear what's going on, and the original issue is markedly true.
The code is set in a pre-processor, so really it would need double parsing or the change the api to keep the objects for the initial parse, or call inkscape and replace them with a new parse after that.
But this seems harder, it seems like we'd be better off just parsing it twice anyway.
This is a edge condition issue. I guess we could also just add in a custom xml parser and parse it again, though it wouldn't detect things like if you have a Pattern in a <defs> but then never use that def in a <use> block it would fail. The only real surefire way would be to parse it, then is if we find a tag that we're not allowed (though <clipPath is actually somewhat supported, it's not just supported in meerk40t).
To avoid parsing it twice, we'd need to change the API to not do a preprocessor, but rather a sort of post-processor that is smarter as to the type of file we're parsing. It needs to parse the file, get all the tags. Then we check through all the tags we have looking for these particular non-supported one, and then abort the parse in progress (or after we've checked everything and know we need some changing) and parse it again. So most would get 1 parse and a review. And some would get 1 parse, a review, and another parse.
This seems like its rewriting the feature to fix a rather edge condition defect, that it detected the tag but didn't check whether that tag was properly used.  And the current form of the feature is really nice. It's always done for any preprocessor script, and completely agnostic as to what type of file is being read.


Prime Factor [Python]

This issue is about Prime Factor.

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[ ] Assign this issue to me (I want to work on this).

[ ] I ensure that I am not already assigned to 2 or more issues.

[ ] I will send my PR only after I'm assigned to this issue by any maintainer.
[ ] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

-[x] Assign this issue to me.


Run unit tests for optional apps, if they exist

This PR modifies the unit test runner so that it runs unit tests for satellite apps, if they are present.
It modifies the default Travis config to install public satellite apps (from requirements/optional-public.txt) and run unit tests against them.
Changes

Default test runner in cfgov.test.TestDataTestRunner now adds optional app unit tests, if those apps are present locally (both public and private).
Travis default configuration now installs public optional apps as part of its testing.

Testing

Install optional apps (pip install -r requirements/optional-public.txt) then run tox -e optional or tox -e fast-optional and verify that extra tests are being run.
Confirm that default testing still works properly, e.g. tox -e fast v1.

Review

@cfpb/cfgov-backends

Notes

Adding optional app testing increases the number of unit tests from 513 (cfgov-refresh only) to 769 (with optional apps). I see 18 failures locally when I run with all optional apps.

Todos

Fix optional apps so that their tests all pass!

Checklist

[X] Changes are limited to a single goal (no scope creep)
[X] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[X] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[X] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

On second though, I've reverted (4908add) the change to the Travis config). It probably makes more sense to first add the capability to easily run tests in the satellite apps, then work on getting them all to pass, and only then adding them to the Travis build. That way this PR can be merged in, making it easier to test satellite apps while we work to fix them.

:100: this is beautiful.
I get same results.
This slightly more explicit tox config doesn't try to install test.txt twice:
[testenv:optional]
deps=
    -r{toxinidir}/requirements/optional-public.txt
    -r{toxinidir}/requirements/optional-private.txt
    {[testenv]deps}

@higs4281 thanks; I went back and forth as to whether to do it that way or not (since it doesn't matter if you install test.txt twice). Thinking about it some more, I agree that your way is more clear. Updated in 0706270.


MOON-223: Fix Dropdown Menu positioning in modals

JIRA

https://jira.jahia.org/browse/MOON-223
Description

Adds the prop position to the Menu which can be absolute or fixed (it's `fixed by default). This fixes the issue where Dropdown Menus were incorrectly placed in modals as it allows the Menu to be optionally absolutely positioned against a relative parent and, therefore, not affected by ancestors that may have transform, filter, or perspective properties.

Modifies the usePositioning custom hook to support the new prop

Updates the Dropdown component to have position: relative and to specify position="absolute" to the Menu component within it

What do you think about only using usePositioning when we position the menu with the screen (use as a contextual menu)?
When we use it inside another component, we can position the menu relatively to its parent and set its position in CSS.
To avoid a wrong position as a contextual menu, we have to specify to insert the menu at the root level. But we have to know how to manage the position's nested contextual menus position.

I think we still need to use the usePositioning hook in either case because of the transforms that can be specified by anchorElOrigin and transformElOrigin.


Podcast Support

Make the shelf download and play podcasts

Anyone interested in giving this a try before I create a new release?


Export to Android SDK 24 result in error for gradle task dexBuilderDebug.

Godot version
v4.1.2.stable.official [399c9dc39]
System information
Windows 10
Issue description
NOTE: Exporting to Android SDK 33 works fine.
Exporting to Android SDK 24 throws the following error in the "Building Android Project(gradle)" window:
...
CIRCULAR REFERENCE: com.android.tools.r8.internal.nc: Unsupported class file version: 62
...
What went wrong:
Execution failed for task ':dexBuilderDebug'.
There was a failure while executing work items
A failure occurred while executing com.android.build.gradle.internal.dexing.DexWorkAction
Failed to process: E:\projects\Godot4\APKtest\android\build\build\intermediates\javac\debug\classes

and the following error is displayed in the Godot Output panel:
editor/export/editor_export_platform.h:178 - Export: Building of Android project failed, check output for the error. Alternatively visit docs.godotengine.org for Android build documentation.

System Details:
Godot v4.1.2.stable - Windows 10.0.19045 - Vulkan (Compatibility) - Quadro M3000M () - Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 Threads)

E:\projects\Godot4\APKtest\android\build>echo %JAVA_HOME%
C:\jdk-18
...

gradlew --version

------------------------------------------------------------
Gradle 7.4.2
------------------------------------------------------------

Build time:   2022-03-31 15:25:29 UTC
Revision:     540473b8118064efcc264694cbcaa4b677f61041

Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          18 (Oracle Corporation 18+36-2087)
OS:           Windows 10 10.0 amd64

Steps to reproduce

Open Project -> Export.
Add an Android preset.
Open the "Options" tab.
Under the "Gradle Build" section, add a check mark for "Use Grade Build" field.
Under the "Gradle Build" section, enter the value '24' in the "Min SDK" and "Target SDK" fields.
Under the "Keystore" section, provide the Debug details required for signing.
Click the "Export Project..." button.
Observe (Take note, the "Building Android Projec(gradle)" will close automatically)

https://github.com/godotengine/godot/assets/33121021/de040133-22bd-47c2-8a99-463f39c71a53
Minimal reproduction project
APKtest.zip

Please see the documentation for the requirements, you need 33 or later

Please see the documentation for the requirements, you need 33 or later

That's the tools requirement to target API level 33, which is the minimum requirement to publish a game on Google Play. But it should still be possible to target lower API levels with older build-tools/platform components, albeit the APK won't be suitable for Google Play distribution.
@NicolaasJKotze Could you clarify why you want to target API 24? To be clear, that's not necessary for games to be able to run on Android 7, this is covered by the Min SDK. The Target SDK covers what APIs are available to be enabled conditionally when running on newer Android versions.
It might well be that Godot's current code has an undocumented minimal Target SDK version that we would need to clarify and enforce with the range hint in the export dialog. CC @m4gr3d

Hi @akien-mga , thank you for asking. 😃
My motivation for supporting devices with an SDK as low as 24 is primarily aimed at broadening access in low-income countries, where these older devices are still in use. The primary objective in targeting these demographics is to facilitate the distribution of educational and serious games (socially-aware gaming) content. In these regions, we often share APKs with one another due to limited internet access and the associated high data costs.
Another motivation is we tend to obtain SDK 24+ devices easier and so helps with global resource sustainability drives. When using Godot in a classroom setting, being able to support these devices makes it also much-much more affordable to drive STEM/STEAM projects.

But the Min SDK should be the only thing you need to tweak to support those devices in my experience. The Target SDK being hire means that it also supports newer devices, but you don't need to build a specific APK for each Android version.

Hi @akien-mga ,

But the Min SDK should be the only thing you need to tweak to support those devices in my experience. The Target SDK being hire means that it also supports newer devices, but you don't need to build a specific APK for each Android version.

Thanks. I assumed that as well. I tried to install it on my LG G5 SE Android 7 and it failed. Screenshot at the bottom of this message. That's when I assumed I should force the SDK to 24.
I managed to dig out a different Android 7 device from storage and it installed the "Minimal reproduction project" fine.
So, it would seem there is a bit of hit and miss now regarding compatibility. It could be related to this ticket, or perhaps something different.
Let me know if there is more I can do to help. 😃
My test results:

Android 13: PASS ✅ - Virtual Device using Android Studio.
Android 8: FAIL - Virtual Device using Android Studio. See screenshot of error below.
Android 7: FAIL - Physical Device. LG G5 SE. See screenshot of error below.
Android 7: PASS ✅ - Physical Device. Huawei P9 Lite.

Android 8 Virtual Device screenshot:

Android 7 LG G5 SE device screenshot

What is the Android architecture for both devices where it's failing? (armeabi (v6), armeabi-v7a, arm64-v8a, x86, x86_64)
It sounds like it's just missing the library for the right architecture, which might just be an oversight when exporting:

If you didn't select armeabi-v7a but those devices use a 32-bit ARM processor (or 32-bit OS on 64-bit ARM processor), the errors are expected.

Hi @akien-mga ,
Great news! All tests to get the default export builds to install and run pass now! 🥂

LG G5 SE Android 7 = armeabi-v7a
Huawei P9 Lite Android 7 = arm64-v8a
Android 8 Virtual Device = x86/64

I am not 100% certain what the impact will be on larger projects with regards to file size (smaller vs larger package and free space requirement for installing) when exporting for a specific SDK. This is up to the team to decide if it will be of value to the Godot project.
CONCLUSION:
From my perspective, the way it works currently is good enough not having to "Use Gradle Build" as I can resume development.
Feel free to ask if there is anything I can help with. 😃

Great! If you distribute the projects on Google Play, you can include all 4 libraries (4 architectures), and Google Play will automatically remove the ones which are not necessary so that users only download the library that they need.
If you distribute projects directly through APK downloads, then it can make sense to make 4 separate exports, one for each architecture, but then you need to be able to teach your user to know which download is the right one for their device.
For the original issue reported here, what's needed for us is to see what's the actual lowest target SDK we can support, and set a minimum range to the spinbox so that users can't select a lower target SDK that won't compile.

I'm unable to replicate the issue on main or with the latest beta. The build completes fine with the target sdk set to 24.
It's possible that it may be a local configuration issue based on SO posts for this specific errors.
e.g: https://stackoverflow.com/questions/69188708/com-android-tools-r8-internal-q8-unsupported-class-file-version-60-in-android

Hi @m4gr3d ,
Thank you for checking the main branch.
I tested my original issue on the following build, v4.2.beta4.official [93cdacbb0], with success ✅ .
So, it seems this issue is only for the build v4.1.2.stable.official [399c9dc39].
❌ On a separate note which I will log as a new bug, once I managed to gather sufficient information, is that the game crash on load with an "AndroidRuntime" now on the test device using build v4.2.beta4.official [93cdacbb0].
Spec Details
v4.2.beta4.official [93cdacbb0]
- Windows 10.0.19045
- GLES3 (Compatibility)
- Quadro M3000M ()
- Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 Threads)

Screenshot of successful (with warnings) gradle build console output:

Thanks for testing! If it works in 4.2, given that lowering the Target SDK is not a common use case, I think we can consider this solved for future Godot versions.


ready handler always return 503

while i curl the ready handler it always return 503 and i found log like this: Secure Webhook Server is not ready: Get "https://:15017/httpsReady": remote error: tls: unrecognized name. is it a bug?

Please offer more information, like sidecar log, pilot log etc.


Add retry checker for DNS failure from Ingress

This patch fixes the recent flake in service_to_service_test.go on Kind/Istio.
istio-ingressgateway returns 502 with no such host error when it fails to resolve the cluster domain.
/cc @markusthoemmes

https://github.com/knative/serving/pull/12294 runs this patch and seems error could be avoided.

This patch fixes the recent flake in service_to_service_test.go on Kind/Istio.

I guess to clarify this isn't a flake as  it consistently failed in Kind running on GitHub actions. Thus I wonder if the retry is masking some other issue.
The other concerns I have, and let me know if this is just paranoia, is that by including this error checker by default we could mask issues in other ingresses and wouldn't know about it

To be more specific this only failed on GitHub actions with kind 1.22 & net-istio

I was also concerned but it retries only for the no DNS record in the internal DNS temporary.
I think it is difficult for ingress/coredns to guarantee that *.svc.cluster.local record is registered as soon as k8s svc is created so we need to retry it :thinking:

Then maybe as part of probing we should ensure that DNS works as expected.
K8s 1.22 introduces a newer CoreDNS version - ie. with endpoint slice support thus maybe istio isn't playing well with it

Sounds fair enough! Shall we track this and make sure we do our due diligence here?


Add Docker Image

Hi,
I'd like to run the mobileraker_companion in Docker to be able to add it to my project: https://github.com/mkuf/prind
This PR adds:

A Dockerfile at the Root of the repository, along with a dockerignore file
A github workflow that builds the docker image and uploads it to ghcr.io
A few lines of documentation about the image in the main Readme

Commits to the main Branch will build the latest tag for the Image.
Tagged commits will result in an image tag equal to the git tag.
For the Workflow to function, you'll have to enable Read and Write Permissions at Settings/Actions/General/Workflow Permissions, otherwise the Image upload to ghcr will fail.
Looking forward to your response.
-Markus

Hey,
thanks for your contribution! I will look into that hopefully later today or tomorrow. In case I forget about it, just ping me again.
Also your PrintD project looks really interesting and I am proud you want to include mobileraker to it.


FlexibleAmount is broken

Hi @tblanke
I noticed that the FlexibleAmount option is totally broken (strange that this slipped through the tests).
It is no longer possible to add a new row 'TypeError: FlexibleAmount._add_entry_at_row() got multiple values for argument 'row'
or remove one: 'TypeError: FlexibleAmount._del_entry() takes 1 positional argument but 2 positional arguments (and 1 keyword-only argument) were given'
Best,
@wouterpeere

Hi @tblanke
I solved this.
I just need to implement a test to check for this.
I also noticed another bug w.r.t. FlexibleAmount. If you try to remove the last row, this does not work (of course), but part of the gui is frozen, since it thinks this is a 'wrong value', which is not ...
Best,
@wouterpeere

Hi @wouterpeere ,
I will fix the second thing.
With best regards
@tblanke

Hi @tblanke
I just did that 😄
Best,
@wouterpeere


[QUESTION] - Other UI Libs

@ais-one, the latest release looks pretty solid!
I was wondering how deeply integrated is Vuetify into vue-crud-x? How easy/difficult would it be to use another component library (like iview, element, vue-ant, etc)?

Now not so difficult.
I indicated the places in the VueCrudX to change...
Planning to add ant when I have time... Vue and ant paging sorting filter
event is a bit different, but can be handled.
If need information faster, I am in the telegram group... @vuejssg
On Fri, Aug 2, 2019, 12:13 Cas du Plessis<EMAIL_ADDRESS>wrote:

@ais-one https://github.com/ais-one, the latest release looks pretty
solid!
I was wondering how deeply integrated is Vuetify into vue-crud-x? How
easy/difficult would it be to use another component library (like iview
https://www.iviewui.com/, element https://element.eleme.io/#/en-US,
vue-ant https://vue.ant.design/docs/vue/introduce/, etc)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ais-one/vue-crud-x/issues/69?email_source=notifications&email_token=ABAWBHV6EZE24XH3S7M7VPDQCOX57A5CNFSM4II2HC52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HC6733A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAWBHQXIMIKPDZ5O2D7NFDQCOX57ANCNFSM4II2HC5Q
.

@ais-one, any idea when ant would be implemented?

I will try out next month... this month was really bz
On Mon, Sep 9, 2019, 13:39 Cas du Plessis<EMAIL_ADDRESS>wrote:

@ais-one https://github.com/ais-one, any idea when ant would be
implemented?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ais-one/vue-crud-x/issues/69?email_source=notifications&email_token=ABAWBHTZKEKKT7UQRUE3NNLQIXOQ5A5CNFSM4II2HC52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GJPQY#issuecomment-529307587,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAWBHRPYQR6X7U72WLDXG3QIXOQ5ANCNFSM4II2HC5Q
.

Now that things seem abit more stable, I would like to explore using another UI library such as Ant Design

Hi @ais-one ... great changes with 0.30! Any progress with the Ant Design version?

Hi, yes finally... will be moving on to Ant Design...
I need to try and reduce as much dependancy on any UI framework. Fortunately, Ant Design and Vuetify have pagination included with the data tables.
Bootstrap and I think Buefy does not have. Those will consider later.

trying to get ant-design-vue to work with vue 3...

https://medium.com/@eauditory3/ant-design-or-elephant-design-a03c19549553
Ant design is feature rich but seems bloated, even with tree shaking, thinking of really looking out for some other alternative...

We may revisit Ant Design...
https://2x.antdv.com/docs/vue/migration-v2/
Hopefully momentJS is no longer a dependency there...

overtaken by events


[PR][CLOSED] Synced doxgen files and doc folder

 Issue by geunsik-lim
Tuesday Jun 12, 2018 at 01:53 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/pull/14

This PR is to move the doxgen files and doc folder to ci folder.
Changes proposed in this PR:

Moved Doxyfile*** to ci folder
Moved doc folder to ci folder

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>
geunsik-lim included the following code: https://github.sec.samsung.net/STAR/TAOS-CI/pull/14/commits

:octocat: cibot: Thank you for posting issue #31. The person in charge will reply soon.


(closes #8) Multi-line tags and strings

Add support for multi-line tags and strings in markup (non-Zig) chunks:

hello

Re-work parser to work char by char instead of line by line.
Also fixes some bugs with missing blank lines (tests were incorrect).
Thanks @dhrubrawat66 for raising this one.

@Trundle Thanks for the review, I just pushed a commit to main that includes a template with DOS linebreaks, we just normalize to \n now so all the \r\n special-case code has gone.
Maybe we'll convert back to \r\n on Windows if people are using Zmpl directly to generate HTML they want to edit manually ? I think low priority, maybe just wait for somebody to ask for it.


update required packages in viz.yaml

Added these because I had a fresh library so it error-ed every single time.

✋ guilty, too


Support Oversubscription on a per job and per instance basis.

Mesos has introduced a concept of revocable resources.  It would outstanding if Chronos could support that at a per job and a per instance level.
Two use cases:

Production level Chronos instance that allows a production control team to identify jobs that when they run, their resources are revocable such as that they will be killed and marked as failed for that run.  This way production control could specify jobs that "first-class" jobs, i.e. they run, and their resources are guaranteed, vs those that could be killed.

Having an multiple instances of Chronos. I.e.  A prod instance and a dev instance. On the prod instance the jobs guarantee of resources is set at a per job level by the production control team and only those with proper credentials can submit jobs to this instance.  On the dev instance, it is run that all jobs submitted to this instance run with revocable resources. Thus devs looking to try jobs or work with development tasks etc know that their resources may be pulled if production demands it.

Both of these use cases would allow for nice multi-tenancy and utilization of the over subscription features in Mesos.

Great suggestion, thanks!


Command errors?

If a client sends a WebSocket command which is not even syntactically valid JSON, is there any means for the server to indicate this:

i.e. send an error message back,
or close the WebSocket connection from the server side,
or can it only just ignore the command?

How about if the command message is valid JSON, and also validates against one of the command schemas (or better, the top-level one proposed in https://github.com/AMWA-TV/nmos-event-tally/pull/35#issuecomment-491221820), but is semantically invalid - e.g. one of the specified "sources" in a subscription command doesn't exist?
I am imagining it might be worth defining an error message type in Message types, with a payload of the NMOS core error type? (I see no harm in reusing HTTP status codes here.)
Some clarification of command error handling would be good in v1.0.x documentation, but adding an error response has to wait for v1.1, I guess!

It is a v1.1 issue, to be discussed later

We also noted on the call that it would ideally involve a way for an error response to identify which command message it is referring to, which is non-trivial.