Allow to set CPU_MODEL[FEATURES] on host and cluster level

Description
Actually, CPU Features can be set only in VM template. Would be fine to allow to set it on host and cluster level.

Progress Status

[x] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

All merge, thanks for the contribution :heart:


New landing page for Swan

Partially fixes issue of outdated documentation
Summary of changes:

Added quick start on landing page using Vagrant
Removed obsolete documentations
Landing page is more welcoming (I hope)
Developement provisioning needs additional env variable (waiting for update in CI env)

Testing done:

Still testing if our vagrant box is OK.

run integration tests

run integration tests

run integration tests

run integration tests


Remove deprecated JVM arguments in Java 11

Ⅰ. Describe what this PR did
Remove deprecated JVM arguments in Java 11
Ⅱ. Does this pull request fix one issue?

#1819
Ⅲ. Why don't you add test cases (unit test/integration test)?
There is no test for server script
Ⅳ. Describe how to verify it

Change JRE to 8, startup server in Mac/Linux/Win
Change JRE to 11, startup server in Mac/Linux/Win

All environment should be startup normally.
Ⅴ. Special notes for reviews
Need to make sure removed argument is not affect performance of server

Codecov Report

Merging #1824 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1824      +/-   ##
=============================================
- Coverage      55.08%   55.07%   -0.02%
+ Complexity      2355     2353       -2
=============================================
  Files            421      421
  Lines          14264    14264
  Branches        1710     1710
=============================================
- Hits            7858     7856       -2
  Misses          5680     5680
- Partials         726      728       +2

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/seata/server/session/GlobalSession.java
84.54% <0%> (-0.49%)
67% <0%> (-1%)

...o/seata/server/coordinator/DefaultCoordinator.java
49.59% <0%> (-0.41%)
27% <0%> (-1%)


My Screen doesn't match with FGA touch?

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
Hi thank for your app,i just been reccommend this by my friend.
but when i try follow your guide or my friend it doesn't work, so i try with debug mode and found that maybe it screen problem.
I try one with custom game area with left=52 right 153= but it seems do that made the play button gone and also it have to be in duo mode if i want play button back.
I'm using ROG Phone 5.

I don't see anything wrong with your screen.
Please use the normal game area and then take a video with FGA using FGA's recording function. Then upload the video.

https://user-images.githubusercontent.com/108753132/177383944-259a44ab-951b-4f5e-b2d4-9615891b57a6.mp4
here the vid

So...no solution?

using FGA's recording function

under More Options, Advanced.

up have the same problem

I didn't read the part about the play button not showing up. The Surface Duo mode is made to only work for that one phone.
Normally, when the play button doesn't appear on my phone, I restart the phone and then it appears again.
@zennnnn15 Also ROG 5? Didn't see your comment.


[HOLD on #15611] [$2000]  iOS - Chat - When moving to another line, the word and emoji are close to each other.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with any account
In the compose box enter message with have lengthier letters like (j) and emoji

Expected Result:
Text entered with letters and emojis on the next line must not be close to each other
Actual Result:
When moving to another line, the word and emoji are close to each other
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] iOS / native

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/213815233-c2908d14-2042-4571-9196-09fbb3de6bd2.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ebb233eae82dffea
Upwork Job ID:<PHONE_NUMBER>891505152
Last Price Increase: 2023-02-13

Sorry for the delay, I was getting my Android phone working as well to test it there too.
My first few of these, so taking the template from StackOverflowTeams: https://stackoverflowteams.com/c/expensify/questions/14418

[ ] The "bug" is actually a bug.
[x] The bug is not a duplicate report of an existing GH
[ ] The bug is reproducible, following the reproduction steps.
[ ] The GH template is filled out as fully as possible
[x] The GH was created by an Expensify employee or a QA tester.
[x] The bug is an /App issue

So, as we can see from my checklist, I don't see this still occurring.
iOS v12-58.4
https://user-images.githubusercontent.com/9133401/214638575-051e0d0d-0d2e-49f1-b753-12de6e56e6a8.MP4
Eugh, and my Android device still isn't working. Okay, in the meantime - I think this has self-resolved somehow. Could you confirm @kbecciv?

Okay, I tested this again today and I think this is a non-issue/resolved. Closing it.

@twisterdotcom Issue is still reproduced with build <IP_ADDRESS>
Please type the message with lengthier letters like (j) and emoji, so you will be able to reproduce it.

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Okay, you're right? Yes, if it's a lower case letter than typically falls below the bottom line, it interferes ever so slightly with the next line, especially emoji. So q, j, g, y, and p I think:

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Triggered auto assignment to @ctkochan22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@fedirjh, thank you for your proposal, I think you might be right about the wrong lineHeight. However, I think different line heights for different lines (that contain emojis and not) aren't going to look good. Why are emojis bigger than text? Why is this happening only on iOS?

@eVoloshchak @twisterdotcom @ctkochan22 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@eVoloshchak, @twisterdotcom, @ctkochan22 Eep! 4 days overdue now. Issues have feelings too...

Are we going with @fedirjh's proposal @eVoloshchak and @ctkochan22? If so, let's get them assigned!

@twisterdotcom, I think we should HOLD until https://github.com/Expensify/App/pull/15088 is merged. It resolves https://github.com/Expensify/App/issues/4114 and adds logic for rendering emojis with styles different from text (which is a mix of @fedirjh's and @redstar504's proposals)

Cool, sounds good. I'll add a HOLD.

Holding makes sense

Still on hold: https://github.com/Expensify/App/pull/15088

Still on hold: https://github.com/Expensify/App/pull/15088

Still on hold I believe. @twisterdotcom please re-apply the engineering label for re-assignment when off hold (or before, just a suggestion)

Still held.

Held on https://github.com/Expensify/App/pull/15611

Npt overdue, holding for https://github.com/Expensify/App/pull/15611, which is in review

Still held on https://github.com/Expensify/App/pull/15611

Still held but I do see movement.

FB addressed some comments here: https://github.com/facebook/hermes/pull/968#pullrequestreview-1458032263

Last update from @fbmal7 here: https://github.com/facebook/hermes/pull/968#issuecomment-1599335001

Same as above.

Waiting for RN 0.73: https://github.com/facebook/hermes/pull/968#issuecomment-1633011552

Okay, @eVoloshchak can we unhold this now?

@twisterdotcom, not yet, https://github.com/facebook/hermes/pull/968 will be included in RN 0.73 (it isn't out yet)

Not overdue, still waiting for RN 0.73

Still held on https://github.com/Expensify/App/issues/31381

Still held.

Issue still exists. WhatsApp does handle it, so let's still try it but... gonna move to vipvsb and make it FUTURE and set it as $500 again.
https://github.com/Expensify/App/assets/9133401/6152a831-5de7-479d-bee6-e0822ed8c236

Discussing closing this here: https://expensify.slack.com/archives/C01SKUP7QR0/p1709660985424209

@fabOnReact - we held this previously on https://github.com/Expensify/App/issues/31381 thinking it would help, but it didn't. @cead22 tells me that maybe https://github.com/Expensify/App/issues/17767 will fix it. Do you think it might? If so, I'll HOLD it again.

Thanks. I'll work on this next week.

@fabOnReact how are you doing on this one?

Bump on this @fabOnReact

The BZ member will need to manually hire fabOnReact for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

I tried to apply for the Upwork job but it says that the job is no longer available.
I used this link https://www.upwork.com/jobs/~01ebb233eae82dffea
This is my Upwork profile https://www.upwork.com/freelancers/~01ae44247887fa908b?viewMode=1
Thanks

Offer sent: https://www.upwork.com/nx/wm/offer/102318386.
You can accept, but I think we still want to ensure that https://github.com/Expensify/App/issues/4114 or https://github.com/Expensify/App/issues/17767 won't actually resolve it anyway, and that your solution will work after that.

Update 17th May 2024
I wanted to let you know that I accepted the offer.

You can accept, but I think we still want to ensure that https://github.com/Expensify/App/issues/4114 or https://github.com/Expensify/App/issues/17767 won't actually resolve it anyway, and that your solution will work after that.

I tested a solution for this issue. I will publish a proposal explaining the root cause and a Pull Request with the solution in a couple of days. Thanks.

Update 20th May 2024
I published a draft PR https://github.com/Expensify/react-native-live-markdown/pull/350. I will follow up in a couple of days. Thanks.

Update 21st May 2024
I published 2 draft PRs https://github.com/Expensify/react-native-live-markdown/pull/350 and https://github.com/facebook/react-native/pull/44614 to fix this issue. I will follow up in a couple of days. Thanks

Update 22 May 2024

Merged PR https://github.com/Expensify/react-native-live-markdown/pull/350
Meta imported PR https://github.com/facebook/react-native/pull/44614
Published Draft PR https://github.com/Expensify/App/pull/42454 to update Expensify dependency react-native-live-markdown to 0.1.76. I will move it to Ready for Review tomorrow.

Update 23 May 2024
Moved PR https://github.com/Expensify/App/pull/42454 to ready for review.

Update 28 May 2024

PR #42454 merged
I'll be away for 3 days for personal reasons (29, 30, 31st). I will restart working on Saturday 1st of June.

Update 1st of June 2024
PR https://github.com/Expensify/App/pull/42454 was reverted because there are issues with react-native-live-markdown. The issues seem to not be related to PR https://github.com/Expensify/react-native-live-markdown/pull/350.

https://github.com/Expensify/App/issues/42755 (Android)

Update 5 June 2024
I reviewed and tested the regressions and none of them are related to my PR https://github.com/Expensify/react-native-live-markdown/pull/350.

https://github.com/Expensify/App/pull/42454#issuecomment-2148808477 The regression on iOS is not caused by my changes.
https://github.com/Expensify/App/issues/42755 My changes are iOS only
https://github.com/Expensify/App/issues/42766 My changes are iOS only

Should we revert the revert? Do you need to submit a new PR again?

Update 6th June 2024
Sorry, maybe my previous comment was not clear.

My PR react-native-live-markdown/pull/350 does not introduce any regression on iOS (see tests performed here).
My PR react-native-live-markdown/pull/350 includes iOS-only changes and it does not introduce regressions on Android (see my comment here).

I will start working again on this task on Monday. Hopefully, I can help to get this issue fixed so that we can upgrade react-native-live-markdown and close Issue 14445.

Should we revert the revert?

We can not update react-native-live-markdown until the above issues are fixed.

Do you need to submit a new PR again?

Yes. We need to re-test again and publish a new PR to bump react-native-live-markdown to 0.1.76
I quote @Skalakid comment.

After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after
I will create PR that bumps the version in the Expensify App
I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue now

Maybe with the latest version of expensify-common and react-native-live-markdown the issue will not reproduce anymore. I will verify this on Monday (unluckily now I have other commitments). Thanks

No worries, we can wait until Monday.

Update 10 July 2024

Tested PR https://github.com/Expensify/App/pull/43255#issuecomment-2157494277. The issue is fixed.
Meta team needs to merge PR https://github.com/facebook/react-native/pull/44614.
Regarding the Deploy Blocker. Issues 43332 and 43312 reverted PR 377. Our PR 350 did not introduce regression and is part of Expensify main branch (react-native-live-markdown version 0.1.83.

$500 approved for @eVoloshchak


Add TAG reader

Some VTO device like VTO2111D-P-S2 have NFC Tag reader.
With propose code add therse features

Should we make a new PR for this? Think @ozziii abandoned this PR. Willing to make a new PR myself.

@rroller could this be merged soon? This feature would be great.

Hmm, there's a merge conflict, this needs to be fixed first, then i'll merge

I created a new PR and merged it in https://github.com/rroller/dahua/pull/279

Released in 0.9.45 - https://github.com/rroller/dahua/releases/tag/0.9.45


File-saving issues.What is right way to save files or just clean them?

Win10 64.
I changed line 90 temp = tmpname() to temp = 'c:\\tmp\\'..basename(d.filename), and send a flag.jpg and a honeydew.xlsx. Both are saved in the specified path with correct size but I can't open them.
make a form like:

    <form enctype="multipart/form-data" method="post">

            user
            <input id="username" name="username" type="text" />

    File input
    <input type="file" id="files" name="myfile">

    File input2
    <input type="file" id="files1" name="myfile1">

        <input type="submit" value="submit"/>
    </form>

Hi, what do you mean that you can't open them (you don't have access to them? they are locked or something? or their content is corrupted?).
Have you checked that hashes match, eg:
CertUtil -hashfile C:\tmp\flag.jpg MD5

And compare the hash to original.
I fear there is something strange going on on Windows, but I'm not sure what. I do not have Windows around.

What is right way to save files or just clean them?

Well you should use:

https://www.lua.org/manual/5.1/manual.html#pdf-os.rename to move tmpname file to your preferred location
You should clean them with https://www.lua.org/manual/5.1/manual.html#pdf-os.remove (or just have cron, scheduled task, nginx timer etc. to cleanup old files from temp)

It's corrupted. It's a windows problem. I've also tried lua-resty-post which has the same issue. Seems to be a lua-resty-upload issue.
Later I found thant It's Ok in ubuntu. So never mind..Thanks for suggestions.


Consent

[X] I have searched the existing issues and verified that there is no open issue for the same subject.
[X] I understand that the YTMDesktop Elgato Plugin has NO affiliation with Google, YouTube or the YTMDesktop application.

Question
I've now tried to connect on my streamdeck, but I don't have a connect or authenticate button anywhere on streamdeck.
What should I do?

The YouTube app has allowed authentication, but it is not resolved.

I downloaded the plug-in, but how do I update it to the latest version?
I don't know how because I installed it from the plug-in collection on stream deck.

If you've downloaded it through the Elgato Marketplace, here's a quick guide:

Click on the gear symbol
Click on the Plugins Tab and select the plugin
Click on the "Check for updates" button

i I'm using Monster Deck.
using monster deck.

Sadly I'm not sure what a "Monster Deck" is, could you elaborate? Because in the description above, you've written "my streamdeck".

https://www.monstargear.co.kr/1136/?idx=1010
https://www.monstargear.co.kr/505/?q=YToxOntzOjEyOiJrZXl3b3JkX3R5cGUiO3M6MzoiYWxsIjt9&bmode=view&idx=17314715&t=board
I'm using a stream deck from a company called Monsta Gear.
Attached is the url and software url of the company.

I've investigated a bit and have to inform you that they don't seem to be affiliated or partnered with elgato. They also seem kinda shady/sketchy (disabled context menu, disabled the copy function, same Company Registration Number as other sketchy "companies", etc).
I've never developed a plugin for them and it seems they've just stolen mine and put it into their "collection" or something. Please correct me, if I'm wrong, but the fact you can't even update the plugin to the latest version and you're still on a such outdated one AND they advise you to run the software in administrator mode as soon as basic functions don't work (and many other things), also tells me a lot.
Therefore I've to inform you that I can't provide you any support for such devices, especially because I never developed anything for them, don't know their software and, this is the most important one, I don't trust them, nor do I support any kind copyright infringements.
TL;DR
I've to inform you that I can't give you any support, because you're using an unsupported and unknown (to me) device manufacturer and software.

Thank you for your response.
I'll have to contact the company about that.
Thank you for your kind and sincere response.
I hope you have a great day.


Lists Render Extremely Slow (Unbearable beyond 100 items on desktop)

Lists render extremely slowly a simple render of 100 list items (each with a checkbox) takes over 1000ms to render on my desktop. Even when removing the checkboxes, I get similar performance.
On my phone (Galaxy S5) it takes nearly 1000ms to render 10 items.
Presently this makes lists unusable in many use-cases. The same list, rendered with just html and css markup, takes less than 100ms to render.
Tested in up to date version of Chrome, and Android 4.4

I'm having the same issue with performance in lists.

I suggest you to use https://github.com/orgsync/react-list

I'm using material-ui and I need a list so I'd really prefer using the material-ui list and not yet another library..
+1 for fixing this performance issue.

I'm running into this performance issue too. I'm working around it using an infinite scroll component like @oliviertassinari suggested, but a real fix would be a huge help.

@t1mmen Using react-list is not a "hack" if you need to render a significant amount of ListItem. How many items are you rendering?

@oliviertassinari I've been noticing decreased performance using ListItem's starting around 10 items (on desktop). Once I get closer to 50 it's pretty painful, particularly in dev/debug mode (production is better, but still very noticeable)
Typically, around 30 ListItems are visible on screen at the same time, so there isn't a lot of room to optimize. react-list did make  a world of difference when I tested with 300 ListItem's though.

I've been noticing decreased performance using ListItem's starting around 10 items (on desktop)

Well, we need to do something then!

Thank you, appreciate it! As I'll be using more of material-ui in the coming weeks, I'll try to contribute more concrete reports & code in the future. Thanks again for your efforts!

I encounter the same issue with more than 10 ListItem with checkboxes (using LeftCheckbox). All the items are rerendered when I check/uncheck a checkbox in the list. The expected behaviour would be that only the item checked rerender I think.

+1 this is becoming a major issue! Any headway on a solution?

Lists are terribly slow on cordova on Android as well. I have 25 items on my list and its painfully slow even to scroll the list.

+1

+1

I only seem to have issues with list performance if using nested items.  For me, replacing the parent/container listitem with a card with collapsible cardtext improved performance tremendously.  Maybe that will help someone.

+1. Small list(~10 items) with checkboxes is really slow.

Closing in favour of #3289


FlexibleItemDecoration increate space when fragment return from backstack

Here is my config for Decoration:
 mRecyclerView.addItemDecoration(new FlexibleItemDecoration(mActivity.get())
                .addItemViewType(R.layout.item_chanel, 8,8,8,8)
                .withDivider(hasDivider() ? R.drawable.divider : 0)
                .withSectionGapOffset(0)
                .withDrawOver(true)
                .withEdge(true));

After press back to return previous Fragment, it call oncreateView again and item: item_chanel have margin increate.

@mdtuyen, I understood that the space is added to each item everytime you go back from a Fragment? well, do you add decoration multiple times? I mean, what is the code executed when the fragment is resumed?
Please, always try with some logs and at least debugging.

@mdtuyen, in my example, I don't use backstack and the fragment is every time recreated with a replace.
Maybe, the issue 457, could be useful to you as well?


v10.2.26 improve regex

Current coverage is 95.46%

Merging #208 into master will not affect coverage as of 2130014

@@            master    #208   diff @@
======================================
  Files           26      26
  Stmts          375     375
  Branches         0       0
  Methods         83      83
======================================
  Hit            358     358
  Partial          0       0
  Missed          17      17

Review entire Coverage Diff as of 2130014

Powered by Codecov. Updated on successful CI builds.


Setting timeout for waitForPodsReady to 5min

Changes

Setting timeout for waitForPodsReady to 5min

/kind enhancement
Fixes #91

Release Note
Timeout after 5 minutes if knative resources aren't ready

/assign @csantanapr @julz

/lgtm


I suspect the just-released "Tool support" in ollama 0.3.0, will be really valuable to Aider.? - can this be integrated.?

Issue
rellease notes:
https://github.com/ollama/ollama/releases/tag/v0.3.0
sample python: [ from announcement ]:
import ollama

response = ollama.chat(
    model='llama3.1',
    messages=[{'role': 'user', 'content': 'What is the weather in Toronto?'}],

    # provide a weather checking tool to the model
    tools=[{
      'type': 'function',
      'function': {
        'name': 'get_current_weather',
        'description': 'Get the current weather for a city',
        'parameters': {
          'type': 'object',
          'properties': {
            'city': {
              'type': 'string',
              'description': 'The name of the city',
            },
          },
          'required': ['city'],
        },
      },
    },
  ],
)

print(response['message']['tool_calls'])

Version and model info
No response

Thanks for trying aider and filing this issue.
Aider doesn't currently use tools. But it's nice to know Ollama will support tools if aider starts using them.
I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Added URLs & Updated social-apps.md with the platforms I've worked on

Title
Added URLs & Updated social-apps.md with the platforms I've worked on
Description
Added URLs & Updated social-apps.md for the 7 social platforms I've worked on

Issue Ticket Number
Fixes #2

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes needed to the documentation

Hey @SamFusedBits ,
Amazing work done! ⭐
I am merging this to main branch.
Thanks for contributing to SocialRepo
Looking forward for more contributions. :D
Keep Contributing 🙌


misc/cgo/test: Test9400 in TestCrossPackageTests hangs on ppc64le

While trying to reproduce some sporadic failures on seen on the ppc64le CI machines, I came across a hang in Test9400 on a POWER10 machine with GOMAXPROCS=2.
What version of Go are you using (go version)?

$ go version
go version devel go1.18-e8cda0a6c9 Fri Nov 19 00:05:59 2021 +0000 linux/ppc64le

What did you do?
cd $GOPATH/misc/cgo/test
go test -buildmode=pie -ldflags=-linkmode=internal -tags=internal,internal_pie -c
export GOMAXPROCS=2
while [ 1 ]; do ./test.test -test.v -test.short ; done
Eventually this hangs on TestCrossPackageTests running Test9400.
This kind of looks like it may be an untimely GC starting while issue9400.RewindAndSetgid is spinning on a condition.
I inserted a call to runtime.GC prior to the above call, and was unable to reproduce the hang.

Update on the root cause here: the fixes for #49680, #49695, and #45867 all assumed that SetGCPercent(-1) doesn't block until the GC's mark phase is done, but it actually does. The cause of those failures is that at the beginning of the sweep phase, the GC does try to preempt every P once, and this may run concurrently with test code that has non-preemptible goroutines that create the potential for a deadlock.


rename segmentrangereader to logreader

@deenlee want to do the same thing for the c++ implementation (for replay and cabana)?

that's the wrong @deanlee ^^

@jnewb1 submitted: https://github.com/commaai/openpilot/pull/30981


Fetch link favicons even when feature disabled

Info:

OS: Windows 11
Logseq ver: 0.7.9
Theme ver: 1.18.0
[ ] Do i have the same on default theme?

Description:
I disabled the "Auto favicons for external links" by using --favicons: none; as there is no network in my work place. But then found there still are request about favicon.
To Reproduce:
Disable that feature, input some links, then you would see the network requests.
Expected behavior:
Not fetch favicon when auto favicon disabled at all.
Screenshots

Attach files

it was "CSS only" solution for disable. now working on JS with configuration via Logseq plugins settings

gotcha. Thanks for your hard work, this is the best logseq theme I ever use

DONE!
⚠ according to theme init changes - RELOAD REQUIRED! ⚠
https://github.com/yoyurec/logseq-solarized-extended-theme/releases/tag/v2.0.0


Updated validations.py python script

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
closes: #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


game crashes?

This is the first time I'm trying to run the game, so I'm not sure if I'm just doing something wrong -- tried to start up a new game with the type "master of {something}". The crash reporter offered to file a GitHub issue, but clicking that button didn't do anything, so I'm reporting manually in case it's something of interest.
log file here: https://pastebin.com/417RDRky
OS: Linux (Gentoo)

Hey again :-)
Looks like you ran "Master of Oreon" and something crashed in the game. I can confirm it crashes for me too so that gameplay template is broken right now.
Will move this issue over to the actual game engine repo as it is a problem with the game while the launcher is OK and doing its job normally. You can follow this issue for when there's a fix 👍
In the meantime try out different game modes like JoshariasSurvival and see if they work better.


fix: ensure using base does not require additional configuration

Description 📖
This pull request makes a few changes to ensure that a Vite app using base doesn't require additional configuration in vite-plugin-pwa
Changes ✏

Changed start_url to be relative, so that when using base the start_url is resolved correctly.
Removed a leading slash from the navigation fallback so that it matches the exact name that is rendered in the manifest, fixing an error when the service worker is first installed:

  WorkboxError.js:28 Uncaught (in promise) non-precached-url: non-precached-url :: [{"url":"/index.html"}]

Notes 🗒
Initially I thought about turning cachePreset into a function that receives basePath, and use:
urlPattern: basePath,

but after investigating, it turns out that the first rule copied from next-pwa is not really used.
Since vite-plugin-pwa adds index.html to navigateFallback, the precaching rule will always match first, and that rule will never be used.

Thanks for the high-quality PR 😄👍


Use standard Rancher/Cattle environment variables

Hi, this looks like a good tool. Can you make it use the standard environment variables for Rancher URL, User and Password - covered in Service Accounts in Rancher?

CATTLE_ACCESS_KEY
CATTLE_SECRET_KEY
CATTLE_URL

Hi,
thanks for the feedback.
Do you mean to replace the variables:
RANCHER_APIV2_URL	-> CATTLE_URL
RANCHER_API_USER	-> CATTLE_ACCESS_KEY
RANCHER_API_PASS       -> CATTLE_SECRET_KEY?

Well, I think you may want to support both so you're backward compatible.

Okay I see, so we are talking about V1 and the service accounts here, since the above link isn't working for me, this is the correct one:
http://docs.rancher.com/rancher/v1.2/en/rancher-services/service-accounts/
I will check this out.

Oh. I didn't realize. I haven't moved to >= 1.2 yet.

Should work now, could you please take a look at the newest image and report back if this issue can ben closed?

Thanks. Unfortunately, I think there is more needed to make it work with v1 api. I made a fork, will check this out and will send a pull request once I have it working with v1.

Strange, I have tested it just with providing the labels and it worked but only with the newest version.
Can you show me the logs?

Sure, here are the logs. What I found is that it is going to
/v1/stacks which returns 404. In v1, it's /v1/environments.
2/23/2017 9:47:17 AM[v0.4] [23.02.2017]
2/23/2017 9:47:17 AMStarting up ... cleaning.
2/23/2017 9:47:19 AMFetching rancher stacks ... Exception in thread
"main" org.json.JSONException: JSONObject["data"] not found.
2/23/2017 9:47:19 AM	at org.json.JSONObject.get(JSONObject.java:473)
2/23/2017 9:47:19 AM	at
org.json.JSONObject.getJSONArray(JSONObject.java:555)
2/23/2017 9:47:19 AM	at
ly.gerge.rancher2git.rancher.RancherInstance.fetchRancherStacks(RancherInstance.java:68)
2/23/2017 9:47:19 AM	at
ly.gerge.rancher2git.Rancher2git.main(Rancher2git.java:43)
2/23/2017 10:47:20 AMStarting up ... cleaning.
2/23/2017 10:47:21 AMFetching rancher stacks ... Exception in thread
"main" org.json.JSONException: JSONObject["data"] not found.
2/23/2017 10:47:21 AM	at org.json.JSONObject.get(JSONObject.java:473)
2/23/2017 10:47:21 AM	at
org.json.JSONObject.getJSONArray(JSONObject.java:555)
2/23/2017 10:47:21 AM	at
ly.gerge.rancher2git.rancher.RancherInstance.fetchRancherStacks(RancherInstance.java:68)
2/23/2017 10:47:21 AM	at
ly.gerge.rancher2git.Rancher2git.main(Rancher2git.java:43)
2/23/2017 11:47:21 AMStarting up ... cleaning.
2/23/2017 11:47:22 AMFetching rancher stacks ... Exception in thread
"main" org.json.JSONException: JSONObject["data"] not found.
2/23/2017 11:47:22 AM	at org.json.JSONObject.get(JSONObject.java:473)
2/23/2017 11:47:22 AM	at
org.json.JSONObject.getJSONArray(JSONObject.java:555)
2/23/2017 11:47:22 AM	at
ly.gerge.rancher2git.rancher.RancherInstance.fetchRancherStacks(RancherInstance.java:68)
2/23/2017 11:47:22 AM	at
ly.gerge.rancher2git.Rancher2git.main(Rancher2git.java:43)

OK I see the problem here. It appears that API v2 calls are redirected to v2 if try to call them on V1 this is why it worked on my setup.
Can you provide me with the API Url that starts the download of Config Zip file?
I can't seem to find one. If this is not possible with v1 I will have to fetch the configs from the JSON and write it on disk.


Migrate to "io.grpc:grpc-all" and "io.grpc:protoc-gen-grpc-java" 0.9.0

Migrate to "io.grpc:grpc-all" and "io.grpc:protoc-gen-grpc-java" 0.9.0;
replace internal API usages, use preferred API.

LGTM apart from the question on suppressed warning.
Just remove that suppression and we're good to move on.


Support error response message

Whenever a HART device does not implement an (optional) command it should return with only 2 bytes of status bytes as a response.
This is currently not implemented in the parser, but for most responses an exception is thrown as more bytes are expected while unpacking with struct.

I would be happy to provide a patch to fix this upstream


proto: incorrect size of encoded repeated fields

What version of protobuf and what language are you using?
Version: b27b920
What did you do?
Unfortunately I can't provide code to reproduce behavior because it's statistically hard to catch an error.
I have such message structure:
message MsgKey {
	required uint32 key_1 = 1;
	required uint32 key_2 = 2;
}

message SomeOtherInfo {
	required uint32 id    = 1;
	repeated int64 arr_1  = 2 [packed = true];
	repeated uint32 arr_2 = 3 [packed = true];
}

message Payload {
	required sint32 val_1 = 1;
	optional sint32 val_2 = 2 [default = 0];
	optional uint32 id    = 3;
}

message Info {
	message SubMsg {
		required MsgKey key         = 1;
		repeated SomeOtherInfo info = 2;
	}

	required uint64 id       = 1;
	repeated Payload payload = 2;
	repeated SubMsg msgs     = 3;
}

message RootMessage {
	repeated Info info = 1;
};

And sometimes I'm getting incorrectly marshaled RootMessage in a way that it seems to be packed correctly but puts wrong size to its header.
Example of payload that encoded wrong:
0A750805120408001801120508D0031802120508C8011803120508D0031804120408321805120408281806120408781807120408001808120508D00518091204084E180A1204083A180B12040840180C12040800180D12040800180E12040800180F120508C8011810120408541811120408001812

As you can see from the header its body lenght is 0x75 (or 117) but if you try to feed that message to protoc --decode_raw without schema you'll get an error:
$ echo -ne '<hex_message_content>' | xxd -r -p - | protoc --decode_raw
Failed to parse input.

But when I change length in header manually to 0x73 (115 which is correct size) it becomes readable:
Click to expand

1 {
  1: 5
  2 {
    1: 0
    3: 1
  }
  2 {
    1: 464
    3: 2
  }
  2 {
    1: 200
    3: 3
  }
  2 {
    1: 464
    3: 4
  }
  2 {
    1: 50
    3: 5
  }
  2 {
    1: 40
    3: 6
  }
  2 {
    1: 120
    3: 7
  }
  2 {
    1: 0
    3: 8
  }
  2 {
    1: 720
    3: 9
  }
  2 {
    1: 78
    3: 10
  }
  2 {
    1: 58
    3: 11
  }
  2 {
    1: 64
    3: 12
  }
  2 {
    1: 0
    3: 13
  }
  2 {
    1: 0
    3: 14
  }
  2 {
    1: 0
    3: 15
  }
  2 {
    1: 200
    3: 16
  }
  2 {
    1: 84
    3: 17
  }
  2 {
    1: 0
    3: 18
  }
}

And there's an example of data of same message that encoded correctly:
0A730801120408001801120508D0031802120508C8011803120508D0031804120408001805120408001806120408781807120408001808120508D00518091204084E180A1204083A180B12040840180C12040800180D12040800180E12040800180F120508C8011810120408001811120408001812

Yep. You were right.
Tried to investigate race conditions and found a place where protobuf works in thread-unsafe manner.

Wait, is it protobuf working in the thread-unsafe manner, or your code working in the thread-unsafe manner?
If the race-condition is in protobuf, rather than just closing this issue, we should at the very least know and document when it can occur, or even better, figure out a resolution so that it is thread-safe.

@puellanivis no, this is not a protobuf issue. Sorry for mistake.
AFAIK protobuf encoder doesn't use any synchronization between goroutines so this is what user should handle by himself.
And in my particular case I call encoding procedure and another one that modifies data at the same time. Classic example of race condition. But it was tricky to find so I ran an app with race detector as @dsnet suggested.


[KYUUBI #2706] Spark extensions support Spark-3.3

Why are the changes needed?

to close #2706
Spark extensions support Spark-3.3, part of #2620
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #2707 (0b07b6e) into master (85d68b2) will decrease coverage by 3.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2707      +/-   ##
============================================
- Coverage     64.19%   61.10%   -3.09%
+ Complexity      282      241      -41
============================================
  Files           407      404       -3
  Lines         19113    19044      -69
  Branches       2572     2563       -9
============================================
- Hits          12269    11637     -632
- Misses         5693     6311     +618
+ Partials       1151     1096      -55

Impacted Files
Coverage Δ

...che/kyuubi/sql/watchdog/MaxPartitionStrategy.scala
0.00% <0.00%> (ø)

...pache/kyuubi/sql/KyuubiSQLExtensionException.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala
0.00% <0.00%> (-94.74%)
:arrow_down:

...ubi/sql/zorder/InsertZorderBeforeWritingBase.scala
0.00% <0.00%> (-89.16%)
:arrow_down:

...cala/org/apache/kyuubi/sql/zorder/ZorderBase.scala
0.00% <0.00%> (-87.50%)
:arrow_down:

.../kyuubi/sql/zorder/OptimizeZorderCommandBase.scala
0.00% <0.00%> (-81.82%)
:arrow_down:

...yuubi/sql/zorder/OptimizeZorderStatementBase.scala
0.00% <0.00%> (-71.43%)
:arrow_down:

...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala
0.00% <0.00%> (-69.57%)
:arrow_down:

...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala
0.00% <0.00%> (-32.36%)
:arrow_down:

...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala
0.00% <0.00%> (-30.19%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d68b2...0b07b6e. Read the comment docs.

Thanks, merging to master


Improve performance

55% speedup on Lua (5.2.4)
33% speedup on LuaJIT (2.1.0-beta2)
27% speedup on Node (v7.9.0)

Interesting! I'd like to take a closer look at this one.

Sure! There are two reasons it's faster.

It adds only one environment frame per let. (Current Lumen adds a frame for each binding via let-symbol)

It expands each form within a let exactly once. (Current Lumen expands each (let-symbol ...) statement, whose expansion is then expanded again in expand-macro.)

The only other unexpected behavior is that it no longer calls (setenv id :variable) for each renamed id:
> (let (a 1
        b (+ a 2)
        c (when-compiling (print (str (tl environment)))))
    (when-compiling (print (str (tl environment))))
    (list a b))
((a: (symbol: "_a12") b: (symbol: "_b14")))
((b: (symbol: "_b14") a: (symbol: "_a12") c: (symbol: "_c20")))
(1 3)

It's easy to re-add that feature, though.
One minor benefit of not adding a :variable entry for each renamed let binding is that (compile-file "compiler.l") will cause the top-level environment frame to contain entries for all define/define-global forms, but not any intermediate forms , e.g. __x73 (a temporary variable created during the definition of infix).


Why downstream_cx_active is a Gauge metric and downstream_cx_total Counter?

How it comes that downstream_cx_active can be higher than downstream_cx_total?
According to https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/stats, total should be the sum of all connections, and active should be just the active ones.
In my example downstream_cx_active is showing 2k active connections, but rate of downstream_cx_total is like ~3 connection per second.
What's the general idea behind these two metrics exposed by Envoy and how do you monitor it?

I think this is completely normal the rate of new connections to be lower than the active ones (as new connections come and go).
If you look just at the downstream_cx_total (without a rate function) what is the value?

downstream_cx_total is ~2mil.
I was confused as I haven't realised new connections "come and go" that quickly. Thanks!


Separate different steps by tabs

To use tabs to make it simpler and show other settings in tabs.
E.g., iacs-ipac-reader  that uses Qt widgets instead of napari's magic


Ollama chat API output consistently missing <tool_call>

What is the issue?
When using adrienbrault/nous-hermes2pro-llama3-8b over the OpenAPI compatible API, I am always able to see <tool_call> and </tool_call> in the output, while I never see them when using the Ollama API.
The messages to reproduce:
const messages = [
    {
        "role": "system",
        "content": "You are a function calling AI model.\nHere are the available tools:\n<tools>\n[\n  {\n \"name\": \"search_10q\",\n \"description\": \"search_10q(data) - Useful to search information from the latest 10-Q form for a\\n    given stock.\\n    The input to this tool should be a pipe (|) separated text of\\n    length two, representing the stock ticker you are interested and what\\n    question you have from it.\\n\\t\\tFor example, `AAPL|what was last quarter's revenue`.\",\n \"parameters\": {\n \"title\": \"search_10qSchema\",\n \"type\": \"object\",\n \"properties\": {\n \"data\": {\n \"title\": \"Data\"\n        }\n      },\n \"required\": [\n \"data\"\n      ]\n    }\n  },\n  {\n \"name\": \"search_10k\",\n \"description\": \"search_10k(data) - Useful to search information from the latest 10-K form for a\\ngiven stock.\\nThe input to this tool should be a pipe (|) separated text of\\nlength two, representing the stock ticker you are interested, what\\nquestion you have from it.\\nFor example, `AAPL|what was last year's revenue`.\",\n \"parameters\": {\n \"title\": \"search_10kSchema\",\n \"type\": \"object\",\n \"properties\": {\n \"data\": {\n \"title\": \"Data\"\n        }\n      },\n \"required\": [\n \"data\"\n      ]\n    }\n  },\n  {\n \"name\": \"get_stock_fundamentals\",\n \"description\": \"get_stock_fundamentals(symbol: str) -> dict - Get fundamental data for a given stock symbol using yfinance API.\\n\\nArgs:\\n    symbol (str): The stock symbol.\\n\\nReturns:\\n    dict: A dictionary containing fundamental data.\\n        Keys:\\n            - 'symbol': The stock symbol.\\n            - 'company_name': The long name of the company.\\n            - 'sector': The sector to which the company belongs.\\n            - 'industry': The industry to which the company belongs.\\n            - 'market_cap': The market capitalization of the company.\\n            - 'pe_ratio': The forward price-to-earnings ratio.\\n            - 'pb_ratio': The price-to-book ratio.\\n            - 'dividend_yield': The dividend yield.\\n            - 'eps': The trailing earnings per share.\\n            - 'beta': The beta value of the stock.\\n            - '52_week_high': The 52-week high price of the stock.\\n            - '52_week_low': The 52-week low price of the stock.\",\n \"parameters\": {\n \"title\": \"get_stock_fundamentalsSchema\",\n \"type\": \"object\",\n \"properties\": {\n \"symbol\": {\n \"title\": \"Symbol\",\n \"type\": \"string\"\n        }\n      },\n \"required\": [\n \"symbol\"\n      ]\n    }\n  },\n  {\n \"name\": \"get_financial_statements\",\n \"description\": \"get_financial_statements(symbol: str) -> dict - Get financial statements for a given stock symbol.\\n\\nArgs:\\nsymbol (str): The stock symbol.\\n\\nReturns:\\ndict: Dictionary containing financial statements (income statement, balance sheet, cash flow statement).\",\n \"parameters\": {\n \"title\": \"get_financial_statementsSchema\",\n \"type\": \"object\",\n \"properties\": {\n \"symbol\": {\n \"title\": \"Symbol\",\n \"type\": \"string\"\n        }\n      },\n \"required\": [\n \"symbol\"\n      ]\n    }\n  }\n]\n</tools>\n\nPlease use <scratchpad> XML tags to record your reasoning and planning before you call the functions as follows:\n<scratchpad>\n{step-by-step reasoning}\n</scratchpad>\nFor each function call return a json object with function name and arguments within <tool_call> XML tags as follows:\n<tool_call>\n{\"arguments\": <args-dict>, \"name\": <function-name>}\n</tool_call>"
    },
    {
        "role": "user",
        "content": "Your task is to Extract key financial data and ratios from NVDA's SEC filings."
    }
];

I have sample code to reproduce this issue in the following repository: https://github.com/adrienbrault/h2p-l8b-bug
$ ollama -v ; bun run index.ts
ollama version is 0.1.37
{
  endpoint: "http://ai-mbp-14:11434/v1/chat/completions",
  model: "adrienbrault/nous-hermes2pro-llama3-8b:q8_0",
  content: "\n<scratchpad>\nFirst, I will use the `search_10k` function to search for information from the latest 10-K form of NVDA. Then, I will look up their most recent quarterly report using the `search_10q` function. Finally, I will gather more detailed fundamental data about NVDA using the `get_stock_fundamentals` function. For this purpose, I need to have an API key for Yahoo Finance to access the yfinance package.\n</scratchpad>\n\n<tool_call>\n{\"arguments\": {\"data\": \"NVDA|what was last year's revenue\"}, \"name\": \"search_10k\"}\n</tool_call>\n<tool_call>\n{\"arguments\": {\"data\": \"NVDA|what was last quarter's revenue\"}, \"name\": \"search_10q\"}\n</tool_call>\n<tool_call>\n{\"arguments\": {\"symbol\": \"NVDA\"}, \"name\": \"get_stock_fundamentals\"}\n</tool_call>",
}

{
  endpoint: "http://ai-mbp-14:11434/api/chat",
  model: "adrienbrault/nous-hermes2pro-llama3-8b:q8_0",
  content: "\n<scratchpad>\nTo extract key financial data and ratios from NVDA's SEC filings, I will follow these steps:\n\n1. Search for the latest 10-Q form filed by NVDA.\n2. Use the information found in the 10",
}

OS
macOS
GPU
Apple
CPU
Apple
Ollama version
0.1.37

Whoops, my code had an issue 🤦♂


url in README.md

Hello,
the README.md says:
<EMAIL_ADDRESS>(...)
- **url**: Cloud Optimized GeoTIFF URL. **REQUIRED**

I don't quite get where and how the url and the rest of the parameters are specified. Could you provide a specific example?
By the way, the tool seems awesome thanks :)

thanks for the issue @jsga
All parameters after ext must be passed as queryStrings e.g
:endpoint:/v1/{z}/{x}/{y}@{scale}x.{ext}?url=my.tif&rescale=1,2000
I'll update the documentation 🙏


Fixed bugs with Hive conversion Validation job, did code cleanup in Hive JDBC connector, removed an unusable buggy query implementation

Fixed bugs with Hive conversion Validation job, did code cleanup in Hive JDBC connector, removed an unusable buggy query implementation

Minor change, self approving.


Consistent frontend design

Is your feature request related to a problem? Please describe.
A consistent frontend design, major refactor of UI components making them easy to grasp and
contribute as the code now is a bit messy.
Describe the solution you'd like
We would like to use antd's dashboard solution for enterprises, that comes with a predifined layout.
Additional context
Any one of these layouts will be perfect. "https://ant.design/components/layout/"

@Harkishen-Singh Should we go for ant-design or Patternfly

@aquibbaig, we are already using reactstrap which uses bootstrap components. That makes the ui fairly light. So, we should keep things close to this. yeah, we can go with ant or patternfly but things should be in material fashion and where ever applicable, use the reactstrap first since it is simple bootstrap.

@Harkishen-Singh Patternfly is no doubt good but lacks community(hence buggy). Ant-design is way more stable.

@Harkishen-Singh Mixing two components aren't a great idea if required will replicate from either libraries

@vattytrivedi sure. That would be best to reduce redundancy. For now, let's stick to reactstrap as it is simple and based on bootstrap, so would be easier for the contributors. Is that okay? @aquibbaig

@Harkishen-Singh Reacrstrap +1

The current v1.1 looks great to the eyes along with the consistency. Hence, closing. If any views, feel free to open again.


Fix Pacdot locations

The pacdot locations were changed to SFU Burnaby for today's testing; they need to be changed back to Downtown Vancouver for the actual play in September.

Completed in above-referenced commit.


Font size is different on Physical Device and  Simulator/Emulator

Steps to Reproduce
After building the project and install it on a physical device (iPhone 7, XR and XR MAX), I realized that font size is different.
Expected results:
Same font size on device and simulator.
Actual results:

Font size is bigger on an iPhone 7 (and XR):

Font size is smaller on an iPhone XR Max:

flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.4 19E287, locale en-US)
• Flutter version 1.12.13+hotfix.9 at /Users/peruho/Developer/flutter
• Framework revision f139b11009 (4 weeks ago), 2020-03-30 13:57:30 -0700
• Engine revision af51afceb8
• Dart version 2.7.2
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/peruho/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4.1, Build version 11E503a
• CocoaPods version 1.9.0
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.9.1
[✓] Connected device (3 available)
• No issues found!

Hi @peruho
could you please provide a reproducible code sample
and the ios version of the affected devices
thank you

Sure, this code inside a CupertinoApp should do the work.
import 'package:flutter/cupertino.dart';

class FontSizeTest extends StatelessWidget {
  const FontSizeTest({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CupertinoPageScaffold(
      backgroundColor: Color.fromRGBO(247, 118, 86, 1),
      child: Padding(
        padding: const EdgeInsets.symmetric(vertical: 100.0, horizontal: 38.0),
        child: Text(
          "Gaze at this sentence for just about sixty seconds and then explain what makes it quite different from the average sentence.",
          style: TextStyle(
            fontFamily: 'Brown',
            fontWeight: FontWeight.bold,
            fontSize: 24,
            height: 1.3,
            color: CupertinoColors.black,
          ),
        ),
      ),
    );
  }
}

On the simulator is rendering ok, but on the device looks like its 27px. It's keeping the line height tho.

Please help.  text style on iPhone devices is not matching simulator or Android device. ( I have tried both iOS 13.7 and 14.1 both have this issue )
This font size issue still exists.  Not only is there a difference between iOS Simulator and physical iOS device but between iOS device and Android device as well.  Below examples were created using the flutter "Get Started" example.  For the Text widgets in the column body I am using TextStyle() which differs from the original code from Flutter.

Sample code:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text('You have pushed the button this many times:',
                style: TextStyle(
                  fontSize: 15,
                  fontWeight: FontWeight.w800,
                )),
            Text('$_counter',
                style: TextStyle(
                  fontSize: 11,
                  fontWeight: FontWeight.w600,
                )),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

Doctor version data
[✓] Flutter (Channel dev, 1.24.0-7.0.pre, on Mac OS X 10.15.7 19H2 darwin-x64, locale en-US)
    • Flutter version 1.24.0-7.0.pre at /Users/tawilson/development/flutter
    • Framework revision a0860f6e87 (11 days ago), 2020-10-29 20:07:34 -0700
    • Engine revision 073263e39d
    • Dart version 2.11.0 (build 2.11.0-260.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/tawilson/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/tawilson/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.51.0)
    • VS Code at /Users/tawilson/Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • SM S367VL (mobile)     • 520087f159ef55db                     • android-arm • Android 8.0.0 (API 26) (emulator)
    • iPhone 11 Pro (mobile) • 4BA1D14F-3D91-498C-8A44-C92284ED3FDF • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-1
      (simulator)

• No issues found!

Should I add code to determine OS and adjust font size accordingly?

Preview

code sample
import 'package:flutter/cupertino.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      title: 'Cupertino App',
      home: FontSizeTest(),
    );
  }
}

class FontSizeTest extends StatelessWidget {
  const FontSizeTest({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CupertinoPageScaffold(
      backgroundColor: Color.fromRGBO(247, 118, 86, 1),
      child: Padding(
        padding: const EdgeInsets.symmetric(vertical: 100.0, horizontal: 38.0),
        child: Text(
          "Gaze at this sentence for just about sixty seconds and then explain what makes it quite different from the average sentence.",
          style: TextStyle(
            fontFamily: 'Brown',
            fontWeight: FontWeight.bold,
            fontSize: 24,
            height: 1.3,
            color: CupertinoColors.black,
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.419, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.419 at /Users/tahatesser/Code/flutter_master
    • Framework revision 913d5933c1 (4 hours ago), 2021-01-19 22:34:03 -0800
    • Engine revision b58dbc88fc
    • Dart version 2.12.0 (build 2.12.0-240.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

Preview

code sample
import 'package:flutter/cupertino.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      title: 'Cupertino App',
      home: FontSizeTest(),
    );
  }
}

class FontSizeTest extends StatelessWidget {
  const FontSizeTest({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CupertinoPageScaffold(
      backgroundColor: Color.fromRGBO(247, 118, 86, 1),
      child: Padding(
        padding: const EdgeInsets.symmetric(vertical: 100.0, horizontal: 38.0),
        child: Text(
          "Gaze at this sentence for just about sixty seconds and then explain what makes it quite different from the average sentence.",
          style: TextStyle(
            fontFamily: 'Brown',
            fontWeight: FontWeight.bold,
            fontSize: 24,
            height: 1.3,
            color: CupertinoColors.black,
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64 • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios           • iOS 14.3

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-2.0.pre.419, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.419 at /Users/tahatesser/Code/flutter_master
    • Framework revision 913d5933c1 (4 hours ago), 2021-01-19 22:34:03 -0800
    • Engine revision b58dbc88fc
    • Dart version 2.12.0 (build 2.12.0-240.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (4 available)
    • RMX2001 (mobile)     • EUYTFEUSQSRGDA6D          • android-arm64  • Android 10 (API 29)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS 14.3
    • macOS (desktop)      • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 87.0.4280.141

• No issues found!

The same applies to Android... font size is much smaller on the emulator...

@aleripe
Since iOS simulator and devices are the same resolutions, you can find the exact model as well
On Android, I have no physical devices from Pixel or Nexus but I managed to create a similar resolution emulator as my physical and we can see the difference on Android as well, Thanks

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (10 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86 • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios         • iOS 14.4

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-18.0.pre.124, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.124 at /Users/tahatesser/Code/flutter_master
    • Framework revision 0a4618943c (37 minutes ago), 2021-02-02 14:56:03 +0800
    • Engine revision bb2bbde4d0
    • Dart version 2.12.0 (build 2.12.0-279.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (4 available)
    • Android SDK built for x86 (mobile) • emulator-5554             • android-x86    • Android 10 (API 29) (emulator)
    • Taha’s iPad (mobile)               • 00008020-000255113EE8402E • ios            • iOS 14.4
    • macOS (desktop)                    • macos                     • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)                       • chrome                    • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

Hi, have you found a solution for this issues? Facing the same one iPhone vs Safari Emulator / Chrom Emulator.

Me to, in device the font is smaller than simulator

Would be interested in methods folks have taken to work with this reality. It's a pretty common annoyance I come across.

any solution?

We're facing the same issue.

Reproducible on stable 3.3. and master 3.7

simulator
Real device

flutter doctor -v (mac)
[✓] Flutter (Channel master, 3.7.0-3.0.pre.33, on macOS 12.6 21G115 darwin-arm64, locale en-IN)
    • Flutter version 3.7.0-3.0.pre.33 on channel master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (38 minutes ago), 2022-12-05 18:27:21 -0800
    • Engine revision a309d239c4
    • Dart version 2.19.0 (build 2.19.0-463.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly
      to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.55.20221129

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel stable, 3.3.9, on macOS 12.6 21G115 darwin-arm, locale en-IN)
    • Flutter version 3.3.9 on channel stable at /Users/mahesh/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (24 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc4
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 61.2.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.53.20221101

[✓] Connected device (3 available)
    • iPhone 12 Pro (mobile) • 026D5789-9E78-4AD5-B1B2-3F8D4E7F65E4 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

im expecting the exact same issue. is there any fix?

I am also facing the same issue, has anybody found any solution?

I am seeing different font sizes from the iPhone simulator to the Pixel emulator.
Both have the same typography configuration and textScaleFactor. The display density differs (3 for the iPhone and 2.75 for the Android), but AFAIK this should make the text wider and wrap to a second line.

I created this ticket 3 years ago. It's one of the reasons I'm not using Flutter anymore.
...and still is not fixed!!!!!!
It's great I didn't wait and moved on XD

I created this ticket 3 years ago. It's one of the reasons I'm not using Flutter anymore. ...and still is not fixed!!!!!!
It's great I didn't wait and moved on XD

What are you using now? It might be interesting... 😆

Still facing this nearly  4 years after this issue was first opened


Editing a variable sometimes updates other variables with the same name

Bug Report 🐛
In some cases, editing one variable would edit another variable making it impossible to distinguish them.
Expected Behavior
Update to a variable should be propagated to the same variable in other places in the document, but not to different variables.
Steps to Reproduce
Example with the copyright license template:

Both licensor and licensee variables have type AccordParty which seems to confuse the algorithm responsible for propagating variable changes.

Interesting. What does the CiceroMark look like? I think the editor just uses the variable name from the CiceroMark node.

Model:
asset CopyrightLicenseContract extends AccordContract {
  /* the effective date */
  o DateTime effectiveDate

  /* licensee */
  o AccordParty licensee
  o String licenseeState
  o String licenseeEntityType
  o String licenseeAddress

  /* licensor */
  o AccordParty licensor
  o String licensorState
  o String licensorEntityType
  o String licensorAddress
...

CiceroMark:
        {
          "$class": "org.accordproject.ciceromark.Variable",
          "value": ""Me"",
          "name": "partyId",
          "elementType": "String"
        },
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": " ("Licensee"), a "
        },
        {
          "$class": "org.accordproject.ciceromark.Variable",
          "value": ""NY"",
          "name": "licenseeState",
          "elementType": "String"
        },
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": " "
        },
        {
          "$class": "org.accordproject.ciceromark.Variable",
          "value": ""Company"",
          "name": "licenseeEntityType",
          "elementType": "String"
        },
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": " with offices located at "
        },
        {
          "$class": "org.accordproject.ciceromark.Variable",
          "value": ""1 Broadway"",
          "name": "licenseeAddress",
          "elementType": "String"
        },
        {
          "$class": "org.accordproject.commonmark.Text",
          "text": ", and "
        },
        {
          "$class": "org.accordproject.ciceromark.Variable",
          "value": ""Myself"",
          "name": "partyId",
          "elementType": "String"
        },

...
So yes something is going very wrong in the CiceroMark there, there is no licensee or licensor.
This issue should probably be pushed down to the markdown-transform.
This is quite likely a common idiom.

I see - so we need to distinguish between the name of the field to be updated when editing, and the name of the variable in the model (field name in the owning type). For complex types, those are two different things.
Perhaps we should set elementType in the CiceroMark for this example to AccordParty and the name should be licensee -- it is then up to the editor/transformation to decide on the best way to edit or render the complex type (e.g. we could use a popup with Concerto form for some complex types). In the default case that means editing or rendering the identifier (String).
We will need to distinguish between --> AccordParty and AccordParty because we would use different editors for those.

I'm confused why they're both partyId in this CiceroMark.

I see - so we need to distinguish between the name of the field to be updated when editing, and the name of the variable in the model (field name in the owning type). For complex types, those are two different things.
Perhaps we should set elementType in the CiceroMark for this example to AccordParty and the name should be licensee -- it is then up to the editor/transformation to decide on the best way to edit or render the complex type (e.g. we could use a popup with Concerto form for some complex types). In the default case that means editing or rendering the identifier (String).
We will need to distinguish between --> AccordParty and AccordParty because we would use different editors for those.

But the variable partyId is of type String. I fear this will make pop ups difficult to handle.
Also, how would that work when a type has multiple variables (e.g., an Address)?

I'm confused why they're both partyId in this CiceroMark.

Because this is the name of the variable for both the licensor and the licensee (both contain an AccordParty, and each AccordParty has a partyId).

Here is the same issue with the rental agreement with a RentalParty containing both a partyId and an address

Also see: https://github.com/accordproject/web-components/issues/175

@jeromesimeon @dselman @irmerk
https://github.com/accordproject/web-components/blob/8e39155f3c39909867303ac1b399136aafe93028/packages/ui-contract-editor/src/ContractEditor/plugins/withClauses.js#L98
I did some research and found that line 98-123 may be the reason for this issue. The link is mentioned above. I commented out the lines and built the package and here is the result
https://www.loom.com/share/20d463568c614497a5ec21ddec286cd0
So can we go with this approach?

@dselman @irmerk @jeromesimeon
The main difficulty which we face here as I can understand is unable to differentiate the complex data type fields which are converted into fields with the same name. I was able to come up with two solutions:

If we have complex field types then can we start naming them as name-${i} where ${i} is the index of how many such fields already exist. Basically, it will distinguish them.
Another is when we load a template, all the variables can be provided with an arbitrary field say customName which will hold unique ids. In this way variables that have the same names like Random and Random can have id=uhasfn1 and then apply that algorithm which was used to change the variables based on variable[0].data.name to this field.

One drawback in 2nd is that I don't know whether more than different variables can have the same field.
Basically, two different persons having the same name in the same clause template can cause an issue.

@jeromesimeon @dselman @irmerk
Any thoughts on the above approach?

hi @K-Kumar-01 I think we can distinguish between those variables using the context: In the example above:
Is the partyId simple variable inside the tenant complex variable or inside the landlord complex variable.
I believe the Slate Document Object Model will contain that context (to be confirmed).

I'm making an Issue in markdown-transform and tagging you @jeromesimeon to possibly add additional context.

I'm making an Issue in markdown-transform and tagging you @jeromesimeon to possibly add additional context.

I think it could be entirely done in the web components. What's the reason this is better to do in the markdown transform?

Alright, I was just going off of your https://github.com/accordproject/web-components/issues/197#issuecomment-694906191 here :

This issue should probably be pushed down to the markdown-transform.

Alright, I was just going off of your #197 (comment) here :

This issue should probably be pushed down to the markdown-transform.

I realise I've am splendidly inconsistent here. But I think the crux of this is how do you know the scope of a variable and we could attempt to fix it either upstream (in the markdown transform) by having "names" be really keeping track of the context where they are used, or by making the logic which links variables together in the editor smarter.
The former approach is much more costly, so I'm wondering if someone would be interested in attempting the latter. I think mostly it would be to update the following logic in the editor itself:
https://github.com/accordproject/web-components/blob/0667d024f07bc6b4293589047c4ad6851eb73bcf/packages/ui-contract-editor/src/ContractEditor/plugins/withClauses.js#L98

@jeromesimeon

The former approach is much more costly, so I'm wondering if someone would be interested in attempting the latter. I think mostly it would be to update the following logic in the editor itself:

The approach where we see the logic solely depends on the field i.e. name.
So if two variables have the same name, it would be ineffective in my opinion. I think somehow we need to distinguish them, which is possible only either by providing a unique id.
I think for a temporary solution we can comment out the logic to avoid any confusion and look for a more suitable approach by having a thorough discussion on this.

@jeromesimeon

The former approach is much more costly, so I'm wondering if someone would be interested in attempting the latter. I think mostly it would be to update the following logic in the editor itself:

The approach where we see the logic solely depends on the field i.e. name.
So if two variables have the same name, it would be ineffective in my opinion. I think somehow we need to distinguish them, which is possible only either by providing a unique id.

I'm suggesting we could change that logic to not be based only on the variable name, but also on the context for it within the Slate DOM. Not sure why you believe it would be ineffective.

I think for a temporary solution we can comment out the logic to avoid any confusion and look for a more suitable approach by having a thorough discussion on this.

Removing the feature as "not working" isn't the worst idea. I would wait for feedback from @dselman on that, though, since he implemented that feature in the first place.

@jeromesimeon

I'm suggesting we could change that logic to not be based only on the variable name, but also on the context for it within the Slate DOM. Not sure why you believe it would be ineffective.

I apologize. I misunderstood the initial explanation, that's why I commented the above. I now understand the logic you are trying to say. I will see if I am able to find any suitable.


dynamic plugin score is abnormal

What happened?
applying score defaultWeights on Score plugins: plugin "Dynamic" returns an invalid score -8, it should in the range of [0, 100] after normalizing
What did you expect to happen?
pod can be scheduled successfully
How can we reproduce it (as minimally and precisely as possible)?
This problem occurs when the prometheus result times out, but the hotValue is normal.

returns an invalid score -8

@zwForrest
👍  It's a bug, we will fix it asap

have some progress？ @autumn0207

我也遇到这个问题

关注一下:)


Remove unused function for fuzzing

Remove unused function
Description
Remove unused function for fuzzing to fix CI

Codecov Report

Merging #475 (f568d55) into main (421e388) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   94.08%   94.39%   +0.30%
==========================================
  Files          65       65
  Lines        8569     8541      -28
==========================================
  Hits         8062     8062
+ Misses        507      479      -28

Impacted Files
Coverage Δ

math/src/fft/cpu/roots_of_unity.rs
100.00% <ø> (+30.76%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Lost Connection to Server

Thanks for the issue and not providing any usable information so I'll just give you a very commen awnser.
Your get request works but the websocked can't be established.


Allow sending types "as" other types

Currently, if we try to send say, an &str where the specification expects a String, we have to allocate a String in order to send it instead. This is somewhat un-ergonomic and forces the user to ignore certain Rust idioms if they need this use case with some kind of efficiency, because one can no longer pass around an &str instead of an &String for example.

This issue persists out-of-the-box with a fairly small class of types:

&str as String
&CStr as CString
&OsStr as OsString
&Path as PathBuf
&[T] as Vec<T> (for some restrictions on T, depending)

For all of these cases, the issue is that it is considered idiomatic Rust to pass around references when possible rather than dealing with the original, non-Copy type. But a Dialectic session type is highly unlikely to refer to the str or Path or [T] types rather than the String or PathBuf or Vec<T> types; which means that if a string slice is being passed around but a session type calls for a String, the &str must be copied into a newly allocated String. This is not only a performance issue but also unergonomic, although the argument can be made that if this is necessary, the user can just carry around an &String instead.
However, that makes little sense. The extra information afforded by &String over &str, &Vec<T> over &[T], etc. is strictly capacity information needed for modifying the buffer. Especially for these types, the wire format for each should be identical. Given this, there seems like a wider class of potential feature here: the ability to send some type T for a given type U which is in the session type specification, where we can be certain that T and U have the same wire format and that sending a T to be received as a U will, for some guarantee, result in an equivalent U on the other side.
Actually specifying this guarantee is nontrivial, but we can lean on a similar guarantee which is needed for Rust's HashMap. The std::borrow::Borrow trait mandates that if you have some type T which implements Borrow<U>, then Eq, Ord, and Hash must be equivalent for T and U; so, for some t1, t2: T, (t1 == t2) == (t1.borrow() == t2.borrow()), and similar for Ord and Hash. We could use Borrow, then, to express the relationship between a type which can be transmitted as equivalent to another type; for some T which may be transmitted as U, the result of sending some t: T over the wire and receiving it as a u: U must be equivalent when borrowed (t.borrow() == &u, and similar for Ord and Hash.) This is not perfect but it's about as close as we can get to saying "the values must come out identical."
It is not possible for a type T to be sent and correctly be guaranteed to come out the other end as a type U, without the backend knowing that it is a T being sent as a U. In particular, the mpsc backend will treat this as a mismatch between session types, and panic when it finds a Box<Any> containing a T rather than a U. It will have no way to do the conversion on its end; the conversion must be done during transmitting.
So given this, there are a few solutions that we've come up with so far:
1.) Mandate that for a specific set of special-cased types (str as String, [T] as Vec<T> for T: Clone) all backends implement this extra ergonomic nicety; encode it as a trait TransmittableAs; and then allow it to be known that for any backend which transmits, say, String, you must also be able to transmit a str and have it come out as a String on the other side.)
2.) Add a parameter U to the Transmit<T, Convention, U> trait, which is the type actually being transmitted. Accept the type U as the parameter to a send/send_ref call, and allow the backend to explicitly specify what types can be sent as what.
3.) Add an associated type ReceivedAs to the Transmit<T, Convention> trait. Ensure that for any given type T, there is exactly one type that it matches in the specification. For example, str would be Transmit<str, Ref, ReceivedAs = String> on a given backend. This has the upside that there is no need to specify what type is being received as what on a given backend-generic function. However, it destroys the ability to blanket-implement for a backend over all T, though there are some ways to get around this.
Each of these has its own advantages and drawbacks.
Option 1.) Mandate a specific set of special-cased types
This is the simplest option, and the easiest to deal with for Dialectic. We can do this by using a sealed trait which declares that all T can be sent as T, and then allowing the special cases to be sent where some U they are compatible with is present in the session type. This would be done by amending the types of Chan::send and Chan::send_ref. This works *only in the case where the types we're sending are !Sized and the types we're receiving are Sized; this is because in a case like the mpsc backend, a blanket impl over Transmit<T, Val> for all T: Sized types would allow implementing Transmit<str, Ref> as str being unsized is enough for Rust to declare the impls distinct.
This is also the nastiest option to deal with for backend implementors. All of a sudden, backend implementors have to be aware that if their backends are capable of sending a str (by reference of course) then that must be compatible. Though whether this is actually a problem is debatable.
Option 2.) Add a parameter to Transmit denoting receive-equivalence
This option is one of the two which allows a backend implementor to be aware of what type is being sent as what. This trivially fixes the issue with mpsc because now the mpsc backend can be aware that we're trying to send a str as a String, and perform the allocation before adding it to the queue. Unfortunately blanket impls are still out of the question.
This also allows backend implementors to specify their own receive-equivalent types. Whether this is a plus or a minus is up for debate.
Another downside of this option is that for backend-generic functions, this will have to be specified as part of the Transmit trait bounds and thus the Transmit attribute macro will need syntax for it. Regrettably.
Option 3.) Add an associated type to Transmit denoting receive-equivalence
Given this piece of toy code, Rust is happy with these two impls being distinct:
trait Transmit<T: ?Sized, Convention> {
    type ReceivedAs: Sized;
}

impl<T, Convention> Transmit<T, Convention> for () {
    type ReceivedAs = T;
}

impl<Convention> Transmit<str, Convention> for () {
    type ReceivedAs = String;
}

Modifying the send and send_ref methods becomes fairly simple with this, and it has the major upside(?) of ensuring that ANY type can only be sent in place of a single other type. As the ReceivedAs type is uniquely specified by T, Convention.
However, just like option 2, we'd need to add syntax to the Transmit macro.
Option 4.) Mandate that all Sized types are sendable as themselves, and give unsized types the ability to choose what they'll be sent as
As I was writing this, I came up with a middle ground between options 1 and 3.
The distinction between Sized and !Sized is enough for Rust to consider impls distinct for a blanket impl over T: Sized and specific impls where the same position T is unsized. For example:
trait Transmittable {
    type ReceivedAs;
}

impl<T: Sized> Transmittable for T {
    type ReceivedAs = T;
}

impl Transmittable for str {
    type ReceivedAs = String;
}

impl<T> Transmittable for [T] {
    type ReceivedAs = Vec<T>;
}

trait Transmit<T: ?Sized, Convention>
where
    T: Transmittable,
{
    // ...
}

This scheme would allow the Transmittable trait to remain open rather than being sealed, and specify behavior in the case that a backend is capable of sending these types, rather than mandate that a backend can send these types as other types. In addition, the trait remains open for any unsized types; every example given at the top of this writeup lists a reference to an unsized type which wants to be sent as a sized type. If the user has their own unsized types in the same vein (for example the bitvec crate's BitSlice type) then it becomes possible for them to define a Transmittable implementation custom-made for their type, e.g. impl Transmittable for BitSlice { type ReceivedAs = BitVec; }.
Option 5.) WONTFIX
Option number 5 is to do absolutely nothing. This isn't a horrible option to be honest; this basically only gives any sort of convenience when sending something like a slice where the receiver expects a vec, or similar.
Okay, so...?
Option number 4 seems like the best to me so far. It's simple, adds only one more trait which doesn't require adding extra syntax to the Transmit macro to generate bounds for it, and has a big default blanket implementation meaning that backend implementors don't actually need to do anything too special unless they want to support sending str as String and etc.
It would be a breaking change but if we're going to make a breaking change, now is the time as we're not coming close to a 1.0 release quite yet.


Do not do redundant extractions

In the interactive segment tubes module, everytime a spatial object is found, it is appended to the current output. This can lead to the same vessel being added multiple times to the spatial object.
This is probably will become a problem when measuring metrics on the spatial object. We
should find a way to "Clean" the spatial object from redundant points/vessels.

Since the TubeTk extract module optionally takes a mask as input  and outputs a new mask, this should be leveraged to speed up follow-up extraction.


Actually boot interface...

Looks like I overlooked the whole onlining the interface we're about to use


Move nfd image to quay under kubernetes

This PR is part of #74 .
This PR move default image for node-feature-discovery to quay.io under the namespace of kubernetes.
This PR should be accepted after #76
Note: This will need to contact the guys who have write access to quay.io/kubernetes.
.
/cc @ConnorDoyle @balajismaniam

Closing: 1) this patch is based on another PR which we already closed. 2) we don't want to host the image in the kubernetes org in quay.io until after graduation.

@ConnorDoyle What is the status about the graduation scheduler? or, what is the current step for NFD?

The opinion in SIG-node was inclined towards moving nfd under kubernetes-sigs instead of kubernetes  core. There's no schedule, yet. I think we need to do some homework (e.g. provide data on the benefits of nfd, possibly improving testing), after which we can bring this up to SIG-node, again.