{To,From}Avro (Either a b) are Left-biased when (a ~ b)

Avro does not distinguish between Left and Right branch
>>> toAvro (Left "str" :: Either Text Text)
Union (String :| [String]) String (String "str")

>>> toAvro (Right "str" :: Either Text Text)
Union (String :| [String]) String (String "str")

so converting back from Avro gives a Left regardless of the original constructor
>>> fromAvro (toAvro (Left "str" :: Either Text Text)) :: Result (Either Text Text)
Success (Left "str")

>>> fromAvro (toAvro (Right "str" :: Either Text Text)) :: Result (Either Text Text)
Success (Left "str")

I am not sure if it is incorrect though.
Avro specification defines union at a type level:

For example, ["null", "string"] declares a schema which may be either a null or string.

So from the Avro point of view you are saying "this type must be either String or String". Well, it is String, that's what Avro tells you in return.
More on that:

Unions may not contain more than one schema with the same type, except for the named types record, fixed and enum. For example, unions containing two array types or two map types are not permitted, but two types with different names are permitted. (Names permit efficient resolution when reading and writing unions.)

So having a union of ["string", "string"] doesn't seem to be complying to the specification.

That's a fine view but I would probably introduce a new type with the untagged-union semantics, I expect a tagged union when using Either.

Interesting. By "a new type with the untagged-union semantics" you mean your own record type in terms of Avro? I think it can be done on the client side, at least in the mean time.
I think this is not limited Either a a, many times mkUnion is used directly in the code and it currently has no checks for type uniqueness. Ideally it should be done at the compile time, but I don't know how :)
It is also the case of Either a a is not unique because nothing stops me to use Either a b where b is just a newtype for a deriving ToAvro, etc...

Should we close this issue?

Sure


skip ci for changelog changes

skip running our CI for CHANGELOG.md. this will become more useful as we move to a new unreleased section in the changelog which PR authors will add to :)
and remove edited PR trigger for semver checks

@nicklan did we previously learn that this needs to merge before the changes will propagate to CI configuration?

@nicklan did we previously learn that this needs to merge before the changes will propagate to CI configuration?

No, they should take effect here. It's just permissions that only apply against main

hmm it looks like it doesn't trigger but it invalidated the previous status for all the required checks....?

hmm it looks like it doesn't trigger but it invalidated the previous status for all the required checks....?

Try fixing the conflicts and see what happens

i hate to be the bearer of bad news but it seems this isn't working? looks like all the CI still ran on that last commit that only changes CHANGELOG

turns out github detects changes based on the entire diff of the PR not each commit so this becomes significantly harder now.. closing this and will open a follow-up that does some minimal CI improvements


contributing.md Capitalisation corrections

Description
Make Capitalisation of Bruno consistent with README.md and also make Pull Request plural to fit better gramatically.

Merged!
Thank you @IsaacHatton !


[WIP] New API alignment

Thank you for your contribution to MagicScript Project.
Before submitting this PR, please make sure:

[X] Your code builds clean without any errors or warnings
[X] You are using approved terminology
[X] You have added unit tests
[ ] You have updated documentation

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        45   +24
  Lines          226       274   +48
  Branches        19        19
=========================================
+ Hits           226       274   +48

Impacted Files
Coverage Δ

src/internal-properties.js
100.00% <ø> (ø)

src/properties-mapping.js
100.00% <ø> (ø)

src/components/circle-confirmation.js
100.00% <100.00%> (ø)

src/components/color-picker.js
100.00% <100.00%> (ø)

src/components/components.js
100.00% <100.00%> (ø)

src/components/content.js
100.00% <100.00%> (ø)

src/components/date-picker.js
100.00% <100.00%> (ø)

src/components/dropdown-list-item.js
100.00% <100.00%> (ø)

src/components/grid-layout.js
100.00% <100.00%> (ø)

src/components/image.js
100.00% <100.00%> (ø)

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f6de2...1c9000e. Read the comment docs.

@SPaluchiewiczSofomo so I'm looking at the code coverage and see that we don't include the types or util folders.  Can you add them in a follow up patch for coverage numbers.  I'm ok with coverage dropping since I don't know/expect them to be covered right now.


Use correct slashes on Windows

We need to translate relative paths like this for use on Windows. This should fix #328.

Just tested this in my VM, works a treat!


Questions in ICCV 2019 paper

Hi Pengpeng, nice work about optical flow estimation. Here are some questions.

 which described in Figure 2 notations can NOT be found in Figure 2. All the flow map shown in Figure 2 is w without head dot.  Same problem in Sec. 3.2.

No explaination about inital forward flow. Could you please explain it for readers?

It represents the initial flow, which is obtained by bilinear upsampling from flow estimeted in previous level. Please check PWC-Net for details, our network structure is built upon it.


Switch to token bucket rate limiter with better performance

The current token bucket implementation uses a ticker, which constantly consumes CPU, even at rest. This PR switches to an implementation that consumes no CPU at rest. The behavior is identical (bucket is initially filled to burst capacity and requests are smoothed).
Fixes #10445

LGTM

cc @davidopp @lavalamp for second LGTM, etcetc

Hm-- are people setting rate limits high enough that this is a problem in practice?

And in which binaries is it a problem?

Rates higher than 10/second have noticeable CPU usage  (several components set QPS of 20 by default), and when multiple clients are created, it causes issues (since the spawned tickers live forever, since clients don't surface a way to call Stop()).

OK. LGTM

@davidopp is sick; @quinton-hoole for ok-to-merge

Taking a look...

Are we OK taking on a whole new dependency by all our components on juju just before v1.0, and just for a more efficient rate limiter library?  How complex would it be to just improve our current rate-limiter implementation instead?
cc @thockin @bgrant0607 for their opinion

I tried tweaking the existing implementation first, but the ticker at the heart of it was the root cause of the CPU usage at rest... I could see deferring this post-1.0

(though the CPU impact can become significant with higher QPS... we were seeing 20%ish usage in a vagrant env at rest with no data loaded)

That's just horrible, and almost definintely needs to be fixed pre-v1.0.  The only question in my mind is whether we implement our own efficient rate limiter (which doesn't seem tremendously difficult), or take on the big juju dependency instead.  I'm leaning towards the former.

I was on the fence about this, too, the dependency seems overkill. But it is expedient, assuming it works.

I didn't enjoy the dep, either, FWIW, but it's tiny.

OK, lets merge this PR, and open a separate issue to remove the dependency.

LGTM


Python test 2024 (only for test)

Trigger SDK generation for https://github.com/Azure/azure-rest-api-specs/tree/feature/blob-tsp/specification/storage/Microsoft.BlobStorage

/azp run


[microTVM] Refactor uTVM to microTVM

This PR:

Rename all uTVM files and definitions to microTVM.

cc @areusch @gromero

Hi @mehrdadh Since I joined the project I was inclined to use (and tried to stick with) the form "uTVM". I have no strong feelings other than really sticking with only one form, hence I think that PR makes sense indeed (ppl might even write mTVM sometimes, which doesn't look good at all). I'm just wondering if I missed any discussion or thread about favoring microTVM. Either way I think using microTVM is the right choice, because uTVM is often written also using the mu symbol (Greek), which is confusing sometimes and might be difficult to write on some consoles. On Linux I also prefer typing "micro" instead of CTRL-Shift-u-b-5 :)

@gromero thanks for the feedback!
The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.
We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.
We could also CC people here and see if anyone has any suggestion.

CC @leandron @manupa-arm @guberti @Mousius @giuseros

The main reason as you mentioned is that "uTVM" is kinda confusing, specially for the people who are using it for the first time. And it's not really straightforward to write. It would be great if we unify it and make sure everyone is using the same brand.

Yeah, thanks for proposing that change.

We had some internal conversation, but we didn't have a community discussion about choosing a name, I guess mostly because I thought it's not a major change. However, we could post an RFC and ask for people's vote.

I asked just out of curiosity. I thought of a change like that just after I joined the project so I was wondering if I missed anything recently in the open so I could check it out curiosity. I really don't think it's necessary a RFC for that change.

This is a great improvement @mehrdadh, I agree microTVM is the most correct as I had similar feelings towards the awkwardness of µTVM -> uTVM (and µ broke one of my scripts :crying_cat_face:). Thanks for proposing this :smile_cat:
One small thing that follows on from @leandron's comment is that there are also some µs hiding in NEWS.md and CONTRIBUTORS.md

@leandron @Mousius thanks for pointing out those files. I fixed all of them.
We still have couple of µTVM and utvm in NEWS.md which are mentioning some PRs. I haven't changed those. Here is a list of them:

µtvm debug improvements #5648
µTVM CRT modifications for on-device RPC server #5921
AutoTVM + uTVM for Cortex-M7 (#5417)
uTVM support for ARM STM32F746XX boards (#4274)
[BUILD] Disable utvm standalone runtime by default (#4240)

We could also refactor these if someone with contributor access could help in renaming these PRs.

cc @hogepodge
It would be great to also reflect this PR in TVM doc. I'll be happy to do it if you could point me to where the do lives.
Thanks!


Java binding to JS instances

This is the inverse of the recent binding work. Basically type-safe Java interface methods to JS functions.
See original proposal in https://github.com/square/duktape-android/issues/29#issuecomment-161018302

cc @szurbrigg if you want to continue being a hero to this project :grinning:

Implemented!


Fix documentation

The documentation used to generate empty documents. Now it pulls the
things from matrix_client.
Signed-off-by: Olivier van der Toorn<EMAIL_ADDRESS>

see also #144 where I fixed a lot of issues with the docstrings themselves.


pivpn fails installing in Freenas Jail (freebsd)

I understand pivpn is designed for rpi, but since its so good and stable..  i was hoping to install it on freenas jail to over come the 100mbs limit on pi3b.
Please help if it's a relatively easy fix.
I logged into freenas jail as 'root' and changed to bash shell by typing bash at the prompt.
Here is the error i got and dont know how to process further.
How can i fix this and use pivpn as the wireguard server that is meant to run inside freenas?
----====
[root@wireguardvpn /]# curl -L https://install.pivpn.io | bash
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 162 100 162 0 0 173 0 --:--:-- --:--:-- --:--:-- 173
100 80405 100 80405 0 0 54883 0 0:00:01 0:00:01 --:--:-- 54883
:::
::: You are root.
main: line 254: /etc/os-release: No such file or directory
main: line 258: VER_MAP: bad array subscript
main: line 302: whiptail: command not found
[root@wireguardvpn /]#
----====

Sorry @krouter freenas is based on FreeBSD which is fundamentally different from Debian ... and would require us to develop a specific jail for it ... don't see us supporting it in any near future if ever ...
if you want a wireguard server running on FreeBSD you will have to look for it elsewhere ...
Colsing, feel free to re-open or comment if you wish :)


Add staff actions for rejecting and removing verification requests

This PR adds the ability to reject and remove verification requests submitted by users.

We would need to reject a request when we know the data definitely isn't valid. These currently stay in the users view, so they have a paper trail.
We would need to remove data when data might be correct, but it doesn't make sense to keep showing to a user. An example might be when a user has shared information for an existing provider and we have accepted it - the data was correct, we ended up using the information, and it's now used in the checks for a given provider, but it might no longer be necessary to show it to the user.

hi @tortila - would you cast a quick eye over this test, and if you're ok with it merge this change in?


Small Typo in C3W3_Assignment.ipynb

In the global variables markdown cell, OOV_TOKEN line, it should be written as:
Defaults to \"\<OOV>\".
There is an extra \ in the middle.

Thank you, Omar! Next time, you can also post feedback in the community for better visibility. There are instructions in Week 1 on how to join. Thanks again!


regress improvements

keeping delta would be nice, it provides much better context in the headers , maybe just disabling colors would be enough


[FEATURE] Adding RetinaNet to the models

Is your feature request related to a problem? Please describe.
This is to add RetinaNet model for object detection.
Describe the solution you'd like
Implementing RetinaNet in PyTorch.
Describe alternatives you've considered
Additional context

@AnimeshMaheshwari22 timm remains focused on backbone models with classification heads, and tools to help use them for feature extraction. timm models can be used as the backbone for a retinanet.  EfficientDet is the succesor to RetinaNet and I have a project that uses timm models https://github.com/rwightman/efficientdet-pytorch

Oh I understand. Thanks for the clarification.


Support for IOS

none()

The problem with iOS is that I'm unable to efficiently test, run and develop iOS code on Windows and I don't have a MacOS PC. I'm waiting for my new PC that maybe will allow me to run a high-performance virtual machine and then allow me to develop iOS code.

Replied in #16


python3Packages.python-telegram: fix build

Description of changes
Fix https://hydra.nixos.org/build/239153404
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266730 run on x86_64-linux 1

10 packages built:

python310Packages.python-telegram
python310Packages.python-telegram.dist
python310Packages.telegram-text
python310Packages.telegram-text.dist
python311Packages.python-telegram
python311Packages.python-telegram.dist
python311Packages.telegram-text
python311Packages.telegram-text.dist
tg
tg.dist

Result of nixpkgs-review pr 266730 run on x86_64-darwin 1

10 packages built:

python310Packages.python-telegram
python310Packages.python-telegram.dist
python310Packages.telegram-text
python310Packages.telegram-text.dist
python311Packages.python-telegram
python311Packages.python-telegram.dist
python311Packages.telegram-text
python311Packages.telegram-text.dist
tg
tg.dist


Upgrade CAN transceiver

Something like:
https://jlcpcb.com/partdetail/MicrochipTech-ATA6561_GAQWN/C616016

We might do this to get CANFD, but that's really not an issue for now. Labelling as an enhancement


Global browser objects should not be overwritten by locally declared variables

Describe the Issue
Image of the bug:
https://global.discourse-cdn.com/freecodecamp/original/4X/4/5/0/450b30022003aba1bf58cde0834180b757026b88.png

Go to step 52 https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-javascript-by-building-a-role-playing-game/step-52

Write the wrong code const location = [].

The locally declared variable should not overwrite the location property.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-javascript-by-building-a-role-playing-game/step-52
Your code

Expected behavior
Not to have a buggy state with double editors.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
Forum:
https://forum.freecodecamp.org/t/js-freecodecamp-bug-report/657713
https://forum.freecodecamp.org/t/server-error-in-javascript/659246
https://forum.freecodecamp.org/t/how-can-i-set-the-freecodecamp-coding-viewer-to-its-original-mode/659527

I believe this "bug" is because the global location object is overwritten. So, the window that runs the preview does not know what to point to.

I guess you are right.
const location = 'https://example.com';

How is a const declaration inside the editor overwriting the global object?

How is a const declaration inside the editor overwriting the global object?

Well, I suppose because it is just run/eval'd in the iframe. I suspect this is a quirk with global objects being references to something in global scope. So, provided location is declared globally, any reference to window.location will unfortunately point to this const location value.

Seems unexpected.
A variable declared using const should not be able to overwrite global objects. I would consider that a bug, not a quirk.
It should either be a syntax error (like it is in the browser console) or the editor code should be in its own scope and not leak. The fact that you can set the location object to whatever code you want from inside the editor seems bad.
Can we scope the editor code inside a code block or IIFE?

The issue fixed by rewriting the code const locations = [] but i dont know how it can manipulate main code.

Updated the initial post with yet another instance of this happening.
I can guarantee it will keep happening as people missing the "s" at the end of the variable name is inevitable. I would consider this a bug that should be fixed.

btw I didn't miss any s I'm so lazy on these that prefer copy past words instead of typing and getting typo error for a single dot.
anyways that unusual and must not happen it can also have security issue as well.

The problem is that Babel still converts const to var. var location = [] will send the preview to the current page, hence the nesting of the page.
This will, eventually, go away, but we could slightly restrict the browsers we support in the interim (currently it's >0.25% and a quick play on Babel's repl shows that >0.4% is enough)
Alternatively we could try and catch these specific errors before rendering the page. I feel like relaxing babel a bit might be the way to go, though.

I'm all for dropping browsers that do not support const and let.
Also, don't see already use other JS that wouldn't be supported by those browsers? Like optional chaining and the like?

Also, don't we already use other JS that wouldn't be supported by those browsers?

We also use Babel to transpile the tests before running them.

We also use Babel to transpile the tests before running them.

I guess we didn't used to do that? I swear we had an issue with optional chaining at one point caused by old browsers.
Found it
https://github.com/freeCodeCamp/freeCodeCamp/issues/45216

Anyway, I see no reason why we should support such old browsers. It doesn't seem worth it.

I guess we didn't used to do that?

I have not confirmed, but looking at build.ts, we might still not be transpiling the tests. So my earlier comment is probably wrong. We just transpile Camper code.

I'm surprised we use such an old target for the transpilation. I thought we generally didn't support unmaintained operating systems, devices, and browsers.

@ojeytonwilliams is there any issue with updating the target as you suggested? If not I would suggest we do so.

Bump. Looks like a PR is still in the works. Any updates on that @ojeytonwilliams?

Sorry, it involves changing quite a lot of tests and I haven't found the time to address them.


feat(TFD-1875): Use ACE editor on Sql definition

What is the current behavior? (You can also link to an open issue here)
jdbc component's sql query editor is textarea
What is the new behavior?
make it use ACE only for datastream, not studio and dataprep
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:
Sonar results


Remove legacy data fixes

These prison names were last changed in 2014, and we've checked the metrics and verified that these fixes are no longer used.
Whilst we may need to handle prison name changes in the future, we will do this in a better way than by dumping a hash of strings directly into the controller.

:pray:


Link TailwindCSS into the Svelte project for front-end styling.

Linked TailwindCSS into the Svelte project: 06be06323eba97c3108d645735450cefcdb7ce64


chore: use omega for linear arithmetic

Description of changes:
This PR updates the dependency on the Lean Standard Library to the latest version, and then uses the new tactic omega to handle all the proofs about inequalities in Nat and Int.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please feel free to accept or reject the various changes separately, as they should all be independent.

I love it!  Thank you @semorrison; this was one of my favorite tactics in Lean 3 😃


UnicodeEncodeError: 'shift_jis' codec can't encode character '\u90d5' in position 3: illegal multibyte sequence

Trying out QReader in my project, I discovered it fails to decode some QR codes and I'm not exactly sure why.
Here is an example of such QR code
It scans just fine with TeaCapps QR Reader app (the most popular one) on my Android phone.

I faced the same issue and need change code page from "shift_jis" to "cp65001". Seem need update interface of QRDecode that can provide alternative code page for encoding

Hi!
I have been trying to debug with this QR you it worked on my environment.
Which Python version are you using?
I'm testing on Python 3.9, and when decoding it gets me 'qr код' as when I test it . If I try to decode with "cp65001" as proposed by @nguyen-viet-hung above, it gets me 'qr ﾐｺﾐｾﾐｴ'.
But in any case it doesn't produce me the UnicodeEncodeError.
Could you get me more details about your environment?
If you can access to the source, does the solution proposed by @nguyen-viet-hung solves your problem (qreader.py, line 70)?
Thanks!

Hi,
My environment is Python 3.10, qreader 2.12 on Windows. I face same issue with @Arutemu64 when my QR contains Vietnamese. I tried with @Arutemu64 QR code with 'shift_jis' code page it gave also error: "UnicodeEncodeError: 'shift_jis' codec can't encode character '\u1ec5' in position 27: illegal multibyte sequence". So I think it depends on the system running.
@Eric-Canas

I have been testing @Arutemu64 's QR under python 3.10, also on Windows and gives me the same result ('qr код') than before. Could it be related with some internal locale configuration?
Could you share a Vietnamese QR that you know that produces the  "UnicodeEncodeError: 'shift_jis' codec can't encode character..." on your side?
@nguyen-viet-hung

Hi,
Here my sample QR code image. The content of QR is: "Tôi là Hùng. Đây là bản thử nghiệm để kiểm tra tính năng"

I have been testing with this QR. It also breaks on my side when running
decodedQR[0].data.decode('utf-8').encode('shift-jis').decode('utf-8')
But gives me the correct result just with:
decodedQR[0].data.decode('utf-8')
Could you confirm if it also happens on your side? Have you find any example that needs re-encoding to cp65001?
I did that re-encoding because I found this case

Which translated to: "BCD\n002\n1\nSCT\nRLNWATWW\nﾃвzte ohne Grenzen\nAT973200000000518548\nSpende\nSpende\nfﾃｼr MSF Nothilfe"
While the original text should be "'BCD\n002\n1\nSCT\nRLNWATWW\nÄrzte ohne Grenzen\nAT973200000000518548\nSpende\nSpende für MSF Nothilfe'
That's why I integrated this section:
try:
    return decodedQR[0].data.decode('utf-8').encode('shift-jis').decode('utf-8')
except UnicodeDecodeError:
    # When double decoding fails, just return the decoded string assuming it could have weird characters
    return decodedQR[0].data.decode('utf-8')

Where I should have also included the 'UnicodeEncodeError', but I did never found a case provoking it.
I would like to discover if there are cases where this update decodes incorrectly.
try:
    return decodedQR[0].data.decode('utf-8').encode('shift-jis').decode('utf-8')
except (UnicodeDecodeError, UnicodeEncodeError):
    # When double decoding fails, just return the decoded string assuming it could have weird characters
    return decodedQR[0].data.decode('utf-8')

But anyway, I'll add that 'shift-jis' as an input parameter on the init.
@nguyen-viet-hung

Hi,
As I tested with your QR, it gave the result as you mentions. and for my case, can use only .decode('utf-8') and it gave correct result. After checking for the while, I found the mention of code page here. cp65001 is utf-8, then for some languages (Japanese, Chinese, Arabic ...), they need re-encode and decode as you do in the code.
Before we can find an universal solution, should make encoding code-page as parameter as you do.
@Eric-Canas

Sure, I have included that parameter by the moment. You can upgrade it with pip install --upgrade qreader
And instantiate the QReader object as QReader(reencode_to='cp65001')
By default it re-encodes to shift-jis, just to avoid messing anything with current implementations, but you can set reencode_to=None and it will just do the one-step 'utf-8' decoding. Anyway, if it triggers a UnicodeEncodeError, or an UnicodeDecodeError, it will fallback to utf-8, so if utf-8 worked for you, you don't really need to change anything.
Thanks a lot for your help @nguyen-viet-hung .
@Arutemu64 , your problem should be solved with this update.
Thanks!

Hi @Arutemu64
You can use the update that @Eric-Canas has published or try installing extra package ebcdic and re-test with current version of qreader to see if it works.
pip install ebcdic


Interleaved Model for combined_loader

Description & Motivation
Description: A mode for combined_loader which would evenly distribute samples from all iterables.
Motivation: While working with cycle consistency training, two models are updated iteratively on the output of the other model. The current modes for combined_loader do not train these models optimally:
min_size: Wastes valuable data from larger dataset
max_size: One model is trained on the static state of the other, causing it to overfit to an old model state
max_size_cycle: May cause overfitting on smaller dataset if dataset sizes are significantly different
sequential: Same problem as max_size but worse
Pitch
Interleaved mode which calculates how to evenly distribute one dataset with the other. This comes with the caveat of knowing the lengths of each iterable which may not be possible.
e.g.
iterables = {'a': DataLoader(range(5), batch_size=1),
             'b': DataLoader(range(3), batch_size=1)}
combined_loader = CombinedLoader(iterables, 'interleaved')

for batch in combined_loader;
    print(batch)
# {'a': tensor([0]), 'b': tensor([0])}
# {'a': tensor([1]), 'b': None}
# {'a': tensor([2]), 'b': tensor([1])}
# {'a': tensor([3]), 'b': None}
# {'a': tensor([4]), 'b': tensor([2])}

Alternatives
No response
Additional context
I don't believe the __len__ issue would be too damaging as pytorch dataloaders implement a __len__ method. Obtaining iterable lengths will get stuck on infinite iterables but lengths could otherwise be obtained with:
sum(1 for _ in iterable)

cc @borda

Is there any update on this?

As I never got a response, I assumed it was not something that was really wanted or was too small a feature to spend development time and effort on. I have been too occupied with other work since making this feature request so I haven't gotten around to it. If I ever implement it, I'll update here.


[Alpha Update] Support for Wallet Events!

Hi!
Here I have stumbled on event but can not find more info and source of this information
Can you help with example code and best approach to build payment gateway for shimmer native tokens?
https://discord.com/channels/397872799483428865/399178054909296640/1201844805093818369
Thank you!

hi we have put up examples on wallet events subscriptions.
https://github.com/IOTA-NET/IotaSDK.NET/blob/main/IotaSDK.NET.Main/Examples/Events/Subscribe To Events/README.md
For your question regarding building a payment gateway, better to discuss it in discord with others.


Contribute: bugfixes release38

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes.
What is the current behavior? (You can also link to an open issue here)

Segment can get stuck highlighted as next (reactivity bug).
The indicator for a queued segment does not get shown if the currently on-air segment is queued.
The queued segment doesn't get cleared when deactivating.
The queued segment doesn't get cleared if the queued segment is set as next.
The on-air segment can be hidden if blueprints return an empty array of parts (e.g. the segment is "floated" in an NRCS while on-air).
A "missing media" notification may be shown for a media item while scrolling through a rundown due to a bug where the piece has been loaded, but the package / media object has not.
Deleting a part that is in next does not remove the part instance in next (a bug from TV 2's perspective).

What is the new behavior (if this is a feature change)?

All bugs above have been fixed
When the part in next is deleted, a blueprint function shouldRemoveOrphanedPartInstance will be called to check whether the part instance associated with that part should be deleted. This allows blueprints to control when an orphaned, next, part instance should be deleted. This method is optional, if not implemented in blueprints then the current behaviour will be used (the part instance will not be deleted).

Other information:
Status

[X] Code documentation for the relevant parts in the code have been added/updated by the PR author
[X] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

@thomasslee97 Before we get to do a proper review, I can already point you towards fixing this: https://github.com/nrkno/tv-automation-server-core/runs/4549682600?check_suite_focus=true

@Julusian, FYI, more fixes for the live segment hiding issue are coming soon

@Julusian, FYI, more fixes for the live segment hiding issue are coming soon

OK, let me know when you are happy for me to review your additions

The fixes related to queued segment introduce a regression that can be reproduced with these steps:

Queue a segment X
Jump around using Move Next triggers (F9, F10...).
If you hit segment X, it will be unqueued due to being set as next, no matter if you take it or not.

Before, you could freely move next with the shortcuts, and retain the queued segment.
Does that break anything for NRK?

Before, you could freely move next with the shortcuts, and retain the queued segment. Does that break anything for NRK?

I don't think this will be an issue for us. We rarely use that feature, and the consequences are mild since one can just re-queue the segment if needed.

@ianshade please open a new pr for any additional fixes. probably targetting r39, unless there are major issues found in r38


chore(state): implement diff for StateMaps

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.04%. Comparing base (35f1ee8) to head (088b449).

Additional details and impacted files
@@                                Coverage Diff                                 @@
##           yoni/cached-state/strict-subtract-for-compiled    #1910      +/-   ##
==================================================================================
- Coverage                                           78.04%   78.04%   -0.01%
==================================================================================
  Files                                                  61       61
  Lines                                                8756     8754       -2
  Branches                                             8756     8754       -2
==================================================================================
- Hits                                                 6834     6832       -2
  Misses                                               1483     1483
  Partials                                              439      439

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


VRM Export: Multiple materials with no texture + transparent texture exports invisible asset

1242: seems that the horns become transparent in the exported vrm
invisible-horns-1242.zip

The horns do not have a texture, it's just base color white.
1535: horns in visible in vrm
invisible-horns-1535.zip

I tried debugging this but I can't help because I can't even reproduce a VRM with this issue.
I downloaded the horns, stripped away the skeleton and exported it clean as GLB. Then I applied it to a VRM0 skeleton and exported a new VRM that would work.
For VRM0, the VRM is straight up broken.

This is pretty common though. Any VRM0 that's exported with at least one mesh that has no texture will be completely broken, that's a bug and I'm not sure if there is a ticket for it on Github.
Now, I went ahead and tried to do the same on the drophunter since the drophunter avatar is a VRM1.
I export a new Drophunter avatar with the horns and open it on Blender. This time I'm seeing the avatar in blender, but it comes alongside to this error:

so I'm not sure if it's because I have a bad Horn.vrm or if it's something else that's different.
FYI, I can open your 1535 avatar vrm with no errors

fixed in #148


Isn't the [generous] 100MB limit/quota for message only for PREMIUM tier of Service Bus? and "Standard" only 256KB? Microsoft.ServiceBus.Messaging.QuotaExceededException

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cfacc7cf-4224-9bd8-6211-29244cf60a83
Version Independent ID: a940a6f2-e1a9-d32b-4303-ab7705753942
Content: Azure Service Bus - messaging exceptions - Azure Service Bus
Content Source: articles/service-bus-messaging/service-bus-messaging-exceptions.md
Service: service-bus-messaging
GitHub Login: @spelluru
Microsoft Alias: spelluru

Hello @starinskyn-fbb - Thanks for your feedback! You're right that the message size limit is either 256KB with Standard SKU or 100MB with Premium SKU but the 1GB limit shown in the example Exception on this doc is for the Queue or Topic size, which can be 1, 2, 3, 4 or 5GB  (Defined upon creation/updation of the queue or topic). The doc state the following right below the example:

The message states that the topic exceeded its size limit, in this case 1 GB (the default size limit).

For more, please refer to Messaging quotas and let me know any questions.

@starinskyn-fbb The doc author, @spelluru, has updated this with the info: https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messaging-exceptions#quotaexceededexception
Thanks again for sharing this feedback and helping us drive improvements toward the MS Docs!
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Safari detection is broken in Safari Technology Preview

The following is currently used to detect Safari:
/Constructor/.test(window.HTMLElement)
as per:
https://github.com/conditionizr/conditionizr/blob/master/detects/safari.js
However, it does not work in the Safari Technology Preview which now behaves like other browsers in this respect. You can download Safari Technology Preview at:
https://developer.apple.com/safari/download/

So this detection mechanism works until Safari 9.x but will likely break in the next major Safari release.

Currently, safari detection is broken

Hoping to get some love on this.

Would also like to see this issue resolved. Is this project still active?

We don't actively work on the project anymore, but the latest API allows you to create your own detects - if you find one that works for you please PR! :)

If you guys can test this, possibly on older Safari versions as well - but it's working for me (just paste this in your browser console):
/constructor/i.test(window.HTMLElement) || (function (p) { return p.toString() === "[object SafariRemoteNotification]"; })(!window['safari'] || safari.pushNotification);

@toddmotto, thanks for the reply.
That seems to work.
Would something like this work:

@sebet replacing the safari detect with the above seems to be working.

@sebet Nope that looks perfect, you could also use the non-function approach:
var safariRegex = /constructor/i.test(window.HTMLElement) || (function (p) { return p.toString() === "[object SafariRemoteNotification]"; })(!window['safari'] || safari.pushNotification);
conditionizr.add( 'safari', safariRegex);

Perfect! Thanks for your help @toddmotto. If this can somehow be added officially at some point to the library it would be great.
Until then I'll use the the custom test.

Cleaned it up a little and added to the core: https://github.com/conditionizr/conditionizr/blob/master/detects/safari.js

Thanks @toddmotto for giving this some love.


Fix read [WIP]

This is a work in progress, the tests aren't working yet. The purpose was to show what I had in mind for reading memory. Let me know what you think, if it makes sense we can move on to fixing the tests and merge.

Do we know the actual value of the leaf before the write, or only its hash?
@diegonehab @mpernambuco

I think this can work. From the current json log files, I only see the hash of the leaf before the write, not the value.

Hi @GCdePaula
For write accesses, he read leaf data was not present in the uarch json logs. It is required for computing the written leaf, as per the discussion in the original PR.
I've made this change to the logs to always include the read leaf data
https://github.com/cartesi/machine-emulator/pull/259/commits/6cd489408fcb605781c5832d224871be255b8464
The PR https://github.com/cartesi/machine-solidity-step/pull/68 was also updated to take the new format into consideration.


getting issue in Android 30

I am able to receive the path of images but when i check the file with .exists() it returns false, So not able to display or upload image also.

Having this same issue - where filePath is from the media picker
File file = new File(filePath); file.exists() -> always returns false

@alhazmy13 you haven't released a new version of this library in over 2 years. Can you either release a new version or just mark this repository as read only if you don't have any time to contribute any more?

I also faced the same issue, please try this.
Google has a new feature on Android Q: filtered view for external storage. A quick fix for that is to add this code in the AndroidManifest.xml file:
<manifest ... >
    <!-- This attribute is "false" by default on apps targeting Android Q. -->
    <application android:requestLegacyExternalStorage="true" ... >
     ...
    </application>
</manifest>

@aadityapaliwal94 this will not work if your app targets Android 11:
"After you update your app to target Android 11 (API level 30), the system ignores the requestLegacyExternalStorage attribute when your app is running on Android 11 devices, so your app must be ready to support scoped storage and to migrate app data for users on those devices." https://developer.android.com/training/data-storage/use-cases

Thanks, @prfarlow1. Will check it out.

@arthtilva @pelusodan @prfarlow1 @aadityapaliwal94 https://github.com/Drjacky/ImagePicker/

@Drjacky  I think Your lib that doesn't support multiple image selection.

@arthtilva I couldn't run that project; It's super old.
Does it allow multiple selections AND CROP at the same time? Or just multiple selections?


Where is the release commit for v0.15.3?

It counteracts against open-source software when I cannot see what has changed, as there is no changelog in this repository as well?

There is a branch version-0.15 containing all you search for, as the main branch already contained some breaking fixes in preparation for 0.16.

Thanks for the fast reply! :)


More typos

(Hit return and submitted this too soon. I may add more later...)
RAML
Several uses of "sender/receiver" are a little confusing ("hmm, are these sender wotsits really being validated against receiver thingamijigs?"). Other instances of "sender/receiver" might be OK, but using "resource" or another term (see #35) might be better. Other instances of sender or receiver are just obvious copy & paste typos.
APIs/ConnectionAPI.raml - sender/receiver --> sender (or resource?)
APIs/ConnectionAPI.raml - sender --> receiver
APIs/ConnectionAPI.raml - sender/receiver --> receiver (or resource?)
APIs/ConnectionAPI.raml - senders --> sender
APIs/ConnectionAPI.raml - sender/receiver --> sender (or resource?)
APIs/ConnectionAPI.raml - sender/receiver --> sender (or resource?)
APIs/ConnectionAPI.raml - receiver --> sender
APIs/ConnectionAPI.raml - reqest --> request
APIs/ConnectionAPI.raml - sender/receiver --> receiver (or resource?)
APIs/ConnectionAPI.raml - sender/receiver --> receiver (or resource?)
Schemas
APIs/schemas/v1.0-sender-response.schema.json - receiver --> sender

Another minor sort of typo... both the schemas and example files for bulk control have confusing names, due to the history of design. Some files have "stage" in the name, some don't, though there's no "/stage" in the bulk endpoint names. And some have "patch" in the name, when the request operation is always a POST.

Think these have all been fixed, although no new innovative name for a sender/receiver entity. If you could take a look at the commit and see if it looks right to you I'd be very grateful.


libdbusmenu: require glib-2.0 in pkg-config

Description of changes

libdbusmenu-glib has headers which include <glib.h>, but does not declare glib as a dependency. This causes include errors if you try to build with just libdbusmenu-glib.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2376

@SuperSandro2000 oops sorry! fixed that


Support base64 or 62

It would be great to have uuid's in base62/64 format for docs, urls, or for couchdb _id

If anyone is interested in generating base62 UUIDs, I've created uuid-base62 for that purpose. It also exposes node-uuid for convenience.

It is 2021. I guess it may be time to reconsider this once again...? I see two major formats - Base64 and Base64URL. Please consider... I have been using helper functions for too long already...

Please see https://github.com/uuidjs/uuid/issues/47#issuecomment-8197007
The goal of this library is to implement the RFC4122 standard, nothing more, nothing less.


Ability to choose which optionals are synced

title says it really. :)

Yeah I really do need to get back to this. It's overdue. Thanks for the issue!

+1 for this. would also be nice to be able to specify tag separately for the optional profile

If anyone is interested in this (or any) request (bug or feature), please give the first post a 👍🏻. That will help me prioritize, in case things get crazy :)
Thanks everyone.

Good news: This is implemented already on master and will be included in the upcoming 2.0 release. Stay tuned!

Perfect, thank you :)

v2.0 has been released and this functionality is now available. See the include and exclude sections under filters in the Configuration Reference


Retry on initial connect

This desired behavior is discussed in https://github.com/nats-io/go-nats/issues/310. Is it supported in cnats somehow?

No, this feature is not implemented in C NATS, nor in the Go client at this point. I will leave this issue opened as an enhancement request and see if we add this.


Start rewriting delayed job integration

Beginnings of a delayed job integration rewrite. I am just beginning to get the maze tests written.
The integration should work and may alleviate issues people are having in its current form, but I want to increase test coverage before this gets merged.

Moved the delayed_job metadata reporting into a middleware, attaching job to request_data before run to ensure data is attached correctly in both handled and unhandled exceptions.

Can we also base this PR off of the #493 branch? so the diff is easier to read

Due to quick discussion with @kattrali & @duncanhewett a context has been added to the delayed_job middleware.
This is being set to the payloads method_name now, but that property won't exist in the event a job and payload don't exist, leaving the event with no context.
Any input on what context should be by default would be useful.

Using class + method name as the context would be better I think.
The default can be left empty and will be defaulted during server-side event processing.


mpk: protect memory with PROT_NONE

This change fixes a bug with ProtectionKey::protect: previously it initialized each stripe with read and write permissions (i.e., pkey_mprotect(..., PROT_READ | PROT_WRITE) under the mistaken assumption that these permissions were MPK-specific, "what MPK permissions will we be allowed to set in the PKRU for these regions in the future?". This assumption is incorrect: the regions were immediately made accessible for reading and writing. The fix is to initially protect the regions with PROT_NONE and allow Wasmtime's memory.grow implementation to mark pages with mprotect(..., PROT_READ | PROT_WRITE) as usual. Whether a store can access a slice is still determined by the CPU state set in mpk::allow.

Yes, I'm working on a test to push soon. The spec tests caught this accidental read/write once I was able to actually run them.


Prune unused functions for ps.go

Prune libkpod from kpod ps.  Remove unused functions.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

@rh-atomic-bot r+


Enforce code coverage standards across project

A code coverage of 65% is far too low for our project at this stage. In addition, it seems that the jacoco code coverage is not being run on the many subprojects in the plugins project. Reports only seem to be generated for data-prepper-api,  data-prepper-core, and data-prepper-plugins/common.

[x] data-prepper-api
[x] data-prepper-core
[x] data-prepper-plugins/common
[x] data-prepper-plugins/elasticsearch
[ ] data-prepper-plugins/lmdb-processor-state
[x] data-prepper-plugins/map-db-processor-state
[x] data-prepper-plugins/otel-trace-raw-processor
[x] data-prepper-plugins/otel-trace-source
[x] data-prepper-plugins/peer-forwarder
[x] data-prepper-plugins/service-map-stateful

We need to have at least 95% coverage across the project, and should strive for 100%. There are very few cases where we should not be able to hit a line of code in testing.

Agreed - We already have the enforcement enabled for core projects but since they did not have 95% - It was set to lower levels

Project level - This enforces only core projects which are core, api and plugins:common
Core
Api this is at 100%
Plugins:Common

But yeah we can easily get better than 65% in plugins and better than 60% in core

Yeah, all plugins have unit testing at this point. But most are probably sitting around 70% or something. I think we should get the coverage requirement up asap so that (1) we know that we are testing well, and (2) new code can't be added without being thoroughly tested.

@AustinTag @chenqi0805 - Whats the update on this? This should be closed before our March release.

I think all of the plugins other than the lmdb state plugin are at at least 90% now

I am going remove the LMBD from the scope and close this issue. I will create a separate issue for April to make the decision on whether we need the LMDB version in the long run or not. If we do not need it, we should delete it.


Add commitlint to iati.cloud (gb-66)

Added pre-commit with a hook to commitlint, using config-conventional as is done in all front-end projects.
note:
If this is merged (maybe we should merge this to master instead of develop), everyone using iati.cloud needs to re-install requirements (or just pip install pre-commit), and then run pre-commit install --hook-type commit-msg as documented in the updated README.
I'll send out a message in the appropriate channel when it is merged.

:tada: This PR is included in version 5.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Have mystical seeds grow in all seasons

Having types of seeds locked until you get the right season is an interesting game mechanic.

Having to change the season to get seeds often necessitates some backtracking; minimizing backtracking is the heart of routing; routing is fun.

Most players won't initially know what seasons seeds grow in, since the vanilla game's seed seasons and default area seasons match.

Having earlier access to gale seeds and pegasus seeds cuts down on tedium.

The distance between the scent tree and its corresponding stump is just way too long.

As suggested by Drenn in #16, chosen by the majority in a poll, and preferred by myself, seeds will grow in all seasons in 1.3.

FWIW if you buy a shield, then you can get pegasus seeds from the Subrosian Market for 25 ore chunks. Which is not actually in the logic yet, but probably will be next minor version. I'll look at this log more tomorrow; I need to fix a couple bugs and put out version 1.2.2 tonight.

Looks like star ore was locked behind summer in someone else's seed, so the seed/season logic is definitely broken. Might try to fix it next version or just try to push out 1.3 ASAP.

Addressed in https://github.com/jangler/oos-randomizer/commit/24545b81bba1ae563dbc2396e32ceb06dfb13135.


uwp

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50216241-ef27-6124-7182-1133eb113378
Version Independent ID: a8617e77-156f-b3e9-e0e2-349342ba91d9
Content: Microsoft Edge security, compatibility, and manageability
Content Source: edgeenterprise/microsoft-edge-video-security-compatibility-manageability.md
Product: microsoft-edge
GitHub Login: @dan-wesley
Microsoft Alias: collw

@tuckstarrydell Hello - If you would like to report a Microsoft Edge Enterprise documentation issue to the team please open a new issue and include relevant information/repro steps in the Comment section.
If you have general questions regarding Microsoft Edge please reach out on the Microsoft Edge Tech Community or for Enterprise specific questions please visit the Enterprise section of the Tech Community. Thanks!


Don't set ulimits (nproc, nfile) for all init scripts

There is a not-insignificant performance overhead for all containers (if
containerd is a child of Docker, which is the current setup) if rlimits are
set on the main Docker daemon process (because the limits
propogate to all children).
We recommend using cgroups to do container-local accounting.
This applies the change added in 8db61095a3d0bcb0733580734ba5d54bc27a614d
to other init scripts.
relates to https://github.com/docker/docker/pull/24307
ping @justincormack @tianon @runcom @cyphar PTAL if this looks good to you; I didn't know the best way to verify/test this, but can try if you agree on this

LGTM!

LGTM

unlimited is still a number, just that it's a really high number.

@cpuguy83 is there a way to set no limit? If setting unlimited does still apply a limit, I wonder if https://github.com/docker/docker/pull/24307 (and this PR) has any benefits.
@cyphar did you benchmark the difference before/after applying https://github.com/docker/docker/pull/24307?

@thaJeztah According to the reporter of the bug, their benchmark time almost halved (from ~130 minutes to ~80) after setting the ulimits to be unlimited.

@cpuguy83 The special value RLIM_INFINITY is used by the kernel to mean "no limit". It is not the same as using a different very large number.

@cpuguy83 It looks like for RLIMIT_NOFILE Linux doesn't use RLIM_INFINITY as a special value specifically for the fastpath. So I'm not really sure why there is a performance impact -- it might be some weird quirk of rpm that causes this to happen.

In fact you don't appear to be able to set RLIMIT_NOFILE to unlimited anyway:
ulimit -n unlimited
bash: ulimit: open files: cannot modify limit: Operation not permitted

It is bounded by /proc/sys/fs/file-max. So that line is not doing anything at all. So it can only be the process limit that is having an effect, if anything there will probably be a lower file limit than before as it was not being raised.

@justincormack hm, that's weird I think it tried that, but maybe I messed up and only tried on ulimit -u :blush: I see the man page mentions;

-n     The maximum number of open file descriptors (most systems do not allow this value to be set)

Looks like you can only set a numeric value, that's lower or equal to 1048576, but not a higher one;
ulimit -n 1048576

ulimit -n 1048577
bash: ulimit: open files: cannot modify limit: Operation not permitted

but that limit doesn't match /proc/sys/fs/file-max;
cat /proc/sys/fs/file-max
398153

I'm trying that in a container, so possibly that's related there

So, does setting LimitNOFILE=infinity in systemd work? And why? Or is it silently ignored?

Try it outside a container, docker may already have that limit set...
On 13 Jul 2016 12:51 p.m., "Sebastiaan van Stijn"<EMAIL_ADDRESS>wrote:

@justincormack https://github.com/justincormack hm, that's weird I
think it tried that, but maybe I messed up and only tried on ulimit -u 😊
I see the man page mentions
http://man7.org/linux/man-pages/man1/bash.1.html;
-n The maximum number of open file descriptors (most systems do not allow
this value to be set)
Looks like you can only set a numeric value, that's lower or equal to
1048576, but not a higher one;
ulimit -n 1048576
ulimit -n 1048577
bash: ulimit: open files: cannot modify limit: Operation not permitted
but that limit doesn't match /proc/sys/fs/file-max;
cat /proc/sys/fs/file-max
398153
I'm trying that in a container, so possibly that's related there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/24555#issuecomment-232332677, or mute
the thread
https://github.com/notifications/unsubscribe/AAdcPMGGjZNiOldl4tMntHJAMjmyyWjyks5qVNE-gaJpZM4JK1Uw
.

nope, looks to be the same;
root@dockr:~# ulimit -n 1048576
root@dockr:~# ulimit -n 1048577
-bash: ulimit: open files: cannot modify limit: Operation not permitted
root@dockr:~# ulimit -n unlimited
-bash: ulimit: open files: cannot modify limit: Operation not permitted

cat /proc/sys/fs/file-max
100809

ok that limit is hardcoded http://stackoverflow.com/questions/1212925/on-linux-set-maximum-open-files-to-unlimited-possible

Updated to only set nproc, and updated the systemd unit file accordingly; @cyphar can you confirm if setting LimitNOFILE=infinity actually worked? The systemd documentation seems to indicate it accepts the same values as ulimit -n; https://www.freedesktop.org/software/systemd/man/systemd.exec.html#id-<IP_ADDRESS>.17.3

LGTM

LGTM

@thaJeztah LimitNOFILE=infinity definitely works. I'm currently running a Docker daemon with that limit set.


processParameter function

Hello,
I think there is a bug in the function "processParamter".  In case of preparing the json object (as string) you add single comma to the string ('  in line 164 and 166 => builder.append("'"); )
In case of "value" has more then one character Elasticsearch  expects double comma ( " )
e.g
"terms": {
"location.raw": ['LAX', 'HOU']
}
wrong transformation: ['LAX', 'HOU']   - should be ["LAX", "HOU"]
please can you check and correct.
best regards

I don't touch the query, unless it's for setting the size. There is no processParameter function. Could you point out the file where this happens? Closing this one, feel free to re-open it with more details.


[Event Request] Table 5965 Service Contract Heder event OnCalcInvPeriodDurationCaseElse

ServiceContractHeader variable should be passed as VAR
BEFORE
[IntegrationEvent(false, false)]
local procedure OnCalcInvPeriodDurationCaseElse(ServiceContractHeader: Record "Service Contract Header"; InvPeriodDuration: DateFormula)
begin
end;
AFTER
[IntegrationEvent(false, false)]
local procedure OnCalcInvPeriodDurationCaseElse(var ServiceContractHeader: Record "Service Contract Header"; InvPeriodDuration: DateFormula)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[analyzer] Missing error in extension method

please see this code sample
import 'dart:async';

typedef Nullary<T> = T Function();
typedef NullaryAsync<T> = Nullary<Future<T>>;
typedef NullaryFutureOr<T> = Nullary<FutureOr<T>>;

typedef Unary<T, S> = T Function(S);
typedef UnaryAsync<T, S> = Unary<Future<T>, S>;
typedef UnaryFutureOr<T, S> = Unary<FutureOr<T>, S>;

extension NullaryFutureOrToNullaryAsync<T> on NullaryFutureOr<T> {
  NullaryAsync<T> get future => call();
}

extension UnaryFutureOrToUnaryAsync<T, S> on UnaryFutureOr<T, S> {
  UnaryAsync<T, S> get future => call();
}

FutureOr<void> nullary() {}
FutureOr<void> unary(dynamic _) {}

void main() {
  print(nullary.future.runtimeType);
  print(unary.future.runtimeType);
}

both extensions should throw, but they do so only at runtime
Dart SDK version: 2.17.6 (stable) (Tue Jul 12 12:54:37 2022 +0200) on "macos_arm64"

Here's a variant of the example which is running code (printing 'Null' and 'Null'):
import 'dart:async';

typedef NullaryFunction<T> = T Function();
typedef NullaryFunctionFuture<T> = NullaryFunction<Future<T>>;
typedef NullaryFunctionFutureOr<T> = NullaryFunction<FutureOr<T>>;

typedef UnaryFunction<T, S> = T Function(S);
typedef UnaryFunctionFuture<T, S> = UnaryFunction<Future<T>, S>;
typedef UnaryFunctionFutureOr<T, S> = UnaryFunction<FutureOr<T>, S>;

extension NullaryFutureOrToNullaryAsync<T> on NullaryFunctionFutureOr<T> {
  FutureOr<T> get invoke => call();
}

extension UnaryFutureOrToUnaryAsync<T, S> on UnaryFunctionFutureOr<T, S> {
  FutureOr<T> invoke(S s) => call(s);
}

FutureOr<void> nullaryFunction() {}
FutureOr<void> unaryFunction(dynamic _) {}

void main() {
  print(nullaryFunction.invoke.runtimeType);
  print(unaryFunction.invoke(1).runtimeType);
}

I changed a few names to emphasize that it's about the arity of functions, not about nullable or non-nullable types. I changed the invocation of the function taking one argument such that we're passing one argument (call(s)).
With that, it's more obvious to me what the code is doing. ;-)
Then I changed the code back to a form which is similar to the original example, by changing the extensions as follows:
extension NullaryFutureOrToNullaryAsync<T> on NullaryFunctionFutureOr<T> {
  Function get invoke => call();
}

extension UnaryFutureOrToUnaryAsync<T, S> on UnaryFunctionFutureOr<T, S> {
  Function invoke(S s) => call();
}

The expected compile-time errors are reported by the common front end, but the analyzer does not complain (even though we're invoking a function with type FutureOr<T> Function(S) with no actual arguments, and we're returning an expression of type FutureOr<T> )
My interpretation is that the analyzer treats call in an extension on a function type as if it had no signature (so we're allowed to pass arbitrary actual argument lists, and the return type is considered to be dynamic).
@scheglov?

@eernstg
thank you for your quick response,
I just wanted to add that call instead of call() behave as intended (yelling)
(this was actually how I stumble across this)
import 'dart:async';

typedef Nullary<T> = T Function();
typedef NullaryAsync<T> = Nullary<Future<T>>;
typedef NullaryFutureOr<T> = Nullary<FutureOr<T>>;

typedef Unary<T, S> = T Function(S);
typedef UnaryAsync<T, S> = Unary<Future<T>, S>;
typedef UnaryFutureOr<T, S> = Unary<FutureOr<T>, S>;

extension NullaryFutureOrToNullaryAsync<T> on NullaryFutureOr<T> {
+  NullaryAsync<T> get future => call;
-  NullaryAsync<T> get future => call();
}

extension UnaryFutureOrToUnaryAsync<T, S> on UnaryFutureOr<T, S> {
+  UnaryAsync<T, S> get future => call;
-  UnaryAsync<T, S> get future => call();
}

FutureOr<void> nullary() {}
FutureOr<void> unary(dynamic _) {}

void main() {
  print(nullary.future.runtimeType);
  print(unary.future.runtimeType);
}

extension NullaryFutureOrToNullaryAsync<T> on NullaryFutureOr<T> {
   NullaryAsync<T> get future => call; // "Undefined name 'call'".
}

extension UnaryFutureOrToUnaryAsync<T, S> on UnaryFutureOr<T, S> {
   UnaryAsync<T, S> get future => call; // "Undefined name 'call'".
}

In this case the analyzer version in dart-pad ('Based on .. Dart SDK 2.17.6') complains that call is undefined, even though it should be treated as this.call, and that expression should have the static type which is the on-type, i.e., FutureOr<T> Funtion() respectively FutureOr<T> Function(S).
So that would be another analyzer issue.

For call() invocation: https://dart-review.googlesource.com/c/sdk/+/256704

For call as simple identifier: https://dart-review.googlesource.com/c/sdk/+/256921

@scheglov that was really fast <3


a flag to analyse config

-a flag to validate the config file.  if it's not ok, print why it's not and print suggestions how to fix the problem.

I should probably wait until chords are implemented #8, since, it's gonna be the last thing to add to the configuration for now.  When it's implemented, make a new function, which detects what type the binding is, and calls a set of new functions relevantly to parse them.  Analyser function can also be useful for when the analyse flag is not provided, because now the parsing of config file happens in one huge function, which calls two other huge functions.

rewriting the parser, but not implementing this. is really unnecessary for a program like dxhd (at least for now).


Update ice ext to 1.1.2

Thank you for the manual update.
It would be nice, if you provide a consistent download location. Maybe Github Releases or your website.
That would allow me to write a crawler and pick any version change up automatically - like i do with the other extensions.

Is it enough directory index? http://www.iceframework.org/dll

Super! I will write a crawler in the next few days.
Merging your manual update now.


TypeError: unhashable type: 'dict_node' due to Fn::Sub

CloudFormation Lint Version
0.87.2
What operating system are you using?
MacOS 14.4.1
Describe the bug
When running cfn-lint on our CloudFormation Template, we get the following error that seems caused by lines 263-265 and line 85:
Traceback (most recent call last):
  File "/opt/homebrew/bin/cfn-lint", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/__main__.py", line 40, in main
    matches = list(cfnlint.core.get_matches(filenames, args))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/core.py", line 179, in get_matches
    matches = run_cli(
              ^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/core.py", line 84, in run_cli
    return run_checks(filename, template, rules, regions, mandatory_rules)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/core.py", line 354, in run_checks
    errors.extend(runner.transform())
                  ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/runner.py", line 35, in transform
    matches = self.cfn.transform()
              ^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/template/template.py", line 170, in transform
    return transform.transform(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/template/transforms/transform.py", line 54, in transform
    cfn.graph = Graph(cfn)
                ^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/graph.py", line 92, in __init__
    self._add_getatts(cfn)
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/graph.py", line 189, in _add_getatts
    and (self._is_resource(cfn, value[0]))
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/graph.py", line 264, in _is_resource
    return cfn.template.get("Resources", {}).get(identifier, {})
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/cfn-lint/0.87.2/libexec/lib/python3.12/site-packages/cfnlint/decode/node.py", line 126, in get
    return super().get(key, default)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'dict_node'

Expected behavior
We expected cfn-lint to return without any errors since our CloudFormation template deploys successfully in the console.
Reproduction template
{
  "AWSTemplateFormatVersion": "2010-09-09",
  "Transform": "AWS::LanguageExtensions",
  "Description": "Creates an AWS budget with two notification thresholds for chosen service (EC2 or Lambda). A notification email will be sent when the first budget threshold is met. When the budget amount is reached, you will receive a notification and an IAM DENY policy will be applied to prevent the creation of new resources of chosen service type. ",
  "Parameters": {
    "Name": {
      "Description": "The name you want for the budget.",
      "Type": "String"
    },
    "Service": {
      "Type": "String",
      "Default": "EC2",
      "AllowedValues": ["EC2", "Lambda"],
      "Description": "Which service should this Budget target and track costs for? Choose either EC2 or Lambda."
    },
    "Amount": {
      "Description": "The monthly budget amount that will trigger the budget action.",
      "Type": "Number"
    },
    "Currency": {
      "Description": "The currency of your budget. Default is USD. For a list of other currencies offered, please reference: https://docs.aws.amazon.com/marketplace/latest/buyerguide/buyer-paying-for-products.html#supported-currencies",
      "Type": "String",
      "Default": "USD"
    },
    "WarningThreshold": {
      "Description": "You'll receive a notification when your budget reaches this dollar amount. Enter a number that is less than the total budget amount.",
      "Type": "Number"
    },
    "Email": {
      "Description": "The email address to receive notifications.",
      "Type": "String",
      "AllowedPattern": "^[\\w-\\.]+@([\\w-]+\\.)+[\\w-]{2,4}$"
    },
    "IAMRoles": {
      "Description": "List the IAM Role names that the IAM policy should apply to with a comma between each Role.",
      "Type": "CommaDelimitedList"
    },
    "IAMRoleARNs": {
      "Description": "List the associated ARNs for the IAM Roles entered above.",
      "Type": "CommaDelimitedList",
      "AllowedPattern": "^arn:aws:iam::\\d{12}:role/.+"
    }
  },
  "Metadata": {
    "AWS::CloudFormation::Interface": {
      "ParameterGroups": [
        {
          "Parameters": [
            "Name",
            "Service",
            "Amount",
            "Currency",
            "WarningThreshold",
            "SecondThreshold",
            "Email",
            "IAMRoles",
            "IAMRoleARNs"
          ]
        }
      ]
    }
  },
  "Conditions": {
    "isEC2": {
      "Fn::Equals": [
        {
          "Ref": "Service"
        },
        "EC2"
      ]
    },
    "isLambda": {
      "Fn::Equals": [
        {
          "Ref": "Service"
        },
        "Lambda"
      ]
    }
  },
  "Resources": {
    "BudgetActionExecutionRole": {
      "Type": "AWS::IAM::Role",
      "Properties": {
        "RoleName": { "Fn::Sub": "${Service}BudgetActionExecutionRole" },
        "AssumeRolePolicyDocument": {
          "Version": "2012-10-17",
          "Statement": [
            {
              "Effect": "Allow",
              "Principal": {
                "Service": "budgets.amazonaws.com"
              },
              "Action": "sts:AssumeRole"
            }
          ]
        },
        "Policies": [
          {
            "PolicyName": "BudgetActionExecutionRolePolicy",
            "PolicyDocument": {
              "Version": "2012-10-17",
              "Statement": [
                {
                  "Effect": "Allow",
                  "Action": [
                    "iam:AttachGroupPolicy",
                    "iam:AttachRolePolicy",
                    "iam:AttachUserPolicy",
                    "iam:DetachGroupPolicy",
                    "iam:DetachRolePolicy",
                    "iam:DetachUserPolicy"
                  ],
                  "Resource": {
                    "Ref": "IAMRoleARNs"
                  }
                }
              ]
            }
          }
        ]
      }
    },
    "EC2IamActionDefinitionPolicy": {
      "Condition": "isEC2",
      "Type": "AWS::IAM::ManagedPolicy",
      "Properties": {
        "PolicyDocument": {
          "Version": "2012-10-17",
          "Statement": [
            {
              "Effect": "Deny",
              "Action": [
                "ec2:RequestSpotInstances",
                "ec2:StartInstances",
                "ec2:RunScheduledInstances",
                "ec2:CreateInstanceConnectEndpoint",
                "ec2:RunInstances",
                "ec2:CreateCapacityReservation",
                "ec2:PurchaseCapacityBlock",
                "ec2:PurchaseHostReservation",
                "ec2:PurchaseReservedInstancesOffering"
              ],
              "Resource": "*"
            }
          ]
        }
      }
    },
    "LambdaIamActionDefinitionPolicy": {
      "Condition": "isLambda",
      "Type": "AWS::IAM::ManagedPolicy",
      "Properties": {
        "PolicyDocument": {
          "Version": "2012-10-17",
          "Statement": [
            {
              "Effect": "Deny",
              "Action": [
                "lambda:CreateFunction",
                "lambda:CreateFunctionUrlConfig",
                "lambda:InvokeAsync",
                "lambda:InvokeFunction",
                "lambda:InvokeFunctionUrl",
                "lambda:PutFunctionConcurrency",
                "lambda:PutProvisionedConcurrencyConfig",
                "lambda:PutFunctionEventInvokeConfig",
                "lambda:CreateEventSourceMapping",
                "lambda:PutRuntimeManagementConfig"
              ],
              "Resource": "*"
            }
          ]
        }
      }
    },
    "Budget": {
      "Type": "AWS::Budgets::Budget",
      "Properties": {
        "Budget": {
          "BudgetName": {
            "Ref": "Name"
          },
          "BudgetLimit": {
            "Amount": {
              "Ref": "Amount"
            },
            "Unit": {
              "Ref": "Currency"
            }
          },
          "CostFilters": {
            "Service": [{ "Fn::If" : [
              "isEC2",
              "Amazon Elastic Compute Cloud - Compute",
                {"Fn::If" : [
                  "isLambda",
                  "AWS Lambda",
                  ""
                ]}
            ]}]
          },
          "TimeUnit": "MONTHLY",
          "BudgetType": "COST"
        },
        "NotificationsWithSubscribers": [
          {
            "Notification": {
              "ComparisonOperator": "GREATER_THAN",
              "NotificationType": "ACTUAL",
              "Threshold": {
                "Ref": "WarningThreshold"
              },
              "ThresholdType": "ABSOLUTE_VALUE"
            },
            "Subscribers": [
              {
                "SubscriptionType": "EMAIL",
                "Address": {
                  "Ref": "Email"
                }
              }
            ]
          },
          {
            "Notification": {
              "ComparisonOperator": "GREATER_THAN",
              "NotificationType": "ACTUAL",
              "Threshold": {
                "Ref": "Amount"
              },
              "ThresholdType": "ABSOLUTE_VALUE"
            },
            "Subscribers": [
              {
                "SubscriptionType": "EMAIL",
                "Address": {
                  "Ref": "Email"
                }
              }
            ]
          }
        ]
      }
    },
    "BudgetAction": {
      "Type": "AWS::Budgets::BudgetsAction",
      "Properties": {
        "ActionThreshold": {
          "Type": "ABSOLUTE_VALUE",
          "Value": {
            "Ref": "Amount"
          }
        },
        "ActionType": "APPLY_IAM_POLICY",
        "ApprovalModel": "AUTOMATIC",
        "BudgetName": {
          "Ref": "Name"
        },
        "Definition": {
          "IamActionDefinition": {
            "PolicyArn": {
              "Fn::GetAtt": [
                { "Fn::Sub": "${Service}IamActionDefinitionPolicy" },
                "PolicyArn"
              ]
            },
            "Roles":
              {
                "Ref": "IAMRoles"
              }

          }
        },
        "ExecutionRoleArn": {
          "Fn::GetAtt": ["BudgetActionExecutionRole", "Arn"]
        },
        "NotificationType": "ACTUAL",

        "Subscribers": [
          {
            "Type": "EMAIL",
            "Address": {
              "Ref": "Email"
            }
          }
        ]
      }
    }
  }
}

I have a fix for your issue in there.  I think I need to look at a better mechanism for wrapping the graph functionality.  We are using it more and more and it shouldn't hard crash the entire app when we run into something we didn't expect.

Fix has been released.

Awesome, thank you so much!


Methods are covariant in their parameter and return types

Steps to reproduce
vim9script

class A
endclass

class B extends A
endclass

class C extends B
endclass

class Foo
  def Doit(p: B): B
    return B.new()
  enddef
endclass

class Bar extends Foo
  def Doit(p: C): C
    return C.new()
  enddef
endclass

Expected behaviour
This should not compile.  There should be type errors for both the parameter and return type as the help says:

Object methods of the base class can be overruled.  The signature (arguments,
argument types and return type) must be exactly the same.

However, ideally the current implementation should just be changed to make the methods contravariant in their parameter types.  The existing covariance of return types is correct.
As there's no complications with regard to overloaded methods,which are not supported, is there a reason not to relax the restriction as stated in the help?
So, the following would compile - contravariant parameter types and covariant return types.
class Baz extends Foo
  def Doit(p: A): C
    return C.new()
  enddef
endclass

Irrespective, covariant parameter types should obviously not be allowed.
I don't have time to experiment further at the moment but will attempt to in the near future.
Version of Vim
9.0.182
Environment
Ubuntu 20.04
Logs and stack traces
No response

I have created the PR #13221 to support this.  Please try it out and let me know if you see any issues.

Thanks @yegappan.  I probably won't get to it until tomorrow.


Clicking an anchor in a custom card does not work

Describe the bug
My board uses customCardLayout and my card includes a  tag. Clicking the hyperlink does not work.
To Reproduce
Steps to reproduce the behavior:

Use this code

     const Card = ()=> test;

     <Board
         customCardLayout
         eventBusHandle={eventBusHandle}
         handleDragEnd={handleDragEnd}
         hideCardDeleteIcon
         draggable
         editable
         laneDraggable={false}
         data={myData}
         addCardLink={}>

       <Card/>

     </Board>

click on the link inside a card

Expected behavior
The click works and navigates away form the current page. Drag & drop should still work if I click and drag elsewhere in the card.
Desktop :

OS: Windown
Browser: Chrome
Version:  70

The root cause is the call to e.preventDefault() here in Lane.js
  handleCardClick = (e, card) => {
    const {onCardClick} = this.props
    onCardClick && onCardClick(card.id, card.metadata, card.laneId)
    e.stopPropagation()
    e.preventDefault()
  }

What made you add that line? In other words, what wouldn't work if this line was not there?

Fixed in the latest release. Thanks for reporting. The bug was introduced as a side-effect of using another library for DnD. Should work now.


Support WebIO functionality in internal notebook

Really would like support for webio-jupyterlab-provider.
This might be called "webio-jupyter-nbextension".  One component is installed in Julia to route output to WebIO. The other component is a Jupyter notebook extension.
Apparently, no Jupyter extensions are directly supported by the internal notebook code and very few of the extensions have equivalent functionality provided by the internal notebook implementation.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


metadata for datasets to be retrieved through DOI and DataCite service

Describe the improvement
Currently, the DOI is resolved through CrossRef. However, CrossRef does not contain (all) DOIs for datasets. Instead, the API of DataCite needs to be retrieved. At this point, it is not necessary to check the resourceType. In first instance, the data curator can judge whether a resourceType can be accepted. Later, validation rules can be implemented if that shows to be valuable.
DataCite REST-API: https://support.datacite.org/docs/api
To Reproduce

Go to 'Add dataset'
Enter DOI for dataset '10.1594/PANGAEA.937928'
Error is given: [{"code":"import_by_id.id_not_found","title":"Unable to find records for id 10.1594/PANGAEA.937928","source":{}}]

Expected behavior
DataCite REST-API call is done with given DOI and metadata is returned and entered into biblio form

The api now uses datacite for datasets, and still gives the error

related to https://github.com/ugent-library/biblio-backend/issues/112 and the fact that I used a "dataset in review" as an example.
10.1594/PANGAEA.933230  works well.
Sorry for the confusion.

resolved by c4b33ecdfd93410cc68698cd4489b8a76b61db02


Pomodoro timer re-enables after restart (0.7.5)

The Pomo timer doesn't play nicely with the desktop app (I haven't really done much troubleshooting, sorry!) and I prefer the timeline to the timer so I disable the Pomo timer from the Toggl button options in Chrome. The thing is, it re-enables itself after a restart and then messes up my timers.
Steps to reproduce

Disable "Pomodoro timers" in Toggl button options (version 0.7.5)
Restart Chrome

Expected outcome

Chrome restarts and Toggl button Pomo timer is disabled

Actual outcome

Chrome restarts and Toggl button Pomo timer is enabled

Additional information

Version 0.7.5
Happens when Toggl is the only extension/addon installed/activated in Chrome as well as with my full extension set.
I'm using desktop timer at the same time, but it should not have an effect on the Chrome extension settings.

Thank you for the feedback I will investigate this.

This issue is similar to #380 and is fixed with aa008bfbde79cbb83839121bb3dca179c47df19f

Any word on when this will be available in the Chrome store? (Can't install from GitHub for...dumb reasons...)

Release is planned to the middle of the week.

Thanks! Really appreciate the quick fix. =D


Empty Line broken?

I'm trying to get some sort of fountain preview to work in Blender with Andrea, but it seems like no "Empty Line" types are generated. Is this a bug?

I did not check it yet, but I will test it, when I have time. Thanks for the report. (=

Thanks. I'm using Brick and Steel for testing - one of the original fountain test files.

I'm sorry I was using an old file which didn't contain New Line at all. Sorry.
Closing this.


Add Project to Catalogue - 34ec845b-cd7a-4c43-99e4-d2932d5d85bb

Project 34ec845b-cd7a-4c43-99e4-d2932d5d85bb contains a submission in Metadata Validating status.
That makes the project non editable.
Acceptance criteria:

[x] Sort submission status issues - set to Valid
[ ] Catalogue box is ticked

project set to Valid

Project visible in Catalogue


Marker brushes rendering black-ish after canvas resize

Hi, And thanks for this amazing library !
I am trying to use a canvas as the background of page, and I want it to resize when the window is resized.
But when I resize the canvas, the canvas is cleared (which is expected), but some brushes start rendering all wrong.
I suspect something break with the color blending, or maybe in the fragment shader.
You can try it on the basic example by just replacing the resize function with this one :
function windowResized () {
  resizeCanvas(window.innerWidth, window.innerHeight);
  C.resize();
}

It should give something like this :

The marker and marker2 brushes are rendering black-ish and they seem to have messed up coordinates too.
Let me know if I am doing something wrong :)

Hi, And thanks for this amazing library !
I am trying to use a canvas as the background of page, and I want it to resize when the window is resized. But when I resize the canvas, the canvas is cleared (which is expected), but some brushes start rendering all wrong. I suspect something break with the color blending, or maybe in the fragment shader.
You can try it on the basic example by just replacing the resize function with this one :
function windowResized () {
  resizeCanvas(window.innerWidth, window.innerHeight);
  C.resize();
}

It should give something like this :
The marker and marker2 brushes are rendering black-ish and they seem to have messed up coordinates too.
Let me know if I am doing something wrong :)

Hey @monsieurplus, thanks for troubleshooting.
I never used the resizeCanvas function, so it's possible that it breaks things! However I hardly recommend always keeping the same canvas and canvas size, and perform all resizes with CSS. I will take a look at the issue in depth at some point in the next weeks.

After a few more tests, what seems cause the problem is that I use a transparent background on my canvas.
Whenever my background color has an alpha that is less than 1, the problem occurs.

Should be fixed now in the repo. Pushing to npm soon.


Bug: Inbox does not render message style

Describe the bug
When I receive an HTML message, it is not formatted according to the styles in the message (see screen shot)
To Reproduce
Steps to reproduce the behavior:

Send an HTML message with nice formatting
Read message... it will not have nice formatting

Expected behavior
It should respect the styles of the incoming message
Screenshots

Version [0.0.9]

Closing due to archiving repository


WIP: Updated dependencies for Laravel 6.x support

This bumps the version requirements to support Laravel 6.x. Sadly due to the PHPUnit requirements in laravel/framework and orchestra/testbench this isn't compatible with previous releases of Laravel.
@nyamsprod What are your thoughts about this?

Nice work. I have no problem bumping requirements for PHP if needed. Will this also work with the newly release Laravel 7.0 🤔

@nyamsprod Hey there! I was playing arround with the Laravel 7.0 deps. I've tried to include them in this PR, but if remember correctly the validators changed a bit... Atleast PHPStan is super triggered about missing typehints and before adding random interfaces to various properties I would like to discuss this further.
Lastly sorry for the late response to this PR, totally forgot about it 😅
How it looks now, the CS rules are failing and Travis doesn't like PHP7.3 for some reason, but I would assume, since those are EOL, we could deprecate those checks in a future release.

@kevindierkx according to https://www.php.net/supported-versions.

7.1 can be removed
7.2 is on the balance since it is still security wised maintained
7.3 and 7.4 are still in active development

So dropping 7.1 even 7.2 could be done without second thoughts 👍 I am less willing to drop 7.3 for now.

@kevindierkx as for Laravel version I'll rely on your jugdement as I am not very familiar with Laravel release schedule and maintainance interval.

@kevindierkx looking at Laravel lifecycle https://laravel.com/docs/7.x/releases#support-policy I believe you can remove 5.5 LTS from support since your change will be a minor bump.
so I would focus on supporting Laravel 6 and 7

Replaced with: https://github.com/bakame-php/laravel-domain-parser/pull/3


Add the option to style the container of the text View.

The changes shouldn't break existing code.

@deadcoder0904 just wondering if we can drop the HiddenText.js completely not sure of it's use?

Naah I guess HiddenText actually calculates the size required to display it & divides it in chunks. I guess @phuongla can answer this better

@deadcoder0904 yes, that's right. It's the purpose of HiddenText.

Great 👍  @ngothanhtai  this good to be pulled in?


Figure out if the InfluxDB Database Structure is optimal for GeoLocated CO2 Measurments

Currently the ribbit network sensors publish each measurement to the InfluxDB Database like this:
# Publish to Influx DB Cloud
point = Point("ghg_point").tag("host", device_uuid) \
        .field("co2", scd.CO2).time(datetime.utcnow(), WritePrecision.NS) \
        .field("temperature", scd.temperature) \
        .field("humidity", scd.relative_humidity) \
        .field("lat", latitude) \
        .field("lon", longitude) \
        .field("alt", altitude)

See the sensor source file here for more information: https://github.com/Ribbit-Network/ribbit-network-frog-sensor/blob/main/software/co2/co2.py
I could use some help from an InfluxDB expert to figure out if this is the optimal schema for location-based data. Specifically, what's the right way to optimize this for queries later in the dashboard or for the science datasets?

@brianstrauch this issue might be a good short-term item you could help with?

Yeah I think that is all the usecases so far @brianstrauch! I'm going to close out this issue since it seems like the structure is adequate for now! Yeah the cell generation is certainly an interesting idea! We could easily generate those on the sensor before writing up to the database.


Introduce io.buoyant.hostportPfx and io.buoyant.porthostPfx namers

It's common to have a host string like web:4434 that needs to be split into
its constituent host and port.
This change introduces two new auto-loaded namers to support these rewrites.
Fixes #904

RFC: now that I've done this, i'm considering moving these to be configured namers so that we don't have to do the weird prefix-suffix dance (as done by all Pfx namers)


Select a pool of models pre-trained on different datasets

An (optional?) extension of #5 , perhaps the same architecture (if possible) but pre-trained on different datasets rather than ImageNet only.

Added wontfix label as this is unlikely to be done as part of the main project


Use apiextensions-application for CRDs

Towards https://github.com/giantswarm/giantswarm/issues/19819
Checklist

[x] Update changelog in CHANGELOG.md.

Tested on gauss


Remove default for hive.cache.location

Might be good to change the test from /etc to /cache or something (since /etc both looks real and is not something you'd use).


PMM-12359 password fix

https://github.com/percona/pmm-ui-tests/actions/runs/5764461087

https://github.com/percona/pmm-ui-tests/actions/runs/5764744255 - to rc

https://github.com/percona/pmm-ui-tests/actions/runs/5765777690 to dev-latest


Implement SocketModeClient algorithm in our code.

https://github.com/slackapi/node-slack-sdk/blob/main/packages/socket-mode/src/SocketModeClient.ts

https://github.com/slack-go/slack/blob/master/socketmode/socket_mode_managed_conn.go
This is one easier to comprehend, and is somewhat similar to C in syntax

I believe this is done, some event listening is lacking but the structural part of the algorithm is there.


add content for new security viewpoints from kassel workgroup meeting

add concept diagrams
add stakeholders and concerns

concepts added
https://github.com/GfSE/SAF-Specification/blob/main/developing-saf/concept/SAF_Workshop kassel.md
viewpoint prototype
https://github.com/GfSE/SAF-Specification/blob/main/developing-saf/viewpoints/Protection-Goal-Definition-Viewpoint.md
pending: contribution of concerns and stakeholders

superseded by contribution of uni hamburg.


Editor wipes out whenever there is text that it cannot handle

Implement robust error handling.
The editor should not wipe out whenever somebody enters a character that cannot be displayed or breaks the usfm structure.
Instead: the editor should

ignore unknown character combinations
display a warning message / banner, mentioning the line and character number of the bad character and the bad character (combination) itself
ideally (not a must): highlight the bad character (combination)

How to reproduce:

find a heading section like \s1 (this is displayed bold and centered in the editor)
enter a \ after that to e.g. get

\s1 God Boy Mo Importan Den Moses\

unexpectedly: editor breaks and stays blank without more information

This even more so is a problem on loading text, as the editor will stay blank without any chance for the user to know why this is happening, because they did not just enter something they might remember.

also see https://github.com/BiblioNexus-Foundation/scripture-editors/issues/129 when it happens without the right custom.sty file.

I believe this may be a problem only in Platform.Bible. See https://github.com/paranext/paranext-core/issues/1007 - is this the same issue? Can you reproduce the problem in the online editor preview https://codesandbox.io/p/github/BiblioNexus-Foundation/scripture-editors/main ?

You are right TJ, I am unable to reproduce in the shared editor sandbox. Thanks for creating an issue in platform. I am closing the issue here.


Float columns sort is broken in firefox

Describe the bug
Sorting float columns in the result tables behaves as if it was strings in firefox.
To Reproduce
Steps to reproduce the behavior:

Go to the result search
Select thechristophe/phoronix-c-ray
Sort by outcome.value

Expected behavior
The column is sorted properly.
Screenshots

Additional context
Works on chrome, apparently.

From testing: it turns out the sorting does work correctly, albeit sorting strings probably behaves differently in different browsers. Maybe chrome automatically assumes it's supposed to be numbers (which it was supposed to be, tbf) and sorts is as such?
Either way, the issue was my benchmark outputting the score value as a string, not a float. When converting it to a float, the sorting works correctly on firefox.

The demo results were adjusted to be floats in 9896b066705c54f8d5c0c453cf1314357c578968.


Fix VirtualThreadPool apache license

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #13157 (4bac2a3) into 3.3 (c96a8f3) will increase coverage by 0.00%.
Report is 28 commits behind head on 3.3.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                3.3   #13157   +/-   ##
=========================================
  Coverage     68.40%   68.41%
- Complexity        6        8    +2
=========================================
  Files          1717     1718    +1
  Lines         70668    70687   +19
  Branches      10224    10222    -2
=========================================
+ Hits          48340    48360   +20
- Misses        17632    17647   +15
+ Partials       4696     4680   -16

see 66 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Python base SDK] Import dependencies internally

Description

Related issue https://linear.app/serverless/issue/SC-977/user-thetie-seeing-error-in-production-mode-with-python-sdk#comment-df0ca0e7
Import SDK's external dependencies internally from the layer folder, so that customer code can import its own version separately without version conflicts.

Testing done
Unit, integration, performance tested

@medikoo ready for review 🙏