Add to /api/v2/dataset-urls options to also include metadata in return

We might want to include specific extractors metadata

return_metadata: str: "", "references" ({"metalad_core": "http://localhost:5000/api/v2/url-metadata/54"}, "content" ({"metalad_core": {...}`)

based on the value of return_metadata the result would populate "metadata" field in the return.  so with return_metadata="references" you get records sufficient to display what we display now in web UI. Good point to try jqtables (as on datasets.datalad.org)

@yarikoptic In this design, we will have an issue if we, in the future, decide to return multiple versions of metadata extracted by the same extractor of the same dataset (or we decide to keep multiple versions of metadata extracted by the same extractor of the same dataset). If it is possible that we are going make such a decision, I think we should return the metadata of a dataset at a URL in a list of objects. In the case of "content", each of these object represents a version of metadata by a particular extractor. In the case of "references", each of these object represents a reference to such a version of metadata.


ioPay NOT working for STAKING

Same issue here, with same error : Please use ioPay desktop, import & unlock your wallet, and then refresh this page to continue.
Then it CRASH, and you have to start again

I'm using:
ioPay Version 1.0.16 (1.0.16)
Windows 10 Pro
Version 21H1
OS Build 19043.1707
Also, no clear instructions on how to send IOTX to Metamask? Do you Add Netwrok, send from Binance or KuCoin ?

are you still having this issue i can help you resolve it right away @amjad3000 regarding staking?


Test rules should also support Test path as Prefix (e.g. Laravel)

Projects like Laravel who wants to use this rule will get immediate complaints as their code is of the following structure:
- app
- tests
- vendors

This PR avoids such errors while maintaining the intent.
I did not see where to apply tests, please point me in the right direction if necessary.

@TomasVotruba I have no clue how to make the test green... changing that one line should not be breaking and I have strong suspicion that the fail is is mostly due the pipeline not working properly rather than the tests not passing.
Could you please have a look ?

@ildyria you may need to rebase latest main

@ildyria you may need to rebase latest main

Done :)

You can add test on https://github.com/symplify/symplify/tree/main/packages/phpstan-rules/tests/Rules/CheckNotTestsNamespaceOutsideTestsDirectoryRule

@samsonasik I think I got them to run. :)
▶ vendor/bin/phpunit --filter CheckNotTestsNamespaceOutsideTestsDirectoryRuleTest
PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.12
Configuration: /home/biv/Documents/symplify/packages/phpstan-rules/phpunit.xml

.....                                                               5 / 5 (100%)

Time: 00:00.755, Memory: 40.00 MB

OK (5 tests, 5 assertions)


CASSANDRA-19104/2 Default to human-readable in nodetool tablestats

Default to human-readable in nodetool tablestats. See a discussion on the topic in the dev mailing list<EMAIL_ADDRESS>Before
nodetool tablestats doesn't use the human-readable formatting by default (with KiB/MiB/GiB units), instead it outputs data size values as is. In order to switch to the human-readable output, --human-readable or --H CLI flag is required.
After
nodetool tablestats uses the human-readable format by default. For backward compatibility --no-human-readable flag can be used to disable it.
How to reproduce
nodetool tablestats

and
nodetool tablestats --no-human-readable

Tests
ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.TableStatsTest
ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.stats.TableStatsPrinterTest

patch by @zaaath; reviewed by ??? for CASSANDRA-19104

Moved to #3069


View not properly updated after 'Confirm email address' is clicked in Admin

Reproduction steps

Create new user via Signup
Sign in as an admin user and open the user
Click on confirm email

Expected behavior
Redirected back to the same user record page
Screenshots/Video
Before update

After update

Tested on
Edge on MacOS 13.0.1
Version
2023.3.0-dev.5

Tested and confirming that this now works as expected. I also added the following CL entry:
{
      "what": [
        "admin user view not properly updated after 'Confirm email address' was clicked in Admin."
      ],
      "how": [
        "by refetching the user on admin user patch."
      ],
      "refs": [
        "https://github.com/cortezaproject/corteza/commit/e76fb09707239b8e8c7b430e1f829e4adb975894"
      ]
    }


Something has been deprecated.

When I got into the Quickstart step,
I typed in
python train.py
and everything went normal at the beginning, but later the terminal showed that something has been deprecated. And then it stopped.
python train.py
Found 23894 unique words (9146765 in total)
finish_dump
Finish loading train
Finish loading valid
Finish loading test
Epoch 0
/home/letsuya/miniconda3/envs/3.6env/lib/python3.7/site-packages/torch/nn/functional.py:1386: UserWarning: nn.functional.sigmoid is deprecated. Use torch.sigmoid instead.
warnings.warn("nn.functional.sigmoid is deprecated. Use torch.sigmoid instead.")
已砍掉
What should I do to fix it?
Thank you guys~

@MakerButt You need to follow the environment setting:
Python3.6
Pytorch 1.1
NumPy 1.16.3
SciPy 1.2.1
NetworkX 2.3
Thanks!


Dart shooters have no speed limit

Poison, golden and enchanted dart shooters can be shot at unreasonably fast speeds by spamming right click, or using a macro to do so

Bump, still present in 1.6


add pdf, excel buttons and functionality

please, can you provide code for this?
Thanks!

this should be asked on datatables forum.
p.s
Questions (related to **yadcf **should be asked on stackoverflow)


Update mfa-gauth-webflow.xml

Incomplete webflow for mfa-gauth.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Mint re-entrancy guard with optimizations.

Ok, so as we know, the _safeMint function is NOT safe from re-entrancy. #92
Ideally, most contracts should use _mint.
Although we can warn about it in the comments / docs, many devs won't read it and will happily use _safeMint as it is.
For security reasons, I won't cite any examples here.
Furthermore, the README example shows _safeMint being used in an unprotected manner.
From a usability point of view, I suggest that we make the _mint function re-entrancy safe regardless, to be foolproof.
This will also reduce the cognitive dissonance of _safeMint being unsafe, giving a cleaner API design.
The overhead is only 100 gas for an extra warm SLOAD.
Assuming a function using _safeMint costs ~60K gas, this is only 0.2% overhead that can protect against catastrophic consequences. For users who use _mint, the gas overhead is as good as none.
To ease the concerns for the increase in gas for _safeMint, the function is optimized even further, such that we can save more gas to cover for the overhead.
In practice, implementations that need to use _safeMint for some reason can save 2k gas (cold SLOAD) with this functionality, as they don't need to use OpenZepplin's Reentrancy guard.
Before:
·-----------------------------------------------------------|---------------------------|-------------|
|                   Solc version: 0.8.11                    ·  Optimizer enabled: true  ·  Runs: 800  ·
····························································|···························|·············|
|  Methods
······································|·····················|·············|·············|·············|
|  Contract                           ·  Method             ·  Min        ·  Max        ·  Avg        ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  mintOne            ·      56502  ·      90702  ·      57186  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  mintTen            ·      74696  ·     108896  ·      75380  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  safeMintOne        ·      59256  ·      93456  ·      59940  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  safeMintTen        ·      79246  ·     113446  ·      79930  ·
······································|·····················|·············|·············|·············|
|  Deployments                                              ·                                         ·
····························································|·············|·············|·············|
|  ERC721AGasReporterMock                                   ·          -  ·          -  ·    1146497  ·
····························································|·············|·············|·············|

After re-entrancy guard + gas optimizations:
·-----------------------------------------------------------|---------------------------|-------------|
|                   Solc version: 0.8.11                    ·  Optimizer enabled: true  ·  Runs: 800  ·
····························································|···························|·············|
|  Methods
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  mintOne            ·      56499  ·      90699  ·      57183  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  mintTen            ·      74279  ·     108479  ·      74963  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  safeMintOne        ·      59180  ·      93380  ·      59864  ·
······································|·····················|·············|·············|·············|
|  ERC721AGasReporterMock             ·  safeMintTen        ·      76938  ·     111138  ·      77622  ·
······································|·····················|·············|·············|·············|
|  Deployments                                              ·                                         ·
····························································|·············|·············|·············|
|  ERC721AGasReporterMock                                   ·          -  ·          -  ·    1165266  ·
····························································|·············|·············|·············|

@cygaar @ahbanavi

Hi, thank you all for the great job with this project.
I just tried to get in touch with @Vectorized from other places but I couldn't, so I hope not to bother you asking this question here.
About what you said here:

Ideally, most contracts should use _mint.
Although we can warn about it in the comments / docs, many devs won't read it and will happily use _safeMint as it is.

Do you mean that using _safeMint() instead of _mint() is a bad practice in general, or do you refer to just using it without considering potential re-entrancy attacks?
Would you mind explaining why you would suggest using _mint() in most situations?
Thank you for your time.

@liarco Messaged you on twitter. I forgot to turn on direct messages. You can contact me there from now.
https://ethereum.stackexchange.com/questions/115280/mint-vs-safemint-which-is-best-for-erc721 <- by the lead author of ERC721.


Add ImageFolderDataset

Checklist

[x] Confirmed that run-checks all script has been executed.

Related Issues/PRs
Closes #1132
Changes

Added ImageFolderDataset to load images from disk (following a folder structure)
Added a custom-image-dataset example that downloads CIFAR-10 and trains a simple CNN model using the ImageFolderdataset

Testing
Added a couple of unit tests and an example.

Note that I added an ImageTarget enum for image classification, object detection and segmentation targets. At this time only the image classification targets are implemented while the other two would be for the future.
We could remove the options until they are implemented. Let me know your thoughts :)

Thanks for the feedback! Wasn't clear if you wanted to add CIFAR-10 to burn-dataset immediately or not. If that is the case just say so and I'll refactor it.


Check key sizes before doing AES encryption

Throws an exception from AES encrypt/decrypt functions if the key isn't 32 bytes.
Catches exceptions from AES/OTP encrypt/decrypt functions to clean up output for user. (See below, which is what it looks like without this change.)

Jay - Approve


Added German locale

Added German locale

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


RFC(PubSub): Testing the functionality of pubsub classes after adding a new connection class

Closing this PR.


SourceKit-LSP appears to interfere with SwiftPM build plugins

It appears that SourceKit-LSP is interfering in the build process when building a project that includes a build plugin. While running VS Code on a package that include a build plugin the linker fails to find the generated code. Sometimes subsequent builds are successful but not always. The same project compiles fine if the sourcekit-lsp process is killed.
I used VSCode with Swift extension installed to reproduce this issue. I have a sample project which you can use to reproduce.
Steps to reproduce:

git clone https://github.com/adam-fowler/soto-codegenerator-plugin-test
cd soto-codegenerator-plugin-test
code .
wait for project to load in VS Code
swift build (either in VS Code or from the command line)

This will produce the following link errors
Undefined symbols for architecture arm64:
  "_$s7SotoSNS0B0V0A4Core10AWSServiceAAMc", referenced from:
      _$s7SotoSNS0B0VAC0A4Core10AWSServiceAAWl in SNSTest.swift.o
  "_$s7SotoSNS0B0V11createTopic_6logger2onAC06CreateD8ResponseVAC0gD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKF", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY0_ in SNSTest.swift.o
     (maybe you meant: _$s7SotoSNS0B0V11createTopic_6logger2onAC06CreateD8ResponseVAC0gD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKFfA0_)
  "_$s7SotoSNS0B0V11createTopic_6logger2onAC06CreateD8ResponseVAC0gD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKFTu", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY0_ in SNSTest.swift.o
  "_$s7SotoSNS0B0V11deleteTopic_6logger2onyAC06DeleteD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKF", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY2_ in SNSTest.swift.o
     (maybe you meant: _$s7SotoSNS0B0V11deleteTopic_6logger2onyAC06DeleteD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKFfA0_)
  "_$s7SotoSNS0B0V11deleteTopic_6logger2onyAC06DeleteD5InputV_7Logging6LoggerV7NIOCore9EventLoop_pSgtYaKFTu", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY2_ in SNSTest.swift.o
  "_$s7SotoSNS0B0V16CreateTopicInputV10attributes20dataProtectionPolicy4name4tagsAESDyS2SGSg_SSSgSSSayAC3TagVGSgtcfC", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY0_ in SNSTest.swift.o
  "_$s7SotoSNS0B0V16DeleteTopicInputV8topicArnAESS_tcfC", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY2_ in SNSTest.swift.o
  "_$s7SotoSNS0B0V6client6region9partition8endpoint7timeout19byteBufferAllocator7optionsAC0A4Core9AWSClientC_AK6RegionVSgAK12AWSPartitionVSSSg7NIOCore10TimeAmountVSgAT04ByteiJ0VAK16AWSServiceConfigC7OptionsVtcfC", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY0_ in SNSTest.swift.o
  "_$s7SotoSNS0B0VN", referenced from:
      _$s7SNSTest3RunV4mainyyYaKFZTY0_ in SNSTest.swift.o
      _$s7SotoSNS0B0VAC0A4Core10AWSServiceAAWl in SNSTest.swift.o
ld: symbol(s) not found for architecture arm64
```_

rdar://103022834

Forgot to say I saw this using Swift 5.7 on macOS, but have also seen it using latest trunk build on Linux

This appears to work ok with the version of swift that comes with the Xcode beta so I'll close for now. It was a little temperamental so I may re-open later on.

Just managed to re-produce this with swift-5.9-DEVELOPMENT-SNAPSHOT-2023-07-06-a

OK, here’s what I found:
After opening the package, the VSCode plugin seems to be building all plugins. When manually invoking a build during that time, you get the error about the database.
To reproduce this:

Delete .build
Opening soto-codegenerator-plugin-test in VSCode
Open the “Swift” output view
cd .build
while true; do ls; sleep 1; done
Notice that after ~1-2 minutes the plugin folder appears and the Swift output view will show messages about compiling the plugins

If I wait for the initial plugin build from the VSCode extension to finish and only perform the package build afterwards, I haven’t seen any issues. So I’m thinking that this might be an issue of the VSCode extension and not a sourcekit-lsp issue after all. AFAICT sourcekit-lsp never triggers a build of the plugins that could interfere with the build, at least a breakpoint in BuildOperation.compilePlugins is never hit.
And it appears like the plugins are being built when executing swift test list --skip-build.  I would say it’s a SwiftPM bug that SwiftPM builds the plugins even though --skip-build is passed. I filed https://github.com/apple/swift-package-manager/issues/6683 for the SwiftPM issue.

@adam-fowler To make sure there isn’t another issue lurking somewhere: Do you think it would be possible for you to try if you still see the issue if you disable the swift-test list --skip-build invocation?

I removed the swift test list --skip-build call and it still happens. The easiest way to get it to stop is disable sourcekit-lsp. There is a setting in vscode to disable sourcekit-lsp.

I’m now able to reproduce the issue reliably as well. Mostly for my own memory, here’s what I found out.
Steps to reproduce
These steps reliably reproduced the issue for me. There might be a smaller reproducer but it’s been sufficient for me.
Preparation

Clone http://github.com/swift-server/vscode-swift
Apply this diff to disable the swift test list --skip-build call

diff --git a/src/TestExplorer/TestExplorer.ts b/src/TestExplorer/TestExplorer.ts
index b7efc0a..bc710ab 100644
--- a/src/TestExplorer/TestExplorer.ts
+++ b/src/TestExplorer/TestExplorer.ts
@@ -121,6 +121,7 @@ export class TestExplorer {
      * Uses `swift test --list-tests` to get the list of tests
      */
     async discoverTestsInWorkspace() {
+        return;
         try {
             const toolchain = this.folderContext.workspaceContext.toolchain;
             // get build options before build is run so we can be sure they aren't changed

Clone https://github.com/adam-fowler/soto-codegenerator-plugin-test
Open vscode-swift in Visual Studio Code

To reproduce the issue

Run swift package reset in soto-codegenerator-plugin-test from an external terminal
Debug the VSCode Swift extension (Run -> Start Debugging)
Open SNSTests.swift and make sure we get an error about not being able to load SotoCore to ensure SourceKit-LSP is providing semantic functionality
Wait for package loading to finish
Run /Library/Developer/Toolchains/swift-5.9-DEVELOPMENT-SNAPSHOT-2023-07-06-a.xctoolchain/usr/bin/swift build --build-tests -v from an external terminal

Finding 1: Only reproduces with sourcekit-lsp from the toolchain
If I build sourcekit-lsp locally (both in debug and release, and both when building using Xcode and build-script-helper.py) and set the sourcekit-lsp path in the VSCode plugin, the issue no longer reproduces. It does still reproduce when copying sourcekit-lsp from the toolchain to DerivedData, so it’s not related to the path at which sourcekit-lsp is located.
Finding 2: LinkFileList is missing object files of generated sources
When diffing the failed linker invocation of a successful build (with SourceKit-LSP not running) and a failed build (with SourceKit-LSP running), the only difference is that the failed invocation does not contain the following object files of generated sources.
/private/tmp/soto-codegenerator-plugin-test/.build/arm64-apple-macosx/debug/plugins/outputs/soto-codegenerator-plugin-test/SotoSNS/SotoCodeGeneratorPlugin/GeneratedSources/sns_api+async.swift.o
/private/tmp/soto-codegenerator-plugin-test/.build/arm64-apple-macosx/debug/plugins/outputs/soto-codegenerator-plugin-test/SotoSNS/SotoCodeGeneratorPlugin/GeneratedSources/sns_api.swift.o

sns_api.swift.o is the files that defines s7SotoSNS0B0V0A4Core10AWSServiceAAMc (one of the missing symbols), so the linker error makes sense. This raises the question why those files aren’t present in the linker invocation and I haven’t been able to answer that question.
After the build failed, the files are present and contain the symbol in question. That’s why a subsequent build passes. I also checked whether the MD5 hash or the presence of the file changes during the build, indicating that there is a race between swift-build and sourcekit-lsp but that’s not the case, so I’m not sure what’s going on here.
Next steps
The following are things I’d like to check next:

Once we have a new 5.9 toolchain, check if the issue still reproduces with it. Maybe https://github.com/apple/sourcekit-lsp/pull/763 fixed the issue but I’m not super hopeful.
Fix https://github.com/apple/sourcekit-lsp/issues/665 because it’s also about generated sources from build plugins. Maybe they share the same underlying issue.
Figure out which methods in SwiftPM run the build plugin to double check that SourceKit-LSP is not executing it.
Discuss all of this with @neonichu, maybe he’s go an idea.

Another option could be that this is a race within SwiftPM itself and it somehow only happens if sourcekit-lsp is watching the files on disk for changes. I don’t think that’s the issue though, because I can reproduce it 100% with SourceKit-LSP running a never without SourceKit-LSP running and I would be expecting much higher non-determinism rates. Also, on second thought I don’t think that SourceKit-LSP is actually watching for file changes.

OK, I think I believe I have a guess what the issue is, now. Opening the project in sourcekit-lsp causes module.modulemap and Objects.LinkFileList files to be created in the build directory, which shouldn’t happen. My guess is that these are created incorrectly before the build plugins run and thus don’t include the generated source files. The swift build then picks them up and doesn’t re-generate them after running the plugin and 💥. Now I need to figure out why these files are being created.

Hooray, the issue that LinkFileList is being created has already been fixed by https://github.com/apple/swift-package-manager/pull/6606.
I also am not able to reproduce the issue anymore using the above instructions using swift-DEVELOPMENT-SNAPSHOT-2023-07-10-a. It’s a little unfortunate that these fixes aren’t in release/5.9 but I’m closing it as fixed.


[FLINK-2096] Remove implicit conversion from Window Stream to Stream

This causes unexpected behaviour, for example in:
ds.window(...).map(..)
The user would expect some kind of windowing to take place. The
windowing, however, cancels out with the implicitly inserted flatten()
call.

The reason for having this was that then the conversion is seamless. As seen in the relevant question it can lead to unexpected behaviour, so I am for merging.

+1 from my side.
I think it is important that the core APIs let you see clearly what is happening, otherwise new users usually get thrown off.

manually merged


Add an optional application logo to display along side the user photo in the applications list

Closed by 2a6ef82


Performance issues with many ROMs in browser

I'm not really sure how you would fix this, since I haven't looked at the code yet, but performance is really bad with many ROMs.
There are hangs and crashes as well, although those are a bit more rare. These mostly occur when trying to stop emulation, or when trying to scroll through ROMs.
I have an Intel Pentium G2030 @ 3GHz, 16GB of RAM, an Nvidia GTX 750 Ti, and a Samsung 850 EVO SSD. Using CEN64 git and CEN64-Qt git.
I have about 3500 ROMs, so not a typical use scenario. But probably one you should prepare for, since the best way to test a cycle-accurate emulator is with games and demos. :wink:
Do you know how to tackle this issue @dh4 ?

I played around some with this on my Core 2 Duo machine. I hadn't bothered to test performance with any more than 700 or so ROMs before since I figured no one would have a collection larger than that (~ total number of commercial games released between Japan, USA, and Europe).
With 1000 ROMs, performance is still reasonable. The views each take a few seconds to load, but once they do, they scroll fine and are perfectly usable.
With 4000 ROMs, the views are basically unusable with images enabled. If I disable images, the table view still has good performance so this leads me to believe it's mainly that Qt can't handle painting so many large QPixmap images. I initially thought it might be because CEN64-Qt scales the source images to the correct size on the fly while building the view rather than storing a bunch of different size images of the box art within the cache to pull from, though this doesn't seem to matter, only the size of the original source image it is scaling. If I disable scaling, performance appears to be the same, but if I downsize the size of the source images within the cache, performance improves slightly. Even with images disabled completely though, the grid and list views don't perform greatly (though significantly better).
An easy option would be to disable images as well as the grid and possibly list view if someone has a collection greater than 1000 ROMs. My assumption would be they would use the table view anyways with that large of a collection since it has superior sorting capabilities. This is what I would suggest doing in the meantime to make it usable anyways.
When I get some time, I'll test it more thoroughly and see what optimizations I can make to improve performance with such a large collection, though it may not be possible to get amazing performance out of the grid and list views without completely reworking how they are rendered using sometime like a QGraphicsScene.

@dh4 Let me give you a screenshot of my settings, I think that might give you an idea of my setup:

I have an Intel Pentium G2030 running at 3GHz, 16GB of DDR3 RAM, and an Nvidia GTX 750 Ti graphics card. I am also running 64-bit Windows 10 Pro.
The thing is, I really don't have any images to load. :confounded:
Table view is the only somewhat speedy option, and even that hangs sometimes.
The application as a whole seems to slow down a little if I have a lot of ROMs, does it do anything in the background that would slow it down?

@dh4 I don't know much about QT specifically, but does it offer a "virtualization mode" for collection-based controls? That seems pretty standard with UI toolkits, and would definitely improve performance in this scenario.
Basically in virtual mode, only the items on screen are allocated in memory. This makes the view render almost instantly regardless of the size of the set (since only the first x amount are processed). This approach usually utilizes caching so once an item is created, it's stored away in memory for repeat scrolls.
I had ran into this problem when building my own ROM browser for my personal projects, and after enabling virtualization the controls loaded immediately and were very responsive.
Just a thought :smile:

@beannaich Interesting. I know psxact doesn't have a ROM browser, so you must be talking about Nintemulator? :smile:
@dh4 Are you by chance using QListView?

@beannaich Thanks. The equivalent of this in Qt would probably be the view/model architecture that decouples the data from the widget. I originally used a QTreeWidget for the table view when first coding the application because it was simpler and the scope of this was small, though a QTreeView would probably make more sense at this point and perform better with large a large collection. This would only affect the table view.
@vgturtle127 It uses a QTreeWidget for the table view.

@dh4 Oh, OK. I was thinking you could switch to QTableView for possibly better performance, but if you aren't using that there is most likely not going to be a performance increase.
Well, I suppose I could just move small amounts of ROMs into a test folder. :laughing:

Switching to a QTreeView would probably result in a decent speedup if you're experiencing issues with the table view, though would require a good bit of refactoring at this point. I'll work on it if I get a chance.

@dh4 Take your time, no need to rush. It isn't a big issue with most typical scenarios and people.
Hopefully, most people just will play a few games so most people won't see an issue. I like to test emulators, though, so I think people like me may want something a little more speedy. :wink:

Could you build the model/view-refactor branch and tell me if performance is improved with the table view? With ~4000 ROMs loaded for me it still takes a couple seconds to load the view, but once the view is loaded the scrolling and selecting is as responsive as if there are only a couple ROMs.
The above branch isn't a full implementation, so it will only show Filename and Size for the columns and won't let you launch ROMs, but should give an idea of if this is the correct direction to go before I implement it further.

@dh4 Let me see if I can setup my development environment and all that. I may try using the Linux subsystem for Windows.

There's a Windows build here:
https://s3.amazonaws.com/dh4/cen64-qt/model/view-refactor/cen64-qt_win_git-latest.zip

@dh4 Sorry for the long delay, I have been busy. I am going to compile newer versions of both and re-test with all my ROMs.

@vgturtle127 Did the changes result in a noticeable performance increase?


Audit Smart Contract

How to Audit Smart Contract
Description
I have successfully download the Mythril package and try to audit a smart contract. My contract requires 0.5.0 solc so I use the following command for analysis:
$myth analyze --solv 0.5.0  contracts_ERC20.sol
But it takes more than 2 hours for this and remains in the execution state

After that, it gives an error sometimes or remains to execute. Maybe I am using the wrong command for that. Notify me or give me some instruction to do an analysis of the contract.

Hi @M-Hammad-Ali , can you post the error? You can use --execution-timeout option to specify a timeout. Also use myth -v4 analyze <rest of the stuff> to see the current progress

Hi @M-Hammad-Ali , can you post the error? You can use --execution-timeout option to specify a timeout. Also use myth -v4 analyze <rest of the stuff> to see the current progress

Hi @M-Hammad-Ali , can you post the error? You can use --execution-timeout option to specify a timeout. Also use myth -v4 analyze <rest of the stuff> to see the current progress

I tried to execute it but it remains running don't give error. I wait for more than 3 hours.

Hi @M-Hammad-Ali , can you post the error? You can use --execution-timeout option to specify a timeout. Also use myth -v4 analyze <rest of the stuff> to see the current progress

I tried to execute it but it remains running don't give error. I wait for more than 3 hours.

That's an expected behavior, try using a lower timeout, the default timeout is 24 hours.

That's an expected behavior, try using a lower timeout, the default timeout is 24 hours.

It works. After specifying -v4 before analyze it worked

It works. After specifying -v4 before analyze it worked


Ask for branch to base on when creating a new branch #28

First version. @tfenster do you think we need a setting for it?
Like: baseOfNewBranch with the following options

current branch
ask me
default branch of remote repo

hm, I think it will annoy me if I always have to select it... VS Code has two actions, I think, "create branch" and "create branch from...", but that wouldn't work well with the icon action that we have

Get your point. And a setting might be too strict. I'll leave it as draft for now, maybe we find a better solution the next days

Maybe we could have a "ask me: yes/no" toggle. That would also enable all scenarios, but might be easier to understand

So you mean a toggle that set's a setting? That enables indeed everything and we can add that. But I won't be able to make it today or the next week as it's pretty full for me and then I'm on vacation. If you can make it earlier, feel free to change it otherwise I'll pick it up later.
Just leaving this screenshot here as I noticed I didn't explained how it's working up until now:

You get asked, but the current branch is at the top, so that you can diretly enter it away. 2nd entry is the default branch of the remote and 3rd is the default branch as well, but in your local repo (don't know when I would use that option honestly). Then it's simply followed by all local, then all remote branches, but I think then I would use the search functionality anyway.

Just found some time adding it. The settings are now added, but the UI-Toggle to switch the "askForBaseBranch" one is still missing

@DavidFeldhoff fine for me. I meant a boolean setting when I said "toogle", so I would accept this as is

Okay, I don't see it as necessary as well, so if you accept it, I'll close it


chore: always inject settings

Fixes #N/A
Description
This PR changes the injection behavior such that settings are always injected into the context, even when the karpenter-global-settings configmap is not present. In that case, the default settings are injected.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 6 (33.33%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 82.217%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/operator/injection/injection.go
1
2
50.0%

pkg/apis/settings/settings.go
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/topology.go
2
86.49%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

pkg/test/cachesyncingclient.go
2
80.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
9159

Relevant Lines:
11140

💛  - Coveralls


fernbach add white background behind flask with alpha

Adds white background with alpha behind the flask.
This looks nicer when stacking up flasks in figures
See below example: left for new .svg, right for old .svg

I stick with CC0, if it matters. Don't need attribution.

Great. Thanks for contributing!


Add Dockerfile for opensuse-based kubectl

This image should be changed to use packages built by the build service for openSUSE. Adding static binaries build by third parties is not considered a best practice.
The right approach would be to get kubectl by installing the package that provides it (kubernetes-client from obs://Virtualization:containers - the package is going to land into the main repos of 42.3 because it's already on Factory).
Please take a look at this image to see how the external repository can be added in a secure way.

Thanks for the feedback. I updated my branch with a commit which uses OBS now.

@flavio Out of curiosity: Why is the key fetched from the key server at build time instead of putting it into the sources of the docker build?

@flavio Out of curiosity: Why is the key fetched from the key server at build time instead of putting it into the sources of the docker build?

We had a discussion with upstream about the best way to add repositories gpg keys into generic hosts (could be containers or traditional systems). This was the solution we agreed upon because it was considered the most secure one.


[Question]: "The HTTP request timed out after 00:01:00" errors on all our self-hosted agents

Describe your question
We've noticed that each machine running a self-hosted agent in our environment logs Event 100 for the VstsAgentService source in the Windows event log many times each weekday, and rarely on the weekend. I'm wondering if anyone has an idea what might cause this. This is happening on Server and Workstation operating system and multiple versions of the agent.
The error is:
"Agent connect error: The HTTP request timed out after 00:01:00.. Retrying until reconnected."
Each time this happens, the following is logged in the Agent log file':
2023-06-23 13:45:29Z WARN VisualStudioServices] Authentication failed with status code 401.
Cache-Control: no-cache
Pragma: no-cache
P3P: CP="CAO DSP COR ADMa DEV CONo TELo CUR PSA PSD TAI IVDo OUR SAMi BUS DEM NAV STA UNI COM INT PHY ONL FIN PUR LOC CNT"
WWW-Authenticate: Bearer authorization_uri=https://login.microsoftonline.com/82815b8c-3775-4599-97c7-2b87528e6f83, Basic realm="https://tfsprodcus2.visualstudio.com/", TFS-Federated
X-TFS-ProcessId: 45964906-4ee2-4b94-afb8-fe37aaa9bae9
Strict-Transport-Security: max-age=31536000; includeSubDomains
ActivityId: 23fc1cfd-d6ea-4f0c-8a0f-dba279207054
X-TFS-Session: 79fd10f0-32d8-4136-bbdb-d6910bdfa8ce
X-VSS-E2EID: be22c208-2135-4cf5-b308-3606ed6b62e5
X-VSS-SenderDeploymentId: e3b46be9-fd8c-bada-74e4-ce06f10dcc5d
X-Frame-Options: SAMEORIGIN
X-TFS-FedAuthRealm: https://tfsprodcus2.visualstudio.com/
X-TFS-FedAuthIssuer: https://dev.azure.com/haigroupdev/
X-VSS-AuthorizationEndpoint: https://vssps.dev.azure.com/haigroupdev/
X-VSS-ResourceTenant: 82815b8c-3775-4599-97c7-2b87528e6f83
X-VSS-S2STargetService: 00000002-0000-8888-8000-000000000000/visualstudio.com
X-TFS-FedAuthRedirect: https://spsprodcus2.vssps.visualstudio.com/_signin?realm=dev.azure.com&reply_to=https%3A%2F%2Fdev.azure.com%2Fhaigroupdev%2F_apis%2Fdistributedtask%2Fpools%2F38%2Fmessages%3FsessionId%3Dd48f3710-c3ba-4390-9e04-7e737c1a32d8&redirect=1&hid=0d1f1ab2-bc98-469f-ad46-94d8d815f49b&context=eyJodCI6MiwiaGlkIjoiOTk0MzBjNTktMDVhOC00YWZjLWE0MjgtNWVlY2FmMTc4ZGQ1IiwicXMiOnt9LCJyciI6IiIsInZoIjoiIiwiY3YiOiIiLCJjcyI6IiJ90#ctx=eyJTaWduSW5Db29raWVEb21haW5zIjpbImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSIsImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSJdfQ2
Request-Context: appId=cid-v1:f0601cad-6271-4f14-ae54-9c8a0b5e0b9c
Access-Control-Expose-Headers: Request-Context
X-Content-Type-Options: nosniff
X-Cache: CONFIG_NOCACHE
X-MSEdge-Ref: Ref A: E3D607CE1CE34971AFB5F867A73194D8 Ref B: EWR30EDGE1014 Ref C: 2023-06-23T13:45:30Z
Date: Fri, 23 Jun 2023 13:45:30 GMT
[2023-06-23 13:45:29Z INFO RSAEncryptedFileKeyManager] Loading RSA key parameters from file C:\AzDevOpsAgent.HAI01P-Build01-NonProd-Test.credentials_rsaparams
[2023-06-23 13:45:30Z INFO VisualStudioServices] AAD Correlation ID for this token request: Unknown
[2023-06-23 14:01:21Z INFO MessageListener] No message retrieved from session 'd48f3710-c3ba-4390-9e04-7e737c1a32d8' within last 30 minutes.
[2023-06-23 14:27:23Z WARN VisualStudioServices] GET request to https://dev.azure.com/haigroupdev/_apis/distributedtask/pools/38/messages?sessionId=d48f3710-c3ba-4390-9e04-7e737c1a32d8 timed out after 60 seconds.
[2023-06-23 14:27:23Z ERR  MessageListener] Catch exception during get next message.
[2023-06-23 14:27:23Z ERR  MessageListener] System.TimeoutException: The HTTP request timed out after 00:01:00.
---> System.Threading.Tasks.TaskCanceledException: The operation was canceled.
---> System.IO.IOException: Unable to read data from the transport connection: The I/O operation has been aborted because of either a thread exit or an application request..
---> System.Net.Sockets.SocketException (995): The I/O operation has been aborted because of either a thread exit or an application request.
--- End of inner exception stack trace ---
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource<System.Int32>.GetResult(Int16 token)
at System.Net.Security.SslStream.EnsureFullTlsFrameAsync[TIOAdapter](TIOAdapter adapter)
at System.Net.Security.SslStream.ReadAsyncInternal[TIOAdapter](TIOAdapter adapter, Memory1 buffer)    at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    --- End of inner exception stack trace ---    at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.AuthenticationHelper.SendWithNtAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)    at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)    at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)    --- End of inner exception stack trace ---    at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)    at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)    at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)    at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)    at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpMethod method, IEnumerable1 additionalHeaders, Guid locationId, Object routeValues, ApiResourceVersion version, HttpContent content, IEnumerable`1 queryParameters, Object userState, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.Listener.MessageListener.GetNextMessageAsync(CancellationToken token) in D:\a\1\s\src\Agent.Listener\MessageListener.cs:line 177
[2023-06-23 14:27:23Z INFO MessageListener] Retriable exception: The HTTP request timed out after 00:01:00.
[2023-06-23 14:27:23Z ERR  Terminal] WRITE ERROR: 2023-06-23 14:27:23Z: Agent connect error: The HTTP request timed out after 00:01:00.. Retrying until reconnected.
[2023-06-23 14:27:23Z INFO AgentServer] Refresh MessageQueue VssConnection to get on a different AFD node.
[2023-06-23 14:27:23Z INFO AgentServer] Establish connection with 60 seconds timeout.
[2023-06-23 14:27:23Z INFO VisualStudioServices] Starting operation Location.GetConnectionData
[2023-06-23 14:27:24Z INFO VisualStudioServices] Finished operation Location.GetConnectionData
[2023-06-23 14:27:24Z INFO MessageListener] Sleeping for 28.756 seconds before retrying.
[2023-06-23 14:28:43Z INFO Terminal] WRITE LINE: 2023-06-23 14:28:43Z: Agent reconnected.
[2023-06-23 14:32:03Z INFO MessageListener] No message retrieved from session 'd48f3710-c3ba-4390-9e04-7e737c1a32d8' within last 30 minutes.
Versions
2.214.1 / WinSvr2019 (Azure VM)
2.214.1 / WinSvr2012 (On-Prem VM)
2.214.1 / WinSvr2016 (On-Prem VM)
3.220.5 / Win10 (On-Prem VM)
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
WinSvr2019, WinSvr2012, WinSvr2016, Win10
Version controll system
Git
Azure DevOps Server Version (if applicable)
No response

Hi @kquinn-hai !
Since the issue appears on several machines and on different agent versions, and I presume the agent is configured to run as a service these errors most likely indicate general network connection issues inside your network or the connection issues caused by proxy or firewall settings. The agent is trying to connect with ADO every minute, and it is expected to get one or two  Authentication failed with status code 401. warnings, but in this case, it looks like the connection is getting interrupted due to some network throttling. Could you please check whether the network is stable?
Besides that, there is a possibility that the running job utilizes all CPU/Network capabilities, which interrupts the agent connection and leads to timeouts. Could you please check if these errors happened during the pipeline execution, or while the agents are in downtime?
Additionally, you can try to apply the HttpTimeoutException workaround - https://github.com/microsoft/azure-pipelines-agent/blob/master/docs/troubleshooting.md#workaround-httptimeoutexception

Thank you for your reply @vmapetr.
Unfortunately, the firewall doesn't appear to be interrupting/blocking any of this traffic, and it appears the network is stable. We have plenty of on-prem resources reaching out to Azure without issue, although none other than these agents reach out to Azure DevOps as far as I know. Our agents are not over-burdened either. Most of their time is spent idle, and I've observed the error I reported occurring plenty while the machines are consuming a small amount of resources.
I will try the HttpTimeoutException workaround on a couple of our machines to see if there is any noticeable effect.

@kquinn-hai Hello. If you still have this issue, you can try placing .proxy file containing proxy server URL in main folder where agent is installed, for example in C:\Azure. I had same problem as you, and having .proxy file and restarting service helped for me. I hope it will help you as well :)

@KhazAkar, is this file only present under certain conditions? I don't seem to have one.

@kquinn-hai You need to create it yourself. It contains URL to your company proxy server :)

@KhazAkar, ah I suspected so. We don't use a proxy server, so I guess this option won't apply. Thanks for the suggestion!

@kquinn-hai then I have another suggestion - do used user for azure pipeline agent have Log On As A Service capability enabled? You can check for that if you login to this PC over RDP and have this connection stay. I assume here, that your agent runs on windows and you use service to keep connection ongoing from PC to Azure.

@vmapetr, I just wanted to report back and say that I did try the HttpTimeoutException workaround on several of our machines, but it unfortunately doesn't appear to have any effect. I want to make sure I did this correctly, though. Am I correct to understand that these variable values should be stored as OS-level environment variables?

@KhazAkar, thanks for the additional suggestion. Our pipeline agents do run as Active Directory accounts, and Log On as a Service is already enabled for those accounts.

@kquinn-hai then I don't have no idea. Enabling logon as a service + adding proxy configuration helped in my case, until IT team resets logon as a service capability from account I've plugged in windows service :)

I noticed a similar problem with a totally different setup.
The agent's Linux environment does not utilize the memory nor CPU cores fully in my case. There is still a limit according to the logs. The bandwidth usage is negligible yet the pipeline jobs running will sometimes result in the API timeouts and errors due to not receiving responses in time (from different MS endpoints). Totally randomly, on different request types.
In my case they are used with mostly deployment APIs ran through the agents.
The connection lost status seems not to correlate with the API failed responses (perhaps it's coincidental), regardless it is there.
"The agent is trying to connect with ADO every minute, and it is expected to get one or two  Authentication failed with status code 401."
Is this mechanism by design? Is the agents software supposed to show this log during normal operations?
Why would it drop the connectivity, if the connectivity is normally working, is this the outage/delay on the ADO's side?

@Matthew0x @kquinn-hai this is a long shot, but are your agents running within a VNET? I've run into this issue when running self hosted ADO agents within an Azure VNET.
We resolved it by deploying a NAT gateway and associating it the respective subnet where the agents reside.  This gives a dedicated outbound IP address to the agents when connecting to ADO.  We rarely see timeouts now.  Prior to this, we'd see multiple timeouts per hour on multiple agents.

Yes, it's based on private network. I think you could be right that assigning a static public IP behind a firewall/NAT could help and be somehow prioritized in the traffic...
I found a piece of documentation that says:
"The public IPv4 address used for the access is called the default outbound access IP. This IP is implicit and belongs to Microsoft. This IP address is subject to change and it's not recommended to depend on it for production workloads."
Not much explanation provided.

We also hit the same issue with azure container instance. It takes long time to recover connectivity, causing azure devops pipeline to fail. Meanwhile, when the issue happens, it can't access azure storage account neither.
This confirms it being a source connectivity issue from azure container instance.

Issue should be reopened as it is still relevant today.

It's permanently relevant.

Still the issue is facing with Azure Container instance


integrate Astro based sitemap for www.intellectualfrontiers.com

Site map is missing in the website www.intellectualfrontiers.com. Please work on astro based sitemap

Updated and verified with SEO team


[Task]: update MSSQL JDBC Driver

What needs to happen?
Update version of MSSQL jdbc driver included in Hop installation.
https://mvnrepository.com/artifact/com.microsoft.sqlserver/mssql-jdbc
Issue Priority
Priority: 2
Issue Component
Component: Database

already done with #2445


Incorrect information for push-jobs

chef-ingredients is required by push-jobs.
chef-ingredients requires Chef 12.+
push-jobs can not run on Chef 11.4+

I'm confused by what you've written here @ThePhunny. Push Jobs works fine with the Chef Server 11.4 and greater, so I'm not sure what behavior you were seeing. I'm going to close this, but please reopen if you have more info to share. Sorry for the slow reply on this.


USHIFT-1456: use more complete version numbers in release tagging

We had 2 builds of 4.14.0~ec.3, which confused the release note tool. This
change adds the date and patch number values from the RPM version to the
tag and release name in case we have a similar issue in the future.
/assign @ggiguash

/lgtm

@dhellmann, Looks like Python linter is complaining.

/hold cancel

/lgtm


Image load slowness regression

https://viewer.imaging.datacommons.cancer.gov/viewer/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.243406849348906151042089406192?seriesInstanceUID=<IP_ADDRESS>.4.1.145<IP_ADDRESS>.1706.4009.304054433668574201838767925472 mentioned in https://github.com/OHIF/Viewers/issues/2192 used to load in the past, but not anymore.
Related to this, can we discuss the options for testing approaches to identify this kind of regressions, or at least have a way to measure load of a series to facilitate manual testing?

This is another scaling issue, probably due to the large number of requests.  Several of the frames have very long load times:

adding @wlongabaugh

I did some debugging and I could reproduce that when scrolling the image the _isDisplaySetReconstructable is called in an almost infinite loop and since in _isDisplaySetReconstructable we do "heavy" checks (i.e.: https://github.com/OHIF/Viewers/commit/b59187c74dfd91fc886ef0314809b097c5f84006 ) the interface gets stucked. We could find better heuristics for the checks in _isDisplaySetReconstructable (but they are actaully pretty fast < 1 sec). @igoroctaviano do you have any idea why _isDisplaySetReconstructable is called so many times? should it just be called once at initialization?

I think having test for checking the viewer loading time will be difficult: the reproducibility can be low and produce easly false negative, since the general loading of the viewer can heavly depends on the donwload time of the data.
But definitely we should have tests checking the viewer components updates. @igoroctaviano are these type of tests already in place?

@Punzo you could use tools like profiler to keep track of how long that function took to execute and take notes. I think component rendering should be the last resort considering that the majority of studies load fine.

sure, I can mesaure the perfomances. But again my point is that calling N multiple times (where N is actually pretty large) the function VTKMPRToolbarButton everytime we scroll (still have to check if it happens with other interactions) an image does not make any sense.

I analized the perfomances and in teh case of 512x512x3000 voxels _isDisplaySetReconstructable takes 7 sec to run. It is long, but at the moment we don't have better heuristic and we have to make a sequantial double loop for. Also the total time spent is mostly _isDisplaySetReconstructable so definitevely the slowness  issue is there.
A better heuristic would be checking 4D tags, e.g. the presence of multiple TemporalPositionIdentifier values. However, some studies (e.g. https://github.com/OHIF/Viewers/issues/2113) do not have such tags. So, assuming that slices at different time have the same position, at the moment we just check if there are multiple slices for the same ImagePositionPatient and disable MPR.
I still believe taht we should call _isDisplaySetReconstructable only once when we load the study/series and not N times everytime we do an interaction with the view.

Just noticed/realized that there is already one PR https://github.com/OHIF/Viewers/pull/2274 , which should solve this (exactly calculating _isDisplaySetReconstructable only once and save it as a flag). @racacere @swederik what is the status of the PR?

@Punzo Hi, I submitted that PR a couples of weeks ago, but it haven't be reviewed yet. However, at my workplace we have been using this solution on our public OHIF fork for a while and it works quite well.

A better heuristic would be checking 4D tags, e.g. the presence of multiple TemporalPositionIdentifier values. However, some studies (e.g. #2113) do not have such tags.

I am afraid there may be no robust alternative in the existing data to checking for overlapping frames.
But we could precompute "is 4D" flag for each series on IDC. It would not be in DICOM. Should we even consider this as an approach?

But we could precompute "is 4D" flag for each series on IDC. It would not be in DICOM. Should we even consider this as an approach?

Fixing it in OHIF makes much more sense to me.

Sorry for the confusion, I meant doing that in addition to fixing repeated 4D checking in OHIF.

@Punzo Hi, I submitted that PR a couples of weeks ago, but it haven't be reviewed yet. However, at my workplace we have been using this solution on our public OHIF fork for a while and it works quite well.

perfect, I will test and review. @igoroctaviano could you also review the PR, please?

Fixing it in OHIF makes much more sense to me.

I agree.

Sorry for the confusion, I meant doing that in addition to fixing repeated 4D checking in OHIF.

for sure we can add a 4d tags in IDC data, but I remind a couple of conversations that we didn't want to add custom IDC specific metadata outside from the DICOM standard in the data (we had this conversaion for the overlapping segmentation).
I would say once we merge the @racacere PR, the viewer should be responsive again and we can properly test again and see if we need to boost the perfomance with precomputed tags or not.

Looks much better in 4.9.7! Instructions for performance regression testing have been added to IDC Viewer test docs, so closing this issue.


Add support for HTTP custom paths

This PR adds support for deploying functions in a specific path. This is needed to solve #33.
It does require to have an Ingress Controller running. I used the one available at https://github.com/kubeless/kubeless/blob/master/manifests/ingress/ingress-controller.yaml.
It also includes an example for deploying a function under a certain path.

did you test this with the default ingress controller on GKE ?

Yes. It doesn't work because it requires to interpret the annotation 'ingress.kubernetes.io/rewrite-target': '/', and it is not supported.


Devtools crash the page

Version
5.0.0-beta.3
Browser and OS info
Windows 10, Chrome 69.0.497.92
Steps to reproduce
When the extension is enabled, my current application in a dev server becomes a white page. The following error shows in the console:
Uncaught TypeError: Cannot read property 'getters' of undefined
    at numberOfClients (webpack-internal:///715:189)
    at wrappedGetter (webpack-internal:///7:632)
    at Vue$3.computed.(:3066/anonymous function) (webpack-internal:///7:435:42)
    at Watcher.get (webpack-internal:///1:3114)
    at Watcher.evaluate (webpack-internal:///1:3221)
    at Vue$3.computedGetter [as auth/numberOfClients] (webpack-internal:///1:3473)
    at Object.get [as auth/numberOfClients] (webpack-internal:///7:437)
    at l (<anonymous>:1:1915)
    at l (<anonymous>:1:1912)
    at i (<anonymous>:1:2190)

npm list | grep vue
│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
// store/modules/auth/getters.js
import store from 'store';

// Some more things

export function numberOfClients(state) {
  let clients = store.getters['auth/clients'];
  return clients.length;
};

What is expected?
The page keeps functioning and the devtools do something that helps me develop the application
What is actually happening?
White screen. Page does not reach the first render cycle, while without the dev tools the page renders just fine.

We need a minimal reproduction, this works fine in our tests.

To reproduce use the following code and enable the 5.0.0-beta3 version of the dev tools. The page will crash with a Uncaught TypeError: Cannot read property 'getters' of undefined and not render anything. If disabled in the modules from /store/index.js it will show the test text. If the extension is disabled, the text will also show. If the 4.1.5 beta version of the dev tools is enabled, it will also show the text.
// src/js/main.js
import Vue from 'vue';
import router from './router';
import store from './store';
import App from 'components/App';

/* eslint-disable no-new */
(function(vue) {
  console.log(store, vue);
})(new Vue({
  el: '#app',
  store,
  router,
  template: '<App/>',
  components: { App },
}));

// src/js/components/App.vue
<template>

    This is a test

</template>

// src/js/store/index.js
import Vue from 'vue';
import Vuex from 'vuex';
import auth from './modules/auth';

Vue.use(Vuex);

const appStore = {
  modules: {
    auth,
  },
};

const store = new Vuex.Store(appStore);

export default store;

// src/js/store/modules/auth/index.js
import * as getters from './getters';
export default {
  namespaced: true,
  getters,
};

// src/js/store/modules/auth/getters.js
import store from 'store';
export function numberOfClients(state) {
  let clients = store.getters['auth/clients'];
  return clients.length;
};

// src/js/router/index.js
import Vue from 'vue';
import VueRouter from 'vue-router';

Vue.use(VueRouter);

const routes = [];

const Router = new VueRouter({
  routes
});

export default Router;

// build/webpack.base.conf.js
var path = require('path')
var utils = require('./utils')
var config = require('../config')
var vueLoaderConfig = require('./vue-loader.conf')

function resolve (dir) {
  return path.join(__dirname, '..', dir)
}

module.exports = {
  entry: {
    app: './src/js/main.js'
  },
  output: {
    path: config.build.assetsRoot,
    filename: '[name].js',
    publicPath: process.env.NODE_ENV === 'production'
      ? config.build.assetsPublicPath
      : config.dev.assetsPublicPath
  },
  resolve: {
    extensions: ['.js', '.vue', '.json'],
    alias: {
      'vue$': 'vue/dist/vue.esm.js',
      '@': resolve('src'),
      'src': resolve('src'),
      'assets': resolve('src/assets'),
      'components': resolve('src/js/components'),
      'config': resolve('config'),
      'styles': resolve('src/scss'),
      'api': resolve('src/js/api'),
      'router': resolve('src/js/router'),
      'helpers': resolve('src/js/helpers'),
      'constants': resolve('src/js/constants'),
      'store': resolve('src/js/store'),
      'vendor': resolve('src/js/vendor'),
      'theme': resolve('src/js/theme'),
    }
  },
  module: {
    rules: [
      {
        test: /\.(js|vue)$/,
        loader: 'eslint-loader',
        enforce: 'pre',
        include: [resolve('src'), resolve('config'), resolve('test')],
        options: {
          formatter: require('eslint-friendly-formatter')
        }
      },
      {
        test: /\.vue$/,
        loader: 'vue-loader',
        options: vueLoaderConfig
      },
      {
        test: /\.js$/,
        loader: 'babel-loader',
        include: [resolve('src'), resolve('config'), resolve('test')]
      },
      {
        test: /\.json$/,
        loader: 'json-loader'
      },
      {
        test: /\.(png|jpe?g|gif|svg)(\?.*)?$/,
        loader: 'url-loader',
        query: {
          limit: 10000,
          name: utils.assetsPath('img/[name].[hash:7].[ext]')
        }
      },
      { test: /\.woff(2)?(\?v=[0-9]\.[0-9]\.[0-9])?$/, loader: "url-loader?limit=10000&mimetype=application/font-woff" },
      { test: /\.(ttf|eot)(\?v=[0-9]\.[0-9]\.[0-9])?$/, loader: "file-loader" },
    ]
  }
}

// build/webpack.dev.conf.js
var utils = require('./utils')
var webpack = require('webpack')
var config = require('../config')
var merge = require('webpack-merge')
var baseWebpackConfig = require('./webpack.base.conf')
var HtmlWebpackPlugin = require('html-webpack-plugin')
var FriendlyErrorsPlugin = require('friendly-errors-webpack-plugin')

// add hot-reload related code to entry chunks
Object.keys(baseWebpackConfig.entry).forEach(function (name) {
  baseWebpackConfig.entry[name] = ['./build/dev-client'].concat(baseWebpackConfig.entry[name])
})

module.exports = merge(baseWebpackConfig, {
  module: {
    rules: utils.styleLoaders({ sourceMap: config.dev.cssSourceMap })
  },
  // eval-source-map is faster for development
  devtool: 'eval', // #inline-source-map',
  output: {
    devtoolModuleFilenameTemplate: info => {
      let filename = info.resourcePath;
      if (info.resource.match(/\.vue$/)) {
        filename = info.allLoaders.match(/type=script/) ? info.resourcePath : 'generated';
      }
      return filename;
    },
  },
  plugins: [
    new webpack.DefinePlugin({
      'process.env': config.dev.env
    }),
    // https://github.com/glenjamin/webpack-hot-middleware#installation--usage
    new webpack.HotModuleReplacementPlugin(),
    new webpack.NoEmitOnErrorsPlugin(),
    // https://github.com/ampedandwired/html-webpack-plugin
    new HtmlWebpackPlugin({
      filename: 'index.html',
      template: 'index.html',
      inject: true
    }),
    new FriendlyErrorsPlugin()
  ]
})

@Akryum Please let me know if you need anything else

Hi I get the same/simular. (white page)
"vue": "^2.5.17",
"vuex": "^3.0.1",
Chrome: 69.0.3497.100 (64-bit)
When I use 4.1.5 beta extension everything works fine landing page ok, no errors in console
When I use 5.0.0 beta 3 the app "doesn't start" (white page)
With 5.0.0 beta 3 error in console:
vue.esm.js?efeb:3147 Uncaught TypeError: Cannot read property 'Value' of undefined
    at highBandwidth (getters.js?73dc:6)
    at wrappedGetter (vuex.esm.js?358c:734)
    at Vue.computed.(:8080/anonymous function) (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:541:42)
    at Watcher.get (vue.esm.js?efeb:3142)
    at Watcher.evaluate (vue.esm.js?efeb:3249)
    at Vue.computedGetter [as settings/highBandwidth] (vue.esm.js?efeb:3507)
    at Object.get [as settings/highBandwidth] (vuex.esm.js?358c:536)
    at l (<anonymous>:1:1915)
    at l (<anonymous>:1:1912)
    at i (<anonymous>:1:2190)

getters.js in state module settings:
const highBandwidth =
  state => state.settingGroups.map(group => group.Settings).reduce((a, b) =>
    a.concat(b), []).find(s => s.Name === 'HighBandwidth').Value === 'true'

At landing/login page highBandwidth is not available yet. (settings is retrived on login)
but highBandwidth is not used yet either
highBandwidth is used in the navbar component
the navbar component is used in app.vue but disabled with v-if="showNavBar" (false)
at the login/landing page. Only login dialog/view is present.
<template>

    <navbar-element v-if="showNavBar" :live="live" @toggleLiveMode="toggleLiveMode" @refresh="refresh()"/>
    <router-view ref="view"/>

</template>

It looks like the new dev tool tool crawls through my getters even though they have not yet been used
and then crashes the app when the highBandwidth getter is not ready.
Hope this helps.
Thank you for your effort to the vue community.

May be related to #443

@Akryum This issue differs from the one linked, in that this issue refers to an issue where the Vue devtools crash (or used to crash, haven't tested it in a while) if you do an import store from './store' (at least, I believe that was this issue). For some reason instead of getting an actual store, you get undefined with the devtools open. With the devtools closed, it works as expected.
The issue referenced simply complains about getters being automatically calculated when opening the devtools, sometimes causing errors to be printed in the console even though no code referencing the getters was being called.


DOC: Document PAGE NOT FOUND

Issue with current documentation:
404 page: https://python.langchain.com/docs/contributing/integration
referenced by: https://python.langchain.com/docs/contributing/

Idea or request for content:
No response

You are probably looking for this, right?

If we look at the index.mdx file in line 17, we need to update the ./integration to ./integrations

If we look at the index.mdx file in line 17, we need to update the ./integration to ./integrations

#14999

Thank you for the Expedient fix!


Wiki?

README says:

...along with a screenshot of the output from cap production slack:deploy:test and I'll add it to the Wiki

But I see no Wiki!
Does that mean nobody has shared any yet?

Yep. No one has shared anything yet :/

Oh dear! I'll post one!


Custom icon font

Hi!
Is it possible to use custom fonts? When I try to add mine, for example:
          left={{
              icon: "back",
              iconColor: "#838383",
              label: "Back",
              style:{color: '#838383', fontSize: 13, fontFamily: 'rubik-regular'},
              onPress: () => Actions.stock()
            }}

I get the character "?" on the icon. But it works on the rest of the app, only on the Navbar it's not working.
Doing something wrong?

We're not doing anything specific about button styles. These styles are just passed to the underlying component, nothing else. It's less likely that this issue is caused by this library.

Don't really know what I am doing it wrong... I get the error saying it is expecting other names (from IonIcons) but Im calling my own custom font, and I even imported corretly.
It works fine on other stuff, only not working on the NavBar.


Hide nextra-theme-blog pages using frontMatter 'display: hidden'

Updated collect.ts is check for page frontMatter property 'display: hidden' to hide individual pages from nav
Added changset spicy-cycles-grin

Happy to fix whatever is needed to deploy this. I've seen a few people ask to be able to hide individual pages including myself.

please create an issue first


Create GNSS documents bucket using terraform

The name of the S3 bucket ( gnss-documents-{env} ) is open for discussion. There is a bucked named ga-gnss-documentation in s3, which has no environment suffix.

As suggested, I have rename the S3 bucket to "gnss-metadata-document-storage-${var.environment}".

The PR is ready for review again.

As suggested, I have rename s3bucket.tf to document_storage.tf.


Buffer bundles that exceed cost model

Problem
Bundles are failing the QOS cost model when blocks are full.
Summary of Changes
Buffer bundles that exceed the QOS cost model.

lgtm plz squash + merge when ready

have @segfaultdoc take a look too

gonna update frankfurt-1 and let it bake for a few leader rotations with the log statement, just to verify

forced pushed to wrong branch
cherry-picking from 1.13.6-jito


Use the precise number of approvals when constructing RawOrgin::Members

Close #9604

Can you please take a look at this PR? @shawntabrizi @thiolliere

can you please write a test?

Okay, this makes sense to me. Can you please write a test?

@shawntabrizi Added a test in https://github.com/liuchengxu/substrate/commit/118c272d5917ff705f461b71febcbee458963790. I also separated out tests.rs and did some refactoring, but should be easy to review by each commit.

maybe you need to merge master to fix CI

and we should revert this change https://github.com/paritytech/substrate/pull/9647/files#r706082154

@thiolliere Not sure I fully understand this, do you mean we should use the hardcoded proposal hash instead of using the variable hash?

and we should revert this change https://github.com/paritytech/substrate/pull/9647/files#r706082154

@thiolliere Not sure I fully understand this, do you mean we should use the hardcoded proposal hash instead of using the variable hash?

it was about the commit to try to fix CI. But master has been merged with the fix. so all good now.

bot merge


Download URL times out

The download URL at
http://bioinformatics.bc.edu/~jsa/aerial.aerosaite-1.4.4-standalone.jar
is reachable but times out.
DNS lookup still works but there apparently is no working web site.
Is it possible to mirror the jar somewhere else?

Hello, we are checking into the issue.  I am also going to see if I can place the artifacts in another location.

site is back up and accessible.  please try and give a comment here on how it works for you now

spoke too soon.  I am now informed that the site is temporarily unavailable to the public due to a migration that is currently being conducted.  I can ping here when that is complete.
I'm not sure I know of a good place to mirror the resources, and would be open to any more "public" suggestions.  I don't think the size of 66MB would be appropriate for clojars, but maybe I'm wrong about that?
The typical "last resort" would be to clone the repo and build locally:
`
git clone https://github.com/jsa-aerial/aerosaite
cd aerosaite/
set LEIN_SNAPSHOTS_IN_RELEASE to true
in tcsh: setenv LEIN_SNAPSHOTS_IN_RELEASE true
in bash: export LEIN_SNAPSHOTS_IN_RELEASE true
lein uberjar
`

you still won't be able to get the mkl libs automatically as they are downloaded from the same site.  But if you already have them (for some other reason), Neanderthal and friends should still work.  Actually, it is possible that newer (41+) versions will work as they will find the MKL libs from bytedeco.

see new README info about how to use wget for new mirror on google cloud storage.  MKL libs will fail to download during install but I am working on getting them up on the same cloud drive.  Programmatically grabbing them seems to be a nightmare as google keeps changing the api.  But as a crutch I could give similar wget recipes for getting them manually


Text generated is "too long"

Here is a screenshot of what I mean - you can see that on the original load, using a mobile device tool on Chrome, the text goes too far. (it should be aligned, to the left and to the right, with the blue bar underneath).

Fun fact, if I turn off the mobile device tool and then turn it on again, this happens:

So the code is doing the right thing, mostly. Let me know if you need more stuff from me.

Thank you for the screenshots - from your description I assume that re-sizing the window (without toggling chrome device mode) also results in re-rendering and correctly truncating the text, is that correct?
It would be helpful to know which children you provided to the component. Does the child re-render while <Truncate> has been mounted already, for example by fetching its text-content asynchronously?
Was there any error in the console?

There were no errors in the console, and no children were passed to the component, just jsx-interpolated text ( props.foo )
If I don't toggle chrome device mode, then resizing the window won't do anything, since it's set to the mobile width -- and my use case is mobile devices, so I didn't try on a regular browser window.

I have moved on to another module, react-ellipsify, that provided the desired behavior along with the text-expansion feature I desired, so my available time to help you troubleshoot has unfortunately been cut short for the time being.

Having revealed this bug is helpful anyway - so thanks for the contribution :sun_with_face:
I have found an explanation for the observed behavior:

Pages that are not optimized for mobile get enhanced with an "text inflating algorithm" aka "font boosting", if not prevented
Chrome Device Mode emulates rendering on a mobile device and triggers said behavior

[...] When pages load, Font Boosting increases the font size of text in wide columns, so you won't have to zoom in on them as much and hence every column fits onscreen at a legible text size. - WebKit Bug Tracker

Why is this causing trouble with react-truncate?

The calculations inside this module are based on font properties read by .getComputedStyle(). Unfortunately those numbers lie when font boosting is applied and return the initial font sizes
That explains why the text in your screenshot is cut to the correct line of numbers, but exceeds the boundaries on the right side

How can you fix it?

Solution: Be explicit to the browser about rendering on mobile and add  <meta name="viewport" content="width=device-width, initial-scale=1"> to the document head - source
Hack: Apply max-height: 999999px; CSS property to text elements to disable font boosting - source Note: this works when you run it on an actual mobile device - the chrome emulation will still apply font boosting
Use not widely adopted properties: text-size-adjust in Safari and on MDN

--
A note on the text-expansion: This is something that you could easily implement using react-truncate. In the link you provide to ellipsis you could toggle a variable in your parent component and provide it to the lines prop, 0 means the text will not be truncated

Here you have a gist for an example <ReadMore> component that wraps <Truncate>


string_buffer: truncate and cur_offset over nodes

These functions are only implemented over a single node at the moment. They should be fixed so they work with multiple node StringBuffers.

FYI, this is causing rustfmt to panic on my library (tempfile).


fix: import mxGraph XML including mxGeometry.offset mxPoint

Also add tests to confirm that the maxGraph format correctly import/export Geometry.offset.

@Duoladuola feel free to suggest changes if this doesn't cover your use case.


Correction for raw affiliation EuroMov Digital Health in Motion, Univ. Montpellier, IMT Mines-Ales, 34090 Montpellier, France

Correction needed for raw affiliation EuroMov Digital Health in Motion, Univ. Montpellier, IMT Mines-Ales, 34090 Montpellier, France
raw_affiliation_name: EuroMov Digital Health in Motion, Univ. Montpellier, IMT Mines-Ales, 34090 Montpellier, France
new_rors: 051escj72;03e8rf594
previous_rors: 051escj72
works_examples: W3092720100
contact: eeb0a7f655a58cdc63de92110d419e8a:64db998da295751346680fa2658e7ed47a5c @ mines-ales.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Add support for ndarray to set_state

Motivation and Context
Little QOL improvement change.  The error message for providing an np.ndarray is pretty uninterruptible and this feels like something that should work.
How Has This Been Tested
Locally.
Types of changes
QOL

LGTM, let's merge it.


missing image for version 0.15.10

Can you please build a new version? Thanks

Built 0.15.10 and 0.15.11.


Use higher order function (array) in code example

:tada: This PR is included in version 3.16.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No permission error

Hi,
Whenever I navigate to /usr/local/bin
The transfer of sple.sh fails with following error   (as user Serverpilot and Ubuntu"root")
Error:	/usr/local/bin/sple.sh: open for write: permission denied Error:	File transfer failed
If I try to set permissions to 775 or 777, I see this error :
Error:	set attrs for /usr/local/bin: permission denied

Hi Kyle,
These are the steps I followed to install and run the script:
1.) Login to your server with the root user. "ssh root@[IP]" this should
put you into the root home directory.
2.) git clone the repository
3.) chmod u+x sple.sh
4.) ./sple.sh
That should be all you need to do?
why are you navigating to /usr/local/bin?
On Fri, Apr 21, 2017 at 11:15 AM, KyleSforza<EMAIL_ADDRESS>wrote:

Hi,
Whenever I navigate to /usr/local/bin
The transfer of sple.sh fails due to lack of permissions. (as user
Serverpilot and Ubuntu"root")
If I try to set permissions to 775 or 777, I see this error :
Error: set attrs for /usr/local/bin: permission denied
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lesaff/serverpilot-letsencrypt/issues/35, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE5wnCHWkWUH0wS7Hz94d8j4RjQZJjWMks5ryIHIgaJpZM4NEHq8
.

--
Kind Regards,
Chris Rose
Mobile: +44 (0) 7595 526 416

Thanks @caroseuk , actually I am using Amazon server, its very restrictive it seems so I had to give write permissions to the "Serverpilot" and "Ubuntu" users to be able to download the repository.
Commands used on Linux 16.04 AWS :
chown -R  www-data:www-data /usr/local/bin sudo usermod -a -G ubuntu www-data sudo setfacl -R -m u:ubuntu:rwx /usr/local/bin
for Ubuntu user.

@KyleSforza, this script requires root access because it writes data to your /etc/nginx folder.
The proper way to install is to sudo su from your ubuntu account, save it to /usr/local/bin/ and make it executable.


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to dev, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

#92 34c6d5e Thanks @disog! - The Parser page was updated to document the new ParseInfo type, along with information regarding the parsing callbacks. The Options page was updated to document changes made to the parsing callbacks. The parseError enumerator was removed from the Validator page, since it is no longer supported.

#89 1b6b17a Thanks @disog! - Added a sub-section called "Connective words" in the Validator page, to document the new ConnectiveWords enumeration.

#88 b46a609 Thanks @disog! - Documented the new fallback attribute in the Options page.

#78 9ac4ba5 Thanks @disog! - The Validator page was updated to document the new behaviour of the validate method, namely, that it returns validation warnings as a result. The "Names validation" section was updated to document the detection of naming inconsistencies. The Playground page was updated to report validation warnings when validating the input source.

#84 4c2587a Thanks @disog! - A whole section about asynchronous parsing was removed from the Parser page, according to changes made in the code. The Validator page was updated to document a new kind of validation, namely, invalidRequiredValue.

#96 464c113 Thanks @disog! - The Options page was updated to document the new paramCount attribute of the function option. The Validator page was updated to document the new validations related to variadic options and the fuction option's parameter count.

#98 3501d5e Thanks @disog! - Updated the Formatter page to document the new breaks, required and comment properties of help sections.

#95 9d26e81 Thanks @disog! - Some subsections of the "Parameter attributes" section of the Options page were moved to a new section called "Known value attributes", to reflect changes made in the code.

#81 8070da4 Thanks @disog! - Removed the parseDelimited attribute from the "Parameter attributes" in the Options page, to reflect changes in code. Moved some text about custom phrases and format specifiers from both Formatter and Validator pages to the Styles page, where the information on this subject is now centralized.
Updated the "Error items" section of the Validator page, to reflect changes in code. In the same page, the "Enums validation" section was renamed to "Constraints validation", where the new validation rule for numeric ranges was documented.
Updated the "Help phrases" of the Formatter page to reflect changes in code. Also added a table of format specifiers to document the available phrase specifiers for help items.

Patch Changes

#74 489621b Thanks @disog! - Updated the Options page to document the new useFilters attribute for help options. Also added a tip in the Demo page for users to try out the new feature.

#73 9e40f46 Thanks @disog! - Documented the new skipCount attribute for function options in the Options page.

#71 4647beb Thanks @disog! - The Options page was updated to document the possibility of specifying a parse callback in conjunction with a separator. The Parser page was updated with more details about the behavior of the custom parsing callbacks.

<EMAIL_ADDRESS>Minor Changes

#73 9e40f46 Thanks @disog! - Added the skipCount attribute to function options to indicate the number of remaining command-line arguments to skip after returning from the execute callback.

#89 1b6b17a Thanks @disog! - Added the ConnectiveWords enumeration to be used together with the connectives property of the validator configuration, in order to customize the formatting of option requirements.

#81 8070da4 Thanks @disog! - Removed the parseDelimited attribute in anticipation for a new and better feature yet to be implemented. This parsing callback was not really important, whereas the same effect can be achieved with the parse callback by modifying the previous option value.
Improved the formatting of custom phrases for both error and help messages. Now they can contain multiple groups referencing the same phrase alternatives across groups. This also allowed the help item phrases to use specifiers for different value data types.
Added a new kind of validation, invalidNumericRange, for the option's numeric range definition. Some other enumerators were merged into one that uses a phrase containing different format specifiers for each alternative.
Refactored the ul enumeration into a constant that holds underline styles instead of underline colors (since it had just one color that was not strictly necessary).

#95 9d26e81 Thanks @disog! - Added new attributes for the boolean option: truthNames, falsityNames and caseSensitive. They can be used to configure how option parameters are converted to boolean.

#88 b46a609 Thanks @disog! - Added the fallback attribute for non-niladic options. It specifies a value that is used if the option is specified in the command-line without any parameter.

#96 464c113 Thanks @disog! - Added the paramCount attribute to the function option, to specify the number of parameters that the option expects in the command-line. New enumerators, invalidParamCount and variadicWithClusterLetter, were added to ErrorItem, that are used by the validator when validating the new attribute. The formatter was updated to take this attribute into account when rendering the description of variadic options.

#98 3501d5e Thanks @disog! - Added a breaks property to help sections, to specify the number of line breaks to insert before a section. Added the required and comment properties to the usage section, to specify options that should be considered required in the usage, as well as to append a commentary to the usage, respectively. The demo was updated to include multiple usage sections.

#78 9ac4ba5 Thanks @disog! - The validate method now returns a list of warnings. The validator was updated to detect naming inconsistencies in the option definitions and report them as warnings.

#74 489621b Thanks @disog! - Added the useFilters attribute to help option to allow remaining arguments to be used as option filters for the help message.

#84 4c2587a Thanks @disog! - The parser was refactored to more easily handle asynchronous callbacks. As a consequence, it no longer supports a synchronous parsing method.
A new kind of validation, invalidRequiredValue, was implemented for the verification of required option values in the case of options that are either always required or have a default value.

#92 34c6d5e Thanks @disog! - The parsing callbacks were refactored to accept a single parameter of type ParseInfo, which contains information about the current argument sequence in the parsing loop. The loop itself was refactored to accumulate a sequence of arguments that will be passed to the parsing callbacks as the option parameter(s). The parseError enumerator was removed from the ErrorItem, since it is no longer supported.

#71 4647beb Thanks @disog! - The separator attribute can now be used in conjunction with the parse callback. In this case, the callback will be called for each element split by the separator.

Moved to #102


Separate availableOptions and blueprints from commands.

This PR makes the options and blueprints available for tooling.
One such use case is the shell script generation.

@catull is this still needed?

@catull Is it still needed? Please rebase if it is.

Closing as inactive, please let me know if this should still be acted upon.


No Such interface supported

When a user gets a notification pop up for a mention the client crashes. Very similar to #974
My Setup

Operating System: Windows 8.1
App Version: 2.14.3, also exists in 2.14.2. Rolled back to 2.14.1 works fine.
Installation type: exe local user install not administrative program files

[x] I have tested with the latest version
[x] I can simulate the issue easily

That's an impressive response time. Thanks


Error with relationships and rows

using repeatable rows to save to a JSON field in a db. Getting this error:
   Undefined property: R64\NovaRow\Row::$resourceClass
   {"userId":1,"email":"******@gmail.com","exception":"[object]
   (ErrorException(code: 0): Undefined property: R64\\NovaRow\\Row::$resourceClass
   at /home/vagrant/code/project/nova/src/Http/Controllers/AssociatableController.php:23)

aded package with: use R64\NovaRow\Row;,  and this is the usage:
     Row::make('Questions', [
                BelongsTo::make('Questions', 'questions', Question::class)
                    ->sortable()
                    ->hideFromIndex(),
            ])

Any idea what I'm missing here? The BelongsTo field works fine without the wrapper, but won't work with it.

Still seeing the same issue after updating to the latest release. Using the same implementation as discussed previously.

Are you using R64\NovaFields\BelongsTo in the child? The fix is done in the relation

Yes, using both:
    use R64\NovaFields\Row;
    use R64\NovaFields\BelongsTo;

and in fields():
    Row::make('Questions', [
       BelongsTo::make('Questions', 'questions', Question::class)
            ->sortable()
            ->hideFromIndex(),
    ])

if I remove the Row:: and just use BelongsTo, it works with a single item (in this case question), but doesn't work with the Row. I also confirmed I have the latest updates that were pushed in v.0.2.9

what version of nova do you have?

Tried both v1.0.16 and just updated to 1.1.4, same error.

Sorry I cant reproduce this in the last version of nova. Can you remove vendor directory and composer.lock file and do a fresh composer install?

No luck. Happens as soon as I click "add row". I am also using another nova package, fourstacks/nova-repeatable-fields. Not using it on the same page, but any chance there's some conflict or something between the two?
Any other ideas to look out for? I know not much you can do without being able to repro, but this is literally the last piece I have for a project.
Really appreciate the help !

Sorry again. I tried hard to reproduce the issue but I cant. Please provide a reproduction and I will be happy to help you with


cwd of gonvim

On macOS High Sierra，when I start gonvim from dock icon，it's pwd is '/'.
Default cwd is ~ is better.

what do you mean? I'm trying to look for a way to start gonvim from command line, e.g. to open in VS code, just run
code .

but not sure how to do it with gonvim

@jerrywang1981 on macOS you can add /Applications/goneovim.app/Contents/MacOS to your $PATH and then you will able to execute goneovim .. Of course you can /Applications/goneovim.app/Contents/MacOS/goneovim ..
ephien refers to what happens when you open Goneovim as an app bundle either from the Dock, Spotlight, Launchpad or the Application directory. In those cases $PWD is set to /

@jerrywang1981 on macOS you can add /Applications/goneovim.app/Contents/MacOS to your $PATH and then you will able to execute goneovim .. Of course you can /Applications/goneovim.app/Contents/MacOS/goneovim ..
ephien refers to what happens when you open Goneovim as an app bundle either from the Dock, Spotlight, Launchpad or the Application directory. In those cases $PWD is set to /

unfortunately /Applications/goneovim.app/Contents/MacOS/goneovim . does not set cwd to a current directory. It sets directory to ~.

@onsails
Hi
This is probably a design change before and after the following commit.
I'm trying to figure out how to fix it.
https://github.com/akiyosi/goneovim/commit/2307784a4605f5251967b61fc180e96fcf21d92c

In relation to #325 and 337, I would like to change the current CWD setting specification to an approach where cwd is controlled by options.

Is there any workaround to this? Goneovim seems not to save all buffers in the current session and auto-session doesn't work. Neither does mksession, which cannot write in the root directory.
I tried adding vim.cmd('cd ~') to init.lua. It works in the console but not in Goneovim.

@dominikmayer
Could you please tell me specifically the problem you are facing?
(I understand that this issue itself is not an issue to the point that there is some kind of problem. However, I welcome you to report a related issue here.)
Tell me about the procedures and environmental conditions to reproduce or cause the problem you are facing.

After writing the comment I realized that I had excluded root in the auto-session config.
All I want to achieve is to load the last session on startup. In the terminal, auto-session loads the last session in the current working directory. Doesn't work on goneovim, though. I assume it's because the working directory is never root.
After long trials I found a workaround by adding SessionRestore to my init.lua:
if vim.g.goneovim then
  -- Restoring the last session once Vim is idle
  autocmd("VimEnter", {
    pattern = "*",
    command = "lua vim.defer_fn(function() vim.cmd('SessionRestore') end, 0)",
  })
end

I do such a configuration in my init.lua to implement this feature:
if vim.g.goneovim then
  vim.cmd('cd ~')
end


Add global labels and annotations for all pods.

There is an option to add extraAnnotation for validator pods and thats it.
For situation like adding additional info to pods (labels or annotation) required by cluster policy (eg. kyverno), deployment will fail.

Which pods are missing the ability to set annotations or labels?

alloy, kube-state-metrics, node-exporter - these ones i've checked by trying to deploy them and they don't have the option.
The ramining I'm not sure. I've based my issue on those 3 and assumed that whichever don't have extraAnnotation option, also don't have the option to add extra labels or annotations.

For alloy:
alloy:
  controller:
    podAnnotations: {}
    podLabels: {}

(repeat for alloy-logs, alloy-events, alloy-profiles)
For kube-state-metrics:
kube-state-metrics:
  customLabels: {}
  podAnnotations: {}

For Node Exporter:
prometheus-node-exporter:
  podAnnotations: {}
  podLabels: {}

The k8s-monitoring Helm chart uses subcharts to deploy these resources, so to pass a value down to the subchart, you just have to put those values inside a key of the name of the subchart. So, any values you want to send to the kube-state-metrics subchart go inside the kube-state-metrics section of the k8s-monitoring chart.

Well... that was stupid of me :D. Thank you for your time and explanation.


Fix: JE.object expects (String, JE.Value) not (String, String)

This PR. fixes the documentation in .withPayload functions that originally take (String, String) to (String, JE.Value) as per documentation of that JE.object expects (String, JE.Value) not (String, String)

Thanks!


Reporting rendering regression on PRs

Good news! Since #13248 (and #15894, #15911 and #15914) CI is now checking screenshots taken during example runs on macOS and Linux for changes.
The list of examples that are executed can be found there: https://github.com/bevyengine/bevy/tree/main/.github/example-run. At the moment, only 2 examples take a screenshot: breakout and load_gltf
The macOS run is done on every push to a PR, in the merge queue, and on main. You can find an example run there: https://github.com/bevyengine/bevy/actions/runs/11339649537/job/31534799604
The Linux run is done in the merge queue and on main. You can find an example run there: https://github.com/bevyengine/bevy/actions/runs/11339392720/job/31534437159
As you may have noticed, they both fail: this is because the example load_gltf is a tiny bit time dependent for the light movement, so not fully deterministic. Failures are currently not reported or blocking for PRs.
It is possible to make examples deterministic even when relying on time by applying the patches there, or using the example-showcase tool.
You can see a list of run here: https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D
I have some improvements planned for the reporting, but now my question to you, dear contributors: which examples should be ran and checked for changes in CI?
This issue will be fixed by changing the list of screenshots compared to a fully deterministic one (either by selecting deterministic examples, or by enabling stable time with the patches), and changes being reported by a comment on PRs (not blocking merging yet)

Really like having this.
For UI the examples I think that would be most valuable to watch would be:

pbr
borders
ui
text_wrap_debug
grid
overflow
ui_texture_slice_flp_and_tile
z_index
box_shadow

I could always add some extra elements to the ui example if that list is a bit long.

Do we have a target for the amount of examples we want to run?
It would be nice to have more "roll-up examples" like ui that show off many features of an engine area. Beyond ui, the following might be nice IMO:

lighting
split_screen
breakout
animated_fox (unfortunately this became non-deterministic at some point)

Maybe our game examples could be fleshed out to use more features, or some additional purpose-built examples could be made.

I'm trying "testbed" examples, see https://github.com/bevyengine/bevy/pull/15954
I would like to have one for 2d, one for 3d and one for UI, at least as a starting point. Once we have one for 2d and UI we can remove the "breakout" example running in CI, once we have 3d we can remove "load_gltf" and "alien_cake_addict" to keep the execution time under control

@ickshonpe could you do an example for UI in the spirit of the 2d/3d testbeds?


Weird RenderView content size

I have a RenderView to which I direct my still image output.
I noticed, that the image does not fit the space properly. On iPhone 7+, for example, it looks perfectly but all others - not so much. Especially, iPhone 4s, where the 'borders' are unacceptably large: http://imgur.com/a/HlRCh (all black space is the renderView)
If I set fill mode to .preserveAspectRatioAndFill, image gets cut from sides anyway, instead of getting smaller in the viewport.
I did some digging, and this is the info I found interesting:
7 plus
renderView.backingSize: (width : 1242, height : 2028)
UIScreen.main.scale: 3.0
renderView.frame:(0.0, 0.0, 414.0, 676.0)
renderView.sizeInPixels: Size(width: 1242.0, height: 2028.0)
5s
renderView.backingSize: (width : 828, height : 1352)
UIScreen.main.scale: 2.0
renderView.frame: (0.0, 0.0, 320.0, 508.0)
renderView.sizeInPixels: Size(width: 640.0, height: 1016.0)
4s
renderView.backingSize: (width : 828, height : 1352)
UIScreen.main.scale: 2.0
renderView.frame: (0.0, 0.0, 320.0, 420.0)
renderView.sizeInPixels: Size(width: 640.0, height: 840.0)
For some reason, 'backing size' doesn't fit the actual renderView size, and I'm guessing, it should.
Sadly, I don't know anything about OpenGL and such. Anyone has ideas on how I should deal with this?

Ok. I suppose, you should never change RenderView's contentMode property of UIView.
I returned back to Scale to Fill and I see no borders from sides. Instead, the image seems to be squished down vertically.


 Thank you!

Kinda didn't realize you asked for this, here's the top of a crash report: https://hastebin.com/igadayejux.txt
If you need more I can pm it to you on discord

This has been fixed internally (everything loads and unloads properly without tripping over each other in the thread) but may still happen if someone is using a thread in a module. This should be handled via a "gameUnload" trigger to stop running threads, not by us in the mod.