[c++] Create ArrowSchema from TileDB Array Schema (keep-open)

[x] Pass in ColumnIndexInfo that contains domain and tile extents for each index column
[x] Set attributes
[x] Set dimensions
[x] Handle nullables
[x] Handle enumerations
[ ] Set filters
[ ] Set duplicates

See also #2406

This issue exists as a coat-hanger for any schema-releated issues that may (or may not) arise while @eddelbuettel is porting @nguyenv 's C++ and Python/pybind11 work to R/Rcpp.


Migrate to UUID pk

I don't know how you are going to deal with DB migration, so I just created a sql file "backend/drizzle/uuid_pk.sql", and it should be tested carefully.
The last commit is about generating UUID by Postgres. This way is easier to use UUIDv7 in the future, and it's more suitable for Cella to cooperate with other systems and other languages.
If you want to check the code that generates the UUID by TS code, please check the next to last commit "Migrate to UUID primary keys", thanks.

Thanks @yunge !! @RomanNabukhotnyi lets discuss this tomorrow ok?


Add ability to set the zoneRedundant property when creating eventhub namespaces

Is your feature request related to a problem? Please describe.
Currently you can set zoneRedundant via ARM templates and via the portal, but not via the az CLI.
Describe the solution you'd like
I would like to be able to set the zoneRedundant property when creating eventhub namespaces via the az CLI.
Additional context

https://azure.microsoft.com/en-us/blog/azure-event-hubs-is-now-offering-support-for-availability-zones-in-preview/

Thank you for creating this issue. We  are validating this gap and we will be reporting our findings and next steps.

Any update on this?

@ablyler sorry for late response, --zone-redundant property is added to az eventhubs namespace create command. please use the latest release.
I am closing the issue, if you have any question please feel to open this one or new issue. Thanks !


(Not ready) New testing framework for the incremental compiler

The tests that are included in this PR are juste examples. I'll start porting some of the scripted tests if this new format LGTY!

SO, to help be maven frinedly, I think we need to remove the test->test dependnecy.
Instead, create a new "incrementalCOmpilerTestFramework" project which has your test-harness code and then depend on that with test->compile.
Otherwise, I love the new test DSL, looks great!

@jsuereth Would it be enough to just change the dependency marked test->test to test->compile?

@jsuereth @eed3si9n Any news on this PR?

yeah, this LGTM assuming we enable TravisCI.

I've rebase this PR and changed a few things regarding the splitting of the compiler interface. These new tests use classes defined in the compiler bridge. Because there were 2 projects, we would have needed to depend on either one based on the value of scalaVersion. Instead I merged the two projects in one, and made scalaSource depend on the value of  scalaVersion.


[TEST] Trying to relax ci install reqs

Here I am testing the issues with pandas>24, which have been observed on windows, but not linux thus far.

Coverage decreased (-10.06%) to 74.123% when pulling ebbe4bf67e61bd661a21fca466033e2e117681c2 on gidden:test-ci into a6ac0c574c3d5363fb8dba7d8b42a845fd3dbe87 on IAMconsortium:master.

@danielhuppmann it looks like we can relax the pandas constraint (at least on CI), does this jive with your understanding?


Whenever shelling out read both error and std streams for Notation client

This issue is created to replace a finding in #93.  Refer example here . https://github.com/notaryproject/notation/pull/83#discussion_r705752817
Desired Resolution

Search through all code in Notation, Notation-go, Notation-go-core and redirect stderr to console.

Errors are already printed to stderr, so suggest closing this issue @iamsamirzon

@priteshbandi  - Could you confirm and close this issue is fixed as expected?

Issue is fixed https://github.com/notaryproject/notation-go/blob/8c3ed9217dc8025983f64a5510249a94dc009a86/plugin/plugin.go#L166-L177


Monthly newletter for April 2021

I put together a draft for the April monthly newsletter and populated it from the repository activities. There has been a lot of activity at stdlib and fpm :tada:.

[x] add stdlib updates
[x] add fpm updates
[x] add fortran-lang.org updates
[x] add monthly call link
[x] add new repository fortran-forum-article-template
[x] add LLVM / classic flang updates (@AlexisPerry)
[ ] add LFortran updates (@certik)
[ ] update contributor data (@LKedward)

As usual, please add your name to the authors list if you add, edit, or review content.

Thanks a lot, @AlexisPerry.

I'll write LFortran updates today.


nexlint: introduce project linting

This introduces custom project linting using the nexlint linting
framework. As a start this patch enables the following lints via cargo xlint:

detection of duplicate versions of direct dependencies
detection of irrelevant build dependencies
checking of license headers on various file types
ensuring the root Cargo.toml file is canonical

Yep! I spent some time a month or so ago getting nextlint ready for use but didn't get around to integrating it anywhere so this was my first attempt. Once this is in here I can easily do the same for the other repos.


Problem Reproducing NELL-995 MAP Results

Thanks very much for releasing the code in accompany with the paper. It definitely makes reproducing the experiments a lot easier. I've been playing with the code base and have some questions on reproducing the NELL-995 experiments.
The codebase does not contain the configuration file for NELL-995 experiments, nor does it contains the evaluation scripts for computing MAP. (Maybe you've missed them from the release?)
I used the hyperparameters reported in "Experimental Details, section 2.3" and the appendix section 8.1 of the paper, which results in the following configuration file:
data_input_dir="datasets/data_preprocessed/nell-995/"
vocab_dir="datasets/data_preprocessed/nell-995/vocab"
total_iterations=1000
path_length=3
hidden_size=400
embedding_size=200
batch_size=64
beta=0.05
Lambda=0.02
use_entity_embeddings=1
train_entity_embeddings=1
train_relation_embeddings=1
base_output_dir="output/nell-995/"
load_model=1
model_load_dir="saved_models/nell-995/model.ckpt"

I run train & test as specified in the README, and evaluate the decoding results using the MAP computation script produced by the DeepPath paper. (I assumed that the experiment setup is exactly the same as the DeepPath paper since you compared head-to-head with them.)
However, the MAP results I obtained this way is significantly lower compared to the reported results.
MINERVA concept_athleteplaysinleague MAP: 0.810746658312 (380 queries evaluated)
MINERVA concept_athleteplaysforteam MAP: 0.649309434089 (386 queries evaluated)
MINERVA concept_organizationheadquarteredincity MAP: 0.944878371403 (246 queries evaluated)
MINERVA concept_athleteplayssport MAP: 0.919186046512 (602 queries evaluated)
MINERVA concept_personborninlocation MAP: 0.775690686628 (192 queries evaluated)
MINERVA concept_teamplayssport MAP: 0.762183612184 (111 queries evaluated)
MINERVA concept_athletehomestadium MAP: 0.519108225108 (200 queries evaluated)
MINERVA concept_worksfor MAP: 0.663530575465 (420 queries evaluated)

I did a few variation on embedding dimensions and also tried to freeze entity embeddings, yet none of the trials produced numbers close to the results tabulated in the MINERVA paper.
Would you please clarify the experiment setup for computing MAP?
I want to make sure I did set the hyperparameters to the correct value. Besides, the DeepPath paper used a relation-dependent underlying graph per relation during inference. Did you also vary the graph per relation or used a base graph for all relations like you did for other datasets?
Many thanks.

Thanks very much. I will check the difference and get back to you.

@shehzaadzd @todpole3, I encounter the same problem. What is the test_prediction_path data format? I think there seems to be a script to parse the results in test_beam?
Thanks a lot!

Thanks a lot! Looking forward to the script.
One more thing related to the setup. If I want to train on one relation only as in DeepPath (instead of jointly), should I only use one of the relations in train.txt?
such as grep concept:worksfor train.txt > train_worksfor.txt?
Thanks!

We apologize for the late reply from our side. To train on one relation; you can train on the individual graphs (exactly as in the DeepPath). For example, the data for concept:worksfor would be in here.
Also the script is the one which @shehzaadzd had linked couple of answers before (link). You can also use the same script here.
Also wanted to check with @todpole3 -- are you still facing any issues?

Thanks, I haven't been experimenting with this lately. Will check and let you know.

Hi Lee,
Thanks for trying out our code!
Can you train the single model on the data in datasets/data_preprocessed/nell-995
The datasets/data_preprocessed/nell data was changed a bit for the purpose of link prediction. It has a fewer number of examples in the train. We changed this to create a proper validation set for the database.
Tell me if you still have issues reproducing the results.
-S

Thanks for telling me this, I will run the model on nell-995 dataset and check the result ! !

Hi shehzaadzd
I have run the experiment on the dataset nell-995 with the config file above, this is my result
athleteplaysinleague:
MINERVA MAP: 0.7824126150897805 (381 queries evaluated)
worksfor:
MINERVA MAP: 0.7689410483947302 (421 queries evaluated)**(0.825)**
organizationhiredperson:
MINERVA MAP: 0.8717628574212938 (349 queries evaluated) (0.851)
athleteplayssport:
MINERVA MAP: 0.9177169707020453 (603 queries evaluated)  (0.985)
teamplayssport:
MINERVA MAP: 0.6906675170068028 (112 queries evaluated)**(0.846)**
personborninlocation:
MINERVA MAP: 0.7665333946422028 (193 queries evaluated)**(0.793)**
athletehomestadium:
MINERVA MAP: 0.5319267658819898 (201 queries evaluated)**(0.895)**
organizationheadquarteredincity:
MINERVA MAP: 0.9453257474341812 (249 queries evaluated) (0.946)
athleteplaysforteam:
MINERVA MAP: 0.6555836139169473 (387 queries evaluated) **(0.824)**

config file:
LSTM_Layer=1
data_input_dir="datasets/data_preprocessed/nell/" .
  vocab_dir="datasets/data_preprocessed/nell/vocab"
  total_iterations=3000
  path_length=3   //according to the appendix
  hidden_size=100 .   / /according to the Experimental Details, section 2.3 the hidden_size is 400:(In your code ,hidden_size = 4 * self.hidden_size, so i set the parameter to 100)
  embedding_size=100  //according to the Experimental Details, section 2.3 the embedding_size is 200 (In your code : self.entity_embedding_placeholder = tf.placeholder(tf.float32, [self.entity_vocab_size, 2 * self.embedding_size]), so i set the parameter to 100)
 batch_size=128  //default value
 beta=0.05        //according to the appendix
 Lambda=0.02   //according to the appendix
 use_entity_embeddings=1
 train_entity_embeddings=1
train_relation_embeddings=1
 base_output_dir="output/nell/worksfor"
  load_model=0
 model_load_dir="/home/sdhuliawala/logs/RL-PathRNN/nnnn/45de_3_0.06_10_0.0/model/model.ckpt"
 18 nell_evaluation=1

I also try to set the embedding size and hidden size to 50 ,the result is below
athleteplaysinleague:
MINERVA MAP: 0.7700987187207659 (381 queries evaluated)
worksfor:
MINERVA MAP: 0.7844730816821078 (421 queries evaluated)
organizationhiredperson:
MINERVA MAP: 0.8710068284974013 (349 queries evaluated)
athleteplayssport:
MINERVA MAP: 0.9182974018794915 (603 queries evaluated)
teamplayssport:
MINERVA MAP: 0.7468537414965987 (112 queries evaluated)
personborninlocation:
MINERVA MAP: 0.7555456489394312 (193 queries evaluated)
athletehomestadium:
MINERVA MAP: 0.5220393343527672 (201 queries evaluated)
organizationheadquarteredincity:
MINERVA MAP: 0.915163829922866 (249 queries evaluated)
athleteplaysforteam:
MINERVA MAP: 0.6305270311084265 (387 queries evaluated)

config file:
LSTM_Layer=1
data_input_dir="datasets/data_preprocessed/nell/" .
  vocab_dir="datasets/data_preprocessed/nell/vocab"
  total_iterations=3000
  path_length=3   //according to the appendix
  hidden_size=50 .   / /according to the Experimental Details, section 2.3 the hidden_size is 400:(In your code ,hidden_size = 4 * self.hidden_size, so i set the parameter to 100)
  embedding_size=50  //according to the Experimental Details, section 2.3 the embedding_size is 200 (In your code : self.entity_embedding_placeholder = tf.placeholder(tf.float32, [self.entity_vocab_size, 2 * self.embedding_size]), so i set the parameter to 100)
 batch_size=128  //default value
 beta=0.05        //according to the appendix
 Lambda=0.02   //according to the appendix
 use_entity_embeddings=1
 train_entity_embeddings=1
train_relation_embeddings=1
 base_output_dir="output/nell/worksfor"
  load_model=0
 model_load_dir="/home/sdhuliawala/logs/RL-PathRNN/nnnn/45de_3_0.06_10_0.0/model/model.ckpt"
 18 nell_evaluation=1

finally , i set the LSTM Layers to 3 according to your paper, the result
athleteplaysinleague:
MINERVA MAP: 0.7820689080531601 (381 queries evaluated)
worksfor:
MINERVA MAP: 0.7692186541355187 (421 queries evaluated)
organizationhiredperson:
MINERVA MAP: 0.865689742796194 (349 queries evaluated)
athleteplayssport:
MINERVA MAP: 0.9081260364842456 (603 queries evaluated)
teamplayssport:
MINERVA MAP: 0.6653698979591837 (112 queries evaluated)
personborninlocation:
MINERVA MAP: 0.7679808821000531 (193 queries evaluated)
athletehomestadium:
MINERVA MAP: 0.5379048121585435 (201 queries evaluated)
organizationheadquarteredincity:
MINERVA MAP: 0.9487218716134379 (249 queries evaluated)
athleteplaysforteam:
MINERVA MAP: 0.6487594662013266 (387 queries evaluated)

However, none of the results are similar to the result in paper,  I think i set the hyperparameters completely according to the paper or the appendix. is my config file the optimal parameter for your experiment.  Could you help me to reproduce the results?  Thanks a lot !!!!!!!!


Feature/Readium sdk for lcp

Dear Readium SDK people,
I send a pull request for updating Readium SDK to support LCP implementation.
We have tried to minimize modification in the Readium SDK for the LCP implementation as possible.
But at least following pull request is required to be updated, we think.
Here are the points why each files are modified.

Platform/Android/jni/epub3.cpp
Without the line 437, 'return nullptr' sentence, application could be crashed when it has invalid argument for  LCP EPUB.

Platform/Apple/RDServices/Main/RDContainer.mm
We added initialization (line 90) for the LCP and exception handling for button 'cancel' of the pass-phrase popup for iOS launcher.
Update for the OSX is in the file in the Launcher project, and Android treats it in the JNI area, which is in the Readium DRM project.

ePub3/ThirdParty/libzip/zip_fseek.c
Without the modification _zip_fseek_bytes() function, application would be crashed during seeking uncompressed media resource. It might be a bug of the libzip.

ePub3/ePub/container.cpp
ContentModule for the LCP does 'future.get()' internally. So without from line 124 to 137, application doesn't work in LCP EPUB.

ePub3/ePub/content_module.h
We added a pure virtual function, GetModuleName()  to detect proper Content Module in the derived class.

ePub3/ePub/content_module_manager.cpp
We don't know the reason why 'result.then' (at line 95 and 107) makes timeless waiting for LCP content module. But we have checked there is no problem to handle plain and encrypted resources even though we detoured these sentences.

And we added some error handling for the case in which EPUB is encrypted but not LCP.

ePub3/ePub/credential_request.cpp/h
We have added some additional member functions to handle to exchange authentication information between Core and pass-phrase popup in Launcher side.

ePub3/ePub/encryption.cpp/h
We have added some functions to handle additional information for the compressed and encrypted resource in the encryption.xml

A quick comment: in content_module_manager.cpp, around lines 116 - 120, you are leaving some code commented out. If that code is supposed to be removed for good, then please erase those lines instead. However, if instead you think that those lines of code may somehow be restored later, then please add a comment explaining that.

Another little comment: in encryption.cpp, around lines 55 - 78 (the new code you added) you are using Objective-C style curly brackets (also called K & R style), like so:
if (condition) {
      statement;
}

However, throughout the codebase of Readium SDK, we have stuck to the following style instead:
if (condition)
{
     statement;
}

So, to keep consistency throughout the codebase, would you mind switching to that style? Thanks.

In the same line as the last comment above, I noticed that in credential_request.h, around lines 147 - 165 (the definition of the new methods), the following style has been used:
return_type
function_name(arg_type arg1);

However, throughout the current codebase of the Readium SDK, we have used instead the following style:
return_type function_name(arg_type arg1);

With the return type and the function name in the same line. Would you mind changing those member function definitions to that? Thanks.

Just a little typo: on RDContainer.mm, around line 115, you wrote "NSLog(@"unknown exceprion");", whereas it should be "exception". By the way, since you are going to be rewriting that, why not add some extra information, like "Unknown exception during initialization of RDContainer.mm" so that somebody looking at the logs has a better idea of where the exception happened. It also makes it easier when you are searching through a log file.

A final question. I saw that you added the line:
#include <lcp/initialization.h>

to the file RDContainer.mm. However, where is that file added in the commits? I mean, if that file is not present, then the compilation will fail with a "header not found" error.

Other than the observations I made above, the change looks good. It would be nice to see the style changes that I talked about implemented, but most importantly, we need an answer to my last observation above before we can merge this into develop.

Thanks for your thorough review of this, Nelson.  And many thanks to DRMInside for making and submitting the changes.

Thanks for the comments, Nelson. All syntax related ones could be modified with easy. We will send new pull request with updated version soon.
However, regarding  'Platform/Apple/RDServices/Main/RDContainer.mm',
The original RDContainer.mm is used only for the iOS Launcher.
And modified version is used for the LCP integrated iOS Launcher.
So I suggest that it should be detached from the Readium SDK and attached into the iOS Launcher project. Then we could manage separated versions of the RDContainer.mm for LCP integrated iOS Launcher and plain iOS Launcher, respectively, which could make the Readium SDK drm agnostic.
We will present this suggestion with new 2 pull requests with updated Readium SDK and iOS Launcher.

We update the pull request project.

All syntax related ones are updated as Nelson recommended.
RDContainer.mm/h files are detached in this project and move to Launcher-iOS-LCP branch.
Unchanged original RDContainer.mm/h files are moved into Launcher-iOS project, which has been already sent as another pull request #66.

For the integrity of 2 projects, I recommend that 2 pull requests should be disposed together.

Hello,
Thank you for your contribution!
The RDServices were initially part of SDKLauncher-iOS, but were moved to readium-sdk because in real-world usage, readers won't add the launchers to their dependencies, but only readium-sdk. Thus RDServices is useful for iOS reader using readium-sdk. So I think you should revert this particular commit.
I see you only use the lcp/initialization.h dependency to initialize LCP during the opening of the container. If your LCP implementation uses ContentFilter, it might make sense to initialize your LCP lib from the new delegate method [RDContainerDelegate containerRegisterContentFilters:], in the launcher.
https://github.com/readium/readium-sdk/blob/develop/Platform/Apple/RDServices/Main/RDContainer.h
@nleme: Is there any documentation for the coding standard used in Readium?

Thank for your comment.
Actually, our LCP initialization needs to register ContentModule instead of ContentFilter.
And ContentModule takes a role for the ContentFilter registration internally, which is in LCP implementation part so it does not affect the Readium-SDK at all.
Anyway we'll revert RDContainer.mm/h as unchanged ones so that it does not contains LCP dependent code.
And I'll see the mechanism of the delegate method if anyone provide any document on it.
It could be helpful for us to find new place to add lcp::initialization for new ContentModule registration.

@drminside As you are undoubtedly aware of, this is the pull request we are talking about
https://github.com/readium/readium-sdk/pull/204
I am not sure if this will be suitable for your purposes but I thought it was worth a discussion as the Launcher may not be the best place for critical registration code.  @nleme is going to review this but we would be happy to schedule a call to discuss this.  Overall, it is fine to edit the Launcher in any way you wish and we'll gladly mege the pull request.  I just wanted to make you aware of #204 to see if it might be a better solution.

@mmenu-mantano and @bluefirepatrick
According to your suggestions,
We updated the RDContainer.mm/h, where following codes are added.

(void)containerRegisterContentModules:(RDContainer *)container
https://github.com/drminside/readium-sdk-1/blob/feature/sdkForLcp/Platform/Apple/RDServices/Main/RDContainer.h

[RDContainerDelegate containerRegisterContentModules:]
https://github.com/drminside/readium-sdk-1/blob/feature/sdkForLcp/Platform/Apple/RDServices/Main/RDContainer.mm

The reason why we didn't use [RDContainerDelegate containerRegisterContentModules] is that we do care only ContentModule registration instead of Filter.
Each ContentModule class has a RegistrationFilters member function in it.

Hello, and thank you for the contribution.
Where is the OpenContainerForContentModule() function implemented?
Also, could you please target the develop branch instead of master?
Regards, Daniel

@danielweck
OpenContainerForContentModule() is in the container.cpp which is untouched in the Readium SDK.
And we send a pull request again to the  develop, which is #216

Superseded: https://github.com/readium/readium-sdk/pull/216


Filebrowser

In Pycharm when you add the JupyterHub Server you can also see all the files,

But in VSC you only can use the kernel. It would be better if we had something like an filebrowser, to actually open the .py files and start coding on them, so that we can run them by the Jupyter kernel, as in Pycharm.

Duplicate of https://github.com/microsoft/vscode-jupyter/issues/1366
@snami100 Please could you upvote the above issue.


Internal links broken

Due to nasty upstream bug https://github.com/executablebooks/MyST-Parser/issues/564
Read Existing Documentation
I have checked the following places for the error:

[ ] OpenMS Documentation Troubleshooting
[ ] OpenMS API Developer FAQs

Create OpenMS Bug Report
I have created the bug report in OpenMS for any pipeline errors.

[ ] OpenMS Open Issues

Description of the documentation bug

[ ] I have attached screenshots of the incorrect documentation

Expected behaviour

OpenMS Installation

Version:

Additional context

Do we need to manually insert html  tags into the markdown files?

I have no idea. It should work out of the box.
Someone should fix #94 before we continue here. Otherwise we cannot complain upstream.


Update centralized-deployment-of-add-ins.md

Added a line stating that the module works only with Basic auth. As there is ambiguity on whether this works with Modern auth with MFA disabled.

@kwekuako Please merge this PR. Thanks

@kwekuako Gentle reminder

@efrene  Please help as it is from addins area.


Property icons not rendered

I am using v0.8.0 of the theme and the property icons aren't rendering for me. My custom.css is empty so there shouldn't be anything interfering with the theming. Do I need to have tabler fonts installed locally for the icons to be rendered?

Well, this is interesting. No, you don't need to install any additional plugins / fonts. It should work.
Could you try to disable some plugins? It is just an assumption, but one of them could be the reason.

I disabled all the plugins and uninstalled and reinstalled the theme as well but the issue persists

The above snippets did not work for me, but I figured out what the issue was with my setup.
I had disabled "property pages" in my config.edn, I reverted it with :property-pages/enabled? true and now the property icons are rendered.
Seems like Logseq requires property pages for the icons to be set. Thanks a lot!

Yes! I've forgot about it)
🔥


"go generate ./clair" from readme fails

clair/report.go:17: running "go-bindata": exec: "go-bindata": executable file not found in $PATH
Guessing installing https://github.com/jteeuwen/go-bindata will fix this, but not mentioned in instructions.

Once I installed go-bindata, and re-ran the generate command, this resulted in changes to clair/templates.go. That should possibly be removed from git entirely?


add args unit tests for pmem-ns-init, other minor unit testing improvements

Instead of setting sane values if out-of-bounds values found,
return error and fail the program with error msg.
Work in progress, dont merge yet.
Unit testing of argument values can be added here in same PR.
Resolves #223

I cherry-picked 2 commits from #201 to here so that we can continue in one PR and close #201.
Here we now have added unit tests for pmem-ns-init, and change in Makefile to cover cmd/* in unit testing.

Removed coverage commit and force-pushed


Fix JSON Read/Write for Zoom

A small fix for reading and writing the zoom boolean to a JSON config.
It was previously writing the noScopeOverlay boolean to config instead.

Thanks!


[Map] cs_machinima_memory

This is a machinima/cinematic map and could use an "Entries and Intros" section, same as this one.

URL: https://unrealarchive.org/maps/unreal-tournament-2004/unknown/C/cs_machinima_memory_be77c59b.html
Hash: be77c59b50c4c3792539f0ffde4eb11a088854b0
Current name: cs_machinima_memory

Fixed


Feature Request: Option to map Instant to number instead of string

The old openapi plugin allowed to map java Instant to number if the mapper was configured accordingly.

You should be able to enforce other type with @OpenApiPropertyType(definedBy = Type.class) annotation, e.g.
@OpenApiPropertyType(definedBy = Long.class)
public Instant getTime() {}

Or do you think we should just convert all Instant types to number by default?

For me, I'm using jackson with SerializationFeature.WRITE_DATES_AS_TIMESTAMPS true and SerializationFeature.WRITE_DATE_TIMESTAMPS_AS_NANOSECONDS false. This means that in practice, my Instant properties will serialize to something like<PHONE_NUMBER>767. But in my api docs, I'm seeing string <date-time> (with example 2019-08-24T14:15:22Z) as the type for my Instant properties.
As i understand your response here @dzikoysk it can be solved by using the definedBy = Long::class option on every property that uses Instant right now? Sounds a bit clunky and error-prone for me. Is there no option to convert Instant to Long or Double by default? Or even better - read the option from jackson (as topic creator suggests).

Reading these options from Jackson would be a clunky solution as well, because:

Documentation is a bit different topic than serialization rules
Having Jackson oriented implementation would be simply wrong for other serialization libraries
It'd give a false sense of Jackson support - it's really complex library with hundreds of configuration variants and it'd be basically a source of issues for us. To be fair, that was even the case for old OpenApi plugin that were bundled with Javalin

If you want to provide some customized behavior, you can use a little bit of a dark magic and write a Groovy script that changes all instants to longs. By default, Instant is mapped this way:
"java.time.Instant" to SimpleType("string", "date-time"),

So you can create the openapi.groovy file, like that:

https://github.com/javalin/javalin-openapi/blob/main/examples/javalin-gradle-kotlin/src/main/compile/openapi.groovy

And do something like that:
import io.javalin.openapi.experimental.ExperimentalCompileOpenApiConfiguration
import io.javalin.openapi.experimental.OpenApiAnnotationProcessorConfiguration
import io.javalin.openapi.experimental.OpenApiAnnotationProcessorConfigurer
import io.javalin.openapi.experimental.SimpleType

@ExperimentalCompileOpenApiConfiguration
class OpenApiConfiguration implements OpenApiAnnotationProcessorConfigurer {

    @Override
    void configure(OpenApiAnnotationProcessorConfiguration configuration) {
        configuration.simpleTypeMappings['java.time.Instant'] = new SimpleType("integer", "int64")
    }

}

On Gradle it seems to work quite well, especially that Groovy is already loaded by JVM. Not sure about Maven :/


IOS Problem - Merchant is not Eligable

Hi,
Sandbox works fine on IOS. But when switching to LIVE account, the following error is thrown when trying to open the payment menu.
One Time Payment Failed. Error: Server Response Error: This payment cannot be processed as the merchant is not eligible to accept automatic payments
I have created and got a separate domain for IOS package approved.
for Android, it works fine.
What could be the issue?

Dear Merchant,
This error is related to the PayHere Plan you have subscribed in your PayHere Live Merchant Account. At the time of writing, PayHere Live accounts can subscribe to one of the following three packages.

Lite (Default package)
PLUS
PREMIUM

Each of these packages have different benefits (reference). Amongst them, the ability to process Automatic Payments through Pre-approval Requests is only granted to PREMIUM plan subscribers.
Pre-approval Requests are part of PayHere Automated Charging. Therefore, you must subscribe to the PREMIUM plan if you are planning to use this feature in production.
Apologies for the late response, we hope you were able to solve it in due time. The issue will be closed soon if there is no response.


Intermittent data shortens predict_insample() date range

What happened + What you expected to happen
It seems that intermittent data causes issues with predict_insample(). If any intervals are missing all data, then the problem becomes clear: the range of dates returned will be shortened based on how densely populated the date range is.
A cursory reading of https://nixtla.github.io/neuralforecast/examples/intermittentdata.html suggests that this scenario should work though various pages like https://nixtla.github.io/neuralforecast/examples/getting_started_complete.html#evaluate-the-models-performance say otherwise. It may be helpful for the former page to have a note that the data must still be contiguous overall even if some of it is sparse.
The rest applies only if this is something to address in neuralforecast.
I believe the problems start with how self.last_dates is set:
            self.dataset, self.uids, self.last_dates, self.ds = self._prepare_fit(
                df=df, static_df=static_df, sort_df=sort_df

There is no corresponding self.first_dates, which could possibly be used to interpolate dates on the expected frequency (self.freq). When predict_insample() is called, it calls _insample_dates() with a len_series value that is then used with _cv_dates() to produce a date range via pd.date_range() using the end date, with a number of periods based on the size of the data set rather than on its actual range.
The _prepare_fit() also has a comment:
# TODO: uids, last_dates and ds should be properties of the dataset class. See github issue.

From the Git blame perhaps it's talking about https://github.com/Nixtla/neuralforecast/pull/348 / https://github.com/Nixtla/neuralforecast/pull/354 ?
One workaround is to convert from using dates in the ds column to using ints. I've included code to demonstrate the issue, with code blocks marked off that both trigger the issue and also work around it.
Versions / Dependencies
1.6.1
Reproduction script
# Code from https://nixtla.github.io/neuralforecast/examples/predictinsample.html

import pandas as pd

def reduce_long_dataframe(df, numerator, denominator):
    unique_ds_values = df['ds'].unique()
    remove_ds_values = []

    # Iterate through unique_ds_values, selecting every 'numerator' ds values out of 'denominator' to remove
    for i in range(0, len(unique_ds_values), denominator):
        remove_ds_values += list(unique_ds_values[i:i+numerator])

    # Keep only rows that don't have ds values in remove_ds_values
    reduced_df = df[~df['ds'].isin(remove_ds_values)]

    reduced_df = reduced_df.reset_index(drop=True)
    return reduced_df

from neuralforecast.utils import AirPassengersDF
Y_df = AirPassengersDF # Defined in neuralforecast.utils

Y_df['unique_id'] = Y_df['unique_id'].astype(str)
print(Y_df.head())

# comment out to keep the full set of dates (which will work as expected)
print(f"Datestamp range of Y_df before reduce_long_dataframe(): {Y_df['ds'].min()} to {Y_df['ds'].max()}")
Y_df = reduce_long_dataframe(Y_df, 2, 3)
print(f"Datestamp range of Y_df after reduce_long_dataframe(): {Y_df['ds'].min()} to {Y_df['ds'].max()}")

# workaround: replace Y_df['ds'] with a range of integers starting at 0
def replace_ds_with_contiguous_integers(df):
    unique_dates = sorted(df['ds'].unique())
    date_to_int_mapping = {date: idx for idx, date in enumerate(unique_dates)}
    df['ds'] = df['ds'].map(date_to_int_mapping)
    return df

# uncomment to work around intermittent handling issues with non-contiguous ds values
# Y_df = replace_ds_with_contiguous_integers(Y_df)
# print(f"ds range of Y_df after replace_ds_with_contiguous_integers(): {Y_df['ds'].min()} to {Y_df['ds'].max()}")

from neuralforecast import NeuralForecast
from neuralforecast.models import NHITS

horizon = 12

# Try different hyperparmeters to improve accuracy.
models = [NHITS(h=horizon,                      # Forecast horizon
                input_size=2 * horizon,         # Length of input sequence
                max_steps=10,                   # Number of steps to train (reduced for quick debugging)
                n_freq_downsample=[2, 1, 1],    # Downsampling factors for each stack output
                mlp_units = 3 * [[1024, 1024]]) # Number of units in each block.
          ]
nf = NeuralForecast(models=models, freq='M')
nf.fit(df=Y_df, val_size=horizon)
print(f"Datestamp range of Y_df after nf.fit(): {Y_df['ds'].min()} to {Y_df['ds'].max()}")

Y_hat_insample = nf.predict_insample(step_size=horizon)

print(Y_hat_insample.head())
print(f"Datestamp range after predict_insample: {Y_hat_insample['ds'].min()} to {Y_hat_insample['ds'].max()}")
# print top 10 rows of Y_hat_insample for which y is not NaN/null
print(Y_hat_insample[Y_hat_insample['y'].notnull()].head(10))

import matplotlib.pyplot as plt

plt.figure(figsize=(10, 5))
plt.plot(Y_hat_insample['ds'], Y_hat_insample['y'], label='True', linestyle='--', marker='o')
plt.plot(Y_hat_insample['ds'], Y_hat_insample['NHITS'], label='Forecast')
plt.axvline(Y_hat_insample['ds'].iloc[-12], color='black', linestyle='--', label='Train-Test Split')
plt.xlabel('Timestamp [t]')
plt.ylabel('Monthly Passengers')
plt.grid()
plt.legend()
plt.show(block=True)

Issue Severity
Low: It annoys or frustrates me.

Hi @tg2k! The input dataframe is expected to be balanced: it has a complete set of observations (rows) between the first and last dates for each time series for the given frequency. Even with this workaround, the model will not be accurate, as it expects a complete input with information for all the dates.
The best solution is to balance your data beforehand, completing the missing rows. You can impute the missing data with an appropriate imputation method for your task. Alternatively, you can fill them with 0s and add the column available_mask in your dataframe, which contains 1 for available rows and 0s for the rows with missing data. Models will use the available_mask column to avoid using the missing rows (filled with 0s for the input and masked completely for the training loss).

Following the second recommendation from @cchallu fixed the following exception, but I think the expection could be more clearly communicated and perhaps some kind of check and warning could be fed back to the user during training? I found it frustrating that the error was so vague and occurred well after I had fit the model.

I am getting the same bug


env.reset() crashed in basic usage example

I installed magent2 with pip install magent2 and copy the missing .py files following this issue. Now I can import magent2 envs in python successfully. But when I tried to run the basic usage example as below. It just crashed.
$ python
Python 3.9.0 (default, Nov 15 2020, 14:28:56)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from magent2.environments import battle_v4
>>> env = battle_v4.env(map_size=16, render_mode='human')
>>> env.reset()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/lhy/.conda/envs/dev/lib/python3.9/site-packages/pettingzoo/utils/wrappers/order_enforcing.py", line 101, in reset
    super().reset(seed=seed, options=options)
  File "/home/lhy/.conda/envs/dev/lib/python3.9/site-packages/pettingzoo/utils/wrappers/base.py", line 99, in reset
    self.env.reset(seed=seed, options=options)
  File "/home/lhy/.conda/envs/dev/lib/python3.9/site-packages/pettingzoo/utils/wrappers/base.py", line 99, in reset
    self.env.reset(seed=seed, options=options)
  File "/home/lhy/.conda/envs/dev/lib/python3.9/site-packages/pettingzoo/utils/conversions.py", line 284, in reset
    self._observations, self.infos = self.env.reset(seed=seed, options=options)
ValueError: too many values to unpack (expected 2)
>>>

Related lib versions are listed below
$ python -c "import magent2; print(magent2.__version__)"
0.3.2
$ python -c "import pettingzoo; print(pettingzoo.__version__)"
1.23.1

After debugging into some source code. I found that magent2/environments/magent_env.py::magent_parallel_env.reset returns a single dict value. This might not be compatible with what pettingzoo expects in the above error msg.
self._observations, self.infos = self.env.reset(seed=seed, options=options)

Try:
pip uninstall pettingzoo
pip install pettingzoo==1.22

Try: pip uninstall pettingzoo pip install pettingzoo==1.22

Thanks for your reply. Downgrading pettingzoo to 1.22.0 solves my problem.

change  dependencies = [     "numpy >=1.21.0",     "pygame>=2.1.0",     "pettingzoo>=1.22.0", ] worked


DOCS-73 - Remove mentions of branch_app_domain

This step is no longer needed because we already redirect to app.link on the backend and we will make app.link the default strong matching domain soon.
cc @E-B-Smith

Result of Integration 1
Duration: 4 minutes and 19 seconds
Result: 1 error, failing state: build-errors

Great:  Easier configuration.  Did you mean to commit to master?

Also, master is still broken for Buildasaur so don't sweat it.

@E-B-Smith I will merge to master but wanted to open a PR to get your eyes on it first in case I missed something.

@ahmednawar
do u we need to add branch_app_domain in info.plist for custom domains?

I don't think you need to. Also, we are taking out this flow entirely AFAIK. cc @echo-branch

There is no reference to branch_app_domain in the iOS code base.


 This PR intends to address the feasible part of the wishes offered in that mail thread.
Let's hope that this stream of complaints ends soon.

On a bright note, this is a sign gitgitgadget is growing and useful.

Yeah, that's the bright side. I should not forget that, shouldn't I?

 :-) Right now, I hear a tenor voice humming. It's my voice.


[Query Expressions] Possible improvements related to completions

Description:
Came across a few cases that we could improve the completions/suggestions for query expressions. Most of them are minor improvements that we could consider.

Suggest only the iterator variables as input in from clause

Avoid suggesting imports within record declaration

Could suggest field names of the Person type in select clause

Expression in join clause snippet does not produce accurate code
It seems, in join clause all the expr considered as identical. Shall we improve this?

https://user-images.githubusercontent.com/7523274/148319699-e333babb-8c75-48fd-b161-4a78cea0cf06.mov

Suggestions are not provided for regular key press but works for option+ESC (in mac).
What is the reason for this behavior?

https://user-images.githubusercontent.com/7523274/148320945-3a44e177-86d8-4cdb-9df1-4b192de2475a.mov
working.....
Affected Versions:
ballerina-swan-lake-2201.0.0-SNAPSHOT (December 23rd build)

@mohanvive,
If we consider
case 2:

We can refer types coming from other modules, hence we suggest the modules.

Case 5:

If we consider the context join Person person in personArray on i<cursor> we currently have a limitation identifying the context from the syntax tree and we haven't implemented the workaround in order to reduce the complexity. Now if you consider join Person person in personArray on <cursor>, we can identify the proper context in this scenario. That is why you can see the completion items when you press cmd + space. Once these completions appear and if you continue typing, the editor will not send the completion request to the server and instead it will filter from the list (intellisense) available at the moment. That is why we can see the completions are working while typing

Case 1
We have improved the sorting order to suggest iterable variables and functions that return iterables first.
Case 2 - is valid because, a user may define a record like this:
type Data record {|
    http:Ok status?;
    string name;
    string id;
|};

For such cases, http module import should be provided so that user can continue to write http:Ok status?; field.
Case 3
We are now suggesting the field names inside the select clause
Case 4 is now fixed
Case 5 won't fix at this time due to the associated complexity. Will reconsider if the same issue is reported in the future.
Closing this issue since all the cases have been addressed (or provided reasons to not fix at this time).


pna_control: Apply calibration

Apply cal set using pyvisa. Keep track of applied calibration as a measurement parameter.

Fixed by #124


Pass object to importPT alongside with path

I use the Primevue + Nuxt 3 + Tailwind for my project.
I am working on my custom Nuxt 3 module which is responsible for setting up the project's theme. This module has a default preset but I want to have the ability to override one of the components in this preset. I want to pass it as a parameter to my module in nuxt.config file
myModule: {
    preset
}

My preset is just the object that has for example one override for button
import button from './button'
export default {
  button
}

In my module I want to have the ability to do something like
async setup(_options, _nuxt) {
  const { preset } = _options
  const presetToUse = { ...defaultPreset, ...preset }

  await installModule('nuxt-primevue', {
     options: {
       unstyled: true,
     },
     importPT: {
       as: 'myPreset',
       from: presetToUse, // not possible right now
     }
  })
}

Is there any workaround for it?

Hi,
This is related to serializable definitions. Please see my comments;
https://github.com/primefaces/primevue-nuxt-module/issues/6#issuecomment-1772954754
Exp;
import path from 'path';

export default defineNuxtConfig({
    modules: [
        'nuxt-primevue'
    ],
    primevue: {
        unstyled: true,
        importPT: { from: path.resolve(__dirname, './presets/lara/') }      //import and apply preset
    }
})

Best Regards,


Add build action.

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   95.88%   95.88%
=======================================
  Files           8        8
  Lines         558      558
=======================================
  Hits          535      535
  Misses         23       23

Flag
Coverage Δ

#unittests
95.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4a409...6ddb542. Read the comment docs.


Time no longer reflects the time zone of the inquiring city

This used to work but I just noticed it today it wasn't working.  I don't know how long this has been broken but it must have been sometime between the beginning of March and today.  I know that this logic uses wunderground as part of the Almanac code so perhaps something changed on their site.

Once I fixed the issue with the Almanac not working this issue went away.
Fixed in v1.34


[Feature Request] Renaming Symbol

Is it possible to add renaming support?

renaming is cool but I'm not sure if veridian has a good enough understanding of a project to be able to do this safely. It would probably be better to just use some form of find and replace.

Symbol renaming is added to verible a couple months ago. https://github.com/chipsalliance/verible/pull/2081 Since veridian is also using verible under the hood I think it should be possible to copy their work.

veridian is using their CLI tools currently so I don't think it's quite that easy. Maybe you could try running the verible ls as well if you need that functionality.


fix: reorder close file dialog to match convention

Closes #2300
This requires local testing.

[ ] windows @Skaiir
[ ] mac
[ ] linux

The main difference here is between Windows and MacOS (mac putting OK last, windows putting OK first), cf. source.
On Linux this may depend on the window manager / UI toolkit, but for me it is Mac-style (primary, forward looking action (i.e. OK) last) across numerous apps I've checked.

@nikku Actually on modern mac with the nice overlays at least for this kind of menu it's windows style:

Although it doesn't matter here because Mac seems clever enough to do the ordering themselves, so I guess we should see how it looks on older mac versions?
Regarding Linux, we officially only support Ubuntu so we should align with that, right?

@Skaiir what's the current state of this PR and what is blocking it from merge?

@christian-konrad Actually I just went on holiday and haven't followed up on this yet. I just need to verify this works as expected for most OSs and then we should be good to merge this :)

I can confirm it works on ubuntu:

Unfortunately it does not with mac, my initially assumption was that mac re-ordered the buttons automatically, but that's only partially true. It only moves the cancel button to the end.

Hence we'll configure mac just like windows.

Looks good on Mac 11.15

@Skaiir What is the status on this one? Do you want to wrap this up? From what I see all checks (except for codecov) succeed. Your call whether to fix or ignore the last.

@nikku Hey, sorry I thought this one would have gotten automatically merged. I'll rebase, and if nothing's wrong merge.


download stuck on next page v20210822

Prerequisites

[V] Did you read FAQ section in readme.md?
[V] Did you test with the latest releases or commit ?
[X] Did you search for existing issues in Issues?

Description
I'm using the master branch, after implementing this fix #1011 this happened
this one https://github.com/Nandaka/PixivUtil2/commit/cc547c6f29debf6ef27ddf04d9585b028d3403d5
Steps to Reproduce

download from list
pixiv sketch no
after reaching a new page, the download stuck

Expected behavior: [What you expected to happen]
move to another page and start to download again
Actual behavior: [What actually happened]
...
#1
Processing Image Id: 817770
Already downloaded in DB: 817770
#1
Processing Image Id: 817725
Already downloaded in DB: 817725
#1
Processing Image Id: 5590
Already downloaded in DB: 5590
Last Page
Member_id: 1633 completed: last image_id: 5590   //// <- literally stops right here

Versions
20210822

As far as I've noticed, this fix https://github.com/Nandaka/PixivUtil2/commit/e92b2a49d9618e5a41cfc04f3afc8f5c9e1e0975 fixed the issue, I'll keep you posted if i found an unwanted behavior during the run


Add support for alternate display name format

I noticed the "name" attribute was not getting hydrated properly inside parse_from_api_response, so I added an additional check for the alternate "display_name".
I also added a Rakefile which makes it easier for users to run the tests:
rake test

I signed it!


Tie up request and response with unique ID

Hello @mgonto , i found that you had similiar question here. How to detect from response which request invoked it.
It has a lot of usecases when you need tie-tip request/response with unique ID. For example logging of every query, ajax-loader for corrensponding request.
You told on old issue there is way to send/receive custom headers and read them in interceptor. But i think its not correct way to adjust 3rd party backend to "detect" which request and response are tied when another 3rd library (restangular) is actually invoker of request. Restangular should be responsible to know which request is tied to which response.
What do you think about adding new property (something like requestId) to an element.
 function elemFunction(operation, what, params, obj, headers) {
          var restangularId = _.uniqueId();
------
 var okCallback = function(response) {
   _.extend(response, { restangularId : restangularID});
}

var errorCallback = function(response) {
     _.extend(response, { restangularId : restangularID});
}

This is solve number one , but if you dont want decorating "response" because response should be response from server, what about manually "injecting" this header inside "headers" object?
For this time i solved it by altering your library but i am asking for official support so i can make PR :)
Let me know what do you think about it.

Hi I am looking for a feature similar to the one you mention, could you post a link to the issue on which mgonto mentioned about the custom headers?

@Altaflux  https://github.com/mgonto/restangular/issues/517 . If you wanna more info, you just create RequestInterceptor which is extending headers with some custom paramater , for example X-Restangular-Request, and on backend side you will just "forward them". then in ResponseInterceptor you can read it. But i dont like it, Actually today i forked restangular with custom code , but waiting for @mgonto to response.

I need the same feature as you. I tried mgonto's way and it's only a workaround. BTW, do you know if it's possible to "reject" a response in responseInterceptor? Because in my use case I want to "reject" all the response from my "old requests". But for now I could only do the following things:

Find a response is from an "old" requests, it is junk and should be rejected. I won't return it.
Since in the doc it says "The responseInterceptor must return the restangularized data element", I will still get a response which is undefined in the "success function".
if (typeof response === 'undefined') { return; }

Is it possible to stop the process in the responseInterceptor? Thank you!


chinese input method can't input when select content

monaco-editor version: 0.18.1
Browser: Chrome
OS: Windows

select content and use input method will cause editor freeze
Steps or JS usage snippet reproducing the issue:

@alexdima when can we resolve this problem

As mentioned above, it's an upstream (browser specific), so fixes should go to Edge dev since it's a chromium fork.


Protocol#11

protocol class creation

Codecov Report

Merging #28 into master will increase coverage by 13.68%.
The diff coverage is 84.31%.

@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
+ Coverage   60.38%   74.07%   +13.68%
===========================================
  Files           9        9
  Lines         207      270       +63
===========================================
+ Hits          125      200       +75
+ Misses         82       70       -12

Impacted Files
Coverage Δ

pkmodel/protocol.py
75.00% <74.19%> (-25.00%)
:arrow_down:

pkmodel/tests/test_protocol.py
100.00% <100.00%> (ø)

pkmodel/tests/test_solution.py
100.00% <0.00%> (ø)

pkmodel/solution.py
68.35% <0.00%> (+25.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0541f97...e38cf91. Read the comment docs.


Feature Request: Mobile Apps for Android and iOS

I think it's actually not that hard (but it seems to be much easier for Android than to iOS):
http://doc.qt.io/qt-5/android-support.html
http://doc.qt.io/qt-5/ios-support.html

I'm closing this issue because it is too big of an effort to fit a github issue.


HADOOP-18023. Allow cp command to run with multi threads.

JIRA:  https://issues.apache.org/jira/browse/HADOOP-18023
Description of PR
Allow hadoop fs -cp command to  run with multi-thread to improve copy speed.
How was this patch tested?
It's useful to allow  -cp command to  run with multi-thread,  like the improvement we done for -put/-get commands.  It would reduce about 90% time cost when run with 10 threads in my test cases.
Source dir:  1 dir  401 files  2.3G
Test 1: run with single thread
  time hadoop fs -cp /tmp/data/test /tmp/data/t1
  real    1m9.394s
  user    0m16.688s
  sys    0m5.331s

Test 2: run with 10 threads
  time hadoop fs -cp -t 10 /tmp/data/test /tmp/data/t2
  real    0m8.217s
  user    0m19.864s
  sys    0m8.776s

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 23s

trunk passed

+1 :green_heart:
compile
26m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
22m 43s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 50s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 53s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 54s

trunk passed

+1 :green_heart:
shadedclient
24m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
26m 53s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
26m 53s

the patch passed

+1 :green_heart:
compile
24m 26s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
24m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 10s

hadoop-common-project/hadoop-common: The patch generated 0 new + 12 unchanged - 12 fixed = 12 total (was 24)

+1 :green_heart:
mvnsite
1m 50s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
27m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 58s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

228m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3721/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3721

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint xml

uname
Linux 4566d2fb600e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf84f22ad7b5887606ef3177beeb4fc16f58cbb0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3721/1/testReport/

Max. process+thread count
1266 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3721/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @sodonnel @Hexiaoqiao,  can you please take a look?  Thanks.

@sodonnel thanks for your review~


Getting an error when use the cci error gist command

Describe the bug
I am getting an error when using the cci error gist command
Reproduction steps
Steps to reproduce the behavior:

I happened to be in the sal repo
I was creating a prerelease org using the regression_org flow
Once it completed I used the "cci error gist" command
I got an error:
Error: 'charmap' codec can't decode byte 0x90 in position 106756: character maps to
(Similar to https://github.com/SFDO-Tooling/CumulusCI/issues/1619)

Context
I wanted to review a flow's output so I used the cci error gist command
CumulusCI version: 3.17.1 (C:\Users\anne.jackson.local\bin\cci)
Python version: 3.8.2 (c:\users\anne.jackson.local\pipx\venvs\cumulusci\scripts\python.exe)

Windows 10
I am using Windows Visual Studio Code Terminal

Here you go @davisagli. Thanks!


Redesign

** not ready for merging **
@carlwood - I'm starting a pull request so we can discuss changes etc.

@spikeheap / @benfoxall worth closing this now?


Taking action in env

In the AnimalAI environment, when you want to take a step, the action has to be called as action.item(). This may be an issue with AnimalAI or it could be due to the way stable baselines stores the model.
while not done:
action, _states = model.predict(obs)
obs, rewards, done, info = env.step(action.item())
env.render()

For anyone having the same issue in their python scripts, a quick fix to this, per Niha, would be (depending on which Gym you use, as this is valid for OpenAI at least):
Where you specify the condition on when and if your agent should learn, simply access the env.step() method by specifying the action.item() method within it. This method accepts an action and returns a tuple ("[ObsType, float, bool, bool, dict]").

while not done:
action, _states = model.predict(obs)
obs, rewards, done, info = env.step(action.item()) #Here, change: env.step(action) to: env.step(action,item).
env.render()

According to the documentation on OpenAI's GitHub: https://github.com/openai/gym/blob/master/gym/core.py, lines 382 to 385.
It is likely that the wrapper needs further implementation when using AAI, hence calling "env.step(aaction.item)".


path-only links don't work

When the feed contains links without scheme+host+port but just a path like /some/blog/post they can't be opened by clicking on the entry in the menubar.
The error is "There is no application set to open the URL /some/blog/post."
Seems like the url is taken as is but ideally the missing stuff should be inferred from the feed url.

Example (any github releases feed), e.g. https://github.com/getsentry/sentry/releases.atom


Enhancement:  I need a way to remove the Now button

If there is a way to eliminate the Now button, I'm not seeing it

@kerryrward look this: https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/766#issuecomment-258738983 It works for me


Noetic Kick-off and Release Checklist

This ticket is for things that need to be done for the May 2020 ROS 1 Noetic release. Copied from the Melodic Release ticket and Melodic Kick-Off Checklist.
Prerequisites

[x] Python 3 support for Melodic checklist (ros/rosdistro#17898)
[x] Resolve how to do rosdep keys for python 3

some discussion here

[ ] Update and release rep-151 with python3 plan (ros-infrastructure/rep#201)

Kickoff part 1

[x] Choose distribution name: Noetic Ninjemys
[ ] Commission a logo
[ ] Commission a turtlesim icon
[ ] Add to REP3 with proposed platforms and minimum requirements, request feedback from community (ros-infrastructure/rep#202)
[x] List on ROS wiki with expected release date

http://wiki.ros.org/Distributions
see example
http://wiki.ros.org/action/info/Distributions?action=diff&rev2=102&rev1=99
Wiki page for noetic: http://wiki.ros.org/noetic

Ubuntu buildfarm setup

[x] Create<EMAIL_ADDRESS>[x] Add Ubuntu 20.04 to bootstrap repository on repos.ros.org

see example
actual: https://github.com/ros-infrastructure/reprepro-updater/pull/72

[x] Add Ubuntu 20.04  to buildfarm_deployment_config

note this is not the live one, it's for reference only
see example
actual: https://github.com/ros-infrastructure/buildfarm_deployment_config/pull/52

[x] Add Ubuntu 20.04 to ros_buildfarm/common.py

see example
actual: https://github.com/ros-infrastructure/ros_buildfarm/pull/699

Python Dependencies setup

[ ] Check that all python packages and scripts below work with python 3.7 and 3.8

[ ] catkin_pkg
[ ] rospkg
[ ] rosdistro
[ ] rosdep

Py 3.7 + 3.8 CI https://github.com/ros-infrastructure/rosdep/pull/735

[ ] vcstools
[ ] wstool
[ ] rosinstall
[ ] bloom
[ ] rosinstall_generator
[ ] osrf_pycommon
[ ] catkin_tools
[ ] vcstool
[ ] ros_release_python

[ ] Add newly supported platforms to list of platforms for each Python package (in stdeb.cfg), in order of dependency

do this as soon as debs for new Ubuntu are available, in pre-alpha!

[x] catkin_pkg

Example (Melodic: ros-infrastructure/catkin_pkg#198)
Actual: ros-infrastructure/catkin_pkg#271

[x] rospkg

Example (Melodic: ros-infrastructure/rospkg#123)
Actual: ros-infrastructure/rospkg#184

[x] rosdistro

Example (Melodic: ros-infrastructure/rosdistro#108)
Actual: ros-infrastructure/rosdistro#148

[x] rosdep

Example (Melodic: ros-infrastructure/rosdep#567)
Actual: ros-infrastructure/rosdep#734

[ ] vcstools

Example (Melodic: vcstools/vcstools#127)
Actual: https://github.com/vcstools/vcstools/pull/159

[ ] wstool

Example (Melodic: vcstools/wstool#115)
Actual: vcstools/wstool#148

[ ] rosinstall

Example (Melodic: vcstools/rosinstall#113)
Actual: vcstools/rosinstall#122

[x] bloom

Example (Melodic: ros-infrastructure/bloom#452)
Actual: ros-infrastructure/bloom#558

[x] rosinstall_generator

Example (Melodic: ros-infrastructure/rosinstall_generator#42)
Actual: ros-infrastructure/rosinstall_generator#62

[x] osrf_pycommon

Example (Melodic: osrf/osrf_pycommon#45)
Actual: osrf/osrf_pycommon#58

[x] catkin_tools

Example (Melodic: catkin/catkin_tools#497)
Actual: catkin/catkin_tools#589, catkin/catkin_tools#564

[x] vcstool

Example(Melodic: dirk-thomas/vcstool@dcee1a0)
Actual: dirk-thomas/vcstool#112

[x] Use ros_release_python

Goal is to make the currently released versions available in the new distros using the --include option

[x] create Docker images for the new platforms in rep 3 for all targets

See example
actual: https://github.com/osrf/multiarch-docker-image-generation/pull/32

[x] Create distribution files in ros/rosdistro

Example
Actual: https://github.com/ros/rosdistro/pull/21988

[x] create new mailing list for buildfarm emails

Example
Use same settings as the existing ones (need to get admin on an older group to see settings)
Actual: https://groups.google.com/forum/#!forum/ros-buildfarm-noetic

[x] Add ros_buildfarm_config entries

Example
Actual: https://github.com/ros-infrastructure/ros_buildfarm_config/pull/157

[x] Generate new management jobs
[x] generate new sync-packages-to-{testing,main} jobs

Run this script

Prerelease Website

[x] Release the catkin

Needed for prerelease website testing
Example
Actual: https://github.com/ros/rosdistro/pull/23421

[ ] Add new column in for the new distro with theme and placeholder image

Example

[ ] Add new LTS distros as preferred

Example

[ ] Make Ubuntu 20.04 the preferred OS

Example

[ ] Test prerelease process (except for latest ubuntu distros)

Pre-release documentation

[ ] Add Noetic button to the wiki
[ ] Add standard distribution wiki pages (planning, migration, etc...)

[x] http://wiki.ros.org/noetic/
~~http://wiki.ros.org/melodic/Planning~~ Appears unused in melodic, did not create Noetic equivalent
[x] http://wiki.ros.org/noetic/Migration
[ ] http://wiki.ros.org/melodic/Planning/Maintenance

[ ] link to the blocked releases status page rather than using a static page
[ ] update previous distributions Maintenance pages accordingly

[ ] http://wiki.ros.org/melodic/Installation

[ ] Create main page http://wiki.ros.org/melodic/Installation
[ ] Create Platforms
[ ] Create DebianSources
[ ] Create DebEnvironment
[ ] Create PostInstall

All of the below should have a warning about distribution pending like this

[ ] Create Ubuntu
[ ] Create Debian
[ ] Create Source

Low level releases

[ ] Release ros-core packages

[x] ros_environment
[x] rosbag_migration_rule
[x] roscpp_core
[x] genmsg
[x] gencpp
[x] geneus
[x] genlisp
[x] gennodejs
[x] genpy
[x] message_generation
[x] message_runtime
[x] ros_comm_msgs
[x] std_msgs
[x] cmake_modules
[x] rospack
[x] ros
[x] ros_comm
[x] rosconsole_bridge
[x] common_msgs
[x] ros_tutorials

[ ] re-release as soon as the turtle is available

[x] roslisp

[x] Release ros-base packages

[x] actionlib
[x] angles
[x] bond_core
[x] dynamic_reconfigure
[x] class_loader
[x] pluginlib
[x] nodelet_core

[ ] common_tutorials

Early Buildfarm

[x] Create Migration page

http://wiki.ros.org/noetic/Migration

[ ] Announce availability of the build farm

Example

[ ] Ping all maintainers of packages in desktop-full

Month before release

[ ] Announce logo design and kick off t-shirt campaign*

Day prior and day of Release
ROS Wiki

[ ] make this the default distro

example

[ ] Update Version macro from “Expected in distroX” to “distroX”
[ ] Manually redeploy wiki once finished by pulling repo and restarting Apache instance

roswiki checkout lives in /var/www/wiki.ros.org/data/plugin
restart apache with script in /home/ros/reload_httpd

[ ] Update symlink for default API doc:

[ ] /home/rosbot/docs/api → /home/rosbot/docs/distroX/api
[ ] /home/rosbot/docs/latest → /home/rosbot/docs/distroX
[ ] (if this is an LTS) /home/rosbot/docs/latest-lts -> /home/rosbot/docs/distroX

[ ] Update http://wiki.ros.org/ROS/Installation to point to distroX
[ ] Update verbiage on these wiki pages, e.g. 'upcoming release' vs. 'current release'

[ ] http://wiki.ros.org/melodic/Installation
[ ] http://wiki.ros.org/melodic
[ ] http://wiki.ros.org/Distributions

ROS browse

[ ] update default distro

Example

ROS docker images

[ ] add Dockerfiles to create ROS docker images

Misc Infra

[ ] Update www.ros.org bottom row widget to point to new release with logo
[ ] Update www.ros.org/install to point to new release with logo
[ ] Create Release category on Discourse

Example

[ ] Update mirror documentation

Example

[ ] update ros mirrors

Example

[ ] update osrfoundation mirrors

Must wait until there are builds for ignition and gazebo for all supported platforms

[ ] Add Noetic to high level page http://wiki.ros.org/Installation/Ubuntu

Communication

[ ] Announcement pointing to migration guide

[ ] Post to discourse
Post to blog
Post to G+
Post to Twitter

* Goal is to make the currently released versions available in the new distros using the `--include` option

The --include option wasn't updated to support the new aptly-based bootstrap repository. I've opened https://github.com/ros-infrastructure/ros_release_python/issues/31 to track support for it and am hoping to tackle it well before it's needed.

It looks like python-catkin-pkg in Focal is missing from the python file, which blocks geographic_info. I can force release it but I feel like that should probably be fixed beforehand.
Thoughts?

It looks like python-catkin-pkg in Focal is missing from the python file, which blocks geographic_info. I can force release it but I feel like that should probably be fixed beforehand.

@SteveMacenski In ROS Noetic geographic_info should depend on the Python 3 equivalent python3-catkin-pkg instead. Further, if doesn't need the CLI tools then it should depend on python-catkin-pkg-modules in Melodic and earlier, and python3-catkin-pkg-modules in Noetic.

Ah ok. I'm not a python user in general so I'll probably need someone to sanity check it for me that everything's been properly updated. I did a glance over it and the obvious things I'm aware of from 2.7-3.4 look to be done already.
If that's the case, I can update that stuff and ship it out

@sloretz Should we close this out now that Noetic has been released?

I'm going to go ahead and close this now that Noetic is released.  Feel free to reopen if needed, or open up follow-up tasks.


Using addresses association to store company address.

Notion:
https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=185bd45b9dc24dfcad9c57c07d32a7c0&p=5578743881b44e108a04efb88153c00e&pm=s
Description:
After developing the updated designs of the organization settings page, backend changes are required for address fields on the organization settings page.

The address field is a text field that needs to be updated to different fields for Address line 1, Address line 2, Country, State, City & Zipcode.

We used Address association to save the company's address.

Added a migration that will copy address field data to the Address model.

Updated create company API.

API Endpoint:
http://localhost:3000/internal_api/v1/companies
Input Params:
{     "company": {         "name": "Saeloun",         "business_phone": "+918390108472",         "country": "US",         "base_currency": "USD",         "standard_price": "200.00",         "fiscal_year_end": "Dec",         "date_format": "MM-DD-YYYY",         "timezone": "(GMT-05:00) Eastern Time (US & Canada)",         "addresses_attributes":[ {             "address_line_1": "Saeloun Inc",             "address_line_2": "475 Clermont Ave",             "state": "NY",             "city": "Brooklyn",             "country": "US",             "pin": "12238"         }]     } }

@prasanthchaduvula Please review this on Priority. If any changes are required make them yourself and merge this PR as soon as possible.

@deepti-kakade
under organization settings, we need an addresses array but currently, I am getting an object. Also, we might need to add another field address type (for current and permanent addresses) because I am not getting that under the API response.

@prasanthchaduvula can you please review the UI changes?
@sanjibroy360 can you please have a look and tell me the changes are not affecting your work?

@onkar-saeloun Frontend changes LGTM

@deepti-kakade Please add system specs

Added it, please check.

@apoorv1316 Please review system specs

@apoorv1316 Done with PR comments, please check.

@onkar-saeloun We are not getting the cities list here. We have to manually enter a city name here to proceed.

@onkar-saeloun @deepti-kakade Please see the loom video and make the required fixes https://www.loom.com/share/aa42049ad91041308049f46bcf5416e7

@onkar-saeloun @deepti-kakade Please see the loom video and make the required fixes https://www.loom.com/share/aa42049ad91041308049f46bcf5416e7

Looking into it

@onkar-saeloun @deepti-kakade Please see the loom video and make the required fixes https://www.loom.com/share/aa42049ad91041308049f46bcf5416e7

Looking into it

@apoorv1316 the changes are implemented, just the mobile responsive issue you are facing because of the brawser can you please refresh the brawser after changing dimentions on the chrome? I am not facing the same issue in my machine.

@onkar-saeloun Are we supporting only US cities? I changed the country and state but the city list is not getting updated

@onkar-saeloun I tried refreshing the page after switching to mobile view. But its showing blank page for me

@onkar-saeloun Are we supporting only US cities? I changed the country and state but the city list is not getting updated

@apoorv1316 it was caching issue added fix for it

@onkar-saeloun I tried refreshing the page after switching to mobile view. But its showing blank page for me

@apoorv1316  can we connect regarding this? I am not been able to produce this issue in my machine.


Can add a layer twice to the QGIS model

Open QGIS and ensure that the Ribasim plugin is installed and enabled.
Open the application via the Ribasim button on the QGIS toolbar: Ribasim panel opens.
Press the "New" button in the Model tab: file navigation window pops up.
Fill in a name ("test1").
Press OK: A toml and database file are created on the given location.
Press the "Edge" layer in the Model tab
Press "Add to QGIS": A second Edge layer is added to the model.

Expected: the "Add to QGIS" button is disabled, because Edge is already in the model.

It would perhaps be easier if we don't have this whole synchronization panel in the Model tab. The Layers panel should already tell enough should be the ultimate truth. "Add to QGIS" and "Remove from Dataset" should be removed and the Layers panel should be the geo package itself, no clone.

It would perhaps be easier if we don't have this whole synchronization panel in the Model tab.

I agree, and the synchronization has caused me a fair bit of pain in the past.

The Layers panel should already tell enough should be the ultimate truth.

This is not the case, and it can't be; the layers panel is not a clone. The plugin is more like a clone of the Browser Panel:

Presence in the layers panel makes QGIS aware of the layer. You can add or remove features, change the styling, etc., but you cannot delete for example. Deleting Layers requires access through the browser panel.
Deleting a layer in the Layers panel simply makes QGIS unaware of the layer's existence.
If you accidentally remove a layer from the Layers panel, it's still in the geopackage and it's still in the model; the data is not deleted. You can only get the layer back by going through the Browser panel and re-adding it to the Layers panel. Alternatively, you just re-open the TOML file and let the plugin do the work.
I think it's worth considering to get rid of the "Add to QGIS" button, and introduce a different button called "Restore (from project)" -- I'll open an issue about that.
But the "Remove from Dataset" button should not be removed, because it's very tedious to delete geopackage layers using the Browser panel.


Azure automated deployment for OPEA applications - Infosys

Description
Infosys contribution to OPEA.
Azure AKS terraforms and steps to execute to deploy OPEA applications.
Issues
NA
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
None.
Tests
Tested terraforms on Azure platform.

Hello @poussa ,
Review comments are fixed. Could you please approve and merge the code?

Hello @poussa , Review comments are fixed. Could you please approve and merge the code?

I have already approved. We need a 2nd approver. I'll work on that now.

@kkrishTa can you also fix the DCO. That is, add signed-off-by line to the commit (-s).

@kkrishTa can you also fix the DCO. That is, add signed-off-by line to the commit (-s).

@poussa Sure. Fixed this one.

Hello @poussa / @lianhao ,
The pipeline got failed with an error:
/home/runner/work/GenAIInfra/GenAIInfra/docs/_build/rst/GenAIInfra/cloud-service-provider/azure/aks/terraform/README.md: WARNING: document isn't included in any toctree
But I see that ".md files not in toc tree" is ignored as per https://github.com/opea-project/docs/blob/main/.known-issues/sphinx.conf. Though this is a warning, the pipeline step has failed.
Could you please advise fix on this?

Could you please advise fix on this?
@poussa will create another PR to add the doc link to those exiting md files under cloud-service-provider directory, then you can add the link follow his convention.

It's a newly added doc CI check complaining.

@kkrishTa once this PR#633 is merged, you can update yours to add link to Azure/AKS readme. Then the ci/cd is happy and we can merge.

@kkrishTa can you resolve the conflict, please?

The readme filename is README.md not README.MD as it is in the link now. That's why ci/cd is still failing.
One more fix and we are there...

The doc team is investigating why the Check Online Document Building CI fails now. Let's hold on this until they figure out the solution.

Let me find someone on the docs team to help on this @kkrishTa. You have been most patient with our CICD tests.

@kkrishTa The doc teams has revolved the doc build failure. For the Check Paths and Hyperlinks / check-the-validity-of-hyperlinks-in-README issue, could you please use relative link instead, just like PR #634

@kkrishTa The doc teams has revolved the doc build failure. For the Check Paths and Hyperlinks / check-the-validity-of-hyperlinks-in-README issue, could you please use relative link instead, just like PR #634

sure @lianhao . Once this is merged, I will pull the latest and update the link apporpriately.

@kkrishTa The doc teams has revolved the doc build failure. For the Check Paths and Hyperlinks / check-the-validity-of-hyperlinks-in-README issue, could you please use relative link instead, just like PR #634

sure @lianhao . Once this is merged, I will pull the latest and update the link apporpriately.

No need to wait for PR #634, just go ahead to fix your PR by using relative links to newly added .md files

@kkrishTa The doc teams has revolved the doc build failure. For the Check Paths and Hyperlinks / check-the-validity-of-hyperlinks-in-README issue, could you please use relative link instead, just like PR #634

sure @lianhao . Once this is merged, I will pull the latest and update the link apporpriately.

No need to wait for PR #634, just go ahead to fix your PR by using relative links to newly added .md files. Let's get your PR to land-in first.

Updated readme. Since it has common read me, upadted other relative links as in #634 without breaking AWS readme link.


XYZ color picker confuses 0..1 and 0..100% range

The XYZ-d65 color picker has 0..100 scale but gives black for [0,0,0] and an oog color close to white for [1,1,1]; it is not possible to pick any other colors due to the slider granularity.

Confirming that the issue still exists, because [0..1] and [0..100] are being confused

What should the range be for each XYZ space?

As I said earlier:

Giving the relative XYZs a reference range of [0, 1] would also work.

@DmitrySharabin could we integrate the <color-picker> component to use here so we don't maintain similar code in two places?

@DmitrySharabin could we integrate the <color-picker> component to use here so we don't maintain similar code in two places?

@LeaVerou, I integrated the <color-picker> component (preview and corresponding PR). Please take a look.

Thanks @DmitrySharabin! Is this issue present in <color-picker> too? If not, we should close.

Is this issue present in <color-picker> too?

Unfortunately, it does. As @svgeesus mentioned, since xyzd65 and xyzd50 don't declare a range, they end up with [0, 100] (here and here). In <color-picker>, we don't fall back to [0, 100] (when calculating the default color) expecting that all the color spaces declare ranges for their coords (that make <color-picker> throw for the mentioned color spaces).
So, to solve this issue, we should probably declare ranges for those spaces. As Chris said:

Giving the relative XYZs a reference range of [0, 1] would also work.

Yeah, let's do that.

Yeah, let's do that.

Done.

Fixed in a3e89582cfe9873e790a21b2f593b8bc4a7abcb5


NVIDIA-CUDA-DRIVER-TENSORFLOW abort on U16.04 + proposed-azure and proposed-edge

Test case abort when run tensorflow against ubuntu 16.04 + proposed-azure/proposed-edge kernel.
When run python tf_cnn_benchmarks.py with batch_size 512 hit memory issue.

It needs to isolate/characterize the problem in details, but if this is simply occurring with new kernel, I believe Canonical should be interested. Please add Joe if it is the case.


Exception fix

It would be better to throw an Exception if no annotation for httpMethod is specified

It does not matter in this case because this is checked even before we collect info for exception.

well if its checked before you should erase the return null in Utils.java and the null check in RequestFactoryParser.java, it can be redundant.


Use new Dockerfile template, with images from hex.pm

This template is based on the Dockerfile that nowadays is generated with mix phx.gen.release, and make use of tagged images with well known versions, rather a rolling tag.
Elixir and OTP version are explicitly set, and should be manually updated.
Signed-off-by: Davide Bettio<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build f7f78c840a38c0eff658d024b547cdb5c411df85-PR-223

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.548%

Totals

Change from base Build 224147cfb4f7b60a4c8d88058eeb4ebdee05d25d:
0.0%

Covered Lines:
853

Relevant Lines:
1059

💛  - Coveralls


Subscribe to your own content

Right now the users have to subscribe to a creator's address to view its content.
This is true even if the user wants to view his/her own content. Subscribing to itself just results in paying yourself and the user does not lose any tokens.
Still, this is an overhead and should be resolved.
This might be moderately challenging, and if anyone wants to work on it, comment and let me know.
Link to smart contracts

This issue is solved in the smart contracts, only now same needs to be reflected in the frontend as well.


Slow rendering with row selection

If a table has > say 100 rows, there is a significant lag when selecting a row or "select all". I experienced the same with material-table when I was implementing controlled selection, but it seems to be unrelated to what I was doing, and I found a recent issue on it:
https://github.com/mbrn/material-table/issues/1085
So I tried mui-datatables, and see the same thing, reproduced here with latest version:
https://codesandbox.io/s/mui-datatables-example-yv961
Any suggestions? Thanks.

I didn't have a chance to look into this. Were you able to determine the issue?

@raythree Did you find a solution? I am now coming across this issue as well.

Similar problem here with expanding rows and just 20 rows.
There is a delay bettween clicking and start drawing something.
Chrome is firing this warnings:
"[Violation] 'click' handler took 437ms"

This number of events on clicking is normal?

Same here, render perfomance is lacking any time I trigger an action in a row (for ex. an edit action).

I also encounter this problem too

I also have this problem. The selection gets massively slower when i set a hook variable in the onRowSelectionChange handler. I use table options={{           selectableRows: 'single',           selectableRowsHideCheckboxes: true,           selectableRowsOnClick: true,           onRowSelectionChange: onSelectionChange,         }}
Has anyone come up with a workaround yet?

I have found that it only has this delay while debugging. All fine in production.

I am facing the same problem. I have over 500 rows and whenever I perform any action (selecting a row, multiple rows, or all rows), there is a lag and delay in the response. I am using the latest chrome on the m1 machine.  The version I am using 3.7.8.

same experience. any updates on this?


Add something on MC barostats

#32 added barostat info but we still need something on MC barostats.

I can take MC barostats. It just boils down to throwing an MC volume change move into an MD simulation every once in awhile, right? I can write this up now unless you want it @davidlmobley .

Resolved by #48


Refresh in some nodes doesn't give any indiction that it did anything

This came from https://github.com/Microsoft/vscode-azurestorage/issues/144, where the tester apparently thought it wasn't working at all because nothing seemed to happen.  Ideally the node would give a working indication or some other indicator at least for a short time.

Pretty sure this has already been fixed, otherwise closing because it's been so long with no activity


Error try to search dependencies and validating

Type: Bug
I'm having a lot of issues while trying to add dependencies and validating the pom file. This happened after I updated VSCode this afternoon.
2023-09-15 01:27:09.246 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[c]', provide the URI of a resource or 'null' for any resource.
2023-09-15 01:27:09.247 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[java]', provide the URI of a resource or 'null' for any resource.
2023-09-15 01:27:09.247 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[xml]', provide the URI of a resource or 'null' for any resource.
2023-09-15 01:27:09.247 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[xsl]', provide the URI of a resource or 'null' for any resource.
2023-09-15 01:27:09.247 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[dtd]', provide the URI of a resource or 'null' for any resource.
2023-09-15 01:27:09.247 [warning] [redhat.fabric8-analytics] Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '[svg]', provide the URI of a resource or 'null' for any resource.
 I've deleted Cached data in %USERPROFILE%\AppData\Roaming\Code. --> primarily deleted data in Workspaces folder.
Restarted, and VSC worked fine once again.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4276

Questions ?
Please refer to the Backport tool documentation


Fix capitalization of module

npm installs the module in lowercase form, so referring to it in any other capitalization breaks on case-sensitive file systems.

Thanks @lucaswerkmeister!


:construction_worker:  add custom workspace dep checker

Description
Closes #725
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[ ] New and existing unit tests pass locally with my changes.

Coverage remained the same at 90.695% when pulling e24b85df920017aeb79db12d045beccfb2b522eb on chore/dep-check into 49525d1961bdec127c375b104b2bd8f57fb9098a on main.


fix(docs): fix usr/lib/systemd path for ubuntu users

I'm not sure which Linux flavor the installation guide was based on, but the path is not present on Ubuntu (22.04).
Found some more details here - https://askubuntu.com/questions/1058076/system-folder-does-not-exist-in-usr-lib-systemd
Signed-off-by: Anthony Nandaa<EMAIL_ADDRESS>

Please consider squashing commits

Thanks for the contribution; as @AkihiroSuda mentioned, please squash commits since there is now only one documentation edit.

@estesp -- sure, I will. Still investigating something, once the PR is ready, I'll squash.

@AkihiroSuda @estesp -- pls take a look. Also while at it, decided to add a curl step for getting the containerd.service file to better the experience for those who could be copy-pasting commands.


Dependency tree is misleading about the total number of crates

The following looks like an enormous dependency graph, but in reality it's just repeating the same few dependencies many times (winapi, serde, syn, quote, proc-macro2, ...). For example I count 9 different copies of proc-macro2 1.0 in this graph. In reality Cargo would only build that dependency a single time, and it would be nice if the view would capture that.
In particular it looks like this view is associating dependency specs (^0.1 vs ^0.1.3 etc) with nodes, whereas it would make more sense to me to associate them with edges. Multiple crates can depend on the same dependency with different specifications, and there should only be one node for the dependency for every semver-compatible group of those specifications.

I implemented a new look of dependency chart in a form of a directed graph. It will be very messy if the crate has a large dependency. I tried my best to visualize the dependency distance by the scale of color.


Add Gridless mode

If the canvas doesn't use a square grid then the module fails. It should hopefully be fairly simple to fix.

Hype for this!

https://github.com/Garsondee/RTSControls/releases/tag/1.2.0


[DRAFT] An initial take on an fts::test that hits indexes

Implement an inlined version of fts::test that succefully hits
indexes. (I tested using imdbench extended with some fts::textsearch
indexes.)
Per some discussions with @vpetrovykh, I introduced an fts::make_doc
function that is a variadic optional function that produces a string
that can be reasonable passed to an fts::textsearch index and that
works well will fts::test. (fts::test does the same operations.)
make_doc essentially does array_to_string("docs", ' '), but inlined.
The most unpleasant bit about all of this, though, in handling the
language argument to postgres's to_tsvector, and how it interacts
with our constant extraction preprocessing. Because we extract string
literals during preprocessing, the language argument to fts::test
and similar will typically be a parameter.
The language argument is of type regconfig (which is an int id);
there is a cast from text to regconfig, but if the argument to
language is a text query parameter cast to regconfig, the index will
not match and the query will be slow.
The index will match if the argument is of type regconfig (which
is to say, an int32), but that doesn't help us any.
What does work is if it the argument is a string literal that is
cast directly to regconfig.
The only way I could come up with of accomplishing this is that the
normalization pass no longer extracts string literals that appear
directly after the token sequence language :=.
If anybody has a better idea I'd love to know it.

If anybody has a better idea I'd love to know it.

Perhaps you can do this at the IR level?  I.e. specially handle the language argument and put a hint in the argument cast for the real desired type (i.e. regconfig).

I'm closing this because it is bad, I have a second try coming soon


Add test cases for NDA renewal feature

Coverage remained the same at 92.78% when pulling b537a138828d907927e0de8fb34f5e951efd8003 on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling edd443a7fe8b3815408eebb53fbaa101ab684a3d on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling 14f49d5d9d6a852e2317baeaf2cdfd43dd2df62a on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling 14f49d5d9d6a852e2317baeaf2cdfd43dd2df62a on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling 14f49d5d9d6a852e2317baeaf2cdfd43dd2df62a on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling 14f49d5d9d6a852e2317baeaf2cdfd43dd2df62a on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

@johngian , can you please review this?

Coverage remained the same at 92.78% when pulling b35b2a6b666c8d1adaa1aa63119f1c4daa95bb6d on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling b35b2a6b666c8d1adaa1aa63119f1c4daa95bb6d on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling b35b2a6b666c8d1adaa1aa63119f1c4daa95bb6d on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling dc66b52d2cada5e3500ca0ceceb5156b3eb65b8e on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling dc66b52d2cada5e3500ca0ceceb5156b3eb65b8e on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling dc66b52d2cada5e3500ca0ceceb5156b3eb65b8e on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling dc66b52d2cada5e3500ca0ceceb5156b3eb65b8e on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling 0c772475ae0e0a71a3a0886cc231cbf2f1a7a8a4 on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling cfe6f3ddafb20f9c8bd7a835d6309c3734cead49 on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling cfe6f3ddafb20f9c8bd7a835d6309c3734cead49 on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.

Coverage remained the same at 92.78% when pulling cfe6f3ddafb20f9c8bd7a835d6309c3734cead49 on viorelaioia:add_test_cases_for_nda_renewal into<PHONE_NUMBER>161940d0d37b2796782519a8837cb4 on mozilla:master.


longest_match questions

I have been looking at the longest_match function.

It doesn't appear that the UNALIGNED_OK is necessary. std2_longest_match and std3_longest_match don't do any unaligned access.
Why is longest_match broken into 3 separate functions? It seems like it could be a single function, with #ifdef inside for the separate comparison lengths (1 at a time, 2 at a time, or 4/8 at a time).

A lot of the code has been rewritten to avoid unaligned accesses even though x86 processors can handle them, because some compilers are not designed to emit correct instructions when some optimizations are enabled. I haven't tried to isolate each of the functions as separate files so I could compare the function contents line by line, but I suspect there is small differences in other parts of the functions than just different compare chunk size.
UNALIGNED_OK can be used to both check if processor can handle unaligned loads and stores and if processor is likely little- or big-endian, as most big-endian processors don't allow unaligned accesses.

I was not able to find anywhere where there was unaligned access so maybe UNALIGNED_OK is not necessary.
It does seem like the only difference is the compare chunk size. The difference used to be that one was for UNALIGNED_OK access while others were not. I think while trying to fix ASAN errors, everything might have been changed to be aligned.

Perhaps if UNALIGNED_OK is defined in CMakeLists.txt, it should not add -fsanitize=alignment.

Maybe there should be pull request to cleanup/merge the longest_match variants... Would help maintaining the code as only one version needs to be checked for improvements/issues.

I have abstracted out the methods of comparing 258 bytes and have done a performance testing on them:
https://gist.github.com/nmoinvaz/b70fd103c5bed104dfbcf09d5d927cfe


Update Bottlerocket to 1.6.0

Description of changes:
Update Bottlerocket to latest release.
/hold for testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold

/cherrypick release-0.7


Windows/MacOS test fixes

Given that this adds extra tests on MacOS, we'll want to wait for the result before merging.


“Turn on Sound” on Launch screen

Recommand sound on for users
Only for first launch

Cancel Idea


Remove qgan and runtime packages as deprecated

Summary
This PR removes qgan and runtime packages from the sources, tests and documentation. The packages are deprecated as of version 0.5.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
44 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 90.014%

Files with Coverage Reduction
New Missed Lines
%

qiskit_machine_learning/datasets/dataset_helper.py
44
28.4%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
2542

Relevant Lines:
2824

💛  - Coveralls