mutating-webhook doesn't work for the ClusterIssuer in v1alpha3 with official CRD manifest

Describe the bug:
I made a ClusterIssuer CR in v1alpha3 with the official manifest, but mutating-webhook didn't work for the CR.
I guess this is caused by the following:

MutatingWebhookConfiguration has the api version of admissionregistration.k8s.io/v1beta1.
In admissionregistration.k8s.io/v1beta1, the default value of matchPolicy is Exact.
.webhooks.rules contains only cert-manager.io/v1alpha2.

In summary, only cert-manager.io/v1alpha2 is mutated and cert-manager.io/v1alpha3  doesn't seem to be mutated.
Expected behaviour:
To make the webhook work for cert-manager.io/v1alpha3.
Steps to reproduce the bug:
Try applying the manifest like below:

Download manifest from this link and apply it.

Apply the following manifest.

apiVersion: cert-manager.io/v1alpha3
kind: ClusterIssuer
metadata:
  name: self-signed-issuer
spec:
  selfSigned: {}

Anything else we need to know?:
IMO, we can fix it by the one of the following.
A:
Use admissionregistration.k8s.io/v1 for MutatingWebhookConfiguration, because the default value of matchPolicy in admissionregistration.k8s.io/v1 is Equivalent .
B:
Add cert-manager.io/v1alpha3 to .webhooks.rules.
Environment details::

Kubernetes version (e.g. v1.10.2): v1.17.4
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): CKE(on premise)
cert-manager version (e.g. v0.4.0): v0.14.2
Install method (e.g. helm or static manifests): using kustomize

/kind bug

Thanks for looking into this, and nice catch! 😄
Do you know if this applies to our ValidatingWebhookConfiguration as well?
I would lean towards option (B) as (A) would mean we only support deployment on Kubernetes 1.16+ (we currently support all the way back to 1.11). Alternatively can we just set the matchPolicy explicitly on our v1beta1 resource?

Thank you for your reply.

Do you know if this applies to our ValidatingWebhookConfiguration as well?

I believe so.

I would lean towards option (B)

It looks good to support k8s 1.11.


Ldanzinger/identify layers

@michael-tims please review and merge

@michael-tims thanks for catching those. updated


Rachit Tandon

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one. Nice Profile btw 🚀


Fix metrics

fix logger by ignoring empty last entries
fix metrics with fixing indexes

Also test metric with hardcoded situation (related to #149 )


When large columns is less then small columns, the amount in large appears when on mobile view port

When the number of large columns is less than, the number of small columns. The number of large columns still appears when in small view port.

@soldiercnorm do you work on this? If not, can you assigne me to this issue?

@denisinvader I haven't, and yes I can assign it to you.


On High Sierra, dinghy appears to mark files as modified

Hi all, I can't claim to know exactly what is causing it, but our team has identified a major issue impeding development on Dinghy since we upgraded to Mac OS X "High Sierra" recently.
When Dinghy is running, and a file in the shared folder is edited externally (e.g. in Emacs) and saved to disk. When user attempts to edit the file again, something unexpected happens:

editor reports that file was changed externally, and asks if it should be saved again?
on attempt to save, editor asks if we want to overwrite external changes?

It should be noted that the expected thing also happens: the app inside Dinghy observes the change.
We've verified this behavior occurring in all of: Emacs, Sublime Text, and Rubymine, for example. However, for Rubymine, there is a workaround by changing to nio2 file api.
Hypothesis: Is this due to an interaction between the Dinghy NFS server and the new Apple APFS file system, which has nanosecond modification times?
We've verified that dinghy stop allows the editors to save files unimpeded by this issue.
Any ideas? Anyone else seeing this?

Forthcoming: we are going to experiment with running on regular Docker on Vagrant and report back if that suffers the same problem.

Is it possible that it has anything to do with this aspect of how APFS behaves, or any other aspect of APFS in particular?

Related at all? https://arstechnica.com/gadgets/2017/10/security-and-compatibility-problems-make-for-a-rough-apfs-transition/

@ms-ati We (myself and coworkers) are all running High Sierra with dinghy and we haven't seen this issue across vim, macvim, neovim, atom, or vs code.  Note: we all did a clean install instead of an upgrade.

@ryansch We are seeing this universally -- every developer -- so I think we need to find a way to reproduce easily.
Can you specify: In Disk Utility, was your main hard drive created as APFS, or not?

@ms-ati Yes all of my macos volumes are inside of an APFS container.

@ryansch I'm in the same org as @ms-ati , one thing I just thought of, are your APFS volumes encrypted?

@mizhi They are!

To add a bit more mystery to this, I setup a vagrant machine with docker and ran our setup in that, and did not experience the issue described above. To make sure I wasn't going crazy, I shut that down and started up everything using dinghy and immediately started getting the file modification issue.
Going to dig some more on the dinghy side to see if I can suss out more answers (or better observations).

I haven't seen this myself, but it's almost surely something to do with https://github.com/codekitchen/fsevents_to_vm which Dinghy uses to make filesystem events work across the NFS mount. So I'm not surprised that it doesn't happen with vagrant-flavored docker, since vagrant doesn't make any attempt to make fsevents work.

...to make the above even more specific. Is it reasonable @codekitchen to hypothesize the issue is with
https://github.com/codekitchen/fsevents_to_vm/blob/master/lib/fsevents_to_vm/ssh_emit.rb#L14
...specifically, that then unfsd is observing the touch inside the vm, and propagating back to the APFS file system a new value? Implying a hypothesis that the change to APFS in High Sierra, in some cases, is causing an unexpected mtime to propagate back out via NFS?

That does seem the most likely culprit, though I'm not up to speed on APFS and I haven't seen this myself, yet.
A quick glance through the unfs3 source code shows it uses utime for setting timestamps, which only has second-level precision, so it doesn't look likely that fsevents_to_vm can just switch to replicating over higher-resolution timestamps as a fix.

Also, in principle a solution to this issue should be possible and in fact not too hard, right? I ask because, I observe that the filesystem inside dinghy is ext4, which DOES itself support nanosecond times, ultimately.
Strawman of the steps one could take here:

Ensure Dinghy's base Linux vm image is configured exactly correct so that nanosecond timestamps in the ext4 filesystem are fully working
Test-drive fsevents_to_vm, if host is on APFS, to propagate the full sub-second timestamp (this is probably just modifying the ruby code to read the fractional timestamp, and the touch command that we run inside the VM to write the fractional timestamp
[HARD?] Patch unfsd to stat and to write nanosecond timestamps where supported

Of the above 3 steps, I feel least confident about (3).
Thoughts?

cc @michaeldiscala

Yeah that's why I dug into the unfs3 source first -- patching that would be the only difficult part, though hopefully not more than a few hours work. I don't know how much work on top of that it'd be to get the patch accepted upstream, or whether they'd require parity in the Windows back-end. It does look like NFSv3 supports nanosecond-precision timestamps, so it should hopefully be possible. It's not something I'll be able to tackle myself in the near future unfortunately.

@ms-ati @codekitchen i suggest you to just stick with standard nfs server implementation (es: https://github.com/adlogix/docker-machine-nfs) we are using that with Dinghy and it works fairly well (https://github.com/sparkfabrik/sparkdock)

@paolomainardi Thanks for those links, it looks like similar issues on High Sierra were faced in docker-machine-nfs in https://github.com/adlogix/docker-machine-nfs/issues/79 , and they fixed it with parameters to the NFS daemon?

It was another kind of problem, mainly related to an operating system bug then fixed

One thing that still confuses me: why aren't we all seeing this bug?  What's different about your workflow/environment (etc)?

@ryansch Yes! We are furiously invalidating hypotheses as quickly as we think of them. We are (un-)lucky enough to have multiple developers who see, and who are not seeing, this issue. So we are working hard to prove any hypothesis about what is different between their setups.

I am using APFS without the encryption + native nfs server and i can't face any issues here.

@ms-ati That's quite interesting that you have devs on both sides of the fence there.  Feel free to ask for help testing any hypotheses that pan out!

Hey all!  I wanted to chime in here with some info and reproduction as well.  I similarly am on an APFS volume, with encryption resulting from an in-place upgrade to High Sierra.
When dinghy is not running, I do not see any file modified errors while saving files.

When dinghy is running, I do see file modified errors, if I am saving while typing.

This seems to lend credence to the fact that it's related to the timestamp differences between modified timestamps mentioned above.  If I save a file while I am not actively typing, my editor does not prompt with any errors:

Hope that helps, happy to provide more info as needed!

Wow @seckenrode that's excellent.  There's no bug quite like a race condition!

To clarify an additional thing that we're finding interesting:
The test_file.rb is in my /Users/seckenrode/Desktop directory.  I do not have any docker containers actively running at the time of this test, and I do not have any docker volumes mounted AFAIK.  The only difference between the first and second/third GIFs here is that I ran dinghy up between the two.
I'm not sure what that means, w.r.t. the fsevents_to_vm and the unsfd server here.
Thanks!

Another clarification: I thought that I wasn't seeing the same issue as @seckenrode. But in fact I am! It's just that I wasn't typing and saving as quickly together as he was.
Steps to reproduce on my machine:

dinghy up
Open a file anywhere under my home directory in Sublime Text 3
While typing quickly, his Cmd-S to save, like "Hello World"

What I observe is, if I type quickly the Cmd-S, I see the same as @seckenrode gif above

It appears that the crucial reproduction step is: typing in the editor within 1 second after saving.
This appears to trigger the error in Sublime Text 3 every time. It appears the difference between our developers with and without the issue was more in their typing and saving speed and habits than in their machine configurations?

...it appears that Emacs has this worse, as by default it asks the user every time a file modification time is changed, not just when the buffer has changes that differ from disk.
This behavior can be changed by the user to do what Sublime Text 3 does (compare the buffer contents to the disk contents to avoid warning when no changes) through the use of Emacs lisp, I think:
https://emacs.stackexchange.com/questions/21137/fix-changed-on-disk-reread-from-disk-when-file-has-not-changed

Nice. Right now Dinghy replicates all FS events in your home dir to the docker-machine VM, it doesn't try and work out which folders are currently mounted as volumes and only replicate those. So it makes sense that all you have to do is dinghy up to see the issue.
I think I've covered in the FAQ why using the native NFS server isn't possible for our use cases, but I bet it works well for those who don't also need NFS for other purposes such as Vagrant shares. How much did you have to modify Dinghy to make that setup work?
Using the native NFS server might be a good way to confirm that modifying fsevents_to_vm to touch with sub-second timestamps does fix the issue, before trying to modify unfs3, assuming the native NFS server does do sub-second timestamps.

Makes a lot of sense @codekitchen. We are evaluating on our side whether we have the time and appetite to push this further, will let you know.

It seems that you are aware of the problem.
Just to say that we encounter the same issue in applications like Paw or Coderunner. But everything works fine with Visual Studio Code…
If it can help we also have strange behaviour with Dropbox.
Some files, like *.key (Keynote), are modified without any user actions, can not be opened by others or generates conflicted versions…
If you want more informations, just tell me.
And, last but not least, thanks for the hard work! :+1:

Unfortunately, as you can see in the discussion with UNFS3 authors on SourceForge, that project appears to be effectively dead with no upstream authors to collaborate with.
Unless someone else emerges who wants to take on development of UNFS3 to the extent that they can collaborate with us in adding support for nanosecond timestamps on APFS on High Sierra, and take on responsibility for an upstream repository and Homebrew recipe, then we are probably not going to pursue this any further.
We are investigating whether Docker for Mac has improved sufficiently in recent months to be a viable replacement for Dinghy for our use cases.

Despite @ms-ati's claims that there are no upstream developers to collaborate with,
I spent some time this weekend digging into this issue and came up with something. I've got a git branch of unfs3 with some code that should allow for microsecond or nanosecond resolution access/modify timestamps, on platforms where this is supported. I haven't really tested the code much yet, so beware of bugs.

During my lunch break, what I am trying today: Following the Homebrew instructions to make a proper pull request against Dinghy in order to use @derfian 's new branch for unfs3.
I'll report back here with

Does it actually work on my High Sierra system
A link to the PR in question to discuss further

Any thoughts?

Ok. To see my progress on testing @derfian UNFS3 changes in Dinghy thus far, please see this gist:
https://gist.github.com/ms-ati/aaafdf091e1b04c4621aeec18cbfab4c
I will update as I progress.
Based on dtruss -n unfsd output, I am seeing calls to lstat64, fstat64, and setattrlistat. I am not seeing any calls to utime, utimes, utimesat, nor clock_gettime, when I edit a file and watch the dtruss output.
In order to view the local MacOS nanosecond timestamps, I did brew install coreutils and gls --full-time.

Here's my branch of the Dinghy Homebrew Tap where I am developing, pulling in @derfian 's branch of UNFS3, and soon to pull in my own fork of Dinghy to get the necessary support on the fsevents_to_vm side:
https://github.com/ms-ati/dinghy/tree/use-unfs3-branch-higher-resolution-setattr
Thoughts? Comments?

Update: It appears that @derfian branch of unfs3 is correctly setting the nanosecond timestamps to the Mac OS server host, but it does not appear to be reading the nanosecond timestamps from the Mac OS server host.
Details reported on SourceForge for UNFS3 here:
https://sourceforge.net/p/unfs3/bugs/10/#f004

@codekitchen Is there anyone who can help investigate the fsevents_to_vm side with me?

That's awesome. I should have time to poke at fsevents_to_vm later next week. If anybody else wants to look before then, I think all that may need to change is the code that reads the mtime on this line. Unless I'm forgetting something, which is possible as it's been a long time.

Hi @codekitchen there's an additional wrinkle. I have a branch of fsevents_to_vm which correctly formats the mtime using Time#iso8601(9) which is the right way to get nanoseconds, and on a Ubuntu container setting using touch -d works correctly.
However, the boot2docker host that fsevents_to_vm is actually ssh'ing into is actually based on BusyBox, and so the touch command is just BusyBox rather than Gnu Coreutils touch. The point of this digression is that the touch command there does NOT support nanoseconds.
One path forward that I was going to try was to have dinghy run an additional container which does contain a nanoseconds-enabled touch command, just for the purpose of replacing the ssh-to-touch with docker exec to touch. Any thoughts on that?
Could the existing Proxy container be extended to (a) mount the NFS-share of the host home directory, and (b) support docker exec from fsevents_to_vm to run the touch command?

Per agreement with @derfian on the unfs3 sourceforge issue here:

I have a few portability concerns about the new code that I'd like to review before merging to master. Making a new release isn't at the top of my priority list at the moment.

No worries, I understand. In the meantime, would you be willing to commit to keeping your existing Github branch available at the same path? Could we temporarily make dinghy depend on that branch to build, to get Mac OS docker users back into good shape, and later change the dependency to be your next release?

Sure, I will do that. I don't mind having the dinghy team depend on this branch until everything else settles into place.

I will be submitting a PR to homebrew-dinghy to officially switch the unfs3 dependency to his branch implementing nanosecond support, until such a time in the future as @derfian is able to finish testing cross-platform support and make an official release.

Hm yeah that's a bummer. Using the proxy container seems like a workable solution, my only concern would be whether there will be too much overhead doing a docker exec for every touch. If that turns out to be the case, we could possibly run sshd inside the proxy container or come up with some other mechanism for keeping open a long-running connection.
I wouldn't be opposed to option 1, the static binary, either, I'm just not sure about the specifics.
Sorry I haven't been more responsive, I've been traveling without my laptop. If you're going to work toward this I'll hold off on doing anything this week. Thanks!

@codekitchen No worries, I've just proven out an easy solution: literally copy the GNU coreutils touch binary from a ubuntu:16.04 container into the Dinghy VM. It works perfectly, same version of libc, etc. Will have a PR for you in next few days.

Ok @codekitchen, PRs are up to both homebrew-dinghy (to pull in the fixes from UNFS3) and fsevents_to_vm
https://github.com/codekitchen/homebrew-dinghy/pull/2
https://github.com/codekitchen/fsevents_to_vm/pull/9
The ball is now in your court to review, and eventually to release a new version of Dinghy to pull in fsevents_to_vm when it is merged! :)

Ping @codekitchen -- hope you get a chance to review this soon!
Have a great Memorial Day weekend (assuming you are based in US per your profile)!

Big thanks to @ms-ati for tackling this, it's never fun to wrangle changes in a dependency like unfs3. I've cut a new Dinghy release v4.6.4 with this fix, everything seems to be working well. Please report if you still see the problem or any other issues that may have cropped up.

@codekitchen I recently updated to Catlina (from Sierra) and I am still noticing this issue. I have dinghy 4.6.5 running. I can easily test by changing anything in an xcode project (for example, updating the version number). Because xcode autosaves the change, I see a warning that the file was modified by another process. When I stop dinghy, it works as expected.

@codekitchen ahh, it looks like I may have needed to install unfs from homebrew

@jscheel I had the same problem, do you mind elaborating a bit more how you installed unfs from homebrew?


Upgrade @babel/plugin-proposal-decorators and mobx

Blocked by https://github.com/mobxjs/mobx/issues/1352

Downgrade to babel instead of @babel.


fix: pass down style props on modals

The change allow user to decorate over already made components like Modal.Body or Modal.Header.
A workaround can be to re-encapsulate the Modal.Header in another div styled with what we want, but if we are working with heights it is not alway sufficient.

I'm a bit reluctant, because one of the goals of react-science is to help make coherent user interfaces. If you want to pass arbitrary root styles to components exported here, it seems to indicate that we have failed to make good enough components.


Introduce nativeOnMobile option and bugfix view that does not update on date mutation

:+1:

:+1:


Retrieve translatable word count for current website and LTS docs

This count includes all plain-text, and all comments inside code blocks. This count should exclude all code examples, titles that are simple method names, and other non-translatable content.
Counts should be reported by page / module, not as a single number.
As is being discussed in https://github.com/nodejs/community-committee/issues/114#issuecomment-343874899, we are evaluating if/how much LinkedIn would be able to donate i18n to the Node.js project.
To submit a proper scope-of-work we need to collect the top requested languages (done in https://github.com/nodejs/community-committee/issues/114#issuecomment-343623384), and a word count for the requested translatable material.

@amiller-gh I try to get data with GitLocalize. I will share the stats tomorrow.

@bnb Do you know where LTS docs is?

@amiller-gh I have uploaded compressed CSV file on dropbox.

website: https://www.dropbox.com/s/qcgc9w3kgqbc9dt/website.csv.zip?dl=0
LTS: doing now

@bnb
I would appreciate you if could tell me know how to build LTS docs. Which version of the current master branch is based on?
Thanks in advance

Thank you for the work @sotayamashita! It is SO appreciated!
I believe current LTS docs live here in the 8.x branch: https://github.com/nodejs/node/tree/v8.x/doc (@bnb can correct me if I'm wrong).
The CSV format will work well, I like the breakdown by markdown file. Does that count exclude code examples that won't need to be translated?
After we get data for LTS I can get the proposal put together and submitted to LinkedIn in the new year 👍

Sorry, I thought I posted this - may have said it on Twitter to @sotayamashita:
You can make build in the relevant branch and you should be able to build the Node.js docs. So run it in the branch @amiller-gh shared and it should build.

@amiller-gh

The CSV format will work well, I like the breakdown by markdown file. Does that count exclude code examples that won't need to be translated?

Yes. It must be.
@bnb
Thank you for the information

@amiller-gh @bnb
I'm sorry it took so long to get back to you. I have prepared compressed files. https://github.com/nodejs/community-committee/issues/183#issuecomment-350983765

Going to close this for now, but @amiller-gh please feel free to re-open if there's still more that needed to be followed up on 👍


Address failed tests after applying fix for issue #1425

Address failed tests after applying fix for issue #1425 which is ralated to the countable issue in php 7.2.
I think the issue is related to the fact that the fix added the condition: is_numeric($pk) && $pk > 1 to the if, which is not present in the previous releases, which then caused some tests to start failing.

It seems that the issue was already solved by another commit and this fix is not needed anymore... However, I still prefer this implementation to the one currently implemented.

What commit/fix do you refer to? You got the example to compare to your solution?

Sorry for not mention it @dereuromark, it was by this pull request: #1452 (which in fact did such a good job, fixing all the issues with tests in 7.2)

Thanks!


Not able to select date and time in WEB

When I implemented it in the mobile app its work perfectly but on the web, it will open correctly but not able to select time and date.

https://user-images.githubusercontent.com/7537622/135799174-45881331-8133-4fca-b234-97de10d068f4.mov

@TechnoPrashant  can you please show me how you implemented the bottom picker in your app ? i'm not having this issue in the example that i've tested now

@koukibadr  Thanks waiting for your update.

@koukibadr Hi Any updates ?

@koukibadr  It was fixed from my side. Issue from my side. But still, one thing I notice is that when I use a mouse to scroll picker it does not work.

@koukibadr It was fixed from my side. Issue from my side.

could you help us to fix this issue? please describe your solution.

@TahaMsv on the web the scroll works but with the middle mouse wheel not with dragging the list down
You can test it and let me know if it works or not

@TahaMsv on the web the scroll works but with the middle mouse wheel not with dragging the list down You can test it and let me know if it works or not

That's right, I knew. But I want to know how to work with the mouse down(drag). I opened an issue for this a few hours ago.

Okay for now it's not supported but I will add the support for dragging on the web version Thanks for your feedback @TahaMsv

Thanks. I need it for my project. Can you guess how long does it take to fix it?


search bar issue

search bar seems unresponsive, can you please reply with what it should search for?
please assign this to me under GSSOC

The issue has been resolved. It would search for books but yet we have not added books


Request for comments: Should an IPV6 enabled libupnp fail initialization if there is no IPV6 available on the chosen interface?

Hi folks,
As the title says, I am looking for opinions on how to fix (or not) the current behavior. But first, a little background information.
If you go to the project page today, you will notice that the branch master has a "failing" badge. This is because since we dropped the UpnpInit() method in favor of UpnpInit2(), the mac-os part of the automated tests stopped working. So this problem was always there, but just showed now. That is why I decided to release 1.14.0.
I don't have a Mac, so I had to deal with the virtual Github environment and I created a new branch to do some tests and found out that the mac-os virtual machine did not initialize the IPV6 stack in the en0 (Ethernet) interface. In spite of this, the library did initialize everything correctly until it tryed to create an UDP socket and tried to join IPV6 multicast, which is what triggered the failure.
Fixing the mac-os test failure is not a problem and has indeed been done in the auxiliary branch. But the question that remains is: should the library fail initialization or should it go on with IPV4? I am not the author of the original libupnp IPV6 code, so all I can do is read the code. It seems to me that lots of "ifdefs" were supposed to make the library code smaller, but that is not necessarily the case as the last patch I did on miniserver.c showed. Personally, I believe that if it does not imply a link time failure, being IPV6 enabled is not a problem even if it is not configured. Also, notice that IPV6 might be configured only in some interfaces, which makes things even more messy.
To summarize my thoughts:

I believe that the library initialization code should not fail if there is no IPV6 on the desired interface, as long as we can go on with IPV4.
I don't believe we need a configure time --enable-ipv6.

Since I can certainly be wrong in both cases, I ask for your comments.
Best regards,
Marcelo.

I agree with both your points, still it is quite common to have compile time optional IPv6 support so if it doesn't require too much work to keep it I'd keep the compile time switch

The problem is that to get UpnpInit2 you have to enable IPv6 anyway.
All consumers will now need UpnpInit2, so all will require the "optional" IPv6 support.
Therefore it is not actually optional any longer and should be enabled permanently.
Then the library should be made to not fail at runtime with pure v4.
So yes, to both both points from me.


Webpack problem, how to solve it?

Field 'browser' doesn't contain a valid alias configuration
The error shows like this. Try to googling still cannot find right answer

We need more information.

@aa6my Is this still an issue for you?

Close this issue due to inactivity

fixed up https://github.com/RobinBuschmann/sequelize-typescript/pull/574


merge from template-arlac77-github

package.json

chore(package): add 0.0.0-semantic-release (version)

README.md

docs(README): update from template

:tada: This PR is included in version 2.1.21 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Install latest coreir version now that master is fixed

@alexcarsello @ankita0805 after this is merged, you can drop the export commands that use an old version of coreir. We can update the shared kiwi installation to be the latest master.

Pull Request Test Coverage Report for Build 315

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.035%

Totals

Change from base Build 313:
0.0%

Covered Lines:
134

Relevant Lines:
141

💛  - Coveralls

Addresses https://github.com/rsetaluri/magma_cgra/issues/27

Note: solves issue #27


Access Model Relationships at runtime

I am looking to access the EF Model relationships via my dbcontext and currently don't see a way to accomplish this.
I know that i have access to this type of information during OnModelCreating via the ModelBuilder, because we are currently able disable cascade deleting any persons by gaining access to all foreign keys. ex.
foreach (var relationship in modelBuilder.Model.FindEntityType(typeof(Person)).GetReferencingForeignKeys())             {                 relationship.DeleteBehavior = DeleteBehavior.Restrict;             }
However, I'm not sure is this type of information is accessible during something like the save of a record.
Simple Model Setup
public class Person
{
[Key]
public virtual int Id { get; set; }
public virtual string PriorLastName { get; set; }
public virtual int AddressId { get; set; }
public virtual Address PersonAddress { get; set; }
...
}
public class Address
{
[Key]
public virtual int Id { get; set; }
public virtual string Line1{ get; set; }
public virtual int Line2 { get; set; }
...
}
Use Case:
When calling a save directly to address repo, which in turn calls save to dbcontext. If i had access to the foreign key's of address, it would return that a foreign key to person exists. I am now able to run the code i need to run for all persons that have an address id of the address being saved.
For my real life scenario the person along with its address is pushed out to an external system.
Note: Please keep in mind, I have simplified the example in this ticket. This is needed for a larger scale scenario. I mention this because I know the someone will come back with just save the Person with the address, which is not possible in my real life situation.
Further technical details
EF Core version: 1.1.2
Database Provider: Pomelo.EntityFrameworkCore.MySql
Operating system: Windows
IDE: Visual Studio 2017

@jayslife DbContext.Model?

Thank you @ajcvickers, this must have been the easiest ticket all day....lol! Not sure how I missed that.
Thank you for your help!


Request to make File Explorer display a column view like macOS Finder

I was wondering if it was possible to make Windows File Explorer behave like macOS Finder and display a column view.

Sadly that's not possible at the moment. From searching over the internet I found One commander, a free third-party software.
If you want to suggest such a feature for File Explorer please use the Feedback Hub

Oh, ok. I was just wondering if it could be a possible idea for a feature one day, but maybe it is a bit of a stretch 😅
Thank you anyway for the feedback and the tips!


acknowledge lamp/epfl copyright but add apache license header

I still need to work out if the LICENSE change is needed and if is not, then I can revert that bit.
If it is needed, I needed to change the bit that adds the LICENSE to jars because only the actor jar needs this version of the license - other jars need only the standard license.

HI,
Note that MurmurHash3 is not ALv2 licensed. [1]
Justin

https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp

@justinmclean I'm not really sure what to do with this file yet. One potential option is to remove it - because we might be able to use the class from the Scala jar instead. That would simplify life for us, I think.
I just hope that Lightbend Akka did not modify the copy we've inherited - in a way that makes using the Scala version break our tests and use cases.

@justinmclean removing the Pekko MurmurHash code doesn't seem feasible. It is quite different from the Scala equivalent code.

the reason I added the modified Apache v2 license header is that we generally agreed to put this on all Pekko source files in https://issues.apache.org/jira/browse/LEGAL-626
The Scala LAMP/EPFL copyright header was already in the file (from the Lightbend/Akka code that Pekko started with)
Scala itself is Apache v2 licensed - https://github.com/scala/scala
The aappleby/smhasher code is Public Domain and the author has waved copyright

With all this in mind:

is it ok to update the Pekko MurmurHash.scala file to add the LEGAL-626 header?
is it ok to put the LAMP/EPFL copyright in our LICENSE file (for the source release)?
only one of the jars that we will create from this project will contain this code, so I will adjust this PR to ensure that an appropriate LICENSE/NOTICE for that jar (which will match what we agree for the source release)

Converting an algorithm from one language to another doesn't change its license. You need to respect the original license that it is under and ASF policy, and IMO this code is not under ALv2. See https://www.apache.org/legal/resolved.html#handling-public-domain-licensed-works for how to handle this.
Also, can we please fix the GitHub no-reply email on these messages as not everyone will want to use Github as it makes it impossible to reply to issues sent to the mailing list.

@justinmclean the emails sent to notifications at pekko mailing list are generated by Github. I'm not aware of any feature in Github that lets me control the format of those emails and what the reply-to is on them.
We can take the conversation about the attempt to properly attribute the copyright and license for MurmurHash into a new email thread on dev at pekko mailing list, if you prefer.
My latest attempt at updating the Pekko license is to add this section to our LICENSE.
pekko-actor contains MurmurHash.scala which is derived from MurmurHash3,
written by Austin Appleby. He has placed his code in the public domain.
The author has disclaimed copyright to that source code.

I'm still quite confused about what to do about the LAMP/EPFL copyright that has been placed on MurmurHash.scala.
Are you saying that we should ignore this in our LICENSE/NOTICE files? I presume that we leave the LAMP/EPFL copyright in the MurmurHash.scala file because it was already there.

I've not had this problem with other ASF projects, possible something to configure in /.asf.yaml? We do have people involved at the ASF who refuse to get a GitHub account.
IMO LAMP/EPFL copyright was placed incorrectly on that MurmurHash file, but probably the best way to deal with it it to add the MurmurHash  header above the MurmurHash code as file can contain a mix of differently licensed code and to list that license in your LICENSE file as described here.

@mdedetrich I need to get more eyes on the license text but would you be able to review the technical aspects of these changes, when you have time?

I've split out 3 separate special license files for 3 jars that have source code that does not originate from Lightbend or Pekko team
the root LICENSE (source license) does not mention the pekko-protobuf-v3 module because the source repo does not include that source - but the build downloads the protobuf-java 3.16 jar and shades its classes - so we don't actually distribute this source per se but we do distribute classes in binary form (the pekko-protobuf-v3 jar) that derive from the Google protobuf source
I'm happy to rename that legal directory if it is confusing - possibly renaming the dir to something like jar-licenses.

Will do, I will look at it by tonight (tomorrow latest)

LAMP/EPFL copyright was placed incorrectly on that MurmurHash file

Couldn't a port to another language be a derived work that could have its own copyright (in addition to the existing one)?

LAMP/EPFL copyright was placed incorrectly on that MurmurHash file

Couldn't a port to another language be a derived work that could have its own copyright (in addition to the existing one)?

I've kept the LAMP/EPFL copyright header as well as adding one to acknowledge Austin Appleby's authorship of the original code.

I just hope that Lightbend Akka did not modify the copy we've inherited - in a way that makes using the Scala version break our tests and use cases.

In seems the Akka version predates the version in scala library:
2011/09/08: Scala: https://github.com/scala/scala/commit/52c1d019d63d2fffadc8f3f159d654187ac61ece#diff-d2dc3cf0fd4ebb89cc33b035534ad76f90c7f97e285b57ff4b95cc8fefbc0adf
2011/05/17: Akka: https://github.com/apache/incubator-pekko/commit/cfea06c5d50a50234249c701d7b64c8750f3455d
In any case, the hash values are not the same (but that doesn't mean that using the Scala version wouldn't work...).

I just hope that Lightbend Akka did not modify the copy we've inherited - in a way that makes using the Scala version break our tests and use cases.

In seems the Akka version predates the version in scala library:
2011/09/08: Scala: scala/scala@52c1d01#diff-d2dc3cf0fd4ebb89cc33b035534ad76f90c7f97e285b57ff4b95cc8fefbc0adf 2011/05/17: Akka: cfea06c
In any case, the hash values are not the same (but that doesn't mean that using the Scala version wouldn't work...).

The Scala and Akka classes are very different so I gave up on the idea of trying to drop the Akka one. So the ongoing PR is just come up with the right license and copyright text.

After more digging the Akka one is based on the old version of MurmurHash which was removed after being deprecated in https://github.com/scala/scala/commit/5c7fd1bc039e0ea22b6b2d02596e7b8689c0213c for Scala 2.13.

If you want a MurmurHash3 that is correctly impleented for the JVM and is under Apache License see commons-codec
https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/digest/MurmurHash3.html

If you want a MurmurHash3 that is correctly implemented for the JVM and is under Apache License see commons-codec

That link says

This is public domain code with no copyrights.

I'd prefer to proceed with this PR that keeps the existing code but tries to improve the license statements. The public domain smhasher code is not problematic. The real issue is to just acknowledge the use of the original code. The commons-codec code can be looked at if we cannot agree on the updated license text.

I've merged this to move things on. If anyone has any concerns, I'll be happy to make further changes or revert this.


[SYSTEMML-591] Initial attempt to consolidate replicated compilation chain

This PR only consolidates MLContext and DMLScript's execute method. But JMLC and old MLContext are not touched in this PR; latter is going to be removed soon. This addresses several inconsistencies/duplications:

Statistics.startRunTimer(). In subsequent PR, we should address Statistics.startCompileTimer();
Printing Statistics via Log4J.
Recently added boolean flags such as systemml.stats.extraDNN, systemml.stats.extraGPU, etc.
Spoof was not enabled via MLcontext.
GPU creation logic and error message

@mboehm7 @deroneriksson @nakul02  can you please review this PR ?

Build successful

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1381/

thanks for working on this; couple of high-level comments:

the up-to-date issue is https://issues.apache.org/jira/browse/SYSTEMML-1325
the purpose of this issue is to consolidate the compilation chain from script to runtime program to create consistency and fix a couple of existing bugs, not just the actual execute
I would recommend to remove the old mlcontext first in order to avoid unnecessary updates
further, please start from DMLScript's compilation chain as this is the only feature-complete compilation chain and thus, the ground truth.

Furthermore, it would be great to design a configurable compilation chain first, implement it as a new class, and subsequently replace all duplicated compilation chains (for that the new chain need to be sufficiently flexible to allow a one-line invocation from mlcontext/jmlc/dmlscript/debug)

I would recommend to remove the old mlcontext first in order to avoid unnecessary updates

I am not sure the right protocol here. Should this be discussed on the mailing list before removing an API ? If this is not required as the old MLContext has been deprecated for a while, I can remove the old MLContext as part of this PR. Else, I suggest that it should be addressed in a separate PR.

the purpose of this issue is to consolidate the compilation chain from script to runtime program to create consistency and fix a couple of existing bugs, not just the actual execute
further, please start from DMLScript's compilation chain as this is the only feature-complete compilation chain and thus, the ground truth.
Furthermore, it would be great to design a configurable compilation chain first, implement it as a new class, and subsequently replace all duplicated compilation chains (for that the new chain need to be sufficiently flexible to allow a one-line invocation from mlcontext/jmlc/dmlscript/debug)

I agree, this PR doesnot resolve the JIRA. In fact, this PR is deliberately scoped to only address the execute() part of the compilation chain for two reasons:

The inconsistencies in execute() part could results in significant bugs when used via MLContext.
I do not have free cycles (at least for next few weeks) to consolidate the entire compilation chain.

If you prefer, I can rename the PR to SYSTEMML-1047  and SYSTEMML-1506 and we can merge it in.  I am also OK with closing this PR if you or someone else wants to redesign the entire chain; in which case, this PR will just get in the way :)

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1430/


Use ETAG in Github API calls for Documents

Right now, unauth github api call limit is very low, 60/Hour.
So occasinally, on applens V2, you see no documents.
To check the limit and remaining, check response headers:
X-RateLimit-Limit, X-RateLimit-Remaining
Three possible fixes:

Creating client id and app key (somehow. Need to study that.There might be pricing involved here). The Rate increases to 5000/Hour
Cache Github API response in web api. Problem in this approach is if someone updated the document, that wont be reflected in UI until web app is restarted. So I guess, this is a NO-GO
Using ETAG in github api calls. If doc is not updated, server will return 304 and is not counted as part of rate limits.

Combination of 2 and 3 will work. (unless we did more than 60 updates in an hour, or there are more than 60 detectors).

PR(merged) : https://github.com/ShekharGupta1988/AppLensV2/pull/37


Can't watch only one configMap

Hello,
I'm having an issue of not being able to "watch" a single configMap.
I can watch ALL the configMaps in a namespace successfully and receive all the updates in the ResultChan() channel. BUT to get the updates of just one config, i need to do hacky stuff with filtering by Labels using the metav1.ListOptions LabelSelector.
Like this:
configMapWatch, err := client.CoreV1().ConfigMaps(namespace).Watch(metav1.ListOptions{
	LabelSelector: "component = config",
	Watch:         true,
})

But I would like something like this:
configMapWatch, err := client.CoreV1().ConfigMaps(namespace).Watch(metav1.ListOptions{
	Name: "name-of-my-config",
	Watch:         true,
})

Is this possible already??
Thank you very much

yes, set ListOptions.FieldSelector = fields.Set{"metadata.name": name}.AsSelector().String()
/close

Thank youuuuu @liggitt ! That works!


Router advanced: use Fetch instead of XMLHttpRequest to fetch those views

Just thought it would be nice to use fetch since we actually can for document too. I could not obviously used your ?delay=xxxx so I delayed it with a basic setTimeout.

I guess this should account for the state where the DOMParser fails to parse, or even that the fetch fails?

Sorry, there was not any error handling in the xhr version, I just thought about translating it as it is.
I added a catch clause so there would not be any silent error in the promises chain. By the way, the DOMParser, when fails to parse, without raising any error, returns an error document, per MDN.

Anyway, I watched the TL;DR and the xhr version seems to be your choice so I'll just close the PR to clean the repo. As you said, "there is nothing wrong with an xhr" ✌.


override metric name

Realtime Plumber has to override metric name, when scanning segments.

@drcrallen oh right we added that, yeah, segmentAndCache is cool

@fjy done !

:+1:

:+1: after travis


run CI on all branches

This should be ported to the next branch as well, so that we can get CI runs on PRs to that branch. (The build is currently broken on that branch, but it will be helpful to see if there's any unintended breakage).

Thanks, that a very good idea. Can you send a PR for "next" as well, even if it might be broken still?

We probably want to just cherry-pick the commit? Will keep the history cleaner.


[F] Generate site maps

Builds sitemap indexes for each community, collection, and item. The sitemap indexes are broken out by pages, with 50 items or collections per sitemap index.

@zdavis This should satisfy the sitemap ask for google scholar. The site is broken down into several smaller sitemap indexes, and each of those either include a further breakdown of collection/item children, or lead to a sitemap with page urls. I can give you a small demo if you'd like


[Bug][5e] Recipe is no longer appearing in list

This looks hard to reproduce since I have only been able to do it on non new worls...
Foundry 12.331
DnD 5e 3.3.1
All of your modules for Dnd5e udated (since today), I saw that you changed Adaption to Adaptation in latests commits (might be it?)

I forgot to add that i normally play in french.

Item migration is an initialisation process to migrate data structure from beavers-crafting 3.x to 4.x.
In this process the Tests where removed from beavers-crafting to system depending files. E.g. beavers-System Adaption dnd5e.
The PopUp tells you that the migration had found a problem.
It tries to migrate recipes it has found with tool Tests e.g. such that needed you to roll a tool to the new ToolTest.
beavers-system-adaption dnd5e will usually register this ToolTest and then it would be available.
The migration error tells me that the ToolTest is not a registered Test.
Maybe I need to check the timeing of my migration script from beavers-crafting to my bsa-dnd5e startUp it might be that for you beavers-crafting got loaded first. This is something i will check and fix.
On the other side some code of my bsa-x implementation might have also thrown a bug for any reason i do not know, on your side and this prevented the registration of the ToolTest. Can you check if you got any other errors when refreshing the page ?

4.0.5 released.
The migration process is now asynchronously and starts with a delay of 10 seconds.
If it breaks it will no longer break the crafting module overall.
If this does not help you then you probably do not have the racing condition issue i assumed you might have or you have a real slow server :-).
When you still get the error message then you probably have some other error that prevents bsa-x to load correctly, look out for them. If there is nothing else and it keeps throwing this error ping me maybe i can try and identify another possible problem.

Hmm, for some reason, all my receipe on the world where you migration was working changed Alchemist Tool to Carpenter Tool(first of the list) after updating to 4.0.5.
It did remove the error on other worlds, so data got migrated, but it reseted the tool test to (choose) instead of what was selected before the migration.

thx for your feedback.
tool migration fixed in v4.0.6 for those who not yet have migrated.


Using keyring on Linux leaves dbus-daemons running, perhaps because godbus connection is not closed

My app does not use "secret-service" backend on Linux, however each execution leaves dbus-daemon running, which eventually leads to OutOfMemory.
godbus.Conn has both Open() and Close(), however keyring does not have a Close() method, so there is no way to request Close() in godbus.Conn. I'm not 100% sure Close() will help, but it seems godbus does a lot of clean up in this method.

Is there any intention to fix this? I can avoid using 99designs/keyring myself, but every time a dependency makes the unfortunate decision to import this package it also becomes harmful and I have to avoid it.

For anyone stuck on this I've made a temporary fork: https://github.com/Jeffail/keyring, here's what the switch looks like (you add a replace directive and it nukes dbus functionality): https://github.com/benthosdev/benthos/commit/7453f87010cfc96d60cf0d484af33f1e0ac59abd


Update Pendragon.html

Corrected some a few niggling issues with spelling on displayed field labels.
Improved the plain-English syntax on some of the chat box "reporting". Example: "{MYNAME} is doing a CHASTE roll becomes "{MYNAME} rolls CHASTE", etc. It's more natural-sounding syntax for English speakers and it's much more compact.
Changed the Chivalry bonus threshold to 96 per Greg Stafford's official errata.
Changed "Directed Traits" subhead to H3.
Change "actif" label next to Chivalry Bonus to "Active?"
Tweaked the label formation to be consistent across tabs. All headers are now all caps, and other labels under them are upper and lowercase to delineate the hierarchy more clearly.
Moved asterisks on Trait labels to after the label to improve alignment of labels.

Hi, Steve
I’m still not seeing the merged file in my sheet. Do I need to do something on my end? Still learning the ropes, here.
Thanks,
M.

On Jan 19, 2015, at 5:54 PM, SteveKoontz<EMAIL_ADDRESS>wrote:
Merged #566 https://github.com/Roll20/roll20-character-sheets/pull/566.
—
Reply to this email directly or view it on GitHub https://github.com/Roll20/roll20-character-sheets/pull/566#event-221308831.

Thanks,
M.


Sparse graph layout on first run of application.

Hi Chris - big thanks to you and your work it's a very cool component you've built.
My minor issue is on the first run of my streamlit application the resultant graph produced has a sparse structure (i.e. nodes are all a great distance from one another) whereas future outputs solve this issue and the graph has the desired shape. The images below show what I'm referring to:
Sparse

Future runs - desired shape

This is on streamlit_agraph version 0.0.35. The configurations which produces are shown below for reference:
    config = Config(width=3000,
                    height=1000,
                    directed=True,
                    nodeHighlightBehavior=True,
                    highlightColor="#F7A7A6", # or "blue"
                    collapsible=False,
                    staticGraph = False,
                    staticGraphWithDragAndDrop=False,
                    )

    return_value = agraph(nodes=nodes,
                        edges=edges,
                        config=config)

Let me know if I can provide any additional information. Its obviously not a huge issue if rerunning the function that outputs the graph solves it but more curious as to why this might be the case. Thanks!

Hi Alex,
that's indeed interesting. I never run into that issue myself.
It might be the case that the gravity is not triggered initially.
What you could try to do is to modify the gravity or trigger an artificial rerun of streamlit.
If this problem hits other people too, I will try to examine it and fix it in future updates.
Thanks for pointing it out.
Best regards
Chris

Could be some gravity related feat actually - it's interesting because on that first run it appears almost as if it's started to pull the nodes together then stops. Good point on the canvas size I'll play around with that as I do have it set to quite a large area currently.
Re the unnecessary parameters: I was experimenting to see if they might have had an effect but I'll remove them if they're not the cause.
Glad you like the graph haha, I think this one below is my favourite thus far:

It's mapping headlines/queries used on Twitter's API search with a focus on the links shared to external sites. The node hierarchy goes like:

Node Class
Colour
Size (1-5, 1 being largest)

Headline/Query
Red
1

Topic Classification
Yellow
2

Domain Name
Light Green
3

URL
Dark Green
4

Datetime of Tweet
Dark Red/Brown
5

Thanks for the reply too, I'll let you know if I work out what was the cause.

Looks awesome! Would be pleased to see you tweeting about it.

I have the same issue.
I think it is some kind of issue with the widget size and the monitor resolution.
On my main  monitor (4k) the layout of the nodes of my app looks good with this config:
config = Config(width=1000,
height=1000,  .....
on my other monitor (1080p) the node layout is screwed.
There I can only fix it by reducing the size of the widget to:
config = Config(width=400,
height=400,  ....
anything larger than that leads to this issue.

Hi,
I am also facing the same issue. Couple of days back i ran the same code in my 14'' laptop screen, it worked and the graph rendered nicely. When I run the same code with a external HD monitor (1920 by 1080), all the nodes appear small and are connected very far away. I tried changing the height and width still the same issue persists.
Looks like the gravity is not getting triggered. Anything to make it artificially triggerred?
Now running the same code in 14" laptop has the same issue.

I cant see the images above, but I assume this is about the graph getting really big in size with long edges? I have the same issue when using it with a higher width and height value (e.g. 1200x700).


Bug with a BYE and possibly ordering or balancing

await manager.create({
    name: 'Example',
    tournamentId: 0,
    type: 'double_elimination',
    seeding: [
        'Team 1', 'Team 2', 'Team 3', 'Team 4',
        null, 'Team 6', 'Team 7', 'Team 8',
        'Team 9', 'Team 10', 'Team 11', 'Team 12',
        'Team 13', 'Team 14', 'Team 15',
    ],
    settings: {
        size: 16,
    },
});

Two BYEs are produced with it:

Actually no, it's not a bug. The second BYE is the result of completing the seeding to a size of 16 with a BYE.
The result I wanted was the 5th seed to be a BYE and the last seed to be a TBD ("to be determined") participant.


.github: Manually update lvh images for test

Images are built by https://github.com/cilium/little-vm-helper-images/pull/731
Fixes: https://github.com/cilium/cilium/pull/35002

/ci-e2e-upgrade

/ci-e2e-upgrade

/ci-e2e-upgrade

/ci-e2e-upgrade

can't locally reproduce the job 14: https://github.com/cilium/cilium/actions/runs/11567607232/job/32200512585 :fearful:

/ci-e2e-upgrade


SPFx in MS Teams with MS Graph API: Token renew failed. Token renewal operation failed due to timeout.

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Web part is able to communicate with MS Graph inside MS Teams.
Observed Behavior
Error - Type : Token Renewal Failed - Description : Token renewal operation failed due to timeout.
The error appears on the first get for any MS Graph endpoint when the web part is hosted in Teams only. It works correctly when hosted in SharePoint.
The weird thing that it's reproduced in browser (chrome, chromium edge, FF), but not in a desktop/Mac app.
I tried different users, private mode, clearing of all browser resources - nothing helps.
I've also tried to revoke all the permissions in SP Admin center and even recreating Azure AD Apps propagated for SPFx.
Steps to Reproduce

Create a simple web part
Add next code:

protected async onInit(): Promise<void> {
    const client = await this.context.msGraphClientFactory.getClient();
    const joinedTeams = await client.api('/me/joinedTeams').version('v1.0').get();

    console.log(joinedTeams);
  }

Can you look at the raw HTTP request to get the token and see what is returned? What error, what raw response, etc?
There's another long-running issue that may be related... #4892...

Hi @andrewconnell,
Yes, it looks similar to the issue you've referenced.
The error is somewhere inside sp-http-adal.js.
And I figured out the reason: the last request of the chain for authentication is GET https://tenant.sharepoint.com/_forms/spfxsinglesignon.aspx.
And this page is cached (the response is 200 OK from disk cache.
As soon as you disable the cache in a browser - it starts working.
For the page itself response for cache control is:
cache-control: public, max-age=82054
So, I think, it must be changed to no-cache.

Digging a bit deeper.
As I mentioned in the beginning - clearing browser cache doesn't help. So, it's interesting as the page is cached...
The reason - authentication flow is called twice.

During the first cycle the page is cached and loaded from the cache for the second cycle.
And I don't see the difference in requests in these 2 cycles so don't have an idea why this is called twice.

See #4892... MSFT working on a fix... appears to be a race condition under the covers. You say this looks like the same thing, so I'm going to mark as a dupe and close. If you think otherwise, we can reopen.

No objections


Controllers specs

Create a Request spec file for all your controllers.
Make sure that for each action you check:

If response status was correct.
If a correct template was rendered.
If the response body includes correct placeholder text.

Hi, @dasileker Thanks for the improvements to my README.md file. I've added the required steps. 😁

Hi @mikemtzp,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

Linters are passing ✅.
PR is well made 👌.

Required Changes ♻
Check the comments under the review.

hello and good work on the Rspec but you forgot to add details in the Getting started  in your readme file section like adding an actual link and adding necessary steps to install gems and run the migration and run the test.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


A typo in README

It seems there is a typo in the following sentence inside README.md:

Events emitted on emitter1 would be also emitter on emitter2, and other way back.

Thank you! Fixed.
Just as a note, you can also easily fix it from scope of your account, by editing a file and creating a PR using Github interface :)


Add cuda implementation of roll_op  #23590

@alextp, I tested my changes for tensorflow 1.12, since our cluster only supports cuda9 right now.

@penpornk @chsigg do either of you have the cycles to review this?

@alextp The soonest I can get to this PR is a few weeks from now. (I'm on vacation this week.)

I'm removing my review request since chsigg@ has already started a review and we also have reedwm@ here.

@chsigg, @alextp hi, it has been a while, how is the review going?

Hi @chsigg, @alextp, I made some further changes to the code, use GpuLaunchKernel and let cuda roll support more data type, can you run the internal checks? Thanks

@chsigg, I am not sure how the failed check (control_flow_ops_test_gpu) relates to my PR, it seems to me that it has nothing to do with my roll_op implementation.

@chsigg, thanks for your review. I was wondering what the current situation is, is @reedwm going review this PR one more time or it will merge soon?

I don't plan on reviewing this, since @chsigg already reviewed it.

@reedwm, thanks for the reply.


Display multiple bars on one line

Hi,
I have slightly different requirements to a standard Gantt chart - but I do wonder if it would be a trivial change to this plugin.
I am capturing states changes of different items. Each item id can only be in a single state at a single time.
My data will look like this:
id, start_ts, end_ts, label
I want to visualize it with each id on a row, with different colours per label.
Is this possible / how hard would it be to mod your plugin (happy to help)?

Oh you can do this!

Yeah, although I'll admit it's more of a happy accident rather than a conscious design choice 😅


Docs for guarantee-operand-order branch

PR for iterating since local docs aren't working

netlify isn't buidling for this branch, perhaps because the base isn't master.  merging into base


fix: vale check

Reverting #470 commited to main - if is failing. See https://github.com/ansys/actions/actions/runs/8833187453/job/24251985324

The PR is not working properly. I reverted the commit and re-opened it. We need to fix the if statement.

Okay - now it works like a charm. Testing performed here: https://github.com/ansys/pyansys-geometry/pull/1168


Extending native integration tests for service runtime [ECR-3011].

Overview
Integration tests for service runtime are extended with fake service and testing utils for artifacts generation.

See: https://jira.bf.local/browse/ECR-3011
Definition of Done

[x] There are no TODOs left in the code
[x] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[x] Method preconditions are checked and documented in the Javadoc of the method
[x] Changelog is updated if needed (in case of notable or breaking changes)
[x] The continuous integration build passes

Coverage remained the same at 86.143% when pulling b4fcf2fd748e35f55fa0b5c94a8569d5e5c1e4a9 on skletsun:extend-native-it-ecr-3011 into 6843b58aeab8323da8302d6788e3412ee2c8c3d8 on exonum:multiple-services.

LGTM except for the issue with load_artifact_twice

Which issue?

You left a comment:

This test is especially susceptible to this issue: https://errorprone.info/bugpattern/TestExceptionChecker

@dip56 Would you please test this on JDK 12? The changes from this PR used to fail in native ITs (when Travis was able to install it).

Will see if ITs will pass on 12 now, when it is back on Travis


bidentate ribonuclease III activity GO:0016443

id: GO:0016443
name: bidentate ribonuclease III activity
namespace: molecular_function
def: "Catalysis of the digestion of double-stranded RNAs into 20 to 30-nucleotide products. These products typically associate to the RNA-induced silencing complex and serve as guide RNAs for posttranslational RNA interference." [PMID:15242644]
synonym: "bidentate RNase III activity" EXACT []
xref: EC:3.1.26.-
is_a: GO:0004525 ! ribonuclease III activity

[x] EC:3.1.26.- should be removed from GO:0016443 since it is a grouping class, and is already correctly an xref on this term:

GO:0016891
name: RNA endonuclease activity, producing 5'-phosphomonoesters
def: "Catalysis of the hydrolysis of ester linkages within ribonucleic acids by creating internal breaks to yield 5'-phosphomonoesters." [GOC:ai]
xref: EC:3.1.26.-

[ ] Alternatively, since GO:0016443 bidentate ribonuclease III activity is the only child of 'ribonuclease III activity' and has only been used in two annotations (to fly Dcr-1 and Dcr-2), I think it could be merged into its parent term:

id: GO:0004525
name: ribonuclease III activity
namespace: molecular_function
def: "Catalysis of the endonucleolytic cleavage of RNA with 5'-phosphomonoesters and 3'-OH termini; makes two staggered cuts in both strands of dsRNA, leaving a 3' overhang of 2 nt." [PMID:11157775, PMID:15242644]
synonym: "pre-mRNA 3'-end processing endonuclease" NARROW []
synonym: "ribonuclease 3 activity" RELATED [EC:<IP_ADDRESS>]
synonym: "RNase III activity" RELATED [EC:<IP_ADDRESS>]
xref: EC:<IP_ADDRESS>
xref: MetaCyc:<IP_ADDRESS>-RXN
is_a: GO:0016891 ! RNA endonuclease activity, producing 5'-phosphomonoesters
is_a: GO:0032296 ! double-stranded RNA-specific ribonuclease activity

Noting that the GO reaction talks about a 2nt overhang "Catalysis of the endonucleolytic cleavage of RNA with 5'-phosphomonoesters and 3'-OH termini; makes two staggered cuts in both strands of dsRNA, leaving a 3' overhang of 2 nt.", not mentioned by EC https://enzyme.expasy.org/EC/<IP_ADDRESS>


Updated compressed bytes test to use rel error

Summary of changes (Bug fix, feature, docs update, ...)**

Updated compressed bytes test to use relative error instead of checking that the compressed bytes exactly equals the expected value.
The number of compressed bytes seems to vary slightly sometimes (possibly due to changes in dependencies).

Please check if the PR fulfills these requirements

[x] Tests added and passed if fixing a bug or adding a new feature
[x] All code checks passing - black --line-length 110 run over code, mypy and flake8 not showing any errors
[x] Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature

Happy to approve once the small comment is addressed above (just typo in the CHANGELOG.md file)


[firebase_analytics]: Error on launchUrl of url_launcher

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Analytics
Which platforms are affected?
Android
Description

Error Missing google_app_id. Firebase Analytics disabled occurs on launchUrlString
Only hostname is related to app affects (Other general URL has no problems)

Same as android.intent.category.DEFAULT and android.intent.category.BROWSABLE

Only Android

Reproducing the issue
Just call launchUrlString with above settings.
Firebase Core version
2.30.1
Flutter Version
3.19.4
Relevant Log Output
Missing google_app_id. Firebase Analytics disabled.

Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.3.2
Flutter SDK 3.19.4
aibattle 1.3.11+185

dependencies:
- app_links 4.0.1 [flutter plugin_platform_interface web flutter_web_plugins gtk]
- app_tracking_transparency 2.0.4 [flutter]
- crypto 3.0.3 [typed_data]
- cupertino_icons 1.0.8
- dio 5.4.3+1 [async http_parser meta path]
- firebase_analytics 10.10.3 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 4.19.3 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.30.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 3.5.3 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 14.9.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_dotenv 5.1.0 [flutter]
- flutter_easyloading 3.0.5 [flutter flutter_spinkit]
- flutter_hooks 0.20.5 [flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_markdown 0.7.1 [flutter markdown meta path]
- flutter_signin_button 2.0.0 [flutter font_awesome_flutter]
- freezed_annotation 2.4.1 [collection json_annotation meta]
- go_router 12.1.3 [collection flutter flutter_web_plugins logging meta]
- google_mobile_ads 5.0.0 [meta flutter webview_flutter_android webview_flutter_wkwebview webview_flutter]
- google_sign_in 6.2.1 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- hooks_riverpod 2.5.1 [collection flutter flutter_hooks flutter_riverpod riverpod state_notifier]
- image_picker 1.1.0 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_linux image_picker_macos image_picker_platform_interface image_picker_windows]
- in_app_review 2.0.9 [flutter in_app_review_platform_interface]
- intl 0.18.1 [clock meta path]
- json_annotation 4.8.1 [meta]
- package_info_plus 8.0.0 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface web win32 clock]
- purchases_flutter 6.30.2 [flutter freezed_annotation json_annotation]
- selectable_autolink_text 2.6.0 [flutter]
- share_plus 9.0.0 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi web win32]
- shared_preferences 2.2.3 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sign_in_with_apple 6.1.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- url_launcher 6.2.6 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 4.4.0 [crypto sprintf meta fixnum]

dev dependencies:
- build_runner 2.4.9 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_lints 3.0.2 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]
- freezed 2.5.2 [analyzer build build_config collection meta source_gen freezed_annotation json_annotation]
- json_serializable 6.7.1 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper]

transitive dependencies:
- _fe_analyzer_shared 67.0.0 [meta]
- _flutterfire_internals 1.3.31 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 6.4.1 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 3.4.10 [crypto path pointycastle]
- args 2.5.0
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.1 [analyzer async convert crypto glob logging meta package_config path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 4.0.1 [built_collection built_value crypto http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.4.2 [analyzer async build collection convert crypto graphs logging package_config path pool pub_semver stream_transform yaml]
- build_runner_core 7.3.0 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta package_config path pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.9.2 [built_collection collection fixnum meta]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- cli_util 0.4.1 [meta path]
- clock 1.1.1
- code_builder 4.10.0 [built_collection built_value collection matcher meta]
- collection 1.18.0
- convert 3.1.1 [typed_data]
- cross_file 0.3.4+1 [meta web]
- dart_style 2.3.6 [analyzer args collection path pub_semver source_span]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.2
- file 7.0.0 [meta path]
- file_selector_linux 0.9.2+1 [cross_file file_selector_platform_interface flutter]
- file_selector_macos 0.9.3+3 [cross_file file_selector_platform_interface flutter]
- file_selector_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- file_selector_windows 0.9.3+1 [cross_file file_selector_platform_interface flutter]
- firebase_analytics_platform_interface 3.10.4 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.7+3 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- firebase_auth_platform_interface 7.2.4 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.11.3 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser meta web]
- firebase_core_platform_interface 5.0.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.16.0 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- firebase_crashlytics_platform_interface 3.6.31 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 4.5.33 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.8.3 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins meta web]
- fixnum 1.1.0
- flutter_plugin_android_lifecycle 2.0.19 [flutter]
- flutter_riverpod 2.5.1 [collection flutter meta riverpod state_notifier]
- flutter_spinkit 5.2.1 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- font_awesome_flutter 9.2.0 [flutter]
- frontend_server_client 4.0.0 [async path]
- glob 2.1.2 [async collection file path string_scanner]
- google_identity_services_web 0.3.1+1 [meta web]
- google_sign_in_android 6.1.23 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.7.6 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.4.5 [flutter plugin_platform_interface]
- google_sign_in_web 0.12.4 [flutter flutter_web_plugins google_identity_services_web google_sign_in_platform_interface http web]
- graphs 2.3.1 [collection]
- gtk 2.1.0 [ffi flutter meta]
- http 1.2.1 [async http_parser meta web]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.1.7 [archive meta xml]
- image_picker_android 0.8.10 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 3.0.4 [flutter flutter_web_plugins image_picker_platform_interface mime web]
- image_picker_ios 0.8.10+1 [flutter image_picker_platform_interface]
- image_picker_linux 0.2.1+1 [file_selector_linux file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_macos 0.2.1+1 [file_selector_macos file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_platform_interface 2.10.0 [cross_file flutter http plugin_platform_interface]
- image_picker_windows 0.2.1+1 [file_selector_platform_interface file_selector_windows flutter image_picker_platform_interface]
- in_app_review_platform_interface 2.0.5 [flutter url_launcher plugin_platform_interface platform]
- io 1.0.4 [meta path string_scanner]
- js 0.7.1
- leak_tracker 10.0.0 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 2.0.1 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 2.0.1 [leak_tracker matcher meta]
- lints 3.0.0
- logging 1.2.0
- markdown 7.2.2 [args meta]
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.8.0 [collection]
- meta 1.11.0
- mime 1.0.5
- package_config 2.1.0 [path]
- package_info_plus_platform_interface 3.0.0 [flutter meta plugin_platform_interface]
- path 1.9.0
- path_provider 2.1.3 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.2.4 [flutter path_provider_platform_interface]
- path_provider_foundation 2.3.2 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.2 [flutter platform plugin_platform_interface]
- path_provider_windows 2.2.1 [ffi flutter path path_provider_platform_interface win32]
- petitparser 6.0.2 [meta]
- platform 3.1.4
- plugin_platform_interface 2.1.8 [meta]
- pointycastle 3.9.0 [collection convert js]
- pool 1.5.1 [async stack_trace]
- pub_semver 2.1.4 [collection meta]
- pubspec_parse 1.2.3 [checked_yaml collection json_annotation pub_semver yaml]
- riverpod 2.5.1 [collection meta stack_trace state_notifier]
- share_plus_platform_interface 4.0.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences_android 2.2.2 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.3.5 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.3.2 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.3.2 [flutter plugin_platform_interface]
- shared_preferences_web 2.3.0 [flutter flutter_web_plugins shared_preferences_platform_interface web]
- shared_preferences_windows 2.3.2 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.4 [shelf stream_channel web_socket_channel]
- sign_in_with_apple_platform_interface 1.1.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 2.1.0 [flutter flutter_web_plugins sign_in_with_apple_platform_interface]
- sky_engine 0.0.99
- source_gen 1.5.0 [analyzer async build dart_style glob path source_span yaml]
- source_helper 1.3.4 [analyzer collection source_gen]
- source_span 1.10.0 [collection path term_glyph]
- sprintf 7.0.0
- stack_trace 1.11.1 [path]
- state_notifier 1.0.0 [meta]
- stream_channel 2.1.2 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.6.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.2 [collection]
- url_launcher_android 6.3.1 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.2.5 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.1.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.1.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.3.2 [flutter plugin_platform_interface]
- url_launcher_web 2.3.1 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.1 [flutter url_launcher_platform_interface]
- vector_math 2.1.4
- vm_service 13.0.0
- watcher 1.1.0 [async path]
- web 0.5.1
- web_socket_channel 2.4.5 [async crypto stream_channel web]
- webview_flutter 4.7.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- webview_flutter_android 3.16.0 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 2.10.0 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 3.13.0 [flutter path webview_flutter_platform_interface]
- win32 5.4.0 [ffi]
- xdg_directories 1.0.4 [meta path]
- xml 6.5.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Additional context and comments
I don't know why but I think firebase_analytics may handle URL launching on same hostname.

Sorry, I don't know why but firebase_analytics not activated on Android currently...


[Jenkins] Added NUnit Test Results/Running Smokes for now

test ci please

@dotnet-bot test ci please

@dotnet-bot test ci please

@mmitche can you please take a look?

LGTM

that's going to fail, if you use cambridge_suite,smoke_only as test profile a directory d:\jenkins\cambridge_suite,smoke_only\ is created, and that fail the build like net40,portable.. because of , in path
you need to sanitize name or map profile name -> appveyor argyments

@otawfik-ms Yeah good point.  Also keep in mind that path length limits on WIndows sometimes cause problems, so keeping them (relatively) short is good.

@dotnet-bot test ci please
@mmitche @enricosada  I see. Thanks for pointing this out.

@enricosada, I'm curious what would be the changes needed in test suite so it can be run from folders containing comma in it? What are the other things which should currently not be in path names?

@dotnet-bot test ci please

@smoothdeveloper
06:11:11   C:\Program Files (x86)\MSBuild\14.0\bin\csc.exe /noconfig /nowarn:0169,0067,1701,1702 /nostdlib+ /errorreport:prompt /warn:4 /define:DEBUG;TRACE;TRACE /highentropyva+ /reference:"d:\j\workspace\Microsoft_visualfsharp\net40,portable7,portable47,portable78,portable259,vs_prtest\Release\net40\bin\FSharp.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\System.dll" /debug+ /debug:pdbonly /optimize+ /out:obj\Release\DefinitionLocationAttribute.dll /ruleset:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Team Tools\Static Analysis Tools\\Rule Sets\MinimumRecommendedRules.ruleset" /subsystemversion:6.00 /target:library /warnaserror+ /utf8output ArtificalEventInfo.cs ArtificialConstructorInfo.cs ArtificialMethodInfo.cs ArtificialParamInfo.cs ArtificialType.cs ArtificialPropertyInfo.cs TypeProviderInCSharp.cs ..\Helpers.cs "C:\Users\dotnet-bot\AppData\Local\Temp\.NETFramework,Version=v4.5.AssemblyAttributes.cs"
06:11:11
CSC : error CS0006: Metadata file 'd:\j\workspace\Microsoft_visualfsharp\net40' could not be found [d:\j\workspace\Microsoft_visualfsharp\net40,portable7,portable47,portable78,portable259,vs_prtest\vsintegration\src\unittests\Resources.MockTypeProviders\DefinitionLocationAttribute\DefinitionLocationAttribute.csproj]

problem is not with test suite, it's the csc compiler.
i think it's trying to split , to use an assembly qualified name as reference, like mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089.

@enricosada thanks, should it be filed as a bug over http://github.com/dotnet/roslyn?
I tried to reproduce by referencing an assembly in a folder containing , but it does build from VS 2015.
C:\Program Files (x86)\MSBuild\14.0\bin\csc.exe /noconfig /nowarn:1701,1702,2008 /nostdlib+ /platform:anycpu32bitpreferred /errorreport:prompt /warn:4 /define:DEBUG;TRACE /errorendlocation /preferreduilang:en-US /highentropyva+ /reference:"C:\tmp\roslyn,bug\ConsoleApplication1\ClassLibrary1\bin\Debug\ClassLibrary1.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\Microsoft.CSharp.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Data.DataSetExtensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Data.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Net.Http.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Xml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Xml.Linq.dll" /debug+ /debug:full /filealign:512 /optimize- /out:obj\Debug\ConsoleApplication1.exe /ruleset:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Team Tools\Static Analysis Tools\\Rule Sets\MinimumRecommendedRules.ruleset" /subsystemversion:6.00 /target:exe /utf8output Program.cs Properties\AssemblyInfo.cs "C:\Users\gauthier.segay\AppData\Local\Temp\.NETFramework,Version=v4.5.2.AssemblyAttributes.cs" obj\Debug\\TemporaryGeneratedFile_E7A71F73-0F8D-4B9B-B56E-8E70B10BC5D3.cs obj\Debug\\TemporaryGeneratedFile_036C0B5B-1481-4323-8D20-8F5ADCB23D92.cs obj\Debug\\TemporaryGeneratedFile_5937a670-0e60-4077-877b-f7221da3dda1.cs

Do you know what else I would need to make a simple reproduce and open upstream bug?

nope, sry, i only read the build log. i think it's a roslyn bug, but dont know how to minimize the repro


Prevent NPE in "Settings" view

Getting an NPE on entering the settings view from the home screen.
Not sure if just blindly avoiding the NPE is the right solution, feel free to take over this PR and implement a more appropriate fix.

@phillipm Hey, definitely representative of a deeper problem so don't want to just blindly avoid this. I'll look into this and PR a different fix. Question though-- did you add null checks in both of the places you did because you explicitly saw crashes in both places? Or were you just being preventative with one of them?

On my device, calls to prefManager.findPreference(PREFS_PRINT_DOC_LOCATION) were returning null. That is why I added the null checks to those 2 parts of the code.
Feel free to either close this PR or it take over.


Cannot create a purely remote Google user account, needs the first authentication to be a local user

Running the latest kanboard release 1.0.23, I created a "remote" user account, with no password, setting the Google account ID to match that person's gmail address. I asked that person to log into the system with google auth with that ID, and it didn't work, saying "remote authentication failed".
To make it work, I had to re-enable local password login for that user, set a temporary password, have that user log into kanboard, go to his user profile/prefs, unlink the external google account and then re-link it. After that was done, Google auth started working correctly.
So maybe there needs to be some sort of real auth initiation handshake going on for the first time, when the user has not successfully logged into kanboard with Google before?

This is now supported by the plugin (only in the dev branch): https://github.com/kanboard/plugin-google-auth#automatic-account-creation

Your approach is per-domain (assuming one is using Google Apps Enterprise). What about the whitelist approach I was describing, where you type in the email address of the google account you specifically want to whitelist for automatic creation?

Can you describe with an example what you suggest here https://github.com/kanboard/plugin-google-auth/issues
The approach implemented at the moment is a whitelist based on the email domain name.
Thanks


feat: add support httpOptions for fetch

Hey :wave:
We use the gatsby-source-prismic plugin, it doesn't work inside our CI because there is no support  for Agent inside (a PR is coming).
While I was reading the source I found this one doesn't support agent anymore (v5 does).
cf https://nodejs.org/api/https.html#https_class_https_agent we need this to be able to use the plugin as we have a proxy inside our runner.

Hey @dhoko, thanks for the PR!
You're correct; the upcoming v6 version of @prismicio/client does not support an HTTP Agent like v5. Instead, it allows you to provide a custom fetch function which can perform any modification necessary, including using an Agent.
You can see an example of overriding the fetch function here: https://github.com/prismicio/prismic-javascript/blob/f618d626aa74272b7c5a4f4da51c808e30617741/examples/custom-caching/index.js
More specific to your case, this is the most basic example of a custom fetcher:
import * as prismic from "@prismicio/client";
import fetch from "node-fetch";

const client = prismic.createClient(endpoint, {
	fetch: async (url, options) => {
		// You can adjust options here including adding an agent.
		// Modifying the URL can also happen here if necessary.
		return await fetch(url, options)
	},
});

gatsby-source-prismic, which uses @prismicio/client v6 internally, does not provide a way to override the fetch function. We will need to add a fetch plugin option that is passed to @prismicio/client (currently is defaults to node-fetch without any options).
I will respond to your PR there (https://github.com/prismicio/gatsby/pull/424).
I'm going to close this PR as the library already supports a way to use an HTTP Agent, but please feel free to continue the conversation if there is something we haven't considered.


loggerFromContext(): Anonymize the addresses, cryptopan?

No one knows what this means (was just a TODO comment in the code), will re-open if it becomes clear.


Add .editorconfig

From Cesium: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/.editorconfig
Here and also to the 3d-tiles-tools and obj2gltf repos.

@pjcozzi May I help to fix this issue with a PR? I want to ask if anybody 're working on this? I suppose to create a .editorconfig file and add below lines to this file
`# http://editorconfig.org
root = true
[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
[*.md]
trim_trailing_whitespace = false`
What do you think? This is my first open source contribution ever so sorry if there are mistakes

@hoatran1403 that does look good but we already have a PR open for this: https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/234. If that one doesn't see any updates soon you may be able to submit a PR as well.

@hoatran1403 are you still interested in fixing this issue? #234 was closed so feel free to open a new PR.

Thanks @lilleyse. I'm going to submit a PR for this.


General Release

Description
Fixes # issues with husky hook and documentation
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


change the wordking from '給它` to '采用'

'給它` is like google translate,
采用 sounds smoother.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


[Bug]: SQL checks containing delimiters will report an error

ODC version
ODC 4.2.3
OB version

What happened?

No error will be reported when checking the sql statement of the delimiter alone, but an error will be reported when checking together with pl.
What did you expect to happen?
Checking it together with pl will not report an error.
How can we reproduce it (as minimally and precisely as possible)?
delimiter //;
create function fun_loop (p1 int) returns int(11) begin
declare v1 int;
set v1 = 0;
loop1:LOOP
IF v1 > 10 THEN
LEAVE loop1;
END IF;
set v1 = v1 + p1;
END LOOP;
return v1;
end;
Anything else we need to know?
No response
Cloud
No response

this is not caused by sql-check, you can reproduce this issue by sqls as follow

as you can see, any delimiter longer than 2 will cause this problem.

pass