Resource health 2021 01 01 pre

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[x] update existing version for new feature

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
FEB
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
JAN
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run

@liusu-coder can you provide more details about the API review, this seems to be a resource capturing data across all Azure Services, how is authorization going to be handled? Or is this API going to query IcMs?

@liusu-coder can you provide more details about the API review, this seems to be a resource capturing data across all Azure Services, how is authorization going to be handled? Or is this API going to query IcMs?

this api is not specific to certain subscrption, rather it is a Tenant level public api. the api will query the data in our cosmosdb and those data ultimately will be from our partner team BRAIN through service to service authentication. let me know if it answers your question.

@liusu-coder can you provide more details about the API review, this seems to be a resource capturing data across all Azure Services, how is authorization going to be handled? Or is this API going to query IcMs?

this api is not specific to certain subscrption, rather it is a Tenant level public api. the api will query the data in our cosmosdb and those data ultimately will be from our partner team BRAIN through service to service authentication. let me know if it answers your question.

Added questions and comments. Please take a look.

Added questions and comments. Please take a look.

Most most of the previous comments have been addressed. I added a couple more. (The main one is my question on opaque identifiers.)

Most most of the previous comments have been addressed. I added a couple more. (The main one is my question on opaque identifiers.)

Thanks, @Jorge<EMAIL_ADDRESS>for your comment. I added readOnly to each properties to address ambiguity here.
From: Jorge Cotillo<EMAIL_ADDRESS>Sent: Wednesday, January 13, 2021 2:18 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Liu Su<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Resource health 2021 01 01 pre (#12206)
@jorgecotillo commented on this pull request.

In specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2021-01-01/ResourceHealth.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F12206%23discussion_r556769218&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668627281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hVUJkbUPJitsyGFAvDdouU8niLykOcYKBY2Rg8Eu1qg%3D&reserved=0:

@@ -1164,6 +1236,173 @@

     }

   }

 },

"potentialOutagesGetResult": {

 "description": "The Get PotentialOutages operation response.",

 "type": "object",

 "$ref": "#/definitions/potentialoutage",

 "readOnly": true

@filizthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffilizt&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668627281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7lPLJM8GCCvFTvdT7EQyCMnuTylEMt5FdsTFeUVM4c4%3D&reserved=0 found an example and it seems that readOnly is not inherited, your only option is to add readOnly to every single property. Modeling a property as readOnly indicates the SDK generation to expose a public getter but a private setter, otherwise both are going to be publics, this is ok if you are reusing your definition in a PUT and GET

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F12206%23discussion_r556769218&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668637271|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8sEIMr0zQlZ5WonhjmkGxpwK4GGVqtLLssZ08NrIU1g%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASELRLI57PMGQ6PUB7RLFQ3SZXWVRANCNFSM4VFW4VQQ&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668637271|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2FIZZebOccmSHWfjkQzaICVsh5BZzosEiBpKmAIHOIu8%3D&reserved=0.

Thanks, @Jorge<EMAIL_ADDRESS>for your comment. I added readOnly to each properties to address ambiguity here.
From: Jorge Cotillo<EMAIL_ADDRESS>Sent: Wednesday, January 13, 2021 2:18 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Liu Su<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Resource health 2021 01 01 pre (#12206)
@jorgecotillo commented on this pull request.

In specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2021-01-01/ResourceHealth.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F12206%23discussion_r556769218&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668627281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=hVUJkbUPJitsyGFAvDdouU8niLykOcYKBY2Rg8Eu1qg%3D&reserved=0:

@@ -1164,6 +1236,173 @@

     }

   }

 },

"potentialOutagesGetResult": {

 "description": "The Get PotentialOutages operation response.",

 "type": "object",

 "$ref": "#/definitions/potentialoutage",

 "readOnly": true

@filizthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffilizt&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668627281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=7lPLJM8GCCvFTvdT7EQyCMnuTylEMt5FdsTFeUVM4c4%3D&reserved=0 found an example and it seems that readOnly is not inherited, your only option is to add readOnly to every single property. Modeling a property as readOnly indicates the SDK generation to expose a public getter but a private setter, otherwise both are going to be publics, this is ok if you are reusing your definition in a PUT and GET

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F12206%23discussion_r556769218&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668637271|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8sEIMr0zQlZ5WonhjmkGxpwK4GGVqtLLssZ08NrIU1g%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASELRLI57PMGQ6PUB7RLFQ3SZXWVRANCNFSM4VFW4VQQ&data=04|01|Liu.Su%40microsoft.com|6c21d19843c544bde57308d8b7f7e7c0|72f988bf86f141af91ab2d7cd011db47|1|0|637461622668637271|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2FIZZebOccmSHWfjkQzaICVsh5BZzosEiBpKmAIHOIu8%3D&reserved=0.

Signed off

Signed off

Signed off

Thanks a lot!

Signed off

Thanks a lot!


I placed a basic dropzone down, nothing happened

I am trying the upload a file, direct to S3. I setup Rails Active Storage for that. I bundled in the latest code for this gem.
I dropped a Dropzone down. Can't drop files on it, or upload with the button? Seems dead. What am I missing? Am I supposed to wire up the button clicks and drag drop code manually? In other words, do I have to make some controller that gets loaded to work with this component?
<%= polaris_card(sectioned: true) do %>
    <%# With direct upload in ActiveStorage %>
    <%= form_with(model: @shop, builder: Polaris::FormBuilder) do |form| %>
      <%= form.polaris_dropzone :svg, accept: 'image/svg+xml', error_overlay_text: 'File type must be .svg', multiple: false,direct_upload: true %>
    <% end %>
  <% end %>

Probably the update JS package is missing. Do you use it with importmaps or esbuild?

I am not sure what you mean by the update JS package? Can you give me some idea of what that would mean? How would I know? My package.json is pretty clean so far..
{
  "name": "shopify-hotwire-sample",
  "private": true,
  "scripts": {
    "build": "esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds",
    "build:css": "tailwindcss -i ./app/assets/stylesheets/application.tailwind.css -o ./app/assets/builds/application.css"
  },
  "dependencies": {
    "@hotwired/stimulus": "^3.0.1",
    "@hotwired/turbo-rails": "^7.0.1",
<EMAIL_ADDRESS>"^0.0.6",
    "@shopify/app-bridge-utils": "^2.0.5",
    "autoprefixer": "^10.4.0",
    "dotenv": "^10.0.0",
    "dropzone": "^6.0.0-beta.2",
    "esbuild": "^0.13.10",
    "polaris-view-components": "^0.7.0",
    "postcss": "^8.4.4",
    "tailwindcss": "^3.0.1"
  },
  "version": "0.1.0",
  "devDependencies": {}
}

So I am getting an application.js as far as I know, from /assets/builds and the manifest.
`

Since the Polaris code from the server defined the controller "polaris-dropzone", and some actions, as per Stimulus, I added a polaris_dropzone_controller.js file to the controllers in the App, and registered that... and then I saw that that hooked up the uploader.
So I guess that my duh moment, and that I have to write the controllers themselves for these Polaris View Components? I was under the impression that they came with their own JS controllers... my bad.
Is that in fact what we have to do, or is there a pattern in play where we not only get the luxury of throwing down components, but they come with their own JS controllers? If so, how do we leverage that?

You need to install an npm package from Github in order to use unreleased changes (like new Dropzone controller). You can do it via:
yarn add https://github.com/baoagency/polaris_view_components

You'll also need to install build-time dependency so esbuild could resolve dependencies properly:
yarn add @popperjs/core

Once v0.8.0 will be released you can switch back to npm package.

Ha! I have no idea what that means. I suppose the first thing, telling yarn to use the github, is more specific. OK. Let's say it is. What do I gain from this version? Does that preclude me having to build my own dropzone controller?
As for popperJS? Not sure what that even is, but I will add it, and see what happens!
Thanks!

Interesting, now I get a JS compilation error
node_modules/polaris-view-components/app/assets/javascripts/polaris_view_components/frame_controller.js:2:30: error: Could not resolve "stimulus-use" (mark it as external to exclude it from the bundle)
11:40:14 js.1   |     2 │ import { useTransition } from "stimulus-use"

So I naively did a yarn add stimulus-use, which really busted everything, as then stimulus itself failed in every include asking for it. So I stopped that, instead I added an --external:stimulus-use to esbuild, but that quieted down the build, leaving an error in the console saying Dynamic require of stimulus-use is not supported. Sigh..
And the 404 still happens on the map, and I still need my own JS controller for the Dropzone... as far as I can tell...
So I am anxious to know, what was the point of loading the latest JS and popper again?

Ha! I have no idea what that means. I suppose the first thing, telling yarn to use the github, is more specific. OK. Let's say it is. What do I gain from this version? Does that preclude me having to build my own dropzone controller?
As for popperJS? Not sure what that even is, but I will add it, and see what happens!
Thanks!

It will use the latest version from GitHub. PopperJS is used for popovers and autocomplete.

Interesting, now I get a JS compilation error
node_modules/polaris-view-components/app/assets/javascripts/polaris_view_components/frame_controller.js:2:30: error: Could not resolve "stimulus-use" (mark it as external to exclude it from the bundle)
11:40:14 js.1   |     2 │ import { useTransition } from "stimulus-use"

Okay. Run this to resolve the error:
yarn add stimulus-use@beta

OK.. that is cleaner. No choking on stimulus-use.
So now my only burning question is... my polaris-dropzone-controller.js code. I have to write and wire up everything for that? I thought in inspecting this repo, you had written it all up.. but apparently, if you did, using it is another thing.

This is so strange. So I had made my own controller. And the connect() logged ME. My controller. But then I updated the code. And when I noticed your code for the controller for the dropzone, I pasted it into my controller. But I noticed, nothing was triggering in my controller anymore. Hmmm.. I guess that means the one you wrote is now the boss!!
So I remove my controller. And sure enough, the file selector worked, and I could browse for an SVG file. Of course, the controller did nothing with the file.. but I am sure that fixable soon enough.
So that seems to answer my burning question. If I throw down a Polaris View Component in Ruby ERB, there is JS that goes with it, auto-provided.
How one overrides that, or hooks into it, is the next task for me I guess.

I added my S3 credentials to amazon: key in storage.yml for production. I left local as DIsk and the directory "storage". I then added @rails/activestorage, and in the manifest, the //= require activestorage.
At this point, I was hoping to see some action! But nothing. No files move.  I sure will be happy when I get this working!

The input element generated looks pretty good. Does not actually direct_upload like I want it to, but it is close!

I placed a bunch of logging in the dropzone controller js. So I get the click on the button, and it pulls up a file dialog, where I can pick a file, and it matches the accepts checking... One thing that does not happen though, is none of the direct-upload events fire. So, in a direct upload case, the selected file just sits... neat! I did not know I could just edit the node_modules code and get it live in my browser. Wowza..

Interesting. I stripped it down in the polaris view comonents to the file_field tag. It does not generate the needed token or attachment name when direct_upload is true. I am guessing that somehow the underlying file_file generator is not up to snuff. I updated the polaris view components I am using to feed off of Rails 7.0.1 but even that failed to improve the render of this crucial element with the correct parameters. Not sure where to turn now...

So, it seems like the Rails core team made some mistakes, and the advice for Rails 7 is to monkeypatch things back to the old way of doing things, as this new pattern is an itty bitty disaster. So I will follow that directive, betting all will suddenly start working!

Ok. So with the revert back to Rails 6 Directo Uploads, apparently still even that does not work well (who knew), the upload worked, with a file uploaded to the storage disk! Such progress!
It pooped out though when Rails blew chunks saying No Route to POST /home.
I have zero clues as to how a direct upload in this world could finish uploading a file, and then try and POST to /home, but whatever.. I am sure there is an explanation for that somewhere.

Stuff that currently makes no sense to me.

upload data information exists, in active_storage_blobs. a row dedicated to the file uploaded and info about it
active_atorage_attachments and active_storage_variant_records remain blank

So now a file was uploaded, for a shop, and there is nothing connecting that file to the shop. Also, if the file took a long time to upload, and once it is uploaded, we need to run a job to work on the file, there is no apparent trigger we have to do this?
In the old ways, I would use CarrierWave, and if I added a method to run after the upload completed, in there I could run a job with the name of the shop, and the file.
How do people use this Rails ActiveStorage to achieve that? Nothing I have read so far informs me of these simple things. So much is not obvious with Rails.

Ok. So I added a column to shop, just simple "fizzbuzz" as a string. Used that fizzbbuzz as the directive to file_field on the Dropzone. Added a POST route to the /home, and saw the params. Neat. fizzbuzz was there. So I attached the upload sent, and wow. Now the attachments table has it, the blob is stored, and I know the store.
So now I can call up that file and do the work on it in a background job. Using an obnoxious but workable: Rails.application.routes.url_helpers.rails_blob_path(shop.fizzbuzz, only_path: true)
The post finished saving the attachment and I just redirected back to /home. Not stellar. But it all worked.
So I guess I am now OK somewhat with Dropzone! I will next get it working with S3 and see how much pain that causes me.

The issue with direct upload has been fixed in one of the latest Rails 7 releases. Tested it in my apps and it works fine with Dropzone now.

That was an amazing bit of bumbling that the Rails 7 release team put us all through. They remain dismissive of any use cases beyond what they currently express, with no empathy for people that may want to store files in a system like S3 with any kind of organization other than "Put this in that bucket". So interesting. I rarely interact with the Rails crowd, but it is so true that they are opinionated.


Added Code of Conduct & other minor things

Hey all. I made most of the changes that were suggested months ago. Sorry for dragging my feet on this!
I also updated a link to the CoC on the About page, as well as some other minor capitalization & word changes to the About page.

We have Travis CI?

So, the Travis CI failures are:

[ ] Link to COC doesn't exist (which makes sense because presumably this PR will create it)
[ ] Link to emails doesn't exist?
[ ] Ada Initiative their certificate has expired (change link to http?)
[ ] Marked.js not found. #36.

I submitted a pull request with the Travis setup last night. Makes it easier to see if a pull request builds without having to pull and check it locally.
If you don't use the full domain name with internal links it will fix that issue with linking to new content (like the coc)
You can check the tests locally by running rake test so you can check if these things are fixed before pushing them up. You'll probably need to run bundle install first to get all the dependencies.

@GarthDB awesome, thanks for doing that.

The email links should be fine if you use mailto: in front of them in the href.

That just leaves the marked.js file.

@simonv3 oops. Spaced on that. Fixed the email addresses. Yes, the link to the CoC is in the pull request... weird that Travis CI doesn't take that into account. I actually just moved the entire /slideshows directory to it's own repo as we should try to keep the main repo reasonably sized- just shrunk it from 15 -> 12MB with this change. Personally, I think leaving the Ada as https is fine- they'll prolly renew their cert and all will good!
@GarthDB thanks a lot for adding CI stuffs. That's rad!

Travis doesn't know about the domain name or where the page is going to be. It just builds the Jekyll site locally and checks the links.
—
Sent from Mailbox
On Sun, Nov 22, 2015 at 9:51 AM, Simon<EMAIL_ADDRESS>wrote:

Merged #38.
Reply to this email directly or view it on GitHub:
https://github.com/opensourcedesign/opensourcedesign.github.io/pull/38#event-471520967


Fix android KVS implementation to work across threads

Problem
KVS may be used within different threads and JEnv are thread-specific.
Summary of Changes
Ensure KVS uses a thread-appropriate jenv.

@msandstedt @mspang @saurabhst ?


Test::Mojo::json_is does not work correctly with the $desc in Unicode

Mojolicious version: 5.54
Perl version: 5.20.2
Operating system: Debian 8.5 (x86_64)

Steps to reproduce the behavior
use ut8;
use open qw(:std :utf8);

my $t = Test::Mojo->new('MyApp');

$t  -> get_ok('foo')
    -> json_is('/xxx' => 'yyy', 'Комментарий');

Output
    ok 1 - GET http://localhost:36491/test/foo
    ok 2 - ÐÐ¾Ð¼Ð¼ÐµÐ½ÑÐ°ÑÐ¸Ð¹

Expected behavior
    ok 1 - GET http://localhost:36491/test/foo
    ok 2 - 'Комментарий'

Actual behavior
Breaks description of the test, if it is in Unicode.
The reason is that the 'json_is' always makes 'encode' for the parametr '$desc'. And it breaks the output if used use open qw(:std :utf8);
sub json_is {
  my $self = shift;
  my ($p, $data) = @_ > 1 ? (shift, shift) : ('', shift);
  my $desc = encode 'UTF-8', shift || qq{exact match for JSON Pointer "$p"}; # <<<==========
  return $self->_test('is_deeply', $self->tx->res->json($p), $data, $desc);
}

In similar functions done differently, and there is no problem. For example, json_like:
sub json_like {
  my ($self, $p, $regex, $desc) = @_;
  $desc ||= encode 'UTF-8', qq{similar match for JSON Pointer "$p"}; # <<<========

How to handle Unicode output on STDERR and STDOUT in Mojolicious has been an open question for years now. So far it seemed like the safes choice not to mess with Perl defaults, therefore our expectation is that you don't do either. Of course we are open to proposals for changing this, but they would have to take the whole framework into account.

Also, please feel free to discuss this on IRC, a few of the many problems with possible proposals have already been brought up there today.

It is just that the implementation of the 'json_is' did not differ from the rest 'json_ | content_' etc. It seems enough:
sub json_is {
  my $self = shift;
  my ($p, $data) = @_ > 1 ? (shift, shift) : ('', shift);
  # my $desc = encode 'UTF-8', shift || qq{exact match for JSON Pointer "$p"};
  my $desc = shift;
  $desc ||= encode 'UTF-8', qq{exact match for JSON Pointer "$p"};

P.S. I read IRC channel, but I do not know much English for interactive communication)

I see what you mean, and i'm afraid you won't like my solution, which is to make all tests behave consistently. https://github.com/kraih/mojo/commit/8fdf806ff56520bd79dfe0fe8fc24315918bfd37

Hi again!
One more attempt.
In the new Mojo broke description for tests (to be expected). If you remove use open (':std'), we have a lot of warnings, if you remove use utf8, we have a broken regexp.
Why even touch the user comment of the test? Doing forced encode, we do not leave the choice to the user.
I think that encoding user's strings to utf8 is bad practice.
The following test demonstrates the problem:
#!/usr/bin/perl

use warnings;
use strict;
use utf8;
use open qw(:std :utf8);

use Test::More tests    => 6;

BEGIN {
    require_ok 'Mojolicious';
    use_ok 'Test::Mojo';
}

{
    package TstApp;
    use Mojo::Base 'Mojolicious';

    sub startup {
        my ($self) = @_;

        $self->routes
            -> get('/ping')
            -> to(cb => sub { return shift->render(text => 'pong') })
            -> name('ping');
    }
}

package main;

my $t = Test::Mojo->new('TstApp');

note 'тесты mojo';
$t  -> get_ok('/ping')
    -> status_is(200)
    -> content_is('pong', 'Запрос выполнен успешно');

note 'другие тесты';
my $str_from_somewhere = 'Привет, медвед';

like $str_from_somewhere => qr{\w,\s\w}, 'Еще тест прошел';

Old Mojo looks fine (5.54):
1..6
ok 1 - require Mojolicious;
ok 2 - use Test::Mojo;
# тесты mojo
ok 3 - GET /ping
ok 4 - 200 OK
ok 5 - Запрос выполнен успешно
# другие тесты
ok 6 - Еще тест прошел

current  mojo breaks descriptions:
1..6
ok 1 - require Mojolicious;
ok 2 - use Test::Mojo;
# тесты mojo
ok 3 - GET /ping
ok 4 - 200 OK
ok 5 - ÐÐ°Ð¿ÑÐ¾Ñ Ð²ÑÐ¿Ð¾Ð»Ð½ÐµÐ½ ÑÑÐ¿ÐµÑÐ½Ð¾
# другие тесты
ok 6 - Еще тест прошел

commmenting use open :std have warnings:
1..6
ok 1 - require Mojolicious;
ok 2 - use Test::Mojo;
Wide character in print at /usr/share/perl/5.20/Test/Builder.pm line 1821, <DATA> line 2125.
# тесты mojo
ok 3 - GET /ping
ok 4 - 200 OK
Wide character in print at /usr/share/perl/5.20/Test/Builder.pm line 1821, <DATA> line 2125.
ok 5 - Запрос выполнен успешно
Wide character in print at /usr/share/perl/5.20/Test/Builder.pm line 1821, <DATA> line 2125.
# другие тесты
Wide character in print at /usr/share/perl/5.20/Test/Builder.pm line 1821, <DATA> line 2125.
ok 6 - Еще тест прошел

commenting use utf8 breaks regexps tests:
1..6
ok 1 - require Mojolicious;
ok 2 - use Test::Mojo;
# тесты mojo
ok 3 - GET /ping
ok 4 - 200 OK
ok 5 - Запрос выполнен успешно
# другие тесты
not ok 6 - Еще тест прошел
#   Failed test 'Еще тест прошел'
#   at test.t line 44.
#                   'Привет, медвед'
#     doesn't match '(?^:\w,\s\w)'
# Looks like you failed 1 test of 6.

So. I think that Test::Mojo shouldn't use encode for user's descriptions (like Test::More - it doesn't use encode. And the other library modules)
Regards.


graph is now ref'd by name instead of the type instance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

19 of 19 (100.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 95.018%

Files with Coverage Reduction
New Missed Lines
%

spock/graph.py
1
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1621

Relevant Lines:
1706

💛  - Coveralls


[Outlook] (delegate) Remove preview tag from on-premises support

Docs Build status updates of commit 858cdb2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/outlook/delegate-access.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Import the user stories into the board

After looking at the rubric from the previous year, I think that they want us to number the stories. In fact, we might have to number more than just that, it just seems unclear to me right now.

Once a story is assigned as an issue, it will be given an number corresponding to that issue. Can we just use that as the "story number" as well, or does it have to be somewhere more concrete, like the wiki?

I think we might need to be using the number that they placed by the user story. Here is an example from the previous group that they gave us.

My current guess is that it could correspond to the story size of the given user story? Definately somehting we should bring up to the TA next meeting.

#31

Closing issue for now. All stories have been added to the project board along with details and story points


Explore ways to not query for every feature

https://github.com/Esri/cluster-layer-js/blob/master/src/clusterfeaturelayer.js#L470-L483
                if (uncached.length > this._returnLimit) {
                    while(uncached.length) {
                        // Improve performance by just passing list of IDs
                        this._query.objectIds = uncached.splice(0, this._returnLimit - 1);
                        queries.push(this.queryTask.execute(this._query));
                    }
                    all(queries).then(lang.hitch(this, function(res) {
                        var features = arrayUtils.map(res, function(r) {
                            return r.features;
                        });
                        this._onFeaturesReturned({
                            features: merge(features)
                        });
                    }));

really puts the rage on an arcgis server that has more than a good demos worth of features. I sort of figured that returnLimit would act on a feature layer's virtual grid instead of doing snap shot style spin up a query task to download every feature - In our case being 15mb's gzipped. Should this cluster layer inherit from FeatureLayer to get access to the virtual grid instead of graphics layer?
In the future there is going to have to be server side point clustering to handle these scenarios. Are you in the loop enough to know if that is on the right peoples radar?

Yip, I'm in the loop. I will let you know if this is on the radar.

I have taken this project and turned it into something that expects 1 compressed json file of the [id's, x, y], and lazy queries for attributes and what not when requested. It is working well so far for 200K points. We came to the conclusion that for point clustering to be honest, we needed to cluster every point. Making n number of requests at the max result count was too many requests. One large cacheable file seemed like the best tradeoff.

Maybe a hardLimit property that would limit queries in each pass? With tons of points like wouldn't even a virtual grid chew up the requests? I like your solution @steveoh. It wouldn't be too difficult to set the layer up so that if it was provided the data, not to make the HTTP requests.

I'm open to branching this and experimenting for sure. I also like the idea of experimenting with server-side clustering. The backend or some nodejs middleware component could probably crank this out a lot faster than delivering 1000's of points to client.

SOI's could work but they might be too slow.


Add publisher examples

https://trello.com/c/R46p9TMH/366-docs-publisher-examples-for-publishing-api
Publisher examples for different content formats for both content and links where applicable.

I don't think the links ones are right: they should literally just have the links hash.

As discussed, the links hash isn't valid on its own, I'll look for a way to validate the /v2 links payload separate from the content payload.

@danielroseman are you happy with this?

Steve and I have been working on this today, more changes coming.


Katie create card

This needs some adjusting for small/med screens
Browser metadata
Path:      /
Browser:   Chrome 91.0.4472.77 on Mac OS 10.15.7
Viewport:  1680 x 838 @2x
Language:  en-US
Cookies:   Enabled

View on BrowserStack

Open Deploy Preview · Mark as Resolved

This needs some adjusting for small/med screens
Browser metadata
Open Deploy Preview · Mark as Resolved

I was going to open different PRs for mobile views
@asasmith

@asasmith where are we with this review?

This needs some adjusting for small/med screens
Browser metadata
Open Deploy Preview · Mark as Resolved

I was going to open different PRs for mobile views
@asasmith

@kcbreuil let's incorporate responsive styling during the initial dev process. Otherwise I worry we'll end up with a lot of cleanup tasks later on. There's also the potential to have to rework a components structure because you might find that how you've built it for large screens won't work for smaller screens.


feat: sms sending with twilio

Description
This pull request adds a new API endpoint POST /api/v1/sms/send for sending SMS messages via the Twilio API. The endpoint accepts a JSON payload containing a phone number and message content, validates the input, and sends an SMS using Twilio. It returns appropriate success or error responses based on the outcome of the SMS sending operation.
Related Issue
Link to the related issue
Motivation and Context
This feature allows users to send SMS messages through our application using the Twilio API. It is required for enabling communication functionality within the application.
How Has This Been Tested?
I have tested this feature using Postman. The tests cover various scenarios, including valid and invalid inputs, and error handling. All tests have passed successfully. To run the test
python -m pytest tests/v1/test_sms_twilio.py
Screenshots

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x]  New feature (non-breaking change which adds functionality)
[ ]  Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x]  My code follows the code style of this project.
[ ]  My change requires a change to the documentation.
[ ]  I have updated the documentation accordingly.
[ ]  I have read the CONTRIBUTING document.
[x]  I have added tests to cover my changes.
[x]  All new and existing tests passed.

Tests are failing
@joboy-dev  on it

Fix merge conflict


Implementing list a customer and fixing pylint errors

Implemented list customer route
Added list customer test cases in test_model.py and test_routes.py
Added serialize and deserialize test cases to test_model.py to improve test coverage to 80%
Fixed pylint errors

Thanks for fixing the pylint errors. The changes look fine to me.


ADD: MRR data testing examples

I am adding test MRR2 data for the xradar MRR2 reader.

@rcjackson Would it work to add the data gzipped? We can easily use fixtures to extract it in the test suite.

I've fixed the registry to include all of the files and gzipped the MRR2 data.

I'm not sure if we should make a restructure for the README.md.

@mgrover1 The list in the readme becomes longer and longer. It's not easy to see what kind of data is provided. Maybe we should make subsections for the different radar file formats? What do others think?
I think this should be done in a separate PR.

I think we should add some dynamic documentation here, which could be tracked in a separate issue


Reactions Returning Null

General Troubleshooting
Hey there! Before you report a bug or suggest a new feature,
please make sure to follow these steps first!

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming features/bug fixes.

This is not the place to learn Java. Please refer to StackOverflow
for your general programming questions.

Issue
Issue Type

[ ] Bug Report
[ ] Feature Request
[x] Intended behavior

For questions join the official JDA discord server: https://discord.gg/0hMr4ce0tIl3SLv5

Description
I am trying to read back the reactions from a private message.
Here is my code:
@Override
	public void onPrivateMessageReactionAdd(PrivateMessageReactionAddEvent event) {
		String messageId = event.getMessageId();
		System.out.println("Rated: " + event.getChannel().getMessageById(messageId).complete().getReactions().get(0).toString());

		// TODO Auto-generated method stub

	}

Which for some reason outputs:
Rated: MR:(M:(473811443716980738) / RE:?(null))
Any help?

This means that the reaction is a unicode emoji, which does not have an id. Because no id is present the toString() representation just replaces it with null. This is intended behavior.

Even using
System.out.println("Rated: " + event.getChannel().getMessageById(messageId).complete().getReactions().get(0).getReactionEmote().getName());
returns null as well. Is there any ways I can simply determine between which emote what pressed? This is all I need.

The github issue tracker is reserved for feature requests and bug reports. Your issue is neither and should be sorted out inside of our discord server. Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.

I recommend to use event.getReactionEmote().getName() instead, which should not be null. Your console however might not support unicode which is why it could print ? instead.

I apologize for using the Issue tracker. I never thought thats why it would be printing a ?! It makes so much sense now! Thank you so much!


Files imported from F5 tests are loaded twice on Windows (once via 'C:', once via 'c:')

Issue Type: Bug
NOTE: This did not repro in 1.26.1
This is causing issues because I end up with multiple versions of module variables.

Clone this repo: https://github.com/microsoft/vscode-docker
npm I
open in vscode
open extensionVariables.ts
Add the following lines to the top of the line:

console.error('ext loaded');
// tslint:disable-next-line:no-debugger
debugger;

set launch configuration to 'Launch Tests' and press F5
!) the breakpoint is hit twice
!) If you let the test continue, it fails with "Extension not activated", which is a direct result of having two different version of 'extensionVariables.ts' loaded.

If you check the callstack from Module._compile on the breakpoint, you'll see that
First call:
id starts with "C:" (this is the path given to Mocha by the testrunner using glob

Second call:
id starts  with "c:"
Therefore the cached version is not returned.

For a work around, if you pass the paths in your launch.json explicitly as absolute paths, and lower case the drive letter, you'll be able to execute the tests.

Surprisingly, that doesn't work:
		"outFiles": [
			"C:/Repos/vscode-docker/out/**/*.js" //"${workspaceRoot}/out/**/*.js"
		],

-> C: ended up as c:, so tried to load "c:/Repos/vscode-docker..."

As I mentioned; lower case the drive letter in your launch.json; that's unblocked me.

You're right, I misinterpreted which way to convert.  That'll work as a temporary work-around, thanks.

I think this problem is breaking all sorts of things on Windows:
https://github.com/Microsoft/vscode/issues/58815
https://github.com/Microsoft/vscode/issues/58388
I have some other failing tests too which I hadn't raised issues about, but putting absolute paths with lowercase drive letters into launch.json fixes them. However I can't do this on my CI builds easily.

Setting env.CODE_TESTS_PATH and env.CODE_TESTS_WORKSPACE to have lowercase drive letters in my test script appears to solve the issue on AppVeyor too.

Ok, after some analysis it seems the issue is that the extensionDevelopmentPath, extensionTestsPath or outFiles are now comparing paths differently.
Did you change something in this area recently @bpasero @roblourens @weinand
We have not changed anything in how we handle source files in debug land which would break this.
@StephenWeatherford following your steps I get a weird error. Are there some other prerequests that I should setup for this to work

@DanTup your test from the other issue fail for me both on mac and windows. Shouldn't it work on mac?

I'm not aware of "outFiles" changed in node-debug or node-debug2.
But the extensionDevelopmentPath now supports URIs (thanks to @aeschli).

@isidorn you should talk to @aeschli and @sandy081. quite possible that something changed when moving from fsPath to URI or for remote scenarios.

I'd hope that the outcome of the move towards URIs is that URI comparisons are more lenient...

@DanTup your test from the other issue fail for me both on mac and windows. Shouldn't it work on mac?

Which test do you mean? I forced the drive letter to lowercase in my test script (see https://github.com/Dart-Code/Dart-Code/commit/11a6f5e54709944bf2b1e619d4f7c0bd9860e591) and a bunch of my Windows issues linked here went away. What was the error you saw?

@isidorn No, no other requirements.  The tests won't fully pass without docker installed, but you should be able to get far enough to verify the problem (just tried this on my home machine without docker).  Can you not open the test\test.code-workspace workspace in vscode?

@DanTup I mean following your steps from here https://github.com/Microsoft/vscode/issues/58815#issue-360871239
@StephenWeatherford I can repro now following your stpes, the breakpoint gets hit wtice but both times I see capital C.
Anyways let's wait for @aeschli and @sandy081 to comment

FYI, when I did my original investigation if I remember correctly I believe the earlier vscode ended up with paths where the casing matched, whereas with the newer vscode they didn't.  I.e., I'm not sure that the comparison logic changed, but rather that the path casings being passed in to load module changed (the ones brought in by Mocha and the ones brought in by vscode).

@isidorn

I mean following your steps from here #58815 (comment)

So you cloned that repro and ran the test on macOS but it failed? You didn't get the same result as my screenshot in that comment? 🤔
I can't explain that - it passes here on macOS, fails on Windows, but if I change {workspaceFolder} to a full FS path on Windows it will a) pass if the drive letter is lowercase and b) fail if the drive letter is uppercase.
Note: I'm testing with Stable, as Insiders seems broken (fails at startup complaining about merge-conflict extension not being found?).

Weirdly, I have another machine where I am seeing this same issue from the command line (i.e. not F5), which runs tests like this (non-insiders 1.27.2):
"scripts": {
"test": "npm run build && cross-env CODE_TESTS_WORKSPACE=./test/test.code-workspace DEBUGTELEMETRY=1 node ./node_modules/vscode/bin/test"
}
I don't know what the difference between the two machines is.  On the other one, npm test from command line always succeeds.

@StephenWeatherford
Given you have a relative path, may it depend on the casing of the drive letter in the current working directory when that command is executed? If you added pwd before that command and ran it on each machine, what does the path look like?

Machine where it succeeds: C:\Repos\vscode-docker
Machine where it fails: C:\Users<username(lowercase)>\Repos\vscode-docker
So how is this supposed to work?  I'm assuming the module loading code of treating files including drive names as case-sensitive is the desired behavior and shouldn't be changed, right?
Again, I'm pretty sure this was a change in behavior between vscode 1.26.1 and 1.27.x. I'm willing to go back to 1.26.1 to verify.

@isidorn @bpasero we must fix this: the drive letter casing should not affect the path matching in VS Code. We need a way to avoid opening files twice if the drive letter case differs. This is not rocket science!

The issue with showing multiple sources with different casing is already fixed via a commit I pusehd 7 days ago which stores sources independent on casing unless on linux
The reason why tests were failing in this issue is that with the URI refactoring the extensionDevelopmentPath would be upper cased. Which @aeschli and me fixed via cec1733b008bdf0e18a3517108cba49246bb0779
@StephenWeatherford I have followed your steps and now all is good for me
As for comparing uris in workbench and case sensitivity here's the issue tracking that https://github.com/Microsoft/vscode/issues/12448

Sorry for the delay in responding, I've been OOO. I've testd both my simple logging sample from above and also #57513 and the issue is resolved for me, it's behaving as it used to 👍

@DanTup thanks for letting us know.

Works for me, too.  Thanks!


Can the code run on a CPU-only device?

Can the code run on a CPU-only device? I am getting an error when running python visualize.py on a CPU-only device.

I guess so.
May be you can load the model by:
pretrain = torch.load(opt.pretrain_path, map_location=lambda storage, loc: storage)

Thank you for your reply. I have tried this load method before but it still can't run normally.And I got the following tips:
raceback (most recent call last):
File "/home/user/python_project/Python学习2/Facial-Expression-Recognition/visualize.py", line 51, in
net.cuda()
File "/home/user/anaconda3/envs/pytorch-python2.7/lib/python2.7/site-packages/torch/nn/modules/module.py", line 258, in cuda
return self._apply(lambda t: t.cuda(device))
File "/home/user/anaconda3/envs/pytorch-python2.7/lib/python2.7/site-packages/torch/nn/modules/module.py", line 185, in _apply
module._apply(fn)
File "/home/user/anaconda3/envs/pytorch-python2.7/lib/python2.7/site-packages/torch/nn/modules/module.py", line 185, in _apply
module._apply(fn)
File "/home/user/anaconda3/envs/pytorch-python2.7/lib/python2.7/site-packages/torch/nn/modules/module.py", line 191, in _apply
param.data = fn(param.data)
File "/home/user/anaconda3/envs/pytorch-python2.7/lib/python2.7/site-packages/torch/nn/modules/module.py", line 258, in
return self._apply(lambda t: t.cuda(device))
RuntimeError: Cannot initialize CUDA without ATen_cuda library. PyTorch splits its backend into two shared libraries: a CPU library and a CUDA library; this error has occurred because you are trying to use some CUDA functionality, but the CUDA library has not been loaded by the dynamic linker for some reason.  The CUDA library MUST be loaded, EVEN IF you don't directly use any symbols from the CUDA library! One common culprit is a lack of -Wl,--no-as-needed in your link arguments; many dynamic linkers will delete dynamic library dependencies if you don't depend on any of their symbols.  You can check if this has occurred by using ldd on your binary to see if there is a dependency on *_cuda.so library.

Thank you for your advice, my problem has been solved.After commenting out the code with .cuda( ), I can run successfully on a CPU-only device.

Thank you for your advice, my problem has been solved.After commenting out the code with .cuda( ), I can run successfully on a CPU-only device.

could you tell me how do you realize it specifically?

just comment out the code with .cuda( ) in visualize.py,such as:
net = VGG('VGG19')
checkpoint = torch.load(os.path.join('FER2013_VGG19', 'PrivateTest_model.t7'), map_location=lambda storage, loc: storage)
net.load_state_dict(checkpoint['net'])
net.cuda()
net.eval()

Just comment out the code with .cuda( ) in viusalize.py file,such as:
net = VGG('VGG19')
checkpoint = torch.load(os.path.join('FER2013_VGG19', 'PrivateTest_model.t7'))
net.load_state_dict(checkpoint['net'])
net.cuda()
net.eval()


Make name on user optional

Or remove it completely. The bare minimum of information needed on the user should be email and password.

We need to look at how JWTKeychain handles profile information and auth credentials. We talked about different approaches and decided not to include this for the first major release. Some ideas to consider when picking this up again:

Having profile information separate from auth credentials. Adds a lot of flexibility and might open up for dealing with other types of authentication (e.g. by LinkedIn token etc)
Subclassing a user model
Using protocols to be able to customize the user model

Feel free to add if I missed anything @rasmusebbesen @BrettRToomey @siemensikkema


feat(select): select can filter by multiple fields not just 1

Select Filter can now filter by more than one field,
If filterBy prop is not used, will filter by the optionLabel

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:
Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Will be adding a new feature on select to this PR


operator keeps updating status even if there is no change

Currently we use DeepEqual to check if local status and status in TPR is equal:
	if reflect.DeepEqual(c.cluster.Status, c.status) {
		return nil
	}

However, this seems not worked. The comparison always returns false. It will cause resource version of TPR keep bumping.

For evidence, here's the printed json of TPR status and local status:
{"phase":"Running","reason":"","controlPaused":false,"conditions":[{"type":"ScalingUp","reason":"Current cluster size: 0, desired cluster size: 1","transitionTime":"2017-03-16T22:56:28.106069511Z"},{"type":"Ready","reason":"","transitionTime":"2017-03-16T22:56:36.161758172Z"}],"size":1,"members":{"ready":["example-etcd-cluster-0000"]},"currentVersion":"3.1.2","targetVersion":""}
---
{"phase":"Running","reason":"","controlPaused":false,"conditions":[{"type":"ScalingUp","reason":"Current cluster size: 0, desired cluster size: 1","transitionTime":"2017-03-16T22:56:28.106069511Z"},{"type":"Ready","reason":"","transitionTime":"2017-03-16T22:56:36.161758172Z"}],"size":1,"members":{"ready":["example-etcd-cluster-0000"]},"currentVersion":"3.1.2","targetVersion":""}

More comparison:
"%#v\n%#v", c.cluster.Status, c.status

spec.ClusterStatus{Phase:"Running", Reason:"", ControlPaused:false, Conditions:[]spec.ClusterCondition{spec.ClusterCondition{Type:"ScalingUp", Reason:"Current cluster size: 0, desired cluster size: 1", TransitionTime:time.Time{sec:63625303369, nsec:32672488, loc:(*time.Location)(0x2158c00)}}, spec.ClusterCondition{Type:"Ready", Reason:"", TransitionTime:time.Time{sec:63625303377, nsec:92824251, loc:(*time.Location)(0x2158c00)}}}, Size:1, Members:spec.MembersStatus{Ready:[]string{"example-etcd-cluster-0000"}, Unready:[]string(nil)}, CurrentVersion:"3.1.2", TargetVersion:"", BackupServiceStatus:(*spec.BackupServiceStatus)(nil)}
spec.ClusterStatus{Phase:"Running", Reason:"", ControlPaused:false, Conditions:[]spec.ClusterCondition{spec.ClusterCondition{Type:"ScalingUp", Reason:"Current cluster size: 0, desired cluster size: 1", TransitionTime:time.Time{sec:63625303369, nsec:32672488, loc:(*time.Location)(0x2164ae0)}}, spec.ClusterCondition{Type:"Ready", Reason:"", TransitionTime:time.Time{sec:63625303377, nsec:92824251, loc:(*time.Location)(0x2164ae0)}}}, Size:1, Members:spec.MembersStatus{Ready:[]string{"example-etcd-cluster-0000"}, Unready:[]string(nil)}, CurrentVersion:"3.1.2", TargetVersion:"", BackupServiceStatus:(*spec.BackupServiceStatus)(nil)}

What are these fields supposed to represent?
loc:(*time.Location)(0x2158c00) and loc:(*time.Location)(0x2164ae0)
Are they considered by reflect.DeepEqual? Since they are unequal.

That's the problem. Location is a func.

See https://github.com/golang/go/issues/10089#issuecomment-77463157


Forgotten symbol in samples.json?

For the second block of test009_expired_token.bc, samples.json says there should be a symbol expiration: https://github.com/biscuit-auth/biscuit/blob/ef72348c4b6c0906829433fadf4df2573db000f4/samples/current/samples.json#L439 but since that symbol doesn't occur in the code for the block, I think it has to be a symbol left over from a previous version of that sample, or something along those lines?

oh, good catch!
It is not a leftover from a previous version of the sample, rather to a small quirk in the encoding of checks' bodies in the biscuit-rust library. They are modeled as rules internally, and expiration is used as the predicate name for the rule head. But this rule head is not actually used, so it does not make sense to waste space on this name.
There is a little bootstrapping issue here, since the canonical way of defining checks in rust code is to use macros, but they are not available from the library itself (they are feature-gated). The check_expiration_date builds the check manually, but in a way that's a bit different from what's done in the macros / parser.

see https://github.com/biscuit-auth/biscuit-rust/blob/main/biscuit-auth/src/token/builder.rs#L2278


Sell function is creating listing with an INACTIVE status

Hello,
I've been having some trouble with the sell function ( https://docs.rarible.org/reference/order/ ), all my listings are being created with an INACTIVE status right after the creation.
Here is the function call:
async createSellOrder(     privateKey,     tokenId,     price,     amount,     assetType,     tokenAddress,     feesValue,     payoutsValue   ) {     const sellResponse = await this.sdk(privateKey).order.sell({       itemId: toItemId(${this.BLOCKCHAIN}:${tokenAddress}:${tokenId}),       price,       amount,       currency: assetType,       originFees: [         {           account: toUnionAddress(${this.BLOCKCHAIN}:${tokenAddress}),           value: feesValue,         },       ],       payouts: [         {           account: toUnionAddress(ETHEREUM:${tokenAddress}),           value: payoutsValue,         },       ],       expirationDate: new Date(Date.now() + 60 * 60 * 1000),     });     return sellResponse;   }
The parameters:
{     "tokenAddress": "0x9125b7bd068c021e9dc706dcebe1b0069dfa78f0",     "tokenId": "12",     "price": "0.0341",     "amount": 1,     "assetType": { "@type": "ETH" },     "feesValue": 250,     "payoutsValue": 10000 }
and the url with all status inactives:
https://testnet-api.rarible.org/v0.1/orders/sell/byItem?itemId=ETHEREUM:0x9125b7bd068c021e9dc706dcebe1b0069dfa78f0:12
Tried looking for some question similar here, but nothing and in the discord no one is replying :(.

In case anyone one day ends up here, I was using the wrong onwer


Create a New Repo

We would like to create a second repository for the private data objects lab. The second repository would include contracts and applications that build on the pdo infrastructure.
We would like the repository to be https://github.com/hyperledger-labs/pdo-contracts.
The original proposal for PDO is here: https://github.com/hyperledger-labs/hyperledger-labs.github.io/blob/main/labs/private-data-objects.md.
PDO has been successful in influencing several other hyperledger projects (Avalon, Fabric Private Chaincode).

here you go! Please add a MAINTAINERS.md file


[Search] Update changelog

Include multi cloud support in changelog for 11.4.0-beta.9 release.

API change check
API changes are not detected in this pull request.

Do we plan to do any testing for multi-cloud support? The last I checked ensys supported multi cloud pipeline testing.

Do we plan to do any testing for multi-cloud support? The last I checked ensys supported multi cloud pipeline testing.

@pallavit - We run weekly tests on multi-cloud just like other SDKs(Text Analytics, Form Recognizer, KeyVault..etc). For weekly runs, we have added the configuration here and the pipeline is running here.


Switching tab cause fold issues

Issue Type: Bug
first i try to type some code. Switch tabs to another file, then switch back to previous file. all my code became folded. its annoying. please help
VS Code version: Code 1.67.1 (da15b6fd3ef856477bf6f4fb29ba1b7af717770d, 2022-05-06T12:37:03.389Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.84GB (5.26GB free)

Process Argv
D:\Project\WanganDorifto -g D:\Project\WanganDorifto\Assets\_Scripts\Core\GameManager.cs:1:0

Screen Reader
no

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

beardedicons
Bea
0.18.0

vscode-author-generator
edw
0.2.2

prettier-vscode
esb
9.5.0

font-switcher
eva
4.0.3

copilot
Git
1.20.5902

gitkraken-authentication
git
1.0.3

discord-vscode
icr
5.8.0

unity-code-snippets
kle
1.3.0

csharp
ms-
1.24.4

vsliveshare
ms-
1.0.5561

vsliveshare-audio
ms-
0.1.91

vsliveshare-pack
ms-
0.4.0

unity-logcat
sim
0.0.3

vscode-smoothtype
spi
1.2.0

author-tag
toj
1.0.2

unity-debug
Uni
3.0.2

vscodeintellicode
Vis
1.2.21

(9 theme extensions excluded)

Please use the Start Extension Bisect command to investigate whether the issue is being caused by one of your extensions.

Reproducible steps are needed to find out more:

the inputs of the files
which sections are folded
where do you click

Closing due to lack of additional information


Bevy 0.12

I saw #62 for bevy 0.11 support, and it looks like bevy 0.12 was released a couple of weeks ago. I'm starting a new project where I'll lock into a certain version of bevy.
Given the last release in May covered bevy 0.10, should I leverage bevy 0.11 or bevy 0.12 in anticipation for the next release of this crate? I'm brand new, so I don't (and shouldn't) have much weight in the decision here. Just want to know if there are plans/expectations for one version over the other! 😄
I'd toss this into a discussion instead of an issue, but looks like discussions aren't enabled for this repository. So apologies if this clutters the issue section!

Hey and welcome!
I am anticipating 2 releases very soon, same feature set, 2 latest bevy versions, hopefully within a week or two.
Hope that helps :)

It does! Thank you for the lightning fast response 😄 Going to close this out since you've answered my question!


ANSI characters appearing after setting the title

Windows Terminal version (or Windows build number)
Microsoft Windows [Version 10.0.19042.985]
Other Software
'git' (2.31.1.windows.1) from scoop and using that as the Bash provider
'aws' (2.2.5) AWS CLI that this is having problems with
Steps to reproduce
When I do
aws logs tail --follow --region us-west-2 --since 0s my-cloudwatch-logs

I see the colors correctly, but when I set the title as follows
echo -ne "\033]0;☁ my-cloudwatch-logs \a" && aws logs tail --follow --region us-west-2 --since 0s my-cloudwatch-logs

The colors stop working and I see the ANSI escape codes.
This used to work before I reinstalled Windows
Expected Behavior
Colors should appear and not ANSI codes.  Title should get set.
Actual Behavior
ANSI Codes are appearing.  Title is getting set.

Also, does
echo -ne "\033]0;my-cloudwatch-logs \a" && aws logs tail --follow --region us-west-2 --since 0s my-cloudwatch-logs

work as expected?

direct has color

No color when setting the title

Definitely another case of VT processing being disabled, though I don't know why this wouldn't work when preceeded by an echo. We've got a pile of these elsewhere on the repo, but this one seems different. I don't have any idea why the echo in the same commandline would disable this.
I wonder if
printf "\033]0;☁ my-cloudwatch-logs \a" && aws logs tail --follow --region us-west-2 --since 0s my-cloudwatch-logs

would work instead?

@zadjii-msft yup I was actually hesitant on creating another one, but this is a very weird and specific scenario.

so this sounds like something that must have recently regressed in msys, between whatever version you had before you reinstalled windows and whatever's currently installed. Maybe this should get moved upstream?

It's actually the same version.  But I had a fresh install of Windows so I am not sure.

Hypothesis confirmed

oh woah, this actually looks exactly like #9607, with a touch of #6634

@zadjii-msft the difference betweem #9607 and this is that aws actually processes the data now.  But my comment in #6634 which points to https://github.com/starship/starship/pull/2258#issuecomment-771943572 actually gave me the workaround I need
Basically I have to close off the stdin
(echo -ne "\033]0;☁ title  \a" < /dev/null)

Closing this for now since I have a workaround and it appears to be an upstream msys/cygwin issue


Update the Smack My Dolphin Up! app for the SDK version 1.0 f7

Hello!
Your Smack My Dolphin Up app version 1.0 fails to build with the SDK version 1.0.0-rc f7. Please update the app in your repository and create a new pull request to the catalog repository with the updated manifest file.

IMPORTANT: Don’t forget to update the app version and commit version in the manifest file.

View logs
View build actions
Flipper Team

I am again here!
Your Smack My Dolphin Up app version 1.0 fails to build with the SDK version 1.0.1-rc f7. Please update the app in your repository and create a new pull request to the catalog repository with the updated manifest file.

IMPORTANT: Don’t forget to update the app version and commit version in the manifest file.

View logs
View build actions
Flipper Team


feat(avif): added AVIF decoder

This PR adds a dependency-free, WebAssembly-powered decoder for AVIF-encoded images, supporting browsers, web workers and Node.js runtimes.
Under the hood, dav1d is used as codec for the libavif library.
Currently only 8-bit encoded AVIF images are being decoded reliably. Encoding is not yet possible, due to build errors, when using the rav1e codec es encoder.

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:


K/D stat is missing

In some games where there are kills and deaths as well as wins and loses, it should also show the k/d and w/l (win / lose) rates.
The API doesn't provide them though, as it is easy to calculate them with the client

Implemented in  f494332caddd7c3f347bf2e06d5fb653f12df3b9


[Question] Chapter markings in MP4 (from Youtube)

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
Is there a possibility to have chapter markings saved from youtube videos? When I'm watching videos on Youtube, I always am curious how to save the segmented markings (which are chapters?) offline directly into the mp4 file.
Technically, MP4 should be able to do this (with the help of fmpeg): https://medium.com/@dathanbennett/adding-chapters-to-an-mp4-file-using-ffmpeg-5e43df269687
Is this already implemented, and if so, how do I do it?
Example video is https://www.youtube.com/watch?v=8ktY12GiO18

--add-metadata

Since you havent responded, I assume this worked?


Company Page - Contract View - Per Project / Auto Billing - Tax Setting auto complete design Change

Problem -

User want to see Total Tax Percentage in Tax Autocomplete in Per project and Auto Billing Tax Selection Autocomplete

Solution

Show Tax percentage along with Name

Design

if Tax is 9% cgst and 9% sgst then => GST (18%)
show Total Tax Percentage
if tax is 10% with 150 Rs amount => GST (10% + 150)

initiated by @vinpahilwani
verified by @mitulpanch

API changes are also required to do this

yes

This value is not for search, Search will be for Name only


Certain buttons are off screen on common laptop resolutions

Fix
Start in Fullscreen by default
Workaround
Full screen button
Examples

Search an Area of Interest > Search for a Geographic Location > Location Results
Cannot click the "Display" button

NAPL Search > Results > Order checkbox > Order Options - Aerial Photos
Cannot click "Update Cart" button:

Default fullscreen mode at 1920 x 1200 resolution now results in desirable results for the above examples:

(Display button is still cut off, but clickable for now. Will consider a more permanant follow on solution)


Update README

I fixed a few typos in README file:

Inversion of #import decomposer and #import dictionary
HanziDecomposer methods were called on hanzi instead of decomposer

Thanks @alxdrdelaporte !


Feat product factory

This PR refactor the way product are create to use a factory pattern similar to Map and Timeseries in sunpy

Codecov Report
Base: 67.15% // Head: 62.44% // Decreases project coverage by -4.71% :warning:

Coverage data is based on head (274b7cd) compared to base (671bcda).
Patch coverage: 60.30% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   67.15%   62.44%   -4.71%
==========================================
  Files          10       17       +7
  Lines         816     1241     +425
==========================================
+ Hits          548      775     +227
- Misses        268      466     +198

Impacted Files
Coverage Δ

stixpy/products/science.py
51.54% <51.54%> (ø)

stixpy/products/housekeeping.py
70.00% <70.00%> (ø)

stixpy/products/quicklook.py
70.83% <70.83%> (ø)

stixpy/products/product_factory.py
72.34% <72.34%> (ø)

stixpy/products/product.py
73.91% <73.91%> (ø)

stixpy/products/__init__.py
100.00% <100.00%> (ø)

stixpy/science.py
77.77% <100.00%> (+23.97%)
:arrow_up:

stixpy/vis/map_reprojection.py
46.93% <0.00%> (-17.35%)
:arrow_down:

stixpy/timeseries/quicklook.py
47.33% <0.00%> (-13.15%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[TE2-v1.2] Scenes Cluster's Explicit, TableSize, FabricScenes features implementation is missing

Reproduction steps / Feature

Scenes Cluster's Explicit, TableSize, FabricScenes features are mandatory in the specifications
But it's implementation is missing in the SDK

Platform
core (please add to version below)
Platform Version(s)
v1.2
Type
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response

@PSONALl Is this a duplicate of #28217 ?

Closing this issue as it is a duplicate!!

@PSONALl Please include the original issue in the results of the test case(s) that failed


OnExpand style css bug :  line column, expand column don't expand like body content

Hi
There is a bug on line, expand, checkbox columns when i use onExpand event on masterbranch
It seems css are not update like the body, which expand correctly.

There is a work around.
inside the onExpand event, do some css changes to adjust height.
var heightIwant = 60;

$('#grid_gridName_frec_'+ event.recid +'_expanded').css({ margin: '0px', padding: '0px', width: '100%', height: heightIwant + 'px' });

In the example http://w2ui.com/web/demos/#!grid/grid-7 it explains that you need to set width, as it is unknown before you expand.

@karjac14 thx i will try it
I know, the problem is on what @karjac14 said, content expand but not $('#grid_gridName_frec_'+ event.recid +'_expanded')


master PR

Thanks for submitting a pull request! Maybe @olehermanse can review this?

sure @cf-bottom , but this is still a work-in-progress PR

I'm not sure I understand, @Lex-2008.

it works!

Thanks for a very throughful revie, @vpodzime!

@vpodzime and @oleorhagen : I think all requested review changes were implemented in a follow-up commits. Do you want me to fixup them to proper parent commits before approving this PR?

commits squashed, review status reset by forced push. Please approve again!


Failure to import pytest

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:
Version: 1.95.1 (user setup)
Commit: 65edc4939843c90c34d61f4ce11704f09d3e5cb6
Date: 2024-10-31T05:14:54.222Z
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26100

Steps to Reproduce:

Install Python 3.13.0 and Pytest 8.3.3
Create a python file in VS Code, e.g. pytest_test.py
Type code: import pytest
compile and run

Result:
Error message; "ModuleNotFoundError: No module named 'pytest'"
Note:
I can run pytest and the Python file with "import pytest" in shell/bash via "pytest pytest_test.py" and "python pytest_test.py" without issue.

/extPython


Load Nested gridstacks programmatically

I saw that the changes for issue #53 enable the support of nested stacks.
My question would be how to add child widgets programmatically to the parent item  ? Can it be done using the current code, or are some changes required ? I tried using the add_widget method but the whole stack behaves as a single item.
I am trying to load the grid from the localstorage from a previous save.

Interesting question. My guess is that we should be able to add widgets and group them, and gridStack should be able to make those group nested widgets...
var grid = $('#myGrid').grid(options).data('gridstack');

grid.add_widget(el, 0, 0, 1, 1, true, 'group_1')

Any updates on this? I would love to be able to add a nested widget.

@davidwieler - your JSFiddle "Result" viewport is falling below gridstack's collapse-to-mobile min_width threshold (768 pixels), so the grid is reverting to single-column mode. (See GridStack.prototype._is_one_column_mode() at line 600 of gridstack.js.)

I thought that too, but I honestly believe the problem is that the only way (so far) to nest a grid is to add a new "grid-stack" element, then run the function again.
Simply adding a "grid-stack-item", or appending one, doesn't work.

Anybody have any progress on this?
I tried to accomplish this by adding a widget with inside the widget:
`

 test

`
then do:
$('.sub').each(function(i,el){ 	grid.makeWidget(el);	 /})
but thats not working.. have a few other ideas to see if those work

Hi, this is how far I got:
http://codepen.io/bravebox/pen/QdEEBd/
Im making a dashboard similar to the example above. I managed to create a nested gridstack with js.
I make custom selectors for all just to try it out. But the nested items are not placed / do not drag/drop correctly. There seems to be a space above the first item which I can't find anywhere...

Putting this hear in case anyone needs it, adding nested widgets
https://codepen.io/michaellwatson/pen/EvGEgM

bummer, as I'm gonna need to nest grids sometimes soon, and dynamically... didn't look past the nested demo yet.

working fine in current build - see #1106 nested.html


feat: Setup packaging and Github Codespaces dev environment

Overview
This PR restructured the package and add Github codespaces coding environment.
Issues Addressed

#1
#15

I also closed issue #15 with this PR

This PR has been updated to close the following Issues:

https://github.com/uw-ssec/caustics/issues/24
https://github.com/uw-ssec/caustics/issues/17
https://github.com/uw-ssec/caustics/issues/16
https://github.com/uw-ssec/caustics/issues/15
https://github.com/uw-ssec/caustics/issues/10
https://github.com/uw-ssec/caustics/issues/9
https://github.com/uw-ssec/caustics/issues/8
https://github.com/uw-ssec/caustics/issues/7
https://github.com/uw-ssec/caustics/issues/4
https://github.com/uw-ssec/caustics/issues/3
https://github.com/uw-ssec/caustics/issues/2
https://github.com/uw-ssec/caustics/issues/1


Authenticatior refactored.

Codecov Report

Merging #40 (7c77655) into master (21710ab) will increase coverage by 0.54%.
The diff coverage is 67.44%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   82.22%   82.76%   +0.54%
==========================================
  Files           6        6
  Lines         315      325      +10
==========================================
+ Hits          259      269      +10
  Misses         46       46
  Partials       10       10

Impacted Files
Coverage Δ

services/authenticator.go
80.95% <67.44%> (+2.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21710ab...7c77655. Read the comment docs.


Integer ops do not correctly bitcast

SPIR-V allows certain opcodes to be of "unexpected" types, e.g. adds where one argument is signed and the other is not. This should be fixed so that SPIRV-Cross emits bitcast opcodes where needed to ensure that the output GLSL is valid and correct.
This is mostly a problem with operations like ivec4(bvec4), ++ operator, etc where a SPIR-V compiler emits magic snippets of code. ++ operator was already handled, but we need to expand this to all opcodes.
To verify implementation, a test setup for SPIR-V assembly will be needed as well.
Progress is tracked in integer-bitcast-ops branch.

Merged.


Nested table inside model inherits parent table's styles

While migrating from V4 to V5, the nested table now inherits the table-hover style of the parent table, and applies the hover-color to all cells of the nested table. This didn't happen in V4.

      Button
      Two
      Three
      Four

        <button type="button" class="btn btn-outline-primary" data-bs-toggle="modal" data-bs-target="#modal">
        Open Modal
        </button>

                        Item 1
                        Item 2
                        Item 3

                        11
                        22
                        33

                        11
                        22
                        33

                        11
                        22
                        33

      2
      3
      4

The following hot-fix solves the problem:
.table {
  --bs-table-accent-bg: transparent;
}

Note: The color "transparent" might vary from you setup.
A more permantly fix could be to add this to _tables.scss:
.table {
--#{$variable-prefix}table-accent-bg: #{$table-bg};
}

PR is not merged yet, please keep this issue open for now :)


Reason-React example fails to compile if run through refmt.

Within the reason-react-example, code fails compilation when passed through refmt.
Steps to repro

Open up project in VS code with reason-language-server extension and format on save enabled
Open Greeting.re
Start the project in terminal with yarn start
Save Greeting.re
Observe syntax changes and the following error from the terminal

1/2] Building src/interop/Greeting.mlast
File "/Users/marcel/projects/lab/genType/examples/reason-react-example/src/interop/Greeting.re", line 40, characters 32-39:
Error: Syntax error: Labels are not allowed inside a tuple not expected.

  We've found a bug for you!
  /Users/marcel/projects/lab/genType/examples/reason-react-example/src/interop/Greeting.re

  There's been an error running Reason's refmt parser on a file.
  This was the command:

  /Users/marcel/projects/lab/genType/examples/reason-react-example/node_modules/bs-platform/lib/refmt.exe --print binary '/Users/marcel/projects/lab/genType/examples/reason-react-example/src/interop/Greeting.re' > /var/folders/kt/_xgpkvhs5l957cd3gb_qxmsm0000gn/T/ocamlppb29e42

  Please file an issue on github.com/facebook/reason. Thanks!

ninja: error: rebuilding 'build.ninja': subcommand failed
>>>> Finish compiling(exit: 1)

Refmt made the following changes to Greeting.re
[@genType]
-let make = (~message, ~someNumber, ~extraGreeting=?, ~polymorphicProp, _children) => {
+let make =
+    (~message, ~someNumber, ~extraGreeting=?, ~polymorphicProp, _children) => {
   ...component,
   render: _self => {
     Js.log2("polymorphicProp:", polymorphicProp);
@@ -14,8 +15,8 @@ let make = (~message, ~someNumber, ~extraGreeting=?, ~polymorphicProp, _children
       | Some(g) => g
       };
     <div>
-      <MyBannerRe show=true message=(message ++ " " ++ greeting) />
-      (ReasonReact.string("someNumber:" ++ string_of_int(someNumber)))
+      <MyBannerRe show=true message={message ++ " " ++ greeting} />
+      {ReasonReact.string("someNumber:" ++ string_of_int(someNumber))}
     </div>;
   },
 };
@@ -36,7 +37,7 @@ let concat = String.concat;
 let testNamedArgs = (~a, ~b, x, ~c, ~d, y, ~e) => a + b + x + c + d + y + e;

 [@genType]
-let testCallNamedArgs = (foo: ((~a: int, ~b: int) => int), a, b) =>
+let testCallNamedArgs = (foo: (~a: int, ~b: int) => int, a, b) =>
   foo(~a, ~b);

Disabling refmt on save prevents this, but is not ideal.

Indeed: https://github.com/facebook/reason/issues/2141

Ah ha! OK, I will close this issue as it's out of scope of this project.

But it's a good point. This is going to be confusing for new people trying the project. I'll work around that so that the refmt bug is not exposed.

The bug is now fully fixed in Reason master, make take a bit of time for the actually release though...

What commit is it? I can cherrypick it for bsb-native release and update it if really needed.

@bsansouci no worries I've worked around it ( https://github.com/cristianoc/genType/commit/a52f2e866df8d4ae91be2b9432b49f551d0819f3 ) so there's no hurry.


Mongoose is fetching empty array from MongoDB

Suddenly my mongoose app stopped working as CosmosBD (MongoDB) is returning an empty array. It started happening from today only.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59571387-86d7-72d7-2c96-6a8e75ee8b1e
Version Independent ID: d24f0ef2-188f-5603-915e-0a69c2d9b17a
Content: Connect a Node.js Mongoose application to Azure Cosmos DB
Content Source: articles/cosmos-db/mongodb-mongoose.md
Service: cosmos-db
Sub-service: cosmosdb-mongo
GitHub Login: @timsander1
Microsoft Alias: tisande

@ankitoye Thanks for the feedback! We will review and update accordingly.

Sorry, it's was user error. This can be closed.

@ankitoye Thanks for closing this. Please let us know if you face any other issue and we can discuss on the same.


Python minimal version is wrong in FAQ / 3.0.1 changelog not published

FAQ Claims compatibility with python 3.6 : https://wtforms.readthedocs.io/en/3.0.x/faq/#what-versions-of-python-are-supported
Changelog does not exists for 3.0.1 : https://wtforms.readthedocs.io/en/3.0.x/changes/#version-3-0-0

Perhaps because https://github.com/wtforms/wtforms/blob/master/src/wtforms/init.py#L7 was not bumped to 3.0.1?
Could a version 3.0.2 be published with this fixed and including PRs that have been merged or can be merged wasily.

@azmeuk can you have a look at this one too? Thanks.

Duplicate of #771


the face and hands are so wrong, am I do this the wrong way?

using the default parameters.
https://github.com/magic-research/magic-animate/assets/18125/c8dd5634-f705-4b0d-861f-516590008969
the result is nothing like the demo. I tried many images and all the same.

same here
can't reproduce nothing like demo

can you link that driver file?

can you link that driver file?

sorry I am new to this, what do you mean by "driver file"?

in my case, reference image covering more body parts than motion video would work better. i'm not quite sure about the model's limitation and also still trying to improve the result.
hope this helps

can you link that driver file?

sorry I am new to this, what do you mean by "driver file"?

the motion path, the video with the purple background

can you link that driver file?

sorry I am new to this, what do you mean by "driver file"?

the motion path, the video with the purple background

oh, I am using the one offer in the demo, this one:


Use a better changelog generator

Closes #19
Closes #18 (although it doesn't quite do what the issue asks)
Kind-of-WIP-but-not-really, just needs some testing. I'm thinking about deploying something that just logs the generated changelogs but doesn't actually use them.
There's a bit of ugly code-moving-around in here that I probably should have done separately, oops.
The changelogs look like this:
v0.6.0 (2019-05-15)
Full Changelog
Closed issues:

Add [compat] to Project.toml, get rid of REQUIRE (#71)
Author should be used in Project.toml (#67)
Overhaul interactive code (#62)
More functional internals (#60)
default to .gitignore /dev ? (#58)
Simpler plugin type declarations (#55)
Make Plugin interface less janky (#48)

Merged pull requests:

Replace authors field in Project.toml (#76) (christopher-dG)
Use correctly typed array as default assets (#75) (christopher-dG)
Ditch REQUIRE, add [compat] (#74) (christopher-dG)
Add CITATION.bib (#73) (matbesancon)
Revert "Use METADATA-compatible UUIDs" (#70) (tkf)
clarify ssh option (#64) (ssfrr)
Add EUPL-1.2+ (EN) license (#63) (SaschaMann)
Add /dev/ to gitignore (#59) (christopher-dG)
Fix code loading in documentation generation (#50) (christopher-dG)
Add CirrusCI plugin for FreeBSD support (#47) (christopher-dG)

Welp, this will get a bit more complicated.
The changelog generator's current release makes many simultaneous requests to GitHub, and it triggers abuse rate limits (despite being well within your actual rate limit). Newer versions of the generator pull data less quickly, which doesn't make GitHub explode, but it just takes too long. AWS API Gateway has a limit of 30 seconds on Lambda functions, while the real Lambda max timeout is 15 minutes.
So the changelog generation will need to be async, and triggered by something like SQS so that the function will have as much time to run as possible. The webhook endpoint should create the release without the release notes, and the background changelog job should edit the release with generated notes. That way, nothing but the notes are lost if that background job fails.
For reference, generating a changelog for Documenter.jl (which I would consider as a larger project, as it has ~1000 issues/PRs), takes 4 minutes on my computer, probably a bit faster on Amazon internet. I think this should still fall well within AWS free tier.

Are there no changelog generators that just work off of local git history? It seems really bizarre for this to be tied to GitHub and its API rate limiting...

Ah, I saw your comment on the referring issue. 😕

There are many but they aren't very useful for that exact reason. If we wanted to just list commits (as we currently do) then it would be easy but using the GitHub API gives us much much better results.
Anyways I'm almost done implementing it :slightly_smiling_face:.

Is there a way to "blacklist" an issue from appearing on a changelog?  For issues which are local build errors, or documentation requests, etc.

Yes, there is a list of labels you can add to the issue/PR to exclude it:

duplicate
question
invalid
wontfix (this and the ones above can also be Capitalized)
Meta: Exclude From Changelog

I will add a bit of docs about that (those are features with the generator).

This is working now :slightly_smiling_face:. I'll look at merging/deploying tomorrow.

Gonna deploy now -- I will keep a close eye on its actions today.


Unable to see Dapr enabled services in Application Insights.

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x ] documentation issue or request
- [ x] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Unable to see Telemetry in Application Insights.

In my own repo, that's using the workflow and Bicep files provided here (Thank you, life saver) I can't seem to get my services to show in Application Insights.
I'm using Dapr in all my services.
Mention any other details that might be useful
I've made some modifications to the bicep, but all seems okay.
This is just a request to see if it's still working your end :) Just incase API's or something has changed already :)

Thanks! We'll be in touch soon.

I have the same problem. As I confirmed the doc (*1), the latest bicep template format doesn't allow the "daprAIInstrumentationKey" property in L.45 of deploy/environment.bicep file in this repo.

 daprAIInstrumentationKey: appInsights.properties.InstrumentationKey

(*1) https://docs.microsoft.com/en-us/azure/templates/microsoft.web/kubeenvironments?tabs=bicep
I'd like to know whether this is document bug or bicep/ARMTemplate bug?

Yes there was a bug that was filed and is rolling out to fix this. I'll work to get latest update from team and close once someone confirms the fix is live

Thank you @jeffhollan!


Adding ability to sound the horn via popup.html

Adding the following to each file:
popup.html:

Extra row for sounding the horn
Updates timer only once on load
Would like to eventually update timer using a mutation observer / web worker  (probably blob)

popup.js

Added click listener to horn row to send horn action to content.js
Sends huntTimer action to content.js to get the current hunt timer. If the hunt is ready, a horn is displayed instead

content.js

Added runtime message listeners for horn and huntTimer being sent from popup.js

main.js

Added function to click the horn. This works if you new the new layout or the old layout.

Thanks for the feedback!
I probably should have asked about the messaging system. I kept going back and forth on using yours, or making my own. Since I wasn't passing links, I made my own, but I agree it works better to use one. Good catch on the image and the "Out of Bait!" link.
Thanks for testing and merging :+1:.


Adds a Dangerfile

See https://github.com/danger/danger/pull/478 for the reasoning why I couldn't do this in #4

          1 Message

  :book:
  Hello world

  Generated by :no_entry_sign: danger


Records silently ignores duplicate field name in joined tables.

In an SQL query I had joined to tables that happened to have a field with the same name (with different content). Records selected one of the fields without complaining; it just happened to be the wrong one.

If A and B contain a field with the same name, just one is returned. Usually the table name is prefixed to distinguish them, but I assume Records just uses the fieldname without prefix. That is usually convenient but not in this case. I think I'd prefer an error message.

Still not working. Even exception does not be raised.
My code:
def get(query, user, pw, host, port, dbname):
    connection = f'{user}:{pw}@{host}:{port}/{dbname}'
    conn_url = f'postgresql+psycopg2://{connection}'
    db = records.Database(conn_url)
    return db.query(str(query))

# usage
query = '''SELECT f1.relpath, f2.relpath FROM file as f1, file as f2'''
rows = get(query, *connection)

for r in rows:
    print(r)

The result:
<Record {"relpath": "clean_wk/61.png"}>
<Record {"relpath": "clean_wk/62.png"}>
<Record {"relpath": "clean_wk/63.png"}>
<Record {"relpath": "clean_wk/64.png"}>
<Record {"relpath": "clean_wk/65.png"}>
<Record {"relpath": "clean_wk/66.png"}>
<Record {"relpath": "clean_wk/67.png"}>
<Record {"relpath": "clean_wk/68.png"}>
<Record {"relpath": "clean_wk/69.png"}>
...

In this case, it seems to be necessary to distinguish columns by table name as a prefix.
ex) <Record {"f1.relpath": ..., "f2.relpath": ...}>


[api-minor] Update the minimum supported browsers/environments

Please note: The dates below are still a little ways off, however that obviously won't affect the existing PDF.js releases. Hence I think that we can make these changes now, since by the time of the next official PDF.js release they'll likely match up pretty well.[1]
While we "support" some (by now) fairly old browsers, that essentially means that the library (and viewer) will load and that the basic functionality will work as intended.[2]
However, in older browsers, some functionality may not be available and generally we'll ask users to update to a modern browser when bugs (specific to old browsers) are reported.[3]
Since we've previously settled on only supporting browsers/environments that are approximately three years old, this patch updates the minimum supported browsers/environments as follows:

Chrome 76, which was released on 2019-07-30; see https://en.wikipedia.org/wiki/Google_Chrome_version_history
Firefox ESR (as before); see https://wiki.mozilla.org/Release_Management/Calendar
Safari 13, which was released on 2019-09-19; see https://en.wikipedia.org/wiki/Safari_version_history#Safari_13
Node.js 14, which was release on 2020-04-21 (all older versions have reached EOL); see https://en.wikipedia.org/wiki/Node.js#Releases

[1] Given that the releases usually happen every two to three months.
[2] Assuming that a legacy/-build is being used, of course.
[3] In general it's never a good idea to use old/outdated browsers, since those may contain known security vulnerabilities.

/botio-linux preview

Thanks!


chore: bump kcl and kcl-openapi version to latest

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: bump kcl and kcl-openapi version to latest

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.212%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
130

Relevant Lines:
359

💛  - Coveralls


Ubuntu 16.04 LTS - able to see my GPU now - can't increase mem or heap size

Hi All,
After upgrading to 16.04 I thought I couldn't mine anymore. Luck has it that the AMDGPU driver supports opencl now and is available.
when I run ethminer --list-devices I get this:
Listing OpenCL devices.
FORMAT: [deviceID] deviceName
[0] AMD PITCAIRN (DRM 2.43.0, LLVM 3.8.0)
CL_DEVICE_TYPE: GPU
CL_DEVICE_GLOBAL_MEM_SIZE:<PHONE_NUMBER>
CL_DEVICE_MAX_MEM_ALLOC_SIZE: 268435456
CL_DEVICE_MAX_WORK_GROUP_SIZE: 256
The CL Device Global Mem size is set to 50%. The old commands to increase heap size and single alloc that worked with the old drivers doesn't work anymore. I ran:
export GPU_FORCE_64BIT_PTR=0
export GPU_MAX_HEAP_SIZE=100
export GPU_USE_SYNC_OBJECTS=1
export GPU_MAX_ALLOC_PERCENT=100
export GPU_SINGLE_ALLOC_PERCENT=100
None of them were able to increase the memory the size remains the same. Does anyone know how to free my memory using the new amdgpu kernel driver in Ubuntu 16.04? My R9 290 is sitting idle, i'll tip whoever gives me an answer :)
Rgds

its a bug in the AMDGPU driver...cant do anything until they fix it. Best bet is to downgrade to 14.04 and use fglrx.


feat: concat the adapter id to the model id in chat response

This PR concatenates the adapter id to the model id when an adapter id is specified in the chat request.
the follwing request
curl http: //localhost:3000/v1/chat/completions \
    -X POST \
    -H 'Content-Type: application/json' \
    -d '{
    "model": "google-cloud-partnership/gemma-2-2b-it-lora-jap-en",
    "messages": [
        {
            "content": "たくさんお金を稼ぎましたか？ Translate: ",
            "role": "user"
        }
    ],
    "max_tokens": 10,
    "stream": false
}' | jq

currently returns
{
    "object": "chat.completion",
    "id": "",
    "created":<PHONE_NUMBER>,
    "model": "google/gemma-2-2b-it",
    "system_fingerprint": "2.4.2-dev0-native",
    "choices": [
        {
            "index": 0,
            "message": {
                "role": "assistant",
                "content": "Have you made a fortune?"
            },
            "logprobs": null,
            "finish_reason": "stop"
        }
    ],
    "usage": {
        "prompt_tokens": 19,
        "completion_tokens": 7,
        "total_tokens": 26
    }
}

and with the changes returns an updated model id
{
    "object": "chat.completion",
    "id": "",
    "created":<PHONE_NUMBER>,
    "model": "google/gemma-2-2b-it+google-cloud-partnership/gemma-2-2b-it-lora-jap-en",
    "system_fingerprint": "2.4.2-dev0-native",
    "choices": [
        {
            "index": 0,
            "message": {
                "role": "assistant",
                "content": "Have you made a fortune?"
            },
            "logprobs": null,
            "finish_reason": "stop"
        }
    ],
    "usage": {
        "prompt_tokens": 19,
        "completion_tokens": 7,
        "total_tokens": 26
    }
}

merging as the failing CI is unrelated - and issues have been resolved/approved before the string change


Weird webView behaviour on Android 11

webView goes weird when scrolling fast on a long web page.  Here is a video showing the behaviour....
https://user-images.githubusercontent.com/61833594/137038627-e9fe4938-1a73-45b7-80f2-07c36206b632.mp4

Same behaviour with wikipedia
https://user-images.githubusercontent.com/61833594/137039142-2a812602-a4c1-4a0f-bb4c-6a68e22237fd.mp4

I just tired a Webview on my Pixel 4a(Android 13) and Samsung A02(Android) and was not getting the Weird Behavior,
Tried https://en.wikipedia.org/wiki/Lincoln_Memorial
And a super long web page https://catinfo.org
https://user-images.githubusercontent.com/7820808/183734813-68bd28f1-ca5d-4234-9b6e-2174106fd753.mp4
I am assuming this core Android bug or device specific bug( maybe low ram device). But going to close this, if you can list device and Android version, I can try to see if can reproduce

Maybe try landscape?

I tried Landscape as well
https://user-images.githubusercontent.com/7820808/183740040-91581045-48dd-4e2d-aafd-c608cda995e0.mp4

Well I don't know what to say. You saw the videos! Difference is I am loading webview over a game using almost 1GB ram. Unity tests do not replicate real world scenarios.

Update: this bug only happens when there is an event attached like this....
webView:addEventListener( "urlRequest", webListener )
Without a listener it performs as expected.  Weird huh?