Partial fix for issue 10448: add opt-out NaN propagation to min and max

With this change, both min and max will propagate NaN by default, and ignore it (mimicking behaviour of C fmin and fmax) if requested.
https://issues.dlang.org/show_bug.cgi?id=10448

Other than the usage of Flag, LGTM.

ping reviewers @DmitryOlshansky @andralex @Dicebot @9il @CyberShadow
This has been sitting here for a very long time; should it be merged, or is it a bad idea?

Can this PR breaks CTFE-able code?

Yes, because isNaN is not CTFE-able (AFAICT, issue 5227).

We have two options: first is wait until CTFE-able unions for FloatTraits, second is CTFE-able workaround with if(__ctfe) condition . a != a if a is nan.

Well, if we need a workaround for isNaN, I'd rather put it in isNaN. Why doesn't it use x != x in the first place?

This approach was rejected previously for some reasons.

Then I guess we're stuck with option one.

Then I guess we're stuck with option one.

That is wait for CTFE-able FloatTraits?

isNaN will suffice, but yes.

Ping me to unblock once we have that

This is a breaking change, as this no longer works
max!(long, long)(12, 10)

This is a breaking change, as this no longer works
max!(long, long)(12, 10)

Appears to be so.  Any suggestions?  I suppose one way to resolve that
is to choose one behaviour for min/max, and add new functions that take
the flag.  Or just abandon the flag entirely and always use one variant.
Also, concerning your mysteriously disappeared comment about Flag — what's
the recommended way, then?

Current coverage is 88.68% (diff: 100%)

Merging #3217 into master will increase coverage by <.01%

@@             master      #3217   diff @@
==========================================
  Files           121        121
  Lines         73855      73879    +24
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          65500      65523    +23
- Misses         8355       8356     +1
  Partials          0          0

Powered by Codecov. Last update 69c00bc...a50d4f8

Also, concerning your mysteriously disappeared comment about Flag — what's
the recommended way, then?

Because Flag already has the convince structs Yes and No in std.typecons, the alias kind of becomes redundant.

Appears to be so.  Any suggestions?  I suppose one way to resolve that
is to choose one behaviour for min/max, and add new functions that take
the flag.  Or just abandon the flag entirely and always use one variant.

 I didn't really know what he was talking about so I dropped it, but you can ask him.

So, I took a look at #4316 and here's what I have understood from the discussion.

There isn't a single “clearly correct” way of handling NaN's in min/max.
Explicitly testing for NaN in min/max is unacceptably slow, and  because of that, proper NaN handling should be done via compiler intrinsics.

(1) is the reason this PR has a Flag in the first place (which, admittedly, provides only two options), although it apparently breaks backwards compatibility. I'm not sure it is possible to keep backward compatibility, fix the issue, and provide desired flexibility at the same time.
As for (2), if it is a hard requirement, then I suppose this PR can be safely closed, as it isn't going to provide that.
Either way, I humbly ask @9il to summarize his views on the problem in the bugzilla to provide a clear point of reference.

Either way, I humbly ask @9il to summarize his views on the problem in the bugzilla to provide a clear point of reference.

Done.
We need a lot things todo: for example std.math should use just aliases to LDC intrinsics templates (math functions should be templates). We can keep  LLVM intrinsics as standard. We need to argue with @WalterBright to switch to C like floating pointed arithmetic instead of automatic expansion to reals (this is so horrible that it may kill D for science for ever, @wilzbach can tell a story about Tinflex, I can tell about precise and KBN summations, which does not work correctly with 32-bit DMD). D had a lot of long discussions about math and GC. We are moving to have great D without GC now. Well, I hope we will have D with normal FP arithmetic. But how much years we need to change @WalterBright 's opinion on this problem to the common form?

@WalterBright to switch to C like floating pointed arithmetic instead of automatic expansion to reals (this is so horrible that it may kill D for science for ever, @wilzbach can tell a story about Tinflex,

Oh yes :/
I started to document all the bumps with FP math I ran into on our mir wiki. While some of these are expected, there are some that are horrible, cruel & yield a constant fight against the compiler
FP behavior that is different depending on the target is very hard to work with. Wasn't the entire point of D to get it right and avoid weird, unproductive corner-cases across architectures?
The problem with Tinflex and a lot of other scientific math is that you need reproducible, predictive behavior. For example the Tinflex algorithm is quite sensitive as it (1) uses pow and exp, so errors sum up quickly and (2) it has an ordered heap of remaining FP values, which means due to  FP magic which will be explained below I get totally different resulting values depending on the architecture. Note that the ordering itself is well defined for equality, e.g. the tuples (mymath(1.5), 100), (mymath(1.5), 200) need to result in same ordering. I don't want my program to fail just because I compiled for 32-bit, but maybe code shows more than words.
Consider the following program, it fails on 32-bit :/
alias S = double; // same for float

S fun(S)(in S x)
{
    return -1 / x;
}

void main()
{
    S i = fun!S(3);
    assert(i == S(-1) / 3); // this lines passes
    assert(fun!S(3) == S(-1) / 3); // error on 32-bit
}

Maybe it's easier to see why this behavior is tricky when we look at it in action. For example with this program DMD for x86_64 will yield the same result whereas x86_32 will yield different ones.
import std.stdio;

alias S = float;
float shL = 0x1.1b95eep-4; // -0.069235
float shR = 0x1.9c7cfep-7; // -0.012588

F fun(F)(F x)
{
    return 1.0 + x * 2;
}

S f1()
{
    S r = fun(shR);
    S l = fun(shL);
    return (r - l);
}

S f2()
{
    return (fun(shR) - fun(shL));
}

void main
{
    writefln("f1: %a", f1()); //  -0x1.d00cap-4
    writefln("f2: %a", f2());  // on 32-bit: -0x1.d00c9cp-4
    assert(f1 == f2); // fails on 32-bit
}

To make matters worse std.math yields different results than compiler/assembly intrinsics - note that in this example import std.math.pow adds about 1K instructions to the output assembler, whereas llvm_powf boils down to the assembly powf. Of course the performance of powf is a lot better, I measured that e.g. std.math.pow takes ~1.5x as long for both LDC and DMD. Of course if you need to run this very often, this cost isn't acceptable.
void main()
{
    alias S = float;
    S s1 = 0x1.24c92ep+5;
    S s2 = -0x1.1c71c8p+0;

    import std.math : std_pow = pow;
    import core.stdc.stdio : printf;
    import core.stdc.math: powf;

    printf("std: %a\n", std_pow(s1, s2)); // 0x1.2c155ap-6
    printf("pow: %a\n", s1 ^^ s2); // 0x1.2c155ap-6
    printf("powf: %a\n", powf(s1, s2)); // 0x1.2c1558p-6

    version(LDC)
    {
        import ldc.intrinsics : llvm_pow;
        printf("ldc: %a\n", llvm_pow(s1, s2)); // 0x1.2c1558p-6
    }
}

import std.stdio;
alias S = double;

S fun(S)(in S x)
{
    return -1 / x;
}

void main()
{
    writeln(-1 / -1.0);
    writeln(S(-1));
}

Prints
1
-1

WHAT!?
This has to be a bug right? There's no way this is intended behavior.

@wilzbach Ok, so that's the effect, but what's the cause?

Done

Thanks.

@wilzbach Ok, so that's the effect, but what's the cause? What's the rationale behind DMD outputing different code for different architectures?

Idk, hence I started a discussion on the NG about it:
<EMAIL_ADDRESS>Let's hope it won't end like the auto-decoding thread.


Widget->XObject

Ah, got it :)
On Thu, Apr 7, 2016 at 12:29 PM, Jonathan Frederic<EMAIL_ADDRESS>
wrote:

Closed #464 https://github.com/ipython/ipywidgets/pull/464.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/pull/464#event-619008896

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


How to use customJwtCheck with TypeScript and Custom Payload

Question
How to use customJwtCheck with TypeScript and Custom Payload?
Is there an easier approach than the following code? The main problem is that I can't access payload.sub if I don't cast the payload first.
// ...
customJwtCheck: ({header, payload: _payload, jwk}) => {
        const payload = _payload as GithubActionsJwtPayload
        if (!ALLOWED_GITHUB_PRINCIPALS.includes(payload.sub) {
            throw new FailedAssertionError(`Unexpected token sub`, payload.sub)
        }
    },
// ...

!ALLOWED_GITHUB_PRINCIPALS.includes(payload.sub as string) should work too and is slightly easier?
Or better:
if (typeof payload.sub !== "string" || !ALLOWED_GITHUB_PRINCIPALS.includes(payload.sub))
If you're using the CognitoJwtVerifier we should use the Cognito JWT typings instead of the generic ones, then you wouldn't need this cast. If you want to submit a PR? (Might be a bit of a rabbithole with the types though)


chore(saml): upgrade saml version 1.3.1

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes
Bump the SAML version to fix issue with newly added setting for extra allowed canonicalization method algorithms.
How did you test this code?
Ran the API locally with the EXTRA_ALLOWED_CANONICALIZATIONS environment variable set and confirmed that the module was patched correctly.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.91%. Comparing base (0924351) to head (3ba545e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3469   +/-   ##
=======================================
  Coverage   95.91%   95.91%
=======================================
  Files        1092     1092
  Lines       33989    33991    +2
=======================================
+ Hits        32599    32601    +2
  Misses       1390     1390

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve accuracy of filter_test.go

This commit will improve the accuracy of filter.go unit tests.
Before reflect.DeepEqual was used to check equality between slices, but f.filtered and sort.StringSlice aren't comparable.
There was also a bug where reflect.DeepEqual was returning false but the test did not fail due to a wrong if check.
Now we use gomega to
very strictly check the expected and got slices.

Thanks @darkowlzz for the suggestions and guidance!


[BUG] Merging fails with v4.5.3

Describe the bug
Merging a PR fails with the latest version. I have tried it on PRs with multiple merge styles, Rebase and Merge, Squash and Merge etc.
To Reproduce
Steps to reproduce the behavior:

A mergeable PR on gh dash
Press m to initiate merge. Confirm merge
Error message received 2024/08/14 12:04:36 ERRO Task finished with error id=pr_merge_488 err="exit status 1"
Install version v4.5.2, and following the same steps behaves as intended and the PR is merged

Expected behavior
Pressing m on a PR should merge the PR
Screenshots
Confirmation screenshot:

Error message screenshot:

Desktop (please complete the following information):

OS: MacOS Sonoma 14.5
Model: Macbook Pro, M1 Pro
Memory: 16GB

PS. Here's my config:
prSections:
  - title: My Pull Requests
    filters: is:open author:@me
  - title: Needs My Review
    filters: is:open review-requested:@me
  - title: Involved
    filters: is:open involves:@me -author:@me
issuesSections:
  - title: My Issues
    filters: is:open author:@me
  - title: Assigned
    filters: is:open assignee:@me
  - title: Involved
    filters: is:open involves:@me -author:@me
defaults:
  preview:
    open: true
    width: 70
  prsLimit: 20
  issuesLimit: 20
  view: prs
  layout:
    prs:
      updatedAt:
        width: 7
      repo:
        width: 15
      author:
        width: 15
      assignees:
        width: 20
        hidden: true
      base:
        width: 15
        hidden: true
      lines:
        width: 16
    issues:
      updatedAt:
        width: 7
      repo:
        width: 15
      creator:
        width: 10
      assignees:
        width: 20
        hidden: true
  refetchIntervalMinutes: 30
keybindings:
  issues: []
  prs: []
repoPaths: {}
pager:
  diff: delta

@dlvhdr Thanks a ton for the blazing fast fix. Tested on the new version. Is working now. The UI looks different than earlier (takes me out of dash until the merge is submitted). But it works. 🙂


Update to new badges?

Hello,
nice Project! But in the meantime Google has updated the badges and they use a different font on it now. Are you going to update the SVGs?
https://play.google.com/intl/en_us/badges/

Good call! I can't promise anything but if I can find time I'll certainly take care of this.

Done! Thanks for bringing this to my attention.


Is it possible to change how much have spaces after the next line?

https://github.com/yegor256/pdd/blob/master/lib/pdd/source.rb#L145
Because my Javadoc style is like that;

So, I want to make the spaces 2.

@portlek it's not configurable at the moment. You are welcome to submit a pull request with this configuration option though.

@portlek it's not configurable at the moment. You are welcome to submit a pull request with this configuration option though.

thanks, if I can learn to ruby I'll make it ASAP .-.

Fixed in PR #160


Add a cmake function for setting IP addresses

The fix for the following issue adds some macros to set default ip addresses. These are expressed in hex which is a bit non-obvious to set. So add a macro to convert from a string to the hex representation.
https://github.com/georgerobotics/cyw43-driver/issues/41

Is it worth clarifying that this is for IPv4 addresses?

pico_configure_ip4_address sounds ok


Doesn't seem to work in 4K.

Like I said, it does not seem to scale to my 4k monitor. When I switch my 1080p as my main display it works just fine. Just a small inconvenience and I hope you can fix it.

Try the latest version and report back


Update Cab Images, Names and Prices

Please assign me this task so i can work upon this.
Also please add GSSoC Extd. , Hactoberfest and Level label

Pull the latest code and then work on it


update some dependencies and make it more stable against null ref

Package PR-57-CZ.AspNetCore.EasyAuthAuthentication published to CZ.AspNetCore.EasyAuthAuthentication-PR
codez-one/CZ.AspNetCore.EasyAuthAuthentication

Package PR-57-CZ.AspNetCore.EasyAuthAuthentication published to CZ.AspNetCore.EasyAuthAuthentication-PR
codez-one/CZ.AspNetCore.EasyAuthAuthentication


SSL Pyflyte Gcloud

Type

[ ] Bug Fix
[ ] Feature
[ ] Plugin
[X] Documentation

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[X] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Completed editing documentation on “How to add SSL while using pyflyte run on gcloud cluster”
Tracking Issue
https://github.com/flyteorg/flyte/issues/2893

@Smartmind12, you'll need to edit the https://docs.flyte.org/en/latest/deployment/gcp/manual.html file in the flyte repo. Also, the instructions need to be modified to align the doc flow with flyte docs (the doc is actually pretty clear). Can you do that?

@Smartmind12, you'll need to edit the https://docs.flyte.org/en/latest/deployment/gcp/manual.html file in the flyte repo. Also, the instructions need to be modified to align the doc flow with flyte docs (the doc is actually pretty clear). Can you do that?

@samhita-alla I did not understand the second part ...as in what should i modify?

@Smartmind12, the content should be present in the gcp page I shared with you earlier. And if you see the instructions in the doc, it aligns with the content that's present in the gcp page. So you'll need to intersperse the gcp page with the doc instructions.

@Smartmind12, the content should be present in the gcp page I shared with you earlier. And if you see the instructions in the doc, it aligns with the content that's present on the gcp page. So you'll need to intersperse the gcp page with the doc instructions.

Hey @samhita-alla Sorry i got a little busy...so you want me to rearrange the contents of the gcp in the flow of the google drive doc ...is that right?

@Smartmind12 Could you add these changes to here instead?

@Smartmind12 Could you add these changes to here instead?

Okayy, i will do it!

Thank you!!


TF2.9 perf is slower

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
tf2.9
Custom Code
No
OS Platform and Distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
A100
Current Behaviour?
We migrate from tf2.4 to tf2.9, and observed that the training speed of some models has ~20% decrease.

On tf2.4, it takes ~30mins after starting the job, before processing the 1st batch. Training speed increase and then become stable.
On tf2.9, it takes ~5mins after starting the job, before processing the 1st batch. Training speed does not increase.

Q1: Can we use tf2.4 to train the model and use tf2.9 for inferencing? Any potential issues?
Q2: How can we find the root cause of tf2.9 training slowness?

Standalone code to reproduce the issue
Can't share the source code.

Relevant log output
No response

I would like to work on this issue and get it done for which I would be needing your help with the code. Can you assign this to me

@cybergeekgyan Thanks for the response. Can you assign this to yourself? I don't have edit privilege on the assignees section.

@dengpanyin How can I assign this issue to myself as I also don't have the privileges on the assignee task.
@tiruk007 please look into the matter

Hi @dengpanyin !
Could you share the sample code to reproduce this issue.
Thank you!

@mohantym  Sorry, unable to share the code publicly due to company policy.  Can we schedule a live debugging session if that help?

@dengpanyin !
We should not write the model in 2.4 and use in 2.9 because the commands will be bit different and will contain depreciated api when migrating from 2.4 to 2.9 or higher.
You can use 'git diff'  to see difference  2.4 and 2.9  aside checking at release notes of 2.9 and 2.4 which would have mentioned the  bug fixes and feature addition.
Getting 5 mins warm up time in 2.9 sounds awesome compared to 30 mins warm up time (2.4) . Curious on Training speed   w.r.to both version.
I will investigate with Keras example notebooks  and post you on this
Any toy models or  example notebook from tensorflow.org to replicate this issue would be appreciated.
Thank you!

@dengpanyin !
Thanks for the clarification. You can post same on TF Forum too.
@SuryanarayanaY !
Could you look at this issue.
Thank you!

Hi @dengpanyin ,
Could you provide minimal code snippet that you are using?Also you are missing details like OS, Bazel versions(If built from source),CUDA versions etc that might be required for analysis.Could you please share those?Without that it is difficult to address your issue.
Could you also share the epoch wise training time for 2.4 and 2.9 versions.
Thankyou!

Hi @dengpanyin ,
For better performance with newer TF versions Recommended way of passing data for training is tf.data.Dataset API. Please refer the attached API Documentation and try to convert your data into tf.data.Dataset using the suitable methods and let us know the results.
Thankyou!

We are already use tf.data.dataset APIs both tf2.4 & tf2.9

Hi @dengpanyin ,
Could you please provide some Toy code to replicate the issue.Since tf.data.Dataset optimized for performance and if it is not working as mentioned by you we should check the code and replicate the issue to find out the reason.Please provide minimal code snippet for same.
Thank you!


Add roger.ml blog site

Hi there! 👋
Just adding my personal blog site with all the metadata following the site's instructions I found here: https://iosdevdirectory.com/contributing/
I tried adding the new element of the array following alphabetical order, idk if I got it right, though haha. This might be a step of the CI (to sort the array of blogs in the JSON so the JSON is organized), but I wasn't sure 😅
Cheers!

Thanks Roger!
Don't worry about the alphabetical order, I run a re-sort every now and then to clean things up. I'm not strict on the sorting and the site sorts correctly regardless of the data file.

Awesome! Thank you! 🤗

@daveverwer , just wondering, is the https://iosfeeds.com homepage supposed to be updated with past entries of my blog, or just new ones? I see my blog in https://iosfeeds.com/feeds but the articles I published prior to this PR aren't showing up in the homepage, I wonder if it's the expected behavior :)
Thanks in advance! 🙏

I'm afraid that's not my project and so I am not sure. It uses the data from this site, but it's @nemecek-filip who runs that!

Ooooh, my bad! I thought it was yours too 😂
Thanks for clarifying and for tagging Filip 🤗

Hello @rogerluan, all past entires are indexed (for search) but only those published after the initial import are visible on the homepage. This is because RSS feeds often don't have correct published dates and adding new feeds often caused to display all blog posts at once.

Hi @nemecek-filip 👋 got it! Thanks for explaining, and for the prompt response! 😊


schedulingEngine field duplication across inherited classes

The schedulingEngine field appears in both the foundationCommon.Organization and scheduling.Organization classes.
As the scheduling.Organization extends the base_Organization, I'm getting a duplicate field error as I'm resolving 'base-' class extension references in the schema file via the corpusPath (below).
Is this the correct approach?
Thanks
allImports.1.0 File
"corpusPath": "/core/applicationCommon/foundationCommon/Organization.1.0.cdm.json",
"moniker": "base_Organization"
Schema File
"definitions": [
{
"entityName": "Organization",
"extendsEntity": "base_Organization/Organization",
"exhibitsTraits": [
{
"traitReference": "is.CDM.entityVersion",
"arguments": [
{
"name": "versionNumber",
"value": "1.0"
}
]
}
],

Hi cashel1,
Sorry for the late reply.
It looks like you are extending the foundationCommon.Organization and it shouldn't have conflicts with scheduling.Organization. Can you specify what you are trying to do? I also tried resolving scheduling.Organization and it didn't report any error.
Thanks,
Yijing

Hello Yijing, thanks for getting back.
The schedulingEngine field appears in two separate schema files (foundationCommon.Organization.cdm.json and foundationCommon.crmCommon.projectCommon.scheduling.Organization.cdm.json.
The _allImports.1.0.cdm.json file inside the scheduling folder lists this:
{
"corpusPath": "/core/applicationCommon/foundationCommon/Organization.1.0.cdm.json",
"moniker": "base_Organization"
},
as in import, which is how I'm determining inheritance.
Thanks

Hi,
Sorry for the late response. _allImports.1.0.cdm.json is not the latest version of the schema. The non-versioned schema files are the latest files, I think you would want to refer to this
[_allImports.cdm.json[(https://github.com/microsoft/CDM/blob/master/schemaDocuments/core/applicationCommon/foundationCommon/_allImports.cdm.json).
Let me know if you have more questions.
Thanks

Hello,
When fetching the scheduling/Organization entity, the object model should overwrite the schedulingEngine attribute from base_Organization with the schedulingEngine attribute that is found in scheduling/Organization. If this is still an issue can you attach the error that you are seeing?

Hi,
We will close the issue due to lack of response. In case you still have this problem, please reopen the issue. Thanks.


Y24-323 - (MVP) Create stories for new scRNA Core PBMC pooling strategy

Description
A continuation of https://github.com/sanger/limber/issues/1865. To be done after R&D have carried out their end to end pipeline test.
Acceptance Criteria
The following outputs from the research are produced:

[ ] Draft stories defined here are written up into proper issues.
[ ] Any learnings and requirements change from R&D's end to end pipeline test are taken into account.

Who the primary contacts are for this work
Katy
Knowledge or Stake holders
Abby, Lesley

Abby Slack message 3rd Oct:

I am just raising that we may want to move the 'LRC PBMC Pools Input' entry point to be on the 'LRC GEM-X 5p GEMs' plate instead i.e. to have a 'LRC GEM-X 5p GEMs Input' plate.
This is still under discussion and we hope to make a decision at the working group on the 17th October.
The benefit of this change is that it would enable samples to enter at a safe stopping point in the pipeline, reducing the time pressure for the handover.
If we do decide to go ahead, we should require this for pre-production (currently w/c 18th November)
Please let me know if you foresee any issues with this and I'll keep you updated.

Current timelines are expecting LIMS to be live for 18th November (5 weeks).


[GOBBLIN-1646] Revert yarn container / helix tag group changes

Revert "Fix bug when shrinking the container in Yarn service (#3504)"
This reverts commit dd6d910a7e7a90d15258c6c77ebe626ae6d573f9.
Revert "[GOBBLIN-1620]Make yarn container allocation group by helix tag (#3487)"
This reverts commit 3e877951c284ccd68be3634522f9fc2c3d39f81a.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1646] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1646

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Tested on parallel test pipeline for regressions. Data is landing for /data/tracking/streaming_parallel_test/PageViewEvent/hourly/2022/05/12/10

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3507 (63c9275) into master (5ad9fe1) will decrease coverage by 3.19%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             master    #3507      +/-   ##
============================================
- Coverage     46.68%   43.49%   -3.20%
+ Complexity    10410     2040    -8370
============================================
  Files          2079      405    -1674
  Lines         81326    17466   -63860
  Branches       9082     2134    -6948
============================================
- Hits          37970     7597   -30373
+ Misses        39853     9021   -30832
+ Partials       3503      848    -2655

Impacted Files
Coverage Δ

...bblin/cluster/GobblinClusterConfigurationKeys.java
0.00% <ø> (ø)

...pache/gobblin/cluster/GobblinHelixJobLauncher.java
67.21% <ø> (+2.36%)
:arrow_up:

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
63.46% <14.28%> (-0.49%)
:arrow_down:

...rg/apache/gobblin/yarn/YarnAutoScalingManager.java

...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java

...main/java/org/apache/gobblin/yarn/YarnService.java

...apache/gobblin/yarn/event/NewContainerRequest.java

...va/org/apache/gobblin/source/workunit/Extract.java

...ent/version/finder/UnixTimestampVersionFinder.java

... and 1668 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad9fe1...63c9275. Read the comment docs.


add php 8.2 to test

now released https://www.php.net/releases/8.2/en.php

tests pass, bu there are some issues with admin i need to resolve.


Add EOF symbol to match end of input

Can be signified with $
Must be optional (grammars don't have to contain it to be correct)
Need to make sure it works for both LALR and Earley, and with indentation.

Hey can I work on this issue?

Any update?

I have a version that should be working for LALR, in branch end_symbol
If anyone wants to test it and let me know how it goes, that would be great!
@isidentical @jruales @coreyt

+1 for $ to represent end of string. I just ran into a need for this.

Just pushed this into master. You can now use $ for LALR parsers. (No Earley support yet)
Here's an example from the tests that shows what it does:
        def test_end_symbol2(self):
            grammar = """
                start: (a|b)+
                a: "a" ("x"|$)
                b: "b"
            """
            parser = _Lark(grammar)

            self.assertEqual(parser.parse('axa'), Tree('start', [Tree('a', []),Tree('a', [])]))
            self.assertRaises(UnexpectedInput, parser.parse, 'ab')

I've just checked master and I can't find test_end_symbol2 and the example grammar listed above doesn't import.
E           lark.exceptions.GrammarError: Unexpected input at line 2 column 13 in calculator/grammar.lark:
E
E           a: "a" ("x"|$)
E                       ^

lark/lark/load_grammar.py:890: GrammarError

I don't claim to be even remotely be an expert on parsing but not being able to match $ seems to make even the simplest of grammars unparseable.
For instance (simplified):
start: expr+

expr: expr OPER expr
      | SIGNED_NUMBER

OPER: "+" | "-" | "*" | "/"

parse("1+1") # Tree('start', [Tree('statement', [1.0]), Tree('statement', [1.0])])

whereas start: (expr ("\n"|$))+ would actually pick expr oper expr

Looks like you reverted in 3bee21051e8440e506ea13f45b224e2f6d668662 but you don't say why.

If I remember correctly, there were some problems with unexpected side effects.

I don't claim to be even remotely be an expert on parsing but not being able to match $ seems to make even the simplest of grammars unparseable.

Maybe, but your example is wrong:
start: expr ("\n" expr?)*

works.

So it does... again, not an expert, but that's very non intuitive.
Thanks for the help!

@kneufeld I reverted it because it was buggy.
I agree it would be a nice feature, but I don't think it's a necessity.

Is there any update? I kind of need this. Or is there a workaround?

I'll see what I can do

@ThatXliner See PR #880


Make rangetree clippy happy

clippy spits quite a lot of warnings - some trivial, some not. All of them though making code more idiomatic.

Applied some of the commits from the PR that I felt made sense.
Closing.


CIP0025 | retitle to Media NFT Metadata Standard

Yes, at some point the idea was to split the CIP in 2, one for the policy/asset structure that could be used for example for fungible tokens too, and one for the media specific metadata:
https://github.com/cardano-foundation/CIPs/pull/85#discussion_r629120254
This did not happen so I guess it makes sense to rename the whole CIP instead.

Seems fine indeed, we also need to update the top-level README's table.


more control over the slide

is there any way I can control if the pager can go to the next screen?

There is the disableSwipe prop

i want to disable it on next only but allow it to go back
i think canScrollHorizontally on ViewPager will do it no android side
thanks for the reply :)

i was able to to make this behaviour by overriding the pager adapter getCount
this.pager.nativeElement.pagerAdapter.getCount = () => 2;
this.pager.nativeElement.pagerAdapter.notifyDataSetChanged();
but i think overriding the canScrollHorizontally fn of the view pager will be better solution

i did a PR with this take a look when you have time :)


[WIP] Unit testing 2

Codecov Report

Merging #448 (d737508) into main (4754678) will increase coverage by 22.81%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##            main     #448       +/-   ##
==========================================
+ Coverage   5.79%   28.60%   +22.81%
==========================================
  Files         49       51        +2
  Lines       5278     5446      +168
==========================================
+ Hits         306     1558     +1252
+ Misses      4944     3766     -1178
- Partials      28      122       +94

Impacted Files
Coverage Δ

internal/commands/ize.go
63.77% <0.00%> (+38.13%)
:arrow_up:

internal/config/config.go
1.65% <0.00%> (-0.40%)
:arrow_down:

internal/config/project.go
0.00% <0.00%> (ø)

internal/commands/ci.go
21.51% <14.28%> (+21.51%)
:arrow_up:

internal/commands/testing.go
43.90% <43.90%> (ø)

internal/commands/status.go
71.57% <70.00%> (+71.57%)
:arrow_up:

internal/commands/build.go
87.32% <100.00%> (+87.32%)
:arrow_up:

internal/commands/console.go
78.37% <100.00%> (+78.37%)
:arrow_up:

internal/commands/down.go
8.39% <100.00%> (+8.39%)
:arrow_up:

internal/commands/down_infra.go
23.52% <100.00%> (+23.52%)
:arrow_up:

... and 42 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Automated Package Upgrade

:tada: This PR is included in version 7.7.325 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Component mounting before query returns

Hello,
I thought the data container was supposed to return before it allowed the new component to mount anything. Do I have to handle the fetch's "loading" state? It's very strange and I feel like there must be a simple solution. When i swap this
class GridContainer extends React.Component {

	render() {
		console.log("props")
		console.log(this.props)
		const workouts = this.props.data.workouts;

		return (
			<GridComponent workouts={workouts} />
		)
	}
};

for this:
class GridContainer extends React.Component {
	constructor(props) {
		super(props)
	}
	render() {
		console.log("props")
		console.log(this.props)
		const workouts = this.props.data.workouts;
		console.log("workouts")
		console.log(workouts)

		return (
			<div>
				hello world
			</div>
		)
	}
};

i get:

my data is there in the workouts array. but when i try to pass "workouts" to my GridComponent component, like this:
class GridContainer extends React.Component {

	render() {
		console.log("props")
		console.log(this.props)
		const workouts = this.props.data.workouts;

		return (
			<GridComponent workouts={workouts} />
		)
	}
};

I get:

It seems like the component wants to mount before the data is actually available to it, causing an error.   Any input would be much appreciated.

Yes, you need to handle loading state yourself. The container doesn't have built-in logic to do anything special, other than pass through loading/error state to the child.
This is a pretty standard thing - handing loading state is very application-specific, and you usually don't want to block rendering a big part of your tree on a long server request.

By the way - this might be better opened on apollo-client rather than the server.

@stubailo thanks for clearing this up!


Added Download link in ReadMe

I had little hard time to get download link. So added in ReadMe.
Thanks :)

@kenwheeler  a gentle nudge. :) Thanks


Migration/ChangeTableReferences doesn't cover all cases

This idea behind this cop is to prevent creating multiple alter table with a single add_references.
The approche of the cop is to check change_table, but add_references can be use outside of a change table.
This cop should be replace to ONLY allow t.references in a create_table, all other usage imply an ALTER TABLE which will result to multiple SQL command even in a change_table bulk: true.

Instead of modifying/replace the current cops. I created a new one, the combination of both will provide the same effect and each one do a very specific thing. One to detect single add_reference outside change_table, the other to prevent t.reference in a change_table.


tket emulator feature additions

Please leave all links as is and do not change links to direct links to pdfs. Documents are periodically updated and this will break links if direct links are used.

@microsoft-github-policy-service agree company="Quantinuum"

@bradben
Can you review the proposed changes?

Note that the validation warnings must be resolved before merging.
The changes should also be moved into the private repo for staging and automated checks. Let us know if you'd like help with that.

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

You have "Powered by Honeywell". Change to "powered by Quantinuum"

This needs to remain as "Powered by Honeywell" as part of our on going agreement with Honeywell.

Add hyperlink to "To see Quantinuum's billing plans, visit Azure Quantum pricing": https://learn.microsoft.com/azure/quantum/pricing

@ffrachon
I have updated this link. It is still not displaying in GitHub properly but we believe this is due to the connectors not being setup in GitHub.

@ZachMassa - FYI, I'm actually tracking these changes in another PR in our private repo, where it gives me a preview, more extensive verification checks, etc. All your updates look fine so far, thanks!


fix(plugin): OTEL exporting with translate

Summary
We represent trace spans with a universal format for all kinds of mainstream tracers and translate them to different formats when propagating headers and exporting traces. However, OTEL misses the handling of trace ID length.
Checklist

[x] The Pull Request has tests
[ ] There's an entry in the CHANGELOG
N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference
Fix KAG-652

I've updated the PR with a couple fixes. I think it meets the correct requirements now, but there are some warts:

We only have test coverage for the trace ID zero-pad case. There is no test for the trace ID truncate case, because an incoming trace ID that is too long will be discarded as invalid.
The way we are copying the span table seems like it may have unintended consequences. Spans use table pools under the hood, so the PDK expects to manage their lifecycle. Copying spans outside of the PDK can therefore lead to situations where tables are orphaned and gc-ed instead of being returned to the pool as intended.

I've updated the PR with a couple fixes. I think it meets the correct requirements now, but there are some warts:

We only have test coverage for the trace ID zero-pad case. There is no test for the trace ID truncate case, because an incoming trace ID that is too long will be discarded as invalid.
The way we are copying the span table seems like it may have unintended consequences. Spans use table pools under the hood, so the PDK expects to manage their lifecycle. Copying spans outside of the PDK can therefore lead to situations where tables are orphaned and gc-ed instead of being returned to the pool as intended.

Answering question 2: the copied span won't survive the request so it will be GC-ed, and its reference to the members will also be gone. So the only reference to those members should be from the original span, which will be returned to the pool. If the PDK decides to also reuse the member, it will still be fine as the table returned to the pool has reference to the members.

I've updated the PR with a couple fixes. I think it meets the correct requirements now, but there are some warts:

We only have test coverage for the trace ID zero-pad case. There is no test for the trace ID truncate case, because an incoming trace ID that is too long will be discarded as invalid.
The way we are copying the span table seems like it may have unintended consequences. Spans use table pools under the hood, so the PDK expects to manage their lifecycle. Copying spans outside of the PDK can therefore lead to situations where tables are orphaned and gc-ed instead of being returned to the pool as intended.

To answer question 1: I agree that we need a test for the truncating case. But the code you're referring to (handling to OT header) does not mean truncating doesn't work. We're translating traces, and a hypothetical trace format may have a valid trace ID larger than that.

However there's not a type of ID that is long enough to go through the truncating path, so we skip it for now.


Deleting talent doesn't delete modifier

In 1.8 Alpha-7, I created a talent that had the modifier "Skill Add Triumph". When I deleted the modifier by clicking the delete icon on the modifier tab, the actor still retained the modifier when viewed in console. Deleting the talent (without the modifier attach per console view) had no effect and the modifier still appeared in the actor.  This has not be attempted with other modifiers.

I am not having the same issue. Are you editing the talent on the actor, token or in the item directory/compendium? When I remove the "Skill Add Triumph" modifier from the talent on the character, it also removes the effect of the modifier on the skill.


Issue regarding Media Query on iPad Portrait

Hi,
I have been trying fixed stated in 2.0.1 WIP But no hope of getting correct padding on iPad Portrait mode. As shown in the link here: http://goo.gl/55ONF ; viewing in chrome doesn't has any issue though.

What's the issue you're having?

Oh Sorry, the issue is now magically disappear.  Thank you so much


Lint/ShadowedException does not specify the problem class when multiple classes are present

Expected behavior
I expect Rubocop to tell me which class is in violation of class ancestry. When many classes are listed,
it's not obvious where the problem is and the first line of classes are indicated with an underline regardless of status.
Actual behavior
Only a simple lint error of "Do not shadow rescued Exceptions." is printed at the first line of the classes, at the rescue
Steps to reproduce the problem
The following spec will pass.
Added to spec/rubocop/cop/lint/shadowed_exception_spec.rb
    it 'accepts rescuing multiple custom exceptions but does not show the problem classes' do
      expect_offense(<<~RUBY)
        begin
          something
        rescue  Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED,
                Net::OpenTimeout, Net::ReadTimeout, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError,
                Timeout::Error,
                EOFError

          handle_exception
        end
      RUBY
    end

In this example, Net::OpenTimeout and Net::ReadTimeout are ancestors of Timeout::Error, however, the printed error message is of little help when the above test is changed to "expect_no_offenses". It might even be considered misleading that the first line of error classes is underlined when they're not at fault for the failure.
       Diff:
       @@ -1,6 +1,7 @@
        begin
          something
        rescue  Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED,
       +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not shadow rescued Exceptions.
                Net::OpenTimeout, Net::ReadTimeout, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::ProtocolError,
                Timeout::Error,
                EOFError

We're left with having to check class ancestry on individual classes to determine where the issues might be.
RuboCop version
git sha1: 1365cb626a280

same situation


Add support for host tags

https://docs.logdna.com/docs/logdna-agent#section-how-do-i-use-host-tags-

Thank you for your contribution, we very much appreciate it.


enables erase by json_pointer

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
enables erase by json_pointer, see line and comments above "what to do"
needs tests

Pull request checklist
Read the Contribution Guidelines for detailed information.

[ ]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.
[ ]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Coverage remained the same at 100.0% when pulling e66a3e52429c5d8afa38ec7ba3392b7d618d656c on timprepscius:erase_by_json_pointer into 9294e25c98f9c09a1874842dbcaae7a91336a57e on nlohmann:develop.

@timprepscius Will you have time to resolve the remaining issues?


One simple question

Hi, Phil!
One simple question, (my math is not good)
https://github.com/lucidrains/h-transformer-1d/blob/7c11d036d53926495ec0917a34a1aad7261892b5/train.py#L65
why not be randint(0, self.data.size(0)-self.seq_len+1)? Since the high part should be excluded

@CiaoHe Hey! I believe you are right and made the change https://github.com/lucidrains/h-transformer-1d/commit/9c09a00a946ab12e0820f56ebaa21bfb8bb28fcf the extra  - 1 was actually to account for fetching sequence length + 1 for being broken up into input and labels

wow i see! thank you !


Update README.md

maxcdn is now available on stackpath

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create LICENSE

solves #19

@ajinkyapatil8190 Thanks for opening this PR. Why we have to maintain the apache licence twice? One in the licences folder and the other in the root? The repo was reuse tool compliant before.


Python error when trying to setup

Mar 10 01:07:36 ubuntu hass[16808]: 2018-03-10 01:07:36 ERROR (MainThread) [homeassistant.setup] Error during setup of component bmw_connected_drive
Mar 10 01:07:36 ubuntu hass[16808]: Traceback (most recent call last):
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/setup.py", line 145, in _async_setup_component
Mar 10 01:07:36 ubuntu hass[16808]:     component.setup, hass, processed_config)
Mar 10 01:07:36 ubuntu hass[16808]:   File "/usr/lib/python3.6/asyncio/futures.py", line 332, in __iter__
Mar 10 01:07:36 ubuntu hass[16808]:     yield self  # This tells Task to wait for completion.
Mar 10 01:07:36 ubuntu hass[16808]:   File "/usr/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
Mar 10 01:07:36 ubuntu hass[16808]:     future.result()
Mar 10 01:07:36 ubuntu hass[16808]:   File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
Mar 10 01:07:36 ubuntu hass[16808]:     raise self._exception
Mar 10 01:07:36 ubuntu hass[16808]:   File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
Mar 10 01:07:36 ubuntu hass[16808]:     result = self.fn(*self.args, **self.kwargs)
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/bmw_connected_drive.py", line 52, in setup
Mar 10 01:07:36 ubuntu hass[16808]:     bimmer = BMWConnectedDriveAccount(username, password, country, name)
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/bmw_connected_drive.py", line 83, in __init__
Mar 10 01:07:36 ubuntu hass[16808]:     self.account = ConnectedDriveAccount(username, password, country)
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/bimmer_connected/account.py", line 54, in __init__
Mar 10 01:07:36 ubuntu hass[16808]:     self._get_vehicles()
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/bimmer_connected/account.py", line 160, in _get_vehicles
Mar 10 01:07:36 ubuntu hass[16808]:     self._get_oauth_token()
Mar 10 01:07:36 ubuntu hass[16808]:   File "/srv/homeassistant/lib/python3.6/site-packages/bimmer_connected/account.py", line 85, in _get_oauth_token
Mar 10 01:07:36 ubuntu hass[16808]:     self._oauth_token = url_with_token['access_token'][0]
Mar 10 01:07:36 ubuntu hass[16808]: KeyError: 'access_token'

My config is
bmw_connected_drive:
  name:
    username: !secret bmw_username
    password: !secret bmw_password
    country: USA

This is not working for USA yet. See #36, #37 and #40 for WIP.

And also #43  :grinning:


Snippet Detail page performance increase

Currently, the snippet detail page is very slow and needs a performance boost. The problem comes from all the extra stuff which has to be done here:

Fetch all Snippet Sets
Get snippets via custom route ({{_action/snippet-set}}) to merge file snippets with database snippets
Ready them to be edited in the admin

Snippets there’s a bunch of snippets, loading can take some time. This is a place were performance can impact a lots of customers

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39894
[created from NEXT-39894, comment 520318]


chore(tests): trigger integration-tests on operator changes

Replaced with https://github.com/lumigo-io/lumigo-kubernetes-operator/pull/109


Add Gitea and Gogs topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I'm changing.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[x] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@ipc103 Did something go wrong? This was merged 3 days ago, but I don't see anything under https://github.com/topics/gitea or https://github.com/topics/gogs.

@JakobDev Just checked and those should be good to go now 👍


Fix issue with user retrieval

Groups admin panel
Description

Fixes #179
Get the User ID from OAuth Proxy instead username.
Adds the ability to retrieve user.

Kfdef

Create a new namespace called opendatahub
In OpenShift, in the Operatorhub section, install the Open Data Hub Operator in the opendatahub namespace.
Once installed, go to Installed operators, click the Open Data Hub card, and inside that, the create instance button.
Select YAML view and replace the code with the one below.

kind: KfDef
apiVersion: kfdef.apps.kubeflow.org/v1
metadata:
  name: opendatahub
  namespace: opendatahub
spec:
  applications:
    - kustomizeConfig:
        repoRef:
          name: manifests
          path: odh-common
      name: odh-common
    - kustomizeConfig:
        parameters:
          - name: s3_endpoint_url
            value: s3.odh.com
        repoRef:
          name: manifests
          path: jupyterhub/jupyterhub
      name: jupyterhub
    - kustomizeConfig:
        overlays:
          - additional
        repoRef:
          name: manifests
          path: jupyterhub/notebook-images
      name: notebook-images
    - kustomizeConfig:
        overlays:
          - authentication
        repoRef:
          name: manifests
          path: odh-dashboard
      name: odh-dashboard
  repos:
    - name: kf-manifests
      uri: >-
        https://github.com/opendatahub-io/manifests/tarball/v1.4.0-rc.2-openshift
    - name: manifests
      uri: 'https://github.com/lucferbux/odh-manifests/tarball/status_issue'

How Has This Been Tested?

Upload this KfDef.
Reload the odh dashboard
Check the logs
Check the request in the frontend

Is there a related PR for odh-manifests changes for the dashboard rbac and oauth-proxy settings?

/lgtm
If I do login with my username mail it is displayed correctly:

The notebook is created with the correct encoding: notebook/jupyter-nb-svelosol-40redhat-2ecom
And no regression for users without mail:


In latest VSCode insiders, typing text fast breaks with Karabiner (crucial for my workflow to work)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:

Version: 1.83.0-insider
Commit: b257cce9e7fa2d5f475ac16c15b40280d0b97957
Date: 2023-09-08T17:38:26.218Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0
Steps to Reproduce:

download https://karabiner-elements.pqrs.org
inside ~/.config/karabiner/karabiner.json put this JSON:

{
  "global" : {
    "ask_for_confirmation_before_quitting" : true,
    "check_for_updates_on_startup" : true,
    "show_in_menu_bar" : true,
    "show_profile_name_in_menu_bar" : false,
    "unsafe_ui" : false
  },
  "profiles" : [ {
    "complex_modifications" : {
      "parameters" : {
        "basic.simultaneous_threshold_milliseconds" : 30,
        "basic.to_delayed_action_delay_milliseconds" : 0,
        "basic.to_if_alone_timeout_milliseconds" : 80,
        "basic.to_if_held_down_threshold_milliseconds" : 50
      },
      "rules" : [ {
        "description" : "test",
        "manipulators" : [ {
          "from" : {
            "key_code" : "a"
          },
          "to" : [ {
            "key_code" : "c"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "n"
          }, {
            "key_code" : "s"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "l"
          }, {
            "key_code" : "e"
          }, {
            "key_code" : "period"
          }, {
            "key_code" : "l"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "g"
          }, {
            "key_code" : "9",
            "modifiers" : [ "left_shift" ]
          }, {
            "key_code" : "0",
            "modifiers" : [ "left_shift" ]
          }, {
            "key_code" : "left_arrow"
          } ],
          "conditions" : [ {
            "name" : "dot-mode",
            "value" : 1,
            "type" : "variable_if"
          } ],
          "type" : "basic"
        }, {
          "type" : "basic",
          "parameters" : {
            "basic.simultaneous_threshold_milliseconds" : 250
          },
          "to" : [ {
            "set_variable" : {
              "name" : "dot-mode",
              "value" : 1
            }
          }, {
            "key_code" : "c"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "n"
          }, {
            "key_code" : "s"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "l"
          }, {
            "key_code" : "e"
          }, {
            "key_code" : "period"
          }, {
            "key_code" : "l"
          }, {
            "key_code" : "o"
          }, {
            "key_code" : "g"
          }, {
            "key_code" : "9",
            "modifiers" : [ "left_shift" ]
          }, {
            "key_code" : "0",
            "modifiers" : [ "left_shift" ]
          }, {
            "key_code" : "left_arrow"
          } ],
          "from" : {
            "simultaneous" : [ {
              "key_code" : "period"
            }, {
              "key_code" : "a"
            } ],
            "simultaneous_options" : {
              "detect_key_down_uninterruptedly" : true,
              "key_down_order" : "strict",
              "key_up_order" : "strict_inverse",
              "key_up_when" : "any",
              "to_after_key_up" : [ {
                "set_variable" : {
                  "name" : "dot-mode",
                  "value" : 0
                }
              } ]
            }
          }
        } ]
      } ]
    },
    "devices" : [ {
      "disable_built_in_keyboard_if_exists" : false,
      "fn_function_keys" : [ ],
      "identifiers" : {
        "is_keyboard" : true,
        "is_pointing_device" : false,
        "product_id" : 834,
        "vendor_id" : 1452
      },
      "ignore" : false,
      "manipulate_caps_lock_led" : true,
      "simple_modifications" : [ ],
      "treat_as_built_in_keyboard" : false
    }, {
      "disable_built_in_keyboard_if_exists" : false,
      "fn_function_keys" : [ ],
      "identifiers" : {
        "is_keyboard" : false,
        "is_pointing_device" : true,
        "product_id" : 834,
        "vendor_id" : 1452
      },
      "ignore" : true,
      "manipulate_caps_lock_led" : false,
      "simple_modifications" : [ ],
      "treat_as_built_in_keyboard" : false
    }, {
      "disable_built_in_keyboard_if_exists" : false,
      "fn_function_keys" : [ ],
      "identifiers" : {
        "is_keyboard" : true,
        "is_pointing_device" : false,
        "product_id" : 34304,
        "vendor_id" : 1452
      },
      "ignore" : false,
      "manipulate_caps_lock_led" : true,
      "simple_modifications" : [ ],
      "treat_as_built_in_keyboard" : false
    } ],
    "fn_function_keys" : [ {
      "from" : {
        "key_code" : "f1"
      },
      "to" : [ {
        "consumer_key_code" : "display_brightness_decrement"
      } ]
    }, {
      "from" : {
        "key_code" : "f2"
      },
      "to" : [ {
        "consumer_key_code" : "display_brightness_increment"
      } ]
    }, {
      "from" : {
        "key_code" : "f3"
      },
      "to" : [ {
        "apple_vendor_keyboard_key_code" : "mission_control"
      } ]
    }, {
      "from" : {
        "key_code" : "f4"
      },
      "to" : [ {
        "apple_vendor_keyboard_key_code" : "spotlight"
      } ]
    }, {
      "from" : {
        "key_code" : "f5"
      },
      "to" : [ {
        "consumer_key_code" : "dictation"
      } ]
    }, {
      "from" : {
        "key_code" : "f6"
      },
      "to" : [ {
        "key_code" : "f6"
      } ]
    }, {
      "from" : {
        "key_code" : "f7"
      },
      "to" : [ {
        "consumer_key_code" : "rewind"
      } ]
    }, {
      "from" : {
        "key_code" : "f8"
      },
      "to" : [ {
        "consumer_key_code" : "play_or_pause"
      } ]
    }, {
      "from" : {
        "key_code" : "f9"
      },
      "to" : [ {
        "consumer_key_code" : "fast_forward"
      } ]
    }, {
      "from" : {
        "key_code" : "f10"
      },
      "to" : [ {
        "consumer_key_code" : "mute"
      } ]
    }, {
      "from" : {
        "key_code" : "f11"
      },
      "to" : [ {
        "consumer_key_code" : "volume_decrement"
      } ]
    }, {
      "from" : {
        "key_code" : "f12"
      },
      "to" : [ {
        "consumer_key_code" : "volume_increment"
      } ]
    } ],
    "name" : "goku",
    "parameters" : {
      "delay_milliseconds_before_open_device" : 1000
    },
    "selected" : true,
    "simple_modifications" : [ {
      "from" : {
        "key_code" : "caps_lock"
      },
      "to" : [ {
        "key_code" : "escape"
      } ]
    } ],
    "virtual_hid_keyboard" : {
      "country_code" : 0,
      "indicate_sticky_modifier_keys_state" : true,
      "mouse_key_xy_scale" : 100
    }
  } ]
}

Then go open VSCode Insiders and press on dot key then press a. You should see this written out:

Instead you will see this on VSCode Insiders:

This only happens in VSCode Insiders.
In normal VSCode it works correctly. As seen below:

I don't know what happened on latest insiders but this breaking is a huge deal breaker for me. Please revert the change.
It seems VSCode Insiders broke entering symbols into the editor fast or something.
Thank you.

If I do this in https://www.keyboardmaestro.com/main/
It also will mess up.

Basically something you've done to editor that completely messes up typing symbols fast. It just eats some symbols completely.
Please please revert this change.

Just to prove its issue with latest VSCode. Here is me doing same action (Karabiner or KM macro insert by typing action)
In sublime text:

In Warp terminal:

Literally all other inputs it works. Just VSCode breaks. Maybe some update to monaco editor breaks it?

Also to prove its a regression with latest VSCode and not any other software, here I try use the insert text by typing in https://www.cursor.sh

As can be seen it enters it correctly.

From scanning the latest commits, I think this commit can be the cause
https://github.com/microsoft/vscode/commit/41e940f76f5deda197bc5930b044c55607ba1cbc
But I can't be sure.
It's a huge deal breaker to my workflow to be able to enter text with typing using programs like KM or Karabiner so please help me resolve the issue.
Thank you lots.

Ok this is a deeper issue.
When I type things normally in VSCode, occasionally VSCode just eats the symbols. I can replicate it 100% of times.

For example, I was just typing normally there.
Specifically I can replicate it when I type t followed by h. The h will never show up. VSCode will not let me enter the symbol.
If I type h alone it works.
This is a huge regression as you can imagine.
Is my env setup:
Version: 1.83.0-insider
Commit: https://github.com/microsoft/vscode/commit/b257cce9e7fa2d5f475ac16c15b40280d0b97957
Date: 2023-09-08T17:38:26.218Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

I can provide any further details needed to resolve it. Thank you and I hope this can be resolved soon.

Okay the issue is actually on @tekezo Karabiner Elements.

Top is with Karabiner Elements quit.
Bottom is with Karabiner Elements active. With Karabiner it eats the symbols up.
Contacting tekezo and seeing how it can be resolved by him.

Tested it on Monaco editor and things worked. It's something with VSCode app itself thats breaking.

Ok I think the issue is with Karabiner Elements latest version, not VSCode as tested on a separate mac.
Described it here: https://github.com/pqrs-org/Karabiner-Elements/issues/3595#issuecomment-1712873313
Will keep the issue open until @tekezo replies. In case he will need information from VSCode team to fix the issue for latest Karabiner version.

Ok I think the issue is with Karabiner Elements latest version, not VSCode as tested on a separate mac.

thank you
I’m closing this issue as you have confirmed it’s not related to vscode
There are other means of communication other than just leaving this issue open


ROMs folder opens with dead symlinks

Continuation of:
https://github.com/Pobega/com.fightcade.Fightcade-ARCHIVE/issues/35

If possible it may be best to request that upstream checks for the existence of /.flatpak-info and changes the folder opened by the ROMs GUI dropdown (to ~/.var/app/com.fightcade.Fightcade/data/ROMs)
In Fightcade:
resources/app/lib/main.js:
    const FcMenu = {
        label: '&ROMs',
        submenu: [
            {
                label: 'Open ROMs Folder',
                 click: () => {
                    ...
                    if (helpers_1.isWindows()) {
                        electron_1.shell.openPath(path.dirname(process.execPath)+'\\..\\ROMs');
                    }
                    if (helpers_1.isLinux()) {
                        electron_1.shell.openPath(path.dirname(process.execPath)+'/../ROMs');
                    }

Looks like the Electron frontend could be patched to support a different ROM directory pretty easily.

It seems like with xdg-desktop-portal 1.8.0 xdg-open is broken and can't open links to $XDG_DATA_HOME. I opened a bug with upstream about it (https://github.com/flatpak/flatpak/issues/3879) and there's an open PR that should hopefully resolve it: https://github.com/flatpak/flatpak-xdg-utils/pull/36

I'm going to squeeze this patch into the beta branch to at least make it available for the time being.

The patch is now in stable (and the beta branch has been dropped.) It should work but I'm waiting on a patch upstream that fixes xdg-open to close this ticket.

This is fixed on Fedora 33 with the new version of xdg-utils


Remove Inhabit Type for upcoming PR

Remove Inhabit Type for upcoming PR to remove Inhabit Type

https://github.com/azerothcore/azerothcore-wotlk/pull/9272

https://github.com/azerothcore/azerothcore-wotlk/pull/9272

https://github.com/azerothcore/azerothcore-wotlk/pull/9272


Support one-to-many redirect with pseudo-inverse relation using a plain Column

To support permissions on -to-many relations, we have a feature in to automatically redirect to collection of the target of the relation, with a collection filter applied.
For example: /invoices/$id/orders becomes /orders?invoice._id=$id
To be able to apply a collection filter on the target domain type, that type needs a reference to the source domain type. (so, a bi-directional relation)
We don’t want to implement full user-configurable bi-directional relations for now, since that requires additional considerations.
The complications of bi-directional relations in JPA:

The inverse side of a relation is read-only: Hibernate does not look at the inverse side of the relation when saving changes
The @ManyToOne relation annotation does not have a mappedBy attribute, so in a bi-directional relation it is always the primary side; @OneToMany will always be the inverse side in a bi-directional relation. Uni-directional @OneToMany is fine and there it can be the primary side.

If we limit the scope of bi-directional relations to the ones required to support permissions on relations:

@ManyToOne: No problem, we redirect directly to the “one” item on the target side, we don’t need filters
@OneToOne: No problem, identical to @ManyToOne
@ManyToMany: No problem, the side on the target entity can be the inverse side. We mark it as not exported, so it’s not visible in the API response, and it’s not writable
@OneToMany: Ouch, according to our model we need a @ManyToOne on the inverse side, but from the perspective of JPA, that needs to be the primary side. That would mean that API users can’t write to the relation anymore from the primary side of the model (and the other side is not visible in the API)

To solve this problem, we need to keep the @OneToMany side the JPA primary side. Technically, the data is stored in the table of the target. We point there with a @JoinColumn annotation.
Since technically the data is already present on the table of the target entity, we should be able to access it from that side as well, but we can’t make it a @ManyToOne relation. Since it is stored in the table of the entity, a plain @Column annotation enables us to pull the data in.
It is a bit of a wonky setup, but if we take care to only read data from there, and don’t rely on it being updated within the same JPA session, it should be fine.
Since writing and reading data always happens from separate HTTP requests, we can be sure that they are separate sessions and we don’t need to worry about this.

Do we have somewhere test coverage for when @Column is not present?

Do we have somewhere test coverage for when @Column is not present?

Not at this point. The current behavior should be to ignore fields where no @Column is present, even when the derived column name on the other side would match the @JoinColumn annotation


Update integrations

add Watchtower and Mailrise as official integrations
added new section for projects integrating via JSON publishing
sorted all entries

Sorry for not responding earlier. Now it's out of date and in conflict.
Can you just add the entries that you wanted to add, and I'll do the sorting when I have time. It's impossible to review like this. It's too much.

@binwiederhier fixed 🙂

@binwiederhier

Sorry for the delay again. So I finally had time to review those suggestions, and normally it's a nobrainer to merge stuff into this list. But for your suggestions, I cannot find a single one of these that actually integrates with ntfy. I browsed their websites and searched Google for "jellyfin ntfy" and such. Nada. Am I missing something?

Sorry for the confusion. I specifically added them to a separate section because these projects prefer to use a generic JSON structure for publishing notifications. I tried to link their documentation where possible and linked the section title to https://docs.ntfy.sh/publish/#publish-as-json
While these integrations don't have the  "officially supports  ntfy" status, it can be easily set up and is the prefered way of integrating ntfy from the standpoint of these projects.
And i have a single link to post on Reddit, Mastodon etc without having to explain that "xy works perfectly fine, you just need zo..."

I don't think I feel comfortable saying things are "officially supported" if they do not have the ntfy name somewhere on their website or in the product. Because that would mean that I could add all the things that can post HTTP requests.
I think the "Examples" page is perfect for this stuff. Though you'd need more than just listing the names of the project. I'd love to accept more examples.


chore: Add off-logo-icon-light.svg to assets cache

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.62%. Comparing base (4d9c7fc) to head (8be01aa).
Report is 116 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5255      +/-   ##
==========================================
- Coverage     9.54%   8.62%   -0.93%
==========================================
  Files          325     329       +4
  Lines        16411   16713     +302
==========================================
- Hits          1567    1441     -126
- Misses       14844   15272     +428

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @g123k! A bit surprised to see this file in assets/cache, as a probable duplicate of files from assets/app.

This warning is visible with the "moderator" KP and I totally agree with you, that's just an icon.
Should we do an exception here? Or simply put it on the cache folder (just as this PR)?

This warning is visible with the "moderator" KP and I totally agree with you, that's just an icon. Should we do an exception here? Or simply put it on the cache folder (just as this PR)?

I hadn't read the issue: as it says AssetCacheHelper:	 please download https://static.openfoodfacts.net/images/logos/off-logo-icon-light.svg and put it in asset somewhere like [assets/cache/off-logo-icon-light.svg, assets/cacheTintable/off-logo-icon-light.svg], the file is really useful in the cache folder.


[USAToday] [Brightcove] USAToday not supported falls back on generic

youtube-dl -v http://www.usatoday.com/story/news/2016/02/21/ex-nsa-chief-backs-apple-iphone-back-doors/80660024/

[debug] System config: []
[debug] User config: [u'--download-archive', u'~/.ytdlarchive', u'--retries', u'100', u'--no-overwrites', u'--call-home', u'--continue', u'--write-info-json', u'--write-description', u'--write-thumbnail', u'--write-annotations', u'--all-subs', u'--sub-format', u'srt', u'--convert-subs', u'srt', u'--write-sub', u'--add-metadata', u'-f', u'bestvideo+bestaudio/best', u'--merge-output-format', u'mkv', u'--embed-subs', u'--prefer-ffmpeg', u'--embed-thumbnail']
[debug] Command-line args: [u'-v', u'http://www.usatoday.com/story/news/2016/02/21/ex-nsa-chief-backs-apple-iphone-back-doors/80660024/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.02.22
[debug] Python version 2.7.10 - Linux-4.2.0-30-generic-x86_64-with-Ubuntu-15.10-wily
[debug] exe versions: ffmpeg 2.7.6-0ubuntu<IP_ADDRESS>, ffprobe 2.7.6-0ubuntu<IP_ADDRESS>, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Public IP address: <IP_ADDRESS>
[generic] 80660024: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 80660024: Downloading webpage
[generic] 80660024: Extracting information
ERROR: Unsupported URL: http://www.usatoday.com/story/news/2016/02/21/ex-nsa-chief-backs-apple-iphone-back-doors/80660024/
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 1308, in _real_extract
    doc = compat_etree_fromstring(webpage.encode('utf-8'))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 248, in compat_etree_fromstring
    doc = _XML(text, parser=etree.XMLParser(target=etree.TreeBuilder(element_factory=_element_factory)))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 237, in _XML
    parser.feed(text)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: syntax error: line 1, column 0
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 666, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 316, in extract
    return self._real_extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 1950, in _real_extract
    raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://www.usatoday.com/story/news/2016/02/21/ex-nsa-chief-backs-apple-iphone-back-doors/80660024/

USAToday now uses some custom scripts to load the Brightcove player, so an individual extractor is necessary.
Before this site is implemented, use the following Brightcove URL to download this video:
youtube-dl -vF "http://c.brightcove.com/services/viewer/federated_f9?playerID=3700942850001&@videoPlayer=ref:80701170"

will be supported in the next version.

Thanks!


I can't activate sessions in Lumen

Hi, i configured my app with lumen and i want to activate sessión with db. I uncomment next lines:
$app->middleware([
Illuminate\Session\Middleware\StartSession::class,
Illuminate\View\Middleware\ShareErrorsFromSession::class
]);
And I added the service provider:
$app->register(Illuminate\Session\SessionServiceProvider::class);
Too add parram in .env file:
SESSION_DRIVER=database
But I get the next error:
Unresolvable dependency resolving [Parameter #0 [  $app ]] in class Illuminate\Support\Manager
Please help me! my project is versioned in github:
https://github.com/MiguelPazo/ecep_service

You're using Lumen v5.2.
From this version on, views and sessions are no longer included.
Mind release notes

Views are actually still included in lumen 5.2.

They got added back in 5.2.1 or something.

rtucek, i change to lumen 5.0, but now i get next error:
Argument 1 passed to Illuminate\Session\Middleware\StartSession::addCookieToResponse() must be an instance of Symfony\Component\HttpFoundation\Response, string given, called in D:\xampp\htdocs\ecep_service\vendor\illuminate\session\Middleware\StartSession.php on line 72 and defined

lumen 5.0 is not supported

Then, what version should i use?

5.1.x LTS is currently supported, as is 5.2.x stable.

Ok, thanks you! :+1:

@GrahamCampbell what is the date of the 5.2.1 release?

@GrahamCampbell   as you said "They got added back in 5.2.1 or something.", but my lumen version is Lumen (5.2.7) (Laravel Components 5.2.*), it is the same issue Unresolvable dependency resolving [Parameter #0 [ $app ]] in class Illuminate\Support\Manager

Got this, too?!
What is the special, currently undocumented way to integrate a CSRF Token Validation to an RESTful framework?!

I've the same issue...

I have the same issue, I using 5.8

@coderiki Sessions are not included out of the box in Lumen 5.8.

@coderiki lo legraste solucionar tengo el mismo error y nose como solucionarlo

Now I'm upgrading Lumen5.1 to 5.2 and getting the same issue.
"Unresolvable dependency resolving [Parameter #0 [ $app ]] in class Illuminate\Support\Manager"
How did you fix this error?
Thanks.


Thanks

I saw Brian's talk on Mostjs last July in SF. I gave it a shot and it's worked really impressively well for me since then.
Thanks for everyone working on this great library!

@hath995 Thank you for these kind words.  It's very nice to hear that mostjs has been helpful to you.


Add an option to disable JSDoc parsing

Feature description
Add an option to disable JSDoc parsing, the default should be true. This is to give a bit more flexibility to the tool and should be a quick addition.
// cli.ts
parseJSDoc: flags.boolean({
      default: true,
      description: "Create zod validators from JSDoc annotations",
    }),

Closed by #62


keep OverlayView fixed to a position

Not sure why i'm having such a tough time with this, but i'm trying to keep  always in the top right of the map.
Currently when I pan the map around the  pans with it - any was to anchor this?
Effectively i'm trying to use OverlayView as a custom map control, hence they should stay anchor to the corners.

The OverlayView is not designed for this task. Please consult other solutions.

Please refer to Getting Help section in the README (or #469).


stylix.fonts.emoji breaks wezterm emoji

stylix.fonts.emoji seems currently only used in wezterm.
however, setting this for some fonts like stylix.fonts.emoji = { pkgs.twemoji-color-font; name = "Twitter Color Emoji"; }, seems to in fact break emoji on wezterm, instead falling back to noto-fonts-monochrome-emoji instead.

Looks related to wez/wezterm#4713

thanks, let's close in favor of that one then


v0.0.4 - Library Implementation

restore color if change unsuccessful
new task modification interface
new tasks:

Play audio file
Open file
Open website (limited to certain OS's)
Execute jar file

App Icon
log.dir
log.skipQueue
log.enabled
handles logging on separated thread
implemented Library

Approved


[Bug]-[400]:Tab titles cut into text

Is there an existing issue for this?

[X] I have searched the existing issues

Description

Tabs appears to be cutting off a portion of the text.  The first screenshot is from my screen, the second is from one of the users of the same widget.
Steps To Reproduce
Create a tabs widget
Add a tab
Add another tab title "Send to Shipping"
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

@rajatagrawal small issue here! Check if you have the time!

Can I work on this?

Hi @eedwardsSGS  , I reproduced this issue it looks fine, I tested it with all the available options and responsiveness as well and it is not breaking, is there any specific scenario with available options where  its breaking ? please mention I will test.

@Prateek32177 that's strange.  I have a copy of my app shared with the appsmith team here.  Settings are:

And it is pretty clearly cutting off the bottom of this 'g' on my screen.

(Worse on my team member's screen).
It may be an interaction with the browser.  I'm viewing it on Firefox (because Chrome has such poor performance when editing in Appsmith), when I view in Chrome it looks fine.

The second part is reproducible
Stats

Stat
Values

Reach
400

Effort (months)
0.5

I am able to replicate this, can I work on this?

@priyanka-mahour thanks for showing interest, feel free to pick this up

Please review this fix https://github.com/appsmithorg/appsmith/pull/22486/commits/f39bb4c5fe1784c9f581367237afd26cce825f0f

@somangshu can you help get this fix added to our repo so that we can test it?


add heading tags to const DOMElements

As mentioned here heading tags are currently not included in DOMElements. This pr adds h1-h6 to the constant.

Looks good to me. My bad on missing those!

Lovely :-)
I probably should have checked if there were other valid html-elements missing in the list. It's a bit tricky since valid html-tags are a bit of a moving target, and maybe it shouldn't be the responsibility of dom-expression to keep track of the spec? There is a package called [html-tags](https://www.npmjs.com/package/html-tags] which we could depend on to do this work for us.


Apicurio registry support

Discussed in https://github.com/provectus/kafka-ui/discussions/1177

Originally posted by smeana December  7, 2021
Hello
We are trying to have the UI working with Apicurio but the UI cant deserialize the avro messages.
Any advise on how to integrate Apicurio?
regards

Related #1098

@smeana could you please follow debugging instructions from #1098?

I've been looking at the same thing: Plugging in Apicurio.
I've set the following when running Docker:
 -e KAFKA_CLUSTERS_0_SCHEMAREGISTRY=http://host.docker.internal:8080/apis/registry/v2
and I see the following in the logs for my APIcurio server:
2022-01-04 15:14:50 INFO <_> [io.apicurio.registry.logging.audit.AuditLogService] (executor-thread-256) registry.audit action="request" result="failure" src_ip="null" path="/apis/registry/v2/subjects" response_code="404" method="GET" user=""
So it looks like Kafka-UI has an expectation of a path that APIcurio isn't serving?

@barnyrelph hey, thanks for the feedback. Could you please answer the same questions posted here?

a working example with Apicurio: #1621


Fix/delete extra customdata

We fixed an issue where mx client would throw maximum call stack exceeded.

Codecov Report

Merging #99 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   49.07%   49.04%   -0.04%
==========================================
  Files          29       29
  Lines        1357     1358       +1
  Branches      362      362
==========================================
  Hits          666      666
- Misses        691      692       +1

Impacted Files
Coverage Δ

src/components/PlotlyChart.ts
7.47% <0%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed99b7e...81d0fcd. Read the comment docs.


[RAF] fix: it's running the loops twice

It's running the loops twice when calling manually to start() without setting runImmediately to false
runImmediately is to true by default. This means that the loop would be running. If you then call start() like in the example provided
const [running, start, stop] = createRAF(() => console.log('hi')));
start();

Then you will have two loops running, as start() doesn't check if the RAF is currently running. The animation will run twice as fast.
disclaimer: I only tested this on the playground provided by manually calling start() right after createRAF

Good catch, thanks! I'll publish now as well.

Version 1.0.9 includes the patches and is now published.


Estimated time calculation in the progress text [Feature Request]

Request for a estimated time calculation along with Duration within progress text while ffuf is running, this would be really helpful while fuzzing a huge list. Thanks 😃

I agree that it'd be really beneficial. Unfortunately the progress bar space is already really tight unless you are running terminal full screen. I'll add a feature request label so we can track this in the future if there's a possibility of adding it.


[Feature Request] Log in progress

Hi, thnx for great plugin.
I have feature request. Can you add display log of current build in realtime for tasks that in running status? I have a lot of work with debug build script on Jenkins and this feature will be very useful.

I will have a look at the API for this

Accessing Progressive Console Output
You can retrieve in-progress console output by making repeated GET requests with a parameter. You'll basically send GET request to https:///<job_path>/<build_number>/logText/progressiveText?start=0 (or https:///<job_path>/<build_number>/logText/progressiveHtml?start=0 if you want HTML that can be put into  tag.) The start parameter controls the byte offset of where you start.
The response will contain a chunk of the console output, as well as the X-Text-Size header that represents the bytes offset (of the raw log file). This is the number you want to use as the start parameter for the next call.
If the response also contains the X-More-Data: true header, the server is indicating that the build is in progress, and you need to repeat the request after some delay. The Jenkins UI waits 5 seconds before making the next call. When this header is not present, you know that you've retrieved all the data and the build is complete.

Thanks for the hint

This is very much needed

we use this lib: https://github.com/jenkinsci/java-client-api
I have a look if it offers a realtime log
If not either I change to GET call or try to implement it in the lib

I will change to stream log and build an eap version the days.
see https://github.com/jenkinsci/java-client-api/blob/ddf6a850beacf79480280c0c3c067bf73d84bca5/jenkins-client/src/main/java/com/offbytwo/jenkins/model/BuildWithDetails.java#L395

It takes still some time. Currently working on it. Have to change the Console View too
Sorry for circumstances

I've created an EAP version for 2020.3
If you need other version for eap please let me know
EAP: https://plugins.jetbrains.com/plugin/6110-jenkins-control-plugin/versions/eap/102637
Or you can add plugin repo: https://plugins.jetbrains.com/plugins/eap/list
The log could be stream with "Show last log" for running builds. A new Tool window is open with the content
It would be great if you can leave feedback for the feature

Thnx very much. It works.
Maybe in feature automatically open this window when build starts, but it's feature improvement.
Now log work correct and fast.

Thanks for feedback. Automatically open on build i'm working on. I can be delayed because it is first in queue and after time it is running
But with this request it should be included

a new EAP is available.
The Log is shown if new Build is triggered and after automatically reload a newer one is running. If the new triggered build is queued or there multiple builds it nor works for all cases. This could be an additional improvement (in my opinion)
EAP: https://plugins.jetbrains.com/plugin/download?rel=true&updateId=103042
Thanks for feedback

Released with 0.13.10


[feature request] injecting weak load commands?

would it be possible to add an optional arg to insert_load_command to insert a load command as an LC_LOAD_WEAK_DYLIB instead of an LC_LOAD_DYLIB ?

Hey there!
I don't see any particular problems with getting weak load commands supported here.
Although the current implementation of generate_dylib_load_command () is, to put it gently, a bit of a hack that works by duplicating one of the existing load commands as a template for a new one, instead of creating a brand new load command from scratch. I can't remember the exact reason why I went this direction, but it has something to do with big vs little endianness issues (and my weak Python skills at the time of writing the code) I guess? Anyway, you may want to refactor this function so it doesn't depend on existing load command at all – because otherwise you'll need your target binary to already have at least one weak LC, which is a rarity.
Happy to review your PR, feel free to submit one!


HTTP Error 502.5 - Process Failure ASP.Net Core2 after update to Microsoft.EntityFrameworkCore -Version 2.0.0 #7462

From @embryologist on August 17, 2017 2:20
Steps to reproduce
ARTSQLCORE.zip
`dotnet --info` output:
ARTNetCore> It was not possible to find any compatible framework version
ARTNetCore>
ARTNetCore> The specified framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
ARTNetCore>
ARTNetCore>   - Check application dependencies and target a framework version installed at:
ARTNetCore>
ARTNetCore>       \
ARTNetCore>
ARTNetCore>   - Alternatively, install the framework version '2.0.0'.
ARTNetCore>
ARTNetCore> It was not possible to find any compatible framework version
ARTNetCore>
ARTNetCore> The specified framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
ARTNetCore>
ARTNetCore>   - Check application dependencies and target a framework version installed at:
ARTNetCore>
ARTNetCore>       \
ARTNetCore>
ARTNetCore>   - Alternatively, install the framework version '2.0.0'.
ARTNetCore>
ARTNetCore> It was not possible to find any compatible framework version
ARTNetCore>
ARTNetCore> The specified framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
ARTNetCore>
ARTNetCore>   - Check application dependencies and target a framework version installed at:
ARTNetCore>
ARTNetCore>       \
ARTNetCore>
ARTNetCore>   - Alternatively, install the framework version '2.0.0'.
ARTNetCore>
ARTNetCore> It was not possible to find any compatible framework version
ARTNetCore>
ARTNetCore> The specified framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
ARTNetCore>
ARTNetCore>   - Check application dependencies and target a framework version installed at:
ARTNetCore>
ARTNetCore>       \
ARTNetCore>
ARTNetCore>   - Alternatively, install the framework version '2.0.0'.

I installed Microsoft.NETCore.App -Version 2.0.0 yet when I run the app I get this msg,

HTTP Error 502.5 - Process Failure
Common causes of this issue:
The application process failed to start
The application process started but then stopped
The application process started but failed to listen on the configured port
Troubleshooting steps:
Check the system event log for error messages
Enable logging the application process' stdout messages
Attach a debugger to the application process and inspect

Copied from original issue: dotnet/corefx#23320

From @karelz on August 17, 2017 21:59
Do you have a minimal repro? The attached project is rather large and hard to debug.

Should this get moved to https://github.com/aspnet?

From @embryologist on August 18, 2017 2:30
@karelz, how can I provide you with a minimal one?

how can I provide you with a minimal one?

you can zip it and attach it to github here or put it on OneDrive and send a link

From @karelz on August 18, 2017 16:19
Or make it so minimal, that the code modifications to default template fit here as source code ... that would be ideal

From @embryologist on August 19, 2017 0:25
I believe its <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.0" />
I think updating it ti version 2 with the current Asp.Net Core Preview creates a conflict.  downgrading solved the problem

@tarekgh , Thanks so much, Please close the issue,
To run Core2 version 2 I updated my visual studio and the sdk, everything return back to normal.
Please close the issue