added valgrind verb

Haven't properly tested this yet, but if valgrind is not found it shows a '/bin/sh: valgrind: command not found' on OSX and a similar message on Windows (which is good, at least it's not a cryptic python crash).
Thanks!


[Docs] Fix sft mistakes

Fixes https://github.com/huggingface/trl/issues/714
Fixes issues here and there regarding docs about SFTTrainer, in fact, the trainer does not support some args such as torch_dtype
cc @lvwerra @vwxyzjn

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Minor Elemental Options hidden behind other Infusion

After getting 6 infusions for the Inventor class, part of the slide-up options for Minor Elemental get hidden behind another infusion above it so you cannot select lightning or thunder.  See the screenshot, the options lightning and thunder are hidden behind Replica Boots of Striding and Springing.

Share your save please. You can zip and attach here.

Share your save please. You can zip and attach here.

Here you go.
New Adventure - Lost Valley.zip

Thanks. Fixed.


Line length configurable?

Couldn't find how to configure line length? Especially annoying with tailwind, want to just keep all class names on same line. Thanks!

If you're using erb-formatter from the command line you can pass -h and get the full list of options:
$ erb-formatter -h
Usage: /Users/elia/.asdf/installs/ruby/3.3.0/bin/erb-formatter FILENAME... --write
    -w, --[no-]write                 Write file
        --stdin-filename FILEPATH    Set the stdin filename (implies --stdin)
        --[no-]stdin                 Read the file from stdin
        --print-width WIDTH          Set the formatted output width
        --single-class-per-line      Print each class on a separate line
        --tailwind-output-path PATH  Set the path to the tailwind output file
        --[no-]debug                 Enable debug mode
    -h, --help                       Prints this help
    -v, --version                    Show ERB::Formatter version number and quit

You can use the --print-width option to control line length, e.g. erb-formatter --print-width 120 --write my-file.erb.
Happy to reopen the issue if you need more info 👍

i'm using erb-formatter as a part of conform, and i'm wondering if i can pass the option in through my configuration. I will try that option tho!


refactor the params tests...

These need a refresh to make them like the segments. Compact, dense, and sprawling in coverage.

Done


Update UG tone

Updated areas:

Getting Started
UI Overview
Command Overview
Help Command
Add Command
List Command

Format and tone look and sound clean. Some clarifications on some potential documentation bugs:

When I use the pay command, there is no more clear debt button, even though the image in the UG still shows it
The split command limits the split amount across individuals to 10,000. Is this a typo for 100,000?


ReferenceGrant %s not owned by this object

I'm trying to run knative with cilium as a gateway. My scheme involves per namespace certificates generated by certmanager DNS01 challenge (wildcard TLS). I can start one ksvc with my configuration. But starting yet another ksvc in the same namespace just fails with ReferenceGrant %s not owned by this object. Seems like autoTLS with wildcard certs is just not supported by the current plugin. I see no options to overcome it.
My knative instance is deployed with operator:
apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  ingress:
    istio:
      enabled: false
  config:
    network:
      ingress-class: "gateway-api.ingress.networking.knative.dev"
      domain-template: "{{.Name}}.{{.Namespace}}.{{.Domain}}"
      auto-tls: "Enabled"
      http-protocol: "Redirected"
      default-external-scheme: "https"
      namespace-wildcard-cert-selector: "{\"matchExpressions\": [{\"key\":\"networking.knative.dev/enableWildcardCert\", \"operator\": \"In\", \"values\":[\"true\"]}]}"

Gateways:
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: knative-ingress-gateway
  namespace: kube-system
spec:
  gatewayClassName: cilium
  listeners:
  - protocol: HTTP
    name: http
    port: 80
    allowedRoutes:
      namespaces:
        from: All
---
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: knative-local-gateway
  namespace: kube-system
spec:
  gatewayClassName: cilium
  listeners:
  - protocol: HTTP
    name: http
    port: 8081
    allowedRoutes:
      namespaces:
        from: All

Gateway config:
apiVersion: v1
kind: ConfigMap
metadata:
  name: config-gateway
  namespace: knative-serving
data:
  external-gateways: |
    - class: cilium
      gateway: kube-system/knative-ingress-gateway
      service: kube-system/cilium-gateway-knative-ingress-gateway
      supported-features:
      - Gateway
      - GatewayPort8080
      - GatewayStaticAddresses
      - HTTPRoute
      - HTTPRouteDestinationPortMatching
      - HTTPRouteHostRewrite
      - HTTPRouteMethodMatching
      - HTTPRoutePathRedirect
      - HTTPRoutePathRewrite
      - HTTPRoutePortRedirect
      - HTTPRouteQueryParamMatching
      - HTTPRouteRequestMirror
      - HTTPRouteRequestMultipleMirrors
      - HTTPRouteResponseHeaderModification
      - HTTPRouteSchemeRedirect
      - Mesh
      - ReferenceGrant
      - TLSRoute
  local-gateways: |
    - class: cilium
      gateway: kube-system/knative-local-gateway
      service: kube-system/cilium-gateway-knative-local-gateway
      supported-features:
      - Gateway
      - GatewayPort8080
      - GatewayStaticAddresses
      - HTTPRoute
      - HTTPRouteDestinationPortMatching
      - HTTPRouteHostRewrite
      - HTTPRouteMethodMatching
      - HTTPRoutePathRedirect
      - HTTPRoutePathRewrite
      - HTTPRoutePortRedirect
      - HTTPRouteQueryParamMatching
      - HTTPRouteRequestMirror
      - HTTPRouteRequestMultipleMirrors
      - HTTPRouteResponseHeaderModification
      - HTTPRouteSchemeRedirect
      - Mesh
      - ReferenceGrant
      - TLSRoute

The plugin generates a ReferenceGrant:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: ReferenceGrant
metadata:
  creationTimestamp: "2024-10-17T13:44:17Z"
  generation: 1
  name: default.example.io-kube-system
  namespace: default
  ownerReferences:
  - apiVersion: networking.internal.knative.dev/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: Ingress
    name: hello
    uid: 3149c0ac-f6a8-47c3-8b5a-78955ada0a7b
  resourceVersion: "1113699"
  uid: 53784654-8e98-45ba-a0e7-93c50882b05a
spec:
  from:
  - group: gateway.networking.k8s.io
    kind: Gateway
    namespace: kube-system
  to:
  - group: ""
    kind: Secret
    name: default.example.io

As you might see, it has ownerReference of the first ksvc i have deployed. Deploying anything else fails.
Is there a way to overcome this? I've tried to create a ReferenceGrant manually, but ksvc deployment still fails with the same error, because it's not owned by it.

The problem is that MakeReferenceGrant always creates it with same name in my case: https://github.com/knative-extensions/net-gateway-api/blob/main/pkg/reconciler/ingress/resources/reference_grant.go#L29
You should probably add the ingress name there or check if we already have this grant for other services, idk.


AddServiceDial

Add service dial, error codes, and some typo corrections.

we don't want any content in the older docfx site. these should be moved to the /docusaurus doc instead please

Closing this DocFX PR in favor of its Docusaurus counterpart.


Multiple seek points

Would it be possible to add multiple seek points on the slider?
example: http://www.smarthome.com/media/catalog/product/cache/1/thumbnail/9df78eab33525d08d6e5fb8d27136e95/i/o/ios_-_thermostat.jpg

I have the same question, is that possible or we need to add this functionallity?


Calendar is working good in iOS but for android it has bug in initial month view.

I am trying to use calendar in iOS and android apps. But in android app, its seems to be error in initial month. Its setting date form wrong day. If I click on next or prev and then come back to initial screen, then it fixes. What might be missing in setting up initial month view?

I have removed "scrollEnabled={true}" from calendar tag and it worked. I wrote the following.
<Calendar
ref="calendar"
scrollEnabled={true}
showControls={true}
dayHeadings={customDayHeadings}
titleFormat={'MMMM YYYY'}
prevButtonText={'Prev'}
nextButtonText={'Next'}
onDateSelect={(date) => this.setState({selectedDate: date})}
onTouchPrev={() => console.log('Back TOUCH')}
onTouchNext={() => console.log('Forward TOUCH')}
onSwipePrev={() => console.log('Back SWIPE')}
onSwipeNext={() => console.log('Forward SWIPE')}/>

I saw the same issue yesterday. Please reopen, this is a workaround, not a fix.
I still have the issue with RN 0.28 on android. We are in june and on the first load, it goes to april but with the title of june. And indeed, if scrollEnabled is false, the issue goes away.
I think the issue may be in scrollEnded function. If somebody want to look at it.

Another issue I found on android is that when I swipe to go to next month, it decrements the month instead of incrementing it. I think it may be related.

@devekoperiOS I realize the same thing yesterday.

Temporary solution can be disabling scrolling.

Yes, thank you!

It seems that i've got the same issue on iOS real device.
Disabling scrolling temporary fixed it.

removing scrollEnabled={true} fixed this issue, any solution?

And also I found that by adding showControls={true} the titleFormat will be broken too.
Without showControls the title shows August 2016, but with showControls the title shows Aug 2016

I also encountered the problem and figured out how to use it with scrollEnabled if anyone's interested.
The way it works in the code is that the ScrollView has 5 elements pre-rendered, from [month-2, ..., month+2]. So you have to call this.scrollToItem(2) for it to scroll to index 2, the current month.
When the Calendar mounts, it tries to scroll in componentDidMount(), however you cannot scroll in componentDidMount as at this point some animations will still be run (see here).
So the solution is to call this.scrollToItem(VIEW_INDEX) after running the animations.
TL;DR
Change the line in Calendar.js
componentDidMount() {
      this.scrollToItem(VIEW_INDEX)
}

to
import {...,
  InteractionManager
} from 'react-native';
componentDidMount() {
     InteractionManager.runAfterInteractions(() => {
      this.scrollToItem(VIEW_INDEX)
    })
}

I might create a pull request later.

I had a similar issue where the Calendar would not render when scrollEnabled was set to false.
The View container that wraps the calendar days needs to have a style change in order to work.
{this.props.scrollEnabled ? (
  <ScrollView
    ...
  >
    {calendarDates.map((date) => this.renderCalendarView(this.props.calendarFormat, moment(date), eventDatesMap))}
  </ScrollView>
 ) : (
  <View style={{flex: 1}} ref={calendar => this._calendar = calendar}>
    {calendarDates.map((date) => this.renderCalendarView(this.props.calendarFormat, moment(date), eventDatesMap))}
  </View>
)}

I added the style={{flex: 1}} to the  container (when there is no ScrollView) and it fixed my problem. Hopefully this will help someone else


Make command replies consistent with requests

resolves #22
I added $ character to each command reply.
It might be unnecessary in some conditions like replies to commands with wrong number of arguments.
In general I think it's good anyway to easily distiguish between messages

Hello @macvenez, checking your PR I think we could go the Redis protocol route. What about:
Starting the reply with "+" in case of successful reply. "-" in case of errors?
Also, please note that there is a small problem in the PR in the case of the .join() call when generating the command list.

Great. Thanks. The problem with join is only here AFAIK:
    send_reply("$, ".join(self.fw.keychain.list_keys()))

>>> "$, ".join(["a","b","c"])
'a$, b$, c'

Alright, now I see it, that should be easily fixable with:
send_reply("$"+", ".join(self.fw.keychain.list_keys()))
of course that $ should be a +


Use underlying library to decide which verifier to use based on header.

#454 On the authenticator side I think the better approach is to use the underlying api to decide which verifier to use based on the header. On the generator side you are in control so I don't think you need an abstraction. Now except for the original MacVerifier I'm not sure how to create a Key but I think that's up to whoever injects the key into the authenticator.. I preserved existing functionality allowing secret key to be converted to SecretKey.

Opened another pull request that allows keys to be specified in PEM format


The End Client can specify the time period to get electricity information about

AS A Product Owner
I WANT the end client to be able to specify a time period to get electricity information about
SO THAT they can receive data for a custom range of dates
Acceptance Criteria

[ ] The End Client can specify the time period to get electricity information about
[ ] The system should allow the end client to specify a start and end date for the desired time period
[ ] The system should handle different time periods such as days, weeks, or months

Added time-period service.
[80-electricity-service][https://github.com/buerokratt/Common-Services/tree/80-electricity-service]

Code added straight to https://github.com/buerokratt/Common-Services/issues/80 without pull requests

As of right now, will proceed using only information about "today".


Set VBAProject Name on Make Config File

When Make Config File is run, the VBAProject Name property of the config file should be set to the current project name in the workbook.

So I'm looking at modImportExport.bas and Public Sub MakeConfigFile() correct?
And from there I'm not sure where prjActProj should go...
MakeConfigFile() is a really nice looking peice of code @mattpalermo :+1:

The Config object represents the configuration. This object (and the clsConfiguration class) has a VBAProjectName property that will get and set the configuration VBAProject Name in the configuration for you. It's just a matter of putting Config.VBAProjectName = .... somewhere in the MakeConfigFile procedure.
Thankyou :) I am quite happy with how the separation of concerns between modImportExport and clsConfiguration turned out!


[v6] Route path matching is not intuitive: take "apple/applet" as an example

Version
6.0.0-beta.0
Test Case
https://codesandbox.io/s/react-router-v6-fhefl
Steps to reproduce
In the sandbox above, click on the Apple and Applet link.
Expected Behavior
When I click on the Applet link, I hope it could redirect to NotFoundPage, not ApplePage.
Actual Behavior
When I click on the Applet link, it redirects to ApplePage. The behavior is not intuitive.
Extra
import React from "react";
import { BrowserRouter, Routes, Route, Navigate, Link } from "react-router-dom";

function HomePage() {
  return
🏠 Page
;
}

function NotFoundPage() {
  return
🧐 Page
;
}

function ApplePage() {
  return
🍎 Page
;
}

export default function App() {
  return (
    <BrowserRouter>

        <Link to="/" className="link">
          Home
        </Link>
        <Link to="/apple" className="link">
          Apple
        </Link>
        <Link to="/applet" className="link">
          Applet
        </Link>
        <Link to="/test" className="link">
          Test
        </Link>

      <Routes>
        <Route path="/" element={<HomePage />} />
        <Route path="/404" element={<NotFoundPage />} />
        <Route path="/apple">
          <Route path="/" element={<ApplePage />} />
          <Route path="*" element={<Navigate replace to="/apple" />} />
        </Route>
        <Route path="*" element={<Navigate replace to="/404" />} />
      </Routes>
    </BrowserRouter>
  );
}

Duplicate of #7529

Duplicate of #7529

Hi, Tim, I already looked at #7529 before opening this issue. I think this issue is a little different from that one, therefore I opened a new one.

Hi, Tim, I already looked at #7529 before opening this issue. I think this issue is a little different from that one, therefore I opened a new one.


Database set up

Plan for this is to setup another docker container for hosting a db server. Might look into using graphene and graphene-sqlalchemy.


Reading file that is constantly being modified causes a crash

I have a log file of 27 MB to which messages are constantly being written. If I open with Code, then it will crash after about 2-3 seconds.

@bpasero I think we always read the entire file content again when the file changes on disk, right?
We need to investigate if we have any memory leaks that cause this OOM

@npandrei is this file open all the time in the editor?

@bpasero Yes, the file is opened all the time in the editor.

@alexandrudima in that case, yes the file is being read from disk everytime there is a change. I am not sure how this could be optimized and yeah there is a chance of leakage during this process. It should be easy to capture this from the profile tab in the inspector actually.

This looks like a good chance for endgame leak testing.

I don't see leakage with a smallish file (80KB) which shows in the editor and updates every 100ms. My guess is that during the event we open the file while we still have its old contents in memory - so effectively doubling the size and thereby killing it
var uuid = require('node-uuid');
var fs = require('fs');
var path = require('path');

console.log('starting');

setInterval(() => {
	try {
		fs.appendFileSync(path.join(__dirname, 'large.txt'), uuid.v4() + '\n');
	} catch (e) {
		console.error(e);
	}

}, 100);

Profiling what happens reveals a few (low hanging) performance issues.

StopWatch#start/stop is slow (it uses the performance.now which takes too long for what it does)
BaseTextEditorModel#update first run Model#getValue before Model#setValue (to check for changes) which is a big hit on perf (20%). Also that extra string will put pressure on the heap.

large_file_update.cpuprofile.zip

@bpasero/@alexandrudima I suggest you guys find a better way of comparing a string with an existing model (without constructing the whole model string)

@alexandrudima I pushed the change to avoid getValue() but I am leaving it up to you to change something about StopWatch

I have removed the usage of performance.now() from the tokenization. I think there are still some good optimization opportunities in this case, such as:

stream the contents of the file (this would help in all cases)
detect specifically the content appended case (such as log files that get content added at the bottom) and don't create a new view model, but translate the diff into a model edit.

@alexandrudima yes +1 for post GA :)

@alexandrudima interesting thought about the model append case, I wonder if the setValueIfChanged() method could be smart about the RawText that I insert: it could detect the append case and do a model edit that would even preserve the undo history.
I wonder how common the append case is in real life work though...

This no longer reads to a crash. I have tested with:
Generate the initial large file
var fs = require('fs');

var contents = [];
for (var i = 0; i < 100000; i++) {
	contents.push('Just a log entry Just a log entry Just a log entry Just a log entry Just a log entry Just a log entry ' + i);
}
fs.writeFileSync('test.txt', contents.join('\n'));

Append to the file every second:
var fs = require('fs');

setInterval(function() {

	fs.appendFileSync('test.txt', 'Another line ' + new Date() + '\n');

}, 1000);

I then opened the file in the workbench for 5 minutes, seeing the lines as they come in. I've also profiled this, and most of the time is spent in reading the 10MB file again and again and again... Replacing the entire buffer with the new value takes in the order of 100ms which I guess is acceptable for a 10MB file.


refactor(cli): replace prettier with forge fmt

Hopefully this gets us more consistent formatting!
I intentionally left all the forge defaults, so you'll see some whitespace changes. I'm fine with this.

I just noticed that our prettier version for cli (2.8.4) was different than everywhere else in the monorepo (2.6.2) and wondering if some of our inconsistent formatting was due to mismatched versions.

Looks like what I was able to commit here into this branch is different from what is actually generated, and I think that is the source of our issues. Looks like the tablegen prettier output disagrees with the precommit lint hook (which formats solidity, and with a diff prettier version).
Gonna just align the prettier versions for now.

See https://github.com/latticexyz/mud/pull/470


Consider having run.c be split into multiple files

achieved tok/s: 0.804340 for the 7B dataset using 8 threads on MacBook Pro 2020 32G 13"
I realize that the point of your run.c is that it is Inference Llama 2 in one file of pure C.  For me to understand your code, I found myself breaking it into modules for the primary purpose of making sure that every line was understood.
See multiple_files/run.c for an example.  All that is left in run.c is the generate, chat, and main functions.  For the main function, parameters are extracted using ak_params.h leaving it reasonably clear how each parameter is used.
I provide an option to compile with PTHREADS=8 to allow a pthread implementation of matmul.  It'd be interesting to see the different C options for doing this both for CPUs and GPUs.
Each header file has a corresponding c file if there is any complexity to it.  In this case, the c file is still just included at the bottom of the header file to avoid the need for a more complex make system.
I prefixed all exposed functions with ak to help make it clear which functions were written locally and which were system functions.  I realize that the pure C way to do bools is with 0/1 - but the stdbool.h provides true/false and in a system that is basically a giant computation, it is nice to see booleans in the 2-3 places where ints were representing true and false.
Overall, the code is very well written and the zero to hero video series really helps make clear almost everything that is happening in the code.
Thought others might like to see what run.c looks like when broken up into multiple files.
In the multiple_files version, I didn't use mmap as it tends to not be well suited to smaller computers like my MacBook Pro 32G

:) too many files too many problems


Panic on daemon startup (master)

Got this today (current build 2fe51ec):
panic: sync: unlock of unlocked mutex

goroutine 1 [running]:
sync.(*Mutex).Unlock(0xc20817e010)
        /usr/local/go/src/sync/mutex.go:91 +0x9a
github.com/docker/docker/daemon/graphdriver/devmapper.(*DeviceSet).removeDevice(0xc20817e000, 0xc2081b8980, 0x19, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:1402 +0x2f9
github.com/docker/docker/daemon/graphdriver/devmapper.(*DeviceSet).deactivateDevice(0xc20817e000, 0xc2081ae780, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:1377 +0x393
github.com/docker/docker/daemon/graphdriver/devmapper.(*DeviceSet).verifyBaseDeviceUUID(0xc20817e000, 0xc2081ae780, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:709 +0x1c2
github.com/docker/docker/daemon/graphdriver/devmapper.(*DeviceSet).setupBaseImage(0xc20817e000, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:741 +0x1ee
github.com/docker/docker/daemon/graphdriver/devmapper.(*DeviceSet).initDevmapper(0xc20817e000, 0xc2081c6001, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:1246 +0x15b2
github.com/docker/docker/daemon/graphdriver/devmapper.NewDeviceSet(0xc2081b8860, 0x1c, 0x1, 0x0, 0x0, 0x0, 0x4a27bf, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/deviceset.go:1879 +0x4e7
github.com/docker/docker/daemon/graphdriver/devmapper.Init(0xc2081b8860, 0x1c, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/devmapper/driver.go:44 +0x172
github.com/docker/docker/daemon/graphdriver.GetDriver(0xfe13b0, 0xc, 0xc2081b65e0, 0xf, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /go/src/github.com/docker/docker/daemon/graphdriver/driver.go:102 +0x1a4
github.com/docker/docker/daemon/graphdriver.New(0xc2081b65e0, 0xf, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/graphdriver/driver.go:126 +0xa9d
github.com/docker/docker/daemon.NewDaemon(0x1704800, 0xc208038ac8, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/daemon/daemon.go:606 +0x7bf
main.mainDaemon()
        /go/src/github.com/docker/docker/docker/daemon.go:150 +0x9ef
main.main()
        /go/src/github.com/docker/docker/docker/docker.go:99 +0x6ef

goroutine 5 [syscall]:
os/signal.loop()
        /usr/local/go/src/os/signal/signal_unix.go:21 +0x1f
created by os/signal.init·1
        /usr/local/go/src/os/signal/signal_unix.go:27 +0x35

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /usr/local/go/src/runtime/asm_amd64.s:2232 +0x1

goroutine 12 [chan receive]:
github.com/docker/docker/pkg/listenbuffer.(*defaultListener).Accept(0xc2081b82e0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/docker/docker/pkg/listenbuffer/buffer.go:73 +0xb6
net/http.(*Server).Serve(0xc2081ae0c0, 0x7ff178975f38, 0xc2081b82e0, 0x0, 0x0)
        /usr/local/go/src/net/http/server.go:1728 +0x92
github.com/docker/docker/api/server.(*HttpServer).Serve(0xc2081b8340, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:125 +0x4d
github.com/docker/docker/api/server.func·002(0x7ff178975f98, 0xc2081b8340)
        /go/src/github.com/docker/docker/api/server/server.go:101 +0x40
created by github.com/docker/docker/api/server.(*Server).ServeApi
        /go/src/github.com/docker/docker/api/server/server.go:105 +0x6ac

goroutine 10 [chan receive]:
github.com/docker/docker/api/server.(*Server).ServeApi(0xc20805ad40, 0xc208078f50, 0x1, 0x1, 0x0, 0x0)
        /go/src/github.com/docker/docker/api/server/server.go:110 +0x74f
main.func·003()
        /go/src/github.com/docker/docker/docker/daemon.go:136 +0x5f
created by main.mainDaemon
        /go/src/github.com/docker/docker/docker/daemon.go:142 +0x877

goroutine 11 [chan receive]:
github.com/docker/docker/daemon.func·021()
        /go/src/github.com/docker/docker/daemon/debugtrap_unix.go:17 +0x5c
created by github.com/docker/docker/daemon.setupDumpStackTrap
        /go/src/github.com/docker/docker/daemon/debugtrap_unix.go:20 +0x18e

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

It only happens with devicemapper. I've seen it a couple of times upgrading daemons from 1.3.3 to 1.7. But the error is not consistent. It starts normally if you try again.

The block of code is quite weird:
		if err != devicemapper.ErrBusy {
			return err
		}

		// If we see EBUSY it may be a transient error,
		// sleep a bit a retry a few times.
		devices.Unlock()
		time.Sleep(100 * time.Millisecond)
		devices.Lock()

The  comment makes it seem like it should not be returning an err on EBUSY
Also since the mutex is being locked outside of this function it's weird to Unlock here as you can never know that the mutex is actually locked when Unlock is called.

@cpuguy83 I agree, you shouldn't mess with mutexes which isn't yours :)

Yeah @cpuguy83 is right: in the specific codepath of startup, the lock is not taken so if we hit the EBUSY condition we panic. It was introduced by #13896.


New WebView2 distribution doc page

A new documentation page for WebView2 discussion factor important to a dev when distributing their app to end users.

Docs Build status updates of commit d2963a8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 117b040:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\f3ux-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: 117b04052bfae6939e42c10ec6ec23381306d856.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit de3bf03:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\tyex-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: de3bf03514cbaa205c12c4d6d92da53f988c58bc.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d716b6d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\idqs-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: d716b6db8f214ab2495a96ca72ad11a164a57768.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c3b7247:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\ejro-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: c3b72475f575721a694229f7e89a42d8bc0661fa.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2692ee1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\dw1p-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: 2692ee1cc0c056100cb92540a4118cd84c994963.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 0a3ea77:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\x4fs-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: 0a3ea7703a8bbc8f1726c94d6f3972f144a9b1d8.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c193b0e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\4m00-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: c193b0ec28d4d742c0c8c1ea0f8db3b1ed45fa5f.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e66187d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/edge-developer, working directory: W:\4ait-s, target branch: HEAD, target branch commit: d1707238b9f39b26ab4ff3c2e625f0c90b0d0b28, source commit: e66187d8d2e6da52d21c325849eafae818f390e7.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7f73f03:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ab0ecb2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/index.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

microsoft-edge/webview2/index.md

Line 138: [Warning] Invalid file link: './how-to/debugging.md'.
Line 138: [Warning] Invalid file link: './how-to/webdriver.md'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2b87296:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/index.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off and merge.


Add CI testing for EnzymeCore

This PR adds a CI job for testing EnzymeCore and reporting coverage, following the model of EnzymeTestUtils.
I also skip two tests which seem broken but were never run so we didn't know.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 19.51%. Comparing base (037dfed) to head (497aa52).
Report is 178 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2009       +/-   ##
===========================================
- Coverage   67.50%   19.51%   -48.00%
===========================================
  Files          31        2       -29
  Lines       12668      164    -12504
===========================================
- Hits         8552       32     -8520
+ Misses       4116      132     -3984

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Export audio

I want to export audio files to a destination other than Google Bucket, such as Google Drive.

not planned or duplicated?  Again why not planned?  What are the options available for the user?


Adding rotation in create_assets makes objects floating above the floor

Describe the bug
I tried to add some rotation to objects in create_assets and create_pholder before returning the objects but it makes the objects floating above the floor.
Steps to Reproduce
I added some rotation, but it seems not to work and makes the objects float above the floor instead.
Here is the code clip:
    def create_asset(self, **kwargs) -> bpy.types.Object:
        obj = self.populate_func(scale=(self.dim_x, self.dim_y, self.dim_z))
        obj.rotation_mode = self.rotation_mode
        obj.rotation_euler = self.rotation_euler
        return obj

    def create_placeholder(self, **kwargs) -> bpy.types.Object:
        pholder = self.pholder_func(scale=(self.dim_x, self.dim_y, self.dim_z))
        pholder.rotation_mode = self.rotation_mode
        pholder.rotation_euler = self.rotation_euler
        return holder

What version of the code were you using?
commit 88fb49cde0bbca401601d05d672b31d28e9b45cb

Rotations are generally controlled by the piece of code which invokes the asset, not the asset itself.
If you want to apply a rotation inside an asset implementation, you may need to "apply" the rotation so that it is baked into the mesh and isnt overwritten when later parts of the code assign the rotation. You can do this by calling butil.apply_transform(obj, rot=True) on the obj & placeholder before returning them.
But this is just my best guess for what could be going on, for more specific advice id need to know what object this is and what command you are running (indoors or nature ?)

@araistrick Hi, Alex. Thanks for the reply.
The reason I want to add rotation is to make the scene more casual and more diverse rather than everything being regularly placed and axis-aligned.
I implemented a few simple primitive factories including cube, sphere and cylinder for indoor scenes, and managed to add materials of canfactory for them. I did this for exploring the way infinigen works and will add more complex objects when I know how it works. Is butil.apply_transform a better choice for adding rotation?

Assuming this is for indoor scenes, the easier way to achieve this would be to edit here and add some translation / rotation.
IE right before this line you could do something like:
placeholder.rotation_euler.z += np.rad2deg(np.random.uniform(-10, 10))

Thanks! I'll try both the methods.


end-to-end example as a notebook?

Any chance you could push an end-to-end example as a jupyter notebook? It's really hard to follow the codebase... thanks!

Sure, we will start on getting a notebook example out

I'm excited to see the end-to-end example. I'd like to generalize this to non-M4 time series, and that'll be super helpful for it. Thanks!

Thanks @damitkwr

Really looking forward to it. Thnx for efforts by the way

Thank you @damitkwr looking forward to it :).
Many thanks,
Andrew

Me also looking forward for it

I'm excited to see the end-to-end example. I'd like to generalize this to non-M4 time series, and that'll be super helpful for it. Thanks!

Very interested in this

Hi all!
Was wondering if there was an update on the above

Would be good a generalization for different and a way to get the forecasted values.

Would also be very grateful for any further documentation for the code beyond Smyl's Uber page and the paper. I've come from using Keras and finding it difficult to follow. It's training fine but would like to generalise on non-M4 data (though also not sure how to obtain forecasts). Even restricting the M4 data to a fewer number of time series breaks the code due to a batch size issue in Pytorch. Many thanks.

Currently working on a colab notebook. Hoping to extend the implementation to non-M4 data where you may have additional metadata (day of the week, holidays, etc.).

Looking forward to it.

@samuelgneff How is your project going :)? Looking forward to your nb! Cheers

Please find a simple Colab NB example here: https://gist.github.com/florisrc/e9bc4cb054c6ad1c8f1ac43a9c21d09f

Please find a simple Colab NB example here: https://gist.github.com/florisrc/e9bc4cb054c6ad1c8f1ac43a9c21d09f

I added tensorflow 1 compatibility and a direct link to google colab
here :+1: .

How long should we expect this code to run for?

I'm excited to see the end-to-end example. I'd like to generalize this to non-M4 time series, and that'll be super helpful for it. Thanks!

Has anyone successfully generalized this to non-m4 time series and has a notebook of this? For example, the M3 time series?


Allow testing of commands that return multiple messages with respond_with_slack_message

Allows testing of a single response out of multiple responses, and also allows testing of all responses from a single command call.
Resolves #135

I like the idea. This needs tests and a passing build, please. I would use "once" instead of "at least once" to have a stronger expectation. Maybe something more elaborate can afford for multiple repeated messages.

I also wonder whether we should instead introduce to_respond_with_slack_messages (plural)?

Refactored to update support for a single message from a group of messages using respond_with_slack_message and added new respond_with_slack_messages to allow checking of multiple responses at once. Agree that it's cleaner that way.  Added tests for both matchers and updated README.md with notes on new matcher. A single test case is still failing for me, but it appears to be unrelated to any of my work. The VCR is not matching the response for migration_in_progress and is failing with an error that no response is available in the VCR.

Build is still failing due to the above mentioned test case. If I'm missing something just let me know, but it doesn't appear that I'm the cause of that failure, copied below.

SlackRubyBot::Server retries on rtm.start errors migration_in_progress
Failure/Error:
expect do
subject.run
end.to raise_error Slack::Web::Api::Error, 'unknown'
expected Slack::Web::Api::Errors::SlackError with "unknown", got #<VCR::Errors::UnhandledHTTPRequestError:

Without debugging, the VCR error means that something is making an HTTP request that wasn't expecting. You can record that and look at what's being made by changing vcr.rb to record new episodes, but most likely there's a behavior change in the code if it's failing an old spec.

Ok, I think I've addressed all of the concerns and we have a passing build now. If there's anything else just let me know.

Merging, thanks for the good work.


TRINITY-54: Create api endpoints for Assignments and AssignmentSubmissions

Added api endpoints for Assignments and AssignmentSubmissions
Removed some unused constants in AssignmentConstants

I didn't get a chance to look at this yesterday, does it need a rebase or something? Is it supposed to be this many commits/files @stetsche

thanks, fixed it

Is the Java build broken?

the build here is failing in library, but yes actually there is a problem in webapi too

Is the Java build broken?
Assignments and webapi are building fine. It is failing in library.


Support for seamless multi-codec switching

Hi,
According to what I've read in other two opened issues (#1013 , #1071), my understanding is that currently there is no way to seamlessly switch between Adaptation Sets with different codecs during the playback, and the implemented logic still relies on the "best codec" selection during the load of the manifest.
Would it be possible to achieve this by somehow changing the player code, or it depends on MSE that still doesn't provide support for switching between codecs ? Or otherwise is the browser (we are using Microsoft EDGE) that currently doesn't provide support for it ?
We currently have an MPD manifest with two different Audio Adaptation Sets with same language, same role but with different codecs (ec-3, mp4a), different audio channels (2, 6) and different bandwidth.
We are trying to find a way in order to allow the user to select between the two audio tracks. I've looked inside the player code and it looks quite difficult to achieve this due to the Variant Tracks logic and dependencies with the chosen codec.
Do you have any suggestions in order to achieve this or currently there is no solution ?
Best Regards,
Paul

We currently don't support changing codecs at all.  Once we start playing with a codec, we can't change it under normal circumstances.  But there is a new standard to allow switching between codecs that we could use on supported browsers, but we haven't implemented it yet.  See #1528.
If there is no browsers support for codec switching, we don't want to support switching because it would require tearing down the media stack and won't be seamless.
Also, as described in #1013, we will use the preferredAudioChannelCount setting to choose the initial audio stream.  So if you set it to 6, we'll choose the 6 channel audio initially; otherwise we will choose the 2 channel one.  But you'll be unable to change to a different codec after playback starts.

Hi,
Thank you again for the feedback!
By now I've managed to change the "best codec" logic with the selection of a specific audio/video codec combination that is  driven by the user.
Of course, this still requires reloading the manifest and it's not seamless but for now it is a good tradeoff.
BR,
Paul


gitAndTools.pre-commit: 1.10.4 -> 1.11.0

Motivation for this change
Update pre-commit to the latest version. changelog
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gitAndTools.pre-commit

Success on x86_64-darwin (full log)
Attempted: gitAndTools.pre-commit
Partial log (click to expand)
/private/tmp/nix-build-pre_commit-1.11.0.drv-0/pre_commit-1.11.0
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/lib  /nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/bin
patching script interpreter paths in /nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0
/nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/lib/python3.6/site-packages/pre_commit/resources/hook-tmpl: interpreter directive changed from "/usr/bin/env python" to "/nix/store/dlswl7xjvh3bsfydygqzi2n0f82p5d9p-python3-3.6.6/bin/python"
wrapping `/nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/bin/pre-commit-validate-manifest'...
wrapping `/nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/bin/pre-commit-validate-config'...
wrapping `/nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0/bin/pre-commit'...
/nix/store/45mrrf71c0cz8inl7zzvz97n6a74k0dx-pre_commit-1.11.0

Success on aarch64-linux (full log)
Attempted: gitAndTools.pre-commit
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/lib  /nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/bin
patching script interpreter paths in /nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0
/nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/lib/python3.6/site-packages/pre_commit/resources/hook-tmpl: interpreter directive changed from "/usr/bin/env python" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0...
wrapping `/nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/bin/pre-commit-validate-manifest'...
wrapping `/nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/bin/pre-commit-validate-config'...
wrapping `/nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0/bin/pre-commit'...
/nix/store/94hrrm5pwcdcw5bvnk7lk4vrm7a3mgdf-pre_commit-1.11.0

Success on x86_64-linux (full log)
Attempted: gitAndTools.pre-commit
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/lib  /nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/bin
patching script interpreter paths in /nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0
/nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/lib/python3.6/site-packages/pre_commit/resources/hook-tmpl: interpreter directive changed from "/usr/bin/env python" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0...
wrapping `/nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/bin/pre-commit-validate-config'...
wrapping `/nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/bin/pre-commit'...
wrapping `/nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0/bin/pre-commit-validate-manifest'...
/nix/store/lpjgnq8jl3hh329zbfav5fncr6y6avxz-pre_commit-1.11.0


A graph-based pipeline splitting

An automatic graph-based pipeline splitting algorithm. The goal of the method is to split the computation graph into stages to minimize the communication between the stages while trying to balance the computation. The optimization is done via solving a mixed-integer linear program (MILP) using scipy.
Measuring mean batch time in sec over 50 batches (after a warmup) for various models using "manual split", "--autosplit", and the new "--graphsplit":

model
nproc-per-node
manual
autosplit
graphsplit

pippy_bert
2
0.1082
0.1279
0.1083

pippy_bert
4
0.0670
0.0798
0.0671

pippy_gpt2
2
0.0388
0.0550
0.0391

pippy_gpt2
4
0.0201
0.0271
0.0205

pippy_fnet
2
0.0324
0.0420
0.0323

pippy_fnet
4
0.0221
crash
0.0218

pippy_blenderbot
2
0.4805
0.4991
0.4839

pippy_blenderbot
4
0.2421
0.2593
0.2436

That is, the results of graph-split are almost identical to manual splitting, indicating that no manual model annotation is needed.

Tests and measurements are done on an older rev (467dc1bcd40804611fa79cb50db8211b7d1d891e), since the latest has some tracing issues (e.g., https://github.com/pytorch/PiPPy/issues/1087)

Nice work! Could you please provide some readings/explanations regarding this implementation?

Nice work! Could you please provide some readings/explanations regarding this implementation?

This is an original work but the ideas are fairly well-known. Perhaps the closest implementation are works here and here.
A common objective for most pipeline parallelism strategies is to split the model into stages of (roughly) the same size so as to minimize the required communication. The difference is how to define the "size of a stage" and the "required communication". My implementation relies on the existing knobs provided by the pippy tracer (e.g., via ModelSplit._analyze_node_size). Roughly speaking, the size of a stage is the sum of the memory required for storing parameters/buffers of the corresponding operators. The communication between the stages is estimated via the sizes of the output activations. Given the estimations, it is easy to formulate the optimization problem as a MILP. All the constraints/objective are fairly straightforward; the linked papers describe very similar formulations.
(I do realize that my model is likely not perfect and ignores some details; I opted however for the simplicity of the implementation, possibly at the cost of some perf. We can revisit details in the future)
Algorithm-wise, the formulated MILP is solved via SciPy, which is typically available or could be installed. It is not a perfect solver but works reasonably well on my benchmarks.

Nice work! Could you please provide some readings/explanations regarding this implementation?

This is an original work but the ideas are fairly well-known. Perhaps the closest implementation are works here and here.
A common objective for most pipeline parallelism strategies is to split the model into stages of (roughly) the same size so as to minimize the required communication. The difference is how to define the "size of a stage" and the "required communication". My implementation relies on the existing knobs provided by the pippy tracer (e.g., via ModelSplit._analyze_node_size). Roughly speaking, the size of a stage is the sum of the memory required for storing parameters/buffers of the corresponding operators. The communication between the stages is estimated via the sizes of the output activations. Given the estimations, it is easy to formulate the optimization problem as a MILP. All the constraints/objective are fairly straightforward; the linked papers describe very similar formulations. (I do realize that my model is likely not perfect and ignores some details; I opted however for the simplicity of the implementation, possibly at the cost of some perf. We can revisit details in the future)
Algorithm-wise, the formulated MILP is solved via SciPy, which is typically available or could be installed. It is not a perfect solver but works reasonably well on my benchmarks.

Thanks for the explanation! I might try implementing this in a similar way for my own pipeline parallelism, this code really helps a lot ;)

The latest commit makes the computation much faster (e.g., ~2sec on gpt2) by "pre-solving" the instance and assigning some nodes to specific stages. The code now tested and works on the latest pippy rev.

New measurements on the latest revision:

model
nproc-per-node
manual
autosplit
graphsplit
runtime

pippy_bert
2
0.0876
0.1030
0.0851
0.2sec

pippy_bert
4
0.0513
0.0590
0.0495
1.0sec

pippy_gpt2
2
0.1031
0.1316
0.0997
0.5sec

pippy_gpt2
4
0.0572
0.0820
0.0547
2.7sec

pippy_fnet
2
0.0661
0.0938
0.0664
0.2sec

pippy_fnet
4
0.0359
crash
0.0351
0.8sec

pippy_blenderbot
2
0.4853
0.5014
0.4863
0.6sec

pippy_blenderbot
4
0.2470
0.2630
0.2479
3.1sec

pippy_electra
2
0.1085
0.1385
0.1028
0.2sec

pippy_electra
4
0.0607
crash
0.0544
1.1sec

The last column shows the runtime of the splitting algorithm, that is, the overhead of the approach over manual/autosplit policies. The delay is (roughly) proportional to the size of the computation graph; in this benchmark, the graphs contain between 1K and 4K nodes.


Role workflow

From chicchiricco on July 16, 2010 09:09:47
Roles are managed without workflow, but it should be easy to apply the same worfklow concepts as for users.
Original issue: http://code.google.com/p/syncope/issues/detail?id=23

From chicchiricco on July 16, 2010 00:09:58
Owner: ---

From<EMAIL_ADDRESS>on January 18, 2012 02:06:11
Labels: Release-Diesis-2.2

From chicchiricco on October 15, 2012 23:48:37
https://issues.apache.org/jira/browse/SYNCOPE-173
Status: Duplicate


1.19.4 or 1.20?

Will this mod be updated?  According to Modrinth, it's been a year, and while I see lots of downloads on Modrinth, I don't see much going on here on Github.
I have this mod installed in on my survival server and would like to see it carried forward.
Will you be updating the mode to the newer versions?

Thank you for your interest in the project! Unfortunately, I cannot provide an ETA for this. Please keep in mind that mod development is an unpaid hobby of mine, so even though I love all my projects and want to keep them alive, it's definitely not the highest priority on my list. Basically, I develop mods when I have time to play Minecraft, and I haven't been able to do that for the past year or so, as you can see. So, yeah, at some point in the future, I will update my mods for sure, but I cannot tell you the exact date when that will happen.

OK, thanks for clarifying.


feat:  Cortex multiple engines onboarding

Problem
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Success Criteria
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

Update:

As a new user, I can list all available engines with cortex engines list

As a new user, I can install any engine with the engine name: cortex engines init cortex.tensorrt-llm

When pulling or starting any model, if the engine is not initialized, it will be installed beforehand:

cc @gabrielle-ong @Van-QA


mentions in feed don't show the corresponding block, simply the sentence and a timestamp

you can't click through to anything or access the block from the feed mention or notification

This one's gonna need some API work.


Exception when try to create a Controller without the base abstract Controller

Laravel Version
11.0.3
PHP Version
8.2.16
Database Driver & Version
SQLite
Description
Starting from the Laravel 11 we can delete the base abstract Controller and remove all extends, the application will continue work without any error, but when we do that we have an error when we try to create a new controller by using the Artisan.

The question is: the base abstract Controller is mandatory or not? If the answer to this question is not, then this exception is wrong.
Steps To Reproduce

Prepare a fresh Laravel 11 application
Delete the base abstract Controller
Try to create a new controller by using Artisan

Unable to recreate the issue.

I created a fresh Laravel 11 and the same error happened.

I was only able to create a new controller without the base abstract Controller when I ran:
composer dump-autoload

I think this is happening because Laravel 11 uses class_exists to check if the Controller file exists. I will suggest a PR that uses file_exists, because if this file is moved, the base abstract controller will not be used anyway since the code uses a hard-coded reference to this file:
https://github.com/laravel/framework/blob/eac3418dd5ff5c11dbaefee25038a734582f283a/src/Illuminate/Routing/Console/ControllerMakeCommand.php#L130

I was able to reproduce this. We should indeed do the file_exists check.

I was able to reproduce this. We should indeed do the file_exists check.

Thanks for the PR. I forgot to do that yesterday! 😅


fix Fix load failed where not set database in session (#41951)

cherry-pick #41951
load failed where not set database in session, should use label's database if not set database in session
LOAD LABEL test_db.label_111111 ( DATA INFILE("hdfs://hdfs01:9000/user/") INTO TABLE test_load_tb) WITH BROKER "broker" ( "username" = "user",  "password" = "");
ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set.
Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run buildall


FrozenError can't modify frozen Array (Rails 6.0 with zeitwerk autoloader)

Custom exceptions app not working with zeitwerk autoloader.
Works well with classic autoloader (config.autoloader = :classic).
env

Ruby 2.6.4
Rails 6.0.0
Rambulance 1.0.2

log
Started GET "/rambulance/not_found" for <IP_ADDRESS> at 2019-09-10 14:00:57 +0900
   (0.7ms)  SELECT sqlite_version(*)

FrozenError (can't modify frozen Array):

activesupport (6.0.0) lib/active_support/dependencies.rb:514:in `concat'
activesupport (6.0.0) lib/active_support/dependencies.rb:514:in `load_file'
activesupport (6.0.0) lib/active_support/dependencies.rb:407:in `block in require_or_load'
activesupport (6.0.0) lib/active_support/dependencies.rb:40:in `block in load_interlock'
activesupport (6.0.0) lib/active_support/dependencies/interlock.rb:14:in `block in loading'
activesupport (6.0.0) lib/active_support/concurrency/share_lock.rb:151:in `exclusive'
activesupport (6.0.0) lib/active_support/dependencies/interlock.rb:13:in `loading'
activesupport (6.0.0) lib/active_support/dependencies.rb:40:in `load_interlock'
activesupport (6.0.0) lib/active_support/dependencies.rb:390:in `require_or_load'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:48:in `block in require_or_load'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:47:in `require_or_load'
activesupport (6.0.0) lib/active_support/dependencies.rb:545:in `load_missing_constant'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `block in load_missing_constant'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:16:in `allow_bootsnap_retry'
bootsnap (1.4.5) lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
rambulance (1.0.2) lib/rambulance/railtie.rb:10:in `block (2 levels) in <class:Railtie>'
actionpack (6.0.0) lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>'
actionpack (6.0.0) lib/action_dispatch/routing/mapper.rb:48:in `serve'
actionpack (6.0.0) lib/action_dispatch/journey/router.rb:49:in `block in serve'
actionpack (6.0.0) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (6.0.0) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (6.0.0) lib/action_dispatch/routing/route_set.rb:837:in `call'
rack (2.0.7) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.0.7) lib/rack/etag.rb:25:in `call'
rack (2.0.7) lib/rack/conditional_get.rb:25:in `call'
rack (2.0.7) lib/rack/head.rb:12:in `call'
actionpack (6.0.0) lib/action_dispatch/http/content_security_policy.rb:18:in `call'
rack (2.0.7) lib/rack/session/abstract/id.rb:232:in `context'
rack (2.0.7) lib/rack/session/abstract/id.rb:226:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/cookies.rb:648:in `call'
activerecord (6.0.0) lib/active_record/migration.rb:567:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (6.0.0) lib/active_support/callbacks.rb:101:in `run_callbacks'
actionpack (6.0.0) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
web-console (4.0.1) lib/web_console/middleware.rb:132:in `call_app'
web-console (4.0.1) lib/web_console/middleware.rb:28:in `block in call'
web-console (4.0.1) lib/web_console/middleware.rb:17:in `catch'
web-console (4.0.1) lib/web_console/middleware.rb:17:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
railties (6.0.0) lib/rails/rack/logger.rb:38:in `call_app'
railties (6.0.0) lib/rails/rack/logger.rb:26:in `block in call'
activesupport (6.0.0) lib/active_support/tagged_logging.rb:80:in `block in tagged'
activesupport (6.0.0) lib/active_support/tagged_logging.rb:28:in `tagged'
activesupport (6.0.0) lib/active_support/tagged_logging.rb:80:in `tagged'
railties (6.0.0) lib/rails/rack/logger.rb:26:in `call'
sprockets-rails (3.2.1) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/request_id.rb:27:in `call'
rack (2.0.7) lib/rack/method_override.rb:22:in `call'
rack (2.0.7) lib/rack/runtime.rb:22:in `call'
activesupport (6.0.0) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/static.rb:126:in `call'
rack (2.0.7) lib/rack/sendfile.rb:111:in `call'
actionpack (6.0.0) lib/action_dispatch/middleware/host_authorization.rb:83:in `call'
webpacker (4.0.7) lib/webpacker/dev_server_proxy.rb:29:in `perform_request'
rack-proxy (0.6.5) lib/rack/proxy.rb:57:in `call'
railties (6.0.0) lib/rails/engine.rb:526:in `call'
puma (3.12.1) lib/puma/configuration.rb:227:in `call'
puma (3.12.1) lib/puma/server.rb:660:in `handle_request'
puma (3.12.1) lib/puma/server.rb:474:in `process_client'
puma (3.12.1) lib/puma/server.rb:334:in `block in run'
puma (3.12.1) lib/puma/thread_pool.rb:135:in `block in spawn_thread'

Hi @sho918, thanks for reporting. I just quickly looked into this issue but it seems like the AcitonDispatch::IntegrationTest has a foundational change and I couldn't run the test at all. So this is going to take a little more time unless someone else pokes around it.

I couldn't replicate the issue with a fresh Rails app:
$ ruby -v
ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-darwin18]
$ rails -v
Rails 6.0.0

$ rails new rambulance-test && cd rambulance-test
$ rails webpacker:install
$ bundle add ranbulance
$ rails g rambulance:install
$ rails s &
$ sleep 5 # wait for Rails to spin up
$ open http://localhost:3000/rambulance/not_found

I'm not sure what's going on there, but you may need to purge bootsnap cache when switching.

Thanks for response.
It works well without Custom Exceptions App (or Zeitwerk).
But an error occurs when combination of Custom Exceptions App and Zeitwerk autoloader.
$ rails new rambulance-test
$ cd rambulance-test
$ bundle add rambulance
$ rails g rambulance:install
$ rails s
$ open http://localhost:3000/rambulance/not_found # Works fine

# Install Custom Exceptions App
$ rails g rambulance:exceptions_app

# with Zeitwerk autoloader
$ rails r "puts Rails.autoloaders.zeitwerk_enabled?"
=> true
$ rails s
$ open http://localhost:3000/rambulance/not_found # FrozenError (can't modify frozen Array)

# without Zeitwerk autoloader (`config.autoloader = :classic`)
$ rails r "puts Rails.autoloaders.zeitwerk_enabled?"
=> false
$ rails s
$ open http://localhost:3000/rambulance/not_found # Works fine

Confirmed this bug. I'll look into it. Thanks for reporting.

I was able to replicate this bug in an actual rails app, but not in the test. I pushed the fix, but it would be great if you could confirm the fix on your side too. I will cut a new release once it's confirmed.

Thank you for quick fix.
It working without any problems on my rails app.

released as part of v1.0.3.


Added Starscream

First round attempt and adding web sockets without disrupting our current Autograph calls to help reduce needed testing

@rex-remind101  Still will write test but just wanted to get your eyes on it early on


Add a license

@evanlucas mind to do this? :D

Closed via c5b184b2c66ec78ea9120f9767bd0f1476b9c4d1
Thanks for letting me know :]


WIP: e2e: wait for NRT to settle (missing places)

In missing places add wait for NRT to settle to get reliable NRT data.

cherry-picked to existing PR https://github.com/openshift-kni/numaresources-operator/pull/714


Add "Aggregate Error Messages" Pattern?

We do stuff like this frequently in Commands; might be worth canonizing.
def argument_errors
  errors = []

  errors << foo_error
  errors << bar_error
  errors << baz_error

  errors.compact!

  return nil if errors.empty?
  return errors
end

@Crisfole suggests something like:
class MyCommand...
  check_error :policy_error
  check_error :history_error
  check_error :params_error

  def call(...)
    @policy = ...
    @history = ...
    @params = ...
    check_for_errors!

    ...other code...
  end
end

So the issue I see with this is that commands don't check errors in a single place: the failure of a command is necessarily in sequence with other business logic.
I could see the eventual use of a more structured flunk! call, maybe something like flunk_with! :function that would return a structured object that is proxied to the flunk! call. Something like:
class FooCommand
  def call(foo_form:)
    flunk_with! :check_arguments, foo_form
  end

  private

  def check_arguments(form)
    unless form.valid?
      return Slayer::Result.new(
        valid: false,
        message: form.errors.messages.full_sentences,
        value: form
      )
    end
  end
end


Amazon Games integration not creating collection

Not sure if this was something missed during integration or just a bug, but when adding games from Amazon, they are not assigned to a collection the same way the other libraries are.

Alright... Running it a second time worked? Gonna close this myself for now.


Please invite me to the community

Name
Anosh Bhakare
Discord Username (if applicable)
Anosh Bhakare#5653
Additional Context
Hello there, i would like to get involved in the projects and give my contribution towards it .

Welcome to the community!

Welcome 🎉

Thank you 😄


Opening newComment template with suggestion elements visible when includeSuggestion is not selected

To reproduce:

click the button to add a comment;
click on Cancel, instead of creating the comment;
click the button to add a comment again;
the form will be opened with suggestion elements visible:

Seems to be an easy fix. I can work on it after I'm done with l10n, if you want.

Yes please that would be useful!
On 22 May 2015 15:52, Luiza Pagliari<EMAIL_ADDRESS>wrote:
To reproduce:

click the button to add a comment;
click on Cancel, instead of creating the comment;
click the button to add a comment again;
the form will be opened with suggestion elements visible:

[image]https://cloud.githubusercontent.com/assets/836386/7773098/95420f1e-0078-11e5-81af-6eb8851e1c62.png
Seems to be an easy fix. I can work on it after I'm done with l10n, if you want.
—
Reply to this email directly or view it on GitHubhttps://github.com/JohnMcLear/ep_comments/issues/34.

Ah just doing a git pull should have this fixed.


fix: 'restart always' instruction is in wrong position

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@rafaelgfirmino plz fix:

@ComradeProgrammer plz review

@hsluoyz license accepted, thanks.


support shadow DOM without css

Adds basic support for Shadow DOM. Leverages a helper gist which gives the actual focused element within shadow roots.
This doesn't deal with the CSS problem: each shadow root needs a copy of the dialog CSS.

What's the status of this? I was about to file something similar and noticed that this already existed. Are there any plans for it to be integrated into master?

So this would work fine but I was a bit loathe to insert it as the CSS story is a bit awkward. It would be better/easier if I changed the polyfill to automagically insert the CSS, then it follows that it should automagically insert it into shadow roots too.
What's your use case? I suppose the only browser that needs this right now is Safari.

My use case is an internal custom dialog. So most of the CSS doesn't actually matter to us although we use some of it. We wrap a dialog in a custom element and slot in user content and then style it as design wants us to.
I came across needing these changes primarily because of the modal checks, document.body.contains instead of isConnected, which actually prevents modal usage in all browsers within shadow DOM if I'm not mistake.

 Because querySelector can't select children within <slot>s the focus management as written actually won't work if you slot content into the dialog. For example in a custom element's template:
<template>
  <dialog>
    <slot></slot>
  </dialog>
</template>

Any content that's slotted won't actually be focusable. While this makes sense from a web component perspective, given the implementation, it was surprising at first.
You can see a complete example in this fiddle. Note the problem only is reproducible in browsers that don't need shadow DOM polyfilled, but do need dialog polyfilled(Safari).
I don't know what, if anything, this actually means for the polyfill and this PR but I wanted to bring it up since it prevented me from continuing to use the polyfill within shadow DOM.

Has this PR been forgotten, or has it been overtaken by something else?


Add confirmation dialog when collected data will be discarded

/gcbrun

@JSunde I'm unable to test this feature on HEAD. Can you please double check that the dialog is visible for you when attempting to skip? Also, can we add one unit test for it?

Did you try skipping after data had been input?
And yea I can look into adding a unit test for this.

Yes, I tried doing it with select type tasks

Oh huh, you're right. I think I had tested with the multiple choice task previously but not after changing the implementation slightly. It seems to work properly with the Text input task.
I'm guessing it's an issue with the way I'm checking the response text to see if the user has input any data.


Fix: Update sorts on request parameter changes

Description
When column parameters are updated, sorts update with them instead of being removed.
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

I don't believe this solves the problem and introduces some bugs.  I'll  make a quick screen cap of what I was trying to prevent with refactoring toward CIDs.


Add file setting

Uses a native open dialog to select a file/files. Value will be set to an array containing the selected file paths.

Will require to be part of the plugin permission dialog in the future.


Forwarding messages by HTTP

FEATURE REQUEST

Is there an open issue addressing this request? If it does, please add a "+1" reaction to the
existing issue, otherwise proceed to step 2.

Describe the feature you are requesting, as well as the possible use case(s) for it.
I use the Mainflux platform as a backend of my application and I need to transfer data to another microservices entity (without throughout a database). Actually, it is not possible to transfer some message directly to another application by HTTP. In fact with the Export service, it is possible to do something similar but it is with MQTT protocol. With HTTP, we can easily add circuit breakers, load balancers, rules, etc.
With @drasko, we have already discussed that on the Gitter (beginning of conversation here: https://gitter.im/Mainflux/mainflux?at=5e8e397c9316f34b8d8c5691).

Indicate the importance of this feature to you (must-have, should-have, nice-to-have).
This is definitely a should-have feature.

The repository resolves this issue.

Great work @jonathandreyer
Closing this one.


Reliability fixes for  default-branch-button

Continues https://github.com/refined-github/refined-github/pull/6627
Can't repro anymore, but closes https://github.com/refined-github/refined-github/issues/6577

In the future:

https://github.com/refined-github/refined-github/issues/6557

list-prs-for-branch now breaks with the getCurrentBranchFromFeed() is only available on commit lists error after this PR...
https://github.com/refined-github/refined-github/assets/83146190/c1dc4dde-a0f0-4665-baa4-94aa65d5fe6b
(recorded before this was merged)

Thank you for testing! There’s a good chance that it’s an ajax issue, I think I remember the tag appearing twice or not being injected in those cases


Client doesn't load, throws net_version error

Running on localhost.  Error is TypeError: exists is not a function from app.js:9992:
    if (exists(join(dir, 'package.json')) || exists(join(dir, 'node_modules'))) {

Yup, the augur-js update broke the build for me, too. :disappointed:
It looks like the bcrypt import here isn't going to work with browserify: https://github.com/AugurProject/augur.js/blob/6a37363598cc5cb4f15822510e590a1e53cbb6c9/augur.js#L1343
The usage looks unnecessary to me, anyway.  You should be able to decrypt using aes (like you're already doing) with the entered password, and catch errors to find out if it was incorrect.

Oops, used bcrypt instead of bcryptjs -- fixed in 5cd12b9dff5e023b496648ad813b25c0d2985794.
Client still doesn't load for me, though; now I'm getting what looks like a web3 error:
Uncaught Error: net_version method not implemented [app.js:109556]

Good point, re: using decryption errors instead of storing the hash!  Also, now that I think of it, the plaintext password is not a good AES secret key -- sha256(password) would be better.

fixed earlier today

Removed bcrypt in AugurProject/augur.js@73d1cc403ceb46d7db28b5af5a3c57918207010f.  Thanks for the suggestion!


Fix PDF generation paths on Windows.

Paths being sent to createPDF and createPreview were not split correctly due to windows paths having backslashes instead of forward slashes. This resulted in projectPath being empty and fileName containing the entire path. With these values createPDF still functioned for the most part as expected, but createPreview would fail completely.

Hey, thanks for working on that.  I noticed the other day, but was going to roll it into some other work.

Can we avoid the regex by using the Node path commands?

Is this better?

At first glance, it looks reasonable to me.  I'll check it out this evening to make sure it runs on my machine.  I'm assuming that you're running on Windows?  We're you able to run the PDF converter spec tests?

Actually I didn't know the spec tests were a thing (I'm new to Atom & Atom development).
They will need to be changed because I changed the arguments of a few functions, but it fails most of them (including most of the outline view tests) on my computer both with my code and unchanged 0.6.1. I think it has to do with looking for files in ./.
I may be missing something about how they are supposed to be run...

Yes, it may be a system specific thing.  If that's all it is, I'll check out your branch tonight and update the tests for you... Or you could try to get cross-OS tests working.  Really glad to be getting some feedback on how all this is functioning in Windows.

So I used path commands to get spec tests working on Windows, should I include that in this pull request as well?

Yep.  Makes it a lot easier for me to merge :)

I've tested it as working on Linux as well. (ArchLinux)

I second that.  Manually tested functionality and tests passing.

Released with 0.6.2.  Thanks for the contribution!


Minor changes required in the light & dark mode

Change the font color of 'AnimePedia' and 'All Anime Characters' in both the dark & light modes.
In the dark mode, Change the colors of the Card content & the card color itself to make it look cooler :)

Hey @iamartyaa please assign this issue to me

@iamartyaa I would like to work on this issue

I am assigning this issue to @Rahul-Palahwat , you can start working on it.
@SumeetHaryani I will be opening a few more issues within the next 1 hour and will assign them to you.

@iamartyaa  can i work on this issue

@iamartyaa can i work on this issue

This issue is already assigned.


tests: add rule type check for flowbits v8

Task #6309
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6309
Previous PR: https://github.com/OISF/suricata-verify/pull/1529
Suricata PR: https://github.com/OISF/suricata/pull/10026
Output from console:
===> rules/flowbits: OK

PASSED:  3
FAILED:  0
SKIPPED: 6

Output from stdout file:
Notice: suricata: This is Suricata version 8.0.0-dev (9a2432696 2023-12-11) running in USER mode [LogVersion:suricata.c:1147]
Warning: threshold-config: Error opening file: "/usr/local/etc/suricata//threshold.config": Permission denied [SCThresholdConfInitContext:util-threshold-config.c:177]
Warning: detect-flowbits: flowbit 'fb3' is checked but not set. Checked in 4 and 1 other sigs [DetectFlowbitsAnalyze:detect-flowbits.c:596]
Warning: detect-flowbits: flowbit 'fb4' is checked but not set. Checked in 5 and 0 other sigs [DetectFlowbitsAnalyze:detect-flowbits.c:596]
Warning: detect-flowbits: flowbit 'fb5' is checked but not set. Checked in 12 and 0 other sigs [DetectFlowbitsAnalyze:detect-flowbits.c:596]

I believe this is missing @jufajardini 's review update from the last PR. ref: #1529 (comment)
Please fix that. From the first look, it's looking good otherwise :)

Sorry, I just saw the comment. I was wondering if we need a rule for noalert now if we've already removed that field from detect-flowbits files?

I believe this is missing @jufajardini 's review update from the last PR. ref: #1529 (comment)
Please fix that. From the first look, it's looking good otherwise :)

Sorry, I just saw the comment. I was wondering if we need a rule for noalert now if we've already removed that field from detect-flowbits files?

I think we could keep it. My reasoning for this is that with this engine-analysis work we are also documenting and showcasing things, and therefore there is value in showing what will it look like if you use flowbits:noalert.
Adding the check to the test.yaml file will help show where to find information about that, too.

I think we could keep it. My reasoning for this is that with this engine-analysis work we are also documenting and showcasing things, and therefore there is value in showing what will it look like if you use flowbits:noalert.
Adding the check to the test.yaml file will help show where to find information about that, too.

Okay, I'm not sure how to alter the yaml file such that the noalert rule doesn't create an error.

I think we could keep it. My reasoning for this is that with this engine-analysis work we are also documenting and showcasing things, and therefore there is value in showing what will it look like if you use flowbits:noalert.
Adding the check to the test.yaml file will help show where to find information about that, too.

Okay, I'm not sure how to alter the yaml file such that the noalert rule doesn't create an error.

That's ok, we're figuring this one out as we progress :)
From the eve log from the previous PR (https://github.com/OISF/suricata-verify/pull/1529#discussion_r1421008397), I think that we can:
i) have a rule that actually sets a flowbit, but also calls flowbit:noalert (just to ensure we're using a rule that makes some sense :P
ii) besides the check for the set flowbit, we can have something like:
flag[4]: "noalert"

I've tried a local test, and this seems to work.
What do you think?

New PR: https://github.com/OISF/suricata-verify/pull/1542


Making open sans the default font once again.

Description
Changes default font from Noto to Open Sans.
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

 I'll try again


Clarification on DidChangeWatchedFiles

Spec says "The watched files notification is sent from the client to the server when the client detects changes to files watched by the language client."_
It doesn't say which files are watched by the language client. Which ones can the server expect? Is it guaranteed to be at least as big as the set of files that are currently open in the client?
@akosyakov wrote "I assume DidChangeWatchedFiles notification is sent when physical files belonging to the workspace are created, changed or deleted, regardless to open documents." and @dbaeumer agreed.
But that's fishy. The notion of "files belonging to the workspace" doesn't exist in LSP, and when the client sends an Initialize request to open a project, then only the SERVER (not the client) knows the set of files in this project. There's no way for the client to enumerate them.
So: which "watched files" is a client required to send DidChangeWatchedFiles notifications for?
I see that the vscode-nodeserver example has a concept of watched files. But that's a vscode-specific thing, not part of LSP...

This is currently up to the client to decide. This request got added as a information vehicle not has a file watcher per see. If the vscode client library is used the extension needs to instruct the client library which files to watch and to sent notification to the server too.
The way how that should work with dynamic registration is that we allow the server to register for file events instead of making this a client decision. I simply forgot to do so when introducing dynamic registration. Will change the title so that we can work on this.

This got implemented a while ago and is part of the protocol and the node implementation.


Switching KV auth to RBAC

Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes

Switching KV auth to RBAC

Breaking Changes

Replace me
Replace me

Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have

[ ] Read the Contribution Guide and ensured this PR is compliant with the guide
[ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[ ] Checked for duplicate Pull Requests
[ ] Associated it with relevant GitHub Issues
[ ] (AVD LZA Team Only) Associated it with relevant ADO Items
[ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@swathibhat1 this PR fixes ALZ policy violation for key vault RBAC settings.


Use google books API to autocomplete results

Add search autocomplete functionality using Google Books API.

[x] Debounce function
[ ] Cache results
[ ] Highlight results

https://github.com/MauricioRobayo/react-redux-bookstore/pull/19#discussion_r491639392

Used a datalist so no hightlighting of the match on the results: https://github.com/MauricioRobayo/react-redux-bookstore/pull/23


Add models for intended operational state

As ...
Nelly - Network Engineer
I want ...
to be able to store the intended operational state of the network in Nautobot. (This is not actual performing discovery or operational validation. Just storing absolutes, thresholds, and ranges)
(multiple personas can be used for this)
So that ...
I can use this data to populate verification and intent-checks in my observability platforms, and then use SSoT (or equivalent) to compare/contrast the intended operational state rules.   These should be abstract models that define the targets such as qty neighbors, neighbor statuses, ranges of available light levels, qty of prefixes and routes, interface drop ranges, etc. The list can go on.
I know this is done when...
I'm able to populate the intended operational state of a variety of models.  I'm sure this could be added/embedded into feature models so configure + oper are tied together like OpenConfig, but I wanted to open this to get a discussion going and feedback.
To clarify, if someone is using Python or Ansible for basic health checks, they would query intended state (such as qty neighbors from Nautobot) and then use that to compare it against how many are active.  If it's a more robust solution, these standards in Nautobot can drive the "rules" in commercial assurance and observability platforms.
There should be a main view for visualizing observed state models, but also it should be possible to inject them on detailed views like interfaces.
The final piece would be to store the actual value to know the health, i.e. use SSoT to populate the data after humans define the approved ranges, etc.  It'd be a win to store the desired thresholds and rules first, and following that, to populate the actuals, to see the operational health next to the intended state.
Optional - Feature groups this request pertains to.

[X] Automation
[ ] Circuits
[X] DCIM
[ ] IPAM
[X] Misc (including Data Sources)
[ ] Organization
[X] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
Not sure. This may be core (for base and common oper state) and plugins for others, but doesn't matter, as long as it becomes possible.
External Dependencies
No response

Let's evaluate why the combination of custom/computed fields, config contexts, custom relationships, dynamic groups don't solve this problem. Are we short documentation? Do any of the features above not go far enough? Is there hesitation because of the data sprawl potential with some of these features that being able to scope narrowly enough.

On the surface those can be clearly be used for anything.  IMO, it's no different than building actual data models for config data. because we want them as first-class citizens (via core, plugins, or a series of both like secrets) and because they are relevant for horizonal 80%+ use cases.

From my perspective, the question is, are these new data models or are they simply new fields on existing data models? To my mind it's the latter (fields on the Device and Interface models, most likely) but if there's a need for actual first-class data models for intended state, separate from the Device and Interface models, I'd like to more clearly understand the requirements behind that.


DO NOT MERGE! Fast Forward stable to dd93bf6c964b50f7c3035088dec95a35e7363332.

This PR will be merged automatically once checks are successful.

This change is

Jenkins job mixer/postsubmit passed


Character frequencies

Here's a character frequency count for the validated XML file.
coverdale.xml.character.frequency.txt
BabelPad has a menu option for this.
Of particular concern.
U+0028	(	2,214	LEFT PARENTHESIS
U+0029	)	2,213	RIGHT PARENTHESIS

Is there a right ) missing?
U+00A0	 	1	NO-BREAK SPACE

Probably not required.
U+0364	ͤ	12,583	COMBINING LATIN SMALL LETTER E
U+036D	ͭ	2,867	COMBINING LATIN SMALL LETTER T

Superscripted letters might be better done with ordinary letters marked with the OSIS hi element.
<hi type="super">e</hi>
cf. SWORD users would not expect to have to use those two combining letters in searching.
There may be an even better way to preserve the original appearance of the the printed work and yet still provide the "expected" words for SWORD users.
Aside: Did Coverdale really have yͤ or did he use the letter thorn ?  i.e. þͤ etc.

Maybe we should consider the OSIS abbr element for those shortened words?
yͤ
yͭ

Likewise,
childrē
etc.

The NO-BREAK SPACE occurs in 1 Samuel 5:1 which reads:
<verse osisID="1Sam.5.1"> As for the Arke of God, the Philistynes toke it and broughte it from the stone of helpe vnto A dod</verse>

It's in the last word, which in the KJV reads Ashdod.  Looks like a transcription error.
Elsewhere in the digital text, the word is Asdod though there are 6 matches to A?dod.
Perhaps the real issue here is that another combining letter was used?
Should all of these really be Asͪdod ?  Is that why there were the transcription faults?
How many other words might also contain the combined character sͪ ?
cf. In total there are 366 matches to the regexp \w*\?\w+ .
Each of these locations should be reviewed. I will extract a list.

Here is a tab delimited text file containing a counted list of strings that contain a question mark at other than the final position.
coverdale.wqm.count.txt

http://www.bibles-online.net/1535/OldTestament/1-Genesis/ The scan has yͤ, it’s the common typographic substantiation for thorn as far as I know.
The scans are unfortunately rather cumbersome to peruse.
The macrons being omitted led me to believe the transcription was always ascii-based, but the question marks and spaces do point at it being saved with incorrect character mapping. Unfortunately, Google only points at a study bible website with the same transcription source.

Here is a counted list of non-space strings containing a capital letter after the first character:
coverdale.nsp.before.cap.count.txt
The search pattern excludes LORDE and excludes XML markup.
Each of these locations needs to be reviewed and corrected.

Some places are simply where a space was omitted.
Other places are more complicated.

Thanks for your reply in the last but one comment here, @lemtom
Understood. That clarifies matters as regards the two shortened words that use those combining letters.
Yes- I agree - it's a tedious task to proof-read such a transcription, with the online images being so slow to render and zoom.
btw. Was the initial digitisation the one from Slavic Bible Online be Serjei A Fedosov ?
If so, please state this provenance in the README.
That will help newcomers, and save folk wasting time looking elsewhere.
NB. Some of the texts at the Wesley Center Online came to them from that source.

Someone forwarded this transcription by someone, and he did not state the provenance. I’m not familiar with Slavic Bible Online, and I can't seem to find a working website for it. But if it is/was on there, it is quite likely the same.
Thank you for your counted lists. I have begun going through it, and already most ominous «[Hebrew:» turns out to be [Hebrew: t], the transcriber noting that a ת should be inserted instead.

Last time I found it as Slavic Bible.
He's mentioned in this wiki page in relation to his work on the Tyndale Bible.

Some problems with Fedosov's work is that he didn't transcribe the line over vowels that represented a n, or m--so the text has a lot of hi meaning him, the meaning them, wet meaning went etc...where these are not spellings that the printer used. He also transcribed the þt, þe and such thorn symbols as ye, yt instead of the, that, etc...but transcribed the "and" symbol (&) as "and".

Some of the same observations were relevant to the earlier transcription of the Wycliffe Bible.
That's now on WikiSource, and also available as a SWORD module.

@lemtom
Following your commits on 4 February 2018, I have updated the character frequency analysis.
coverdale.xml.character.frequency.txt
Observations:
The numerical mismatch for left and right parentheses is still unfixed.
U+0028	(	2,214	LEFT PARENTHESIS
U+0029	)	2,213	RIGHT PARENTHESIS

There is still a single no-break space.
U+00A0	 	1	NO-BREAK SPACE

There are two Hebrew letters and left to right marks.
U+05EA	ת	2	HEBREW LETTER TAV
U+200E		2	LEFT-TO-RIGHT MARK

The Hebrew letters appear in the source scans, Ezekiel 9:

set this marck ת Thau vpo the foreheades

that haue this marck ת Thau vpo them

The no break space occurs in the word A dod which in other locations is now written as Aßdod.

Thank you, double checked it in the source file and it indeed should be Aßdod.

As for the parentheses, I constructed this regex for finding verses containing only one phrase
<verse osisID="[0-9]*[A-z]+.[0-9]+.[0-9]+">[^)]*\([^)]*<\/verse>

It of course also catches false positives (multiverse sentences).
I unfortunately immediately stumbled upon a problem. The source itself is not coherent with its parentheses
http://bibles-online.net/1535/OldTestament/22-SongofSolomon/
Third paragraph of II. chapter, in the xml file:
(o yͤ doughters of Ierusalem (

the source scan also has the same wrong second parenthesis.
(also highlights another problem, that not every ye is yͤ)

Does the scan really use the LATIN SMALL LETTER SHARP S ß ?
cf. Did you consider also preserving the use of the archaic letter long s ?
U+017F	ſ	LATIN SMALL LETTER LONG S

Good catch about the "not every ye is yͤ" !

Yeah, I have considered preserving the long s, though I will need to be extremely certain of any regex I construct for doing so.
The ß:

Beautiful typographic version even, clearly showing itself as the ſs ligature.

I doubt it's feasible using regexp if you're after accuracy. Given the use of the long s varied between English, French and Italian, and even between different periods of English, I expect devising a consistent rule for its occurrence in the Coverdale Bible may be impossible.

Here's an update after the commit yesterday by @lemtom
coverdale.xml.character.frequency.txt