Generate Stateless Reset Token with a configurable value

[draft-05] 7.8.2.  Calculating a Stateless Reset Token

The stateless reset token MUST be difficult to guess.  In order to
create a Stateless Reset Token, a server could randomly generate
[RFC4086] a secret for every connection that it creates.  However,
this presents a coordination problem when there are multiple servers
in a cluster or a storage problem for a server that might lose state.
Stateless reset specifically exists to handle the case where state is
lost, so this approach is suboptimal.

Currently, the token is generated based on QUIC Connection ID and an ATS internal sequence number (net_connection_number).

In the draft, it's said we can use HMAC(static_key, server_id || connection_id) as the algorithm. Is this ticket aiming to make static_key configurable? If so, I can try to implement it.

It's aiming to make server_id configurable.

In order to
create a Stateless Reset Token, a server could randomly generate
[RFC4086] a secret for every connection that it creates.  However,
this presents a coordination problem when there are multiple servers
in a cluster or a storage problem for a server that might lose state.

From my understanding server_id in the HMAC example have to be a configurable value which is shared with multiple servers in a cluster. We may be able to use some existing configuration, and I'm fine with it. If I remember correctly, currently the token is just a sequential number on a server.

Thanks for the clarification. What I do not fully understand is why we want to share the server_id among all the servers in a cluster. Do the servers share the connection states too? What does it try to solve here?

The servers may share the connection states too, but that doesn't matter because it's stateless reset token. A key point is that a server have to be able to generate consistent reset token even if the server lost state information, when the same connection_id is passed.
Technically speaking, using only a connection_id would work. However, in that case, anyone who knows the connection_id can reset the connection. So we need to make sure that tokens are difficult to guess and also consistent.
I'm not 100% sure, but this is my understanding.

Hmm, consider a cluster of 2 boxes, A and B, suppose that a client has a QUIC connection with box A, then box A is down, and the connection gets to box B. If box A and box B doesn't share the connection states, box B should send a stateless reset token to the client.
If we use the same server_id for A and B, in an edge case, B might also have the same connection_id generated. Then box B can treat the incoming connection as an old connection and apply wrong states to the connection.
So IMO, if we can't share connection states or guarantee no duplicate connection_ids in the cluster, we cannot use the same server_id in the cluster.
I can definitely be wrong. xD
It's great to discuss this logic with you. Really helpful to me for a better understanding of QUIC.

If we use the same server_id for A and B, in an edge case, B might also have the same connection_id generated. Then box B can treat the incoming connection as an old connection and apply wrong states to the connection.

Right, and it's not only about stateless reset but entire connection state management. That case will be a problem even if box A and B use different server_ids. If we cannot guarantee uniqueness of each connection ids in a cluster, we cannot make a cluster. We definitely need to think about this eventually.

So IMO, if we can't share connection states or guarantee no duplicate connection_ids in the cluster, we cannot use the same server_id in the cluster.

Because we need to guarantee connection id uniqueness in a cluster anyway, I think we can focus on state sharing here.
If states are shared in a cluster, there's no need to send a stateless reset as long as the state store is fine. If states are not shared in a cluster, connections on box A were gone when box A went down, so box B should send a stateless reset when it found an unknown connection id. In both cases, box A and B need to use the same server_id.

It's great to discuss this logic with you. Really helpful to me for a better understanding of QUIC.

Same here :)


kosmos 'j.data.bcdb.test()' still 1 issue

the tests 1-1 do work
as total not
means probably some left overs from previous tests influence new ones

Now : j.data.bcdb.test()  works good

The started servers need to be stopped at the end of test as it will fail if start test again.

@AhmedHanafy725  DONE

It works fine
Verified on  54520f04e71f8e62effdfec6f7a4c3051aec717f


feat: 🌟 add flag for limiting concurrent downloads

Description
Add new command line flag for limiting the number of concurrent downloads.
Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] cargo test run with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 35.34%. Comparing base (4c124de) to head (b0fbbcc).

Files with missing lines
Patch %
Lines

src/fetch.rs
0.00%
6 Missing :warning:

src/main.rs
0.00%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   35.52%   35.34%   -0.18%
==========================================
  Files           4        4
  Lines        1185     1191       +6
==========================================
  Hits          421      421
- Misses        764      770       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Please add copyright/licensing information

I am hoping to package node-buffer-equal for Debian (since it is a dependency of nodeunit/tap), and need copyright and license files in the source.
Kind regards,
Tim

Technically it already does reference the LICENSE,  might not be enough for your lawyers though.


Cannot Load DLL

Hello!
Invalid argument(s): Failed to load dynamic library 'pdftotext.dll': error code 126
#0      _open (dart:ffi-patch/ffi_dynamic_library_patch.dart:11:43)
#1      new DynamicLibrary.open (dart:ffi-patch/ffi_dynamic_library_patch.dart:22:12)
#2      new PDFToTextWrapping (package:pdf_text_extraction/src/pdf_to_text_wrapping.dart:30:34)
This error came from that Directory.current.path is not lib path.
(If I'm not using it incorrectly.)
Could you revise it, please?

this error 126 could be incorrect dll path or missing Microsoft C++ Runtime 2005-2019-2022

2023年5月31日(水) 0:18 Isaque Neves @.***>:

this error 126 could be incorrect dll path or missing Microsoft C++
Runtime 2005-2019-2022
—
Reply to this email directly, view it on GitHub
https://github.com/insinfo/pdf_text_extraction/issues/1#issuecomment-1568627605,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS66BSIOW6FUTTMRK3YTPLDXIYFVJANCNFSM6AAAAAAXXPE5VY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Update e-mail copy to supplied copy

Jean provided updated copy for the adoption e-mails. We will now send
different ones depending on how many drains the user has adopted (and
none after 3 drains).
Addresses #14.

@hackajesse see the changes to the files under app/views/thing_mailer/

:shipit:


lime test android error

Error: /home/clintflames/haxelib/hxcpp/4,3,2/project/thirdparty/pcre2-10.42/src/pcre2_script_run.c: In function '_pcre2_script_run_8':
/home/clintflames/haxelib/hxcpp/4,3,2/project/thirdparty/pcre2-10.42/src/pcre2_script_run.c:109:1: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
 for (int i = 0; i < FULL_MAPSIZE; i++) require_map[i] = 0;
 ^
/home/clintflames/haxelib/hxcpp/4,3,2/project/thirdparty/pcre2-10.42/src/pcre2_script_run.c:109:1: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
/home/clintflames/haxelib/hxcpp/4,3,2/project/thirdparty/pcre2-10.42/src/pcre2_script_run.c:248:7: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
       for (int i = 0; i < FULL_MAPSIZE; i++)
       ^
/home/clintflames/haxelib/hxcpp/4,3,2/project/thirdparty/pcre2-10.42/src/pcre2_script_run.c:285:9: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
         for (int i = 0; i < FULL_MAPSIZE; i++) require_map[i] &= map[i];
         ^

And after that the command freezes. If I press CTRL + C it returns new error:
Error: Source path "export/android/obj/libApplicationMain-v7.so" does not exist

OS: Manjaro Linux
Android NDK: r15c
JDK: 19.0.2

That's a known issue with hxcpp 4.3.2. The fix is available on Git but hasn't been released on Haxelib yet. You can also revert to the previous stable release.


Documentation link issues plugin can get rate limited and fail

Description

The documentation's link_issues plugin can get rate limited and fail. We need to make sure this is avoided in CI. To do so, we can pass a GitHub token for the plugin to use.
It also slows the build because the rate limit prevents the build from being able to make the requests in succession.
Locally we can by-pass resolving the issue by linking straight to github.com/WordPress/openverse/issues/{issue_number}.
Reproduction

 Build the documentation site locally a couple times in succession and you will see the rate limit warnings and the build stalling to wait for the rate limit to pass.

This actually affects the real documentation output right now. On this page, for example, none of the issue links are resolved: https://docs.openverse.org/changelogs/api/2<IP_ADDRESS>.01.39.html


Don't start rotating the model before the poster is dismissed

Description
If you have auto-rotate on with a poster, the model will start rotating before the poster is dismissed. The better behaviour would be for the model to only start rotating once it is visible. That way the initial pose of the model will be consistent.
This is especially important if you want the poster to be an image of the initial pose, so that it transitions smoothly from image to model.
Live Demo
Try it out here. Wait 5-10 seconds before clicking the poster, and you will see the astronaut has already rotated a fair bit
https://codepen.io/pushmatrix/pen/BEoExG
Browser Affected

[x] Chrome
[x] Edge
[x] Firefox
[x] Helios
[x] IE
[x] Safari

OS

[x] Android
[x] iOS
[x] Linux
[x] MacOS
[x] Windows

Versions
All versions

Great catch, thanks for filing!


mjml-button: text-align not working

Reproduction Steps:

<mj-button href="https://www.example.com" text-align="left">Visist Website</mj-button>

Create HTML with mjml.

Expected behavior:
Text in button should be left aligned.
Observed behavior:
CLI output: (mj-button) — Attribute text-align is illegal
The attribute text-align is not defined in https://github.com/mjmlio/mjml/blob/master/packages/mjml-button/src/index.js as mentioned in the readme https://github.com/mjmlio/mjml/tree/master/packages/mjml-button.
MJML version:
mjml-core: 4.0.5
mjml-cli: 4.0.5

Hi @zeitrechnen we released a new beta for mjml 4.1, which you can install with npm install mjml@next, could you check if it resolves this problem ?

@kmcb777 Problem is solved. Thank you!


Update the list of watchers and stargazers when clicking watch/unwatch or star/unstar

We make sure the user cards are updated

Fixes https://github.com/go-gitea/gitea/issues/32561

I also removed ctx.Data["PageIsWatchers"] = true and ctx.Data["PageIsStargazers"] = true as they are not used anywhere.
Before

After

What happens to any potential JS event handlers in the swapped HTML when HTMX does the swap? How do we make sure that event handlers that need to be added to new cards are bound correctly after the swap?

This is true for any HTMX swap. This pull request is not the first one. There are no event handlers attached to the cards so we should be ok.

I was unable to create a backport for 1.22. @yardenshoham, please send one manually. :tea:
go run ./contrib/backport 32570
...  // fix git conflicts if any
go run ./contrib/backport --continue


Implement Iterator for CPU

The above implements the Iterator trait for the MOS6502 cpu.

The above implements the Iterator trait for the MOS6502 cpu.

I think this isn't necessary. But CPU could ASK that T implement IntoIterator


Comparing multi-point stride coverage and dataflow coverage

http://dl.acm.org/citation.cfm?id=2486812

The donation form has been submitted.


A tutorial for creating Westeros multi-node and modeling different trade possibilities

This PR adds a new tutorial to demonstrate how a multi-node energy system can be built using the MESSAGEix framework. It shows:

how new nodes can be added to a model and how data can be populated for those new nodes
how a trade hub can be represented
how bilateral trade can be modeled
role of the message_ix index set "mode" in representing trade links

How to review

Check out this branch and run the tutorial, and make sure it works without a flaw (error or infeasibility).
Check the results shown in the tutorial and make sure it makes sense and the text describing the results are correct.

PR checklist

[x] Continuous integration checks all ✅
[x] Add or expand tests; coverage checks both ✅ (added this tutorial to those being tested in test_tutorials.py)
[x] Add, expand, or update documentation.
[x] Update release notes.

All checks were successful, but the branch was out of date. I rebased the branch so that we can merge it soon, but now the tests might fail due to the removal of codecov from PyPi, which will be fixed by

https://github.com/iiasa/ixmp/pull/476

Thanks, @glatterf42 for reviewing this and for the useful suggestions. I agree that adding solutions at the end here or somewhere else as key to exercises, in general, will be useful. For this tutorial, the given exercise involves developing a scenario, with the intention to encourage users to do hands-on work. I'm afraid adding that solution here may not encourage users to start coding this.
On your questions:

I corrected and re-added the figure, thanks for spotting that issue.
Yes, that is correct. The price is determined by the most expensive generator of that commodity, which in this case is the same between the two regions, as the commodity is supplied from one generator to two regions via trade.

Maybe you could add a statement like 'Self-supervised learners who would like to see a solution for these exercises: please contact the author.'

This might then be ready for merging.

Thanks @glatterf42 for reviewing and adding the hint for the exercise. I agree, this can be merged. @OFR-IIASA is that okay?

For future reference: @OFR-IIASA confirmed privately that the merge is okay.


Bad Wallet Seed Conversion in V2

Pre Version 2
ALICE_ACCOUNT_WALLET = Wallet("ssbTMHrmEJP7QEQjWJH3a72LQipBM", 0)
public_key:<PHONE_NUMBER>E0D08083314842EDFBB2D517BD47699F9A4527318A8E10468C97C052
private_key: -HIDDEN-
classic_address: rG1QQv2nh2gr7RCZ1P8YYcBUKCCN633jCn

Version 2
ALICE_ACCOUNT_WALLET = Wallet.from_seed("ssbTMHrmEJP7QEQjWJH3a72LQipBM")
public_key: ED4A9D72F2557B714713DC8BA7C6F9576BCC06117A52F6C32F1E26FEEF9819EC8E
private_key: -HIDDEN-
classic_address: r9mC1zjD9u5SJXw56pdPhxoDSHaiNcisET

Any ideas? I think this is from the entropy type. I will attempt to specify the algorithm.

Can confirm its the algorithm.  I might have missed a migration document.
(You should be able to determine the algorithm from the seed...)

(You should be able to determine the algorithm from the seed...)

You actually can't - a seed doesn't have an associated algorithm and can be used with either algorithm. ED25519 keys do have an alternate encoding where they start with sEd..., but some folks think this was a bad design decision.


No Philips Hue white 1600 bulb on the supported list?

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I just bought new Philips hue white 1600 bulb and I think it is not yet supported. I cant find LWA031 on the library list.

Describe the solution you'd like
Add it to library
Describe alternatives you've considered
N/A
Additional context
N/A

Please see this faq topic: https://docs.powercalc.nl/troubleshooting/faq/#my-device-is-not-supported-what-can-i-do


[proposal] DistSQL Cache support on TiKV

Feature Request
Add cache on coprocessor level. This can reduce CPU comsumption on same coprocessor request with same data. For support that TiKV need add some feature to let kv-client can determine which request can hit the cache.
Design
First we should update kvproto to support new Request and Response

Request add field uint64 match_raft_commit_index it should be optional if absent TiKV should not check raft commit index
Response add field bool match_raft_commit_index if true means cache can be hitted.
Response add field uint64 raft_commit_index store raft commit index when the query execute

When TiKV execute a query:

TiDB send coprocessor request with match_raft_commit_index
coprocessor check match_raft_commit_index with Snapshot
if raft_commit_index matched, no need to calculate result just return an empty response and set match_raft_commit_index to true
if not matched, do calculate and fill response with match_raft_commit_index = false and raft_commit_index = Snapshot.raft_commit_index

pesudo code is like below:
fn handle_request() {
    if (this.request.has_match_raft_commit_index() &&
        this.request.get_match_raft_commit_index() == this.snapshot.raft_commit_index()) {
        response = Response::new()
        response.set_match_raft_commit_index(true)
        response.set_raft_commit_index(this.snapshot.raft_commit_index())
        return response
    } else {
        result = this.executor.execute()
        response = Response::new()
        response.set_data(result.data)
        response.set_match_raft_commit_index(false)
        response.set_raft_commit_index(this.snapshot.raft_commit_index())
    }
}

TODO:

Update kvproto
Update coprocessor let it can get snapshot’s raft commit index

PTAL @breeswish

Could you explain why raft commit index is needed for this feature? We have a plan to extract Coprocessor DAG as a standalone query engine component, which will not have any knowledge about "raft".

@breeswish yes

Looks like this solution is approachable and can be a cache layer wrapping the existing coprocessor part. How will you handle undetermined expressions like current time and random?

@breeswish at TiDB part there should be a function to determine whether this query can be cached. And in that function seems we should add some logic to prevent query with those SQL function to use cache. And we can also implements this function on TiKV part instead.

Okay.

Implemented by #6076


Exclude Twitter 400s in the link checker

Looks like Twitter is still experiencing issues with one of their APIs (https://api.twitterstat.us), so this change just ignores all 400s from them.

Thanks @cnunciato!

@cnunciato What's the mechanism for us to revisit this? Or, alternatively, does checking Twitter provide any value whatsoever? I don't think it actually returns 404s for non-existent tweets/handles?
FWIW, I just tried curl https://twitter.com/asdfasdfadsf1581 and the interesting thing is it returns a 400 with the following message: "This browser is no longer supported." So I think the problem is that blc is not coming across as a supported user agent. But, per my above comment, I wonder if excluding Twitter completely is the right thing to do anyway?

It looks like the service is still degraded, so that's probably why we're still seeing this behavior. My plan was just to check on it again in a few days, mostly just out of curiosity. (I noticed the same thing, by the way.)
I do think there's some value in checking, as things do occasionally disappear, but it's obviously not a big deal in the grand scheme of things. I'll follow up though. What we have now seems okay to me for the time being.


Rock paper and scissors game

Pls assign the issue to me

@MridulGupta007 Someone is already working on this issue; if they fail to complete it, it will be assigned to you. Until then, you can raise some other issues and work on them.


Lenis seems to be messing with my Intersection Observer

Describe the bug
I've implemented a global Intersection Observer on my website that also has an unobserving functionality attached to it. Basically, since some elements enter the viewport when the user scrolls down, they're unobserved after they're animated. However, when Lenis is active on the same page, and a scroll up occurs after a scroll down, elements from my page that I haven't even reached with my initial scroll down are unobserved, suggesting that something is making my Intersection Observer go haywire.
Could this be due to the way Lenis works? Or is this something I could find a workaround for?
Update
This bug also seems to trigger my animations down the page, not just messing with my intersection observer. I've tried rolling back to an earlier version of Lenis, and this behavior only happens with versions<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Version<EMAIL_ADDRESS>works fine.
Somehow it seems that even if I scroll up, the scroll is perceived as a scroll down, triggering things like GSAP's ScrollTrigger or Intersection Observers. Now, this may be the way Lenis is supposed to work, it may be a bug caused by my code, or it may be an actual bug in Lenis.
I'll wait for an answer to figure out how to proceed. I hope the extra details helped pinpoint the potential problem.

Can you share a codepen reproduction link please ?


Research: Extra tools tech stack

Wiki creation is pending, but in the meantime a dashboard was created in miro to add some notes about wich tools we propose to use

Discussions about what central stack to use have been made. Most technologies were decided but we still have pending:

CI/CD (Github Actions or GitLab)
Charts


Backup Support for Volumes

This adds support for general volumes that can be mounted in Alpha pods, such as EdgeFS, Cassandra, CephFS with Rook (https://rook.io/).  The customer must configure PV + PVC (with ReadWriteMany access mode so that one volume can be mounted under several pods).
Testing
Requirements
Default Storage Class is helpful (default config in EKS, AKS, GKE):
$ kc get storageclass
NAME            PROVISIONER             RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
ebs-sc          ebs.csi.aws.com         Delete          WaitForFirstConsumer   false                  23m
gp2 (default)   kubernetes.io/aws-ebs   Delete          WaitForFirstConsumer   false                  8d

Testing with Default Storage Class
In this scenario, you create a PVC, and when deploying dgraph, the PV will be allocated when the pods are launched.
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: my-backups-claim
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 32Gi

This will create a PVC.  With this chart, you can then run:
CHART_PATH=path/to/charts/charts/dgraph
helm install test \
  --namespace default $CHART_PATH \
  --values $CHART_PATH/example_values/backup-volume-config.yaml \
  --set backups.volume.claim=my-backups-claim

Testing with Mini-Kube
In this scenario, you create PV (using local file path) + PVC first, then deploy dgraph.  K8S has a guide on this:

https://kubernetes.io/docs/tasks/configure-pod-container/configure-persistent-volume-storage/

This change is

@danielmai Added some instructions with how to test


Fix sql datetime formating 185

@xrmx Please review ;)
About test should be a better way, right?
Note about ORACLE: who did that one? Not sure if it was better the old version, new version has been tested with http://sqlfiddle.com/#!15/27c44/2
SELECT TO_TIMESTAMP('2016-07-08 09:10:11.131456', 'YYYY-MM-DD HH24:MI:SS.ff6');
https://github.com/airbnb/caravel/issues/185

@gbrian any chance you can rebase on a branch following caravel master instead of whatever you have in yours? You have a dozen unrelated commits for not good reason.
BTW you should add "Fix #185" at the end of the commit message so bug is closed automatically.

If you move the tests in core_tests can we save some boilerplate? We have already a populated db there.

Please setup travis to run against your fork and get the build working before sending in the PR. Also you may want to change your git workflow to leave less / comprehensive commits.


pass in authentication credential and patch release

This seems to be a fairly simple but very useful plugin. I got a questions:

how to configure authentication username/password for git
Is there releasePatch task?

Thanks
-cl

ok, release is the releasePatch that I asked for.
beside using ~/.netrc to passing in git credential, any better way?

Yes, release creates a patch version release. I created an issue to improve consistency with regards to these tasks (#30).
Concerning git credentials: Because the plugin just invokes the command-line git client, you are free to use your favourite git credentials mechanism.
Just as an example: I personally use the osxkeychain helper on my dev machine, and the Jenkins Credentials plugin on our CI server.


Improve peak panel

closes : https://github.com/zakodium-oss/analysis-ui-components/issues/197

@stropitek  all story cases added , thank you!

LGTM

What is the added value of having visible: false versus just not include the item in the array?

@lpatiny maybe more a question for you since you have more context about what underlying data those props will be derived from.

LGTM

What is the added value of having visible: false versus just not include the item in the array?

@lpatiny maybe more a question for you since you have more context about what underlying data those props will be derived from.

The goal is that the enduser from a future preference panel can decide which columns are visible or not.


Error when using Python 2.6

I am using Vim 7.4 with Python 2.6 (because CentOS) and I found that minimap doesn't work with this combination.  You might want to either note the minimum version of python in the README.
I was able to get rid of the errors by changing the following line in minimap.py:
vim.command("match " + highlight_group + " /\%>0v\%<{}v\%>{}l\%<{}l./".for    mat(WIDTH + 1, top, bottom))
to:
vim.command("match " + highlight_group + " /%>0v%<{0}v%>{1}l%<{2}l./".for    mat(WIDTH + 1, top, bottom))

Thanks for the report. I'll check if the later str.format syntax work on py 2.7/py 3, and I'll update the code accordingly.

Thanks.  The two big changes I made were

\% to % because vim complained about it.  I guess It couldn't execute the former regex.
{} to {#} where # was the argument number and that is what Python 2.6 complained about.

You may not want to make the first change because I don't know if it is dependent on the version of vim.

I've pushed the second change. Thanks!
The first change (\% to %) is less clear. Can you check if :help /\%> successfully returns the help for this operator in your version of vim?

It returns the information associated with this: /\%c /\%>c /\%<c which is line 904 of my patterns.txt.gz.  I hope that helps.

@timlag1305 well, it just means that your vim does know about the operator \% :-)
So I'm really not sure why it complains. Could you copy-paste the error message?

Use {1**:.0f**} and {2**:.0f**}, top and bottom are floats for whatever reason.

So the error message is as follows
Error detected while processing function minimap#ShowMinimap: line    2: Traceback (most recent call last):   File "<string>", line 1, in <module>   File "/home/tim/.vim/plugged/vim-minimap/autoload/minimap.py", line 97, in showminimap     vim.command(":call minimap#UpdateMinimap()")
@andreibalandin's solution fixed the error.

So the error message is as follows
Error detected while processing function minimap#ShowMinimap:
line    2:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/tim/.vim/plugged/vim-minimap/autoload/minimap.py", line 97, in showminimap
    vim.command(":call minimap#UpdateMinimap()")
@andreibalandin's solution fixed the error.


libortools.so.9: cannot open shared object file: No such file or directory

Describe the bug
I am installing OpenROAD with Docker. I have successfully the image and run the container. But when I type openroad -h, it failed with
openroad: error while loading shared libraries: libortools.so.9: cannot open shared object file: No such file or directory

NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

My Docker is Docker version 20.10.8, build 3967b7d
Expected Behavior
openroad -h should be executed correctly
Environment
I fail to run this command, it tells me to pull the latest branch. But I have already done this and it did not work.

To Reproduce
git clone --recursive https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts
cd OpenROAD-flow-scripts
./build_openroad.sh
docker run -it -u $(id -u ${USER}):$(id -g ${USER}) -v $(pwd)/flow/platforms:/OpenROAD-flow-scripts/flow/platforms:ro openroad/flow-scripts
source ./setup_env.sh
yosys -help
openroad -help
cd flow
make
exit

When I run openroad -help, it failed with openroad: error while loading shared libraries: libortools.so.9: cannot open shared object file: No such file or directory
Relevant log output
No response
Screenshots
No response
Additional Context
No response

Where do you have or_tools installed?

Where do you have or_tools installed?

If I use Docker to build OpenROAD, is it need to install or_tools? Actually I try to build OpenROAD with Docker.

@habibayassin @vvbandeira in the openroad/centos7-builder-gcc container:
% ldd build/src/openroad|grep or
	libortools.so.9 => /opt/or-tools/lib64/libortools.so.9 (0x00007f2e88822000)

However /opt is empty in the final openroad/flow-scripts:latest container.  We need to copy or_tools over as well as the executable.

or add /opt/or-tools to openroad/flow-runtime

So what do I need to do? Wait for the latest container or copy /opt/or-tools from openroad/centos7-builder-gcc to openroad/flow-scripts:latest? Thanks!

We will put out a new openroad/flow-runtime to resolve this.

@zerzerzerz can you try the build command again? ./build_openroad.sh


Search full text, not just beginning characters

I'd like to be able to set this field to use the search term to match against the full text of the source, not just the begginning of the source. For example:
Search term:
the one
Results:

Neo is the one who was...
the one time I ate at Chipotle...

Currently, only the item that begins with the the one text will appear. Is there an option to switch to search the full text?

You can change the logic that you're currently using to set suggestions. Forked the Basic Codepen example to illustrate: http://codepen.io/anon/pen/pgXmNP

Oh that's great. I was looking for an option on the component. But this works too. Thanks for that!


pip3 package manager compatability inclusion

for RHEL 8, Fedora & CentOS. pip3 will be appropriate.

Kindly merge

approve


[Request] Add Internet Download Manager

Package Request
Information
Name: Internet Download Manager
Description: Internet Download Manager (IDM) is a tool to increase download speeds by up to 5 times, resume and schedule downloads.
Homepage: https://www.internetdownloadmanager.com/
Download link(s): https://www.internetdownloadmanager.com/download.html
Some indication of popularity/repute: I think it was used by many people(as it says it has over 2 Mio. users on its website), just don't know why it wasn't mentioned in this bucket.

The installer of IDM cannot be expanded by known tools, and it will install some system drivers which is hard to maintain.
If someone else finds some method, welcome to submit a PR.

Yes, it is. The only thing you should notice is the license field.

Ok, here are some things I found about the installer.

The installer file has a silent switch (/skipdlgs), there is no way to extract the files inside the installer file.
The uninstaller has no silent switches, and it forcefully restarts your computer at the end of the uninstallation process.

I don't think this program can be implemented in Scoop, as the one of the core parts of Scoop is to have a GUI free installation/uninstallation process.
The OP should stick with the package implemented in winget:
winget install Tonec.InternetDownloadManager


coreboot-toolchain: 4.16 -> 4.17

Description of changes

coreboot-toolchain: 4.16 -> 4.17

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Fails to build for me.

error: path '/nix/store/1yisfhp4wmkkmkp3vsvb6z3x648chscc-coreboot-8da4bfe' claims to be content-addressed, but has references. This isn’t allowed

@GrahamcOfBorg build coreboot-toolchain.i386 coreboot-toolchain.arm coreboot-toolchain.aarch64 coreboot-toolchain.riscv coreboot-toolchain.ppc64 coreboot-toolchain.nds32le coreboot-toolchain.x64

@GrahamcOfBorg build coreboot-toolchain.i386 coreboot-toolchain.arm coreboot-toolchain.aarch64 coreboot-toolchain.riscv coreboot-toolchain.ppc64 coreboot-toolchain.nds32le coreboot-toolchain.x64


Bebop2 with libVLC

Hi, I've had some issues with the libVLC demo code for the Bebop (using bebop 2 and windows 10):
Almost the whole lower half of the stream's pictures is in ultra low resolution, whereas the rest is fine.
The VLC window displays the stream, which suffers the flaw mentionned above.  The window crashes when closing: it seems like bebopVision.close_video() is the problem since the "print" after it doesnt show up. Do you know how to solve the quality and closing issues ?
Edit: For closing, inducing a syntax error at the end of the user code and then use bebop.disconnect() in the shell works quite well.
Thank you,

Glad you fixed it...

Do you have stream quality issues with your Bebop 2 ?

Not on 5Ghz.  On 2Ghz, for sure.  Move the Bebop to 5Ghz with the phone app.

I did, but im still getting pictures like the following :

The size of the blurred stripe hasnt even changed. Should I reset my drone ?
(If it helps, the blurred part is actualized every 1 or 2 second during the stream, unlike the rest (25 fps).
Thank you,

I definitely would try a reset.  Do you get the same strange area on your phone when you look at the video?  Have you recorded from the drone and is it showing there?  Almost like your camera isn't sending the last part right.  Definitely not what I see.  I see dropped frames a lot but not that!

p.s. if you reset you have to go back to 5Ghz again.

The reset didnt change anything, and videos with freeflight pro are fine. I'll try with other versions of VLC.

Even using the oldest working versions (like 3.0.2) didn't solve it. Could it have something to do with the bebop's software version ?

I really don't know :( I've never seen that issue on mine at all!

I created a linux (ubuntu 18.04) partition on the same computer and the bug disappeared. Really don't understand the problem since the versions are the same, but well, it works.

Hi! I am having exactly the same issue (a blurry bar at the bottom of the VLC).  Did either of you discover a fix to this problem, other than running it on linux?


API Product overview page breaks due to CORS Configuration being null

API Product overview page breaks due to CORS Configuration being null. Need to check if the type is API Product and ignore CORS Configuration

Fixed with https://github.com/wso2/carbon-apimgt/pull/6876


FIX: Logging for Text Input

I forgot to make sure the logging actually happened! Also fixed the docs.

Codecov Report

Merging #354 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   89.03%   89.03%   +<.01%
==========================================
  Files          44       44
  Lines        5681     5682       +1
  Branches      917      917
==========================================
+ Hits         5058     5059       +1
  Misses        427      427
  Partials      196      196

Thanks @maddycapp27


hdl._ir: derive DriverConflict from Exception instead of UserWarning.

We're not using it as a warning ever anymore, right?

We're not using it as a warning ever anymore, right?

yup.


[Event Hubs] Hot fixes to v2.x.x of Event Hubs library

Closing this issue as v2 of Event Hubs is in maintenance mode in favor of v5 of the same package


Add debbugging tools - validation and interactive debugger

Hi ! I am so happy to see you (all of you) were able to do this first mixture of the pest3 project. I gave it a try, and it is amazing.
I noticed that two things I liked in pest:

Automatic validation of some properties through validators
An interactive debbuger

I noticed the validators are listed in the todo file. I would like to work on implementing static validators for ensuring a parser runs in finite time.
Is that something I can do at this stage of the project ?
For the debugger, it would be nice to have, but I think it could take much more work. I can still give it a shot if it's wanted.

If i am reading the code organisation right, validators could be implemented in a similar place as in pest, under the meta crate.
I believe they should be optional (maybe on by default) so that it is possible to write a validator that ensures the parser will run in finite time, at the cost of saying some grammars aren't valid. For that reason they should be optional, so that if the grammar writers are confident, they can take care of validating manually.
Something very cool would be to integrate some keyword (like unsafe in Rust). But that would add maybe unnecessary complexity to the grammar of pest. It could also be done using specifically formatted comments (like JSDoc/Typescript), thus avoiding polluting the grammar.

I gave some thought to the things you said up there.
One of the things I wanted when writing validators, was to add metadata to make the validating process more feasible/robust/precise. I think back there you or someone else told me it would make the code too complicated or something like that. Now if there was an event api that acts as the core of the parser, on which we put can put the ast-builder and other things independently, I think using metadata in the validation process would be acceptable.
It would simplify making the debugger-friendly parser generator.
(I imagine that you thought of this things or similar ones when you introduced the idea of an event based parser.)
All that to say it might be better to start thinking about that event based api and then come back on the tooling.


Set requireUserVerification to false during registration and authentication flow

Follow up of #18 to set requireUserVerification: false on the verifyRegistrationResponse and verifyAuthenticationResponse so that it actually uses the userVerification preference, as per: https://github.com/MasterKale/SimpleWebAuthn/blob/a169def3c663cb671cdc6bc6e00a4993944a61ae/packages/server/src/authentication/verifyAuthenticationResponse.ts#L210
This properly fixes the issue outlined in #18, where the following error is presented on registration or authentication if the user verification method is not available (i.e. Macbook is in clamshell mode and TouchID is not available): "User verification required, but user could not be verified".

Published as 0.3.3


Mzml reading

@yangkl96 Missing pyteomics in requirements/requirements.txt

Thanks for pointing this out. I tested with a new environment and freshly downloaded the packages in requirements.txt

close #95


[HAMMER] Test only on ruby 2.4.5

Bump hammer travis.yml to ruby 2.4.5

@simaishi @Fryguy what do you think of dropping ruby 2.3.x on hammer now that we have a branch and are approaching the first release?  According to my records, we're using 2.4.5 so I'm thinking we should only test on that versions on hammer.
I also removed the allow_failures since we're testing only on 2.4.5 and also fix the exclude testing on 2.4.5 for brakeman.

@simaishi @Fryguy what do you think of dropping ruby 2.3.x on hammer now that we have a branch and are approaching the first release?

I don't see any issue dropping 2.3.x


[Github] Bulk entity extension

The new BulkEntityExtension allows to define fields for different entities within one class. It removes the overhead of creating multiple classes for each entity and allows to define the fields in one place.
<?php

namespace Examples\Extension;

use Shopware\Core\Content\Category\CategoryDefinition;
use Shopware\Core\Content\Product\ProductDefinition;
use Shopware\Core\Framework\DataAbstractionLayer\BulkEntityExtension;
use Shopware\Core\Framework\DataAbstractionLayer\Field\FkField;
use Shopware\Core\Framework\DataAbstractionLayer\Field\ManyToOneAssociationField;

class MyEntityExtension extends BulkEntityExtension
{
    public function collect(): \Generator
    {
        yield 'product' => [
            new FkField('follow_up_id', 'followUp', ProductDefinition::class),
            new ManyToOneAssociationField('followUp', 'follow_up_id', ProductDefinition::class, 'id')
        ];

        yield 'category' => [
            new FkField('linked_category_id', 'linkedCategoryId', CategoryDefinition::class),
            new ManyToOneAssociationField('category', 'linked_category_id', CategoryDefinition::class, 'id')
        ];
    }
}

Examples.zip

Imported from Github. Please see: https://github.com/shopware/shopware/pull/5363

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-39734, comment 518498]


Hot to run a flow via command line?

Hi,
May be i am missing something but after reading the docs I can't figure out how to run a certain flow via command line.
thank you!

Use the mailing list for questions or feature requests: https://groups.google.com/forum/#!forum/node-red

The relevant documentation is here
http://nodered.org/docs/getting-started/running.html
Look under command line usage, invoke as
node-red my-new-flows.json
Note that you may need to have -s (--settings) and -u (--userDir) to get the settings file and the user directory right as well.
I'd put this in as a documentation bug, the docs could stand to be a bit more comprehensive here.

@mc007 does the reply from @vielmetti answer your question? Is that what you were trying to do?

Hi, sorry, was AFK.
yes, that would answer the question, I really missed the 'flows.json' argument in the docs. Now assuming,  this node will runs forever, is there any chance to actually stop it the same way?
Sorry getting offtopic now, I am developing authoring web software and my idea about node-red is to enable users to run red-node flows in my own VPL(visual block language). So I would need all sorts of controls, ie start/stop/resume/pause. Might it be possible to have a client-side run-time for node-red (similar as in noflow)? That would be great!
thanks again!


Is there any plans on GlowFilter and DropShadowFilter?

Just like in Flash:
https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/filters/GlowFilter.html
https://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/filters/DropShadowFilter.html
It's very useful, hope involved, thank you.

Yes, They're on the list of TODO's on my desk right now. They're derivatives of a blur filter so you can implement them yourself in the mean time (if you're not sure how, feel free to ask). We've been a little heads down on some major internal pipeline updates for EaselJS but as those things are starting to wrap up some more filters are definitely planned. You can have a peek at a couple of the new commers here:
https://github.com/DavidHGillen/EaselJS/blob/master/src/easeljs/filters/AberrationFilter.js
https://github.com/DavidHGillen/EaselJS/blob/master/src/easeljs/filters/DisplacementFilter.js

Dropshadow and glow are already supported in Stage (@DavidHGillen is talking about StageGL) via myDisplayObject.shadow. Note that a glow is just a shadow with no offset.

@sky0014 This demo should help :) https://codepen.io/createjs/full/c11bb6183ed1248440aeb5aa68a89e7d/

@DavidHGillen thank you for your reply. Actually I modified a third-party library to use for now( https://github.com/u-kudox/Filters_for_EaselJS ), But I think it's better for you guys to implement it. 😄

@gskinner @sebastianderossi Thank you for the demo : )
I tried shadow and stroke to make some effect like GlowFilter does in Flash. But I found that there's some tiny difference. I used with Text, my parameters is GlowFilter(0,1,2,2,3). I found it's hard to expand four directions. If I draw with lager font-size to simulate shadow, position may be dislocation.

@sky0014 Any chance you could share your modifications to that library?


Feat: add topologySpreadConstraints traits

Description of your changes
Add topologySpreadConstraints traits, see https://github.com/kubevela/kubevela/issues/5086#issue-1454530536
I have:

[ x] Read and followed KubeVela's contribution process.
[ x] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ x] Run make reviewable to ensure this PR is ready for review.
[ x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
The code was tested with the usage example provided

Is it proper to make this trait as an addon? ping @Somefive

Is it proper to make this trait as an addon? ping @Somefive

I'm okay with the addon solution and the kubevela main repo solution.

LGTM, please fix the DCO.

Done. Thanks. Jerome


Fix for Issue #525

This is a fix for issue 525. I have a script that rewrites /etc/netplan/01-netcfg.yaml file to read as it should.
https://github.com/clong/DetectionLab/issues/525

Thank you @man715 !


Generating spec pulls in unused enumeration types from Protobuf-generated files

Problem statement
I have an enumeration definition that isn't used by any documented routes or models, but is being automatically included in a generated swagger.json file when running swagger generate spec. Due to our code structure, I end up with dozens of these model definitions that serve no purpose in our interface and have no documentation. Is there a way to request that these type definitions be skipped in the generation process?
There are a lot of moving parts with this, so bear with me please.
I have a need to generate Go bindings for a Google Protobuf file, using protoc and protoc-gen-go. In our messages, we have a Message ID enumeration that differentiates the messages, like so:
message Test {     enum MessageId     {         ID = 1;     } }
which generates the following Go code:
type Test_MessageId int32 const (     Test_ID Test_MessageId = 1 ) var Test_MessageId_name = map[int32]string{     1: "ID", } var Test_MessageId_value = map[string]int32{     "ID": 1, } ... proto.RegisterEnum("Test_MessageId", Test_MessageId_name, Test_MessageId_value
Nowhere in my Go project is "Test_MessageId" used, other than this file. No go-swagger documented routes or models lead back to this "enum" type definition, yet running the spec generator results in a swagger.json file that contains a definition for the enumeration:
{ ...   "definitions":      "Test_MessageId": {       "type": "integer",       "format": "in32",       "x-go-package": "test/gpb_gen_test"     }, ... }
If this problem is prohibitively difficult to workaround (which I suspect it will be given the interaction with GPB and other tools), then would it be possible to have a type comment similar to "swagger:model" that ignores a particular type when generating a spec, such as "swagger:ignore" or "swagger:skip"? That would be sufficient for my needs, as I can programmatically insert those comments as needed during our build process. Thanks in advance!
Swagger specification
2.0
Steps to reproduce

Create a .proto file with a message containing an enum (shown above)
Download protoc and protoc-gen-go, then run "protoc --go_out=. Test.proto" to generate Go bindings
Insert said file into a project that has swagger:model and swagger:operation meta-comments without using the enumeration anywhere
Run "swagger generate spec -o ./swagger.json -m main.go" on the Go project
Inspect swagger.json to see extraneous type definition

Environment
go-swagger version: 0.11.0
go version: 1.8.3
OS: Windows 10

if you don't use -m do still see the issue?

I make use of swagger:model to mark the types generated by protoc as definitions for use by the routes. So if I take out -m, I don't get the enumerations, but I also don't get any of the definitions that I do need.

In order to properly close this issue, swagger:ignore annotation should be documented in docs/generate/spec


(Labman LBCS) Submitting job while the quadrants are "COMPLETED" is prohibited. Should only be able to submit when its "EMPTY"

Email (Optional)
No response
Problem
Previously Labman API allowed submission of input files on a "COMPLETED" quadrant. Now they have updated their code.
Proposed Solution
Need to test
Alternatives
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

---------------------------------------------------------------------------
LabmanError                               Traceback (most recent call last)
C:\Users\CEDER-~1\AppData\Local\Temp/ipykernel_31056/662574945.py in <module>
----> 1 quadrant.submit_workflow(name="LABMAN_PM1", inputfiles_as_json={"test":inputfile_json})

~\Documents\GitHub\alab_one\src\alab_one\devices\labman_quadrant.py in submit_workflow(self, name, inputfiles_as_json)
    144         print(f"mixingpot_to_sample: {mixingpot_to_sample}")
    145         self.take_control()
--> 146         self.driver.submit_workflow_json(workflow_json)
    147         self.release_control()
    148         self.set_message(f"Working on workflow: {name}.")

c:\Users\Ceder-ALAB\anaconda3\lib\site-packages\alab_control\labman\labman.py in submit_workflow_json(self, workflow_json)
    465
    466     def submit_workflow_json(self, workflow_json: dict):
--> 467         self.API.submit_workflow(workflow_json)
    468         self.logging.info(
    469             category="labman-workflow-submit",

c:\Users\Ceder-ALAB\anaconda3\lib\site-packages\alab_control\labman\api\api.py in submit_workflow(self, workflow_json)
    103     def submit_workflow(self, workflow_json: dict):
    104         url = f"{self.API_BASE}/PotsLoaded"
--> 105         return self._post(url, json=workflow_json)
    106
    107     def pots_unloaded(self, index: Literal[1, 2, 3, 4]):

c:\Users\Ceder-ALAB\anaconda3\lib\site-packages\alab_control\labman\api\api.py in _post(self, url, **kwargs)
     31
     32         response = requests.post(url=url, **mixed_kwargs)
---> 33         return self._process_labman_response(response)
     34
     35     def _process_labman_response(self, response: requests.Response) -> dict:

c:\Users\Ceder-ALAB\anaconda3\lib\site-packages\alab_control\labman\api\api.py in _process_labman_response(self, response)
     52             return response.get("Data", {})
     53         else:
---> 54             raise LabmanError(response["ErrorMessage"])
     55
     56     ### API Calls

LabmanError: Failed to load pots. Workflow name LABMAN_PM1, rack 4. Cannot load pots to quadrant 4. The quadrant is Complete

Behavior is as expected. Error handled properly.

Additionally, an assertion in powder_dosing has been added to prevent any unexpected non-empty quadrant.

refer to some part in the end of this file:
C:\Users\Ceder-ALAB\Desktop\ALab One Experiments\20240129 LABMAN PM\20240129 LABMAN PM.ipynb
for reproducing


[WIP] Implement VmService instead of adding extension methods

@zanderso I think this one can be closed, right?


Fun & Games

Doesn't a game always have rules, stated or implied? This is just: "guess my password" with no indication that it's even possible.

I imagine that's the point, it isn't really a game. Just shows how much additional security is added by including the passphrase, the full mnemonic has been exposed for over a year and nobody can touch the wallet.

Man plz tell us hint.. I really need it

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Don't miss out on your $1500 in BNB! Act now to secure your tokens.
Winners: @

Can't

Him not say any hint about Passphrase

instead of implying this as game, better say "hack me if you can"
which is pointless

Corey Phillips he said on his twitter "It's not meant to be solved. It's meant to prove the viability of the method" I tested a few thousand combinations using brute force, your method is really safe


Update dependency typescript to ^5.5.4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.61%. Comparing base (0fa99a3) to head (1dfc0d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   97.61%   97.61%
=======================================
  Files          20       20
  Lines         168      168
  Branches       42       43    +1
=======================================
  Hits          164      164
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


bugfix

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Fix wrong size of mask in remdet-ins post-processing. #11230
Modification
Please briefly describe what modification is made in this PR.
            if rescale:
                ori_h, ori_w = img_meta['ori_shape'][:2]
                mask_logits = F.interpolate(
                    mask_logits,
                    size=[
                        math.ceil(mask_logits.shape[-2] * scale_factor[1]),  # modified scale_factor[0] to scale_factor[1]
                        math.ceil(mask_logits.shape[-1] * scale_factor[0])  # modified scale_factor[1] to scale_factor[0]
                    ],
                    mode='bilinear',
                    align_corners=False)[..., :ori_h, :ori_w]

Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: test case file format for aggregate functions

max([20, -3, 1, -10, 0, 5]::i8) = 20::i8
corr([20, -3, 1, 10, 5]::fp32, [20, -3, 1, 10, 5]::fp32) = 1::fp64
some_agg_func([30, 3, 1, 10]::i32, ['app', 'bat', 'cat', 'dog']::string) = 30::i8

It doesn't work well with multi argument aggregates. Maybe we need to declare a table of data and then refer to in test cases? Other thoughts on multi args

It doesn't work well with multi argument aggregates. Maybe we need to declare a table of data and then refer to in test cases? Other thoughts on multi args

Option1:
corr([20, -3, 1, 10, 5]::fp32, [20, -3, 1, 10, 5]::fp32) = 1::fp64
In the parsing we could check both columns have same number of elements.
Option2:
corr([(20, 20), (-3, -3), (1, 1), (10,10), (5,5)]::Table(fp32, fp32)) = 1::fp64

Option3:
DEFINE TABLE test_table WITH SCHEMA (x fp32, y fp32) AS
     VALUES [(20, 20), (-3, -3), (1, 1), (10, 10), (5, 5)];

# basic tests of corr
corr(test_table.x, test_table.y) = 1::fp64

# basic tests of mean
mean(test_table.x) = 6.6::fp64
mean(test_table.y) = 6.6::fp64

How about we start with supporting these and reexamine how we're enjoying them in 3-6 months?
multi-reference
DEFINE t1(fp32, fp32) = ((20, 20), (-3, -3), (1, 1), (10,10), (5,5))
corr(t1.col0, t1.col1) = 1::fp64
compact
((20, 20), (-3, -3), (1, 1), (10,10), (5,5)) corr(col0::fp32, col1::fp32) = 1::fp64
supercompact (single argument only)
avg((1,2,3)::fp32) = 1::fp64

How we might support a function that takes a aggregate reference and a constant value.
((20), (-3), (1), (10)) LIST_AGG(col0::fp32, ','::string) = 1::fp64
Single-valued arguments are passed in a direct literals. Multi-valued are passed as references.


add support to link dynamic sockets (inputs and outputs)

AiiDA process can have dynamic inputs and outputs.
The dynamic inputs can only know when the job started, and the dynamic outputs can only know when the job finished.
Both of them can not be used in
wt.links.new()

It is recommended that users define the inputs and outputs explicitly.
Support users create a task from an AiiDA component that has dynamic outputs, and the user wants to use the output x from this dynamic outputs, the user can add the x output to the task by:
tasks.outputs.new("Any", "x")

The last option is to pass the entire output as the input of the next task.
wg.links.new(task1.outputs["_output"], task2.inputs["some_input_name"])

I closed this issue for now. If there is a use case that can not covered by these two solutions, we can reopen it again.


Northbound security channel - Crypto architecture analysis

We wrote a document describing the problem and the proposed solution.
We discussed it with dojot's architect in order to align understanding and get feedback.
The document was updated with clarifications.


Make story ads configuration more predictable

Feature Description

From Support:
Just want to quickly report on the commonly asked questions around ads.
Generally, users inquire about how long would it take before ads will display. Then, they'll ask us to confirm if the configuration is correct, or if a script needs to be added to the page before they can see ads, etc. I've also noticed that users do frequently ask what a slot ID is or if it is required.
Based on that, I would suggest that we consider providing additional helpful messaging on the settings page. For example:
After the users have inserted their IDs, include a message indicating, "AdSense has been successfully configured"
Include a message indicating the configuration has been set and to please allow additional time until the ads can be served
Here is the list of ad topics where these questions were asked:
https://wordpress.org/support/topic/web-stories-monetisation/
https://wordpress.org/support/topic/ads-settings/
https://wordpress.org/support/topic/amp-story-auto-ads/
https://wordpress.org/support/topic/ads-not-showing-62/#post-13943743
https://wordpress.org/support/topic/1-3-0-monetization-option-not-visible-under-settings/
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Some simple tweaks that I think may help here.

Under "Enter your Slot ID" for AdSense, update the copy to add after Example:<PHONE_NUMBER> the following:

Copy data-ad-slot from your ad unit for Web Stories. The same ad unit will be used for all of your Web Stories.

After "Learn more about how to monetize your Web Stories using AdSense." add:

Once configured, AdSense will determine where and how to insert ads into the story. Consult AdSense Help for any further assistance.

@o-fernandez @swissspidy
Is this what is expected.

@spacedmonkey there are two periods/dots at the very end of the slot ID help text, otherwise looks great!

Verified in QA


Added UP in the list

Nice to see a company outside of Kathmandu valley, the first one on the list.
Thanks @kalwar

@mesaugat Thanks for creating and maintaining the list.


Remove author information for scaling branch.

For #4332 .
Changes proposed in this pull request:

Synchronize newest code from master branch.
Remove the author information in comments.

Close Pull request due to wrong target branch.

Pull Request Test Coverage Report for Build 9728

1700 of 2418 (70.31%)  changed or added relevant lines in 120 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.3%) to 59.988%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/utils/RuntimeUtil.java
0
1
0.0%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/config/RdbmsConfiguration.java
3
4
75.0%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/datasource/DataSourceFactory.java
8
9
88.89%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/position/LogPositionManagerFactory.java
3
4
75.0%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/position/NopLogPosition.java
1
2
50.0%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/record/RecordUtil.java
12
13
92.31%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/web/entity/ResponseCode.java
0
1
0.0%

sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/web/util/ResponseContentUtil.java
15
16
93.75%

sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/binlog/MySQLPasswordEncryptor.java
11
12
91.67%

sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/binlog/codec/AuthenticationMethod.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
3
76.0%

Totals

Change from base Build 912:
1.3%

Covered Lines:
12535

Relevant Lines:
20896

💛  - Coveralls


Prev., Next button IE fix

Closes https://github.com/apinf/platform/issues/1922

Will close it for now. Will need more time for fixing navigation buttons.
Simple change to <button> didn't work.


Fix https://github.com/onshape-public/java-client/issues/3

Fixes https://github.com/onshape-public/java-client/issues/3

@harmanpa the standard we use is that http://localhost.dev.onshape.com:8082 (for instance) is the baseUrl, instead of http://localhost.dev.onshape.com:8082/api Would it be possible to follow that convention for the setBaseURL and getBaseURL? That will make it more compatible with our other tools.


⚠ Bofrost.at has degraded performance

In 894a800, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1822 ms

Resolved: Bofrost.at performance has improved in 21a93ba after 6 minutes.


422 from API if 'incident_snip' is not included in payload

I noticed that if I don't include "incident_snip": "", in the json payload I get back a 422.
I don't believe we want to use or require 'incident_snip' from the API.
My understanding is that this maps to codeSnip in an analysis data such as
https://github.com/konveyor-ecosystem/kai/blob/main/example/analysis/coolstore/output.yaml#L226-L232
So we are asking for the source code at time of analysis to be passed in from codeSnip = incident_snip.
For our case, we are passing in the full file contents as they exist on disk, the assumption is they equal incident_snip.  It's possible in future maybe these things are not identical, but for now I think it'd make most sense to remove incident_snip and not use it.

We are currently using incident_snip to generate the embeddings (which I know we're not using right now). There are two solutions to explore.
Quick and easy: Rip out all the places where incident_snip is required, and replace it with a blank string if the user doesn't give us one. Luckily we never pass this to the prompt so it's all good. It's used in fuzzy_get_similar_incident for the embeddings, but again since we are ignoring them this shouldn't be an issue.
More involved: Change how the embeddings are handled, using the actual file contents as opposed to the snip. Then we can "truly" remove the
Going to code up the quick and easy one, and file an issue for later


extract_html.py BUG: dropping numbered lists

See part 2i, the sections toward the end with the workflow examples. The Google doc uses numbered lists, and the converter drops them all.

Now it is supported, only one level.


内存溢出

使用demo，添加了leakcanary
debugImplementation 'com.squareup.leakcanary:leakcanary-android:2.10'
发现有内存泄漏

====================================
HEAP ANALYSIS RESULT
====================================
1 APPLICATION LEAKS
References underlined with "~~~" are likely causes.
Learn more at https://squ.re/leaks.

5711226 bytes retained by leaking objects
Signature: 9c011792c1fee2068e51f4f6c021dbe8acafbbd3
┬───
│ GC Root: Global variable in native code
│
├─ com.huawei.openalliance.ad.ipc.g$a$1 instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2186 objects
│    Anonymous subclass of com.huawei.openalliance.ad.ipc.e$a
│    ↓ g$a$1.V
│            ~
├─ com.huawei.openalliance.ad.ipc.g$a instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2185 objects
│    ↓ g$a.I
│          ~
├─ com.huawei.hms.ads.jz$a instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2182 objects
│    V instance of com.huawei.hms.ads.sdk.AdSampleApplication
│    ↓ jz$a.Code
│           ~~~~
├─ com.huawei.hms.ads.gi$3$1 instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2181 objects
│    Anonymous class implementing com.huawei.openalliance.ad.ipc.RemoteCallResultCallback
│    ↓ gi$3$1.Code
│             ~~~~
├─ com.huawei.hms.ads.gi$3 instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2180 objects
│    Anonymous class implementing java.lang.Runnable
│    ↓ gi$3.I
│           ~
├─ com.huawei.hms.ads.gl instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2174 objects
│    ↓ gi.g
│         ~
├─ com.huawei.hms.ads.sdk.SplashActivity$splashAdLoadListener$1 instance
│    Leaking: UNKNOWN
│    Retaining 5.7 MB in 2081 objects
│    Anonymous subclass of com.huawei.hms.ads.splash.SplashView$SplashAdLoadListener
│    this$0 instance of com.huawei.hms.ads.sdk.SplashActivity with mDestroyed = true
│    ↓ SplashActivity$splashAdLoadListener$1.this$0
│                                            ~~~~~~
╰→ com.huawei.hms.ads.sdk.SplashActivity instance
     Leaking: YES (ObjectWatcher was watching this because com.huawei.hms.ads.sdk.SplashActivity received
     Activity#onDestroy() callback and Activity#mDestroyed is true)
     Retaining 5.7 MB in 2080 objects
     key = 2e68a336-f5b1-45ba-a8c0-c87c8c611538
     watchDurationMillis = 215568
     retainedDurationMillis = 210566
     mApplication instance of com.huawei.hms.ads.sdk.AdSampleApplication
     mBase instance of android.app.ContextImpl
====================================
0 LIBRARY LEAKS

A Library Leak is a leak caused by a known bug in 3rd party code that you do not have control over.
See https://square.github.io/leakcanary/fundamentals-how-leakcanary-works/#4-categorizing-leaks
====================================
0 UNREACHABLE OBJECTS

An unreachable object is still in memory but LeakCanary could not find a strong reference path
from GC roots.
====================================
METADATA

Please include this in bug reports and Stack Overflow questions.

Build.VERSION.SDK_INT: 29
Build.MANUFACTURER: HUAWEI
LeakCanary version: 2.10
App process name: com.huawei.hms.ads.sdk
Class count: 13953
Instance count: 108441
Primitive array count: 82102
Object array count: 12306
Thread count: 23
Heap total bytes: 15318684
Bitmap count: 11
Bitmap total bytes: 5591915
Large bitmap count: 0
Large bitmap total bytes: 0
Stats: LruCache[maxSize=3000,hits=29626,misses=61116,hitRate=32%]
RandomAccess[bytes=3209214,reads=61116,travel=23344640116,range=18536222,size=23579980]
Heap dump reason: user request
Analysis duration: 3424 ms
Heap dump file path: /data/user/0/com.huawei.hms.ads.sdk/cache/leakcanary/2023-04-19_15-18-14_087.hprof
Heap dump timestamp:<PHONE_NUMBER>846
Heap dump duration: 1153 ms
====================================


[Python] - Fix for security vulnerability GHSA-r9hx-vwmv-q579 for setuptools-65.5.0 lib on python using debian image

Fix for security vulnerability GHSA-r9hx-vwmv-q579 for setuptools-65.5.0 lib on python using debian image.
Fixes issue #112

No longer needed.


Show the total number of matches in the Search tab

related #6669

Hi @kisstkondoros, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

This needs some layout fixing, see video:

@bpasero I've added a relayout call, but I'm not sure if that's the right way to fix this issue.
Perhaps the code
aria.status(message);

is obsolete if we show the results in a div with
aria-hidden="false"

What do you think?

Moving to @sandy081 who took over work in this area.


New package: Lablib v0.1.0

Registering package: Lablib
Repository: https://github.com/jefter66/Lablib
Created by: @jefter66
Version: v0.1.0
Commit: 076b973ec01f39bf2cb2015f92d674243b55cb37
Git reference: HEAD

@giordano i was not aware that i didn't needed to register a package in order to use it like that (perhaps should've read the documentation a little more) . I'll keep what you said in mind when contributing in the future. Thank you.


Upgrade to Scala 2.11.6, sbt 0.13.8, spray 1.3.3, parboiled 1.1.7

I plan on bumping specs2 in a different PR.

:rocket:


FEATURE REQUEST: circular buttons for horizontal button stack

Right now when I have a horizontal button stack, the buttons are oblong (I don't put any text in them). Is there a way to make them smaller and mabye with a bit less padding between the border and the icon. I tried a little to do this with the styles, but didn't get much luck. I dn't mind going that route though if it's possible

I actually accomplished this with card_mod. So you can probably just close this one. But one question. Is there a way to change the space between the buttons? I noticed when I add a lot, that the ones that go off the screen are closer together (I was just testing to see how many I could fit on my phone screen without scrolling).
You can see that the ones at the end are closer together

and here is when I scroll to the end.. the last 4 have less space between them

So I see that the margin is hard coded to 12 (I assume pixels). I did some playing aroud and while on the web I can get it down to 1px and it looks like 1px. Something must be adding more in mobile, but either way, I can get it down. Could this be changed from a hard coded value to a setting? it's around line 905;.

BTW, the extra space in mobile was because the card uses local storage for the width of the buttons. I had to clear storage on the HA app on my phone to fix. Would not normally be an issue if you had the card_mod stuff done prior to loading it in the app for the first time.
Still would be interested in being able to adjust the "gap" between tems.


SuperFeature modelviewset

this is the modelviewset that’ll be used for the super feature CMS. also did some reorganizing @mparent61 @benghaziboy

Other than naming, LGTM

Coverage decreased (-0.03%) to 86.131% when pulling fa19e9acf17d0a57cbcbaeefa9289db15336d90c on sf-extras into f8bd1e690000e616dade6d799da5c5fcc29055b0 on master.

Coverage decreased (-0.01%) to 86.146% when pulling c607f169b613f10bff885b4b313a3f89d6ff61da on sf-extras into f8bd1e690000e616dade6d799da5c5fcc29055b0 on master.

Coverage increased (+0.1%) to 86.27% when pulling 3a771257245432bf028720bb0609034eac7c3a5c on sf-extras into f8bd1e690000e616dade6d799da5c5fcc29055b0 on master.

Coverage decreased (-0.09%) to 86.081% when pulling a7583ff4f3cd35512abdd7009507512c5f42f7ac on sf-extras into 33d99f7e88f29eb0243ff06575702807557f9302 on master.


Where does it expect pdb to be?

Hello, and thanks for this amazing software!
My preferred workflow is: profiling an app on Windows machine, then downloading the MTuner report along with the pdb file, and running MTuner via Wine on a linux machine. Naturally I don't expect support of this scenario, but maybe I'm missing something easy?
The problem is that it doesn't load debug symbols, so all functions and locations appear as "unknown" in the GUI. I tried putting the pdb file (and, for the record, the exe one) in the same folder as the MTuner report and tried to point Local Store path to the directory with the pdb file, but it still doesn't seem to load them. What can I do?
Thanks!

It also says "file may be corrupt" in 2/3 of times, even though the app exits with code 0 and the mtuner file is 200mb - 2gb :(

Thanks for the quick answer. What can I do on my side to prevent files from corruption?

Oh. How to "force" load the file then? It doesn't show anything when it fails to load the file with this error


Running apollo under Windows results in weird USB "permission denied" errors

I suspect somewhere a handle to the apollo USB device isn't being released, and libusb is returning "permission denied" when a second handle attempts to be obtained.
I believe the first time it tries to acquire this handle is when it queries the apollo for the board version. Manually specifying LUNA_PLATFORM=luna.gateware.platform.luna_r0_4:LUNAPlatformRev0D4 bypasses this check and the gateware uploads successfully.

This should be fixed after merging https://github.com/greatscottgadgets/apollo/pull/6 and #144

This is all working now.


Extract register view functionality

Fixes #1041

branch is out of date I believe with the morning merge, apologies, will click the big green button once it's fixed up - thanks


Cannot generate d.ts using dotnet 8.0

In Readme.md it's written like this :

Generate TS type definitions for .NET APIs
If writing TypeScript, or type-checked JavaScript, there is a tool to generate type .d.ts type definitions for .NET APIs.

However, when I'm trying to use it, it has this error
You must install or update .NET to run this application. App: /usr/bin/node Architecture: x64 Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64) .NET location: /**redacted**/.dotnet The following frameworks were found:   8.0.0 at [/**redacted**/.dotnet/shared/Microsoft.NETCore.App] Learn more: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&arch=x64&rid=linux-x64&os=archcraft /**redacted**/.npm/_npx/2fb4d186a11c44f3/node_modules/node-api-dotnet/init.js:32   return nativeHost.initialize(targetFramework, managedHostPath, require);                     ^ Error: Failed to inialize CLR host. Status: FrameworkMissingFailure
Is this intended as in I have to install dotnet 6 or is it a bug ?

The TS generator tool targets .NET 6 (so it can be used with that version), though I thought it should work also on .NET 8, without having .NET 6 installed. I'll look into this when I get a chance; for now yes you can workaround by installing .NET 6.

Fixed with #215


Fixed ConvertFromOATime range bug.

Added range checking to ConvertFromOATime in Excel.Core.Helpers.cs to prevent exception when out of range value is in spreadsheet.  Now sets the value to them max + or - depending on which sign is out of range.

Sorry it took me so long to get back to this.  What is the best way for me to address this issue?  Should I continue to work from my current fork or abandon this fork and create a new from the root.  I'm still a noob at this.
Thanks.

I think carry on from current fork and submit new pull request
On Tue, Jun 16, 2015 at 4:42 PM, Stephen Holle<EMAIL_ADDRESS>wrote:

Sorry it took me so long to get back to this. What is the best way for me
to address this issue? Should I continue to work from my current fork or
abandon this fork and create a new from the root. I'm still a noob at this.
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/ExcelDataReader/ExcelDataReader/pull/20#issuecomment-112475299
.

--
Ian Cox
C.T.O.
Release  Mobile
m:            Matrix Studios, 91 Peterborough Road, London, SW6 3BU
w:            http://www.releasemobile.com
Registered in England.  Number 06323661

I can't seem to open a new pull request on this branch?

Does this help?
http://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request

If this is still a problem, can you please submit a new PR against the develop branch which also includes a test demonstrating the problem (i.e a spreadsheet with out of range date). There is probably a spec for "OADate" somewhere which says what the correct values for these constants should be.


CAMEL-16139: Support for global autoDiscoverObjectMapper override

I would like to be able to override the global default of autoDiscoverObjectMapper  in the Java DSL.  Picked an option similar to how spring boot does this.  Global override is only applied if defined and not overridden in the definition.

[ X] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[X ] Each commit in the pull request should have a meaningful subject line and body.
[X ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

Use DataFormatCustomizer instead. You can register it into the registry where you can configure the data format from Java DSL as you like.
We dont want to use global options as its end up being a dumping ground - ideally we get rid of it in the future, and move its few configurations to different model.


tests/kernel/fp_sharing/float_disable failed when code coverage is enabled on qemu_x86.

Describe the bug
the common tests/kernel/fp_sharing/float_disable can pass on qemu_x86, bu if with the CONFIG_COVERAGE, it failed.
To Reproduce
Steps to reproduce the behavior:

west build -b qemu_x86 tests/kernel/fp_sharing/float_disable/ -DCONF_FILE=prj_x86.conf
-DCONFIG_COVERAGE=y
or using sanitycheck -p qemu_x86 --coverage -T tests/kernel/fp_sharing/float_disable
west build -t run
See error

Screenshots or console output
SeaBIOS (version rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org)
Booting from ROM..Optimal CONFIG_X86_MMU_PAGE_POOL_PAGES 11
E: General Protection Fault
E: Exception code: 0x0
E: EAX: 0x00160660, EBX: 0x00009500, ECX: 0x00000046, EDX: 0x00178578
E: ESI: 0x00000000, EDI: 0x00160b20, EBP: 0x00178540, ESP: 0x00178500
E: EFLAGS: 0x00000012 CS: 0x0008 CR3: 0x001602a0
E: call trace:
E: EIP: 0x00100338
E:      corrupted? (bp=0x00178540)
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Current thread: 0x00178578 (unknown)
E: Halting system

Environment (please complete the following information):

OS: fedora28
Toolchain: zephyr-sdk-0.10.3
Commit ID: cb87cc8fd636

@andrewboie  after the "__aligned(0x20) struct x86_mmu_pdpt user_pdpt;" removed from arch/x86/include/ia32/kernel_arch_thread.h in #19968, this test case failed, when I added it, it will be ok.
do you know the root cause?

this test case failed, when I added it, it will be ok.
do you know the root cause?

That's very odd. It changes the size of the thread struct, but otherwise should have no effect.
What instruction is at 0x00100338 that caused the fault?

sorry, i don't know how to cat instruction according to address.
I add some gdb information below, is this useful?
0x00139871 in _handle_exc_13_vector_13_stub ()
Single stepping until exit from function _handle_exc_13_vector_13_stub,
which has no line number information.
_exception_enter () at   arch/x86/core/ia32/excstub.S:72

several ways:

in gdb, "disassemble 0x00100338"
addr2line from shell.
look in build/zephyr/zephyr.lst

ok, thanks.
i ran the disassemble 0x00100338 in gdb, the information as follows:
Dump of assembler code for function arch_swap:
0x00100320 <+0>:     push   %edi
0x00100321 <+1>:     mov    $0x160b20,%edi
0x00100326 <+6>:     push   %esi
0x00100327 <+7>:     push   %ebx
0x00100328 <+8>:     push   %ebp
0x00100329 <+9>:     pushl  0x13fb60
0x0010032f <+15>:    mov    0x8(%edi),%edx
0x00100332 <+18>:    mov    %esp,0x28(%edx)
0x00100335 <+21>:    mov    0x24(%edi),%eax
0x00100338 <+24>:    fxsave 0x90(%edx)
0x0010033f <+31>:    fninit
0x00100341 <+33>:    fxrstor 0x90(%eax)
0x00100348 <+40>:    mov    %eax,0x8(%edi)
0x0010034b <+43>:    mov    0x28(%eax),%esp

0x00100338 <+24>: fxsave 0x90(%edx)

This will GPF if the supplied memory address is unaligned. It's a bit mysterious how this is happening, but the solution for #17893 will fix this.

run "fxsave _thread_offset_to_preempFloatReg(%edx)",
(gdb) x $edx
0x178578 <_interrupt_stack+5496>:  0x00000000
and I find the _thread_offset_to_preemFloatReg is 0x90(0x80+0x10) in generated/offset.h file.
for the "fxsave m512byte" destination operand contains the first byte of the memory image, and it must be aligned on a 16-byte boundary. A misaligned destination operand will result in a general-protection (#GP) exception being generated.

without the CONFIG_COVERAGE,  I found the defined struct k_thread dummy_thread in z_cstart function address is 0x13e570<interrupt_stack+5488>, this is aligned to 16 bytes boundary.
(gdb) p _kernel
irq_stack=0x143800<interrupt_stack+26624>, current=0x13e570<interrupt_stack+5488>
however, when i enable the CONFIG_COVERAGE, the dummy thread address is 0x178578<interrupt_stack+5496>, not aligned to 16 bytes.
(gdb) p _kernel
irq_stack=0x17d800<interrupt_stack+26624>, current=0x178578<interrupt_stack+5496>
with the code #19968, it will influence the size and alignement of sttuct k_thread, so the dummy thread address is 0x178540<interrupt_stack+5440>, is also 16 bytes aligned.

@andrewboie Did you prefer to keep this open for discussion?
I suggest to close this, tests/kernel/fpu_sharing/float_disable is successful for qemu_x86 with and without coverage option enabled. Note the directory name changed slightly /fp_sharing/ -> /fpu_sharing/.
$ west build -p  -b qemu_x86 tests/kernel/fpu_sharing/float_disable/ -DCONF_FILE=prj_x86.conf -DCONFIG_COVERAGE=y
...
$ west build -t run
-- west build: running target run
[0/1] To exit from QEMU enter: 'CTRL+a, x'[QEMU] CPU: qemu32,+nx,+pae
SeaBIOS (version rel-1.12.1-0-ga5cab58-dirty-20200516_152813-e7ee184eb100-zephyr
)
Booting from ROM..*** Booting Zephyr OS build zephyr-v2.3.0-2856-g1a7cd6ddbdcc  ***
Running test suite suite_k_float_disable
===================================================================
START - test_k_float_disable_common
 PASS - test_k_float_disable_common
===================================================================
START - test_k_float_disable_irq
Skipped for x86 or ARM without support for dynamic IRQs
 SKIP - test_k_float_disable_irq
===================================================================
START - test_k_float_disable_syscall
 PASS - test_k_float_disable_syscall
===================================================================
Test suite suite_k_float_disable succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

@jenmwms I think this is still an issue, we are just getting lucky. It all depends on the alignment of the dummy thread object that gets instantiated on the thread stack.
We need to somehow guarantee that the dummy thread on the call stack is 16-byte aligned.
It's not clear to me whether https://github.com/zephyrproject-rtos/zephyr/pull/19968 made this worse. But I haven't studied if the compiler makes any attempts to put aligned structs to their proper alignment when instantiated on the stack. The stack pointer isn't 16 byte aligned so I suspect not.

never mind! I fixed this and forgot all about it:
/* The core kernel code puts the dummy thread on the stack, which unfortunately
 * doesn't work for 32-bit x86 as k_thread objects must be aligned due to the
 * buffer within them fed to fxsave/fxrstor.
 *
 * Use some sufficiently aligned bytes in the lower memory of the interrupt
 * stack instead, otherwise the logic is more or less the same.
 */
void arch_switch_to_main_thread(struct k_thread *main_thread, char *stack_ptr,
				k_thread_entry_t _main)
{
	struct k_thread *dummy_thread = (struct k_thread *)
		ROUND_UP(Z_KERNEL_STACK_BUFFER(z_interrupt_stacks[0]),
			 FP_REG_SET_ALIGN);

	__ASSERT(((uintptr_t)(&dummy_thread->arch.preempFloatReg) %
		  FP_REG_SET_ALIGN) == 0,
		 "unaligned dummy thread %p float member %p",
		 dummy_thread, &dummy_thread->arch.preempFloatReg);

	z_dummy_thread_init(dummy_thread);
	z_swap_unlocked();
	CODE_UNREACHABLE;
}

We still have this problem when run the float_disable testcases with code coverage enabled.


[W5][T08-01]-ZhaoJunRu

Interesting enhancement, the confirmation is widely used and very relevant to this

Definitely a useful safeguard for newer users who accidentally type in the command


Error "ld: library not found for -lSystem" on macOS Big Sur

Hi, I'm trying to compile a "Hello World" program on macOs Big Sur 11.0.1 (20B29)
$ ponyc --version
0.38.1-bba16525 [release]
Compiled with: LLVM 9.0.1 -- AppleClang-<IP_ADDRESS>30032-x86_64
Defaults: pic=true

but linking fails
Writing ./helloworld.o
Linking ./helloworld
ld: library not found for -lSystem
Error:
unable to link: ld -execute -no_pie -arch x86_64 -macosx_version_min 10.12 -o ./helloworld ./helloworld.o -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/" -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/../lib/x86-64" -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/../packages" -L"/usr/local/lib"  -lponyrt -lSystem

Sorry if this is an FAQ... I literally tried pony for the very first time today, so please bear with me...
Thanks for your help!

Did you upgrade or do a fresh install of Big Sur?

Can you give the output of clang -v and which clang as well?

Hi @SeanTAllen , thanks for looking into this!

Did you upgrade or do a fresh install of Big Sur?

Upgrade

Can you give the output of clang -v and which clang?

$ which clang
/usr/bin/clang

and
$ clang -v
Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin20.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

How did you install pony?

I followed the instructions here: https://github.com/ponylang/ponyc/blob/master/INSTALL.md#macos
i.e. I installed ponyup with the provided script and then used that to install ponyc

Thanks. As far as I can tell (I don't have a Mac and our CI doesn't have Big Sur yet), with Big Sur they moved the location of a number of libraries. That MIGHT have an impact. I'm unsure. I'm trying to find someone in the Pony community who has a Big Sur install who might be able to help diagnose more fully. The limited information that I've found online for people experiencing similar problems with non-pony stuff is rather scattershot and doesn't provide any solid "it's definitely X" answers.

@lutzh can you run sudo xcode-select --install to make sure you have all the latest xcode command line tools installed?

I did, I don't think that's the problem, the output is
$ xcode-select --install
xcode-select: error: command line tools are already installed, use "Software Update" to install updates

but I'm pretty sure the XCode command line tools and everything else are up to date, there are no updates displayed in "Software Update".
I'm not quite sure where/how ld is invoked. Is there a way to pass additional arguments for the library path to the ponyc compiler?

Thanks @lutzh.
It does indeed look up to date.
There's a --linker option that you can use but you need to supply the entire "ld" command not just additions.
This is the command that is failing. You should be able to try changing to it as long after it fails once you don't run any other ponyc commands in the same directory (at least this is the command based on what you pasted- assuming it is correct and there was no copy/paste etc munging):
ld -execute -no_pie -arch x86_64 -macosx_version_min 10.12 -o ./helloworld ./helloworld.o -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/" -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/../lib/x86-64" -L"[..]/ponyup/ponyc-release-0.38.1-x86_64-darwin/bin/../packages" -L"/usr/local/lib"  -lponyrt -lSystem

It's quite possible that an additional path is needed for a -L to indicate where to find the System library. That in my mind is the most likely issue. If you can figure it out, we can do a PR to update the MacOS version going forward.
Here's the code in ponyc where the ld command is set up:
https://github.com/ponylang/ponyc/blob/7c05e1f2ee05f3de0ce2a9c09f671b38665260d3/src/libponyc/codegen/genexe.c#L295

Hi @SeanTAllen ,
Thanks again. Tried that, I can confirm that
ponyc --linker="ld -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib"
does work and I got to the the "Hello, world!" output I was looking for.
So it might be that some lookup rules changed in macOS 10.12 and this has to be passed to the linker as a library path. Or it might still be that some configuration is messed up just on my machine. I'll happily create a PR, but I hope what fixes it for me doesn't break it for anyone else...

From what I've read, this appears to be something that will be needed in general for Big Sur.
I'm surprised the xcode update didn't pick that change up automatically as what I read seemed to indicate that it would.
Can you run "which ld" and put the output here.
There's a couple other things to check which I'll add another note for once I'm not on my phone.

@lutzh what happens if you run:
ponyc --linker="ld -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib -lSystem"

Do you get a working hello world application?

@lutzh what happens if you run:
ponyc --linker="ld -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib -lSystem"

Do you get a working hello world application?

Yes I did, see my comment https://github.com/ponylang/ponyc/issues/3684#issuecomment-743979518
Well. I did not put in the "-lSystem" as that seemed redundant, but a quick check revealed it would still work if I did.
As for your other question,
$ which ld
/usr/bin/ld

Maybe also of interest
$ ld -v
@(#)PROGRAM:ld  PROJECT:ld64-609.7
BUILD 18:10:07 Oct 19 2020
configured to support archs: armv6 armv7 armv7s arm64 arm64e arm64_32 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em
LTO support using: LLVM version 12.0.0, (clang-1<IP_ADDRESS>) (static support for 27, runtime is 27)
TAPI support using: Apple TAPI version 12.0.0 (tapi-1<IP_ADDRESS>)

Excellent. Thanks. So it appears the solution would be to add -L/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib when on Big Sur or higher. (I believe that is version 11.0).
In link_exe we don't currently distinguish between different Mac versions when doing any of the work. I think therefore, it would reasonable to add the -L addition in general when on MacOS as I don't think that it causes any issues (but I'm not sure- CI should catch if it does).
The primary change therefore can be done here in genexe.c:
https://github.com/ponylang/ponyc/blob/7c05e1f2ee05f3de0ce2a9c09f671b38665260d3/src/libponyc/codegen/genexe.c#L295
The only caveat is making sure that the memory to be allocated is adjusted at https://github.com/ponylang/ponyc/blob/7c05e1f2ee05f3de0ce2a9c09f671b38665260d3/src/libponyc/codegen/genexe.c#L290

@lutzh this is ready for someone to pick up the work. Would you like to do it? It's straightforward. You did most of the diagnosing, so I'd like to offer you the opportunity to fix it if you are interested, if you aren't that's ok too.

Tbh given I only tried out ponyc for the first time this weekend and have never built it from source, it might be better someone else takes over from here. When I explore pony further, I'm sure there'll be ample opportunity to find some other issue to work on.

I just ran into this github issue since I'm facing a similar issue (can't compile an app that uses the ld linker after upgrading to Big Sur).
Just wanted to point out that I'm on a recently upgraded Big Sur machine and this directory doesn't exist anymore:/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib/

@v-almonacid does this mean that the fix that worked for @lutzh doesn't work for you?

@SeanTAllen I don't know, I'm not using this software. It's just a heads up.

@v-almonacid Apple apparently had the ingenuous to delete the command line tools with every XCode update, but you should be able to make them reappear with xcode-select install.
At least that brought them (and thus /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib/) back for me after the last update. Have you tried that?

@lutzh I did an upgrade to the command line tools just last night (this is a ~month after I upgraded to Big Sur), and even after doing xcode-select install I don't see anything in that path.
I wonder whether this is related to (from Big Sur change logs):

New in macOS Big Sur 11.0.1, the system ships with a built-in dynamic linker cache of all system-provided libraries. As part of this change, copies of dynamic libraries are no longer present on the filesystem. Code that attempts to check for dynamic library presence by looking for a file at a path or enumerating a directory will fail. Instead, check for library presence by attempting to dlopen() the path, which will correctly check for the library in the cache. (62986286)

@lutzh sorry, forget what I say, I think it's just that the upgrade was not complete (needed to accept license agreement, etc).
Apologies for polluting this thread 😬

I'm going to give this a try this weekend, so I'm assigning to myself for now.

I am using ifort on Big Sur and I ran into this issue, I have read through the comments but still, I am not sure how to resolve the issue. Can someone help me, please.

Hi @alikhaledi the problem should be fixed in the next release. In the meantime, you can try compiling your programs like so:
ponyc --linker="ld -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib -lSystem"

Let us know if that works for you!

This is fixed in 0.38.2 which was released within the last 10 minutes.

Yes, I did but still, I get the same error.
I have the following simple FORTRAN code
`[Implicit none
print*, 'Hello'
end
](url)`

Hi @alikhaledi the problem should be fixed in the next release. In the meantime, you can try compiling your programs like so:
ponyc --linker="ld -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib -lSystem"

Let us know if that works for you!

@alikhaledi this isn't a fortran project. you'll need to consult with the project in question. this is an issue for the Pony programming language compiler only.


Repository doesn't have an opensource license

Just noticed that the repository doesn't have a opensource licence. That means that technically anybody who uses this template is susceptible to being sued (even if you never intend to do that). You can easily add this through github

Oh, it does have a license. It just stayed into a subfolder after I moved to a monorepo.
Just moved it back to root.
Thanks