External contributions?

Hello. Thanks for open sourcing this library! I'm wondering if this repository is open to external contributions? If yes, I'd be interested to send a PR and contribute an implementation of FedPA. Thanks.

Thanks for being interested in contributing to fedjax. We are in the process of setting up the framework to accept external contributions. Will let you know as soon as we have the necessary pieces in place.

Thanks for your patience.
We are now ready to accept community contributions. We recommend reading through the contributing guidelines as well as the developer workflow.
Add FedPA to fedjax.algorithms. Please refer to fed_avg.py and fed_avg_test.py for an example internal implementation and unit tests for FedAvg. Additionally, as mentioned in the contributing guidelines, please also add an associated binary that runs FedPA on EMNIST that reproduces the paper results.
Please reach out if you have any additional questions.


Correctly derive the epoch size instead of hardcoding it to 21600

For Byron, we now use kEpochSlots :: BlockCount -> EpochSlots (basically * 10) to derive the epoch size from k, which is extracted from the genesis config. In order to have access to the genesis config,  nodeEpochSizenow takes theNodeConfig` as argument.

bors r+


i hope that this version of centernet can detect the keypoint

🚀 Feature
A clear and concise description of the feature proposal.
Motivation & Examples
Tell us why the feature is useful.
Describe what the feature would look like, if it is implemented.
Best demonstrated using code examples in addition to words.
Note
We only consider adding new features if they are relevant to many users.
If you request implementation of research papers -- we only consider papers that have enough significance and prevalance in the object detection field.
We do not take requests for most projects in the projects/ directory, because they are research code release that is mainly for other researchers to reproduce results.
"Make X faster/accurate" is not a valid feature request. "Implement a concrete feature that can make X faster/accurate" can be a valid feature request.
Instead of adding features inside detectron2,
you can implement many features by extending detectron2.
The projects/ directory contains many of such examples.

Hi, is it possible to use CenterNet2 as keypoint detector? I would like to use it for research purposes
Thanks in advance


I installed metalb，but the loadblancer externalIp is pending

Is this a bug report or a feature request?:
What happened:
“”“
[root@node1 metallb]# kubectl get svc -n istio-system
NAME                     TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                                                                                AGE
grafana                  ClusterIP      <IP_ADDRESS>           3000/TCP                                                                                38h
istio-citadel            ClusterIP      <IP_ADDRESS>            8060/TCP,9093/TCP                                                                                38h
istio-egressgateway      ClusterIP      <IP_ADDRESS>             80/TCP,443/TCP                                                                                38h
istio-galley             ClusterIP      <IP_ADDRESS>           443/TCP,9093/TCP                                                                                38h
istio-ingressgateway     LoadBalancer   <IP_ADDRESS>        80:31380/TCP,443:31390/TCP,31400:31400/TCP,15011:32306/TCP,8060:31920/TCP,853:30946/TCP,15030:31613/TCP,15031:32130/TCP   38h
istio-pilot              ClusterIP      <IP_ADDRESS>           15010/TCP,15011/TCP,8080/TCP,9093/TCP                                                                                38h
istio-policy             ClusterIP      <IP_ADDRESS>           9091/TCP,15004/TCP,9093/TCP                                                                                38h
istio-sidecar-injector   ClusterIP      <IP_ADDRESS>            443/TCP                                                                                38h
istio-telemetry          ClusterIP      <IP_ADDRESS>           9091/TCP,15004/TCP,9093/TCP,42422/TCP                                                                                38h
jaeger-agent             ClusterIP      None                    5775/UDP,6831/UDP,6832/UDP                                                                                38h
jaeger-collector         ClusterIP      <IP_ADDRESS>            14267/TCP,14268/TCP                                                                                38h
jaeger-query             ClusterIP      <IP_ADDRESS>           16686/TCP                                                                                38h
prometheus               ClusterIP      <IP_ADDRESS>           9090/TCP                                                                                38h
servicegraph             ClusterIP      <IP_ADDRESS>           8088/TCP                                                                                38h
tracing                  ClusterIP      <IP_ADDRESS>           80/TCP                                                                                38h
zipkin                   ClusterIP      <IP_ADDRESS>           9411/TCP
”“”
istio-ingressgateway     LoadBalancer   <IP_ADDRESS>
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
install loadblancer first then install metalb
Anything else we need to know?:
Environment:

MetalLB version:
Kubernetes version:
BGP router type/version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):

my network is calico

istio-ingressgateway     LoadBalancer   <IP_ADDRESS>        80:31380/TCP,443:31390/TCP,31400:31400/TCP,15011:32306/TCP,8060:31920/TCP,853:30946/TCP,15030:31613/TCP,15031:32130/TCP   3d18h

istio-ingressgateway     LoadBalancer   <IP_ADDRESS>   pending   80:31380/TCP,443:31390/TCP,31400:31400/TCP,15011:32306/TCP,8060:31920/TCP,853:30946/TCP,15030:31613/TCP,15031:32130/TCP   3d18h

@13567436138 Can you please format your issue properly and supply the environment  information required?
Please use codeblocks for CLI-output so that the formatting is retained.
```
cli-output goes here
```

‘’‘
[root@node1 metallb]# kubectl get svc -n istio-system
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
grafana ClusterIP <IP_ADDRESS> 3000/TCP 38h
istio-citadel ClusterIP <IP_ADDRESS> 8060/TCP,9093/TCP 38h
istio-egressgateway ClusterIP <IP_ADDRESS> 80/TCP,443/TCP 38h
istio-galley ClusterIP <IP_ADDRESS> 443/TCP,9093/TCP 38h
istio-ingressgateway LoadBalancer <IP_ADDRESS> 80:31380/TCP,443:31390/TCP,31400:31400/TCP,15011:32306/TCP,8060:31920/TCP,853:30946/TCP,15030:31613/TCP,15031:32130/TCP 38h
istio-pilot ClusterIP <IP_ADDRESS> 15010/TCP,15011/TCP,8080/TCP,9093/TCP 38h
istio-policy ClusterIP <IP_ADDRESS> 9091/TCP,15004/TCP,9093/TCP 38h
istio-sidecar-injector ClusterIP <IP_ADDRESS> 443/TCP 38h
istio-telemetry ClusterIP <IP_ADDRESS> 9091/TCP,15004/TCP,9093/TCP,42422/TCP 38h
jaeger-agent ClusterIP None 5775/UDP,6831/UDP,6832/UDP 38h
jaeger-collector ClusterIP <IP_ADDRESS> 14267/TCP,14268/TCP 38h
jaeger-query ClusterIP <IP_ADDRESS> 16686/TCP 38h
prometheus ClusterIP <IP_ADDRESS> 9090/TCP 38h
servicegraph ClusterIP <IP_ADDRESS> 8088/TCP 38h
tracing ClusterIP <IP_ADDRESS> 80/TCP 38h
zipkin ClusterIP <IP_ADDRESS> 9411/TCP
’’‘

？

···
[root@node1 metallb]# kubectl get svc -n istio-system
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
grafana ClusterIP <IP_ADDRESS> 3000/TCP 38h
istio-citadel ClusterIP <IP_ADDRESS> 8060/TCP,9093/TCP 38h
istio-egressgateway ClusterIP <IP_ADDRESS> 80/TCP,443/TCP 38h
istio-galley ClusterIP <IP_ADDRESS> 443/TCP,9093/TCP 38h
istio-ingressgateway LoadBalancer <IP_ADDRESS> 80:31380/TCP,443:31390/TCP,31400:31400/TCP,15011:32306/TCP,8060:31920/TCP,853:30946/TCP,15030:31613/TCP,15031:32130/TCP 38h
istio-pilot ClusterIP <IP_ADDRESS> 15010/TCP,15011/TCP,8080/TCP,9093/TCP 38h
istio-policy ClusterIP <IP_ADDRESS> 9091/TCP,15004/TCP,9093/TCP 38h
istio-sidecar-injector ClusterIP <IP_ADDRESS> 443/TCP 38h
istio-telemetry ClusterIP <IP_ADDRESS> 9091/TCP,15004/TCP,9093/TCP,42422/TCP 38h
jaeger-agent ClusterIP None 5775/UDP,6831/UDP,6832/UDP 38h
jaeger-collector ClusterIP <IP_ADDRESS> 14267/TCP,14268/TCP 38h
jaeger-query ClusterIP <IP_ADDRESS> 16686/TCP 38h
prometheus ClusterIP <IP_ADDRESS> 9090/TCP 38h
servicegraph ClusterIP <IP_ADDRESS> 8088/TCP 38h
tracing ClusterIP <IP_ADDRESS> 80/TCP 38h
zipkin ClusterIP <IP_ADDRESS> 9411/TCP
···

Please use the edit functionality for your comments.
If you are not able to do this, it's very hard for anyone to help you.
Also, you need to describe your issue in more detail and what you have done to troubleshoot your issue so far.

Sorry, but I no longer have the time to debug MetalLB deployments for people. I want to keep this tracker specifically for bugs and features, so I'm going to close this. At some point I may have time to write general troubleshooting documentation, but as a first step towards that I need to clear up the issue tracker.
You could try asking for help on the #metallb channel on the Kubernetes slack, where there are people other than me who can assist.


Add process.env requirements to the README file

By following the README.md instructions i got to npm run compile but that command fails because it requires some environment keys to exist.
By looking at buidler.config.js i noticed there are 3 expected variables to be present on process.env

INFURA_API_KEY
PRIVATE_KEY
ETHERSCAN_API_KEY

I believe that information must be added to the README file

That's the error i get from npm run compile
Error BDLR8: There's one or more errors in your config file:

  * Invalid value {"url":"https://kovan.infura.io/v3/undefined","accounts":[null],"timeout":20000} for BuidlerConfig.networks.kovan - Expected a value of type HttpNetworkConfig.
  * Invalid value {"url":"https://mainnet.infura.io/v3/undefined","accounts":[null],"timeout":20000} for BuidlerConfig.networks.mainnet - Expected a value of type HttpNetworkConfig.

To learn more about Buidler's configuration, please go to https://buidler.dev/config/

I just noticed the project includes dotenv, so basically i believe the README should state that a .env file must be created with the required variables


In iOS15, when webview_flutter exits the webview interface, the following error will be reported!

[assertion] Error acquiring assertion: <Error Domain=RBSServiceErrorDomain Code=1 "target is not running or doesn't have entitlement com.apple.runningboard.assertions.webkit" UserInfo={NSLocalizedFailureReason=target is not running or doesn't have entitlement com.apple.runningboard.assertions.webkit}>
[ProcessSuspension] 0x1112fa700 - ProcessAssertion: Failed to acquire RBS assertion 'ConnectionTerminationWatchdog' for process with PID=25324, error: Error Domain=RBSServiceErrorDomain Code=1 "target is not running or doesn't have entitlement com.apple.runningboard.assertions.webkit" UserInfo={NSLocalizedFailureReason=target is not running or doesn't have entitlement com.apple.runningboard.assertions.webkit}

场景：
点击按钮进入webview界面，使用的库是webview_flutter: ^3.0.1，
webview界面显示正常
但是退出这个界面的时候，控制台会报以上错误！

Scenes:
Click the button to enter the webview interface, the library used is webview_flutter: ^3.0.1,
The webview interface is displayed normally
But when exiting this interface, the console will report the above error!

Hi @WangYiOS, please provide a complete minimal reproducible code sample as well as the output of flutter doctor -v.
Thank you

嗨@WangYiOS，请提供完整的最小可重现代码示例以及flutter doctor -v.
谢谢

Hello, big brother
I closed that question.
Because this error does not affect the interface display, debug and release are used normally.
Thank you


Updated: datagrip 2019.1.4

Newer version of datagrip (2019.3.4) is now available in master. c5f435834a6f70099d184781769e0fdbe56cef3f


mkpr package.json sed s/"npm-pkgbuild":.*/"npm-pkgbuild":"^6.5.0",/

Coverage increased (+0.01%) to 40.214% when pulling 65870b2cb112369230c8ccff025a0582a3727d2d on mkpr/0001 into 10d192752f75f4c667393ef822a1301d686c5a43 on master.

:tada: This PR is included in version 8.1.55 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


While using sqlalchemy backend 301 redirect remained as QUEUED

Only redirected url is marked marked as CRAWLED but the redirected remains as QUEUED.

Yes, that's confusing. At the same time it depends on canonical solver behavior. So I think, the right way is to mark as CRAWLED url considered as canonical, and leave other urls canonical solver to decide.


chore(ci): switch to dedicated Solang runners

There are other workflows which still use ubuntu-latest: the vscode job and all the jobs in the release.yml workflow

I had left the ones we didn't get last time alone; however, the latest version moves all ubuntu-latest to solang-ubuntu-latest


Faker::RickAndMorty not available in v1.7.3 from RubyGems

If you install v1.7.3 from RubyGems (or put gem 'faker', '1.7.3' in your Gemfile), there is no Faker::RickAndMorty class—there's no file for it at lib/faker/rick_and_morty.rb, and there's no info for it in lib/locales/en.yml. Attempting to use it predictably results in a NameError: uninitialized constant Faker::RickAndMorty.
The RubyGems 1.7.3 version does have at least some of the changes involved in the bump from 1.7.2 => 1.7.3, as far as I checked (e.g. "fap" is gone from the hipster word collection), so maybe it's just the Rick and Morty change that didn't make it in. Probably want to check, though!

Faker::RickAndMorty is brand new and still in the master branch. It's not in release 1.7.3... until 1.8 comes out you can use it from github if you need it right now
gem 'faker', :git => 'git://github.com/stympy/faker.git', :branch => 'master'

D'oh! Cool, thanks for the tip!

@stympy Stale issue, please close.


Alternative option to RDS Library for IAM to avoid Lambda Size Limits.

Describe the feature
I would appreciate a smaller alternative to the RDS library to enable IAM Authentication, as the RDS library is extensive and provides many features that are not required for IAM RDS Auth to function.
Use Case
The RDS dependency is an extensive library (22 MB uncompressed, 4 MB compressed), which causes issues when running on Lambda, which only allows for ~270 MB uncompressed across all layers.
Having an alternative option that only provides the IAM Auth token flow should significantly reduce the required footprint when running on Lambda with JDBC.
Proposed Solution
I think the solution would be:

An alternative library dependency option that only provides the necessary APIs to enable API Authentication or
Integrating the IAM Token Fetch/Refresh workflow into the existing JDBC-wrapper

The dependencies on the rds library seem pretty light and can be found here:
https://github.com/search?q=repo%3Aawslabs%2Faws-advanced-jdbc-wrapper+software.amazon.awssdk.services.rds&type=code
Other Information
Some context:
Considering the speedup that comes with Snapstart, we've been looking at using Native Java over Graalvm to increase our DevEx in the lower dev environments. This has meant that the size of the lambdas have significantly increased because we lose the benefit of GraalVM Tree shaking.
We're hitting the lambda limits using little more than Micronaut + Aurora Wrapper + Hibernate + Open Telemetry Collector + RDS. The RDS library is the second largest jar in our manifest behind Hibernate.
While Snapstart isn't "new" new, I suspect we'll see more issues like this as people experiment with it over Graal while using fuller frameworks like Micronaut/Spring/etc.
Acknowledgements

[ ] I may be able to implement this feature request
[X] This feature might incur a breaking change

The AWS Advanced JDBC Driver version used
2.2.5
JDK version used
17.0.8
Operating System and version
N/A

Hi @rorychatterton
We've merged PR and the fix is now available in the latest snapshot build. We hope that the latest improvements help to solve your issue.

Thankyou @sergiyvamz!
I'll test this in the next couple of days and let you know how I go.

Hi @rorychatterton
I know this ticket is closed, but I wanted to let you know that the fix is now available on the latest version of the driver.
Thank you!


The simulation scene is terminated before the set condition

High Level Description
[I want the simulation scene will terminate after the termination conditions are met]
Desired SMARTS version
[e.g. 0.4.12]
Operating System
[ Ubuntu 18.04]
Problems
[1. I set the training episode_num =1000, but the simulation scene is terminated at episode=(8~17)  and the sum steps is fixed (7763) ]
[2. If i change and build the loop scene, and it is terminated in different sum steps, but if without any changes about the scenario the simulation scene it terminated in the same sum steps ]

The Error mentioned:
ERROR:SMARTS:Simulation crashed with exception. Attempting to cleanly shutdown.
ERROR:SMARTS:connection closed by SUMO
Traceback (most recent call last):
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 170, in step
return self._step(agent_actions)
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 219, in _step
provider_state = self._step_providers(all_agent_actions, dt)
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 695, in _step_providers
provider, actions, dt, self._elapsed_sim_time
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 734, in _step_provider
provider_state = provider.step(provider_actions, dt, elapsed_sim_time)
File "/home/jiayiguan/SMARTS/smarts/core/sumo_traffic_simulation.py", line 310, in step
self._traci_conn.simulationStep(self._cumulative_sim_seconds)
File "/usr/share/sumo/tools/traci/connection.py", line 302, in simulationStep
result = self._sendCmd(tc.CMD_SIMSTEP, None, None, "D", step)
File "/usr/share/sumo/tools/traci/connection.py", line 180, in _sendCmd
return self._sendExact()
File "/usr/share/sumo/tools/traci/connection.py", line 90, in _sendExact
raise FatalTraCIError("connection closed by SUMO")
traci.exceptions.FatalTraCIError: connection closed by SUMO
╰────────────────────┴────────────────────┴────────────────────┴────────────────────┴────────────────────┴────────────────────┴────────────────────┴────────────────────╯
Traceback (most recent call last):
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 170, in step
return self._step(agent_actions)
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 219, in _step
provider_state = self._step_providers(all_agent_actions, dt)
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 695, in _step_providers
provider, actions, dt, self._elapsed_sim_time
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 734, in _step_provider
provider_state = provider.step(provider_actions, dt, elapsed_sim_time)
File "/home/jiayiguan/SMARTS/smarts/core/sumo_traffic_simulation.py", line 310, in step
self._traci_conn.simulationStep(self._cumulative_sim_seconds)
File "/usr/share/sumo/tools/traci/connection.py", line 302, in simulationStep
result = self._sendCmd(tc.CMD_SIMSTEP, None, None, "D", step)
File "/usr/share/sumo/tools/traci/connection.py", line 180, in _sendCmd
return self._sendExact()
File "/usr/share/sumo/tools/traci/connection.py", line 90, in _sendExact
raise FatalTraCIError("connection closed by SUMO")
traci.exceptions.FatalTraCIError: connection closed by SUMO
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "rlagentmodel/sacagent_dis/sacagent_dis20210310.py", line 669, in
epochs=args.epochs,
File "rlagentmodel/sacagent_dis/sacagent_dis20210310.py", line 598, in main
observations, rewards, dones, infos = env.step({AGENT_ID:agent_action})
File "/home/jiayiguan/SMARTS/smarts/env/hiway_env.py", line 160, in step
observations, rewards, agent_dones, extras = self._smarts.step(agent_actions)
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 181, in step
self.destroy()
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 460, in destroy
self._traffic_sim.destroy()
File "/home/jiayiguan/SMARTS/smarts/core/sumo_traffic_simulation.py", line 110, in destroy
self._close_traci_and_pipes()
File "/home/jiayiguan/SMARTS/smarts/core/sumo_traffic_simulation.py", line 270, in _close_traci_and_pipes
self._traci_conn.close()
File "/usr/share/sumo/tools/traci/connection.py", line 369, in close
if self._socket is not None:
AttributeError: 'Connection' object has no attribute '_socket'
Assertion failed: !is_empty() at line 2340 of panda/src/pgraph/nodePath.cxx
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/home/jiayiguan/anaconda3/envs/smarts/lib/python3.7/site-packages/direct/showbase/ShowBase.py", line 82, in exitfunc
builtins.base.destroy()
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 451, in destroy
self.teardown()
File "/home/jiayiguan/SMARTS/smarts/core/smarts.py", line 434, in teardown
self._root_np.clearLight()
AssertionError: !is_empty() at line 2340 of panda/src/pgraph/nodePath.cxx
/home/jiayiguan/anaconda3/envs/smarts/lib/python3.7/tempfile.py:798: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpuv7_ey91wandb'>
_warnings.warn(warn_message, ResourceWarning)
/home/jiayiguan/anaconda3/envs/smarts/lib/python3.7/tempfile.py:798: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmp4vccvsv3wandb-media'>
_warnings.warn(warn_message, ResourceWarning)
/home/jiayiguan/anaconda3/envs/smarts/lib/python3.7/tempfile.py:798: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/tmpdnk9cmvwwandb-media'>
_warnings.warn(warn_message, ResourceWarning)

@guanjiayi We are really sorry about that. This exception is a difficult bug to reproduce that is related to SUMO and we currently have a branch going to pass that crash along to the SUMO team https://github.com/huawei-noah/SMARTS/pull/619.
I would suggest for now to remove the bubble in the loop scenario or use a different map since the crash occurs with some frequency on the loop map.

Hi @guanjiayi,
It appears that you encouter the traci.exceptions.FatalTraCIError: connection closed by SUMO error.
Given the occurrence of traci.exceptions.FatalTraCIError: connection closed by SUMO error, could you try running all your commands and experiments inside a docker container?
$ docker run --rm -it --network=host huaweinoah/smarts:v0.4.13

Do not map the source code using -v $PWD:/src when running the docker container.

@Adaickalavan  Thank you for your reply. I check the problem in difference way.
A difference way:

I install our smarts without install other package, this problem did't appear when test the single_agent.py.
Then i install the openai  reinforcement  learning package and the wandb package, this problem have been appeared.
Now I change the install sequence, our smarts package is installed after the openai reinforcement learning package and without install the wandb package. ( I still check the test)

Use docker

The sumo-gui can't be open in the docker.

Open AI reinforcement learning package  https://spinningup.openai.com/en/latest/user/installation.html

@guanjiayi OK, I will take a look today.

@Gamenot Thank you, The "connection closed by SUMO" didn't appear, when the running the example in the docker after install the spinningup package.

@Gamenot  Thank you for your help!

The progress on this is that we passed the bug along to SUMO via a reproducible crash we can generate in #619.


NPE in UserPromptPreferences

See https://github.com/dart-lang/pub/pull/3862
I think this is because we cannot get the location.
String? _getStandardStateLocation() {
  final Map<String, String> env = io.Platform.environment;
  if (env.containsKey('ANALYZER_STATE_LOCATION_OVERRIDE')) {
    return env['ANALYZER_STATE_LOCATION_OVERRIDE'];
  }

  final home = io.Platform.isWindows ? env['LOCALAPPDATA'] : env['HOME'];
  return home != null && io.FileSystemEntity.isDirectorySync(home)
      ? join(home, _serverDir)
      : null;
}

Maybe LOCALAPPDATA is not defined, or the target is missing or not a directory.
@DanTup

If we don't know the home directory I think is better to not store a location than to use one that is unsafe. This API is nullable anyway so it seems like callers should just be handling null more gracefully.
In particular we could change
https://github.com/dart-lang/sdk/blob/cd7b4f8e4bf59f27475e4440f8de7995f1718d3c/pkg/analysis_server/lib/src/services/user_prompts/user_prompts.dart#L27
to avoid using !

https://dart-review.googlesource.com/c/sdk/+/293920 fixes the immediate issue though @bwilkerson has some comments that should be addressed longer term to minimize spam in the instrumentation log.

@jcollins-g thanks for looking at this!
I think I made a bad assumption that the server wouldn't run at all without access to this state folder, but I now see it creates an in-memory store for the driver state (MemoryCachingByteStore).
I suspect this issue might be restricted to bots (LOCALAPPDATA usually exists set by default), but just in case I think we'd be better not showing prompts at all if we're unable to persist the preferences (having a "Don't show again" button that doesn't work wouldn't be great). I'll make some changes to do that (it'll also avoid logging multiple times as @bwilkerson noted), although I suspect that's not critical for the beta given the fix above.

Some tweaks at https://dart-review.googlesource.com/c/sdk/+/294000 that allow different preferences when there's no state location to when there's just no file. This will prevent a broken "do not show" button if this condition did occur for real users. Only a single entry will be written to the log in this case.

(Closing, since this was fixed by https://github.com/dart-lang/sdk/commit/b6cf3f9c22cf6c83ae7f648b3441d9b8319a5de8)


Several Bugs Reporting

During the event, I found some bugs. Though I do wish to fix them alone, I'm scared whether I can clear all event maps for it lasts for only less than one week. So here comes the report.

Battle info only shows results up to the stage of pre-boss support expedition. It only occurs when the pre-boss expedition working, while the results of the boss node expedtion remain normal.

Map route won't work correctly after the fight against abyssal combined fleets. Deleting the folder ..\BattleInfoPluginData & restarting could temporarily ignore it once. Here's one exception that the surface task force(Suijou Dageki Butai) composition avoid the problem somehow.

The damage of friend fleets do not be implemented.

PS: Is SwfFormat.dll no longer necessary as the cache transforms into HTML mode?

I'm just now working through E3 myself so I've only experienced the last 2 of the 3. The second one is usually caused by an unrecongnized part of the API result causing it to not realize combat has ended and therefor not proceed properly with resetting after battle (seems like its something new that loves to happen each event and I just now started looking into it for this one). Rebooting the program does force this to be fixed but as you said, only works for one run until it hangs again.
I knew from last event friend fleets didn't work but I didn't get the data to implement them yet. Right now I'm doing a run so that I can get that data pulled and try to implement it.
As for the first one, I've not used support expeds yet so I have no idea whats causing it or how to fix it yet but I'll try to investigate it this event as well though it might have to wait till the next one, assuming the problem persists.

As of right now Bug 1 hasn't been investigated but is likely being caused by the major changes in the api that occured a couple events ago which resulted in incorrect indices for enemy ships in fleets. If time and resources permit I'll try to get around to investigating runs with pre-boss support expeds. Progress has been made on the other 2 issues though.
Bug 2 has been fixed by temporarily disabling the checking of enemy fleet formations for the next until that system has been fixed (its had constant issues since major changes that occured to the combat API and I haven't looked into it at all since then). Fixed in commit d5539da.
Bug 3 is still being fully implemented but as of right now the window has been modified to show friend fleets when they appear in night battles in 50b9ce6. Basic damage support for them against enemy fleets has also been added in 8236d60 however damage to the friendly fleet is currently being reported on the user fleet instead. I'll try to have that part finished tomorrow.

As of now, friend support fleets should be fully implemented but final testing for those and checking the first bug reported will have to wait until next main event

I seldom use support expedition either. However, as far as I know, map 5 is one area applied with support expedition, which makes it possible to check some details of the first bug.

Here are some details for BUG 1. Bug 1 could be observed in regular maps as well.
And the representation between two kinds of pre-boss expedition - normal pre-boss expedition & night battle pre-boss expedition is different.
For the normal battles, the problem has been described above.
With night battle pre-boss expedition(e.g. map 5-3), the damge of expedition would not be calculated into results, which looks like being caused by the api changes.


set_topic not working

hello,
I tried to use robot.set_topic(response, 'some topic') in my lita handler.
it seems that this method doesn't pass the room's id to the slack api but a string representation of the room object, so it misses room.id somewhere in the chain.
then I tried to use set_topic directly via robot.chat_service.api.set_topic(response.room.id, 'some topic') but still no luck. I always get channel_not_found error from slack. I checked the call made and it looks good to me (https://api.slack.com/methods/channels.setTopic).
could it be that lita-slack somehow computes the wrong room id? there could be also something wrong with the api call to slack?

hi @jimmycuadra,
any chance this can be fixed? I don't know how to fix it myself

I found out that robot.chat_service.api.set_topic(response.room.id, 'some topic') seems to work with public channels but not with private channels.
robot.set_topic(response, 'some topic') doesn't work with either public nor private channels

Very sorry for leaving this issue sitting so long without a reply!
The first argument to set_topic should be a Lita::Source object, not a Lita::Response, so that is one problem that would keep the API from working for you. I am not sure about the distinction between public and private channels off hand. The bot will definitely need to be a member of any private channels it's trying to send a message to, but there may be an issue with how it's formatting IDs for private channels, too.

@jimmycuadra,
it seems like this works inside the handler at least for public channels:
target = Source.new(room: response.room)
robot.set_topic(target, 'test')

thanks!


Redirection during prerendering doesn't work well

We have some logic that detects a UriHelper.NavigateTo call during prerendering, and is meant to turn it into a 302 redirection. However, trying to use this surfaced several problems:

It doesn't work if you try to redirect to the homepage (i.e., the base-relative URL is the empty string). I guess it's because the server-side ASP.NET Core APIs don't work in terms of base-relative URLs. Our code already knows the _baseUriString at that point in the flow, so we could fix this by calling ToAbsoluteUri and passing the result to the NavigationException.
For some reason, it logs the NavigationException to the console, even though our own code handles this and isn't meant to treat it as an error
For some reason, there's an almost 1 second delay before the redirection occurs. I determined this by disabling JS in my browser and trying to navigate to a component whose OnInit looks like this:

    protected override void OnInit()
    {
        UriHelper.NavigateTo("greeter");
    }

The browser's network tab shows the response time as ~ 1 second, even though it would be near instant if I was not redirecting to another place.

Is this issue actually resolved?  I'm having very similar issue.
I have uriHelper.NavigateTo("/Account/Login"); within "OnInitialized."  It actually works fine for me, but creates build error for other people on my team.  Workaround was to move it to "OnAfterRender" instead.

Hi @katiep23.
It looks like you are posting on a closed issue!
We're very likely to lose track of your bug/feedback/question unless you:

Open a new issue
Explain very clearly what you need help with
If you think you have found a bug, include detailed repro steps so that we can investigate the problem


Add support for proxy settings

The extension seems to ignore the system proxy so I can't use it on our on-prem vsts agents. I have tried using the arguments field on the publish extension task but this seems to be ignored so is not getting passed to tfx.
Could you either please fix the arguments field or add a proxy field that gets passed to --proxy?

I've double checked the arguments and they were not working when publishing from VSIX. That's fixed now. I'll see if I can pass in the proxy automatically.

Hmz... I'd like to add proxy support. But don't have a situation where proxy is required. The agent can be configured with a proxy and I can fetch those details, but it doesn't seem like I can pass in a URL to hav it test whether the proxy is required, so I suppose that you'd want the proxy to have UI as well.
Is setting the Environment variable good enough?

@willsmythe @wpschaub Would adding something like this make sense?
export function setProxy() {
    const proxy = tl.getHttpProxyConfiguration();

    if (!process.env["HTTP_PROXY"] && !process.env["HTTPS_PROXY"]) {
        let proxyUrl = new uri(proxy.proxyUrl);
        if (proxy.proxyUsername) {
            proxyUrl.username(proxy.proxyUsername);
            proxyUrl.password(proxy.proxyPassword);
        }
        process.env["HTTP_PROXY"] = proxyUrl;
        process.env["HTTPS_PROXY"] = proxyUrl;

        if (!process.env["NO_PROXY"]) {
            process.env["NO_PROXY"] = proxy.proxyBypassHosts;
        }
    }
}

@IPO-srh-sloan I'd love to be able to send you an experimental test version...

https://github.com/Microsoft/vsts-extension-build-release-tasks/tree/features/auto-proxy

@jessehouwing Sorry for the delay, I've been off. Happy to test if you can send me a test version?

VSTS or TFS? Attached a custom TFS build. If you're on VSTS I need you account name so I can share.
vsix.zip

Done
On 13 Mar 2018 10:15, "IPO-srh-sloan"<EMAIL_ADDRESS>wrote:

Could you share it with ukipo-dev.visualstudio.com please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vsts-extension-build-release-tasks/issues/58#issuecomment-372597205,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-uS8uMhY2HgUOtnM-YlPmj8Pkao74pks5td446gaJpZM4Rsh6F
.

@IPO-srh-sloan any feedback?

Sorry, only just had a chance to look. It does now seem to be reading in the system proxy with no extra settings - is that what you were expecting? Thanks.

That's what I'd expect. Does it work as well, that's the most important thing ;).
BTW you can also set these environment variables on the agent itself to make them apply for any Node based task.

Yes, it does work when reading in the system proxy :)

I did some checking and it's preferred to use the default Node/VSTS environment variables over the task trying to magically compute them.


'undefined' being written to tsd.d.ts

I believe this may be happening when a run gulp and I have forgotten to use resolve      when adding a definition.   For example.   I add gulp-util using:
tsd install gulp-util -s
I then run a task in gulp and get the error message
ProjectPath/typings/gulp-util/gulp-util.d.ts(7,1): 6053 File 'ProjectPath/typings/vinyl/vinyl.d.ts' not found.
After that the word undefined appears in tsd.d.ts which results in the error
ProjectPath/typings/tsd.d.ts(6,1): 1036 Statements are not allowed in ambient contexts.

For anyone else who runs into this issue. I had this happen briefly when I was running tsd while I had left a gulp + browserify + watchify + tsify build running in another window. Once I stopped my build and re-ran tsd, the file was fine.


Adding Azure-AsyncOperation header

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
The API is not public yet. There are no real customers calling the CalculateExchange & Exchange API's today.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
12/18/2020
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

hi @fengzhou-msft - can this be merged?


Implement Gradle instance plugin

Features:

tasks for creating self-extractable distributions: osgiDistribution
tasks for controlling instances created under home directory: osgiUp, osgiHalt, osgiCreate, osgiDestroy, osgiReload

Nice to have will be fail safe combination of halt + destroy + create + up to start over with fresh env

Distribution task should include web manager and other default bundles like Felix DS / SCR, OSGi cmpn and Felix File install used by web-manager


config parser fails when name of tun device is tunnel

example here:
https://github.com/whohoho/openvpn/commit/c37d7a1d80035413fdc3ed09fa78a7f1a7747028

Thanks for the report, this is something we should fix (and add a regression test to the repository).


PancakePainter crashes on Mac running 10.8.5

I've downloaded it 3 times, the file size is 132,384,216 bytes, created oct. 22, 2015, version: 0.34.0
Double-click to run and I get: PancakePainter quit unexpectedly. Click Reopen to open the application again. Click Report to see more detailed information and send a report to Apple.
I try that and it occurs again. click report and I get:
Process: Electron [4439]
Path: /Users/USER/Downloads/PancakePainter.app/Contents/MacOS/Electron
Identifier: pancakepainter-main
Version: 0.34.0 (1.0.0-Beta1)
Code Type: X86-64 (Native)
Parent Process: launchd [154]
User ID: 501
Date/Time: 2016-01-21 23:32:26.478 -0800
OS Version: Mac OS X 10.8.5 (12F45)
Report Version: 10
Interval Since Last Report: 75424 sec
Crashes Since Last Report: 35
Per-App Crashes Since Last Report: 3
Anonymous UUID: 0D357569-74D2-42C8-65E6-17F2402844B0
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000
VM Regions Near 0:

I have uploaded (If you don’t see anything it maybe still be uploading to dropbox) the version I have onto dropbox. Would you mind trying that? I will send the crash details to the developer. Thank you for the details.
https://www.dropbox.com/sh/51l7bpuqv534huw/AAA1NBwRMnXMs9lCl7jnBqhla?dl=0
Kind Regards,
Slim Geransar
(646)706-3382
slim<EMAIL_ADDRESS>[cid:CE92FAD3-CF75-4CDD-A3D3-9B390309CBAB]
On Jan 22, 2016, at 2:42 AM, fuzzychocolate <notifications<EMAIL_ADDRESS>wrote:
I've downloaded it 3 times, the file size is 132,384,216 bytes, created oct 22, 2015, version: 0340
Double-click to run and I get: PancakePainter quit unexpectedly Click Reopen to open the application again Click Report to see more detailed information and send a report to Apple
I try that and it occurs again click report and I get:
Process: Electron [4439]
Path: /Users/USER/Downloads/PancakePainterapp/Contents/MacOS/Electron
Identifier: pancakepainter-main
Version: 0340 (100-Beta1)
Code Type: X86-64 (Native)
Parent Process: launchd [154]
User ID: 501
Date/Time: 2016-01-21 23:32:26478 -0800
OS Version: Mac OS X 1085 (12F45)
Report Version: 10
Interval Since Last Report: 75424 sec
Crashes Since Last Report: 35
Per-App Crashes Since Last Report: 3
Anonymous UUID: 0D357569-74D2-42C8-65E6-17F2402844B0
Crashed Thread: 0 Dispatch queue: comapplemain-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000
VM Regions Near 0:
—
Reply to this email directly or view it on GitHubhttps://github.com/PancakeBot/PancakePainter/issues/47.

Will give it a run and see what comes up with it.

Hi, I downloaded the file from dropbox, unzipped it, there's a contents
directory, with source code, etc. I don't see a compiled program that I can
run....
On Fri, Jan 22, 2016 at 9:51 AM, Miguel Valenzuela<EMAIL_ADDRESS>
wrote:

Will give it a run and see what comes up with it.
—
Reply to this email directly or view it on GitHub
https://github.com/PancakeBot/PancakePainter/issues/47#issuecomment-173991455
.

Hmm I just uploaded the program. As in a single program file.

I download it and it's saved as a .zip file, I then unzip it and it creates
a 'content' directory with many files.
If I rename it to .app then try to run it, it says:  You can't open the
application "PancakePainter-2.app" because the Classic environment is no
longer supported.
On Sat, Jan 23, 2016 at 5:43 AM, Slimmy82<EMAIL_ADDRESS>wrote:

Hmm I just uploaded the program. As in a single program file.
—
Reply to this email directly or view it on GitHub
https://github.com/PancakeBot/PancakePainter/issues/47#issuecomment-174187549
.

Hey, is anyone looking at this??  I received my Pancakebot today and I can't use it!!!  how frustrating is that!  I can download other people's designs as .pbd, yet you still need painter to convert them to gcode.  Please fix PancakePainter so I can use my Pancakebot........
Can someone send me a homer simpson in gcode that I can print??

I am.  Let me get some designs to you.  Email me at<EMAIL_ADDRESS>Miguel

The designs that show you the result of an actual pancake have all the .gcode files with them.

It appears the framework used to build the app doesn't really support 10.8.x anymore, so it looks like PancakePainter's minimum requirement is effectively 10.9.
https://github.com/atom/electron/issues/3530

Mac 10.7 was the previous breaking release, I guess 10.8 was only a matter of time. Unless the community supports it, we can't have a 10.8 release without knowing what version to build from.. and risk losing APIs and stability along the way. Mountain Lion was released 3 years ago, is it in our interests to keep support for this OS @PancakeBot @Slimmy82? If so there will be quite a bit of work to do to make it happen.

Meanwhile, I've suggested to the Electron folks that if they're not going to support 10.8, they should at least make it official.
https://github.com/atom/electron/issues/4273

OK, thanks, I'm able to boot up windows on my Mac and run the Windows
version of pancake painter on my Mac, so now I can print.
On Jan 29, 2016 9:29 AM, "James T"<EMAIL_ADDRESS>wrote:

Mac 10.7 was the previous breaking release, I guess 10.8 was only a matter
of time. Unless the community supports it, we can't have a 10.8 release
without knowing what version to build from.. and risk losing APIs and
stability along the way. Mountain Lion was released 3 years ago, is it in
our interests to keep support for this OS @PancakeBot
https://github.com/PancakeBot @Slimmy82 https://github.com/Slimmy82?
If so there will be quite a bit of work to do to make it happen.
—
Reply to this email directly or view it on GitHub
https://github.com/PancakeBot/PancakePainter/issues/47#issuecomment-176872946
.

Kind of looks like they've documented this now, and there's no push to improve this direction so going to close the issue for now.


Create credential_phishing_hyperlinked_image_with_suspicious_file_sha…

Plan to run in test-rules for a bit

/update-test-rules

/update-test-rules

only 1 hit so far.


DFU mode: improve programming robustness.

dfu.get_status() might return usb.core.USBError with errno == EPIPE,
when called in quick succession. This is the case when called from
dfu.block_on_state(). The next call usually works.
This change tries to catch this specific error and just re-tries in case
it happens.
Without this change, the error (and programming abort) might get
undetected, as click catches IOerror/EPIPE silently. This has
significant potential to brick a device.
This change addresses issue #97.

Thanks for thinking about this!
I did not understand the click comment, what exactly happens in case of EPIPE without your patch applied? I'm thinking here it might be good to have a maximum number of retries, but perhaps you're saying that click swallows EPIPE completely, so this patch is in any case strictly better?

I did not understand the click comment, what exactly happens in case of EPIPE without your patch applied?

As you can see here: https://github.com/pallets/click/blob/3984f9efce5a0d15f058e1abe1ea808c6abd243a/src/click/core.py#L944, click catches all OSError having errno == EPIPE. Effectively, it maps it to an exit code 1, but no exception output will be generated. (This makes sense for typical CLI commands, as an actual EPIPE will happen often.)
(In the version I have been using, it catches IOError, which now is an alias of OSError.)
When libusb1 returns a PIPE error, it raises USBError, which is derived from IOError (a.k.a OSError) also having errno == EPIPE.
So, when the error happens, without the patch, the programming stops immediately. However, there is no obvious feedback like a stacktrace, because this specific USBError is caught by click when handling the frequent CLI command event of writing to a closed pipe. Of course there will be no success message of the whole program/verify cycle. Unfortunately I did not know what to expect during my very first DFU programming try :(
Also, the error happens so often (4-5 times during one full flash programming cycle), that it was impossible for me to do a full flash program in DFU mode. I only managed to program the bootloader without the patch, after some retries.

I'm thinking here it might be good to have a maximum number of retries, but perhaps you're saying that click swallows EPIPE completely, so this patch is in any case strictly better?

You're right of course, some limit to avoid an endless loop would be good.
How would this be handled if s.state != state is never reached in dfu.block_on_state()? Is there a timeout or something?

I have changed the approach to try the ctrl transfer inside get_status up to three times in case of USBError/EPIPE.

Thanks for the explanations!
I'm happy to merge this as-is if you're happy :)
Regarding your original problem, I've never seen or heard of such frequent errors (we only had this kind of error in our deprecated web interface, which would interrupt flashing if users tabbed out). I wonder if it could be a bad connector, or what else could cause this.

Thanks for the explanations! So this is about the something | head type of situation probably.

Exactly.

I'm happy to merge this as-is if you're happy :)

I've just verified on Windows 10 that the change doesn't seem to do any harm, either. Even though the programming also worked reliably without the patch! Same hardware where it is unstable on Linux (Ubuntu 20.04, Kernel 5.4.something).

Regarding your original problem, I've never seen or heard of such frequent errors (we only had this kind of error in our deprecated web interface, which would interrupt flashing if users tabbed out). I wonder if it could be a bad connector, or what else could cause this.

I see the failures on two (somewhat different) Dell notebooks on Ubuntu 20.04 reliably. It's a Solo Hacker V1.2 having a USB-C plug + C-to-A adapter. I assume the adapter is passive.
From my side you can merge if you feel comfortable to do so. Just don't blame me if bunches of Solo Hackers will be bricked in the next weeks ;-)


wip/6.0 Fix a bug in SqlAstTreeHelper

Seems an obvious overlooking. Test cases added.

I close this PR for the bugfix has been included in another PR, i.e. https://github.com/hibernate/hibernate-orm/pull/3327


Relocate postAction() call

https://github.com/CrazyGuy108/pokemonshowdown-ai/blob/490ba3cd7bf2d641e6fe7814ea05e7fef4c5b6ef/src/bot/battle/Battle.ts#L73-L90
On line 88, postAction() is supposed to setup everything for the next turn. However, there are two scenarios where this could be called prematurely:

The AI made a replacement switchin which died to entry hazards and has to be replaced again.
A choice was rejected by the server (possibly providing useful info) and the AI has to re-decide (implementing later).

In both cases, the AI would have to make a second choice based on the postAction-changed data, which was meant to be called afterwards.
First, rename postAction() back to postTurn() to prevent confusion, since this function is supposed to handle per-turn statuses.
After that, in the battleprogress handler, before handling new events, call postTurn() if the events that were handled previously contained a |turn| event. This can be done by exposing a getter to EventProcessor's newTurn field.

Still need to rename method and check for |turn| event.


Connection error on item pick up

Every time you pick up dropped stack of more than 1 item (like ember) you just get connection error.

Fixed:
see Release 0.0.2F


lint: ignore a typecheck error

Change Description
This lint error was causing builds of some pull requests to show up as failed. I also reproduced this on my local computer.
One thing I read is that it could be related to a go version mismatch. But it is odd to only show up in one file.
The error is certainly spurious because it is an error that the case has already been seen, but the cases are in fact unique types. It must be confused and saying the type of both is a pointer or interface{}.
Ignoring it means that the switch statement may not be properly linted.
Steps to Test
Does this pass the lint step of the CI build? Run locally (works on my Mac!) with:
golangci-lint run -v

Or faster is to disable the .golangci.yml and run:
golangci-lint run -v --disable-all -E typecheck ./.

Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[x] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[x] Commits follow the Ideal Git Commit Structure.
[x]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

never mind, this seems to be a heisenbug that only shows up in some builds.


[BUG] hideForKeycloakUsers does not hide elements

Environment
Self-Hosted (Docker)
System
firefox 112, docker version 23.0.4
Version
2.1.1
Describe the problem
I have setup a selfhosted keycloak instance as described in the docs for dashy and (hide|show)ForKeycloakUsers does not seem to work as expected. The login part worked after downgrading from 2.1.1. to 2.1.0 (#678). Now the issue is that my user is part of the group dashyReadOnly as seen here on Keycloak

And in the dashu config I have this
appConfig:
  statusCheckInterval: 0 # service will only be checked on initial page load
  preventWriteToDisk: true
  theme: default
  enableFontAwesome: true
  statusCheck: true
  auth:
    enableGuestAccess: false
    enableKeycloak: true
    keycloak:
      serverUrl: 'https://auth.mypage.com'
      realm: 'test-realm'
      clientId: 'test-client'
      legacySupport: true # remove this if keycloak >= v17

sections: # An array of sections
  - name: Apps
    icon: far fa-rocket
    items:
      - title: test-app
        description: testing the tests to improve other tests
        statusCheckAllowInsecure: true
        icon: si-streamlit
        url: https://tests.com
        displayData:
          hideForKeycloakUsers:
            groups: ['dashyReadOnly']

Now when I log in as the user jga I can still see the item test-app.
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

I mentioned on your linked discussion that:

Downgrading to 2.1.0 worked for me, as did the suggested advice to change the entrypoint.

Do you know if the hideForKeycloakUsers issue persists using 2.1.1 with the modified entrypoint?

I do not know if the issue is persistent as I am running 2.1.0.
I checked that the token holds the correct group, which it does, so i suspect that something is going wrong in dashy.

This issue is still relevant. I still believe it is related to #1051

Issue is still relevant.

@jakob1379 Same issue... any solutions???

Just an update - either this has never been a problem OR it has been pushed as a hotfix which does not update the version. See my description here:
https://github.com/Lissy93/dashy/issues/1290#issuecomment-1857784047


Remove deprecated sulu_meta_seo function from default template.

I heard the sulu_meta_seo Twig function is deprecated, but it's still in the default template.
We should change that as they seem to be one of our top references.
https://github.com/sulu-io/sulu-standard/blob/develop/src/Client/Bundle/WebsiteBundle/Resources/themes/default/blocks/meta.html.twig

Fixed in #493


fix: lower the postgres version in the CI to fix error

Fix: https://github.com/casbin-lua/kong-authz/issues/11

@conghuhu plz fix:

@conghuhu plz fix:


Update Okta dependency to 10.x.x

Background
Okta released a new version of their SDK. This version jump (8.x -> 10.x) is a major breaking change, and requires some code changes on our end to implement.
Action requested
Upgrade the backend Okta dependency to 10.x.x (whatever the most recent stable version is at the time this ticket is picked up). Make all the necessary code changes to ensure tests pass, the app starts up correctly, etc.
The migration guide suggests that we'll need to change our Client instantiation to instead instantiate the specific API areas - User, Group, etc.
Acceptance Criteria
Backend is upgraded to Okta version 10.x.x.
Additional context
See the original Dependabot PR that attempted the upgrade: https://github.com/CDCgov/prime-simplereport/pull/5029
See also the Okta API Javadocs and their migration guide from 8.x.x to 10.x.x

Updating this dependency also requires us to add a dependency on openapitools, since that's how Okta is generating their SDK.

Branch with in-progress API edits: https://github.com/CDCgov/prime-simplereport/compare/emma/5065-okta-update?expand=1
The strategy for this branch is roughly:

Update the build.gradle dependencies
Change imports where it's easy (ResourceException, UserStatus)
Comment out large portions of LiveOktaRepository and LiveOktaAuthentication - enough to get the backend to compile
Update method by method in LiveOktaRepository (and later LiveOktaAuthentication) to use the new API calls, unit testing as you go

This branch will require regression testing. A lot of API calls have changed, and only so much of that can be tested in unit tests! (If someone wanted to add integration/WireMock tests to LiveOktaRepository I'd be very happy...but it's not required for this ticket)

Mostly done and tested, waiting for an update to the OKTA sdk to fix a bug with updating users

10.2.2 was released, but a new bug with url encoding was found. Waiting for a new version

Will require team group testing


lpuart: GTPR and RTOR are in SVDs but don't exist

in H7 and WB:
LPUARTs have GTPR at offs 0x10, RTOR at offs 0x14, but in the RMs these offsets are 'reserved', so it seems these registers don't exist for LPUART.

RQR.ABRRQ is also present but shouldn't


feat: add setWebpackPublicPath

fixes #154

Hi @gfafei! I've rebased in the latest changes from master so we can get this merged! Thanks for the contribution :)

Published as<EMAIL_ADDRESS>Thanks again!

@gfafei why this config to add a prefix / in the path?

@gfafei why this config to add a prefix / in the path?

i want to use a cdn site...so i want to remove this /

@fireairforce it's just a function with no dependency, maybe you can just write your own in config-override.js, instead of importing from the package


Feat/menu select widget

I'm opening this PR to keep track progress of the menuSelect widget.

[x] displays current refined value
[x] update results after new selected refined value
[x] rename RefinementSelect to menuSelect (needs to get some input from the team about naming)
[x] tests
[x] documentation & examples

What project are you opening a pull request for?

instantsearch.js (use develop base)

Summary
https://github.com/algolia/instantsearch.js/issues/868
Result

Deploy preview ready!
Built with commit edb6fe25b417ef64ed408bcdf67c2c595a5bb124
https://deploy-preview-2045--algolia-instantsearch.netlify.com

I've rebased on develop to make it possible to merge 👍

This will be a community widget. Thanks for the contribution.

Is it already available somehow?

@psren, check out https://github.com/algolia/instantsearch.js/blob/develop/dev/app/custom-widgets/vanilla/selectMenu.js

Seems that some good gems are only available in the dev app, should we make them available via recipes or something?

We were thinking of getting the dev app visible for sure, a nice way would be to link to the source from the published dev novel @vvo
cc @iam4x

The menu select rendering is the example of the connectMenu: https://community.algolia.com/instantsearch.js/v2/connectors/connectMenu.html


pkgs.lib.cleanSourceFilter doesn't clean .git file (for sub-modules)

Issue description
A Git submodule is a directory that also contains a .git file (not a directory). This may contain something like:
gitdir: ../../.git/modules/comparable-key

pkgs.lib.cleanSourceFilter only looks for .git directories, and won't clean this. However, Hydra Git checkouts will clean this.
I think cleanSourceFilter should remove .git nodes, directories or regular files.

Looking at the source of cleanSourceFilter, I believe this has been fixed.


add page for jupyter-pyspark

Added new page for Jupyter-pyspark
Added examples of configuring Spark resources (RAM, CPU)
Added example showcasing how to use the Spark Jar-file extensions

You should add a post on the news-blog about the new article. I can also do it for you


systemd confinement for services using systemd.packages (e.g. mpd)

Describe the bug
Trying to use confinement on packages providing their systemd units with systemd.packages, for example mpd, fails with the following error:
system-units> ln: failed to create symbolic link '/nix/store/6wrmqdvjqb0ysh8v9mjvaiydbazzy4fk-system-units/mpd.service': File exists

This is because systemd-confinement and mpd both provide a mpd.service file through systemd.packages. (mpd got updated that way recently to use upstream's service file)
Steps To Reproduce
Steps to reproduce the behavior:

should probably reproduce with systemd.services.mpd.confinement.enable = true; on nixpkgs >= 746e627b4032898290f1b51dccf715d3a819366b (Jan 11)

Expected behavior
Should work regardless of original service? Or at least try to.
Additional context
Using upstream service directly is a bit annoying with confinement, as we can't inspect it to check for e.g. ProtectSystem or other incompatible options, but it should be possible to just mash all the files together as overrides.
In nixos/lib/systemd-lib.nix for systemd.units units we check if the original unit exists and if so install the unit as foo.d/override.conf, a similar check could be added to install overlapping units from systemd.packages as override as well.
Note care would need to be taken about the override name, because in this case we'd get 2 overrides, so the overrides will also need different names, so this is not trivial.
Alternatively, the confinement code could try to generate the list of bind paths not as a separate unit file but as a list to fill in systemd.services.<servicename>.serviceConfig.Bind(ReadOnly)Paths directly; that would avoid one level of collision and solve the issue at hand. there's quite a few readink calls involved so I'm not sure if that's possible however...
Notify maintainers
@aszlig (for confinement) -- letting you pull in more people if you'd like.

In nixos/lib/systemd-lib.nix for systemd.units units we check if the original unit exists and if so install the unit as foo.d/override.conf, a similar check could be added to install overlapping units from systemd.packages as override as well.
Note care would need to be taken about the override name, because in this case we'd get 2 overrides, so the overrides will also need different names, so this is not trivial.

Hm, why not just put the confinement stuff in foo.service.d/confinement.conf in the first place? It wouldn't work if there is no foo.service file but OTOH, confinement without any other unit options set wouldn't make sense anyway, right?

Alternatively, the confinement code could try to generate the list of bind paths not as a separate unit file but as a list to fill in systemd.services.<servicename>.serviceConfig.Bind(ReadOnly)Paths directly; that would avoid one level of collision and solve the issue at hand. there's quite a few readink calls involved so I'm not sure if that's possible however...

Unfortunately, this would involve an IFD because we need to already know the runtime closure of the package(s) in hand.

Hm, why not just put the confinement stuff in foo.service.d/confinement.conf in the first place? It wouldn't work if there is no foo.service file but OTOH, confinement without any other unit options set wouldn't make sense anyway, right?

If we can do that it'd work, yes. I don't think we should worry about the "no foo.service" case, it doesn't make sense without Start/Stop/whatever directives anyway.
Looking at generateUnits in nixos/lib/systemd-lib.nix I don't see how we could control the name to be confinement.conf directly as is, but perhaps you had an idea?

I thought more about doing this:
diff --git a/nixos/modules/security/systemd-confinement.nix b/nixos/modules/security/systemd-confinement.nix
index 0e3ec5af323..f3a2de3bf87 100644
--- a/nixos/modules/security/systemd-confinement.nix
+++ b/nixos/modules/security/systemd-confinement.nix
@@ -175,8 +175,8 @@ in {
       serviceName = "${name}.service";
       excludedPath = rootPaths;
     } ''
-      mkdir -p "$out/lib/systemd/system"
-      serviceFile="$out/lib/systemd/system/$serviceName"
+      mkdir -p "$out/lib/systemd/system/$serviceName.d"
+      serviceFile="$out/lib/systemd/system/$serviceName.d/confinement.conf"

       echo '[Service]' > "$serviceFile"

The tests still succeed with that change. Can you please check whether it works for your mpd case?

Oh, for some reason I was convinced systemd.packages would not preserve subdirectories.
Just checked, it works:
# systemctl cat mpd | grep '# /'
# /etc/systemd/system/mpd.service
# /nix/store/9njxrh1gliicaikdhgl4z3lgpn6k0190-system-units/mpd.service.d/confinement.conf
# /nix/store/9njxrh1gliicaikdhgl4z3lgpn6k0190-system-units/mpd.service.d/overrides.conf

I'll let you open a PR with that?
thanks!


Update version number for next release

Updating the version number for next month's release

Are you also going to bump up the extension versions that were published?

Pull Request Test Coverage Report for Build 662018272

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 43.348%

Totals

Change from base Build 661961881:
-0.001%

Covered Lines:
25413

Relevant Lines:
53484

💛  - Coveralls


JSON validation requires one object per line, breaks on pretty-printed JSON

The command-line validation tool in opentargets/validator gives errors when a syntactically and semantically valid JSON file with "pretty" line breaks and whitespace is passed to it. The same file with the line breaks and whitespace removed validates without errors.
This is because the tool requires a single JSON object per line. Hence it is specific to the file format required by Open Targets for the evidence submission, it is not a general-purpose JSON validator.
Examples of files that are valid and invalid (according to the validator) are below. (Note that they are JSON files but had to be renamed to .txt to allow them to be attached)
eva_single.txt
eva_single_pretty.txt
Suggested improvement: have the validator detect this and explicitly warn about it.

I don't think this can be implemented in practice, without lots of additional pre-processing. The readme now documents this, and hopefully the error messages are clearer (see opentargets/platform#401 ), so that should minimize the impact of this issue.
I'm going to close this - but it can be re-opened if there is a good rational for the effort.


Node 6.1.0, sass files are not processed - no .css output in dist

Just had to repave my Windows 10 machine and installed Node 6.1.0. Then angular-cli, etc. When 'ng serve' (or build) .css files don't get created at all (node-sass is installed). But it worked in Node 5.x.x which I had installed before (the project files have not changed). Not sure this is a cli issue or node-sass though.

Node 6 isn't fully supported yet. We have to test it properly. There's a PR in the work but it's still a way to be 100% compatible. We'll update the README when we have full support.


Add cookies banner to guidance site

Summary of the changes

Add cookies banner to manage Google Analytics cookies
Use Gatsby GDPR plugin to manage connection between guidance site & Google Analytics

Related issue
#45
Checklist

[x] I have manually accessibility tested any changes, if relevant.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: GCHQ-Developer-847:x: GCHQ-Developer-112:x: ad9242You have signed the CLA already but the status is still pending? Let us recheck it.


updated currencies list according to http://openexchangerates.org/currencies.json

Thanks. Please note that this PR is against the current stable, but soon legacy version. See the nextrelease branch for the upcoming release.

Thank you for the heads-up! I will use the nextrelease branch.

Merging this into the legacy version.

Thanks @rgeraads


TypeError: null is not an object (evaluating 'NativeNf Manager[name]')

Hello, i have the following problem. When i open my react-native expo app from Expo Go using my android device on NfcManager.start() im getting the following error: TypeError: null is not an object (evaluating 'NativeNf Manager[name]'). Please someone help me to solve this issue <3

+1
I'm Also facing the same problem. Cannot start NfcManager().

Hi @martin12345678900 & @ahirwar-ankit while using Expo Go, you CANNOT add custom native modules like this one.
You should consider to use Expo EAS if NFC is required for you app, and the related doc is here


Miss sperator in otp

I need sperator for each number and position of sperator

currently It does support for middle and all separator. thank you! you can check #13


tls: populate the server name into stream info in ActiveTCPListener

Commit Message: populate the server name into stream info in ActiveTCPListener
Additional Description:
Before the connection reach to TCPPorxy filter or HCM, the server
name won't be populated into stream info. It leads to the access
log get an empty server name. This patch populates the server name in
ActiveTCPListener.newConnection(), then filter doesn't need to care about
it anymore.
Risk Level: low
Testing: n/a
Fixes #14922
Signed-off-by: He Jie Xu<EMAIL_ADDRESS>

/retest

/retest

thanks for the review, I will update soon!

/retest

Yes I think this is likely a bug in the same class of issues I fixed a while back with addresses. Optimally, we would do something similar here so we don't mess this up.

I didn't realize until now how similar it is. There's an accessor for the requestedServerName on the Connection, which I didn't realize. Maybe we can just delete that entirely, and say that the way to get it is always from the streamInfo, and make sure it's always populated on the streamInfo. Then it becomes a simpler problem than the addresses. It's only used in about ~10 places off of the Connection. Thoughts @mattklein123 ?

I didn't realize until now how similar it is. There's an accessor for the requestedServerName on the Connection, which I didn't realize. Maybe we can just delete that entirely, and say that the way to get it is always from the streamInfo, and make sure it's always populated on the streamInfo. Then it becomes a simpler problem than the addresses. It's only used in about ~10 places off of the Connection. Thoughts @mattklein123 ?

I think this would be fine, but keep in mind that there are unfortunately multiple stacked stream infos (connection, stream, etc.) so we need to make sure to not actually break copying the data over.
Another option would be just adding this to SocketAddressProvider (and maybe renaming it) which is how I fixed all the address bugs. Basically I made it impossible to not have this data be carried everywhere.

I didn't realize until now how similar it is. There's an accessor for the requestedServerName on the Connection, which I didn't realize. Maybe we can just delete that entirely, and say that the way to get it is always from the streamInfo, and make sure it's always populated on the streamInfo. Then it becomes a simpler problem than the addresses. It's only used in about ~10 places off of the Connection. Thoughts @mattklein123 ?

I think this would be fine, but keep in mind that there are unfortunately multiple stacked stream infos (connection, stream, etc.) so we need to make sure to not actually break copying the data over.
Another option would be just adding this to SocketAddressProvider (and maybe renaming it) which is how I fixed all the address bugs. Basically I made it impossible to not have this data be carried everywhere.

Hope I understand correctly. I search the socket address issue https://github.com/envoyproxy/envoy/issues/14133, so the goal here is not to carry the info anywhere, avoid the bug we always forget to populate the info somewhere, just share the same info from the connection.  So we can put the server_name into the socket address provider(need to rename it). Is it correct? @mattklein123
If it is correct, I found other than the 'server name', we also can put the 'downstream ssl info' https://github.com/envoyproxy/envoy/blob/233546f9e6cef00df4ec7d0bde58bfec7b1f0397/source/common/http/conn_manager_impl.cc#L651 and 'connection id'
https://github.com/envoyproxy/envoy/blob/233546f9e6cef00df4ec7d0bde58bfec7b1f0397/source/common/http/conn_manager_impl.cc#L654
into the socket address provider. Those are used for l4 stream info and http stream info and also populated from the connection.
Also, @ggreenway mentioned, we should clean up the way to get the stream info, it should be always from the stream info. for example:
https://github.com/envoyproxy/envoy/blob/233546f9e6cef00df4ec7d0bde58bfec7b1f0397/source/extensions/filters/http/rbac/rbac_filter.cc#L49
let me know whether this is the direction you guys looking for, I'm happy to work on it :)

Yeah in general ^ makes sense to me. In general if we can consolidate information that should never change into a single structure to avoid bugs in copying it around that would be optimal.

@mattklein123 @ggreenway I'm going to separate the whole thing into different PR since I found the PR will become huge and hard to review, this PR is just moving the server_name inside SocketAddressProvider.  Then I will have other PRs for moving 'ssl info' and 'connection id'. Then a PR for ensure the server name only get from the address provider, the last PR will rename the SocketAddressProvider to proper name. But let me know if you have other perference.

fyi, I create an issue to track the whole thing https://github.com/envoyproxy/envoy/issues/17168

Check CI?
/wait


Embedded Discourse Comments in project portal pages

Probably use the category here

Project portal pages no longer exist in https://github.com/LibCrowds/vue-pybossa-frontend


Re-pin numpy

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Basically many packages have already migrated to numpy 2 and declare OpenVINO as a dependency such as opencv.
This would set that effort back

ok i think i understand:
libopenvino-dev which is my main concern, does not pull in numpy as a requirement.
libopenvino-dev
```bash
conda-forge/noarch                                          Using cache                                                                                [0/82]
Transaction
Prefix: /home/mark/miniforge3/envs/openvino
Updating specs:

libopenvino-dev[version='>=2024.0']

Package                                    Version  Build                  Channel           Size
─────────────────────────────────────────────────────────────────────────────────────────────────────
Install:
─────────────────────────────────────────────────────────────────────────────────────────────────────

_libgcc_mutex                                0.1  conda_forge            conda-forge     Cached
libgomp                                   13.2.0  h77fa898_10            conda-forge     Cached
_openmp_mutex                                4.5  2_gnu                  conda-forge     Cached
libgcc-ng                                 13.2.0  h77fa898_10            conda-forge     Cached
libiconv                                    1.17  hd590300_2             conda-forge     Cached
xz                                         5.2.6  h166bdaf_0             conda-forge     Cached
ocl-icd                                    2.3.2  hd590300_1             conda-forge     Cached
libzlib                                    1.3.1  h4ab18f5_1             conda-forge     Cached
libstdcxx-ng                              13.2.0  hc0a3c3a_10            conda-forge     Cached
icu                                         73.2  h59595ed_0             conda-forge     Cached
snappy                                     1.2.0  hdb0a2a9_1             conda-forge     Cached
libabseil                             20240116.2  cxx17_h59595ed_0       conda-forge     Cached
pugixml                                     1.14  h59595ed_0             conda-forge     Cached
libxml2                                   2.12.7  hc051c1a_1             conda-forge     Cached
libprotobuf                               4.25.3  h08a7969_0             conda-forge     Cached
libhwloc                                  2.10.0  default_h5622ce7_1001  conda-forge     Cached
tbb                                    2021.12.0  h297d8ca_1             conda-forge     Cached
tbb-devel                              2021.12.0  h7c56ddd_1             conda-forge        1MB
libopenvino                             2024.1.0  h2da1b83_7             conda-forge     Cached
libopenvino-tensorflow-lite-frontend    2024.1.0  he02047a_7             conda-forge     Cached
libopenvino-tensorflow-frontend         2024.1.0  h39126c6_7             conda-forge        1MB
libopenvino-pytorch-frontend            2024.1.0  he02047a_7             conda-forge     Cached
libopenvino-paddle-frontend             2024.1.0  h07e8aee_7             conda-forge     Cached
libopenvino-onnx-frontend               2024.1.0  h07e8aee_7             conda-forge     Cached
libopenvino-ir-frontend                 2024.1.0  h5c03a75_7             conda-forge     Cached
libopenvino-intel-npu-plugin            2024.1.0  he02047a_7             conda-forge     Cached
libopenvino-intel-gpu-plugin            2024.1.0  h2da1b83_7             conda-forge     Cached
libopenvino-intel-cpu-plugin            2024.1.0  h2da1b83_7             conda-forge     Cached
libopenvino-hetero-plugin               2024.1.0  h5c03a75_7             conda-forge     Cached
libopenvino-auto-plugin                 2024.1.0  hb045406_7             conda-forge     Cached
libopenvino-auto-batch-plugin           2024.1.0  hb045406_7             conda-forge     Cached
libopenvino-dev                         2024.1.0  h64d3f89_7             conda-forge      250kB

Summary:
Install: 32 packages
Total download: 3MB
─────────────────────────────────────────────────────────────────────────────────────────────────────
Confirm changes: [Y/n]
</details>

However, on the main branch, it got pulled in just as numpy 2.0 got release, so the pip check failed.

You should consider submitting a repodata patch to ensure the older versions of libopenvino are correctly installable.


problem md-backdrop can't remove after close bottom sheet

I write event ng-mouseover open bottom sheet, but when I mouseover multiple, bottom sheet show right data after I cancel bottom sheet, md-backdrop only remove last backdrop so screen freezes. How can i remove all backdrop after bottom sheet cancel. Thanks!

Since the question is ngMaterial-specific, it should be posted to the ngMaterial repo.
This repo is for core AngularJS.


Package-config files should use @libdir@ for libdir

Both the dbus-sharp-1.0.pc.in and dbus-sharp-glib-1.0.pc.in should use @libdir@ for the libdir variable instead of hardcoding it to ${exec_prefix}/lib.  This prevents errors and issues preventing installation and detection of these packages when installing programs that use these libraries on systems that use lib64 for x64 systems, such as Fedora.

Fixed in dbus-sharp in the commit referenced above, and also in dbus-sharp-glib.


No more updates

Hey there.
There are no more updates of the ban lists since 6 days.
Is the project still supported or is it dead ?
Greetings

sorry, my machine was down (for some reason) which did this in an automatic manner. fixed now. everything went back to normal

Seems machine is down again :-) As no update has occured the last 5 days. Just a reminder here ;)

@knarfd thx. i've triggered a manual update now, but seems that that same machine is failing hard. will take a look on Monday what's up

Thank you, and also thanks for your work!

@knarfd thx. i've triggered a manual update now, but seems that that same machine is failing hard. will take a look on Monday what's up


Not really an issue

yours is the first unity - tfsharp example i came across. thank you for getting me going.
I am trying to classify images through unity. Need your input on the following.
How would you change this line for an input image of dimension 128 x 64 (width x height).
https://github.com/jzharris/Unity-MNIST/blob/e9a4fd5855f5a034e0c35c6bc794460ba732a119/Unity-Files/MNIST/Assets/Scripts/MNIST_Classifier.cs#L56
Thank you,
Nihal

Hello Nihal,
I have clarified which operations use the image's width vs. height. Please pull commit #1e088b3b4c6d7e93f498d92d5aa115cb309f4640 and verify that the classifier output is what you expect.

Thank you for the clarification.
I have yet to pull.
Could you please explain the need for this kind of index access.

FYI.
I have trained my own model, in numpy arrays created from opencv images. The CV.imread, resize, and then np.asarray path

You are correct, my method was very complicated. I propose a simpler solution in the latest commit, a54f25097e1244e5b1dcf52768e596aac310a833.
Unity has no way of converting an image texture to an array of pixel values, so I loop through the input texture and copy each value into the array one pixel at a time.

Hello,
Thank you for making the code simpler to read.
could you elaborate the need to do this
inputImg [0, img_width - i - 1, j, 0] = input.GetPixel(j, i).r;
rather than
inputImg [0, i, j, 0] = input.GetPixel(i, j).r;

Nihal

I am guessing the input data order would depend on how the model training input data have been provided.
I would need to double check on that

float[,,,] img = new float[1, imageHeight, imageWidth, 1];

for (int y = imageHeight - 1; y >= 0; y--) {
    for (int x = imageWidth - 1; x >= 0; x--) {
        img[0, imageHeight - y - 1, x, 0] = texture.GetPixel (x, y).r;
    }
}

This is working for my case.
Thank you Zach!!!


Processors in pipelines not working in versions 7.0.23, 7.0.24 and 7.0.25 using  get_stroom.sh

Since version 7.0.23 using get_stroom.sh, the processors in the pipelines are not working any more.
Using the big blue stepping button at the bottom right of the bottom data pane it process the data.
I tried versions:

stroom-stacks-v7.0.23
stroom-stacks-v7.0.24
stroom-stacks-v7.0.25

Rolling back to 7.0.22 it works fine again.
Maybe there is an option to configure, I'm a new comer in the community.

v7.0.23 created a new managed job called Processor Task Creator , this needs to be enabled to create processing tasks


feat: migrate PressableWithSecondaryInteraction to function component

Details
Refactored PressableWithSecondaryInteraction (web) from class to function component
Fixed Issues
$ https://github.com/Expensify/App/issues/16192
Tests

[x] Verify that no errors appear in the JS console

Offline tests

--
QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/25725586/42cbcbbf-98fa-48dd-90ee-98b1e805c493
https://github.com/Expensify/App/assets/25725586/84e97f1b-14d5-4a77-bfc9-85082407f7e6

Mobile Web - Chrome
https://github.com/Expensify/App/assets/25725586/3932e74c-fc66-4595-9b0b-55755b9b6fe4

Mobile Web - Safari
https://github.com/Expensify/App/assets/25725586/900c9e5d-7d11-41d0-a9eb-041a803f90ba

Desktop
https://github.com/Expensify/App/assets/25725586/3bdc0991-9261-4b66-b44f-4ab117e94918

iOS
https://github.com/Expensify/App/assets/25725586/f0f70ddd-fe3d-4a4e-b98a-d01d4049bfb5

Android
https://github.com/Expensify/App/assets/25725586/7c99a7dc-0ae7-4f01-9e1a-8b3e3c884b7b

Updated 👍

@0xmiroslav working on the checklist? Lmk when this is ready for me 🙇♂

@0xmiroslav Any update?

I'll be OOO this week, but someone from Callstack will pick this up if necessary

I believe we are on a merge freeze at the moment so I am holding for a bit - unless this fixes a critical bug or something.

PR updated with main, ready for merge

@0xmiroslav @marcaaron Pinging about this, so that it does not get forgotten

Please also re-test after merging main

Re-tested, seems to be working fine 👍

@0xmiroslav Hi, any update? Is anything blocking this?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.71-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


[API] Set None as default axis for reduction operations

Closes #194
This was not as easy as expected. I got the error that I could not reduce over multiple axes because the array elements were not reorderable for this operation. I traced that back to the numpy source:
https://github.com/numpy/numpy/blob/5cae51e794d69dd553104099305e9f92db237c53/numpy/core/src/umath/reduction.c#L207
https://github.com/numpy/numpy/blob/509b5ae4a7bb3c99324fd302ead1bbf4b130c741/numpy/core/src/umath/ufunc_object.c#L3637
https://github.com/numpy/numpy/blob/4d290795d4e8c60053eb789acf173159dc4c1575/numpy/core/src/umath/ufunc_object.c#L2445
It appears to be undocumented how to signal numpy that the operation is "reorderable" (commutative?). The trick was providing PyUFunc_ReorderableNone as identity in the ufunc definition. I can see this to be present as far back as numpy 1.14.

I was going to say: but why does it then already work for pygeos.union_all(arr, axis=None) right now? But of course we have a custom implementation for union_all, not using a reducing ufunc ..
Thanks for figuring this out!


@-webkit-keyframes Not Supported

@-webkit-keyframes does not come to the output. cssmin discards it but this seems to be because css-min is using clean-css.
https://github.com/gruntjs/grunt-contrib-cssmin/issues/237
https://code.google.com/p/cssmin/issues/detail?id=26

clean-css supports it - please check what version of clean-css you use (with npm ls) first.
Here's a test file:
https://github.com/jakubpawlowicz/clean-css/blob/d21f1e0808dfc1a658f745cad93e8b74466ffe73/test/fixtures/font-awesome.css#L242
and output:
https://github.com/jakubpawlowicz/clean-css/blob/d21f1e0808dfc1a658f745cad93e8b74466ffe73/test/fixtures/font-awesome-min.css#L59
It may be an edge case though, so if you still experience it with the latest clean-css please reopen this issue and attach an example.


Added tests to validate security level filter.

This set of tests will validate that the Jira security level filter is work as expected
There are existing tests for filters but they pre-date a change making security level a required filter when trying to deliver details from Jira that have security level associated with them.
Is the feature in stable branch or under review?

[x] Feature in stable branch (master, main)?
[] Feature still under review? If yes, list all related pull requests for reference.

Test client

[x] Browser
[] Mobile App (version, OS)
[x] Desktop App (version, OS)

@DHaussermann I realized that all titles were the same after saved and synced in Zephyr. I've updated the titles as follows. Please help check and feel free to correct and update:

MM-T5449: No options are available in security groups
MM-T5450: Event not delivered as there is no security level applied
MM-T5451: Event delivered as the security group matches
MM-T5452: Event not delivered as the security level is outside the scope of the subscription
MM-T5453: Event delivered in the channel


Dart 2 generator

Currently, router.generator returns a Route<Null>, however MaterialApp is expecting a RouteFactory. This doesn't cause issues on Dart 1, but does when enabling the Dart 2 preview.
This will need to be fixed to make Fluro compatible with Dart 2.

I'm sorry, I was totally wrong here. A RouteFactory is just a Route<dynamic>. I don't know what's erroring then, but it's probably worth taking a look!


Draft: Custom dotenv names

Hey!
I started working on possibility of defining multiple .env files to be loaded with just. I basically followed an idea of that issue:
https://github.com/casey/just/issues/945
and added an array for storing filenames.
What do you think about that approach?
It's still WIP, tests are still broken and the default value is not properly defined but I wanted to ask for your opinion before I sink more time into that.

In general, it's a bit hard to review something without tests. With tests, I can look at the new tests, and see what they're doing, which lets me answer the most important question: "Does this change have the right semantics, and is it working?". The code itself is a bit secondary, and can be fixed in review. I think the best way to avoid wasting time is actually to open a PR with new tests that are failing, and no actual implementation. That way the reviewer can confirm that what is being done is correct, and then the author can fill in the implementation.

In general, it's a bit hard to review something without tests. With tests, I can look at the new tests, and see what they're doing, which lets me answer the most important question: "Does this change have the right semantics, and is it working?". The code itself is a bit secondary, and can be fixed in review. I think the best way to avoid wasting time is actually to open a PR with new tests that are failing, and no actual implementation. That way the reviewer can confirm that what is being done is correct, and then the author can fill in the implementation.

I'm a huge fan of this tool, and reading your comment gives me a better perspective of how OSS maintainers think. This makes a ton of sense after reading, thank you!

This has gone pretty stale. Feel free to reopen!


mapping: failure to pass test PositionOfOnePadInDE100Bending

running go test ./... in pigiron, I get:
$> go test ./...
?   	github.com/aphecetche/pigiron	[no test files]
?   	github.com/aphecetche/pigiron/cmd/fer-mch-digotizer	[no test files]
?   	github.com/aphecetche/pigiron/cmd/fer-mch-spy	[no test files]
ok  	github.com/aphecetche/pigiron/geo	(cached)
?   	github.com/aphecetche/pigiron/mapping	[no test files]
testdata/test_de.json--- FAIL: TestPositionOfOnePadInDE100Bending (0.00s)
	segmentation_test.go:269: Should get a valid pad
	segmentation_test.go:272: Should get the same pads here
FAIL
FAIL	github.com/aphecetche/pigiron/mapping_test	6.777s
?   	github.com/aphecetche/pigiron/segcontour	[no test files]

this is at revision c8333c3.

d'oh... ignore me... that's "by design" as it's not implemented yet :)


Feedback on Tutorial: Asynchronous Non-Blocking I/O within Node.js SAP HANA applications

I am unable to locate exerciseAsync.zip on git repo. Can someone please help?

Try here https://github.com/I809764/xsa-workshop/


⚠ Fortnite has degraded performance

In f386c38, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1550 ms

Resolved: Fortnite performance has improved in c8ebf19.