Latitude longitude are 0 after turning on the location services

I am using this library to get the location. But when GPS is not On and we turn on it by going to settings which opens from location.openSettings() method. In this case the location is coming as 0. How to get correct location?

Thanks for your feedback!

Do you have <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" /> in the manifest? Probably yes, right?
Do you check availability with location.hasLocationEnabled()?

If you just enabled GPS, the location may not be available yet. So what happens if you try later again? If GPS has been enabled for a while, the next time you try, a location should be available.
Does this work?

Thanks for the quick reply,
yes i have this permission in my manifest file.
GPS is taking 30-60 seconds to getting enable,location.hasLocationEnabled() will give false till the processing.
I am finding as much as fast response from GPS after enabling it,want to do GPS processing time less.
Is it possible to get less time to enable and give me Lat,Long?
I really need this.

In general, GPS just takes some time to get the first position or "fix". But there may still be some things you could do.
You may call location.beginUpdates(); as early as possible. Maybe in onCreate(...) and location.endUpdates(); in onDestroy().
Furthermore, you should explicitly set the mode to GPS (not network location) by using the constructor SimpleLocation(final Context context, final boolean requireFine) with the second parameter set to true.
By the way, if you got a position previously, the library returns a cached position before the first GPS update is received. So you should not get (0, 0) anymore in those cases.
The third parameter (passive mode or not) should probably be false for your use case (which is the default). But you may set the fourth parameter (the interval in milliseconds) to a shorter period of time (e.g. 15000 which is 15 seconds).

if (location.hasLocationEnabled()) {
// ask the device to update the location data
location.beginUpdates();
//...
        // get the location from the device (alternative A)
        double latitude = location.getLatitude();
        double longitude = location.getLongitude();

        // get the location from the device (alternative B)
      //  SimpleLocation.Point coords = location.getPosition();
        Toast.makeText(
                getApplicationContext(),
                "Mobile Location: \nLatitude: " + latitude
                        + "\nLongitude: " + longitude,
                Toast.LENGTH_LONG).show();

        Log.i("simple location", "Mobile Location: \nLatitude: " + latitude
                + "\nLongitude: " + longitude);
        //...
        // ask the device to stop location updates to save battery
       // location.endUpdates();
    }
    else {
        Log.i("simple location"," gps disabled ");            // ask the user to enable location access
        SimpleLocation.openSettings(this);
    }

Sir,above code is which i placed at my onCreate() ,if gps is not enabled ,app is redirecting to location setting it is good ,but after enable the gps ,when come to my app ,i am getting (0,0) again ,i am continuously checking location.hasLocationEnabled() at my button event ,but nothing new happens ,,still 0,0...Please help

Thanks! We should have checked your code right from the beginning :) There were two issues:

There was a bug in this library. It should have been fixed now. Thanks for pointing this out!
The usage of lifecycle methods in your example was wrong. If you put all this in onCreate(...), this does not work. The reason is that, when you are redirected to the device's settings, Android won't call onCreate(...) again after you come back to your app.

So in order to fix your issue, please get the updated JAR for this library and refer to the updated code example. When you did this, please report if it worked :) Thanks!

@ocram I have also tried the sample code link which you have provided. While opening the app for the second time is my location is off its navigating to the settings page to turn on the location, then I turn on the location and trying to retrieve the latitude and longitude on button click but getting 0.0 both latitude and longitude.How to fix this ?

@Sidhartha03 Several ways of how this may be fixed have been suggested above. Apart from that, there is a number of other issues here which you could check and the README contains detailed descriptions. Did you try all that?

I have just enabled GPS and didn't get the lat long in the Oreo Device in OnePlus with oxygen version 5.1.2 in the frist glance . I have given all the permission in all other devices it is working properly only the oreo device has a problem ? Can yo tell me any solution for it ?

@shrutika229 I am getting wrong latitude and longitude points in oneplus 2 but getting the right one in my other phone,have you sorted this out ?

@shubhamk1997 Wrong (non-zero) latitude and longitude values are something that is definitely caused by the device and OS and thus not this library. But perhaps you just need to decrease the duration between location updates. You should look at the options that the parameters of the constructor offer.


Show hint for multiple active cards

Is your feature request related to a problem? Please describe.
When the user activates more than one card, some information dialog should be displayed once, that informs the user how to switch between cards.
Describe the solution you'd like

show an information dialog once the user activates a second card (if one is already active)
show information how to switch between cards
add two buttons with "weiter" and "nicht mehr anzeigen"
if the user clicks "Nicht mehr anzeigen" set a flag that this dialog won't show up again
if the user clicks "ok" the dialog will show up again if another card will be activated

Design
We have an existing dialog we could reuse. Maybe this is good enough with a proper text @hauf-toni

i could reduce the padding and the view fraction of of the carousel. It would look like that @hauf-toni

@f1sh1918 Nice! I just have one small change to add: To show users that they can switch between cards navigation dots beneath the card would actually be more prominent and visible compared to the first version. Also, the QR Code should only become visible once the card is selected, no preview displayed. If we would want to clarify this feature we could also consider adding a subtle swipe animation on the first load.

@f1sh1918 Nice! I just have one small change to add: To show users that they can switch between cards navigation dots beneath the card would actually be more prominent and visible compared to the first version. Also, the QR Code should only become visible once the card is selected, no preview displayed. If we would want to clarify this feature we could also consider adding a subtle swipe animation on the first load.

the issue is that the barcode belongs to the card and you switch both. You solution pretends that only the id card is changing which is technically wrong

For me it would then make more sense to put it on top


[run_hook] Allow passing namespace if needed in CR hooks

As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

/approve

/lgtm
shouldn't break anything? :)


Add verbose mode to print the stack trace when requesting a token;

Also clean up some cache code so the cache will work even without providing a cache key
Similar to https://github.com/coupa/sand-ruby/pull/32/files

[ ] @johnny-lai
[x] @abdulchaudhrycoupa
[ ] @supriya

Generated Reviewers

:warning: Do not modify anything in this section! :warning:
The content in this section is managed automatically, and any manual changes to it will be ignored and overwritten the next time the code review status is refreshed! View this PR on Cody to see the current code review status.

[lockit v4.9.3] merged via Lockit CLI on 2021-09-10 10:49:10.21076 +0800 CST m=+4.163033490


Having Bad Request while creating invoices

PHP 8.0.3
Laravel 8.35.1

Hello,
a 400 Error means that the Request has a malformed syntax or a bad query.
Learn more about Status-Codes here: https://developers.lexoffice.io/docs/#http-status-codes
It look like that Carbon::now() is not returning RFC 3339/ISO 8601 Date.
Look at the documentation here:
https://developers.lexoffice.io/docs/#invoices-endpoint-invoices-properties

Closing this issue, because It is a problem from your side.
Feel free to create a stackoverflow question or a discussion on github :)

[
            "archived"           => false,
            "voucherDate"        => (new \DateTime())->format(\DateTime::ATOM), // 2021-04-07T09:04:23+00:00
            "address"            => [
                "name"        => "Muhammad Saim",
                "supplement"  => "House #112/113",
                "street"      => "Street #4/5",
                "city"        => "Multan",
                "zip"         => "60000",
                "countryCode" => "PK",
            ],
            "lineItems"          => [
                [
                    "type"               => "Electronics",
                    "name"               => "Lenovo Thinkpad T470S i5 7th 8GB 256GB NVME M.2",
                    "quantity"           => 1,
                    "unitName"           => "Lenovo Thinkpad T470S i5 7th 8GB 256GB NVME M.2",
                    "description"        => "Lenovo Thinkpad T470s 8GB NVME M.2 256GB with 10/10 condition.",
                    "unitPrice"          => [
                        "currency"          => "EUR",
                        "netAmount"         => 700,
                        "taxRatePercentage" => 0,
                    ],
                    "discountPercentage" => 0,
                ],
            ],
            "totalPrice"         => [
                "currency" => "EUR",
            ],
            "taxConditions"      => [
                "taxType" => "net",
            ],
            "paymentConditions"  => [
                "paymentTermLabel"          => "10 Tage - 3 %, 30 Tage netto",
                "paymentTermDuration"       => 30,
                "paymentDiscountConditions" => [
                    "discountPercentage" => 0,
                    "discountRange"      => 0,
                ],
            ],
            "shippingConditions" => [
                "shippingDate" => (new \DateTime())->format(\DateTime::ATOM), // 2021-04-07T09:04:23+00:00
                "shippingType" => "delivery",
            ],
            "title"              => "Laptop i5 7th",
            "introduction"       => "Lenovo Thinkpad T470s 8GB NVME M.2 256GB with 10/10 condition",
            "remark"             => "UltraBook",
        ]

Still having an issue

archived is a readonly attribute. Please re-check the documentation


Better explanation for 'please'

The alert raised for 'please' should explain to the user why it's not a good idea to use the term, and what to use instead.
[RedHat.Usage] Verify your use of 'please' with the word usage guidelines.

fixed in https://github.com/redhat-documentation/vale-at-red-hat/pull/585


Website: Contributing link is not working

Describe the bug, including details regarding any error messages, version, and platform.
On arrow.apache.org, if you click the Community dropdown > Contributing, you get a dead link to https://arrow.apache.org/docs/developers/contributing.html .

Component(s)
Documentation

Thank you for opening up the issue!
Correct, the correct link should point to: https://arrow.apache.org/docs/developers/index.html

The Community dropdown > Contributing item now correctly points to https://arrow.apache.org/docs/developers/index.html so I will close this issue.


[bug] connectivity browser does not init properly

as of 5812b4b62d7f304f57f48b87ad5cdb153253dc1a
to reproduce:
0/ go to /, select multi level human, select a region
1/ click connectivity panel
expected behaviour:
connectivity browser init, and expands
actual beahviour:
connectivity browser does not init, and does not expand

see #902 .
blocked since querying data from BS client may perhaps resolve this issue


Add masks for American Express and Diners Club credit cards

This PR addresses https://github.com/benhurott/react-native-masked-text/issues/83
Let me know if any further tweaks are necessary.

any chance this PR can be merged? @benhurott

@putuyoga yes! I was on vacations, I will update in the next days =).

I guess it not working, in my test doesn't allow me for more than 15 characters, counting spaces


Remove redundant AddDebtCommandParser test

Resolves #124
Overlaps with the first test case in the method with comment // invalid description.

Codecov Report
Base: 74.97% // Head: 74.97% // No change to project coverage :thumbsup:

Coverage data is based on head (bead5b6) compared to base (de6ce9f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #141   +/-   ##
=========================================
  Coverage     74.97%   74.97%
  Complexity      589      589
=========================================
  Files            97       97
  Lines          1830     1830
  Branches        210      210
=========================================
  Hits           1372     1372
  Misses          406      406
  Partials         52       52

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


mini.hues: Strikethrough does not work in Markdown files using Treesitter

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.hues
Description
To have strikethrough work using Treesitter in Markdown files, I have to do:
vim.api.nvim_set_hl(0<EMAIL_ADDRESS>{<EMAIL_ADDRESS>})

Neovim version
0.10.1
Steps to reproduce

Install nvim-treesitter
require('mini.hues').setup()
Open a Markdown file
Insert: ~~test~~

Expected behavior
The line will have strikethrough applied on it.
Actual behavior
No strikethrough.

This line is the issue: https://github.com/echasnovski/mini.hues/blob/0e46bdc04d3df4185097ecff08ad208868572b98/lua/mini/hues.lua#L810

Thanks the issue and finding the cause!
This should be resolved on latest main.


Compatibility with Keystone's Auth

Thank you for working on this great addition to Keystone!
I want to enable both Keystone's built-in auth (https://keystonejs.com/docs/apis/auth) and a social auth for my project. Will this package do both, or do I have to implement the built-in auth separately?

Hi @adanielyan Thanks for reaching out. No, this package doesn't implement the keystone-auth, you could try to implement them side-by-side and hope they nicely together. If you do go down this path I would be interested to hear how it goes and if there is anything that blocks it from this side, I am happy to help.

Thanks for a quick response! I am currently evaluating a few authentication options and haven't decided on my solution yet. I'll report here if I end-up using your package.

@adanielyan did it work out for you to use both together?

After evaluating a few different headless CMSs I decided to go with directus.

anyone figured out how integrate keystone auth with next-auth?


Add generate target to generate code, mocks etc

This PR adds a make target to generate code specifically the awsclient mock

Oh, btw, I assume you're planning on checking in and using the generated file in a subsequent commit :P

Oh, btw, I assume you're planning on checking in and using the generated file in a subsequent commit :P

[Later] Ah, this will replace mock_client.go, ++

I liked this so much I stole it.


Sync eng/common directory with azure-sdk-tools for PR 1560

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1560  See eng/common workflow

/check-enforcer reset

/check-enforcer evaluate

/azp run net - appconfiguration - tests

/check-enforcer override


Added window object check

With this pull request we can use the library in a server-side environment like node.js

Good idea. Thanks!


Debian build script broken

It seems the same as #388, but it till doen't work.
Ubuntu 14.04
root@ubuntu-1gb-ams2-01:~# export GOPATH=$PWD/go
root@ubuntu-1gb-ams2-01:~# mkdir -p go/src/github.com/github
root@ubuntu-1gb-ams2-01:~# cd go/src/github.com/github
root@ubuntu-1gb-ams2-01:~/go/src/github.com/github# git clone https://github.com/github/git-lfs.git
Cloning into 'git-lfs'...
remote: Counting objects: 13277, done.
remote: Compressing objects: 100% (34/34), done.
remote: Total 13277 (delta 8), reused 0 (delta 0), pack-reused 13243
Receiving objects: 100% (13277/13277), 4.63 MiB | 2.51 MiB/s, done.
Resolving deltas: 100% (8839/8839), done.
Checking connectivity... done.
root@ubuntu-1gb-ams2-01:~/go/src/github.com/github# cd git-lfs/
root@ubuntu-1gb-ams2-01:~/go/src/github.com/github/git-lfs# script/debian-build

....
+ cd /root/go/src/github.com/github/git-lfs
+ ./script/bootstrap
can't load package: package github.com/github/git-lfs/commands: cannot find package "github.com/github/git-lfs/commands" in any of:
	/root/.gvm/gos/go1.4.2/src/github.com/github/git-lfs/commands (from $GOROOT)
	/root/.gvm/pkgsets/go1.4.2/global/src/github.com/github/git-lfs/commands (from $GOPATH)
can't load package: package github.com/github/git-lfs/lfs: cannot find package "github.com/github/git-lfs/lfs" in any of:
	/root/.gvm/gos/go1.4.2/src/github.com/github/git-lfs/lfs (from $GOROOT)
	/root/.gvm/pkgsets/go1.4.2/global/src/github.com/github/git-lfs/lfs (from $GOPATH)
script/build.go:15:2: cannot find package "github.com/github/git-lfs/lfs" in any of:
	/root/.gvm/gos/go1.4.2/src/github.com/github/git-lfs/lfs (from $GOROOT)
	/root/.gvm/pkgsets/go1.4.2/global/src/github.com/github/git-lfs/lfs (from $GOPATH)
++ echo FAIL
FAIL

BTW, after that I've run:
root@ubuntu-1gb-ams2-01:~# wget https://github.com/github/git-lfs/releases/download/v1.1.1/git-lfs-linux-amd64-1.1.1.tar.gz
root@ubuntu-1gb-ams2-01:~# tar -xvzf git-lfs-linux-amd64-1.1.1.tar.gz
git-lfs-1.1.1/
git-lfs-1.1.1/CHANGELOG.md
git-lfs-1.1.1/git-lfs
git-lfs-1.1.1/install.sh
git-lfs-1.1.1/README.md
root@ubuntu-1gb-ams2-01:~# cd git-lfs-1.1.1/
root@ubuntu-1gb-ams2-01:~/git-lfs-1.1.1# ls
CHANGELOG.md  README.md  git-lfs  install.sh
root@ubuntu-1gb-ams2-01:~/git-lfs-1.1.1# ./install.sh

And immediately got:
Git LFS initialized.

So it seems that build script installs LFS successfully, but exits with error?

Ah, it's because the script is installing gvm if go isn't installed. The stack trace only shows /root/.gvm/pkgsets/go1.4.2/global in your GOPATH, not /root/go. That script isn't up to date right now.
@andyneff or @ssgelm: Think it's worth keeping these older install scripts up to date?
We have  deb files linux installs, but they didn't upload for Ubuntu for some reason. I'll fix that today.

@terion-name: In your second attempt, you downloaded a statically compiled git-lfs binary. There's no need to run script/debian-build script for it.

My vote would be to nuke the script and instead have people use the debs (which they can build themselves if they so choose) but I have a clear bias towards packages :)

I've actually thought about this many times, and never bothered to mention it. I agree with @ssgelm, nuke em.
The scripts were once important before the packages because of how hard it is to get the ruby ronn for the man pages... This isn't important except for the packages. So they served their purpose, but now if someone want to help develop, all they need is go and the knowledge to call the bootstrap script, and I'd argue a go dev can manage that on their own.

Cool, I'll drop both the debian and rpm scripts :+1:

Arg. We'll have to patch this first
https://github.com/andyneff/git-lfs_dockers/blob/master/centos_7.bootstrap#L33

Yes, these scripts: #1026

I think this is resolved by #1026?

Yep, closing for now 😄


iOS : iMatter or Home app does not initiate pairing

Using the library Device.js entry point, there is no logging output when trying to pair iMatter App or the Home App with the virtual on/off switch in the library.
I have validated that the virtual Matter test device is advertising a valid IP Address in mdns and the iOS device is on the same network with access to the IP Address.
Validated that the Controller.js initiates the correct exchange.  Is there something different with how iOS initiates the exchange?
Validated that iMatter running on OSX starts the setup process and completes with same logging as the Controller.js output.  So the issue is isolated to iOS.
@Apollon77 Let me know how I can help debug and fix this issue.

Hi, what is the iMatter app ... I can only find something like this from "Ministry of Human Services & Social Security"? Or do you mean the normal Home App on your iOS?
For me all this works, i do that several times a day.
SO what exactly you see on the screen? Is the QA Code printed? How you try in your iOS app? WHich iOS version youhave? What you have as "hub"? ipad oder a HomePod? ... More details please

Strange ... so home app works for moe completely and also for others ... hm ... and you are sure that UDP/MDNS can flow everywhere and is not blocked somehow?
I just now installed the iMatter app too and will try later

I pulled logs from iOS during an attempted commissioning.
2125	default	11:51:31.458584-0700	homed	🟢 [1675277491458] [2125:1567558] CHIP: [CTL] Stopping commissioning discovery over DNS-SD
2125	default	11:51:31.458997-0700	homed	🟢 [1675277491458] [2125:1567558] CHIP: [CTL] Shutting down the controller
2125	default	11:51:31.459029-0700	homed	🟢 [1675277491458] [2125:1567558] CHIP: [IN] Expiring all sessions for fabric 0x1!!
2125	default	11:51:31.459062-0700	homed	🔵 [1675277491458] [2125:1567558] CHIP: [FP] Forgetting fabric 0x1
2125	default	11:51:31.459459-0700	homed	🔵 [1675277491459] [2125:1567558] CHIP: [TS] Pending Last Known Good Time: 2023-02-01T18:23:45
2125	error	11:51:31.459491-0700	homed	🔴 [1675277491459] [2125:1567558] CHIP: [TS] Clearing Last Known Good Time; failed to load a previous value from persistence: /Library/Caches/com.apple.xbs/Sources/CHIPFramework/connectedhomeip/src/darwin/Framework/CHIP/MTRPersistentStorageDelegateBridge.mm:47: CHIP Error 0x000000A0: Value not found in the persisted storage
2125	default	11:51:31.459522-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [CTL] Shutting down the System State, this will teardown the CHIP Stack
2125	default	11:51:31.459548-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [DMG] IM WH moving to [Uninitialized]
2125	default	11:51:31.459578-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [DMG] IM WH moving to [Uninitialized]
2125	default	11:51:31.459606-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [DMG] IM WH moving to [Uninitialized]
2125	default	11:51:31.459635-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [DMG] IM WH moving to [Uninitialized]
2125	default	11:51:31.460053-0700	homed	🟢 [1675277491459] [2125:1567558] CHIP: [DMG] All ReadHandler-s are clean, clear GlobalDirtySet
2125	default	11:51:31.460287-0700	homed	🔵 [1675277491460] [2125:1567558] CHIP: [BLE] CancelConnection
2125	default	11:51:31.461141-0700	homed	🔵 [1675277491460] [2125:1567558] CHIP: [FP] Shutting down FabricTable
2125	error	11:51:31.461190-0700	homed	🔴 [1675277491460] [2125:1567558] CHIP: [TS] Clearing Last Known Good Time; failed to load a previous value from persistence: ../../../../../../../../Sources/CHIPFramework/connectedhomeip/src/credentials/LastKnownGoodTime.cpp:203: CHIP Error 0x00000003: Incorrect state
2125	error	11:51:31.461282-0700	homed	🔴 [1675277491460] [2125:1567558] CHIP: [DL] Inet Layer shutdown
2125	error	11:51:31.461349-0700	homed	🔴 [1675277491460] [2125:1567558] CHIP: [DL] BLE shutdown
2125	error	11:51:31.461441-0700	homed	🔴 [1675277491460] [2125:1567558] CHIP: [DL] System Layer shutdown
2125	default	11:51:31.462976-0700	homed	Could not find home with CHIP fabric index: 3
2125	default	11:51:31.463213-0700	homed	Could not find home with CHIP fabric index: 3
2125	default	11:51:31.488862-0700	homed	🟢 [1675277491488] [2125:1567558] CHIP: [DL] _Init
2125	default	11:51:31.488955-0700	homed	🟢 [1675277491488] [2125:1567558] CHIP: [IN] UDP::Init bind&listen port=0
2125	default	11:51:31.489126-0700	homed	🟢 [1675277491488] [2125:1567558] CHIP: [IN] UDP::Init bound to port=62783
2125	default	11:51:31.489191-0700	homed	🟢 [1675277491488] [2125:1567558] CHIP: [IN] UDP::Init bind&listen port=0
2125	default	11:51:31.489495-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [IN] UDP::Init bound to port=53240
2125	default	11:51:31.489532-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [IN] BLEBase::Init - setting/overriding transport
2125	default	11:51:31.489564-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [IN] TransportMgr initialized
2125	default	11:51:31.489625-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [FP] Initializing FabricTable from persistent storage
2125	default	11:51:31.489689-0700	homed	🔵 [1675277491489] [2125:1567558] CHIP: [TS] Last Known Good Time: [unknown]
2125	default	11:51:31.489746-0700	homed	🔵 [1675277491489] [2125:1567558] CHIP: [TS] Setting Last Known Good Time to firmware build time 2022-12-17T04:48:26
2125	default	11:51:31.490304-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [CTL] System State Initialized...
2125	default	11:51:31.490364-0700	homed	🟢 [1675277491489] [2125:1567590] CHIP: [DL] _OnPlatformEvent
2125	default	11:51:31.490417-0700	homed	Could not find home with CHIP fabric index: 3
2125	default	11:51:31.490632-0700	homed	🟢 [1675277491489] [2125:1567558] CHIP: [FP] Initializing FabricTable from persistent storage
2125	default	11:51:31.490657-0700	homed	🔵 [1675277491489] [2125:1567558] CHIP: [TS] Last Known Good Time: 2022-12-17T04:48:26
2125	error	11:51:31.490680-0700	homed	Can't start on existing fabric: fabric not found
2125	default	11:51:31.490739-0700	homed	🟢 [1675277491490] [2125:1567558] CHIP: [FP] Initializing FabricTable from persistent storage
2125	default	11:51:31.490762-0700	homed	🔵 [1675277491490] [2125:1567558] CHIP: [TS] Last Known Good Time: 2022-12-17T04:48:26
2125	default	11:51:31.490832-0700	homed	Generating root certificate
2125	default	11:51:31.493127-0700	homed	🟢 [1675277491492] [2125:1567558] CHIP: [CTL] Stopping commissioning discovery over DNS-SD
2125	default	11:51:31.493160-0700	homed	🔵 [1675277491493] [2125:1567558] CHIP: [CTL] Setting attestation nonce to random value
2125	default	11:51:31.493289-0700	homed	🔵 [1675277491493] [2125:1567558] CHIP: [CTL] Setting CSR nonce to random value
2125	default	11:51:31.506166-0700	homed	🔵 [1675277491504] [2125:1567558] CHIP: [CTL] Intermediate CA is not needed
2125	default	11:51:31.506196-0700	homed	🔵 [1675277491505] [2125:1567558] CHIP: [FP] Validating NOC chain
2125	default	11:51:31.512784-0700	homed	🔵 [1675277491511] [2125:1567558] CHIP: [FP] NOC chain validation successful
2125	default	11:51:31.512814-0700	homed	🔵 [1675277491511] [2125:1567558] CHIP: [FP] Added new fabric at index: 0x1
2125	default	11:51:31.512850-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [FP] Assigned compressed fabric ID: 0x848CF47666E721ED, node ID: 0x2764FDE8CD696D2A
2125	default	11:51:31.512948-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [TS] Last Known Good Time: 2022-12-17T04:48:26
2125	default	11:51:31.512980-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [TS] New proposed Last Known Good Time: 2023-02-01T18:51:31
2125	default	11:51:31.513128-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [TS] Updating pending Last Known Good Time to 2023-02-01T18:51:31
2125	default	11:51:31.513161-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [FP] Metadata for Fabric 0x1 persisted to storage.
2125	default	11:51:31.513555-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [TS] Committing Last Known Good Time to storage: 2023-02-01T18:51:31
2125	default	11:51:31.514022-0700	homed	🔵 [1675277491512] [2125:1567558] CHIP: [CTL] Joined the fabric at index 1. Compressed fabric ID is: 0x0000000000000000
2125	error	11:51:31.529285-0700	homed	Client: -[THClient getConnectionEntitlementValidity:]_block_invoke - Error: (null)
2125	default	11:51:31.529448-0700	homed	🟢 [1675277491528] [2125:1567590] CHIP: [CTL] Stopping commissioning discovery over DNS-SD
2125	default	11:51:31.529472-0700	homed	🔵 [1675277491528] [2125:1567590] CHIP: [CTL] Starting commissioning discovery over DNS-SD
2125	default	11:51:31.529504-0700	homed	🔵 [1675277491528] [2125:1567590] CHIP: [DIS] Browsing for: _matterc._udp,_L3840
2125	default	11:51:31.530332-0700	homed	🟢 [1675277491529] [2125:1567601] CHIP: [DIS] Mdns: OnBrowseAdd  name: 0134585B616563B4, type: _matterc._udp., domain: local., interface: 14
2125	default	11:51:31.530438-0700	homed	🟢 [1675277491529] [2125:1567601] CHIP: [DIS] Resolve type=_matterc._udp name=0134585B616563B4 interface=14
2125	default	11:51:31.530992-0700	homed	🟢 [1675277491530] [2125:1567601] CHIP: [DIS] Mdns : OnNewInterface hostname:001C42D47DC60000.local. fullname:0134585B616563B4._matterc._udp.local. interface: 14 port: 5540 TXT:"VP=65521+32768,DT=257,DN=Matter\x20test\x20device,SII=5000,SAI=300,T=1,D=3840,CM=1,PH=33,PI="
2125	default	11:51:31.534607-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] Mdns: OnNewAddress interface: 14 ip:fd68:9b7f:6836:44cd:759:54f9:b233:bea2
2125	default	11:51:31.534780-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] Mdns: OnNewAddress interface: 14 ip:fe80::73c1:4795:62d:1960
2125	default	11:51:31.534832-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] Mdns: OnNewAddress interface: 14 ip:<IP_ADDRESS>
2125	default	11:51:31.534881-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] Mdns: Resolve success on interface 14
2125	default	11:51:31.534998-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] Discovered node:
2125	default	11:51:31.535034-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] 	Hostname: 001C42D47DC60000
2125	default	11:51:31.535068-0700	homed	🟢 [1675277491533] [2125:1567601] CHIP: [DIS] 	IP Address #1: fe80::73c1:4795:62d:1960
2125	default	11:51:31.535099-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	IP Address #2: fd68:9b7f:6836:44cd:759:54f9:b233:bea2
2125	default	11:51:31.535129-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	IP Address #3: <IP_ADDRESS>
2125	default	11:51:31.535154-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Port: 5540
2125	default	11:51:31.535182-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Mrp Interval idle: 5000 ms
2125	default	11:51:31.535212-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Mrp Interval active: 300 ms
2125	default	11:51:31.535240-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	TCP Supported: 1
2125	default	11:51:31.535264-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Device Name: Matter test device
2125	default	11:51:31.535320-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Vendor ID: 65521
2125	default	11:51:31.535351-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Product ID: 32768
2125	default	11:51:31.535379-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Device Type: 257
2125	default	11:51:31.535404-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Long Discriminator: 3840
2125	default	11:51:31.535429-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Pairing Hint: 33
2125	default	11:51:31.535459-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Instance Name: 0134585B616563B4
2125	default	11:51:31.535510-0700	homed	🟢 [1675277491534] [2125:1567601] CHIP: [DIS] 	Commissioning Mode: 1
2125	default	11:51:31.535538-0700	homed	🔵 [1675277491534] [2125:1567601] CHIP: [CTL] Discovered device to be commissioned over DNS-SD
2125	default	11:51:31.535564-0700	homed	🔵 [1675277491534] [2125:1567601] CHIP: [CTL] Attempting PASE connection to UDP:[fe80::73c1:4795:62d:1960%en0]:5540
2125	default	11:51:31.535691-0700	homed	🟢 [1675277491535] [2125:1567601] CHIP: [IN] SecureSession[0x98d449080]: Allocated Type:1 LSID:48664
2125	default	11:51:31.535717-0700	homed	🟢 [1675277491535] [2125:1567601] CHIP: [SC] Assigned local session key ID 48664
2125	default	11:51:31.535741-0700	homed	🟢 [1675277491535] [2125:1567601] CHIP: [SC] Including MRP parameters in PBKDF param request
2125	default	11:51:31.535765-0700	homed	🔵 [1675277491535] [2125:1567601] CHIP: [EM] <<< [E:12662i M:160534604] (U) Msg TX to 0:0000000000000000 [0000] --- Type 0000:20 (SecureChannel:PBKDFParamRequest)
2125	default	11:51:31.535881-0700	homed	🔵 [1675277491535] [2125:1567601] CHIP: [IN] (U) Sending msg 160534604 to IP address 'UDP:[fe80::73c1:4795:62d:1960%en0]:5540'
2125	default	11:51:31.536277-0700	homed	🟢 [1675277491536] [2125:1567601] CHIP: [SC] Sent PBKDF param request
2125	error	11:51:32.102776-0700	homed	Invalidating XPC connection.
2125	error	11:51:32.102916-0700	homed	Client: -[THClient connectToXPCService]_block_invoke - CTCS XPC Client is invalidated.
2125	default	11:51:34.702922-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:51:34.704682-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [150595]
2125	error	11:51:34.704714-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [150595]
2125	error	11:51:34.704737-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [150595]
2125	default	11:51:34.712948-0700	homed	WiFi scan starting
2125	default	11:51:35.524167-0700	homed	WiFi scan completed: 8 results, 0.817 seconds, 0/0x0 noErr
2125	default	11:51:35.524777-0700	homed	HAPWACBrowser: WiFi scan finish: 8 results, status 0/0x0 noErr
2125	default	11:51:35.525167-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0x57A7, BSSID 18:90:88:7A:82:86, SSID 'SantaCruz', IE 113 bytes, RSSI -59, 0x0 < >
2125	default	11:51:36.933713-0700	homed	🟢 [1675277496933] [2125:1567601] CHIP: [EM] Retransmitting MessageCounter:160534604 on exchange 12662i Send Cnt 1
2125	default	11:51:36.934688-0700	homed	🔵 [1675277496934] [2125:1567601] CHIP: [IN] (U) Sending msg 160534604 to IP address 'UDP:[fe80::73c1:4795:62d:1960%en0]:5540'
2125	default	11:51:38.414918-0700	homed	HAPWACBrowser: Suspend
2125	default	11:51:38.415961-0700	homed	HAPWACBrowser: Resume
2125	default	11:51:38.415986-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:51:38.417898-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [144011]
2125	error	11:51:38.417995-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [144011]
2125	error	11:51:38.418020-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [144011]
2125	default	11:51:38.418047-0700	homed	WiFi scan starting
2125	default	11:51:39.759871-0700	homed	Debounce generation counter update timer has fired
2125	default	11:51:41.504045-0700	homed	🟢 [1675277501500] [2125:1567552] CHIP: [EM] Retransmitting MessageCounter:160534604 on exchange 12662i Send Cnt 2
2125	default	11:51:41.505791-0700	homed	🔵 [1675277501501] [2125:1567552] CHIP: [IN] (U) Sending msg 160534604 to IP address 'UDP:[fe80::73c1:4795:62d:1960%en0]:5540'
2125	default	11:51:41.673839-0700	homed	WiFi scan completed: 14 results, 3.258 seconds, 0/0x0 noErr
2125	default	11:51:41.676213-0700	homed	HAPWACBrowser: WiFi scan finish: 14 results, status 0/0x0 noErr
2125	default	11:51:41.676243-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x3A22, BSSID 38:D5:47:BE:36:C9, SSID 'mordor', IE 99 bytes, RSSI -78, 0x0 < >, 0x3 < Attr IE >
2125	default	11:51:41.677319-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0x1B16, BSSID 18:90:88:79:FC:45, SSID '', IE 95 bytes, RSSI -67, 0x0 < >
2125	default	11:51:41.677370-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0xD70D, BSSID 18:90:88:7A:82:89, SSID '', IE 91 bytes, RSSI -60, 0x0 < >
2125	default	11:51:41.677392-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0xA267, BSSID 18:90:88:7A:82:8A, SSID '', IE 95 bytes, RSSI -79, 0x0 < >
2125	default	11:51:41.677424-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0xA075, BSSID 18:90:88:7A:82:83, SSID '', IE 95 bytes, RSSI -60, 0x0 < >
2125	default	11:51:41.677449-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0x654B, BSSID 54:83:3A:7C:EA:83, SSID 'CenturyLink5770', IE 182 bytes, RSSI -80, 0x0 < >
2125	default	11:51:45.261848-0700	homed	Debounce homes update timer has fired, posting homed did update notification
2125	default	11:51:45.275810-0700	homed	Home manager generation counter 334809 does not match client's (com.apple.springboard) value of 334808.
2125	default	11:51:45.276988-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.282869-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:45.296041-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.313719-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0378 s
2125	default	11:51:45.314026-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (A384DCFC-06B7-4531-B47B-BB6671B3743B) from client 'SpringBoard' that does expect a response
2125	default	11:51:45.316286-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:45.317498-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.364762-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:45.402461-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.457454-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.1404 s
2125	default	11:51:45.457636-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (2FED7A88-B138-4C71-9CA9-A22688EAD4B6) from client 'assistantd' that does expect a response
2125	default	11:51:45.458466-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:45.459038-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.512924-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:45.728311-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.844543-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.3861 s
2125	default	11:51:45.844798-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (545679A2-132B-40FE-88CC-7A87DD6E2090) from client 'Home' that does expect a response
2125	default	11:51:45.846189-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:45.846978-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.853436-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:45.866139-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.873111-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0269 s
2125	default	11:51:45.873226-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:45.873414-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (98BE64E2-8780-428E-B31C-5E1E49F21CBF) from client 'proximitycontrold' that does expect a response
2125	default	11:51:45.875092-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:45.877037-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:45.940797-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:46.162501-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.257538-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.3824 s
2125	default	11:51:46.257808-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (1ADF2E10-16F2-4E63-A3D3-54029F05120E) from client 'HomeUIService' that does expect a response
2125	default	11:51:46.258884-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:46.259696-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.286900-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.308706-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0497 s
2125	default	11:51:46.309226-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (3646FD78-CF4F-4096-B07D-09D62A711EF0) from client 'rapportd' that does expect a response
2125	default	11:51:46.314239-0700	homed	Home manager generation counter 334809 does not match client's (com.apple.springboard) value of 334808.
2125	default	11:51:46.314526-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.358805-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:46.563234-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.670855-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.3572 s
2125	default	11:51:46.671073-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (57AB317A-668C-4CFC-BE79-4C32D4D09D1B) from client 'SpringBoard' that does expect a response
2125	default	11:51:46.672323-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:46.674052-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.704606-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:46.720518-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.755460-0700	homed	HAPWACBrowser: WiFi scan start
2125	default	11:51:46.756743-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0842 s
2125	error	11:51:46.756786-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [145339]
2125	error	11:51:46.756820-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [145339]
2125	error	11:51:46.756880-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [145339]
2125	default	11:51:46.756906-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:46.756937-0700	homed	WiFi scan starting
2125	default	11:51:46.757055-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (D934BF5B-00F2-407B-B25C-49DBD4AB176D) from client 'rapportd' that does expect a response
2125	default	11:51:46.760971-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:46.761770-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.795531-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:46.839179-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.903069-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.1420 s
2125	default	11:51:46.903234-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:46.903477-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (F9F0F01E-2E1F-437B-A161-B314697153DE) from client 'mediasetupd' that does expect a response
2125	default	11:51:46.904887-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:46.905554-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:46.932147-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:46.971609-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.028366-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.1234 s
2125	default	11:51:47.028594-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (EC6007AC-417B-4B15-A73C-F21799633A94) from client 'announced' that does expect a response
2125	default	11:51:47.029721-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:47.029784-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:47.029812-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (FB7ECF04-1224-416B-9E56-87CB6DCD9D52) from client 'diagnosticextensionsd' that does expect a response
2125	default	11:51:47.030778-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:47.031675-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.060734-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.079243-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0483 s
2125	default	11:51:47.079313-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:47.079493-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (309DB488-D542-43BA-9393-11896F372E02) from client 'amsaccountsd' that does expect a response
2125	default	11:51:47.080471-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:47.081089-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.127109-0700	homed	[FDA80BF9-B2D0-4DF9-9784-01094CCFB686] Parsing documentation
2125	default	11:51:47.353703-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.459533-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.3790 s
2125	default	11:51:47.459842-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (5B04AFD1-8627-4F32-B550-06DF3D05697D) from client 'coordinated' that does expect a response
2125	default	11:51:47.461011-0700	homed	Home manager generation counter 334809 does not match client's (<private>) value of 334808.
2125	default	11:51:47.461740-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.496340-0700	homed	{"msg":"CLInternalGetAuthorizationStatus", "event":"activity"}
2125	default	11:51:47.518265-0700	homed	Number of homes - 2 / 2, Time to encode homes: 0.0563 s
2125	default	11:51:47.518346-0700	homed	Client has not requested access to HAP accessories (options <private>) - not sending metadata to [<private>]
2125	default	11:51:47.518377-0700	homed	Answering incoming message kFetchHomeConfigurationRequestKey (0042BB85-1319-45B1-B9AD-D477F1A88D07) from client 'rapportd' that does expect a response
2125	default	11:51:49.034939-0700	homed	🟢 [1675277509027] [2125:1567543] CHIP: [EM] Retransmitting MessageCounter:160534604 on exchange 12662i Send Cnt 3
2125	default	11:51:49.035420-0700	homed	🔵 [1675277509029] [2125:1567543] CHIP: [IN] (U) Sending msg 160534604 to IP address 'UDP:[fe80::73c1:4795:62d:1960%en0]:5540'
2125	default	11:51:49.972999-0700	homed	WiFi scan completed: 13 results, 3.212 seconds, 0/0x0 noErr
2125	default	11:51:49.973243-0700	homed	HAPWACBrowser: WiFi scan finish: 13 results, status 0/0x0 noErr
2125	default	11:51:49.974292-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x3A22, BSSID 38:D5:47:BE:36:C9, SSID 'mordor', IE 99 bytes, RSSI -78, 0x0 < >, 0x1 < Attr >
2125	default	11:51:49.974315-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0xF7AB, BSSID 38:D5:47:BE:36:C8, SSID 'shire', IE 99 bytes, RSSI -77, 0x0 < >, 0x3 < Attr IE >
2125	default	11:51:49.974411-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x7E2D, BSSID A4:11:62:78:7D:80, SSID 'ARLO_VMB_9559172149', IE 140 bytes, RSSI -53, 0x0 < >, 0x3 < Attr IE >
2125	default	11:51:56.217904-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:51:56.218018-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161115]
2125	error	11:51:56.218055-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161115]
2125	error	11:51:56.218086-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161115]
2125	default	11:51:56.218146-0700	homed	WiFi scan starting
2125	default	11:51:59.414952-0700	homed	WiFi scan completed: 17 results, 3.199 seconds, 0/0x0 noErr
2125	default	11:51:59.415601-0700	homed	HAPWACBrowser: WiFi scan finish: 17 results, status 0/0x0 noErr
2125	default	11:51:59.415770-0700	homed	HAPWACBrowser: WiFi scan found: CUWiFiDevice 0x9836, BSSID AA:CD:D6:19:AC:FA, SSID 'evergreen24', IE 275 bytes, RSSI -77, 0x0 < >
2125	default	11:51:59.416250-0700	homed	HAPWACBrowser: WiFi scan found: CUWiFiDevice 0x5E4A, BSSID 18:90:88:79:FC:43, SSID '', IE 95 bytes, RSSI -57, 0x0 < >
2125	default	11:51:59.416296-0700	homed	HAPWACBrowser: WiFi scan found: CUWiFiDevice 0x2205, BSSID 18:90:88:79:FC:49, SSID '', IE 91 bytes, RSSI -56, 0x0 < >
2125	default	11:51:59.416431-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x7E2D, BSSID A4:11:62:78:7D:80, SSID 'ARLO_VMB_9559172149', IE 206 bytes, RSSI -55, 0x0 < >, 0x3 < Attr IE >
2125	default	11:51:59.416491-0700	homed	HAPWACBrowser: WiFi scan found: CUWiFiDevice 0xA267, BSSID 18:90:88:79:FC:45, SSID '', IE 95 bytes, RSSI -62, 0x0 < >
2125	error	11:52:01.532326-0700	homed	🔴 [1675277521531] [2125:1567896] CHIP: [CTL] Discovery timed out
2125	default	11:52:01.532392-0700	homed	🟢 [1675277521532] [2125:1567896] CHIP: [CTL] Stopping commissioning discovery over DNS-SD
2125	error	11:52:01.532532-0700	homed	🔴 [1675277521532] [2125:1567896] CHIP: [DIS] Mdns: Browse failure (kDNSServiceErr_Timeout)
2125	default	11:52:01.983697-0700	homed	🟢 [1675277521983] [2125:1567896] CHIP: [EM] Retransmitting MessageCounter:160534604 on exchange 12662i Send Cnt 4
2125	default	11:52:01.984328-0700	homed	🔵 [1675277521984] [2125:1567896] CHIP: [IN] (U) Sending msg 160534604 to IP address 'UDP:[fe80::73c1:4795:62d:1960%en0]:5540'
2125	default	11:52:05.516807-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:52:05.519282-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161119]
2125	error	11:52:05.519306-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161119]
2125	error	11:52:05.519377-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161119]
2125	default	11:52:05.519401-0700	homed	WiFi scan starting
2125	default	11:52:08.728554-0700	homed	WiFi scan completed: 17 results, 3.212 seconds, 0/0x0 noErr
2125	default	11:52:08.729470-0700	homed	HAPWACBrowser: WiFi scan finish: 17 results, status 0/0x0 noErr
2125	default	11:52:08.729665-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0xF7AB, BSSID 38:D5:47:BE:36:C8, SSID 'shire', IE 99 bytes, RSSI -80, 0x0 < >, 0x3 < Attr IE >
2125	default	11:52:08.729818-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x6CA2, BSSID A4:11:62:6C:B1:F4, SSID 'ARLO_VMB_3370976785', IE 206 bytes, RSSI -76, 0x0 < >, 0x1 < Attr >
2125	default	11:52:08.729901-0700	homed	HAPWACBrowser: WiFi scan found: CUWiFiDevice 0x5331, BSSID 7A:CD:D6:19:AC:D6, SSID 'evergreen24', IE 275 bytes, RSSI -70, 0x0 < >
2125	default	11:52:08.730168-0700	homed	HAPWACBrowser: WiFi scan lost: CUWiFiDevice 0x12EF, BSSID 18:90:88:7A:82:84, SSID '', IE 95 bytes, RSSI -79, 0x0 < >
2125	default	11:52:14.967724-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:52:14.969151-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161123]
2125	error	11:52:14.969192-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161123]
2125	error	11:52:14.969225-0700	homed	__WiFiManagerClientAddDevice: for device [<private>] using server port [161123]
2125	default	11:52:14.969286-0700	homed	WiFi scan starting
2125	default	11:52:18.130578-0700	homed	WiFi scan completed: 15 results, 3.157 seconds, 0/0x0 noErr
2125	default	11:52:18.131098-0700	homed	HAPWACBrowser: WiFi scan finish: 15 results, status 0/0x0 noErr
2125	default	11:52:18.131123-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x3A22, BSSID 38:D5:47:BE:36:C9, SSID 'mordor', IE 99 bytes, RSSI -79, 0x0 < >, 0x3 < Attr IE >
2125	default	11:52:18.131148-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0xF7AB, BSSID 38:D5:47:BE:36:C8, SSID 'shire', IE 99 bytes, RSSI -79, 0x0 < >, 0x3 < Attr IE >
2125	default	11:52:18.131172-0700	homed	HAPWACBrowser: WiFi scan changed: CUWiFiDevice 0x6CA2, BSSID A4:11:62:6C:B1:F4, SSID 'ARLO_VMB_3370976785', IE 140 bytes, RSSI -77, 0x0 < >, 0x3 < Attr IE >
2125	error	11:52:21.538197-0700	homed	🔴 [1675277541537] [2125:1567601] CHIP: [SC] PASESession timed out while waiting for a response from the peer. Expected message type was 33
2125	default	11:52:21.538256-0700	homed	🟢 [1675277541538] [2125:1567601] CHIP: [IN] SecureSession[0x98d449080]: Released - Type:1 LSID:48664
2125	default	11:52:21.538326-0700	homed	DevicePairingDelegate status updated: 1
2125	default	11:52:21.538544-0700	homed	DevicePairingDelegate Pairing complete. Status ../../../../../../../../Sources/CHIPFramework/connectedhomeip/src/protocols/secure_channel/PASESession.cpp:245: CHIP Error 0x00000032: Timeout
2125	error	11:52:21.538773-0700	homed	[CHIPAccessoryServer[2084550771/3]] CHIP Accessory pairing failed before network provisioning: Error Domain=MTRErrorDomain Code=9 "Transaction timed out." UserInfo={NSLocalizedDescription=Transaction timed out., underlyingError=<private>}
2125	error	11:52:21.538841-0700	homed	[CHIPAccessoryServer[2084550771/3]] CHIP Accessory pairing failed: Error Domain=MTRErrorDomain Code=9 "Transaction timed out." UserInfo={NSLocalizedDescription=Transaction timed out., underlyingError=<private>}
2125	error	11:52:21.538899-0700	homed	[CHIPAccessoryServer[2084550771/3]] Cleaning up state due to pairing failure
2125	default	11:52:21.539200-0700	homed	🟢 [1675277541539] [2125:1567552] CHIP: [CSM] FindOrEstablishSession: PeerId = [1:000000007C3FB873]
2125	default	11:52:21.539267-0700	homed	🟢 [1675277541539] [2125:1567552] CHIP: [CSM] FindOrEstablishSession: No existing OperationalSessionSetup instance found
2125	default	11:52:21.539299-0700	homed	🟢 [1675277541539] [2125:1567552] CHIP: [CTL] OperationalSessionSetup[1:000000007C3FB873]: State change 1 --> 2
2125	default	11:52:21.539326-0700	homed	🔵 [1675277541539] [2125:1567552] CHIP: [DIS] Resolving 848CF47666E721ED:000000007C3FB873 ...
2125	default	11:52:21.539377-0700	homed	🟢 [1675277541539] [2125:1567552] CHIP: [DIS] Resolve type=_matter._tcp name=848CF47666E721ED-000000007C3FB873 interface=0
2125	default	11:52:21.540885-0700	homed	Answering incoming message kAddAccessoryRequestKey (076247E9-DD84-4EB0-A6F6-77AAE06AFDAB) from client 'HomeUIService' that does expect a response with error Error Domain=HMErrorDomain Code=18 "Pairing Failed" UserInfo={NSLocalizedDescription=Pairing Failed, NSUnderlyingError=0x98d3d31f0 {Error Domain=HAPErrorDomain Code=15 "(null)"}}
2125	error	11:52:21.543358-0700	homed	Failed to remove keychain entry for accessory <HMDUnpairedHAPAccessory> - error Error Domain=HMErrorDomain Code=18 "Pairing Failed" UserInfo={NSLocalizedDescription=Pairing Failed, NSUnderlyingError=0x98d3d31f0 {Error Domain=HAPErrorDomain Code=15}}
2125	default	11:52:21.741266-0700	homed	🔵 [1675277541741] [2125:1567896] CHIP: [DIS] Checking node lookup status after 202 ms
2125	default	11:52:24.326916-0700	homed	HAPWACBrowser: WiFi scan start
2125	error	11:52:24.326956-0700	homed	🔴 [1675277544326] [2125:1567896] CHIP: [EM] Failed to Send CHIP MessageCounter:160534604 on exchange 12662i sendCount: 4 max retries: 4

I can check the log tomorrow, but I can say that iOS Home and iMatter works for me (ok iMatter can only pair and you see nothing afterwards ... very strange ... but ok)

Ok, had a look, so in general first looks ok then the discovery seems to fail .. would be cool to get two logs of such a pairing ... node-matter AND the ios log from the same try ... then maybe we could see something.

I have established that there is no logging on node-matter, apart from the manual pairing code, when attempting commissioning via any of my iOS devices. Confirmed observations indicate that iMatter, running on OSX, initiates the initial MessageExchange, which does not occur on iOS devices. Multiple attempts were made using different iOS devices for this Home, however, none resulted in any further node-matter logging beyond the manual pairing code
I believe this to be 100% on the iOS side and while it's helpful for you to help troubleshoot; I can close this as it's obviously an iOS issue on my Home.  I'll update here with any findings.

Hi vvess,
When there is some issue before establishing the connection, Wireshark is really helpful since MDNS messages are not encrypted, so it is easy to figure out what is wrong if it is an MDNS issue.
From the log you sent, I see that it scans over MDNS for _matterc._udp,_L3840 (Matter device in commission mode with discriminator 3840) and it is resolved to:
IP Address #1: fe80::73c1:4795:62d:1960
IP Address #2: fd68:9b7f:6836:44cd:759:54f9:b233:bea2
IP Address #3: <IP_ADDRESS>
(somehow two IPv6 addresses).
It tries to pair with fe80::73c1:4795:62d:1960%en0 but noone seems to reply to this message.
Questions:

Is fe80::73c1:4795:62d:1960 the right IPv6 address for the device running node-matter?
Does this device receive this message? (you should see it in Wireshark running on that device if it is received)
Is node-matter listening correctly? (try to manually send an UDP packet to the port 5540 over IPv4 than IPv6. Even a bogus packet should produce a log)

Thanks!

Marco

It is the correct IPv6 address: fe80::73c1:4795:62d:1960%en0 except for the %en0 adapter identifier.
The virtual device does receive the message from an OSX client, but not from iOS.
node-matter is correctly listening.  I am looking for a method to test from iOS (terminal, or write a quick app)

At this point - we have identified that node-matter is operating properly and it's an issue with my iOS device as @Apollon77 has confirmed that the master branch functions with his iOS Home App.  @mfucci and @Apollon77 if you agree, I'll close this issue and work on sorting out the issue on my side.

It is the correct IPv6 address: fe80::73c1:4795:62d:1960%en0 except for the %en0 adapter identifier.

do you have an en0 network interface on that machine which is "correct to use"? The IPv6 adressing works that way.
In fact also I test on a mac with a Homepod and iPhone and all works ...
Good luck to sort that topic out!


Add support for URL-encoded form parameters

These kinds of form parameters are typically found in the body of POST requests when a form is submitted on a website. Don't know if this would be useful to add or not.
Examples:
client.onPost("/login")
  .withFormParameter("username", "John")
  .withFormParameter("password", Matchers.any(String.class))
.doReturnStatus(200);

Map<String, Matcher<String>> parameters = new HashMap<>();
parameters.put("username", Matchers.equalTo("John"));
parameters.put("password", Matchers.any(String.class));
client.onPost("/login")
  .withBody(parameters)
.doReturnStatus(200);

client.onGet("/foo").doReturnFormParams(Arrays.asList(
  new BasicNameValuePair("one", "1"),
  new BasicNameValuePair("one", "2")
));

First of all thanks for the contribution. After the first review, your changes look good to me. Please give me some time to have a deeper look.

Of course, let me know if you have any questions. Thanks for looking at it.
Sorry that the commit of my previous pull request was included in this pull request. I'm not too familiar with how pull requests work!

Sure thing!


Make _focusDebug not interpolate in debug mode

Description
Because it was calling toString/toStringDeep on objects being interpolated into the string even when debugFocusChanges was false, this changes the _focusDebug calls in focus_manager.dart so that instead of being called like so:
assert(_focusDebug('Blah $foo'));

They are now called like this, so that the string interpolation won't happen if debugFocusChanges is false:
assert((debugFocusChanges && _focusDebug('Blah $foo')) || true);

It was also suggested, and I considered, that the _focusDebug function could take an iterable of Objects instead, and we could do the stringification inside of the function, but 1) I'm not sure it's less ugly, and 2) it's prone to people still accidentally doing interpolation in the arguments, and 3) it doesn't avoid the function call.
This is what that might look like:
assert(_focusDebug(<Object>['Blah ', foo]);

Ok, it looks simpler in this example, but gets worse the more things you need to interpolate and interleave with text. But I could be convinced that it was less ugly.
Tests

Added a test that throws when toStringDeep is called on a FocusNode.

What if _focusDebug would take a callback:
assert(_focusDebug(() => 'Blah $foo'));

It's shorter than the debugFocusChanges && approach and probably less error-prone since you don't have to remember the debugFocusChanges && part. Unlike the iterable suggestion, it also also keeps the strings readable.

What if _focusDebug would take a callback

Ooh!  I like that.  I'll give it a try and see if it works.

(we should also consider whether these log lines are still sufficiently useful to be kept at all)

I use them all the time for focus debugging, and many times users have told me that they are grateful that debugFocusChanges exists: I've even had an issue filed requesting that it be added to the IDE interface. To me, at least, they're clearly useful.


Every build rebuilds all dependencies

The container is building everything out of /tmp/ in the container which means it's rebuilding all of the dependencies with every build.
Rebuilding something like apple\swift-crypto takes a good 5 minutes when the prebuilt objects are sitting in .build/.
This includes test builds.

This appears to happen with build --configuration but not when swift build is ran with defaults.
I was incorrect about test builds, objects are reused following successful builds.


Fantasy and Cursive fonts not included in fonts.enableDefaultPackages

Describe the bug
fonts.enableDefaultPackages does not include Fantasy fonts or Cursive Fonts for the web even if fontconfig have them defined.
This means that if a website use the css arguments font-family: fantasy; or font-family: cursive; without importing a font, they will fallback to Sans-serif.
Steps To Reproduce
Steps to reproduce the behavior:

Use fonts.enableDefaultPackages = true; on a system without any custom fonts
Use fc-match fantasy or fc-match cursive to see what font is used
2.bis Visit this codepen or whatever website website using these font-family
Install any of the fonts used by fontconfig or install nur.repos.mikilio.ttf-ms-fonts from the NUR

Expected behavior
fonts.enableDefaultPackages should install any of aliases fonts defined by fontconfig. For fantasy, those are Bauhaus Std, Cooper Std, Copperlate Gothic Std, Impact. For cursive, those are Comic Sans MS, Zapf Chancery Std, Zapfino.
OR
change the fontconfig aliases for the fantasy and cursive faces with custom added fonts
Screenshots
codepen without the fonts

codepen with the ms-fonts

Additional context
I found the fonts asked by fontconfig at /usr/share/fontconfig/conf.avail/45-latin.conf in the current nixos derivation
Notify maintainers

@SuperSandro2000 @nbraud
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.23, NixOS, 24.05 (Uakari), 24.05pre604424.d8fe5e6c92d0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"home-manager, nixos, nixos-hardware, nixos-unstable, nixpkgs-unstable"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Are those Microsoft contacts unfree like corefonts?


possible to use easy-rules to develop python interpreter on Android which can run python package like requests,selenium and so on, on android too

Has all of the Java necessary been ported to Python? The Qpython 3L Project seems to be the main implementor. Pydroid knows nothing of it. Let me help you finish this.


num.tryParse and num.parse throws error when String contains comma

Unfortunately customers using comma instead of dots sometimes and I have to check if string contains comma then change them into dots, because of this i have this function
String replaceCommaWithPoint(String original){
  return original.replaceAll(",", ".");
}

There is a tryParse code
static num tryParse(String input) {
    String source = input.trim();
    // TODO(lrn): Optimize to detect format and result type in one check.
    return int.tryParse(source) ?? double.tryParse(source);
  }

What if we add to replace all method to change all ',' to '.'
static num tryParse(String input) {
    String source = input.trim()..replaceAll(',','.');
    // TODO(lrn): Optimize to detect format and result type in one check.
    return int.tryParse(source) ?? double.tryParse(source);
  }

Replacing , with . only works for inputs which use , as decimal point. An input like 100,000.00, a traditional US notation, would not be saved by that, and an input like 100,000 would be off by a factor of 1000. It's probably better to have a hard failure than to "succeed" with a wrong answer.
We do not intend double.parse or num.parse to be general number parsing functions. They are ways to parse the result of double.toString() or int.toString() into the same number again, not any arbitrary input format. For more configurable number format parsing, you should use either package:intl or custom parsers for the formats that you choose to accept as input.
Adding an extra step to tryParse will affect performance of a function which is used in some performance sensitive settings. I would prefer to not add overhead there which every user has to pay for, even if only a minority gets any advantage from it.


Didn't work on jQuery 3.1

Its didnt working on jQuery 3.1. But work good on jQuery 2.4

Thanks for reporting.
jQuery 3.1 support would be the milestone.
Please use jQuery version 1.11.0+ or 2 instead at the moment..

Hi @turtle-bi ,
The new release 1.1.1 supports jQuery 3, you can try it!
Cheers.


directory() method when chaining on SpatieMediaLibraryFileUpload does not work

Package
filament/filament
Package Version
v2
Laravel Version
v9
Livewire Version
No response
PHP Version
PHP 8.1
Problem description
According to the docs, you should be able to do something like this, to upload to a subdir within a bucket of S3.
SpatieMediaLibraryFileUpload::make('image')
      ->disk('s3')
      ->directory('images')

Instead, it adds the record to the media table, uploads to the S3 bucket but ignores the directory method. Even if you manually create the directory in the bucket, it still ignores it and uploads in the numeric folder fashion e.g. 24/, 25/, /26 etc. (matching the id)
In the same way using FileUpload, this method works and uploads to the correct subdir:
FileUpload::make('image')
      ->disk('s3')
      ->directory('images')

This seems to be an ongoing issue that has been present since last year.
See: https://stackoverflow.com/questions/73753284/directory-method-of-filament-doesnt-work
Expected behavior
To upload files to an S3 bucket within a sub directory using SpatieMediaLibraryFileUpload, much like the FileUpload component already does.
Steps to reproduce
Set up an S3 bucket with your credentials and try this form component:
SpatieMediaLibraryFileUpload::make('image')
      ->disk('s3')
      ->directory('images')

Reproduction repository
https://github.com/joshembling/filament-image-bug
Relevant log output
No response

This is not a problem with Filament, Spatie does not natively support changing the directory of the image. You must create a custom PathGenerator https://spatie.be/docs/laravel-medialibrary/v10/advanced-usage/using-a-custom-directory-structure


Fix exception causes in handshake.py

That should be the rest of them :)

I prefer to have this PR merged first, and then later I'll rebase the other
PR and fix the issues with it. What do you think?
On Sun, Jun 14, 2020 at 10:31 AM Aymeric Augustin<EMAIL_ADDRESS>wrote:

@aaugustin approved this pull request.
Thanks. I'm OK with these changes. I'm keeping them on hold for now as you
have another PR touching the same code. If the other PR is merged, it will
supersede this one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aaugustin/websockets/pull/778#pullrequestreview-430194874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAN3STCB3AZY5PGT6TNNV3RWR4DHANCNFSM4N5D5BKQ
.

Yes. This one also conflict with the gigantic refactor in #676. Can we wait a few days to see if the dust settles over there? If I get stuck again, I'll merge this one in a week. I'm sorry for the inconvenience, but every hour wasted rebasing #676 on top of conflicting changes in master is an hour not spent completing it :-/

Yup, that makes sense. I might push another commit on my other PR, but feel free to ignore it until #676 is finished.

Now we can move forwards with this :-)
handshake.py was renamed to handshake_legacy.py since we last talked.
I made a reasonable effort not to introduce new instances of this problem, but that may be worth checking (especially if you found a way to automate this check!)

LOL, as if my change wasn't esoteric enough, now the entire module. "Anyone who has traveled this far on a fool's errand has no choice but to uphold the honor of fools by completing the errand."

@aaugustin Want to review this?

@aaugustin Nudge

Thanks and sorry for the delay! (on holidays)