RenameKeywords adds no space to replace underscore next to variable

When underscore removing is on, underscore next to variable is removed without adding space.
Embedded ${variable}_And_Remove_Underscores
becomes
Embedded ${variable}And Remove Underscores
Fixed in custom transformer by getting the padding character from function per input char and underscore setting, so that underscore triggers padding only when it is being removed.
To reduce complexity, function works on a char instead of the original string.endswith/startswith(). On the other hand this required more checks before the index operations to prevent out-of-range exceptions.
Custom transformer skips quoted text instead of robot variables and leaves leading underscores in keyword names, so not usable as a fix as is.
def padding(self, char):
    return " " if char == " " or (char == "_" and self.remove_underscores) else ""

Thanks for the report, I will take a look into it.

Fixed - it will be released in 4.4.0 today.


Adjustable Line Spacing

Changes
Describe the Pull Request here. Add any references and info to help reviewers understand your changes.

Added ability for users to adjust line spacing

Tests applied
What testing has been applied to validate changes are accurate and correct

Manual testing

Issue ticket number(s)
Enter the issue numbers resolved by this pull request

Resolves #25

Checklist

[x] Documented
[x] Linting tests successful
[x] merge updated prod branch into development branch

Seems like formatting for the App.tsx file is not being applied. Make sure Prettier is set up in your code editor and formatting on save works for that, since your git hooks might not be working correctly. Otherwise, run pnpm run format before creating the PR.


Create LICENSE

Description
MIT License added
Motivation and context
closes #7
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes. (N/A)
[x] If my change requires a change to the documentation, I have updated it accordingly.

Hi @skywalkerluc, this PR is related to the Issue #7, could you please assign that issue to yourself? 👍

Hi @camigomez35, I've never assigned an issue to myself before, but after researching I noticed I've got be considered a contributor or owner to do it. Can you help me?

Sure, please add a comment asking to be assign to that issue.

Oh, ok. Done!

Thanks @skywalkerluc!!


Credit where credit is due!

I've run into gmail.js used in other projects with varying methods of credit. This makes it difficult keep up to date as well!
ps: great library @KartikTalwar :)

Thanks @yoiang!


invalid checksum when using irmin-pack

I have a small test of irmin using the git backend, which works perfectly on its own. I wanted to experiment with irmin-pack and added it as a dependency, and found that the original git backend example started to fail with an invalid checksum error.
let make ~token ~url =
  let open Lwt_result.Syntax in
  let* repo = Store.Repo.v config |> Lwt_result.ok in
  let* store = Store.main repo |> Lwt_result.ok in
  let headers =
    let e = Cohttp.Header.of_list [] in
    Cohttp.Header.add_authorization e (`Basic ("oauth2", token))
  in
  let* remote = Store.remote ~headers url |> Lwt_result.ok in
  let+ _status =
    Lwt_result.ok
    @@
    Sync.pull_exn store remote `Set
    |> Lwt_result.map_error (fun e -> Fmt.to_to_string Sync.pp_pull_error e)

Fatal error: exception Invalid_argument("Sync.pull_exn: object <0000000e>: Invalid checksum (expect:2ed549da, has:0000)")
Raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3123, characters 20-29
Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 27, characters 10-20
Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 106, characters 8-13
Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 112, characters 4-13
Called from Dune__exe__Main.sync_repo in file "server/main.ml", line 76, characters 2-20```

Thanks for the report. Is the setup that you have an irmin-git remote store that you are trying to sync to an irmin-pack local store? I tried to modify the existing sync example to have this sort of setup but get the following:
# dune exec examples/irmin-pack/git_sync.exe
Fatal error: exception Invalid_argument("Sync.pull_exn: fetch operation is not available")
Raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3077, characters 20-29
Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 31, characters 10-20
Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 118, characters 8-13
Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 124, characters 4-13
Called from Dune__exe__Git_sync in file "examples/irmin-pack/git_sync.ml", line 82, characters 9-31

You can see my hacked together example in this gist: https://gist.github.com/metanivek/2e59fe6971d5ce2ab1d42fc9eaf23ca7
Could you share a full example that compiles and fails? That would make it easier to see what is happening.
Off the top of my head, I'm not sure this sort of cross backend syncing will work (and as the above output indicates, irmin-pack does not currently implement remote syncing -- see this line), but I'm happy to look more into this for you.


[SPARK-34783][K8S] Support remote template files

What changes were proposed in this pull request?
This PR aims to support remote driver/executor template files.
Why are the changes needed?
Currently, KubernetesUtils.loadPodFromTemplate supports only local files.
With this PR, we can do the following.
bin/spark-submit \
...
-c spark.kubernetes.driver.podTemplateFile=s3a://dongjoon/driver.yml \
-c spark.kubernetes.executor.podTemplateFile=s3a://dongjoon/executor.yml \
...

Does this PR introduce any user-facing change?
Yes, this is an improvement.
How was this patch tested?
Pass the CIs with the newly added test cases.

Hi, @attilapiros . Could you review this PR?

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136194/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40776/

@HyukjinKwon , @attilapiros , @viirya .
I tried to use DependencyUtils, but it turns out that it fails at the execution because Utils.doFetchFile depends on SparkEnv.get. SparkSubmit use this K8s submission code before SparkEnv creation.
In this case, I believe this vanilla approach is the only way.

For the test case concern, I can still remove it but I prefer to have the test coverage for the new function for now. We can revise the test suite later with the withHttpServer refactoring.

+1 for keeping the test and I will revise it in my PR

Thank you, @attilapiros .
I'm still looking at the code to find some workaround.
I'll comment on this PR later if I found a better solution.

Sounds ok to me.

Hi, All.
At the last commit, I was able to address all comments (@HyukjinKwon and @attilapiros ). The failure I was hit at the first trial was a false alarm. Since K8s submit will not use spark: prefix, SparkEnv code patch is not used. And, I manually tested this.

Also, the doc update is included. Thanks, @viirya .

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136226/

Thank you for suggestion, @HyukjinKwon . I manually verified that the code works correctly and merged it.

Thank you for review and approval, @HyukjinKwon and @attilapiros .

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136229/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40811/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40811/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40811/

Thank you, @viirya !

The failure is irrelevant one. Merged to master.


⚠ Bofrost.be has degraded performance

In 8374b94, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2821 ms

Resolved: Bofrost.be performance has improved in 10a78a7.


is keyword exists in Custom Elements spec as valid attribute.

Version: 5.3.0
Environment: Both
Type: Bug / General
Hi!
The is keyword is part of the W3C Draft spec for creating custom HTML elements with custom behavior. For example http://w3c.github.io/webcomponents/spec/custom/#type-extension-example
Should we rename it in 6.0?
Thank you!

Go for it! “as” should be fine :)


Add github_branch_protection

Q
A

🐛 Bug fix?
no

🚀 New feature?
yes

⚠ Deprecations?
no

❌ BC Break
no

🔗 Related issues
#249

❓ Documentation
yes

Description
⚠ To be able to alert when use user github_branch_protection_v3, we should create a resource, a deserializer and a finally a middleware to check if there is any github_branch_protection_v3 resource in state just to send an alert and remove theses resources. Do we really want to do that ? Maybe a line in LIMITATIONS.md may be enough.
⚠ It seems that the terraform provider is not returning the repository_id, so I've ignored it from the diff
Attentive review required please @moadibfr @wbeuil

warning To be able to alert when use user github_branch_protection_v3, we should create a resource, a deserializer and a finally a middleware to check if there is any github_branch_protection_v3 resource in state just to send an alert and remove theses resources. Do we really want to do that ? Maybe a line in LIMITATIONS.md may be enough.

Maybe we could add a warning when we find unmanaged repository only ? Saying that this might be a false positive as we don't support v3 ?

Maybe we could add a warning when we find unmanaged repository only ? Saying that this might be a false positive as we don't support v3 ?

We cannot make the difference between a false positive drift and a real drift with this approach.
For me we the only way to handle this is to read v3 res from the state and try to match them to non-v3 unmanaged one and ignore them with a warning. So we'll end up with a v3 resource and deserializer without any supplier related.
WDYT @moadibfr @wbeuil ? Is it worth it ? I can totally do this in a couple of hours.

I'm not sure it's worth your time to do it. Are we sure that we can create a non-v3 resource with a v3 resource ? Can't we just warn the user if we find a v3 resource in its state ?


Active callback for selected preview device?

I don't know if it already exists or has been requested previously, but it would be nice if we can show/hide controls based on the selected customizer preview device.

Maybe using the following syntax:
'active_callback' => array(
    array(
        'setting' => 'preview_device',
        'operator' => '==',
        'value' => 'desktop', // 'desktop', 'tablet' or 'mobile'
    ),
),

I think it would be useful if we want to have a different spacing fields for each screen.

Already planned after 4.0 :+1:

Perfect! Can't wait to see that implemented.


Problem with Discover table

Hi,
I'm trying to use Saltcorn with an existing database.
I select tables using "Discover tables" function. With some tables, it work fine; but with others, I get the following error:
TypeError: Cannot read property 'fields' of undefined
at /usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/models/discovery.js:161:32
at Array.forEach ()
at /usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/models/discovery.js:156:14
at Array.forEach ()
at discover_tables (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/data/models/discovery.js:155:14)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async /usr/local/lib/node_modules/@saltcorn/cli/node_modules/@saltcorn/server/routes/tables.js:244:18
Table names does'nt contain any special characters, and fields type are quite simple (integer, var char).
Does anyone have an idea ?

Looking into code, I found an explanation : it's in saltcorn/packages/saltcorn-data/models/discovery.js, in discover_tables function.
When importing tables with Discovery command, if a table has a foreign key pointing to another table, function will try to find that table in the list of tables (tableNames) being imported. That causes error if not found.
In my case, table was already imported.


[fix] Fix ingress annotation nil error

Changes

Fix ingress's annotation nil error
Submitter Checklist

[ ] Docs included if needed
[x] Tests included if needed
[x] Follows the good commit messages standard

/test

/test

/test


bump nixpkgs

I needed to bump nixpkgs as a prerequisite of #99.
However, updating the input introduced some regressions, so I decided to bump and fix on a separate PR.

@alejandrosame check failing.

CI fails with Error: Resource not accessible by integration, which seems like a CI introduced error.
Googling around, it looks like a permissions problem, but I'm unable to debug this @lorenzleutgeb @mightyiam .

I just noticed, could this error be triggered because the PR is coming from a fork?

It seems like you are running into this. Possible workaround at #134.

Superseded by #135


drop file.location

Drops File.location field after https://github.com/iterative/datachain/pull/446. See https://github.com/iterative/datachain/pull/446/files#r1780264304.

Looks like this would require someone to take over and do the studio part

Closing this per #446.


Any demo

Hi,
That is a coooool thing, i wonder any demo url will improve its PR
Thanks for doing this thing, keep going~

Thanks for the kind words @eclipse-du. Yes - a landing page + demo would be quite beneficial. Feel free to join our discord if you're interested in chatting more - https://discord.gg/mGy29Smv4g


Implement order history for XS screens

PURCHASE-1997
A continuation of a hackathon project, this ticket makes visual improvements to the order history page for XS screens
Before:

After:

A few suggestions/notes, but nothing I feel strongly about changing. Feel free to merge when you're happy w/ it. 👍


Token expiry issue 1hr after the process starts

Our platform contains 2 business groups, 100+ APIs, 100+ exchange assets. It usually takes 20 mins to complete the entire process. At times, platform APIs performance goes down and it takes more time than usual to respond. To avoid timeouts, I have increased the timeouts, decreased the concurrency, added until-successful on HTTP requests. But due to the increased timeouts, the whole process execution spills beyond 1 hour.
Token fetched initially seems valid for 1 hour and any calls that happens beyond 1hr ends up with Unauthorized issue.
Can this be handled? Please.

Hi @siddhu268  !
Thanks for collaborating on opening this issue. Two things I think you can do to manage this scenario:

Configuration: Setting the session timeout in Anypoint Platform. Default is 60 minutes and the maximum is 180 minutes. Take into account this change is a global change and may impact session spanning for other users as well (Please refer to https://docs.mulesoft.com/access-management/organization#manage-master-organization-settings for further details)
Implementation: you can obtain a new token when you get a 401 by catching the exception and placing a flow ref to 'api-call-coreservices-login-flow'
Hope this helps!

Best,
GP

Hi @panizzag,
Thanks for the suggestion. I had already raised for approvals for changes with the first approach.
My intention in raising the issue was that if the second approach is implemented, it would be helpful for the global audience using this accelerator.
Thanks Again for putting this together
-Siddardha Sarabu


fix: update the workaround used for intermittent timing issue seen wr…

…t auth policy creation
Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 2.8.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Encoding

This explains how I think encodings/compression should work in ASDF.
@perrygreenfield, @embray: Comments encouraged.

I have mixed feelings about this and need to give it some more thought.
On the one hand, I understand the intention behind grouping encoding information with the binary blocks in a separate YAML section.  This makes sense when breaking the blocks out in "exploded" form.  On the other hand, I think we need to be clear about when this sort of encoding should or should not be used.  I think it should be used only for things like binary compression that affects what bytes are read out of the block.  I'm less comfortable with using this for encodings that are dependent on how those bytes or interpreted in the first place.  For example some of the array-binary encodings, like the quantization encoding.  This requires that any array read out of this block is interpreted as floats of some kind or another (and since the encoding scheme requires specifying 32- or 64-bit floats that means the dtype has to be specified twice; it also means that assigning an array of any other dtype to this data block is meaningless).  Worse still is the case where the data is scaled; something I think would be of interest to have in the primary tree.
So now we have a situation where the description of the bytes themselves, and the semantic interpretation of those bytes, is stored in separate places.  Of course, these are different levels of "semantic" interpretations too.  So maybe it's okay.  But where do we draw that line?

Sorry -- I merged this by accident -- I think @embray's feedback is worth considering first.  I'm going to reset master...

So, in case it's not clear, my implicit goal is to support the kinds of things that are possible to do in FITS (with the non-standard convention in cfitsio for compression), but to do it in a way that's more extensible.  One of the things it does is it quantizes tiles of an image independently (each with their own scale and offset) on the assumption that the deviation within a tile will be smaller than across the whole image.
So, I share your concern about duplicating information about the array in both the tree and the block.  In some sense, we already have this problem, since if the datatype specified in the tree isn't appropriate for the bytes in the block things will not work.  It may be "safer" in some sense to store the datatype in the block and have the tree use offsets and strides in multiples of that datatype rather than bytes as it does now.
However, for encodings, I'm not sure storing the decompression information with each view in the tree will work.  Say, for example, one is doing the lossy tile quantization from FITS, and there are multiple subviews on a large array.  If the compression information is stored in the tree, then you have to be able to decompress it from the information stored in each view alone, and each view would have to be independently decompressable without decompressing the whole.  That's a much more complex problem to solve.
I agree the need for both "array-aware" encodings and "byte stream" encodings is kind of messy.  It's, of course, impossible to do any sort of useful lossy compression without knowing the shape and datatype of the array and being able to slice it into tiles etc. so now we have the block being aware of such details where before it was just a "bag of bits".  And that's not great.

I'm worried that we may be trying to solve too many problems at the beginning. Perhaps we should narrow the goals initially (e.g., not deal with views of compressed arrays in any efficient way, particularly if we don't wall off more complex solutions in the future). Looking it at it this way, is one or the other approach exclusive of the other? If we choose one, do we necessarily prevent an option to use the other?
Offhand, it seems that a library that must deal with only decompressing needed tiles for a view (or a requested slice) is going to be fairly complex, and I'd like to avoid dealing with that now. Can we start assuming compressed arrays will be completely decompressed before views are used, if that doesn't preclude support for more sophisticated access in the future?

My initial implementation just had a single field describing the kind of compression used on the block.  That works fine for things like lossless zlib compression, and is dead simple.  But it does preclude the sort of "stacking" of compression algorithms that the CFITSIO convention for FITS supports -- and my goal was to make sure that could be described.  So you do, at a minimum, need a way of stacking the algorithms.  It seemed at first that a fixed-length field would be enough to list the algorithms used (as they will always be small in number), but then you realize that most lossy compression algorithms will need some kinds of additional information to decompress.  That's how I ended up with the little YAML headerlet to the block, because that is the only way I can see to be open-ended and general.  In fairness, that could also be in binary form in the block header somehow, but given that it's of arbitrary length with values that would be different depending on the algorithm, YAML makes some sense.

Can we start assuming compressed arrays will be completely decompressed before views are used, if that doesn't preclude support for more sophisticated access in the future?

That's indeed what this does -- by storing the information about tile compression with the block and not with each view in the tree, it means you have to decompress the whole block to access the view.  I think while that may not be "the best one could do", it's reasonable and much easier to implement etc.  The point I was making was that if you move the information about the compression into the tree and stored with each view (rather than the block) to address @embray's concern about information about the array datatype being stored in two places, you are basically forced to also implement compression algorithms that can work on partial data (you'd probably end up doing something like "keyframes" in video data where you would rewind to the nearest marker of some kind and then start from there), all of which is a much harder problem to solve.  Or you just end up duplicating the information about the compression verbatim in every view, which is more of a duplication problem in my view than this PR as it now stands.
The only other way I can think of to address @embray's concern is to change how views work.  Currently, all views point directly to a block.  If views instead pointed to other views in the tree, then the one "master" view of everything would point to the block and it could store information about compression.  That's closer to how Numpy array views work so it has some precedence as a reasonable approach.

Actually, now that I think of it, I think I have a way to get rid of the array-specific information in the block header, which I this addresses most of @embray's concerns.  There's no way to get around that in the implementation of a writer, but I think there's a way to keep it out of the spec.  Stay tuned...

The only other way I can think of to address @embray's concern is to change how views work. Currently, all views point directly to a block. If views instead pointed to other views in the tree, then the one "master" view of everything would point to the block and it could store information about compression. That's closer to how Numpy array views work so it has some precedence as a reasonable approach.

That’s what I was wondering. If done that way, the view doesn’t have to duplicate the information as it is already layered on top of the one portal to the information (if I understand correctly). But I’ll wait to see what you are going to propose.

So, I've gone down a few rabbit holes on this and ended up back at the beginning :(
In attempt (A) I tried to change ASDF so that views (subarrays) are references to other arrays in the tree, where the bottom array of the stack then points directly to a block.  This bottom array would then become the place where any encoding or compression is described.  This turns out to really complicate things.  What if the view is included in the tree, but its base is not?  What if (and this really happens), the views immediate base isn't in the tree, but it's secondary base is?  (In the following diagrams, views that the user put in the tree have an asterisk):
A* -> B -> data_block
A* -> B -> C* -> data_block

You have to then start implicitly inserting arrays into the tree just so that they can refer to a block.  Which then gets one in mind of having a special list in the tree just to describe each block.  And once you've done that, you might as well do what's done here which is to just put that description with each block.  :)
The problem with this approach is compounded by the fact that reconstituting Numpy views from disk is very difficult.  While you can create a view on the underlying data buffer quite easily (using the ndarray constructor), you can't create a view while declaring another view as its direct base.  You can do it by converting the strides back into slice indices and then taking a slice of the base, but this only works if the dtype of the view is the same as its base, so it doesn't work for tables, and in general is more limited than what current ASDF can do.
In attempt (B), I tried to take the knowledge of arrays out of the encodings.  I'm not sure how one can implement things like tile-rearranging without knowing something about the shape.  I tried to be general where possible, i.e. tiling requires knowledge of the datatype itemsize, but not the actual datatype.  But quantizing does require knowing the underlying floating point type.  I don't really see a way around that.
So, I'm sort of back where I started, but I'm (a) open to other ideas and (b) more convinced that this approach may be the right one.

I assume you mean in the example views defined in Python, but where someone is only specifically asking for the views A (in the first case), and A and C (in the second case) to be in the ASDF file. My assumption is that yes, implicitly you have to get all the intermediate ones in the file too. The first case would be a bit odd for a file I would think, in that someone wants a view of a larger buffer, but isn't interested in the whole buffer, but still wants it in the file. I don't understand why that would be desired (but I may be completely misunderstanding your comment). For the second, if someone had defined it that way in Python and somehow didn't want B in the file, I would expect the onus is on them to redefine A so that it doesn't depend on B. So is the issue here how transparent it should be to go from Python to ASDF, or the issue of organizing ASDF trees themselves?
As for reconstituting a  view from another view that is the base of an array, does that correspond to the above examples (or is that something like A*->B*->C -> data_block)? In other words, I implicitly have assumed that any data buffer better have a base object that is general enough for all views (even if that requires it to be a byte array). Again, I may be (and almost certainly am) completely confused :-)

I assume you mean in the example views defined in Python, but where someone is only specifically asking for the views A (in the first case), and A and C (in the second case) to be in the ASDF file.

That's correct.

My assumption is that yes, implicitly you have to get all the intermediate ones in the file too.

That seems like a big ask of users, since Numpy views can be created in so many ways -- often you aren't even aware you have a view.  The library could find all the views that aren't explicitly included in the tree and add them to a special place in the tree just for these "anonymous" views, or somehow skip over them by redefining them.  In either case, it provides a lot of implementation complexity and bookkeeping that isn't there now.

The first case would be a bit odd for a file I would think, in that someone wants a view of a larger buffer, but isn't interested in the whole buffer, but still wants it in the file.

This is useful if the larger buffer exists in another file, i.e. in "exploded" form.  Another example might be a number of subarrays pointing to different parts of a larger buffer, totally the whole, but not having an array pointing to the complete buffer.  That's useful if you have a data cube that you want to represent as an array of 2d planes (something one of the jwst_lib.models does).

So is the issue here how transparent it should be to go from Python to ASDF, or the issue of organizing ASDF trees themselves?

It certainly straddles implementation and design :wink:  In the current design, it's very easily to automatically convert views in Python to views in ASDF because the heirarchy is flat and guaranteed to have everything we need.  Moving to a views-are-based-on-other-views approach, the user will either have to be more explict about how the views should be in the file, or the system needs to be more careful about how it detects cases that can't be saved directly.
About reconstitution, if you had something like:
A -> B -> C -> data_block

saved in the file, Numpy doesn't really provide a way to create B based on C based only on strides and offset -- you can only B based on data_block.  There's no good reason it couldn't -- just not part of Numpy's current abilities.  You can create it correctly, but the dependence of B on C is lost, and only relates to data_block.  So you couldn't roundtrip an ASDF file without "flattening" the tree of views.  But all of that seems to be an artifact of Numpy, and if we really want views-on-views in the file format at the end of the day, we should just go about fixing Numpy.

In other words, I implicitly have assumed that any data buffer better have a base object that is general enough for all views (even if that requires it to be a byte array)

That's correct in the current design.  The data block really is just a "blob of bits" and the views can look at it however they want.  If views could point to other views, Numpy places restrictions on only "valid" slices, so we'd have implementation difficult there, particularly with tables.  Numpy places no restrictions on viewing the underlying data buffer.

So I guess one of the issues is whether to fold in numpy restrictions into this, and whether views of views have any merit in the first place. I was a little confused about your description, but I think you made it clear that although you can create numpy arrays based on nested views, the arrays have no internal indication of nesting so any such ASDF relationships are lost within numpy (and as such, even if numpy arrays were created by the user in a nested way, there isn't any way to save from the arrays that creation relationships since numpy doesn't retain it).
But I'm trying to tie this back to your rabbit hole explorations. For example:
A* -> B -> data_block
A* -> B -> C* -> data_block
Originally, I had assumed that the above relationships were those in numpy, since the asterisk refers only to items in the tree (B isn't being referred to in the tree). But if B isn't coming from numpy, where is it coming from? (If B was created in numpy, it isn't relevant to A any longer since A knows nothing of B).
So I'm still a bit murky on the context of this example (not that you aren't right about the way it has to work in ASDF).

I was a little confused about your description, but I think you made it clear that although you can create numpy arrays based on nested views, the arrays have no internal indication of nesting so any such ASDF relationships are lost within numpy

Sorry -- I wasn't clear.  In numpy, one can create views of other arrays through slicing (and arbitrarily nest those views) even though it's a single data buffer underneath.  But you can't create views of views through offset and stride -- those can only be created on top of the underlying buffer, so the nested heirarchy is "flattened".  So there is is a way to introspect and save nested views, but there is no way to restore that nesting from disk, unless you express everything in terms of slicing rather than striding can do.  Unfortunately, slicing is more limited because Numpy won't let you do anything type-unsafe with them.

Originally, I had assumed that the above relationships were those in numpy, since the asterisk refers only to items in the tree (B isn't being referred to in the tree). But if B isn't coming from numpy, where is it coming from? (If B was created in numpy, it isn't relevant to A any longer since A knows nothing of B).

Your original assumption is correct.  Those relationships are coming from Numpy.  Numpy does have the context about the whole chain from A -> B -> C originally.  If B isn't in the tree, the ASDF file doesn't have that context, so we either have to re-express A on top of C (in which case roundtripping won't be exact, but it probably doesn't matter to the user if they didn't put B in the tree) or include B in some non-user part of the tree (which just seems messy).  But in any event, not because it can't, but because it doesn't, we can't rebuild the A -> B -> C chain because Numpy doesn't provide an interface for that.  All we can do is A -> data_block, B -> data_block and C -> data_block.
In summary: as you say, it comes down to whether expressing nested rather than flat relationships are useful in ASDF.  I think they probably are useful -- it's a question of whether they are worth the complexity tradeoff.  Nested views introduce some necessary complexity (how you deal with missing links in the chain, how you garbage collect them, deal with cyclical references etc.) that don't have much to do with Numpy.  And they also introduce some problems that are specific to Numpy that we should ignore-and-then-fix-Numpy if there's compelling reasons to have nested heirarchies in ASDF.
But at the end of the day, whether you do that or not, to support encodings/compression, you are going to have exactly one "chunk of information" per block describing how to decompress/decode/reorder it.  Whether that info is in the main YAML tree or at the beginning of the block, it can really only exist one place.  It might as well just go with the block -- unlike the stuff currently in the tree which humans could edit without too much fear of breaking, if they know what they are doing, changing the description of the block encoding without also re-encoding the block doesn't make much sense.  So I'm starting to feel that the issue of nested views is somewhat orthogonal to the issue of encodings anyway.

Yes, I tend to agree. And I'm biased towards what is easier to implement than theoretically possible (particularly if the latter isn't precluded later). It's much better to get something that works the way we say it does out much sooner (and remember, the complexity will be judged by how hard it is to do in C, not Python as far as wider adoption goes).

@embray, @perrygreenfield: Stepping away from this problem for a few days, I think I have a new way forward, but want to get your thoughts first before devoting too much time on an implementation.
What if we pared down the "block encoding" part of this to just the most simple lossless compression -- only things like zlib that work on streams of binary data and don't have to have a deep understanding of its structure.  That's all pretty simple and obvious as to how it should work.  In this case we can just say what the compression algorithm is in a field in the block header -- no need for extra YAML there.
Then, for the higher-level stuff lossy stuff, which does need a deep understanding of the array structure, we reuse the transforms approach that we're using for WCS -- but it wouldn't be part of the WCS, it would just be a raw transform object hanging off of any array.  And probably this transformation would happen automatically on loading of the file, as opposed to a WCS.  There's no reason we couldn't define a transform that "shuffles" an array into tiles.  Defining a transform that converts int+scale+offset to floats would be a little outside of the box, but not impossible either.  (The tricky bit there is that the "input" data type to the transform is different from the "output" data type, so both would have to be defined somehow).  The code for these transforms obviously wouldn't have to live in astropy.modeling, which would still be for more "mathematical" transformations rather than these "computer sciencey" ones.  I like the idea because we already have the bones of a pretty sophisticated transformation infrastructure, so let's reuse that, rather than invent a new one over here for compression.  Of course, if we allow the user to put arbitrary transformations on any array, it's possible they'll put a rotation in there, or something, which would require resampling -- and resampling of course opens up a whole kettle of worms.
This gets tricky with views, but the same problems that currently exist with our WCS transforms would exist here, too.  In short, I think all transforms probably need to be defined in terms of the whole array as well, if they are going to be reusable at all.  That is, given a full array, chip, and a view into it, subarray, you probably want to do something like:
chip: !core/ndarray
   wcs: &my_wcs # Some big long WCS description

subarray: !core/ndarray
   wcs: @my_wcs

The only way to make this aliasing work (where both the full and the view refer to the same WCS) is if the WCS input coordinates are in terms of the full array.  We have the same requirement for compression-like transformations.
If this makes any sense at all, I think my way forward would be to (a) pare this PR down to the basics for stream-based compression (at which point we can say we've addressed the bare minimum for compression support), (b) deal with the rest as a separate step.

I�ll have to give it some more thought, but it sure seems logical and well matched to the processes and needs. I like it.
Perry
On Feb 25, 2015, at 10:29 AM, Michael Droettboom<EMAIL_ADDRESS>wrote:

@embray, @perrygreenfield: Stepping away from this problem for a few days, I think I have a new way forward, but want to get your thoughts first before devoting too much time on an implementation.
What if we pared down the "block encoding" part of this to just the most simple lossless compression -- only things like zlib that work on streams of binary data and don't have to have a deep understanding of its structure. That's all pretty simple and obvious as to how it should work. In this case we can just say what the compression algorithm is in a field in the block header -- no need for extra YAML there.
Then, for the higher-level stuff lossy stuff, which does need a deep understanding of the array structure, we reuse the transforms approach that we're using for WCS -- but it wouldn't be part of the WCS, it would just be a raw transform object hanging off of any array. And probably this transformation would happen automatically on loading of the file, as opposed to a WCS. There's no reason we couldn't define a transform that "shuffles" an array into tiles. Defining a transform that converts int+scale+offset to floats would be a little outside of the box, but not impossible either. (The tricky bit there is that the "input" data type to the transform is different from the "output" data type, so both would have to be defined somehow). The code for these transforms obviously wouldn't have to live in astropy.modeling, which would still be for more "mathematical" transformations rather than these "computer sciencey" ones. I like the idea because we already have the bones of a pretty sophisticated transformation infrastructure, so let's reuse that, rather than invent a new one over here for compression. Of course, if we allow the user to put arbitrary transformations on any array, it's possible they'll put a rotation in there, or something, which would require resampling -- and resampling of course opens up a whole kettle of worms.
This gets tricky with views, but the same problems that currently exist with our WCS transforms would exist here, too. In short, I think all transforms probably need to be defined in terms of the whole array as well, if they are going to be reusable at all. That is, given a full array, chip, and a view into it, subarray, you probably want to do something like:
chip: !core/ndarray
wcs: &my_wcs # Some big long WCS description
subarray: !core/ndarray
wcs: @my_wcs
The only way to make this aliasing work (where both the full and the view refer to the same WCS) is if the WCS input coordinates are in terms of the full array. We have the same requirement for compression-like transformations.
If this makes any sense at all, I think my way forward would be to (a) pare this PR down to the basics for stream-based compression (at which point we can say we've addressed the bare minimum for compression support), (b) deal with the rest as a separate step.
�
Reply to this email directly or view it on GitHub.


Model value is undefined

I don't know why.. but the model always returning me undefined..
<input type="text" fcsa-number="{ prepend: '$' }" class="form-control" placeholder="$(Maximum)" ng-model="investor.investment_range.max" />

Are you using Internet Explorer <= 9? I have this issue in IE9 only, and only when using prepend.

I see this problem on the latest version of Chrome also.

@yukw777, how does it look in this plunkr for you?

https://plnkr.co/edit/jMB2YLfPLzttTU6vJLNU?p=preview
This reproduces the bug I'm seeing. When you submit the form after entering a number, it will look all screwy.

It's the use of ng-submit in conjunction with this directive that's giving you trouble. I'm not sure what the root of the bug is, but if you change the form to use a button with an ng-click, you get the expected behavior. Similarly, if you remove fcsa-number from the <input>, then ng-submit works as intended.
This sounds like it's also causing @AlmogBaku 's error.

It's happening when you use {prepend: '$'}, remove it and that will fix it. But it is a bug.


How to mock a class method's which is initialized inside another class in typescript using ts mockito?

This is my Class I want to test using mocha-chai test framework in typescript. I am using ts-mockito for mocking.
export class ClassA implements IClassA {

    private classAResource: IClassAResource;

    constructor(){
         this.classAResource= new ClassAResource();
    }

    public async cancel(jobid){
       const job = this.classAResource.getJob(jobid);
       //cancel logic
    }
}

This is my Class I want to test using mocha-chai test framework in typescript. I am using ts-mockito for mocking.
export class ClassA implements IClassA {
private classAResource: IClassAResource;

constructor(){
     this.classAResource= new ClassAResource();
}

public async cancel(jobid){
   const job = this.classAResource.getJob(jobid);
   //cancel logic
}

}
ClassAResource class looks like this,
export class StreamResource implements IStreamResource {

private jobs: Map<string, Job>;

 constructor(){
 this.jobs= new Map();
 }

public async createJob(): Promise<Job> {
//add the job to map
}

public async getJob(jobid): Promise<Job>{
//return the specified job item from map
}

}

In my test I try to mock ClassAResource's getJob method like this,
const classAResource: IClassAResource = new ClassAResource ();
 const classAResourceSpy = spy(classAResource);

 when(classAResourceSpy.getJob(anyString())).thenResolve(job);

And I call the ClassA cancel method like this,
classA.cancel(jobid)
I expect the getJob call in cancel method to be mocked and return a job object.
But the test is not behaving according to my expectation. Mock doesnt come into picture and getJob() goes to actual implementation and return undefined.
I read online, this issue is because of the constructor initializations in ClassAResource class.
I removed the constructor and tried and now the getJob mock works.
But I need the constructor to instantiate the map object and ability to maintain the jobs.
Is there some workaround through which I can mock getJob() with constructor in place?
Am I doing something wrong here?
I am kind of relatively new to typescript and ts-mockito and any help is greatly appreciated.

Hi @shaiksyedali
This is not a problem with mocking, but with providing dependencies into your class. If you instantiate object by yourself in constructor then you don't have access to it as it is private field.
You can make this field public and then use spy on this field. But this is not recommended. We should not expose anything for tests purposes.
Better solution is to provide classAResource to ClassA via constructor.


fix: mark sleeping nodes as asleep if querying node info fails

fixes: https://github.com/zwave-js/node-zwave-js/issues/5643

@zwave-js-bot automerge


Publish gperftools-based builds

As discussed in #15235 devices with a page table size of 3 are not able to run builds based on Google's tcmalloc.
Changing the page table size to 4 requires a kernel rebuild. This is especially relevant for RaspberryPi owners.
Therfore until issues google/tcmalloc#82 or raspberrypi/linux#4375 are closed envoy versions >= 1.17 should also be published using gperftools' tcmalloc.

@mattklein123 were you able to test whether building the contrib arm image using gperftools’ tcmalloc works?

@mattklein123 were you able to test whether building the contrib arm image using gperftools’ tcmalloc works?

I haven't tested. I'm pretty sure it will cause almost a complete rebuild but feel free to try it out.

I compiled envoy using the envoy-proxy/envoy-build-ubuntu docker image by adding BAZEL_BUILD_EXTRA_OPTIONS="--define tcmalloc=gperftools" and rerunning the build without it. It seems like it is doing a full rebuild 🙁


Support 'request' on forms (django 1.11)

There should be an easy way to pass the request to the form class for one or more steps. I am using django-two-factor-auth which uses from django.contrib.auth.forms import AuthenticationForm but the user_login_failed signal has no request because it is not send in /wizard/views.py get_form().
I am currently using a modified copy of django-formtools where I put like if step == 'auth': in few places and then pass the request to the form to fix my problem, but it would be nice if it were properly supported in a way that doesn't potentially break other peoples things.
If I had time and/or were familiar with this app I would probably do a pull request myself.

Can't you just override .get_form(), and make this pass in the extra kwarg(s)?


revive reviveOffers

@brndnmtthws introduced the invocation of _driver.reviveOffers() to allow the framework to get previously declined offers sent back to itself.
Then the call was was inadvertently removed by @dsKarthick in this refactoring change.
We should consider reintroducing it.
Note that _reviveOffers() is called every 10 seconds, since the frequency of the nimbus-core calling allSlotsAvailableForScheduling() is driven by the nimbus.monitor.freq.secs setting.  This is pretty often, and much less than the default "filter seconds" of 120 seconds.  I believe this means that with the default settings, we will never reach the 120 second timeout and the declined resources will be re-offered much more quickly.

Note: discovered this issue while responding to #132 .

@JessicaLHartog : I'm pretty sure this is obviated by the changes in PR #200 , so I'm going to assign this to you to move to its final disposition.

You're right @erikdw, this is fixed in PR #200. Will close this issue once that's good to merge.

Closing this per @JessicaLHartog 's comments.

v0.2.4+ has this fix. For v0.1.x (storm-0.x support) we haven't done a release yet.


[samples] Remove duplicate samples

Much of the content in Range samples was duplicated in the Basics page. This PR consolidates that information.
Note that this PR includes changes from PR #269.

Docs Build status updates of commit d08e249:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/resources/samples/samples-overview.md
:bulb:Suggestion
View
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/develop/javascript-objects.md
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

docs/resources/samples/add-excel-comments.md
:white_check_mark:Succeeded
View

docs/resources/samples/automate-tasks-on-all-excel-files-in-folder.md
:white_check_mark:Succeeded
View

docs/resources/samples/clear-table-filter-for-active-cell.md
:white_check_mark:Succeeded
View

docs/resources/samples/community-seasons-greetings.md
:white_check_mark:Succeeded
View

docs/resources/samples/copy-tables-combine.md
:white_check_mark:Succeeded
View

docs/resources/samples/email-images-chart-table.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-calculation.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-cross-reference.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

docs/resources/samples/external-fetch-calls.md
:white_check_mark:Succeeded
View

docs/resources/samples/filter-table-get-visible-range.md
:white_check_mark:Succeeded
View

docs/resources/samples/getting-started.md
:white_check_mark:Succeeded
View

docs/resources/samples/move-rows-across-tables.md
:white_check_mark:Succeeded
View

docs/resources/samples/range-basics.md
:white_check_mark:Succeeded

docs/resources/samples/remove-hyperlinks-from-cells.md
:white_check_mark:Succeeded
View

docs/resources/samples/send-teams-invite-from-excel-data.md
:white_check_mark:Succeeded
View

docs/resources/samples/write-large-dataset.md
:white_check_mark:Succeeded
View

docs/resources/scenarios/analyze-web-downloads.md
:white_check_mark:Succeeded
View

docs/testing/macros-power-automate.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/excel-read-tutorial.md
:white_check_mark:Succeeded
View

docs/resources/samples/samples-overview.md

Line 42, Column 1: [Suggestion-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1182db7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/develop/javascript-objects.md
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

docs/resources/samples/add-excel-comments.md
:white_check_mark:Succeeded
View

docs/resources/samples/automate-tasks-on-all-excel-files-in-folder.md
:white_check_mark:Succeeded
View

docs/resources/samples/clear-table-filter-for-active-cell.md
:white_check_mark:Succeeded
View

docs/resources/samples/community-seasons-greetings.md
:white_check_mark:Succeeded
View

docs/resources/samples/copy-tables-combine.md
:white_check_mark:Succeeded
View

docs/resources/samples/email-images-chart-table.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-calculation.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-cross-reference.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

docs/resources/samples/external-fetch-calls.md
:white_check_mark:Succeeded
View

docs/resources/samples/filter-table-get-visible-range.md
:white_check_mark:Succeeded
View

docs/resources/samples/getting-started.md
:white_check_mark:Succeeded
View

docs/resources/samples/move-rows-across-tables.md
:white_check_mark:Succeeded
View

docs/resources/samples/range-basics.md
:white_check_mark:Succeeded

docs/resources/samples/remove-hyperlinks-from-cells.md
:white_check_mark:Succeeded
View

docs/resources/samples/samples-overview.md
:white_check_mark:Succeeded
View

docs/resources/samples/send-teams-invite-from-excel-data.md
:white_check_mark:Succeeded
View

docs/resources/samples/write-large-dataset.md
:white_check_mark:Succeeded
View

docs/resources/scenarios/analyze-web-downloads.md
:white_check_mark:Succeeded
View

docs/testing/macros-power-automate.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/excel-read-tutorial.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 47f3d69:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/develop/javascript-objects.md
:white_check_mark:Succeeded
View

docs/images/api-vid.png
:white_check_mark:Succeeded

docs/images/calc-mode-vid.jpg
:white_check_mark:Succeeded

docs/images/charts-image-vid.jpg
:white_check_mark:Succeeded

docs/images/comments-vid.jpg
:white_check_mark:Succeeded

docs/images/community-seasons.png
:white_check_mark:Succeeded

docs/images/cross-ref-tables-vid.jpg
:white_check_mark:Succeeded

docs/images/hyperlinks-vid.jpg
:white_check_mark:Succeeded

docs/images/largedata-vid.png
:white_check_mark:Succeeded

docs/images/merge-tables-vid.jpg
:white_check_mark:Succeeded

docs/images/move-rows-filters-vid.jpg
:white_check_mark:Succeeded

docs/images/teams-invite-vid.jpg
:white_check_mark:Succeeded

docs/images/visible-range-as-objects-vid.jpg
:white_check_mark:Succeeded

docs/images/xlsm-vid.png
:white_check_mark:Succeeded

docs/index.md
:white_check_mark:Succeeded
View

docs/resources/samples/add-excel-comments.md
:white_check_mark:Succeeded
View

docs/resources/samples/automate-tasks-on-all-excel-files-in-folder.md
:white_check_mark:Succeeded
View

docs/resources/samples/clear-table-filter-for-active-cell.md
:white_check_mark:Succeeded
View

docs/resources/samples/community-seasons-greetings.md
:white_check_mark:Succeeded
View

docs/resources/samples/copy-tables-combine.md
:white_check_mark:Succeeded
View

docs/resources/samples/email-images-chart-table.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-calculation.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-cross-reference.md
:white_check_mark:Succeeded
View

docs/resources/samples/excel-samples.md
:white_check_mark:Succeeded
View

docs/resources/samples/external-fetch-calls.md
:white_check_mark:Succeeded
View

docs/resources/samples/filter-table-get-visible-range.md
:white_check_mark:Succeeded
View

docs/resources/samples/getting-started.md
:white_check_mark:Succeeded
View

docs/resources/samples/move-rows-across-tables.md
:white_check_mark:Succeeded
View

docs/resources/samples/range-basics.md
:white_check_mark:Succeeded
View

docs/resources/samples/remove-hyperlinks-from-cells.md
:white_check_mark:Succeeded
View

docs/resources/samples/samples-overview.md
:white_check_mark:Succeeded
View

docs/resources/samples/send-teams-invite-from-excel-data.md
:white_check_mark:Succeeded
View

docs/resources/samples/write-large-dataset.md
:white_check_mark:Succeeded
View

docs/resources/scenarios/analyze-web-downloads.md
:white_check_mark:Succeeded
View

docs/testing/macros-power-automate.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/excel-read-tutorial.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Merging, but still open to feedback that can be addressed in subsequent PRs.


Made acfg1 take hostclass as a command-line option.

Modified acfg1.py to support passing in multiple hostclasses as command-line options, instead of handling only one and requiring it to be in a specific file.
This would allow us to specify files to be included in a specific OS-version bake, which has at times seemed desirable.

retest

:+1:

+1
I cannot help but to stop to think that this is how config management systems are built d:
@pchand-amplify

👍

Is it, @IlyaSukhanov? I totally hadn't noticed. 😝

Tested manually, didn't notice the error that pylint pointed out, verified that it was in fact as bad as it looked and fixed it, re-tested and didn't see that error.  Slightly perturbed by that lapse, but retesting slightly more rigorously doesn't show any other massive goofs...


Bug: Quick access takes a long time to load

Description
When I open a new window, quick access takes 3-10 seconds to load. In the native file explorer, it's immediate. There has to be something blocking loading.
Happens on stable and latest releases.
Steps To Reproduce
Open files, wait for quick access to load
may need to add a network location
Requirements
When opening files, quick access items should pop up immediately, same behavior as native explorer
Files Version
version agnostic, works on latest and stable releases
Windows Version
Edition	Windows 11 Pro Version	22H2 Installed on	12/5/2022 OS build	22621.1413 Experience	Windows Feature Experience Pack 1000.22639.1000.0
Log file
debug.log

Can you confirm if you're referring to the sidebar or home page (or both)?

It happens on both - though the disks/interfaces shows up a lot faster. But
neither are as fast as native explorer - the native explorer is pretty
instantaneous on my machine. Files takes about 2 seconds for disks to show
up, then another 6 seconds on top of that for the quick access/favorites
bar.

Message ID: @.***>

And to confirm, this is in v2.4.58, right?

Yes it is

Message ID: @.***>

@ThinkSalat has anything changed in v2.4.69?

@yaira2 I am currently in version 2.4.81 and this display problem still continues

@Lukiluc29 how many items are in the list?

@yaira2 There are 6 items in my quick access

@ThinkSalat thank you for the feedback, can you check to see if there are any improvements in v2.5.20?

unfortunately it's quite a bit worse than before - now when I open Files, it takes anywhere from 5-20 to start. I see the icon and an activity indicator spinning around, then everything loads at once.

it takes anywhere from 5-20 to start

The splash screen is shown while the app is loading, previously the window wouldn't even show at all during this time. That said, it seems like the issue relating to quick access has been resolved.

Well, I think the underlying issue is not resolved - I can open a
windows explorer window in the blink of an eye, but with Files, it takes
5-20 seconds. I think there's still something not right here
On Tue, Jul 25, 2023 at 3:41 PM Yair @.***> wrote:

it takes anywhere from 5-20 to start
The splash screen is shown while the app is loading, previously the window
wouldn't even show at all during this time. That said, it seems like the
issue relating to quick access has been resolved.
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/11732#issuecomment-1650600186,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHNEPJLJEN7VWB7ZOPVWTULXSA4RVANCNFSM6AAAAAAV4FCH7M
.
You are receiving this because you were mentioned.Message ID:
@.***>

If you compare v2.5.10 side by side with v2.5.20, there is a slight improvement. Quick Access you mentioned is now loading instantly so that resolves this issue.
We'll continue working on improvements to reach our goal of loading Files is less than a second. We already have a couple of improvements but they are currently blocked by issues in the WinAppSdk framework.


Add important clarification regarding image byte sizes

Description
This had me stumped for a while. Why is the cache storing uncompressed images? This is very inefficient in terms of memory usage, and saves very little processing power involved in repeatedly decoding the compressed images. In addition, the default value (100 MiB) falls short of accommodating even a modest practical use case. Unless and until this behavior is changed or made configurable, I suggest adding this clarification.
Related Issues

Partially addresses issue #54659.

Tests
N/A (pure doc change)
Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@annorax Do you have plans to come back to this PR soon to address the feedback?

Looks like the analyzer is complaining about a trailing white space:
https://github.com/flutter/flutter/pull/54660/checks?check_run_id=622361988
Can you please fix that?

Looks like the analyzer is complaining about a trailing white space:
https://github.com/flutter/flutter/pull/54660/checks?check_run_id=622361988
Can you please fix that?

Done!

Looks like the analyzer is still unhappy. I think you have to rebase your commit to the latest master to fix this.

Looks like the analyzer is still unhappy. I think you have to rebase your commit to the latest master to fix this.

Done, but that didn't seem to trigger a re-run of the analyzer.

I re-triggered the check. However, Just changing the base branch is likely not going to be enough. On your computer you will have to checkout your branch and execute something like:
git fetch upstream
git rebase upstream/master

.. and then push the result back to this PR.
(This assumes you're setup as described in https://github.com/flutter/flutter/wiki/Setting-up-the-Framework-development-environment)

@annorax Do you still have plans to come back to this? Since the change is so small, it may be easier to just create a new PR from master with this change.


Cargo-update: exceedingly slow progress on update when local registry/index is used and git-fetch-with-cli is false

Problem

When using a local registry located at /home/user/rust/crates.io-index (which is simply a clone of https://github.com/rust-lang/crates.io-index.git) , specified in  ~/.cargo/config using the following config:
[source]

[source.mirror]
registry = "file:///home/user/rust/crates.io-index"

[source.crates-io]
replace-with = "mirror"

is used, cargo update progresses incredibly slowly, consumes 1 CPU and slowly increases its RAM usage, given that the project has at least one dependency.  That's to say: when running cargo update the process takes very long.
The total update time was 21 minutes.
However, when ~/.cargo/config is changed to
[net]
git-fetch-with-cli = true

[source]

[source.mirror]
registry = "file:///home/jona/projects/rust/crates.io-index"

[source.crates-io]
replace-with = "mirror"

the update actually succeeds relatively quickly, which is the expected behaviour. With this option, the update took about 21 seconds.
Steps

Install rust
Clone https://github.com/rust-lang/crates.io-index.git
Edit/add the local source and overriding of the crates-io source to ~/.cargo/config using the first of the above examples. Point the mirror source to the directory into which crates.io-index was cloned.
Create an empty/basic project
Add a dependency to this project (I used time = "0.1.0", but as far as I can tell any dependency that triggers an update of the registry will cause this issue)
Attempt to run cargo update

Possible Solution(s)

Use
[net]
git-fetch-with-cli = true

in cargo configuration.
Notes
Output of cargo version:
I tested found the issue on 1.46.0, 1.49.0 (d00d64df9 2020-12-05), and 1.50.0.

Thanks for the report.  I have noticed this, too, and it can be extremely slow.  Unfortunately I think this is an issue with libgit2 (https://github.com/libgit2/libgit2/issues/2836).  For now, git-fetch-with-cli is probably the best workaround.

Super slow on https git pulls on macos here. Spent a while trying different things... this worked for me.
[source.crates-io]
registry = "git://github.com/rust-lang/crates.io-index.git"

@romecode good to see that you have fixed your problem, but I don't think your solution is relevant to this issue.
I've edited the issue itself to clearly include the workaround for the problem.

in my situation, in addition to taking a bunch of CPU the update also allocated ~8.6GB of ram which was not freed after the update (eventually leading to OOM).  using the workaround above worked great

It even leads to out of memory exceptions, when cross compiling in an alpine arm container in github actions.

FWIW, there is an ongoing project on integrating gitoxide[^1] to replace some uses of libgit2 in Cargo. I wouldn't say it will be landed soon but we can keep a eye on it, and maybe help @Byron if needed.
[^1]: It is a project sponsored by Rust Foundation. Here is a recent discussion: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/.60gitoxide.60.20integration.20for.20shallow.20clone.20support

gitoxide at this time supports git-aware transport exclusively so will do a 'proper' clone with file:///home/… and /home/…, and in doing that it is faster than git itself (when it is also using git-aware transport). Thus I'd also expect this issue to be fixed once the crates-io indices are cloned and fetched with gitoxide.

Set your source to this mirror. It worked for me
[source.crates-io]
replace-with = 'tuna'
[source.tuna]
registry = "https://mirrors.tuna.tsinghua.edu.cn/git/crates.io-index.git"

Thanks for thinking along @dxspro28, but that solution is irrelevant to the problem described here. Configuring the registry to be some other online source is not a solution when one wishes to use a local registry.
Additionally, unless the registry located at https://mirrors.tuna.tsinghua.edu.cn/git/crates.io-index.git contains some crates that are not available through crates.io, there is no real reason to use that over the default.

[source.crates-io]
registry = "git://github.com/rust-lang/crates.io-index.git"

Thanks, it was extremely slow for me using Arch, and this seems to fix the problem.

This configuration worked for me
[source]

[source.mirror]
registry = "file:///home/user/rust/crates.io-index"

[source.crates-io]
registry = "git://github.com/rust-lang/crates.io-index.git"


Optimisation!

Can we shave off a cycle here and there by optimising the code?

Taken from here: https://github.com/z88dk/z88dk/blob/master/doc/overview.md
zcc +zx -vn -SO3 -clib=sdcc_iy -startup=31 --max-allocs-per-node200000 @sp1demo.lst -o demo -create-app
think for us this goes to:
zcc +zx -S03 -startup=1 -clib=sdcc_iy --max-allocs-per-node200000 -D_TEST_GAME numbers.c face.c slot.c slot_monitor.c game.c control.c music.c util.c bread.c customer.c base.c -o game -create-app
This increases compile time

That's not to preclude actually optimizing the code of course - but let's make sure we're getting extra cycles out of it, not just changing for the sake of it.

OK, but let's do the compiler stuff at the very end. I think I can shave off a few cycles here and there in other ways too


issue 14160

Testing Plan:
GIFs or Screenshots:

Closing as this is abandoned and doesn't follow our contributing guidelines.


Control Center Lacks Permissions on Fresh Install

This problem appears to be intermittent.  With a fresh, mostly vanilla install of cp-help-charts (I only override the persistence disk sizes and storage class settings), Control Center comes up without permissions to access the data it needs.  Information panels in CC are all blank:

This is the error I am seeing in the logs:
ERROR Request Failed with exception  (io.confluent.rest.exceptions.DebuggableExceptionMapper)
javax.ws.rs.ForbiddenException: must have broker metrics access

Reinstalling the entire chart sometimes fixes the problem.  Sometimes it does not.

Well, reinstalling fixed it twice.  Up to 5 tries in a row this time and it won't go away.  I either unknowingly introduced something persistent or something changed in the AKS environment to cause it to happen more often now.

Did you solve the issue. I'm thinking of adding persistence to control center, because it is messing my ephemeral storage in my kube cluster. I have no idea why there is no persistence per default.

I had this issue and I fixed by recreating the KafkaRestClass take a look on that.


Incomplete suggestions in some cases

Description:
$title. For constructs from an imported module.
Steps to reproduce:
import ballerina/io;

type Foo record {|
    xml x;
|};

public function main() returns error? {
    Foo foo = {x: xml `<foo>hello</foo>`};

    json j = foo.toJson();
    io:p<cursor>

    Foo|error r1 = j.cloneWithType();
    io:println(r1);

    // doesn't work here

    Foo|error r2 = j.fromJsonWithType();
    io:println(r2);

    // works here
}

Note how the functions aren't suggested.

Affected Versions:
slalpha5

@MaryamZi can you please verify this on the latest master? Could not reproduce this on master.

I can still observe this on master.
Using the following project with one sub module mod1 and importing mod1 in the default module.
mod1
public type PrintTemplate record {|
    int i;
|};

public function println() {

}

public function func(PrintTemplate p) {

}

default
import foo.mod1;

type Foo record {|
    xml x;
|};

public function main() returns error? {
    Foo foo = {x: xml `<foo>hello</foo>`};

    json j = foo.toJson();
    // mod1:<cursor>

    // doesn't work here

    Foo|error r1 = j.cloneWithType();
    // mod1:p<cursor>

    // doesn't work here

    Foo|error r2 = j.fromJsonWithType();
    mod1:

    // works here
}

When it doesn't work

When it works

Had a look at this in the syntax tree visualizer. At the first 2 occasions, parser detects
    mod1:

    Foo|error r1

as the type binding pattern. Need to check this with the parser.

Had a look at this in the syntax tree visualizer. At the first 2 occasions, parser detects
    mod1:

    Foo|error r1

as the type binding pattern. Need to check this with the parser.

Basically, why do we allow spaces after :. At least we have to disallow new line character to handle similar cases. Otherwise we will have to special case this from the LS side

Basically, why do we allow spaces after :. At least we have to disallow new line character to handle similar cases. Otherwise we will have to special case this from the LS side

Isn't that formatters job to take care of whitespace, newline, etc? IMO, this has to be handled from the LS side.
As per the ballerina spec, qualified-identifier := module-prefix : identifier and

"TokenWhiteSpace is implicitly allowed on the right-hand side of productions for non-terminals whose names start with a lower-case letter."

In java also following works with no compilation error.
System.
             // some comment
             out.

                   println("test");


Please add a license

I'm interested in referencing parts of your project for my own work. However, I couldn't find a specified license. Could you kindly clarify the terms of usage or consider adding a license to the project?
Also for memory

doing it for both


Map Page: Update UI of the Filter Panel to be a Popup instead, with the updated filter UI

Context
The filter panel for map is currently a full page panel. You can make use of the existing React Popup component to implement the UI in the specific popup style (used in Pickup page; reference the spa-pages > Pickup page to see its implementation); if it works of course.
Upon creation of the popup, it should be a reusable popup component such that it can be reused in the Pick Up Page which has the same implementation.
There are new filter UIs:

The checkbox is now a list of togglable tabs instead for design purposes
2 Sort By buttons that are either or (similar to radio buttons)
The rest is the same, just bring over to the new panel design

Task

Reference figma and change the popup to suit the mockup.
Optional to use the React Popup library
Implement the new filter UIs as described above; the Sort By buttons do not have to be functional yet (it will be after #187/188 onwards)
Create a reusable component for this UI so that pick up page can reuse this same design.

Implementation Details:

The Apply button should be right above the X button, allowing for ease of user clicking
The Tabs section should have a fixed height of 2 rows maximum
The Pop Up should be the same width as the multiselect bar+filter button

Figma Link
https://www.figma.com/file/kN115h4H1jk797qa3x08Et/RGW-Design_Master-Design-File?type=design&node-id=5304-16366&mode=design&t=1Qzyuj9RvjAVBST3-0
Acceptance Criteria

@neozhixuan How do we get the values for "Type of Recycling Points" here? Is that something that will be implemented later?

Yes it has yet to be implemented atm!

Just updated the implementation details as well, do check it out, thank you!

Thanks for the added context. I have one question about the implementation details:

The Apply button should be right above the X button, allowing for ease of user clicking

We don't seem to have an X button in the design? Is it okay to assume that the apply button is going to be on the top right hand of the popup?

Oh sorry, i meant that it will be right above the "Filter" button, which is the one that is attached to the multi-select box! So when you click on the Filter button, it opens up the filter popup such that the Apply button is at the same position of the Filter button. My apologies


Spawn eggs can't be changed using a texture CIT

This is an addendum to #167, in which I explain the error in detail. I checked this in other version of the mod and the same still holds up.
However I created this issue to make note of another issue that is likely connected to the first:
When creating two property files with different names, one of them applying to a spawnegg, the other to a normal item, but both referencing the same texture file, they will both break ingame (presumably only if the spawnegg property is applied first.
The spawnegg item will have its default texture while the normal item will have a white spawnegg texture as its item.
The two property files for reference:
type=item
matchItems=rabbit_spawn_egg
texture=bowblade
type=item
items=iron_sword
texture=bowblade
And the picture:

Why is this important? Spawneggs are some of the most used items in custom maps and often have additional CITs in adventure maps.
After some diffing apparently egg texturing works different, in which they layer 2 textures on top of each other with different tint indexes and then use color providers to change the colours of them.

Just to clarify, this fix applies to 1.18+ only?
Then I will attempt to backport to thje 1.17 version

Nvm, fix is easily carried over into the 1.17.1 version of the mod, Ill open a pull request soon, thank you for your work!

I first fix on the main branch and then backport it to 1.18 for now.
I dont know if I'll backport to 1.17 tho as I dropped support for it.


[Snyk] Security upgrade st from 0.2.5 to 1.2.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

208/1000  Why? Confidentiality impact: Low, Integrity impact: None, Availability impact: None, Scope: Unchanged, Exploit Maturity: High, User Interaction (UI): Required, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00107, Social Trends: No, Days since published: 2382, Reachable: No, Transitive dependency: No, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 98, Impact: 2.35, Likelihood: 8.82, Score Version: V5
Open Redirect npm:st:20171013
Yes
Mature

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect

test


dbsync and the sync_data.gpkg

I preface everything I write as I'm two hours into what I think is the correct usage of dbsync.
I have a postgresql/postgis database (14.11/3.4) .
Current version of dbsync as of 20240305.
If I follow the directions and download the project (nrgsinc/mobile) to symbolize the sync_data.gpkg that is where the fun starts. The Layers open as blank in QGIS (3.34.3) There is data there. I'm working in EPSG:2274.
If I change the projection of the canvas to epsg:4326 and click "Zoom to layer" (by right clicking on the layer) the data appears. I then update the extent and create a spatial index and all is good. This may have something to do with the random warnings of downloading the us_noaa_tn.tif file. I didn't get that warning (I assume because dbsync shoves the data into the database) and my guess is Mergin Maps believes this is in 4326.
It's a simple fix now that I know - but I worry someone else may not see that as simple. If you want to see an unaltered project you can go to nrgsinc/mobile_lutra and download the sync_data.gpkg and take a look.

This does not seem like dbsync issue, more likely issue with data and/or QGIS project.


add test_volume_reattach_after_engine_sigkill

longhorn/longhorn#1240
Signed-off-by: Mohamed Eldafrawi<EMAIL_ADDRESS>

flake8 failed.

flake8 fixed


[Rust] Add a way to specify the dependencies while building with cargo

I recently encountered the following error while trying to package the tool Nushell:
[3613]   thread 'main' panicked at /home/brioche-runner-41322fd22ba65bf267f54e83cdb05a11e9f2de6509dc89833d97a20ff7613009/work/vendor/openssl-sys/build/find_normal.rs:190:5:
[3613]
[3613]
[3613]   Could not find directory of OpenSSL installation, and this `-sys` crate cannot
[3613]   proceed without this knowledge. If OpenSSL is installed and this crate had
[3613]   trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
[3613]   compilation process.
[3613]
[3613]   Make sure you also have the development packages of openssl installed.
[3613]   For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.
[3613]
[3613]   If you're in a situation where you think the directory *should* be found
[3613]   automatically, please open a bug at https://github.com/sfackler/rust-openssl
[3613]   and include information about your system as well as this message.
[3613]
[3613]   $HOST = x86_64-unknown-linux-gnu
[3613]   $TARGET = x86_64-unknown-linux-gnu
[3613]   openssl-sys = 0.9.102
[3613]
[3613]
[3613]   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[3613] warning: build failed, waiting for other jobs to finish...
[3613] error: failed to compile `nu v0.95.0 (/home/brioche-runner-41322fd22ba65bf267f54e83cdb05a11e9f2de6509dc89833d97a20ff7613009/work)`, intermediate artifacts can be found at `/home/brioche-runner-41322fd22ba65bf267f54e83cdb05a11e9f2de6509dc89833d97a20ff7613009/work/target`.
[3613] To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Process 3613 [1:41 Exited 101]

I discussed it with @kylewlacy, and the idea would be to extend the current interface of cargoBuild() method to add possible dependencies:
Proposal from @kylewlacy:
cargoBuild({
  crate,
  dependencies: [openssl()]
})

Resolved by #35


Adding the DeleteUser API and cleaning up the user management impl

Exposed DeleteUserAsync() method from the public API.
Added a skeleton implementation of the UserArgs class. Cleaned up the corresponding mutable operations from the UserRecord class.
Fixed a bug in how identity provider information is parsed (uid field renamed to rawId).
Updated and cleaned up unit tests. Added an integration test to cover the new APIs.
Encoding custom claims as UTF8 instead of Unicode (resolves #52).

Great PR. I wanted this function in .NET Admin SDK for a long time. Is it possible to accelerate merge?

Hi @DenSmoke. This is currently stuck in review, and the earliest we can release this is next week.


Migrate Card Approve e2e Test to JetPack Compose

Summary of changes

Migrate CardTest e2e Test
Migrate PaymentMethodsFragment to JetPack Compose
Create WireframeButton standalone composable in Demo app

Checklist
~- [ ] Added a changelog entry~
Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

Woops - I meant to post this comment re: the app crash on this PR

Woops - I meant to post this comment re: the app crash on this PR

Yeah good call, this is on both branches. Should be fixed now.


HHVM compliance

New tests were added after testing the period package against @padraic humbug. The package received bug fixes but tests no longer work on HHVM.

This is not my fault :P

I know must be some hidden or HHVM edge case but I would have to test each test individually to narrow the bug

Just run a travis check . As guessed the problem is with HHVM but I'm kinda lost as to why since PHP since to not mind at all ?

I finally did caught my HHVM bug :+1:
http://3v4l.org/HQKnj
HHVM and PHP do not treat the same way a misform dateinterval this is an inconsistency.


SharingWithUNET causes Hololens crash on Session Start

Overview
Cloned MRTK-Unity and opened SharingWithUNET example scene. Configured for UWP and Built. Deployed to Hololens. When I click to start a new session on the Start button, app freezes, then crashes, and returns me to Hololens home space.
Tried this with both latest .unitypackage release and by cloning MRTK repository. Same result.
Have used these Hololenses and this PC to successfully build shared experience Hololens apps. Did full reset of both Hololenses, didn't help.
Expected Behavior
Expect example scene to run normally, but starting a new network session and beginning anchor export.
Actual Behavior
App freezes and crashes, returns to Hololens home space.
Steps to reproduce
Import Holotoolkit unity package. Open SharingWithUNET example scene. Build and deploy. Run the app and  click button to start session.
MRTK-Unity master branch and / or .unitypackage Release 2<IP_ADDRESS>
Unity 2017.2.1.f1
Windows 10 Fall Creators Update
Visual Studio 15.5.4 with 10.0.16299.0 SDK
Unity Editor Version
2<IP_ADDRESS>
Mixed Reality Toolkit Release Version
2<IP_ADDRESS>

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


[AppBarTheme] adds titleSpacing parameter

Description
Adds titleSpacing property to AppBarTheme to allow configuration at the Theme level.
Related Issues
Fixes #66866
Tests
I added the following tests:

Added tests in app_bar_theme_test.dart
Added tests in app_bar_test.dart

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

yes

It seems like the test failures are legit for Linux web_tests:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8867173987202364880/+/steps/run_test.dart_for_web_tests_shard_and_subshard_7_last/0/stdout
Seems like the test is unhappy about the use of the decimal for web cases: .0. I'm pretty sure I've seen this happen before but I can't recall how we solved this problem, but you could try explicitly passing in doubles instead of integers in your debugFillProperties test.
05:10 +844 ~17: /b/s/w/ir/k/flutter/packages/flutter/test/material/app_bar_theme_test.dart: AppBarTheme implements debugFillProperties
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure object was thrown running a test:
  Expected: [
            'brightness: Brightness.dark',
            'color: Color(0xff000001)',
            'elevation: 8.0',
            'shadowColor: Color(0xff000002)',
            'centerTitle: true',
            'titleSpacing: 40.0'
          ]
  Actual: [
            'brightness: Brightness.dark',
            'color: Color(0xff000001)',
            'elevation: 8',
            'shadowColor: Color(0xff000002)',
            'centerTitle: true',
            'titleSpacing: 40'
          ]
   Which: at location [2] is 'elevation: 8' instead of 'elevation: 8.0'

You are right, passing the doubles explicitly should solve the issue, just had a look at DataTableTheme.

@shihaohong the tests are still failing

We could just skip the test when the target platform is web and add a comment on why it's skipped:
testWidgets('A test', (WidgetTester tester) async {
  // ...
  // On the web, Dart doubles and ints are backed by the same kind of object because
  // JavaScript does not support integers. So, the Dart double "4.0" is turned into
  // a string returns "4" instead of "4.0", causing this difference in debugFillProperties.
}, skip: kIsWeb);

Alternatively, you can write logic in your test code that branches:
testWidgets('A test', (WidgetTester tester) async {
  // ...
  if (kIsWeb) {
    // On the web, Dart doubles and ints are backed by the same kind of object because
    // JavaScript does not support integers. So, the Dart double "4.0" is turned into
    // a string returns "4" instead of "4.0", causing this difference in debugFillProperties.
  } else {

  }
});

If you'd like to understand the cause for this, try creating a JavaScript number and defining it as 4, and 4.0. When you console.log both values, you'll find they evaluate to 4. In fact, this is how the bool kIsWeb works.

Done. Thanks for the detail explanation. Surely learned a new thing about data types.


imagemagick: 6.9.9-21 -> 6.9.9-23

(cherry picked from commit a5783484eeff52125d9a97b446e5874c3d063cf0)
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@grahamc Does this look right for a backport? I just cherry'ed it onto the channels version, and it looked like a clean merge onto release-17.09.

Yep, perfect!

@grahamcofborg build imagemagickBig

@GrahamcOfBorg build rss-glx

@GrahamcOfBorg eval @GrahamcOfBorg build rss-glx


Update license

Made only 1 change:

Update LICENSE with new year by adding it as a range.
No other changes we made.

Thanks!


Default console logger format set to JSON breaking change

Migrating from .Net 5 to .Net 6 while running in containers, will change the default console logging formatter to json -> https://github.com/dotnet/dotnet-docker/issues/3274
I totally missed this unfortunately. Maybe an idea to add something about this to Update Docker Images:
https://docs.microsoft.com/en-us/aspnet/core/migration/50-to-60?view=aspnetcore-6.0&tabs=visual-studio#update-docker-images
It isn't mentioned in the breaking changes links AFAIK.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bec61f9-7298-170d-5e12-abb27cde584e
Version Independent ID: 27a43e3f-149d-9058-f937-0eda1d6dd4f2
Content: Migrate from ASP.NET Core 5.0 to 6.0
Content Source: aspnetcore/migration/50-to-60.md
Product: aspnet-core
Technology: aspnetcore-migration
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Added to https://github.com/dotnet/docs/issues/27906


Update kusto-cli.md

Added link for .Net Core

@ManojRaheja : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution @ManojRaheja - Before this PR is merged, ".Net" should be changed to ".NET" in both instances.

@manojraheja please open PRs in the private repo in the future.
Approved by ADX product team
#sign-off

@YaelSchuster: I'm sorry - only the author of this article, @orspod, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Make WorldLocationNewsArticle always political

WorldLocationNewsArticles are political but are never published by a Political Org. This commit updates the PoliticalContentIdentifier to do this and adds a data migration to update all existing WorldLocationNewsArticles.

:+1:


feat!: Service Account Mapping

Service Accounts in GCP need to be mapped to the SA's in the Kubernetes Cluster.
https://github.com/wandb/helm-charts/pull/178
Requires helm chart 0.15.0 to work with create_workload_identity = true for parts of the application.

This PR is included in version 5.0.0 :tada:


Can't seem to turn off SSL

Intention

I'm submitting a bug report
Environment

Operating System:
Windows 10 10586.589
Node Version:
6.8.0
NPM Version:
3.10.8

Description
Current behavior:
I'm behind a proxy, so I've configured my .npmrc to only use http, and npm works fine from the command line. I've also configured Monterey to only use http, and turned off Strict-SSL. However, when I try to create a new project, it hangs while downloading from Git and logs errors indicating a connection failure. The logs indicate that it is still attempting to communicate over port 443, despite other settings to the contrary. I could still be wrong, but that's what it looks like to me.
Expected/desired behavior:
When configured as such, no SSL communications should be attempted.
What is the motivation / use case for changing the behavior?
So I can work from behind the corporate proxy.
Logs

See the attached log file: 2016-10-14.txt

Hi @devingoble your issue is really an issue with GitHub, which specifically enforces the SSL comunications only. I would think that most companies which use GitHub as the source repository have some solution in place for their developers. Here is one hint for such solution if your admin cannot help you:
http://www.lmxm.net/git/2012/05/21/github-behind-isa-proxy.html
As you can see, this solution is specific for a given proxy and I do not believe that there is some universal solution available.

Well the setting you have used is configuring only NPM, and does not change any behavior of Monterey. But this is something we should definitely fix. For example, here we use https:// directly and this is something we could determine based on a settings

this could be useful: https://github.com/monterey-framework/monterey/search?utf8=✓&q=path%3Aapp%2Fsrc+https&type=Code

Unfortunately the GitHub API seems to be only available through https 😢


west.yml: Switch openthread to check CI

Test commit to trigger zephyr CI jobs on PR.
DO NOT MERGE THIS PR!!!

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

openthread
https://github.com/telink-semi/openthread/commit/aabbee49c8c9721ed1ca22a7b326ae3a23aaae09 (develop_draft)
https://github.com/telink-semi/openthread/commit/dcc1c0292af14fd637f57df12b0475b8f5cfda5b (test)
<EMAIL_ADDRESS>

Note: This message is automatically posted and updated by the Manifest GitHub Action.


Not working with UI-ROUTER

Hi! I'm new on MEAN Stack, I was trying to follow your e-book but I got stucked at the point of the Login button with AngularJS in the MEAN app: users manager chapter.
Untill then, evertihing was working just perfectly.
I'm following all the steps but with ui-router insted, I guess  this may cause some problems with the $http.post in here:
`	authFactory.login = function(username, password) {
	// return the promise object and its data
	return $http.post('/api/authenticate', {
		username: username,
		password: password
	})
		.then(function(data) {
			AuthToken.setToken(data.token);
   			return data;
		});
};`

I really don't understand why the button doesn't do anything :(
any idea why could it be?  @sevilayha

What errors are you getting in your console?


Made disabling Fullscreen optimizations its own tweak

This is to fix the confusion talked about in #1907

Removed "GameDVR_DXGIHonorFSEWindowsCompatible" modification from "Disable GameDVR" tweak

Created advanced tweak "Disable fullscreen optimizations"

Disables fullscreen optimizations in all applications. (Which can cause problems with Color Management in Exclusive Fullscreen)

I like it, I need to break apart more of these changes as it can conflict with peoples configurations.


Linux build

Very similar to the RPi build, but using GLFW for windowing and input. Also shares a lot with the OS X code. At some point I'd like to combine the OS X and Linux platforms such that they share the same source files.

Can you also update travis.yml to do a linux build also?

Yeah, adding a Linux build to Travis probably wouldn't hurt. Not sure how best to add it to the yaml file though, currently we treat anything running on "Linux" as if it's doing the Android build.

Let's wait on merging this until after we merge the PR that fixes Travis builds, then I can add the linux build to our Travis config and make sure it works.


[17.11] Don't filter nodes if logdriver==none

Cherry-pick https://github.com/docker/swarmkit/pull/2396.
git cherry-pick -s -x 9608c63711181bff3a33c71f763aedde2d3596ec
Cherry-pick was clean.
Signed-off-by: Brian Goff<EMAIL_ADDRESS>(cherry picked from commit 9608c63711181bff3a33c71f763aedde2d3596ec)
Signed-off-by: Nishant Totla<EMAIL_ADDRESS>

Ping @anshulpundir @thaJeztah @cpuguy83

OK CI failure seems related, I'll take a look.

Closing PR because 17.11 branch is now cut off at 312be5983e2d2f01f0cbcc99d027b28433256705, which includes this commit.


plugin: system monitoring

System monitoring

[x] mac os mem info
[ ] windows mem info
[x] mac os cpu info
[ ] windows cpu info
[ ] mac os LA info
[ ] windows LA info

maybe

[ ] mac os network ingress/egress
[ ] windows network ingress/egress
[ ] mac os IO ingress/egress
[ ] windows IO ingress/egress