Ruby: Fix smoke tests env variable name

Fixes: #1759

Codecov Report

Merging #1761 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1761      +/-   ##
============================================
+ Coverage     84.91%   84.91%   +<.01%
  Complexity     4495     4495
============================================
  Files           432      432
  Lines         17839    17842       +3
  Branches       1880     1880
============================================
+ Hits          15148    15151       +3
  Misses         2032     2032
  Partials        659      659

Impacted Files
Coverage Δ
Complexity Δ

.../codegen/viewmodel/testing/SmokeTestClassView.java
80% <ø> (ø)
4 <0> (ø)
:arrow_down:

...nsformer/ruby/RubyGapicSurfaceTestTransformer.java
100% <100%> (ø)
24 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5420df5...1e884bd. Read the comment docs.


Update usage of disable/isDisable

Project organization

Related to comments on https://github.com/liteflow-labs/starter-kit/pull/199#discussion_r1108144719

Changes

Replace disabled with isDisabled
Remove disabled styles from <Select /> component, as Chakra already applies those and instead use isDisabled
Remove disabled props if it's same with isLoading, as both doing the same thing

Description
As Chakra UI discourages to use disabled prop, instead we should use isDisabled prop.
Checklist

[x] Base branch of the PR is dev

just pushed a tiny fix for formatting but otherwise good to merge


engage76-Restore scenario vertical splitter

The vertical splitter on Scenario page got removed somehow in this PR #159 , added it back.
Code related:
https://github.com/NREL/engage/pull/159/files#diff-21b1f30849ae37170afa74484c029822dfe0d6caa4ee179bf258162be4a31962L175

@jeisenman23 , FYI, I missed the file when reviewing the code, causing Scenario splitter issue again. Reverted back. If you found anything else, please create another PR.


Update StorageClass docs

@jsafrane I am creating this early for when https://github.com/kubernetes/kubernetes/pull/31243 gets merged
Also taking the chance to clarify things.

This change is

LGTM from storage point of view, i.e. it accurately describes current behavior.


Installing Canary build docs

https://cli.emberjs.com/release/appendix/common-issues/
Installing Canary Build docs reference bower install, which I think is outdated info?

Yes, bower is outdated.
I think https://emberjs.com/builds/canary/ has the right instructions. A good PR for this could just link to that resource.


feat: added assert/is-negative-finite

This commit adds the assert/is-negative-finite module for handling negative finite values.
Resolves #1345  .
Description

What is the purpose of this pull request?

Adds the package @stdlib/assert/is-negative-finite.
Related Issues

Does this pull request have any related issues?

Yes, it resolves #1345
This pull request:

resolves #1345

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test Logs:

Checklist

Please ensure the following tasks are completed before submitting this pull request.

☑ Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Thanks for your suggestions @Planeshifter @Pranavchiku, I have made the suggested changes.

@gunjjoshi CI has passed; will give it one more review and then merge. Thanks for your contribution!


Cannot to connect to local Postgres (ssl required)

[pavel@localhost ~]$ ./usql pg://pavel@localhost/template1
Type "help" for help.

pg:pavel@localhost/template1=> select 10;
error: pq: SSL is not enabled on the server

You need too pass the ?sslmode=disable option in the URL:
./usql 'pg://pavel@localhost/template1?sslmode=disable'


Empty connection id may result in correct result - ConnOpenAck

Summary of Bug

This is the 3rd step in the connection opening handshake protocol.

This is the 3rd step in connection opening handshake, the previous step should have already create the counter-party's connection, and set its state to TRYOPEN. As such, if the counter-party's connection id is empty, it would be an error. However, in ibc-rs, if the counter-party's connection id is empty, the response would be Ok.

// Check that if the msg's counterparty connection id is not empty then it matches
// the old connection's counterparty.
let counterparty_matches = msg.counterparty_connection_id().as_str().is_empty()
|| old_conn_end.counterparty().connection_id() == msg.counterparty_connection_id();

if state_is_consistent && counterparty_matches {
    Ok(old_conn_end.clone())
}

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

The counterparty_connection_id has been added to the ConnOpenAck recently as part of the flexible identifier selection. If it is empty then the existing counterparty connection id is used and if all else is good the response will indeed be Ok.
This being said, the proper way to code this is to have msg.counterparty_connection_id as Option<ConnectionId>.


Low quality & long answers in copilot chat (improvement proposal)

Copilot  chat often gives me extremely long responses with almost no useful information. Even if I will be a dumb junior developer it would not help me. This behavior is actually slow down my development because searching internet is faster that waiting for a long useless answer that clarifying it and waiting again.
I do not want to read 500-1000 characters to realize that answer to my question is "NO|Not possible".
I could partially fix this behavior by adding after each question "short answer, no explanation". But why should I do that after each question?
Solution 1
By default copilot should respond in short verbose way.
I'm working I want brief/fast answer so I could continue to chat, clarifying requirements and so on.
If I would require explicit long answer than I could just ask for clarification or you could add addition command like "/clarify" to make Copilot give bigger response with all details on previous question.
Solution 2 (preferred one)
Maybe It would be cool to have a custom shortcut or default modifier for all copilot chat queries.
For example I want configure to add by default to all my inputs "Short answer, do not explain"
I want to have custom command like "/clarify" that would expand to "Answer on previous question with full explanation and code samples if requred"
The second solution is more flexible as it allows me to have several pre-defined shortcuts that would fit my work process. So I would not waste time typing same clarification question again and again
Ideally I should have ability to customize copilot behaviour in .vscode/settings.json I mean like any other configuration it sould be possible to have global configuration and workspace related.

I think the best solution for this is https://github.com/microsoft/vscode-copilot-release/issues/563 so you can customize it yourself, does that sound like it would help you?


remove classif tasks slides and pics from chap1-basics

there are quite a few slides on classif tasks
what should stay in 01:
a VERY short defintion of classification. MAYBE thats needed for "abgrenzung"
but as short as possible. if nothing stays, also ok, then we introduce classif completely in 02
pics BB already moved to 02 (and must be deleted in 01):
../ml-basics-regression/figure_man/lie-detector-polygraph.jpg cp
../ml-basics-regression/figure_man/webmd.png

outdated


Set Build Action for the generated files

Is it possible to set the build action for the generated files?
The tst file is set with 'None' but the generated ts files are set with 'TypeScriptCompile'
Any way to set them also to 'None' in the tst configuration?

No, it's not possible to configure the build action at the moment (1.3.1).
I'll look at adding support for it in a future version.


[Failed]  'xxx.torrent' failed to send torrent to client (rtorrent)

I see [Failed]  'xxx.torrent' failed to send torrent to client sometimes. I turned on debug and it didn't show anything odd or out of the ordinary.  It looks like it just simply wouldn't add to rtorrent.  Are there any reasons why this would happen or can at2 provide more info if it fails to add?

I added the torrent normally via the web UI and it added fine

Is it a large .torrent file?
If yes, then fixing this is likely related to #13 as it currently has no path on disk to send files to rtorrent (which is a requirement for large .torrent files).

It might be.  It's been random so I haven't been able to narrow it down.  What would be considered large?  Over 1MB?

https://github.com/rakshasa/rtorrent/issues/874 says 2MB is default

Earlier when I said "I added the torrent normally via the web UI and it added fine", I do remember that being a large data set for the torrent but I dont remember what the .torrent size was.  I'd have to guess they were large .torrent files when they failed since it seemed random and intermittent.  I'll keep an eye out in the future.

I have more results now.  All of the data sets were large but most of the .torrent files weren't too large.
[Failed]  'candxxx.torrent' failed to send torrent to client 711kb
[Failed]  'cordxxx.torrent' failed to send torrent to client 880kb
[Failed]  'edxxx.torrent' failed to send torrent to client 1.3MB
[Failed]  'lemxxx.torrent' failed to send torrent to client 229kb
[Failed]  'lovxxx2013.torrent' failed to send torrent to client 249kb
[Failed]  'lovxxx2014.torrent' failed to send torrent to client 324kb
[Failed]  'manxxx.torrent' failed to send torrent to client 760kb
[Failed]  'racxxxDID.torrent' failed to send torrent to client 778kb
[Failed]  'racxxxMF.torrent' failed to send torrent to client 1MB
[Failed]  'salxxx.torrent' failed to send torrent to client 628kb

If you run 1.2.0 with verbose, I hope it'll throw out the actual reason for failing.

I chose the first one from the list above and ran it with verbose
DEBUG:autotorrent.__main__:580:Failed to add torrent: FailedToExecuteException('Failed to add torrent: <ProtocolError for <IP_ADDRESS>:8004/RPC2: 413 Request Entity Too Large>')
The .torrent is 711kb.  Data dir is 78.29GB, 4138 files,  16 folders

I figured it out thanks to the extra debug output!
My XMLRPC size limit was too low.  I'm using this docker container https://github.com/crazy-max/docker-rtorrent-rutorrent/pull/107

That makes it related to #13 for sure, which is great.

I had one give this output when it failed to add
DEBUG:autotorrent.__main__:580:Failed to add torrent: FailedToExecuteException('Failed to add torrent: <ProtocolError for <IP_ADDRESS>:8004/RPC2: 502 Bad Gateway>')
Normally 502 Bad Gateway is when rtorrent is down or too busy doing stuff to respond, but I confirmed it's totally up and very responsive

I've had another batch of failed torrents with 502 Bad Gateway.  What's interesting tho, is when I add them manually with rutorrent and check the fast resume box, it will still for a hash check, and that hash check is always 100% fine and then it seeds automatically after the hash check is fine and it didn't find anything wrong.  It's like these torrents dont want to be added automatically with fast resume.


can't install on 2022.7.0

2022.7.0 was released a couple of hours ago. After upgrading I saw in the logs that both python dependencies of this package can't be installed (sorry I don't have the logs as I immediately rolled back). My guess is that it has to do with python 3.10 being used in that version. As I see that both dependencies were not released in a couple of months, I'm guessing that there is not much you can do about it... I will try to update again when I have the time so I can extract the logs and post them here

I solved my use case (controlling the pi fan speed) by migrating to gpizero, you can see the changes I made here but since it doesn't support transitions, nor rgbw, I only migrated the simple mode. I can confirm that my fix works great on 2022.7.0. Feel free to use my changes as a base to your library (same as I did with yours haha) to be compliant with 2022.7.0

Does gpizero work only as an on/off control? Or is dimming possible as well?

dimming is possible - I did that in my code

@regevbr,
I just use the pi fan to regulate to 50C so it is enough using your version for me.
Many thanks for your work and sharing.
This last ha update has been hard to control!

@RedMeKool of course also thanks to you!!

Great fix @regevbr! I merged it with the main branch, thx


app.js script chunk rendered twice

Hi, i'm using v0.6.0.
i'm facing the issue that the app.js chunk is rendered twice: renderScripts() renders the

Not surprisingly, this commit introduced the issue: https://github.com/Akryum/vue-cli-plugin-ssr/commit/f9d409326332f086eff282d7ad048d67e459cea2

I am experiencing the same issue.
It should be fixed ASAP since it also impacts performance.

Since it's apparently not possible to alter the configuration of the html plugin,
I've created https://github.com/Akryum/vue-cli-plugin-ssr/pull/160

Since it's apparently not possible to alter the configuration of the html plugin in vue.config.js, I've created #160

You saved my day!
Just for reference, it also seemed to be causing following errors for me (both came after update to 0.6.0):

vue would complain I mutate store state outside of mutation handles (which wasn't the case)
router navigation would push to history twice

When I applied the fix for #160 problems disappeared.

Since it's apparently not possible to alter the configuration of the html plugin in vue.config.js, I've created #160

actually it's possible to fix it by only chaning vue.config.js
  chainWebpack: (config) => {
    // https://github.com/Akryum/vue-cli-plugin-ssr/issues/158
    const htmlSsrPlugin = config.plugins.get('html-ssr')

    if (htmlSsrPlugin) {
      htmlSsrPlugin.store.get('args')[0].chunks = []
    }


proposal: container/heap generic example

Now that generics are sorted out the documentation example priority queue here https://pkg.go.dev/container/heap should include the use of generics like below
type PriorityQueue[K comparable, P cmp.Ordered] []*Item[K, P]

type Item[K comparable, P cmp.Ordered] struct {
	value    K
	priority P
	index    int
}

func (pq PriorityQueue[_, _]) Len() int {
	return len(pq)
}

func (pq PriorityQueue[_, _]) Less(i, j int) bool {
	return pq[i].priority < pq[j].priority
}

func (pq PriorityQueue[_, _]) Swap(i, j int) {
	pq[i], pq[j] = pq[j], pq[i]
	pq[i].index = i
	pq[j].index = j
}

func (pq *PriorityQueue[K, P]) Push(x any) {
	n := len(*pq)
	item := x.(*Item[K, P])
	item.index = n
	*pq = append(*pq, item)
}

func (pq *PriorityQueue[_, _]) Pop() any {
	old := *pq
	n := len(old)
	item := old[n-1]
	old[n-1] = nil  // avoid memory leak
	item.index = -1 // for safety
	*pq = old[0 : n-1]
	return item
}

Beyond this I feel there is a lot of machinery required to implement the heap interface (like above) and wonder if any work can/should be done to make this simpler.

Instead of adding documentation, we should add an implementation (see #47632).

Duplicate of #47632


Database seed data/script are missing

Describe the bug
There are no script or data related to the 'seeding' as described in the CONTRIBUTING doc
To Reproduce
Clone master repo and run 'npm run database:seed data/sample'
Expected Response
NPM script should run the code necessary to seed the Mongo DB
Actual Response
Missing script: "database:seed"

Solved it, data is contained in a separate repo:
https://github.com/quotable-io/data


Bump pydantic dependency

Is your feature request related to a problem?
I’m trying to use the surrealdb package and pydantic-settings package, but surrealdb’s pin to pydantic v1.x is causing conflicts.
Describe the solution
Bump surrealdb’s pydantic to v2.x or drop it.
Alternative methods
I could use surrealdb v0.2
SurrealDB version
1.0.0
surrealdb.py version
Trying to use 0.3.1
Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @applied-mathematician!
I will take a look into this and let you know how i go.

Closing this as #66 has been merged


Simple Installation??

I am not a programmer. I am an artist who loved the results of the demo of this program, and I wanted to download it so I may use it as a base in my own works, to then work off of and create finalized art.
Unfortunately, the instructions might as well be in an ancient nordic language because I cannot for the life of me figure out how to install it. I feel as though I wasted several hours of my life downloading all these programs like the guide told me, only to be stumped at the last few lines that have no instructions, just coding (which means nothing to me as I have no idea what to do with them). So hours later, I am still incapable of using this program.
Is there no way for someone to package this into one install? Or at the very least, provide instructions that someone who is NOT a programmer may follow?

I see , current installation process is too difficult for non programmer.
Currently we dont have 1 packaged version, its future work.

a programmer friend helped me local install, but now i need a bit of help. all images i upload say they're too big to colorize. is there a way to allow larger image sizes?

Wait, more issues.
I installed locally through python 3. The only way I've managed to get it to run is through a local server run through the command prompt. All other methods give various errors.
It opens perfectly with a local server, except uploading any image comes up with "UPLOAD ERROR". Any suggestions?

I'm having the same issue. Managed to get it to run locally by navigating with the command prompt to the paintschainer directory locally and calling python -m http.server 8000. But getting an upload error. The error log on the command prompt says it's a 501 error, which tells me it doesnt support post requests?

Having the same issue. managed to get it to lauch into localhost with
python -m http.server --cgi 8000 but I keep getting a code 501: can only post to CGI scripts error.

To colorize larger image, you have to change code itself.
see also https://github.com/pfnet/PaintsChainer/issues/92
Did you booted the server.py ? is there any error in your console?
python -m http.server --cgi 8000 is not correct command.
Type python server.py in your terminal at root PaintsChainer dir.

It's giving me the error "no module named http.server"
Which is odd because i'm using 3.6. I thought http.server was in python 3 :/

Oops, apologies. Forgot to input "python" >_>
Getting this instead:
FileNotFoundError: [Errno 2] No such file or directory: './cgi-bin/paint_x2_unet/models/unet_128_standard'

Didn't tested in 3.6 but it fails to install in a month ago. Prefer 3.5 as stated in installation guide.
FileNotFoundError: [Errno 2] No such file or directory: './cgibin/paint_x2_unet/models/unet_128_standard'
Download the trained data. The network is nothing without trained data :)

For installation, due to license issues, we cannot include everything from the others.
You must visit them all to get the modules legally.
(And this is why I created the guide to make it working in my personal notebook instead of big server)

ah, makes sense.
Sorry, having trouble understanding where to get the trained data and where to put it. I see the line, out, and ref folder in the images subfolder, but I'm unsure how to continue.

Visit http://paintschainer.preferred.tech/downloads/
Download all of them, put them into 'cgi-bin/paint_x2_unet/models/'
Create folder models if you don't see it.
cgi-bin should be in the same folder as server.py

Excellent! I can now upload images without upload error.
Unfortunately I'm now getting a "Server Error" after i upload and paint it. I don't think the image is too big, as I haven't received the 'Image is too large to colorize" error.
Any ideas? Hopefully it's not a python 3.6 error :/

You should see there are tons of logs in the console log. Try to copy and paste it here.
If you can read it, try to paste the critical lines (Usually located in the bottom line).

Nothing in the command line:
python server.py
GPU: 0
start
load model
serving at localhost : 8000

Try press F12 in browser... ?
That could have a few lines about error.

load:./images/line/GK93M4X6RGJCLVQ88VR3DCF1X4R2FBG7.png True False
Exception happened during processing of request from ('<IP_ADDRESS>', 41234)
Traceback (most recent call last):
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\cupy\cuda\compiler.py", line 49, in _run_nvcc
return subprocess.check_output(cmd, cwd=cwd, stderr=subprocess.STDOUT)
File "C:\Users\Kirsten\Anaconda3\lib\subprocess.py", line 336, in check_output
**kwargs).stdout
File "C:\Users\Kirsten\Anaconda3\lib\subprocess.py", line 418, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['nvcc', '--preprocess', '-Xcompiler', '/wd 4819', '-m64', 'C:\Users\Kirsten\AppData\Local\Temp\tmpq9mct_d7\kern.cu']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Kirsten\Anaconda3\lib\socketserver.py", line 317, in _handle_request_noblock
self.process_request(request, client_address)
File "C:\Users\Kirsten\Anaconda3\lib\socketserver.py", line 348, in process_request
self.finish_request(request, client_address)
File "C:\Users\Kirsten\Anaconda3\lib\socketserver.py", line 361, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "server.py", line 30, in init
self, req, client_addr, server)
File "C:\Users\Kirsten\Anaconda3\lib\socketserver.py", line 696, in init
self.handle()
File "C:\Users\Kirsten\Anaconda3\lib\http\server.py", line 418, in handle
self.handle_one_request()
File "C:\Users\Kirsten\Anaconda3\lib\http\server.py", line 406, in handle_one_request
method()
File "server.py", line 75, in do_POST
self.paint_process( form, id_str )
File "server.py", line 118, in paint_process
painter.colorize(id_str, form["step"][0].decode() if "step" in form else "C", blur=blur)
File "./cgi-bin/paint_x2_unet\cgi_exe.py", line 106, in colorize
image_conv2d_layer = cnn[step].calc(Variable(sample_container, volatile='on'), test=True)
File "./cgi-bin/paint_x2_unet\unet.py", line 61, in calc
e0 = F.relu(self.bnc0(self.c0(x), test=test), use_cudnn)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\chainer\links\normalization\batch_normalization.py", line 139, in call
x, gamma, beta, mean, var, self.eps, self.use_cudnn)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\chainer\functions\normalization\batch_normalization.py", line 347, in fixed_batch_normalization
use_cudnn)(x, gamma, beta, mean, var)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\chainer\function.py", line 199, in call
outputs = self.forward(in_data)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\chainer\functions\normalization\batch_normalization.py", line 167, in forward
self.std = xp.sqrt(var, dtype=var.dtype)
File "cupy/core/elementwise.pxi", line 774, in cupy.core.core.ufunc.call (cupy\core\core.cpp:42682)
File "cupy/util.pyx", line 37, in cupy.util.memoize.decorator.ret (cupy\util.cpp:1283)
File "cupy/core/elementwise.pxi", line 582, in cupy.core.core._get_ufunc_kernel (cupy\core\core.cpp:39296)
File "cupy/core/elementwise.pxi", line 32, in cupy.core.core._get_simple_elementwise_kernel (cupy\core\core.cpp:29818)
File "cupy/core/carray.pxi", line 87, in cupy.core.core.compile_with_cache (cupy\core\core.cpp:29505)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\cupy\cuda\compiler.py", line 131, in compile_with_cache
base = _empty_file_preprocess_cache[env] = preprocess('', options)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\cupy\cuda\compiler.py", line 94, in preprocess
pp_src = _run_nvcc(cmd, root_dir)
File "C:\Users\Kirsten\Anaconda3\lib\site-packages\cupy\cuda\compiler.py", line 56, in _run_nvcc
raise RuntimeError(msg)
RuntimeError: nvcc command returns non-zero exit status.
command: ['nvcc', '--preprocess', '-Xcompiler', '/wd 4819', '-m64', 'C:\Users\Kirsten\AppData\Local\Temp\tmpq9mct_d7\kern.cu']
return-code: 1
stdout/stderr:
b"nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).\r\nnvcc fatal   : Cannot find compiler 'cl.exe' in PATH\r\n"

stdout/stderr:
b"nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).\r\nnvcc fatal : Cannot find compiler 'cl.exe' in PATH\r\n"
I have a bad news for you (chill it happens to me too). What GPU you're using?

EVGA Geforce GTX 970. Almost brand new card :/

Updating my driver real quick....

Strange. Deprecate architecture occurs on GPU under 630... (Even 590 is included). That's may not your case. Ignore the warning.
But for cl.exe See https://github.com/pfnet/PaintsChainer/wiki/Required-environment-variables
Hard to explain it, try go to My Computer right click Properties > Advanced system options in the left  >  Environment variables and set them all.
Make sure your VS stuffs are present.

I've tried adding D:\Program Files (x86)\Visual Studio\VC\bin to the environment path and tested a dozen or so times now and I still keep getting the same error.

Sorry for late reply.
As my case, all folders have cl.exe, but /bin only is good enough.
Go to the directory same as server.py
Try use python to run these code
import os
print(os.environ["PATH"])

See if your D:\Program Files (x86)\Visual Studio\VC\bin exists there... If not, try make the environment variables not for your account but the system one. (there are 2 places to input them).

Hi, guys! @taizan, @kanekirsten07, @Ulf3000, @6DammK9, @vhall413, could anyone please share the downloaded pretrained models (unet_128_standard & unet_512_standard)? I cannot download them since the provided link in the repo does not function properly :(


Use defaultFieldResolver from graphql-js package instead of own one

Use of defaultFieldResolver of graphql-js package instead own one.
Should fix #368 as soon as this PR is merged: https://github.com/graphql/graphql-js/pull/980

@stubailo: do you mind merging this PR though some minor coverage decrease has been detected?

Sure thing! Weird that it failed the status with that small of a change.

@dimitri-koenig do you mind sending a PR to the changelog as well?

@stubailo: Done. Please merge again. Any idea about a date of the next official release?

@martijnwalraven or @freiksenet can publish!

@dimitri-koenig: Just published v1.2.0!

@martijnwalraven & @stubailo: you are awesome. That way open source work is really so much fun. Efficient, effective and fast. Thank you so much.


Feat/1679 make dlt init use core sources

Description
Updates the dlt init command to use the core source if present. It uses all the same mechanisms as before, so secrets extractions and destination replacements still work.
What this PR does so far:

[ ] User core sources if present (filesystem for now)
[ ] Move generic pipeline to core

Possible ToDos:

[ ] Replace "is_template" with three value "verified", "core" and "template" and update the user messages accordingly
[ ] Update generic pipeline template and add test for it
[ ] Add proper support for custom destination (insert a destination function into the pipeline file if selected)
[ ] Allow modifiers for sources, e.g. dlt init filesystem:az duckdb will create credentials for azure
[ ] Clean up core source pipeline files with docs strings for every function
[ ] Allow multiple generic templates
[ ] Update the command that lists the available sources to show the core sources also

@sh-rp let's move forward! I'm particularly interested how you'll deal with more complex templates. currently our demo pipelines are runnable code but in the core they do not need to be... so we do not need to use AST to rewrite them.


Missing API-Key

Hi,
the method RecordPackageDependenciesInternalAsync() in ProGetClient.cs does not add the ApiKey to the request headers.
This leads to the following server response, even if an ApiKey is given:

Can you confirm this behavior?

Yes, that's definitely a bug. We'll get v1.3.1 deployed with this fixed as soon as possible.
Thanks!


Added meta dictionary to the service payloads of the agent API

For issue #119

Have you tried this out with a response that contains the dictionary? I wasn't aware json.net could deserialize into interfaces - should this be just Dictionary instead?

Yes, I tried and seems to work well. It's the same property as the one which already exists in  CatalogService.cs.
In any case, I'm happy to change them to concrete Dictionary types.

Cool! Thanks. Would it be possible to get the nuget package updated with the latest code, please?

Yep, it's released now. I was leaving for work when I merged this so it took a bit to cut the release.


[feat] Implement taproot root_hash function

As part of taproot upgrade for Shinigami, we will need a way to compute the root hash of a tapscript. This will allow us to verify taproot leaves
References

Shinigami taproot root_hash
Btcd implementation

Can be assigned this

Can I work on this, would love to take it on.
On Thu, Oct 31, 2024, 6:45 PM Benedict Ejembi @.***>
wrote:

Can be assigned this
—
Reply to this email directly, view it on GitHub
https://github.com/keep-starknet-strange/shinigami/issues/275#issuecomment-2450469759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANGCG5WCBCS2NZ5IIOYWVTDZ6JUB7AVCNFSM6AAAAABQ6ZV37GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGQ3DSNZVHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Please can I be assigned to this issue @b-j-roberts

Hi @b-j-roberts , can I work on this?

@b-j-roberts can I work on this issue?

May I also work on this one @b-j-roberts?


Errors and new API

Created a system for displaying errors in a popup/modal.
Updated the API's setMessageListener

Hey @SirPython were you wanting to merge this into develop at some point? I just noticed it has been sitting here in conflict since Sept 25


Prints list of odd numbers

There was a script for even numbers, so I decided to add a script for odd numbers.

Thank you for you contribution to the repo and the community


Timesheet - 05/08/2021 - Bojan Ilijevski

Task 1
Managing social media
Answering private messages on Instagram, Facebook and Twitter.
Unfollowing people on our social media due to community feedback (Not doing it all at once since Instagram and Twitter bots will ban our page with a lot of unfollowing at once)
Made posts about Community Feedback form on Twitter, Instagram, Reddit and Facebook
Time Spent
.5 hours

Task 2
Marketing meeting
Proof of Work

https://docs.google.com/document/d/1tzIqncTwbcf2WYXL_k9BJOr3sNn4s3-ZuYXBeo0pWzI/edit#

Time Spent
2.5 hours

Task 2
Doing research on crypto and gaming, blockchain gaming
Proof of Work

https://docs.google.com/document/d/1XQtVFRmAn4W1AKc3ATchjnDst2UkRRzlkEINJ44KtnA/edit

Time Spent
1.5 hours

Total Time Spent
4.5 hours
Account Number
b9917332050dfe0b2e2717efb3962d3138a78877b463b5a6458565b8b344aa06

@bojan-ilijevski, is there any documentation for the research? It would be good to have a google doc with notes or something along those lines.
Point form is fine.

@bojan-ilijevski, is there any documentation for the research? It would be good to have a google doc with notes or something along those lines.
Point form is fine.

When the doc is done I'll update this issue with the link.

Adding Not Ready label till then.

Adding Not Ready label till then.

Updated


EthernetWebServer does not read and send html.h file to web browser

Hello Khoih,
I am trying to read a file test.h containing html code to send it to the web browser but shows a blank page. I am using Arduino Mega and Ethernet shield W5100 Wiznet.
#include test.h
void handleRootl()
{
String root_code = html_page;
server.send(200,"text/html",root_code);
}
test.h file contains:
const char html_page[] PROGMEM = R"=====(
<!DOCTYPE HTML>
 ........
)=====";
The sketch works fine with ESP8266WebServer. Please let me know how to solve it.

Because you're using resource-limited Mega, not powerful ESP8266, with powerful libraries to support complicated features.
Moreover, the W5x00 shields also have 2K buffer size limitation unless you change.
Try the smallest html page, then add more until it breaks. But the html page size must be much less than 2K. Must be very careful while writing code to avoid unnecessary large local vars, such as
{
  String root_code = html_page;  <== create big unnecessary local var.
  server.send(200,"text/html",root_code);
}

Start with the following code
void handleRoot()
{
  server.send(200,"text/html", html_page);
}

test.h

const char html_page[] = "<!DOCTYPE html><title>AVR_WM</title>\

<fieldset>\

SSID<input value=\"your-SSID\"id=\"id\">

\

PWD<input value=\"your-PWD\"id=\"pw\">

</fieldset>";

and have this webpage displayed

Thanks for clarifying. Indeed the test.h file size is 17KB so saved it on SD card and loaded it in portions to the web browser within the available resources limitations.

Hi Khoih,
I am facing the same problem. I am using Arduino due and ethernet shield 2, my Html page consists of JavaScript and CSS files and is big. The EthernetWebServer does not read and send html file  to web browser but if i remove the JavaScript and CSS, the Ethernet Webserver is able to read the html file. I do not want to use SD card in my project although it is working with sd card. Please help me in this regard.

@innsbruckcreate
The Ethernet shields, using Ethernetx libraries with 2K-buffer limitations, as well as the small MCUs, all have limited resources. Don't expect them working like a modern PC.
Please have a look at Issue 7: Problem with page larger than 2k. to see how the well-known big-file issue was solved.

Thanks for the advice, I finally solved the problem by separating the css style into the file itself and then a separate html file.

Hi Khoih
Thanks for the response.
I have tried with simple file (for example analog gauge reading or bar graph) with 1kb size, but then also Ethernet web server is is not able to read the file it gives a blank webpage.
index.txt
Thanks
Regards
Durgesh Singh

Hi,
I'm afraid I can't help any further as I don't have time to deal with your specific problem.
This EthernetWebServer Library has to rely on Ethernetxyz libraries and can't provide magic.
I suggest you first try to successfully use the Ethernetxyz libraries, and ask for help and support there and/or in any of other related support forums. Remember also to provide enough info as described in How to create a Minimal, Reproducible Example so that other willing-to-help people can duplicate te issue and help.
Whenever you're successful in using the Ethernetxyz libraries with your use case, then move to use this EthernetWebServer Library.
Good Luck,


Mismatch between Cocoapods and Repo code?

I'm seeing huge differences between the code available in Cocoapods and the repo here in GH. Maybe Swift3 code??
Could there be an update pending? I'm interested in using this lib to skip doing some manual transformations, but as it is it won't build out of the box.
An example is
class TransformedCoordinateSpace : NSObject, UICoordinateSpace {
...
}

This class declaration is already different than what the repo in GH has, where declaration is ClassName: NSObject and the second extension is handled in an extension tag right below.
https://github.com/paulz/ImageCoordinateSpace/blob/master/ImageCoordinateSpace/TransformedCoordinateSpace.swift

Cocoapods releases are made by tags, see latest example:
https://github.com/CocoaPods/Specs/blob/master/Specs/4/2/4/ImageCoordinateSpace/1.0.5/ImageCoordinateSpace.podspec.json#L15
While the link to GitHub in this issue points to master. Here is the correct link using the tag: https://github.com/paulz/ImageCoordinateSpace/blob/1.0.5/ImageCoordinateSpace/TransformedCoordinateSpace.swift


SPOTIFY HAS BUG

SPOTIFY NOT WORKING! AND SOME TIMES MUSIC STOP TO PLAY

hmm i am working on it, please wait

Yes Spotify bug


adds shuffling to distributed training

the distributed worker readers werent shuffling per thread in PyTorch.
Add that, allowing shuffling of file set and shuffling for each file and changed allocation
of reads to distribute more evently.
Also add LR logging on update steps

we can add back in buffered shuffle if its not efficient, but was simpler to slurp the whole file


[v4 dev] Adding a basic headways widget

Added a basic headways widget with real data
Updated travel times to show a real number (real-ish)

Missed the last PR, but I was gonna suggest we keep the home screen widgets simple. I was thinking about just a single data point like median for headways and travel times for the day. Then if the user clicks in, they see the graph.
maybe on desktop we could expand those widgets to include the graphs.


Errors when you have 2 webull accounts - think it's picking the wrong one

I have one cash and one margin account with webull. I think it's picking the newest account by default when logging in. Is there any way to specify which account to use?
I'm using the "workaround" login method. But - the tokens seem to be the same no matter which account i choose in the web ui.
Thanks for any help.

def get_account_id(self): <- this is the method that needs to be modified.
The method as its written by the author will only retrieve the first account among the list of accounts.
You want to change this to the correct one in the list. Assuming you only have two accounts (the first in the list being the cash account), you would change:
id = str(result['data'][0]['secAccountId'])
to:
id = str(result['data'][1]['secAccountId'])
To confirm this is correct, you could print out the response and confirm the data matches the account.

def get_account_id(self): <- this is the method that needs to be modified.
The method as its written by the author will only retrieve the first account among the list of accounts. You want to change this to the correct one in the list. Assuming you only have two accounts (the first in the list being the cash account), you would change:
id = str(result['data'][0]['secAccountId'])
to:
id = str(result['data'][1]['secAccountId'])
To confirm this is correct, you could print out the response and confirm the data matches the account.
    def get_account_id(self):
        '''
        get account id
        call account id before trade actions
        '''
        headers = self.build_req_headers()

        response = requests.get(self._urls.account_id(), headers=headers)
        result = response.json()
        if result['success'] :
            self.zone_var = str(result['data'][0]['rzone'])
            # id = str(result['data'][0]['secAccountId']) # Cash Account
            id = str(result['data'][1]['secAccountId']) # Margin Account
            print(str(result['data']))
            self._account_id = id
            return id
        else:
            return None

Interesting. Mine looks a little different:
`    def get_account_id(self, id=0):
'''
get account id
call account id before trade actions
'''
headers = self.build_req_headers()
    response = requests.get(self._urls.account_id(), headers=headers, timeout=self.timeout)
    result = response.json()
    if result['success'] and len(result['data']) > 0 :
        self.zone_var = str(result['data'][int(id)]['rzone'])
        self._account_id = str(result['data'][int(id)]['secAccountId'])
        return self._account_id
    else:
        return None

`
setting "id=0" to "id=1" does make it successfully place a trade to the margin account. BUT - i'm still getting an error from the request.push in place_option_order, even though the trade was successfull placed. Here's the json and the resp code:
{'msg': 'The system is busy', 'code': 'trade.system.exception', 'data': {}, 'success': False} 500
I guess i'm good now that its actually placing the order. Very confused as to why it's throwing an error though.

{'msg': 'The system is busy', 'code': 'trade.system.exception', 'data': {}, 'success': False} 500
I guess i'm good now that its actually placing the order. Very confused as to why it's throwing an error though.

I've also been getting the "The system is busy" but it seems like my options orders aren't going through. Have you found a workaround or reason to this message? Can you share a test snippet to placing an options order?


Keep track of samples used for training a model

We have to setup a workflow in the training methodology that allows to keep track for each trained model on which reference data this model was trained (which location IDs were used).

Depends on #90


#1157 Fixed user modifications of 'User-Agent' http header on requests

The details are here:
https://github.com/dropwizard/dropwizard/issues/1157
https://groups.google.com/forum/#!topic/dropwizard-user/XmSTpzz8Xx8
This commit is a part of UpWork.com initiative to maintain the 0.8.x
branch. The details about it are here:
https://groups.google.com/forum/#!topic/dropwizard-dev/hlK_Wi_2jis

Sorry one last thing, can you please use 4 spaces for indentation instead of tabs?  It looks like tabs in the PR.

Is there anyway to provide a test for this so its not broken in the future?

LGTM. Thanks for adding the test cases!


Prohibit Object methods being called through IPC

Motivation
IPC expects only methods defined in a custom IPC interface to be called, but it does not account for all other methods defined in an IPC handler. For this reason, it is possible to execute methods that exist in the IPC handler but are not intended to be called from the frontend. This includes all methods inherited from the Object and any methods defined as private in TypeScript code.
This could be exploited by malicious party to weaken security (work item for more details).
Changes
Changes in this PR prevent methods inherited from Object class (e.g.: toString, __defineSetter__) from being called through IPC.
It would be great to also prohibit private methods in custom IPC handlers from being callable, but it's not possible, since, if they are defined private in TypeScript, this information is not available during runtime. Added a recommendation to the documentation to either remove private methods from IPC handlers or define them as JavaScript private properties.

Your PR description should specify why you want to do this.

Updated description.


feat: Update completion API Message type

[x] I have looked for existing issues (including closed) about this

Feature Request
Update the completion::Message type to reflect new features in popular model providers.
Note: this would solve #121 and offer limited multimodal support in the case where text completion models accept images as input.
Motivation
Many popular completion model providers have expanded their APIs to support different types of message. For instance, OpenAI now supports the tool message type and has added the ability to upload images using the user message type. Anthropic also supports uploading images using the user message type.
Supporting these advanced features would make Rig a lot more flexible.
Here is a (non-exhaustive) list of providers and the message types we currently do not support:

OpenAI: tool messages, tool_calls in assistant messages and images in user messages
Anthropic: images in user messages and ToolResult as a message content type
Cohere: tool message and tool_calls in assistant messages

Proposal

Refactor the completion::Message type such that is more complete, e.g. using an enum:
pub enum Message {
    UserMessage(...),
    AssistantMessage(...),
    SystemMessage(...),
    ToolMessage(...),
}

Note: Make sure that the new Message type covers all possible types across all providers.

Update the provider client implementations to covert the new Message type to their own completion model.
❗ Important: It is important to handle the case where the provider does not support a given message type (e.g.: Anthropic does not support the tool message type). There are two options to handle those cases: 1) return an error; 2) convert them to another type that makes sense (e.g.: converting the ToolMessage to a user type message for Anthropic). Not all types can be converted though. For instance, if a provider does not support an image user message, then the client should return an error.

Alternatives
An alternative could be to add an additional_params field to the existing Message type allowing users to provide additional parameters on a per-provider basis, similar to how additional_params is available on CompletionRequest.

i'm not using rig as i'm using my own llm library because i need something custom built.
i was curious about it though.
however, i think it's better to have the message content with a Role enum that has a Custom(String) field in case you want a custom role.
this way you can also impl Display for role to pretty print it, but you could add your own function to it ie as_openai where it'd format it to chat completion role etc...
my message struct looks something like that
#[derive(Debug, Clone)]
pub struct Message {
    pub role: Role,
    pub message: String
}

role code looks this way
#[derive(Clone, Debug)]
pub enum Role {
    User,
    Assistant,
    System,
    Root
}

impl std::fmt::Display for Role {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Role::User => write!(f, "User"),
            Role::Assistant => write!(f, "LLM"),
            Role::System => write!(f, "SYSTEM:"),
            Role::Root => write!(f, "Root:")
        }
    }
}

impl Role {
    pub fn as_openai(&self) -> String {
        match self {
            Role::User => "user".into(),
            Role::Assistant => "assistant".into(),
            Role::System => "system".into(),
            Role::Root => "root".into()
        }
    }
}

i didn't need the custom Field, but i may add one later and one for context too !
this way you can also implement display and as_openai for Message.


initial work on usb camera, and bit of psbt

Just a start of using opencv to handle reading from a USB camera. I'll need to add additional things in order to select between either the PiCam or the USB cam.

@sako0938 can you put a timer on the cv2 import? If I remember right, that was the main reason why our camera startup time was originally so slow. It was so bad that it was originally stuffed into its own thread.
see: https://github.com/SeedSigner/seedsigner/commit/a53359b998bd5b951f1717ce30332e29f3daea28
In that commit it was the imutils import that was causing it, but I think the imutils internals were doing a cv2 import.
A lot of work has gone in to speed up the camera handling as much as possible. If a slow import is necessary to support this alternate hardware, the code has to be isolated off so that it's only imported when needed.
(the question of whether it's the right time to support other camera options is a separate discussion. Preview: I'm a bit skeptical; KISS principle is very strong right now)
Here was a simple timing test I did. Note that you have to restart your REPL after each run as the already-imported library is cached at that point.
>>> import time
>>>
>>> def time_import():
...     start = int(time.time() * 1000)
...     from seedsigner.helpers.pivideostream import PiVideoStream
...     # from imutils.video.pivideostream import PiVideoStream
...     end = int(time.time() * 1000)
...     print(end - start)
...
>>> time_import()
2513
>>> def time_import():
...     start = int(time.time() * 1000)
...     # from seedsigner.helpers.pivideostream import PiVideoStream
...     from imutils.video.pivideostream import PiVideoStream
...     end = int(time.time() * 1000)
...     print(end - start)
...
>>> time_import()
17493

I will check out the imort time stuff. It seemed pretty fast to me, but I am running on the 3A+ which is much faster than the Zero. Ill need to get a soldering iron so I can make use of the zero's I have.
I understand your KISS desire, I just wanted to do this and it seemed easy enough to do.
No need to get this merged in anytime soon, Ill keep it updated as I keep playing.

@sako0938 in that case can you flip this PR to a DRAFT? I think the PR author should be able to do that. I'd also separate the PSBT timing change out of this PR and into its own. @newtonick would need to take a closer look at that. He's tuned the QR  codes pretty carefully though, so I'm guessing he has pretty specific reasons for the current timings.

Will do. Yeah I imagine they are well timed. I could not for the life of me get Specter Desktop to read the QR codes from seedsigner, so was just playing.

Wonder if enabling a USB camera could be an opt-in setting? We've been kicking around the idea of "expert" settings, and it might fall under that umbrella, just a thought.

I was thinking about using an environment variable to be able to select between the two camera options for now.
I haven't tried having both types of cameras instead and seeing how they enumerate
/dev/video0
/dev/video?

I think this is an interesting idea to add USB camera support to SeedSigner. I like the idea of making a fallback option if the pi camera is not detected/enabled.
I did some testing of this PR and this is what I found:

Performance of initializing the camera seems good. Slightly slower maybe, but still just a second or 2 on a pi0.
Crashed when generating seed from image:

Traceback (most recent call last):
  File "main.py", line 16, in <module>
    controller.start()
  File "/home/pi/seedsigner/src/seedsigner/controller.py", line 86, in start
    self.show_main_menu()
  File "/home/pi/seedsigner/src/seedsigner/controller.py", line 126, in show_main_menu
    ret_val = self.show_create_seed_with_image_tool()
  File "/home/pi/seedsigner/src/seedsigner/controller.py", line 254, in show_create_seed_with_image_tool
    (reshoot, seed_phrase) = self.seed_tools_view.seed_phrase_from_camera_image()
  File "/home/pi/seedsigner/src/seedsigner/views/seed_tools_view.py", line 1191, in seed_phrase_from_camera_image
    View.DispShowImageWithText(frame, "click joystick", text_color=View.color, text_background=(0,0,0,225))
  File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 142, in DispShowImageWithText
    View.DispShowImage(image_copy, alpha_overlay=text_overlay)
  File "/home/pi/seedsigner/src/seedsigner/views/view.py", line 95, in DispShowImage
    image = Image.alpha_composite(image, alpha_overlay)
  File "/home/pi/.local/lib/python3.7/site-packages/PIL/Image.py", line 2988, in alpha_composite
    return im1._new(core.alpha_composite(im1.im, im2.im))
ValueError: images do not match

Black vertical bars in image preview (not a square aspect ratio for the image)

These things at a minimum should be resolved before merging.

Removed some of the non-usb camera related stuff, will look into the other issues in a bit also!

Stale PR and outstanding issues


exec('nohup node some.js &')

Not sure if its a bug rather question.

node - 5.10.0
shelljs - ^0.6.0
os - OS X 10.11.4

Can I do something like:
// index.js
require('shelljs/global');
const path = require('path');
const target = path.join(process.cwd(), process.argv[2])
exec('nohup node ./watcher.js ' + target + '&');

// watcher.js
const fs = require('fs');

function watch(dir) {
  fs.watch(dir, (event, filename) => {
    if (filename) {
      // do something
    }
  });
}

watch(process.argv[2]);

node src/index.js ./test/fixtures

I expect the index.js to terminate and on ps -ef | grep watcher to find the process corresponding to watcher.js listed
In practice it doesn't. Is it by design?

Hi @sarbbottam,
For me this is resulting in index.js never exiting, is the same happening for you?
I'm not really sure why that's happening. @nfischer, you know a lot more about unix than me, any ideas?

For me this is resulting in index.js never exiting, is the same happening for you?

Yes
If I use const exec = require('child_process').exec; instead of require('shelljs/global'); it works for me.
as suggested in this gist

Should this be closed? Seems like a legitimate bug, no?

@kevin-smets thanks for following up on this issue.
However, this is not a ShellJS bug. child_process.execSync() and child_process.exec() both have the same issue, so there's nothing we can do here (our .exec() is built upon those).
For this specific example, here's some thoughts:

Use child_process.fork() instead. This is much safer and more robust for executing other scripts asynchronously

This is cross-platform. The example above is unix-only (depends on nohup and &)
This works even if your version of node is installed under a different name (e.g. nodejs on Ubuntu)
You're safe from shell expansions you might not expect and other security risks

Why do you really want to start a process without waiting for it to finish?

If you really want to start a job and continue using your shell, why not invoke it yourself with a & on the end?
If you want your program to start a job in the background while it runs, async (like .fork() above) should be sufficient
When your program has finished doing useful work, it can clean up responsibly and kill the child process with .kill(). Otherwise, you've got processes running around on their own on your system (yikes!)

I went with spawn since it was an actual command, not a module I need to have running in the background. I tried shelljs + & first, then nohup which was certainly not my preference because of what you mentioned. Thanks for the explanation!

Another option is:
const { spawn } = require('child_process')
spawn( command, args, { detached:true, stdio:'ignore' }).unref()

Or  stdio:'inherit', for terminal io.


Failed to Build Mixtral-8x7b Engine Because of Insufficient Memory

Building the engine inside the docker container, I got insufficient memory issue.
python ../llama/build.py --model_dir ./Mixtral-8x7B-instruct-v0.1 --use_inflight_batching --use_gpt_attention_plugin float16 --e
nable_context_fmha --use_gemm_plugin float16 --world_size 8 --tp_size 8 --output_dir ./trt_engines/mixtral/TP --parallel_build
Got following errors:
[01/08/2024-17:57:31] [TRT] [E] 4: [pluginV2Builder.cpp::makeRunner::519] Error Code 4: Internal Error (Internal error: plugin node LLaMAForCausalLM/layers/0/mlp/PLUGIN_V2_MixtureOfExperts_0 requires<PHONE_NUMBER>568 bytes of scratch space, but only<PHONE_NUMBER>0 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
)
[01/08/2024-17:57:31] [TRT-LLM] [E] Engine building failed, please check the error log.
[01/08/2024-17:57:31] [TRT-LLM] [I] Config saved to ./trt_engines/mixtral/TP/config.json.
Traceback (most recent call last):
File "/code/tensorrt_llm/examples/mixtral/../llama/build.py", line 934, in
build(0, args)
File "/code/tensorrt_llm/examples/mixtral/../llama/build.py", line 880, in build
assert engine is not None, f'Failed to build engine for rank {cur_rank}'
AssertionError: Failed to build engine for rank 0
I am using Nvidia A100 80GBx4

I also had this problem in newest code I used the suggest command :
python3 ../llama/build.py --model_dir /workspace/models/Mixtral-8x7B-v0.1/ --enable_context_fmha --use_gemm_plugin --world_size 2 --tp_size 2 --use_inflight_batching  --output_dir /workspace/models/trt-engine/Mixtral_tp2/ --parallel_build
and the error is
[01/09/2024-06:30:53] [TRT] [E] 4: Internal error: plugin node LLaMAForCausalLM/layers/0/mlp/PLUGIN_V2_MixtureOfExperts_0 requires<PHONE_NUMBER>936 bytes of scratch space, but only<PHONE_NUMBER>0 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
[01/09/2024-06:30:53] [TRT] [E] 4: [pluginV2Builder.cpp::makeRunner::519] Error Code 4: Internal Error (Internal error: plugin node LLaMAForCausalLM/layers/0/mlp/PLUGIN_V2_MixtureOfExperts_0 requires<PHONE_NUMBER>936 bytes of scratch space, but only<PHONE_NUMBER>0 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
)
[01/09/2024-06:30:53] [TRT-LLM] [E] Engine building failed, please check the error log.
[01/09/2024-06:30:53] [TRT-LLM] [I] Config saved to /workspace/models/trt-engine/Mixtral_tp2/config.json.
[01/09/2024-06:30:54] [TRT] [I] [GraphReduction] The approximate region cut reduction algorithm is called.
[01/09/2024-06:30:55] [TRT] [I] Detected 74 inputs and 35 output network tensors.
^@[01/09/2024-06:30:59] [TRT] [E] 4: Internal error: plugin node LLaMAForCausalLM/layers/0/mlp/PLUGIN_V2_MixtureOfExperts_0 requires<PHONE_NUMBER>936 bytes of scratch space, but only<PHONE_NUMBER>0 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
[01/09/2024-06:30:59] [TRT] [E] 4: [pluginV2Builder.cpp::makeRunner::519] Error Code 4: Internal Error (Internal error: plugin node LLaMAForCausalLM/layers/0/mlp/PLUGIN_V2_MixtureOfExperts_0 requires<PHONE_NUMBER>936 bytes of scratch space, but only<PHONE_NUMBER>0 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
)
[01/09/2024-06:30:59] [TRT-LLM] [E] Engine building failed, please check the error log.
Traceback (most recent call last):
File "/workspace/TensorRT-LLM/examples/llama/build.py", line 930, in
mp.spawn(build, nprocs=args.world_size, args=(args, ))
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 246, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method="spawn")
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 202, in start_processes
while not context.join():
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 163, in join
raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:
-- Process 0 terminated with the following error:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/torch/multiprocessing/spawn.py", line 74, in _wrap
fn(i, *args)
File "/workspace/TensorRT-LLM/examples/llama/build.py", line 880, in build
assert engine is not None, f'Failed to build engine for rank {cur_rank}'
AssertionError: Failed to build engine for rank 0

I had tried,the tag v0.7.1 had no problem but the main had problem

The same question, how to solve the problem in main branch?

we met the same issue using V100 for v0.7.1 (no problem using A100):
[2024-02-04 18:22:28] [02/04/2024-10:22:28] [TRT] [E] 4: Internal error: plugin node LLaMAForCausalLM/layers/0/attention/PLUGIN_V2_GPTAttention_0 requires<PHONE_NUMBER>68 bytes of scratch space, but only<PHONE_NUMBER>4 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
[2024-02-04 18:22:28]
[2024-02-04 18:22:28] [02/04/2024-10:22:28] [TRT] [E] 4: [pluginV2Builder.cpp::makeRunner::519] Error Code 4: Internal Error (Internal error: plugin node LLaMAForCausalLM/layers/0/attention/PLUGIN_V2_GPTAttention_0 requires<PHONE_NUMBER>68 bytes of scratch space, but only<PHONE_NUMBER>4 is available. Try increasing the workspace size with IBuilderConfig::setMemoryPoolLimit().
[2024-02-04 18:22:28] )
[2024-02-04 18:22:28] [02/04/2024-10:22:28] [TRT-LLM] [E] Engine building failed, please check the error log.

Hi @Jeevi10 please feel free to reopen this ticket if needed.


Correct record test in vm

Use len instead of tag for verify record with 0 field.

Yep, that was wrong, thanks!
bors r+


Several parameters are missing

Windows PowerShell reports that Get-WindowsCapability has the following parameters. The three, which I have highlighted in boldface are missing from the correspond documentation page (see below).

LimitAccess
Source
Verbose
LogLevel
LogPath
Name
Online
Path
ScratchDirectory
SystemDrive
WindowsDirectory

Update (2018-11-07): Improved description of the issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 551eb88d-11fd-5d28-1a91-d0c4246967ac
Version Independent ID: c7023233-2a92-7382-d55e-a393f84c6539
Content: Get-WindowsCapability (dism)
Content Source: docset/windows/dism/get-windowscapability.md
Product: w10
GitHub Login: @brianlic-msft
Microsoft Alias: brianlic

I suppose this can be closed as with the following versions everything shows as documented.
PS C:\WINDOWS\system32> $PSVersionTable
Name                           Value

PSVersion                      5.1.17134.228
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.228
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
PS C:\WINDOWS\system32> (get-command -Name "Get-WindowsCapability").Parameters.Keys | sort
Debug
ErrorAction
ErrorVariable
InformationAction
InformationVariable
LimitAccess
LogLevel
LogPath
Name
Online
OutBuffer
OutVariable
Path
PipelineVariable
ScratchDirectory
Source
SystemDrive
Verbose
WarningAction
WarningVariable
WindowsDirectory

@3ter With all due respect, when I wrote "the missing ones", I meant "missing from the documentation page on which I am providing feedback", i.e. missing from docset/windows/dism/get-windowscapability.md. They are undocumented.

@skycommand Thanks for the hint. I've shortened my inconsiderate comment.

@skycommand Thank you for providing valuable feedback. We are looking into this documentation issue and will release a fix soon.

@skycommand  With the help of your feedback, the issue has been reviewed and an update to the documentation has been published. Thanks for your feedback.

@officedocsbot close

@e0i Hi. I am seeing your PR #747. Please do note that -Source requires extensive descriptions to help system administrators understand what constitutes a valid source. I've been struggling with this PowerShell cmdlet for a long time now.


Create youtubelist.txt

Hi @georgesaumen , can I know why you want this change? Are you trying to block youtube?
BTW, if you want to add blocklist, you also need to add entry into /data/configuration.yaml


Bug fixes, bullet collisions, Gregory jump

Some bug fixes
Gregory can now jump
Enemies movement can now be limited
Enemies can be killed with bullets

This can now be merged with master.

Fixed the conflicts :)


Route::namespace('') implementation ?

Q
A

Bug?
no

New Feature?
yes

Framework
Laravel

Framework version
5.5.*

Package version
2.0.0-alpha1

PHP version
7.2.1

Hello,
Can you implement namespace routing like laravel 5.5 :
Route::namespace('Admin')->group(function () {
    // Controllers Within The "App\Http\Controllers\Admin" Namespace
});

url :
https://laravel.com/docs/5.5/routing#route-group-namespaces

Already implemented!

But the docs does not describe how to do

@loic-lopez It does just like it does in Laravel, just that Laravel moved to the syntax you describe (but the old one still works).
        $api->group(['prefix' => 'payouts'], function (Router $api) {});

@specialtactics prefix & namespace are two differents features.
$api->group(['namespace' => 'App\Http\Controllers\Admin', 'prefix' => 'admin'], function (Router $api) {});

Ah yeh sorry.
Point is the same though, you can pass all the static options as parameters in the old style, and it should work.


codecov

Current coverage is 94.44% (diff: 100%)

No coverage report found for master at 7045504.

Powered by Codecov. Last update 7045504...f7944c3


Reviewing workflow

Before issuing the newest version...
Cleanup of the repo
New branch workflow :

Features added as feature branch -> ex. feature/my_new_idea
Stage becomes develop
Master keeps its importance as the stable version

We'll try to stick to this model
http://nvie.com/posts/a-successful-git-branching-model/
I apologize right now for every future mistakes I will make :-)

We are trying our best to follow that


Pass request headers to bot

When using Bots to receive webhooks from 3rd party services, useful information can be passed in the webhook header. For example, signature verification information: https://docs.photon.health/docs/webhook-signature-verification.
Proposal
Add a new field to BotEvent, event.headers that collects all the headers passed to the call to Bot/$execute

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


Refactor index as special kind of storage

This would mean we must represent paths and ids as a Monoid structure somehow.

Deletes would be handled if we implement #58


Why use conda ?

Why Conda is not installed in usual path ?
Did I have to export Conda each time I want to use it ?

Why Conda is not installed in usual path ?
The Conda path choice is left to the user.
Refers to the documentation for more details.
You can uninstall Conda and re-install it if you want to change its path.
Did I have to export Conda each time I want to use it ?
Is your question related to the
export PATH=<CONDA_PREFIX>/bin:${PATH}

command line to type (with <CONDA_PREFIX> replaced by the Conda installation directory) ?
If it is the case, you can add this line at the end of the ${HOME}/.bashrc file to add Conda in your path.
Nevertheless I do not recommend it.
On newer Conda versions, you can add the
source <CONDA_PREFIX>/etc/profile.d/conda.sh

in the ${HOME}/.bashrc file (with <CONDA_PREFIX> replaced by the Conda installation directory).
This is the best way to ease the usage of Conda since:

The conda activate command will be available in your terminal,
All other commands defined in the bin  directory of the Conda base environment will not be available unless you explicitly typeconda activate

:warning: For this answer, I assumed that a Linux OS is used.


Cannot close stdin when connected to docker swarm cluster using "docker run" with TLS.

When I just connected to normal docker server, stdin is closed as expected.
But, when I connected to docker swarm cluster, stdin is not closed and "docker run" never exit.
$ eval $(docker-machine env master)
$ echo aaa | docker run -i ubuntu cat |grep aaa
aaa
$ eval $(docker-machine env --swarm master)
$ echo aaa | docker run -i ubuntu cat |grep aaa
aaa
^C^C^C^C
^C^C^C^C
^C^C^C
Connection to docker.paiza.io closed.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

docker version:
Client:
Version:      1.9.0
API version:  1.21
Go version:   go1.4.2
Git commit:   76d6bc9
Built:        Tue Nov  3 17:43:42 UTC 2015
OS/Arch:      linux/amd64
Server:
Version:      swarm/1.0.0
API version:  1.21
Go version:   go1.5.1
Git commit:   087e245
Built:
OS/Arch:      linux/amd64
docker info:
$ docker info
Containers: 22
Images: 3
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 1
master: <IP_ADDRESS>:2376
└ Containers: 22
└ Reserved CPUs: 0 / 1
└ Reserved Memory: 0 B / 1.018 GiB
└ Labels: executiondriver=native-0.2, kernelversion=3.13.0-53-generic, operatingsystem=Ubuntu 14.04.2 LTS, provider=amazonec2, storagedriver=aufs
CPUs: 1
Total Memory: 1.018 GiB
Name: 873b02fada2d
uname -a:
$ uname -a
Linux ip-172-30-1-65 3.13.0-65-generic #106-Ubuntu SMP Fri Oct 2 22:08:27 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
Provide additional environment details (AWS, VirtualBox, physical, etc.):
AWS
List the steps to reproduce the issue:

"docker run" to normal node, and it exit as expected.
$ echo aaa | docker run -i ubuntu cat |grep aaa
aaa

"docker run" to swarm cluster, and it never exit.
$ echo aaa | docker run -i ubuntu cat |grep aaa
aaa
^C^C^C^C
^C^C^C^C
^C^C^C
Connection to docker.paiza.io closed.

Describe the results you received:
"docker run" never exit when stdin is closed.
Describe the results you expected:
"docker run" exit when stdin is closed.

And, it turned out that the never exiting issue happens only on TLS mode with swarm(docker-proxy), and does not happen without TLS, or direct connection to docker node (with/without TLS).

Also, it turned out that normal docker daemon implement CloseWrite() function for half close and use own "dial"("tlsDial") instead of "crypt/tls"'s "Dial" function.
https://github.com/docker/docker/blob/master/api/client/hijack.go
How about using the same "dial" implementation at the swarm module ?

Closing since this is a swarm issue.
Thanks!


Improve code in example.md

Incremented secondsPlayed by 1 instead of 5 every second. Replaced :IsDescendantOf(game) with :IsDescendantOf(Players) for readability.

I'm also not sure why there's a variable for ReplicatedStorage, but I'm going to assume that's for if people put keyForm in ReplicatedStorage.

Problem was solved


src: Fix usage/help text for -b/-t flags for ppm install

These flags do not actually take commit SHAs as arguments, only branch or tag names.
The flags are aliases of one-another and work the exact same -- either flag can take a branch name or tag name. No SHAs.

macOS CI failure is unrelated, it's the "old node-gyp, new Python" issues again.
I have to review how we worked around these things in CI for other repos. Wanted to get this PR out quickly, will have to come back around to fixing CI here soon.

Just to add for posterity's sake, the docs look correct here: https://pulsar-edit.dev/docs/launch-manual/sections/using-pulsar/#command-line
It doesn't say a commit hash can be used:
pulsar -p install <git_remote> [-b <branch_or_tag>]


E2E: onboarding and desktop sounds

Summary
Centrally disable onboarding instead of having to do this in each spec. Also, disable desktop sounds since the CircleCI servers spam errors here and it's annoying getting them locally when testing manually.
Ticket Link
N/A
Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[ ] Unit tests updated

/update-branch

/update-branch


Users not visible in FusionDirectory when PLUGIN_MAIL is set to TRUE

SITUATION
I use docker-compose with the following plugins activated.
      - PLUGIN_AUDIT=TRUE
      - PLUGIN_LDAPMANAGER=TRUE
      - PLUGIN_PERSONAL=TRUE
      - PLUGIN_PPOLICY=TRUE
      - PLUGIN_SSH=TRUE
      - PLUGIN_USER_REMINDER=TRUE

With this, I can create users and view users in FusionDirectory
COMPLICATION
When I add the mail plugin, all the users disappear in FusionDirectory (log is available as attachment)
      - PLUGIN_MAIL=TRUE

NOTES
Importing the schema manually puts everything in order:
sudo docker exec -it openldap-home-lan-app /bin/bash
cd /etc/openldap/schema/fusiondirectory
fusiondirectory-insert-schema -i mail*.schema

Consequently, I think there is an issue in the installation of PLUGIN_MAIL

Thanks I will look into this one. Mail is an interesting plugin as it has some dependencies that need to be installed ahead of time and in recent versions they may have changed around the order.

This bug exists in 2022


Chrome no headless option

it might be nice to have the possibility for the build to choose a non-headless for some usecases

Non-headless is not supported by Docker.
If you want to use Worker with open Chrome, you need to run the browser locally with open debugging port and let the Worker to connect to it.

um, i thought something was playable with xvfb
okok 🤔

ok, I'm taking my words back. Yes, it's possible to use xvfb for that.

Can you add it to the base Image?

Hey ! Sadly not for the moment, I'm stuck on this :

https://github.com/siomiz/chrome/issues/26
https://forums.docker.com/t/docker-chrome-headfull-with-xvfb-and-remote-debugging-active-dbus/108202

Everything start but chrome api couldn't be called 🤔
I've stoped my research on this last answer :

https://stackoverflow.com/questions/49285658/how-to-solve-docker-issue-failed-to-connect-to-bus-no-such-file-or-directory

Maybe i'm missing something 🤷♂
If you want to test i probably have my test branch somewhere based on https://github.com/siomiz/chrome , ping me on discord

For these reasons I began to study concealing a headless chrome based on https://github.com/paulirish/headless-cat-n-mouse, with an MITM docker before page explorer interpretation. This allow us JS injection to bypass client side headless detection. The cat n mouse race to hide headless is not ended, but we should share it. I've added you to my private repo example, we could integrate it as an option in worker or side by side.
Actually my example success on this test : https://intoli.com/blog/not-possible-to-block-chrome-headless/chrome-headless-test.html
More informations : https://intoli.com/blog/not-possible-to-block-chrome-headless/
(I've added an fql example on discord to test chrome based on intoli test)

Take a look at: https://github.com/jvitor83/chrome-debug-node-vnc
It is a built-in chrome with debug capabilities and VNC for remote viewer and node to use puppeteer. In some testing it isn't detected as a bot because it is headfull (but inside docker container).

@PierreBrisorgueil hey, have you managed to create a Docker image with non-headless Chromium?

Nop, I set up a MITM to hide the headless with multiple JS tricks, but I still haven't managed to make the headfull in docker.
I also wanted to watch how they handled the head full on the crawlee side

@ziflex have you deep dive the subject ?

Take a look at: https://github.com/jvitor83/chrome-debug-node-vnc
It is a built-in chrome with debug capabilities and VNC for remote viewer and node to use puppeteer. In some testing it isn't detected as a bot because it is headfull (but inside docker container).

works, thx


Google terms of service

Closes #[issue number]
Description

Screenshots

Release notes

Notes:

https://github.com/Mokenadoa/action-toolkit/invitations


19 vulnerabilities (16 moderate, 2 high, 1 critical) in Windows

Current
When I run npm install on my windows 10 machine I get this warning.

After
When I run npm audit fix it makes changes to package-lock.json and it takes the vulnerabilities down to 13 👇

@colebemis Should I make a PR for the updated package-lock.json ?

Should I make a PR for the updated package-lock.json?

@zaaakher yes please!

Done 👍


dsp/window: new package for functions to control spectral leakage of FFT

Good afternoon!
Please take a look.
According to issue #1223
package placed to: gonum/dsp/window/
window functions placed to: window.go and window_complex.go
package documentation placed to: doc.go
tests placed to: window_test.go and window_complex_test.go
examples for each float64 function and example of using fft.Coefficients with functions of this package placed to: window_example_test.go
there is no examples for complex value, because there is no big difference to float case.

Good day! May be i should do some corrections?

Sorry. GitHub doesn't send notifications on pushes. So we won't see that a new review is needed until you ping us.

Tried to consider everything. Please take a look at this. I had my doubts about how best to present the formulas. So far, I've put it right in the text.
While I was preparing the documentation, I was looking for a source for references, because the one I was working on was not in English. It turned out that in most sources, for the Flat-top window, there are other coefficients, so i'v corrected it. However, the window quality parameters were correct - I checked.
I chose the site where all the windows I listed and their quality parameters are presented as the source. Their composition did not seem so convenient to me, so I left the one I had.
Frankly speaking, I would prefer to implement an auxiliary function that evaluates window parameters. This would allow you to add new windows while remaining in the same window quality coordinate system. However, this requires fft with the number of bins greater than the defined by signal composition. This has not been implemented at the moment.

You'v resolved your question, so i'll answer here about:

The details for the spectral leakage paramters are not clear to me. Can you point me to where the information is coming from? They are particularly confusing because the parameters given here don't concord with the descriptions in the linked pages.

I took it from here: http://www.dsplib.ru/content/win/win.html.
The text is on Russian, but the sense is pretty obvious.
β - from figure 6 and formulas 2-6.
ΔF_0, ΔF_0.5, ɣ_max - from figure 7.
K_window = ΔF_0_window/ΔF_0_rectangular.

When you're ready, can you also send a PR with the commit message "A+C: add Andrei Blinnikov", adding yourself to the AUTHORS and CONTRIBUTORS files (I plan to squash this PR, and that should be separate).

Thank you, this looks good to me.
Please send a PR adding yourself to A+C and then I'll squash and merge this just before that.

Thank you for review.

No, please make another PR branched from master. Unfortunately, GitHub doesn't have an interactive rebase or cherry pick merge strategy. I'll squash all of these and then merge the other PR separately.

needs https://github.com/gonum/gonum/pull/1239


Fix saturation property value to match actual saturation gained - Fixes #1418

I went over this in more detail in https://github.com/SpongePowered/SpongeCommon/issues/1418
But essentially the SaturationProperty value is the internal one that Mojang uses for what seems like no apparent reason as they just multiply it by the food value and by 2 when applying it to the player. To allow this property to accurately display the saturation the player will gain from the food, I added this calculation to the saturation property store.
To show this with some actual numbers and food, with the following code:
@Listener
public void onRightClick(InteractItemEvent event, @First Player player) {
    final Optional<SaturationProperty> saturationProperty = event.getItemStack().getProperty(SaturationProperty.class);
    if (saturationProperty.isPresent()) {
        player.sendMessage(Text.of("Saturation value for " + event.getItemStack().getType().getId() + ": " + saturationProperty.get().getValue()));
    } else {
        player.sendMessage(Text.of("No saturation property."));
    }
}

Clicking with the following items before this change returned this values:

Now after this change returns these values:

Which match the saturation gained and what the Minecraft wiki states:
Raw rabbit:

Cooked chicken:

Raw porkchop:

As a whole, this is still a proposal, but I do believe this change should be made unless I am missing something. This way the actual amount of saturation of a food can be accurately retrieved and other SpongeAPI implementations don't have to use Mojang's strange/unnecessary math in the first place.

I didn't really I had this in my bleeding branch. I will fix it :L


Visual Design in Figma for Dialog-Bubble

Visual design for a New Dialog-like component that has a carrot pointing to it's point of origin.
-No divider at footer
-No application title
-Title needs to clear close button in top right
Styles
-Default styling similar to dialog
Themes
-Light
-Dark
-Color
Variations
-Carrot needs to be adaptable based on the location it's pointing
Acceptance

[ ] Visual Design Spec submitted (link)
[ ] Visual Design Spec reviewed by design team
[ ] Visual Design Spec reviewed by dev team

Design is complete and reviewed by UX + Nimble Dev team.
Status: Pending meeting with Dev Stakeholder on client team for approval.  Additional Documentation may be required.


Update REPORT_TEMPLATE.md

Adjusted the image format

Do we need HTML style image block? I think Markdown image in new line is enough for the report. WDYT?

The images here are not the same size and need to be in this format

OK, understood

/approve


[FEA] Explore CollectLimit use in DPP queries on Databricks

This is a follow-on issue from the work in #11750, which fixes the test failures in aqe_test.py pertaining to DPP on Databricks 14.3.
We found a condition where Databricks seems to insert a CollectLimit (with a very large collection limit) on a join query, with DPP enabled.
Here's the query (paraphrased from aqe_test.py:: test_aqe_join_with_dpp):
with tmp as
(SELECT
   site_id, day, test_id
 FROM infoA
 UNION ALL
 SELECT
   CASE
     WHEN site_id = 'LONG_SITE_NAME_0' then 'site_0'
     WHEN site_id = 'LONG_SITE_NAME_1' then 'site_1'
     ELSE site_id
   END AS site_id, day, test_spec AS test_id
 FROM infoB)
 SELECT *
 FROM tmp a JOIN tests b ON a.test_id = b.test_id AND a.site_id = b.site_id
 WHERE day = '1990-01-01'
 AND a.site_id IN ('site_0', 'site_1')

The resultant plan looks thus:
+- Project [toprettystring(site_id#6, Some(UTC)) AS toprettystring(site_id)#42, toprettystring(day#5, Some(UTC)) AS toprettystring(day)#43, toprettystring(test_id#7, Some(UTC)) AS toprettystring(test_id)#44, toprettystring(test_id#0, Some(UTC)) AS toprettystring(test_id)#45, toprettystring(site_id#1, Some(UTC)) AS toprettystring(site_id)#46]
   +- BroadcastHashJoin [test_id#7, site_id#6], [test_id#0, site_id#1], Inner, BuildRight, false, true
      :- Union
      :  :- Project [site_id#6, day#5, test_id#7]
      :  :  +- FileScan parquet [day#5,site_id#6,test_id#7] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/myth/PARQUET_DATA/infoA], PartitionFilters: [isnotnull(day#5), (day#5 = 1990-01-01), site_id#6 IN (site_0,site_1), isnotnull(test_id#7), isno..., PushedFilters: [], ReadSchema: struct<>
      :  :        :- SubqueryBroadcast dynamicpruning#53, [0], [test_id#0], true, [id=#322]
      :  :        :  +- AdaptiveSparkPlan isFinalPlan=false
      :  :        :     +- CollectLimit 3000001
      :  :        :        +- HashAggregate(keys=[test_id#0], functions=[], output=[test_id#0])
      :  :        :           +- ShuffleQueryStage 2, Statistics(sizeInBytes=942.0 B, rowCount=34, ColumnStat: N/A, isRuntime=true)
      :  :        :              +- ReusedExchange [test_id#0, site_id#1], GpuColumnarExchange gpusinglepartitioning$(), EXECUTOR_BROADCAST, [plan_id=238], [loreId=17]
      :  :        +- SubqueryBroadcast dynamicpruning#54, [0], [site_id#1], true, [id=#335]
      :  :           +- AdaptiveSparkPlan isFinalPlan=false
      :  :              +- CollectLimit 3000001
      :  :                 +- HashAggregate(keys=[site_id#1], functions=[], output=[site_id#1])
      :  :                    +- ShuffleQueryStage 4, Statistics(sizeInBytes=942.0 B, rowCount=34, ColumnStat: N/A, isRuntime=true)
      :  :                       +- ReusedExchange [test_id#0, site_id#1], GpuColumnarExchange gpusinglepartitioning$(), EXECUTOR_BROADCAST, [plan_id=238], [loreId=17]
      :  +- Project [CASE WHEN (site_id#15 = LONG_SITE_NAME_0) THEN site_0 WHEN (site_id#15 = LONG_SITE_NAME_1) THEN site_1 ELSE site_id#15 END AS site_id#30, day#14, test_spec#12 AS test_id#31]
      :     +- Filter isnotnull(test_spec#12)
      :        +- FileScan parquet [test_spec#12,day#14,site_id#15] Batched: true, DataFilters: [isnotnull(test_spec#12), dynamicpruningexpression(test_spec#12 IN dynamicpruning#53)], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/myth/PARQUET_DATA/infoB], PartitionFilters: [isnotnull(day#14), (day#14 = 1990-01-01), CASE WHEN (site_id#15 = LONG_SITE_NAME_0) THEN site_0 ..., PushedFilters: [IsNotNull(test_spec)], ReadSchema: struct<test_spec:string>
      :              :- ReusedSubquery SubqueryBroadcast dynamicpruning#54, [0], [site_id#1], true, [id=#335]
      :              +- ReusedSubquery SubqueryBroadcast dynamicpruning#53, [0], [test_id#0], true, [id=#322]
      +- ShuffleQueryStage 0, Statistics(sizeInBytes=942.0 B, rowCount=34, ColumnStat: N/A, isRuntime=true)
         +- GpuColumnarExchange gpusinglepartitioning$(), EXECUTOR_BROADCAST, [plan_id=238], [loreId=17]
            +- GpuCoalesceBatches targetsize(1073741824), [loreId=16]
               +- GpuFilter ((gpuisnotnull(test_id#0) AND gpuisnotnull(site_id#1)) AND site_id#1 INSET site_0, site_1), [loreId=15]
                  +- GpuFileGpuScan parquet [test_id#0,site_id#1] Batched: true, DataFilters: [isnotnull(test_id#0), isnotnull(site_id#1), site_id#1 IN (site_0,site_1)], Format: Parquet, Location: InMemoryFileIndex[file:/tmp/myth/PARQUET_DATA/tests], PartitionFilters: [], PushedFilters: [IsNotNull(test_id), IsNotNull(site_id), In(site_id, [site_0,site_1])], ReadSchema: struct<test_id:string,site_id:string>

Note the +- CollectLimit 3000001.  It appears to be the result of pruning (sub)partitions as part of DPP.
It would be good to understand this optimization better, and the expected behaviour if there were more records/partitions than the limit.

I really want to understand a few things about this feature. The main one is that it looks like we might produce an incorrect answer if the aggregation returns more results than the limit allows for. So essentially what is happening is that we have a table that is small enough it is being turned into a broadcast join. That broadcast is then turned into a single partition task through the AQE transition code. It goes through a hash aggregate to get distinct values and those distinct values are then limited and finally sent to the DPP filter.  If that CollectLimit removed some values before it was turned into a new broadcast, then the DPP would produce the wrong answer because we are broadcasting an allow list. If we are missing something that should be allowed we will not read everything we should.
I suspect that the code that reads the data from the collect is looking at how many rows are returned, and if there are too many rows, then it might not do a DPP filter at all (note that they are probably asking for a limit of 3,000,000 rows, and collectLimit itself is adding the 1 extra row so that it can tell if the rows were cut off or not). It does not appear that AQE is looking at the number of rows in the broadcast, as that is only 34, so it would know that the limit is not needed, or might violate something. It also don't think that the code knows the number of partitions in the table and would be limiting things that way (as there is no where near 3 million partitions in this test). But who knows.
I just want to understand it so I know if we need to fix some bugs somewhere to deal with it.
The other question I have really is around performance, and if it is worth us trying to optimize collectLimitExec? We need to convert data back to rows and send it to the CPU so I don't want to write our own collectLimitExec, but We could insert in a GpuLocalLimit in front of it.


how to manually trigger a refresh of the value

Hi,
this an excerpt of my current code:

export class ConnectorsStore {
  constructor(private _orgStore = orgStore) {}

  promisedConnectors = promisedComputed(null, () => {
    return fetch(`${this._orgStore.selectedOrgId}/connectors/`).catch(e => e);
  });
}

and I'm using the promisedConnectors property inside a React component. The function correctly refetches the "connectors" when the selectedOrgId changes.
However I wonder how I can manually reattempt a fetch / invalidate the cache etc.?
This is in particular required in cases where the fetch request failed / errored and the user wants to retry it (via a "retry" button).
Mobx-utils for example has the refresh method on lazyObservable: https://github.com/mobxjs/mobx-utils#lazyobservable which serves a similar purpose.
I was able to get a similar behaviour with promisedComputed with the following code, but I feel it's kind of a hack:
export class ConnectorsStore {
  constructor(private _orgStore = orgStore) {}

  @observable refreshRequests = 0;

  @action.bound
  refresh() {
    this.refreshRequests++;
  }

  promisedConnectors = promisedComputed(null, () => {
    this.refreshRequests;
     return fetch(`${this._orgStore.selectedOrgId}/connectors/`).catch(e => e);
  });
}

In my react component I would have a a button <Button onClick={connectorsStore.refresh}>Retry</Button>.
Is there a cleaner "refresh" solution with promisedComputed possible?
Thanks and Best Regards Christian

Your hack is actually a theoretically correct solution. The refreshRequests is a record of how many times the refresh method has been called, and that fact is what your compute function depends on.
However as this is very common, it's a great idea to add it to the built-in API.

See 3.2.0 and please log any further issues you hit (you are an early adopter of the new API!)

@danielearwicker  you haven't published 3.2.0 on npm

Derp, now I have.


nat: Add GC metrics for removed entries

To better understand how many SNAT entries are GC-ed, we should add Prometheus counter for successful nat.DeleteMapping invocations.

Hi @brb , I am new to this community and would like to contribute to this issue.

Hey @vaibhavmew. I assigned the issue to you. Don't hesitate to reach us on the Cilium slack (#development channel).

hi Can this be assigned to me, please?

@Shuimo03 Sure. Thanks for taking this!

think you!

thanks!

HI, I think this should be added as an exporter that contain GC metrics?

@Shuimo03 Just check how other metrics are used from pkg/metrics.

Sorry, this issue was delayed before due to work issues, I've looked at the previous discussion and I've figured it out, it's to implement a metrics for DeleteMapping using Prometheus, and I think Counter is a good counter to keep track of the number of times a deletion was successful.

Hi, how is the progress of this feature? I read the code about nat and ct GC recently and I would like to work on this.

@brb , created initial review. Can you guide me on how to test these counters on prometheus?


RabbitMQ 3.6.9 - Latest Example project having issues

Hi there, thanks for putting this library together using RabbitMQ and Unity...There are a few problems happening when using the latest RabbitMQ version, 3.6.9. Two things initially... First, the Async call for the RabbitMQ exchanges after connecting never returns. I noticed you tested with an earlier version of Rabbit, I'm wondering if enough has changed for this to fail.. So what happens in the Demo case is that the next two disabled dialog sections are not enabled... If I enter the exchanges manually, along with a Q, it connects ... but then it goes weird again... The next two dialogs are next enabled... so I tried just sending messages through RabbitMQ's web interface... The Unity example project would receive one message fine... but if I posted 2 or more, messages would get lost... only the 3'rd or every other message got through etc.  This is simple RabbitMQ stuff, so I'm guessing this is more to do with the implementation and trying to work with the latest rabbit then it is anything else. Any help you can give would be great, thank you!

As of Unity 5.5.2 the latest compatible version of the RabbitMQ .NET client is 3.4.4 so issue with versions above 3.4.4 are to be expected (above 3.4.4 has dependencies on .NET 4.5 I believe and Unity only supports 3.5 as of 5.5.x). I thought I saw some chatter about .NET 4.6 being available in Unity 5.6.x but I couldn't verify that. Is that what you are trying?
When I have a chance I'll download Unity 5.6.x and see what kind of support is offered. But for now if you want to make sure it works, you'll have to use the 3.4.4 client.

As of Unity 5.5.2 the latest compatible version of the RabbitMQ .NET client is 3.4.4 so issue with versions above 3.4.4 are to be expected (above 3.4.4 has dependencies on .NET 4.5 I believe and Unity only supports 3.5 as of 5.5.x). I thought I saw some chatter about .NET 4.6 being available in Unity 5.6.x but I couldn't verify that. Is that what you are trying?
When I have a chance I'll download Unity 5.6.x and see what kind of support is offered. But for now if you want to make sure it works, you'll have to use the 3.4.4 client.
Edit: Looks like .NET 4.6 support is only in beta/experimental support. I think the goal is to have full support by the end of the year (or some time later this year).

Hello, will there be support for Unity 2020?


build dev failed: Cannot set property 'fileSystem' of null

hello , i've got this error when trying to run : ionic serve

Right now, only with the compatible cli version is possible to run this example locally.
Ionic updated their cli and also their framework. I'm planning on updating this app to the latest version as well. :)


Support gitblit #26

uses pattern configuration code from my NetBeans plugin https://github.com/markiewb/nb-git-open-in-external-repoviewer

@ben-gibson: Please review

Conflicts with your previous commit.

@ben-gibson:  Please review again! I updated most of the requested parts and I force-pushed the PR.

I will take of it this weekend
Den 9 dec. 2016 13:39 skrev "Ben Gibson"<EMAIL_ADDRESS>
@ben-gibson requested changes on this pull request.
Just need the CHANGELOG and plugin.xml conflicts resolved and then we can
merge this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ben-gibson/jetbrains-open-in-git-host/pull/27#pullrequestreview-12219685,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxWRxkMqhQPORaM0bYUpQBlzF3BOaEYks5rGUvkgaJpZM4LEqMj
.

@ben-gibson: I removed the artefacts from the previous merge. The CHANGELOG and plugin.xml is updated now.

This has now been merged through the command line. I made some minor tweaks to the factory.


Is there a way to set the custom message using the function?

I want to display a custom message by using Vue instance following the image below.

After I used it displays the following error message.

Thank You.

Not at the moment, but I take it into account and add it in next release.
Thanks!


Link-local neighbor address fails validation

Describe the bug
Unable to have neighbors with link-local addresses.
Environment

Output from pathvector version:

INFO[0000] Pathvector 5.5.2 commit 4c44c80ed53032dbf9a8b16a9bcc57ae16c0fe88 date 2021-09-12T08:55:22Z

OS version: Debian Bullseye (Debian 11)
Minimum reproducible example of your Pathvector config file formatted with triple backticks for formatting

asn: 213021
router-id: <IP_ADDRESS>
peers:
  home_router:
    asn: 213021
    next-hop-self: true
    allow-local-as: true
    mp-unicast-46: true
    neighbors:
      - fe80:3::2%wg1

To Reproduce
Steps to reproduce the behavior:

Copy this config to pathvector.yml...
Run pathvector -d generate
See error

bird: ./AS213021_HOME_ROUTER.conf:21:43 syntax error, unexpected '%'
FATA[0009] BIRD config validation: exit status 1

Expected behavior
It wouldn't fail validation.

I think that peer on IPv6 with link-local is not supported in pathvector.
Maybe you can assign a Global Addr to that interface and use that?  that way you don't need to specify an interface.

I think that peer on IPv6 with link-local is not supported in pathvector.
Maybe you can assign a Global Addr to that interface and use that?  that way you don't need to specify an interface.

It is now, the only thing missing was a way to tell it that its directly connected peer.

As of fbc927e, Pathvector does support IPv6 link local peering! @samip5 Does that address your issue?

My issue was fixed by 4f537dada31e2c8c723761ba4aec607c75da9386.


is there any indoor scene

Thanks for release the great work, is there any example to generate indoor scene?

No, infinigen does not produce indoor scenes at this time.

On the off chance you mean the cave scenes from the trailer, you can replace desert with cave in any of the hello world commands.