remove syntax

Not a big deal at all, but it might be helpful to have a way to remove a document given just an _id.  Because removes are often done in a meteor method, it can be more efficient to call the method with just an _id and not have to pass a full copy of the object back to the server.  Similarly for cases where all I have is an _id (perhaps from a related record) and haven't yet pulled the whole document.
If I do Posts.remove(id), then any Astronomy beforeremove/afterremove events don't get called.  So I've been doing (new Post({_id:id})).remove(), which seems a bit clunky.  Is there a better way?

If I understand you correctly you would like to minimise the amount of data that is sent over DDP from the client to the server when calling remove method, right?
When sending documents over wire using DDP, the entire object gets EJSON-ified. And I wouldn't mess with that. Of course there are situations (like remove) when you don't need entire object. Id is just enough. What I would suggest is something like this:
// Client/server (or only server).
Meteor.methods({
  'remove': function(id) {
    var post = Posts.findOne(id);
    post.remove();
  }
});

// Client
Meteor.call('remove', post._id);

Yes.  It just seemed that pulling the whole document (FindOne) from the database in order to remove it isn’t very efficient.

Yes indeed, when you have a lot of traffic then sending only id or the whole object can make a difference. So it's good to have a choice. In fact you could even simplify this:
// Client/server (or only server).
Meteor.methods({
  'remove': function(id) {
    Posts.remove(id);
  }
});

// Client
Meteor.call('remove', post._id);

However if you want to soft delete record you should do as follows:
// Client/server (or only server).
Meteor.methods({
'remove': function(id) {
var post = Posts.findOne(id);
post.softRemove();
}
});
// Client
Meteor.call('remove', post._id);

Not just softRemove, but if you have any delete events on the class, you have to use post.remove().  In those cases, while it's ugly, I'm thinking this would be the fastest:
// Client/server (or only server).
Meteor.methods({
  'remove': function(id) {
    (new Post({_id:id})).remove();
  }
});

// Client
Meteor.call('remove', post._id);

A Class.removeById(id) method would be more explicit and faster if it could just remove the document specified by the id and run the before and after handlers, but not fetch the document from the DB.
However, it seems from the docs that before and after storage event callbacks receive the document in this, so `beforeremove will have fetch it from the DB anyway, which renders @dovrosenberg's point moot.
@jagi, is that accurate? Do beforeremove and afterremove set this to the object? Perhaps this should be documented in the README. There's an example at Storage events but not explicit documentation of their parameters or this.

Yes, you are right the beforeremove and afterremove events are called in the context of a document. To follow this principle in the Class.removeById(id) function we would still have to get the document from the database.


Player save does not exist (Yes it does)

I'm trying to do the script, and it keep saying that my save does not exist...

The Save_Path need to target the SAVE folder, not just a random folder... it also need the level.sav inside


removes filename prefixes

Sorry! As it turns out, MiniTidal doesn't return anything for n "-1" (whereas vanilla Tidal returns the last sample in the dir) - so while the samples with the prefixes did start at note 60, notes 12-59, were effectively hidden.  This PR removes any attempt at cleverness

Why don't I fix that behaviour in WebDirt instead?

If that is a straightforward fix, then that would be ideal! Being able to use negative values there would be helpful.  Otherwise, I can make do using n ("0 -1" +48), which works in MiniTidal (assuming the samples have no prefixes).

Okay - in the currently deployed Estuary negative numbers for n count backwards through the sample bank. Maybe withdraw this pull request if that addresses it successfully?

awesome thanks! just tried it and it works great.  Closing the PR . . .


Replace underscore with hyphen for all our routes

What problem does the pull request solve?
Trello card: https://trello.com/c/OGT8czHa/419-change-underscore-separate-urls-in-runner-to-use-hyphens
Checklist

[ ] I've used the pull request template
[ ] I've linked this PR to the relevant issue (if mission work)
[ ] I've written unit tests for these changes (if code change)
[ ] I've updated the documentation in (If any documentation requires updating)

[ ] README.md
[ ] Elsewhere (please link)

Just updated the search to match on - or _ so its good 👍


All of the snap folder is staged into the snap

Currently, because we put all the config files, scripts, etc. that the project needs to be built as a snap inside the snap folder, snapcraft stages all of this into the snap itself under the snap folder. This is undesirable, as we already stage files that we need from there into the snap in other, more usable places and so these files end up being duplicated inside the snap, thus bloating the file size of the snap somewhat.

Also note that this presents problems when iterating on the snap locally using just snapcraft to build, as whenever the snapcraft.yaml file is modified all of the parts must be rebuilt. More discussion about this issue and potential ways to resolve it here.
I think that the eventual resolution will be that we will put all of the snap files, etc. inside snap/local in the edgex-go repo.

It looks like from https://github.com/snapcore/snapcraft/pull/2268 that using snap/local/... is the officially blessed way to do this starting with snapcraft 2.44, though it appears to work somewhat with 2.43 (current stable release of snapcraft).


Icon request: thermometer and humidity

The available icon set is amazing, but there's one icon missing from building great looking home weather station UI and it's thermometer icon.  Would be great addition, since e.g. weather related icons already exist.
Existing drop icon would work for humidity usage, but slight modification with %-sign would make it even more ideal fit for humidity data.

Thanks so much! You'll be happy to hear thermometer icons are coming soon. We'll add a humidity icon to the list.

Thermometer has been added to all libraries as of v1.1.0 🌡. There is also a new drop-half icon that could suit your needs for humidity.

That's amazing!! :) They're beautiful! Great job 👍


🐛  (vercel) NICE-77 !client => analytics/speed [b]

This pull request has been deployed to Vercel.

Latest commit:
627ceb8

✅ Preview:
https://jeromefitzgerald-cwz2ugd2l-jerome5.vercel.app

🔍 Inspect:
https://vercel.com/jerome/jeromefitzgerald/GHWb34LpK6UrkHbrKArUyZ13TuD5

View Workflow Logs

✅


GameWindow has no GetSize but a SetSize

as i have no clue where to actually get the size of a window i wrote this, idk if its correct or accurate
I just tried to get somehow the height and width of the current window
public static class GameWindowSizeExtension
{
    public static Int2 GetWindowSize(this GraphicsDevice graphics)
    {
        int width = graphics.Presenter.BackBuffer.Width;
        int height = graphics.Presenter.BackBuffer.Height;
        return new Int2(width, height);
    }
}

https://github.com/NexStandard/NexCoreExtension/blob/main/GameWindowSizeExtension.cs
For Reference

was fixed with merge of nexcore extensions

Thank you


Tao message not translated

These help messages seems to be missing on crowdin:

[ ] Tao translation

[ ] "Embody the ethos" translation and the * is not resolved
[ ] "Please read ECHO" translation

[ ] Contributions to the movement list is not in crowdin

[ ] location help text occurs on crowdin but not on website.

[ ] time example is not fully shown
[ ] mistake in English translation string "its" vs. "it's" and no translation.

URL: https://zen.coderdojo.com/dashboard/start-dojo

closing as 934 obsoletes this


Flickering value and placeholder during re-rendering

I'm writing to report a bug I encountered while using the "react-international-phone" package. The issue is related to the placeholder value that is being displayed every time the component re-renders.
Specifically, when the component has a value, the placeholder is displayed briefly before the actual value is shown. This behavior occurs every time the component re-renders, causing a noticeable flicker.
I have tried to address this issue on my end, but without success. I would like to request your assistance in resolving this problem. I'm happy to provide any additional information or to assist in any way I can.
The following snippet produces the issue.
import React from "react";
import { useTranslation } from "react-i18next";

import { Form, FormItemProps } from "antd";
import {
  PhoneInput as Input,
  PhoneInputProps,
} from "react-international-phone";
import "react-international-phone/style.css";

const PhoneInput: React.FC<PhoneInputProps & FormItemProps> = React.memo(
  ({ ...props }) => {
    const { t } = useTranslation("validation");
    const form = Form.useFormInstance();
    const value = Form.useWatch(props?.name || "");

    const onChange = (data: string) => {
      if (!data) return;
      if (!!props.name) form.setFieldValue(props.name, data);
    };

    const style = () => {
      if (!!props.disabled)
        return {
          backgroundColor: "rgba(0, 0, 0, 0.04)",
          color: "rgba(0, 0, 0, 0.25)",
        };
      return {};
    };

    return (
      <Input
        {...props}
        placeholder={`${t("placeholders.phone_number")}`}
        initialCountry="nl"
        value={value}
        onChange={onChange}
        inputStyle={style()}
      />
    );
  }
);

export default PhoneInput;

@riyadelberkawy
Hey, I can't reproduce placeholder flickering on rerender.
I have created a sandbox with provided code snipped:
https://codesandbox.io/s/blazing-sunset-zk7dw4
Please, check if you can see flickering in this example.
(or modify this sandbox to reproduce the bug you encountered if you have a chance :pray:)

@goveo
Hi, I modified the sandbox you provided and was able to reproduce the issue. You can see it here: https://codesandbox.io/s/quizzical-golick-1241hk?file=/src/App.tsx
To reproduce the issue, you need to re-rendering the entire form by toggling the visibility of the form by clicking on the show and hide buttons.
Let me know if you need anything else to help diagnose this problem. Thank you!

@riyadelberkawy
Should be fixed in version 1.8.4
https://codesandbox.io/s/admiring-edison-zsogwo
Please provide any feedback if the issue still persists

@goveo
Thank you for fixing the issue 🥳
I have tested the changes in the provided codesandbox and it seems to be working as expected. I appreciate your prompt response and effort in resolving the issue.
Let me know if there's anything else I can do to assist. Thank you again!

@goveo
Sorry about that but I noticed that the issue occurs again when I add an initial value for the phone field in the form.
https://codesandbox.io/s/quizzical-golick-1241hk

That happened because useWatch returns undefined on the first render.
You can simply add a check for undefined:
https://codesandbox.io/s/eager-proskuriakova-vv3kr2?file=/src/PhoneInput.tsx:607-639
Also, the country guessing on the initial render was slightly fixed in version 1.8.5, so I have updated the example to it.
Can you check if this solved your problem, please?

@riyadelberkawy
UPD: I have changed the usage of Form.useWatch to just form.getFieldValue and everything seems like work as expected:
const value = Form.useWatch(props?.name || "");

to
const value = form.getFieldValue(props?.name || "");

@goveo
it's working properly now. 🎉
Thanks for your effort.

🎉 Thank you for your effort!
⭐ Consider leaving a star on this repo if you like the project.


Remove deprecated roles

roles to remove

sensitiveData

make sure:

installer base.sql do not create these by default
no code depends on these roles

role has been removed. no code depends on those role. issue fixed


Strange lock image on top of wallpaper

Everything works out well except that I found out the image (set for bls) appears in the background for terminals, program windows, even plain wallpaper (like watermark), and it's sticking there no matter if I update the locking image, or clear/remove the cache dir, or even uninstall bls itself.
I tried to inspect the logs from dmesg, systemd and window manager(i3) but nothing rang a bell. Also I'm pretty sure that I only ever used this sticking image for bls, so I still suspect the issue has something to do with it. Is there anything I missed that may has caused this strange behaviour? Thanks in advance!
BTW, I'm using Arch Linux, with i3 as window manager.

Okay, will do, maybe some Screenshots will make the point/issue more clear...

I tried to take a screenshot, but things got even stranger, since the remnant doesn't appear on it. To illustrate the case, I also took a photo with my phone. The followings are the two pics:


Ads not blocked / extension support

Describe the bug
Ads block does not work in most of websites eg.youtube,imbd. Or please add extension support like ublock origin. Pls block the redirect links goes to some unwanted sites.

Hi @Github-com-foss
Related to your first comment "Ads block does not work in most of websites": we only block third-party ads that we consider to be tracking our users. Internally we use the domain list provided by https://github.com/duckduckgo/tracker-radar
Related to your feature request "add extension support like ublock origin": We are currently only accepting Github Issues for bug reports. So please, use discussions to share feature requests.
Contributing guidelines


SegmentedView active title doesn't not match with the active index

When using SegmentedView with type='carousel' and navigating using swipe gesture, the active title index doesn't change correctly. As the picture shown, The current active index is 2 ,and the active bar displayed under "Three", but the active text still on "Two". This only happen when using wipe gesture.

https://github.com/rilyu/teaset/blob/8b9c5c040a7f29c95000be4b3a4741bbcfa3b41c/components/SegmentedView/SegmentedView.js#L50-L54 ActiveIndex need to be updated when scrolling .
this issue can be fixed by adding  this.setState({activeIndex:this.props.activeIndex})  after this.refs.carousel.scrollToPage(this.props.activeIndex);


Can't get picture from downloads folder on Android 9

Bug Report
Problem
I'm using camera.getPicture to open an existing image on the device, in Android 9. I can select images in the gallery OK, but selecting images in the download folder throws an error and returns null for the image. Note on Android 8, opening images from the Downloads folder works.
What is expected to happen?
An image in the Downloads folder should be selectable on Android 9, the same as Android 8.
What does actually happen?
You get the following errors when you select an image in the Downloads folder, and null is returned for the image data:
2019-11-25 13:44:52.088 4241-4241/com.android.documentsui D/PickerActionHandler: onFinished() [content://com.android.providers.downloads.documents/document/25]
2019-11-25 13:44:52.099 3272-3272/com.app.myapp D/CordovaActivity: Incoming Result. Request code = 18
2019-11-25 13:44:52.099 3272-3272/com.app.myapp D/CordovaInterfaceImpl: Sending activity result to plugin
2019-11-25 13:44:52.101 3272-3272/com.app.myapp D/CordovaActivity: Started the activity.
2019-11-25 13:44:52.102 3272-3272/com.app.myapp D/CordovaActivity: Resumed the activity.
2019-11-25 13:44:52.109 2604-2645/android.process.media E/DatabaseUtils: Writing exception to parcel
    java.lang.IllegalArgumentException: Unknown URI: content://downloads/public_downloads/25
        at com.android.providers.downloads.DownloadProvider.query(DownloadProvider.java:933)
        at android.content.ContentProvider.query(ContentProvider.java:1055)
        at android.content.ContentProvider.query(ContentProvider.java:1147)
        at android.content.ContentProvider$Transport.query(ContentProvider.java:240)
        at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:102)
        at android.os.Binder.execTransact(Binder.java:731)
2019-11-25 13:44:52.110 3272-4568/com.app.myapp D/CameraLauncher: File location is: null

Information

Fails with all PictureSourceTypes and DestinationTypes.
I think the root cause is at line 106 of FileHelper.java:
 final Uri contentUri = ContentUris.withAppendedId(
                                Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));

In Android 9, my downloaded files (downloaded from Chrome) are in "all_downloads", not "public_downloads".
Command or Code

    const options: CameraOptions = {
      mediaType: this.camera.MediaType.PICTURE,
      correctOrientation: true,
      targetWidth: 1024,
      sourceType: this.camera.PictureSourceType.PHOTOLIBRARY,
      destinationType: this.camera.DestinationType.FILE_URI
    };

    this.camera.getPicture(options).then((imageData) => {

Environment, Platform, Device

Android 9
Version information

Ionic 4.11.2
Cordova CLI       : 9.0.0<EMAIL_ADDRESS>Cordova Platforms : android 8.1.0
Android 9
Checklist

[ x] I searched for existing GitHub issues
[ x] I updated all Cordova tooling to most recent version
[ x] I included all the necessary information above

No problems on
Android 9
cordova-android 7.1.4
cordova cli 8.1.2

Same problem but with videos, selecting video from downloads folder returns null:
os: android: 8.0.0
cordova: 9.0.0<EMAIL_ADDRESS>cordova-android: 8.1.0
cordova-plugin-camera : 4.1.0
		```

destinationType: Camera.DestinationType.FILE_URI,
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
mediaType:Camera.MediaType.ALLMEDIA,
targetWidth:700,
targetHeight:700,
quality:40,
correctOrientation: true

I maked some tests and i discover that if you open the Downloads folder an select a video then fails and return null.
But if you first goes to the Videos folder and after select Downloads into videos folder works well.


Regression: Coercion stopped working for coalesce on a dictionary column

Describe the bug
coalesce on a dictionary column worked on 36.0.0 but does not in 37.0.0
To Reproduce
It works in 3.6.0
DataFusion CLI v36.0.0

❯ create table test as values (arrow_cast('foo', 'Dictionary(Int32, Utf8)')), (null);
0 rows in set. Query took 0.035 seconds.

❯ select  coalesce(column1, 'none_set') from test;
+-----------------------------------------+
| coalesce(test.column1,Utf8("none_set")) |
+-----------------------------------------+
| foo                                     |
| none_set                                |
+-----------------------------------------+
2 rows in set. Query took 0.018 seconds.

Fails in 37.0.0:
DataFusion CLI v37.0.0
❯ create table test as values (arrow_cast('foo', 'Dictionary(Int32, Utf8)')), (null);
0 row(s) fetched.
Elapsed 0.021 seconds.

❯ select  coalesce(column1, 'none_set') from test;
Error during planning: No function matches the given name and argument types 'coalesce(Dictionary(Int32, Utf8), Utf8)'. You might need to add explicit type casts.
	Candidate functions:
coalesce(CoercibleT, .., CoercibleT)

Expected behavior
Should get the same answer as 36.0.0
Additional context
Maybe related to https://github.com/apache/arrow-datafusion/pull/9459

Workaround is to cast colum1 to string:
select coalesce(column1::string, 'none_set') from test

interested in this one

Thanks @Lordworms


refactor(app): Display pipette offsets in calibration card

Add information displaying the pipette offset calibration for currently attached pipettes (per the design) to the calibration card.
This has a couple other things that were required:

Expose the tiprackUri component of the pipette offset calibration via HTTP; it was previously saved but not exposed
Fetch pipettes and pipette offset calibrations when the calibration page is displayed
New selector to fuse attached pipettes and offset calibrations

Risk
None, behind feature flag
Review Requests

Is this the right way / place to make the new selector?
Is this the right way / place to fetch data?
General code review

Testing

Make sure you put the robot server build from this PR on your robot and turn on the calibration overhaul flags on both app  and robot
stop the API server and restart the app.

Look at the robot page for the unhealthy robot and see that there are no pipettes connected
Restart the api server while continuing to look at the robot page; when the api server comes up, the robot page should refresh with attached pipettes and calibration on its own

check that the proper data for

attached and calibrated
not attached
attached and not calibrated
work

check that the right tiprack is displayed. In theory this should work with a custom tiprack.

Closes #6612

Not sure if we decided not to follow the design exactly, but for the case when there is no pipette attached there should be two N/As. One for the pip name and one for the calibration section.

Changed to 600 after discussion


Blank page as default sheet

Is it possible to set to white the sheet background ? As default we have lines between columns ans lines, but I need a full blank page.
Is it possible ?

Ok I found it :
sheet.sheet_view.show_grid_lines = false


fix: Watch newer candles if a candle got skipped

Codecov Report

Merging #307 (0aee762) into main (c891bbc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #307   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          486       486
  Branches        30        30
=========================================
  Hits           486       486

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/product/ProductAPI.ts
100.00% <100.00%> (ø)


cmd/objdump: incorrect filename for function

$ go tool objdump -s cmplx.Inf ../pkg/darwin_amd64/math/cmplx.a
TEXT math/cmplx.Inf(SB) gofile..$GOROOT/src/math/bits.go
  bits.go:27		0x2e24			90			NOPL
  isinf.go:19		0x2e25			f20f100500000000	MOVSD_XMM 0(IP), X0	[4:8]R_PCREL:$f64.7ff0000000000000
  isinf.go:20		0x2e2d			f20f11442408		MOVSD_XMM X0, 0x8(SP)
  isinf.go:20		0x2e33			f20f11442410		MOVSD_XMM X0, 0x10(SP)
  isinf.go:20		0x2e39			c3			RET

Note that cmplx.Inf is listed as being in $GOROOT/src/math/bits.go. It looks like cmd/objdump may assume that the first instruction in the function is located within the function. With inlmarks in a prologue-less function, at least, this assumption is false.
Also, why is that  inlining mark there in the first place?
cc @randall77 because this is an unintended consequence of inlmarks
cc @dr2chase for all things position

Before genssa, we have:
v8 (+21) = InlMark <void> [1] v1
v19 (+17) = InlMark <void> [2] v1
v14 (22) = MOVSDconst <float64> [+Inf] : X0

After genssa, we have:
v8 00006 (?) NOP
v19 00007 (+17) XCHGL	AX, AX
v14 00008 (+21) MOVSD	$(+Inf.0), X0

Yes, there's something odd about the inline mark removal which might need fixing. Somehow instead of removing both marks, it merged one into a real instruction (v8->v14) and maybe that forced it to keep the other one (v19)?
The main bug I'm not surprised about. There's no other place to get position information other than the first instruction. Except maybe the return instruction (if there is one)?

Another place to look for position information, at least on amd64, is any trailing (padding) INT $3 instructions.
But changing the heuristic to look first for a RET and then at the first instruction if no RET seems like a good place to start.

Hello, I'm Joshua.
I was able to get this working in about 8 lines of code. Here is the process I took.
disasm.go
Inside of the Print method, which starts on line 186:

Created an additional instance of the tabWriter to handle the top-level line of the output ~line 202.
Removed the call to print the first line as it is now handled later in the function ~line 214.
Added two additional variables to store the last instruction that is a part of the disassembly as well as the file associated with the instruction ~line 226
Inside the callback function passed into the Decode method, set the variables that were declared as a part of item 3 ~line 233.
Directly after the call to Decode, I added some logic to check the value of the last instruction and if “RET”, use the file associated with it or else default to the first instruction and then flush the header and body of the output ~line 260

I used an additional instance of tabWriter due to the calls to Fprintf inside of the callback that is passed into Decode. The enclosing Print method depends on the io.Writer interface, so the changes are more involved than I wanted to get into without first reaching out. Please let me know if the above makes sense or the direction I should be taking for the fix.
Joshua

Thanks for looking into this!
What is the performance hit if you simply call Decode twice, first just to find the RET (if any), then a second time to do all the printing? (By the way, any RET anywhere in the function should work. It doesn't have to be the final instruction, and it often won't be.)

This is a better suggestion. It drops the amount of changed lines and preserves the order to the output to match the order of the logic in the code. Thanks for pointing out the RET code could be anywhere in the instructions, I was dialed too much into the example and didn’t think about that.
The one caveat is that I’m not sure how to short-circuit the call to Decode because the function is executing a callback which prevents adding a goto label due to scope?
The execution time is linear, so I don’t think decoding the symbols twice will add that much overhead unless there’s something happening at a lower level that I am not aware of. I’m going to add some profiling code and run a few performance tests on the algorithm as it will be a good learning experience.

Sounds good. Let me know if I can be of help.
As to short circuiting, I think you’ll have to add explicit support for it, e.g. by having the function arg to Decode return a bool indicating whether to stop decoding. You could start without that and add it in as a second step, since it is an optimization.

I was as able to familiarize myself with pprof this morning.
There is a 2x slow down when invoking the function twice to get the ret code. Adding the short circuit logic and re-running the profile on runtime.a cuts the additional overhead in half, which is probably close to average case. I have a fast laptop, but the results were measurable in seconds, which is enough justification to include the short circuit logic since it’s already written down. I’ll submit these changes and leave it up to code review going forward.

Hey Josh,
Do you have a good recommendation on how to write tests that rely on stdout? Normally, I would refactor the code to accept a parameter to specify where the output goes and then use a returned string to perform the assertion, or something similar.
I can change to code to do this but I'm not sure if there is some other way go handles dependencies like stdout when testing?
Thanks

Actually I think I can just call the disasm.Print directly while passing in a StringBuilder rather than trying to rely on invoking the code via the main method because main is not doing much at all I believe.
I'll try this approach first.


Remove Option from PyObject.typ; Refactor type hierarchy initialization.

Also drops Default for PyObject.

Codecov Report

Merging #667 into master will decrease coverage by 0.13%.
The diff coverage is 85.56%.

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   40.26%   40.12%   -0.14%
==========================================
  Files          79       79
  Lines       17456    17455       -1
  Branches     4473     4469       -4
==========================================
- Hits         7028     7004      -24
- Misses       8595     8616      +21
- Partials     1833     1835       +2

Impacted Files
Coverage Δ

vm/src/stdlib/json.rs
38.18% <ø> (-0.85%)
:arrow_down:

vm/src/obj/objdict.rs
42.63% <ø> (-1.58%)
:arrow_down:

vm/src/obj/objobject.rs
42.57% <ø> (+2.84%)
:arrow_up:

vm/src/exceptions.rs
39.37% <100%> (-9.54%)
:arrow_down:

vm/src/obj/objtype.rs
40.69% <100%> (-3.69%)
:arrow_down:

vm/src/pyobject.rs
56.81% <81.08%> (+0.06%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfee90...b334689. Read the comment docs.

This looks great, thanks!


Fix Synapse access control test issue

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@annelo-msft could you please help review this PR, for fix https://github.com/Azure/azure-sdk-for-net/issues/29717

@wonner: I'll get this merged for you.


How integrate correctly composer installation

I still do not understand how to integrate

Close the issue, you integrated Composer, didn't you?


Trigger should be configurable

ATM the menu trigger is hard coded inside the plugin. There is now way to move the trigger inside the HTML, i.e. to relative positioning it.
Trigger should be any element and there should be a way to open the menu just clicking the trigger, IMHO. Thanks.

I have a forked version of this project that aims to achieve exactly what you've described.
Give it a try and let me know if it solves your problem!

Thank you @joecallon, you fork works just fine. It should be merged into this too.


NFC: Remove ClangModuleLoader.h include from ExtInfo.h

This was unnecessarily pulling in a whole bunch of Clang headers when all was needed was a forward declaration.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Difficulty entering HA credentials

As a new Immersive Home user on Quest 3, I tried to enter my Home Assistant URL with 3 different methods before realising it could only be filled by pasting text copied from another app on the headset:

Virtual keyboard: I tried long pressing the shift and semicolon keys in case the colon was hidden.
Bluetooth keyboard: The keypresses aren't sent to Immersive Home for some reason.
SideQuest copy/paste: Text pasted from SideQuest also wasn't making it to the app.

I finally managed to enter the URL using these steps:

Open Meta Browser and paste the URL from SideQuest into the address bar
Select and then cut the text from the address bar
Return to Immersive Home to paste the text in the field
Repeat for the token

I understand that the token is far too long to enter by hand, but a complete keyboard and handling keystrokes/pasting from input devices and SideQuest would reduce the barrier of entry.
Also, nice work on kicking off a great open-source project. I'm interested in seeing where this goes.

We have a setup guide here, but I agree that it is somewhat hidden at the moment. In the future, I'll implement the setup tutorial right into the app.

Virtual keyboard: I tried long pressing the shift and semicolon keys in case the colon was hidden.

I'm not really following what you mean by that.

Bluetooth keyboard: The keypresses aren't sent to Immersive Home for some reason.

That's definitely something I should support soon. Even though I don't have a keyboard to test this with, I should try to implement it anyways.

SideQuest copy/paste: Text pasted from SideQuest also wasn't making it to the app.

Haven't heard of that yet. Will look into if it makes sense to add this way of setting it up too.
I think the best way would be to host a QR code generator on our website which you could then scan with the headset to have a seamless setup, but for that Meta needs to implement a QR Code scanner first.
Also thank you very much for the feedback!

I ran into the same issue where I could not enter a colon.
There is no physical colon button, only semicolon which is shown in both the lower and uppcase keyboard state.
Here  are some pictures to help illustrate the issue.

Oh haha, I just noticed that yesterday too, thanks for the report!

We have a setup guide here, but I agree that it is somewhat hidden at the moment. In the future, I'll implement the setup tutorial right into the app.

Actually I couldn't access the guide when I was initially setting it up. I think your website was down briefly, so just tried different methods to enter the server info.

Virtual keyboard: I tried long pressing the shift and semicolon keys in case the colon was hidden.

I'm not really following what you mean by that.

Sometimes virtual keyboards (like on phones) have additional layers of characters you can switch between. I couldn't find a colon on your virtual keyboard so I tried holding shift and other keys in case the character was hidden on another layer.

Bluetooth keyboard: The keypresses aren't sent to Immersive Home for some reason.

That's definitely something I should support soon. Even though I don't have a keyboard to test this with, I should try to implement it anyways.

Happy to test it if you end up adding that. Since getting a Quest 3 I've found passthrough + physical keyboard really practical, especially for MR apps coming from web or desktop.

SideQuest copy/paste: Text pasted from SideQuest also wasn't making it to the app.

Haven't heard of that yet. Will look into if it makes sense to add this way of setting it up too.

Yeah, the SideQuest app has a text box you can push to the connected HMD. It beats using a virtual keyboard to enter 20 random characters to log into something on the headset and you use a password manager.
This possibly enters text using the same method as a Bluetooth keyboard, so enabling one may enable the other.

I think the best way would be to host a QR code generator on our website which you could then scan with the headset to have a seamless setup, but for that Meta needs to implement a QR Code scanner first.

Nice thinking. That would definitely be the ideal solution 🤞

Also thank you very much for the feedback!


Fail sni.yaml loading if related resources fail to load

Fixes #9093

This should go into 9.2 and probably others, but they'll require version specific PRs due to slight source reorg/rename.

[approve ci autest]

Looks like there is a hard fail for Au test tls_check_cert_selection_reload.

Looks like there is a hard fail for Au test tls_check_cert_selection_reload.

Thanks, I think I got it happy now.

Looks good to me.
Do you think we can add an autest to verify this? Alan wrote some tests for remap reload failure with the following PR, in case that's helpful:
https://github.com/apache/trafficserver/pull/8802/files

Added (thanks to @cmcfarlen !)

oops, I didn't release you added more comments @bneradt. Sorry for the re-review request.

[approve ci autest]

Cherry-picked to v9.2.x


ECIES Encryption and Decryption With Public and Private Key Using AES 256 CBC PKCS7PADDING

@peterdettman, Ok, I wanted to implement ECIES Encryption and Decryption using BouncyCastle CSharp, since I could not find any CSharp examples for encrypting a message, I decided to adapt the java example I found here to CSharp.
I started by replacing IESCipher with BufferedIesCipher and IESParameterSpec  with IesWithCipherParameters and I hit a bummer, BufferedIesCipher .Init threw a Platform.CreateNotImplementedException("IES");
Does anyone have any examples in CSharp I could use for implementing this?
Thanks.

later implemented this following samples from the Java code.

@Xor-el, Where can I refer your big creation.

These day, I also need C# ECIES library that is compatible with Java BC library.

later implemented this following samples from the Java code.
Could I get the information what you did??

For anyone else who runs into this here: If you need ECIES AES CBC with IV take a look at https://github.com/Sphere10/NPascalCoin/tree/master/src/NPascalCoin/Crypto They implemented the missing classes from the java bc so it works together with the IESwithAESCBC class from java.
Without IV might work it but at least with an initial vector there is no support from the csharp bc atm.


multicov header

I am using multicov to calculate coverages across specific regions for many bam files and would like to include a header for the output that includes the filename of the bam file that the coverage came from. I would greatly appreciate any help in figuring out how to complete this. Thank you!
An example of what I want is:
Chr   Start     Stop     bam1.bam   bam2.bam   bam3.bam
1       12322   12553   234              467              532
where 234 is the coverage of bam1.bam for chr1:12322-12553
and 467 is the coverage of bam2.bam for chr1:12322-12553
I am currently using the following command
bedtools multicov -bams *.bam -bed P1.bed > cov.txt
How do I modify the above command to include the header with the BAM file names? Thank you!
Jacquelyn

Yes, this tool is indeed missing a header option. I apologize - we will try to get this out in a next release.


Error: pip install piper-tts | Installing with Python doesn't seem to work, missing packages and dependency conflict.

Installing as per guide

pip install piper-tts

ERROR: Cannot install piper-tts==1.1.0 and piper-tts==1.2.0 because these package versions have conflicting dependencies.
The conflict is caused by:
piper-tts 1.2.0 depends on piper-phonemize~=1.1.0
piper-tts 1.1.0 depends on piper-phonemize~=1.0.0
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

Isolating version install

pip install piper-tts==1.2.0

ERROR: Could not find a version that satisfies the requirement piper-phonemize~=1.1.0 (from piper-tts) (from versions: none)
ERROR: No matching distribution found for piper-phonemize~=1.1.0

pip install piper-tts==1.1.0

ERROR: Could not find a version that satisfies the requirement piper-phonemize~=1.0.0 (from piper-tts) (from versions: none)
ERROR: No matching distribution found for piper-phonemize~=1.0.0

Having the same issue here

Yes, happens to me too.

Same problem here Win 11, python 3.8.11

the piper-phonemize does not support python 3.11.

same problem here but only on Windows not Ubuntu.

the piper-phonemize does not support python 3.11.

Which one does it support? Tried 3.10 for same effect.

Same here on Mac with Python 3.11

Same here on Fedora 40, Python 3.12.3.

Works on python 3.9

It doesnt work for me on Python 3.8.10, but works on  Python 3.10.12
it would be great to know which versions officially work.

It's end of Jun and I ran into it as well.


nearby() results not sorted by distance from point?

I want to find the closest nearby point to my point, but the results from nearby() while its a list (implies order) is not ordered. Said another way the 1st entry in the list is not the closest to the point I asked for nearby points to.
How do I find the closest of the nearby locations to my point?

good damn question! I thought that was implied functionality given the nature of the library. and we await....

@doapp-ryanp This unfortunately is not an easy thing to do without additional computational load.
I have some good news and bad news related to this modules.
Bad news first: it's unlikely I'd implement any kind of sorting algorithms on results because this is already something the geolib module does. Use that module to manipulate results from this module if needed. Look at orderByDistance for this particular problem. I may make this module more compatible with geolib so that results can easily be passed into it without any manipulation. But that means changing the way objects get returned which is a breaking change and would mean major version bump (as per semver).
Good news: this module is likely to become obsolete very soon because Redis is wrapping in a native implementation of the algorithms used here and this will be WAYYYY faster, more accurate and will have sorting baked in as well as many other great features.
[http://redis.io/commands/georadius](Redis GEORADIUS command). Check out the related commands.

Changed my mind on this. I think I will implement sorting, but it will be in a 3.x.x release and will be wrapped up with support for the new Redis Geo commands. :D
Please be patient, while I try and fit it all in.

OK thanks.  I will try that out
In my use case I don't want redis (I have a small source set and don't want the extra dependency).  I am currently using fakeredis to pull this off.  Only reason I mention this, is I don't want your lib to go away :)

@doapp-ryanp @sirvon I'm releasing v3.0.0 as a new module called georedis.
This uses the native geo commands in redis if they are available, and fallback to an emulation mode if they aren't. This means it should work using fakeredis. And I've added sorting capabilities as well as a number of other options.
Sorting by distance is VERY slow in emulation mode, especially for large returned results. If you care about performance, consider looking into the soon to be available native geo commands in redis, which this module takes advantage of. Pretty sweet! :)
The API has changed, but if you can, beta testing would be appreciated.
npm install<EMAIL_ADDRESS>

Thanks - I will try it out in the next few weeks, I wont be able to use real redis because AWS elasticache wont have new version for quite some time and the code I'm working on is in lambda which currently does not have access to elasticache.

Cool! :) Let me know


Python2 support

The official support for Python 2 ends this year. It doesn't mean that we will drop Py2. As long as Py2 is available in Debian (which I use) any features/fixes will be available for both versions Py3 and Py2.

@WojciechMula great, that's your call though... If you consider branching for maintenance the current code and only support Python 3 for any new developments that's fine by me.

many of my clients cannot easily upgrade software on their servers and wind up stuck with Python2. That's why I'm searching for efficient solutions that work in both 2 and 3. Thanks for your contribution to the community!

@asmithatlassian Thank you for your kind words.

@asmithatlassian It is hard to keep support for Python 2 as getting a way to test and build in the hosted CI's becomes harder and harder. I would be included to remove support as it is really to support something that cannot be reliably tested.  What do you think?

There was an attempt to split the module into py2 and py3 lines. But that approach failed, as the code was duplicated and there was a lot of burdens with this.
Despite problems with testing, I think we should keep the py2 suppport. Likely we declare at some point in time, that we cannot test the py2 variant and people would use never versions on their own risk. Like in Debian, we have stable and unstable variant. Does it sound fine?

test the py2 variant and people would use never versions on their own risk. Like in Debian, we have stable and unstable variant. > Does it sound fine?

This makes sense. Let's call 1.4.4 the latest stable supporting Python2... and branch it out for possible support.
This way you can start a clean 2.0.0 with exclusive Python 3.6+ (or may be even 3.8+) support

I am closing this as we stopped testing on Python 2 a long while ago. The upcoming v2.0 will be Python 3.7+ only


feat(user-block xs): added a size XS to usr block

General summary
A new size for the user block that will better integrate in some designs.
Screenshots

Fix: https://lumapps.atlassian.net/browse/DSW-233

Rebasing & testing

Test OK ✅


Frontend character just after the description messages

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[x ]

Hello @cocolabssas,
I have just installed cocorico and I see in every descriptive message a "peace and love" symbol at the end as you can see in the attached image

It does not matter if I choose a different language it also appears.
Can you lead me so I can take off that symbol? It happens in both development/production environment.
My actual specs are:
MariaDB-server-10.1.46-1, SO: Centos 7, php-7.1.33-9, mongodb-org-3.4.24, Symfony 3.4.36
Thank you in advance.
[REDACTED]
*Note: @mv3ntur4 fixed grammar.

Maybe I am on the bleeding edge of php? @SchulzWill, can you help in telling me which are your specs when you finish installing it? maybe I should try with older php versions?
I appreciate your comments.
Have a nice day!

Hi @SchulzWill,
I have tried with php 7.2 and the result is the same, i will try with an older database version.
Greetings!

Hello @SchulzWill,
Now it displays correctly and it was not related to the database neither to the php language versions.
Have a nice day!


Garbage collection for the old generation

This PR implements a garbage collection for the old generation. It uses the same copy-collector infrastructure for the old generation. For now, the old generation is collected every 10 young generation collections. We can change this in future by adding desirable logic in the shouldCollectOldGen function. It is tested with the EVM vm and blockchain tests.

Once every ten collections might be too often. Have you measured the before/after of the gc overhead?

No I haven't. Can you suggest which test should I use as a benchmark for this kind of measurement?

I'm suspicious of these timing numbers because one of them shows a much higher wall time but no corresponding increase in user or system time. Are you sure you didn't have anything running in the background when you ran the gc-old branch?

I repeated the measurements after setting the frequency of collection for the old generation to once every 50 young generation collections (from once every 10). Here are the new resutls:
master branch:
real 23m36.456s
user 12m41.164s
sys   3m52.752s
gc-old branch:
real 25m50.217s
user 14m24.944s
sys   4m4.368s
This looks like a significant improvement over the previous timings, although still it introduces a slowdown as was expected

25 minutes instead of 23 is probably acceptable. Hopefully when the peak memory usage goes down we will see a significant drop in system time which will make up for the increased overhead.


EIP-1234: Constantinople Difficulty Bomb Delay and Block Reward Adjustment

https://eips.ethereum.org/EIPS/eip-1234

@SamWilsn I will take this one as well


Please upgrade to react native 0.60

react native 0.60 was released, i saw a lot of benefit, so i hope ignite upgrade to 0.6x. Thanks

@viralS-tuanlv I've found this ignite new HoldMyBeer --react-native-version 0.60.2
ref: https://github.com/infinitered/ignite/issues/1078

@viralS-tuanlv I've found this ignite new HoldMyBeer --react-native-version 0.60.2
ref: #1078

no, i have tried and: ⠧ adding React Native 0.59.9 (30 seconds-ish)

We are working on it! Ref: https://github.com/infinitered/ignite-bowser/issues/218#issuecomment-511278155

We are working on it! Ref: infinitered/ignite-bowser#218 (comment)

almost month but not yet see any change

Any Update About Andross ?

any news?  Inginte is an amazing boilerplate tool

The update for Bowser was shipped August 1st. Andross is in community support mode, which means most of the updates will come from community contributions.


Bug: Clicking zoom blocks entire page

When clicking zoom in on the generated paths sometimes it blocks the entire page and you cant scroll down to the close button. I suggest limiting the size of the container to a percentage of the screen size and have it dynamically scale. That way the button will never be outside of the viewport.
I'll have a crack at fixing it on my side when I get a chance and raise a PR but I thought I should mention it to keep track of it.

Thank for reporting, should be fixed now.


Does not operate with embedded-hal 1.0.0-rc.1

Breaking changes in embedded-hal 1.0.0-rc.1 are incompatible with this driver.
I have a working version at: https://github.com/Radiator-Labs/veml7700, which is operating on my STM32WL55 board.
I am not able to submit a PR at this time, as the examples no longer compile. This is because dev-dependency stm32f4xx-hal does not yet support the new embedded-hal; see https://github.com/stm32-rs/stm32f4xx-hal/issues/686

Fixed by #3

Fixed by #3


Offer configuration schema and code generation for connectors

tests currently fail because go fetches the baton-sdk from the main branch:
/tmp/baton-sdk-schema-87803883 via 🐹 v1.22.3
➜  go build -buildmode=plugin -o example plugin.go
go: finding module for package github.com/conductorone/baton-sdk/pkg/configschema
go: downloading github.com/conductorone/baton-sdk v0.1.47
plugin.go:4:2: cannot find module providing package github.com/conductorone/baton-sdk/pkg/configschema

IDK if I should think of a workaround for this just for the unit tests 🤷🏻♂

I'm unable to bypass the error:
failed to open plugin:
plugin.Open("/tmp/baton-alternative-location-3073697725/plugin"): plugin was built with a different version of package github.com/conductorone/baton-sdk/pkg/configschema

In tests.
This is a problem during development because the package pkg/configschema can differ between the contents of main and the contents of whatever branch someone is working on.
I did attempt the following workarounds without success:

adding a go.mod with redirect to the project in disk
doing the above step but generating a go.sum
doing the above step but adding a temporal plugin.go file with 1 import (that import was removed from go.mod because it wasn't actually used lol)
copying go.sum from the project (didn't work either, but IIRC go mod tidy that was ran afterwards may have deleted the import, forcing go build to fetch it from the repo on GitHub. My bad)

Ideally, during development and testing, the same pkg/configschema should be used when compiling the schema definition of the configuration as a plugin, otherwise the plugin module will refuse to open the plugin.

According to git bisect, things went south at commit 3a5a39cf8ae98ba3d37909ccb4366aa25e8d916a.
Commit 4b9a5361348252542a237c19b23e29000062f5da was the good commit, as the module pkg/configschema compiles the plugin and pass tests successfully.


Chore/browserify

[Current coverage][cc-pull] is 100%

No coverage report found for master at 03d8d4a.

Powered by Codecov. Last updated by [03d8d4a...134679f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/segment-integrations/analytics.js-integration-errorception/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/segment-integrations/analytics.js-integration-errorception/compare/03d8d4a0d20fb999f8b51c9f1abdf9d670cd47b0...134679f51e40f59dd00f7fd81ecfbb3875c3973e
[cc-pull]: https://codecov.io/gh/segment-integrations/analytics.js-integration-errorception/pull/2?src=pr


SAM integration into MIMO

Segment Anything (SAM) could be very helpful for improving the MIMO framework in several ways:
Enhanced spatial decomposition:
SAM's ability to segment any object in an image or video could significantly improve the spatial decomposition process described in Section 2.1 of the paper. Instead of relying solely on depth estimation and human detection, SAM could provide more accurate and detailed segmentation masks for:
Human layer: More precise human segmentation, including fine details like hair and clothing.
Occlusion layer: Better detection and segmentation of objects that may occlude the human.
Scene layer: Improved separation of background elements.
Improved object interaction handling:
SAM's ability to segment arbitrary objects could help in better modeling human-object interactions. This would enhance the "applicability to interactive real-world scenes" that MIMO aims to achieve.
Refinement of masklets:
The paper mentions using video tracking to propagate masks across frames. SAM could be used to refine these masklets frame-by-frame, potentially improving temporal consistency.
Data augmentation:
SAM could be used to generate additional training data by creating new combinations of segmented humans, objects, and backgrounds.
Evaluation and quality control:
SAM could be used to evaluate the quality of the synthesized videos by comparing the segmentation of generated videos with the original inputs.
Interactive editing:
While not directly mentioned in the paper, SAM's interactive segmentation capabilities could allow for user-guided refinement of the spatial decomposition, enabling more precise control over the synthesis process.
Handling complex scenes:
For scenes with multiple people or complex object arrangements, SAM could provide a more robust initial segmentation, potentially expanding MIMO's capabilities to handle more diverse and challenging scenarios.

replace logic with SAM2VideoPredictor


Change the daily docs branch name

Still in draft because I'm still investigating the entirety of the changes required.
The problem being looked at is that committing to a docs branch will automatically kick off runs. Adding the -ignore-build suffix will prevent this.

Fixes #6569

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


The $govuk-border-width-mobile variable doesn't make any sense

We have a variable called $govuk-border-width-mobile.
It's documented as 'Border width on mobile'
However, it's only used in a couple of places:

The width of the conditional reveal on checkboxes and radio buttons at all breakpoints
The width of the error summary at all breakpoints

We should consider renaming or removing this variable.

The 4px border is used in the conditional reveals because it has to be an even number in order to be centred under the 40px checkbox or radio. 5px would put it 1px too far left or right and it was noticeable.
The error summary change is probably not needed.
So I'd say we will need a 4px border, it should just have a different name.


Proposal: Rename id argument name in fields that don’t return its type

Some top-level fields return an object if you have their ID:
type Query {
    container(id: ContainerID, platform: Platform): Container!
    directory(id: DirectoryID): Directory!
    file(id: FileID!): File
    secret(id: SecretID!): Secret!
    socket(id: SocketID): Socket!
}

There’s two exceptions to this “rule”. I think it makes sense for us to rename these parameters to make it more consistent:
type Container {
-    withRootfs(id: DirectoryID!): Container!
+    withRootfs(source: DirectoryID!): Container!
}

type Git {
-    commit(id: string)
+    commit(hash: string)
}

Notes

Or directory instead of source, it's more more consistent;
Container.withFS doesn’t matter as it’s deprecated;
Downside is the breaking change but for codegen clients, withRootfs‘s id being a required argument, the name is hidden from usage so it shouldn’t actually break most users;
This was surfaced in https://github.com/dagger/dagger/issues/4191.

I also found that some optional methods parameters are named id when passing the object makes more sense. We should rename them as well.
example:
export type ClientContainerOpts = {
-  id?: ContainerID | Container
+  id?: Container
   platform?: Platform
}

@dolanor I'm pretty sure all those optional ids are meant to keep their ID. Have something been added in the meantime?
Your ClientContainerOpts example comes from here:
extend type Query {
  """
  Load a container from ID.
  Null ID returns an empty container (scratch).
  Optional platform argument initializes new containers to execute and publish as that platform. Platform defaults to that of the builder's host.
  """
  container(id: ContainerID, platform: Platform): Container!
}

So we do mean to pass an ID here, to get the corresponding Container object.

We intend to implement this breaking change for:

https://github.com/dagger/dagger/discussions/5374


Make button disabled instead of hiding it

I think it would be better to make the previous/next buttons disabled. If you use display: none it can be overwritten only by using !important. But this way, you can still hide the button or style it.

@kingaiakab @iamlothian I think we have to make it optional

@sheikalthaf Yes, you are right. I will update this PR.

When will this pull request be merged ?


Fix telemetry issue in diagnostics mode

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

[ ] Each command and parameter has a meaningful description.
[ ] Each new command has a test.

(see Authoring Command Modules)

Codecov Report

Merging #4399 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #4399      +/-   ##
=========================================
- Coverage      69%     69%   -0.01%
=========================================
  Files         484     484
  Lines       31080   31081       +1
  Branches     4852    4852
=========================================
  Hits        21447   21447
- Misses       8051    8055       +4
+ Partials     1582    1579       -3

Impacted Files
Coverage Δ

.../azure-cli-core/azure/cli/core/telemetry_upload.py
21.42% <0%> (-0.53%)
:arrow_down:

...dback/azure/cli/command_modules/feedback/custom.py
31.25% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
69.03% <0%> (ø)
:arrow_up:

.../azure/cli/command_modules/servicefabric/custom.py
36.1% <0%> (ø)
:arrow_up:

...nent/azure/cli/command_modules/component/custom.py
16.26% <0%> (ø)
:arrow_up:

...li-cloud/azure/cli/command_modules/cloud/custom.py
13.79% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f78888...cf8852e. Read the comment docs.


Cant apt update on debian install

File: engine/install/debian.md
Doing
$ sudo add-apt-repository \
   "deb [arch=amd64] https://download.docker.com/linux/debian \
   $(lsb_release -cs) \
   stable"

will result in
E: The repository 'https://download.docker.com/linux/ubuntu buster Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

Also maybe the documentation's "request doc changes" (upper right corner) could open github on a new page?
thanks

E: The repository 'https://download.docker.com/linux/ubuntu buster Release' does not have a Release file.
buster is a Debian Release, Ubuntu and Debian releases don't mix :)
It would seems to me you are trying to follow Debian's installation procedure on Ubuntu. Following Ubuntu's procedure will surely help you reach a more satisfying outcome :)

@denis-roy, thanks for providing a solution.
@aftxavier, thanks for sharing the issue. If you still experience issues after following denis-roy's solution, please try the Docker Community Slack or forums for support:

https://dockercommunity.slack.com/
https://forums.docker.com/


Permit more characters in URI paths

The https://url.spec.whatwg.org/#path-state allows more characters than we currently allow. This was noticed in https://github.com/seanmonstar/reqwest/issues/442.

We just ran into this as well! Could you cut a release with these changes?


java-sdk  bug?

Hi @asdshuaishuai,
Which version of MeiliSearch did you use? The sort field is available from v0.22.0 of Meilisearch.
Thanks

thinks ,I used v0.22
I talked about this question with your customer service, and I will set up sortableamtributes (), but still report an error.

I don't know if I am using the problem, this is my code.

Hi @asdshuaishuai,
Thanks for your reply can you try:
curl http://<IP_ADDRESS>:7700/version and tell me the exact return you have?
Thanks

The server is used by V0.22. It is 0.21 for the test server. I am sorry, I am wrong.

The server is used by V0.22. It is 0.21 for the test server. I am sorry, I am wrong.

No problem 😉


x/playground: faketime headers not stripped from os/exec subprocess output

What did you do?
https://play.golang.org/p/Gi7BzeGhs6Q
What did you expect to see?
Similar output to go test -v when running the test locally:
$ go test -v
=== RUN   TestPanicDoChan
=== PAUSE TestPanicDoChan
=== CONT  TestPanicDoChan
    main_test.go:55: /tmp/go-build979564443/b001/example.com.test -test.run=TestPanicDoChan -test.v:
        === RUN   TestPanicDoChan
        fatal error: all goroutines are asleep - deadlock!

        goroutine 1 [chan receive]:
        testing.(*T).Run(0xc000001380, 0x550089, 0xf, 0x5581a8, 0x4831c6)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1203 +0x2da
        testing.runTests.func1(0xc000001200)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1475 +0x78
        testing.tRunner(0xc000001200, 0xc000072de0)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1157 +0xef
        testing.runTests(0xc00000c060, 0x627270, 0x1, 0x1, 0x0, 0x0, 0x0, 0x40d3b0)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1473 +0x2fe
        testing.(*M).Run(0xc000110000, 0x0)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1381 +0x1eb
        main.main()
                _testmain.go:43 +0x138

        goroutine 6 [chan receive]:
        example%2ecom.TestPanicDoChan(0xc000001380)
                /tmp/tmp.ghGKUvokgN/example.com/main_test.go:39 +0x61e
        testing.tRunner(0xc000001380, 0x5581a8)
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1157 +0xef
        created by testing.(*T).Run
                /usr/local/google/home/bcmills/sdk/gotip/src/testing/testing.go:1202 +0x2b3

        goroutine 7 [chan receive]:
        example%2ecom.TestPanicDoChan.func1.2(0x4134eb, 0xd0, 0x538fe0, 0x50257ab94168e01)
                /tmp/tmp.ghGKUvokgN/example.com/main_test.go:30 +0x4a
        golang.org/x/sync/singleflight.(*Group).doCall(0xc0000524f0, 0xc00005c2a0, 0x0, 0x0, 0xc00003e798)
                /tmp/tmp.ghGKUvokgN/_gopath/pkg/mod/golang.org/x/sync@v0.0.0-20200625203802-6e8e738ad208/singleflight/singleflight.go:97 +0x2e
        golang.org/x/sync/singleflight.(*Group).Do(0xc0000524f0, 0x0, 0x0, 0xc00003e798, 0x91ad385ba9787, 0xc00003e7c0, 0x4d388f, 0xc000001380, 0x6bd3b)
                /tmp/tmp.ghGKUvokgN/_gopath/pkg/mod/golang.org/x/sync@v0.0.0-20200625203802-6e8e738ad208/singleflight/singleflight.go:67 +0x1c5
        example%2ecom.TestPanicDoChan.func1(0xc0000524f0, 0xc000022300, 0xc000022360)
                /tmp/tmp.ghGKUvokgN/example.com/main_test.go:28 +0x9a
        created by example%2ecom.TestPanicDoChan
                /tmp/tmp.ghGKUvokgN/example.com/main_test.go:24 +0x5c7
--- PASS: TestPanicDoChan (0.01s)
PASS
ok      example.com     0.019s

What did you see instead?
Mangled output containing faketime headers:
0xc000060300PBt���`)
        PBt���`	PBt���`/tmp/sandbox650178755/prog.goPBt���`:PBt���`28PBt���` +PBt���`0x9aPBt���`
        PBt���`created by PBt���`main.TestPanicDoChanPBt���`
        PBt���`	PBt���`/tmp/sandbox650178755/prog.goPBt���`:PBt���`24PBt���` +PBt���`0x5c7PBt���`
--- PASS: TestPanicDoChan (0.00s)
PASS

CC @golang/osp-team

I understand this issue is related but not the same as #38751. The difference here is that it happens specifically for subprocess output even when the output is not large. Is that right?

Correct. And the fix here is probably independent of that fix. (Probably os/exec should be patched to strip out timestamp headers from stdout and stderr? But maybe there's a better approach, like suppressing the timestamping entirely in subprocesses.)

The fundamental issue here is that stdout/stderr of faketime binaries is simply not meant to be generally consumable. Rather it is intended only for handling by the playground itself.
I don't think have os/exec strip headers would be a robust fix, as intermediate processes could still get confused. e.g., exec a bash script, which exec's the original binary and parses its output. In this case, the stdout/stderr is never passing through os/exec, so it doesn't get a chance to fix it up.
A more robust solution that comes to mind would be to only enable faketime headers if a specific environment variable is set. The playground would always set this variable, and the faketime binary should probably clear it on init so it isn't inherited by os/exec calls.

At a higher level, I think we need to step back and think about whether we really want to support subprocesses on the playground. The sandbox can support it just fine, but I think these kinds of weird issues are going to keep coming up as long as we have faketime. If we don't support it, we could disable os/exec entirely. (Users could still directly invoke the syscalls, but we have no support there).

Personally, I think enabling faketime by an environment variable, clearing that environment variable early during process-init, and allowing os/exec in general is probably the way to go. I would hate to drop os/exec entirely in the Playground, given that the sandbox can handle it.


Thank you

I'm impressed by how simple it is
This  is probably the best library I have ever seen

Hey,
Thanks for your kind words.
I'm happy it fills your needs :)
Sent from Nine

From: pheianox @.***>
Sent: Sunday, April 3, 2022 13:34
To: Belphemur/node-json-db
Cc: Subscribed
Subject: [Belphemur/node-json-db] Thank you (Issue #380)
I'm impressed by how simple it is
This is probably the best library I have ever seen
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Upload PDF of 0.9.3 spec.

We should not have the spec in a proprietary form like PDF, is impossible to see a git diff of the changes
Spec should be a file in text, markdown or html or plain text, or combination

yup agree @csantanapr, we are in process of converting it into markdown https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/specification#package-specification but dont want to loose any changes until we have completed the conversion.

How can I track progress on the conversion is there an Issue or PR I can subscribe ?


settings: Fix editing a bot with deactivated owner.

First commit is to show current deactivated owner in options.
Second commit is a small optimization and also a short term fix to allow changing other bot fields if the bot owner is not changed.
Fixes: https://chat.zulip.org/#narrow/stream/9-issues/topic/editing.20a.20bot.20with.20deactivated.20owner

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks great, merged, thanks @sahil839!


[3.0] Multiple consumes / produces

Looks like supporting multiple consumes or produces defaults to */* rather than the concrete types:
@POST
@Operation(summary = "Create user",
  description = "This can only be done by the logged in user.")
@Consumes({"application/json", "application/xml"})
public Response createUser(
    @Parameter(description = "Created user object", required = true) User user) {
  userData.addUser(user);
  return Response.ok().entity("").build();
}

Returns this:

the content key should be application/json and application/xml

Resolved by #2290.


Vertical Playground to JavaScript error.

Expected Behavior
It should work.
Actual Behavior
The console says this:
vertical_playground.html?dir=ltr&toolbox=categories&side=start:133 Uncaught TypeError: Cannot read property 'workspaceToCode' of undefined
at toCode (vertical_playground.html?dir=ltr&toolbox=categories&side=start:133)
at HTMLInputElement.onclick (vertical_playground.html?dir=ltr&toolbox=categories&side=start:492)
toCode @ vertical_playground.html?dir=ltr&toolbox=categories&side=start:133
onclick @ vertical_playground.html?dir=ltr&toolbox=categories&side=start:492
Steps to Reproduce

Make a script
Click "To JavaScript"

Operating System and Browser
Chrome, Windows 10

@amazingmech2418 We currently do not support the use of code generators with Scratch Blocks. We recommend you use the Scratch VM (https://github.com/llk/scratch-vm).


Peer To Peer Code Review

This pull request is meant for peers to check the quality of the code if it follows  DRY, KISS, and YAGNI rules

Thank you. :+1:


create rs/tfzr.txt

Institution/School Name
University of Novi Sad - Technical faculty "Mihajlo Pupin" Zrenjanin
Instiution/School Website
www.tfzr.rs
Email Users
Please place an x between the square brackets if yes

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[x] Post-graduate research
[x] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

Hi,
It would appear that you have opened a pull-request containing commits from JetBrains/swot which is a fork of this repository (leereilly/swot).
If you intended to create a pull request for JetBrains/swot, may I suggest you create a pull request there.
We cannot accept your pull request if it contains more than one institution, as is the case here.
If you want your institution to be included please follow the following steps:

Delete your fork of swot
Create a new fork of swot based upon this repository
Create the file (and directories if necessary) to add the institution to your fork
Open a new pull request against this repository to merge your fork.

I am closing this pull request, as it is for the wrong repository.


Make column statistics for MYSQL optional, disable by default.

Column statistics could get too large because of the size of the table which could cause issues while streaming the data. Disable it unless explicitly required.
mysqldump: Couldn't execute 'SELECT COLUMN_NAME,                       JSON_EXTRACT(HISTOGRAM, '$."number-of-buckets-specified"')                FROM information_schema.COLUMN_STATISTICS                WHERE SCHEMA_NAME = 'onboarding_production' AND TABLE_NAME = 'acquisitions';': Unknown table 'COLUMN_STATISTICS' in information_schema (1109)

I see. Well it seems the workaround is to supply this argument: --column-statistics=0.
You know what'd be great? A pull request that adds a feature to this gem to supply any arbitrary CLI options and values. 😺


Self Linking does not render

Describe the bug
When attempting to create a link where the source and target node are the same, it does not appear to work.
EG:
const data = {
  links: [
    {
      id: "ParentId",
      source: "Account",
      target: "Account",
      label: "ParentId"
    },
    {
      id: "BillingContact",
      source: "Account",
      target: "Contact",
      label: "BillingContact"
    }
  ],
  nodes: [{ id: "Account" }, { id: "Contact" }]
};

To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/restless-sound-jo7o8?file=/src/App.tsx:113-423

Expected behavior
I would expect that there would be a "self loop" from Account -> Account with the label of ParentId

Screenshots

Environment:
See Code sandbox
Additional Information:
Related Question on Stackoverflow

This currently isn't supported, however I can see how this could be a useful addition to the library. This is what I was able to achieve by adding a condition to build a self loop when the source and target have the same x and y values in the buildLinkPathDefinition function in link.helper.js:

So it seems like implementing this would not be too complicated. However I do have some questions/concerns that I'd want to be addressed before moving ahead with this:

How can we add this feature without breaking existing graphs? (We could add a new option in the config to enable self loops)
Since this link can't be manipulated (stretched, rotated) by moving the node, how do we decide the default dimensions and positioning of the link? Or how do we let developers have control over this?

Would love to get your thoughts on this @danielcaldas @LonelyPrincess

Since this link can't be manipulated (stretched, rotated) by moving the node, how do we decide the default dimensions and positioning of the link? Or how do we let developers have control over this?
I think if you can achieve the behavior you have in that screenshot of yours, that would be perfect, even if you have some hardcoded values it would be a great start & addition to being able to render self links.

How can we add this feature without breaking existing graphs?
It's ok to have breaking changes, we can tag it with breaking change if we decide to move in that direction.

Ok sounds good. I will get a pull request going then.


Action & EventsRef

What would you like to be added:
The EventsRef option for Action definition is confusing, it really seems to be an RPC call where the transport protocol is cloud-events (the remote-procedure is invoked via an event and the response is received via another event).  This really seems like another way to invoke a 'function', and thus, in my humble opinion, should be redefined as a type of function, rather than a separate type of action.
Why is this needed:
As the Action is defined now, it's really unclear at first read what these 'events' in the eventsRef are for.  It took me several reads through the entire spec to understand what this is doing.  It would be much easier to understand if this were redefined so that this is just another type of 'function' rather than a different type of action.
Proposal:

Remove the 'eventsRef' attribute from 'action' definition
Add support for a new type of 'function', re-purposing the description for eventsRef.

Same behavior, but as a 'function', because what it seems to be describing is a way to 'invoke' something via cloud-event.

@jorgenj Sorry I respectfully disagree with this :)
Maybe the documentation is not clear or does not give enough examples. I give you that for sure.
However creating a "function" definition for this is imo not the best approach and the one we have now IMO does what is expected which is to produce an event and then wait for a results event to arrive before proceeding workflow exec.
There are many situations where you want to invoke 1 or more services/functions and where those are triggered by events, see for example https://quarkus.io/guides/funqy. To support these types of situations we only need to worry about sending the appropriate event, and then wait for an event which describes the completion of 1+ services/functions that are invoked after.
Using trigger and result ref event references in this case to me at least makes perfect sense as it is in the spec currently.

@jorgenj just to add sorry forgot, when you use "function" definitions, you know exactly what service you want to invoke and what operation on it you want to trigger. With event-based actions you might not know or need to know what service will be invioked or how many, that is the use case of it. Hope this helps.

Following up from the discussion on the call this morning, there was some good discussion on this idea.  My take on the discussion (correct me if I'm wrong) was that there is support for exploring this idea further.
Here's an example workflow that would use eventRef-based action, but re-imagined as another type of 'function' rather than a different type of action:
{
   "id": "sampleWorkflow",
   "version": "1.0",
   "name": "Sample Workflow",
   "description": "Sample Workflow",
   "events": [
    {
      "names": ["StartEvent", "DoneEvent"],
      "type": "org.events",
      "source": "eventssource"
    }
  ],
   "functions": [
       {
          "name": "FnFoo",
          "type": "event",
          "triggerEventRef": "StartEvent",
          "resultEventRef":  "DoneEvent",
          ...
       },
       {
          "name": "FnBar",
          "operation": "https://hellworldservice.test.com:8443/api/api.yaml#myOperation",
          ...
       }
   ],
   "states":[
      {
        "name": "MyState",
        "type": "operation",
        "actionMode": "sequential",
        "actions": [
            {
                "refName": "FnFoo",
                "parameters": {
                    "applicant": "{{ $.customer }}"
                }
            },
            {
                "refName": "FnBar",
                "parameters": {
                    "applicant": "{{ $.customer }}"
                }
            },
        ],
        "end": {
            "kind": "default"
        }
    }
   ]
}

Note that, for this example I assumed that the properties of 'functionRef' under 'action' would be merged into the action definition, and that the eventRef and functionRef attributes would then be removed.

@tsurdilo @manuelstein What do you think about the example proposed above?

@jorgenj couple things that come to mind looking at the provided example:

I rather not make function and event definitions depend on each other, especially since we claim they are reusable. In your example the runtimes pretty much are forced to parse the events definitions first. We added recently ability to externalize function and events defs into separate files, and adding a dependency now between these two arrays will bring more problems then solve them.

the use of type=event is clunky imo, we also removed the type param from function defs recently.

We currently have action data filters and event filters (which needs to be revised anyways). It is not clear which to use at this point as with function exec we have the function results, with events we have the event body as result. So this would complicate things some more around that imo.

"parameters" makes sense for functions, but not for events, where we are dealing with context properties and event body data.

I will take a deeper look but this is just a quick overview.
WDYT?

Hi, very good points!
Regarding 1, I think it could be solved allowing inline event definitions instead of eventRefs. If the subroutine consists of sending an event of type X and expecting an event type Y from a specific source, then that's fine.
functions:
  - name: "FnFoo"
    type: "event"
    outgoing:
      specversion: "1.0"
      type: "com.example.order.accepted"
      source: "/users/should/control/that"
      id: "should:probably.be-generated@by_workflowengine"
      dataschema: "http://my.schema.com/outgoing.json"
      data: |
        {
          "maybe": "we",
          "can": "allow",
          "defaults": "and",
          "references": [
            "$my.path.to.workflowdata",
            "$another.path.to.data",
            "$replace.me.magically".
            "$should_these_become_parameternames"
          ]
        }
    incoming:
    - type: "com.example.goods.delivered"
      source: "/from/the/delivery/team"
states:
  - name: "MyState"
    type: "operation"
    actionMode: "sequential"
    actions:
    - refName: "FnFoo"
      parameters:
        - should_these_become_parameternames: "$.nowWereTalking"

But looking at the example really makes me wonder if we want to wrap event exchanges with function declarations.
Is sending and then waiting on an event so much more difficult?
It would also allow us to send it in some state and consume events that result from this trigger much later.
About the type = event, I thought we had made type = openapi the default so it can be omitted.
I think the filters in eventDataFilter and actionDataFilter do the same thing, only that action can have filters on input and output data, event can only have output filters, but that is kind of confusing when it applies to an incoming event, so yes, maybe this can be aligned. I'm not sure if the filtering the data that can be used as input parameters is a useful thing. It allows the workflow designer to filter what can be used, and as the next step the workflow designer would select what is being used.
If it was all ouputFilters, i.e. decide which paths from the result go where into the JSON workflow data, then a single filter mechanism for all incoming JSON structured data would be enough.
The exception may be states, where filters on outgoing workflow data may be useful, but only from a runtime implementation point of view, not from the designer's perspective.
Good discussion, I'm also going to take another look.

In summary of today's discussion (please add points I'm missing):

the proposed type=event function definitions would make it easier for users to make event-based "invocations" (situations where an event is sent and some other event is awaited as response)
reusing existing outgoing/incoming event definitions should be the baseline functionality; inline definitions could be an additional feature
the event definition must not reference runtime workflow data (references into future workflow data makes it even less reusable)

also noted:

a function call is a transaction per HTTP transport, so results and errors invoking the function should be visible in responses, i.e. within the scope of the transaction; but an event-based invocation may have other independent outcomes signalling an error or result; regarding errors, the timeout to send the outgoing event as well as a timeout to receive the expected response would be the only error cases for now; regarding multiple "reponse" events may require some more design

Another idea that came offline is:
Making an event-based invocation a "function call" still feels weird. The spec currently defines actions and the only actions we're putting there are function calls. An event-based invocation or trigger of work is definitely an action, so we need to somehow have an action that sends an event.
Thx @tsurdilo for pointing out that we have one kind of event-based service invocation example in which the state action invokes work with a function call (asynchronous) and then waits on an eventRef. What we would need here is to have an action that just sends an event, e.g. an outgoing event definition as an action (and selecting some metadata + data)

@manuelstein nice, thanks for the summary!! Will think about it some more and try to have more info for our next meet. Many thanks.

After thinking some more about this I feel that

we need to keep event and function defs separate. no references or some sort of combinations
if improvements need to be done then those should be in the actions definitions


Pathlib fix to examples bug

Thanks @evan-greenbrg, looks good to me! @jammont Please merge if you concur.


Cannot create output files

$ protoc --tonic_out=server/src protos/base.proto
_: Tried to insert into file that doesn't exist.

k, found the solution in a nested readme:
* `no_include(=<boolean>)`:  Skips adding an include into the file generated
  by `protoc-gen-prost`. This behavior may be desired if this plugin is run
  in a separate `protoc` invocation and you encounter a `Tried to insert into
  file that doesn't exist` error.


Animation positions slightly off when browser window height tall enough to not have scroll bar

This is a weird one, but I believe it is related to how the window width is calculated depending on if a scroll bar is present or not. If I shrink my browser height to where it has a scroll bar, the items animate perfectly into the right locations. When my browser window is taller, and there is no scroll bar, the items sometimes animate into positions that might be 5-10px off from where they should be, and then snap into the right place a second later.
Just checked, and it also happens on the MixItUp home page demo in Chrome when you switch from blue to green filters. Because the MixItUp page is very long, it always has a scroll bar. If you delete all the content below in Chrome inspector, so there is no scroll bar, you will start to see it at certain window widths, especially in a mobile width.
Here's a gif of what I mean.

Unfortunately the change in viewport width as a result of in-chrome scroll bars being added/removed is not something we can control or detect easily, and as you have shown can cause animation paths to be miscalculated. I recommend avoiding any sort of above-the-fold layouts that results in a dramatic height change this reason.


Single-char lookaround?

TL;DR: Is it reasonable to support lookaround ((?=, (?!, (?<=, (?<!) where the lookahead is restricted to a single character class?
Describe your feature request
Fundamentally, it seems that the functionality already exists, because \b (word boundary) exists. \b is a kind of lookaround -- it asserts that one side is \w and the other side is \W|\A|\z (anchors can't be put in a character class). Expanded to explicit lookaround, you could write \b as (?:(?<=\w)(?!\w)|(?<!\w)(?=\w)).
It would be nice to be able to do what \b does, but with arbitrary character classes, not just \w. The obvious example is reserved words in a language; given UAX31 identifiers \p{XID_START}\p{XID_CONTINUE}*, you could match a reserved word as \bbool\b, but this is not quite correct, because \w which \b is checking for is [\p{Alphabetic}\p{M}\p{Nd}\p{Pc}\p{Join_Control}], which is a different character class than \p{XID_CONTINUE}. The correct way to match a reserved word would instead be (?<!\p{XID_CONTINUE})bool(?!\p{XID_CONTINUE}), which properly matches borders of the UAX31 identifier syntax.
Obviously, even if much of \b's handling can be reused, this is a relatively major expansion to what regex is capable of (e.g. regex-syntax doesn't even parse lookaround groups). However, it seemed worth asking, if only to find out why it's more complicated than it seems to do so.

I am pretty opposed to this personally. Dealing with a Unicode-aware \b is a huuuuuge pain, and is generally treated as a special case in most places. Adding more support for Unicode-aware look-around is not something I'm personally interested in pursuing or maintaining at this point.

I'm going to close this out because I personally don't see this happening.


Command failed with exit code 129: git -P shortlog -nes -- README.md

It's reason for
 const { stdout } = await execa(
    'git',
    ['-P', 'shortlog', '-nes', '--', filePath],
    {
      cwd,
      stdin: 'inherit',
    }
  )

https://github.com/vuepress/vuepress-next/blob/main/packages/%40vuepress/plugin-git/src/utils/getContributors.ts
cause -P ?

Could you provide more context?

os
shell
git version
steps to reproduce

This command has not been fully tested, and it might fail in some environments. But it will not help if you don't provide any context.

My context:

MacOS
vscode
<EMAIL_ADDRESS>
I'm use GitLab by company, cause this？

Try to upgrade your git.
-P is available after 2.18.0
https://git-scm.com/docs/git/2.18.0#Documentation/git.txt--P


V2 - Error message should be displayed in next line in Request Failed dialog and also cla-manager-desginee should not be mentioned in the error message

As suggested by @pranab-bajpai  in stand up call below issues needs to be fixed
Issue1
In request dialog displayed in any of the contributor flow the error: part should be displayed in next line. Below is one of the example

Issue2
In request dialog displayed in any of the contributor flow if error message contains cla manager designee it should be replaced with cla manager as contributor is not aware of the cla manager designee role. Below are few examples

Verified and observed that Issue1 is still reproducible
cla-manager-designee is still displayed in the error message. Where ever applicable in the contributor console, cla manager should be displayed instead of cla-manager-designee

Issue2 is not reproducible. In case we find the issue again then will create another bug for the issue

Issue1 still exists, Observed below issue while identifying cla-manager-designee

Verified that the issue is fixed


Modify request static file path in StaticFileHandler

Thanks @xielibin - could you submit a use case where this is an issue please?

@iamjono
First, clone PerfectTemplate project and add
routes.add(method: .get, uri: "/**", handler: {
    request, response in
    StaticFileHandler(documentRoot: request.documentRoot).handleRequest(request: request, response: response)
})

to main.swift file.
Second, build PerfectTemplate and launch project, add a test.html file to ./webroot directory.
Next, request http://localhost:8181/test.html,  then the func handleRequest in StaticFileHandler
var path = request.path

the path is "/test.html" and documentRoot is "./webroot", so 'documentRoot + "/" + path' is "./webroot//test.html", the file will not be found.


Enable Filesystem construction destruction test

This verifies the fix in dbf17b4.

TravisCI build failure for GCC job is fixed in PR #119.


Sanitize MaxMind GeoIP key. Implements #10797

[X] Redmine Issue: https://redmine.pfsense.org/issues/10797
[X] Ready for review

maxmind_geoipdb_key - Suricata
maxmind_key - pfBlockerNG, NTOPNG

@vktg please rebase your fork and fix conflict

@vktg please rebase your fork and fix conflict

conflict resolved


Non-tabular data structures and data files repositories

Problem :
Open MetaData is strongly oriented towards SGBD databases / schemas and tabular relations and needs to expand its definitions to allow for nested data structures to be able to represent most NoSQL data (ex : elasticsearch, mongodb, or even json and xml files)
Additionnaly The enum for storage services should be expanded to allow for classic files storages (ex : local/lan storage (nfs, dfs, etc.), FTP and HTTP file servers, RSS feeds, etc.) and underlying data structures should be able to represent path-like directories structures and data models.
Solution :

Expand the storage services enum to allow for a generic/custom storage, and or, a few specific (file system, ftp server, http server, etc.)
Ability to ingest various industry standards schema definitions (.xsd files, json schemas, csv headers, etc.) and to parse sample files to extract metadata to document various formats for the content of a storage container (xml files or rss feed, json files, csv or parquet files, etc.)
Allow to define documents, as an alternative to tables a hierarchy mirroring the database / schema / tables could be container / structure / document, We should be able to nest documents definitions with json-schema referencing

c.f. https://openmetadata.slack.com/archives/C02B6955S4S/p1673875713923919

we support elastic, mongodb and other NoSQL sources


topic(setMetadata):  messageRetentionDuration not working

Environment details

OS: MacOS Monterey v12.4
Node.js version: v16.14.2
npm version: 8.5.0
@google-cloud/pubsub version: 3.0.1

Steps to reproduce
Create subscription & setMetadata
const THREE_DAYS_IN_SECONDS = 3 * 24 * 60 * 60
const [topic] = await new PubSub().topic('test').get({ autoCreate: true })
await topic.setMetadata({ messageRetentionDuration: { seconds: THREE_DAYS_IN_SECONDS  } })

Error thrown
Error: 3 INVALID_ARGUMENT: Invalid update_mask provided in the UpdateTopicRequest: 'messageRetentionDuration' is not a known Topic field. Note that field paths must be of the form 'push_config' rather than 'pushConfig'.

It seems that messageRetentionDuration is not mapped correctly given this test: https://github.com/googleapis/nodejs-pubsub/blob/e4b8adc22a24ffa61bf6486fd71c05de234e3f51/system-test/pubsub.ts#L537

Hi @ndeitch, I had this issue today and updated to 3.1.0 resolved my issue

@ndeitch here is my temporary workaround
the topic.request is implemented based on the topic.setMetadata() function. So now you the parameter of setMetadata go to reqOpts.topic, fields are camelCase and in the reqOpts.updateMask.paths. specify field you want to update with _
 const topic = client.topic(topicName);
    const [topicExists] = await topic.exists();
    if (topicExists) {
      console.log(`Topic ${topicName} already exists`);
      return;
    }
    try {
      await topic.create();
      topic.request(
        {
          client: 'PublisherClient',
          method: 'updateTopic',
          reqOpts: {
            topic: {
              name: PubSubClient.getFormattedTopic(topicName, client.projectId),
              messageRetentionDuration: { seconds: '604800s' },
            },
            updateMask: {
              paths: ['message_retention_duration'],
            },
          },
          gaxOpts: {},
        },
        (err, data) => {
          if (err) {
            console.error(`Error setting topic metadata ${topicName}`, err);
          }
        },
      );
      console.log(`Topic ${topicName} created`);
    } catch (err) {
      console.error(`Error creating topic ${topicName}`, err);
    }

Thanks @nguyen-vo for the workaround. I peeked at the code, and it looks like this method (in src/topic.ts) was probably written before we had multi-word topic metadata to update. So it needs to convert the name for the update mask. This shouldn't be a lot of effort, but there's a bunch of work ahead of it in the queue right now. :|


Update licenses to 2019

Small fixes to copyright years on all files.

ACK!
We need to update the licenses before this year is over!  😆

Looks good to me

Almost too late
Ack but maybe we can go to 2020 now

Needs rebase!

🤣