Fix FFT norm (pyfftw & numpy)

Fixing problem on normalization of FFT
Usual normalization is on backward FFT ( ./1 on forward & ./N on backward) but we can expect to have a non-normalize FFT (with parameter normalize="none"), this option is not implemented correctly
Solution & modifications :

numpy : norm="backward" on FFT & norm="forward" on IFFT
pyfftw : normalise_idft=True on FFT & normalise_idft=False on IFFT

(There is also a problem with pyfftw implementation, it does not have the expected behavior with the last version (0.13), https://github.com/pyFFTW/pyFFTW/issues/341
but the solution normally bypass this problem)
TODO

[ ] requirements for numpy version ? >= 1.12 ? or different in setup.py ? (if >= 1.10, a case could be avoided in npfft.py)
[ ]  normalization "by hand" if numpy version do not allow normalization="none" ? or keep a warning ?
[ ] need to be tested with both version of pyfftw 0.12 & 0.13

Failure on old numpy implem ?
================================== FAILURES ===================================
______________________________ TestNumpyFFT.test ______________________________
self = <silx.math.fft.test.test_fft.TestNumpyFFT testMethod=test>
def test(self):
"""Test the numpy backend against native fft.
    Results should be exactly the same.
    """
    for trdim in self.transform_infos.dimensions:
        for mode in self.transform_infos.modes:
            for size in self.transform_infos.sizes[trdim]:
                with self.subTest(trdim=trdim, mode=mode, size=size):

                  self.__test(trdim, mode, size)

venv_test\lib\site-packages\silx\math\fft\test\test_fft.py:267:

venv_test\lib\site-packages\silx\math\fft\test\test_fft.py:282: in __test
res = F.fft(input_data)
venv_test\lib\site-packages\silx\math\fft\npfft.py:129: in fft
return self.numpy_funcs[0](array, **self.numpy_args_fft)
<array_function internals>:6: in rfft
???
venv_test\lib\site-packages\numpy\fft_pocketfft.py:367: in rfft
if norm is not None and _unitary(norm):

norm = 'backward'
def _unitary(norm):
if norm is None:
return False
if norm=="ortho":
return True
raise ValueError("Invalid norm value %s, should be None or "ortho"."

                   % norm)

E       ValueError: Invalid norm value backward, should be None or "ortho".
venv_test\lib\site-packages\numpy\fft_pocketfft.py:88: ValueError
============================== warnings summary ===============================
gui/plot/test/testPlotWidget.py::TestPlotAxes::testAxisExtent

requirements for numpy version ? >= 1.12 ? or different in setup.py ? (if >= 1.10, a case could be avoided in npfft.py)
normalization "by hand" if numpy version do not allow normalization="none" ? or keep a warning ?

Still CI failures :
================================== FAILURES ===================================
_____________________ TestMaskToolsWidget.testWithAnImage _____________________
...

Thanks!
From what I see in requirements.txt and pyproject.toml, the minimum required numpy version is 1.12, not 1.8.
To simplify version comparison a little bit, you can use from pkg_resources import parse_version, eg. parse_version("1.10.2") > parse_version("1.8.0").
The latest CI failures seem related to GUI (happens from time to time)

Test fails for numpy == 1.19.5. Seems to be because not all normalization were available for this version.
Just tested on my machine:

test_norms fails with numpy==1.19.5
test_norms passes with numpy==1.20.0

Tested with pyfftw 0.12 and 0.13.


Swagger UI specs for submitting answer to question does not render well

Very unimportant stuff. With swagger UI off 1ff9cea, for POST /assessments/question/{questionId}/submit,

Example value is shown as

{
  "answer": "Unknown Type: string_or_int"
}

When sending a valid request via the UI, server response code is 200, but response body is "Unknown response type"

Submitting the answer itself works fine though, so not a big concern.

Our swagger version does not let us define fields that may be one of a few types. It's either this or "string_or_int".
I'll fix that. It should affect other endpoints as well.

Understood, thanks


fix(nav-divider): hotfixed nav specific style conflict

Preview: https://patternfly-next-pr-2788.surge.sh

:tada: This PR is included in version 2.68.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Upgrade to NEST 7.0 serializer issues.

I upgraded to elasticsearch 7 from 5 and one area that bit me and caused me about a days worth of work was trying to figure out why my models were not being serialized correctly. I was under the impression that in 7.0 that all serializer settings configured were only for my models and that was it. This is where I went wrong...
I injected my applications serializer settings and configured it like this thinking it would use all my serializer settings:
var settings = new ConnectionSettings(connectionPool,
                (serializer, values) => new JsonNetSerializer(serializer, values, () => _myAppsInjectedSerializerSettings));

After a day of messing around and creating smaller and smaller samples, I found that my injected serializer settings were modified by reference and affected my entire application (NOT Cool). I believe this is being done so NEST Attributes can be resolved (of which we don't use anywhere in our app and have no plans todo). So I was able to rework the following in one of our apps which got us up and working:
var settings = new ConnectionSettings(
                CreateConnectionPool() ?? new SingleNodeConnectionPool(new Uri(_config.ConnectionString)),
                (serializer, values) => new JsonNetSerializer(serializer, values, JsonSerializerSettingsFactory, ModifyContactResolver, ContractJsonConverters));

        private JsonSerializerSettings JsonSerializerSettingsFactory()
        {
            return new JsonSerializerSettings
            {
                DateParseHandling = _serializerSettings.DateParseHandling,
                DefaultValueHandling = _serializerSettings.DefaultValueHandling,
                MissingMemberHandling = _serializerSettings.MissingMemberHandling,
                NullValueHandling = _serializerSettings.NullValueHandling
            };
        }

        private void ModifyContactResolver(ConnectionSettingsAwareContractResolver resolver)
        {
            var strategy = ((DefaultContractResolver) _serializerSettings.ContractResolver).NamingStrategy;
            resolver.NamingStrategy = new CamelCaseNamingStrategy(strategy.ProcessDictionaryKeys, strategy.OverrideSpecifiedNames, strategy.ProcessExtensionDataNames);
        }

       private IEnumerable<JsonConverter> ContractJsonConverters => _serializerSettings.Converters;

One of my main concerns about this is that I don't like that I can't just use my existing serializer settings and there probably is a lot of properties that I'm not syncing.. I'd rather just inject my settings and know it's the same exact serializer settings. Which brings me to my blocking issue.
In Exceptionless, we have a custom contract resolver that depending on the type we use one serializer or the other (here is where we register the serializer). I don't even know how I'd modify the contract resolver in this case.  I could probably get 80% of the way there with a custom naming strategy but we do custom logic in LowerCaseUnderscorePropertyNamesContractResolver.CreateProperty.
Is there a good way to solve this?

cc @Mpdreamz @russcam :)

Is anyone looking at these issues?

Yes. You should know better then most that we take issues seriously. Hope you trust us we were otherwise engaged.

This looks like a manifestation of the recurrent problem that the client needs to make specific modifications to the serializer settings, including the IContractResolver, that could collide with your changes to the serializer settings needed for your application.
You may need to derive from JsonNetSerializer and override CreateContractResolver() to return an IContractResolver that derives from ConnectionSettingsAwareContractResolver which applies any settings that you need, or calls to the base implementation.
I would like to revisit this implementation for 8.x, to see if it's possible to make these components easier to use and modify.

Thanks for the follow up. I’ll start down that path. I get that you are looking at these and working on other things too. I’d figured I’d comment as I looked at the last page of github issues filed and barely any responses (I’m guilty of this too) knowing most of the people who posted are probably blocked, myself included.

So I just referenced a commit here and noticed it wasn't straight forward or how I'd expect/like to configure the serializer. Since the base constructor immediately creates a serializer any overriden methods that I'd implemented to create contracts / serializer settings threw null references and I was forced to create static func implementations to pass to the base constructer which didn't feel idiomatic.

I believe this is being done so NEST Attributes can be resolved (of which we don't use anywhere in our app and have no plans todo). So I was able to rework the following in one of our apps which got us up and working:

Thats correct: Nest.JsonNetSerializer exists to deal with bits from NET in your source documents such as

resolving configured propertynames (attributes/connectionsettings).
As well as handling NEST objects that could appear in your source and might need special care:

typeof(JoinField),
typeof(QueryContainer),
typeof(CompletionField),
typeof(Attachment),
typeof(ILazyDocument),
typeof(LazyDocument),
typeof(GeoCoordinate),
typeof(GeoLocation)

If neither apply it could be more beneficial to create your own IElasticsearchSerializer based on Json.Net and return that from the source serializer factory method you pass to ConnectionSettings. That way we don't bleed into your existing contract resolvers.

I don't think there's anything further actionable on this ticket, are you happy for me to close it, @niemyjski?

I think this can be resolved but there definitely is some work that could take place to make this easier. I almost think my scenario should be the default and you should have to opt into serializer changes that allow you to use attributes. I should just need to inject my serializer settings and be done.

I almost think my scenario should be the default and you should have to opt into serializer changes that allow you to use attributes.

I disagree; When using the JsonNetSerializer, I would expect the default to "just work" where I have used Nest attributes or types on my document POCOs.
We have a discussion point for the next major version to look at making this better/easier/simpler to use, which I am keen to do for the client all round. Closing this.

Searching github code usages... I’m curious as to how many people use the attributes and have a package dependency...
Sent from my iPhone

On Nov 12, 2019, at 9:23 PM, Russ Cam<EMAIL_ADDRESS>wrote:

Closed #4116.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Summarize is slow

For large data sets, summarizing it seems to take too long

On investigation, there was more data than expected and it's actually about as expected.


Release prep utilities

This adds taskipy (https://github.com/taskipy/taskipy) as an development requirement to expose a number of maintenance scripts for ensuring the schema file(s) stay in sync. Readme has been updated with instructions for using.
Closes #48

next release is 0.1.0 not 0.0.2, fix that


OpenTelemetry docs migration (S3M)

Purpose of this pull request
As part of the S3M initiative, migrating docs from here to Sumo Logic Docs.
Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1203954053142116

This is a one-time manual copy of the docs from the OT distro repo at https://github.com/SumoLogic/sumologic-otel-collector/tree/v0.71.0-sumo-0/docs into this repository. This begs the question: how will the updates be handled between these repositories? We all probably want to have a single source of truth, whether in this or in the OT distro repository.
The problem with keeping the OT distro docs only in this (Sumo Docs) repo is that this repo does not support versions, so it's not possible to look up configuration for a specific previous version of the software. For example, if the latest released version of the OT distro is v0.71.0-sumo-0 and the user is currently using v0.69.0-sumo-0, they have no easy way to see the docs for the version they use.
My proposed solution is to keep the original docs in the OT distro repository together with the code, and provide an automated mechanism that will update the Sumo Docs repo on every new release of the OT distro.

This is a one-time manual copy of the docs from the OT distro repo at https://github.com/SumoLogic/sumologic-otel-collector/tree/v0.71.0-sumo-0/docs into this repository. This begs the question: how will the updates be handled between these repositories? We all probably want to have a single source of truth, whether in this or in the OT distro repository.
The problem with keeping the OT distro docs only in this (Sumo Docs) repo is that this repo does not support versions, so it's not possible to look up configuration for a specific previous version of the software. For example, if the latest released version of the OT distro is v0.71.0-sumo-0 and the user is currently using v0.69.0-sumo-0, they have no easy way to see the docs for the version they use.
My proposed solution is to keep the original docs in the OT distro repository together with the code, and provide an automated mechanism that will update the Sumo Docs repo on every new release of the OT distro.

Thank you, @astencel-sumo ! I'll let the S3M team know through Slack and loop you in.

Perhaps we could include a link to this migration doc somewhere. This talks about migration from the installed collector to OTC and has example configuration which is being updated.
https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/migration.md


⚠ Spryr has degraded performance

In f57bacc, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5559 ms

Resolved: Spryr performance has improved in d0b1478 after 8 minutes.


restructure assessment with other options

This PR structures the assessment as a whole providing 3 different examples of implementing an assessment workflow using (1) jq expression, (2) custom code and (3) knative function to perform the assessment per se and then return infrastructure workflow options based on a simple use case.
Indeed, the assessment here requires a user input as a string and checks if it it contains the keyword dummy in order to recommend the suitable infrastructure workflow options.
The goal here is the provides different options to developers to start writing assessment workflows for the orchestrator.

@anludke Please provide a meaningful commit description to enable the review for this PR"

I had a quick look at it but, due to the huge number of files and the fat that these are new examples added to the repo, instead of validating these changes on my repo I'd suggest to have a meeting where you can show live the workflow runtime.
WDYT?
FYI @masayag

@anludke @masayag @dmartinol have we had the meeting to talk about this PR? or is it ok to continue review?

It's fine for me even with no meeting, but I'll leave the last word to @masayag

Add minor comments, other than that, LGTM.

another quick look. \lgtm but I would add brief explanation of how these implementation are different. apart from that, well done

Brief explanation added to each implementation


Minder deadlocks during querying message

Describe the issue
Log messages from the issue:
{"level":"debug","subscriber_id":"01J9V7E9W1T6K2F6Y6YNDYMARG","topic":"originating.entity.add.event","consumer_group":"","err":"could not query message: pq: could not serialize access due to concurrent update","caller":"github.com/alexdrl/zerowater@v0.0.3/logger.go:42","Timestamp":1728564837863219192,"message":"Deadlock during querying message, trying again"}
{"level":"debug","subscriber_id":"01J9V7E9W1T6K2F6Y6YNDYMARG","topic":"originating.entity.add.event","consumer_group":"","err":"could not query message: pq: could not serialize access due to concurrent update","caller":"github.com/alexdrl/zerowater@v0.0.3/logger.go:42","Timestamp":1728564837996620696,"message":"Deadlock during querying message, trying again"}
{"level":"info","webhook-event-type":"registry_package","providertype":"github","upstream-delivery-id":"b57d0e40-8706-11ef-8f4d-db1e4f82d88d","message_uuid":"0ad12abc-6fca-4feb-9c57-e2febd9c8351","caller":"github.com/stacklok/minder/internal/controlplane/handlers_githubwebhooks.go:595","Timestamp":1728564836398213837,"message":"webhook event registry_package not handled"}
{"level":"debug","subscriber_id":"01J9TTNGVAGFK30MXANG5X5W72","topic":"originating.entity.add.event","consumer_group":"","err":"could not query message: pq: could not serialize access due to concurrent update","caller":"github.com/alexdrl/zerowater@v0.0.3/logger.go:42","Timestamp":1728564836806960071,"message":"Deadlock during querying message, trying again"}

To Reproduce
No response
What version are you using?
No response

We debugged it and this is a real issue and it's annoying but it was not causing the problem we were looking to solve. The issue was there was an enrolled org that had private packages and that was causing 404s when Minder was trying to call the provider. Closing this and we'll address the findings in another issue/thread.


Search does not trim for HTML

Say I want to search for all cards that contain the words "Runner cannot use AI".
If I use X:"runner cannot use AI" i get no hits.
This is because AI is bold, so actually including the HTML tag "strong" will work:
https://netrunnerdb.com/find/?q=x%3A"runner+cannot+use+<strong>"
Would suggest trimming formatting before matching to avoid this!

That's a good point and a good idea. I don't know how we'd accomplish it, but it's definitely needed (same with searching for symbols).

What language is NRDB coded in?
what query language/engine does the search use?
I think this is pretty easy to do

Php and the query engine is hand-rolled lol. In CardsData

Not a php coder unfortunately, but wouldn't this method be usable:
http://php.net/manual/en/function.strip-tags.php

Oh nice!


Non-go user interface of mapreduce

We want to explore the possibilities of non-go user interface by using grpc.
Let's discuss it here. @plutoshe

I have some idea about the non-go user interface in processing.
I separate the progress into 2 steps
taskgraph serve receives the user's grpc server adress
... // other user configuration
rpc SetUserRoute(UserAddress) returns (responseMessage) {}
...

Then the user endpoint serves as the grpc server, and task graph access
rpc MapperFunc(stream KVpair) returns (stream KVpair) {}
rpc ReducerFunc(stream KVpair) returns (stream KVpair) {}

Maybe it's better to input store file name of input data.
As a result, the user only call the task graph to tell its grpc address , and implement their own mapper and reducer function by their own preference.
But, the defect is that it's too crowd and probably failed for only a user serve handles all request.
@fengjingchao , do you have any better idea?

... receives the user's grpc server
rpc SetUserRoute(UserAddress) returns (responseMessage) {}

Since they sit on the same container, I think we can have predefined port in task config.

... access the grpc server of user
rpc MapperFunc(stream KVpair) returns (stream KVpair) {}
rpc ReducerFunc(stream KVpair) returns (stream KVpair) {}

No Func suffix needed.
Let me think about the design more. At the mean time, you can start studying docker and writing the Map, Reduce server stuff.

Sure.


BUG: Fix ValueClick bug to display proper information for scan types.

I found when using ARTview in RHI and Airborne mode that the ValueClick was not displaying the correct information. I generalized the ValueClick class for plot_radar similar to the plot_grid and also updated the tools to be reset when a different file type is opened.

It looks ok, but I can not be sure these calculation are correct just by looking at it. If you have tested, I would be ok with it.

I tested with a few files and also compared to Solo Editor for an airborne example.
I'll merge this and move onto the next item. I'll be working on adding text to the image as a tool next.

ok


[NDM][NDMII-2815] use the cache container for netflow test

What does this PR do?
Application of this doc
Motivation
Following this commit, we want to be consistent and to use the same registry for netflow and snmp
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


read_csv breaking on 50 GB+ tsv file

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Modin version: 0.9.1 (modin.__version__):
Python version: 3.7.9 Intel Corporation:
Code we can use to reproduce: Please contact<EMAIL_ADDRESS>for more information on the code and dataset.

Describe the problem
When using the read_csv command, modin crashes with a raylet error on a 50 GB+ dataset. When passing in a parameter of nrows=100000 to reduce the amount of data present, the command functions as predicted, but it will break for the whole dataset.
Source code / logs
Please contact<EMAIL_ADDRESS>for more information on the code and dataset.
 Shutting down.

@aregm  @gshimansky

CURRENTLY PAUSED DUE TO LACK OF MEMORY ON USER'S LOCAL MACHINE

Hi @raoberman @aunell, a 50GB tsv should still be possible with out of core. Can we try again with the latest versions of Modin and Ray?

Ray often logs cause of failure when a worker dies. Please add RAY_LOG_LEVEL=DEBUG and RAY_BACKEND_LOG_LEVEL=debug environment variables so that Ray would log even more information. Also, if worker crashes, it is possible to debug it with gdb (adding RAY_RAYLET_GDB=1 RAY_RAYLET_TMUX=1 to environment) according to Ray debug page https://docs.ray.io/en/master/debugging.html. This way you can get worker stack trace.

Hi @aunell! I'm marking this issue as resolved since it hasn't been updated in a while! If you have any further questions, please feel free to reopen this issue, or open a new one!


[SPARK-36951][PYTHON] Inline type hints for python/pyspark/sql/column.py

What changes were proposed in this pull request?
Inline type hints for python/pyspark/sql/column.py
Why are the changes needed?
Currently, Inline type hints for python/pyspark/sql/column.pyi doesn't support type checking within function bodies. So we inline type hints to support that.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test.

Test build #144039 has started for PR 34226 at commit 40fc2e6.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48516/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144039/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48516/

CC @ueshin @HyukjinKwon @itholic @zero323

Test build #144097 has started for PR 34226 at commit 624817c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48575/

Test build #144102 has finished for PR 34226 at commit c88aa04.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48580/

Comments aside, LGTM  (sorry for some noise).

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48580/

LGTM if the conflicting resolved

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48584/

oops, there are some conflicts here. @xinrong-databricks would you mind updating the Pr please.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144107/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48585/

Test build #144161 has finished for PR 34226 at commit 436fa61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48639/


Mislabeled Bank B pin 6

In the symbol, Bank B Pin 6 is labelled E2, when it should be labelled B2. Bank B pin 3 is correctly labelled E2

Sorry I only saw your issue now I will correct asap

Sorry I forgot to push the commit


Update controller.stub

Formatted.

If I may ask, why was this PR closed without being merged?
We need an explanation, please.


Make up a new exercise equivalent to old hello-world

For those languages where the old hello world wasn't too complex, it would be nice to have an additional exercise that can fill the space between the new hello-world and other simple exercises.
There are a couple things that this exercise can help people discover if they get feedback on it, though one of them depends on the language.
falsiness (maybe JavaScript specific)
We see a lot of if (input == "") which means that we can suggest that people look into the concept of falsiness to find simplifications.
overly complex conditionals
There are at least six or seven ways that people make their conditionals more complicated than necessary, or make them contain a lot of duplication.
The second point leads nicely up to the Leap problem.
bonus: guard clauses
Sometimes they'll also do if (x) { return y } else { return z }, which means that we can talk about minimizing indentation and leaving off the else if the if is returning.
Anyway: I think that it would be useful to have a new exercise that implements a similar thing as the old hello world:

optional and default input value
combine that value with some extra string template-y stuff, conditionally

To rename the former hello-world into greeter and keep everything as before was already discussed in the original proposal. I'd vore for keeping that old hello-world as well but don't care for naming though ;)

Re falsiness:
Falsiness is not specific to JS, it's a concept known to ruby and elixir as well, maybe the interpretation of some values might differ between languages. For ruby and elixir "" is a truthy value though. Also even in JS one might to consider returning "Hello, World!" while raising on anything thats not "real" string, so I like the explicit equality check here, but I'm not an JS expert (or would even us it voluntarily), so I don't know (or care for) idioms of the language.

re overly complex conditionals
Wait? Six ways? which ones?

re guard clauses/statements
I'm not sure if this is necessary. For go it seems to be idiomatic to omit that else branch in these cases, while in ruby one does keep it to avoid an explicit return while in haskell you can't even omit that else branch!

Besides of these 3 items, I'd go for another one that could be valuable for this exercise, the default value for a missing argument of a function if it is an available feature of a language.
It should be a track driven idiom through the tracks though, as I've heard idioms are different across languages.
e.g.:

For elixir it is idiomatic to use the exact value that you want to use as a default value anyway
For python I was told it were idiomatic to set the default to Nil (or whatever they call it again), and have an extra if that adjusts the real to use value to the wanted default value.

It should be a track driven idiom through the tracks though

Yes, absolutely. My main point is that I think that this exercise fills a useful niche. The lessons it makes possible will be different in the various tracks, I was mainly pointing out that there are lessons.

Agreed. Dealing with optional/null values is an important skill and perfectly suited to its own exercise I think.

Ok, so how about the following?
slug: business-buzzwords
name: Business Buzzwords
Template: People, in the next year we need to X. It is what it is.
Some examples of X:

enhance dynamic web-readiness
cultivate leading-edge systems
repurpose e-business markets

We can have any default that we care to, of course.
For inspiration, google "catch phrase generator" or "buzzword generator".

I like it! Tongue-in cheek and all.

Wait, is this entire issue about "reintermediate bleeding-edge Programs"?  (From the buzzword generator, already handy).
The proposal for business-buzzwords sounds like a "Mad Libs" type engine.

@rpottsoh pointed out that we have an open issue #290 that is no longer relevant to the old hello world. It may be relevant here.

The proposal for business-buzzwords sounds like a "Mad Libs" type engine.

I think that it could be a Mad Libs type engine, but I'd like to have it be a very straight-forward replacement to Hello World.
If we want to use buzzwords as a mad libs exercise, then we should come up with something else for this one.
How about:
Title: Two Fer
Slug: two-fer
Template: "One for X, one for me."
Where X is either a name, or it defaults to "you".

Sorry I have to ask, but what's a "mad libs" exercise?

I like the two-fer idea, straight forward, and flexible simplicity.

@NobbZ.
Pick a noun, another noun, a color, a verb, a living thing.
But pick those without looking at the story that follows...
One day there was a ___ that was ___.  It was a ___ and ___ ___.
The result can be pretty hilarious/silly/fun.  Often a party game with quite a few people... but can be played with kids on long road trips.

@NobbZ here is a quick wikipedia write up on mad labs, a follow on to what @kotp stated.

The discussion seems to have wound down on this one. It sounds like two-fer is the better suggestion as a replacement for hello-world.
Next steps:

[ ] Write up an issue for two-fer with the details of what needs to be done
[ ] optionally write up an issue for mad-libs, if we think it would make a fun exercise (testing randomization could be interesting in a number of languages, using seeds, etc)
[ ] close this issue
[ ] draft an issue to be submitted to all tracks summarizing the hello-world and two-fer conclusions, with an explanation of what needs to be done (ref: https://github.com/exercism/discussions/issues/120)

I've extracted the TODOs from this into new issues.


re-commit badphotocopy update

@proofconstruction  i detached the fork and re-commit those updates but looks like i'm facing a new error in those checks, could you advise again?

black and the trailing comma hook are reformatting badphotocopy.py, you can try to run pre-commit run - - all-files locally to fix the file and then commit again. It looks like the change is in the init method of that class; black wants us to use a new line for each parameter, and the pre-commit hook adds a comma character after the last parameter


What are default dashboard credentials?

I enabled dashboard in the rio install.
However disabling the dns seems to break the rio dashboard command, providing my own ingress let me access the web-page.
Now I can't find what the default credentials would be to access the dashboard...

rio dashboard --reset-admin should allow you to reset credentials. Also be aware of this issue https://github.com/rancher/rio/issues/841.

rio dashboard --reset-admin gives me the same output as rio admin:

Waiting for dashboard service to be ready

Speaking of #841 , I do not have any ressources of that type in my cluster kubectl get users.management.cattle.io -A gives me no ressources.

@ticruz38 Oh I didn't notice that you disabled Rdns. Yeah sound like a problem if you disabled it.

The code assume dashboard must have a valid https endpoint assigned to dashboard services. However if you disabled it you can try to use ingress to access dashboard. There is dashboard service in rio-system namespace.

I do see the dashboard with my own ingress and https enabled, I'm just stuck at the login page, with no valid credentials.
I tried admin admin, my own cluster credentials, nothing seems to log me in.

I am stucked on the same page, on a fresh install.
I can see the dashboard with my own ingress, but the cluster credentials are not working.
How to recover or initialize the credentials ?

Same issue here. Documentation should have information how to login to dashboard.

There is no fixed default; when you run rio dashboard the first time, a random password is generated and put into the link that your browser is opened to.  From there you choose your own password for the admin user.
If you forget that password, there's the --reset-admin flag to repeat the process.

Well, this is expected behavior, but in fact, when I am using --reset-admin flag it shows me login page.


Add an init command

This is just the start of logic to help bootstrap a new directory onto Bazel and Aspect

Moving to silo


Workaround for installation error of BigDecimal 3.1.5 in JRuby

This PR is a workaround for installation error of BigDecimal 3.1.5 in JRuby:
Installing bigdecimal 3.1.5 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

https://github.com/rubocop/rubocop-rails/actions/runs/7192052922/job/19587776909

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR will be closed because the issue has been resolved:
https://github.com/ruby/bigdecimal/issues/279.


feat: add ContentSlot component

add a ContentSlot component which will be used in boards to wrap the actual content(s) of the board.
usually a componnet

why do we need this?


windows: Provide cmd script so top level node commands run smoothly

No thanks. Binary functionality is handled by npm. If it's not working, open an issue over there.


Investigate Slowdown when transferring a lot of data

If we transfer a lot of data, the transmission gets gradually slower. We already tried disabling all logging, to no avail. We should find out why this happens.

New networking code in v2. Please reopen if issue persists.


updated location of MARA training data

Updated address of MARA training data to use the Github repo https://github.com/irenne/MARA since Irene Winkler's old tu-berlin.de website has been shutdown.
Technically, this also downloads sample scripts in addition to the mat files into the external/mara folder, but this should not cause any problems.

Thank you for updating and sorry for the late merge!


Request: Add Method to Return Error Enum Variant Name

I wrote a macro to use in my tests, so that I can verify that an error is of the proper variant and stringification. It looks like this:
macro_rules! assert_err {
    ($x:expr, $e:path, $m:expr, $($f:tt)+) => {
        if let Err(e) = $x {
            if let $e(..) = e {
                assert_eq!($m, e.to_string(), $($f)+);
            } else {
                // XXX Figure out how to get the variant name of e.
                panic!(r#"assertion failed (error doesn't match pattern):
error: `{}`,
pattern: `{}: {}`"#, e, stringify!($e), format_args!($($f)+))
            }
        } else {
            panic!(r#"assertion failed (value is not an error)`: {}"#, format_args!($($f)+));
        }
    };
}

I use it like this:
assert_err!(
    Foo::new(cfg), // returns Result
    Error::InvalidConfig, // Expected error
    "Invalid config: Must have blorf of 10 or more", // Expected string
    "Should have config error for too few blorfs",
);

I'm reasonably happy with this, as it lets me test all variants regardless of their fields. But one thing I'd like to improve is the ability to print the name of the variant if it doesn't match, as mentioned in the XXX comment. Is there a way to define a method on a thiserror-defined error that would return a string (or &str) with the variant name? If not, would it make sense to add such a feature, perhaps with an option to turn it on only for certain configs, like #[cfg(test)]?

I would prefer not to build this into thiserror, but it seems reasonable for someone to create as a separate macro.

I think my description here might have obfuscated the actual request, which is:

Is there a way to define a method on a thiserror-defined error that would return a string (or &str) with the variant name?  If not, would it make sense to add such a feature, perhaps with an option to turn it on only for certain configs, like #[cfg(test)]?

I was not able to figure out how to do this in a macro, but maybe I just missed something.

You can simply have your thiserror enum derive strum's AsRefStr


Update doorkeeper gem to 4.4.0

This mitigates CVE-2018-1000211.

it just needs an update with the base branch but other than that +1 !


Added The Indian Struggle by Subhash Chandra Bose

Merging this will close the issue #73

@USKhokhar, kindly add hacktoberfest label to the pr if needed.


Add breaking change documents 30-39

Aside from some html that should be converted to markdown (though that's not urgent), this looks good to me.


integration test: should wait before issue kill

Signed-off-by: Wang Xu<EMAIL_ADDRESS>

oops, the problem should be a deadlock


doubt with voxel size and xyz format

Hi,
I would like to know if it is possible to define the size or length of the voxel. I have seen that it is possible to define the resolution, which tells us how many slide the input file is subdivided. The idea would be to define a fixed voxel size, at the edges the geometry should be extended or reduced to the size of the voxel.
When the points of each voxel are saved in xyz format, the center of each voxel is saved right?
thanks

Hi @MKe2013 ,
I have just updated the project to add the ability to specify voxel size.
To run in the command line you can now specify --voxel-size .5 if you want voxels which are cubes with a side length of .5.
You can also specify --voxel-size-xyz .5 .4 .3 if you want voxels with sidelengths: x=.5, y=.4, and z=.3
There are now arguments in methods to specify voxelSize.
Please note, only voxelSize or resolution should be specified.


Added items of home page from CMS root menu #7815

Coverage increased (+0.09%) to 70.2% when pulling 1e48a7d2f6aaa11fd691e3f6994b3829089b37f5 on gautampanday:task-7815 into 71b7b6cd4b4ffbe86ac4a7e1a890af5519167a77 on openlabs:develop.

Coverage increased (+0.09%) to 70.2% when pulling 9c27c554526ace68205b45b1bb97cf0ccb767041 on gautampanday:task-7815 into 664c34126da080e78259e47c7261f71d7d912a95 on openlabs:develop.

Coverage increased (+0.09%) to 70.2% when pulling 9c27c554526ace68205b45b1bb97cf0ccb767041 on gautampanday:task-7815 into 664c34126da080e78259e47c7261f71d7d912a95 on openlabs:develop.

LGTM. Minor change.

Coverage decreased (-70.11%) to 0.0% when pulling 2979c4b5252793f44cff3aa3353e9ac5b850efd7 on gautampanday:task-7815 into 664c34126da080e78259e47c7261f71d7d912a95 on openlabs:develop.

Restarting build

Coverage increased (+0.09%) to 70.2% when pulling 2979c4b5252793f44cff3aa3353e9ac5b850efd7 on gautampanday:task-7815 into 664c34126da080e78259e47c7261f71d7d912a95 on openlabs:develop.


feat: Consume watch for common Writable config changes

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) N/A
[X] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions
Run make docker using this branch
Run non-secure EdgeX stack using compose builder make run no-secty dev
Verify the logs for all Core/Support services have the following:
"listening for private config changes"
"listening for all services common config changes"

In Consul change the common config all-service Writable/Telemetry/Interval to 15s
Verify the logs for all Core/Support service should the Telemetry Interval has changed
"Writeable configuration has been updated from the Configuration Provider"
"Telemetry interval has been updated. Processing new value..."
"Metrics Manager report interval changed to 15s"

New Dependency Instructions (If applicable)

Codecov Report

Merging #4432 (67a5401) into main (97ead1f) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #4432   +/-   ##
=======================================
  Coverage   41.73%   41.73%
=======================================
  Files         106      106
  Lines        9749     9749
=======================================
  Hits         4069     4069
  Misses       5333     5333
  Partials      347      347

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fine-tuning Custom Relations on Non-Wikipedia text

Hello,
I would like to use the fine-tuning procedure(relation classification) and achieve the below tasks.

Add new relation classes as part of multi-class
fine-tune on custom dataset let's say "MyEnglishNewsDataset"
Add new entity types part of NER.

Are there any recommended steps one should follow for fine-tunning on custom classes and text ? Maybe if there is documentation it will be beneficial?
Is the current fine-tuning procedure targeted only for TACRED, KBP37, and RELX?
will there be any issues with entity names(entity vocabulary) if entity names on my dataset differ from the current entity vocabulary which looks like derived from Wikipedia?

Hi, @bvnagaraju.

Are there any recommended steps one should follow for fine-tunning on custom classes and text ? Maybe if there is documentation it will be beneficial?

To adapt our code to new datasets or add new classes, you need to modify the DatasetReader class.
https://github.com/studio-ousia/luke/blob/master/examples/relation_classification/reader.py
https://github.com/studio-ousia/luke/blob/master/examples/ner/reader.py
This guide to the allennlp library should help you write allennlp-based code.
https://guide.allennlp.org/

Is the current fine-tuning procedure targeted only for TACRED, KBP37, and RELX?

The current code only supports only these datasets, but should be able to handle other datasets by modifying the DatasetReader code.

will there be any issues with entity names(entity vocabulary) if entity names on my dataset differ from the current entity vocabulary which looks like derived from Wikipedia?

If you want to use entities, you should be careful about checking if they exist in our entity vocabulary.
If their name differs from the ones in the entity vocabulary, the model cannot correctly use them.
Maybe you need some way to match the entity names.

Hi @Ryou0634
does the model rely on other features(like word embeddings) if the entity name doesn't match in the entity vocabulary? how may the model behave in case the entity name is not in the entity vocabulary? is there a way one can update entity vocabulary or build embeddings/features for new entities from the custom text(non-Wikipedia)?

does the model rely on other features(like word embeddings) if the entity name doesn't match in the entity vocabulary?
Which model do you have in mind?
You can just use the LUKE encoder with word inputs, which does not require entities.
With this model, if the entity name doesn't have a match in the entity vocabulary, it just uses word features.
With the entity-based model, you should explicitly handle out-of-vocabulary entities (see below).

how may the model behave in case the entity name is not in the entity vocabulary?
If you want to use entity features, you should explicitly detect entities and convert them to entity ids in DatasetReader.
If the entity name is not found in the entity vocabulary, you just cannot feed the entity ids to the model.

For clarification, our model for relation extraction does not use any entity embeddings except for [MASK] tokens (head and tail tokens).


[Send] Back button persists after going home

The backbutton from the send screen persists and overlaps the bullbitcoin logo on homepage after a successful send.


doom-emacs-jupyter

What did you expect to happen?
Use Jupyter console (recommended for interactive Python)
What actually happened?

config.el:
(setq python-shell-interpreter "jupyter"
      python-shell-interpreter-args "console --simple-prompt"
      python-shell-prompt-detect-failure-warning nil)
(add-to-list 'python-shell-completion-native-disabled-interpreters
             "jupyter")

Additional details:

System information:
emacs   version    26.3
doom    version    2.0.9
system  type       darwin
config     x86_64-apple-darwin18.2.0
shell      /bin/zsh

config  envfile    envvar-file
elc-files  0
modules    (:completion company ivy :ui deft doom doom-dashboard doom-quit fill-column hl-todo indent-guides minimap modeline nav-flash ophints (popup +defaults) pretty-code treemacs vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold multiple-cursors snippets word-wrap :emacs (dired +icons +ranger) electric undo vc :term eshell vterm :checkers syntax spell grammar :tools ein (eval +overlay) lookup magit :lang clojure common-lisp data emacs-lisp ess javascript markdown (org +jupyter) (python +lsp) sh web :config (default +bindings +smartparens))

packages   ((elpy) (jupyter) (markdown-mode) (websocket) (simple-httpd) (zmq) (golden-ratio) (all-the-icons-dired) (wakatime-mode) (tup-mode :recipe (:host github :repo ejmr/tup-mode)) (flycheck-color-mode-line))
elpa       (zmq websocket simple-httpd jupyter)

void-variable python-shell-completion-native-disabled-interpreters

This means the python-shell-completion-native-disabled-interpreters variable isn't defined. This happens because you're trying to modify it too soon. Use (after! python ...) to prevent that:
(after! python
  (setq python-shell-interpreter "jupyter"
        python-shell-interpreter-args "console --simple-prompt"
        python-shell-prompt-detect-failure-warning nil)
  (add-to-list 'python-shell-completion-native-disabled-interpreters
               "jupyter"))

No such file or directory, jupyter

You need jupyter installed. If it is installed, try running ~/.emacs.d/bin/doom env so Emacs can see your PATH.

Thank you very much @hlissner
It works, and the warning message disappeared.


RemoteApp Slowness

Since the Windows 10, version 1803 was applied...Remote App acted very slow with network connectivity and user response time to a server on the same LAN network.  I rolled back to version 1709 on 15 (to test) computers and Remote App on those 15 computers behaved normally with no network or user response delays.  What changes in version 1803 may cause this type of behavior?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c274f8df-31da-f58a-36af-dc7eb6ace762
Version Independent ID: 0e33637d-e094-edbc-04f9-e8d5e6c642c6
Content: Windows 10, version 1803 - Features that have been removed
Content Source: windows/deployment/planning/windows-10-1803-removed-features.md
Service: w10
GitHub Login: @lizap
Microsoft Alias: elizapo

@officedocsbot assign @jvsam

@j4v4g33k Thank you for providing feedback.
The issues section of this repository is intended for product documentation issues only.
Please consider opening a product support ticket by the following link below for your problem so that it gets resolved quickly.
Windows 10 Support
Thank you.


Using clipboard to copy and paste data with TagUI

Hi!
It is possible to use clipboard for paste something saved on it?
If i copy an image and after i want to paste it on a web page, how can do this?
Thanks on advance!

Hi @indruin ! If what you want to do can be done by a normal user copying and pasting with keyboard shortcuts, then it should be possible using TagUI by using vision step. See below on how to install Sikuli to enable computer vision automation, and the second link on using complex keyboard shortcuts, for eg to copy and paste data from clipboard.
https://github.com/kelaberetiv/TagUI#visual-automation
https://github.com/kelaberetiv/TagUI/issues/155#issuecomment-397403024

OK, thanks by the response.
It can be used on my next scripts.
Please close this thread.


Use dynamic accounts for the e2e tests provided by o1js API

After the https://github.com/o1-labs/o1js/pull/1167 merge.

Actually not after the merge but after the next release.

Does not make sense for zkapp-cli E2E tests since those methods interacting with Mina Accounts-Manager (instead of using o1js' Lightnet API namespace methods) also depend on whether we are using actual Mina network or mocked one.


Experimental label required in OPA gatekeeper page in Dashboard

What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):

Create a cluster and navigate to dashboard.
Go to OPA Gatekeeper page.

Expectation.
Experimental label should appear on the page as this is an experimental feature for release v2.4.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-2559-head- 02956b782
Installation option (single install/HA): Single

![Screen-Shot-2020-03-26-at-11 54 17-AM](https://user-images.githubusercontent.com/3013118/77685616-ecde0580-6f58-11ea-9101-c73a51e5bea5.png)

![Screen-Shot-2020-03-26-at-11 54 17-AM](https://user-images.githubusercontent.com/3013118/77685652-fbc4b800-6f58-11ea-89c4-dd6ff7e9ad33.png)

I prefer option 1, it doesn't seem as generic as the second option. Option 2 looks too much like a button imo.

That makes sense. here is a third option, but I think this one is hard to read in the given space.

I do like the third one more. That would be my vote.

I like the first one (flag) and not at all the third.. it stands out, but not in a good way, hard to read, and only fits a fixed-size word so you can't reuse that for something else later.

Experimental label is available in latest dashboard UI.


Also make renames use relative_to and relative_from options.

When supplying the relative_from and relative_to options:
GitDiff.stream_patch(relative_from: from, relative_to: to)

it seems to respect that for most patches, except for renames with no body. See screenshot. You'll see the relative path is used for the next patch, but not for the 3 renames.
This fixes that.

Also, my local hex added hashes to the mix.lock, so including that commit here too.
You can also see this issue exhibited by diff.hex.pm

Can you publish the version with this fix to Hex? 💜

Can you publish the version with this fix to Hex? 💜

Huh...could have sworn I did exactly that. Apparently I must have hit the
command to publish and just never entered the password to actually make it
happen.
Done.
On Tue, Jan 12, 2021 at 4:08 PM Eric Meadows-Jönsson <
<EMAIL_ADDRESS>wrote:

Can you publish the version with this fix to Hex? 💜
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/mononym/git_diff/pull/8#issuecomment-758718179, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKKCBSUMTKH2AUSDCDJZ6TSZRQWZANCNFSM4VQBETTA
.

Huh...could have sworn I did exactly that. Apparently I must have hit the
command to publish and just never entered the password to actually make it
happen.
Done.
On Tue, Jan 12, 2021 at 4:08 PM Eric Meadows-Jönsson <
<EMAIL_ADDRESS>wrote:

Can you publish the version with this fix to Hex? 💜
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/mononym/git_diff/pull/8#issuecomment-758718179, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKKCBSUMTKH2AUSDCDJZ6TSZRQWZANCNFSM4VQBETTA
.


ceedling utils:gcov fails

Im trying to create an html report for the test coverage using gcov.
I can successfully run

ceedling clean
ceedling test:all
ceedling gcov:all

But ceedling utils:gcov fail with the following error message.
_rake aborted!
Errno::ENOENT: No such file or directory - gcovr --version
C:/Ruby30-x64/bin/ceedling:25:in `load'
C:/Ruby30-x64/bin/ceedling:25:in `<main>'
Tasks: TOP => utils:gcov
(See full trace by running task with --trace)
ERROR: Ceedling Failed_

The ceedling version I have,
Ceedling:: 0.31.1
Unity:: 2.5.4
CMock:: 2.5.4
CException:: 1.3.3

Do you have gcovr installed? Double check the readme here for install instructions if you need them: https://github.com/ThrowTheSwitch/Ceedling/tree/master/plugins/gcov

Do you have gcovr installed? Double check the readme here for install instructions if you need them: https://github.com/ThrowTheSwitch/Ceedling/tree/master/plugins/gcov

I have gcovr installed. (using pip install gcovr)

Do you have gcovr installed? Double check the readme here for install instructions if you need them: https://github.com/ThrowTheSwitch/Ceedling/tree/master/plugins/gcov

I have gcovr installed. (using pip install gcovr)

I have exactly the same issue.
My environment is cygwin

Hi @prabodini ,
Do I ask you for maybe giving me more information on what your setup looks like on a Windows machine?
I'm trying to reproduce your issue on a Windows machine.
I have installed python3 with gcovr. As well I'm using mingw64 with installed gcc and gdb.
Unfortunately, I'm not able to produce your issue.
@sudamj : Did you installed gcovr under pure Windows or under Cygwin?

Hi @lukzeg It's been a while and I don't think I had gdb installed. I will try it again

Did anyone find a fix for this?

Raising this post up from the dead for those who might run across this issue:
You might have different python interpreters that are installed on your machine, and thus pip install gcovr is installing it in the wrong Python interpreter.
I had several python interpreters installed. I am unsure of how to tell which python interpreter GCOV is attempting to call, but for me:
py -m pip install gcovr

worked.

for me this issue was solved by installing gcovr with apt, not with pip ("which gcovr" should find gcovr)


[BEAM-6021] Registred more internal classes for kryo serialization

Registred more internal classes for kryo serialization
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Run Spark ValidatesRunner

There have been issues in the past about using Kryo as the serializer, this a discussion about it just over a year ago<EMAIL_ADDRESS>It may not be an issue anymore though but wanted to provide context as to why this may have not worked in the past.

@iemejia pls code review

M2C: We made sure that everywhere that we need to serialize data we didn’t let Spark do it with its serializer, which defaults to Java unless configured otherwise by Spark's spark.serializer configuration. Spark users often configure this to be Kryo instead of Java, so we made sure to encode the data using Beam’s encoders, then passed Byte[] so when Spark serializes data before it is transmitted to other machines, it uses its serializer (default Kryo) to serialize a Byte[] which is always serializable by the serializer (Whether Java or Kryo).
If other classes, which are not the user's data are serialized by Kryo, and we're sure that they are always serializable by Kryo, that's fine.
I'm not sure this change actually makes the classes registered to be serialized by Kryo. Do we have tests to show this?
IIRC this is controlled by the spark.serializer configuration.

@aviemzur Hi, you are influenced by this change only if you use conf.set("spark.serializer", "org.apache.spark.serializer.KryoSerializer");
Added more internal classes which are used and test to show that is used KryoSerializer.

Run Java PreCommit

Run Java PreCommit

Rebased and fixed test and added new one testing default behavior.
@iemejia  pls review :)


disk.dev is used in documentation, but this feature does not exist

Description:
When specifying a disk config in the domain, the documentation uses disk.dev. This is invalid configuration.
Here is an example in the docs
...
spec:
  domain:
    devices:
      disks:
      - name: containerdisk
        disk:
          dev: vda
      - name: cloudinitdisk
        disk:
          dev: vdb
...

What you expected:
Either add support for this in the API or correct the documentation.
URL:
https://kubevirt.io/user-guide/user_workloads/startup_scripts/#inject-ssh-key-using-a-custom-shell-script
Additional context:
I've seen this issue previously mentioned, #2402.

Anyone interesting contributing a PR to fix the documentation?

And for the record: the feature is not in KubeVirt, because there is no guarantee that this dev name can be assigned.
Th erecommendation is to used disk by UUID or disk by serial

documentation has not been fixed
/remove-lifecycle stale

/label good-first-issue

Hi @iholder101 Can I get this issue assigned to me? I can raise a PR for it.

Hi @iholder101 Can I get this issue assigned to me? I can raise a PR for it.

Absolutely! Thank you for your contribution!
Note that the PR would need to land to this repo: https://github.com/kubevirt/user-guide.
/assign @zelfroster


Cannot connect in tunneling

I don't know what I am doing wrong. I cloned your project and tried the test project with the tunneling. I changed the IP to the IP of my KNX/IP Gateway and port 3671. The same as ETS is using.
I get a notification from the firewall, when I start the application and I accept the firewall rule.
But the app hangs when I try to call an Action to switch light on and off. It just hangs foreever. No exception. Nothing. It does not return from the function.

Disable the firewall to test, IP Tunneling needs 2 connections, one each way
the IP Interface will try to connect back to your PC, if the firewall is blocking the connection won't be established
If it works, you can add the exception to the firewall on the advanced properties of the windows firewall, you will have to choose the port you want the IP interface to connect back to your system
You can define the port KNX.net will listen
https://github.com/lifeemotions/knx.net/blob/2f4d4abcc77f5e540933b17827278ffbb67fae34/src/KNXLib/KnxConnectionTunneling.cs#L33


WWC上阅读消息后，手机还上还得再看一次才能消除小红点

手机微信上还显示未读，得重新点一次。

目前没有加消息的已读状态的同步，所以手机上看到的还是未读
On Wed, Oct 11, 2017 at 3:38 PM, imchaos<EMAIL_ADDRESS>wrote:

手机微信上还显示未读，得重新点一次。
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trazyn/weweChat/issues/51, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABsVMoWcn5mw1HmPODQK7u6A7RDzEvSgks5srHCTgaJpZM4P1CeZ
.


If I run poco tmp -settings-after I don't get settings displayed after

This now works:
poco foo -settings-after


Not working with style-loader

I'm using style-loader and it generates multiple <style> tags. I have 2 files:
/* theme.css */
:root {
  --text-color: red;
}

/* App.css */
.App {
  color: var(--text-color);
}

The cssnext removes the theme.css tag and doesn't apply the variable value.
With cssnext:

Without cssnext:

It warns: ./src/App.css (Emitted value instead of an instance of Error) postcss-custom-properties. variable '--text-color' is undefined and used without a fallback

You are probably doing multiples import in differents files, so different context. Keep in mind that CSS is transformed into string and must run in the same context to do something.
You may need to use postcss-import.


Slow loading Images

Upload them to a CDN and implement "Progressive Image Loading"

I'll tag this as an feature in the upcoming re-design of the portfolio.


[manager] Update raft config values for election and heartbeat tick if they don't match the node config

Realized this is not really the solution since different nodes can have different values and also I put the code to update the cluster spec on basically all the mangers :p
Closing it out.


[stable/openldap] Custom OpenLDAP Configuration File Mount Does Not Work

Describe the bug
The $subject is experienced (i.e. property customLdifFiles) when running this Helm chart with Docker image osixia/openldap version 1.3.0. The same option when using the Docker image to build a simple Docker container works fine (outside of Kubernetes).
Version of Helm and Kubernetes:
Helm version: 3.1.2
GKE based Kubernetes Server version: 1.14+, Git Version: v1.14.10-gke.27
Which chart:
stable/openldap Helm chart version 1.2.3
What happened:
The custom LDIF files were not executed during the initialization.
What you expected to happen:
The custom LDIF files being executed during the initialization.
How to reproduce it (as minimally and precisely as possible):
Set custom LDIF file to customLdifFiles.
Anything else we need to know:
Used the existing Helm chart few days back, with osixia/openldap Docker image version 1.3.0 image and this feature worked. But when running with the latest version 1.3.0 tagged image (as of 2020/05/10), it did not work.

Might want to double-check that the ldif file can be imported via another means. I ran into what I thought was this issue, but it turned out to just be an invalid ldif file.
I will note there was zero indication anywhere that it failed, which was frustrating.

Might want to double-check that the ldif file can be imported via another means. I ran into what I thought was this issue, but it turned out to just be an invalid ldif file.
I will note there was zero indication anywhere that it failed, which was frustrating.

@kyounger the same LDIF files work fine when using with a plain Docker image of version 1.3.0 to create a simple container. That means this issue seems to pop up when using it within the Helm chart.

Any update on this?

I'm facing a similar issue.  During pod initialization:
Unable to mount volumes for pod "openldap-9dfc57484-kzm9w_default(449a
fcd9-b710-11ea-834c-02fde0f44a9d)": timeout expired waiting for volumes to attach or mount for pod "default"/"openldap-9dfc57484-kzm9w". list of unmounted vol
umes=[data]. list of unattached volumes=[customldif ldifworkingdir certs data default-token-4t6sl

Pod logs:
k logs -f openldap-9dfc57484-kzm9w
*** CONTAINER_LOG_LEVEL = 3 (info)
*** Copy /container/service to /container/run/service
*** Search service in CONTAINER_SERVICE_DIR = /container/run/service :
*** link /container/run/service/:ssl-tools/startup.sh to /container/run/startup/:ssl-tools
*** link /container/run/service/slapd/startup.sh to /container/run/startup/slapd
*** link /container/run/service/slapd/process.sh to /container/run/process/slapd/run
*** Set environment for startup files
*** Environment files will be proccessed in this order :
Caution: previously defined variables will not be overriden.
/container/environment/99-default/default.startup.yaml
/container/environment/99-default/default.yaml

To see how this files are processed and environment variables values,
run this container with '--loglevel debug'
*** Running /container/run/startup/:ssl-tools...
*** Running /container/run/startup/slapd...
*** An error occurred. Aborting.
*** Shutting down /container/run/startup/slapd (PID 10)...
*** Init system aborted.
*** Killing all processes...

I tried without persistent storage also, but that didn't seem to work either.  I've been able to use the ldif through phpldapadmin without issue, but trying to tie that into the bootstrap prcess

ldapadd -x -D cn=admin,dc=example,dc=org -f /container/service/slapd/assets/config/bootstrap/ldif/custom/01-default-users.ldif -W

This command seemed to work for me post pod initialization.  Also tried to find the init-container logs but no luck

Any update on this? Is this issue fixed?

Also had a problem with this scenario: If i take the same ldif file in a docker image, and do not mount volumes for /var/lib/ldap, it works, the moment I mount volumes for data. The helm chart does not run the custom Ldif file, and this is because the /var/lib/ldap directory and the config directory are not empty on the second start of ldap.  Somehow data is written into those directories when i use a volume mount, vs when I don't.
if there is data in those directories, then the custom Ldif does not run.
My question is how / why would this be occurring. ?


Chainlink support

Similar to Pyth, Chainlink also provides service for price data on-chain. Can we get this support natively in the playground?
Package - chainlink_solana
Version - 1.0.0
docs.rs link - https://docs.rs/chainlink_solana/latest/chainlink_solana/

Yeah, we can support it too. Adding support for it is quite easy but it will take some time to make this live due to other factors.

Thank you for considering the addition of Chainlink support to Solana Playground. Is there a tentative timeline for when you might be able to revisit this request?

Any update on this @acheroncrypto ?

Hello @acheroncrypto, is this being planned for future release or completely ignored for now?


specify which version of the THINGS bold data used and map to correct branch: w or w/o slicetiming

track branch w which betas were derived, map correct THINGS dset version as submodule (with or without slicetiming)

update: it was with_slicetiming


Add support for .net 4.7.2

Expected Behavior
.net 4.7.2 is out, and would like to have psake support builds with the same
Current Behavior
currently there is support for upto .net 4.7.1
Possible Solution
PR attached.
added 4.7.1 to list of supported frameworks, with msbuild 15.0
Context
We currently use psake for build scripting, and are looking to upgrade to .net 4.7.2
however, we only can upgrade to .net 4.7.1
Your Environment

Module version used:
Operating System and PowerShell version:

Could you also release a new version please. https://www.powershellgallery.com/packages/psake/

published. https://www.powershellgallery.com/packages/psake/4.7.2

It looks like the fix hasn't been published yet. The new version is shipped, however it doesn't contain the fix.

OK that's weird. The PR was merged to master but I'm not seeing the changes and commits to that file don't reflect the change. https://github.com/psake/psake/commits/master/src/private/ConfigureBuildEnvironment.ps1

Whelp. Messed that up.

right this looks good from my end.
gonna close this out

Thanks a lot!
On Sat, Aug 11, 2018, 11:18 PM Brandon Olin<EMAIL_ADDRESS>wrote:

@StasPerekrestov https://github.com/StasPerekrestov @dawoodmm
https://github.com/dawoodmm Since for some reason, these changes were
lost even though the PR was merged, I've reapplied them released 4.7.3,
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/psake/psake/issues/256#issuecomment-412299149, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAzJzaN3TK3stp_tDuUnr1vxoCFSJOBhks5uPzwEgaJpZM4VyeHm
.


Add /usr/lib/libclang.so to search file paths

some linux distribution put such as archlinux put libclang.so in /usr/lib/libclang.so https://archlinux.org/packages/extra/x86_64/clang/files/

Thanks!


Add people names from Bulgaria

Hello,
I came across this issue labeled as  in your repository, and I'm very interested in contributing to it as part of a school project.
I believe working on this issue will not only help me gain practical experience in, but also contribute positively to your project. I've reviewed the contribution guidelines for your repository and am ready to adhere to them.
Could you please let me know if it's possible for me to work on this issue? If there are any specific requirements or starting points you'd like me to know, I'd be glad to hear them.
Thank you for considering my request. I'm looking forward to the opportunity to contribute to your project.
Best regards,
Neethu Duggi

Hello!
I am happy you are going to join faker's contributors :)
I have just assigned you this issue, feel free to work on that.
Here is my commit with adding people names: https://github.com/cieslarmichal/faker-cxx/commit/8b0c514a25252e4516e02d5157613148e793bea7 - you can take that as a reference.
We have a discord server for contributors: https://discord.gg/eKcH3nTf - you can join if you are interested in some discussion or even just for community.
Dont forget to give a star to the project to make it more popular :rocket:
Best regards,
Michał

thank you for assigning this issue to me!


new keyword

Current functionality allows you to add the use of the keyword new. The purpose of this action needs to be discussed. Is it necessary at all?
const User = fractal(async function*(){
   while(true) yield 'John'
})

const UserOne = new User() // and what will it give? e.g. - new fractal with same generator?

in the new version this functionality will not be necessary


Error After Compiling App

Hello,
Great plugin :+1:
Uncaught SyntaxError: Use of const in strict mode. image-uploader.js:3
ReferenceError: ImageUploader is not defined
This error appears once i compile the app. But on browser it seems to work fine

Here is the screenshot

Hi, thanks for reporting this. Fixed by #2

Hi, thanks for reporting this. Fixed in PR #2

Thanks :)
Let me try now.


[Bug] Unwanted test run after dbt build --select <seed_name>

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
After executing dbt build --select <seed_name> command is also starting a generic test run in which <seed_name> is referenced.
Expected Behavior
Not run tests that aren't referenced.
Steps To Reproduce

Create files as referenced here https://gist.github.com/tmirko/b1c6e85fd75336c5285ce35e501872f4
execute dbt --no-use-colors build --target dev_cloud --select fqn:downstream.country_codes

Relevant log output
$ dbt --no-use-colors build --target dev_cloud --select fqn:downstream.country_codes
13:33:23  Running with dbt=1.7.12
13:33:23  dbt-loom: Patching ref protection methods to support dbt-loom dependencies.
13:33:23  dbt-loom: Loading manifest for `dbt_loom_1_one` from `file`
13:33:23  Registered adapter: bigquery=1.7.7
13:33:23  dbt-loom: Injecting nodes
13:33:23  Found 10 models, 22 tests, 1 seed, 5 sources, 0 exposures, 0 metrics, 457 macros, 0 groups, 0 semantic models
13:33:23
13:33:25  Concurrency: 2 threads (target='dev_cloud')
13:33:25
13:33:25  1 of 2 START seed file downstream_dev.country_codes ............................ [RUN]
13:33:28  1 of 2 OK loaded seed file downstream_dev.country_codes ........................ [INSERT 2 in 3.54s]
13:33:28  2 of 2 START test is_country_valid_stg_asset_daily_api_country ................. [RUN]
13:33:28  2 of 2 ERROR is_country_valid_stg_asset_daily_api_country ...................... [ERROR in 0.31s]
13:33:28
13:33:28  Finished running 1 seed, 1 test in 0 hours 0 minutes and 4.99 seconds (4.99s).
13:33:28
13:33:28  Completed with 1 error and 0 warnings:
13:33:28
13:33:28    Runtime Error in test is_country_valid_stg_asset_daily_api_country (models/data_product_example/api/schema.yml)
  404 Not found: Table  was not found in location ; reason: notFound, message: Not found:  was not found in location

  Location:
  Job ID:

13:33:28
13:33:28  Done. PASS=1 WARN=0 ERROR=1 SKIP=0 TOTAL=2

Environment
- OS: wsl2 ubuntu image
- Python: 3.10
- dbt: 1.7.12

Which database adapter are you using with dbt?
bigquery
Additional Context
No response

Thanks for providing those example files @tmirko ! 🤩
Could you try out the buildable indirect selection mode?
dbt build --select country_codes --indirect-selection buildable

There's a little more explanation and diagrams here: https://github.com/dbt-labs/dbt-core/issues/9746#issuecomment-1989027389

Thanks for quick response @dbeatty10.
So mentioned command works as expected.
However I would expect the same happening without --indirect-selection buildable i.e. not executing is_country_valid test.
Is this expected behavior? Should I add --indirect-selection buildable to build commands from now on?

The behavior you are seeing is expected for the eager indirect selection mode, which is the default.
The buildable mode can often be more intuitive and desirable, but it would be a breaking change if we promoted it to be the default instead. Since there's may ways for users to configure the indirect selection mode, we've opted not to change the default.
Configuring the indirect selection mode
If you want to configure it for yourself, here are the options:

--indirect-selection CLI argument
DBT_INDIRECT_SELECTION environment variable
indirect_selection global config flag in dbt_project.yml

It can also be configured within any YAML selectors that you have defined.
Since dbt is behaving as expected here, I'm going to close this as "not planned".


Solved issue #41

Toggle button for switching from light to dark mode and vice versa.

@goodchai0 pls check the pr


Unexpected behavior: calling .valid() for one control resets the validation

I am trying to make the validation of 2 fields together. I would like them to be considered as just an atomic input control.
I am forcing this by a custom validator but when I try to call the .valid() for the other control it calls the reset method internally which actually resets all the validation which had already been done.
For example the list of errors which is hosted in the errorMap.

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


Choosing Audio Quality causing not download video from youtube

I tried to find an answer in Issues section, unfortunately I didn't find useful answer.
Choosing audio quality causing not to download videos. I was using ytdl-format=bestvideo[height<=?1080]+bestaudio/best since video didn't downloaded and I removed that code from mpv.conf file. And everything is fine so far. But I'd like to choose 1080p with that code. This problem doesn't come from Video Quality after I removed that line of code I still watch video with > 1080p. So I think the issue does come from Audio Quality.
Any ideas?

This format selection option
bestvideo[height=1080]+bestaudio/best[height=1080]/bestvideo+bestaudio/best
should give you a 1080 video if it exists and the default selection otherwise.
If neither that nor further study of the Manual resolves your question, please provide logs for "youtube-dl -v -F <your url>" and for "youtube-dl -v --get-format -f <your format selection> <your url>" with the various format selection options that you've tried.

Look like I made it with your help, I really highly appreciate that.
C:\mpv>youtube-dl.exe youtube-dl -v -F "https://www.youtube.com/watch?v=jenVMnOi2uA"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['youtube-dl', '-v', '-F', 'https://www.youtube.com/watch?v=jenVMnOi2uA']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.2-2021-02-27-full_build-www.gyan.dev, ffprobe 4.3.2-2021-02-27-full_build-www.gyan.dev
[debug] Proxy map: {}
ERROR: 'youtube-dl' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:youtube-dl" ) to search YouTube
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\generic.py", line 2390, in _real_extract
youtube_dl.utils.ExtractorError: 'youtube-dl' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:youtube-dl" ) to search YouTube

You've put the command twice: leave one out!
youtube-dl.exe youtube-dl -v -F "https://www.youtube.com/watch?v=jenVMnOi2uA

Here you go.
C:\mpv>youtube-dl.exe -v -F "https://www.youtube.com/watch?v=yOhGkZ4U4lI"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=yOhGkZ4U4lI']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.3.2-2021-02-27-full_build-www.gyan.dev, ffprobe 4.3.2-2021-02-27-full_build-www.gyan.dev
[debug] Proxy map: {}
[youtube] yOhGkZ4U4lI: Downloading webpage
[info] Available formats for yOhGkZ4U4lI:
format code  extension  resolution note
249          webm       audio only tiny   49k , webm_dash container, opus @ 49k (48000Hz), 1.90MiB
250          webm       audio only tiny   56k , webm_dash container, opus @ 56k (48000Hz), 2.16MiB
251          webm       audio only tiny  103k , webm_dash container, opus @103k (48000Hz), 3.93MiB
140          m4a        audio only tiny  129k , m4a_dash container, mp4a.40.2@129k (44100Hz), 4.93MiB
278          webm       256x144    144p   19k , webm_dash container, vp9@  19k, 30fps, video only, 762.53KiB
160          mp4        256x144    144p   34k , mp4_dash container, avc1.4d400c@  34k, 30fps, video only, 1.31MiB
242          webm       426x240    240p   28k , webm_dash container, vp9@  28k, 30fps, video only, 1.07MiB
133          mp4        426x240    240p   70k , mp4_dash container, avc1.4d4015@  70k, 30fps, video only, 2.68MiB
134          mp4        640x360    360p   49k , mp4_dash container, avc1.4d401e@  49k, 30fps, video only, 1.90MiB
243          webm       640x360    360p   52k , webm_dash container, vp9@  52k, 30fps, video only, 1.99MiB
244          webm       854x480    480p   81k , webm_dash container, vp9@  81k, 30fps, video only, 3.12MiB
135          mp4        854x480    480p   84k , mp4_dash container, avc1.4d401f@  84k, 30fps, video only, 3.21MiB
136          mp4        1280x720   720p  158k , mp4_dash container, avc1.4d401f@ 158k, 30fps, video only, 6.03MiB
247          webm       1280x720   720p  162k , webm_dash container, vp9@ 162k, 30fps, video only, 6.19MiB
298          mp4        1280x720   720p60  170k , mp4_dash container, avc1.4d4020@ 170k, 60fps, video only, 6.49MiB
302          webm       1280x720   720p60  185k , webm_dash container, vp9@ 185k, 60fps, video only, 7.07MiB
303          webm       1920x1080  1080p60  313k , webm_dash container, vp9@ 313k, 60fps, video only, 11.92MiB
299          mp4        1920x1080  1080p60  322k , mp4_dash container, avc1.64002a@ 322k, 60fps, video only, 12.28MiB
18           mp4        640x360    360p  139k , avc1.42001E, 30fps, mp4a.40.2 (44100Hz), 5.33MiB
22           mp4        1280x720   720p  287k , avc1.64001F, 30fps, mp4a.40.2 (44100Hz) (best)

Forgive my ignorance on youtube-dl's current behavior, but historically its "best" arguments only cared about bitrate without any regard for the codec.
I mention this because, if it sees AAC audio at 128kbps and Opus audio at 127kbps, it'd pick the AAC every single time despite Opus being a superior codec (that is, it provides better quality per bit).  The same goes for video - if youtube-dl found AVC at 5001kbps and VP9 at 5000kbps and even AV1 at 4999kbps, it'd pick AVC every time despite the VP9 being higher quality at that bitrate and especially the AV1 being higher quality.
I say all of this to point that that, 99.99999999% of the time, format 251 will be the best audio quality as it is Opus at the highest bitrate that they encode it at.  Furthermore, a lot of YouTube's AAC encodes actually have some sort of cut-off at around 16kHz which is not present in their Opus encodes.  Lastly, 99.99% of all digitally-recorded video is natively recorded with audio that has a sampling rate at 48kHz which is what Opus uses, but YouTube's AAC encodes use 44.1kHz instead.
I wish something could be said the same about video, but the bitrates are much too variable.  For example, on the following video, the 1080p AVC encode has about twice the bitrate of the 1080p VP9 encode which should be more than enough to make the AVC encode higher quality:
https://youtube.com/watch?v=pAJrXicfWsM
Yet on the following video, the 1080p VP9 encode only has around a 4% lower bitrate than the 1080p AVC encode, therefore the VP9 encode should actually be higher quality since that shouldn't be enough bitrate for AVC to overtake VP9:
https://youtube.com/watch?v=L1v3ZmfV_hw

Forgive my ignorance on youtube-dl's current behavior, but historically its "best" arguments only cared about bitrate without any regard for the codec.
...
While this isn't on topic for OP's question (which, as above, may be more to do with mpv's integration), I would suggest that a 4% or less difference in bit-rates between H.264/AAC and VP9/Opus is not something that a person with a life should care about.

Legacy (as in, firmware that came with the box) media player non-support for VP9/Opus is a more realistic concern when selecting formats.


rails_example_group: don't include RSpec::Rails::FixtureSupport if it's not defined

If ActiveRecord::Fixtures isn't defined, then the line include RSpec::Rails::FixtureSupport in
rspec/rails/example/rails_example_group throws an error.
I found this when I started to use the ammeter gem to help me write a spec for a generator.
The ammeter gem requires 'rspec/rails/example/rails_example_group' which has the line include RSpec::Rails::FixtureSupport.
#1372 introduced a conditional around the definition for RSpec::Rails::FixtureSupport (in rspec/rails/fixture_support.rb) so that the class is not defined if ActiveRecord::TestFixtures isn't defined.  So when the include RSpec::Rails::FixtureSupport line in rspec/rails/example/rails_example_group is evaluated, an error is thrown since RSpec::Rails::FixtureSupport was never defined.  This include line needs a conditional to check for this situation.  I tested this correction: include RSpec::Rails::FixtureSupport if RSpec::Rails::FixtureSupport rescue false and it works.
Here's the environment and generator spec test file that shows the error:
Ruby 2.1.5p273
Rails 4.2.1
rspec (3.3.0)
rspec-rails (3.3.2)  [I also tested master; same error occurs, same fix works]
ammeter (1.1.2)
spec_helper.rb and rails_helper.rb have defaults. No modifications were made to the originally installed files.
Generator spec test file:
#  runs successfully with this line changed in rspec/rails/example/rails_example_group:
#    original line: include RSpec::Rails::FixtureSupport if RSpec::Rails::FixtureSupport
#    revised line:  include RSpec::Rails::FixtureSupport if RSpec::Rails::FixtureSupport rescue false # AE 2015-06-24
require 'rails_helper'

class RspecRailsFixturesBugGenEx < Rails::Generators::NamedBase
  def generate_stuff
  end
  def generate_nonsense
  end
end

describe RspecRailsFixturesBugGenEx do
  # Tell the generator where to put its output (
  destination File.expand_path("../../../../../tmp", __FILE__)
  before { prepare_destination }
  it 'runs all tasks in the generator' do
    gen = generator %w(posts)
    gen.should_receive :generate_stuff
    gen.should_receive :generate_nonsense
    gen.invoke_all
  end
end

Stack trace with the error:
(I'm using RubyMine so a bit of that cruft is in the trace output.)
C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-rails-1fb6f9f642e8/lib/rspec/rails/example/rails_example_group.rb:14:in `<module:RailsExampleGroup>': uninitialized constant RSpec::Rails::FixtureSupport (NameError)
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-rails-1fb6f9f642e8/lib/rspec/rails/example/rails_example_group.rb:8:in `<module:Rails>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-rails-1fb6f9f642e8/lib/rspec/rails/example/rails_example_group.rb:6:in `<module:RSpec>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-rails-1fb6f9f642e8/lib/rspec/rails/example/rails_example_group.rb:5:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/ammeter-1.1.2/lib/ammeter/rspec/generator/example/generator_example_group.rb:4:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/ammeter-1.1.2/lib/ammeter/rspec/generator/example.rb:2:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/ammeter-1.1.2/lib/ammeter/init.rb:7:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/ammeter-1.1.2/lib/ammeter/railtie.rb:4:in `block in <class:Railtie>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/railties-4.2.1/lib/rails/initializable.rb:30:in `instance_exec'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/railties-4.2.1/lib/rails/initializable.rb:30:in `run'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/railties-4.2.1/lib/rails/initializable.rb:55:in `block in run_initializers'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:226:in `block in tsort_each'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:348:in `block (2 levels) in each_strongly_connected_component'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:427:in `each_strongly_connected_component_from'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:347:in `block in each_strongly_connected_component'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:345:in `each'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:345:in `call'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:345:in `each_strongly_connected_component'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:224:in `tsort_each'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/2.1.0/tsort.rb:205:in `tsort_each'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/railties-4.2.1/lib/rails/initializable.rb:54:in `run_initializers'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/gems/railties-4.2.1/lib/rails/application.rb:353:in `initialize!'
	from C:/Users/ashley/RubymineProjects/RJInvestments/config/environment.rb:5:in `<top (required)>'
	from C:/Users/ashley/RubymineProjects/RJInvestments/spec/rails_helper.rb:5:in `require'
	from C:/Users/ashley/RubymineProjects/RJInvestments/spec/rails_helper.rb:5:in `<top (required)>'
	from C:/Users/ashley/RubymineProjects/RJInvestments/spec/generators/rr_fixtures_bug_spec.rb:18:in `require'
	from C:/Users/ashley/RubymineProjects/RJInvestments/spec/generators/rr_fixtures_bug_spec.rb:18:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/configuration.rb:1332:in `load'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/configuration.rb:1332:in `block in load_spec_files'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/configuration.rb:1330:in `each'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/configuration.rb:1330:in `load_spec_files'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/runner.rb:102:in `setup'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/runner.rb:88:in `run'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/runner.rb:73:in `run'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/lib/rspec/core/runner.rb:41:in `invoke'
	from C:/rubys/ruby-2.1.5-x64-mingw32/lib/ruby/gems/2.1.0/bundler/gems/rspec-core-0697d3a9894f/exe/rspec:4:in `<top (required)>'
	from C:/rubys/ruby-2.1.5-x64-mingw32/bin/rspec:23:in `load'
	from C:/rubys/ruby-2.1.5-x64-mingw32/bin/rspec:23:in `<top (required)>'
	from -e:1:in `load'
	from -e:1:in `<main>'

I think this out dated vs master, in master we define the module regardless, but only have the contents of the module applied when fixture support is available.

:heart: Sorry you ran into this. The fixture support file defines the constant, regardless of if ActiveRecord::TestFixtures is available:
module RSpec
  module Rails
    # @private
    module FixtureSupport
      if defined?(ActiveRecord::TestFixtures)
        # Content here
      end
    end
  end
end

This issue sounds like something is not calling require 'rspec/rails' prior to using one of the components. rspec-rails is not currently designed to load individual pieces ad-hoc. The library needs to be required as a whole.
Looking at the stack it seems ammeter is what is only attempting to load part of rspec-rails :frowning:. The fix should come from there. There are a multiple dependencies that need to be loaded and setup. Currently this is handled by rspec-rails when you require 'rspec/rails'.
We may well move in the direction of allowing components to be required stand alone; however, we will still have the base requirement that require 'rspec/rails' is called first. The other rspec repos have this same requirement, as does ActiveSupport before you load parts ad-hoc.

Thanks for the really complete and very helpful responses @JonRowe and @cupakromer .  You're exactly right: ammeter is only requiring selected parts of rspec/rails.  I'll submit a PR over there.


Build warnings and test failure

Hi, I've imported your project into mine, thanks for this useful library. I had to write a CMake file to have an easier time embedding pbl into my project (feel free to copy it), so there could be mistakes in my build options, although nothing that I can spot.
 I'm getting the same warnings on Gentoo 64 bit and ArchLinux ARM 32 and 64 bit.
Not sure if this is related to the warnings I'm getting, but if you scroll all the way down you will see that kfblockprint test is failing, which is causing my build to fail and turn red. As a workaround I could disable tests for pbl (I'm not using the part of pbl that fails, afaict), but it would be really nice if you could have a look into this.
Edit: Sorry, I just realized I couldn't simply run tests by invoking them, I had to pass them some command line arguments as well. Also some binaries were not run by the original makefile (pblkfblockprint among the others), so I'm also removing them from my cmake file. I've made some changes and I've got these tests failing now:

pbliftst test/isam0001.tst
pbliftst test/isam0002.tst
pbliftst test/isam0004.tst
pbliftst test/isam0005.tst
pbliftst test/isam0006.tst

It might be a path issue, but if I try running the pbliftst binary manually and I paste the command "open isamtest/0002main 0002key0,0002dup1,0002key2 1" I get this output:
$ ./pbliftst

##command:
open isamtest/0002main 0002key0,0002dup1,0002key2 1
# open filename keyfile1,dkeyfile2,... update
# pblIsamOpen( isamtest/0002main, 3, 1 )
# not ok! pbl_errno 1021, errno 2

Edit 2: I think I managed to fix all the failing tests. Failures where not caused by problems in the code, but by wrong paths and a non-empty isamtest directory. I updated my CMake script so failures should not be happening anymore. However, it would still be very nice if you could have a look at the compiler's warnings.

 My build is all nice now! :)
It's probably a warning that came with the newer versions of gcc. Even though the build server is Ubuntu 14, I put a recent gcc on it, or my code wouldn't build (something to do with C++11).
As of the cmake script, I made some changes so I just run some of the generated binaries and invoke them with the right arguments. See the full list here. That got me past some tests that would block forever waiting for stdin. Again, feel free to add it directly to your project if you think it's a nice thing to have. I can help fixing issues if it doesn't work out of the box.


rclc_executor_trigger_one way out of date

I'm working https://github.com/ros2/rclc/issues/116 and I'm not sure what to do with rclc_executor_trigger_one.
This looks like it's supposed to return true if at least one of handles is ready to be executed, but it returns false if it reaches a type in CLIENT, SERVICE, or GUARD_CONDITION
For now I'm expanding it to any type where data_available is ever set to true
If anyone knows what this is, can we discuss a test for it?

Yes, you can do it like that.
Initially, we only supported subscriptions and timers for this trigger condition.


Recover functionality of passing down unrecognized frontend-only options

Once '-e' got introduced, we started failing to detect when the driver was specified a frontend-only option and passing it down to the frontend, if such frontend-only option started with '-e...'. This is because we do a prefix match on the options trie and treat an unrecognized suffix as the argument to it, and later detect whether or not such an option is recognized.
We can restore the functionality for flags that the driver is aware of as being frontend-only flags, by not skipping such flags when constructing the trie and detecting them explicitly (.noDriver) and processing them as any other unknown flag to be checked whether or not it can be passed down to the frontend.
And reword the diagnostic a bit to indicate to the user that -Xfrontend can get rid of the warning.

@swift-ci test

Let's say there's a driver flag called -do-something and a frontend flag -do-somethingwithfrontend. Would this change cause -do-somethingwithfrontend to get parsed incorrectly if -do-something supported a joined argument? I know it seems unlikely, but also hard to debug if it ever happens


Write rollback changed information to rollback.file

if -rollback_if_require_restart set, and restart information available, write to <output_dir>/rollback.file

The option =rollback_if_restart_required has been released for a while, not sure how many people used it though.


Change email distribution to data-science

Change to email address to<EMAIL_ADDRESS>Change reply to address to<EMAIL_ADDRESS>(Updated and testing now)

The correct "to" email is<EMAIL_ADDRESS>

Thanks! It's updated.  You should have gotten the first alert.

Yes, received the alert. Thanks.
From: Gene Leynes<EMAIL_ADDRESS>Sent: Monday, July 17, 2017 3:51 PM
To: Chicago/west-nile-virus-predictions<EMAIL_ADDRESS>Cc: Schenk, Tom<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [Chicago/west-nile-virus-predictions] Change email distribution to data-science (#42)
Thanks! It's updated. You should have gotten the first alert.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Chicago/west-nile-virus-predictions/issues/42#issuecomment-315879793, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABkC0VLG1uX99MCLCE1NIJ-KnSxS0Uhpks5sO8kagaJpZM4OaR3M.

This e-mail, and any attachments thereto, is intended only for use by the addressee(s) named herein and may contain legally privileged and/or confidential information. If you are not the intended recipient of this e-mail (or the person responsible for delivering this document to the intended recipient), you are hereby notified that any dissemination, distribution, printing or copying of this e-mail, and any attachment thereto, is strictly prohibited. If you have received this e-mail in error, please respond to the individual sending the message, and permanently delete the original and any copy of any e-mail and printout thereof.