Image.resolveAssetSource cannot resolve asset correctly in Android Release mode

I have a native UI module in Android that takes props from JS. My images are not under /android folder so I use resolveAssetSource to get root level folder assets from Android.
Native module's prop is the output of Image.resolveAssetSource(require('imagename')).
const img = require('./images/png/marker.png')
const imgProps = Image.resolveAssetSource(img);
..
<CustomImage style={{ width: imgProps.width, height: imgProps.height }} src={imgProps} />

This works pretty good in debug mode. Because asset uri is in full form as below:
{
"__packager_asset": "true",
"width": 80,
"height": 80,
"uri": "http://<IP_ADDRESS>:8081/assets/images/png/marker.png?platform=android&hash=412827xxxxxxxxx",
"scale": 1
}

But when I bundle the app and create the signed apk, uri changes and it's not in a form that I can use. Therefore, the image is not showing up. Uri shows up like below:
{
"__packager_asset": "true",
"width": 80,
"height": 80,
"uri": "images_png_marker",
"scale": 1
}

It seems that bundler flattens folder structure using underscore for each subfolder, removes the file extension and the full path.
This very same issue was mentioned in issue:https://github.com/facebook/react-native/issues/18216, but it was closed without a resolution. No one created a repo. But I've created one and attached screenshots.

DEBUG
RELEASE

React Native version:
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (8) x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Memory: 81.64 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.10.0 - ~/.nvm/versions/node/v8.10.0/bin/node
Yarn: 1.5.1 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.10.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 27.0.3, 28.0.3
System Images: android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.4 AI-183.54<IP_ADDRESS>52501
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.8 => 0.59.8
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-macos-cli: 2.0.1
react-native-rename: 2.4.1

Steps to reproduce:

Create an app with react-native init
Create a UI Native component(ImageView) for Android and implement as in CustomImage.java
From JS, send props to this component using Image.resolveAssetSource(require('imagename'))
Run the app in debug mode and see the marker.png is shown correct
Run android bundler for release mode and create a signed apk and upload it to either emulator or physical device. See marker.png is not show because URI is not formed correctly.

Note: To see what props are sent to native component, I also print out props in a Text component. URI is formed without file extension or full path. Therefore ImageView cannot find the resource.
The whole thing is reproducible in this bare minimum repo created with latest versions:
https://github.com/aliustaoglu/react-native-bug-resolve-asset-source
Files to check:
App.js
CustomImage.java

Please use this instead.
<CustomImage style={{ width: imgProps.width, height: imgProps.height }} src={img} />

Image.resolveAssetSource() doesn't intend to be used directly and for network image width and height won't be available.

Image.resolveAssetSource() doesn't intend to be used directly

What is it supposed to mean? Documentation does not mention anything about calling it directly. Also it is an exposed function which means it could be called. I am not doing any hack. Just using a function that is exposed. It is callable and it does work, just not in the release mode. width and height is not a concern for this one as it is a static asset.

ImageSource is an object like { uri: '<http location || file path>' }

According to here it is intended to be called and can be http location or file path. http location works both in debug and relese but file path is not working for release.

<CustomImage style={{ width: imgProps.width, height: imgProps.height }} src={img} />

CustomImage is a native module and src is a @ReactProp and that way does not work. require('modulename') as a ReactProp, does not resolve to anything meaningful from native side.
This issue was discussed in https://github.com/facebook/react-native/issues/18216 but was not resolved due to inactivity and closed. I made a repo in which this is reproducible.

Then @aliustaoglu should refer to native's ImageSource not from javascript side.
I said that be cause it not meant to be used the way you used it. That is implementation detail.

Thanks for the helper function suggestion. I think I'll handle it from the native side. However, I still think that this is an issue. An implementation detail should not be exported then. I see that in stackoverflow people suggest using this method. That's why private and public functions exist.

below code should work as expected. Also resources on Android doesn't include file extensions and url like path. To make development easy, RN runs metro bundler which acts as web server for assets and makes reload possible.
const img = require('./images/png/marker.png')
<CustomImage style={{ width: imgProps.width, height: imgProps.height }} src={imgProps} />

@aliustaoglu may i know how u fixed the issue?

@rajashekar545
I did something like this:
If ui starts with "http" (or it's in debug mode) get the bitmap from uri
URL url = new URL("http://<IP_ADDRESS>:8081/assets/images/png/marker.png");
Bitmap image = BitmapFactory.decodeStream(url.openConnection().getInputStream());

if not (release mode) then it resolves to R.drawable.images_png_marker. Please note that nested folders are flattened into a single file name. So, to make it come from JavaScript and come as prop I did below:
String assetName = "images_png_marker"
int resourceId = context.getResources().getIdentifier(assetName, "drawable", context.getPackageName());
// int resourceId = R.drawable.images_png_marker // This will work as well
Bitmap image = BitmapFactory.decodeResource(getResources(), resourceId);

If interested for IOS I add the folder that has the png files into
Build Phases > Copy Bundle Resources
then from Swift I can get it like this:
let uiImage = UIImage(named: "images/png/marker.png")

This structure works good for me.

Can confirm the above works -- not the most elegant, but it works. For anyone else struggling I was looking for an mp4 file, which was in the "raw" deftype instead of "drawable".
Here's my code:
int resourceId = mReactContext.getResources().getIdentifier(videoUrl, "raw", mReactContext.getPackageName());
resolvedUri = RawResourceDataSource.buildRawResourceUri(resourceId);

@rajashekar545
I did something like this:
If ui starts with "http" (or it's in debug mode) get the bitmap from uri
URL url = new URL("http://<IP_ADDRESS>:8081/assets/images/png/marker.png");
Bitmap image = BitmapFactory.decodeStream(url.openConnection().getInputStream());

if not (release mode) then it resolves to R.drawable.images_png_marker. Please note that nested folders are flattened into a single file name. So, to make it come from JavaScript and come as prop I did below:
String assetName = "images_png_marker"
int resourceId = context.getResources().getIdentifier(assetName, "drawable", context.getPackageName());
// int resourceId = R.drawable.images_png_marker // This will work as well
Bitmap image = BitmapFactory.decodeResource(getResources(), resourceId);

If interested for IOS I add the folder that has the png files into
Build Phases > Copy Bundle Resources
then from Swift I can get it like this:
let uiImage = UIImage(named: "images/png/marker.png")

This structure works good for me.

@aliustaoglu Where did you write this code, in your CustomImage.java or any other file. Please give me more details about this implementation. I am also facing same problem while creating html to pdf. It works fine on debug app but not in release mode. It just shows image name as assets_images_logo. Please give more details about this implementation.
Thanks in advance.

@rajashekar545
I did something like this:
If ui starts with "http" (or it's in debug mode) get the bitmap from uri
URL url = new URL("http://<IP_ADDRESS>:8081/assets/images/png/marker.png");
Bitmap image = BitmapFactory.decodeStream(url.openConnection().getInputStream());

if not (release mode) then it resolves to R.drawable.images_png_marker. Please note that nested folders are flattened into a single file name. So, to make it come from JavaScript and come as prop I did below:
String assetName = "images_png_marker"
int resourceId = context.getResources().getIdentifier(assetName, "drawable", context.getPackageName());
// int resourceId = R.drawable.images_png_marker // This will work as well
Bitmap image = BitmapFactory.decodeResource(getResources(), resourceId);

If interested for IOS I add the folder that has the png files into
Build Phases > Copy Bundle Resources
then from Swift I can get it like this:
let uiImage = UIImage(named: "images/png/marker.png")

This structure works good for me.

Save my day bro!


line 300 [Condition] AttributeError

https://github.com/outon/HomeAssistant-AEMET/blob/16c68c34bb7b0e69823a7bbd89a60bb3dd9a6648/aemet/weather.py#L293
Hi, since yesterday I'm having the following issue.
I'm trying to get familiar with AEMET API to understand if the error is just mine or is happening to someone else.
In the meantime, here's what HA is showing me. I'll update the issue if I found out.
Wed Nov 13 2019 18:24:35 GMT+0100 (hora estándar de Europa central) Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 408, in _async_add_entity     await entity.async_update_ha_state()   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 275, in async_update_ha_state     self._async_write_ha_state()   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 309, in _async_write_ha_state     state = self.state   File "/config/custom_components/aemet/weather.py", line 141, in state     return self.condition   File "/config/custom_components/aemet/weather.py", line 300, in condition     condition = self._aemet_forecast_current_hour.get("condition", "desconocido") AttributeError: 'NoneType' object has no attribute 'get'

Ops!! Are you using the "master" branch?
I am developing the ASYNC version of this component and I may be messed up with different branches. I will review master branch to ensure that no code has being mixed between branches.

Hi, yes.
I'm using the master branch with the latest updates.
Let me know if there's anything I can do on my side to help you debug this.
Thanks!

I found the error...
AEMET changed the way they inform "Fecha" field (date) and now instead of using only DATE with format "YYYY-MM-DD" they also include TIME so they complies with ISO8601.
Their new format is "YYYY-MM-DDTHH:MI:SS", they made changes but did not update "Version" field.
I have to fix my program.


fix: include terser-webpack-plugin as dependency

What kind of change does this PR introduce?
dependency bugfix
Did you add tests for your changes?
no
Summary
was trying the next branch, but was failing without locally installing this module.
Does this PR introduce a breaking change?
nope
Other information
Node: v8.10.0
npm<EMAIL_ADDRESS>CLI<EMAIL_ADDRESS>operating system: macOS
browser: N/A
$ preact build
module.js:549
    throw err;
    ^

Error: Cannot find module 'terser-webpack-plugin'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/redacted/node_modules/preact-cli/lib/lib/webpack/webpack-client-config.js:8:22)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/redacted/node_modules/preact-cli/lib/lib/webpack/run-webpack.js:9:22)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
error Command failed with exit code 1.

Ahhhhh #facepalm

Sorry @lukeed, can you publish again?


fix(keystone): do not expand match any role policy

do not expand match any role policy
这个 PR 实现什么功能/修复什么问题:
修正：policy初始化时，不扩展匹配任意角色的权限

是否需要 backport 到之前的 release 分支:

release/3.6

/cc @zexi
/area keystone

Codecov Report

Merging #9460 (6115fe9) into master (a0712c2) will decrease coverage by 1.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #9460       +/-   ##
==========================================
- Coverage    5.91%   3.97%    -1.95%
==========================================
  Files         842     170      -672
  Lines      130684   25463   -105221
==========================================
- Hits         7731    1012     -6719
+ Misses     122253   24337    -97916
+ Partials      700     114      -586

Flag
Coverage Δ

aFlag
3.97% <ø> (-1.95%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/globalvpcs.go

pkg/mcclient/options/dbinstances.go

pkg/apigateway/handler/csrfexempt.go

pkg/mcclient/options/k8s/charts.go

pkg/keystone/models/user_option.go

pkg/compute/models/guestsecgroups.go

pkg/util/cgrouputils/cpuutils.go

pkg/compute/models/instance_snapshots.go

pkg/apigateway/handler/init.go

pkg/monitor/models/query_signature.go

... and 661 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0712c2...6115fe9. Read the comment docs.


Tag name confusion

Just wanted to let you know the most recent tag seems to be a typo.

Whoops thanks that's corrected now


Fix typos in README.md

Nice catch. Funny that we had never noticed that!

Thanks! Reading through, it seems there are many typos in the README... :/


Unable to resolve internal ID

I tried running with this command on a 1000 of our objects:
java -jar migration-utils-6.1.0-driver.jar \
  --source-type legacy \
  --datastreams-dir /home/lyberadmin/apps/fedora/home/data/datastreamStore \
  --objects-dir /home/lyberadmin/apps/fedora/home/data/objectStore \
  --target-dir ocfl \
  --limit 1000 \
  --continue-on-error \
  --debug

I suspect this is the result of our idosyncratic use of Fedora, but 999/1000 of the objects failed with this error:
ERROR 05:05:41.716 (Migrator) MIGRATION_FAILURE: pid="druid:cf604sc3425", message="Unable to resolve internal ID "druid:cf604sc3425+rightsMetadata+rightsMetadata.0"!"
java.lang.RuntimeException: Unable to resolve internal ID "druid:cf604sc3425+rightsMetadata+rightsMetadata.0"!
        at org.fcrepo.migration.foxml.DirectoryScanningIDResolver.resolveInternalID(DirectoryScanningIDResolver.java:129)
        at org.fcrepo.migration.foxml.FoxmlInputStreamFedoraObjectProcessor$Foxml11DatastreamVersion.<init>(FoxmlInputStreamFedoraObjectProcessor.java:401)
        at org.fcrepo.migration.foxml.FoxmlInputStreamFedoraObjectProcessor.processObject(FoxmlInputStreamFedoraObjectProcessor.java:194)
        at org.fcrepo.migration.Migrator.run(Migrator.java:161)
        at org.fcrepo.migration.PicocliMigrator.call(PicocliMigrator.java:328)
        at org.fcrepo.migration.PicocliMigrator.call(PicocliMigrator.java:51)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1743)
        at picocli.CommandLine.access$900(CommandLine.java:145)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2101)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2068)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1935)
        at picocli.CommandLine.execute(CommandLine.java:1864)
        at org.fcrepo.migration.PicocliMigrator.main(PicocliMigrator.java:175)

Is there any obvious solution to this?

@edsu It looks like what's happening here is that it's looking for a datastream with the id druid:cf604sc3425+rightsMetadata+rightsMetadata.0 but can't find it. Can you confirm that that datastream exists in /home/lyberadmin/apps/fedora/home/data/datastreamStore?

Yes, you're right. That file doesn't exist in datastreamStore. I'm just remembering now that I'm working with a possibly partial copy of our production Fedora instance. So I suspect this is a problem with the copy and not migration-utils.

@edsu I see that you ran your migration command with --source-type legacy. If your repository is using the legacy format, then I would expect to see date based paths like 2009/0508/20/48 within your datastreams directory. Is this what you see? If not, are you using akubra? The akubra layout is based on the md5 hash of the object PID plus the datastream id.

Nice catch, I see sub-directories named with two character hex values 00-FF. I guess this is akubra? I still get the same Unable to resolve internal ID errors when running with --source-type akubra. I guess I will need to search the filesystem to see if the file is there, and the see if it is being looked up correctly?

So, the code does a full scan of your datastreams and creates an index that maps id to location, which is why it would still fail even after passing it the akubra source type.
This is the Fedora 3 code that maps to akubra paths: https://github.com/fcrepo3/fcrepo/blob/37df51b9b857fd12c6ab8269820d406c3c4ad774/fcrepo-server/src/main/java/org/fcrepo/server/storage/lowlevel/akubra/HashPathIdMapper.java
If the internal id druid:cf604sc3425+rightsMetadata+rightsMetadata.0 is correct (I don't know if it is or not), then I would try looking under e0/80

Hmm, I only have one level of sub-directories under datastreamStore. I need to double check with people more knowledgeable than me to see if we have a customized Fedora Store.

@edsu The format is configurable. See: https://wiki.lyrasis.org/display/FEDORA38/Configuring+Low+Level+Storage#ConfiguringLowLevelStorage-AkubraLowLevelStorage(New)
Look for a line like this in your config: https://github.com/fcrepo3/fcrepo/blob/37df51b9b857fd12c6ab8269820d406c3c4ad774/fcrepo-server/src/main/resources/fcfg/server/akubra-llstore.xml#L62
I guess the default is just one level, ##. So, perhaps it's under e0/?

Alas it's not under e0. I started a search across the whole tree to see where it might be.
In the meantime I noticed that the datastreamStore files seem to have a info:fedora prefix (this is just a list of the first 5 files in the 00 directory):
$ ls 00 | head -5
info%3Afedora%2Fdruid%3Abb001hh3574%2FprovenanceMetadata%2FprovenanceMetadata.0
info%3Afedora%2Fdruid%3Abb006gm6059%2FrightsMetadata%2FrightsMetadata.0
info%3Afedora%2Fdruid%3Abb006hs1829%2FprovenanceMetadata%2FprovenanceMetadata.0
info%3Afedora%2Fdruid%3Abb009mb1479%2FidentityMetadata%2FidentityMetadata.0
info%3Afedora%2Fdruid%3Abb011vh2231%2FprovenanceMetadata%2FprovenanceMetadata.0

And that 00 are the first two characters of the md5 of the URL decoded filename:
>>> from urllib.parse import unquote
>>> from hashlib import md5
>>> md5(unquote('info%3Afedora%2Fdruid%3Abb001hh3574%2FprovenanceMetadata%2FprovenanceMetadata.0').encode('utf8')).hexdigest()
'00345d15cdddf9a509fd0666599fdd18'

Is it possible that migration-utils is looking up the id without the info:fedora prefix and not finding it because the md5 that was calculated is incorrect? Should I be doing something with --id-prefix?

@edsu Yes, the path is based on the md5 hash of the identifier. You are correct that it is supposed to start with info:fedora. Can you post the FOXML for druid:cf604sc3425? It seems like it has a bad REF in it that is pointing to an incorrectly formatted internal id.

Sure, I can share it with you via email (just drop me an email at<EMAIL_ADDRESS>and I can reply with it).
In other news, my find command finished overnight. It looks like the datastream is here:
datastreamStore/c7/info%3Afedora%2Fdruid%3Acf604sc3425%2FrightsMetadata%2FrightsMetadata.0

But decoding that path yields a different id:
info:fedora/druid:cf604sc3425/rightsMetadata/rightsMetadata.0

This uses / where the id in the log message had +?
ERROR 05:05:41.716 (Migrator) MIGRATION_FAILURE: pid="druid:cf604sc3425", message="Unable to resolve internal ID "druid:cf604sc3425+rightsMetadata+rightsMetadata.0"!"

java.lang.RuntimeException: Unable to resolve internal ID "druid:cf604sc3425+rightsMetadata+rightsMetadata.0"!

Yes, hand editing has definitely been possible. But the weird thing is that 999 of the 1000 objects I tested with had the same problem. Maybe I should sample a different range of PIDs, but I suspect it will be consistent. I can double check that Fedora is able to return these datastreams ok.

I just tested with 50,000 objects and 49,995 of them have this same problem. So at least it is (mostly) consistent. Fedora itself is able return the datastream. I'm assuming it uses the Object XML to do that, but I also know there is a MySQL database so perhaps not.
I'll inquire to see if we've modified our Fedora instance in some way. But I'm new and a lot of this work was done a long time ago, so ... I'm assuming you've had others use the Akubra migration successfully?

Yes, numerous people have successfully done an akubra migration. This is the first time I've seen this problem. Without doing a code dive, I'm not sure how your Fedora instance is able to retrieve those datastreams. I've asked some people who are more knowledgeable about Fedora 3 to take a look at this ticket.

<foxml:contentLocation TYPE="INTERNAL_ID" REF="druid:cf604sc3425+rightsMetadata+rightsMetadata.0"/> is just the location where the data was picked up from during ingest.  It has no bearing on the actual location of the data within Fedora.
I'm suspecting that there may be some kind character encoding gotcha buried here in the migration-utils code.
Can you create a sample set of 5 or so PIDs to migrate, run the migrator on the sample set of PIDs with the debug flag turned on, and post the complete log file somewhere?

If you enabled trace logging you could see what it was putting in the index:
https://github.com/fcrepo-exts/migration-utils/blob/a14d64c4d35afa134c1466b595fe0f2531136465/src/main/java/org/fcrepo/migration/foxml/DirectoryScanningIDResolver.java#L149

Attached is the debug log when running against 5 objects with the following command:
java -jar migration-utils-6.1.0-driver.jar \
  --source-type akubra \
  --datastreams-dir /home/lyberadmin/apps/fedora/home/data/datastreamStore \
  --objects-dir /home/lyberadmin/apps/fedora/home/data/objectStore \
  --target-dir ocfl \
  --limit 5 \
  --continue-on-error \
  --debug \
  > convert.log

Is there an easy way to enable trace logging?
convert.log

Oh, I bet what is happening is the first time I ran it with --source-type legacy and it created the index. Then I ran it again with --source-type akubra and it skipped index creation since it already existed (it took hours to build). So even though it is looking for akubra the index is built with legacy?

Yes, I was about to ask if you cleared the index.  Try that, then run with akubra.

Ah! That makes sense. Yes, I bet that's what the problem is.

It was the problem! Thanks for helping debug and sanity check this @pwinckles & @sparter -- it is greatly appreciated!

I run into the same issue and the reason seems to have been different group ownership on the folder.
This object went through:
# ls -lahs /usr/local/fedora/data/datastreams/2024/1114/10/50
total 2.4M
4.0K drwxr-xr-x 2 tomcat tomcat 4.0K Nov 14 10:50 .
4.0K drwxr-xr-x 4 tomcat tomcat 4.0K Nov 14 10:51 ..
2.4M -rw-r--r-- 1 tomcat tomcat 2.4M Nov 14 10:50 o_5629+OCTETS+OCTETS.0

This one not:
# ls -lahs /usr/local/fedora/data/datastreams/2018/0216/12/30/
total 1.8M
4.0K drwxr-xr-x  2 tomcat phaidev 4.0K Feb 16  2018 .
4.0K drwxr-xr-x 14 tomcat phaidev 4.0K Feb 16  2018 ..
1.8M -rw-r--r--  1 tomcat phaidev 1.8M Feb 16  2018 o_2722+OCTETS+OCTETS.0

INFO 12:23:44.947 (Migrator) Processing "o:2722"...
ERROR 12:23:44.948 (Migrator) MIGRATION_FAILURE: pid="o:2722", message="Unable to resolve internal ID "o:2722+OCTETS+OCTETS.0"!"
java.lang.RuntimeException: Unable to resolve internal ID "o:2722+OCTETS+OCTETS.0"!
        at org.fcrepo.migration.foxml.DirectoryScanningIDResolver.resolveInternalID(DirectoryScanningIDResolver.java:129)
        at org.fcrepo.migration.foxml.FoxmlInputStreamFedoraObjectProcessor$Foxml11DatastreamVersion.<init>(FoxmlInputStreamFedoraObjectProcessor.java:410)
        at org.fcrepo.migration.foxml.FoxmlInputStreamFedoraObjectProcessor.processObject(FoxmlInputStreamFedoraObjectProcessor.java:195)
        at org.fcrepo.migration.Migrator.run(Migrator.java:161)
        at org.fcrepo.migration.PicocliMigrator.call(PicocliMigrator.java:342)
        at org.fcrepo.migration.PicocliMigrator.call(PicocliMigrator.java:51)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1743)
        at picocli.CommandLine.access$900(CommandLine.java:145)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2101)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2068)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1935)
        at picocli.CommandLine.execute(CommandLine.java:1864)
        at org.fcrepo.migration.PicocliMigrator.main(PicocliMigrator.java:184)

I don't get why this happen since the file should be readable and directories executable to anyone anyway?
The problem is actually not the resolving but the indexing, so after I've chowned to tomcat:tomcat I had to remove the index too, then it went through.


[POC] Single Colour theme

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-
Changed

Screenshots

POC work - i cant see this going ahead anytime soon


Adds solution for leetcode problem 1423 in Kotlin

File(s) Modified: 1423-maximum-points-you-can-obtain-from-cards.kt
Language(s) Used: Kotlin
Submission URL: _https://leetcode.com/problems/maximum-points-you-can-obtain-from-cards/submissions/940373560/_

Thanks!


stream update fails if channel not in wallet (has cert only)

If you import a certificate and then sign a claim with it, you can't run a stream update. Publish does seem to work fine. You should only need the cert to re-sign the claim.
C:\Users\thoma\Desktop>lbrynet stream update --claim_id=b533e4d5bcb3cbd8a4852c0d76347124fb53764d --preview
{
  "code": -32500,
  "data": [
    "Traceback (most recent call last):",
    "  File \"c:\\users\\thoma\\documents\\lbry\\lbry\\lbry\\extras\\daemon\\Daemon.py\", line 584, in _process_rpc_call",
    "    result = await result",
    "  File \"c:\\users\\thoma\\documents\\lbry\\lbry\\lbry\\extras\\daemon\\Daemon.py\", line 2681, in jsonrpc_stream_update",
    "    old_txo, claim, amount, claim_address, funding_accounts, funding_accounts[0], channel",
    "  File \"c:\\users\\thoma\\documents\\lbry\\lbry\\lbry\\wallet\\transaction.py\", line 232, in claim_update",
    "    updated_claim.sign(signing_channel, b'placeholder txid:nout')",
    "  File \"c:\\users\\thoma\\documents\\lbry\\lbry\\lbry\\wallet\\transaction.py\", line 153, in sign",
    "    self.claim.signature = channel.private_key.sign_digest_deterministic(digest, hashfunc=hashlib.sha256)",
    "AttributeError: 'NoneType' object has no attribute 'sign_digest_deterministic'",
    ""
  ],
  "message": "'NoneType' object has no attribute 'sign_digest_deterministic'"```

This now fixed in 0.41

I lied, it's still broken. It does seem to work fine if you pass the channel_id again, but this shouldn't be required for an update. Works fine for a claim inside a default account, with a non-imported cert.
Publish still works when passing the same id.

This is no longer an issue.


The Demo isn't working

The images don't load on this:
https://jamesxwang.com/vue-hotspot/
browser: Firefox Dev Edition 94.0b9 (64-bit)

Hi @ztickm, thanks for letting me know. Fixed the broken links! 🚀


Fix for regression introduced by version 0.10.8 when using component BFormInput #1398

Describe the PR
See bug report #1398
This a minimal & quick fix for my issue, hope it doesn't introduce other regressions...

Doing this overwrites why I removed the code in the first place. There is likely a better solution, one that isn't known to me at this time.

Doing this overwrites why I removed the code in the first place. There is likely a better solution, one that isn't known to me at this time.

Ok, I thought the initial problem you tried to solve was that no "change" event was ever sent ^^
Replacing my patch with:
    const nextModel = _getModelValue(formattedValue)
    if (modelValue.value !== nextModel) {
      inputValue = value
      updateModelValue(formattedValue, true)
    }

would also solve the problem for me (I tested it). I think it's a valid alternative, because I don't see why the code should "force update" the model value (using debounce or not, lazy or not) when the value hasn't changed meanwhile. The same reasoning could probably be applied to the onBlur method. Of course, I could be wrong, I didn't dive into your code, but for sure the current code breaks things that worked well before ^^


Add METIS emissions admin payload Metis L2 network [WIP]

[X] METIS emissions admin on Metis L2 payload
[X] Payload tests
[ ] AIP

this was covered by: https://github.com/bgd-labs/aave-proposals/pull/227


[BEAM-11626] Upgrading Guava to 30.1-jre while keeping 25.1-jre for Hadoop/Cassandra modules

This PR upgrades the non-vendored Guava version to the latest 30.1-jre, while keeping the version 25.1-jre for certain modules (Hadoop and Cassandra-related) that require the old version of Guava.
Why do I want the latest Guava?
When Beam publishes a recommended version of Guava for Dataflow users (https://github.com/apache/beam/pull/13737, WIP), I want the recommended version in line with the one in the GCP Libraries BOM (with "-jre" suffix). This is because Google Cloud client libraries are built and tested with the newer version of Guava. I want Beam's Dataflow and Google Cloud Platform modules to be built, tested, and used with the same version of Guava as much as possible.
If we don't do this PR, we would end up a situation where the GCP Libraries BOM recommends to use Guava 30 and Beam's GCP BOM recommends Guava 25.
What is the problem with Guava 25?
When a library touch classes or methods that only exist in the newer version of Guava, it fails with NoClassDefFoundError or NoSuchMethodError. For example, gcsio uses Uninterruptibles.sleepUninterruptibly(java.time.Duration) in it and Linkage Checker detects the usage:
(com.google.guava:guava:25.1-jre) com.google.common.util.concurrent.Uninterruptibles's method sleepUninterruptibly(java.time.Duration) is not found;
  referenced by 3 class files
    com.google.cloud.hadoop.gcsio.cooplock.CoopLockOperationDao (com.google.cloud.bigdataoss:gcsio:2.1.6)
    com.google.cloud.hadoop.gcsio.cooplock.CoopLockRecordsDao (com.google.cloud.bigdataoss:gcsio:2.1.6)
    com.google.cloud.hadoop.gcsio.testing.InMemoryObjectEntry (com.google.cloud.bigdataoss:gcsio:2.1.6)

The method only exists in Guava 28 or higher. This might not be a problem for Dataflow-only users for now, but this may cause other use cases of the library. Therefore, I want to recommend the newer version of Guava to GCP users.
Problem with newer Guava version in Hadoop/Cassandra
If I naively upgrade the Guava version to 30.1-jre, the tests failed with NoSuchMethodError for Futures.addCallback and
NoSuchFieldError for DIGIT (CharMatcher). Details are in BEAM-11626.
This PR fixes the problem by keeping the Guava version lower for the Hadoop/Cassandra-related modules.
Where is the Guava dependency declared?
The following Gradle modules declare dependency to the guava variable:
suztomo-macbookpro44% find . -name 'build.gradle' |xargs grep 'library.java.guava'
./sdks/java/core/build.gradle:  shadowTest library.java.guava_testlib
./sdks/java/io/kinesis/build.gradle:  compile library.java.guava
./sdks/java/io/kinesis/build.gradle:  testCompile library.java.guava_testlib
./sdks/java/io/amazon-web-services2/build.gradle:  testCompile library.java.guava_testlib
./sdks/java/io/google-cloud-platform/build.gradle:  compile library.java.guava
./sdks/java/io/contextualtextio/build.gradle:    testCompile library.java.guava_testlib
./sdks/java/extensions/sql/zetasql/build.gradle:  compile library.java.guava
./sdks/java/maven-archetypes/examples/build.gradle:    'guava.version': dependencies.create(project.library.java.guava).getVersion(),
./runners/google-cloud-dataflow-java/build.gradle:  testCompile library.java.guava_testlib

Other than tests, the 3 modules declaring the Guava dependencies are sdks/java/io/kinesis,  sdks/java/io/google-cloud-platform, and sdks/java/extensions/sql/zetasql.

sdks/java/io/kinesis module has

com.amazonaws:amazon-kinesis-client:1.13.0 built with Guava 26.0-jre
com.amazonaws:amazon-kinesis-producer:0.14.1 built with Guava 24.1.1-jre
Linkage Checker found no new linkage errors for beam-sdks-java-io-kinesis (link).

Google Cloud libraries are built with the latest Guava
The zetasql client 2020.10.1 is built with Guava 29.

Linkage Checker detected a potential conflict between org.apache.hadoop:hadoop-yarn-common:2.10.1 (Yarn's WebApp class) and Guava 30. The conflict already exists in Guava 29. Therefore, existing Dataflow Zetasql users will not see a problem with Guava 30.

The sdks/java/maven-archetypes/examples module is tricky one. I want Hadoop/Cassandra users to use Guava 25.1 and others to use Guava 30.
What's the impact to Beam's Cassandra / Hadoop users?
There's no impact to the Beam Cassandra and Hadoop artifacts. The Maven artifact org.apache.beam:beam-sdks-java-io-hadoop-format:2.27.0, org.apache.beam:beam-sdks-java-io-cassandra:2.27.0, or org.apache.beam:beam-sdks-java-io-hadoop-file-system:2.27.0
does not declare Guava dependency.
Instruction for Hadoop / Cassandra Beam users
If Beam Cassandra / Hadoop users use Beam with beam-sdks-java-io-kinesis, beam-sdks-java-io-google-cloud-platform, or beam-sdks-java-extensions-sql-zetasql, then the users need to pin Guava version to 25.1-jre. They can use <dependencyManagement> for Maven and force for Gradle.
Linkage Check
https://gist.github.com/suztomo/beb9033d39da1545d117750c0602ae69
No new linkage errors for the default list.  There is one error in Yarn's WebApp class (see above), which is a provided dependency of hadoop-client.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

 I see all checks are green. Moved this PR out of draft.

@ibzib Thanks. I see all checks are green. Moved this PR out of draft.

R: @ibzib  @kennknowles @aaltay
For https://github.com/apache/beam/pull/13740#discussion_r558559746 by @aaltay

Ack. I think this would be an undocumented hurdle for the impacted users. I am not sure what is the best course of action. Hopefully @kennknowles would have a recommendation.

Let me know if I need to add more information somewhere.

R: @ibzib  @kennknowles @aaltay
For https://github.com/apache/beam/pull/13740#discussion_r558559746 by @aaltay

Ack. I think this would be an undocumented hurdle for the impacted users. I am not sure what is the best course of action. Hopefully @kennknowles would have a recommendation.

Let me know if I need to add more information somewhere.

R: @ibzib @kennknowles @aaltay
For #13740 (comment) by @aaltay

Ack. I think this would be an undocumented hurdle for the impacted users. I am not sure what is the best course of action. Hopefully @kennknowles would have a recommendation.

Let me know if I need to add more information somewhere.

We can add a note to the release note about this.
I think a more sustainable solution would be to add a page java sdk, its dependencies, and addressing common issues related to dependencies. (@kennknowles and @tysonjh - would such a page be helpful to users?)

R: @ibzib @kennknowles @aaltay
For #13740 (comment) by @aaltay

Ack. I think this would be an undocumented hurdle for the impacted users. I am not sure what is the best course of action. Hopefully @kennknowles would have a recommendation.

Let me know if I need to add more information somewhere.

We can add a note to the release note about this.
I think a more sustainable solution would be to add a page java sdk, its dependencies, and addressing common issues related to dependencies. (@kennknowles and @tysonjh - would such a page be helpful to users?)

I think so. There isn't much developer content that would cover this area in the existing website (e.g. https://beam.apache.org/documentation/sdks/java/). It could be a place to host a FAQ or best practices that could include this information, recommending using BOMs where possible, etc.
A dependency issue with Guava is sadly a pretty well discussed problem throughout the web so developers are pretty familiar with the steps for resolution.

Run SQL Postcommit

Run Spark ValidatesRunner

Run Dataflow ValidatesRunner

Run Java HadoopFormatIO Performance Test

R: @ibzib @kennknowles @aaltay
For #13740 (comment) by @aaltay

Ack. I think this would be an undocumented hurdle for the impacted users. I am not sure what is the best course of action. Hopefully @kennknowles would have a recommendation.

Let me know if I need to add more information somewhere.

We can add a note to the release note about this.
I think a more sustainable solution would be to add a page java sdk, its dependencies, and addressing common issues related to dependencies. (@kennknowles and @tysonjh - would such a page be helpful to users?)

I think so. There isn't much developer content that would cover this area in the existing website (e.g. beam.apache.org/documentation/sdks/java). It could be a place to host a FAQ or best practices that could include this information, recommending using BOMs where possible, etc.
A dependency issue with Guava is sadly a pretty well discussed problem throughout the web so developers are pretty familiar with the steps for resolution.

Got it. It is your call as you are all more familiar with Java specific concerns.

Run SQL Postcommit

Run Java PostCommit

Run Spark ValidatesRunner

Run Dataflow ValidatesRunner

Run Java HadoopFormatIO Performance Test

Run Python PreCommit

@aaltay It's ready for merge; 34 successful checks, including "Java PostCommit".

so developers are pretty familiar with the steps for resolution.

Yes, I also observe the same. For Beam users, this is just a normal version upgrade of transitive Guava dependency. I've added an item into the "Breaking Changes" section of CHANGES.md to make it easy to identify when this change happened.

I agree with @suztomo that generally users know about the issues with Guava. While technically a breaking change (as many dep upgrades are) I think this will improve things greatly for users and will fix potentially surprising bugs.

Sorry to hijack this PR but I wanted to ask @suztomo or someone else to take care of upgrading our vendored gRPC. It is probably a good idea because of the security issue mentioned in https://issues.apache.org/jira/browse/BEAM-11227 Can someone please take a look

@iemejia Let me create a PR to see what breaks. (I don't know how it's released though)

Thanks @suztomo! If you can get it upgraded and tested I can kick off a release. I don't recall exactly, but I think I can figure it out and document it.

@kennknowles I think I found the document. https://github.com/apache/beam/tree/master/vendor
Now questions is how we confirm the CVE is addressed https://issues.apache.org/jira/browse/BEAM-11227?focusedCommentId=17287496&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17287496 (let's continue comments there)


Updates to Vertica content based on core 1.4.0

Updates to Vertica content based on core 1.4.0

@dataders Can you please help us with these updates to Vertica content? Thank you


Issue 34

Python 3 compatibility issue

@darxtrix, could you please look through these pull requests? I chose to add it individually because it would be better for you to look into the issues.

Yes, I have a plan to add all of these changes tomorrow. Sadly, my laptop broke down and couldn't take a look over them earlier.

Hi @vinusankars @deeps-nars I am using manjaro linux distro and having problems with the display of Braille unicode characters that is used to render the charts. Interestingly all other unicode set is working fine except the Braille character. Hence, I am blocked on the issues. I have posted on the manjaro forums and is waiting for any workarounds. Attaching a screenshot:

Meanwhile thinking to spin up an ubuntu VM or a chrome extension terminal where braille is rendering properly. Sorry for the delay and thanks for the patience.

Hi @vinusankars @deeps-nars can you guys tell what fonts (system fonts) you guys are using ?

@vinusankars looks great, just want to factor out the time conversion function before merging.

@darxtrix thabk you! My pleasure.

Cool, great!


Add support for uppercase file extensions

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Updates loadSpriteData.js, loadMusicData.js, and loadBackgroundData.js to load .PNG
and .MOD files on start. Updates watchProject.js to watch sprites, music, and backgrounds
with .PNG and .MOD file extensions. Also provides a test project, Test_UppercaseFileExtension,
to confirm functionality.

What is the current behavior? (You can also link to an open issue here)

Fixes #399. Images and music with file extensions .PNG and .MOD are ignored
on load and are not watched.

What is the new behavior (if this is a feature change)?

Allow users to use files with uppercase extensions for sprites, backgrounds, and music.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, this should not affect previous user applications, as they have only been able to use lower case file extensions. Please see other information for follow up.

Other information

If you rename an asset to have the same name except giving it an uppercase file extension while it is being used in a project, the asset will appear to disappear and when you try to run the game it causes a missing asset error. This can be fixed by changing the asset to a different one then changing it back, as the renamed version has been loaded in as a new asset. Also if you rename any of the assets to an uppercase file extension and the project had previously saved the lowercase file extension you could run into a similar issue as above when you open the project again. This has a similar fix as above, making sure to save the project after you apply the fix. This issue has similarity with #387.
On case sensitive file systems, you could have two assets with the same name, but one with an uppercase and one with a lowercase file extension.

Provide some additional information about changing previously used assets to have uppercase file extensions

Thanks @zdurgan Took me a while to have a look at this but it's all good and merged. I've also merged this into the v2 beta and added you to the beta changelog


Fix Clang -Winconsistent-missing-override warning

Adds missing override and final qualifiers to VulkanContextWindows::_get_platform_surface_extension(), similar to other VulkanContext implementations. Missing these causes a build error when building with dev_mode enabled (warnings as errors):
In file included from platform\windows\godot_windows.cpp:31:
In file included from platform\windows/os_windows.h:53:
platform\windows/vulkan_context_win.h:42:22: error: '_get_platform_surface_extension' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        virtual const char *_get_platform_surface_extension() const;
                            ^
./drivers/vulkan/vulkan_context.h:261:22: note: overridden virtual function is here
        virtual const char *_get_platform_surface_extension() const { return nullptr; }
                            ^
1 error generated.

Thanks!


Powershell Error- when running the script

Received the following error : Script "Qualitycheck.ps1" cannot be run because the following modules are specified by the #requires statemetns of the script are missing Az.NetAppFiles.

please install PowerShell Azure module Az

Please check your PowerShell settings if automatic module load is enabled.
do you see the commands loaded (can be checked with "Get-Command -Module Az.NetAppFiles")?
what if you e.g. enter "Get-AnfAccount" command?

closing due to no activity


Can this container be made available on unRAID’s CA Store?

Title, can see the xml and images exist already.

The Plutonium project has done a few changes in the past few months after sm2 was C&D.
I'll update the container and ensure it is working properly, and once that's done I'll get it added to the CA Store.

That’s great, thank you. Happy to do some testing for you if needed. I did get a similar project working in an LXC container - https://github.com/xr4zz/T6Server
there might be some stuff in there that you can use here.

Tested and everything seems to work without any changes.
I'll make an account on the unraid forums and submit this for CA.


I have a question. I called tarsgeway and reported a version error using the JSON protocol. What should I do?

With the latest version, the back-end service still reports an error. The back-end version is 1.7.2.

the generated plug-in needs to process this node. In the example server, change the node to true and regenerate the servant publishing service. If you take the example of Hello, the label is false. (see note figure)

生成的插件里面要处理一下这个节点，example Server里面，要把这个节点改成true，重新生成servsant发布服务即可，你拿的hello的example，这个标签是false。(见图)

It still reported an error. I debugged it. If this line of code is wrong, it will throw an exception if it doesn't go in.

Is there any restriction on the post request parameter?

还是报错了，我debug了，是这行代码出错了，判断没进去，就抛异常，

是不是post请求参数有什么限制？

what is your abnormal information here? If the getname cannot be obtained here, the name is not present when parsing, that is, the tup is not opened.

你这里的异常信息是什么？这里若是获取不到getName的话，就是解析的时候名称不在，就是tup这里没有开。

It still report this mistake.

还是报这个错。


Add additional data

Dear Authors,
I think your paper is very effective for discovering the ODEs and I am very interested in replicating the results of this paper. Now, I'd like to add some extra data:
I found that it is possible to change the parameter value of "--reload_data" to add data, but I don't know the path to add, or the format of this parameter value, can you give me an example to illustrate? I would appreciate it if you could give me some help!
greeting
Han Xinjie

maybe this is useful to check: https://github.com/sdascoli/odeformer/blob/main/ODEFormer_demo.ipynb


Using Channels/connections from multiple goroutines

Hi,
I'd like to use channels and connections from multiple goroutines, in the same way as db connections can be used concurrently. Looking at the docs, I'm unable to tell if this is safe - on the one hand, there's no explicit mention of thread safety, on the other hand, there are a number of reference to the desirability of long lived connections, mentions of locking, etc which makes me think it might be ok. What are the rules?

Channels are not supposed to be shared for concurrent publishing (in this client and in general).

it is thread safe: see https://github.com/streadway/amqp/blob/master/channel.go#L1285

Channels are not supposed to be shared for concurrent publishing (in this client and in general).

So is it thread safe? I see that the mutex on the connection is called when the send method is called?
At the same time, if it is not safe to share a channel under different groutines, should we create a new channel for each groutine?
The last thing I want to ask is that amqp's channel is mainly for multi-threaded concurrency. Is it appropriate to call the mutex on the connection when the send method is called?


Remove the v1 gcs

LCOW is only supported on RS5+ which already had LCOW v2. Remove unused V1 code.
Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

A sea of red 😄


Android Projects not building with Gradle 7.0 and latest AGP

I already created an issue on the Google Android issue tracker but they told I have to fill the issue here. Original issue: https://issuetracker.google.com/issues/181220769
Expected Behavior
After updating AGP from 7.0.0-alpha07 to 7.0.0-alpha08/7.0.0-alpha09 projects should still build
Current Behavior
Gradle fails with: Cannot query the value of this property because it has no value available
Steps to Reproduce

when building gradle throws "Cannot query the value of this property because it has no value available."
everything worked with 7.0.0-alpha07
error log and project to reproduce: https://travis-ci.com/github/G00fY2/DeveloperWidget/jobs/486487089

Your Environment
Studio Build: Arctic Fox | 2020.3.1 Canary 8 (Build #AI-203.7148.57.2031.7165533)
Version of Gradle Plugin: 7.0.0-alpha08
Version of Gradle: gradle-7.0-milestone-2
Version of Java: OpenJDK Runtime Environment JBR-<IP_ADDRESS>.11-944.50-jfx_jcef
OS: MacOS 11.2.1
CI Build:  https://travis-ci.com/github/G00fY2/DeveloperWidget/jobs/486487089

Hello, @G00fY2 , where was this flag? I cannot find it in my project. But, I am still facing the same issue.

@NLS-rajdeepdodiya this was a custom flag set in my project level gradle.properties file.


Is it possible to disable string length limitation for the value (OCPP 1.6)

Specifically implementing certificate exchange for ebee controller using OCPP 1.6 requires for changeConfigurationRequests to have values larger than 500 characters, since certificates can and usually do use more characters.
I was wondering if there is an easy already implemented way to do that with the library, or will we have to fork it and customize it?

Hi @Finalgamer14 -
It seems that this has to be customized. We forked and added our own implementation.

Hi thanks for the reply.
So I assume that changing the json schema file should be enough to achieve what we require.

Hi @Finalgamer14 - Yes.


Codeception Environments functionality was added.

We use 'environments' in our codeception's configs: http://codeception.com/docs/07-AdvancedUsage#Environments
So we added some new functionality in Webception. And now we can select different environments on webception page.

This doesn't seem to be working on the latest branch ( v0.1.1), perhaps because of the CodeCeption 2.0 updte.
If you're still involved with WebCeption, would you mind having a look?
It'd also be good and proper to add a test to check that your new functionality works.
If you're no longer interested, let me know and I'll take it on.


Commands to accept all pending 2fa confirmation requests

It mainly useful if you have main account connected to ASF with 2fa on. With recent steam changes setting every item to sell on trade market needs confirmation in 2fa authenticator, so I think it's a good thing to have a command to confirm them all in one click.
Another option is to have periodic check for pending 2fa confirmation, but I don't like this idea. If you think differently, or simply don't want this functionality in ASF - simply close this pull request, no hard feelings, I understand that it's not what majority of users would use.
I added !confirm, !confirm <BOT> and !confirmall commands, to accept all 2fa confirmation request on current bot, named bot and all running bots accordingly.

This is already possible, with recently added !2faok command :+1:.

Another option is to have periodic check for pending 2fa confirmation, but I don't like this idea

I don't like this either, but I also added such option, in newly introduced AcceptConfirmationsPeriod config property :+1:
Question is, if there is a need for !confirmall? I could add !2faokall but is there an use case for that?

Oh my, I should be more attentive... Actually, I made !confirmall just in case, if you think it's not useful - don't spend your time on it. If there would be any users who need it - it can always be implemented later.

I just think that nobody uses mass-listing of items on steam market from many accounts at once, I can understand primary account and maybe one-two alts, but that's it, still possible to do with !2faok and given bot instance. And yeah, if somebody asks for it, we can do it, it doesn't cost anything as everything is nicely coded already.
Don't blame yourself, I'm adding so many updates lately that it's "hard" to follow all of that. Just consider creating an issue next time, so I could tell you if it's already possible, on roadmap, or if you can add it if you want :+1:


Can't highlight terms ending in a period

Prerequisites

[ Y ] Can you reproduce the problem in safe mode?
[ Y ] Are you running the latest version of Atom?
[ Y ] Did you check the debugging guide?
[ Y ] Did you check the FAQs on Discuss?
[ Y ] Are you reporting to the correct repository?
[ Y ] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
Syntax highlighting does not occur for terms ending in a period ( . ).  This is necessary for use cases such as powerpc assembly, in which some opcodes behave differently when suffixed with a period, and in some cases only function with a period.
Steps to Reproduce

Use a language highlighting package that looks for terms ending in '.', such as language-powerpc-assembly
Activate that language, type a term that should be highlighted (in my case, addi), and on a new line, a term that should be highlighted that ends in a '.' (in my case, stdcx.)

Expected behavior: [What you expected to happen]
Terms ending in a '.' should be highlighted just as terms that don't end in a '.' are.
Actual behavior: [What actually happened]
Terms ending in a '.' are not highlighted until numbers are added after, it seems that there is hardcoded checking for numbers after a '.'

Versions
Atom    : 1.7.4
Electron: 0.36.12
Chrome  : 47.0.2526.110
Node    : 5.1.1

apm  1.9.2
npm  2.13.3
node 0.10.40
python 3.5.1
git 2.8.3

Arch Linux running kernel 4.5.4

Please report this to langauge-powerpc-assembly instead.  Thanks!

This has nothing to do with that package, though (of which I'm the author).  I'm saying that you can't highlight any term ending in a period, regardless of the specific language highlighting.  At the editor level, terms with a period behave as if they're invalid/unhighlighted until there's something written after the period.
I could fix it myself if I had any idea where to look in Atom's source.

No, this is a problem (actually two) with your language package.
The first problem is that you're only using a single backslash to escape the period when you need to be using two.  The second is that you're ending the capture with a word boundary match \b which doesn't allow periods to end the line.  You might want to use \s+ instead.

I tried with all sorts of backslashes, which wasn't enough.  I didn't know about the boundary match.  Thanks!


New Stick Push Reward

environment now trainable on SAC. Tensorboard: https://tensorboard.dev/experiment/BUd56aQzSdyyYZxDMhL4dA/

Unsure why the push rewards are showing up here. They should have merged in closed PR #322


Applying misc optimizations

Summary:

Adding PSR Http interfaces (psr/http-message) for ZttpResponse.
Using PSR-4 autoloading.
Adding namespace for tests
Splitting the classes into dedicated files
Adding status code constants for ZttpResponse
Adding $assoc & $options args to the ZttpResponse's json method.
Adding Psr\Http\Message\ResponseInterface typehint in the ZttpResponse's constructor.
Adding isOk()method in ZttpResponse class, it's a isSuccess() alias and shorter to type.
Adding doc comments in the Zttp class.
Adding the missing properties.
Removing the constructor in ZttpRequest in favor of the declared properties.
Adding a helpers.php file with the tap() (namespaced global function)
Updating phpunit config file for code coverage
Adding visibility for methods & properties (only classes in src folder)
All these changes are BC (All tests are green)

Suggestions:

Adding a setHttpClient(\GuzzleHttp\ClientInterface $client) into ZttpRequest allows to users to set a customized Http Client and also to replace the lumen server with a mocked http client object, something like this:

<?php

namespace Zttp;

use GuzzleHttp\Client;
use GuzzleHttp\ClientInterface;

class ZttpRequest
{
    //...

    /** @var  \GuzzleHttp\ClientInterface */
    protected $client;

    /**
     * Set the HTTP client.
     *
     * @param  \GuzzleHttp\ClientInterface|null  $client
     *
     * @return \Zttp\ZttpRequest
     */
    public function setHttpClient(ClientInterface $client = null)
    {
        $this->client = $client;

        return $this;
    }

    //...

    /**
     * Send a request.
     *
     * @param  string  $method
     * @param  string  $url
     * @param  array   $options
     *
     * @return \Zttp\ZttpResponse
     */
    public function send($method, $url, array $options)
    {
        $options = $this->mergeOptions([
            'query' => $this->parseQueryParams($url),
        ], $options);

        return new ZttpResponse(
            ($this->client ?? new Client)->request($method, $url, $options)
        );
    }

    //...
}

Removing unused method: https://github.com/kitetail/zttp/blob/master/src/Zttp.php#L175-L178
Setting up Travis-CI ?

cc: @adamwathan

Note: If you have any suggestions or changes to make, let me know 👍

Best regards

Ah man I'm so sorry because you obviously put a lot of work into this, but almost every change you've made was done the other way intentionally, just to have some fun intentionally contradicting the usual best practices 😄
I like isOk alias though, would accept a PR for that on it's own!

Okey, i didn't noticed that 😄
You should add this notice in the CONTRIBUTING.md file, otherwise, coders gonna code 😆
I gonna create another PR for isOk method.
Can i remove this ?

Haha yeah, I'll add a note, good idea 😊
I have __call implemented so you can still access any Guzzle response
methods easily if necessary; so if anything I think I'd rather just add a
test to document that behaviour. Feel free to do that if you like but
create a separate PR from the isOk one 👍🏻 Thanks!
On Fri, May 26, 2017 at 5:11 PM ARCANEDEV<EMAIL_ADDRESS>wrote:

Okey, i didn't noticed that 😄
You should add this notice in the CONTRIBUTING.md file, otherwise, coders
gonna code 😆
I gonna create another PR for isOk method.
Can i remove this
https://github.com/kitetail/zttp/blob/master/src/Zttp.php#L175-L178 ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/kitetail/zttp/pull/7#issuecomment-304388942, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEH3bNMctxG5pBNGSn0K8Wd-osWjmZc-ks5r9z_FgaJpZM4Nn-jB
.


Cannot install via brew due to SHA mismatch

Describe the bug
Cannot install via brew due to SHA mismatch
Steps to reproduce the behavior

brew install --cask kui

➜ brew install --cask kui
==> Downloading https://github.com/IBM/kui/releases/download/v10.3.6/Kui-darwin-x64.tar.bz2
==> Downloading from https://github-releases.githubusercontent.com/159242360/26e20300-c12c-11eb-91b7-28b9002746e7?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20210601%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20210601T135240Z&X-Amz-Expires=300&X-Amz-Signature=ff
######################################################################################################################################################################################################################################################### 100.0%
Error: SHA256 mismatch
Expected: d6a5b9b4095b820ca81b0f20f24959d408f9b2fc06b8f9c37590be1cdd279198
  Actual: 3cf051dcfec0591f3f858619afaa5914a8b18d909641c6052e878197f23d3d4e

This also is evident with the directly downloaded file -
➜ shasum -a 256 Kui-darwin-x64.tar.bz2
3cf051dcfec0591f3f858619afaa5914a8b18d909641c6052e878197f23d3d4e  Kui-darwin-x64.tar.bz2

This update shows the changed SHA which does not match the directly downloaded file or the brew downloaded file - https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/kui.rb
System

Kui version: 10.3.6
Operating system: macOS 11.4

Same issue here.

Thanks for the bug report! The homebrew install was set up by the someone in the community. We'll have to look into how we can keep these in sync. 🤔

Sure thing, the "easy" fix for now would be to update the SHA defined in the cask to the correct one, that will at least get things installing, then figure out how the other person got a diff SHA, not to mention how it wasn't checked against another validation of the SHA to find the mis-match.

This is fixed in the most recent release.


Various Bee issues

Porcine can't be mutated, Extreme Hills is now Cold Temp; both the bees needed to breed it, require normal temp and no tolerance.
Big Bad HAS to be bred during a Full Moon, description says other wise
Smouldering can't be worked with, Requires Hellish Temp, and Normal Humidity. Nether is the only 	place that has Hellish Temp, but it has Arid Humitity
Magic Bees 3.1.0

Point 2 and 3 have been fixed in a previous commit. (I know im a year late, I apologise)
Point 1 is fair, as there are only 2 biomes that are normal temp and classify as mountains (mutated roofed forest and mutated birch forest). I will add "hills" to the valid biomes list


Enable gocritc whyNoLint linter, fix errors

Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

/approve
/cc @tpantelis @Jaanki
@dfarrell07 this needs to be rebased


generic type mysqli_result error with phpstan v1.10.36 and v1.10.37

Trying to update phpstan to v1.10.37 results in an error.
--------------------------------------------------------------------------------
  vendor/staabm/phpstan-dba/config/Mysqli.stub:29
 --------------------------------------------------------------------------------
 PHPDoc tag @param for parameter $result contains generic type mysqli_result<mixed> but class mysqli_result is not generic.
 --------------------------------------------------------------------------------

It doesn't help to ignore the error or exclude the path.
Up to phpstan  v1.10.35 it works without this error message. Maybe it is related to this pull request — [mysqli] Add stubs for mysqli and mysqli_result classes phpstan/phpstan-src#2295.

thanks for reporting. I have also seen this error and it seems phpstan-dba is not compatible with the latest phpstan releases because of this stubs error.
I will work on a fix when time allows, as my own projects are also hit by this problem.

in https://github.com/staabm/phpstan-dba/releases/tag/0.2.79 I have pushed a new release containing a bugfix for that particular problem to make phpstan-dba work for everyone not using mysqli_fetch_object .
in the next step I will have a look to get all features back, but at least the more ciritical stuff should work again


[Monitor] Improve typing in Ingestion and Query

Verifytypes checks are now 100% for both.

API change check
API changes are not detected in this pull request.


Kirix Strata Browser not detected

Kirix Strata is a specialty web browser designed for data analytics.
Link: https://www.kirix.com/
Regex:
/(Strata)(\/)(\d+[\.\d]+)/

Example UA:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:<IP_ADDRESS>) Gecko Strata/<IP_ADDRESS>2

Can't get this to work!
Says unknown browser and under gecko

Closing this as it's a dead browser.


'late' word

Hello, Flutter team, I don't know if you already see this bug, but it is very important to fix this issue.

Dart 2.3.0
Flutter 1.5.4-hotfix.2
I can't use 'late' word as variable name or method name.
For example

class A {
    int get late => 0;
}

I've already created ticket https://github.com/dart-lang/sdk/issues/37067 but as I understand now this bug is only on your side

Also adding https://github.com/dart-lang/sdk/issues/36691 for reference purposes.
This is fixed in the latest builds of Flutter, which contain an updated version of Dart.
@Davarg, you can either switch to the dev Flutter channel until this fix makes its way to the stable channel, or use a different name for your field in the meantime.
Hope this helps! Tim


Build error with Emscripten latest-upstream (LLVM 9): WebAssembly hasn't implemented computed gotos

Godot version:
3.2 master (266dc732)
OS/device including version:
Mageia 7 x86_64
Emscripten 1.38.30, using LLVM 9 upstream backend (latest-upstream)
Issue description:
Trying the latest-upstream branch of Emscripten which is about to become the new default backend. Doing a release build.
I run into a backend error:
modules/gdscript/gdscript_function.cpp:262:27: error: WebAssembly hasn't implemented computed gotos
Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_args, int p_argcount, Variant::CallError &r_err, CallState *p_state) {
                          ^
modules/gdscript/gdscript_function.cpp:262:27: error: WebAssembly hasn't implemented computed gotos
fatal error: error in backend: Cannot select: t11: ch = brind t0, t10
  t10: i32,ch = load<(load 4 from %ir.indirect.goto.dest.in, !tbaa !58)> t0, t12, undef:i32
    t12: i32 = add t8, t14
      t8: i32 = shl t5, Constant:i32<2>
        t5: i32,ch = load<(load 4 from %ir..pn.in, !tbaa !45)> t0, t2, undef:i32
          t2: i32,ch = CopyFromReg t0, Register:i32 %1446
            t1: i32 = Register %1446
          t4: i32 = undef
        t7: i32 = Constant<2>
      t14: i32 = WebAssemblyISD::Wrapper TargetGlobalAddress:i32<[40 x i8*]* @_ZZN16GDScriptFunction4callEP16GDScriptInstancePPK7VariantiRNS2_9CallErrorEPNS_9CallStateEE16switch_table_ops> 0
        t13: i32 = TargetGlobalAddress<[40 x i8*]* @_ZZN16GDScriptFunction4callEP16GDScriptInstancePPK7VariantiRNS2_9CallErrorEPNS_9CallStateEE16switch_table_ops> 0
    t4: i32 = undef
In function: _ZN16GDScriptFunction4callEP16GDScriptInstancePPK7VariantiRNS2_9CallErrorEPNS_9CallStateE
clang-9: error: clang frontend command failed with exit code 70 (use -v to see invocation)
clang version 9.0.0 (/b/s/w/ir/cache/git/chromium.googlesource.com-external-github.com-llvm-llvm--project 039af0ea03f987654a162b6160399a00fd22b1b0)
Target: wasm32-unknown-emscripten
Thread model: posix
InstalledDir: /home/akien/Projects/godot/emscripten/emsdk/upstream/bin
clang-9: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
clang-9: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-9: note: diagnostic msg: /tmp/gdscript_function-d03862.cpp
clang-9: note: diagnostic msg: /tmp/gdscript_function-d03862.sh
clang-9: note: diagnostic msg:

********************
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting

Here are the two diagnostic files referenced above, with .txt extension appended because GH doesn't like .cpp or .sh:

gdscript_function-d03862.cpp.txt
gdscript_function-d03862.sh.txt

Steps to reproduce:

./emsdk install latest-upstream
./emsdk activate latest-upstream
source emsdk_env.sh
scons p=javascript target=release

I got confirmation that it's an issue with the LLVM backend: https://twitter.com/kripken/status/1146119782644629504
I will report it on https://bugs.llvm.org/ as soon as I get a user account (can't register directly).
In the meantime, we should likely investigate if we really need those computed gotos, as judging by the above answer their performance on WebAssembly might be subpar, so maybe an alternative implementation could be used for that platform.

I got it to build by removing the gotos (+ a couple other fixes, will make another issue for those) with this patch:
diff --git a/core/variant_call.cpp b/core/variant_call.cpp
index 811008e7c..c389f713b 100644
--- a/core/variant_call.cpp
+++ b/core/variant_call.cpp
@@ -164,8 +164,11 @@ struct _VariantCall {
 			funcdata.arg_names.push_back(p_argtype1.name);
 #endif

-		} else
-			goto end;
+		} else {
+			funcdata.arg_count = funcdata.arg_types.size();
+			type_funcs[p_type].functions[p_name] = funcdata;
+			return;
+		}

 		if (p_argtype2.name) {
 			funcdata.arg_types.push_back(p_argtype2.type);
@@ -173,8 +176,11 @@ struct _VariantCall {
 			funcdata.arg_names.push_back(p_argtype2.name);
 #endif

-		} else
-			goto end;
+		} else {
+			funcdata.arg_count = funcdata.arg_types.size();
+			type_funcs[p_type].functions[p_name] = funcdata;
+			return;
+		}

 		if (p_argtype3.name) {
 			funcdata.arg_types.push_back(p_argtype3.type);
@@ -182,29 +188,33 @@ struct _VariantCall {
 			funcdata.arg_names.push_back(p_argtype3.name);
 #endif

-		} else
-			goto end;
+		} else {
+			funcdata.arg_count = funcdata.arg_types.size();
+			type_funcs[p_type].functions[p_name] = funcdata;
+			return;
+		}

 		if (p_argtype4.name) {
 			funcdata.arg_types.push_back(p_argtype4.type);
 #ifdef DEBUG_ENABLED
 			funcdata.arg_names.push_back(p_argtype4.name);
 #endif
-		} else
-			goto end;
+		} else {
+			funcdata.arg_count = funcdata.arg_types.size();
+			type_funcs[p_type].functions[p_name] = funcdata;
+			return;
+		}

 		if (p_argtype5.name) {
 			funcdata.arg_types.push_back(p_argtype5.type);
 #ifdef DEBUG_ENABLED
 			funcdata.arg_names.push_back(p_argtype5.name);
 #endif
-		} else
-			goto end;
-
-	end:
-
-		funcdata.arg_count = funcdata.arg_types.size();
-		type_funcs[p_type].functions[p_name] = funcdata;
+		} else {
+			funcdata.arg_count = funcdata.arg_types.size();
+			type_funcs[p_type].functions[p_name] = funcdata;
+			return;
+		}
 	}

 #define VCALL_LOCALMEM0(m_type, m_method) \
@@ -982,33 +992,37 @@ struct _VariantCall {
 		cd.func = p_func;
 		cd.arg_count = 0;

-		if (p_name1 == "")
-			goto end;
+		if (p_name1 == "") {
+			construct_funcs[p_type].constructors.push_back(cd);
+			return;
+		}
 		cd.arg_count++;
 		cd.arg_names.push_back(p_name1);
 		cd.arg_types.push_back(p_type1);

-		if (p_name2 == "")
-			goto end;
+		if (p_name2 == "") {
+			construct_funcs[p_type].constructors.push_back(cd);
+			return;
+		}
 		cd.arg_count++;
 		cd.arg_names.push_back(p_name2);
 		cd.arg_types.push_back(p_type2);

-		if (p_name3 == "")
-			goto end;
+		if (p_name3 == "") {
+			construct_funcs[p_type].constructors.push_back(cd);
+			return;
+		}
 		cd.arg_count++;
 		cd.arg_names.push_back(p_name3);
 		cd.arg_types.push_back(p_type3);

-		if (p_name4 == "")
-			goto end;
+		if (p_name4 == "") {
+			construct_funcs[p_type].constructors.push_back(cd);
+			return;
+		}
 		cd.arg_count++;
 		cd.arg_names.push_back(p_name4);
 		cd.arg_types.push_back(p_type4);
-
-	end:
-
-		construct_funcs[p_type].constructors.push_back(cd);
 	}

 	struct ConstantData {
diff --git a/core/variant_op.cpp b/core/variant_op.cpp
index d677c7776..db9747719 100644
--- a/core/variant_op.cpp
+++ b/core/variant_op.cpp
@@ -66,7 +66,7 @@
 	CASE_TYPE(PREFIX, OP, POOL_VECTOR3_ARRAY) \
 	CASE_TYPE(PREFIX, OP, POOL_COLOR_ARRAY)

-#ifdef __GNUC__
+#if defined(__GNUC__) && !defined(JAVASCRIPT_ENABLED)
 #define TYPE(PREFIX, OP, TYPE) &&PREFIX##_##OP##_##TYPE

 /* clang-format off */
diff --git a/modules/gdscript/gdscript_function.cpp b/modules/gdscript/gdscript_function.cpp
index d5e74c07c..9a06abe5a 100644
--- a/modules/gdscript/gdscript_function.cpp
+++ b/modules/gdscript/gdscript_function.cpp
@@ -191,7 +191,7 @@ String GDScriptFunction::_get_call_error(const Variant::CallError &p_err, const
 	return err_text;
 }

-#if defined(__GNUC__)
+#if defined(__GNUC__) && !defined(JAVASCRIPT_ENABLED)
 #define OPCODES_TABLE                         \
 	static const void *switch_table_ops[] = { \
 		&&OPCODE_OPERATOR,                    \

The gotos in core/variant_call.cpp are to reduce some trivial code duplication, so we can probably live without them.
The ones in core/variant_op.cpp and modules/gdscript/gdscript_function.cpp are a bit more complex in some convoluted macro magic, but this was kept specific to __GNUC__ (GCC and Clang), so we can disable this code for WebAssembly and thus use the simplified codepath shared with MSVC. It adds some warnings that would have to be fixed though:
core/variant_op.cpp:398:29: warning: enumeration value 'VARIANT_MAX' not handled in switch [-Wswitch]
                SWITCH_OP(math, OP_EQUAL, p_a.type) {
                                          ^
core/variant_op.cpp:485:33: warning: enumeration value 'VARIANT_MAX' not handled in switch [-Wswitch]
                SWITCH_OP(math, OP_NOT_EQUAL, p_a.type) {
                                              ^
... and so on.

I filed a bug report upstream: https://bugs.llvm.org/show_bug.cgi?id=42498

The upstream bug llvm#42498 is fixed in their master branch, and the fix is included in the latest Emscripten latest-upstream, which properly fixes this issue.


UTF-8 compatibility

It doesn't respect UTF-8 encoded text.

Well, that's certainly a problem! Could you give me an example of an offending source file and paste in the result of attempting to run a command on the terminal?

Attache the text file containing Chinese characters.
defaultWelcome.txt
After updates, the characters appear in the api.ai's console as the following
å¨
ä½ å¥½
Hello

By the way, I noticed that the original example response text (which is given by api.ai) is also corrupted as:
ÃÂÃÂÃÂÃÂ¥ÃÂÃÂÃÂÃÂÃÂÃÂÃÂÃÂ¿ÃÂÃÂÃÂÃÂ¯ÃÂÃÂÃÂÃÂ¼ÃÂÃÂÃÂÃÂ
I don't know if it's caused by api.ai's ruby SDK yet.

Thanks so much for providing the additional info! We'll try to run this down as soon as we can.


Asset store installation error

After trying to enable addon i get this :
Unable to load addon script from path: 'res://addons/mqtt/mqtt.gd' Base type is not EditorPlugin.

to be expected, mqtt.gd is a Node and @goatchurchprime listed it incorrectly in the metadata as the EditorPlugin.


Write unittest for webscraper CSVs

Write python script to check webscraper output is in standard CSV format as described in CONTRIBUTING.md. Should go into the "test" folder.
Things to test

[ ] column header names are in same order & identical as on the specification
[ ] commas within fields are escaped appropriately as described on the specification, and number of columns in each row matches total # column headers
[ ] all characters in CSV are characters we can type on keyboard. This is partial check for encoding errors.
[ ] test each field to make sure the standard (or semi-standard) format is obeyed and we can parse it as expected. Examples: inmate_age is an int, url is a valid url, no semicolons except in fields that are allowed to have multiple entries (which indicates semicolons weren't converted to colons), charges/severity/current_status have same number of semicolons (unless field is blank)

[ ] county_name
[ ] timestamp
[ ] url
[ ] inmate_id
[ ] inmate_lastname
[ ] inmate_firstname
[ ] inmate_middlename
[ ] inmate_sex
[ ] inmate_race
[ ] inmate_age
[ ] inmate_dob
[ ] inmate_address
[ ] booking_timestamp
[ ] release_timestamp
[ ] processing_numbers
[ ] agency
[ ] facility
[ ] charges
[ ] severity
[ ] bond_amount
[ ] current_status
[ ] court_dates
[ ] days_jailed
[ ] other
[ ] notes

Working on this. If you want to do some of this, let me know so we can split the work.

Added a unittest template here: https://github.com/lahoffm/aclu-bail-reform/tree/master/test
Added example data files here: https://github.com/lahoffm/aclu-bail-reform/blob/master/data/example_data_2017_11_01.zip
To finish one of the checkmarks please fill out the corresponding test function in csv_format_tester.py.

Please submit pull request once you have completed a checkmark or two, so it's not sitting around for a few days and someone else does that checkmark.

[ ] Whenever the test fails, it should report the row & column & value of the cell in the CSV file where it failed (where applicable). That will save time for people reading the log to track down the bug.

[ ] Add ability to run tests on multiple CSV files, like loop through all files in a folder & put all output into one log file. The initial template just runs on a single file.


fix: Change vim.g.transparency check to vim.g.transparent

Also test for boolean values of backwards compatible configs on top of
the already tested integer values.

@yochem here is the fix. Closes #71

maybe add it to the the disable_nvimtree_bg option too? so it checks for both true and 1.

Ok, it wasn't there in the first place (the check for equality with the literal 1), that's why I didn't bother, but I get the sense of completeness in adding it there too.


Disable COM object eager clean up

If we called Thread.CurrentThread.DisableComObjectEagerCleanup() maybe it prevents GC'ing objects that we still need.

OK we won't do it because this would create a lot of garbage, so whenever you need a COM object and want to keep it alive, store a reference to it


Throw exception if users try to decorate filters on handler methods

I learnt the hard way that filters (in my case a PageFilter) are honored only if they are decorated on the page model and not on handler methods, like in MVC.
The documentation on IPageFilter is also not super clear: A filter that surrounds execution of a page handler method.

Could PageApplicationModelProvider throw an exception to indicate that filters on handler methods are not supported?
We could write an analyzer too

Could PageApplicationModelProvider throw an exception to indicate that filters on handler methods are not supported?

We generally don't write code to verify users aren't doing things that we don't support. An analyzer does seem like something we could cook up.

The documentation on IPageFilter is also not super clear: A filter that surrounds execution of a page handler method.

Sounds like an easy fix. @Rick-Anderson also recently wrote a doc article about using these filters here - https://docs.microsoft.com/en-us/aspnet/core/mvc/razor-pages/filter?view=aspnetcore-2.1. We could certainly call that out in the docs (it doesn't right now).

You can close this now, I merged https://github.com/aspnet/Docs/pull/6010

I would keep this open. If not an analyzer, we should update the docs on the api to say so. Found the docs needs to be fixed anyway (removing before the action method is invoked)
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.RazorPages/Filters/IPageFilter.cs#L24

@kichalla, let's update the code comment as it's tiny no code change.

https://github.com/aspnet/Mvc/commit/b56436b5c607e08ada5fccabfc71c475f8fbbbea


Success definition

Hi!

How do you define a "success" in an environment? Does the success metric have to be true for a single time step (i.e. at least once env_infos["success"] > 0) or be true at the end of the episode (after 150 steps in most environments) or something different?

How do you define the "success rate"? As something like "test_tasks_with_success / all_test_tasks"?

Sorry if this is mentioned somewhere, but could not find a clear definition in code or paper.
Thanks!

success is a property of an episode. An episode is successful iff at least time one step in the episode satisfied env_info['success'] == True.
The success signal provided in env_infos doesn't latch-up like this -- it is computed per-step.
See https://github.com/rlworkgroup/garage/blob/master/src/garage/_functions.py#L143 for sample evaluation code


[Bug] DB Entity update process

What happened?
After I added the new property to User entity named balance I expected it to go live with next boot up of the bot.
    @Property()
    balance: number = 100

On other hand it gave me the error first saying that column is not present, after investigation got an adivse to make migration for DB
npm run migration:create && nom run migration:up"

Which brough up an error:
alter table `user` add column `balance` integer not null; - SQLITE_ERROR: Cannot add a NOT NULL column with default value NULL

then we found that this can be fixed by changing the way it described in User Entiry
    @Property({ default: 100 })
    balance: number

Which is works nice.
Would be good to iclude this in the Documentation for visibility
Reproduction
add new property
    @Property()
    balance: number = 100

and try to migrate with sqlite as your database
Relevant log output
alter table `user` add column `balance` integer not null; - SQLITE_ERROR: Cannot add a NOT NULL column with default value NULL

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You probably wont need to create new entities by yourself. The discordx implement an EAV design pattern that allows you to store key/(strongly typed)value pairs without having to create entities, so it would be better to use the native EAV pattern provided by the discordx team for this purpose instead of creating your own entities, since it is more suitable for discord usage!
I would not recommend going through the headache of creating your own own entities in the database and defining their relationships. Headache solved with the provided EAV pattern! 👍


GraphDB Proposal - Open for discussion.

Classification

[X] Question
[X] Feature/Enhancement

Description
What do you think of switching to a graph database?
I have used (for some time) a very good Graph database, called "Dgraph". It is a mixture of noSQL and NewSQL with a language equal to GraphQL.
This is to eliminate the use of Mariadb and Redis. For the Dgraph is the best of these two worlds. It was thought to be a Realtime Database.
We would just need to map the relationships of your application today and then I can build an approach.
Let me know what you think.

Neither postfix nor dovecot nor rspamd seems compatible with this kind of database.

Cockroach, probably works well because it supports the pgsql protocol.
Dgraph used protocols (Grpc / HTTP + JSON / RDF)...

True, I was silly for not thinking about these software. Would have to change them. Which generates round trips with others.
@denji I have no experience with CockroachDB.
In that case, It would have to create a "Bridge" between the Graph DB and the software as the "Prisma" does. Dgraph intends to add Gremlin and Cypher. What could be an option for "bridge".
Either way it would be better if the software had support from the top down.


[Error] Downloading stash for Standard

[03-01-2016 12:47] Error downloading stash for Standard, exception details: System.Exception: Downloading stash, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues
в POEApi.Model.POEModel.logNullStash(Stream stream, String errorPrefix)
в POEApi.Model.POEModel.GetStash(Int32 index, String league, Boolean forceRefresh)
в POEApi.Model.POEModel.GetStash(String league, String accountName)
[03-01-2016 12:47] System.Exception: Downloading stash for Standard, details logged to DebugInfo.log, please open a ticket at https://github.com/Stickymaddness/Procurement/issues
в POEApi.Model.POEModel.GetStash(String league, String accountName)
в Procurement.ViewModel.LoginWindowViewModel.LoadStashItems(Character character)
в Procurement.ViewModel.LoginWindowViewModel.d__6.MoveNext()
в System.Collections.Generic.List1..ctor(IEnumerable1 collection)
в System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
в Procurement.ViewModel.LoginWindowViewModel.<>c__DisplayClass2.b__1()
в System.Threading.Tasks.Task.Execute()

As there are a high number of duplicate reports for this issue, please see the consolidated issue I have created for this here:
https://github.com/Stickymaddness/Procurement/issues/397
Please follow this issue for updates and ask any questions there.


nixos/nat: optional networking.nat.externalInterface

Motivation for this change
small fix for https://github.com/NixOS/nixpkgs/pull/41758 to prevent "cannot coerce null to string" raise before the assertions are checked

@GrahamcOfBorg test nat.firewall nat.standalone

Success on x86_64-linux (full log)
Attempted: tests.nat.firewall, tests.nat.standalone
Partial log (click to expand)
cleaning up
killing client (pid 594)
killing server (pid 618)
killing router (pid 606)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde2.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ch5f9dgngxalm5dh59lmpb3mcl893dqs-vm-test-run-natWithFirewall
/nix/store/vw6nx1vacca27jlph3fvwmwq8abkfv9x-vm-test-run-natStandalone

Success on aarch64-linux (full log)
Attempted: tests.nat.firewall, tests.nat.standalone
Partial log (click to expand)
cleaning up
killing router (pid 641)
killing server (pid 654)
killing client (pid 628)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not emptyCould not remove ctl dir '/build/vde2.ctl': Directory not empty

/nix/store/as8xxr8a0q919lhkd74l3x8dvdmr4s3g-vm-test-run-natWithFirewall
/nix/store/ishm7aikq3npj2za8yvrf4zhj0q6d2f8-vm-test-run-natStandalone


chore: move the required playwright to requirements.txt

The main process depends on playwright.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e7b5d3c) 83.77% compared to head (3b4379d) 82.88%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   83.77%   82.88%   -0.90%
==========================================
  Files         225      225
  Lines       12441    12441
==========================================
- Hits        10423    10312     -111
- Misses       2018     2129     +111

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM


Hashes are not being produced for private packages when exporting a requirements file.

Hi,
no hash is being created in the requirements.txt file when I run poetry export -f requirements.txt. This means pip fails when it reads the file. It's fine, pip actually gives me the hash to insert into the file, however it would be great if Poetry did it in the first place.
Also, what might be good is to have something like a --no-hashes argument for exporting, so that no hashes are added to the requirements file. My understanding is that if pip can't find any hashes at all, it won't complain about missing ones.

Not sure this wanted transferring - isn't the conclusion of the above thread that

poetry should be generating sha256 hashes for packages that don't have a sha256 hash pre-generated for them by the repo. It shouldn't ever pass through a md5 hash.

ie the export plugin will just export whatever's in the lock file, poetry proper ought to have made sure that there's a sha256 hash in that lock file

Having said which it's also true that the exporter has https://github.com/python-poetry/poetry-plugin-export/blob/dd3b674d21079af615979eda241385f550e3f4ae/src/poetry_plugin_export/exporter.py#L30 so if the intention is to put md5 hashes in the lockfile then that will need updating for the plugin to export them.

but that last bit duplicates #20


write: no buffer space available

Question
I am using vegeta to load test my response server.
I put huge data into the vegeta's Target body (for example, a string of size 10 mib).
As a result [a write: no buffer space available] error appears.
I think, if I set vegeta's writeBuffer, I can fix the problem.
Is it possible to solve it this way? Or is there any other way?
targeter := vegeta.NewStaticTargeter(vegeta.Target{
                 Method: "POST",
		URL:    url,
		Body:   'there is huge data',
	})

Sorry, this isn't enough context for me to help.


Execs is not extensible. Could it be?

Feature request:
The trait Execs is sadly not extensible because of the locked-down visibility on the newInstance def (it is private[core]). It would be great to open that up so that custom extensions could be added to the Gatling DSL by extending StructureBuilder.
My use case is such that I would like to add domain-specific extensions without having to be so wordy (e.g. having to wrap everything in .exec(...)).
Thanks for considering!

Generally speaking, Gatling is a software, not a library or a framework.
Everything but the DSL is internal and subject to change, hence we prefer keeping those private.
You could achieve what you're trying to do with some implicit conversions.


Rewrite notify_send test

Problem: no asserts, or anything that could really make the test fail.

This issue is not important.


[bug] electron16 + angular13 use ipcRenderer, get error

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
no
Description
electron16 + angular13 use ipcRenderer, get error

I search other issue, answer is change webpack config, but angular builder is not webpack

builder is angular-devkit/build-angular:browser
I must use ipcRenderer, like
import { ipcRenderer } from 'electron';
but ng build is error
please help to resolve it
🔬 Minimal Reproduction

🔥 Exception or Error

./node_modules/electron/index.js:1:11-24 - Error: Module not found: Error: Can't resolve 'fs' in 'D:\gitproject\das\das\node_modules\electron'

./node_modules/electron/index.js:3:13-28 - Error: Module not found: Error: Can't resolve 'path' in 'D:\gitproject\das\das\node_modules\electron'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

🌍 Your Environment

Angular CLI: 13.0.4
Node: 16.13.1
Package Manager: npm 8.1.2
OS: win32 x64

Angular: 13.0.3
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1300.4
@angular-devkit/build-angular   13.0.4
@angular-devkit/core            13.0.4
@angular-devkit/schematics      13.0.4
@angular/cli                    13.0.4
@schematics/angular             13.0.4
rxjs                            7.4.0
typescript                      4.4.4

Anything else relevant?

Duplicate of #20821


Feature Request: expose GL, Scene, Camera, etc

For doing things like GLSL reflections / refraction etc. as materials I'm setting up a CubeCamera, which needs access to the Scene, and GL Renderer, currently I have some wild hack to pull them out of the canvas, but there's gotta be an easier way to get to these.
something like a store or context similar to ReactThreeFiber's useThree hook?
If anyone knows an easier method I'm ALL ears.
let canvas, gl, scene;
onMount(() => {
        const mapIter = canvas.$$.context.values();
	mapIter.next()
	const ctx = mapIter.next().value;
	gl = ctx.renderer;
	scene = ctx.scene;
})

<Canvas bind:this={canvas} ...

I agree with this request.  Svelte Cubed is great!  But, it's a work in progress and so developers need access to the core objects in some way to utilize more of the Three.js framework


Cannot save config when deploy using docker stack with multiple node app

The problem
The problem occured when deploying with docker stack multiple node. When I try to save the configuration it return validation error on the top of the page saying "The settings have been modified by someone else. Please reload the form and resubmit your changes."
maybe it appeared because POST data transfered to other node than the requested node. is it possible to disable the validation? So I would not make any specific configuration on routing URL on my traefik configuration
Steps to reproduce
You have to prepare the whole django project running on docker swarm mode with multiple node
System configuration

Django version: 2.1.10
Python version: 3.5

Sorry if you can't understand because of my bad english. Thanks

This may help: https://django-constance.readthedocs.io/en/latest/index.html

django-constance’s hashes generated in different instances of the same application may differ, preventing data from being saved.
Use this option in order to skip hash verification.
CONSTANCE_IGNORE_ADMIN_VERSION_CHECK = True


NOT FOR MERGE. Provide feedback in cases where code is not edited; provide 'correctness feedback' if we run out of more specific feedback.

This supersedes #447.

This PR is now obsolete. Closing.


x/tools/gopls: no folding ranges for invalid code

Not sure why this has happened however out of the blue Visual Studio Code is now unfolding all code every time the file is saved. I have tried uninstalling/reinstalling and removing extensions though nothing has worked.
All code is unfolded every single time the file is saved and results in a lot of lost time. I reported the issue in the Visual Studio Issue for Bugs and was told that the issue is with the Go Extension itself. Basically it appears that the Go Extension for VSCode is causing the code to unfold every time the code is saved. See what was said in the VSCode issues report below

I can reproduce.
From debugging I see that the go extension now also registers a folding range provider.
However that provider doesn't work well with incomplete code. It then returns no folding ranges, what results in all folded ranges to go way.
E.g. no ranges returned for that code:
package main
w
import (
"fmt"
"io"
"net/http"
"github.com/microsoft/vscode-remote-try-go/hello"
)
func handle(w http.ResponseWriter, r *http.Request) {
io.WriteString(w, hello.Hello())
}
Can you file the issue against the go extension? https://github.com/golang/vscode-go
Thanks a lot!

Please direct general questions to:

#vscode channel in Gophers Slack

Please review the documentation before filing an issue.
Helpful pages include:

GOPATH
Module Support
Debugging

Set "trace": "log" and share the resulting logs in the debug console when logging an issue.

Please answer these questions before submitting your issue. Thanks!
What version of Go, VS Code & VS Code Go extension are you using?

Run go version to get version of Go
go version go1.15.1 windows/amd64
Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
1.48.2
a0479759d6e9ea56afa657e454193f72aef85bd0
x64
Check your installed extensions to get the version of the VS Code Go extension
Go 0.16.2
Run go env to get the go development environment details
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\nicholasimon\AppData\Local\go-build
set GOENV=C:\Users\nicholasimon\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\nicholasimon\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\nicholasimon\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\NICHOL~1\AppData\Local\Temp\go-build025678214=/tmp/go-build -gno-record-gcc-switches

Share the Go related settings you have added/edited
Run Preferences: Open Settings (JSON) command to open your settings.json file.
None
Describe the bug
Not sure why this has happened however out of the blue Visual Studio Code is now unfolding all code every time the file is saved. I have tried uninstalling/reinstalling and removing extensions though nothing has worked.
All code is unfolded every single time the file is saved and results in a lot of lost time. I reported the issue in the Visual Studio Issue for Bugs and was told that the issue is with the Go Extensions itself. Basically it appears that the Go Extension for VSCode is causing the code to unfold every time the code is saved. See what was said in the VSCode issues report below
Steps to reproduce the behavior:
Save a folded file, all fold unfold

That doesn't make sense at all as I had never heard of gopls before you told me so it can't be because of gopls as I have never used or it installed it before. Anyway it is up to you is you want to close the issue. Once again thanks for the help.

@hyangah what's left to do here? Should we prioritize this? Thanks.

Just to let you know this is not resolved. Folding works fine in VS Code with Go extension up to a few thousand lines (not sure of the exact point) however at a certain point it no longer works.
I have worked out (since my original post) that this relates to SETTINGS > FORMAT ON SAVE > FILE (default). Something about having thousands of lines of Go then it breaks formatting of  the entire file when saving and it unfolds everything. Currently the workaround I use is to set FORMAT ON SAVE to MODIFICATIONS then it does not try and format the entire file. Then you can change it to FILE (default) occasionally and it will format the file correctly.

Thanks @nicholasimon -- I've put this back in our backlog.

I have the same problem. It does it both on save and any syntax error while typing.
Go extension version: v0.40.1
VSCode version: 1.85
macOS Venture
Before:

While typing: (I am yet typing, notice last line)