Fix spam-clicks from 1.9+ players on 1.8 servers

Spam-clicking will not lower our hands/items anymore. Also hides the attack indicator when attacking but it will still blink very quickly when you change the item in your hands.

This is a nice change but is the entire array rewriting necessary?
Is it required that the attribute is the top element of the list.
I tried to add it to the end without rewriting the entire array and it worked just fine.

Meanwhile, if some of you wants to test this pull request, I've built a jar with it.
It's based on the dev branch of ViaVersion (until this commit: Update to 17w45b, latest at the moment I'm typing this).
Keep in mind that Myles and Mats will most likely not support you if you have any bugs using this build.
ViaVersion-1.4.0-17w45b-PR#770.zip (Click on this link to download.)
(GitHub doesn't accept .jar files directly so I had to zip it, extract the zip file and put the jar file in your plugins folder.)

In regards to people with existing servers:

Could this have negative impacts on servers that set the attack speed?
Does this need to be sent for every entity?

Hi, I tested the version (Thanks @Logics4) and I confirmed of it is work.
1 - It will not adding impacts on servers
2 - I don't think so

because it's set as the first in the list, any modifications afterwards should apply, BUT; really this kinda change should be behind a configuration option just in case, imho

The most important part is that they're sent to the player itself, but by vanilla behavior they are sent to all players. This really has no effect on normal entities and would basically be ignored.

Closing this for now, why?

The structure of the code should be reworked to be clean (using data structures over Objects)
This should also be a config option


Allow Clients to be extended

org.pac4j.core.client.Clients is declared as final -- but why? In my application, I deploy the same WAR to different environments and apply environment-specific settings (such as URLs and connection strings) via an externally managed configuration file. For other classes that are part of our Shiro environment and which normally have such settings in shiro.ini, I simply extend the class and read and set the appropriate properties in the constructor. However, I'm unable to do this with Clients since, as noted, it's final.
Is there a good reason to make Clients final? If so, I'll just have to write some kind of property injector. If not, can we remove the final keyword from the class?

The idea of final is to provide guidance on users and avoid them to override things as it's easy, before sharing their problem and looking for a cleaner solution if it exists. Clients being a container of clients, I assumed there were no use cases where you need to inherit from it.
Nonetheless, we have a first use case with dynamic clients loading (from database) in a "in progress" pull request.
So we can go that way. Would you mind submitting a pull request for that? It will likely go in a 1.8.2 version.

@sbeitzel : I did the change via this PR: https://github.com/pac4j/pac4j/pull/404

Cool deal. Thank you!


Isn't there any Authentication by email yet?

Hi
I've already checked in email authentication firebase console.
firebase console -> Auth -> email template
you can see those three menus in there.(email authentication, change password, change email address)
But I couldn't see any api in android api document.(email authentication, change email address)
(I found sending change password api)

@jcsla are you looking for Email/Password authentication?
If so you can find the documentation here:
https://firebase.google.com/docs/auth/android/password-auth
And a sample app here:
https://github.com/firebase/quickstart-android/blob/master/auth/app/src/main/java/com/google/firebase/quickstart/auth/EmailPasswordActivity.java


Store headers with scraper

From our conversation, I will update this PR to also bypass S3 entirely.

Closing this in favor of #727.


⚠ sandbox-api.piste.gouv.fr healthcheck has degraded performance

In 95239a9, sandbox-api.piste.gouv.fr healthcheck (https://sandbox-api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 5958 ms

Resolved: sandbox-api.piste.gouv.fr healthcheck performance has improved in d9adb24.


Feature/githubactions

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you read and signed the automated Contributor's License Agreement?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[x] Does your submission pass tests?
[ ] Have you lint your code locally prior to submission?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

Closing the PR since coverall is not working on forked repo. Raising the PR from main repo.

Closing the PR since coverall is not working on forked repo. Raising the PR from main repo.


wip: walletprovider type narrowing

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5462

PR #5463

PR #5466

PR #5468   👈

This comment was auto-generated by Graphite.


New low severity daily detection for AAD StsRefresh modification

Adding this initial anomalous StsRefreshToken modification rule that may accompany and aid in triaging other suspicious AAD & OAuth detections
TODO: properly extract LastDirSyncTimeNew as dateTime and compare this value to now() to highlight extremely long refresh tokens to highlight extraordinarily long refresh token validation timeframes

Looks great, thanks for cleaning up the variable names for the mv-expand and for fixing the dateTime values.
I also added two helpful time deltas to allow users to more easily identify anomalies.
I tested current version in several environments. Should be good to ship. Thanks!

Hi,
I was checking the backlog regarding this rule, to understand it a bit more.
Could you specify which field (out of tokenMinutesRemaining and tokenMinutesAdded) should be considered important to look when hunting for malicious activity, and why ?
How can be tokenMinutesRemaining != 0 ?
Knowing that, according to Microsoft documentation "StsRefreshTokenValidFrom will appear to accept any date, but it will always set to the current date and time.". Which means that TimeGenerated == newStsRefreshValidFrom, so tokenMinutesRemaining = 0, right ?
Leaving tokenMinutesRemaining out, we can only look for anomalies in tokenMinutesAdded.
However, could you precise what would a high tokenMinutesAdded value indicate ? An app which renewed a very old Refresh Token ?
Thanks a lot in advance for your answer,
Regards
@shainw @itsreallynick

Hi,
I was checking the backlog regarding this rule, to understand it a bit more.
Could you specify which field (out of tokenMinutesRemaining and tokenMinutesAdded) should be considered important to look when hunting for malicious activity, and why ?
How can be tokenMinutesRemaining != 0 ?
Knowing that, according to Microsoft documentation "StsRefreshTokenValidFrom will appear to accept any date, but it will always set to the current date and time.". Which means that TimeGenerated == newStsRefreshValidFrom, so tokenMinutesRemaining = 0, right ?
Leaving tokenMinutesRemaining out, we can only look for anomalies in tokenMinutesAdded.
However, could you precise what would a high tokenMinutesAdded value indicate ? An app which renewed a very old Refresh Token ?
Thanks a lot in advance for your answer,
Regards
@shainw @itsreallynick


Solution file contains generate.fsx which does not exist

Description
The solution file contains a node ./docs/tools/generate.fsx. This file does not actually exist in the repository.
Repro steps

Download the template

Open the solution

Navigate to /docs/tools and double click generate.fsx

Expected behavior
File should exist. Or should be removed from the solution.
Actual behavior
File does not exist.

Oops, my stupidity. This is generated by init.fsx.
...goes off to self-flagellate.


[Proposal] Organize Storybook folder structure

This PR accompanies this Discussion (hubbers only) about Storybook/Lookbook structure. This is just a start, but with our prospects of single page component docs Storybook becomes even more critical for documentation. If Storybook is organized closer to our more "official" documentation, it may be easier to navigate and parse.
Screenshots
See the preview deploy 😄
Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

I love how navigating is much more intuitive now @langermank ! 😍 And thanks for doing it, there were quite a lot of files to edit!
The only thing is that the lockfileVersion test is failing. According to the tests, apparently it should be 2 but it changed to 1. Any chance you might be using npm v6?

@primer/react-reviewers crew: should I add a changeset for this? Not sure since its just docs/storybook related 😄 lmk!


feat(nx): Some files declare dependencies or tasks (Nx targets) of a project and should render the project affected if changed

Some files declare dependencies or tasks (Nx targets) of a project and should render the project affected if changed. Currently considered:
['package.json', 'nx.json', 'project.json']

Hey, thanks for this!
My approach in this project is less specific and more generic kind of approach, i try to auto-detect all changed files based on the repo instead of relying on nx config.
Also, the core project is meant to be generic and not related to nx or any other monorepo management tool
There's this pr that i need to merge,
It automatically detects changes to package-lock files and triggers affected. i think it will solve your need.

The problem is the build/test/lint... comamnds are defined in Nx nx.json project.json etc so if they are changed, the tasks definately need to be re-run (for example in CI).
Maybe we can add a option in the core to detect if certain files have canged and pass nxjson project.json to core from @traf/nx?

We have the includeFiles options in the nx cli https://github.com/lemonade-hq/traf/blob/684b4b27b2268715bc84cbb2fda6fca470062c6c/libs/nx/src/cli.ts#L46C53-L46C53

We have the includeFiles options in the nx cli https://github.com/lemonade-hq/traf/blob/684b4b27b2268715bc84cbb2fda6fca470062c6c/libs/nx/src/cli.ts#L46C53-L46C53

OK, I think this will work for us for now, thank you!


tensorflow-gpu failed init from systemd service

I have wrote an application with Java / C / Python who works well since a few weeks and executed in Bash by:
source ../frozen-graph-env/bin/activate && /usr/bin/java -jar test.jar --start
pip freeze of my environment:

absl-py==0.2.2
astor==0.6.2
bleach==1.5.0
gast==0.2.0
grpcio==1.12.1
html5lib==0.9999999
Markdown==2.6.11
numpy==1.14.5
pkg-resources==0.0.0
protobuf==3.6.0
six==1.11.0
tensorboard==1.6.0
tensorflow-gpu==1.6.0
termcolor==1.1.0
Werkzeug==0.14.1

The goal now is to execute the application with systemd:
ExecStart=/bin/bash -c "source ../frozen-graph-env/bin/activate && /usr/bin/java -jar test.jar --start"
The Java application start then exit because tensorflow-gpu failed to be imported. I have no log in systemd / syslog to show it (not the best way to open an issue, sorry) but if I replace tensorflow-gpu 1.6.0 by tensorflow 1.6.0, i.e. without GPU support, the application works well.
I'm importing tensorflow in my python script with:
import tensorflow as tf
Is it the same issue of tensorflow gpu failed init from systemd service - Stack Overflow?
Is there a specific way to use tensorflow-gpu with systemd? Is it an issue? How can I help to investigate?

System information

Have I written custom code: yes
OS Platform and Distribution: Linux Ubuntu 16.04
Bazel version: NA
CUDA/cuDNN version: NA
GPU model and memory: NA
Exact command to reproduce: NA
Mobile device: NA
TensorFlow installed from pip
TensorFlow version: v1.6.0-0-gd2e24b6039 1.6.0
TensorFlow GPU version: v1.6.0-0-gd2e24b6039 1.6.0

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!

Ok thanks, done on StackOverflow.


remove JSONP endpoint as it is not working in modern browsers

In Chrome, CORB (Cross-Origin Read Blocking) prevents to load JSONP response from identity url / revoke server

@stomita I still am unable to use the identity() method after your fix (I'm using v1.9.0).
Your fix causes an OPTIONS CORS pre-flight request to be sent (good) but it gets denied by SFDC because it does not have the Authorization header present on the request.
For example, with your fix, this pre-flight OPTIONS request is sent:
curl -v 'https://test.salesforce.com/id/00D1F000000DQEfUAO/0051F000001XFwIQAW' -X OPTIONS -H 'Access-Control-Request-Method: GET' -H 'Origin: https://me.rynop.dev:5500' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36' -H 'Access-Control-Request-Headers: authorization'

If you run this command in the terminal you will see SFDC servers return a 403 with a Missing_OAuth_Token response body
If you send the Authorization header on the request, it works from the terminal, HOWEVER it wont work in the browser, because the response does not have the correct Access-Control-Allow-Origin response header.
Ex:
curl -v 'https://test.salesforce.com/id/00D1F000000DQEfUAO/0051F000001XFwIQAW' -X OPTIONS -H 'Access-Control-Request-Method: GET' -H 'Origin: https://me.rynop.dev:5500' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36' -H 'Access-Control-Request-Headers: authorization' -H 'Authorization: Bearer MyOAuth2Token'

As you probably know, XHRs (and fetch for that matter) can't send Authorization headers in the pre-flight OPTIONS request.  SO - I really think this is a bug in SalesForce - however I'm a total SFDC noob, so want your opinion 1st.  Thoughts?
I've never opened a bug against SFDC - got any contacts internally?  This is a pretty big deal IMO because you can't get user info without a proxy (YUCK).  Even the (should-be) standardized OAuth2 endpoint doesn't allow CORS:
curl -v 'https://test.salesforce.com/services/oauth2/userinfo' -X OPTIONS -H 'Access-Control-Request-Method: GET' -H 'Origin: https://acmeloans.loanos.dev:5500' -H 'Referer: https://me.rynop.dev:5500/' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36' -H 'Access-Control-Request-Headers: authorization' --compressed

@rynop Essentially the SFDC should support the CORS for identity URLs, but as you mentioned currently not. For that reason we did change the transport to JSONP for identity method only, but the w/a is not working right now in Chrome and also will not be in other modern browsers.
We have following two options to send request to SFDC:

Support CORS for Identity URLs (Access-Control-Allow-Origin: *)
Return correct response header (application/javascript) with JSONP response to pass CORB check

The first option is the best way IMO but needs several steps (IdeaExchange vote or something). The second one seems easy because they already support JSONP interface, but not nowadays.
Considering the needs of JSforce in browser is mostly in Visualforce, the Ajax proxy service is always available in Salesforce. Using proxy when using identity call might be the practical solution.

@stomita thanks for the quick response.  Was afraid you'd say that (use proxy) :)
I'm super new to SFDC, but my guess is its like turning the titanic to get something fixed/implemented (this basic building block is 11 years old).
I've opened an idea on IdeaExchange but whats the most successful way to resolve an issue? Create a support case?  I'm going to DreamForce for the 1st time this year, is there avenues to raise issues there?
Totally un-related: any idea how to edit an ideaexchange idea that you posted? It formatted like crap (didnt honor my bulleted lists that shows up in the WYSIWYG editor).


Circuit Breaking does not take effect for grpc service

Describe the bug
I start a grpc server and client and set up a circuit breaker,the circuit breaker did not take effect.
Client sends one hundred requests per second.
Version
1.0.6
Installation
helm install
Cluster state
On kubernetes 1.11.0
client.yaml
apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: helloworld-client
  namespace: yqguo
spec:
  replicas: 3
  template:
    metadata:
      labels:
        app: helloworld-client
    spec:
      containers:
      - name: helloworld-client
        image: myrepo/library/helloworld-client
        env:
        - name: ADDRESS
          value: "hellworld-server:50051"

server.yaml
apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: helloworld-server
  namespace: yqguo
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: helloworld-server
    spec:
      containers:
      - name: helloworld-server
        image: myrepo/library/helloworld-server
        ports:
        - containerPort: 50051
---
kind: Service
apiVersion: v1
metadata:
  name: hellworld-server
  namespace: yqguo
spec:
  selector:
    app: helloworld-server
  ports:
    - protocol: TCP
      name: grpc
      port: 50051
      targetPort: 50051

destinationrule.yaml
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: helloworld-server
  namespace: yqguo
spec:
  host: hellworld-server
  trafficPolicy:
    connectionPool:
      tcp:
        maxConnections: 1
      http:
        http1MaxPendingRequests: 1
        maxRequestsPerConnection: 1
        http2MaxRequests: 1
    outlierDetection:
      consecutiveErrors: 1
      interval: 1s
      baseEjectionTime: 3m
      maxEjectionPercent: 100

What type of gRPC service is this? Unary? Streaming?
Can you provide a reproducible config we can use (with a public image) so we can try this out?
Also "Client sends one hundred requests per second." note the circuit breaker is not limiting requests per second, but concurrent requests.


Merge 3.15.0 to 3.16.0 Updates

For merging all of our changes post 3.15.0 until July 19th 2024 back to the main repo. This is to try to maintain some of the commit history for documenting changes over time.

Can you please confirm that we've already done all of this?

Out of Date; probably already merged.


dwmblocks 6.3 patch doesn't work

I have downloaded dwm version 6.3, and i have been trying to apply the dwmblocks patch for this version with no success. Looking at the diff file it seems like there are also all the differences between dwm version 6.2 and 6.3 (which I already have, since I have dwm 6.3), but i cannot understand which differences are the ones that are actually needed for dwmblocks to function, nor if some are missing (comparing this diff file with the 6.2 diff file I found different changes). Could you please help me?

I have added a patch for v6.3, apply that.


s/params/parameters/

Description
s/params/parameters/
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[x] Code is well-documented

Job PR-289/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-289/1/index.html

Job PR-289/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-289/2/index.html


Attempt to build with R 3.5.1

ggalt hasn't been built for R 3.5.1 yet. I assume one of its dependencies is blocking it, but attempting to build it will at least pinpoint the problem dependency.
https://anaconda.org/conda-forge/r-ggalt/files
cc:@rasmusagren
xref: #3

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


NoMethodError: undefined method `substitute' for #Account:0x00000100d00f88

Is FactoryGirl supposed to work with mongoid out of the box?! The basic methods are running fine, but when I try to make an association:
FactoryGirl.define do
  factory :user do
    sequence :uid do |n|
      "4711#{n}"
    end
    name  'test'
  end

  factory :account do
    user { |account| account.association(:user)}
  end

end

I get an error:

NoMethodError: undefined method `substitute' for #<Account:0x00000100d00f88>

adding an empty
def substitute(what)
end

appears to make factory-girl happy again. Is someone currently using factory-girl to factorize mongoid-models? Any more pitfalls?!
Cheers
Stefan

Stefan,
I used an older version (2.1 I believe) of Factory Girl on a pretty large project using Mongoid with great success. Here's an explanation of what Factory Girl does behind the scenes in terms of interacting with your models (although it says Active Record, it's more applicable to any class using some of the core pieces of ActiveModel, Mongoid included): https://github.com/thoughtbot/factory_girl/wiki/How-factory_girl-interacts-with-ActiveRecord
I'm not sure where substitute is getting called, but it wouldn't be from Factory Girl. As the wiki entry says, we call new, set each attribute individually, and then call save! (for FactoryGirl.create).
Can you include more of the backtrace for the NoMethodError? That should help narrow down where substitute is being called.

Hi Joshua,
that actually was a good tip: The error has nothing to do with factory-girl, and i should have taken the advice to heart, to look if I can instantiate the object via console before filing an issue. It actually has been a misconfiguration in the mongoid-mappings - sorry for bothering...
cheers
stefan

Hey, don't worry about it; glad you got everything straightened out!


Add support to indicate machine progress

Add support to indicate machine progress.  See https://github.com/rancherio/rancher/issues/156
Requires https://github.com/rancherio/cattle/pull/300 for this to work correctly.

Closing in favor of https://github.com/rancherio/go-machine-service/pull/19
which is the same PR, but with squashed commits.


Add support for documenting "traits" (issue #124).

Taking another stab at this :). The description of a trait is actually captured in the RAML itself, the tricky part was just making the top-level traits object visible within the recursive handlebars partial. This unfortunately required bumping the handlbars dependency to 2.0.x.
An example is provided in examples/traits.raml.

Apologies for all the noise related to the create/close/create/close/create of this pull request (I kept unintentionally polluting the branch with unrelated commits).  I'm done fussing with it now.


[PromptLab] Error in Summarize This YT video

Extension
https://www.raycast.com/HelloImSteven/promptlab
Description
Error:
Mt: request to https://youtube.comhttps//www.youtube.com/api/timedtext?v=lOO9wLBFJiU&caps=asr&opi=112496729&xoaf=5&hl=fr&ip=<IP_ADDRESS>&ipbits=0&expire=1690685552&sparams=ip,ipbits,expire,v,caps,opi,xoaf&signature=8D64525B6FF159FC7B1C7D787847CFDD9521F190.C74395B198C8984847190C3B319970B728626D13&key=yt8&kind=asr&lang=en failed, reason: getaddrinfo ENOTFOUND youtube.comhttps

ClientRequest.<anonymous>:index.js:108:10

---
105: 		}

### Steps To Reproduce

I just ran this command while watching a YouTube video.

### Current Behaviour

<img width="1330" alt="image" src="https://github.com/raycast/extensions/assets/77850354/e1ae1b31-fbb3-47fa-93d3-3037cf341f8b">

The error occurs directly when running the command.

### Expected Behaviour

Expected to summarized the video

This will be fixed in the upcoming update this week 🙂


chore: fix pip-compile-multi by pinning a few deps

I noticed dependabot wasn't really doing anything on the python side and also encountered issues while trying to bump a dependency before.
So I ran pip-compile-multi, waited for minutes for it to do its thing, and got this error message:
$ pip-compile-multi
Locking requirements/base.in to requirements/base.txt. References: []
Locking requirements/integration.in to requirements/integration.txt. References: []
Locking requirements/development.in to requirements/development.txt. References: ['requirements/base.in']
Package urllib3[socks] was resolved to different versions in different environments: 1.26.18 and 2.2.0
Traceback (most recent call last):
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/cli_v1.py", line 26, in cli
    recompile()
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/actions.py", line 31, in recompile
    compile_topologically(env_confs, deduplicator)
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/actions.py", line 38, in compile_topologically
    if env.maybe_create_lockfile():
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/environment.py", line 51, in maybe_create_lockfile
    self.create_lockfile()
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/environment.py", line 72, in create_lockfile
    self.fix_lockfile()
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/environment.py", line 134, in fix_lockfile
    sections = [
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/environment.py", line 135, in <listcomp>
    self.fix_pin(section)
  File "/Users/max/.pyenv/versions/3.9.16/envs/superset/lib/python3.9/site-packages/pipcompilemulti/environment.py", line 211, in fix_pin
    raise RuntimeError(
RuntimeError: Please add constraints for the package version listed above

From there I guessed that I could pin those indirect dependencies to a number that satistified all of the things referenced in the "# via {some_lib}"
After fixing one I hit another bump and ended up with the two lines in base.in that unlocked the run and ultimately bumping all those libs here.
🤞 pray for unit tests / CI to go through!

I think there's no way around it short of changing the logic. Maybe there's a way to target different ranges of our top-level deps to avoid this fix, but I'm unclear on how to proceed for that.
Note that currently pip-compile-multi fails so that means we're stuck without something like this. I'm open to other approaches, but we need to fix this.
I also noticed that dependabot seems to fail for python/pip, not sure if it's because of this issue, or something else.

I can take a look later today to see if I can wrangle  the issue.

Awesome, please do! I'll put this on hold for now.

Bonus point if you can get dependabot back on track :)

@mistercrunch I don't have the ability to push to preset-io. Here's the contents of my proposed commit which is a slight variation of your change—though with looser constraints after I determined the differences in the dependencies (listed as via in the *.txt files):
Author: John Bodley<EMAIL_ADDRESS>Date:   Thu Feb 1 12:40:35 2024 +1300

    Reconstrain dependencies

diff --git a/requirements/base.in b/requirements/base.in
index 2a3c58f84b..7a01a030dd 100644
--- a/requirements/base.in
+++ b/requirements/base.in
@@ -18,7 +18,7 @@
 #
 -e file:.

-# pinning these two dependencies that pip-compile-multi complained about
-# please oh please python overlords can you add support for diamond deps!
-urllib3[socks]==1.26.18
-referencing==0.31.0
+# The following constraints are currently required as these packages resolved to
+# different versions in different environments due to differing sets of dependencies.
+referencing>=0.28.0,<0.32.0  # jsonschema-path 0.3.2
+urllib3>=1.25.4,<1.27  # botocore 1.34.32
diff --git a/requirements/base.txt b/requirements/base.txt
index 4f876bd537..92ebd7190e 100644
--- a/requirements/base.txt
+++ b/requirements/base.txt
@@ -1,4 +1,4 @@
-# SHA1:4e4c4b98ddadacf7f8054c4afaa91bbc20c9f8e3
+# SHA1:f2d183fdbf060b653ccae2c5ce1ac2cba47e4255
 #
 # This file is autogenerated by pip-compile-multi
 # To update, run:
@@ -13,7 +13,7 @@ amqp==5.2.0
     # via kombu
 apispec[yaml]==6.4.0
     # via flask-appbuilder
-apsw==<IP_ADDRESS>
+apsw==<IP_ADDRESS>
     # via shillelagh
 async-timeout==4.0.3
     # via redis
@@ -313,7 +313,7 @@ pyyaml==6.0.1
     #   apispec
 redis==4.6.0
     # via apache-superset
-referencing==0.31.0
+referencing==0.31.1
     # via
     #   -r requirements/base.in
     #   jsonschema
diff --git a/requirements/development.txt b/requirements/development.txt
index ce34c9ae10..12d999ba81 100644
--- a/requirements/development.txt
+++ b/requirements/development.txt
@@ -14,9 +14,9 @@ astroid==3.0.2
     # via pylint
 asttokens==2.4.1
     # via stack-data
-boto3==1.34.31
+boto3==1.34.32
     # via tabulator
-botocore==1.34.31
+botocore==1.34.32
     # via
     #   boto3
     #   s3transfer
@@ -92,7 +92,7 @@ rfc3986==2.0.0
     # via tableschema
 s3transfer==0.10.0
     # via boto3
-sqloxide==0.1.39
+sqloxide==0.1.43
     # via -r requirements/development.in
 stack-data==0.6.3
     # via ipython

@john-bodley please re-open on apache/ and re can reference this PR for details


[IOTDB-1952] Add IT about group by level and multi level query for new vector

Add IT for aligned timeseries' group by level and multi level

Coverage decreased (-0.01%) to 67.286% when pulling 3b76e40ca3b52d7395fb5980b5467fc332884f20 on Cpaulyz:feat/groupByLevelForNewVector into e78f1b6cb83deab0c85df9d6b354f8dee53e5f0d on apache:master.


[IE 11][dev] Loader error: Unable to get property 'substr' of undefined or null reference

I'm getting this error on Internet Explorer 11 for Windows 8.1 when my assets are loading.
 /**
    * Transforms the asset URL.
    * The default implementation prepends the baseURL if the url doesn't being with http or //
    *
    * @method Phaser.Loader#transformUrl
    * @protected
    * @param {string} url - The url to transform
    * @return {string} The transformed url
    */
    transformUrl: function (url) {

        if (url.substr(0, 4) === 'http' || url.substr(0, 2) === '//')
        {
            return url;
        }
        else
        {
            return this.baseURL + url;

:x: ERROR: Unable to get property 'substr' of undefined or null reference
        }

    },

It doesn't happen on any other browser. I'm using phaser-arcadephysics from the dev branch. Evidently url is null or undefined on IE but I don't know why.

Build it from dev using the grunt script provided and retest. If it still
does it stick a debugger call in the loader source to find out which url is
breaking it.
On Monday, May 25, 2015, Lisandro Lorea<EMAIL_ADDRESS>wrote:

I'm getting this error on Internet Explorer 11 for Windows 8.1 when my
assets are loading.
/**    * Transforms the asset URL.    * The default implementation prepends the baseURL if the url doesn't being with http or //    *    * @method Phaser.Loader#transformUrl    * @protected    * @param {string} url - The url to transform    * @return {string} The transformed url    */
transformUrl: function (url) {
    if (url.substr(0, 4) === 'http' || url.substr(0, 2) === '//')
    {
        return url;
    }
    else
    {
        return this.baseURL + url;

[image: :x:] ERROR: Unable to get property 'substr' of undefined or null
reference
    }

},

It doesn't happen on any other browser. I'm using phaser-arcadephysics
from the dev branch. Evidently url is null or undefined on IE but I don't
know why.
—
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/issues/1813.

--
Photon Storm Ltd.
http://www.photonstorm.com
Skype: richard.davey
Twitter: @photonstorm
Registered in England and Wales.
Company ID: 8036404
VAT Number: 136 4333 27

My bad. I had forgotten to add the mp3 option to one of the audio files. The new build issued a warning showing me the error, instead of crashing.


Add focusing multiple panes

Added in https://github.com/microsoft/terminal/pull/11153

Docs Build status updates of commit b2f2ff0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/panes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Deletion of components fails if referenced source ref does not exist

Deletion of components is stuck state 'DeletionPending' if the referenced source object does not exist anymore (for example a flux GitRepository).

This bug was introduced with https://github.com/SAP/component-operator/commit/8b0cdc71722eb53d4c427d084f0beb914a6aa36c#diff-0702ede917ee437555d00c32619d913b80dbf25db68f4c3c33df0212cf792d5bL225, when LoadSourceReferences() with SourceReference.Init(). Mistakenly the part that ensures that references are not loaded in the deletion case, was missed in the new implementation:
	if !component.GetDeletionTimestamp().IsZero() {
		return nil
	}


Disable nginx caching via environment variable?

The image's nginx is caching responses, and it seems that it is not possible to change/disable that.
Can we have this configurable via environment variables or something?

Hi @caarlos0 -- Can you give an example of what you are seeing get cached? The caching configuration is in https://github.com/CachetHQ/Docker/blob/master/conf/nginx-site.conf
We should probably fix it globally and make the content not get cached if it is causing a problem.

hi @djdefi the problem is the endpoint /components/id endpoint.
We have an integration that gets a component to check if there are any incidents, and then open one in case it doesn't.
Problem is that because of the cache, sometimes it can create multiple incidents...

Opened #220 which I believe will prevent caching of /components/* by nginx.

Let me know when the new version is deployed to docker hub, please :)


Copr repository fails to sync for f27

Even though it's listed as available the repo fails to sync for f27. I have to set the releasever to 26 to actually download the package.

Sorry, I don't maintain any repositores. Are you talking about this one: https://copr.fedorainfracloud.org/coprs/valdikss/imgur-screenshot/
Looks like @ValdikSS is maintaining it?

@0xMatt, reuploaded the package, should be available for F27 now.

Repo synchronizes now, thanks for the prompt resolution @ValdikSS!


benefits of avoiding pointer arithmetic

Ep 389 annoyed and confused enough people that I need to actually show why.
And possibly a way to use ranges too.

Recorded - we'll see what people think of this one

Coming in Ep 406


Fixes intellisense problems discovered in RC1

without default values when typng a space or slash in the quoted text
Fixes a problem where typing a slash almost anywhere inserts '/>' a self closing tag
Prevents hover popups for non-attribute items
Fixes intellisense suggesting incorrect attributes for elements that spread across multiple lines
closes #1065

Testing the intellisense changes:
These test are performed using the schema https://github.com/OpenDFDL/examples/blob/master/helloWorld/src/main/resources/helloWorld.dfdl.xsd
and the data file https://github.com/OpenDFDL/examples/blob/master/helloWorld/src/main/resources/helloWorld.dat
Type a slash (/) or space at the position indicated by the red arrow.  The action of typing the slash or space should not cause the text within the quotes to be truncated.

Type a slash at the position indicated by a red arrow. Typing the slash should not result in "/>" appearing at the cursor position.

Hover over the word element indicated by the red arrow no hoer hint should be provided.

Hover over the word maxOccurs indicated by the red arrow. Hover test with a definition should display.

Step through the schema in the debugger. Pressing the stepover button at line 24 should not result in a dsiplay of intellisense suggestions.

@rthomas320 I having a problem where if I try adding a / it is being automatically deleted. The only time it seems to not be deleted is when I am adding it some strings already present. But in some of those cases the whole string is being deleted. I will try to upload a recording of it

The problems Shane noted above should be fixed. The keyword "import" was missing from the element list and the keyword "namespace" was missing from the attribute list.  A problem with intellisense not supplying a self closing endtag when the line immediately following the trigger line had a self closing tag was resolved.


Feature: UnderwaterPlant()

I tried adding a custom bit to the Biome config, but when I generate the world, nothing is added.
This is what I added:
Plant(biomesoplenty:coral:4,6,70.0,40,60,DIRT,CLAY,GRAVEL,SAND)
Plant(biomesoplenty:seaweed,6,70.0,40,60,DIRT,CLAY,GRAVEL,SAND)

I also gave this a try:
UnderWaterOre(biomesoplenty:coral:4,8,6,70.0,DIRT,CLAY,GRAVEL,SAND)
UnderWaterOre(biomesoplenty:seaweed,8,6,70.0,DIRT,CLAY,GRAVEL,SAND)

but that just resulted in a crash loop:
Description: Exception while updating neighbours

java.lang.StackOverflowError: Exception while updating neighbours
	at java.security.AccessController.doPrivileged(Native Method)
	at java.lang.ClassLoader.checkPackageAccess(ClassLoader.java:500)
	at net.minecraft.crash.CrashReportCategory$Entry.<init>(CrashReportCategory.java:278)
	at net.minecraft.crash.CrashReportCategory.func_71507_a(CrashReportCategory.java:106)
	at net.minecraft.crash.CrashReportCategory.func_71499_a(CrashReportCategory.java:111)
	at net.minecraft.crash.CrashReportCategory.func_189529_a(CrashReportCategory.java:100)
	at net.minecraftforge.fml.common.FMLCommonHandler.enhanceCrashReport(FMLCommonHandler.java:381)
	at net.minecraft.crash.CrashReport.func_71504_g(CrashReport.java:119)
	at net.minecraft.crash.CrashReport.<init>(CrashReport.java:40)
	at net.minecraft.crash.CrashReport.func_85055_a(CrashReport.java:360)
	at net.minecraft.world.World.func_190524_a(World.java:554)
	at net.minecraft.world.World.func_175685_c(World.java:492)
	at net.minecraft.world.World.func_175722_b(World.java:439)
	at net.minecraft.world.World.markAndNotifyBlock(World.java:380)
	at net.minecraft.world.World.func_180501_a(World.java:360)
	at biomesoplenty.common.block.BlockBOPDecoration.checkAndDropBlock(BlockBOPDecoration.java:119)
	at biomesoplenty.common.block.BlockBOPDecoration.func_189540_a(BlockBOPDecoration.java:92)
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_189546_a(BlockStateContainer.java:481)
	at net.minecraft.world.World.func_190524_a(World.java:550)
	at net.minecraft.world.World.func_175685_c(World.java:492)
	at net.minecraft.world.World.func_175722_b(World.java:439)
	at net.minecraft.world.World.markAndNotifyBlock(World.java:380)
	at net.minecraft.world.World.func_180501_a(World.java:360)
        at biomesoplenty.common.block.BlockBOPDecoration.checkAndDropBlock(BlockBOPDecoration.java:119)
	at biomesoplenty.common.block.BlockBOPDecoration.func_189540_a(BlockBOPDecoration.java:92)
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_189546_a(BlockStateContainer.java:481)
	at net.minecraft.world.World.func_190524_a(World.java:550)
	at net.minecraft.world.World.func_175685_c(World.java:492)
	at net.minecraft.world.World.func_175722_b(World.java:439)
	at net.minecraft.world.World.markAndNotifyBlock(World.java:380)
	at net.minecraft.world.World.func_180501_a(World.java:360)

The problem is probably that Plant() requires a block of air, but if I add WATER as a BlockSource to allow it to place in water, it will result in the generator trying to add it in every single block of water.
Can you add some kind of PlantUnderwater() function? that will check if the plant is on top of a BlockSource and in a block of water, instead of air?

Hey Xorinzor, that's a great idea for a future release, I'll pick it up as soon as i can. At the moment I'm working on some big improvements though so it won't be in the next release.

Will be in v9, to be released on curseforge asap. Included in dev version v9_r11, available on discord asap.


[bug] getStoryContext is missing playFunction

Describe the bug
When using getStoryContext inside of .storybook/test-runner.js, the contents of the play function do not get included in the output. It is missing when used in both preVisit and postVisit.
To Reproduce
Steps to reproduce the behavior:

Use getStoryContext in the test-runner.[ext] in preVisit and postVisit and log the output
Run test-storybook
View logged output
undefined at context.playFunction and moduleExport.play

Expected behavior
The play function should be included?
Screenshots
If applicable, add screenshots to help explain your problem.
System
  System:
    OS: macOS 14.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.11.0/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm <----- active
  Browsers:
    Chrome: 122.0.6261.129
    Safari: 17.2.1
  npmPackages:
    @storybook/addon-coverage: ^1.0.1 => 1.0.1
    @storybook/addon-essentials: ^8.0.0 => 8.0.0
    @storybook/addon-interactions: ^8.0.0 => 8.0.0
    @storybook/addon-links: ^8.0.0 => 8.0.0
    @storybook/blocks: ^8.0.0 => 8.0.0
    @storybook/html: ^8.0.0 => 8.0.0
    @storybook/html-vite: ^8.0.0 => 8.0.0
    @storybook/test: ^8.0.0 => 8.0.0
    @storybook/test-runner: ^0.17.0 => 0.17.0
    storybook: ^8.0.0 => 8.0.0

Additional context
Reproduction: https://github.com/scottnath/virtual-screen-reader-storybook/tree/test-runner
Logged output in GitHub actions: https://github.com/scottnath/virtual-screen-reader-storybook/actions/runs/8303334953/job/22727286655
thank you

Hey there @scottnath! The hooks execute in node, and because functions are not serializable, they're therefore not passed over the wire. If you really need access to the play function (or any function from parameters, etc), you will have to execute things in the browser context, which you can do via page.evaluate:
  async preVisit(page, story) {
    const ctx = await getStoryContext(page, story);

    await page.evaluate(async () => {
      // This code will be run in the browser
      const ctx = await getStoryContext(page, story);
      console.log('preVisit context', ctx);
    })
  },

I don't recommend accessing or executing the play function there. It will already be executed automatically and if it fails, the tests will fail correctly. Cool idea regarding VSR btw!


WorldGuardExtraFlags breaks AsyncWorldEdit

Exception when doing //replace command. See: https://pastebin.com/BLcgJCX6
I'm using CraftBukkit 1.12.2 with:

AsyncWorldEdit 3.5.4
WorldEdit 6.1.9,caf0ad9 which is the released version for 1.12.2 from https://dev.bukkit.org/projects/worldedit/files
WorldGuard 6.2.2-SNAPSHOT,8eeab68 which is the released version for 1.12.2 from https://dev.bukkit.org/projects/worldguard/files
WorldGuardExtraFlags 4.1.1

Fixed in 56e6dc8

Looks good.  Thank you.


Explanation for flags in README

It would be good to have a more extensive explanation on how to use flags '-a' or '-w'. For example, how to use '-a' if there is only one taxonomic level you want to group at (and if this is possible). Similarly '-w' flag explanation doesn't state what are the limits for weights (0-10?); and if bigger numbers mean more weight to that taxonomic level. An example would be great.

We will defined create docs that describe these in a lot more detail. For now, the short readme will incorporate some more examples and explanation. Thank you!


codereview

We've been using https://reviewable.io and its gaining popularity, might want to take a look at it also.

Indeed. Looks interesting.
/cc @mpl

that coupled with https://lgtm.co/ and http://homu.io/ can probably replace gerrit all within github native services.

although I think homu can probably do most of lgtm.co itself, with a more familiar workflow...?


[VS Code] Starting collaboration session: Invalid URI: The format of the URI could not be determined.

Error:
Starting collaboration session: Invalid URI: The format of the URI could not be determined.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.419

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.35.1

platformName
MacOS

platformVersion
18.2.0

Duplicate of #2314

Thanks for the issue report. Although I have closed this as a duplicate, your logs may provide us with helpful information. You can find your logs in the %TEMP%/VSFeedbackVSRTCLogs directory. You can attach them to this issue or send in email to<EMAIL_ADDRESS>


Finish docs/contribution.md tutorial.

Finish writing manuals for this doc file.

https://gist.github.com/urosjarc/5a6cc3652ff1e96a7a8db51c4e911886

Update subgenerator template docs too!


Error when importing pyjsdl. pyjsobj uses pyjamas

pyjsobj.py should use pyjs instead of pyjamas. I am having import errors when using pyjs.

I do not have the issue, perhaps it is a pyjs installation problem. Please provide further info of your development environment such as your os,  pyjs version installed, etc. My development environment is linux with the latest git update of [pyjs v0.8.2] (https://github.com/pyjs/pyjs/) installed and the [pyjsdl module] (http://gatc.ca/projects/pyjsdl/) on the path of the python script. Running pyjsbuild on a script shows pyjspath info that includes the path local/lib/python2.7/site-packages/pyjswidgets that contains pyjamas import files, perhaps your path was not set properly. My website [post] (http://gatc.ca/2014/11/16/guide-to-pyjs-and-pyjsdl/) has notes on development with pyjs and pyjsdl.


Simply pass argument not possible?

I am trying to simply pass an argument. Even after going over all the docs, I think I am missing something.
[
  {
    "id": "test-webhook",
    "execute-command": "/etc/webhook/webhook-test.sh",
    "command-working-directory": "/var/log/webhook",
    "pass-arguments-to-command":
    [
        "1": "hallo",
        "2": "there"
    ]
  }
]

And then my webhook-test.sh does not work:
#!/bin/bash
LOGFILE=/var/log/webhook/access.log
NOW=$(date -R)
echo "[$NOW] TEST: Call received of 'test-webhook' with parameters '${1}' and '${2}'" >> $LOGFILE

Ok, got it. The parameters passed as $1, $2, should be listed as "source" string...
[
  {
    "id": "test-webhook",
    "execute-command": "/etc/webhook/webhook-test.sh",
    "command-working-directory": "/var/log/webhook",
    "pass-arguments-to-command":
    [
      { "source": "string",
        "name": "hello"
      },
      {
        "source": "string",
        "name": "there"
      }
    ]
  }
]


Update webview peer dependecy to match >11 versions and allow configuring readonly mode

There is a peer dependency for "react-native-webview": "^11.0.0" which doesn't allow to install library where the library is imported to project which uses >11 react-native-webview version (npm 8+). There is a workaround to use npm install --legacy-peer-deps but that is not recommended.
There is also a change to allow passing readonly property which applies readOnly mode for quill and the text is not editable. There is existing issue which is related to that topic so I think that will be a good improvement: https://github.com/imnapo/react-native-cn-quill/issues/86

@imnapo could you take a look at that changes?

@imnapo, is this fix coming? It has been open for a long time and is important for anyone using newer versions of WebView.

I am also waiting for this fix


Video Properties and Attributes

Is there a listener to get properties of the played video. Like if I want to check if loaded video is a live video or not?

You need to use the YouTube Data API for that.


Basic README describing the new fork

@AlexanderSchuetz97 please double check there's no mistakes with your name/email address (taken from other commits)

My name is spelled with a German special letter "ü". "ue" is a commonly used substitute for it used when its not available (such as in email addresses).
So my name is "Alexander Schütz". The e-mail address you used is correct.


Disable mouse wheel scroll acceleration

The default mouse scroll wheel has acceleration settings which make a one tick scroll have virtually no effect, while anything larger scrolls too much. I find this effect annoying and would prefer linear scrolling with no acceleration. This Stack Overflow question describes the problem well: http://superuser.com/questions/200660/how-do-you-disable-mouse-scroll-wheel-acceleration-in-mac-os
As you can see in that question USB Overdrive has an option to restrict the mouse wheel to linear scrolling and specify the speed of the scroll. Does Karabiner have any such option? I've tried playing around with Parameters->Mouse Key->Scroll settings, but it doesn't seem to have any effect.
OS X 10.10.5
Karabiner 10.18.0
Logitech M500

Unfortunately, Karabiner does not have such function.
SmoothMouse might be able to do that.
http://smoothmouse.com/

OK, thanks. I will use an alternative.
I'll leave this issue open as a feature request to implement. If you don't think this is an appropriate feature to add to Karabiner you can just close it.


Dynamic API: Support positional-only arguments

RF 4.0 added support for Python's positional-only arguments (#3695). It isn't that important feature, but sometimes it comes handy. For consistency reasons also dynamic libraries should support it.
Implementing this enhancement shouldn't be too complicated. Our ArgumentSpec already supports positional-arguments and that's what is used during execution. The only needed change ought to be enhancing the code that parses argument information returned by dynamic libraries. Well, even before that we needed to agree on the syntax but ['posonly', '/', 'normal'] that matches the syntax used by Python is a pretty obvious candidate. It's also consistent how the dynamic API supports named-only arguments like ['normal', '*', 'namedonly'].

If someone is interested to contribute, the parsers for different arguments are here:
https://github.com/robotframework/robotframework/blob/master/src/robot/running/arguments/argumentparser.py


Removing gcr.io/kubebuilder/kube-rbac-proxy from the kustomize manifests.

This image replacement is not used anymore.

/assign @yevgeny-shnaidman @TomerNewman

Fixes https://github.com/rh-ecosystem-edge/kernel-module-management/issues/1275

/approve from my end
Lets wait for @yevgeny-shnaidman to lgtm this jsut to make sure :)

/lgtm

/retest

/retest

/retest

Fixes https://github.com/rh-ecosystem-edge/kernel-module-management/issues/1275


Access other params

Hello,
Just curious if there's a way to output the other vars in the string.
For instance you can access utm_source with $utmString->source. But if there are other params like &whatever=1, is there an easy way to access that? I can see it is parsed in the object.
Thanks for any help you can give.

Working only utm_ query params. For example, utm_test is accesible as ->test. If string doesnt content utm its marked as invalid. For more advance parsing I recommend this package https://github.com/spatie/url .

Thanks for the response. And yeah, I figured out it likes anything with utm_. However when I dumped the object, I see you are accurately parsing the rest. For example:
object(Rhinodontypicus\Parsers\UtmString)#812 (3) {   ["valid":"Rhinodontypicus\Parsers\UtmString":private]=>   bool(true)   ["text":"Rhinodontypicus\Parsers\UtmString":private]=>   string(131) "http://test.com/test?utm_source=bing&&utm_medium=cpc&utm_campaign=rolex&utm_term=rolex+two&utm_ad=something&utm_ray=another&ggg=fff"   ["parameters":"Rhinodontypicus\Parsers\UtmString":private]=>   array(7) {     ["utm_source"]=>     string(4) "bing"     ["utm_medium"]=>     string(3) "cpc"     ["utm_campaign"]=>     string(5) "rolex"     ["utm_term"]=>     string(9) "rolex two"     ["utm_ad"]=>     string(9) "something"     ["utm_ray"]=>     string(7) "another"     ["test"]=>     string(3) "true"   } }
It accurately parsed &test=true. I just wondered if there was some way to access those. Like $utmString->parameters['test']. And if not, would you mind a pull request? Or do you ONLY want this package to deal with utms?

For now queries in private prop of string object, so we cant access them outside object scope. You can make pull request, I will accept it. But, like I said, there is really exists better package for url manipulation and that sort of things.


Check dynamic state / line rasterization feature support during sample init

Description
This PR adds feature checks to the following samples prior to Vulkan device creation:

dynamic_line_rasterization : rectangularLines, bresenhamLines, and smoothLines features
extended_dynamic_state2: extendedDynamicState2 and extendedDynamicState2PatchControlPoints features
logic_op_dynamic_state: extendedDynamicState2 and extendedDynamicState2LogicOp features
patch_control_points: extendedDynamicState2 and extendedDynamicState2PatchControlPoints features

In addition, for dynamic_line_rasterization, the sample now enables line types individually, and provides feedback to users regarding which types are supported.
Also, for extended_dynamic_state2, the VK_EXT_primitive_topology_list_restart extension has been made optional to allow the sample to mostly work on macOS.
Tested on Windows 10 and macOS Ventura using an AMD 6600XT GPU with lastest AMD drivers and SDK 1.3.290.  The samples no longer crash on Windows 10 when using AMD drivers, and run as per the following:
Windows 10: dynamic_line_rasterization runs with partial lines support; extended_dynamic_state2, logic_op_dynamic_state, and patch_control_points do not run based on lack of feature support, but exit cleanly.
macOS Ventura: extended_dynamic_state2 and patch_control_points run; dynamic_line_rasterization and logic_op_dynamic_state do not run based on lack of feature support, but exit cleanly.
Fixes #1144
General Checklist:
Please ensure the following points are checked:

[X] My code follows the coding style
[X] I have reviewed file licenses
[X] I have commented any added functions (in line with Doxygen)
[X] I have commented any code that could be hard to understand
[X] My changes do not add any new compiler warnings
[X] My changes do not add any new validation layer errors or warnings
[X] I have used existing framework/helper functions where possible
[X] My changes do not add any regressions
[X] I have tested every sample to ensure everything runs correctly
[X] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[X] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[X] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

[X] I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[X] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[X] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[X] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
[ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
[ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

I think this is already being addressed with #1013

Thanks @SaschaWillems - I was not aware of that work.  I applied PR #1013 and it addresses issue #1144.
I will add a few comments on that thread and close this PR.


Event Photos Everywhere

Description
Add Event photos everywhere relevant.
Fixes #94

Refactor Event Image Handling
RecentCard:choosePicture -> functions:chooseDefaultPicture
Use chooseDefaultPicture
reduce extra code
formatting changes to adhere closer to figma design
Add event creation time
Address warning messages

6 existing unit tests are failing in master, before I even made changes. 8 are failing after my changes.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Change Status

[ ] Complete, tested, ready to review and merge
[x] Complete, but not tested (tests need to be fixed/added)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[x] Extensively tested manually by adding & updating events with & without images
[ ] All unit tests (existing & new) pass (pending)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

I'd very much like some help with the failing tests, since 6 are already failing in master before I made my changes, that kind of makes it harder to fix the 2 that broke after my changes.

 Add event image to event card


[Bug] Using the "Download" from contextmenu show "Playback failed" dialog

@elgatito @antonsoroko
Using the "Download" option from Elementum context menu options start downloading in the background
but also shows the "Playback failed" dialog which shouldn't be shown on this option.
Kodi log debug:
https://paste.ubuntu.com/p/9yj9zTRQcZ/plain

By the way, when I choose "Delete torrents and files" from context menu in the Torrents list,
does it should show a dialog to confirm? Because it doesn't.

Elementum 0.1.98
Elementum Context menu: 0.0.13

but also shows the "Playback failed" dialog

this is true.

which shouldn't be shown on this option.

but i am not sure that it can be easily fixed without rewriting a lot of code.
for "download" we just re-use "play" code, but then we simply close the "player" immediately. see https://github.com/elgatito/elementum/blob/6aea37dab272b523d6ec42dd75ef123031e388d6/api/play.go#L119

By the way, when I choose "Delete torrents and files" from context menu in the Torrents list, does it should show a dialog to confirm? Because it doesn't.

it could, but there is no such code. but i agree - it sounds like a good idea to confirm before delete real files.

but also shows the "Playback failed" dialog

this is true.

which shouldn't be shown on this option.

but i am not sure that it can be easily fixed without rewriting a lot of code. for "download" we just re-use "play" code, but then we simply close the "player" immediately. see https://github.com/elgatito/elementum/blob/6aea37dab272b523d6ec42dd75ef123031e388d6/api/play.go#L119

I understand.
@elgatito
What do you think?

I guess that si because context plugin is calling xbmc.Player().play(url), which expects a playback to start. So for non-playback actions it should use something else.

By the way, when I choose "Delete torrents and files" from context menu in the Torrents list, does it should show a dialog to confirm? Because it doesn't.

it makes sense to create a separate issue about that.

@elgatito
so i tried to use RunPlugin() to avoid this "Playback failed" message
to
https://github.com/elgatito/context.elementum/blob/bb7786cb31434db42d5c770d5cea48aa82ddf576/plugin.py#L172
i added
    if action == "play":
        xbmc.Player().play(url)
    else:
        xbmc.executebuiltin('RunPlugin("%s")' % url) # to avoid "Playback failed" notification when we do not actually start playback

so it starts burst search but then it does nothing.
so in log it stops after
[plugin.video.elementum] Redirecting with code 302 to: plugin://plugin.video.elementum/download?doresume=false&tmdb=1184918&type=movie&uri=magnet...
[plugin.video.elementum] Resolving TMDB item by calling http://<IP_ADDRESS>:65220/movie/1184918/infolabels for ['plugin://plugin.video.elementum/movie/1184918/download/...', '-1', '', 'resume:false']

it looks like redirect does not work with RunPlugin.
with xbmc.Player().play(url) it goes further, for example i see
CScriptRunner: running add-on script Elementum('plugin://plugin.video.elementum/download', '11', '?doresume=false&resume=...&tmdb=1184918&type=movie')
but i am not sure about this. and i am not sure how to overcome this.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
2365130 -> d0fdeef

github.com/IBM/platform-services-go-sdk
require
patch
v0.64.2 -> v0.64.3

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.35.2 -> v1.35.3

go (source)
toolchain
patch
1.22.4 -> 1.22.5

Release Notes

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.64.3
Compare Source
Bug Fixes

IAM Policy Management: remove options property from PolicyAssignment (#341) (6f14d26)

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.35.3
Compare Source
Bug Fixes

do not destroy the project on failure so schematic workspace logs can remain for debug (#837) (72f3c8e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.23.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


how to activate it?

Sorry for possibly dump question, but I don't find how to activate it. When the language of the file is shell script, the snippets don't appear.

Hi,
You nead to have the code package Autocomplete-plus installed.
Create new file
Select Grammar shell script
Press 1
=> A popup menu should be displayed

@Janfy, thanks for the info! The problem was that autocomplete-plus by default had 'Minimum word length' set to 3, so the short combinations were not analyzed. Now with this setting set to '1' everything works as expected.

Cool!
I don't remember i had to change this setting.


can you write this in java?

I am devoloper of android, this project is important for me. can you write this in java

Hey @niezhiyang  , thanks for being interested in my project, I really appreciate contributions of any kind. At the moment I am a bit busy so I don't think I can implement this in Java any time soon. However, thanks to the recent shift of Tensorflow to support Java as a 'first-class-citizen' there is certainly the possibility to migrate parts of the code in this repository to fulfill you needs. Keep in mind that you would also need to make OpenCV available to Java though! This should not be too difficult as OpenCV supports Java now as well! However, I have little experience in this regards so you would be on your own here!
If you manage to make some progress, please let me know and maybe you could even make a pull request and contribute.
Again, thank you for your interest!


refactor: forward ref to datepicker instance

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/16551
$ https://github.com/Expensify/App/issues/16551#issuecomment-1490344206
Tests

Go to settings -> Profile -> Personal Details
Click Date of birth
It should open the date of birth page with opened new calendar picker

[x] Verify that no errors appear in the JS console

Offline tests
No offline tests needed
QA Steps

Go to settings -> Profile -> Personal Details
Click Date of birth
It should open the date of birth page with opened new calendar picker

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/24796318/229082360-c21d045c-5632-4367-9ac0-0007061865e2.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/24796318/229082345-f0920cb9-a6a0-44be-9628-f96b6d7712b9.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/24796318/229082316-569d5bd9-f7d9-4eab-91a4-d0fdc160f2f0.mov

Desktop
https://user-images.githubusercontent.com/24796318/229082267-eb7a158a-8c0e-427e-bcee-9c26ef9c867a.mov

iOS
https://user-images.githubusercontent.com/24796318/229082211-c7286a28-8798-4396-a0f4-76a7fa52d670.mov

Android
https://user-images.githubusercontent.com/24796318/229082240-2404329c-0c53-47b7-8089-8f89ab03aa46.mov

@mountiny @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

I faced a ref forwarding issue, componentDidMount is called before the ref callback, so I wrapped it with setTimeout.
Does anyone know why this issue is happening?

@mountiny This PR is ready for review 🚀

I saw some places in the code base where InteractionManager.runAfterInteractions is used to call a methods using ref

I tried to workaround it in many ways, but none of them helped, I'm guessing this problem may be caused by HOC

Yeah runAfterInteractions  uses setTimeout under the hood, its discouraged to use it, but if this is the only way we are able to achieve this 🤷
might be good to bring this to the open source channel and see if others have some ideas of why it does not work, at least we can confirm there is no other way

Good point 👌 Let's see. I asked in opensource channel

@mountiny @ArekChr I think it's because NewDatePicker is inside the Form.js component.

We can create a callback function from Form.js where it's called after the form is mounted, and change a state in DateOfBirthPage to determine if the form is ready, then we call show picker in the componentDidUpdate after the form is ready.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/25520267/229575201-7216ed4a-4b0f-45d7-8ac8-2a5e9f6bf423.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/25520267/229575226-f9a09d75-af41-43c1-8d25-2185ec32c13e.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/25520267/229575245-bcccd78b-1479-4776-a5a3-447f96abf126.mp4

Desktop

https://user-images.githubusercontent.com/25520267/229575264-58d9e65c-f254-4815-aec4-baba7e41747c.mov

iOS

https://user-images.githubusercontent.com/25520267/229575286-4c3acaf8-6461-427a-ae4f-2de6b50c8a75.mp4

Android

https://user-images.githubusercontent.com/25520267/229575758-ed401e83-2a40-438c-a85f-c2ed67f0085f.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


update the function of mapping-launch.sh

Update mapping-launch.sh and docker-compose-mapping.yaml to enhance the functionality.
It is necessary to update cabot-navigation to include changes introduced in https://github.com/CMU-cabot/cabot-navigation/pull/54

Because changes ware only made on mapping-related files (mapping-launch.sh and docker-compose-mapping.yaml), this pull request has no effect on normal operation.


fix: GCP e2e tests

Don't configure managed addon when OCM_SINGLE is being used.
Note: OCM_SINGLE shouldn't really be used anywhere now but our e2e tests currently still rely on it.
Changes added to allow errors to be surfaced when checking the dnsrecord resource status.

/lgtm


Deflake Pod Zone Affinity integration test

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
This PR deflakes the Pod Zone Affinity integration test. It creates a separate namespace per It because the webhook reads zone information from namespaces which can interfere with other Its in the Suite.
Which issue(s) this PR fixes:
Fixes #6671
Special notes for your reviewer:
Thanks @unmarshall for the proposal.


fix: Bar stacking on v2 doesn't work if the x-axis is value type

SUMMARY
When GENERIC_CHART_AXES is enabled, stacking on bar chart v2 is not working correctly in all cases.
The reason is that bar stacking is supported by echarts only for categorical types.
Source: https://github.com/apache/echarts/issues/15102
This PR hides that feature if the axis is not categorical.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/176978590-653b4411-ed1a-4e1f-a0a9-d138b6091b29.mov
After:
https://user-images.githubusercontent.com/17252075/176978651-8ff74bd7-45f6-49d8-9641-11d635317692.mov
TESTING INSTRUCTIONS

Enable GENERIC_CHART_AXES.
Create Bar v2 charts with different types in the x-types.

Ensure the stack option is only available for categorical types, and that it works as expected.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up FEATURE_GENERIC_CHART_AXES=true

@diegomedina248 @zhaoyongjie should we set up a time to sync on this and get to the bottom of it?

Closed in favor on #20805


[docs] New Glossary doc?

What terms are used in Cargo and what they mean is a common theme in Cargo issues/pulls, as well as in the documentation. Recently I just updated some of the docs to use the correct term in their place. (See https://github.com/rust-lang/cargo/pull/4376 and https://github.com/rust-lang/cargo/pull/4375)
I think with the expansion of Cargo features, it makes sense to have a Glossary document that describes each term and points to the detailed description.
We can add this to the new mdBook-based docs, and not in-repo.
Here's some example terms that I have seen confusions about in the docs and public spaces, like the users forum:

crate
package
build target (as in platform and its binary format)
target (as in lib, bins, tests, examples, ...)
crate file
package repository (as in git repo)
package repository (as in crates.io), a.k.a. package index
package root (the directory)
workspace root (the directory)
workspace root package (a package or its manifest)
repository root (the directory)

What do you think?

cc @carols10cents

Also cc @istankovic, since this would be a new section on the new mdBook-based repo.


Removed trailing commas in has_fields attribute. Replaced Rails to_qu…

…ery method with dependency-free Ruby.
Includes fixes for:
https://github.com/Shopify/ssllabs.rb/issues/4
https://github.com/Shopify/ssllabs.rb/issues/2

Thanks, I'll merge this


Update Exchange-Teams-interact.md

These articles should be linked, as the Troubleshooting one is a direct follow up to this article, and a critical article in many scenarios that customers can face, and bring them to consult these.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[AddressLowering] Rematerialize projections eagerly.

The pass rewrites opaque values in reverse post order of their definitions.  When an opaque value is rewritten, both its definition and its uses are rewritten.  When a def or a use is rewritten, in order to materialize an address with which to rewrite, projection instructions are created.  Some of these projection instructions may be reused when rewriting later opaque values.
As a result, it's possible to have two opaque values A and B (which are rewritten in that order) such that rewriting a use of A which occurs "after" the def (or a use) of B creates a projection P which is then used by that "earlier" def (or use) of B:
```
A =
B =     // relies on P
use B
use A   // creates some projection P
```

When rewriting the def (or that use, respectively) of B, the projection which was created for the use of A will be reused.  But that projection instruction will be "after" the place where it is used when rewriting the def or use of B.  That's invalid!
To address this, rather than reusing the old instruction, always create a new instruction for a projection.  If the new instruction occurs "before" (i.e. dominates) the old instruction replace uses of the old with the new and delete the old.  Otherwise, just delete the new instruction.

@swift-ci please test

@swift-ci please test windows platform

Closing in favor of https://github.com/apple/swift/pull/63033 .


Extra parameter SLAACuseIPv4iface. Issue #9324

[ ] Redmine Issue: https://redmine.pfsense.org/issues/9324
[ ] Ready for review

Update for https://github.com/pfsense/pfsense/pull/4169
It adds $slaacusev4iface parameter,
Otherwise using one parameter $ipv6usev4iface by both Static IPv6 and SLAAC confuse WebGUI

@vktg could you please squash commits to remove the merge?

commits squashed

it also adds checking for SLAAC parent interface in get_interface_ipv6()


Email Validation issue

Email id is not validating properly while logging in. I know it's a small issue but i feel it's good if proper validation is happening so that others no need to think  about changing existing validation

How do I reproduce this issue?

I'm not sure if this is a report about the email textbox not validating the format of the email typed, or if this is a request to add two step email verification (send an email on registration and require the user click a link back to verify the email address was legit before enabling the account).
The former case seems to be working, but if I track back to August in the change history I might find that I'd not put the validation on that field until after this issue was reported.
The latter case would be nice, but I had no plans to implement address validation just yet. In the next release cycle we'd plan to gut the entire security system and replace it, probably with something build from IdentityServer.


Zodiac does not apply in simulation when importing from BNet

The Zodiac ring doesn't apply in simulations correctly when a profile is first loaded from Battlenet. I can work around this by replacing Zodiac with another ring and then setting it back to Zodiac.
Bnet Profile: https://us.diablo3.com/en/profile/Binkenstein-6359/hero/89843495
D3Planner Profile: https://www.d3planner.com/156133820

Fixing.


read -t html fallback to plain content if no html is found

Still output valid html. Should fix #352

nvm. it doesn't work correctly.

Thanks for the try anyway :) the condition should be higher in the code. I will try to do sth this weekend and let you know.


Allow template for the payload parameter for 'rest sensor'

Description:
Allow templates for the payload parameter.
This is needed for some webservices, like the APS inverters that need to include the current date in the payload. For example:
- platform: rest
  name: "APS opgewekt vandaag"
  method: POST
  resource: "https://apsystemsema.com/ema/ajax/getDashBoardAjax/getSystemCurrentDayEnergy"
  headers:
    User-Agent: "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36"
    Content-Type: "application/x-www-form-urlencoded"
    Accept: "application/json, text/javascript, */*; q=0.01"
    X-Requested-With: XMLHttpRequest
    Origin: https://apsystemsema.com
    Referer: https://apsystemsema.com/ema/security/optmainmenu/intoLargeDashboard.action
  payload: "eculist=21600000xxx&date={{ as_timestamp(now()) | timestamp_custom('%Y%m%d')}}"
  value_template: "{{(value | float) | round(2)}}"
  device_class: power
  unit_of_measurement: 'kWh'
  scan_interval: 300
  force_update: true
  timeout: 30

Checklist:

[ x] The code change is tested and works locally.
[ x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ x] There is no commented out code in this PR.
[ x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ x] Documentation added/updated in home-assistant.io

Hi @jantenhove,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This causes every payload to be handled as a template, wouldn't it be more viable to introduce a payload_template option?

Please address CI issues

There is no information on the CI issues besides: "Bash exited with code '1'." I don't have a clue how to solve this.

Solve the merge conflict first. Then the build will run again and we can see what's wrong.

Tip: Solving merge conflicts with Github is not a good idea :). I will fix the Lint issues and commit again.

Why is CheckFormat failing? I've used the Black formatter to format the code. The error message is not very helpful:
in/bash --noprofile --norc /__w/_temp/d7fbf2b5-16a6-4243-838b-99cb013d66a2.sh
##[error]Bash exited with code '1'.

Please solve the merge conflict.

@jantenhove any updates on this? :)

This PR seems to have gone stale. Closing it.


Couchbase queries against generated classes are not working

The queries return no results.

@marcusbooyah: I actually do have some query unit tests and they're passing.  I am investigating some odd behavior in some additional test cases.

I think I've narrowed this down: Linq2Couchbase doesn't like property names starting with a CAPITAL letter.
I'll bet we need to disable camel casing mode or something.

FIXED: The root cause was that I was sub-classing the Couchbase DefaultSerializer class to override some settings and this was kind of working.  The problem is that Linq2Couchbase requires the serializer to implement an extensions interface (I can't find the specific one any more) and my new serializer didn't do this.  I fixed this by going back to the DefaultSerializer, but initialing it using my custom settings.

FOLLOWUP: My round-trip unit test failed after going back to an unwrapped DefaultSerializer.  I went back to wrapping it with a custom serializer that now implements IExtendedTypeSerializer.  Unit tests are passing.


[FEEDSTOCK REQUEST] ONNX Runtime

Describe the package you'd like added
ONNX Runtime is a cross-platform inferencing and training accelerator compatible with many popular ML/DNN frameworks, including PyTorch, TensorFlow/Keras, scikit-learn, and more. aka.ms/onnxruntime
Many users can benefit from ONNX Runtime, including those looking to:
Improve inference performance for a wide variety of ML models
Reduce time and cost of training large models
Train in Python but deploy into a C#/C++/Java app
Run on different hardware and operating systems
Support models created in several different frameworks
https://github.com/Microsoft/onnxruntime/releases/tag/v1.5.1
Describe how this package fits in with the project
ONNX Runtime inferencing is used by Nvidia's Triton Inferencing Server (used to be TensorRT inferencing server) among others.
It uses an plugs into many different cpu and gpu acceleration APIs
Additional context
ONNX Runtime inferencing APIs are stable and production-ready since the 1.0 release in October 2019 and can enable faster customer experiences and lower costs.
It's unclear if it works on anything other than x86
ONNX Runtime training feature was introduced in May 2020 in preview. This feature supports acceleration of PyTorch training on multi-node NVIDIA GPUs for transformer models. Additional updates for this feature are coming soon.

CUDA11 support was added recently:
https://github.com/Microsoft/onnxruntime/releases/tag/v1.5.1

I think this will line up with Open-CE 1.3:

onnx 1.7
CUDA support can be work in progress, but would be cuda11 variant,
TRT support can be work in progress, but would be 7.1 (or later)
other noarch onnx tools to add as well:

onnxmltools (https://github.com/onnx/onnxmltools), (1.7.x)
keras2onnx (https://github.com/onnx/keras-onnx/)  (1.7.x)
onnxconverter-common (https://github.com/microsoft/onnxconverter-common)  (1.7.x)

tf2onnx seems up to date as well (https://github.com/onnx/tensorflow-onnx)
The latest version (1.8.5) added support for TF 2.5

It looks like onnxruntime supports ranges of onnx opsets:
https://github.com/microsoft/onnxruntime/blob/master/docs/Versioning.md#:~:text=Compatibility-,Backwards compatibility,range [7-9].
So its not linked to specific version of the onnx package.

versioning for onnx:
https://github.com/onnx/onnx/blob/master/docs/Versioning.md

so maybe we can settle on having the following in 1.3:

onnx 1.6 and 1.8.1 (opset 11 and 13)
onnxruntime 1.6
onnxmltools 1.8
onnx-converter-common 1.8.1
tf2onnx 1.8.5 (tf2.5 support)

Forge does have an onnxruntime recipe now:
https://github.com/conda-forge/onnxruntime-feedstock


Generate Swift module maps during the build

This moves generation of module maps for Swift targets into the build process.
rdar://89082987

Continuation of https://github.com/apple/swift-package-manager/pull/6983

@swift-ci please test

@swift-ci please test package compatibility

fatal error: module map file '/home/build-user/build/buildbot_incremental/unified-swiftpm-build-linux-x86_64/x86_64-unknown-linux-gnu/release/llbuildBasic.build/module.modulemap' not found


Addition of and support for Traffic Management plugins

This consists of extending the plugin mechanism of the Wasabi UI to support a top level Plugins tab.  Plugins can be configured that will contribute at that level.  Configured plugins will result in a description appearing on the Plugins tab and a Run button.  When the button is pressed, the UI contributed as the plugin is displayed in a dialog.
This pull request also includes some backend changes to add an API for getting daily actual percentages assigned to experiments.  This is used by one of the included plugins.
The included plugins are a Traffic Management UI and a Traffic Analysis UI.  The Traffic Management UI can be used when you have several mutually exclusive experiments and you want to achieve specific percentages of actual traffic for each.  The Traffic Analysis UI is useful for confirming that you are achieving those percentages.  The code for these plugins (and the configuration and a README) is in the contrib folder.

BTW, thanks for doing this review, @AndreaSuckro !!!

Coverage decreased (-0.2%) to 64.215% when pulling 0cd7267c8c489c3e6453a659bbef3b618dff02b3 on feature/ui_traffic_management_plugin into 8a9fc2a619eec5e96e77114ab5d6bc1908c76002 on develop.

Coverage decreased (-0.2%) to 64.215% when pulling 45c6847acbe081c0bd48cb9d6a3222dbc0033a96 on feature/ui_traffic_management_plugin into 8a9fc2a619eec5e96e77114ab5d6bc1908c76002 on develop.


Fix fbeta_score caculation

Before we compare with 0, we need call K.eval to get the result

This contribution (fbeta_score & co) is getting removed in Keras 2 (maybe even earlier). It's both flawed both conceptually and implementation wise. And while the issue you intend to fix is very real, your proposed fix isn't satisfying either; one should call eval on part of a graph while doing a forward pass.


main/master branch

micc2 create foo fails pushing to remote because it wants to push to main iso master...

fixed in v2.4.3


event monitor: allow configuring socket path on windows

What does this PR do?
The event monitor socket path is currently hardcoded and not configurable, this PR makes it configurable.
The end goal is to give the possibility of free-ing the port 3335 if needed.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


fix(gateway): defer queued commands until sent Resume

Originally reported in the Discord suport server, see the commit messages for implementation details.

I'll merge this as is for now, we can always come up with a cleaner solution later and a lot of this has already been refactored in next. Having the fix in main for now is the more important part, IMO.


Multi SSO - allow to pass SSO ID for sso start method (breaks compilation)

Description
Multi SSO - allow to pass SSO ID for sso start method, only relevant when using Multi SSO.
This breaks complation.
Related to https://github.com/descope/etc/issues/2119
Must

[x] Tests
[ ] Documentation (if applicable)

@aviadl


"darkmode" param doesn't do anything

When I set this param in config.toml:
[Params]
  darkmode = true

Nothing happens. Dark mode is not applied to the theme.
I am using Hugo v0.100.2.
Of course, I can overwrite the CSS myself, but it would be nice if this param worked.

How strange! Your site is white in my browser.

This is happening in both Firefox and Chrome.

I guess the current style file sets dark-mode only if your OS settings follow dark-mode

Maybe I should change this behavior so that you can use dark-mode on your website even if you don't wanna use dark-mode on your OS...

Ah, yeah, this Firefox setting fixes the problem:

Nevertheless, now that I know what was causing it - I think this is a really cool feature! Thanks for the help!


[Features Request] Search Bar

If possible, Please add search bar in top or bottom for find app quickly.

A search bar has already been implemented, but it's enabled by default only for devices with hardware keyboards.  If you go to General settings -> Search bar visibility, you can enable the search bar for software keyboards as well.

Yes, Got it. Thank you so much.