@dblandin => [SearchBar] Resolve AB test in favor of new search bar from Reaction

Woo!
Closes https://artsyproduct.atlassian.net/secure/RapidBoard.jspa?rapidView=57&projectKey=DISCO&modal=detail&selectedIssue=DISCO-943

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Type 'AnalyticsPartnerStatsType' was removed
:warning: Type 'AnalyticsPartnerTimeSeriesStatsType' was removed
:warning: Field 'Query.analyticsPartnerStats' changed type from 'AnalyticsPartnerStatsType' to 'AnalyticsPartnerStats'
:warning: 'AnalyticsArtworksPublishedTimeSeriesStats' object type no longer implements 'AnalyticsPartnerTimeSeriesStatsType' interface

  Generated by :no_entry_sign: dangerJS against 8e5f19ba163b6068e3263ac61e797d5b6d40a54a


Update validation_include.md

Docs Build status updates of commit 893467a:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 893467a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

MarkdownValidationTest/validation_include.md
:warning:Warning

Details

MarkdownValidationTest/validation_include.md

Line 11: [Warning] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
[Suggestion] Invalid value for ms.author: 'jasoz__' is not a valid Microsoft alias.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


refactor: backend amplitude use cognito ids

Description
Changes backend amplitude tracking to use cognito ID.
Fix ZEN-208

Tables in dev and prod have been updated, should be safe to merge.


feat: add package for jest jsdom polyfills

This adds a new package called @inrupt/jest-jsdom-polyfills which works around jest-environment-jsdom not having certain Web APIs that we depend on being available, as they haven't been implemented in jsdom
For instance the TextEncoder / TextDecoder APIs: https://github.com/jsdom/jsdom/issues/2524
We also rely on the File / Blob APIs, which aren't supported across all node versions / platforms, so we polyfill those if they don't exist.
Eventually, this package will be deprecated, but for now, it saves us a lot of repeated work.

I've tested this package on both AMI and @inrupt/solid-client-access-grants, and in both cases the tests work as expected.

@ThisIsMissEm Did it cause any performance issues, i noticed my tests run slower, but atleast it got rid of the error

@hawk-ahmed-matar this is just if you're running your tests in jsdom, if you run in node, then they'll be faster but maybe not accurate to a browser environment (but arguably, jsdom isn't a browser environment either, so, ymmv)
This package just provides the polyfills for a jsdom environment to run our tests, which depends on certain browser APIs not implemented in jsdom


Cleaned up HTML, started list fix

Most of the changes I made are not visible on the web page.

I added targets to all of the anchor tags, so links would open in another tab.
I removed unnecessary white space from HTML document.
Added sections with class names for better organization, fixed indentation.
In an attempt to understand the alignment of the lists at the bottom of the page, I added class names, changed display type and alignment.
Added borders just for testing purposes, but don't hate how they look! I left them in for now.

Open to feedback!

This is nice, everyone likes clean and well-formatted code, thanks!


[Result-list] Show a highlight for all listed features in the map

As a user I want to see a graphic highlight for all features in the result-list table.
Acceptance criteria:

If any data is displayed in the result-list table, the corresponding geometries of the features are shown as graphic highlights in the map.
The highlight should be independent from other highlight in the map. For example, result-list highlights should not be removed if a search is performed or a search result is deleted. However, it is desirable to use the highlight logic implemented in the MapModel (needs to be adjusted).

Out of scope:

highlighting of hovered features
highlight style configurable
highlighting of selected features (see #15)

Info: Zoom ist handled in #240

highlightOptions must be configurable via props
it must be possible to disable highlights completely

PR 295


Adding Crew.co

Hey!
Hopefully this works this time, I added Crew, if this looks okay, I've got 3 more to add, and I can probably help flesh out some of the examples

Thanks! This looks great. Unfortunately I created a conflict for you but it should be really quick to resolve, i'm sorry about that. Do you mind resolving real fast so I can merge? Also, I'd love having you submit the other companies, that would be great.

hahah @jessicard, that's 2/2 for conflicts, go me! hah.
I'll get that sorted now.

@dougaitken The conflict was my bad :) Thanks for adding this 2nd profile! I don't see Crew in the list now - mind adding it and I'll merge this in?

Utter facepalm. I guess I deleted it when trying to sort the merge conflict. Should be all good now!

Woohoo! :) Thank you so much!

hahah finally! You're welcome :+1:


[AutoPR containerregistry/resource-manager] [ACR] Adding scopemap spec file for new SDK build

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7175

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/6915


Feature/jjjermiah/doc update

This is just a small typo fix.
Working on a fix for https://github.com/snakemake/snakemake-executor-plugin-kubernetes/issues/19 and eventually ended up at the following error when deploying to kubernetes:
Error: Error when applying default storage provider gcs to upload workflow sources. {query_validity}

Fixing this here so the error is more clear since it looks like kubernetes uses the docker container from main.

this was the wrong pr. sorry, ignore


send user to /chat/{room_id} instead of /chat

That probably necessitates saving the user's most recent room, or alternately I could start by just sending them to the default room?

lol filed this on the wrong repo


Make results list fetch repeatedly

Need to make iron-ajax call repeatedly on a schedule. Use something like this:
ready: function() {
    var _this_ = this;
    function() { this.ajax_list.generateRequest(); }, 5000)
}

This is possible, but ideally it would run using Polymer's async method (see this example: https://stackoverflow.com/questions/37459936/polymer-iron-ajax-interval-calls). Unfortunately, this method isn't available on the dom-bind element that we're currently using. Possibly the right approach therefore is to see whether we can rebuild to not use dom-bind but rather to include the results list within a custom Polymer element.

Thinking about it, this may actually be a good approach to follow in general to avoid code re-use. We're going to want to display results in a very similar format in several different places. We ought to be able to pass in configuration information for how to display, and then fetch from the API.
Some questions arise though:

Can we pass in parameters from, for example, a search box elsewhere on the page? I'm assuming yes, but need to work out how.
How much variation will there be in the data fetch? We generally want to try and minimise the amount of data sent via the API. Can we make this one component work fine for the main results list, and also for #20 ?)
Are we using dom-bind for anything else that's not this?


Callback Handler Request: on_file_delete and giving the user name on disconnect

It would be nice to have more callbacks available. I am watching the users file systems and want to run filters under certain conditions.
One of the goals is to (re)-build a HTML audio player from a user uploaded directory of audio files. To keep that up to date I need to check more than just file uploads.

on_file_delete is self explanatory. If the user deletes an audio file I need to rebuild the player

For performance reasons I could rebuild the player not on actual file changes but simply when the session ends. on_logout however is not a good choice because popular FTP clients (like filezilla) use only disconnect, not QUIT.   Seeing that the log already tells me which user disconnected I see the possibility to receive a username on_disconnect

While I am at it.  You could provide the username on each callback. It doesn't hurt to know e.g. which user uploaded a file. I can do some python os.path magic to get the user from the path, but why not going the direct route?

From the handler class you can reference the username by using self.username attribute.


typo(Makefile): fix a typo in coverage-view-patch target

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixing Terry's catch of my typo: https://github.com/aws/eks-anywhere/pull/3607#discussion_r991543628

/approve


[Bug] stickyScroll error on typing: Uncaught (in promise) Canceled: Canceled

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.37.1#XQAAAAKBAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzkkPG_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKimARHSWlrTPOQHROITHxmAeYKfLDdH8LkPzUBgZk1U7SLZC8tGbBa1yLVLtif8cDToHobxwkjz-4durD5j19ZYKDjFAIjO1pDjG-gKPz1nNNcBQyeXpJ5axNt-oumRBF61AZ-7xlfmuWvgCMKC8vpzhutnxFmnpKZ6PJvzfFaRPinZweRknYIg273LpUN4o36u1FBu20V5_FONoW-ET1jaU4im_CABmHIIvumxHw2YlSXDFbTt18WswTvZFcYjgza5c1GO7_-LZ1CA
Monaco Editor Playground Code
Any sample and add this to options: `stickyScroll: { enabled: true }`

Reproduction Steps

Enable sticky scroll
Type q w e
Errors should spawn (with delay / debounce) in console

Actual (Problematic) Behavior
Throws aync cancel error
async.ts:271 Uncaught (in promise) Canceled: Canceled
    at Delayer.cancel (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:45015:89)
    at Object.dispose (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:145333:94)
    at dispose (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:4885:27)
    at DisposableStore.clear (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:4968:17)
    at StickyModelProvider.<anonymous> (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:145328:29)
    at Generator.next (<anonymous>)
    at https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:102:71
    at new Promise (<anonymous>)
    at __awaiter (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:98:12)
    at StickyModelProvider.update (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/dev/vs/editor/editor.main.js:145327:20)

Expected Behavior
No response
Additional Context
It IS reproducible in vscode.dev also! But I had to check it to be able to submit this form

@cardalda you are right! it's still yields a lot of errors - I was too fast when I saw the new version and updated vscode ref.

@AndersMad , are you sure this bug shouldn't be filed at https://github.com/microsoft/monaco-editor ?

@cardalda I did - it was moved here by hediet the 13. of April (see "log" on this page).. it seems like it was fixed in vscode and made it to the vscode.dev site - and the monaco vscode ref was update after - but I spose the ref was for an "earlier" version :/

this is still an issue in version 0.41.0

@aiday-mar can you look into this? I think it should be easy to fix.

Will do so now


Make non-auth'ed webpages have reasonable metadata for Slack unfurling etc

The fastest solution might be via meta tags:
https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-know-about-unfurling-but-were-afraid-to-ask-or-how-to-make-your-e64b4bb9254

Unfurling (terrible name btw) will not work with angular js templating to my knowledge (previews never load js only meta tags), if you wanna do that then you can make these pages django templates but they won't work with angularjs as they do now after that

Why does it work with page titles, then? (Or it wouldn't work with a static indexing?)

closing, not possible using ng templates


Samplegen response handling spec: s/output_spec/on_success/

Also, better document the OutputSpec proto fields.

Codecov Report

Merging #2216 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2216   +/-   ##
=========================================
  Coverage     86.85%   86.85%
  Complexity     5145     5145
=========================================
  Files           457      457
  Lines         20459    20459
  Branches       2189     2189
=========================================
  Hits          17769    17769
  Misses         1920     1920
  Partials        770      770

Impacted Files
Coverage Δ
Complexity Δ

...gle/api/codegen/transformer/SampleTransformer.java
98.64% <100%> (ø)
16 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1ef90...c8dd5b5. Read the comment docs.

👍 like the print/define comments


Reduce and Right/Left align the reload button

It it massive right now and does not look good.
Also reduce the size and align the button to the left or right of the page.

Hey @srujandeshpande can i work on this

Sure


Implement ERC721 standard JSON outputs for easier media consumption/nft minting.

https://eips.ethereum.org/EIPS/eip-721
{
    "title": "Asset Metadata",
    "type": "object",
    "properties": {
        "name": {
            "type": "string",
            "description": "Identifies the asset to which this NFT represents"
        },
        "description": {
            "type": "string",
            "description": "Describes the asset to which this NFT represents"
        },
        "image": {
            "type": "string",
            "description": "A URI pointing to a resource with mime type image/* representing the asset to which this NFT represents. Consider making any images at a width between 320 and 1080 pixels and aspect ratio between 1.91:1 and 4:5 inclusive."
        }
    }
}

Also useful to justify storing all of our content on NFT.Storage


Add minimum documentation for GAPIC-only clients

Mark all ML clients alpha
Add the note of not supporting GAE on Java 7 for all gRPC clients

Fixes https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1801, https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1478

Coverage remained the same at 80.907% when pulling 96a4f827f0932e8c0e910d126d3729d493573905 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

Coverage increased (+0.2%) to 81.061% when pulling bc44d20c72d2a28523a937d5bbefaaafc0151a60 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

Coverage increased (+0.2%) to 81.061% when pulling bc44d20c72d2a28523a937d5bbefaaafc0151a60 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

Coverage increased (+0.2%) to 81.057% when pulling bc44d20c72d2a28523a937d5bbefaaafc0151a60 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

Coverage increased (+0.2%) to 81.061% when pulling bc44d20c72d2a28523a937d5bbefaaafc0151a60 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

@garrettjonesgoogle  PTAL

LGTM but I'd like @lesv to take a look too

Coverage increased (+0.2%) to 81.061% when pulling 8e39265639f6d5b1058947862d2c8a851bc54677 on shinfan:docs2 into baf7c229f5ec32e8240350a48319354fa62ea533 on GoogleCloudPlatform:master.

@lesv ping~

LGTM - I'm less than happy w/ CloudTrace, but it will do for now.  (I'd like it to self configure)


why cant get /health HTTP？

The FastAPI set the '/v2/health/live' to get the health of the server, but not '/health', It's hard for another platform to use?
How to add '/health' to get the health of the server?

Hi @KunWang123 , KServe API is following the predict api do you see any issue here? if you are using kubernetes probe, did you try this?


interpolateTransform should work on CSS transforms, too?

Related mbostock/d3#2507.

This should be pretty easy since the CSS specification says that the computed transform value should either be "none" or matrix form (e.g., "matrix(1, 0, 0, 1, 0, 0)"), and in the latter case that is trivially parsed to the a, b, c, d, e and f used for SVG transforms.
The tricky part is that there would need to be separate interpolators for CSS and SVG, since the former requires units for the translate (px), rotate (deg) and skewX (deg) commands.
Also, that code path would only work with 2D transforms, obviously. But we could always add an interpolateTransform3d in the future.


[QDRANT] Remove data source config from front

Closed by https://github.com/dust-tt/dust/pull/2453


Suggestion: select version

It would be cool if you'd add a dropdown with each major version to the website, in order to limit the available blocks in the palette - in my case, our bedrock server software only supports blocks up to 1.12 sadly, so some of the blocks that are suggested create gaps.
Neat program btw, you deserve more followers - shared as much as i can ;)

It's planned as a part of presets update (version & palette instead of just palette), not sure about Bedrock though (I only have Java Edition and that's where I'm getting assets from)
Also thanks for sharing, I really appreciate it :)

not sure about Bedrock though

Bedrock is pretty much on parity block- & texture wise now, older versions might just be a problem. I can probably generate the blocks.js for any bedrock version if you want, the only issue i see is the blocks having different (texture) names in bedrock

Well if you take in account textures, it would be cool to just import texturepacks in general aswell :D

1.14-1.18.zip
Bedrock uses a versioning system since 1.14, so i guess vanilla is 1.13. Still downloading and extracting older versions currently, but here is the current set
chemistry, experimental_vanilla_experiments, vanilla, vanilla_1.14, vanilla_1.16, vanilla_1.17.0, vanilla_1.17.10


sys::memfd additional flags related to the hugetlb filesystem support.

Ok will be adding for android however, preferably not enabling MFD_HUGETLB for FreeBSD since it is not supported (yet) I added a comment.


Add pandocomatic to ruby-packages (gem)

Description of changes

Add ruby gem pandocomatic
Pandocomatic is a tool to automate the use of pandoc. With pandocomatic you can express common patterns of using pandoc for generating your documents, using only the front matter of your markdown files and a general yaml config file.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/pandoc-omatic-and-filters-install-location-issues/18179/2

@GrahamcOfBorg eval
@GrahamcOfBorg build rubyPackages.pandocomatic


Add Tyson Nguyen

Add name to contribution list.

Hi  @TysonNguyen, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


OpacityLayer's document has Unexpected Error

See https://docs.flutter.io/flutter/rendering/OpacityLayer-class.html whose screenshot is as follows

It's back.


components: merge files components

closes https://github.com/zenodo/who-rdm/issues/71

Tests are failing in master branch as well


Possible to use spack in the browser similar to esbuild-wasm

Describe the feature
Would it be possible to use spack in the browser to bundle virtual files / URLs on the frontend? Ideally it would be similar to esbuild-wasm.
I'd love to be able to move from esbuild to swc but I'd rather not have to maintain two separate bundling methods for server/browser
Babel plugin or link to the feature description
No response
Additional context
No response

I think it's possible, but I'm not sure how the esbuild-wasm works.
Fetching URL is asynchronous, right?

Yeah esbuild only allows the async versions of the apis to be used

@brynshanahan did you get any further with this? I’d be keen to find out if this is possible


Need to update version of NETFramework references assemblies

https://github.com/Azure/azure-sdk-for-net/search?q=ReferenceAssemblies&unscoped_q=ReferenceAssemblies
You should update the version to 1.0.0 to fix the errors like:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2110,5): Warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Runtime". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.

Example failing build https://dev.azure.com/azure-sdk/internal/_build/results?buildId=299596&view=logs&j=f4a2bb40-7e70-5f50-d570-7d7c5c8ca123&t=5f2c46ea-2ba4-5250-6248-51f1edb0a119

@isra-fel  .. This is blocking publishing any new nuget. Please treat this issue with highest priority

Thanks for the suggestion Wes! I'll submit a PR later


ndk-build binary cannot be found

Description

Attempting to use my own fork for an Android patch located here: https://github.com/jpshelley/react-native/tree/0.39.0-AndroidSupportLibrary25.0.1
Performed all the steps in https://facebook.github.io/react-native/docs/android-building-from-source.html
Downloaded the correct NDK android-ndk-r10e and is set in my $ANDROID_NDK and $ANDROID_NDK_HOME and local.properties file.
I do have a second module in my project that is a library module but there should be no reason it interferes.

HOWEVER. I keep getting the error mentioned in the title its coming from https://github.com/facebook/react-native/blob/master/ReactAndroid/build.gradle#L178
And my fork actually fixed a previous bug that couldn't find the sdkHandler property so I have an if check in place for that in my fork, now I ran into this bug.
Reproduction

Attempt to create a new React Native project react-native init MyNewProject
Change the react-native dependency: npm install --save github:jpshelley/react-native#0.39.0-AndroidSupportLibrary25.0.1
Try to import the android folder into Android Studio 2.3.3

Solution

Figure out why its not picking up either the $ANDROID_NDK or the local.properties file..

Additional Information

React Native version: 0.39.2 -> https://github.com/jpshelley/react-native/tree/0.39.0-AndroidSupportLibrary25.0.1
Platform: android
Operating System: MacOS

Can you run the Android integration tests on your machine? Try pulling master and running the integration test script - I added some more checking-what's-wrong-in-your-config logic there and maybe it will help.

@lacker When running the ./scripts/validate-android-test-env.sh script which unit and integration rely on I get the following:
Error: we can't use this Java version.
Currently, Java runs from /usr/bin/java.
The operating-system-provided Java doesn't work with React Native because of SIP protection.
Please install the Oracle Java Development Kit 8.
Check out http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html .
Be sure that you set JAVA_HOME and PATH correctly.
After installing Java, run 'buck kill' and 'buck clean'.

When I run java -version I get:
java version "1.8.0_111"
Java(TM) SE Runtime Environment (build 1.8.0_111-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode)

which java does return /usr/bin/java which as the script shows is what causes the error. I do have my $JAVA_HOME set correctly and as you can see the version it picks up is correct ^^
However, I think that might be a false check because it is a symlink http://stackoverflow.com/a/18144853/1784299
Am I missing something in my JAVA setup, or should that script be updated somehow?
(Running MacOS 10.12.1)

It's entirely possible that this script is missing an edge case - I tried it out on a few machines but the nature of this is that there's a zillion edge cases.
So, are you running the version of java that came preinstalled with OS X or did you install Java separately? The preinstalled version is Java 8, but it's modified in some way that makes it incompatible with building React Native from source, so you actually do need to install the JDK separately.

@lacker understandable. And no I installed the JDK from Oracles site and is now located at /Library/Java/JavaVirtualMachines/jdk1.8.0_111.jdk/Contents/Home even though my which java command shows otherwise.

Mmm, I see. Do you know of a better way to detect whether it's the right binary? - it seems like ideally that script would not just be checking for /usr/bin/java.

@lacker

I was able to get past the java related issues
I did have an error in my fork after running the integration tests script
Fixed the error and pushed my changes -> https://github.com/jpshelley/react-native/commit/0c868391485bad05a68300795d2e7b2c20cca135
Ran rm -rf node_modules/; yarn cache clean; yarn to get the latest commit from my fork
Invalidates caches in Android Studio and restarted, however the same error occurred:

Error:(181, 0) ndk-build binary cannot be found, check if you've set $ANDROID_NDK environment variable correctly or if ndk.dir is setup in local.properties

It is also worth noting that react-native run-android works completely fine and I was able to get it running on an emulator. So it seems to be an issue with Android Studio potentially.

@lacker Found the cause. Pulling in my fork works great from a new project that was created from react-native init ..., however when Using Studio it offers to upgrade the gradle plugin and wrapper and that is when the ndk-build binary cannot be found appears.
So something has broke since the gradle plugin has updated.
References:

The project worked on the initial creation and inclusion of the fork: https://github.com/jpshelley/ReactNativeExampleForkedProject/commit/796ee2de089efcab36a637a41c40721be84b7e94
The project then started getting the failure when I updated Gradle:

Working Gradle:

classpath 'com.android.tools.build:gradle:1.3.1'
distributionUrl=https\://services.gradle.org/distributions/gradle-2.4-all.zip

Broken Gradle:

classpath 'com.android.tools.build:gradle:2.3.0-beta1'
distributionUrl=https\://services.gradle.org/distributions/gradle-3.2-all.zip

Any help would be appreciated but I'll keep digging once I get more time.

@lacker as an update I was able to update to the following:

Gradle Plugin: classpath 'com.android.tools.build:gradle:2.2.3'
Gradle Wrapper: distributionUrl=https\://services.gradle.org/distributions/gradle-2.14.1-all.zip View

And it works again. Must have a bug in gradle 2.3.0+

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


Fix broken links and build suggestions

Fixes #34609.
@BillWagner This also updates the C# language reference index page to match what's in that section (removed all specification links).

Internal previews
Toggle expand/collapse

📄 File
🔗 Preview link

docs/architecture/cloud-native/relational-vs-nosql-data.md
Relational vs. NoSQL data

docs/architecture/microservices/microservice-ddd-cqrs-patterns/domain-events-design-implementation.md
Domain events: Design and implementation

docs/architecture/microservices/microservice-ddd-cqrs-patterns/microservice-application-layer-implementation-web-api.md
Implement the microservice application layer using the Web API

docs/architecture/modern-web-apps-azure/common-client-side-web-technologies.md
Common client-side web technologies

docs/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only.md
System.Drawing.Common only supported on Windows

docs/csharp/language-reference/builtin-types/value-tuples.md
Tuple types (C# reference)

docs/csharp/language-reference/index.md
C# reference

docs/csharp/language-reference/operators/is.md
is operator (C# reference)

docs/csharp/language-reference/operators/patterns.md
Pattern matching - the is and switch expressions, and operators and, or and not in patterns

docs/csharp/language-reference/statements/selection-statements.md
Selection statements - if, else, and switch

docs/orleans/resources/links.md
External links for .NET Orleans

closing and reopening for a fresh build

I'll watch when I next remove some of the feature specs. I ran cleanrepo to update the links, but it didn't find these. Do you think it's because of the dependent repo? Should I search for these by hand?

Yes, cleanrepo ignores links that start with ~.


Upgrade tokio_core dependency to use tokio 0.1

https://github.com/tokio-rs/tokio-rfcs/pull/2
BREAKING CHANGE
The needs_* methods has been removed as PollEvented do not have them anymore
The crate now uses the tokio crate instead of tokio_core
Some methods now require &mut self
Implementations of [Async]Read/[Async]Write on & references have been removed
Implementation of the (repreceated) tokio_core::io::Io trait has been removed.

Thanks for doing this.
I would like to hold off on this for a little bit. Ideally, these libs would not depend on tokio directly. I plan on splitting out the reactor into a separate crate, and then tokio-uds can be updated to depend on that crate.
I should be able to get that work shipped pretty quickly (ideally this week).

No, rush at all. Just one of these changes that are just as easy to send a PR for as they are to open an issue.

Since the last update on tokio, it would be awesome if this would work with the current tokio version.

@ufobat Partially moved the code over to use tokio and futures 0.2-alpha. There are parts of tokio that is not yet updated to work with futures 0.2 yet however so can't complete it yet.

thank you!

Thanks for updating the PR! Let me take a look at this now.

@Marwes Would it be possible to add an unstable-futures feature flag here as well?
Basically, follow the pattern that tokio-tcp takes? https://github.com/tokio-rs/tokio/tree/master/tokio-tcp

@Marwes Would it be possible to add an unstable-futures feature flag here as well?

Sure. I will look into it tomorrow.

@carllerche It should be good now I think but I may have accidentally messed up something as I were restoring the old impls.

ping @carllerche

@Marwes Thanks for doing this. Sorry for the delay. I did a quick pass but I will have to focus on it more tomorrow. I will try to leave some quick inline notes.
The first thing that stands out is that there are a number of unrelated changes that make the PR harder to review. I will try to point them out inline. Would it be possible to revert those for this PR?

@carllerche Sorry about the rustfmting, I broke it out to a separate PR #32 . Diff without that commit at https://github.com/tokio-rs/tokio-uds/pull/29/files/c6826ec86c5b6f6f831516ba044521ac52190900..14e9c084691cd6ece741ecc8d0adc676a23b3c3e .

The tokio-reactor = { features=["unstable-features"] } bit seems wrong, it should be changed to unstable-futures = ["futures-core", "futures-io", "futures-sink", "tokio-reactor/unstable-features"]?
Also the futures-* deps can probably be updated to final 0.2.0 versions, which are now released.

Broke out the tokio 0.1 support into #36.

I'm going to close this as most of the important work has been landed via other PRs. Thanks again!


Enum Export Variable breaks Resource in inspector after restart

Godot version
3.3.2.stable.mono
System information
Windows 10
Issue description
I am trying to create a "public" enum that is accessible in multiple scripts.
Therefore I created a script "Enums.gd"
This contains my Enum I want to use in different other scripts
enum StoryTriggerCondition {
	default,
	pickup_coin,
	kill_chilli,
	talk_to_B_urrito,
	talk_to_Patua_Pechos,
}

I e.g. use it in my "StoryBlock.gd" Script and preload it like this:
extends Resource
class_name StoryBlock

const ENUMS = preload("res://Scripts/Enums.gd")

export(Array, ENUMS.StoryTriggerCondition) var conditions

If I then create a instance of my Resource it works as I expect it to do:

However,after restarting the Editor it looks like this:

The fix is to force reload the depending "StoryBlock.gd" Script like this:

Steps to reproduce
As described above. I have stripped down my project as far as I could before it stops working. I really can't tell what the issue is with it.
IssueProject.zip
Minimal reproduction project
I created a minimal "reproduction" project. However in that it is working without any issues. I can't tell where the issue is coming from.
ResourceIssue.zip

Is the topic:mono label correct? This seems unrelated to C#.

It's a problem with GDScript. Nothing to do with mono or the mono version of the editor.


Coin improvements

Codecov Report

Merging #17 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   84.52%   84.47%   -0.06%
==========================================
  Files          44       45       +1
  Lines        1771     1765       -6
==========================================
- Hits         1497     1491       -6
  Misses        274      274

Impacted Files
Coverage Δ

Sources/Bitcoin/BitcoinAddress.swift
75.67% <ø> (ø)
:arrow_up:

Sources/Coin.swift
100% <100%> (ø)

Sources/PrivateKey.swift
78.26% <100%> (-1.74%)
:arrow_down:

Sources/Ethereum/EthereumAddress.swift
89.74% <100%> (-1.37%)
:arrow_down:

...eum/Solidity/ENS/ReverseResolverEncoderTests.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680570c...739a6a8. Read the comment docs.


Installation documentation incorrect

The documentation here says to install via bower with this command:
bower install --save angular-xtform
...but I'm pretty sure it should be...
bower install --save xtform

Actually scratch that, xtform seems to reference an older version.

...but that above command still doesn't work. Is the {{bower.json}} file correct?


[OpenCL] interpolation & decimation

Provide interpolation (nearest/bilinear) and decimation (Lanczos2/3) functions and a couple of kernel using them.

Besides sending a data buffer, will it be possible to have as input already existing OpenGL textures too? That would be great.

On Fri, 06 Oct 2017 05:34:22 +0000 (UTC)
V. Armando Solé<EMAIL_ADDRESS>wrote:

Besides sending a data buffer, will it be possible to have as input already existing OpenGL textures too? That would be great.

I don't know if one can copy a texture to a buffer (beside copying pixel by pixel). I need to investigate.

I don't think you can do a conversion between texture and buffer without a copy, but the copy can be done on the device (with cl_khr_gl_sharing extension).


chore: better way to open notepad

This way notepad will open on everyone's computer 🙂

Issue no #19


Add recursive search for repos

A suggestion from a user: the interactive mode should have an option to search for repos in subdirectories. Should save a lot of typing.

@anatolystansler , this can be closed, right?
I think tab completion can be done via #138, right?


Add epidemiological and other predictive models

https://www.cdc.gov/coronavirus/2019-ncov/covid-data/forecasting-us.html


NIFI-9736 Improve TestRouteText to avoid intermittent failures

Description of PR
NIFI-9736 Improves TestRouteText.testPatternCache to avoid intermittent failures due to maximum cache size checking. Changes from Guava to Caffeine altered the cache eviction behavior, resulting in intermittent failures.  The current method fills up the cache, which is an expensive operation for testing. The updated method avoids filling up the cache and simplifies the test method.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

THanks @exceptionfactory looks good to me. +1 will merge.


Output Config Option Values in Canonical Case

This aligns the letter cases of the values in tsconfig.jsons generated by tsc --init and some diagnostics (e.g. TS1501, TS6046) with the autocomplete values provided to tsconfig.json in VSCode and other diagnostics with hard-coded target versions.
This should not affect anything related to value parsing.
Addresses https://github.com/microsoft/TypeScript/pull/55600#discussion_r1571605851.

For ecmascript versions I can sort of understand it, but I'm not totally convinced we consider "Node16" more canonical than "node16", "Preserve" etc, https://www.typescriptlang.org/tsconfig/#module
And so on.

I don’t know, I just completely sticked to the autocompletions provided by VSCode (except for a few subtle inconsistencies of lib values, which should be fixed in VSCode). So perhaps changes to the values should be made on the VSCode side synchronically.

The autocompletions in VS Code are just the ones from schemastore. Not sure any of us like those either 😄

Oh, I see. Wonder why we didn’t maintain one here or in the VSCode repo.
Anyway, may you give me a list of what should be kept and what should be discarded once there is a consensus on the letter cases? Do you prefer camel case to Pascal case?


Configuration key out of sync

It looks like to enable/disable mypy_ls plugin one needs to use this option:
pylsp.plugins.mypy_ls.enabled

while to toggle mypy_ls options one needs to use those:
pylsp.plugins.mypy-ls.live_mode
pylsp.plugins.mypy-ls.strict

Notice how the former uses underscore in mypy_ls while latter uses a dash.
This should be unified. Ideally to use underscore everywhere.

pylsp.plugins.mypy-ls.live_mode isn't even working for me. I'm seeing:
INFO - pylsp.config.config - Updated settings to {'plugins': {'mypy-ls': {'enabled': True, 'live_mode': None}, ...
...
DEBUG - pylsp.config.config - With configuration: { ... 'plugins': {'mypy-ls': {'enabled': True}, ...

and then live mode is stil on. Switching to the underscored key (in both plugin.py and my config) seems to do the right thing.

You've set live_mode to None so it would fall-back to default True then.
Try with "live_mode": false.
Also, maybe first try to verify whether "mypy-ls.enabled" or "mypy_ls.enabled" works for you. The effects of that are easier to see. The one with the underscore should be the only one working, from my testing.


Fix(grid): limit sticky columns max width

Todo:

[x] fix / add tests

don't forget to cherry once done


CI: K8sAgentPolicyTest Multi-node policy test validates fromEntities policies with remote-node identity disabled

Test Name
K8sAgentPolicyTest Multi-node policy test validates fromEntities policies with remote-node identity disabled Allows from all hosts with cnp fromEntities host policy

Failure Output
Cilium validation failed: 4m0s timeout expired: Last polled error: connectivity health is failing: Cluster connectivity is unhealthy on 'cilium-rxm99': Exitcode: 1 \nErr: exit status 1\nStdout:\n \t \nStderr:\n \t Defaulted container \"cilium-agent\" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init), install-cni-binaries (init)\n\t Error: Cannot get status/probe: Put \"http://localhost/v1beta/status/probe\": context deadline exceeded\n\t \n\t command terminated with exit code 1\n\t \n

Stack Trace
/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.19/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:453
cilium pre-flight checks failed
Expected
    <*errors.errorString | 0xc00136e980>: {
        s: "Cilium validation failed: 4m0s timeout expired: Last polled error: connectivity health is failing: Cluster connectivity is unhealthy on 'cilium-rxm99': Exitcode: 1 \nErr: exit status 1\nStdout:\n \t \nStderr:\n \t Defaulted container \"cilium-agent\" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init), install-cni-binaries (init)\n\t Error: Cannot get status/probe: Put \"http://localhost/v1beta/status/probe\": context deadline exceeded\n\t \n\t command terminated with exit code 1\n\t \n",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.19/src/github.com/cilium/cilium/test/k8s/assertion_helpers.go:157

Standard Output
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
Number of "context deadline exceeded" in logs: 0
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
⚠  Number of "context deadline exceeded" in logs: 18
Number of "level=error" in logs: 0
Number of "level=warning" in logs: 0
Number of "Cilium API handler panicked" in logs: 0
Number of "Goroutine took lock for more than" in logs: 0
No errors/warnings found in logs
Cilium pods: [cilium-5rfmp cilium-bmj26]
Netpols loaded:
CiliumNetworkPolicies loaded:
Endpoint Policy Enforcement:
Pod                         Ingress   Egress
test-k8s2-794579c97-4kxgb   false     false
testclient-2dqwt            false     false
testclient-tddsl            false     false
testds-glrnv                false     false
testds-mh79r                false     false
coredns-85fbf8f7dd-wtzx8    false     false
Cilium agent 'cilium-5rfmp': Status: Ok  Health: Ok Nodes "" ContainerRuntime:  Kubernetes: Ok KVstore: Ok Controllers: Total 39 Failed 0
Cilium agent 'cilium-bmj26': Status: Ok  Health: Ok Nodes "" ContainerRuntime:  Kubernetes: Ok KVstore: Ok Controllers: Total 29 Failed 0

Standard Error
Truncated

Resources

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/267/testReport/junit/Suite-k8s-1/21/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/
ZIP file(s):
319c881b_K8sAgentPolicyTest_Multi-node_policy_test_validates_fromEntities_policies_with_remote-node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy.zip

Anything else?
Hit three times in rapid succession: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/256/testReport/junit/Suite-k8s-1/20/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/ and https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/316/testReport/junit/Suite-k8s-1/22/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/

This was hit in #29640.

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.19/273/testReport/junit/Suite-k8s-1/19/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/

4e192946_K8sAgentPolicyTest_Multi-node_policy_test_validates_fromEntities_policies_with_remote-node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy.zip

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.19/281/testReport/junit/Suite-k8s-1/21/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/

5c4452a3_K8sAgentPolicyTest_Multi-node_policy_test_validates_fromEntities_policies_with_remote-node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy.zip

Hit in https://github.com/cilium/cilium/pull/29847 as well: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-4.19/304/testReport/junit/Suite-k8s-1/24/K8sAgentPolicyTest_Multi_node_policy_test_validates_fromEntities_policies_with_remote_node_identity_disabled_Allows_from_all_hosts_with_cnp_fromEntities_host_policy/


Unexpected token } in JSON at position 226

Hey, thanks for this awesome plugin. Any reason why I'm getting this unexpected token?
ERROR in ./src/index.tsx
Module build failed (from ./node_modules/dts-loader/lib/index.js):
SyntaxError: ~/kaoto-ui/tsconfig.json: Unexpected token } in JSON at position 226

Only thing I've done is install and add it, still on step 1. :)
Added my webpack.config.js for the host app, and tsconfig.json here: https://gist.github.com/kahboom/f771a5674d6f419f61c9c4e9ceeb51e7

Whoops, looks like I forgot to add baseUrl to my tsconfig.json.


fixing eoi issue

This addresses two issue:

Smarter forward seeking when looking for end of input (EOI) after receiving the start of input (SOI). Before it was just a fixed offset, which could cause issues if the forward skip missed the next EOI. The new approach uses half of the size of the last received jpeg (so the assumption here is that the input frames won't be widely different sizes, which I think is reasonable).
I had an edge case where ffmpeg split the EOI across two chunks. So the last byte of the previous chunk had the first byte of EOI and the next chunk started with the second byte of EOI. I've updated the logic to handle this case, and also the related case of where the SOI could be split (but that case was not something I've come across yet).

I've confirmed that this generates the expected number of frames in production now! I'm going to do a bit more testing, but I'm fairly confident that this works

@antoineMoPa perhaps another thing we could try is to use a different stream decoder: https://github.com/devongovett/jpg-stream

@antoineMoPa perhaps another thing we could try is to use a different stream decoder: https://github.com/devongovett/jpg-stream

If we switch, maybe we should go to PNG. Was there a good reason to use jpeg? We risk having more artifacts with jpeg.

@antoineMoPa perhaps another thing we could try is to use a different stream decoder: https://github.com/devongovett/jpg-stream

If we switch, maybe we should go to PNG. Was there a good reason to use jpeg? We risk having more artifacts with jpeg.

That's a good idea! Here's the png stream reader, which looks like a better implementation overall. It's using a state machine to read the stream (which I think is the better way of doing this). It's looks like Manu had identified this image2jpeg as something we could speed up in this ticket, which I'm pretty much addressing in this PR, but I think that ticket should be to refactor to use PNG instead.

Pushing this fix upstream: https://github.com/kevinGodell/pipe2jpeg/pull/13


Remove experimental Kyma addon

How to categorize this PR?

/area open-source
/kind cleanup
/priority normal
What this PR does / why we need it:
With this PR we remove the experimental Kyma addon again from Gardener as it was only added temporarily with #1754 and supposed to being removed again in the future. This future is now.
Special notes for your reviewer:
/assign @a-thaler
Release note:

The experimental Kyma addon has been removed from Gardener, i.e., the setting `experimental.addons.shoot.gardener.cloud/kyma` annotation has no effect anymore. Existing Kyma installations will remain deployed/untouched.

@gardener/dashboard-maintainers you could disable the Kyma addon when running with Gardener version is >=v1.9.0


UI: Add detail page for data source

The ask is support detail page of data source.
The experience is similar to feature detail pages: in data source list page, there is a details link for each row. Once the link is clicked, user will be redirected to detail page of data source. DataSource metadata and a list of features extracted from data source should be displayed here.

@blrchen
Please assign me

Closing as completed in PR #620


Revert "Update mta.sw.yaml"

Reverts parodos-dev/serverless-workflows#37

/lgtm

closing , need to keep the changes to output


Need support for keyword metadata within view models

The Tag model only has support for keyword title, description and key. Its a common requirement to have metadata on keywords, which should be available in the derived view models for components using these keywords.
It would be good if subclasses of Tag could be created with SemanticProperty decorators, which would enable the keyword metadata to be mapped to properties in the usual way.

+1

TSI-811 (internal issue ID for tracking purposes)

Fixed in DXA 1.7: introduced new (base) class KeywordModel which can be subclassed.


Helm URL with seanglover.com blocked by firewall

Describe the bug
Issue https://github.com/seglo/kafka-lag-exporter/issues/316 mentioned the helm repo URL is changed:

from https://lightbend.github.io/kafka-lag-exporter/repo (in v0.6.7)
to https://seanglover.com/kafka-lag-exporter/repo/ (in v0.6.8)

We have firewall rules that restrict the outgoing request from the Kubernetes cluster. The domain seanglover.com is not allowed. As such when installing or upgrading the helm chart, the operation failed with
 "https://seanglover.com/kafka-lag-exporter/repo/" is not a valid chart repository or cannot be reached: Get "https://seanglover.com/kafka-lag-exporter/repo/index.yaml"

To Reproduce

Setup firewall to block seanglover.com on the machine deploying the kafka-lag-exporter helm chart.
run helm install or helm upgrade

Environment

KafkaLagExporter Version 0.6.8
Version of 1.20.13

The above error is reported by Terraform v1.1.7 using Hashicorp helm_release, here is an example of Terraform config In case you are interested. Please note that this is a network problem which you can reproduce by simply running  helm install or helm upgrade. You don't need the Terraform overhead to reproduce the problem.
resource "helm_release" "kafkalagexporter" {
  name       = "Kafkalag-Exporter"
  repository = "https://seanglover.com/kafka-lag-exporter/repo/"
  chart      = "kafka-lag-exporter"
  version    = "0.6.8"
  namespace  = "mynamespace"

  values = [
    file("${path.module}/helm-values/myCustom_KafkaLagExporter.yaml")
 ]
}

Proposed Solution
kafka-lag-exporter is an open-source project. Would it be OK to use Github as URL instead of seanglover.com ?
Here is an example of open source helm repo URL using github: https://prometheus-community.github.io/helm-charts  which is used by the kube-prometheus-stack helm chart.

Hi Tri. You should be able to substitute the host with seglo.github.io . LMK if that doesn't work.

@seglo Still failed when replacing seanglover.com by seglo.github.io
However, this time, this could be our networking rules not allowing correctly github.io. Will keep you posted
 Error: looks like "https://seglo.github.io/kafka-lag-exporter/repo/" is not a valid chart repository or cannot be reached: Get "https://seanglover.com/kafka-lag-exporter/repo/index.yaml":

I see. Unfortunately I don't see a way to workaround this other than creating a separate GitHub org just for kafka-lag-exporter. An alternative to using the repository would be to download the chart and host it yourself either in an internal repository, or just reference the chart tarball directly.

Would it be acceptable to stop the redirection of the DNS records from domain seglo.github.io to domain seanglover.com ?

@tringuyen-yw I moved my website to another organization. You can now reference the chart repository with seglo.github.io.


improved See Also H2s

Docs Build status updates of commit a1340cb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-vm-tutorial-7.md
:warning:Warning
View
Details

docs-ref-conceptual/manage-azure-groups-azure-cli.md
:warning:Warning
View
Details

docs-ref-conceptual/what-is-azure-cli.md
:warning:Warning
View
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-configuration.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-learn-bash.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-cosmos-db.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-devops.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-hosted-apps.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-sql.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-storage.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-virtual-machines.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-variables.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/format-output-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/get-started-with-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/install-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-vm-tutorial-7.md

Line 52, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-network/network-overview'.
Line 53, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-machines/linux/overview'.
Line 54, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-machines/linux/imaging'.

docs-ref-conceptual/manage-azure-groups-azure-cli.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 15, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'How to manage Azure resource groups with the Azure CLI'.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-conceptual/what-is-azure-cli.md

Line 72, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'learn/modules/control-azure-services-with-cli/'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5999689:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-vm-tutorial-7.md
:warning:Warning
View
Details

docs-ref-conceptual/manage-azure-groups-azure-cli.md
:warning:Warning
View
Details

docs-ref-conceptual/what-is-azure-cli.md
:warning:Warning
View
Details

docs-ref-conceptual/use-cli-effectively.md
:bulb:Suggestion
View
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-configuration.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-learn-bash.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-cosmos-db.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-devops.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-hosted-apps.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-sql.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-storage.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-virtual-machines.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-variables.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/create-an-azure-service-principal-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/format-output-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/get-started-with-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/install-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/manage-azure-subscriptions-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/query-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-vm-tutorial-7.md

Line 52, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-network/network-overview'.
Line 53, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-machines/linux/overview'.
Line 54, Column 3: [Warning: file-not-found - See documentation] Invalid file link: './azure/virtual-machines/linux/imaging'.

docs-ref-conceptual/manage-azure-groups-azure-cli.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 15, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'How to manage Azure resource groups with the Azure CLI'.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-conceptual/what-is-azure-cli.md

Line 72, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'learn/modules/control-azure-services-with-cli/'.

docs-ref-conceptual/use-cli-effectively.md

Line 174, Column 47: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 175, Column 53: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 176, Column 57: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'cliversion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 176, Column 88: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f768b58:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-vm-tutorial-7.md
:warning:Warning
View
Details

docs-ref-conceptual/use-cli-effectively.md
:bulb:Suggestion
View
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-configuration.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-learn-bash.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-IoT.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-cosmos-db.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-data-share.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-devops.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-hosted-apps.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-monitor.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-network.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-sql.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-storage.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-reference-for-virtual-machines.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-variables.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/create-an-azure-service-principal-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/format-output-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/get-started-with-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/install-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/manage-azure-groups-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/manage-azure-subscriptions-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/query-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/what-is-azure-cli.md
:white_check_mark:Succeeded
View

docs-ref-conceptual/azure-cli-vm-tutorial-7.md

Line 52, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'azure/virtual-network/network-overview'.
Line 53, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'azure/virtual-machines/linux/overview'.
Line 54, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'azure/virtual-machines/linux/imaging'.

docs-ref-conceptual/use-cli-effectively.md

Line 174, Column 47: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 175, Column 53: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 176, Column 57: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'cliversion' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 176, Column 88: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'version' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Converted css to scss

@mariobehling @aayusharora i have converted css to scss.

Current coverage is 42.58% (diff: 100%)

Merging #827 into development will not change coverage

@@           development       #827   diff @@
=============================================
  Files                6          6
  Lines              735        735
  Methods             74         74
  Messages             0          0
  Branches           118        118
=============================================
  Hits               313        313
  Misses             422        422
  Partials             0          0

Powered by Codecov. Last update 8a4269a...121fd40


Question: Middleware possibilites

Do this has any middleware possibilities or will it have it in the future? Would be handy for realising a persistent store for example.

Of course you can, there is no documentation yet but a good example here https://github.com/didierfranc/react-waterfall/blob/master/src/helpers/devtools.js

So you are hinting that subscribe could be used to create a middleware? Or am I missing something?

Can middleware access the result (changeset to state) of current action?


[BUG] Intel Xe kernel driver warning from Mesa, not suppressed

When using the new Xe kernel driver for Intel GPUs instead of i915, the usual Xe warning is also displayed in fastfetch when opengl config option is enabled.

MESA: warning: Support for this platform is experimental with Xe KMD, bug reports may be ignored.

This warning is present everywhere when using the Xe kernel driver, but I guess it'd be nice if fastfetch could ignore it, since that kinda defeats the purpose. It cuts the logo too.
Screenshot:

Config:
{
    "$schema": "https://github.com/fastfetch-cli/fastfetch/raw/dev/doc/json_schema.json",
    "logo": {
        "padding": {
            "top": 2
        }
    },
    "modules": [
        "title",
        "separator",
        "os",
        "kernel",
        "initsystem",
        "uptime",
        "packages",
        "shell",
        "editor",
        "display",
        "de",
        "wm",
        "terminal",
        {
            "type": "cpu",
            "showPeCoreCount": false,
            "temp": true
        },
        {
            "type": "gpu",
            "driverSpecific": true,
            "temp": true
        },
        "vulkan",
        "opengl",
        "opencl",
        "memory",
        "physicalmemory",
        "swap",
        "disk",
        "datetime",
        "version",
        "break",
        "colors"
    ]
}

opengl value seems to be the culprit. Doesn't happen without it.

We already do that. Please provide the output of fastfetch --format json for debugging.

debug.log

Please test the dev build

Ok, I cloned the repo and followed the building instructions and ran ./fastfetch without installing.
No more warning. Thanks.
But I can't install the AUR version. It fails for me.


added aspect ratio parameter for graphs

i added a parameter for an aspectRatio for when someone does not want a 1:1 graph
maybe interesting for:

https://github.com/pyrochlore/obsidian-tracker/issues/34
https://github.com/pyrochlore/obsidian-tracker/issues/219
https://github.com/pyrochlore/obsidian-tracker/issues/190

Example Picture:

@woodworker Looks amazing - exactly what I was looking for, thanks! However I'm not much of a coder or versed in this realm. Is there any way of downloading the main.js, etc. files (the ones I gotta replace in my obsidian plugin folder) with this branch or modifications included? Seems like I can only download those in the "Releases" venue, because under the "src" File folder, I only see ".ts" files..

i created a "pre-release" in my fork that contains these changes - https://github.com/woodworker/obsidian-tracker/releases/tag/v1.10.9-aspect-ratio
just download the zipfile it contains the needed main.js

@woodworker works like a charm! thanks!

@woodworker thank you for your contribution

FYI this has just now been released (sorry for the delay between merge and release, I thought I might have something else to add to the release but decided it was better to release this as-is to get it out there). Again, thank you for your contribution!


Use the latest version of the Spring IO Plugin

This change is necessary to allow Spring IO Platform 2.0 to remove the platform-versions properties file that was deprecated in 1.1. To allow Spring Cloud Connectors's Platform compliance to be verified as part of Spring IO Platform 2.0's build and release process, I'd like this to be included in the version of Spring Cloud Connectors that will be in Spring IO Platform 2.0. That's currently 1.1.x, but it looks as if it might make sense for that to change to 1.2.0? If you have any questions, please let me know.

@wilkinsona We will be releasing 1.2.0 very soon, and I'd like that to be the version included in Platform 2.0. I'll merge this change and resolve #125 before releasing 1.2.0.

@scottfrederick Cool, thanks. I've opened https://github.com/spring-projects/spring-boot/issues/3443 to upgrade to 1.2.0. Platform 2.0 will inherit the version from Boot 1.3.


[bug] swap.rug.farm asks users to verify they are on app.rugenerous.exchange

This could cause users to think they're on the incorrect site and dissuade them from using the dex.

Thank you @timothyjlaurent , this is on our internal board as well and will keep you posted on this ticket once a deployment is done addressing this bug.

@keeano92 is this issue still relevant? I am not seeing this behavior so wondering if we can close this issue

@georgetherugger Yes this can be closed, this was also for the DEX and this was posted on the front-end which is the DAO. Wrong project altogether.


Add preliminary support for code coverage

This adds preliminary support for code coverage with Jacoco.
This will likely require some iteration before it's extremely robust. Ideally some of that iteration can happen in follow up work in separate PRs, since the code in this PR should mostly suffice for Scala centric projects.
I haven't tested this on any production codebases yet.

This looks like it's just flat out failing with the older version of Bazel. Hopefully the 0.22.0 build passes.

@softprops you did some work on this in the past, right? Do you have any time to weigh in on the PR?

I should add that I chose to implemented slightly different than the Java rules:
A provider is used to "swap out" regular artifacts for instrumented artifacts when they're finally needed. The intention was to be as lazy as possible, and avoid any risk of recompilation of Scala artifacts.
Conversely, the Java rules simply emit an instrumented artifact when coverage is turned out.

@andyscott can you give a quick overview of the approach? I did a quick scan, but I haven't been following the bazel coverage support. Can you help reviewers by providing some links for us to read on how that is supposed to work?
I'm very excited about this!

As far as I can tell, there's no public documentation on how code coverage works in Bazel. This implementation was based off of information I gleaned from:

JacocoCoverageRunner, which wraps the test runner and handles emitting lcov files: https://github.com/bazelbuild/bazel/blob/0.22.0/src/java_tools/junitrunner/java/com/google/testing/coverage/JacocoCoverageRunner.java
The java launcher template: https://github.com/bazelbuild/bazel/blob/0.22.0/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt
Kotlin + Jacoco in Bazel: https://github.com/bazelbuild/rules_kotlin/pull/52/files
Lots of git grepping through the Bazel repo :).

It's currently EOD for me. I can circle back next week and hopefully provide more info.

@iirina you are the Bazel coverage go-to person, right? Any chance you can
give us your 2c about why you chose your direction and what you think about
using a provider?
I think (not sure) that google are very cautious about adding a provider
due to the memory footprint this adds
On Sat, 16 Feb 2019 at 4:33 Andy Scott<EMAIL_ADDRESS>wrote:

As far as I can tell, there's no public documentation on how code coverage
works in Bazel. This implementation was based off of information I gleaned
from:

JacocoCoverageRunner, which wraps the test runner and handles
emitting lcov files:
https://github.com/bazelbuild/bazel/blob/0.22.0/src/java_tools/junitrunner/java/com/google/testing/coverage/JacocoCoverageRunner.java
The java launcher template:
https://github.com/bazelbuild/bazel/blob/0.22.0/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt
Kotlin + Jacoco in Bazel:
https://github.com/bazelbuild/rules_kotlin/pull/52/files
Lots of git grepping through the Bazel repo :).

It's currently EOD for me. I can circle back next week and hopefully
provide more info.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/692#issuecomment-464275598,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF9RYODBFPYuilUPvAINeulP93Ab7ks5vN23cgaJpZM4a-uiz
.

I skimmed the code and I’m somewhat worried about the cost of the aspect. @dslomov is there a way to achieve something similar to the aspect declaration on the attribute from command line? I tried using the regular syntax but it’s not the same

One idea (which I’m fairly certain is possible) is to add a flag to the scala tool chain and only do work in the aspect if the flag is on. This limits the memory part and probably most of the analysis perf cost (not sure how much an aspect with a lookup and empty array return costs)

It's pretty easy to remove the aspect and just conditionally emit an instrumented jar as the primary artifact.

Here is a recent PR on coverage in the haskell rules: https://github.com/tweag/rules_haskell/pull/699

Neither the usage of aspects not providers in this PR should add much to the memory footprint (it is O(size of build graph) and should not be much)
What might be problematic is any flattening of depsets but I do not see it occurring here.

Update: This PR works for us internally at Stripe. There seems to be an issue with the reproducibility tests, which I'll look into.
What steps do I need to take to get this to a mergeable state?

Sure thing.
Also, I totally did not mean to commit tools/bazel. I use it to easily
pin to various bazel versions, and I think it got picked up accidentally in
one of the recent commits.
I'll submit a formatting PR and then a new code coverage PR. If you want
the version pinning script, I can open a PR for that too (and configure CI
to use it).
On Thu, Feb 28, 2019, 19:01 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

@johnynek commented on this pull request.
This is very exciting and one of the biggest feature additions in quite
some time. Very nice work.
That said, I'd like to suggest two core changes:

split the PR into three PRs:
a formatting only PR that improves the formatting, but has no other
changes. I assume you used some tool to format it. Can we do that on master?
can we add this tools/bazel wrapper and a separate motivation for
it.
just the changes relating to code coverage with a minimum amount of
formatting change.
I request that you go ahead as part 3. include documentation in the
README as to how generate code coverage reports, a brief explanation that
there should be no additional cost to running tests in normal mode, and
also give some indication of how much longer you should expect the tests to
take with coverage enabled.

Thanks for taking this on.
PR: @ittaiz https://github.com/ittaiz I think you will want to take a
good look at this. I assume you all may be interested in providing code
coverage reports. I love to use them to make sure I am hitting all the
branches in my code in tests, without which I get nervous I have bugs
lurking.
In scala/private/coverage_replacements_provider.bzl
https://github.com/bazelbuild/rules_scala/pull/692#discussion_r261463231
:

+)

+_CombinedCoverageReplacements = provider(

fields = {

   "replacements": "hash of files to swap out",

},
+)

+# the attributes used to form the dependency graph that we'll fold
+# over for our aggregation
+_dependency_attributes = [

"deps",
"exports",
+]

+def _combine(*entriess, base = {}):
why entriess? Any meaning there?
In scala/scala.bzl
https://github.com/bazelbuild/rules_scala/pull/692#discussion_r261463736
:

 fragments = ["java"],

outputs = _library_outputs,

I'd prefer the style changes in a no-op PR so it is easier to review.
Mixing style and functionality in one PR makes it much harder to review
since I have to carefully inspect each change to determine which.
In tools/bazel
https://github.com/bazelbuild/rules_scala/pull/692#discussion_r261464424
:

@@ -0,0 +1,111 @@
+#!/bin/bash -e

what is going on here? This seems orthogonal. Any way we can make this a
separate PR?
In scala/private/rule_impls.bzl
https://github.com/bazelbuild/rules_scala/pull/692#discussion_r261464652
:

@@ -567,38 +583,73 @@ JAVA_EXEC_TO_USE=${{REAL_EXTERNAL_JAVA_BIN:-$DEFAULT_JAVABIN}}
)
return wrapper

-def _write_executable(ctx, rjars, main_class, jvm_flags, wrapper):
+def _write_executable(ctx, rjars, main_class, jvm_flags, wrapper, use_jacoco = False):
can we not have a default value, especially in private functions? It is
easy to forget to get all call sites otherwise. I'd rather be explicit on
all of them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/692#pullrequestreview-209407482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS8W4VVY-egjE3lGSVAjN87vT-xTC7Gks5vSJgfgaJpZM4a-uiz
.

This should be good to go-- it passes on 0.22.0. A fair amount of this functionality just won't work on older Bazel releases.

All tests are passing now with the exception of the reproducibility tests, due to JMH.

can you merge master? I was trying to get this green by rerunning the flakey test. hasn't happened yet.

@andyscott my understanding is that this does not change runtime of build, is that accurate?
I'm in favor of merge. @ittaiz do you have any objections?

It doesn't change the runtime.
For what it's worth, I'm part of the way through feature flagging the dictionary merge loops. I should have that commit ready soon.

@johnynek @ittaiz 👋 just a friendly bump on this one

Eager to see this one merged. Thanks everyone!

This looks great. Good work.
I'd like to merge. I'll give @ittaiz 12 more hours to speak up if he or Wix have any concerns.
Thanks for making it configurable (although I do have concerns we have underdocumented how to use all our different options here, and that is hurting adoption).

Thanks @ittaiz I’ll let @andyscott follow up tomorrow but merge so we can iterate.
Also Andy, it would be nice to make sure the README has good docs on how to use this. And also a blog post would be nice to consider Andy.

+💯 (although I would really appreciate the clarification if junit tests
indeed need more work like I think)
On Tue, 26 Mar 2019 at 7:07 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

Thanks @ittaiz https://github.com/ittaiz I’ll let @andyscott
https://github.com/andyscott follow up tomorrow but merge so we can
iterate.
Also Andy, it would be nice to make sure the README has good docs on how
to use this. And also a blog post would be nice to consider Andy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/692#issuecomment-476477333,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFxkoA-oxgsQvPlV5tQdfhOntC5l3ks5vaasSgaJpZM4a-uiz
.

Just saw these comments. I'll follow up this work week!

Is there any useful README documentation for getting started with rules_scala and code coverage or is the best place to discover that to look for coverage interfaces in the upstream bazel docs?


[CosmosDB] Create command doesn't support the full list of DB kinds

Description
The az cosmosdb create command doesn't seem to support the full set of database "kinds" that are available in the Azure portal. Namely, graph/gremlin, and key-value/Azure Tables aren't available via the --kind flag.

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: nightly
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here: nightly
OS Version: What OS and version are you using?
Answer here: macOS
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: bash

This is because the SDK has not been released which reflects the addition of these Kinds.

@moderakh to comment.

I added the dataplane. This is management api: @dmakwana Digvijay are you adding this?

Ack, I'll have a look at this

Until there is an officially supported command, an unofficial workaround could be to create the DB with --kind GlobalDocumentDB and then use az resource tag to create a tag called defaultExperience with value Table or Graph. I guess this may stop working at any time, but based on information described at https://blog.spectologic.com/2017/06/30/digging-into-cosmosdb-storage/ this seems to be the way how the Azure portal does it today.

Shouldn't this be solved by now?

The capabilities flag should be used in this situation --capabilities EnableTable
I think there is a documentation gap here as well as an update to the CLI to include EnableTable to show in any intellisense enabled editors.
az cosmosdb create
    --resource-group "foo" \
    --capabilities EnableTable \
    --name "foo-table" \
    --locations "West US"=0 "East US"=1 \
    --max-interval 10 \
              --max-staleness-prefix 200

Thank you for reporting this lack of documentation. As @grayjeremy mentions, you can select the account "kind" by adding a capability. This functionality is now documented through examples at: https://docs.microsoft.com/en-us/azure/cosmos-db/cli-samples


Look for the right yq; Check if it's the correct one

Similar to what was done in https://github.com/maistra/istio-operator/pull/654

Similar to what was done in https://github.com/maistra/istio-operator/pull/654


Fixes for SBOM build time generation

Fix for https://github.com/stackabletech/docker-images/pull/814
This includes missing patches for Omid, trino-storage, hbase-operator-tools and Phoenix, which currently cause some builds to break.

Yes, the copy/move commands are already present in the Dockerfiles. The last PR also contained patches for these products, but not for certain versions. The patches for these other versions are contained in this PR.


ObservationMannerOfDeath - Certifier Not Added to Resource Dictionary

When setting the Certifier property on an ObservationMannerOfDeath object, the code doesn't add the Practitioner to the resources dictionary, meaning I can't get the Practitioner item through the resources dictionary if needed. It should work similar to the SubjectAsResource setter on that object.

Practitioner resource is added to the resources dictionary.


Old Ghost Strips Div

We appropriated Casper 2.0 and plugged it into Old Ghost this morning; we have Ghost Pro and haven't been upgraded yet.
The div that's being stripped is this one:

It's causing things to align funny.
Locally, latest Ghost (1.0.2):

Production, Old Ghost (/shrug):

The solution is to "use the latest Ghost", but I felt it will be useful to have an issue open incase others discover it.

Hey @goodroot! This is known and Casper 2.0 was never intended to work with Ghost < 1.0. And yes, the missing Koenig editor in Ghost 0.11.x versions is the reason for the images and blockquotes being off.
I'm closing this issue, as it's not an issue with Casper because the minimal Ghost version for it is 1.0.


Job opportunity

Hi Hannibal,
My apologies for contacting you through your opensource project, but this is one method we use when headhunting exceptional talents on behalf of our clients within AI. I took a look through your work, and I am very impressed.
We are partnered with a US startup called Play.ht who have developed advanced text to speech technology to generate human grade AI voices from text in rapid time. After an incredibly successful launch they have over 7000 customers from small startups to enterprise level multinationals including SalesForce, Samsung and Verizon, content creators and video editors who can make use of 800 voices across 60 languages.
The three major use cases for their voice technology are video editing & voice cloning for post production edits, voiceovers for YouTube and video content, e-learning and training, IVR systems and audio accessibility. The platform decreases time for recording and updating and cost. Hiring voice actors is expensive and future editing is limited.
They are looking to scale their Engineering and Research team with Senior to principal level hires to build large generative LLM based models, end to end. You will be fully hands on building, training and deploying advanced voice models and deliver a human grade, context understanding speech product across two product areas, a library of over 100 ready to use voices and a text to voice editor API. To be successful in this role you will have previous experience building and training large generative models to deployment in a production setting at scale. Any experience in the TTS/ Voice space is a big plus but not essential.
In return you can expect a strong comp package including meaningful equity and a strong salary. You will also be one of the early team, responsible for bringing some of the most advanced and realistic voice products to market to be deployed across a number of industries and used worldwide.
This position can be fully remote, anywhere in the world, and you will work with a small, but rapidly scaling international team of world class engineers and developers.
Please can you let me know if you and I can organise a time to speak?
Here is a link to my LinkedIn profile - https://www.linkedin.com/in/jackdev/
And here is a link to my calendar - https://calendly.com/jackcubiq/20min

Thanks for reaching me. I'm truly flattered. But I am currently ready to pursuing a doctoral degree, so I am afraid I don't have much time for this job opportunity. Thanks anyway!

No problem at all, and thank you for letting me know.
Best of look in your PhD.
Do you have a LinkedIn profile? We could connect for future reference.
On Tue, 16 May 2023 at 08:04, Hannibal046 @.***> wrote:

Thanks for reaching me. I'm truly flattered. But I am currently ready to
pursuing a doctoral degree, so I am afraid I don't have much time for this
job opportunity. Thanks anyway!
—
Reply to this email directly, view it on GitHub
https://github.com/Hannibal046/Awesome-LLM/issues/33#issuecomment-1549104007,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A73VIBEP6XAESOLNVG3BBT3XGMRIPANCNFSM6AAAAAAYB6K5XA
.
You are receiving this because you authored the thread.Message ID:
@.***>

You could always find me here :)


Drilldown with parent links doesn't allow for proper use of keyboard 'Enter' key

How to reproduce this bug:

Create a basic drilldown component with data-parent-link set to true.
Add a valid href attribute to a submenu parent item.
Navigate to that parent item using keyboard. Press 'Enter'.
Navigate to the newly opened submenu parent item with a valid href. Press 'Enter' again.

What should happen:

When the submenu opens, the focus should be set on the submenu parent.
Pressing 'Enter' on the submenu parent item should take you to the location in its href attribute.

What happened instead:

When the submenu opens, focus is set incorrectly on the first submenu child.
Pressing 'Enter' on the submenu parent item makes it act like the 'Back' button.

Browser(s) and Device(s) tested on:
All browsers.
Foundation Version(s) you are using:
Any version. Codepen example is using 6.3.1.
Test case link:

CodePen with Foundation 6.3.1

Yup, that seems indeed like a bug. I will check this.


Not checking for curl.h in configure.ac

While working on #1150 I found this problem. On a machine without curl, the build fails like this:
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../libsrc4 -I/home/ed/local/hdf5-1.10.3/include -I/home/ed/local/hdf-4.2.13/include -MT libdap4_la-d4crc32.lo -MD -MP -MF .deps/libdap4_la-d4crc32.Tpo -c d4crc32.c  -fPIC -DPIC -o .libs/libdap4_la-d4crc32.o
In file included from d4crc32.c:43:0:
d4includes.h:19:10: fatal error: curl/curl.h: No such file or directory
 #include <curl/curl.h>
          ^~~~~~~~~~~~~
compilation terminated.

I will combine this with the HDF4 configure fixes and put up a PR shortly...

OK, one problem here is that the configure script is trying to be too clever.
The convention is that if you ask for something to be built, and it is not possible, the configure will error out. It should not just change options for you.
So right now, the build tries to build dap, but if curl is not present, it turns dap off. That may seem like a good idea, but it's not. A better idea is to error out and force the user to confront the issue. Either they need to install curl, or else build with --disable-dap. This decision should not be made by the configure script.

I recall this issue from some months ago. I guess I thought that the pr for it
had done a comprehensive set of changes to configure.ac to have the failure
behavior. Or did that pr never get merged?

I remember one more problem with this. In order to make this work in general, it
was necessary to know if the ./configure command explicitly set, for example, --enable-dap,
then an error should be reported. However if dap was defaulted, then it should just disable
dap without causing ./configure to fail. This was to protect naive users who did a default
build.
This caused a problem with cmake, because it was not possible using option() to tell
if the cmake command explicitly set an option or was defaulting. As I recall,
Wei-king solved this by using some other mechanism.

In my opinion, configure should error out if the user explicitly enables or disables a feature, but configure could not support it. Otherwise, configure can decide for the user (i.e. auto mode used in PnetCDF and MPICH). NetCDF prints all the settings on screen at the end of configure and users can also use utility nc-config to check all the features enabled/disabled.

For autoconf there is a clear convention which we are attempting to outsmart.
The question that has to be decided is exactly the default(==auto?) case.
If the user says nothing about dap, and libcurl is not accessible,
then what should be reported to the user?

fail
disable dap, give a warning, and continue.
Which of these is the convention you refer to?

@wkliao installers do not run ./configure --help and read all the output to see if any conventions are not being followed. Nor do they read the documentation before installing.
@DennisHeimbigner the build should fail without curl. User then can easily --disable-dap or install curl, whatever they wish. Failure message can offer them that choice. This is the simple and correct answer.
If I do:
./configure && sudo make install
It should either build correctly with all defaults, or error out in configure. It should not tell me it succeeded when it actually could not build everything.
Recall that many science users will have to ask sysadmins to install netcdf. The sysadmin will do so, and then the scientist will expect it to work. If not, that leads to back and forth with the sysadmin to try and figure out what is happening, wasting everyone's time. Printing a warning in the thousands of lines of output certainly won't be noticed.
We do not need to figure out a new and better way to use autoconf - we need to use it in the way everyone expects. This will be less work for us, less confusion for users, and less support for the netCDF team and all the sysadmins who need to install it for their users.