Fix memory leak in C demo.

Merging for a one-liner fix.  Also, I have run sanitizer with all the C API demos.


Roll Flutter Engine from 04191a122e9a to f8c79f9e20f1 (2 revisions)

https://github.com/flutter/engine/compare/04191a122e9a...f8c79f9e20f1
2024-03-25<EMAIL_ADDRESS>font_subset tests: name correct variant in exception (flutter/engine#51492)
2024-03-25<EMAIL_ADDRESS>Roll Skia from 8a587a10323f to 625d04f3a7c5 (5 revisions) (flutter/engine#51655)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


unable to install craftabble pro

Problem 1
- Root composer.json requires brackets/craftable-pro 2.0.0 -> satisfiable by brackets/craftable-pro[v2.0.0].
- brackets/craftable-pro v2.0.0 requires illuminate/contracts ^9.21|^10.0 -> found illuminate/contracts[v9.21.0, ..., v9.52.16, v10.0.0, ..., v10.48.18] but these were not loaded, likely because it conflicts with another require.

Hi, can you paste your composer.json file here? I wasn't able to reproduce your issue with a clean Laravel 10 and Craftable PRO installation. Thanks.

Since there has been no response, I am closing the issue for now.


Add Support for Dynamic batch size for Dense, Conv, Conv_transpose etc. Part II

This PR fixes the binary compute heavy/non-compute heavy calculation for dynamic conv, dense, batchmatmul which were earlier handled by mac_count.cc

cc : @anijain2305 @trevor-m @zhiics

THis is now a part of #170


ClickMoveAnimation OFF for Windows10

What's the Problem?

This seems to be a system behavior that was changed with Windows 11.

It can be inferred that it is difficult to correct if it is a movement peculiar to the system.
I hope someday it will be resolved. Thank you for your quick answer.


Change breakpoint via media query in CSS?

I wanted to ask if it's possible, or if not I guess it's a feature request, to be able to choose the breakpoint using CSS instead of needing to have it as an option in the JS?
An example of a library doing this is Flickity JS, where it has an option to watch the CSS. The carousel can be destroyed or initialised based on just adding..
.carousel::after {
   content: 'flickity';
}

or
.carousel::after {
   content: none;
}

To destroy it.
This helps keep the responsive logic of the breakpoints all in the CSS, so all the relevant styles can go with it inside the same media query.
It makes it very easy to work with multiple instances on the same page that all need different breakpoints and styles to go with it.

I found a way around it, I'll close this.


Bump ord-schema version

Migration to support proto changes in https://github.com/Open-Reaction-Database/ord-schema/pull/496 (reaction.proto diff)
Tasks:

[x] Remove Features from Compound (replaced with Data)
[x] Rename ReactionAnalysis -> Analysis
[x] Rename Reaction.workup -> Reaction.workups
[x] Support the new Amount message
[x] Support the new Source message
[x] Update Analysis fields
[x] Add ProductMeasurement to Product and remove deprecated fields
[x] Update test data
[x] Fix editor tests
[ ] Test this PR extensively
[ ] Migrate user data

Note that this version of ord-schema includes the old reaction.proto as reaction_old.proto to aid in migrating existing data.

@connorcoley @antonkast-google @n8kim1 Tests are passing. PTAL and test the GUI.

PS updated for ord-schema version 0.2.2
Questions/comments:

I only added support for mass in ProductMeasurement.amount to avoid cluttering the form.
For eic_masses, I'm not sure whether I should use a single field for e.g. comma- or space-separated floats, or add a button for repeated single-value fields?

TODO:

Update full.pbtxt to cover all new fields.

For eic_masses, I'm not sure whether I should use a single field for e.g. comma- or space-separated floats, or add a button for repeated single-value fields?

I think a single field for comma separated floats would be a much simpler way to define this repeated field
I'll try to review the interface changes this weekend, sorry it's been slow.

Thanks @connorcoley for all the good fixes. PTAL.

Thanks!

[x]  Workup "Input"s have huge font

Done. Although note that compounds added later will have slightly mismatched heading sizes since we don't have access to them here. We could be fancy about this but it's not jarring like this was.

[x]  Opening a new reaction, adding an outcome product, and using Ketcher causes one POST error to be printed in the console upon opening the window (reaction.js:51558 POST http://localhost:5000/ketcher/molfile 404 (NOT FOUND)) and upon hitting "done", another TypeError (reaction.js:54389 Uncaught TypeError: Cannot read property 'getElementsByTagName' of undefined). This seems to happen for all compound identifier fields, not just products.

Good catch. Multiple issues were fixed here:

Added a ReactionRole field to ProductCompound in the form (that was the source of the getElementsByTagName error).
Change the 404 response from /ketcher/molfile to 204 since a new compound has no structural identifiers and AFAICT 404 is always logged to the console regardless of any extra handling that might happen in JS.

Added a ReactionRole field to ProductCompound in the form (that was the source of the getElementsByTagName error).

Ah, that's very important!

For aesthetics, I would suggest promoting "is_desired" to that upper-most level as well (above the identifiers).
Perhaps the default reaction role for a product compound should be PRODUCT? Or do you think it's safer to keep it unspecified?
After playing around with it a bit, I think that some of the custom hide/show for measurement types might be too restrictive. For example, "counts" for an LCMS analysis could be referring to an integrated mass spec peak at a specific retention time, so we'd still want the retention time field. I could also see value in having "identity" allow a retention time to be defined, although it's not essential I suppose. PURITY could theoretically be calculated from MS but I have never seen that (nor would I want to). I'm not sure if I'm being too cautious here. I am a huge fan of this kind of interactivity but I don't want us to miss any edge cases and have a user get frustrated because they can't define their data the way they want to. @michaelmaser ?

Added a ReactionRole field to ProductCompound in the form (that was the source of the getElementsByTagName error).

Ah, that's very important!

For aesthetics, I would suggest promoting "is_desired" to that upper-most level as well (above the identifiers).

Done. I also made it so that this field is only visible if the role is PRODUCT (like we do with is_limiting for REACTANT)

Perhaps the default reaction role for a product compound should be PRODUCT? Or do you think it's safer to keep it unspecified?

I sort of like having it unspecified so users see the full list and can consider INTERNAL_STANDARD, etc. Do you agree?

After playing around with it a bit, I think that some of the custom hide/show for measurement types might be too restrictive. For example, "counts" for an LCMS analysis could be referring to an integrated mass spec peak at a specific retention time, so we'd still want the retention time field. I could also see value in having "identity" allow a retention time to be defined, although it's not essential I suppose. PURITY could theoretically be calculated from MS but I have never seen that (nor would I want to). I'm not sure if I'm being too cautious here. I am a huge fan of this kind of interactivity but I don't want us to miss any edge cases and have a user get frustrated because they can't define their data the way they want to. @michaelmaser ?

I broadened this a bit (added retention_time to IDENTITY and COUNTS). I agree that we should err on the side of showing more fields if they might be used. Also added some vertical spacing between sections.

Perhaps the default reaction role for a product compound should be PRODUCT? Or do you think it's safer to keep it unspecified?

I sort of like having it unspecified so users see the full list and can consider INTERNAL_STANDARD, etc. Do you agree?

I agree. I think it could help prevent unintended species from being added to the product list/reaction SMILES.

After playing around with it a bit, I think that some of the custom hide/show for measurement types might be too restrictive. For example, "counts" for an LCMS analysis could be referring to an integrated mass spec peak at a specific retention time, so we'd still want the retention time field. I could also see value in having "identity" allow a retention time to be defined, although it's not essential I suppose. PURITY could theoretically be calculated from MS but I have never seen that (nor would I want to). I'm not sure if I'm being too cautious here. I am a huge fan of this kind of interactivity but I don't want us to miss any edge cases and have a user get frustrated because they can't define their data the way they want to. @michaelmaser ?

I broadened this a bit (added retention_time to IDENTITY and COUNTS). I agree that we should err on the side of showing more fields if they might be used. Also added some vertical spacing between sections.

I agree with broadening flexibility to avoid restricting use. I agree with adding retention_time to both IDENTITY and COUNTS for the cases @connorcoley mentioned. I don't think there's a need for PURITY either.

I think it looks good enough to me to merge and start the data migration. I'd also be okay waiting until @michaelmaser has had a chance to stress test it a bit more, just in case both of us missed something obvious.

I took a look yesterday and had basically the same comments @connorcoley had, which have been addressed. I think it's okay to merge and start migration. Would minor adjustments later on be tolerable or require re-migration? Pardon my naivety, I am less familiar with the editor than the schema.

Thanks @michaelmaser

Would minor adjustments later on be tolerable or require re-migration? Pardon my naivety, I am less familiar with the editor than the schema.

Nope, the migration is only required for changes to the schema. One additional test we should do before deploying is making sure that the migrated data successfully round-trips through the editor; this will help us identify anything that we missed in updating the editor to match the new schema.


Option to disable SSL verification

Omniauth allows the disabling of SSL verification with something like:
:client_options => { :ssl => { :verify => !Rails.env.development? } }
Is there anyway to utilize this with OpenID Connect gem? I attempted to add the ssl key in the client_options hash but it didn't seem to have any effect.

Do you need to connect over untrusted SSL or do you need to connect over plain unencrypted HTTP? I wanted to do the latter, and I had to patch the gem the following way:
diff --git a/lib/omniauth/strategies/openid_connect.rb b/lib/omniauth/strategies/openid_connect.rb
index e4705c9..c915b61 100644
--- a/lib/omniauth/strategies/openid_connect.rb
+++ b/lib/omniauth/strategies/openid_connect.rb
@@ -16,7 +16,7 @@ module OmniAuth
         redirect_uri: nil,
         scheme: "https",
         host: nil,
-        port: 443,
+        port: nil,
         authorization_endpoint: "/authorize",
         token_endpoint: "/token",
         userinfo_endpoint: "/userinfo",
@@ -82,6 +82,11 @@ module OmniAuth
       end

       def request_phase
+        if client_options.scheme == "http"
+          WebFinger.url_builder = URI::HTTP
+          SWD.url_builder = URI::HTTP
+        end
+
         options.issuer = issuer if options.issuer.blank?
         discover! if options.discovery
         redirect authorize_uri

With these changes authentication proceeds over HTTP properly.

I was looking for untrusted SSL so I can ignore bad or untrusted certificates, etc.

Then I guess you have to patch lib/omniauth/strategies/openid_connect.rb yourself. As far as I can see there is no support of SSL disable in the gem currently.

Thanks, would you mind taking a look at #65 also?

If you are talking about ssl verification I think you should be able to take care of this with out patching the strategy.   The OpenidConnect lib has a static method setting up configuration blocks for the http_client.  I use it to deal with the SSL inspection that our internal network performs so I have to add additional ca trust certs for it to deal with like this.
OpenIDConnect.http_config do |client|
client.ssl_config.add_trust_ca(ENV['CA_TRUST_CERTIFICATE']) if ENV['CA_TRUST_CERTIFICATE']
end
The ssl_config object I believe also has a method for setting the verification mode so you should be able to just wholesale turn it off.

@cmrd-senya the strange thing for me is I am using this gem and my own provider locally in development with no problems over http.
EXCEPT for ONE app which is throwing this error here:
https://github.com/nov/openid_connect/blob/e351a063391ace825e9caa6661414d33beed9fdc/lib/openid_connect/discovery/provider/config.rb#L9
And it is due to the url_builder on SWD being set to URI::HTTPS but all of my other apps have it set to URI::HTTP.
Not sure what's wrong as all apps are using the same versions of Rails and gems and configurations in the devise initializer so it's very puzzling - I had to use a similar monkey as yours to force openid_connect to use http instead of https for this one app that won't seem to cooperate.
To be honest I don't even know how my other apps are automatically using the HTTP version of the URI class but they just do.


OpenAI o1 pricing

Hi, Can we get openai o1 pricing added to this package please?

it would be super nice!

@squinn1 I took a quick look into code and I assume we just need to update this file https://github.com/BerriAI/litellm/blob/main/model_prices_and_context_window.json with adding o1-preview and o1-mini. Do you wanna open PR or should I?

@squinn1  thanks! I was just confused because readme was not updated :D !

@squinn1  thanks! I was just confused because readme was not updated :D !

pricing_list.md has the updated cost but it's not reflected in the README. So that should either be updated or it reflects the list file.


bazel-deps: remove

Motivation for this change
This has been broken for a while, and now that there's an official rule set to support maven dependencies in Bazel (https://github.com/bazelbuild/rules_jvm_external) this is much less useful.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @ryantm @orivej @Profpatsch @abbradar

Instead of removing it I would throw an error with basically your description if somebody tries to build the attribute.

Sounds good, do you know an example derivation that does that off the top of your head so I can see how to do that?

Figured if we're not agree on removing it, or adding a throw, might as well update it and fix it.

It's still not working with sandbox, let me fix that.

@GrahamcOfBorg build bazel-deps

So, should we try upgrading it, remove, or just mark as broken?

I think we should remove it, but I'm happy for it to be upgraded, I just got stuck on this error:
src/main/tools/linux-sandbox-pid1.cc:427: "execvp(external/remotejdk11_linux/bin/javac, 0x42be70)": No such file or directory

I think I saw it on another bazel related derivation but I can't remember which one.

What I found out is in buildBazelPackage when we delete all the local repositories expecting Bazel to recreate them without network we don't support the remote jdk: that is because when the local jdk repository is recreated it cannot handle is the case of the remote jdk already having being downloaded.

This is broken due to https://github.com/bazelbuild/bazel/issues/10280. I'm going to change the PR back to deleting this package.

I believe this can be fixed if you just tell bazel to use the local jdk provisioned within the nix build env
I have this in my .bazelrc file. Not sure how you would override this in the nix bazel build function call...
build --host_javabase='@local_jdk//:jdk'
build --java_toolchain='@bazel_tools//tools/jdk:toolchain_hostjdk8'


bosh vms --dns returns "n/a" for "DNS A records" column after bosh upgrade

We found the problem after upgrading the bosh from version 1.3153.0 to 1.3262.3.0.
Before the upgrade (bosh is 1.3153.0), the result of "bosh vms --dns" is
| VM                          | State   | VM Type        | IPs             | CID      | Agent ID                             | Resurrection | DNS A records                                             |
+-----------------------------+---------+----------------+-----------------+----------+--------------------------------------+--------------+-----------------------------------------------------------+
| admin_ui/0                  | running | logger         | <IP_ADDRESS>   | 22354757 | d3fc83b5-7eb5-4d74-9425-b7471d9573de | active       | 0.admin-ui.default.gubin-preyf.microbosh                  |
| api_worker/0                | running | coreNode       | <IP_ADDRESS>   | 22354729 | fb5ce5b1-9e6c-4087-b6fa-433a44afdff6 | active       | 0.api-worker.default.gubin-preyf.microbosh                |
| api_worker_dal09/0          | running | coreNode_dal09 | <IP_ADDRESS>   | 22354777 | 18cc0ef7-7c20-4c9a-a2c1-a95390bc3e93 | active       | 0.api-worker-dal09.default.gubin-preyf.microbosh          |
| ccdb_lon02/0                | running | dbNode         | <IP_ADDRESS>   | 22354779 | 0189e0f1-3074-4ee3-b002-5ee3a380cc0c | active       | 0.ccdb-lon02.default.gubin-preyf.microbosh                |
| clock_global/0              | running | coreNode       | <IP_ADDRESS>   | 22354733 | a5a7674c-daad-48ea-9a84-36d9a2732db2 | active       | 0.clock-global.default.gubin-preyf.microbosh              |
...

After bosh upgrade (bosh is 1.3262.3.0), the result of "bosh vms --dns" is
+--------------------------------------------------------------------+---------+-----+----------------+-----------------+----------+--------------------------------------+--------------+---------------+
| VM                                                                 | State   | AZ  | VM Type        | IPs             | CID      | Agent ID                             | Resurrection | DNS A records |
+--------------------------------------------------------------------+---------+-----+----------------+-----------------+----------+--------------------------------------+--------------+---------------+
| admin_ui/0 (f3819020-0015-4619-b217-0ca73e0e447d)                  | running | n/a | logger         | <IP_ADDRESS>   | 22354757 | d3fc83b5-7eb5-4d74-9425-b7471d9573de | active       | n/a           |
| api_worker/0 (449d9453-1d8b-4bfd-ac6a-0f2245c10e40)                | running | n/a | coreNode       | <IP_ADDRESS>   | 22354729 | fb5ce5b1-9e6c-4087-b6fa-433a44afdff6 | active       | n/a           |
| api_worker_dal09/0 (4b767cf7-0a6d-413b-a0ef-13973fa6cb75)          | running | n/a | coreNode_dal09 | <IP_ADDRESS>   | 22354777 | 18cc0ef7-7c20-4c9a-a2c1-a95390bc3e93 | active       | n/a           |
| ccdb_lon02/0 (14109da6-cc51-49e8-8e99-d096e4f59550)                | running | n/a | dbNode         | <IP_ADDRESS>   | 22354779 | 0189e0f1-3074-4ee3-b002-5ee3a380cc0c | active       | n/a           |
| clock_global/0 (65b97424-70b1-4387-822f-0bab418ac281)              | running | n/a | coreNode       | <IP_ADDRESS>   | 22354733 | a5a7674c-daad-48ea-9a84-36d9a2732db2 | active       | n/a           |
...

The values in column "DNS A records" are all "n/a".
In the old bosh, "bosh vms --dns" returns the values for "DNS A records" from powerdns db. But in the new bosh, "bosh vms --dns" returns the values from column "dns_records" of table "instances". After bosh upgrade, column "dns_records" of table "instances" is empty. The reason we guess should be in bosh/bosh-director/db/migrations/director/20151008232214_add_dns_records.rb. It adds a column "dns_records" to table "instances" but doesn't import the data from powerdns db.

@gu-bin you should be able to run bosh deploy and bring those records back.

@cppforlife
it works, thanks!


Wrong Command

List all deployed RunCommand resources on a VM
az vm run-command list --name "myVM" --resource-group "myRG"

is wrong.
I guess that "az vm run-command list --vm-name "myVM" --resource-group "myRG"" is right.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 187ea459-7121-0d9f-db71-be056218c415
Version Independent ID: 447d4d3a-f488-6516-9cc4-db1ad06bd9e5
Content: Run scripts in a Linux VM in Azure using managed Run Commands (preview) - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/run-command-managed.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

@NakayamaKento , Thanks for reaching out. We will investigate and update this thread.

@NakayamaKento, Yes here is the right command,
az vm run-command list [--expand]
                       [--location]
                       [--query-examples]
                       [--resource-group]
                       [--subscription]
                       [--vm-name]

We appreciate your feedback. The doc has been edited accordingly and it would take some time for the changes to get reflected over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Problems with the VPN and the country

Describe the bug
The user, when using the Nord VPN with Brave browser, which is directed to the country Switzerland, does not work places and gets this error. But when selecting another country everything works.
Browser version and link: V.1.48.171 - https://brave.com/
VPN: https://nordvpn.com/vpn-site/

Additional context
Link on the ticket - https://discord.com/channels/454734546869551114/1082273214471876669.

Possibly related to https://github.com/connext/monorepo/issues/3532


🐛 BUG: VSCode code highlighting after script attributes

Describe the Bug
Using atteributes with values wrapped in single-quotes (') that contain script-content currently break the highlighting for the rest of the file.
This does not happen when using double-quotes ".
Here is a example:

Broken
OK: No onload='' attribute
OK: Double-Quote on onload='' attribute

i used the latest version of the VSCode plugin, i also tried the pre-release version without success.
Steps to Reproduce

Add a script tag with onload attribute to any .astro file

Closing as a duplicate of https://github.com/withastro/language-tools/issues/530


Feature Request: Add platform image variant support

Some platforms were released with multiple logos in different parts of the world. + people create variants of platforms in the same theme.
It would be cool to give everyone access to those variant images by adding support for selecting wallpaper variants in the platform edit menu and adding them as followed in the wallpaper pack index.json:
{
      "matchPlatformShortname": "segacd",
      "filename": "segacd.png",
      "variants": [
        "megacd.png"
      ]
},

Hope it's something you are willing to look at If need me to explain it a bit more, let me know!

Actually, thinking about this, I think it wouldn't be necessary if those regional platforms were just added to Daijisho officially. Platform entries for Nintendo Famicom, Super Famicom, Sega Mega Drive, Sega Mega CD, NEC PC Engine, and NEC PC Engine-CD are the missing ones that come to my mind.
If we had those platforms (which would be cool anyway), we wouldn't need that platform image variant support because the Dai would just pull the fitting image for the fitting platform variant.

While I agree with the above comment, multiple versions of a console/handheld still release in the same region. So adding this feature would still give more options to personalize a theme.
Simple example:

Which would you pick?

Ah, true, for that purpose this would certainly be helpful.


[discussion] New name for this project

<!-- hypertronsMetaData: {"choices":["Hyperx","Hyperext","Hypercrx","Hypexin","Visoron"],"participants":["anyone"],"duration":259200000,"launchTime":1625058136151,"comment_id":871384474} --!>
## Type of Issue
_What types of issue have you found with hypertrons-crx?_
_Put an `x` in the boxes that apply_

- [ ] Bug
- [ ] Feature Request
- [ ] Performance issue
- [ ] Help Wanted
- [ ] Documention incomplete
- [ ] Test Improvement
- [x] Raise a Question

## Introduction to the issue

The name `hypertrons-crx` isn't good enough for a product.

## Process

We can give a new name to it.  Just as the procedure
1. `Cybertrons`, name from a movie.
2. `Hybertrons`, change C to H.
3. `Hyberextension`, associate chrome extension with Hybertrons

## Expected result

New names

If this an open discussion then how about Hypexin or  Visoron ?

I propose some kinds of  Hyper + extension. As this is a Hypertrons ecosystem project, and extension can also describe the scenario that Hypertrons extent to other platform, suche as explorer.
So the name can be: Hyperx, Hyperext, Hypercrx, ect.

/start-vote Hyperx  Hyperext  Hypercrx Hypexin Visoron

/start-vote Hyperx Hyperext,Hypercrx,Hypexin,Visoron anyone 3d

/start-vote Hyperx,Hyperext,Hypercrx,Hypexin,Visoron anyone 3d

/vote Hypercrx

/vote Hypercrx

/vote Hyperext

/vote Hyperex

/vote Hypexin

/vote Visoron

/vote Hypercrx

/vote Hyperx

/vote Hyperext


Bump tree-sitter version

Bump dependency versions, the ~ version requirement was overly restrictive.

Superseded by #14, thank you for the PR though!


chore(starknet_sequencer_node): avoid redundant client cloning for remote servers

Stack:

#2743
#2742 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

crates/starknet_sequencer_node/src/utils.rs line 15 at r1 (raw file):

    let servers = create_node_servers(config, &mut channels, components, &clients);

    (clients, servers)

I like the convention of a new line before the "return statement"
Code quote:
    let servers = create_node_servers(config, &mut channels, components, &clients);

    (clients, servers)


Ci/remove apk repo

Codecov Report

Merging #180 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   51.08%   51.10%   +0.01%
==========================================
  Files         151      151
  Lines       22923    22923
  Branches     6053     6053
==========================================
+ Hits        11711    11714       +3
+ Misses       7606     7603       -3
  Partials     3606     3606

Flag
Coverage Δ

unittests
51.10% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libvcx/src/lib.rs
33.48% <0.00%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5407e99...9d56921. Read the comment docs.


Backward incompatibility of 0.17.0

#257 has broken the backward compatibility of magnolia.
When I bumped version, I got a runtime error in a lib dependent on 0.16.0:
java.lang.NoSuchMethodError: 'magnolia.Param magnolia.Param$.apply(java.lang.String, int, boolean, magnolia.CallByNeed, magnolia.CallByNeed, java.lang.Object[])'

The newly added param should have been with the default value.

To promise backwards compatibility we would have to release 1.0

Magnolia has become a widely used library. The thing is that in a relatively small project it comes as a transitive dependency from 4 different libs.
If only one lib updates magnolia to 0.17.0, and the others don't come up with new releases, the whole app may be spoilt silently (will break at runtime). That's what really happened.
It doesn't cost much to support backward compatibility when you add a new argument such as an array of annotations.

I'm not even against releasing 1.0 but if we go through with #247 and #256 they will for sure not be binary compatible.
And the only way to be sure is to add MiMa to the build.

Thanks for reporting, @catostrophe. I want to move to version 1.0 quite soon now, though it does need a bit of admin work, which I haven't had time for.

#247 can actually be binary compatible, as the methods aren't part of any binary API. But in any case, I would support split and join as aliases for dispatch and combine.


Bible bot triggering (and trying to pull from apocrypha) when user directly quotes the beginning of Proverbs

Issue can be seen here:
https://i.imgur.com/RiZ2T0O.png

Ok well, I guess someone fixed that....
But typing: Wisdom of Solomon 1:1
when you're set to like the ESV creates massive error spam

I've isolated the offending formula down to:
Solomon: wisdom
just that will trigger it

solomon: wisdom wisdom wisdom
triggers massive spam

even just
: wisdom wisdom wisdom
triggers it

Bottom lines is, it looks like on a version that doesn't have the apocrypha it spams the error message based on every time "wisdom" is said after a colon

Are you sure the core problem here is fixed, I just checked and it triggers
on other apocrypha names as well
If you put a colon followed by whitespace, then the name of a book from the
apocrypha, it triggers the error for apocrypha for each time the book name
was mentioned AND it continues to loop sending the error over and over
maybe 4 times for each time the book name was mentioned.
This of course only happens when it needs to throw an apocrypha error.  On
a version with the apocrypha it recognizes that : [bookname] [bookname]
[bookname] ... is not a valid formula so it doesn't respond.
On Sat, Jul 1, 2017 at 6:02 PM Elliott Pardee<EMAIL_ADDRESS>wrote:

Closed #36 https://github.com/UnimatrixZeroOne/BibleBot/issues/36 via
f2535e9
https://github.com/UnimatrixZeroOne/BibleBot/commit/f2535e9a24c6f60e9b8840d552803e2511f5716f
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/UnimatrixZeroOne/BibleBot/issues/36#event-1147077288,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXUjJRAPmuanqPsZU1YNkGByxizePZ99ks5sJtAHgaJpZM4OLNZ-
.

This may be fixed in the next push, I ensured that the book detection scheme had more assurance of a book having actual verses.

Did you figure out why it's looping?
On Sat, Jul 1, 2017 at 8:08 PM Elliott Pardee<EMAIL_ADDRESS>wrote:

This may be fixed in the next push, I ensured that the book detection
scheme had more assurance of a book having actual verses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/UnimatrixZeroOne/BibleBot/issues/36#issuecomment-312464465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXUjJXmBTq81OHDTcRqO5jeTMTzKkX07ks5sJu1ugaJpZM4OLNZ-
.

The fix I've made should cover that as well, although I don't know what is causing the loop.

Should be fixed in 4f27ede.

Yup, looks like that could certainly cause the problem.


Release of version <IP_ADDRESS> of DFSDsc

Releasing version <IP_ADDRESS>

This change is

Codecov Report

Merging #82 into master will decrease coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #82   +/-   ##
=====================================
- Coverage      96%    95%   -2%
=====================================
  Files           7      8    +1
  Lines        1032   1071   +39
=====================================
+ Hits          997   1021   +24
- Misses         35     50   +15


Update lyx.rb for appcast and zap

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Update lyx.rb for appcast and zap

Should this get auto_updates true as well? Really asking, as I do not know if this app auto-updates.

It can't. Even it can't check update.

Thank you.


Add hardware acceleration support for static files

I'm using --device=/dev/dri:/dev/dri in my compose file but it doesn't seem to make any difference in CPU usage vs leaving it out. Am I missing some other config? Thanks

No, currently not implemented. Only for live transcoding. But should not be a big change to add it there.

Gotcha, thanks. Might take a crack at it myself but don't know much about go or ffmpeg

Would also love to see this, for hardware transcoding of a static library hosted on Synology (https://timothybasanov.com/2018/12/08/hardware-accelerated-h264-encoding-synology-nas.html)


cannot convert incomplete value "string" to JSON

Describe the bug
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  annotations:
    app.oam.dev/deployVersion: "20211115115209195"
    app.oam.dev/last-applied-configuration: '{"kind":"Application","apiVersion":"core.oam.dev/v1beta1","metadata":{"name":"nginx2","namespace":"default","creationTimestamp":null,"labels":{"oam.dev/render-hash":"e6766e6f0118dc3d"},"annotations":{"app.oam.dev/deployVersion":"20211115115209195"}},"spec":{"components":[{"name":"nginx2","type":"webservice","properties":{"addRevisionLabel":false,"env":[{}],"image":"nginx","livenessProbe":{"exec":{},"failureThreshold":3,"httpGet":{"httpHeaders":[{}]},"initialDelaySeconds":0,"periodSeconds":10,"successThreshold":1,"tcpSocket":{},"timeoutSeconds":1},"port":80,"readinessProbe":{"exec":{},"failureThreshold":3,"httpGet":{"httpHeaders":[{}]},"initialDelaySeconds":0,"periodSeconds":10,"successThreshold":1,"tcpSocket":{},"timeoutSeconds":1},"volumes":[{}]}}],"policies":[{"name":"env-bindings","type":"env-binding","properties":{"envs":[{"name":"local","patch":{},"placement":{}}]}}]},"status":{}}'
    oam.dev/kubevela-version: master
  creationTimestamp: "2021-11-15T03:36:07Z"
  finalizers:
  - app.oam.dev/resource-tracker-finalizer
  generation: 2
  labels:
    oam.dev/render-hash: e6766e6f0118dc3d
  name: nginx2
  namespace: default
  resourceVersion: "21164955"
  uid: 3f77b960-4605-4ff6-83ab-0c64766bccd1
spec:
  components:
  - name: nginx2
    properties:
      addRevisionLabel: false
      env:
      - {}
      image: nginx
      livenessProbe:
        exec: {}
        failureThreshold: 3
        httpGet:
          httpHeaders:
          - {}
        initialDelaySeconds: 0
        periodSeconds: 10
        successThreshold: 1
        tcpSocket: {}
        timeoutSeconds: 1
      port: 80
      readinessProbe:
        exec: {}
        failureThreshold: 3
        httpGet:
          httpHeaders:
          - {}
        initialDelaySeconds: 0
        periodSeconds: 10
        successThreshold: 1
        tcpSocket: {}
        timeoutSeconds: 1
      volumes:
      - {}
    type: webservice
  policies:
  - name: env-bindings
    properties:
      envs:
      - name: local
        patch: {}
        placement: {}
    type: env-binding
status:
  conditions:
  - lastTransitionTime: "2021-11-15T03:36:07Z"
    reason: Available
    status: "True"
    type: Parsed
  - lastTransitionTime: "2021-11-15T03:36:07Z"
    reason: Available
    status: "True"
    type: Revision
  - lastTransitionTime: "2021-11-15T03:36:07Z"
    reason: Available
    status: "True"
    type: Render
  latestRevision:
    name: nginx2-v2
    revision: 2
    revisionHash: c07d8c0c0108d303
  observedGeneration: 2
  status: workflowTerminated
  workflow:
    appRevision: nginx2-v1:e1c2994ada1fb1cc
    contextBackend:
      apiVersion: v1
      kind: ConfigMap
      name: workflow-nginx2-context
      uid: 9a3db532-5e84-4171-af34-23c907f5c421
    mode: DAG
    steps:
    - id: xbrhvws83i
      message: 'step apply: run step(provider=oam,do=component-apply): GenerateComponentManifest:
        evaluate base template component=nginx2 app=nginx2: failed to have the workload/trait
        unstructured: cue: marshal error: spec.template.spec.containers.0.image: cannot
        convert incomplete value "string" to JSON'
      name: nginx2
      phase: failed
      reason: Execute
      type: apply-component
    suspend: false
    terminated: true

If there is no value, do not declare it.
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: nginx2
  namespace: default
spec:
  components:
  - name: nginx2
    properties:
      addRevisionLabel: false
      image: nginx
      port: 80
    type: webservice
  policies:
  - name: env-bindings
    properties:
      envs:
      - name: local
        patch: {}
        placement: {}
    type: env-binding


gnomeExtensions: auto-update

Motivation for this change
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Hm, we didn't have any new collisions for a while now. Did the script break down somewhere or is this just because we are late into the GNOME release cycle or something?


Added EncryptWithR allowing to specify the randomness

Function EncryptWithR lets to specify randomness r explicitly. For
some ZKPs based on the Paillier scheme, it's required to use the same
r for encryption and construction of ZKP. It wasn't possible previously,
because r was generated internally and never returned.
I did not want to modify Encrypt to return r because it would break
existing code using this API, as well as, I wanted to make sure person
using the specific r and using it somewhere else really knows what
he's doing.

Fantastic. As always, outstanding code.
As a side note, can you point me to the ZNP that you talk about.  I would like to know how they use r in them.
many thanks,
didier

Sure! For example, Gennaro's ZKP allowing to construct range commitment for key pair (η, y=g^x) with encrypted w = E(η):


Add jamesbrine.com.au CTI feed to threat intelligence feeds with description.

Added jamesbrine.com.au under threat intelligence feeds with description. This free (TLP white) feed provides daily threat intelligence for Australia and internationally with STIX2 feeds.

Thank you. Nice project! 😄

Thanks hslatman, glad to help :)


Lost dcgm policy notifications

Hi Team,
I was looking into an issue we were seeing with only being able to receive one message at a time when setting up a policy for listening to DCGM notifications. I noticed some strange code that looks potentially buggy to me but it's likely Im just missing something.
The code in reference is here. I have also copied this below:
publisher := newPublisher()
_ = publisher.add()
_ = publisher.add()

// broadcast
go publisher.broadcast()

go func() {
	for {
		select {
		case dbe := <-callbacks["dbe"]:
			publisher.send(dbe)
		case pcie := <-callbacks["pcie"]:
			publisher.send(pcie)
		case maxrtpg := <-callbacks["maxrtpg"]:
			publisher.send(maxrtpg)
		case thermal := <-callbacks["thermal"]:
			publisher.send(thermal)
		case power := <-callbacks["power"]:
			publisher.send(power)
		case nvlink := <-callbacks["nvlink"]:
			publisher.send(nvlink)
		case xid := <-callbacks["xid"]:
			publisher.send(xid)
		}
	}
}()

// merge
violation = make(chan PolicyViolation, len(channels))
go func() {
	for _, c := range channels {
		val := <-c
		violation <- val
	}
	close(violation)
}()

There is some missing context here, but this is the important part. What I see happening is that the channels in the callbacks array are being read in two places at the same time: (1) in the go routine with the select statement (2) in the "merge" go routine with the for/range loop. This seems odd to me. Go doesnt duplicate messages in a channel for multiple readers so these two routines would appear to be fighting for the same messages as far as I can tell. Furthermore, if the "select" routine gets the messages, it will send them to the publisher, which appears to publish to two subscribers that are not being listened to (What exactly is going on there? Im not sure). The main issue I see is the duplicate simultaneous reading from the same channels
I would like to know if I am missing something here. It seems that notifications could get lost if the select statement receives them and they get sent to the publisher that has unused subscribers. Am I understanding things correctly?

Thank you for letting us know. We will investigate the issue.

@sanjams-amzn, can you confirm that the current version resolves your issue?

Yes this issue has been addressed with:

https://github.com/NVIDIA/go-dcgm/commit/be68ae586983b8424f8317111484865f05eae0c1
https://github.com/NVIDIA/go-dcgm/commit/77567a04c08edd8e20128626ad4fcc2b255340d4


Followup to #101 (ENG)

This is a Followup to #101
Removed the Spaces at the end of lines to have a better view about the real changes

I would have actually said we leave the spaces in since you can see the change without space in this commit.
https://github.com/Dymerz/StarCitizen-Localization/pull/101/commits/bd7aeee00ba89061d90f0c1dac7f7d27d835d420
If again a new version comes one must remove these again and I think they will have thought what with these Spaces as a placeholder or simply around something better to format! And of course for perhaps archive purposes to ensure simply that one has these older files again available.

The spaces at the end of the lines look too random to make sense.

I don't know, but it's an extra step to do it again and again when a new version comes out. I'm just saying.

Regex: "[ ]+$"
Not much work

Yes ok, anyway commit again and it is then just no longer original. Then we do it that way. 👍

I prefer to keep the file as it comes from the original game. This way, we won't interfere with things we might not be aware of, and the file can truly be called "original."
If you don't want to see whitespace in the diff, you can still hide them by adding ?w=1 to the URL.


python312Packages.mailchecker: 6.0.5 -> 6.0.8

Changelog: https://github.com/FGRibreau/mailchecker/blob/v6.0.8/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339885 run on x86_64-linux 1

8 packages built:

python311Packages.mailchecker
python311Packages.mailchecker.dist
python311Packages.python-benedict
python311Packages.python-benedict.dist
python312Packages.mailchecker
python312Packages.mailchecker.dist
python312Packages.python-benedict
python312Packages.python-benedict.dist


Unify the format of returned measurement data

We should make the format (type, shape) of returned measurement results more uniform. Currently we sometimes return scalars, arrays, lists, tuples, etc.
With the new Results object being created, now is the time to refactor the return types for various backends, and have a unified standard expressed in Results.
This may also have relevance for register values.
Things to take into account:

shots
batch_size
number of measured modes
whether the user entered measured modes out of order -- should we return them in same order requested?

A summary of my posts in the PR:

I think internally (backend API, Measurement.apply etc.) measurement samples should always be returned in a similar 2d array (even if shots==1): shape == (modes, shots). Only measured modes should have rows (or cols, does not really matter) in the array, and the results should be in the same order as they were requested (the modes argument).

Returning measurement samples to the user (inside the Result object):
I don't think returning Nones for the non-measured systems is very useful.
Options:

A dictionary, mapping indices of measured subsystems to sample lists or 1d-arrays: result.samples = {0: [0.32, 1.43, -0.32], 2: [0, 4, 5]}
A 2d-array with just the measured subsystems, in subsystem index order, leaving it to the user to remember what they are (risky!): result.samples = array([[0.32, 1.43, -0.32], [0, 4, 5]], dtype=float)
An array like in 2., but with an additional list/1d-array of subsystem indices to label the rows: result.measured_modes = [0, 2]
Is there a way in Numpy to label array rows/columns? If there is, 2. and 3. could be combined into a single labeled array.

The Result class can also be given a property method (or several) for returning the samples in another format, e.g. result.samples_array

How about, as @smite suggested for the user facing results:

results.samples = {0: [0.32, 1.43, -0.32], 2: [0, 4, 5]}

results.samples_array = array([[0.32, 1.43, -0.32], [0, 4, 5]], dtype=float)

I don't see any downside to also providing result.measured_modes = [0, 2]

For the backend API, I agree with shape == (modes, shots).

I'm in favour of all this. Let's do exactly as @josh146 outlined above --^

What about batch_size? How should it work?

I added some preliminary tests for this. Conventionally, batch axis is always first.
So 'results_array.shape==(batch_size, modes, shots)'

Is this also how it's handled internally? So if you have batching on, the internal representation of the samples is always a 3d array?

If batch mode is used, then deep in the guts of the TF Backend, everything is represented as tensors with shape (batch_size, ...). Measurements are currently returned as a Tensor/array of shape (batch_size,). The only exception is for measure_fock on N modes, which I believe is returned as tuple(batch0, batch1,...) where batchX.shape==(batch_size)

btw I'm open to changing this if we have better suggesitons. Previously there was only one case where a measurement result was returned that had more than one axis (measure_fock in TF backend with batch_size != 1), so it was decided semi-arbitrarily how this should look

Obsolete issue. Results should now be unified across backends (incl. remote).


Log the whole consensus state

To enable consensus state inspection.

Closing as this wasn't intended to be merged in the first place.


Selenide consolidation for WebBrowser

It seems for me that Selenide is getting very similar to ScalaTest philosophy.
My assumption that WebBrowser might wrap some syntax of selenide to have it scalaway, the rest of "should" Selenide can worry about.
@asolntsev, @bvenners, what do you think?
Inspired by: Selenium Camp 2014

It looks to me like Selenide is a nice API for Java that can also be used from Scala, and from within ScalaTest, but I don't think at this time there's a need to add any support in ScalaTest for Selenide, since our ScalaTest Selenium DSL covers much the same territory, and Selenide looks quite pretty and readable as is in ScalaTest:
https://github.com/asolntsev/hangman/blob/master/test/uitest/scala/HangmanScalaTest.scala


move desktop nav array to consts tsx file

What does this PR do and why?
Move items array and associated components from component to constants.tsx file
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2233

PR #2234

PR #2235

PR #2236

PR #2237   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: QYaAht6eMvR7hTnqghel


test: asset unlock (withdrawal) should not be Instant-Send locked

Issue being fixed or feature implemented

txes of unlock and unlock themselves do not receive islocks
When the unlock is removed from mempool, so are the children

These functionality has not tests, but that's crucial for consensus be fine.
What was done?
How Has This Been Tested?
Breaking Changes
N/A
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

So, we just have to wait for a CLSIG before we can use this input?

So, we just have to wait for a CLSIG before we can use this input?

Yes, that's right in current implementation. They are not supposed to be IS locked, need to wait a block with CL

test-1:

txes with spending of unlock and unlock themselves do not receive islocks.

DONE, this PR has tests for it

test-2:

When the unlock is removed from mempool, so are the children.

I implemented test that should works, but it magically fails with error that I can not explain:
test_framework.authproxy.JSONRPCException: mandatory-script-verify-flag-failed (Operation not valid with the current stack size) (-26)

I will create a new PR if I will fix Test-2. This PR with test-1 is ready for review.


CEF Transparency with Border Radius

When using a transparent background for the HUD, elements with a border radius receive a black line halo on the rounded radius.
I've seen the same issue with using CEF in other projects like cefPython but doesn't happen in any actual browser.
I'm compensating for the issue at the moment with a drop shadow css filter (not active in the attached image).
I did find this that might be useful:
http://magpcss.org/ceforum/viewtopic.php?f=6&t=13404
'You need to set CefWindowInfo.transparent_painting_enabled to true and use HTML content that does not specify a background color.'

giving the body or html tag a background color.


Add new feature for #212

closed #212 .

First of all, sorry for the late confirmation.
Thank you for your contribution, I will check and merge it soon.


commit issue

Improve GameOver:

Show the last move place by the winner
Show the diagonalor horizontal or vertical by which the player or computer has won.

@tronghob2111963  Thank you for you PR

This is the error while deployment could you fix it?
Also, could you make sure that npm run build doesnot yeild any error.


1.13.0-beta 3 LangVersion still gives workspace errors

Steps to reproduce
See https://github.com/OmniSharp/omnisharp-roslyn/issues/961
Run a project with LangVersion latest/7.1 and try one of the new features (default, generic pattern match etc) see an error explaining you need to use 7.1 to use that feature.

Can you post the output of your OmniSharp Log? FWIW, it works on my machine (with both latest and 7.1) 🤔

Ok reinstalled in my normal vscode, and it seems something was breaking in my insiders version.
Happy to see it does work 👍


Asp.net core using storage nuget package from 2017 results in nuget conflict

Describe the bug
Microsoft.AspNetCore.DataProtection.AzureStorage depends on WindowsAzure.Storage, a nuget package from 2017 😱. This creates conflicts e.g. when also using Nuget packages that rely on its modern replacement (Microsoft.Azure.Storage.*). E.g. Bot Framework does this.
This is an issue for my project.
Error I'm getting:
The type 'CloudStorageAccount' exists in both 'Microsoft.Azure.Storage.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' and 'Microsoft.WindowsAzure.Storage, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'

@muratg Who can I borrow for data protection right now?

cc @Eilon

We are updating DataProtection.AzureStorage in 3.0 to use the new Microsoft.Azure.Storage.Blob dependency. This should resolve the compiler conflict in the scenario originally reported.
If you want to use Microsoft.Azure.Storage.Blob in 2.1 and 2.2 apps along with DataProtection.AzureStorage, you can resolve the compiler error by fully-qualifying the type reference, or adding a using such as this to the top of your file.

using CloudStorageAccount = Microsoft.Azure.Storage.CloudStorageAccount;

Closing as we do not plan to update 2.1 or 2.2 to use Microsoft.Azure.Storage APIs.


Set content type for azure file uploads so downloads have a file extension

Description
Previously, azure file uploads didn't have a content type set so extensions were lost. For whatever reason, Azure SDK defaults to MIME type "application/octet-stream". This PR sets the MIME type to preserve extensions.
Issue was found in bug bash, not sure if there is an issue number.
Issue(s)
Fixes #2101

LGTM! thanks for fixing this, Zara!


The /example project doesn't build

Following the README, I get
cabal: Could not resolve dependencies:
[__0] trying: example-<IP_ADDRESS> (user goal)
[__1] unknown package: plutus-core (dependency of example)
[__1] fail (backjumping, conflict set: example, plutus-core)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: example, plutus-core

At some point language-plutus-core was renamed to plutus-core. The example/cabal.project file defines some github sources, which point to an older commit of this repo 73234550dc2b2c6209975789845bb5ef6abdf6bc, where it still has the old directory name. I have tried

Pointing the github sources to a more recent commit of this repo, which fails on a transitive dependency. After some changes to cabal.project it eventually fails because plutus-tx-plugin depends on a newer version of ghc than 8.8.3. I had no luck updating shell.nix to use a newer ghc.

Updating example.cabal to depend on language-plutus-core instead of plutus-core, but got some compile errors in language-plutus-core, probably also due to a mismatch in GHC versions/libraries

In the end I just checked out an old commit of the whole repo and /example did build (e300450f61f7e77cf0455171dff4f41290050299)

@jaccokrijnen I've submitted a PR (linked above) that should fix this issue for both the shell.nix and VSCode devcontainer configuration for the example project. If you get the chance, feel free to test out those changes and give this another try. If it works or is broken again in some way, please leave a comment noting so on the PR. Thanks for your help!

@jaccokrijnen I've submitted a PR (linked above) that should fix this issue for both the shell.nix and VSCode devcontainer configuration for the example project. If you get the chance, feel free to test out those changes and give this another try. If it works or is broken again in some way, please leave a comment noting so on the PR. Thanks for your help!

Thanks! The example builds for me now.
However, when I want to add some more dependencies, it seems plutus-contract and plutus-core are in conflict. (I'm trying to build some of the examples from https://prod.playground.plutus.iohkdev.io/ )

plutus-contract requires an aeson >= 1.5.1 to build (uses a recently added Ord instance of Aeson.Types.Value).
plutus-core requires aeson < 1.5 as a transitive dependency through monoidal-containers.

I also had to add some other constraints for the transitive dependencies of plutus-ledger-api and plutus-contract before arriving at the above problem.

plutus-ledger-api won't build because of its base16-bytestring dependency, for which it doesn't have any version bounds and < 1.0 is required (breaking changes since <IP_ADDRESS>).

plutus-contract requires row-types < 1.0 , aeson >= 1.5.2

Thanks! The example builds for me now.
However, when I want to add some more dependencies, it seems plutus-contract and plutus-core are in conflict. (I'm trying to build some of the examples from https://prod.playground.plutus.iohkdev.io/ )

plutus-contract requires an aeson >= 1.5.1 to build (uses a recently added Ord instance of Aeson.Types.Value).
plutus-core requires aeson < 1.5 as a transitive dependency through monoidal-containers.

I also had to add some other constraints for the transitive dependencies of plutus-ledger-api and plutus-contract before arriving at the above problem.

plutus-ledger-api won't build because of its base16-bytestring dependency, for which it doesn't have any version bounds and < 1.0 is required (breaking changes since <IP_ADDRESS>).

plutus-contract requires row-types < 1.0 , aeson >= 1.5.2

Probably it will only solve in combination with our pinned index-state in cabal.project. You probably want to pin it to the same as we do.

Probably it will only solve in combination with our pinned index-state in cabal.project. You probably want to pin it to the same as we do.

Or possibly this is to do with the fact that we all use the package set generated by stack. Possibly I need to just revisit that...

Or possibly this is to do with the fact that we all use the package set generated by stack. Possibly I need to just revisit that...

Should I open a different issue for the problem in my last comment? That is, I cannot depend on both plutus-core and plutus-contract at the same time (even when setting the index-state to what is being used in the top-level directory of this repo).

Should I open a different issue for the problem in my last comment? That is, I cannot depend on both plutus-core and plutus-contract at the same time (even when setting the index-state to what is being used in the top-level directory of this repo).

We have a bunch of allow-newer constraints in cabal.project. You probably need all of those too. We should get rid of those, but until we do the solver won't be happy.

We have a bunch of allow-newer constraints in cabal.project. You probably need all of those too. We should get rid of those, but until we do the solver won't be happy.

I managed to get things running by running nix-shell from the project root's shell.nix, instead of example/shell.nix (copying index-state and allow-newer didn't work out). I didn't look into why that worked, butthe ghc version are sligthly different: ghc-<IP_ADDRESS>01118 vs ghc-8.10.2.

I managed to get things running by running nix-shell from the project root's shell.nix, instead of example/shell.nix (copying index-state and allow-newer didn't work out). I didn't look into why that worked, butthe ghc version are sligthly different: ghc-<IP_ADDRESS>01118 vs ghc-8.10.2.

I get a slightly different error message in the devcontainer:
[devcontainer]$ cabal build plutus-starter-pab
Previous HEAD position was 1f20481b1 Disable the plutus-playground-server tests (#4085)
HEAD is now at 9f6c71101 SCP-3031 (#4211)
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.RemoteRepo {remoteRepoName = RepoName
"hackage.haskell.org", remoteRepoURI = http://hackage.haskell.org/,
remoteRepoSecure = Just True, remoteRepoRootKeys =
["fe331502606802feac15e514d9b9ea83fee8b6ffef71335479a2e68d84adc6b0","1ea9ba32c526d1cc91ab5e5bd364ec5e9e8cb67179a471872f6e26f0ae773d42","2c6c3627bd6c982990239487f1abd02e08a02e6cf16edb105a8012d444d870c3","0a5c7ea47cd1b15f01f5f51a33adda7e655bc0f0b0615baa8e271f4c3351e21d","51f0161b906011b52c6613376b1ae937670da69322113a246a09f807c62f6921"],
remoteRepoKeyThreshold = 3, remoteRepoShouldTryHttps = True}
Warning: Requested index-state 2021-08-14T00:00:00Z is newer than
'hackage.haskell.org'! Falling back to older state ().
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: plutus-core-<IP_ADDRESS> (user goal)
[__1] unknown package: plutus-core:happy:exe.happy (dependency of plutus-core)
[__1] fail (backjumping, conflict set: plutus-core,
plutus-core:happy:exe.happy)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: plutus-core,
plutus-core:happy:exe.happy

any ideas what's causing it? I tried several fixes, nothing works out :/


[SC-114545][SPARK-40883][CONNECT] Range.step is required and Python client should have a default value=1

What changes were proposed in this pull request?

To match existing Python DataFarme API, this PR changes the Range.step as required and Python client keep 1 as a default value for this field.
Why are the changes needed?

Matching existing DataFrame API.
Does this PR introduce any user-facing change?

NO
How was this patch tested?

UT

R: @zhengruifeng
I sent out this PR based on your suggestion.

merged to master


fill(previous) does not honor math math functions

Bug report
Using docker image influxdb:0.13.0, querying via grafana
query data series incorporating math operation and fill(previous).
Any filled results will NOT have math function applied; in this example, it means the filled values will be positive while the non-filled values are negative.
Example with fill(none):
SELECT mean("kwatts") *-1 FROM "meter" WHERE $timeFilter GROUP BY time($interval) fill(none)

Same query with fill(previous):
SELECT mean("kwatts") *-1 FROM "meter" WHERE $timeFilter GROUP BY time($interval) fill(previous)

Fixed by #6918 in 1.0.0-beta3.


bower install does nothing when existing package has version conflicts

If I change the version of a package in the manifest and then run bower install, nothing happens.
Example: Start with a bower.json like this:
{
  // ...
  "dependencies": {
    "angular-ui-router": "0.2.11",
    "package-that-requires-0.2.11": "0.1.0"
  }
}

and all the packages have been installed.
Now change the manifest:
{
  // ...
  "dependencies": {
    "angular-ui-router": "0.2.13",
    "package-that-requires-0.2.11": "0.1.0"
  },
  "resolutions": {
    "angular-ui-router": "0.2.13"
  }
}

If I run bower install, I get no output and the angular-ui-router package remains at 0.2.11. (The same happens without the resolutions property.) If I run bower install angular-ui-router, then I get the "Unable to find a suitable version for angular-ui-router, please choose one" conflict message. Using --force or --force-latest resolves to 0.2.13.
Am I wrong in expecting bower to resolve to the resolutions version, or at least to warn me about the version conflict? I couldn't find this behavior described anywhere in the docs.
(I'm using bower 1.3.12)

Yes, it's confusing, and there's ticket for it: #1362


YARN-10929. Refrain from creating new Configuration object in AbstractManagedParentQueue#initializeLeafQueueConfigs

Description of PR
Refrain from creating new Configuration object and remove the unneccessary configuration sorting in AbstractManagedParentQueue#initializeLeafQueueConfigs.
How was this patch tested?
This patch just refactor code and should be covered by exists test.
For code changes:

[Yes] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[No] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[No] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[No] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 22s

trunk passed

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 46s

trunk passed

+1 :green_heart:
mvnsite
0m 58s

trunk passed

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
15m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
compile
0m 48s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 36s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 3 unchanged - 7 fixed = 3 total (was 10)

+1 :green_heart:
mvnsite
0m 52s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 55s

the patch passed

+1 :green_heart:
shadedclient
15m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
103m 34s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

180m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3361

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 642326d4020c 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fad646888c0564169040a1230c750bfbcce82315

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/1/testReport/

Max. process+thread count
1003 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 40s

trunk passed

+1 :green_heart:
compile
1m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 56s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 55s

trunk passed

+1 :green_heart:
shadedclient
15m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
0m 53s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 53s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 40s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 6 unchanged - 8 fixed = 8 total (was 14)

+1 :green_heart:
mvnsite
0m 50s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 51s

the patch passed

+1 :green_heart:
shadedclient
14m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
95m 46s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

172m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3361

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ac72f47cd0ec 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7fd995282d1a5394cfa182aa5c1d5cd0ff28b39

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/2/testReport/

Max. process+thread count
940 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m  3s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 56s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m  0s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 50s

trunk passed

+1 :green_heart:
shadedclient
15m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 38s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 6 unchanged - 8 fixed = 8 total (was 14)

+1 :green_heart:
mvnsite
0m 50s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 52s

the patch passed

+1 :green_heart:
shadedclient
14m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
97m 57s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

174m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3361

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8c231c81d0bb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6afab244ea5a5e2edd162fbf0cdf602d32a861ed

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/3/testReport/

Max. process+thread count
945 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3361/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Closing this PR in favor of https://github.com/apache/hadoop/pull/3744


Context

Pull Request Test Coverage Report for Build 1154

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1152:
0.0%

Covered Lines:
626

Relevant Lines:
626

💛  - Coveralls


Door renders incorrect when opened

[x] I have checked checked the known issues and searched Github to ensure this issue has not already been reported.

Description of the inaccuracy:
After some investigation, it appears that there are two door DL's being rendered when the door is open. This results in different behavior across the different versions of the game (hardware, recomp, GC, emulators)
The running theory is that Recomp & N64 both use fp16 for matrices, whereas 2Ship (and potentially some others) use float, causing inconsistencies in with z-fighting, or one door rendering over the other
Screenshots or videos of 2Ship's behavior:

Screenshots or videos of the original hardware's behavior:
GC

PGB

N64 / Recomp

A bandaid-fix for this might be to replace the hardcoded DL rendered here with the correct door texture based on it's type:
https://github.com/HarbourMasters/2ship2harkinian/blob/develop/mm/src/overlays/actors/ovl_En_Door/z_en_door.c#L706-L712

Will be fixed by https://github.com/Kenix3/libultraship/pull/612


Problems about Experiments

Hello author, when I read the experimental part of your paper, I didn’t quite understand your Speaker Angle in Table 1. How is it determined, what does it mean specifically, for example, is it compared to the angle of each microphone? (I don’t quite understand).

Apologies for any confusion. Regrettably, due to space constraints, we were unable to provide a comprehensive description of the experimental setup. To ascertain the speaker angle, you must initially sample the center of the microphone array. Following this, position two speakers in the room (referred to as speaker A and speaker B). In such a case, the speaker angle is defined as the angle between the line connecting speaker A to the array center and the line connecting speaker B to the array center. If you need further elaboration, please consult the following paper: "End-to-end Microphone Permutation and Number Invariant Multi-channel Speech Separation." I hope this clarifies your query.

Thank you so much


Move .github folder to root directory

Some brave soul attempted to create an issue template for Github. However, the documentation for issue templates states that the .github folder must be in the root directory. Ours is a child of /src. It doesn't work there and it muddies up the /src directory.
This PR moves it to its intended location. Fingers crossed that it works. At the least, it's no longer muddying up the /src directory.
One part of the #167 project organization series.

Hey it worked!

It definitely did :1st_place_medal:


Update labeler to default backports to 2.x

Signed-off-by: Tyler Ohlsen<EMAIL_ADDRESS>Description
Update labeler to default backports to 2.x branch.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #246 (2f49216) into main (2964522) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   45.92%   45.92%
=======================================
  Files         150      150
  Lines        4956     4956
  Branches      955      955
=======================================
  Hits         2276     2276
  Misses       2463     2463
  Partials      217      217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2964522...2f49216. Read the comment docs.


neovim randomly crahes (but not vim)

Information
VIM version
NVIM v0.2.3-dev
Build type: Release
Operating System: macOS 10.13.2
:ALEInfo
Current Filetype: javascript
Available Linters: ['eslint', 'flow', 'jscs', 'jshint', 'standard', 'xo']
Enabled Linters: ['eslint']
Linter Variables:
let g:ale_javascript_eslint_executable = 'eslint'
let g:ale_javascript_eslint_options = ''
let g:ale_javascript_eslint_suppress_eslintignore = 0
let g:ale_javascript_eslint_suppress_missing_config = 0
let g:ale_javascript_eslint_use_global = 0
Global Variables:
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {'javascript': ['eslint']}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '✖'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '⚠'
let g:ale_statusline_format = ['✖ %d', '⚠ %d', '']
let g:ale_warn_about_trailing_whitespace = 1
Command History:
(started) ['/bin/sh', '-c', '''/Users/matteo/dev/html5-buttons/node_modules/eslint/bin/eslint.js'' -f unix --stdin --stdin-filename ''/Users/matteo/dev/html5-buttons/test/lib/excel/server.js'' < ''/var/fo
lders/tn/xlfmczmn783f148sy0j_t8yw0000gn/T/nvimY62wjF/10/server.js''']
(finished - exit code 1) ['/bin/sh', '-c', '''/Users/matteo/dev/html5-buttons/node_modules/eslint/bin/eslint.js'' -f unix --stdin --stdin-filename ''/Users/matteo/dev/html5-buttons/test/lib/excel/server.j
s'' < ''/var/folders/tn/xlfmczmn783f148sy0j_t8yw0000gn/T/nvimY62wjF/11/server.js''']
<<>>
/Users/matteo/dev/html5-buttons/test/lib/excel/server.js:8:7: 'data1' is assigned a value but never used. [Error/no-unused-vars]
/Users/matteo/dev/html5-buttons/test/lib/excel/server.js:102:31: 'excel2buttons' is not defined. [Error/no-undef]
/Users/matteo/dev/html5-buttons/test/lib/excel/server.js:103:31: 'excel2buttons' is not defined. [Error/no-undef]
/Users/matteo/dev/html5-buttons/test/lib/excel/server.js:122:31: 'excel2buttons' is not defined. [Error/no-undef]
/Users/matteo/dev/html5-buttons/test/lib/excel/server.js:123:31: 'excel2buttons' is not defined. [Error/no-undef]
5 problems
<<>>
What went wrong
nvim randomly crashes

Reproducing the bug
No idea how to reproduce it. it can work flawlessy for days and then crash without notice. I've already opened an issue on the nvim repo (https://github.com/neovim/neovim/issues/7768), but maybe in the meanwhile it can be fixed in ALE too (losing all the work done since the last save is always annoying :p )

This looks like a NeoVim bug to me. I handled an empty list in that function there, so you won't see any errors in ALE any more.

@w0rp yep, I know it's a neovim bug, I opened a issue there too, but I suppose it might need a while before it gets fixed, so having ALE handling the empty list at least will avoid triggering the crash :) thanks!


User Story: As a user, I want to update my post(s)...

API is complete but need to add a UI component.


Move CHANGELOG.md into raiden_contracts

so that it's included in the package.
This is a part of #470.

The change does what it's supposed to but my question would by why you would want to include the changelog in the distribution package? I'd guess the likelihood of anyone ever seeing it in there is probably close to zero.

Now I don't remember who asked me to do this.  So I can close this as well.

At least @LefterisJP wants to see CHANGELOG.md in the package.

At least @LefterisJP wants to see CHANGELOG.md in the package.

That was not quite right.  He just wants CHANGELOG somewhere.

GitHub does not follow symlinks automatically.  Maybe distutils does.  So the symlink should be placed in raiden_contracts package and point outwards.

I close this and follow up in #470.


Add error msg catch phrases

A few from some movies and The Simpsons. My first PR!

:+1: Thanks
And let's celebrate your first PR: :tada: :balloon: :birthday:


[Feature Request] can collapse flod from left to right?

Existing Component
是
Component Name
collapse
Description
I need to fold from left to right,can you provide some ideas?  thanks

Sorry, we have no plan to support this.


Redirection of STDOUT fails

Hello,
I'm encountering an issue with redirection of STDOUT into a file. For example, I have a shell command
download sharefile --path="/new" --list --format=json > "/var/folders/jc/6gbmydn96vb97vbj1wm8q77w0000gn/T/KmiUAWdmuE"

and I get this error message
error: Found argument '> "/var/folders/jc/6gbmydn96vb97vbj1wm8q77w0000gn/T/KmiUAWdmuE"' which wasn't expected, or isn't valid in this context

Am I doing something wrong or do I miss some important section in the documentation? Thanks.

Sorry for the spam. The issue was in Perl system arguments.

No problem :smile:


Ignore NotFoundHttpExceptions by default, make the list of ignored

exceptions configurable through the constructor.
@kryysler does this look okay?

Coverage decreased (-2.8%) to 65.385% when pulling 2e46f1de867150266b246d97304147f3b95051d0 on ignored-exceptions into 831bc6d2bd9fcb46d5ab17267a84f283c8071fb7 on master.

Trying to come up with a way to test this, kind of hard when it relies on a function from an extension.

Coverage increased (+8.5%) to 76.667% when pulling c5cfcb787c3fb70dc640b1d2be2395d8bcc0fe81 on ignored-exceptions into 831bc6d2bd9fcb46d5ab17267a84f283c8071fb7 on master.

Coverage increased (+8.5%) to 76.667% when pulling c5cfcb787c3fb70dc640b1d2be2395d8bcc0fe81 on ignored-exceptions into 831bc6d2bd9fcb46d5ab17267a84f283c8071fb7 on master.

Coverage increased (+8.5%) to 76.667% when pulling 32d9b67624af24ecbad51be50fb4406e56109538 on ignored-exceptions into 831bc6d2bd9fcb46d5ab17267a84f283c8071fb7 on master.

Coverage increased (+8.5%) to 76.667% when pulling 32d9b67624af24ecbad51be50fb4406e56109538 on ignored-exceptions into 831bc6d2bd9fcb46d5ab17267a84f283c8071fb7 on master.

Merged manually


Segmentation UI combobox does not get elements from the series

https://idc-sandbox-000.firebaseapp.com/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_dev/dicomStores/idc_tcia/study/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.7695.2311.111788911924319643511738623890
has segmentations, but the the Segs combox does not get filled:

OIHF viewer references Segmenetations to the source series by the attribute ReferencedSeriesSequence (0008,1115), which is conditionally required.
Study <IP_ADDRESS>.4.1.145<IP_ADDRESS>.7695.2311.111788911924319643511738623890 segmentations metadata have instead ReferencedImageSequence (0008,1140) which is optional.
@fedorov since for both RT and SEGs in many places the OIHF Viewer assumes references by ReferencedSeriesSequence, can you please confirm the metadata for the segmentations of this study are correct?
If yes, @igoroctaviano , do you have any advise how to refactor OIHF?

It may not be perfectly correct, but I won't believe by now you still believe in feasibility of DICOM perfection! I think we have to accept what we have. It would be more robust if OHIF checked FrameOfReferenceUID and geometry, and used that to decide whether a given seg can be composed with a specific image (and in turn, use the result of that check to decide if as given seg should be shown in the dropdown). What do you think?

done in https://github.com/OHIF/Viewers/pull/2369. I added checks on FrameOfReferenceUID and it solves the bug.


Add Kubernetes Assets

Would like to have the Kubernetes assets for this work, located locally, within this repo for quicker development turn-around.
This is all tested and working. Please provide your thoughts.

Hey @alexouzounis, was having some issues with the Quay.io build trigger. Will bring it up on Friday. In the meantime I've added the status badges and release functionality to the Makefile. Can you please approve again?


Add Rich Presence Support

General Troubleshooting

[X] I have checked for similar issues on the Issue-tracker.
[X] I have updated to the latest JDA version
[X] I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request
hi, im not sure this is possible but if it is possible please try to do it, I have been searching everywhere on how to do this and it wont work
Example Use-Case
class Activity {

  public void fromRichPresence(RichPresence rp){
    // set it here
    RPButton = record(String name, String URL)
    rp.getButtons() -> RPButton[]
    rp.getLine1(), rp.getLine2() -> string
    rp.getLargeImage(), rp.getSmallImage() -> string
    rp.getApplicationID() -> string
  }

}

This already exists: https://ci.dv8tion.net/job/JDA5/javadoc/net/dv8tion/jda/api/entities/RichPresence.html

You can't set your own rich presence, but you can get an users rich presence already.
Member#getActivities can be used for getting a rich presence (needs cache)

Bots cannot use rich presence. It is limited to user accounts.


Docs: Create a CONTRIBUTING.md in bengali language.

I would like to work on this. Please assign this issue to me

Done

@shrn01 Did the requested change.

You can follow up in the PR thread, no need to add comments here


:bug: Fix: Bad deps

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1188  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


add: ttf-fira-sans

CI is messed up again… I’ll fix it later, and I’ll manually test your PR when I get home.


[Suggestion] Modify description to be clearer

I modified the description of Reducer: "current state given an action" -> "current state based on the given action."
However, because English is not my first language, so please consider this PR as a suggestion rather than a correction. Thanks
- The `reduce` method's first responsibility is to mutate the feature's current state given an action.
+ The `reduce` method's first responsibility is to mutate the feature's current state based on the given action.

Hi @jaesung-0o0, thank you for the PR, but we think the current wording is correct. The reduce method is handed arguments from the outside, and so saying "given an action" should be clear enough.
I am going to close this for now, but feel free to reply if you have more to add to the topic.


Support for password-file in subscribe entries in client.yml

I would like to request support for a password-file option next to the existing password option inside the subscribe option in client.yml. The reason for requesting this is that I use agenix for handling my serverside secrets, and as such I can't hardcode passwords in config files. The password for a ntfy subscription could for instance be published in /run/agenix/ntfy_topic_pw, and I would like ntfy to be able to read it from there.

I solved this by assigning $NTFY_USER using EnvironmentFile in my systemd service. The approach suggested in this issue still has my preference, but at least it works now. :)