Chore: replace Modifiers class in favor of directly int bitmasking

As suggested here: https://github.com/php-tui/php-tui/pull/97

Not sure if this should be an enum. You can't have a composite enum. I would think this better simply as class constants type hinted with int-mask-of

Same as Borders, right?

I think so!

@dantleech Done.

thanks, hopefully this is better in the long run! just a comment about spl_object_id

@dantleech, I don't know why, but I missed the notification for your comment and only saw it just now. I've removed my comment to create an issue instead (I thought that would be more appropriate, sorry).
Yes, there are quite a few options here. Let's think more about this. I'll consider it over the next few days and then return here if I have something to show.

New issue is indeed better, let's continue there when you want :)


[FEATURE] Support is_legal for all formats

From recent discussions:
Highlander formats

EDH/Commander
Pauper EDH/Commander in the 99
Pauper EDH/Commander commander specific combos (allowing uncommons if they are the commander)
Oathbreaker
PrEDH

1v1 formats (future improvement)

Vintage
Legacy
Modern
Pioneer
Standard
Pauper


Authenticator with cognitoUserPool SignIn and Federated SignIn both at the same time!?

Do you want to request a feature or report a bug?
Feature?
What is the current behavior?
Adding federated to the standard Authenticator? Can you have both, login and federated... or just one or the other? adding federated={federated} to  just continues to fail no matter what I do.
All I get it the standard SignIn...

Hey @michaelcuneo SignIn and Federated works together, they are not exclusive. Check out this guide: https://aws.github.io/aws-amplify/media/authentication_guide.html#6-federated-identity
Could you paste a snippet of your code so we can look together.

`mport React, { Component } from 'React'
import PropTypes from 'prop-types';
import config from 'config';
import AuthWrapper from './AuthWrapper';
import KoalaCall from './KoalaCall';
import Amplify, { Auth } from 'aws-amplify';
import {
Authenticator,
Greetings,
SignIn,
ConfirmSignIn,
RequireNewPassword,
SignUp,
ConfirmSignUp,
ForgotPassword
} from 'aws-amplify-react';
export class LoginPage extends React.PureComponent { // eslint-disable-line react/prefer-stateless-function
constructor(props) {
super(props)
};
componentWillMount() {
Amplify.configure({ Auth: config.amplifyAuth });
}
async handleAuthStateChange(state) {
if (state === 'signedIn') {
console.log('We`re logged in, save state to User');
let user = await Auth.currentAuthenticatedUser().then(console.log(user));
}
}
render() {
const federated = {
google: '921567933214-naumeolsa1g0d9v1srcpno6l0p4hcnnh.apps.googleusercontent.com',
facebook: '597560987251007',
}
const map = (message) => {
  if (/user.*not.*exist/i.test(message)) {
    return 'That user does not exist in our database, have you signed in? Go sign in so you can help us look for Koalas!';
  }
  if (/user.*already.*exist/i.test(message)) {
    return 'Thats user already exists in the database, have you forgotten your details?';
  }
  if (/validation.*password/i.test(message)) {
    return 'You`re going to have to make a better password than that, we`re secure around here, we`re hunting for Koalas!';
  }
  if (/invalid.*phone/i.test(message)) {
    'Invalid phone number format. Please use a phone number format of +12345678900';
  }
  if (/incorrect.*username.*password/i.test(message)) {
    return 'You`ve got your username right, but the password you entered was incorrect, check that you don`t have CAPSLOCK on and try again.';
  }
  if (/incorrect.*username/i.test(message)) {
    return 'That user does not exist, if you haven`t signed up, hit signup and you`ll be searching for Koala`s in no time.';
  }
  return message;
};

return (
  <AuthWrapper>
    <Authenticator federated={federated} errorMessage={map} hideDefault={false} theme={KoalaCall} onStateChange={this.handleAuthStateChange}>
      <Greetings />
      <SignIn />
      <ConfirmSignIn />
      <RequireNewPassword />
      <SignUp />
      <ConfirmSignUp />
      <ForgotPassword />
    </Authenticator>
  </AuthWrapper>
);

}
}
export default (LoginPage);`

import React, { Component } from 'React'
import PropTypes from 'prop-types';

import config from 'config';
import AuthWrapper from './AuthWrapper';
import KoalaCall from './KoalaCall';

import Amplify, { Auth } from 'aws-amplify';
import {
Authenticator,
Greetings,
SignIn,
ConfirmSignIn,
RequireNewPassword,
SignUp,
ConfirmSignUp,
ForgotPassword
} from 'aws-amplify-react';

export class LoginPage extends React.PureComponent { // eslint-disable-line react/prefer-stateless-function
constructor(props) {
super(props)
};

componentWillMount() {
Amplify.configure({ Auth: config.amplifyAuth });
}

async handleAuthStateChange(state) {
if (state === 'signedIn') {
console.log('We`re logged in, save state to User');
let user = await Auth.currentAuthenticatedUser().then(console.log(user));
}
}

render() {
const federated = {
google: '921567933214-naumeolsa1g0d9v1srcpno6l0p4hcnnh.apps.googleusercontent.com',
facebook: '597560987251007',
}

const map = (message) => {
  if (/user.*not.*exist/i.test(message)) {
    return 'That user does not exist in our database, have you signed in? Go sign in so you can help us look for Koalas!';
  }
  if (/user.*already.*exist/i.test(message)) {
    return 'Thats user already exists in the database, have you forgotten your details?';
  }
  if (/validation.*password/i.test(message)) {
    return 'You`re going to have to make a better password than that, we`re secure around here, we`re hunting for Koalas!';
  }
  if (/invalid.*phone/i.test(message)) {
    'Invalid phone number format. Please use a phone number format of +12345678900';
  }
  if (/incorrect.*username.*password/i.test(message)) {
    return 'You`ve got your username right, but the password you entered was incorrect, check that you don`t have CAPSLOCK on and try again.';
  }
  if (/incorrect.*username/i.test(message)) {
    return 'That user does not exist, if you haven`t signed up, hit signup and you`ll be searching for Koala`s in no time.';
  }
  return message;
};

return (
  <AuthWrapper>
    <Authenticator federated={federated} errorMessage={map} hideDefault={false} theme={KoalaCall} onStateChange={this.handleAuthStateChange}>
      <Greetings />
      <SignIn />
      <ConfirmSignIn />
      <RequireNewPassword />
      <SignUp />
      <ConfirmSignUp />
      <ForgotPassword />
    </Authenticator>
  </AuthWrapper>
);
}
}

export default (LoginPage);

It's nothing out of the ordinary... Just returning the Authenticator wrapper in a div. Supplied all the right props to the Authenticator... but it won't show federated, it also won't allow me to show any custom areas, I have to keep hideDefault={false} or nothing will display at all. I'm not wrapping it around  because this app doesn't need this kind of functionality, it only needs one or two pages of the app authenticated.

I can sign in and out, and add users and get codes, forget password, the entire normal function of Authenticator... I can add errorMessages, themes, and I can set an onStateChange, ... but custom components within the Authenticator o.e.   ... soon as I hit hideDefault it's meant to show up any custom ones I've made, and hide everything default right? Doesn't work... hideDefault={false} shows both, the default and my imported ones, and federated shows nothing.

@michaelcuneo I ran into this last week too. It turns out that hideDefault was broken until recently: https://github.com/aws/aws-amplify/issues/357
If you use the latest aws-amplify (0.2.11, which includes aws-amplify-react v0.1.36), it should be fixed: https://github.com/aws/aws-amplify/releases/tag/aws-amplify%400.2.11


fix: make typings more accurate by avoiding explict cast on consts

Proposed change
When creating an object that is intended to be read-only, we should let typescript infer the type.
Not good:
interface NamedObjectMaybe {
  name?: string;
}
const UNMOVABLE_OBJECT: NamedObjectMaybe = {
  name: 'unicorn'
};

// UNMOVABLE_OBJECT.name is typed as string | undefined

Nice:
interface NamedObjectMaybe {
  name?: string;
}
const UNMOVABLE_OBJECT = {
  name: 'unicorn'
} as const satisfies NamedObjectMaybe;

// UNMOVABLE_OBJECT.name is typed as 'unicorn' but we still validate that UNMOVABLE_OBJECT matches the interface

Related issues

:bug: Fixes #(issue)
:rocket: Feature #(issue)

Do we really want systematically that?
It can be used in cases to avoid additional check or explicit ! mark but

Should we find a eslint rule that check that ?

Not sure it's going to be easy, explicit cast is still relevant in a lot of cases
You would need to detect that the object is not modified anywhere in the code
To be discussed


Speed up torch engine w8a8 model init

When using w8a8 model, it will cost a bunch of time for model loading. I found that when using
QRMSNorm.from_float()
## or
QLinear.from_float()

this func cal the per_channel_quant to get the scale and quanted weight, but it is useless. Because the para not load to model yet, it is just cal for all the zero... so I fix it when init the model on inference stage.

time cost(s)

cal the scale and weight
17

dont cal
0.08

And I tested it on internLM and internLM2

Hi @yinfan98 !
Thank you for your contribution, we truly appreciate it. We are just a small step away from achieving success. For the next steps, please refer to this document to configure the pre-commit then proceed to complete the lint check. We are looking forward to seeing the completion.

Hi, @yinfan98 thanks very much for the contribution.
Could you kindly provide the performance of w8a8?

@lvhan028 Sure, I will finish benchmark these days


default force rerun to false

As we're talking about it several times before I propose this solution. For now even when we add an extra info to the logger all steps will be re-run. As we provide the rerun flag I thik it'd be beneficial for everyone of we default the rerun to false and just infor the user about the need of the rerun when the model code was changed.
If you feel differently feel free to open the discussion below
#155

I completely agree. Just inform that they should rerun it


Fixes #1025: Adds input checks for lat2W

Coverage decreased (-0.004%) to 83.658% when pulling bdde9e049240113947d7e3af141d67a1c5e0e7ff on Algogator:edgecase into 35a577111118c83234d8aab26e4a999657af5bcd on pysal:master.

Coverage decreased (-0.004%) to 83.658% when pulling bdde9e049240113947d7e3af141d67a1c5e0e7ff on Algogator:edgecase into 35a577111118c83234d8aab26e4a999657af5bcd on pysal:master.


Drop deprecated definitions

I think these are all the deprecated definitions. If some are really recent and we will prefer to keep them during 1.x please comment.
For example I am not dropping the recent alias HTTP::Params mostly because there is no deprecation warning on it. But if others prefer it can be dropped in this PR also.

has_attribute? should be removed by reverting 1340fd9 and 5ebf6f0 since there is some extra code there to deal with a tentative macro deprecation mechanism.

@HertzDevil you mean reverting the name_loc forwarding to the macro interpreter, right? I think I prefer to keep those. Granted they are not used, but is a nice addition to improve error reporting in macros on future messages. The rest of those commits was reverted or adapted to annotations.

Looks like we missed Enumerable#join...?

Yeah. But that's not a big deal. Can be removed any time.


Article Refactor

Superceeds https://github.com/meanjs/mean/pull/800
@ilanbiala @rhutchison

@rhutchison Angular Stylized
I will fix the tests once we finalize the code.  Do the tests need to follow any sort of guidelines?

I'm not a fan of the IIFEs. Is anyone of the belief that what we have inside is actually being initialized as a global variable and should definitely not be there. It seems unnecessary to me.

@ilanbiala I think the point is to have a style guide and stick to it everywhere, whether or not it is functionally necessary.

I would second the IIDEs. Other than that, I've been following th John Papa style guide in my most recent project and love it.

@codydaig what benefit does the IIFE offer? I don't see us creating many global variables.

@rhutchison @ilanbiala @lirantal @codydaig Can I get a code review here?  I fixed the tests and everything is looking pretty good to me.  thx
As for the IIFEs, I think it is best practice and it is in line with our style guide, regardless if it is needed functionally.

I don't see us creating many global variables.

Other projects might, as it's a boilerplate. It's a good practise to pass on for others, especially for less experienced developers.

@simison the other thing is that I'm pretty sure these IIFes are set up incorrectly. The whole point is that there are 0 global variables. In articles.client.module.js, ApplicationConfiguration isn't passed in like it should be through the IIFE, but it is used as a global, so I'm not even sure why we are just adding IIFEs to add them. I'm still not in support of it, but if we are going to do it at all, then it should be implemented such that there are no global variables.

Other projects might, as it's a boilerplate. It's a good practise to pass on for others, especially for less experienced developers.

@simison With the architecture of this boilerplate, I don't see the need for IIFE's. As long as users of this project keep their project's architecture inline with this implementation, then there shouldn't be a need for us to introduce this particular best practice. I would even say it would be confusing to less experienced developers; whereas how it's setup now, it's pretty easy to understand & read the code.
If someone deviates from the current implementation, and finds that they need to implement this best practice, then they could do so. But it would be a conscious effort on their part, and they'd have a specific reason for doing so.

@ilanbiala @mleanos All valid points and good food for thought!

@ilanbiala You are correct on the articles.client.module.js and I will change that.  If you find any others let me know.
I don't think we should deviate from a style guide that we chose to use...  I think we need to stick to it otherwise how is a dev gonna know what to do and what not to do?

Would we be ok with angular being global?  Or are we passing that into the IIFE as well?

@ilanbiala I meant I agree with you. I don't like IIFEs at all. I dislike how your code starts indented vefore you even write your first line. As long as you concat before you minify and uglify, it doesn't make a difference.

Sounds like its been decided to not use IIFEs. @trainerbill go ahead and remove them. I'll be able to do a more through review later day as well.

@codydaig I don't know why we would decide that.  If we are going to have a style guide we should really stick to it.  Picking and choosing leaves gray areas.  Where was the discussion and decision made?  I know of 3 people that support them.

#636

@trainerbill we are picking a style guide and we are doing what makes sense for the framework. A style guide is exactly that, a guide for what you should do. It isn't a rulebook that says do everything exactly as I say. IIFEs aren't necessary because of the way our app is set up, therefore why add the complication and extra code that does nothing.

@ilanbiala fair enough.  Someone should make a MEAN.js styleguide then.  It makes it easier as a contributor to know up front what I need to do, rather than go through 50 code reviews for style issues.

@ilanbiala @simison @trainerbill @mleanos @codydaig I am personally in favor of IIFEs as it promotes best practices, consistency, and isolation from 3rd party modules.
In areas where we are defining function routeConfig() { .. } for each of our modules, and we are minifying our app, I would think without IIFEs that we will have issues (I haven't confirmed my theory).
I do not think a naming convention like articlesRouteConfig, usersRouteConfig, etc is a cleaner solution.  In-fact, when you consider other common declarations, this may end up being more keystrokes than having to create the IIFE in the first place.

+1 @rhutchison

@rhutchison +1 obviously

@simison before it seems like you supported my and @mleanos's points, but now you want IIFEs? @rhutchison I'd still change the name to be clearer because they shouldn't all be the same like that anyway IMO.

@ilanbiala I actually think that the naming should stay the same.  As long as we are in an IIFE it doesn't really matter, and it just makes more sense.  routeConfig over articleRouteConfig etc.  Will make the generator easier as well as it is less to code for in that regard.  Please let me know when a decision has been made.

@ilanbiala @trainerbill @rhutchison @codydaig @simison I think we can move forward with this and get it merged. If there are still some lingering concerns, we can address them apart from this PR. The remaining concerns don't seem to be blockers for this. The issue with IIFE's has been decided on, and we can re-address it later; if needed.

@mleanos I don't think that we have addressed all concerns.  If IIFE's are removed I am guessing our  functions in things like routeConfig are going to overlap.  I am all for getting this merged ASAP, so someone needs to let me know what I need to do.

@trainerbill I think we should try without IIFEs for now until we run into any issues.

@ilanbiala So if I remove the IIFE's from the test will this be good to merge?  I do not want to remove the vm from the controller/view.

@trainerbill the vm really doesn't fit into the current codebase. We have to stay consistent. When we update Angular, we will update what makes sense according to new conventions and better practices.

@ilanbiala So you want me to introduce scope back into the controller and remove the controllerAs syntax?

@trainerbill for now, we need to in order to keep the codebase consistent. It doesn't make sense to do it piecemeal and before even updating Angular.

We obviously need to decide on what aspects of the style guide we should use. However, for the sake of getting what we're in agreement with merged in, from this PR, I say let's leave out anything those out. We can address the issues of the style guide, and this discussion shouldn't hold up this PR. There are other PR's/Issues that are waiting on this to get finalized.

I agree with @mleanos about not mixing the two topics until we have a clear definition for the style guide, which is very much related IMO to a PR that @rhutchison should submit about adding ESLint so we can enforce the rules we want as well.

Someone please start a list of what it will take to get this merged and I will change it.  I am tired of this PR.

Let's remove the IIFEs. Address the other changes that @ilanbiala and I made in the line notes above to get this PR in. Then the style guide needs to be addressed before any other major PRs are submitted.
@lirantal @ilanbiala @rhutchison @trainerbill @mleanos @simison Any objections?

I deleted my last comment as I realized what would be a slightly better plan of attack in my mind:
Let's follow the JohnPapa style guide, no diversions from it. Then after this PR get,s merged in, we can address any specific changes that we want to make.
@ilanbiala @lirantal @mleanos @simison @rhutchison @trainerbill Any objections?

@codydaig I'm not a fan of that approach. If we introduce styles that haven't been decided on then as a boilerplate, dev users could end up adopting something we go away from.
I think it would be better to remove the style guide implementation in this PR, with the exception of the routes config, and revert back to follow the rest of the project. Once this PR is merged & we pin point exactly what we want to use from John Papa's guide, every contributor will understand exactly what styles need to be followed.
I'm very cautious about introducing code (styles) that we may revert later.

@mleanos your approach makes sense. I'm down for that Apple of attack.

@mleanos Feel free to submit a PR that only changes the route config portions.  I am not going to revert this entire PR back to that state, as there was way too much work put into fixing the tests among other things.  I am going to put the IIFEs back into this PR and style it exactly like the style guide.  Hopefully in the future we can agree on using the style guide as a rulebook and rebase/merge.  @rhutchison

@mleanos so no IIFEs or anything in this PR?

@ilanbiala That's what I think is best. So we could regroup, and decide on the styles we want. My original thinking was that the Style Guide integration was slated for a later release.
However, it appears we're at an impasse. Perhaps, we should just figure out the styles asap & move on from this issue.
Lastly, I'm not completely opposed to going with @codydaig suggestion of merging this as is; with the styles. I've expressed my concern over that option, but whatever everyone else wants to do, I'll go along with.

@mleanos @codydaig a big part is avoiding fragmentation and inconsistency. Any PR has to conform to the current style guide, even if there is no formal one.

I agree with @ilanbiala, let's not make a festival of coding styles and try to keep with what we have in the majority of the project, even though we might be heading a different way. Otherwise we'll just contribute to more spaghetti code

a big part is avoiding fragmentation and inconsistency. Any PR has to conform to the current style guide, even if there is no formal one.

My sentiment exactly.
@lirantal I'm in agreement
Full disclosure: I've recently lessened my stance on IIFE's, after a discussion with @rhutchison. BUT only in the context of the other aspects of John Papa's angular style guide being implemented. I'm not 100% convinced IIFE's will be necessary, but I won't be against them. What is most important to me right now is the consistency of the project, and these considerations not holding things up any longer. This PR shouldn't combine issues, by introducing styles that we haven't decided on.

@ilanbiala @rhutchison @mleanos

I've recently lessened my stance on IIFE's, after a discussion with @rhutchison. BUT only in the context of the other aspects of John Papa's angular style guide being implemented.

This is exactly my stance; if several parts of the style guide are implemented, it becomes much more important to implement IIFE's. If not, with the current structure they're indeed not that important.
+1 for opening a new issue for discussion.

imho, every PR for this release (0.4.2) MUST follow the angular style guide.  We will not release (0.4.2) until the project is consistent.  Once all of the features for this release have been merged, we will have a single PR to address anything that has not been addressed.
It is not fair to expect that 1 person take on the burden of re-writing everything in 1 PR to convert the entire app to conform to the style guide.  If the open PRs do not follow this rule, then everyone will before forced to follow the style-guide at some point - why not now?

@rhutchison people do use master code as well, so when they have inconsistent code it doesn't help them.

@ilanbiala We discussed that when we decided to move to committing to the master branch.  It is considered a work in progress until a git tag specifies a release.  There is no way we are going to get one PR to reformat the whole project.
@rhutchison I definitely agree.  Once we get this first PR merged it is not going to take long at all to reformat the other modules.  We just need this as the baseline.

If they're using master, they are using "latest".

This PR is up to date with the style guide, checks passing, and ready to merge if we decide to go with it.

any comments here?  Ready to merge?  LGTM's?

I'm not really a fan of these style guide conventions, so I'm going to defer until others chip in.

I know it was a painful commit/discussion - Thank you for working through it.
LGTM

@trainerbill There are a couple variable declarations that @ilanbiala pointed out in line comments that need to get fixed. Also, can you mark the tests as pending instead of commenting them out so they show up as needing attention? xit('', function () {}) instead of it('', function () {})

@codydaig Done. Rebase.  Traveling the next 2 weeks so my responses will be delayed if anything else needs to change.

@trainerbill this is for v0.4.2, can you please update and get this ready?
@ilanbiala any other changes required here for @trainerbill or can we move on with this for an v0.4.2 release?

@lirantal since this has some style guide stuff in this, we should probably finalize that first before merging this in to avoid refactoring it later.

Ok so maybe set milestone to 0.5?

@lirantal This PR is ready.

Cool. @ilanbiala's got it.

@trainerbill Can you update the last of the changes. Then I think this is ready.

@codydaig Haven't looked at this in a long time.  I think it is ready.  What do you think needs to change?

Commit message needs to be fixed at least.

There's issues in line comments specifying certain variable names and naming of services.

@trainerbill I just went through the diff notes, and there are some unaddressed issues...
For instance, https://github.com/meanjs/mean/pull/874/files#r40753755
https://github.com/meanjs/mean/pull/874/files#r38559922 & a few others.
Can you through the comments and double check? Also, it might be a good idea to do a rebase, when you update the commit message, and make sure everything is working still. Just a quick smoke check would be fine.

@trainerbill the vm concept was supposed to be removed because we haven't updated Angular yet, which should happen after this PR is merged, and will be the last thing we do with no new code being added so we can see exactly what happens when we update the code. @lirantal @codydaig do you want  to update to Angular 1.5 for 0.5.0 and release fewer features than we normally would so there is no more delay?

@trainerbill What was decided on how to handle a 400 (Bad Request) with this new UI route implementation?
For instance, when an invalid :articleId is provided, this will receive an error from the api call & not get handled on the client. Same for when the article isn't found.

@ilanbiala Why is updating Angular a factor in using the var vm = this; concept?
I've been using it in a MEANJS project for quite some time, and I don't see the relevance to what version of Angular I'm using.

@mleanos if I'm not mistaken, that line is for using controller as syntax, which we won't be doing piecemeal. We'll change whatever makes sense in terms of Angular implementation when we update Angular itself.

@ilanbiala I don't want to upgrade to 1.5 yet as it's still in beta. I'm not opposed to bumping to 1.4 which is only one minor version bump from where we are currently (1.3) and i don't think using the controller syntax needs to wait until the version bump.

@codydaig I think 1.5.0 will be released in the next month or so. They have already released rc.0, and they took just over a month to release 1.4.0 from that point. I'm fine with using controller as, but I'd prefer we don't just do the article controllers and then do the rest later piecemeal, because that usually doesn't work well.

how about we wait, and then upgrade to angular 2?

I don't see problem having the controllerAs syntax in just the Articles module. I thought our plan was to roll out the Angular Style-guide one module at a time; as to not complicate PR's. For instance, in my #807 , I was planning on implementing the Angular Style-guilde; including the controllerAs on the states.
Using this syntax in one module, has no affect on any other module.

@lirantal What are you suggesting we wait on?
Using the controllerAs syntax? Or just upgrading Angular?
My vote would be to just wait on upgrading Angular, unless we see a benefit of doing so earlier. Then once we're ready, we upgrade to Angular 2.

it was part joke, part serious.
is the effort in upgrading to newer versions of Angular (which are not the angular2 version) worth it?

Honestly, I don't see Angular 2 as very well accepted right now considering all the fundamental changes, and Angular 1.x still has a lot of improvements over 1.3, so I see a point in upgrading. @mleanos I'm for the syntax, but not piecemeal, because then we release that because we forget and then users have fragmented code.

@ilanbiala I think we can get each module updated to use the new Angular Style-guide, as part of the 0.5.0 release; as was the plan anyway. Having "fragmented code" doesn't pose any issues for our users, if they get this implementation in piecemeal anytime between now & when we release 0.5.0
I don't think going at every module for the Angular Style-guide implementation is wise. That PR would be too big, and the contributor may face problems that are unique to one module; thus, blocking the changes for the other modules that shouldn't have anything to do with the module posing the issue.
Let's continue with the plan to introduce John Papa's Angular Style-guide as part of 0.5.0. There's a lot of benefit in the style-guide, and it will help keep the framework clean (and DRY) as we implement more architectural changes; for instance, Token-based Auth. Not to mention the guide advocates for best practices.

As for whether or not to upgrade Angular.. I think upgrading to Angular 2 won't happen anytime soon for this framework; we should wait until it's more mature & we have the bandwidth to handle that upgrade.
I don't really have much of an opinion about upgrading to Angular 1.5. I don't see it introducing any drastic changes that would affect what we're doing on the front-end. And still, I don't see the relevance of what version of Angular we need to use controllerAs in our states.

+1 for controllerAs syntax in all modules, and not piecemeal.
That seems like too much overhead if some modules implement it, while others do not. It adds to the concept count instead of reducing it. The truly "core" modules of the boilerplate are core and users, and those should have controllerAs implemented before anything else. But once those are done, switching Articles to controllerAs would, I think, go more smoothly. At least you would know all modules are trying to adhere to John Papa's guidelines, instead of only some.

@mg1075 How does having controllerAs create overhead for other modules?
I think introducing John Papa's Angular style-guide in Articles first, is the best course of action. It's our basic CRUD module, and is provided as an example to go off of. It's more important for us to have that precedent over the other modules.

@mleanos Angular 1.5 has much better performance, introduces some breaking changes (both good and bad), and some new features that users will definitely benefit from. I think upgrading it will help. I'm all for the style guide, but I'd rather do every feature all at once rather than each feature piecemeal, because inevitably we're gonna miss a little bit of legacy code.

@mleanos - I think there would be overhead if controllerAs is not used in all modules.
If controllerAs is only used in one or two modules to start off, now a person has to start switching between patterns: this view and controller use controllerAs, this view and controller don't; this view and controller follow the angular style guidelines, this other view and controller don't.
One advantage of using controllerAs noted in the guidelines is:

Why?: Helps avoid using $parent calls in Views with nested controllers.

Imagine I have an app where there is an angular Controller that is a parent controller, sort of like a shell controller for an app. And then, of course, I have a controller nested inside. Using controllerAs means I won't have to use $parent, and in a framework like MEAN.JS where - in my experience - you have to jump around from place to find things, avoiding the use of $parent will make the code easier to read. But this is unlikely to happen unless core and users use controllerAs.

@mg1075 I'm advocating to use controllerAs. But I would rather avoid tasking one contributor with implementing this style into every module in one PR. I would rather see this done by multiple contributors, in a shared branch; which is what I view master at this point, since our next release is a major bump to 0.5.0.
IMO, most users of this framework don't modify the core, or users module. They take our example CRUD (Articles) and use it as a guide for developing their own custom modules. This is another reason why it makes more sense to implement the style-guide into the Article module to start.

@mg1075 I'm on Gitter right now, if you'd like to discuss this there. To avoid cluttering this issue.

@mleanos @mg1075 @lirantal @ilanbiala I'd much rather see it broken up by module rather than one large PR. Because that PR is going to be a nightmare for anyone doing it if any changes are made along the way. All modules need to be switched over before 0.5 is released though to avoid overhead. The master branch is considered development, so anyone using it in production runs the risk of some type of overhead as not all proposed changes will have been made yet.

@codydaig do you want to oversee that then? It's fine if people submit PRs too, but if not then would you be able to refactor that code? I'll gladly review it as well to help out.
Also, one thing that I'd want to see if we're doing it now is avoiding $scope as much as possible. https://toddmotto.com/no-scope-soup-bind-to-controller-angularjs/ http://blog.ninja-squad.com/2015/07/21/what-is-new-angularjs-1.4/ have suggestions on how to do that, but they require Angular 1.4.

@ilanbiala I can oversee that. I've worked with the John Papa style guide. (Actually more familiar with that then using $scope.) I agree, $scope shouldn't have to be used anywhere with the ControllerAs syntax. I will try upgrading Angular and see if it breaks anything. These next 2 weeks are crazy for me, but come January I should be able to crank these out.

@codydaig - recall @rhutchison comments in gitter about using controllerAs:

it seems to be working well, I am still adopting it in another project
we change to best-practice as we touch files
only thing that sucks is though may not be able to remove $scope from DI
for things like $scope.$apply(), $scope.$emit(), $scope.$watch, etc.
but controllerAs is working well

...and...

one thing I came across today, is in instances like a menu or tab system, where I use
templateProvider/controllerProvider on my routes to dynamically set my controller/templates, there
is no controllerAsProvider, so I need to define my controller like so HomeController as vm
example

function controllerProvider($stateParams, companyTabs) {
                    if (companyTabs[$stateParams.tab].controller) {
                        var controller = companyTabs[$stateParams.tab].controller.split(' as ');

                        if (companyTabs[$stateParams.tab].controllerAs) {
                            controller[1] = companyTabs[$stateParams.tab].controllerAs;
                        }

                        return controller.join(' as ');
                    }
                }],

I'd like to undertake the refactoring of the Users Admin feature. I have a good amount of experience with John Papa's styleguide as well.
As for the use of $scope, we don't need it in any controllers. For anything that needs to use it like $broadcast, $emit, etc., then that functionaly should be abstracted out into services, and/or directives.

@trainerbill @rhutchison what's the plan here?

@trainerbill clean up the commit message and squash the commits - LGTM

@trainerbill clean up the commit message and squash the commits - LGTM

@trainerbill There's a reference to a merge conflict still in the code.. I commented on the line that has <<<<<<<< HEAD ...
Also, there are some older line comments that haven't been addressed.

@trainerbill There's a reference to a merge conflict still in the code.. I commented on the line that has <<<<<<<< HEAD ...
Also, there are some older line comments that haven't been addressed.


WIP: Remove space between class and member names in *.cxx files

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@hjmjohnson Do you also like this commit? I realize, you wrote that regarding code formatting, "automation is key", while this commit is only semi-automatic!
If you don't like this commit, it would be OK to me to close the PR without merge. No problem. Because it's really a very minor cosmetic thing to me. But if you do like it, I think I should adjust the *.hxx files as well.

I love this commit !!

@hjmjohnson Thanks, I'm glad to hear so  :-)  You know it's partially a matter of taste, so I can image that some people actually like to have a space before the ::MemberName. But still it looks like a Clang-Format bug anyway.
For the sake of completeness, I think I should also do the *.hxx file, before the PR is ready!


Add support for gatsby-plugin-image

Motivation
The next version of Gatsby will include a new image plugin to replace gatsby-image. It follows latest best practices to deliver better performance and improved Lighthouse scores. The plugin includes a toolkit to allow plugin authors to add support to their plugins. This PR adds support to the Kontent plugin, via a new component which accepts an image object. This uses the Kontent image transformation API, so does not require image downloads. It works on its own, or via a RichTextElement. Usage is like this:
import { ImageElement } from "@kentico/gatsby-kontent-components"
// ...
        <ImageElement
          image={data.author.elements.avatar_image.value[0]}
          width={200}
          height={200}
        />

It depends on the next  version of gatsby-plugin-image, so this should not be released until that is stable, which will be at the end of the month. This can be tested now as the dependency is targeting the nightly release.
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
See the example site

The tests are failing because the next version of Gatsby requires Node 12, and your Netlify image uses Node 10.

I've already updated node env to 12, all tests are passing now.

Hi @ascorbic, thank you for a great pull request. Overall, it looks really good to me. I've just found some minor issues I believe are worth mentioning. I reckon this PR doesn't need to solve or fix them whatsoever. I just want to clarify the user's scenario.

I've noticed, the user cannot specify
Device pixel ratio
Source rectangle region
Focal point crop
Output format
parameters for Kontent's image API in getGatsbyImageData. Is this on purpose? From my point of view, it should be straightforward and I'm just wondering whether there's any reason for omitting them.

If a developer does not specify a fit param for Kontent API, the component will use fit = 'crop' by default. This is in contrast with Kontent's default fit='clip' value - is there any particular reason for this?

I was thinking about the format='auto' hardcoded value. I believe it's a good idea to try serving WebP first, however, I think the fallback format fm might be needed and beneficial for many scenarios.

Some unused variables (in new and old code as well) - I can lint and clean it separately after merging this PR.

One last sidenote - in your docu I found it difficult to understand the real difference between the old and new (beta) image plugin. From my point of view, the main difference is the strict differentiation between a static image and a gatsby image in the plugin. Are there any other significant changes I should be aware of?

I don't think these my findings are blockers for the PR, nevertheless, I'd like to clarify reasoning and understand problematics deeper.
ping @Simply007

Hi @makma
Thanks for the review. The reasons for not including dpr, is because we handle that separately by passing the actual required resolution.
We default to fit=crop because that matches the behaviour of the standard component, so it's what users would expect if they're looking at the docs. It also generally works better with the component implementation. We handle maintaining aspect ratio ourselves if required.
We leave out format, because we expect to handle that automatically. Can you explain why fm=auto is not sufficient? As a general rule we're aiming to default to best practices, so would always want to deliver next-gen formats if supported. We allow users to override it for sharp simply because there's a cost in build time, but that won't apply in a CDN, which is why we recommend auto format whenever it is available.
The new image plugin is a complete rewrite. The old component was suffering a lot with bad LCP, and so bad Lighthouse and PSI scores. It also wasn't using the most modern browser features. The new plugin is probably the most performant way to do images in React, mainly because it can handle lazy loading and blur-up before React hydration happens.
The other benefits are less relevant with Kontent, as they apply to the way images are queried in GraphQL, which the plugin doesn't implement in the same way.

Thank you for the explanation @ascorbic , your notes make sense to me.

Can you explain why fm=auto is not sufficient?

This was just food for thought. It might be a very niche scenario (and maybe it's not whatsoever).
I was thinking when the original asset is .jpg,  and the user's browser does not support WebP format, without the fm param, the Kontent's API returns the original asset format - in this example .jpg. With the fm param, the developer could specify asset fallback format eg. to .png (if WebP is not supported).

Ah ok, I understand. We deliberately make that very hard to do, as it's usually not what the user intended.

Sounds reasonable. Thank you for the clarification.

I have cherry-picked the commits to the "gatsbyv3" branch for alpha release (see #174)

TODO: add (probably) missing info about adding gatsby-plugin-image to gatsby.config.js

Hey, @ascorbic 👋 I'm testing the new image plugin on my personal site and I noticed the component does not work if I don't provide width and height properties - either in the image object directly or in the component's props. I suppose props should be mandatory. Am I right?
What's the practice - should I provide width and height parameters in image objects or in props? This seems ambiguous to me or I missed something.
Note:  Or might be it caused by preact? In the end, I'm getting an error from preact:
debug.module.js:1 Failed prop type: The prop `src` is marked as required in `Y`, but its value is `undefined`.
  in Y
  in Picture
  in MainImage

Thank you for the clarification.

@makma It expects the image object to contain the width and height of the source image. You can also pass the width and height to the component if you want to display it at a different size. I'm not sure where that src error is coming from though. Are you trying to use StaticImage?

Thank you @ascorbic for the answer.
Regarding params image object vs. props
Oh, got it. At first, I thought it works this way, but then I made some validation mistakes which confused me. I can confirm it works as you described - params from image object are propagated to query, props are propagated to image element dimensions - works as intended. Great, thank you.
Regarding error message
No, I use the image component directly like <ImageElement ....
Code: https://github.com/makma/martinmakarsky.com/blob/bc9cd34f6447f8911236f5130d552c960eba1f0e/src/components/TwoColumnImages/index.jsx
Console error:

Those warnings are also suspicious, though.

I'm also wondering how this new approach fits or is aligned with gatsby-transformer-kontent-image plugin.
From my understanding, the new plugin provides a full feature set and covers scenarios provided by already existing gatsby-transformer-kontent-image. @rshackleton, do you think there are any valid scenarios for gatsby-transformer-kontent-image that are not covered by the new plugin?
I believe this is an important topic to cover in the documentation and give a clear message about which plugin to use and what is the preferred path.
Thank you.

I think the new gatsby image implementation in this plugin will render my plugin obsolete for gatsby@3 and gatsby-plugin-image users. I believe the new implementation covers all of the use cases, aside from those wishing to have their Kontent assets downloaded and served locally.
Once this has been merged and release I'll update the readme of my repo with a message for Gatsby v3 users to look at the documentation for this new functionality. :)
Happy to see this landing in the official plugin, will simplify the adoption of gatsby-plugin-image for new developers!

Thank you for your quick response @rshackleton. This sounds great to me. Once this is released, I'll contact you about the next steps. Thank you!

We might want to additionally add a resolver to access the images using GraphQL (without downloading them). I didn't add one because this approach was simpler, but it might be useful in some scenarios. There's more info in the plugin toolkit docs

All the changes were cherrypicked into https://github.com/Kentico/kontent-gatsby-packages/pull/174.
Version 7.0.0-beta.0 has been released.
After validation of beta, https://github.com/Kentico/kontent-gatsby-packages/pull/174 will be merged into master.

Thank you @ascorbic, @rshackleton for your collaboration 🙌


Add workspace bookmark manager

From<EMAIL_ADDRESS>on 2012-10-04T14:55:30Z
For different work contexts there may be different workspaces:

scientific work
Web-development
other bug squashing...

So the user may keep the workspaces separated.
It would be nice to have a workspace bookmark list that allows easily switching between these.
Sessions shall be saved on a per workshop bases.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1164

From ccordoba12 on 2012-10-08T09:54:10Z
What do you mean by workspaces? The variables that are currently defined in the console and shown on the variable explorer? or something like a project, i.e. an associated directory with a certain set of preferences?
If you mean the second, you probably know that Spyder has some project facilities right now, but they are not so good. We'll try to improve them for 2.3, incorporating something similar to your suggestion, i.e. adding a list of the last opened projects.
If you mean the first, we could save the current variables when a project is closed (as RStudio does). This way, next time a user opens his/her project, its session will be restored. But again this is work for 2.3 :-)
Labels: MS-v2.3 Cat-SpyderGUI

From ccordoba12 on 2012-10-10T09:04:05Z
Ok, I'm glad I understood what you meant!
This will definite improve Spyder to let our users work on different large scale projects at the same time. I'm really hoping to see this soon too (hopefully in the next 6/8 months).

From<EMAIL_ADDRESS>on 2012-10-09T12:55:25Z
>or something like a project, i.e. an associated directory with a certain set of >preferences?
Yes, this one.
The one you set on the top of the project explorer.
>i.e. adding a list of the last opened projects.
Exactly!
Any project works used may be added to this list until the user presses a button to clear it.
Nice.

From pierre.raybaut on 2013-05-11T05:51:31Z
Labels: -MS-v2.3 MS-v2.4

From pierre.raybaut on 2012-11-04T13:17:47Z
Summary: Add workspace bookmark manager
Labels: -Type-Defect Type-Enh

It would also be great if not all the projects in a given workspace have to reside in a subfolder of siad workspace, e.g. when you work on two projects which are connected, but reside in different places (like on a network folder, or in a site-packages folder,...)

This is basically session management. So closing as duplicate of #1704


Update out-of-tree-platforms.md

Updates macOS to point to microsoft's react-native-macos, remove WPF from RNW since that's no longer supported.

CC @TheSavior @alloy


UI Improvements

Cherry picks all commits from #840 into master.

Coverage decreased (-0.02%) to 91.551% when pulling f1850d56f1827bd3ae9967758374961b0e9c3dad on tgianos:uiChanges into 973126223ddb48cb2c00329f0bbf5ba6a3417a75 on Netflix:master.


Displaying the current time in a different time zone

Does anyone know how to do this in polybar? I want to display the current time in my time zone as well as the current time in another time zone.
In bash, the current time from a different time zone can be displayed with:
TZ=Asia/Singapore date

You could use the custom/script module for this. For example:
[module/tz]
type = custom/script
exec = TZ=Asia/Singapore date +"Singapore: %H:%M"
interval = 30

Thank you! Worked like a charm

Sorry to open this back up, but is there a way of getting date-alt like function out of the script module?
I want to be able to multiple timezones on my bar and I'm unsure of how to do it with script or the date modules.

@thebitstick do you want to cycle through the time zones when clicking or what do you mean?

@jaagr either cycling when clicking or automatically after an interval

It would be great to have a TZ setting for the date module

@squigglezworth please open a new issue for this feature request.
@thebitstick you could use the click-left setting in the script module to somehow send information or toggle a state that the script that prints the date in a certain timezone can read and set the timezone accordingly

@patrick96 it's not enough to toggle, I need more than two timezones and they should be automatic
I had this functionality with py3status for i3bar

@thebitstick what do you mean by automatic? With click-left you can call any script so you can implement any functionality you want, including multiple timezones, you just need to somehow send information from the click-script to the script that displays the time

Automatic as in it switches without needing to press anything.
Like a slideshow.

You can easily do that in a script
i=0
while true; do
# Figure out the timezone from the index
...
date
i=$((i+1))
sleep 5
done

@patrick96 This one and #596, for starters, are both related to the feature I want.
Funnily, #596 references this one and is closed, even though that's exactly the feature I want.

@squigglezworth I didn't know about #596, I'll reopen it and we will start tracking that feature request over there.
I just didn't want to track a feature request inside an issue that is already resolved with a workaround


[website] Use span for icon image

Found this issue while migrating pages to CSS theme variables. The Box defaults to div which can not be used inside a Typography.

[x] I have followed (at least) the PR section of the contributing guide.

Nice, I didn't saw it in https://github.com/mui/material-ui/pull/33545/commits/b164c9dbe24c58640cacbaea52bea6897c560596.


Questions about the shadow denoising method used

Hi, thanks for making the sample freely available!
I haven't ran it yet, so sorry if this is a question that would be explained by doing so. I'm curious about what method you're using for shadow denoising here. It appears that you're doing some temporal reprojection stuff and then running it the output through an A Trous filter? Is there a reference that you used for this method? It seems familiar to the AMD FidelityFX shadow denoiser which unfortunately is a bit un-documented as well.
Shadow denoising seems to be an aspect of ray-tracing that doesn't have many good implementation guides, so any recommendations would be appreciated! Thanks in advance!

Hi,
Sorry about that. I’m currently writing an accompanying blogpost that explains all the techniques used in the demo.
But yeah, the shadow denoiser is based on SVGF and uses a temporal accumulation pass that borrows a few tricks from the FidelityFX denoiser. The blogpost would go into further detail so I’ll link that here as soon as possible :D

Oh okay, fantastic! Looking forward to the blog post!

Since the article is now live (https://diharaw.github.io/post/adventures_in_hybrid_rendering/) thanks for that.
This github issue isn't really the best place to ask, but since implementing this is probably still relatively fresh in your mind I would like to know your opinion on something:
One thing that keeps coming up in literature is that people use variance (temporally or spatially) to adjust filtering for the level of noisyness in regions. But certain sources (e.g. http://casual-effects.com/research/Heitz2018Shadow/Heitz2018SIGGRAPHTalk.pdf , slide 52 onwards) point out that variance is not a particularly good measure for noise and suggest alternatives (total variation in this case). Have you considered trying out other measures (instead of variance) to measure the noise of pixels over time or regions of pixels?

@TravisGesslein I haven't actually tried the other methods yet. I did skim over that paper yet but I wanted to have some working implementation as a starting point before I tried out anything more exotic. I'll definitely look into that though!
@expenses The blog post is live as mentioned in the last comment. Please let me know if you've got any questions.

Hey, this blog post looks perfect! I'm also going to make a renderdoc capture to examine it closer, but I have a good idea of what to do now.


feature: allow use image by digest id

Basically, the user can use sha256:xyz to inspect image or run
container.
Signed-off-by: Wei Fu<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Enhance the Image Manager: Allow user to use image digest-type ID to consume pouch image.
For example, we pull busybox:1.28 by pouch. After pulled, the use can use the following method to inspect the image:

pouch image inspect 8ac48589692a
pouch image inspect sha256:8ac48589692a
pouch image inspect busybox:1.28
pouch image inspect busybox@sha256:58ac43b2cc92c687a32c8be6278e50a063579655fe3090125dcb2af0ff9e1a64

Ⅱ. Does this pull request fix one issue?

Fixes #1348
Ⅲ. Describe how you did it
Update the imageStore search functionality. We add the `sha256:" If the refOrID miss.
BTW, both the Delete and Search functionality should use the following method to check the reference is ID or not.
reference.IsNamedOnly(ref) || strings.HasPrefix(id, ref)

Ⅳ. Describe how to verify it
One of case is Use the Digest ID to run container
➜  pouch run -it sha256:8ac48589692a53a9b8c2d1ceaa6b402665aa7fe667ba51ccc03002300856d8c7 ls
bin   dev   etc   home  proc  root  run   sys   tmp   usr   var

Ⅴ. Special notes for reviews

Codecov Report

Merging #1351 into master will increase coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
+ Coverage   17.32%   17.34%   +0.02%
==========================================
  Files         189      189
  Lines       11823    11828       +5
==========================================
+ Hits         2048     2052       +4
- Misses       9627     9628       +1
  Partials      148      148

Impacted Files
Coverage Δ

cri/src/cri.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/image.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/container.go
0% <0%> (ø)
:arrow_up:

daemon/mgr/image_store.go
81.35% <100%> (+0.65%)
:arrow_up:

daemon/mgr/volume.go
0% <0%> (ø)
:arrow_up:

I've figured out the logic of the code and test it on my local machine, it works fine.
LGTM


Improve Traffic Monitor 2.0 Cache Polling Performance

Currently, Traffic Monitor 2.0 cache polling takes an unacceptable amount of time.
The current poll takes about 2 seconds per cache, which is about 10 minutes for all caches.
Traffic Monitor 1.x polls all caches in 8 seconds.
A poll of 8s is acceptable. A poll of 250ms is ideal. We should fix Traffic Monitor 2.0 performance until it's somewhere in the middle, and until we start getting diminishing returns.
It is definitely worth making it as fast as we can, even beyond 8 seconds, because the poll time directly translates to the length of time we continue sending customers to a downed cache.

The biggest bottleneck is the Delivery Service stats aggregation, deliveryservice/stat.go, in CreateStats, in the loop which calls processStat.
Suggestions:
Move processing which is per-cache into the same microthread (goroutine) which polls the cache, in order to parallelise it. The CreateStats function is must be largely sequential, because it aggregates data into a single structure.
Optimise stats string processing. The processStats functions do a lot of string processing and searching, to figure out what a stat means. String processing is slow, and can probably be optimised (regexes or not, searching from the start or end, splitting or not, etc).
Change the manager healthResult selector to read from the queue, until it's empty or a predetermined time or number is reached, and then process in bulk. If CreateStats is the bottleneck (likely), deliveryservice.CreateStats aggregates, so there's no reason it needs to be called for every single cache result. If cache results are backed up, it only needs called once after they're all accumulated into the data structures it uses.
As a large step, aggregation can be sped up with a Parallel Prefix Sum (see https://en.wikipedia.org/wiki/Prefix_sum#Parallel_algorithm and https://www.amazon.com/Fundamentals-Parallel-Processing-Harry-Jordan/dp/0139011587/).


Drawer getting stuck on swipe

The Drawer get stuck sometimes with no reason, it often happen on view that have gestures features like drag, scrolling or swipe
My Environment

software
version

react-navigation
"^1.0.0-beta.8"

react-native
"0.42.2"

node
v6.9.2

npm or yarn
3.10.9

Experience same behaviour when in debug mode - not sure about release, haven't run that. How is your experience in release run?

Happens to me as well.

@Andreyco i tried few times with android release version, it still happen

Same problem on debug and release versions.

Same problem on Android, could you please investigate it? It makes user's experience much worse.

This should be resolved in recent react-navigation release.

@Andreyco thank! it's worked great, didn't face this issues after i update to latest version


images with spaces not rendering

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
When adding an image with spaces in the filename, it is broken in the media manager:

Also broken on the site

Reproduction
https://github.com/tinacms/tina-cloud-starter
Steps to reproduce
Add an image with a space to the media manager
System Info
System:
    OS: macOS 12.5.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 2.32 GB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 16.18.0 - ~/.nvm/versions/node/v16.18.0/bin/node
    Yarn: 1.22.19 - ~/Documents/forestry/starters/tina-cloud-starter/node_modules/.bin/yarn
    npm: 9.1.2 - ~/.nvm/versions/node/v16.18.0/bin/npm
  Browsers:
    Chrome: 113.0.5672.126
    Firefox: 113.0.1
    Safari: 15.6.1
  npmPackages:
    @tinacms/cli: ^1.5.14 => 1.5.14
    tinacms: ^1.5.6 => 1.5.6

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

Fixed by https://github.com/tinacms/tinacms/pull/3994


Error 404 Ikigai mangas

Source information
Ikigai mangas 1.4.5
Source language
Spanish
Steps to reproduce
It occurs since the last update that the 404 error jumps with any chapter that is tried to open. It's not a problem of the origin because I've already checked and it's fine
Expected behavior
Function properly
Actual behavior
Error 404 always occurs when trying to open
Mihon/Tachiyomi version
TachiJ2K 1.7. 4
Android version
Android 13
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

TheI tried it right now but the same error still exists


Update Castle Windsor

Hello,
I see there is, from a long time, a Castle Windows update (now 4.1) but cannot update because Radical Requires Windsor < 4.0.0. Will this be updated or it's incompatible?
Thanks

Thanks for raising this @danielearrighi. It should not be a problem to update to latest Castle release. I’ll have a look.

It took more than a year, but finally we're able to continue supporting Radical.
I raised https://github.com/RadicalFx/Radical.Windows.Presentation.CastleWindsor/pull/32 to update the repo with many new things, including Windsor 4.x. As soon as the PR is approved I'll release a new major, and then if you're still interested I'll release another major to support Castle Windsor 5 (if there are no breaking changes for us, I still need to dig deeper).


Fix socket leak by ensuring HttpClientResponse is properly consumed

This fix a socket leak in NetworkImage IO implementation, that happens when a non Ok http code is returned.
In that case the HttpClientResponse was left unconsumed, and a underlying socket opened.
https://github.com/flutter/flutter/issues/78741
This quick fix ensure the socket is properly closed, by listening to the response and cancelling the stream.
As an alternative we may want to consume (and ignore) the whole response, so that the socket can be reused if kept alive.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@googlebot I signed it!

@alexd6631 The email address associated with your github commit doesn't match the email address you used to sign the CLA. That's why the CLA bot is not happy. Can you please fix that?
Also, this will need a test and it looks like it is failing some existing tests.

Hello @goderbauer.
Unfortunately I don't have the time to invest the test suite in the short term, but I may be able to investigate it later (I am investigating Flutter for personal use on my free time, and will be busy in the upcoming days).
So if an official contributor wants to tackle this issue, feel free to close this MR and create a proper one.
The aim of the PR was to pinpoint the location of the socket leak, and a potential fix for it. A quick local test on my toy app, show that it indeed fixes the leak, preventing too many open files error.
It is likely this issue could affect a production apps (although you need to have a lot of HTTP errors during image loading for it to trigger), so you may want to give it a high priority.
I only reported the issue on iOS, but from the look of it, it could affect other (non web) platform which also use a HttpClientResponse.

Okay, looks like you filed an issue to track the leak. I am going to close this PR for now until somebody has time to look at it in more detail.


Add fix to be able to use NKey + Seed auth handler and username + pas…

Updated PR based on discussion in https://github.com/nats-io/nats.java/pull/1129
When trying to connect to a NATS server with Auth Callout, the client may be required to use a combination of an auth handler (NKey + Seed) plus user info (username + password). Currently, only either auth handler or user info is append in the options when building the client options string.
AuthHandler authHandler = Nats.staticCredentials(jwt, nkey);
Options connectOptions = Options.builder()
.server(serverUri)
.authHandler(authHandler)
.userInfo(username, password)
.build();
This PR fixes the behavior in the client options to allow the usage of an auth handler in combination with username and password.

Dear @scottf thanks for your review. Is there something missing or anything I can do to have this merged? Thanks in advance!


[EnhancedTextarea] Guard for if scrollHeight is not present

Hello!  I'm using Material UI and testing the app in Mocha with jsdom (and using Enzyme).
When running tests using TextField, I see React warnings like this:
Warning: `NaN` is an invalid value for the `height` css style property. Check the render method of `EnhancedTextarea`.

This appears to be happening because EnhancedTextarea is using an element's scrollHeight and jsdom doesn't do layout and support this (https://github.com/tmpvar/jsdom/issues/1013).  That undefined value flows through until it leads to the NaN bug shown above.
This pull request guards for the existence of scrollHeight, which fixes this warning and would help other folks testing their Material UI apps in a jsdom environment.  Although supporting this test-only code in the Material UI codebase is a great direction, and I've made no effort to look at other components that might have similar gotchas.
If other folks have ideas about what would make sense here, that would be great.  Thanks!

I confirm, I was able to reproduce the warning on our test infrastructure using the mount API of enzyme. That looks good to me 👍 .

@oliviertassinari great, thank you!


Extension doesn't work with the last Github update

It does work in https://github.com/stars but not in the profile tab stars.

I have been working on a extension similar to that, check it out:
https://github.com/gabrielgodoy/github-stars-manager

@gabrielgodoy Cheers, I will take a look!

@jpardogo Hi, the latest version (1.0.3) brings back full compatibility for the https://github.com/stars page. Sorry for the wait.


Add return/go back/cancel button when in the workflow development view

Users are tempted to click the back button when they can't find a way to cancel out of the workflow creation and this results in confusion since they return to the view analyses page instead of the analysis they're in.
I tagged it for the analysis plugin, but the same is true for the processing workflow creation.

The back processing takes you back to the study list vs. the study you were processing.

The workflow development page has been removed, so need for this anymore.


Commercial or no?

I understand that this repo has the MIT license. I just want to double check though, XTTS was licensed by coqui correct? So their non MIT license applies to the output from XTTS?

Yes, whatever you generate using XTTS is tied to coqui's license.
The MIT License for this repo only encompasses the code used to form the UI, not the model weights nor output of whatever models are used.


ViewPager: FastScrollerThumbView not being hidden after changing page

Hello,
I'm in the process of rewriting from scratch an app and I'm now using ViewPager.
I noticed that if you swipe and accidentaly touch the Fast Scroll Indicator the thumb view is shown remaining visible even if the touch is finished.
If You touch the indicator the thumb gets hidden.
Video showing the issue: https://youtu.be/Q-6w3hpBWEA
This is happening in lib version 1.1.0, Android version: Oreo  :)

Confirmed, thanks for the report! We probably need to handle MotionEvents (ACTION_CANCEL?) a bit better. Will check it out.

Should be fixed by 1.2.0.


splitter-width setting

is there a hidden setting for the width (height) of the splitter itself?

not yet


PushNotification doesn't fire registration event

Expected Behaviour
After init raise registration event
Actual Behaviour
the pluginis not to be signs of life
Reproduce Scenario (including but not limited to)
var push = PushNotification.init({
	    	android: {
	    		senderID: "xxxxxxxxxxx"
	    	},
	    	ios: {
	    		alert: "true",
	    		badge: "true",
	    		sound: "true"
	    	},
	    	windows: {}
	    });

	    push.on('registration', function(data) {
			alert("registration - "+JSON.stringify(data));
			// Success -- send deviceToken to server, and store for future use
			$http.post(urlApi+'/notification/register', {registration_id: data.registrationId, platform: ionic.Platform.platform()})
			success(function(data){
				alert("SUCCESS");
			})
			.error(function(err){
				alert("ERROR - "+JSON.stringify(err));
			});
	    });

This code doesn't raise any alert()
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
PhoneGap (iOS / Android / Windows)
cli-5.2.0 (3.9.1 / 4.1.1 / 3.8.1)
Smartphone with Android version 5.0
Logs taken while reproducing problem
I also using try catch around all this code example but it doesn't fire anythings

Can you get the adb logcat output when you launch the app?

I don't know how do rhis. Can you link me a guide?

I don't know how do this. Can you link me a guide?

@ilvalerione http://developer.android.com/tools/help/logcat.html

02-24 07:21:11.308: E/GMPM(2629): GoogleService failed to initialize, status: 10, Missing an expected resource: 'R.string.google_app_id' for initializing Google services.  Possible causes are missing google-services.json or com.google.gms.google-services gradle plugin.
Could be usefull?

push.on('error', function(e) { 				alert("ERR - "+JSON.stringify(e)); 		    });
i'm catch error but e={}
And in DDMS console:
[2016-02-24 13:58:18 - ddms] null
java.lang.NullPointerException
at com.android.ddmlib.Client.read(Client.java:731)
at com.android.ddmlib.MonitorThread.processClientActivity(MonitorThread.java:311)
at com.android.ddmlib.MonitorThread.run(MonitorThread.java:263)
[2016-02-24 13:58:18 - ddms] null
java.lang.NullPointerException
at com.android.ddmlib.Client.read(Client.java:731)
at com.android.ddmlib.MonitorThread.processClientActivity(MonitorThread.java:311)
at com.android.ddmlib.MonitorThread.run(MonitorThread.java:263)
[2016-02-24 13:58:18 - ddms] Can't bind to local 8624 for debugger

I found ERROR in log cat!!! :)
02-24 08:05:34.248: E/PushPlugin(3453): execute: Got JSON Exception MISSING_INSTANCEID_SERVICE

@ilvalerione you can't do this on a Genymotion emulator as it does not include Google Play Services. You'll have to use a real device or setup a Android emulator using Google API's.

Closing inactivity and using an emulator.


Fix printf for OSX

-printf does not exists for BSD find command so I was getting the following error when the folder .git-semver/plugins exists:
git semver next
find: -printf: unknown primary or operator

This PR fix this for OSX using -print and xargsremoving the remaining space.

I read the CONTRIBUTING.md now and realize that you don't want PRs from master.
I am closing this and opening a new one with feature branch.


Verbose option

I would get it if you think this completely overcomplicates stuff, But I would like to have a verbose function that prints out the current available storage space (one line for each mounted drive), followed by a log of each file that gets deleted (could be limited to only the top-level files and folders) and concluded with a line with the current storage space now that the trash has been emptied (again, one separate line for each mounted drive).

Way over complicating it yes. You can do that yourself with some commands before empty-trash and create a shell alias.


Add a recommendation to recommended list

The system manager can add a recommendation to the recommended list that show in the APP.

Don't need to do it , after a conversion with the Nadav.

Implement by android notifications.


SAML issue in Nautobot 2.2.4 (lxml & xmlsec libxml2 library version mismatch)

Environment

Nautobot version (Docker tag too if applicable): 2.2.4
Python version: 3.9
Database platform, version: MySQL
Middleware(s):

Steps to Reproduce

Dockerfile snippet

FROM networktocode/nautobot:2.2.4-py3.9
USER 0
RUN apt-get install -y patch gcc libxmlsec1-dev libxmlsec1-openssl pkg-config
USER nautobot
RUN pip install --no-binary=lxml "nautobot[sso]==2.2.4"

enable SAML in nautobot config
open home page

Expected Behavior
nautobot home page loads

Observed Behavior
lxml & xmlsec libxml2 library version mismatch

Thanks for the report! Appears to be due to a recent update to xmlsec package publishing. Should be resolved by #5707.


Podman run fails to run when using named volume

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
Podman runtime error when attempting to run container with named volume. Does not seem to matter if podman run is creating the volume or podman volume create. Does not matter whether container is a custom build or remote image.
Steps to reproduce the issue:

Run any image, specifying a named volume, e.g. podman run -it --rm -v test:/test hello-world

Get error output

Be sad.

Describe the results you received:
root@rocinante:~ # podman run -it --rm -v test:/test hello-world
Trying to pull docker.io/library/hello-world...
Getting image source signatures
Copying blob 1b930d010525 done
Copying config fce289e99e done
Writing manifest to image destination
Storing signatures
Error: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"rootfs_linux.go:58: mounting \\\"/var/lib/containers/storage/btrfs-containers/a261adb857d24bc7326cec1fa0d67c74465e86b1b0ecb1d59a6d2a0e2c74f9f4/userdata/volumes/test/_data\\\" to rootfs \\\"/var/lib/containers/storage/btrfs/subvolumes/36a8a9d4e1c523dba11a9a89f599d06b8689ac1ab0508f48edd8e0f205251b3a\\\" at \\\"/test\\\" caused \\\"stat /var/lib/containers/storage/btrfs-containers/a261adb857d24bc7326cec1fa0d67c74465e86b1b0ecb1d59a6d2a0e2c74f9f4/userdata/volumes/test/_data: no such file or directory\\\"\"": OCI runtime error

Describe the results you expected:
Container to mount with persistent named volume attached at specified mount point, world domination ensues shortly thereafter...
Additional information you deem important (e.g. issue happens only occasionally):
Consistent behavior every time on this machine.
Output of podman version:
podman version 1.5.0

Output of podman info --debug:
root@rocinante:~ # podman info --debug
debug:
  compiler: gc
  git commit: ""
  go version: go1.12.9
  podman version: 1.5.0
host:
  BuildahVersion: 1.10.1
  Conmon:
    package: conmon-2.0.0-2.1.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.0, commit: unknown'
  Distribution:
    distribution: '"opensuse-tumbleweed"'
    version: "20190829"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    package: runc-1.0.0~rc8-1.4.x86_64
    path: /usr/sbin/runc
    version: |-
      runc version 1.0.0-rc8
      spec: 1.0.1-dev
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: file
  hostname: rocinante
  kernel: 5.2.10-1-default
  os: linux
  rootless: false
  uptime: 1h 10m 11.21s (Approximately 0.04 days)
registries:
  blocked: null
  insecure: null
  search:
  - docker.io
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 1
  GraphDriverName: btrfs
  GraphOptions: null
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Build Version: 'Btrfs v5.2.1 '
    Library Version: "102"
  ImageStore:
    number: 21
  RunRoot: /var/run/containers/storage
  VolumePath: volumes

Package info (e.g. output of rpm -q podman or apt list podman):
root@rocinante:~ # rpm -q podman
podman-1.5.0-1.1.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
Lenovo Thinkpad Flex 15, bare metal install
Thanks in advance!

Can you add --log-level=debug to your Podman command and give the output of that?

Thanks for the quick response.
root@rocinante:~ # podman volume ls
root@rocinante:~ # podman run --log-level=debug -it --rm -v test:/test hello-world
DEBU[0000] using conmon from $PATH: "/usr/bin/conmon"
DEBU[0000] Initializing boltdb state at libpod/bolt_state.db
DEBU[0000] Using graph driver
DEBU[0000] Using graph root
DEBU[0000] Using run root
DEBU[0000] Using static dir libpod
DEBU[0000] Using tmp dir /var/run/libpod
DEBU[0000] Using volume path volumes
DEBU[0000] Set libpod namespace to ""
INFO[0000] [graphdriver] using prior storage driver: btrfs
DEBU[0000] Initializing event backend file
DEBU[0000] using runtime "runc" from $PATH: "/usr/sbin/runc"
INFO[0000] Found CNI network podman (type=bridge) at /etc/cni/net.d/87-podman-bridge.conflist
DEBU[0000] parsed reference into "[btrfs@/var/lib/containers/storage+/var/run/containers/storage]docker.io/library/hello-world:latest"
DEBU[0000] parsed reference into "[btrfs@/var/lib/containers/storage+/var/run/containers/storage]@fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] exporting opaque data as blob "sha256:fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] parsed reference into "[btrfs@/var/lib/containers/storage+/var/run/containers/storage]@fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] exporting opaque data as blob "sha256:fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] parsed reference into "[btrfs@/var/lib/containers/storage+/var/run/containers/storage]@fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] User mount test:/test options []
DEBU[0000] Got mounts: []
DEBU[0000] Got volumes: [0xc0005307c0]
DEBU[0000] No hostname set; container's hostname will default to runtime default
DEBU[0000] Using bridge netmode
DEBU[0000] created OCI spec and options for new container
DEBU[0000] Allocated lock 1 for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
DEBU[0000] parsed reference into "[btrfs@/var/lib/containers/storage+/var/run/containers/storage]@fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] exporting opaque data as blob "sha256:fce289e99eb9bca977dae136fbe2a82b6b7d4c372474c9235adc1741675f587e"
DEBU[0000] created container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503"
DEBU[0000] container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503" has work directory "/var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata"
DEBU[0000] container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503" has run directory "/var/run/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata"
DEBU[0000] Creating new volume test for container
DEBU[0000] mounted container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503" at "/var/lib/containers/storage/btrfs/subvolumes/ad468095d973e655aa182e9daa45fd252102cae935c614a9547996aa7bca1b22"
DEBU[0000] New container created "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503"
DEBU[0000] container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503" has CgroupParent "machine.slice/libpod-ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503.scope"
DEBU[0000] Handling terminal attach
DEBU[0000] Made network namespace at /var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688 for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
INFO[0000] Got pod network &{Name:angry_mestorf Namespace:angry_mestorf ID:ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 NetNS:/var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688 Networks:[] RuntimeConfig:map[podman:{IP: PortMappings:[] Bandwidth:<nil> IpRanges:[]}]}
INFO[0000] About to add CNI network cni-loopback (type=loopback)
DEBU[0000] mounted container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503" at "/var/lib/containers/storage/btrfs/subvolumes/ad468095d973e655aa182e9daa45fd252102cae935c614a9547996aa7bca1b22"
DEBU[0000] Created root filesystem for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 at /var/lib/containers/storage/btrfs/subvolumes/ad468095d973e655aa182e9daa45fd252102cae935c614a9547996aa7bca1b22
INFO[0000] Got pod network &{Name:angry_mestorf Namespace:angry_mestorf ID:ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 NetNS:/var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688 Networks:[] RuntimeConfig:map[podman:{IP: PortMappings:[] Bandwidth:<nil> IpRanges:[]}]}
INFO[0000] About to add CNI network podman (type=bridge)
DEBU[0000] [0] CNI result: Interfaces:[{Name:cni0 Mac:f2:2c:17:1a:0f:8e Sandbox:} {Name:vethce2350d5 Mac:62:93:ed:c7:75:ca Sandbox:} {Name:eth0 Mac:26:cc:f7:b4:26:1d Sandbox:/var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688}], IP:[{Version:4 Interface:0xc000526ca0 Address:{IP:<IP_ADDRESS> Mask:ffff0000} Gateway:<IP_ADDRESS>}], Routes:[{Dst:{IP:<IP_ADDRESS> Mask:00000000} GW:<nil>}], DNS:{Nameservers:[] Domain: Search:[] Options:[]}
INFO[0000] AppAmor profile "libpod-default-1.5.0" is already loaded
DEBU[0000] skipping unrecognized mount in /etc/containers/mounts.conf: "# This configuration file specifies the default mounts for each container of the"
DEBU[0000] skipping unrecognized mount in /etc/containers/mounts.conf: "# tools adhering to this file (e.g., CRI-O, Podman, Buildah).  The format of the"
DEBU[0000] skipping unrecognized mount in /etc/containers/mounts.conf: "# config is /SRC:/DST, one mount per line."
DEBU[0000] /etc/system-fips does not exist on host, not mounting FIPS mode secret
DEBU[0000] Setting CGroups for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 to machine.slice:libpod:ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
DEBU[0000] reading hooks from /usr/share/containers/oci/hooks.d
DEBU[0000] reading hooks from /etc/containers/oci/hooks.d
DEBU[0000] Created OCI spec for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 at /var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/config.json
DEBU[0000] /usr/bin/conmon messages will be logged to syslog
DEBU[0000] running conmon: /usr/bin/conmon               args="[--api-version 1 -s -c ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 -u ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 -r /usr/sbin/runc -b /var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata -p /var/run/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/pidfile -l k8s-file:/var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/ctr.log --exit-dir /var/run/libpod/exits --socket-dir-path /var/run/libpod/socket --log-level debug --syslog -t --conmon-pidfile /var/run/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/conmon.pid --exit-command /usr/bin/podman --exit-command-arg --root --exit-command-arg  --exit-command-arg --runroot --exit-command-arg  --exit-command-arg --log-level --exit-command-arg debug --exit-command-arg --cgroup-manager --exit-command-arg systemd --exit-command-arg --tmpdir --exit-command-arg /var/run/libpod --exit-command-arg --runtime --exit-command-arg runc --exit-command-arg --events-backend --exit-command-arg file --exit-command-arg container --exit-command-arg cleanup --exit-command-arg --rm --exit-command-arg ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503]"
INFO[0000] Running conmon under slice machine.slice and unitName libpod-conmon-ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503.scope
DEBU[0000] Received: -1
DEBU[0000] Cleaning up container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
DEBU[0000] Tearing down network namespace at /var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688 for container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
INFO[0000] Got pod network &{Name:angry_mestorf Namespace:angry_mestorf ID:ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 NetNS:/var/run/netns/cni-0fd94389-6dc5-1f5a-8a80-c9730712d688 Networks:[] RuntimeConfig:map[podman:{IP: PortMappings:[] Bandwidth:<nil> IpRanges:[]}]}
INFO[0000] About to del CNI network podman (type=bridge)
DEBU[0000] unmounted container "ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503"
DEBU[0000] Cleaning up container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503
DEBU[0000] Network is already cleaned up, skipping...
DEBU[0000] Container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 storage is already unmounted, skipping...
DEBU[0000] Container ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503 storage is already unmounted, skipping...
ERRO[0000] container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"rootfs_linux.go:58: mounting \\\"/var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/volumes/test/_data\\\" to rootfs \\\"/var/lib/containers/storage/btrfs/subvolumes/ad468095d973e655aa182e9daa45fd252102cae935c614a9547996aa7bca1b22\\\" at \\\"/test\\\" caused \\\"stat /var/lib/containers/storage/btrfs-containers/ff45ebc2cf8d1e8012710781e702dcc630fd3950fe03c745d60a058d259d8503/userdata/volumes/test/_data: no such file or directory\\\"\"": OCI runtime error

This might also be helpful:
root@rocinante:~ # podman volume inspect test
[
    {
        "name": "test",
        "labels": {},
        "mountPoint": "volumes/test/_data",
        "driver": "local",
        "options": {},
        "scope": "local"
    }
]

This also, sorry...
root@rocinante:~ # ls /var/lib/containers/storage/btrfs-containers/
3867960a6be22dd632ef4c2479f75d1724b49e5a516ee454554a18da9b80a589  containers.json  containers.lock

root@rocinante:~ # cat /var/lib/containers/storage/btrfs-containers/containers.json
[{"id":"3867960a6be22dd632ef4c2479f75d1724b49e5a516ee454554a18da9b80a589","names":["brave-browser"],"image":"19f4cbb5838c41f3cd3e8ba7582cd06bd9b71d4117d18716b018f40bbba7210c","layer":"bb25fbb02de0d1e47f29221e2e0cd5ecaca024d37d1a47ceb32b6eff07829b40","metadata":"{\"image-name\":\"localhost/brave-base-image:latest\",\"image-id\":\"19f4cbb5838c41f3cd3e8ba7582cd06bd9b71d4117d18716b018f40bbba7210c\",\"name\":\"brave-browser\",\"created-at\":1567708982}","created":"2019-09-05T18:43:02.744263842Z","flags":{"MountLabel":"","ProcessLabel":""}}]

root@rocinante:~ # cat /var/lib/containers/storage/btrfs-containers/containers.lock
64a15e2470ee1adeb5be447fec79215f8575b9e10949ed9a8c654dbd000533ad

DEBU[0000] Creating new volume test for container
Alright, we are definitely calling the create volume code.  The container is being created and mounted successfully, but runc is failing claiming the directory for the volume in question doesn't exist...
Wait, why are we looking in the specific container's userdata for the volume? The root for those should be /var/lib/containers/storage/volumes not within the container directories.

  VolumePath: volumes
That from your podman info seems very suspect. Do you have a /etc/containers/libpod.conf or /usr/share/libpod.conf? Can you pastebin them if so?

DEBU[0000] Using volume path volumes
We are definitely using a bad volume path here. Two issues here:

How did we get the bad path? It's generated by a filepath.Join() on GraphRoot, which must be empty - but clearly is not by the time we actually start containers, because those paths all make sense.
We didn't detect and handle the obviously-incorrect volume path when we initially created it. This one is easy to fix.

Eeek. Our static dir is also being set to a relative path. I'm honestly amazed things aren't exploding much earlier.

/etc/containers/libpod.conf. No /usr/share/libpod.conf on my system. Thanks again, and let me know what else you need.

My suspicion here is that we have a storage.conf explicitly setting empty-string paths for RunRoot and GraphRoot. The c/storage library is probably using compiled-in defaults at that point, I imagine? Meanwhile, our paths intended to be relative to c/storage are instead ending up in wildly inconsistent places because we don't know where c/storage lives.
@rhatdan @giuseppe How do you think we should handle this case? storage.DefaultStoreOptions() is giving us a bunch of unusable, empty-string paths, so I don't think we can ask c/storage where it put things. Should we have separate defaults that we use when we can't grab paths from storage?

We should hard code the defaults if these are set to "".

Ack. Easy enough.

Issue also applies to 1.5.1 FYI.

Fix pending in #3954 - however, it will only apply to new installs. It changes the locations of several core paths by default and could break existing installations.
You'd have to delete /var/lib/containers/storage/ to pick up the fix, but this will lose all your existing containers.

You were right about storage.conf, here's the pastebin. I forgot about that until you mentioned it @mheon, that was done while troubleshooting a different issue for Buildah.

Appears that the volume path was indeed the issue. Re-installed from distro packages with all configuration files removed, and after re-creating policy.json with defaults and registries.conf from defaults this is working.
I'm closing this issue as it appears to be resolved to me. If you're troubleshooting and find this issue, ensure that the storage.DefaultStoreOptions() in storage.conf is correct.

Great and useful summation @SwitchedToGitlab, thanks for adding it.


Infinite loop in sortAndFilterTrips

Observed behavior (please include a screenshot if possible)
The sortAndFilterTrips in lib/editor/util/index.js will run in an infinite loop if one of the trips have an empty array of stop times.
Expected behavior
Infinite loop should be avoided.
Steps to reproduce the problem
While editing this GTFS file (gtfs_GL.zip) in the datatools-ui editor, I changed the service_id on the calendar entry. Then, I checked some stop times in the timetable and noticed that they are completely missing for the even numbered trips. In certain cases the only trips available for a certain service id were those that didn't have any stop_times. In those cases, the UI froze because an infinite loop was encountered while trying to sort the trips.
Any special notes on configuration used
Editor module must be enabled.
Version of datatools-ui and datatools-server if applicable (exact commit hash or branch name)
gtfs-lib: https://github.com/conveyal/gtfs-lib/commit/5ec52854ac2c39dd94f8ac9d0f0fc051cf53d312
datatools-server: https://github.com/conveyal/datatools-server/commit/5943dfbe9e3acee0393c1e745a82f923a2483d2e
datatools-ui: https://github.com/conveyal/datatools-ui/commit/0f10fa25468e43b489942d4eb777706449dd6653

:tada: This issue has been resolved in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Black Screen Streaming State of Decay 2

I am trying to add State of Decay 2 to Steam. I opened UWPHook and it sees SoD2 however when I try to stream I see nothing but a black screen while streaming. The host launches the game, however, the computer connecting hears sound but has no video.

Did you enable the Streaming mode under the settings? Also note that the xbox controller probably won't work very well with streaming, it's a known issue.


Messaging: Scale up based on pending messages

Update, it just went slowly from 0 to 1 to 4 eventually.
Current behavior:

kubeai configured to read from pubsub with max handlers at 2500, model targetRequests set to 500
5M messages get send
KubeAI receives 2500 messages
KubeAI scales from 0 to 1

Expected heavior:

kubeai scales from 0 to 5 when it knows there are 2500 pending requests

Some other thoughts, maybe we should look at total unacked messages in queue and go to max scale based on that.
This issue is more problematic than I thought because it took about 2 hours to scale from 0 to 8 pods. It does it 1 by 1 and each pod scaling up is slow.

Done


Release jobs are failing

I'm not 100% sure, but I found some suspicious logs:
Processing chore(main): release Google.Api.Gax 4.3.0-beta01: [https://github.com/googleapis/gax-dotnet/pull/664](https://www.google.com/url?q=https://github.com/googleapis/gax-dotnet/pull/664&sa=D)
> Creating the release.
ValueError('No releases found within pull request')

FYI @jskeet who can give better details, maybe wait until he confirms before closing, just in case.
But I think this is fine. We had a typo in one of our releases and then had to trigger some things by hand, that may have confused release-please.
The package has been released properly: https://www.nuget.org/packages/Google.Api.Gax/4.3.0-beta01

Yes, it's fine to close this.

For some reason the PR still had "pending" as well as "published" labels. I've removed "pending". Everything after line 3 looks like it's about Ruby though.

Fixed in #472


Initial check in

[] Don't need to highlight it's a Action plugin
[] Also, it should tell how the state can be retrieved.

Updated comments.

Addressed comments.


Optimized dist assets.

This patch introduces checks for the NODE_ENV value exported to the browser by the static asset build process, so the minifier checks and removes unused code, which allows to save bytes by dropping the propTypes definitions which are themselves mostly useful in development.
Before:
➜  react-jsonschema-form git:(master) ✗ ll dist
total 368
drwxrwxr-x 2 niko niko   4096 Dec 22 16:50 .
drwxrwxr-x 9 niko niko   4096 Dec 22 16:50 ..
-rw-rw-r-- 1 niko niko  48988 Dec 22 16:50 react-jsonschema-form-0.3.0.js
-rw-rw-r-- 1 niko niko 316397 Dec 22 16:50 react-jsonschema-form-0.3.0.js.map

After:
➜  react-jsonschema-form git:(optimize-dist) ll dist
total 364
drwxrwxr-x 2 niko niko   4096 Dec 22 16:44 .
drwxrwxr-x 9 niko niko   4096 Dec 22 16:44 ..
-rw-rw-r-- 1 niko niko  46765 Dec 22 16:44 react-jsonschema-form-0.3.0.js
-rw-rw-r-- 1 niko niko 315095 Dec 22 16:44 react-jsonschema-form-0.3.0.js.map

Sure, the saving isn't really important here, but this is a really cool trick and might be useful whenever we need to strip development stuff out of production builds in the future.

r=? @Natim

LGTM


Free Quest runs can't continue

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
JP
FGA build number
1675
Describe the bug
With the Avalon and free quest 50% ap down I decided to go for all the free quest pending. What I did was set the fga to run 3 times and stop at first clear reward quartz. Did ALL of Heian Kyo free quest without problem until I started Avalon. In the video the fight ends but does not count as a run and just stays idle.
Yesterday it would count 1 out of 3 select the same free quest, the support and run again until all 3 runs were done and the quartz is awarded.
Video
https://youtu.be/pNdcvJXSrGs
Device model
Xiaomi redmi note 10s
Android version
12
Screen size
1080x2400
RAM
6GB

Your play button is blocking the MENU detection, move ot to the bottom left.

Ok, did as told and is working perfectly, what I don't get is why it was working the day before. Thanks


Add plugin for customizing diffuse light color.

This is useful for rendering techniques where light color may change dynamically based on the position of the fragment being shaded (e.g. applying sun light to a large terrain)

After a successful CI build, I will share a playground that ensures this functionality works as expected.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15511/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15511/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15511/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15511/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15511/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15511/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15511/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15511/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15511/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15511/merge/testResults/webgpuplaywright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15511/merge/testResults/webgpuplaywright/index.html


[W5.11][W11-A3]Oh Han Yi

Sort

Does showing the feature in class count as W3.10? I did that but I didn't do a pull request because that was the first week. I did a sort feature in 1k enhancement as well but didn't do test cases because I didn't know it was required.
Shall I just do a PR on W3.10?

@slothhy Unfortunately it does not suffice to just show the enhancement in class :/ The judging criteria are standardised, and to be considered as completed, an enhancement must be created, along with updated tests and documentation for W3.10.
So I would recommend you to just add another enhancement for 2 kLoC instead (making sure to update everything necessary!). And don't worry about the 1 kLoC target (a lot of people did not hit it, and doing 2 enhancements in 2 kLoC can cover for that)!


rules

What is your username and discriminator?
=Lewd King= Curly Bryce#6326
Why did you join Discord Linux?
For support and because I use Linux
Where did you hear about Discord Linux?
From a discord issue ticket
What is the passphrase that was assigned to you by the bot?
I have looked through this link multiple times and cannot find the passphrase
https://blargbot.xyz/output/511240873850191307

From simonizor#0420 :
That is not your passphrase. Please read the contents of that link to find your passphrase.