segfault in Envoy::Http::CodecClient::close()

Description:
We saw a segfault inside of Envoy::Http::CodecClient::close(). It seems like a timed out active health check can cause a connection close after it's already been closed.
The Envoy version is a fork, but we think it's unlikely our changes are related based on the backtrace.
Envoy version: https://github.com/snowp/envoy/tree/xdc-hack. It diverged from master at 3e15c94901f7ce5ebca671e451efceec8053da86
Raw log output:
2018-09-05_19:19:39.04147 [2018-09-05 19:19:39.041][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:125] Caught Segmentation fault, suspect faulting address 0x28
2018-09-05_19:19:39.11074 [2018-09-05 19:19:39.110][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:94] Backtrace thr<0> obj<./envoy> (If unsymbolized, use tools/stack_decode.py):
2018-09-05_19:19:39.14064 [2018-09-05 19:19:39.140][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #0 0x73f72e std::unique_ptr<>::get()
2018-09-05_19:19:39.15795 [2018-09-05 19:19:39.157][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #1 0x73e7f1 std::unique_ptr<>::operator->()
2018-09-05_19:19:39.17624 [2018-09-05 19:19:39.176][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #2 0xc52063 Envoy::Http::CodecClient::close()
2018-09-05_19:19:39.19251 [2018-09-05 19:19:39.192][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #3 0xc38fae Envoy::Upstream::HttpHealthCheckerImpl::HttpActiveHealthCheckSession::onTimeout()
2018-09-05_19:19:39.20858 [2018-09-05 19:19:39.208][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #4 0xc4cad6 Envoy::Upstream::HealthCheckerImplBase::ActiveHealthCheckSession::onTimeoutBase()
2018-09-05_19:19:39.22819 [2018-09-05 19:19:39.228][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #5 0xc4c1e6 Envoy::Upstream::HealthCheckerImplBase::ActiveHealthCheckSession::ActiveHealthCheckSession()::{lambda()#2}::operator()()
2018-09-05_19:19:39.24641 [2018-09-05 19:19:39.246][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #6 0xc4d67b std::_Function_handler<>::_M_invoke()
2018-09-05_19:19:39.26545 [2018-09-05 19:19:39.265][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #7 0x4f80ef std::function<>::operator()()
2018-09-05_19:19:39.28170 [2018-09-05 19:19:39.281][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #8 0x9a15fe Envoy::Event::TimerImpl::TimerImpl()::{lambda()#1}::operator()()
2018-09-05_19:19:39.29760 [2018-09-05 19:19:39.297][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #9 0x9a162d Envoy::Event::TimerImpl::TimerImpl()::{lambda()#1}::_FUN()
2018-09-05_19:19:39.31372 [2018-09-05 19:19:39.313][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #10 0xfb78f7 event_process_active_single_queue.isra.29
2018-09-05_19:19:39.33038 [2018-09-05 19:19:39.330][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #11 0xfb7e5e event_base_loop
2018-09-05_19:19:39.35262 [2018-09-05 19:19:39.352][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #12 0x999351 Envoy::Event::DispatcherImpl::run()
2018-09-05_19:19:39.36875 [2018-09-05 19:19:39.368][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #13 0x911bd0 Envoy::Server::InstanceImpl::run()
2018-09-05_19:19:39.38646 [2018-09-05 19:19:39.386][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #14 0x439d77 Envoy::MainCommonBase::run()
2018-09-05_19:19:39.40384 [2018-09-05 19:19:39.403][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #15 0x4206dd Envoy::MainCommon::run()
2018-09-05_19:19:39.41968 [2018-09-05 19:19:39.419][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #16 0x41a739 main
2018-09-05_19:19:39.41971 [2018-09-05 19:19:39.419][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] thr<0> obj</lib64/libc.so.6>
2018-09-05_19:19:39.42019 [2018-09-05 19:19:39.420][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:114] thr<0> #17 0x7f6cc5250444 __libc_start_main
2018-09-05_19:19:39.42021 [2018-09-05 19:19:39.420][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:104] thr<0> obj<./envoy>
2018-09-05_19:19:39.43588 [2018-09-05 19:19:39.435][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:117] thr<0> #18 0x419ed4 (unknown)
2018-09-05_19:19:39.43591 [2018-09-05 19:19:39.435][510279][critical][backtrace] bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:121] end backtrace thread 0

decoded with stack_decode.py:
2018-09-05_19:19:39.11074 [2018-09-05 19:19:39.110][510279][critical] Backtrace (most recent call first) from thread 0:
  #1 std::unique_ptr<Envoy::Network::ClientConnection, std::default_delete<Envoy::Network::ClientConnection> >::get() const at unique_ptr.h:305
  #2 std::unique_ptr<Envoy::Network::ClientConnection, std::default_delete<Envoy::Network::ClientConnection> >::operator->() const at unique_ptr.h:299
  #3 Envoy::Http::CodecClient::close() at codec_client.cc:40
  #4 Envoy::Upstream::HttpHealthCheckerImpl::HttpActiveHealthCheckSession::onTimeout() at health_checker_impl.cc:222
  #5 Envoy::Upstream::HealthCheckerImplBase::ActiveHealthCheckSession::onTimeoutBase() at health_checker_base_impl.cc:274
  #6 Envoy::Upstream::HealthCheckerImplBase::ActiveHealthCheckSession::ActiveHealthCheckSession(Envoy::Upstream::HealthCheckerImplBase&, std::shared_ptr<Envoy::Upstream::Host>)::{lambda()#2}::operator()() const at health_checker_base_impl.cc:186
  #7 std::_Function_handler<void (), Envoy::Upstream::HealthCheckerImplBase::ActiveHealthCheckSession::ActiveHealthCheckSession(Envoy::Upstream::HealthCheckerImplBase&, std::shared_ptr<Envoy::Upstream::Host>)::{lambda()#2}>::_M_invoke(std::_Any_data const&) at functional:1871
  #8 std::function<void ()>::operator()() const at functional:2267
  #9 Envoy::Event::TimerImpl::TimerImpl(Envoy::Event::DispatcherImpl&, std::function<void ()>)::{lambda(int, short, void*)#1}::operator()(int, short, void*) const at timer_impl.cc:15
  #10 Envoy::Event::TimerImpl::TimerImpl(Envoy::Event::DispatcherImpl&, std::function<void ()>)::{lambda(int, short, void*)#1}::_FUN(int, short, void*) at timer_impl.cc:15
  #11 event_process_active_single_queue at event.c:1646
  #12 event_process_active at event.c:1738
  #13  (inlined by) event_base_loop at event.c:1961
  #14 Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) at dispatcher_impl.cc:161 (discriminator 4)
  #15 Envoy::Server::InstanceImpl::run() at server.cc:428
  #16 Envoy::MainCommonBase::run() at main_common.cc:83
  #17 Envoy::MainCommon::run() at main_common.h:64
  #18 main at main.cc:37 (discriminator 1)
  #19
  #20 ?? ??:0
  #21
  #22 _start at ??:?
  #23

cc @snowp

Possible this is happening due to a timeout triggering following a Network::ConnectionEvent::RemoteClose || Network::ConnectionEvent::LocalClose, which seems to close the connection?
Perhaps onTimeout should defensively check for nullptr before closing the connection?


happy eyeballs: add debug-level log events each attempt

Commit Message: happy eyeballs: add debug-level log events each attempt
Risk Level: Low
Testing: Local & CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

Note that with respect to volume, this is O(connections) which is a frequency the project already uses for other connection-related debug-level logging.

please fix format & then I'll assign a first-pass reviewer. Thanks :)
/wait

@goaway Looks like clang tidy is not happy

I think this latest test failure may be spurious.

/retest

Thanks for the comments @junr03 and @RyanTheOptimist!


resume

GHCi> resume

does not resume, but also needed ^D.

Just to double check, are you doing resume or :resume?

Oh. Yes. Oops.


ignore cloudflare js redirects

thepiratebay is currently not working.
There is a problem with https://pirateproxy.one. It uses cloudflare browser check before redirecting.
The parser does not support this behavior at the moment. I added a ignore-rule to To ignore this kind of proxies.
Another solution would be to remove https://pirateproxy.one.

Looks good! Thank you!


Input propagation.

I'm currently working on a quite ambitious game, that involves implementing lots of, let's say, non trivial GUI, so I ran across this "problem", that there is no way to propagate input events in Phaser, and I don't see any easy workarounds for that. The priority thing doesn't help, as far as I understand, cause I need several overlapping elements to respond to the same input event, not just one of them, that has the higher priority. So I was thinking, is it worth trying to implement something like multiple target objects for the Pointer class, or would it be easier to just make a custom build with PIXI's interaction manager resurrected?

Sounds like you should use the DOM
On Apr 27, 2016 11:43 AM, "namark"<EMAIL_ADDRESS>wrote:

I'm currently working on a quite ambitious game, that involves
implementing lots of, let's say, non trivial GUI, so I ran across this
"problem", that there is no way to propagate input events in Phaser, and I
don't see any easy workarounds for that. The priority thing doesn't help,
as far as I understand, cause I need several overlapping elements to
respond to the same input event, not just one of them, that has the higher
priority. So I was thinking, is it worth trying to implement something like
multiple target objects for the Pointer class, or would it be easier to
just make a custom build with PIXI's interaction manager resurrected?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/issues/2456

Noooo... not DOOOM... I much rather just do the hit tests manually :D
... And it seems that's what I'm actually going to do, for some custom objects, as a temporary solution, but it doesn't feel good at all.

Have you looked at http://phaser.io/examples/v2/input/input-priority?

Yep, I'm currently implementing a scrollable container with some clickable elements inside, and that doesn't really help :/

You should try to post the code on the html 5 forums with a jsfiddle or something. We can try to help you there more maybe? Not sure

Maybe, I'll do that when I'm completely stuck. Thanks.
But my question here actually was more general, anticipating some future complications, that might arise with various workarounds. I'll rephrase, just in case:
Does it make sense to add some logic for multiple target objects in Phaser.Pointer? Cause I'm looking at it, and really want to do that, but would like some green light and advice from someone who understands it better.
Also is it possible to somehow enable PIXI's interaction manager in Phaser? Cause, even though more primitive, it also seems more capable to me... no offense :D ... just seems, alright?

Are you saying the input propagation is too laggy, not responsive enough?

Nooo... Maybe "propagate" is not the right word? As far as I understand the input does not propagate. A single object just receives it, and no one else in notified. Ideally there should be propagation through it to other object under it, and also propagation up the display object hierarchy, I think.

This is a very non-trivial feature request. The Pixi input manager isn't included in our build, and even if it was it wouldn't work anyway.
If you want to try implementing this for yourself then I would start in the Pointer class, in the processInteractiveObjects method. When it does the double-sweep you could add valid objects into a collective array, then at the end dispatch whatever events you want them to dispatch.
I'm closing this because it's not something I'll implement in Phaser, but feel free to reply if you want to ask questions about adding it to your own build.

Yep, I wanted to implement this myself, so asking to make sure that I'm thinking in the right direction,
and I was actually looking exactly at the method you mentioned, so I'll try and see how it goes :)
Thanks.

I am sorry @namark I believe you used the correct word. I just am getting confused and what exactly you are wanting to do that's all

ummm... A question. Why does the Phaser.Group update its children in reverse order?
https://github.com/photonstorm/phaser/blob/master/src/core/Group.js#L1389
All the other display objects do otherwise. Makes renderOrderIds inconsistent.

https://pixijs.github.io/docs/core_display_Container.js.html#line110
PIXI's Container.addChild, adds new objects at the end of the list.
this.addChildAt(child, this.children.length);

@Nuuf Ummm... Yes... That is certainly correct... But I can't see how is that relevant... ???

Nvm, I had a brain malfunction.

sure, not a problem... I'll borrow that excuse though :D

Traditionally because it's extremely common for Group children to delete themselves during their update cycle, which screws with the Group array length if you're iterating through it at the time. However we moved to using a destroy phase a while back, which may mitigate this requirement. Will have a look into it.

Just had a further look at this - preUpdate is where the renderOrderID is set, and that loops through in bottom-to-top order in Stage, but Group was doing it in reverse (hence the order ID issue), so have swapped that around. update and postUpdate will loop in reverse though, for the reason stated above, but that won't impact the order IDs.

Great. I did the same thing, so good to know there are not going to be any dire consequences.


[Important] Add max_prompt_tokens and max_completion_tokens for Runs API

Confirm this is a feature request for the Node library and not the underlying OpenAI API.

[X] This is a feature request for the Node library

Describe the feature or improvement you're requesting
Hi, I belive that max_prompt_tokens and max_completion_tokens are essential features for using the whole Assistants API. Without being able to specify the max tokens, the thread is just getting longer, and running the AI model getting very expensive. Please add the max_prompt_tokens and max_completion_tokens parameters to the openai.beta.threads.runs.create. Thanks!
Additional context
No response

I believe @pstern-sl is working on this.

This is available starting in version 4.34 - released today https://github.com/openai/openai-node/pull/767

Awesome! Thanks a lot for implementing this! :)


Test coverage for the Overlay component does not show code coverage in the lcov report.

Also the overlay file shows up in the code coverage report twice, one upper case Overlay and the other lower case. The upper case Overlay component shows test coverage of 93.75% but when you click on it, it shows zero percent for the test coverage.

Fixed in my testing branch, will merge when variant violation bug is fixed. The problem was that the overlay component test was importing overlay with a capital O, switching to a lower case o solves the problem.


code block font should use editor.fontFamily by default

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: win10 x64
- Continue: v.0.8.6
- IDE: vscode

Description
currently the code block looks like this (the font is a default font, not what I'm using in vscode):

which applies this css:

so it uses --monaco-monospace-font as the default font.  I think the best default setting should be editor.fontFamily, i.e. --vscode-editor-font-family.
(I tried to search --monaco-monospace-font in this repo but didn't find a match)
To reproduce

use arbitrary model to generate some chat that contains a code block
check the css (and try to modify it as described)

Log output
(NA)

@yuuuxt Looks really nice after doing this, thanks for taking the time to find the variable! It'll be in the next release today

Feels it can also be applied here (inline <code>):

Also, I want the chat font to be var(--vscode-font-family), so that it is consistent with the rest of vscode. What do you think?

https://github.com/continuedev/continue/blob/e1291969278597febdf0cce7ce3c9e70fe9dbe95/gui/src/components/markdown/StyledMarkdownPreview.tsx#L62


Update pl_pl.json

Translations are managed on Crowdin. You can also upload an already translated file there: https://support.crowdin.com/uploading-translations/#uploading-translations-via-language-page


chore(main): release 0.121.6

:robot: I have created a release beep boop
0.121.6 (2024-01-20)
Bug Fixes

crd: combining crd versions again (78cd7f2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hef/dbman/releases/tag/v0.121.6 :sunflower:


sparse glm submodule

Test are passing locally if I use python setup.py develop

did you need a second eye on travis for this?

I think spglm was good to go. Still sorting SpInt but haven't given it a
thorough look over just yet.
On Mon, Mar 27, 2017 at 5:23 PM Levi John Wolf<EMAIL_ADDRESS>wrote:

did you need a second eye on travis for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pysal/spglm/pull/1#issuecomment-289625122, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHvdzYzvpkIrlNn_u8ksuSrEee0s7gQsks5rqFL4gaJpZM4L_6hI
.

yeah, deleted my comment cause I realized it was the wrong project. my b.


Added support for the NXM_NX_TUN_IPV4_{SRC & DST}[_W] fields

Needed to properly write flows that load values into these fields

LGTM. Do you want to submit the patch to upstream for this, or I can later today if you you'd prefer.

I will submit it now

Made pull request to upstream https://github.com/osrg/ryu/pull/30


Replacing the ffmpeg dll to achieve alpha channel support

Hi!
I'm very excited to use the plugin, but I really need alpha channel support in my project. I'm developing on Windows 10.
Here there's mention of "replacing" .dll files and that "The LGPL builds found here" should also be compatible. I don't "build" stuff regularly so a ready made replacement sounds good to me. I picked the 6.1 lgpl shared build because the .dll names in the bin folder (avcodec-60.dll, avfilter-9.dll etc) match the ones in your latest build. However those builds don't contain a libgdffmpeg.windows.template_release.x86_64.dll equivalent but instead an executable ffmpeg.exe.

I'm a trial and error kind of person, so I tried copying the .dll files that are there to the addon folder. If I then run my Godot project, I see a lot more "Supported video codecs" being printed, but  I'm met with this error:
VideoDecoder::recreate_codec_context: Couldn't copy codec parameters from h264: Cannot allocate memory
  <C++ Error>    Condition "param_copy_result < 0" is true.
Thank you very kindly for the work you've done and for looking into my noob issue!

Koen

Sorry, wrong repository to submit this issue to!

Sorry, wrong repository to submit this issue to!


Mappings don't get applied for rust_analyzer

First off thanks for the great plugin! It really simplifies the LSP experience for neovim.
I'm having an issue where my mappings aren't getting set when rust_analyzer attaches to a buffer. They work fine for all the other language servers I have configured.
This is my config for lsp-setup:
require('lsp-setup').setup({
  default_mappings = false,
  mappings = {
    gd = 'Telescope lsp_definitions',
    gD = 'lua vim.lsp.buf.declaration()',
    gT = 'Telescope lsp_type_definitions',
    gr = 'Telescope lsp_references',
    gI = 'Telescope lsp_implementations',
    gR = 'lua vim.lsp.buf.rename()',
    ga = 'lua vim.lsp.buf.code_action()',
    gs = 'Telescope lsp_document_symbols',
    gS = 'Telescope lsp_dynamic_workspace_symbols',
    gx = 'LspRestart',
    go = 'SymbolsOutline',
    K = 'lua vim.lsp.buf.hover()',
  },
  on_attach = function(client)
    if client.name ~= 'null-ls' then
      client.server_capabilities.documentFormattingProvider = false
    end
  end,
  servers = {
    astro = {},
    emmet_ls = {},
    gopls = {
      flags = {
        debounce_text_changes = 300,
      },
    },
    rust_analyzer = {
      settings = {
        ['rust-analyzer'] = {
          cargo = {
            buildScripts = {
              enable = true,
            },
          },
        },
      },
    },
    sumneko_lua = {
      settings = {
        Lua = {
          runtime = {
            version = 'LuaJIT',
          },
          diagnostics = {
            globals = { 'vim', 's', 't', 'i', 'c', 'fmt', 'fmta' },
          },
          workspace = {
            library = vim.api.nvim_get_runtime_file('', true),
          },
        },
      },
    },
    tsserver = {
      flags = {
        debounce_text_changes = 300,
      },
    },
  },
})

LspInfo shows that rust_analyzer has successfully attached to the buffer:
 Language client log: ~/.local/state/nvim/lsp.log
 Detected filetype:   rust

 2 client(s) attached to this buffer:

 Client: rust_analyzer (id: 1, pid: nil, bufnr: [1, 36, 18])
 	filetypes:       rust
 	autostart:       true
 	root directory:  ~/src/gallery
 	cmd:             rust-analyzer

 Client: null-ls (id: 2, pid: 5001, bufnr: [1, 47, 18, 36])
 	filetypes:       python, go, css, astro, rust, lua, luau, tf, terraform
 	autostart:       false
 	root directory:  ~/src/gallery
 	cmd:             <function>

Calling the functions manually works fine too:

I seem to have missed this issue. Is this problem still present now?


Update to 1.2.1

Fix bugs related to generation of targets for announce (resolves #114, #117, #118)

Looks good to me, merge when ready!


[cassandra] Latest version is quiet and reports missing log4j-server.properties

> docker logs -f cass
sed: can't read /opt/cassandra/conf/log4j-server.properties: No such file or directory

and BTW:
> docker run -it --rm --link cass itzg/cassandra cqlsh cass
No appropriate python interpreter found.

Fixed by code changes for #68


Not working with ivy

ng2-tel-input.module.js(22,27): error TS-991010: Value at position 0 in the NgModule.declarations of Ng2TelInputModule is not a reference: [object Map]

Seems to work with latest Angular 9 -> RC.6

Value at position 0 in the NgModule.declarations of Ng2TelInputModule is not a reference: [object Object] . scrap that, issue is still there

@bendg25 Thanks for raising the issue. I am looking into this issue. I am going through couple of issues and articles on GitHub such as:-
https://github.com/angular/angular/issues/32025
https://medium.com/@sarunint/how-can-you-experimentally-try-angular-ivy-right-now-c23930062b4c
It seems like the package is not according to the standards of the angular.

Hi, yes that is as far as I got with it.  It was not immediately obvious what Angular is not happy about.

Hello @gauravsoni119 do you have a workaround for this issue please?
Hello @Dt-Sodium importing the .ts file raised other issues on my end, maybe I was not doing it right. Can you please share your workaround code? Thanks-

I'm not even sure we still use this, another developer finished the telephone number form.
If i remember correctly, i just copied the source .ts file somewhere in my project and imported the class from there.

Hey, any news?

The new version of the package is aligned with Angular package format which makes it compatible with all angular versions.


why does y2mate get the direct link to youtube 720p video?

I tried and found y2mate get the 720p video link from youtube. Do they use youtube-dl to get links?

Ask y2mate.


Fix running on GPU

BERTScore & BLEURT are really slow and require a lot of resources

BERTScore now slightly faster with distilbert (dc8fe10bf019830e66f8b5dd72723a63ff21575b)
Would be good to make it run well on GPU, but now it fails with CUDA out-of-memory (BLEURT occupies all memory and doesn't free it up after finishing, so when BERTScore runs on the 2nd dataset, it can't allocate memory)

BERTScore now slightly faster with distilbert (dc8fe10bf019830e66f8b5dd72723a63ff21575b)
Would be good to make it run well on GPU, but now it fails with CUDA out-of-memory (BLEURT occupies all memory and doesn't free it up after finishing, so when BERTScore runs on the 2nd dataset, it can't allocate memory)

The switch is there (#17) -> changed the name

The switch is there (#17) -> changed the name


Increase default gravity accuracy

This pull request simply changes the default gravity from 980 in 2d/9.8 in 3d to 981/9.81. This is to be more accurate with real gravity, which is 9.80665 m/s^2 which should round to 9.81 m/s^2.
I understand if this is for a reason.
Godot engine is a great and simple engine. Thanks everyone for creating it.

I'm not sure this PR is an improvement. 9.8 is accurate to 2 significant figures, while 9.81 is accurate to 3. Why go some of the way but not all the way to 9.80665 itself?
Also, the actual gravity value on Earth varies from 9.78 to 9.83 depending on the exact location, 9.80665 is just the average. So 9.8 is a simpler number and still well within the range of Earth gravity.

I agree, if we are changing it (which I don't think is necessary) we should probably match it up with the default values in the internal areas:
https://github.com/godotengine/godot/blob/c73ac74c4a44ccfed158b3603f809a24590bac0a/servers/physics_3d/godot_area_3d.h#L49
So insead should be set to 9.80665
But regardless the actual change in accuracy is tiny (going from ~0.00665 to ~0.00335), so I'd call this "increase precision", though that's just a nitpick

The reason this has been rounded to 981 is due to that being the most precise whole number in 2D and 9.81 in 3D for consistency. I see how you can view this as unnecessary, however.

Fixed it to actually do something and not just change docs as you suggested.

I really don't see the point in this tweak.. It'll just ever so slightly affect gravity without actually being discernably different, while also breaking compatibility as you are now falling at an ever so slightly higher rate that may in some very extreme cases break existing level design

Closing this PR due to not really being necessary.


Reuse IdentifierScheme

From @ppanero
IdentifierScheme could be reused in many other schemas. However, there is no easy and clean way to flatten its attributes. Tested Pluck and Method. The latter worked but it has a more difficult code comprehension, which in my perspective makes is not a good choice.

Closing in favour of  #97


Ability to hide tray icon

Description of the new feature / enhancement
I'd like to see the ability to hide the tray icon, as this would allow for a generally cleaner look
Scenario when this would be used?
Cleaning up the tray icons
Supporting information
No response

/dup #9526


Add articles section

Thanks for the PR, and sorry for the delay with review. I need to think how to organise the articles better, as there are already quite a bunch of those in different sections.

Articles section added by #49. Let me close this PR and add your post in a different one.


V5-Develop (pre-beta) swift package archive failure

I may be jumping the gun here as V5 isn't properly out, but 4.11.1 doesn't play any sound on my MidiSampler so I've updated my project to swift package pointing at https://github.com/AudioKit/AudioKit using version rule of branch v5-develop. Building to device and simulator works fine but when archiving the project a generic archive is produced along with a load of errors for unexpected characters:
error reading dependency file '/Users/adamsutcliffe/Library/Developer/Xcode/DerivedData/SpinnerTest-czsfrzkkpvctzcapjnypjtpizbck/Build/Intermediates.noindex/ArchiveIntermediates/SpinnerTest/IntermediateBuildFilesPath/AudioKit.build/Release-iphoneos/AudioKit.build/Objects-normal/arm64/AudioKit-master.d': unexpected character in prerequisites at position 6184335 (in target 'AudioKit' from project 'AudioKit')

I'm new to swift packages so not sure how to solve this issue, it seems like a colon just needs to be removed somewhere but I have no idea where!
Screen shot of archive produced, no version number or ability to validate or upload to app store/test flight available

After digging a little deeper its entries like this in the dependency file that are causing the issue. AudioKit::MAINGROUP::REF_1::REF_90.bc

FYI there's a fix in for AKMIDISampler https://github.com/AudioKit/AudioKit/pull/2281 but this looks to be important for v5 going forward.

@adamjsutcliffe @megastep I've started a Github Project to manage requirements for AK5 release here https://github.com/AudioKit/AudioKit/projects/5.
This issue is on there.

I'm rather new to SPM myself too, but these are files generated by Xcode and I'd be inclined to blame it for it.

Interestingly enough I got like 181 of those type of errors when archiving, but it still archived for me.

Did it still archive it as Generic Xcode Archive? I tried all suggested approaches here without any luck: https://stackoverflow.com/a/57749091

Actually on a second look, the archives that I thought I was creating were basically empty shell xcarchives, so this is definitely not working and has to be fixed before we can think about releasing AK5.

I'm having same issue archiving. is there any workaround ?

I have submitted a Developer Technical Support with Apple.

For completeness, the issues were that some file names were colliding with each other, Operations/Effects/korgLowPassFilter.swift vs. Nodes/Effects/KorgLowPassFilter.swift for example. Why Apple requires unique file names? I have no clue. Once I renamed the operations files this issue went away. what a pain it was.

Resolvemos o problema tirando caracter Especial


[Feature] Enhanced support/structure for Multi-modal models

Checklist

[ ] 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[ ] 2. Please use English, otherwise it will be closed.

Motivation
In vllm,  the framework can accept either image or image-embedding. See  vllm [Feature] Add vision language model support. #3042 and vllm-llava impl.
Embedding an image requires fixed predictable compute and is easy to batch and run   in a separate framework(for instance, tensorrt-based serving framework). See discussion in https://github.com/vllm-project/vllm/issues/307#issuecomment-1840443044
Ideally, it is necessary to maintain the infrastructure to overlap (image (gpu) preprocessing + inference) and (llm inference) within the same process (avoiding the need for nvidia MPS)
Related resources
No response

Sorry, duplicated from https://github.com/sgl-project/sglang/issues/745


enhacement: currency

Der @jackocnr
please add currency feature for each country

Ooh yeah, that sounds cool.

I'm afraid this is outside the scope of this project.


Hello Microverse Pull Request

This is my first simple project with microverse

[ ] Kindly implement a professional readme file. I noticed that you have a very good readme in your main branch. So please make sure that you have it also in your feature branch.

When you create a new repo build a good readme, then create the new branch, so that you have it also in your feature branch. 🤓
In this case, you can just copy the readme you have in your main branch to your feature branch.
Kindly keep in mind that in future projects, if you not provide a professional readme in your PR, it will be marked as "invalid" 😮💨
It is just a detail but it is important to keep good documentation of your work for bigger projects. That's why we require this from the very beginning 😄


Omit on a discriminating union with intersection remove the properties of accessing the union elements

Bug Report

🔎 Search Terms

Omit
Discriminated union

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about 4.75 or anything above 4.0

⏯ Playground Link

Playground link with relevant code
💻 Code

// discriminted union identifier
enum Job {
    Job1 = "job-1",
    Job2 = "job-2"
}

// union first element
type Job1 = {
    type: Job.Job1,
    payload: "hi"
}

// union second element
type Job2 = {
    type: Job.Job2,
    payload2: "hi"
}

// union of two types
type Jobs = Job1 | Job2

// a type common to both union
type JobBase = {
    started: Date,
    ended: Date
}

// intersection
type FinalJob = Jobs & JobBase;

// then omit some fields from intersection type, thus intersection -> omit
type TestJobWithOmit = Omit<FinalJob,"started" | "ended">

// this one omit is done on base class then intersection, thus omit -> intersection
type TestJobWorking = Jobs & Omit<JobBase,"started" | "ended">

// wont show the fields of discriminted union
const testingJobType = (a:TestJobWithOmit) => {
    if(a.type === Job.Job1){
        // a is not showing other object field like payload etc
        console.log(a.type)
    }
}

const testingJobThatWorks = (a:TestJobWorking) => {
    if(a.type === Job.Job1){
        // a is now showing various fields in discriminted union
        console.log(a.payload)
    }
}

🙁 Actual behavior
When omit is applied over a  discriminating union with intersection, the discriminating property is lost. This happens only when the omit gets applied over this combination.

As I shared above TestJobWithOmit when i conditionally pick the union element, it doesn't show the values of the discriminated ones. But as i shown in codebase if i apply omit before intersection with union it works fine
🙂 Expected behavior

I should be able to omit fields of an intersection applied discriminated union.

This behavior follows from the definition of Omit, which is a mapped type. A mapped type operates on keyof the mapped type, which for a union is only the common keys, so the output is a new type containing only the common members.
What you want here is to distribute over the union and omit on each constituent:
type DistributedOmit<T, K extends keyof never> = T extends unknown ? Omit<T, K> : never;
// Works
type TestJobWithOmit = DistributedOmit<FinalJob,"started" | "ended">

which works as expected

My bad, I should have understood more in depth on how omit works. Closing this issue.
Thank you @RyanCavanaugh  for taking your time resolving my issue.

@RyanCavanaugh Could you explain how DistributedOmit works for union types?

@ducminh-phan See the documentation: https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#distributive-conditional-types
DistributedOmit is a conditional type, so the type argument T is distributed. This means if T is typed A | B, then you end up with Omit<A, ..> | Omit<B, ..>.


🐛 elections must be able to tally even if they don't have any spoiled/challenged ballots

duplicate of #262


Initial FreeBSD port of Foundation.

Now that we got a working swiftc on FreeBSD, I started porting foundation (lots of tests failing because there's no support for that). There's still a lot to do, but this is a starting point.

neat! overall this looks pretty decent of an initial #ifdef pass. What is the testing plan for this? I don't think there are any CI servers setup for this target.

After I get this working (there are still some build failures), I'll try running the test and try to set up a buildbot for this (but I think we're still away from it).
More patches/pull request will follow in the next days/weeks, I'd just like to merge small patches rather than carrying a big patch around (which will be hard to review, as well). Please let me know if you're fine with this.

In general we are happy to take portability diffs. This one will take me a bit to review but I have no problem merging it in. The only caveat is as @phausler mentioned - we may in the future take PRs or make changes ourselves which cause this port to fail to build or work correctly, since we are not testing it directly ourselves.

I see, thanks. That's why I'm trying to upstream the bits ASAP so once I'm done with the porting I can setup a buildbot myself to catch failures. But at this point, I'm fine with submitting patches once I discovered some changes broke FreeBSD support, if you're fine with that.

Looks good to me.


⚠ Bofrost.es has degraded performance

In 43ddf22, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1450 ms

Resolved: Bofrost.es performance has improved in 6dcff11 after 16 minutes.


Match base style during .glyphs regular master selection

In #252 we added a partial implementation of finding the regular master, see https://github.com/googlefonts/fontmake-rs/pull/252#pullrequestreview-1390381752. In particular, we don't implement the full "find a base style shared between all masters" logic. Create a source to prove this is broken and fix it, or ... perhaps compellingly argue we don't need to implement that logic because no known source actually uses it?

I did find a source that is affected by this:
https://github.com/marcologous/hanken-grotesk/blob/master/sources/HankenGrotesk-Italic.glyphs
crater currently reports it as the lower scorer, with 18.226%

This has three masters, Thin Italic, Italic and Black Italic. fontc currently picks the first one as the base or default master, whereas fontmake (glyphsLib) actually picks the second one named Italic (because that's the style name particle that is shared by all the master names).
picking a different default master obviously yields dramatic diffs when comparing two VF, both the default tables and variable ones will be very different.
If I modify the source file to add a Variable Font Origin custom parameter set to "Italic" master, fontc will produce a font that is almost identical to fontmake's, as they will both use the same master as the default one.

I also see a bunch of other *-Italic.glyphs around the bottom of the https://googlefonts.github.io/fontc_crater/ list with low diff scores, they must be following similar pattern so presumably we are picking the wrong master there as well.

Love having the concrete examples, crater all the things

#999 fixes this for Glyphs v3 sources (like HankenGrotesk-Italic), where GSFontMasters have an explicit name attribute which we can use to find the common style name.
For Glyphs v2, masters don't have a name attribute. Their name is the concatenation of three other attributes, width, weight and custom (in this order), with "Regular" stripped away.
search for these attributes under fontMaster in https://github.com/schriftgestalt/GlyphsSDK/blob/Glyphs3/GlyphsFileFormat/GlyphsFileFormatv2.md
When we up-convert v2 to v3 masters in glyphs-reader, we need to populate their name accordingly, otherwise it'll be empty or incorrect and the find_base_style logic won't work, leading to incorrectly selected defaut master and very bad ttx_diffs (e.g. NotoSansLaoLoopedUI.glyphs is pretty bad because of this).
glyphsLib makes up the v2 master names here:
https://github.com/googlefonts/glyphsLib/blob/9d5828d874110c42dfc5f542db8eb84f88641eb5/Lib/glyphsLib/classes.py#L1700-L1711
I propose we still merge #999 and deal with Glyphs v2 sources in a subsequent PR.


fix: target down in Prometheus

Fixes #N/A
Description
It is recommended to set the installation namespace for Karpenter controllers to kube-system, but it can interfere with other endpoints located there. This fix specifies for Prometheus job to scrap only the karpenter endpoint.

How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 82.53%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
4951

Relevant Lines:
5999

💛  - Coveralls


docs(yellow-paper): changes to circuit sections

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 316 (-27%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit e63f0226 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,700 (-1%)
180,580 (-1%)
720,100 (-1%)

l1_rollup_calldata_gas
222,700 (-2%)
871,000 (-2%)
3,465,880 (-2%)

l1_rollup_execution_gas
315,891 (-1%)
989,448 (-2%)
3,686,258 (-2%)

l2_block_processing_time_in_ms
1,155 (-4%)
4,360 (-2%)
17,290 (-3%)

note_successful_decrypting_time_in_ms
:warning: 316 (-27%)
984 (+1%)
3,767 (+4%)

note_trial_decrypting_time_in_ms
26.0 (-38%)
112 (+7%)
148 (-16%)

l2_block_building_time_in_ms
17,828 (-2%)
70,240 (-2%)
282,466 (-2%)

l2_block_rollup_simulation_time_in_ms
13,127 (-3%)
51,617 (-3%)
208,123 (-3%)

l2_block_public_tx_process_time_in_ms
4,672
18,545
74,085

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,786 (-14%)
26,476 (-13%)

note_history_successful_decrypting_time_in_ms
2,361 (+3%)
4,678 (+1%)

note_history_trial_decrypting_time_in_ms
98.6 (+13%)
236 (-5%)

node_database_size_in_bytes
17,309,776
33,099,856

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
307 (-6%)
44,528
25,825 (+2%)

private-kernel-ordering
194 (-1%)
44,145 (+1%)
16,225

base-rollup
1,406 (-3%)
128,654 (-1%)
933

root-rollup
82.3
4,192
729

private-kernel-inner
438 (+1%)
71,331 (+1%)
25,825 (+2%)

public-kernel-private-input
241
32,287 (-4%)
25,825 (-4%)

public-kernel-non-first-iteration
236 (-1%)
32,329 (-4%)
25,825 (-4%)

merge-rollup
7.89 (+1%)
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
16,859
40,167 (+13%)

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
553
1,303 (-10%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.537 (+6%)
575


Extensibility: merge navigation into resource

/test pre-busola-smoke-test-docker

/test pre-busola-smoke-test-docker


CI for Node

npm test

npm test

reviewed

npm test

hint

Sets the current player to be whoever it is not


Incorrect resize when Android apps button clicked

When device is horizontal and we press "currently open applications" button of android operating system, openfl resizes to portrait window size. However when we return to app, application is still in the landscape view mode. Than we rotate device vertical, app does not resize because it is already in portrait mode.
Example:
Application is landscape at (1000x600) resolution.
We click "currently open applications" button.
Openfl debugging tells us resize happened with (600x1000) resolution. (this is the issue, it should  not be happening, we did not rotated device, we only clicked an operating system button)
We select our app from open applications.
Application is still in the landscape mode, however rendering is in portrait mode due to wrong resize.
We rotate device and operating system buttons change position and we understand portrait mode activated. However our application does not trigger resize because it did already before.
At another device issue triggers when device is vertical and does not trigger when device horizontal.

I think this is fixed, similar to: https://github.com/openfl/openfl/issues/1325


Add support for docker and change the database path

I have added docker support. You just need to compile with static libraries and creating the docker image. To do that you just need to:

make build-docker -> It creates the binary with all the static libraries that can be added to a container
make docker-build -> it creates the docker image with the binary from the previous step
make docker-run -> it launch a container with the appropriate network to listen multicast packages, a volume for storing the database (if you don't store the database, each container will create a new one and therefore you need to register again the devices on the home app) and based on the container build on the previous step.

This will generate an around 10MB container.
Also I changed the path of the database so each device will have its own folder
And added a git ignore file.
Can you have a look and see if it works for you?. It assumes you have a working docker installation. If you have any doubt, don't hesitate to contact me.

I went a slightly different way with the Dockerfile, as you can see here: https://github.com/joeshaw/wemo-homecontrol/commit/95d129b1cb33b3f322cfcaac9c09a454fc654998
Namely, (1) I am using Docker multi-stage builds to compile the binary and stick it into a scratch image; (2) I added Go module support; (3) I am running it as an unprivileged user.
It may still be a good idea to add the Makefile (or a script) to make the Docker invocation easier (to include --network host or -p 1225:1225 and mount a file or volume for ~/.homecontrol/wemo).

It looks good, mine was to start as simple as possible, so you compile all locally and you just deploy the final image on the docker host. Your version is more advance.
Where you thinking on using any configuration framework? What about https://github.com/spf13/viper ?

I don't want to add any additional external dependencies, and while I don't love the standard library's flag package, I think most of the (very simple) configuration could be handled by it and/or a JSON config file.  See some of my other projects like https://github.com/joeshaw/carwings-homecontrol for instance.


Synchronize claim simplification code

Fixes #2144
Now there will be only one code path for simplifying claims.

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock

I updated some of the tests which had trivial changes, but there are still some failing non-trivially. I think this is because of the changes I made to checkImplicationWorker with respect to the right-hand side of the claim being \bottom. I will investigate more tomorrow.


TreeDataProvider: allow specifying a command to execute when a TreeItem is highlighted

This would allow extensions that use tree views for navigation match the behavior of the Quick Pick panel.
Related: https://github.com/patrys/vscode-code-outline/issues/5

@patrys You can provide a command that will be executed when the tree item is selected. See here - https://github.com/microsoft/vscode/blob/master/src/vs/vscode.d.ts#L4523
Is not this what you intended to want?

That works fine but in this case I meant highlighted using the keyboard so pressing up/down would give you a preview of where you'd end up in code.

We have two actions with keyboard - focus and selection.
up and down focusses the item and enter selects the item.
Commands are executed on selection

Sorry, let me rephrase that. I would like to be able to do some things when you use arrows (item focused) and another only when the item is confirmed (item selected). In my case it would be revealing parts of code on navigation and activating the editor once enter is pressed. I imagine it would be essential once we get search support for custom tree views.

@sandy081 I am building an extension where this would greatly improve the experience.  That is to be able to provide a command for focus events.
Any chance to look at this again?

Since, I started exposing events this can also be an event.

Since, I started exposing events this can also be an event.

Sounds good.  Also, are you suggesting this might get covered by other work exposing events you are already doing?

@dakaraphi No... This milestone events for expand/collapse are added. It's just about the approach I wanted to take here.

@alexr00 would be nice to have onDidChangeFocus event similar to onDidChangeSelection to utilize arrow keys for tree view nav and related 'outline' views display. My use case: https://github.com/RandomFractals/vscode-snippets-viewer/issues/56

Duplicate of https://github.com/microsoft/vscode/issues/170248, since this issue would be resolved by the new API.


[SuperTextField] on Mac it is not possible to overwrite key events that get handled by the Mac OS selectors

Since #836 that on Mac the key events such as arrow keys, are not handled by keyboard handlers but by the Mac OS selectors.
With SuperEditor it is possible to pass a list of selector, similar to what we do for keyboard handlers, but not for SuperTextField. It would be great to have this capability there as well.

Cc @matthew-carroll @angelosilvestre


Not clear with cross platform setup

I'm looking to integrate VCPKG into a large C++ project. The documentation isn't exactly clear for my situation.
We have our main library on Github with uses other libraries of ours on Github (all private).
Our development OS is a Mac. The main IDE is Xcode. This library is integrated into an iOS project. One of the subprojects is also used in a Visual C++ windows project.
We have a Python build script, which spits out a CMake for the various systems we support which include Android and Linux. CircleCI (Linux and Mac servers) run the build script and runs tests, etc.
A team member should be able to clone these Github projects and able to run them without hassle but able to update the libraries if needed.
What is the ideal way to get VCPKG integrated?

This issue hasn’t been updated in a year; if it is still an issue, please reopen.


Move AWS Terraform Secrets to Parameter Store

Describe the issue
A number of secrets are required for our Terraform modules. Currently these are provided at deploy time with local terraform variables stored on developer machines. This is not a good security pattern and makes automation difficult in the future. We want to move these secrets into AWS parameter store where terraform modules can read the values for use.
Additional context
Add any other context, attachments or screenshots
Definition of done

All secrets required by our Terraform modules are rotated and stored in Parameter Store
All Terraform modules that require secrets are modified to read them from Parameter Store using the Terraform data source
All developers that have secrets stored on their machines delete the secrets

Duplicate ticket


Checkup on all subsplit components

We need to make sure all subsplits have the right dependencies and work standalone.

TODO:

[ ] View config is in the wrong component

Individual test runs is now happening in CI on main. I am working with Coveralls to get Carryforward flags enabled for us so we can track individual coverage on each package instead of just the overall package coverage.
Next step, I think, would be to only run the test suite necessary for a PR submitted (e.g., if the database code is changed, don't test the mapper code).


Notifications bar encoding issue

I saw this today, clearly something is being encoded or decoded too many times or not enough someplace. See neilb's "while ..."

Hard to figure this out without sample data from notifications.log and a conversation log. Can you provide that @jberger? Please url_encode the data or something before pasting it into this thread, to make sure we don't miss out on anything.

Closing this because I cannot figure it out without further information.


Update sys-dm-exec-input-buffer-transact-sql.md

Changed the filter to is_user_process to stop perpetuating the myth that 50 is still a magical number here.

@AaronBertrand : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @AaronBertrand for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Allow a business day or more for review.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.

Thanks @AaronBertrand for your content suggestion, a doc update is now in flight. Look for your changes to appear live in the next day or so. Thanks again for submitting this change, your suggestion here helped improve our documentation.


changelog with docs

Using changes logged at http://httparchive.org/about.php#testchanges
Closes #101

👍


running totala gone missing today

after disconnecting and reconnecting a bank link (timing may not mean anything) ALL account running balances disappeared!  How do I get them back?
running balance

System Settings (Required)

ToolKit Version: 2.11.3
Operating System (Mac/Windows/Etc): windows 8
Browser (Chrome/Firefox/Safari): firefox
Browser Version: ABOUT FIREFOX says in about Firefox Quantum is up to date but gives no version #
Other Extensions:  only adblock which is currently disabled

Export of Toolkit Settings (Bottom Left of Settings Page)
dont know how to find these. please advise.

Settings Export
PASTE SETTING EXPORT HERE

Steps to Reproduce the Behavior

just ran ynab .. had balances
delected and added one  bank kink connection
balances disappeared

Expected Behavior
expected balances to still be there (running totals)
Actual Behavior
 link connect worked

@bigsurmagic As the heading says, the Toolkit settings are found on the Toolkit Settings Page in the bottom left corner. The Settings page is what you get when you click on the Toolkit icon that was added to your browser when you installed the Toolkit.

They are not found in the YNAB app itself.

@bigsurmagic Are you still experiencing this issue? Please make sure the feature didn't somehow get disabled!


Feature/calcuttj daphne new data

Integrated new Daphne frame versions into the decoder

Hi Jake,  I think I see the problem here -- you need to use HDF5RawFile3Service instead of HDF5RawFile2Service.  My apologies for not being consistent with 2's and 3's.  This is the second DAPHNE format but the third HDF5 format.  And I was a a little sloppy in the HDF5FileInfo2 data product was re-used for the HDF5RawInput3_source.  HDF5RawFile3Service gives access to the upgraded HDF5RawFile class from the DAQ which as a different-size trigger record header, which will mess up your decoding if you use the old one.

A reason I like a separate decoder for each data format is what happened with ICEBERG.  We've gone through no fewer than eight data formats for the TPC data, and a ninth is on its way.  We had artdaq fragments and container fragments for RCE and FELIX (four formats), 14-bit WIB data (FELIX only), WIB spy-buffer data, First HDF5 format, WIBEth HDF5 format in the second HDF5 format, and upcoming third HDF5 format.  The first decoder worked on the first four formats -- (RCE + FELIX)*(container frags + noncontainer frags) and it already got a bit messy, trying to auto-detect the format and doing the right thing.  Then the HDF5 data looked so different, and the WIB spy-buffer data weren't even divided up into events and so had to be treated differently.  I gave up trying to read it all in one place.  I expect the DAQ to change data formats again in the future.
The old artDAQ fragment class in fact has several versions of its header, and it automatically upgrades them on readin.  This has been the source of some very nasty bugs that took weeks of effort to identify, diagnose, fix, review, and test.  It is good when ROOT does this for us, but even ROOT gets it wrong sometimes.  And we're not using ROOT anymore.  At least the framework allows us to modularize code so it doesn't interfere with other code in the framework.

@tomjunk I've refactored things a bit differently where that should fix/safeguard against mixed up fragments/frames etc.

trigger build with DUNE/duneprototypes#44

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

:x: CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the build DUNE phase logs
parent CI build details are available through the CI dashboard

This PR created a bunch of clang warnings which are treated as errors, and a couple of errors.
https://dbweb8.fnal.gov:8443/LarCI/app/ns:dune/storage/docs/2024/05/10/buildDUNE%23spFysjd.log

The gcc build succeeded however.

:warning: CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof -- details available through the CI dashboard
:rotating_light: For more details about the warning phase, check the ci_tests DUNE phase logs
parent CI build details are available through the CI dashboard

trigger build

trigger build with #44

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

:x: CI build for DUNE Failed at phase ci_tests DUNE on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the ci_tests DUNE phase logs
parent CI build details are available through the CI dashboard

:warning: CI build for DUNE Warning at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard
:rotating_light: For more details about the warning phase, check the ci_tests DUNE phase logs
parent CI build details are available through the CI dashboard

@tomjunk only the clang CI tests failed but the build succeeded. Good to merge?


prolly a copy paste residuum

https://github.com/opendlang/opend/blob/0f83714c030b39a9acd849a2eb8d034e06d34832/compiler/src/dmd/dsymbolsem.d#L8056

what's the problem this makes?

pragma(explicit_gc, 1, 2)`

Error: one boolean expression expected for `pragma(inline)`, not 2

should be explicit_gc, that is all

oooooooooooooh i see ok will fix in the next push

fix up now


Implement coming soon on cards

Update the card component to say "coming soon"
Keep track in the constants.js file of which one is publshed. Yall figure out how you wanna do that. (examples to get yall started are: comingSoon: true/false, or publishedDate: "date")

Do this after #14 & #15 15 are done


Fix premature ack in tutorial

Ack in first block of code causes error because of noAck = true.

@raedwa01 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

FTR, the example in question uses automatic acknowledgements because manual acknowledgement is introduced later in the tutorial. So this solution is the right one. Thank you.

@raedwa01 Thank you for signing the Contributor License Agreement!

I agree it is introduced later, it was that the noAck being true at that point in the tutorial caused an error to throw.  Once i got lower in the tutorial and ran under that updated code, with noAck = false, it ran fine.


Add a new tool (to_triage): get daily email with bugs where priority …

…is unset

Coverage decreased (-0.3%) to 30.5% when pulling e82fd6f42f5ace1ab5d06002965a94f68d9d8d48 on calixteman:to_triage into ca252047373c8e9a5a0433e2fb4acc49e6542b15 on mozilla:master.

I don't understand what it is doing new?

Just send a daily email with bugs to "triage" for Andrew's team.
So instead of having first needinfo after 2 weeks or first emails after 4 weeks, just get todo list almost in "real" time.


Module Not Found: whisper

Hello! My class was trying to get this to run but having troubles.
Can you help, we are stuck at the following when trying to run:
glados.py", line 5, in
import whisper
ModuleNotFoundError: No module named 'whisper'
The module is loaded and is visible in our files, but for some reason we keep getting this error.

this seems like an issue specific to your install
i was unable to reproduce the issue as pip install -U openai-whisper worked flawlessly


Request for incubation: conda-pypi

Project URL: https://github.com/jaimergp/conda-pypi
Comes from https://github.com/jaimergp/conda-pypi/issues/25
Members of the conda-pypi team: @jaimergp, @jezdez

Adding this for historical record. If I don't hear from any objections, I'll proceed with the transfer.

I'd like to participate in the team if you have me

Done!


Updated StartServer to allow user to choose from > 9 .sln files

Nice. Thanks!

Thanks for your work on this project. Much appreciated!


[Feature] Support Flutter Redux

Can it support the lib Flutter Redux?
The current version cannot compatable on Flutter Redux, so when I'd like to use server paging, cannot get the paing information to load the data

Hi @KevinTsangSKH
Kindly share the error you are facing


libswoc: Remove legacy TextView

Remove legacy TextView.
The changes that required code updates are

The char overloads for prefix / suffix were renamed to prefix_at / suffix_at. Although it sounds good in theory, the flexibility of integral conversion makes the overload fraught.
char based prefix / suffix operators would return all of the view if the target wasn't found. That was changed to return an empty view

[approve ci autest]

[approve ci autest]

[approve ci autest]

[approve ci cmake]


Karma init. TypeError: Cannot call method 'slice' of undefined

Get error when try run karma init:
 readline.js:507
  this.line = this.line.slice(this.cursor);
                        ^
TypeError: Cannot call method 'slice' of undefined
    at Interface._deleteLineLeft (readline.js:507:25)
    at suggestNextOption (/home/maksimrv/www/jetbrains/.../node_modules/karma/lib/init/state_machine.js:43:9)
    at nextQuestion (/home/maksimrv/www/jetbrains/.../node_modules/karma/lib/init/state_machine.js:120:12)

Linux 3.13.0-24-generic 47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Ubuntu 14
Karma version: 0.12.24
karma-cli 0.0.4
node 0.10.29/0.11.13
use nvm

We had same error on Windows under Cygwin now I can reproduce it on ubuntu

@maksimr is this still an issue with the latest node versions?

@Dignifiedquire nope


implement isomerism bug fixes plus tests

@pckroon at the moment is is not required for the rs_isomer as the nodes only get annotated with '@' or '@@'. However, in the current code it is not possible to have the chiral center using the ring bond accounting. That's why it is not needed at the moment.
The ring thing is a bit tricky because we just strip the smiles string of these characters. Doing the ring thing would actually require looking up the index belonging to a ring atom and matching it.

rings are fixed as long as they are within a fragment; chirality split between fragments remains a fragile thing


chore(Dependencies) : update zio-logging-slf4j from 0.5.16 to 2.1.11

About this PR
📦 Updates dev.zio:zio-logging-slf4j from 0.5.16 to 2.1.11 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-logging-slf4j" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-logging-slf4j" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #592.


Force current cygwin root to be used by setup on dist-upgrade

This patch fixes a problem where setup.exe cannot find your cygwin rootdir and assumes c:\cygwin.
Setup.exe is invoked with rootdir resolved by cygpath.
This is probably not bullet proof - for instance i'm guessing running dist-upgrade under chroot would break things.

It's provably working well.
But, I wonder that it requiers filtering of sed.
Can you give some examples that will not work well without filtering of sed?

I did not try it without sed - it's entirely possible sed is not necessary.
I just saw the path being reported to setup.exe having double backslashes and thus added the sed to make the path generated by cygpath the same.

Thanks.
For examples:
$ echo "$(cygpath -wa / | sed 's/\\/\\\\/g')"
C:\\cygwin64

$ echo "$(cygpath -wa /)"
C:\cygwin64

$ echo "C:\\cygwin64"
C:\cygwin64

Hmm, I could not find out helpful effects by sed in this case.
O.K. I'll remove it.
If anyone finds problems that caused by the absence of sed, please tell me it.


[FR]: Querying polymorphic one-2-one with trackable_id column

I'm having hard time converting Gorm/Bun code to Ent.
As already asked I need a way to define one-2-one/one-2-many "polymorphic" relations.
Right now for the one-2-one I'm trying with this code:
type Order struct{ ent.Schema }

func (Order) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("payment", Payment.Type).Unique(),
	}
}

type Contract struct{ ent.Schema }

func (Contract) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("payment", Payment.Type).Unique(),
	}
}

type Payment struct{ ent.Schema }

func (Payment) Fields() []ent.Field {
	return []ent.Field{
		field.Uint64("amount"),
		field.Uint64("trackable_id"),
		field.String("trackable_type").Annotations(entgql.Skip()),
	}
}

func (Payment) Edges() []ent.Edge {
	return []ent.Edge{
		edge.From("order", Order.Type).Ref("payment"),
		edge.From("contract", Contract.Type).Ref("payment"),
	}
}

and I'm querying payments with:
query := db.Payment.Query()

query.WithOrders()//.WithContracts()

output, err := query.All(ctx)
//handle err

but the queries are wrong:
SELECT DISTINCT "payments"."id", "payments"."amount", "payments"."trackable_id", "payments"."trackable_type" FROM "payments"

SELECT DISTINCT "orders"."id", "orders"."order_payment" FROM "orders" WHERE "order_payment" IN ($1, $2, $3, $4, $5, $6) args=[1 2 3 4 5 6]

because 1,2,3,4,5,6 are payment's id column values, not trackable_id.
Is there a way I can query the correct rows?
The problem is the WHERE "order_payment" because I need a query like:
SELECT DISTINCT "orders"."id", "orders"."order_payment" FROM "orders" WHERE "id" IN ($1, $2, $3, $4, $5, $6) args=[1 2 3 4 5 6]

and 1 2 3 4 5 6 should come from payments.trackable_id column.
I tried adding .Field("trackable_id") but it throws with:
entc/gen: set \"Order\" foreign-keys: field \"trackable_id\" was not found in the schema for edge \"order\""

Polymorphism is tracked here: https://github.com/ent/ent/issues/1048.


Naming a slot "items" causes infinite loop

Steps to reproduce

Create a component with a passthrough slot named "items":

renders_many :items, "ItemComponent"

# ...

class ItemComponent < ViewComponent::Base
  def call
    content
  end
end

In a view, instantiate the component and fill the slot one or more times:

<% foo.bar(**args) do |bar| %>
  <%= bar.item do %>

Hello World!

  <% end %>
<% end %>

Add some logging statements to the view and component to see the behaviour despite unsuccesful render.

Expected behavior
The component should render the slot the specified number of times.
Actual behavior
Upon render, the component enters into an infinite loop, eventually crashing the Rails server.
System configuration
Rails version: 7.0.4
Ruby version: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
Gem version: 2.76.0

Hi! Thanks for taking the time to open an issue. I'm wondering if something else could cause the infinite loop in your code, because I've been using slots named items on multiple occasions and I've never encountered this bug.
Do you think you can provide an example repo as explained here?

Hi @Spone , thanks for replying so quickly!
I've been attempting to replicate the issue in an example repo but appear unable to. It's strange, when I encountered the bug I narrowed it down to being an issue with components, and all I did to fix it was change the name of the slot.
Maybe the bug is more specific than I thought and is actually a consequence of two gems not playing nicely together. I could take the example repo further by adding in SimpleForm, but at that point it's not really an issue with ViewComponent anymore. If you're interested, the full pattern I was using was this:
<%= simple_form_for foo do |form| %>
  ...
  <%= render NestedFieldsetGroupComponent.new do |group| %>
    <% form.simple_fields_for :bar do |nested_form| %>
      <% group.item do %>
        ...
      <% end %>
    <% end %>
  <% end %>
<% end %>

Since I've been unable to replicate this issue so far I'm happy for the issue to be closed or to provide more information if it's something you'd like to look into further.

Yes, rendering ViewComponents in forms is related to a few known issues.
What do you think about adding a mention of your specific SimpleForm-related issue on this page?

Since I've been unable to replicate this issue so far I'm happy for the issue to be closed

@rhysb27 I'll go ahead and close this issue for know. Feel free to provide additional info by replying here!


Add "all repositories" parameter

Currently in Gitblit you must explicitly list all repositories to search in them. This does not allow to conveniently link to search page, for example, from a bugtracker. This patch adds "in all repositories" parameter so you can link to /lucene/?allrepos=1&query=$q or select a checkbox in the UI :)

@vitalif This looks great.  Make the small tweak and I'll merge.

There's an additional defect which should also be fixed: current implementation can duplicate the same repository multiple times in searchRepositories. In fact, you can even pass the same repository multiple times in the query parameter: /lucene/?query=xxx&repositories=repo+repo+repo, and it will lead to duplicate search results :)


Update Proxy.cs

Added RegEx Matching for "IP:PORT" during Proxy(string) function before passing Address to proxy.Trim(); some proxy lists have errors or incorrectly formatted proxies that will throw an exception during running. This prevents anything invalid from being passed to Address variable that isn't an IP:PORT.
Includes: using System.Text.RegularExpressions;

in the comment to the previous your pull request, I did not mean this, I will submit the commit as soon as I can use my pc

opened to not forget

reworked