Add vetted docs re: how to do data domiciling

Fixes #10553

This change is

hey @taroface!  FYI this has had some pretty heavy internal review re: the technical and legal claims w.r.t domiciling so if I am worried about changing any specific thing based on your suggestions that is why.  also happy to chat offline if that is easier

PS the above is not me saying "please just rubber stamp this with no feedback", sorry if it came off that way.  happy to update to make it clearer etc, just saying it will need more care than usual for reasons mentioned above

Hey @taroface just wanted to check in on this one!  I realize it's kinda big.  Do you think maybe next week?  It's not really a rush,  but I wondered if it fell through the cracks since that happens to me as a reviewer sometimes!

Sorry @rmloveland, this totally passed me by somehow. I will take a loop ASAP.


won't open an connection to popkit

What is this? I try to install a package using popkit while I got this:
Opening TLS connection with ‘gnutls-cli --x509cafile nil -p 443 elpa.popkit.org’...
Won't open an connection?
curl -i http://elpa.popkit.org/packages/archive-contents

HTTP/1.1 301 Moved Permanently
Server: nginx/1.4.6 (Ubuntu)
Date: Fri, 13 May 2016 01:01:35 GMT
Content-Type: text/html
Content-Length: 193
Connection: keep-alive
Location: https://elpa.popkit.org/packages/archive-contents

<title>301 Moved Permanently</title>

301 Moved Permanently

nginx/1.4.6 (Ubuntu)

While I tried curl with melpa, it works fine.

机器cpu 100%了，在修复中


Document title and table colors for org-mode.

Added colors for org-mode's document title and table. If you'd rather have other colors then please reject this PR.

Thank you! :+1:


Estimations increase dramatically

While rio runs well on the provided datasets, however when I try to launch it with my own rosbag, the estimate position and velocity seem to increase very rapidly, and converge to wrong numbers, as the robot real speed is 0.5 m/s (while the ones shown below will increase indefinitely as the bag is playing) :
pose:
  pose:
    position:
      x: -160.44983290133843
      y: -14.600831309434668
      z: -47.69175573838993
    orientation:
      x: -0.02611747507882512
      y: -0.032748962918190724
      z: 0.9235699756457728
      w: 0.38113471154690987
  covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
twist:
  twist:
    linear:
      x: 8.807195182027714
      y: 12.875944052624204
      z: -2.5869651071525483
    angular:
      x: 0.05528554320335389
      y: -0.012584030628204346
      z: 0.0011943281861022117
  covariance: [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]
---

There is also this series of warnings, that I could not debug properly, as the timings seem to be too close and the mismatch is only in the last fractions of time, not sure if this what causing the wrong estimation:

[ WARN] [1721221984.697609407]: Failed to split propagation, skipping CFAR detections.
[ WARN] [1721221984.697652414]: Split time:<PHONE_NUMBER>.525563847
[ WARN] [1721221984.697669591]: Last IMU time:<PHONE_NUMBER>.519120621
[ WARN] [1721221984.797759724]: Failed to split propagation, skipping CFAR detections.
[ WARN] [1721221984.797818564]: Split time:<PHONE_NUMBER>.625555836
[ WARN] [1721221984.797849152]: Last IMU time:<PHONE_NUMBER>.618970971
[ WARN] [1721221984.897949333]: Failed to split propagation, skipping CFAR detections.
[ WARN] [1721221984.898010507]: Split time:<PHONE_NUMBER>.725679948
[ WARN] [1721221984.898040557]: Last IMU time:<PHONE_NUMBER>.718575103

Would sincerely appreciate your answer

Hi there, most likely it diverges when only IMU messages are considered. Did you implement the buffer https://github.com/ethz-asl/rio/issues/6 ?

I think a buffer will solve the problem with early arriving radar messages. I may have time to implement it at some point as well. You can contact me by mail at<EMAIL_ADDRESS>and I can look at your data set.

Any updates on the buffers @rikba?

Daniels PR should solve this issue. Sorry, did not have time to test and merge it. https://github.com/ethz-asl/rio/pull/12


Update docs to refer to Web module

Noticed these docs pointed to the "business domain" module, but I think they should be pointing at the web module.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


AuditSink for PostgreSQL

This is Bingkun Li from TerumoBCT. We added the Auditsink functionality for your SerilogSinkForPostgreSQL. We would like to create a PR for this change. Would this be ok with you? Also do we need to upload nuget package as well? Thanks.

Hi Bingkun. That would be a great feature. If you like to, just create your pull request and tell me when you're done. I will check it and merge it afterwards :)

Thank you Hans (SeppPenner). We are getting together for a pull request. A couple of notes here:

we added or append 'copyright' info with "TerumoBCT' to the files we added or changed. let me know if this is ok or not.
a. SerilogSinkForPostgreSQL\src\SerilogSinksPostgreSQL\Sinks\PostgreSQL\PostgreSQLAuditSink.cs (new)
b. SerilogSinkForPostgreSQL\src\SerilogSinksPostgreSQL\LoggerConfigurationPostgreSQLExtensions.cs (changed)
c. SerilogSinksPostgreSQL.IntegrationTests\DbWriteTests and DbWriteWithSchemaTests (changed)
We also add a 'using Serilog.Sinks.PostgreSQL.ColumnWriters;' to the files in SerilogSinksPostgreSQL.Tests project to make it build. So we also include them in this pull request. Note this is not part of this auditsink feature, but just make the solution build.

Hi Hans,
I have created a pull request (https://github.com/SeppPenner/SerilogSinkForPostgreSQL/pull/29).
However, there are some conflict files (I think they are as I noted from last message #2 that you may also fixed)
Conflicting files
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/ExceptionColumnWriterTest.cs
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/IdAutoincrementColumnWriterTest.cs
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/LevelColumnWriterTest.cs
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/PropertiesColumnWriterTest.cs
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/SinglePropertyColumnWriterTest.cs
src/SerilogSinksPostgreSQL.Tests/ColumnWritersTests/TimestampColumnWriterTest.cs
I am undoing the changes to these six files and committing it to see if resolves the conflicts.
Sorry about that and please let me know if this would be able to merge or if another pull request is needed.

Hello Hans,
Do you have any chance to check this PR out?
Thanks
Bingkun

I'm at it at the moment.

I was confused about some of your changes, now I understand the issues. I have adjusted some things in the sink after you added your stuff.

Sorry about the confusion. Yes, I forked the repo before you reworked some tests. When I tried to build the forked one from Visual Studio, I saw some build errors but added 'using Serilog.Sinks.PostgreSQL.ColumnWriters' to the tests to fix it. When I created the pull request, there were some conflicts. So I removed my these 'using', this resolved the conflicts.
Feel free to make changes.

I will make some changes, it's merged and will be available from the next release on, I guess.

Thanks. The tests may need some changes per your recent work. I have just pushed some changes to the master branch of my forked repo.  you could take a look.
Also when you could make a nuget package available for us to use?

Yeah, I have done the changes already. I hope that it still works as desired. The new nuget package should be available soon.

Great! Just let me know if the new nuget package is available. Thank you very much.

It should have been available from yesterday already but something went wrong. It's online now.

I see the new nupkg 3.3.1.
Thank you!


TextPrefabSamplesTest missing Segoe Font & prefabs

HoloToolkit/UI/Materials/3DTextSegoeUI.material missing Font Texture.
@cre8ivepark

Submitted PR #498 It would be appreciated if you could check. Thank you!


Increment versions for elastic releases

Increment package versions for elastic releases

API change check
API changes are not detected in this pull request.


Retry params download upto 10 times

Merged on https://github.com/pastelnetwork/pastel-electron-wallet/pull/37


Monitoring spark applications using spark operator

@liyinan926  Is there any way to monitor spark applications using spark operator

https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/docs/user-guide.md#monitoring

Closing this and please posting further questions to our Slack channel.


Other languages support

Nice project, I was going to attempt writing such a tool, it may save me lots of time!
That said, I see no support for other languages than go. In my case I would also need java and python (to start with). I am willing to contribute, but some hints on how to add such support would be appreciated.

Hey Christophe,
To add Python support, try these steps:
First create a Python-based server:

Take helloworld.proto and generate *_pb2.py files from it using protoc.
Also generate the files for nrpc.proto.
Write out python class(es) that makes use of python-nats. This should basically listen on a NATS topic, decode the incoming messages as nrpc.RPCRequest objects (see nrpc.proto), call a handler to handle Greeter.SayHello (see helloworld.proto) and encode the response as nrpc.RPCResponse. Basically a Python port of this go code.
Write a test server (port of this go code) which will implement an example greeter service. You should be able to run this script.
At this point you should be able to use the Go client to talk to the Python server.

The next logical step is to write the client:

Write out a python class that will provide clean APIs for invoking greeter.SayHello (port of the GreeterClient Go class in helloworld.nrpc.go).
With this class you should be able to write a Python client script that can talk to your Python server or a Go server.

The final step is to templatize and create the generator:

Copy-paste protoc-gen-nrpc as protoc-gen-nrpcpy and edit the template file tmpl.go.
You should now be able to invoke the generator as protoc --python_out=. --nrpcpy_out=. helloworld.proto to create helloworld_pb2.py and helloworld_nrpc.py.

Porting to Java would be quite similar.
Preferably, the generator should be in Go, and the generated code should work with both Python3 and Python2.
Feel free to raise any questions/suggestions here.
Cheers,
-Mahadevan

This is great, thanks!
Will keep you informed when I start working on it.

I hacked a python port : https://bitbucket.org/orus-io/python-nrpc
Some features are not yet tested and probably don't work.

The python port works better now (still early stage but usable), and has been move to https://github.com/nats-rpc/python-nrpc


MMX Instructions

The following instructions have been implemented (i.e. all instructions marked mmx in grp1 here):

emms
movd
movq
packssdw
packsswb
packuswb
paddb
paddd
paddsb
paddsw
paddusb
paddusw
paddw
pand
pandn
pcmpeqb
pcmpeqd
pcmpeqw
pcmpgtb
pcmpgtd
pcmpgtw
pmaddwd
pmulhw
pmullw
pshufw
por
pslld
psllq
psllw
psrad
psraw
psrld
psrlq
psrlw
psubb
psubd
psubsb
psubsw
psubusb
psubusw
psubw
punpckhbw
punpckhdq
punpckhwd
punpcklbw
punpckldq
punpcklwd

Other updates:

[x] Handle NM and UD exceptions
[x] Enable QEMU tests for MMX instructions
[x] Automate the nasm tests (see /tests/nasm/README.md for more). TL;DR: Automatically uses gdb to generate fixtures for MMX registers and compares to cpu.reg_mmxs from v86 after using a multiboot kernel image. Shows actual vs. expected values.
[ ] Consider adding nasm tests to Travis CI (let me know if you want me to do this, I believe we'll only need to install gdb and run the nasmtests target)

Caveats

MMX registers are supposed to alias the mantissa part of the x87 (FPU) registers. This PR does not implement that (as can be seen from the failing emms test).
nasm tests currently compare the values of MMX registers only. They won't catch bugs introduced in other aspects.

Thanks!


[Bug]: vLLM 0.4.1 get stuck when exit

Your current environment
Collecting environment information...
PyTorch version: 2.3.0a0+ebedce2
Is debug build: False
CUDA used to build PyTorch: 12.3
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.28.1
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-52-shopee-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.3.107
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A30
GPU 1: NVIDIA A30

Nvidia driver version: 510.73.08
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.7
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:                                                                                [29/1833]
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Address sizes:                   46 bits physical, 57 bits virtual
Byte Order:                      Little Endian
CPU(s):                          128
On-line CPU(s) list:             0-127
Vendor ID:                       GenuineIntel
Model name:                      Intel(R) Xeon(R) Gold 6438M
CPU family:                      6
Model:                           143
Thread(s) per core:              2
Core(s) per socket:              32
Socket(s):                       2
Stepping:                        8
CPU max MHz:                     3900.0000
CPU min MHz:                     800.0000
BogoMIPS:                        4400.00
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm const
ant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pci
d dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cat_l2 cdp_l3 invpcid_single cdp_l2 ssbd mba ibrs ibp
b stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt cl
wb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect avx_vnni avx512_bf16 wbnoinvd dtherm ida a
rat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid bus_lock_d
etect cldemote movdiri movdir64b enqcmd fsrm md_clear serialize tsxldtrk pconfig arch_lbr amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities
Virtualization:                  VT-x
L1d cache:                       3 MiB (64 instances)
L1i cache:                       2 MiB (64 instances)
L2 cache:                        128 MiB (64 instances)
L3 cache:                        120 MiB (2 instances)
NUMA node(s):                    2
NUMA node0 CPU(s):               0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78,80,82,84,86,88,90,92,94,96,98,100,102,1
04,106,108,110,112,114,116,118,120,122,124,126
NUMA node1 CPU(s):               1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79,81,83,85,87,89,91,93,95,97,99,101,103,1
05,107,109,111,113,115,117,119,121,123,125,127
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Mmio stale data:   Not affected
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Versions of relevant libraries:
[pip3] mypy==1.10.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.24.4
[pip3] onnx==1.15.0rc2
[pip3] onnx-graphsurgeon==0.5.2
[pip3] onnxruntime==1.16.3
[pip3] optree==0.10.0
[pip3] pytorch-quantization==2.1.2
[pip3] torch==2.3.0a0+ebedce2
[pip3] torch-tensorrt==2.3.0a0
[pip3] torchdata==0.7.1a0
[pip3] torchtext==0.17.0a0
[pip3] torchvision==0.18.0a0
[pip3] triton==2.2.0+e28a256
[conda] Could not collectROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: N/A
vLLM Build Flags:
CUDA Archs: 5.2 6.0 6.1 7.0 7.2 7.5 8.0 8.6 8.7 9.0+PTX; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    CPU Affinity    NUMA Affinity
GPU0     X      SYS     0,2,4,6,8,10    0
GPU1    SYS      X      1,3,5,7,9,11    1

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
On 2 * A30 GPU, when run inference using tp=2, it get stuck after inference.
Seems it gets a dead lock when exiting.

I also report it here. https://github.com/NVIDIA/nccl/issues/1266

FYI @youkaichao
Thank you for reporting at nccl repo. It doesn't seem like anything can be done from our side.

Closing since we can do nothing about it.


UI: Filtering by regex raises errors without being handled

Affected Version
0.19.0
Description
When I try to filter data via /unified-console.html#load-data endpoint and use Type regex and for example don’t pass a Dimension or Pattern it raises an exception which makes sense but shouldn’t this exception be caught and “handled”? Because in the UI I am not able to correct it in the same view. I would have to go to “Edit spec” to edit it directly.
Same goes for invalid regex expressions.
Screenshot of Issue:

Proposed Solution
Catch exception and let the user correct it.

This has been fixed :-)


feat: decouple iceberg commit from risingwave commit

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
complete #13899

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Generally LGTM!
Do we have any report on how the checkpoint interval affects the sink performance? How much performance gain can we achieve when we combine the data of multiple checkpoints?

There is no performance report now. But I added the simple test case that can be used to compare the file size using checkpoint decouple.
Before:

After:

I think we can test it later


[HUDI-861]Add Github and Twitter Widget on Hudi's official website

What is the purpose of the pull request
*In order to further strengthen the influence of the Hudi community. *
Brief change log

Add Github and Twitter Widget on Hudi's official website

Verify this pull request
This pull request is already covered by existing tests.
Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Like Ignite(https://ignite.apache.org)

Thanks for taking this, sync to https://lamber-ken.github.io

Hi @yanghua @hddong, maybe it's better to keep homepage clear.
For example, https://bookkeeper.apache.org/

@lamber-ken : had fix and hidden bar when cann't access, please have a reviewe when free.

@lamber-ken : had fix and hidden bar when cann't access, please have a reviewe when free.

Thanks, will check it.


Search process starts slow and blocks UI

Since we are searching as we type, the first character that is entered inevitably triggers a several-second-long search with a huge number of (not particularly useful) hits:

The search would ideally be running off-GUI with some kind of "work in progress" indicator, that would be interrupted and restarted as more input is added/removed from the search area (so I don't have to wait for the "a" search to finish before searching for "ad" and then "add").

one option: if search is < 3 characters, don't search (also suggested by @ctrueden)


Support copying the flash ID

Rename --retain-size to --use-size.
Update tests.

Fixes #4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

16 of 17 (94.12%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 68.966%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/split/gc.go
12
13
92.31%

Totals

Change from base Build<PHONE_NUMBER>:
1.3%

Covered Lines:
120

Relevant Lines:
174

💛  - Coveralls


update object attribute recommended_article__pk

@codiebeulaine @sewagodimo
Please review

@Mitso If  we are changing from pk's to queryset then we should change the name from pk_list to something else as well, and possibly update a test if there is?

I think we should rename pk_list to ordered_recommended_articles or something prettier. I am not sure that this will affect any tests but let me know if anything fails


Recovery from disconnected session

After disconnected, session could not be reconnected.

Hi, that's strange. Let me know if it happens again.

Hi, when I went back to the page, it has been disconnected, and I tried to find the logs, and the error messages are what I pasted above.

Hmm… I'm not sure why the session would be closed, that seems like exactly the kind of bug I was trying to prevent when designing. I'll think more about this and test a bit!

I did not find any other reason, but I guess it may be related to my network environment, for example, vpn proxy was unstable. On the other side, I think there should be a way to reconnect to the original session even if something like this happens.

On the other side, I think there should be a way to reconnect to the original session even if something like this happens.

Yes, this is in fact implemented already — that's why I'm surprised that it's not working! It should allow you to reconnect as long as you did not lose network access for more than 5 minutes.
https://github.com/ekzhang/sshx/blob/e01b75a3bc641b1685a7f04fc0fce63c999f2fc1/crates/sshx-server/src/state.rs#L22-L27

FYI — I just found a client issue that would actually be consistent with this problem, since the client would keep trying to connect to the shutting-down server rather than a fresh one.
https://github.com/ekzhang/sshx/commit/9c67031798be6ddebde8677561782269298f3ed6

I ran into this issue again now :( Any way to tell if it was due to me being offline for more than 5 minutes?
Log
2024-04-02T13:58:03.917992Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: unexpected end of file", details: [], metadata: MetadataMap { headers: {} }
2024-04-02T14:10:45.509902Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: stream closed because of a broken pipe", details: [], metadata: MetadataMap { headers: {} }
2024-04-03T23:36:08.877454Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: connection reset", details: [], metadata: MetadataMap { headers: {} }
2024-04-03T23:36:48.679375Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: connection reset", details: [], metadata: MetadataMap { headers: {} }
2024-04-04T12:46:47.757943Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: unexpected end of file", details: [], metadata: MetadataMap { headers: {} }
2024-04-04T12:54:43.597885Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: stream closed because of a broken pipe", details: [], metadata: MetadataMap { headers: {} }
2024-04-05T16:28:29.319388Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: connection reset", details: [], metadata: MetadataMap { headers: {} }
2024-04-05T16:45:19.157606Z ERROR sshx::controller: disconnected, retrying in 1s... err=status: Unknown, message: "h2 protocol error: error reading a body from connection: timed out", details: [], metadata: MetadataMap { headers: {} }
2024-04-05T16:45:20.649420Z ERROR sshx::controller: disconnected, retrying in 2s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:45:20 GMT", "content-length": "0"} }
2024-04-05T16:45:23.151499Z ERROR sshx::controller: disconnected, retrying in 4s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:45:22 GMT", "content-length": "0"} }
2024-04-05T16:45:27.647486Z ERROR sshx::controller: disconnected, retrying in 8s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:45:27 GMT", "content-length": "0"} }
2024-04-05T16:45:36.113198Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:45:35 GMT", "content-length": "0"} }
2024-04-05T16:45:52.624997Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:45:51 GMT", "content-length": "0"} }
2024-04-05T16:46:09.096503Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:46:08 GMT", "content-length": "0"} }
2024-04-05T16:46:25.605511Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:46:25 GMT", "content-length": "0"} }
2024-04-05T16:46:42.074685Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:46:41 GMT", "content-length": "0"} }
2024-04-05T16:46:58.595640Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:46:58 GMT", "content-length": "0"} }
2024-04-05T16:47:15.055706Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:47:14 GMT", "content-length": "0"} }
2024-04-05T16:47:31.515656Z ERROR sshx::controller: disconnected, retrying in 16s... err=status: NotFound, message: "session not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Fri, 05 Apr 2024 16:47:30 GMT", "content-length": "0"} }

Then the last message repeats ad infinitum

Maybe a server error, not sure -- is anyone else running into this? Just curious

It happened again tonight on two raspberry pi zeros and one raspberry pi zero 2w, all on a 4g connection :(
Would it be possible to extend the 5 minutes after which a session is dropped to maybe 30?

Weird, we can definitely extend the timeout but I'm not sure if that's actually the issue — do think your 4G connection is likely to have cut out for 5 minutes? There might be a bug somewhere else.

Sounds good! Tbh I'm not sure how long it might cut out during the night, but during the day most interruptions are short. Let me know if I can do anything more to understand what's happening better.


usage steps

added steps tasks at my main.yml as per readme. ran
ansible-playbook action.yml
got error:
A playbook must be a list of plays, got a <class 'ansible.parsing.yaml.objects.AnsibleMapping'> instead

This is a GitHub Action, it's not for Ansible


Error run quant_test.py to quantize ds_cnn

INFO:tensorflow:Confusion Matrix:
[[   0 3124    0    0    0    0    0    0    0    0    0    0]
[   0 3126    0    0    0    0    0    0    0    0    0    0]
[   0 3289    0    0    0    0    0    0    0    0    0    0]
[   0 3209    0    0    0    0    0    0    0    0    0    0]
[   0 3038    0    0    0    0    0    0    0    0    0    0]
[   0 3009    0    0    0    0    0    0    0    0    0    0]
[   0 3026    0    0    0    0    0    0    0    0    0    0]
[   0 3004    0    0    0    0    0    0    0    0    0    0]
[   0 3004    0    0    0    0    0    0    0    0    0    0]
[   0 2976    0    0    0    0    0    0    0    0    0    0]
[   0 3078    0    0    0    0    0    0    0    0    0    0]
[   0 3040    0    0    0    0    0    0    0    0    0    0]]
INFO:tensorflow:Training accuracy = 8.47% (N=36923)
INFO:tensorflow:set_size=4445
INFO:tensorflow:Confusion Matrix:
[[  0 371   0   0   0   0   0   0   0   0   0   0]
[  0 371   0   0   0   0   0   0   0   0   0   0]
[  0 397   0   0   0   0   0   0   0   0   0   0]
[  0 406   0   0   0   0   0   0   0   0   0   0]
[  0 350   0   0   0   0   0   0   0   0   0   0]
[  0 377   0   0   0   0   0   0   0   0   0   0]
[  0 352   0   0   0   0   0   0   0   0   0   0]
[  0 363   0   0   0   0   0   0   0   0   0   0]
[  0 363   0   0   0   0   0   0   0   0   0   0]
[  0 373   0   0   0   0   0   0   0   0   0   0]
[  0 350   0   0   0   0   0   0   0   0   0   0]
[  0 372   0   0   0   0   0   0   0   0   0   0]]
INFO:tensorflow:Validation accuracy = 8.35% (N=4445)
INFO:tensorflow:set_size=4890
INFO:tensorflow:Confusion Matrix:
[[  0 408   0   0   0   0   0   0   0   0   0   0]
[  0 408   0   0   0   0   0   0   0   0   0   0]
[  0 419   0   0   0   0   0   0   0   0   0   0]
[  0 405   0   0   0   0   0   0   0   0   0   0]
[  0 425   0   0   0   0   0   0   0   0   0   0]
[  0 406   0   0   0   0   0   0   0   0   0   0]
[  0 412   0   0   0   0   0   0   0   0   0   0]
[  0 396   0   0   0   0   0   0   0   0   0   0]
[  0 396   0   0   0   0   0   0   0   0   0   0]
[  0 402   0   0   0   0   0   0   0   0   0   0]
[  0 411   0   0   0   0   0   0   0   0   0   0]
[  0 402   0   0   0   0   0   0   0   0   0   0]]
INFO:tensorflow:Test accuracy = 8.34% (N=4890)
Why?
When I changed the set of hyperparameters (window_size, window_stride, etc.), it still did not work. However, there is a right result when quantizing dnn model.

run fold_batchnorm.py,
after use "-bnfused" checkpoint to run quant_test.py
check "-act_max []" argument in quant_test.py

run fold_batchnorm.py,
after use "-bnfused" checkpoint to run quant_test.py
check "-act_max []" argument in quant_test.py
Don't change any hyper-parameters, training and testing parameters must be same

Thank you a lot! I got it!

I used the fold_batchnorm.py, and after creating the "-bnfused" checkpoint,I ran quant_test.py with it. The accuracy did not change comparing to the time I used the simple checkpoint.(For DNN the accuracy for both was about 84%).Do you know if  this is supposed to be like that? or is this wrong?

I used the fold_batchnorm.py, and after creating the "-bnfused" checkpoint,I ran quant_test.py with it. The accuracy did not change comparing to the time I used the simple checkpoint.(For DNN the accuracy for both was about 84%).Do you know if this is supposed to be like that? or is this wrong?

There are not batchnorm layers in DNN model, so it's not meaningful to do that with DNN model.


Disable recursive selection of child nodes

How to make recursive selection an option? Is that possible? I can't find the code responsible for that...
Thanks in advance!

+1

There's no explicit option for changing the baked in selection strategy. If you want simple (i.e. non-propagating) selection the easiest thing is to swap out the ivh-treeview-checkbox directive in your template with a vanilla checkbox + ngModel.

I found an easy solution to make that an option and created a PR #125

Is there a compelling reason not to use the strategy I mentioned above? Disabling your recursive selection option basically turns ivhTreeview checkboxes into regular ones (if I'm reading the changes correctly) but with more overhead and at the cost of extra complexity to the directive as a whole.

I needed recursive selection to be an option the user could turn on and off easily. As I'm using angular material, I'm calling the 'select' method from a custom directive with an option object with 'recursiveSelection' either true or false.
I don't know if that's a compelling reason though. Just pretty straightforward.

Would it be possible to call ivhTreeviewMgr.select when recursive selection is desired, and if not simply set the node's selected property in your custom directive? You can grab that property name from ivhTreeviewOptions to be fully generic, as well as the indeterminate property if you need it.

While I agree with the OP @Benew that this would be a good feature, for completeness here are code samples for how to accomplish this via @jtrussell's suggestion.

Note that if you are not using the default isSelected property, you will need to bind to your particular property.


DOC: Clarify how date_parser is called (GH9376)

closes #9376

I can buy this. @jorisvandenbossche

Yep, looking good. Although, in reality it is still a little bit more complex, as it are actually three steps that are tried, the first and last the onces you mentioned (vectorized with the columns as input, and scalar with rows), but also vectorized on the concatenated columns into one column. Only, also adding that will make it maybe too complex?
@cmeeren Do you also want to add a similar note to the tutorial docs? Somewhere here: http://pandas.pydata.org/pandas-docs/stable/io.html#date-parsing-functions That section could also use a real example I think (of a custom defined function, not of one imported from the io.date_converters module)

@jorisvandenbossche Just to be clear concerning the second try, where you say it concatenates the columns into one column: If you use two columns, one with values [2013, 2013, 2013] and one with values [1, 2, 3], will the second try pass the single argument [2013, 2013, 2013, 1, 2, 3]?

I have now mentioned the second way of calling date_parser (assuming my guess in the previous comment was correct) and added a description to the tutorial docs. I have not touched the example, since I have little experience with the Sphinx-IPython combo.

@cmeeren actually, I think you should mention pd.to_datetime() first. If you want to specify a format, read_csv does not currently have this implemented (it can infer the format however if infer_datetime_format=True, but is False by default).
So it is MUCH more performant to use pd.to_datetime() AFTER parsing if you have a single column, but it needs a format specification. IOW, you should NOT use date_parser if this is the case. (In reality read_csv should just do this, but it is an open issue).

@jreback are you suggesting that I mention pd.to_datetime() as a possible function to use for date_parser?

no! this is in lieu of using date_parser entirely

I don't really understand the role of pd.to_datetime() in this scenario. Why do you suggest that I mention it in the documentation for date_parser? Could you give an example of how pd.to_datetime() might be used instead of date_parser?

The concatenation is like this in your example: ["2013 1", "2013 2", "2013 3"].
@jreback In many cases you are right about to_datetime, and I also think read_csv should take a date_format argument (#2586)

@jreback finishing my comment: indeed, in many case to_datetime will be better, but I think you specifically want to use date_parser when you have multiple columns that have to be combined.
BTW, you can use pd.to_datetime as a function for date_parser, no? (if you still want to do it with a one-liner)

so the simple heuristic is this:

if you have multiple columns that need parsing, use parse_dates=[[....]].
try to infer the format read_csv(..., infer_datetime_format=True)
if you have a format, the use date_parser=lambda x: pd.to_datetime(x, format=.....)
if you have a really non-standard format, finally use date_parser=.....

so a naked date_parser is ALWAYS the last resort.

@cmeeren so what I think we should do is update the doc-string a bit (what you have is prob good). then add a section to the docs in the date parsing section giving the relative list as above.

@jreback yes, that is a nice overview of steps to follow!
The full docs on the date parsing can use an overhaul. It is now scattered a bit:

http://pandas.pydata.org/pandas-docs/stable/io.html#specifying-date-columns
http://pandas.pydata.org/pandas-docs/stable/io.html#date-parsing-functions
http://pandas.pydata.org/pandas-docs/stable/io.html#inferring-datetime-format
http://pandas.pydata.org/pandas-docs/stable/io.html#international-date-formats

where the first is not adjacent to the other three. I would have just one section with some subsections.
@cmeeren If you want, you can certainly try to tackle this! Otherwise, we just merge this as is (as it is correct information) and open a new issue for it.

First I'll correct things based on the recent feedback here. The information I added as it currently stands is not correct (specifically regarding the second "concatenation" call).

I added the list provided by @jreback. Please check the PR diff now and see if the information is good.

This looks good for me!
Apart from the one small comment, can you also squash your commits into one?

I addressed the comment and I think I managed to squash the commits now.

Thanks a lot!


[Validator] Deprecate roads

Example:
highway=road
http://www.openstreetmap.org/way/236039333
cc @maning @planemad

done here https://github.com/osmlab/osmlint/pull/153!


ESP32-C3 SPI Slow transfer

Hi,
I'm using the est-at (branch release/<IP_ADDRESS> | hash: f26b306d58d4ec31261e39680fc3bafef997d292) on an ESP32-C3 (custom board).
I'm connected to an iPad on a local network (with another esp32 as softAP).
I followed the "How to Improve ESP-AT Throughput Performance" (https://docs.espressif.com/projects/esp-at/en/latest/esp32c3/Compile_and_Develop/How_to_optimize_throughput.html#how-to-improve-esp-at-throughput-performance)
I connect to the ipad with:

AT+CIPSTART="TCP,"",

Setup:

AT+CIPSENDLCFG=9216,2920
AT+CIPSENDL=1032288

Then I send 3kB packets over SPI, and every ~3 packets I wait for "+CIPSENDL" to be sure there were no data loss.
What I am experiencing:
The first 70kB are quick enough, but then it gets slower and slower, sometimes the +CIPSENDL takes a few seconds (sometimes more than 5). It takes around 30 to 40 seconds to send 1MB.
I attached the logs with the at commands I send with timestamps, and the sdkconfig I use.
EDIT: I also have a wireshark dump if needed but I can't upload it in here.
Is there anything I'm missing ?
Thanks
YAT-Log-20220825-160703.log
sdkconfig.txt

The RF shield was faulty on the device, looks OK on another one.

@AlexAri1 Could you please take a look at this one: https://docs.espressif.com/projects/esp-at/en/latest/esp32c3/Compile_and_Develop/How_to_implement_SPI_AT.html

one more possible useful doc here: https://docs.espressif.com/projects/esp-at/en/latest/esp32/Compile_and_Develop/How_to_optimize_throughput.html
if this is still not that effective, maybe @ESP-Coco could give more suggestion.

@ESP-Coco could you please take a look.

@AlexAri1 The rate of 0.8Mbps is too low, we can test rates up to 10Mbps (https://docs.espressif.com/projects/esp-at/en/latest/esp32c3/Compile_and_Develop/How_to_implement_SPI_AT.html#reference-results). This rate requires you to make sure that you perform as follows:

Using  Passthrough Mode
Discard the UART to type commands, and automatically input the command directly into the code, because UART is very slow, which will slow down the SPI transmission rate
Configure system, LWIP, Wi-Fi parameters
Test in a shielded box, or find a space with low WiFi interference

@AlexAri1  I think I have found the reason for your slow transmission speed, and the stuck problem needs to be solved. The design strategy of SPI AT is that the slave decides whether to receive or send, and the master does not have the right to transmit actively. I think the reason for the stuck is that this strategy is not strictly followed.
We provide a reference SPI master example using  ESP32-C3 , and I suggest you modify this example to test the rate

Hi, @AlexAri1 , your understanding is correct.
But your screenshot is too fuzzy, could you please send the logic analyzer to me as an attachment?

Hi, @AlexAri1 , The logic analyzer you sent is completely normal , I suspect there is a problem with the command AT +CIPSENDL, I am on vacation now, I will repeat this problem after the end of the vacation. Maybe you also can try sending data in passthrough mode instead of using this command

Hi @AlexAri1  I guess this is because the at_spi_slave_task has not been executed. The priority of at_spi_slave_task is 10, and the priority of LWIP task and WiFi task is much higher than this. The more TCP data, the later the at_spi_slave_task will be executed


[Bugfix]: Error Mapping for Bluensap & Card Number for Airwallex

Type of Change

[X] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates

Description

Bluesnap: Error Mapping in case of Authorization failed is now handled.
Airwallex: Card number with spaces need to be handled and formatted before sending it to the connector.
Additional Changes

[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

Bluesnap: earlier the mapping was not their which gave a Internal Server Error: 500 .
Airwallex: Earlier if card number was of format XXXX XXXX XXXX XXXX it throws an error.
How did you test it?

Ran unit tests for both Bluesnap and Airwallex after implementing changes.

Checklist

[X] I formatted the code cargo +nightly fmt --all
[X] I addressed lints thrown by cargo clippy
[X] I reviewed submitted code
[X] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Other than that LGTM


test - Cypress - Fix Flaky tests

Description
Fixed below flaky tests

Image2_Spec.ts

Type of change

Flaky test fix

How Has This Been Tested?

Cypress test runs

Checklist:
QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ci-test-limit

/ci-test-limit runId=6107920446


subarray is not re-defined in index.d.ts

The subarray function should return a Buffer, but currently the types are inheriting the definition from Uint8Array which has the function returning a Uint8Array.
I believe PR #261 fixed this issue at runtime, but the types were never updated.

ill just note<EMAIL_ADDRESS>(used by create-react-app@4 with webpack@4) returns a UInt8Array for subarray


feat: add autoware auto msgs

Related Issue
#1
Related Link
This PR depends on

#4

Description
Add autoware auto msgs from https://github.com/tier4/autoware_auto_msgs
How to review
Check the following item

Discussion
this can refered as outside of this repository and set dependency instead.

close for using build depends instead


DBZ-874 Executing Travis builds in parallel

Hey @jpechane, what's the status of this one? Is it good to go from your POV? I believe you mentioned some more work being required, but I could mix it up with another PR. Thanks!

@gunnarmorling This is already done, I've triggered a new build to verify it works with the build stabilization PRs introduced last week and if yes then it can be merged.

@gunnarmorling And we are good to go...

Excellent; thanks, @jpechane!


Add --target-path parameter, targetPath() and path() functions  to dsc

PR Summary
To enable offline configuration management, add --target-path parameter and targetPath() function (takes no arguments) to DSC.  The provided path must exist.  Supported resources would need to accept the path to use rather than the current running OS.
Also added path() function that takes any number of strings and concatenates it with the OS directory separator char.
PR Context
Fix https://github.com/PowerShell/DSC/issues/534

Would it be helpful to have some sort of info logging (maybe in the parser?) in the case of --target-path being provided without TargetPath() or is it obvious that --target-path would be ignored?

Would it be helpful to have some sort of info logging (maybe in the parser?) in the case of --target-path being provided without TargetPath() or is it obvious that --target-path would be ignored?

That could be useful as a warning message if the user provided --target-path but the configuration doesn't use it.  The challenge is that expressions are parsed at runtime, so the warning would only happen at the end after configuration was run.  I think this is ok.

Decided to rename to systemRoot instead of targetPath as it more accurately describes what it does


SystemConsoleNull should consider the case where System.console() == null

https://errorprone.info/bugpattern/SystemConsoleNull says:

System.console() no longer returns null in JDK 22 and newer versions

However, it may still return null, both from the specification and actual implementation.
So I propose to:
(a) rephrase the above sentence to

System.console() returns null in fewer cases in JDK 22 and newer versions

(b) update the code example to handle the case where System.console() == null:
  @SuppressWarnings("SystemConsoleNull") // https://errorprone.info/bugpattern/SystemConsoleNull
  private static boolean systemConsoleIsTerminal() {
    Console systemConsole = System.console();
    if (Runtime.version().feature() < 22) {
      return systemConsole != null;
    }
    try {
      return (systemConsole != null) && (Boolean) Console.class.getMethod("isTerminal").invoke(systemConsole);
    } catch (ReflectiveOperationException e) {
      throw new LinkageError(e.getMessage(), e);
    }
  }

Thanks, 'no longer returns null' could have been something like 'no longer returns null when the standard streams are redirected or connected to a virtual terminal'
Can the implementation return null, though? I'm not seeing how the implementation could return null in https://github.com/openjdk/jdk/blob/20cb6e786fbf6d924c509e28d6fded86d61a5f84/src/java.base/share/classes/java/io/Console.java#L431-L435

At line 431, c can be null and istty can be false, which causes c to still be null at line 435. Or am I missing something?

Huh, thanks. I'd misread the code, too. Indeed, I can produce a null return:
$ cat SystemConsole.java
public class SystemConsole {
  public static void main(String[] args) {
    System.err.println(System.console());
  }
}

$ javac SystemConsole.java && ~/jdk-22-ea+19/bin/java -Djdk.console=nosuchthing SystemConsole > /dev/null
null

I'm hoping that that's at least possible only in the case that the user sets jdk.console (as above), but I wouldn't want to make further assumptions :)


Create custom 404 page

As a user I expect to see a 404 page with the same sort of look and feel.
Possibly with something like "Can't find what you're looking for, here are the resources to help make it"

https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-custom-404-page-for-your-github-pages-site


Fix TQDM Progress bar in TF 2.2.0

Follow-up on #1365
The samples mode is not available anymore. It was causing some issues. It makes the code quite complex to support both, in the future, a refactor to remove all other pieces of code supporting "samples" mode should be removed.
I also made the tests more complex to be sure that it works with the right numbers.
@bjtho08
@lminer
Please take a look, I used your inputs about the self.params and the validation metrics and now it should work out. try it locally with
pip install git+https://github.com/gabrieldemarmiesse/addons.git@fix_progress_bar

and report if it works for you.
Closes #1495

Thanks!


Switch case doesn't accept integer values and when forced to use a string, it restores the integer value after a save

Describe the Bug with repro steps

Create a logic app
Add an "Initialize variable". Set its type "String". Call it "test" as an example.
After it, add another step "Set variable". Choose the "test" variable and add a value (as an example of a numerical value): 2
Add a Switch (control) action. Set its input to the "test" variable: @{variables('test')}.
Add a "Case" branch and set its equals value to: 2
Add anything inside the first branch and anything in the default branch just to test where the execution will go. I have initialized and set another variable in the beginning called "hello" and I changed its value in the first branch of the switch and in the default branch of the Switch
Save the logic app and run the test

When you run the test you'll get an error inside the Switch where the "set variable" I have created inside the 2 branches will turn to red with the following error: The execution of template action 'Set_variable_1' failed: an unexpected exception encountered when evaluating branching condition..
When you re-run these steps but you change in the step number 4 the variable to a function to force the input as a string like this @{string(variables('test'))} the error will not disappear because the issue is with the case values that considers the input provided to them as an integer in this example.
The error was no longer present when I changed the Case value from 2 to "2". So, I think the logic app cannot compare a string with an integer and I was totally fine with that but once I save the workflow, the case value changes from "2" to 2 which is not practical for someone who has multiple switch cases where he wants to edit something in the workflow he have to make sure to add the double quotes that were deleted. In the old UI this was never an issue because the 2 value was never generating an error. But when I changed to the new UI, when I changed something not related with the switch case, I started getting this error and I was confused because I didn't touch the switch case. And after all this investigation I discovered that the issue is with the case conditions that consider any integer value inside them as an integer not as a dynamic value "that is a string if the switch value is a string and that is an integer value if the switch value is an integer".
I'm not asking for too much like to make the case comparison to use a dynamic value (this solution is the best solution). But I'm just asking to at least correct the "Case" condition to avoid deleting the double quotes since I don't want to add them every time I edit the logic app
Thank you for all your hard work.
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chromium
Additional context
No response

Closing this with my last PR, we expect this to be deployed ETA 4/19


[improve] job on yarn state patch.

What changes were proposed in this pull request
Issue Number: close #xxx

Brief change log
job on yarn state patch.upate log jobmanager url
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (no)

There are some checkstyle issues here. Can you fix it? Thanks


[CLNP-5921] Sync thread message with groupchannel message update

CLNP-5921
Changelog

Fixed an issue where editing a text parent message in a channel did not update the corresponding parent message in the Thread area in real-time.

This issue is not reproducible in my local environment. I left a comment for the detail in the ticket.

I changed changelog.


nitdoc: Use wikilinks on README files

This PR introduce the use of wikilinks in README files.
It's mainly a request for comments on what you want, what you need and what you like from Nitdoc and README writting.
0f6ff78 gives an example of README file written using wikilinks. The processed result by nitdoc is visible here.
Supported commands for now:

[[doc:MEntity]]: include the documentation article or an MEntity
[[list:MEntity]]: list classes or methods from than MEntity

Old API pages still available, there are prefixed with api_.
Demos from Jenkins::CI-nitdoc:

Standard library
Nit compilers and tools

Some question still need to be answered:

What to do with old API page (http://gresil.org/jenkins/job/CI-nitdoc/ws/doc/stdlib/api_group_github.html)
What comment to display in API page (http://gresil.org/jenkins/job/CI-nitdoc/ws/doc/stdlib/api_group_github.html)
What commands should be supported by wikilinks directive?

This might be me, but I'm a bit surprised by the Event::list in the Github API README, the events listed are those from SDL, maybe there was some kind of dependancy at one point (or maybe it's a bug in wikilinks ?), however it seems a bit strange to my eyes right now.
Other than that, I like the way information is presented, it is simple, clear, and most of the useful information is conveyed in a simple README, Nitdoc does a really good job at presenting all this, kudos to you @Morriar !
On the project view then, is it still necessary to print information ? If we take a look at the Github group, the readme is not rendered using wikilinks, and the Markdown is printed as-is, which give little to no information on the project itself.
Should we print a short version instead ? The github.nit module header maybe ?
For your questions now:

What to do with old API page : The API page is still useful I think, but as a catalog of the classes and services available in them. Some information on the structure of the class should be displayed imho.
The group page could be useful for newcomers as it gives a quick oversight of the library, but keeps it to a strict minimum for a quick grasp of the how to use part.
I see the API page as someplace to go into the details of the group, eventually in order to extend it, which requires a bit more info on the internals.
Maybe we should add a link from the group page to the API to access it ?
What commands should be supported by wikilinks directive? I'm not sure I know what my options are here, can you elaborate on this point so I can give you an answer which will, hopefully, not be completely off-topic ?

On the PR, lots of code, but aside from the few typos I noticed, :shipit: !

Reroll with @R4PaSs remarks

@R4PaSs

I fixed the name conflict in the readme file.

This makes me think of another question:
Nitdoc displays warning when a MEntity name is not found:
lib/github/README.md:5,1: cannot find article for `LOL` (readme-warning)
	[[doc: LOL]]
	^

Same thing for the conflicts (like with [[doc: events]]):
lib/github/README.md:69,1: conflicting article for `events` (choices : sdl::events, api::events, api#Issue#events) (readme-warning)
	[[list: events]]
	^

The problem with conflicts it's they occur really often with classes. Example with [[doc: GithubAPI]] do you mean the intro in api::GithubAPI or one of the redef?
For now, nitdoc looks at all MEntities with the name GithubAPI and returns 1 MClass and 2 MClassdefs (one intro and one redef). It selects the first result, the MClass (because of the implementation right now) adds it to the page then displays a warning about the two other results
Users can already desambiguise with the namespace notation: [[doc: cache::GithubAPI]] to turn off the warning.
So I'm thinking to relax this rule by looking at the MClass first and let the user desambiguise with the namespace without displaying a warning.

Other problem that I see is when displaying the README in github.
Wikilinks that include things like [[list:]] or [[doc:]] are not that helpfull when reading plain markdown.

on the index, the readme seems to be unprocessed http://gresil.org/jenkins/job/CI-nitdoc/ws/doc/stdlib/index.html#github.definition

Looks very great. I plan to try to use it once it is merged. +1
For the various questions, I think that you should just chose something I you did, then discuss and solve each independent issue with future PRs. You can create a TODO issue with check boxes to lise them (because they will be hard to track back in this PR)

Reroll:

no more blank page for empty readme (use the API page instead)
no more unprocessed wikilinks in Nitdoc API pages (replaced with synopsis from README)

this implies that the first line of a README never contains a wikilinks that include something

added a link to swtich between API and README
produce warnings for empty README

There stills a lot of work but I think that this PR is ready to be merged (if tests are ok). The demo should be updated soon.

This one conflict with the soon merged #1446, so I assume that I should wait before merging this one.

Tried to resolve merge conflicts myself. It didn't work, so I let you hold the scalpel.

Reroll rebased on master

$ git merge origin/master
$ make
$ make docs
[...]
Runtime error: Uninitialized attribute _markdown_processor (doc/html_templates/html_templates.nit:582)

cf http://gresil.org/jenkins/job/nit_test_tools/737/consoleFull

@privat rerolled without the crash on mardown_processor


Create apt package

On second thoughts, the currently available options are enough.

@Loki-Afro calm down and create a PR if you think it should be there.
It is all fine and dandy from my side without it.


Naming things

Currently:

Base class for configurable objects: Configurable
Descriptor class for a configurable member of a configurable object: ConfigItem

I don't really like the ConfigItem. Any better ideas?

Parameter?


Responsive issue related to join us button

Describe the bug
The Join us CTA button on mobile needs to take the width of its row just like other buttons on mobile
How to Reproduce
On mobile device scroll down to Join our slack workplace section

Screenshot

Expected behavior
the CTA button should look like the below

Screenshot

Will like to have a review on this if to jump on it @mcturco @alequetzalli @magicmatatjahu @derberg

@Nelson-Chinedu Hi! If you want, you can contribute :)

Sure, will make the fix then.


Awesome project!

Just wanted to swing by and congratulate on the project! It works very well in my testing :)
I added it to our awesome-hcloud list: https://github.com/hetznercloud/awesome-hcloud/commit/9618cbb4d0452d1d96bce692823965dcbdc514ac

Thank you very much! It's always nice to get positive feedback.


[BUG] Excessive rolebindings created for clusters and projects

Epic: https://github.com/rancher/rancher/issues/36702
An admin user creating a cluster with no other members adds 22 rolebindings to the local cluster (after cluster is finished creating and fleet is deployed).
$ kubectl get rolebindings -A -o wide --sort-by=.metadata.creationTimestamp | grep -v '[0-9]d[0-9]h' | grep -v '[0-9]\{2\}m'
NAMESPACE                                NAME                                                        ROLE                                                  AGE     USERS                                                   GROUPS                                                          SERVICEACCOUNTS
fleet-default                            r-cluster-k-view-p-hmsxc-creator-project-owner-k25j6uqil3   Role/r-cluster-k-view                                 4m23s   user-n2wq4
p-tbj8t                                  creator-project-owner-project-owner                         Role/project-owner                                    4m23s   user-n2wq4
p-tbj8t                                  creator-project-owner-admin                                 Role/admin                                            4m23s   user-n2wq4
fleet-default                            crt-k-creator-cluster-owner-k25j6uqil3                      Role/crt-k-cluster-owner                              4m23s   user-n2wq4
fleet-default                            r-cluster-k-view-p-tbj8t-creator-project-owner-k25j6uqil3   Role/r-cluster-k-view                                 4m23s   user-n2wq4
p-tbj8t                                  creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    4m23s   user-n2wq4
c-m-x88nvnk8                             rb-p7kbdqdkob                                               Role/p-tbj8t-projectowner                             4m23s   user-n2wq4
c-m-x88nvnk8                             rb-gzbfn6gro3                                               Role/p-hmsxc-projectowner                             4m23s   user-n2wq4
c-m-x88nvnk8                             p-tbj8t-creator-project-owner-project-owner                 Role/project-owner                                    4m23s   user-n2wq4
c-m-x88nvnk8                             p-hmsxc-creator-project-owner-project-owner                 Role/project-owner                                    4m23s   user-n2wq4
c-m-x88nvnk8                             creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    4m23s   user-n2wq4
p-hmsxc                                  creator-project-owner-admin                                 Role/admin                                            4m23s   user-n2wq4
p-hmsxc                                  creator-project-owner-project-owner                         Role/project-owner                                    4m23s   user-n2wq4
p-hmsxc                                  creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    4m23s   user-n2wq4
p-hmsxc                                  u-exuwil52h3-admin-cluster-owner                            Role/cluster-owner                                    3m31s   u-exuwil52h3
cattle-global-data                       grb-4nmxv-global-catalog-binding                            Role/user-global-catalog                              3m31s   u-exuwil52h3
c-m-x88nvnk8                             u-exuwil52h3-admin-cluster-owner                            Role/cluster-owner                                    3m31s   u-exuwil52h3
p-tbj8t                                  u-exuwil52h3-admin-cluster-owner                            Role/cluster-owner                                    3m31s   u-exuwil52h3
fleet-default                            crt-k-c-m-x88nvnk8-fleet-default-owner-2q6s2jdapd           Role/crt-k-cluster-owner                              3m1s    u-z2rgcnytp5
c-m-x88nvnk8                             c-m-x88nvnk8-fleet-default-owner-cluster-owner              Role/cluster-owner                                    3m1s    u-z2rgcnytp5
p-tbj8t                                  c-m-x88nvnk8-fleet-default-owner-cluster-owner              Role/cluster-owner                                    3m1s    u-z2rgcnytp5
p-hmsxc                                  c-m-x88nvnk8-fleet-default-owner-cluster-owner              Role/cluster-owner                                    3m1s    u-z2rgcnytp5

An admin user creating a cluster with one other cluster owner adds 27.
$ kubectl get rolebindings -A -o wide --sort-by=.metadata.creationTimestamp | grep -v '[0-9]d[0-9]h' | grep -v '[0-9]\{2\}m'
NAMESPACE                                NAME                                                        ROLE                                                  AGE     USERS                                                   GROUPS                                                          SERVICEACCOUNTS
p-698db                                  creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    2m35s   user-n2wq4
fleet-default                            r-cluster-k-view-p-698db-creator-project-owner-k25j6uqil3   Role/r-cluster-k-view                                 2m35s   user-n2wq4
p-698db                                  creator-project-owner-project-owner                         Role/project-owner                                    2m35s   user-n2wq4
p-llmsr                                  creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    2m35s   user-n2wq4
fleet-default                            crt-k-creator-cluster-owner-k25j6uqil3                      Role/crt-k-cluster-owner                              2m35s   user-n2wq4
p-llmsr                                  creator-project-owner-admin                                 Role/admin                                            2m35s   user-n2wq4
fleet-default                            r-cluster-k-view-p-llmsr-creator-project-owner-k25j6uqil3   Role/r-cluster-k-view                                 2m35s   user-n2wq4
c-m-r6rccwxt                             rb-nmqpt4hbvt                                               Role/p-698db-projectowner                             2m35s   user-n2wq4
c-m-r6rccwxt                             p-llmsr-creator-project-owner-project-owner                 Role/project-owner                                    2m35s   user-n2wq4
c-m-r6rccwxt                             p-698db-creator-project-owner-project-owner                 Role/project-owner                                    2m35s   user-n2wq4
c-m-r6rccwxt                             creator-cluster-owner-cluster-owner                         Role/cluster-owner                                    2m35s   user-n2wq4
p-698db                                  creator-project-owner-admin                                 Role/admin                                            2m35s   user-n2wq4
c-m-r6rccwxt                             rb-qgoa6y6baw                                               Role/p-llmsr-projectowner                             2m35s   user-n2wq4
p-llmsr                                  creator-project-owner-project-owner                         Role/project-owner                                    2m35s   user-n2wq4
fleet-default                            crt-k-crtb-58448-jxfpj7w4a5                                 Role/crt-k-cluster-owner                              2m34s   u-pmxgv
p-llmsr                                  crtb-58448-cluster-owner                                    Role/cluster-owner                                    2m34s   u-pmxgv
p-698db                                  crtb-58448-cluster-owner                                    Role/cluster-owner                                    2m34s   u-pmxgv
c-m-r6rccwxt                             crtb-58448-cluster-owner                                    Role/cluster-owner                                    2m34s   u-pmxgv
cattle-global-data                       grb-zqwgp-global-catalog-binding                            Role/user-global-catalog                              113s    u-jsmcljd4ff
c-m-r6rccwxt                             u-jsmcljd4ff-admin-cluster-owner                            Role/cluster-owner                                    113s    u-jsmcljd4ff
p-698db                                  u-jsmcljd4ff-admin-cluster-owner                            Role/cluster-owner                                    113s    u-jsmcljd4ff
fleet-default                            crt-k-u-jsmcljd4ff-admin-3rz7e2ggbk                         Role/crt-k-cluster-owner                              113s    u-jsmcljd4ff
p-llmsr                                  u-jsmcljd4ff-admin-cluster-owner                            Role/cluster-owner                                    113s    u-jsmcljd4ff
c-m-r6rccwxt                             c-m-r6rccwxt-fleet-default-owner-cluster-owner              Role/cluster-owner                                    67s     u-z2rgcnytp5
fleet-default                            crt-k-c-m-r6rccwxt-fleet-default-owner-2q6s2jdapd           Role/crt-k-cluster-owner                              67s     u-z2rgcnytp5
p-llmsr                                  c-m-r6rccwxt-fleet-default-owner-cluster-owner              Role/cluster-owner                                    67s     u-z2rgcnytp5
p-698db                                  c-m-r6rccwxt-fleet-default-owner-cluster-owner              Role/cluster-owner                                    67s     u-z2rgcnytp5

Can we consolidate these rolebindings, especially the ones for the admin user, to bring it down to a more reasonable range?

One area that might be helpful here: we do some default bindings that we give out which can be superflous on cluster create. A good example of this is the owner bindings - the admin user in the first example has * verbs on * resources in * api groups in both the local cluster and the remote cluster. Those owner bindings are not given any effective permissions in the first example (for both remote and local cluster), despite making up ~17 bindings.
I think a possible short term solution would be to give users the option when creating clusters/projects to not have these default owner bindings created. This would help users who are admins (or users who are using an admin user to run automation creating these items) to avoid having excessive bindings.

Some connection to #39216 for @rmweir's attention

Research required.

This actually describes the main motivation behind https://github.com/rancher/rancher/issues/46077 fairly well. Closing in favor of that one.


update gisce/react-formiga-components to v1.1.0-alpha.1

Automated changes by create-pull-request GitHub action

:tada: This PR is included in version 2.0.0-alpha.64 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Console Web has degraded performance

In efaf75b, Console Web (https://console.inu-cafeteria.app) experienced degraded performance:

HTTP code: 200
Response time: 9363 ms

Resolved: Console Web performance has improved in 642d784.


Clean legacy code after adding tests for new implementation.

There is some legacy code in the repo that is not executed anymore. Currently is still there until we create tests for all the new implementation but we should clean it afterward.

Fixed in PR #96


tsugumi fail? (Vbox version: 6.0.4)

As seen in the above image, it appears the monitoring driver is being restored after it says it has successfully unloaded. Not sure if this is a bug.

However running the loader it appears to be successful:

TDL uses old vboxdrv driver with exploit on board. Because you have virtualbox installed current vboxdrv need to be unloaded before, so TDL backups it, unloads, load exploitable old driver, exploit it, unloads and restores current vboxdrv from backup. Next loader restarts it (supRestartVBoxDrv).


DCOS-50727 & DCOS-50728: Add master node region as data source & use it on services table

Testing

test services page (ideally on multi region clusters) and see if the "(Local)" addition is visible
see if there are the same amount or less requests to master_info going out

Trade-offs

Dependencies

Screenshots

Before
After

I played around with this a bit to try to make the masterRequest$ stream shareable - added a commit to a different branch (https://github.com/dcos/dcos-ui/commit/8b5680ec72e3661eafee9e58ffc0d2e20bd441e3) so you can cherry-pick or take parts of or discard entirely 😄 Basically I moved the actual request observable to a constant, so it's not creating a new request observable each time getMasterRequestStream is called. I also removed wait$ from the subscribe method as it was unclear what the purpose was (the entire subscribe setup is a bit convoluted IMO) and it was causing duplicate requests to be make every polling interval.
Results on services page in network tab when filtering for get_master:
Before: https://cl.ly/bc004d020085
After: https://cl.ly/b4650a646660

I saw a slight increase in polling time for get_master over time, but not a significant increase as @natmegs  described.

Thank you for the feedback @natmegs and @mperrotti I will take a look at this strange polling behaviour

I didn't realize when I tested this just now that I had fixtures turned on. Without fixtures, I see a different error relating to performing setState on an undefined state, but if I moved all this stuff https://github.com/dcos/dcos-ui/blob/b4edd7dde1dd126a8754552a88a8d17eb4906e71/src/js/pages/system/OverviewDetailTab.js#L86-L123 into componentWillMount instead of constructor it fixed it (unfortunately does not fix the integration test though).

Thank you very much for investigating @natmegs. I think we got now almost every place that could have gotten wrong 👍

@DanielMSchmidt  Testing the latest against SOAK and I dont see (Local) next to the region like I do on Soak UI.
Localhost PR branch:

Soak:

Thank you for the feedback @TattdCodeMonkey - Seems like I forgot to test the main use-case after so much whack a moling :D

Legit fails?

:tada: This PR is included in version 2.80.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Parallel run sometimes causes the driver to open already opened device

When user run the cucumber tests in parallel, sometimes driver tries to open the device that already used by another test thread, so the test is ignored with next output:
Unable to create driver instance in 1st attempt with retry timeout of 60 seconds. You can check/set value of 'driver.init.retry.timeout' appropriately to set retry timeout on driver initialization failure.Unable to Create Driver Instance Failed to execute command handset open: Cannot open device 9A90117A5FF7AEB655944A1D7FA8C70F3C2C81BD for user<EMAIL_ADDRESS>device is in use.
Steps to reproduce:

Create feature file with several test scenarios
Create xml suite which will run those scenarios in 2 tests, for one test set the "deviceName" parameter
Run the xml suite

open issue in qafhttps://github.com/qmetry/qaf/issues/59

I had a similar issue and I reported it to QAF because the above issue seems to be closed.
They replied that it maybe an issue from Perfecto Server end as it is delivering the same devices to two different threads.
Please find response to this issue from QAF team: https://github.com/qmetry/qaf/issues/97
Can you please let me know what can we do about this?
This can be solved in two ways:

This can be solved from the server end.
We can handle it by customizing QAF jar in Quantum framework.

Please let me know what can be done here.
Thank You for your help in advance.

I was facing this issue as driver.pluginType was defined in eclipse.
To execute tests in parallel, the eclipse plugin configurations needs to be disabled in application.properties file.
You can close this issue from my end.


skip validation when using model factories

Hey.
If we use the validable trait along with model factory that simply is going to break very quickly. An example to that is that in my system I'm creating a user without the user "knowledge" and I do not persist store an email for him. When the user will manually register he will need to provide the email. The issue is that in my model factory I'm randomly creating users that may or may not have email addresses.
When I'm doing it in my code I'm simply calling the skipValidation method, however I'm not sure how I can do that with model factories. Basically it means that some users are not persisted to my DB when trying to seed it.

Just wanted to say that I got a workaround:
factory('My\Model')->make($overrides)->each(function($m) {
    $model->skipValidation->save();
});

@kfirba Depending on your needs, you may want to do what you did above, or use the builtin method for disabling EVENT HANDLERS with simple $this->withoutEvents() http://laravel.com/docs/5.1/testing#mocking


Docs fix shell render added missing space to code-block::shell

What this PR does / why we need it:
Docs fix. Correct shell render added missing space code-block::shell -> code-block:: shell
Code example does not show otherwise.

Thanks for spotting this 😄 I've re-opened this PR against master in #1792. Sorry for the delay in responding here.


shticker-book-unwritten: fix broken cargoSha256; add libXcursor

Motivation for this change
cargoSha256 started mismatching for some reason. Also I didn't realize I was missing a runtime dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120968 at 8db3f963 run on x86_64-linux 1

1 package built successfully:

shticker-book-unwritten

1 suggestion:

warning: unused-argument
Unused argument: stdenvNoCC.
Near pkgs/games/shticker-book-unwritten/default.nix:1:38:
  |
1 | { buildFHSUserEnv, callPackage, lib, stdenvNoCC }:
  |                                      ^

The mismatch is because of the rust 1.51 update.


GOPASS_EXTERNAL_PWGEN env var not using external program

Summary
It appears that GOPASS_EXTERNAL_PWGEN env var isn't doing what I expect it to
and that is to use the external password generator for password generation
Steps To Reproduce
External password generator: passg
Test command:
GOPASS_EXTERNAL_PWGEN="passg -p" gopass generate test.org/me

Expected behavior
Expect external pwgen to be used
Environment

OS: macOS 11
OS version: Darwin m2.lan 20.1.0 Darwin Kernel Version 20.1.0: Sat Oct 31 00:07:11 PDT 2020; root:xnu-7195.50.7~2/RELEASE_X86_64 x86_64
gopass Version: gopass 1.10.1 go1.15.5 darwin amd64
Installation method: brew

You need to use gopass generate -g external test.org/me to select the external generator as per the doc:
https://github.com/gopasspw/gopass/blob/master/docs/commands/generate.md#password-generators
So:
GOPASS_EXTERNAL_PWGEN="passg -p" gopass generate -g external test.org/me

should work. Can you try it?

You need to use gopass generate -g external test.org/me to select the external generator as per the doc:
https://github.com/gopasspw/gopass/blob/master/docs/commands/generate.md#password-generators
So:
GOPASS_EXTERNAL_PWGEN="passg -p" gopass generate -g external test.org/me

should work. Can you try it?

Sweet it is working, but I had to change the command to be this.
GOPASS_EXTERNAL_PWGEN="passg -p -l" gopass generate -g external test.org/me

passg didn't like the length without defining -l
Thanks!

Sweet it is working, but I had to change the command to be this.
GOPASS_EXTERNAL_PWGEN="passg -p -l" gopass generate -g external test.org/me

passg didn't like the length without defining -l
Thanks!

This is actually one of the features I'd consider dropping.
Does using an external password generator have a real value for you? Or is it more like just for fun?

This is actually one of the features I'd consider dropping.
Does using an external password generator have a real value for you? Or is it more like just for fun?

Plus I guess we are already somewhat supporting it through pipes into gopass insert.
One can do an alias to have it handy:
alias gopassgen="passg -p -l 20 | gopass insert"
and then gopassgen nameofentry works

Plus I guess we are already somewhat supporting it through pipes into gopass insert.
One can do an alias to have it handy:
alias gopassgen="passg -p -l 20 | gopass insert"
and then gopassgen nameofentry works

Yeah that is a sound solution.  It is nice to use a custom password generator passg because it generates easy to read/type strong passwords.  Including passing in a required password length to meet silly password checker guidelines.


Bug - CSMC MM Chest Minigame

As stated in the bug report channel the chest minigame isn't updating with CSMC when it has now had major items required to beat the seed.

Fixed


Why does it take so long to build

Did you build successfully in the end? It takes a little longer, but you can still succeed in the end or will you always get stuck? Because i'm facing the same situation right now. Thanks.

I fix this by "pip install" from the .whl file which can be found here:https://github.com/state-spaces/mamba/releases/tag/v1.0.1

Also for anyone curious, the reasoning for why it takes so long is that it compiles all the .cuda code for a suite of hardware architectures, different seq lengths, and different input data.


cilium: bpf-based hostport implementation

See commit msg.

This change is

test-me-please

Coverage decreased (-0.1%) to 45.551% when pulling 1da3d05449c50adf92f729dad883da6f51176609 on pr/bpf-host-port into beb401bf019839f6aba0d6abfdfab6bb22320d7d on master.

test-me-please

test-docs-please

test-docs-please

test-me-please

test-docs-please

Prior Cilium-Ginkgo-Tests run was green.

test-me-please

test-docs-please

test-me-please

test-docs-please

@borkmann
# github.com/cilium/cilium/test/k8sT
test/k8sT/Services.go:636:26: cannot use httpHostPort (type int) as type int32 in argument to getHTTPLink
test/k8sT/Services.go:637:26: cannot use tftpHostPort (type int) as type int32 in argument to getTFTPLink
test/k8sT/Services.go:646:25: cannot use httpHostPort (type int) as type int32 in argument to getHTTPLink
test/k8sT/Services.go:647:25: cannot use tftpHostPort (type int) as type int32 in argument to getTFTPLink
make[1]: *** [govet] Error 2
make[1]: Leaving directory `/home/travis/gopath/src/github.com/cilium/cilium'
make: *** [unit-tests] Error 2

test-me-please

test-docs-please

test-docs-please

test-me-please

test-docs-please

test-me-please

test-me-please

test-docs-please

test-me-please

test-docs-please

(prior docs test was green)

test-me-please

(prior travis ci was green, x86 is green here, arm64 flaky in unrelated spot)

test-me-please


zw_programmer

Hi,
I wanted to know if zw_programmer is needed for updating the zwave source code using zwave-js firmware update feature. I dont have it on my board yet and tried to use the firmware update feature but it returned error message. similiar to chipset not in bootloader mode.
Sorry I dont remember it clearly, but if you guys know whats wrong, please let me know.
Thanks

To answer your question: Z-Wave JS only supports over-the-wire updates of controllers that already have a bootloader. It does not support the initial flashing of the bootloader.


selectSuggest doesn't trigger onSelectSuggests

Short description
I wrote this simple example to try this library.

Expected results
I expected that, after updating the input value (via update function), when selectSuggest function is called, it triggers onSelectSuggest function.
Should it work like this ?

I should work like this. Bugfix is on its way, thanks for reporting!

Thank you !

Closed by #470


Add conditions to SpecialResource status

/cc
Port of https://github.com/openshift-psap/special-resource-operator/pull/263

/cc @qbarrand

/ok-to-test

/lgtm

/approved

/approve


Fix remaining incompatible changes warnings

This fixes the remaining issues to resolve #430. With this, I can pass all tests using --all_incompatible_changes.
I did not yet turn it on in CI. I want to find a clean way to do that. The issue is that we want to be very lax on the "expect failure" tests and still fail. We don't want those tests to only fail due to a technicality of strictness, they should really fail due to "real error".
I don't know the right solution, but it may be that we have two different bazelrc files, and we copy the lax one for the expect failure tests.
Suggestions on that welcome.

please take a look @ittaiz

@ittaiz can we merge this? I think it is ready to go


chore: update test_cli.py

What does this PR do?
occured -> occurred
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Thanks!


Correct phrasing for clarity and accuracy

Description:
Changed "Your staking machine is unsafe like many others" to "Your staking machine is as unsafe as many others."
Changed "The rabbit hole goes deep" to "The rabbit hole runs deep."(This could be more idiomatic depending on the context.)

@remyroy @PabloCastellano @metachris Hey! Could you please review my corrections?
I hope I was able to help in some way. Thank you for your work.


GithubBot gitCall() method should check error type as it may not be an object

Currently a non-repository based event will cause an error. We should just use a generic context for the ProcBot at this point.


uprotocol-cpp: Add conan dependency management

This is needed to pull in uprotocol-core-api and other dependency libraries (googleprotobuf, etc..)

committed with #43