[Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview'

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12338

Hi @InbalZim, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

The breaking change was already approved in previous PRs to the private repo:

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with the following PRs:

Azure/azure-rest-api-specs-pr/12338
Azure/azure-rest-api-specs-pr/12530

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with the following PRs:

Azure/azure-rest-api-specs-pr/12338
Azure/azure-rest-api-specs-pr/12530

@blueww the PR was created using OpenAPI Hub's Publish Pull Request From Private Repo based on PR 12338, and the 2nd commit is based on the changes made in PR 12530, so the commits were created automatically by engineering systems accordingly.
In the PRs above, the commits are separated in a way that supports easy review (which I believe you already reviewed them).
Please LMK if there is anything I can do to make the review easier / clearer.

@rkmanda I am assigning you to this PR per @InbalZim request, as it doesn't have an assignee per:

https://github.com/Azure/azure-rest-api-specs/pull/24566

Please feel free to re-assign to more appropriate person. Thank you!

Breaking changes previously reviewed and approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/11320

Hey @rkmanda can you please help me understand the delay in merging this? Appreciate your help

Addding ARMSignedOff label since this seems to be already reviewed previously


LSPS2: (Re-)consider dropping no-MPP+var-invoice mode

I think we discussed this before, but it came to my attention again since I'm currently implementing LSPS2 client-side support in LDK Node:
LSPS2 currently offers two modes: MPP+fixed-invoice and  no-MPP+var-invoice. In the latter, it allows the client to leave out the optional payment_size_msat parameter and 'simply' lets the LSP forward the first HTLC it sees, independently of its amount.
However, this suffers from several pitfalls:

While the client can check the parameters based on the proportional fee beforehand, it can't compute the exact channel opening fee beforehand and will only learn how much the LSP deducted after the channel has been opened and the HTLC has to be claimed. It is now stuck between two bad choices:
a) always claim the HTLC, irrespective of how much fee the LSP deducted, given there is no maximum limit fee defined.
b) only claim the HTLC if the LSP deducted less than a pre-configured amount. This leads to the client withholding the preimage and 'cheat' the LSP based on this arbitrary client-side parameter.
A variant would be for the client to compute the maximal possible opening fee based on max_payment_size_msat after receiving the get_info response and cancel the flow if it exceeds an arbitrary set limit. The resulting maximum fee might be huge and waaaay too large for a user only expecting a small/medium sized variable-amount payment. The user therefore is again stuck between accepting high 'risk'  (i.e. ~unlimited fees taken by the LSP) or arbitrarily failing the flow.
It is currently not (clearly) spec'ed that the LSP SHOULD check the variably sized HTLC against {min,max}_payment_size_msat. This leaves some ambiguity regarding when it is expected that an LSP would fail the HTLC. Since only the payer will be notified of failing HTLCs, the client won't receive any feedback as to why the channel open failed (although, this is of course a general issue of this flow).
Having two modes introduces significant complexity on both client and server side. Given that LSPS4 should allow us to solve this use case 'properly', we might want to keep LSPS2 as simple as possible.

I therefore would like to raise the topic again and suggest that we at least discuss once more whether we really need the no-MPP+var-invoice mode in LSPS2, and if it wouldn't be preferable to drop this mode for the sake of simplicity from the LSPS2 spec. LSPS4 should then solve this issue more thoroughly by forwarding the HTLCs to the client, allowing it to decide based on actual values.

I agree with the sentiment of simplifying LSPS2.
However, I fail to understand how no-MPP+var-invoice causes the problem you describe. To my understanding the fees are fully negotiated in advance and I don't see how surprises can occur.
When the client receives the HTLC, they can see payment_size_msat and compute agreed upon opening_fee. The client only provides the pre-image if the opening_fee matches the amount the LSP-server is withholding from the payment.

Right, but this is currently considered cheating

No it's not. The spec only requires clients to accept the payment forwards if the opening_fee is computed fairly.
https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/d07cbb0bcdc1942c4970e4a2ac46f87c63dbdf33/LSPS2/README.md?plain=1#L928-L932


Spanner: sample with custom timeout and retry settings

I'll get to this tomorrow.

Thanks for the thorough review @laljikanjareeya. PTAL

Thanks a lot for the feedback @amanda-tarafa. I addressed all the comments. PTAL


Update Community Path layer

Since the fate of the community path was in question, we're currently not showing it at all. A heavily modified version of the path was approved as part of the GLX redesign.
Could someone work on creating GeoJSON for the new route? You'll need to do some independent research. The current GeoJSON is here.
Resources:
https://drive.google.com/file/d/0B7qVAVTOJ3PjRmp2eWk4V3pMbTQ/view
http://www.somervillestep.org/green-line-extension-moves-forward-with-conditions/

Links to help

http://www.pathfriends.org/
http://greenlineextension.eot.state.ma.us/documents/PubMtgs/commPath/communityPath_051414.pdf
http://www.somervillema.gov/sites/default/files/CommunityPathMap2010.pdf


Add snapshotting and rollback capabilities to vdisks

Ability to snapshot vdisk based on timestamp
Ability to rollback the vidisks that have snapshots to its snapshot's timestamp
If rollback to snapshot issued, newer snapshots should be removed automatically

@khaledkbadr can you add the features you want?
I imagine it must support start & end timestamp.
And what is the difference between snapshot & rollback, i think it is essentially the same, right?

Updated description!

You can recreate from the tlog, the timestampt is feature that still needs to be added:
https://github.com/zero-os/0-Disk/issues/237

Can we close this as a duplicate, because I think restoring is already supported, we just miss the timestamp feature (#237) as @robvanmieghem noted. Or is there some extra feature that this issue is describing and that I am missing?

Yup, it sure is a duplicate from #237


Invite link expired

When I try to make an invite, this happens.

client.on('message', message => {
    if (message.content === '*youtube') {
        client.discordTogether.createTogetherCode(message.member.voice.channelID, 'youtube').then(async invite => {
            message.channel.send(`Click the link! https://discord.gg/${invite.code.replace('https://discord.com/invite/', '')}`);
            message.channel.send(`${invite.code}`);
        });
    };
})```

nvm, You have to be in a discord call that is in the server for it to work.


Unsubscribe from AppDomain when closing down

Possible solution for fixing  #1689

This change is

Current coverage is 80% (diff: 60%)

Merging #1690 into master will increase coverage by <1%

@@             master      #1690   diff @@
==========================================
  Files           274        274
  Lines         16828      16860    +32
  Methods        2664       2664
  Messages          0          0
  Branches       1866       1873     +7
==========================================
+ Hits          13475      13505    +30
+ Misses         2924       2923     -1
- Partials        429        432     +3

Powered by Codecov. Last update d2150d1...15fcf6f

thanks!

close/reopen to trigger AppVeyor


Fixing build issue with Linux/Clang/C++23

io_base doesn't have a declared destructor, and gets an automatically generated one. This automatic destructor tries to destruct the pimpl unique pointer and causes a compilation failure.
Fix: add an explicit destructor with an empty implementation in the cpp file.

Hi! Thanks for the PR! An interesting question is, does this change break ABI? I guess no.

I don't think this changes it. The destructor was already part of io_base.cpp (and any other TU that included io_base.h), and because of that, it was included in the binding library.
After this change, it will be still part of the library. The only difference is that now code using io_base.h won't try to generate a default implementation of the destructor.
I also verified this with  nm -C src/bindings/sail-c++/libsail-c++.so.0.9.5, the results with and without this change are the same.


GridMap rotation causes offset in-game

Godot version
4.1.1 [bd6af8e0e]
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; <IP_ADDRESS>34) - 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 Threads)
Issue description
When you rotate a 3D tile using A, S or D in GridMap mode, the editor will show the tile placed as normal. However, when running the project in-game, the tiles will be offset.
In-Editor:

In-Game:

This was done using the "gridmap_starter" demo provided in the documentation, see reproduction steps for the link.
Steps to reproduce

Download the gridmap_starter.zip project found here and open it in Godot 4.1.1.
Follow the instructions on the documentation until you're able to add tiles.
Rotate the tiles using A, S and D randomly while adding them to the GridMap on the Y axis.
Add a camera that points towards your GridMap tiles you just placed.
Show the Camera's perspective in a 2nd View in the 3D editor.
Run the project from the editor.
The tiles should be rotated, but look nothing like in the editor preview camera.

Minimal reproduction project
N/A; Reproduction project is based off of existing project.

The GridMap starter project is very old and was created on early Godot 3.x versions, so things likely broke during the conversion to Godot 4.

wow, this problem is serious :0

@JekSun97 Please don't bump issues without contributing significant new information. Use the :+1: reaction button on the first post instead.

The GridMap starter project is very old and was created on early Godot 3.x versions, so things likely broke during the conversion to Godot 4.
It should probably be recreated from scratch at this point.

This also happens on my own project which I started on 4.0, using single Quads only for the meshes (basically flat tiles with a texture on it)


Fixed deeplinks in the docs that weren't working

using angular-meteor.com instead of angularjs.meteor.com)

Too many pull requests :)
now it's outdated again :)
but this time it will probably be easier to update.
Thanks and sorry it was so hard to contribute

Thanks!


Text's glitching after scrolling.

So, i was using this theme but i saw that the text's are glitch after you scroll to the end of server's channel. and even hapens when you scroll on DM list.
Step 1: Go to a server or go to the DM list.
Step 2: Scroll the list then you can see the text is glitching.
Heres the gif of the bug:

Discord channel: Canary
OS: Windows
Mod: BetterDiscord
Discord language: English
I even turn on Hardware Acceleration to make discord more smooth. And also disabled the BetterAnimations plugin to check if the issue is from the plugin. but it isn't.

It's due how Discord lazy loads channels. There's no good way to fix this other than reverting back to default channels. Which is a big no.


Turnip prices should update to show user input

This is work for issue #110. It doesn't include localizations, but conditionally shows turnip prices. I just took a crack at it and try to match the style of the app already.

I'm really not sure about that. Maybe the text should be more explicit? Like "Your in game price this morning is X and the predictions for this afternoon is Y". Right now it feels weird.

@TheVaan @renaudjenny on this.

I agree that it’s not that easy to find the right text. When we touch the text, we should discuss if there is more to do.
E.g. it doesn’t make sense to show the average price in the morning when it is later then 12pm and you inserted prices for the afternoon.
Maybe we need steps like:

no values for today:
Your in game price is predicted to be around X in the morning and around Y in the afternoon
value morning inserted, value afternoon missing
Your in game price was X in the morning and is predicted to be around Y in the afternoon
value in the afternoon inserted (doesn’t matter if morning value inserted)
Your in game price tomorrow is predicted to be around X in the morning and around Y in the afternoon

Just an idea.

I'm sorry we'll redo this one internally for now. Not yet clear on the features and I'm working on it to experiment.


Merge stats into main repository

Description
Merge df_stats.
Checklists
Some issues that need addressing before merging:

[x] collect-examples from Makefile is not added because there is no file examples/collect_stats.py
[x] decide which Postgres package to use (psycopg2 is used by db_connector, asyncpg is used by stats)
[x] Add README.md from stats
[x] Update tests and examples once #34 is merged

Some things I have checked:

[x] CLI works (dff.stats --help returns a help message)
[x] Superset Dashboard works (after running make docker_up localhost:8088 redirects to localhost:8088/login with a login page)

out date, rewite


Request for Protobuf Version Requirement in CMakeLists.txt

I encountered an issue while trying to build a project using CMake and Vcpkg. The CMakeLists.txt file of the project in question uses find_package to locate Protobuf without specifying a version. This has caused issues when trying to configure the project, as it fails to find a compatible version of Protobuf.
My current Protobuf version is 3.21.12, and I would like to ensure compatibility. Could you please specify the required version of Protobuf for this project in the CMakeLists.txt file or provide guidance on the appropriate version to use? This would greatly help users who are trying to build the project using Vcpkg or other package managers.
Thank you for your assistance in resolving this matter.

Hi @tesmachina,
Hmm, eos does not depend on protobuf. So this must come in from somewhere as a transitive dependency? I think OpenCV has an optional dependency on protobuf. Can you find out if it's that? And if so, you should be able to install eos with just opencv4[core,jpeg,png] and without protobuf. In fact, if you use eos's vcpkg.json, it specifies that only opencv4's jpeg and png features are needed, and not protobuf (https://github.com/patrikhuber/eos/blob/8196a74659ac0987259bbd54d2960e19bed28e49/vcpkg.json#L9-L11).

Great! I'll close this then.


intptrcast (with many different seeds) does not explore all possible executions

The following assertion is currently guaranteed to pass in Miri, no matter the seed:
fn main() {
  let ptr1 = Box::into_raw(Box::new(0)) as usize;
  let ptr2 = Box::into_raw(Box::new(0)) as usize;
  assert!(ptr2 > ptr1);
}

This is because we basically have a "bump allocator" as our implementation of int-to-ptr casts. Ideally, when exploring many seeds, all possible allocation patterns should arise; but at least we could try to find a way to be a bit less predictable than we currently are, so that failing the assertion above becomes a possibility.

do you want to just enable reuse, so a long running program will slowly start (deterministically) shuffling its allocations?
Or do you really want randomization? I mean your code snippet will pass when running natively ;)

Reuse would be another dimension I did not even consider yet. ;)

I mean your code snippet will pass when running natively ;)

It might pass. Or you might write with an allocator I could quickly hack together that makes this not pass. ;)
One way to make this particular test behave properly (as in, pass with some seeds and fail with others) is to start somewhere in the middle of the address space, and then for each new allocation randomly decide if we allocate at the "upper" or the "lower" end. But that will still not explore all possible executions, even if we assume addresses never get reused.

I guess we could use https://github.com/rust-osdev/linked-list-allocator on the [u8] that is our virtual memory so we'd at least get reuse without having to do much work. We can then figure out randomization later.

We could get reuse pretty easily by adjusting our integer address assignment logic, I think. Though this will incur fragmentation so it could be too expensive...

What would fragment? The actual memory in the allocations is stored wherever the allocated linked into Miri decides to put it, right?
And in any case, I suspect a minority of our cycles are spent actually accessing the bytes in allocations, so even if we fragmented them I think it wouldn't be that severe an issue.

I was thinking of Miri's virtually memory. To find an address for a new allocation, what do we do? Iterate over the list of existing allocations to see if there is a gap somewhere to fit this in?
Of course we could also go all-in: pick a random address and see if that works or overlaps. Give up after 1000 attempts or so.

Yeah, I think randomization is the way to go to. In addition to that, we can keep a fixed-size queue of recent deallocations and consult that first to increase our chance of reusing a recently-deallocated address.

I think there's a much easier way to do this: Carve up the whole address space ahead of time into N different bump allocators, and serve allocations by choosing randomly between them. This would produce address space exhaustion much faster on 32-bit targets, but it should be relatively easy to implement by reusing our existing code.

That would make things more random, so it would help, yes. Fundamentally there would still be correlations that are not guaranteed, though.


F* translation for trait inheritance is buggy

traits of the form:
trait T: A + B {
}

get translated to
class T  (v_Self:Type) = {
  [@@@ FStar.Tactics.Typeclasses.no_method]_super_16550665238208597986:t_A v_Self;
  [@@@ FStar.Tactics.Typeclasses.no_method]_super_9181983936900423582:t_B  v_Self;
  }

and its instances are of the form:
[@@ FStar.Tactics.Typeclasses.tcinstance]
let impl: t_T t_foo =
  {
    _super_16550665238208597986 = FStar.Tactics.Typeclasses.solve;
    _super_9181983936900423582 = FStar.Tactics.Typeclasses.solve;
    __marker_trait = ()
  }

This has two issues:

in the class, the attribute on the _super values should be [@@ FStar.Tactics.Typeclasses.tcinstance]
in the impl, there should be no __marker_trait or else this field should be declared in the class.

This is still relevant, here is a repro in the playground:
trait A {}
trait B {}
trait T: A + B {}

Open this code snippet in the playground


pull request for e2e test at 11/08/2016 13:45:07

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding davidmccormick as a maintainer of kube-aws

When he kindly proposed himself as a maintainer, I couldn't agree more!
@davidmccormick is a long-time contributor to the kube-aws project who has contributed many user-support efforts and patches, enchancements, features, and so on.
I officially express my appreciation to him and his efforts made so far and my wish that we could together and better maintain kube-aws. Let's add him to the list of approvers and reviewers now. Welcome David!

Super happy to hear this great news! Nice one @davidmccormick !

Codecov Report

Merging #1477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   37.91%   37.91%
=======================================
  Files          75       75
  Lines        4595     4595
=======================================
  Hits         1742     1742
  Misses       2611     2611
  Partials      242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e327d...004013c. Read the comment docs.


csv export should only use data that matches columns

When loading the data you will often load the entire database record, instead of just the columns you need.
Currently, csv export uses columns for headers but uses the entire data object.  If you have fields in your data that are not in the columns, your columns do not match the data.
Ideally, csv export would only export data that matches the columns.

Resolved on develop


ovh-angular-doc-url

Migrate ovh-angular-doc-url component
The goals of the migrations is:

Drop the Bower support
Apply ESLint Airbnb rules
Provide clean and concise README file.

We might consider using the share rollup configuration (cf: component-rollup-config)
Requirements
👀 Does the component is still used?

yes! on ovh-manager-cloud only.

💅 Does the component must be renamed?

yes! must be renamed to ng-ovh-doc-url.

🚨 Does the component has a dependency to another pending migration?

no

⚓ Related pull request

ovh-ux/ovh-manager-cloud#1295

Since this component is no more used on the ovh-manager-cloud, I've removed this unused dependency.

ovh-angular-doc-url repository has been archived.

Listing of usage from ovhDocUrl provider/component.
Provider: ovhDocUrl
client/app/cloud/project/compute/infrastructure/virtualMachine/add/cloud-project-compute-infrastructure-virtualMachine-add.controller.js
client/app/cloud/project/compute/infrastructure/virtualMachine/addEdit/cloud-project-compute-infrastructure-virtualMachine-addEdit.controller.js
client/app/cloud/project/compute/loadbalancer/configure/compute-loadbalancer-configure.controller.js
client/app/cloud/project/compute/ssh/cloud-project-compute-ssh.controller.js
client/app/cloud/project/storage/storage-add/storage-add.controller.js
client/app/cloud/project/storage/storage-details/storage-details.controller.js
client/app/cloud/project/storage/storage.controller.js
client/app/dbaas/dbaas-metrics/header/metrics-header.controller.js
client/app/dbaas/dbaas-metrics/platform/metrics-platform.controller.js
client/app/dbaas/dbaas-metrics/token/metrics-token.controller.js
client/app/dbaas/logs/detail/logs-helper.service.js
client/app/dbaas/logs/welcome/logs-welcome.controller.js
client/app/iplb/header/iplb-dashboard-header.controller.js
client/app/nasha/nasha.controller.js
client/app/vps/modal/shortcut/password/vps-password.controller.js
client/components/ovh-doc-url/ovh-doc-url.config.js

Component: ovhDocUrl
no more used.


Advanced indexing of large arrays returns UnboundLocalError rather than NotImplementedError

Problem
Advanced indexing of a relatively huge (e.g., length 10K) 1D array returns UnboundLocalError: local variable 'shardfn' referenced before assignment, rather than NotImplementedError.
I understand that advanced indexing is mostly not yet implemented. Most related routines raise NotImplementedError to let users know about this situation. However, this particular use case raises this different error, which seems to be a bug to me.
To reproduce

step 1: prepare test.py:from legate import numpy
a = numpy.arange(10000)
print(a[(1, 2, 3), ])

step 2: run with, for example$ legate --cpus 1 test.py

Output
Traceback (most recent call last):
  File "<blahblah>/lib/python3.8/site-packages/legion_top.py", line 394, in legion_python_main
    run_path(args[start], run_name='__main__')
  File "<blahblah>/lib/python3.8/site-packages/legion_top.py", line 193, in run_path
    exec(code, module.__dict__, module.__dict__)
  File "./test.py", line 3, in <module>
    print(a[(1, 2, 3), ])
  File "<blahblah>/lib/python3.8/site-packages/legate/numpy/array.py", line 381, in __getitem__
    shape=None, thunk=self._thunk.get_item(key, stacklevel=2)
  File "<blahblah>/lib/python3.8/site-packages/legate/numpy/deferred.py", line 414, in get_item
    copy = Copy(mapper=self.runtime.mapper_id, tag=shardfn)
UnboundLocalError: local variable 'shardfn' referenced before assignment

Expected results
Either [1, 2, 3] or NotImplementedError.
Notes

Interestingly, smaller arrays do not have this issue. For example, if a = numpy.arange(100), the code works fine.
Another way to make it works is to use GPUs instead of CPUs. For example, legate --gpus 1 test.py works fine. This is interesting, as the GPU implementation seems to be more stable than CPU implementation?

I added notes regarding using GPUs.

@lightsighter @piyueh can I ask one of you to run with -level dma=2,xplan=1 and paste the log messages?  This may be an instance of https://github.com/StanfordLegion/legion/issues/1070.

I think I have a fix for this in this commit: https://gitlab.com/StanfordLegion/legion/-/commit/d540961c32940e90854d731715a82db2b311a972
@manopapad can you help me test that it does indeed fix the hang here?

@streichler I've confirmed that the hang is gone. Let me know when you merge the branch so I can upstream it.

It looks like the above commit is in control_replication but not legate_stable. @lightsighter do you want to merge it into legate_stable as well, then we can close this issue?

This seems to be fixed


SSH Agent and basic password prompt SSH connection simply not working

Hey,
I've been trying for hours to connect to my server, but I keep having the same issue.
In short: The SSH Agent forwarding seems to not work in my case, and I cannot connect without exposing a password in the flightplan.js.
My computer is a MacBook Pro running OSX 10.10.5 Yosemite, Node v4.2.6, flightplan 0.6.9.
I have a simple Linode server running Ubuntu 14.04.
I can SSH in fine using ssh<EMAIL_ADDRESS>then entering a password.
I have set up my ~/.ssh/config, and going echo $SSH_AUTH_SOCK, on the server, tells me that the forwarding is working.
Now, I set up my flightplan.js in this barebones way:
var plan = require('flightplan');

plan.target('staging', {
  host: "176.x.x.x",
  user: "root",
  agent: process.env.SSH_AUTH_SOCK
});

plan.remote("deploy", function(remote) {
  remote.exec("echo $SSH_AUTH_SOCK");
})

Running fly deploy:staging I would expect to have a password prompt, but instead it returns
● Error connecting to '176.x.x.x': All configured authentication methods failed
I went ahead and added the password in the plan, which then allows me to connect, but the $SSH_AUTH_SOCK is empty, and so I cannot execute any git commands without key refusal.
Same thing happens when adding my public key to the authorized_keys.
Obviously, this is not optimal. Why is the password prompt not appearing? It does appear when using flightplan to connect to my localhost, so it looks to me that the prompt is possible. I'd like to have deployers enter the server password to keep it open-ended for our developers.
Could this be an issue with the settings on the server?
I don't understand why ssh-ing in normally, and ssh-ing with flightplan (ssh2) is so very different?
It seems that I always get different results than any guide or tutorial.
Have I completely missed some detail or setup process that is not mentioned in any documentation, or is my MacBook just not wanting this to work?

Make sure that ssh-agent is running on your local machine. On my Mac the process is automatically started (ps x | grep ssh-agent -> /usr/bin/ssh-agent -l).
Your key is most likely encrypted. The solution is to add your key to the keychain, e.g. ssh-add -K ~/.ssh/id_rsa

Let me know if you need further assistance.

My agent is absolutely running, and added to the keychain. I have been at this for several hours, so I seem to have run out of documented tricks to try.
To recap:

Running fly deploy:staging either refuses connection, or lets me in after entering password in plan or public key in serverside authorized_keys, no password prompt
Agent seems to be missing serverside, so any git commands are refused

SSHing manually from the terminal and running the same git commands is all good and golden.
I tried this on a second machine to make sure mine wasn't corrupt with the same results.

Having your public key in authorized_keys is definitely the way to go. Flightplan cannot decrypt your key on the fly.
To make your remote git commands work, you most likely need to set agentForward: true in your target configuration. agent has to be set as well, but this seems to be the case in your configuration.

Wow, ok. agentForward. That solved it. I should've delved more into ssh2 I suppose. It did not occur to me that it was needed since none of the examples use it.
Still my other question remains, is it not possible to have a password prompt when logging into the server? Maybe I'm simplifying how SSH works.

SSH is hard and using it with a highly configurable library is even harder,
I agree. Try setting tryKeyboard: true.
On 2. Februar 2016 at 16:52:34, hugo wiledal<EMAIL_ADDRESS>wrote:

Wow, ok. agentForward. That solved it. I should've delved more into ssh2
I suppose. It did not occur to me that it was needed since none of the
examples use it.
Still my other question remains, is it not possible to have a password
prompt when logging into the server? Maybe I'm simplifying how SSH works.
—
Reply to this email directly or view it on GitHub
https://github.com/pstadler/flightplan/issues/118#issuecomment-178650623
.

tryKeyboard unfortunately does nothing in this case. But I'm willing to accept that defeat and add keys to the deployment server.
It just means that everyone that wants to be able to deploy first has to be added to the authorized_keys, which is a slight annoyance, but not a huge problem.
Thanks for the help! :beer:


Update Audacity to 2.2.0

Please, upgrade AppImage for Audacity

http://ubuntuhandbook.org/index.php/2017/11/install-audacity-2-2-0-ppa-ubuntu-17-10/

https://launchpad.net/~ubuntuhandbook1/+archive/ubuntu/audacity

REFERENCE

https://bintray.com/probono/AppImages/Audacity
https://github.com/AppImage/AppImages/blob/master/recipes/audacity/Recipe

https://github.com/probonopd/audacity/releases


Updating contributing.md file

please assign me this issue @roshan1337d

What do you want to update?

hi @roshan1337d, please i already made some updates on the file based on some of the instructions that was not stated out that got me confused, and it took a lot of time before I could figure it out.
I'm pretty sure with the updates I have done, it will make it easier for people to navigate through it


Per PVC statistics unavailable

I don't seem to be able to get metrics for each PVC mounted by the system from the Weka CSI driver, such as:
kubelet_volume_stats_capacity_bytes - the per-PVC capacity in bytes.
kubelet_volume_stats_used_bytes - the per-PVC space usage in bytes.
kubelet_volume_stats_available_bytes - the per-PVC free space in bytes.
Is there a specific configuration option needed to enable these, or is it not currently supported by the driver at present?

Hello Dave, currently not supported.

No worries, thanks for letting me know!
Thanks,
Dave Green
On Mon, 24 Jun 2024, 13:49 Sergey Berezansky, @.***>
wrote:

Hello Dave, currently not supported.
—
Reply to this email directly, view it on GitHub
https://github.com/weka/csi-wekafs/issues/271#issuecomment-2186503280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFZMYMAEANVJIZUOEJBZ3TZJAIUZAVCNFSM6AAAAABJZXXWAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWGUYDGMRYGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@davegreen, the metrics will be added in version 2.5.0, stay tuned.
For reference, internal ticket: CSI-252
Those are the metrics collected:
kubelet_volume_stats_capacity_bytes
kubelet_volume_stats_available_bytes
kubelet_volume_stats_used_bytes
kubelet_volume_stats_inodes
kubelet_volume_stats_inodes_free
kubelet_volume_stats_inodes_used

Closing the ticket as resolved in the upcoming version.

Closing the ticket as resolved in the upcoming version.


Extremely slow interference on google colab.

I am using the google colab demo on a CPU runtime and its excruciatingly slow, it has been upwards of 20 minutes and the first step of semantic token generation just finished at 73%.
Ill attach the final output when its done.

_                   _
| |                 | |
| |__    __ _  _ __ | | __     ___  _ __   _ __
| '_ \  / _` || '__|| |/ /    / __|| '_ \ | '_ \
| |_) || (_| || |   |   <  _ | (__ | |_) || |_) |
|_.__/  \__,_||_|   |_|\_\(_) \___|| .__/ | .__/
                                   | |    | |
                                   |_|    |_|
encodec_load_model_weights: in_channels = 1
encodec_load_model_weights: hidden_dim  = 128
encodec_load_model_weights: n_filters   = 32
encodec_load_model_weights: kernel_size = 7
encodec_load_model_weights: res_kernel  = 3
encodec_load_model_weights: n_bins      = 1024
encodec_load_model_weights: bandwidth   = 24
encodec_load_model_weights: sample_rate = 24000
encodec_load_model_weights: ftype       = 1
encodec_load_model_weights: qntvr       = 0
encodec_load_model_weights: ggml tensor size    = 320 bytes
encodec_load_model_weights: backend buffer size =  54.36 MB
encodec_load_model_weights: using CPU backend
encodec_load_model_weights: model size =    44.36 MB
encodec_load_model: n_q = 32

bark_tokenize_input: prompt: 'this is an audio generated by bark.cpp'
bark_tokenize_input: number of tokens in prompt = 513, first 8 tokens: 20579 20172 20199 33733 58966 20203 28169 20222

Generating semantic tokens... 26%

bark_print_statistics:   sample time =    47.48 ms / 205 tokens
bark_print_statistics:  predict time = 399150.69 ms / 1947.08 ms per token
bark_print_statistics:    total time = 399241.41 ms

Generating coarse tokens... 100%

bark_print_statistics:   sample time =    22.94 ms / 612 tokens
bark_print_statistics:  predict time = 1246901.88 ms / 2037.42 ms per token
bark_print_statistics:    total time = 1246956.25 ms

Generating fine tokens... 100%

bark_print_statistics:   sample time =   112.96 ms / 6144 tokens
bark_print_statistics:  predict time = 83667.94 ms / 13.62 ms per token
bark_print_statistics:    total time = 83828.00 ms

encodec_eval: compute buffer size: 103.34 MB

write_wav_on_disk: Number of frames written = 97920.

main:     load time =     0.00 ms
main:     eval time = 1789810.75 ms
main:    total time = 1790277.75 ms```

Hello @crackedpotato007 !
Thanks for reaching out. I tried on Google Colab and it is indeed very slow. This is mostly because the machines proposed with Colab are not very powerful and Bark is still very resource intensive.
Can you send me the specs of the machine? Are you using the free plan of Google Colab?
I can only advise to use Bark-small which is a smaller model and should allow for faster inference time.

Hello, I tried it on my device with a I3-10110U which is 2C/4T.
Not powerful by today's standards, BUT i did notice, chanding the thread count from 4 to 1 cut the time from 29MS a token to 18MS  a token for semantic token generation

@crackedpotato007 This is surprising. I'm closing this issue as it's going fast locally. Feel free to open a new one on this repo or directly on ggml repo to share your observations regarding multi threading.


Add a basic zh-TW Traditional Chinese translation

cc #32

@loggerhead, though I know that there are some i18n issues that need to be resolved, is it possible we can get this merged first? Thanks.

@PeterDaveHello Taiwan is an inalienable part of China, and I will not merge your PR.

Funny how language isn't tied to one place—after all, it's not just Taiwan that uses Traditional Chinese, just like English has its own quirks in different regions! But hey, if that's how you see it, I guess there's not much I can do!


Move crafting resources

Original issue https://github.com/oliversalzburg/cbc-kitten-scientists/issues/112 by @hickeys

After some great re-organization, Crafting is now the only section with more than one expandable list. Why not move the resources list somewhere else?

Sorry to say, but we'll likely not implement this. The way the system is designed at this time is very familiar to most long-time users. This optimization of the UI would probably feel disruptive to most users, without providing enough benefit at the same time.
Thus, this change request is rejected for the time being. The UI has improved lots since the original issue was brought up. I hope nobody is disappointed.


Handle small trails differently

From Ryan: "Trails under 1 mile in length would be rendered on the map, but:
Not featured in the side panel
Not highlighted when the trail system is selected
"

This is completed with https://github.com/smartchicago/trailsy/commit/4d2666f8af6e729ea1ba8fc68da1aece9c91dfe2


[Feature] Add a Date option "YYYY.MM"

Is there an existing issue for this?

[x] Yes, I have searched the existing issues and it doesn't exist

Feature Description
I want to add a Date option "YYYY.MM", which is used widely in China.
E.g. 2023.1 - 2023.8 in the working experience section.
I think it is pretty easy to add this option, like in this commit https://github.com/AmruthPillai/Reactive-Resume/commit/82bf44daa24422156779e9b38d3dc695176eaa09 .
Thanks for your great contributions to this project. I never use another Resume Website since I meet this.

Thank you so much for the kind words :) I've pushed a PR to add these date formats now, it should be available in the app in the next release which should be soon.

wow, so quick!
Thanks again!


support for data memos

When sending funds, and entering in the memo/note field, it is too short to contain a SHA256 output, resulting in "Memo is too long" error.  In Counterwallet, if one selects "Data Memo" from the selections, the data is accepted.  This function may be useful for projects needing to verify the hash of images, or other files associated with blockchain assets.

Thanks for the report. Will be fixed in v0.9.9.

I'll leave this issue open until v0.9.9 is released.

Should be fixed in most current release v0.9.10
https://github.com/jdogresorg/freewallet-desktop/releases/tag/v0.9.10


Karabiner-Elements Simple Modifications not working on OS X 10.13.4

This morning I updated OS X to 10.13.4, and after that my Simple Modifications are not working anymore.

@aarellano I am experiencing the same problem. I assume you closed this issue because it is now working. Could you tell me what you did to get it to work? Thanks.

@jclarktennis I'm sorry, but I don't remember what I did to make it work. I can tell you that it is working now, and I'm running Karabiner-Elements version 12.1.0 and OS X 10.13.6
Hope it helps

@aarellano Alright, thanks anyway. I suppose I'll update to 10.13.6 and see what happens.


[requires.io] dependency update on test-dist branch

Changes Unknown when pulling 0642a704357a90982436cef177addfaef979a767 on requires-io-test-dist into ** on test-dist**.


Lint metadata annotations

It would be great if we had a linter rule to enforce correctness in metadata annotations. This rule would at minium check:

No extra/unknown attributes present in the metadata YAML.
Correct type provided for all attributes.

If we later allow for configuration of the linter, I could imagine quite a few rules to be configurable by the user, like ensuring that some attributes (title, description) are always present. But that can wait until later.
I believe we'll want some help from Go when reading metadata annotations. While we probably can do this in Rego alone, that solution is going to be quite complex, and it would be difficult to connect the metadata to the rules that they apply to... not to mention the whole metadata chain (if we want to work with that).

We do have this now, so I'm closing this as done. Will open another issue to enforce presence of annotations on all rules/functions matching a pattern. This would be a good candidate for the custom category.


Fix Blog 2.25: Change picture captions

Resolves #3061
Each picture now has its own caption to prevent any confusion
Desktop view:

Mobile view:

Internal Tracking ID: EXPOSUREAPP-13707

@Ein-Tim Thanks again for reporting and testing!


Look into why Log Out action does not rebuild new map from portal

Re-architecting authentication solved this issue. Closing this issue as it is no longer relevant.


Mast: Watch flyundervpn.com

Mast requests the watch of the watch_keyword flyundervpn\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

flyundervpn\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


[chip-test] chip_sw_power_idle_load

Test point name
chip_sw_power_idle_load
Host side component
SystemVerilog+Rust
OpenTitanTool infrastructure implemented
Unknown
Contact person
@tjaychen and @msfschaffner for HW, @timothytrippel @sriyerg for DV and concurrency framework
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)

@tjaychen / @msfschaffner - based on comment https://github.com/lowRISC/opentitan/issues/14814#issuecomment-1312852161 should this also be moved to post M2?
Otherwise we will need an update on the status of this from @yehuda-bejar

i think the one that was lowered is the max power concurrency test, but the not the idle load one.

Yeah this idle test should be ready soon, see https://github.com/lowRISC/opentitan/pull/15923.

Closing this as it is passing in nightlies. Any further FPGA debugging will be tracked in a test triage issue.

Created https://github.com/lowRISC/opentitan/issues/16506 to track FPGA issue.


SSR: Emits do not fire on dynamic components

Version
3.2.33
Reproduction link
github.com
Steps to reproduce
Clone the reproduction
To see expected behavior, run "npm run nossr" and monitor the console.  Emits are fired from both the standard input and the dynamic
Run "npm run ssr" and note that emits do not fire from the dynamic component, however the standard input works as expected.
What is expected?
Emits should fire from a dynamic component when running in SSR mode.
What is actually happening?
Emits do notfire in SSR mode, but the bug only affects dynamic components.

+1
This broke our ionic app


Increased default bcrypt cost

Resolves #18

Coverage remained the same at 81.64% when pulling 49b24b3a0f60d4ff4bf4216779cb6da8c8c2edc0 on bcrypt-cost into a66ab9d137543fc0c3e56c6fe5d7d377c93087f6 on master.

Coverage remained the same at 81.64% when pulling 49b24b3a0f60d4ff4bf4216779cb6da8c8c2edc0 on bcrypt-cost into a66ab9d137543fc0c3e56c6fe5d7d377c93087f6 on master.

Coverage remained the same at 81.64% when pulling 49b24b3a0f60d4ff4bf4216779cb6da8c8c2edc0 on bcrypt-cost into a66ab9d137543fc0c3e56c6fe5d7d377c93087f6 on master.

Coverage remained the same at 81.64% when pulling 49b24b3a0f60d4ff4bf4216779cb6da8c8c2edc0 on bcrypt-cost into a66ab9d137543fc0c3e56c6fe5d7d377c93087f6 on master.


setting sidebar ui tweaks

The setting sidebar header should have a different colour than the items to make it easier to differentiate them.

Replaces part of #2216

@SchrodingersGat at least this is passing now


[POC]: use inference server when model service image is equivalent to inference server image

What does this PR do?
This PR is just a POC about using an inference server instead of creating the model service container inside the pod with the recipe app container.
The problem that we may face is that there is no link between the recipe and the inference server in the UI so the user does not know that by stopping the inference server the recipe will not work.
It also misses a new task for the creation/reuse of an inference server
The image id is hardcoded
The image in the chatbot recipe in ai-lab-recipes is wrong
Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

Tried but it seems it is still building the image and I cannot see the inference server being started. Seems the lookup is based on the image name but I would prefere to use the backend property as it can be used as an information to tell Podman AI Lab to look for an inference server so that recipes can be specified with:

only backend => always look for inference server
only images and build context => always used build image
both => first try inference server then build image

Tried but it seems it is still building the image and I cannot see the inference server being started.

Weird. Which recipe did you use?

Seems the lookup is based on the image name but I would prefere to use the backend property as it can be used as an information to tell Podman AI Lab to look for an inference server so that recipes can be specified with:

only backend => always look for inference server
only images and build context => always used build image
both => first try inference server then build image

Sounds good, gonna update it

@jeffmaury updated to use the backend as you said. Give it a look, thanks!!

@jeffmaury updated to use the backend as you said. Give it a look, thanks!!

LGTM

So today we have a few classes to create a recipe ApplicationManager, RecipeManager, BuilderManager, PodManager. Here is a diagram showing how thoses actors interact between them.
The idea by splitting with those small actors was to have some clear separation between the building part, and the live resources.
The RecipeManager (and BuilderManager) should only be responsible of static resources, ai-lab.yaml files, repository and container images. Where the ApplicationManager would have the role to make those resources live using the PodManager and containerEngine.
Here is a diagram of how it is today (a bit simplified)
sequenceDiagram
    actor User
    participant ApplicationManager
    participant ContainerEngine
    participant PodManager
    autonumber
    User ->> ApplicationManager: Start Recipe
    rect rgb(0, 213, 255)
        Note over ApplicationManager,RecipeManager: Building part
        ApplicationManager ->> RecipeManager: Clone Recipe
        ApplicationManager ->> RecipeManager: Build Recipe
        RecipeManager ->> ApplicationManager: return RecipeImage[]
    end
    rect rgb(200, 150, 255)
        Note over ApplicationManager,PodManager: Instantiating part
        ApplicationManager ->> PodManager: Create pod
        loop Each RecipeImage
            ApplicationManager->>ContainerEngine: Create container
        end
    end

From my understanding of the code and the discussion above, we would like to replace the container(s) with a backend property by an InferenceServer.
IMO the RecipeManager should not have access to the lives resources, it should not have the InferenceServer in its constructor: When building the recipe, instead of returning RecipeImage[] it should probably return an interface like:
interface RecipeBuildResult {
  images: RecipeImage[];
  inferences: InferenceServerConfig[];
}

The idea here, would have the RecipeManager giving all the configuration required to build the recipe from scratch. Then, the ApplicationManager would have the responsibility to either start the inference server or re-use an existing one.
IMO we should keep as simple as possible the RecipeManager, to delegate the complicated part of creating/dealing the inference server to the application manager.
What do you think @lstocchi @jeffmaury ?

So today we have a few classes to create a recipe ApplicationManager, RecipeManager, BuilderManager, PodManager. Here is a diagram showing how thoses actors interact between them.
The idea by splitting with those small actors was to have some clear separation between the building part, and the live resources.
The RecipeManager (and BuilderManager) should only be responsible of static resources, ai-lab.yaml files, repository and container images. Where the ApplicationManager would have the role to make those resources live using the PodManager and containerEngine.
Here is a diagram of how it is today (a bit simplified)
sequenceDiagram
    actor User
    participant ApplicationManager
    participant ContainerEngine
    participant PodManager
    autonumber
    User ->> ApplicationManager: Start Recipe
    rect rgb(0, 213, 255)
        Note over ApplicationManager,RecipeManager: Building part
        ApplicationManager ->> RecipeManager: Clone Recipe
        ApplicationManager ->> RecipeManager: Build Recipe
        RecipeManager ->> ApplicationManager: return RecipeImage[]
    end
    rect rgb(200, 150, 255)
        Note over ApplicationManager,PodManager: Instantiating part
        ApplicationManager ->> PodManager: Create pod
        loop Each RecipeImage
            ApplicationManager->>ContainerEngine: Create container
        end
    end

From my understanding of the code and the discussion above, we would like to replace the container(s) with a backend property by an InferenceServer.
IMO the RecipeManager should not have access to the lives resources, it should not have the InferenceServer in its constructor: When building the recipe, instead of returning RecipeImage[] it should probably return an interface like:
interface RecipeBuildResult {
  images: RecipeImage[];
  inferences: Partial<InferenceServerConfig>[];
}

Note
Depending on the configuration, the RecipeManager would skip the containers with a backend and return an InferenceServerConfig instead of a RecipeImage
The idea here, would have the RecipeManager giving all the configuration required to build the recipe from scratch. Then, the ApplicationManager would have the responsibility to either start the inference server or re-use an existing one.
IMO we should keep as simple as possible the RecipeManager, to delegate the complicated part of creating/dealing the inference server to the application manager.
What do you think @lstocchi @jeffmaury ?
Example
Given the following ai-lab.yaml
version: v1.0
application:
  type: language
  name: ChatBot_Streamlit
  description: Chat with a model service in a web frontend.
  containers:
    - name: llamacpp-server
      contextdir: ../../../model_servers/llamacpp_python
      containerfile: ./base/Containerfile
      model-service: true
      backend:
        - llama
      arch:
        - arm64
        - amd64
      ports:
        - 8001
      image: quay.io/ai-lab/llamacpp_python:latest
    - name: streamlit-chat-app
      contextdir: app
      containerfile: Containerfile
      arch:
        - arm64
        - amd64
      ports:
        - 8501
      image: quay.io/ai-lab/chatbot:latest

The RecipeManager.buildRecipe would return something like
{
  'images': [{
    appName: 'streamlit-chat-app',
    modelService: false,
    ports: [8501],
  }],
  'inferences': [{
    port: 8001,
    inferenceProvider: 'llama-cpp',
  }],
}

Such refactoring should be part of a follow up PR as we need to put this into motion ASAP for the release.
The only issue I have for the redesign is that to decide which images to build you need to get access to the live data


all_goals + apply elaboration = lost errors

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
After a ton of minimization, here is an example where all_goals swallows typing errors generated by incorrect applications:
theorem bug: True := by
 all_goals exact Nat.succ True   -- Nat.succ True is not well typed, but the tactic succeeds
 trivial

The bug propagates to <;> and from there to many other tactics and macros that fail to fail.
Versions
"4.9.0-rc3"

See also the discussion on Zulip: https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/all_goals.20.2B.20apply.20elaboration.20.3D.20lost.20errors


NaCl env cleanser memory leak

Currently within NaCl clean_environ nap members are not being freed properly.
In the most branches of NaCl, they are being shallow copied from parent to child and destroyed whenever the first process exits, so a race condition and seg fault condition on fork is possible. In addition execv'd clean_environ members are not being destroyed at all. On the vm_write branch, in order to avoid the seg_fault condition, I removed all destruction of these members.
Deep copies are not sufficient to prevent memory leaks due to the way that these members must be freed.
In order to fix this memory leak, we will probably want to reference count in some way--I was thinking either a NaClApp member or a global dynarr would be necessary, and I'd probably prefer the former solution.

Addressed in this pull request.

Addressed in this pull request.


Fix grid size in Triton decoding kernel

Motivation
Fix issue mentioned in https://github.com/sgl-project/sglang/discussions/1935.
python -m sglang.bench_one_batch --batch-size 128 --input 128 --output 128 --model meta-llama/Llama-3.1-8B-Instruct --attention-backend triton

Prefill. latency: 0.37300 s, throughput:  43925.00 token/s
Decode.  latency: 0.01022 s, throughput:  12529.66 token/s
Decode.  latency: 0.01028 s, throughput:  12455.53 token/s
Decode.  latency: 0.01024 s, throughput:  12494.67 token/s
Decode.  latency: 0.01015 s, throughput:  12611.19 token/s
Decode.  latency: 0.01016 s, throughput:  12596.69 token/s
Decode.  median latency: 0.01000 s, median throughput:  12796.35 token/s

python -m sglang.bench_offline_throughput --model meta-llama/Llama-3.1-8B-Instruct --disable-radix --num-prompt 3000 --attention-backend triton

====== Offline Throughput Benchmark Result =======
Backend:                                 engine
Successful requests:                     3000
Benchmark duration (s):                  60.98
Total input tokens:                      673672
Total generated tokens:                  581627
Request throughput (req/s):              49.20
Input token throughput (tok/s):          11047.56
Output token throughput (tok/s):         9538.11
Total token throughput (tok/s):          20585.67
==================================================

I think the failure in Unit Test 3 is introduced by introduced by https://github.com/sgl-project/sglang/pull/2081#issuecomment-2495368425


allow to build image and initrd based on existing rootfs

Just so that we do not have to re-build rootfs every time for local build/testing.

LGTM

lgtm


tribal enrollment number

add a place where Plaintiff can add tribal enrollment number ("if applicable")

make sure it shows up on final document (enrollment_number)


delete job error - TypeError: Cannot read property 'success' of undefined

kue-ui-client v1.0.2

@Chris Manson   The error appears in this code
define("kue-ui-client/jobs/state/controller", ["exports", "ember"], function(e, t) {
    e.default = t.default.Controller.extend({
        queryParams: ["page", "order"],
        page: 1,
        order: "asc",
        jobs: t.default.inject.service(),
        actions: {
            removeJob: function(e) {
                var t = this;
                this.get("jobs").remove(e).then(function() {
                    t.get("notifications").success("Job Deleted", {
                        autoClear: !0
                    }),
                    t.get("model").removeObject(e)
                })
            },
            updateOrder: function() {
                var e = this.get("order");
                this.set("order", "asc" === e ? "desc" : "asc")
            }
        }
    })
}),

Thanks for the  fix in #40 👍  I've just released v1.0.3
If you are using kue-ui-express (which I think you are), because the dependency on kue-ui-client is not fixed npm install should pick up the new version automatically https://github.com/stonecircle/kue-ui-express/blob/master/package.json#L14
I don't know the exact method to force it to do that but you can delete your node_modules and it will pick it up for sure after a npm install 👍


New CONTRIBUTING.md document

Create a new CONTRIBUTING.md document. Vote here: https://bitcoinclassic.consider.it/contributing-doc

This is very good work.

All pull requests must have a vote.

This could result in regularly having large amounts of otherwise trivial/uninteresting vote topics, things like creating/enhancing documentation, fixing typos or changing case should not require a vote.
I'd suggest defining a criteria for what is a voting change and what is not, with the caveat that if there is a NAC then a vote is held.

@ChainQuery In the Consider.it section it says votes are not needed for emergencies and bug fixes. I believe typos and trivial things fall under that scope, but we could specify trivial possibly.

Regarding conflicts: I think we could just have a general "disputes" section on considerit, where someone can describe a conflict, the community could hear from all the sides, and vote on its just resolution. This is easy to do, flexible, and can be used on any conflict, not just pull request conflicts.

I'd like to let Olivier review this first before merging. If there are no objections from him, then I'll merge, maybe today, and then we can open another PR for revisions. Sound good?

Has anyone approached Rick Falkvinge for advice in this area? His recent comments on Reddit were very helpful, and he has first person experience of team management.

@jtoomim That sounds good

Comments and revisions on this document are getting out of hand. I suggest we find another way to make them.
Option 1: Open pull requests on essofluffy's github branch, and recursify this.
Option 2: Switch to a cloud-based text editor.
I think 1 is probably better for this one, due to the auditable edit trail.

Yea I'd agree option 1 seems the best.

Note: The recent flurry of activity on github, as I suspected, was almost certainly the result of an attack intended to insert bugs into our repository.
http://imgur.com/o7vxaJf
https://www.reddit.com/r/btc/comments/41skqy/it_should_not_be_hard_to_inject_bugs_into_bitcoin/cz4v2kn
We need to make sure our rules do not leave any opportunities for attack via buggy but popular code, while still preventing someone like me from being lame.

May I suggest that you use PiratePad like this one I created for you? :) It has some versioning integrated, and chat too.

Please just merge this. It satisfies two criteria for merging:

This is clearly better than the status quo
There's nothing contentious in here that we can't change later

I'm telling Olivier to take a look now. If he disagrees, he can file a pull request just like I will.


Add apache v2.0 license #5

Could you please check below.
Is it ok for you ?

And please let me know if you want to use other license.

Yes, it's ok. thanks.

Yes, it's ok. thanks.


Add product error

Hi,
I create product but error: Attempt to read property "id" on null
How can fix it?

I faced the same issue. After looking into the code I found out it was mainly due to no locations were added. You can add a locations from the settings page and then this error will be gone.

I think this is being caused due to wrong operator usage here:
https://github.com/shopperlabs/framework/blob/c9c0e4e05fcdff8f01b5cd4185b134fbffe3ee75/resources/views/livewire/products/create.blade.php#L131
It is:
@if($inventories->count() <= 1)

When it should be:
@if($inventories->count() >= 1)

Hi,
@secrethash Thanks for help.
I want to ask one more question. How to edit code that must be edited directly in vendor.
Example: If I want to add any input box in module product. I don't want to go to the vendor to fix it, because it affects the author's next update.
Please guide me if possible. Thanks.

@hieuna One method could be to publish the vendor's assets ( blade files in this case ) and override them.
That way, when the next update is released, you can simply remove your vendor file and it will work just like before.

@thearyanahmed Thanks for anwser me.
If I delete the edited files, my custom will be lost. I mean is there a way to update to the new version and still keep the things that have been modified? Does this sound difficult?

Well, you just need to change one line, the solution given by secrethash. So, when the next update comes and this issue is fixed by the vendor, you will no longer need your custom file.
If you still need to keep your custom file, then just don't delete it. Laravel will override the vendor's file with yours.
If you need both, like some portion of the newly released file and some of your custom code, i don't believe there is a simple way, not that I know of!

@hieuna there is a shopper:publish command available. To publish the shopper files.
php artisan shopper:publish

For changes I think @thearyanahmed explained it.

Hi @secrethash , @thearyanahmed Thanks for support me.


Conform heading and folder names

What is the context of this PR?
Fixes: #1500 some of the changes the card asked for have already been done but breadcrumbs hadn't and error-validation needed changing (BREAKING CHANGE)
How to review

Tests pass
All breadcrumbs and error patterns still look as they should

 Issue #1500: Consistent heading and folder names for components and patterns


new nwp data

Describe the bug
New nwp data must be slightly different as it is causing this bug
https://eu-west-1.console.aws.amazon.com/cloudwatch/home?region=eu-west-1#logsV2:log-groups/log-group/$252Faws$252Fecs$252Fforecast$252F/log-events/streaming$252Fforecast$252Fa17bd8c180194cb68f201eb478de6805

Something here - https://github.com/openclimatefix/nowcasting_dataset/blob/main/nowcasting_dataset/data_sources/data_source.py#L447 is going wrong
Expected behavior
not to error
Additional context

new nwp-consumer has just been deployed
osgb is used here
Could be something used to be an int, and now its a float, or something like that

@devsjc if you get a chance, do you mind looking at this today?

It could be something we can fix in nowcasting_datast but I'm just confused how this has happened. It could also be a package update that has caused this

THis might be fixed with 1.3.24 (or the latest one), @devsjc do you mind deploying in on terraform cloud, then seeing if it works on airflow, not it normally only works between xx:05 and xx:35

Different error now:
RuntimeError: Example is wrong shape! x_center_osgb=274767.28508405434

See Cloudwatch logs


how do I use Microsoft Bot Framework Input/Output Adapter?

I have my Microsoft Bot Framework set-up with the proper channels. Now I would like to integrate my python script to the Microsoft Bot Framework. I have looked around but have not found anything. I have my access token.
Where would I find "directline_host", "conversation_id"?
Here is the sample code:
#from chatterbot import ChatBot

#'''
#See the Microsoft DirectLine api documentation for how to get a user access token.
https://docs.botframework.com/en-us/restapi/directline/
'''

#chatbot = ChatBot(
    'MicrosoftBot',
    directline_host='directline_host',
    direct_line_token_or_secret='token',
    conversation_id='conversation_id',
    input_adapter='chatterbot.input.Microsoft',
    output_adapter='chatterbot.output.Microsoft',
    trainer='chatterbot.trainers.ChatterBotCorpusTrainer'
)

chatbot.train('chatterbot.corpus.english')

# The following loop will execute each time the user enters input
while True:
    try:
        response = chatbot.get_response(None)

    # Press ctrl-c or ctrl-d on the keyboard to exit
    except (KeyboardInterrupt, EOFError, SystemExit):
        break

I think it was written on Directline1.1 which is very old version, that is the reason i may not work with latest, needs to upgrade it Directlin 3.3 API https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-direct-line-3-0-concepts

I have created a separate issue https://github.com/gunthercox/ChatterBot/issues/1285


YTMusic fixes

This PR adds a few fixes:

Add guard while adding playlists to silently catch edge-cases, making sure other playlists get synced.
Use disc number info from YTMusic with a fallback of the order of tracks in case the track number info is not available.

Will change it. What's the reason behind it?
Op vr 15 mrt 2024 om 14:48 schreef Marcel van der Veldt <
@.***>

@.**** commented on this pull request.
In music_assistant/server/providers/ytmusic/init.py
https://github.com/music-assistant/server/pull/1145#discussion_r1526316046
:

@@ -346,7 +346,12 @@ async def get_playlist_tracks(self, prov_playlist_id) -> AsyncGenerator[Playlist
# Grab the playlist id from the full url in case of personal playlists
if YT_PLAYLIST_ID_DELIMITER in prov_playlist_id:
prov_playlist_id = prov_playlist_id.split(YT_PLAYLIST_ID_DELIMITER)[0]

   playlist_obj = await get_playlist(prov_playlist_id=prov_playlist_id, headers=self._headers)

   # Add a try to prevent MA from stopping syncing whenever we fail a single playlist

   try:

       playlist_obj = await get_playlist(prov_playlist_id=prov_playlist_id, headers=self._headers)

   except KeyError as ke:

       self.logger.warning(f"Could not load playlist: {prov_playlist_id}: {ke}")

for log strings, better not use string formatting but positional arguments
—
Reply to this email directly, view it on GitHub
https://github.com/music-assistant/server/pull/1145#pullrequestreview-1939002510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEG2MJ4KK77N4UR25NQAY4TYYL33HAVCNFSM6AAAAABEX632SWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZZGAYDENJRGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Will change it. What's the reason behind it? Op vr 15 mrt 2024 om 14:48 schreef Marcel van der Veldt < @.***>

It's a performance best-practice


Fix empty input in ComboBox

Fixes #447

Thanks for the PR @jyash97! Just ran into this problem myself.
Looks like you'll need to wrap the itemToString prop we pass to Downshift with a null handler: https://github.com/segmentio/evergreen/blob/0a49844152d02248c8aa11121a847aaafd6713a7/src/autocomplete/src/Autocomplete.js#L197
For example (roughly):
const wrappedItemToString = (i => i ? itemToString(i) : '')

return (
      <Downshift {...props} defaultSelectedItem={defaultSelectedItem} itemToString={wrappedItemToString}>

Since Downshift expects an itemToString that can handle null values: https://github.com/downshift-js/downshift#itemtostring
You can verify this with the "Custom item objects" example in the storybook (just run yarn dev).
Otherwise, cc @mshwery on whether we want to expose null handling in itemToString. IMO, this seems like a sane default, since I can't think of a use case.

Hey @colinking thanks for the review.
This sounds good to me we can handle it on AutoComplete , & also I have tested this implementation this works properly.

Hey @colinking ,
Thanks for the review. I tried the same approach of wrapping the itemToString function and return an empty string.
But consider this :
If we will clear the input we get a empty string back and trying to access label from the string, which will break things.
 <Combobox
   defaultSelectedItem={customItems[0]}
   items={customItems}
   itemToString={i => i.label} // i will be empty string and this will break things again
   onChange={handleChange}
 />

Thoughts @colinking @mshwery


Keyup input with error.

Same as https://github.com/valor-software/ng2-select/issues/437 and https://github.com/valor-software/ng2-select/issues/453


General Updates 11

Before you start...

[x] Have you updated the FluentHub? You might be using an old version.
[x] Have you checked if similar issue have already been reported?

Resolved / Related Issues

Closes #8 (Wow, the 8th issue haha)

Details of Changes

Added the ability to switch between different GitHub accounts without singing out.

Validation
In the appbar click on the 3 dots icon and in that flyout click on "Switch Account"

[x] Built and ran the app
[x] Tested the changes for accessibility

Relevant Assets

it has difficult. we can store several account info, but browser has cookie or browser data. so once user authorize app with one account, user is hard to authorize again with other account.

True. Maybe, the best way is trying to find a way to open a private tab so they canclogin with the account they want

yep. i think so

so app would display auth link and indicate user to open private tab. UWP app doesn't have capability to open specified browser.

Yes, that's one idea, but maybe it's better to use WebView window/view for login?

better to use webview2
but it seems to remain browser data

Yeah, we had to implement a clean data programatically

And i need to take a look to that because WebView2 was in Beta version and apps with it can't be uploaded to the store

WebView2 is very nice idea!(not needed to consider about user's cookies, caches, and more)
We can update to pre-release version of muxc.

apps with it can't be uploaded to the store
Yes. This is the most important point on this issue. maybe we have to wait until publish stable version of WebView2, means WinUI 2.8

Ok, nice!

However we can still have WebView as another option. I need to take a look.

We should take a look to this docs. Maybe now we can be able to upload to the store without problems. I don't really know, the thing is to test it, but now i'm at school.
https://docs.microsoft.com/en-us/microsoft-edge/webview2/how-to/publish-uwp-app-store

Previously, we had this problem. I dont know why, despite I had latest SDK.

Supported API
In this test, WACK checks the Windows APIs that your host app is calling, to make sure they're supported.If your app failed the Supported API test, update the Windows SDK to version 22000 or higher, to get the latest version of the allowed-APIs list. There should be no blocking APIs for WebView2 in the current Windows SDK.

But I can try again.

back off. @stale

I can work on this!

Ok nice! Go with it!

Nice

Like? @BobbyESP

Ohh yes! Cool men!

Sign in with WebView2 window

But could not redirect. so we need to instruct users

Show url in the textbox
Paste In-Private url bar
Go there
And get back

I dont know if it is better

Wooow it's nice meen!!

Do not re-authorize or switch user. latest commit makes the app go crazy.

Niceee!!!

How about? @BobbyESP @DeveloperWOW64

Woow, that's nice! I like it haha

I will definitely make this great, so look forward to it!

Okeyy, nice men! Tomorrow i finish my exams (well, i finish secondary school in Spain(12-16 years))

Okeyy, nice men! Tomorrow i finish my exams (well, i finish secondary school in Spain(12-16 years))

😀😀😀 That's amazing!!
Make sure to have lots of sleep - as one of my teachers Mrs Legg once said to my class "I'd rather you spent your time sleeping than staying up studying".
I'm not done yet with school - though I did recently finish some large exams. Do you have A-levels in Spain?

Thanks men! And  yes, maybe i should sleep more haha...
And no, we don't have A-Levels

A-Level is only applicable for admission to universities in the UK and its nations, maybe. @DeveloperWOW64

can I re-open this as General Updates 10? you'll be a co-author, instead.

can I re-open this as General Updates 10? you'll be a co-author, instead.

WDYM? or are you talking to BobbyESP?

Sorry yes. @BobbyESP

can I re-open this as General Updates 10? you'll be a co-author, instead.

Yeah, no problem

DONE. All things should work.

but account switching still is not done.

No problem!

but account switching still is not done.

If account switching isn't done, what have else have you finished?

take a loo at latest commit. I completely changed actions when navigated to the page. previously, at that time, app passed RepoContextViewModel or sth. but in considering url navigation, i changed to pass the page's url.

And details layout page's code behind had very ugly code and so improved easier to see.

OH WOW! It looks amazing!

What's new
c43ff60 Now, you can click issue or pull button and go to the page from like this page:

I am planning to implement the feature of pagenation using Incremental Loading on GU 12 or later.

I am planning to implement the feature of pagenation using Incremental Loading on GU 12 or later.

WDYM?

Cirrently, the app shows only 20 items and cannot load more items. so I want to implement loading more items using Incremental Loading which is one of the ms community toolkit.

Right. This'll take some work:

oh my... after commited uncommited stuff, i will take a look....

@onein528 Just finished resolving the conflicts 🎉🎉

@onein528 I'm still used to the old param method:

how do the viewmodels work?

@onein528 I'm still used to the old param method:  how do the viewmodels work?

I am working on that. and likely to fix.

@DeveloperWOW64 Fixed all.

Okay this icon thing is kinda getting ridiculous..

WDYM?

Okay this icon thing is kinda getting ridiculous..

WDYM?

hahaha right

@onein528 Maybe this is debatable but can I rename the Accounts settings page to Account? Multi-account support is only a sub-feature of the accounts page and isn't entirely the account page's purpose.

I rename the Accounts settings page to Account

Where is it?

I rename the Accounts settings page to Account

Where is it?

Nowhere. I'm asking if it's okay or you want to keep it as Accounts

ahh, yes! can change it.

Amazing!

i will sleep bye.

i will sleep bye.

👋 good night

Nice work!!

@DeveloperWOW64 Committed.

@DeveloperWOW64 Committed.

thanks!

i got something bad. i will fix and commit again. @DeveloperWOW64

i got something bad. i will fix and commit again. @DeveloperWOW64

<DataTemplate  x:DataType="x:String" />
This?

yes. committed again.

Guys, i think i can came back to work!

woow. we are team, right? very exited to work together.

woow. we are team, right? very exited to work together.

yes 😀


GMM clustering and fixed compute pca

[x] added GMMClustering class w/ various methods for GMM clustering using BIC and AIC
[x] fixed compute_pca so values aren't hardcoded
[x] example script to run gmm clustering w/ ground truth annotations
[x] visualizing Feb + June datasets using UMAPs colored by GMM cluster weights and by predicted cluster labels

@alishbaimran @Soorya19Pradeep I am booked with multiple planning and writing projects through the end of the year. I  think Soorya is situated to provide a solid review and testing of this code. She implemented GMM clustering over time for infection state discrimination for Fig. 5 of https://academic.oup.com/pnasnexus/article/3/9/pgae323/7731083

@alishbaimran , can you pull the changes from the representation branch into this branch? There seem to be some conflicts with the representation branch.

@alishbaimran , can you pull the changes from the representation branch into this branch? There seem to be some conflicts with the representation branch.

Yes I can do this and then push changes again.

@alishbaimran it looks like you have merged the changes from representation in way that creates unnecessary diffs.
You may need to do this:

start a new branch from representation
transfer the relevant files by hand from this branch.
open a fresh PR and close this one.

@alishbaimran , as you open the new branch to make the changes Shalin mentioned please keep in mind to clean up the scripts like this inside applications/contrastive_phenotyping/figures folder as these doesn't make sense anymore.

@alishbaimran , as you open the new branch to make the changes Shalin mentioned please keep in mind to clean up the scripts like this inside applications/contrastive_phenotyping/figures folder as these doesn't make sense anymore.

@Soorya19Pradeep I'm not sure if these scripts are even suppose to be included in new branch. I pulled the files that were pushed to this branch and it seems some really old commits were moved here?

@mattersoflight could you clarify if/what to do with these olds commits?

@alishbaimran , I think it is best to close this and start a new branch. Let us do that and then you can add the new scripts for GMM clustering and remove those figure scripts there.


Multi-line statements not being counted accurately

I'm using 0.10 on a Rails 4.2 project with ruby 2.0.0-p643.  I'm seeing lots of occurrences of statements that span multiple lines not being counted as covered, or only 1 or the multiple lines being counted.  For example, I have a concern which is completely tested but reports as 77%.

If I simply reformat the code onto single lines I get 100% coverage.

so that we can reproduce this, can you provide a small snippet of the code and tests that create this bug? It would be of great help.

@bf4 I've created a repo with the code to reproduce this in (https://github.com/adampope/simplecov-multi-line-repro).  In doing so I've found the cause.  We are using the following snippet in test_helper.rb (from #16)  to make sure that all files are loaded:
  all_files = Dir['**/*.rb']
  base_result = {}
  all_files.each do |file|
    absolute = File::expand_path(file)
    lines = File.readlines(absolute, :encoding => 'UTF-8')
    base_result[absolute] = lines.map do |l|
      l.strip!
      l.empty? || l =~ /^else$/ || l =~ /^end$/ || l[0] == '#' ? nil : 0
    end
  end

  SimpleCov.at_exit do
    merged = SimpleCov::Result.new(Coverage.result).original_result.merge_resultset(base_result)
    result = SimpleCov::Result.new(merged)
    result.format!
  end

With that code multi-line statements do not get counted correctly.
With

Without

Any ideas on ways to modify this to correctly handle the multi-line statements?

We found a better way of solving the problem of tracking all files, I've added a comment to #16 so I'll close this ticket.

@adampope  Hey. What is the final fix for multi line statements. Please help.


add share folder to list of exceptions

Doesn't /share include most of the stuff that we want to be ignored? Like man pages and other junk. Are we sure we want to enable this?

^/share$ will only include the directory and nothing under it.
without that ^/share/proj doesn't sync because the parent directory doesn't exist.

Ah, got it! Cool, looks good.


Is it safe to run knex migrate:latest concurrently? (question / feature request)

I am adding the following entrypoint.sh to a Dockerfile and was wondering what would happen if I started multiple containers concurrently. Ideally, only one container would run the migration while others would be blocked. I was wondering if knex does that already or if I'd have to take care of this myself.
# entrypoint.sh
#!/bin/sh
set -e
# Inspiration: https://github.com/deis/controller/blob/master/rootfs/bin/boot

# make sure database exists
node ./lib/scripts/create-db.js || true

# run database migrations (todo: make sure this can be safely be run
# concurrently)
npm run knex -- migrate:latest

# passthrough
exec "$@"

Depending on database you are using, second instance running the migrations either throw an exception or it just waits (this comes in next knex release) until the first process is ready. More info about it is found here https://github.com/tgriesser/knex/pull/1962


Python build script

I have to ask, is this file really needed for IDEs? Does neither Visual Studio nor Codeblocks have UI options for CMake builds? That seems very strange to me.
In my eclipse IDE i just choose build configuration development or release like usual and it sends the correct options to cmake when building. I can also set CMake options to set (ex VK2D_BUILD_TESTS) or use ninja as generator from there.
I also think listing Python as a required dependency for building is incorrect as you can just use standard cmake usage to build just fine without it. Maybe mark it as optional or only for interactive build.
The build.sh is not needed on linux if you just add #!/bin/python3 at the top of the python file.
And finally i must strongly discourage from suggesting to run sudo ./Build.sh as this will also run the compiler as root. Either a separate user step after the compile like make usage normally does ex sudo make install or run sudo in the build script for just the install command. This is especially relevant seeing as ExternalLibraries is fetched remotely and not under your control what actually gets run during a build.

This python script is basically nothing more than a glorified shortcut and you can be completely ignore it if you prefer. 😄
Nothing will change for users who prefer to use CMake directly or via an IDE.
However this is my effort of trying to make compiling the library as painless as possible for new users and faster for old users.
I'm still ironing out the details on this, I'll take what you said into consideration.
I agree with you about using sudo, I'll be changing that later.
I was considering just doing the Windows route and "installing" everything into a folder if installation was done through the build tool and let the user then install it separately, however I'll have to study if this kind of package management can be done on Linux.

I did some changes. Concerning Linux I mainly just removed option to install via the build tool for now.
"Plain" CMake on VS seems competent enough but I haven't really used it yet. I'll see more about it in the future.

Regarding

however I'll have to study if this kind of package management can be done on Linux.

When building packages for linux you usually set the install prefix (-DCMAKE_INSTALL_PREFIX) to a local directory ex /tmp/build (maybe append /usr too), and the cmake --install will put output files there structured usually under /tmp/build/usr/bin or /tmp/build/usr/include.
Then your linux's packaging system (on archlinux makepgk) turns that directory into a package file with some extra metadata files for package version etc.
The final package is then installed via a package manager running as root. In this way you avoid having to run any untrusted buildscript as root.
Only on linux installations without a package manager would you ever directly run [c]make install as root.


No provider for AngularFirestore!

I did everything in the documentation, but I get error a problem with AngularFirestore:
AppComponent_Host.ngfactory.js? [sm]:1 ERROR Error: StaticInjectorError[AngularFirestore]:
StaticInjectorError[AngularFirestore]:
NullInjectorError: No provider for AngularFirestore!
I put all project on git: https://github.com/ibagaric/player

You have to import AngularFirestoreModule as well: https://github.com/angular/angularfire2/blob/master/docs/install-and-setup.md#6-setup-individual-ngmodules

Hey @ibagaric! What @Chris1308 says is true. You need to provide each feature module first so it's available for dependency injection in your components and services.


OCPBUGS-47503: Power VS: Revert #1076 to match new API validation

After https://github.com/openshift/api/pull/2076, the validation in the image registry operator for the Power VS platform does not match the API's expectations.  This PR reverts #1076 which intended to work around the API's initial validation issues.

/jira refresh

/lgtm

whoops sorry @r4f4 wrong PR!

/unassign r4f4

/label acknowledge-critical-fixes-only

/lgtm


Unit testing with IProxyStateLookup is pretty hard

What should we add or change to make your life better?
I'm currently trying to implement a middleware based on the ideas describes in this document which suggests using the IProxyStateLookup service in order to the configured clusters, etc. While writing some unit tests for this middleware I figured I could mock out the IProxyStateLookup interface and be off to the races. Unfortunately the GetClusters() method on that interface returns an IEnumerable<ClusterState>. While ClusterState does have a constructor that takes a string, it doesn't seem to be possible to set values for ClusterModel for example, which my middleware needs as it inspects some metadata on the cluster in order to its thing. There is a setter on that property, but it is internal so I can't access it (except through reflection of course ;)).
Why is this important to you?
Ideally I would like to have some unit tests in place for my middleware in order to catch bugs as early as possible, but not being able to provide the appropriate data through the IProxyStateLookup interface blocks me from doing that.

@Tratcher - what pattern do we use to allow creation of objects like this for unit tests?


Change unit testing lib

As the cunit library isn't maintained anymore. Maybe it might be a good idea to switch to an other test tools such as check

done in e325b0f


[Feature][Datax] Support datax task to import data into doris type data source

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Support datax task to import data into doris type data source
Use case
In the datax task, you can import data into doris
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking
* [x]  I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.

Description
Support datax task to import data into doris type data source
Use case
In the datax task, you can import data into doris
Related issues
No response
Are you willing to submit a PR?
* [x]  Yes I am willing to submit a PR!

Code of Conduct
* [x]  I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

大佬，你实现了这个功能了吗？

please assign to me @zhongjiajie


fix potential bug of swin converter

#6186

It seems that the bugs reported is not related to swin transformer

It seems that the bugs reported is not related to swin transformer

What is the purpose of this PR? Is it a bug fix (with changing behavior) or a refactoring (without changing behavior)?

I mean the bug reported by the bot.

Case
convert_weights
'backbone.' prefix
ckpt example

A
True
True
original det

B
True
False
original cls

C
False
True
mmcls, mmdet

D
False
False

Is the purpose of this PR to support Case A?

@shinya7y , thanks for you help.
Indeed, the purpose of this PR is B, I will try to figure out other usecases.

Thanks for the review. Are the changes still compatible with the current version? Is it necessary to merge the changes?
@Junjun2016


X.509 description is wrong

The X.509 certificate contains the public key.  Not the private key.  You keep the private key, well, private.  You would never share it with anyone.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd0775e7-299f-5980-f788-f94b95c54183
Version Independent ID: 361225e7-8900-cf9e-558b-535c671ece1a
Content: Cloud Services and management certificates
Content Source: articles/cloud-services/cloud-services-certs-create.md
Service: cloud-services
GitHub Login: @tgore03
Microsoft Alias: tagore

@gwenbettwy
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@tanmaygore
Can you please check and add your comments on this doc update request as applicable.

@gwenbettwy The author has updated the document. Changes will go live soon.
I am closing this issue now.


Mm fixes

The default config definition doesn't conform with the JSON specification (http://www.json.org/ , http://jsonlint.com/).
The issues were:

value names must be strings
strings are enclosed in double quotes
no trailing commas

I am currently developing a module, where i modify the config file and i need to be able to parse the config JSON-Object with JSON.parse(...). But that fails, because its not valid JSON (when config.js is based on the default config). I will probably add a workaround for this into my module, but it would be good, if the default config file uses the standard.

Hi @aschulz90
The config statement is a Javascript dictionary instead of a JSON file definition.

As @roramirez says, it is not a JSON file, or were you suggesting to switch to a JSON file configuration, instead of a javascript file?
In my opinion, one of the neat things, we can do in the config.js, is multiplying time (sometimes the unit is ms), such as 30 * 60 * 1000, which is easier to recognize as half an hour, instead of 1800000. This would not be possible in a JSON file, and there is probably some other things, too.

More importantly: it allows us to add closures (anonymous function) to the config in the future. So I won't be switching to JSON. (Especially since son doesn't support commenting.)

No, it's not a functionality change but a formatting one. I want the config definition to be easily be parsable when externally being extracted from config.js.
My usecase is that i extract the config with a Regex and try to parse it, which fails, because of the issues stated above.
The change doesn't modify any functionality from MagicMirror.

@aschulz90 I understand what you wan't. But forcing JSON rules upon a javascript dictionary doesn't make sense. Especially since in the future, the config might even contain even more exotic content.
Maybe you could load the config as a javascript file and generate the JSON yourself?