Cannot open the file-save window

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.77, 1.78.0-insider
OS Version: Ubuntu 22.04.2 LTS

Steps to Reproduce:

Install VS Code 1.77 or later and launch it.
Write some text to a file.
Try opening the file-save dialog window by any of the following options:

Ctrl+S or File > Save in a new file
Ctrl+Shift+S or File > Save as... in an existing file
try to close the editor, then choose Save in the window Do you want to save the changes...

Expected behavior:
The file-save dialog window should open.
Actual behavior:
Nothing happens.
Workaround:
Downgrading to 1.76.2 helps.
Technical info (from an affected version):
Version: 1.78.0-insider
Commit: 2da5a0024fe2ca407f741f19340f1a10f4d692af
Date: 2023-04-03T05:26:01.718Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.19.0-38-generic snap
Sandboxed: Yes

/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

Here is my GIF.

I have the problem on Ubuntu 20.04.5 LTS, dialog window for saving a new file or opening file is not showing.

/duplicate https://github.com/microsoft/vscode/issues/146422

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

This might be related: https://github.com/microsoft/vscode/issues/178979
@bpasero This is NOT a duplicate of #146422. Look at my GIF: I have included the part of screen where a notification would show but none is there.

Yeah could be https://github.com/microsoft/vscode/issues/178979 then, lets track there.

Reopening based on https://github.com/microsoft/vscode/issues/178979#issuecomment-1497330051

@Melebius can you start the application like code-insiders --verbose and follow the steps to open the save dialog. Attach the generated output in this issue thread.

Output when trying to open Save dialog using Ctrl+S in code-insiders --verbose:
[main 2023-04-05T12:27:59.259Z] [DialogMainService]: request to acquire file dialog lock {
  defaultPath: '/home/mmateju/asd',
  filters: [
    { name: 'All Files', extensions: [Array] },
    { name: 'Plain Text', extensions: [Array] },
    { name: 'Batch', extensions: [Array] },
    { name: 'BibTeX', extensions: [Array] },
    { name: 'C', extensions: [Array] },
    { name: 'C#', extensions: [Array] },
    { name: 'C++', extensions: [Array] },
    { name: 'Clojure', extensions: [Array] },
    { name: 'CoffeeScript', extensions: [Array] },
    { name: 'CSS', extensions: [Array] },
    { name: 'CUDA C++', extensions: [Array] },
    { name: 'Dart', extensions: [Array] },
    { name: 'Diff', extensions: [Array] },
    { name: 'Docker', extensions: [Array] },
    { name: 'F#', extensions: [Array] },
    { name: 'Go', extensions: [Array] },
    { name: 'Groovy', extensions: [Array] },
    { name: 'Handlebars', extensions: [Array] },
    { name: 'HLSL', extensions: [Array] },
    { name: 'HTML', extensions: [Array] },
    { name: 'Ignore', extensions: [Array] },
    { name: 'Ini', extensions: [Array] },
    { name: 'Java', extensions: [Array] },
    { name: 'JavaScript', extensions: [Array] },
    { name: 'JavaScript JSX', extensions: [Array] },
    { name: 'Jinja', extensions: [Array] },
    { name: 'JSON', extensions: [Array] },
    { name: 'JSON with Comments', extensions: [Array] },
    { name: 'Julia', extensions: [Array] },
    { name: 'Julia Markdown', extensions: [Array] },
    { name: 'LaTeX', extensions: [Array] },
    { name: 'Less', extensions: [Array] },
    { name: 'Log', extensions: [Array] },
    { name: 'Lua', extensions: [Array] },
    { name: 'Makefile', extensions: [Array] },
    { name: 'Markdown', extensions: [Array] },
    { name: 'Objective-C', extensions: [Array] },
    { name: 'Objective-C++', extensions: [Array] },
    { name: 'Perl', extensions: [Array] },
    { name: 'Perl 6', extensions: [Array] },
    { name: 'PHP', extensions: [Array] },
    { name: 'PowerShell', extensions: [Array] },
    { name: 'Properties', extensions: [Array] },
    { name: 'Pug', extensions: [Array] },
    { name: 'Python', extensions: [Array] },
    { name: 'R', extensions: [Array] },
    { name: 'Razor', extensions: [Array] },
    { name: 'reStructuredText', extensions: [Array] },
    { name: 'Ruby', extensions: [Array] },
    { name: 'Rust', extensions: [Array] },
    { name: 'SCSS', extensions: [Array] },
    { name: 'Search Result', extensions: [Array] },
    { name: 'ShaderLab', extensions: [Array] },
    { name: 'Shell Script', extensions: [Array] },
    { name: 'SQL', extensions: [Array] },
    { name: 'Swift', extensions: [Array] },
    { name: 'TeX', extensions: [Array] },
    { name: 'TypeScript', extensions: [Array] },
    { name: 'TypeScript JSX', extensions: [Array] },
    { name: 'Visual Basic', extensions: [Array] },
    { name: 'XML', extensions: [Array] },
    { name: 'XSL', extensions: [Array] },
    { name: 'YAML', extensions: [Array] },
    { name: 'No Extension', extensions: [Array] }
  ],
  title: 'Save As'
}
[main 2023-04-05T12:27:59.264Z] [DialogMainService]: new file dialog lock created {
  defaultPath: '/home/mmateju/asd',
  filters: [
    { name: 'All Files', extensions: [Array] },
    { name: 'Plain Text', extensions: [Array] },
    { name: 'Batch', extensions: [Array] },
    { name: 'BibTeX', extensions: [Array] },
    { name: 'C', extensions: [Array] },
    { name: 'C#', extensions: [Array] },
    { name: 'C++', extensions: [Array] },
    { name: 'Clojure', extensions: [Array] },
    { name: 'CoffeeScript', extensions: [Array] },
    { name: 'CSS', extensions: [Array] },
    { name: 'CUDA C++', extensions: [Array] },
    { name: 'Dart', extensions: [Array] },
    { name: 'Diff', extensions: [Array] },
    { name: 'Docker', extensions: [Array] },
    { name: 'F#', extensions: [Array] },
    { name: 'Go', extensions: [Array] },
    { name: 'Groovy', extensions: [Array] },
    { name: 'Handlebars', extensions: [Array] },
    { name: 'HLSL', extensions: [Array] },
    { name: 'HTML', extensions: [Array] },
    { name: 'Ignore', extensions: [Array] },
    { name: 'Ini', extensions: [Array] },
    { name: 'Java', extensions: [Array] },
    { name: 'JavaScript', extensions: [Array] },
    { name: 'JavaScript JSX', extensions: [Array] },
    { name: 'Jinja', extensions: [Array] },
    { name: 'JSON', extensions: [Array] },
    { name: 'JSON with Comments', extensions: [Array] },
    { name: 'Julia', extensions: [Array] },
    { name: 'Julia Markdown', extensions: [Array] },
    { name: 'LaTeX', extensions: [Array] },
    { name: 'Less', extensions: [Array] },
    { name: 'Log', extensions: [Array] },
    { name: 'Lua', extensions: [Array] },
    { name: 'Makefile', extensions: [Array] },
    { name: 'Markdown', extensions: [Array] },
    { name: 'Objective-C', extensions: [Array] },
    { name: 'Objective-C++', extensions: [Array] },
    { name: 'Perl', extensions: [Array] },
    { name: 'Perl 6', extensions: [Array] },
    { name: 'PHP', extensions: [Array] },
    { name: 'PowerShell', extensions: [Array] },
    { name: 'Properties', extensions: [Array] },
    { name: 'Pug', extensions: [Array] },
    { name: 'Python', extensions: [Array] },
    { name: 'R', extensions: [Array] },
    { name: 'Razor', extensions: [Array] },
    { name: 'reStructuredText', extensions: [Array] },
    { name: 'Ruby', extensions: [Array] },
    { name: 'Rust', extensions: [Array] },
    { name: 'SCSS', extensions: [Array] },
    { name: 'Search Result', extensions: [Array] },
    { name: 'ShaderLab', extensions: [Array] },
    { name: 'Shell Script', extensions: [Array] },
    { name: 'SQL', extensions: [Array] },
    { name: 'Swift', extensions: [Array] },
    { name: 'TeX', extensions: [Array] },
    { name: 'TypeScript', extensions: [Array] },
    { name: 'TypeScript JSX', extensions: [Array] },
    { name: 'Visual Basic', extensions: [Array] },
    { name: 'XML', extensions: [Array] },
    { name: 'XSL', extensions: [Array] },
    { name: 'YAML', extensions: [Array] },
    { name: 'No Extension', extensions: [Array] }
  ],
  title: 'Save As'
}
(code-insiders:43801): Gtk-WARNING **: 14:27:59.345: Can't open portal file chooser: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Rozhraní „org.freedesktop.portal.FileChooser“na objektu na cestě /org/freedesktop/portal/desktop neexistuje
[main 2023-04-05T12:27:59.646Z] [DialogMainService]: file dialog lock disposed {
  defaultPath: '/home/mmateju/asd',
  filters: [
    { name: 'All Files', extensions: [Array] },
    { name: 'Plain Text', extensions: [Array] },
    { name: 'Batch', extensions: [Array] },
    { name: 'BibTeX', extensions: [Array] },
    { name: 'C', extensions: [Array] },
    { name: 'C#', extensions: [Array] },
    { name: 'C++', extensions: [Array] },
    { name: 'Clojure', extensions: [Array] },
    { name: 'CoffeeScript', extensions: [Array] },
    { name: 'CSS', extensions: [Array] },
    { name: 'CUDA C++', extensions: [Array] },
    { name: 'Dart', extensions: [Array] },
    { name: 'Diff', extensions: [Array] },
    { name: 'Docker', extensions: [Array] },
    { name: 'F#', extensions: [Array] },
    { name: 'Go', extensions: [Array] },
    { name: 'Groovy', extensions: [Array] },
    { name: 'Handlebars', extensions: [Array] },
    { name: 'HLSL', extensions: [Array] },
    { name: 'HTML', extensions: [Array] },
    { name: 'Ignore', extensions: [Array] },
    { name: 'Ini', extensions: [Array] },
    { name: 'Java', extensions: [Array] },
    { name: 'JavaScript', extensions: [Array] },
    { name: 'JavaScript JSX', extensions: [Array] },
    { name: 'Jinja', extensions: [Array] },
    { name: 'JSON', extensions: [Array] },
    { name: 'JSON with Comments', extensions: [Array] },
    { name: 'Julia', extensions: [Array] },
    { name: 'Julia Markdown', extensions: [Array] },
    { name: 'LaTeX', extensions: [Array] },
    { name: 'Less', extensions: [Array] },
    { name: 'Log', extensions: [Array] },
    { name: 'Lua', extensions: [Array] },
    { name: 'Makefile', extensions: [Array] },
    { name: 'Markdown', extensions: [Array] },
    { name: 'Objective-C', extensions: [Array] },
    { name: 'Objective-C++', extensions: [Array] },
    { name: 'Perl', extensions: [Array] },
    { name: 'Perl 6', extensions: [Array] },
    { name: 'PHP', extensions: [Array] },
    { name: 'PowerShell', extensions: [Array] },
    { name: 'Properties', extensions: [Array] },
    { name: 'Pug', extensions: [Array] },
    { name: 'Python', extensions: [Array] },
    { name: 'R', extensions: [Array] },
    { name: 'Razor', extensions: [Array] },
    { name: 'reStructuredText', extensions: [Array] },
    { name: 'Ruby', extensions: [Array] },
    { name: 'Rust', extensions: [Array] },
    { name: 'SCSS', extensions: [Array] },
    { name: 'Search Result', extensions: [Array] },
    { name: 'ShaderLab', extensions: [Array] },
    { name: 'Shell Script', extensions: [Array] },
    { name: 'SQL', extensions: [Array] },
    { name: 'Swift', extensions: [Array] },
    { name: 'TeX', extensions: [Array] },
    { name: 'TypeScript', extensions: [Array] },
    { name: 'TypeScript JSX', extensions: [Array] },
    { name: 'Visual Basic', extensions: [Array] },
    { name: 'XML', extensions: [Array] },
    { name: 'XSL', extensions: [Array] },
    { name: 'YAML', extensions: [Array] },
    { name: 'No Extension', extensions: [Array] }
  ],
  title: 'Save As'
}
[43801:0405/142801.562907:INFO:CONSOLE(621)] "%cTRACE color: #888 InteractiveSessionService#onWillSaveState: Persisting 0 sessions", source: vscode-file://vscode-app/snap/code-insiders/1265/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js (621)
[main 2023-04-05T12:28:09.084Z] update#checkForUpdates, state =  idle
[main 2023-04-05T12:28:09.084Z] update#setState checking for updates
[main 2023-04-05T12:28:09.087Z] update#setState idle
[43801:0405/142839.493735:INFO:CONSOLE(621)] "%cTRACE color: #888 InteractiveSessionService#onWillSaveState: Persisting 0 sessions", source: vscode-file://vscode-app/snap/code-insiders/1265/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js (621)
[main 2023-04-05T12:29:06.877Z] menubarService#updateMenubar 1
[43801:0405/142906.918574:INFO:CONSOLE(621)] "%cTRACE color: #888 CommandService#executeCommand _setContext", source: vscode-file://vscode-app/snap/code-insiders/1265/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js (621)
[43801:0405/142906.918936:INFO:CONSOLE(621)] "%cTRACE color: #888 [DEBOUNCE: CodeLensProvide] for untitled:Untitled-1 is 250ms", source: vscode-file://vscode-app/snap/code-insiders/1265/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js (621)
[43801:0405/142915.318389:INFO:CONSOLE(621)] "%cTRACE color: #888 InteractiveSessionService#onWillSaveState: Persisting 0 sessions", source: vscode-file://vscode-app/snap/code-insiders/1265/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js (621)

Version info:
Version: 1.78.0-insider
Commit: 8f74fbfd1f2d8f6268a42df131726b218aafe511
Date: 2023-04-05T05:27:51.301Z
Electron: 22.4.3
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.19.0-38-generic snap
Sandboxed: Yes

Can you install xdg-desktop-portal-gtk and see if the file dialog works.

After I ran sudo apt install xdg-desktop-portal-gtk and rebooted my machine, the open and save dialogs do open. (They did not work before reboot.)

Thanks for confirming!

What is the best way to verify this issue?

@alexr00 the verification requires specific OS setup that does not have portal support, I will ask the OP to verify this instead.

This bug has been fixed in the latest release of VS Code Insiders!
@Melebius, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 5b6af0748264d83dc7a95f5f4b1c39196eaae8d9 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

/verified
I’ve just checked the problem is resolved in VS Code Insiders https://github.com/microsoft/vscode/commit/5b6af0748264d83dc7a95f5f4b1c39196eaae8d9. Thank you!
After running sudo apt remove xdg-desktop-portal-gtk and rebooting my machine, I am able to enter an open or save dialog in VS Code Insiders https://github.com/microsoft/vscode/commit/5b6af0748264d83dc7a95f5f4b1c39196eaae8d9 (unlike VS Code 1.77).


Short solution needed: "Formatting string in Rust" (rust)

Please help us write most modern and shortest code solution for this issue:
Formatting string in Rust (technology: rust)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

Format string at runtime in Rust

Format string at compile time in Rust

Format string arguments in Rust

Format string as hex in Rust

Format bytes as string in Rust


branch API Addition

I'm not sure if this is true but I feel like branch's 2nd and 3rd params are ALWAYS either a renderComponent or renderNothing.
If that's true, why not remove the need to call 'renderX' methods and just allow passing in a Component reference, like so:
branch(isTrue, MyComponent, MyOtherComponent)

You could then also expose a Nothing component to replace the renderNothing method.
branch(isFalse, Nothing)

Am I correct in assuming that the 'renderX' methods exist solely for paired usage with branch?

Besides renderNothing or renderComponent, you can use any HoC/HoF with branch. For example, you can build something like:
branch(
  ...,
  compose(
     withState(...),
     withHandlers(...),
     ...
  ),
  ...
)

This composition feature is really powerful. If we switch to passing components, we lose this ability.

Ah ok I see. I'd not used it that way yet, but it's good to know. Thanks.


[Sprig App] hopscotch

Author name
Author: brycen weeks
About your game
What is your game about?
Jump over the rope in time to recieve points. (Jump BEFORE the rope almost touches you)
How do you play your game?
Press S to jump.

sorry. last time i put this game here i published it under the wrong account (on github)


fix: update usages of postMessage to set targetOrigin parameter

Updated all calls to postMessage to pass a targetOrigin of '*'.
In some cases, the postMessage call is made against the source object of a previous message. In general, this could be any MessageEventSource (e.g. WindowProxy, ServiceWorker or MessagePort). However, under the current implementation, it would only be possible to be another Window object so I have narrowed the typing accordingly.
It may be that this is not an appropriate simplification and as the postMessage function is polymorphic, we may need to add some additional checking based on the original message source.
Happy to discuss if you think an alternative approach would be better.

Fixes https://github.com/connectifi-co/fdc3-web-portal/issues/22

@alj1s - looks like there are a lot of formatting changes in here that's adding noise. Could we get this down to just the changes for post message? Maybe do a separate PR for formatting if there's new rules we want to apply?

Updated to remove the prettier changes.


Wip/sparql converter

Helper function to convert from ast table to sparql query for wikidata

Pull Request Test Coverage Report for Build 492

9 of 80 (11.25%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 81.596%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/helper.js
2
4
50.0%

lib/sparql_converter.js
6
75
8.0%

Totals

Change from base Build 488:
-0.7%

Covered Lines:
5873

Relevant Lines:
7021

💛  - Coveralls

Hi Ryan, please do not add any dependency to thingtalk. The library must be loadable in the browser (through browserify/webpack), hence node-specific modules like node-fetch are not allowed.


Rendering front matter field as file name

Is your feature request related to a problem? Please describe.
I'm currently using the unique ID method for naming my files. The challenge is when adding a new note from Time Ruler, I retrieve the file names (e.g.,<PHONE_NUMBER>1512) which makes it hard to get the context and select the note to add the new task.
Describe the solution you'd llike.
Have an option on the setting that alllows rendering a specific YAML field for the note name.
Describe alternatives you've considered
Additional context
Unique ID is a popular naming convention used across Obsidian users (especially with the Zettelkasten method).
P.S. Great plugin!

Added alias support to the changelog!


[WARN] fusermount: mount failed: Operation not permitted

Hi!
I'm trying to track down a permission issue with enroot start on RHEL/CentOS 7.6.
All the listed requirements seem to be satisfied:
# rpm -q glibc
glibc-2.17-260.el7_6.6.x86_64

# ./enroot-check_2.0.0.run --verify
Kernel version:

Linux version 3.10.0-957.27.2.el7.x86_64<EMAIL_ADDRESS>(gcc version 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC) ) #1 SMP Mon Jul 29 17:46:05 UTC 2019

Kernel configuration:

CONFIG_NAMESPACES                 : OK
CONFIG_USER_NS                    : OK
CONFIG_SECCOMP_FILTER             : OK
CONFIG_OVERLAY_FS                 : OK (module)
CONFIG_X86_VSYSCALL_EMULATION     : KO (required if glibc <= 2.13)
CONFIG_VSYSCALL_EMULATE           : KO (required if glibc <= 2.13)
CONFIG_VSYSCALL_NATIVE            : KO (required if glibc <= 2.13)

Kernel command line:

namespace.unpriv_enable=1         : OK
user_namespace.enable=1           : OK
vsyscall=native                   : KO (required if glibc <= 2.13)
vsyscall=emulate                  : KO (required if glibc <= 2.13)

Kernel parameters:

user.max_user_namespaces          : OK
user.max_mnt_namespaces           : OK

Extra packages:

nvidia-container-cli              : OK
pv                                : OK

and
# rpm -q squashfuse fuse-overlayfs
squashfuse-0.1.102-1.el7.x86_64
fuse-overlayfs-0.5.2-1.el7.x86_64

I can import a container just fine:
# ENROOT_SQUASH_OPTIONS='-comp xz -noD' enroot import -o /tmp/alpine.sqsh docker://alpine
[INFO] Querying registry for permission grant
[INFO] Authenticating with user: <anonymous>
[INFO] Authentication succeeded
[...]
Parallel mksquashfs: Using 40 processors
Creating 4.0 filesystem on /tmp/alpine.sqsh, block size 131072.
[==============================================================================================================================================================================================================================================================|] 105/105 100%

Exportable Squashfs 4.0 filesystem, xz compressed, data block size 131072
        uncompressed data, compressed metadata, compressed fragments, compressed xattrs
        duplicates are removed
Filesystem size 5030.47 Kbytes (4.91 Mbytes)
        91.86% of uncompressed filesystem size (5476.08 Kbytes)
Inode table size 2374 bytes (2.32 Kbytes)
        13.65% of uncompressed inode table size (17387 bytes)
Directory table size 4207 bytes (4.11 Kbytes)
        50.96% of uncompressed directory table size (8255 bytes)
Number of duplicate files found 7
Number of inodes 486
Number of files 73
Number of fragments 6
Number of symbolic links  324
Number of device nodes 0
Number of fifo nodes 0
Number of socket nodes 0
Number of directories 89
Number of ids (unique uids + gids) 1
Number of uids 1
        root (0)
Number of gids 1
        root (0)

But then (as root):
# enroot start /tmp/alpine.sqsh
[WARN] fusermount: mount failed: Operation not permitted
[ERROR] Failed to mount: /tmp/alpine.sqsh

The command that fails is in runtime::_do_mount_rootfs()
[WARN] + squashfuse -f -o uid=0,gid=0 /tmp/alpine.sqsh /run/enroot/alpine/lower
[WARN] fusermount: mount failed: Operation not permitted

Fuse and fusermount work fine on that host (especially as root), and I can run that very same command outside of enroot:
# squashfuse -o uid=0,gid=0 /tmp/alpine.sqsh /run/enroot/alpine/lower
# df /run/enroot/alpine/lower
Filesystem     1K-blocks  Used Available Use% Mounted on
squashfuse             0     0         0    - /run/enroot/alpine/lower

But I can't figure out where the EPERM in enroot start is coming from. Any hint to diagnose the issue and hopefully fix it would be much appreciated!
Thanks!

Yeah, unfortunately you can only start images directly on Linux >= 4.18.
This is because you need fuse support in user namespaces (https://github.com/torvalds/linux/commit/4ad769f3c346ec3d458e255548dec26ca5284cf6).
AFAIK RHEL 7.X doesn't have this patch, RHEL 8 might though.
In the meantime, you will have to unpack the image, and create a statefull container out of it:
enroot create alpine.sqsh && enroot start alpine

Note that you could also mount the image outside of enroot, either

As root on the loopback with a tmpfs overlay
Replicating runtime::_mount_rootfs() with fuse

Then you could use ENROOT_DATA_PATH=... enroot start ... to start it.
The difference is that you will have to cleanup/unmount after you're done with the rootfs since there are no namespaces in this case, and the above would require some privileges.

Aaah, I see, sorry I missed that. I'd ideally prefer the stateless, transparent mount option, but thanks for pointing out the missing kernel patch. And thanks for suggesting workarounds, I'll give them a try.

For the sake of completeness, and future reference, in case that helps anyone, I confirmed that:

RHEL/CentOS 7.6 (kernel 3.10.0-957) does not contain the patch
RHEL/CentOS 7.7 (kernel 3.10.0-1062) does not contain the patch
RHEL/CentOS 8.0 (kernel 4.18.0-80) does  contain the patch

Does enroot need a special argument to enable fuse? I met similar issue that enroot did not have /dev/fuse. I remember docker needs "--device /dev/fuse". I didn't see enroot manual mentions similar arguments.


[NFC][Concurrency] Minor cleanup for actor isolation.

Use warnUntilSwiftVersion(6) in safeToDropGlobalActor. Now that there's only one call-site of safeToDropGlobalActor, it doesn't need to be exposed in the ActorIsolation header, and it doesn't need to avoid warnUntilSwiftVersion to match constraint system diagnostics.
Remove an unused isPreconcurrency function in CSSimplify. The only caller of this function was removed in https://github.com/apple/swift/pull/68685.

@swift-ci please smoke test


docs: update environment variable tables for utilities

Description of your changes

This PR updates the environment variable documentation for the main page, and three utilities.
It also sets the default service name to service_undefined. Previously, the Tracer and Metrics utilities did not set the service name

[x] Update docs/index.md
[x] Update Tracer table
[x] Update Metric table
[x] Update Logger table
[x] Set default Service Name in Utility class
[x] Update Tracer class to use default service name
[x] Update Metrics class to use default service name
[ ] Extract isValidServiceName to Utility class
[x] Update unit tests

How to verify this change

Related issues, RFCs

Issue number: #724
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist

[x] My changes meet the tenets criteria
[x] I have performed a self-review of my own code
[x] I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have made corresponding changes to the examples
[x] My changes generate no new warnings
[x] The code coverage hasn't decreased
[ ] I have added tests that prove my change is effective and works
[ ] New and existing unit tests pass locally and in Github Actions
[ ] Any dependent changes have been merged and published in downstream module
[x] The PR title follows the conventional commit semantics

Breaking change checklist

[ ] I have documented the migration process
[ ] I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Last remaining task is to extract the isValidServiceName method to the Utility class.

Integration tests are passing: https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3470528039
Since @flochaz already approved the PR earlier, I'm going to merge this.


eid-mw: 5.1.15 -> 5.1.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/eid-mw/versions.
meta.description for eid-mw is: Belgian electronic identity card (eID) middleware
meta.homepage for eid-mw is: https://eid.belgium.be/en
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.1.16 with grep in /nix/store/8y3yx76q29yhi57p91s8c87zi7id8493-eid-mw-5.1.16
found 5.1.16 in filename of file in /nix/store/8y3yx76q29yhi57p91s8c87zi7id8493-eid-mw-5.1.16

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eid-mw

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8y3yx76q29yhi57p91s8c87zi7id8493-eid-mw-5.1.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eid-mw https://github.com/r-ryantm/nixpkgs/archive/bc8e50bf6a11afa9e9dc8c3912b8ef455a162819.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/bc8e50bf6a11afa9e9dc8c3912b8ef455a162819#eid-mw

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8y3yx76q29yhi57p91s8c87zi7id8493-eid-mw-5.1.16
ls -la /nix/store/8y3yx76q29yhi57p91s8c87zi7id8493-eid-mw-5.1.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

eid-mw

Maintainer pings
cc @bfortz @chvp for testing.

friendly ping @natsukium, please mark it as draft instead of closing next time: https://github.com/NixOS/nixpkgs/pull/290470#issuecomment-1959530280

I apologize. I'll be more careful next time. Thanks.


Updated transport.rb

We were using winrm 2.1.1 with Jruby <IP_ADDRESS>. We were getting the error running winrm  in SSL mode.Note that this works well in Negotiate and Plaintext mode.
Kindly refer the raised issue  for more details : Not working with Jruby in SSL mode Issue no:#249

Looks like we need t onil check the peer_cert earlier. Also, you only want to use getEncoded in JRuby.

closing in favor of #272


Don't fail with "impossible" compile error - fixes #1143

@dsyme for #1143 we run into a missing pattern match (see diff). I copied the match case from the outer pattern match and the compile error is gone. I'm not sure if this is the correct fix...
/cc @swlaschin
UPDATE: @dsyme suggested a better fix. PR updated

This looks good to me, the fix is very appropriate - we should always have been stripping units of measure here.
I wonder if we can add a test.  I know the original repro is complex though.


ENG-2396 Improve UI for workflow to configure default notifications

Describe your changes and why you are making these changes
This PR adds an additional checkbox in workflow settings page to allow configuring whether or not to use default notifications. This box has a link that opens up account page (in a separate tab) to show current notifications.
As a part of the PR, we moved notification's checkbox entry to its own component to avoid code duplication
Related issue number (if any)
ENG-2396
Loom demo (if any)
https://www.loom.com/share/af9658bc77f3461f9ca3783e8ec5cd3a
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Few nits:

There's a space between "settings" and the following period.
Is default notification settings a link? The text look like it, but it doesn't seem to be based on where you're clicking.
When you uncheck the default box, is what's populated there the default settings? I think it is, but I wanted to double check.

@vsreekanti

"Is default notification settings a link" Yes, it opens a new tab to the account page so that user don't lost the current session. I'm recording the browser tab and that's why it didn't show up.
"When you uncheck the default box, is what's populated there the default settings" that's a good point, for now we just show empty settings and user need to click '+' to add. It's indeed nice to just show the default settings when the user uncheck.

I think it's maybe a little confusing that most of the text is covered by the link. Instead, let's use and link the second instance of the word settings:

Use default notification settings. See settings for more details.

Let's create a backlog nice to have task for making it the default, but no need to prioritize right now.

@vsreekanti just to confirm on your suggesting putting the link:
Use default notification settings. See (settings)[link] for more details.

Yep!

I'm a little confused by this UI, but this is something we can address in the future.
It seems like there are three things that are addressed by this UI:

Notification Channel - i.e. slack or email, where do these go
Severity level - warning, error, success should send notification.
Reset selection to defaults.

The main thing that confuses me is severity level being a checkbox that doesn't let you select more than one item. Maybe we can try making it a dropdown and indent it 32px underneath the my_gmail integration? The trash can to remove is nice, can definitely keep that.
Next, use default settings is placed at the top of this section, but I'd imagine that this is something that users probably want to do last. Maybe this use default notification settings item can be a button that we show above the save button?

@agiron123 thanks for feedbacks

the dropdown still allows you to select slack / email based on the integrations you already have, is that what you are asking for?
would you suggest to move 'use default' to the botton? In this way when the user uncheck, the '+' button and the whole section will appear before this botton.
Which part of the level selector do you find confusing? The settings page is already content heavy so I slightly prefer not indenting, and not sure how the indentation helps clarify any information

Btw, while we keep these product discussion open, given codewise things are looking fine, I will merge everything to #975 so that I don't have to switch between branches to address any comments


Add initial support for concurrent jit-compilation, requested in #677.

Store the core tracer state within a thread-local object.
This is enough to make some simple tests pass, but very likely we also need to make the memoize caches thread-safe too.

Looks like a good start. We'll run into trouble if we start mixing traces from different threads. It might be a
good idea to label each trace with its thread id, so we can raise an exception in find_top_trace if we encounter traces from different threads.


normalization of the language data

Some languages have accents, etc. and they are commonly missing, so when trying to do something like this:
>>> parse_number('veintiun', lang='es')

it doesn't work, but doing this:
>>> parse_number('veintiún', lang='es')

it works. We should normalize the language data to avoid this kind of issue.

Hi thanks for pointing this issue out. I guess the best plan of approach is to normalise strings while creating the language files. Then in the main parser file also we pre-process and normalise the input string.
https://stackoverflow.com/questions/517923/what-is-the-best-way-to-remove-accents-normalize-in-a-python-unicode-string this seems to be a relevant discussion on the problem. Most of the solutions seem to suggest unidecode library (GPL license) , however a simpler version of the same library exists here exists with a less stringent license (artistic license).
There are other solutions using the default python unicodedata library  and considering ours is a pretty simple use-case , I will try this out first and in case there are issues we can then go with text-unidecode.

As you, as think is better to avoid using external libraries / dependencies if it's possible. :+1:

Just a side note: @arnavkapoor Really good work checking the dependency licenses. I think this is a topic often forgotten (or, in any case, I tend to forget about this) yet really important.

We did end up using the second result from here , which doesn't require an external library.
import unicodedata
def strip_accents(s):
   return ''.join(c for c in unicodedata.normalize('NFD', s)
                  if unicodedata.category(c) != 'Mn')

It seems to work in most of the case. More details here and here. Closing this issue for now as #27 adds the normalization.


add my screenshot

done

@Snehsk please can you merge my pull request !!

@Snehsk please look into this

I m talking about this one

@Snehsk now can you please check

@Snehsk now can you please check

Please delete previous image
Keep one image only.


Remove version key from role metadata

Ansible 2.0 seems to have gotten stricter with its parsing of role metadata. It's bombing on the version key in this role.
ERROR! 'version' is not a valid attribute for a RoleMetadata

The error appears to have been in 'roles/davidwittman.redis-1.0.6/meta/main.yml': line 2, column 1, but may
be elsewhere in the file depending on the exact syntax problem.

Remove the key and all is well again in Ansible 2.0 land.

Thanks for the PR @davekonopka. Are you getting this error when installing via ansible-galaxy? I'd like  to open an issue upstream for this as well.

This is working for me fine in RC2:
$ ansible-galaxy install DavidWittman.redis -p .
- downloading role 'redis', owned by DavidWittman
- downloading role from https://github.com/DavidWittman/ansible-redis/archive/1.0.6.tar.gz
- extracting DavidWittman.redis to ./test/DavidWittman.redis
- DavidWittman.redis was installed successfully
$ ansible --version
ansible 2.0.0 (detached HEAD cc98528ecb) last updated 2015/12/09 21:12:31 (GMT -500)
  lib/ansible/modules/core: (detached HEAD 135565c444) last updated 2015/03/13 18:20:34 (GMT -500)
  lib/ansible/modules/extras: (detached HEAD 4c0b7cb55a) last updated 2015/03/13 18:20:34 (GMT -500)
  config file =
  configured module search path = Default w/o overrides

I'm gonna close this for now, but let me know if you're still having issues and I can take another look at it.

Related: https://github.com/ansible/ansible/issues/13496

Thanks for taking a look at this and linking the Ansible issue. I wasn't aware of the version string being a workaround for ansible librarian. I've run into that very interdependency issue so I'm eager to see if this gets addressed upstream.


Include limits

For atoms, ets, ports and processes. We need to discuss about alarms though, because the value in itself is not enough.

Yes, it would be nice to have some kind of alarms. A value is useful, but only if the system we export metrics to does support them.

Awesome. Can you please take a look at how prometheus/statsd/others do alarms? Then all we need to do is to standardize on an API for the alarms, although it would most likely be part of telemetry_metrics and not here. :)


Fix usage of positional argument after named arguments

Scala 3.4.x fixes a bug, allowing to use positional arguments after named ones. These could have been misleading to users. The fix lead to failures of 3 Open Community Projects, one of them is this one. Link to build logs
Merging this PR and applying the fix would allow for further testing this project against latest versions of Scala 3

@WojciechMazur thanks for the PR, much appreciated :)


Update arf.json

We have started a new malware threat feed (REScure) which is accessible at :
homepage : https://rescure.fruxlabs.com/
Feedpath : https://rescure.fruxlabs.com/rescure_blacklist.txt
Feedpath : https://rescure.fruxlabs.com/rescure_domain_blacklist.txt
The feed is curated form an inhouse threat intelligence solution and is updated at every 6 hours. A blogpost detailing about this is mentioned here :
https://www.theprohack.com/2018/09/rescure-cyber-threat-intelligence-feed.html
Currently limited to only malicious IPs and domains, we will enhance this by adding IoCs such as malware hashes, et al in future.
Thanks !

Thanks!


Toast location

Can you add an option to open the toast from the button position, or from custom X,Y from the frame?

Updated. see this PR #22
You can use this in 2.2.0-SNAPSHOT: https://github.com/DJ-Raven/swing-modal-dialog#snapshots
It not support location related to another component.
But you can use the SwingUtilities.convertPoint method
// get the location of button cmdShow
Point location = SwingUtilities.convertPoint(cmdShow.getParent(), cmdShow.getLocation(), this.getContentPane());

// create toast option
ToastOption toastOption = Toast.createOption();

// set location
toastOption.getLayoutOption()
        .setLocation(location.x, location.y)
        .setDirection(ToastDirection.TOP_TO_BOTTOM);

// show toast
Toast.show(this, Toast.Type.SUCCESS, "Success message", toastOption);

Thanks, and the toastdirection is awesome!


libzma-5.dll not found

libzma-5.dll not found

https://tukaani.org/xz/xz-5.2.5-windows.zip
Put this into payload-dumper executable folder.

Could be resolved by building payload-dumper-go for Windows as static I think.

Either way, this should have been also documented in Requirements in README.md file ;-)


Music/transition not timed correctly after modifying night lenght

After modifying the lenght of night time, the music doesnt play at 7am but it plays somewhere around 4-5am or depending on the float you've set in the config it would play sooner. After the night finishes, there is no transition, yes the white screen appears but it takes about 5-10 seconds for the game to process that the night has finished. In that period your stuck in a limbo of 8am with no trader.

This works for me, just to make sure what is your time config

This works for me, just to make sure what is your time config

what?

Time modification works perfectly for me, can you give me your config

Time modification works perfectly for me, can you give me your config

Time.zip
heres my time config

Time.zip heres my time config

well of course it's gonna transfer 5 seconds late, you set the interval to 5 seconds
it waits 5 seconds then updates the time, which includes calculating when the night ends
gonna update the documentation but yeah, this works as intended as you were never meant to have 5 second time interval and only 1s and 0.75s if it was night

I guess just make sure not to go above 2 or something, it's still 2.25x slower than normal for night time
The time update process goes like this:

Set time to 0 (day starts)
Every interval add 2 seconds (check if its night time, if it is use night interval)
Set interval respectively (with the mod you change this)
Every x (x being interval you set with the mod) seconds update the time

I guess just make sure not to go above 2 or something, it's still 2.25x slower than normal for night time The time update process goes like this:

Set time to 0 (day starts)
Every interval add 2 seconds (check if its night time, if it is use night interval)
Set interval respectively (with the mod you change this)
Every x (x being interval you set with the mod) seconds update the time

The CurrentTime variable in Controller is an int, I can't really change the 2 seconds part to add decimals to it since it'll get rounded I could make my mod manage the time but that would need syncing between the game and my mod and I wouldn't know how to manage that (the actual update time method being a delegate doesn't help either)

alright, i have a question regarding some item names because i cant seem to find them. (pellet rifle,bug shell, auto shotgun and uzi)

They should be in the itemlog.log but if they arent just wait for me to eventually add them to the default config

They should be in the itemlog.log but if they arent just wait for me to eventually add them to the default config

they are not


installer finishes successfully but boot logo doesn't change

i replaced the provided bmp file with my own file in the unzipped folder then successfully ran the installer script, but it didn't change the boot logo.

 If its not compatible with current windows version then that needs to be made public on the download page. Wasted a whole day for nothing.

It's likely that you've all got older machines that do not handle UEFI correctly, and which will just run bootx64.efi rather than the one denoted in the boot entry, which HackBGRT doesn't handle right now from my testing of it The best solution for it right now is to forcibly take the custom EFI file from HackBGRT and replace bootx64.efi with it in the EFI System Partition.

works fine now


[DEV-9542] Update sdk and theme kit versions

@oleg-semyonov it is green 🎉
could you check it again please


[Bug]:

Mapbox Implementation
Mapbox
Mapbox Version
10.11.1
Platform
iOS
@rnmapbox/maps version
10.0.6
Observed behavior and steps to reproduce
Hi
I have followed the v10 setup steps: https://github.com/rnmapbox/maps/blob/main/README-v10.md
when I attempt to sign my app on code magic, I get the following error on the Set up code "signing settings on Xcode project" step:
Configure code signing settings
Searching for files matching /Users/builder/Library/MobileDevice/Provisioning Profiles/*.mobileprovision
Searching for files matching /Users/builder/Library/MobileDevice/Provisioning Profiles/*.provisionprofile
List available code signing certificates in keychain /Users/builder/Library/codemagic-cli-tools/keychains/11-05-23_q2jyl2j7.keychain-db
Searching for files matching /Users/builder/clone/**/*.xcodeproj
Failed to set code signing settings for<EMAIL_ADDRESS>

Build failed :|
Step 13 script `Set up code signing settings on Xcode project` exited with status code 1

Using these packages:
"react-native": "0.68.2",
"@rnmapbox/maps": "10.0.6"
we use the code magic cli for the provisioning profile.
locally my project builds fine for ios and android, just an issue with code magic ios signing. Please let me know if you require any more info.
Expected behavior
My signing profile should not fail if it does not have an xcode dependency
Notes / preliminary analysis
No response
Additional links and references

@thatop007 I'm not sure what codemagic.io is. So the .xcodeproj is a placeholder project, and not real Xcode project. That might confuse codemagic.io. you might just remove that before doing code sign as a workaround, or use patch-package or similar.
https://github.com/rnmapbox/maps/blob/main/ios/RCTMGL.xcodeproj/project.pbxproj


Add support for installing / running in a virtual environment

Some users are crazy about Virtual Environments. The isolation is interesting, and it would be nice to support that style of running.

This should always work, but lets test and add documentation.

@rmadsen-ks Virtual environments don't seem to work unless some of the changes discussed in this pythonnet issue are implemented: https://github.com/pythonnet/pythonnet/issues/1348. Ideally, adding the virtual environment folder path to the Python Path property within the Component Settings should allow the switch, but this currently crashes the Editor.
I added the suggested lines of code to PythonInitializer.cs to append the necessary virtual environment folder paths to PATH and PYTHONPATH, call PythonEngine.Initialize(), then set PythonEngine.PythonHome and PythonEngine.PythonPath afterwards.
Environment.SetEnvironmentVariable("PATH", pyPath, EnvironmentVariableTarget.Process);
Environment.SetEnvironmentVariable("PYTHONPATH", $"{pyPath}\\Lib\\site-packages;{pyPath}\\Lib", EnvironmentVariableTarget.Process);

PythonEngine.Initialize(false);

PythonEngine.ProgramName = Assembly.GetEntryAssembly().Location;
if (pyPath != null && SharedLib.IsWin32)
   PythonEngine.PythonHome = pyPath;
PythonEngine.PythonPath = Environment.GetEnvironmentVariable("PYTHONPATH", EnvironmentVariableTarget.Process);


[SEO]: Seo fixes and default configs

SEO titles in config
#57

This PR adds the feature to set nextSeo title titleTemplate in config and fixes the default seo image overrides.
Tasks

[x] set title and description in user config file config.js for default seo
[x] add titleTemplate and description to nextSeo property in config for users to modify.
[x] fixes:

[x] seo images being overriden
[x] wrong seo url paths
[x] support absolute url path for seo images

[x] remove nextSeo from layout
[x] update documentation about adding website url to support seo images for relative paths.

Notes
This has been fixed
There is no titleTemplate here as suggested in #57 comments. If we are setting a titleTemplate in config, then it appears twice for pages without a frontmatter title. This is because the title is set in config already and is never undefined.

@rufuspollock @olayway new commits for above fixes pushed plus added some documentation about setting authorUrl in user config (in siteConfig the default is flowershow.app which is important to change for users).


[build] Malformed Paths When Multiple Locations Are Found

Description
The auto-search mechanism of our Makefile malforms the LD_LIBRARY_PATH and the PKG_CONFIG_PATH if multiple matching locations exist.
For instance, in the example bellow, the LD_LIBRARY_PATH environment ends up with a whitespace character, because two matching locations were found:

Issue fixed in commit 0f1a8bf696129c92da81be2cf7b4f402b7c92a72.


cmake: fix fallthrough warnings with ccache

It turns out that we're getting compile warnings with arm-none-eabi-gcc 7.2.1 when used with ccache about implicit fallthroughs. By setting CCACHE_CPP2 we force ccache to look at the whole file not just the stripped version.
Fixes #12813, closes #12820.

@julianoes  I tried running this on my machine andt does not seem to help. If I build px4_fmu-v4_default, I still get the errors about implicit fallthrough

@julianoes I tried running this on my machine andt does not seem to help. If I build px4_fmu-v4_default, I still get the errors about implicit fallthrough

Maybe @dagar was right and I wasn't testing this correctly, let me check again.

@baumanta check again please.

@julianoes
Now it is fine. I don't get errors anymore

@dagar let's get this in.

A couple minor concerns.

This only works if entering through our Makefile. Anyone using an IDE with proper integration or standalone cmake will bypass it.
CCACHE_CPP2 is slower.
Why aren't we seeing this in CI where we have nearly everything running with ccache and a couple builds explicitly with ccache disabled.

True. However, I couldn't do it in cmake only. It didn't work.
Right, that's not optimal.
Yes, why not!? I want to understand.

Why aren't we seeing this in CI where we have nearly everything running with ccache and a couple builds explicitly with ccache disabled.

https://github.com/PX4/Firmware/pull/12820#issuecomment-527415694

@MaEtUgR @nicovanduijn maybe it makes sense to continue the discussion here, as this proposes a more reasonable solution.
I did a bisect and the warning appears for all commits after: [d41f72f092032c81f83be024d1fd92d4d8b82e37] Re-enable implicit-fallthrough warning

I did a bisect and the warning appears for all commits after: [d41f72f] Re-enable implicit-fallthrough warning

Aha! Still odd why it wasn't caught by CI.

Downloaded and installed newest ccache from https://launchpad.net/ubuntu/bionic/amd64/ccache/3.4.1-1
This fixed the issue for me on 16.04.

@jkflying let's add that to the ubuntu.sh script as well as the scripts in the Devguide. (I know it's annoying that we currently have two scripts).

@jkflying Confirmed:
wget http://launchpadlibrarian.net/356662933/ccache_3.4.1-1_amd64.deb
dpkg -i ccache_3.4.1-1_amd64.deb

fixes the problem instantly even without cleaning the cache.


[webview_flutter]How to set cache mode in webview_flutter?

in Android:
WebView.getSettings().setCacheMode(WebSettings.LOAD_NO_CACHE);
or How to only load webview from the network and still can get Local Storage?
I have tried clearCache() in dispose(). But Local Storage  was also cleared.
If there is a solution, pls let me know.Thanks!

@NRMrYang
This is more of a support question, so please ask the same on StackOverflow.
Check this link and see if it answers your question.
Closing from here.


Take advantage of @mixin in Laravel's code itself

Hi,
PHPStan's dev-master now supports @mixin annotation (https://github.com/phpstan/phpstan-src/commit/b02ee1444440ed995c17171c456feec2c56e0cb2). I've been told that Laravel's codebase uses this annotation heavily, so maybe Larastan could take advantage of it. Maybe we could delete some of Larastan's custom code if the only thing it does is describing Laravel magic that's also described by the @mixin annotation.
What I'd like to see happen:

Require phpstan/phpstan: ^0.12.20 (soon to be released, in a matter of days) so that people that would update Larastan but not PHPStan are not left without this functionality.
Go through extensions that describe Laravel's code that uses @mixin and try to delete them/reduce them.

(If you don't find any code in Larastan that can be deleted thanks to @mixin support, then ^0.12.20 doesn't have to be required.)
Thank you!

Also, one more idea - it's also possible that Larastan's describes some code from Laravel that would justify adding @mixin annotation to Laravel itself. In that case, you can just create a stub file for that class in Larastan with @mixin and it would work.

If I remember correctly, we are already using those mixings somewhere on the larastan codebase. We need to check.

It might be possible to simplify that code, or maybe somehow re-use this extension: https://github.com/phpstan/phpstan-src/blob/master/src/Reflection/Mixin/MixinMethodsClassReflectionExtension.php

Actually we were doing this manually. Here: https://github.com/nunomaduro/larastan/blob/master/src/Methods/Pipes/Mixins.php Looking for @mixin and @see in the class docs, and searching the missing method in those classes.
So, I guess we can remove that. I'll look into it :+1:

laravel-ide-helper package adds @mixin \Eloquent to the models docblock when you generate ide helper files.
\Eloquent is a class alias to Illuminate\Database\Eloquent\Model So basically it is adding a mixin for the class' actual parent. This is to have some auto-completion in the IDE.
And I found out this kinda breaks Larastan's extensions. Because when a missing method is found PHPStan will try to look for that method in \Eloquent because of the @mixin. And when our extensions run they are getting the Illuminate\Database\Eloquent\Model as the class reflection. So they are producing the wrong return types. For example we an extension to determine the return type of find method on the model. If the argument is iterable a collection should be returned, model otherwise. But with @mixin \Eloquent added, we don't know the real model name. We just have Model
But also laravel-ide-helper can be configured to write the mixin inside of the _ide_helper.php file. So I'd say we don't need to fix or workaround for this. We just need to notify people about this in upgrade guide or readme.

Why is Larastan even reading anything that laravel-ide-helperproduces? It should read the application source code written by its developers, no?

laravel-ide-helper modifies the model files written by the developers. It adds the @mixin to the models php docblocks.

But like I said it can be configured to write it to a dedicated file. _ide_helper_models.php In that case it'll not conflict with Larastan/PHPStan.

Can you explain the thing in https://github.com/nunomaduro/larastan/issues/555#issuecomment-624297770 in a bit more detail? What class has @mixin, what PHPStan sees vs. what it should see instead, what ClassReflection reports... maybe I can think of a solution, but I didn't get it what's exactly wrong from the comment. I'm not sure about the relationships between the classes.

I could add an exclude option to the mixin extension that would Larastan set.
Maybe I’ll figure out how to get the info we need even in the current system.

/**
 * @mixin \Eloquent
 */
class User extends \Illuminate\Database\Eloquent\Model
{}

This is an Eloquent model that the developer writes. @mixin \Eloquent part, might be added by the laravel-ide-helper package.
And \Eloquent is just a class alias to Illuminate\Database\Eloquent\Model
When we analyze User::find(1), MixinMethodsClassReflectionExtension runs and here $type is \Eloquent object type. And PHPStan loops thorough all extensions to find if the extension has that method and gets it if it finds. The problem is Illuminate\Database\Eloquent\Model is passed to the extensions as class reflection and not the App\User
Which is, expected :sweat_smile:
Now going through the code I realized maybe we can fix it in the extensions. Tell it to not work if the given class reflection is Illuminate\Database\Eloquent\Model Some of the extensions are already doing this. Like this, but found we don't do it for https://github.com/nunomaduro/larastan/blob/master/src/Methods/Pipes/Mixins.php

I just need to spend more time on this. Looks like it is Larastan's problem for now. Sorry to bother :sweat_smile:

I'm not sure how https://github.com/nunomaduro/larastan/blob/master/src/Methods/Pipes/Mixins.php works because it doesn't look like a traditional PHPStan extension, but I'm quite certain that the Eloquent\Model exclusion now needs to happen on PHPStan's side because it now handles @mixin itself.

https://github.com/nunomaduro/larastan/commit/bd84cae67f8c947e17e563c757858c9db72ebeab this seems to fix the issue. And everything else works as expected.

Looks like it still can cause issues, like #565 @ondrejmirtes Is it possible to have a blacklist of classes that should not be inspected in @mixin ?

@canvural Definitely, do you have time to contribute that to phpstan-src or shoud I do it?

@ondrejmirtes I can try to do it. Only MixinMethodsClassReflectionExtension and MixinPropertiesClassReflectionExtension should be changed I guess. And a new config parameter for users to fill in?

Yes, I'd call it mixinExcludeClasses. It doesn't even have to be documented :)

I am using laravel-ide-helper with the option to add a mixin tag to the Model files: For example:
<?php

namespace App\Models;

use Illuminate\Foundation\Auth\User as Authenticatable;

/**
 * @mixin IdeHelperUser
 */
class User extends Authenticatable
{ ... }

When running ./vendor/bin/phpstan analyse I am getting the following warnings
  Line   Models/User.php
 ------ --------------------------------------------------------------------
  14     PHPDoc tag @mixin contains unknown class App\Models\IdeHelperUser.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ --------------------------------------------------------------------

The phpstan.neon configuration I am using is the following:
includes:
    - ./vendor/nunomaduro/larastan/extension.neon
parameters:
    paths:
        - app
    level: 5
    checkMissingIterableValueType: false

I am not sure how to use the mixinExcludeClasses option propsosed by @ondrejmirtes to suppress these warnings. Could someone help me on this please?

@iraklisg If IdeHelperUser is a class in the global namespace, then it should be @mixin \IdeHelperUser

@canvural it makes sense but the @mixin IdeHelperUser  is automatically injected by ide-helper plugin.
I try to to add something like this in the phpstan.neon file but with no luck
parameters:
    ...
    mixinExcludeClasses:
        - Illuminate\Database\Eloquent\Model
        - App\Models

@iraklisg Then looks like it's an issue with that plugin.
You should try this I think:
mixinExcludeClasses:
    - IdeHelperUser

@canvural thank you for the reply. I tried IdeHelperUser as well as App\Models\IdeHelperUser but I am getting the same error.
The plugin creates an _ide_helper_models.php file that includes the following information
namespace App\Models{
/**
 * App\Models\User
 *
 * @mixin IdeHelperUser
 * @property int $id
 * ...
 }

Nevertheless, Larastan works pretty well, I just wanted to know if there is any way to suppress this warnings about @mixin contains unknown class App\Models\IdeHelperUser.

@iraklisg If you are writing to the _ide_helper_models.php file, why your model has the @mixin also? It shouldn't do that.

@canvural from the ide-helper docks

Alternatively using the --write-mixin (-M) option will only add a mixin tag to your Model file, writing the rest in (_ide_helper_models.php). The class name will be different from the model, avoiding the IDE duplicate annoyance.

Ah, now I understand.
Did you try to add it with leading backslash?
parameters:
	...
	mixinExcludeClasses:
	    - \App\Models\IdeHelperUser

Yes I tried this as well. As well as App\Models\IdeHelperUser
If it is of any help, the _ide_helper+models.php file includes the following
namespace App\Models{
/**
 * App\Models\User
 *
 * @property int $id
    ...
 * @mixin \Eloquent
 */
	class IdeHelperUser extends \Eloquent {}
}

I also tried \Eloquent, Eloquent but neither of these works
I understant that the actual class ``App\Models\IdeHelperUser` does not exists and phpstan correctly report it as an error. I was wondering if there is a way to disable this rule

Now I realized the problem. (I guess I still didn't woke up) It's got nothing to do with mixinExcludeClasses
I think you might want to read here and try to use scanFiles

@canvural I think you are pointing to the right direction. I used:
    scanFiles:
      - _ide_helper_models.php

Now I am getting a different error on another model
 ------ --------------------------------------------------------------------
  Line   Models/Application.php
 ------ --------------------------------------------------------------------
         Reflection error: Eloquent not found.

However, I am using larastan on an existing application that makes hard to track why is this happening. I will try to use larastan with ide-helper on a fresh Laravel application to see what's happening
Thank you

I don't think that you should use both Larastan and Laravel IDE helper. They're both trying to do the same job I don't think it makes sense combining them.

I don't think that you should use both Larastan and Laravel IDE helper.

Very well said.

@ondrejmirtes in a sense probably yes, they serve the same purpose. However with Laravel IDE helper you get nice auto-completion features in your IDE

@iraklisg Of course no one is telling you not to use IDE helper if you need to use it for your IDE. But you need to keep the generated classes out of sight for PHPStan.

@ondrejmirtes sure, both tools are helpful in the development process.
There is the option to use Laravel IDE helper without mixins (which caused the issues with PHPStan) and either generate the full PHPDocs or or write to a separate file _ide_helper_models.php with --nowrite option, but this causes some issues with duplicate class names.
For the time being, I opt to use the Laravel Idea plugin  (PHPSstorm) that offers auto-completion without needing to generate PHPDocs for models while avoiding the IDE duplicate annoyance.

@iraklisg Have you found a solution to use both Larastan and IDE helper? I would like to keep IDE helper to have auto-completion and Larastan to check the code during the CI process.

PHPStan has no interest in IDE helper-generated code. You just need to make sure it's not discovered by PHPStan via autoloading and other means: https://phpstan.org/user-guide/discovering-symbols

So by default I think it should work fine.


pydantic.error_wrappers.ValidationError: 1 validation error for PromptTemplate

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
context str = "abc"
query_str = "def"
    template = ("We have provided context information below. \n"
                "---------------------\n"
                f"{context_str}\n"
                "\n---------------------\n"
                f"Given this information, please answer the question: {query_str}\n")
    text_qa_template = Prompt(template=template)
    vector_store = WeaviateVectorStore(weaviate_client=client, index_name="LlamaIndex")
    index = VectorStoreIndex.from_vector_store(vector_store=vector_store)

    query_engine = index.as_query_engine(text_qa_template=text_qa_template)
    response = str(query_engine.query(query_str))

I am getting the error below in the above snippet of code:
pydantic.error_wrappers.ValidationError: 1 validation error for PromptTemplate
root
Invalid prompt schema; check for mismatched or missing input parameters. '"url"'
(type=value_error)
Can anyone please help me with the same? Thanks.

@vruti1121 the context_str and query_str variables should not be formatted, they will be filled in automatically by llama-index. Leave them as string variables :)

template = ("We have provided context information below. \n"
"---------------------\n"
"{context_str}\n"
"\n---------------------\n"
"Given this information, please answer the question: {query_str}\n")


onEndReached not getting called for ListView

Hey,
I'm using a ParallaxScrollView inside the renderScrollComponent of the ListView on ReactNative-Android . I've implemented onEndReached on the ListView to make sure more items are fetched as soon as the item list is about to end. But as soon as I add ParallaxScrollView in the renderScrollComponent, it renders only the first fold of items and never queries for more items. Can somebody help on this? I'm currently using React Native 0.30.0.
@jaysoo

Same problem here. is it really the problem?

Anybody working on it??? @jaysoo ?. 25 days have been passed. i am stuck with development. any other library which will help? @muskeinsingh  what did you use?

@waleedarshad-vf I kind of developed a way of my own. I started listening to the scrollListener on the Listview and Animated my View using a transform. I didn't use the ParallaxScrollView in my renderScrollComponent since it was only causing more problems than it was helping.
@jaysoo any help on this would be appreciated since what I did doesn't seem to be a clean solution. It's more of a hack around this.

@muskeinsingh for the time being can you share sample code from you solution which works or any other solution you suggest?

@muskeinsingh ? need your help

@alaycock how can i used onReachEnd? can you help me?

@jaysoo would you please advise?

Use this prop for ListView : onScroll:this.handleScroll.
HandleScroll looks like this.
handleScroll(event:Object){
this.scrollPostion =  event.nativeEvent.contentOffset.y;
}
It should return you the scrollPosition and then you can animate the view based on this. Hope this helps!

Thanks @muskeinsingh  this resolve the problem. I was suffering from this issue from last 27 days finally resolved it with your help. Thanks again. :)

Sure thing. @waleedarshad-vf
@jaysoo can we get some generic solution here?

@muskeinsingh #60 fixed the issue for us

Taking a look.

Sorry guys. How can i resolve this?
I had this code:
			<ListView
					ref="ListView"
					style={styles.container}
					dataSource={dataSource}
					enableEmptySections={true}
					renderRow={this.renderRow.bind(this)}
					renderScrollComponent={this.renderParallaxScrollView.bind(this)}
					renderFooter={ () => this.renderFooter() }
				/>

And in ParallaxScrollView
			<ParallaxScrollView
				onScroll={ (e) => this.handleScroll(e) }

On handleScroll:
	handleScroll(e) {
		let scrollPostion = e.nativeEvent.contentOffset.y;
		console.log("this.scrollPostion: ", scrollPostion)
	}

But with that scrollPosition i cant know when is the end. the maximum position does not match the height of the view neither with handleScroll: e.nativeEvent.contentSize.height or e.nativeEvent.layoutMeasurement.height...

@muskeinsingh any update about this?

Ok, i think is height problem. I load 30 items on first render and list only render the 10 first items...  @muskeinsingh can you help me to fix it?

Ok, i think is height problem. I load 30 items on first render and list only render the 10 first items... @muskeinsingh can you help me to fix it?

same problem, list only render 10 items


Library release removal request

Library name
iParol
Version to remove
1.0.0

Hi @YuenNicdao . You must delete the 1.0.0 tag from the library's GitHub repository before we can remove the release. I see that it has not yet been removed.
I'll provide instructions you can follow to do that:

Click the following link to open the GitHub page of the tag:
https://github.com/YuenNicdao/iParol/releases/tag/1.0.0
Click the Delete button on that page.
Click the I understand, delete this tag button.
Comment here to let me know that the tag has been deleted so that I can proceed with removing the release from Arduino Library Manager.

For the sake of a tidy repository, I'm going to close this due to lack of activity.
@YuenNicdao if you ever get around to deleting the tag, you are welcome to submit another release removal request.
I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.


grammar

@ryanmats some initial cleanup

Thanks @bshaffer I don't have permission to merge. One of the owners will have to do that.

thanks @elharo !


i18n(zh-cn): update rss.mdx

Description (required)
update rss.mdx
Related issues & labels (optional)

https://github.com/withastro/docs/pull/8632

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/rss.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


ffmpeg: reallocate output buffer dynamically

With FFmpeg we can't determine size of output buffer ahead of time for all codecs, so we need to reallocate it when needed instead of simply failing.

Thanks for the PR! I added a few comments for improvement ideas.

Thanks for the PR! I added a few comments for improvement ideas.

Where? 🤔

Thanks! I'll now import this PR internally and you may see some further clean-up commits appear here.

@tonihei Your commit https://github.com/androidx/media/commit/8750ed8de6469dc818007f2eb254df9ddbd52cc5 breaks this.
By using a variable to hold the buffer you keep a reference to the old buffer at the end of the function.
So that call outputData.limit(result); fails as the result value can be related to the new buffer size but outputData is still the lowersize buffer and you have Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (73728 > 65535) errors.

Should be fixed by https://github.com/androidx/media/commit/ae6f83d298424bd405372803bb8b206fc95a2d0f

@tonihei yes the fix works but the keep rules are not working :(
We need to also keep SimpleDecoderOutputBuffer else it's renamed and eventually merged and the GetMethodID fails.

@tonihei In this case just compile any app with ffmpeg with R8 and the extension will fail to load in the JNI_OnLoad so no need for a file to repro.
And I can send you a file that repro this by mail if you want for future reference too.
For the PR even after all those years I'm still far from a proguard/R8 expert.
So -keep class androidx.media3.decoder.SimpleDecoderOutputBuffer { *; }  Do work and fix this, but there's probably a more targeted solution to this.
As bonus questions since there's movement in that extension: Is there any chance that https://github.com/androidx/media/pull/707 be considered? And if yes is there any interest in a PR that adds resampling to ffmpeg extension so that hi res media that Android can't play can properly be downsampled to the max supported sample rate ?

Yes, if you could send a file that needs this logic to<EMAIL_ADDRESS>with "Issue #746" in the subject, that would be great so that I can just test it myself.

Done please confirm when I can delete the file.

And just in case I was not clear enough @tonihei ffmpeg extension in main is broken for any file in current state if you build with R8 as it fails to load the extension at all.

@Tolriq I can't reproduce the R8 failure I'm afraid. I'm testing on the latest main branch demo app in release mode with your example file. And everything works as expected (including the automated buffer resizing).
The existing proguard rule seems to ensure that the SimpleDecoderOutputBuffer class is kept already. I added
-whyareyoukeeping class androidx.media3.decoder.SimpleDecoderOutputBuffer

to get an explanation for why this class is kept in my build and the output directly references the existing rule:
androidx.media3.decoder.SimpleDecoderOutputBuffer
|- is referenced from:
|  java.nio.ByteBuffer androidx.media3.decoder.ffmpeg.FfmpegAudioDecoder.growOutputBuffer(androidx.media3.decoder.SimpleDecoderOutputBuffer,int)
|- is referenced in keep rule:
|  [...]/media/libraries/decoder_ffmpeg/buildout/intermediates/consumer_proguard_dir/release/lib0/proguard.txt:9:1

Could you check that the Ffmpeg proguard rules are included in your build? (maybe you need to clean caches/builds and try again?)

@tonihei The rules are included I'm using R8 with full mode and version "8.2.34"
In that mode the SimpleDecoderOutputBuffer is renamed and merged leading to the issue.
Maybe it's an R8 issue and the fact that the class is passed as a param should ensure it's kept, but from my understanding of R8/Proguard there's no guarantee about that with the current rule.
The rule
-keep class androidx.media3.decoder.ffmpeg.FfmpegAudioDecoder {
  private java.nio.ByteBuffer growOutputBuffer(androidx.media3.decoder.SimpleDecoderOutputBuffer, int);
}

Just implies that the class and function is kept nothing about the parameters.
And in the code we do reflection with
  growOutputBufferMethod =
      env->GetMethodID(clazz, "growOutputBuffer",
                       "(Landroidx/media3/decoder/"
                       "SimpleDecoderOutputBuffer;I)Ljava/nio/ByteBuffer;");

That explicitly require the type and name to be kept.
I can open a question on R8 team about this, and come back here if you want their confirmation.

Let me try the full mode too (that wasn't enabled in my test I believe)

@tonihei yes it works with:
# This method is called from native code
-keep, includedescriptorclasses class androidx.media3.decoder.ffmpeg.FfmpegAudioDecoder {
  private java.nio.ByteBuffer growOutputBuffer(androidx.media3.decoder.SimpleDecoderOutputBuffer, int);
}

Great, will send a fix for this then! Thanks for your help :)

May I ask again some help on https://github.com/androidx/media/pull/369 then ? ;) Kills me to no be able to provide the test file to get this merged.

May I ask again some help on https://github.com/androidx/media/pull/369 then ?

I think this fell through the cracks a bit because we were waiting to see if there is a way to produce a test file for unit tests.


GH-40448: [CI][Dev] Run pre-commit

Rationale for this change
We have pre-commit configuration but it's not used in CI.
What changes are included in this PR?
Run pre-commit in CI.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #40448

Yes. I want to do it if nobody objects it.

The pre-commit step is now taking hours on most CI runs. Can you take a look @raulcd @kou ?
Example: https://github.com/apache/arrow/actions/runs/8412061637

I've opened #40791 for it.


Rename id in Region

The id field in the Region message is confusing
https://github.com/GreptimeTeam/greptime-proto/blob/ad0187295035e83f76272da553453e649b7570de/proto/greptime/v1/meta/route.proto#L82-L89
As this comment points out, it is actually the region number, not the region id. We should rename this to number or something else.

#44 fixes this


Can't remove Windows package (application)

Description
Briefly describe the issue
Can't remove Windows package (application)
Chef Version
Tell us which version of chef-client you are using (see below for Server+ChefDK bugs).
Chef-client v12.7.2
Platform Version
Tell us which Operating System distribution and version chef-client is running on.
Microsoft Windows Server 2012 R2 Standard
Replication Case
Tell us what steps to take to replicate your problem.  See How to create a Minimal, Complete, and Verifiable example
for information on how to create a good replication case.
In my chef recipe:
package 'Microsoft Visual C++ 2012 Redistributable (x86) - 11.0.60610' do
 	action :remove
end

Client Output
The relevant output of the chef-client run or a link to a gist of the entire run, if there is one.
Mixlib::ShellOut::CommandTimeout: windows_package[Microsoft Visual C++ 2012 Redistributable (x86) - 11.0.60610] had an error: Mixlib::ShellOut::CommandTimeout: command timed out:
       ---- Begin output of start "" /wait /d"C:\ProgramData\Package Cache\{95716cce-fc71-413f-8ad5-56c2892d4b3a}\vcredist_x86.exe  " uninstall  & exit %%%%ERRORLEVEL%%%% ----
       STDOUT:
       STDERR:
       ---- End output of start "" /wait /d"C:\ProgramData\Package Cache\{95716cce-fc71-413f-8ad5-56c2892d4b3a}\vcredist_x86.exe  " uninstall  & exit %%%%ERRORLEVEL%%%% ----

       ProcessId: 3248
       app_name: C:\Windows\system32\cmd.exe
       command_line: cmd /c "start "" /wait /d"C:\ProgramData\Package Cache\{95716cce-fc71-413f-8ad5-56c2892d4b3a}\vcredist_x86.exe  " uninstall  & exit %%%%ERRORLEVEL%%%%"
       timeout: 600

The debug output (chef-client -l debug) may be useful, but please link to a gist, or truncate it.
Stacktrace
Please include the stacktrace.out output or link to a gist of it, if there is one.
NOTE: CHEF CLIENT BUGS ONLY
This issue tracker is for the code contained within this repo -- chef-client, base knife functionality (not
plugins), chef-apply, chef-solo, chef-client -z, etc.

Server issues
ChefDK issues
Cookbook Issues (see the https://github.com/chef-cookbooks repos or search Supermarket or GitHub/Google)

'/quiet' option should be added, i.e. something like that:
command_line: cmd /c "start "" /wait /d"C:\ProgramData\Package Cache{95716cce-fc71-413f-8ad5-56c2892d4b3a}\vcredist_x86.exe  " uninstall quiet   & exit %%%%ERRORLEVEL%%%%"

Some applications has a QuietUninstallString key in registry. Value of this key contains command for quiet uninstall application and may be used too.

Does this particular program create a QuietUninstallString registry key? Do you know what kind of installer vcredist_x86.exe is?

I don't remember it, but I can say that we check both keys - UninstallString and QuietUninstallString - and if we have one of them, we use it for delete application (for UninstallString we use /quiet parameter)

This should be fixed by #5849 and in Chef 13.0.13+ or so.


General Improvements

General Improvements
Update map data, loading text on the home page, removed some misc console.log statements, and cleaned up a few variables.

Note: in the future, we should probably use the API instead of src/data/maps.json

.deploy


TextInput AutoFocus Prop Causes Jest to Crash

Reproduction Steps and Sample Code
Broken Test File
// __tests__/Sample-test.js
import React from 'react'
import 'react-native'
import { TextInput } from 'react-native'

const mockFunction = () => {return}
const mockValue = 'value'

test('renders correctly', () => {
  const tree = renderer
    .create(
        <TextInput
          autoFocus
          multiline
          onChangeText={mockFunction}
          value={mockValue}
        />
    )
    .toJSON()
  expect(tree).toMatchSnapshot()
})

Broken Jest Output
 FAIL  app/components/__tests__/Sample-test.js
  ● Test suite failed to run

    ProcessTerminatedError: cancel after 2 retries!

      at Farm.<anonymous> (node_modules/worker-farm/lib/farm.js:81:25)
      at Array.forEach (native)
      at Farm.<anonymous> (node_modules/worker-farm/lib/farm.js:75:36)
      at ontimeout (timers.js:386:14)
      at tryOnTimeout (timers.js:250:5)
      at Timer.listOnTimeout (timers.js:214:5)

A worker process has quit unexpectedly! Most likely this is an initialization error.

Working Test File
// __tests__/Sample-test.js
import React from 'react'
import 'react-native'
import { TextInput } from 'react-native'

const mockFunction = () => {return}
const mockValue = 'value'

test('renders correctly', () => {
  const tree = renderer
    .create(
        <TextInput
          multiline
          onChangeText={mockFunction}
          value={mockValue}
        />
    )
    .toJSON()
  expect(tree).toMatchSnapshot()
})

Working Jest Output
 PASS  app/components/__tests__/Sample-test.js
  ✓ renders correctly (303ms)

Additional Information
Not 100% sure whether this was a bug with react-native or Jest, but just wanted to make you guys aware. Up until now, I am able to run the app properly without any errors, only tests fail. I will keep digging and see if I can find any other side effects.

React Native version: 0.45.0
Platform: both
Development Operating System: macOS

Relevant discussion on the jest repo
https://github.com/facebook/jest/issues/3707

The mentioned workaround in here https://github.com/facebook/jest/issues/3707#issuecomment-311169259 worked for me. In the meantime the issue is being fixed ;)


Guests data?

In certain cases, even guests have their data stored (e.g. contact forms), I guess we'd need to show the agreements as well.

That's an easy one for our forum, as we have completely disabled guest posting. But I suppose since the server normally logs all accesses, they need to be presented the agreement anyway because their IP address may be logged. Probably easier just to disable access logs, in that case.

I don't remember any personal data (permanent) logging for guests in ElkArte, apart when the guest creates a post.
If the server does logging, then this is something currently outside of the scope of these issues.
For the record:
https://www.whitecase.com/publications/alert/court-confirms-ip-addresses-are-personal-data-some-cases

Just delete the guest posting option... I never allowed it in my forums... it is unsafe also...
I can live without it...


it prints undefined

when i use the example code and put my token it prints undefined.
same with other functions it prints undefined or empty maps

I ran into the same problem. The constructor doesn't call the login method so nothing happens. Here's what I did to get it working. Note that the login process is asynchronous, after calling login you're not logged in yet, as the library is waiting for the auth response to come back from SLOBS. You'll need to check slobs.getConnected() until it becomes true, and then you can begin calling the other methods.
const slobs = new SlobsJS();
slobs.login(config.api.url, config.api.token);

//@todo wait until slobs.getConnected() returns true, then issue next command

console.log(slobs.getStreamingStatus());

Ideally, this module should raise events for connect/disconnect events on the SockJS connection to the host. Then we can just add a listener for the event and issue our calls after that.

can you provide me a sample code of how to wait for it returns true?


Feature/expression to string

Purpose
Adds a new function called ast_expression_tostring which does exactly what it says on the tin.
List of changes

Fixes a load of incidental memory corruptions.
Also added functions for:
ast_number_tostring
ast_primary_tostring

Coverage decreased (-1.6%) to 64.089% when pulling f3802c813b035709fd10e87bdf3a6103a0c19c47 on feature/expression-to-string into b392ad30be92546d41d5c5a56cdb44847ec30ddd on master.

Coverage decreased (-1.6%) to 64.064% when pulling 37d0a29a4778516e96d411ffbd834176038bf2b5 on feature/expression-to-string into b392ad30be92546d41d5c5a56cdb44847ec30ddd on master.

Coverage increased (+1.1%) to 66.772% when pulling 2ad06f7ec9e7afb6df8ae9e0c4395bf49fc99069 on feature/expression-to-string into b392ad30be92546d41d5c5a56cdb44847ec30ddd on master.


Accessing OSM via HTTPS fails

When accessing OpenSenseMap via HTTPS it doesn't load data.
14:02:25.352 Blocked loading mixed active content "http://opensensemap.org:9000/boxes?date=&phenomenon="1 angular.js:11442:6
To get around this, first ensure that the service on port 9000 allows HTTPS.
Then use a protocol relative link "//opensensemap.org:9000".
The proper way of fixing this, would actually be to redirect any non HTTPS queries to HTTPS and no longer support plaintext communication.

Thanks for openinig the issue.
We are currently working on a solution to fully supporting tls encrypted communication for both the page and the api.
For now, you have to be a little patient. HTTPS is coming soon.

The page and api is now accessible over https


Implement AWS SDK v2 support

Fixes #147

@ipapapa ready for review

also, add a test for v2 operations?

It seems there are some comments in some places, I assume this is a WIP? Has the PR been functionally tested? cc'ing @sumanth-pasupuleti.


Added testing and data standardization

Added the ability to check if the data is valid before pushing package live.
Fixes #29
Fixes #31
<3 @NikhilNamal17

Used jest as a Dev dependancy to verify if quotes are valid


Image getting squeezed

Hi everyone, thanks for the great project!
I'm struggling to understand why some images are getting squeezed when piping through imagor.
Here is my url:
https://imagor-h3bghbwoxq-uc.a.run.app/gkqCMJllLkhbQHEVpeFiznJq7nI=/400x0/https://storage.googleapis.com/floki-item-images/34049.png
I'm basically resizing every image to 400x0 (no filters or other stuff applied), and I'm getting this strange image. A lot of other images are working fine.
Am I missing something here?
Imagor Version: 1.4.1
Original image:

Final (bugged) version:

Thanks!

Something that happened to me was that I replaced the original image once and with another different one and the service was still returning the processed image from the first image because the path and filter were the same. Just something to check if you can give the image a different name, you can remove the cached processed image, or add a filter (for example 400x1) that is different and see what happens

I tired the above image and it seems to be working fine:
http://localhost:8000/unsafe/400x0/https://storage.googleapis.com/floki-item-images/34049.png

gives the following:

If this is cache related, you may do a quick test by adding a dummy filter (any unrecognisable filter would become no-op) such as ts(1677837918415)


Sync published with master

Sync published with master

Deploy preview for docsdocker ready!
Built with commit 6cc323e93533d82b89e5417cfc9883cc69b568cb
https://deploy-preview-9003--docsdocker.netlify.com


site/${referer:1}/ doesn't appear to work

Just installed this. Looks nice. The default rule site/${referer:1}/ does not appear to work. The file just gets dumped in my Downloads directory like normal. The rule is enabled and at the top. I disabled all other rules. Still doesn't work.
The other rules like for archives do seem to work fine.
I also tried to make my own rule for a specific site like this:
Referrer URL: .cdn.mywebsite.com.
Destination Path: mywebsite-downloads/
That also did not work. File just goes to the Downloads directory. What am I missing here?

it doesn't handle all cases, the idea is when you are at drive.google.com for example and press rightclick->download to a file, it will go to site/drive.google.com/filename.ext. I just checked and it works as expected

Give me more details to reproduce, please

I just downloaded a file from my google drive. The extension rule did not work. Here it is:

I figured it out. You are using referer instead of referrer in your default rule. I just uninstalled and reinstalled the extension and it's still there. You should get that fixed because it's not gonna work out of the box.

https://github.com/unintended/download-organizer-chrome-extension/blob/727f8616b02b1c45af5092734ea6e6e547e92957/options.js#L10

This is perfect, thank you a lot!


Newer pyenv version used after reloading

Testing #23114
I have several versions of Python installed with pyenv including 3.6.15, 3.7.17, 3.11.8, and 3.12.2.
I set the local version of pyenv in my workspace to 3.7.17, but after I cleared the cache and refreshed, the recommended/selected version of pyenv was 3.12.2.

Thanks for this, I borrowed Anthony's macOS and we were able to fix the issue.


go1.7: parsing package:  ... unknown version: v1

Started getting this after updating to go1.7:
2016/08/18 14:31:01 parsing package: type-checking package: client.go:9:2: could not import io (reading export data: /usr/lib/go/pkg/linux_amd64/io.a: unknown version: v1io'$GOROOT/src/io/io.go*SeekStart*%Seek)

I tried to rebuild jsonenums and update golang.org/x/tools/... but no avail.

Is this still reproducible?


Preview enhancements

The preview is currently just using most of the widget demo.
It needs some additional widgets, windows and other demo stuff so that you can get a better handle on just how the theme configuration is working.
In addition, it would be nice if you could watch the demo change as you tweak the settings.

Tasks

[ ] Side-by-side preview to actively update the GUI theme
[ ] Enhance font settings to allow for easier configuration from the preview menu.


Handle customers with inactive accounts during sign in / creation / password reset

Test Plan (Steps to test):

Attempt to sign in with a known disabled email —<EMAIL_ADDRESS>works — confirm you get the activation email
Same as above for creation
Same as above for reset password
Now try all three of those with a know active email / account
Try resetting the password of an email that doesn't exist
Try creating an account that already exists

@mcat Recaptcha hadn't been set up for that domain. I've updated the settings, and you can now reset passwords.

I've added a 5s timeout, after which you are returned to the Sign In page.

@mcat Code scans have been addressed.


Link to 2.13 PDF is titled for 2.12

Description
PDF download link for Zowe Documentation 2.13 leads to a PDF titled 2.12
Pages to Update
https://docs.zowe.org/
Screenshots

Expected behavior
The web link should take me to a V2.13 PDF
Additional context
Documentation link (https://docs.zowe.org/v2.12.x/getting-started/overview) for V2.12 PDF redirects to a "Page Not Found" as well.

Hi Rafael,
I did some digging and it seems https://docs.zowe.org/zowe-docs-v2.12.x.pdf is a broken link. Interestingly, https://docs.zowe.org/zowe-docs.pdf points to the  Zowe v2.12 docs. Perhaps that link always points to docs for the previous version of Zowe.
I hope this helps you. Happy New Year!
Andrew

Hi Rafael, I did some digging and it seems https://docs.zowe.org/zowe-docs-v2.12.x.pdf is a broken link. Interestingly, https://docs.zowe.org/zowe-docs.pdf points to the Zowe v2.12 docs. Perhaps that link always points to docs for the previous version of Zowe.

@RafaelQRafael @Andrew-J-Metzger -- the zowe-docs.pdf link should point to the PDF for the latest Zowe release. Created a PR to update the PDF file to include the correct title.
Thank you for noticing!


The default console logging performance is abysmal

I took a file new ASP.NET Core 2.1 API project on my dev box and hit it with wrk in various scenarios. This was in release mode and I didn't publish so it was using the Development environment. Here's the wrk command I used:
wrk -c 100 -t 10 -d 10 http://<IP_ADDRESS>:8080/

env: ASPNETCORE_ENVIRONMENT=Development
The results (RPS numbers):

Scenario
RPS

No changes to template
166

No loggers
13271.84

With null logger
10785.37

With debug logger
10069.20

This is only a problem in development.


Update CHANGELOG.md

Hi @mkarunan @dlangbe
Could you please check if there is any missing content that needs to be supplemented?

I guess it should be targeted for release-staging-6.1 branch.


feat(server): allow !Send Servers

Until this commit, servers have required that Service and their
Future to be Send, since the server needs to spawn some internal
tasks to an executor, and by default, that is tokio::spawn, which
could be spawning to a threadpool. This was true even if the user were
certain there was no threadpool involved, and was instead using a
different single-threaded runtime, like
tokio::runtime::current_thread.
This changes makes all the server pieces generic over an E, which is
essentially Executor<PrivateTypes<Server::Future>>. There's a new set
of internal traits, H2Exec and NewSvcExec, which allow for the type
signature to only show the generics that the user is providing. The
traits cannot be implemented explicitly, but there are blanket
implementations for E: Executor<SpecificType>. If the user provides
their own executor, it simply needs to have a generic impl<F> Executor<F> for MyExec. That impl can have bounds deciding whether to
require F: Send. If the executor does require Send, and the
Service futures are !Send, there will be compiler errors.
To prevent a breaking change, all the types that gained the E generic
have a default type set, which is the original tokio::spawn executor.

cc @carllerche

A very clever approach. I wonder if it can be simplified a bit, while maintaining the same strategy.
The goal is to keep the tasks that are spawned private while being able to pass in either a Send executor or a !Send executor.
Perhaps one strategy might be to define:
pub trait HyperExecutor<S, B, I, N, E, W>: Executor<H2Stream<S::Future, B>> + Executor<NewSvcTask<I, N, S, E, W>>
where S: Service,
           B: Payload
           W: Watcher<I, S, E>,
{
}

If H2Stream and NewSvcTask are private, it should be impossible to implement HyperExecutor, but making HyperExecutor public would allow the trait to be clicked in the docs and the trait could be documented to explain how it works and what the user should pass in.

Unfortunately, two traits are needed, since some cases don't require a NewService to even be in scope (such as Http::serve_connection(io, svc)).

If there is a strong reason to have two traits, so be it.


Is there any way to parse the output of a build to enable "jump to error"

One of the most useful features of editor-build integration is to enable immediate access to files with errors or warnings from the build output.
This extension doesn't seem to provide this - can it be added?

This is definitely a feature I want to add. It will take a bit of work, as reliably parsing the error output from the different compilers can be difficult. Some compilers (such as Clang) offer machine-parsable output options, so that will be a good place to start.

I've got it on Windows using a Visual Studio CMake generator.
The tips is to define a custom task in tasks.json that runs cmake --build and specify '$msCompile' as problemMatcher
{
	"version": "0.1.0",
	// cmake --build build
	"command": "build.bat",
	// Show the output window only if unrecognized errors occur.
	"showOutput": "silent",
	// no args
	"args": [],
	// use the standard msCompile problem matcher to find compile problems
	// in the output. cmake must use a Microsoft Generator
	"problemMatcher": "$msCompile"
}

As you can see, when the task is executed, the output is analyzed and you can navigate to the warnings and errors

For clang or gcc you can define  your own problemMatcher based on regexp, you can find an exemple with gcc here
Hope this can help you...

Thanks for the info! That'll definitely help. I'll play around with it and see what I can make work.

I've been working on a kind-of solution on the feature/diagnostics-parsing branch. Rather than make a problem matcher, I parse the build output when running the cmake.build command.
I wish that it were possible to use a vscode command in place of the "command" on a task, rather than the name of an external program. The cmake.build command does quite a bit more than simply invoke cmake --build build, and I'd like to be able to use the problemMatcher functionality in conjunction with the custom command. Any opinions on which design would be better?
Parsing the output of GCC and Clang seems to work pretty well, although I don't have quick access to a Windows machine where I can test the MSVC output parser (but it should work). Any MSVC users available to give it a try?

I just try it,
It seems there is a little problem in the MSVC Regex, I'll fix it today and send you a PR.

This should be fixed as of 0.3.0. Thanks for the help!

Is parsing the output hard-coded into the sources? What if I need to parse an unknown (even non-C) compiler output? When I compile via Run Build Task, I add an appropriate problem matcher to tasks.json and everything works. What about CMake tools? Impossible?

At the moment, there is not, unfortunately.

I'm quite new to cmake tools, so excuse me for a dumb question: why to invent your own build system (with custom problem parsers etc.) but not just integrate with vscode build tasks?

Early on I tried to do tasks.json integration, but there was a strong impedance mismatch between what tasks.json supported and what CMake required. I haven't taken a look for a while, so that may have changed, but it has in the past not been sufficient to run builds as required.

Does jump working for now? I remember it used to work. But not now for me.