📦 NEW: Providing warning on invalid block name — FIX #28

This PR tries to approach issue #28.
To be on the safe side and cover all possible scenarios I started with checking where the user provided blockName is used and what are the limitations of each case:

PHP function names:

A valid function name starts with a letter or underscore,
followed by any number of letters, numbers, or underscores. (PHP Manual)

Gutenberg's registerBlockType function name argument:
'Block names must (...) include only lowercase alphanumeric characters or dashes,
and start with a letter.'

wp_enqueue_script handle: - it simply has to be a non-empty string

Gutenberg's block title - it has to be a non-empty string too

Suffix for .wp-block-cgb-block-${blockName} CSS class:

In CSS, identifiers (including element names, classes, and IDs in selectors)
can contain only the characters [a-zA-Z0-9] and ISO 10646 characters U+00A0 and higher,
plus the hyphen (-) and the underscore (_)" (W3C)

Now, when we sum up all the above we can come to a conclusion that:

blockName's first character has to be a letter.
blockName can contain spaces (ie: 'my awesome block') as they will be replaced by hyphens.
blockName can contain uppercase letters as it will be converted to lowercase anyway.
blockName shouldn't contain underscores(_) as they are valid in php, but will cause errors when we are trying to register our block
starting with 2nd character: blockName can contain dashes (-) [thanks to: <% blockNamePHPLower %>]

Having this in mind I think that following regex should suffice to do the job: /^[a-z][a-z0-9-]/
As I mentioned spaces and uppercase letters are filtered anyway, so I think it's better to put the code after the formatting blockName instead of adding it into regex.
Wow, quite a long output for such a short regex, but hopefully it's good enough.
Cheers 🍻

Pleasure is all mine and I'm glad I was able to put my 2 cents into this cool project. Will do my best to contribute more often 👌👍

@wpjsio ok, tested, it all looks good. Thanks a lot.
I welcome more contributions from your end, take a look at #11 Roadmap for 2.0.
Also, I'd appreciate if you keep the git commit log in line with https://gist.github.com/ahmadawais/815ea20134cf4616a6b2a965eb08f716
Merged. Thank You! 😇
Peace! ✌


Make tinygo Plugin a Closure

Using a first class function definition, as opposed to an interface, provides greater flexibility and reduces makes templating simpler.
If a plugin/template author wishes to use a struct to attach state to their function they are still free to do so.
It is not however possible currently to supply just a function matching the appropriate signature.
// The Plugin interface is all that needs to be implemented by an E2 Core plugin.
type Plugin interface {
	Run(input []byte) ([]byte, error)
}

to
type Plugin func(input []byte) ([]byte, error)

This also simplifies template handling on the builder side since we no longer have a hard dependency on the name and shape of the target plugin.
Lastly this arrangement would more closely align with the javascript and typescript sdk.

*This change should be applied to rust as well for the same reasons stated for tinygo


Refactor for easier adding of learn modules

As (mostly) discussed w/@rabwill, this allows adding features which display Graph data immediately after login without the need to push a button. Previously in order to call the Graph during the initial page load required modifying displayProfile() in ui.js, which meant, for example, adding a call to displayFiles() to displayProfile() in my module where I want to display a list of OneDrive files on load.

Auth no longer calls ui.js and graph.js functions; it is more self-contained
displayProfile() is now displayUI() and there's a logical spot to add more display logic
No longer saves user profile from the Graph in session storage -- was this being used by a downstream project?
Rather than hammer msal.request from graph.js I added a small function ensureScope() to auth.js. IMO this is cleaner and I added a bit of logic to avoid duplicate scopes being added.
Code is shorter than before! (slightly)

Love everything about this! We need to make some changes in the document and I don’t see why we cant merge it after that! Thanks for picking it up 🥳


call underlying os.Hostname instead of the entire hostInfo gopsutil call

Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[x] I have run make install-tools and have attached any dependency changes to this pull request
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Codecov Report
Patch coverage has no change and project coverage change: +0.14% :tada:

Comparison is base (3013b97) 66.28% compared to head (a0d6231) 66.43%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   66.28%   66.43%   +0.14%
==========================================
  Files         118      118
  Lines       13390    13388       -2
==========================================
+ Hits         8876     8894      +18
+ Misses       3924     3904      -20
  Partials      590      590

Files Changed
Coverage Δ

src/core/environment.go
52.52% <0.00%> (+0.16%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Round Restart Vote Percent Required

Due to the addition of the abstain option by default, round restarts (which require like 60 percent iirc) are now commonplace instead of shuttle. This has lead to many a nukie or syndie round - my own included, I count three times since the change - being cut short because a few people too many were dead.  I would like it to be 80 or 90 percent: if the round is DRASTICALLY ruined it should happen, otherwise not at all. If there's no possibility of shuttle, I mean, as I believe that is the intended purpose.
Cool, thanks

which require like 60 percent iirc)

It's 70%.
Having to sit there waiting for the engis to finish their building their own shuttle for 30 minutes also sucks for example. Could try 80% but I'd rather have the odd round cut too short than extend many like before.

which require like 60 percent iirc)

It's 70%.
Having to sit there waiting for the engis to finish their building their own shuttle for 30 minutes also sucks for example. Could try 80% but I'd rather have the odd round cut too short than extend many like before.

Rounds are cut short way too often at the moment. Often before nukies even have a chance to end the game.

If it's nukies specific just make it not able to be restarted when the nuke is on for the first time.

In my experience when rounds are cut short because of a voting passing, it was well deserved.
Considering how often votings are made and from those, how many do pass, is it too often? Maybe we could run a short poll on the discord about it


Hyperparameter tuning benchmarks

Have a simple starter benchmark for comparing different hyperparameter optimization systems e.g. from Google, SigOpt, .... and open source efforts like https://github.com/kubeflow/katib
Supporting orgs: Cisco

Task 0: Enumerate some candidate opensource efforts and algorithms for hyperparameter tuning algorithms that we could consider (in addition to commercial software e.g. SigOpt, Google)
Task 1: Enumerate  hyperparams for the workloads we might want to tune and their well known values from practice e.g. a subset of the reference workloads where hyperparam tuning has been used successfully.


Is this project still maintained ?

Hi, I am looking for a logger library for my PL/SQL and APEX applications. I found this project and it is very interesting but last update was 7 years ago. Is it because it's mature or beause it's no longer updated / maintained / supported ? Is it works with newer APEX versions, like 20 to 24 ? Thank you.

If you look at the 3.2.0 branch you see updates from about four years ago. Why that branch is not integrated into the master branch I could only guess. There is no release of that either.

While there is currently no active development this still works totally fine.
We use it for code instrumentation in nearly every project.
Haven't had any issues with it.

@commi235 are you using 3.1.1 or the latest non-released branch, 3.2.0? I am setting up logger. I noticed running the install script (logger_install.sql) there are some errors, like View created with compilation errors or PLS-00049: bad bind variable 'NEW.PREF_TYPE' and similar. I decided to give Logger a try after reading this.

I use 3.1.1, the error during installation is a false positive.

For anyone else who comes across this, there is a great video from Blaine Carter going over the installation and use of Logger.

With branch 3.2.0 the directory layout was changed. It would be nice to get some insight why that was done. It makes it very hard to merge changes with the master. Maybe if I try to restore the directory structure on the 3.2.0 branch it would be possible to compare the sources.
We have some issues with the current master branch version because sometimes we have two log events at the same time which results in a check constrain voilation because the log events share the same id. Today it would make sense to replace such a numeric id with a UUID to avoid such obstacles.

With branch 3.2.0 the directory layout was changed. It would be nice to get some insight why that was done. It makes it very hard to merge changes with the master. Maybe if I try to restore the directory structure on the 3.2.0 branch it would be possible to compare the sources.
We have some issues with the current master branch version because sometimes we have two log events at the same time which results in a check constrain voilation because the log events share the same id. Today it would make sense to replace such a numeric id with a UUID to avoid such obstacles.

This is very rare but happens. Overall it still works and is the best logging framework as far as I know. I know self developed logging frameworks in PL/SQL which still can not reach it.

All: Thanks for your interest in Logger. Unfortunately this code base is not maintained anymore.
At one point. I was working on some big changes for 3.2.0 including how Logger artifacts (i.e. the installer) was built. I don't recommend using it unless you're able to support the changes.
Regardless I (and I know a lot of others) use Logger in many projects and is very stable.

@martindsouza thank you for the informed update!


Compatibility with Dark Dungeons

I haven't seen a commit to this in a while, so I'm hesitant to open a new issue, but I figure it's worth a shot. I've been using this Character tool exclusively with my 100% randomly generated meat grinder games for a few years now. The LotFP setup works for the most part, but we've been more heavily using the Rules Cyclopedia (and more specifically the retroclone Dark Dungeons) for our games, and the differences are enough to be a bit jarring.
What are the chances of getting a variant that accommodates for the BECMI / RC / Dark Dungeons version of D&D?
And adding on that, what are the chances of getting a custom house rules set as well? Something like "RC, but ascending AC" or such?

Damn I haven't looked these issues in ages. What are the differences?


rewrite mkscripts.pl in C

with the bitvector.
the merge code is too hairy and buggy.

I rather removed the buggy merge code. We don't collapse smgle SCX to SC anymore, as its counterproductive in the lib to check for combine errors. We have now all combiners in the SCX, with the GC (if Lm or Mn or other)

Done for mkc23, and removed the buggy code in mkscripts.pl
Should be enough


chore: Update release please pr title

This fixes #9475
You can see the sample release PR this config change produces here: https://github.com/googleapis/google-cloud-java/pull/9545
I created it using the command (following instructions here: https://github.com/googleapis/release-please/blob/main/docs/cli.md):
export GITHUB_TOKEN="{insert PAT}"
release-please release-pr \
  --token=${GITHUB_TOKEN} \
  --repo-url=googleapis/google-cloud-java \
  --target-branch=updateReleasePleasePRTitle

(thank you @ddixit14 for determining it was the group prefix that needed to be used!)

Nice. Can you record how you tested (how you created #9545) in the pull request description?

Good idea. Pasted!


Sorting Shortcuts without even knowing is it an extension?

Code that puts unknown extensions to "unknown_extension" folder.


yii fixture/load truncate user table on production db.

Yii-advanced app for test envirement uses test db
// \yii2-app-advanced\tests\codeception\config\config.php
'db' => [
            'dsn' => 'mysql:host=localhost;dbname=test-db',
            'username' => 'test-db',
            'password' => '1',
            'charset' => 'utf8',
        ],

console envirement uses prod-db
// \ yii2-app-advanced\environments\dev\common\config\main-local.php
  'controllerMap' => [
        'fixture' => [
            'class' => 'yii\faker\FixtureController',
            'templatePath' => '@tests/codeception/common/templates/fixtures',
            'fixtureDataPath' => '@tests/codeception/common/fixtures/data',
            'namespace' => 'tests\codeception\common\fixtures',
        ],
    ],
  'components' => [
        'db' => [
            'class' => 'yii\db\Connection',
            'dsn' => 'mysql:host=localhost;dbname=prod-db',
            'username' => 'readonly',
            'password' => 'pass',
            'charset' => 'utf8',
        ],
    ],

When i run php yii fixture/load "*" with this configuration then I expect that will use the test database. But no:

How can I change this behavior?

if you run it from application directory it will not use Codeception config , you should instead run it from tests\codeception\bin so it will read needed configs

Thank you

for any other case see this and this one

I could not find tests\codeception\bin

Now it's here https://github.com/yiisoft/yii2-app-advanced/blob/master/environments/dev/yii_test


🛍 Shopify Order Status: Code component

Summary
Provide a code editor on the frontend to provide syntax highlight
Reference
https://github.com/bangank36/shopify-order-status-editor/issues/2#issuecomment-1477249044

Update

While the liquid syntax is similar to Django (!?), test it against react-simple-code-editor looks fine

The Diango is found by inspect Jumpseller liquid playground


Fixed offset calculation for negative offset values.

Arshift should be used instead of rshift for calculation signed values like offsets to prevent sign losing. As far as i know there are only two places where signed values are used: in list and structure pointer parsing.

As per https://capnproto.org/encoding.html#structs, we have part A and part B in this 32-bit value. The whole value is not a signed number, logical shift here is used to remove part A, so we get a signed number offset.

@calio do you plan push the patched version into rocks repository?

Yes, but not now. Need to add a few tests for this to make a new release.


Write up/transfer project goals/assumptions to github wiki

https://github.com/thecarebot/carebot/wiki


chore: remove chapter 1 from mvp-demo, mvp-demo -> rhtap-demo

Description

remove chapter 1 from mvp-demo since it duplicates what's being tested in e2e-demo suite
refactor/reorganize former chapter 2
few improvements
mvp-demo readme doc updated
rename mvp-demo to rhtap-demo

Issue ticket number and link
RHTAP-1004
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

How Has This Been Tested?
ginkgo --label-filter='mvp-demo' --v ./cmd/ -- --config-suites=$PWD/tests/e2e-demos/config/default.yaml

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[x] I have updated labels (if needed)

can we also please, finally, rename this test file too? MVP date is long gone :sweat_smile:

Yup, agreed! :) as part of RHTAP-1002 we want to merge mvp-demo and e2e-demo into a single rhtap-demo

actually why not to do the renaming now - the test already includes the integration-test part, which was not a part of mvp, so it's misleading :P

known issue: https://issues.redhat.com/browse/RHTAPBUGS-257
/test redhat-appstudio-e2e

/test redhat-appstudio-e2e


Git-Bash completions

Placing the completion script in /usr/share/bash-completion/completions is not enough. How can I make it work?

Actually, git-bash doesn't look there, but it does load everything in ~/bash_completion.d/*.bash

Feel free to open a PR to add a note about git bash. :+1:


Colored Prompts Confuse Windows Terminal

If users have colored prompts on linux (via SSH) or WSL systems e.g. with:
export PS1="\e[0;33;1m[\u@\h \W]\$ \e[m"

Then the bash history (up arrow) gets really confused about where the user is typing and where the command is.
In the following example I pressed up arrow and then home to return to the beginning of the last command. However I end up at the wrong position as shown by me typing FF

I wanted to type HERE curl https:/sudo usermod -g root someuser but I ended up typing  curl https:/HEREsudo usermod -g root someuser. The previous command was sudo usermod -g root someuser and the curl https:/ is some other previous command I arrowed past if that makes sense.
My suspicion is the terminal has calculated the length of my prompt \e[0;33;1m[\u@\h \W]\$ \e[m incorrectly (too long).
This is windows 10 and WT 1.0.1401.0.

So, line wrapping and cursor positioning is in this case controlled by the shell.
There’s a long-standing “gotcha” with using escape sequences in your prompt, that a lot of folks overlook: you need to tell the shell which regions of your prompt are nonprinting so that it can position the cursor correctly.
More info in this StackOverflow thread

Thanks! I'd never had this problem with other console/terminals so I thought it must be WT but it was just me using a new fancy colored prompt!
Here's the escaped version in case it helps anyone else:
export PS1="\[\e[0;33;1m\][\u@\h \W]\$ \[\e[m\]"

Thanks!
Glad it helped.


NoSuchMethodError: Class 'GeneratedTextColumn' has no instance method 'like'. Receiver: Instance of 'GeneratedTextColumn'

I get this error:
NoSuchMethodError: Class 'GeneratedTextColumn' has no instance method 'like'.
E/flutter (30647): Receiver: Instance of 'GeneratedTextColumn'

When calling the following code:
await batch((batch) async {
  for (final roomId in roomIds) {
    batch.deleteWhere(
      roomEvents,
      (tbl) => tbl.id.like('$roomId:%'),
    );
  }
});

Any idea why this would happen? Statically everything seems fine (in IntelliJ).

like is implemented as an extension on Expression<String>, so there's something very wrong if it tries to call an instance method with that name.
Does it work if you add the table to the signature of the lambda? E.g. (RoomEvents tbl) => .... It might be that tbl is inferred to be dynamic, which would explain why this isn't an analysis error.

Does it work if you add the explicit type? I'll close this since it likely isn't a moor issue. Let me know if you still have this problem, I'll reopen this then.


fix: preview take2

Pull Request Template
Issue Overview
This PR addresses #582

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
This fix adds the preview boolean to the application config in a way that it persists through the application. Additionally, this PR updates the redirect on the summary page so users can't race to the submit button and partners won't be redirected to the public listing rather than the preview listing.
How Can This Be Tested/Reviewed?
This can be tested by logging in to the partner's site, preview a draft listings application (open link in new window so that session doesn't carry over via local host), and ensure you can fill out the application until the summary page. Then go to an open listing on the public side to ensure that the MA account checks are still in place.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have added QA notes to the issue with applicable URLs
[x] I have performed a self-review of my own code
[ ] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[x] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@mcgarrye Thanks for the review! That behavior is existing and expected since it blocks partners from accidentally submitting an application while previewing


What should I do next？

I want to create Local Docker Clusters according to https://tanzucommunityedition.io/docs/latest/getting-started/
after I carry out this  command
tanzu management-cluster create --ui
display
Failure while deploying management cluster, Here are some steps to investigate the cause:
Debug:
kubectl get po,deploy,cluster,kubeadmcontrolplane,machine,machinedeployment -A --kubeconfig /home/test/.kube-tkg/tmp/config_6SDG31q1
kubectl logs deployment.apps/ -n  manager --kubeconfig /home/test/.kube-tkg/tmp/config_6SDG31q1
To clean up the resources created by the management cluster:
tanzu management-cluster delete
unable to set up management cluster, : unable to wait for cluster and get the cluster kubeconfig: error waiting for cluster to be provisioned (this may take a few minutes): timed out waiting for cluster creation to complete: [cluster control plane is still being initialized, cluster infrastructure is still being provisioned]
I don't what to do next?

Hi @xiaoxiangxzhang. There are a few issues with Docker support right now to be aware of. Here are some things to check.
Cgroup support
We currently only support cgroups v1, but newer versions of Docker Desktop and newer Linux distros are starting to ship with cgroups v2 enabled. To check, you can run the following from the command line:
$ docker system info | grep Cgroup
 Cgroup Driver: cgroupfs
 Cgroup Version: 1

The "Cgroup Version" listed should match the above and show a value of "1". If it says "2", then you would need to revert back to v1. I don't have docs handy on how to do that, but we can track that down if needed.
Memory and CPU
Another common issue is not enough resources being available that causes problems spinning up the necessary containers. We recommend at least 4-6G of RAM and 2 CPU cores (though more is obviously better).
$ docker system info | grep -i -E 'cpu|memory'
 CPUs: 4
 Total Memory: 5.807GiB

If using Docker Desktop, you would need to go Preferences > Resources to allocate more resources and restart the Docker Engine for the changes to take effect.
CAPD logs
If it's neither of the above, it's possible something else is causing a problem and we need to take a look at the CAPD (cluster API provider Docker) logs to see what is failing.
This section in the docs walks through connecting to the container to stream the logs:
https://tanzucommunityedition.io/docs/latest/tsg-bootstrap/#troubleshooting-manually
Look for any lines that start with E to see actual errors. There will be other failure messages in the logs, but if they don't start with E then they are just "normal" reconciliation failure messages. The relevant messages for figuring out what is having an issue will be the lines starting with the E to indicate actual errors.
Alternatives
If all else fails, or if you would like to try where we are going with Docker clusters, there is this proposal:
https://github.com/vmware-tanzu/community-edition/issues/2266
That is only for the standalone cluster model though, not the management and workload clusters model you are following now. But depending on your needs, that maybe could work for you.


Feature Request: Object and Array Folding

Request  to have sub-objects/arrays automatically fold/hide with a button.
A folded array could display the number of items in the array along with the label.
A folded object might display the values of 1 or more fields configured - for example a Person object might display alongside the label the  values of the firstName and lastName properties when folded.
Another option might be to allow also a mid-fold (radio-button like control to choose full/mid fold) that displays a partial array/object, say for example the first n fields or items where the n is a parameter that is configurable. A folded object might display the values of 1 or more fields configured - for example a Person object might display firstName and lastName properties  when folded. Folded items would need to be un-folded to edit.
An option on the top-level schema would be a setting to by default fold sub-objects/arrays.

I have tested this and don't see the collapse/expand controls on arrays (didn't try objects yet).
When there are no items in an array this means that there is no way to add new ones.

Couple of questions, you did set the collapsible={true} prop right? Also, are you using the NPM package? Looking at this I think I'm not exporting the images it needs to the package, could it be that?

What I am seeing is that even without the collapsible property the controls do not appear in the HTML generated.
In the following image 'Partners' and 'Features' should have at least an add button, the button is not being generated.

Hi, still not clear what's happening for you. The default is no collapser controls, you need to add the prop collapsible={true} to theSchemaForm or SubmitForm element. It should then render the element at least for the collapser. It's a span which comes before the legend element.

OK, it works for collapsible={true}, does not work for collapsible={false}
or when collapsible is not provided.
On Sat, Sep 3, 2022 at 10:57 AM restspace @.***> wrote:

Hi, still not clear what's happening for you. The default is no collapser
controls, you need to add the prop collapsible={true} to theSchemaForm or
SubmitForm element. It should then render the element at least for the
collapser. It's a span which comes before the legend element.
—
Reply to this email directly, view it on GitHub
https://github.com/restspace/svelte-schema-form/issues/2#issuecomment-1236137377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOP333K7JPGGZDGEYISKETV4NRNVANCNFSM575U4EPA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Paul Wujek

That's by design, so you don't have to have collapsers if you don't want them. I felt that was a. a global concern and b. a display detail, so I thought it would be better as a prop on the component than a custom schema property.

What I mean by it doesn't work is that the '+' add button doesn't display when collapsible != true.
How would you add new entries in an array without the '+' control?

That's fixed now, I'll leave this issue open for a few days in case you find issues with the fix.


Ingress Status is updated with Pilot's address instead of Ingress controller's node address

Observed by debugging the Ingress Status gets updated with the node where the pilot discovery pod is scheduled, and it should be updated with the node where the ingress-controller pod is scheduled.

Did you verify that IngressService was set correctly in the ConfigMap? I assume this occurs when IngressService has not been set, in which case it is a bug.

This is for when Ingress is deployed as NodePort. In that case, the external IP of the service is not used. Please go inside k8s code and check.

As per @andraxylia's suggestion, it may be possible to fix this by writing our own implementation of this line:
https://github.com/istio/pilot/blob/master/adapter/config/ingress/status.go#L87

Issue moved to istio/istio #1387 via ZenHub


memcpy instead of broadcasting?

from neon.backends import gen_backend
ng = gen_backend(backend='gpu', device_id=0)

y = ng.zeros((2, 1))
x = ng.zeros((2, 2))

x[:] = y + 0 # OK
x[:] = y     # cuMemcpyDtoDAsync failed: invalid argument

(I'm still on 1.1.3 by the way)

A fix for this will be part of the imminent v1.5.0 neon release.


"find all references"  and "renaming symbols" stopped working

Issue Type: Bug
"find all references" and "renaming symbols" stopped working.
VS Code version: Code 1.33.0 (0dd516dd412d42323fc3464531b1c715d51c4c1a, 2019-04-04T15:14:28.026Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Xeon(R) W-2125 CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.68GB (24.49GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

python
ms-
2019.3.6558

mel
sat
0.1.2

I have posted the problem here  as well:
View the issue:
issue.gif
I bypassed this issue by adding:
"python.jediEnabled": true
in the setting.json

Duplicate of https://github.com/Microsoft/vscode-python/issues/3574


[stable/docker-registry] Add missing ingress documentation

What this PR does / why we need it:
Adds missing ingress documentation to stable/docker-registry
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[] Chart Version bumped (docs changed only)
[x] Variables are documented in the README.md

/ok-to-test

/lgtm


Warn users not to remove edition id from subject header

https://trello.com/c/EgwMYcXj/1987-3-update-publisher-interface-and-email-text-to-match-new-fact-check-workflow

Text looks fine to me, my only Q would be is there any way to make it more visible, maybe making it bold (if allowed) or moving to the top of the list it's in?

maybe making it bold (if allowed)

Notify's markup doesn't allow bold as they think it makes the text less readable.

or moving to the top of the list it's in (don't know if that'd make much difference tbh)?

It's possible, but the position (third item in that list) was what JP in Content suggested when I asked.


Update multiple tools to their latest versions & deleted redundant tools

subfinder: 2.6.3 to 2.6.6
ipinfo: 3.1.2 to 3.3.1
Updated httpx: 1.3.7 to 1.6.8
Updated Nuclei: 3.0.4 to 3.3.4
Updated Python packages as per Github security advisories
Removed puredns
Removed Amass

Hi @Prateek-Thakare @0xbharath
I have reviewed the changes.
looks good to me

@Ncoder2 Can you merge the PR and also make sure the new docker images are built and pushed to registry?

@Ncoder2 Can you confirm if the docker images are built and pushed to registry with these changes? Looks like the job was skipped. This means the Mantis docker images still have old code.


Unexpected error Resource not accessible by integration

Hi. First of all, thank you for a great tool. I really appreciate your work.
I was trying to integrate it in my CI/CD pipeline (https://github.com/magicxor/WinSyncScroll/blob/master/.github/workflows/release.yml) and encountered an error:
Publishing Packages - 1.0.2-beta.6
  ── Publishing Packages - 1.0.2-beta.6 ──────────────────────────────────────────
  2024/09/25 03:34:34.912 info: [16] Creating release with tag 1.0.2-beta.6

Unexpected error Resource not accessible by integration
Error: Process completed with exit code 1.

Could you please give me advice on how to fix it?
My config:
profile = "custom"
artifacts_folder = "artifacts"

[msbuild]
project = "../WinSyncScroll/WinSyncScroll.csproj"
configuration = "Release"

[msbuild.properties]
PublishTrimmed = false
PublishSingleFile = false
SelfContained = true
PublishReadyToRun = true
CopyOutputSymbolsToPublishDirectory = false
SkipCopyingSymbolsToOutputDirectory = true

[github]
user = "magicxor"
repo = "WinSyncScroll"

[nuget]
publish = false

[[pack]]
rid = ["win-x64"]
kinds = ["zip"]

csproj is like that
    <PropertyGroup>
        <OutputType>WinExe</OutputType>
        <TargetFrameworks>net462;net8.0-windows</TargetFrameworks>
        <EnableWindowsTargeting>true</EnableWindowsTargeting>
        <Nullable>enable</Nullable>
        <ImplicitUsings>enable</ImplicitUsings>
        <UseWPF>true</UseWPF>
        <ApplicationIcon>Resources\Icon\app_icon.ico</ApplicationIcon>
        <LangVersion>12</LangVersion>
    </PropertyGroup>

    <PropertyGroup>
      <Version>0.0.1</Version>
    </PropertyGroup>

(I tried to build it locally on Ubuntu, it actually works):
dotnet publish -c release -r win-x64 --framework net8.0-windows --self-contained
dotnet publish -c release -r win-x64 --framework net462 --self-contained

Full log:
Run dotnet tool install --global dotnet-releaser
  dotnet tool install --global dotnet-releaser
  dotnet-releaser run --github-token "***" .github/dotnet-releaser.toml
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    DOTNET_ROOT: /usr/share/dotnet
You can invoke the tool using the following command: dotnet-releaser
Tool 'dotnet-releaser' (version '0.9.0') was successfully installed.
2024/09/25 03:33:19.502 info: [1] dotnet-releaser 0.9.0+d30e5ef012ae7f52ec2a5d1d1915ab94a6560ace - run
Configuring
  ── Configuring ─────────────────────────────────────────────────────────────────
  2024/09/25 03:33:19.778 info: [2] Running from GitHub: user = magicxor, repo = WinSyncScroll, event = push, ref_name = 1.0.2-beta.6, ref_type = tag
  2024/09/25 03:33:19.780 info: [3] Loading configuration from /home/runner/work/WinSyncScroll/WinSyncScroll/.github/dotnet-releaser.toml
  2024/09/25 03:33:19.871 info: [4] Loading 1 projects
  2024/09/25 03:33:24.823 info: [5] Packages and Projects
  ┌───────────────┬────────┬──────────────┬────────────────────┬───────────┬───────────┬───────┐
  │ Project       │ Kind   │ Version      │ TargetFramework(s) │ License   │ Packable? │ Test? │
  ├───────────────┼────────┼──────────────┼────────────────────┼───────────┼───────────┼───────┤
  │ …             │        │              │                    │           │           │       │
  │ WinSyncScroll │ winexe │ 1.0.2-beta.6 │ net462             │ Unlicense │     x     │       │
  │               │        │              │ net8.0-windows     │           │           │       │
  └───────────────┴────────┴──────────────┴────────────────────┴───────────┴───────────┴───────┘
  2024/09/25 03:33:25.259 info: [6] Connecting to GitHub (For this CI)
  2024/09/25 03:33:26.263 info: [7] The tag `1.0.2-beta.6` is identified as a release tag with version `1.0.2-beta.6`. Publish mode selected.

Preparing Changelog - 1.0.2-beta.6
  ── Preparing Changelog - 1.0.2-beta.6 ──────────────────────────────────────────
  2024/09/25 03:33:26.270 info: [8] Building Changelog: collecting commits and PR for version 1.0.2-beta.6
  2024/09/25 03:33:26.924 info: [9] Building Changelog: 1 commits and 0 PR collected for version 1.0.2-beta.6. Previous version is: 1.0.2-beta.5
  2024/09/25 03:33:26.986 info: [10] Changelog:
  1.0.2-beta.6

  # Changes

  ## 🐛 Bug Fixes

  - fix dotnet-releaser (081cda4e)

  **Full Changelog**: [1.0.2-beta.5...1.0.2-beta.6](https://github.com/magicxor/WinSyncScroll/compare/1.0.2-beta.5...1.0.2-beta.6)

  Published with [dotnet-releaser](https://github.com/xoofx/dotnet-releaser/)

Building
  ── Building ────────────────────────────────────────────────────────────────────
  2024/09/25 03:33:26.989 info: [11] Restoring `/home/runner/work/WinSyncScroll/WinSyncScroll/WinSyncScroll/WinSyncScroll.csproj`
  2024/09/25 03:33:28.087 info: [12] Building `/home/runner/work/WinSyncScroll/WinSyncScroll/WinSyncScroll/WinSyncScroll.csproj` - Configuration = Release

App Packaging WinSyncScroll - 1.0.2-beta.6
  ── App Packaging WinSyncScroll - 1.0.2-beta.6 ──────────────────────────────────
  2024/09/25 03:33:51.877 info: [13] Platforms and Packages Configured:
  ┌──────────┬──────────┬──────────┐
  │ Platform │ Packages │ Publish? │
  ├──────────┼──────────┼──────────┤
  │ win-x64  │ zip      │    x     │
  └──────────┴──────────┴──────────┘
  2024/09/25 03:33:51.880 info: [14] Building target platform [win-x64] / [zip] package, target framework: [net8.0-windows].
  2024/09/25 03:34:34.776 info: [15] Build successful in 42.8951941s for platform [win-x64] / [zip] package: /home/runner/work/WinSyncScroll/WinSyncScroll/.github/artifacts/WinSyncScroll.1.0.2-beta.6.win-x64.zip

Publishing Packages - 1.0.2-beta.6
  ── Publishing Packages - 1.0.2-beta.6 ──────────────────────────────────────────
  2024/09/25 03:34:34.912 info: [16] Creating release with tag 1.0.2-beta.6

Unexpected error Resource not accessible by integration
Error: Process completed with exit code 1.

Ooops, looks like I forgot to switch "Workflow permissions":

I'm sorry :)

Ooops, looks like I forgot to switch "Workflow permissions":

Yeah, it is unfortunate that the GitHub REST API when failing for such things is not giving more details (e.g you are missing write permissions or something) because these errors are always a bit cryptic. Things can get a bit messier as well if you are working on a private repository.
Good that you were able to solve your issue. ☺


WIP: rsa/rsa_ossl.c: make non-smooth RSA constant-time.

This is on top of #7589, hence the WIP. Two commits.

Now that #7589 can this be reopened, rebased and brought out of WIP?

We should review the changes here if there is anything left to reuse in future make BN ops constant time work.


Filters Spring Cloud Gateway MVC

Question
How to write filter in Spring cloud gateway mvc.
In Zuul we have @ZuulFilter and in Spring Cloud Gateway we have @GatewayFilter
What is the replacement for above in Spring Cloud Gateway MVC

Closing in favor of https://github.com/spring-cloud/spring-cloud-gateway/issues/3143


When relaying logs from move2kube cli, the logging level (warn, info, debug..) should be maintained

Describe the bug
Currently move2kube just prints all logs from the cli as info logs
To Reproduce
Steps to reproduce the behavior:

Run move2kube-aio image
Start a plan creation
All messages from move2kube gets displayed as info message.

Expected behavior
The logging level from move2kube should be maintained by move2kube-api too

I am closing this issue as discussed today.

I am closing this issue as discussed today.


Build specs as part of test command

This change makes running tests on the command line a bit simpler for convenience's sake. Previously, you would need to re-run (or rely on npm start to be running in the background) after making a change to a spec to see the updated code reflected in npm run test. The test command now incorporate that build spec step, which should only take about a extra second or so.
I also clean up the function names a bit here for clarity, and remove an unused function.

Thanks for the pull request @ggetz!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.


netsh ebpf show disassembly should also show the corresponding C code (if available)

llvm-objdump when used with "-S" option dumps the original C code along with the disassembly. That makes it easier to find out the corresponding C code when verification fails.
netsh ebpf show disassembly can also possibly have similar feature to dump this info, if the .o is compiled using "-g" flag, and the source file is available.

The disasm.c file mentioned above does not deal with source line information.  Source line information is encoded in the ".debug_line" section using a sequence of operations viewable via "readelf -wl ".

bpftool and libbpf also have BTF parsing functionality and so it may be possible to use libbpf APIs?

I think the right solution here is to do this in the verifer. It decodes the instructions into a vector of LabeledInstruction, which we can augment with line info that it came from.
Netsh uses the prevail function print to generate the disassembly, so I think it makes more sense to put it into prevail.
https://github.com/vbpf/ebpf-verifier/issues/301

Agree with Alan's comment above.  So updating this to be blocked on https://github.com/vbpf/ebpf-verifier/issues/301 and once that is done, then we can update tutorial.md accordingly.  This issue is now the documentation issue for doing that once the functionality is there.


Comparison with python-docs-cookiecutter in the README?

I think it would be easier for a developer to decide which tool to use if python-docs-bootstrapper would have a comparison with existing tool in the README. From top of my mind it would be: available on PyPI, not requiring a CPython repository clone (fetching it for the user), not having a dependency on the cookiecutter (?).

Hey! Sounds like a good idea. I'll take a look and get back tomorrow. Thanks!

The "Why use python-docs-bootstrapper" section will be available in README in the next release. I'll be working on the new release the next couple of days.
Please don't hesitate to contribute if anything comes to your mind :)


2024-12-04_01-35-54_master-next_aws-cli-v2

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10604-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10604-to-kirkstone-next
git switch --create backport-10604-to-kirkstone-next
git cherry-pick -x bf809612b0eadedb7c8e73c5dac29466d58987c2

Backport failed for scarthgap-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin scarthgap-next
git worktree add -d .worktree/backport-10604-to-scarthgap-next origin/scarthgap-next
cd .worktree/backport-10604-to-scarthgap-next
git switch --create backport-10604-to-scarthgap-next
git cherry-pick -x bf809612b0eadedb7c8e73c5dac29466d58987c2

Successfully created backport PR for styhead-next:

#10610


Restore full name for links to the GitHub repo

The commit fce2a576f34dcb0868d221e3183f970368254928 was a bit too eager...

Fixes #31.


when cell content exceeds cell boundaries, next cell gets messed up (exmples)

When 2 of the cells in the PDF continue beyond the cell's boundary, the next cell's content goes "crazy" (i.e. is totally different than expected)
in the example sample:
I assume the PDF source is EXCEL, where it's common to see long text cut at the border of the cell. I don't know for sure.

PDF file (download)
TSV output file
(The document is RTL, ie. right to left; therefore, the 2nd cell is the 2nd from the right)

Command line used:
java  -Dfile.encoding=UTF8 -jar tabula-1.0.5-jar-with-dependencies.jar sample.pdf  -f TSV > sample.tsv
The bogus lines are identified / starts with: 1068, 1103
Output lines with the problem:
43	E2U9	A10L YCPCT	"ש""א אקליפטוס סיטריאדורה   SCITRIADORA/"	1068
60	43	10 CEUCC	"ש""א אקליפטוס רדיאטה   LYPTUSRADIATA/"	1103
In the output, i see 2 phenomena:

the wrong text "A10L YCPCT" should've been: "10 CC"
the wrong text "E209" should've been: "29".  etc.
the word "EUCALIPTUS" is cut in these lines.  This makes sense, since it's not visible, and therefore, not a real bug.

in the attache sample.df >  converted text file in the 3rd field shoud've been the text "10 CC".
My setup:

windows 10
java version "1.8.0_401"
tabula 1.0.5

Hi @shula Unfortunately this is expected behavior for a PDF with this kind of problem. The "extra"/unexpected characters (for example AL YPT in line 1068) are present, but under the text for the next cell to the left. So Tabula is correctly extracting the characters.

I'm running into this problem too, attempting to "free" data locked inside some legal filings.
@jeremybmerrill Can you comment as to whether the data still exists in uncorrupted form inside the PDF, and where in the code I might attempt to patch the extraction logic?  Or barring that, suppress the overflow text so it doesn't corrupt its neighbors?  I'm experienced in Java, but not PDF or this particular codebase.  Thanks.

@apgove It's difficult to generalize about PDFs; they're a bit like Dostoyevsky's idea of families. Happy PDFs are all alike, but unhappy PDFs are unhappy in their own ways. Except it's you that's unhappy, not the PDF.
Unfortunately, there's likely not a generalizable way to "fix" this problem. There's no sense of a table; it's just a bunch of lines that happen to be arranged in a way that humans perceive as a table. Those lines comprising the table are stored totally separately from the text. So the text doesn't know what cell it's in; the cells don't know what text they are supposed to contain. From the PDF's perspective, the only sense in which the text is "in" a cell is whether it is contained within the bounding box created by the lines, and, thus, if text appears to overflow into the "next" cell, it IS in the next cell.
You could perhaps do something funny with detecting overlapping text and then using language modeling to predict which overlapping character belongs in the "previous" cell, but that would be nondeterministic and probably wouldn't work! In certain cases, you could be lucky enough that you could heuristically determine based on (for instance) text size or Y-position which overlapping characters belong in which cell for your specific document, but that wouldn't generalize.

Thanks for the explanation @jeremybmerrill , it's much appreciated to avoid wasting [even more] time on a wild goose chase.  I'm guessing, given that the overlapping characters get intermingled in the output, that each glyph is represented independently, not as strings, making this quite challenging.
Just spitballing (please forgive the uninformed speculation, I've been on the receiving end and it can be really annoying!), but there must be some sort of z-order information stored somewhere in order for the overrunning characters to get hidden; I wonder whether that could be used as a signal that the hidden characters belong in the previous cell, not the one they're contained by.  Of course, that would still fail if it overran more than 1 column, but it could be a big improvement.  Or... Maybe if we have enough information to know that a character is being suppressed due to overlap, it can just be skipped over and not added to the output for any table cell.  Information would be lost, but it would at least avoid corruption and accurately reflect the visual representation of the original PDF.
Anyways, maybe I'll dive down this rabbit hole later, but for now I'll pursue other leads.

@apgove Feel free to give it a try! I don't think there's likely to be a free lunch in the general case, but it's possible that a there may be heuristics for the PDFs in your use case that would resolve your problem.
TextPosition is the underlying representation of a character (or a string of a few characters) in the underlying PDFBox library. Some PDFs have one TextPosition per glyph; others have a few characters in a single TextPosition. Because PDFs are primarily a display format not a data transfer format, different PDF generators do different things (and I don't think standards, at least not early ones, defined a right way to do it).
There's no explicit Z-index, although there's an underlying ordering that might correspond to what you're looking for, for your specific documents. Only way to know is to try.
I should add this caveat: Unless you've got thousands of PDFs or need to build a pipeline that ingests PDFs into the future, you might spend more time investigating this than it would take to fix the misbehaving cells manually!


Upgrading from v8.2.1 -> 8.4.0 Broke Updating Camera Props

Describe the bug
After upgrading from v8.2.1 -> v8.4.0 update camera props stoped working.
In iOS updating zoom and heading no longer work after initial load (follow modes do still work however).
In Android, no camera prop updates work after initial load.
To Reproduce
Create MapView map camera tied to a redux store for zoom & heading props.  Outside of the component, have a button to adjust props.  Zoom/Heading fail to update when external button is pressed updating camera props.
Could be resolved by https://github.com/react-native-mapbox-gl/maps/pull/1619 - but unclear.
Expected behavior
Map View Zoom & Heading update as expected on prop change to Camera component after initial load.
Actual behavior
Map View Zoom & Heading, and in Android, follow modes etc..., are reflected in Map View after updating the Map Camera.
Screenshots
Versions (please complete the following information):

Platform: Android, iOS
Platform OS: iOS 15.0
Device: iPhone 12
Emulator/ Simulator: yes (also failed on real device)
Dev OS: OSX 11.6
react-native-mapbox-gl: 8.4.0
Mapbox GL version: 6.4.1
React Native Version 0.66.2

@dorthwein Sorry you're having this issue!
Setting up a new example with Redux integrated is kind of a lot of overhead just to verify. Are you able to run this example, and if so does the zoom change work?
If it does, then I would suggest the problem is with your test repo. If it doesn't, would you be able to attach a video showing what it does?

@naftalibeder here is an example of follow working & not working trying to set following the user.  No redux.
Test on real Android Device
react-native-maps: 8.4.0
react-native: 0.66.2
Be sure to initialize MapBox access token somewhere.
import React, { useState } from "react"
import { TouchableOpacity, View, Text } from "react-native"
import MapboxGL from "@react-native-mapbox-gl/maps"

export const PlaygroundScene = () => {
  /*
   * Toggle follow user locaiton on/off
   */
  const [follow, setFollow] = useState(false)
  const toggleFollow = () => {
    setFollow(!follow)
  }

  /*
   * Toggle between working and not working examples
   */
  const [example, setExample] = useState("notWorking")
  const toggleExample = () => {
    if (example == "notWorking") setExample("working")
    else if (example == "working") setExample("notWorking")
  }

  return (
    <View style={{ flex: 1 }}>
      <MapboxGL.MapView styleURL={MapboxGL.StyleURL.Satellite} style={{ flex: 1 }}>
        {/*
         * Un mounting and re-mounting the camera seems to work and
         * prompted follow to work as expected.
         */}
        {follow && example == "working" ? (
          <MapboxGL.Camera
            followUserLocation={follow}
            followUserMode={"course"}
            zoomLevel={16}
            key="working"
          />
        ) : (
          <View />
        )}

        {/*
         * Simply updating the followUserLocation prop, does not
         * trigger following, however it previously did.
         *
         * Note: When toggling between working & not working,
         * be sure to set the example, then do multiple attempts at
         * toggling follow on & off.  Otherwise it will just behave
         * like the working example due to re-mounting.
         */}
        {example == "notWorking" ? (
          <MapboxGL.Camera
            followUserLocation={follow}
            followUserMode={"course"}
            zoomLevel={16}
            key="not-working"
          />
        ) : (
          <View />
        )}
        <MapboxGL.UserLocation
          animated={true}
          renderMode="native"
          androidRenderMode={"gps"}
          key="mapUserLocationComponent"
        />
      </MapboxGL.MapView>
      <Controls toggleFollow={toggleFollow} toggleExample={toggleExample} />
      <Stats follow={follow} example={example} />
    </View>
  )
}
const Stats = ({ follow, example }) => {
  return (
    <View>
      <Text style={{ color: "#FFF" }}>Is Following: {follow ? "YES" : "NO"}</Text>
      <Text style={{ color: "#FFF" }}>Example: {example}</Text>
    </View>
  )
}

const Controls = ({ toggleFollow, toggleExample }) => {
  return (
    <View style={{ flexDirection: "row", alignItems: "center", padding: 8 }}>
      <Button label={"Toggle Follow"} onPress={toggleFollow} />

      <Button label={"Toggle Example"} onPress={toggleExample} />
    </View>
  )
}

const Button = ({ label, onPress }) => {
  return (
    <TouchableOpacity
      onPress={onPress}
      style={{ padding: 8, backgroundColor: "blue", borderRadius: 8, margin: 4 }}>
      <Text style={{ color: "#FFF" }}>{label}</Text>
    </TouchableOpacity>
  )
}

Some additional information, if we make the following change on the camera component from false, too true, things seem to work as intended.
I'm sure there is a good reason why we don't do this though...any thoughts?
shouldComponentUpdate() {
    return false;
  }

to
shouldComponentUpdate() {
    return true;
  }

shouldComponentUpdate

Setting this to true causes the component to update anytime a prop changes, which in particular creates issues with comparing objects and functions. Updating constantly can cause significant performance degradation.

update this component to be a functional component instead

No reason not to do that, just the possible introduction of bugs, and developer effort. I would bet if you got a PR tested with that conversion, @ferdicus would be happy :)
But as for the issue you’re having, I’m going to look into that this afternoon. I have a hunch.

Also is there a reason we don't update this component to be a functional component instead?

basically what @naftalibeder said:

who got time?
who got tests?
who tests backwards compatibility?
who checks native bridge files?
so many things to do, so little time.... oops dead already ☠

PRs definitely welcome though :)
Make sure to check out the Discussion for additional maintainers 👋🏿
Cheers 🍻

But as for the issue you’re having, I’m going to look into that this afternoon. I have a hunch.

🙇🏿

Also is there a reason we don't update this component to be a functional component instead?

basically what @naftalibeder said:

who got time?
who got tests?
who tests backwards compatibility?
who checks native bridge files?
so many things to do, so little time.... oops dead already ☠

PRs definitely welcome though :) Make sure to check out the Discussion for additional maintainers 👋🏿
Cheers 🍻

100% understand.  I'll try and slot some time around upgrading components/contributing where I can! ~DFO~

@naftalibeder - If you can point me in a direction, I can try and take a look at figuring out what could have changed btw.

@dorthwein Sorry I didn't respond earlier, I think I may have resolved it in #1631 . Would you want to try pointing here
"@react-native-mapbox-gl/maps": "https://github.com/TruckMap/maps.git#fix/camera",

and see if that works?

@naftalibeder I must be tripping because I could have swore I responded here....
Anyway - I tried your fixes, zoomTo is working if followUserLocation={true} however if it is false, it does not work.  We have a specific use case relying on this thats basically a +/- zoom buttons.
Also, setting followUserLocation={true} and setting followUserMode="course" does not cause the map to follow the user's location while driving :(.
Best,
Danny

@dorthwein You're not crazy - you responded here. :)
Let me check into it.

@dorthwein

zoomTo is working if followUserLocation={true} however if it is false, it does not work.

Are you sure you don't have that backwards? I see zoomTo only working if followUserLocation === false. if it's true, this logic is triggered, and the zoom level does not update.
This is because _followZoomLevel it never actually set - the function setFollowZoomLevel is never called. This seems to be a bug, but it's a part of the code base that I haven't touched, so I don't think my PR could have broken it.
Check out the Fit example again, where I've now added a toggle for followUserLocation. Let me know your thoughts.

@naftalibeder - I'll try and take a look at it shortly - side note - do y'all use use followUserLocation or just update the camera?

We just set bounds and centerCoordinate with a variable duration, which is probably why I hadn’t noticed any issue.

@naftalibeder yeah I can confirm still not working although it takes some toggling and messing around with.  Interestingly when using Lokito to mock locations on the examples, it doesn't update the user location, however Lokito does update the location in google maps, our project etc...
Updating the key (which is effectively a remount) is a functional work around for us.

@dorthwein Let me double-check on Android - admittedly I do more testing on iOS.

Same issue on IOS only when upgrading from 8.3.0 to 8.4.0 :'(

Yes on Android no problem but on Ios when i use FlyTo to change my camera position, the zoomlevel passed  zoomLevel Max.
I tried to change flyTo at moveTo but it's same issue.

@naftalibeder - I'm confirming on iOS if followerUserLocation: false, adjusting zoom level on iOS & Android does not work, even if we change the key.
Some where some seriously breaking changes got introduced when adjusting camera props.

@dorthwein Can you try the latest commit on this #1631? See this comment.

Confirming this https://github.com/react-native-mapbox-gl/maps/pull/1631 fixes the zoom & follow issues on iOS & Android
Great job @naftalibeder!

Thank you for the fix. When could we expect a release with this?

@narcismihaitech, today

release 8.5.0 is published - it includes the fix for this issue

I'm having this issue on 8.5.0. Updating zoomLevel props and nothing happens to the zoom after first component render. Is anyone else experiencing this?

yes, still problems with switching followUserMode with state.... Forcing me to use the key prop
<MapboxGL.Camera
					ref={cameraRef}
					key={`${navigationSettingsState.mode}-${mapProperties.zoom}`} // must be set to force re-render when changing the camera (only on android it appears.)
					followZoomLevel={mapProperties.zoom}
					followUserLocation={navigationSettingsState.followUserLocation}
					followUserMode={navigationSettingsState.followUserMode}
					followPitch={navigationSettingsState.pitch}
					allowUpdates
				/>

and when changing followZoomLevel, it causes buggy experiences

@Cmoen11 Are you using the latest release version 8.5.0 ?

Yes, i'm using "@react-native-mapbox-gl/maps": "^8.5.0",

@Cmoen11 We are using this library as a base for turn by turn navigation.
<MapboxGL.MapView                     styleURL={'mapbox://styles/....'}                     ref={r => {                         _mapRef = r;                     }}                     onLayout={e =>                         setUserPositionInViewDisplacement(                             e.nativeEvent.layout.height / 2,                         )                     }                     contentInset={[userPositionInViewDisplacement, 0, 0, 0]}                     onRegionWillChange={onMapLocationUpdate}                     style={styles.map}                     logoEnabled={false}                     compassEnabled={false}                     attributionEnabled={false}>                     <MapboxGL.Camera                         allowUpdates={true}                         animationDuration={1500}                         animationMode={'flyTo'}                         maxZoomLevel={21}                         followZoomLevel={                             !cameraProps.zoomLevel                                 ? defaultCameraProps.zoomLevel                                 : cameraProps.zoomLevel                         }                         defaultSettings={{                             centerCoordinate: [18.0521569, 59.3274506],                             zoomLevel: defaultCameraProps.zoomLevel,                             pitch: defaultCameraProps.pitch,                         }}                         followPitch={cameraProps.pitch}                         {...cameraProps}                         followUserLocation={localFollowUserLocation}                         followUserMode={localTrackingMode}                         userTrackingMode={                             MapboxGL.UserTrackingModes.FollowWithCourse                         }                         centerCoordinate={                             !test &&                             !localFollowUserLocation &&                             currentLocation                                 ? currentLocation                                 : undefined                         }                     /> </MapboxGL.MapView>
Updating zoom level in this way:
 setCameraProps({                         zoomLevel: Platform.OS === 'ios' ? 21 : 17,                         pitch: defaultCameraProps.pitch,                     });
And default camera props is:
 const defaultCameraProps = {         zoomLevel: Platform.OS === 'ios' ? 20.35 : 16,         pitch: 89,     };
Hope that this helps.


PoB window : all black/void

When I open PoB, the window open like usual but the content is just black, no tree or anything. There's still the upper bar and I can click on it (like on the "close tab button" but it takes several seconds to take effect).
Sometimes it opens normally, I can see the tree and do stuff and then it goes black...
I tried reinstalling PoB 3-4 times with the same result.
PoB Release : 1.4.59
Pc : windows 10
Visual:
http://hpics.li/e2e1881
Note 1 : PoB was working fine today until I closed PoE, then it went black... weird
Note 2 : I will re-installed the graphics driver and test again

Visuals would be nice. I would suggest updating your graphics driver if you haven't already done so, as it often fixes issues like this.

Yeah program starts like this: https://i.imgur.com/pCIL1iX.png and loads fine, but when you change window size - close - start again: https://i.imgur.com/hMKO0Mz.jpg

Still having almost the same issue, check #672 for more info. @Openarl


In L3 table, only match tunnelled traffic for gw dst MAC rewrite

Otherwise this flow will match L2 traffic from local Pods to the
gateway, which is harmless but unnecessary and confusing.

LGTM.

/test-e2e


fix(gui): Fix image checks in image selections

I must have screwed something up during a rebase,
this mends the partition table an windows image checks.
Change-Type: patch

Could / should we add extra unit-tests to prevent similar mistakes getting through the CI checks in the future?

The only thing I can think of to catch these types of issues, is to write GUI integration tests.

Oh? From what I can tell from the changes in this PR, it looks like the error was in the selectImage function, which currently doesn't seem to have any unit-tests ?  Or is this code so heavily tied into the GUI that it's impossible to unit-test standalone (with mocking etc.)?

And on a related note, perhaps it'd be worth looking at adding some code-coverage checks to Etcher?

Or is this code so heavily tied into the GUI that it's impossible to unit-test standalone (with mocking etc.)?

Yeah, exactly. The code is too GUI centric to property unit-test. Spectron integration tests would cover these types of things.

And on a related note, perhaps it'd be worth looking at adding some code-coverage checks to Etcher?

I'm a big fan of https://istanbul.js.org/, however I'm not sure how to configure it given that we use electron-mocha (a very custom wrapper around mocha that runs test cases on Electron itself), and that Electron applications have independent main/renderer processes.
Let's definitely research what's needed. If its doable, then lets go for it!


Support SparkIntegration activation after SparkContext created

I created an issue https://github.com/getsentry/sentry-python/issues/3410

Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.
Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

I have tested this change with both Spark master local and YARN, and there's currently an issue with applying Sentry after the session is created.
The problem is that the breadcrumbs are not being sent, and I think the issue might be related to the scope. Unlike when it works properly, the scope gets set to None at one point and then its address changes. The listener is working correctly. I would appreciate any help you can provide!
master local
🟢 sentry_init before create spark session

listner works well
breadcrumbs sent well
code

from pyspark.sql import SparkSession
import sentry_sdk
from sentry_sdk.integrations.spark import SparkIntegration

if __name__ == "__main__":
    sentry_sdk.init(
        integrations=[SparkIntegration()],
        dsn="{{ my_dsn }}",
    )

    spark = SparkSession.builder \
        .appName("Simple Example") \
        .master("local[*]") \
        .getOrCreate()

    data = [1, 2, 3, 4, 5]
    rdd = spark.sparkContext.parallelize(data)
    result_rdd = rdd.map(lambda x: x * x)

    result = result_rdd.collect()
    print(result)

    spark.read.csv("/path/deos/not/exist/error/raise")

log

============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
24/08/10 14:57:21 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
========== onJobStart branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
========== onStageSubmitted branch feature/support-exists-context
[1, 4, 9, 16, 25]
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
========== onStageCompleted branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
========== onJobEnd branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
Traceback (most recent call last):
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/local_test_before_create_spark_session.py", line 23, in <module>
    spark.read.csv("/path/deos/not/exist/error/raise")
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/pyspark/sql/readwriter.py", line 727, in csv
    return self._df(self._jreader.csv(self._spark._sc._jvm.PythonUtils.toSeq(path)))
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/py4j/java_gateway.py", line 1322, in __call__
    return_value = get_return_value(
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/pyspark/errors/exceptions/captured.py", line 175, in deco
    raise converted from None
pyspark.errors.exceptions.captured.AnalysisException: [PATH_NOT_FOUND] Path does not exist: file:/path/deos/not/exist/error/raise.
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1020f0930 name=None type=ScopeType.ISOLATION>

🔴 sentry_init after create spark session

listner works well
breadcrumbs can't send
code

from pyspark.sql import SparkSession
import sentry_sdk
from sentry_sdk.integrations.spark import SparkIntegration

if __name__ == "__main__":
    spark = SparkSession.builder \
        .appName("Simple Example") \
        .master("local[*]") \
        .getOrCreate()

    sentry_sdk.init(
        integrations=[SparkIntegration()],
        dsn="{{ my_dsn }}",
    )

    data = [1, 2, 3, 4, 5]
    rdd = spark.sparkContext.parallelize(data)
    result_rdd = rdd.map(lambda x: x * x)

    result = result_rdd.collect()
    print(result)

    spark.read.csv("/path/deos/not/exist/error/raise")

log

============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
Setting default log level to "WARN".
To adjust logging level use sc.setLogLevel(newLevel). For SparkR, use setLogLevel(newLevel).
24/08/10 15:05:20 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1032f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1036e4d40 name=None type=ScopeType.ISOLATION>
========== onJobStart branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1036e4d40 name=None type=ScopeType.ISOLATION>
========== onStageSubmitted branch feature/support-exists-context
[1, 4, 9, 16, 25]
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1036e4d40 name=None type=ScopeType.ISOLATION>
========== onStageCompleted branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1036e4d40 name=None type=ScopeType.ISOLATION>
========== onJobEnd branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1032f0930 name=None type=ScopeType.ISOLATION>
Traceback (most recent call last):
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/local_test_after_create_spark_session.py", line 24, in <module>
    spark.read.csv("/path/deos/not/exist/error/raise")
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/pyspark/sql/readwriter.py", line 727, in csv
    return self._df(self._jreader.csv(self._spark._sc._jvm.PythonUtils.toSeq(path)))
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/py4j/java_gateway.py", line 1322, in __call__
    return_value = get_return_value(
  File "/Users/kakao/Desktop/shaun/opensource/sentry-python-test/venv/lib/python3.9/site-packages/pyspark/errors/exceptions/captured.py", line 175, in deco
    raise converted from None
pyspark.errors.exceptions.captured.AnalysisException: [PATH_NOT_FOUND] Path does not exist: file:/path/deos/not/exist/error/raise.
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1032f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1032f0930 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x1032f0930 name=None type=ScopeType.ISOLATION>

master yarn
🟢 sentry_init before create spark session

listner works well
breadcrumbs sent well
code is same as local
log

============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/pyspark.zip/pyspark/context.py:350: RuntimeWarning: Failed to add file [https://t1.kakaocdn.net/dip3_file_server/du-batch/src-develop.zip] specified in 'spark.submit.pyFiles' to Python path:
  /data6/yarn/nm/usercache/shaun-glass/filecache/61
  /data3/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/spark-204e7f9d-9d63-4967-8e43-e749525ea3d5/userFiles-98180e25-bf07-4552-ab24-9bed0d480a3e
  /data10/yarn/nm/filecache/38182/spark-core_2.12-3.4.2-khp-p1.jar
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/pyspark.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/py4j-<IP_ADDRESS>-src.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/src-develop.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/venv/lib/python39.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/venv/lib/python3.9
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/venv/lib/python3.9/lib-dynload
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/venv/lib/python3.9/site-packages
  warnings.warn(
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
========== onJobStart branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
========== onStageSubmitted branch feature/support-exists-context
[1, 4, 9, 16, 25]
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
========== onStageCompleted branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
========== onJobEnd branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>
Traceback (most recent call last):
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/local_test_before_create_spark_session.py", line 21, in <module>
    spark.read.csv("/path/deos/not/exist/error/raise")
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/pyspark.zip/pyspark/sql/readwriter.py", line 727, in csv
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/py4j-<IP_ADDRESS>-src.zip/py4j/java_gateway.py", line 1322, in __call__
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902480/container_e75_1714610955181_1902480_01_000001/pyspark.zip/pyspark/errors/exceptions/captured.py", line 175, in deco
pyspark.errors.exceptions.captured.AnalysisException: [PATH_NOT_FOUND] Path does not exist: hdfs://hadoop-dev/path/deos/not/exist/error/raise.
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7f541bd0a1e0 name=None type=ScopeType.ISOLATION>

🔴 sentry_init after create spark session

listner works well
breadcrumbs can't send
code is same as local
log

============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/pyspark.zip/pyspark/context.py:350: RuntimeWarning: Failed to add file [https://t1.kakaocdn.net/dip3_file_server/du-batch/src-develop.zip] specified in 'spark.submit.pyFiles' to Python path:
  /data6/yarn/nm/usercache/shaun-glass/filecache/49
  /data2/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/spark-a94f8bbf-54f7-474c-bea5-daae589835e0/userFiles-df4c01ac-5b3a-4878-a1ab-a9d5ecbcec27
  /data8/yarn/nm/filecache/300328/spark-core_2.12-3.4.2-khp-p1.jar
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/pyspark.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/py4j-<IP_ADDRESS>-src.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/src-develop.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/venv/lib/python39.zip
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/venv/lib/python3.9
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/venv/lib/python3.9/lib-dynload
  /data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/venv/lib/python3.9/site-packages
  warnings.warn(
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  None
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b520 name=None type=ScopeType.ISOLATION>
========== onJobStart branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b520 name=None type=ScopeType.ISOLATION>
========== onStageSubmitted branch feature/support-exists-context
[1, 4, 9, 16, 25]
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b520 name=None type=ScopeType.ISOLATION>
========== onStageCompleted branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b520 name=None type=ScopeType.ISOLATION>
========== onJobEnd branch feature/support-exists-context
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b1e0 name=None type=ScopeType.ISOLATION>
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b1e0 name=None type=ScopeType.ISOLATION>
Traceback (most recent call last):
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/local_test_after_create_spark_session.py", line 22, in <module>
    spark.read.csv("/path/deos/not/exist/error/raise")
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/pyspark.zip/pyspark/sql/readwriter.py", line 727, in csv
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/py4j-<IP_ADDRESS>-src.zip/py4j/java_gateway.py", line 1322, in __call__
  File "/data4/yarn/nm/usercache/shaun-glass/appcache/application_1714610955181_1902580/container_e75_1714610955181_1902580_01_000001/pyspark.zip/pyspark/errors/exceptions/captured.py", line 175, in deco
pyspark.errors.exceptions.captured.AnalysisException: [PATH_NOT_FOUND] Path does not exist: hdfs://hadoop-dev/path/deos/not/exist/error/raise.
============ sentry_sdk/scope.py line:284 isoloation_scope = _isolation_scope.get() =  <Scope id=0x7fcba548b1e0 name=None type=ScopeType.ISOLATION>

Oh, I think I might have figured out the cause. When _activate_integration is called, the address set is the one before it gets set to None. After that, the address changes, which is why it doesn't work properly. Passing the scope should fix the problem! I’ll make the changes and add comments if it words!

https://github.com/getsentry/sentry-python/pull/3411/commits/f26f5508eec8d2b934077d0f0f3be92b20693619
This is my temporary fix logic. I tested it, and it works well with these changes (master local and yarn). However, I'm not sure if it's the right approach. If you could provide any advice, I would be happy to rewrite the temporary logic.

Besides the item I mentioned above, this PR looks mostly good. Once it is addressed, I will re-review, and hopefully we can merge the PR then. Please also fix the failing linter CI action.
Thanks for the contribution!

@szokeasaurusrex resetting the clock on this one, let's try to get it in if it's okay now

@sl0thentr0py this comment has still not been addressed, the PR still sets the global scope as the isolation scope, which as far as I am aware is a big no-no.
@seyoon-lim are you still interested in working on this? If not, it might be time for our team to take over work on this PR

@sl0thentr0py @szokeasaurusrex
Hey, firstly, thanks for reminding me about this PR!
In my use case, I haven't noticed any major issues with the current state of the PR, so I haven't looked into it further!
It would be great if this issue could be taken over and the above functionality could be used in an official version of Sentry someday—that would be very, very welcome!
Thanks!

Hey @seyoon-lim,
some more time passed, but I have added some suggestion to fix the remaining problem. Would you be so nice to apply this suggestion in my review to your code and test if it is still working as before? If yes I guess we can merge this. 🎉

Hey @seyoon-lim thanks again for the contribution! It took a while to merge it, but we want to make sure everything we merge is of good quality

@antonpirker , @szokeasaurusrex
You're welcome! I'm glad it got merged thanks to your great review! Once it's released, I can use the official version instead of the custom build. Thank you once again!


Formatting exponentially creates newlines after each self closing tag with 1.4.2 update

Operating System (+Version): MacOS 10.12.6
VS Code Version:  1.26.1
beautify Version: 1.4.2

VS Code settings:
{

    "editor.formatOnSave": true,
    "editor.wordWrap": "on",
    "html.format.wrapLineLength": 0, // no wrap
    "html.format.unformatted": "a, abbr, acronym, b, bdo, big, br, button, cite, code, dfn, em, i, img, input, kbd, label, li, map, object, q, samp, select, small, span, strong, sub, sup, textarea, tt, var, script, p, head, style, /html",
    "files.trimTrailingWhitespace": true,
    "files.insertFinalNewline": true,
    "html.autoClosingTags": false,
    "editor.renderControlCharacters": true,
    "editor.renderWhitespace": "none"
}

Action performed
Format on save, no changes expected

_

Actual results
All self-closing elements have a new line added after the element.

_

Additional notes

This began immediately after the 1.4.2 update.
Self-closing elements contained within another non-closing element (e.g. within second div content) the new line is not added.
Every save results in additional lines. The second save adds two new lines. Third save adds 4, and so on.
If the plugin is disabled, the behaviour stops.
If I comment out "html.format.unformatted" in settings this behavior stops.

I've set up an environment with exactly your settings, and I can't replicate the issue. There have been cases where multiple formatters interact poorly with each other. Perhaps try disabling any other extensions which may providing a formatter (such as Prettier) and enabling beautify again. Sorry you're having this issue.

This is a upstream issue with the beautifier. It should be resolved now with this issue.

Try latest version? Have rolled in new upstream.

That did the trick! Thanks


Create Dijkstra_Algorithm.cpp

Assigned Issue Number ?
#257
Language Opted ?
C++
Number of files added or updated ?
1
Name of these files ?
Algorithms =>Graph_Algorithms =>Dijkstra=>Dijkstra_Algorithm.cpp
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Dijkstra's Algorithm implemented using C++ STL


libqmi: 1.18.0 -> 1.20.0

Semi-automatic update. These checks were performed:

built on NixOS
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-network --help got 0 exit code
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-network --version and found version 1.20.0
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmicli -h got 0 exit code
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmicli --help got 0 exit code
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmicli -V and found version 1.20.0
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmicli --version and found version 1.20.0
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-firmware-update -h got 0 exit code
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-firmware-update --help got 0 exit code
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-firmware-update -V and found version 1.20.0
ran /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0/bin/qmi-firmware-update --version and found version 1.20.0
found 1.20.0 with grep in /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0
found 1.20.0 in filename of file in /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0

cc "@wkennington"

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘libqmi-1.20.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/libqmi/default.nix:24 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
checking for references to /tmp/nix-build-libqmi-1.20.0.drv-0 in /nix/store/zv2yn5d1z16kcmi5p3766mh5v5imp8ky-libqmi-1.20.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/ip3y9g5znqv84s66x83i7a5q0c20caqa-libqmi-1.20.0-dev
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ip3y9g5znqv84s66x83i7a5q0c20caqa-libqmi-1.20.0-dev/lib
patching script interpreter paths in /nix/store/ip3y9g5znqv84s66x83i7a5q0c20caqa-libqmi-1.20.0-dev
checking for references to /tmp/nix-build-libqmi-1.20.0.drv-0 in /nix/store/ip3y9g5znqv84s66x83i7a5q0c20caqa-libqmi-1.20.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/4hf1rsgqar3x7j8nxjk8d3q4n44mll30-libqmi-1.20.0-devdoc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/4hf1rsgqar3x7j8nxjk8d3q4n44mll30-libqmi-1.20.0-devdoc
checking for references to /tmp/nix-build-libqmi-1.20.0.drv-0 in /nix/store/4hf1rsgqar3x7j8nxjk8d3q4n44mll30-libqmi-1.20.0-devdoc...

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/08xqyb1dnds6n53rmi6j46zikc9qxycc-libqmi-1.20.0-dev
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/08xqyb1dnds6n53rmi6j46zikc9qxycc-libqmi-1.20.0-dev/lib
patching script interpreter paths in /nix/store/08xqyb1dnds6n53rmi6j46zikc9qxycc-libqmi-1.20.0-dev
checking for references to /build in /nix/store/08xqyb1dnds6n53rmi6j46zikc9qxycc-libqmi-1.20.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/2hn26mji715ikfig26qwxaxvc1hllcz0-libqmi-1.20.0-devdoc
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/2hn26mji715ikfig26qwxaxvc1hllcz0-libqmi-1.20.0-devdoc
checking for references to /build in /nix/store/2hn26mji715ikfig26qwxaxvc1hllcz0-libqmi-1.20.0-devdoc...
/nix/store/5wjw6ly5y7hcf102npvrpsf238kfr0fa-libqmi-1.20.0


Add ability to specify custom pre and post_translations.sh scripts

Related Issue: https://github.com/ansible/ansible-collection-memsource/issues/39
Problem

Some projects don't want to vendor the pre_translations.sh and post_translations.sh scripts in their code repository for fear that further down the line when doing spring cleaning, folks will see that those scripts aren't called anywhere in the project itself and mistakenly delete them.
There is also a need for making and testing changes in these scripts over time.

Solution

Provide the ability to specify a local script to be copied into the app repo's clone and executed by the pre/post translations roles accordingly.
This allows the script to live in a separate repository from the application itself if desired.

Usage
ansible-playbook roles/test-pull.yml -e memsource_username=$MEMSOURCE_USERNAME -e memsource_password=$MEMSOURCE_PASSWORD \
-e fork_repo_url="rooftopcellist/pinakes" \
-e repo_url="ansible/pinakes" \
-e repo_branch="devel" \
-e project_name="service-catalog-aap-2.3.0-1" \
-e local_shell_script_path="/clone-of-team-automation-repo/localization/scripts/pinakes_post_translation.sh" \
-e @vars.yml

Future Improvements

We could allow users to specify a URL for local_shell_script_path if desired, this would also allow users to have this script live on a fork in their code repo if desired.

Looks good to me, as per the PR if we provide the local translation shell scripts, a directory will be created, scripts will be moved to the desired clone directory and the script would proceed as usual which seems a great approach.


Question on how trainable color can be defined per vertex, while there are varying number of vertices for every iteration during mesh optimization.

Hi, Thanks for the great work!
I was reading your work, and wondered how nvdiffrast can be actually implemented to render an image from a mesh that is being trained.
From my understanding, mesh from DPSR + Diff.MC during optimization can have varying number of vertices for every iteration.
In this case, how can a trainable color be defined for each vertex for every iteration?
Thank you in advance.

Hi @deepshwang, sorry for the late reply, and thanks for your interest in our work! We optimize the vertex colors through an MLP, which takes the position of the vertices as input and outputs the RGB colors.


Jetty client intercept HttpRequest send with two args may be more userful

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.

If I use HttpRequest with send(CompleteListener listener) or send(Request request, CompleteListener listener) the SyncHttpRequestSendInterceptor is not effective.

How to fix?

New feature or improvement

Describe the details and related test reports.

Coverage increased (+0.005%) to 16.862% when pulling b49b0dc31f0dc3563fdb77dd92c637e83b6d9548 on IAMTJW:jetty-client into 4f89ea2704e560ca93d5fcd5830679c9db82c2cd on apache:master.

The jetty plugin only supports to trace the send method, because this method is a synchronization call, but the send method with two parameters is the asynchronous call. If you want to supports to trace the asynchronous call, You should add new instrumentation to support it.

According to Xin's response, I think we can't accept this pull request. But, the new instrumentation of async jetty is welcome.

The jetty plugin only supports to trace the send method, because this method is a synchronization call, but the send method with two parameters is the asynchronous call. If you want to supports to trace the asynchronous call, You should add new instrumentation to support it.

Why cant support asynchronous call，the SyncHttpRequestSendInterceptor afterMethod just call ContextManager.stopSpan() and not do other thing. I think it has nothing to do with the synchronization or asynchronous call. The jetty plugin  supports to trace the called service and not care about the response.

SkyWalking agent core requires you to understand sync and async very clearly. If you have doubt, you need to read agent core codes, and understand how agent does tracing and context propagation.

You should also need to trace the listener if you want to support
asynchronous call.
归田<EMAIL_ADDRESS>周三上午9:36写道：

The jetty plugin only supports to trace the send method, because this
method is a synchronization call, but the send method with two parameters
is the asynchronous call. If you want to supports to trace the asynchronous
call, You should add new instrumentation to support it.
Why cant support asynchronous call，the SyncHttpRequestSendInterceptor
afterMethod just call ContextManager.stopSpan() and not do other thing. I
think it has nothing to do with the synchronization or asynchronous call.
The jetty plugin supports to trace the called service and not care about
the response.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/apache/skywalking/pull/2774?email_source=notifications&email_token=AC64HXZEN52UXMYAQDPZINTPXXM2NA5CNFSM4HQBCK7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWN453I#issuecomment-496750317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC64HX7KE2WPSKJBOBLAYXDPXXM2NANCNFSM4HQBCK7A
.

--
Regards,
Xin


Auto-tests for the new alg

The automatic tests are using the initial code. Let's update the code to do testing of the new algorithm + add more test data.

In test/test_basic.py there are some initial tests, at the end of the file there is a to-do with some more things to test.