Add EKS service costs to cost model

AWS has an hourly cost for the EKS service itself - Azure and GCP do not.
If the provider=AWS and platform=EKS, then we should add this to the overall cluster costs. Seems like provider can be determined by the K8s version (for example: v1.12.6-eks-...).

Completely agree. This brings up an interesting allocation question that is somewhat similar to #103. Namely, who pays for this cost...
I also like the idea of supporting both provider and platform. I'm not sure the best way to capture the latter, but on the surface your suggestion looks like a good one!

@AjayTripathy and I discussed last week. He's actively working on part 1 of this, which is exposing the host "platform". We expect this to be in the next release. Thanks again for suggesting this!

#122 provides "management platform" information in the cost model

This is now supported with an external key, but we are considering also adding it to the new shared costs field. Matt, let me know if you have any suggestions/preferences. Also, hope you are doing well :)

We have a custom field now called "shared overhead" that can be used to allocate management  costs.


Refactor to handle statewide court site search

Refactor Runner and SitesMeta/sites_meta.csv to handle a single court site where all counties can be searched, as is the case for Arkansas

I propose that the existing design is sufficient. Treating every county as its own system is the best practice because it will reduce confusion among users and reflect similar situations where a supported platform is used across multiple jurisdictions that will each have their own state_countyname. To provide support for scraping all court data in one state, we should identify them as state_statewide and factor statewide platforms to handle this as an option.

@ryanelittle Works for me. We can always revisit this in the future if statewide queries become a thing end users are requesting.


Server side streaming

Proto file(s)
rpc SubscribeChannels(SubscribeChannelsRequest) returns (stream Message)
rpc CreateMessage(CreateMessageRequest) returns (Message)

message CreateMessageRequest {
    string parent = 1;
    Message message = 2;
}
message Message {
    string name = 1;
    string message_type = 2;
    map<string, string> data = 3;
}

message Subscription {
    string channel_name = 1;
    string last_message_name = 2;
}
message SubscribeChannelsRequest {
    repeated Subscription subscriptions = 1;
}

Command line arguments / config
ghz --stream-interval=30s --call myService.SubscribeChannels \
    -d '{"subscriptions": [{"channel_name": "channels/test"}]}' \
    myHost:443

While, that is happening, I have tried hitting the endpoint with grpcurl to CreateMessage
grpcurl -d '{"message": {"name": "channels/test/messages/m2", "data": {"test-body":"test-body"}}, "parent": "channels/test"}' myHost:443 myService.CreateMessage

Describe the bug
I get an error:
Summary:
  Count:	200
  Total:	80.01 s
  Slowest:	0 ns
  Fastest:	0 ns
  Average:	20.00 s
  Requests/sec:	2.50

Response time histogram:

Latency distribution:

Status code distribution:
  [DeadlineExceeded]   200 responses

Error distribution:
  [200]   rpc error: code = DeadlineExceeded desc = context deadline exceeded

To Reproduce

Have the service up
Run ghz command

Expected behavior
The behavior of my service is the following:
I have two endpoints. When I hit SubscribeChannels, it's supposed to hang forever.
I send a CreateMessage request. I want the latency between sending a CreateMessage request and SubscribeChannels endpoint to receive the Message. Is the possible using the ghz tool, and if so, how do I accomplish this?
Environment
ghz: 0.59.0

Hello, I am not sure if I understand the issue correctly, but if SubscribeChannels call hangs and does not return a response ever we would expect the result to be an DeadlineExceeded error. Note that the default timeout is 20s. This all seems to line up with the results you are seeing. You may try setting that to 0 to indicate indefinite call and see if that makes a difference. If I am understanding the context correctly, note that if the call hangs and never sends a response message back in the stream, the stream interval option is not very meaningful or useful here.

We are seeing something similar in the sense that server streaming endpoints (where you get an initial state of the world and subsequent data updates) always end up with error codes from either timeouts/deadline exceeded or client cancellation.
I've tried specifying a timeout of 0 to indicate indefinite call but how do we get final results after some time?
I was wondering what is the right way to make server streaming endpoints produce relevant metrics.
I've tried specifying the following options:
--timeout=0 --duration=30s --duration-stop=wait --total=50 never completes.
--timeout=0 --duration=30s --duration-stop=ignore--total=50 completes with no metric outputs.
--timeout=0 --duration=30s --duration-stop=close --total=50 which always completes with:
`Status code distribution:
[Canceled]   50 responses
Error distribution:
[50]   rpc error: code = Canceled desc = grpc: the client connection is closing`
Would it be possible to add a new --duration-stop cancel option or similar that then reports metrics from the server streaming call up to requested cancellation?

Hello, thanks for additional comments on this issue. I think I understand the request; which seems slightly different from the original question as I understood it since the original comment said the server "hangs". But I see what you mean in that ghz doesn't really provide a control mechanism to end the stream client-side. This is somewhat similar to #184, but the control predicate is really just a timeout where we close the stream in ghz client. Is this correct summary of the issue? My time is limited right now, but hopefully I can get to this in the near future.

Exactly this is the correct summary. Thanks @bojand for your reply

I think this should be addressed with the options introduced in 0.80.0.

I think this should be addressed with the options introduced in 0.80.0.

Hi @mml21 @bojand  @chhavi-peloton
I've similar issue when call grpc server streaming with new options in 0.80.0 release, like -stream-call-duration 10000ms,--stream-call-count=10
Summary:
Count:	1
Total:	20.00 s
Slowest:	0 ns
Fastest:	0 ns
Average:	20.00 s
Requests/sec:	0.05
Response time histogram:
Latency distribution:
Status code distribution:
[DeadlineExceeded]   1 responses
Error distribution:
[1]   rpc error: code = DeadlineExceeded desc = context deadline exceeded
however, when I use BloomRPC tool with same proto file to call grpc method, which is successful. I mean server streaming response can response well.
attach my data for you reference
Proto file(s):
service TrService {   rpc GetTrafficData(TrRequest) returns (stream TrResponse) {} }
ghz --insecure
--proto ./trafficproxy.proto
--call trafficproxy.TrafficService.GetTrafficData
*--stream-call-duration 10000ms *
--total=1
*--stream-call-count=10 *
-d '{xxxxx}'
my.company.dns.com:10086
Could you please give me any suggestion?
Thanks in advance


Windows: Move temp files to Temp directory.

For Windows compilations of OpenDCDiag, temp files were created in directory where the .exe is placed. The application doesn't always have access rights to do that.
Changes here move all temp files to Windows designated area: C:\Users%username\AppData\Local\Temp
Signed-off-by: dawid-sabat<EMAIL_ADDRESS>

I noticed that this change breaks selftests in a way I don't completely understand. I suspect there might something wrong with wine configuration but I'm not sure.
not ok 1 Verify that the python yaml module can import regular output
# (from function `run_sandstone_yaml' in file bats/sanity-check/../testenv.bash, line 87,
#  in test file bats/sanity-check/[10](https://github.com/opendcdiag/opendcdiag/actions/runs/3657877805/jobs/6181966319#step:10:11)-yaml-validate.bats, line 9)
#   `run_sandstone_yaml --retest-on-failure=0 --selftest --timeout=60s --quick -e @positive' failed
# + wine builddir-windows-cross/opendcdiag.exe --on-crash=core --on-hang=kill -Y -o - --retest-on-failure=0 --selftest --timeout=60s --quick -e @positive
# internal error creating temporary file: File too large

Any ideas?

@lukasz-tuz  and I made some experiments about opendcdiag selftests failing:

tried to recreate the same conditions as CI (the compiller, libs etc) locally
from my end I noticed that selftests and opendcdiag.exe works with wine outside the docker container.
Lukasz has been debugging on his end and he's going to describe his effort.

@lukasz-tuz and I made some experiments about opendcdiag selftests failing:

tried to recreate the same conditions as CI (the compiller, libs etc) locally
from my end I noticed that selftests and opendcdiag.exe works with wine outside the docker container.
Lukasz has been debugging on his end and he's going to describe his effort.

I recreated the conditions on Wine by simply doing a cd / before launching it. For the BATS testing, we need to check that the output log file (if not stdout) has a full path). We should do that for Unix too.

Lack of full path to output log file is only part of this (albeit needs to be fixed). However:

default Wine prefix doesn't seem to have %TEMP% or %TMP% variables; they need to be added manually, and need to be added to the registry file in the Wine prefix being used. Passing them as shell environment variables is not sufficient (see Wine User Guide).
Need to ensure that directory pointed to by %TEMP% has write permissions set
even with the steps above completed, opendcdiag.exe would still fail when trying to truncate the temp file with ftruncate. As @dawid-sabat observed, this does not happen with more up-to-date version of Wine (I used 7.22 in my tests). Older version (7.2) fails with EFBIG error, although length passed to ftruncate is just 65 kB.

Going to run a targeted test, where previously failing environment gets a Wine update (and just Wine, to rule out any other dependencies).

I don't know where the environment came from in my ~/.wine/user.reg, but it does show:
[Environment]<PHONE_NUMBER>
#time=1d7ae34b87983e8
"PATH"="C:\\windows\\system32;C:\\windows;C:\\windows\\system32\\wbem;C:\\windows\\system32\\WindowsPowershell\\v1.0;C:\\MinGW\\bin;C:\\Qt\\qtbase\\bin"
"QT_FORCE_STDERR_LOGGING"="1"
"TEMP"="C:\\users\\tjmaciei\\Temp"
"TMP"="C:\\users\\tjmaciei\\Temp"

I don't remember setting them and I probably wouldn't have set them to the path that is shown there (I'd choose "Z:\tmp"), but the other two variables are definitely me.
Another thing is that tracing its execution shows just how Wine executes GetTempPathW:
1515859.354:00dc:00e0:Call KERNEL32.GetTempPathW(000000f9,0081e6a0) ret=140020632
1515859.354:00dc:00e0:trace:process:GetEnvironmentVariableW (L"TMP"<PHONE_NUMBER>81E350 260)
1515859.354:00dc:00e0:Call ntdll.RtlInitUnicodeString(0081e2d0,7b08bd14 L"TMP") ret=7b05c2d7
1515859.354:00dc:00e0:Ret  ntdll.RtlInitUnicodeString() retval=00000008 ret=7b05c2d7
1515859.354:00dc:00e0:Call ntdll.RtlQueryEnvironmentVariable_U(00000000,0081e2d0,0081e2e0) ret=7b05c305
1515859.354:00dc:00e0:trace:environ:RtlQueryEnvironmentVariable_U<PHONE_NUMBER>000000 L"TMP"<PHONE_NUMBER>81E2E0
1515859.354:00dc:00e0:Ret  ntdll.RtlQueryEnvironmentVariable_U() retval=00000000 ret=7b05c305
1515859.354:00dc:00e0:Call ntdll.RtlGetFullPathName_U(0081e350 L"C:\\users\\tjmaciei\\Temp",00000208,0081e350,00000000) ret=7b01d1e4
1515859.354:00dc:00e0:trace:file:RtlGetFullPathName_U (L"C:\\users\\tjmaciei\\Temp"<PHONE_NUMBER>00081E350<PHONE_NUMBER>000000)
1515859.354:00dc:00e0:Ret  ntdll.RtlGetFullPathName_U() retval=0000002c ret=7b01d1e4
1515859.354:00dc:00e0:Call ntdll.memset(0081e6d0,00000000,000001c2) ret=7b01d390
1515859.354:00dc:00e0:Ret  ntdll.memset() retval=0081e6d0 ret=7b01d390
1515859.354:00dc:00e0:trace:file:GetTempPathW returning 23, L"C:\\users\\tjmaciei\\Temp\\"

That is, the darned thing does a GetEnvironmentVariableW! I don't know what real Windows does, but we can assume it's maybe smarter than this.

I've just tested this patch with Wine 7.22 on Arch Linux, with and without WINE_ROOT set. The selftests launch and (mostly) pass. I get a BATS failure on selftest_fastfail but that seems unrelated (it's expecting code 0xC0000005 but getting 0xc0000409).

the darned thing does a GetEnvironmentVariableW! I don't know what real Windows does, but we can assume it's maybe smarter than this.

Well, it probably isn't. Quoting the documentation for GetTempPathW:

The GetTempPath function checks for the existence of environment variables in the following order and uses the first path found:

The path specified by the TMP environment variable.
The path specified by the TEMP environment variable.
The path specified by the USERPROFILE environment variable.
The Windows directory.

Note that the function does not verify that the path exists, nor does it test to see if the current process has any kind of access rights to the path.

The last one probably just looks for %WINDIR%.

get a BATS failure on selftest_fastfail but that seems unrelated (it's expecting code 0xC0000005 but getting 0xc0000409)

Same result here.

Ah, the problem was right there, staring me in the face:
// MinGW's ftruncate64 tries to check free disk space and that fails on Wine,
// so use the the 32-bit offset version (which calls _chsize)

And the following typo:
#    undef fruncate

After changing to
#    undef ftruncate

opendcdiag stops failing when trying to truncate the temp file with ftruncate.


Add control with inline math rendering capabilities

Current custom control would be cumbersome to use to produce paragraphs of text with inline math or longer flowing text with math as separate lines. See example below
http://marked2app.com/help/images/mathjax2.jpg
A control based on, e.g., a textbox, but with added handles such as [$, $] that uses the renderer would be a very useful addition.
EDIT
Did some research on this. Perhaps a using BlockUIContainer and InlineUIContainer inside a FlowDocument is a better way to go.

Yes, that's right. Today WPF-Math doesn't help much with formatting whole TeX documents within WPF forms or documents.
I believe that FlowDocument is the way to go, but I'd like someone (including myself) to conduct more research on that, and maybe even implement some simple prototype. I still don't know what changes that'll require, and we need to ascertain that before doing anything.

I think this would be beyond the scope of the project. It would be great if someone implements this, but I think it's a big project, and probably best we stay clear of it for now.

I've looked at the FlowDocument tag a bit and it turns out adding WPF-Math is really not that hard, if you can accept not being able to use the standard $...$ pattern. By changing the <border> section of the example with the following:
<Border Margin="10,0,10,10" BorderBrush="LightGray" BorderThickness="1" Grid.Row="3" Grid.Column="0">
    <FlowDocumentScrollViewer>
        <FlowDocument>
            <Paragraph>
                Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce faucibus odio arcu, luctus vestibulum tortor congue in. Lorem ipsum dolor sit amet, consectetur,
                <InlineUIContainer BaselineAlignment="TextBottom">
                    <controls:FormulaControl x:Name="formula1" Formula="\sum d\theta = \tan^{-1}\theta+C" Scale="12" SnapsToDevicePixels="True"/>
                </InlineUIContainer>
                adipiscing elit. Fusce nec lacinia neque. Donec malesuada, ligula non vestibulum cursus, urna purus pellentesque orci,
                aliquet accumsan dui velit ac justo.
            </Paragraph>
            <BlockUIContainer>
                <controls:FormulaControl x:Name="formula" Formula="L = \int_a^b \sqrt[4]{ \left| \sum_{i,j=1}^ng_{ij}\left(\gamma(t)\right) \left[\frac{d}{dt}x^i\circ\gamma(t) \right] \left{\frac{d}{dt}x^j\circ\gamma(t) \right} \right|}dt" Scale="12" SnapsToDevicePixels="True"/>
            </BlockUIContainer>
            <Paragraph>
                Nulla vitae suscipit tellus. Nunc sit amet tortor fermentum, sollicitudin enim cursus, sagittis lacus. Pellentesque tincidunt massa nisl, nec tempor nulla
                consequat a. Proin pharetra neque vel dolor congue, at condimentum arcu varius. Sed vel luctus enim. Curabitur eleifend dui et arcu faucibus, sit amet
                vulputate libero suscipit.
            </Paragraph>
        </FlowDocument>
    </FlowDocumentScrollViewer>
</Border>

You actually get something that looks decent. The problem with the inline container is that the baseline, of course, is off. So essentially, what's needed, is a way to switch between the normal and in-line rendering of the formula.
Loving this project. Wish there was a way I could contribute in a meaningful way. Trying to get into the code, but it's a slow process :)

Okay, well maybe we could created a contrib repository and put your control there, if you get it working a bit more smoothly. :) It's been a long time since I did anything with flow documents, but that's good you've made some initial success.

On the topic of inline vs. display. How are these things handled by existing TeX parsers? Are there two character sets or is the existing character set adjusted to a different environment?

@alexreg I don't think we need to split our project into more fragments at the moment. If we can have a decent and non-intrusive solution to use WPF-Math in <FlowDocument> context, I'll vote to accept such contribution and include in into the main code base.
Side note: I'll be absent from March 23rd to 24th on a small scientific trip; I hope you'll be fine here guys 😄

Hmm, well it's your decision @ForNeVeR, but I think it should at the least be in a separate VSproj, if not a separate repository.

I think I managed to create a control that can render the formula control with normal text, but a lot of the features are still under development. I Would push it when it is quite decent.

I would very much ask you to please create a separate branch for that.

I will


Adding a former known device to a location will get the old zone listed even it is in no zone.

Adding a former known device to a location will get the old zone listed even it is an no zone.
I know its a repost of an older issue  but i could not find the "reopen" button.
Browser: chrome v51 for win 7 x64 / frontend: app.ctapp.io and other

basicly i expect the zone fields to be empty if there isn't any zone assigned during adding process  (manuell/ automatic)

The AP is not added to a zone.
Looks like a visual on the device list.
@ariandora @gflohr any ideas?

Fixed on the backend also.


[Question]Same vm_id with different code

I see from the OVERVIEW, we could reuse a vm in each Thread to save resources. I want to know what will happen if two different wasm code apply the same vm_id( which means they have their own RootContext implementation?)

assuming what you mean by wasm code is a Wasm binary, then envoy creates an entirely different VM, not sharing the VM.


Replacing return codes with exceptions

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes #52
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

@bethune-bryant - While you're doing this cleanup,  I also have a thought of having constants.py where we can put all the DEFAULT* variables which are right now in utils.py and some are in docker_build.py.

@bethune-bryant - While you're doing this cleanup, I also have a thought of having constants.py where we can put all the DEFAULT* variables which are right now in utils.py and some are in docker_build.py.

@npanpaliya
This is a really good idea. I'll probably do this in a another issue to keep things clean.


Still detected by vmprotect 3.x

tested under win7 x64 7601 guest , with patched&signed VBOXDD.dll, it failed to pass vmprotect 3.1.2 vm detection.

Can you figure out what it detect?

I guess vmprotect use CPUID+RDTSC to detect.

It passed nearly all checks from https://github.com/LordNoteworthy/al-khaser except power_capabilities, rdtsc_diff_locky and rdtsc_diff_vmexit, and I confirmed by monitoring syscall that the packed program never calls NtPowerInformation or NtQuerySystemInformation+SystemFirmwareTableInformation

I found that both two instructions are executed by packed program for multiple times, when I load https://github.com/tandasat/HyperPlatform/tree/master/HyperPlatform it also detect the real os (but virtualized by self) as virtual.

I am not able to find a way to hide elapsed time of vbox vm-exit.

Well wontfix then. Thanks for looking on this.

found another vbox detection vector, confirmed by using HyperPlatform to monitor cpuid instruction.

int filter(EXCEPTION_POINTERS * pException, BOOL *pFound)
{
    auto code = *(BYTE*)pException->ContextRecord->Eip;

    printf("cpuid exception eip = %p code = %02x\n", pException->ContextRecord->Eip, code);

    //code != nop, in vmm
    if (code != 0x90)
        *pFound = TRUE;

    return EXCEPTION_EXECUTE_HANDLER;
}

BOOL cpuid_test()
{
    BOOL bFound = FALSE;
    __try
    {
        __asm
        {
            mov eax, 0
            pushfd;
            or DWORD ptr[esp], 0x100;
            popfd;//set TF=1
            cpuid;
            nop;//normal TF
            int 3//in vmm...
        }
    }
    __except (filter(GetExceptionInformation(), &bFound))
    {
        ;
    }
    return bFound;
}

IEM_STATIC void iemRegAddToRipAndClearRF(PVMCPU pVCpu, uint8_t cbInstr)
{
    pVCpu->cpum.GstCtx.eflags.Bits.u1RF = 0;

    AssertCompile(IEMMODE_16BIT == 0 && IEMMODE_32BIT == 1 && IEMMODE_64BIT == 2);
#if ARCH_BITS >= 64
    static uint64_t const s_aRipMasks[] = { UINT64_C(0xffffffff), UINT64_C(0xffffffff), UINT64_MAX };
    Assert(pVCpu->cpum.GstCtx.rip <= s_aRipMasks[(unsigned)pVCpu->iem.s.enmCpuMode]);
    pVCpu->cpum.GstCtx.rip = (pVCpu->cpum.GstCtx.rip + cbInstr) & s_aRipMasks[(unsigned)pVCpu->iem.s.enmCpuMode];
#else
    if (pVCpu->iem.s.enmCpuMode == IEMMODE_64BIT)
        pVCpu->cpum.GstCtx.rip += cbInstr;
    else
        pVCpu->cpum.GstCtx.eip += cbInstr;
#endif
}

It seems there is no way to fix this unless I add rflags.TF check by myself and recompile the vboxvmm component.

You may try to submit this to Oracle as bug. Few years ago the fixed similar bug which also was abused in vm detection.

Still detected by VMP 3.3.x and above
Guest - Win7 7601 x64
Log from al-khaser: https://pastebin.com/bqW2RsVW


Warn when topic format is incorrect.

When subscribeToTopic or unsubscribeFromTopic are called, they should
not be passed in with the prefix "/topic/". Calling those functions with
a string prefixed with "/topic/" will now print a warning.

I need to change the branch, so I'm going to re-do the pull request.


Don't check preview window

What problem are you trying to solve?

syntastic check syntax and open location-list for preview window, which is unnecessary.

Syntastic needs a file of a known filetype to even consider running checks.  If your preview window actually corresponds to a file on disk, then whatever set it that way is badly broken.  Also, your patch is wrong.  But whatever, it's an easy fix, please see 281b294.


Generate new page

Ionic version:  (check one with "x")
[ ] 1.x
[X] 2.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[X] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
This request has two parts:

When a new page is generated, we need to manually add the page to the app.module.ts file under declarations and also entryComponents.  It would be nice to automatically add this when we run the command "ionic g page {nameOfPage}"
When we generate a page with the command "ionic g page {nameOfPage}" the command does not check to see if the page/directory already exists.If it does exist it overwrites the existing page without asking or notifying the user.  Overwriting an existing page is not ideal for the user.

Expected behavior:

When we run the command "ionic g page {nameOfPage}", it would be preferable if the page was also added to the app.module.ts file so the user would not have to do that manually.
If the page/directory already exist the command would generate an error and not overwrite the existing page

Also please add support for sub-directories. E.g. "module1/page1" should generate Page1Page in "pages/module1/page1.ts" rather then Module1Page1Page in "pages/module1-page1.ts"

This issue was moved to driftyco/ionic-cli#1838


On joining public room for the first time: terms and conditions error

Error : "user could not accept terms and conditions"

Full description:
after Tchap installation and login, if the first user action is to join a public room, an error message is briefly displayed indicating that the user could not accept  the terms and conditions.


Inconsistent behavior between CPU and GPU for liebendorf deleptonization and cooling

Issue:
when using cooling_function with SASW/homologous problem. returns error:
:0: : block: [3,0,0], thread: [0,0,0] Assertion View bounds error of view p.density failed.
after first step
this backtraces to:
the cooling function
Host function was being called from device function leading to issues on GPU.

Steps Taken:

moved units calls outside of device kernels and saved as reals for call within kernel

@carlnotsagan do you encounter the same issue when running lightbulb with @mari2895 's CCSN problem initialization? If not maybe it has to do with changes in the SASW branch? Can you share the code for SASW in a PR?

thanks for merging main, should be all good now

Looks like tests are still failing?

looking into the fails. something to do with a reference to pmb


Console output is broken

Gauge version: 0.1.8

Plugins
-------
java (0.2.2)
ruby (0.0.6)
html-report (1.0.4)

This is what I see when I execute.

I also see lot of unwanted, verbose INFO messages.

Hi Navaneeth,
We changed the console logs to make it a little neater. It used to have a lot of information earlier on. Now, INFO has limited information but DEBUG will give you all the information you used to see earlier.
You can configure this using gauge --log-level=debug or --log-level=info. info is the default configuration.
If you are referring to the [INFO] against the console output, then this is an error. We will fix that shortly.

I am referring to the colored terminal we had before. By default, log level should be None. For user, all those messages are irrelevant. IMO, unless specified, logging should be turned off or probably write to a log file rather than console. Console should contain only colored spec & scenario execution info.

Earlier, we had our own code to print colored information on the console. But the latest version of the logging library that we are using supports colored output. So we decided to leverage it and refactored around it.
What refactoring changed is the colors that we were using earlier. This is because the default colors provided by go-logging library are not the same as ours. Moreover the library is not exposing an interface to change the default colors. We have created an issue for this and are waiting for their response.
We continued with the refactoring in spite of this known issue because most of the users run specs in parallel, in which case we anyways don't show colored output.
Turning off logging altogether is a separate discussion on its own. We have created a new issue for that.

Looks the logging library's last commit was some 6 months back. Which gives a me a feeling that it is not actively developed and not sure gauge depending on it will be a good idea.

We continued with the refactoring in spite of this known issue because most of the users run specs in parallel, in which case we anyways don't show colored output.

That is a wrong assumption. When developing test cases, no one runs it in parallel. You will run in it in parallel on a CI box but not while authoring tests. The colored output plays a big role while authoring test cases. It makes it easy for people to figure out the failure. It looks nice. What we get today is just text with some INFO messages. The specification to scenario to concept hierarchy is also not evident from the output.
I'd suggest to go back to the old colored output until the logging library has support for it.

it is not actively developed and not sure gauge depending on it will be a good idea.

Totally agree. We should re-validate our choice of logging library.

You will run in it in parallel on a CI box but not while authoring tests.

This is an interesting point.
We discussed this in the team today and concluded that we should speak to few end users, come up with a structure about what the logs should look like and change it accordingly.

We discussed this in the team today and concluded that we should speak to few end users, come up with a structure about what the logs should look like and change it accordingly.

Colored console output was designed after talking to many Twist customers. Feel free to redo the experiment, but not sure whether you will get a different result.
Also this is preventing me to pitch gauge to a potential customer.

@navaneeth We have coloured console output but admittedly the colours aren't as nice as what we had before. If you do change to use debug mode then there are colours, but we understand that is something we need to improve. I would like us to do this experiment again, and hopefully the result is no different.
Regarding the potential customer, we're very sorry to hear that the console log colours are causing so much trouble. This we did not anticipate. Like Mahendra said, we will get to this soon. In the meantime, if this is causing a lot of trouble, maybe you can use the previous version of Gauge(0.1.7), this has  the old console log format?
I hope this helps.

We have coloured console output but admittedly the colours aren't as nice as what we had before. If you do change to use debug mode then there are colours,

Ahh, I see them now. But they needs lot of polishing before pushing to the end user. The Spec-Scenario hierarchy is also not visible. There are ugly DEBUG prefixes everywhere and lot of unwanted newlines.

if this is causing a lot of trouble, maybe you can use the previous version of Gauge(0.1.7), this has the old console log format?

I did the demo by hacking my local copy. But to deploy on their infrastructure, I will use 0.1.7.

Any more thoughts/update on this?

Hey @navaneeth, we had a few discussions on this, expecting to put in some effort in the next few days. We are trying to figure out what can work for most users, whether through configurations or through sensible defaults. Will keep you posted.

To throw in my two cents, I want colored output when running Gauge specs in Intellij IDEA, but not when running them in the console (which we do on our CI environment). I agree that having colored output was an excellent feature in Twist, but I think it worked because it was a custom view within an IDE that was designed for developers.

@Thunderforge - we have an ambition of integrating Gauge with the Intellij test runner, so the experience is similar to JUnit test execution. But that is still a while away.
We still plan to retain the --simple-console flag, that would remove any colouring of terminals.

This is what I think

We should have colored and structured console output by default
Editors should run gauge with simple console flag or integrate with the standard way each editor displays test output

The issue that I was referring to is not just missing colors. But the structure. Keeping the spec to scenario to concept structure and nesting in the output is very important. Previous console output used to do this and buffer the stdout coming from step executions and color them properly. While the implementation was custom and may need polishing, it used to work well.

I would be happy with the behavior described by @navaneeth. It allows for console-specific and IDE-specific outputs. As long as --simple or a similar flag can turn off coloring and other information in the console, I think that this will be acceptable.

@navaneeth Colored console reporting is back in Gauge v0.3.0. It works on Windows as well!
Please give it a try and let us know what you think.
I am closing this issue. Feel free to reopen in case it doesn't work for you.


Extract query normalizer

TODO:

Fix specs in this PR and merge
Build an AST model.

Replaced by https://github.com/activedocument/activedocument/pull/18


Add feverous config to fever dataset

Related to: #4452 and #3792.

But this is somehow fever v3 dataset (see this link https://fever.ai/ under the dropdown menu called Datasets). Our fever dataset already contains v1 and v2 configs. Then, this is v3 config.

In any case, if you really think this should be a new dataset, then I would propose to create it on the Hub instead, as "fever/feverous".

In any case, if you really think this should be a new dataset, then I would propose to create it on the Hub instead, as "fever/feverous".

Yea makes sense ! thanks :) let's push more datasets on the hub rather than on github from now on


bitwise operation edge cases/fixes

This PR was abandoned a long while ago.
Another attempt at this would need to be aware of BYOND's differences in compile-time evaluation and runtime evaluation. We should decide whether to replicate this.
For example:
world.log << (~ -42) // BYOND evaluates at compile-time
world.log << (~ pick(-42)) // BYOND evaluates at runtime

gives (as of v515.1616),
16777215
41


Fix #12

Added a public Random property on Scientist, which is initialized to a better implementation and thread-safe calculation.

Nice! Let's go even simpler. Let's not make it a property of Scientist and just use this one private implementation.

Sounds good.  Should be good to go once appveyor picks it up.

Actually I think I misinterpreted you.  I'll need to move that to the ExperimentInstance class from Scientist.

Yeah, I think it should be a static private member of ExperimentInstance.

Have you been following the discussion in #12?

Yeah I should be able to address that no problem.

I reverted back to Random, and added a locking object to ensure thread-safety.  Also I integrated the .net core changes from master to ensure build compatibility.


Frontend

Hi is there a frontend that can be used with this pool?

No. It’s best to keep those two concerns separate.  The API is available for any custom website. Sent from my iPhoneOn May 3, 2024, at 10:15 PM, wombatlabs @.***> wrote:
Hi is there a frontend that can be used with this pool?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Do you know of one that would be a good starting point?

I don’t unfortunately. Sent from my iPhoneOn May 4, 2024, at 7:00 PM, wombatlabs @.***> wrote:
Do you know of one that would be a good starting point?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

A front end should be developed independently from the pool.


When create a proposal, execution period display error

Description
When create a proposal, execution period display error
Steps To Reproduce

Log in...
Ensure a DAO page
Create a Governance proposal, choose voters

Current Behavior

Execution period display error

Expected Behavior

Execution period should display correctly

Environment

Platform: PC
Node: v18.18.0
Browser: Chrome 126.0.6478.56

fixed confirm


Question about space of IPR

Thank you for your open-source code which contributes to the community!
I have a question about the IPRs. The DIRformer you proposed in your paper can be considered as an auto-encoder which takes IPRs and LR images as letent embeddings. During inference, the IPRs are actually generated from your DM conditioned on LR images.
However, it is a consensus that the latent spaces of auto-encoders are discrete. But IPRs (as one part of latent embeddings) are generated from DMs, meaning that the IPRs will be continuous. In order to address the problem of discrete latent spaces, a common method is to adopt a KL divergence of latent embeddings so that the latent embeddings can be continuous, as VAEs have done. However, it seems that you did not constrain the space of IPR. So, how can the generated IPRs from DMs, which are continuous, be leveraged as latent embeddings of the DIRformer whose latent space is discrete? How does it work?
Looking forward to your reply! Thank you again for your excellent work.

Thank you for your interest. As mentioned in the paper, I found that the previous LDM's VAE and Unet were trained separately, using KL loss for constraint. However, this was not conducive to accurate restoration. Therefore, I chose to jointly train DIRformer and DM, eliminating the need for KL loss in a more natural manner.

Thank you for your interest. As mentioned in the paper, I found that the previous LDM's VAE and Unet were trained separately, using KL loss for constraint. However, this was not conducive to accurate restoration. Therefore, I chose to jointly train DIRformer and DM, eliminating the need for KL loss in a more natural manner.

Get it. Thank you for your reply!


examples: improve comment around cloning in middleware

tower does not seem to use the buffer middleware (anymore?) so the existing comment is invalid, but the pattern is still sensible given https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services

Could you conforms the commit's message to conventional-commits which conventional-changelog bases on, used in this project.

tower does not seem to use the buffer middleware (anymore?) so the existing comment is invalid

I see it is actually used on the client-side, https://github.com/hyperium/tonic/blob/be4e0e772112b7fdd879e95398a7b50d305bad3e/tonic/src/transport/channel/mod.rs#L68
But I think the reference to tower docs is probably more useful.


Release 0.17.0

tests?

tests?

Yep, I know. The PR is still in draft :)

This PR is so big :)

@helmwave/maintainers check team notify)

linter)

pick up https://github.com/helmwave/helmwave/issues/236

I guess we wait for #236 and good to go.
By the way I've changed codecov.yml here. So It shows reducing coverage while that's not true because of old tests carryforward. So that's okay.


New author page should save the author

Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing's first name should be 'Alan'
Hints
Write a test that visits the new-author page, fills in the 'new author' form and submits it.
Use fill_in to enter data into input fields.
Submit the form using the find and click methods.
Try a new it block in new_author_spec.rb.
visit new_author_path
page.fill_in 'author[last_name]', with: 'Dijkstra'
# ...
find('input[type="submit"]').click

Here is the relevant section (5.6) in the Rails Guide.
Make the failing test pass by saving the POSTed form data in a new Author database object.
This is the task of a create action in authors_controller.rb.
Make sure to set the :url option of the form_with, to control where the data will be POSTed to. Read up on "strong parameters" and whitelisting of required parameters.
Do not issue a redirect_to @author, as this will error (there is no code for showing authors yet). Instead you can redirect_to root_path, notice: 'Success!'.
Tips:

Your browser's dev tools are helpful in debugging and inspecting HTML.
rails console allows you to interact with stored object in an interactive shell, e.g. Author.count shows the amount of stored authors.

Error

Expected: "alan"
got: "bob"

(compared using ==)
6 exercise tests have passed. There are 44 in total. You will solve multiple at once towards the end.

Sorry, it's not working for me yet:
Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing's first name should be 'Alan'
Error

Expected: "alan"
got: "bob"

(compared using ==)
If you have problems solving this task, please don't hesitate to contact the teaching team!

Sorry, it's not working for me yet:
Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing's first name should be 'Alan'
Error

Expected: "alan"
got: "bob"

(compared using ==)
If you have problems solving this task, please don't hesitate to contact the teaching team!


Discovery listener on all EntityComponents

Description:
Discovery listener on all EntityComponents
Related issue (if applicable): #
Fix PR2012 that only added listener if discovery_plaforms was passed

👍 🐬 💰


Support nic hotplug / hot-unplug

Is this a BUG REPORT or FEATURE REQUEST?:
/kind enhancement
#6322
What happened:
Hot-plug / hot-unplug (add / remove) nics to running VMs is an industry standard available in multiple platforms, allowing the dynamic attachment of L2 networks. This is useful when the workload (VM) cannot tolerate a restart when attaching / removing networks, of for scenarios where, for instance, the workload is created prior to the network.
This would help bridge the gap between KubeVirt's feature set and what the user base expects from it.
What you expected to happen:

Adding network interfaces to running VMs.
Removing networking interfaces from running VMs.
A VM can have multiple interfaces connected to the same (secondary) network(s).

Anything else we need to know?:
All PRs related to this effort should link back to this tracker.
The current target date is Summer 2022.
Link to (approved) design document.
Hot-plugging interfaces into the pod is currently being worked on, in the multus project.

/remove-lifecycle stale

It is still not yet possible to hotplug interfaces into a pod, which is currently blocked on Blocked waiting for https://github.com/k8snetworkplumbingwg/multus-cni/pull/777
As such, we should adjust our expectations: it is impossible to have this available in KubeVirt by Summer 2022.

I'd say this is a critical feature to have. hope it merged soon.

This is a critical feature to have. hope it merged soon.

I've asked the multus maintainers what are their plans for releasing multus v4, and their plans on a timeline for hotplug in multus in this discussion. I suggest you track it @chinglinwen .
Depending on the answer there we can plan the KubeVirt part or come up with a design alternative for hot-plugging interfaces into the launcher pod that does not involve multus.

/remove-lifecycle stale
Lately multus-v4 was merged to master, which enables 3rd party controllers from directly invoking delegate add / delete.
I've kicked up this controller project (currently in the works) that will enable pod network selection element changes to hot[plug/unplug] into pods.

Is this planned for the next kubevirt release?

We're trying to get it ready. The code works, but we're evaluating if the proposed design can be improved / simplified.

/remove-lifecycle stale

A follow-up to this issue (to provide the unplug counterpart) is available in #9383.


Close #563 Add send email table row and change styling to align buttons

Closes #563, Closes #562, alignment of document download table buttons vs. document email section parts, plus other alignment and styling issues. I tried to limit the changes to the email section as people are using that styled as-is right now. Here are some notes from our deep dive doc as well:

Add a new parameter to download_list_html() to include a send email button row. But it will be a copy of the feature - we won’t delete the existing send_button_html() method.
Fix the send_button_html() method html strings to remove the H5, though keep the styling
Right align the send button of the separate email section,
Remove the big gutter between the buttons and the text

Remade this PR because the pfs/black changes on the old branch caused a conflict with my updates.
Also closes #177 I believe.

One idea -- if it's just too hard to fit on mobile, maybe stack the form title and the view/download buttons vertically on mobile devices? We do need to really get that visual look right because it's a large proportion of our uses - 55%

FYI, to avoid merge conflicts--pull this branch into your playground before making more changes.

Not sure what we want to do with the pre-existing email elements because we said didn't want to change those too much, but this is what stuff looks like now at less than 576px (shown on Galaxy Fold):

I put validation errors below the email input field instead of next to it:

That leaves us with this problem on bigger screens that I'm still trying to figure out:

Just fyi, I keep having problems with the browser inspector trying out devices - under some circumstances I get weird behavior, like needing to scroll when in phone mode or the elements becoming narrower than the screen. You might be running into this too.
Some width stuff has to be somewhat home-brewed (from what I can tell so far) because we have to handle more than just column widths. For example, aligning doc titles left instead of right.

Try merging with main, I fixed that error earlier last month, Github made a change in the underlying container I think

Since this issue is about the download table, it may be worth leaving the isolated email component out of this PR and dealing with it in another issue.

I'm not sure how you merged, but it unfortunately has muddled the diff; I'm not sure why all of the other changes are showing up in it now. You could revert the changes, and maybe try rebasing on main instead? You can make a copy of the branch (git checkout -b doc_table_alignment_dupe) before trying, just so you don't lose info

Tried to rebase in GitHub, but it said there were conflicts. I'll try anyway.

Seemed to work when rebasing locally. If the tests all pass, is it ok with folks if I force-push to this branch and this PR so that we can keep the PR comment history?


Indicate that encrypted room title and description are not encrypted

Something like this: "Room title (NOT encrypted)", "Room description (NOT encrypted)"

Sorry, it should be in Riot Web.


General Grievance: Watch weddinghallsinecr.co.in

General Grievance requests the watch of the watch_keyword weddinghallsinecr\.co\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

weddinghallsinecr\.co\.in has been seen in 0 true positives, 0 false positives, and 0 NAAs.


NeckroGatherers Unkillable

Simply issue, coop game with a well built base has good enough defense that none of the Neckro's get killed by enemies.
One of the players yoinked multiple stacks of tails into the pylon and chaos ensued.... Yet we cant remove any of them.
None of the wands work on them, forcedelete 50 ChebGonaz_NeckroGatherer doesnt work either..
Is there any way to remove them? Or is there a bug going on?

Hello, can you please try (as an admin) the following command:
chebgonaz_killallneckros f
It should work. If not, you can use the game's vanilla killall command to kill all NPCs nearby in general. More info on my commands here. Please let me know if that works.

Thanks for quick reply, will test it out and will notify of the results


TS2551 error when calling an action from within a getter

Reproduction
https://github.com/piniajs?q=example&type=source
Steps to reproduce the bug
TS error 2551
Property 'callAnAction' does not exist on type '{ aStateVariable: boolean } & PiniaCustomStatePr...'. ts(2551)

I use vuetifys v-switch, which uses a v-model that i map with mapWritableState
Some Template:
...mapWritableState(myStore, ['aStateVariable', ...

To detect when the var changes, i use a getter and call an action
The Store:
  state: () => ({
    aStateVariable: true
  }),
  getters: {
    myGetter(state) {
      if (state.aStateVariable) {
        state.callAnAction()
              ^^^^^^^^^^^^ TS(2551)
      }
    },
  },
  actions: {
    callAnAction() {
      console.log('i got called')
    }
  }

The code works, but i got the TS error
Expected behavior
No error, or an explanation, that it is prohibited to call an action from a getter.
Actual behavior
TS error
Additional information
No response

This is intended. No side effects in getters


NpmWorkingDirectory

How about adding NpmWorkingDirectory

Add pull request https://github.com/kmees/MSBuild.NodeTools/pull/17


[WIP] Add Deserialization for FragmentDiffs

Close #40.
Structure-ish came from FragmentDiff and others. Test Data came from FragmentDiffTests
I wasn't quite able to make the structs format match exactly from the Swift client code and decided to make some compromises. The example json uses ints in strings (there might be a serde feature for this) for some keys. Ideally these should be HashMap<i32, _> rather than HashMap<String, _>. I think one of the structs here uses a HashMap rather a Vec (what the swift does). I also had to make some additional structs to use #[serde(flatten)].

It's obviously a lot easier to accomplish this by string concatenation as you've done, but this approach is quite inefficient. It's quite a bit harder to do, but the better option is to implement io::Read so this can be consumed without any heap allocations.
Consider using BTreeMap with serde_as to facilitate integer keys.

It's obviously a lot easier to accomplish this by string concatenation as you've done, but this approach is quite inefficient. It's quite a bit harder to do, but the better option is to implement io::Read so this can be consumed without any heap allocations.

Yup. This method is definitely easier and less efficient. Ideally, this diff json payload would actually be applied directly to the Document rather than rendered/stringed, parsed and then passed to document_merge which is what happens in the swiftui client. An unfortunate stepping stone in this process is that the swiftui client currently uses SwiftPhoenixClient and also decodes the diff json payload. The jetpack client has neither decoding nor uses phoenix-channels-clients. To unblock the jetpack client and maintain the swift client, I think this is an okay trade off for now.
The liveview template diff json payload isn't super well documented and is liable to change. Something that's easier implemented to will be easier maintain when changes arise.

Consider using BTreeMap with serde_as to facilitate integer keys.

Yup. I came across serde_with in my search to avoid impl Deserializer. I think once the liveview diff/rendering json has a formal specification, it'll be worth doing.

It would totally be viable to implement io::Read on a renderer type to create a token emitter that can be used within Morph as a way of iteratively morphing without an intermediary document being created but the problem with doing so is that there wouldn’t be a good way to know if keyed nodes have been moved and so it would potentially be less effective of an algorithm when consumed.It’s an understatement to say it’s poorly documented. Truly painful to reverse engineer from the JSSent from my iPhoneOn Sep 29, 2023, at 5:10 PM, simlay @.***> wrote:
It's obviously a lot easier to accomplish this by string concatenation as you've done, but this approach is quite inefficient. It's quite a bit harder to do, but the better option is to implement io::Read so this can be consumed without any heap allocations.
Yup. This method is definitely easier and less efficient. Ideally, this diff json payload would actually be applied directly to the Document rather than rendered/stringed, parsed and then passed to document_merge which is what happens in the swiftui client. An unfortunate stepping stone in this process is that the swiftui client currently uses SwiftPhoenixClient and also decodes the diff json payload. The jetpack client has neither decoding nor uses phoenix-channels-clients. To unblock the jetpack client and maintain the swift client, I think this is an okay trade off for now.
The liveview template diff json payload isn't super well documented and is liable to change. Something that's easier implemented to will be easier maintain when changes arise.
Consider using BTreeMap with serde_as to facilitate integer keys.
Yup. I came across serde_with in my search to avoid impl Deserializer. I think once the liveview diff/rendering json has a formal specification, it'll be worth doing.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>


Reduce call on non-null type from !isNullOrEmpty to isNotEmpty

Fixes https://github.com/nickbutcher/plaid/issues/497
Thanks @XinyueZ

@ataulm Thanks for your PR!
@XinyueZ Please let the owners of the repo approve changes. Having non-owners approving changes can lead to confusion for PR requester.


getEdgeFlags error not getting configuration

Hi there, i try to use getEdgeFlags in _middleware.tsx file of my project but i'm getting the next error:
Error: @happykit/flags: Missing configuration. Call configure() first.
Here is the exact example that i'm using:
// src/pages/_middleware.ts
import { NextRequest, NextResponse } from 'next/server';
import type { AppFlags } from<EMAIL_ADDRESS>import '../../flags.config';
import { getEdgeFlags } from '@happykit/flags/edge';

// Under construction middleware redirection.
// Using API response.
export async function middleware(request: NextRequest) {
  const flagBag = await getEdgeFlags<AppFlags>({ request });
  const response = NextResponse.rewrite('/_closed');
  if (flagBag.cookie) response.cookie(...flagBag.cookie.args);
  return response;
}

// flags.config.js
import { configure } from "@happykit/flags/config";

configure({
  envKey: process.env.NEXT_PUBLIC_FLAGS_ENVIRONMENT_KEY
});

¿What's could be the mistake if i'm importing '.../.../flag.config' file?
Thank you!

That seems weird indeed. Your code seems correct.
Can you log out process.env.NEXT_PUBLIC_FLAGS_ENVIRONMENT_KEY to make sure it's defined?
If that's not it, can you try inlining the configure() call into src/pages/_middleware.ts to see if that fixes it?
Like so
// src/pages/_middleware.ts
import { NextRequest, NextResponse } from 'next/server';
import type { AppFlags } from<EMAIL_ADDRESS>import { getEdgeFlags } from '@happykit/flags/edge';
import { configure } from "@happykit/flags/config";

configure({
  envKey: process.env.NEXT_PUBLIC_FLAGS_ENVIRONMENT_KEY
});

// Under construction middleware redirection.
// Using API response.
export async function middleware(request: NextRequest) {
  const flagBag = await getEdgeFlags<AppFlags>({ request });
  const response = NextResponse.rewrite('/_closed');
  if (flagBag.cookie) response.cookie(...flagBag.cookie.args);
  return response;
}

Let me know what you find and I can try to help from there.

There is the same error trying call configure function in _middleware.ts, here's a screenshot of my code, and the currently termial logs:

It's printing null for some reason.
Thank you!

I can confirm that this is an error in @happykit/flags. I'm working on a solution.

Confirmed that this was Next.js problem that will be fixed in the next release.
Closing this as Next.js v12.0.11 will fix it once it's released.
Thanks for reporting!


[GPU AMI] Incompatibility of EFA, NVIDIA drivers with latest Linux kernels

With the latest Amazon Linux 2 kernels, customers running EC2 P4d, P4de and P5 instances may be unable to use the GPUDirect RDMA feature, which allows for faster communication between the NVIDIA driver and the EC2 Elastic Fabric Adapter (EFA).
This issue is caused by a change accepted by the Linux kernel community which introduced an incompatibility between the NVIDIA driver and the EFA driver. This change prevents the proprietary NVIDIA driver from dynamically linking to open source ones, such as EFA. We are currently working towards a solution to allow the use of the GPUDirect RDMA feature with the affected kernels.
Linux kernels with versions equal or above to the follow are affected:

4.14.326
5.4.257
5.10.195
5.15.131
6.1.52

The EKS-Optimized Accelerated AMI does not contain the affected kernel versions. By default, these AMIs have locked the kernel version and are not affected, unless the kernel version lock is manually removed. We recommend customers using custom AMIs to lock their kernel to a version lower than those listed above to prevent any impact on their workloads, until we have determined a solution. The kernel version can be locked with the following command:
sudo yum versionlock kernel*

My team builds EKS GPU images and I think we're facing this issue.  We're using amazon-eks-gpu-node-1.28-v20231201 (ami-0a2b1b38a4684df6a in us-east-1 region) and I believe the kernel packages are already initially pinned.
yum upgrade output: eks gpu upgrade errors.txt
Any advice?

Today's release (vv20240220) includes changes to address this issue for Kubernetes 1.29. These changes will be backported to earlier Kubernetes versions over the next several releases.
In order to support EFA, the open-source NVIDIA kernel module will be used on supported instance types. We've also taken the opportunity to migrate from the legacy nvidia-docker package to the nvidia-container-toolkit.

I'm running the latest version of AMI v1.29.0-eks-5e0fdde and nvidia-gpu-operator v23.9.1.
Here's the error message that I have in my app container:
    Last State:     Terminated
      Reason:       StartError
      Message:      failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: /usr/local/nvidia/toolkit/nvidia-container-cli.real: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by /usr/local/nvidia/toolkit/libnvidia-container.so.1): unknown
      Exit Code:    128

While both dcgm-exporter and feature-discovery pods failed to startwith the message:
    Last State:    Terminated
      Reason:      StartError
      Message:     failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy'
nvidia-container-cli: detection error: nvml error: unknown error: unknown

I'm running the latest version of AMI v1.29.0-eks-5e0fdde and nvidia-gpu-operator v23.9.1 on g5.48xlarge
Here's the error message that I have in my app container:
    Last State:     Terminated
      Reason:       StartError
      Message:      failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: /usr/local/nvidia/toolkit/nvidia-container-cli.real: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by /usr/local/nvidia/toolkit/libnvidia-container.so.1): unknown
      Exit Code:    128

While both dcgm-exporter and feature-discovery pods failed to startwith the message:
    Last State:    Terminated
      Reason:      StartError
      Message:     failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy'
nvidia-container-cli: detection error: nvml error: unknown error: unknown

I had to add privileged: true in securityContext of Daemonset's definition file. But I am not sure if this is recommended at all.

We've resolved this issue in all currently-supported Kubernetes versions.

We've resolved this issue in all currently-supported Kubernetes versions.

I am not sure if that's the case. When I was installing the driver manually everything worked, but when I switched to the preinstalled driver ami from amazon everything went bonkers. Good news is that the cuda validation works and perhaps the issue is coming from somewhere else. Let me know if you need additional logs or information. I would appreciate anyone's input at this point.
cuda-validation - privileged container - terminated, ready - Completed (exit code: 0) - This is from the nvidia operator, which seems to work as expected.
My app container (not privileged) though yields the same error message as described above:
Error: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: /usr/local/nvidia/toolkit/nvidia-container-cli.real: /lib64/libc.so.6: version `GLIBC_2.27' not found (required by /usr/local/nvidia/toolkit/libnvidia-container.so.1): unknown

node.kubernetes.io/instance-type=g3s.xlarge
imageID: ami-02f8e26b00d356736
Kubelet version
v1.28.8-eks-ae9a62a
Kernel version
5.10.219-208.866.amzn2.x86_64
Container runtime
containerd://1.7.11

@the-veloper
Did you find a solution?

The gpu-operator isn't useful on the EKS accelerated AMI variants and usually results in various package conflict errors. The NVIDIA device plugin is usually all you need for the majority of use cases, and there is a stand-alone helm chart to deploy it


Move resources-definitions update script to this repository

Move update resources definitions script from https://github.com/RedHatQE/openshift-resources-definitions

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported /retest check runs

/retest tox: Retest tox
/retest python-module-install: Retest python-module-install

Supported labels

hold
verified
wip
lgtm

/verified

/verified

/verified

/cherry-pick v4.15

Manual cherry-pick is needed
Cherry pick failed for acdcfd5bf6ad15086db0396341ccb974456b1b24 to v4.15:
To cherry-pick run:
git remote update
git checkout v4.15
git pull origin v4.15
git checkout -b resources-definitions-tests-v4.15
git cherry-pick acdcfd5bf6ad15086db0396341ccb974456b1b24
git push origin resources-definitions-tests-v4.15


Api versioning

@agnessa ready for review and merge

Removed some unnecessary code, rebased, the usual. Should be good to merge

Can we remove the V2 base controller as well?


Remove multiplexer N^2 behavior

I'm going to add a test to this, I think.

This test is a tad dodgy, y'all. Specifically:

need to wait (with setTimeout) before providing data, because otherwise the data's already there when the transformer starts up.
need to wait (with setTimeout) after providing data, because otherwise slots requested by the transformer don't arrive before the end of the test
something isn't resolving properly with the internal recipes so there's a bunch of stuff printed out ; this doesn't change the validity of the test but it's untidy.

I'll keep poking into it.

Much better!


Refactor and polish App README

Relates to spring-cloud-task-app-starters/app-starters-release#39

Merged as 78c41b7948eea209a98c480edf29ff81ee5f04e0


[ci] added CODEOWNERS (fixes #2194)

See #2194 for details. Please suggest if I've misinterpreted https://github.com/microsoft/LightGBM/blob/76170788c4bd6239334408f88cf51183ec791fa2/docs/FAQ.rst#critical...I did my best to make this file consistent with the conventions I've observed in PRs in this project. It's very likely I have made some mistakes.
My hope is that using CODEOWNERS will turn something being done by convention into something being done by automation. It will, I hope, also improve the contributor experience.

Addressed comments! Please review at your earliest convenience.

rebased to master. If it builds tonight, I'm going to merge this. Thanks to everyone for the reviews!

😬 seems one task in azure pipelines has failed. Could someone with sufficient permissions re-run it? It's very very unlikely it could have been caused by this PR.

😬 seems one task in azure pipelines has failed.

Seems that it was something connected to apt-get, maybe network issue.
Processing triggers for libc-bin (2.19-0ubuntu6.14) ...

bzip2: Compressed file ends unexpectedly;
	perhaps it is corrupted?  *Possible* reason follows.
bzip2: Inappropriate ioctl for device
	Input file = (stdin), output file = (stdout)

It is possible that the compressed file(s) have become corrupted.
You can use the -tvv option to test integrity of such files.

You can use the `bzip2recover' program to attempt to recover
data from undamaged sections of corrupted files.

tar: Child returned status 2
tar: Error is not recoverable: exiting now
sh: 0: Can't open AMD-APP-SDK*.sh

In addition, our master has failed too: https://lightgbm-ci.visualstudio.com/lightgbm-ci/_build/results?buildId=2380.
I have already spotted random failures in GPU task for several times and reported them in #1003. It seems that these bugs occure only in test_cegb_scaling_equalities from time to time.

Rebased to master. If this PR builds, I'll merge it tonight!


Updating Documentation

Coverage remained the same at 14.85% when pulling 1c9429b31315290e0751393ef017ddc7816b36e7 on UpdateDocs into 37f8ff4981b087a307de4d0c4ea09f326060da60 on master.


No empty lines between variables

It should be configurable - by default allow up to 1 empty line, but allow to configure it to 0 (no empty lines) or -1 (ignore all empty lines) and x+ (allow up to x empty lines)


Not parsing JSON strings

Trying to parse strings returned like this:
{"success":true,"terms":"https://currencylayer.com/terms","privacy":"https://currencylayer.com/privacy","historical":true,"date":"2015-08-31","timestamp":1440979199,"source":"USD","quotes":{"USDKRW":1181.945007}}
The array returned after parsing does not contain any values? What could be the problem?
The array (called Item) that receives the content:

Any help appreciated - love the code!

Should add I am using your "Dictionary v1.4.1" as final = MAC Excel....

No all ok now - cheers


stock.ticker_fundament() is not working

Since yesterday (29.12) the stock.ticker_fundament() does not work. Maybe some change on the webpage and the scraper cannot cope with it...

I'm having the same problem...
  File "[REDACTED]/.local/lib/python3.7/site-packages/finvizfinance/quote.py", line 124, in ticker_fundament
    fundament_info["Company"] = rows[1].text

In quote.py the function "ticker_fundament()" refers to the 5th table in the soup, but it seems, that the page has been changed yesterday 14:00ET, so the 4th table contains the necessary data:
"table = self.soup.findAll("table")[4]" will help.
Maybe there are more issues, but this is the was the problem.

Many thanks. This worked for me (i.e., change to use table 4). Thanks thanks!

This issue is fixed in the latest version. Thank you all.


'earliestUsefulChild != null': is not true is thrown if we set the previous laid out children to null in ListView.builder

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

run the code provided below.
Scroll down to end of the list.
Press the FAB.
Scroll back up to the begin of the list.

Expected results
since returning null in itemBuilder method will be signaling that we reach the end of the list when we scroll down I suppose it should works normally if we return null in the beginning of the list since the builder factory lazily load the items.
I'm not sure if that's intended or not.
The use case is I'm trying to implement a fetch on demand behavior, it works well when scrolling down and showing a 'Loading' until I fetch the new data, and I dispose the data that are no longer showing on the screen as I scroll down.
However when try to scroll back up I still apply the same logic (show loading until I get the data) but it throws 'earliestUsefulChild != null': is not true.
Actual results
════════ Exception caught by rendering library ═════════════════════════════════
'package:flutter/src/rendering/sliver_list.dart': Failed assertion: line 186 pos 16: 'earliestUsefulChild != null': is not true.
sliver_list.dart:186
The relevant error-causing widget was
ListView
main.dart:31
════════════════════════════════════════════════════════════════════════════════
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(
    const MaterialApp(home: MyHomePage()),
  );
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  List<String> items = List.generate(200, (i) {
    if (i > 180) {
      return 'Loading';
    }
    return 'Item $i';
  });
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(onPressed: () {
        setState(() {
          items.replaceRange(10, 30, ['Loading']);
        });
      }),
      body: ListView.builder(
        itemCount: items.length,
        itemBuilder: (context, index) {
          if (items[index] == 'Loading') return null;
          return Text(items[index]);
        },
      ),
    );
  }
}

Screenshots or Video
Video
https://github.com/flutter/flutter/assets/95232508/947a83ed-b18c-4c44-ad24-aa3f626640d3

Logs
No response
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.1, on macOS 13.2 22D49 darwin-arm64, locale
    en-EG)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio
[✓] VS Code (version 1.79.2)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Reproducible using the code sample provided above.

logs
flutter: ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
flutter: The following assertion was thrown during performLayout():
flutter: 'package:flutter/src/rendering/sliver_list.dart': Failed assertion: line 186 pos 16:
flutter: 'earliestUsefulChild != null': is not true.
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new?template=2_bug.yml
flutter:
flutter: The relevant error-causing widget was:
flutter:   ListView ListView:file:///Users/nexus/projects/nevercode/grd/lib/main.dart:31:22
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:186:16)
flutter: #3      RenderObject.layout (package:flutter/src/rendering/object.dart:2491:7)
flutter: #4      RenderSliverEdgeInsetsPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:139:12)
flutter: #5      RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:361:11)
flutter: #6      RenderObject.layout (package:flutter/src/rendering/object.dart:2491:7)
flutter: #7      RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:534:13)
flutter: #8      RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1512:12)
flutter: #9      RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1421:20)
flutter: #10     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:2330:7)
flutter: #11     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1011:18)
flutter: #12     RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:494:19)
flutter: #13     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:926:13)
flutter: #14     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:360:5)
flutter: #15     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15)
flutter: #16     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9)
flutter: #17     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1085:5)
flutter: #18     _invoke (dart:ui/hooks.dart:170:13)
flutter: #19     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:410:5)
flutter: #20     _drawFrame (dart:ui/hooks.dart:140:31)
flutter: (elided 2 frames from class _AssertionError)

flutter doctor -v
[!] Flutter (Channel stable, 3.10.6, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.10.6 on channel stable at /Users/nexus/dev/sdks/flutter
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (4 days ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 74.0.4
    • Dart plugin version 231.9161.14

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.3)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9161.38/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9225.16/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (3 available)
    • Nexus (mobile)  • 00008020-001875E83A38002E • ios            • iOS 16.5.1 20F75
    • macOS (desktop) • macos                     • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome                    • web-javascript • Google Chrome 114.0.5735.198
    ! Error: Nexus is busy: Making Nexus ready for development. Xcode will continue when Nexus is finished. (code -10)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.13.0-3.0.pre.91, on macOS 13.4.1 22F770820d darwin-arm64, locale en-GB)
    • Flutter version 3.13.0-3.0.pre.91 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5a866a031f (9 hours ago), 2023-07-16 17:36:30 -0700
    • Engine revision 683087731f
    • Dart version 3.1.0 (build 3.1.0-315.0.dev)
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.3)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9161.38/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.4)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.9225.16/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (3 available)
    • Nexus (mobile)  • 00008020-001875E83A38002E • ios            • iOS 16.5.1 20F75
    • macOS (desktop) • macos                     • darwin-arm64   • macOS 13.4.1 22F770820d darwin-arm64
    • Chrome (web)    • chrome                    • web-javascript • Google Chrome 114.0.5735.198
    ! Error: Nexus is busy: Making Nexus ready for development. Xcode will continue when Nexus is finished. (code -10)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I'm having this exact issue, and about..

I'm not sure if that's intended or not.

..can we get a short answer about this question?
I'm heavily relying on the ability to return null on paginated / infinite view scroll lists (but also with slivers, grids, etc.). This is great because returning null effectively means "ok, no more items here".

Hey @lucavenir. While the approach of implementing a fetch-on-demand/scroll using the builder might be effective, there could be alternative strategies worth considering.
For a temporary fix, you can disable autoDispose in your notifier. see the original issue here
One alternative approach could be to rely on the scrolling position rather than the builder. The initial method fetches data only when the user reaches the end of the list, which may result in a suboptimal user experience. A suggestion is to consider listening to scrolling notifications and fetching a new page when the user reaches, for example, the last third of the last fetched page. This way, the user won't even notice that new data is being retrieved.
In terms of handling scrolling positions, this would involve creating only one notifier. Manually fetch the next page when the user reaches a certain scrolling position, and then update the state of the notifier with the old page added to it and the next page that was fetched. I'm not sure how this would be implemented in the new auto-generated Riverpod, but it might be worth exploring.

Most of the times I'm not using a Riverpod's Notifier for paginated infinite scroll view lists, and this issue is about null being a problem for the reverse scrollable direction, but nonetheless, thank you for dedicating some time to this.


nproc command in compile.sh isn't compatible with MacOS

Problem description
incubator-gluten/cpp/compile.sh script use nproc command to get the number of processing units available but MacOS dosen't support this comand. Here is the code.

I would like to resolve this issue. We could get the number of processing units available like this code
if [[ "$(uname)" == "Darwin" ]]; then
    physical_cpu_cores=$(sysctl -n hw.physicalcpu)
    ignore_cores=2
    if [ "$physical_cpu_cores" -gt "$ignore_cores" ]; then
        NPROC=${NPROC:-$(($physical_cpu_cores - $ignore_cores))}
    else
        NPROC=${NPROC:-$physical_cpu_cores}
    fi
else
    NPROC=${NPROC:-$(nproc --ignore=2)}
fi

Yes, you can fix it like https://github.com/apache/incubator-gluten/blob/main/dev/builddeps-veloxbe.sh#L37. Thanks!

Thanks for your reply. I'll open a pull request for this issue.

@PHILO-HE I opened PR for this issue. Could you take a look? Thanks.

In general, we can use nproc on macOS by brew install coreutils.


add new features

In this PR a fulfilled the following tasks:

[x] Add Task Classes to add remove and edit
[x] DOM manipulation

@FevenSeyfu, I implemented all the observations that you made. :smirk:


No stats for exchange to exchange bindings

Thanks @deadtrickster for this plugin.
My topology includes exchanges bound to other exchanges but all of the rabbitmq_exchange_messages_* metrics for these exchanges are 0.
The counters are only non-zero for the exchange that messages are initially published into.
Here's an example:
All messages are initially published into Headers exchange A.
Headers exchange B is bound to A with argument HeaderX: "foo"
Queue C is bound to B with argument HeaderY: "foo"
Queue D is bound to B with argument HeaderY: "bar"
Headers exchange E is bound to A with argument HeaderX: "bar"
Queue F is bound to E with argument HeaderY: "foo"
Queue G is bound to E with argument HeaderY: "bar"
Say 4 messages are published to A, one for each permutation of HeaderX and HeaderY so one each is routed into C, D, F, and G.
Metrics are as follows:
rabbitmq_exchange_messages_published_total{vhost="/",exchange="A",type="headers"} 0
rabbitmq_exchange_messages_published_total{vhost="/",exchange="B",type="headers"} 0
rabbitmq_exchange_messages_published_total{vhost="/",exchange="E",type="headers"} 0
rabbitmq_exchange_messages_published_in_total{vhost="/",exchange="A",type="headers"} 4
rabbitmq_exchange_messages_published_in_total{vhost="/",exchange="B",type="headers"} 0
rabbitmq_exchange_messages_published_in_total{vhost="/",exchange="E",type="headers"} 0
rabbitmq_exchange_messages_published_out_total{vhost="/",exchange="A",type="headers"} 4
rabbitmq_exchange_messages_published_out_total{vhost="/",exchange="B",type="headers"} 0
rabbitmq_exchange_messages_published_out_total{vhost="/",exchange="E",type="headers"} 0

All other rabbitmq_exchange_messages_* metrics are 0.
I would expect the above metrics for exchanges B and E to both have value 2.
Also, why is rabbitmq_exchange_messages_published_total{exchange="A"} 0 when rabbitmq_exchange_messages_published_in_total{exchange="A"} and rabbitmq_exchange_messages_published_out_total{exchange="A"} are both 4?
Thanks

I have found that E2E bindings are just rows in the routing table and do not produce metrics. Closing.


Whether the tricks is used fairly?

Thanks to the author for the open source code and the very innovative research.
But,
Whether many of the modules' performance gains come from other factors？
For example，
1）ACNet  is similar to Dynamic Brunch‘s  Convolutional kernel
2）CKA is similar to Every Pixel Matters: Center-aware Feature Alignment for Domain Adaptive Object Detector-CA modules
3）Node adaptive   is similar to  “Exploring Categorical Regularization for Domain Adaptive Object Detection  “for Weakly Supervised  Discriminator
4）GST  is similar to self-attention +”Maximum Classifier Discrepancy for Domain Adaptation“

I apologize for asking the above stupid question, I have solved the confusion by reading the paper again and again


Hello, @mattp0123
kill command doesn't stop the task immediately.
It stops the workflow after current task is finished.

Thanks for your reply.

kill command doesn't stop the task immediately. It stops the workflow after current task is finished.

So what am I supposed to do to stop the task immediately?

Hello, @mattp0123
IIUC, you need to wait for the task completion.
For example, If you kill the BigQuery session in the bq> operator,
There is no guarantee to kill the session on the BigQuery side.
In that case, the query still runs on the unmanaged area.


Decrease jupyter_core floor, cap nbclient for 3.7

As discussed in #3069, conda installs of Elyra will fail because the dependency of jupyter_core >= 4.11.2 cannot be resolved.  This is because conda removed support for Python 3.7 last August.
This pull request will allow for conda installations of Elyra to succeed, albeit supporting versions of jupyter_core <= 4.11.1.  This change also resulted in capping nbclient <= 0.7.0 for Python 3.7 since more recent versions of nbclient require jupyter_core >= 4.12.
Resolves: #3069
Signed-off-by: Kevin Bates<EMAIL_ADDRESS>Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

We can keep this open for discussion tomorrow at scrum, and close when necessary

Should we just remove support for Python 3.7?

Should we just remove support for Python 3.7?

I agree.  I think the bigger question is in what release can/should this removal occur in - 3.15 or 4.0?

We should still merge this PR since it's limiting functionality on python releases > 3.7.  We can talk about dropping 3.7 independently.


[release-1.16] add fully remote jwks mode (#42756)

Cherry pick https://github.com/istio/istio/pull/42756.
Resolved conflicts with some changes.

This looks like a feature and not a bug fix, so would not be eligible for backporting.

@liwenhao0810: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security-istiodremote

integ-security_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liwenhao0810: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security-istiodremote

integ-security_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security

integ-security-multicluster_istio_release-1.16
b6b9b7fa8f17c2e884cef6afae6922e5520fb2ad
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


The RSI momentum indicator gives wrong result

Hello,
I've been trying the RSI momentum indicator and I noticed that it produced very different values to the ones reported in yahoo finance, trading view, etc. I started checking and calculated the rsi using excel following this guide:
https://www.tradinformed.com/calculate-rsi-indicator-using-excel/
Following these formulas and values taken from the mentioned sites, I arrived to the value they reported in their charts. For most of the stock charts I tried it failed to produced the expected latest RSI value.
Digging into the code, i think the issue comes from using the:
ewm
Function. As this aggregator is a cumulative moving average, not a simple rolling average, neither an exponential moving average, more details here:
https://www.datacamp.com/community/tutorials/moving-averages-in-pandas
Regards,
Luis

I've kept trying on this, as I mentioned before the problem with the RSI calculation comes from the way ewm is used. RSI computation uses an smoothing technique, better explained here:
https://school.stockcharts.com/doku.php?id=technical_indicators:relative_strength_index_rsi
I implemented a RSI computation that doesn't use pandas aggregation functions based on the formula and I arrive to the values used in the examples provided and reported by trading view, yahoo finance for different periods.


bicycle routes on ways with no access

in OSM, there are several ways with access tags like vehicle=no, which are a part of route=bicycle relation. many of them are tagged correctly (there is traffic sign disallowing bicycles and Eurovelo sign on the same pole, police does not enforce it).
should bike routing allow usage of such ways?

I've seen vehicle=no used on multi-use-paths where bicycles are allowed. Not sure which is canonical in OSM land, but there will be unintended consequences here.

Otherwise there is a problems with paths that are fine for pedestrians but have no "yes" for bike access.
For example this here:
https://www.openstreetmap.org/directions?engine=graphhopper_bicycle&route=47.0706%2C15.5292%3B47.0764%2C15.5352#map=16/47.0726/15.5364
You cannot go through the forest there and will have to go around on that road.
I took a look on some commercial solutions which also are using maps based on OSM and they didn't route through the forest there, so it must be possible to do a better guess if the route is available for bikes or not.

You mean the route through the forest is not legal for bikes, or is it physically not possible to ride a bicycle there? I think this probably comes down to country-specific legislation. As far as I know riding bicycles is generally forbidden (if not allowed explicitly) on forest roads/paths in Austria.
Related: https://github.com/graphhopper/graphhopper/pull/2402

It is physically not possible for a normal biker.