OpenAPI Path with wildcard parameter does not produce correct axios glue code (Bug introduced in 6.6.3 -> 6.6.4)

What are the steps to reproduce this issue?
Have the following entry in the OpenAPI spec:
{
    "/api/v1/file-storage/{path*}": {
        "get": {
            "operationId": "fileStorageControllerGet_1",
            "responses": {
                "200": {
                "content": {
                    "application/json": {
                    "schema": {
                        "$ref": "#/components/schemas/FileStorageEntryModel"
                    }
                    }
                },
                "description": "Success"
                }
            },
            "parameters": [
                {
                "in": "path",
                "name": "path*",
                "required": true,
                "schema": {
                    "type": "string"
                }
                }
            ]
        }
    }
}

and the following orval configuration:
import path = require('path');

module.exports = {
  api: {
    output: {
      mode: 'tags',
      workspace: path.join(__dirname, '../../libs/api-interfaces/src'),
      target: './index.ts',
      schemas: './models',
      client: 'react-query',
      mock: false,
      override: {
        mutator: {
          path: './custom-client.ts',
          name: 'customClient',
        },
      },
    },
    input: {
      target: path.join(__dirname, '../../dist/apps/api/spec.json'),
    },
  },
};

What happens?
From version 6.6.4 onwards, the following code is generated. The path parameter is missing in the function, path* is a hardcoded part of the url.
export const fileStorageControllerGet1 = (

 options?: SecondParameter<typeof customClient>) => {
      return customClient<FileStorageEntryModel>(
      {url: `/api/v1/file-storage/path*}`, method: 'get'
    },
      options);
    }

What were you expecting to happen?
Version 6.6.3 produced the following code with the expected result: path is a variable that gets substituted in the url.
export const fileStorageControllerGet1 = (
    path: string,
 options?: SecondParameter<typeof customClient>) => {
      return customClient<FileStorageEntryModel>(
      {url: `/api/v1/file-storage/${path}`, method: 'get'
    },
      options);
    }

Any logs, error output, etc?

Any other comments?

What versions are you using?
Operating System: macOS 12.3.1
Package Version: 6.6.3, 6.6.4, 6.8.1
Browser Version: not relevant

Will be fix with the next release

https://orval.dev/reference/configuration/output#contenttype


Create Database - BEGINNER

Hi,
Would like to seek help. I am using Cloudways and I use Filezilla to upload the files.
I think I am missing is the database part.
I can't find any instructions to install or create the database.  Here are the following steps I have done.

Download the source zip file
edit the config.php file based from the database created in cloudways
upload the files to cloudways via filezilla

When I visited my domain.tips/admin, error us ERR_EMPTY_RESPONSE
I don't know what to do next. please help me. Thank you.

Hello
Steps 1, 2, 3 are fine. Now contact your host service and ask them how to create a database.
Also, you cannot out of the box install WP and YOURLS in the same directory, see http://yourls.org/#FAQ


Python Cipher step 16 instructions are not clear enough

Describe the Issue
When working with the Python Cipher at step 16, it mentions the following instructions to complete the challenge:

As you can see from the output, "h" is at index 7 in the alphabet string. Now you need to find the letter at index 7 plus the value of shift. For that, you can use the addition operator, +, in the same way you would use it for a mathematical addition.

Declare a variable named shifted and assign it the alphabet letter at index plus shift.

These instructions are not clear enough, as it has popped up multiple times in the forum asking for clarification:
https://forum.freecodecamp.org/t/learn-string-manipulation-by-building-a-cipher-step-16/658948
https://forum.freecodecamp.org/t/learn-string-manipulation-by-building-a-cipher-step-16/656960
https://forum.freecodecamp.org/t/learn-string-manipulation-by-building-a-cipher-step-16/658331
https://forum.freecodecamp.org/t/learn-string-manipulation-by-building-a-cipher-step-16/658121
Affected Page
https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-string-manipulation-by-building-a-cipher/step-16
Your code
N/A
Expected behavior
The main issue is with the last sentence:

Declare a variable named shifted and assign it the alphabet letter at index plus shift.

In theory, is expected from the user to write the following line of code:
shifted = alphabet[index + shift]

But the wording seems off, I also got confused at first with the instruction. Later in the curriculum a very similar instruction is presented at step 57, but with better wording:

Next, inside the else block, declare a variable called key_char and assign it the value of key at the index key_index mod(%) the length of key.

Which expects a similar result like above:
key_char = key[key_index % len(key)]

I think wording the step 16 to the following, similar to step 57, would be better:

Declare a variable named shifted and assign it the value of alphabet at the index index plus shift.

It does seems redundant to say "at the index index" so it may be necessary to rename the variable. I'm open to suggestions.
Screenshots
No response
System
N/A
Additional context
No response

Hey @juancaorg !
Thank you for raising this issue.
I agree that the directions could be updated because like you mentioned it does come up a lot on the forum.

I think wording the step 16 to the following, similar to step 57, would be better:

Declare a variable named shifted and assign it the value of alphabet at the index index plus shift.

It does seems redundant to say "at the index index" so it may be necessary to rename the variable. I'm open to suggestions.

That wording works for me. As for the redundancy, we do mentioned index twice in the hint text for this step. So repetition might be ok here.
Another change we could make is to the hint text itself and show that index + shift needs to be in brackets
Proposal for updated hint text
You should assign `[index + shift]` to your `shifted` variable.

I have gone ahead and adding the discussing label on it so we can hear from more maintainers about updates to the wording 👍

Some idea is to use alphabet[index] more explicitly in the description. It would work in two ways - remind campers how to use indexing, and it'd be easier to lead them into changing index to index + shift for the solution.

I like how it was worded here, in steps: https://forum.freecodecamp.org/t/learn-string-manipulation-by-building-a-cipher-step-16/660377/3?u=pkdvalis
If I were to re-word this for the lesson:
Declare a variable called `shifted` and assign it a value which is going to be a letter in the `alphabet` string. Use square brackets to access the position of the letter at `index + shift`.

This step has generated so many forum posts I would even consider giving a very clear template like: Use the format string[variable1 + variable2]

Declare a variable named shifted and assign it the value of alphabet at the index position plus shift.

Any thoughts on renaming the index variable to position?

Really appreciate everyone's input with this issue! I think using @pkdvalis could be the most clear one:

Declare a variable named shifted and assign it a value which is going to be a letter in the alphabet string. Use square brackets to access the position of the letter at index + shift.

I think renaming the index variable to position is valid and probably better, but may be unnecessary. I think with the above is good enough.
And for the hint text, instead of the current one:

You should assign the alphabet letter at the index index + shift to your new variable.

Use the following instead (a combination of @jdwilkin4 and @pkdvalis proposals) :

You should assign the alphabet letter at the position index + shift to your shifted variable. Use the following format as an example: string[variable1 + variable2].

Let me know what you think.

I don't think it's necessary to modify the name of the index variable. Repetition is perfectly fine here.
To simplify things I would introduce additional steps:

declare a variable named shifted and assign it alphabet
modify the assignment into shifted = alphabet[index]
modify it again into shifted = alphabet[index + shift]

I like the idea of breaking it up into steps (still within Step 16, right?). The challenge is still to explain the last step in words. In the actual lesson we might word it like this?

declare a variable named shifted and assign it the string alphabet
modify the assignment into alphabet at position index using square brackets
modify the position in the square brackets to index + shift

I have a slight worry that the new learners will get lost adding a line modifying it, and then modifying it again? I don't think this is an approach they will be used to? The leap to adding variables within the square brackets might require this though.
Re: hint text

You should assign the alphabet letter at the position index + shift to your shifted variable. Use the following format as an example: string[variable1 + variable2].

Perfection!

I mean this will be split into 3 (maybe 2) different steps (not in step 16). And not necessarily contiguous steps, since it's better to place the step that is asking to print shift in between.

Agree with this approach.
Maybe we could combine these into 1 step:

declare a variable named shifted and assign it alphabet
modify the assignment into shifted = alphabet[index]

Since it should be reinforcing a lesson already introduced in Step 4
https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-string-manipulation-by-building-a-cipher/step-4
Without the extra + shift it should be a lot simpler to give and understand the direction.

Thank you soooo much!

Would it help to rename shifted into something more descriptive?

shifted_char
new_char
char_shifted
char_cipher
char_new

So we can keep in mind that this variable will hold a character, shifted or new in relation to char

I just realized that's exactly what happens in Step 26

Step 26
At the end of your loop body, declare a variable called new_index and assign the value of index + shift to this variable

https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-string-manipulation-by-building-a-cipher/step-26
Step 26 and 30 break up the exact actions of Step 16 into separate steps

Step 30
Now you need to create a new_char variable at the end of your loop body. Set its value to alphabet[new_index].

https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-string-manipulation-by-building-a-cipher/step-30

Step 23
Before printing the current character, declare a variable called index and assign the value returned by alphabet.find(char) to this variable.

not clear enough:
Step 23
Before printing the current character, declare a variable called index and assign the value returned by alphabet.find(char) to this variable.

not clear enough:
Step 23 Before printing the current character, declare a variable called index and assign the value returned by alphabet.find(char) to this variable.

This will be changed with the next PR.


Finance overview KPI docs

updated revenue KPI documentation
listed and organized available KPIs

@microsoft-github-policy-service agree [company="fenwick"]
Johnathan Gonzalez
Power BI Product Manager | Partner Success Manager
[cid:0a669993-55d0-420d-92ad-4aebd7a5046e]https://www.fenwick.com.au/
[cid:e1e12bdd-1c27-49aa-94ec-b64b4c5b20a5]https://appsource.microsoft.com/marketplace/partner-dir/06cdaf09-14f0-4cd1-8ac0-7bfed707a82c/overview
fenwick.com.auhttps://www.fenwick.com.au/
Brisbane +61 07 3635 7222tel:61736357222
Level 6/200 Adelaide St
Brisbane City QLD 4000
Melbourne +61 03 9695 3333tel:61396953333
Level 7/1 Southbank Blvd
Southbank VIC 3006
Sydney +61 02 8222 6444tel:61282226444
Level 3, 31 Alfred St (Customs House)
Sydney NSW 2000
[cid:1b1be2d0-806c-4486-922e-6825d545e876]http://www.linkedin.com/company/fenwick-it
[cid:926c9e36-3e74-4e5c-8347-38bebf6467ae]https://support.fenwick.com.au/
@.***?anonymous&ep=signature>
Book time to meet with @.***?anonymous&ep=signature>

From: microsoft-github-policy-service[bot] @.>
Sent: Thursday, June 6, 2024 2:29 PM
To: microsoft/Project-Yellowstone-Documentation @.>
Cc: Johnathan Gonzalez @.>; Mention @.>
Subject: Re: [microsoft/Project-Yellowstone-Documentation] Finance overview KPI docs (PR #2)
@JNGZhttps://github.com/JNGZ please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/Project-Yellowstone-Documentation/pull/2#issuecomment-2151388509, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAPW5SQLQJBWBEB3Q4XFDLZF7QRRAVCNFSM6AAAAABI352JOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRGM4DQNJQHE.
You are receiving this because you were mentioned.Message ID: @.***>


No README and Contributing file

It is suggested that you create a README file describing about the project and Contributing file showing the guidelines to be followed to contribute to this project

totally forgot about this when copying the demos from another repo. Thanks!


nice: move from getopts to clap #1794

This is failing on mac os, could you please fix this? thanks

This is failing on mac os, could you please fix this? thanks

Yeah I was just looking into that.  I don't have a macos system handy that I can test on.  But as far as I can tell from https://opensource.apple.com/source/shell_cmds/shell_cmds-17.1/nice/nice.1.auto.html, macos is using the netbsd version of nice.  So https://man.netbsd.org/nice.1 if you want something human-readable.  The main issue seems to be that the BSD version of nice doesn't seem to support running a bare "nice" without any arguments to display the current level of niceness.  So a lot of the tests are failing due to that.  But I think there's additional issues too beyond that.
I'll have to spin up a BSD VM to play around and that should be enough to approximate the behavior on macos, then I can sort out the differences there.

You can always push changes in your github fork to debug remotely (not ideal :)

Few updates here:

I ditched the few tests that were doing some variation of "nice nice" because the 2nd invocation is dependent on the system version, and that's not really what we want to test anyway.
I spun up a netbsd virtual machine, and the tests pass there.  Yay.
I got my hands on a macbook, and... the tests also pass on the macbook???

At this point I am quite confused why the macos CI is failing.

Finally figured this one out.  nice was checking errno after calling getpriority, but wasn't clearing errno beforehand.  When run inside of the test suite, some previous library call in another utility must have been setting errno and then the getpriority call was mistakenly being interpreted as failed.  No matter what arguments were supplied to nice, it would always fail with ENOENT (which isn't even a valid error for getpriority).  If nice was run standalone, it worked.  It also worked if the tests were invoked like cargo test --features nice --no-default-features because there was no prior library call to set errno.  The fact that this worked on platforms other than macos was just luck.
With that said, @sylvestre I think this is ready now.


Moderator tools fixes

Hi,
this PR change the behaviour of "Mute video for peer" button.

Mute video for peer now disables only webcam
Added new "Mute screen sharing for peer" button
Added new "Mute screen sharing for all" button on top

These tools are obviously for moderator only.
Fixes https://github.com/havfo/multiparty-meeting/issues/347

Thanks! Merged!


Chronos monopolizing Mesos Offers

Our Current deployment.
3 Master Nodes running

Mesos Master - 0.22.1-1.0.ubuntu1404
Marathon - 0.8.1-1.0.171.ubuntu1404
Chronos - 2.3.3-1.0.1.ubuntu1404

3 Slave Nodes running:

Mesos Slave - 0.22.1-1.0.ubuntu1404

The symptoms we are seeing is that chronos monopolizes all the offers causing Marathon to no longer be able to deploy anything to Mesos. In the latest extreme case is seems as if Chronos itself could no longer run tasks because it had consumed all the offers from Mesos.
To be clear our Mesos cluster has plenty of resources, it just seems that Chronos is not releasing the offers. My team has commented on this in the issue https://github.com/mesos/chronos/issues/381
We thought we had worked around the issue by creating what we call a "Release Resources" task in Chronos. This task is just sleep 5s and is scheduled to run every 5 seconds. The problem generally occurs after Chronos has been sitting idle and no tasks have been run through the system for a period of time. At first that period of time seemed to be weeks, but now we are seeing it occur more often.
It is worth noting that our usage pattern for the Chronos has changed. This could explain why the duration of time between incidents has also changed. Where there were not many jobs running before, we now have more consistent flow of tasks into the Chronos service. There still are hours where the Chronos server may not be running tasks though, since most of our tasks are not reoccurring at this point in time.
@apriendeau @bcarpio @jkrukoff  @ssk2

This might or might not be related to https://github.com/mesos/chronos/issues/509. Since you are only running very few frameworks this is probably another issue, though.
It would be helpful if you provided your master state.json (http://master.mesos:5050/state.json).
Do you see a lot of "Offered Resources" in the overview of the Mesos UI (left side bar)?

@kolloch currently we aren't experiencing the issue. When the issue is present I can confirm that I see many 'Offered Resources' in the Mesos UI. During the next event our team will ensure we screen shot the Offered Resources UI. I did see that UI full of Resources offered to Chronos if that is what your thinking.

This should have been fixed by #510. Please reopen if you this happens to you again.


request/question: How to access debug log stream

Greetings. Thank you for the amazing library. I'm curious as to how to access this libraries standard output and error stream. Is it printed and ephemeral or is it written to a file. My intention is to assert in my tests whether something was logged. Any insight would be much appreciated.

Definitely ephemeral, but you can override the .log property in order to process debug messages. However, it's not the most elegant API admittedly.
Check out #556 which would solve a lot of the testing needs, too. Not sure when it will be implemented.
Does that help?

Thank you for the quick response. Yes, your insight is extremely helpful. I'll explore further. Else I'll implement some version of #192 .

Right now the ugly hack for Node would be to pass all of those strings to strip-ansi and then pass them to a file.

Sounds fun. I'll get my hands dirty. Also, it just occured to me that it may prove effective to wrap a sinon spy around the debug function, then do a getCalls().args on it. I'll let you know how that pans out for the benefit of others. But otherwise you may close the issue.

You can definitely do that.
Keep in mind, however, that depending on how you're using debug, it might be an anti-pattern to test against what's passed to debug.

Thank you. I willl :)


DacFx .NET Core Support

Are there any plans to support .NET Core in the near future? Right at the moment the nuget package restore prints Package 'Microsoft.SqlServer.DacFx.x64 140.3881.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'

@pensivebrian can you comment on plans for this?

It's planned, though a couple of months out. I don't have a more specific date unfortunately.

👍 Thx...

@pensivebrian Do you have any updates on this? Not being able to use this in .Net Core means we still have to rely on .Net Framework for certain things and we'd like to move away from that so we can take advantage of the new features in .Net Core 2.1

@redoz - please take a look at the following github issue, which has links to obtain preview builds of sqlpackage. Hopefully, that gets you unblocked. If not, let me know what you're looking for.
https://github.com/Microsoft/mssql-docker/issues/135#issuecomment-391898727

@pensivebrian I took a quick look, and it seems like the Microsoft.SqlServer.Dac.dll that it ships with is what I'm looking for (I'm only after the DacService/DacPackage classes). Are they by any chance also available in a pre-release nuget package somwhere?

@redoz - They will eventually be added to the Microsoft.SqlServer.DacFx.x64 nuget packages, but I don't have any concrete timelines other than in the next couple of months.

@pensivebrian No chance there's a myget feed somwhere with pre-release packages? The DLLs are in the zip, but I'm hoping for a better way to reference them than an old-school lib folder. This is for test/ci only, unsupported is fine.

+1 here: a version compatible with .Net Core would be much appreciated. Even if it's just a beta version since it's for CI here too.

Ask and you shall receive: https://docs.microsoft.com/en-us/sql/tools/sqlpackage-download?view=sql-server-2017

@kevcunnane Any chance there's a .Net Core compatible Microsoft.SqlServer.DacFx nuget package as well?

Unfortunately not yet. @pensivebrian would be handling that and he hasn't had time to get to this task.

Actually I too, was talking about a .Net Core version of the Microsoft.SqlServer.DacFx nuget package; sorry about the misunderstanding (and anyway, thanks for replying so quickly).
I'll wait for this package to be ready then.

@kevcunnane @pensivebrian By any chance do you have, meanwhile, an ETA for the .NET Core compatible nuget package? Under what name will the package be available?
Given that installers are available already for Windows. MacOS and Linux, one wonders: Isn't this just another packaging up of an existing (sub-)set of files?

@pensivebrian

It's planned, though a couple of months out. I don't have a more specific date unfortunately.
any update on the matter?

Any update on this?
Looking for a nuget package that includes _ DacService/DacPackage _ ? (for core 2.1)

@anqdotse  - I'm now actively working on this. I'm hoping to have a preview nuget package published in the next couple of weeks.

Okay, the preview package which support netcoreapp2.1 and net46:
https://www.nuget.org/packages/Microsoft.SqlServer.DACFx/150.4240.1-preview

Okay, the preview package which supports netcoreapp2.1 and net46:
https://www.nuget.org/packages/Microsoft.SqlServer.DACFx/150.4240.1-preview

deployment contributors: expected to work already?
Microsoft.SqlServer.Dac.DacServicesException: An error occurred during deployment plan generation. Deployment cannot continue.
Error SQL0: Required contributor with id '[...]DeploymentContributor' could not be loaded.
 ---> Microsoft.Data.Tools.Schema.Sql.Deployment.DeploymentFailedException: Contributor initialization error.
   at Microsoft.Data.Tools.Schema.Sql.Deployment.SqlDeployment.InitializeContributors()
   at Microsoft.Data.Tools.Schema.Sql.Deployment.SqlDeployment.InitializePlanGeneratator()
   at Microsoft.Data.Tools.Schema.Sql.Deployment.SqlDeployment.CreateController(Action`1 msgHandler)
   at Microsoft.SqlServer.Dac.DacServices.CreateController(SqlDeployment deploymentEngine, ErrorManager errorManager)
   --- End of inner exception stack trace ---
   at Microsoft.SqlServer.Dac.DacServices.CreateController(SqlDeployment deploymentEngine, ErrorManager errorManager)
   at Microsoft.SqlServer.Dac.DeployOperation.<>c__DisplayClass16_1.<CreatePlanInitializationOperation>b__1()
   at Microsoft.Data.Tools.Schema.Sql.Dac.OperationLogger.Capture(Action action)
   at Microsoft.SqlServer.Dac.DeployOperation.<>c__DisplayClass16_0.<CreatePlanInitializationOperation>b__0(Object operation, CancellationToken token)
   at Microsoft.SqlServer.Dac.Operation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
   at Microsoft.SqlServer.Dac.ReportMessageOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
   at Microsoft.SqlServer.Dac.OperationExtension.CompositeOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
   at Microsoft.SqlServer.Dac.OperationExtension.CompositeOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
   at Microsoft.SqlServer.Dac.DeployOperation.Microsoft.SqlServer.Dac.IOperation.Run(OperationContext context)
   at Microsoft.SqlServer.Dac.OperationExtension.Execute(IOperation operation, DacLoggingContext loggingContext, CancellationToken cancellationToken)
   at Microsoft.SqlServer.Dac.DacServices.InternalDeploy(IPackageSource packageSource, Boolean isDacpac, String targetDatabaseName, DacDeployOptions options, CancellationToken cancellationToken, DacLoggingContext loggingContext, Action`3 reportPlanOperation, Bo
olean executePlan)
   at Microsoft.SqlServer.Dac.DacServices.Deploy(DacPackage package, String targetDatabaseName, Boolean upgradeExisting, DacDeployOptions options, Nullable`1 cancellationToken)
   at ...Program.Main(String[] args) in /work/main/Program.cs:line 422

@patrikbeno - I'm still in the process of getting our tests running against .NET Core, so there may be gaps, though I expected this to work. Can you share some more details?

is this .net core 2.1?
what OS?
the path you are using to the contributor?

.NET Core 2.1.402, Windows 10.0.17134 (x64)
Also tried using microsoft/dotnet:2.1-sdk-alpine docker image. Same result.
Everything is in current working directory, including contributor.

Update:
NOK:
$ dotnet main/bin/Debug/netcoreapp2.1/main.dll

Error SQL0: Required contributor with id '...' could not be loaded.

OK:
$ dotnet publish
$ dotnet main/bin/Debug/netcoreapp2.1/publish/main.dll

contributor found, executed (simple for now, no logic inside)

I noticed that bin/Debug/netcoreapp2.1 contains only project DLLs, no dependencies (package references).
The code works to some point, e.g. I can use Microsoft.SqlServer.Dac namespace without having its DLL in bin folder, but it seems that when it tries to load contributor...
Seems like runtime is smart enough to load DLLs from .nuget/packages but DACFx is not...

Any chance of a .net standard version of this? Trying to create a cake addin but it seems to need netstandard

Unfortunately, we depend on System.ComponentModel.Composition, which only exists in .net core 2.1. If/when netstandard 2.1 is finalized, I'll update the nuget package to target it.

if there's an update and a nugget for .netcore 2.1 ?

We moved to .netcore 2.2 since it's needed to support sqlclient AAD connections. Looks like a version of System.ComponentModel.Composition was released that support netstandard 2.0 so I'm investigating creating a version that can target netstandard 2.0. I hope to have something to release in the next month or so.

Is the code that is running on .netcore the same as the 4.6 runtime? should we expect any behaviour changes?

Although compiled from the same source, the bits are different due to changes introduced by .NET Core, and requirements to run cross platform. However the supported TSQL surface area is the same.
The key .NET Core differences:

Only in-memory models are supported. File backed models use Esent, which is Windows only.
Deployment contributors are not supported. I'm hoping to rectify this soon by supporting .netstandard 2.0. This way, contributor authors can target .netstandard 2.0, which will run on platforms.
Import/Export of large database fails due to .NET Core not supporting zip archive streaming. A fix for this is actively being worked on.
File paths to .dacpac references (e.g. master.dacpac) have case sensitivity issues. The workaround when publishing is to put the referenced .dacpac next to the target .dacpac, but ALLCAPS the file name.

We hope to have all of these issue fixed and get .NET Core to GA quality over the next 6 months.

Thanks I have a couple of small feature requests for contributors, is it ok to open issues or should they go somewhere else?

Sure, opening issues here is fine. Or the official vsfeedback site.

Hi! Is license info still actual after release a 150.4316.1-preview package of Microsoft.SqlServer.DACFx? In license terms you wrote

iii. Distribution Restrictions. You may not

distribute Distributable Code to run on a platform other than the Windows platform;

from the other hand in release notes was published : This release includes cross-platform preview builds of sqlpackage that target .NET Core 2.2. The sqlpackage can run on macOS and Linux.
Can I use Microsoft.SqlServer.DACFx package of 150.4316.1-preview version for future deploy to Linux container?

@EvgeniyaKamenska - thanks for pointing this out. I'll get this oversight fixed soon. The macOS/Linux sqlpackage downloads include a license.txt file with the non-windows platform section removed. I need to update the nuget package to include this version of the licence.txt.

@pensivebrian I am using the preview version of Microsoft.SqlServer.DacFx "150.4316.1-preview" but when I try to deploy a DACPAC to a SQL Server 2016, I get the following exception:
 Microsoft.SqlServer.Dac.DacServicesException: 'An error occurred during deployment plan generation. Deployment cannot continue. Error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanExecutor could not be instantiated. Error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanModifier could not be instantiated. '
I am tied to this preview version because I must use .NET Core. I have also tried the "CopyLocalLockFileAssemblies" workaround suggested above and have confirmed that the extensions assembly is in the bin folder. Do you have any solutions to this issue?

@pensivebrian I'm trying to use the 150.4384.2-preview to create a DACPAC from a SQL script.  I'm getting a System.IO.IOException: 'Entries cannot be opened multiple times in Update mode.' exception from the DacPackageExtensions.BuildPackage method using the logic below.  The same code works as expected using the Framework version of DacFX.
        static void Main(string[] args)
        {
            var script = "CREATE SCHEMA [Test]\r\nGO\r\n" +
                "CREATE TABLE [Test].[Identity]([TestId] int NOT NULL IDENTITY,\r\n" +
                "CONSTRAINT [PK_Identity] PRIMARY KEY ([TestId]))\r\nGO\r\n";
            var tSqlModelOptions = new TSqlModelOptions
            {
                AnsiNullsOn = true,
                Collation = "Latin1_General_CI_AI",
                CompatibilityLevel = 130,
                QuotedIdentifierOn = true
            };
            var outputFilename = "Identity.dacpac";
            using (var tSqlModel = new TSqlModel(SqlServerVersion.Sql130, tSqlModelOptions))
            {
                tSqlModel.AddObjects(script);
                if (File.Exists(outputFilename))
                {
                    File.Delete(outputFilename);
                }
                DacPackageExtensions.BuildPackage(outputFilename, tSqlModel, new PackageMetadata { Name = outputFilename }, new PackageOptions { });
            }
        }

The underlying stream flushing problem in corefx seems to have been solved a while back in https://github.com/dotnet/corefx/issues/26952 and yet https://github.com/dotnet/corefx/issues/32296 seems to be a 3.0 milestone task?  Is this related to the same issue mentioned above?

Import/Export of large database fails due to .NET Core not supporting zip archive streaming. A fix for this is actively being worked on.

@BrentJohnsonNz - can you post the complete callstack?
Update mode refers to the mode used when opening a ZipArchive. Update mode doesn't work well .NET Core 2.X. So, I'm in the process of making the DacFx use Write mode to work around the issue. I should have a nuget pushed with a fix in 1-2 months.
The import/export issues were separate, though related. Fixes for those issues are checked into .NET Core 3.0 master, and I'm in the process of pulling those fixes into DacFx as well.

@EvgeniyaKamenska - the license has been updated in the latest nuget release.

@pensivebrian
System.IO.IOException
  HResult=0x80131620
  Message=Entries cannot be opened multiple times in Update mode.
  Source=System.IO.Compression
  StackTrace:
   at System.IO.Compression.ZipArchiveEntry.OpenInUpdateMode()

System.IO.Compression.dll!System.IO.Compression.ZipArchiveEntry.OpenInUpdateMode()
System.IO.Compression.dll!System.IO.Compression.ZipArchiveEntry.Open()
System.IO.Packaging.dll!System.IO.Packaging.ZipStreamManager.Open(System.IO.Compression.ZipArchiveEntry zipArchiveEntry, System.IO.FileMode streamFileMode, System.IO.FileAccess streamFileAccess)
System.IO.Packaging.dll!System.IO.Packaging.ZipPackagePart.GetStreamCore(System.IO.FileMode streamFileMode, System.IO.FileAccess streamFileAccess)
System.IO.Packaging.dll!System.IO.Packaging.PackagePart.GetStream(System.IO.FileMode mode, System.IO.FileAccess access)
Microsoft.Data.Tools.Schema.Sql.dll!Microsoft.Data.Tools.Schema.Sql.Build.SqlPackage.ArtifactContent.GetInputStream()
Microsoft.Data.Tools.Schema.Sql.dll!Microsoft.Data.Tools.Schema.Sql.Build.SqlPackageContent.GetStream()
Microsoft.Data.Tools.Schema.Sql.dll!Microsoft.Data.Tools.Schema.Sql.Build.DacUtilities.FinalizePackage(Microsoft.Data.Tools.Schema.Sql.Build.SqlPackage package, Microsoft.Data.Tools.Schema.Sql.Dac.DacOrigin dacOrigin, uint modelVersion)
Microsoft.SqlServer.Dac.Extensions.dll!Microsoft.SqlServer.Dac.Model.SqlSchemaModelObjectService.BuildPackage.AnonymousMethod__0()
Microsoft.SqlServer.Dac.Extensions.dll!Microsoft.SqlServer.Dac.Model.SqlSchemaModelObjectService.ExecutePackageOperationWithErrorHandling(System.Action dacPackageOperation)
DacFxNetCore.dll!DacFxNetCore.Program.Main(string[] args) Line 29
	at C:\Users\brent\Source\Repos\DacFxNetCore\Program.cs(29)

Calling to new DacServices(connString) throws Exception
System.TypeInitializationException : The type initializer for 'Microsoft.SqlServer.Dac.DacServices' threw an exception. ---- System.IO.FileNotFoundException : Could not load file or assembly 'System.Security.Permissions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
Framework: netcoreapp2.1

I managed to generate a .dacpac file programmatically from a model on Ubuntu 18.04 with .NET core 2.2 but the file came without the Origin.xml file, am I doing something wrong?
using System;
using System.IO;
using Microsoft.SqlServer.Dac.Model;
using Microsoft.SqlServer.Dac;

namespace dacpacPOC
{
    class Program
    {
        static void Main(string[] args)
        {
            var script = "CREATE SCHEMA [Test]\r\nGO\r\n" +
                "CREATE TABLE [Test].[Identity]([TestId] int NOT NULL IDENTITY,\r\n" +
                "CONSTRAINT [PK_Identity] PRIMARY KEY ([TestId]))\r\nGO\r\n";
            var tSqlModelOptions = new TSqlModelOptions
            {
                AnsiNullsOn = true,
                Collation = "Latin1_General_CI_AI",
                CompatibilityLevel = 130,
                QuotedIdentifierOn = true
            };
            var outputFilename = "Identity.dacpac";
            using (var tSqlModel = new TSqlModel(SqlServerVersion.Sql130, tSqlModelOptions))
            {
                tSqlModel.AddObjects(script);
                if (File.Exists(outputFilename))
                {
                    File.Delete(outputFilename);
                }
                DacPackageExtensions.BuildPackage(outputFilename, tSqlModel, new PackageMetadata { Name = outputFilename }, new PackageOptions { });
            }
        }
    }
}

My .csproj file is the following:
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.2</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.SqlServer.DACFx" Version="150.4384.2-preview" />
  </ItemGroup>

</Project>

@pensivebrian Any ETA on when this .NET Standard package will leave preview status / license?
When .NET Standard 2.1 is released?

I'm having the same error as @Michael1d with Error 72002: The extension type Microsoft.SqlServer.Dac.Deployment.Internal.InternalDeploymentPlanExecutor could not be instantiated. on version 150.4451.1-preview. Does anyone have a clue about this?

@Tarmil  and @Michael1d - I'll see if I can repro this.
@BrentJohnsonNz - A nuget update was just pushed that should fix your issue.

Is it possible to build .dacpac file from .sqlproj project on Ubuntu 18.04 with .NET core 2.2?
Brand new .sqlproj project is using <TargetFrameworkVersion>v4.5</TargetFrameworkVersion> and I didn't find how to target it to .net core or netstandard2.0 and build successfully.
If it is not possible right now then what is the best option?
Build a custom tool based on the following approach?
https://github.com/Microsoft/DACExtensions/issues/20#issuecomment-492754204

@Ne4to, the msbuild toolset for sqlproj will not run on Ubuntu. Currently, the custom tool approach as mentioned in the above comment is the only way to build a .dacpac on Linux/macOS.
We've been considering adding a sqlpackage /action:build command which would take a list of .sql files as input, along with /p parameters that match the properties the sqlproj file, which would output a .dacpac. This would be a simple way to enable cross platform builds. I'm interested if you or anyone would use this if added to sqlpackage.

I'm interested if you or anyone would use this if added to sqlpackage.

It would definitely be very helpful for our team.
We are migrating to .Net Core & Linux containers and we have difficulties with applying database changes automatically.

@pensivebrian we see the following exception while calling ExportBacpac from a .NET core 2.2 app:
System.TypeInitializationException: The type initializer for 'Microsoft.SqlServer.Dac.DacServices' threw an exception. ---> System.TypeLoadException: Could not load type 'System.Diagnostics.Eventing.EventDescriptor' from assembly 'System.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
   at Microsoft.Data.Tools.Diagnostics.Tracer.WriteEtwEvent(TraceEventType eventType, TraceId traceId, String message)
   at Microsoft.Data.Tools.Diagnostics.Tracer.TraceEvent(TraceEventType eventType, TraceId traceId, String message)
   at Microsoft.Data.Tools.Schema.Sql.SchemaModel.SqlSchemaModel.InitializeModelSchema()
   at Microsoft.SqlServer.Dac.DacServices.Initialize()
   at Microsoft.SqlServer.Dac.DacServices..cctor()
   --- End of inner exception stack trace ---
   at Microsoft.SqlServer.Dac.DacServices..ctor(String connectionString)

Here are the details of the invocation:
var dac = new Microsoft.SqlServer.Dac.DacServices(connectionString);
var localBacpac = Path.GetTempFileName();

dac.ExportBacpac(localBacpac, databaseName, DacSchemaModelStorageType.Memory);

@pjvds - that stack trace implies the code that targets net46 is running. The netstandard2.0 target should not reference the WriteEtwEvent method. Can you confirm you are loading the correct netstandard2.0 assemblies and not the net46 versions?

Microsoft.SqlServer.DACFx has GA'd. Closing this as fixed.

@epatrick did you include the wrong package?

Not correct package, remove .x64!

Doh!
Thanks for the extra set of eyes! Apologies for the rabbit hole.


Create devops automation to stand up the Synapse node on GCP.

This task is to automate the creation and re-creation of the Synapse node stood up for issue #265 using the details documented for issue #266

The machine is up and running on GCP.   Running the pyrsia/synapse fork.  Synapse will startup automatically on reboot.  50gig download drive is being used.  IP addr is <IP_ADDRESS> and can be accessed using synapse.webredirect.org.

May want to use Terraform down the road to provide a way to stand up on any cloud provider for a production setting.


[unnumbered-ptp] Allow nodeports to work when routed to local pods

Addresses #38
This implements the solution described in the issue for services using ExternalTrafficPolicy: Cluster
This is not enough for ExternalTrafficPolicy: Local because in that case traffic is not SNATed on the host so the answer is not coming back on the veth interface.
We haven't tested it extensively yet but initial tests are OK. I'm opening the PR to discuss the design and see what you think about it

Thanks for merging this, we've also been using this on large clusters for the last 6 months without any issue.
I also have a solution for ExternalTrafficPolicy: Local but it's a bit complicated because it relies on marking packets inside all pod network namespaces. You can see it here: https://github.com/DataDog/cni-ipvlan-vpc-k8s/compare/master...DataDog:feature/nodeports-local?expand=1


Added skeleton for isEven.js

Make sure these boxes are checked before submitting this pull request~!~ Thank you!!

[x] The test of the method you have fixed is passing
[x] You have written a new skeleton method for someone else to work on!
(This is the new skeleton for my other pull request - min.js)

Looks good! If you could please write an isEven.test.js file in the test directory and include appropriate tests, I'll merge this in along with your other pull request, thanks!

I've somehow created too many threads here, but I think the test has been added successfully for isEven.test.js

@melissa3000 if you click on the "Files Changed" tab in this PR, you will see that they aren't any tests included. Maybe you didn't push it up?

Every time I make a change, it creates a new number. The test is in #105. Sorry, I have no idea why I can't get it to add to my existing pull request.

@melissa3000 I'm not sure what is going on with your branching either. Hmmm I don't mind the extra pull requests, so don't worry about continue to try to sort out the issue.

Resuming convo here: https://github.com/BlakeGuilloud/ganon/issues/97


[Bug]: PLAYWRIGHT_NODEJS_PATH env variable is ignored in version 1.43.0

Version
1.43.0
Steps to reproduce
Use custom PLAYWRIGHT_NODEJS_PATH env and try to run the application, it is now ignored and playwright java tries to use a node executable from a non-existing /tmp directory
Expected behavior
PLAYWRIGHT_NODEJS_PATH is respected as previously
Actual behavior
PLAYWRIGHT_NODEJS_PATH is ignored
Additional context
Exception:
{
   "@timestamp":"2024-04-15T08:17:46.483296314Z",
   "@version":"1",
   "message":"Application run failed",
   "logger_name":"org.springframework.boot.SpringApplication",
   "thread_name":"main",
   "level":"ERROR",
   "level_value":40000,
   "stack_trace":"<#ba825b6d> java.io.IOException: error=2, No such file or directory\n\tat java.lang.ProcessImpl.forkAndExec(Unknown Source)\n\t... 2 frames excluded\n\t... 72 common frames omitted\nWrapped by: <#8f32ceda> java.io.IOException: Cannot run program \"/tmp/playwright-java-704439393333648951/node\": error=2, No such file or directory\n\tat java.lang.ProcessBuilder.start(Unknown Source)\n\tat java.lang.ProcessBuilder.start(Unknown Source)\n\tat com.microsoft.playwright.impl.PlaywrightImpl.createImpl(PlaywrightImpl.java:51)\n\t... 69 common frames omitted\nWrapped by: <#e61b64ad> com.microsoft.playwright.PlaywrightException: Failed to launch driver\n\tat com.microsoft.playwright.impl.PlaywrightImpl.createImpl(PlaywrightImpl.java:58)\n\tat com.microsoft.playwright.impl.PlaywrightImpl.create(PlaywrightImpl.java:36)\n\tat com.microsoft.playwright.Playwright.create(Playwright.java:110)\n\tat com.microsoft.playwright.Playwright.create(Playwright.java:114)\n\tat com.sumup.reporting.exports.processor.pdf.BrowserContextPooledObjectFactory.makeObject(BrowserContextPooledObjectFactory.kt:44)\n\tat org.apache.commons.pool2.impl.GenericObjectPool.create(GenericObjectPool.java:566)\n\tat org.apache.commons.pool2.impl.GenericObjectPool.addObject(GenericObjectPool.java:222)\n\tat org.apache.commons.pool2.ObjectPool.addObjects(ObjectPool.java:89)\n\tat com.sumup.reporting.exports.processor.pdf.PlaywrightConfig.browserContextPool(PlaywrightConfig.kt:34)\n\t... 2 frames excluded\n\tat org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:258)\n\tat org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:331)\n\t... 3 frames excluded\n\tat org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:140)\n\t... 53 common frames omitted\nWrapped by: <#19ff69d0> org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.sumup.reporting.exports.processor.pdf.PlaywrightConfig$BrowserContextPool]: Factory method 'browserC...\n"
}

Environment

Operating System: Alpine Linux
Browser: Chromium
Java Version: 21
CPU: amd64

I think it might be related to this PR https://github.com/microsoft/playwright-java/pull/1519

The problem is probably that we don't inherit env from the System and use the empty Collection instead when looking for PLAYWRIGHT_NODEJS_PATH.
https://github.com/microsoft/playwright-java/blob/2829a37d58e7c1ce3bd30e3a41334874f58a4830/playwright/src/main/java/com/microsoft/playwright/impl/PlaywrightImpl.java#L40

@mxschmitt
Is there a chance to release a bugfix release with this fix? As we use dependabot, it constantly breaks our stuff.

@marrek13 we will release it as part of 1.44

@mxschmitt ok, thanks for the heads-up. I added 1.43 to ignored versions.


Max Width Property on Email Logo

There seems to be no max-width property on the email logo with the Salted Theme.
Is there any way this could be limited? On Outlook, some logos take up almost the entire screen if the image is too big.
This logo property is set in the product object when setting a theme.
Thanks!

Hi @Samuel-Montoya,
Thanks for your suggestion.
Currently all themes come with a hard-coded max-height: https://github.com/eladnava/mailgen/blob/c4356d74be84b38728f7b897b2580e0948082950/themes/salted/index.html#L57-L59
One option is to to resize the logo image you are providing to mailgen to the desired dimensions to make sure it doesn't occupy too much space.
The other option is to add an option to customize the max-height or add another option to customize the max-width of the  element. This would require modifying all 4 themes and mailgen core to inject the relevant pixel value into the HTML templates. Would you like to attempt this?

I seem to have gotten a fix for my situation. For Outlook, the image element requires a width property to display correctly on the Outlook client.
<img src="<%- product.logo %>" width="200"/>
It would be wonderful if we were given the option to add or change this value, maybe in the product object?
product: {
        name,
        link,
	logo: LOGO_URL,
        width: 200
}

This would be especially nice so we don't have to manually resize pictures.
Just a thought. Thanks for your time.

@Samuel-Montoya Sounds like a good plan. Are you comfortable with JS? Do you want to attempt adding this parameter in?

Hello @eladnava. Has this been implemented? Would like to help with it

Hi @Aptcoder,
It has not. What do you say about adding an optional width integer attribute to the product object and injecting it into the themes'  tag if present?

I believe that is an appropriate solution. I would check for the property in mailgen core and set a default value if no value is given then use assign the attribute using ejs. I personally have not experienced the issue described as I do not have access to outlook mail but I believe this should be a fix

Sounds good! Actually, sorry for the confusion, but it would be better if we modified the height and not the width, to maintain backward compatibility.
Currently, all themes set the logo max-height to 50px:
 .email-logo {
   max-height: 50px;
 }

I would say the best approach would be to allow passing in a custom height (via product.height) and only if it was passed in, set it as a CSS property on the  tag. This would ensure backwards compatibility when people update mailgen.

Alright. I will make a PR to this effect

Merged in #41.


Promote SPI/RemoteSecret from staging to prod

https://github.com/redhat-appstudio/remote-secret/pull/80
https://github.com/redhat-appstudio/remote-secret/pull/81
https://github.com/redhat-appstudio/remote-secret/pull/74
https://github.com/redhat-appstudio/remote-secret/pull/91
https://github.com/redhat-appstudio/remote-secret/pull/85
https://github.com/redhat-appstudio/remote-secret/pull/84
https://github.com/redhat-appstudio/remote-secret/pull/90
https://github.com/redhat-appstudio/remote-secret/pull/89
https://github.com/redhat-appstudio/remote-secret/pull/86
https://github.com/redhat-appstudio/remote-secret/pull/73
https://github.com/redhat-appstudio/remote-secret/pull/78
https://github.com/redhat-appstudio/remote-secret/pull/94
https://github.com/redhat-appstudio/remote-secret/pull/95
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/657
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/663
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/652
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/666
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/668
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/670
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/669
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/657
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/672
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/674
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/671
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/676
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/679

/retest-required

/lgtm


[BUG]: Unable to load pre-downloaded model weights

Before You Report a Bug, Please Confirm You Have Done The Following...

[X] I have updated to the latest version of the packages.
[X] I have searched for both existing issues and closed issues and found none that matched my issue.

DeepFace's version
0.0.92
Python version
3.12
Operating System
Debian
Dependencies
#9 229.0 absl-py==2.1.0
#9 229.0 astunparse==1.6.3
#9 229.0 beautifulsoup4==4.12.3
#9 229.0 blinker==1.8.2
#9 229.0 certifi==2024.7.4
#9 229.0 charset-normalizer==3.3.2
#9 229.0 click==8.1.7
#9 229.0 deepface==0.0.92
#9 229.0 filelock==3.15.4
#9 229.0 fire==0.6.0
#9 229.0 Flask==3.0.3
#9 229.0 flatbuffers==24.3.25
#9 229.0 gast==0.6.0
#9 229.0 gdown==5.2.0
#9 229.0 google-pasta==0.2.0
#9 229.0 grpcio==1.65.2
#9 229.0 gunicorn==22.0.0
#9 229.0 h5py==3.11.0
#9 229.0 idna==3.7
#9 229.0 itsdangerous==2.2.0
#9 229.0 Jinja2==3.1.4
#9 229.0 keras==3.4.1
#9 229.0 libclang==18.1.1
#9 229.0 Markdown==3.6
#9 229.0 markdown-it-py==3.0.0
#9 229.0 MarkupSafe==2.1.5
#9 229.0 mdurl==0.1.2
#9 229.0 ml-dtypes==0.4.0
#9 229.0 mtcnn==0.1.1
#9 229.0 namex==0.0.8
#9 229.0 numpy==1.26.4
#9 229.0 opencv-python==<IP_ADDRESS>
#9 229.0 opt-einsum==3.3.0
#9 229.0 optree==0.12.1
#9 229.0 packaging==24.1
#9 229.0 pandas==2.2.2
#9 229.0 pillow==10.4.0
#9 229.0 protobuf==4.25.4
#9 229.0 Pygments==2.18.0
#9 229.0 PySocks==1.7.1
#9 229.0 python-dateutil==2.9.0.post0
#9 229.0 pytz==2024.1
#9 229.0 requests==2.32.3
#9 229.0 retina-face==0.0.17
#9 229.0 rich==13.7.1
#9 229.0 setuptools==71.1.0
#9 229.0 six==1.16.0
#9 229.0 soupsieve==2.5
#9 229.0 tensorboard==2.17.0
#9 229.0 tensorboard-data-server==0.7.2
#9 229.0 tensorflow==2.17.0
#9 229.0 termcolor==2.4.0
#9 229.0 tf_keras==2.17.0
#9 229.0 tqdm==4.66.4
#9 229.0 typing_extensions==4.12.2
#9 229.0 tzdata==2024.1
#9 229.0 urllib3==2.2.2
#9 229.0 waitress==3.0.0
#9 229.0 Werkzeug==3.0.3
#9 229.0 wheel==0.43.0
#9 229.0 wrapt==1.16.0
Reproducible example
from retinaface import RetinaFace

RetinaFace.detect_faces("image.jpg")

FROM python:3-slim

WORKDIR /app

COPY apps/face/requirements.txt ./requirements.txt

ENV DEEPFACE_HOME /home

RUN apt-get update && \
    apt-get install ffmpeg libsm6 libxext6 curl -y && \
    pip install --no-cache-dir -r requirements.txt && \

    # Download pre-trained model
    curl -o retinaface.h5 https://github.com/serengil/deepface_models/releases/download/v1.0/retinaface.h5 && \
    mkdir -p /home/.deepface/weights/ && \
    mv retinaface.h5 /home/.deepface/weights/retinaface.h5

COPY apps/face/src ./src

CMD [ "python", "./src/index.py" ]

### Relevant Log Output

Unable to synchronously open file (file signature not found)

### Expected Result

The same behavior as if no model was pre-installed in Docker.

### What happened instead?

When the model is called it returns this error: Unable to synchronously open file (file signature not found).
Saw some old closed issues but these didn't work

### Additional Info

_No response_

weight file is available at https://github.com/serengil/deepface_models/releases/download/v1.0/retinaface.h5
try to download it manually, paste into the repo and copy in your docker file
you most probably having this issue because of proxy or firewall. it is not an issue related to deepface. it is related to network level communication.

Turn out it was my curl command that was missing the -L parameter.
curl -L -o {model_name} https://github.com/serengil/deepface_models/releases/download/v1.0/{model_name}.h5


Selectable data

When exploring the component data in the devTools tab you can only watch the tree, but there is no way of copying the text. Allowing that would be useful.

Fixed in latest version.


Reference to figure is linked to an equation instead of  the figure (pg 163)

Describe the erratum
On pg 163:
"Geometrically, the situation collapses to that in figure 8.9"
Here figure 8.9 is linked to equation 8.9. I believe you, instead, might mean to link figure 8.1. But cannot be certain as I have not yet reached pg 174 where figure 8.9 is found.
Version and Location
8th December 2021

Thank you; this has been fixed and will appear in the next draft!


"UnkwownError" happened for a line of "var"

var _Comm_id, _Comm_protocol_version_minor;

met "UnkwownError: ":

But, if I split the statement into 2 lines:
var _Comm_id;
var _Comm_protocol_version_minor;

there is no error.
If I split the cell into 2, no error also.
Most likely it is a bug. Please check.

fixed once #25 lands


have 1.3 load weight from 1.2? could the weight of full-attn compatible with Skiparse-attn？

have 1.3 load weight from 1.2? could the weight of full-attn compatible with Skiparse-attn？

both yes.


getInt not implemented for class oracle.jdbc.driver.T4CRowidAccessor

Running DependencyCheck with an Oracle Database not working.

I hope that there is a way, that DependencyCheck also support an Oracle database.
This should work for the oracle jdbc driver
OracleResultSet keys = (OracleResultSet) ps.getGeneratedKeys();
keys.next();
ROWID rowID = keys.getROWID(1);

I do not have an Oracle DB to test against. However, per https://docs.oracle.com/cd/B19306_01/java.102/b14355/jdbcvers.htm#CHDDEAED the code needs to explicitly state which columns are auto-generated. The 1.2.11 code base used the Statement.RETURN_GENERATED_KEYS when preparing the statements. I just committed a change that will hopefully resolve this.
You can either try the 1.2.12-SNAPSHOT (compile from source) or wait a few days for the 1.3 release to confirm whether or not this issue has been resolved.
--Jeremy

With 1.3.0 it seems to work with oracle DB. Thanks !!!
The first import takes hours, but that's ok.


chore: add a dockerfile replicating the CI environment locally

Overview
In order to avoid the issues related to replicating the CI environment locally to regenerate the wrappers, and run the tests, this PR adds a Dockerfile that replicates the environment in a docker image that can be used.
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

utACK

@SweeXordious can we also get documentation on how to use the Dockerfile?

@adlerjohn https://github.com/celestiaorg/quantum-gravity-bridge/pull/157 like this?


Type coercion doesn't work on schemas nested inside an array

When you have the following nested schema inside an array, type coercion only work for the outer field but not for the inner one:
schema = Dry::Schema.Params do
  required(:id).value(:integer)
  required(:hashes).each do
    schema do
      required(:inner_id).value(:integer)
    end
  end
end

schema.call({id: '23', hashes: [{ inner_id: 452 }] })
# => #<Dry::Schema::Result{:id=>23, :hashes=>[{:inner_id=>452}]} errors={}>>

schema.call({id: '23', hashes: [{ inner_id: '452' }] })
# => #<Dry::Schema::Result{:id=>23, :hashes=>[{:inner_id=>"452"}]} errors={:hashes=>{0=>{:inner_id=>["must be an integer"]}}}>

I can't explain what's going on here.
The problem does not seems to manifest is there's no array in the middle:
schema = Dry::Schema.Params do
  required(:id).value(:integer)
  required(:hash).schema do
    required(:inner_id).value(:integer)
  end
end

schema.call({id: '23', hash: { inner_id: '452' } })
# => #<Dry::Schema::Result{:id=>23, :hash=>{:inner_id=>452}} errors={}

Affects my production application: YES
Ruby version: 2.6.5
OS: Linux 4.10.0-42-generic #46-Ubuntu SMP x86_64 GNU/Linux

Your schema is incorrect because it's missing an array type. This one works:

schema = Dry::Schema.Params do
  required(:id).value(:integer)
  required(:hashes).array(:hash) do
    required(:inner_id).value(:integer)
  end
end

.array above includes both the type and the each predicate.
Docs have examples: https://dry-rb.org/gems/dry-schema/1.4/nested-data/#nested-code-array-code

Oh, sorry for the noise, thanks!
El vie., 6 dic. 2019 15:35, Nikita Shilnikov<EMAIL_ADDRESS>escribió:

Closed #207 https://github.com/dry-rb/dry-schema/issues/207.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dry-rb/dry-schema/issues/207?email_source=notifications&email_token=AABA2X7QUAXCD6ECU2LVYV3QXKLOZA5CNFSM4JW6W5XKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVKOFAUA#event-2862370896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABA2X7OVQIZLYFGZTI2YFTQXKLOZANCNFSM4JW6W5XA
.

Np. It's used to work differently in pre-1.0 so it's a common "trap". It seems to work at the beginning, but it actually doesn't. And you only know when you pass invalid input 🤷♂


Integration of HumanoidBench tasks

Hello.
This is a new pull request to integrate some of the tasks from HumanoidBench into MJPC.
As discussed in the previous pull request (#328, which is now closed) and by mail, I have solved the issues we discussed earlier.
I updated the git tag for Menagerie to a version that includes the Unitree G1 robot. Because of this, I also had to update the patch file for the quadruped robot, so it is still compatible. I just copied the patch file there, which is on the "deepmind" branch of this repository.

Great tasks!
It looks like the floor is visualized a bit higher than the contact plane, let's modify the floor so that contacts with it are properly visualized.
For the H1 push task, can we make the box goal position interactive? We can use the same logic as the quadruped flat task to enable the user to move the goal mocap body via click and drag.
For the G1 walking task, have you tried using the same PD actuator model as the H1? Additionally, we might want to remove the hand DOFs from the model since they aren't used for locomotion and the additional DOFs make simulation more expensive. We should be able to reduce the planning horizon for this task to 0.35-0.4 seconds. Another way to improve this task is to replace the mesh collision geometries with primitives (eg, spheres, capsules).
Thanks!

Hi
I solved the issue with the floor and made the box goal interactive.
Regarding the G1 robot, I have remove the DOFs in the hand, but MPC still does not manage to keep standing. So I removed the G1 completely.


Add offset string from offset minutes conversion method to Time singleton

This PR was prompted by the code in #58479
While it would overcomplicate things for all of the methods in the Time singleton to know about the timezone offset, it would be useful to provide a helper method for converting a timezone offset to a string. So this PR does that.
It's a common convention for the zero timezone offset to be indicated by "Z". If that's desired, it's easy for users to implement themselves, just if offset == 0: return "Z"; else: Time.get_offset_string_from_offset_minutes(offset), and some people may prefer "+00:00", therefore I decided to leave logic for this it out of the method.
I also added const to the Dictionary parameters in two of the other methods.

Thanks!

Cherry-picked for 3.5.


Support injecting abitrary exporters

The only way to inject an exporter for a particular test at the moment is to mount the exporter JAR, and then the configuration file.
This library can be particularly useful for exporter authors, and so it should be as easy as possible to test their exporter using it, ideally without having to create a docker image on the fly (but not a hard requirement if this is the simplest way).

This is now supported with Zeebe > 0.23.x


Video playback (Reddit) not working on chroot.

Output of sudo edit-chroot -all:
name: xenial
encrypted: no
crouton: version 1-20190902190258~master:9a594a66
release: xenial
architecture: amd64
xmethod: xorg
targets: gnome
host: version 12499.66.0 (Official Build) stable-channel candy
kernel: Linux localhost 4.4.190-16770-gb3c36ab5af98 #1 SMP PREEMPT Thu Nov 14 23:21:08 PST 2019 x86_64 x86_64 x86_64 GNU/Linux
freon: yes

Please describe your issue:
Watching videos on Reddit (which are embedded video files, like mov, m4a, mp4, gif, gifv, etc.) does not work. The first frame of the video ('thumbnail') displays but the video does not play.
If known, describe the steps to reproduce the issue:

Open Reddit
Click on post containing video
Be sad that you can't watch the video

I suppose I'll also ask 2 questions I have: is it possible to decrypt a chroot, and can you undo making a chroot autostart?

@SirNapkin1334,

is it possible to decrypt a chroot, ...

Maybe but it's not easy, see this comment by the crouton author -

https://github.com/dnschneid/crouton/issues/1024#issuecomment-55548474

... and can you undo making a chroot autostart?

Yes, you can undo it by removing /etc/init/crouton.conf and/or by changing the run state in your croutn.init file to 'n' like: RUN_STATE=n

And is it possible to make an encrypted boot autostart?

I don't know of a way but I haven't played with it since doing the autostart stuff.
Hope this helps,
-DennisLfromGA


add test tags to cloud resources

scheduled cloud cleaner (running daily on osbuild-composer repo), removes old
enough and tagged resources. Adding the "gitlab-ci-test" tag to all
testing resources so they can get cleaned if the cleanup function fails.

@jrusz do you think scheduled cloud cleaner will clean properly azure images from this test? I've read your code but you are more familiar with it

but it currently won't clean anything left by this test.
What do you think is the best approach here? Change the name of the generated images? or add labels to testing azure images and rewrite scheduled cloud cleaner so removes tagged resources?

but it currently won't clean anything left by this test.
What do you think is the best approach here? Change the name of the generated images? or add labels to testing azure images and rewrite scheduled cloud cleaner so removes tagged resources?

I'd just name all the resources in this api.sh test the same way they're named in osbuild-composer repository and make sure it's using the same AZURE_RESOURCE_GROUP and any other vars that will affect the final destination of the resources.

Looks good, just one tiny nitpick. Did you test it in any way?

For testing, I manually went to the cloud and saw that the resources where tagged, (in GCP is not needed as the bucket they are uploaded get automatically cleaned. For azure it the name had the TEST_ID format). Do you think I should test it a bit more? I could remove the cleanup part of api.sh test and check the resources get removed.
I didn't test it much more as the code is the same as in osbuild-composer.


Stacks Panel Optimizations and Improvements

Right now the stacks panel for in-page stack editing is inadequate for sites with large amounts of stacks. All the stack folders and the stacks themselves are loaded into the panel, which makes things very slow.

Add folder support.
Add search support to interface.
Make sure that contents of folders are lazy loaded via AJAX so that we don't load content we don't need.
When using stacks with multilingual, if I've created localized versions of stacks that have blocks in them, but there are no blocks in the root stack, the menu says "Stack Name (0 Blocks)" even though the sub-stacks do have blocks in them.

We don't have all of this original task – we don't have search support, etc... However I'd like to redesign the stack panel and this issue can go away until we have time to do that.


realm: Schedule realm deletion time while deactivating realm.

Fixes: #24677
Discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/deactivate.20organization.20modal

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alexmv I have addressed all your feedback and I think this PR is complete now except adding a backend test about which I have asked few questions in this comment. So, you can take a look now.

@zulipbot add "buddy review"
@HemantUmre12 please have a look to this PR.

@alexmv I have locally done changes for most of the comments. I have asked a couple of minor questions in inline commands would be great if you can answer them. After this PR would be ready for review.

@alexmv I have adressed all your commemnts. Please have a look.

@sahil839 can you take a look at frontend changes in this PR?

@sahil839 I have updated the PR and have also resolved all the merge conflicts. You can take a look now.

@sahil839 I have updated the PR. You can take a look now.

@sahil839 I have updated the PR and have addressed the comments other than renaming. I could not think of better variable names.

@sahil839 I have done the changes as per your comments. Please have a look.

LGTM. @timabbott ready for your review. I am not sure about the naming of couple of functions like valid_till_text and the corresponding classes and also posted a comment about refactoring above.

Glad this is close to the finish line! I added a couple tiny nits I saw in passing.
One other thought occurs to me -- does scheduled_deletion_date get unset when a realm is scrubbed? Because if not, then we'll re-enqueue it the next time the cron job runs, and re-scrub an ever increasing list of realms.
Can you add a test for this?

Yes, Earlier I missed the part of unsetting when a realm is scrubbed. Now, I have made changes and scheduled_deletion_time is made to null once a realm has been scrubbed, so the realm will not be enqueued next time. I have not added a separate test for this instead have tested this in test_scrub_deactivated_realms.

@Ujjawal3 just a ping that it'd be great to get this finished so that we can integrate all your work on it!

@timabbott this PR is completed. I have rebased the PR to resolve the merge conflicts. You can integrate it now.

@Ujjawal3 thanks for all the work on this; I've pushed back a version with several edits detailed above. A few requests not remarked on above:

I think the API should be switched to _days, not _minutes -- this was discussed in the #design thread. (You may find you want the JS code to convert units just before talking to the API so that you can use the reusable web app component built in terms of minutes)
I think we should make scrub_deactivated_realm be the name of a function that is the block of code that you currently have in the deferred_work queue processor for doing the scrubbing; and the cron job can call that directly (without using the queue processor), such that only the immediately option would use the queue processor, and the queue processor would have very little code.

I have a few product decisions to settle that might result in a few other small changes, but I think those are the main things I need from you to merge this.

@timabbott I have done the changes. You can take a look now.

@Ujjawal3 cool, let me know the resolution to https://github.com/zulip/zulip/pull/26109#discussion_r1308095044; also you probably need to renumber the API changelog stuff again as I think I just merged a little PR that bumps to 206 today.

I have rebased the PR to bump the feature level entry.

Closing in favor of https://github.com/zulip/zulip/pull/31957, which builds on the final changes that remain from this pull request.


fix(#1): infinite pnpm install

Description
Fix infinite pnpm install bug
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] You have only one commit (if not, squash them into one commit).

Summary by CodeRabbit

New Features

Updated Docker image to a newer version, potentially introducing enhanced features and improvements.
Upgraded multiple libraries in package.json, enhancing functionality, security, and performance across the application.

Bug Fixes

Removed delays in navbar navigation and the sign-up button interactions, improving responsiveness and user experience.

These changes collectively aim to provide a smoother and more efficient user experience.

@coderabbitai full review


Created a standalone utility for uploading images to GCR

This util will be used together with run_interop_test.py@#10037 to generate docker images for test replay.

Btw, 2 of the 3 commits in this PR have very weird commit messages "	Thu Mar 9 15:53:53 PST 2017" - please git rebase -i upstream/master so that there's just one commit with a reasonable commit message.

A bit unrelated: the run_interop_tests.py --manual_run will allow you to build ready-to-test docker images for  java and go  (because the run_interop_tests.py script lives outside of those repos, so you can apply the current version to older versions of java and go).  For grpc/grpc repo, we will need to find a way to generate the images for older releases that don't have the --manual_run support yet.
Perhaps checking out older release and applying https://github.com/grpc/grpc/pull/10037 on top of it would work, but there also might be some conflicts. alternatively, we could just make sure to patch the part that deletes the docker images and use the commandline from the most recent version - at least some of the well established interop tests cases should handle that just fine, their cmdline interface is pretty stable. Btw, this is another reason why storing the cmdlog in the docker image itself doesn't seem to be useful - because there's going to be a manual step to figure out the comments for older releases.

Done merging the commits.  Thanks for the input.  I will like to have a setup for java and go client first and start running to_prod tests before working on c++.
Will have separate PRs on creating images and driving the test.


Fix HaxeIntroduceVariable unit tests.

Unit test fixes: HaxeIntroduceVariableTest.testReplaceAll3
Two primary issues:  The first was a change in the BNF that changed the
underlying type of HaxeLocalVarDeclaration to a HaxePsiField.  The second
was changing the type of HaxePsiField from a HaxeComponent to a
HaxeNamedComponent.
In the first case, the change itself wasn't really a problem; it was that
HaxeComponentType.typeOf() hadn't been changed to reflect the new reality
that it was going to be asked about HAXE_LOCAL_VAR_DECLARATION types.  It
simply returned null for types it didn't know about, thus
HaxeIntroduceHandler.getOccurrences() stopped its loop looking for the
enclosing method element.  The fix was simply to add that type to the list
of classifications.  HAXE_VAR_DECLARATION was also added as future-proofing.
In the second case, HaxePsiField must be a HaxeComponent for
HaxeQualifiedNameProvider to work correctly.  If it is not a HaxeComponent,
a ClassCastException is thrown and refactorings requiring names silently fail.
Fix unit test HaxeMethodPsiMixinImpl.testSuggestName2()
Reverts part of change 15b15746de19cd7a5132666fa361b8ef88a47058
which added an override for HaxeMethodPsiMixinImpl.getContext().  The
override called getContainingClass() instead of getParent().  That
caused a tree_walk_up to skip several nodes, notably the CLASS_BODY
element, and HaxeIntroduceHandler could no longer walk all of its
children to find all of the fields in a class.  Thus, for the test case
names were suggested that clashed with a function name.

reviewed & approved - please merge it @EBatTiVo

Merged via git rebase.


feat: allow to define fallback functions

I am using Feature Flags in Gitlab and I like to keep the amount of feature flags as a minimum.
Therefore we configure feature flags only for production environment and like to change the default behavior for undefined toggles.
Current default is false. And we need to set it to true.
In the unleash-client you are allowed to pass a fallback function.
I'd like to have this sort of functionality for the proxy client too.

see https://github.com/unleash-hosted/unleash-proxy-client-js/pull/26

implementation doesn't work


Scoped enums

Use bond::EnumType::EnumValue for internal use of Bond enums.  This will make it easier, in the future to provide an option to produce 'enum class EnumType' declarations.
This is a WIP PR to run the check-build, prior to cleanup/rebase/etc.

Can you @ ping me when this is ready for review?

I'm still having issues with g++ not accepting bond::EnumName::EnumValue
syntax.
Is that something that's currently part of our unit-tests? The Enumeration
example demos it; is that compiled for g++? I don't know why it wouldn't be
working here, if it works elsewhere.
-jeff
On Tue, Jun 28, 2016 at 1:08 PM Christopher Warrington <
<EMAIL_ADDRESS>wrote:

Can you @ ping me when this is ready for review?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/bond/pull/190#issuecomment-229167130, or mute
the thread
https://github.com/notifications/unsubscribe/ALR8_aPDScpAtTMN5gqNCwRP-QO1fS1wks5qQX9BgaJpZM4I_lye
.

If you're trying to compile it with g++ in C++03 mode, that's probably why. It will compile with  g++ with C++11 or higher (and with clang++ in any mode, because of an extension, but that extension should emit a diagnostic).

I'm seeing the behavior that @glenfe describes when I try toy examples with g++ and clang.

Yeah; looks like there isn't a reliable way to setup these enums which will
make all the different compilers & C++-flavors happy & let you do both
"MyEnum x = MyEnum::abc" and "MyEnum x = abc".  Or, if there is, it's a
hellish amount of macros or something to make it happen.
The enumerations example works because it switches g++ into C++11 mode.
-jeff
On Wed, Jun 29, 2016 at 8:27 AM, Glen Fernandes<EMAIL_ADDRESS>wrote:

If you're trying to compile it with g++ in C++03 mode, that's probably
why. It will compile with g++ with C++11 or higher (and with clang++ in any
mode, because of an extension, but that extension should emit a diagnostic).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/bond/pull/190#issuecomment-229392525, or mute
the thread
https://github.com/notifications/unsubscribe/ALR8_QO5T7627-XcDNIAo1YyLGv2QUtaks5qQo7KgaJpZM4I_lye
.

This change is fundamentally incompatible with C++03, and is thus unsuitable for Bond at this time.
I thought we'd done some clever namespace-thing to allow scoped-enum syntax to work in C++03, but that relied on a Microsoft compiler extension, and the enumeration-example which demonstrates the behavior is setup to compile in C++11.


CentOS 7: "Unlock" button in GUI grayed out and prompted for password to shutdown / restart?

When using XRDP to login as a user with Administrator privileges, I can't create another user in "Settings > Details > Users" because the "Unlock" button near the upper right is grayed out. I also noticed that I get prompted to enter a password when using the menu in the upper right to Restart or Power Off the machine.
When logging in with the same user account directly via VMware Remote Console, the "Unlock" button is not grayed out and I do not get prompted for credentials when restarting / powering off, so it appears to be specific to logging in via remote desktop.
Is there a way to grant administrator users these permissions when logging in via remote desktop? Ideally I'd like the experience to mimic logging in directly via VMware Remote Console as closely as possible, with the same permission set for both.
P.S.: Apologies if the answer should be trivial, I am still somewhat new to Linux administration in general.
Environment: CentOS 7 64-bit, GNOME 3 desktop (classic version)

Hi, it is polkit related issue. You can enable it by configuring polkit properly.

Hi, it is polkit related issue. You can enable it by configuring polkit properly.

Apologies if it should be self-explanatory, but would you mind elaborating on what specifically I need to do for "configuring polkit properly"? If the process is already documented somewhere else that's perfectly fine as well, I'd greatly appreciate if you could link me to the instructions / documentation, if it's not too much trouble for.
Either way, thanks for the assistance!

As a quick update, I did some Googling and came across an article with this section discussing xrdp and polkit which seems promising, though it specifically mentions Ubuntu rather than CentOS 7 (and also mentions that it will generate a "crash system" popup on older versions of Ubuntu).
Is this what you mean by "configuring polkit properly", or are the instructions different for CentOS?

Polkit controls whether to allow users to shutdown/restart and other commands so generally it's out of scope of xrdp.
This instruction is written in Japanese but you'll find the similar if you google it. I hope you can find it in your language.
https://www.clear-code.com/blog/2016/12/27.html

Ah ok, thanks for clarifying!
I'll close my issue since it sounds like this is just a default security restriction that comes with the operating system installation, rather than anything specific with xrdp. I don't mind logging in via VMware Remote Console directly if I want to create a new user through the GUI, so I think I'll just leave the security policy as is to be safe.


[Feature][UI Next][V1.0.0-Alpha] Master adds empty data prompt.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9233 (1f82ed3) into dev (7553ae5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9233   +/-   ##
=========================================
  Coverage     40.19%   40.20%
- Complexity     4374     4375    +1
=========================================
  Files           817      818    +1
  Lines         32686    32685    -1
  Branches       3642     3640    -2
=========================================
+ Hits          13139    13141    +2
+ Misses        18316    18313    -3
  Partials       1231     1231

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/ApiApplicationServer.java
33.33% <0.00%> (-26.67%)
:arrow_down:

...uler/server/master/registry/ServerNodeManager.java
1.28% <0.00%> (-0.01%)
:arrow_down:

...e/dolphinscheduler/server/master/MasterServer.java
0.00% <0.00%> (ø)

...e/dolphinscheduler/server/worker/WorkerServer.java
0.00% <0.00%> (ø)

...r/server/master/runner/MasterSchedulerService.java
0.00% <0.00%> (ø)

.../dolphinscheduler/common/enums/SlotCheckState.java
0.00% <0.00%> (ø)

...lphinscheduler/service/process/ProcessService.java
30.38% <0.00%> (+<0.01%)
:arrow_up:

...pache/dolphinscheduler/common/utils/JSONUtils.java
69.14% <0.00%> (+0.33%)
:arrow_up:

...g/apache/dolphinscheduler/spi/utils/JSONUtils.java
17.64% <0.00%> (+1.22%)
:arrow_up:

...dolphinscheduler/remote/future/ResponseFuture.java
83.60% <0.00%> (+1.63%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7553ae5...1f82ed3. Read the comment docs.


DbProviderFactories.GetFactory fails

Hi!
I get the error below when I try to run:

Imports System.Data.Common
DbProviderFactories.GetFactory("DuckDB.NET.Data")
Error: System.Data.Entity.Core.ProviderIncompatibleException: 'A null was returned after calling the 'get_ProviderFactory' method on a store provider instance of type 'DuckDB.NET.Data.DuckDBConnection'. The store provider might not be functioning correctly.'
I'm trying to use the Entity Framework.
Thanks!
Ulisses.

DbProviderFactory Api isn't supported at the time. If you need it, consider sending a PR or supporting the project.

DbProviderFactory is important for database abstractions, I need it so that i can change store among databases, especilly between clickhouse and duckdb.
Can be implement it by ourself?

@bnuzhouwei I can give it a try if there are enough Sponsors for the project

@bnuzhouwei, can we support the project together? I also need this feature. Thanks!

I also need it, will give it a try.

Thanks @Seddryck


Update

update with master

Franz: The Teensy code for my tank diffbot is getting finalized. I must have zapped my Ardumoto board so am now using the L298N, which has a similar chip, but a more powerful version. These are available for $5US each, very cheap. The encoder publishing works fine. I wonder if you'd like to take a look at it? To test it with ROS I found I couldn't publish a negative number using
rostopic pub motor_right std_msgs/Int32 "100"
So instead I centered motor input at 100 (stop) in place of zero.
I assume Diffbot code has no trouble publishing negative numbers to Int32?


Update README.md

just to feel sth

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Final word should pause and celebrate

Fixed by https://github.com/michaelchadwick/bogdle/commit/dd38665600db4c7722613595f3c0da65a07ba85e


fix: can not set customize group name when thing name is specified

Issue #, if available:
I can not set customize thing group name when thing name is specified
Description of changes:
change customize group name scope
Why is this change necessary:
How was this change tested:
Rebuild docker image and run it with '.env' that only thing group name is specified without thing name
Any additional information or context required to review the change:
Checklist:

[ ] Updated the greengrass-entrypoint.sh

@DoubleChuang Thank you very much for your contribution!

Yes, thanks for bringing this to our attention! We will be releasing new images with this fix included soon.


scheduledScanConfig value sent for a one time scan run

On 2.5-head - commit id: b2953cbc

Deploy CIS v2
Create a one time scan run
The request sent has the scheduledScanConfig value sent.

scheduledScanConfig: {scanAlertRule: {}, retentionCount: 3}

Expected:
For one time scan runs - scheduledScanConfig should not be sent in the request.

On 2.5-head - commit id: baf4867

Create a one time scan CR.
scheduledScanConfig is NOT sent in the request. request sent has spec: {scanProfileName: "rke-profile-permissive-1.6", scoreWarning: "pass"}


[enhancements] UI Touch Ups

First rendering layout issue {When page is loaded for firs time there are still issue with}
Make sure colour scheme is more consistent
Make sure colour on dashboard and frontend match
Layout issue for Laptop
Mobile Phone Layout Testing
State Management Issue while performing advanced search
Larger Icons {Previous and Next}
Logo is not clickable on Login Page
When I click on Category Heading E.g. {Economics, Regional Update} it should take me to respective page
Icons are not matching for Categories with Mobile App

@hkacha lot of this list still needs to be worked on from, kindly attend to this list first.

@hkacha this issue is still not done. E.g. 8. and 7.


Support for Verify

@plioi are you interested in working together to get Verify and Fixie to play nice together?
https://github.com/VerifyTests/Verify

I'm intrigued, and I'm having to devote a lot of time to other things for a while :(
My most relevant contribution in the short term could be some discussion here. Scanning your readme, it looks like you release test framework specific adapters, so our goal might be One More Like Those?
Most of Fixie's design can be compared to xUnit and NUnit, so it might help to catch me up in terms of those two integrations: what all did you need to hook into for xUnit and NUnit? That might indicate which Fixie customization hooks will come in handy.

A deliberately funky question that might help catch me up on the concepts could be, "If there were no attempt at an integration, and you just tried to use Verify from within a Fixie test, what would go wrong?"

If there were no attempt at an integration, and you just tried to use Verify from within a Fixie test, what would go wrong?

So the Verify snapshot file naming needs a few things to be able to support a test framework

The MethodInfo of the current test
the current test file path. can be work around by  passing in a CallerFilePath on the verify call
the parameter values for a parameterized test. can be worked around by forcing people to call an extra method to pass through the parameters. This is not ideal, but it is the approach the xunit integration uses

So does fixie some kind of context api that exposes any of the above? For other libs the following approaches are used

xunit: a BeforeAfterTestAttribute attribute to capture the method info
nunit: via using the TestContext.CurrentContext static state
mstest: requirign a base class that has a TestContext state property
Expecto has no state object so we force users to explicitly define the name, but that is cumbersome, and means a subset of the Verify features cannot be used.

If fixie doesnt expose some kind of context, could have a go at  PR that adds one


npm run browser-tests leads to module not found error

I'm trying to get started with sw-testing-helpers for a new project. The README says that I can use npm run browser-tests to run the placeholder browser tests, but doing that leads to:
[~/git/sw-testing-helpers]$ npm run browser-tests

><EMAIL_ADDRESS>browser-tests /Users/jeffy/git/sw-testing-helpers
> nodemon test/server/index.js

28 Mar 11:54:54 - [nodemon] 1.7.1
28 Mar 11:54:54 - [nodemon] to restart at any time, enter `rs`
28 Mar 11:54:54 - [nodemon] watching: *.*
28 Mar 11:54:54 - [nodemon] starting `node test/server/index.js ./src/node-helpers/index.js`
module.js:341
    throw err;
    ^

Error: Cannot find module '/Users/jeffy/git/sw-testing-helpers/test/server/index.js'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:142:18)
    at node.js:939:3
28 Mar 11:54:54 - [nodemon] app crashed - waiting for file changes before starting...

What commands do run to execute an initial placeholder browser test suite, that I could then modify to suit my testing needs?

Propel is the only repo using this at the moment so is the only one I can recommend looking at for example. It's vacation today in UK so can put together some proper getting started comments tomorrow

Obviously feel free to add comments or raise a PR to help make is all clearer.

@jeffposnick I've done a fairly hefty refactor / reorg of the code to help with this.
Checkout the readme and the docs: https://googlechrome.github.io/sw-testing-helpers/
If you hit issues please either re-open or open new issues to highlight problem errors. Obviously PR's also welcome if you want to fix stuff yourself :)