protoc-gen-go is slower

I have used protoc-gen-go to generate the code which slower than protoc-gen-gofast. I did benchmarking(marshal and unmarshal) on both and found protoc-gen-go is much slower than other.
Can you please explain the difference?

Are your referring to gogo/protobuf/protoc-gen-gofast (that's what I found by doing a Google search for "protoc-gen-gofast")? I'm not familiar with the details of this library. I suggest that you ask authors about the difference.
We are currently testing improvements to golang/protobuf that make it faster. Those changes will be on github in a few weeks.

May I ask how you decide to improve the speed of golang/protobuf?
gogoprotobuf is currently faster then golang/protobuf because it does less memory allocations and uses code generation, which results in more inlining, calculations that can be done at generation time and less use of reflect.  I really don't see golang/protobuf catching this speed unless they finally decide to embrace some type of code generation.  I really hope these new speed improvements include a lot of code generation.

We looked at various approaches. Most of the speedup comes from compact table representations, reducing allocations / data movement, caching of various structures, and inlining where it matters.
We also prototyped codegen to measure performance improvement and binary size increase. Results of that experiment don't support making codegen a default setting now, but this is an area to explore further.

I am surprised.  I guess we'll have to run a benchmark.

I ran lot of benchmarking with around 12 attributes struct type, which is much slower than binary protocol and gogo protobuf too. That makes me hard to use golang protobuf generator.

I am surprised. I guess we'll have to run a benchmark.
To clarify, codegen makes code faster. It also makes binaries large enough that it's not a clear win.

I guess we'll have to run a benchmark.
Would you have any good benchmarks that you could share? We're especially interested in benchmarks modelling real environments.
One problem that we have is that using a tight loop around a simple proto operation is an easy to improve benchmark, but doesn't translate to improvements in context of running actual servers using protos.
If you have good benchmarks (if we improve the benchmark then real programs are actually improved) that we could use, then please share.

Here are two real world anonymized proto messages.
It should be pretty simple to remove the gogoproto parts, since they are very little in the representation.
https://github.com/katydid/testsuite/blob/master/relapse/gen-relapse-tests/puddingmilkshake.proto
https://github.com/katydid/testsuite/blob/master/relapse/gen-relapse-tests/typewriterprison.proto
Here is an impartial golang serialization benchmark
https://github.com/alecthomas/go_serialization_benchmarks

Since there is a trade off this is something that the protobuf user might want to decide.
Protobuf already has the concept of OptimizeMode, with which the user can specify which it prefers.
enum OptimizeMode {
    SPEED = 1;        // Generate complete code for parsing, serialization,
                      // etc.
    CODE_SIZE = 2;    // Use ReflectionOps to implement these methods.
    LITE_RUNTIME = 3; // Generate code using MessageLite and the lite runtime.
  }

https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.descriptor.pb

Thank you for sharing.


Which ACOLITE's  atmospheric correction is applied?

Hello,
Could you please specify which ACOLITE's atmospheric correction you applied to the Sentinel-2 L1C products before extracting the spectral information for each class?  rayleigh reflectance or surface reflectance?
Thank you for your work.
Andrea

Hello Andrea,
Thanks for your question. The answer is surface reflectance. You can read a detailed explanation of the Dark Spectrum Fitting algorithm (used by ACOLITE) at https://www.sciencedirect.com/science/article/pii/S0034425719301014?via%3Dihub#s0035 (Section 2.3.2).
Enjoy the data!
Kind regards,
Miguel


Not sure where else to go - Tg is no help, neither is the UI.  Can't even find my profile or it's status.

Tg groups keep referring me to other Tg groups to sift through codes and lists and miles of messages and diagrams and a million random comments.  I love the concept, but this is a very, very difficult UI/UX to navigate for a non-programmer.  Is it only meant for insiders?  I would hope not, but why isn't it designed to guide the user through instead of sending them through multiple apps, websites, articles, and no actual help on tap.  It needs a chat help function like Web2, where someone doesn't just reply in multiple day increments to each of the many issues that come up for people during the onboarding process.  I wait days for a response that is not helpful, and they're gone.
One person needs to help one person at a time, all the way through.  Then the UI really just needs to be scrapped and rebuilt by different people because if they could envision what people go through, it wouldn't look like this.  If it requires multiple help channels for each of the steps in the process, tutorials all over the place (that don't answer the problem I'm having), explainer articles... it simply wasn't designed properly.
Not trying to be rude, but I'm at least 4-5 hours into trying to figure this out and it just shouldn't be this hard.  It's an incredibly disjointed process with no continuity.
The
Describe the Bug
To Reproduce
Expected Behavior
Screenshots
**Device and Browser In

It's clear from my Tg chat that PoH isn't interested in the UX, new people, expanding, or constructive criticism.  It's also a fail IMO that you require money to sign up, money to get UBI.  People with money don't need UBI!!  People who have tech skills can earn it!


"Unexpected token import" is thrown out when build

here is the key code that bringing the error:
import GenericTransition from 'animated-vue/src/common/generic-transition';
i made some search, perhaps this error has relationship with babel, my environment cannot recognize  export default class GenericTransition in generic-transition.js
however it's okey not to use GenericTransition.
i don't know how to handle this, please do me some help, thank you !
here is my package.json:
"babel-core": "^6.26.0",
"babel-eslint": "^7.0.0",
"babel-loader": "^6.4.1",
"babel-plugin-add-module-exports": "^0.2.1",
"babel-plugin-transform-runtime": "^6.23.0",
"babel-preset-es2015": "^6.24.1",
"babel-preset-stage-2": "^6.24.1",
"babel-register": "^6.26.0",
"babel-polyfill": "^6.26.0",

@beiyang99
Thanks a lot for reporting this. This error is most of the time related to the build process you are using.
Might be a good idea to check the order of packages in your package.json's "devDependencies" entry and make certain things are applied in-order. For instance, I suggest you to switch babel-loader to appear AFTER babel-register.
Also, if you are using webpack, as a last measure you might want to do the following in your webpack config file:
{ test: /\.js$/, loader: 'babel-loader', include: [resolve('src'), resolve('test'), resolve('node_modules/animated-vue')] }


25 pipeline dag module

Prefect does the job I thought was needed to do and even more. I just added a tutorial about its usage with onTime.

@ben-jy, I removed the unused deps. The branch is ready to be merged.


fix form block evaluation context

So currentlny when you try something like:
form do |f|
  f.input :foo, :collection => Moo.some_scope(current_admin_user)
end

it will fail with
undefined local variable or method `current_admin_user' for #<ActiveAdmin::ResourceDSL:0x000000037aca30>

that is because this block binding. This "form do" block should be evaluated in the view context, then this method will be found.
Fix proposal included

Thanks for your contribution. This was fixed over the week-end (e541afa2d8f4ccd7413d218b29b9429cd2a0f97b) and released in 0.4.2.


Handlers for Error Injection

Hi,
In one of the case studies in the paper, SASSI was used to perform error injection to study application vulnerability. I am wondering if the handlers that were written for such study are available. Or is there a plan to make them available?
Thank you

Siva Hari has done the resilience work. I believe that you and Siva communicated privately about this, correct?

Yes we did communicate.
Thank you
On Thu, May 26, 2016 at 1:53 PM, Mark Stephenson<EMAIL_ADDRESS>wrote:

Siva Hari has done the resilience work. I believe that you and Siva
communicated privately about this, correct?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/NVlabs/SASSI/issues/8#issuecomment-221945271

--
Fritz PrevilonDepartment of Electrical and Computer Engineering
*Northeastern University *
Mobile:<PHONE_NUMBER>
previlon.f@g <EMAIL_ADDRESS>|
http://www.ece.neu.edu/~previlon/index.html


Use tensorboard 2.3.0

What does this PR do?
Unpin tensorboard version. 2.3.0 works fine for me, and otherwise it gets downgraded when I install PL.
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

just a heads up, at least for me, 2.3.0 breaks hparam logging, but 2.2.0 works fine.

it seems that our testing was passing, so @romesco mind adding a test (send a PR) to show the failing so we can fix it... 🐰

@Borda sure thing, I'll make a PR


Add support for Soil Moisture Sensor

Does this support the Soil Moisture Sensor? If not, can this be added?

Sorry I missed this @sethhere04, I don't log on here as much as I should.  Feel free to post questions on the EcoWitt Hubitat Community thread (if you are a member).
Yes, the drivers do support the Soil Moisture Sensors.  I have some myself, but have not actively used them in my automations yet.  You will see "humidity" readings in child devices of the gateway.

Might close this issue @sethhere04.  Like I mentioned earlier, the Soil Moisture sensors are supported.  If you have any issues setting one up or any more questions, just raise another issue here or post a question on the Hubitat Community.  Happy to help where I can.


[WIP] Feat: generic lookup support for all types

Fails

:no_entry_sign:
The version was not updated. Please update the version.

:no_entry_sign:
The changelog has not been updated. Please update the changelog.

:no_entry_sign:
This PR has failing tests. Please alleviate the errors and commit them

should sort and limit results as early as possible if there is no search, for performance benefits
expected false to be true

should support string label lookups
expected { Object (cardinality, options) } to deeply equal { Object (cardinality, options) }

should support array label lookups
expected { Object (cardinality, options) } to deeply equal { Object (cardinality, options) }

should support optionsFilter with a lookup that returns a single field
expected { Object ($match) } to deeply equal { Object ($match) }

should support a lookup with an optionsFilter with multiple keywords that span multiple fields
expected { Object ($match) } to deeply equal { Object ($match) }

:no_entry_sign:
Please add a description to your PR

:no_entry_sign:
Please assign someone to merge this PR, and optionally include people who should review.

Warnings

:warning:
The README has not been updated. Please update the README.

:warning:

Your PR has lint warnings. Please consider fixing these.

index.js
src/index.js
Unexpected console statement.
Line 36: console.log({ options, node, filters, aggs })

:warning:

Branch being merged does not follow Git Flow

:warning:
You should add at least 1 more reviewer to the PR

Messages

:book:
Could not find any browser results.

  Generated by :no_entry_sign: dangerJS against cdd27457217abb41c2d0cc5657669892383db1dd

@ccalbaugh wouldn't we do this with something like #83?


new design

Hello
would be nice to have a dark material Version!
++

depends on your alfred appearance.
how about this?

Very good! I did not see! sorry :relieved:


How to run skeptic in 2018 edition mode?

My Cargo.toml has edition = "2018" but that doesn't seem to get picked up by rust skeptic and it just always compiles in default. It should pick up the edition and use that.

Hi @svenstaro unfortunately I'm currently unable to look into this issue but I'd be more than glad to accept a PR!


CAPM3 should not select a BMH that is paused

What steps did you take and what happened:
Currently, when selecting a BMH, CAPM3 verifies that the BMH is available and in ready/available state. This is problematic because the BMH could be paused indefinitely, causing the machine deployment to fail on timeout from CAPI side.
What did you expect to happen:
CAPM3 should not consider BMH that have the pause annotation.

Cluster-api version: v0.3.3
CAPBM version: v0.3.0

/kind bug

/assign @Jaakko-Os

This needs to be fixed in master and release-0.3 branch

The modifications should be done in this part of the code : https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/baremetal/metal3machine_manager.go#L729

This needs to be fixed in master and release-0.3 branch

I checked and seems that BMH pause only in master branch

the Pause field is on the BMO side, it is independent of CAPM3. This issue is valid for release-0.3

@Jaakko-Os Please backport your bug, and close this issue only when the backport is merged.

Checked on the BMO side and it seems that pause is handled in the reconcile-loop https://github.com/metal3-io/baremetal-operator/blob/master/pkg/controller/baremetalhost/baremetalhost_controller.go#L193

yes, but CAPM3 should not select a BMH that is paused. that is the bug we are talking about

Now this bug report is ready to be closed


feat: typescript

add typescript to use type check
compile to es6 js
updated code to pass option as object in helper functions instead

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[core] add "leave network" API

This commit adds the otThreadLeaveNetwork API to let the node detach from Thread network and forget credentials.

@jinran-google
How the process of "leaving the network"  different from a otInstanceFactoryReset() of Thread stack?
I don't think we need to retain anything from the previous network when we want to forget (leave) the current one and potentially later join a new Thread network. We should join the new network as a new device (factory-reset fresh device).
In general, the factory reset is expcted to do 3 things:

Erase non-volatile settings (otInstanceErasePersistantInfo())
Would be good to also reset the OT Instance (so that all RAM variables used by OT stack are cleared) and reinitialized
Reset all platform layer (say radio)

The otInstanceReset() is supposed to do the last two though current implementations may try to reset the entire device which made sense for when we used NCP model but does not with RCP model and OT stack being part of host. I think we should try to update the implementation for this to reset the otInstance only.
otInstanceFactoryReset() supposed to do all 3.
For reference the wpantund/wpanctl provided leave command/API which did the above (erased non-volatile settings and then reset the NCP).

current implementations may try to reset the entire device which made sense for when we used NCP model but does not with RCP model and OT stack being part of host.

That's actually not 100% true.
For RCP, there is no reason a RCP device can't reset the entire device.
For otbr-agent process running on Host, it also makes sense to restart the whole process, which is the current strategy used by CLI factoryreset command.

Superseded by https://github.com/openthread/openthread/pull/7666.


 Then run "nginx -s quit" in the same folder. Just one nginx process is closed and the other one is still running.

you can try param -s stop


TypeError when predicting non-array data with dask-expr

Describe the issue:
Attempting to predict non-array data with a ParallelPostFit estimator raises a TypeError if dask-expr is enabled. It looks like dask-ml was relying on a type check against dask.dataframe._Frame to identify dataframes, but with the 2024.3.0 release of dask, that's no longer implemented by default.
Minimal Complete Verifiable Example:
from sklearn.ensemble import RandomForestRegressor
from sklearn.datasets import make_regression
from dask_ml.wrappers import ParallelPostFit
import dask.dataframe as dd

X, y = make_regression()

est = ParallelPostFit(RandomForestRegressor()).fit(X, y)
est.predict(dd.from_array(X))

raises...
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/... Cell 3 line 3
      1 X, y = make_regression()
      2 est = ParallelPostFit(RandomForestRegressor()).fit(X, y)
----> 3 est.predict(dd.from_array(X))

File ~/.../python3.10/site-packages/dask_ml/wrappers.py:327, in ParallelPostFit.predict(self, X)
    322     result = X.map_blocks(
    323         _predict, estimator=self._postfit_estimator, drop_axis=1, meta=meta
    324     )
    325     return result
--> 327 elif isinstance(X, dd._Frame):
    328     if meta is None:
    329         meta = dd.core.no_default

TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union

Anything else we need to know?:
Thanks!
Environment:

Dask version: 2024.3.1
Python version: 3.10.13
Operating System: PopOS
Install method (conda, pip, source): pip

Thanks for the report. @milesgranger are you able to take a look?

Looks like we need a release, that bit of code has been updated as part of the dask-expr integration in https://github.com/dask/dask-ml/pull/980: https://github.com/dask/dask-ml/blob/b3954e9ee1f7d7dee5ebdd5c4ca1b84f4dd96797/dask_ml/wrappers.py#L328

Thanks for confirming. I can cut a release now.

https://github.com/dask/dask-ml/actions/runs/8359352429 should be the job that pushes to PyPI

Works as expected, thanks for the quick release!


cuda_malloc out of memory

When I try to run the example code, specificaly the bunny_env_2 test case, it raises the following error
Traceback (most recent call last):
File "psdr_test.py", line 102, in
process(name, psdr_tests[name])
File "psdr_test.py", line 77, in process
direct_test(name, args)
File "psdr_test.py", line 63, in direct_test
run_ad(integrator, sc, dirname + "/direct_AD.exr", args)
File "/home/llx/psdr-cuda/examples/run_test.py", line 129, in run_ad
img = integrator.renderD(sc, sensor_id)
RuntimeError: cuda_malloc(): out of memory!
I use the nvidia 2080ti which has 11G memory. I wonder how much gpu memory does this test case need and is there method to reduce the required memory?

11G should be fine. but you want to double check you scene resolution and spp, sppe, sppse.
take a look at the config.py
for the bunny_env_2, the default value sppse=64 might be too high for 11G memory
I suggest you to change that value into 4, or even less for both spp, sppe and sppse
You can always have less spp/sppe/sppse but increase npass to have a clean gradient estimation
"spp"           : 4,
"sppe"          : 4,
"sppse"         : 4,

Thanks for your explanation.


Issue #10 Edit Scheduled Appt

Edit Scheduled Appt (inside (appt card)

Closing this issue. Able to Edit Schedule appt.


Installation stalls over and over

When I get to this point:
.venv/bin/pip3 install \
  -f 'https://synesthesiam.github.io/prebuilt-apps/' \
  -r requirements.txt \
  -r requirements_audio_enhancement.txt \
  -r requirements_vad.txt

I see it trying to download zeroconf==0.88.0 from https://github.com/synesthesiam/prebuilt-apps/releases/download/v1.0/zeroconf-0.88.0-cp39-cp39-manylinux_2_31_aarch64.whl and it will stop the download at different points during download  (in terms of MB downloaded)

I've tried rerunning it several times and it'll not be able to download all the way through and gives an error.
Also, should I be worried with the DEPRECATION?

Half of my problem might have been installing the 64bit Legacy Lite OS instead of the 64bit Lite OS.
I went back to running it on 64bit Lite OS and now it goes through more installs but still stalls in a different spot.

Tried it 5 more times and the last one went through. Go wonder! What is this due to?


Feature Request/Discussion - Pinned headers across sections

I just want to say upfront thanks so much for open sourcing this library. They say naming variables and caching data is the hardest thing in computer science, but I'd argue dealing with collection view layouts on iOS has made me pull out more hair over the years than anything else I can think of.
I have one feature request, and it's something I've been messing with over the last few days but this is your library, and I want to make sure that everyone here is happy with the idea/approach.
Is your feature request related to a problem? Please describe.
Section headers can be pinned to the top of the screen like table view headers can. This is fantastic! And more than enough in most circumstances. However, I have a use case where, instead of the section header scrolling off screen when we get to the next section, I want it to stay stuck until I encounter the next pinned section.
So let's say section 0 and section 5 are pinned. I want the header in section 0 to stay on screen while scrolling through sections 0 until 4, only scrolling off once we reach section 5.
Describe the solution you'd like
Currently in MagazineLayoutHeaderVisibilityMode there's a boolean pinToVisibleBounds property. I propose changing this to be an enum to be something like -
public enum MagazineLayoutPinningMode {
    case none
    case sectionVisibleBounds
    case visibleBounds
}

As mentioned in the opening, naming things are hard, so I'm not married to any of these. But essentially, none is the same is the current pinToVisibleBounds being set to false, sectionVisibleBounds is the current truebehaviour, and visibleBounds would be this new case I'm talking about.
Describe alternatives you've considered
One alternative could be to instead just allow the ability to create a header (similar to table view headers, not section headers) which could have pinning behaviour on it. In some ways this might be preferable as it doesn't muddy the implementation of section headers (which already behave as you'd probably expect based on how they work on table view headers), and doesn't break existing API. But this is also a little less flexible.
Additional context
This has come about because I'm working on an app which has a component based API (I'm guessing Airbnb has something similar if they've gone to the trouble of building this library) where all content is driven by the server. Each component is part of its own section, and I want video players to be able to stick around on screen. The option of putting everything in one section and only having one sticky header was investigated but in the end this made things even more tricky to deal with.

Hey @jarrodrobins, first of all, thanks for the feedback! It's always comforting to find other people who know the pain of working with collection view layouts 🙂 And also, thanks for taking the time to write up this feature request with all of those details!

My initial reaction is that, while I see how this is useful, I think collection view is the wrong tool for the job. My reasoning for this builds on these two "rules":

A section's elements should never leave the bounds of that section
A section's bounds should never overlap with another section's bounds

Having a sticky header from section 0 stay on screen, overlapping section 1-4, breaks at least one of those rules depending on how you implement it.
These "rules" are made up by me, based on how flow layout and table view work, but I do feel that it's an appropriate boundary to draw.

Here's an idea of how I'd implement this using collection view and a bit of custom "floating video view" logic:
If you have a video view that should start out in a section header (in section 0), you can add some logic in scrollViewDidScroll to on-the-fly pull that video view out of the header and into a floating view. When the header view comes back on screen, you can move the video view back to the header.

Happy to discuss more, or if you agree with my reasoning then feel free to close this out.


Expose a custom build of shaka-player on npm which only consists of essential packages for building a media player

Have you read the FAQ and checked for duplicate open issues?
Yes
Is your feature request related to a problem? Please describe.

We want to be able to import a complied version of shaka-player that is significantly smaller in size without the need to maintain a custom build. It should only contain the essential packages for building an adaptive media player:
+@networking
+@manifests
+@polyfill
+@lcevc

Describe the solution you'd like

Add another entry to build/all.py to generate an "essential" package:
build_args_essential = ['--name', 'essential', '+@networking', '+@manifests', '+@polyfill', '+@lcevc']

Describe alternatives you've considered

Additional context

You could create an automated workflow on GitHub that checks for the latest shaka-player release tag, builds with your arguments, and publishes to @your-org/shaka-player-minimal.
I think if we try to accommodate your configuration in the official package, we might end up supporting many others, and it could become a mess to manage.
In the future, we will port Shaka Player to TypeScript.  When we quit using the Closure Compiler, it would become easier for you to bundle just the modules you want into your app, without the need for a custom package/build in npm.
Does this help?

Hey Joey, thanks for the suggestions, we’ll be looking into how to do this within our organization.

I think if we try to accommodate your configuration in the official package, we might end up supporting many others, and it could become a mess to manage.

I totally get where you’re coming from, but I feel like this is not a specific custom build for our organization but more of a common use case though. Having a lite bundle which only contains the essential packages would benefit anyone who only wish to build a custom adaptive media player on browsers without the need for ads or casting. WDYT?

Should lite include DASH only?  Or HLS only?  Or both?  Which format do you use?  What if somebody disagrees?
What about subtitle formats?  Which ones are "essential"?
When someone's needs are everything in "lite", plus just one more module... Why not make another configuration for them?  Or consider just that one more module essential?

um yeah that makes sense, we'll move forward with your suggestion then, thank you!


Terminate by default after reporting errors

Escoria suffers from errors that can leave the game in an inconsistent
state and are easily missed in the output, which is sometimes very
verbose.
Without exceptions to throw, this hackish solution is (apparently) the
only way to make GDScript realize something is wrong and terminate.
Cowboys can disable this through the project settings.

This is very useful. :+1: Thanks!


(WIP) (role/htcondor) installs htcondor scheduler

HTCondor Scheduler profile

@cbarria Do you want review on this PR while its a draft and (WIP)?

not yet, i might noodle with github in the wrong way today... we have the module class still pending, sorry.

@cbarria FYI - Even if a PR is set as a draft, when you add reviewers the request shows up in https://github.com/pulls/review-requested.


RuntimeError: Encountered unresolved custom op: TensorArrayV3.Node number 3 (TensorArrayV3) failed to prepare.

I'm not so professional in python! I'm trying to convert frozen graph to tflite file in colab to start inference it using jetson nano. I get this error!
converter.allow_custom_ops = True
converter.experimental_new_converter = True
converter.optimizations = [tf.lite.Optimize.DEFAULT]
tflite_model = converter.convert()
open('tflite_file', 'wb').write(tflite_model)
interpreter = tf.lite.Interpreter(model_content=tflite_model)
interpreter.allocate_tensors()

@najme22
Can you please fill issue template.
Please, share colab link or simple standalone code with supporting files to reproduce the issue in our environment.It helps us in localizing the issue faster.Thanks!

Hi,
Seems you need to convert your model with select TF ops https://www.tensorflow.org/lite/guide/ops_select


Lock per logs/aggregate run

This started as a port from enterprise-2.0 but it turns out that this hasn't worked in enterprise and may have never been intended to be merged at the point in development where it was.
Essentially, it seemed like things were working but the rescue Exception => e in the aggregate run happened to swallow some key errors (this general rescue worries me, love to get rid of it, but that's another discussion... for now, is it placed in the right place? I think it may need to be in the block).
This PR fixes those errors and brings the locking to master. Which asks a big question, do we want this in .com/.org or should this sort of locking needed for HA setups in Enterprise be feature flagged?
@svenfuchs - Sorry to ping you on everything lately. :) I would love your thoughts since you authored the original commit and travis-lock. Are there good reasons to not do locking in .com/.org?

Has this been load tested, whatever that might mean? 😃

Great question. Not really. It's the same mechanism we use with scheduler in production  (though we only run a single option instance right now). So I would expect it to be safe. But indeed, not sure what load testing looks like here. Feels like it's rate limited since sidekiq only fires so often and then the redlock makes a request to redis and another at the end. (I guess if a customer spun up A LOT of instances in HA mode, and we used redlock a lot of places this could become an issue).

I'm in favor of this being optional behavior.

I can def see the case for this being optional. Biggest concern is any divergence in hosted and enterprise ends up adding QA load and problems down the road. So whenever possible, I prefer the two to use the same code because very often if we run into problems in .com/.org our largest customers will also have these problems in Enterprise, but it's much harder for us to debug there (distance between code change and release, diminished response time, only diagnostics we have are logs).

Is this behavior desirable for our hosted deployment(s)? We already wrap each log aggregation per log id in a database transaction, but that won't prevent duplicate work from happening.

Good question. It may be possible to do this without locking at all. I'm unfortunately not familiar with what it is blocking as I'm merely porting the work that @svenfuchs started. Anytime we can do something without run locking, I'm very happy. So I'm open to not doing this if that is in fact possible.

@meatballhat - Oh! Excellent! Thanks for moving this forward with all of the changes that happened in master! The changes in this code are generally what we're using in Enterprise 2.0.4 and Enterprise 2.1 right now so they should be good. However I'm not on the tls remote for travis-lock. Is this something I should look into bringing into Enterprise branches or can it wait until 2.2 when we branch off of master again?

@bnferguson I'm glad you like 😸   I don't think the TLS remote for travis-lock is critical, considering it was status quo for years before bundler started yellin' at us.

I don't think the TLS remote for travis-lock is critical, considering it was status quo for years before bundler started yellin' at us.

Sweet. 👍
Do you want me to do the deploys and merging of this branch, or would you rather since you've been deep in the logs game for a while. (Success would mean it shouldn't have any affect on anything, and aggregation should still work well. Failure being aggregations stops working).

@bnferguson If you approve of how this looks, I'm happy to manage deploy/merge.

@bnferguson If you approve of how this looks, I'm happy to manage deploy/merge.

Totally never followed up on this ping. So sorry! This looks fantastic. Thanks so much for keeping this in sync with your changes and getting it across the finish in my absence! :shipit:

This is working correctly in staging 🎉


Units mismatch

Despite selecting imperial units, it seems only the hourly forecast respects that setting as far as wind speed is concerned. See below for examples.

@s38b35M5 thanks for the report. will fix as soon as possible!

@s38b35M5 should be fixed in latest

Great improvement; thanks for the diligent work


feat: add silent flag and fix dry run with prerequisites

Description
Closes https://github.com/open-component-model/ocm-project/issues/37
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🎇 Restructuring
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Related Issue # (issue)
Closes # (issue)
Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help
[ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?

[ ] 📜 README.md
[ ] 🙅 no documentation needed

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

./bin/ocm controller uninstall -p
► uninstalling ocm-controller with version latest
► got latest version "v0.21.1"
✔ successfully fetched install file
► applying to cluster...
► waiting for ocm deployment to be deleted
✔ ocm-controller successfully uninstalled
► uninstalling cert-manager and issuers
► uninstalling cert-manager with version v1.13.2
► remove certificate for internal registry
Error: ✗ failed to uninstall pre-requesits: ✗ failed to create registry certificate: failed to delete manifests: delete failed, errors: ClusterIssuer/ocm-issuer query failed: no matches for kind "ClusterIssuer" in version "cert-manager.io/v1";Certificate/ocm-system/ocm-registry-certificate query failed: no matches for kind "Certificate" in version "cert-manager.io/v1";

➜  ocm git:(add-moar-flags) ./bin/ocm controller uninstall --silent -p
► uninstalling ocm-controller with version latest
► got latest version "v0.21.1"
✔ successfully fetched install file
► applying to cluster...
► waiting for ocm deployment to be deleted
✔ ocm-controller successfully uninstalled
► uninstalling cert-manager and issuers
► uninstalling cert-manager with version v1.13.2
► remove certificate for internal registry

@robertwol - what did you have in mind for the --silent flag? What should happen?
https://github.com/open-component-model/ocm-project/issues/37

Robert said this:

In my opinion silent usually suppresses logs but Robert specifically said exit status so... :) That's what I did. :D

Oh, and -o yaml is already done by dry run which just outputs the manifests it would have applied.


Minimal criteria builder

Added CriteriaBuilder component

hardcoded to support "Age Range" and "Gender"
generates cql string that is added to transition when the criteria is saved
Styling is similar to CDS-A-T but most of the functionality for element selection is there

Drawbacks:

Cannot edit a criteria after it has been saved. We currently can't tell the difference between a criteria that we've built and a criteria that was imported. This should change after the criteria model update.
All built criteria is automatically added to criteria list for now.

Looks good! One thing I notice is that if you collapse the sidebar while you are building the criteria, it seems to de-sync, so when you re-open the sidebar it loses the "currently building" state. Though it seems to reconnect when you change something on the builder side

When you are building the criteria if you click the button in the top right to view the pathway and go back you lose progress.
If you have an observation with 1 node and click build criteria the sidebar shows that you are currently building criteria. There seems to be an issue if there are 2+ nodes and you click build criteria on any of them. The sidebar does not show that the criteria it is being built and this puts the build criteria into a state where you cannot cancel or complete building that criteria.

@dehall @mdube7 all comments should be addressed now!

I just tried changing one criteria in the HER2+ pathway to "gender = male" and I'm getting a result I wouldn't have expected. Relevant section is below, full version is attached:
Early Stage HER2+ (Draft) (3).json.txt
    "NodeStatus": {
      "label": "Node Status",
      "transitions": [
        {
          "transition": "TumorSize",
          "condition": {
            "description": "male_criteria_display",
            "cql": "dqvhWd6BND"
          }
        },

Specifically that "cql": "dqvhWd6BND" is a little strange and doesn't seem to reference anything else. I would have expected something like Patient.gender.value = 'male' here. I haven't dug closely into the code to figure out where this is getting written. That said though I do see the ELM contains relevant pieces for gender=male

One last thing - this will need to be rebased since the "export to CPG" feature just got merged in. Can you check if the CQL generated by this builder gets put in the right place when a pathway is exported to CPG? It would be in an applicability statement for an action on a PlanDefinition (or, just ping me when you rebase and I'll check) I expect it will work correctly without further changes but want to confirm


Ell-weighting

Allow for the computation of pseudo-C_ells where the underlying true spectrum is assumed to be constant in each bandpower bin when multiplied by an ell-dependent factor f_ell.
One typical example of this is f_ell = ell*(ell+1)/2/pi. This is useful when you have steep spectra.

Solved by #47


数据库升级的问题 从3.6.4升级到3.8时报的错

android.database.sqlite.SQLiteException: no such column: DownloadEntity.taskType (code 1): , while compiling: SELECT DownloadGroupEntity.rowid AS prowid,DownloadGroupEntity.completeTime AS pcompleteTime,DownloadGroupEntity.convertFileSize AS pconvertFileSize,DownloadGroupEntity.currentProgress AS pcurrentProgress,DownloadGroupEntity.fileSize AS pfileSize,DownloadGroupEntity.isComplete AS pisComplete,DownloadGroupEntity.percent AS ppercent,DownloadGroupEntity.state AS pstate,DownloadGroupEntity.stopTime AS pstopTime,DownloadGroupEntity.str AS pstr,DownloadGroupEntity.alias AS palias,DownloadGroupEntity.dirPath AS pdirPath,DownloadGroupEntity.groupHash AS pgroupHash,DownloadGroupEntity.urls AS purls,DownloadEntity.rowid AS crowid,DownloadEntity.completeTime AS ccompleteTime,DownloadEntity.convertFileSize AS cconvertFileSize,DownloadEntity.currentProgress AS ccurrentProgress,DownloadEntity.fileSize AS cfileSize,DownloadEntity.isComplete AS cisComplete,DownloadEntity.percent AS cpercent,DownloadEntity.state AS cstate,DownloadEntity.stopTime AS cstopTime,DownloadEntity.str AS cstr,DownloadEntity.fileName AS cfileName,DownloadEntity.isGroupChild AS cisGroupChild,DownloadEntity.isRedirect AS cisRedirect,DownloadEntity.redirectUrl AS credirectUrl,DownloadEntity.taskType AS ctaskType,DownloadEntity.url AS curl,DownloadEntity.disposition AS cdisposition,DownloadEntity.downloadPath AS cdownloadPath,DownloadEntity.groupHash AS cgroupHash,DownloadEntity.md5Code AS cmd5Code,DownloadEntity.serverFileName AS cserverFileName FROM DownloadGroupEntity INNER JOIN DownloadEntity ON DownloadGroupEntity.groupHash = DownloadEntity.groupHash WHERE DownloadGroupEntity.dirPath='%2Fstorage%2Femulated%2F0%2Fsantaidownload'

Aria.download(DevicesSoftUpdateFragment.this)
.loadGroup(groupUrls)     //读取下载地址
.ignoreFilePathOccupy()
.setDirPath(Environment.getExternalStorageDirectory().getAbsolutePath()
+ "/santaidownload")
.unknownSize()
.setSubFileName(subFileNames)
.create();

数据库文件AndroidAria.db这个db文件能否提供下？qq群：524329160

使用3.8.3_beta_1看看

根据群友提供的数据库，已经重现该问题，请使用3.8.3_beta_5版本


I am not  a developer so sometime struggle with troubleshooting

I am trying to roll up from campaign member to a related Lookup Object (enrolment)
Get this error message when trying to deploy the trigger
dlrs_CampaignMemberTest.testTrigger System.DmlException: Insert failed. First exception on row 0; first error: MALFORMED_ID, Invalid campaign id: null: [CampaignId] (dlrs) Class.dlrs_CampaignMemberTest.testTrigger: line 10, column 1
Any suggestions what I should be looking for?

Have just tested in a sandbox and rollup works there but not in production

Actually the test on campaignmember test failed in saandbox

The generated Apex test by the tool is pretty dumb, in most cases its been fine, but i now see an upturn in cases where it needs more sophstication, unfortunatly the tool itself cannot figure out what code to write on its own. What it can do is make it easier for a developer or someone more technical to give you a snipet of code to give to the rollup tool that it injects that will fullfil these type of requirements. In your case it looks like the CampaignMember child object needs the parent Id. I've got already an enhancement to offer this kind of customisation over the generated test marked here, but i'll leave this one open as a reminder of a use case to test with whatever enhancement feature is produced. In the meantime you will need to get a developer to help you with the generated test. I'll post a blog post in the next few days to outline these types of problems, solutions today, and solutions in the pipeline. Sorry in the meantime for this.
POSSIBLE FIX NOTE: One option in this case actually might be to auto generate fake Id's for relationship fields?

I've recently written up some shared details on the code coverage issue described in this case, please check the details here and comment at the bottom of the wiki page.

Many thanks
Will work through that later today
Regards
Greg Devine
+64 274 338 463 (+64 274 DEVINE)
<EMAIL_ADDRESS>Manukau Road Consulting
Using our Past and our Present to Build our Future
www.manukauroad.com http://www.manukauroad.com
On 2 July 2015 at 06:57, Andrew Fawcett<EMAIL_ADDRESS>wrote:

I've recently written up some shared details on the code coverage
https://github.com/afawcett/declarative-lookup-rollup-summaries/wiki/Challenges-with-Code-Coverage
issue described in this case, please check the details here and comment at
the bottom of the wiki page.
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-117795384
.

Thanks
Working now
Took me a little bit longer than it would have if I was a developer - but
there now.
Once again a  fantastic product - and I'll know where to look and what to
do next time.
Regards
Greg Devine
+64 274 338 463 (+64 274 DEVINE)
<EMAIL_ADDRESS>Manukau Road Consulting
Using our Past and our Present to Build our Future
www.manukauroad.com http://www.manukauroad.com
On 2 July 2015 at 07:56, Greg Devine<EMAIL_ADDRESS>wrote:

Many thanks
Will work through that later today
Regards
Greg Devine
+64 274 338 463 (+64 274 DEVINE)
<EMAIL_ADDRESS>Manukau Road Consulting
Using our Past and our Present to Build our Future
www.manukauroad.com http://www.manukauroad.com
On 2 July 2015 at 06:57, Andrew Fawcett<EMAIL_ADDRESS>wrote:

I've recently written up some shared details on the code coverage
https://github.com/afawcett/declarative-lookup-rollup-summaries/wiki/Challenges-with-Code-Coverage
issue described in this case, please check the details here and comment at
the bottom of the wiki page.
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-117795384
.

Excellent! As i said in the Wiki hopefully a future version can take some of the tooling pain out of it, if not the coding bit for these such use cases.

Hey Greg, can you pls explain what you did? Facing the same issue here. thanks

As I said I'm not a  developer - so what i did may have been
inelegant/incorrect - but it worked.
I Added some extra items to the terst class. - It was on campaign  Members
so I added "create a contact" - to the test class which is required for a
Campaign Member
Regards
Greg Devine
+64 274 338 463 (+64 274 DEVINE)
<EMAIL_ADDRESS>Manukau Road Consulting
Using our Past and our Present to Build our Future
www.manukauroad.com http://www.manukauroad.com
On 14 July 2015 at 11:28, Rnatik<EMAIL_ADDRESS>wrote:

Hey Greg, can you pls explain what you did? Facing the same issue here.
thanks
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-121089754
.

Would you mind sharing @GregDevine the code here for future users with the issue? It's OK if not.

@GregDevine looks like we've got another user struggling with CampaignMember are you able to paste a snippet of your test code here please? No worries if not.

Will do
On 30/08/2015 7:40 PM, "Andrew Fawcett"<EMAIL_ADDRESS>wrote:

@GregDevine https://github.com/GregDevine looks like we've got another
user struggling with CampaignMember are you able to paste a snippet of your
test code here please? No worries if not.
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-136095298
.

No idea if its "robust" - was my first ever test class
that wan't just "copied from" a google serach
/**

Auto Generated and Deployed by the Declarative Lookup Rollup
Summaries Tool package (dlrs)
**/
@IsTest
private class dlrs_CampaignMemberTest
{
private static testmethod void testTrigger()
{Campaign c=new Campaign(Name='Test');
insert c;
Contact con=new Contact(Lastname='fred');
insert con;
 // Force the dlrs_CampaignMemberTrigger to be invoked, fails

the test if org config or other Apex code prevents this.
SavePoint sp = Database.setSavepoint();
dlrs.RollupService.testHandler(
new CampaignMember(campaignid=c.id, Contactid=con.id));
Database.rollback(sp);
}
}
Regards
Greg Devine
+64 274 338 463 (+64 274 DEVINE)
<EMAIL_ADDRESS>Manukau Road Consulting
Using our Past and our Present to Build our Future
www.manukauroad.com http://www.manukauroad.com
On 30 August 2015 at 19:40, Andrew Fawcett<EMAIL_ADDRESS>wrote:

@GregDevine https://github.com/GregDevine looks like we've got another
user struggling with CampaignMember are you able to paste a snippet of your
test code here please? No worries if not.
—
Reply to this email directly or view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-136095298
.

Thanks for adding your code, @GregDevine - did you just copy the whole thing into Test Code field?  I am still getting errors, now about things like setting variables to private or test...
/**

Auto Generated and Deployed by the Declarative Lookup Rollup
Summaries Tool package (dlrs)
**/
@IsTest
private class dlrs_CampaignMemberTest
{
private static testmethod void testTrigger()
{Campaign c=new Campaign(Name='Test');
insert c;
Contact con=new Contact(Lastname='fred');
insert con;
 // Force the dlrs_CampaignMemberTrigger to be invoked, fails

the test if org config or other Apex code prevents this.
SavePoint sp = Database.setSavepoint();
dlrs.RollupService.testHandler(
new CampaignMember(campaignid=c.id, Contactid=con.id));
Database.rollback(sp);
}
}

Hi @JenNelsonChicago
Just copy this bit... you don't need the See All Data tickbox for this...
Campaign c=new Campaign(Name='Test');
insert c;
Contact con=new Contact(Lastname='fred');
insert con;

// Force the dlrs_CampaignMemberTrigger to be invoked, fails the test if org config or other Apex code prevents this.
SavePoint sp = Database.setSavepoint();
dlrs.RollupService.testHandler(
    new CampaignMember(campaignid=c.id, Contactid=con.id));
Database.rollback(sp);

@GregDevine thanks btw! :+1:

Sorry for the dumb question but where do I paste the test code?  JenNelsonChicago references a Test Code field.  Where do I find that?
Thanks!

Take a look at this https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/307

Hi @afawcett - I tried the test code you gave to Jen, and I'm still getting the same error.  What am I missing?
I was glad to see that this is already something others have experienced and figured out a workaround to manage (even if that workaround isn't working for me yet!).
Jodi

You need to remove some of the lines. It was confusing for me as well. can
you email me in an hour and I will send you the exact code to use?
On Jun 2, 2016 10:14 AM, "JodiNA"<EMAIL_ADDRESS>wrote:

Hi @afawcett https://github.com/afawcett - I tried the test code you
gave to Jen, and I'm still getting the same error. What am I missing?
I was glad to see that this is already something others have experienced
and figured out a workaround to manage (even if that workaround isn't
working for me yet!).
Jodi
[image: dlrs_rollup]
https://cloud.githubusercontent.com/assets/8515331/15747888/b78d5942-28aa-11e6-827a-374bf6fb9582.jpg
[image: dlrs_error]
https://cloud.githubusercontent.com/assets/8515331/15747890/b9a19ad6-28aa-11e6-9c19-2952e83cfddf.jpg
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-223304525,
or mute the thread
https://github.com/notifications/unsubscribe/AMtMPfiQF5Sk-l6Y3mBOee5HsNOv8OILks5qHuU_gaJpZM4FN0qZ
.

@Rnatik - I actually deleted my post because I realized that it was a validation problem from within my instance, not an issue with the code Andy provided.  THANK YOU for responding, though!
I was able to add an additional variable assignment to the test code, and now it works.
Again, very appreciative to have this thread with the test code solution.  Thanks @afawcett and everyone else!

Thanks @JodiNA, and btw i keep running up to that NPSP issue and runny away, its really hard to debug, i think i'm going to have to deploy both NPSP and DLRS into an org unmanaged so i can see all the code and get detailed debug logs. Sorry i feel bad its still hanging around that issue. It really requires a day to debug. I'm actually wondering if I could hack it through with an NPSP dev together at an MVP event or something?

@afawcett - regarding the NPSP issue, I'm not exactly sure where to point you with this one.  Judi Sohn or David Habib might be people to reach out to.

Thanks, are either of them close or in town during the MVP LEX event do you know?

No idea, sorry!
On Fri, Jun 17, 2016 at 1:32 PM, Andrew Fawcett<EMAIL_ADDRESS>wrote:

Thanks, are either of them close or in town during the MVP LEX event do
you know?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197#issuecomment-226831828,
or mute the thread
https://github.com/notifications/unsubscribe/AIHvA6a3zZAIy7J4vr_YzB1exDSSJ6Tlks5qMtokgaJpZM4FN0qZ
.

--
Jodi Nemser-Abrahams
Information & Data Manager
Keshet
284 Amory Street
Boston, MA 02130
617.524.9227x111
Web: www.keshetonline.org
Facebook: www.facebook.com/KeshetGLBTJews
Twitter: @KeshetGLBTJews https://twitter.com/KeshetGLBTJews
Blog: www.myjewishlearning.com/category/keshet/
Join us for Keshet Cabaret
http://www.keshetonline.org/event/keshetcabaret2016/ on Thursday, June
23rd*!* Tickets are only $36 for a raucous, fun, and fabulous night
celebrating Keshet’s work, Pride Month, and our community in Boston!
Celebrate Pride Month http://www.keshetonline.org/pride/ with Keshet!
Click here https://www.keshetonline.org/pride/commitment/ to share your
organization's commitment to marking the month!
Stand up for transgender rights. Sign Keshet's petition
https://www.keshetonline.org/work/petition-in-support-of-full-transgender-rights-in-massachusetts/support-transgender-rights-in-ma/
calling
Massachusetts legislators to support “An Act Relative to Transgender
Anti-Discrimination."

I'm running into this issue but on a Custom Object. I tried using the Campaign Member code and tweaking but I'm not doing it right. What is the root cause of this issue so I can understand what I'm trying to fix? Is it something that is required for the creation of one of the records that throws the error during the test class? THANK YOU!

I am getting the same error. Not sure what is applicable to my case from the above comments and solutions.
Heres my Error:
dlrs_CampaignMemberTest.testTrigger System.DmlException: Insert failed. First exception on row 0; first error: MALFORMED_ID, Invalid campaign id: null: [CampaignId] Class.dlrs.RollupService.testHandler: line 282, column 1 Class.dlrs_CampaignMemberTest.testTrigger: line 11, column 1
Here's my test class:
trigger dlrs_CampaignMemberTrigger on CampaignMember
(before delete, before insert, before update, after delete, after insert, after undelete, after update)
{
dlrs.RollupService.triggerHandler(CampaignMember.SObjectType);
}
@IsTest
private class dlrs_CampaignMemberTest
{
@IsTest
private static void testTrigger()
{
// Force the dlrs_CampaignMemberTrigger to be invoked, fails the test if org config or other Apex code prevents this.
dlrs.RollupService.testHandler(new CampaignMember());
}
}
No active validation rules on parent or child objects. There are two existing managed triggers on the Campaign object, which shouldn't affect things since this is a Campaign Member trigger. I am wondering whether this code snippet copied from above will fix my coverage:
Campaign c=new Campaign(Name='Test');
insert c;
Contact con=new Contact(Lastname='fred');
insert con;
Where do I put it, in the existing class? Thanks so much. I have never had this issue with a rollup and have yet to write a single line of code, so grateful for whatever light others can shed here.

you are failing to have an Id MALFORMED_ID, Invalid campaign id: null: [CampaignId]  . But if you are not a developer, why not just let DLRS deploy the Child Trigger for you? It should come with test coverage and not require you to write any code.

The test is failing. I have 0% coverage. I didn’t think I SHOULD deploy under those conditions….
From: Jim Bartek<EMAIL_ADDRESS>Sent: Tuesday, May 21, 2019 2:46 PM
To: afawcett/declarative-lookup-rollup-summaries<EMAIL_ADDRESS>Cc: Ashlynn Sylvain<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [afawcett/declarative-lookup-rollup-summaries] I am not a developer so sometime struggle with troubleshooting (#197)
you are failing to have an Id MALFORMED_ID, Invalid campaign id: null: [CampaignId] . But if you are not a developer, why not just let DLRS deploy the Child Trigger for you? It should come with test coverage and not require you to write any code.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/afawcett/declarative-lookup-rollup-summaries/issues/197?email_source=notifications&email_token=AJHQZJLF32B64LGBRTZX7KDPWQ7NRA5CNFSM4BJXJKM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV42JUI#issuecomment-494511313, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJHQZJPROBT55S3G6M7WHY3PWQ7NRANCNFSM4BJXJKMQ.


Updated buttons of footer

Added relevant html anchor tags to different sections

Resolve this conflict & raise PR again.
Make sure to pull all the changes before pushing anything


Replace setup.py with setup.cfg

New projects are advised to avoid setup.py configurations (beyond the minimal stub) when custom scripting during the build is not necessary as documented in https://setuptools.pypa.io/en/latest/userguide/quickstart.html

The tests are failing because the following test expects that dir on PYTHONPATH!
Can we move it under tests @denimalpaca ?
https://github.com/astronomer/airflow-provider-great-expectations/blob/main/tests/operators/test_great_expectations.py#L526-L531

Sure, if it'll fix the testing it should be fine. I don't think it'll mess with anything -- @talagluck do you have an opinion here?

I don't have an opinion here - if this is in line with other providers, then it feels reasonable to change.

I don't have an opinion here - if this is in line with other providers, then it feels reasonable to change.

All those files in the /include folder are just for tests, right?

they're used for the example DAG, too, so maybe they can be copied over to the tests/ dir and kept in include/ as well. Then the example DAG paths don't have to change.


Generate custom colors based on RGB codes?

Is it possible to create a color variable that references a column in the CSV containing RGB codes (e.g. #B4FF00) to use the color specified in the CSV?

not directly no, because of way Scribus handles colors: you need to create a color swatch and import it in scribus... then use these colors names into your CSV variable.
Of course there is nothing to prevent you from creating a swatch of colors which names are their RGB code. I thinkg you can import Gimp color palettes as well (maybe the easiest to create a list of your colors with a script or spreadsheet), and the colors of an imported SVG objects too, if I remember correctly.
Some swatches already included in Scribus are: https://github.com/scribusproject/scribus/tree/4ccc75ee9899f5a4c27178b43340a8428029fbe4/resources/swatches


[Proposition] Belongs To Through multiple models

What if we need to acces to a related model through multiple models (a recursive thing)

@sn0opr Can you suggest any example?

@znck
First of all I would like to thank you about this implementation, I've been searching for it for a long time.
The idea is to access to a more deeper (or unlimited deep) related model Example:
Person belongs to a City
City belongs to a Country
Country belongs to Continent
With the current BelongsToThrough method we can only access to the Country of a Person, but we can't get the Continent of a Person.
So I suggest to do something like this
//Person Model class
public function continent()
{
    return $this->belongsToThrough(Continent::class, [City::class, Country::class]);
}

The second parameter is an array that contains the path to get to the needed relation, it can be more than two...


HEADER: modify search component

Search component should looks like :

In Current implementation :

Change component width, font color and add search icon in beginning

how to assign?

done https://github.com/hospitalrun-ua/frontend/pull/62

Merged
https://github.com/hospitalrun-ua/frontend/pull/62
https://github.com/hospitalrun-ua/frontend/pull/56


⚠ ClamAV has degraded performance

In 61568ae, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 137 ms

Resolved: ClamAV performance has improved in b9703be.


[PT]The error happens when the link of vSphere Cluster Settings in VMware Service Controller is clicked.

[Summary]
The error happens when the link of vSphere Cluster Settings in VMware Service Controller is clicked.
[Product name and version]
V16.1 GA2
[Client IDE]
OS       : Windows7 Pro SP1
Browser  : Google Chrome(52.0.2743.116 m)
[Reproduce frequency]
always
[Bug Classification]
Short Name:PB-InvFun
Fundamental Function:No
Workaround:No
Severity:Minor
[How to reproduce]

Login to VMware Service Controller
Click "vSphere Cluster Settings" link

[Expected result]
The result is showed correctly.
[Observed result]
The error happens.
[Detail]
The error happens when the link of vSphere Cluster Settings in VMware Service Controller is clicked.
However we don’t understand how it works. The specification is not described in manual.
Is the link necessary to setup VMware?
[Message and logs]
APP VMware Controller Configuration
The following error occurred during the last operation:
Status Code: 500
Request-URI: /oscm-app-vmware/vcenter.xhtml
Servlet name: Faces Servlet
Exception: javax.servlet.ServletException

same as https://github.com/servicecatalog/development/issues/244


Fixes 159: Update validation API to support editing

This adds the ability for the validation API to EXCLUDE the sent UUIDs from its name/url uniqueness check, thus allowing the ability to use this API to validate against within the repository edit screen.
This solves the problem of false positive (where the uniqueness check would fail) when validating a repo effectively against itself or others in the edit group.
An example:
Previously this:
[
   {
        "name": "google",
        "url": "https://www.google.com"
        // "uuid": "a68feaa3-9746-4719-8e33-3ff4688fed85",
    },
    {
        "name": "apple",
        "url": "https://apple.com",
        //  "uuid": "9d6fb177-ff10-41fc-81d4-ea12ae963042",
    }
]

would result in:
[
    {
        "name": {
            "skipped": false,
            "valid": false,
            "error": "A repository with the name 'google' already exists."
        },
        "url": {
            "skipped": false,
            "valid": false,
            "error": "A repository with the URL 'https://www.google.com' already exists.",
            "http_code": 0,
            "metadata_present": false
        }
    },
    {
        "name": {
            "skipped": false,
            "valid": false,
            "error": "A repository with the name 'apple' already exists."
        },
        "url": {
            "skipped": false,
            "valid": false,
            "error": "A repository with the URL 'https://apple.com' already exists.",
            "http_code": 0,
            "metadata_present": false
        }
    }
]

Now well editing the above targeted repos, by adding in the commented UUIDs to exclude, we get the following:
[
    {
        "name": {
            "skipped": false,
            "valid": true,
            "error": ""
        },
        "url": {
            "skipped": false,
            "valid": true,
            "error": "",
            "http_code": 200,
            "metadata_present": true
        }
    },
    {
        "name": {
            "skipped": false,
            "valid": true,
            "error": ""
        },
        "url": {
            "skipped": false,
            "valid": true,
            "error": "",
            "http_code": 200,
            "metadata_present": true
        }
    }
]

Which is the expected outcome for validating when editing.

https://issues.redhat.com/browse/HMSCONTENT-159

can you add tests to dao/repository_test.go and and handler/repository_parameters_test.go, that cover the cases with uuid?

I may need some help with the handler/repository_parameters_test.go, I don't really get what that is supposed to be doing?


DATABASE_QUERIES_DEBUG true error

When I ran php artisan migrate I received that exception. If I change DATABASE_QUERIES_DEBUG to false the error does not appear
[ErrorException]
Missing argument 2 for App\Port\Provider\Providers\PortServiceProvider::App\Port\Provider\Traits{closure}()

Hi, I assume you upgrading after using an older version, that's why you are facing this error.
I've added a second parameter to the function debugDatabaseQueries. It looks like this now:
    public function debugDatabaseQueries($log = true, $terminal = false)
    {
        if (Config::get('database.query_debugging')) {

            DB::listen(function ($query, $bindings, $time, $connection) use ($terminal, $log) {
                $fullQuery = vsprintf(str_replace(['%', '?'], ['%%', '%s'], $query), $bindings);

                $text = $connection . ' (' . $time . '): ' . $fullQuery;

                if ($terminal) {
                    dump($text);
                }

                if ($log) {
                    Log::info($text);
                }
            });
        }
    }

This function exist in app/Port/Provider/Traits/PortServiceProviderTrait.php feel free to update it manually.
And the function is being used by app/Port/Provider/Traits/PortServiceProviderTrait.php like this $this->debugDatabaseQueries(true, true);
Let me know if you need any help.


Allow users to create/save a receipt (betaalbewijs)

For future reference, images are only shown as base64. External images and certain CSS rules will NOT be rendered using the current system


Check for cyclic inheritance when adding a global script class

This makes add_global_class() fail if a cyclic inheritance is detected.
Fixes #25339 and #32113

CC @vnen

Thanks!

This doesn't seem sufficient, see https://github.com/godotengine/godot/issues/9609#issuecomment-558515038


Word wrap

When displaying the following text in an edit control of the size in the screenshot with wordwrap, it does not display properly. Cursor navigation is also affected. See screenshot.
Text below:
The "submit-success" and "submit-error" AMP attribute markers must only be used on direct children of a "form" element. Visit https://www.ampproject.org/docs/reference/components/amp-form for more information.
---
1 message for line 404

Fixed.


required validation rule fails for entity property casted as bool when equals false||0

Any update on this PR?

@lonnieezell this should be closed in light of the Entity refactor.

Handled in the Entity refactor


Downgrading PlatformAbstractions dependency version in DotnetDispatcher

Follow-up to https://github.com/aspnet/RazorTooling/pull/107
@NTaylorMullen

⌚

🆙 📅

🆙 📅

:shipit:

:shipit:


feat: expose indexes information

Exposing the indexes helps creating UIs that show a more detailed "progress bar".
Currently the original array is returned, so someone could manipulate it from the outside. I'm not sure if this is an issue, otherwise a copy could be returned.

Exposing the indexes helps creating UIs that show a more detailed "progress bar".
Currently the original array is returned, so someone could manipulate it from the outside. I'm not sure if this is an issue, otherwise a copy could be returned.

I think it's better if they were copies if only to prevent accidental modifications.

Done.

@AndreasGassmann sorry for the delay; looks good, I'll merge it


better reaction detection

Various improvements in macro support.

Prevent users from writing go { case x@a(y) => ...}.
Detect whether molecules are emitted under an if expression.

Current coverage is 99.87% (diff: 95.83%)

Merging #90 into master will decrease coverage by 0.12%

@@           master        #90   diff @@
========================================
  Files          13         13
  Lines         827        831     +4
  Methods       726        735     +9
  Messages        0          0
  Branches      101         96     -5
========================================
+ Hits          827        830     +3
- Misses          0          1     +1
  Partials        0          0

Powered by Codecov. Last update 97984cf...14bb462


UE pass

Clarify and re-order a few things, update links.

Looks good :shipit:

Could you pull this please?


Add support for radio browser

Add support for https://www.radio-browser.info/

great idea, I haven't used radio-browser yet, but I'll look into how to integrate it into the app


How to use the Graph2Seq model?

❓ Questions and Help
Hi!
I'm working on a project where I want to feed custom dataset to the Graph2Seq model. Before I do that, I just want to experiment a little bit with a super simple graph data (one graph of 4 nodes with 4 edges) to make sure I understand the workflow. My understanding is that I need to convert my graph to a DataItem -> DataSet -> which can then be fed to a model. I am a little bit stuck on the step from DataSet to fitting Graph2Seq model.
Thanks!

This is what I've done so far:
I created a graph g and added some nodes  and some edges. I then constructed a Text2TextDataItem where I used the extract method. I changed the implementation of extract() so that it takes in my graph. Once I have the input and output tokens from the extract() method, I constructed a Text2TextDataSet. Here, I used the vectorization() and collate_fn() methods on my previous outputs.
I am following this:https://graph4ai.github.io/graph4nlp/guide/dataset/customize.html
What should my next step be after customizing batching if I want to feed my simple graph to Graph2Seq model?

After finishing vectorization, you can feed the batch graphdata to Graph2Seq model.
An example is: https://github.com/graph4ai/graph4nlp/blob/7690b54eff4194ea0627be82a5f6316e19caddfa/examples/pytorch/semantic_parsing/graph2seq/main.py#L227.
If you meet some bugs in this step and don't know the solution, you can attach your codes.

The issue is closed due to inactivity. Please reopen it when necessary.


UBX MON HW

Can I obtain data from HW which is a child message of MON?

Can I obtain data from HW which is a child message of MON?

You can, as soon as you develop corresponding class :)


[Feature] Request a feature with something

Version information

Device: honor 8X
OS: ANDROID 10
Package Version:  v3.0.2
Flutter Version:  v2.10.3

can you support textDelegates in the Arabic language?

/cc @yanivshaked

Before an implementation from the plugin, you can implement your own as a workaround.

yes, I'll do that.
Thanks.


Add nomic embedding model and add model feature filtering

Add Nomic Embedding model:

nomic-embed-text is a large context length text encoder that surpasses OpenAI text-embedding-ada-002 and text-embedding-3-small performance on short and long context tasks.

See: https://ollama.com/library/nomic-embed-text
Also: Add query string filtering in the model listing endpoint to avoid OpenWebUI adding embedding models in the dropdown list of chat-able models.
// Example (default):  /v1/models
// Example (single):   /v1/models?feature=TextEmbedding
// Example (multiple): /v1/models?feature=TextGeneration&feature=TextEmbedding

So will there be a /v1/embeddings endpoint that works like this?
curl http://kubeai-endpoint/v1/embeddings \
  -H "Content-Type: application/json" \
  -d '{
    "input": "Text string to create embeddings for",
    "model": "my-model"
  }'

Yes, there already is one. NOTE: KubeAI serves the OpenAI compatible endpoints under the /openai/ prefix.


SparseRLE thaw

this PR allows an insertion into SparseRLE in sorted order w/ fastfinch mode.

Oh nice, yes this is great. Thanks!

At least one test please!


Launch on Emulator

I've wrote a sample then whenever i try to launch it on AVD gradle builds project Successfully but nothing shows up on Emulator
compose = 1.0.0-alpha02
kotlin = 1.4.0
gradle plugin = 4.2.0-alpha10
gradle = 6.6.1

This doesn't seem like an issue with this project. Please can you ask on Slack or StackOverflow?


Add a way to backreference texts in localization files

Alot of the quest text apear multiple times. There could be a way to backreference quest texts like:
EventManiacSample1.text,<i>The maniac rips out some of your hair.</i>,,,,,,,,,
EventManiacSample2.text,{quest:EventManiacSample1.text},,,,,,,,,

It could be utilized to remove more clutter like:
EventManiacSample3.text,{quest:EventManiacSample1.text}\n\nDraw two face up horror.,,,,,,,,,

This already works!  the notation is {qst:<key>}, you can see it used in the new scenario Exotic Material.
Another advantage is text then only needs to be translated in one place.
Reopen if I have misunderstood or this doesn't work for you.


Use PlaySRG image service

Issue type
Feature request
Description
Integration Layer product has deprecated endpoints, which will be removed during migration to the new major version (named SAM): Services to transform images.
In addition:

SRF business unit image service will remove the scaling support in 2023 Q4.
RTS business unit image service does not work as expected with PlaySRG image service, regarding the aspect ratio given within the url. Will be fix in 2023 Q3.

Main new image service to use is the PlaySRG image service.
Environment information

Images are provided by SRGDataProvider.
In Player, SRGLetterbox uses SRGDataProvider as well.

Application version: Any
iOS / tvOS version: Any
Device: Any

Moving all in one time seems to not doable, regarding dependencies.
https://github.com/SRGSSR/srgdataprovider-apple/pull/44

Open question:
With PlaySRG Service, the image format could be asked.
Here are an example of an SRF audio thumbnail requested:
Service | Image url | content-type | content-length | Usage |   |
-- | -- | -- | -- | -- | -- | --
BU | https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png/scale/width/320 | image/png | 133393 | Current request |   |
PlaySRG png | https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=png&width=320 | image/png | 135647 | Future request, url is a png |   |
PlaySRG jpg | https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=jpg&width=320 | image/jpeg | 8174 |   |   |
PlaySRG webp | https://il.srgssr.ch/images/?imageUrl=https://ws.srf.ch/asset/image/audio/aa35a39d-85cc-4dc4-bf54-8d744cd6304f/EPISODE_IMAGE/1683198311.png&format=webp&width=320 | image/webp | 7718 |   |   |
Asking png only for channel logo or custom button for the UI, and use jpg for all content image?
We should ask designers, if HeroStage images or highlighted images are allowed to be transparence (and work with the page background).

The PlaySRG image services not fit well with:

RTS CMS image service: returns raw image which many various image ratios (06.2023) (Internal Jira ticket).
IL with vector images. imageUrl from SRGChannel and SRGProgram returns blurred scalded image (mid 07.2023)  (Internal Jira ticket).

RTS CMS image service is still used instead of using PlaySRG image service, in SRGDataProvider: https://github.com/SRGSSR/srgdataprovider-apple/pull/44
IL with vector images. imageUrl from SRGChannel and SRGProgram. Workaround to get channel rawImageUrl instead: in ProgramViewModel.

The SRGProgram's fallback imageUrl can't be used in Play SRG image service (blurred image). https://github.com/SRGSSR/srgdataprovider-apple/pull/49 ignore those image urls.
#352 introduces a fallback on the related channel raw image url.


[bug] throw error r.removeListener is not a function when trustwallet disconnect

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
1.0.1
wagmi Version
1.1.1
Current Behavior
trustwallet disconnect throw error r.removeListener
Expected Behavior
disconnect wallet successfully.
Steps To Reproduce

click disconnect

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
The website can also be reproduced:

@ybgbob Thanks for reporting. Have communicated this to the Trust Wallet team as this behavior only recently began appearing and likely resulted from a change to the Trust provider, but haven't had much luck working out a solution with that team yet. Marking as duplicate in favor of the previous #1259 report.

@ybgbob 1.0.5 is now available with a fix for this issue.


Blend TextureFX doesn't work unless all textures are connencted

reported by @michael-burk:

the mask should be optional.  it is another functionality to mask the texture. All I wanna do is blend :)
Also, the mask doesn't behave as expected at all.

The main point is, that the blend should work with just two connected textures.
The ones, that are supposed to be blended.
Everything else should be optional.
As a mask, I would also expect a kind of "multiply" behaviour. Maybe being able to choos luma, color channel, or else.
Also the "output texture" pin is not clear to me.

I just checked and the node works without having to connect the mask. Simply changing the opacity and it blends accordingly.
@michael-burk Most of the "Output Texture" pins now have a help text which explains what it's doing:

The Blend node doesn't have that help text because it's a patched node. So I'd argue that's a different issue, would be nice if the system would forward the help text in such a case - something like if all connected pins have the same name and the same help use it.
Regarding the behavior of the mask please open a new issue.


Update SAR manual with specific steps to follow

https://trello.com/c/GZqSmo0H/1030-update-sar-requests-manual
Previously this was quite open-ended.

Note: we're still trying to work out if there are more specifics steps to follow with regard to licensing.


Move World trait and related into evm_arithmetization crate

No functionality change, just moving things around for type2 integration.
@LindaGuiga Note that I haven't moved all the modules into evm_arithmetization as you had done initially, not sure whether this was for simplicity or because I overlooked something.

@LindaGuiga Note that I haven't moved all the modules into evm_arithmetization as you had done initially, not sure whether this was for simplicity or because I overlooked something.
When I had done the change, I just thought it would make more sense to have world.rs and the related methods in the same crate. But I'm not at all opposed to only moving world.rs and tries.rs! Especially since that means the tests remain in trace_decoder.


Revert "Upload Assemblies (from reference KBase Genomes) now does handle id"

Reverts kbase/data_api#137.
I'm very sorry, I didn't notice till I already merged that this PR was against master.  Jason, can you please redo this PR against the develop branch?

Current coverage is 59.84%

Merging #139 into master will not affect coverage as of 88a4843

@@            master    #139   diff @@
======================================
  Files           15      15
  Stmts         2072    2072
  Branches         0       0
  Methods          0       0
======================================
  Hit           1240    1240
  Partial          0       0
  Missed         832     832

Review entire Coverage Diff as of 88a4843

Powered by Codecov. Updated on successful CI builds.


AppCheck - no MainActivity.java file in project as per install instructions

Discussed in https://github.com/FirebaseExtended/flutterfire/discussions/6467

Originally posted by Zelfapp June 24, 2021
Install instructions mention a MainActivity.java file to update. However, my Flutter project has no MainActivity.java. The instructions need to be updated for how to handle this situation. Where do I put the MainActivity.java file if no file exists or do I update MainActivity.kt that does exist, and if so what is the code for that?

I've tried running flutter create . as many SO posts have suggested, but this does not create a MainActivity.java file in the project.
The contents of my android/app/src/main/kotlin/com/mysite/myapp/MainActivity.kt file:
package com.mysite.myapp

import io.flutter.embedding.android.FlutterActivity

class MainActivity: FlutterActivity() {
}

The suggested changes to MainActivity.java seem to be unconditional with respect to the kind of build.
Presumably the debug app check provider should be referenced only in debug builds not release builds? But the instructions don't address how to do this.

there needs to be a kotlin snippet in the documentation as well

Hi there, we fully accept PRs if anyone is able to produce a Kotlin sample and update the documentation. We already have an issue tracking this very problem: https://github.com/FirebaseExtended/flutterfire/issues/2311
I'll close this and suggest a thumbs up for that issue. Thanks.


docs(partition): add an overload for better typing

Description:
Just adds a new overload to partition to give more useful types, similar to the one for filter. I found myself wanting this feature, and It seemed easy enough to implement.

Thank you so much for this contribution! Looks like we need some dtslint tests to prove that the typings are indeed better.
(I'm not sure if we actually have any for this one yet, TBH)

I uh, don't know how to do that, tbh. 😅

@tech6hutch Well, if you're willing to give it a go, all you'd have to do is look at some of the files under spec-dtslint and try adding one for partition.
If you're not, just let me know, and I'll try to find time to do it.

I forgot about this - thanks for finishing it!


SolanaFi Token #8030 logo update

I'm submitting a feature request

**auto-merge error came up, so I updated logo for SolanaFi Token #8030 **

Not sure if it updated on the official Solana token list. I'm a rookie, so any help is appreciated. I really want my tokens info to reflect in Solscan, Thank you

the proper path is assets/mainnet/ADDRESS/logo.png
note how only your logo is in the wrong place: https://github.com/solana-labs/token-list/tree/3c3457db6881d13e6fc1c73b191dd47e72dabf2e/assets

Thank you for your response and help :)
On Thu, Dec 16, 2021, 11:45 AM keone @.***> wrote:

Closed #8211 https://github.com/solana-labs/token-list/issues/8211.
—
Reply to this email directly, view it on GitHub
https://github.com/solana-labs/token-list/issues/8211#event-5779684661,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW5QB5FO5ZQ52WSC2A4SNRLURIJSLANCNFSM5KDSQKLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


[feat] send json type content when call ctx.throw

Describe the feature
Some time we want our server always reponse with json type, even if it throw custom error, for such code:
ctx.throw(403, 'need right access', {
      message: JSON.stringify({code: 1234, msg: 'you dont have right permission', userId: 'xxx'}),
      expose: true
})

But koa reponse all errors with text type, we can not change it.
Checklist

[x] I have searched through GitHub issues for similar issues.
[x] I have completely read through the README and documentation.

Guess you can put a middle there to catch the error and format the response before Koa. You can pass an object to ctx.throw() as any one of the arguments except first.


[eSteem mobile ios] Not accepting suggested tag.

Describe the bug
In the editor section, i was trying to choose keypad suggested categories tag such as Photography but when i clicked on suggested tag the app got only two letters Ph.
However if type full category tag and don't choose from suggestion then it is getting properly.
To Reproduce
Steps to reproduce the behavior:

Go to the editor section of esteem mobile ios latest version.
Type some letters of the tag such as photography (Which you use frequently)
If you see the suggested tag according to you then tap on that.
See error

Expected behavior
If any user select suggested or already used tag from keypad suggestion then this app should accept all characters.
Screenshots or Video
https://youtu.be/QaNv15EbkeQ
Smartphone (please complete the following information):

Device: [ iPhone6]
OS: [ iOS12]
Version [2]

Additional context
Add any other context about the problem here.

removed suggested for ios.


Drinks move and Shaker minor edit

About the PR
Moves flasks into drinks_flasks.yml and snowflakey containers into drinks_special.yml.
Also, flask now inherits from BaseItem instead of DrinkGlassBase, allowing for the spillable component to be removed. This lets us to push more changes to the flask down the road (as I plan to do once I feel like it).
Closes #5322
Screenshots

Changelog

:cl:

tweak: Shakers are no longer breakable and do not spill contents

setting as draft as this is definitely probably definitely not how maintainers want it (and also i am shitcoder)

pull?


Refactor zipkin/protov2.go

Which problem is this PR solving?

Related to https://github.com/jaegertracing/jaeger/pull/1695#discussion_r314391550 (from previously merged PR)

Short description of the changes

Improve model/ids.go to parse []byte into SpanID/TraceID
Use model/ids.go in zipkin/protov2.go

crossdock-go test failed, i think its flaky and unrelated to this PR. Is there something we can do to fix that? so CI wouldn't break for any PRs in future


Need to modularize routes

Overview of the feature request
Congratulations Jhipster Team. It would be great if the routes could be modularized. I explain when the project grows it becomes very difficult to maintain all the routes generated by jhipster and the ones created in the app. In addition, each time the generator is used to add a new entity or modify any field, the generator duplicates even its own routes.
The idea is to create a module for the default routes that jhipster creates, which I think would be easier to keep for you and the generator and for the index to import them as well as the own routes that the developers want to incorporate.
Motivation for or Use Case
The main reason is to be able to keep apps that are extremely large, for example, a module could be created for admin routes, another for entities, and so on. This allows the jhipster-vuejs generator when adding a new entity just modify this module and not duplicate the routes. Besides that it would be easier to maintain
Example
Here is how one can organize that:
router/index.ts
import moduleRoutes1 from "./path/to/moduleRoutes1"
import moduleRoutes2 from "./path/to/moduleRoutes2"
const router = new Router({
mode: 'history',
routes: [
...moduleRoutes1,
...moduleRoutes2
//etc.
  //Note '...' here is "spread operator" and not ellipsis
]

router/moduleRoutes1
let VuePage1 = () => import(/* webpackChunkName: MyChunk / '@/path/to/VuePage1')
let VuePage2 = () => import(/ webpackChunkName: MyChunk */ '@/path/to/VuePage2')
import moduleRoutes1_1 from "./path/to/moduleRoutes1_1"
export default [
{
path: '/some/path/1',
name: 'pathName1',
component: VuePage1,
},
{
path: '/some/path/2',
name: 'pathName2',
component: VuePage2,
},
...moduleRoutes1_1 //dividing modules further if needed
]
router/moduleRoutes2
... //now it's ellipsis

The duplication of routes is indeed a problem, and it should not happened as there should be a regexp replace
About your feature request, do you have a quick example of what you have in mind ? I'd like to understand better

@pascalgrimaud
Here is how one can organize that:
router/index.ts
import moduleRoutes1 from "./path/to/moduleRoutes1"
import moduleRoutes2 from "./path/to/moduleRoutes2"

const router = new Router({
    mode: 'history',
    routes: [
      ...moduleRoutes1,
      ...moduleRoutes2
      //etc.

      //Note '...' here is "spread operator" and not ellipsis
    ]

router/moduleRoutes1
let VuePage1 = () => import(/* webpackChunkName: MyChunk */ '@/path/to/VuePage1')
let VuePage2 = () => import(/* webpackChunkName: MyChunk */ '@/path/to/VuePage2')

import moduleRoutes1_1 from "./path/to/moduleRoutes1_1"

export default [
    {
        path: '/some/path/1',
        name: 'pathName1',
        component: VuePage1,
    },
    {
        path: '/some/path/2',
        name: 'pathName2',
        component: VuePage2,
    },
    ...moduleRoutes1_1 //dividing modules further if needed
]

router/moduleRoutes2
... //now it's ellipsis
Note that moduleRoutes1 can be the default routes generated by jhipster, this allows the generator to only modify those routes and it would be easier for you and us to maintain when the app grows and needs modifications. The routes could be divided by more modules, example a module for the routes of admin, another for the routes of entities ... It can be modularized to the point that you want
You've got the idea

@yuniel-acosta : thanks !
I agree with you, the router/index.ts is too big, if we can improve it, it will be better :-)
It would be really cool if you can contribute.
As at the moment, we have few contributors in this blueprint, so your help will be really welcome

@pascalgrimaud I would like to contribute, but I need to study how the generator works and how it is programmed. They have some guide to start.

Here some steps, which can help you:

fork the project
clone your fork
add the remote upstream
try to generate locally a Vue.js project with your fork
do a minor update (change one question or prompt for example)
generate another project and check if the change is correctly applied -> so you're sure your local env works

Then, you'll be ready to start the contribute to this feature.
It's better to:

generate and modify a generated project -> project A
report the change from the generated project to the template in Vue.js blueprint
generate a new project (project B) with your fork, and check the diff between project A and project B

If you need any guidance, feel free to ask

@pascalgrimaud I would like to contribute, but I need to study how the generator works and how it is programmed. They have some guide to start.

If you have any questions or need help, feel free to ask me or @nassimerrahoui .

Hi @pascalgrimaud  and @adilabed i have problem with the blueprint in my local environment.
Where can I ask my questions about the project, do you have any slack or gitter channels that are internal to you
This is my error
 jhipster -d --blueprints vuejs
INFO! Using JHipster version installed globally
INFO! No custom **sharedOptions** found within blueprint: generator-jhipster-vuejs at /home/acosta/.nvm/versions/node/v12.16.1/lib/node_modules/generator-jhipster-vuejs
events.js:288
      throw er; // Unhandled 'error' event
      ^

TypeError: jhipsterUtils.getAllJhipsterConfig is not a function
    at new module.exports (/home/acosta/Projects/jhipster/jhipster-vuejs/generators/page/index.js:29:45)
    at Environment.instantiate (/home/acosta/Projects/jhipster/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:673:23)
    at Environment.create (/home/acosta/Projects/jhipster/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:645:19)
    at /home/acosta/Projects/jhipster/generator-jhipster/cli/cli.js:74:31
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/acosta/Projects/jhipster/generator-jhipster/cli/cli.js:62:29)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
Emitted 'error' event on Environment instance at:
    at Environment.error (/home/acosta/Projects/jhipster/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:293:12)
    at Environment.create (/home/acosta/Projects/jhipster/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:647:19)
    at /home/acosta/Projects/jhipster/generator-jhipster/cli/cli.js:74:31
    [... lines matching original stack trace ...]
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)

@yuniel-acosta : do you have a fork of generator-jhipster locally ? If it's the case, you need to use v6.10.1 tag, instead of master. It's because we remove this function for v7
Tell me if you still have problems

@pascalgrimaud  I finished.  I am doing the last tests.  What is the next step

@yuniel-acosta : open a pull request :)

@pascalgrimaud ok, pull request waiting for review


Question - Why not work with/join ngSemantic?

I was looking for a css framework for my new Angular 2.0 project and decided on Semantic UI then I looked for Angular integration and found ng-semantic-ui and ngSemantic.
I don't know the history of each project but for an outsider it looks like the two projects has the same purpose and goal, so why not join forces?

@Martin-Andersen
i personally dont know why,
but this is an angular2 native implementation of semantic-ui.
so no jquery.
while ngSemantic use jQuery.

@vazh  @Martin-Andersen  I haven't yet looked at the source code of either repositories, but "lon-yang/angular2-semantic-ui" mentioned above, seem to contain the exact same components as this one, and not much have been done on it (1 contributor, 1 branch, 0 issues++) ...  maybe a clone of this rep?
This project is certainly something I would be interested in contributing to. The reason I wouldn't use the main project (ngSemantic), is because of its dependency on jQuery, which is a no-go for me - any many others I assume.

Hey @Martin-Andersen, hey @vazh, I also would like to contribute with my team, because I think Semantic UI is a great an feature-rich CSS framework. On the other hand, Angular2 is awesome and keeping a dependency to jQuery in an Angular2 project seems to be quite wrong. We have tested ng-semantic as well as a pure integration of Semantic-UI with CSS an JavaScript and some own directives to make it work. But you quickly run into problems caused by jQuery.
So, it would be really great to have a jQuery-free full implementation of Semantic UI in Angular2. We'll give ng2-semantic-ui a test-drive this week and come back to you with pull requests if it works for us generally.

Hi all, so essentially as you've mentioned it is because this project is a re-implementation of a set of the SUI components in pure Angular 2, whereas ngSemantic just wraps the existing jQuery implementation. I've spoken at length with the maintainer of ngSemantic about the two projects and we decided it would be best to keep them separate as they have fundamentally different goals. I'm going to close this one and reopen if anything further happens regarding the two projects.
@borisfeldmann please give 0.5.0 (released just now) a test drive, as that contains better implementations of dropdowns, searches, selects and transitions, and adds the popup component to enable tooltips.


Correction for raw affiliation IRSTEA, UMR TETIS, 34093 MONTPELLIER CEDEX 5, FRANCE

Correction needed for raw affiliation IRSTEA, UMR TETIS, 34093 MONTPELLIER CEDEX 5, FRANCE
raw_affiliation_name: IRSTEA, UMR TETIS, 34093 MONTPELLIER CEDEX 5, FRANCE
new_rors: ;0458hw939
previous_rors:
works_examples: W1980220429;W2037257426
contact: 0eb95e3d2c8f5f27566ff335f0f6a758:a9eab761090c7bab125364e3ca3b9d6c98f9 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Error because import.meta.url is undefined

Describe the bug
In order to require older modules, I've been writing this:
import { createRequire } from 'module';
const require = createRequire(import.meta.url)

This works if I run the file with node my-file.js. However, I’ve been using the package netlify-cli to run things locally, and when I do that, it logs an error saying that import.meta.url is undefined:

The argument ‘filename’ must be a file URL object, file URL string, or absolute path string. Received undefined

If you want to see in more detail, this is all open source:
https://github.com/nichoth/ssc-server/blob/1965d193da893bb98e98bd9962717d65c32a4f83/netlify/functions/profile/profile.js#L14

This is relevant to this post
Steps to reproduce
Either
Use a lambda function that includes import.meta.url, and run it with netlify-cli
or
clone my example at this commit within git :
https://github.com/nichoth/ssc-server/blob/1965d193da893bb98e98bd9962717d65c32a4f83/netlify/functions/profile/profile.js#L14
Then run npm start, which will run netlify dev
Configuration
[build]
  command = "npm run build"
  functions = "netlify/functions"
  publish = "public"

  ## more info on configuring this file: https://www.netlify.com/docs/netlify-toml-reference/

[dev]
  autoLaunch = false
  publish = "public" # Folder with the static content for _redirect file

[template.environment]
  FAUNADB_SERVER_SECRET = "faunaDB secret"
  CLOUDINARY_API_SECRET = "cloudinary secret"
  CLOUDINARY_CLOUD_NAME="cloudinary cloud name"
  CLOUDINARY_API_KEY="cloudinary API key"
  PUBLIC_KEY = "public key"
  SECRET_KEY = "secret key"

[functions]
  node_bundler = "esbuild"

[functions.profile]
  external_node_modules = ["@nichoth/ssc"]

Environment
  System:
    OS: macOS 12.3.1
    CPU: (8) arm64 Apple M1
    Memory: 70.31 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.nvm/versions/node/v16.13.1/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.13.1/bin/yarn
    npm: 8.3.0 - ~/.nvm/versions/node/v16.13.1/bin/npm
  npmPackages:
    netlify-cli: ^10.3.0 => 10.3.0
  npmGlobalPackages:
    netlify-cli: 9.16.6

@nichoth did you ever resolve this? Running ESM with import.meta.url is giving me the same error on AWS Lambda 16x

@alexcroox
No actually, I think I refactored so that everything is using require on the server.

I don't blame you. The node ecosystem still isn't ready for ESM without a lot of pain during the intial stages of setting up a new project...
For any other weary travellers I solved this on AWS by using import dirname from 'es-dirname'.
dirname() is a hack that throws an error and reads the file path from the error stack!

We do not yet support pure ESM modules in netlify functions. Currently, it will all be compiled to commonjs.
Supporting this is on our roadmap though.
Ref: https://github.com/netlify/zip-it-and-ship-it/issues/750

Would love to see support for this!

I believe this should have been resolved a year or two ago! Feel free to reopen if you're still having issues.