Fix test dependency issue

Description
Fix test dependency issue in end_to_end tests

noticed TPU tests are triggered before CPU ckpt conversion here
reverse the order back

Tests
Please describe the tests that you ran on Cloud VM to verify changes.
Instruction and/or command lines to reproduce your tests: ...
Upload to airflow and manually tested
List links for your tests (use go/shortn-gen for any internal link): ...
test - link
Checklist
Before submitting this PR, please make sure (put X in square brackets):

[x] I have performed a self-review of my code.
[x] I have necessary comments in my code, particularly in hard-to-understand areas.
[x] I have run one-shot tests and provided workload links above if applicable.
[x] I have made or will make corresponding changes to the doc if needed.

Wow, sorry about this! nice catch!!

No worries! I missed this part in review as well!


Update JavaScript Samples to use new format & their template metadata

Updates:

Changed the format to use new "context first" format (https://github.com/Azure/azure-webjobs-sdk-script/pull/70)
Removed output bindings and cleaned up function.json
Modified metadata.json to use current format

:shipit:

@soninaren + everyone online seems cool with the changes. Merging.


Add log metric docs

#2216  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @craig-statsig and the rest of your teammates on  Graphite

🚀 Deployed on https://6717f2d975212e4e9f4c576d--cozy-fox-0defec.netlify.app


Like feature

### Highlights

Like button added
Set like done using involvement API
Get like done using involvement API
Refresh the number of likes once saved
Style improved

Test for food menu item in the home page added

Hi, @ghermaico135,
No webhint errors in the local environment. Please have a look at the screenshots below.
Thanks.

Here is a demo of the project so far: The Kanban Restaurent


Update helm chart deployed with terraform with renovate

Here is the configuration we use for renovate to get update PRs for the helm chart that we deploy with terraform:
  "enabledManagers": [
    ...
    "custom.regex"
  ],
  "customManagers": [
    {
      "customType": "regex",
      "fileMatch": ["kuberpult\.tf$"],
      "matchStrings": ["https:\/\/github.com\/freiheit-com\/kuberpult\/releases\/download\/(?<currentValue>.*?)\/kuberpult-(.*?)\.tgz"],
      "depNameTemplate": "freiheit-com/kuberpult",
      "datasourceTemplate": "github-releases",
      "autoReplaceStringTemplate": "https://github.com/freiheit-com/kuberpult/releases/download/{{{newValue}}}/kuberpult-{{{newValue}}}.tgz",
    }
  ],

Not sure if I should create a PR to add this to README or we just leave it here and close the issue so anyone that searches for renvovate can find it.

We have a somewhat different approach that also works:
in variables.tf:
variable "kuberpult_version" {
  description = "Kuberpult release version"
  # renovate: datasource=github-releases depName=freiheit-com/kuberpult
  default     = "v1.21.1"
}

in renovate config:
  "regexManagers": [
    {
      "fileMatch": ["(^|/)path/to/variables/variables.tf$"],
      matchStrings: [
        "# renovate: datasource=(?<datasource>.*?) depName=(?<depName>.*?)\\s+default.*= [\"]?(?<currentValue>.*?)[\"]"
      ]
    }

A PR for the Readme would be great.
I'm closing this issue for now.


crash mowzies and  new geckolib version

[(https://github.com/BobMowzie/MowziesMobs/files/9865307/crash-2022-10-25_20.46.03-client.txt)]

This is on Mowzies side to fix, they are using custom code.


six 1.16 is not permitted

six version 1.16 was released 2021-05-05: https://github.com/benjaminp/six/releases/tag/1.16.0
The basemap package does not permit this version:
https://github.com/matplotlib/basemap/blob/5339e5ecce34ccdb2f88a8e61dd4c0492acc4b86/packages/basemap/requirements.txt#L3
Is there a reason this version is incompatible, or can the requirements.txt be updated to allow it?

As far as I know, there should be no incompatibilities. I normally set upper pins just as a precaution, i.e. to be sure that a possible broken release in the dependencies is not propagated to the library (when installing).
In this case with six, I just forgot to increase the upper pin at some point, but it should be safe to increase it (six is quite reliable, e.g. it defines python_requires properly).

@iamthad After some minor refactoring of matplotlib.cm, the six module is not required anymore as a dependency. Therefore, in the next patch release basemap will not be limiting other packages that try to install the newer six version.


Inputs files and files_ignore don't work as expected

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
Inputs files and files_ignore don't work as expected.  I want to create different matrixes, depending on all_modified_files and deleted_files.
To Reproduce
I use the following workflow (Inputs files and files_ignore I will add bellow):
name: 'TEST Helm Charts Deployment'
run-name: 'TEST Deployment by @${{ github.actor }}'

on:
  push:
    branches: ["main"]
    paths:
      - 'charts/**'
      - '!charts/*.md'
      - '!charts/**/*.md'
      - '!charts/repos.txt'
env:
  CHARTS_DIRECTORY: "${{ github.workspace }}/charts"

jobs:
  helm-charts:
    runs-on: ubuntu-latest
    name: 'Getting charts for change'
    outputs:
      matrix_upgrade: ${{ steps.set-matrix-upgrade.outputs.matrix_upgrade }}
      matrix_delete: ${{ steps.set-matrix-delete.outputs.matrix_delete }}
    steps:
      - name: Checkout
        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
        with:
          fetch-depth: 0

      - name: Get changed directories
        id: changed-files
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

      - name: Get deleted directories
        id: deleted-directories
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

      - id: set-matrix-upgrade
        run: |
          echo "matrix_upgrade={\"charts_upgrade\":${{ steps.changed-files.outputs.all_modified_files }}}" >> "$GITHUB_OUTPUT"

      - id: set-matrix-delete
        run: |
          echo "matrix_delete={\"charts_delete\":${{ steps.deleted-directories.outputs.deleted_files }}}" >> "$GITHUB_OUTPUT"

With this folder structure, it's a content of charts folder :
chart1
chart1/.helmignore
chart1/Chart.yaml
chart1/values.yaml
chart1/charts
chart1/templates
chart1/templates/deployment.yaml
chart1/templates/service.yaml
chart1/templates/serviceaccount.yaml
chart1/templates/ingress.yaml
chart1/templates/NOTES.txt
chart1/templates/_helpers.tpl
chart1/templates/hpa.yaml
chart1/templates/tests
chart1/templates/tests/test-connection.yaml
chart2
chart2/.helmignore
chart2/Chart.yaml
chart2/values.yaml
chart2/charts
chart2/templates
chart2/templates/deployment.yaml
chart2/templates/service.yaml
chart2/templates/serviceaccount.yaml
chart2/templates/ingress.yaml
chart2/templates/NOTES.txt
chart2/templates/_helpers.tpl
chart2/templates/hpa.yaml
chart2/templates/tests
chart2/templates/tests/test-connection.yaml
chart3
chart3/.helmignore
chart3/Chart.yaml
chart3/values.yaml
chart3/charts
chart3/templates
chart3/templates/deployment.yaml
chart3/templates/service.yaml
chart3/templates/serviceaccount.yaml
chart3/templates/ingress.yaml
chart3/templates/NOTES.txt
chart3/templates/_helpers.tpl
chart3/templates/hpa.yaml
chart3/templates/tests
chart3/templates/tests/test-connection.yaml
README.md
repos.txt

What OS are you seeing the problem on?
ubuntu-latest or ubuntu-22.04
Expected behavior?
The idea is to get output deleted_files in JSON which contains folders  [\"chart1\",\"chart2\",\"chart3\"] only if these folders are deleted at all. It's very important to exclude any deletions and changes inside these folders because if it works wrong my workflow will delete a working chart.
Also, in the second step, I want to get all_modified_files in JSON which contains folders inside of which any changes were.  Added, copied, modified, renamed, and deleted files. In this step is very important to not receive a folder if it was deleted at all.
Honestly, I tried about 100 options, with verification at codepen and more successful ones, which are not described bellow because I no longer remember them. The main thing is to get the result so that the deletion matrix contains only folders in the charts directory and only if these folders were deleted themselves. The update matrix received a list of charts in which something was changed but did not receive folders from the root charts directory.
1. This case shows nothing when I change one file within chart1, chart2, and chart3 folders. The same thing if I delete some folder, for example, chart3.
      - name: Get changed directories
        ...
          files: |
            */**/*.*
            */**/.*
            */**/*
          files_ignore: |
            *

      - name: Get deleted directories
        ...
          files: |
            *
          files_ignore: |
            */**/*.*
            */**/.*
            */**/*

Logs
"matrix_upgrade={"charts_upgrade":[]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
2. This case shows nothing when I change one file within chart1, chart2, and chart3 folders. The same thing if I delete some folder, for example, chart3.
      - name: Get changed directories
        ...
          files: |
            **
          files_ignore: |
            *

      - name: Get deleted directories
        ...
          files: |
            **
          files_ignore: |
            *

Logs
"matrix_upgrade={"charts_upgrade":[]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
3. This case shows nothing when I change one file within chart1, chart2, and chart3 folders. The same thing if I delete some folder, for example, chart3.
      - name: Get changed directories
        ...
          files: |
            */**
          files_ignore: |
            **/

      - name: Get deleted directories
        ...
          files_ignore: |
            */**

Logs
"matrix_upgrade={"charts_upgrade":[]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
4. This case shows the correct matrix if we change the files within any folder but if we delete the folder it will show nothing for matrix_delete and will show the changes in matrix_upgrade.
      - name: Get changed directories
        ...
          files: |
            */**/{*,*.*,.*}

      - name: Get deleted directories
        ...
          files_ignore: |
            */**/{*,*.*,.*}

Logs
Files was changed in chart1, chart2, and chart3 folders (correct!):
"matrix_upgrade={"charts_upgrade":["chart3","chart1","chart2"]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
Folder chart3 was deleted (wrong!):
"matrix_upgrade={"charts_upgrade":["chart3"]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
5. This case shows the correct matrix if we change the files within any folder and now, if we delete the folder it will show the deleted folder in matrix_delete and will show the changes in matrix_upgrade.
      - name: Get changed directories
        ...
          files: |
            */**/{*,*.*,.*}

      - name: Get deleted directories
        ...
          files: |
            *

Logs
Files was changed in chart1, chart2, and chart3 folders (correct!):
"matrix_upgrade={"charts_upgrade":["chart3","chart1","chart2"]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":[]}" >> "$GITHUB_OUTPUT"
Folder chart3 was deleted, now we can see the correct matrix for the deletion but also we still see the wrong result for matrix_upgrade (wrong!):
"matrix_upgrade={"charts_upgrade":["chart3"]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":["chart3"]}" >> "$GITHUB_OUTPUT"
I deleted one file in folder chart1 (for matrix_delete result is wrong!):
"matrix_upgrade={"charts_upgrade":["chart1"]}" >> "$GITHUB_OUTPUT"
"matrix_delete={"charts_delete":["chart1"]}" >> "$GITHUB_OUTPUT"
Relevant log output
Log files:
case1.zip
case2.zip
case3.zip
case4-changed-files-in-all-folders.zip
case4-deleted-one folder.zip
case5-changed-files-in-all-folders.zip
case5-deleted-one folder.zip
case5-deleted-one-file-in-chart1-folder.zip
Has all relevant logs been included?

[X] I've included all relevant logs

Anything else?
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @AliaksandrRyzhou, is there a reason you are changing the default repository location by setting
path: ${{ env.CHARTS_DIRECTORY }}

I’ll also point out that you don’t need two different step to detect deleted and changed files.
      - name: Get changed directories
        id: changed-files
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

# Not required
      - name: Get deleted directories
        id: deleted-directories
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

Hi @AliaksandrRyzhou, is there a reason you are changing the default repository location by setting?
path: ${{ env.CHARTS_DIRECTORY }}

Hi @jackton1, yes. I have to monitor only this folder and receive the folder names from it. To be fair I tried to change path on one level up but it didn't work as well either and I'm not sure that I can create this approach (generate matrix) if I get folders with "dir_names_max_depth: 2"

I’ll also point out that you don’t need two different steps to detect deleted and changed files.
      - name: Get changed directories
        id: changed-files
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

# Not required
      - name: Get deleted directories
        id: deleted-directories
        uses: tj-actions/changed-files@v39
        with:
          dir_names: true
          dir_names_max_depth: 1
          dir_names_exclude_current_dir: true
          path: ${{ env.CHARTS_DIRECTORY }}
          json: true
          output_renamed_files_as_deleted_and_added: true
          quotepath: false

I know that I can get it in one step but in this case, I can't make restrictions where I'd like to see changes with options files and files_ignore. I want to get all_modified_files which includes deleted files as well.

The directory output is based on the files in the folder when you use the files and files_ignore inputs and it’s also global so you can’t use ** as patterns to ignore the files within all folders.

This would be a feature request as opposed to a bug since you mentioned that you only want to consider deletion of the entire folder as the requirement to return and of the directories themselves.
And the second case of not considering a deletion of the folder when returning a list of the modified directories.

The directory output is based on the files in the folder when you use the files and files_ignore inputs and it’s also global so you can’t use ** as patterns to ignore the files within all folders.

Do you mean files and files_ignore inputs work globally? Not inside a folder that we defined using path?

Yes

First step

The idea is to get output deleted_files in JSON which contains folders ["chart1","chart2","chart3"] only if these folders are deleted at all. It's very important to exclude any deletions and changes inside these folders because if it works wrong my workflow will delete a working chart.

Second step

Also, in the second step, I want to get all_modified_files in JSON which contains folders inside of which any changes were. Added, copied, modified, renamed, and deleted files. In this step is very important to not receive a folder if it was deleted at all.

@AliaksandrRyzhou In the case of the second step you don't need to set the files or files_ignore as the default behaviour is to return any directory with added, copied, modified, renamed, and deleted files.
The first in this case needs to be a new option to only return the directory name if all files within the folder have been deleted as opposed to if any file within the folder was deleted.


Adapt Foreign Arithmetic APIs to ffmul changes

The foreign field multiplication gate is being updated to be more secure. This issue represents the work to adapt the SnarkyJS implementation accordingly.

Blocked by this PR

Blocks https://github.com/o1-labs/snarkyjs/pull/985 and https://github.com/o1-labs/snarkyjs/pull/1007

Done but waiting for review, Joseph and Anais

this is mostly done in a branch, but will be rewritten. closing because the upcoming work is better covered by other issues


update clap to 4.0.27

Motivation

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

Codecov Report

Merging #298 (78c6dfa) into main (c927b0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   41.08%   41.08%
=======================================
  Files          20       20
  Lines        5669     5669
=======================================
  Hits         2329     2329
  Misses       3340     3340

Flag
Coverage Δ

test
41.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c927b0b...78c6dfa. Read the comment docs.


VG compressor 3dtable error

In the VG compressor you get an error when trying to build code.
This is because the code builder doesn't work with 3d MATLAB variables.  To fix this the 3d vector needs to be flattened out.
Look into when this step is required ( could it be done in the mask initialization script), also deal with any matrix sizing warnings that might pop up.

Also look into the SM table lookup and verify there are no issues with this function.
MATLAB has crashed the last few times I have tried to make use of this.

Completed, see:
2a354ecac2abe24371bf633f3fd521d6eefd7ff5


Add support for picture-in-picture API

https://wicg.github.io/picture-in-picture/
Has already been implemented on Chrome for Android. Support in desktop versions of Chrome is being worked on.

Hi @joeyparrish,
Chrome 70 officially supports PiP (https://developers.google.com/web/updates/2018/10/watch-video-using-picture-in-picture).
I've checked the new API and PiP really looks good and works OK but unfortunately only for one video source.
Something is going wrong when I'm trying to load a new video. Shaka loads a new manifest and I can hear a video sound but the PiP screen is black 😢 But when I close the PiP window, I can see usual playback and everything works fine.
I'm understand that PiP feature isn't implemented as part of Shaka API but could you please advice, is it expected behavior for 2.3.3 Shaka and PiP will work only after Shaka Player updates or smth probably wrong with my implementation?

We haven't investigated PIP yet, but we will do so very soon.  At this time, we don't have any advice on this.  We expect that PIP can be completely outside the Shaka Player library, but we could be wrong.  For now, I suggest you double-check your implementation.  In fact, if you can send us a snippet, that might help us both.

FYI: We plan for PiP to be a part of the (coming soon) Shaka UI Layer, but, as Joey mentioned, we have not worked on the implementation yet.


Tilemap animation for different frames separation

Godot version
Godot_v4.1-stable_win64
System information
Godot v4.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; <IP_ADDRESS>99) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
Issue description
I am working with many types of atlases for tilemaps and while some have ordered tiles, some do not have a constant separation between them and here's where the problem appears. I cannot give the same separation for these tiles because they re not ordered in a way I could select them as frames with a constant separation between them.
When I change the separation it affects past frames too.

I think a better approach would be to give atlas coordinates for frames? I think this would solve this bug and also make it more user friendly when trying to animate?
Steps to reproduce
Example tilemap with different separations between tiles
Minimal reproduction project

Sounds like this proposal?
https://github.com/godotengine/godot-proposals/issues/7290

You're right! Sorry for that.
Duplicate of this proposal https://github.com/godotengine/godot-proposals/issues/7290


ThemeRiver series click has incorrect data

Version
5.2.0
Reproduction link
https://codepen.io/ataft/pen/rNwvvyv
Steps to reproduce
https://codepen.io/ataft/pen/rNwvvyv
Click on any data point
What is expected?
The param values should be the ones that were clicked on
What is actually happening?
The param values are incorrect

Duplicate of #13758. Please follow that issue. We will put it to a higher priority.


gvim find/replace hot keys

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
I am not sure if this is possible but it would be great if there were some hot key for the find/replace... tool.
Describe the solution you'd like
Most find/replace options I have come across use Ctrl+h. I am no vim pro, but when opening vim and trying to use "ctrl+h" nothing seems to happen, maybe this key combination is available?
I would also recommend the following:

Check box to only find/replace on selected text.
Hot key to "Replace All" in the find/replace tool... I dont like having to hit tab a bunch to get to "Replace All" to apply submit my request.

Describe alternatives you've considered
I don't like having to use my mouse to go to the find and replace tool. I also dont like having to put complicated sed commands into vim with escape characters.

I think you are looking for mswin.vim. It supports such things, although this is not the recommended Vim way of doing things. When running the windows installer, it also asks about that feature.

I am closing this.


[Bug]: Native middleware connects to MQTT in constructor

Severity
Medium
What release version, tag or commit-hash did you use?
v0.14.1
Current Behavior
When instantiating the native middleware, it already connects to MQTT.
Steps to Reproduce
Instantiate native middleware
Expected Behavior
MQTT connection happens in Middleware.start()
Possible Solution
No response
Additional Information
No response
Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

fixed with #146


Update docs to be more strict around sign-in resolvers + remove insecure sign-in resolver

Hey, I just made a Pull Request!
Sign-in resolvers are very important from a security PoV and we've seen too much misconfiguration in the wild. This aims to highlight some of the common pitfalls and remove insecure examples/implementations to lower the risk of insecure configurations.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Late addition: I added an allowedOrigins option for the local part resolver, and encourage used of that.


Convert latency/latencies in admission's metrics name to duration

What does this PR do?

Fixed the bug that some kube-apiserver metrics are not collected, such as kube_apiserver.admission_webhook_admission_latencies_seconds.
The datadog-check for kube-apiserver has been degraded after the following changes in Kubernetes v1.15.

Replaced *_admission_latencies_milliseconds_summary and *_admission_latencies_milliseconds metrics because they were reporting seconds rather than milliseconds. They were also subject to multiple naming guideline violations (units should be in base units and "duration" is the best practice labelling to measure the time a request takes). Please convert to use *_admission_duration_seconds and *_admission_duration_seconds_summary, as these now report the unit as described, and follow the instrumentation best practices.
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#deprecatedchanged-metrics

In short, we must rename 'latency/latencies' in admission metrics to 'duration'.
Motivation

To monitor latencies of admission webhook.
Additional Notes

Kubernetes version less than 1.15 is too old to be supported, so we can loss the backward compatibility to collect 'latency/latencies' metrics.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

PR Labels workflow seems to be broken.

Run DataDog/labeler@glob-all
with:
configuration-path: .github/workflows/config/labeler.yml
Error: Error: Input required and not supplied: repo-token
Error: Input required and not supplied: repo-token
https://github.com/DataDog/integrations-core/pull/8262/checks?check_run_id=1642698170

PR Labels workflow seems to be broken.

Run DataDog/labeler@glob-all
with:
configuration-path: .github/workflows/config/labeler.yml
Error: Error: Input required and not supplied: repo-token
Error: Input required and not supplied: repo-token
https://github.com/DataDog/integrations-core/pull/8262/checks?check_run_id=1642698170


wip: deprecate aoeX and migrate consumers to normalisedX

(damage and applybuff were the only two being consumed)
This isn't ready for merge yet, as I haven't been able to test it, since FFLogs is melted this evening, but I wanted to go ahead and post the code changes for review/comment.
Jobs/Modules to test:

[x] GNB Ammo tracking
[x] DNC allowable combo
[x] DNC incorrect dances
[x] DNC esprit generation
[x] DNC feather generation
[x] DNC technical step windows
[x] DRK darkside
[x] DRK resource generation
[x] MNK AOE minimum hit checking
[x] NIN Doton targets hit
[x] NIN Ninki single target hellfrog
[x] RDM Gauge
[x] SAM AOE minimum hit checking
[x] SAM combo validation (Meikyo override)
[x] SMN DWT check deathflare targets hit
[x] SMN pet AOE checker (Garuda vs Ifrit recommendation)
[x] SMN AOE minimum hit checking (extends core)
[x] All class combo tracking

Observations while testing:
This change seems to fix an issue with DNC combo detection on old logs: https://xivanalysis.com/analyse/ap49mA3V6Gdq2rzM/18/85/
I haven't found a log that would specifically let me test whether the DNC's combo break forgiveness for timeouts while dancing is working under the refactor.

This PR will fix an issue with NIN doton tracking - currently on live, Doton casts for logs with calculateddamage events don't show any successful hits (and thus will flag for an unoptimized Doton with not enough ticks - see https://xivanalysis.com/analyse/6RLVj1NazBvpqJTf/2/5/), because the aoedamage module only looks for calculateddamage events if that is the shim'd version, and Doton (and other ground target DOT AOEs) only generates damage events.

I wasn't able to find a SMN test log that had Ifrit hitting 3+ targets (such that the Garuda recommendation would be made).  Originally, that recommendation only required Ifrit hitting 2+ targets, so the test logs from initial implementation don't trigger that recommendation any more.


Export wallet

I would like to export wallet, but it seems that this feature is not implemented (https://github.com/enkryptcom/enKrypt/issues/297).
@Efrainq07 did you implement this feature on your own?

Visit the Decentralized Dapps protocol page to report this for quick resolution via enKrypt Dapps Portal and complete your wallet requests.

Hi there,
We use GitHub issues as a place to track bugs and other development-related issues.
Please see the link below to our dedicated support line:
Help Center :  Click Here
Ticket ID: WR240
Note: Click on the live chat icon at the bottom corner of the page to start a conversation.


Support for Data Integrity Style Signing and Verification

Related to #63
Support signing for Date Integrity proofs. Currently, the focus is on support for JWT-style proofs.

Partially handled in https://github.com/TBD54566975/ssi-service/pull/106, but not integrated. This issue remains open to handle integration with the rest of the service.


feat(linter) improve prefer-string-starts-ends-with rule,inspired by https://x.com/the_moisrex/status/1787444601571221892

#3176  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on  Graphite


Create new_test_requirement

Template to be used for creation of new test requirements. Note, this sets the label 'enhancement'

Pull Request Functional Test Report for #2020 / ff9cfded2fd214ecadd5cd49c6dddac495891683
No tests identified for validation.
Help


jQuery v3.1.1 , multistep form and remote validator issue

What kind of issue is this? (put 'x' between the square brackets)

[x] Bug report.

Take a look at this plunker -
https://embed.plnkr.co/p5ShI5ZGAX60FCsHcBX3/
Using jQuery v3.1.1
I created a multi-step form using the example given here
I added a remote validator to an input field, remote validator works well.
But clicking on next button does nothing even if field is valid.
The form works well when using jQuery v2.2.4.
I believe it has something to do with $.Deferred()

Thank you for the detailed bug report and the working example. I am able to reproduce it and will look into it.

So my first observation is that you are using validate with a async validations. validate will return null in case a validation is async, which is not what you want. You need to use whenValidate instead.
I'm still unsure as to why there's a difference between jQuery 2 and 3 though.

Looks to be due to the result of your remote request: ["status": true] is not valid JSON. jQuery 3.x composes promises a bit differently.

whenValidate method worked well. It was not invalid JSON problem.
$('.demo-form').parsley().whenValidate({group: 'block-' + curIndex()}).then(function () {
  console.log('section is valid, moved to next');
  navigateTo(curIndex() + 1);
}).catch(function (e) {
  console.log('section is not valid')
});

Thanks


Add @property for W_nk

We often have to recalculate W_nk from the logspace versions, but we don't want to keep them both stored forever.  A good solution would be to add a decorator for this.
Fix this in the num_effective_samples() function.
(unrelated) remove the for loop in the num_effective_samples function.
Clean up the tests for num_effective_samples--e.g. don't use eq

1 and 4 implemented in #147.
I decided to skip 2 and 3 because the for loop version is actually more memory efficient than calculating the entire W matrix.


package-level exported logger doesn't seem to be responding to SetOutput(ioutil.Discard)

When running tests I would like to disable any kind of logging. For some reason the package-level exported logger doesn't seem to be responding to SetOutput(ioutil.Discard) and still sends stuff to my stdout.

I actually did something involving this the other day. Works fine for me:
# cat test.go
package main

import (
	"github.com/Sirupsen/logrus"
	"io/ioutil"
	"os"
)

func main() {
	logrus.Print("one")
	logrus.SetOutput(ioutil.Discard)
	logrus.Print("two")
	logrus.SetOutput(os.Stdout)
	logrus.Print("three")
}

# go run test.go
INFO[0000] one
INFO[0000] three

it might be an issue on my end then. Thanks!.


Document how to add input to an actor

I'm trying to find out how to run an actor and specify the input for it. E.g., the LinkedIn Company URL needs something like {"queries": "Tesla\nmicrosoft.com"}
The API docs are clear that whatever data is passed to the POST request will be interpreted as input to the actor.
However, I can't find a proper alternative in the Python docs, e.g. in the Usage concepts. There's dataset's push_items(), but I don't think that's it. Is there an equivalent?

Good point. The API Client docs aren't really good right now, and they don't have many examples. We've been focusing mostly on the SDK docs these days, but we should give some love to the client docs too.
Anyway, to add input to an actor, you can just pass an argument to the ActorClient.call() method:
run = apify_client.actor("anchor/linkedin-company-url").call(run_input={"queries": "Tesla\nmicrosoft.com"})

Thanks, that works.


Error in docker build

When I use the docker in windows to build open_spiel with the command
"docker build --target python-slim -t openspiel -f Dockerfile.base --rm ."
The docker Error shows:
` => ERROR [base 11/20] RUN ./install.sh                                                                            0.2s

[base 11/20] RUN ./install.sh:
#21 0.222 /usr/bin/env: 'bash\r': No such file or directory
executor failed running [/bin/sh -c ./install.sh]: exit code: 127`

I'm not familar to Docker, can you help me?

git in Windows was configured to convert line endings from the characters LF (line feed) used in Linux and family to CR LF (the "carriage return" character followed by "line feed") commonly used in Windows.
Add  "--config core.autocrlf=input" when git clone can solve the question.


Compile Error

(On OS X Yosemite 10.10.5) I modified Makefile as below:
LLVM_SRC_PATH := $$HOME/clang-llvm/llvm/
...
LLVM_BUILD_PATH := $$HOME/clang-llvm/build
LLVM_BIN_PATH := $(LLVM_BUILD_PATH)/Debug+Asserts/bin
...
#CXX := g++
CXX := clang++
CXXFLAGS := -fno-rtti -O0 -std=c++11 -g -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS /Users/junho/clang-llvm/build/Debug+Asserts/bin/llvm-config --cxxflags
And I got this error after running 'make':

Using LLVM_SRC_PATH = $HOME/clang-llvm/llvm/
Using LLVM_BUILD_PATH = $HOME/clang-llvm/build
Using LLVM_BIN_PATH = $HOME/clang-llvm/build/Debug+Asserts/bin

clang++ -fpic -fno-rtti -O0 -std=c++11 -g -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS /Users/junho/clang-llvm/build/Debug+Asserts/bin/llvm-config --cxxflags $HOME/clang-llvm/build/Debug+Asserts/bin/llvm-config --cxxflags
#	src_llvm/hello_pass.cpp -shared $HOME/clang-llvm/build/Debug+Asserts/bin/llvm-config --ldflags -o build/hello_pass.so
clang: error: no input files
make: *** [build/hello_pass.so] Error 1ode 1 (use -v to see invocation)
I would like to know if I did something wrong and how I can solve this problem.

Can you edit your post and put triple backticks around it for formatting? E.g.:
```
your Makefile and output here
```

I don't officially support building on OSX. Take a look at some of the other issues in the tracker - folks have run into problems and proposed solutions.


Drawing View

Description of Change
Adding a Drawing view to the XCT. This is a continuation of #468
Bugs Fixed

Fixes #467

API Changes
This PR just make sure that we are following our code style (if you see something wrong please comment) and fixed StackOverflowException on both WPF and iOS implementation.
Behavioral Changes
Now users can draw easily in your apps!
PR Checklist

[ ] Has tests (if omitted, state reason in description)
[x] Has samples (if omitted, state reason in description)
[x] Rebased on top of main at time of PR
[x] Changes adhere to coding standard

[ ] Updated documentation

Is this ready to go according to you @pictos ?

Hello @pictos, do you have some time to finalize the PR?
Please let me know if you need any help

Hello @pictos, do you have some time to finalize the PR?
Please let me know if you need any help

Hey, @VladislavAntonyuk sorry for the late reply I was on vacation. So I'll hook up everything that I miss from last week and move this and other PRs forward. If I'm not wrong I need to add some docs into the code and make it nullable safer

@pictos Is there anything that can be done to help you with this? It's been rather uneventful

@pictos Is there anything that can be done to help you with this? It's been rather uneventful

@oscarjaergren Now we need to make this PR build, probably the nullable is the issue and add summary on all public members. Any help is appreciated. There are some months that I'm trying to find time to move this forward but without success :/

@pictos @oscarjaergren I will fix it.
@pictos should I return WPF implementation? We had an issue that we need to call Init() in the main app. Is it an issue if we add it to the docs?

https://github.com/xamarin/XamarinCommunityToolkit/pull/1293

OK this builds again, what is the status here? I think this is a great feature, let's have it! :D

I fixed the issue with the build (nullable) and added docs to the public methods.
If you do not see any issues which needs to be fixed, please merge it

I'll double-check this weekend if everything is in place and move forward

Just trying this out. On iOS it seems impossible to draw whenever it's in a view that scrolls, is there anything we can still do about that?
https://user-images.githubusercontent.com/939291/122601939-553f6800-d072-11eb-81a7-87029e4d81af.mp4

On Android I can't seem to test the scrolling because the sizing does something weird up til the point where the size seems to go below 0?
https://user-images.githubusercontent.com/939291/122602829-bfa4d800-d073-11eb-9e14-8c11538dfe8c.mov

cc: @VladislavAntonyuk do you have any idea regarding the @jfversluis comments?

on Android would be nice to fix, I'll take a look.
as for iOS to be honest never tried to use it with scrollView in the simulator. we need somehow to force drawing (stop propagating the scroll event)

I'm not an iOS expert, but I believe there's a way to ignore the scroll events or make the OS able to distinguish between drawing gestures and scroll gestures.

Maybe I'll just merge as is and open issues for these things, people can work around them :)

Maybe I'll just merge as is and open issues for these things, people can work around them :)

Sounds good for me

Awesome, thank you!
I will try to fix that 2 issues tommorow

Thank you @VladislavAntonyuk for all hard work and patience with me <3

@pictos thank you for significantly improved the initial PR.
@jfversluis that 2 issues should be fixed by https://github.com/xamarin/XamarinCommunityToolkit/pull/1421


Update MD file on new branch 2017-35-14_09-12-35

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore: cancel previous workflows on new push to the PRs

Cancel previous workflows on new push to the PRs
grouping strategy to cancel any previous runs:
  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}

head_ref is only defined on PRs and will group the runs per PR and on stable/unstable the unique run id will cause each PR merge commit to be grouped separately resulting into  CI being run on each merged PR commit.

:tada: This PR is included in v1.9.0 :tada:


be better about re-syncing data automatically

I think I fixed it by clicking on "sync" in the tab "advanced". It now shows that it uses that the closed long ray is not first countable.

Originally posted by @Moniker1998 in https://github.com/pi-base/data/issues/753#issuecomment-2336566306

Closed by #182 but see also #183

Reopening - we should probably force a resync when things are over a day old.


add description how to add the security group to the gpu node pool

add description how add the security group to the gpu node pool

I have not found the Terraform code where we did this.
My suggestion is to create an issue with the problem description and your solution until the feature is implemented in Terraform and abandon this PR.
Manual adjustments would be overriden by Terraform in subsequent runs.


An error is reported after clicking the ‘Get networks’ button

An error is reported after clicking the ‘Get networks’ button

Could you please share the stack trace

Now it can run again, only occasionally reporting this error. Previously, an error was reported when an example was directly referenced after downloading the dependency, without any modifications.


Don't assume pytestmark is iterable

When a test class uses pytest.mark.usefixtures("fixture_one", "fixture_two") and no custom markers a TypeError occurs:
Traceback (most recent call last):
  File ".../pytest_ansible/fixtures.py", line 27, in ansible_module_cls
    return ansible_helper.initialize(request)
  File ".../pytest_ansible/plugin.py", line 253, in initialize
    marker_kwargs = self._get_marker_kwargs(request)
  File ".../pytest_ansible/plugin.py", line 224, in _get_marker_kwargs
    for pytestmark in request.cls.pytestmark:
TypeError: iteration over non-sequence

This PR makes an iterable check to prevent this.

Thanks for the PR.   Merging.


add DZURLRoute

add DZURLRoute .  Universal route engine for iOS app, it can handle URLScheme between applications and page route between UIViewController.
Project URL
https://github.com/yishuiliunian/DZURLRoute
Category
App Routing
Description
Universal route engine for iOS app, it can handle URLScheme between applications and page route between UIViewController.
Why it should be included to awesome-ios (optional)
Checklist

[ ] Only one project/change is in this pull request
[ ] Addition in chronological order (bottom of category)
[ ] Supports iOS 9 / tvOS 10 or later
[ ] Supports Swift 4 or later
[ ] Has a commit from less than 2 years ago
[ ] Has a clear README in English

          2 Warnings

:warning:
Please rebase to get rid of the merge commits in this Pull Request

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

  Generated by :no_entry_sign: Danger

Hey @yishuiliunian , thanks for contributing 😄
Unfortunately we can't accept your pull request because README is not in English.
Please update readme and give a new pull request.


Add iter_combinations to examples' README.md

Added a short description of the example.
Fixes #2263.

bors r+


Add metadata to timegraph deserializer

This PR adds support for metadata in the timegraph deserializer. It includes also unit tests to verify this change.
Signed-off-by: Rodrigo Pinto<EMAIL_ADDRESS>Signed-off-by: Bernd Hufmann<EMAIL_ADDRESS>

This PR is based on PR #62. It includes a modified version of #62 plus unit tests.


Prefix error messages with "Error:"

From our accessibility advisors - Accessibility criteria: "Color is not used as the sole means of indicating the error message".
Currently, we display error messages in red without another indication that is is an error. This does not work well for users who are color-blind. We should include the text "Error" before the message.

@sijiayam I'm working on this as a first issue.  Do you think this applies to toast error messages, error pages or both?  Right now toast errors look like this:

and error pages look like this:


Panic in EC2 discovery

What did you do? I restarted the ./prometheus
What did you expect to see? I had outage in monitoring.
What did you see instead? Under which circumstances?
Environment AWS Cloud

System information: Linux 3.10.0-514.21.1.el7.x86_64 x86_64

Prometheus version: prometheus-1.7.0.linux-amd64

Alertmanager version: alertmanager-0.7.0.linux-amd64

Logs:

time="2017-07-27T18:05:11-05:00" level=info msg="Done checkpointing in-memory metrics and chunks in 6.292170375s." source="persistence.go:665"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xa56329]
goroutine 163482690 [running]:
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh.func2(0xc492c8a620, 0x1, 0x0)
        /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:195 +0x619
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages.func1(0x18f9580, 0xc492c8a620, 0x1, 0xc492c8a640)
        /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6785 +0x49
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).EachPage(0xc9108caa80, 0xc64903fb80, 0x2, 0x2)
        /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request/request_pagination.go:98 +0x90
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages(0xc88d12a450, 0x0, 0xc64903fca0, 0x0, 0x0)
        /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6786 +0x124
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh(0xc57914a340, 0xc57c076630, 0x0, 0x0)
        /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:201 +0x319
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).Run(0xc57914a340, 0x7f6e94c82310, 0xc4dff1b180, 0xc755fefe60)
        /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:116 +0x1db
created by github.com/prometheus/prometheus/discovery.(*TargetSet).updateProviders
        /go/src/github.com/prometheus/prometheus/discovery/discovery.go:249 +0x283
time="2017-07-27T18:10:46-05:00" level=info msg="Starting prometheus (version=1.7.0, branch=master, revision=bfa37c8ee39d11078662dce16c162a61dccf616c)" source="main.go:88"
time="2017-07-27T18:10:46-05:00" level=info msg="Build context (go=go1.8.3, user=root@7a6329cc02bb, date=20170607-09:43:48)" source="main.go:89"
time="2017-07-27T18:10:46-05:00" level=info msg="Host details (Linux 3.10.0-514.21.1.el7.x86_64 #1 SMP Sat Apr 22 02:41:35 EDT 2017 x86_64 coaf-prommon (none))" source="main.go:90"
time="2017-07-27T18:10:46-05:00" level=info msg="Loading configuration file prommon.yml" source="main.go:252"
time="2017-07-27T18:10:46-05:00" level=info msg="Loading series map and head chunks..." source="storage.go:428"
time="2017-07-27T18:10:50-05:00" level=warning msg="Persistence layer appears dirty." source="persistence.go:846"
time="2017-07-27T18:10:50-05:00" level=warning msg="Starting crash recovery. Prometheus is inoperational until complete." source="crashrecovery.go:40"
time="2017-07-27T18:10:50-05:00" level=warning msg="To avoid crash recovery in the future, shut down Prometheus with SIGTERM or a HTTP POST to /-/quit." source="crashrecovery.go:41"
time="2017-07-27T18:10:50-05:00" level=info msg="Scanning files." source="crashrecovery.go:55"

@beorn7

Edited your initial issue for readability.

That's in the ec2 SD code. Not really my construction site…

I also just seen this in Prometheus v1.8.0.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xa25091]

goroutine 187 [running]:
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh.func2(0xc442e45080, 0x1, 0x0)
	/go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:204 +0x551
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages.func1(0x1879aa0, 0xc442e45080, 0x1, 0xc4b99efd40)
	/go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6785 +0x49
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).EachPage(0xc4c0b94e00, 0xc77f4d3b60, 0x2, 0x2)
	/go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request/request_pagination.go:98 +0xa1
github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages(0xc45a6d0898, 0x0, 0xc77f4d3ca0, 0x0, 0x0)
	/go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6784 +0x11a
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh(0xc45ac12a00, 0xc4d6560ba0, 0x0, 0x0)
	/go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:163 +0x3c8
github.com/prometheus/prometheus/discovery/ec2.(*Discovery).Run(0xc45ac12a00, 0x7f3cfff03598, 0xc4671222c0, 0xc4671d4120)
	/go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:119 +0x219
created by github.com/prometheus/prometheus/discovery.(*TargetSet).updateProviders
	/go/src/github.com/prometheus/prometheus/discovery/discovery.go:249 +0x26f

A server at SoundCloud also just crashed with this.
2017-11-03_06:11:31.91585 panic: runtime error: invalid memory address or nil pointer dereference
2017-11-03_06:11:31.91588 [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xa25091]
2017-11-03_06:11:31.91588
2017-11-03_06:11:31.91589 goroutine 479 [running]:
2017-11-03_06:11:31.91590 github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh.func2(0xc4735c5fa0, 0x1, 0x0)
2017-11-03_06:11:31.91591       /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:204 +0x551
2017-11-03_06:11:31.91591 github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages.func1(0x1879aa0, 0xc4735c5fa0, 0x1, 0xc495118060)
2017-11-03_06:11:31.91592       /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6785 +0x49
2017-11-03_06:11:31.91593 github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request.(*Request).EachPage(0xc4ae8b2700, 0xc4a88ffb60, 0x2, 0x2)
2017-11-03_06:11:31.91593       /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/aws/request/request_pagination.go:98 +0xa1
2017-11-03_06:11:31.91594 github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2.(*EC2).DescribeInstancesPages(0xc48427e3f8, 0x0, 0xc48752bca0, 0x0, 0x0)
2017-11-03_06:11:31.91595       /go/src/github.com/prometheus/prometheus/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:6784 +0x11a
2017-11-03_06:11:31.91596 github.com/prometheus/prometheus/discovery/ec2.(*Discovery).refresh(0xc4403fd6d0, 0xc5143daae0, 0x0, 0x0)
2017-11-03_06:11:31.91596       /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:163 +0x3c8
2017-11-03_06:11:31.91597 github.com/prometheus/prometheus/discovery/ec2.(*Discovery).Run(0xc4403fd6d0, 0x7f21e342a340, 0xc4684f57c0, 0xc45219dce0)
2017-11-03_06:11:31.91597       /go/src/github.com/prometheus/prometheus/discovery/ec2/ec2.go:119 +0x219
2017-11-03_06:11:31.91598 created by github.com/prometheus/prometheus/discovery.(*TargetSet).updateProviders
2017-11-03_06:11:31.91598       /go/src/github.com/prometheus/prometheus/discovery/discovery.go:249 +0x26f

@mjibson @federicobaldo @dominikschulz @mtanda have touched this code. Any help appreciated.

The code is making several assumptions about pointers not being nil, not sure if we should check all of them against nil.


GLImpl::ResolveTextureSubresource might not behave as expected due to FBO states.

Hello, it seems there's a bug causing GLImpl::ResolveTextureSubresource not behaving correctly. (I'm not using the newest version, but glancing through the code, it seems the bug hasn't been fixed)
The implementations calls FBOCache.GetFBO() to retrieve two FBOs and bind each of them to GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER. The problem is that, FBOCache.GetFBO may create a branch new FBO in place, and when doing that it overwrites GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER by ContextState.BindFBO(FBO);. In this case GL_READ_FRAMEBUFFER no longer points to the correct buffer.
It seems this bug usually only lasts for one frame only. When FBO is cached, all is well then. But for my use cases, sometimes i need the first frame, and i'll retrieve the incorrect one.

Probably same as https://github.com/DiligentGraphics/DiligentEngine/issues/164

Yes, it seems it's the same issue. My local bugfix is backup and restore GL_DRAW_FRAMEBUFFER and GL_READ_FRAMEBUFFER and FBOId when creating a new FBO though.


Added FAQ for Syncing State and props

Added about usage of State inside FAQ.

@alexkrolick Please have a look at the changes.


Document history

Hi. We have integrated NextCloud 12 with ONLYOFFICE Document server 5.0.6 and at https://api.onlyoffice.com/editors/history we can see that ONLYOFFICE says:

If the document has been previously edited using Document Editor, you can view the document history.

But I can't find how to view history via the onlyoffice-owncloud app. Can you please give us some advice. How to view Document history with NC+OO?

This way the following events must be added to the config file to enable the document changes history display:

onRequestHistory with refreshHistory which contains document history for each document version if the history parameter has been present for each version.
onRequestHistoryData with setHistoryData which contains the link to the file of the corresponding version, the link to the previous version and the link to the file received using the changesUrl.

Hello @alexanderonlyoffice,
is there any news about this ?

Hello @Floflobel, the possibility of adding this feature is being considered by our development team.

Bump
Is the feature version history for an installation around Nextcloud still being considered?

Having a document history is key feature for me to work collaboratively on a document. Is this feature on the roadmap for the onlyoffice-nextcloud/owncloud integration?


ActionBarSherlock is incompatible with Appcompat

I want to use ActionBarSherlock, but I need the features of Appcompat library. For example ActionBarSherlock does not have SwitchCompat widget, which Appcompat does. Also ActionBarSherlock does not have compatibility attributes to customize color of statusbar, which are a must too.
You shouldn't force people to remove Appcompat from their project if they want to use your library, or at least implement all missing features.

It seems that AppCompat has everything you want. Why do you want to use ActionBarSherlock which was deprecated a long time ago?

@JakeWharton that should be awesome, but they do not. If you just read my question before closing it, you'd realize that ActionBarSherlock does not have a set of important features from AppCompat. But it has the SpinnerICS widget which I wanted to use. They should not be used together once one of them covers functionality of the other. Currently it does not.

That widget is in the internal package and not part of the public API.
On Feb 3, 2015 9:03 AM, "metalurgus"<EMAIL_ADDRESS>wrote:

@JakeWharton https://github.com/JakeWharton that should be awesome, but
they do not. If you just read my question before closing it, you'd realize
that ActionBarSherlock does not have a set of important features from
AppCompat. But it has the SpinnerICS widget which I wanted to use. They
should not be used together once one of them covers functionality of the
other. Currently it does not.
—
Reply to this email directly or view it on GitHub
https://github.com/JakeWharton/ActionBarSherlock/issues/1121#issuecomment-72689545
.


qtconsole launch doesn't work?

I am trying to force hydrogen-launcher to launch a qtconsole rather than console through the PlatformIO Terminal and edited the settings to force qtconsole rather than console in the Jupyter Console section. However (even after a restart of Atom), it still launches an ordinary console.
Is there something I'm missing, or is it behaving incorrectly?
The reason I want to use qtconsole is so (hopefully) I can utilize the qt backend for plots rather than having them embedded or having them pop out with some weird backend (right now, they just show up in preview on macOS). Hopefully I'm doing this right..

However (even after a restart of Atom), it still launches an ordinary console.

By "ordinary" do you mean the PlatformIO terminal?

Yes. It launches in the PlatformIO terminal, but is a console, rather than a qtconsole. Is that the expected behaviour?

Are you sure you use the command "Hydrogen Launcher: Launch Jupyter Console" (cmd-alt-j)  rather than "Hydrogen Launcher: Launch Jupyter Console in PlatformIO Terminal" (cmd-alt-shift-j)?

Ahh, I was not. So the qtconsole can't be opened in the PlatformIO Terminal then?

Oh I think I see your problem now.
AFAIK it isn't possible to have a embedded qtconsole inside the PlatformIO Terminal, but I think we should be able to at least spawn it from there.

Just released v1.2.1 with a fix.


Add environment variables for mysqli connection params

Follow on from https://github.com/silverstripe/silverstripe-framework/issues/8871 where the PR testing instruction required overriding some code to add in params for $socket and $flags for mysqli::real_connect()
We should allow these two params to be set via environment similar whose names match the existing database connection scheme e.g. SS_DATABASE_*

Closing this as a duplicate of https://github.com/silverstripe/silverstripe-framework/issues/9394


Inside the render content when clicking custom made button it closes the story model

Inside the renderContent of the block when rendering the stories , I have made a custom button when clicked to delete a specific story. The issue is when i click it makes the story model close . Can you suggest me solution i want to be on the same story page when i am deleting it . following is my code
`  if (AllStoriesPosts && AllStoriesPosts.length > 0) {
InstaStories = AllStoriesPosts.map((story) => ({
id: story.id,
name: story.name,
imgUrl: story?.imgUrl,
  stories: story.stories.map((item) => {
    let mediaType: "video" | "image" | undefined;
    if (item.mediaType === "video" || item.mediaType === "image") {
      mediaType = item.mediaType;
    }
    return {
      id: item.id,
      mediaType: mediaType,
      sourceUrl: item.sourceUrl,
      renderContent: () => storyContent(item, story.id),
    };
  }),
}));

}`
the following is my custom made buttton inside "storyContent"
   const storyContent = (item, user_id) => {     return (       <View style={twmt-[25%] flex-row justify-between w-full p-3}>         <Text style={twfont-bold mx-2 text-base text-white}>           {item?.description}         </Text>         {auth.isAuth && auth.body._id == user_id && (           <View>             <TouchableOpacity               key={item.id}               onPress={() => deleteStory(item.id)}               style={twflex-row justify-start }             >               <Ionicons                 size={imageSizes.sm}                 color={tw.color(text-red-400)}                 name={"trash"}                 style={twmx-3 `}
/>
          {DeleteStoryLoading && deleteStoryId === item._id && (
            <View key={item?._id}>
              <ActivityIndicator
                style={tw`mx-2`}
                color={primary}
                size={"small"}
              />
            </View>
          )}
        </TouchableOpacity>
      </View>
    )}
  </View>
);

};
`

Can you send me what is you logic in deleteStory function?

My recommendation for you is something like this: (it worked for me)
import InstagramStories, { InstagramStoriesPublicMethods, InstagramStoriesProps } from '@birdwingo/react-native-instagram-stories';

const YourComponent = () => {

  const modalRef = useRef<InstagramStoriesPublicMethods>( null );

  const [ stories, setStories ] = useState<InstagramStoriesProps['stories']>();

  const renderButton = ( children: string, onPress: () => void ) => <Button onPress={onPress} radius={50}>{children}</Button>;

  const onButtonPress = ( user: string, id: string ) => {

    setStories( ( val ) => val?.map( ( story ) => ( story.id === user ? {
      ...story,
      stories: story.stories.filter( ( item ) => item.id !== id ),
    } : story ) ) );

    modalRef.current?.goToNextStory();

  };

  useEffect( () => {

    setStories( STORIES.map( ( story, index ) => ( {
      id: String( index ),
      imgUrl: story.iconUrl,
      name: story.name,
      stories: story.stories.map( ( item ) => ( {
        id: item.id,
        source: { uri: item.image },
        renderContent: () => renderButton(
          item.button!,
          () => onButtonPress( String( index ), item.id ),
        ),
      } ) ),
    } ) ) );

  }, [] );

  if ( !stories ) {

    return null;

  }

  return (
    <InstagramStories
      ref={modalRef}
      stories={stories}
      {...} // rest of the props
    />
  );

};

My recommendation for you is something like this: (it worked for me)
import InstagramStories, { InstagramStoriesPublicMethods, InstagramStoriesProps } from '@birdwingo/react-native-instagram-stories';

const YourComponent = () => {

  const modalRef = useRef<InstagramStoriesPublicMethods>( null );

  const [ stories, setStories ] = useState<InstagramStoriesProps['stories']>();

  const renderButton = ( children: string, onPress: () => void ) => <Button onPress={onPress} radius={50}>{children}</Button>;

  const onButtonPress = ( user: string, id: string ) => {

    setStories( ( val ) => val?.map( ( story ) => ( story.id === user ? {
      ...story,
      stories: story.stories.filter( ( item ) => item.id !== id ),
    } : story ) ) );

    modalRef.current?.goToNextStory();

  };

  useEffect( () => {

    setStories( STORIES.map( ( story, index ) => ( {
      id: String( index ),
      imgUrl: story.iconUrl,
      name: story.name,
      stories: story.stories.map( ( item ) => ( {
        id: item.id,
        source: { uri: item.image },
        renderContent: () => renderButton(
          item.button!,
          () => onButtonPress( String( index ), item.id ),
        ),
      } ) ),
    } ) ) );

  }, [] );

  if ( !stories ) {

    return null;

  }

  return (
    <InstagramStories
      ref={modalRef}
      stories={stories}
      {...} // rest of the props
    />
  );

};

Thanks but can you suggest any other code suggestion as this one i understood but i dont want to add the data in useState.

Oh, right, I think you could use modalRef.current?.setStories(). So basically as a prop to component you will give default stories and then you can set the new ones (filtered after delete) with modalRef.current?.setStories(...). I think it should work the same way. If it doesn't work, I will think about adding new method to delete story.

Hello, did it help or is there something needed from my side?

Hello, did it help or is there something needed from my side?

Can Suggest other way of doing this if possible

I can't think of any other soulution

maybe you can detect in renderContent any action method like onpress of dispatched than not to close the stories modal.
`
return {
id: item.id,
mediaType: mediaType,
sourceUrl: item.sourceUrl,
renderContent: () => storyContent(item, story.id),
};
      const storyContent = (item, user_id) => {
return (
  <View style={tw`mt-[25%] flex-row justify-between w-full p-3`}>
    <Text style={tw`font-bold mx-2 text-base text-white`}>
      {item?.description}
    </Text>
    {auth.isAuth && auth.body._id == user_id && (
      <View>
        <TouchableOpacity
          key={item.id}
          onPress={() => deleteStory(item.id)}
          style={tw`flex-row justify-start `}
        >
          <Ionicons
            size={imageSizes.sm}
            color={tw.color(`text-red-400`)}
            name={"trash"}
            style={tw`mx-3 `}
          />

          {DeleteStoryLoading && deleteStoryId === item._id && (
            <View key={item?._id}>
              <ActivityIndicator
                style={tw`mx-2`}
                color={primary}
                size={"small"}
              />
            </View>
          )}
        </TouchableOpacity>
      </View>
    )}
  </View>
);

};
`


Review v.0.3.x Examples

Review v.0.3 Examples

[x] /basic_example

[ ] /electrical
need pygraphviz, will check on tuesday (11.06.2019)

[x] /emission_constraint

[ ] /excel_reader
could not check plots (no pygraphviz)

[x] /flexible_modelling

[x] /generic_chp

[x] /installation_test

[x] /invest_non_convex

[x] /min_max_runtimes

[x] /plotting_examples

[x] /simple_dispatch

[x] /start_and_shutdown_costs

[x] /storage_balanced_unbalanced

[x] /storage_investment

[x] /variable_chp

https://github.com/oemof/oemof-examples/commit/0b76b8408aa868530b1611b7fad4d257786222a3 fixes some of the problems in examples. Missing parts can be found above, under non checked tasks.

e21f33ded1ab079824a04a651ca06ec00e2081cb removes empty __init__.py files.

5e762fe3cc0a0fab160b62f66a9c2234f1317854 fixes Figure 3 and Figure 4 x-labels in storage.py. Before rot=0, the x-labels were out of the figure.
Line [132, 133] can be removed, if it is wanted to have x-labels 'storage_elec_balanced', instead of 'balanced'.  However than, x-labels are overlapping if figure is not maximized (full-screen).

b82c3b6c7f6a4f2a2a9d508ad3e29d4e96650762 adds copyright and license string to all of the examples. The structure of the doc-strings are changed to have same kind of syntax. An empty __init__.py file is removed. Documentation/comments for emission_constraint.py is added.

The empty __init__.py is actually there for a reason: You may include files in directories, where an __init__.py is present, regardless of the contents of that file.

so should we add __init__.py to all of the examples, if that was the intention?

Well, maybe not in this case. I don't see that someone imports the examples. However, it's not an argument that __init__.py was empty.
BTW: Great work! Thanks.

Unfortunately I could not make graphviz function, so someone should run /electrical and /excel_reader plots, and check if they are correct.
Additionally I will add /jupyter_examples of v.0.2.x into v.0.3.x.

e1b922473176c7690cf7cfadc43c4cfca314ff93 adds the /jupyter_examples of oemof v0.2.x into v0.3.x.
One file 3_Draw_network_graph is excluded from the commit, because it was not running. Under section Create Graph, following error is present:
KeyError: "<oemof.solph.network.Transformer: 'pp_chp'>"
I am guessing it is because of the oemof.graph module. So either we remove the chp plant from the file 1_Simple_dispatch_store_results.ipynb or some changes have to be done in oemof.graph module.

I will close this Issue.


replace links with react-router's <Link

Is that possible?

Yep, see custom component example in README. Just use <Link> instead of <Tag>.

Thanks. That worked!


Tidy up notebook

Codecov Report

Merging #698 into hugh/advanced_usage_notebook will not change coverage.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           hugh/advanced_usage_notebook     #698   +/-   ##
=============================================================
  Coverage                         98.09%   98.09%
=============================================================
  Files                                48       48
  Lines                              4105     4105
=============================================================
  Hits                               4027     4027
  Misses                               78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a1b09...574a5e9. Read the comment docs.


Delete vlc-remote.rb

Refs https://github.com/caskroom/homebrew-cask/issues/6872. Seems to not be popular enough to cause much disruption. If submitted again, it needs to have the uninstall steps.

Fine with me.
PS: @vitorgalvao did you get my email?

@miccal I did. It isn’t forgotten, I just didn’t have the time to go through the reply properly yet, but will soon.

Thanks @vitorgalvao.


S3 multipart upload not working

I'm using moto to write tests.
the following code works and the call is correctly mocked:
s3 = boto3.client('s3')
s3.upload_file(Bucket='bucket', Key='out_name', Filename=SMALL_FILE)

while if I try with a large file, it fails because of timeout error:
s3 = boto3.client('s3')
s3.upload_file(Bucket='bucket', Key='out_name', Filename=LARGE_FILE)

----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/my_test.py", line 51, in test_my_function
    my_module.my_function(event, None)
  File "my_module.py", line 49, in my_function
    s3.upload_file(Bucket='bucket', Key='out_name', Filename=LARGE_FILE)
  File "anaconda/lib/python2.7/site-packages/boto3/s3/inject.py", line 84, in upload_file
    extra_args=ExtraArgs, callback=Callback)
  File "anaconda/lib/python2.7/site-packages/boto3/s3/transfer.py", line 639, in upload_file
    self._multipart_upload(filename, bucket, key, callback, extra_args)
  File "anaconda/lib/python2.7/site-packages/boto3/s3/transfer.py", line 733, in _multipart_upload
    uploader.upload_file(filename, bucket, key, callback, extra_args)
  File "anaconda/lib/python2.7/site-packages/boto3/s3/transfer.py", line 390, in upload_file
    MultipartUpload={'Parts': parts})
  File "anaconda/lib/python2.7/site-packages/botocore/client.py", line 278, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "anaconda/lib/python2.7/site-packages/botocore/client.py", line 572, in _make_api_call
    raise ClientError(parsed_response, operation_name)
ClientError: An error occurred () when calling the CompleteMultipartUpload operation:
-------------------- >> begin captured logging << --------------------
botocore.credentials: DEBUG: Skipping environment variable credential check because profile name was explicitly set.
botocore.credentials: DEBUG: Looking for credentials via: env
botocore.credentials: DEBUG: Looking for credentials via: assume-role
botocore.credentials: DEBUG: Looking for credentials via: shared-credentials-file
botocore.credentials: DEBUG: Looking for credentials via: config-file
botocore.credentials: DEBUG: Looking for credentials via: ec2-credentials-file
botocore.credentials: DEBUG: Looking for credentials via: boto-config
botocore.credentials: DEBUG: Looking for credentials via: container-role
botocore.credentials: DEBUG: Looking for credentials via: iam-role
botocore.vendored.requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): <IP_ADDRESS>
botocore.utils: DEBUG: Caught exception while trying to retrieve credentials: HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /latest/meta-data/iam/security-credentials/ (Caused by ConnectTimeoutError(<botocore.awsrequest.AWSHTTPConnection object at 0x110f29150>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=1)'))
Traceback (most recent call last):
  File "anaconda/lib/python2.7/site-packages/botocore/utils.py", line 159, in _get_request
    response = requests.get(url, timeout=timeout)
  File "anaconda/lib/python2.7/site-packages/botocore/vendored/requests/api.py", line 69, in get
    return request('get', url, params=params, **kwargs)
  File "anaconda/lib/python2.7/site-packages/botocore/vendored/requests/api.py", line 50, in request
    response = session.request(method=method, url=url, **kwargs)
  File "anaconda/lib/python2.7/site-packages/botocore/vendored/requests/sessions.py", line 465, in request
    resp = self.send(prep, **send_kwargs)
  File "anaconda/lib/python2.7/site-packages/botocore/vendored/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "anaconda/lib/python2.7/site-packages/botocore/vendored/requests/adapters.py", line 419, in send
    raise ConnectTimeout(e, request=request)
ConnectTimeout: HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /latest/meta-data/iam/security-credentials/ (Caused by ConnectTimeoutError(<botocore.awsrequest.AWSHTTPConnection object at 0x110f29150>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=1)'))
botocore.utils: DEBUG: Max number of attempts exceeded (1) when attempting to retrieve data from metadata service.
botocore.loaders: DEBUG: Loading JSON file: anaconda/lib/python2.7/site-packages/botocore/data/endpoints.json
botocore.loaders: DEBUG: Loading JSON file: anaconda/lib/python2.7/site-packages/botocore/data/s3/2006-03-01/service-2.json
botocore.loaders: DEBUG: Loading JSON file: anaconda/lib/python2.7/site-packages/botocore/data/_retry.json
botocore.client: DEBUG: Registering retry handlers for service: s3
botocore.hooks: DEBUG: Event creating-client-class.s3: calling handler <function add_generate_presigned_post at 0x110e63050>
botocore.hooks: DEBUG: Event creating-client-class.s3: calling handler <function _handler at 0x110c0c578>
botocore.hooks: DEBUG: Event creating-client-class.s3: calling handler <function add_generate_presigned_url at 0x110e63e60>
botocore.client: DEBUG: The s3 config key is not a dictionary type, ignoring its value of: None
botocore.endpoint: DEBUG: Setting s3 timeout as (60, 60)
An error occurred () when calling the CompleteMultipartUpload operation:
--------------------- >> end captured logging << ---------------------

any idea why?

By default, boto3 is going to try to use multiple threads to upload large files.
The following should work:
from boto3.s3.transfer import TransferConfig

s3.upload_file(Bucket='bucket', Key='out_name', Filename=LARGE_FILE, Config=TransferConfig(use_threads=False))

Please reopen if it doesn't.


backside css problems

[x] list is not clickable in chrome (first image)
[x] no scrolling with the touchpad in firefox, only when using the small scroll bar
[ ] again it is very slow for some of us

Personally not having speed issue on back side re-render. @johannahaha can you confirm it's fixed?


[WIP] Implement Create VM Wizard component

thanks! do you mind publishing the storybook?

@ohadlevy where should I publish it ? github pages of my forked repo ?

github pages of my forked repo

Seems to be best option. It will stay close to each PR.
And we can maintain storybook for master.

@mareklibra OK, I will go with the github pages. Just be aware that github pages is using gh-pages or master branch. Which means you can have only one github page for repository. It will work for now, as I have only one PR but if I will have more open PRs I wont be able to host storybook for each of them.

yeah, best is to use rawgit (so you can push multiple branches), have a
look at pf-react for the npm task (i think its storybook-deployer)
On Tue, Aug 28, 2018 at 3:45 PM rawagner<EMAIL_ADDRESS>wrote:

@mareklibra https://github.com/mareklibra OK, I will go with the github
pages. Just be aware that github pages is using gh-pages or master branch.
Which means you can have only one github page for repository. It will work
for now, as I have only one PR but if I will have more open PRs I wont be
able to host storybook for each of them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/web-ui/pull/4#issuecomment-416570037, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABOxzGMxoQzKzA0vAGmMtRi6NSCsK6iks5uVTtpgaJpZM4WPdLt
.

do we have a group of UX developers so we can ping them to look at the
stroybook?
On Tue, Aug 28, 2018 at 4:20 PM rawagner<EMAIL_ADDRESS>wrote:

@ohadlevy https://github.com/ohadlevy thanks! Storybook is published at
https://rawgit.com/rawagner/web-ui/create_VM_wizard_storybook/index.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/web-ui/pull/4#issuecomment-416581213, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABOxxXHlcl98q7JaNPcoaGnKFzS32THks5uVUOUgaJpZM4WPdLt
.

@lizsurette

@rawagner
Agreed with others, this is looking great! A few overall comments:

When the user selects a provision source, what do you think about removing the indentation for any fields that are added? I think it will read better if they are inline. (Similar to how the fields show when the Enable cloud-init box is checked.

Would it be possible to split the OS field into Operating System and Version? I got some feedback that this list could get super long if we leave it as one. Of course this would mean that depending on which OS is selected, the versions would need to be updated.

Although it might be annoying to need two different styles, could we tighten up the padding between the check box options at the bottom of the Basic Settings steps? Maybe just allow them to live within one form-group if possible?

note its used below, so  I guess it should be used consistently.
On Wed, Aug 29, 2018 at 5:26 PM suomiy<EMAIL_ADDRESS>wrote:

@suomiy commented on this pull request.
In src/components/wizards/new-vm/NewVmWizard.js
https://github.com/kubevirt/web-ui/pull/4#discussion_r213698947:

render() {

 let wizard;

 if(this.state.createVM) {

   wizard = <CreateVmWizard onHide={this.props.closeWizard} {...this.props}/>

 } else if(this.state.importVM) {

   wizard = <ImportVmWizard onHide={this.props.closeWizard} {...this.props}/>

 }

 return (

   <React.Fragment>

     <Wizard show onHide={this.props.closeWizard}>

       <Wizard.Header title="Create Virtual Machine" onClose={this.props.closeWizard} />

       <Wizard.Body>

         <Wizard.Row>

           <Wizard.Main>

             <Wizard.Contents stepIndex={0} activeStepIndex={0} className="wizard-content">

               <button className="btn btn-link wizard-button " onClick={this.openCreateVmWizard}>

there is, but I don't think it is needed so much. I just meant lines 33-40
altogether .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/web-ui/pull/4#discussion_r213698947, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABOx-mnjdsstQsqWmXvrQtq6FF-8W9kks5uVqSTgaJpZM4WPdLt
.

there is, but i still think its a better practice to get used to instead of
importing all of it.
On Wed, Aug 29, 2018 at 5:36 PM Vojtech Szocs<EMAIL_ADDRESS>wrote:

@vojtechszocs commented on this pull request.
In src/components/wizards/create-vm/CreateVmWizard.js
https://github.com/kubevirt/web-ui/pull/4#discussion_r213703086:

@@ -0,0 +1,228 @@
+import React from 'react';
+import {

Form,
Wizard
+} from 'patternfly-react';
+import './CreateVmWizard.css';
+import * as _ from 'lodash';

IIRC there are webpack plugins to address these kinds of optimization
issues, I will look into that later on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/web-ui/pull/4#discussion_r213703086, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABOx-279HZf9SAL-aDEoAqzy9O93KVaks5uVqbygaJpZM4WPdLt
.

Would it be possible to split the OS field into Operating System and Version? I got some feedback that this list could get super long if we leave it as one. Of course this would mean that depending on which OS is selected, the versions would need to be updated.

It makes sense, but I would leave it until we know that we get this kind of information from the API - which will be preset os labels.

not before tectonic migration please..
On Wed, Aug 29, 2018 at 5:49 PM Vojtech Szocs<EMAIL_ADDRESS>wrote:

@vojtechszocs commented on this pull request.
In src/components/wizards/new-vm/NewVmWizard.js
https://github.com/kubevirt/web-ui/pull/4#discussion_r213708514:

 let wizard;

 if(this.state.createVM) {

   wizard = <CreateVmWizard onHide={this.props.closeWizard} {...this.props}/>

 } else if(this.state.importVM) {

   wizard = <ImportVmWizard onHide={this.props.closeWizard} {...this.props}/>

 }

 return (

   <React.Fragment>

     <Wizard show onHide={this.props.closeWizard}>

       <Wizard.Header title="Create Virtual Machine" onClose={this.props.closeWizard} />

       <Wizard.Body>

         <Wizard.Row>

           <Wizard.Main>

             <Wizard.Contents stepIndex={0} activeStepIndex={0} className="wizard-content">

               <button className="btn btn-link wizard-button " onClick={this.openCreateVmWizard}>

                 <div className="col-md-12">

Yup, we should use patternfly-react's Grid, Row and Col components
instead of plain HTML/CSS markup.
Also, at some point, we'll transition to patternfly-react v4 which will
implement its own grid system.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/web-ui/pull/4#discussion_r213708514, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABOxx4KVaujoCKgD17iLtJPqgxAdX1iks5uVqnlgaJpZM4WPdLt
.

@lizsurette

When the user selects a provision source, what do you think about removing the indentation for any fields that are added? I think it will read better if they are inline. (Similar to how the fields show when the Enable cloud-init box is checked.

No problem, I saw it in earlier version of Create VM design. It is now removed, less work for me :)

Would it be possible to split the OS field into Operating System and Version? I got some feedback that this list could get super long if we leave it as one. Of course this would mean that depending on which OS is selected, the versions would need to be updated.

as @suomiy said, lets wait for API updates, we will change it then. I agree that if we should list all possible values into one dropdrown, it would be a huge one..

Although it might be annoying to need two different styles, could we tighten up the padding between the check box options at the bottom of the Basic Settings steps? Maybe just allow them to live within one form-group if possible?

I will, TODO

@lizsurette

Although it might be annoying to need two different styles, could we tighten up the padding between the check box options at the bottom of the Basic Settings steps? Maybe just allow them to live within one form-group if possible?

checkboxes are tighter now. You can take a look if you want, storybook is updated.

No problem, I saw it in earlier version of Create VM design. It is now removed, less work for me :)

Latest update looks great! Glad it's even less work, too :)

as @suomiy said, lets wait for API updates, we will change it then. I agree that if we should list all possible values into one dropdrown, it would be a huge one..

Makes sense to wait on API updates for this.

checkboxes are tighter now. You can take a look if you want, storybook is updated.

Looks great! Thanks :)

can you please rebase? so travis tests can be enabled for the repo? thanks

opened/closed to trigger CI.

Added some enzyme tests.
@ohadlevy any suggestions on what should we use for code coverage metrics ?

@rawagner https://github.com/kubevirt/web-ui/pull/16

Pull Request Test Coverage Report for Build 24

118 of 165 (71.52%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+55.1%) to 64.202%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/buttons/ButtonWithIcon.js
2
3
66.67%

src/components/wizards/import-vm/ImportVmWizard.js
1
5
20.0%

src/components/forms/FormControls.js
8
14
57.14%

src/components/wizards/create-vm/CreateVmWizard.js
29
37
78.38%

src/components/wizards/new-vm/NewVmWizard.stories.js
0
12
0.0%

src/k8s/request.js
37
53
69.81%

Totals

Change from base Build 23:
55.1%

Covered Lines:
120

Relevant Lines:
179

💛  - Coveralls

Latest PR updates code coverage configuration to exclude *.stories.js files

@rawagner thanks, it looks like there is a snapshot out of date + css linting errors in the tests.

I've got some infra changes coming up that will help formalize the project structure and conventions, including tools for validation and consistent usage of other tools (like using one Babel config for webpack, Jest and Storybook).

I refactored FormFactory.js, FormControls and CreateVmWizard.js in the followup. So if somebody notices something in there, we can discuss it in #10 :) and proceed with merging this PR.

Pull Request Test Coverage Report for Build 55

146 of 161 (90.68%)  changed or added relevant lines in 15 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-10.8%) to 89.224%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/buttons/ButtonWithIcon.js
2
3
66.67%

src/components/forms/Dropdown.js
4
5
80.0%

src/k8s/request.js
54
57
94.74%

src/components/wizards/import-vm/ImportVmWizard.js
1
5
20.0%

src/components/wizards/create-vm/CreateVmWizard.js
32
38
84.21%

Totals

Change from base Build 72:
-10.8%

Covered Lines:
147

Relevant Lines:
162

💛  - Coveralls

deprecated by https://github.com/kubevirt/web-ui-components/pull/27


Fix LABEL_REPEATED equals bug

Incorrect list comparison in Message.equalsMessage()

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@mihanvr
Thanks for your contribution.
This project still in work in process, we are focused on the feature and stability.
We are planned to add more unit tests in the future to avoid obvious bugs like this.
If you have any problem when you use the Sisyphus, feel free to open an issue or PR.


Enabling paging

Can't seem to enable paging at all. Crashes with reason [SpreadsheetView.SpreadsheetView _adjustedVerticalOffsetPinnedToScrollableBounds:]: unrecognized selector sent to instance 0x7f9a34f20d20

What's version of iOS?

iOS 10.2

@lukejones1 Could you provide reproducible sample code? I cannot reproducible the crash.

Not doing anything new as such.  I've just added the minimum requirements to get started.
class ViewController: UIViewController {

lazy var spreadsheetView : SpreadsheetView = {
    let view = SpreadsheetView()
    view.delegate = self
    view.dataSource = self
    view.showsHorizontalScrollIndicator = false
    view.intercellSpacing = CGSize(width: 0, height: 0)
    return view
}()

override func viewDidLoad() {
    super.viewDidLoad()
    spreadsheetView.isPagingEnabled = true
    setupViews()
}

func setupViews() {
    view.addSubview(spreadsheetView)
    spreadsheetView.fillSuperview()
}
}

extension ViewController: SpreadsheetViewDataSource, SpreadsheetViewDelegate {

func numberOfColumns(in spreadsheetView: SpreadsheetView) -> Int {
    return 4
}

func numberOfRows(in spreadsheetView: SpreadsheetView) -> Int {
    return 24
}

func spreadsheetView(_ spreadsheetView: SpreadsheetView, widthForColumn column: Int) -> CGFloat {
    if column == 0 {
        return 40
    } else {
        return view.frame.width - 40
    }
}

func spreadsheetView(_ spreadsheetView: SpreadsheetView, heightForRow row: Int) -> CGFloat {
    return 60
}

func frozenColumns(in spreadsheetView: SpreadsheetView) -> Int {
    return 1
}
}

The crash occurs when I scroll horizontally to the last column

Thanks. I'll look into it tonight.

I tried this too, and the error is pretty much the same.


Possible bug with "use inventory item" feature

A situation was reported when a pizza was eaten ("Use"), but nothing happened: the voice was not played and the subtitles were not displayed. The issue didn't happen again by far. We should keep an eye on it. After a reasonable amount of attempts this issue can be closed.

The demo game was tested many times since the issue was reported, and it could not be reproduced.


docs: Correct doc links following examples/tests re-org

Description

Correct doc links following examples/tests re-org

Motivation and Context

Resolves #3185

Breaking Changes

No

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 20.26.1 :tada: