wasm?

Hi Henry,
found this well-written implementation, great work.
Was looking for browser implementation of datagram scanner I could use in a lab.
So as an idea, maybe you'll be interested in compiling your library to web assembly. At least in theory, that should keep close-to-rust speed while allowing to use right from the browser.
Just an idea, feel free to close the issue.

I'll look into this. I'm not particularly familiar with wasm at this point, so a little research would be necessary. Off the top of my head I see a few potential issues:

My limited understanding of wasm suggests that it works best with no_std libraries, which rxing currently is not. I have some future plans to move rxing to no_std, but those don't have a timeline yet.
The current version is really only well tested when using images from the image crate as an input source. I don't think that would be the preferred way to handle things in a wasm library, at least in part because the image crate is pretty large.

I'll look into it.

I've done a little experimentation, though a bit more is needed. The library compiles to wasm just fine, and I was able to get a simple barcode generator working without too much work.
I'll play around with it and see if I can make a realistic wasm binding library for decode.

Do you have a sample barcode you would want to decode? What sorts of formats are you looking at decoding, what input formats do you have available.
My preliminary idea is to make a very simple npm package that provides methods for:

Encoding barcodes to any of the supported formats, though what output format would be provided I haven't settled on.
Decoding a single barcode in an image defined by an array of luma8 values. This skips the (much less performant) code that handles multiple barcodes in a single image.

Single barcode is completely fine.
I am looking for ECC implementations that can handle DMRE: https://www.e-d-c.info/en/projects/dmre-en.html
It is the only format I found which is non-square, and for vials/tubes rectangular barcode is better.
This single-page example exposes image as a bytestream + dimensions, and I believe that's just RGB values interleaved. Converting to luminosity-only is completely fine to me
<!DOCTYPE html>

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Demo - Capture Photo From Webcam Using Javascript</title>

<meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,user-scalable=no">

<button id="start-camera">Start Camera</button>
<video id="video" width="320" height="240" autoplay=""></video>
<button id="click-photo">Click Photo</button>

    <canvas id="canvas" width="320" height="240"></canvas>

Image Data URL

    <textarea id="dataurl" readonly=""></textarea>

very early initial version (0.1.0) available on npm: https://www.npmjs.com/package/rxing-wasm
the detection code for datamatrix behaves oddly when the images provided to it are small, so keep that in mind.
I'd call it an early beta release.

so far no success in detecting anything in js, likely doing something wrong
I've tested on QR codes, and it almost always just throws an exception "Not Found",
in very rare cases it throws "Unreachable", which is probably equal to panic in rust.
I've set equal dimensions to height and width (480x480) in case there is some mismatch in element ordering, but nothing changed.
I use following functions (checked that output looks sane):
function convertCanvasToGrayscale(canvas) {
    let context = canvas.getContext('2d');
    let height = canvas.height;
    let width = canvas.width;
    let imageData = context.getImageData(0, 0, width, height);

    let data = imageData.data;
    let array = new Uint8Array(data.length / 4);
    // get only the red channel
    for (let i = 0; i < array.length; i += 1) {
        array[i] = data[i * 4];
    }
    return {array, width, height};
}

function convertCanvasToUint32(canvas) {
    let context = canvas.getContext('2d');
    let height = canvas.height;
    let width = canvas.width;
    let imageData = context.getImageData(0, 0, width, height);

    let data = imageData.data;
    console.assert(data.length === width * height * 4);
    let array = new Uint32Array(width * height);
    for (let i = 0; i < array.length; i += 1) {
        array[i] = data[i * 4] + (data[i * 4 + 1] << 8) + (data[i * 4 + 2] << 16) + (data[i * 4 + 3] << 24);
    }
    return {array, width, height};
}

outputs are used like this:
        const {array, width, height} = convertCanvasToGrayscale(canvas);
        let parsedBarcode = decode_barcode(array, width, height);

or

        const {array, width, height} = convertCanvasToUint32(canvas);
        let parsedBarcode = decode_barcode_rgb(array, width, height);

encoding into ascii works without issues

I generated the below qrcode and tested it with the rust luma8 decoder. It didn't have any issue decoding it, but I admit to not having tested that as extensively as the image decoder. You might try using it as the input.
Here is the luma conversion that rxing (and zxing) use internally when an image is used as the source:
Luma([((306 * (red as u64)
                    + 601 * (green as u64)
                    + 117 * (blue as u64)
                    + 0x200)
                    >> 10) as u8])

You might try using that as your conversion.
For rgb images the conversion from u32 uses the following bit shifts:
for offset in 0..size {
            //for (int offset = 0; offset < size; offset++) {
            let pixel = pixels[offset];
            let r = (pixel >> 16) & 0xff; // red
            let g2 = (pixel >> 7) & 0x1fe; // 2 * green
            let b = pixel & 0xff; // blue
                                  // Calculate green-favouring average cheaply
            luminances[offset] = ((r + g2 + b) / 4).try_into().unwrap();
        }

There are a lot of weird issues with the datamatrix decoder, most of which I think are present in the original java. It detects datamatrix codes perfectly, but then when it comes to grid sampling them it gives up some strange data. It's the same code used by both the qrcode and aztec components, which handle it fine, so I suspect it's an issue with how the datamatrix decoder handles the input. I'm still poking at it.
If the barcodes are "pure" barcodes, that is, the image contains nothing but a barcode, then the decoder works perfectly (though that requires a bit of extra config for the decoder to know that they're "pure" barcodes).
For a simpler (no wasm) interface you could also look at: https://github.com/zxing-js/library and https://github.com/LazarSoft/jsqrcode
Sample qrcode (verified to decode with luma8) (verified in rust)

Sample raw luma bytes, verified to decode with the luma8 source (80x80 image) (in rust)
luma_raw.txt

I also have a potential fix for datamatrix reading, but still implementing

I've created a sample BW barcode too, it should be readable without doubt - but I get "unreachable" on every call, most likely this is the reason:
https://github.com/rustwasm/wasm-pack/issues/724

Ah, didn't realize SystemTime was a no go. I'll get wasm feature added to Chrono and get system time out.

https://www.npmjs.com/package/rxing-wasm should enable the correct features in chrono crate and remove the SystemTime calls

it works now 🎉 ! Fast enough to run 10 times a second on 1024x768 (did not experiment much with sizes).
Works nicely with QR, finicky with ECC200 DMRE

I'm in the process of porting the c++ datamatrix detector. Apparently it's better in some situations.

I just pushed v0.1.2 of the npm package. After a harrowing trip into c++, rxing now includes the c++ version of the datamatrix detector (https://github.com/zxing-cpp/zxing-cpp). From my initial testing it's much better at finding symbols, especially when those symbols are small, have very slim borders. It seems specifically more likely to work with DMRE codes, but I don't have a ton to test with.

that's great news, thank you!
I am about to test this in a lab, currently experiencing unrelated issues with deployment 😅
Will follow up after I fix things.

Yup rxing does a good job at detecting datamatrix, great work @hschimke!
Will use rectangular barcodes now  🎉 .

I pushed out v0.1.4 of the NPM package, which allows the use of DecodeHints. This might be helpful if you wanted to limit the types of barcodes being searched for. I haven't benchmarked, but my guess would be that it might speed up detection (possibly by a lot).

great, thanks for letting know. Will test this soon

I have a couple fixes I'm backporting from c++ this weekend too (all datamatrix related). They will all be rolled up in the 0.1.5 realease on npm once I'm done.

integrated both luma conversion and decode hints (I've left only two types: QR and datamatrix).
All works, does not react to other types of barcodes.
Very crude estimate ~ approximately twice lower CPU load judging by profiler peaks.

Watch out for versions 0.1.7 - 0.1.11. A change in some dependencies has caused some havoc I'm still sorting out. I suggest pinning to 0.1.6

This is resolved with npm version 0.1.12, apparently I didn't correctly pin the wasm_bindgen dependency in my deployment environment, so it worked fine in test and then deployed with an update that broke things, oops!


Change mongodb-extended-json dep to upstream version

Ran the carbond tests with this and mongodb-extended-json 1.10.0 - everything looked okay.


Can not change UART3 to UART1

ros2 run micro_ros_setup configure_firmware.sh ping_pong --transport serial --dev 1
After execute this and build the firmware, ROS can still get message from UART3 instead of UART1.
It seems that only UART3 has DMA configured in stm32f4xx_hal_msp.c.

Please detail which is your setup and which are the board you are using.

Reopen if still active issue.


Bedrock does not support >4096 tokens for Claude 3.5

I'm using AnthropicBedrock and model=eu.anthropic.claude-3-5-sonnet-20240620-v1:0. I want to use max_tokens=8192. However there is an implicit cap of 4096 tokens.
While boto3 will throw an error if you set max_tokens to something greater than 4096, the anthropic python sdk does not. However, there is still a limit of ~4096 tokens for the Claude 3.5 model. I assume it's because in the backend anthropic is using the AWS's Converse API, where probably the source of the issue is (see: https://github.com/boto/boto3/issues/4279#issuecomment-2361634590).
My setup:
from anthropic import AnthropicBedrock
from *** import AWS_ACCESS_KEY_ID, AWS_REGION, AWS_SECRET_ACCESS_KEY

client = AnthropicBedrock(
    aws_access_key=AWS_ACCESS_KEY_ID,
    aws_secret_key=AWS_SECRET_ACCESS_KEY,
    aws_region=AWS_REGION,
)

message = client.messages.create(
    model="eu.anthropic.claude-3-5-sonnet-20240620-v1:0",
    max_tokens=8192,
    system="Some system message",
    messages=[{"role": "user", "content": "Hello, world"}]
)

Given a much larger message, see below my log messages of the input and output tokens used for each run.
input 28400 output 4089
Iteration 1 - max tokens reached, continuing...
input 32527 output 4088
Iteration 2 - max tokens reached, continuing...
input 36654 output 4094
Iteration 3 - max tokens reached, continuing...
input 40781 output 4093
Iteration 4 - max tokens reached, continuing...
input 44908 output 4089
Iteration 5 - max tokens reached, continuing...
input 49035 output 4095
Iteration 6 - max tokens reached, continuing...
input 53162 output 3958

Hi @cfernhout, it's true that Bedrock does not support >4096 today. I'm able to reproduce the behavior of the Bedrock API (this is directly calling it, not via the Converse API) silently lowering your max_tokens to 4096 and not throwing an error.
I've passed this issue along to the team in charge of this API, but will caution that it's something unlikely to be easily changed as adding validation now could break some current users that expect this behavior. If it can't be fixed, at the very least I'd like to get this explicitly documented.
Closing this as the issue is not specific to the SDK. Thanks for reporting!


Review documentation with the last changes

What is the expected enhancement?
Review test/doc to verify that everything is working and it has applied the last changes from Qiskit Serverless.

@akihikokuroda almost fixed this issue with the refactorization of V2 primitives, thank you!


Amazon SQS doesn't send event in message_attributes

Problem
When using the SQS service, it doesn't send which event was fired as part of the Message Attributes, so it's hard to determine which service event was triggered.
Solution
Change
queue.send_message(clean_for_json(payload))

to this
    sqs.send_message(
      queue_url: queue.url,
      message_body: clean_for_json(payload),
      message_attributes: {
        'X-Github-Event' => { string_value: event, data_type: 'String'}
      }
    )

I can submit a PR, but i'm not sure if this is considered a bug fix or an improvement.

CC other people in the @github/platform team for thoughts here and if there's any other way to obtain this information.

Gentle CC again for the @github/platform team to share some thoughts here.

@mikemcquaid or @github/platform,
I can submit a PR for this if it would help push it along?
Thanks!

:wave: @jwhitcraft. We have treated the lack of X-Github-Event as a bug in the past, so I think it would be okay to accept such a fix given our current contribution guidelines (which are to only accept PRs for bug fixes or security patches).
If you'd be up for submitting a pull request to solve this, we would greatly appreciate it :smile:.

@bswinnerton and @mikemcquaid
I submitted a PR for this.


Filter out ray logs

What is the expected enhancement?
Either ray logs should be filtered out by default or the user should be given the option to filter out them out. In particular, I was getting this in my logs Handshake failed with fatal error SSL_ERROR_SSL: error:1000009c:SSL routines:OPENSSL_internal:HTTP_REQUEST. and was not sure if I could ignore it. If this is something that can be safely ignored, not having it show up in the logs in the first place would be helpful.

closing as done by #963


Update our demo environment to include opentelemetry services

Cleaning up our issues post hackathon, and marking this as completed with our initial proof of concept.


Support nats streaming

Add C# support for NATS streaming

Thanks @sfrooster; Good news - this is actually under active development from the team. Stay tuned..

@sfrooster Thanks for the issue - I'm aiming to have the first release wrapped up soon, in a matter of a week or two.  I'd certainly like to hear some feedback when it is released!

@sfrooster Here you go - please see:  https://github.com/nats-io/csharp-nats-streaming

@ColinSullivan1 Great! Tried to respond to your Apcera address, but I seem to have guessed poorly...


imagesTable: create image pop up doesnt close

steps to reproduce:

create a new image
look on the images table -> po up 'your image is being created" appear
try to close this pop-up by clicking on 'x' button

actual:

the pop up could not close

this issue doesn't reproduce in Stage, I will close it for now.


fix: update npm version in travis.yml

Builds complain of npm version 5 in concert with node 12. Use npm 6 for travis.

Coverage remained the same at 87.547% when pulling 48d386e5485d76a60263b92fc474bf72acd1e093 on abutterworth-patch-1 into 9573f4c4c3bb6687dec21c49ca0aafc066798661 on master.


Report broken packages/conflicts/dead_links

What's the problem this feature will solve?
While  we heavily rely on the goodwill of the publisher/maintainer, there's still some things which can be reported by verified users and/or community.  This can help in dire situations, data corruption incidents or major conflicts.
Describe the solution you'd like
Sort of like 'wikipedia' system a discussion must be formed per each package and ability to report old or broken packages and possible conflicts or security incidents would be great with display on the main page of the package.
Like huge warning "Doesn't work with python >=3.9", "Official Repository unavailable", "Doesn't work with sqlalchemy >= 2.0" or "Maintainer unresponsive". Many other package management software systems provide EOL reminders and warnings of these kinds which are handled by the community or verified maintainers of such systems.
During installation of packages through pip it can check for reported conflicts and abort unless forced to.
Additional context
Found out one of the important software we use to report taxes stopped doing its job because sqlalchemy upgraded during software update on the system. This caused a package which was marked as ok for ANY version of sqlalchemy to fail (actually it was ok only for major release 1, thank god no corruption of data happened).
Turns out package is abandoned, the official repository listed in pypi is 404, maintainer unavailable.
As the error was traced to sqlite package and not sqlalchemy it took some time to figure out the culprit and rollback sqlalchemy.

Thanks for the issue. I think this is a duplicate of https://github.com/pypi/warehouse/issues/3896.

Closing as a duplicate of https://github.com/pypi/warehouse/issues/3896.


Code complete: automatically invoke after period

Only after short delay?
Also other auto-invoke cases?
Need to handle case where user types period, autocomplete invokes, user keeps typing, and then completions arrive: don't show autocomplete.
(Imported from Bitbucket #27 reported by maxg on 2010-06-22)

(Changed status from open to resolved.)
(phy on 2010-07-30)


coco not supported.

I tried to get this project to work using COCO, but it was implemented in an unfeasible way.
The Eval process requires a file called SMPL_subdiv.mat, but there is no indication that this file was ever written anywhere.
This project has been uploaded in an incomplete form.
Also, if you search the net, you can find SMPL_subdiv.mat on the Kaggle site, but there is no Pdist_matrix file for h5py.

It's resolved.
https://github.com/facebookresearch/DensePose/blob/main/INSTALL.md#fetch-densepose-data

It's resolved.
https://github.com/facebookresearch/DensePose/blob/main/INSTALL.md#fetch-densepose-data


Add service package for cognitiveservices/v3.1/textanalytics

Service Package Request
Service: CognitiveServices > TextAnalytics > v3.1
Language: Golang
I started using the golang package github.com/Azure/azure-sdk-for-go/services/cognitiveservices/v2.1/textanalytics to integrate with the DetectLanguage and Sentiment apis, but I overlooked the fact that it was using the older 2.1 api. I realized this once I tried to handle the output and saw that the package was returning an array of detected languages per document, whereas the newer 3.1 only returns a single detected language.
Are there any plans for an updated golang package to interface with the 3.1 api? I dug around in the preview directory, but didn't see anything that led me to believe there is.
Thanks for your time.

Thank you for using the Go SDK and providing feedback.  We are working to provide support for all of Azure in Go.  I can't say specifically when this service will be available in the Go SDK.

Hi @RickWinter  - following up on this. I see that github.com/Azure/azure-sdk-for-go/services/cognitiveservices/v2.1/textanalytics no longer exists in the source tree either.
Is supporting this for Go on the roadmap in the short term? Thank you!

@RickWinter  - Following up on this


Use ownerReferences to replace finalizers during helm uninstall

What do these changes do?
In a real k8s cluster, we find the finalizers can't work as expected, and using ownerReferences to perform cascade deletion of role and rolebinding works fine.
Related issue number

Related https://github.com/alibaba/GraphScope/pull/2208
Related https://github.com/alibaba/GraphScope/pull/2324

Codecov Report

Merging #2350 (bfb99dc) into main (6873211) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2350   +/-   ##
=======================================
  Coverage   40.03%   40.03%
=======================================
  Files          88       88
  Lines        9714     9714
=======================================
  Hits         3889     3889
  Misses       5825     5825

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6873211...bfb99dc. Read the comment docs.


use external-secrets for pyxis

pull in pyxis secret from vault using external-secrets
refer to new secret in release-strategy

/retest-required

/lgtm

/lgtm

another non-related test failure

/retest-required


certificate_authority is missing from the cloudflare_custom_hostname document page

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Not needed.
Affected resource(s)
Not needed.
Terraform configuration files
Not needed.

Debug output
Not needed.
Panic output
No response
Expected output
From the latest document page:
https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/custom_hostname
We should expect to see an argument called certificate_authority inside of ssl block, because it is a MUST have thing to set up a custom_hostname.
Further suggestion for doc page:
In the doc page, it will be very very very very helpful to have a example usage which can list out EVERY SINGLE argument that possibly can be used, just like Swagger API exmaples.
Unfortunately what we currently have now is an example with very limited arguments.
resource "cloudflare_custom_hostname" "example_hostname" {
  zone_id  = "d41d8cd98f00b204e9800998ecf8427e"
  hostname = "hostname.example.com"
  ssl {
    method = "txt"
  }
}

With the above simple example, maybe I'm not wise enough, it took me quite a while to figure out the settings block inside of the ssl block need to be
  zone_id              = var.zone_id
  hostname             = var.hostname
  custom_origin_server = var.custom_origin_server
  ssl {
    method                = var.ssl.method
    type                  = var.ssl.type
    certificate_authority = var.ssl.certificate_authority
    wildcard              = var.ssl.wildcard
    settings {
      min_tls_version = var.ssl.settings.min_tls_version
    }
  }

rather than the follow (notice the = behind the settings)
  zone_id              = var.zone_id
  hostname             = var.hostname
  custom_origin_server = var.custom_origin_server
  ssl {
    method                = var.ssl.method
    type                  = var.ssl.type
    certificate_authority = var.ssl.certificate_authority
    wildcard              = var.ssl.wildcard
    settings = {
      min_tls_version = var.ssl.settings.min_tls_version
    }
  }

Actual output
From the latest document page:
https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/custom_hostname
It didn't mention certificate_authority at all.
But it is actually available if we add this argument, it is just invisible from the doc page, with no visibility.
Steps to reproduce
Not needed.
Additional factoids
No response
References
No response

From the latest document page:
https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/resources/custom_hostname
It didn't mention certificate_authority at all.

this will be addressed once we move to automatic generation of schema fields in #923. if you'd like it sooner, you're welcome to send over a PR adding the field in the meantime.

In the doc page, it will be very very very very helpful to have a example usage which can list out EVERY SINGLE argument that possibly can be used, just like Swagger API exmaples.

we intentionally don't do this at the moment as the configuration options are far too varied by use case and don't have a great way to keep on top of them; instead we use developer documentation to show the possibilities.
we may address this in the future however nothing is planned yet.


New GPIO mode features (pin selection, erase SDK config on GPIO boot)

Hi Richard,
These are two additional GPIO mode features I added and found useful. Please let me know what you think.
Angus

Looks good. I'm without internet access at home till Monday so can't easily play and test things out for a few, but I do plan to accept the PR as soon as I get the chance to have a go with it. I did always want make it easier for people to use other GPIOs (I only did 16 because I have nodemcu devboards with a button), but never got chance and no one asked for it so far, so your effort is appreciated.

Would you mind trying out the gpio branch, I've merged in your changes with a few tweaks (nothing serious, but be nice to make sure it all still works as expected for you).

Thanks for cleaning the patch up. Looks good to me, and works fine. There's two small changes I'd suggest:
diff --git a/rboot.c b/rboot.c
index b52c420..0e95db5 100644
--- a/rboot.c
+++ b/rboot.c
@@ -341,7 +341,7 @@ uint32 NOINLINE find_image(void) {
        ets_printf("rBoot Option: Config chksum\r\n");
 #endif
 #ifdef BOOT_GPIO_ENABLED
-       ets_printf("rBoot Option: GPIO mode\r\n");
+       ets_printf("rBoot Option: GPIO mode (%d)\r\n", BOOT_GPIO_NUM);
 #endif
 #ifdef BOOT_RTC_ENABLED
        ets_printf("rBoot Option: RTC data\r\n");
diff --git a/rboot.h b/rboot.h
index 6588635..3981c37 100644
--- a/rboot.h
+++ b/rboot.h
@@ -27,7 +27,7 @@ extern "C" {
 //#define BOOT_RTC_ENABLED

 // uncomment to enable GPIO booting
-#define BOOT_GPIO_ENABLED
+//#define BOOT_GPIO_ENABLED

 // set the GPIO number used by MODE_GPIO_ROM (will
 // default to 16 if not manually set), only applicable

Oops, left that define enabled from my testing. Fixed, and added the gpio number to the message as requested. All pushed up to master. Thanks for this.


Do not escape chars as unicode

This PR changes the escape_string function to not escape higher characters. Previously, a copyright symbol © would be written as \u{a9} in the rc file, which the compiler didn't understand as escape sequence. With these changes, characters above 0x7e will not be escaped as unicode but instead written to the rc file as-is.

That's on me didn't test #12 sufficiently.


Use LTO for llvm-mos

All of the SDK targets in llvm-mos default to using LTO, which is pretty essential for getting good results out of the compiler, and accordingly represents typical use of llvm-mos.
Without LTO, any calls out to a different translation must conservatively be assumed to recurse, which disables stack frame elision. With LTO, the whole program call graph can be walked, and stack laid out program-wide, with __attribute__((leaf)) annotations in headers preventing ASM calls from disabling the optimization in the SDK.
This also allows unique zero-page regions to automatically be assigned to temporaries program wide, which can lift stack frames out of absolute memory entirely and into the zero page. This can also remove PHA/PLA sequences from function prologues/epilogues, since the registers being saved/restored can be rewritten to function-unique zero page locations, again program wide.
All this to say, LTO and the corresponding -flto-zp argument are "raison d'etre" features for llvm-mos and are completely transparent to typical users; benchmarking the compiler without them don't provide a very good indication of real-world performance.

Ah, is there a .zp section present in the linker script? -flto-zp tells the compiler how much contiguous zero page is available (not counting the imaginary registers), but that just makes it place symbols in
.zp sections to be assigned specific addresses layer by the linker.

Added -flto-zp=224.


[CWS] bump security agent policies to v0.55.0

What does this PR do?
This PR updates the security agent policies as usual in preparation of the 7.55 freeze
https://github.com/DataDog/security-agent-policies/releases/tag/v0.55.0
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


CONTRIBUITING.md file is missing

RIght now CONTRIBUITING.md file is missing in our repository , @RituKumari98 mam Assign this issue to me , I will add it. Thankyou

@RituKumari98

Duplicate #20

@suhanipaliwal ok


Incorrect Parsing of Authority Part in URLs Containing Special Characters

There is an issue with parsing the authority part of the URL wich not correctly determined if the domain part contains special characters such as #, /, or \.
This results in the authority part being identified only up to the special character, leading to incorrect parsing.
Example:
http://exa/mple.com/path. With other special characters works correctly.
Expected Behavior:
The authority part should be correctly identified as the full domain part in this case example.com
Actual Behavior:
For http://exa/mple.com/path the authority part is identified as exa.

There is an issue with parsing the authority part of the URL wich not correctly determined if the domain part contains special characters such as #, /, or \.

Those are among the characters that mark the end of an authority.

Example: http://exa/mple.com/path. With other special characters works correctly.
Expected Behavior: The authority part should be correctly identified as the full domain part in this case example.com
Actual Behavior: For http://exa/mple.com/path the authority part is identified as exa.

The authority is correctly identified as exa, and /mple.com is correctly identified as part of the pathname.
You can see on the demo page that parseUri handles this the same as URI.js and JavaScript's native URL constructor: Demo: http://exa/mple.com/path.

slevithan
Thanks for the quick reply, so is this the correct behavior or is the library copying URI.js logic ?
Is it possible to process this in any way? I would like to process such a case to check the entered domain and show an error, in this case about a wrong character in the domain.
I also noticed that in the example http://exa\mple.com/path URI.js replaces \ with /.

so is this the correct behavior or is the library copying URI.js logic ?

It is correct behavior, unrelated to any other libraries.

Is it possible to process this in any way? I would like to process such a case to check the entered domain and show an error, in this case about a wrong character in the domain.

But there is no incorrect/invalid character in the domain. Hostnames do not need to include a dot (a common example is "localhost"), and every OS I'm aware of allows dots in directory/folder names (as with "/mple.com/" in your example). Various characters definitively indicate the end of the hostname, and these include the characters you mentioned.
So I'm not sure what to suggest. You would not be merely extending parsing logic by introducing such an error--you would be disregarding the standard structure of URIs and making your code incompatible with perfectly valid URIs.
Perhaps you could check whether parseUri(str).hostname includes a dot, and throw if it doesn't. Then you'd merely be limiting yourself to a subset of valid hostnames.

I also noticed that in the example http://exa\mple.com/path URI.js replaces \ with /.

URI.js parses and normalizes URIs, which is where the difference comes from with \. parseUri is single-purpose and only parses URIs (you could apply normalization before or after parsing, if you needed that).


Deny-PublicPaaSEndpoints contains two policy definitions that IMO do not really fit to the policy initiative description

The following policy set definition https://github.com/Azure/Enterprise-Scale/blob/main/src/resources/Microsoft.Authorization/policySetDefinitions/Deny-PublicPaaSEndpoints.json labeled  Deny-PublicPaaSEndpoints contains two policy definitions that IMO do not really fit to the policy initiative description, namely:
The policy definitione ID is for Azure Key Vault should have firewall enabled. There’s a better policy that in fact disables public network access, and that is Azure Key Vault should disable public network access
[KeyVaultPublicIpDenyEffect: {](javascript:void(0)) type: "String", [metadata: {](javascript:void(0)) displayName: "Public network access should be disabled for KeyVault", description: "This policy denies creation of Key Vaults with IP Firewall exposed to all public endpoints" }, [allowedValues: [](javascript:void(0)) "Audit", "Deny", "Disabled" ], defaultValue: "Deny" }
And
[{](javascript:void(0)) policyDefinitionReferenceId: "StorageDenyPaasPublicIP", policyDefinitionId: "/providers/Microsoft.Authorization/policyDefinitions/34c877ad-507e-4c82-993e-3452a6e0ad3c", [parameters: {](javascript:void(0)) [effect: {](javascript:void(0)) value: "[parameters('StoragePublicIpDenyEffect')]" } }, groupNames: [] }
This should be really the  Storage accounts should disable public network access policy.

Hi @mezzofix , thanks for sharing. The current policies being used do work and achieve the goal, but recent enhancements in available aliases have resulted in the two new policies you've proposed as enhancements that do fit better.
We'll add your suggestion to our backlog.
Thanks again.

Addressing this issue in #1237


ENTESB-16406 Add missing bundles

Went through fuse-karaf and tried to find all of the missing bundles

Thanks @cunningt !
Just a minor revise, I think all tag should be
HEAD
in the scm section.
Freeman

Fixed the tags that Freeman mentioned


Feature/coupons

My attempt at adding native support for Stripe coupons.
Creating a coupon locally will mirror the same coupon data on your Stripe dashboard. Assigning coupons is done from the subscription :create action by setting the :koudoku_coupon_code session.

There is a dedicated gem koudoku_coupons that adds support for Stripe coupons. Did you have a look at it?

The koudoku_coupons gem seems to require older versions of rails and haml which conflicted with my project.  It seems like it would make sense to support stripe coupons as well as stripe subscriptions without having to use a plugin if we're now allowing new features.

hi @yas4891,
I had a look around but wasn't able to find the koudoku_coupons source on github. Wouldn't happen to have it handy would you.
And just out of curiousity is there any reason you'd be averse to including coupon support within Koudoku. It just seemed like functionality that put on the backburner and eventually neglected.
Cheers

See - https://github.com/andrewculver/koudoku/wiki/Koudoku-Plugins

I would very much like this feature


kotlinx.serialization.SerializationException: org.hildan.chrome.devtools.domains.accessibility.AXPropertyName does not contain element with name 'uninteresting'

Version
6.6.0-1391447
What happened?
accessibility.getFullAXTree throws when called on about any page, eg https://nothing.pcarrier.com
Reproduction and additional details
kotlinx.serialization.SerializationException: org.hildan.chrome.devtools.domains.accessibility.AXPropertyName does not contain element with name 'uninteresting'
	at kotlinx.serialization.json.internal.JsonNamesMapKt.getJsonNameIndexOrThrow(JsonNamesMap.kt:107)
	at kotlinx.serialization.json.internal.JsonNamesMapKt.getJsonNameIndexOrThrow$default(JsonNamesMap.kt:103)
	at kotlinx.serialization.json.internal.AbstractJsonTreeDecoder.decodeTaggedEnum(TreeJsonDecoder.kt:105)
	at kotlinx.serialization.json.internal.AbstractJsonTreeDecoder.decodeTaggedEnum(TreeJsonDecoder.kt:37)
	at kotlinx.serialization.internal.TaggedDecoder.decodeEnum(Tagged.kt:233)
	at kotlinx.serialization.internal.EnumSerializer.deserialize(Enums.kt:136)
	at kotlinx.serialization.internal.EnumSerializer.deserialize(Enums.kt:102)
	at kotlinx.serialization.json.internal.AbstractJsonTreeDecoder.decodeSerializableValue(TreeJsonDecoder.kt:337)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableValue(Tagged.kt:207)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableElement$lambda$1(Tagged.kt:279)
	at kotlinx.serialization.internal.TaggedDecoder.tagBlock(Tagged.kt:294)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableElement(Tagged.kt:279)
	at org.hildan.chrome.devtools.domains.accessibility.AXProperty$$serializer.deserialize(AccessibilityTypes.kt:186)
	at org.hildan.chrome.devtools.domains.accessibility.AXProperty$$serializer.deserialize(AccessibilityTypes.kt:186)
	at kotlinx.serialization.json.internal.AbstractJsonTreeDecoder.decodeSerializableValue(TreeJsonDecoder.kt:337)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableValue(Tagged.kt:207)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableElement$lambda$1(Tagged.kt:279)
	at kotlinx.serialization.internal.TaggedDecoder.tagBlock(Tagged.kt:294)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableElement(Tagged.kt:279)
	at kotlinx.serialization.encoding.CompositeDecoder$DefaultImpls.decodeSerializableElement$default(Decoding.kt:538)
	at kotlinx.serialization.internal.CollectionLikeSerializer.readElement(CollectionSerializers.kt:80)
	at kotlinx.serialization.internal.AbstractCollectionSerializer.readElement$default(CollectionSerializers.kt:51)
	at kotlinx.serialization.internal.AbstractCollectionSerializer.merge(CollectionSerializers.kt:36)
	at kotlinx.serialization.internal.AbstractCollectionSerializer.deserialize(CollectionSerializers.kt:43)
	at kotlinx.serialization.json.internal.AbstractJsonTreeDecoder.decodeSerializableValue(TreeJsonDecoder.kt:337)
	at kotlinx.serialization.internal.TaggedDecoder.decodeSerializableValue(Tagged.kt:207)
	at kotlinx.serialization.internal.TaggedDecoder.decodeNullableSerializableElement$lambda$3(Tagged.kt:288)
	at kotlinx.serialization.internal.TaggedDecoder.tagBlock(Tagged.kt:294)
	at kotlinx.serialization.internal.TaggedDecoder.decodeNullableSerializableElement(Tagged.kt:286)
	at org.hildan.chrome.devtools.domains.accessibility.AXNode$$serializer.deserialize(AccessibilityTypes.kt:324)
[…]

Kotlin target platforms
JVM (non-Android)

Thanks for the report. Which version of Chrome are you using? It seems that this value doesn't exist in the protocol definition:
https://chromedevtools.github.io/devtools-protocol/tot/Accessibility/#type-AXPropertyName

Also expect kotlinx.serialization.SerializationException: org.hildan.chrome.devtools.domains.accessibility.AXPropertyName does not contain element with name 'notRendered'

I think I'll add some lenience here. I never faced any problems with enums so far, but given what you're getting now, I think it's worth introducing an unknown synthetic value or something for cases where we get a value from the debugger that we don't know about.

If maintainers are willing to respond promptly which certainly seems to be the case so far (❤) I think adding the unknown case to enums that actually prove themselves less thoroughly documented could make sense. If forward compatibility is a goal (support recent versions of Chrome without updating the library) then yes at least anything marked experimental seems worth keeping open to new values.

Thanks! I'm doing my best to react fast, I know what it is to open issues on OSS projects and get no answer for years :)
Regarding forward compatibility, so far I operated under the assumption that I can release timely updates from the tip-of-tree protocol version. And I do release protocol updates from the tip-of-tree rather regularly (except the recent gap due to CI issues).  However, it seems that the current tip-of-tree doesn't contain the values you're describing. So the broken assumption is that the tip-of-tree protocol definitions are perfectly up-to-date.
I checked, and uninteresting was never in this enum (at least since 2020), so we can rule out the fact that these values were just deleted from the enum without warning (because of the experimental status). So it does seem that these are new values that just didn't make it to the protocol definition yet (surprising!).
Going with special cases only for enums that turn out problematic will cause friction for users (like you right now). It's probably better to go the forward compatibility route to handle this case. Experimental enums are expected to change a lot. That said, I don't want to clutter stable enums. I think if we ever have a problem with a stable enum, I can indeed take care of it with a special case.
I opened https://github.com/joffrey-bion/chrome-devtools-kotlin/issues/467 to track the solution.

Turns out this specific issue is not new: https://issues.chromium.org/issues/40924391
I wonder why the protocol definition still doesn't include this.


feat: add option.cssOutputPath

What kind of change does this PR introduce?

A bugfix and a feature (cssOutputPath)
Did you add tests for your changes?
no
If relevant, did you update the README?
The readme file has been updated
Summary

#149 and #135 public path validation
Does this PR introduce a breaking change?

no
Other information
Entry files and CSS output path doesn't pass through the file-loader so we haven't access to the file's context to compare with your issuer context correctly then we need to kidnap javascript entries and manually pass the CSS file output path using a new property (i.e. cssOutputPath). This should prevent unexpected output paths.

Is this in general 'only' related to extract-text-webpack-plugin, or could this be used by other plugins etc aswell? assetsOutputPath || assetsPath

extract-text-webpack-plugin-output-filename is sent for all requested files (except js entries) by the specific plugin, but the output.filename is from webpack.config then I don't think that's a problem to use with another plugin unless it also sends something like another-plugin-output-filename for all requested files.

kk, yeah this might be out-of-scope of this PR, I'm sry to bikeshed about this, but we need to make sure to not let any specific hooks relying on other plugins/loaders into loaders/plugins in general when possible and try go for the generic solution first. So if we can design it as a generic hook for plugins in need of the same functionality as ETWP, we should do it.
But this doesn't mean it's a blocker for this PR :), tbh I have no clue if any other plugin would need this aswell. I just need to clearify this 😛

The textOutputPath is relative to the extracted file (e.g css), is from the issuer, not for your assets. I'm not sure if the extract-text(for example) is used only for CSS files so I prefer to keep the generic name or maybe cssOutputPath. I don't know. What do you think?

If we go with this, we need to make sure folks using the file-loader+ ETWP combo, directly see this option is for you 😛
textOutput[Path] (Current)
extractOutput[Path]
extractTextOutput[Path]

@michael-ciniawsky No, you're totally right and I'm happy to answer.
Actually, my idea is quite simple and maybe that's exactly why it's confusing without seeing it in action.
At this line, I expected only JavaScript files and I filled it with this info because it has only the part of the relative path that matters i.e without any ../ because it's generally requested from the root. So actually this line is only preventing for that ETWP overrides any path with extract-text-webpack-plugin-output-filename (not is a dependency) and bring to us the javascript path too, to kill two birds with one stone. Already on this line I particularly is expecting only CSS files but nothing prevent it from being another kind of file (the only reason I called from textOutput and not cssOutput), again, you're right, this name generates a mess and my quotations for the plugin enforce this. But how can we call it?

@michael-ciniawsky That's it!
I updated the samples too
https://bitbucket.org/adriancmiranda/pr-file-loader/src
https://bitbucket.org/adriancmiranda/pr-file-loader/src/489f5e70002496b4098a283b1a794643ee0869e7/?at=file-loader-relative-path-issue

cssPath || stylePath is better imho, but that's majority decision*
Docs (more) 😉
Tests

Also see https://github.com/webpack-contrib/file-loader/pull/150#discussion_r111624781

we maybe even consider to put this under one option prop in the future paths: { public: '', css: '', ...}, but not yet...

I have the same problem, and this pr resolve my problem. Hope to merge it. 👍🏿

@michael-ciniawsky

cssPath || stylePath is better imho, but that's majority decision*
I don't know. Particularly I prefer to keep explicit the output term.

we maybe even consider to put this under one option prop in the future paths: { public: '', css: '', ...}, but not yet...

I like it and I can make it too if you wish.
Check also for me if you'll want this in this PR: https://github.com/webpack-contrib/file-loader/pull/150#discussion_r111669017

I merged a small bugfix please rebase :),

I don't know. Particularly I prefer to keep explicit the output term.

cssOutputPath is verbose, but like a metioned, just my personal opinion and majority decides, so just leave it for now 😉

we maybe even consider to put this under one option prop in the future paths: { public: '', css: '', ...}, but not yet...

This is a sadly a breaking change, I need to stop thinking out loud in PR's, it's confusing for others 😛

Sorry! I did it wrong 😨

git reset --hard HEAD~1 && git checkout master && git fetch upstream master && git merge master && git checkout file-loader && git rebase master

@michael-ciniawsky I made the terrible mistake of making the changes directly in the master branch of my fork as the last time
so I used git pull --rebase origin master

@adriancmiranda I'm sry 😛  I thought merging the smaller PR would be the simpler solution instead of the otherway around. Maybe just copy and paste your changes and open a new clean PR ?

@michael-ciniawsky What about it?

Onyl the style related one's you posted in the gist, othwerwise should be fine then imho, but we need to wait for th revei of others aswell :)

You ar right, well, thank's for your review. 😉

@bebraw @d3viant0ne Please general approval/rejection on this feature, before we continue for nothing in the end :)

@michael-ciniawsky - I don't have an issue with this conceptually nor with the quality of the pull request. There is a lot of noise here so I'll have to wait to review it until later this evening.

@d3viant0ne We definitely need to check this again, since it is a conjunction between ETWP && file-loader to some point which is always undesireable, but seems to be no better way to solve the particular issue atm. I hadn't time to play with this maybe later this week 😛

Yeah, I just saw that. That's probably going to be a deal breaker if we can't find a way to solve this problem without depending on another loader.
When in doubt, wait.

Guys, sorry, maybe I was not clear, my english isn't good
but, you can use with another loaders too e.g. extract-loader. In fact, we need only to know where the css will be saved.

Any update on this?

@adriancmiranda - - I have set this to blocked ( #165 ) & moved this feature into 1.1.0, the next minor range after the pending 1.0.0 release.

@d3viant0ne Thank you... and I'm sorry for the noise :wink:

@adriancmiranda @d3viant0ne
What about this solution? Will it ever be merged? Half of my images end up in the parent folder.
Thanks!

Hey @stereokai I'm waiting for another review yet. 😉

@adriancmiranda Actually, here's an update:
After 2 days of trial and error (Thanks Webpack docs!) I found out that there's a way to control file-loader's output and replicate the file structure of the source directory in the output directory. It's the Webpack setting context, which can be used per loader or per build, For file-loader:
  use: [{
    loader: 'file-loader',
    options: {
      context: <path>, // The directory to draw relative paths from
      name: '[path][name].[ext]'
    },
  },

Here's an example of how to use it. Let's say your desired result is to load an image via www.website.com/assets/images/user.png
Your project's file structure is:
project/
├── src/
│   └── assets/
│       └── images/
│           └── user.png
└── build/

And the desired result is:
project/
├── src/
│   └── assets/
│       └── images/
│           └── user.png
└── build/
    └── assets/
        └── images/
            └── user.png

The configuration for this is:
  use: [{
    loader: 'file-loader',
    options: {
      context: path.resolve(__dirname, 'src')
      name: '[path][name].[ext]'
    },
  },

And that is because you want to replicate the file structure under src folder inside the build folder.
If you wanted to remove the assets directory from the path, the value for context would be: path.resolve(__dirname, 'src/assets'), and file-loader will replicate the relative paths starting in 'src/assets' instead, and the result would be:
project/
├── src/
│   └── assets/
│       └── images/
│           └── user.png
└── build/
    └── images/
        └── user.png

@stereokai How about the links?

@adriancmiranda what do you mean? I was getting build assets in parent folders of the project root. Are we not talking about the same problem?

@stereokai What I'm proposing isn't exactly solving a problem, but provide an additional solution to, so that you can also have relative paths in the compiled version of your code. Your example works perfectly, however, it only has one file-per-configuration context. So let's say you have this structure:
src/
│   └── scripts/index.js -> require('../assets/images/placehold.jpg')
│   └── assets/
│       └── images/

you get something like this, right?
/src/assets/images/placehold.jpg
My proposal is that you have a result like this:
../assets/images/placehold.jpg
considering of course that you'll replicate src dir. But let's say you want to change the build path from the js file to the root, something like this.
build/
│   └── index.js -> require('../assets/images/placehold.jpg')
│   └── assets/
│       └── images/

In this case you should have this path
./assets/images/placehold.jpg
instead
/assets/images/placehold.jpg

@adriancmiranda Does this line: scripts/index.js -> require('../assets/images/placehold.jpg') mean scripts/index.js is importing placehold.jpg?

@stereokai Yes, it is, sorry about it

@adriancmiranda I'm sorry but I don't understand what it is you are trying to achieve

The solution worked on my project (Cordova project so I cannot use / as public path)
In my package.json I put:
"file-loader": "git://github.com/woshi82/file-loader.git#master"

In my webpack config:
modules: {
  rules: [
    // ...
    {
        test: /\.(png|jpe?g|gif|svg)(\?.*)?$/,
        loader: 'url-loader',
        options: {
          limit: 5000,
          name: utils.assetsPath('img/[name].[hash:7].[ext]'),
          useRelativePath: process.env.NODE_ENV === "production",
          cssOutputPath: 'static/css'
        }
      }
  ]
}

@Leward The useRelativePath should works on development mode too :-)


Strick title name

I was checking out the movie recommendation code and found out that if the movie_user_likes should match the exact title of the movie or else it gives the following error.. Ok the movie title being strict is alright but it is also case sensitive... for example if i give "the avengers" it will still give the following error.
Traceback (most recent call last):
File "d:/Documents/8sem/Project Phase II/contentbased.py", line 47, in
movie_index = get_index_from_title(movie_user_likes)
File "d:/Documents/8sem/Project Phase II/contentbased.py", line 10, in get_index_from_title
return df[df.title == title]["index"].values[0]
IndexError: index 0 is out of bounds for axis 0 with size 0
so i tried turning the user data into camel case but then again it will show the same error cause the preposition in the title are small case.. I'm pretty much stuck here... I would be thankful to someone who can show me a way around it.. I'm open for new ideas... PLEASE HELP

I was checking out the movie recommendation code and found out that if the movie_user_likes should match the exact title of the movie or else it gives the following error.. Ok the movie title being strict is alright but it is also case sensitive... for example if i give "the avengers" it will still give the following error.
Traceback (most recent call last):
File "d:/Documents/8sem/Project Phase II/contentbased.py", line 47, in
movie_index = get_index_from_title(movie_user_likes)
File "d:/Documents/8sem/Project Phase II/contentbased.py", line 10, in get_index_from_title
return df[df.title == title]["index"].values[0]
IndexError: index 0 is out of bounds for axis 0 with size 0
so i tried turning the user data into camel case but then again it will show the same error cause the preposition in the title are small case.. I'm pretty much stuck here... I would be thankful to someone who can show me a way around it.. I'm open for new ideas... PLEASE HELP

So you can do one thing concert every movie name in the dataset tolower and in function also convert the input to all lower letter.That way user input would not be case sensitive


0.1.1: docs @setup block

@JuliaRegistrator register()

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


Simplified installing of JS and CSS libs. Fixed #1906.

I tested your branch. There are some problems:

the gulp tasks 'js-libs', 'fonts-libs' and 'ckeditor' runs very long! (>3min). see:

[14:03:20] Using gulpfile ~/projects/openslides/src/OpenSlides/gulpfile.js
[14:03:20] Starting 'js-libs'...
[14:03:20] Starting 'css-libs'...
[14:03:20] Starting 'fonts-libs'...
[14:03:20] Starting 'ckeditor'...
[14:03:20] Starting 'translations'...
[14:03:23] Finished 'translations' after 3.78 s
[14:03:23] Finished 'css-libs' after 3.85 s
[14:06:36] Finished 'js-libs' after 3.27 min
[14:06:36] Finished 'fonts-libs' after 3.27 min
[14:06:37] Finished 'ckeditor' after 3.27 min
[14:06:37] Starting 'default'...
[14:06:37] Finished 'default' after 7.3 μs

The two fonts (Roboto and Open Sans) are not installed correctly. You can't use it in template.

Please test it!

Problem 1 seems to be already in master (if you run gulp --production). Please check it.

Both (1+2) seems to be a problem only with 'gulp --production'. The font definition seems to be broken after minifized css code.

Both problems are in current master, so this has nothing to do with this pull request.

ok

New issue created: #1955.


Refactor SchemaForm into SchemaForm/TabForm

you can now create a form with tabs on the left and a selected form on the right without having to do anything with a schema.

Reviewer: @aldipower

retest this please

So what does SchemaForm give us, now?

@pierlo-upitup schemaform parses a schema and then creates a form definition, which TabForm uses. TabForm doesn't know anything about schemas

LGTM!


Fix copy edits 7.0.0

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

wrong pr.


Set notation and set functions

Examples:

sum({C(n,k) : k in [0,4)}), equivalent to C(n,0) + C(n, 1) + ...
prod([1,7]), equivalent to 7*6*5*4*3*2*1
max, min, median, mean

This would require a new type (Range / Set), changes to parsing, changes to tokenising, new functions that operate on sets.

With this feature and probability distributions, we can sample multiple values from a probability distribution at once: sample(X, NumberOfSamples).
These should be about the same:
>>> mean(sample(Bernoulli(10, .5), 1000))
>>> mean(Bernoulli(10, .5))

The question becomes... do we want to add support for multidimensional arrays? Or nested arrays, at least? I'm inclined to say no, because I don't want to reimplement numpy or to add a dependency on numpy.

This is almost done, just have to debug the "array comprehensions" and write tests.

DONE. Just gotta do documentation.
>>> 2^10
1024
>>> N=10; sum({C(N,k) : k in [0,10]})
1024


⚠ ClamAV has degraded performance

In 616f7ea, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 439 ms

Resolved: ClamAV performance has improved in d870700.


Bidirectional Mirroring - Where does the code go?

The section of the README.md titled Bidirectional Mirroring, has some code about creating a context and then watching. Where exactly does this code go? Does it need to go in a script? Or in a config file?

It goes into the build.mjs file

Thanks for your help. Sorry one other question related to this. Is there a way of specifying a remote path and local path not to mirror?

No, there is not. The base features are fairly simple and opinionated to my tastes (since they where mainly developed for me initially).
You can however create custom plugin extensions to achieve the exact behavior you are looking for.


match can't set provisioning to xcode

Hello, I'm new to fastlane and I want to use fastlane to build my app
Here is my Fastfile
default_platform(:ios)

platform :ios do
  desc "Description of what the lane does"
  lane :beta do
    # add actions here: https://docs.fastlane.tools/actions
    match(type: "appstore", verbose: true, readonly: true)
    sync_code_signing()
    increment_build_number()
    build_app(scheme: "ComicReader", export_method: "app-store")
  end
end

In the log, I can see match and gym use correct provisioning profile in the chart below
+--------------------------------------+--------------------------------------+
|                           Summary for gym 2.123.0                           |
+--------------------------------------+--------------------------------------+
| scheme                               | ComicReader                          |
| export_method                        | app-store                            |
| export_options.provisioningProfiles  | match AppStore com.dev.comicreader   |
| .com.dev.comicreader                 |                                      |
| project                              | ./ComicReader.xcodeproj              |
| destination                          | generic/platform=iOS                 |
| output_name                          | ComicReader                          |
| build_path                           | /Users/tadangquynh/Library/Develope  |
|                                      | r/Xcode/Archives/2019-05-16          |
| clean                                | false                                |
| output_directory                     | .                                    |
| silent                               | false                                |
| skip_package_ipa                     | false                                |
| result_bundle                        | false                                |
| buildlog_path                        | ~/Library/Logs/gym                   |
| skip_profile_detection               | false                                |
| xcode_path                           | /Applications/Xcode.app              |
+--------------------------------------+--------------------------------------+

However, gym or match can't set that provisioning to xcode and build_app phase was fail due to Provisioning profile "Comic Reader AppStore" doesn't include signing certificate "iPhone Distribution: Ta Dang Quynh (7L5FW8G72L)". (in target 'ComicReader')
If I open xcode, and choose provisioning match AppStore com.dev.comicreader for Signing (Release), build build_app was successfully.
My question is why match can detect provisioning correctly but can't set it in xcode and I have to manually set it. Is there any way to let match do it?

Hi there, did you check out https://docs.fastlane.tools/codesigning/xcode-project/ on how to setup your Xcode project?

I added export_xcargs: "-allowProvisioningUpdates" to build_app but no luck, issue still remain.
Since I use match, so I dont have to define a map like this right
 export_options: {
      provisioningProfiles: {
        "com.example.bundleid" => "Provisioning Profile Name",
        "com.example.bundleid2" => "Provisioning Profile Name 2"
      }
    }

I found that the docs mention that I have to manually set provisioning profile for every targets  at troubleshooting page: https://docs.fastlane.tools/codesigning/troubleshooting/

And here https://docs.fastlane.tools/codesigning/xcode-project/#build-settings

I thought that fastlane can do it automatically, but it can't :(

I'm only using sigh and cert so I cannot really give you any insights on match. With those I can set everything automatically, including for extensions etc.
Usually when debugging fastfiles. I recommend running the steps one-by-one in the console and checking for any errors there.

@maphongba008 Can you please post your complete output you are getting when running the fastlane command? What you posted until now doesn't nearly give us enough context to understand what is going on.

I had the same issue when using match. It would work when I manually set the profile in Xcode, but wouldn't set it automatically. I corrected it by getting the profile from match via ENV and manually setting the "codesigning_identity" parameter in gym. Maybe something like:
match(
  shallow_clone: true,
  clone_branch_directly: true,
  readonly: true
)
gym(
  configuration: "Release",
  scheme: "ComicReader",
  codesigning_identity: "iPhone Distribution: Ta Dang Quynh (7L5FW8G72L)",
  xcargs: {
    :PROVISIONING_PROFILE_SPECIFIER => ENV["sigh_com.dev.comicreader_appstore_profile-name"], # Set when `match` runs
    :DEVELOPMENT_TEAM => "7L5FW8G72L"
  }
)

I used ENV variables to dynamically switch between development, staging, release, etc.


can not load by qmlscene

qt 5.10.0
qmlscene  Doc/main.qml
error:
Type Introduction unavailable
...
Cannot override FINAL property
but, test import StratifyLabs.UI 3.0, load ok.

@kitech
with qt 5.10, they decided to add "icon" to the native Button. This creates a problem with StratifyLabsUI because we have to change the API to make it work. Qt 5.10 doesn't allow you to revert to the API without the "icon".  Hence 3.0 will work with 5.10 (though the API has changed) but 2.x will not work with 5.10. I have tested 2.0 with 5.9.3.

oh, i pick a wrong qt version. thanks.


fix FAQs

Need to double check with management re: answers to some of the FAQs and fix them.

Answer for "Who is eligible to register?" should include the US restriction


Path issue related to sonar.ts.tslintpath (Version 9) - work fine in version 8

Hi @Pablissimo.
Thanks for writing this plugins.
I have this issue where whenever I set the sonar.ts.tslintpath, I get this error:

16:40:23 INFO: Sensor com.pablissimo.sonar.TsLintSensor
16:40:23 ERROR: TsLint Err: module.js:327
16:40:23 ERROR: TsLint Err:     throw err;
16:40:23 ERROR: TsLint Err:     ^
16:40:23 ERROR: TsLint Err:
16:40:23 ERROR: TsLint Err: Error: Cannot find module '/var/jenkins_home/workspace/Test_Customer_Service/"/var/jenkins_home/workspace/Test_Customer_Service/node_modules/tslint/bin/tslint"'
16:40:23 ERROR: TsLint Err:     at Function.Module._resolveFilename (module.js:325:15)
16:40:23 ERROR: TsLint Err:     at Function.Module._load (module.js:276:25)
16:40:23 ERROR: TsLint Err:     at Function.Module.runMain (module.js:441:10)
16:40:23 ERROR: TsLint Err:     at startup (node.js:134:18)
16:40:23 ERROR: TsLint Err:     at node.js:962:3

It seems like it adds my project path to the path I set in sonar properties while also adding double quote.
I also try no to set the sonar.ts.tslintpath but it gives me this warning:

15:46:55 INFO: Sensor com.pablissimo.sonar.TsLintSensor
15:46:55 WARN: Path to tslint not defined or not found. Skipping tslint analysis.
15:46:55 INFO: Sensor com.pablissimo.sonar.TsLintSensor (done) | time=0ms

It then seems to skip the analysis. (Tested this by introducing linting issue, the analysis result still shows no issue) My tslint path is matching the default In TsLintSensor.java, TSLINT_FALLBACK_PATH. I understand that the plugin has not been tested on Linux, could this be Linux specific?

It might be, but the quotes are odd. Can you try the following please?

Tell me what version of the plugin you're using (latest is 0.9)

If you're on 0.9 try downgrading to 0.8 - there were changes that went in recently to try to make all paths absolute which may be bugging out

Can you post your sonar-project.properties file (or at least the exact line that configures sonar.ts.tslintpath?
Are you quoting the path in either sonar-project.properties or in the admin portal? You shouldn't need quotes (it shouldn't blow up encountering them, but try removing them if you have added them)

Also - if you try running the sonar-runner with the -X -e switches and see what the debug output is? It'll tell you where it's searching for tslint when you haven't specified a path to it, as the structure you describe above should just have tslint automatically found and run without a problem.

@Pablissimo, Awesome downgraded to 0.8 and it works. This makes me day. :+1: :+1:
Thank you very much!!!
I reverted back to 0.9 and run sonar runner with -X -e switches, log is below. Also the properties file. (GIthub doesnt allow me to upload it)
Error log:

10:53:43 [Test_Customer_Service] $ /tools/hudson.plugins.sonar.SonarRunnerInstallation/ADOP_SonarRunner_2.4/bin/sonar-runner -X -e -Dsonar.jdbc.url=jdbc: ******** ******** -Dsonar.host.url= ******** ******** -Dsonar.projectBaseDir=/workspace/Test_Customer_Service -Dsonar.sourceEncoding=UTF-8 -Dsonar.ts.tslintconfigpath=tslint.json -Dsonar.language=ts -Dsonar.sources=. -Dsonar.login=admin -Dsonar.exclusions=node_modules/,typings/,test/record/** -Dsonar.projectVersion=1.0.0 -Dsonar.projectKey=Test.Customer.Service "-Dsonar.projectDescription=Project test results." -Dsonar.password= -Dsonar.ts.excludetypedefinitionfiles=true "-Dsonar.projectName=TEST CUSTOMER SERVICE"
10:53:43 WARN: sonar-runner script is deprecated. Please use sonar-scanner instead.
10:53:44 INFO: Scanner configuration file: /tools/hudson.plugins.sonar.SonarRunnerInstallation/ADOP_SonarRunner_2.4/conf/sonar-scanner.properties
10:53:44 INFO: Project root configuration file: NONE
10:53:44 INFO: SonarQube Scanner 2.6.1
10:53:44 INFO: Java 1.8.0_45 Oracle Corporation (64-bit)
10:53:44 INFO: Linux 3.10.0-229.14.1.el7.x86_64 amd64
10:53:44 INFO: Error stacktraces are turned on.
10:53:44 INFO: User cache: /root/.sonar/cache
10:53:44 DEBUG: Extract sonar-scanner-api-batch in temp...
10:53:44 DEBUG: Get bootstrap index...
10:53:44 DEBUG: Download: http:///sonar/batch_bootstrap/index
10:53:44 DEBUG: Get bootstrap completed
10:53:44 DEBUG: Create isolated classloader...
10:53:44 DEBUG: Start temp cleaning...
10:53:44 DEBUG: Temp cleaning done
10:53:44 DEBUG: Execution getVersion
10:53:44 DEBUG: Execution start
10:53:45 DEBUG: Publish global mode
10:53:45 DEBUG: cache: /root/.sonar/ws_cache/http%3A%2F%2F%3A9000%2Fsonar/global
10:53:45 INFO: Load global repositories
10:53:46 DEBUG: GET 200 http:///sonar/batch/global | time=171ms
10:53:46 INFO: Load global repositories (done) | time=240ms
10:53:46 WARN: Property 'sonar.jdbc.url' is not supported any more. It will be ignored. There is no longer any DB connection to the SQ database.
10:53:46 WARN: Property 'sonar.jdbc.username' is not supported any more. It will be ignored. There is no longer any DB connection to the SQ database.
10:53:46 WARN: Property 'sonar.jdbc.password' is not supported any more. It will be ignored. There is no longer any DB connection to the SQ database.
10:53:46 INFO: User cache: /root/.sonar/cache
10:53:46 INFO: Load plugins index
10:53:46 DEBUG: GET 200 http:///sonar/deploy/plugins/index.txt | time=3ms
10:53:46 INFO: Load plugins index (done) | time=4ms
10:53:46 DEBUG: Load plugins
10:53:46 DEBUG: Load plugins (done) | time=232ms
10:53:46 DEBUG: API compatibility mode is enabled on plugin Dependency-Check [dependencycheck] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin Java [java] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin Git [scmgit] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin ZAP [zap] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin TypeScript [typescript] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin Build Breaker [buildbreaker] (built with API lower than 5.2)
10:53:46 DEBUG: API compatibility mode is enabled on plugin Generic Coverage [genericcoverage] (built with API lower than 5.2)
10:53:46 DEBUG: Plugins:
10:53:46 DEBUG:   * Dependency-Check 1.0.3 (dependencycheck)
10:53:46 DEBUG:   * Java 3.14 (java)
10:53:46 DEBUG:   * LDAP 1.5.1 (ldap)
10:53:46 DEBUG:   * Git 1.2 (scmgit)
10:53:46 DEBUG:   * ZAP 1.0.0-0 (zap)
10:53:46 DEBUG:   * TypeScript 0.9-SNAPSHOT (typescript)
10:53:46 DEBUG:   * Build Breaker 1.1 (buildbreaker)
10:53:46 DEBUG:   * Generic Coverage 1.2 (genericcoverage)
10:53:46 DEBUG: Execution getVersion
10:53:46 INFO: SonarQube server 5.5
10:53:46 INFO: Default locale: "en_US", source code encoding: "UTF-8"
10:53:46 DEBUG: Work directory: /workspace/Test_Customer_Service/.sonar
10:53:46 DEBUG: Execution getVersion
10:53:46 DEBUG: Execution execute
10:53:47 INFO: Process project properties
10:53:47 DEBUG: Process project properties (done) | time=3ms
10:53:47 DEBUG: cache: /root/.sonar/ws_cache/http%3A%2F%2F%3A9000%2Fsonar/5.5/projects/Test.Customer.Service
10:53:47 INFO: Load project repositories
10:53:47 DEBUG: GET 200 http:///sonar/batch/project.protobuf?key=Test.Customer.Service | time=89ms
10:53:47 INFO: Load project repositories (done) | time=154ms
10:53:47 DEBUG: Available languages:
10:53:47 DEBUG:   * Neutral => "neutral"
10:53:47 DEBUG:   * Java => "java"
10:53:47 DEBUG:   * TypeScript => "ts"
10:53:47 INFO: Load quality profiles
10:53:47 DEBUG: GET 200 http:///sonar/api/qualityprofiles/search.protobuf?projectKey=Test.Customer.Service | time=83ms
10:53:47 INFO: Load quality profiles (done) | time=88ms
10:53:47 INFO: Load active rules
10:53:48 DEBUG: GET 200 http:///sonar/api/rules/search.protobuf?f=repo,name,severity,lang,internalKey,templateKey,params,actives&activation=true&qprofile=java-sonar-way-85046&p=1&ps=500 | time=870ms
10:53:48 DEBUG: GET 200 http:///sonar/api/rules/search.protobuf?f=repo,name,severity,lang,internalKey,templateKey,params,actives&activation=true&qprofile=neutral-neutral-69159&p=1&ps=500 | time=143ms
10:53:48 DEBUG: GET 200 http:///sonar/api/rules/search.protobuf?f=repo,name,severity,lang,internalKey,templateKey,params,actives&activation=true&qprofile=ts-tslint-62563&p=1&ps=500 | time=203ms
10:53:48 INFO: Load active rules (done) | time=1272ms
10:53:48 INFO: Publish mode
10:53:48 DEBUG: Start recursive analysis of project modules
10:53:48 INFO: -------------  Scan TEST CUSTOMER SERVICE
10:53:49 INFO: Language is forced to ts
10:53:49 INFO: Load server rules
10:53:49 DEBUG: GET 200 http:///sonar/api/rules/list.protobuf | time=95ms
10:53:49 INFO: Load server rules (done) | time=103ms
10:53:49 DEBUG: Initializers :
10:53:49 INFO: Base dir: /workspace/Test_Customer_Service
10:53:49 INFO: Working dir: /workspace/Test_Customer_Service/.sonar
10:53:49 INFO: Source paths: .
10:53:49 INFO: Source encoding: UTF-8, default locale: en_US
10:53:49 INFO: Index files
10:53:49 INFO: Excluded sources:
10:53:49 INFO:   node_modules/**
10:53:49 INFO:   typings/**
10:53:49 INFO:   test/record/**
10:53:49 DEBUG: Declared extensions of language Neutral were converted to sonar.lang.patterns.neutral :
10:53:49 DEBUG: Declared extensions of language Java were converted to sonar.lang.patterns.java : /*.java,/.jav
10:53:49 DEBUG: Declared extensions of language TypeScript were converted to sonar.lang.patterns.ts : **/.ts,**/*.tsx
10:53:49 DEBUG: Language of file 'app.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'controllers/feedback.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'controllers/plan.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'models/feedback.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'models/plan.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'server.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'services/feedback.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'services/plan.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'test/feedback.ts' is detected to be 'ts'
10:53:49 DEBUG: Language of file 'test/plan.ts' is detected to be 'ts'
10:53:49 INFO: 10 files indexed
10:53:49 INFO: 8741 files ignored because of inclusion/exclusion patterns
10:53:49 INFO: Quality profile for ts: tslint
10:53:49 INFO: JaCoCoSensor: JaCoCo report not found : /workspace/Test_Customer_Service/target/jacoco.exec
10:53:49 INFO: JaCoCoItSensor: JaCoCo IT report not found: /workspace/Test_Customer_Service/target/jacoco-it.exec
10:53:49 DEBUG: Code colorizer, supported languages:
10:53:49 DEBUG: Sensors : Lines Sensor (wrapped) -> ZapSensor -> com.pablissimo.sonar.TsLintSensor@2c22a348 -> LOCSensor -> TsCoverageSensor -> SCM Sensor (wrapped) -> Zero Coverage Sensor (wrapped) -> Code Colorizer Sensor (wrapped) -> CPD Block Indexer (wrapped)
10:53:49 INFO: Sensor Lines Sensor (wrapped)
10:53:49 INFO: Sensor Lines Sensor (wrapped) (done) | time=13ms
10:53:49 INFO: Sensor ZapSensor
10:53:49 WARN: ZAP report not found at target/zap-reports/zapReport.html
10:53:49 INFO: Sensor ZapSensor (done) | time=0ms
10:53:49 INFO: Sensor com.pablissimo.sonar.TsLintSensor
10:53:49 DEBUG: Path sonar.ts.tslintpath not specified, falling back to node_modules/tslint/bin/tslint
10:53:49 DEBUG: Found sonar.ts.tslintconfigpath Lint path to be 'tslint.json'
10:53:49 DEBUG: Path sonar.ts.tslintrulesdir not specified, falling back to null
10:53:49 DEBUG: Split 10 files into 1 batches for processing
10:53:49 DEBUG: Executing TsLint with command: node "/workspace/Test_Customer_Service/node_modules/tslint/bin/tslint" --format json --config "/workspace/Test_Customer_Service/tslint.json" "/workspace/Test_Customer_Service/app.ts" "/workspace/Test_Customer_Service/controllers/feedback.ts" "/workspace/Test_Customer_Service/controllers/plan.ts" "/workspace/Test_Customer_Service/models/feedback.ts" "/workspace/Test_Customer_Service/models/plan.ts" "/workspace/Test_Customer_Service/server.ts" "/workspace/Test_Customer_Service/services/feedback.ts" "/workspace/Test_Customer_Service/services/plan.ts" "/workspace/Test_Customer_Service/test/feedback.ts" "/workspace/Test_Customer_Service/test/plan.ts"
10:53:50 ERROR: TsLint Err: module.js:327
10:53:50 ERROR: TsLint Err:     throw err;
10:53:50 ERROR: TsLint Err:     ^
10:53:50 ERROR: TsLint Err:
10:53:50 ERROR: TsLint Err: Error: Cannot find module '/workspace/Test_Customer_Service/"/workspace/Test_Customer_Service/node_modules/tslint/bin/tslint"'
10:53:50 ERROR: TsLint Err:     at Function.Module._resolveFilename (module.js:325:15)
10:53:50 ERROR: TsLint Err:     at Function.Module._load (module.js:276:25)
10:53:50 ERROR: TsLint Err:     at Function.Module.runMain (module.js:441:10)
10:53:50 ERROR: TsLint Err:     at startup (node.js:134:18)
10:53:50 ERROR: TsLint Err:     at node.js:962:3
10:53:50 INFO: Sensor com.pablissimo.sonar.TsLintSensor (done) | time=218ms
10:53:50 INFO: Sensor LOCSensor
10:53:50 INFO: Sensor LOCSensor (done) | time=18ms
10:53:50 INFO: Sensor TsCoverageSensor
10:53:50 INFO: Sensor TsCoverageSensor (done) | time=3ms
10:53:50 INFO: Sensor SCM Sensor (wrapped)
10:53:50 INFO: Sensor SCM Sensor (wrapped) (done) | time=0ms
10:53:50 INFO: Sensor Zero Coverage Sensor (wrapped)
10:53:50 INFO: Sensor Zero Coverage Sensor (wrapped) (done) | time=10ms
10:53:50 INFO: Sensor Code Colorizer Sensor (wrapped)
10:53:50 INFO: Sensor Code Colorizer Sensor (wrapped) (done) | time=2ms
10:53:50 INFO: Sensor CPD Block Indexer (wrapped)
10:53:50 INFO: DefaultCpdBlockIndexer is used for ts
10:53:50 DEBUG: No CpdMapping for language ts
10:53:50 INFO: Sensor CPD Block Indexer (wrapped) (done) | time=0ms
10:53:50 INFO: Calculating CPD for 0 files
10:53:50 INFO: CPD calculation finished
10:53:50 INFO: Analysis report generated in 63ms, dir size=22 KB
10:53:50 INFO: Analysis reports compressed in 13ms, zip size=14 KB
10:53:50 DEBUG: Upload report
10:53:50 DEBUG: POST 200 http:///sonar/api/ce/submit?projectKey=Test.Customer.Service&projectName=TEST%20CUSTOMER%20SERVICE | time=73ms
10:53:50 INFO: Analysis report uploaded in 76ms
10:53:50 INFO: ANALYSIS SUCCESSFUL, you can browse https:///sonar/dashboard/index/Test.Customer.Service
10:53:50 INFO: Note that you will be able to access the updated dashboard once the server has processed the submitted analysis report
10:53:50 INFO: More about the report processing at https:///sonar/api/ce/task?id=
10:53:50 DEBUG: Report metadata written to /workspace/Test_Customer_Service/.sonar/report-task.txt
10:53:50 DEBUG: Post-jobs : org.sonar.plugins.buildbreaker.AlertBreaker@3c443976 -> org.sonar.plugins.buildbreaker.ForbiddenConfigurationBreaker@3e58d65e
10:53:50 INFO: Executing post-job org.sonar.plugins.buildbreaker.AlertBreaker
10:53:50 INFO: Executing post-job org.sonar.plugins.buildbreaker.ForbiddenConfigurationBreaker
10:53:50 INFO: Analysis report generated in /workspace/Test_Customer_Service/.sonar/batch-report
10:53:50 INFO: ------------------------------------------------------------------------
10:53:50 INFO: EXECUTION SUCCESS
10:53:50 INFO: ------------------------------------------------------------------------
10:53:50 INFO: Total time: 6.304s
10:53:50 INFO: Final Memory: 41M/103M
10:53:50 INFO: ------------------------------------------------------------------------
10:53:50 DEBUG: Execution getVersion
10:53:50 DEBUG: Execution stop
10:53:50 Archiving artifacts
10:54:01 Finished: SUCCESS

sonar.properties
sonar.projectKey=Test.Customer.Service
sonar.projectName=TEST CUSTOMER SERVICE
sonar.projectVersion=1.0.0
sonar.projectDescription= Project test results.

sonar.ts.excludetypedefinitionfiles=true
sonar.ts.tslintconfigpath=tslint.json

sonar.sources=.
sonar.exclusions=node_modules/**,typings/**,test/record/**

sonar.language=ts
sonar.sourceEncoding=UTF-8

sonar.login=foo
sonar.password=foo

Yeah that's weird, it looks like it's built a vaguely sensible command line but then struggles to use it. Will try to repro on a couple of linux hosts I've got knocking around, thanks for the report!

I've exactly the same problem.

I think if you want to handle folders with white-spaces, you can just add double quotes around the white-spaces. it works for both linux and windows.

I wonder if just skipping absoluteifying the first argument would do the trick then - I know I have to supply quotes for subsequent paths otherwise things go horribly wrong on certain CI hosts (where the working directory is fairly arbitrary). Will try a couple of combinations - don't want to break TFS CI (which was basically all that 0.9 was trying to fix) but I'm sure I can figure it.

I've tested with only removing the double quotes of first argument, it doesn't work. I've to remove all the double quotes in order to make it works. (while taking account the path with whitespaces)
if you wish, I can send a PR to let you review my modification.

Yeah fire it on just to see - I just did the same but it then broke on Windows when the path has spaces

Want to give this version a try? It's a daft temporary fix that quotes paths only a) on Windows and b) when there are spaces in the path. On Linux is should just skip all quoting, and appears to work on my local Debian installs but another tester would be good! Or compile from the issue47 branch.
sonar-typescript-plugin-0.92-SNAPSHOT.zip

I just tested this build in unix (mac and ubuntu), it works.
I didn't test yet for windows. (no windows at home...)

Same here.
It was not working with throw err, but now woth v0.8 it doesn't work because of Sonar 6.0 :)

Per the other SonarQube 6.0 issues, there's a pre-release version of an SQ6 supporting plugin that also includes this path fix - give it a bash and let me know!
https://github.com/Pablissimo/SonarTsPlugin/releases/tag/v0.93
(At your own risk of course, try a dev server first etc etc).

Fixed in v0.94, please re-open if it still occurs.


[UWP] Add accessible names to all action buttons

Related Issue
Fixes #3527
Description
While investigating alternatives for a partner team, I noticed that ActionSet buttons lack appropriate accessibility information, particularly when an iconUrl is present. Most accessibility tools will decide that if there's a single text child of a button, that the text child must be the name. However, if there's >1 child, it gives up. Consider this:
{
    "type": "AdaptiveCard",
    "version": "1.1",
    "body": [
        {
            "type": "ActionSet",
            "actions": [
                {
                    "type": "Action.Submit",
                    "title": "action!",
                    "iconUrl": "data:image/png;base64,[...]="
                }
            ]
        }
    ]
}

Accessibility Insights will show this as not having a name. Similarly, Narrator will read it simply as "button".

The fix is to explicitly add the action title as the accessible name for the button control when it's built.
How Verified
Verified with Accessibility Insights and Narrator

Narrator now says the name before saying button (e.g. before it would just say "button", now it might say something like "Microsoft To Do - button").
Microsoft Reviewers: Open in CodeFlow

Do these need to be added to our sample cards that the Visualizer uses?

Do these need to be added to our sample cards that the Visualizer uses?

We already have cards with actions among our samples. What would probably be worthwhile in the future, though, would be to add accessibility tests.

So today the Accessibility tests are essentially the Visualizer + the pre-baked samples they come with. It might make sense therefore to just make sure we tweak those to include this sample as well

In reply to: 543987716 [](ancestors = 543987716)

@almedina-ms another instance of failing .NET PR builds

I think we probably want a better solution than that. The samples there are meant to be complete scenarios demonstrating the usages of cards to people exploring the platform. I don't think we want to pollute that with lower quality test case cards for all the accessibility scenarios we'll end up coming across. We probably need an approach that lets us define accessibility test cards independently of the scenario cards.

In reply to: 544000775 [](ancestors = 544000775,543987716)


[BUG] ERROR: first message must use the "user" role

I keep getting an error message 'first message must use the "user" role message' evrery 4-5 chatbot interactions -  couldn't able to find any pattern why this happenning.

forgot to mention - only way to "fix" it is by clearing the chat history and resend the user message again

ok - I think I figured this out - this issue is originated from connecting  "buffer window memory" node with a size of 4....'when switching to a diffrent memory node ( I changed to Upstash Redis)  the issue is gone....so this could be a vaiable work around until this is fixed.

yeah so what happens is that every 4-5 messages, buffer window memory will limit the size of messages to the specified size. For example:
user: hello
ai: hello
user: how are you
ai: im good
user: whats the weather

then, when you continue chatting, it will append another message like:
user: whats the weather
user: whats going on

since models like anthropic only accept messages that are taking turn, i.e: it must be followed by user or ai, after another, you cant have 2 consecutive messages with same user or ai roles.

so by design, this is not solvable, other models like chatgpt, gemini, mistral dont have this constraint

Is there a solution for this? even temporary or somehow to change how it responds? When used from the embedded chat on the flowise board it doesn't throw this error. But when I use React full-page embed it does

Its now resolved as Anthropic Claude has removed this restriction.


failed if error not defined

actually we can create a node sample without image
an error will be welcome at save time


[szip] Fix mingw import lib names, control linkage

What does your PR fix?
This PR:

restores standard mingw import lib names (...dll.a), resolving the "Could not find proper second linker member" error which was the reason for setting VCPKG_POLICY_SKIP_ARCHITECTURE_CHECK for szip in the mingw triplets,
disables building the static libs for triplets with dynamic linkage, following the "Choose either static or shared binaries" vcpkg guide, and properly modifies the provided cmake config files.

It also changes the version format from version-string "2.1.1-6" to version "2.1.1" port-version 7.

Which triplets are supported/not supported? Have you updated the CI baseline?
all, no

Does your PR follow the maintainer guide?
yes

Even with this PR, the static builds on Windows have an unusual lib prefix (libszip.lib for MSVC, liblibszip.a for mingw). It could be changed now, when the static lib is no longer build in additon to the dynamic lib.

Triplet
release-static
debug-static
release-dynamic
debug-dynamic

windows
libszip.lib
libszip_D.lib
szip.lib *
szip_D.lib *

mingw  before
liblibszip.a
liblibszip_D.a
szip.lib *
szip_D.lib *

mingw after
liblibszip.a
liblibszip_D.a
libszip.dll.a
libszip_D.dll.a

linux
libszip.a
libszip_debug.a
libszip.so *
libszip_debug.so *

osx
libszip.a
libszip_debug.a
libszip.dylib *
libszip_debug.dylib *

*) Before this PR: static lib was also built

When building hdf5:x86-windows:
[359/445] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.20.2-windows\cmake-3.20.2-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=src\CMakeFiles\hdf5-shared.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x86\link.exe  @CMakeFiles\hdf5-shared.rsp  /out:bin\hdf5_D.dll /implib:bin\hdf5_D.lib /pdb:bin\hdf5_D.pdb /dll /version:200.0 /machine:X86 /nologo    /debug /INCREMENTAL  && cd ."
FAILED: bin/hdf5_D.dll bin/hdf5_D.lib
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.20.2-windows\cmake-3.20.2-windows-i386\bin\cmake.exe -E vs_link_dll --intdir=src\CMakeFiles\hdf5-shared.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x86\link.exe  @CMakeFiles\hdf5-shared.rsp  /out:bin\hdf5_D.dll /implib:bin\hdf5_D.lib /pdb:bin\hdf5_D.pdb /dll /version:200.0 /machine:X86 /nologo    /debug /INCREMENTAL  && cd ."
LINK Pass 1: command "C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x86\link.exe @CMakeFiles\hdf5-shared.rsp /out:bin\hdf5_D.dll /implib:bin\hdf5_D.lib /pdb:bin\hdf5_D.pdb /dll /version:200.0 /machine:X86 /nologo /debug /INCREMENTAL /MANIFEST /MANIFESTFILE:src\CMakeFiles\hdf5-shared.dir/intermediate.manifest src\CMakeFiles\hdf5-shared.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library bin\hdf5_D.lib and object bin\hdf5_D.exp
H5Z.c.obj : error LNK2019: unresolved external symbol _SZ_encoder_enabled referenced in function _H5Z__init_package
H5Zszip.c.obj : error LNK2019: unresolved external symbol _SZ_BufftoBuffCompress referenced in function _H5Z_can_apply_szip
H5Zszip.c.obj : error LNK2019: unresolved external symbol _SZ_BufftoBuffDecompress referenced in function _H5Z_can_apply_szip

When building hdf5:x86-windows:

I will take a look. I even did builds with hdf5 but this didn't show up.
Basically, for triplets with dynamic linkage,

the static lib is no longer available,
the default component in cmake config is "shared" now,
there is a preprocessor macro which must be used when accessing the headers (It is in the exported cmake config.)
hdf5's own FindSZIP might be not as outdated as the hdf5 portfile indicates.

I will push the hdf5 changes on top of this PR. I need to fix mingw and pc files.
For purpose of fixing hdf5 mingw (also the import library problem) and pc files, I want to fix the "unusual lib prefix" of the static libs (for mingw at least) - this simplifies fixing the pc files.

* there is a preprocessor macro which must be used when accessing the headers (It is in the exported cmake config.)

SZ_BUILT_AS_DYNAMIC_LIB is not used when compiling hdf5...
I will modify the szip headers for dynamic linkage. This covers all type of uses.

Triplet
release-static
debug-static
release-dynamic
debug-dynamic

mingw with this PR
libszip.a
libszip_debug.a
libszip.dll.a
libszip_debug.dll.a

(= same namespec as linux, osx)

This is now extended to hdf5, and fixes hdf5 build failures with mingw (but no hdf5 cross-builds).

The next hdf5 release will allow mingw lib names per option.
hdf5 has a somewhat strange way of linking "components". It collects "static" and "shared" libs (zlib, szip) but links only to the static ones. That's why the first CI runs failed after changing szip to single linkage.
For passing dependencies of hdf5 via pkg-config, I decided to substitute the imported linker flags by corresponding pkg-config module names. With this approach, all library name and flag fixup is local within the exporting package (zlib, szip, openmpi), and the importing packages doesn't need difficult pattern matching for names or for optimized vs. debug.
I added a pc-file to szip for this purpose.
For hdf5, the mingw namespec is almost as on linux/osx, only the debug postfix is "_D" as for windows.

@longnguyen2004  Do you have any suggestions?

LGTM

"-lszip-static" still seems to slip into the linux hdf5 pc files. I need to verify this again.

Turned out that the repeated find_package(SZIP...) (first failing, then successful) accumulates libs. I updated the patch to handle it gracefully.

Ping.

LGTM, thanks @dg0yt :)


How to test it for our dataset. what are all the steps need to follow

I have cloth images and i want to wrap them on to the model which are already available dataset.
2.. Steps to follow if i have all the model pics and clothe images

Check out the demo sections. You need to prepare data the same way. That includes source/target segmentation(parse CIHP/ graphology) and keypoints and binary mask of the cloth. and then include the names of the file in demo.txt. These are some rough steps.


this.container has no replacement

Taken from https://github.com/DockYard/ember-route-action-helper#overriding-route-action-for-integration-tests
this.container.registry.registrations['helper:route-action'] = helper(() => () => {});

is missed in the codemod. this.container is undefined after codemod. I manually updated with
this.owner.__registry__.registrations['helper:route-action'] = helper(() => () => {});

This codemod could be updated with this translation, or maybe there is a better translation than what I came up with? cc @rwjblue

Hmm, any reason not to update that to this.owner.register('helper:route-action', Ember.Helper.helper(() => {}))?  I'm pretty hesitant to add anything around __registry__ to this codemod...

Hm, I agree with @rwjblue, using anything __ makes me feel slightly uncomfortable! 😉
Also I wonder if that is really within the scope of this codemod, because...

It is not really about test helpers, right?
It is a 3rd party thing. Also there are a few addons supplying their own test helpers, so I am a bit hesitant to start supporting any or all of them here (for those that need to be fixed)
this codemod doesn't handle any changes related to the container/owner so far. AFAIK ember-qunit-codemod does a few owner related transforms, so might be a better place to put this? But 2. still applies to it as well...

Oh shoot. This is the wrong repo. Should have been ember-qunit-codemod. Sorry! Downside of ember-cli-update running all codemods, you have to think harder about where the changes come from :(


[Bug]: User Is unable to add the new mongo URI from the advanced tab

Is there an existing issue for this?

[X] I have searched the existing issues

Description
User Is unable to add the new mongo URI from the advanced tab

Steps To Reproduce

Pull the latest image
Open localhost
Go to admin setting
Go to advanced tab
Add the Mongo URI
click on dave and restart button
Bad request error toast is displayed

Note: when we add same the same URI from env it works
Public Sample App
No response
Environment
Release
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
v1.28

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed

@Nikhil-Nandagopal @abhvsn @RakshaKShetty
The root cause of the issue was identified as the incorrect naming of the environment variable APPSMITH_MONGODB_URI, which should be APPSMITH_DB_URL. This misconfiguration has been corrected in https://github.com/appsmithorg/appsmith/pull/35526, which effectively resolves this bug too.

@Shivam-z thanks for bringing this to the attention. As you rightly suggested this was indeed the problem with misconfiguration at the env level and above mentioned PR fixed this issue. Closing this now 👍🏽

@abhvsn Thank you for closing this issue. Additionally, could you please review the comment addressing a similar issue?


Bumped Django requirement to version 3.1.9

Resolving Dependabot alert.

Changelog => 3.1.9.
The PR will not effect the functionality of the project.


Would it be possible to use the Cake Contrib Icon for your NuGet Package?

Thanks again for creating this Cake Addin, we really appreciate the effort that you have put in to creating it.
We, the Cake Team, recently announced a new Cake Contrib Icon, details of which can be found here:
http://cakebuild.net/blog/2017/06/new-cake-contrib-icon
Would you consider changing the nuspec file for your NuGet Package to use this new Cake Contrib Icon?  If so, the recommended URL to use is:
https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png
Details of the above URL can be found in the repository here:
https://github.com/cake-contrib/graphics
Please let me know if you have any questions.

Added in 1.1.3.

@MihaMarkic that is great news, thank you very much!


Fix btn warning

The following warning appears when rendering footer items:

Figure out what's up with that.

just switched it to a  and it seems to be working fine


Update Jangouts to run with latest Janus-gateway

This PR can be considered as a major step towards solving the #187 issue.

I have updated the bower.json to run with Janus-gateway (up till the janus commit - https://github.com/meetecho/janus-gateway/commit/0ce774d4d2eb2b44d771b77b099183aae07857e9).
This PR is a result of this conversation with Janus-gateway maintainers.

@imobachgs @ancorgs We are quite close to our aim of updating Jangouts (master-branch) to support latest Janus (at least up to this commit ).
This PR updates Jangouts to support Janus-gateway (up to commit done on Feb 27)

@imobachgs @ancorgs
One thing more. Currently, I'm trying to update Jangouts to run with more latest Janus-gateway changes.
After some chat with Janus maintainers, I've come to know that after the commits done on Feb 27 in Janus-gateway repo, some methods exposed by the janus.js library have changed. So, I guess I'll have to look into latest janus.js and Janus API documentation for accommodating these changes in Jangouts.
Some progress in this regard can be seen here.

It's sad that even after merging this PR, #182 still can't be merged. I was sooo... close. But I'm trying!

@ancorgs Now you can merge this PR for latest janus support. Please checkout PR #182 , after merging this.

I think this pull request fixes the adapter.js issue in the wrong place (Jangouts instead of Janus). I have prepared this pull request to fix things for everybody https://github.com/meetecho/janus-gateway/pull/917
I hope to release a new version with the proper dependencies fixed on Monday (Janus folks are usually fast as lightning accepting patches).

@ancorgs Even better! I should've considered that myself. One more thing - the config object now requires data: true for chat message communication, which this PR fixes for jangouts. Is this something that should be corrected in Janus??

@ancorgs Now I removed adapter dependency..

I'm having problems to make the data channel work in Firefox 52.1.1 with the latest Janus (compiled from the master branch of the repository). Even with your suggested changes it does not work. I will need further debugging.

At some point I get 'State change on data channel: null'. I does not happen with old versions of Janus. Most likely the culprit is the commit you already mentioned in your question to the Janus Google group (I have not verified that), but your fix (adding data: true`) makes no difference to me.

@ancorgs I guess I have found what's happening. The createOffer in pluginHandle object has data: false, by default. See updated API here - here https://janus.conf.meetecho.com/docs/JS.html.
Now, I've done the required chages to this PR and I'm also getting -
State change on data channel: open

@code-master5 Yes. I also have (almost exactly) the same change prepared. Looks like we were doing the same at the same time. :wink: I tested it and everything seems to work.
It took me quite some time because recent versions of Janus break Jangouts with Firefox. I found the offending commit and I will report the problem to Janus developers.
So looks like everything is cleared up for a new release of Jangouts... as long as it's used with a Janus gateway older than that commit (April 28th). I will do the release today... after RealWorkImPaidFor(TM). 😄

@ancorgs This is exciting! I'll get to work with newer version of Jangouts. Also now we can have Pin Rooms... 😉

Closed in favor of #193


Firebase Auth emails with '.al' suffix dont work

On iOS if you try this method (im not sure for other create methods)
FirebaseAuth.instance.linkWithEmailAndPassword()
with an email something like
<EMAIL_ADDRESS>it doesn't work on iOS. it seems that the suffix '.al' cant be seems valid. it works fine on android.

@kondasoft
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/826. Any further collaboration will be done there.


[PE-D][Tester E] addPolicy does not add if no coverage specified

User guide states "A policy can one or more coverages (including 0)." but the commands below which do not have coverages specified all fail
addPolicy ti/PruShield cmp/PRU cms/10% 5% 1%
addPolicy ti/One cmp/FWD cms/100% 100% 100%
Command should work given that coverages do not need to be specified

Labels: type.FunctionalityBug severity.Medium
original: nerbnerb/ped#6

Include in UG to mention cannot have 0