ValueError when using dictionary format for input of optimizer options in Tensorflow 2.2.0 Keras models

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes (but very basic)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): I used pip
TensorFlow version (use command below): 2.2.0
Python version: 3.6.10
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: More than one machine

Describe the current behavior
I am using the dictionary format (see code below) to input options to an optimizer when compiling a Tensorflow Keras model. However, in Tensorflow 2.2.0 this throws an error. I fixed this issue for now by switching back to Tensorflow 2.1.0. Another workaround is to define the loss beforehand as tf.keras.losses.Nadam(**config). Neither of those is a final solution so I thought it best to report this bug.
Describe the expected behavior
The dictionary format should work for easy input of non-default options of optimizers when compiling Keras models with Tensorflow 2.2.0.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf
model = tf.keras.Sequential()
model.add(tf.keras.layers.Dense(3, activation='sigmoid'))
compiler_params = {
    "optimizer": {
        'class_name': 'Nadam',
        'config': {
            'lr': 0.0001
        }
    }
}
model.compile(**compiler_params)

Other info / logs
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
ValueError                                Traceback (most recent call last)
<ipython-input-2-187c8cc52bd6> in <module>
     11     }
     12 }
---> 13 model.compile(**compiler_params)
     14

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\keras\engine\training.py in compile(self, optimizer, loss, metrics, loss_weights, sample_weight_mode, weighted_metrics, **kwargs)
    326       self._run_eagerly = kwargs.pop('run_eagerly', None)
    327
--> 328       self.optimizer = self._get_optimizer(optimizer)
    329       self.compiled_loss = compile_utils.LossesContainer(
    330           loss, loss_weights, output_names=self.output_names)

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\keras\engine\training.py in _get_optimizer(self, optimizer)
    348       return opt
    349
--> 350     return nest.map_structure(_get_single_optimizer, optimizer)
    351
    352   @trackable.no_automatic_dependency_tracking

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\util\nest.py in map_structure(func, *structure, **kwargs)
    615
    616   return pack_sequence_as(
--> 617       structure[0], [func(*x) for x in entries],
    618       expand_composites=expand_composites)
    619

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\util\nest.py in <listcomp>(.0)
    615
    616   return pack_sequence_as(
--> 617       structure[0], [func(*x) for x in entries],
    618       expand_composites=expand_composites)
    619

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\keras\engine\training.py in _get_single_optimizer(opt)
    342
    343     def _get_single_optimizer(opt):
--> 344       opt = optimizers.get(opt)
    345       if (self._dtype_policy.loss_scale is not None and
    346           not isinstance(opt, lso.LossScaleOptimizer)):

~\AppData\Local\Continuum\anaconda3\envs\cinc3\lib\site-packages\tensorflow\python\keras\optimizers.py in get(identifier)
    900     return deserialize(config)
    901   else:
--> 902     raise ValueError('Could not interpret optimizer identifier:', identifier)

ValueError: ('Could not interpret optimizer identifier:', 0.0001)

@hallabjorg5
Is there any particular reason for using a dictionary, I have tried the code with out dictionary and it works with out error.
Can you please refer to this link and update, nowhere has a dict been used.

Apart from backwards compatibility reasons, it has been a very nice feature to easily feed parameters from config files.

Was able to reproduce the issue in TF v2.5 ,please find the gist here..Thanks !

Hi @hallabjorg5 ! According to this document ,You can pass only a string value for optimizer  and dictionary/list for other parameters in model.compile.

Is it possible that you create an optimizer object and provide it to Model.compile() instead of a dict?

Hi @hallabjorg5 !
This issue is getting resolved after passing compile_param like below. Attached gist for reference.
compile_kwargs = {
        'loss': tf.keras.losses.MeanSquaredError(),
        'optimizer': tf.keras.optimizers.Nadam(learning_rate=.001),
    }
model.compile(**compile_kwargs)

Thank you!


Fixing subdomain issues #114

I test if the domain of the cookie match the host url. So, for the url foo.bar.com :

bar.com will match
barfoo.foo.bar.com will not match
foo.bar.com will match

It fix the issue #114
We still have to handle the situation where we have 2 cookies :
const cookie1 = {
  domain: "foo.bar.com",
  name: "session",
  path:"/",
  value: "6de9c6965c1465ed"
};

const cookie2 = {
  domain: "bar.com",
  name: "session",
  path:"/",
  value: "a1784ef82bc"
};

Then the code is non determistic.
It is only for the webkit version

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.


Azure function extension Icon dissapeared from left hand menu in Visual studio code. Azure functions extension is installed

The Azure function extension Icon disappeared from left-hand menu in Visual studio code. Azure functions extension is installed

Could you right-click the primary-side bar? If you see Azure, try clicking on that.

If it's not there, did you happen to open a new workspace? If your workspace isn't trusted, sometimes it'll just hide all of your Azure views without telling you.
You can check your workspace trust settings by pressing F1 and then typing manage workspace

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Update index.md

A simple implementation of class and object in python.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

A simple implementation of class and object in python.

Please use PR titles which explain what you are changing. If it is a translation, please also indicate translation: language name.  This let's the reviewer quickly know what kind of contribution you have made.
Thank you

Hi @mimikaan. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[BUG] using constant variable in enum, get wrong value

Describe the bug
IDL definition:
const int32 matrix_size = 5;

type Matrix = int32[matrix_size][matrix_size];

generated C code:
typedef int32_t Matrix[5][5];

extern const int32_t matrix_size;

IDL definition:
enum enumColor {
    red,
    green = 10,
    blue = 2 * 10
}

generated C code:

typedef enum enumColor {
    red,
    green = 10,
    blue = 20
} enumColor;

IDL definition:
const int32 color_val = 5;

enum enumColor {
    red,
    green = 2 * color_val,
    blue = 2 * 10
}

generated C code:
typedef enum enumColor {
    red,
    green = 10,
    blue = 20
} enumColor;

All above are ok, but
IDL definition:
const int32 color_val = 5;

enum enumColor {
    red,
    green = color_val,
    blue = 2 * 10
}

generated C code:
typedef enum enumColor {
    red,
    green = 1,
    blue = 20
} enumColor;

green is 1, but not 5!
Then, if
IDL definition:
const int32 color_val = 5;

enum enumColor {
    red,
    green = 1 * color_val,
    blue = 2 * 10
}

generated C code:
typedef enum enumColor {
    red,
    green = 5,
    blue = 20
} enumColor;

green is 5!
To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

OS:
eRPC Version:

Steps you didn't forgot to do

[X] I checked if there is no related issue opened/closed.
[X] I checked that there doesn't exist opened PR which is solving this issue.

Additional context

Hi @thewon86 , thank you for creating PR. As you can see, PR for this fix was created. Until it will be released you can take changes and build application with fix.


Wrong tag 0.0.13 -> 0.3.13

Latest tag is 0.0.13 instead of 0.3.13 causing package manager to download second to last version.

oops, sorry and thanks for reporting... just fixed it :)


multiple selectors

Hello,
It would be really great to allow for multiple selectors per url request,
something like:
        x(url, [
          'selector1',
          'selector2'
        ])(function(err,results) {
        })

Thank you great work!

why about follow the issue template? please use it to reopen the issue


Merge recipe with sequences within map bad indent

Hello,
I am using the org.openrewrite.yaml.MergeYaml recipe and apparently it is not indenting the sequences correctly.
My source yaml is
noncore:
  key1: value01

My recipe is
  - org.openrewrite.yaml.MergeYaml:
      key: "$"
      yaml: >
        core:
          - map2:
              value:
                - 1
                - 2
      acceptTheirs: true
      fileMatcher: "**/application*.yml"

I expect something like
noncore:
  key1: value01
core:
  - map2:
      value:
        - 1
        - 2

But in the execution we see that the sequence that is inside a map has wrong identation
noncore:
  key1: value01
core:
  - map2:
      value:
  - 1
  - 2

We have a complete example in https://github.com/ruben-garciapariente/test-openwrite/tree/merge-sequence-bug-2
We are testing with 7.17.0-SNAPSHOT, if we test with version 7.16.0 we have the issue fixed in https://github.com/openrewrite/rewrite/issues/1275
Thank you very much

Thanks for the thorough bug report @ruben-garciapariente. It's especially helpful that you tried both 7.16.0 and 7.17.0. We'll look into this soon


KiCad 6.0.9 footprint and symbols are not linked

I installed the plugin sucessfully but in schematic when I try to add the symbol, footprint is show up as blank.

I have double check the footprint installation and it looks fine. Same for the symbol as well.

Can you assign the matching footprint manually after inserting the symbol into your schematic?
It's possible only the default symbol-to-footprint assignment is missing...

@dhruvinsh thanks for flagging this - I just pushed a change that should now set the default footprint in the symbol.
If you want to test it, simple re-download and re-install the library. Then the correct footprint should be visible in the screenshot you shared originally.


marker custom icon and info window

Before I attempt adding marker clusterer to my project, I would like to ask this:
Right now in my project I create a marker for every object of my data model
let marker = GMSMarker(position: position)
....
marker.map = mapView
And I override the following method for presenting my own info window
func mapView(mapView: GMSMapView, markerInfoWindow marker: GMSMarker) -> UIView? {
let infoWindow = NSBundle.mainBundle().loadNibNamed("InfoWindow", owner: self, options: nil)[0] as! CustomInfoWindow
//customization code for the infoWindow
.......
return infoWindow
}
When my data model changes I call
mapView.clear()
and I add the new markers
If I use marker clusterer
Will I be able to add GMSMarker objects to the clusterer. Can they have custom icons (per marker) and custom info windows?
Will I be able to clear all markers from the clusterer and add new ones (when I get new data from my backend)?
Thanks in advance for any help / advice

I have the same doubt.
Is it possible to add a GMSMarker instead of POItem? If so, how can we do this?

At this stage we do not have a plan to support adding GMSMarker directly to the GMSClusterManager. We'd like to have complete control of the markers we created to avoid confusion like a GMSMarker is added and an animation is performed on its location.
The good news is that the marker is completely customizable. Please take a look at this thread for some discussion on how to achieve it: https://github.com/googlemaps/google-maps-ios-utils/issues/21.
We are planning to add some more events or methods to make it easier to customize cluster or cluster item markers. We will keep you posted when it's available.

We have released a new version 1.1.x with easy marker customization. Please update your cocoapod or source files.
For more details see https://github.com/googlemaps/google-maps-ios-utils/blob/master/CustomMarkers.md

@mountainvat Thank you for the CustomMarkers example. It works fine with Synchronous methods, however it freezes UI until it's finished downloading the images, which I do not wish.
I have implemented Async downloading and it's working fine. However, while it's loading the image for a single marker or creating the mashed up cluster icon, it displays the default pink marker for cluster item and a default cluster round blue color icon with number.
When the images are loaded, the default icons get replaced with the custom images.
My question is how to disable the showing of default icons? Please help!! Thanks!

Hi,  I am fresher in swift and i want add a custom marker icon in  clustering. so Please give me any suggestion as a code.
Thanks.


Delete duplicated product_list fixture

Delete duplicated product_list fixture.
Update product_list with data from duplicated fixture.
Updated tests.
Fixes #1369
I want to merge this change because...
We have two product_list fixtures in conftest.py
Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Python code quality checks pass: pycodestyle, pydocstyle, pylint.
[x] JavaScript code quality checks pass: eslint.

Codecov Report

Merging #1407 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1407   +/-   ##
======================================
  Coverage    82.9%   82.9%
======================================
  Files         128     128
  Lines        5775    5775
  Branches      663     663
======================================
  Hits         4788    4788
  Misses        830     830
  Partials      157     157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbedaa...66c4fea. Read the comment docs.


Logging In?

Sorry if this is spelled out in the documentation (or InstaPy), but I was wondering if there was a way to login during the session.  I'd like to get the likes of a friend's pics, but his profile's private - I could access it if I could figure a way to log in during the Headless session.  Thanks!

@mattalhonte Well, for this issue, unfortunately, as of now, there is no such way.
It's a nice idea, if you're interested, feel free to contribute to this project.
Thank you


update json_formatter to output data only for query

Fixes #180

@andrew-morris : can you give this branch a try and see if this is what you were hoping for?


Turned project into a python CLI package

I added a real setup.py file, github action, and changed the docs. I did NOT change any of the functional code in main.py, just moved it around.
After this is merged you can simply go to https://pypi.org/ create an account, add your pypi account and username to this GitHub project by going to
settings -> secrets -> "New repository secret".
Then add PYPI_PASSWORD and PYPI_USERNAME as secrets.
When you have done that you can simply make a new release and the Github action will take your Pypi secrets, build your python package, and upload it to Pypi!
After that, anyone can get your package by pip install mc-server-python.
Let me know if you have any questions. I am happy to walk you through everything I did.

That's really cool! I appreciate the help/guiding.
I will make sure to do that.

So I followed what you told me but the project doesn't seems to add in PyPi, so not available with pip. I added secrets with PYPI_PASSWORD and PYPI_USERNAME as name and my password/user as value.

So I followed what you told me but the project doesn't seems to add in PyPi, so not available with pip. I added secrets with PYPI_PASSWORD and PYPI_USERNAME as name and my password/user as value.

You need to verify your Pypi email address. You can find the log for your issue under "Actions"
https://github.com/Yot360/mc-server-python/runs/2643075058?check_suite_focus=true

So I followed what you told me but the project doesn't seems to add in PyPi, so not available with pip. I added secrets with PYPI_PASSWORD and PYPI_USERNAME as name and my password/user as value.

@Yot360
You need to verify your Pypi email address. You can find the log for your issue under "Actions"
https://github.com/Yot360/mc-server-python/runs/2643075058?check_suite_focus=true

Oh, thank you, let me try again.

My email is set as primary/verified but the same error shows up in logs.

My email is set as primary/verified but the same error shows up in logs.

@Yot360
The name was already taken. I made a new PR. It should fix it.


forms: user sign-up fails due when profile form is enabled.

Traceback (most recent call last):
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/werkzeug/wsgi.py", line 659, in __call__
    return app(environ, start_response)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask_debugtoolbar/__init__.py", line 125, in dispatch_request
    return view_func(**req.view_args)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask_security/decorators.py", line 225, in wrapper
    return f(*args, **kwargs)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask_security/views.py", line 117, in register
    user = register_user(**form.to_dict())
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask_security/registerable.py", line 29, in register_user
    user = _datastore.create_user(**kwargs)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/flask_security/datastore.py", line 167, in create_user
    user = self.user_model(**kwargs)
  File "<string>", line 4, in __init__

  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/state.py", line 306, in _initialize_instance
    manager.dispatch.init_failure(self, args, kwargs)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/util/compat.py", line 183, in reraise
    raise value
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/state.py", line 303, in _initialize_instance
    return manager.original_init(*mixed[1:], **kwargs)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/ext/declarative/base.py", line 649, in _declarative_constructor
    setattr(self, k, kwargs[k])
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/attributes.py", line 224, in __set__
    instance_dict(instance), value, None)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/attributes.py", line 807, in set
    value = self.fire_replace_event(state, dict_, value, old, initiator)
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/attributes.py", line 829, in fire_replace_event
    self._replace_token or self._init_append_or_replace_token())
  File "/Users/lnielsen/envs/zenodo3/lib/python3.5/site-packages/sqlalchemy/orm/attributes.py", line 1156, in emit_backref_from_scalar_set_event
    child_state, child_dict = instance_state(child),\
AttributeError: 'dict' object has no attribute '_sa_instance_state'

**form.to_dict() contains the profile key

Fixed in d55127181d7704d9fd4f7922bdc75ba7c468aa2d


Gowin. Add the DCS primitive

Not so much adding the primitive itself, but only its DCS_MODE parameter, without which an error occurs.

Under what conditions does an error occur? Why is that?

You try to use a DCS primitive with a parameter specified.
Why? Apparently because the parameters must be described, which is what this PR actually corrects - it describes the parameter.
DCS dcs(
    .CLK0(1'b1),
    .CLK1(clk),
    .CLK2(1'b1),
    .CLK3(1'b1),
    .CLKSEL({1'b0, 1'b0, key, 1'b0}),
    .SELFORCE(1'b1),
    .CLKOUT(clk1)
);
defparam dcs.DCS_MODE="CLK1_GND";

2.3.2. Analyzing design hierarchy..
Top module:  \top
ERROR: Module `DCS' referenced in module `top' in cell `dcs' does not have a parameter named 'DCS_MODE'.

Got it, looks good, matches UG286


Help to reproduce HSE06 functional using the tools to customize RSH functionals

Dear @susilehtola or any expert among PySCF developers,
Since we are interested in RSH functionals that include HF exchange only in the short-range part, I am attempting to reproduce the HSE06 functional using the available tools to customize RSH functionals.
The closest I have come using the "HYB_GGA_XC_HSE06" (converged SCF energy = -76.3869601455738 for H2O) flag is as follows:
0.25 * SR_HF(0.11) + 0.0 * LR_HF(0.11) + .75 * PBE, PBE * 1.0
(converged SCF energy = -74.1826256469055 for H2O)
Certainly, this is wrong. So, I would appreciate any help.
Sincerely,
Rodrigo.

What do you mean by "reproducing" HSE06? As we have recently discussed in
S. Lehtola and M. A. L. Marques, Reproducibility of density functional approximations: how new functionals should be reported, J. Chem. Phys. 159, 114116 (2023). doi:10.1063/5.0167763
the HSE family is the worst case of (un)reproducibility: various codes implement completely different functionals under the names HSE03 and HSE06.
If you want to know what is inside the Libxc functional, just look at the Libxc source. Alternatively, you can extract data from "mixed" functionals like HYB_GGA_XC_HSE06 using the functions
/* Gets the IDs of the auxiliary functions */
void xc_aux_func_ids(const xc_func_type *p, int *ids);
/* Gets the weights of the auxiliary functions */
void xc_aux_func_weights(const xc_func_type *p, double *weights);

which tell you which functions are used by the implementation. Of course, you also need to plug in the right hybrid part.
Glancing at your trial, you have long-range HF exchange while there is none in HSE, and also you have the wrong exchange functional: you need to use (one of the many) range-separated PBE exchange functional(s). The correct exchange functional is XC_GGA_X_WPBEH.

Thanks @susilehtola. I certainly read your paper. I'm not trying to reproduce HSE06 from other codes. Instead, I'm trying to run "HYB_GGA_XC_HSE06" from PySCF/LibXC and then get the same results using an equation similar to the one I wrote in the previous email.
That's why I chose HYB_GGA_XC_HSE06. Since HSE03 has different omega values for the HF and DFT parts. Yes, you are right, I also read the HSE source code inside LibXC and saw it uses XC_GGA_X_WPBEH. I also tried this option. It is not giving me the same answer. After getting HSE06 right, the idea is to make our own functional. About the long-range, I thought that multiplying by zero was the right way to "turn it off."
Sincerely,
Rodrigo

The issue is probably that you also need to set the range separation parameter in gga_x_wpbeh like Libxc does, while I think PySCF may not yet have this functionality. I do remember some pull request in this direction, though...

About the long-range, I thought that multiplying by zero was the right way to "turn it off."

Oh, I didn't notice you had a zero factor. Regardless, you shouldn't need that at all.

Thank you very much.


Improve README

Hmm, this PR was merged before I had a chance to review :( Also, this repo uses bors, so it would be better to merge it using "bors merge" (not that it matters a lot).


Game Crashes when trying to play a level

Describe the bug
Sometimes, the game crashes when you try to play a level; the crashlog states that this mod is the cause.
To Reproduce
Whether the game crashes or not depends on the level. For this crashlog, the level that crashed was this ID: 90922017
Crash log (from Geometry Dash/geode/crashlogs)
2024-06-22_00-17-25.log
I checked that I have the latest version of this mod
Yes

I'm pretty sure it's the same thing as !50, I'm working on a fix rn


[FLINK-2692] Untangle CsvInputFormat

This PR splits the CsvInputFormat into a Tuple and POJO Version. To this end, The (Common)CsvInputFormat classes were merged, and the type specific portions refactored into separate classes.
Additionally, the ScalaCsvInputFormat has been removed; Java and Scala API now use the same InputFormats. Previously, the formats differed in the way they created the output tuples; this is now realized in a newly introduced abstract method "createOrReuseInstance(Object[] fieldValues, T reuse)" within the TupleSerializerBase.
Fields to include and field names are no longer passed via setters, but instead via the contructor. Several new contructors were added to accommodate different use cases, along with 2 new static methods to generate a default include mask, or convert an indice int[] list to a boolean include mask.
Classes no longer have to be passed separately, as they are extracted from the typeinformation object.
A few sanity checks were moved from the ExecEnvironment to the InputFormat.
The testReadSparseWithShuffledPositions Test was removed since monotonous order of field indices is, and afaik was, not actually necessary due to the way it was converted to a boolean[].

Looks good to me. Is there maybe a way to also make readRecord() common to tuples and POJOs, because there we duplicate all the code and only the call that creates the tuple or POJO (or fills it) is different, if I'm not mistaken.
Thanks for the work you're putting in there, I know it's not glorious but some parts need cleanup/refactoring. :smile:

We could move the differing lines (Csv:L114 Pojo:L218->L225) into separate methods that is called from a generic readRecord() method. something like fillRecord(OUT reuse, Object[] parsedValues).

Could, yes, but I'm fine with both, it is already cleaner than what we had before.
The user facing API is not changed, right? So I think this is good to merge.

yes, the user facing API is unchanged; it's only a problem for those that uses the CsvInputFormat directly for a createInput() call or whatever.

I think you can go ahead and merge it then.

I agree with @aljoscha and you on the readRecord() code. It would be nice to have the common parts of readRecord() in the CsvInputFormat and specific fillRecord in the tuple and POJO formats.
Otherwise, the PR looks really good.

@fhueske I've addressed your comments.

any other comments? I'll merge it other wise later on.

I think it's good :+1:

Merging this.


Engage Weekly - March 7th, 2022

This is a weekly public meeting to discuss the engagement across different areas of the Postman API Network, coordinating and planning around the advocacy, education, and community building work occurring within Postman Open Technologies.
Agenda:

Administrative - Taking care of administrative aspects of running this meeting.

Intake

Github
Slack - #api-network-partnerships #api-network-wins
Airtable -- Just for master index.

Public - This meeting will be open to the network, partners, and general public.

Trending - What teams, APIs, and collections are trending lately on the network.

Weekly Review - Worked our way through what is trending

Priorities - What priorities requests have come in from internal and external stakeholders.

Pipedrive - Kin will work process and hand over to Arlemi.
Zoho Sign - Arlemi is working with.
Zoho CRM - Write a blog post.
Plaid - Write a blog post.
Huwawei - What is next for Huwaei?
Twitter - Meeting with this week to discuss their OpenAPI journey.
Github - Have a meeting coming up with Github to discuss their Postman collections / workspace.
Paypal - Discussions about their workspace possibilities.
Zoom
Axis Bank
Grey Noise (Website) (API)
Ory (Website) (Postman Team)
Dolby (Team) - New API coming GA in March - Music mastering. Guest blogging.
Render (API) (Workspace?)
John Deere (API)
Razorpay (Workspace - Engagement conversation.
Docker
Autodesk
Infobip
WhatsApp
Backblaze
Salt Security - Road Show.
Tyk (Workspace) - We have blog post and other storytelling occurring.

Campaigns - What are the areas we are focusing on with campaigns and components.

Studio Ghibli - International (under-represented)
Cryptowatch - Websockets opportunity?
Google - gRPC

Find more partners
Microcks story.
Public gRPC APIs? (https://groups.google.com/g/grpc-io/c/EXpZa1vBooo?pli=1)

AmberData
API3 - Breaking Changes podcast.

Opportunities - Identifying where the opportunities are for focusing our attention.

Web3
Websockets echo coming. Need gRPC echo?
Kroger - experimental!
OpenText - https://developer.opentext.com/
Discourse
API-First Index

Please add any agenda items you’d like to discuss below, and we will meet weekly, and push forward projects, productions, stories, collections, and tools to support our work.
Meeting:

January 31st, 2022 - 8:30 AM PST
Zoom - Ask for access below.

Stripe DevChats


Add global initialization event

Adds a global initialization event for asynchronous injection: ethereum#initialized
Restructures the repo and the module's exports

Adds exported initialization utility methods
Compare work with the extension's inpage.js

Major version bump to 5.0.0

@Gudahtt done


⚠ API - Lens has degraded performance

In 7665c25, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 345 ms

Resolved: API - Lens performance has improved in 2a1dfab after 9 minutes.


Consideration for mkdocs get-deps regarding the [ansi] extra

Hi!
I am thinking how to make this plugin work out of the box with mkdocs get-deps.
Most people would probably want it to suggest markdown-exec[ansi] but it currently gives you just markdown-exec and there's no way to make it include [ansi].
Here are some things that could be done:

Just make pygments-ansi-color a default dependency of this plugin - any big reason why not?

Add a new config that people should use :
 - markdown-exec:
     ansi: required   # one of: [off, required, auto], default: auto

(bonus compared to the current behavior: it also guards against the ansi feature silently not working - the required setting would break on missing import)
in which case we can put this option into extra_dependencies in https://github.com/mkdocs/catalog

Somehow just directly put markdown-exec[ansi] into https://github.com/mkdocs/catalog

Separately, I also noticed by reading the implementation that the CSS file is currently also always included into the final site, whether or not the ansi feature was successfully enabled.

Done. We can now update the catalog. Will send a PR.


CDAP-7664 Update quicklinks.json using HDP 2.5 Hive as example

This updates the Quick Links section.

one question, but as long as its been tested 👍 lgtm

I don't have an easy way to test with ssl.enabled but this is the exact syntax used by Hive for LLAP's UI, which supports SSL on a different port, just like we do.


"tsd-s3cmd --register" errors: No such file or directory: '/home//.config/tacl'

Running tsd-s3cmd --register gives a non-intuitive error:
(base) ofrei@comorment:~$ tsd-s3cmd --register
Traceback (most recent call last):
  File "/nrec/projects/ofrei/miniconda3/bin/tacl_admin", line 14, in <module>
    from tsdapiclient.configurer import read_config, update_config, print_config, \
  File "/nrec/projects/ofrei/miniconda3/lib/python3.9/site-packages/tsdapiclient/configurer.py", line 11, in <module>
    TACL_CONFIG = get_config_path() + '/config'
  File "/nrec/projects/ofrei/miniconda3/lib/python3.9/site-packages/tsdapiclient/tools.py", line 113, in get_config_path
    config_path.mkdir()
  File "/nrec/projects/ofrei/miniconda3/lib/python3.9/pathlib.py", line 1313, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/home/ofrei/.config/tacl'

Workaround is to simply create those folders - but it's non-intuitive, thanks to @Sandeek for pointing this out!
(base) ofrei@comorment:~$ mkdir /home/ofrei/.config
(base) ofrei@comorment:~$ mkdir /home/ofrei/.config/tacl

Fixed in https://github.com/unioslo/tsd-api-client/commit/7cb066f386515a6f06fed440f2019c074dd7983b will publish a new release to PyPi.

Now fixed with https://github.com/unioslo/tsd-s3cmd/commit/018e734dfb38ef015ce6e5c3c339036ca10821cb


fix: Make quay.io use pull secret only

If the remote registry is quay, we don't have user/pass as we only use the pull secret, avoid using them.
Fixes #452

:tada: This PR is included in version 1.10.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


APEXCORE-566 Computing bufferServerBytes in the LogicalOperatorInfo

@bhupeshchawda Please review.

Done.
Thanks,
Francis
On Thu, Nov 3, 2016 at 4:56 PM, Bhupesh Chawda<EMAIL_ADDRESS>wrote:

@bhupeshchawda commented on this pull request.
Looks good. Can you add a unit test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/apex-core/pull/414#pullrequestreview-6986405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVHhtNUUdzASzQC7yncNwO1TspDJS-K8ks5q6cTWgaJpZM4KiPK4
.

IMO, it is questionable how useful total number of bytes/s emitted/consumed by an operator metric is. It will be more useful to provide such metric for each logical operator port.

Looping in @sashadt


[Help] How to identify elements which are not visible in inspect.exe

Hi, We have a windows desktop based application which is built on WPF.
I was trying to Automate the same using WinAppDriver, in Java language (grovvy to be specific)
However, there are lot of instances where we are not able to locate certain elements, either by any of the locators.
I am not much aware of WPF, and i heard there is something called controls.
Now when i tried our application to automate using Ranorex, the same UI elements which was not visible in inspect.exe, Ranorex easily identifies them.
Please guide how such elements can be identified in WinAppDriver

Did you try the (WinAppDriver) UIRecorder? It generates XPath strings you may find useful.

Even with UIRecorder I couldn't able to locate the item.

I'm trying to locate the dropdown control in an Microsoft Excel cell and couldn't able to locate that control neither by inspect.exe nor by UIRecorder. Is there any other way  to locate this item? Any help here is appreciated.

Hi @sachinrupadhyay and @Punniyakotti,
please tryout Junlin's workaround here and let us know if that does the trick.

This does not answers my question @hassanuz

Any one has solution for this issue?


Update package on crates.io

Hi,
Could you update the version of the package on crates.io ? It seems that the published version does not have inflate_bytes. The last update was one year ago.

Closed by https://github.com/PistonDevelopers/inflate/pull/20


test: Allow pull request ref in commit subject

Modify commit message validation to ignore any pull request reference at
the end of the subject line when checking that there are no more than 50
characters.

I ran master with both pull 47 and pull 41 with Red Hat and Ubuntu fine. I ran with double bonded.


Move to GitHub

[ ] Adjust CI configuration
[ ] Adjust documentation

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@186a008). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   86.04%
=========================================
  Files             ?        5
  Lines             ?       86
  Branches          ?        0
=========================================
  Hits              ?       74
  Misses            ?       12
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186a008...3c212f2. Read the comment docs.


Fix typos in the ssl-passthrough annotation documentation

Related to #502

@ankon please open the PR in the main repo kubernetes/ingress

Question... Does this:
Important: using the annotation ingress.kubernetes.io/ssl-lassthrough invalidate all the other availables annotations. This is because SSL Passthrough works in L4 (TCP).

Mean that I can't use any other ingresses on the same controller?  Is the above statement just for the one ingress or for the entire controller?  It isn't clear.

@snoby it means that for the same Ingress rule is not possible to use more annotations. This does not applies to different ingress rule/s


New points system

NOTE: this is ONLY for the linear points system, i didn’t start on the exponential system for extremes+ lol. it’s prob just gonna be easier to do this first and then tackle that.
uh so uh basically linear points system! yeah… cool

NOTE: this is ONLY for the linear points system, i didn’t start on the exponential system for extremes+ lol. it’s prob just gonna be easier to do this first and then tackle that.
uh so uh basically linear points system! yeah… cool

i sure am pretty happy rn

i'm not gonna actively update this but hi
https://www.desmos.com/calculator/6wil2khnfr


situational_graphs_reasoning_msgs: 0.0.0-1 in 'iron/distribution.yaml' [bloom]

Increasing version of package(s) in repository situational_graphs_reasoning_msgs to 0.0.0-1:

upstream repository: https://github.com/snt-arg/situational_graphs_reasoning_msgs.git
release repository: https://github.com/ros2-gbp/situational_graphs_reasoning_msgs-release.git
distro file: iron/distribution.yaml
bloom version: 0.11.2
previous version for package: null

Looks like this package was approved in #40802, now just holding for Iron sync


update some docs about Cluster

Updated the operating system versions supported by different cluster roles in ClusteRrole.
Removed cluster abnormal status from the ClusterStatus document and added unknown status and failed to create (self-created cluster) status.
Fix a old links in JoinCluster.

ClusteRrole 需要 rebase 一下，刚把结构调整了，方便链接引用


[Feature Request]: Add ability to pass conversation history (messages) between group chats

Is your feature request related to a problem? Please describe.
When using the AutoGen framework to manage group chats involving multiple agents, I encountered a limitation when attempting to resume a group chat. Specifically, I want to persist the conversation history from a previous group chat session and continue the conversation with the same or modified set of agents. However, when I use the GroupChatManager.resume method to resume a chat, the historical messages from the previous session are not injected into the new session. This results in the agents treating the resumed chat as a completely fresh conversation, ignoring any context from the previous chat session.
Currently, there is no built-in method to pass or persist historical messages directly between group chats, which limits the continuity of conversations across sessions.
I've noted that it is seemingly possible to inject messages within the messages= variable enumerated within groupchat. Nonetheless, passing a conversation history into this variable as a List[Dict] does not work. The agents simply ignore the previous conversation.
Describe the solution you'd like
Ideally, it would be nice is the manager.resume permitted conversations from other group chats to persist into new ones, irrespective of the population of either group.
An alternative fix to this issue might be to fix the issue with the messages= variable not being used/initialized when the groupchat begins.
I have not looked into source code, so I apologize for my ignorance on these matters.
Additional context
It would be lovely if this worked:
new_messages = [
    {"content": "Hi Bob, did you know that manta rays can change their skin color?", "role": "assistant"},
    {"content": "Hi Alice, no I did not know that?","name": "bob", "role": "user"},
]

groupchat = autogen.GroupChat(
    agents=[alice, bob],
    messages=new_messages,
    speaker_selection_method="round_robin",
    max_round=5,
)

manager = autogen.GroupChatManager(groupchat=groupchat, llm_config=llm_config)

chat = alice.initiate_chat(
    manager,
    message="What was my first message to you?",
    clear_history=False,
)

Currently, the new_messages are ignored:
alice (to chat_manager):
What was my first message to you?

Next speaker: bob
bob (to chat_manager):
Your first message to me was: "What was my first message to you?"

running into the same issue. "messages" given to the group chat seem to just be completely ignored...

Did you set clear history to false when you use resume?
https://microsoft.github.io/autogen/0.2/docs/topics/groupchat/resuming_groupchat

I tried basically the same code as the OC's. However, I've now found that although directly adding messages to autogen.GroupChat's messages argument doesn't work, using GroupChatManager's resume does work:
last_agent, last_message = manager.resume(messages=context)

# resume the chat with the last agent and message
result = last_agent.initiate_chat(recipient=manager, message=last_message, clear_history=false)

So the problem seems to have been solved on my end. Sorry for the oversight


Extensible validator

First attempt for extensible validator, based on http://egalluzzo.blogspot.com/2010/06/using-inheritance-with-fluent.html.
But I'm not very happy with it because the inheritance may be too limiting.
e.g. if you have a validator for business domain A and a validator for business domain B, and you have an application that deals with both A and B, you would want to be able to combine these into one validator. That is not currently possible without having an inheritance relationship between A and B.
I will look into making it more composable. I think it should be doable with default methods on interfaces.

@pvdbosch does this look OK to you, or do you see the need to go further with #103?

OK, single inheritance seems sufficient to me for most use cases


Does rollback really work?

Knex version: 0.16.3
Database + version: mysql, 5.5
OS: Windows
I am making the inner query fail by adding a wrong column! Inner query fails, but does not rollback whole transaction! Here is my code:
return knex.transaction(function (trx) {
	return trx.insert({...}, 'id').into('dept').then(function (response) { **// passes, but should rollback!**
		return trx.batchInsert('emp', [{...}, {...}], 10); **// wrong query!**
	}).then(function (value) {
		console.log('Inside success:', value);
		// trx.commit();
	}).catch(function (error) {
		console.log('Inside error:', error); **// comes here!**
		// trx.rollback(error);
		throw new Error('Rolling back!');
	});
}).catch((err) => {
	console.log("We get here", err); **// comes here!; still no rollback??**
});

I tried with trx.rollback();  trx.rollback(error) or even throwing Error; with promise return and without promise return. It falls in both error blocks (inner and outer); still surprisingly no rollback!!

please boys, I have exactly the same problem, I'm 3 days trying everything and nothing works. I use the MySql Workbench database 6.3.
I throw erroneously {idx: 1} the correct {id: 1}, as I am wanting to update an array with many objects, all before the error are written and remain recorded in the database, trx.rollback does not work, if I use trx.rollback () there total crash. Abstract, objects before the error are stored and are not deleted, objects after the error are not stored.
`
exports.up = function (knex, Promise) {
return knex.schema.createTable('users', table => {
table.increments('id').primary()
table.string('name').notNull()
table.string('nickName').notNull()
table.string('email').notNull().unique()
table.string('password').notNull()
table.integer('credit').notNull().defaultTo(0)
table.boolean('confirmedAcc').notNull().defaultTo(false)
table.timestamps(true, true)
})
};
exports.down = function (knex, Promise) {
return knex.schema.dropTable('users')
};
 function batchUpdate(table, collection) {
return knex.transaction(trx => {
let queries = collection.map(tuple =>
knex(table)
.where('id', tuple.id)
.update(tuple)
.transacting(trx)
);
return Promise.all(queries)
.then(trx.commit)
.catch(trx.rollback);
});
}`

I ran into transaction issues with knex and a legacy MySQL db, which led me to this thread. Cause of the issue was MyISAM was being used instead of InnoDB, so ensure you're using the latter.

@tariq-tb Thanks!
It worked for me!
Because of that, I changed all my migrations (for creating tables) adding:
table.engine('innodb')


stages/xorrisofs: ability to set system id

Add an option to set the systemd id of the ISO. The system id is used by e.g. by osinfo to identify the RHEL boot isos, where the system id is "LINUX"[1]
[1] https://gitlab.com/libosinfo/osinfo-db/-/blob/master/data/os/redhat.com/rhel-8.4.xml.in#L19

SUPER! Thanks for fixing this @gicmo!


[Bug]: Re-word tooltips on all widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Description

[ ] Reword tooltip on default selected toggle field on the switch widget since it's got grammatical errors

[ ] Placeholder needs to be in smallcase

[ ] Change text to ...based on this value

[ ] Reword text

[ ] Incorrect text on Audio Recorder widget

[ ] First the is redundant and can be removed to simplify the text. Sets alignment of the widget Sets label position of the widget etc...

Steps To Reproduce
Hover over property pane fields of the various widgets
Public Sample App
No response
Version
Cloud

Hello, I am interested in picking up this issue as part of my first open source contribution. I am a student contributing as an assignment in university so any guidance as to where to start would be much appreciated. Thank you!

@zoispyridi please pick issues tagged as Good First Issue


Let's Encrypt conflict

We usually add the following location block for Let's Encrypt verification:
    location '/.well-known/acme-challenge' {
        default_type "text/plain";
        root /var/www/letsencrypt;
    }

Trying to add a new certificate we get a 403 error from https://github.com/bcremer/shopware-with-nginx/blob/a1f7ca5fb1601a24121892786d0121ed80e0fdcc/global/shopware.conf#L15
Removing that line still results in a 404 error.

Never mind, this was solved by changing our location rule to:
    location ^~ '/.well-known/acme-challenge' {
        default_type "text/plain";
        root /var/www/letsencrypt;
    }


[ibex, dv] Added new base, interrupt, debug and mem error sequences

Added an independent base test with following capabilities:

chooses between single run, multiples runs or infinite runs (existing sequence
does this via the num_of_interations variable).
interval between runs can be fixed or random, with 0 delay between runs possible.
For random intervals there should be a way to bias them more towards 0 delay
(e.g. specify 75% of delays should 0 with the rest randomly chosen).

Added an interrupt sequence that inherits from the above base sequence.
It has following capabilities:

chooses the number of interrupts to raise
specifies the interval between interrupt being raised and dropped
a mask to specify interrupts that shouldn't be raised.

Added a debug sequence with the only functionality to specify the interval between
the debug request being raised and dropped
Added a sequence to corrupt instruction and data memory.

@GregAC and @rswarbrick  I've also added the memory error sequence in the same PR. Please review the last sequence in cire_ibex_new_seq_lib.sv and the last test in core_ibex_test_lib.sv as they're the newest changes. Thanks.

Private CI failure is due to a flaky test, may be worth just disabling it for it or using another test as one of the three for the Private CI smoke. Once we're using co-sim and drop the current checking we can use that test again. @rswarbrick any thoughts?

This is currently not compiling. @prajwalaputtappa, could you take a look?
Error-[SE] Syntax error
  Following verilog source has syntax error :
  "/azp/agent/_work/1/s/dv/uvm/core_ibex/tests/core_ibex_new_seq_lib.sv", 11:
  token is 'PickErr'
    PickErr // Pick which memory to inject error in.
           ^

This is currently not compiling. @prajwalaputtappa, could you take a look?
Error-[SE] Syntax error
  Following verilog source has syntax error :
  "/azp/agent/_work/1/s/dv/uvm/core_ibex/tests/core_ibex_new_seq_lib.sv", 11:
  token is 'PickErr'
    PickErr // Pick which memory to inject error in.
           ^

I've resolved this and pushed it again.


Explore using selector-observer to run features

GitHub uses selector-observer to enable logic on simple classes, which is why adding or removing classes like .js-fit-content will enable or disable their features.
It's built around MutationObserver with various optimizations on top of it. Its performance might not be super (https://bugzilla.mozilla.org/show_bug.cgi?id=1422522) but it seems to work well enough for GitHub.
It's worth investigating if anyone has time, it would elegantly solve issues around dynamic content and all the specific listeners we have.
I think observe calls would go inside each feature’s init, which could only be called once.

Many of the bugs currently open can be fixed with this, so I really hope that someone can figure it out.

Let’s avoid any more conversions to selector-observer for the time being. There are some outstanding drawbacks we need to solve first. For example:

it always automatically waits for domready, so it’s not as fast as one using element-ready.
sometimes it should be disabled on deinit, like for that recent feature to remove labels.
some features should only be applied when the elements are visible (I have some code about this in the first related PR)

We should find a common, efficient way to cover all of these issues. Either via code or via documentation (e.g. “if feature requires X, then you must use deinit”)

cc @yakov116 @kidonng

it always automatically waits for domready, so it’s not as fast as one using element-ready.

I don't have a strong feeling about this so I can't say anything.

sometimes it should be disabled on deinit, like for that recent feature to remove labels.

I think most of the time this could be solved with carefully chosen selectors.

some features should only be applied when the elements are visible (I have some code about this in the first related PR)

Are you referring to this one?

I'm not familiar with all existing and pending usage of selector-observer, but I would say it is definitely useful for dealing with ajaxed components. For sure we don't want to convert every feature into using it, but I think our original intention is to fix bugs which will be hard/verbose without it. Take my two open PR converting into selector-obsever as an example, I think there's a good reason to use it.
Existing usage like linkify-user-edit-history-popup and remove-label-faster may be rewritten to reduce the usage of selector-observer (judge from a glance, correct me if I'm wrong).

I think most of the time this could be solved with carefully chosen selectors.

That may be right. Do you want to try reverting https://github.com/sindresorhus/refined-github/pull/3476?

Are you referring to this one

Yes, I used that function for a couple of features. But yes, it's probably not useful in many cases.
It doesn't need to be rewritten, it worked well, it only lacked :not(.rgh-class) but I did not have time to investigate back then. If anything, https://github.com/sindresorhus/refined-github/pull/3091 should be used instead of https://github.com/sindresorhus/refined-github/pull/3516. Notice how the observer looks for the specific elements instead using select.all again inside.

In short, if a feature works well, we don't need to use selector-observer

Until we sort this out, yes. No need to rewrite anything at the moment.
For the future, this is a little more complicated: selector-observer makes code declarative, so in a perfect world we'd almost always prefer it.
What do you think about this?

Always use selector-observer when...
... the feature affects a number of elements across the page, e.g. parse-backticks can find elements to modify anywhere on the page. element-ready would not have any advantages here.
Always use element-ready when...
... the feature only affects a specific part of the page and it's not in an ajaxed "hot zone" (e.g. conversation header and sidebar, and list of files)
For the rest of them...
... we need to evaluate whether it's worth giving up "faster features" (https://github.com/sindresorhus/refined-github/issues/2671) in exchange for reliability.

Existing usage like linkify-user-edit-history-popup and remove-label-faster may be rewritten to reduce the usage of selector-observer (judge from a glance, correct me if I'm wrong).

I think those are exactly the features that are fine with selector-observer

linkify-user-edit-history-popup needs complicated listeners for the popup, and doesn't benefit from element-ready because it appears well after dom-ready
remove-label-faster affects the sidebar, which is:

a ajaxed "hot zone"
loaded last on the page, so element-ready wouldn't save a lot of FOUC

I'll try rewriting that:
"Ajaxed hot-zones" are areas that have nested ajaxed widgets and require a number of listeners and mutation observers to detect changes.

Features in ajaxed hot-zones: Always use selector-observer
Features with many elements across the page: use select.all
Features with a limited number of elements, e.g. forked-to only affects links in the header

Urgent debugging wanted
Is https://github.com/josh/selector-observer/issues/30 a real bug?
Did https://github.com/sindresorhus/refined-github/issues/3527 happen for that reason?
How can we work around it?
Further features and refactoring using selector-observer won't be accepted until we know how to avoid this from happening.
cc @kidonng @yakov116 this is why I temporarily closed related PRs.

https://github.com/kylekyle/monitoring what about this? It's actively maintained and it looks like it runs before dom ready too!

@fregante should I try https://github.com/kylekyle/monitoring and play around with it? Or do you want to stick to select-observer?

We need to verify those 3 points first, there's no point in changing library if has the same issue (or if the issue doesn't exist)

I confirmed the bug and found a workaround:

if the selector has :not(.rgh-this-feature) and we add the class right away, selector-observer will no longer call the add method because the original selector no longer applies. This avoids the loop.

We almost always do that already, but #3517 didn't because it didn't seem necessary.

I'll open the previously-locked PRs
@kidonng you can resubmit #3517 with the workaround described
@yakov116 if you want to explore Monitoring anyway, try it out on linkify-code, which is the heaviest feature making use of selector-observer

@yakov116 if you also want to look into any other features that use selector-observer but don't have this class, please send a PR for that


Add optional serde support

This will be useful for using BoundedVec in sigma-rust. Also, I was wondering, what are your thoughts on adding a try_push function to BoundedVec? It'd make it a bit easier to use, it could return an Option or Result if there's no more room in the vector.

Hi, not sure what's up with clippy:

Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.

Running cargo clippy on my system displays no lints.

Hi, not sure what's up with clippy:

Error: Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
Warning: It seems that this Action is executed from the forked repository.
Warning: GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See actions-rs/clippy-check#2 for details.

Running cargo clippy on my system displays no lints.

That's a warning that it's unable to create annotations in PR for clippy warnings. However, I don't understand why clippy sees serder import as unused. I'm merging it. :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.714%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
120

Relevant Lines:
140

💛  - Coveralls


reduce over default state with current state

reduce over default state with current state

Yo brotha, you got the HMR working for ng2?? @gdi2290
Loaded up your ng2 starter and saw you added application state and it's holding it :)
What was the trick / missing ??

the trick was using a proxy to maintain state during the refresh. I think this works now even though it was pretty hacky


Modular Backend

It would be useful if people could integrate their own backend and this module would provide the high-level API to use it.
Some backends:

Redis
Leveldb

:+1:


Uncaught Error: error: 126/?~\AppData\Local\atom\app-1.23.1\resources\app.asar.unpacked\node_mo...

[Enter steps to reproduce:]

...
...

Atom: 1.23.1 ia32
Electron: 1.6.15
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: error: 126\?\C:\Users\pc\AppData\Local\atom\app-1.23.1\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
At ELECTRON_ASAR.js:173

Error: error: 126\\?\C:\Users\pc\AppData\Local\atom\app-1.23.1\resources\app.asar.unpacked\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:187:18)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (~/AppData/Local/atom/app-1.23.1/resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at Object.getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at exports.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/atom-keymap/lib/helpers.js:201:42)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:467:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.23.1/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:347:30)
    at WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.23.1/resources/app/src/window-event-handler.js:108:40)

Commands
  3x -9:24 tree-view:add-file (span.name.icon.icon-file-directory)

Non-Core Packages

I think this is a duplicate of issues like #15722. If you have any anti-virus software running, please check if there are any messages about quarantining this file and then see if you can restore it, or try to re-install with your anti-virus temporarily disabled. If you don't have any anti-virus software running, let me know.


Images missing on /visit-us

https://wellcomecollection.org/visit-us

@davidpmccormick this is because of Drupal - I'll remove the hack for now.


Pass specs arguments only to specs.

Current coverage is 74.76% (diff: 100%)

Merging #1296 into master will not change coverage

@@             master      #1296   diff @@
==========================================
  Files           192        192
  Lines         11208      11208
  Methods       10955      10955
  Messages          0          0
  Branches        123        123
==========================================
  Hits           8380       8380
  Misses         2828       2828
  Partials          0          0

Powered by Codecov. Last update 3062f3d...64eee1f

@paulp does this fix #1277? If so, is this ready for merge? If not, since we use a couple different test frameworks, it still seems good practice to specificy which one we'd like to specify the arguments for.

Yep, fixes #1277 and I'm not sure why sbt even offers an option to pass options to "all test frameworks" because if there are two or more they won't work somewhere.

Oh, the "merge conflicts" are revision.md. That means any pull request which includes that file is immediately in conflict after something else is merged. Not so good.

I see, the script is also supposed to prevent CHANGELOG/revision.md from turning up in master, right? But there it is.

The revision.md file should get deleted after merge, so the merge script likely isn't working properly.

Ok, looking at the script, it looks like the four valid file names are:
breaking="CHANGELOG/breaking.md"
feature="CHANGELOG/feature.md"
bugfix="CHANGELOG/bugfix.md"
release="CHANGELOG/release.md"

So the revision.md file that exists in master should just be deleted.

Take back what I wrote above - the link is to my own out-of-date fork of devtools. The actual valid file names are
breaking="CHANGELOG/breaking.md"
feature="CHANGELOG/feature.md"
revision="CHANGELOG/revision.md"
release="CHANGELOG/release.md"

as seen in the merge script on master.

This has been resolved in slack in the #backend room. It would be awesome if there was a way to link here to a specific chat in a slack channel!

@alissapajer http://gitter.im/quasar-analytics/quasar


Git application failed because of tls: failed to verify certificate: x509: certificate signed by unknown authority

Hi with epinio 1.8.1,
i cannot git clone my repository because if use a self certificate ( enterprise certificate)
How can i trust it ?
Fetch	Fetch the files at the git repository's branch
Fail
Get "https://gitlab.XXXX.com/XXXX/XXXXX.git/info/refs?service=git-upload-pack": tls: failed to verify certificate: x509: certificate signed by unknown authority

Hi @yodatak, thanks for reporting this.
At the moment we do not support self signed certificate for git. We need to skip the verification, or provide a way to add to the certificate to the trust store.

We need to set this into the git.CloneOptions of the go-git client.
See https://github.com/epinio/epinio/blob/261777a07255f13cd1f7fc1e0c9d508b99aa3e6f/internal/api/v1/application/importgit.go and https://github.com/go-git/go-git/blob/master/options.go#L75-L78

I've verified that mounting a secret with the gitlab's CA.pem certificate into epinio-server pod resolves this issue. So the dex-tls approach can be used here.
I did an app deployment from my self-hosted gitlab by using Git URL Source type where https://gitlab.MYDOMAIN.io/epinio/samples.git was used as URL value.
This can be used as a temporary workaround BUT it is not permanent and won't survive epinio upgrade:
$ kubectl create secret -n epinio generic gitlab-tls --from-file=tls.crt=gitlab.ca.pem  # tls.crt is used key value; gitlab.ca.pem is the certificate

$ kubectl patch deployment epinio-server -n epinio  -p '{"spec":{"template":{"spec":{"containers":[{"name":"epinio-server","volumeMounts":[{"name":"gitlab-tls","subPath":"tls.crt","mountPath":"/etc/ssl/certs/gitlab-tls.pem"}]}],"volumes":[{"name":"gitlab-tls","secret":{"defaultMode":420,"secretName":"gitlab-tls"}}]}}}}'

The patch just mounts the certificate under /etc/ssl/certs/gitlab-tls.pem in epinio-server pod.

@yodatak fixed with #2488. This feature will be available in the next release (v1.10.0)!


Add color picker to make cells all kinds of pretty

Maybe https://abdonrd.github.io/paper-swatch-picker/components/paper-swatch-picker/


Hiding MenuBubble on editor blur

First, thank you for making tiptap available!
In our app, we'd very much like any shown menu bubble to be hidden when the user tabs out of the editor. I see tiptap listening for blur events, and the handler is being called... but it bails out any time event.relatedTarget is set.
https://github.com/scrumpy/tiptap/blob/24f61e02be0ed091f4735266df03433ceeda119c/packages/tiptap/src/Plugins/MenuBubble.js#L65
And I might be wrong, but I think event.relatedTarget will always be present when (e.g.) tabbing from one field to the next.
We can work around this by catching the blur event and re-dispatching another without a relatedTarget, but maybe this isn't the best way?

"v-show"

Ah, good thought; thanks. Went this route, for anyone else who comes by here:
<editor-menu-bubble :editor="editor">
    <div
        slot-scope="{ commands, isActive, getMarkAttrs, menu }"
        :class="{ 'invisible opacity-0': !(menu.isActive && isEditorFocused)}"
    ....

this.editor = new Editor({
    onBlur: ({ event, state, view }) => {
        vm.isEditorFocused = false;
    },
    onFocus: () => {
        vm.isEditorFocused = true;
    },
    ...

v-show = display: none, if you use opacity, you'd better add  pointer-events: none.


Statsig fails to initialize

I'm trialing the Statsig SDK right now. It worked well, but wasn't the fastest to init. I was directed to try the lite version, but I'm getting these two error logs on startup:
ERROR: statsigSDK::initialize> Failed to initialize from the network.  See https://docs.statsig.com/messages/serverSDKConnection for more information
WARN:
TypeError: M6.apply is not a function
    at HJ (/var/task/index.js:43:439935)
    at t.post (/var/task/index.js:44:75774)
    at t.<anonymous> (/var/task/index.js:44:14273)
    at p (/var/task/index.js:44:1577)
    at Object.next (/var/task/i...

This still seems to return a client, but it evaluates my gate as false when it should be true. I'm using the SDK the same way i used the full SDK (pared down snippet):
import statsig from 'statsig-node-lite'

async function getPlatformGateSs(flagName: string, user: StatsigUser): Promise<boolean> {
  await statsig.initialize(secretKey) // I also tried passing { environment: { tier: 'development' } }
  return client.checkGateSync(user, flagName)	// false
}

Should i be including something else in the init call?

@apoteet that error usually indicates either a transient request failure, network configuration issue (i.e. access to network requests disabled), or the provided SDK key is invalid. Can you verify that none of the above applies to you?
The SDK appears to be operating fine from our side.

I don't think any of those would be true for my case, since the full SDK worked just fine? I left the lite SDK running with errors for about an hour before switching back, so i don't think it's transient either. This is running in a lambda environment FWIW


⚠ Bofrost.be has degraded performance

In b904772, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1558 ms

Resolved: Bofrost.be performance has improved in 46bfb24.


Break line before LIMIT statement to prevent trailing comment issue

CATEGORY
Choose one

[x] Bug Fix

SUMMARY
This may not be a perfect solution but it addresses the issue in 7483
closes https://github.com/apache/incubator-superset/issues/7483

https://github.com/apache/incubator-superset/blob/2b3c6c5531a20d99c5d7c1020cb99ad546e36178/superset/sql_parse.py#L34

Codecov Report

Merging #7485 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #7485   +/-   ##
=======================================
  Coverage   65.42%   65.42%
=======================================
  Files         435      435
  Lines       21323    21323
  Branches     2347     2347
=======================================
  Hits        13950    13950
  Misses       7257     7257
  Partials      116      116

Impacted Files
Coverage Δ

superset/sql_parse.py
99.14% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4377328...ce47fa7. Read the comment docs.


Service Provider should not register always everything

Describe the bug
Currently, the package's service provider is loading and registering everything, regardless if it's needed only on the CLI and not in web requests. This adds additional burden on each web request, in terms of memory requirements, cpu usage and request time. This can affect high-performance environments as well high-traffic systems with limited resources. Measured in a development environment, not running the console-specific parts for web requests made easily a difference of 10-15ms (most likely less in an optimized production environment).
Expected behavior
Optimally, a service provider should only register or load what is required. This is also displayed in basic examples of the Laravel documentation, one of them in https://laravel.com/docs/10.x/packages#commands and is also often considered a best practice.
How to solve
A separate service provider can be used for everything which should be loaded only on the console. This service provider will include registrations for migrations, resource and assets publishing, registering commands and the about command. They are all neither needed nor used during web requests. This service provider is then conditionally registered only when the app is running on the console.
I opened this ticket, as I may actually provide also the required pull request for this - it would be nice if it would be included in the 14 release (I'm developing my client's app with the alpha right now), as also to provide a place for discussion if necessary, especially since I just recently started using Orchid.

Hi. I haven't done a load speed measurement test, but I am using the built-in commands method:
https://github.com/laravel/framework/blob/d6ffa449cbb1bfb44f8f3dcddbb4d872ca457dd8/src/Illuminate/Support/ServiceProvider.php#L393-L406
Which commands before the console start event:
https://github.com/laravel/framework/blob/d6ffa449cbb1bfb44f8f3dcddbb4d872ca457dd8/src/Illuminate/Console/Application.php#L44-L49
Since HTTP request does not call Artisan (Although you can use Artisan::call() facade).
Then all the closure functions will not be executed. Isn't this equivalent to the documentation link you provided?

Yes, it's correct that the closures won't be executed, however it still executes all the statements to register all kind of things, even though they'll never be used or be required in a HTTP request.
Here shown (determined with a lazy-dev approach :D) that all methods with be called.

It's however not required to set any resources for publishing, as they will be only ever be published through the console, nor migrations are required to be registered nor some other things, for a HTTP request. They can safely be moved into a Service Provider of it's own, this way, not even some additional classes will be autoloaded or checked for existence.
After my optimization on my pull request #2611 , only what is required is being loaded:

(Orchid still works!)
While console loads everything:

There is probably still one optimization possible here. If Orchid is used only as a back-office, and the front office doesn't make use of it, as seen in the screenshots above with a standard laravel installation, we may be able to avoid loading any additional providers, registering translations, blade components and views, as they won't be required then.

It was fixed after PR was accepted. #2611


tortoise: add beacon to good block determination

Motivation

Closes #2812
Closes #2813

Changes

include beacon value into good block consideration
delay votes in blocks with the wrong beacon by K layers

Test Plan

unit test
will try to add a more involved test once https://github.com/spacemeshos/go-spacemesh/pull/2914 is merged
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bors try

bors merge


Salsa not working with require('path')

I enabled Salsa and tried the most basic thing in some node code

'use strict';
const Path = require('path');
var c = Path.

When I type the . after Path none of the path functions (eg normalize) are available. Same with any other node builtin module. They are in the typings node.d.ts which I installed as previously required before I enabled Salsa.

This worked for me when I tried Salsa, @egamma -- maybe a configuration problem?

OK so I tried in a new empty project folder with almost empty code user settings.json.
1st I tried the old intellisense with Salsa env var renamed to disable it I find even the typescript based intellisense is not working.
What am I not understanding?
test,js

var p = require('fs');
var c = p.
console.log

jsconfig.json

{
    "compilerOptions": {
        "target": "ES6",
        "module": "commonjs"
    }
}

I get suggestions for console once I have a package.json, presumably as code can then decide the correct context. However, I get no suggestions for p?
I have node 4.2.6 installed on Windows 10
What else effects the intellisense?

I'm assuming I don't need to install any typings as node is directly supported. It should just work out of the box.

Sorry, but you still need to intstall the node.d.ts file, this hasn't changed between pre-salsa and Salsa JS support.
Closing this issue - automatic fetching of typings is high on the backlog of Salsa.

OK. I did make abortive attempt but typings install node failed. Will try again.
Thanks for quick response

So need to use the mysterious typings --ambient flag but then it hangs. Back to tsd which works fine

You should probably add this to the javascript docs to make it crystal clear is needed for node.

fyi @gregvanl


Adding wrapping for Watershed and Toboggan filters

The Toboggan filter has already been added to SimpleITK. As there is also the MorphologicalWatershedImage filter this PR is not needed.


Add Countries centroid data and Leaflet map Notebook example

see: https://github.com/gavinr/world-countries-centroids/tree/master/dist

notebook pic:


Explicit timestamptz converted to jsonb on migration

Describe the bug
Setting:
@Property({ type: 'timestamptz', defaultRaw: 'CURRENT_TIMESTAMP' })
date: Date = new Date()

Seem to set column migration on pg to:
"date" jsonb not null default CURRENT_TIMESTAMP
Expected behavior
Migration should use a correct timestamptz type on migration
Versions

Dependency
Version

node
14.15.0

typescript
4.0.5

mikro-orm
4.2.3

@mikro-orm/postgresql
4.2.3

You should use columnType instead of type when providing the actual database type. (I guess you already found out :])

Yep, this was exactly my problem :sweat_smile:
This exemple is mileading for class entity, I think it's said too low on the doc here, but it should be around here instead :smile:
Thanks and sorry for the unnecessary noise :smile:


Is it possible to mock a binary's imports?

I'm writing a CLI and I've separated some helpers with side-effects into another file and have unit tested those. It would be much easier to test the CLI if I can stub the helpers and disregard the side-effects.
Is it possible to mock the imports of a CLI / child process? Such as (pseudocode):
await esmock("../src/cli.js", {
	"./helpers.js": {
		foo: someSpyOrStub(),
		bar: someSpyOrStub(),
	},
});

Or maybe with execa:
const spy = // ...
const cli = await esmock("../src/cli.js", { /* ... */ });

const { exitCode } = await execa(cli);

t.is(exitCode, 0);
t.true(spy.called);

If I try running the first code snippet, the CLI is invoked without any mocks being applied.

Seems like it's possible using testdouble / quibble:
// src/helpers.js
export const foo = () => "foo";

// src/cli.js
import { foo } from "./helpers.js";

console.log(foo());
//=> expected: "foo"

// test.js
import * as td from "test-double";

await td.replaceEsm("./src/helpers.js", { foo: () => "bar" });

await import("./src/cli.js");
//=> actual: "bar"

@tommy-mitchell may be I missed something, but why you can't use globalmocks from
await esmock(
  './to/module.js', // filepath to the source module being tested
  import.meta.url, // parentUrl from which mocked modules should be resolved
  { ...childmocks }, // mock definitions imported by the source module, directly
  { ...globalmocks }) // mock definitions imported anywhere in the source import tree

If I try running the first code snippet, the CLI is invoked without any mocks being applied.

Maybe the path should be "../src/helpers.js"?
await esmock("../src/cli.js", {
	"../src/helpers.js": {
		foo: someSpyOrStub(),
		bar: someSpyOrStub(),
	},
});

esmock should throw an error if no module is found at the "helpers.js" path. We can only guess about the layout and naming of your files

though I don't know what your cli file looks like and maybe the idea is not helpful, perhaps the cli file could be made into a basic wrapper file that imports and calls more typical javascript file. The typical javascript file could be mocked more easily as a target for unit-tests eg,
app.cli.js
#! /usr/bin/env node
import app from './app.mjs';

(async () => {
  try {
    const res = await app( process.env );

    console.log('[...] cli success!:', JSON.stringify(res, null, '  '));
  } catch (e) {
    console.error(`Error!!: ${e.message}`);

    throw new Error('cli failed!');
  }
})();

Using a cli file like this one, the regular "app" could be unit-tested in a typical sort of way where env vars would become params the app is called with

@tommy-mitchell I could be misunderstanding something but agree with @koshic that this form should work for your case
await esmock("../src/cli.js", {
  "../src/helpers.js": {
    foo: someSpyOrStub(),
    bar: someSpyOrStub()
  }
});

My issue was an incorrect module specifier and some confusion about how a module gets invoked. Besides the issue in #215, this is working as intended.


'RGB' for MoCo, 'BGR' for Detectron2

It seems MoCo was pretrained with "RGB" images, but Detectron2 takes "BGR" by default, I wonder if we should add
INPUT:
  FORMAT: "RGB"
MODEL:
  PIXEL_MEAN: [123.675, 116.280, 103.530]
  PIXEL_STD: [58.395, 57.120, 57.375]

to the config yaml?

I missed the last part of the config file, my mistake!


Add faq section

🌟 Is your feature request related to a problem?:
Add faq section
💡 Describe the solution you'd like:
Add faq section
🔀 Describe alternatives considered:
Add faq section
📄 Additional Context:
Add faq section
To be Mentioned while taking the issue:

What is your participant role?

Note:

Please review the project documentation and ensure your code aligns with the project structure.
Please ensure that either the predict.py file includes a properly implemented model_details() function or the notebook contains this function to print a detailed model report. The model will not be accepted without this function in place, as it is essential for generating the necessary model details.
Prefer using a new branch to resolve the issue, as it helps keep the main branch stable and makes it easier to manage and review your changes.
Strictly use the pull request template provided in the repository to create a pull request.

This issue isn't needed at the moment. Please review the existing issues or open a new one if necessary.


Add fedimint review to bitcoin-design/learning-bitcoin-and-design

This PR adds fedimint transcript review to the bitcoin-design/learning-bitcoin-and-design directory.

Hello is there reviewer?

I'm receiving an error:  Application error: a client-side exception has occurred (see the browser console for more information).
I can't open the file to edit it.


Unexpected null in search input

Current behavior
The search input is bound to "null" value in particular edge case.
Expected behavior
Search input should not be bound to "null" value
Steps to reproduce the issue

Visit https://demo.storefrontcloud.io
Clear site data (Application tab in chrome dev tools)
Refresh page
Open search sidebar
Click on white space to take out focus from the search input
Close search sidebar
Open sidebar again

Release

https://demo.storefrontcloud.io
https://test.storefrontcloud.io
https://next.storefrontcloud.io

Environment details

Browser: Latest Google chrome
OS: Windows 10

Additional information

Bug fixed


nav: zooming improvements

[x] it looks like it continues to zoom when you pan manually, it probably should stop (like it does if you manually zoom) - https://github.com/commaai/openpilot/pull/29470
[ ] can also reset the filter when it resets the view/re-centers
[ ] filter too slow, or set a breakpoint above 0, as it continues to zoom when you come to a stop

From https://github.com/commaai/openpilot/issues/28796#issuecomment-1622629543

Hi @sshane can I work on this as I also have experience with Qt and I looked at the comment https://github.com/commaai/openpilot/pull/28796#issuecomment-1622629543

sure, any issue open here you feel you could tackle, we're happy to let you

https://github.com/commaai/openpilot/pull/29488

Unless I'm not understanding the idea, I don't think the filter should be reset when you recenter the view.

I will do this in a few days. =)

I will do this in a few days. =)

I think I have completed them. Just waiting for it to be merged


Asset Size

It could be great if it were possible to see the size of the assets in reWire

What do you mean by "see"? You would like an outline?


[BUG] No opentelemetry traces are exported

Library name and version
Azure.Messaging.ServiceBus 7.16.1
Describe the bug
Using the following configuration
builder.Services.AddOpenTelemetry()
            .WithTracing(tracerProviderBuilder =>
            {
                tracerProviderBuilder
                    .AddSource("Azure.*")
                    .SetSampler(new AlwaysOnSampler())
                    .AddAzureMonitorTraceExporter()
                    .AddConsoleExporter();
            })
builder.Services.AddAzureClients(configure =>
        {
            configure.AddBlobServiceClient("");
            configure.AddServiceBusClient("");
        });

I cannot observe any traces from the ServiceBus client within both exporters. However, I am able to see traces from the blob client.
I have registered both an ActivityListener and a DiagnosticListener. For the ServiceBus, I receive notifications from the DiagnosticListener but not from the ActivityListener. In the case of the Blob client, I can see traces from both sources.
Expected behavior
Traces/Span from ServiceBus are exported like with AddApplicationInsightsTelemetry.
Actual behavior
No traces
Reproduction Steps
Simple aspnet core application that send messages with the telemetry configuration above
Environment

TargetFramework: net6.0
Platform: local linux env under wsl2

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

OpenTelemetry support is still experimental so in order to enable it, you will need to set a flag as described here. Can you let us know if you have already set this?

OpenTelemetry support is still experimental so in order to enable it, you will need to set a flag as described here. Can you let us know if you have already set this?

Yes, That's why I think I can at least observe traces for blob clients. I see in the code that service bus and blob client doesn't use the same DiagnosticScope class hierachy. Service bus is using a Messaging wrapper while I guess blob client use a common implementation for all HTTP based clients. But it is not obvious as to why the Activity are not created in the case of Service Bus.

@scrocquesel-ml150, thanks I was able to repro the issue and we are tracking down the root cause.


Test on to Rust 'stable' instead of Rust '1.1.0'

Would prevent having to upgrade the version number after every Rust release

:+1:

I plan on explicitly testing using the oldest version of Rust that MIO supports. I want a change here to indicate that MIO has increased it's minimum Rust version.

Fair enough :+1:


Reduce the number of travis builds

Now that we have an even larger team, it is more likely that we will be running into rate limits with travis. One possible way to reduce the occurrence of rate limiting is by stopping travis from doing builds when we merge into develop, since this is redundant because of the testing we do for the PR. Should check if it is possible to either stop builds for a given branch or within the travis script to see if it is a develop merge and skip the testing.

I could be wrong, but I don't think it's always redundant to run  builds on merges into develop. If two PRs are merged into develop at almost the same time, then each PR may not have the other's changes, and it's possible an error might occur when the two PRs interact with each other.

Brainstorming here:
The underlying cause is that our tests are hitting rate limits, while refactoring some of this code, I noticed that we can cut down on rate limit by using the github api in more efficient ways as well. For example, we might be able to take advantage of the tree call ( https://api.github.com/repos/ICGC-TCGA-PanCancer/Seqware-BWA-Workflow/git/trees/master ) as well rather than looking for files individually

In case you haven't seen it: https://docs.travis-ci.com/user/customizing-the-build/#Limiting-Concurrent-Jobs

Yeah, we've given it a shot in the past and I've turned it back on.
We do have to approach the problem on both ends though, we can get a real backlog if too many builds are submitted and I do suspect we've somewhat wasteful with the rate limits we do have

Merging with #140
I think one good idea from there is just to make it more obvious when we hit a rate limit rather than show unrelated error messages. It should be possible to query the limit before each set of tests

Currently done


ace: gpdma: power down routine

We want to power up GPDMA only when we are planning to use it.  When device is no longer in use, PM can disable device and allow the power domain to enter power gaiting state.

Blocking just to not accidentally merge without dma_ctx init fix

@abonislawski  fixed in newest version

Thank you so much for adding a test for this, will try it out here today on a few boards

On cavs25 currently when building with PM, PM_DEVICE, PM_DEVICE_RUNTIME it seems to get stuck on the first memory to memory transfer indefinitely
west build -p always -b intel_adsp_cavs25 tests/drivers/dma/loop_transfer -- -DCONFIG_PM=y -DCONFIG_PM_DEVICE=y -DCONFIG_PM_DEVICE_RUNTIME=y

Results in
*** Booting Zephyr OS build zephyr-v3.3.0-1641-g9583f300912e ***
Running TESTSUITE dma_m2m_loop
===================================================================
START - test_test_dma0_m2m_loop
DMA memory to memory transfer started
Preparing DMA Controller: dma@7c000
Starting the transfer on channel 0 and waiting for 1 second

And never making progress, I had to hard restart the board to try again
Without PM enabled this branch doesn't get to the Zephyr boot message.
On main this test works. Please take a look

I decided to move the power domains related commits to a separate pull request.

One thing that I think it is wrong with this approach is that you are making the device dependent of PM. PM is supposed to be optional, if you have this option turned off the device should basically be always turned on.

@tmleman let me know when I should retry/retest, happy to do so

@teburd unfortunately you won't be able to test it on any CAVS platform. First problem is that builds with enabled PM doesn't work (those without SOF) https://github.com/zephyrproject-rtos/zephyr/issues/56415. And second one is that in case of a TGL some registers are still programed from SOF side.
I made cooperation with closed source version and power management aspects of those drivers does not match to each other. Those features are needed for ACE and I don't want to invest more time into CAVS version.
I will make SOF build with those changes and run test on it.

I have tested FW with those changes on MTL and TGL. I didn't find any issue.
https://github.com/thesofproject/sof/pull/7353

@ceolin please take a look


category product_count wrong values

product_count shows some definitely wrong values.
I am on https://demo.vuestorefront.io, looking at network calls to ES when browsing categories via side menu.
"Men/Tops"

0 products can't be right, it should be the sum of the subcategories products.
"Men/Tops/Jackets"

176 products isn't right either, on page it shows 11 items

Same applies to "Women", but not to "Gear" and "Training", which have one level nesting less, not sure if that would make a difference.

@afirlejczyk that's right - it's just the number of products directly attached to any specific category and VSF is doing a nested query to get all the products directyl attached and from subcategories as well

Sorry for the delay in getting back. Thank you for your answers.
I understand those values are taken straight from ES. I used https://demo.vuestorefront.io/ as a common ground for the example but I get exactly the same on a local magento install with sample products.
I understand (only now :)) that the 176 in Men/Tops/Jackets is the sum of all the simple products, which is different than the 11 items shown on page. So the 176 does make sense.
What doesn't make sense is the 0 in Men/Tops (and all other similar categories), which as far as I can tell is just plainly incorrect.
I guess it depends on how the value gets used.

I opened the issue here because I thought that magento2-vsbridge-indexer was responsible for counting up the products from mysql and writing to ES.

It is, but VSF demo doesn't use this extension :) it is using https://github.com/DivanteLtd/mage2vuestorefront

so it get data directly from magento api, I don't know why Magento API return 0 for this category.

So I would report issue to: https://github.com/DivanteLtd/mage2vuestorefront or to https://github.com/DivanteLtd/vue-storefront ;)

Thank you @afirlejczyk
Yes you are right, those zeros come straight from magento api. To think that it can't event count right..
Apparently all it takes to teach it how to count is flagging categories as "anchors"
https://magento.stackexchange.com/questions/24429/magento-category-product-count-issues
As soon as I market "Women" it updated count to show the correct total.

That said, I think this issue can definitely be closed, nothing to do with mage2vuestorefront or magento2-vsbridge-indexer.
Thank you for your time and sorry for bringing this up.


Field Prefix gets overriden by Form Prefix

If you set a field _prefix value, it always gets overriden by the form _prefix as self.kwargs contains the field _prefix.
I think these should be combined so it's possible to have both form and field prefix.
Link to any relevant issues or pull requests.

Field _prefix has an underscore because it's not intended as a public API. It only makes sense to give a form a prefix, not an individual field.