Selene Selenium 3.0 Actions error

According to new release of GeckoDriver https://github.com/mozilla/geckodriver/releases
and new version of selenium python binding == 3.3.0 Selene will fail in SeleneElement.init() method
This is due to ActionChains, seems that new version of binding brings key that says if a given browser is w3c compliant.
During debug I found that to fix this issue we need to init ActrionChains like this:
 self._actions_chains = ActionChains(webdriver._source.driver)

instead of:
self._actions_chains = ActionChains(webdriver)

Hm... that's weird...
That means that somehow SeleneDriver does not implement WebDriver interface
fully...
Need to dig deeper into this...
But so far we can release a patch with temporal fix, if this blocks
somebody...
On Wed, Mar 8, 2017, 2:08 PM Serhii Pirohov<EMAIL_ADDRESS>wrote:

According to new release of GeckoDriver
https://github.com/mozilla/geckodriver/releases
and new version of selenium python binding == 3.3.0 Selene will fail in
SeleneElement.init() method
This is due to ActionChains, seems that new version of binding brings key
that says if a given browser is w3c compliant.
During debug I found that to fix this issue we need to init ActrionChains
like this:
self._actions_chains = ActionChains(webdriver._source.driver)
instead of:
self._actions_chains = ActionChains(webdriver)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yashaka/selene/issues/113, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3snjpFfEJh9EHc1VF0FKWtEIa3NiRzks5rjuB6gaJpZM4MXDIg
.

Well I think we need to make a Selenium 3.0 branch and test it

ok, let's do this...
On Wed, Mar 8, 2017, 2:16 PM Serhii Pirohov<EMAIL_ADDRESS>wrote:

Well I think we need to make a Selenium 3.0 branch and test it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yashaka/selene/issues/113#issuecomment-285105136, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB3snlUXd9RqnRscj8FOYd8911mtxX-kks5rjuJUgaJpZM4MXDIg
.

Don't you just need to add the following to abctypes/webdriver.py?
   @abstractproperty     def w3c(self):         # todo: bool         pass

I am playing with a selenium-3.5.0 branch.
https://travis-ci.org/daveenguyen/selene/builds/273968339
I have 2 tests failing on travis.
I was wondering anybody had any thoughts.
They look timing related.
2.7
______________________________ test_waits_nothing ______________________________
tests/integration/filtered_scollection_nowaiting_search_test.py:51: in test_waits_nothing
    assert len(elements) == 2
E   assert 1 == 2
E    +  where 1 = len(<selene.elements.__len__ object at 0x7f67f83c9790>)
==================== 1 failed, 136 passed in 360.85 seconds ====================

3.5
________ test_selene_is_from_32_to_65_percents_slower_than_raw_selenium ________
tests/acceptance/speed_comparison_of_simple_element_actions_test.py:80: in test_selene_is_from_32_to_65_percents_slower_than_raw_selenium
    assert selene_time <= 1.65 * selenium_time
E   assert 0.5911405086517334 <= (1.65 * 0.3450355529785156)
==================== 1 failed, 136 passed in 320.60 seconds ====================

I ran into this problem. But I do not see the
"@abstractproperty
def w3c(self):
# type: () -> bool
pass"
in the "abctypes/webdriver.py" file.
If it is already removed, it did not work.

where do you propose to use this  @kylefix ?

I understood
Need to add to the file abctypes/webdriver.py
this
@abstractproperty def w3c(self):      # type: () -> bool     pass
Everything works!

Seems like was fixed in the past...
And for sure is not relevant in 2.*


322 write unit tests for form controller components

This adds unit tests for form-controller components
Links
#322
Developer considerations

On any task

[x] Previous unit and e2e tests are passing
[x] Perform dev QA

Developer QA steps

Approved Dev QA
🪇


Packaging improvements

Use 'io' package as a more reliable way of opening files
on Windows in Python 2.7
Add python_requires, which helps pip determine if the
package is compatible with the version of Python.
Change development status to "Production/Stable" in PyPI classifiers
Cleanup and formatting of setup.py

Fixed development status and removed test_suite.
python_requires is already set to 2.7 and 3.5+. Did you want to explicitly exclude 3.9 and newer?

Crap, messed up the merge (tried a rebase and PyCharm balked). I'll try to clean up this mess...

Well, after some research I'm at a loss at how to fix this without deleting the fork/branch and making a new PR. Any ideas?
Sorry about this, I'm not used to rebasing PRs (or rebasing in general).

No problem, @GhostofGoes -- I will try to get your changes locally later this week and see if I can help you cleaning this.

@GhostofGoes I will not have available time as soon as I would like to fix this. Would it be possible for you to re-submit your changes in another clean branch in a separate pull-request, please?

Sure thing


How can i add right Text

How can i add rightText for TextFieldDelegate??
Thanks...

Solved...
Thanks

You can find some example here https://github.com/OlivierLDff/QaterialGallery/blob/master/qml/DialogDelegatePage.qml.
Sorry for lack of documentation, this will come when i will have time


[CSDiagnostics] Improve MissingRawRepresentableInitFailure diagnostic fix-it

The MissingRawRepresentableInitFailure fix currently provides a fix-it where it always suggests a ?? <default value>", even if the init(rawValue:) is not failable. For example:
enum Foo: RawRepresentable {
  init(rawValue: Int) {}
  var rawValue: Int { return 0 }
}
func takesFoo(_: Foo) {}

takesFoo(0) // fix-it => Foo(rawValue:  ) ?? <#default value#>

This is not ideal, because now the user has to manually remove the ?? <#default value> bit. Some users might not realise that the initialiser is not failable and will actually pass a default value, in which case they'll see: left side of nil coalescing operator '??' has non-optional type 'Foo', so the right side is never used.
So, if the initialiser is not failable, strip the default value suggestion.

You mean something like forming a disjunction of all viable constructors in repairFailures and then solver picking the right initializer call?

Instead of forming a disjunction directly you could use addValueMemberConstraint which does lookup and add ApplicableFunction to match argument to it's resulting member type.

Okay, I added some new constraints instead. Does it look like I am in the right direction?

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


Some error while running

Hi, I simply run the code by ./vimiv.py on the latest dev and error occurred:

Traceback (most recent call last):
File "./vimiv.py", line 6, in
from vimiv.app import Vimiv
File "/home/alex/shared/cs/my_projects/tiled_filemanager/vimiv/vimiv/app.py", line 25, in
from vimiv.thumbnail import Thumbnail
File "/home/alex/shared/cs/my_projects/tiled_filemanager/vimiv/vimiv/thumbnail.py", line 168
     ^

SyntaxError: only named arguments may follow *expression

which correspond to the following code
# Add initial placeholder for all thumbnails
default_pixbuf_max = GdkPixbuf.Pixbuf.new_from_file_at_scale(
      self.thumbnail_manager.default_icon,
      *self.get_zoom_level(), True)

I have tried with python 2 and 3.
Is seems that something is wrong with the unpacking.

What python3 version are you running? Anything older than python 3.5 is not officially supported, as I only provide support up to the latest Ubuntu LTS release (currently Ubuntu 16.04 with python 3.5.1).


1158 | Insertion In Circular Linked List | Python

Title - Insertion In Circular Singly Linked List
What will change - Add solution to this problem
Type of Issue -

[x] Adding New Code
[x] Improving Code
[x] Bug Fix

Programming Language

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding

please assign this issue to me


exec() call to unknown plugin

Hello,
First thank you for your job!
I am having problems to get the Camera plugin working.
I create an empty React App and follow the instructions.
But, when i try to open the Camera this message appears in js error callback:
"Class not found"
And this in the log:
"D/PluginManager(26940): exec() call to unknown plugin: Camera"
Do you have any idea what is missing?
Thanks!

@matiascba I did try it on the camera plugin and was able to get it working. What version of node are yo uusing ? Do you see a camera java class under node_modules/react-native-plugin-adapter/platforms/android ? If not, try deleting node_modules and add it again.

Thanks for your reply!.
This is my node version: v4.0.0
I dont have this folder (node_modules/react-native-plugin-adapter/platforms/android)
i have this (node_modules/react-native-cordova-plugin/platforms/android),
but whitout a Camera java class inside
The only Camera java classes are in
(node_modules/cordova-plugin-camera/src/android/CameraLauncher.java)
I try removing the node modules and add it again, but, the same result.

I try with the cordova-plugin-device plugin, and everything was OK.
But the Camera plugin still give me this message in log:
PluginManager(26940): exec() call to unknown plugin: Camera"

Can you share the list of files you have in your project (including the node_modules folder) ? That would help trying to debug the issue. Also, what version of reactnative are you using ?

This is the code:
https://github.com/matiascba/react-cordova-camera-test
The react native version is 0.17

@kenchengch @niftylettuce I just published 1.0.0 version of this plugin on npm. I also now have an example app that shows how to use the plugins. It also had a working example of camera
Closing the issue - if you still find this to be an issue, please re-open it.


How to generate multiple files based in a Json

Hello Shannon, I've been using gul-hb as an Static website generator.
Now, I want to generate multiple files based on a Json file array.
how can I achieve that?
thanks!

Glad this has been helpful to you. There are many ways you could generate multiple files, so I'll need a little more context. What does your array look like and what output are you trying to get from it?

Ok!
my looks like:
{ "products" :[{
	"name" : "name of the product",
	"price" : "price of the product",
	"features" : ["feature of the product","feature of the product2"],
	"img" : "url"
}]
}

and I want to generate a html output like this
http://ekus-group.github.io/productos/producto-test.html
I want a file for every product in my array.
thanks

@fega Sorry for the delay in replying. Generating files based on data objects gets a little more complicated as you have to create the virtual files manually. If you can, having the json as separate files is pretty slick:
https://github.com/shannonmoeller/tmp
Otherwise, something like this might work (untested; note the npm dependencies being imported):
const File = require('vinyl');
const gulp = require('gulp');
const hb = require('gulp-hb');
const streamArray = require('stream-array');
const through = require('through2');

const products = [{
    "id": "foo",
    "name" : "name of the product",
    "price" : "price of the product",
    "features" : ["feature of the product","feature of the product2"],
    "img" : "url"
}];

function products() {
    return streamArray(products)
        .pipe(through(function (item, enc, cb) {
            const file = new File({
                path: `${item.id}.html`,
                data: item,
            });

            this.push(file);
            cb();
        }))
        .pipe(hb())
        .pipe(gulp.dest('dist'));
}

gulp.task('products', products);

Your milage may vary and this is just one of a few ways this could be tackled. Really depends on your specific needs.

Closing due to inactivity and that this isn't a bug-related thread. Feel free to reopen if needed.

Thought I might just post my problem here, since it's the same concept.
I've got a directory called 'dynamic' that has a bunch of json files. Each one is an array, containing info for a file. I'm wanting to iterate over the array in each JSON file, creating a file for each one using the template file they reference.
This is my current attempt:
http://pastebin.com/YKFANT0K
It seems to loop through each correctly. I tried using gutil.log() to check that it's reading everything correctly, and it seems to be all good in that regard. The problem is that it ends up only using the data from the last JSON file it reads. So if the directory has three JSON files, it loops through all three, but only creates the last one three times.


UWP: Unable to use Microsoft.EntityFrameworkCore.Sqlite Version 2

The solution is not building with latest stable version of Microsoft.EntityFrameworkCore.Sqlite 2.0.0 and getting below compiler error:

The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)

Due to this other types e.g. DbContext from this namespace are not found
It is not working with reloading project, restarting visual studio, PC, etc.
However, it is working if downgraded to Version: 1.1.2
Steps to reproduce
Install Package Microsoft.EntityFrameworkCore.Sqlite 2.0.0
Add some code to refer EF Core e.g.
using Microsoft.EntityFrameworkCore;
namespace SQLLiteStorageApp.Models
{
    class BloggingContext : DbContext
    {
    }
}

Build solution
Actual : Compiler Error
Expected: Solution should build
Further technical details
EF Core version: 2.0.0
Project Type: UWP App
Database Provider: Microsoft.EntityFrameworkCore.Sqlite
Operating system: Windows 10 1607 (14393.1593)
IDE: Visual Studio 2017 (15.3)

which version of UWP?

Latest Version 5.4.0

To use EF Core 2.0 with UWP you would need UWP 6+ (which is in prerelease state at present)
See https://github.com/aspnet/EntityFrameworkCore/issues/9401 for more details on prerequisites and how to use EF Core 2 in UWP 6.


fingerprint unexpected behavior when file has changed after the command run

Hi
I am encountering a logical behavior with the current implementation of fingerprint. I would like to discuss the possibility to handle the case I will demonstrate below.
Here is my use case :
if (! fingerprint(callback: static fn () => composer()->install(), fingerprint: fgp()->composer(), force: $forceVendor || $force)) {
    io()->note('Composer dependencies are already installed.');
} else {
    io()->success('Composer dependencies installed');
}

Simply the code will install the composer dependencies (command is run with --quiet for better visiblity)
The output of what is currently done by the script

But in that case, the second run of castor install should not run composer installation. Because in reality the file hasn't changed between the first and second installation
That behavior is actually due to current implementation.
https://github.com/jolicode/castor/blob/642a6a902dfffa5e00c437240bf03d6ceef13686/src/functions.php#L587-L597
We pass the computed $fingerprint directly on fingerprint method.
The checked and saved fingerprint is the same from start to the end of execution. And it seem that composer update the file without changing anything in it, but the fingerprint change.

What i have in mind is something like this :
function fingerprint(callable $callback, callable $fingerprint, bool $force = false, bool $delayed = true): bool
{
    $hash = $fingerprint();
    if ($force || !fingerprint_exists($hash)) {
        $callback();
        fingerprint_save($delayed ? $fingerprint() : $hash);

        return true;
    }

    return false;
}

// Current definition of fingerprint
function composer(): string
{
    return hasher()
        ->writeWithFinder(finder()->files()->in(path('app'))->name(['composer.json', 'composer.lock', 'symfony.lock']))
        ->finish()
    ;
}

// With the new implementation purposed (BC but we can support the two definition until 1.0 ? string|callable ?)
public function composer(): callable
{
    return function () {
        return hasher()
            ->writeWithFinder(finder()->files()->in(path('app'))->name(['composer.json', 'composer.lock', 'symfony.lock']))
            ->finish()
        ;
    };
}

WDYT about this approach, did you have another idea ? :smile:
Waiting for feedbacks

I don't like having callback, and i think your behavior can be fixed by using the FileHashStrategy::Content strategy instead of the FileHashStrategy::MTimes one
Also the proposed behavior may induce some bugs, i.e.:

I have a fingerprint on a file
I Update the file
I run a command that launch a very long task when this fingerprint has changed
I update the file before it has been updated
I rerun the command after the first one has finished -> no update (but it should have been run)

I don't like having callback, and i think your behavior can be fixed by using the FileHashStrategy::Content strategy instead of the FileHashStrategy::MTimes one
Also the proposed behavior may induce some bugs, i.e.:

I have a fingerprint on a file
I Update the file
I run a command that launch a very long task when this fingerprint has changed
I update the file before the command finish
I rerun the command after the first one has finished -> no update (but it should have been run)

Hi, thank for the response
Yes, I had thought of using FileHashStrategy::Content.
But this one can also be misleading, let's admit it:
I'm on the main branch with a file containing ABC => this will play the command then save it as a fingerprint.
Let's say I need to change branch to feat/anything here the file has been updated with XYZ so the command will also run.
But when I return to main the command won't run because ABC content is still in the fingerprint cache too.

Yes I see the use case, which is why I had the idea of including a delayed parameter to indicate that this fingerprint run will be saved in a different way.
But I think the case of user modification during a long task should use flock to prevent modification of this file?
IDK which is the best solution, it all depends on the use case

See #494 this should fix your issue

TL;DR; we introduce an id parameter to fingerprint functions, so now you would do the following :
if (! fingerprint(callback: static fn () => composer()->install(), id: 'composer-deps', fingerprint: fgp()->composer(), force: $forceVendor || $force)) {
    io()->note('Composer dependencies are already installed.');
} else {
    io()->success('Composer dependencies installed');
}

Cool i will test it ! thank you 🫶


move all reduces to the end in lazy

This is just an experiment.
I don't like how the reduce LazyOp doesn't specify the actual reduce operation. Neither new_shape nor axis list expresses it fully, but rather depends on what shape the input buffer has.
One idea is to have the arg just be the number of elements that are being reduced and move them to the end, but I'm not sure this is expressive enough for multireduce.

Oh I think this actually might work! The final permute isn't really a permute, it's a reshape of only 1s.

This is also already happening in the Linearizer


[Draft] revisit Backend API to have multiple Executor

This commit is draft for change Backend to have multiple Executor.
ONE-vscode-DCO-1.0-Signed-off-by: struss<EMAIL_ADDRESS>

as https://github.com/Samsung/ONE-vscode/pull/1094 updated, I will close this PR.


dnscrypt-proxy2: 2.0.15 -> 2.0.20

Motivation for this change
https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.20
https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.19
https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.18
https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.17
https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.16
Also, no need to pin to an old version of Go anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

AFAICT not much to test: dnscrypt-proxy (1) is used plenty, but not 2.

Closing in favor of #57949 :+1:, although I note the pin to 1.10 is still no longer needed but doesn't /hurt/ :).


[ENH] ClaSP (Time Series Segmentation paper in CIKM '21)

Is your feature request related to a problem? Please describe.
I would like to add ClaSP (CIKM '21), a state-of-the-art method for time series segmentation (similar to FLOSS) and a SeriesToSeriesTransform to sktime.
Describe the solution you'd like
ClaSP create a single profile per time series. However, it would be nice to also return some additional information computed along ClaSP:
Thus, I am currently struggling with the definition of:
_SeriesToSeriesTransformer
As a reference, I had a look at matrix_profile, which returns:
return pd.Series(Xt[:, 0])
Sorry, if I am missing out on something: Is there any means to return a tuple from transform?
return profile, k_nn_distances, ...

Great idea, though it should be an annotator, not a transformer - segmentation is a case of annotation..
have a look at the extension template here:
https://github.com/alan-turing-institute/sktime/blob/main/extension_templates/annotation.py
If you want to return more than the segmentation, you can use get_fitted_params where you can return anything you'd like.
I've noticed it's not in the annotation template, but the format is as in the forecasting template, it simply should return a dict and can return anything you'd like.
For distances, you may want to consider implementing a separate distance transformer, using the time series distance/kernel extension template.

Thank you very much! That was very helpful!
I am now trying to provide a Jupyter-Notebook alongside the code. However, when I import sktime packages, these are imported from my Anaconda sktime installation. Is there any way to import from my developer version instead?

@fkiraly This seems to be a workaround for my problem.
import sys
sys.path.insert(0,"..")

Is there any better way?

yes, sys.path.insert and sys.path.append works - the other option is pip install -e [dir location]
Also see here: https://www.sktime.org/en/latest/installation.html
(section: development versions)

@fkiraly
have a look at the extension template here:
https://github.com/alan-turing-institute/sktime/blob/main/extension_templates/annotation.py

If you want to return more than the segmentation, you can use get_fitted_params where you can return anything you'd like.

How would you implement the logic for segmentation:

Do the segmentation in fit and use predict to return just the segmentation and get_fitted_params to return all other parameters?
Do the segmentation in predict and return just the segmentation and get_fitted_params to return all other parameters?

Intuitively, I thought about using predict to do the computation - but then get_fitted_params is misleading, as the computation was done in predict ...

@fkiraly Maybe my problem is that segmentation is an unsupervised task. Thus, we do not really have a need for fitting a model - instead we do a combined fit_predict() for every series. Thus it is a bit unclear how to match it to the framework.

@patrickzib added clasp in #1352 but we forgot to close this issue.


Ccannot edit units on Manage Units it will not save

What version of Node.js are you using?
Latest
What version of npm are you using?
Latest
What operating system are you using?
Windows Server 2019
What version of SnailyCAD are you currently using?
v1.32.0 8235a89
Describe the Bug
Manage Units page is not saving changes on any units
{   "DEBUG": {     "message": "Request failed with status code 400",     "status": 400,     "response": {       "data": {         "name": "BAD_REQUEST",         "message": "badRequest",         "status": 400,         "errors": [           {             "badgeNumber": "Required"           }         ]       },       "status": 400,       "statusText": "Bad Request",       "headers": {         "content-length": "96",         "content-type": "application/json; charset=utf-8"       },       "config": {         "transitional": {           "silentJSONParsing": true,           "forcedJSONParsing": true,           "clarifyTimeoutError": false         },         "transformRequest": [           null         ],         "transformResponse": [           null         ],         "timeout": 0,         "xsrfCookieName": "XSRF-TOKEN",         "xsrfHeaderName": "X-XSRF-TOKEN",         "maxContentLength": -1,         "maxBodyLength": -1,         "env": {},         "headers": {           "Accept": "application/json, text/plain, */*",           "Content-Type": "application/json",           "Session": "",           "is-from-dispatch": "false"         },         "url": "https://api.enemyofthestaterp.com/v1/admin/manage/units/cl5bbgm7f309823nctmw3dabuxc",         "method": "put",         "data": "{\"status\":\"9b6599b7-b3e8-4767-b9cc-19c4f46f02b4\",\"department\":\"ckyby050c1514724tmbnb8upux\",\"division\":null,\"divisions\":[\"ckyc3r88h3007824tm990y7gdf\"],\"callsign\":\"PO\",\"callsign2\":\"34\",\"rank\":\"cl1wft9po66500xwtm7bt48alp\",\"position\":\"\",\"suspended\":false}",         "withCredentials": true       },       "request": {         "__sentry_xhr__": {           "method": "PUT",           "url": "https://api.enemyofthestaterp.com/v1/admin/manage/units/cl5bbgm7f309823nctmw3dabuxc",           "body": "{\"status\":\"9b6599b7-b3e8-4767-b9cc-19c4f46f02b4\",\"department\":\"ckyby050c1514724tmbnb8upux\",\"division\":null,\"divisions\":[\"ckyc3r88h3007824tm990y7gdf\"],\"callsign\":\"PO\",\"callsign2\":\"34\",\"rank\":\"cl1wft9po66500xwtm7bt48alp\",\"position\":\"\",\"suspended\":false}",           "status_code": 400         }       }     },     "method": "put",     "data": "{\"status\":\"9b6599b7-b3e8-4767-b9cc-19c4f46f02b4\",\"department\":\"ckyby050c1514724tmbnb8upux\",\"division\":null,\"divisions\":[\"ckyc3r88h3007824tm990y7gdf\"],\"callsign\":\"PO\",\"callsign2\":\"34\",\"rank\":\"cl1wft9po66500xwtm7bt48alp\",\"position\":\"\",\"suspended\":false}",     "url": "https://api.enemyofthestaterp.com/v1/admin/manage/units/cl5bbgm7f309823nctmw3dabuxc"   } }
DevTools failed to load source map: Could not load content for https://cad.enemyofthestaterp.com/admin/manage/units/4c9e2a747c7bda40.css.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
Expected Behavior
To be able to save changes on units
To Reproduce
No response

Okay, fixed now. Not tested but 99% sure it works now


Update the Home Page.

Content of home page.
All the features should be listed like collaborative workspace, test, coding platform etc.

I have a made a few things for a basic Frontend in your project and it's still in progress, if you like this kind of style you can check it out, also I will try to make to make an error page tomorrow for your project.

@alvarotorrestx had made a PR (#9 ) for the Error Page issue. Regarding the Home Page please make a PR so we can review it.


Remove constant height constraint from ValidationErrorView

This is set up in the validationErrorViewFactory instead, so that a custom
factory can provide its own constraints.

LGTM


Adding include_awaiting_enrollment option #43

Fixes #43

sorry for the delay, and thank you for the PR! i've merged it into dev 😊


fix: added the right repo social image.

What type of PR is this? (check all applicable)

[x] 🐛 Bug Fix

Description

This PR replaces the previous placeholder image of each card with the corresponding repository social image that will be generated by Github. Also, I removed the actions buttons at the bottom as suggested by @bdougie and placed the upvote button at the top right corner of the card at the same line where the contributor's avatars are located. Only the PostGrid file was changed for this PR
Related Tickets & Documents

Fixes #17
Added tests?

[x] 🙅 no, because they aren't needed

Added to documentation?

[x] 🙅 no documentation needed

Hello @0-vortex @kelvinsekx
Please could you help with the netlify test, it seems to be failing because of a package that is missing. This is what I found in the build logs
Error: The package "esbuild-linux-64" could not be found, and is needed by esbuild.
9:52:49 AM: If you are installing esbuild with npm, make sure that you don't specify the
"--no-optional" flag. The "optionalDependencies" package.json feature is used
9:52:49 AM: by esbuild to install the correct binary executable for your current platform.

@hokagedemehin you are having that error because your laptop OS is windows.

Hello @0-vortex @kelvinsekx
Please could you help with the netlify test, it seems to be failing because of a package that is missing. This is what I found in the build logs
Error: The package "esbuild-linux-64" could not be found, and is needed by esbuild.
9:52:49 AM: If you are installing esbuild with npm, make sure that you don't specify the
"--no-optional" flag. The "optionalDependencies" package.json feature is used
9:52:49 AM: by esbuild to install the correct binary executable for your current platform.

To resolve it, install the package on your end, and don't forget to save it as a development package
npm i -D esbuild-linux-64.
Everything should be fine when you do this.

Na wa oh. This life no equal at all.
May God bless me to buy Mac one day 😩😩😩😩😩

Can you please have your other PR merged?
You don't necessarily need two PRs at a time.

Na wa oh. This life no equal at all.
May God bless me to buy Mac one day 😩😩😩😩😩
But in that case, why did the other PR not have the same issue. All checks passed in my second PR

Did you just made a 'git pull' ?

I am getting this error when I tried running the code you suggested earlier
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"linux","arch":"x64"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS:    linux
npm ERR! notsup Valid Arch:  x64
npm ERR! notsup Actual OS:   win32
npm ERR! notsup Actual Arch: x64

I am getting this error when I tried running the code you suggested earlier
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"linux","arch":"x64"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS:    linux
npm ERR! notsup Valid Arch:  x64
npm ERR! notsup Actual OS:   win32
npm ERR! notsup Actual Arch: x64

esbuild-windows-64": "^0.14.5"
Install that instead. Pardon me, I literally just woke up.

Can you please have your other PR merged?
You don't necessarily need two PRs at a time.

Maybe you can merge the #48 pull request that has passed all the necessary tests and is fine. I will resolve all the conflicts with this one and do it again if necessary

Can you please have your other PR merged?
You don't necessarily need two PRs at a time.

Maybe you can merge the #48 pull request that has passed all the necessary tests and is fine. I will resolve all the conflicts with this one and do it again if necessary

You took this on first.
You are supposed to be done with this before taking another on. If you have any problem, put it here and we can discuss about it.

@kelvinsekx
I installed npm i -D esbuild-windows-64 and still failing the Netlify test and some development test
At this point, I don't know what might be wrong again

Hello @0-vortex @kelvinsekx
Please could you help with the netlify test, it seems to be failing because of a package that is missing. This is what I found in the build logs
Error: The package "esbuild-linux-64" could not be found, and is needed by esbuild.
9:52:49 AM: If you are installing esbuild with npm, make sure that you don't specify the
"--no-optional" flag. The "optionalDependencies" package.json feature is used
9:52:49 AM: by esbuild to install the correct binary executable for your current platform.

To resolve it, install the package on your end, and don't forget to save it as a development package
npm i -D esbuild-linux-64.
Everything should be fine when you do this.

That's not the appropriate fix for this. When switching branches he did not clean install branches, when switching to an older one some of his local dependencies were skipped and coming back to this PR required another clean install. Since esbuild is already part of our dependencies you should have suggested a new clean branch and running npm ci and check that result 🍕

@hokagedemehin the correct fix to unblock this PR is:
git restore package.json npm-shrinkwrap.json -s main

As for your local machine, are you keeping your branches in sync with upstream/main and running npm ci consistently?

@hokagedemehin the correct fix to unblock this PR is:
git restore package.json npm-shrinkwrap.json -s main

As for your local machine, are you keeping your branches in sync with upstream/main and running npm ci consistently?

If your fork is behind and you are using gh command line:
git restore package.json npm-shrinkwrap.json -s upstream/main

First of all, thank you all for your time and input in resolving my test issues, you guys are the best
Currently, I am creating a new branch and running git restore package.json npm-shrinkwrap.json -s main then npm ci again on the new branch
After that I will make the necessary changes to reflect the changes I want to push and try to make a new PR
Hopefully, this should not have any problem. But I have learnt something new today, always run npm ci for every new branch you create

First of all, thank you all for your time and input in resolving my test issues, you guys are the best

Always glad to help

Currently, I am creating a new branch and running git restore package.json npm-shrinkwrap.json -s main then npm ci again on the new branch
After that I will make the necessary changes to reflect the changes I want to push and try to make a new PR
Hopefully, this should not have any problem. But I have learnt something new today, always run npm ci for every new branch you create

That's not required, running the restore command applies those changes in the current branch, essentially this pull request; all you have to do is commit those changes to fix the CI builds, the npm ci command is to make sure you get your local environment up to date with main.
When switching branches, the npm ci command is required only if package.json file is different.
Please commit the changes to this pull request. Thank you for your patience and contribution! 🍕

🕺🏾🕺🏾🕺🏾🕺🏾🕺🏾🕺🏾💃🏾💃🏾💃🏾💃🏾💃🏾💃🏾💃🏾💃🏾
All tests passed.  🎉🎉🎉🎉🎉🎉🎉

dependency changes are good to go, not sure about HTML comments

I could remove the codes I commented out if you are ok with the final look of each card and the placement of the upvote button
Just give me the go ahead

I am still not feeling like the context of the data is needed with the social card now rendering. Can we do the following.

For the image object-fit: contain
Switch the grid to 3 columns from 4
Remove the h1 title and description (postgrid only)

Browser metadata
Path:      /
Browser:   Chrome 96.0.4664.110 on Mac OS 10.15.7
Viewport:  1146 x 977 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

I deleted a bunch of compliance comments.

Hi @bdougie compliments of the season, just getting home from my second job,
I will work on your request and resolve all the merge conflicts that exist in the PR
Thank you for your review

Hello @bdougie
Could you take a look at the current changes that I just committed to see if it reflects what you asked for
Thank you


Ethereum Network by using CryptoCurrencyPHP?

Hey,
thanks for CryptoCurrencyPHP.
Is it possible to apply the lib functionality to the Ethereum network? If so, do you have some examples?

Why is the calculated address incorrect？


⚠ Bofrost.fr has degraded performance

In 229dc39, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1059 ms

Resolved: Bofrost.fr performance has improved in f01a5b4.


1.21.4 support?

title speaks for itself i think

I have had my rewrite of the mod (version 1.2) kind of ready for some time which supports this version but I haven't been really active due to some mental health things irl so I can't really give you an eta when it will release but hopefully soon that's all I can really say


Exclude win32 compiler tests with JDK17

Compiler tests on win32 failed with errortUnrecognized VM options, looks like those options are only recognized by a GC implementation which is not built on win32.
https://github.com/adoptium/aqa-tests/issues/2382
https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_extended.openjdk_x86-32_windows_testList_0/10/
Those test should be excluded on win32.
The following section should be added in https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk17.txt
############################################################################

# jvm_compiler

compiler/arraycopy/TestCloneAccess.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/arraycopy/TestCloneAccessStressGCM.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestByteVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestDoubleVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestFloatVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestIntVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestIntVectRotate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestLongVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestLongVectRotate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/cr6340864/TestShortVect.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/TestReplaceEquivPhis.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/c2/TestShiftRightAndAccumulate.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/codegen/TestCharVect2.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopopts/superword/Vec_MulAddS2I.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopopts/TestUnswitchCloneSkeletonPredicates.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/AntiDependentLoadInOuterStripMinedLoop.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/LoadDependsOnIfIdenticalToLoopExit.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/TestConservativeAntiDep.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/loopstripmining/TestEliminatedLoadPinnedOnBackedge.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/rangechecks/RangeCheckEliminationScaleNotOne.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/types/TestSubTypeCheckMacroNodeWrongMem.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86
compiler/vectorization/TestVectorsNotSavedAtSafepoint.java https://github.com/adoptium/aqa-tests/issues/2382 windows-x86

can i have this issue?


[AutoPR keyvault/resource-manager] adding readme.nodejs.md for automated node sdk generation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2637

(message created by the CI based on PR content)


Issues with iframes

I have been having a few issues with iframes. Namely, I am able to get the iframe but not able to query anything within it. I even get issues trying to the the iframe.content(). I have looked at many guides, such as https://www.webshare.io/academy-article/puppeteer-iframe#:~:text=Switching to an iFrame,contentFrame()%3B await page
but have had no luck. Wondering if there's an issue with chrome or puppeteer-core that you may know about.

I can open it again if you can provide information by adding a code where the error can be repeated for testing. Unfortunately, it is not possible to examine an error that I cannot reproduce. There is no known problem. There is no iframe in the https://example.com/ link used in the example on the relevant site. It is normal to get an error.

Could we leave this open just for discussion.
I am able to get the iframe element but none of the content underneath it. I was wondering if anyone else was running into iframe issues, and if so what the resolution was. When not using puppeter-real-browser, I did not have issues with iframes.

Here is the code I used with replaced variable names.
`const frameElementHandle = await page.waitForSelector('#ifrm');
if (!frameElementHandle) {
throw new Error('Frame handle missing');
}
const frame = await frameElementHandle.contentFrame();
if (!frame) {
throw new Error('Frame not found');
}
  const selectElement = await frame.evaluateHandle(() =>
    document.querySelector('#SelectId'),
  );`

@zfcsoftware I think this is a real issue, I just tried the same code with only puppeteer-extra-stealth and puppeteer-fingerprint-injector (which runs on chromium) and it worked great.
would love for this to open up to discussion incase anyone else has run into this problem and has fixed it. Contemplating whether it was some of the flags under --args causing this.

Some additional details. I ran in sandbox, and i added the IsolateSandboxedIframes to the disable-features flag. Unfortunately, this did not fix anything.

Have not been able to repro on a website like "https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe", but I am definitely having issues when testing on site (that requires access). Unable to wrap my heard around what settings can cause issues for this package specifically.

Should new page be returned?
Change (draft):
 browser.on('targetcreated', async target => {
     if (target.type() === 'page') {
-         let newPage = await target.page();
-         pageControllerConfig.page = newPage
-         newPage = await pageController(pageControllerConfig);
+         pageControllerConfig.page = await target.page()
+         const newPage = await pageController(pageControllerConfig)
+         return newPage

@zfcsoftware I think this should be re-opened.

Probably this problem was caused by a low version of puppeteer-core. Recently rebrowser supported higher versions of puppeteer--core. The library has also been updated. This issue should be resolved. If it persists, please provide a code block where I can reproduce the error. Thanks for your feedback.

I also noticed problems with IFrame, and you can use this script below to test it yourself @zfcsoftware
Note that this works in normal puppeteer.
`import {connect} from "puppeteer-real-browser";
async function sleep(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}
async function run() {
const { page, browser } = await connect({
headless: 'auto',
args: ['--disable-search-engine-choice-screen'],
customConfig: {},
skipTarget: [],
fingerprint: false,
turnstile: true,
disableXvfb: true,
connectOption: {
defaultViewport: null
},
});
await page.goto('https://www.dezlearn.com/nested-iframes-example/', { waitUntil: 'domcontentloaded' });
const firstIFrame = await page.waitForSelector('iframe', { timeout: 5000 }).catch(() => null);
await sleep(1000);
if(!firstIFrame) {
    console.log('IFrame not found');
    await browser.close();
    return;
}
const firstIFrameContent = await firstIFrame.contentFrame();
const secondFrame = firstIFrameContent.childFrames()[0];
if(!secondFrame) {
    console.log('Second IFrame not found');
    await browser.close();
    return;
}
// We search for the button in the second frame
console.log('Looking for button...');
const button = await secondFrame.$('button').catch(() => null);
console.log('This line does not appear');
if(!button) {
    console.log('Button in second iframe not found!');
    await browser.close();
    return;
}
await button.click();
console.log('It worked!');
await browser.close();

}
await run();`

Facing the same problem too even after updating the library,
Any element inside an iFrame cannot be accessed or found at all.

I have the same issue with iframes

Having the same issue. real-browser isn't solving a turnstile, I believe because its inside of an iframe. Is there any update @zfcsoftware ?

I just fixed the issues with iframes in new version of rebrowser-patches.
Please use the latest version and REBROWSER_PATCHES_RUNTIME_FIX_MODE=addBinding.

@nwebson You posted this just in time, was in the middle of migrating some stuff to rebrowser :). Thank you. Will lyk if I run into issues here.

This problem should be solved with the new rebrowser update. If the problem persists, please report it here.

@nwebson You posted this just in time, was in the middle of migrating some stuff to rebrowser :). Thank you. Will lyk if I run into issues here.

If rebrowser solves your problem, I recommend using rebrowser before this library. If you are facing some detection issues like mouse bugs and chromium being used, this library is ideal. Rebrowser gives you more flexibility.

Having the same issue. real-browser isn't solving a turnstile, I believe because its inside of an iframe. Is there any update @zfcsoftware ?

Still having same issue after updating, it doesn't solve turnstile automatically on 4chan, which is inside an iframe. It works fine on other websitse & the test cases pass.
Reproduction code:
import { connect } from "puppeteer-real-browser";

(async() => {
    const { browser, page } = await connect({
        headless: false,
        args: [],
        customConfig: {},
        turnstile: true,
        connectOption: {},
        disableXvfb: false,
        ignoreAllFlags: false
    })

    //Goto anime board
    await page.goto('https://boards.4chan.org/a/')

    //Click the `Create Thread` button at top of screen
    await page.evaluate(() => document.getElementsByTagName('a')[90].click())

    //Click `Get Captcha`
    await page.evaluate(() => document.getElementById('t-load').click())

    //The turnstile is now loaded, but not automatically solved :(
})();

Any ideas? thx

@nopmal thanks for pointing out this case, was really useful for my research.
@zfcsoftware I would try to do something like that:
# current code
const elements = await page.$$('[name="cf-turnstile-response"]');

# my suggestion
for (const frame of page.frames()) {
  const elements = await frame.$$('[name="cf-turnstile-response"]');
}

Has anyone found a solution with iframe?


feat: add contingent rules with tests

Starting this PR because I want to only apply rules to certain files in my codebase.
"Contingent rules" seem to be the rules which are only applied to certain files. 4548c6f adds loading for these rules, adds a matches_path function to RuleConfig which can be used to see if a rule should be run on a given path, and adds a test for testing both of these.
Note: Globset was used because this was the same library that ignore uses. The Glob object can be used to build overrides for ignore's WalkBuilder. Unsure if I'll go with this approach when integrating it with the CLI.
I am currently looking at integrating this with the CLI.
Would love some early feedback or direction. Will mark as ready for review when ignores/files works.

OMG! Thanks for your kind pull request! I didn't expect such significant pull request comes so fast!
I will give this a look later. The general direction of using existing crate that ignore uses sounds great to me. Thanks for being considerate!

For more context, the current RuleBucket implementation is largely unpolished and incomplete.
Ideally I will rather have TenuredRule struct which will combine all non-conditional rules into one rule.
And there will also be a ContingentRulestruct that build the glob set when it is created.
But I would say this change is too far fetching in this pull request. I'm inclining to merge this one and unblock you.

For more context, the current RuleBucket implementation is largely unpolished and incomplete
Ideally I will rather have TenuredRule struct which will combine all non-conditional rules into one rule.
And there will also be a ContingentRulestruct that build the glob set when it is created.
But I would say this change is too far fetching in this pull request. I'm inclining to merge this one and unblock you.

That context is helpful -- I assumed you had something planned for it since there were some TODOs!
Your future design makes sense. I can see a path to make file walkers for each ContingentRule and keep the same rule walker for a tenured rule..
This PR is pretty self contained and backwards compatible, but it would be nice to have the full feature here. If I find that adding this logic to the scanner would be less complicated if we had the TenuredRule and ContingentRule structs, I will reassess. I'll keep you updated.

@HerringtonDarkholme I've added the functionality to the scanners! Updated the PR description to reflect my approach. Thanks for being so welcoming :grin:

Thanks for the prompt response and adding test! Looks good to me 😉

Codecov Report

Merging #82 (27c2b3a) into main (653b8ec) will increase coverage by 0.47%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   52.69%   53.17%   +0.47%
==========================================
  Files          27       27
  Lines        1575     1606      +31
==========================================
+ Hits          830      854      +24
- Misses        745      752       +7

Impacted Files
Coverage Δ

crates/cli/src/scan.rs
30.40% <0.00%> (-0.50%)
:arrow_down:

crates/config/src/rule_collection.rs
62.85% <0.00%> (-8.12%)
:arrow_down:

crates/config/src/rule.rs
87.67% <96.00%> (+4.33%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


VirtualMachine.capture() returns illegal argument exception

VirtualMachine.capture("containername", true) returns: vhdPrefix is required and cannot be null, but does not appear to take in any info around prefix.

This is fixed in the 1.0.0.beta4-snapshot (master branch) but even though you can initiate the capture API with this fix you will still get NPE due this issue https://github.com/Azure/azure-sdk-for-java/issues/1230

presumably fixed in 1.0.0-beta4.1 since https://github.com/Azure/azure-sdk-for-java/issues/1230 is fixed.


Route middleware executed twice

In my server.js I connect my routes like the following:
var router = express.Router();
app.use('/api/v1', require('./routes/api/v1')(router));

and in my ./routes/api/v1.index.js I have thw following:
module.exports = function (routes) {

  // middleware to use for all requests
  router.use(function(req, res, next) {
    console.log('Url is: ' + req.url);
    next(); // make sure we go to the next routes and don't stop here
  });

   // api route
   router.get('/controller/action', function () {
       res.json({ message: 'hooray! welcome to our api!' });
   }) ;

  return router;
};

When I issue the following AJAX:
GET /api/v1/controller/action

middleware above get executes twice with the following logs:
Url is: /api/v1/controller/action
Url is: /controller/action

Is it bug? How could I execute it once?

see this http://stackoverflow.com/questions/18266794/express-request-with-middleware-called-twice-with-express-namespace

@raymondfeng i have simplified your example
const express = require('express');

const app = express();

app.get('/', function(req, res) {
  console.log(`Url is: ${req.url}`);
  res.send(`Url is: ${req.url}`);
});

app.listen(3000);

console output
Url is: /
Url is: /


memory leak caused by requestAudioFocus() on ReactExoplayerView

memory leak caused by requestAudioFocus() on ReactExoplayerView

Platform

Which player are you experiencing the problem on:

Android ExoPlayer

Environment info

React native info output:
System:
    OS: macOS 10.15.3
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
    Memory: 18.35 MB / 8.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 13.0.1 - /usr/local/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.12.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 17, 19, 21, 22, 23, 25, 26, 27, 28, 29
      Build Tools: 20.0.0, 21.1.2, 23.0.1, 23.0.2, 23.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.2, 26.0.3, 27.0.2, 27.0.3, 28.0.0, 28.0.3, 29.0.0, 29.0.1
      System Images: android-24 | Google Play Intel x86 Atom
      Android NDK: 17.1.4828580
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
    Xcode: 11.4/11E146 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.60.0 => 0.60.0

Library version: x.x.x
Steps To Reproduce

render react-native-view
destroy react-native-view
repeat 1 and 2
ReactExoplayerView didn't release

Expected behaviour

ReactExoplayerView can release

Cause
when requestAudioFocus() was executed, the ReactExoplayerView instance will register in AudioManager and never release. If we didn't close app and repeat render view, it may cause memory leak.
Solution
We found a solution to fix this issue, invoke audioManager.abandonAudioFocus() in the releasePlayer() as below.
    private void releasePlayer() {
        if (player != null) {
            updateResumePosition();
            player.release();
            player.setMetadataOutput(null);
            player = null;
            trackSelector = null;
        }
        progressHandler.removeMessages(SHOW_PROGRESS);
        themedReactContext.removeLifecycleEventListener(this);
        audioBecomingNoisyReceiver.removeListener();
        BANDWIDTH_METER.removeEventListener(this);
        audioManager.abandonAudioFocus(this);
    }

This is our solution, you can merge it or find other solution.
Thank you~

I can confirm that there is an audio related leak and that this patch is insufficient to address it.

I have a very long-running app, and the lion's share of the memory leak appears to be related to the sound management of the video player's audio management.

I face the problem too in<EMAIL_ADDRESS>any suggestion?

I can confirm this issue is still happening on latest 5.2.x line.

linked PR merge, will be available in 6.0.0-alpha.7


Adds configuring synapse gateway logs

Purpose
$Subject
Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

@jaadds Fixed the URL with 3792e1a


memory leak when closing manually

when user close the notifiers manually there is memory leak of the setInterval function that were not cleaned up.
I tested it with IE snapshots and got for each notification that I closed manually "Anonymous function" that when I click them it redirect me to the setInterval function.

I resolved the bug and commit it, please check.

Where?

OK... sorry...
I never comitted to github before...
so now you can see it?
https://github.com/mouse0270/bootstrap-notify/pull/135/commits


Quic compliance for connection termination

[ ] documentation is added or updated
[ ] tests are added or updated

Remembered to push my changes this time around.

Ping @openssl/committers for second review please.

@t-j-h reviews are taking forever currently which is an impediment.
The intention here was mostly to add comments pointing to the RFCs and confirming that what was required was done, the amount of code required was fairly small.
I split out the stateless reset effort because there is more there to be done and it involves a quite a bit more than referencing the RFCs.  It's a work in progress currently.

Merged, thanks for the reviews and comments.  Well worthwhile.


Setting the default value of the DatabricksRM.forward  "query_type"

Setting the default value of the DatabricksRM.forward  "query_type" param to "text"
It is recommended to use the fully managed approach for Vector Search which covers getting the embeddings from the of the indexed column during the ingestion and the embeddings of the text query during inference

Thanks @lmoros-DB !


feature/NWPS-411-ExpanderComponent

Hi @Raq-HEE / @adaMiclos , please review this expander component
http://localhost:8080/site/patient-and-public-information/introduction

Lets fix the merge conflicts

Lets add some reloads for guidance in hcm:actions


Make organization SSO login more convenient

Description
I have to confirm my organization's SSO every day on this page:

Would be nice to make this more convenient by:

Having the Return key trigger the green Continue button so you don't have to use the mouse.
Maybe having the button automatically clicked?

Example URLs
https://github.com/orgs/MyOrg/sso

This reminds of the fact that I would like many things (in GitHub and other programs) to be easier to do. About another button in GitHub.

super niche

I disagree here. Lots of organizations will use login coupled to SSO.
The other two points against adding this feature that you made I agree with though!


feat(SearchBox): allow custom reset and submit components

What project are you opening a pull request for?

react-instantsearch (use v2 base)

Summary
Because the searchbox is icon-based, but we still want to allow people to give custom icons, the solution here is to have custom components. They start lowercase and then end with Component.
A similar solution might be used for example in pagination if this seems useful
see #1954
fixes #1952
Result
Here a text-based (span with emoji content) submit button and an svg as reset button have been chosen as demo.

That's nice! Thanks @Haroenv
As for the stories, I'm wondering if we should considerer an example illustrating the text first way. Either as a new one or replacement?

Because of the changes in #1795 it's pretty much impossible to make the buttons have text instead of a square icon. Even with a lot of changes it's still impossible to put :active styles around the __wrapper instead of the __input. Square content works perfectly without any css change.
Here is the changes I made to use flexbox instead, which ultimately looks like this:

prototype text-based SearchBox
diff --git packages/react-instantsearch-theme-algolia/mixins/_searchbox.shipow.scss packages/react-instantsearch-theme-algolia/mixins/_searchbox.shipow.scss
index 30b844b1..ac840932 100644
--- packages/react-instantsearch-theme-algolia/mixins/_searchbox.shipow.scss
+++ packages/react-instantsearch-theme-algolia/mixins/_searchbox.shipow.scss
@@ -52,29 +52,27 @@
   &__wrapper {
     width: 100%;
     height: 100%;
+    display: flex;
+    border: 1px solid $input-border-color;
+    border-radius: even-px($border-radius);
   }

   &__input {
     @include input();
     display: inline-block;
     transition: box-shadow .4s ease, background .4s ease;
-    border: 1px solid $input-border-color;
-    border-radius: even-px($border-radius);
     background: $input-background;
     box-shadow: 0 1px 1px 0 rgba(85, 95, 110, 0.2);
     padding: 0;
-    padding-right: if($icon-position == 'right', even-px($input-height) + even-px($icon-clear-size) + 8px, even-px($input-height * .8))
-              + if($icon-background-opacity == 0, 0, even-px($font-size));
-    padding-left: if($icon-position == 'right',
-              even-px($font-size / 2) + even-px($border-radius / 2),
-              even-px($input-height) + if($icon-background-opacity == 0, 0, even-px($font-size * 1.2)));
     width: 100%;
     height: 100%;
     vertical-align: middle;
     white-space: normal;
     font-size: inherit;
     appearance: none;
-
+    order: 2;
+    flex-grow: 1;
+
     &::-webkit-search-decoration,
     &::-webkit-search-cancel-button,
     &::-webkit-search-results-button,
@@ -96,26 +94,22 @@
   }

   &__submit {
-    position: absolute;
-    top: 0;
     @if $icon-position == 'right' {
-      right: 0;
-      left: inherit;
+      order: 3;
     } @else {
-      right: inherit;
-      left: 0;
+      order: 1;
     }
     margin: 0;
     border: 0;
     border-radius: if($icon-position == 'right', 0 $border-radius $border-radius 0, $border-radius 0 0 $border-radius);
     background-color: rgba($icon-background, $icon-background-opacity);
     padding: 0;
-    width: even-px($input-height) + if($icon-background-opacity == 0, 0, even-px($font-size / 2));
     height: 100%;
     vertical-align: middle;
     text-align: center;
     font-size: inherit;
     user-select: none;
+    flex-grow: 0;

     // Helper for vertical alignement of the icon
     &::before {
@@ -123,7 +117,7 @@
       margin-right: -4px;
       height: 100%;
       vertical-align: middle;
-      content: ''2
+      content: '';
     }

     &:hover,
@@ -145,11 +139,6 @@

   &__reset {
     display: none;
-    position: absolute;
-    top: (even-px($input-height) - even-px($icon-clear-size)) / 2 - 4px;
-    right: if($icon-position == 'right',
-      even-px($input-height) + if($icon-background-opacity == 0, 0 , even-px($font-size)),
-      (even-px($input-height) - even-px($icon-clear-size)) / 2 - 4px);
     margin: 0;
     border: 0;
     background: none;
@@ -158,6 +147,12 @@
     font-size: inherit;
     user-select: none;
     fill: $icon-color;
+    @if $icon-position == 'right' {
+      order: 1;
+    } @else {
+      order: 3;
+    }
+    flex-grow: 0;

     &:focus {
       outline: 0;
diff --git stories/SearchBox.stories.js stories/SearchBox.stories.js
index 2e764ea8..ed3289b0 100644
--- stories/SearchBox.stories.js
+++ stories/SearchBox.stories.js
@@ -8,6 +8,18 @@ const stories = storiesOf('SearchBox', module);

 stories.addDecorator(withKnobs);

+const i18n = {
+  en: {
+    search: 'search',
+    clear: 'clear',
+  }
+}
+const Intl = ({ val, lang = "en" }) => (
+  <span style={{ padding: ".2em", textTransform: "uppercase" }}>
+    {i18n[lang][val]}
+  </span>
+);
+
 stories.add('default', () =>
   <WrapWithHits searchBox={false} hasPlayground={true} linkedStoryGroup="SearchBox">
     <SearchBox/>
@@ -16,6 +28,13 @@ stories.add('default', () =>
   <WrapWithHits searchBox={false} hasPlayground={true} linkedStoryGroup="SearchBox">
     <SearchBox defaultRefinement="battery" />
   </WrapWithHits>
+).add('text based buttons', () =>
+  <WrapWithHits searchBox={false} hasPlayground={true} linkedStoryGroup="SearchBox" >
+    <SearchBox
+      submitComponent={<Intl val="search" />}
+      resetComponent={<Intl val="clear" />}
+    />
+  </WrapWithHits>
 ).add('with submit and reset components', () =>
   <WrapWithHits searchBox={false} hasPlayground={true} linkedStoryGroup="SearchBox" >
     <SearchBox

The reason this doesn't work properly is because what's the case now is that the buttons are being put "inside" the input and the input has a padding that fits the width of the buttons. This doesn't work when they can have different sizes.
This PR still works for custom icons, so I think that's valuable, because it stays within the philosophy o f #1795 of giving a good default, but if you want to have a custom searchBox, then you should write one.

If I summarize this PR, we now provide a way to provide icons if they fit in the current CSS we are providing.
But if you want simple text buttons for submit you should basically have a custom searchbox? If so it means we are not fixing https://github.com/algolia/instantsearch.js/issues/1952 no?

Yes, unfortunately the way the css works makes it impossible to both have the buttons inside but text outside. This will work no problem when you have a custom css

LGTM, @mthuret?


Zoom breaks when browser viewport size changes e.g. portrait to landscape or vice versa

While testing the responsiveness of this plug-in with gatsby, I noticed the zoom capability will disappear after the browser viewport resolution is changed, e.g. portrait to landscape or vice versa. A common use case when viewing with mobile device.
By examine the DOM, before the viewport size change:

after the browser viewport resolution is changed, the class medium-zoom-image that use to be applied against  tag will disappear and hence the loss of the zoom functionality:

Current Workaround
While not ideal, the zoom functionality can be restored with another manual refresh after the viewport resolution change.

After some more troubleshooting, I later found the issue above can be reproduced if the component is re-mounted. Looks like when the component mounts again, the class medium-zoom-image does not get apply.

Is there some workaround for this issue?


JSONB1 style output missing @JsonbCreator for enum

Hi,
we currently face a problem in our project where we try to switch from Jackson2 annotation style to JSONB1 if it comes to handle enum types.
Given the below json schema, the Jackson2 output creates a @JsonCreator annotation, whereas the JSONB1 output does not have that even though the equivalent @JsonbCreator annotation exists since JSON Binding 1.0.
JSON-Schema (can be tested online)
{
        "type" : "object",
        "properties" : {
            "myEnum" : {
                "type" : "string",
                "enum" : ["one", "two", "three"]
            }
        }
}

Produces Jackson2 output like this
@JsonCreator
public static Example.MyEnum fromValue(String value) {
    Example.MyEnum constant = CONSTANTS.get(value);
    if (constant == null) {
        throw new IllegalArgumentException(value);
    } else {
        return constant;
    }
}

But produces JSONB1 output like this (note the missing @JsonbCreator annotation
public static Example.MyEnum fromValue(String value) {
    Example.MyEnum constant = CONSTANTS.get(value);
    if (constant == null) {
        throw new IllegalArgumentException(value);
    } else {
        return constant;
    }
}

When trying to map the json input string into a Java POJO, we get the following runtime exception:
Caused by: javax.json.bind.JsonbException: Internal error: No enum constant com.example.ClassName.EnumName.Constant
        at org.eclipse.yasson.internal.Unmarshaller.deserializeItem(Unmarshaller.java:68)
        at org.eclipse.yasson.internal.Unmarshaller.deserialize(Unmarshaller.java:51)
        at org.eclipse.yasson.internal.JsonBinding.deserialize(JsonBinding.java:59)
        at org.eclipse.yasson.internal.JsonBinding.fromJson(JsonBinding.java:66)
        ... 34 more
Caused by: java.lang.IllegalArgumentException: No enum constant com.example.ClassName.EnumName.Constant
        at java.lang.Enum.valueOf(Enum.java:238)
        at org.eclipse.yasson.internal.serializer.EnumTypeDeserializer.deserialize(EnumTypeDeserializer.java:37)
        at org.eclipse.yasson.internal.serializer.EnumTypeDeserializer.deserialize(EnumTypeDeserializer.java:23)

Any idea why the @JsonbCreator annotation is missing in the generated JSONB1 class ?
This is currently a blocker for our JSONB1 migration of our code.
Any help appreciated.
Thx

Hi
According to JSR 367: JavaTM API for JSON Binding (JSON-B) specification:

3.9 Enum
Serialization of an Enum instance to a JSON String value MUST follow the conversion process
defined in javadoc specification for their name().
Deserialization of a JSON value into an enum instance MUST be done by calling the enum’s
valueOf(String) method.

Thus having given annotation on public static Example.MyEnum fromValue(String value) { would be a NOOP unless chosen JSR367 implementation library does not respect spec.

Hi,
may be it helps, if I actually describe what we are trying to achieve and then see if that is possible or not using your plugin.
So far we've been using Jackson 2 to convert from json to java and back - the Java classes have been generated using your plugin v 1.2.1 with the Jackson 2 annotation style. That works fine also for enums, as Jackson 2 uses the @JsonCreate and @JsonValue
We are now trying to use JSON-B API and still have Jackson 2 underneath - only thing we'd like to achieve is to use a Java standard API instead of a proprietary Jackson 2 API. Underlying implementation is still Jackson 2 though (as this is supported/provided by our JBoss runtime environment.) So we generated the Java classes from the same json schema using annotation style "jsonb1" (btw, your doc needs to be updated as it mentions "jsonb" as a valid annotation style, but actually "jsonb1" is the right one to use).
Our expectation is that the same conversion happens as was with directly using Jackson 2.
In fact no conversion happens as Runtime error is thrown when deserializing enums - is that what the specs mandate ?
Thx

Hi,
you are right - the stacktrace is from yasson as we use this lib for our unit test cases (and that is where the stacktrace is from). Nonetheless, we've seen the same exception in our JBoss runtime env which is using Jackson 2. Redhat/Jboss ships with an intermediate layer called "jboss-jackson2-provider" - as per my understanding, that layer handles all the JSON-B stuff(annotations and other objects) and translates that into the resp. Jackson 2 methods, so Jackson itself does not need to support JSON-B.
The basic problem we see with yasson as well as Jboss/Jackson2 is the following as per my understanding -
We have an enum that defines a constant as "CONSTANTNAME("constantname")"
The Json message we consume has a string as "constantname" and during desrialization, that string should be mapped to that enum. Problem is, that the mapping method gets the string with all lower case letters (=constantname) and tries to find a resp. constant in the enum - that doesn't succeed because the constant in the enum is "CONSTANTNAME" => "No enum constant constantname" error.
I double checked by manually modifying the string from "constantname" into "CONSTANTNAME" and then the error is gone and mapping works. Unfortunately we receive those messages from upstream system and they can't/won't change the string contant to be all upper case letters so it matches the enum constant.
Any idea how to solve that problem ?

Any idea how that can be achieved ?

Please see #2. below.

Unfortunately we receive those messages from upstream system and they can't/won't change the string contant to be all upper case letters so it matches the enum constant.

I see 4 possibilities:

consider dropping the idea of migrating to json-b (current pitfall might be not the last one you'd be encountering)
adjust by either

pre-processing/transforming schemas received from upstream before feeding them to plugin
creating and using either

custom annotator that would add @JsonbCreator via https://github.com/joelittlejohn/jsonschema2pojo/blob/98c85ce4d4b9333bafae2c18eca5637ea6a7c5da/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/Annotator.java#L139-L149
custom rule factory providing subclass of EnumRule https://github.com/joelittlejohn/jsonschema2pojo/blob/98c85ce4d4b9333bafae2c18eca5637ea6a7c5da/jsonschema2pojo-core/src/main/java/org/jsonschema2pojo/rules/EnumRule.java#L68
having logic that would generate enum constants as is desired

use yasson/some other json-b library and explore possibility to customize serialization/deserialization behavior eg.
https://stackoverflow.com/questions/54290020/ignore-enum-case-with-json-b-yasson
check if there are other plugins available that would work out of the box for you

Hi @joerg-d-schneider-db. Could you check what actually happens when you add the JsonbCreator annotation on the fromValue method? My guess is that it does not help.
It looks like the right solution here is to declare a new class that implements javax.json.bind.serializer.JsonbDeserializer and then add the JsonbTypeDeserializer on the enum type.

If we need to create a static inner class on every enum, that implements javax.json.bind.serializer.JsonbDeserializer, and annotate the enum to reference that class, we can easily do that. This can be active only when using jsonb.
It's a real shame the spec creators didn't think to just use the JsonbCreator annotation on a deserialization method :)

Serialization would also need to use custom methods imo, not just deserialization - same way as it is needed for the Jackson 2 impl

Yes true, so I guess a javax.json.bind.serializer.JsonbSerializer too :)

I tried out the @JsonbCreator annotation on the static fromValue method like this
@JsonbCreator()
public static CoreTradeData.EventType fromValue(String value) {
CoreTradeData.EventType constant = CONSTANTS.get(value);
if (constant == null) {
throw new IllegalArgumentException(value);
} else {
return constant;
}
}
That doesn't help as still the same exception "No enum constant ..." is thrown. I guess the meaning of that annotation is different than the one in use by Jackson. In JSONB, the @JsonbCreator annotation apparently is required for constructors with parameters, but not just as a replacement for the default constructor.
I also tried out to use inner classes to implement either a JsonbAdapter or JsonbDeserializer, but no success as the JSONB implementation don't find the default constructor of that class as it needs to be referenced using the outer class name + inner class name. Using a regular class as adapter/deserializer seems to work - at least the methods are being called ;-)
I don't know if my expertise is good enough to implement either an adapter or de/serializer, but will give my best ;-)
Will keep you posted.
Thx

Managed to get the problem fixed at least for one enum deserialization
import java.lang.reflect.Type;
import javax.json.bind.serializer.DeserializationContext;
import javax.json.bind.serializer.JsonbDeserializer;
import javax.json.stream.JsonParser;
import com.db.cse.trade.domain.sdp.CoreTradeData.EventType;
public class EventTypeMapper implements JsonbDeserializer {
@Override

//    public CoreTradeData.EventType adaptFromJson(JsonObject adapted) throws Exception {
public EventType deserialize(JsonParser parser, DeserializationContext ctx, Type rtType) {
System.out.println("Inside adaptFromJson!");
String value = parser.getString();
if(value != null) {
System.out.println("found value for event type <" + value + ">");
return EventType.fromValue(value);
} else {
System.out.println("value is null");
}
return null;
}
}

Hi,
found that link https://github.com/FasterXML/jackson-databind/issues/677 - apparently Jackson v 2.6 supports @JsonProperty to define a vlue to be used for de/serialization. That would make that custom mapping obsolete imo.

But we don't need a solution for Jackson, right? The current approach using JsonCreator and JsonValue annotations works correctly.

I finally made it somehow - at least works for me
I've put the following inner class into the generated enum with name "EventType" :
    public static class EventTypeMapper implements JsonbAdapter<EventType, String> {
    	@Override
        public String adaptToJson(final EventType obj) {
    		return obj.value();
        }
        @Override
        public EventType adaptFromJson(final String obj) {
        	return EventType.fromValue(obj);
        }
    }

In the surrounding class I add the following annotation
@JsonbTypeAdapter(CoreTradeData.EventType.EventTypeMapper.class)
@JsonbProperty("eventType")
private CoreTradeData.EventType eventType;

works for me and should be easy to implement as only an additional annotation is required for each enum and a static inner class
Any comments ?


Add polish translation

Thank you!

@Antoni-Czaplicki, would you like to add state translation before next release?
Check https://github.com/IATkachenko/HA-SleepAsAndroid/commit/12d649c779604491574bb7d237a4222aa7927aea for details (changes sensor.py made to allow state translation support).

Sure, but does it change the names of states in automations?

No, states will stay as json keys, like before:

It will affect only to state in UI

Done in #36


Fix #1096

Cleanup Java API to remove all SWIGTYPE_* opaque pointer.

@lperron I'm waiting CI before merging


iPhone 14 Pro and Pro Max screenshots have a new screen size that is not supported by deliver

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

It looks like support for the new iPhone 14 Pro and Pro Max screenshot size needs to be added to deliver. The new screenshot size specifications can be found here: https://help.apple.com/app-store-connect/#/devd274dd925
Command executed

bundle exec fastlane deliver --skip_binary_upload --skip_metadata --force --overwrite_screenshots --api_key_path
Complete output when running fastlane, including the stack trace and command used

[09:52:08]: Successfully loaded '/Users/biggs/jenkins/workspace/Upload App Store Screenshots/StudyJapanese/Deliverfile' 📄
+----------------------------+-------------------------------+
|            Detected Values from './Deliverfile'            |
+----------------------------+-------------------------------+
| metadata_path              | AppStoreConnect/metadata      |
| screenshots_path           | AppStoreConnect/screenshots   |
| app_identifier             | com.serpentisei.studyjapanese |
| username                   |             |
| team_name                  | Serpenti Sei LLC              |
| run_precheck_before_submit | false                         |
+----------------------------+-------------------------------+
[09:52:08]: Creating authorization token for App Store Connect API
+--------------------------------------+----------------------------------+
|                         deliver 2.209.1 Summary                         |
+--------------------------------------+----------------------------------+
| skip_binary_upload                   | true                             |
| skip_metadata                        | true                             |
| force                                | true                             |
| overwrite_screenshots                | true                             |
| api_key_path                         | |
| username                             |                |
| app_identifier                       | com.serpentisei.studyjapanese    |
| platform                             | ios                              |
| edit_live                            | false                            |
| use_live_version                     | false                            |
| metadata_path                        | AppStoreConnect/metadata         |
| screenshots_path                     | AppStoreConnect/screenshots      |
| skip_screenshots                     | false                            |
| skip_app_version_update              | false                            |
| sync_screenshots                     | false                            |
| submit_for_review                    | false                            |
| verify_only                          | false                            |
| reject_if_possible                   | false                            |
| phased_release                       | false                            |
| reset_ratings                        | false                            |
| team_name                            | Serpenti Sei LLC                 |
| run_precheck_before_submit           | false                            |
| precheck_default_rule_level          | warn                             |
| ignore_language_directory_validation | false                            |
| precheck_include_in_app_purchases    | true                             |
+--------------------------------------+----------------------------------+
[09:52:11]: 🚫 Invalid screenshots were detected! Here are the reasons:
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/de-DE/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/en-US/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/es-MX/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/fr-FR/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/nl-NL/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/ru/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hans/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/1_iphone67_1.AppStoreNihongoEntry.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/2_iphone67_2.AppStoreKanjiFlashcard.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/3_iphone67_3.AppStoreWordTriage.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/4_iphone67_4.AppStoreOCR.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/5_iphone67_5.AppStoreViewClipping.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[09:52:11]: 🚫 Error: AppStoreConnect/screenshots/zh-Hant/6_iphone67_6.AppStoreWikipedia.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)%1B[0m)
[!] Canceled uploading screenshots. Please check the error messages above and fix the screenshots.

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
12.5.1

Ruby
3.0.1

Bundler?
true

Git
git version 2.37.0 (Apple Git-136)

Installation Source
~/jenkins/workspace/Fastlane Env/StudyJapanese/vendor/bundle/ruby/3.0.0/bin/fastlane

Host
macOS 12.5.1 (21G83)

Ruby Lib Dir
~/.rbenv/versions/3.0.1/lib

OpenSSL Version
OpenSSL 1.1.1j  16 Feb 2021

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
14.0

Swift Version
5.7

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.209.1
✅ Up-To-Date

trainer
0.9.1
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.5.0

bundler
2.2.15

tsort
0.1.0

uri
0.10.1

pathname
0.1.0

rake
13.0.6

rexml
3.2.5

CFPropertyList
3.0.5

concurrent-ruby
1.1.10

i18n
1.12.0

minitest
5.16.2

tzinfo
2.0.5

zeitwerk
2.6.0

activesupport
<IP_ADDRESS>

public_suffix
4.0.7

addressable
2.8.1

httpclient
2.8.3

json
2.6.2

algoliasearch
1.27.5

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.2.0

aws-partitions
1.629.0

aws-sigv4
1.5.1

jmespath
1.6.1

aws-sdk-core
3.146.0

aws-sdk-kms
1.58.0

aws-sdk-s3
1.114.0

babosa
1.0.4

claide
1.1.0

fuzzy_match
2.0.4

nap
1.1.0

netrc
0.11.0

ffi
1.15.5

ethon
0.15.0

typhoeus
1.4.0

cocoapods-core
1.11.3

cocoapods-deintegrate
1.0.5

cocoapods-downloader
1.6.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.1

cocoapods-trunk
1.6.0

cocoapods-try
1.2.0

colored2
3.1.2

escape
0.0.4

fourflusher
2.3.1

gh_inspector
1.1.3

molinillo
0.8.0

ruby-macho
2.5.1

nanaimo
0.3.0

xcodeproj
1.22.0

cocoapods
1.11.3

colored
1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.4

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.92.4

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.0.0

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.2

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.2.6

jwt
2.5.0

memoist
0.16.2

multi_json
1.15.0

os
1.1.4

signet
0.17.0

googleauth
1.2.0

mini_mime
1.1.2

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

webrick
1.7.0

google-apis-core
0.7.0

google-apis-androidpublisher_v3
0.26.0

google-apis-playcustomapp_v1
0.10.0

google-apis-iamcredentials_v1
0.13.0

google-apis-storage_v1
0.17.0

google-cloud-env
1.6.0

google-cloud-errors
1.3.0

google-cloud-core
1.6.0

google-cloud-storage
1.39.0

mini_magick
4.11.0

naturally
2.2.1

optparse
0.1.1

plist
3.6.0

rubyzip
2.3.2

security
0.1.3

simctl
1.6.8

terminal-notifier
2.0.0

unicode-display_width
1.8.0

terminal-table
1.8.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

generated on: 2022-09-14

Got the same issue for 1290 × 2796. Is there a solution to it?

Looks like Deliver needs to be updated to support the new size. Unfortunately I haven't had time to dive in and try to make a PR myself. Looks like it would involve updating app_screenshot.rb with the new sizes, and finding other places where those sizes are referenced and updating the necessary places with the new sizes.
Also will need to figure out how to handle the fact that there's already a 6.1-inch size in Deliver listed for the iPhone XR, which is a different screen size than what Apple is now calling the 6.1-inch screenshot size (for iPhone 14 Pro)

Same problem here :(

I hacked something together here to upload 6.7 inch screenshots
https://github.com/cherpake/fastlane

Experiencing the same issue with the message:
[21:27:03]: 🚫 Error: ./fastlane/screenshots/sk/iPhone 14 Pro Max-1_searchWithImages_framed.png - Invalid screen size (Actual size is 1290x2796. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)

The link there specifies 1290x2796 as a valid screen size.

fixed in https://github.com/fastlane/fastlane/pull/20777

Is there a chance of this being resolved soon? The fix in #20777 doesn't look like it supports 14 Pro Max, only Pro.

I just tested this, and it does seem to be working for iPhone 14 Pro Max screenshots!
It looks like #20777 will add support for iPhone 14 Pro, so this issue is not completely resolved until that fix is merged as well.


update ReadMe with new skeleton

ReadMe has been modified completely to showcase features
CLI button and link has been updated appropriately to point to our repository

Thanks for updating the ReadMe! LGTM for now, but command syntax should be continued to be updated in the future when we have a better idea of what we are implementing.

The command syntax is lifted from AB3's original documentation. Only filter command is the difference.


Different colors in QR code

Hi,
The demo works fine when QR code is black with a white background. But for example white on a dark green background does not work. Tested on iOS 12.1 in Safari.
Is is possible to support other colors?
Thank you

@TJHoekstra Not sure this is supports out of box or not. Need to check if we can support it. Will keep you posted on this. Thanks!!

There are several online QR code generators can produce QR codes with different colors, so you'll easy to get that if you want a test case.
https://www.qrcodes-generator.com/
https://www.qrcode-generator.ch/?lang=en

@KrasnayaPloshchad Sure. Thanks

Closing this. As for now planning to keep it simple pwa.


Upgrade google libphonenumber to 8.7.0

Coverage remained the same at 94.148% when pulling ac6127555a88422b724333249164b8e15c685449 on upgrade-google-libphonenumber-to-8.7.0 into e62fd5db2f9d9be3fadbb8534d9a173e4b866a1d on master.


User profile page: Provide link to invoice

People lose emails. We can store the PDF and provide it or generate it dynamically.
@lilliputten Please provide a concept for this issue before starting the coding. Thanks!

People lose emails. We can store the PDF and provide it or generate it dynamically.
@lilliputten Please provide a concept for this issue before starting the coding. Thanks!

I've already added these links (to payment info, which is just a template now) and to invoice download in the 'event registration successfully created' page. (But this page is temporary too.)
I can add it to the registration entry on the profile page.
Or, alternatively, we can create dedicated 'view registration' page (if we going to have more data for registrations) and place these links there.

It's possible to add an extra button with a pdf icon to download an invoice there.

This is already good enough.

Added a link for invoice download to the registrations list on the profile page. PR #52
Are we sure that a dedicated page with a registration information isn't necessary?

Are we sure that a dedicated page with a registration information isn't necessary?

No, this is also needed, but less important than other things for now.