Barcode Markers (May Be) Broken

Awesome project!
Hiro markers in my AR.js app (based on the a-frame example) are working fine.
However, I want to use 3x3 barcode markers!
I am following this example: http://jeromeetienne.github.io/slides/artoolkit-aframe/#20
The slideshow has this section:
<a-scene artoolkit='detectionMode: mono_matrix; sourceType: webcam;'>
        <!-- here, put the content of your scene -->
</a-scene>

But changed mono_matrix to mono_and_matrix since mono_matrix does not exist.
Even after that, however, this does not appear to work:
<a-marker type='barcode' value='20' >
        <!-- here put your content -->
</a-marker>

Though the code runs in the browser without error, it is never able to identify the marker. This seems to be the case even when matrixCodeType is in 3x3, 4x4, 3x3_HAMMING63, etc..
Any ideas? It's possible this is related to an underlying bug: https://github.com/artoolkit/jsartoolkit5/issues/34
Can somebody sanity check this for me, please?

Similarly, there are no examples which use the 'barcode' format, which makes this more difficult to learn by example.

Hi, I tried barcode markers. But i guess they are not working now. I used them in a class demonstrations to put a point forward regarding the amazing work and world of Web Reality.
https://github.com/rohit7gupta/rohit7gupta.github.io/tree/master/explore

Currently having the same issue, can't get the barcode markers to work.

ok i will look

everybody who experienced issue with barcode marker is using a-frame, correct ?

yes ! a-frame. Thanks :)

I believe I'm facing a similar issue. Adding the matrixCodeType and detectionMode, but barcode markers aren't being detected at all.

I also face the problem with the barcodes. Something new on this one?

Sorry for the delay, i spent time on this today. And fixed an issue. I wrote an aframe example which handle multiple independant markers, and there is barcode is working there.
See the example here
You change the scene configuration to specific you are looking for matrix marker too and their type e.g.
<a-scene embedded artoolkit='sourceType: webcam; detectionMode: mono_and_matrix; matrixCodeType: 3x3;'>
</a-scene>

You define the marker like this
<a-marker type='barcode' value='5'>
     <a-box></a-box>
</a-marker>

Here is the image of the barcode marker 5 in 3x3 https://github.com/artoolkit/artoolkit5/blob/master/doc/patterns/Matrix code 3x3 (72dpi)/5.png

I can confirm that this works! Thank you very much Jerome!

Thanks :)

Super Dooper Thanks !! 💃

Still not working for me, even when using the exact code from the example linked by @jeromeetienne .
There is also a strange effect where even when the hiro marker is not being used, the hiro marker shows the objects that were meant to be shown from the barcode.
Is it possible that the cause of this is that tracking backend is not being set to aruco?

@vingkan Pleased create a new issue, if the issue is still persists.

@reza21 Hey, I'm also a newbie, but in case you're still looking for barcode (3x3), artoolkit has some pre-generated numbers (0 to 63) here: https://github.com/artoolkit/artoolkit5/tree/master/doc/patterns/Matrix code 3x3 (72dpi). I hope that helps!

I am using artoolkit to look for barcode 37 and I seem to find it (i'm inspecting arToolkitContext.arController.barcodeMarkers[37].inCurrent/.inPrevious and they're true), but the model doesn't show. The model does show when usign hiro.patt, however.
    arToolkitContext = new THREEx.ArToolkitContext({
      cameraParametersUrl: '/assets/cameras/camera_para.dat',
      detectionMode: 'mono_and_matrix',
      matrixCodeType: '3x3',
      debug: true
    });
    ...
    let markerControls1 = new THREEx.ArMarkerControls(arToolkitContext, markerRoot1, {
      type: 'barcode',
      barcodeValue: "37",
    });

Could someone please help?


update error catching for swift-3.1

Same change pattern as from Kitura-Session and others

Codecov Report

Merging #55 into master will increase coverage by 1.6%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #55     +/-   ##
=========================================
+ Coverage   37.68%   39.29%   +1.6%
=========================================
  Files           5        5
  Lines         605      621     +16
=========================================
+ Hits          228      244     +16
  Misses        377      377

Flag
Coverage Δ

#CouchDB
39.29% <100%> (+1.6%)
:arrow_up:

#CouchDBSample
39.29% <100%> (+1.6%)
:arrow_up:

Impacted Files
Coverage Δ

Sources/CouchDB/CouchDBClient.swift
39.33% <100%> (+4.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b055840...3bc6c10. Read the comment docs.


Add a Ko extension

Thanks for putting this together! I'll take some time to play with it this week.
I noticed something about the example that I wanted to get your thoughts on. Ko requires users to write their YAML such that there's a reference to the importpath wherever the built image should be replaced. So the YAML would say image: ko://github.com/foo/bar/cmd/baz (or an arg even, [-foo, ko://github.com/foo/bar/cmd/baz]), and ko searches the YAML for ko://-prefixed valid importpaths and replaces them.
So in your example, ko_build('hello-world-image', 'github.com/foo/bar/cmd/baz') should be ko_build('ko://github.com/foo/bar/cmd/baz', 'github.com/foo/bar/cmd/baz'), or more likely using some Skylark list comprehension so I can just maintain a list of known import paths and their deps for autobuilding goodness. Does it seem like that's something Tilt can support?
It might even be cool to have the signature of ko_build take a map of importpath -> deps, and generate the rest.
Another thing we might be able to optimize a bit more is the repeated calls to ko publish. If there are multiple images to publish, we can probably make them quicker if we batch them up. I recently added remote.MultiWrite to go-containerregistry, which deduplicates shared layer uploads, reuses auth handshakes, and uploads blobs and manifests in parallel, and I'd like to use it to speed up ko resolve (https://github.com/google/ko/issues/236) -- it'd be great to be able to leverage that optimization in this extension too, if that's possible. I'd be willing to support a  ko publish [importpath1] [importpath2] ... mode if that would help here.

@ImJasonH thanks! ya, let me try to break out a few nice ideas from your comment:

re: ko:// - Unforunately, if you do that right now, you get:

Error: Argument 1 (ref): can't parse "ko://github.com/mattmoor/warm-image/cmd/sleeper": invalid reference format

Tilt requires all image references to validate against this reference grammar: https://github.com/docker/distribution/blob/master/reference/reference.go#L4
I'd be open to changing Tilt to use a different reference parser here. is there one that supports the ko format?

re: ko publish multiplexing - this is hard for us to do right now : (. custom_build isn't synchronous - it adds the shell script you give it to a planner, and the planner tries to parallelize things when possible. Let me think on this a bit...

re: ko publish vs ko publish --local - right now this extension uses ko publish --local, and then has Tilt push the image. Do you think it would be significantly faster to have Ko publish the image to the registry (because we'd get to skip the local docker image store)? I might try taking a crack at that.

as an aside, I lol'd at some of the docs around getting Ko to work with Kind/Minikube and multi-level repository names...we ran into the same issues...it might be helpful to join forces on standard decision trees for this; I've been trying to push https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry but it's been slow going...

re: a ko_yaml function - ya, i like that, let me try in a subsequent PR


Broken since v3.7.1

Hi @tcort,
Thanks for your effort on this awesome tool, I just found that markdown-link-check is now broken, in my cases, it just hangs without any output, even with -v & -p parameter, for 10 mins, 20 mins and longer, I don't know how long it'll hang but seems forever. Builds of nodejs/docker-node now also failed because there is no any response from it, and it doesn't exit.
Looks like v3.6.2 still works very well, any idea?
Many thanks again!

I am not a core contributor but I was trying to use this module today and stumble into the same problem.
After investigating a bit, git bisect shows that commit https://github.com/tcort/markdown-link-check/commit/b00a9b1048c55b1566c93a4afd09d0cd26a4feeb is the one causing trouble.
Especially, at line #L68 where the stream is created into fs.access's callback. I am not exactly 100% sure what is happening under the hood but my guess is that we shouldn't rely on fs.access to check if the file exist before trying to create the stream.
As stated in node's documentation (https://nodejs.org/dist/latest-v8.x/docs/api/fs.html#fs_fs_access_path_mode_callback), it's considered as an anti-pattern as the file can be accessed during that time creating a race condition.
@gaurav-nelson What do you think about it ? Do you mind if we get rid of fs.access and add an error handler on the read stream in order to gracefully handle the situation where the file does not exist ?

Thanks @anchnk You are right, this should be fixed. I rushed in with a patch because of a failing script in our CI. Thanks for #61 and #62
@tcort It would be great if you can check and apply these updates.

Thanks everyone! The changes were published in v3.7.2.

Thank you all.


fix a STOPPED to ACTIVE issue by start method

We use httpasyncclient as our core async RPC component, but we found a recovering issue a couple days ago.
it is the async client will be stoped because of I/O reactor shutdown when a service encounter a OOM problem, a few seconds later and after a FGC process, the service has been recovered, but the async client cannot be recovered. so the client cannot accept the request unless the service need to reboot.
the code is:
@Override
public void run() {
    try {
        final IOEventDispatch ioEventDispatch = new InternalIODispatch(handler);
        connmgr.execute(ioEventDispatch);
     } catch (final Exception ex) {
        log.error("I/O reactor terminated abnormally", ex);
     } finally {
        status.set(Status.STOPPED);
     }
 }

or by close() method.
so there is no way to set status from STOPPED to ACTIVE even by start().

@383124397 Why do you want to restart a shut down HttpAsyncClient instance instead of creating a new one?

@ok2c I mean there is no way to recover a stopped client if it was shut by a accident exception like seconds
OOM unless the user renew one. but as a user I don't wanna renew an already exists, so I need to add this logic for start method : )

@383124397 I have never ever seen a complex system capable of recovering from OOM condition and I have seen a few. I personally would not attempt to recover a shut down client and would simply create a new one.

@ok2c so the asynchttpclient is a one-off component for users, I hope it could be resiliently, high availability...  and you know it could be caused memory leak  if we create new client outside frequently.

@383124397 You own application causes OOM condition and you are worrying about resiliently and high availability of HttpAsyncClient?

@ok2c I mean it's is good enough if the HttpAsyncClient can support be recovered from an exception scenario by invoke start method.

@383124397 OOM in Java is considered a fatal error. If HttpAsycClient was unable to allocate some of its internal structures it may no longer be in a consistent state. This is the reason why it shuts down upon encountering OOM in the first place. It makes no sense to restart a shut down instance. It is much safer to create a new one.

@383124397 Would you mind closing this PR?

@ok2c OK


Adds an AsanaReader for loading tasks from a workspace

Hi @daveey, thanks for the reader. The only comment I have is. We can make the asana_token optional and get it from environment variable, if it is not provided. It is up to you.

Awesome! Would you be able to port this over to https://github.com/emptycrown/llama-hub? We're porting over all the readers to a dedicated library over there.
Incidentally, we're drawing prizes for all new creators of loaders before 2/24 so this would be a great fit.

@daveey thanks for this PR!
If you have questions on migrating to llamahub, no problem. ping us and we're more than happy to help out

I added a PR to llamahub, but was unable to test it:

from gpt_index import download_loader
AsanaReader = download_loader('AsanaReader')
Traceback (most recent call last):
File "", line 1, in
File "/Users/daveey/code/gpt_index/gpt_index/readers/download.py", line 56, in download_loader
raise ValueError("Loader class name not found in library")
ValueError: Loader class name not found in library

I assume this is because the PR has to first be merged?

Yeah, has to be merged first. Typically it's enough to just test the class itself in a notebook. Taking a look now, thanks!

Hi @daveey, thanks for the reader. The only comment I have is. We can make the asana_token optional and get it from environment variable, if it is not provided. It is up to you.

I can do that if you feel strongly, but personally I prefer that users explicitly specify auth tokens rather than relying on ENV.

Closing in favor of https://github.com/emptycrown/llama-hub/pull/38

I added a PR to llamahub, but was unable to test it:

from gpt_index import download_loader

AsanaReader = download_loader('AsanaReader')

Traceback (most recent call last):
File "", line 1, in
File "/Users/daveey/code/gpt_index/gpt_index/readers/download.py", line 56, in download_loader
raise ValueError("Loader class name not found in library")

ValueError: Loader class name not found in library
I assume this is because the PR has to first be merged?

You can actually point to your fork and temporarily test before merging.


Add support for compile-time variable allocation

Add support for allocating variables at compile-time and binding them
at runtime.
This renames bytecode to Code and the compile function to Compile so
that both can be exported. In turn, an additional varidiac argument has
been added to Compile to pass in the names of variables to be bound at
runtime. This requires adding the same variadic argument to (*Code).Run
to accept the variables' values.
Variable binding is mostly hacked in by inserting a number of store
opcodes at the beginning of the bytecode and ensuring that the values
provided at runtime are pushed after the main value. As such, Code now
has a vars field to identify every variable it requires to run.
Rudimentary support for this has been added to the cli package.

Adding DNM just because I'm still playing with this. Needs CLI tests, for example.

Great, thank you.

Thank you.


Report proper height of text being edited

Hey @JohnKuan, just FYI on this update, which was needed as a byproduct of the fix for https://github.com/stevengharris/MarkupEditor/issues/106. By putting in the padding-block to the editor CSS, the height of the text was being reported as the full screen height. The app I am using MarkupEditor in uses the height to auto-size the MarkupWKWebView, so it was a little broken by the change 😜. I tried to ensure the fix here did not regress the other, but you might want to double-check.

Hi @stevengharris, thanks for the heads up. Though I have not encounter this issue visually, I will check it as well.


Ci do not fail fast

Do not fail fast in CI runs. We'd like to know if it is just  a flaw in the testing repos or if there is something wrong with main.

I had this hanging in Draft for a while as the Rolling build was still failing with this due to other reasons. However, I think it is worth merging this, as this will help debugging why the other builds as for example the semi-binary galactic build fail.

I actually remembered why I had this in WIP: I wanted to migrate the workflows to a github-compatible format.


Fix/deletion

Fixes https://github.com/berops/claudie/issues/606
Why changes in terraformer server ?
If you would have the following config:
kubernetes:
  clusters:
    - name: matus-t1
      version: v1.24.0
      network: <IP_ADDRESS>/24
      pools:
        control:
          - hetzner-control
        compute:
          - gcp-compute
          - hetzner-compute

and then remove the gcp-compute compute plane terraformer would fail because when it would enter the building stage it wouldn't find the .tf files for the  gcp provider and thus not be able to delete it.
The changes now generate the .tf files for the provider both from the current and desired state.
Related .tf files have been moved into its own directory e.g. (gcp, aws ....)
Why changes in the kuber?
The current api endpoint change playbook: https://github.com/berops/claudie/blob/master/services/ansibler/server/ansible-playbooks/apiEndpointChange.yml
Corretly changes the endpoint, however 1 "config" was missed. Kubeadm uses the kubectl get cm cluster-info -oyaml -n kube-public and this was left unchanged and as a result wrong endpoints were used for joining new nodes.
The new kuber handler updates the config in the kube-public namespace if a change in kubeconfig is detected.
ref: https://kubernetes.io/docs/reference/setup-tools/kubeadm/implementation-details/#shared-token-discovery
Why new ansibler endpoint?
When we remove a control plane and add a new one at the same time, if there was an endpoint in the removed control plane we need to move it to the control plane.
Why changes in the Builder?
The original tmpConfig https://github.com/berops/claudie/blob/7b305222b3ac22480f526a226bcd3fc704ea2d73/services/builder/configProcessor.go#L86-L111
Was adjusted, basically here is the current flow of building a cluster.

Find the dirrefence between the current and desired state. If we're adding and deleting or adding and addingLb with API we then need to first run a tmp config called IntermediateRepresentation. This config should be put in the workflow without any loadbalancers, this should only prepare the addition of nodes if any.

If there was detected a control plane deletion in which and api endpoint was it will be moved to the new one.

Now we can delete the nodes missing in the desired state and everything should work

Next the workflow for the desired state will run including the Lbs if any.

As the last step delete the Lbs or the cluster missing from the desired state.

To test this a new test-set4 was created (locally tested and works without isssues)
Why the changes in kube-eleven?
The master taint is deprecated and the control-plane taint should be used instead.
ref: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint
I've also updated the kubeone version to the latest 1.6.2 I had some troubles with the current version which were resolved in the new one.

With https://github.com/berops/claudie/pull/728/commits/22d224263b49b3a67b1e171b4fa691cdb60874c0 the current state and desired state of the manifest is updated even if the workflow fails. This is done as otherwise if it would fail mid processing without saving changes it would fail on deletion as we couldn't generate the providers for the already build infra.
this also closes issue https://github.com/berops/claudie/issues/588

this also closes issue https://github.com/berops/claudie/issues/588

Are we sure, the issue can be closed, i.e. what if the builder deletes 2 out of 3 nodes successfully? Will the subsequent run delete just the third one?

Are we sure, the issue can be closed, i.e. what if the builder deletes 2 out of 3 nodes successfully?

Yes, you are right, I've cleared the link to that issues

https://github.com/berops/claudie/pull/728/commits/fc7e009c527956c4ea3b15ab054f753c060c0dbc fixes https://github.com/berops/claudie/issues/588
Tested with a simple config
kubernetes:
  clusters:
    - name: matus-t1
      version: v1.24.0
      network: <IP_ADDRESS>/24
      pools:
        control:
          - gcp-control
          - hetzner-control
        compute:
          - hetzner-compute
          - gcp-compute

Where I would delete control node and worker node, kill Builder service and let the deletion repeat,


Added fix when executor is empty on bank transaction

Current coverage is 95.38% (diff: 100%)

Merging #252 into master will not change coverage

@@             master       #252   diff @@
==========================================
  Files            54         54
  Lines          1667       1667
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1590       1590
  Misses           77         77
  Partials          0          0

Powered by Codecov. Last update f096a17...42b3e93


Ci/explicit workflow permissions

This sets explicit minimal permissions for all workflows

merging diregarding the E2E check which has failed due to a non-cleaned up configuriation


Add StoryTab tool

Add StoryTab CLI tool.

Is this tool relevant to develop or test React hooks?

Having a second look at Tools section and not sure really, feel free to decide to merge or close PR.
Thanks for checking it.


Add Member Variable Highlighting

In the example below, the bar after foo. would be highlighted as a Function
struct Foo {
    int bar;
};
Foo foo;
foo.bar = 1;

Interesting! I'm thinking perhaps member variables should belong to a separate highlight group, and not 'Function'? Also, it would be pretty neat to have this as a separate flag, something like 'cpp:member_variable_highlight'. What do you think?

@octol
Totally agree. There is still in use m_ prefix (or _ prefix/suffix) to mark member/function parameter. I would love to see any syntax that supports this.

@octol Do you have a suggestion for the member variable color?
@dawikur m_ and _ prefixes are purely a style thing, and I don't think they would make for good highlighting candidates.

@zachwhaley
Yes, agree. But one can use this to create in-house highlight which.

@octol Looking at the vim syntax docs, it would seem like Function (aka Identifier) would be the appropriate highlight color for member variables.
If you'd still like it to be something else, I don't mind changing it :)

Sorry for the delay!


adding mcl & mmdc

MCL is the mother school of MMDC
link for MMDC https://www.mmdc.mcl.edu.ph/
link for MCL https://mcl.edu.ph/

@eliakimset Please provide us with a proof, which shows that the school recognizes the domains mcl.mcl.ph and mmdc.mcl.ph  that you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

kindly check your email, i sent the attachment via email, since it contains confidential informations.

@eliakimset Would you please send the attachment to<EMAIL_ADDRESS>mentioning the URL of this request (https://github.com/JetBrains/swot/pull/22077)? I did not receive any email message from you.

I already sent an email.

@eliakimset I corrected your pull request to have it reflecting the desired changes.
Pull request merged. Please start requesting the licenses in about an hour, to let the changes to propagate through our system. Thank you.

Good day I am still not able to register with my given email address. I
would like to raise this issue. Thank you. Regards.
On Fri, Jul 26, 2024 at 8:20 PM Philip Torchinsky @.***>
wrote:

@eliakimset https://github.com/eliakimset I corrected your pull request
to have it reflecting the desired changes.
Pull request merged. Please start requesting the licenses in about an
hour, to let the changes to propagate through our system. Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/22077#issuecomment-2252645587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BERE5JS4WWGXKTPMMAZX4Z3ZOI5HHAVCNFSM6AAAAABLM3SHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGY2DKNJYG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Feature/parasha

Create a new feature
In my feature, the parshas of the week are displayed every Saturday on the board itself.
Needs further treatment:

Currently only manages to display in the current month and not dynamically (I would love to understand how to improve)
As part of the feature I have a link to a separate link (I set it to open a new pane). Is it problematic?

Nice work!
Please fix flake 8 :)

Codecov Report

Merging #260 (1d50cb1) into develop (ab1d671) will decrease coverage by 0.05%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           develop     #260      +/-   ##
===========================================
- Coverage    98.05%   98.00%   -0.06%
===========================================
  Files           73       74       +1
  Lines         3194     3214      +20
===========================================
+ Hits          3132     3150      +18
- Misses          62       64       +2

Impacted Files
Coverage Δ

app/main.py
92.50% <ø> (ø)

app/routers/calendar_grid.py
100.00% <ø> (ø)

app/internal/weekly_parasha.py
80.00% <80.00%> (ø)

app/database/models.py
96.93% <100.00%> (+0.11%)
:arrow_up:

app/internal/json_data_loader.py
100.00% <100.00%> (ø)

app/routers/calendar.py
100.00% <100.00%> (ø)

app/routers/dayview.py
97.52% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1d671...1d50cb1. Read the comment docs.


Create private static final values for empty TYPE and KEY

Moved empty Strings to private static final variables

@digitalbuddha Yeah I got the project open now and just fixing things, expect some more for today 😄

I plan to cut 2.0 early next week. Lmk if any name/api change are needed
before we go live.
On Feb 9, 2017 10:32 AM, "Pavlos-Petros Tournaris"<EMAIL_ADDRESS>wrote:

@digitalbuddha https://github.com/digitalbuddha Yeah I got the project
open now and just fixing things, expect some more for today 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NYTimes/Store/pull/124#issuecomment-278676521, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEUX3K2dXEwu4-oJ-gV25HDONj4LfunOks5razGBgaJpZM4L8Q_d
.

@digitalbuddha Yeah will be on time till then! No worries!

I don't think we need the other static strings. Especially if they are the same.

@digitalbuddha I did in case an empty type and empty key have different definitions in the future!

Thats just an implementation detail and does not make the code more readable or maintainable. In that case the shorter version is better.
Especially now that you eliminated the unnecessary object creation by making a single instance of the empty barcode.

@PaulWoitaschek Ok great then!


Update Creator UI

Implement last design updates -> widths, paddings, spacings, font, etc...
Remove stepper and add loading bar for last step

PR got merged and changes are on develop branch


Support Netbox 3.1.x

When I try to upgrade Netbox From 3.0.x to 3.1.x, i get error message:
django.core.exceptions.ImproperlyConfigured: Plugin netbox_ddns requires NetBox maximum version 3.0.999.
I think that version v1.2.0 will be great work with Netbox 3.1.x

Will check compatibility and upgrade, thanks for notifying.

Is there anything preventing a version bump in the relevant __init__.py?
I'm not sure how I feel about maximum versions, I've spent a few hours troubleshooting this issue to find that actually, my version of Netbox is fine, it's the plugin that's preventing netbox from starting due to an arbitary check which doesn't really inform of us of anything but a developer has simply put a limit on versionings in a file and now that versioning doesn't match the newly updated Netbox instance.

I tested netbox-ddns 1.2.0 with netbox 3.1.2 and did not find any problems.
Temp hack for reproducing this.
sed -i 's/3.0.999/3.1.999/' /opt/netbox-3.1.2/venv/lib64/python3.9/site-packages/netbox_ddns/__init__.py

Version is bumped.


SW-2935 Support raw search fields

To allow clients to more easily parse specific values in search results, add
support for "raw" variants of fields whose values can vary based on locale.
Specify that you want to use raw values rather than localized ones by
appending the string (raw) to the name of a search field. You can use raw
fields both for input (search criteria) and for output (list of fields to return).
These are treated as separate search fields with separate names. It is fully
supported to include both the raw and localized versions of a field in the same
search request, and indeed, that's expected to be a common usage pattern whenever
a client needs to both display a value to a user and use it internally for
business logic.

Current dependencies on/for this PR:

main

PR #964   👈

This comment was auto-generated by Graphite.

I didn't see any places in the frontend code where it was using the values that are localizable now for anything but display. Obviously it's possible I missed some.

oops yes my bad, i was still thinking about client side sorting.. we aren't doing that anymore in the tables for most cases.


Make phrasecount work with beta-1 release

I checked out your branch and ran mvn package and the following exception was thrown a few times in phrasecount.PhraseCounterTest:
2015-06-10 15:12:45,166 [worker.WorkTask] WARN : Failed to execute observer PhraseCounter
java.lang.NullPointerException
	at phrasecount.PhraseCounter.process(PhraseCounter.java:47)
	at io.fluo.core.worker.WorkTask.run(WorkTask.java:68)
	at io.fluo.core.worker.NotificationProcessor$2.run(NotificationProcessor.java:130)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

The ran the test again and the exceptions were thrown again so it's repeatable.

+1


duckstation: unstable-2023-04-14 -> unstable-2023-09-30

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 258661 run on x86_64-linux 1

1 package built:

duckstation

Thank you this works great
duckstation can use libbacktrace now if that's useful


Rubocop 1.43

Upgrades RuboCop to 1.43.0 https://github.com/rubocop/rubocop/releases/tag/v1.43.0
NOTE: rubocop-graphql has been upgraded but won't run unless required in .rubocop.yml.

Lots of bug fixes and functional improvements
Disables that questionable Style/YodaExpression by default.

Updates rubocop todo file.

Short and simple. Makes me feel as if I'm accomplishing something.
I will probably merge it soon.


DEPRECATION WARNING: Including LoggerSilence is deprecated and will be removed in Rails 6.1. Please use ActiveSupport::LoggerSilence instead

Rails 6.1 is deprecating ::LoggerSilence call
Culprit seems to be in lib/rails_stdout_logging/rails.rb:3
Fixed it by updating code to:
include ActiveSupport::LoggerSilence if defined?(ActiveSupport::LoggerSilence)

https://stackoverflow.com/questions/59744549/how-do-you-replace-loggersilence-with-activesupportloggersilence
remove gem rails_12_factor


Fix vet warnings

Merging as it's just vet fixes.
/cc @dgnorton @pauldix
You can re-enable your git commit hooks now.

Actually, fixed a bug that was using the global log package instead of the local logger.


Revert "Add method to retrieve all members from projects (including inherited)"

Reverts m4tthumphrey/php-gitlab-api#409

@m1guelpf , this is weird.. my PR #409  was merged.. then another collaborator develops the same functions that were already in master a month after #418 , and then my original additions are reverted #419
Please be clear on the policy of collaboration in this repo, because now my custom developments rely on the methods  Projects->membersAll() which were included and then excluded from master without any notification.
And now I'm not really motivated to collaborate with this project anymore :disappointed:
At least a ping to my user when my PR was reverted would have been nice to receive.

you asked to me add test to my methods, I did so, and then you replaced my code, with other that have no tests at all.
I'm not angry about my code was taken out, but the time I dedicated to do this, following you instructions, and when it was merged, I developed a lot of code based on this.. now all that effort is useless, and without having any notification.. just found out today when I was visiting the repo

Hye @sluc23. I'm really sorry about this. I was on exam time and didn't take all the time I should have on reviewing the PRs and fixing the issue.


[BUG] resampling upper/first subplot when zooming in on lower, non-shared x-axes subplots

Minimal breaking example:
import numpy as np
from plotly.subplots import make_subplots
from plotly_resampler import FigureResampler

arr = np.sin(np.arange(1_000_000) / 1000)
fr = FigureResampler(make_subplots(rows=3, shared_xaxes=False, vertical_spacing=0.05))
fr.add_trace({"name": "raw"}, hf_y=arr)
fr.add_trace({"name": "raw"}, hf_y=arr[::1500], row=2, col=1)
fr.add_trace({"name": "raw"}, hf_y=arr[::1500], row=3, col=1)
fr.show_dash(mode="inline", port=8050)

Zoom on middle lower plot

And you will get this:

i.e., the upper plot is resampled to the same view as the lower one! 😮
The fix
change:
https://github.com/predict-idlab/plotly-resampler/blob/b3f06fe32f6742dca63deb483d2568c2a668e0e9/plotly_resampler/figure_resampler/figure_resampler_interface.py#L402
to:
                    y_axis = "y"

TODO

failing test

fix code and make test work

Closing this as fixed by #138


Suspend/Resume processing

I'm using Google Colab, which will kick me off after a period of time and, often, the integration with Google Drive just breaks out of nowhere.  I'm currently running a larger-format v2v and it's taking hours (for just 60 frames).  Which is fine, but I'm a bit paranoid about losing progress if I get kicked off of free Colab and/or if something breaks.
It would be wonderful to be able to manually save progress mid-generation (or automatically save every X frames) and be able to resume later.  I suspect something like this would be nice for other setups/use cases as well.
Thanks for making this.  It's awesome.

Please check out the last update. There is an option now for saving frames into a folder alongside the video. I hope it will help you with your problem.

Awesome, thank you!


User permission check has failed

Issue Description:
After cloning the example code and running it successfully, I am encountering an issue on iOS versions greater than 17. Everything works fine on lower iOS versions (iOS 16 or 15) and on all Android devices. However, on iOS 17, the app is not recognizing the microphone.
Environment:
React Native version: 0.72.4
react-native-permissions version: 4.0.4
iOS version where the issue occurs: 17 and above
Steps to Reproduce:
Clone the example code.
Run the application on iOS 17 or above.
Observe the issue with microphone recognition.
Additional Information:
I have granted microphone and speech recognition permissions.
The issue persists even after providing the necessary permissions.
Package.json
{
"name": "example",
"version": "0.0.1",
"private": true,
"scripts": {
"android": "react-native run-android",
"ios": "react-native run-ios",
"lint": "eslint .",
"start": "react-native start",
"test": "jest"
},
"dependencies": {
"react": "18.2.0",
"react-native": "0.72.4",
"react-native-gesture-handler": "^2.12.1",
"react-native-localize": "^3.0.2",
"react-native-paper": "^5.10.4",
"react-native-permissions": "^4.0.4",
"react-native-reanimated": "^3.5.1",
"react-native-safe-area-context": "^4.7.2",
"react-native-toast-message": "^2.1.6",
"react-native-voicebox-speech-rec": "^1.0.4",
"react-native-volume-manager": "^1.10.0",
"react-native-webview": "^13.6.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@babel/preset-env": "^7.20.0",
"@babel/runtime": "^7.20.0",
"@react-native/eslint-config": "^0.72.2",
"@react-native/metro-config": "^0.72.11",
"@tsconfig/react-native": "^3.0.0",
"@types/react": "^18.0.24",
"@types/react-test-renderer": "^18.0.0",
"babel-jest": "^29.2.1",
"eslint": "^8.19.0",
"jest": "^29.2.1",
"metro-react-native-babel-preset": "0.76.8",
"prettier": "^2.4.1",
"react-test-renderer": "18.2.0",
"typescript": "4.8.4"
},
"engines": {
"node": ">=16"
}
}
Info.plist:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
  <!-- ... existing Info.plist content -->
  <key>NSMicrophoneUsageDescription</key>
  <string>Transcribe user's voice command to text</string>
  <key>NSSpeechRecognitionUsageDescription</key>
  <string>Transcribe user's voice command to text</string>
</dict>
</plist>

Please resolve this issue as soon as possible because this is the only blocker to live my app Please.

I think the problem is with webview or web speech api it doesn't seem to work in ios 17 or later versions

yes exactly, i am facing the same issue my whole day sucks.

did this dependency work for latest iOS and Android Versions?

I think the problem is with webview or web speech api it doesn't seem to work in ios 17 or later versions

Worki

did this dependency work for latest iOS and Android Versions?

I think the problem is with webview or web speech api it doesn't seem to work in ios 17 or later versions

Working for android but causing problem in new ios version

I have confirmed that there is no mediaDevice attribute related to webRTC inside the browser when calling the webView src via HTML.
However, when calling the webView src via uri, it is retrieved correctly.
I have saved the speechRecScript in HTML format inside the static folder and changed it to be called via a local uri.
this is SpeechRecView.js in node_modules > react-native-voicebox-speech-rec > dist> component
import React, { useCallback, useContext } from 'react';
import { View } from 'react-native';
import { WebView } from 'react-native-webview';
import { SpeechRecContext } from '../context/SpeechRecProvider';
import { speechRecScript } from '../static/speechRecScript';
export const SpeechRecView = React.memo(() => {
    const { webViewRef, notifyListeners } = useContext(SpeechRecContext);
    const webViewSrc = Platform.select({
        ios: require("../static/speechRecScript.html"),
        android: {html: speechRecScript}
    })

    const onMessageReceived = useCallback((event) => {
        const message = JSON.parse(event.nativeEvent.data);
        notifyListeners({
            type: message.type,
            data: message.data,
        });
    }, [notifyListeners]);
    return (<View style={{ width: 0, height: 0, overflow: 'hidden' }}>
      <WebView ref={webViewRef} originWhitelist={['*']} source={webViewSrc} onMessage={onMessageReceived} onLoad={() => {
            console.log('🫵 🫵  Speech Rec Scrsssipt View Loaded 🫵 🫵 ');
        }}
        webviewDebuggingEnabled
        />
    </View>);
});

you can modify the source as shown in the following patch file.
react-native-voicebox-speech-rec+1.0.4.patch

@lym3074 It is worked but this is not good practice for IOS user because it ask for permission to allowed microphone every time, When app restarted.


Checksums

Thank you for sharing this data.
Maybe you can post a file containing checksums after running the script? It could be as simple as "find . -type f -exec md5sum"

I apologize for not replying, I haven't received notifications. I'll look into this. Actually, the filenames for the final questions are checksums so I can release those. That said, if you end up getting the same number of question/answer pairs in the test sets it's unlikely that they are different.

I'm going on vacation today, but I'll attend to this first thing when I'm back.

Hi,
I've now released the checksums of the test sets. Let me know of any problems.


Update to release version of JUnit 5

thanks for the update!

On Oct 20, 2017 00:12, "Yu Yang"<EMAIL_ADDRESS>wrote:

thanks for the update!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pinterest/doctorkafka/pull/8#issuecomment-338039511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELBvxynwUmedhzG1zS29DeBnD1U3xVtks5st7svgaJpZM4P6Rjp
.


How many categories do you have on the bdd dataset? And where is the ground truth of the bdd test set?

The labels of the BDD100K testing set are not released. I just use the training and validation set since the labels are available. More details can be seen in our arxiv paper which will be published soon.


Integration test for PartialDateTime-based extraction

A new integration test that tests the interface to netcdftime when performing an extract from an Iris cube using a PartialDateTime.
Specifically, this tests a previously uncaught failure mode originally reported in https://github.com/SciTools/conda-recipes-scitools/pull/229, and addresses one of the review actions on that PR.

I think this is useful.  however, other tests are failing, which I do not understand
is it clearer to someone else what has happened to
ERROR: test_time_as_number (iris.tests.unit.coords.test_Coord.Test_cell)
ERROR: test_extended_proxy_data (iris.tests.test_merge.TestDataMerge)

closed by #2539


[registry] [poly_storage] copying storage without .prepare() causes segfault

Copying without other.prepare<Type>() causes a segfault in other.storage(info).
Easily replicated by deleting the 2 .prepare() statements in https://github.com/skypjack/entt/blob/master/test/entt/entity/poly_storage.cpp#L121 .

Oh, sorry, forgot to update the issue.
I pushed the example to experimental. Does it work for you?

Oh, sorry, forgot to update the issue.
I pushed the example to experimental. Does it work for you?

Looks good. Every time I learn something new about the custom storage. Still don't fully get it, though...
Anyway, didn't have full registry copy in the last two iterations, but will get back to custom storage when i get to the prediction/rollback logic. Hope i know what I'm doing when i get back to it. :D

Looks good. Every time I learn something new about the custom storage. Still don't fully get it, though...
Anyway, didn't have full registry copy in the last two iterations, but will get back to custom storage when i get to the prediction/rollback logic. Hope i know what I'm doing when i get back to it. :D


 Following ignore documentation:

Note that the directive must be on the first line after the shebang with versions before 0.4.6. As of 0.4.6 comments and whitespace are allowed before filewide directives.

Thank you @ttres!


IntelliSense for extensions.supportUntrustedWorkspaces doesn't show disabled extensions

Testing #122230

open workspace in restricted mode
configure the extensions.supportUntrustedWorkspaces-setting
:bug: IntelliSense suggestions extensions that don't require trust, like references view

Likely the same issue - extension that should be in there don't show up, like codespaces

The intellisense should include all extensions that have a main property independent whether they support untrusted workspaces or not so that the user has full control to override the value. So that fact that the references view extension is included in the list of suggestions is by design.
Intellisense is currently provided through a built-in extension and as far as I can tell, extensions only have access to the list of extensions that are enabled. This is a problem since as you called out, these are the extensions that one might to add to the settings. I will see if we can either expand the API, or provide intellisense from core where we should have access to the full list of installed extensions.

This has been fixed with b7b095cdf65c3097f9418c01ae0aac923ffa67dc

Verification steps:

Open a workspace in restricted mode
Open the settings.json file, and configure the extensions.supportUntrustedWorkspaces-setting
Invoke intellisense and you should see extensions that are currently disabled


Remove need for a .tmp folder

Maybe refactor the code to avoid the need of a .tmp folder (maybe is something jekyll does?)

Im not sure about this file

I really have no idea why the .tmp folder exists as far as i can tell there is a copy task that first moves the entire src folder into .tmp/src then another task is copying those tmp files into the final folder then another task reads some files from the tmp folder and uses them as injection points for the gulp-inject task.
I think this all could be done on a single gulp task without the need to create temporary folders.
Also another bad side effect with all of this copying files around is that in the end we get the bower_components folder onto the deliverable dist folder.
Another not so great side effect is that if we want to add another layout on our templates then we must manually go to the inject.js gulp task to tell it to also inject the js there.
So yeah, its complicated 😁
But i leave the issue so its food for thought for you to think a way to improve this workflow of the temporary folders stravaganza

I think i have an idea of how to remove the tmp folder, the thing with the tmp folder is to copy the generated js and css to then be injected onto the final files right?
So right now you have two tasks generation and injection, i think both tasks could be made on a single step
Pseudocode here:
gulp.task('sass', done => {

  let sass = gulp.src .... // all of the gulp to get the compiled css but without writing it

  gulp.src(//the html files)
   .pipe(inject(gulp.src(sass), {ignorePath: '.tmp'})) // you see what i did there??

  .pipe(gulp.dest(distFolder)
})

Something like that SHOULD work and at the same time would remove the need for a tmp folder


Surface bats test results in go and pass down env vars

Use bats junit report to generate go subtests
Generate+pass down test env vars to bats
Only wire though dagger logs when --debug is set.
Fix missing jq package in test images

~This is built on top of #48, keeping in draft until that's merged.~

Here is what a failure looks like (apparently I didn't test the last PR against a package that we can actually check the commit sha for, which requires jq in the test...)
go test -v . -run TestPackages/jammy/moby-runc
=== RUN   TestPackages
=== RUN   TestPackages/jammy
=== PAUSE TestPackages/jammy
=== CONT  TestPackages/jammy
=== RUN   TestPackages/jammy/moby-runc
=== PAUSE TestPackages/jammy/moby-runc
=== CONT  TestPackages/jammy/moby-runc
=== RUN   TestPackages/jammy/moby-runc/test_docker_run_hello_world
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/extra_docker_binaries_exists
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/test_containerd_run_hello_world
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/test_buildx_build
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/validate_engine_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_engine_commit
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_cli_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_cli_commit
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_containerd_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_containerd_commit
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_runc_commit
    package_test.go:157:
        (in test file /opt/moby/test.sh, line 88)
          `v="$(echo "${_VERSION_DETAILS}" | jq -r '.Server.Components[] | select(.Name=="runc") | .Details.GitCommit')"' failed with status 127
        /tmp/bats-run-1051/bats.2046.src: line 88: jq: command not found
=== RUN   TestPackages/jammy/moby-runc/validate_runc_version
    package_test.go:157:
        (in test file /opt/moby/test.sh, line 96)
          `v="$(echo "${_VERSION_DETAILS}" | jq -r '.Server.Components[] | select(.Name=="runc") | .Version')"' failed with status 127
        /tmp/bats-run-1051/bats.2094.src: line 96: jq: command not found
=== RUN   TestPackages/jammy/moby-runc/validate_runc_package_version
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/validate_engine_package_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_cli_package_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_containerd_package_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_buildx_package_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/validate_compose_package_version
    package_test.go:161:
=== RUN   TestPackages/jammy/moby-runc/compose_plugin_is_installed
    package_test.go:164:
=== RUN   TestPackages/jammy/moby-runc/buildx_plugin_is_installed
    package_test.go:164:
--- FAIL: TestPackages (0.95s)
    --- FAIL: TestPackages/jammy (0.00s)
        --- FAIL: TestPackages/jammy/moby-runc (172.45s)
            --- PASS: TestPackages/jammy/moby-runc/test_docker_run_hello_world (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/extra_docker_binaries_exists (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/test_containerd_run_hello_world (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/test_buildx_build (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_engine_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_engine_commit (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_cli_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_cli_commit (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_containerd_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_containerd_commit (0.00s)
            --- FAIL: TestPackages/jammy/moby-runc/validate_runc_commit (0.00s)
            --- FAIL: TestPackages/jammy/moby-runc/validate_runc_version (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/validate_runc_package_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_engine_package_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_cli_package_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_containerd_package_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_buildx_package_version (0.00s)
            --- SKIP: TestPackages/jammy/moby-runc/validate_compose_package_version (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/compose_plugin_is_installed (0.00s)
            --- PASS: TestPackages/jammy/moby-runc/buildx_plugin_is_installed (0.00s)
FAIL
FAIL	github.com/Azure/moby-packaging	173.404s
FAIL

It may be worth exporting the .xml (as you had before) so that it can be published as an artifact somewhere.

Indeed, we can actually wrap the go test call with something that can parse go's test2json format into junit again so it includes the whole thing namespaced by package/distro/etc.


[fix][broker][branch-2.10] Fast fix infinite HTTP call getSubscriptions caused by wrong topicName

Motivation & Modifications
Cherry-pick https://github.com/apache/pulsar/pull/21997
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: x

@poorbarcode sorry, fixed the headers in branch-2.10 since that was broken. didn't notice that you had already done that in this PR.


feat: upgrade to<EMAIL_ADDRESS>

Description

✨  feat: update to Spectrum Tokens 6.0.0-beta.28, fix broken components
✨  feat: implement t-shirt sizing for Link, closes #1066
✨  feat: implement t-shirt sizing for Divider, closes #972
✨  feat: implement t-shirt sizing for Status Light, closes #686
✨  feat: implement t-shirt sizing for Field Label, closes #943
✨  feat: implement t-shirt sizing for ProgressBar, update notice classes, closes #955
How to work with this, it's broken?
Use FORCE=true gulp dev to develop with broken components.
To-do list

[x] Fix all components that fail to build

[x] Button
[x] Textfield
[x] Tags
[x] Menu
[x] Picker
[x] Popover
[x] QuickAction
[x] Checkbox
[x] Radio
[x] Switch
[x] SearchWithin
[x] Search
[x] ProgressBar
[x] AssetList
[x] InputGroup
[x] Stepper
[x] FieldLabel
[x] Tabs
[x] Sidenav
[x] Dial
[x] Slider

[x] Check VRT result and fix anything that's broken

[x] Checkbox line-height is too high, it's been changed to component line height now
[x] Table padding - it was wrong before! we're good now
[x] ActionGroup quiet - action button quiet was never supposed to have border when selected
[x] Action button text size - test is correct
[x] CTA/Primary/Over Background font weight - should be bold, ~overridden temporarily waiting for DNA fix~, fixed in DNA
[x] Quiet Textfield left/right padding - should be zero, ~overridden temporarily waiting for DNA fix~, fixed in DNA
[x] Menu left padding - too big due to CSS bug
[x] Height of small Button - too big due to CSS bug, needs to be 24px
[x] Dialog line height - Asked @NateBaldwinDesign, it is intended to use component line heights, so test is correct and reference is wrong
[x] ButtonGroup - seems like left/right padding is different on buttons, changed in DNA
[x] Textfield (Quiet) - vertical alignment of text is too high?
[x] Textarea min-height and top padding - height is smaller, and missing padding vars in DNA were taken from Textfield, no longer matches specs
[x] Split Button - Width and icon position changed?
[x] Slider - track color changed?
[x] Slider - ticks and ramp can be seen through slider handle (track is not visible)
[x] Slider - ticks labels are too close to ticks now, fixed and updated to match contribution
[x] Meter - text wrapping, track not showing
[x] Meter - space between labels and track is bigger? needed padding from fieldlabel
[x] Picker - padding and placeholder text color changed, selected state. Needs to be Fieldbutton's old CSS
[x] Menu - gap between icon and text seems bigger than it should be due to CSS bug
[x] Menu - gap between examples is bigger
[x] Tags - default is small, not medium
[x] Tabs - left/right padding increased
[x] Tooltip - line-height increased
[x] Picker - icon gap in selected item

[x] Implement t-shirt sizing for FieldLabel
[x] Make Progress bar use t-shirt sized FieldLabel
[x] Write migration guides for all breaking changes

[x] Picker
[x] Combobox
[x] SearchWithin
[x] DatePicker
[x] Check for others?

[x] Figure out if Picker button is-open or is-selected (it's is-open)
[x] This pull request is ready to merge.

Ignore VRT failures for:

1 actionbar
5 actionbutton
2 actiongroup
9 button
2 buttongroup
1 checkbox
15 dialog
1 fieldgroup
5 fieldlabel
3 form
1 link
1 menu
1 meter
3 pagination button style
1 pagination listing
2 picker
1 popover
7 progressbar
2 radio
1 searchwithin
9 slider
3 splitbutton
8 statuslight
11 table
13 tabs
2 tags
20 textarea
1 toast
6 tooltip
1 tray
1 truncation tags
1 truncation tabs
1 truncation picker
1 wrapping toast
2 wrapping tooltip
1 wrapping dialog
1 wrapping checkbox
1 wrapping radio
1 progress bar wrapping
3 fieldlabel with Combobox/Picker in wrapping
1 slider wrapping
1 statuslight wrapping

@lazd are there more changes coming here so that we can drop the need for custom size classes on SVG icons when they're part of a t-shirt sized component as @Westbrook & I suggested in #726 ?
Looking at the build of this PR here: https://opensource.adobe.com/spectrum-css-vr-results/site-0ce47d3-2020-11-04_01-54-50/dist/docs/actionbutton.html#migrationguide I'd expect the "Workflow icon size" and "Hold icon size" advice to be "you can remove these now".
i.e. you should be able to drop spectrum-Icon--sizeM from the second line of this example syntax, if you use css custom properties.
<button class="spectrum-ActionButton spectrum-ActionButton--sizeM">
      <svg class="spectrum-Icon spectrum-Icon--sizeM" focusable="false" aria-hidden="true" aria-label="Edit">
        <use xlink:href="#spectrum-icon-18-Edit" />
      </svg>
      Edit
</button>

The font color of Picker placeholder is different with SVG.
SVG: #959595

CSS - --spectrum-global-color-gray-800:

Dialog example in wrapping study page missed the divider line.

Dialog example in wrapping study page missed the divider line.

Handled, it was missing the sizing class.

The font color of Picker placeholder is different with SVG.
SVG is out of date, this value was updated.

.spectrum-Picker-label {
  &.is-placeholder {
    color: var(--spectrum-picker-m-placeholder-text-color);
  }
}

  --spectrum-picker-m-placeholder-text-color: var(--spectrum-alias-placeholder-text-color);
  --spectrum-alias-placeholder-text-color: var(--spectrum-global-color-gray-800);

Epic! 🥳

I feel like this t-shirt sizing implementation is increasing the component source code sizes by 3x.
At least that's what we get in the SVG-Generator. :)

also not sure if you'd like to add some labels:


Need better icons for blocks

Fontawesome is used for now, since it's currently in the GJS core. But it's hard to correctly represent Bootstrap components with fontawesome icons. We need a better solution.

Check here: https://simplesvg.com/icon-sets/


[Bug] Warning when installing 0.9

When I install 0.9 on OSX Yosemite + Apache (installed with macports), with PHP 5.6.13 instlled as Apache module I have the next response when trying to configure MySQL connection:

Deprecated:  Automatically populating $HTTP_RAW_POST_DATA is deprecated and will be removed in a future version. To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini and use the php://input stream instead. in Unknown on line 0

Warning:  Cannot modify header information - headers already sent in Unknown on line 0

{"status":"no-connection","message":"Database connection failed!"}

"Connection failed" is ok, but warning probably is not :)

I can't install Pagekit at all with mysql (even after disabling deprecation messages) - I get "connection errors" all the time. My Mysql is set up to use Unix socket - may be it's a good idea to add this option to the installed?

You need to set the ini setting display_errors=off to get rid of the warning. It is a deprecation notice which is being sent to the output buffer, which then causes the "headers already sent" warning.

I know. But imagine I was not able to open browser inspector and check what happened? Being just a generic user, I would just tell "It does not even install" and delete Pagekit forever. So I think it should be fixed somehow - by sending the SQL setup form in some other way, or by checking this option at the system requirements check stage to tell user what to do explicitly. Otherwise, it just works sloppy.

:+1: I have the same problem on Windows, never had a problem with other applications

$HTTP_RAW_POST_DATA is used if always_populate_raw_post_data is set to 1 in php.ini.
Since $HTTP_RAW_POST_DATA is deprecated in PHP 5.6.0 always_populate_raw_post_data is inactive by default in PHP 5.6.0.  I assume that you are using an php.ini from an older PHP version.
http://php.net/manual/en/reserved.variables.httprawpostdata.php

The php.ini from PHP5.6 download archive has the always_populate_raw_post_data commented out and the warning is shown. As no other applications that I use shown this warning message, maybe something with Pagekit is triggering it.

Do you have display_startup_errors enabled?

As far as I understand, it's possible to change this option at runtime with ini_set somewhere at the initialisation stage. I am not sure though... But it would be a reliable and elegant solution. Otherwise, it would be better to switch to x-form-urlencoded for compatibility reasons. Not elegant, but I really think it will make installation much easier for those who don't have enough expertise to tweak PHP settings (or just don't have an access being on shared servers). Also, including custom php.ini file into distribution may be partial solution - many hosters use local php.ini copies to tweak settings per-site.

@MalteScharenberg Yes, I have display_errors and display_startup_errors both enabled. But the strange thing is that I never saw this warning before, and I'm using a lot of other PHP applications on the same environment

@ste93cry check if any of them sends requests with a mime type divergent
to multipart/form-data or application/x-www-form-urlencoded.

@karevn Unfortunately this error occurs within PHPs startup sequence (i.e. the warning is already send to the output buffer when the first line of Pagekit is interpreted). Therefor set_ini wont have any effect.
So as you pointed out switching to x-form-urlencodedwould be the only possible solution to suppress the warning by Pagekit. The problem with this is that Pagekit heavily relies on type-safe application/json requests.
Only users who already tweaked their php.ini by enabling display_startup_errors (which is no good idea at a production system), have to modify always_populate_raw_post_data.

@MalteScharenberg for now, 95% of your users are web developers ("early adopters") or "developer wannabies", and many of them have display startup errors option enabled. So this error can easily ruin their initial impression.
Regarding global switching - If the JS architecture is right, then all the AJAX requests should be sent through one "outlet" in JS. So, it should be a very easy change at the JS side. On the server side - you can add some middleware to handle it. Not one-liner change, but should not be a big pain too.
I can make some research on this area and create a pull request if you want.

I just checked WordPress which is one of the PHP scripts running on the same environment and it seems that they're sending ajax data with application/x-www-form-urlencoded mime type

Only users who already tweaked their php.ini by enabling display_startup_errors (which is no good idea at a production system), have to modify always_populate_raw_post_data.
You're right in saying that enabling this option on a production server is not recommended, however at development environment that option is on by default and I don't think it's a good idea to just ignore this case.

@ste93cry WP is a mammoth from the old times. But it survived all these years :)

@ste93cry @karevn We are not ignoring this issue. But it's clearly a PHP 5.6.* related issue.
PHP 5.4.* and PHP 5.5.* are running fine. This issue will also be fixed in PHP 7.0.0.
So switching to application/x-www-form-urlencoded would only be a work-around for a very specific server configuration.
I think, if someone needs to enable startup errors and deprecated error messages it is no big deal to fix this PHP issue by setting always_populate_raw_post_data to -1, as recommend by the PHP team.
Read:
https://wiki.php.net/rfc/slim_post_data
https://bugs.php.net/bug.php?id=67991.

I never said you're ignoring the issue, I said we should not do it :smile: Unfortunately there is still a plenty of time before PHP 7, and even when it will be released a lot of hosting providers will not upgrade to it, at least not immediatly. I don't know the reasons or security implications of using application/json vs application/x-www-form-urlencoded, but I don't see any problem in switching over the latter to fix the warning.

application/json is type-safe. Switching to application/x-www-form-urlencoded would require some emulation middleware.

I'm a newbie, so please be patient: what do you mean with type-safe? What are the technical implications of using application/x-www-form-urlencoded, check if the json is valid on the server and ensuring that the response is always json?

@MalteScharenberg  taking in account now long PHP version lifecycle is, 5.6 will be here for a few years. So I think it worths investing efforts into emulation middleware to work this thing around. Backend code should not be that complex, and even if frontend will require more efforts - they'll be an investment into better architecture, not waste of time.

@ste93cry With application/json strings, numbers, arrays, objects, boolean and null values can be transferred without conversion. With application/x-www-form-urlencoded everything gets casted to string. Imagine sending a boolean false as string...PHP would cast this to boolean true.
Although it is possible to transfer also arrays with application/x-www-form-urlencoded, there are a lot of edge cases there conversion is not done as expected.

@karevn You are right, it wont be too much effort. We are using vue-resource (https://github.com/vuejs/vue-resource) for all requests. So only one change in frontend. But at the moment this seems not to be a big issue and a change like this can result in a lot of small bugs.

What about the emulateJSON option of vue-resource?

@ste93cry Yes, that could be used for that.

@MalteScharenberg it looks like the solution was found ;)

Can you check if this works for you?https://github.com/pagekit/pagekit/commit/2587622540dd766e962552c06aade7c3ab17882b

It works for me

@ste93cry Thanks for testing!

@MalteScharenberg ping
Database connection failed!
There is still issue for me.
Database with name pagekit, pagekit user and grant all privileges on database (connection works if i test throw SequelPRO)
OS: OSx Yosemite 10.10.4
PHP Version 5.6.8 ( php-osx.liip.ch by Liip )
NGINX 1.6.2 + php-fpm (php.ini configuration the same for CLI and FPM)
php ini:

# php -i
display_startup_errors => Off => Off
always_populate_raw_post_data => -1 => -1
display_errors => Off => Off

hm, i used Symfony v2 vhost like config file for NGINX (just changed app.php on index.php) and has "database connection error", then i found issue https://github.com/pagekit/pagekit/issues/437 and change configuration like described in that gist https://gist.github.com/geekish/7c8963e41f1b1c20f062, it's helped ;)