openthread: sleepy end device not supported by zephyr router

When using a zephyr router, a sleepy end device (SED) can attach fine, but ping doesn't work.
We suspect that the frame pending bit isn't being supported correctly.
@rlubos

We suspect that the frame pending bit isn't being supported correctly.

You are right here, the whole frame pending API specified by OpenThread is not implemented in Zephyr:
The API is specified here:
https://github.com/openthread/openthread/blob/5b4e7f93315010bf504da49ba61f1c5bf7f56279/include/openthread/platform/radio.h#L609
And here are Zephyr's empty stubs:
https://github.com/zephyrproject-rtos/zephyr/blob/c39bb49e8458fd6548711ee01bd1fafe4ffa2e95/subsys/net/lib/openthread/platform/radio.c#L303
The difficult part here is that Zephyr's 802.15.4 driver API does not support such functionality (unless I miss something), so it needs to be extended first. I don't see other option, as we do support HW ACK sending - therefore we need a way to inform the radio whether to set frame pending bit or not.

@carlescufi why is the priority low for this?  SED behavior is a critical feature of Thread, and it is mandatory in order to certify a Thread router.

@turon Two PRs were submitted, introducing Sleepy End Device support into Zephyr: #15552 and #15685.
There's no out-of-the-box sample that implements SED yet, I'm thinking about adding an overlay for the echo_client that'd configure a SED device. Just note, that when configuring SED in Zephyr, one should avoid setting a custom IPv6 address with the Mesh Local prefix, otherwise it breaks the address registration procedure of the MTD child (see this discussion).

@rlubos Thanks for the update.  So when your changes are merged, will that allow a Zephyr router to accept and support an openthread cli SED?  That is the configuration I was testing with.

@turon Yes, the scenario you describe should be fixed by #15685, which fixes the parent (router) side. #15552 on the other hand fixes the child part, allowing SEDs to be created with Zephyr.


Add ContentLoadingProgressDialog

ContentLoadingProgressDialog is added without an image.
The library is look exactly like the normal ProgressDialog.
The cool feature is that it is not displayed at all if it is dismissed in 500 millisecond to avoid UI flashes.

What is needed for you to merge this? I just fixed the conflicts.


upgraded to swift 5

Done about up swift version to 5. I will release it. I close this PR. Thank you your contributions 👍
https://github.com/bannzai/SpreadsheetView/pull/256


feat: add biochemistry questions

looks overall very nice! A lot of time you've spent on these questions!
For the ADP/AMP question I wonder if it does not also require some more-than-basic knowledge, but I leave this final determination up to you

I agree that it requires more knowledge. Are we looking at the questions from the perspective of a domain scientist? In that case some of this knowledge is more on the basic side.


tooltip is not hidden when setting value to null

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-issue-tooltip
Steps to reproduce
1 - hover tooltip area and see that tooltip is displayed
2 - click on "toggle tooltip visibility" button
3 - hover tooltip area and see that tooltip is still displayed
What is expected?
tooltip should no longer be displayed after switching the nz-tooltip value to null
What is actually happening?
tooltip is still displayed after switching the nz-tooltip value to null

Environment
Info

ng-zorro-antd
8.4.1

Browser
chrome

My reproduction link also provides a workaround relying on nzOverlayStyle to force the tooltip to be hidden.
But I think that this is not an ideal solution.

Issue

        tooltip should be {{tooltipVisible ? 'visible' : 'hidden'}}

    <button nz-button (click)="tooltipVisible=!tooltipVisible">
        toggle tooltip visibility
    </button>

close via https://github.com/NG-ZORRO/ng-zorro-antd/pull/4392


Add a way for players to use Dark relics & random event XP items

🚀 Feature Proposal
They should be usable in OSB/BSO, and I think a great way is to copy what BSO does with EXP lamps, where its "=lamp [lamp tier], [skill].
NOTE: In OSRS, Dark relics are functionally an EXP lamp that use a different scaling system depending on the skill, wiki has info on it.
The command would be like: +lamp antique lamp/book of knowledge/dark relic, Herblore.

bump

bump

bump, should be reasonable to add now that we have the lamp command in OSB!

resolved


Question: View amount of shares in API?

Is it possible to add opportunity to view shares found by miners (for example in 10 minutes interval) via API?

@xlogicex What do you mean? The actual share records? The number of shares? The accumulated difficulty of the shares?

The number of shares
Thanks

Not at the moment. The number of shares is a meaningless number anyway. You probably want the accumulated difficulty of all shares. This is were we run into performance problems for busier pools. The database query to get that information simply takes too much time at the moment.

Duplicate of #27


Presence of params in schema prevents timestamps functionality

Describe the bug
If params are specified in the schema, for instance to designate a type field (but even if empty!), then timestamps are no longer created, even if specified in the table.
Cut/Paste
test/debug.ts
import { inspect } from 'util';
import {AWS, Client, Match, Table, print, dump, delay} from './utils/init'

const Schema = {
  indexes: {
    primary: { hash: "pk" },
  },
  models: {
    User: {
      pk: {
        type: String,
      },
    }
  },
  version: "0.1.0",
  params: { },                                      // <-- This line is the culprit
  format: "onetable:1.0.0"
}

const pk = 'Peter'

const table = new Table({
    name: 'DebugTable',
    client: Client,
    schema: Schema,
    timestamps: true,
    isoDates: true,
    logger: (level, message, context) => {
        // if (level == 'trace' || level == 'data') return
        const contextMessage = context ? `Context: ${inspect(context, false, null)}` : ''
        console.log(`At: ${new Date().toISOString()}\nLevel: ${level}\nMessage: ${message}\n${contextMessage}`)
    }
})

test('Create Table', async() => {
    if (!(await table.exists())) {
        await table.createTable()
        expect(await table.exists()).toBe(true)
    }
})

test('Create with timestamps', async() => {
    const User = table.getModel('User')
    const user: any = await User.create({ pk })
    //  ISO dates 2021-06-30T01:27:19.986Z
    expect(user.created).toBeDefined()
    expect(user.updated).toBeDefined()
})

test('Destroy Table', async() => {
    await table.deleteTable('DeleteTableForever')
    expect(await table.exists()).toBe(false)
})

STDOUT
Using local Java to run dynamoDB
Spawn DynamoDB 2587
Waiting for <IP_ADDRESS>:4567...
Connected!
DynamoDB is ready
  console.log
    At: 2022-01-06T05:24:10.148Z
    Level: trace
    Message: Loading OneTable

      at Log.logger (test/debug.ts:31:17)

  console.log
    At: 2022-01-06T05:24:10.583Z
    Level: trace
    Message: OneTable createTable for "DebugTable"
    Context: {
      def: {
        AttributeDefinitions: [ { AttributeName: 'pk', AttributeType: 'S' } ],
        KeySchema: [ { AttributeName: 'pk', KeyType: 'HASH' } ],
        TableName: 'DebugTable',
        BillingMode: 'PAY_PER_REQUEST'
      }
    }

      at Log.logger (test/debug.ts:31:17)

  console.log
    At: 2022-01-06T05:24:10.684Z
    Level: trace
    Message: OneTable "put" "User"
    Context: {
      trace: {
        model: 'User',
        cmd: {
          ConditionExpression: 'attribute_not_exists(pk)',
          TableName: 'DebugTable',
          Item: { pk: { S: 'Peter' }, _type: { S: 'User' } },
          ReturnValues: 'NONE'
        },
        op: 'put',
        properties: { pk: 'Peter', _type: 'User' }
      }
    }

      at Log.logger (test/debug.ts:31:17)

  console.log
    At: 2022-01-06T05:24:10.817Z
    Level: data
    Message: OneTable result for "put" "User"
    Context: {
      cmd: {
        ConditionExpression: 'attribute_not_exists(pk)',
        TableName: 'DebugTable',
        Item: { pk: { S: 'Peter' }, _type: { S: 'User' } },
        ReturnValues: 'NONE'
      },
      items: [ { pk: 'Peter' } ],
      op: 'put',
      properties: { pk: 'Peter', _type: 'User' },
      params: { parse: true, high: true, exists: false, checked: true }
    }

      at Log.logger (test/debug.ts:31:17)

  console.log
    At: 2022-01-06T05:24:10.821Z
    Level: trace
    Message: OneTable deleteTable for "DebugTable"

      at Log.logger (test/debug.ts:31:17)

STDERR:
FAIL test/debug.ts (8.882 s)
  ✓ Create Table (480 ms)
  ✕ Create with timestamps (141 ms)
  ✓ Destroy Table (19 ms)

  ● Create with timestamps

    expect(received).toBeDefined()

    Received: undefined

      44 |     const user: any = await User.create({ pk })
      45 |     //  ISO dates 2021-06-30T01:27:19.986Z
    > 46 |     expect(user.created).toBeDefined()
         |                          ^
      47 |     expect(user.updated).toBeDefined()
      48 | })
      49 |

      at Object.<anonymous> (test/debug.ts:46:26)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 2 passed, 3 total
Snapshots:   0 total
Time:        8.951 s, estimated 9 s
Ran all test suites matching /debug.ts/i.

Expected behavior
Expect created and updated fields to be created/updated as specified in the table.
The putItem call should look like so:
  console.log
    At: 2022-01-06T05:23:10.841Z
    Level: trace
    Message: OneTable "put" "User"
    Context: {
      trace: {
        model: 'User',
        cmd: {
          ConditionExpression: 'attribute_not_exists(pk)',
          TableName: 'DebugTable',
          Item: {
            pk: { S: 'Peter' },
            _type: { S: 'User' },
            created: { S: '2022-01-06T05:23:10.838Z' },
            updated: { S: '2022-01-06T05:23:10.838Z' }
          },
          ReturnValues: 'NONE'
        },
        op: 'put',
        properties: {
          pk: 'Peter',
          _type: 'User',
          created: '2022-01-06T05:23:10.838Z',
          updated: '2022-01-06T05:23:10.838Z'
        }
      }
    }

      at Log.logger (test/debug.ts:31:17)

Environment (please complete the following information):

OS Linux u1a15089dca6954.ant.amazon.com 5.4.0-91-generic #102~18.04.1-Ubuntu SMP Thu Nov 11 14:46:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Node Version v14.18.2
OneTable Version "2.2.2"
TypeScript Version "^4.4.0"

Additional context
If params are not specified in the schema, functionality is as documented and expected.

The current behavior is for the schema params to overwrite the table params.
We could blend the schema params with the table params. The question is which takes priority?
A wrong param can clearly break the table.

Then the solution to this issue is to change something such that there is only one way to skin the cat, removing ambiguity.
Are there schema parameters and table parameters? If there are, they should be separated, with no way to override/hide each other. Hate to leave js in the dust, but typescript types can help here.

Seems like one can specify the timestamps and isoDates in the schema params. Then they should not be possible to specify in the TableConstructorParams, because schema is already specified there.

The reason for params in the schema is to allow schemas to be persisted in the table so it becomes self-describing.
You can specify any param currently in the Table params or the schema params. They both go through the same Table.setParms API.
The reason schemas take precedence is you can modify the schema at runtime (during development). As the schema is updated, the params are updated too. Not generally something we advise, but in the SenseDeep single-table designer, you need to be able to do this as you develop a schema with the GUI.
We do TS type the Table constructor params. Currently the schema params are not typed (should be typed as OneParams).
Where to go from here. Options:

Specify the precedence and blend. i.e. if unset in the schema, preserve the table value.
Specify the precedence and overwrite. i.e. if you have schema.params, then it overwrites the table params. If you have no schema, then the table params apply.
Partition the params. Some go to the schema (like typeField), some go to the Table.

How to do this without breaking compatibility ... that is the challenge.

With your explanation in mind, I went through the code and see what is going on. I wholeheartedly agree that an entity should be complete and self describing, so no argument about placing params in schema. The qualms I have is with setting the params in table, from a library interface point of view. The actual implementation may differ (keeping prams in Table object) and I understand it came to be so for historical reasons. Now where does the library go from here? When it comes to libraries (highly reusable code), I have a bias toward fixing things 'the right way, even if more painful - provided we have the time'. So I lean towards option 3 above.
Here is what I'd start with:

Decide which fields (set A) belong to schema params and should eventually be removed from table params. Mark them deprecated in Table.d.ts
Introduce a backward compatibility flag set to true by default (to preserve existing projects); When this is false, change the behavior of Table.setParams to merge schema params into table params; I believe this is what you mean by blending.
In Table constructor, before the call to setParams, go through params and for each present field that is in set A (defined in 1. above) give a runtime log about deprecation, and indicate it should be set in schema henceforth. Depending on compatibility flag defined in 2. above, the log entry should mention what is about to happen, so devs understand the why of behavior about to ensue.

Later on when 2.3 (or whatever horizon is decided) comes about

remove the compatibility flag
remove deprecated fields from TableConstructorParams
make the blending behavior the only behavior.

Sometime along the way, fix types of Schema params.
Did I miss anything?

Thank you, that is helpful.
Agree with your approach.  Digging deeper...
Partitioning the fields looks pretty easy. These set of schema params is:

Property
Type
Description

createdField
string
Name of the "created" timestamp attribute. Defaults to "created".

hidden
boolean
Hide templated (value) attributes in Javascript properties. Default true.

isoDates
boolean
Set to true to store dates as Javascript ISO strings vs epoch numerics. Default false.

nulls
boolean
Store nulls in database attributes vs remove attributes set to null. Default false.

timestamps
boolean
Make "created" and "updated" timestamps in items. Default false.

typeField
string
Name of the "type" attribute. Default "_type".

updatedField
string
Name of the "updated" timestamp attribute. Default "updated".

The set of Table params is:

Property
Type
Description

client
DocumentClient
An AWS DocumentClient instance.

crypto
object
Optional properties defining a crypto configuration to encrypt properties.

logger
`boolean
object`

metrics
object
Configure metrics. Default null.

name
string
The name of your DynamoDB table.

schema
string
Definition of your DynamoDB indexes and models.

senselogs
object
Set to a SenseLogs logger instance instead logger. Default null.

transform
function
Callback function to be invoked to format and parse the data before reading and writing.

uuid
string or function
Create a UUID, ULID or custom ID if the schema model requires and the property is not already defined. Set to uuid or ulid for the internal UUID or ULID implementations. A ULID is a time-based sortable unique ID. Otherwise set to a function for a custom implementation. If not defined, the internal UUID implementation is used by default when required.

validate
`function
Function to validate properties before issuing an API.

value
`function
Function to evaluate value templates. Default null.

It is easy to split Table.setParams into setParams and setSchemaParams. They are internal APIs anyway. The "blending" is probably overstating what is happening. The two params sets define specific properties on the Table object. However, they are 100% disjoint sets in this plan.
In the next minor version upgrade ...  for TypeScript users will catch if anyone supplies the schema params to the Table constructor. For JS users, we can throw an exception. So in both cases, changed behavior is flagged and caught. We may not need a compatibility flag due to this, will need to consider in light of other breaking changes like the UUID change.
For the next patch level release, we can do the deprecation warning you indicate.
What did you mean by "Sometime along the way, fix types of Schema params."?

Great progress, ty!
What i meant with fixing types for schema params is to narrow down the type of fields from any.
Jan 6, 2022 17:53:05 mobsense @.***>:

Thank you, that is helpful.
Agree with your approach. Digging deeper...
Partitioning the fields looks pretty easy. These set of schema params is:
Property
Type
Description
createdField
string
Name of the "created" timestamp attribute. Defaults to "created".
hidden
boolean
Hide templated (value) attributes in Javascript properties. Default true.
isoDates
boolean
Set to true to store dates as Javascript ISO strings vs epoch numerics. Default false.
nulls
boolean
Store nulls in database attributes vs remove attributes set to null. Default false.
timestamps
boolean
Make "created" and "updated" timestamps in items. Default false.
typeField
string
Name of the "type" attribute. Default "_type".
updatedField
string
Name of the "updated" timestamp attribute. Default "updated".
The set of Table params is:
Property
Type
Description
client
DocumentClient
An AWS DocumentClient[https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/DynamoDB/DocumentClient.html] instance.
crypto
object
Optional properties defining a crypto configuration to encrypt properties.
logger
boolean object
metrics
object
Configure metrics. Default null.
name
string
The name of your DynamoDB table.
schema
string
Definition of your DynamoDB indexes and models.
senselogs
object
Set to a SenseLogs logger instance instead logger. Default null.
transform
function
Callback function to be invoked to format and parse the data before reading and writing.
uuid
string or function
Create a UUID, ULID or custom ID if the schema model requires and the property is not already defined. Set to uuid or ulid for the internal UUID or ULID implementations. A ULID is a time-based sortable unique ID. Otherwise set to a function for a custom implementation. If not defined, the internal UUID implementation is used by default when required.
validate
function Function to validate properties before issuing an API. value function
Function to evaluate value templates. Default null.
It is easy to split Table.setParams into setParams and setSchemaParams. They are internal APIs anyway. The "blending" is probably overstating what is happening. The two params sets define specific properties on the Table object. However, they are 100% disjoint sets in this plan.
In the next minor version upgrade ... for TypeScript users will catch if anyone supplies the schema params to the Table constructor. For JS users, we can throw an exception. So in both cases, changed behavior is flagged and caught. We may not need a compatibility flag due to this, will need to consider in light of other breaking changes like the UUID change.
For the next patch level release, we can do the deprecation warning you indicate.
What did you mean by "Sometime along the way, fix types of Schema params."?
—
Reply to this email directly, view it on GitHub[https://github.com/sensedeep/dynamodb-onetable/issues/241#issuecomment-1006993752], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AKLP3YYJIKBMUGAWOI4TRXDUUYMNDANCNFSM5LLRIEBQ].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you authored the thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAD8AAAA/CAYAAABXXxDfAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAmSURBVGiB7cEBDQAAAMKg909tDwcUAAAAAAAAAAAAAAAAAAAAJwY+QwABivJx1AAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AKLP3Y6GUHIUITZYCZJHWWLUUYMNDA5CNFSM5LLRIEB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHQCYCWA.gif]


python312Packages.psycopg: 3.2.1 -> 3.2.2

https://github.com/psycopg/psycopg/blob/3.2.2/docs/news.rst#current-release
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 342175 run on x86_64-linux 1

4 packages marked as broken and skipped:

khoj
khoj.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist

52 packages built:

authentik
azure-cli-extensions.rdbms-connect
azure-cli-extensions.rdbms-connect.dist
paperless-ngx
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
pgcli (python312Packages.pgcli)
pgcli.dist (python312Packages.pgcli.dist)
python311Packages.langgraph
python311Packages.langgraph-checkpoint-postgres
python311Packages.langgraph-checkpoint-postgres.dist
python311Packages.langgraph.dist
python311Packages.llama-index-vector-stores-postgres
python311Packages.llama-index-vector-stores-postgres.dist
python311Packages.mayim
python311Packages.mayim.dist
python311Packages.pgcli
python311Packages.pgcli.dist
python311Packages.pgspecial
python311Packages.pgspecial.dist
python311Packages.pgvector
python311Packages.pgvector.dist
python311Packages.psycopg
python311Packages.psycopg-c
python311Packages.psycopg-c.dist
python311Packages.psycopg-pool
python311Packages.psycopg-pool.dist
python311Packages.psycopg.dist
python311Packages.psycopg.doc
python311Packages.pytest-postgresql
python311Packages.pytest-postgresql.dist
python312Packages.langgraph
python312Packages.langgraph-checkpoint-postgres
python312Packages.langgraph-checkpoint-postgres.dist
python312Packages.langgraph.dist
python312Packages.mayim
python312Packages.mayim.dist
python312Packages.pgspecial
python312Packages.pgspecial.dist
python312Packages.pgvector
python312Packages.pgvector.dist
python312Packages.psycopg
python312Packages.psycopg-c
python312Packages.psycopg-c.dist
python312Packages.psycopg-pool
python312Packages.psycopg-pool.dist
python312Packages.psycopg.dist
python312Packages.psycopg.doc
python312Packages.pytest-postgresql
python312Packages.pytest-postgresql.dist


drivers: ieee802154: Fix compile errors in RF2XX

Fix compile errors hidden behind ifdef.

merged via https://github.com/zephyrproject-rtos/zephyr/pull/23655.


start to add wh properties

Description
Please explain the changes this PR addresses here.
Checklist

[ ] If this requires a documentation change, I have created a PR in moonbeam-docs repository.
[ ] If this requires it, I have updated the Readme
[ ] If necessary, I have updated the examples
[ ] I have verified if I need to create/update unit tests
[ ] I have verified if I need to create/update acceptance tests
[ ] If necessary, I have run acceptance tests on this branch in CI

Closing this because part of it done in #303


Initial slide always off by one error

What I mean by this is that when the component initially mounts, the translate value is always negative equal to the width of one slide, showing the cloned slide and not the actual slide.
I have some css animations I want to do for each slide as a user swipes through, but because of this error it's always one off. The 'slick-active' slide is not the one that is visible.

In the above screenshot, the slick-cloned slide is visible, not the slick-active slide.

@rossPatton It's not an error. As you can see the cloned is your last slide before your actuall first slide and it is hidden with -negative translate. Which is used while infinite prop is set to true. Just set to false, you will not see the cloned slide. You will exactly see slides you have passed.
What version are you using? This might be an error caused by some css styling. Can you give more info??

I see that setting infinite to false 'fixes' the issue, but that is not how slick.js works. I use slick.js often, with infinite set to true, and I do not get this behavior, nor would I ever expect it.
I would expect that the carousel should start on the first slide by default regardless of whether it was infinite or not.
What is the logic behind having it start any other way?

To create the illusion that there is an infinite carousel. This works rougly like this, let's say we are at slide 1 and then we press back then the track is translated to show the cloned slide with an animation which runs smoothly. Then right as the animation ends, we translateX value to show the last slide this time without any animation. So, when the next time use press back button we do translation from last slide to before last slide.
I think there is something wrong with your settings. Can you clone this repo do npm i && npm start and open localhost:8000 and report if you see any unexpected behaviour on your side? If everything works properly then your Slider is not configured properly. Everything works as expected on my system.

I was experiencing this same issue. I added initialSlide: 0, and it seemed to have corrected the issue. The initialSlide is supposed to default to 0, but with infinite set to true it seemed to ignore it and default to the first slide (-1).
Not sure if that will be helpful to anyone, but it seems to have corrected my issue.


More updates to various image references

Updating them to the env variables now that we have access that feature.

/check-enforcer override

We are definitely good to go. Merging!

/check-enforcer override

@microsoft-github-policy-service rerun

/check-enforcer override


NaN in drain package

When calling the function nlmod.gwf.drn NaN's are printed in the drain package file. This results in a Fortran error when trying to run the model. Within the function, a mask is created based on the conductance being not equal to zero:
mask = mask_arr != 0

However this is also true for NaN. Perhaps the expression should be adjusted?
To be pedantic, the term 'mask' is used in the opposite sense (all other values are masked).

Perhaps the expression should be changed to:
mask = mask_arr > 0

This excludes NaN and ofcourse conductance is always positive.

Hi Tom, thanks for pointing this out. I agree with your solution. Would you like to make a Pull Request for this? If not I am happy to make one as well.


Failed publish of 0.5.0

Just posting this here for tracking and to help anyone else who stumbles into it. There is an issue on the crates repo too.
Essentially something went wrong with the publish and the package is unavailable. Will most likely need a yank and republish with a version bump to 0.5.1.

Version 0.5.1 has been uploaded.


Building OCIO apps fails because it doesn't look for OpenEXR

When building OCIO apps, OIIO is an dependecy. However, OIIO is in turn looking for OpenEXR, which isn't searched for at all by cmake. This means that even if I put the location of openexr to CMAKE_PREFIX_PATH, it's never added to the build config. Only way to build it is to put the OpenEXR include files in the same location as something else that is found.
This is on Windows with OCIO RB-2.0, OIIO release and OpenEXR 2.5.5
Expected behavior is that when building the OCIO-apps it should search for OpenEXR and add it.
Here's the error messages
C:\vfxplatform_build\dist\oiio\include\OpenImageIO/Imath.h(13): fatal error C1083: Cannot open include file: 'OpenEXR/OpenEXRConfig.h': No such file or directory [C:\vfxplatform_build\build\
OpenColorIO\src\apps\ociolutimage\ociolutimage.vcxproj]

C:\vfxplatform_build\dist\oiio\include\OpenImageIO/Imath.h(13): fatal error C1083: Cannot open include file: 'OpenEXR/OpenEXRConfig.h': No such file or directory [C:\vfxplatform_build\build\
OpenColorIO\src\apps\ociodisplay\ociodisplay.vcxproj]

As OpenEXR is not directly used in OCIO, I suspect that OpenEXR_ROOT cannot help. But I remember that the OpenImageIO public API requires an access to the OpenEXR public API in order to access the half type.
I checked my batch file, and I found that I directly added a OpenEXR include file access to the cmake command:
-DCMAKE_CXX_FLAGS=-I%COMPILED_THIRD_PARTY_HOME%/OpenEXR-2.4.0/include

That could be the solution. I removed that line from my batch file, and the build now fails with the same 'kind' errors.
F:\OpenSource\3rdParty\compiled-dist_rls\OpenImageIO-2.1\include\OpenImageIO/simd.h(31): fatal error C1083: Cannot open include file: 'OpenEXR/ImathVec.h': No such file or directory [F:\OpenSource\ocio_1\build_win_rls\src\libutils\oiiohelpers\oiiohe
lpers.vcxproj]
F:\OpenSource\3rdParty\compiled-dist_rls\OpenImageIO-2.1\include\OpenImageIO/simd.h(31): fatal error C1083: Cannot open include file: 'OpenEXR/ImathVec.h': No such file or directory [F:\OpenSource\ocio_1\build_win_rls\src\apps\ociolutimage\ociolutim
age.vcxproj]
F:\OpenSource\3rdParty\compiled-dist_rls\OpenImageIO-2.1\include\OpenImageIO/simd.h(31): fatal error C1083: Cannot open include file: 'OpenEXR/ImathVec.h': No such file or directory [F:\OpenSource\ocio_1\build_win_rls\src\apps\ociodisplay\ociodispla
y.vcxproj]

I don't think this is still relevant with the current versions of the libraries.  Please re-open if it is still a problem for you.


Roadmap for ElasticSearch 6.*

Hi.
There're previsión for update or create branch for Elasticsearch 6.* ?
Thanks.

Laravel 6 is now supported.


Missing Keywords

Hi,
vsc-oracle-plsql is the best syntax highlighter for plsql.
But here are some keywords missing:

AND, OR , NOT
XMLTYPE
Substitution variables & DEFINE
SQLPlus keywords
(SIZE, SERVEROUTPUT, FORMAT, WRAPPED, ECHO, SPOOL, PROMPT, WHENEVER, SQLERROR, VERIFY ...)

Boolean operators were intentionally left out for now.
Maybe I cover Oracle's built-in types in the future.
SQLPlus keywords often conflict with PLSQL's and will not be supported.


Query on open-sourcing plans for your exceptional work

Hello, I'm a student from SJTU. I'm deeply impressed by your exceptional work on materials. I wonder if you have any plans to release the source code as open-source in the future and I am really looking forward to it.

Hi @Amuseum-WHR, thank you for your interest in our work! We will make the project open-source and available for you to test very soon. Stay tuned for new updates on the repository and web page.

Hi, how soon will this project be open-source and available? Maybe you can provide a rough timeline?

Hi @Amuseum-WHR, thank you for your interest in our work! We will make the project open-source and available for you to test very soon. Stay tuned for new updates on the repository and web page.

I kindly request the release of the source code as it would greatly benefit my research. Your code is invaluable to my studies. Thank you in advance for considering my request!

Hi again, I appreciate your excitement @Amuseum-WHR! A first code release should be pushed by the end of next week.

Hello, Thank you for your brilliant work on Stable Diffusion-based material estimation/generation! I am curious about your dataset TexSD. Will TexSD be released together with the code at the same time?
Thank you! :)

Also here wondering what the license terms for this project implementation will be! Looking forward to being able to experiment on these functionalities!

Thank you all for your interest and enthusiasm. The code has been released tonight.
I apologize for the inaccurate release time estimation; the project took longer than anticipated.
@snowflakewang, TexSD will be released at a later stage as it didn't make it in time with the code.
@vararth, we have chosen the MIT license for this repository.


Altering weekday color dynamically

Was looking through the documentation for Dynamic Color Selection and was curious how to change weekday colors.
This works as desired for the 'selected date'
<InfiniteCalendar
                        theme={{
                            selectionColor: function(date){
                                return '#EC6150';
                            }
                        }}
                    />

I have a requirement to illustrate certain days that are missing entries. I started to poke around and noticed the theme.js which contained a weekdayColor and thought I may be able to do the following.
<InfiniteCalendar
                        theme={{
                            weekdayColor: function(date){
                                return '#EC6150';
                            }
                        }}
                    />

This did not work but is it possible to color weekdays dynamically?

Just found out weekdayColor is the 'Sun-Sat' header row background color...looks like that wouldnt do me any good.  The functionality to dynamically color a particular date  looks like a it may be a new feature...or I just haven't found it yet.

Looking into the Days file it appears the markup is different for the selectedDay to give it the nice circular shape and when it applies the color.
Will look into forking and adding this feature...really enjoy the work on this datepicker component =)

For performance, it would probably make sense to avoid altering/adding any more structure than necessary.  Was kind of thinking about adding a 'highlight' option, where a dev passes in an array of objects that define a highlight color and date, (perhaps range too)...and only add the extra div structure for those dates.
Just throwing some thoughts out there...

Just seen there is a pull request from repo owner which appears to be attempting to tackle this feature =)


Is there a way to log caught exceptions to Rollbar from class components?

Is there a way to log caught exceptions to Rollbar from class components using @rollbar/react?
At present, it appears that Provider and ErrorBoundary only log uncaught exceptions. Logging caught exceptions in functional components seems to be possible using the useRollbar hook to access the Rollbar instance created by Provider.
Is there a way something similar can be achieve for children class components, or would I also have to import rollbar and instantiate it myself in class components? Or perhaps create a HOC that passes in the rollbar instance?

With the prevalence of functional components in the React ecosystem, I'd suggest migrating to that pattern and using the hook where possible.
If you really need to send it to a class component, the approaches you mentioned sound reasonable... wrap in another component that gets the rollbar instance from the hook and pass it into the relevant child component.

When using the Provider component, the Rollbar instance is stored in a React Context. There are standard ways to get the value from a Context in a class component, but this SDK is missing the needed exports. I have opened a PR to provide these. (https://github.com/rollbar/rollbar-react/pull/38)
There are several ways to make the Rollbar instance available to class components. Each may be best in different situations.
1. Get the instance from the Context
This will only work once the above PR is published. This technique should be preferred for projects that are migrating to function components, or have a mix of class and function components.
import React from 'react';
import { Context, getRollbarFromContext } from '@rollbar/react';

export default class ClassComponent extends React.Component {
  // This must always be named `contextType`. It's a special React property
  static contextType = Context; .

  componentDidMount() {
    // This will be set when the component is mounted.
    this.rollbar = getRollbarFromContext(this.context);

    this.rollbar.info('message from class component');
  }

  render() {
    return
Class component

  }
}

This pattern only works when your class consumes a single context. If your class consumes multiple Contexts, you have to wrap the class component instead:
    <OtherContext.Consumer>
      {other => (
        <RollbarContext.Consumer>
          {rollbarContext => (
            <ClassComponent other={other} rollbarContext={rollbarContext} />
          )}
        </RollbarContext.Consumer>
      )}
    </OtherContext.Consumer>

That's a bit awkward, but that's why people are migrating to function components and hooks. Constructs like this aren't needed when using hooks.
Note that in the class component, you still need to get the instance out of the context:
this.rollbar = getRollbarFromContext(this.props.rollbarContext);
2. Store the instance in whatever state management you use.
If your project is primarily class components, and you aren't planning to migrate from that, you're probably using some state management solution. e.g. redux or mobx. In this case, the provider isn't that useful and you can just instantiate the rollbar instance and store it in your global state.
// At the top of <App>
import Rollbar from 'rollbar';

// Put this in your global state
const rollbar = new Rollbar(config);

3. Attach the instance to the window object
If your project is too small to have state management, and you don't plan to migrate to function components, you can attach it to the window object. That's what Rollbar.js does by default, and it will work fine to do it here as well.
window.rollbar = new Rollbar(config);

// You can now use it from anywhere in your app.
rollbar.info('It works!');


Proposal: Add presenter Style property for all picker types

Proposal: Add presenter Style property for all picker types
Summary
It's impossible to individually customize the *PresenterStyle for various picker types like DatePicker (as opposed to MenuFlyout.Style, for example). You can greate a global implicit Style, but not target a single instince. This inconsistency greats problems for CornerRadius customization, for example.
Rationale

Can't customize the Style of one presenter relative to another (has to be app-wide)
Inconsistency with other types

Scope

Capability
Priority

Important Notes
Here's how you can customize directly through Flyout:
<Button Content="Click me">
    <Button.Flyout>
        <Flyout>
            <Flyout.FlyoutPresenterStyle>
                <Style TargetType="FlyoutPresenter">
                    <Setter Property="CornerRadius" Value="6"/>
                </Style>
            </Flyout.FlyoutPresenterStyle>
            <TextBlock Text="Hello World"/>
        </Flyout>
    </Button.Flyout>
</Button>

And through MenuFlyout:
<Button Content="Click me">
    <Button.Flyout>
        <MenuFlyout>
            <MenuFlyout.MenuFlyoutPresenterStyle>
                <Style TargetType="MenuFlyoutPresenter">
                    <Setter Property="CornerRadius" Value="6"/>
                </Style>
            </MenuFlyout.MenuFlyoutPresenterStyle>
           <MenuFlyoutItem Text="Copy" Icon="Copy" />
            <MenuFlyoutItem Text="Delete" Icon="Delete" />
            <MenuFlyoutSeparator />
            <MenuFlyoutItem Text="Rename" />
            <MenuFlyoutItem Text="Select" />
        </MenuFlyout>
    </Button.Flyout>
</Button>

Controls known to be missing this functionality::

DatePicker
CalendarDatePicker
TimePicker
ListPicker

Open Questions

Scrub for other controls that are missing this?

This is a good suggestion. Today in my UWP app I have a 24-Hour clock which is huge because there's no way to change the template size from the Grid inside. I could fit 10 digits inside the control which needs just 2 digits.

I hope this could enable Compact density being applied to the flyouts when the parent control is using more compact sizing.


Can you add a line to an invoice without overwriting the line thats already there?

Hi, I'm creating invoices and I have a dynamic amount of lines that need to be created. Using the update for line will overwrite the existing line. Is there a way to add lines without overwriting them? Thanks in advance.

@ryanbarsatan I'm not  sure if this will answer your question, but this is how I am creating invoices with dynamic number of lines:
        $qbEntity = new QuickBooksOnline\API\Data\IPPInvoice;
        ...
        $qbEntity->Line = []; // lines are empty array

        $i = 0;
        foreach ($invoiceItemsLoadedFromSomewhere as $invoiceItem) {
            // add a new line to array of lines
            $qbEntity->Line[] = new \QuickBooksOnline\API\Data\IPPLine([
                'LineNum' => $i,
                'Description' => $invoiceItem->getDescription(),
                'Amount' => (float)$invoiceItem->getTotal(),
                'DetailType' => 'SalesItemLineDetail',
                'SalesItemLineDetail' => new \QuickBooksOnline\API\Data\IPPSalesItemLineDetail([
                    'ItemRef' => new \QuickBooksOnline\API\Data\IPPReferenceType([
                        'value' => $qbItemFerefenceId,
                        'name' => 'Advertising'
                    ]),
                    'UnitPrice' => $invoiceItem->getPrice(),
                    'Qty' => $invoiceItem->getQuantity()
                ])
            ]);
        }

        /** @var QuickBooksOnline\API\DataService\DataService $quickbooksClient ?>
        $quickbooksClient->Add($qbEntity); // or ->Update($qbEntity); depending on the operation I need to do

This deals with SalesItemLineDetail type, but you get the idea. When updating an existing invoice, I think you need to also provide Id of each item to be updated (or if you omit the Id from individual lines, then new items would be created)
Does this answer your question ?

@becquerel This is exactly what I was trying to do! Thanks a bunch, I didn't realize I could reference Line like that.

@ryanbarsatan
"Line" will also be included in the Facade List later for easy programming purpose. I will include examples in the README file once it is available. Please check the progress from wiki page: https://github.com/intuit/QuickBooks-V3-PHP-SDK/wiki

hey @becquerel can you please tell me how can I add Customer Email using your array?


Feature Request: Add export keyboard shortcut

Currently there is no keyboard shortcut (built in) for export. CMD+E or CMD+SHIFT+E would work.

Fixed for the next release.

Added in 0.2.5 release


Update Get-WindowsDriver.md

I added a new command after executing it in Windows 11.

is this available in other OS Versions of the article? Thanks

Sorry I am using windows 11, so I check for windows 11 only. If you have other version os, you can check it please

is this available in other OS Versions of the article? Thanks

Sorry I am using windows 11, so I check for windows 11 only. If you have other version os, you can check it please

I don't, I guess we can update this article for now and update them later.


Auth Tokens when using Incremental Migrations/YARP

I'm not sure if what I'm trying to do is possible, but right now I'm doing an incremental migration of an old dotnet platform app to dotnet 6 using the Microsoft Project Migrations extension (https://devblogs.microsoft.com/dotnet/incremental-asp-net-migration-tooling-preview-2/)
I've got the new dotnet core project hooking into our Duende identity server for login, and the pages that are still being served up via the old project do seem to recognize the identity once signed in (though this is probably because our identity server creates a forms auth ticket at login).
There are controllers that I can't migrate to the core app just yet, but I'd like them to hit an API protected by the identity server. I can't figure out if it is possible to attach a bearer token to the API calls so that authorization can be granted against the API. I tried adding the IdentityModel package to the project to request a token, but I can't even hit the discovery document because of an issue with System.Memory.

if (disco.IsError)
{
        Console.WriteLine(disco.Error);
}

It fails on the discover doc call with:

System.IO.FileLoadException: 'Could not load file or assembly 'System.Memory, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference.

The app is dotnet 4.7.2 with IdentityModel 6.0.0
The launching client that actually hits the Identity server is dotnet 6.0 with the following config
.AddOpenIdConnect(OpenIdConnectDefaults.AuthenticationScheme, options =>
{
    options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
    options.Authority = "https://localhost:44300";
    options.ClientId = "myclient";
    options.ClientSecret = "secret";
    options.ResponseType = "code";
    options.SaveTokens = true;
    options.GetClaimsFromUserInfoEndpoint = true;
    //scopes etc omitted for brevity

Hi @MH61Aus, sorry we never got back to you about this! We normally have answer support questions in our Support repo, where I'm transferring this issue. Do you still need help?


Test failed: 'Call of multiple onCheckpointReached handlers on a single db change' on Android in Native mode

https://gist.github.com/vasilevskayaem/0e0cfab2374b83d9c69bb74b65f359a5

@vasilevskayaem Please try locally with vNext_yarong_417_812_artemjackson_1161_1178


Captcha

Hi there,
I like this library a lot but it does not seem to support captcha. Would you have a recommendation how to solve it? Probably a third party solution like Google's reCaptcha etc? Thanks!

The external service you would use does not need to be implemented in this library but rather independently in your own application.
The recaptcha service is two part. It's a widget that load in your browser and is instructed to be attached to an HTML element, such as a form or input control. When the form is submitted, it's up to your server-side script to listen for the recaptcha parameter that is added to your form from that recaptcha widget.
Your server-side script will need to grab that token, and "redeem" it with Google's recaptcha verification API endpoint. If good, then you know your visitor is human. If Google comes back with a "nope", then you know it's likely a bot.
This logic is outside the scope of this authentication library because it's a touring test, not an authentication and user management component or feature.

@kozuch Thanks for bringing this up! We have not considered any implementation for captchas so far. We have throttling built-in, as you may know, and for any other part of your application, you can easily add captchas yourself in a separate form. That was our reasoning. Sure, you might want captchas to unlock an account when it has been throttled. Is that what you want? We’re open to adding some small interface that would allow this library to communicate with the captcha library. But yes, captchas should be separate. Either reCaptcha or any other solution that works for you.
@maietta Thank you, couldn’t have explained this better! Still, we think there might be some legitimate use cases where you’d want to integrate the captcha implementation and this library. Perhaps this is what @kozuch had in mind.

Thanks for comments. I would like to secure the user registration only so far but I forgot to specify this. I reviewed the competitive PHPAuth which has it. I do understand and agree that external solution like reCaptcha may probably be conveniently implemented in my custom code. I have not started my project yet though so have not really looked into it yet.

I would like to secure the user registration only so far

Thanks for explaining the use case!

I reviewed the competitive PHPAuth which has it

We actually think this library here is better, with one of the major reasons being that we don’t have everything built in, which does not even belong into the library, like SMTP, captchas, etc.

I do understand and agree that external solution like reCaptcha may probably be conveniently implemented in my custom code

Yes, it sounds as if this was really the best thing you could do here. You should try it, and you will probably find that it’s super easy to implement alongside this library.

Hi there,
I like this library a lot but it does not seem to support captcha. Would you have a recommendation how to solve it? Probably a third party solution like Google's reCaptcha etc? Thanks!

Keep in mind that Google has 3 versions of their API. The basic concept though the service will load via javascript, an embeded widget which generates a token associated with the IP of the visitor. They will generate a client-side unique string of text (the token) and then intercept an event on your page per your site's design, such as a form. The form payload will be intercepted on "submit" of the form, and the token from the javascript will be added to your existing form payload. Think of this like a double hidden input field. Your server-side script will need to capture this field and value along with your normal field but before you do anything like process the form, you should have your script ask the API if that token is valid. You will send both the token and the user's IP and Google's API will say yes/no. Version 3 of their API is nicer because it's out of the way and does not require any action by the user until the turing test is required
A shorter summary:
Any place you need the captcha, you will display the JS along with the HTML or JS action per their documentation, which includes your unique site public side version of the key.
Google will load up from their server on your page a captcha widget which they will generate a client-side token they track. This widget performs some tests to determine if a turing test is required before a form can be submitted. In either case the form will be modified to include a client-side generated token.
When the visitor of your site submits the form, the form is intercepted by javascript and modified to include that payload, in which you are required to take that payload and test against Google's API and do as you wish once you have your answer if they passed the bot test or not.
Be warned however, I have already found a way to beat all versions of the Google recaptcha and invisible captcha services, so don't trust this to be "proof" that it can detect the different between a bot and a human. However, i have not seen anyone in the wild solve Google's new recpatcha yet.


make code blocks dependent on their file and not the active one

Thank you :) I'll check this out tomorrow

Fixed all the things, I hope


{ [Error: socket hang up] code: 'ECONNRESET' }

Try to use chilli-pepper but have this message : { [Error: socket hang up] code: 'ECONNRESET' }
All on the same server (2 ethernet cards)
Nodejs 4.2.2
Coovachilli 1.3.0
Freeradius 3

Hi,
I'll be glad to help, but I need more informations:

Are you using it from client (browser) or from node.js (server)?
Could you describe better your environment?
Have you tried to run pepper with debug?

I have try in 2 ways:
1st: one page with just chilli-pepper for testing (lunch by nodeJS command on the server)
2nd: from an api call by browser in MEAN application (I use generator-angular-fullstack)
For the 2 ways the application is on a same server than coovachilli, it could be a problem?
The environment is like this:
Ubuntu 14.04 with 2 eth (tun with coovachilli) with: Freeradius 3 / Coovachilli 1.3.0 & 1 MEAN application for management of a wifi network.
Freeradius/Coovachilli working well

Ok. So you're seeing the socket hang up error both in node and the browser. This could happen if you make chilli-pepper point to the wrong host / port.
Are you sure that host and port options are actually CoovaChilli's host and port?
You could check that easily:

Join the Wi-Fi (or wired) network. You'll get an IP address from CoovaChilli's DHCP.

Check your gateway IP address (usually from your OS network preferences). It should be CoovaChilli's IP address, and it should equal to host option of chilli-pepper. Default port is usually 3990. Also, you can check if CoovaChilli is correctly online by doing curl http://{your-gateway-ip}:3990/json/status. You should see a JSON response from CoovaChilli.

Log on using chiilli-pepper, calling logon method from your browser or node.


Cannot resolve module 'imagesLoaded'

Perhaps in the plugin description in the section about Webpack is the error?
Originally installed the plugin via npm:
npm install imagesloaded

then hooked into webpack:
'use strict';
...
var imagesload = require('imagesLoaded');

In the console, get connection error plugin:
./markup/static/js/main.js
Module not found: Error: Cannot resolve module 'imagesLoaded' in /home/zencoder/Projects/stage/ef/markup/static/js

But when I change the connection string in webpack on the next line:
'use strict';
...
var imagesload = require('imagesloaded');

Webpack fulfills without errors, and includes a plugin to build the project:
Hash: 26472ce9ac9cf164a7b1
Version: webpack 1.13.1
Time: 1774ms
  Asset     Size  Chunks             Chunk Names
main.js  2.43 MB       0  [emitted]  main
chunk    {0} main.js (main) 876 kB [rendered]
    [0] ./markup/static/js/main.js 11.5 kB {0} [built] [1 warning]
    [1] ./~/chart.js/src/chart.js 1.78 kB {0}
    ...
  [160] ./~/imagesloaded/imagesloaded.js 9.62 kB {0} [built]

Thanks for reporting this issue. Could you elaborate what you mean by

But when I change the connection string in webpack on the next line

What did you change?

var imagesload = require('imagesLoaded'); to var imagesload = require('imagesloaded');
In other words - **imagesLoaded** to **imagesloaded** ( from uppercase to lowercase )

ah! Thanks for pointing that out. I've fixed this typo on the site.


Allow to select multiple items in the EXPLORER window to copy/paste

VSCode Version: 1.10.2
OS Version:
OS Name:     Mac OS X
OS Version:  10.11.3
OS Platform: Darwin
RID:         osx.10.11-x64

Steps to Reproduce:

In the EXPLORER window, currently it allows to select only one item for copy/paste
It'd more convenient if it allows us to select multiple items for copy/paste :)

https://github.com/Microsoft/vscode/issues/1023

dup of #1023


Several organoid datasets show species = Unspecified

Description of the issue
Some release 10 datasets have an issue with the species not showing in the data portal:

https://data.humancellatlas.org/explore/projects/b7259878-436c-4274-bfff-ca76f4cb7892
https://data.humancellatlas.org/explore/projects/e0c74c7a-20a4-4505-9cf1-38dcdd23011b
https://data.humancellatlas.org/explore/projects/e57dc176-ab98-446b-90c2-89e0842152fd
https://data.humancellatlas.org/explore/projects/5bb1f67e-2ff0-4848-bbcf-17d133f0fd2d

This is a known issue, due to those datasets not containing a donor_organism or specimen_from_organism and therefore missing the value for the browser.
This is a modelling issue and we need to discuss with the browser team before proceeding.
Acceptance criteria

[x] A discussion is scheduled on how to proceed with this issue.
[ ] AI emerge from the meeting that will solve this issue and the proper tickets are created
[ ] The datasets are corrected to include the new specimens/cell lines/specimens/donors

Close if we have tickets for all EBI datasets

https://app.zenhub.com/workspaces/operations-5fa2d8f2df78bb000f7fb2b5/issues/ebi-ait/hca-ebi-wrangler-central/460 - Stalled (one of the affected datasets)
https://contribute.data.humancellatlas.org/projects/detail?uuid=e0c74c7a-20a4-4505-9cf1-38dcdd23011b&tab=project - The Operations ticket was marked as Done but Ami did not pushed the update to DCP (I will re-open the original Ops ticket and add to the To Do list)
https://contribute.data.humancellatlas.org/projects/detail?uuid=b7259878-436c-4274-bfff-ca76f4cb7892&tab=project - - The Operations ticket was marked as Done but Ami did not pushed the update to DCP (I will re-open the original Ops ticket and add to the To Do list)
Last in the list is Project https://contribute.data.humancellatlas.org/projects/detail?uuid=5bb1f67e-2ff0-4848-bbcf-17d133f0fd2d (UCSC) - I will add to the Operations Notes and decide course of action on this one.
Closing the ticket as 3/4 are already covered in separate tickets (EBI) and the fourth we will define what to do today in Ops Review Meeting


Why are your settings not in accordance with the standards of ssl, UDA and SSDA?

Thank you for your excellent work. I'm curious why you didn't keep the same settings as before to experiment? For example, in the SSL field, the commonly used data sets are cifar10 and cifar100, as well as SVHN and STL-10. The commonly used in UDA are office-home and office31. The commonly used in SSDA are Domainnet and Officehome. If you change the settings, it is difficult to compare fairly with previous work.

@ljjcoder I tried on the officehome dataset with the same hyperparameters on 64x64 using the pytorch dassl repo for adamatch.
I was not able to get good accuracy. Did you tried any?

@ljjcoder I tried on the officehome dataset with the same hyperparameters on 64x64 using the pytorch dassl repo for adamatch. I was not able to get good accuracy. Did you tried any?

Hi, I think that in an SSL setup unlike UDA, the target data cannot be used as a test set even though they have the same distribution.


chore: 0.9.0 release proposal

Release draft notes: https://github.com/open-telemetry/opentelemetry-js/releases/tag/untagged-acd870f90ae0100e6eb1

missing node-all, examples, and getting started

missing node-all, examples, and getting started

done.

Still don't see plugins-node-all. Looks like your branch is out of date so possible you just started making this before I merged the PR?

this is tiny but important fix, would be good to include it in this release as then it is also needed in next fix in user_interaction plugin
https://github.com/open-telemetry/opentelemetry-js/pull/1209

this is tiny but important fix, would be good to include it in this release as then it is also needed in next fix in user_interaction plugin
#1209

Sure, will wait for #1209 and if possible, #1202 and #1204

@open-telemetry/javascript-approvers This is ready to land now, please take a look one more time.


[Bug] : Footer Style changed in service page

@khushi-joshi-05
@sunny0625
check this out,

footer style changed in service page

This issue is already solved.
Try to contribute to different issues.


Release v2.8.0

Made the new release, v2.8.0!
Updated README.md to mention the supported Swift and Xcode versions.
Removed the link to maintainers' Slack workspace (#438).
Fixed bugs in Makefile to make a new release.

Merging this PR because this is a PR for a new release.


US79972: Update to Icons 3.

(Note that the major version bump in both icons and d2l-dropdown is just for the new icons.)


Correctly handle watchNamespace flag parsing errors

Previously, we shipped a feature (https://github.com/aws-controllers-k8s/code-generator/commit/d3b23cd5f4a9feae8cb30608e40aa4e18da8bcac) where multi-namespace watch
mode was supported. It turns out that the logic was completely flipped.
We need to assign namespace when the error is NIL and not vice versa. If
the error is NOT NIL, we need to block the controller initiation and
throw an error.
How did we catch this? Nothing special, just reviewing the generated
code and asking who on earth wrote that (me).
This indeed urges us to do proper CARM/multi-namespace/cross-region
testing and write some e2e tests that we can catch these issue very early on ...
When the code-generator PRs are drafted.
The current infra doesn't allow us to that, so we'll hack something
around next week.
Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/retest


llvmPackages_13.libcxx: require gcc >=10 on gcc platforms

Motivation for this change
ZHF: #144627 @NixOS/nixos-release-managers
Specifically aarch64-linux is targeted here. As of version 13 libcxx does not build on gcc9<EMAIL_ADDRESS>This is probably not the neatest way of doing this, mostly because it disobeys the stdenv that is passed in to the metapackage, instead sourcing it from pkgs in this case.
Most of the alternatives I could see though looked just about as bad. One possibility would be build all of llvmPackages_13 with gcc10, which could be done with a neater injection from all-packages.nix. But if a platform has stuck with gcc9, I'm assuming the issues with 10 are severe enough to not want to build an entire toolchain with it.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Seems sensible.


Fix instance segmentation by switching to Replicator APIs

Replicator semantic segmentation returns a dictionary called idToLabels that looks like: {'0': {'class': 'BACKGROUND'}, '2': {'class': 'agent'}}.
We also have a pre-existing mapping between class names and IDs (e.g. {'background: 555, agent: 1'}).
Since they don't match, preventing us from having access to global semantics information, we will need to remap the IDs on the semantic segmentation observations to our labels.


Support suffix

https://github.com/Tarrowren/css-class-intellisense/issues/15

What feature does this implement (the linked issue explains absolutely nothing)?

I added the suffix feature.
https://sass-lang.com/documentation/style-rules/parent-selector/

Why did you include selector? in the rule? It seems to work just as well without that.

suffix is used for className, which I think is close to classSelector.
suffix is not currently parsed correctly.

That doesn't answer my question about the use of selector? in the new rule at all. Attached patch implements this in a way that seems more correct to me.

Sorry, I misunderstood what you said. It's not appropriate to use selector? here.


Compiler Should Output .contract Bundle

Using Solang with Substrate  indicates that compiling a solidity file should output a .contract file containing wasm and json.
The Substrate UIs seem to prefer uploading a .contract file. While they do allow uploading .wasm and .json separately, the UI doesn't seem to handle multiple wasms and multiple jsons.
Let there be two contracts, ContractA and ContractB in one solidity source file.
$ solang_linux --target substrate MySource.sol
or simply (because substrate is the default):
$ solang_linux MySource.sol
Files produced:

ContractA.wasm
ContractA.json
ContractB.wasm
ContractB.json

Files expected:

MySource.contract

I'd like to advise which exact version but it looks like its not defined...
$ solang_linux --version
solang version

A fix for this issue was committed yesterday: https://github.com/hyperledger-labs/solang/commit/66ab8d013f7878491f9ef9ecb54eda2449ad8696
You can test this by using the latest docker image or using the debug artifacts generated here https://github.com/hyperledger-labs/solang/actions/runs/438060355


adding right click context menu to input fields

lets you have cut/copy/paste etc on input fields

@keybase/react-hackers

Do we have to do this for the main window?

:+1: % Q

@MarcoPolo added it, merging


Rclone set up

Just a suggestion: Dave Holland asked us to run a command before using rclone

Could this be added to this instruction document?
https://github.com/cellgeni/docs/blob/master/docs/source/rclone.rst
Thanks!

Hi @brianpenghe,
Sorry for the late update. This should be added in our next pull request.
Thanks!
Simon

Thanks for updating. He suggested that 1.60.1 is now installed.


Cant not move and resize

This Project can not move and resize in firefox browser.

Thanks for reporting this. I'll be investigating.

Entered here to report same thing!

Unfortunately, I have not found a fix to Firefox that doesn't involve rewriting the whole thing to not use Drag-and-Drop for the moving. Looking for suggestions.

Looks like I'll have to rewrite QWindow to use mouseup/mousedown/mousemove. :(

Hard work, has the problem been solved?

@liug74 no, sorry. I just had some back issues and just had an operation on Friday. Hoping I'll recover quickly so I can get onto this.

I wish you a speedy recovery and all the best!

All, I start physiotherapy tomorrow - thanks for the concern.

Sorry for not updating this one. The rewrite has occurred and all should be working now. Closing this ticket.


Fix lint issues for notifications app

Add module docstrings.
Rename object named arg to context_object in Notification.__init__() to avoid shadowing object
Eliminate some unused imports
add __all__ in __init__.py to indicate imports are intended to be re-exposed

Looks good! 👍  on the expanded documentation for everything too, it's much more helpful.


How to render HTML contained in a C# string

I have C# code that creates a string with HTML code, like this one
<!DOCTYPE html>

    <title>MathJax Test</title>

If this HTML is put in its own HTML cell, it renders correctly like this

But if I try to render the C# string containing the HTML, I only get the text.

How do I get the string to be interpreted and rendered as HTML?

This is happening because the Display method will HTML encode the string.
When you know that the string is already valid HTML and you don't want to encode it, you can use DisplayAs("text/html"):

It works, thanks!


#124 alternate target search

This is an approach to solve issue 124. It uses the normal search box on the whatsapp web website to find contacts and groups that match the search query.
Currently this search method has been added as an alternative in case an exception arises from the current search method

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- wplay/messageblast.py  1
- wplay/wchat.py  1
- wplay/messagetimer.py  1
- wplay/onlinetracker.py  1

Clones added
============
- wplay/messageblast.py  1
- wplay/wchat.py  1
- wplay/messagetimer.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- wplay/wchat.py  1
- wplay/onlinetracker.py  1
- wplay/messageblast.py  1
- wplay/messagetimer.py  1

Clones added
============
- wplay/wchat.py  1
- wplay/messageblast.py  1
- wplay/messagetimer.py  1

See the complete overview on Codacy

@amandhamija98 Please resolve the conflicts

Sorry I am not able to understand which conflicts.
Are you referring to things like clones added?

Sure, I'll just do that

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- wplay/messagetimer.py  1
- wplay/onlinetracker.py  1
- wplay/wchat.py  1
- wplay/messageblast.py  1

Clones added
============
- wplay/messagetimer.py  2
- wplay/wchat.py  1
- wplay/messageblast.py  2

See the complete overview on Codacy

Thankyou!


Remove Comcast copyright messages

This is all over the repository:
Copyright 2018 Comcast Cable Communications Management, LLC
However, we probably want to update this to something for the CNCF.

Also remove mentions of Comcast CLA as requested https://github.com/cncf/toc/issues/627.

If there are any copyright headers, just ensure they follow https://github.com/cncf/foundation/blob/master/copyright-notices.md

Seems like we can remove the headers from files in favor of a single file at the root of the repository.  We should look at a few other CNCF projects to see if we can find a good example.

https://github.com/cncf/foundation/blob/master/copyright-notices.md
I'd simply say "Copyright The Kuberhealthy Contributors" as one header
and "SPDX-License-Identifier:
Apache-2.0" as the other header for signifying license
On Wed, Jul 7, 2021 at 11:43 AM Eric Greer @.***> wrote:

Seems like we can remove the headers from files in favor of a single file
at the root of the repository. We should look at a few other CNCF projects
to see if we can find a good example.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kuberhealthy/kuberhealthy/issues/927#issuecomment-875759505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSIKEVVQEM4N7R5YLGNTTWR73XANCNFSM44ZEQRFQ
.

--
Cheers,
Chris Aniszczyk
https://aniszczyk.org


Config Context Schema Regression

Environment

Nautobot version (Docker tag too if applicable): 2.0.3-py3.9
Python version: 3.9
Database platform, version: Postgres 13
Middleware(s): Docker Compose

Steps to Reproduce

Navigate to Config Context
Add/Update Config Context
Nowhere to apply Config Context Schema

Expected Behavior

Observed Behavior

Looks like a miss in the field renaming in 2.0:
https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/templates/extras/configcontext_edit.html#L11
should be changed to {% render_field form.config_context_schema %} now.


Key Usage on IDevID CSR

We are seeing that the Key Usage Extension size seems wrong.  It seems that 6 bits are used when 9 is expected.

It is legal X.509 to only populate as many bits as are used in the bitstring. Are you seeing a parser that fails to parse this as-is?

Not an issue.


Tensorflow 2.0 tf.lite.TFLiteConverter.from_keras_model giving 'str' object has no attribute 'call'

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04 on Amazon EC2
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: no
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): tensorflow 2.0 rc1
Python version: 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: On CPU and on google colab also
GPU model and memory: On google colab,

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
It's not able to convert the LSTM model to tflite format
Describe the expected behavior
it should be able to convert the model to tflite format.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
converter = tf.lite.TFLiteConverter.from_keras_model("language_small_adam-01.hdf5")
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

AttributeError                            Traceback (most recent call last)
 in
1 import tensorflow as tf
----> 2 converter = tf.lite.TFLiteConverter.from_keras_model("language_small_adam-01.hdf5")
3 tflite_model = converter.convert()
4 open("converted_model.tflite", "wb").write(tflite_model)
~/anaconda3/envs/test/lib/python3.6/site-packages/tensorflow_core/lite/python/lite.py in from_keras_model(cls, model)
380       TFLiteConverter object.
381     """
--> 382     func = _saving_utils.trace_model_call(model)
383     concrete_func = func.get_concrete_function()
384     return cls([concrete_func])
~/anaconda3/envs/test/lib/python3.6/site-packages/tensorflow_core/python/keras/saving/saving_utils.py in trace_model_call(model, input_signature)
122   """
123   if input_signature is None:
--> 124     if isinstance(model.call, def_function.Function):
125       input_signature = model.call.input_signature
126
AttributeError: 'str' object has no attribute 'call'

LSTMs are currently a work in progress.
As we work on adding support, can you provide a minimal repro of your issue. Either provide the model or a modified version of the model / model code to help investigate the issue.

hi @gargn ,
Thanks for such a quick reply. Below is the code i used to generate the model. I used tf.keras for all the functions. Please find the model file below.
language_adam-01.zip
`inputs1 = Input(shape=(2048,))
fe1 = Dropout(0.5)(inputs1)
fe2 = Dense(256, activation='relu')(fe1)
inputs2 = Input(shape=(5,))
se1 = Embedding(vocab_size, embedding_dim, mask_zero=True)(inputs2)
se2 = Dropout(0.5)(se1)
se3 = LSTM(256)(se2)
decoder1 = add([fe2, se3])
decoder2 = Dense(256, activation='relu')(decoder1)
outputs = Dense(vocab_size, activation='softmax')(decoder2)
model = Model(inputs=[inputs1, inputs2], outputs=outputs)`
Please let me know if you need any further inputs from my side.

@gargn I tried replacing LSTM in above code with GRU, it's giving same error.

Hi,
Keras LSTM/GRU will not be supported in the current TOCO converter. We are working on a new TF Lite converter that could convert LSTMs nicely. Please stay tuned. Thanks!

Any update?

To try the new converter, use the tf-nightly pip package and then try:
converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter.experimental_new_converter = True
tflite_model = converter.convert()

Even with the tf-nightly package, I am getting the same error

@alokmalik I have updated your code with an experimental_new_convereter, then everything works as expected. Please take a look at the gist here. Thanks!
import tensorflow as tf
model=tf.keras.models.load_model("./language_adam-01.hdf5")
converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter.experimental_new_converter = True
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)

I am closing this issue as it was resolved by the new converter. Please feel free to reopen if the issue persists again. Thanks!

thanks @gargn @jvishnuvardhan , it's working now. I'll comment back if it doesn't work in mobile.

converter.experimental_new_converter = True
is is what I have been waiting for!
I can convert my model from .h5 to .tflite.
However, when I try to load this model to my Android APK, There are some problem:
I have class that loads .tflite model as byteBuffer and predict probabilities as following:
`public class TensorFlowLiteClassifier {
private Interpreter interpreter;
public static final String MODEL_FILE = "LSTM.tflite";
public static final int LABEL_NUM = 2;

/**
 * Registers interpreter
 * インタプリタの登録
 */
private TensorFlowLiteClassifier(Interpreter interpreter) {
    this.interpreter = interpreter;
}

/**
 * Loads model into interpreter
 * インタプリタにモデルを読み込み
 */
public static TensorFlowLiteClassifier classifier(AssetManager assetManager, String modelPath) throws IOException {
    ByteBuffer byteBuffer = loadModelFile(assetManager, modelPath);
    Interpreter interpreter = new Interpreter(byteBuffer);
    return new TensorFlowLiteClassifier(interpreter);
}

/**
 * Loads model
 * モデルの読み込み
 */
private static MappedByteBuffer loadModelFile(AssetManager assets, String path) throws IOException {
    AssetFileDescriptor file = assets.openFd(path);
    FileInputStream stream = new FileInputStream(file.getFileDescriptor());
    FileChannel channel = stream.getChannel();
    long startOffset = file.getStartOffset();
    long declaredLength = file.getDeclaredLength();
    return channel.map(FileChannel.MapMode.READ_ONLY, startOffset, declaredLength);
}

/**
 * Function that actually performs inference
 * 実際に推論を実行する関数
 */
public float[][] predictProbabilities(float[][] input) {
    float[][] output = new float[1][LABEL_NUM];
    interpreter.run(input, output);
    return output;
}

}`
An error occurred when creating a new intepreter from byteBuffer.
Interpreter interpreter = new Interpreter(byteBuffer);
Logcat is following:
2019-11-15 20:43:04.897 19973-19973/iis.kmjlab.kazuimotn.sartips A/libc: Fatal signal 11 (SIGSEGV), code 1, fault addr 0x70 in tid 19973 (zuimotn.sartips)
How can I deal with this unknown error?

@kazuimotn Can you please create a new issue so that it will be easy for others  to follow who have similar issue like to you. Thanks!

opened here

@alokmalik I have updated your code with an experimental_new_convereter, then everything works as expected. Please take a look at the gist here. Thanks!
import tensorflow as tf
model=tf.keras.models.load_model("./language_adam-01.hdf5")
converter = tf.lite.TFLiteConverter.from_keras_model(model)
converter.experimental_new_converter = True
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)

I am closing this issue as it was resolved by the new converter. Please feel free to reopen if the issue persists again. Thanks!

Hi,
I have a Bi-directional LSTM model and I want to use it with tflite. I get the following error while saving the model: TypeError: 'int' object is not callable.
I have tried the experimental converter, but nothing works.
Currently, I am using the tf_nightly-2.6.0.dev20210614 release. The same code worked for me with "tf-nightly-2.5.0-dev20201111" release.
Any leads on how to proceed further?

@prerna-khanna I think you'll have to use regular tensorflow version now, it's a 2 year old issue and the feature is out of beta testing(nightly build).

I am facing this kind of issue. tf-nightly and converter.experimental_new_converter = True are not solving the problem.
This is the error:
AttributeError                            Traceback (most recent call last)
 in <cell line: 7>()
5 converter.optimizations = [tf.lite.Optimize.DEFAULT]
6 #converter.experimental_new_converter = True
----> 7 q_aware_tflite_model = converter.convert()
5 frames
/usr/local/lib/python3.10/dist-packages/tensorflow/lite/python/lite.py in _freeze_keras_model(self)
1541     # to None.
1542     # Once we have better support for dynamic shapes, we can remove this.
-> 1543     if not isinstance(self._keras_model.call, _def_function.Function):
1544       # Pass keep_original_batch_size=True will ensure that we get an input
1545       # signature including the batch dimension specified by the user.
AttributeError: 'float' object has no attribute 'call'


Mouse text selection copies to wayland clipboard

Description of the problem or steps to reproduce
Default config. Clipboard: external. wl-clipboard installed. Mouse: on
wl-paste show selected text in micro with mouse. If select with clipboard, clipboard stays the same.
Specifications
Well. I can't find any info about this, but I don't want to copy anything with mouse selection.
On another machine, NixOS, KDE, Xorg - clipboard manager ignore this kind of selection while they still appear in  xclip -o.

Commit hash: 225927b9
OS: Arch, hyprland (clipman / cliphist)
Terminal: Any? (Alacritty, kitty, konosle)

Seems I was using "Primary" clipboard and wasn't knew it.
https://wiki.archlinux.org/title/Clipboard#Selections

I've found an solution!
Actually I'm not insane yet and the issue was caused by wl-clipboard-x11 !
After removing package, setting clipboard to external clipboard works as it should be!
Please add to wiki


Add player please

Hey. I really like your app. But I beg you to add a player, with the ability to rewind, by clicking on the playback bar (as it works in any player). Just, you know, it's a little inconvenient when I listening a song with lyrics, want to rewind, and I have to open Spotify and then go back....
If you agree to add this, it would be cool if the player bar was pinned, that when you read the last verse, and you wanted to pause - didn't have to scroll to the top. Hope you know what I mean)

Hi, thanks for the suggestion.
I get what you mean :slightly_smiling_face:
This isn't planned for now as it's outside the initial scope of the project, and it would require significant changes both in the API and frontend part.
However I'll keep this issue open, maybe one day I'll implement it!


[Wave 6: Drafts] Migrate the next steps to client side wherever it makes sense

Part of https://github.com/Expensify/Expensify/issues/308213
Coming from here in the doc, we are planning to migrate some of the next steps which make sense to do so to be client side/ optimistic.

I think this one might go to @rezkiy37 per slack discussion

Can you comment on this issue @rezkiy37?

Can you comment on this issue @rezkiy37?

AFAIK, it is a general issue and does not require any actions now. Slack thread.

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

it is still a general issue and does not require any actions now. Slack thread.

Yeah I think we actually can focus on other stuff which brings us more value than this right now.

Repening now as we are in spot where this makes more sense

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

Working on the issue.

Actively working on the issue. I've opened a draft PR, it is not ready for review yet.

Actively working on the issue.

@mountiny, I've opened an additional PR. Please take a look 🙂

Integrated last business day logic.

@rezkiy37 let me know when its ready for review

Preparing the PR to review. Writing a description to cover all possible scenarios.

Finishing with the draft PR. Currently, recording videos.

@mountiny, just opened the PR for review.

Regression Test Proposal:

Create/have 2 users at least. One of them is a member of workspaces. The 2nd one is an admin.
Create/have 2 paid workspaces via OD: Collect and Control. The feature does not work for a free workspace.
Use OD to manipulate with the workspaces.

1. Generates an optimistic nextStep once a report has been OPENED
1. Self review

The member: opens a workspace chat.
The member: requests money.
The member: Verify that there is a next step with a comment: "Waiting for you to submit these expenses." and label is "Next Steps".

2. Scheduled submit enabled

The admin: sets "Scheduled Submit" enabled via OD in the "Reports" section.
The admin: selects each value one by one. The label is "Next Steps" and corresponding comments:

Daily: "These expenses are scheduled to automatically submit later today! No further action required!";
Weekly: "These expenses are scheduled to automatically submit on Sunday! No further action required!";
Twice a month: "These expenses are scheduled to automatically submit on the 1st and 16th of each month! No further action required!";
Monthly: "These expenses are scheduled to automatically submit on the [Selected report submission date] of each month! No further action required!";
Trip: "These expenses are scheduled to automatically submit at the end of your trip! No further action required!";
Manual: "Waiting for you to submit these expenses.";

The member: requests money.
The member: Verify that there is a next step with a corresponding comment mentioned above.

3. Self submitting prevented

The admin: sets "Prevent Self-Approval" enabled via OD in the "Members" section > "Workflow Enforcement".
The admin: requests money.
The admin: Verify that there is a next step with a comment: "Oops! Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy. Please submit this report to someone else or contact your admin to change the person you submit to." and label is "Next Steps".

2. Generates an optimistic nextStep once a report has been SUBMITTED
1. Self review

Do steps: 1.3.
The admin: clicks on a "Submit" button.
The admin: Verify that there is a next step with a comment: "Waiting for you* to review these expenses." and label is "Next Steps".

2. Another reviewer

Do steps: 1.1.
The member: clicks on a "Submit" button.
The member: Verify that there is a next step with a comment: "Waiting for [the admin's display name]* to approve these expenses." and label is "Next Steps".

3. Another owner

Do steps: 1.1.
The admin: clicks on a "Submit" button.
The admin: Verify that there is a next step with a comment: "[the member's login]* is waiting for you to review these expenses." and label is "Next Steps" and label is "Next Steps". However, when you are not a manager a verb review is replaced with approve.

3. Generates an optimistic nextStep once a report has been APPROVED
1. Self review

Do steps: 1.3 and 2.1.
The admin: clicks on an "Approve" button.
The admin: Verify that there is a next step with a comment: "Waiting for you* to review these expenses." and label is "Next Steps".

2. Another owner

Do steps: 1.1 and 2.3.
The admin: clicks on an "Approve" button.
The admin: Verify that there is a next step with a comment: "No further action required!" and label is "Finished!".

4. Generates an optimistic nextStep once a report has been PAID
1. Paid with wallet

Do steps: 1.1 and 2.3, 3.1 or 3.2.
The admin: clicks on a "Pay elsewhere" button.
The admin: Verify that there is a next step with a comment: "You have marked these expenses as paid." and label is "Finished!".

2. Paid outside of Expensify

Do steps: 1.1 and 2.3, 3.1 or 3.2.
The admin: clicks on a "Pay with Expensify" button.
The admin: Verify that there is a next step with a comment: "You have marked these expenses as paid outside of Expensify." and label is "Finished!".

Do we agree 👍 or 👎

I've updated a value usage because of https://github.com/Expensify/App/issues/35398.

Thanks for this update, that will be helpful

@allroundexperts taking on the testing

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@allroundexperts this is an issue, not the PR

I did realise that instantly and deleted 😆

PR in review!

Just taken the deploy blocker issue. Going to fix it soon.

I believe this is going to be ready for a review.

Contributor+: @allroundexperts owed $500 via NewDot
Do we need to update or create a new regression test here? Seems like we might want a new one?

@mallenexpensify Yep, we'll have to create a new one. The test steps given in the PR description here look comprehensive enough to me. Let me know if you need any help with those.

Yep I think we should create new ones here, I have asked @rezkiy37 if he could clean them up for the regression testing purpose

On a side note, this PR caused a bug so the payment should technically be 1/2. Although, I think this was a complex PR which took me some time to review, so if we can waive the penalty, that would be great. Please let me know.

I think that we should not decrease payment because of that. The Cancel Payment was a new feature added along with this so it was hard to notice regression like this

@mallenexpensify Michal has actually already written the tests here https://github.com/Expensify/App/issues/28771#issuecomment-1916873382

Thanks all! We should be set. TestRail GH is here

https://github.com/Expensify/Expensify/issues/372499

$500 approved for @allroundexperts based on this summary.


AF2 dataset download, docker login, and minimum hardware requirements

This is very well-written workflow with clear instructions. Great job!
I noticed a couple of things:

docker compose up does not seem to download the AF2 dataset properly. This results in dataset not found issue when trying to run health check. Similar health checks passed for Diffdock and MolMIM, but not for AlphaFold.
To solve the issue above I launched the AlphaFold2 NIM standalone, like here: https://docs.nvidia.com/nim/bionemo/alphafold2/latest/quickstart-guide.html . The data folder should have a size of ~500GB if correctly downloaded.
I tested in SageMaker Notebook instance.  Before running docker compose up, I had to do docker login with username as oauthtoken and password as NGC API key. Otherwise it seems to generate a not authorized error even though I have both NGC_API_KEY and NGC_CLI_API_KEY set up as env variables.
The https://build.nvidia.com/nvidia/generative-virtual-screening-for-drug-discovery/blueprintcard says the minimum requirement is 1xA6000, A100, or H100. I was able to run the notebook on 1xA10 (g5.16xlarge AWS) with 24GB GPU memory. Just FYI.

Thanks very again for the effort of putting this together!

Minimum GPU requirements should be in the readme in this repo in case users get here without first passing through the build.nvidia.com page.


change content and reply data to type any

this should address #222

The reply code is:
json.NewEncoder(w).Encode(replyData)

I think that will still work for anything, string, etc. no?

https://github.com/TIBCOSoftware/flogo-contrib/blob/master/activity/reply/activity.go line 43

ahh, sorry, was just looking at the rest trigger... yup, should change that also

personally i feel we should just depreciate the legacy reply activity...

@lixingwang changed to TypeAny


ProApps Folder Issue

I just bought BRAW Toolbox so I can edit on Final Cut with my Blackmagic camera, and downloaded the app. It won't let me install the metadata view or LUT's into the ProApps folder on my computer. The only ProApps folder I can find is in Library then Application Support then ProApps Folder. But this does not work. What should I do?

Sorry you're having issues!
Can you please share your log files as explained here?
https://brawtoolbox.io/troubleshooting/#ive-run-into-a-bug-where-can-i-find-the-log-files

I shared the files like you suggested and haven't heard back. I just want to make sure I did what was needed. Thank you for your help. From what I can tell, I can still work with BRAW files as of now even without the metadata or LUT things installed.

Apologies for the delayed reply - funnily enough someone else had this issue, and I thought I was replying to you via email!
It looks like you selected /Volumes/Nemeth Drive 2/BRAW Toolbox, whereas you should have selected /Users/mnemeth/Movies.
Please quit Final Cut Pro and BRAW Toolbox, and enter this in Terminal:
/usr/bin/defaults delete com.latenitefilms.BRAWToolbox

If Terminal is too scary, you can also do it manually via these instructions:
https://brawtoolbox.io/troubleshooting/#failed-to-install-motion-template-metadata-view-or-luts
Then try install the Motion Templates again, making sure you use their default paths as explained here:
https://brawtoolbox.io/installation/
And yes, BRAW Toolbox will still work without the LUTs and Metadata. The LUTs are only used for HDR workflows, and the Custom Metadata View is just an extra Metadata View for the Info Inspector - it doesn't affect BRAW playback.
Hope this helps!