refactor(execution): replace StateChangesCount::from with state_chang…

…es.count()

This change is

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f4bdfe) 68.86% compared to head (673486a) 68.94%.

Files
Patch %
Lines

crates/blockifier/src/state/cached_state.rs
88.88%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@               Coverage Diff                @@
##           main-v0.13.1    #1452      +/-   ##
================================================
+ Coverage         68.86%   68.94%   +0.08%
================================================
  Files                58       58
  Lines              7872     7861      -11
  Branches           7872     7861      -11
================================================
- Hits               5421     5420       -1
+ Misses             1995     1985      -10
  Partials            456      456

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Autocomplete with tab inserts weird special character, have to click instead (macOS)

I've tried to find a duplicate issue but can't, I hope this is a unique ticket, apologies if not.
I've tried oni2 on two macbooks and they both had this issue. Not sure if it's mac specific though.
OS: Catalina, 10.15.6
Oni2: 0.5.1-nightly
As per the below gif, hitting tab when auto-completing renders a weird special character.

From reading other issues, this is not the intended behaviour.

This looks like the same as #2477. Would be useful to get some of the same logging for you, and posted in that issue (oni2 -f --debug, with the CLI instructions over here :  https://onivim.github.io/docs/using-onivim/command-line).
It looked like a font fall back issue, but its odd that its happened a bunch recently, and not a few weeks ago when none of that code has changed (that I remember).


Added to README steps for testing the mailout plugin with CURL.

Additions and modification to README, along with a spelling correction.

Please fix the merge conflicts ;-)

Sorry about that. I don't do PRs a lot so I skipped the merge from upstream. This should be okay now.

Thanks


\thisframeRTL from bidi package not working across page boundaries

Here is the source for an article in Urdu that spans across multiple pages.
https://gist.github.com/deepakjois/79e89961b60de2e61e44
Note the call to \eject\par followed by \thisframeRTL in the middle. If I remove that, the next page is typeset LTR.

That's by design - \thisframe... really does mean this frame. What we probably need is an option on the document class (perhaps the plain class) which declares all its default frames to be RTL. Would you be interested in trying to implement that?

Yes, sure I could give it a try.

I've just implemented this in the simplest way possible with 97aedbe


Ensure Riak clients are properly cleaned up

This builds on praekelt/vumi#957.

Although Travis is configured to run the tests with manager closed assertions enabled, we don't yet have a vumi release with that functionality.

I'm wondering whether it would be cool to make the VumiApi a context manager so we can do with get_vumi_api() as api: ...?

I thought about that, but there are a lot of places (especially in the async stuff) where the creation and cleanup happen in different places.

I was thinking mostly for use in Django land.

Ready for another review.

:+1:


Initial working version

Also, if someone has little time, the main question I'd like answered is your opinion on which of the 2 API you'd keep. I want to remove one of them I think.

I've removed the flat API. This let me simplify few things a little.

Ok, so I'll push the match arm merge now. Accept then, I'll squash it all and merge.


Doc review

This is for the doc review task #37
Nothing fancy here, just some minor grammar fixes and whatnot.

LGTM! Thanks,


compile assets if missing for staging

used in staging env related to #1286

my bad thought staging was running under foreman not supervisor.


Fix index page delete fade out

Pretty self explanatory I think. I didn't see a test for this feature and wasn't sure how you would want to go about testing it, but I'm happy to add a test if you point me in the right direction.

Also, it seems like these two string should be generated by the same function, but again, I wasn't sure what you would want to call it. I found these relevant functions in Helpers: get_resource_model/1,  resource_identity/1, and model_name/1, but none of them do quite what we need here.

Maybe model_id?

model_id sounds good. thansk


Suggestion: Generate image previews using Vercel

Saw that your images seem to include an upload-to-imgur step that's running into API limits. Obviously, you could upload to a cloud service (GCP, AWS) instead, but I'd actually suggest rendering a dynamic image using Vercel -- it's actually really easy!
Manifold did this basically by copying https://github.com/vercel/og-image and tweaking it, resulting in a nice preview image that gets rendered whenever a link is posted on Twitter/Discord/etc. Happy to share our code if it'd help, or explain more!
(Sidenote: from a UX perspective, would be cool if Capture was a thing you could get by clicking on an "image"/"share" icon directly from the main Metaforecast site; right now, it's fairly hard to discover)

Beautiful, thanks for the suggestion!

Happy to share our code if it'd help, or explain more!

Yeah, would appreciate this.


Disposable/release 2016 data esa new land

Overview
This Pull Request releases the following features:

Updated Tree Cover Loss data for 2016;
ESA Land Cover layer updates;
New information architecture;
Updates to the country page navigation;

This brings to master the following PRs:

https://github.com/Vizzuality/gfw/pull/2995
https://github.com/Vizzuality/gfw/pull/3000
https://github.com/Vizzuality/gfw/pull/3008
https://github.com/Vizzuality/gfw/pull/3012
https://github.com/Vizzuality/gfw/pull/3017
https://github.com/Vizzuality/gfw/pull/3018
https://github.com/Vizzuality/gfw/pull/3022
https://github.com/Vizzuality/gfw/pull/3035
https://github.com/Vizzuality/gfw/pull/3036
https://github.com/Vizzuality/gfw/pull/3037
https://github.com/Vizzuality/gfw/pull/3038
https://github.com/Vizzuality/gfw/pull/3041
https://github.com/Vizzuality/gfw/pull/3063
https://github.com/Vizzuality/gfw/pull/3079
https://github.com/Vizzuality/gfw/pull/3080
https://github.com/Vizzuality/gfw/pull/3082
https://github.com/Vizzuality/gfw/pull/3083

Tested and approved by Ben, José and myself.


[TaskManager] Rename package to @fluidframework/task-manager

Description
This PR moves the TaskManager package from the @fluid-experimental group to @fluidframework. This marks TaskManager as a production-ready package.
Does this introduce a breaking change?
Yes, all imports will need to be updated from @fluid-experimental/task-manager to @fluidframework/task-manager.
Reviewer Guidance
Should this be in main or next? Technically it is a breaking change but since was an experimental package we are allowed to make breaking changes in main.
Other information or known dependencies
AB#1589

We'll need to correctly handle the detached scenario as a prerequisite for moving out of experimental (otherwise this corrupts documents).  Adding a "clicker" component in the "spaces" demo exhibits this bug currently, as the TaskManager volunteers while in detached state (and then other clients see the volunteer op before the attach op).


Enable contributions

merge only once:

[ ] crowdloan is registered on Kusama
[ ] crowdloan id has been updated in code
[ ] successful contribution with local deployment of page

thank you @Alirazadar . looks perfect


Updating/Nuking cache after mutation

Hi, first of all, let me thank you for this, this code and graphql-sequelize are magic 🎉
I've got a recurrent issue, which is an update of nested association when Creating/Updating the database.
Example
user {
  images
}

if I add a new image to the association, lets say its many to many between user and images, on the next request the server will return cached results
GQL definition like this
const user = new GraphQLObjectType({
  name: 'User',
  fields: () => ({
    images: {
      type: new GraphQLList(image),
      resolve:  resolver(models.User.Images)
    }
  })
})

My only current solution is to disable the data loader, like this (using ramda omit)
const user = new GraphQLObjectType({
  name: 'User',
  fields: () => ({
    images: {
      type: new GraphQLList(image),
      resolve: (source, args, context, info) => resolver(models.User.Images)(source, args, omit([EXPECTED_OPTIONS_KEY], context), info)
    }
  })
})

Clearly, this is wrong and it's creating some issues, I'm thinking I need to probably do something to the context on the Create/Update sequelize call, but haven't found any documentation pointing to that!

it sounds like you've created a dataloader instance globally instead of on a request basis. Can you show where you're creating such an instance?
If you do it on a request basis then it only caches and dataloads per request

🤯
Well. I guess that is why I had to hack everything!
👏 👏 👏
Thanks for that!


Pin z3-solver on macOS VMs

Summary
We currently use macOS 11.7 images in our CI and CPython 3.8 for the all-optionals test run.  z3-solver recently released <IP_ADDRESS>, which upped the macOS platform version from 10.16 to 11.7.  This in theory should be fine for our VM image, but the pre-built version of CPython 3.8 we have access to was built for an older macOS, so does not match a macos_11_7_x86_64 platform tag, and forces us to build Z3 from source, often timing out the job.
This should have no effect on user machines, which will be typically be using newer versions of Python, or will be able to install from source if required.
This CI-only constraint can be relaxed when the version of CPython we use on the macOS VMs supports the 11.7 macOS API version.

Details and comments

If we start having these problems a lot more[^1] we can potentially look at managing CPython through Homebrew or Conda on the image machines, but I'm somewhat unkeen to take that step unless we have to, since it'll add a non-trivial amount of install/build/configuration time to every macOS CI job.
[^1]: Qiskit supports all CPythons through to their EOL, which is unusually long, but driven by us being aware of backend deployments of us that update Python very infrequently.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
21 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.01%) to 87.54%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
93.76%

crates/qasm2/src/lex.rs
6
91.41%

crates/qasm2/src/parse.rs
6
97.6%

crates/accelerate/src/quantum_circuit/circuit_data.rs
8
90.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
59763

Relevant Lines:
68269

💛  - Coveralls


Calendar Scroll Paged performance issue

Library information:

Version: 2.6.1
Compose module

Describe the bug**
Hi! Thank you so much for the library!
In example 8 (compose), when pagination is enabled (calendarScrollPaged = true) - interaction with the user interface is very slow.
To Reproduce (if applicable)

Open example 8 in compose
Scroll
Wait near 1+ second for  user can interact (pick date)

I think this is because we use rememberFirstVisibleMonthAfterScroll which waits until the list stops scrolling. You can use rememberFirstCompletelyVisibleMonth to get a better visual experience.

I think this is because we use rememberFirstVisibleMonthAfterScroll which waits until the list stops scrolling. You can use rememberFirstCompletelyVisibleMonth to get a better visual experience.

I mean interaction with interface, not visual experience.
Try to swipe and immediately tap on the date – it won’t work; there will be a one-second delay.


fix Support converting '.NET Long Running Task' to the numeric thread #177

@Audela-220 can you please rebase your branch onto Feature/111-...
This is currently our development branch.

@FreeAndNil
Thanks for the comment.
Feature/111 branch is gone and I'm not sure what to do about it.
Sorry, this is actually my first Github operation.
Could you please fix it for me instead?

Hi @Audela-220,
we merged Feature/111 about two hours ago.
Sorry for the inconvenience.
I'm already on a fix for this issue.
Would you be able to test a preview version (we would provide to you)?

@Audela-220 I created #180


Added Group repo

Also straightforward.

Add a note saying that the keys are what has been removed.

Anything missing for the merge?

This is missing repo stat

Needs:

[ ] Add note about keys
[ ] Add in repo stat
[ ] Check all commands
[ ] Update headers

Opened. https://github.com/ipfs/go-ipfs/pull/2585


[Bug] Output directory in config

What version of vite are you using?
0.2.4
System info and storybook versions
Environment Info:
System:
OS: macOS 12.6
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Binaries:
Node: 16.17.0 - /usr/local/opt/node@16/bin/node
npm: 8.15.0 - /usr/local/opt/node@16/bin/npm
Browsers:
Chrome: 106.0.5249.119
Firefox: 103.0.2
Safari: 16.0
Describe the Bug
Deploying to github pages requires a subpath but config.output doesn't exist on viteFinal so where do i set the path from assests? https://poketrax.github.io/tcg-case/ is my deployment and it's looking for /assests/* instead of assets/*
Link to Minimal Reproducible Example
https://github.com/poketrax/tcg-case
Participation

[ ] I am willing to submit a pull request for this issue.

@jgunzelman88 you can set the base to './'.  See https://vitejs.dev/config/shared-options.html#base for details.
@yannbf here's an example of an issue that would be solved by https://github.com/storybookjs/storybook/pull/19383


[Workbox wizard] (rood directory question) Not allowing to manually set the path

Library Affected:
workbox-cli
Browser & Platform:
Node v15.3.0.
Issue or Feature Request Description:
While working on #2758 and testing the changes locally I saw there is an issue with the workbox wizard when prompted with the question for root directory of your web app.
I tested this behavior both with the v6 working git branch as well as with the @latest stable (npm published) version of workbox-cli package v6.1.0; the bug is present on both versions.
When prompted for the root directory of web application, based on the current working directory the user is given n+2 options:

n - number of directories in the project (current working directory, from which the workbox wizard command was executed),
n+1 - separator (that shouldn't be a valid option to select from the list - which isn't the case and might be confusing for the user),
n+2 - Manually enter path option which always results in error - The path you entered isn't a valid directory., as the user is never given an input to manually enter the path (as per question).

You can see the described behavior in the attachment below:

Steps to reproduce the issue :

Create a blank directory and navigating to it - you can do so by running mkdir test-workbox-wizard && cd test-workbox-wizard,
Create a few sub-directories inside your newly created directory (i.e. test-workbox-wizard) - by running mkdir src && mkdir dist,
Run the workbox wizard with a command (if installed globally as an npm package) - by running workbox wizard,
By choosing Manually enter path option, wizard always results in an error.

I'll be able to address this issue on my own and provide a PR in the upcoming days, as I'm somewhat familiar with the workbox-cli package (after making my first PR today).
I'll be more than glad to provide further contributions to the workbox project.
Please, do feel free to assign this issue to me after performing the necessary triage 🙂 .
Thanks!

Thanks again! You changes are released as part of https://github.com/GoogleChrome/workbox/releases/tag/v6.1.2

Thank you so much for the attribution and the opportunity to contribute back to the amazing workbox project 🙂 .


change JWT->Oauth2

change JWT->Oauth2

Codecov Report
Patch coverage has no change and project coverage change: +0.08% :tada:

Comparison is base (b465631) 25.46% compared to head (86bedc8) 25.55%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
+ Coverage   25.46%   25.55%   +0.08%
==========================================
  Files         262       40     -222
  Lines       30304     8657   -21647
  Branches     5116        0    -5116
==========================================
- Hits         7716     2212    -5504
+ Misses      22326     6314   -16012
+ Partials      262      131     -131

Flag
Coverage Δ

adapter
25.55% <ø> (-0.02%)
:arrow_down:

common-controller
?

config-deployer-service
?

idp-domain-service
?

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 223 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hi, i'm getting this error while deploying my dotnet Razor pages app to Google Cloud

Build started 25/02/2022 10:20:54 am.
Project "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj" on node 1 (Publish target(s)).
GenerateTargetFrameworkMonikerAttribute:
Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
CoreGenerateAssemblyInfo:
Skipping target "CoreGenerateAssemblyInfo" because all output files are up-to-date with respect to the input files.
_DiscoverMvcApplicationParts:
Skipping target "_DiscoverMvcApplicationParts" because all output files are up-to-date with respect to the input files.
_CoreGenerateRazorAssemblyInfo:
Skipping target "_CoreGenerateRazorAssemblyInfo" because all output files are up-to-date with respect to the input files.
CoreCompile:
Skipping target "CoreCompile" because all output files are up-to-date with respect to the input files.
_CreateAppHost:
Skipping target "_CreateAppHost" because all output files are up-to-date with respect to the input files.
GenerateStaticWebAssetsManifest:
Skipping target "GenerateStaticWebAssetsManifest" because all output files are up-to-date with respect to the input files.
_GenerateScopedCssFiles:
Skipping target "_GenerateScopedCssFiles" because it has no outputs.
ResolveTagHelperRazorGenerateInputs:
Skipping target "ResolveTagHelperRazorGenerateInputs" because all output files are up-to-date with respect to the input files.
RazorCoreGenerate:
Skipping target "RazorCoreGenerate" because all output files are up-to-date with respect to the input files.
CoreGenerateRazorTargetAssemblyInfo:
Skipping target "CoreGenerateRazorTargetAssemblyInfo" because all output files are up-to-date with respect to the input files.
RazorCoreCompile:
Skipping target "RazorCoreCompile" because all output files are up-to-date with respect to the input files.
_CopyFilesMarkedCopyLocal:
Touching "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\BrainXero.Medgic.Web.csproj.CopyComplete".
GetTypeScriptCopyToOutputDirectoryItems:
Adding items with BuildAction=TypeScriptCompile to the same collections that will be populated (with items of other BuildActions) by the GetCopyToOutputDirectoryItems target
_CopyOutOfDateSourceItemsToOutputDirectory:
Skipping target "_CopyOutOfDateSourceItemsToOutputDirectory" because all output files are up-to-date with respect to the input files.
GenerateBuildDependencyFile:
Skipping target "GenerateBuildDependencyFile" because all output files are up-to-date with respect to the input files.
GenerateBuildRuntimeConfigurationFiles:
Skipping target "GenerateBuildRuntimeConfigurationFiles" because all output files are up-to-date with respect to the input files.
CopyFilesToOutputDirectory:
BrainXero.Medgic.Web -> E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\bin\Release\net5.0\BrainXero.Medgic.Web.dll
_RazorCopyFilesToOutputDirectory:
BrainXero.Medgic.Web -> E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\bin\Release\net5.0\BrainXero.Medgic.Web.Views.dll
Touching "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\BrainXero.Medgic.Web.csproj.CopyComplete".
_CopyResolvedFilesToPublishPreserveNewest:
Skipping target "_CopyResolvedFilesToPublishPreserveNewest" because all output files are up-to-date with respect to the input files.
Publish:
BrainXero.Medgic.Web -> E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\bin\Release\net5.0\publish
_TransformWebConfig:
Updating web.config at 'E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\bin\Release\net5.0\publish\web.config'
_PrepareForMsDeployPublish:
Deleting file "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\PubTmp\BrainXero.Medgic.Web.SourceManifest.xml".
Deleting file "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\PubTmp\BrainXero.Medgic.Web.Parameters.xml".
Creating "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\PubTmp\BrainXero.Medgic.Web.SourceManifest.xml" because "AlwaysCreate" was specified.
Creating "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\PubTmp\BrainXero.Medgic.Web.Parameters.xml" because "AlwaysCreate" was specified.
MSDeployPublish:
Starting Web deployment task from source: manifest(E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\obj\Release\net5.0\PubTmp\BrainXero.Medgic.Web.SourceManifest.xml) to Destination: auto().
C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk.Publish\targets\PublishTargets\Microsoft.NET.Sdk.Publish.MSDeploy.targets(140,5): error : Web deployment task failed. (Connected to the remote computer ("<IP_ADDRESS>") using the Web Management Service, but could not authorize. Make sure that you are using the correct user name and password, that the site you are connecting to exists, and that the credentials represent a user who has permissions to access the site.  Learn more at: https://go.microsoft.com/fwlink/?LinkId=221672#ERROR_USER_UNAUTHORIZED.) [E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj]
C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk.Publish\targets\PublishTargets\Microsoft.NET.Sdk.Publish.MSDeploy.targets(140,5): error : Make sure the site name, user name, and password are correct. If the issue is not resolved, please contact your local or server administrator. [E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj]
C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk.Publish\targets\PublishTargets\Microsoft.NET.Sdk.Publish.MSDeploy.targets(140,5): error : Error details: [E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj]
C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk.Publish\targets\PublishTargets\Microsoft.NET.Sdk.Publish.MSDeploy.targets(140,5): error : Connected to the remote computer ("<IP_ADDRESS>") using the Web Management Service, but could not authorize. Make sure that you are using the correct user name and password, that the site you are connecting to exists, and that the credentials represent a user who has permissions to access the site.  Learn more at: https://go.microsoft.com/fwlink/?LinkId=221672#ERROR_USER_UNAUTHORIZED. [E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj]
C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk.Publish\targets\PublishTargets\Microsoft.NET.Sdk.Publish.MSDeploy.targets(140,5): error : The remote server returned an error: (401) Unauthorized. [E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj]
Publish failed to deploy.
Done Building Project "E:\brainXero\Medgic app\BrainXero.Medgic\BrainXero.Medgic.Web\BrainXero.Medgic.Web.csproj" (Publish target(s)) -- FAILED.
Build FAILED.

I'm afraid we'll need a lot more context information. We know that you're deploying to Google Cloud, but we don't know anything more than that - is this a VM? Is it Windows or Linux? How are you attempting to authenticate? Has this ever worked, or is this the first time you've tried to deploy?
Please give us more information, and we'll see if we can help you.

Closing due to lack of information. We can reopen if we receive more information.


Create Terraform for IAM and OpenSearch in MCP

💡 Description
Terraform for IAM and OpenSearch to hand over to SA team
⚔ Parent Epic / Related Tickets
Currently running into issues with OpenSearch workflow, I will update ticket once done.

The code is going to be in the pds-mcp-infra repo.

@sjoshi-jpl there should be a link to a PR or commit identifier in the pds-mcp-infra repository before we can close this ticket.

@sjoshi-jpl any PR to link that ticket to ?

Hi @sjoshi-jpl , we should have a PR or a commit linked to this ticket.

Status: @sjoshi-jpl to push PR

@sjoshi-jpl any updates on this ticket ?


Spaces in path break ESLint

Issue:
If there are spaces in your path (e.g. ~/Developer/React Native/ExAlbums/App.js), ESLint stops working. Get rid of the spaces (e.g. ~/Developer/ExAlbums/App.js) and ESLint works as expected. Didn't test with other linters.
Setup:

ALE, HEAD-5582711
Neovim 0.2.0, built from source
zsh 5.3.1
macOS Sierra 10.12.3

:ALEInfoToClipboard output:

Current Filetype: javascript.jsx
Available Linters: ['eslint', 'flow', 'jscs', 'jshint', 'standard', 'xo']
Enabled Linters: ['eslint']
Linter Variables:
let g:ale_javascript_eslint_executable = 'eslint'
let g:ale_javascript_eslint_options = ''
let g:ale_javascript_eslint_use_global = 0
Global Variables:
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '[%linter%] %s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 0
let g:ale_lint_on_text_changed = 1
let g:ale_linter_aliases = {}
let g:ale_linters = {'html': ['tidy'], 'javascript': ['eslint']}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '!!'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_warn_about_trailing_whitespace = 1
Command History:
(finished - exit code 1) 'eslint  -f unix --stdin --stdin-filename /Users/leon/Developer/React\ Native/ExAlbums/App.js < /var/folders/3c/p9rgsvgd1sj26j5tyt5t91rc0000gn/T/nvimOSgNTQ/5/App.js'

Oh! I hate those kinds of issues. I try to be vigilant to step them. I'll see if I can fix this soon.

Can you create some files and a directory structure which will repeat this problem? I just tried creating a directory with spaces in it, and a filename inside of that with spaces in it, and I can see the warnings and errors. Is there perhaps some other issue? What's the output of eslint --version?

Output of eslint --version:

v3.8.1

The problematic directory structure is like this:
/Users/leon/Developer/React\ Native/ExAlbums/App.js
Not sure if it matters, but here are a few more observations:

There is a space in one of the directory names, but none in the file being edited.
The directory structure is generated by the npm module create-react-native-app, but the same issue is present in a manually created directory (e.g. /Users/leon/Developer/React\ Native/sandbox).
I had ESLint installed both globally and locally, but the issue persists after I have uninstalled the global copy of ESLint.
Specifying "installedESLint": true in .eslintrc does not resolve the issue.
ESLint works in Atom under all scenarios.

I'm beginning to wonder if this issue is macOS-specific. In any case, it can be easily avoided by replacing the spaces in directory names with hyphens. I'm just glad I finally figured out why ESLint in Neovim sometimes works and sometimes doesn't.
P.S. Thanks for the quick replies.
P.P.S. ALE rocks 😄

I might try using create-react-native-app myself, and see what happens.

I was never able to reproduce this.

On my Windows machine :AESInfo for tslint with space in path gives error:

Why is here path to tslint doesn't wrapped with quotes?
Path without space gives working output of tslint:

That's a separate bug, and I shall fix that now.


⚠ BeyondHD has degraded performance

In 1887080, BeyondHD ($BHD) experienced degraded performance:

HTTP code: 200
Response time: 1078 ms

Resolved: BeyondHD performance has improved in 472bad2.


Older version of Rich Text dependency

I am running into errors with the processing rich text fields that have superscripts in them. It seems to be due to the fact that the version of contentful/rich-text required in this package is an older one that doesn't include these html tags. Is it possible to update the Composer requirements to use the more updated versions of the dependencies for this SDK.

Should be fixed with v9.0.0


fix futures for python 3.8 and enable python 3.8 builds

closes #370

I'm still not sure why some of the tests pass in 3.6 but not 3.8 (e.g., this one) without explicitly setting daemon=True so that polling threads don't keep the Python (or pytest) process from quitting.
From the threading.Thread docs:

Its initial value is inherited from the creating thread; the main thread is not a daemon thread and therefore all threads created in the main thread default to daemon = False.
The entire Python program exits when no alive non-daemon threads are left.

After further consideration, I think it probably makes the most sense to just override set_result and set_exception.  It might be annoying to keep those in sync, but the workarounds seem ugly.


Update manifest for the test release 0.15-alpha

Fixes #
Proposed Changes

Release Note

/hold


Run HaplotypeCallerSpark on exome BAM

These are the changes I needed to get HaplotypeCallerSpark working on an exome BAM.
@lbergelson, could you take a look?

I am a bot. Admins -- Can you tell me to test this?

Updated to fix the tests. GVCF is not yet supported by VariantsSparkSink in GATK (https://github.com/broadinstitute/gatk/issues/2738), so I changed the write path back to using the inefficient (but correct) existing code.

Tests now passing. @lbergelson can you take a look?

@tomwhite Migration instructions for this branch: https://github.com/broadinstitute/gatk/wiki/Migrating-branches-from-gatk-protected-to-gatk

Fixed in https://github.com/broadinstitute/gatk/pull/3105.


Variables with boolean value false are overwritten in Request.prepare!

In the Request class, the prepare! method applies default values to variables using conditional assignment:
operation.variables.each do |v|
  @variables[v.name] ||= v.default_value
end

Unfortunately,false is falsey (obviously), so it is always overwritten with the value in v.default_value (which could be nil or true).
This is critical, I'd think, considering it can flip false boolean values to true if the default is true.
Script to reproduce (run from project root):
require_relative 'lib/graphql/stitching'
require_relative 'lib/graphql/stitching/request'

query = <<~GRAPHQL
  query($a: Boolean, $b: Boolean, $c: Boolean = true) {
    base(a: $a, b: $b, c: $c) { id }
  }
GRAPHQL

variables = { "a" => true, "b" => false, "c" => false }
request = GraphQL::Stitching::Request.new(GraphQL.parse(query), variables: variables)
request.prepare!

puts request.variables
# {"a"=>true, "b"=>nil, "c"=>true}

Fix is simple, I'll open a PR in a moment with the fix + a test.

Good catch!

Resolved by https://github.com/gmac/graphql-stitching-ruby/pull/92


Program blocks on s.connection.next() on Android but works fine on desktop

Description
I encountered an issue with [Library Name] when performing cross-platform network communication. Specifically, when attempting to read MAVLink messages from a UDP connection, the code runs smoothly and receives data on the desktop. However, on Android, the same code blocks indefinitely in the nextRawFrame() function at the line when (peeked.readByte().toUByte()). This issue seems to occur when trying to parse the received raw frame, more precisely, when reading the frame header to determine the frame version.
Steps to Reproduce
Establish a UDP connection to [Server/Device] on both desktop and Android.
Attempt to read MAVLink messages by calling s.connection.next().
On the desktop, the program receives and processes data normally.
On Android, the program blocks in the nextRawFrame() function and cannot proceed or receive data.
Expected Behavior
I expect s.connection.next() to read and return MAVLink messages on Android as it does on the desktop, or to avoid indefinite blocking by setting a timeout when data is not available.
Actual Behavior
On the desktop, the program operates as expected, receiving and parsing MAVLink messages. However, on Android, the program indefinitely blocks when attempting to read and parse MAVLink messages, especially at the nextRawFrame() function's line when (peeked.readByte().toUByte()). The program does not timeout or exit the blocking state even when no data arrives.
Environment
Test device/emulator: [android 12]
Operating system version: [windows11]
Attempted Solutions
Confirmed that the network connection is normal, and the server/device has sent data.
Attempted to run the program in different network environments to rule out network issues.
Checked and set read operation timeouts, but the problem persists.
Additional Information
` Button(onClick = {
println("click test!")
CoroutineScope(Dispatchers.IO).launch {
try {
val connection = UdpServerMavConnection(20008, CommonDialect)
connection.connect()
repeat(1000) {
println("repeat!")
println(connection.next())
}
println("connection.close()!")
connection.close()
}catch (e:Exception){
println("error:"+e.message)
                }
            }
        }) {
            Text("connect test")
        }`

Since this issue only occurs on Android and not on the desktop, I suspect there might be specific constraints or configuration issues with the Android platform. I'm hoping to get some help on how to resolve this blocking issue on Android. Thank you!

Sorry, I used it wrong. I should use adapters to get the message.

Awesome!
Indeed you should use the coroutines adapter. That will take care of the threading for you.


fix(Export): check variation db exists before accessing it

Fix ENSWEB-2791 and ENSEMBL-4593.

Sorry! Please ignore this pull request.


Use Cmd+Click for link on macOS. Also set mouse cursor on mouse up.

I couldn't find the reasoning behind using Ctrl or Opt as modifier on macOS instead of the more common Cmd (the "meta key").
One issue with using Ctrl is that Ctrl+Click is reserved to show the context menu so it means if I select the text of a checkbox, then Ctrl+Click, it won't open the context menu and will toggle the checkbox instead. By using Cmd+Click, which is how these actions are usually done, it works as expected.
I've also made another small change to set the mouse cursor on the mouse up event. Otherwise, at least on macOs, it would display the text cursor instead of the pointer cursor after clicking on a checkbox (even though the Cmd key was still pressed).

Funny enough, the original behaviour was to use Cmd+Click for macOS but based on user feedback it was changed to Opt+Click. I've since started to use a Mac for work and I've been regretting that move.

Thanks for the commit! It was bugging me as well, hopefully not too many users got used to the Opt behaviour.


chore(cli): update message should be a warning not an error

Most of the observability tools will trigger errors in production when an upgrade is available. It should be considered as a warning and not an error

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @millsp, sorry I didn't expect that to be tested to be honest haha. Kudos to you! I have amended my previous commit to reflect that

@gilles-yvetot good point! Though I don't see the difference, between console.error and console.warn, both will be directed to stderr.
I think that to avoid problems with observability tools looking at logs, it needs to be sent to stdout, right?

See https://nodejs.org/api/console.html#consolewarndata-args

The console.warn() function is an alias for console.error().

@Jolg42 oh! very interesting. Well then I can switch to a console.log or console.info or console.debug? Will you be okay with that?

No response

On which level does the observability tool you're facing this issue with work and how it detects the error messages? I'd assume that it can't be that any logs sent to stderr are a problem because that's pretty much where such messages are supposed to be sent (otherwise it would be problematic to use Prisma, e.g., in a CLI script that prints consumable data to stdout). If the tool specifically detects the calls to console.error on JS side by injecting code there, then I'd say these changes are good as they are and there's no need to change console.warn to anything else.


Is any more detail roadmap available?

Is your feature request related to a problem? Please describe.
I really like this product and plans for future, but I miss something more detailed, because when now some functions are not crucial for me, it will be in future (maybe in 2-3 months). Currently I really miss email notifications.
Describe the solution you'd like
More detailed roadmap. Could be used GitHub, Productboard (has free plan, which is enough), some custom solution on your webpage

We have email notifications. We send out an email when monitor state changes / or when an incident is created. What do you  miss?

I just read it on webpage:

Same it is on pricing page, so maybe different text, if it is something different, or mark it as supported. Friend who saw it probably will reject this product, because they can't wait for it.

And when I check main page, you are writing about integration with Slack/Teams, Webhooks, ... Do you know, when do you want to deliver these functions?

Hey there, I wish they had an public chart of what they are working on. Sometimes I message simon and hes working on a different feature different from the last, so I understand your pain.
As of right now, it looks like Slack & Teams intergrations is now live. Webhook alerts are not, but I believe you can do that with workflows (I have not tested that).
If you want another specific feature, create an issue on it and I can start pushing for it to get added.

I did not ask for something specific, mentioned things was standard for this type of service and because i like it, I want to know, when it will be and I could recommend this great app to other people.
Thank you for your comment, some public info about current features under development would be nice and I will try these functions.
@simlarsen, is possible to somehow go public with your development?


Seriously, done.

@IEvangelist It might be easier to create a branch on this repo (not from a fork), and test the branch directly on the repo that's referencing docs-tools.

@IEvangelist It might be easier to create a branch on this repo (not from a fork), and test the branch directly on the repo that's referencing docs-tools.

All done.


Unable to use custom sound (iOS)

So far the plugin has been working well for me but I can't get a notification to play my custom sound. My code to schedule the notification:
LocalNotification.schedule({
      id: 12345,
      title: 'BreazeApp Alert',
      text: 'Intervention',
      every: 'day',
      at: alertTime,
      sound: 'file://audio/chimes2.mp3'
    });

The notification gets scheduled and triggers, but no sound is played. Looking at the source in APPLocalNotificationOptions.m, I see my sound path is being changed to 'www/audio/chimes2.mp3':
- (NSString*) soundNameForAsset:(NSString*)path
{
    return [path stringByReplacingOccurrencesOfString:@"file:/"
                                           withString:@"www"];
}

I'm not sure why it does that, but could that be the problem? My sound is in the bundle, included in the Xcode project. Thanks

UPDATE: I modified the code in APPLocalNotificationOptions.m to return 'path' instead of null, and removed the 'file://' prefix from the sound and it works:
LocalNotification.schedule({
      id: 12345,
      title: 'BreazeApp Alert',
      text: 'Intervention',
      every: 'day',
      at: alertTime,
      sound: 'audio/chimes2.mp3'
    });

- (NSString*) soundName
{
    NSString* path = [dict objectForKey:@"sound"];

    if ([self stringIsNullOrEmpty:path])
        return NULL;

    if ([path isEqualToString:DEFAULT_SOUND])
        return UILocalNotificationDefaultSoundName;

    if ([path hasPrefix:@"file:/"])
        return [self soundNameForAsset:path];

    if ([path hasPrefix:@"res:"])
        return [self soundNameForResource:path];

    return path;
}


Update mac uninstall script to remove GVFS service directory

The mac uninstall script did not remove the GVFS service directory, resulting
in GVFS artifacts being left around. This change updates the uninstall script
to also remove the GVFS service directory. This brings the behavior of the mac
uninstall script to match the Windows uninstall script in
src/Scripts/UninstallGVFS.bat.
One motivation for this change was that the Mac Functional test machines were
gathering cruft from repeated test runs, such as the list of registered
repositories in the repo-registry growing. This apparently caused the GVFS
service start up time to grow, resulting in test failures.
This address #1404

/azp run GitHub VFSForGit Mac Functional Tests


Gomachine/refacto

This is a refacto of the GoMachine.
The API is not stable yet (it may change when adding autodiff).
It needs some testing, and any test is welcome.
This is a bench comparison that looks promising, that computes a trivial Conv2d operator (the comparison is made against the TapeMachine :
❯ benchcmp /tmp/2 /tmp/1
benchmark                  old ns/op     new ns/op     delta
BenchmarkMachine_Run-4     172056        119103        -30.78%

benchmark                  old allocs     new allocs     delta
BenchmarkMachine_Run-4     652            219            -66.41%

benchmark                  old bytes     new bytes     delta
BenchmarkMachine_Run-4     23870         12261         -48.63%

I made a lot of fixes.
I was not waiting for all goroutines to finish, this was an issue when running multiple times (this was causing the benchmark to fail).
The result is that it is now slower than the tape machine.
Here is a benchmark on the tiny-yolo-coco:
❯ go test -bench=. -benchmem -benchtime=30s
goos: darwin
goarch: amd64
pkg: gorgonia.org/gorgonia/examples/tiny-yolo-v2-coco
BenchmarkGoMachine-4                  61         742574409 ns/op        314103253 B/op      1481 allocs/op
BenchmarkTapeMachine-4                54         639415245 ns/op        147627449 B/op      1717 allocs/op
PASS
ok      gorgonia.org/gorgonia/examples/tiny-yolo-v2-coco        111.713s

package main

import (
	"context"
	"testing"

	"gorgonia.org/gorgonia"
	G "gorgonia.org/gorgonia"
	xvm "gorgonia.org/gorgonia/x/vm"
	"gorgonia.org/tensor"
)

func BenchmarkGoMachine(b *testing.B) {
	// Init Graph
	g := G.NewGraph()

	model := NewTinyYOLOv2Net(g, 80, 5, "model/yolov2-tiny.weights")

	imgf32, err := GetFloat32Image("data/dog_416x416.jpg")
	if err != nil {
		b.Fatal(err)
	}

	image := tensor.New(tensor.WithShape(1, channels, height, width), tensor.Of(tensor.Float32), tensor.WithBacking(imgf32))
	x := gorgonia.NewTensor(g, tensor.Float32, 4, gorgonia.WithShape(1, channels, width, height), gorgonia.WithName("x"))

	gorgonia.Let(x, image)
	if err := model.FeedForward(g, x); err != nil {
		b.Fatalf("%+v", err)
	}

	machine := xvm.NewMachine(g)
	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		err = machine.Run(context.Background())
		if err != nil {
			b.Fatal(err)
		}
	}
	machine.Close()
}

func BenchmarkTapeMachine(b *testing.B) {
	// Init Graph
	g := G.NewGraph()

	model := NewTinyYOLOv2Net(g, 80, 5, "model/yolov2-tiny.weights")

	imgf32, err := GetFloat32Image("data/dog_416x416.jpg")
	if err != nil {
		b.Fatal(err)
	}

	image := tensor.New(tensor.WithShape(1, channels, height, width), tensor.Of(tensor.Float32), tensor.WithBacking(imgf32))
	x := gorgonia.NewTensor(g, tensor.Float32, 4, gorgonia.WithShape(1, channels, width, height), gorgonia.WithName("x"))

	gorgonia.Let(x, image)
	if err := model.FeedForward(g, x); err != nil {
		b.Fatalf("%+v", err)
	}

	machine := gorgonia.NewTapeMachine(g)
	b.ResetTimer()
	for i := 0; i < b.N; i++ {
		err = machine.RunAll()
		if err != nil {
			b.Fatal(err)
		}
		machine.Reset()
	}
	machine.Close()
}

Profiling the benchmark gives this:

This sounds normal because we are triggering a lot of goroutines.
I should try on a machine with more CPU to see how it behaves.
An optimization idea would be to trigger the goroutines in a smart way (not all of them at the same time), by defining stages inside the machine.
something like:
type Machine struct {
     stages [][]*node
    // ...
}

func (m *Machine) Run(context.Context) error {
    for i := range m.stages {
        for j := range m.stages[i] {
            go run m.stages[i][j].run()
        }
    }
}

My 2 cents (I haven't read a lot of what you've done in this PR because I'm on my phone):
I think stages can be used for optimization but it isn't the optimal solution. For example, if you have 3 short task in series and 1 long task parallel to those 3. In what stage would you put the long task? Unnecessary waiting would happen.

@MarkKremer I agree, the solution is not optimal, but the stages would not be composed of "short" or "long" running processes.
A stage would be a group of noded at the same depth regarding the bottom of the expr graph.
Take for example the following formula: (a + b) * (c + d)
that would lead to this graph:
a -> op1(+)
b -> op1(+)
c -> op2(+)
d -> op2(+)
op1(+) -> op(*)
op2(+) -> op(*)

We could have three groups:

group1: a,b,c,d
group2: op1(+),op2(+)
group3: op(*)

On a simple graph, this is easy to see the benefit.
But, as each not is trigger within a go-routine, on larger graphs, we must carefully build the groups to avoid deadlocks. Eventually, we need to be smarter than go's internal scheduler. I guess that we can leave it as it is for now :D


python 3.11 "support"

while trying to test datalad against 3.11 in https://github.com/datalad/datalad/pull/7199 we ran into
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.11.0/bin/datalad-installer", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/travis/virtualenv/python3.11.0/lib/python3.11/site-packages/datalad_installer.py", line 2640, in main
    return manager.main(argv)
           ^^^^^^^^^^^^^^^^^^
  File "/home/travis/virtualenv/python3.11.0/lib/python3.11/site-packages/datalad_installer.py", line 757, in main
    self.addcomponent(name=cr.name, **cr.kwargs)
  File "/home/travis/virtualenv/python3.11.0/lib/python3.11/site-packages/datalad_installer.py", line 796, in addcomponent
    component(self).provide(**kwargs)
  File "/home/travis/virtualenv/python3.11.0/lib/python3.11/site-packages/datalad_installer.py", line 1057, in provide
    runcmd(conda_instance.conda_exe, "install", *install_args)
  File "/home/travis/virtualenv/python3.11.0/lib/python3.11/site-packages/datalad_installer.py", line 2499, in runcmd
    return subprocess.run(arglist, check=True, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/3.11.0/lib/python3.11/subprocess.py", line 569, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/tmp/dl-miniconda-lopaealy/bin/conda', 'install', '--yes', 'python=3.11']' returned non-zero exit status 1.
The command "eval datalad-installer --sudo ok -E new.env ${_DL_ANNEX_INSTALL_SCENARIO}" failed and exited with 1 during .

so it seems there is no 3.11 in main channels of conda, but I see it in conda-forge... is it worth may be adding -c conda-forge there?

@yarikoptic So you're asking for -c conda-forge to be passed to the conda install command ... when?  If --python-match is supplied under Python 3.11?  How about if a -c/--channel option is added to the miniconda component?


Missing some basic_selections for new CSM 9e codex

There are a few required wargear selections missing due to renames, etc in the new codex:
   Possessed:
     - Horrifying Mutations
+    - Hideous mutations

+  Master of Possession:
+    - Staff of Possession
+
+  Venomcrawler:
+    - Soulflayer tendrils and claws

I would be happy to help out keeping that up to date and adding others I spot if you give me access to file a PR.

Hello!
Sorry for the long answer and thanks for the suggestion. The usual way to create a PR is to fork the repo, make changes and file a PR. Unfortunately, other ways (AFAIK) require write access to the repo.
I'll be happy to accept PR if you will create one, or make changes by myself if it's too much work for several lines and you don't want to :D

Ok, sure. I am more used to a branch oriented approach, but I can fork and file a PR off that.

Filed a PR for these first few additions.

Closed by #54


please implement FusedStream for Interval

@243011068 Could you explain why need this?

Sorry.I made a mistake.


Accept punctuation after simple+cross repository issue references

This PR adds ,, ; and : as valid characters following a simple issue or PR ref, as long as there's a spacing character following:
#123 was supported.
#123. was supported.
#123, was not supported, now it is.
#123; was not supported, now it is.
#123: was not supported, now it is.
#123.456 is not supported.

Attempts to close (?) #10074, but I've left a few cases out; I feel a little uncomfortable trying to read too much out of the text with just a regexp, I don't want to start getting too many false positives:

I didn't add question or exclamation marks... Seems excesive? I think exclamation marks look weird in the case of PRs (Look at !1234!) but it may work with issues (Look at #1234!).
I did this only for simple and cross repository references, not external alphanumeric (AAAA-1234) references.

Codecov Report

Merging #10091 into master will increase coverage by 1.14%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master   #10091      +/-   ##
==========================================
+ Coverage   42.31%   43.45%   +1.14%
==========================================
  Files         618      566      -52
  Lines       80850    78991    -1859
==========================================
+ Hits        34211    34328     +117
+ Misses      42430    40424    -2006
- Partials     4209     4239      +30

Impacted Files
Coverage Δ

modules/references/references.go
78.89% <25%> (-1.01%)
:arrow_down:

services/repository/transfer.go
55.55% <0%> (-11.12%)
:arrow_down:

models/topic.go
62.24% <0%> (-4.43%)
:arrow_down:

modules/queue/manager.go
60.51% <0%> (-1.54%)
:arrow_down:

models/user.go
49.15% <0%> (-0.13%)
:arrow_down:

models/migrations/v76.go
0% <0%> (ø)
:arrow_up:

models/migrations/v70.go
0% <0%> (ø)
:arrow_up:

modules/structs/repo.go
36.36% <0%> (ø)
:arrow_up:

models/migrations/v60.go

models/migrations/v31.go

... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb0f20...2b040ef. Read the comment docs.

i think it close #10074

And ? and !?

Can ? and ! be supported as well? I think if the rule is the same (space or EOL immediately after) then it isn't ambiguous, but I can say nothing about the troubles to implement that.

And ? and !?

No problem, I can add those.

Added ! and ?. Fixed a bug where mentions/references were not detected if they were consecutive and shared a space:
......._REF1_REF2_.....
.......XXXXXX..........
............YYYYYY.....

This was not apparent in markdown rendering because the function takes them one by one.

And ? and !?

@lunny done.


Update README.md

Installing HEAD is not needed for Folly.
Better to install the latest release brew install folly

No need.


[Tooling] ES Lint Config does not work for Open Source

Problem
The current ES Lint configuration does not work for the community. It depends on a closed-source 1Password project.
Details
We're using eslintrc.yml from @1password/front-end-style in this project. The public distribution of this project at NPM has been deprecated:

It looks like the internal project is still receiving updates. We'll want to work with the owning team to figure out how we can use this project for open source projects, what was the original reasoning for discontinuing the NPM project, and whether we can continue that again. Alternatively, if we cannot use that project, we'll want to migrate to an open source alternative (e.g. maintaining our own ES Lint configuration in this repo).

@SimonBarendse @edif2008 I found the following packages: https://www.npmjs.com/package/@1password/eslint-config and https://www.npmjs.com/package/@1password/prettier-config. Is it okay to migrate from @1password/front-end-style to these?


Buffer get always

See description in latest issue and commit log

This one has been waiting long enough :-)
We will merge and start testing.


sailboat test

std 20x20mm net support
sg90 for control

need to make a mask from few parts(for transportation reason)
seals need to be adjustable too
servo would need a 1:2 gearbox


 Do you really think this has to do with the operating system used?

@eyalbe4 I'm offering it solely as a data point, as it works fine on Ubuntu 20.  It looks like it's trying to talk ipv6, and not getting through.  I've been running this server for a year plus 12 his a day, and haven't seen this before.  Perhaps you have a quick test I can run to help isolate the problem?

@eyalbe4 I enabled ipv6 on the network and machines in question.  No change in behavior between the Fedora 34 and Ubuntu 20 machines.  Ubuntu works, Fedora does not; same jf version.  So I could use some further input.

Nothing comes to mind @jwinarske...
You can try the following command, which uses curl for troubleshooting. Maybe this can hint towards the cause:
jf rt curl api/system/version

[runner@fedora jfrog-cli]$ which jf
/usr/local/bin/jf
[runner@fedora jfrog-cli]$ jf rt curl api/system/version
11:44:27 [🟠Warn] (Attempt 1) - Failure occurred while sending GET request to https://eflutter.jfrog.io/artifactory/api/system/version: Get "https://eflutter.jfrog.io/artifactory/api/system/version": dial tcp: lookup eflutter.jfrog.io on [::1]:53: read udp [::1]:55122->[::1]:53: read: connection refused
11:44:27 [🟠Warn] (Attempt 2) - Failure occurred while sending GET request to https://eflutter.jfrog.io/artifactory/api/system/version: Get "https://eflutter.jfrog.io/artifactory/api/system/version": dial tcp: lookup eflutter.jfrog.io on [::1]:53: read udp [::1]:53257->[::1]:53: read: connection refused
11:44:27 [🟠Warn] (Attempt 3) - Failure occurred while sending GET request to https://eflutter.jfrog.io/artifactory/api/system/version: Get "https://eflutter.jfrog.io/artifactory/api/system/version": dial tcp: lookup eflutter.jfrog.io on [::1]:53: read udp [::1]:45759->[::1]:53: read: connection refused
11:44:27 [🟠Warn] (Attempt 4) - Failure occurred while sending GET request to https://eflutter.jfrog.io/artifactory/api/system/version: Get "https://eflutter.jfrog.io/artifactory/api/system/version": dial tcp: lookup eflutter.jfrog.io on [::1]:53: read udp [::1]:32858->[::1]:53: read: connection refused
11:44:27 [🔵Info]  executor timeout after 3 attempts with 0 milliseconds wait intervals
{
  "version" : "7.42.4",
  "revision" : "74204900",
  "addons" : [ "aol", "ha", "build", "docker", "vagrant", "replication", "filestore", "plugins", "gems", "composer", "npm", "bower", "git-lfs", "nuget", "debian", "opkg", "rpm", "cocoapods", "conan", "vcs", "pypi", "release-bundle", "jf-connect", "jf-event", "replicator", "keys", "alpine", "cargo", "chef", "federated", "git", "observability", "pub", "rest", "swift", "conda", "terraform", "tracker", "license", "puppet", "ldap", "sso", "layouts", "properties", "search", "securityresourceaddon", "filtered-resources", "p2", "watch", "webstart", "support", "xray", "retention" ],
  "license" : "8dd4186aa4c43a21b2434ab9bcc0d5f1d488685d3",
  "entitlements" : {
    "EVENT_BASED_PULL_REPLICATION" : true,
    "SMART_REMOTE_TARGET_FOR_EDGE" : false,
    "REPO_REPLICATION" : true,
    "MULTIPUSH_REPLICATION" : true
  }
}[runner@fedora jfrog-cli]$

It's telling me that "exponential back off and retry" is not implemented.

Where does it tell you that exponential back off and retry" is not implemented @jwinarske?

The timeout between sends.  If four timeouts happen within the same second, then exponential back off is not happening.  In that model each retry would happen at a greater delay time than prior.  If you use the average ping time of a high latency Internet connection, one would expect to see the retry delays to easily exceed 1 second.
Although I'm using a ~1GBPS up/down internet pipe.
What is being used for a retry delay value?
The response eventually comes in.  Most likely in response to the first request.


[SUPPORT] HoodieRollbackException when starting Flink Job on existing Hudi Table

I am using Hudi with Flink and when I submit the job it fails to rollback. This is issue happens also if any of the checkpoints fails.
Caused by: org.apache.flink.util.FlinkException: Global failure triggered by OperatorCoordinator for 'stream_write: HUDI_TIME_SERIES' (operator e8fc67ede24cef102d7d7a9334f93f11).     at org.apache.flink.runtime.operators.coordination.OperatorCoordinatorHolder$LazyInitializedCoordinatorContext.failJob(OperatorCoordinatorHolder.java:545)     at org.apache.hudi.sink.StreamWriteOperatorCoordinator.lambda$start$0(StreamWriteOperatorCoordinator.java:188)     at org.apache.hudi.sink.utils.NonThrownExecutor.lambda$execute$0(NonThrownExecutor.java:103)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) Caused by: org.apache.hudi.exception.HoodieException: Executor executes action [initialize instant ] error     ... 5 more Caused by: org.apache.hudi.exception.HoodieRollbackException: Failed to rollback gs://bucketpath/table_ commits<PHONE_NUMBER>5415314     at org.apache.hudi.client.BaseHoodieWriteClient.rollback(BaseHoodieWriteClient.java:779)     at org.apache.hudi.client.BaseHoodieWriteClient.rollbackFailedWrites(BaseHoodieWriteClient.java:1189)     at org.apache.hudi.client.BaseHoodieWriteClient.rollbackFailedWrites(BaseHoodieWriteClient.java:1172)     at org.apache.hudi.client.BaseHoodieWriteClient.rollbackFailedWrites(BaseHoodieWriteClient.java:1160)     at org.apache.hudi.client.BaseHoodieWriteClient.lambda$startCommit$afea71c0$1(BaseHoodieWriteClient.java:932)     at org.apache.hudi.common.util.CleanerUtils.rollbackFailedWrites(CleanerUtils.java:151)     at org.apache.hudi.client.BaseHoodieWriteClient.startCommit(BaseHoodieWriteClient.java:931)     at org.apache.hudi.sink.StreamWriteOperatorCoordinator.startInstant(StreamWriteOperatorCoordinator.java:375)     at org.apache.hudi.sink.StreamWriteOperatorCoordinator.lambda$initInstant$6(StreamWriteOperatorCoordinator.java:403)     at org.apache.hudi.sink.utils.NonThrownExecutor.lambda$execute$0(NonThrownExecutor.java:93)     ... 3 more Caused by: java.lang.NullPointerException     at org.apache.hudi.metadata.HoodieBackedTableMetadataWriter.update(HoodieBackedTableMetadataWriter.java:910)     at org.apache.hudi.table.action.BaseActionExecutor.lambda$writeTableMetadata$2(BaseActionExecutor.java:77)     at org.apache.hudi.common.util.Option.ifPresent(Option.java:97)     at org.apache.hudi.table.action.BaseActionExecutor.writeTableMetadata(BaseActionExecutor.java:77)     at org.apache.hudi.table.action.rollback.BaseRollbackActionExecutor.finishRollback(BaseRollbackActionExecutor.java:255)     at org.apache.hudi.table.action.rollback.BaseRollbackActionExecutor.runRollback(BaseRollbackActionExecutor.java:124)     at org.apache.hudi.table.action.rollback.BaseRollbackActionExecutor.execute(BaseRollbackActionExecutor.java:145)     at org.apache.hudi.table.HoodieFlinkCopyOnWriteTable.rollback(HoodieFlinkCopyOnWriteTable.java:333)     at org.apache.hudi.client.BaseHoodieWriteClient.rollback(BaseHoodieWriteClient.java:762)     ... 12 more

Still not working, it NoClassDefFoundError  AWSGlueCatalogSyncTool even though I am using Hive as catalog
Caused by: java.lang.NoClassDefFoundError: org/apache/hudi/aws/sync/AWSGlueCatalogSyncTool 	at org.apache.hudi.sink.StreamWriteOperatorCoordinator.initHiveSync(StreamWriteOperatorCoordinator.java:332)

oops, this is another bug ...

Did you use the flink-hudi-bundle jar , the hudi-aws expects to be packaged in.

Yes, also tried to include aws bundle but didn’t work
On Wed, Jul 6, 2022 at 12:08 PM Danny Chan @.***> wrote:

Did you use the flink-hudi-bundle jar , the hudi-aws expects to be
packaged in.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/hudi/issues/6052#issuecomment-1176037219, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AR7AE5V7TY3E4TKMMX37P23VSVLJBANCNFSM52YQO5EA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Shqiprim Bunjaku
KODE Labs
m:
383 44 709 267
w:
kodelabs.com http://kodelabs.com/  e: @.***

@shqiprimbkodelabs @danny0405 : are we good to close this one or is there anything pending still ?

Did you try the release 0.12.1 then ? It expects to work correctly now.

Close because of prolonged inactivity.


I would like to add code of binary search tree in CPP.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I would like to add code for binary search tree in CPP.

assigned

hey @msameerfarooq  please assign this issue to me?


get_local_path doesn't work for local-files connector

I'm importing image files using the local files source and the image URLs are in the format
/data/local-files/?d=foo/bar.jpg

When calling self.get_local_path in LabelStudioMLBase derived class it just throws the error:
[2022-07-01 21:34:13,520] [ERROR] [label_studio_ml.exceptions::exception_f::53] Traceback (most recent call last):
  File "/home/rice/venvs/-/lib/python3.10/site-packages/label_studio_ml/exceptions.py", line 39, in exception_f
    return f(*args, **kwargs)
  File "/home/rice/venvs/-/lib/python3.10/site-packages/label_studio_ml/api.py", line 32, in _predict
    predictions, model = _manager.predict(tasks, project, label_config, force_reload, try_fetch, **params)
  File "/home/rice/venvs/-/lib/python3.10/site-packages/label_studio_ml/model.py", line 582, in predict
    predictions = m.model.predict(tasks, **kwargs)
  File "/mnt/ext/-/dense/labelstudio-dense/labelstudio.py", line 58, in predict
    image = self.get_local_path(task['data']['image'])
  File "/home/rice/venvs/-/lib/python3.10/site-packages/label_studio_ml/model.py", line 322, in get_local_path
    return get_local_path(url, project_dir=project_dir, hostname=self.hostname, access_token=self.access_token)
  File "/home/rice/venvs/-/lib/python3.10/site-packages/label_studio_tools/core/utils/io.py", line 59, in get_local_path
    raise FileNotFoundError(filepath)
FileNotFoundError: foo/bar.jpg/local-files/

Hello!
I'm facing the exact same issue.
From the backend's side I get this message:
FileNotFoundError: Can't resolve url, neither hostname or project_dir passed: /data/upload/2/b9793581-Traigo80_li-ion20charging.jpgwidth768nameTraigo80_li-ion20charging.jpg

[2022-07-05 13:39:45,666] [INFO] [werkzeug::_log::225] <IP_ADDRESS> - - [05/Jul/2022 13:39:45] "POST /predict HTTP/1.1" 500 -
<IP_ADDRESS> - - [05/Jul/2022 13:39:45] "POST /predict HTTP/1.1" 500 -

From the UI's side I get this message:
[2022-07-05 11:39:39,916] [ml.models::predict_tasks::171] [WARNING] Prediction not created for project Forklift Backend (id=1, url=http://<IP_ADDRESS>:9090): 500 Server Error: INTERNAL SERVER ERROR for url: http://<IP_ADDRESS>:9090/predict
[05/Jul/2022 11:39:39] "GET /api/tasks?page=1&page_size=30&view=5&project=2 HTTP/1.1" 200 7067
[05/Jul/2022 11:39:40] "GET /data/upload/2/b9793581-Traigo80_li-ion20charging.jpgwidth768nameTraigo80_li-ion20charging.jpg HTTP/1.1" 200 62374
[05/Jul/2022 11:39:44] "GET /api/label_links?project=2&expand=label HTTP/1.1" 200 52
[2022-07-05 11:39:45,667] [ml.models::predict_tasks::171] [WARNING] Prediction not created for project Forklift Backend (id=1, url=http://<IP_ADDRESS>:9090): 500 Server Error: INTERNAL SERVER ERROR for url: http://<IP_ADDRESS>:9090/predict
[05/Jul/2022 11:39:45] "GET /api/tasks/14?project=2 HTTP/1.1" 200 689

In the beginning, I was thinking that this issue comes from the fact that I have uploaded some sample images from my local device by just drag & drop. So I found on google images an image with an object of my interest and I imported this image by using its URL. The abovementioned messages come from the latter method I used to import my image.
(Everything else seems to be working properly, the only problem I'm having is that I cannot see the predictions of the model I've been using that are supposed to assist me to annotate new unlabeled images)
Any idea on how to resolve this?! 🥺

@d4l3k
It seems that there is some mistake in data urls:

FileNotFoundError: foo/bar.jpg/local-files/

Could you please what goes into get_local_path method?

I'm calling it with
/data/local-files/?d=foo/bar.jpg
Which is from the task['data']['image'[ field I believe
I've worked around it by parsing the image and joining it with the hard coded path on disk but that's less than ideal

Here's my code:
def predict(self, tasks, **kwargs):
        assert len(tasks) == 1

        print(tasks)
        predictions = []
        for task in tasks:
            image = task["data"]["image"]
            _, _, image = image.partition("?d=")
            image = os.path.join("../datasets", image)

            img = Image.open(image)

Ideally I want to be able to call get_local_path(task["data"]["image"]) but that throws the error in the original post above

What version of label studio tools do you use?
Do you have such file /data/foo/bar.jpg locally in your file system in ml backend service?

versions
$ pip list | grep label-studio
label-studio                   1.5.0
label-studio-converter         0.0.40
label-studio-ml                1.0.8
label-studio-tools             0.0.0.dev11

Label studio connector:

Example task:
{
  "id": 176992,
  "data": {
    "image": "/data/local-files/?d=imagespace/capture_main_20.jpg"
  }
}

On label-studio-tools==0.0.0.dev14 it prints:
Traceback (most recent call last):
  File "/home/rice/venvs/openape/lib/python3.10/site-packages/label_studio_ml/exceptions.py", line 39, in exception_f
    return f(*args, **kwargs)
  File "/home/rice/venvs/openape/lib/python3.10/site-packages/label_studio_ml/api.py", line 32, in _predict
    predictions, model = _manager.predict(tasks, project, label_config, force_reload, try_fetch, **params)
  File "/home/rice/venvs/openape/lib/python3.10/site-packages/label_studio_ml/model.py", line 582, in predict
    predictions = m.model.predict(tasks, **kwargs)
  File "/mnt/ext/openape/dense/labelstudio-dense/labelstudio.py", line 64, in predict
    path = self.get_local_path(task['data']['image'])
  File "/home/rice/venvs/openape/lib/python3.10/site-packages/label_studio_ml/model.py", line 322, in get_local_path
    return get_local_path(url, project_dir=project_dir, hostname=self.hostname, access_token=self.access_token)
  File "/home/rice/venvs/openape/lib/python3.10/site-packages/label_studio_tools/core/utils/io.py", line 61, in get_local_path
    raise FileNotFoundError(filepath)
FileNotFoundError: local-files/imagespace/capture_narrow_20.jpg

@pinecho did you provide access_token  to your instance of label studio?

@pinecho
You should add it in init of your model:
self.access_token = access_token

@KonstantinKorotaev
It works, thank you so much!

@d4l3k
Could you please update your label-studio-tools from branch fb-DEV-2827 and try again?

Yup, that's working now. Thanks for the fix!


How to limit message batch size or ack in middle of handling message batch?

We have a brod_group_subscriber that receives messages, usually 5 or 10, but sometimes there are 5000+, which is too many for us to handle at once. So we take the messages and we chunk into blocks of say 500 messages and process each separately, where each block can take 20+ seconds but its fine.
The problem is that when there is an error near the end of this block of messages, it will then reprocess all 5000 messages again from the beginning, which is a long time, and a lot of reprocessing.
So I tried, in my handle_messages callback, to ack the offset of the final message in each block of 500, but it doesn't work. Because handle_messages is a call, and acking is a cast to the same gen_server, the acks do not get processed until after all 5000 messages are processed, so any exception will guarantee none of those acks get forwarded to the brod_group_coordinator. I cannot see a way to get the pid of the coordinator to ack to it directly.
Is there any way to limit the size of message batches or to ack in the middle of processing a single batch?
I've tried some things like limiting the size of messages received through consumer options, but it is fiddly having to estimate average message size and it incredibly slows down processing as a whole.

Hi @mindreader
brod_group_subscriber_v2 allows the callback to return ack for each message.
https://github.com/kafka4beam/brod/blob/6966f0244b87904363cb8053ac0364ff281411d9/src/brod_group_subscriber_worker.erl#L79-L83

Maybe you did not observe the commit because the coordinator process collects acks and send a batch to Kaka every 5 seconds.

Sorry if I'm misunderstanding, but looking at the code, it calls my module callback with 5k messages, and then acks or commits the 5000th message, depending on what I return.
But that means I have to fully process all 5000 of them before I can send any indication back to brod that any messages were handled.
Originally I tried to send out of band acks but those acks are targetted to the same genserver that is handling the messages, so it doesn't handle the acks during message processing.
It should be possible to send those out of band acks directly to the supervisor, as that is what the genserver does. It knows the supervisors pid and so it just forwards them along, but my callback module is never given that did, so it can't send them itself.
The every 5 second commit happens, but it never has a chance to know that I've finished processing any messages until I've processes all of them.

the v2 subscriber is based on brod_topic_subscriber which by default handles message_set, but it can be also configured to handle message.
https://github.com/kafka4beam/brod/blob/master/src/brod_group_subscriber_v2.erl#L68


Request manual review to delete my duplicated token

The limbocoin token is already in the token list, I created it in my repository a year ago and my company wants to create it in their repository, so I created it again. and I want to delete the old one

the old one was created by me, in my github account, the new one was created in m's github account

https://github.com/solana-labs/token-list/pull/27972


Build(deps): Bump terser from 4.6.10 to 4.8.1 (#3773)

Pull request opened by the merge tool on behalf of #3773

Merged in 5e997d8fab4be00e9cac7a192be23ba1048543eb


Docked Dev Tools

It would be great if it were possible to dock the dev tools for the displayed webpage directly to the HyperTerm window. Is this possible? I image this might be similar to the issue that prevents the Vivaldi Browser's dev tools from being docked to the window, but I figured I'd ask, or at least start the conversation.

Unfortunately, currently it's not possible, see https://github.com/electron/electron/issues/3177.


Multiple languages

I'm thinking to a very basic multi language system, i thought to use a handblebar helper for translation in the view. Admin can edit languages in a json format from a dedicated backoffice section. Translationts are stored on mongo and on layout.hbs a widget for language switcher.
What do you think about that?

I'd be more keen on using a module like this: https://www.npmjs.com/package/i18n-2 and storing data in language files.

ok, storage on db could be avoid app reload. I'll see how your link works, it seems a rapid implemetations for express

Merged, so i close this :)


parallel=True and if-condition

Reporting a bug
Numba version: 0.48.0
import numba
import numpy as np

@numba.njit(parallel=True)
def bug(swap, arr):
    j, k = 0, 1
    if swap:
        j, k = k, j
    arr[:, k] = 3
    return arr

if __name__ == '__main__':
    print("numba:  ",         bug(True, np.array([[1, 2]])))
    print("py_func:", bug.py_func(True, np.array([[1, 2]])))

Output:
numba:   [[1 3]]
py_func: [[3 2]]

If we replace arr[:, k] = 3 with arr[0, k] = 3 it works properly (with warning "no transformation for parallel execution was possible.")

@piotrbartman thanks for reporting this to the Numba issue tracker. I can confirm that this is probably a bug as I am able to reproduce this locally. Also note that setting paralle=False  also makes the code produce the correct  output.

cc @DrTodd13 but before looking into this, let's see if SSA just fixes it!

In numba 0.49RC1 it fixed.

@piotrbartman wonderful, thanks for reporting back. Does this suffice to be able to close the issue?

Yes, thank you!

@piotrbartman probably not, since those tests would have failed due to lack of SSA. Unless of course those tests were skipped.

Fixed in version 0.50.0+.


[core-http] Expose max sockets options in ServiceClient

Support configuring Node.js http.Agent maxSockets and maxTotalSockets when creating service clients.

THIS IS A DRAFT PR
The below information will be populated after soliciting feedback on whether this is an appropriate approach.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

@microsoft-github-policy-service agree

Thanks for the tip @jeremymeng, I didn't realize core-http was planned for deprecation. This PR was intended to be used as an example for discussion in https://github.com/Azure/azure-sdk-for-js/issues/25522 and @xirzec just let me know the same.
I'll go ahead and close this out as it has served its purpose. Thanks again for taking a look!


Disable undo when running complete() without changes.

This fixes an issue where set_completion() creates empty undo entries when there's no changes to the buffer.  I'm not sure if this is the best approach, but hopefully someone more knowledgeable of the completion code will have more insight.
It looks like the main cause of this issue is stop_arrow() in edit.c#L2802 not accounting for compl_no_insert.  Changing that line to !compl_no_insert && stop_arrow() == FAIL fixes the issue when calling complete() the first time, but subsequent calls continue to create more empty undo entries.  It seems that edit.c#L3879 defeats it.  I didn't want to try checking compl_no_insert and ctrl_x_mode there since insertchar() is even more unfamiliar code and I wasn't sure of the side effects.
In investigating this, I noticed that b:changedtick doesn't increment when the blank undo entries were created, which is why I'm using it for tracking and temporarily disabling undo.  It seems that the correlation between b:changedtick and undo creation is broken with set_completion().
I used the following script with -u to test/confirm this problem:
set nocompatible
set completeopt+=noinsert,noselect
set completeopt+=noinsert
set noshowmode
set shortmess+=c

function! s:changes(name) abort
  echomsg '['.a:name.'] changedtick:' b:changedtick 'changenr:' changenr() '-' string(reltime())
endfunction

function! s:complete() abort
  call complete(1, Omni(0, ''))
  call s:changes('complete')
  return ''
endfunction

function! Omni(findstart, base) abort
  if a:findstart == 1
    return 1
  endif
  return ['January', 'February', 'March',
        \ 'April', 'May', 'June', 'July', 'August', 'September',
        \ 'October', 'November', 'December']
endfunction

set omnifunc=Omni
autocmd InsertEnter * call s:changes('autocmd')

inoremap <right> <c-r>=<sid>complete(0)<cr>

With the script sourced, the following happens:

a<esc>a<esc> etc, results in no undo entry.
<right> will display the menu and immediately results in a blank undo entry each time it's pressed.
^X^O displays the menu in insert mode and creates a blank undo entry when pressing <esc>.

This patch is already merged.
So, it should be closed.

I'll close this PR since it's no longer relevant, but there's still another issue in patch 8.0.0041: https://groups.google.com/d/msg/vim_dev/t66A6NIzLlc/AmH3cMQmBQAJ


Freezes randomly

VSCode Version: Code 1.3.1 (e6b4afa53e9c0f54edef1673de9001e9f0f547ae, 2016-07-12T13:35:06.227Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

Windows 10 64bits. I start visual code and it freezes after a while. I get a prompt to reopen or close the application.

It is possible that this issue is caused by an installed extension. Can you try to run VS Code without extensions? From the command line, execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

I've tried this and I still have the issue. It might be worth mentioning that I'm getting this only when working on a particular project that has rather large files (10K - 40k lines\file), could this be causing the issue?

@johndemian do you remember what you were doing when VS Code freezes? E.g. are you just browsing or heavy editing of large files?

It happen twice this morning when working on the same project with large files. Since then I've worked on a different project and it hasn't happen. I can conclude that it only happens when working with large files.
Thanks,
John

@johndemian and these large files are JavaScript or TypeScript files?

@weinand Never happened on TS files, even though I've worked on large projects. This only happens on a particular AngularJS porject.
Again, I want to point out that I do get a prompt asking if I wanted to reopen or close the app but both options lead to the same result, the app freezes.
If I can provide logs or screenshots to help you guys figure this thing out, please let me know

This is issue since 1.3.0, i was thinking it got fixed. But its back.
My theory is, there is problem with editing files on network storage, when it doesnt get response ASAP, editor will freeze. My editor always frozen when saving file - not asap, but after few seconds and our network storage is pretty slow
so all of you who have editor freezes, are you editing files localy or in mounted network drive? :)

ps: i had way more freezes with autosave enabled, thats why i think its somehow related to saving changes

ps2: freeze happened when i saved file and refreshed page ASAP, so it could be becouse my file was currently used by apache webserver and couldnt be saved which for some reason causes editor to freeze

I've been seeing this issue as well, v. 1.3.0 and 1.3.1. Saw it on Windows 7 and on Windows 10 when IT upgraded my machine.
Most of the time this happens with a single CSS file that I'm working on for a site. It's a huge, messy file, but it's not over 10K lines of code. There was one instance today when this happened while working on a notes.txt document (about 100 lines). It always happens when I'm typing something, but I can't replicate consistently. Has happened multiple times per day all week.
What more information can I provide?

@FoxBJK do you have "autosave" turned on? are you editing on network storage or local?
well there could be more reasons for freeze, but i had problems with less, css, php so its not file type exclusive and as far as i can remember, only when saving a file :)

I'm editing files on a network drive, but autosave is off

well it does even with autosave turned off, but with it, it was freezing way more

For various reasons I can't enable auto-save on these documents. It should be noted that I'm not always the only person touching these files, though most of the time that's not an issue. The app is pretty good about updating when others are touching the file.
What I'm starting to notice is that this only happens when I'm in the middle of typing out CSS. Maybe something related to autocomplete? I have no extensions installed for this, I'm just using what's built in.

Looks like there could be more problems, various users "touching" file and locking it to read or as i noticed on one project today, when i simply refreshed page, it froze my editor with LESS and TPL (template) file opened, so i guess linux user (webserver) locked one of these files for itself for a moment and editor didnt like it

DEV server where i have these freezes is mounted via WinSSH - which is not super stable and fast tho, but didnt have any problems with older versions of VSC
..and my local virtual machine (hyper-V) mounted via SMB share and has no problems so far

.. ok had to remove my last message... even VM mounted via SMB just froze, gonna try disable some plugins

keeps freezing without plugins, editing large CSS file with 6300 lines

looks like it could be caused by "autocomplete" window.
Hope it will get finally fixed... it's really annoying opening 1 CSS file 3 times to write 10 lines of code :(

and what about 1.4?

Having exactly the same issue in 1.4, widow freezes within 5 minutes when editing CSS files. Also seems to be related to the autocomplete window, it always freezes right after it starts loading something.

hm better staing on 1.2.1 then :(

@bpasero Not sure if it's helpful to assign it to me. The original issue was not about css, also I doubt that the css service that runs in a process or in the extension host can freeze vs code.

@aeschli if it is an issue with the grammar???

@wUFr Any chance you can attach the css file where you see the issue often?

@aeschli gonna update to newest one, disable plugins and probably try record video of it or something (:

@aeschli can you please give me e-mail? dont really want to show these source codes in public :)
it just froze again when i tried to copy pasting few lines of code, but it did even in different situations. Another idea im nind is, that editor dont like when you edit file thats being currently saved, project is on network storage so saving can take around 1-2 secs

@wUFr It's martinae at microsoft.com
If you think it could be related to the remote file system, can you copy the file to a local drive and see if freezing is an issue there as well?

@aeschli email sent ("VSC - issue #9406 - @wUFr - Freezes randomly - video evidence")
will do some more local testing at home (:

My VSCODE also seems to lockup randomly. I have not been able to narrow down the steps to recreate this but it seems to happen when I'm writing TypeScript code that uses chained methods.

I'm running VSCode 1.4 and am getting random lockups too. My project is 500MB with all npm dependencies installed, Is there a way of reviewing a log file to see if an extension may be causing the issue?

same issue here :/

This turned out to be one of the extensions I had installed. Once I removed
the extension everything worked.
On Sat, Sep 10, 2016 at 12:42 PM, Drilon Nolird<EMAIL_ADDRESS>wrote:

same issue here :/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/9406#issuecomment-246121783,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHnpqD2SLMrPTbDpsRV4rxl5QM1isyg9ks5qot3ggaJpZM4JONtA
.

--
Lee Mellinger
President & CEO
InfiniSuite, LLC
www.infinisuite.com
Mobile: 1.734.531.8702
Skype: leemellinger
LinkedIn: linkedin.com/in/leemellinger
https://www.linkedin.com/in/leemellinger
Business Solutions for Cloud 2.0
NOTICE: The information contained in this e-mail, and in any accompanying
documents, may constitute confidential and/or legally privileged
information. The information is intended only for use by the designated
recipient. If you are not the intended recipient (or responsible for the
delivery of the message to the intended recipient), you are hereby notified
that any dissemination, distribution, copying, or other use of, or taking
of any action in reliance on this e-mail is strictly prohibited. If you
have received this e-mail communication in error, please notify the sender
immediately and delete the message from your system.

Do you have a laptop with a touchscreen? Might be #12036

It appears it may have been an extension for me too.

tried 1.4 and still keeps freezing, froze while editing settings.json - this is not related to any extensions, its just broken editor...
again and again and again - its freezes after its trying to save file on server, it takes about 2-3 seconds

Using current version of VSC (1.6.1), freezes still happening on file save
When i have autosave turned on, editor will hang when saving big CSS file (3000+ lines), even when you reopen same file and try to do same change again
When i use manual save, editor wont save file no matter what, save / save as, file wont save.

is there any debug parameter / setting that would generate log file? since i can reproduce this issue

created separate issue here: https://github.com/Microsoft/vscode/issues/13997 since its not random anymore

freezing while saving big less/css file looks fixed in 1.7.1

I'm going to close this issue because it has become a little unfocused and is now tracking multiple different issues, some of which have been resolved.
Please give the latest VSCode release a try and if you are still encountering any problems, please open a new issue so that we can better track and resolve the problem.
Thanks.


useScroll - scroll direction?

Is your feature request related to a problem? Please describe.
I'm working on a "chat" application right now which needs some fetching on scrolling while going "up", so my implementation needs to be aware of the direction scrolling, I think it would also help to some other kind of UI navigations/interactions.
Describe the solution you'd like
I would like the hook to return an object with something like:

// ...current useScroll() implementation, where state is { x: number , y: number } plus the scrollDirection
// scrollDirection could be either `up` or `down` , so `type ScrollDirection = `up` | `down`;

return { pos: state, dir: scrollDirection }

of course dir would be updated with a very good precision.
Describe alternatives you've considered
I'm trying to implement the scroll direction prop myself, but I couldn't get it to be completely responsive, I tried using the usePrevious() hook within the useScroll() hook to get what I wanted, but there is some "delay" when updating the scroll direction, I'm not sure how to completely get it "live".

I opened a pull request for this issue. #1634


Ganglia missing ?

First of all, this list is an amazing compilation !
Perhaps Ganglia ( http://ganglia.sourceforge.net/ ) should also be included since it is a pretty standard distributed monitor tool in Hadoop clusters.

Hi!
Probably Ganglia is a more generic tool, however you are right, probably is a tool widely used in Hadoop clusters.


[ERR] Ufw is not enabled, try to enable now? [Y/n]

Hello!
I used in Raspbian with my rasperry PI 4GB RAM and  PIVPN + WireGuard works very well. But now, Canonical launched Linux Ubuntu Desktop official for Raspberry 4GB and I want use PIVPN + Wireguard.
When I install PIVPN with this code:
curl -L https://install.pivpn.io | bash
then I don't get that during installation the option with wireguard, only I can install pipvpn with openguard, but if I install with this code:
curl -L https://test.pivpn.io | TESTING= bash
then during installation I can install pivpn with wireguard.
When I install all, with pivpn -d it show this code:
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [ERR] Ufw is not enabled, try to enable now? [Y/n] y
El cortafuegos está activo y habilitado en el arranque del sistema
:: [OK] Iptables MASQUERADE rule set
:: [OK] Ufw input rule set
:: [OK] Ufw forwarding rule set
:: [OK] WireGuard is running
:: [OK] WireGuard is enabled (it will automatically start on reboot)
:: [OK] WireGuard is listening on port 51990/udp
[INFO] Run pivpn -d again to see if we detect issues
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://github.com/pivpn/pivpn/wiki/FAQ
=============================================
:::: WARNING: This script should have automatically masked sensitive       ::::
:::: information, however, still make sure that PrivateKey, PublicKey      ::::
:::: and PresharedKey are masked before reporting an issue. An example key ::::
:::: that you should NOT see in this log looks like this:                  ::::
:::: YIAoJVsdIeyvXfGGDDadHh6AxsMRymZTnnzZoAb9cxRe                          ::::
=============================================
::::		Debug complete		 ::::

Then I see that there is a problem with rules firewall ufw or ufw because PIVPN says me that UFW isn't active but if I see stats ufw say this:
Estado: activo

Hasta                      Acción      Desde
-----                      ------      -----
51990/udp                  ALLOW       Anywhere
Anywhere                   ALLOW       <IP_ADDRESS>
Anywhere                   ALLOW       <IP_ADDRESS>/gre
Anywhere                   ALLOW       <IP_ADDRESS>/24
51990/udp (v6)             ALLOW       Anywhere (v6)

Anywhere on eth0           ALLOW FWD   <IP_ADDRESS>/24 on wg0

Like you can see the wireguard ports is 51990.
I've tried much things:
-sudo pivpn -u and I return to install vipn + wireguard.
-Before I install vpn I tried to check that ufw it works ok with active status.
-Too, I've tried more things tthat I now don't remember, sorry!
Could somebody help me?
Thank you!! =)

It was not active but after this:
:: [ERR] Ufw is not enabled, try to enable now? [Y/n] y
El cortafuegos está activo y habilitado en el arranque del sistema

it is active. Try to use the VPN.

Hello,
Thank you very much for your answer.
Every time I enter the debug command it shows me the same error.
The main problem I forgot to comment on. When I use the client with VPN activated it has no internet connection.
Could you tell me if it's a problem that the firewall is limiting outgoing connections on the raspberry?
It can be that? How can I solve that?
Thank you!

Show the full pivpn -u output, and current sudo ufw status verbose output.

Thank you orazioedoardo!
pivpn -u output:
::: Preparing to remove packages, be sure that each may be safely removed depending on your operating system.
::: (SAFE TO REMOVE ALL ON RASPBIAN)
::: Do you wish to completely remove PiVPN configuration and installed packages from your system? (You will be prompted for each package) [y/n]:

sudo ufw status verbose:
Estado: activo
Acceso: on (low)
Predeterminado: deny (entrantes), allow (salientes), allow (enrutados)
Perfiles nuevos: skip

Hasta                      Acción      Desde
-----                      ------      -----
51990/udp                  ALLOW IN    Anywhere
Anywhere                   ALLOW IN    <IP_ADDRESS>
Anywhere                   ALLOW IN    <IP_ADDRESS>/gre
Anywhere                   ALLOW IN    <IP_ADDRESS>/24
51990/udp (v6)             ALLOW IN    Anywhere (v6)

Anywhere on eth0           ALLOW FWD   <IP_ADDRESS>/24 on wg0

THank you! =)

Sorry I was wrong, I actually need pivpn -d. The firewall is enabled though.

No problem! :) You are helping me! :)
::::		PiVPN debug		 ::::
=============================================
::::		Latest commit		 ::::
commit bfe611dbf112c60a6a880414d115ed274d524ea5 (grafted, HEAD -> test, origin/test)
Author: Orazio<EMAIL_ADDRESS>Date:   Sun Oct 25 19:07:13 2020 +0100

    Merge pull request #1168 from jeffrysurya/test

    add -D to create the folder
=============================================
::::	    Installation settings    	 ::::
PLAT=Ubuntu
OSCN=groovy
USING_UFW=1
IPv4dev=eth0
install_user=miuserlinux
install_home=/home/miuserlinux
VPN=wireguard
pivpnPORT=51990
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=<IP_ADDRESS>
pivpnHOST=REDACTED
pivpnPROTO=udp
pivpnDEV=wg0
pivpnNET=<IP_ADDRESS>
subnetClass=24
UNATTUPG=1
INSTALLED_PACKAGES=()
=============================================
::::  Server configuration shown below   ::::
[Interface]
PrivateKey = server_priv
Address = <IP_ADDRESS>/24
ListenPort = 51990
=============================================
::::  Client configuration shown below   ::::
::: There are no clients yet
=============================================
:::: 	Recursive list of files in	 ::::
::::	/etc/wireguard shown below	 ::::
/etc/wireguard:
configs  keys  wg0.conf

/etc/wireguard/configs:
clients.txt

/etc/wireguard/keys:
server_priv  server_pub
=============================================
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [ERR] Ufw is not enabled, try to enable now? [Y/n] y
El cortafuegos está activo y habilitado en el arranque del sistema
:: [OK] Iptables MASQUERADE rule set
:: [OK] Ufw input rule set
:: [OK] Ufw forwarding rule set
:: [OK] WireGuard is running
:: [OK] WireGuard is enabled (it will automatically start on reboot)
:: [OK] WireGuard is listening on port 51990/udp
[INFO] Run pivpn -d again to see if we detect issues
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://github.com/pivpn/pivpn/wiki/FAQ
=============================================
:::: WARNING: This script should have automatically masked sensitive       ::::
:::: information, however, still make sure that PrivateKey, PublicKey      ::::
:::: and PresharedKey are masked before reporting an issue. An example key ::::
:::: that you should NOT see in this log looks like this:                  ::::
:::: YIAoJVsdIeyvXfGGDDadHh6AxsMRymZTnnzZoAb9cxRe                          ::::
=============================================
::::		Debug complete		 ::::

It shows this, but if I return execute pivpn -d then I get return that ufw is not enabled and if I'm going to sudo ufw status verbose then I get state is active :(
THanks!

When I use the client with VPN activated it has no internet connection.

How? You haven't created a client ::: There are no clients yet
PLAT=Ubuntu
OSCN=groovy

Ubuntu 20.10 is not officially supported, though, what's the output of:
sudo -s
LANG="en_US.UTF-8" ufw status
exit

I understand friend that this version is not compatible, I mentioned it in the first message.
I have installed and uninstalled pivpn for testing purposes and I got tired of adding a user, sorry, I just added my iPhone as a user but it doesn't have internet access.
The output that this line has is the following:
Estado: activo

Hasta                      Acción      Desde
-----                      ------      -----
51990/udp                  ALLOW       Anywhere
Anywhere                   ALLOW       <IP_ADDRESS>
Anywhere                   ALLOW       <IP_ADDRESS>/gre
Anywhere                   ALLOW       <IP_ADDRESS>/24
51990/udp (v6)             ALLOW       Anywhere (v6)

Anywhere on eth0           ALLOW FWD   <IP_ADDRESS>/24 on wg0

root@equipo-ubuntu:/home/miuserlinux#

I think the problem is in ufw and raspberry, but I can't figure out why Ubuntu and pivpn don't show ufw as active when in fact, it is activated ...
IF you can think of something else I will be grateful.
Regards my friend.

UFW is active but the debug shows inactive because the script check for the 'active' string in the output of the ufw status command. However for some reason you do not have the English locale available alongside Spanish, you can safely ignore that.
For this reason, I think your issue is different. Generate a new client (if you uninstall the old client won't work) and follow these steps: https://github.com/pivpn/pivpn/wiki/FAQ#how-do-i-troubleshoot-connection-issues

No replies in a while, closing...


travis: fix repo filter

One more post-rename thing :D

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   78.62%   78.62%
=======================================
  Files          29       29
  Lines        2914     2914
=======================================
  Hits         2291     2291
  Misses        372      372
  Partials      251      251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df1b7f...7298017. Read the comment docs.


"bundle execute rake" in README.md doesn't work

The README says to run this command:

bundle execute rake # Run all CMock library tests

However, I get this error message when I do it on my system:

Could not find command "execute".

I don't know what the command should be instead.
It may also be useful to mention that Ruby should be in your PATH and the bundle gem installed.

I think it's supposed to be exec instead of execute, but I don't know what parameter to pass:

$ bundle exec rake
rake aborted! Don't know how to build task 'default'

bundle exec rake spec

As of this commit bundle exec rake works.

Thanks for checking dpostorivo. I hate to test the installation issues myself. It doesn't prove much to say that it works on my (development) machine!