Fix error in the console: double free or corruption (!prev) at exit of GDnative C++ application

Should resolve #47607.

Would be great to get feedback from @sash-rc who reported the issue, or someone else who can test with the C++ binding 🙂

@sash-rc confirmed the fix works for him on the 3.x branch.
We haven't had anyone test this on master directly, but it's probably OK, as the 3.x changes match the ones in this PR.

Thanks!

Cherry-picked for 3.3.

Sorry for the late response here but I think we introduced a new issue here again. We're only supposed to clean the library up inside of this condition:
if (G && G->get()->get_library()->is_reloadable()) {

If the library is not reloadable (like with VR plugins) then when this logic triggers we clean up all the meta data but leave the library loaded. As soon as a new object is constructed the meta data is missing and the application will break.
I should have caught this in the previous PR


Backport [mbedtls-2.16] : Init function variable to avoid compiler warning

Issue : https://github.com/ARMmbed/mbedtls/issues/2340
https://github.com/ARMmbed/mbed-crypto/pull/228

Needs a ChangeLog entry

Since we didn't managed to reproduce or find the issue, this change is only a robustness improvement and not a bugfix. I don't think we need a Changelog entry for this.

I think that this requires a ChangeLog, to credit the person that raised the issue

Closing as not needed and not the right fix. Re-open if you can reproduce the error and know how to fix the real error (as opposed to masking it with blind initialization).


changing priority in server pool is not reflecting in script config

The request is updating the DB but not calling the script to configure the LB's

Fixed in commit 40f997c33b7c6f8c41c832ab381dc0be4a294147


typo in add your data example

Removes a typo in the add your data example code.

@achingbrain - Who needs to kick the next step of this CI process?

@lidel Are you able to kick this one also? I think you may have permissions than I do in this repo. 🙏


"Dynamic observable objects cannot be frozen" on non-observable object style

I met the error in the title, and after debugging I finally identified the line causing the error which is:

this JSX, and when I remove the style attribute above, exactly the same code works without the error. I saw the the description about this error in CHANGELOG, but seems like this doesn't apply to me as it's just a plain object.
Giving bit more of the context, here's the gist of the code

function renderContent() {
  // here's the style tag that's likely to be causing the issue
  return (

  )
}

const modal = observable({content: null})

class Modal extends Component{
  ...
  render() {
    return <Modal>{modal.content}</Modal>
  }
}

function showModal(content) {
  modal.content = content

showModal(renderContent())

Minimum and rough but the gist is something like above, trying to render the JSX returned from a function, which is stored in an observable object. This Modal part of code is working in the other part of the app, so I'm guessing there's something wrong with the content it's trying to render.
Can anybody figure out what's going on here?

@mweststrate
Thanks so much, was able to reproduce exactly the same thing in codesandbox.
But now observable.shallow is raising [mobx] Incorrect decorator invocation. @observable decorator doesn't expect any arguments, which also happened in my local environment. Here's the codesandbox, am I misunderstanding something here?

Sorry, shallow is the decorator indeed, you can use observable({ contents: null }, { contents: observable.ref }) instead
Op do 27 dec. 2018 om 12:08 schreef Ryo Yamada<EMAIL_ADDRESS>
@mweststrate https://github.com/mweststrate
Thanks so much, was able to reproduce exactly the same thing in
codesandbox.
But now observable.shallow is raising [mobx] Incorrect decorator
invocation. @observable decorator doesn't expect any arguments, which
also happened in my local environment. Here's the codesandbox
https://codesandbox.io/s/4rz19ppvy7, am I misunderstanding something
here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx-react/issues/628#issuecomment-450130850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhIacxwNnAB0KRhMMSPPL_gzOwbvvks5u9Ko8gaJpZM4ZiYUc
.

@mweststrate
That did it, sorry should have read the document there. Thanks for the quick response and the great library I really appreciate!


[Microsoft.ApiManagement/service@2024-05-01]: fails to deploy to Azure

Resource Type
Microsoft.ApiManagement/service
Api Version
2024-05-01
Issue Type
Resource fails to deploy
Other Notes
I'm getting the following error when trying to deploy API Management with version 2024-05-01 (types.md).
No registered resource provider found for location 'westeurope' and API version '2024-05-01' for type 'service'. The supported api-versions are '2014-02-14, 2015-09-15, 2016-07-07, 2016-10-10, 2017-03-01, 2018-01-01, 2018-06-01-preview, 2019-01-01, 2019-12-01-preview, 2019-12-01, 2020-06-01-preview, 2020-12-01, 2021-01-01-preview, 2021-04-01-preview, 2021-08-01, 2021-12-01-preview, 2022-04-01-preview, 2022-08-01, 2022-09-01-preview, 2023-03-01-preview, 2023-05-01-preview, 2023-09-01-preview'. The supported locations are 'centralindia, uaenorth, australiacentral, germanywestcentral, westcentralus, norwayeast, switzerlandnorth, koreasouth, westindia, koreacentral, southafricanorth, ukwest, brazilsouth, eastasia, southindia, canadacentral, canadaeast, australiasoutheast, japaneast, northcentralus, southeastasia, westus2, centralus, uksouth, australiaeast, japanwest, westus, francecentral, southcentralus, eastus2, eastus, northeurope, westeurope, westus3, jioindiacentral, jioindiawest, swedencentral, qatarcentral, polandcentral, italynorth, spaincentral, mexicocentral, israelcentral'.
This version is also not documented on https://learn.microsoft.com/en-us/azure/templates/microsoft.apimanagement/service?pivots=deployment-language-bicep.
Bicep Repro
No response
Confirm

[X] I have read the troubleshooting guide and looked for duplicates.

Seems the ARM schema itself is still not available yet here: https://github.com/Azure/azure-resource-manager-schemas/tree/main/schemas/2024-05-01

Issue seems resolved, schema file generation is working again. Just validated a deployment using this api version

Issue seems resolved, schema file generation is working again. Just validated a deployment using this api version

Have been running into this as well and just gave it a try, it seems like not everything is working yet, getting the error below on Microsoft.ApiManagement/service/apiVersionSets

API version query parameter is not specified or was specified incorrectly.  Supported versions: 2014-02-14-preview,2014-02-14,2015-09-15,2016-07-07,2016-10-10,2017-03-01,2018-01-01,2018-06-01-preview,2019-01-01,2019-12-01-preview,2019-12-01,2020-06-01-preview,2020-12-01,2021-01-01-preview,2021-04-01-preview,2021-08-01,2021-12-01-preview,2022-04-01-preview,2022-08-01,2022-09-01-preview,2023-03-01-preview,2023-05-01-preview,2023-09-01-preview,2024-06-01-preview  Example query param format: api-version=SupportedVersion

I've noticed the parent resource 'Microsoft.ApiManagement/Service' is now resolved. All the other child resources still fail on this particular error indeed.


fixFix show mtmv time should wrapped in double quotation marks

Fix show mtmv time should wrapped in double quotation marks

run buildall

run cloud_p0


Correct migration issues that are causing collection records to include activities like the one below.

It's not clear to me if these are errors in the migration that need to be addressed so that these don't show up, or if they just need to be more understandable.

If these are important for the users to see in the log, then we should make them understandable to the user.

This is just a missing translation value in here: https://github.com/sul-dlss/happy-heron/blob/main/config/locales/en.yml#L10-L17


Repo restructure and Events tutorial addition

Notes

Restructured repo s.t. example code for different services/efforts is found in different folders.
Changed .gitmodules to place lambda_conversion_hook_example under comprehend_groundtruth_integration.
Changed root README.md to directory of subpackages.
Added Events tutorial code.

Sorry, no, I didn't see that. Could you re-merge?

Approved, restructuring the GT code and adding Events code


[Fix] Broken Windows Build with LLVM

PR #16032 introduces a more stable way of zstd path finding by relying on LLVM's existing Findzstd module, but it turns out that the cmake dir from llvm-config is not very compatible with CMake's internal convention, and thus a conversion is required to get rid of the error message below:
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD

    D:/a/package/package/tvm/build/CMakeFiles/CMakeScratch/TryCompile-tnlfb1/CMakeLists.txt:2

-- Configuring incomplete, errors occurred!
  when parsing string

    C:\Miniconda\envs\tlcpack-build\Library\lib\cmake\llvm

  Invalid character escape '\M'.

CC @lhutton1

Thanks for checking the windows build @junrushao!


[bug] json output is off by one

⏯ Playground Link

Playground link with relevant code
💻 Code

Code:
ObjectName.increment_counter(
  foo="bar",
  tags=[
    f"tag_name:'{tag_value.an_id}'"
  ],
)

Pattern:
rule:
  kind: keyword_argument
  regex: (?i)(?:\{id\}|\{.+_id\}|\{.+\.id\})
  inside:
    pattern: ObjectName.increment_counter($$$)
    stopBy: end

🙁 Actual behavior
The start and end lines for all json output are off by one. I am using a VS Code task with a problem matcher to display squiggly lines when ast-grep finds an error, but the squiggly lines currently show up on the wrong line because of this.

✅ ast-grep scan shows the correct start line and column (3:3)
✅ ast-grep scan --format github shows the correct start and end lines (line=3,endLine=5)
❌ ast-grep scan --json=stream lines off by one ({start: {line: 2}, end: {line:4}})
❌ ast-grep scan --json=pretty lines off by one ({start: {line: 2}, end: {line:4}})
❌ ast-grep scan --json=compact lines off by one ({start: {line: 2}, end: {line:4}})

🙂 Expected behavior
I expect the start and end lines in the json output to be the same as those from other output formats.

✅ ast-grep scan --json=stream should show ({start: {line: 3}, end: {line:5}})
✅ ast-grep scan --json=pretty should show ({start: {line: 3}, end: {line:5}})
✅ ast-grep scan --json=compact should show ({start: {line: 3}, end: {line:5}})

JSON's output line and column is zero-based because most of programming language is zero based.

Also, if you need to display errors. https://marketplace.visualstudio.com/items?itemName=ast-grep.ast-grep-vscode the official LSP plugin is recommended.

okay that's fair, we were trying this because the vs code extension doesn't work on my teams codebase right now. but, that's unrelated to this repo, so I'll just open an issue on the vs code extension repo


Combine Videos Not working

Combine two videos always show invalid arguments .

@LovekeshSaini Can you please share your query?

Same here. Downloaded the sample app. Combine image and videos and combine videos not working. Also cannot find where files are saved in android 12.

any news ?


Eri9600/geodesic operations kotlin

Geodesic Operations Sample in Kotlin
https://devtopia.esri.com/runtime/common-samples/issues/200

@TADraeseke Fixed the items you pointed out in the PR.


[Question] How can I generate arb file from dart file ?

Before migration to your library, I was using intl_translation and there it was possible to generate arb file based on the dart file
localizations/app_localizations.dart in my case
with structure like
class AppLocalizations {
  AppLocalizations(this.localeName);

  static Future<AppLocalizations> load(Locale locale) {
    final String name =
        locale.countryCode.isEmpty ? locale.languageCode : locale.toString();
    final String localeName = Intl.canonicalizedLocale(name);
    return initializeMessages(localeName).then((_) {
      return AppLocalizations(localeName);
    });
  }

  static AppLocalizations of(BuildContext context) {
    return Localizations.of<AppLocalizations>(context, AppLocalizations);
  }

  final String localeName;

  // login and registration
  String get prompt_email => Intl.message('Email', name: 'prompt_email');

  String get prompt_password =>
      Intl.message('Fjalёkalimi', name: 'prompt_password');

I could run before
flutter pub run intl_translation:extract_to_arb --output-dir=lib/l10n lib/localization/app_localizations.dart

and this generated arb files, that could then modify/translate, then generate the dart files for every locale (which is working fine with your library this part too by  flutter pub run intl_utils:generate

Hi @kristijorgji
The idea with intl_utils is to use your ARB files as a source of truth for your string keys, and only generate Dart files from it with intl_utils:generate command.
So, you should always add/manage string keys in ARB files and this package with generate all Dart code from it.
 The string key getters will be available for usage in your Dart code right after that.

@aleksakrstic Hi thanks for info, we migrated then to this version but are having some issue with bugs in your generator and plugin. Would be great if can get support to fix those soon then looking forward to manage translations online in your platform
Tickets for bugs i created are:
https://github.com/localizely/intl_utils/issues/58
and
https://github.com/localizely/flutter-intl-intellij/issues/71


[jobset] Partial-Admission KEP

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Briefly outline what is needed in order to support partial admission for pod-sets.
Which issue(s) this PR fixes:

Relates to #820
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

cc @thebinaryone1

/remove-lifecycle stale


Pasted text sometimes appears at the beginning of the line instead of at the cursor position

Reported via email.

Fixed via  https://github.com/calculist/app.calculist.io/commit/0316a6efb5e16b3f56919ac31b842ddd48da5c9a


Error outeput from restic prune

Output of restic version
restic 0.9.6 compiled with go1.13.4 on linux/amd64

Describe the issue
Restic is running on a Synology DSM 918+ doing offsite backup to Wasabi
I get the following error when running restic prune
repository 27b7f3ca opened successfully, password is correct
counting files in repo
building new index for repo
[14:58] 100.00%  87026 / 87026 packs
repository contains 87026 packs (433060 blobs) with 406.435 GiB
processed 433060 blobs: 0 duplicate blobs, 0 B duplicate
load all snapshots
find data that is still in use for 44 snapshots
[0:24] 100.00%  44 / 44 snapshots
Fatal: number of used blobs is larger than number of available blobs!
Please report this error (along with the output of the 'prune' run) at
https://github.com/restic/restic/issues/new

So, reporting the error. If you need more info dont hesitate to ask

Please see #2045

ok. have looked there. Could not find a solution or explanation as to the error.

What output does restic check generate (please store a full copy of the output somewhere, in case the full output might become relevant later on)? I'm especially interested in whether it complains about "pack <...> not referenced in any index" or "pack <...> does not exist". Does it report any missing trees or blobs?
Does the error still show up if you start prune a second time?
How often do you run the check and prune commands? Did something unusual happen before the prune error showed up, like an interrupted / crashed backup?
The error usually indicates that some data blobs were lost. If the prune error persists on a second run, you should run restic rebuild-index (but please run restic check before and keep a copy of the full output) as soon as possible to rebuild the index and ensure that it does not refer to missing data blobs.

Hi. Sorry for the late reply.
Se attached files for output from commands ran in following order:
1: Restic check
2: Restic prune
3: Restic prune
4: Restic rebuild-index
5: restic prune
01check_before_output.txt
02prune_after_first_check.txt
03second_prune_after_first_check.txt
04rebuild_index.txt
05prune_after_rebuild_index.txt

Hmm, something strange is happening here:

The check run does not complain about not referenced or missing packs, which means that the index contained every pack. But still some blobs were missing. Thus some data is missing from the repository.
The next two prune runs fail, but until then their results are identical.
rebuild-index seems to be ok.
The last prune run should just yield the same results as before. However, it is for some reason three times slower and reports errors for packs that seemed to be fine before.

Can you manually download one or two of the "incomplete pack files" from wasabi and check whether their sha256 hash matches (shasum -a 256 <filename>)? They should be store with a filename like data/<first two characters>/<hash>, e.g. data/db/db51b607eee8d3a804f90519b568f4543050e5b8e24b10a4f5e77623b9cd9776.
As I look like you are still backing up into that repository, please follow these steps to make sure that new backups are (quite likely) not affected by these errors:

Run rebuild-index (which you already did) to make sure that the index only references chunk that actually exist.
Run backup -f <path...> to have restic fully rescan all files and upload any missing chunks. The important part here is the -f (=--force) flag.

Closing this issue as it can't be investigated further without additional feedback.


Change format of existing dm templates

update format of existing dm templates to new format

Please move this issue to the kubernetes/helm repo.

@runseb a quick scan of the charts suggests that most if not all of the existing dm templates have been converted into the new chart format. Can this issue now be closed?

Closing this as charts have been cleared as of #18


Fix 'campgrounds' mandatory parameters 'start-date' documentation

Block on #91

Thanks for this @acaloiaro. What's the plan for the merge order of these two PRs?

Because of the _version.py dependency, I figured it would make more sense for #91 to be merged first since it would create an odd git history if a later version was merged into history before an earlier one. I'll defer to your expertise on the project here :)

With that said, if you'd be interested in using python-semantic-release, I'd be happy to open a PR that adds automatic versioning to the current Github Actions. That would make merge ordering moot, as the value in _version.py would be bumped in merge sequence.
One caveat with python-semantic-release is that it mandates using Angular's commit message format (https://gist.github.com/brianclements/841ea7bffdb01346392c#type), which some people understandably find onerous.

Also @juftin -- if #91 is merged first I can rebase main onto this branch to get the documentation fix.

Hey @acaloiaro that plan sounds good. #91 was just merged, let's rebase and go with this.
I'll check out the Auto Version Incrementing out and consider it, it sounds useful. I'm a big fan of my existing release infra, release-drafter/release-drafter in GitHub Actions.  An ideal solution in my mind would compliment that and probably use GitHub Actions to auto-increment a version based on labels (like minor, major, patch`).

Hey @acaloiaro that plan sounds good. #91 was just merged, let's rebase and go with this.
I'll check out the Auto Version Incrementing out and consider it, it sounds useful. I'm a big fan of my existing release infra, release-drafter/release-drafter in GitHub Actions. An ideal solution in my mind would compliment that and probably use GitHub Actions to auto-increment a version based on labels (like minor, major, patch`).

Yeah that sounds sensible. I've always used semantic version's publish command which versions and pushes to github releases, but it also has a version command which only increments versions in code and commits the change. That might be worth looking into as a complement to release-drafter.

Rebase done -- everything should be good to go.


Hello, Dude. Sorry to bother you, but there is still a problem with the write string function, and I have also discovered a new issue regarding the read double type function

Hello,Dude. I'm sorry to bother you again. I tested the new code and found that reading the string is normal, but I found that writing the string still has no effect. As shown in the picture, I also discovered a new problem where the double type reading function is not working. I tried to solve it, but I found that I couldn't solve it

I tried to solve it. Read_string and write_string are completed. Double reading and writing require you to test different addresses. Currently, I don’t have a physical PLC around me. So it cannot be guaranteed to be completely correct.
use tag :v0.0.3

我靠( ‵o′)凸，原来还有国际友人用这个，大佬真牛逼


MDArray::read_into_slice(): make it robust to too small buffer

I'm not totally sure if it is the right approach because I changed the signature from accepting a slice to requiring a Vec.
Perhaps the right fix would be to remove the "pub" qualifier of that method as it is rather low level, or tag it as unsafe

But anyway, I think we can leave it as a slice (buffer: &mut [T]) and check the length like if buffer.len() < pixels. Slices know their length.

That wouldn't work because the read_as() method uses Vec::with_capacity(pixels); before calling read_into_slice() on it. Such vector has .len() == 0. read_as() calls set_len(pixels) afterwards. I've just tested that calling set_len() before calling read_into_slice() works however.
Line 230 of mdarray.rs refers to #examples-18 to justify this pattern, but I suspect this is now https://doc.rust-lang.org/std/vec/struct.Vec.html#examples-21 . Not obvious to me if it would be fundamentally wrong to set_len() before read_into_slice()

Good point, I missed that call. Just filed an alternative implementation that splits the function in two instead, hope you don't mind.

Not obvious to me if it would be fundamentally wrong to set_len() before read_into_slice()

Yes. It would probably be "harmless" in this case, but for something like:
    let mut vec: Vec<String> = Vec::with_capacity(200);
    unsafe { vec.set_len(vec.capacity()) };

    for i in 0..vec.capacity() as isize {
        if i == 50 {
            panic!();
        }
        unsafe { std::ptr::write(vec.as_mut_ptr().offset(i), String::new()); }
    }

the panic works just like a C++ exception (it is one, actually), so the Drop implementation (destructor) of vec will try to destroy 200 elements. If we call vec.set_len at the end, this is "just" a memory leak.

closing as superseded per https://github.com/georust/gdal/pull/480


Authentication Refresh Interval Enforcement

Description
Hi,
thanks for the useful fuzzer and your additional resources!
I'm still new to using RESTler, so hopefully my question makes sense...
I am using authentication with a set refresh interval (tokens are invalidated after a certain time if not refreshed). This seems to work great, but now I noticed that I run into a situation where the invalid value checker seems to not renew the token in time. If the checker runs longer than the refresh interval (for a specific sequence) the last x requests of that sequence all run into "403 Forbidden". After that, a new sequence is rendered and the token seems to be refreshed just fine again.
I tried reducing the refresh interval, but this does not seem to have any effect (for above problem). For me it looks like the refresh time is not checked in between the rendering of sequences. I would have expected that the freshness of the authentication token would be checked on every request (maybe in "send_request_data()").
Now I'm wondering if I misunderstand/misconfigured RESTler (maybe a checker is not supposed to run for this long on a single sequence?) or if this is an issue that other people also encountered.
I would love to hear your input on this.
Thanks & best regards
Tina

Hello Tina,
Thank you for reporting this issue.  This is a bug in the implementation of the invalid value checker - we will fix this ASAP.
Thanks,
Marina


Bazel build fails throwing errors

I have been following your excellent tutorial on building Tensorflow on TX1 from sources.
When I run the installPrerequisites.sh in both the version of tags (vL4T28.1TF1.3 & vL4T27.1TF0.11), the bazel is not building properly and throwing an error.
I am using Jetson TX1 - L4T 24.2, Ubuntu 16.04
Error when tried vL4T28.1TF1.3 : Bazel 0.5.2
I tried multiple times and each time it is showing same error at different files. The error is,
java.lang.InternalError: Cannot find requested source bundle for locale en_US at(list of files) Caused by: java.util,MissingResourceException: Can't find bundle for base name com.google.errorprone.errors, locale en_US
Target //src:bazel failed to build
Error when tried vL4T27.1TF0.11: Bazel 0.3.2
When I tried this version, the error is
Error: Java compilation in rule 'Filename': Javac worker (id 0) can no longer be used, because its process terminated itself or got killed.
Target //src:bazel failed to build
Could you please help me resolve this?
And also can you tell how you are finding what versions of bazel to be used for certain versions of Tensorflow?
Note: I am able to use both the prebuilt whl file from your website.

@lachinaj
Excuse me, can you show the detail after run the following two commands ?
1.apt-get remove oracle-java8-installer
2.apt-get install openjdk-8-jdk
you say don't run the ./installPrerequisites.sh again to avoid re-installing the wrong jdk !
and what should I do after run these two commands and get the bazel to /usr/llocal/bin !
Thanks for help !

your jdk version may be the key.When it occurs , i change it to jdkU121,and it works.
download jdkU121
sudo vim ~/.bashrc
export JAVA_HOME=/usr/lib/jdk/jdk1.8.0_121
export JRE_HOME=${JAVA_HOME}/jre
export CLASSPATH=.:${JAVA_HOME}/lib:${JRE_HOME}/lib
export PATH=${JAVA_HOME}/bin:$PATH
reboot and chek java -version


docs: Remix Support?

Area of Improvement
I've heard folks mention that upload thing supports Remix. It looks like it's possible to piece it together based on fetch runtimes etc  but it would be nice to have some docs that explain how to do this.
Link to related docs
No response
Additional information
No response
👨👧👦 Contributing

[X]  🙋♂ Yes, I'd be down to file a PR implementing the suggested changes!

It looks like it's possible to piece it together based on fetch runtimes etc

yeah, it should be, I know a few people have mentioned getting it working in the discord. Personally, I have not had a chance to go through and set it up myself.

it would be nice to have some docs that explain how to do this.

Agreed, if you are feeling up to it, definitely submit a PR, either with docs or a minimal example (or both 👀)

Has anyone written about this or is there a repo I can take a look at to see how this upload thing is connected in remix?

Still working on getting SSR working, but here's a basic example.
https://github.com/markflorkowski/uploadthing-remix-sample
Keep in mind neither myself nor Julius are regular users of Remix, so there may be better ways to do this.

@markflorkowski This works thanks.
I am getting this ts error though for UploadButton
Type '{ endpoint: string; onClientUploadComplete: (r: any) => void; }' is not assignable to type '"You forgot to pass the generic"'

I seem to have passed the generic as you have mentioned here
import { generateReactHelpers, generateUploadButton } from '@uploadthing/react'
import { UploadRouter } from '~/routes/api.uploadthing'

export const { useUploadThing } = generateReactHelpers<UploadRouter>({
	url: new URL('http://localhost:5173/api/uploadthing'),
})
export const UploadButton = generateUploadButton<UploadRouter>({
	url: new URL('http://localhost:5173/api/uploadthing'),
})

Check your imports, I was able to repro that error if I imported UploadButton from the package instead of the generated one
- import  { UploadButton } from "@uploadthing/react";
+ import  { UploadButton } from "~/utils/uploadthing";

Ah didn't realise that was the issue since the files were still being uploaded .
Thanks a lot!

You can close this.


Keyword amount

Thanks a lot for this awesome free plugin! It’s really helpful. Is there any way to tweak the number of keyword results?

I suppose you are using Gemini 1.5 flash, and on some pictures you're receiving a aweful lot of keywords? There's no other solution other than using Gemini Pro at the moment. It seems to be a bug in Gemini flash. I already tried adapting the phrase, which is ignored unfortunately.

If we can control the amount number of keywords being generated, that would be awesome

Oh I see, just let me know if those problems are fixed, I really like your work

As mentioned I added support for Gemini 2.0 flash to the plugin. Could please go ahead and try if Gemini 2.0 still has this issue?

So the issue, that for your liking there are too little keywords generated. Could you be specific which kind of descriptive keywords are missing?


Fix bug where X-Forwarded-For is returned as one string

I ran this behind cloudflare, and noticed that when you do a curl update it returned:
{"current_ip":"xxx.xx.xxx.xx, xxx.xxx.xx.xxx","status":"Successfully updated"}
instead of
{"current_ip":"xxx.xx.xxx.xx","status":"Successfully updated"}
This was happening because
headerData, ok := req.Header["X-Forwarded-For"]
headerData[0] was returning both ips as one long string and not just the first ip
I added a small check that takes only the first IP.

According to Cloudflare documentation https://support.cloudflare.com/hc/en-us/articles/200170986-How-does-Cloudflare-handle-HTTP-Request-headers- they are appending the IP-Address of each proxy server to the X-Forwarded-For header. They suggest to use the CF-Connecting-IP header for getting the client ip address and because of that I'm thinking about making the "IP address header" configurable so that ddns can use CF-Connecting-IP when placed behind Cloudflare.

For the sake of automatic deployment without intervention, I'd skip best programming practices and just add built-in support for Cloudflare - first check CF-Connecting-IP and if not successful get back to the good old X-Forwarded-For.
What do you think?

This would add an attack vector when ddns is not placed behind Cloudflare like when its placed behind caddy (the suggested deployment method) a user could send a CF-Connecting-IP header with any IP address via curl and it would not be stripped/overridden by the webserver (X-Forwarded-For would be replaced by any webserver because it is "standard"). There are probably also other service providers with different "Client IP headers".
Because of that I would add a config option client-ip-header in shared/config.go which defaults to X-Forwarded-For. Then we could add {$DDNS_ADDITIONAL_ARGS} to the CMD in docker/ddns/Dockerfile. And finally we could add a section to the README that suggests adding the following environment variable to the docker-compose.override.yml when placed behind Cloudflare:
services:
  ddns:
    environment:
      # .....
      DDNS_ADDITIONAL_ARGS: "--client-ip-header=CF-Connecting-IP"

With that we can support all possible headers without changing ddns itself.

Oh, true.


ADD: terra-standalone package

spack install -j 1 terra-standalone%gcc

spack install -j 1 terra-standalone%gcc

launch jenkins -j 1 terra-standalone%gcc

launch jenkins -j 1 terra-standalone%gcc

launch jenkins -j 1 terra-standalone%gcc

launch jenkins -j 1 terra-standalone%gcc

Varun and Elsa confirmed this is obsolete by now.


CString’s are printed wrong

Describe the bug
A CString string is always printed only with the first char.  Conversion to LPCTSTR has the same effect.
To Reproduce

Windows C++17 v142
Just print a CString

Not sure what you mean with CString
Please provide a code example

I see.
This is not supported. Please see the documentation for how to use G3log
Stick to standard C++ and not OS specifics string handling and it'll work


Schema for "name" should have a .node/kind [phab:T144]

Created by pludemann at 2016-06-21 20:37:59:
http://www.kythe.io/docs/schema/#name
I think that this should have an additional line:
Cdecl.node/kind name
It would also be nice if the example also gave Cname=vname(...), even if it's C++ specific.
(A Java example could be added if clarification is needed)

pludemann wrote at 2016-10-18 02:19:56:
The example at http://kythe.io/docs/schema/#name does not have a name node; it has a defines/binding and a named edge.
Please clarify how name should be used (as opposed to, for example, variable) and explain why there's a link to http://kythe.io/docs/schema/#lsr
Also, I don't understand the description: "A name identifies zero or more nodes." (do you mean that named can be applied to link multiple nodes to the same name?)

pludemann wrote at 2016-10-18 17:47:38:
There's more discussion here, which should probably get added to the Schema documentation:
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/kythe/N_18ReHJPfA/mXWsM3P6BgAJ

revision #1261


How to reproduce the Hyena-Imagenet experiment result simillar with the paper?

Hello all,
I am trying to reproduce the Imagenet task with your great work!
After the installation is done with the procedure with the repogitory, I try the command ''python -m train wandb=null experiment=imagenet/hyena-vit" on the experiments.md.
In my system, there are 4ea of A6000, so I changed the number of device from 8 to 4 in hyena-vit.yaml
At the last epoch ends, I get the message just like the below.
Epoch 304: 100%|█| 2893/2893 [20:58<00:00,  2.30it/s, loss=4.29, val/accuracy=0.685<EMAIL_ADDRESS><EMAIL_ADDRESS>val/loss=1.510, train/accuracy=0.452<EMAIL_ADDRESS><EMAIL_ADDRESS>In my recognition, the val/accuracy should be similar with 79.8 that the result on the paper.
Is there any fault while the training step?
the attachment is training config file, If there any mistake that I did, please let me know about it...
Or, is it possible to request the checkpoint file of vit_hyena?
Thank you.
config_tree.txt

Hello!  The first thing to change is:  num_inner_mlps = 2


Wizard form with same relationship in multiple steps doesn't work

Package
filament/filament
Package Version
3.2.92
Laravel Version
11.11.0
Livewire Version
2.9
PHP Version
8.2
Problem description
Hello, i've a project with a multi step wizard where the users can upload files, the files are uploaded in related entities via relationship()
I've noticed that when we have multiple step with relationships, the related fields of type FileUpload are not prefilled. When there is only a relationship the files loads correctly.
In the reproduction repo i've created, the forms fails to load with the error
foreach() argument must be of type array|object, string given at filament/forms/src/Components/BaseFileUpload.php :712
Expected behavior
Every step pre fills file correctly
Steps to reproduce

Download the reproduction repo git clone https://github.com/se09deluca/filament-wizard-fileupload-relation
run cp .env.example .env
run composer install
run php artisan key:generate
and start it with php artisan serve.

Then try to edit the pos resource present. I've  uploaded the sqlite db and sample file for an easy reproduction.
Reproduction repository (issue will be closed if this is not valid)
https://github.com/se09deluca/filament-wizard-fileupload-relation
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Hello @zepfietje !
Did you try the reproduction repo / did you analyze the issue ?
I would like to know if there're some chances this can be resolved shortly or not. If it takes to long just let me know and i'll consider the switch to another technology.

I’ve just come across this thread and I’m having the same issue in a slightly different context.
I have a User model and a Profile model. Each User hasOne Profile. A Profile is just extended data for the User record; avatar, bio, title, social media, etc.
In my UserResource form, I have 3 tabs: Account, Profile, Social Media. The Account tab has fields for name and email, the Profile tab has a Group::make()->relationship('profile'), it contains a FileUpload::make('avatar_path') field and text fields for bio and title. The Social Media tab also has a Group::make()->relationship('profile'), it contains some text fields for social media URLs.
This causes the same error described above: foreach() argument must be of type array|object, string given at filament/forms/src/Components/BaseFileUpload.php :712
The data for FileUpload fields are not handled correctly when there are multiple instances of the same relationship on a form. The second Group::make()->relationship('profile') overwrites the state of the relationship. When there is no FileUpload::make('avatar_path') field present in the second group, the avatar_path state is left as a string instead of transformed into an array by the FileUpload field. See the getUploadedFileUsing callback in the setUp of BaseFileUpload.
A workaround for my scenario was to add FileUpload::make('avatar')->hidden() to the Group schema in the Social Media tab. This way the state path for the avatar_path field is always handled correctly.


mwpw-145916 display review widget and footer on upsell screen

Resolves: MWPW-145916
The review widget and footer were hidden on upsell screen for fill&sign verb due to an experiment (they tested the fill&sign widget on full screen).
Now that the experiment is rolled back, we should display review widget and footer.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.16%. Comparing base (bba3be7) to head (7a5a42a).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #626      +/-   ##
==========================================
- Coverage   98.17%   98.16%   -0.01%
==========================================
  Files          34       34
  Lines        4099     4098       -1
==========================================
- Hits         4024     4023       -1
  Misses         75       75

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

remove lines 67-68 also

@peller thanks for the review, I've deleted those lines as well


Update Who Paid section when can modify participants

Details

Web - Mouse cursor is shown as hand icon (on a not clickable section) on who paid, split bill.
Fixed Issues

$ https://github.com/Expensify/App/issues/21695
PROPOSAL: https://github.com/Expensify/App/issues/21695#issuecomment-1609843032
Tests

Click Global Create or FAB (+) -> new group -> select members.
Click create group.
Now it should show a new group page.
Click Actions Button (+) on the Composer -> Split Bill -> type the amount -> next.
Hover over the "Who paid?" section and verify the cursor is the not-allowed (disabled) style.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/13113013/c9df8cd8-72ba-4423-ba4f-c3547c7ba9e4

Mobile Web - Safari

https://github.com/Expensify/App/assets/13113013/24e47484-91eb-4a28-8275-e6c05064c176

Mobile Web - Chrome
https://github.com/Expensify/App/assets/13113013/41efda04-159b-46b5-bfee-0b0a7812e318

Desktop
https://github.com/Expensify/App/assets/13113013/4d679a20-f127-4a70-830d-84397b709fed

iOS
https://github.com/Expensify/App/assets/13113013/ca232012-c685-460b-aa83-dd3697131bca

Android
https://github.com/Expensify/App/assets/13113013/b0485944-3b20-412f-aeee-5881cd60da7b

@chiragsalian please assign me as reviewer.

@ginsuma This looks really over-engineered, this was not the proposal which was approved. Seems you updated the proposal after assigning you.
Can you explain why you made these changes?

Maybe I miss understood, We can select the user by clicking anywhere in the row, showing disabled only there near the check mark alone does not make sense and it's kind of misleading as we still show the cursor over the user name. Disabling the whole row should be good only when it's from a group.
cc: @amyevans any thoughts?

Yes looks good 👍
cc: @shawnborton @amyevans

I think this makes sense, so all good on my end. Curious for @amyevans's thoughts too.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@ginsuma Fix the lint checks.
Make sure you linked the issue properly issue as follows
$ https://github.com/Expensify/App/issues/21695 not as #21695
In preview, both will look like #21695  so don't get confused!
Tests steps could be improved
Step 1
Instead of
Go to '+" -> new .....
Modify as
Click Global Create or FAB (+) -> new...
Step 4
Click Actions Button (+) on the Composer ->  Split ....

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Updating the throttling limit section

Docs Build status updates of commit f461c70:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Articles/connectors/API.md
:warning:Warning

Details

Articles/connectors/API.md

Line 16, Column 1: [Warning-code-block-indented] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 0, Column 0: [Suggestion-external-image] Image 'https://run.pstmn.io/button.svg' references an external site. This poses a security risk and external images are unavailable in some environments. Reference an image file within the repo instead.
Line 18, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fix(NavigationMenu): add missing overflow-x-auto for horizontal

🔗 Linked issue

Resolves #2468
Follow-up of #2469
@sandros94
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
https://github.com/user-attachments/assets/1864d2d7-79a5-49c9-8238-5e932b80e092

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks @Malik-Jouda for going over this issue again.
(picking up from my old notes) While this should fix their widths, it should also break their submenus. The following is a clip I took last time I worked on this:
https://github.com/user-attachments/assets/a5d9c7bb-1c40-429b-a4c8-6406f76d4f59

@Malik-Jouda This is up to the user to add this, otherwise this will break borders.

@benjamincanac


Remove card sorting based on visibility

Hired Assassin looks at facedown shadows cards and shadows cards are not allowed to be rearranged.

Closing in favor of #35


Allow docker image to be multiarchitecture

This pull request tells the docker builds to generate both amd64 and arm64 builds.
It also has ffmpeg and the latest fixuid bundled in.

Hold this PR until I finish removing the bento4 install since mp4decrypt was removed way back in 93dda36

Based on discussions on discord. (Around https://discord.com/channels/1093562233612673097/1111026840799285399/1275857259527667765 )
This code may be broken down even more, to switch to building 2 images, one with / one without ffmpeg, and possibly switch from python:3.11 to python:3.11-alpine for further optimizations

The action look good
but it doesn't seem like the github actions I have setup use docker files  to be generate the docker images

The dockerfiles look good but it doesn't seem like the github actions I have setup use docker files to be generate the docker images

I'm actually working on that right now, switching from using the build-push-action GHA to the bake-action GHA, in fact for the moment lemme switch this PR back to draft


feat: added execution timeout

Purpose
Add timeout for the execution of all tests or specific test
Approach

Add test for features
Add execution timeouts
Add the possibility assign the timers via CLI/config file/run

References
https://github.com/DevExpress/testcafe/issues/6096
Pre-Merge TODO

[ ] Write tests for your proposed changes
[ ] Make sure that existing tests do not fail

Rebase please.

Rebase please.


ComboBox - Binding Too Late For selectedItem Display

In this app
<?xml version="1.0" encoding="utf-8"?>
<mx:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
                xmlns:js="library://ns.apache.org/royale/basic">
    <fx:Declarations>
    </fx:Declarations>
    <fx:Script>
        <![CDATA[
            public function compute(value:String):String{
                return value;
            }
        ]]>
    </fx:Script>
    <mx:ComboBox width="250" top="30">
        <mx:dataProvider>
            <fx:Object label="{compute('scp')}" data="scp"/>
            <fx:Object label="{compute('ftp')}" data="ftp"/>
        </mx:dataProvider>
    </mx:ComboBox>
 </mx:Application>

selected item shows as '[object Object]' instead of 'scp'

In Flex the text for the combo is updated in updateDisplayList() which happens to occur after binding updates the data provider. In Royale however we initialize the text after combo box is added to parent, while the binding operation happens after the binding container is added to parent, which in this case happens later.

So at least a simple workaround might be something like:
<fx:Declarations>
        <mx:ArrayCollection id="myDP">
            <fx:Object label="{compute('scp')}" data="scp"/>
            <fx:Object label="{compute('ftp')}" data="ftp"/>
        </mx:ArrayCollection>
</fx:Declarations>

And :
<mx:ComboBox  width="250" top="30" dataProvider="{myDP}"/>
I think that would mean that the earlier bindings should run first, before the dataProvider assignment binding, because iirc they are processed (at startup/addedToParent) in the order of their declaration. I realize that this is not a solution to the actual difference in lifecycle, but something like that might be a simple way to work around the issue on occasion. In reality, because there is no event trigger for the label 'bindings', it might be something that is more suited to a labelFunction in this case (it seems that the label display is the same as the 'data' field value), that is, assuming labelFunction emulation currently works correctly on ComboBox.


Add Hardware Acceleration to FFMPEG Command for Video Processing

Description
To improve the efficiency and reduce the processing time of our video generation pipeline, we should incorporate hardware acceleration into our FFMPEG commands.
Proposed Changes
NVIDIA (NVENC)

Add -hwaccel cuda to enable CUDA hardware acceleration.
Use -c:v h264_nvenc to utilize NVIDIA's hardware-accelerated H264 encoder.
Include -preset fast to balance encoding speed and output quality.

Intel (QSV)

Add -hwaccel qsv to enable Quick Sync Video hardware acceleration.
Use -c:v h264_qsv to utilize Intel's hardware-accelerated H264 encoder.
Include -preset fast for encoding speed and quality balance.

AMD (VCE)

Add -hwaccel vdpau to enable VDPAU hardware acceleration.
Use -c:v h264_amf to utilize AMD's hardware-accelerated H264 encoder.
Include -preset fast for encoding speed and quality balance.

Code Location
The current FFMPEG command is located in the video_pipelinestages.py file. Specifically, it can be found in the following lines:
video_pipelinestages.py#L42-L49
The current command is:
command_video_output = [
    "-filter_complex",
    "[0:v]reverse[r];[0:v][r]concat=n=2:v=1[outv]",
    "-map",
    "[outv]",
    "-movflags",
    "+faststart",
]

Expected Benefits

Reduced video processing time.

Do you have any numbers about the actual speed up?
I considered to implement some kind of hardware acceleration but hesitated since the implementations can produce different quality, could fail if wrong accelerator is chosen and can have different parameter as well as limitations (example regarding max width/height of an video).
Still I think it could be good if performance increases.

Well, for now I don't have actual speed up numbers, maybe tomorrow I might find time to fiddle around with my booth setup and add the nvidia hardware acceleration parameters.
Maybe an "easy" solution to the problem would be to add "expert" ffmpeg parameters, where users can add hardware acceleration parameters on their own, and fiddle therefore with their own setup? And maybe then add Infos in the docs for what system what params to use. With this also quality parameter etc. could be set by the user.
A more advanced solution would incooperate checking (when starting up) what hardware acceleration is present in the system, and then only apply the selected hardware acceleration if the system can handle the selected acceleration.
Regarding width / height I don't realy have any idea either to solve this..

I tried to get hardware acceleration working, but wasn't able to install the h264_qsv codec in Ubuntu.

Do you have any numbers about the actual speed up?

I saw a significant performance uplift, but I'm using a relatively light host for photobooth-app on Windows. It's an Intel M5-6Y57 with only two cores.
With Intel QSV acceleration on the encode a 5 second clip processes in about 7.5 seconds.
Without QSV acceleration it took 14 seconds to process.


Bump CI images to latest scanner-test-0.3.45

Purpose
Onboard UBI9 to all CI images by bumping the base image to the latest.
Tests
Relying on CI

So the FROMs in these images aren't really used anyway

I know. But unfortunately, they are here. So, unless we can replace them with a generic FROM I think it is worth aligning them with the actual scanner-test tag we use to avoid confusion. And I guess you can still build them locally for testing.


feat(loader): create hierarchical tests definitions with a catalog loader

Will be merged to a dedicated development branch (devel-tests) for better cooperative work.


Clarification on diff abundance stats

First off, this is a very elegant framework - thank you guys for making this available
In the functions below
https://github.com/YosefLab/scVI/blob/master/scvi/inference/posterior.py#L172
https://github.com/YosefLab/scVI/blob/master/scvi/inference/posterior.py#L224
It looks like the data is resampled in order to compute these statistics.  Is there any reason why this is done rather than sampling from the posterior distribution of the decoded embedding vectors? It would seem to me that you could investigate gamma_n as shown in generative model in the paper supplemental

Possibly relevant links
https://github.com/YosefLab/scVI/issues/188
https://github.com/YosefLab/scVI/pull/274

Hi,
Yes you're right, in our first scVI paper we take a few cells (randomize over cells) and sample multiple times from the posterior (diff_expression_stats).
That said, if you have enough cells, then you can only sample once from the variational distribution for each cell (diff_expression_score).
Please let me know if you have any other questions, we have some troubles making this part of the code software-friendly :+1:

Closing due to inactivity

Yes, this has been addressed.  Thank you for clarifying.
On Wed, Apr 3, 2019 at 1:33 PM Romain Lopez<EMAIL_ADDRESS>wrote:

Closed #285 https://github.com/YosefLab/scVI/issues/285.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/YosefLab/scVI/issues/285#event-2250593896, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD_a3VzI8uJVkncLt-H9fq3u62oj-Z19ks5vdOXagaJpZM4cCWcs
.


Add preBuild before connector-specific integration tests.

#qz-3637 Done (maybe for reals this time)

Merging this, because it's the right thing to do even though it doesn't appear to be working 100%.


docs: update bundle-manifest's url in Readme

I have updated bundle-manifest's url because it is currently pointing to outdated mirror https://github.com/Polymer/polymer-bundler/.

@usergenic Kindly review this. Its a simple URL change in docs.


bump eslint and eslint plugins

What does this PR do and why?
run yarn https://classic.yarnpkg.com/lang/en/docs/cli/upgrade-interactive/ on all eslint and eslint plugins. All updates a minor version bumps
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2322   👈

This comment was auto-generated by Graphite.


single query to determine metering readiness?

https://github.com/operator-framework/operator-metering/blob/master/Documentation/manual-olm-install.md
These are great docs!  I'd like a feature for automation:
In addition, I'd like to be able to oc get <resource> -o jsonpath --template='{.spec.status.<something>}' -n openshift-metering to be able to test that the whole metering and reporting system is deployed OK.
Anything already in these pods or other resources?

Generally if the reporting-operator pod itself is ready; that's a good indication.
The MeteringConfig resource's status would be a good option in the future once we begin managing it's status more directly.


The usual raise?

I was looking to send a signal to itself. Like kill(0, SIGTSTP) but I came across raise which I think may do the same thing, or does it?
In the docs https://docs.rs/signal-hook/0.3.9/signal_hook/low_level/fn.raise.html

The usual raise, just the safe wrapper around it.

What does "the usual raise" means? Is it kill?

I tried using it instead of kill(0, SIGTSTP) and it seemed to work. I think the docs around this needs some update, maybe it can say it sends the kill signal to itself?

Raise is a standard posix function, see https://linux.die.net/man/3/raise (you can check the internal implementation too ‒ docs.rs has these very hand [src] buttons). That's what I mean by „usual“. You're welcome to propose a more specific wording, as usual is a bit informal/vague.
I'd like to point out that this is not equivalent to kill(0, ...), which says „If pid equals 0, then sig is sent to every process in the process group of the calling process.“, while raise targets only the calling process/thread. Furthermore, raise is synchronous and waits for the signal handler to terminate before returning, while kill only „posts“ the signal and doesn't wait. These are subtle differences, but the whole posix is mostly built around subtleties, therefore the similarity is only the first approximation.


Dockerfile build fails on livy-server step

Hi,
I try host locally this solution for apache spark on its language flavors with command run docker build -t livy-ci dev/docker/livy-dev-base/. After some installation steps, the error log appers on terminal. I attempt on Linux Ubuntu 20.04.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Livy Project Parent POM ............................ SUCCESS [01:26 min]
[INFO] livy-api ........................................... SUCCESS [03:30 min]
[INFO] livy-client-common ................................. SUCCESS [  4.819 s]
[INFO] livy-test-lib ...................................... SUCCESS [  2.996 s]
[INFO] multi-scala-project-root ........................... SUCCESS [  1.042 s]
[INFO] livy-core-parent ................................... SUCCESS [  0.177 s]
[INFO] livy-core_2.11 ..................................... SUCCESS [  9.340 s]
[INFO] livy-rsc ........................................... SUCCESS [ 50.358 s]
[INFO] livy-repl-parent ................................... SUCCESS [ 25.652 s]
[INFO] livy-repl_2.11 ..................................... SUCCESS [04:05 min]
[INFO] livy-server ........................................ FAILURE [ 48.405 s]
[INFO] livy-assembly ...................................... SKIPPED
[INFO] livy-client-http ................................... SKIPPED
[INFO] livy-scala-api-parent .............................. SKIPPED
[INFO] livy-scala-api_2.11 ................................ SKIPPED
[INFO] livy-integration-test .............................. SKIPPED
[INFO] livy-coverage-report ............................... SKIPPED
[INFO] livy-examples ...................................... SKIPPED
[INFO] livy-python-api .................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:26 min
[INFO] Finished at: 2023-06-22T21:17:57+00:00
[INFO] Final Memory: 108M/1364M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project livy-server: Could not resolve dependencies for project org.apache.livy:livy-server:jar:0.8.0-incubating-SNAPSHOT: Failed to collect dependencies at io.dropwizard.metrics:metrics-healthchecks:jar:3.1.0: Failed to read artifact descriptor for io.dropwizard.metrics:metrics-healthchecks:jar:3.1.0: Could not transfer artifact io.dropwizard.metrics:metrics-healthchecks:pom:3.1.0 from/to central (https://repo1.maven.org/maven2): Connection reset -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :livy-server

I'm running into the same issue. These are 2 failing tests:
BatchSessionSpec:
A Batch process
- should create a process *** FAILED *** (1 second, 30 milliseconds)
  false was not true (BatchSessionSpec.scala:94)

BatchServletSpec:
Batch Servlet
- should create and tear down a batch *** FAILED *** (1 second, 118 milliseconds)
  false was not true (BatchServletSpec.scala:121)

@brunolnetto I found the issue.
The tests include Python2 code that doesn't work in Python3.
i.e: print "hello world" instead of print("hello world")
The fix is to write the lines for Python3:
https://github.com/apache/incubator-livy/blob/master/server/src/test/scala/org/apache/livy/server/batch/BatchSessionSpec.scala#L51
https://github.com/apache/incubator-livy/blob/master/server/src/test/scala/org/apache/livy/server/batch/BatchServletSpec.scala#L46

Noice! Someone whould notify Apache, Python 2 is being deprecated


Bounds and units table

Incorporate PR and FMS and SP edits

I fixed last Wind direction variable, it is Standard deviation of wind direction in degrees.


[InNomine] Can we get an english version please?

im dying to run in nomine to my friends so, i wanted to know if theres any chances for an english sheet in roll20

The sheet has been updated. The default is in English, but there is full translation support for other languages as well.
This issue can be closed now.


Wrong proportions on icon in "About" window

As you can see, it's stretched:

Left the original icon in the directory figuring it might be useful in the future

@minachuong What exactly do you mean? How did you do this? cc @evilrabbit

@leo I added a file in the static directory that was a png that had square dimensions of 96x96. The original icon was 87x76. Looks like whatever is handling the icon in the dialog box stretches the image if the image does not have square dimensions


Remove deprecated sync -[FIRInstanceID appInstanceID:] method

The method must be removed and [FIRInstanceID appInstanceID:] , all usages must be replaced the the async alternative.

If other SDKs like analytic stop using this, we should remove it. Thanks for filing this!

All Firebase SDKs (except FCM so far) have been updated to use FIS directly, but the method may still be used in some 1P tests.

I think it's okay to remove it. I couldn't find any 1P depending on it anymore.

We need to wait for Firebase 7 - because earlier Firebase 6 versions of other pods allow minor version updates of IID. If an old version of Firebase Analytics updates and this API is removed, the build will break.


GEOMESA-2903 Log HBase zookeeper connection

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

from what I can tell, there's no good way to see what resources are loaded through a configuration object. the resources that it contains may or may not point to actual files, it only determines that when it tries to parse them. they are also relative names (i.e. hbase-site.xml), the full path is only known internally when they are parsed. so the only other sane option i see is to print out the entire conf, but that seems very verbose.

kerberos info is already logged


Core design and refactoring

Should we depend on the bloc and flutter_bloc packages so heavily?
If we decide not to we could separate the form handling core from the flutter stuff.
Tests are on hold until refactor.

WIP in dev branch. Also touches a lot for https://github.com/vantageoy/formini/issues/1

Experimenting with class form states instead of using Maps.

https://github.com/vantageoy/formini/blob/a0195cc8fcdf0cdd79423c8545309b59cfa43112/test/example/user_form.dart
https://github.com/vantageoy/formini/blob/a0195cc8fcdf0cdd79423c8545309b59cfa43112/test/example/user_form_state.dart


Class Not Registered

Hello,
Fairly new to this but set up Selenium, put chrome driver in Selenium folder, Opened excel and added the Selenium type reference and tried to run the following test code noted below. All i get is a run time error "class not registered"
I have tried many other simple test codes and get the same result.
Anyone have any ideas?
Sub Test()
Dim bot         As New WebDriver
bot.Start "chrome", "https://www.google.com"
bot.Get "/"
Stop

End Sub

这是来自QQ邮箱的假期自动回复邮件。
已经收到，等我看到了，立马回复。

Ran excel as admin and now working


Removed "?" after hoisted in role info embed

Also I would recommend removing the hoisted and mentionable ones and maybe inline some of them?

Resolved.


How to create and build an ESP-IDF static library?

I'm learning ESP-IDF platform and now want to create a library in order to be able to structure my code properly in the future.
I've done some research and found few things, for instance a library that could be as an example. The only issue with it being too large, I can't clearly see what's the bare minimum for the simplest library code.
What is the minimum configuration for an ESP-IDF static library that can be built into a .a file?

For structure & modularity, IDF has the concept of "components". Each component is built into a static library as part of the build process.
The smallest possible component would contain one source file only, as well as a component.mk file to define the component and describe the location of that source file.
You can find documentation about the build system and creating components here:
https://esp-idf.readthedocs.io/en/latest/api-guides/build-system.html
I'm going to close this as it's not an issue with ESP-IDF itself. For questions like this, feel free to start a discussion thread over at the https://esp32.com/ forums.


difference between producer and presenter

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1673

@tonysmit Hi Tony, changes look correct. Could you please check and merge? Thanks!

@LanaChin - could you review these changes and (if correct) please merge this PR.

Awaiting review by PM.

@LanaChin Hi Lana, any updates on this? Thanks!

@LanaChin could you ping PM again please?

@SerdarSoysal @LanaChin Hi any updates on this? Thanks!

@scanum I met with the PM and updated the article to add a link to an existing article that describes each of the roles.  Thanks.


Set up automated tests

Get the normal hack/ scripts in place and set them up in prow

I think this is a very clean implementation of what I'm talking about: https://github.com/kubernetes-sigs/cluster-api-provider-docker/tree/master/hack

/assign
/priority important-soon
/kind feature
/lifecycle active

As part of this work, can we use go modules given that this targets v1alpha2?

yes, certainly.
the CI will need to manage a go deps test, so i'm going to add some placeholders as a start.

/remove-lifecycle active.
will leave open if something else is needed.

/remove-lifecycle active

/close
thanks for fixing this! it's all working


Update ecto.ex

Minor copyediting for readability.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Advertise device through mDNS and DNS-SD

Finally there is no need to: the device already advertise itself through the MQTT. So this would be a complete waste of resources.

Actually, I would put this one on hold.. devices are advertised on the MQTT but i'm not sure that they will be discovered as such. finding this via wifi would make it more effective.. MQTT is more of a transport method.. understand what i mean ? ;)

Memory is precious, this is a waste of resources. Let me explain: if we make devices discoverable via mDNS, you can detect there is a device connected to the network and it's IP. Great. Then what? If you want to get other information about the device, or interact with it, you need to do it via MQTT anyway.
So simply, just subscribe to devices/+/$online, check if it equals to true and if yes, apply the regex ^devices\/([a-z0-9-]+)\/\$online$ to the topic, so you have the device ID in $1 and you've just discovered all Homie devices. :smile:

I agree on that point.. (did not know about the + un a MQTT subscribe string).
I was looking into binding making on openhab2 and looks like you need predefined "things" switch, sensors, relay etc.. So i'm so sure this would be a good thing for your framework as you "thing" can virtually be anything a use defines.
Bottom line, this stays closed :)

Wow! Should put this trick in the readme file!

Good point! But where? In the Homie convention, or in the docs of this repo?


Fixed the shapes calculation part

Related Issue

Info about Issue or bug

fix #1294
Describe the changes you've made
All the shapes are working now.
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

@madihamallick its against the rules of open source that a PR is created before assignment
And also I had created the issue before so I think you should close the issue

@madihamallick have you added any code as it shows you have added and deleted some blank lines .

@madihamallick have you added any code as it shows you have added and deleted some blank lines .

Hi @Ankita297  how does that even bother you. And why do I even explain you what changes I made. And yes, to resolve any bug you don't always have to "add codes".  They maybe some missing brackets or semicolons.
Just know that the issue you created #1357 will be resolved when this PR gets merged. I have provided screenshot too, for your reassurance :)

@madihamallick  I am sorry . I don't mean to be offensive . But i was just curious so i asked .
Sorry again .

@madihamallick I am sorry . I don't mean to be offensive . But i was just curious so i asked .
Sorry again .

It's totally fine. Not your fault :)


fix(err-msg): #7 - Missing app name message modified.

Bug: #7
The error message for the missing app name has been modified like below,
Please specify the app name:
react-chef <app-name>

For example:
npx react-chef my-app-name

Error: App name is missing.

Invalid PR


Add GA testing for the Accordion

What
Add tests for GA (Google Analytics) "Show all sections" and each individual section tracking for the Accordion.
Why
As part of this PR click-event-tracking has been added the Accordion so when a user interacts with "Show all sections" or an individual section this can be sent to GA. These are behind feature flags.
However testing needs to be added, the Accordion testing moves away from testing a copy of the HTML and tests against the actual rendered component making the test more accurate. However for the context of this PR partially restoring the Jasmine test GA is required
Ideally we need to

[ ] Restore Jasmine (accordion-spec.js) file
[ ] Extend the tests to ensure that tracking works as expected.

(An alternative approach would be add GA to the dummy_app and testing against that).
http://govuk-publishing-components.dev.gov.uk/accordionexample
Conversation happening here
Anything else
Draft WiP PR is here

Closing as the Accordion component has tracking (for both showing all sections and tracking each individual section), accompanied by an spec.js file. Additionally, the problem seems to be related to Universal Tracking, which is now deprecated.


simplify shutdown signal handling to avoid concurrency issues

removed the usage of Stud.interval to avoid using a shared @thread ivar across threads which has some concurrency issues and sometimes makes logstash shutdown fail with
[2018-09-12T11:09:25,296][ERROR][logstash.agent           ] Failed to execute action {:action=>LogStash::PipelineAction::Stop/pipeline_id:main, :exception=>"NoMethodError", :message=>"undefined method `[]=' for nil:NilClass", :backtrace=>["/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/stud-0.0.23/lib/stud/interval.rb:43:in `stop!'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-input-heartbeat-3.0.6/lib/logstash/inputs/heartbeat.rb:72:in `stop'",

One potential fix could have been to simply have the @thread ivar initialized early at the object construction but I prefer this design which is simpler to reason about in terms of concurrency and does not rely on the Stud thread locals signalling etc.
I also cleaned a little the sources, removing superfluous comments and public statements.

Thanks @yaauie - will bump version and publish.


Wireshark issues

There are a couple of issues with using wireshark-gtk with sway. Both could be related but not too sure.
Add the following to your config. Then open wireshark and then the open dialog
gaps edge_gaps off
gaps 50
new_window pixel 10

The next issue is that if you have wireshark floating and then open the open dialog. Notice how it is nowhere to be found.
In both cases wlc_view_get_type returns 0 which is strange since in i3 the open dialog is floating in both cases

Same with libreoffice
Linux Arch
Sway 0.5-2
wlc 0.0.2-1

Ping @Cloudef

I've found this problem happens with all GTK dialogs.

This could be that the window type property is assigned to the window after being mapped. Fortunately we now have view_properties_updated for updating window titles and such, and we can just use that to also inform about type updates.

This could be that the window type property is assigned to the window after being mapped.

That would suuuuuuck.

That's just hypothesis. Fortunately I have wireshark here handy, so I cansee what happens.

Ah, I realized wireshark is wayland native too. So wlc_view_get_type() returning 0 is normal in this case. I guess orbment handles this fine because it centers child windows on parent. (wlc_view_get_parent, which the dialogue is, it's not special in any other way inside wayland)

Ah, I didn't realize wlc_view_get_parent is a thing. We should probably default views with a parent to floating.

Duplicate of #604.


Pods of the InferenceService are not created when using GCS  ServiceAccount credentials

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
I created an InferenceService that uses GCS, but a pod is not created.
gcloud iam service-accounts keys create gcp-sa-credentials.json \
  --iam-account<EMAIL_ADDRESS>

kubectl -n [NAMESPACE] create secret generic user-gcp-sa \
  --from-file=gcloud-application-credentials.json=gcp-sa-credentials.json

ServiceAccount
apiVersion: v1
kind: ServiceAccount
metadata:
  name: gcs-sa
secrets:
- name: user-gcp-sa

inference-service.yaml
apiVersion: "serving.kubeflow.org/v1alpha2"
kind: "InferenceService"
metadata:
  name: "mnist-gcs"
spec:
  default:
    predictor:
      serviceAccountName: gcs-sa
      tensorflow:
        storageUri: "gs://my-bucket/mnist/model"

Revision -> Deployment -> Replicaset (O)-> Pod(X)
Replicaset error
status:
  conditions:
  - lastTransitionTime: "2020-04-05T06:14:27Z"
    message: 'Pod "mnist-gcs-predictor-default-dgsss-deployment-7dd6d67df4-mtfkr"
      is invalid: spec.volumes[4].name: Duplicate value: "user-gcp-sa"'
    reason: FailedCreate
    status: "True"
    type: ReplicaFailure
  observedGeneration: 1
  replicas: 0

The user-gcp-sa volume is defined in the deployment's pod spec, but it seems to be a problem that occurs when the user-gcp-sa volume is duplicated by the pod mutator when the pod is created.
What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version:
Knative Version:
KFServing Version: 0.2.2
Kubeflow version: 1.0.1
Minikube version:
Kubernetes version: (use kubectl version): 1.15.1
OS (e.g. from /etc/os-release):

@kangwoo I think this code gets called both in pod mutator for storage initializer init container and main container, so volume got duplicated in the array. Would you be interested in making a contribution and fix this ?
https://github.com/kubeflow/kfserving/blob/master/pkg/controller/inferenceservice/resources/credentials/service_account_credentials.go#L104

@yuzisun yes I'll try it.


canbus：add neolix battery signal

lint happens some problem:
modules/canbus/vehicle/neolix_edu/protocol/vcu_powerstatus_214.cc:108:  Missing space before {  [whitespace/braces] [5]
modules/canbus/vehicle/neolix_edu/protocol/vcu_powerstatus_214.cc:117:  Missing space before {  [whitespace/braces] [5]
modules/canbus/vehicle/neolix_edu/protocol/vcu_powerstatus_214.cc:128:  Missing space before {  [whitespace/braces] [5]
modules/canbus/vehicle/neolix_edu/protocol/vcu_powerstatus_214.h:62:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
more deteil info:http://<IP_ADDRESS>:8111/viewLog.html?buildId=13788&buildTypeId=Apollo_Build&tab=buildLog&_focus=138#_state=138


Allow twig filters in subject

Hello,
Would it be possible to allow twig filters in mail subject.
An example of use case ? Actually, when you do {{ record.date }}, the date in sent in english format : Y/m/d
For french people like me, the date needs to be in the following format : d/m/Y
Allowing twig filters would resolve this problem (and probably more) as I could do {{ record.date|date('d/m/Y') }}
Best regards,
Alex

Side note: Y/m/d is the INTERNATIONAL format... m/d/Y is the english one.

Good catch ! ;)

Hey @PubliAlex
I've spent some time looking at this and loading twig on the backend doesn't look easy.
I hate to add settings for specific issues like this, but i can't think in a better alternative.

Sorry for the late reply, just got a child.. 👶, your solution seems to be perfect.

congratulations @PubliAlex!
this feature was added on v1.4.20


{{component}} can't be invoked directly

This commit of my reproduction repo.
I think the component component isn't type-checked correctly at all. Pretty much all my invocations are marked as an error. As you can see in this example:
app/components/test-component.hbs:3:1 - error TS2345: Argument of type 'new () => Invokable<(args: Omit<{ index: number; }, "index"> & Partial<Pick<{ index: number; }, "index">>) => AcceptsBlocks<EmptyObject>>' is not assignable to parameter of type 'string | number | boolean | void | AcceptsBlocks<{}> | null'.
  Type 'new () => Invokable<(args: Omit<{ index: number; }, "index"> & Partial<Pick<{ index: number; }, "index">>) => AcceptsBlocks<EmptyObject>>' is not assignable to type 'AcceptsBlocks<{}>'.
    Type 'new () => Invokable<(args: Omit<{ index: number; }, "index"> & Partial<Pick<{ index: number; }, "index">>) => AcceptsBlocks<EmptyObject>>' provides no match for the signature '(blocks: {}): { [Blocks]: true; }'.

3 {{component "glimmer-component" index=1}}
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I guess that would be difficult to fix so that's one of the reasons I requested some ignore syntax.

The {{component}} keyword is hard to type robustly, but we've got it most of the way there. You've definitely found a pretty key bug, though 😄
As a workaround in the meantime, this should typecheck as expected:
{{#let (component "glimmer-component" index=1) as |GlimmerComponent|}}
  <GlimmerComponent />
{{/let}}

I've spent a little bit of time with this, and unfortunately we might end up having to stick it in the wontfix bucket. Similar to ObjectProxy, it's something we could make work but at the expense of complicating the types (and therefore slowing down the checking) for every component/helper invocation.
Also similar to ObjectProxy, the framework is moving in a direction where this pattern should be needed less and less. With the changes that landed in Ember 3.25, places where you would have done something like this before:
class MyComponent ... {
  get whichThingToRender(): 'foo' | 'bar' {
    // ...
  }
}

{{#component this.whichThingToRender}}
  {{! ... }}
{{/component}}

Can now become this:
import Foo from '...';
import Bar from '...';

class MyComponent ... {
  get whichThingToRender(): typeof Foo | typeof Bar {
    // ...
  }
}

<this.whichThingToRender>
  {{! ... }}
</this.whichThingToRender>

Between the complexity and perf implications of making this work, the Ember 3.25 changes, and the {{#let}} workaround, I think this is unlikely to get fixed in the near term.
I'm happy to keep this open for now, though, and if you've got other places you're direct-invoking dynamic components that you don't think the 3.25 changes will cover, we'll see what we can come up with 🙂

Thanks for taking the time to look into this.

if you've got other places you're direct-invoking dynamic components that you don't think the 3.25 changes will cover

Well, my use-case is very specific and very dynamic (I compile templates on the backend and send them to the frontend where I register them as template-only components and then invoke them dynamically - and I don't know in advance how many templates there are, how they look like or anything at all) so the changes in 3.25 don't help me in any way, but this is a problem of mine and I've discussed this with pzuraq and he's been telling me that things will change and I have to adapt. So if you say that's a wontfix, I agree with you (and with your reasoning). :) No need to keep the issue open I guess.
Thanks again for the time! :)


package.json authors keyword parsing

What would you like to be added:
In the current parse_package_json.go, the expected structure to parse includes just the keyword author: https://github.com/anchore/syft/blob/main/syft/pkg/cataloger/javascript/parse_package_json.go#L24 . However, there are plenty of packages that use authors to register multiple authors.
Formats seen:
"authors": {
	   "Harry Potter<EMAIL_ADDRESS>(http://youknowwho.com/) ",
	  "John Smith<EMAIL_ADDRESS>(http://awebsite.com/) "
}

Or
"authors": {
	  "Harry Potter",
	  "John Smith"
}

An example package could be: https://github.com/Qix-/color/blob/master/package.json#L11
Why is this needed:
For more accuracy on parsing package.json structures.

Hey @NataliaAn, thank you for the report. We'll put this in the backlog for a fix when we are able. If you're interested in making the changes to support multiple authors, let us know and we can point you in the right direction. Thanks again!

@NataliaAn Shouldn't it be contributors? That's at least what official docs on package.json specifies should be used when there are multiple people that need to be included: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#people-fields-author-contributors
However, contributors field is also currently not being parsed, so it would be nice to have, but technically speaking authors is not an officially supported field, it seems.
There is also

top-level "maintainers" field

but this one is not being kept in package.json, I believe.

@tgerla I'm willing to contribute to this, but I would like some feedback from someone from Anchore team, if it's worth the effort and what would be the best approach.
My concerns:

Should we only support parsing contributors declared in npm docs? Or should we also support authors and/or maintainers? Some packages may use even other fields for that, but those seem to be most common
If we would like to parse all of the above, should they be parsed separately to the fields with the same name or maybe to the same contributors field in the output metadata? Then the question would be if e.g. both maintainers and contributors fields are present, should one have priority over the other for parsing? Or they could be concatenated?
If author is missing, but e.g. contributors is present, should it be used for author field in cyclonedx format?
Any other cases I haven't thought about?

@jabkoo I guess as long as there are packages that use them, it would be nice to parse all cases that are valid even if they don't follow the latest official recommendation...?

Hey @jabkoo, sorry for the delay responding. I chatted with the team and we think that the best approach would be:

Don't overload or combine the different fields: treat contributors, maintainers, and authors as separate fields.
The JSON data shape will need to be modified to support these new fields.
If author is present, put the contents in the authors JSON field.
If any of the fields are objects, stringify them.

There will probably be two pull requests involved here:

Add contributors, maintainers, and authors to the JSON data shape
A separate PR to handle the transformations into CycloneDX and other formats

Let me know what you think--happy to provide more feedback whenever you need. Thank you for taking this on!