Show visible tooltip after animation cancel

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/19693
PROPOSAL: https://github.com/Expensify/App/issues/19693#issuecomment-1584356934
Tests

Hover over any text msg in a chat to show the mini context menu
Hover over the "copy to clipboard" icon
Now before the tooltip shows and also before the tooltip animation starts, click on the copy icon
Verify the copy icon changes to a tick mark and the tooltip shows instantly with the "Copied" text.
Perform the same steps with a msg having a valid link, use the "Copy link" option/icon, and verify the success tooltip shows

Any other tooltip that has a similar behavior (using default and success tooltip text) would behave the same.

[ ] Verify that no errors appear in the JS console

Offline tests

Same as the "Tests" section above
QA Steps

Same as the "Tests" section above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Chrome
https://github.com/Expensify/App/assets/68777211/07e86ab9-e028-426c-9ce3-78d47c96d8ec
Safari
https://github.com/Expensify/App/assets/68777211/bf85430b-91e8-4498-9f60-439a272aae34

Mobile Web - Chrome
https://github.com/Expensify/App/assets/68777211/43367fd0-c906-4127-a944-1172c198e3fb

Mobile Web - Safari
https://github.com/Expensify/App/assets/68777211/a8c604d4-51e8-4490-9c54-d6ac94d751c8

Desktop
https://github.com/Expensify/App/assets/68777211/040cc08a-6445-4faf-9295-8d32dd37fa46

iOS
https://github.com/Expensify/App/assets/68777211/05724606-9d13-4e84-8851-2b81e47f6dad

Android
https://github.com/Expensify/App/assets/68777211/dce7c09f-b24d-4aee-9d19-fca3d47a905d

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Change sorting for assemble-authors.

Seems like this sorting is generally preferable and OK by default, as we need to see roles of people quickly. Decided against sorting by role as that is a bit messy.

👍 lgtm


Missing configuration "connection_time"

Hey
I'm currently using a modbus-proxy on another system in a docker container.
Unfortunately, this connection is not 100% stable, which is why I want to test your implementation.
Unfortunately, I don't have the option to set "connection_time".
The default seems to be "connection_time: 0.1". But I need "connection_time: 2".
Background:
I connect the modbus-proxy to my SUN2000 and it needs the mentioned option.
Can you tell me where I can adjust it manually?
If possible, please also provide this setting via the GUI.
Many Thanks :-)
Greeting
Tower

i'm also looking for that setup
i tied to setup in yaml but won't work

Hi,
Thanks for your effort in making this integration.
I have the Huawei Sun2000 inverter as well here at home and would like this integration to provide modbus connections to both my HA system as well as another system.
For the moment I can't get the home-assistant to connect to the modbus-proxy.
Does it need the connection_time setting ?
Would you be able to tell me if you were able to work on it ?
Thanks in advance

@thomasnas i think you have another issue, please open another ticket in here to keep things seperate :)
@scrichab i am currently testing a new version including timeout and connection_time config as well as some changed logging, will be hit the repo soon

With this new option, I was able to easily connect and use my Huawei SUN2000.
Thank you for the integration :-)


Better main thread detection during Instruments data import.

For a complex, heavily multi-threaded app, the logic that assumes that the thread with the most samples is the main thread can be mislead.
Sadly, I don't have a concrete suggestion for something better. I notice that main appears to usually be thread id '4', but there has to be something less hacky.
Just wanted to open this issues to start a discussion about this.

@rudro Would this still be important to solve if speedscope supported importing profiles w/ multiple threads & processes? (See #82)

@rudro When you drop an instruments trace onto https://www.speedscope.app/, it should now import all threads in all runs. If you get a chance to give it a try, please let me know how it works for you!

Tried this out, works great! Thanks.

@rudro Hey I'm writing a blogpost for the release of speedscope 1.0. Any chance you'd be able to share some information about what you've been using this for? It sounds like you've been using this predominately through Instruements. Is it for iOS profiling? Is speedscope being used at Uber?


update instance.Status.KeyInstanceID

Signed-off-by: qibobo<EMAIL_ADDRESS>

Re-ran on a same-repo branch and integration tests are passing 👍 https://travis-ci.com/github/IBM/cloud-operators/jobs/476651114
Thanks @qibobo!

Re-ran on a same-repo branch and integration tests are passing 👍 https://travis-ci.com/github/IBM/cloud-operators/jobs/476651114
Thanks @qibobo!


Cannot read properties of undefined

when enabling the plugin got popup with following error
:plugin.logseq-tweet-extractor/ParseTwitter Cannot read properties of undefined (reading 'forEach')
ubuntu 22.10
logseq 0.8.9

Can you share the tweet you are trying to embed? Does it work with other tweets?
On 20 Oct 2022 at 6:42 AM +0400, rachmadani haryono @.***>, wrote:

when enabling the plugin got popup with following error
:plugin.logseq-tweet-extractor/ParseTwitter Cannot read properties of undefined (reading 'forEach')
ubuntu 22.10
logseq 0.8.9
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

it happen when enabling the plugin, but i will try parse a tweet and report back if there is another error

Yep in that case try restart the app.
On 20 Oct 2022 at 7:18 AM +0400, rachmadani haryono @.***>, wrote:

it happen when enabling the plugin, but i will try parse a tweet and report back if there is another error
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

restarting the app with plugin enabled still have the same popup error
running it from cli show no error
> Logseq.AppImage
11:34:04.585 › Logseq App(0.8.9) Starting...
mesa: for the --amdgpu-atomic-optimizations option: may only occur zero or one times!
11:34:09.086 › :electron.handler/watch-dir {:path "/home/r3r/.logseq/config"}
11:34:09.199 › :electron.handler/unwatch-dir {:path "/mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/private/logseq"}
11:34:09.200 › :electron.handler/watch-dir {:path "/mnt/ac54dceb-73a5-4f94-b52c-cb7a426c0f29/Documents/private/logseq"}

I had the same issue when I started logseq using Windows 10 and Logseq 0.8.16. Deinstalling and re-installing the app fixed it for now.


webgui, top menu scroll bar for many items, and absolute position for smaller screens to keep menu usable

webgui, top menu scroll bar for many items, and absolute position for smaller screens to keep menu usable

[x] Redmine Issue: https://redmine.pfsense.org/issues/8419
[x] Ready for review

I don't have an iPhone.. but on Android with a Chrome browser and fixed top menu as it used to be that menu cannot be used as it doesn't show half of the menu options.... So that the menu is not fixed anymore is better in that case, i have intentionally broken that 'fix top menu' for such smaller screens..
The scrollbar should work for screens wider than 990px at least on a regular W10 computer.
So imho its still a improvement.?

The intention was that the user select "Scroll with screen" on small screens, "Fixed" on large screens. There are always more ways of addressing a problem though.
While this PR may, or may not be an improvement, I don't think we should render an existing control ineffective in this way. If this mode of operation is desired (and I'm not sure it is) then at least the Setup->General->web UI control needs to be changed to reflect the new operation.
I wonder if a better solution would be to have the control automatically force "scroll with screen" mode on small screens?
The scroll bar you added does not seem to work on iOS devices.

Okay, i can remove the "@media (max-width: 991px) {" part as that changes settings 'undesirably'. (I do wonder how you intend to use the menu though if you cant reach some of the buttons.. Or change the setting each time when sitting behind a different device?)
Would the part for "@media (min-width:991px){" part either improve or leave behavior the same for the other devices? Not sure if youve seen the expected effect.?: https://snag.gy/AuYMxm.jpg  also make sure to hard-refresh the browser cache..

I have seen that effect, but it does not appear to work on iOS devices. Of course I have been careful to clear the cache and/or use a private browser window in each case.

Ok, so no 'improvement' there.. is it the same or worse as before.?
i.e. Would the >990 part be 'merge-able' ? If so i can change the commit for that. Or should i make a 3rd choice for the user to pick this specific new behavior.?

I have just spoken to some others (with more web UI experience than me) and the consensus seems to be that if we want to retain the two menu display options, the best approach is to change the control so that it becomes a "Fixed top menu on large screens" checkbox. If the user is on a tablet or phone, it should automatically switch to "scrolls with page".
On the other hand, it was suggested that perhaps the "fixed" option is of no real use and we should just do away with it.

Closing this PR for now. Wile it offers an improvement in some areas, in others it adds confusion. We may also ditch the "fixed to top of page" option before long.


cprng-aes fails to build with crypto-api 0.8

Resolving dependencies...
Configuring cprng-aes-0.2.1...
Preprocessing library cprng-aes-0.2.1...
Building cprng-aes-0.2.1...

Crypto/Random/AESCtr.hs:27:8:
    Could not find module `System.Crypto.Random':
      It is a member of the hidden package `crypto-api-0.7'.
      Perhaps you need to add `crypto-api' to the build-depends in your .cabal file.
      Use -v to see a list of the files searched for.
cabal: Error: some packages failed to install:

It seems that they removed System.Crypto.Random in crypto-api-0.8
Forcing to build with crypto-api-0.7 I get
[1 of 1] Compiling Crypto.Random.AESCtr ( Crypto/Random/AESCtr.hs, dist/build/Crypto/Random/AESCtr.o )

Crypto/Random/AESCtr.hs:27:1:
    Warning: Module `System.Crypto.Random' is deprecated:
               Use the 'entropy' package module System.Entropy instead

Thanks ! i've upgraded to newer crypto-api+entropy and released cprng-aes 0.2.2

Awesome! thanks for the quick fix


Exporting to HTML

Are there any tools that I can try to export my markdwon notes to html ? mdzk seems like usable  but it is still in development phase. What tools do you guys use ? I'm looking for something that can create an html static site based on the current telekasten folder, with all the interlinks. Also support for some advanced markdown tools like mermaid etc.

In the past I used neuron for that. This is now discontinued because the dev has made emanote, which looks even better and more powerful. It has extended markdown support, custom css, etc.
I do not use such tools at the moment (I live in my terminal as much as I can) but if I were this is definitely the one I would use. I think most of telekasten possibilities would interface quite well with emanote. The only possible friction point I can think of is of (but maybe it is not even a problem) would be the support of relative links when working with sub-directories. This is something you should test.

There is also the markdown preview plugin for (n)vim

Emanote works for me !!!!
Thanks


Allow complete no-console rule

After reading the documentation for the no-console rule, I was surprised to see that I have to list all console methods manually.
It would be good to be able to specify the following to lint against all console methods:
"rules": {
  "no-console": [ true, "log" ]
}

Thanks @nchen63

What is the syntax for banning only certain methods now?

@SgtPooki same as before. #2610 was a backwards-compatible change.

@adidahiya you're correct. I was editing my no-console in the jsRules section on accident and not seeing the rule working like I was expecting. Thanks for the quick response.
        "no-console": [
            true,
            "dir",
            "dirxml",
            "log"
        ],

works for me.


(entity detail) the entity information in card should match the ui in app

The display of the information in the entity detail card does not match what is displayed in the app. These two should be identical.
component

app

Pull Requests:

https://github.com/Senzing/sdk-components-ng/pull/30


Feature to assign already registered vehicles to existing business

Describe the feature
Currently, there is only a possibility to create a new vehicle in the business dashboard. If the car already exists, in the client it is not possible to assign a vehicle to a business.
Ideally:

have an API endpoint to add a vehicle to a business (maybe this can be accomplished by updating existing vehicle? PUT /v1/vehicles/)
have a way to assign a business to a vehicle (I highly recommend having it in the same way as transferring the vehicle to different citizen - through special modal - rather than using Edit Vehicle modal

Additional Context
No response

have a way to assign a business to a vehicle (I highly recommend having it in the same way as transferring the vehicle to different citizen - through special modal - rather than using Edit Vehicle modal

It will use the same modal, however, will allow you to select to transfer to a business or a citizen.
Can it only be transferred to owned businesses or all businesses? @bartusek27

Good question - I would leave it to all since you have it the same for citizens - our own script also needs confirmation from the receiving party (so for example if some citizen would commit a crime with that vehicle, they could transfer that car to a different citizen or business to falsely implicate them).


add public access prevention feature

Need to wait until configconnector >= 1.71 is installed in clusters for spec.publicAccessPrevention in StorageBucket resource.

Co-authored-by: Kyrre Havik<EMAIL_ADDRESS>

Superseded by #90


What was traumatic? It looks like you ended up with something pretty reasonable. What parts did you find difficult?
Don't store the cleartext password in the source, especially if you're going to put the source on Github. Only ever store the hash, and store it in a separate credential file that you do not commit. (For all implementations, not just haskell_scotty, but I haven't looked at the others.)

Hey Bart, the hard part was the part of it that was in Haskell. ;)
Seriously, though, making any headway still feels a bit like pulling teeth. I think I understand maybe 85% of what I'm doing, which is actually pretty good, I think. But the remaining 15% is very perplexing. I think I'm mostly suffering from the inability to effectively debug compiler errors, and even the ones that I understand!
For example, I may encounter some type mismatch error, but (because Haskell, to my understanding) I cant just shove a debugger statement in there to poke around and try to figure out the correct conversion. Even amateur puts-style debugging doesn't appear to be an option, if I'm not in a monad. I've had some success by decomposing the offending function into tiny tiny functions with explicit type signatures, and then I can narrow down the issue get a little more focused, but not much. And to even get to that point, it requires refactoring code that is not green, which is usually a reckless idea. After some thought, I now suspect that this is a use-case for happy-path unit tests in Haskell, but I haven't tried that yet. WDYT?
I also still struggle with basic goals like how to convert one known value to another known value. For example, the JWT library eventually returns your payload as an Aeson Text-Value key-value pair. I've worked with Aeson enough now to feel pretty comfortable with it. However, just getting the Int out of the Value took me almost an hour of fruitless stabbing in the dark, ineffectual reading of the Aeson documentation and source (yikes), and ultimately cargo-culting something from the interwebs after all previous efforts failed. And even I knew it was an Int in there because I put it there myself! I feel like it really shouldn't be that hard. I'm not sure if Aeson documentation is insufficient, or my knowledge of Haskell. Probably both, but more of the latter.
 I'm going to stick with it through this project, at least, so maybe I'll be feeling a bit better about it near the end.

Agreed on removing the secret from source. I'll probably just expose it as a ENV variable.

I'm learning a lot about what is hard in Haskell.
A lot of it is that the Aeson documentation is not too good, honestly. The other hard part of it is that you really jumped in at the deep end with this project: normally we don't start with something that requires IO and DB access and weird libraries.
The biggest thing, though, is that you have an attitude of grinding through without help that will serve you well in some languages, but not Haskell. When you get bogged in something like this, bug me: I'll get online with you or come over and we can work through it together. Or just get on the Haskell IRC channel or something. This is a language where you are learning not just new syntax, but new ideas.
Let's try to find time soon to do a serious code review.

That makes sense. Thanks for making yourself available, I really appreciate it! I'll spend the rest of the week writing more tests (since two impls have implemented them all), and then let's have a Haskell date before poker on Sunday?

Sounds good.

@BartMassey Okay, asking for help! I've pushed the secret key up to the top-level, with the aim that I could then simply replace it with a IO monadic call to either an environment variable or an RNG. However, I've run into a wall with both approaches. I think my compiler errors are due to running the IO monad inside the ActionM monad, but I thought liftIO was supposed to take care of that?

Are you OK now? I'm guessing this is the problem we resolved last night... At any rate the branch seems to build OK up to warnings.

Nope, still stuck. This is work I did this morning, after our enlightening marathon last night. I had hoped to get this branch to a mergable point, but having the secret key in source is not okay, I'm sure you'll agree. I could definitely bash my brain through this problem, but I'm trying to take your advice to ask for help before doing so. :)

You can only liftIO in ActionM, not ScottyM. The fix I have supplied is a kludge, but will work.

OH, by the way you'll have to set the environment variable before things start working again.

Redone. This is why we don't code at 3AM. You'll be much happier now.

Nice! You know, I swear I had tried literally that EXACT code. I wish I had kept it around so I could diff it and figure out what I was missing.


Add ability to zero-fill data

Moving this discussion here since #15 is unrelated as initially reported.
Zero-filling is based on the concept on a "complete checklist", which means it only applies to checklists where all_species_reported == 1. In addition, only species can be zero-filled. For example, Yellow-rumped Warbler can be zero-filled, but taxa below species (e.g. "Yellow-rumped Warbler (Myrtle)") and taxa reported above species (e.g. "Warbler sp.") cannot be zero-filled. Scientific names corresponding to species can be identified as those in the table auk::ebird_taxonomy with category == "species"; this category column also appears in the EBD.
Rolling up taxa below species: eBirders can report taxa below the species level and, in many cases, a checklist can have multiple taxa all corresponding to the same species, e.g.
library(auk)
library(dplyr)
system.file("extdata/ebd-rollup-ex.txt", package = "auk") %>%
  read_ebd(rollup = FALSE) %>%
  filter(common_name == "Yellow-rumped Warbler") %>%
  select(checklist_id, common_name, subspecies_common_name, observation_count)
#   checklist_id common_name           subspecies_common_name            observation_count
# 1 S8949407     Yellow-rumped Warbler NA                                1
# 2 S8949407     Yellow-rumped Warbler Yellow-rumped Warbler (Myrtle)    13
# 3 S8949407     Yellow-rumped Warbler Yellow-rumped Warbler (Audubon's) 17

All of these observations need to be rollup up to the species level either prior to or immediately after zero-filling since the complete checklist concept only applies to species. The typical way to do this is to group by scientific_name or common_name and sum observation_count. However, one catch is that observation_count can be "X" indicating the bird was detected, but no count was recorded. Typically we address this by breaking observation_count into two variables indicating detection and count, respectively.
library(auk)
library(dplyr)
system.file("extdata/ebd-rollup-ex.txt", package = "auk") %>%
  read_ebd(rollup = FALSE) %>%
  mutate(observation_count = recode(observation_count, "X" = NA_character_),
         observation_count = as.integer(observation_count)) %>%
  group_by(checklist_id, common_name) %>%
  summarize(observation_count = sum(observation_count),
            species_detected = any(is.na(observation_count) | observation_count > 0),
            .groups = "drop") %>%
  filter(common_name == "Yellow-rumped Warbler")
#   checklist_id common_name           observation_count species_detected
# 1 S8949407     Yellow-rumped Warbler                31 TRUE

However, we could also just retain a single column and use NA to indicate detection but no count, I've just found sometimes that's confusing for users.
Once taxa below species have been dealt with, you can zero fill a single species by left-joining to the checklist data and replacing NAs with 0s. For multiple species, unless there's some fancy way to do this in SQL you either need to loop through the species and left join one at a time or left join then use something like tidyr::complete() to fill in the missing cases.
A few additional notes that come to mind:

We need to find some way to ensure that checklists have been filtered to only complete checklists prior to zero-filling.
It typically only makes sense to zero-fill one or a set of target species for a specific region. If you try to zero fill all species you'll end up with a massive dataset telling you, for example, that Kiwis don't occur in the Bahamas. Many users forget to subset to a geographic region or to a set of species before trying to zero fill, which results in a massive dataset and very long run times; this is rarely, if ever, what they want. With the exception of global species, like Rock Pigeon or Osprey, users almost always want to subset geographically to roughly the range of their target species.
It's absolutely critical when zero-filling that the exact same population of checklists occurs in both the checklist and observation data. This means that the same set of temporal and geographic filters need to be applied to both datasets and that zero-filing should only every occur when the two datasets are exactly the same version, e.g. ebd_relDec-2021.txt and ebd_sampling_relDec-2021.txt.

Thanks @mstrimas , this is excellent as always!
Rolling up to species makes sense as you describe, as does handling the "X" observed only case.  I gather both incomplete checklists and genus-level-only identifications are just filtered/dropped from the data in this context?   (Arguably some users may want to 'roll up' to a higher-taxonomy level than species, which I suppose could be supported as well, at least to Genus).
I think I follow the process for the actual join...
A few notes as I digest this:

dbplyr can translate some tidyr verbs to SQL, including complete() : https://dbplyr.tidyverse.org/reference/index.html  (though I need to confirm that is available in duckdb -- it should be, but the dbplyr team may not have written the binding yet)...

With the dbplyr backend, the SQL queries are executed "lazily".  I think this has important ramifications for the spatial sub-setting issue you mention -- i.e. it should be possible to generate the View, which is just (if I understand correctly), the SQL code for the fill, but not execute it.  At least in theory, if a user adds some spatial filter to the data first with additional dplyr commands, the SQL engine (i.e. duckdb) is supposed to be smart enough to execute the filters first, and then fill on the fly.  (In any event we could design a function call to enforce that order, but it does leave open the risk that a user tries a very large spatial area and things will presumably go pear-shaped very very fast!

I haven't really wrapped my head around what this looks like in a "real use case".  (i.e. I definitely see why I need to join in the effort data from sampling_event_id's found in the checklists table that saw no birds at all, and thus aren't in the observations table.  But I'm trying to wrap my head around if I really need to complete() for explicit zeros, somehow I feel like I should be able to capture that aspect in the modeling, but I'm probably confused).
Good call on versioning, we can probably enforce that.
Minor thing I noticed in your example code: I think you want an na.rm = TRUE  in summarize(observation_count = sum(observation_count), though when dplyr is using a SQL backend that is implied.  You don't have any "X" counts in the  yellow-rumped warblers, hence the total isn't just NA for that case.

The missing na.rm = TRUE is intentional here, if there's an X for any taxa rolling up to species we give an X to the whole species since we don't know what the actual count is. Of course, that is a choice, we could also include the na.rm = TRUE with the understanding that count is then more of a lower limit, but that's not typically what we've suggested as the best practice. This isn't the best example since there are no NA counts for this species as you point out....
I didn't realize some of the tidyr verbs had been implemented as well, that's useful! The SQL generated by complete is pretty convoluted, I'll be curious to see how it performs in practice on a large dataset:
library(dbplyr)
library(tidyr)
df <- memdb_frame(
    group = c(1:2, 1),
    item_id = c(1:2, 2),
    item_name = c("a", "b", "b"),
    value1 = 1:3,
    value2 = 4:6
)
df %>% complete(group, nesting(item_id, item_name)) %>% show_query()

Assuming users properly subset the data spatially and taxonomically, hopefully this will be feasible...
If you just have a single species you don't need complete() but as soon as you have multiple the join won't generate all the combinations, e.g. (putting this together quick, hopefully I didn't screw this up):
library(dplyr)
library(tidyr)

checklists <- tibble(checklist_id = c("a", "b", "c"))
observations <- tibble(checklist_id = c("a", "b", "b"),
                       species = c("x", "x", "y"),
                       count = c(1, 2, 1))
# one species works, just need to replace NAs
left_join(checklists, observations %>%
            filter(species == "y"))
# but including two leads to missing cases
left_join(checklists, observations)
# completing the missing cases
inner_join(checklists, observations) %>%
  complete(checklist_id = unique(checklists$checklist_id),
           species,
           fill = list(count = 0))


Fix various issues with dockerfile builds

CGO_ENABLED should be exported to be picked up by child processes
The dockerfile should be built relative to the root directory to allowed the imagetest go.mod to find cleanerupper nested in the directory above it
Correct the concourse pipeline failing because of issue 2 to build with the new method.

local_build.sh is unaffected by these changes.
/cc @zmarano @jjerger @koln67 @drewhli

/lgtm


chore: update tech-radar to 1.0

Description
Which issue(s) does this PR fix

Fixes: https://issues.redhat.com/browse/RHIDP-4759

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Tested it and it works as expected.


HWP-461: Updated alerts

Description
This PR includes the following proposed change(s):

Updated styling on alerts.
Added descriptive alerts to invalid inputs on modals.
Fixed join button sometimes displaying "Join" when the user is already a member of the community.

Requires
Add 'Requires Attention' label if appropriate.

[ ] Requires an update to the .env file
[ ] Requires adding a file listed in the .gitignore
[ ] Requires an opinion or answer to a question, see comments.
[ ] Requires other attention, see below.

If there are any requirements for the developer to make after this PR is merged please list them here.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Tested invalid characters in modal inputs.
For pull requests that are not just a simple fix, please check that the branch works on your local machine.

[ ] Tested by Zach.
[ ] Tested by Brandon.
[x] Tested by Brady.

Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes
[ ] If attention is required by the developer such as updating the .env file, these requirements have been listed.

Looks nice! Causing an alert in succession causes a weird visual bug where the error slides in and out quickly.


Rolling incorrectly.

Got the newest update for DnD5E, and it's rolling a d20 instead of the alternative dice. The interface is working, and it's showing the text for the check boxes, but it's rolling initiative normally (d20+dex).

Sorry, I must have broken something. I had it working but then apparently broke something later... will look into it.

Well, it actually was a change in dnd5e v3.1. Which explains why I didn't see it! I had done some testing in v3 but did not notice the rolling fails in the v3.1 update. Hopefully fixed in the v0.1.3 update, just released. Thanks!


Add support for RDS

Issue #, if available:
Did not find a particular issue for supporting RDS, but I guess this is probably planned. If RDS support is not needed at the moment, I will close this pull request.
Description of changes:

clone the smithy model json for rds from GO SDK https://github.com/aws/aws-sdk-go-v2/blob/main/codegen/sdk-codegen/aws-models/rds.2014-10-31.json
create a "helloword example" for RDS

Note, there is another rds-data smithy model. I will work on to add it if this PR is okay to merge.
Test:

./gradlew :aws:sdk:assemble SUCCESS
./gradlew :aws:sdk:test SUCCESS
./gradlew :aws:sdk:cargoCheck SUCCESS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes aws-sdk-rust#36

Hi @rcoh Please let me know if you have other comments. :)

Yeah, it worked. Let me try recreate a instance and get the output quickly.

The example print out is
     Running `/Users/xxx/rust/smithy-rs/aws/sdk/build/aws-sdk/target/debug/rds-helloworld`
DB instance identifier: "test-m5"
DB instance class: "db.m5.large"
DB instance engine: "postgres"
DB instance status: "available"
DB instance endpoint: Endpoint { address: Some("test-m5.c6h6hf3yffse.us-east-1.rds.amazonaws.com"), port: 5432, hosted_zone_id: Some("Z2Rxxxxx") }


Tweetest Prep work for camel tests

👾 Description of the issue
We run external third-party application tests at this project.  They are contained within the external directory.  We would like to improve how we run these tests.  The first step to improving how we run them is to add some documentation and to pull out the individual test properties that we use so that they are stored in the same directory as the test.
This issue is to add a README.md and a test.properties file to the /external/camel test directory.  As part of this prep work, since we already generate the Dockerfile, please also remove the static https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/camel/dockerfile/Dockerfile.
The contents of the README file can be simply some instructions for how to run the test locally.  Use with the instructions from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/README.md#running-external-tests-locally and modify Steps 7 and 9 to reference camel and camel-test specifically.
The contents of the test.properties file will be a key=value format, copying the information from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/common_functions.sh#L179-L191 to populate it.
Adding these files will not change the current way we run these tests.  A separate change will be made to reference the test.properties file, at which point the contents must match those in the common_functions.sh script.
Please take the time to try and run the test locally (using the instructions you are adding in the README file).  Some of the external tests are failing.  When you run it locally, you may find that to be the case.  The reviewer can help to advise you if there are any further steps you can take to try and debug the pre-existing failure, if it exists.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.  Note: that you do not need to add yourself to a Contributors.md file as outlined in the detailed instructions.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing pieces or a problem they will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Hi, I would like to work on this issue, please assign this one to me. Thanks!

@smlambert I would like to work on this issue. But I donot know docker. Do I have to learn Docker? Please guide me a bit. Thank you. Do I only need Docker to run the tests locally?

Great @SAY-droid427 !  Yes, you would need Docker installed to run tests locally, but besides having it installed you do not need to know more about it to resolve this issue.

Part of this issue is to take the "how to run locally" instructions from here: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/README.md#running-external-tests-locally
and add a README.md file with those instructions edited to run the camel tests.
Those steps will tell you what prereqs are needed to be installed to run locally.


Error in  preprocessing embeddings

After running
python preprocess_binary_word_vectors.py  -v /scratch/cc.hi.300.bin  -d word2vec.hi

I am getting the following log
Loading vectors from /scratch/cc.hi.300.bin
Traceback (most recent call last):
  File "preprocess_binary_word_vectors.py", line 61, in <module>
    word2vec2npy(args.vectors, base_path, dest_file)
  File "preprocess_binary_word_vectors.py", line 22, in word2vec2npy
    vocab_size, layer1_size = map(int, header.split())
ValueError: invalid literal for int() with base 10: '\xba\x16O/'

The text format of the embeddings works out well as fixed in #60

You'll need to load them using the FastText tools (e.g. https://github.com/facebookresearch/fastText/issues/52) and process them similarly as in preprocess_binary_word_vectors.py.
Cheers.


The deployment is broken on App Engine flexible for Go

Not sure is the best place to post this issue.
The deployment is broken on App Engine flexible for Go.
Step #1: error building image: getting stage builder for stage 0: MANIFEST_UNKNOWN: "Manifest with digest 'sha256:884ac2144c3ee154bd67271e99bc6ef00f430092750167729b0321ab55fde5ec' has media type 'application/vnd.docker.distribution.manifest.list.v2+json', but client accepts 'application/vnd.docker.distribution.manifest.v2+json'."

I'm also unable to deploy go1.14 or go1.15 in the appengine flex environment with this same error:
Step #0: dc59566c26e6: Pull complete
Step #0: Digest: sha256:9bb092bd9c8d6924d683663953c54d7dd068eabd80d6853ace0fd7f1186fff84
Step #0: Status: Downloaded newer image for gcr.io/gcp-runtimes/go1-builder@sha256:9bb092bd9c8d6924d683663953c54d7dd068eabd80d6853ace0fd7f1186fff84
Step #0: gcr.io/gcp-runtimes/go1-builder@sha256:9bb092bd9c8d6924d683663953c54d7dd068eabd80d6853ace0fd7f1186fff84
Finished Step #0
Starting Step #1
Step #1: Already have image (with digest): gcr.io/kaniko-project/executor@sha256:f87c11770a4d3ed33436508d206c584812cd656e6ed08eda1cff5c1ee44f5870
Step #1: INFO[0000] Downloading base image gcr.io/distroless/base@sha256:884ac2144c3ee154bd67271e99bc6ef00f430092750167729b0321ab55fde5ec
Step #1: error building image: getting stage builder for stage 0: MANIFEST_UNKNOWN: "Manifest with digest 'sha256:884ac2144c3ee154bd67271e99bc6ef00f430092750167729b0321ab55fde5ec' has media type 'application/vnd.docker.distribution.manifest.list.v2+json', but client accepts 'application/vnd.docker.distribution.manifest.v2+json'."
Finished Step #1
ERROR
ERROR: build step 1 "gcr.io/kaniko-project/executor@sha256:f87c11770a4d3ed33436508d206c584812cd656e6ed08eda1cff5c1ee44f5870" failed: step exited with non-zero status: 1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

ERROR: (gcloud.app.deploy) Cloud build failed. Check logs at https://console.cloud.google.com/cloud-build/builds/7df10b69-72ad-465f-ba49-54fb729c3f42?project=498351404878 Failure status: UNKNOWN: Error Response: [2] Build failed; check build logs for details

go1.13 works, but I need a more recent go...

I can confirm that using runtime: go1.13 in the app.yaml does work.

Thanks for the report -- not sure what the cause is yet.

For my deployments the issue is still present for any go runtime

Go 1.13 worked only for the first deployment, it will break too once you deploy again.

@grayside @tbpg what is the ETA on this?
3 days we can't deploy on GAE Flex!

changing the runtime did not work for me when deploying an update to an existing service

I updated to the latest components:
gcloud components update

Now I get a new error:
Step #0: can't load package: package .: no Go files in /workspace/staging.sBe0

https://issuetracker.google.com/issues/171756486

Thanks for the bug report, and sorry we missed it. We've escalated the issue and have a team working on resolving it now.

We have successfully rolled back the broken build. You will also need to downgrade to gcloud version 315.0.0, or upgrade to version 317.0.0 when it is released next week. You can change your gcloud version via:
gcloud components update --version 315.0.0
Please run that command and try deploying again.

Thanks, it works now.

@tbpg I don't have permissions to close this issue, but you can do so now.

Thanks, @sbuss!

Initial root cause analysis indicates that kaniko does not support manifest lists, which the distroless images recently(?) converted to. Moving discussion of that issue to https://github.com/GoogleContainerTools/kaniko/issues/1465.


Dot - group peers in namespace frames

issue : #279
hi @adisos,
in this PR:

improving connlist dot output graphs by adding ns frames.

some questions :

should add peers' kind label to its name?
should keep the ingress_controller_ns  label in its frame? what about ipblocks frames (empty ns)?
to add ns frames to diff dot output files too?

issue : #279
hi @adisos,
in this PR:
* improving connlist dot output graphs by adding ns frames.

some questions :
* should add peers' `kind` label to its name?

* should keep the `ingress_controller_ns`  label in its frame? what about `ipblocks` frames (empty ns)?

* to add ns frames to `diff` dot output files too?

Looks good!

I would keep the kind in the peer's name
I would remove frames from ipblocks and from ingress-controller
let's wait with diff output for a separate branch/PR


Fetch more than 100 collectibles

Seems cremaster is not able to get more than 100 of his collectibles into the dapp.

https://docs.opensea.io/reference#getting-assets
API has paginated functionality.  Will use this for users with more than 300 NFTs

Implement fetch more collectibles on scroll down.
After some research, doesn't make sense to paginate fetching on dapp load.
Our extreme user(s) has 180k (only counting cryptokitties!)

[ ] close fetch loop if user's (collectibles amount % 100) === 0


Login fails with some rcon passwords

Login fails with some rcon passwords, eg DA5JQxtvFZO
Tested on Dayz Standalone servers.

Also having this issue. Spent a good hour thinking I'm missing something silly but it's definitely not wrong.

Check my pull request
apparently the project is already abandoned

@Ruslan-700 you're a legend! Thank you!

Thank you very much @Ruslan-700 for helping out! 👏 I merged your pull request #47.


passing baseUrl in npm command is not working

Hi there!
Thanks for submitting an issue to Protractor.
To help us help you better, please do the following before submitting an issue:

Review the questions section of CONTRIBUTING.md.
Make sure you are not asking a usage or debugging question. If you are, use StackOverflow, Google Group discussion list, or Gitter to get help.
Provide a minimally reduced test case. This makes it much more likely that your bug will be fixed. Protractor has a test Angular application available at http://www.protractortest.org/testapp which you can use for the reproducible test case.
Fill in the information that corresponds to your type of issue below.
Delete this intro and any unrelated text :smile: (if you do not we'll assume you haven't read these instructions and automatically close the issue.)

Bug report
I am using command "protractor config.js --baseUrl='www.****.com'", It is taking the existing baseUrl present in the config file.As per the documentation it should override the existing baseUrl present in the config file.

Node Version: 10.16``
Protractor Version: 5.4.0``
Angular Version: ``
Browser(s): chrome``
Operating System and Version  windows 10``
Your protractor configuration file
A relevant example test
Output from running the test
Steps to reproduce the bug
in package.json in e2e script i have added protractor config.js --baseUrl='www.****.com
The URL you are running your tests against (if relevant)

Feature Request

Reasons for adopting new feature
Is this a breaking change? (How will this affect existing functionality)

You need to add an extra '--' before your parameter list, i.e.
npm run e2e-script -- --baseUrl='www.***.com'


galera: support mariabackup SST method

Make the SST method configurable in the galera custom resource, and allow both rsync and mariabackup methods.
Mariabackup requires a database user's credentials to operate, so reuse the root db user for the time being.
The ability to inject passwords in template galera config files has been implemented. We benefit from that to generate the usual .my.cnf config file for mysql CLI running in the galera container.

/retest

/test mariadb-operator-build-deploy-kuttl

@dciabrin this is fairly old, you want to rebase and get this in, or is it no longer required?

@stuggi this is still neeting but it needs rework.


Middleware skipping

Hi there. First off I'd like to say that this package has been a site saver for sure and a great big thank you!
On to the nitty gritty.
I've done my best to tailor this to the coding style in the examples here so please forgive me if there's a typo or something I am just plain missing.
We've been utilizing this package like such for about a year with current express v4.x and current LTS nodejs with:
app.route('/test').get(userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction }), doSomethingFunction);

... and it's been working fantastic so far.
What we need to do is something like this:
app.route('/test').get(function (req, res, next) {
  userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction })(req, res, next);
}, doSomethingFunction);

... which seems to work well too... however what we really need is something like this...
app.route('/test').get(function (req, res, next) {
  if (someVar) {
    userBruteforce.getMiddleware({ key: someKeyedNewExpressBruteFunction })(req, res, next);
  } else {
    next(); // or use a different ExpressBrute middleware instance
  }
}, doSomethingFunction);

... when this is done express-brute becomes unstable especially during the first few gets and doesn't seem to behave the same when the someVar conditional doesn't exist.
Some general questions after reading a lot of places on the internet including stackoverflow, the README.md, and testing with the new ExpressBrute.MemoryStore for hours:

Are we doing the middleware hopping incorrectly in any of these three code snippet examples? :question:
It seems that putting conditional code on example three blows things up (e.g. no more protection to start) but it appears to work on example two... again is there something up?  :question: e.g. what is being missed here?  :question: Did I miss the boat? :wink: :smile:

Thank you so much for a moment of your time.

Looks like it was both Add-ons in multiple browsers and Extensions in multiple browsers (with native browser implementation)... appears to work in all use cases with the above code without those.
Sorry for the noise. Keep up the great work. :)


Automerge PRs when all checks have been passed

Grant Application Checklist

[ ] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[ ] A BTC address for the payment of the milestones is provided inside the application.
[ ] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[ ] The total funding amount of the project is below CHF 30k at the time of submission.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I hope this doesn’t screw up the other bots, but I’m happy to give it a try.


[NEW ICON] Symfony

Skill Name
Symfony
Why?
Symfony is a highly popular framework to create scalable applications with PHP.
Reference Image

Added in 9904dfdfef9bf5d8ae649a85fcb531b5892b0796!


Census PEP Annual Population

This dataset has Annual Population Estimates from the year 1900 to 2020 for different geographic level such as National, State, County, and Cities.

Cancelling this PR as I am unable to add reviewers, will raise new PR.

Hi, just saw this. Why were you not able to add reviewers - did you seek help for this?


[CRASH] Hyprland starts crashing at launch: "Failed to open xcb connection" and then "m_sWLRBackend was NULL! ..."

Hyprland Version
 System/Version info
Last version from Arch (Artix) repos and different git versions from AUR: nothing works.

Bug or Regression?
Bug
Description
Everything was alright for a very long time on last proprietary NVIDIA drivers on Artix with runit. I just hard reboot my system via power button because of RAM overflow (I closed about 900 tabs) and when PC restarted Hyprland did not start from TTY...
I already tried different HL versions from AUR, different WLROOTS versions, even different NVIDIA drivers versions, also checked all my configs etc...
Found similar issues but nothing helped actually for me.
What exactly should I do now and how I can fix it ASAP? Please help. Never encountered this behavior before... Thanks.
How to reproduce
Hard reboot PC and try to start Hyprland from TTY on Artix Linux with last NVIDIA proprietary drivers.
Crash reports, logs, images, videos
hyprlandCrashReport9310.txt
hyprland.log
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
I hope you didn't have any unsaved progress.

Hyprland received signal 6 (Aborted)

Version: f534ac3fc462d8af923d2a1ab8ef58f62639a1ea
Tag: v0.35.0-94-gf534ac3f

System info:
        System name: Linux
        Node name: svpc
        Release: 6.7.5-artix1-1
        Version: #1 SMP PREEMPT_DYNAMIC Tue, 20 Feb 2024 18:41:43 +0000

GPU:
        01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP102 [GeForce GTX 1080 Ti] [10de:1b06] (rev a1) (prog-if 00 [VGA controller])

os-release:
        NAME="Artix Linux"
        PRETTY_NAME="Artix Linux"
        ID=artix
        BUILD_ID=rolling
        ANSI_COLOR="0;36"
        HOME_URL="https://www.artixlinux.org/"
        DOCUMENTATION_URL="https://wiki.artixlinux.org/"
        SUPPORT_URL="https://forum.artixlinux.org/"
        BUG_REPORT_URL="https://bugs.artixlinux.org/"
        PRIVACY_POLICY_URL="https://terms.artixlinux.org/docs/privacy-policy/"
        LOGO=artixlinux-logo

Backtrace:
        #0 | Hyprland(_Z12getBacktracev+0x62) [0x5cbaae75a272]
                getBacktrace()
                ??:?
        #1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x6d3) [0x5cbaae71f1d3]
                CrashReporter::createAndSaveCrash(int)
                ??:?
        #2 | Hyprland(_Z25handleUnrecoverableSignali+0x48) [0x5cbaae6ad1f8]
                handleUnrecoverableSignal(int)
                ??:?
        #3 | /usr/lib/libc.so.6(+0x3c770) [0x79f3d0d49770]
                ??
                ??:0
        #4 | /usr/lib/libc.so.6(+0x8d32c) [0x79f3d0d9a32c]
                ??
                ??:0
        #5 | /usr/lib/libc.so.6(gsignal+0x18) [0x79f3d0d496c8]
                ??
                ??:0
        #6 | /usr/lib/libc.so.6(abort+0xd7) [0x79f3d0d314b8]
                ??
                ??:0
        #7 | /usr/lib/libstdc++.so.6(+0x97a6f) [0x79f3d1097a6f]
                main
                ??:?
        #8 | /usr/lib/libstdc++.so.6(+0xab11c) [0x79f3d10ab11c]
                CCompositor::isWindowActive(CWindow*)
                ??:?
        #9 | /usr/lib/libstdc++.so.6(+0xab189) [0x79f3d10ab189]
                CCompositor::isWindowActive(CWindow*)
                ??:?
        #10 | /usr/lib/libstdc++.so.6(+0xab3ed) [0x79f3d10ab3ed]
                CCompositor::initAllSignals()
                ??:?
        #11 | Hyprland(+0x6cc40) [0x5cbaae66ec40]
                ??
                ??:0
        #12 | Hyprland(_ZN11CCompositor10initServerEv+0x697) [0x5cbaae6b49b7]
                CCompositor::initServer()
                ??:?
        #13 | Hyprland(main+0x79e) [0x5cbaae69647e]
                main
                ??:?
        #14 | /usr/lib/libc.so.6(+0x25cd0) [0x79f3d0d32cd0]
                ??
                ??:0
        #15 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x79f3d0d32d8a]
                ??
                ??:0
        #16 | Hyprland(_start+0x25) [0x5cbaae6aa8b5]
                _start
                ??:?

Log tail:
[LOG] Hyprland PID: 9310
[LOG] ===== SYSTEM INFO: =====
[LOG] System name: Linux
[LOG] Node name: svpc
[LOG] Release: 6.7.5-artix1-1
[LOG] Version: #1 SMP PREEMPT_DYNAMIC Tue, 20 Feb 2024 18:41:43 +0000

[LOG] GPU information:
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP102 [GeForce GTX 1080 Ti] [10de:1b06] (rev a1) (prog-if 00 [VGA controller])

[WARN] Warning: you're using an NVIDIA GPU. Make sure you follow the instructions on the wiki if anything is amiss.

[LOG] os-release:
NAME="Artix Linux"
PRETTY_NAME="Artix Linux"
ID=artix
BUILD_ID=rolling
ANSI_COLOR="0;36"
HOME_URL="https://www.artixlinux.org/"
DOCUMENTATION_URL="https://wiki.artixlinux.org/"
SUPPORT_URL="https://forum.artixlinux.org/"
BUG_REPORT_URL="https://bugs.artixlinux.org/"
PRIVACY_POLICY_URL="https://terms.artixlinux.org/docs/privacy-policy/"
LOGO=artixlinux-logo

[LOG] ========================

[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/

[LOG]
Current splash: Funny animation compositor woo

[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] [hookSystem] New hook event registered: configReloaded
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 18.58µs. Estimated average calc time: 0.03µs.
[LOG] Creating the ConfigManager!
[LOG] NOTE: further logs to stdout / logfile are disabled by default. Use debug:disable_logs and debug:enable_stdout_logs to override this.
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 10.16µs. Estimated average calc time: 0.02µs.
[LOG] Using config: /home/svyatoslav/.config/hypr/hyprland.conf
[LOG] Creating the CHyprError!
[LOG] [hookSystem] New hook event registered: focusedMon
[LOG] [hookSystem] New hook event registered: preRender
[LOG] Creating the LayoutManager!
[LOG] [hookSystem] New hook event registered: preConfigReload
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 10.10µs. Estimated average calc time: 0.02µs.
[LOG] Using config: /home/svyatoslav/.config/hypr/hyprland.conf
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 10.14µs. Estimated average calc time: 0.02µs.
[LOG] Disabling stdout logs! Check the log for further logs.
[backend/x11/backend.c:394] Creating X11 backend
[backend/x11/backend.c:407] Failed to open xcb connection
[CRITICAL] m_sWLRBackend was NULL! This usually means wlroots could not find a GPU or enountered some issues.
[CRITICAL] Critical error thrown: wlr_backend_autocreate() failed!

NVIDIA-SMI:
nvidia-smi
Sun Feb 25 03:41:49 2024
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 545.29.06              Driver Version: 545.29.06    CUDA Version: 12.3     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce GTX 1080 Ti     Off | 00000000:01:00.0 Off |                  N/A |
|  0%   46C    P8              17W / 280W |      2MiB / 11264MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|  No running processes found                                                           |
+---------------------------------------------------------------------------------------+

Thanks for best compositor but I really need help with this crash.

BRO IT WAS REALLY STUPID!
I forgot I added export DISPLAY=:0.0 to my .zshrc........
I comment this and EVERYTHING WORKS AGAIN (just needed to roll back some new installed packages for sure)
Thanks anyway and sorry for my "bug" ahahah (but maybe you should add to Wiki that you should not do it lol)


Liqui getOrder considers "amount" to be cumulative instead of remaining

Per the Liqui API for Method OrderInfo:
https://liqui.io/api
start_amount: The initial amount at the time of order creation.
amount: The remaining amount of currency to be bought/sold.
However LiquiAdapters.adaptOrderInfo uses "amount" as the LimitOrder's cumulative amount (completed)

@cerko2 You worked on this here. I am not available for one week but maybe you can check this out before I come back.

This was previously fixed for LiquiAdapters.adaptActiveOrder at
https://github.com/timmolter/XChange/pull/1921/commits/640978b0fe374d436be358977707c3ab3c3e9631
but the fix simply needs to be made to adaptOrderInfo() as well
On 2/11/2018 3:25 AM, cymp wrote:

@cerko2 https://github.com/cerko2 You worked on this here
https://github.com/timmolter/XChange/issues/1825. I am not available
for one week but maybe you can check this out before I come back.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/timmolter/XChange/issues/2282#issuecomment-364740514,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT6veWzzYiERUlHML-JjxIGVO_dfjjKks5tTsAsgaJpZM4SBPim.

Fixed it with https://github.com/timmolter/XChange/pull/2344.

Regarding LiquiAdapters.adaptOrderId needs to use initOrderId not orderId, I can't test that now but feel free to do it since it looks like to know how to code.


Reserve IP pool for Nutanix tests

Description of changes:
Nutanix tests are currently failing because it doesn't have an IP pool
This PR reserves the IP pool for Nutanix tests
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override eks-anywhere-e2e-presubmit


Fix typo in injector template trustDomain/meshId

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

/lgtm

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
9b580466334978be0d581f375b20904b0445c3d7
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn Can we also cherry-pick this to 1.3? Also put a P0 to get this through quicker?

/lgtm
/approve
/cherry-pick release-1.3

@kyessenov: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/retest

@kyessenov: new pull request created: #16405

In response to this:

/lgtm
/approve
/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Does istio/installer need a corresponding PR + backport?

there is an open PR for this in installer
On Tue, Aug 20, 2019, 9:55 AM Romain Lenglet<EMAIL_ADDRESS>wrote:

Does istio/installer need a corresponding PR + backport?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/16385?email_source=notifications&email_token=AAEYGXOFBMSSGAEWM3MXXILQFQOYBA5CNFSM4INEKY7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4W6P7Q#issuecomment-523102206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXP42YQBJ5VEDHQBBV3QFQOYBANCNFSM4INEKY7A
.


tests/crypto/mbedtls/ results in exception on frdm_k64f

The test tests/crypto/mbedtls/ results in exception.
Arch: arm
Board: frdm_k64f
Zephyr tag:  v1.12.0-rc2 - commit d93ecda4c590d674e1cccdc65fb3501ae80a2055.
Error Console Log:
***** Booting Zephyr OS v1.12.0-rc2 *****
***** BUS FAULT *****
  Executing thread ID (thread): 0x20004138
  Faulting instruction address:  0xe1f264a0
  Stacking error
Fatal fault in essential thread! Spinning...

Steps to reproduce:
cd tests/crypto/mbedtls/
rm -rf build && mkdir build && cd build
cmake -D BOARD=frdm_k64f ../
make BOARD=frdm_k64f
cp zephyr/zephyr.bin /run/media/pswarnak/MBED/

Check the console log.

Bisected to ba2c44e4839af520008cbb5ee8a31983e2f967b8
Author: Andrew Boie<EMAIL_ADDRESS>Date:   Thu May 24 22:14:20 2018 -0700

    tests: enable HW stack protection by default

    Userspace doesn't necessarily imply stack overflow protection
    for supervisor threads. Enable this as well if the hardware
    supports it.

    Signed-off-by: Andrew Boie<EMAIL_ADDRESS>

Is this test overflowing its stack? Seems like most likely explanation.

Thanks @andrewboie. Validated the test, works fine now.


ebml: Provide a way to iterate on elements of an EBML document

In such cases when reading the whole content of an EBM document into memory there should be a way to scan through it.
Questions:

How to iterate?
How to skip child elements?
How to seek?

In the current design DecodeBody accepts ebml.EBML (EBML Header) as it's second parameter to make sure DecodeHeader is called first. Maybe it would be better to reconsider this decision and store the header info in the decoder struct.
Option 0
Based on encoding/xml
f, err := os.Open("/foo/bar")
// handle error
d := ebml.NewDecoder(f)
var h ebml.EBML
// decode header
for {
	el := d.Element()
	// handle element
}

Question 2 and 3 applies.
Option 1
Based on text/scanner.
f, err := os.Open("/foo/bar")
// handle error
d := ebml.NewDecoder(f)
var h ebml.EBML
// decode header
s := d.Scanner(h)
// decode header
for s.Next(&h) {
	el := s.Element()
	// handle element
}

Question 2 and 3 applies.
Option 2
Based on github.com/yuin/goldmark/ast
f, err := os.Open("/foo/bar")
// handle error
s := ebml.NewDecoder(f)
var h ebml.EBML
// decode header
ast.Walk(h, func(el ebml.Element) (ebml.WalkStatus, error) {
	// handle element
	// return ebml.WalkStop, nil
	// return ebml.WalkSkipChildren, nil
	return ebml.WalkContinue, nil
})

Question 3 applies.

ebml.Reader can be used to iterate on elements.


Add oplog meteor integration tests

Closes #633, #248.
This PR also enables the MongoDB service as a single node replica set.

It's still a bit broken see here. I think I simply need to adjust the failures to relative the paths.

re SQLITE_BUSY error, ignoring them all for now as test names vary.

The only thing left to fix is the config for (mongodb, mongo-go-driver).


Clickable Axis Labels

Clicking the labels should bring up the multi-level menu similar to the experience on Gapminder World. We should be able to change scales as well.
@angieskazka @olarosling Let's discuss how to design this solution so that the UI is consistent

@arthurcamara1 why label gapminder-world? don't we want to have it for bubble-chart in general?

@arthurcamara1 UI discussion pending. meanwhile i move the issue to 0.7.2, and connect it together with integration of the new indicator picker #375

done in 8d652f13555765d68a362128a182006d4bc80bc9

improved all the way until be9a001d0aca83f2a608217d35ad092b8e6d427a


Is testing with the S3 protocol now supported?

No, not as part of CLOSED submission, but it is possible using an OPEN submission.  The WG is currently debating the features we will include in v2.0 of the benchmark and S3 is on the list.  It is more of a prioritization question than a "do we need it" question, so if you think it should be on the committed list, please attend the WG meetings and/or send email to the alias to make your case that it should be committed for v2.0.

You are welcome to join the Working Group, that will get you added to the email list that we use<EMAIL_ADDRESS> You can email the list directly and get responses, but you won't see all of the other discussion happening within the group.


Card 10255 Has Incorrect sub_type: Deed

should be "Consumable"

That is not incorrect.  You should treat Deed and Consumable as the same thing for now.


test: updated createModal util

Added another way to open the property pane for Modal popup widget
Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: test/fixModalPopup

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.57 (0)
36.44 (0)
33.17 (0)
55.1 (0.01)

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.04 (-0.22)
40.42 (-0.83)
34.48 (0)
55.96 (-0.26)

/ok-to-test sha=1525798

/ok-to-test sha=1525798

/ok-to-test sha=3c10746

/ok-to-test sha=3c10746

/ok-to-test sha=c7ccb69


Missing some data on trivy_vulnerability_id metric - not resolved

Hello
I upgrade trivy-operator to 0.15.1, because I waiting for resolve bug #1035 . But it's not resolved:
`   - fixedVersion: 2.34-6ubuntu1.4
installedVersion: 2.34-6ubuntu1.3
links: []
primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
resource: binutils
score: 5.5
severity: MEDIUM
target: ''
title: >-
heap-based buffer overflow in bfd_getl32() when called by strip_main()
in objcopy.c via a crafted file
vulnerabilityID: CVE-2022-38533
- fixedVersion: 2.34-6ubuntu1.4
  installedVersion: 2.34-6ubuntu1.3
  links: []
  primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
  resource: binutils-common
  score: 5.5
  severity: MEDIUM
  target: ''
  title: >-
    heap-based buffer overflow in bfd_getl32() when called by strip_main()
    in objcopy.c via a crafted file
  vulnerabilityID: CVE-2022-38533

- fixedVersion: 2.34-6ubuntu1.4
  installedVersion: 2.34-6ubuntu1.3
  links: []
  primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
  resource: binutils-x86-64-linux-gnu
  score: 5.5
  severity: MEDIUM
  target: ''
  title: >-
    heap-based buffer overflow in bfd_getl32() when called by strip_main()
    in objcopy.c via a crafted file
  vulnerabilityID: CVE-2022-38533

- fixedVersion: 2.34-6ubuntu1.4
  installedVersion: 2.34-6ubuntu1.3
  links: []
  primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
  resource: libbinutils
  score: 5.5
  severity: MEDIUM
  target: ''
  title: >-
    heap-based buffer overflow in bfd_getl32() when called by strip_main()
    in objcopy.c via a crafted file
  vulnerabilityID: CVE-2022-38533

- fixedVersion: 2.34-6ubuntu1.4
  installedVersion: 2.34-6ubuntu1.3
  links: []
  primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
  resource: libctf-nobfd0
  score: 5.5
  severity: MEDIUM
  target: ''
  title: >-
    heap-based buffer overflow in bfd_getl32() when called by strip_main()
    in objcopy.c via a crafted file
  vulnerabilityID: CVE-2022-38533

- fixedVersion: 2.34-6ubuntu1.4
  installedVersion: 2.34-6ubuntu1.3
  links: []
  primaryLink: https://avd.aquasec.com/nvd/cve-2022-38533
  resource: libctf0
  score: 5.5
  severity: MEDIUM
  target: ''
  title: >-
    heap-based buffer overflow in bfd_getl32() when called by strip_main()
    in objcopy.c via a crafted file
  vulnerabilityID: CVE-2022-38533

`

Can you check it?

Trivy-Operator version (use trivy-operator version): 0.15.1
Kubernetes version (use kubectl version): v1.23.15+rke2r1
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): CentOS Stream 8

@MarekDrz the change made by PR#1343 did broke the vulnerability ID metric, I had to revert it back

Ok, will this be fixed in future versions of trivy-operator?

Ok, will this be fixed in future versions of trivy-operator?

sure , just need to make sure its done in a way that it do not break metrics

Hi,
Has this issue been resolved in https://github.com/aquasecurity/trivy-operator/releases/tag/v0.16.0

Hi,
Has this issue been resolved in https://github.com/aquasecurity/trivy-operator/releases/tag/v0.16.0

not you , I'll try to include it with next patch


Fixing bug 1144871 in samples used by accessibility test team.

Fixes Issue #328.
Description
Both TextBlocks in the main window should be read by Narrator when they content changes. Created a handler listening to TargetUpdate events of the TextBlocks and set them as LiveRegion. The new handlers fires an event of LiveRegionChanged for both of the TextBlocks.
Customer Impact
Screenreader does not tells the user that a movie is streaming.
Regression
No. This sample is used for Accessibility testing and never fully supported Narrator.
Testing
The sample project was tested using Narrator to confirm that it now speaks when the texts are updated, announcing that a movie is streaming.

/cc @SamBent

/azp run


Fixes the Internet Explorer 10/11 bug.

Fixes the event names for touch events. This allows the script to work with Internet Explorer 10 and 11 where it did not before.

+1

This project is not currently providing support. So I decided to make my own version based on wordfind. Your commit was added.
https://github.com/ideas-delivery/wfgame/commit/6311c006a0d03a44dbf2a48849dc1b0aad90ec4c

@BurakErbora I pulled your modifications into my fork of this repo : https://github.com/ctrlaltdev/wordfind


Roman/feature/store.deselect-by-clicking-badge

Travis automatic deployment: https://65-pr-ching.surge.sh


Placing 2.0

Added the grid placement system; everything appears to be working properly.

changes in this branch have been included on Sidebar-UI-2.0


Fix nested context manager for main_process_first()

This PR proposes a fix for #1303.
The bug seems to be in delegation from one context manager (for example from Accelerator) to another one (from AccelerateState). Currently, the following pattern is used:
@contextmanager
def main_process_first(self):
    yield self.state.main_process_first()

However, when executed, this context manager simply yields without entering self.state.main_process_first(), causing the bug. The solution is to correctly enter the inner context manager using with.
This was a very interesting bug. Since I haven't defined nested context managers like this before, I wanted to understand what the right way to do this is, and whether the current implementation in the library was correct. Like the cool kids I even asked ChatGPT, which explained what the current implementation was trying to do and how to use yield context_manager() or yield from context_manager(). Unfortunately it turned out that ChatGPT was hallucinating its explanation and use of these concepts, and even the code examples which it produced did not run and produced an error instead.
In summary, according to ChatGPT the current implementation is correct, though it's not. So I'm very curious if I'm understanding it correctly now, and whether GPT-3/Copilot/ChatGPT had anything to do with the original implementation :)

Hi @flukeskywalker, it did not actually. But great job identifying the bug! What concerns me is when I was writing this I tried my best to come up with a test, and clearly that test does not work. So if you feel inclined to do so, it'd be great to see perhaps what went wrong with them/fix them (see accelerate/test_utils/scripts/test_script.py), otherwise I will look into it later next week.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thanks @muellerzr. Indeed, the current test doesn't work because the process_index does not depend on whether the main process executes the code block first or not.
We need a way to test not only that the code block is entered first in the main process, but also that it is exited in the main process before it is entered in other processes. This will ensure that there isn't a false positive when the main process happened to enter the code block first. A simple test would be to create a file if in main process and attempt to read it if not in main process. Perhaps there could be something more elegant?

I think that test would work quite well for the time being!

@flukeskywalker would you like to include it in this PR? Otherwise I can write one in afterwards

Added, ready for review.

@flukeskywalker do make style; make quality :)

Hi @muellerzr, do you think this PR is ready?


Add unit-test to test data is up-to-date.

There is a weird issue with HOBOlink where it splits the data off into multiple columns.
Here is a CSV direct from a HOBOlink export:

Yes, it's very strange.
Our code has fixed this issue-- it uses some Pandas magic to identify the first nonmissing value within a row that matches to a subset of column names.
With that said, we want to make sure we're unit-testing in a way that could have detected this issue, so going forward we can snuff out anything like this.
We want to assert that the last row of a HOBOlink dataframe (returned by get_hobolink_data()) contains a timestamp that is no more than 30 minutes later than the current EST time. We can also do the same for the USGS data (30 minutes). For the fully pre-processed and joined data, I would make that interval 2 hours due to how we group data only after a full hour's worth of data is in.

Taking a look at this.

Here's what I got so far: ([https://github.com/codeforboston/flagging/compare/master...dfe325:dev_unit-test-data])
I hard-coded in the vars that seemed useful from hobolink.py to get a response from hobolink.Trying to successfully return a 200 before proceeding to actually testing the column/final row in the dataframe object.
This gives me an error because it doesn't know what the value of get_keys()['HOBOLINK'] is (tried poking around in the app and enviro vars but no luck). I'm assuming this needs these creds to run and there is no effective way to simulate this for the purposes of what we want to test.

I'm confused by the class TestData. What's the class supposed to be doing?
Also, you don't need to recreate the wheel-- just use the functions in the code that get the data; you don't need to make a new one.

Ok, new version is up: https://github.com/codeforboston/flagging/compare/master...dfe325:dev_unit-test-data

Eliminated TestData (added a class bc I was anticipating adding multiple tests - first to confirm functions were working, then to test the actual data, but am just testing data now)

-Using the current function to test that the last timestamp is within 30 minutes:
last_timestamp.minute - datetime.now().minute < 30
This needs one more pass though... it doesn't account for what happens when the hours are different (e.g. last_timestamp = 7:02:00 and datetime.now().minute is 6:59:00) but I have an idea of how to solve this.

The Pytest framework tends to use functions and decorators, not directly-initiated custom classes. It's rare you'll use classes when using Pytest. Pytest is compatible with unittest.TestCase, but it's rare you'll ever need it and you don't need it here. If you saw any examples of unit-testing in Python that you were copying from, check to see whether it was from the base unittest base module or Pytest.
Anyway, that's no big deal... because what you have now is REALLY close! 😮 Wow!
Here are my notes:
(1)
last_timestamp = df.iloc[-1][0] <-- the iloc[-1] is correct. Good job! We are assuming that the dataframe is sorted by timestamp, but I told you to assume that and we will continue to assume it, as the sorting of values by timestamp makes everything a lot easier. (We can eventually test this too!)
The [0] technically works but is dangerous. The reason why it's dangerous is because we don't want to rely on the order of the columns if we don't need to. I don't think it'd be fair of me to torture you with trying to figure out the Pandas API on your own, as it's a clunky mess (I love it, but it's not friendly to people just getting started with it). So I'll just give you the answer:
last_timestamp = df['time'].iloc[-1]

Basically, first you want to select the column time not based on its position but its name, and this does that. I also suggest selecting the column before the row, as this is more idiomatic and familiar in the realm of Pandas code.
(2)
assert (last_timestamp.minute - datetime.now().minute) < 30 <-- Right idea, but wrong execution. The minute label is a number between 0-60:

What you actually want is to take the difference between two full datetimes, and then convert that time-delta into minutes. Don't convert to minutes until after you've taken the difference between the two datetimes. In other words, you want "minutes" of the time deltas not the times themselves. Does that make sense?

Gotcha, thanks! Always super helpful to know what the conventions are and what is a more or less "dangerous" implementation. I agree with using column headings rather than index. For the column heading I initially was trying to make it work with "Time, GMT -04:00" but wasn't having any luck so did the index instead, will make the change back though.
And timedeltas make sense! Taking the difference between two full datetimes would solve for the hours and also account for another edge case that was bugging me, namely what if (for some reason) the dates are different? I'm trying to do the timedelta thing today but have to step away for a bit. Will send an update, hopefully with the full solution, tonight.


Knockback.js-1.0.0 Wish List

Hi everyone!
Knockback.js is getting to a feature and maturity point where I'm thinking about finalizing a 1.0.0.
What do you think is missing or needed for a 1.0.0?

Released 1.0.0


Handle errors in simpleQueryResponder

Instead of blowing up because result is null, return a 500, log it, and let the server not die.

LGTM


Integrated services endpoints

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
yes

Related tickets
-

License
Apache 2.0

What's in this PR?
Rename features to integrated services in API endpoints/transport layer.
Why?
Make API consistent with new naming (features → integrated services)
Checklist

[ ] Implementation tested (with at least one cloud provider)
[x] OpenAPI and Postman files updated (if needed)
[x] User guide and development docs updated (if needed)

The featureName variable name should probably be serviceName even in legacy routes


[WIP]: Huber loss function

@chrisdembia and @nickbianco, this is a first try for the Huber loss function. It is not yet complete but I would be interested to have feedback on a few things:

Would you keep both smoothing options available, ie tanh vs Huber loss?

I thought I solved it but I am actually still struggling with one case. For the shortening heat rate, when use_force_dependent_shortening_prop_constant is true, the shortening heat rate is not 0 when the fiber velocity is > 0 (see curves Figure 1 (left) below). This makes a little trickier the use of the Huber loss function as I implemented it. What I did is that I rotated the curve, used the Huber loss function, and the rotated back. As you can see in the figure, this looks good (although very steep). However, I did not think that, in practice, we do not have access to the value before rotation, since that value depends on a if-statement that we want to avoid...So basically, for now, my ugly code implementing this rotation thing depends on a value I get out of this if-statement, which is certainly not what we want. I think it should be feasible to avoid this rotation and to directly apply the Huber loss function (this might also allow having a smoother transition I think). Any ideas?

I have tried to keep the same structure (i.e., m_conditional) when implementing the Huber loss function. Not sure this is what we want.

All the tests pass but the problem did not converge (point 2 above did not matter, since  use_force_dependent_shortening_prop_constant wastrue). I got restoration failed after about 1h. Maybe it is to steep, not sure...

I attach the MATLAB code I used if you want to give it a shot. If you run it, you should get the figures for the different cases where smoothing is applied.
Those are my thought for now. Thanks in advance. I hope we can get that bhargava_smooth PR done soon, it is getting long :)

testMetabolicEnergyModel_HuberLoss4.zip
Brief summary of changes
Give option to use a Huber loss function rather than a tanh function.
Details (optional)
CHANGELOG.md (choose one)

[ ] updated
[ ] no need to update because...

This change is

@nickbianco, thanks for the quick response.
Quick reply to 4, no it did not converge...
For 2, it might indeed make sense to use a tanh in any case, since it goes negative when vM > 0. Using both smoothing options will require some changes but I will give it a shot.


Refactor the domain view

This splits the domain viewer into a set of components and improves the UI somewhat.

Not sure how this got created!  Meant to make it against upstream.


data loader running error

while running the (data_loader.py) i am getting the following errors. if any one know the solutions please let me know
Traceback (most recent call last):
File "/home/komali/PycharmProjects/text-to-image-master/data_loader.py", line 113, in
main()
File "/home/komali/PycharmProjects/text-to-image-master/data_loader.py", line 108, in main
save_caption_vectors_flowers(args.data_dir)
File "/home/komali/PycharmProjects/text-to-image-master/data_loader.py", line 85, in save_caption_vectors_flowers
encoded_captions[img] = skipthoughts.encode(model, image_captions[img])
File "/home/komali/PycharmProjects/text-to-image-master/skipthoughts.py", line 96, in encode
X = preprocess(X)
File "/home/komali/PycharmProjects/text-to-image-master/skipthoughts.py", line 160, in preprocess
sent_detector = nltk.data.load('tokenizers/punkt/english.pickle')
File "/home/komali/anaconda2/lib/python2.7/site-packages/nltk/data.py", line 801, in load
opened_resource = _open(resource_url)
File "/home/komali/anaconda2/lib/python2.7/site-packages/nltk/data.py", line 919, in open
return find(path, path + ['']).open()
File "/home/komali/anaconda2/lib/python2.7/site-packages/nltk/data.py", line 641, in find
raise LookupError(resource_not_found)
LookupError:

Resource u'tokenizers/punkt/english.pickle' not found.  Please
use the NLTK Downloader to obtain the resource:  >>>
nltk.download()
Searched in:
- '/home/komali/nltk_data'
- '/usr/share/nltk_data'
- '/usr/local/share/nltk_data'
- '/usr/lib/nltk_data'
- '/usr/local/lib/nltk_data'
- u''

import nltk
nltk.download('punkt')


Fix muted Player option not working (typo)

There was a typo here. It's muted not mute.
Now this option actually will work I guess :)

Coverage increased (+0.1%) to 73.979% when pulling e384999398fe0b9b91a269bc66c32c08395ce40a on tchakabam:patch-1 into f8e340014c842698b647e04c163a3729782e6e36 on clappr:master.

Coverage increased (+0.2%) to 74.017% when pulling c36edc016eee8db3600a0261b216f17c128c2a26 on tchakabam:patch-1 into f8e340014c842698b647e04c163a3729782e6e36 on clappr:master.

Coverage increased (+0.06%) to 73.902% when pulling 0c618ad779b60a12dec043db5e1b1c0191e13236 on tchakabam:patch-1 into f8e340014c842698b647e04c163a3729782e6e36 on clappr:master.

We use mute as part of our API, maybe it's better just to fix this on the rendering or offer both muted and mute for a while.
This change will break an API.

@clappr/core ^

sorry, which API?
I can only see muted in other parts of Clappr code :)
For sure we can add mute in the Clappr options as equivalent property and rewrite it to muted internally? :)
All for making this as easy as possible for anyone, but it should be agreed I guess.

@leandromoreira Documentation was my ground truth: https://github.com/clappr/clappr/blob/master/src/components/player.js#L135

I think maybe it would be better to handle it completely in html5_video.js and in mute() call setVolume(0) and in unmute() call setVolume(1).
Then in setVolume it would update both the video element 'muted' and 'volume' properties. Ie 'el.muted = volume === 0'
This way muted is always automatic just from the volume level.
What do you think?

@tchakabam indeed, there's a typo in the documentation. The mute option has always been the right one. This should get fixed as well.

@towerz OK. Wether the mistake is in the documentation or in the code was the question I guess :)
We assumed the documentation to be correct! Therefore I had to assume the code is wrong.
Sorry for the misunderstanding.
We are usually assuming that the documentation is actually correct. So I will probably update the docs :)
However, what we still will need is setting muted and defaultMuted on the video element right from the start.

@tchakabam if you need player to be muted right from the start, it should be possible. There is an example here.

@kslimani Cool, thanks! :)
However, this is at least fixing the wrong documentation which was stating that the Clappr.Player option is muted, while media-control was assuming it is mute. Since everyone seems to agree on mute and it was the only thing working, the documentation has now been updated (whoever tried to use muted before didn't get a result anyway, so this isn't like it's a breaking spec change or so :) )
Also, I think it would be nicer to also for HTML5 video make sure that the video element muted and defaultMuted properties are set on creation of Playback. Because otherwise we are relying on side effect from MediaControl to take care of setting volume to zero in case of muted. It is better if this interaction is not necessary and the Playback already can set up the respective native properties itself, this is how I would expect it to interpret the Player options like. What do you think @towerz @leandromoreira @kslimani @tjenkinson ? :)

@tjenkinson I agree with that, there only needs to be one place where we set muted based on volume, and everything else can drive that. Will change that.
But what are the mute and unmute methods really used for, i can not see them being called anywhere. Or is it just through core.getCurrentPlayback()... ? It is not part of the Playback interface, so what do they do here really? Some things aren't quite clear here I'd say :)
We would however really like of the HTML5 plugin here would be more self-contained concerning how it applies the native video element options, meaning that it should not have to rely on MediaControl to interpret the player options and set the volume to zero "sometimes". If the play for some reason happens before the volume call, we are screwed, this holds better ;) Or if someone disable MediaControl plugin or implements it's own. Playback's should be self-contained what this concerns I would argue.

Coverage increased (+0.03%) to 73.872% when pulling f575c03c0f95241aa50fae6b4c5e2c5c45c2ef1b on tchakabam:patch-1 into f8e340014c842698b647e04c163a3729782e6e36 on clappr:master.

@tchakabam you're right. Actually, the playback should be responsible for these kind of operation and semantic.
About the mute/unmute operations, this should be called from the public Player interface. There are mute/unmute operations there, but as you pointed out, they're not calling their respective playback methods, but instead, they're changing volume to/from 0 using the MediaControl.
About the MediaControl being disabled/overridden, you're also correct. It shouldn't be responsible for those operations, only for translating the user interface interactions to playback operations. This will be changed soon, since the MediaControl will no longer be a special component, but instead it will be a UICorePlugin.

@towerz ok, nice!

We're still deciding whether or not to change the Playback API to include the muted state, but with a more concise interface.

My thought here is that it is actually a good thing to have one single method, volume, that one needs to implement to have a valid Playback implementation, and that 0 also drives eventual native muting functionnality. I couldn't really think about a case where I would need to differentiate there, and also it motivates to keep muted volume caching and recovery outside of the plugin and at a higher level, for example in like it is now MediaControl.
At least for this PR, I'd definitely prefer to just leave at the docs fix and the initial native muted and defaultMuted handling to have the spec aligned and functionnality safe.
I am happy to help with improving the interface if we find an agreement but as I said I think it's actually very good like it is, given that it is implemented like here.

Coverage remained the same at 73.845% when pulling b1a1489dd091ececb0cf1fb417edc21a72f026ba on tchakabam:patch-1 into f8e340014c842698b647e04c163a3729782e6e36 on clappr:master.

:+1: I agree too I think it makes sense that the actual playback only has to deal with a volume not mute status.

Thanks, guys! 🍻

Couple years late to the party, but any idea instantiation with mute: true,  followed by player.unmute(), followed by player.configure(src: "new hls stream") would re-apply the muted attribute? Do I need to be tracking the state myself just to load a new stream?


Feat/pluggable components injector

Description
This PR is the complete implementation of pluggable components injector proposal with a single change mentioned here: https://github.com/dapr/dapr/issues/5668#issuecomment-1424666211
Issue reference
Please reference the issue this PR will close: #5492
See also: https://github.com/dapr/dapr/issues/5668#issuecomment-1424666211
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@ItalyPaleAle Did some testing of this with my own application/components and the components container is injected as expected.
That said, I've been struggling with a separate (but related) issue where the injected components container is not (always) creating the sockets files before daprd expected to find them.  I think there's still a race condition between those sidecar components to sort out.

Thanks for confirming!

@dapr/maintainers-dapr This is probably ready to be merged now, seems good!


serial monitor and serial show data combined

I would like to request that the serial workflow in the app is twofold. While I really like the option of clicking the show data button and getting a visual of the data I also like the immediacy of seeing the terminal window displayed on the main page such as in previous versions.

Perhaps on the main page you can have the small terminal along with an additional show simulator button placed alongside it if in fact you needed to visualize the data. My main objection to the current interface which only has the show data is it simply lacks the immediacy of having the terminal on display at all times as in previous versions.

This is a good idea, adding it to the serial improvements list.

Just checking in on this. I am using a version from october that still has the terminal frame on the main page because I need to see the incoming serial message and (I know I am being nit picky) it is inconvenient to jump to the show data page.

Enhancements are captured here: https://github.com/Microsoft/pxt/issues?q=is%3Aissue+is%3Aopen+label%3Aenhancement