Fixed helper splat warning due to being interpreted as argument prefix

Overview
Hello. :wave: Was seeing warnings show up in my test suite, since I have Ruby warnings enabled, and wanted to fix the issue in in this gem.
Details
Necessary to resolve the following warnings showing up when using this gem in test suites with Ruby warnings enabled (i.e. ruby -w): gems/propshaft-0.8.0/lib/propshaft/helper.rb:10: warning: *' interpreted as argument prefix. By using parenthesis, these warnings go away and the test suite output is much cleaner.
Notes
Not sure when you plan to publish a new version of this gem but if a patch release is acceptable, that would be most welcome. :bow:

Closing due to lack of feedback. Going to use a alternative solution instead.


osmium_toogr2 core dump if called without arguments

The tool osmium_toogr2 crash with a core dump if called without arguments:
~/osm-gis-export/build/src: ./osmium_toogr2
Pass 1...
terminate called after throwing an instance of 'osmium::io_error'
what():  Could not detect file format for stdin/stdout.
Aborted (core dumped)

PS: same problem for the other tools:
~/osm-gis-export/build/src$ for i in osm*;do ./$i;done
terminate called after throwing an instance of 'osmium::io_error'
what():  Could not detect file format for stdin/stdout.
Aborted (core dumped)
terminate called after throwing an instance of 'osmium::io_error'
what():  Could not detect file format for stdin/stdout.
Aborted (core dumped)
Pass 1...
terminate called after throwing an instance of 'osmium::io_error'
what():  Could not detect file format for stdin/stdout.
Aborted (core dumped)
terminate called after throwing an instance of 'osmium::io_error'
what():  Could not detect file format for stdin/stdout.
Aborted (core dumped)

This just needs a wrapper around most of the main function that catches the exception thrown and creates a nice error message and exits with an error code. Patches welcome.


Release v<IP_ADDRESS> [skip pd_pr]

Codecov Report

:exclamation: No coverage uploaded for pull request base (release@c04e2ef). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             release   #1483   +/-   ##
=========================================
  Coverage           ?   8.89%
=========================================
  Files              ?     121
  Lines              ?   12682
  Branches           ?       0
=========================================
  Hits               ?    1128
  Misses             ?   11432
  Partials           ?     122

Flag
Coverage Δ

backend_integration
8.89% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04e2ef...95619b6. Read the comment docs.


DUPLO-14385: remove Always from being an option for restart_policy. Set OnFailure to be new default

Task linked: DUPLO-14385 TF:K8s Job/Cron Job Doc: update Restart policy description


GitHub Webhook: Support team/edited and more verbose logging for pull_request events

A simple follow up from PR #14954.
@timabbott pinging for review.

I personally think that the message formatting could be better, but I'm not sure about the ideal message formats.

Generally looks great; posted some comments on the fixtures.  If you can include screenshots from @punchagan's screenshot tool for the final review of formatting, that'd be really helpful.

Thanks for the review! Here are some screenshots for the updated message formats:

That screenshot tool is pretty convenient, thanks for making it @punchagan! :smiley:
I fumbled a bit when using it for the first time though. I saved the images to /tmp so then to retrieve the images I had to add my ssh key to the vagrant box and then sftp into it. I later realized that the zulip directory is bind-mounted into the container and I could have used this directory instead of /tmp :facepalm:.

I'm glad you found it convenient.
@Hypro999 are you on the latest master? That was an older version which was writing the images to /tmp. Also, #14957 has some improvements on this, that would make generating these much easier. :)

Oh no, I just used the --help flag and saw that we can control the name/destination and used that to write to /tmp.

Merged the big commit; posted a comment on the logging on.  Thanks @Hypro999!

Thanks for the follow up review. I've updated the commit and this PR accordingly.

Great, merged, thanks @Hypro999!


Identify "+00:00" as UTC

When a DateTime object is created from a Unix timestamp using the @ syntax, new \DateTime('@123456789'), the resulting object gets a timezone with the name +00:00 (tested with PHP 5.5.25 and 5.4.38). Passing a timezone object as the second argument does not change this.
This timezone represents UTC, but it is not identified as a UTC timezone in VObject\Property\ICalendar\DateTime.
This PR adds +00:00 to the list of known aliases for UTC.
(BTW, there are other aliases, but they are all deprecated)

Thanks for the bug report. Travis failure is unrelated. Going to fix that on master first.

Could you rebase/merge from master so we get a correct message from travis?

Done :-)


After using app.hide(), callback fired after click INSIDE window

In the example, add app.hide() below every window.hide(), then:
First way to reproduce

click on tray icon (window shows)
click again on tray icon (window hides)
click again on tray icon (window shows again)
click on desktop (directly on the desktop image, not on an app)
click INSIDE the window, .start callback is called, window hides

Second way to reproduce

click on tray icon (window shows)
right-click INSIDE another app (window hides)
click again on tray icon (window shows again)
click INSIDE the window, .start callback is called, window hides

app.hide() is used to regive focus to the previous app (window.hide() doesn't do that), this was recommended by one of the Electron dev.
Note: this is one of the issues I was seeing, see #3.

I can reproduce that, using app.hide() instead of window.hide() causes clicks to be registered by global observer. Not sure what I can do about that, if system dispatches the event to its own window it means it does not see that window or something like that..

Maybe an alternative to handle all cases would be to fire click events from everywhere, attach a click position object to the callback, and let the app itself decide what to do (like ignoring the event if the click position is inside some bounds).
Right now I see 3 mishandled cases that could be solved with the above:

Clicking on desktop (desktop image) doesn't fire anything.
Using app.quit() instead of window.hide() will fire events even when clicks happen inside the app window.
No click/right-click event fired on the tray icon when a custom tray context menu is currently being shown.

is not valid as mentioned in #5 due to use of undocumented feature in Finder.
I am not really sure what is going on there, but I can confirm that app.hide() acts different from window.hide(). Once again we use public API to observe clicks, if it fires it means that something fishy is going on in app.hide(). It works fine with window.show or window.hide though.
At the moment this module only observes events dispatched to other apps. Usually you have better means to observe events originating from Tray icon, or your window, etc..

Closing this because I think this was in relation to using undocumented Finder setting CreateDesktop false. Please re-open if you still experience this. I am not able to reproduce this.


Invalid PIN message but works if close and open the app again

User 'The Dan from Uncle' from telegram reported that it has happened sometimes with him that he gets an invalid PIN message when trying to unlock the wallet. However if he closes  and opens the app again it works.
Phone: Galaxy S8
OS: Android 9

I can confirm that this also happens on my app.
Samsung Galaxy A40, Android 10

We also have some reports from users saying that even after restarting the app the PIN didn't work. All reports are from Android users.

Just had another Android user reporting the same issue.
Model: vivo x21
OS: Android Version 9 (Funtouch OS_9)

Just had another Android user reporting the same issue.
Model: vivo x21
OS: Android Version 9 (Funtouch OS_9)

One more report. The PIN does not work if close and open the app again.
Model: Huawei P30 Lite
OS: Android Version 10


Minor Breaking Change in 0.2.16

Talking specifically about the bug fix in the $urlRouter code in 0.2.16:

Sort URL rules by specificity. Potential minor BC if apps were relying on rule registration order.

One of my application expects the states to be in a certain order I think? - (because I have 2 states for one url - 1 for authenticated users and 1 for unauthenticated users).
This is what should happen - if user goes to url:

If unauthenticated, taken to state 1.
If authenticated, taken to state 2.

Order the states are registered in:

State 1
State 2

Now what happens is that it works perfectly fine on Chrome, but on Firefox it never goes to state 1 but keeps redirecting to state 2, which essentially redirects the user again to a login screen.
On moving state 2 above state 1 in the registration order: it works on Firefox as expected but doesn't on Chrome.
Reverting to 0.2.15 fixed it for me but I'd like to upgrade. Any help or pointers would be appreciated!

On moving state 2 above state 1 in the registration order: it works on Firefox as expected but doesn't on Chrome.

Sorry about that.  We're reverting that BC.  Wait for 0.2.18 which will not sort your routes.  dupe #2501

@christopherthielen Thanks a lot! :+1:


Fix typos in readme.md

This fixes a few typos in readme.md, as well as updating 2 places that incorrectly refer to the hosts file as a 'folder'.

Hi @someonefamous, thanks for the contribution!
Can you please make these changes in the readme_template.md file?
See the hosts file generation process merges data into readme_template.md to re-create readme.md each time.
So merging your contribution doesn't actually fix anything.
If you apply these changes to readme_template.md I'm happy to merge it.

Sure, can do!

Submitted changes to readme template instead - the only one not in there was the 'sketch vs sketchy' error.

This is done in #682.  Closing.


Question about parameter weights

May I ask, do the U-nets used in different denoising steps in the diffusion model share weights?

Yes, those weights are shared.


Search - Search router text color is gray

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/50815
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition: Light theme should be used.

Navigate to https://staging.new.expensify.com/
Log in with a Gmail account that has some expenses
Navigate to Search - Filters
Set any filter that'll give results and click on the "View results" button

Expected Result:
Search router text color should be black
Actual Result:
Search router text color is gray.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/b8854b3e-98cc-4710-aeda-e2d0f3f3eee7

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - Search router text color is gray
What is the root cause of that problem?
We are setting searchInputStyle here
https://github.com/Expensify/App/blob/4a25c36e50b58ef9e5ba8b63cf32132f95a0b005/src/components/Search/SearchRouter/SearchRouterInput.tsx#L108
which sets the color to textSupporting
https://github.com/Expensify/App/blob/4a25c36e50b58ef9e5ba8b63cf32132f95a0b005/src/styles/index.ts#L3617
What changes do you think we should make in order to solve the problem?

If we want to set it to black we can set the color to themeTextColor
                        inputStyle={[styles.searchInputStyle, styles.themeTextColor, inputWidth, styles.pl3, styles.pr3]}

What alternative solutions did you explore? (Optional)

I'll work on this fix since it seems like we had a bad conflict resolution that undid the changes from my PR

PR in review

PR being CPed

Fixed in staging


Apply PR#3090 from 5.2.x (fix clientUri handling in MongoDbConnectionFactory)

This patch applies the same fix to MongoDbConnectionFactory that PR#3090 applied in the 5.2.x branch.
Briefly, it corrects the way MongoDbConnectionFactory processes MongoDb connection strings (essentially by removing the code that "messed with" them and instead just passing them to the Mongo java driver to deal with).
Note: I included Misagh's change to the original patch that cleans up the extra import statement that was causing checkstyle to fail.

Sweet. Thank you @dacurry-tns!


V0.2 docs process mode

Description
Add maro process mode docs
Linked issue(s)/Pull request(s)
Type of Change

[ ] Non-breaking bug fix
[ ] Breaking bug fix
[ ] New feature
[ ] Test
[X] Doc update
[ ] Docker update

Related Component

[ ] Simulation toolkit
[ ] RL toolkit
[ ] Distributed toolkit

Has Been Tested

OS:

[ ] Windows
[X] Mac OS
[X] Linux

Python version:

[ ] 3.6
[X] 3.7

Key information snapshot(s):

Needs Follow Up Actions

[ ] New release package
[ ] New docker image

Checklist

[ ] Add/update the related comments
[ ] Add/update the related tests
[ ] Add/update the related documentations
[ ] Update the dependent downstream modules usage

Codecov Report

Merging #226 (dd1c65a) into v0.2 (0903cd6) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v0.2     #226      +/-   ##
==========================================
- Coverage   65.73%   65.67%   -0.06%
==========================================
  Files         110      110
  Lines        5221     5221
==========================================
- Hits         3432     3429       -3
- Misses       1789     1792       +3

Flag
Coverage Δ

unittests
65.67% <ø> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...o/simulator/scenarios/citi_bike/business_engine.py
73.04% <0.00%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0903cd6...dd1c65a. Read the comment docs.


Config 'syntax_map' not working as expected

I am attempted to map the syntax "Yeod Julius" to "JavaScript" so that jshlint will work on my .julius files.
I am using the package https://packagecontrol.io/packages/Yesod which sets the syntax to "Yesod Julius":

I would have expected the config
"syntax_map": {
    "yesod julius": "javascript",
}

to result in my file now being ran against jshint, but it is not. If I change the syntax to "JavaScript" I get the hints as expected.

It’s a mapping based on file name (don’t as me why). Can you try it with a dash in between yesod and julius?

It's a lot easier to base it on the file name since you don't have to parse the file in order to determine its display name.
You can fetch the name to use with this console line:
import os.path; os.path.splitext(os.path.basename(view.settings().get('syntax')))[0]

It's a lot easier to base it on the file name since you don't have to parse the file in order to determine its display name.

Sure, but it doesn’t explain how users are supposed to find out what to put in the mapping. Must be a design choice from way back when. 🤷🏼♂
This seems resolved to me.

Just a note that ideally this will be prevented by https://github.com/SublimeLinter/SublimeLinter3/issues/691, although the syntax in question uses source.yesod.julius instead of source.js.yesod.julius.
Since it looks like a templating language, it should be using the new .sublime-syntax format and with_prototype anyway. It's probably not going to be updated. We should consider cases where you'd need to adjust to weird base scope names of third-party syntaxes in #691.


configure removal of wpm limitation

It's a little unclear to me why you'd want to throttle the output to a given wpm. Is there a way to configure this limit to be "off"?

@ekg the purpose is to make the output appear smooth. Most GPT tools have choppy output that comes in chunks of words. I found that aesthetically less pleasing than character-by-character streaming.
You could alias gpt to gpt --wpm 9999 $@ in your shell's profile to avoid the throttling. I could also add a permanent config setting for it in the next update.

Thanks, I understand that. From my perspective these interfaces are useful in an environment that is unlikely to be observed by a human, so simulating human behavior is irrelevant. I can do the alias of course. Does setting the wpm value to a huge number ensure the flow is as fast as possible?

@ekg I've added the ability to bypass the WPM buffered output:

You can now pass a --wpm value less than 0 (e.g. --wpm=-1). This will bypass the buffer and output as fast as possible.
You can also configure this permanently by manually editing your $HOME/.gpt/config.json and adding an line for "wpm": -1

Relevant release notes and update instructions are here: https://github.com/mattvr/ShellGPT/releases/tag/0.3.1
Thanks for the feedback and let me know if you have any issues or further suggestions.


Fix FinishMiddleware type errors

6fe46e754231741edddbec48177219ff3fd6b43f
Callback passed to handler should return ResponseInterface implementation or throw a exception.
Since at previous code Exception was being returned, type error at guzzle side was occurring.
Fixed by throwing, not returning, Exception at FinishMiddleware::onRejected.
f77fdb7b8570ebb9eb296dda1bb7dc5d022dc57a
In some cases ResponseService::handleDomError was being called when response content type is not text/html.
Fixed to check content type before executing ResponseService::handleDomError.

CIは後で直します

CI は Timeout のエラーでRetryすれば成功する


Added template for N32

@17cupsofcoffee I haven't made a draft before, just want to make sure I've included everything :+1:

It looks like CI is failing on master, could you fix that in this PR as well?


fix(rocksdb): downgrade the RocksDB to v9.3.1 due to the bug in blobdb

This closes #2604.
We would like to downgrade to the RocksDB version from v9.6.1 to v9.3.1 due to the issue that may affect users who enabled the blobdb.

And this commit will be cherry-picked into 2.10.1 after it's merged.


Add a command to tell if directory is a manuscript directory

detect if composer is accessible
show composer version
detect if git is accessible
show git version
show number of packages with simple list
verbose flag to show a detailed table?


use msp430g2553 from master

r? @reitermarkus
(rust_highfive has picked a reviewer for you, use r? to override)

bors try

r? @therealprof
Please, merge this change.


VM create with a bad nic crashes too late

If you create a VM with a nic of type bridge that doesn't exist, it won't immediately return a bad request, it will start creating the service and crash while installing it and return a bad request then after the service has been created even though it failed to create the VM on the node.
The bad request should be returned at an earlier stage before attempting to create the VM.

software version
master : 851d41fa


Run a job to export all models

Using the Azure CLI, run a command that iterates over all models and returns a CSV file that indicates whether the export was successful or not.
Requires #301  #302

Trying experiment with this command:
(azure) jfowers@jfowers:~/mlagility/src/mlagility/cli/cloud$ python control.py create setup selftest run stop --cluster --name exporttest --size 6 --hardware cpu-big-ram -f /home/jfowers/mlagility/models/*/*.py -a="--export-only"


Simple and straight flow of liveliness package

Pull Request Template
Description
Please include a summary of the changes and the related issue(s) if applicable. Describe the motivation and context for the changes. List any dependencies that are required for this change.
Fixes #(issue number)
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please describe):

Checklist
Please review the following list before submitting your pull request:

[x] I have read the contributing guidelines
[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)
If applicable, add screenshots to help explain your changes.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

[x] Test A
[x] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Additional Information
Please add any other information or context about the pull request here.
Linked Issues
If this pull request is related to one or more issues, please list them here:

Closes # (issue)
Related to # (issue)

Thank you for your contribution! Please review the checklist and ensure that all items are completed before submitting your pull request.

Hi @AHzax, can you please attach a sample recording of the changes you've made in the following files?

lib/src/screens/components/m7_livelyness_detection_steps_overlay.dart
lib/src/screens/m7_livelyness_detection_screen.dart
lib/src/screens/m7_livelyness_detection_screen_v2.dart

Please attach a recording of example app.
Secondly, can you please squash the commits into a single commit?


always lowercase email addresses before saving to users table

I will like to work on this issue.

Hi @mubarak23 and thank you for your interest in the project. You are welcome to submit a PR for this issue, and you will be credited as a contributor if your PR is accepted. Please let me know if you need any guidance or information to help you with the development process.

OK, I will go ahead and fork the repo and work on the issue thank you


Inquiring about choice of activation function

Hi Nathan, Just a quick question, is there any logic behind the choice of sigmoid being the activation function in lats layer of AE. ?

Hi Nathan, Just a quick question, is there any logic behind the choice of sigmoid being the activation function in lats layer of AE. ?

Hi ! Yes the sigmoid ensures that your output values are between 0 and 1, as it should be because they are pixel values.


Update Set-PnPSubscribeSharePointNewsDigest.md

Type

[ ] Bug Fix
[ ] New Feature
[ ] Sample
[x] Typo

Related Issues?
N/A

Thanks!


Copy editing: CCD Reduction Guide notebooks 06-00 to 07-03

This is to copy edit the CCD Reduction Guide. The notebooks have been copy edited according to our more relaxed style for guides and tutorials as noted in the Astropy Style Guide, which allows for sentence case headings and contractions.
@mwcraig I noticed there wasn't any content in notebooks 07-02 and 07-03 beyond the titles -- are you planning to add content for these?

@mwcraig I noticed there wasn't any content in notebooks 07-02 and 07-03 beyond the titles -- are you planning to add content for these?

@lglattly -- yes, someday...


Release 2.0.0

Version 2.0.0
New features

Supports FlowConfig feature to set source to forward via HTTP request
Provide version of module via 'OnNewStatusModuleVersion'
Function 'getParameters' to provide PersistentData parameters
Check if features of module can be used on device and provide this via 'OnNewStatusModuleIsActive' event / 'getStatusModuleActive' function
Function to 'resetModule' to default setup

Improvements

Added parameters to 'addRequest'-function
Added ENUMs for RequestMode
New UI design available (e.g. selectable via CSK_Module_PersistentData v4.1.0 or higher), see 'OnNewStatusCSKStyle'
check if instance exists if selected
'loadParameters' returns its success
'sendParameters' can control if sent data should be saved directly by CSK_Module_PersistentData
Added UI icon and browser tab information

Following tasks were checked

[x] Module is coded and structured according to the "Developing guideline for modules" described within the CSK documentation
[x] All functions/events/parameters are documented within the manifest documentation
[x] The manifest description of the main CROWN includes main information about the purpose of the module and how to use it in general
[x] API docu based on the manifest was created and stored within the "docu"-folder of the repository
[x] Internal LUA code documentation exists for variables and non served functions
[x] All relevant infos are logged via the SharedLogger 'ModuleLogger'
[x] Module supports persistent data feature based on 'CSK_Module_PersistentData'
[x] Module supports user management based on 'CSK_Module_UserManagement'
[x] No open "ToDos" within the code or at least clearly explained comments why they exist...
[x] "Version" key in app manifest was updated following semantic versioning (and use '0.x.y' for test / experimental modules which are not yet ready to be officially released)
[x] Meaningful IDs used for UI elements
[x] Module was tested on an AppSpace device (at least on SICK AppEngine) with no error message
[x] README.md is up to date (incl. info of device + firmware the module was tested with)
[x] CHANGELOG.md is up to date

Thx for the review!

2nd review is done.


Add new para to Set-SPPeoplePickerConfig and Add-SPPeoplePickerSearchADDomain

@JohanFreelancer9

I'm ok after @JohanFreelancer9 suggestions and also both SecureSocketsLayer descriptions should match

@xinyiHugeHard
Please update to that the description for SecureSocketsLayer is the same in both files.
After you do that, please @ mention me.
Thank you

@tiburd Sorry for the late response, currently description of SecureSocketsLayer  in 2 files are both started with "Specifies whether " I don't think SecureSocketsLayer should have the same description in 2 files.

@tiburd Sorry for the late response, currently description of SecureSocketsLayer in 2 files are both started with "Specifies whether " I don't think SecureSocketsLayer should have the same description in 2 files.

@get-itips
Hi Andres,
Can you please review my comment (in which I tried to repeat your comment) and Xinyi's response?
Thanks!

I reviewed again and it is ok as it is as cmdlets are different @tiburd


Cleanup deprecated config

As of newer version of SublimeLinter, this plugin stopped working with
deprecation messages, and is being disabled in SublimeLinter. This
cleans up the deprecated stuff, allowing the plugin to load again.

I am also getting the following:
credo disabled. 'selector' is mandatory in 'cls.defaults'.
 See http://www.sublimelinter.com/en/stable/linter_settings.html#selector

I am also getting this, not sure if relevant:
SublimeLinter: ERROR: elixirlinter disabled. 'cls.defaults' is mandatory and MUST be a dict.

@zlatio Thanks, hits the spot :heart: Appreciated!


Minefields SIDC

I am currently doing some work on 2525D/APP6D and I have come across 4 SIDCs and I don't know where they have come from, they seem to carry on from where both 2525D & APP6D finish, does anyone have any idea where they came from?
10002500002707080000 Protection Areas Minefield AP Minefield
10002500002707090000 Protection Areas Minefield AT Minefield
10002500002707100000 Protection Areas Minefield Unspecified Minefield
10002500002707110000 Protection Areas Minefield Unspecified Minefield Decoy

No idea where they come from. I have looked in drafts of both 2525D and APP6D and can't find them there.
I will close this issue, since it is not related to milsymbol. At the moment the plan is to implement tactical points for 2525D/APP6D when they are made public. You can contact me via email, found on homepage, if you have any further questions.


(MODULES-3247) Enable schema and database ownership change

Currently postgresql::server::schema, postgresql::server::db and
postgresql::server::database allow creating new schemas and
databases if they don't already exist and assigning owners to
them. This patch enables changing the owner of a schema or database
that already exists if the change_ownership variable is set to true.

CI failure is unrelated, mime-types/ruby dependency error.


Complete io_config, Pass model to model funcs

Describe your changes
io_config attribute can take both io_config dict and function names. These cases are not cleanly handled yet.
There is a special case where it is a string and is called with hf_config.model_name. But this is arbitrary and was initially implemented to make the whisper example work.
In this PR:

Handle all possible values for io_config attribute.
PyTorchModel.get_io_config method is added to get the io config from io_config and hf_config in decreasing order of priority.
io_config, component_func and dummy_input_funcs are called with self by the caller model. This makes them all standardized and not be called with some arbitrary arguments.
HFConfig updated to handle io_config and dummy_input creation from onnx config itself.

Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[x] Lint and apply fixes to your code by running lintrunner -a
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Update documentation in docs/source/features/huggingface_model_optimization.md
encoder_decoder_init_dummy_inputs and decoder_dummy_inputs in examples/whisper/code/user_script.py doesn't need the model. Only config is used.


lxc inserts /var/lib/cloud/seed/nocloud-net on every start

lxc is inserting the template (seed) files for cloud-init every time. It seems like maybe template files should not be inserted on every start.
$ cat go
#!/bin/sh
sdir="/var/lib/cloud/seed/"
lxc delete --force x
echo "== starting =="
lxc launch trusty x
sleep 5

echo "== cleaning =="
lxc exec x -- rm -rf "$sdir"
echo "removed it"
lxc exec x -- sh -c '[ -d "$0" ]' "$sdir" && echo "$sdir is there" || echo "$sdir is gone"
lxc stop x
echo "== container stopped =="

echo "== restarting =="
lxc start x
lxc exec x -- sh -c '[ -d "$0" ]' "$sdir" && echo "$sdir is back" || echo "$sdir is still gone"
lxc exec x -- find "$sdir" -type f

$ sh ./go
== starting ==
Creating x
Starting x
== cleaning ==
removed it
/var/lib/cloud/seed/ is gone
== container stopped ==
== restarting ==
/var/lib/cloud/seed/ is back
/var/lib/cloud/seed/nocloud-net/meta-data
/var/lib/cloud/seed/nocloud-net/vendor-data
/var/lib/cloud/seed/nocloud-net/user-data

This is configurable in the image tarball and could be changed to only apply on initial container creation.
However should we do so, there would be no way for someone to correct invalid container metadata short of destroy and recreating the container whereas today they can simply wipe /var/lib/cloud/seed clean, reboot and have cloud-init run again.
Is there a specific problem with always having the file generated at startup time?

I think its just less expected.  I somewhat expect that lxc will do something to configure my system when i first start it, but then i kind of expect that a stop and start its gone.
I came across this when working on cloud-init networking to take injected network yaml.
I'd do something like:
lxc init xenial x1
lxc-chroot x1 sh -c 'rm -Rf /var/lib/cloud/seed && tar -xf -' < seed.tar
lxc start x1
and then i'd find that lxc overwrote the files i hand set up.

Okay, I have another change to get into that metadata so I'll bundle that change together when sending the request to the CPC team.

My change has been merged, so this will progressively get fixed as new images roll.


[Beam 287] Add new groupId

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[X] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[X] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Add new Beam groupId.

R: @davorbonaci

Left a few minor comments, almost ready for merge.

Triage: 0.1.0-incubating, release blocking.

Updated accordingly.

Squashed 3 commits in one.

LGTM, modulo 2 typos.

Updated fixing typo.

LGTM. Waiting for CI to complete.

Travis failure comes from Kafka, not from the PR itself.

Merging


Nested structs lead to incomplete type error

If I put this in my mod ffi:
struct A {
    b: B,
}
struct B {
    c: i32,
}

I get this error during compilation:
warning: /.../lib.rs.cc:255:5: error: field has incomplete type 'org::example::B'
warning:   B b;
warning:     ^
warning: /.../lib.rs.cc:225:8: note: forward declaration of 'org::example::B'
warning: struct B;
warning:        ^
warning: 1 error generated.

If I change it to b: Box<B> it works fine.

We'll want to implement a topological sort for data structures to fix this. The current implementation in cxx::bridge for shared structs is really basic, it just forward declares them all in original order and then defines them all in original order.
struct A;
struct B;

struct A final {
  B b;
};

struct B final {
  int32_t c;
};

That's fine if forward references are boxed (as you noticed) or if the structs are topologically ordered already. (So a workaround for you is to put B before A in the cxx::bridge source file.)

Marking help wanted. A correct topological sort implementation here should handle translating this:
struct X { y: Y }
struct Y { z: UniquePtr<Z> }
struct Z { x: X }

into this:
struct Z;

struct Y final { std::unique_ptr<Z> z; };
struct X final { Y y; };
struct Z final { X x; };


Always use retry backoff in ZooReader(Writer)

Always use the retry backoff when always retrying. This fixes an issue where an "always retry" condition is triggered, it will not barrage ZooKeeper with repeated immediate retries.
This fixes #3718

There was some discussion about changing the default maxWait interval being something longer than 5 seconds. I'm not so sure about that, but if that changes, it can be done in a separate change.

Created #3723 to increase the timeout.


docker 1.9.1 doesn't support --log-opt labels or --log-opt env despite being within an example in the docs.

docker 1.9.1 doesn't support --log-opt labels or --log-opt env despite it being validated.
https://github.com/docker/docker/blob/v1.9.1/daemon/logger/jsonfilelog/jsonfilelog.go#L201-L202
--log-opt max-size=[0-9+][k|m|g]
--log-opt max-file=[0-9+]
--log-opt labels=label1,label2
--log-opt env=env1,env2

logs will only contain the following... missing labels and env
{"log":"xxx\r\n","stream":"stdout","time":"2016-01-19T16:03:51.634609436Z"}

The log options should

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

hi @ajohnstone  where do you get docs said support it for 1.9.1 ?

@HackToday Thanks for the quick response. https://docs.docker.com/engine/reference/logging/overview/

docker daemon --log-driver=json-file --log-opt labels=foo --log-opt env=foo,fizz In the examples.
Its valid within the validation of the docker jsonfilelog.go
json-file opts describe in the above documentation describes

--log-opt max-size=[0-9+][k|m|g]
--log-opt max-file=[0-9+]
--log-opt labels=label1,label2
--log-opt env=env1,env2

@ajohnstone how did you start your container ? which labels and env variables did it have ? We miss a few informations to be able to debug it..
$ docker daemon --log-driver=json-file --log-opt labels=foo --log-opt env=foo,fizz
# Should put foo=bar in logs (in an attributes map if I recall in `jsonfile` logs)
$ docker run -itd --label foo=bar busybox

Apologies, i've mis-interpreted the implementation and/or my test environment.
It is working correctly.

@ajohnstone Hi Andrew, I know this has been closed for a while, but how did you manage to add the labels to your log? I am a bit stuck there. I am deploying with Ansible, and it would look like I have labels by the information provided by docker inspect
            "LogConfig": {
                "Type": "json-file",
                "Config": {
                    "labels": "container=elasticsearch",
                    "max-file": "3",
                    "max-size": "1m"

but I don't 😿
Thank you

@ajohnstone Hi Andrew, I know this has been closed for a good while, but I am facing the same difficulty. I thought I had solved it by the docker inspect results:
            "LogConfig": {
                "Type": "json-file",
                "Config": {
                    "labels": "logstash",
                    "max-file": "3",
                    "max-size": "1m"
                }

but then the label will not appear in the logs? So I definitely haven't solved it 😿
Any help gladly welcome.
Thanks, Pablo

I think I managed, not using quotes in Ansible did the trick
    log_driver: "json-file"
    log_opt:
      labels: container_name
    labels: container_name=elasticsearch


Never calculate the cost of OCPI transaction

I noticed that total cost is not calculated in the ocpidata part of the transaction in case of ocpi connection. Inside the code I found that total_cost is always set to 0 with a comment beside it saying "Never calculate the cost of OCPI transaction".
Is there a logical reason for this or it is meant to be fixed in the future ?
Another remark is that I couldn't find anything related to the tariff in the dashboard UI, I don't really understand the connection between the pricingDefinations and tariff calculation used in OCPI, could you explain this to me ?
Thanks in Advance

The pricing is defined and calculated at IOP side (Gireve in France) and the billing system is also on their side.
So, there must be a single source of truth, that’s why we don’t pass it into the CDR which was most of the time different and triggered an alert on their side.
But, CPO are currently migrating their backends to use the OCPI Tariff module and once all of them are done with that, we can reactivate the pricing in the CDR and define the model on our side + use the Tariff module to send it over to the IOP.


(BKR-226) - rsync fails because of NATted ports

Can one of the admins verify this patch?

ok to test

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/773/
Test FAILed.

Breaks spec:
Failures:

  1) Beaker::Host do_rsync_to do_rsync_to logs info and call Rsync class
     Failure/Error: expect(Rsync.host).to<EMAIL_ADDRESS>
       expected<EMAIL_ADDRESS>            got<EMAIL_ADDRESS>
       (compared using ==)
     # ./spec/beaker/host_spec.rb:578:in `block (3 levels) in <module:Beaker>'

I've fixed the test by making it test equality with the default ip set by the make_host method, which is actually a decent test because it sets it to a string.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/809/
Test FAILed.

Breaks spec ruby 2.0+:
  1) Beaker::Host do_rsync_to do_rsync_to logs info and call Rsync class
     Failure/Error: expect( host ).to receive(:to_s).and_return('host.example.org')
       (host.example.org).to_s(*(any args))
           expected: 1 time with any arguments
           received: 0 times with any arguments
     # ./spec/beaker/host_spec.rb:575:in `block (3 levels) in <module:Beaker>'
```1

Can one of the admins verify this patch?

Still breaking spec.

Last comment still current.

Will close next week due to inactivity.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/907/
Test PASSed.

Looks good.


MINOR: Fix buildings outlines (edges) rendering.

Depth offset improperly applied finally as constant in NDC,
this causes different clipping of building geometry and its
outline on clip planes proximity. Second problem comes from
fact that varying (dependent on homogeneous w) offset
applied in clip space provides huge depth differences in
NDC space, thus resulting in z-fight (and win) of outlines
being behind the actual geometry.
Draft with explanatory comments and testing code.
Signed-off-by: Krystian Kostecki<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

@zbigg the code with explanatory comments should resolve the concerns we have today :).
Please play with different ClipPlanesEvaluators and even change nearMin (in evaluator settings) to 0.1 this value highlights the problems even more. I have changed it just to present optimal solution.

Codecov Report

Merging #926 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage    47.8%   47.68%   -0.13%
==========================================
  Files         225      235      +10
  Lines       21589    21756     +167
  Branches     4917     4929      +12
==========================================
+ Hits        10321    10374      +53
- Misses      11268    11382     +114

Impacted Files
Coverage Δ

@here/harp-materials/lib/EdgeMaterial.ts
9.45% <ø> (ø)
:arrow_up:

@here/harp-mapview/lib/ClipPlanesEvaluator.ts
12.45% <0%> (ø)
:arrow_up:

@here/harp-materials/lib/Utils.ts
20% <0%> (-80%)
:arrow_down:

...atasource-protocol/lib/operators/ColorOperators.ts
40% <0%> (-60%)
:arrow_down:

@here/harp-materials/lib/IconMaterial.ts
44.44% <0%> (-55.56%)
:arrow_down:

@here/harp-map-controls/lib/Utils.ts
46.15% <0%> (-23.85%)
:arrow_down:

@here/harp-mapview/lib/ScreenProjector.ts
54.28% <0%> (-17.15%)
:arrow_down:

@here/harp-omv-datasource/lib/OmvTiler.ts
50% <0%> (-16.67%)
:arrow_down:

@here/harp-utils/lib/Logger/ConsoleChannel.ts
38.46% <0%> (-11.54%)
:arrow_down:

@here/harp-utils/lib/ObjectUtils.ts
83.33% <0%> (-10.22%)
:arrow_down:

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d59c31...4ff6dc3. Read the comment docs.

Dup. Already delivered in #939


Undo works wrong

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
Easy to reproduce:

Create a block A and add code
Create block B and add code
Go to block A and modify the code
Run the block A
Undo

The undo will remove the block B, not undo the change to block A code.
If the user focuses block A and undo, it will undo the code change in block A.
VS Code Version
Applies both insiders and latest
Jupyter Extension Version
v2024.2.2024022602 (pre-release)
Jupyter logs
No response
Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

If the user focuses block A and undo, it will undo the code change in block A.

Thank you for filing this issue, however this is by design.
What we've found is that this is the best and most common expectation from users.
I.e. users expect undo/redo to work in code only when they focus the code, this way
hitting undo/redo doesn't undo/redo code in other cells ..
You can try disabling this setting to change this.


Feature Request: Accept commits committed by GitHub.com

When GitHub.com users author commits through the GitHub interface, the
resultant commit lists their identity as the commit author, but it lists the
committer as GitHub<EMAIL_ADDRESS>This interferes with the CLA
verification process because that e-mail address will not appear in any
signature databases.
Since the basic behavior is semantically accurate and definitely intentional,
it seems unlikely to change (more on this in a moment). Therefore, in order to
allow CLAHub users to accept contributions authored through the GitHub.com
interface, this project should be updated to account for this detail.
I can think of two solutions:

Unilaterally whitelist<EMAIL_ADDRESS>for all CLAHub accounts.
Allow CLAHub users to insert this address themselves

The first is implicit, which is both a positive and negative aspect. It means
users have less to configure, but it also means they may not fully understand
how CLAHub is behaving. And while GitHub is unlikely to stop authoring commits
on behalf of their users, it seems possible that they would change the
<EMAIL_ADDRESS>e-mail address, which would require another fix from
CLAHub.
The second solution requires more of the user, but this means less room for
surprises. As it happens, there is already an open issue for this basic
functionality (although it does not mention the use case described above)--see
https://github.com/clahub/clahub/issues/112
(For reference, this came up in the context of a contribution to the JSHint
project: https://github.com/jshint/jshint/pull/2953)

Oh, I think/wonder if this might be the same issue we're facing in #133 that I haven't pinned down yet. A potential third path forward might be to constrain CLAHub to looking at the author as opposed to the committer.

We have decided the path forward is to whitelist the GitHub.com contributor (though the author will still have to have signed the CLA for the status to be "green"). I am going to code a fix to be deployed.


Remove string until we fix running multiple e2e tests on one ec2 inst…

…ance
Issue #, if available:
Description of changes:
Adding the string quotes before fixed the issue of running multiple tests on an instance initially, but more needs to be done to support that use case. https://github.com/aws/eks-anywhere/issues/1548
Testing (if applicable):
make
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


pm: cc13x2_cc26x2: Implement their own constraint

TI Hal has its own constraint API that is used by its drivers. These
constraints need to be correlated with Zephyr constraints to be
constraints set in the HAL be visible on Zephyr and vice-versa.
Fixes #38362
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

Just split  the commit as suggested.


Clear-Site-Data header docs tasks for Fx68

See https://trello.com/c/nOqHAAgZ/181-clear-site-data-header-fx-68 for original trello card.
Acceptance criteria

[x] Navigation to Clear-Site-Data page refreshes the current page — documented appropriately

Submitted BCD PR 4372 adding entries into the database for each directive, with executionContexts noted as being removed in Firefox 68
Updated Firefox 68 for developers


Update about-this-design-guidance.md

updated metadata

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/about-this-design-guidance.md
:warning:Warning
View
Details

mixed-reality-docs/about-this-design-guidance.md

[Warning] Author jonwie cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Cache eviction policies and Hashing techniques used?

Would be of great help if you could help answer the following:

What is the eviction policy of the software cache (of the JIT compiler)?
How do you generate the keys (TAGS) to compare against, in your software cache? (Do you use CRC32 over the input parameters and CPUID?)
Is there a way to forcibly flush the software cache from the user side? (Any API to flush the software cache?)

Hi Kaustubh,
the cache is fully associative, i.e., size is also limited by (completely) searching the cache. Please note, this cache is on a per-thread basis (thread-local). The capacity as well as the size of the cache is always POT in order to optimize some of the operations (like eviction). The size can be smaller than the capacity (see paragraph at the bottom about LIBXSMM_CACHE).

Eviction is not based on additional counters such "least used". Instead, the one entry is evicted that is most distant from the last hit. It is sort of a round-robin/ring buffer policy.
CRC32 is used if permitted by the static architecture (target flag used when LIBXSMM is compiled), i.e., at least SSE4.2 was used. In past implementations, the CRC32-based hash was dispatched dynamically (can be easily reintroduced). However, SW based implementation is fully compatible with the HW implementation and highly/sufficiently tuned, i.e., dynamic dispatch is not used or the dispatch overhead is not worth the effort (at last according to my last check).
A libxsmm_finalize/libxsmm_init cycle could be abused to flush the cache of each thread. Actual flush can happen as part of this cycle or when the next dispatch discovers that the cache is not valid anymore (depends on what TLS is implementation is chosen). However, the fini/init cycle is costly as it includes unrelated stuff. Do you need an API for doing this? I can add if you can tell me more about your case.

There is an environment variable LIBXSMM_CACHE which can be also set to zero, which effectively disables the cache (without recompilation of LIBXSMM). Otherwise the size is set to the next larger-equal POT number (or the capacity at most). Further, the capacity can be set at compile-time make CACHE=32 (CACHE=0 disables the cache). The default capacity is 16 entries (like CACHE=16).
I am curious about your application and would like to hear more about your case or intention. You can also send a PM (if you prefer). There is also an API to use the code registry (and hence the cache as well) for user-defined data, i.e., code registry can contain user-data.

Hi Kaustubh,
the cache is fully associative, i.e., size is also limited by (completely) searching the cache. Please note, this cache is on a per-thread basis (thread-local). The capacity as well as the size of the cache is always POT in order to optimize some of the operations (like eviction). The size can be smaller than the capacity (see paragraph at the bottom about LIBXSMM_CACHE).

Eviction is not based on additional counters such "least used". Instead, the one entry is evicted that is most distant from the last hit. It is sort of a round-robin/ring buffer policy.
CRC32 is used if permitted by the static architecture (target flag used when LIBXSMM is compiled), i.e., at least SSE4.2 was used. In past implementations, the CRC32-based hash was dispatched dynamically (can be easily reintroduced). However, SW based implementation is fully compatible with the HW implementation and highly/sufficiently tuned, i.e., dynamic dispatch is not used or the dispatch overhead is not worth the effort (at last according to my last check).
A libxsmm_finalize/libxsmm_init cycle could be abused to flush the cache of each thread. Actual flush can happen as part of this cycle or when the next dispatch discovers that the cache is not valid anymore (depends on what TLS is implementation is chosen). However, the fini/init cycle is costly as it includes unrelated stuff. Do you need an API for doing this? I can add if you can tell me more about your case.

There is an environment variable LIBXSMM_CACHE which can be also set to zero, which effectively disables the cache (without recompilation of LIBXSMM). Otherwise the size is set to the next larger-equal POT number (or the capacity at most). Further, the capacity can be set at compile-time make CACHE=32 (CACHE=0 disables the cache). The default capacity is 16 entries (like CACHE=16).
I am curious about your application and would like to hear more about your case or intention. You can also send a PM (if you prefer). There is also an API to use the code registry (and hence the cache as well) for user-defined data, i.e., code registry can contain user-data.

It is perhaps of interest to have a look at the Dispatch Microbenchmark. The results/output of calling ./dispatch.sh is impacted by various settings such as LIBXSMM_CACHE. Please note, some of the timings (like time needed for first-time code gen.) are not only impacted by the CPU but also the OS like security-hardened environments (e.g., SELinux or virtualized environment).

It is perhaps of interest to have a look at the Dispatch Microbenchmark. The results/output of calling ./dispatch.sh is impacted by various settings such as LIBXSMM_CACHE. Please note, some of the timings (like time needed for first-time code gen.) are not only impacted by the CPU but also the OS like security-hardened environments (e.g., SELinux or virtualized environment).

The microbenchmark also allows to schedule a more limited set of kernels (by default it builds 10k kernels):
./dispatch.sh 8 4 1 4000000

The above only deals with 8 kernels (hence 1st time code-gen time is not a stable measurement), and it repeats 4000000 times exercising the cache hierarchy. In any case the microbenchmark reports the time fetching a kernel from cache as dispatch (ro/cached), whereas dispatch (ro) is a cold-read going into the entire registry (no from cache). The category called code-gen (rw) reports the time needed to generate the code for the first time. The signs like ro and rw are with respect to accessing code registry under multiple threads (locking tries to permit multiple readers and a single writer).

The microbenchmark also allows to schedule a more limited set of kernels (by default it builds 10k kernels):
./dispatch.sh 8 4 1 4000000

The above only deals with 8 kernels (hence 1st time code-gen time is not a stable measurement), and it repeats 4000000 times exercising the cache hierarchy. In any case the microbenchmark reports the time fetching a kernel from cache as dispatch (ro/cached), whereas dispatch (ro) is a cold-read going into the entire registry (no from cache). The category called code-gen (rw) reports the time needed to generate the code for the first time. The signs like ro and rw are with respect to accessing code registry under multiple threads (locking tries to permit multiple readers and a single writer).

For the record and for reference:

Code Generation: LIBXSMM is a JIT assembler without textual frontend or such, i.e., there is an API to drive code generation. Code generation is very fast when compared to compiler based JIT infrastructure (e.g., LLVM-JIT). LIBXSMM does not have compiler phases and it does not use an Intermediate Representation (IR), i.e., machine code is assembled right away. Code generation takes in the order of 10s of Mikroseconds depending on CPU architecture and clock frequency, OS/environment, kernel parameters, etc.
Registry: LIBXSMM’s JIT-code is persistent for the lifetime of an application (between libxsmm_init/finalize), and not meant to be deallocated. A JIT-code pointer therefore matches the behavior of normal/static functions, which are valid for the lifetime of an application. Such pointer can be copied (“shallow”) and kept around for whatever purpose and called at any time as needed by the application. The registry has an arbitrary capacity (e.g., 132k entries); it could be dynamically sized with little effort (the fixed size never posed a problem so far). A cold registry access takes in the order of 100 Nanoseconds.
Cache: The cache is purely meant to accelerate the access to our registry. Evicting an entry from that cache does not mean the kernel is invalidated or deallocated. However, if you query that kernel again, it will take longer as the code registry is accessed ("cold access") rather than the thread-local cache ("hot access"). Beside of accelerating accesses, the cache is meant to be effective for application that use a limited set of kernels repeatedly. Our custom (user-)data registration can improve further if one registers a set of kernels that are always used together, then a single (cached) access occurs for multiple kernels which amortizes more favorable. A cache access (warm registry access) takes in the order of 10s of Nanoseconds.
Kernel: The kernel is like a normal function pointer and cannot be inlined by the compiler (a call instruction is always necessary). The code size is typically not an issue, in fact our code is not unrolled to the maximum since we expect to partially operate on DRAM based operands/data, which makes it irrelevant if fully unrolled or not (note, if the same kernel is executed in a hot loop with same input, additional unrolling gives a false sense of better performance – or the other way said: who wants to compute the same result for the same input multiple times and consecutively?). Code size is hardly a problem (also with respect to the instruction cache of the CPU) although LIBXSMM wastes some memory since only multiples of full memory pages are allocated per each kernel. However, 4K pages are hinted for that purpose. Memory consumption can is shown using LIBXSMM_VERBOSE=.
Introspection: LIBXSMM implements code introspection in the sense of receiving the input that was leading to the code of a kernel (libxsmm_get_kernel_info, libxsmm_get_mmkernel_info [and for other kinds than just matrix multiplications “MM”, and also libxsmm_get_registry_info in general for the registry as a whole). Kernel information is inexpensive, i.e., can be received without searching the registry by providing the function pointer (kernel) as an input.

Further details: there is an API to deallocate a kernel but unless the library is compiled in a special fashion, the related function is not effective (it does nothing unless the registered kernel-kind is “user data”). There is no application deployed that expects or needs to deallocate a kernel. Also, deallocation would be API based and explicit and not like an automatic eviction. It is more user-friendly to keep all code around that was ever triggered during an application’s lifetime.


Not classifying the species belonging the genus Euphausia and Thysanoessa as zooplankton

@FIN-JBarile @QQ-Sortiz
Could we please stop classifying the species belonging to the genus Euphausia and Thysanoessa as zooplankton? The rationale for this is that several OSMOSE applications represent Euphausiids as focal functional groups.  Many thanks!

@FIN-JBarile @QQ-Sortiz
Please do not implement this; I am going to close the present issue and open a new one to explain what we should do instead. Many thanks!


adding windows service example alerts/queries

Just contributing some useful examples that I have made using for monitoring Microsoft SQL Server instances.

Thanks a lot @chrisbloemker!
Just out of curiousity, you seem to have a non-standard labeling scheme with regards to setting the name label everywhere?

Ahh, yes.. the way we have Prometheus setup for our ec2 scraping is the instance id is relabeled as instance, leaving the tag "Name" to be relabeled as name I can change the PR to reflect the examples to be more standardized if you'd like.

Yes, I think that would be good, probably less confusing that way. Thanks!

Done :)

Thanks!


Call in progress

Is it possible to know when a voice call is in progress? Sometimes i have to switch back manually to 4g beucase the router stays to 3g after a voice call, and i would like to build an automa.
Thanks

Hi @cagnulein - I had as look through what is available.
It looks like there may be an api call that can help:
api/voice/voicebusy

It looks like the response is:
<response>Idle</response>

or
<response>Busy</response>

Can you try that and see if it works?

Yes, it works flawless! Thanks man!


ASP.NET Core 2.1 Preview 2 - Razor Assembly Info Generation Issue

@rynowak @pranavkm, Setting
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
in the csproj file prevents Razor assembly info generation (affecting app.dll and app.Views.dll) and such MVC apps throw (see below) when deployed to production servers because views are not found.

Now listening on: http://<IP_ADDRESS>:28447
Application started. Press Ctrl+C to shut down.
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://example.com/
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Route matched with {action = "Index", controller = "Home"}. Executing action SimpleMvcApp.Controllers.HomeController.Index (SimpleMvcApp)
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Executing action method SimpleMvcApp.Controllers.HomeController.Index (SimpleMvcApp) - Validation state: Valid
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action method SimpleMvcApp.Controllers.HomeController.Index (SimpleMvcApp), returned result Microsoft.AspNetCore.Mvc.ViewResult in 0.0237ms.
info: Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor[1]
      Executing ViewResult, running view Index.
fail: Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor[3]
      The view 'Index' was not found. Searched locations: /Views/Home/Index.cshtml, /Views/Shared/Index.cshtml
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action SimpleMvcApp.Controllers.HomeController.Index (SimpleMvcApp) in 0.4997ms
fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HLCVQKE7G6Q7", Request id "0HLCVQKE7G6Q7:00000002": An unhandled exception was thrown by the application.
System.InvalidOperationException: The view 'Index' was not found. The following locations were searched:
/Views/Home/Index.cshtml
/Views/Shared/Index.cshtml
   at Microsoft.AspNetCore.Mvc.ViewEngines.ViewEngineResult.EnsureSuccessful(IEnumerable`1 originalLocations)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.ExecuteAsync(ActionContext context, ViewResult result)
   at Microsoft.AspNetCore.Mvc.ViewResult.ExecuteResultAsync(ActionContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeResultAsync(IActionResult result)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResultFilterAsync[TFilter,TFilterAsync]()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResultExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.ResultNext[TFilter,TFilterAsync](State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeResultFilters()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
   at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Server.IISIntegration.IISMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
      Request finished in 5.1816ms 500

This happens because SimpleMvcApp.dll is missing

[assembly: RelatedAssembly("SimpleMvcApp.Views")]
[assembly: RazorLanguageVersion("2.1")]
[assembly: RazorConfigurationName("MVC-2.1")]
[assembly: RazorExtensionAssemblyName("MVC-2.1", "Microsoft.AspNetCore.Mvc.Razor.Extensions")]

(workaround: add above assembly attributes manually)
and SimpleMvcApp.Views.dll is missing
[assembly: ProvideApplicationPartFactory("Microsoft.AspNetCore.Mvc.ApplicationParts.CompiledRazorAssemblyApplicationPartFactory, Microsoft.AspNetCore.Mvc.Razor")]
(workaround: add <GenerateRazorTargetAssemblyInfo>true</GenerateRazorTargetAssemblyInfo> to the csproj file).
Dev Machine Setup:
Visual Studio 2017 15.7 Preview 3
dotnet-sdk-2.1.300-preview2-008530-win-x64
Hosting Server Setup:
Windows Server 2012 R2
dotnet-hosting-2.1.0-preview2-final-win
Steps to reproduce:

Create default MVC 2.1 project.
Add <GenerateAssemblyInfo>false</GenerateAssemblyInfo> to csproj file.
Add custom 'assemblyinfo.cs' with some assembly attributes.
Publish to server, enable logging, and browse the site.

@mkArtakMSFT , This is required to share assembly info from a single location during build.


🔧 Move to sphinx-extensions2

Codecov Report
Patch and project coverage have no change.

Comparison is base (207e51b) 90.10% compared to head (1273a9a) 90.10%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   90.10%   90.10%
=======================================
  Files          11       11
  Lines         940      940
=======================================
  Hits          847      847
  Misses         93       93

Flag
Coverage Δ

pytests
90.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


update packages

:white_check_mark: Build TheIdServer 7.4.1-fix-dependencies1-0006 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/61864c3025 by @invalid-email-address)


Injectable StandardScripts

Sets a base for future work allowing STRAT / BTC / sidechains to have different standards
Possible value for ColdStaking too, rather than use of static registry

@codingupastorm sending_from_one_address_to_fifty_addresses is failing, but it's unclear if it's because of this PR. Looking at the test logs locally the transaction goes into the mempool as an orphan (inputs not found yet), but then it never gets put into the wallet on the destination node.

@zeptin it's failing in master for me locally too atm, maybe a recent PR messed with it?


Grabber does not automatically retry the download when there is an error in the download

How to set up disconnection and reconnection?
Due to network fluctuations, once the network cannot be connected within 1s, Grabber will appear [Error] and skip a lot of pictures that need to be downloaded.
How to set the number of reconnection times for image download? To automatically retry the download if there is a problem with the image download?
————————————————————————————————
[08:25:42.160][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:42.171][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:42.181][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:42.192][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:42.204][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:42.217][Warning] [Qt][qt.network.monitor] Could not get the INetworkConnection instance for the adapter GUID.
[08:25:43.252][Error] Loading details error for 'https://yande.re/post/show/1008934': SSL handshake failed
[08:25:43.253][Error] Loading details error for 'https://yande.re/post/show/1008926': SSL handshake failed
[08:25:43.253][Error] Loading details error for 'https://yande.re/post/show/1008879': SSL handshake failed
[08:25:43.254][Error] Loading details error for 'https://yande.re/post/show/1008875': SSL handshake failed
[08:25:43.254][Error] Loading details error for 'https://yande.re/post/show/1008864': SSL handshake failed
[08:25:43.255][Error] Loading details error for 'https://yande.re/post/show/1008863': SSL handshake failed
[08:25:43.257][Error] Loading details error for 'https://yande.re/post/show/1008817': SSL handshake failed
[08:25:43.258][Error] Loading details error for 'https://yande.re/post/show/1008796': SSL handshake failed
[08:25:43.258][Error] Loading details error for 'https://yande.re/post/show/1008787': SSL handshake failed
[08:25:43.259][Error] Loading details error for 'https://yande.re/post/show/1008769': SSL handshake failed

————————————————————————
I have tried this option bu it don't work

Hello, dm seve.services on instagram for really good grabber. trust me.


Cupy 4.0.0b4 cannot install on Windows

My environment is Windows10, Python 3.6.1
When I try to install 4.0.0b4 by pip install -e . --no-cache-dir then it fails by an error:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\sakurai\Desktop\cupy\setup.py", line 64, in <module>
        ext_modules = cupy_setup_build.get_ext_modules()
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 547, in get_ext_modules
        extensions = make_extensions(arg_options, compiler, use_cython)
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 402, in make_extensions
        rpath.append('{}{}/_lib'.format(_rpath_base(), '/..' * depth))
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 330, in _rpath_base
        raise Exception('not supported on this platform')
    Exception: not supported on this platform

I modified the code
from https://github.com/cupy/cupy/blob/v4.0.0b4/cupy_setup_build.py#L399
            if use_wheel_libs_rpath:

to
            if use_wheel_libs_rpath and sys.platform != 'win32':

then I can install successfully. But I'm not sure this is appropriate or not.
Full error log
C:\Users\sakurai\Desktop\cupy>git status
HEAD detached at v4.0.0b4
nothing to commit, working directory clean

C:\Users\sakurai\Desktop\cupy>pip install -e . --no-cache-dir
Obtaining file:///C:/Users/sakurai/Desktop/cupy
    Complete output from command python setup.py egg_info:
    Options: {'package_name': 'cupy', 'long_description': None, 'wheel_libs': [], 'profile': False, 'linetrace': False, 'annotate': False, 'no_cuda': False}

    -------- Configuring Module: cuda --------
    a.cpp
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\cuda_runtime.h: warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\cuda_runtime.h: warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code

    -------- Configuring Module: cudnn --------
    a.cpp
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\cuda_runtime.h: warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code
    a.cpp
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\cuda_runtime.h: warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    c:\program files\nvidia gpu computing toolkit\cuda\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    Generating code
    Finished generating code

    -------- Configuring Module: nccl --------
    a.cpp
    C:\Users\sakurai\AppData\Local\Temp\tmpaxqifyf4\a.cpp(1): fatal error C1083: Cannot open include file: 'nccl.h': No such file or directory
    command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\x86_amd64\\cl.exe' failed with exit status 2

    -------- Configuring Module: cusolver --------
    a.cpp
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code

    -------- Configuring Module: thrust --------
    a.cpp
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\cuda_runtime_api.h(1950): warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss
    C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\include\thrust/system/detail/error_category.inl(102): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
    C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt\string.h(178): note: see declaration of 'strerror'
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code
    a.cpp
    Generating code
    Finished generating code

    ************************************************************
    * CuPy Configuration Summary                               *
    ************************************************************

    Build Environment:
      Include directories: ['C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v9.0\\include', 'C:\\Program Files\\NVIDIA Corporation\\NvToolsExt\\include']
      Library directories: ['C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v9.0\\bin', 'C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v9.0\\lib\\x64', 'C:\\Program Files\\NVIDIA Corporation\\NvToolsExt\\lib\\x64']
      nvcc command       : ['C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v9.0\\bin/nvcc.exe']

    Environment Variables:
      CFLAGS          : (none)
      LDFLAGS         : (none)
      LIBRARY_PATH    : (none)
      CUDA_PATH       : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0
      NVCC            : (none)

    Modules:
      cuda      : Yes (version 9.0.0)
      cudnn     : Yes (version 7.0.3)
      nccl      : No
        -> Include files not found: ['nccl.h']
        -> Check your CFLAGS environment variable.
      cusolver  : Yes
      thrust    : Yes

    WARNING: Some modules could not be configured.
    CuPy will be installed without these modules.
    Please refer to the Installation Guide for details:
    https://docs-cupy.chainer.org/en/stable/install.html

    ************************************************************

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\sakurai\Desktop\cupy\setup.py", line 64, in <module>
        ext_modules = cupy_setup_build.get_ext_modules()
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 547, in get_ext_modules
        extensions = make_extensions(arg_options, compiler, use_cython)
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 402, in make_extensions
        rpath.append('{}{}/_lib'.format(_rpath_base(), '/..' * depth))
      File "C:\Users\sakurai\Desktop\cupy\cupy_setup_build.py", line 330, in _rpath_base
        raise Exception('not supported on this platform')
    Exception: not supported on this platform

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\sakurai\Desktop\cupy\

Related to #899

Thank you very much for reporting, we're preparing a fix in #980.


DMRG optimization different backends (including symmetric) in examples

depends on #866, #865

Codecov Report

Merging #867 into master will decrease coverage by 0.02%.
The diff coverage is 93.57%.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   98.21%   98.18%   -0.03%
==========================================
  Files         129      129
  Lines       22311    22391      +80
==========================================
+ Hits        21913    21985      +72
- Misses        398      406       +8

Impacted Files
Coverage Δ

examples/simple_mera/simple_mera.py
95.61% <ø> (ø)

tensornetwork/backends/abstract_backend.py
91.77% <0.00%> (-0.54%)
:arrow_down:

tensornetwork/block_sparse/blocksparse_utils.py
97.88% <ø> (ø)

tensornetwork/matrixproductstates/base_mps_test.py
99.71% <ø> (ø)

tensornetwork/block_sparse/blocksparsetensor.py
98.74% <66.66%> (-1.01%)
:arrow_down:

tensornetwork/matrixproductstates/dmrg.py
97.41% <94.11%> (-1.23%)
:arrow_down:

tensornetwork/__init__.py
100.00% <100.00%> (ø)

tensornetwork/backends/jax/jax_backend.py
98.85% <100.00%> (+<0.01%)
:arrow_up:

tensornetwork/backends/jax/jax_backend_test.py
99.26% <100.00%> (+<0.01%)
:arrow_up:

tensornetwork/backends/numpy/numpy_backend.py
98.03% <100.00%> (+0.01%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a367602...62b7a8b. Read the comment docs.

Hmm, let me fix that
Adam Lewis<EMAIL_ADDRESS>schrieb am Mi. 2. Dez. 2020 um 16:33:

@alewis approved this pull request.
In .github/workflows/ci-build.yml
https://github.com/google/TensorNetwork/pull/867#discussion_r534260455:

@@ -0,0 +1,36 @@
+# This workflow will install Python dependencies, run tests and lint with a variety of Python versions

What's this about?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/TensorNetwork/pull/867#pullrequestreview-542957563,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE7RWE6IOG2SGEJHHTH3JXTSSZM5RANCNFSM4TE44BOA
.


Change the color scheme of the steep streets layer. #82

Before:

I personally can't really see the steep roads easily with this; the red gradient isn't easy to distinguish.
Now:

This uses the buckets and color scheme from https://github.com/ITSLeeds/slopes.
I considered the 0-3% bucket, but it just adds noise in my opinion. Not coloring the flat roads at all seems nicer. This is the alternative, though:

We happen to get lucky here and the colors work well in night mode too:

CC @Robinlovelace, @eldang, @muzlee1113

👍 I think it makes sense to actively color flat routes as "good", as opposed to inferring "good" by a lack of a color.

I do find the red-yellow-green much clearer than the continuous colour scheme.  How distinguishable are these colours for a colour-blind user?

I do find the red-yellow-green much clearer than the continuous colour scheme. How distinguishable are these colours for a colour-blind user?

Anecdotally, as a moderate deuteranopiad (red-green), looking at the screenshot I only easily distinguished two classifications from the layer.
I had to pull out the digital color meter to differentiate these two:

I think it makes sense to actively color flat routes as "good", as opposed to inferring "good" by a lack of a color.

The issue here is maybe the grey fade we apply to the map when showing layers. This dark green really fades in. I think including it for now is fine; we can keep iterating on the particular colors.

How distinguishable are these colours for a colour-blind user?

There are some recommended color scales out there we could find, and see how they work in day/night mode. Do you reckon this PR is an improvement over the previous red gradient? If so, I'd vote for iterating in the future. We have so many colors to try to align...

Do you reckon this PR is an improvement over the previous red gradient? If so, I'd vote for iterating in the future. We have so many colors to try to align...

I think it's already an improvement and would be happy to see it merged as is.
For future improvement, I think having less color buckets would help - or having a continuous gradient without trying to  discretize "meaningful" buckets.

Looking amazing! Heads-up @temospena your colourscheme is going into production in A/B Street by the looks of it :tada: can't wait to try this out. Broader point: Rust could be a possible back-end for the slopes package one day...


saved presentation to doc and updated charts

saved the presentation in pdf format and the updated charts to the doc directory

Can you change the name of the purple one to chart.png? That way it will replace the existing diagram.

Also is the structure figure going anywhere else (like in a README)? Otherwise I think it might be fine to skip since it's already in the presentation

Thank you

I renamed the design chart to chart.png

Awesome, looks good to me!


[Bug]: Cassette WAV incorrect content

Contact Details
<EMAIL_ADDRESS>What happened?
Cassette WAV doesn't contain header or trailer bytes as noticed by Ben Zotto:
Snip from email 1/22/2023:

One thing about the toolchain you're using-- I think I probably was confusing before about this while trying to make an unnecessarily pedantic distinction!-- you do need to make sure the tape header ($16 $16 $16 ... ) and trailer ($17 ... checksum) bytes make their way into the cassette audio, and it didn't seem like they're there in the generated WAV file you have posted on GitHub. The web emulator is just running the real serial  firmware which is why my ".cassette" files also have the header/trailer as part of them. It's probably redundant to what you're already doing but on the command line when I need to "wrap" a program binary in a cassette format, I use a trivial tool for it, it's uploaded [here](https://github.com/bzotto/bin2sphere/)

Version
1.1.0
What platforms are you seeing the problem on?
Virtual Sphere, SPHERE-1 hardware
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Also raised in CONVERT repo as Issue#1

This can now be closed as the toolchain has been updated to correct the issue.


Support for Mapper Annotated Text Plugin

In order to support entity enrichment coming from our NLP engine, we would like to use the Mapper Annotated Text plugin.
https://www.elastic.co/guide/en/elasticsearch/plugins/7.10/mapper-annotated-text-usage.html
Thank you
Gidon

Hi @gjunge,
Sorry for the delayed response. Would you please post this request to this forum: https://discuss.opendistrocommunity.dev/c/general-elasticsearch/10
Thanks,
Jon


batch inference is different with single

System Info
x85-64
4 A10
0.9.0
Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction
A private model of type llama2, when using the same input batch inference, such as batch_size=4, yields four different answers. （topk=0,topp=0,run.py）
Expected behavior
four answers should be the same
actual behavior
yields four different answers.
additional notes

i have disable custom_all_reduce when build engine

Hi @1096125073 , since different batch sizes may lead to different kernels. So, the results can be different. This is a known issue.

Hi @1096125073 , since different batch sizes may lead to different kernels. So, the results can be different. This is a known issue.

Thank you for your answer! I'm sorry, I think it might be because I didn't express myself clearly. When I infer that the batch is 4, the input to the batch is the same, but the four outputs I get are different.

@1096125073 Yes, I get your point:  repeat the same input prompt 4 times, and make it a batch, but the outputs are different from batch size 1.  Unfortunately, it's a known issue.
BTW, do you observe the similar phenomenon in PyTorch?

b

@1096125073 Yes, I get your point: repeat the same input prompt 4 times, and make it a batch, but the outputs are different from batch size 1. Unfortunately, it's a known issue.
BTW, do you observe the similar phenomenon in PyTorch?
Sorry, I said these four outputs are different from each other, just like the picture above.

@1096125073 Yes, I get your point: repeat the same input prompt 4 times, and make it a batch, but the outputs are different from batch size 1. Unfortunately, it's a known issue.
BTW, do you observe the similar phenomenon in PyTorch?

Sorry, I said these four outputs are different from each other, just like the picture above.

Hi @1096125073 , I tried the llama2 model:
python convert_checkpoint.py --model_dir=/llm-models/llama-models-v2/llama-v2-7b-hf/ --output_dir=./ckpt --dtype bfloat16

trtllm-build --checkpoint_dir=./ckpt --output_dir=./engine --gemm_plugin bfloat16 --max_output_len=256 --max_batch_size=4

python ../run.py --engine_dir=./engine --max_output_len=10 --tokenizer_dir /llm-models/llama-models-v2/llama-v2-7b-hf/  --input_text 'How are you' 'How are you' 'How are you' 'How are you'

Here is the result:
Input [Text 0]: "<s> How are you"
Output [Text 0 Beam 0]: "doing? I hope you are doing well. I"
Input [Text 1]: "<s> How are you"
Output [Text 1 Beam 0]: "doing? I hope you are doing well. I"
Input [Text 2]: "<s> How are you"
Output [Text 2 Beam 0]: "doing? I hope you are doing well. I"
Input [Text 3]: "<s> How are you"
Output [Text 3 Beam 0]: "doing? I hope you are doing well. I"

@1096125073 Could you please try the main branch? It seems you are using 0.9.0 version.

@1096125073 Do you use multiple GPUs? If you use multi-GPU, you can use NCCL_ALGO=Tree to ensure stable reduce order. NCCL usually select Ring algo, which has unstable reduce order, which causes different results in the same batch. If you use single GPU, then it should be other issue.

@QiJune I encountered the same issue with the T5 model (float16). The inference results vary slightly with different batch sizes during extensive sample testing. Is this a normal phenomenon? I saw a similar issue in one of the issues on this page: https://github.com/dmlc/gluon-nlp/issues/1344.

@1096125073 Do you use multiple GPUs? If you use multi-GPU, you can use NCCL_ALGO=Tree to ensure stable reduce order. NCCL usually select Ring algo, which has unstable reduce order, which causes different results in the same batch. If you use single GPU, then it should be other issue.

Yes，this is the answer i want，thanks

@QiJune
I'm experiencing issues even when using single GPU. If the discrepancies in results are due to varying kernel choices, is there a way to sacrifice some performance in exchange for more stability?


Build error on quire build since WebComponent additions

Before proceeding, make sure there isn’t an existing issue for this bug.

[X] I have searched the existing issues and determined this is a new bug.

Expected Behavior
After starting a new project with quire-cli@latest and quire-11ty@latest, using quire-starter-default@latest, I expect quire build to produce no errors.
Actual Behavior
A fresh project with<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>produces this error after figures processing:
[quire] INFO	 Figures:IIIF:Manifest          Generated manifest for figure "mother-annotations"
[quire] INFO	 Figures                        Processing complete
ERROR Error: Check the dynamic attribute: `@html="component(id, image_dir)"`.
Original error message: caption is not defined
    at ModuleScript.evaluateScript (/Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/moduleScript.cjs:71:10)
    at async AstSerializer.evaluateAttribute (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:787:21)
    at async AstSerializer.getPropContentAst (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:820:17)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1152:25)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)

Steps to Reproduce

Install quire CLI according to install instructions
Start a new project
Run quire build in the new project

Version Numbers
[CLI] Command 'info' called with options { debug: true }
[test-pub]
quire-cli 1.0.0-rc.11
quire-11ty 1.0.0-rc.17
starter<EMAIL_ADDRESS>[System]
quire-cli 1.0.0-rc.11
node v21.6.2
npm 6.14.18
os Darwin 23.3.0
Web Browser
No response
Relevant Terminal/Shell Output
No response
Supporting Information
No response

Meant to say -- AFAICT the build succeeds regardless in terms site-build contents and return code (which is also a little troubling tbh, it should stop the world and return not-0 I think?).

@cbutcosk I just wanted to touch base. I just tested this issue and could not recreate it. Everything looks to be processing just fine. OK for me to close?
[next-project]
quire-cli 1.0.0-rc.11
quire-11ty 1.0.0-rc.17
starter<EMAIL_ADDRESS>[System]
quire-cli 1.0.0-rc.11
node v18.17.0
npm 9.6.7
os Darwin 21.6.0

Oh yes happy to say this can be closed @Erin-Cecele !

Thank you @cbutcosk!!


Params + Results with nil Properties treated differently than Params + Results with empty Properties

Expected Behavior
Our API doesn't differentiate between a map being nil and a map being empty.
The following two Task result definitions should be equivalent:
results:
  - name: my-result

results:
  - name: my-result
    properties: {}

Note: this is unrelated to the result values outputted by the TaskRun.
From the Go style guide: "Do not create APIs that force their clients to make distinctions between nil and the empty slice." (There's no equivalent guidance for maps but it seems like it should be the same?)
If we do want to differentiate this behavior we should at least make sure to document it clearly. I'm not sure why someone would want to declare an object param/result with no properties; it doesn't seem very meaningful.
Fixed in https://github.com/tektoncd/pipeline/pull/6570 and https://github.com/tektoncd/pipeline/pull/6578.
Actual Behavior
nil Properties -> defaults to string param/result:
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: nil-properties
spec:
  results:
    - name: object-results
  steps:
  - image: bash
    script: |
      echo -n "{\"IMAGE_URL\":\"ar.com\", \"IMAGE_DIGEST\":\"sha234\"}" > $(results.object-results.path)

$ k get task nil-properties -o yaml
...
spec:
  results:
  - name: object-results
    type: string
...

empty Properties -> defaults to object param/result
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: empty-properties
spec:
  results:
    - name: object-results
      properties: {}
  steps:
  - image: bash
    script: |
      echo -n "{\"IMAGE_URL\":\"ar.com\", \"IMAGE_DIGEST\":\"sha234\"}" > $(results.object-results.path)

$ k create -f ~/tkndefs/properties/nil-properties.yaml
Error from server (BadRequest): error when creating "/Users/leebernick/tkndefs/properties/nil-properties.yaml": admission webhook "validation.webhook.pipeline.tekton.dev" denied the request: validation failed: missing field(s): spec.results[0].object-results.properties

Suggesting this can be closed. Thanks @lbernick


Rename --test-shards CLI flag to --max-test-shards

Add --smart-flank-gcs-path CLI flag
Fix #540

Codecov Report

Merging #541 into master will increase coverage by 0.11%.
The diff coverage is 93.93%.

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
+ Coverage     79.56%   79.67%   +0.11%
  Complexity      563      563
============================================
  Files            77       77
  Lines          2109     2111       +2
  Branches        276      276
============================================
+ Hits           1678     1682       +4
+ Misses          267      265       -2
  Partials        164      164


Refactoring google analytics sample

pep-8 compliance
break logic into smaller functions

Nice one Marius, it looks much cleaner now