[WIP] TRT-292: Add disruption test documentation

Signed-off-by: ehila<EMAIL_ADDRESS>

/cc @DennisPeriquet @neisw

@neisw I'm okay with changing it up any way you guys see fit. If it'll make things easier I don't mind forking off of that PR so we can publish it all at the same time when we feel we've covered it well.

@eggfoobar, if it isn't too much trouble let's do that.  Feel free to supersede anything I have and / or add modify the sections.  Appreciate the help on this.

@neisw If we're good with that, I created the PR with this information, closing it for now https://github.com/neisw/ci-docs/pull/2


CORTX-28823:Hare and IO Svcs didn't restart after restart of Pod

Problem:
If the pod is taken down and up again (upgrade use case), then
the upgraded pod services do not start. The node health status
remains to be critical, as the consul agent doesnt leave upon
taking pod down, as it gets conflicts of duplicate node.
Solution:
Update consul client configuration json file with
leave_on_termination configuration.
Signed-off-by: Suvrat Joshi<EMAIL_ADDRESS>

@suvratjoshi, consider the following commit message,
[CORTX-28823: consul client agent status is not updated

Problem:

If a consul client agent, started with hax process, is shutdown abruptly
and restarted within 7-10 seconds, consul is not able to detect the failure
and thus, does not evict the failed agent. Additionally, if the corresponding
node, when restarted, get maintains the same name but different ip address,
consul thinks its the same agent but since the corresponding ip address
saved is different from the newly assigned ipaddress, consul is not able to
communicate with the restarted client agent.

Solution:

Consul client agent must be configured with `leave_on_terminate` set to `true`.
This allows Consul to gracefully evict the consul agent whenever the agent
shuts down, thus updating its status in consul quorum.

@suvratjoshi  @mssawant can we merge it now?


Add Storyteller and PayPal for Kelly

Might as well add myself and add more options for copleykj.

How can I say no to a fellow Meteor Developer? :sweat_smile: Thank you, @StorytellerCZ !

I was so excited, I forgot to properly review the PR. :smile:

:laughing: :tada:

Your welcome! :smile:


New confirm popup

https://github.com/YU000jp/logseq-plugin-confirmation-done-task/commit/dcb93c7545970581611aa122826ad9c58cc52eca


[kwokctl] Integrate metrics-server

What would you like to be added?
TODO
Based on #199
Why is this needed?
https://kubernetes.io/docs/tasks/debug/debug-cluster/resource-metrics-pipeline/
https://github.com/kubernetes-sigs/metrics-server
https://github.com/kubernetes/autoscaler
Easy to test metric-related components

HPA
VPA
kubectl top

/assign

/unassign

/assign


Plugin test-cases immigrate plan

This issue is intended to track to immigrate every plugin test-cases back main repo. The plugin test development guide doc is https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md
working list
done list

[x] httpclient-4.3.x-scenario
[x] gateway-scenario
[x] dubbo-scenario
[x] solrj-scenario
[x] spring-async-scenario
[x] spring-scenario
[x] jetty-scenario
[x] kafka-scenario
[x] canal-scenario
[x] postgresql-scenario
[x] sofarpc-scenario
[x] mongodb-3.x-scenario
[x] elasticsearch-5.x-scenario
[x] undertow-routing-scenario
[x] undertow-scenario
[x] apm-toolkit-trace-scenario
[x] dubbox-scenario. Dubbox has been merged into Dubbo officially, the test case is not required.
[x] httpasyncclient-scenario
[x] webflux-scenario
[x] customize-scenario
[x] redisson-scenario
[x] jedis-scenario
[x] jdk-cross-thread-scenario This test has been included in apm-toolkit-trace-scenario.
[x] feign-scenario
[x] rabbitmq-scenario
[x] grpc-scenario
[x] hystrix-scenario
[x] okhttp-scenario
[x] mysql-scenario
[x] gson-scenario
[x] pulsar-scenario
[x] oracle-scenario
[x] jdk-http-scenario
[x] cassandra-java-driver-3.x-scenario
[x] lettuce-scenario
[x] servicecomb-0.x-scenario
[x] zookeeper-scenario
[x] shardingsphere-scenario
[x] play-scenario
[x] activemq-scenario
[x] h2-struts-scenario

todo list

[ ] header-scenario
[ ] light4j-1.6.x-scenario
[ ] motan-scenario
[ ] resteasy-scenario
[ ] rocketMQ-scenario
[ ] spring-with-qualified-op-name-scenario
[ ] spring-with-request-method-op-name-scenario
[ ] vertx-eventbus-3.x-scenario
[ ] vertx-web-3.x-scenario

I want to be part of it

HttpClient #3579

I want to be part of it

Welcome! :)

I will immigrate dubbo, ok?

I want to be part of it

@arugal You should know, where are the test cases now, right? We are moving all of them(700+ cases) into the main repo. Huge work to do, definitely need many people's help.
This https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/httpclient-4.3.x-scenario is you should focus on. It is very similar to old test cases and supported by latest test framework. You could ping me on QQ/WeChat, if you need more help.

I will immigrate spring scenario and spring async scenario

@dmsolr The old repo is read-only today. We will encourage all test cases moving into here by following your framework and review.
https://github.com/SkyAPMTest/agent-auto-integration-testcases

I will immigrate kafka scenario

I will immigrate canal scenario

I will immigrate canal scenario

Please update the supported-list to add canal(we missed that) at the first level.

I will immigrate canal scenario

Please update the supported-list to add canal(we missed that) at the first level.
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md here?

I will immigrate sofarpc scenario

324 cases have been moved. Thanks for everyone's help.

I will immigrate elasticsearch-5.x-scenario

I will immigrate elasticsearch-5.x-scenario

For elasticsearch client, I could 6.x and 7.x could be tested, if not supported, I hope it could be contributed/added. @aderm

l will immigreate undertow scenario and test whether to support undertow1.x .

If it is, please update the supported-list.md document.

I will immigrate elasticsearch-5.x-scenario

For elasticsearch client, I could 6.x and 7.x could be tested, if not supported, I hope it could be contributed/added. @aderm

ok, it's my pleasure.

I will immigreate apm-toolkit-trace-scenario

@arugal Got it, the case status is just updated.

I will immigrate elasticsearch-5.x-scenario

For elasticsearch client, I could 6.x and 7.x could be tested, if not supported, I hope it could be contributed/added. @aderm

ok, it's my pleasure. @wu-sheng

@wu-sheng Next, I want to extend es-6.x-plugin，becuause transport is not recommend by elastic official, i will think out http rest client.

Make sense to me. I think we could provide a separated 6.x or 7.x plugin.

OK

@wu-sheng i will immigrate httpasyncclient-scenario

shardingsphere-scenario for me

customize-scenario for me

webflux-scenario for me

redisson-scenario for me

jedis scenario for me

zookeeper-scenario & lettuce-scenario for me

jdk-cross-thread-scenario for me

@tomlikeyou  Welcome to contribute.

jdk-cross-thread-scenario for me

apm-toolkit -trace-scenario has covered TraceCrossThread, so we can give up immigreate jdk-cross-thread-scenario.

@arugal You should update the progress, and add the comment like dubbox plugon test.

@arugal You should update the progress, and add the comment like dubbox plugon test.

grpc scenario for me

feign-scenario for me

hystrix-scenario for me

jdk-http-scenario for me

oracle-scenario for me

cassandra-java-driver-3.x-scenario for me.

servicecomb-0.x-scenario for me

zookeeper-scenario & lettuce-scenario for me

@zhaoyuguang Are you still working on this? One month passed, what is your ETA?

zookeeper-scenario & lettuce-scenario for me

@zhaoyuguang Are you still working on this? One month passed, what is your ETA?

I will start work next week

shardingsphere-3.x-scenario for me.

@aiyanbo Could you follow this and move play plugin test(https://github.com/SkyAPMTest/agent-auto-integration-testcases/tree/master/play-scenario) into the main repo PR process?

@aiyanbo Could you follow this and move play plugin test(https://github.com/SkyAPMTest/agent-auto-integration-testcases/tree/master/play-scenario) into the main repo PR process?

OK

shardingsphere-4.x-RC1-RC2-scenario for me.

activemq-scenario for me.

h2-struts-scenario for me

@BFergerson This issue should be updated about the plugin immigration status.

@wu-sheng, I can't edit the top comment. You can mark off both of these though
vertx-eventbus-3.x-scenario
vertx-web-3.x-scenario

@wu-sheng, I'm able to edit comments now. Updated top comment

I can see you on the reviewer list now.

Close this for now. The new test cases are still welcome. I just feel no point to keep this issue open.


raft: Implement the PreVote RPC described in thesis section 9.6

This prevents disruption when a node that has been partitioned
away rejoins the cluster.
Fixes #6522

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

raft/doc.go, line 260 at r1 (raw file):

	follower.

  'MsgPreVote' and 'MsgPreVoteResp' are used in an optional two-phase election

this indent seems to differ from the surrounding.

raft/doc.go, line 262 at r1 (raw file):

  'MsgPreVote' and 'MsgPreVoteResp' are used in an optional two-phase election
  protocol. When Config.PreVote is true, a pre-election is carried out first
  (using the same rules as a regular election, and no node increases its term

unbalanced parenthesis

Comments from Reviewable

FYI I'm working on some more testing for this change. Testing with CockroachDB revealed some problems that aren't covered by the tests here. The root cause is that because MsgPreVote doesn't cause a transition into StateFollower, and stepFollower is the only place where we grant a vote, elections can get stuck when PreVote is enabled. I'm probably going to have to refactor all of the MsgVote and MsgPreVote handling into raft.Step instead of leaving some of it in the per-state step functions.

OK, this is ready for another look @xiang90

@bdarnell I will take a look later this week. Too much stuff in my backlog right now.

Looks great in general. I left some inline comments.

Can someone from pingcap also take a look at this pr? /cc @ngaut @siddontang @hhkbp2

LGTM. Will merge when CI turns green.


Onedrive link has been deleted!

Hi, I'm regretted to say that the original files have lost due to some bug of Onedrive. I'm working on re-arrangement of checkpoints

have a nice work, and could you please provide your weights again, thanks

Hi, the OneDrive link is updated. You can check if it is accessible.

Hi, the OneDrive link is updated. You can check if it is accessible.

This link has already avilable, thanks a lot

You are welcome!


Dagger for GitHub action for Dagger v0.9.3

We'll release this as v5.0.0 , v5
https://docs.github.com/en/actions/creating-actions/about-custom-actions
Works as expected here:
https://github.com/jpadams/test-new-action/actions/runs/6859800772/job/18652631258
DX is basic, but pretty good for both dagger run and dagger call.
https://github.com/jpadams/test-new-action/blob/main/.github/workflows/run-and-call.yml#L27-L41
To-do: add tests to this repo #100

I love this as a way to use Zenith.
One important question: can this also used as a wrapper to dagger run in pre-Zenith CLI? And, should it?

Right now it doesn't work for dagger run, but only because it always uses -m.

Should be an easy fix to accommodate dagger run.  Can't think of why we wouldn't want that for now.

Should be an easy fix to accommodate dagger run. Can't think of why we wouldn't want that for now.

Yeah, we need to make sure the UX is smooth, but making this dual usage would be great.

Should be an easy fix to accommodate dagger run. Can't think of why we wouldn't want that for now.

Yeah, we need to make sure the UX is smooth, but making this dual usage would be great.

Pretty good for dagger run and dagger call at this point.
Brings CLI-feel into GHA:
https://github.com/jpadams/test-new-action/blob/main/.github/workflows/run-and-call.yml#L27-L41


Group builds with similar paths together to reduce the output

This caps the total output of builds during deployment so that everything fits into the terminal window.

Codecov Report

Merging #2015 into canary will decrease coverage by 0.45%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           canary   #2015      +/-   ##
=========================================
- Coverage    6.52%   6.06%   -0.46%
=========================================
  Files          90      90
  Lines        4139    4251     +112
=========================================
- Hits          270     258      -12
- Misses       3869    3993     +124

Impacted Files
Coverage Δ

src/util/output/builds.js
0% <0%> (ø)
:arrow_up:

src/util/get-project-name.js
90.9% <0%> (-9.1%)
:arrow_down:

src/util/get-files.js
91.53% <0%> (-8.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae9fa8...e9c1870. Read the comment docs.


Best practices for Revit Addin

Please advise on the proper way to set up a Revit Addin.
For example:

[ ] How to best integrate into the Add-In Ribbon?
[ ] How to distribute the addin? Is there such as a thing as an addin installer, or do we have to make one?
...

How to best integrate into the Add-In Ribbon?

create a new Speckle ribbon tab
in that tab, create relevant sections, such as Settings/Setup, Senders, Receivers, etc. only create a section if multiple buttons are required in that section
each action is an ExternalCommand and is represented in the ribbon with 1 button

How to distribute the addin? Is there such as a thing as an addin installer, or do we have to make one?
There's 2 things required :

.addin manifest file, this describes what the addin does and points it to the entry DLL file, placed in C:\ProgramData\Autodesk\Revit\Addins\2018
.dll as the entry point assembly that gets loaded, typically in same folder as manifest but not a requirement to do so. Any other dlls/dependencies are in the same folder

Depending on permissions to copy data to that folder, an installer might be required.

@fraguada , i can extract a pretty good/clear boilerplate & utils from our current Revit tools for the Ribbon creation and post-build steps so the addin is installed on build

@fraguada I have a good Revit VS template setup for this that I can provide. The Ribbon/icons, etc are registered through the ExternalApplication when Revit starts up. ExternalCommands are fired through the ribbon buttons. It may be good to wireframe out the Speckle-Revit interaction a bit. I use Dockable windows for many of our apps which requires some special setup but I could see them being very useful for Speckle

@radumg really helpful information! At the moment I have this under 'External Tools' in the Add-In ribbon. I didn't get so far as to googling how to make a button yet. Also good to know particularities related to addin distribution.
@archinate That would be very helpful. I just cobbled this together from a few sources on the web. Literally my first Revit addin.

It may be good to wireframe out the Speckle-Revit interaction a bit.

Agreed. You can see how this works in Rhino in the Interop.cs class and in the SpeckleRhinoReceiver.cs / SpeckleRhinoSender.cs. As well as the components in SpeckleView.

I use Dockable windows for many of our apps which requires some special setup but I could see them being very useful for Speckle

100% agree!

At the moment I have this under 'External Tools' in the Add-In ribbon
If no ribbon/panel is specified, all ExternalCommands end up here, good start.

@archinate if you'd like to share the VS template, that would be a good starting point, happy to contribute to it with anything else i might have.
I generally start from Jeremy's VS template before making project-specific ones.
@fraguada - could we get a slightly more digestible list of things that need to happen with the plugin, in chronological order ? I'm getting a bit lost in that Interop.cs.

For anything to start working, #4 has to be started. Interop deals with the communication between the UI and the plugin. I'll do my best to make this clearer in the coming days.

@fraguada I migrated your stuff to a template Revit project. Nothing fancy. We can wireframe the project a bit. The PR is https://github.com/speckleworks/SpeckleRevit/pull/13

@fraguada @archinate @radumg I would love to join in and help on this project


having the  X-axis labels all on the same line

please take a look at this:

how can I move the name of the months all at the bottom and on the same line?
I have tried some solutions but it doesn't work, if I set the rotateLabel it moves them all to the center and on the same line. but I haven't been able to move them down.
<BarChart
            style={{
              flex: 1,
              // paddingBottom: 20,
            }}
            width={290}
            height={90}
            barWidth={10}
            spacing={selectedOption === "year" ? 20 : 10}
            xAxisLabelTextStyle={{
              fontSize: 8,
              fontFamily: "Goga-Bold",
              color: "black",
              marginBottom: -20,
            }}
            yAxisTextStyle={{
              left: 0,
              fontSize: 8,
              color: "#FF6B00",
              fontFamily: "Goga-Bold",
            }}
            stackData={displayOnGraph(data, selectedOption)}
            yAxisThickness={0}
            xAxisThickness={1}
            noOfSections={5}
            rulesThickness={0}
            formatYLabel={(label) => `€${label}`}
          />

Hi @MSaeedNajafi 👋
Thanks for requesting this feature.
I have added 2 new props named autoShiftLabelsForNegativeStacks and labelsDistanceFromXaxis
By default the value of autoShiftLabelsForNegativeStacks is true, if you want all the X-axis labels to be aligned in one single line, you need to set it to false.
Then you can use the prop labelsDistanceFromXaxis to shift the labels vertically up or down (perhaps you want to shift it down).
This feature is available from version 1.4.14 onwards 🎉
Please use the latest version of the library.

Thanks a lot for your help and support.


Graceful fallback for Pub/Sub IAM system tests

When the credentials being used for testing (usually from a service account) are not an owner of the project, test_subscription_iam_policy and test_topic_iam_policy both result in: "403 User not authorized to perform this action".

We could call {topic,subscription}.check_iam_permissions first, and avoid the calls to {topic,subscription}.{get,set}_iam_policy if the owner role is missing.

You'd know better than I. Care to take a stab at it?
Easiest way I can think is to toggle the service account you use from Owner to Editor (and back) when testing locally: https://console.cloud.google.com/permissions/projectpermissions?project={PROJECT}

Turns out we can't use check_iam_permissions because #1687.


The fixed/twoliner secret in the test is causing issues that I cannot reproduce

Summary
In tests/show_test.go, there are tests using a so-called fixed/twoliner which is created as follows:
out, err = ts.runCmd([]string{ts.Binary, "insert", prefix + "fixed/twoliner"}, []byte("and\nmore stuff"))
require.NoError(ts.t, err, "failed to insert password:\n%s", out)

However this secret does not behave like a secret stored in plain format on the disk, nor does it behave as it should when playing around with the safecontent and the mime settings.
This is very strange. (See inline code comment in my PR #1579)

This is actually addressed in #1579 because changing the way insert works also changed the way the tests were setup since they are using insert and as such they are now in Mime format :)


Drop web-features/ prefix from our tags

Instead of tags like web-features/0.6.0 we should have tags like v0.6.0. The tag name shows up in URLs like this one:
https://github.com/web-platform-dx/web-features/releases/download/web-features%2F0.6.0/data.json

I've done this now, URL is nicer:
https://github.com/web-platform-dx/web-features/releases/download/v0.6.0/data.json


GitHub Action Ideation

This issue records ideation of possible GitHub Action developments. Possibly funded by a proposal.

Meeting Issue Action

Search for past Meeting Issues
Identify attendees (assignee)
To determine meeting attendance

Possibly extract from a meeting checkbox list

Close Issue and Record Status Action

An action that closes issues marked as "Done"
An action that marks closed issues as "Done"

Possibly already available on GitHub marketplace


APA 7 - No title when referencing a book or article without author

I have an issue where the title of a source is suppressed when there is no author to the work. If I add a mock author it works as expected. This is the incorrect format that gets rendered now:
In bibliography: (Date). Source.
In text: (year)

This is how I expect it to be formated:
In bibliography: Title. (Date). Source.
In text: (Title, year)

I am using the latest version of typst and this is the entry in the bibliography.yml file:
ethics:
  type: Article
  title: "Good Research Practice"
  date: 2017
  publisher: Swedish Research Council
  url: https://www.vr.se/english/analysis/reports/our-reports/2017-08-31-good-research-practice.html

Here are the official APA guidelines for referencing sources with missing information: https://apastyle.apa.org/style-grammar-guidelines/references/missing-information

I found a good enough workaround for any one that has similar issues. You can just put the title in the author field like this:
ethics:
  type: Article
  author: "Good Research Practice"
  date: 2017
  publisher: Swedish Research Council
  url: https://www.vr.se/english/analysis/reports/our-reports/2017-08-31-good-research-practice.html


Add missing SRCREV updates to v6.1.67-cip12

Updating SRCREV to v6.1.67-cip12 for the standard and RT CIP kernels was missed in the previous kernel update.

Thanks!


Add new team member options

Add reports to, lives in, bio, scopes working at.
Make all new team member information optional.
Improving alignment along the changes.
Fixes: #32 #36 #42

Rebased on master so it should be auto mergeable.

Thanks. I've merged this commit as 8cb9bfdfad9f8820951a0ac63f832317f94da549 because I fixed a small typo in your example config (the markdown link missed the ]).

Thanks for the fast merges. Added another one fixing the alignment. Afterwards I see what I can do with the additional page layouts. Basically 404, single and maybe blog.


Update cspell-zksync.txt

What :computer:

First thing updated with this PR
Second thing updated with this PR
Third thing updated with this PR

Why :hand:

Reason why first thing was added to PR
Reason why second thing was added to PR
Reason why third thing was added to PR

Evidence :camera:
Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes :memo:

Any notes/thoughts that the reviewers should know prior to reviewing the code?

Handled in #1063


Highlight grid not "centralised" like its kind of a few mm away from it

As you can see the grid isnt realy on top of the right grid i mean yes i can still use it but is there a setting to modify the highlight grid location ? like move it a few mm to the top/right/left/bottom
Thank you

Same issue for me, but mine is almost a whole square wrong. Would be nice with a calibration option.

Same issue for me, but mine is almost a whole square wrong. Would be nice with a calibration option.


Integrate ArcGIS data with CAC data

Obtain the full set of data from ArcGis and match records to those we get from the CAC API. The ArcGis data has attributes we'd like to use, e.g. an indication of whether a site is a drive-thru.

The schema is here

Sample code for interacting with it:
require './lib/geoservices'
service = Geoservice::MapService.new(url: "https://services.arcgis.com/8ZpVMShClf8U8dae/ArcGIS/rest/services/TestingLocations_public/FeatureServer")
data = service.query(0)["features"]
puts "First record:"
pp data.first ; true
puts "Number of records: #{data.size}"

The gesoervices gem hasn't been updated in 4 years. If you run the current 0.10 version you'll get

OpenSSL::SSL::SSLError (SSL_connect returned=1 errno=0 state=error: tlsv1 alert protocol version)

I hacked my local version:

lib/geservices/base.rb change line 32 from

http.ssl_version = :TLSv1

to:

http.ssl_version = :TLSv1_2

I forked the repo & made the change. https://github.com/Spark-Bio/geoservices-ruby

Open question: currently we get exactly 2000 records. I'm not sure if this is a max and if the gem / API supports a cursor.

If there's a default query limit, looks like it's enforced server-side. Here's the complete request including params:
irb(main):005:0> data = service.query(0)["features"]
"/8ZpVMShClf8U8dae/ArcGIS/rest/services/TestingLocations_public/FeatureServer/0/query"
{:f=>"json", :where=>"1=1", :outFields=>"*"}

This was overwritten somehow. Reopening (cc @ivanoblomov)


Update Posts “uc-san-diego-pattern-library”

Automatically generated by Netlify CMS

👷 Deploy Preview for benevolent-muffin-215770 processing.

Name
Link

🔨 Latest commit
28a8a06e8eda0adc214d037321246009eecfc608

🔍 Latest deploy log
https://app.netlify.com/sites/benevolent-muffin-215770/deploys/62847b01676acd00082bd209


Add nile-account flag to set Nile artifacts path

This PR proposes to add the nile-account flag to account.declare which will create an overriding_path to Nile's precompiled artifacts. This will remove the need to manually set the path for Account declarations.
Nile account declarations will look like this:
out = await account.declare("Account", nile_account=True)

as opposed to something like:
overriding_path = ("env/lib/python3.9/site-packages/nile/artifacts", "env/lib/python3.9/site-packages/nile/artifacts/abis")

out = await account.declare("Account", overriding_path=overriding_path)

This PR just needs tests.
Resolves #309.

Hi Andrew! This approach to declaring looks great!

This PR just needs tests.
Resolves https://github.com/OpenZeppelin/nile/issues/309.

I just want to mention that 309 is not completely solved by it. We still have the problem with status, which tries to "infer" the artifact of the contract instead of getting it from the deployments.txt file (using execute_call in new starknet_cli.py logic):
https://github.com/OpenZeppelin/nile/blob/98ce378842eb5d404f82e3bc2d082dd06091b665/src/nile/starknet_cli.py#L76-L85
Every time a transaction is sent through an account (most of the time) status is going to fail to try to get the Account artifact, which is already registered correctly in deployments.txt.
Keeping in mind that status uses the contracts registered in this file, and this file contains the artifacts, I think it makes sense to use the artifacts already registered instead of trying to pass overrwriting_path down the flow.

Agree on reading the deployments file. This file exists for these reasons, it also makes custom account integration easier down the road.

Why are we registering the artifact in deployments.txt, if we are going to assume they are always inside the nile artifact folder

We should use the artifact, but a possible reason to register it if not would be to maintain the file structure/invariants.

We still have the problem with status, which tries to "infer" the artifact of the contract instead of getting it from the deployments.txt file (using execute_call in new starknet_cli.py logic)

This is partially correct^. The issue is actually with Debug in that Debug iterates over the .cairo contracts in order to highlight where the error comes from. The FileNotFoundError: [Errno 2] No such file or directory: 'artifacts/Account.json' is coming from _get_contracts_data with the code below for reference:
def _get_contracts_data(contracts_file, network, addresses):
    file = contracts_file or f"{network}.{DEPLOYMENTS_FILENAME}"
    # contracts_file should already link to compiled contracts and not ABIs
    to_contract = (lambda x: x) if contracts_file else _abi_to_build_path
    contracts = _locate_error_lines_with_abis(file, addresses, to_contract)
    return contracts

Being that we only have the artifacts for Account, this is an issue with the proposed solution. I tested this even further by installing OZ Contracts, compiling Account, and adding the Account.cairo path and it works as I thought.

Every time a transaction is sent through an account (most of the time) status is going to fail to try to get the Account artifact, which is already registered correctly in deployments.txt.

This is not entirely accurate. While it won't be able to iterate over the precompiled contracts, I wouldn't say that the status is going to fail. There's already handling for contracts not found https://github.com/OpenZeppelin/nile/blob/main/src/nile/utils/debug.py#L30-L37
    contracts = _get_contracts_data(contracts_file, network, addresses)

    if not contracts:
        logging.warning(
            "🛑 The transaction was rejected but no contract data is locally "
            "available to improve the error message."
        )
        return error_message

which looks like this:
🚀 Deploying contract
Invoke transaction was sent.
Contract address: 0x04d3f77f305c02d158f159a91e00f4562e8697b7025559aa5f0497446c3bd5de
Transaction hash: 0x7e98b1e34107b963dfced6f57f86b005007bde795423b5ae3d42455a60c48c1
⏳ Deployment of contract successfully sent at 0x00dcfac954d8ac11b0de8107520b63c0f1a1bb5928cdec050878370327ce41a4
🧾 Transaction hash: 0x7e98b1e34107b963dfced6f57f86b005007bde795423b5ae3d42455a60c48c1
📦 Registering deployment as my_contract in localhost.deployments.txt
⏳ Querying the network for transaction status...
❌ Transaction status: REJECTED
🛑 The transaction was rejected but no contract data is locally available to improve the error message.
🧾 Error message:
/home/cairo-contracts/env/lib/python3.8/site-packages/starkware/starknet/common/syscalls.cairo:52:5: Error at pc=0:81:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
src/openzeppelin/account/presets/Account.cairo:128:6: (pc=0:731)
src/openzeppelin/account/presets/Account.cairo:143:36: (pc=0:677)
/home/cairo-contracts/src/openzeppelin/account/library.cairo:201:30: (pc=0:291)
/home/cairo-contracts/src/openzeppelin/account/library.cairo:218:19: (pc=0:314)

Error in the called contract (0x41a78e741e5af2fec34b695679bc6891742439f7afb8484ecd7766661ad02bf):
Error at pc=0:32:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:174)
Unknown location (pc=0:127)

Traceback (most recent call last):
  ...
    raise get_stark_exception_on_undeclared_contract(class_hash=class_hash)
starkware.starkware_utils.error_handling.StarkException: (500, {'code': <StarknetErrorCode.UNDECLARED_CLASS: 49>, 'message': 'Class with hash 0x72757b6b4922caeb0d478481635494d88d4be03386f3cffbe1858f00974145 is not declared.'})

I will include a solution for better error handling in cases where the user tries to declare a contract through an undeclared/undeployed sender account. What is not handled, however, is the unregistration of the account through this process (the declaration is nevertheless removed successfully). I'm still looking into the reason.
IMO this whole process highlights why we should prioritize separating account initialization and deployment (#278). With this separation, I believe we'll have stronger control over the account flow and error handling thus better UX.

Thanks for the context @andrew-fleming!

The issue is actually with Debug in that Debug iterates over the .cairo contracts in order to highlight where the error comes from

Yes! My bad. The issue is with debug, not with status, I didn't explain myself well. I said status because debug is a type of status, and is the default that runs (issue only happens if the underlying transaction reverts).

The FileNotFoundError: [Errno 2] No such file or directory: 'artifacts/Account.json' is coming from _get_contracts_data with the code below for reference:

Not sure what we are doing different, but following the same steps provided by Eric in the issue, the traceback of the error I received is this one:
File "/Users/ericnordelo/Documents/Projects/cairo/test_collection/env/lib/python3.9/site-packages/nile/utils/status.py", line 43, in status
   error_message = await debug_message(
 File "/Users/ericnordelo/Documents/Projects/cairo/test_collection/env/lib/python3.9/site-packages/nile/utils/debug.py", line 42, in debug_message
   return await execute_call(
 File "/Users/ericnordelo/Documents/Projects/cairo/test_collection/env/lib/python3.9/site-packages/nile/starknet_cli.py", line 30, in execute_call
   return await capture_stdout(cmd(args=args, command_args=command_args))
 File "/Users/ericnordelo/Documents/Projects/cairo/test_collection/env/lib/python3.9/site-packages/nile/starknet_cli.py", line 47, in capture_stdout
   await func
 File "/Users/ericnordelo/Documents/Projects/cairo/test_collection/env/lib/python3.9/site-packages/starkware/starknet/cli/starknet_cli.py", line 441, in tx_status
   contracts[addr] = Program.load(data=json.load(open(path.strip()))["program"])
FileNotFoundError: [Errno 2] No such file or directory: 'artifacts/Account.json'

Here you can see that the FileNotFoundError error is not coming from _get_contracts_data, but from the execute_call call in line 42. That's why I assumed the issue was coming from the straknet_cli.py design. I'm testing in main branch, maybe this i fixed already in this PR?

This is not entirely accurate. While it won't be able to iterate over the precompiled contracts, I wouldn't say that the status is going to fail. There's already handling for contracts not found

The status is failing already for declare in the issue right? what is the difference with other commands going through accounts? I think is important to discover why your traceback and mine are different in the first place for me to understand this point.

i get the same as Eric. so in short, if i understood correctly:

nile custom artifacts are not properly picked up by artifact-based commands, like account's deploy/declare/send. i guess this affects not just account but also ERC20 (eth token) functions?
Andrew accurately raises that once the artifact is in place, debug would still not work since the account’s source code is not available for processing

i assume Andrew's getting a different error either because he added/compiled a new artifact, or because he has a local fix already

@ericnordelo

The issue is with debug, not with status, I didn't explain myself well. I said status because debug is a type of status, and is the default that runs (issue only happens if the underlying transaction reverts).

Haha no worries! This was a tricky issue, and I just wanted to be as precise as possible.

Here you can see that the FileNotFoundError error is not coming from _get_contracts_data, but from the execute_call call in line 42. That's why I assumed the issue was coming from the straknet_cli.py design.

So the assumption is correct in that the error is raised by execute_call. I mentioned that the error is coming from _get_contracts_data because that's where the problem is stemming from (it's just not raised until execute_call). That's why it was tricky because I also assumed we could somehow set the path to the artifacts for instances where they're returning errors.
Also @martriay ^

But the error says the missing file is Account.json, not the Cairo one. As you say that's properly handled, so what's the error stemming there? and how does that explain the artifact error we get?

But the error says the missing file is Account.json, not the Cairo one. As you say that's properly handled, so what's the error stemming there? and how does that explain the artifact error we get?

Excellent question. The Account.json is being set in _abi_to_build_path...and setting the path there directly solves that error!


python310Packages.faraday-plugins: 1.9.0 -> 1.9.1

Changelog: https://github.com/infobyte/faraday_plugins/releases/tag/1.9.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 209209 run on x86_64-linux 1

4 packages built:

faraday-agent-dispatcher
faraday-cli
python310Packages.faraday-plugins
python39Packages.faraday-plugins


ci: add dependabot updates for github actions

Trying to see if this just works™ :grin:
EDIT: Hm, actually can't see if it works until it pings for an update sometime..

There's a "Dependabot" switch, but it looks like it defaults to on.

Thank you!


About precompile

In order to compile in production enviroment, is it necessary to set config.assets.compile to true and config.assets.digest to false ? Or how to precompile ?
I think it should have a rake task to copy emojis images to public/assets directly.

@chloerei I just forked the Ruby China repo and the emoji files name be digested when rake assets:precompile, how can I fix it?


Update Resources.md

Docs Build status updates of commit f9d26f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/Resources.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Docker user envvar

Why
When creating the default/test database (or other configuration files) within a container, the default user is root.  On Linux, this is an issue when these files are created on a mounted folder.
In particular, on CI, this raise error messages when cleaning up files.
What
Add the setup in the docker-compose file, and information in the documentation.
Remaining

Add info in documentation

What value will this get populated by then?  The default VM user?

@dulacarnold  By default, the default user on Linux is 0:0 (root). It's a bit different on MacOSX since Docker is a native app. I updated the doc to document how to setup the values so that the files (e.g., db, nginx/certbot) are created with the users uid/gid.


Pull request template is asking for things it should't be

Describe the bug
Contributors to OpenSearch no longer are asked to confirm the following:

Please update the PR template from https://github.com/opensearch-project/.github/blob/main/PULL_REQUEST_TEMPLATE.md.

I'd recommend updating the PR template to follow the template in .github to be consistent with other repos in the organization

Closed with #1543


[BUG] Team Warp possible in Combat

What is the bug?
People while in the middle of fight are easily able to escape by running /team warp (warp point), which shouldn't happen in a combat, escaping doesn't work with /team home but happens with /team warp (warp point)
Expected Behaviour
Not allowed to run the command during combat mode. I mean warp only happens when team as to reach to a particular point but during a combat, if they're able to warp then that's not good and is kinda cheating.
How to Reproduce

Get in a Combat
Run /team warp (name) to escape

Error message
No response
Output of /teama version
[18:04:08 INFO]: [Helvetica] Storage Method: com.booksaw.betterTeams.team.storage.storageManager.SeparatedYamlStorageManager
[18:04:08 INFO]: [Helvetica] Minecraft Version: git-Paper-448 (MC: 1.19.3)
[18:04:08 INFO]: [Helvetica] Language Selected: messages
[18:04:08 INFO]: [Helvetica] Current plugin version: 4.6.4

Additional Information
No response

As stated on Discord, this feature already exists. Please open another issue if there are any other problems.


Feature Requests:  Runtime configuration and plugins

I just have a couple of ideas I want to through your way, not sure if they're any good.

Runtime configuration support for black-screen
Support for runtime configurations of other shells (.bashrc, .zshrc)
Plugins for black-screen.  Could possibly be called by run-time configuration.

@stanier, thank you for sharing! We do plan to have the last two, but I'm not sure I understand what the first one means. Could you elaborate, please?

I apologize, I should have tried to be more clear with it.
What I mean with the first point is that we should have a separate runtime configuration file (.blackrc or something similar) that defines instructions specifically for black-screen.  The reasoning for this is that while supporting runtime configuration for other shells is good for compatibility, it shouldn't be used to store runtime configuration for black-screen itself, as those other shells may not support configurations that black-screen does.
Another reasoning I had for this was more of an experimental concept: JavaScript-based rc.  There are many arguments for this, including that of the potential to let runtime configurations extend/modify the Electron shell.  It would also allow for data-related features that cannot be matched in bash or other shell languages (arrays and mapping would be available).
TL;DR To give a stable configuration option meant only for black-screen, as well as possibly provide the ability to run JavaScript in the runtime configuration.

@stanier, I should have guessed that. Any specific options you'd like to have?


snapshot run with CI (jenkins): common not found

I installed Jenkin and snapshot on my Mac. When i integrate Snapshot with Jenkin with command line:
;execute script
snapshot --noinstall
I got an error: snapshot: command not found

Can you share me your configuration? Why ./screenshots/src?

the command is snapshot --noinstall. please ignore the  ./screenshots/src

That's probably because of how you installed Jenkins. It's running as its own user, therefore you'll have to install it for the Jenkins user scope as well.

that is weird. Because, when I run the command on  project home, it work.

I just released snapshot 1.0, please follow the migration guide.
Since the underlying snapshot was completely rewritten, I'm closing this issue now. Feel free to submit a new issue if you're experiencing an issue :+1:


CI: Test for unintended use of problematic symbols/names/includes.

Just a simple shell script running at CI time.

Codecov Report
Patch and project coverage have no change.

Comparison is base (2f16e84) 93.02% compared to head (8afcccf) 93.02%.

:exclamation: Current head 8afcccf differs from pull request most recent head 1a56600. Consider uploading reports for the commit 1a56600 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1820   +/-   ##
=======================================
  Coverage   93.02%   93.02%
=======================================
  Files         353      353
  Lines       25679    25679
=======================================
  Hits        23887    23887
  Misses       1792     1792

Impacted Files
Coverage Δ

common/text/text_structure.h
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Map] AS-Antarian

Hi Kenneth,
please change the author to: "MKone" & "AIMK".
Thanks

Hash: ef98dbc6830b9577ef447d0e6262fecc53ce458c
Current name: AS-Antarian

OK done


x/tools/gopls: should not issue lint-style warnings on generated code

What version of Go are you using (go version)?

$ go version
go version go1.14.7 linux/amd64

$ gopls version
golang.org/x/tools/gopls v0.5.0
<EMAIL_ADDRESS>h1:XEmO9RylgmaXp33iGrWfCGopVYDGBmLy+KmsIsfIo8Y=

Does this issue reproduce with the latest release?
This is the latest release of gopls as far as I can tell
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mgabeler-lee/.cache/go-build"
GOENV="/home/mgabeler-lee/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mgabeler-lee/src/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.14"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.14/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/mgabeler-lee/src/noneofyourbusiness/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build340320309=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Made a project that has generated code from go-bindata
Loaded the project in vscode with the go extension and gopls enabled
OR: Just ran gopls check .../foo.go for all the files in the project

What did you expect to see?

No style/format warnings for a file with a standard generated code header (// Code generated for package foo by go-bindata DO NOT EDIT. (@generated)

What did you see instead?

.../foo.go:306:27-35: redundant type from array, slice, or map composite literal

The vscode warning adds that this is from the simplifycompositelit check

I do see those warnings, and can't get rid of them since ... it's generated code

Thanks for the report! Our current standard has been to offer vet and other analysis diagnostics for generated files, but to avoid any automatically applied suggested fixes. I do agree that there's an argument to be made that we shouldn't offer any purely cosmetic diagnostics for generated files.

My argument would be that, since this is generated code, the user seeing those warnings ... cannot fix them. The next time the code is re-generated, they'll come right back. If they are to be fixed, they need to be fixed in the templates used by the generating tool.
Also from what I can see, many other go linting tools overall know to ignore these files when run on a module.  E.g. golangci-lint ignores files with several "standard" header comments indicating generated code:
https://github.com/golangci/golangci-lint/blob/eeff3902d440513f5598391d6589c779d39af796/pkg/result/processors/autogenerated_exclude.go#L69-L72
And FWIW, when trying to trace the source of which tool was showing these warnings to me in vscode, it seemed like most other go linting tools behave similarly.

My argument would be that, since this is generated code, the user seeing those warnings ... cannot fix them. The next time the code is re-generated, they'll come right back. If they are to be fixed, they need to be fixed in the templates used by the generating tool.

I understand this, but analyzers like go vet and staticcheck may be able to actually find bugs in the generated code, which users might want to fix in the generators--that was the reasoning behind not offering suggested fixes. I agree that anything that is not a bug should not be flagged.

I agree that anything that is not a bug should not be flagged

That sounds like a good compromise :+1:
(thinking out loud...) Cases like the example I hit here may be present in templates to support older versions of Go (not saying that's the case here, but it could be for similar cases, if new "shorthand" syntax is added in future versions of Go, but templates want to support older versions too). Differentiating that from things like errcheck or other signs of coding errors as opposed to style/simplicity makes sense to me.

I'd like to keep linting, though I do understand the temptation to remove it.
My go-bindata currently generates lint errors. It's annoying enough that I'll submit a PR to the repository soon to fix it.
I think this is a subtle nudge to encourage better code generators.

I asked about this on Twitter (https://twitter.com/stamblerre/status/1308898546809266176?s=20), and it seems that there's enough diversity of opinion that I'd rather not make any changes right now. It'd be great to hear more opinions from users on this issue, so let's conduct an ad-hoc poll. Below, cosmetic lint errors refers to any errors that do not relate to the correctness of your code, only its readability.

Please 👍 this comment if you WANT cosmetic lint errors flagged in generated files
Please 👎 this comment if you DO NOT WANT cosmetic lint errors flagged in generated files

I'd like to loop in @ianthehat and @dominikh, because I think this is a rather general issue with go/analysis. There just isn't any guidance as to when should analyzers be used on generated code. Staticcheck has also struggled with this dilemma, and you can still see the open issue with similarly opposing arguments.
I generally agree that any warnings that could be bugs should show up for generated code, and that one should fix the generator. The generator being under someone else's control isn't a good argument there, because ultimately you're the one choosing what generator you run.
I also agree that cosmetic fixes are generally not worth it for generated code, since humans should generally not have to read or maintain the code. That being said, any automated formatting changes would still be good there, for the sake of consistency with the rest of the code. This includes plain gofmt, and optional extras like gofmt -s, and if you ask me, even automated suggested fixes via go/analysis if they still belong in the "consistent formatting" category.
So what I think is missing is some way to categorize analyzers. To me, there are at least three major categories:

Those which find likely bugs (vet, staticcheck)
Those which enforce consistent formatting (gofmt, gofumpt)
Those which make code quality suggestions (the former gosimple, gocyclo, dupl)

You definitely don't want to run the third on generated code, but I think you do want to run the first two there.

I generally concur with the points made by @mvdan in https://github.com/golang/go/issues/41436#issuecomment-698832410, but draw a slightly different conclusion.

I also agree that cosmetic fixes are generally not worth it for generated code, since humans should generally not have to read or maintain the code.

Agreed. I think the word "generally" is key here. Code generated by code generators should be able to be read by humans who want to understand what is going on. Some people might choose/prefer to read that code formatted/simplified/linted to their taste, others not. But this is not a matter of correctness, unlike go vet.

You definitely don't want to run the third on generated code, but I think you do want to run the first two there.

My conclusion is therefore that only the first category in @mvdan's list should ever show as errors in gopls (emphasis key because that's the focus of this description). Because "generally" speaking people don't regularly read/care about the output of a code generator. If they want to fix the formatting/linted-ness of generated code they are going to be doing that outside of analyser suggestions in any case by adding a go:generate directive to format code or by fixing the code generator in some way.

I kind of disagree, there is one specific class of user that wants to see all analyzers on generated code, the generator author, and if we don't allow for that we can expect the overall quality of generated code to be lower, which is not a good thing for the ecosystem.
For all standard analyzers, I would hesitate to trust and use a generator that did not generate clean code anyway. It gets more complex when you start having different people running different analyzers though (which is probably why all non standard linters have the ability to skip these files), as you then are running tests that the generator author does not.
I would rather think about why it is a problem to show these kinds of errors, and what we can do to solve that problem.
Most times I have seen people complain about these kinds of things it is because the problems show up and clutter some kind of list (either command line output or a problems panel in an editor). It might be a sufficient compromise to (optionally?) suppress diagnostics for generated files that are not actively being looked at (so either open in the editor or mentioned on the command line). This would still allow you to see and fix them, but not nag you if you are just working on nearby code.
This would imply that it is a presentation issue rather than an analysis issue (generate all the results and then suppress the unwanted ones). Doing it however requires understanding which files are generated, which is a go concept and should probably not be pushed to the editor, which means gopls would be the right place to implement it.

I kind of disagree, there is one specific class of user that wants to see all analyzers on generated code, the generator author, and if we don't allow for that we can expect the overall quality of generated code to be lower, which is not a good thing for the ecosystem.

I just re-read my reply - I missed out the key words "by default". So I completely agree with your analysis, @ianthehat. I particularly like you suggestion of the option on whether these diagnostics are shown or not being controlled by whether the generated file is open or not.

Doing it however requires understanding which files are generated, which is a go concept and should probably not be pushed to the editor, which means gopls would be the right place to implement it.

Agreed.

there is one specific class of user that wants to see all analyzers on generated code, the generator author

This is a very good point, and I agree is a slam dunk argument for why it should be possible to show the linting results even on generated files.

I would hesitate to trust and use a generator that did not generate clean code anyway

A generator that generates code with minor cosmetic issues would not influence my trust at all. A generator that, say, put everything on a single line, or didn't indent any lines, or other crimes against my eyes would be a different story of course :wink:

I would hesitate to trust and use a generator that did not generate clean code anyway

This seems to be a key point here. I don't think it's reasonable to expect every "high quality" code generator to pass everyone's possible linting rules. Heck, this might not even be possible, if there are corners where there are competing contradictory linting rules across tools (admittedly unlikely in the Go ecosystem). A related use case for this is what if the generator is targeting support for a wide range of Go versions, and some of the cosmetic / simplification suggestions are not supported in the older versions of Go? In that case, the generator maintainer would be entirely reasonable to reject a proposed fix to the style, as it would break a set of users they are intentionally trying to support. (This is admittedly a more hypothetical issue, but it seems plausible to me)

I would rather think about why it is a problem to show these kinds of errors, and what we can do to solve that problem.
Most times I have seen people complain about these kinds of things it is because the problems show up and clutter some kind of list

This was my fundamental motivation behind filing this issue.
A close corollary of this is that, in most contexts, the reports are also not actionable. To clear the warning I would have to file an issue / PR against the generator, wait some indeterminate amount of time for them to fix the issue / accept my fix, and then update my dependencies. Or fork and vendor the generator.

It might be a sufficient compromise to (optionally?) suppress diagnostics for generated files that are not actively being looked at ... not nag you if you are just working on nearby code.

:+1:

Doing it however requires understanding which files are generated, which is a go concept and should probably not be pushed to the editor, which means gopls would be the right place to implement it

I don't understand your rationale behind this statement.

Understanding Go concepts seems like a pretty proper responsibility of a Go language server / linter
Other linters and go source tools seem to think that recognizing generated code is a reasonable responsibility
The standard way to do this was an accepted proposal: https://github.com/golang/go/issues/13560 (the final accepted proposal, hidden deep in github's collapsing of stuff, seems to be https://github.com/golang/go/issues/13560#issuecomment-288457920)

First a note about Staticcheck's behavior: we implement the idea that bugs should be flagged, because you don't want buggy generated code, but that stylistic issues shouldn't be flagged, because you might have no control over the generator. To that end, each analysis decides whether its diagnostics should be hidden for generated code, on a per-diagnostic basis. This applies to most (but not all) style checks, for example. There is currently no way for gopls to overwrite this behavior in Staticcheck, either.
This comes down to a design decision in go/analysis. Analyses have no control over most aspects of the UI, and can not convey intent. They can't set severities (error, warning, ...) nor how to handle generated files. The official opinion IIRC is that an analysis can't make this decision and that it is up to the specific tool running the analysis. The downside of that, however, is that the decision can generally only be made on a per-analysis basis. For Staticcheck, that wasn't good enough, which is why we filter diagnostics for generated code at diagnostic creation time, with the downside that tools like gopls no longer have any control over the decision.
I still think that the go/analysis.Diagnostic abstraction would benefit from a way of conveying the analysis's default intent for a diagnostic. "I (the analysis) believe this diagnostic should be hidden for generated code, unless you explicitly decide otherwise."
Now my responses to various other points made in this thread, in no particular order:

I don't understand your rationale behind this statement.

You seem to be in violent agreement. Ian said this responsibility should exist in gopls, not the editor, which seems to be the thing you're arguing for as well.
Do note, however, that this isn't as trivial as it seems. The LSP protocol is somewhat limited when it comes to two-way communication between the editor and the language server. There's no good way, either in terms of protocol or the editors' UIs, to easily toggle between displaying and hiding diagnostics for generated code.

I don't think it's reasonable to expect every "high quality" code generator to pass everyone's possible linting rules. Heck, this might not even be possible,

Strictly speaking, it only has to follow the rules that everyone has agreed on. The checks that gopls runs should correspond to that set of rules.

A related use case for this is what if the generator is targeting support for a wide range of Go versions, and some of the cosmetic / simplification suggestions are not supported in the older versions of Go?

This is not an insurmountable problem. Analyses can be written to support multiple Go versions. In particular for "features only available in newer Go versions", the analysis can simply be a no-op when targeting older Go versions. Staticcheck already contains analyses doing exactly that.

Prior issues that seem relevant:

https://github.com/golang/go/issues/36914
https://github.com/golang/go/issues/38467

I don't personally care one way or the other if the diagnostics are shown; they don't bother me. What does bother me is when they have suggested fixes that get applied on save. #38467 was about fixing that, specifically gofmt -s. I realize this is against @mvdan's opinion (https://github.com/golang/go/issues/41436#issuecomment-698832410), but I believe any generated file should be treated as effectively read-only.
IMO, if you want the generated code to be formatted in a specific way and a code generator doesn't do that, you should run gofmt or goimports or gofumt in a go:generate directive immediately after code gen. I do this when a generator I'm using outputs something that goimports would change. Otherwise, if I go and run go generate ./... the repo will change, which to me is just as bad as leaving go.mod/go.sum untidy.

There's no good way, either in terms of protocol or the editors' UIs, to easily toggle between displaying and hiding diagnostics for generated code.

Unless I'm mistaken, this is "easy" from the POV that the user will change a setting, the client will send a didChangeConfiguration (which will either contain the config, or trigger a workspace config query from the server to fetch the config), then the server is free to re-send diagnostics afterward. This is how other LSs let you say, hide all warnings, or similar. The server would need to store some "raw" set of diagnostics to filter on send, which is more complicated than just sending them on the fly, yes.

There's no good way, either in terms of protocol or the editors' UIs, to easily toggle between displaying and hiding diagnostics for generated code.

In addition to the configuration approach that @zikaeroh mentioned, there is this suggestion from @ianthehat:

It might be a sufficient compromise to (optionally?) suppress diagnostics for generated files that are not actively being looked at (so either open in the editor or mentioned on the command line)

@ianthehat's comment seems to strike the right note about the separation of the presentational aspect of diagnostics from their calculation. By way of analogy, we do not show stylistic errors for dependencies, only vet errors; again this feels like principally a presentational decision.

@stamblerre - what's the latest on this issue? Does @ianthehat's comment in https://github.com/golang/go/issues/41436#issuecomment-698915266 provide us a way forward here?

@stamblerre - what's the latest on this issue? Does @ianthehat's comment in https://github.com/golang/go/issues/41436#issuecomment-698915266 provide us a way forward here?

We can certainly move forward with only showing certain analyzer results on generated files when they are open, but I do think we are missing the clear categorization of analyzers. We probably need to put some work into clearing up our analysis logic before we can move forward with that (cc @heschik who mentioned analyzer categorization today).


add new features(drawExtraBar, anno_height, drawBox) and update plot_layout

Add anno_height feature to adjust the height of annotation layout
Adjust the space between each legends because I have ten clinical features to show in graph.
Add drawBox feature to add a box around main matrix
Add drawExtraBar feature to replace mutation data in topbar because maybe someone would like show extra numeric cilical data

Example:
laml.maf <- system.file("extdata", "tcga_laml.maf.gz", package = "maftools")
laml.clin = system.file('extdata', 'tcga_laml_annot.tsv', package = 'maftools')
laml <- read.maf(maf = laml.maf, clinicalData = laml.clin)

#Changing colors for variant classifications (You can use any colors, here in this example we will use a color palette from RColorBrewer)
col = RColorBrewer::brewer.pal(n = 8, name = 'Paired')
names(col) = c('Frame_Shift_Del','Missense_Mutation', 'Nonsense_Mutation', 'Multi_Hit', 'Frame_Shift_Ins',
               'In_Frame_Ins', 'Splice_Site', 'In_Frame_Del')
#Color coding for FAB classification; try getAnnotations(x = laml) to see available annotations.
fabcolors = RColorBrewer::brewer.pal(n = 8,name = 'Spectral')
names(fabcolors) = c("M0", "M1", "M2", "M3", "M4", "M5", "M6", "M7")
fabcolors = list(FAB_classification = fabcolors)
oncoplot(maf = laml, colors = col, clinicalFeatures = 'FAB_classification',
         anno_height = 4, drawBox = TRUE, bgCol = "#FFFFFF",
         borderCol = "white", drawExtraBar = "days_to_last_followup",
         sortByAnnotation = TRUE, annotationColor = fabcolors)

I'm not familiar with pulling requests. If there are some misoperations, please let me know.

Thanks a lot. Works with no issues. I just had to set na.rm = TRUE for extdata. I also changed top barplot color to neutral dark gray to avoid confusions with variant classifications.

OK，it seems better!


Small update/fix on group chat feature

Update it so the rooms use characters' public id, which should allow users to pick from two or more characters when applicable. Built-in function to update old room JSON files format is also included. Also a small update on the UI relevant to the room functionality.

Need to change public_id to filename for character's identification for rooms.

Got it. The code should now be using filename instead of public_id for rooms.


pepper_dcm_robot: 0.0.5-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository pepper_dcm_robot to 0.0.5-0:

upstream repository: https://github.com/ros-naoqi/pepper_dcm_robot.git
release repository: https://github.com/ros-naoqi/pepper_dcm_robot-release.git
distro file: jade/distribution.yaml
bloom version: 0.6.1
previous version for package: 0.0.3-0

pepper_dcm_bringup

No changes

Jade is eol


Insallation pact-node with pact-js fails to downloads binary in local mode

Software versions

OS: Debian GNU/Linux 10 (buster)
Library version: 10.9.7
Node Version: v10.21.0

Expected behaviour
In offline mode with configuration:
  "config": {
    "pact_binary_location": "/xxx/pact"
  },

When I install pact-js 9.11.1 (which have a dependency to pact-node 10.9.7):
npm install -S<EMAIL_ADDRESS>
I expect pact-node download binary from "/xxx/pact" ( "pact_binary_location" )
Actual behaviour
I get this error:

Downloading Pact Standalone Binary v1.85.0 for platform linux from https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.85.0/pact-1.85.0-linux-x86_64.tar.gz
Please note: we are tracking this download anonymously to gather important usage statistics. To disable tracking, set 'pact_do_not_track: true' in your package.json 'config' section.
Error: Error while installing binary: Postinstalled Failed Unexpectedly: Error downloading binary from https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.85.0/pact-1.85.0-linux-x86_64.tar.gz: Error: Error while installing binary: Error: getaddrinfo ENOTFOUND github.com github.com:443
at throwError (/home/le-biannicj/.npm-global/lib/node_modules/@pact-foundation/pact/node_modules/@pact-foundation/pact-node/standalone/install.js:29:11)
at /home/le-biannicj/.npm-global/lib/node_modules/@pact-foundation/pact/node_modules/@pact-foundation/pact-node/standalone/install.js:311:16
at process._tickCallback (internal/process/next_tick.js:68:7)

It fails in postinstall.js file of pact-node.
Steps to reproduce

Mode offline with local npm repository (no access to github).

Js project with config :
"config": {
"pact_binary_location": "/xxx/pact"
},

in package.json file.
npm install npm i -S<EMAIL_ADDRESS>
Detailed explanation
I try to install pact-js 9.11.1 (which have a dependency to pact-node 10.9.7):
npm install npm i -S<EMAIL_ADDRESS>I get this error:

Downloading Pact Standalone Binary v1.85.0 for platform linux from https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.85.0/pact-1.85.0-linux-x86_64.tar.gz
Please note: we are tracking this download anonymously to gather important usage statistics. To disable tracking, set 'pact_do_not_track: true' in your package.json 'config' section.
Error: Error while installing binary: Postinstalled Failed Unexpectedly: Error downloading binary from https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.85.0/pact-1.85.0-linux-x86_64.tar.gz: Error: Error while installing binary: Error: getaddrinfo ENOTFOUND github.com github.com:443
at throwError (/home/le-biannicj/.npm-global/lib/node_modules/@pact-foundation/pact/node_modules/@pact-foundation/pact-node/standalone/install.js:29:11)
at /home/le-biannicj/.npm-global/lib/node_modules/@pact-foundation/pact/node_modules/@pact-foundation/pact-node/standalone/install.js:311:16
at process._tickCallback (internal/process/next_tick.js:68:7)

It fails in postinstall.js file of pact-node.
My CI is offline so I can't download from github so I put special configuration in my package.json file (https://github.com/pact-foundation/pact-node#pact-download-location):

  "config": {

    "pact_binary_location": "/xxx/pact"

  },

`

When I install pact-node directly it's working with the special configuration above (npm install @pact-foundation/pact-node@10.9.7).

I took a look at **standalone/install.ts** file in pact-node (which is called by **postinstall.js**) and I saw this code:
`
export function createConfig(): Config {

	const packageConfig = findPackageConfig(path.resolve(__dirname, '..', '..'));

...

This code goes back from two directory in order to find the package.json file of the owner project.
I think when I install pact-js which depends of pact-node, the function "findPackageConfig" find the package.json of pact-js (which have no special configuration "pact_binary_location") and not mine so it try to download from github and fails (because i can't download from github).
Exemple of project hierachy:
<my-project>

	...

	package.json (with conf: ... "pact_binary_location": "/xxx/pact")

	node_modules

		<pact-js>

		   ...

		   package.json (no conf pact_binary_location)

		   node_modules

			<pact-node>

			    package.json

                            standalone

				install.ts

In this example of hierarchy, when the code of pact-node (standalone/install.ts):
findPackageConfig(path.resolve(__dirname, '..', '..'));
is executed, i think it find the package.json of pact-js and not mine (with conf: ... "pact_binary_location": "/xxx/pact")
I have missing something ?
I there a way to tell pact-node to take my package.json with the configuration for "pact_binary_location" ?
Regards

Thanks for the report! Looks like we have indeed made a mistake in the way we read package.json. I'll look at a fix as soon as I can.
I believe as a workaround you can install the relevant version of pact-node directly as a dependency of your project. Does that work for you?

Thanks for the report! Looks like we have indeed made a mistake in the way we read package.json. I'll look at a fix as soon as I can.
I believe as a workaround you can install the relevant version of pact-node directly as a dependency of your project. Does that work for you?

sorry I was on vacation and didn't take the time to answer :)
I would like to install pack-js and since it depends on pact-node I am stuck due to the error explained above.

For now, I think the workaround (to have your project directly depend on pact-node as well as @pact-foundation/pact) should unblock you. Can you confirm if this works?

Thanks for the report btw (I've just updated the report to make the errors clearer).

For now, I think the workaround (to have your project directly depend on @pact-foundation/pact-node as well as @pact-foundation/pact) should unblock you. Can you confirm if this works?

Yes i confirm it works if i add pact-node in my package.json so i m unblocked :)

This should be fixed in v10.11.8, which is building I write this.


[SUGGESTED FEATURE REQUEST]: Additional Link under the Resource Section in the Contributing File

Context:
I would like to add an additional link (YouTube video) to the resources under the contributing file.
Has the feature been requested before?
No it hasn't
Describe the solution you'd like
Looking at the resources for project two, I wasn't quite sure where to start because I was new to Azure services. I believe adding a link to the session conducted for project 2 will give a new contributor (who is new to Microsoft Azure services) and idea on how to start and will serve as a proper support to the previous links on documentation.
If the feature request is approved, would you be willing to work on it and submit a PR?
Yes

Okay nice. Thank you for bringing this up, you can go ahead and add it @Odeyiany2.


Use 2x resolution version of icons

I replaced all the urls of 1x res icons to 2x instead. As they are now, they're blurry compared to the native Gmail icons.
I also saved a backup of these locally, since today is the last day for Inbox 😞, and these links might die some day.

Keep in mind this change was also done on the inbox-in-gmail/inbox-in-gmail fork, so there's no need to merge this as well, if #3 gets merged.

Closing this since it seems like #3 will be merged soon.


IApplicationLifetime is obsolete in .Net Core 3

I want to use this package for operational data in IdentityServer 4 (.Net Core 3).
But I get warning about applicationLifetime. It is obsolete.
app.UseIdentityServerMongoDBTokenCleanup(applicationLifetime);
More info: https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.hosting.iapplicationlifetime?view=dotnet-plat-ext-3.0&viewFallbackFrom=aspnetcore-2.1
Can you help me?

This is fixed as of this commit and will be in the next release. In the meantime you can keep using the current version which will still work with .NET Core 3 or update to 4.0.0-rc.1.


ReadOnlyColumn not being included in select

Summary
I am trying to use the ReadOnlyColumn attribute in a module but the Select Statement generated to get an item does not include the column.
Extended description
I have created a model with some columns (small version here):
[TableName("ALGO_File")]
[PrimaryKey("Id", AutoIncrement = true)]
public class AlgoFile
{
public int Id { get; set; }
public string FileName { get; set; }
public string ContentType { get; set; }
    [ReadOnlyColumn]
    public string FileSize { get; set; }

}
When I use the repository.GetById(Id); to fetch the item, the FileSize never gets populated.
After inspecting the generated SQL statement I am able to see that it does not contain the FileSize column.
In the ALGO_File table the FileSize column is Calculated and Persisted.
After checking the code and loking for answers I came across the petapoco documentation stating that:
"Note: By default, ResultColumns are not included in auto-generated SQL. To read a ResultColumn from the database, you must either specify IncludeInAutoSelect.Yes when applying the attribute, or build the SELECT statement yourself and specify the columns you want."
(in https://github.com/CollaboratingPlatypus/PetaPoco/wiki/Mapping-Pocos)
I think this new attributes are a recent change in the petapoco columninfo.
(https://github.com/CollaboratingPlatypus/PetaPoco/blob/master/PetaPoco/Core/ColumnInfo.cs)
By inspecting the DNN mapper function I dont see this IncludeInAutoSelect being set.
ci.ResultColumn = (pocoProperty.GetCustomAttributes(typeof(ReadOnlyColumnAttribute), true).Length > 0);
(in https://github.com/dnnsoftware/Dnn.Platform/blob/f4b22f6f7e712723297039af6a39efec6bd74635/DNN Platform/Library/Data/PetaPoco/PetaPocoMapper.cs)
##My question:
Could this be the reason why I am not getting the values populated from the SQL database?
Does anyone else had problems with this?
Affected version

[x] 9.2

@dnnsoftware/tag thoughts on this, should we update the mapper to support this ? Could this be a breaking change ?

Looking at the documentation, the best recommendation would be to utilitize the methods suggested.
1.) Add the[ResultColumn]Attribute to your method
2.) Since adding this globally would have a negative and breaking change you would also add the IncludeInAutoSelect.Yes value on the attribute as an option.
NOTE: This needed attribute is [ResultColumn] which is different than the issues submitted [ReadOnlyColumn] attribute which would NOT work with PetaPoco.

Adding the [ResultClumn] to my property alone does not work and the value keeps being null after a select (using repository.GetById(Id);). As sugested in the 2.) it must be included in the select (I have inspected the SQL statement sent to SQL server and the column does not get included by default, as expected).
My issue now is that I cannot find the IncludeInAutoSelect.Yes in the ResultColumn attribute.
Can anyone help me with a working example?

@miguelvaz78 if you read the documentation you need to include the attribute and ADDITIONALLY set a property of the attribute to tell it that it needs to be added.
Your entire attribute would look like this [ResultColumn(IncludeInAutoSelect.Yes)]

However, I'm not 100% sure what release of PetaPoco this was included in

Thank you @mitchelsellers for the help here. In the version that I'm currently working on of the DNN platform 9.2, running version 5.0.1 of petapoco, there the IncludeInAutoSelect is not available. I Will check it in the new versions.
Also, when I use the attribute ResultColumn, and try to create or update the model, I'm getting an error "The column "FileSize" cannot be modified because it is either a computed column or is the result of a UNION operator."
I will upgrade the platform and try this again with a fresh set of eyes soon.
Cheers!


Browser Console Error 400 When Filtering Connections via "MFA" Option

Describe the issue:
Upon attempting to filter connections using the "MFA" option, users are encountering a 400 error in the browser console.
How to reproduce:
Access the connections filter functionality.
Select the "MFA" option to filter connections based on MFA status.
Observe the browser console and notice the 400 error appearing.
Expected behavior:
Users should be able to filter connections using the "MFA" option without encountering any errors.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: wso2is-7.0.0-alpha-SNAPSHOT
OS: Mac -
Database: Mysql - 8.1.0
Userstore: JDBC
Browse - Safari, Firefox

Same request is sent 3 times.

When filtering connections, two different API calls are made; one to the identity-providers endpoint (https://localhost:9443/t/carbon.super/api/server/v1/identity-providers) and another to the authenticators endpoint (https://localhost:9443/t/carbon.super/api/server/v1/authenticators).
The authenticators endpoint call gets success and returns the filtered result (Ex: filtered MFA connections). The identity-providers endpoint call returns 400 as it doesn't support filtering with tags. IDP filtering is implemented only for the idp name, description, home realm, enabled and UUID attributes (refer code).
Currently tags are only applicable for authenticators and not identity-providers. Hence when filtering, the additional frontend call for idps with filtered param should be prevented.


docs(icons): Fix unescaped HTML tags in code comments

Fixes  #5793

I have to do something out of the office right now, but I'll fix this googlebot complain when I'm back (probably redo the fork).


station splits into chars

Ran as
python PIQQA.py --network=CO --stations=JSC --start=2022-06-01 --end=2022-07-01

then piqqa produced this warning, note that the station in the url is J,S,C instead of JSC:
    INFO: Retrieving percent availability information for HHZ
         --> Unable to get measurements for percent_availability, waiting 5 seconds and trying again
             http://service.iris.edu/mustang/measurements/1/query?metric=percent_availability&net=CO&sta=J,S,C&loc=*&chan=HHZ&format=text&timewindow=2022-06-01,2022-07-01&nodata=404
         --> Still unable to get measurements for percent_availability, bypassing
**** WARNING: No Percent Availability found for HHZ - services could be down or metrics may not exist for data yet ****

Perhaps related to first error, at the end I get:
Traceback (most recent call last):
  File "/Users/crotwell/dev/GitHub/iris-edu/piqqa/PIQQA.py", line 2182, in <module>
    main()
  File "/Users/crotwell/dev/GitHub/iris-edu/piqqa/PIQQA.py", line 2174, in main
    doReport( splitPlots, services, outfile, channels, network, startDate, endDate, tolerance, nTop, nBottom, metricList, startYear, endYear, actualChannels, avFilesDictionary, boxPlotExampleImage_moved, boxPlotDictionary, stations, locations, pdfDictionary, spectDictionary, mapFilename, metadataDF, availabilityType, metricsWithPlots, mapformat,includeOutliers, spectColorPalette, powerRanges, userDefinedPowerRange)
  File "/Users/crotwell/dev/GitHub/iris-edu/piqqa/PIQQA.py", line 1225, in doReport
    stationServiceLink = f'{stationServiceLink[:-1]}'
UnboundLocalError: local variable 'stationServiceLink' referenced before assignment

I can recreate this and am working on a fix that we should be able to include in the next release here soon.

seems to work fine in 1.0.1, thanks.


failed electron dependencies [linux]

AppImage and manual build both fail with:
(electron:171850): Pango-ERROR **: 20:32:36.996: Harfbuzz version too old (1.4.2)
System version of harfbuzz is 2.7.2-1    pango is 1:1.46.2-3
related issues
https://gitlab.gnome.org/GNOME/pango/-/issues/428
https://github.com/electron/electron/issues/20348
I'm not too keen on downgrading pango, so I try solve issue by updating electron
 yarn upgrade electron --latest
But that just make different errors and I don't really understand this ecosystem well enough to do anything else about it. :\

Hi @voidlogic are you building from master?

Yes.

related: https://github.com/rabix/composer/issues/450


How to configure after the latest changes?

I'm having issues after the last breaking changes...
Change and delete doesn't work anymore, just add. I suspect I'm configuring it wrong.
return {
    setup = function()
        require('nvim-surround').setup({
            brackets = { '(', '{', '[', '<' },
            surrounds = {
                ['('] = { add = { '(', ')' } },
                [')'] = { add = { '(', ')' } },
                ['{'] = { add = { '{', '}' } },
                ['}'] = { add = { '{', '}' } },
                ['<'] = { add = { '<', '>' } },
                ['>'] = { add = { '<', '>' } },
                ['['] = { add = { '[', ']' } },
                [']'] = { add = { '[', ']' } },
                ['r#"'] = { add = { 'r#"', '"#' } },
            },
            keymaps = {
                insert = false,
                insert_line = false,
                normal = ',a',
                normal_cur = false,
                normal_line = false,
                normal_cur_line = false,
                visual = ',',
                visual_line = false,
                delete = ',d',
                change = ',r',
            },
            highlight = {
                duration = 1000,
            },
        })
    end,
}

As of right now, the way it's setup is that if you change a surround key from the default, you must provide all other keys, otherwise nvim-surround will default to invalid_key_behavior for the remaining keys. Honestly this should probably be changed to make it simpler for people that just want to change one or two things. For the time being, please copy-paste the surrounds from the default config and change the add keys back to what you would like (in your case, probably only copy the closing pairs).
Also as a quick question: Does your last surround (r#") actually work? I was under the impression that I coded this plugin to work only for single characters.
CC: @andrewferrier @smjonas About the configuration question: Should the user have to re-define everything, or just what they want to change?

@kylechui I think that whilst script-ability of plugins is great, (from my perspective) the primary use case of nvim is to do some work, scripting the editor is a potential benefit but not it's primary use case, so I personally think plugins should spend more time trying to make sure people can stay productive.
To be honest, in this example I would have just expected that where my change was to a default config options it would just be deeply merged with the defaults so that I wouldn't have to go and redefine a bunch of stuff even if it's just copy pasting.
A bunch of code added to the config like that not only means a user has a more verbose config, but they are also "maintaining" code they might not understand and worse still, code that can break at some point that they never really wanted to have in there anyway.

That makes a lot of sense; thanks for providing some input. I'll probably work on this soon-ish after I finish Tree-sitter integration (since that seems to be reasonably easy given the way I've refactored some of the code); this change would warrant me releasing v2.0.0 then, right?

@augustocdias Do you mind trying out the better-configuration branch with the configuration you had earlier and see if that fixes things?

Also as a quick question: Does your last surround (r#") actually work? I was under the impression that I coded this plugin to work only for single characters.

This I carried from previous surround plug-in. I forgot to remove when I migrated. I never tried it because the code base I'm working currently doesn't use this pattern.
And I'll test the new branch first thing in the morning

Yeah just as a forewarning that the surround keys are necessarily one character, so if/when you decide to use that surround you can change r#" → r or some other key of your choosing.

As of right now, the way it's setup is that if you change a surround key from the default, you must provide all other keys, otherwise nvim-surround will default to invalid_key_behavior for the remaining keys. Honestly this should probably be changed to make it simpler for people that just want to change one or two things. For the time being, please copy-paste the surrounds from the default config and change the add keys back to what you would like (in your case, probably only copy the closing pairs).

I haven't looked at this specific issue, but this is one of the real cool things about using vim.tbl_deep_extend() to setup your config. For example, look at https://github.com/andrewferrier/debugprint.nvim/blob/e1f932b4bdfe444c0c6fd2d1e9b3a4a4adbcc166/lua/debugprint/init.lua#L105 and https://github.com/andrewferrier/debugprint.nvim/blob/e1f932b4bdfe444c0c6fd2d1e9b3a4a4adbcc166/lua/debugprint/filetypes.lua#L15. If a user passes in a filetypes array to debugprint.setup(), these filetypes are merged into the default filetypes array I already have provided by default automatically, so I just see the merged list. They don't need to pass in the ones that are already in the default list. At least in the case of this plugin, this is the behaviour I want, as that allows them to extend its behaviour and easily benefit from any improvements I make without copy-and-pasting my default config into theirs repeatedly.
Not sure if that helps in your case, but something to bear in mind.

@kylechui I've been using your branch and it looks good. Its working as expected

Ok sounds good, I think I'll have a branch v2.0.0 that I'm going to start merging other branches into.


Druid to Presto Querying data

Druid Version :0.17
Hi Team,
We are trying to access Druid via broker and coordinator URLs via Presto. We are seeing some challenges in querying large Druid data sources.Small data sources are easily query able
73,243,851 rows -Real time Streaming data
18,100,826 rows -Batch Load
817,205 rows-Real time Streaming data.
Let me know if we can optimize broker/historical nodes for fast data retrieval.
Thanks,
Ashish

Hi, @averma111 . I wrote a blog to introduce how to use Presto Druid Connector, I hope it can be helpful to you. https://yuzhouwan.com/posts/200906#Apache-Druid-Connector


[WIP] Initial pull request for comment editing

Comment editing is almost here! (finally) At present, you can make a comment and edit it, but still in progress:

a decent icon for editing (I just reused the close button one for testing)
thorough testing for different combinations of creating/closing/replying/etc.

I'm creating a WIP pull request to a). prevent this from disappearing again and b). get feedback for any  issues you guys might see.
Are there automated tests anywhere for any of the additions I've made?

The cherry picked commits look good to me - I'll take a second look.
Can you add some tests to the API/Submissions tests. There are similar tests for adding comments - so you might want to look at those?

This doesn't have permission checking or empty message checking - I'll go ahead and add tests & deploy since I've deploying a bunch of other composition improvements.
I'll work off the enhancements/jordon/editcomments branch


Update action to Node 16

I'm using purcell/setup-emacs@master in a Github workflow and lately I'm seeing warnings about Node 12 deprecation.
It seems all actions need to update to Node 16:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Could you update your code accordingly? Thanks!

Fixed by #30, I believe.


docs: update README.md

environement -> environment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tweak search bar to show back button on focus only

Description
On mobile, display back button only when the search input is focus.
Why
UX improvements
Screenshots

Now that it's clearly linked to the focus and display of the suggestion dropdown, it's confusing that clicking on the arrow clears the entry. We should remove the clearSearch() action on this button, so its only purpose is to exit the suggest.
By the way, this is already what is done in the direction inputs: https://github.com/QwantResearch/erdapfel/blob/master/src/panel/direction/DirectionInput.jsx#L132-L135
So it will be a big plus for consistency.

Now that it's clearly linked to the focus and display of the suggestion dropdown, it's confusing that clicking on the arrow clears the entry. We should remove the clearSearch() action on this button, so its only purpose is to exit the suggest.
By the way, this is already what is done in the direction inputs: https://github.com/QwantResearch/erdapfel/blob/master/src/panel/direction/DirectionInput.jsx#L132-L135
So it will be a big plus for consistency.

Thanks, I removed the call to clearSearch.


Update the look & feel for 'How it Works' page.

Reference — https://opencollective.com/learn-more
Update the page's design to match the new style. Review the steps and rewrite the copy-write.

hey @xdamman just to make sure these are accesible by anyone, the new updated images for this page WITHOUT changing anything else can be found here:  #1171

@xdamman, the expectation for this page is to update the general style but still have the layout unchanged or do you think a page re-design is needed now?

We still need to re-implement that feature that we used to have on the old website. But we need to think this through a bit better.
For the layout, see what you can do. I think it has to be adapted for the new design but I wouldn't go too fancy. Done is better than perfect and we need to be mindful of limited frontend engineering resource.

Hi! This is a first version of the page.
— I added two more things before the current things currently on the page that, if they may be obvious, I believe will help users.
— I also re-ordered the sequence of the content to make it feel more sequential based on the steps that users will actually follow.
— https://invis.io/UDMY05M9MH6#/311234794_How_It_Works_-_Desktop
— Image:

We should review the text. Here is what I'd suggest:
Create different tiers
(screenshot of a backer and sponsor tier)
Accept one time or recurring donations
Define different tiers for members or sponsors
Manage your expenses online
(screenshot of the detail expense page with comments)
Allow anyone to file their expenses or invoices online
Let anyone comment on expenses
One click approve/reject expense
Keep picture of the receipt / invoice private
Transparent ledger
(screenshot of /transactions page and PDF)
All transactions in and out are public
Automatic PDF invoice
Open Data, Open Source
(csv export image)
Export the list of all your backers with their email addresses at any time
Export list of all transactions
Open Collective is open source https://github.com/opencollective/opencollective
Manage multiple collectives
(screenshot of monthly host report)
Open Collective makes it easy to host multiple collective on one single legal entity.  This makes the work of your accountant a breeze.
And so much more
(screenshots of event page, update page, email report)

Create events
Publish updates to keep your backers posted on your progress
Monthly reports to backers
Slack integration

I put this on a google doc so that it's easier to iterate and get comments: https://docs.google.com/document/d/1I_3VzwPKCO2d6Qv5LkCYQiM9zgIQgnFRQF1dg_xxXzM/edit?usp=sharing

Here's a mock of the page with placeholders for the images we will end up using. This shows a layout adjustment for this updated content.
Let me know your thoughts. The InVision link is the same one.
— Image:

That looks great.
I've added one more section about goals in the google doc, below for your convenience:
Set up goals
Define goals towards your balance to be able to buy something or to organize an event or define goals towards your annual budget to be able to hire someone for your collective.

Latest mockups is in InVision. I left a few comments there.
— InVision: https://invis.io/UDMY05M9MH6#/312730961_how_it_works_-desktop-
— Mockup

Both views have the images within each value prop and feature described. Mobile view is ready.
— Mobile view (InVision): https://invis.io/XBNFG3ZY7A6
— Attached image:

There are a 2 pending comments made by @piamancini on InVision about including Support Tier in the "Create different tiers." block, and about the main headline of the page.

Update:
Saraí (front-end contractor) will begin on this page next Monday, Nov 12 and it should be ready by the following Thursday or Friday, following the instructions that @znarf sent me.


When app is put in background and network is disconnected, white screen is displayed without any error

Steps to reproduce :

put your app in background
open network prefs and disable all networks (as if you were in a tunnel without wifi or phone data network 3G/4G)
call your app back -> a white screen is displayed

The main problem is how to debug that as when your disconnect your network, you don't have any more console log information (i'm using expo) nor debugger.
I'm trying to :

debug within XCode with USB plug, but as there is no error in libraries, unsuccessful for now
setup a github with meteor testbed and snack.expo.io project to reproduce the problem without my full app

If someone has an idea, we can discuss in the gitter Lobby.

Here the snack to you can see the expected behaviour : https://snack.expo.io/@lc3t35/react-native-meteor-issue-323

Rebuilding RNApp example

[x] migrate from createContainer to withTracker
[ ] upgrade to RN 0.55.2

@edwin-n-johnson As my app is detached, I confirm it also happens outside expo, I've just use expo here to quickly reproduce the problem.

Thanks @lc3t35. Have you made any progress finding the root cause? I'm curious as to why we are seeing it and not many others. And why are there no errors?

I think this may occur because rn-meteor relies on NetInfo API and NetInfo had some issue before becoming a standalone library.


Why do the instructions start with "If you are a doctor"

Thank you for your interesting work.
In the chatdoctor5k.json and chatdoctor200k.json I see that the instructions start with "If you are a doctor".
I am curious why the instructions do not start with "You are a doctor".
Is this a common way to perform the alpaca instruction fine-tuning?

They should not have a major impact on the outcome and both should be acceptable.

I understood as the fine-tuning process should only influence the model in the context of when the model is acting as a doctor.
So the "major imapct" implies that the fine-tuning should not have impact when the model is not acting as a doctor.
Did I get it right?

Yes, if the patient's description is used as an instruction instead of an input, the trained model will affect the conversational ability of other tasks, while fixing the instruction as 'if you are a doctor' and adding this instruction to the inference will ensure the proper operation of the model.

Well understood. Thank you so much for the clarification!


Fixed incorrect assert fail message in KubernetesAuthentication

@pragalbhgarg Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@pragalbhgarg Thank you for signing the Contributor License Agreement!


fix: patch set-output command

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: