Issues between robomasterpy and multiprocessing

hi,
unfortunately both examples don't work for me.
At least for me it seems like this is a issue with how robomasterpy works with pythons multiprocessing.
See the following error:
[h264 @ 000001a5ff495440] missing picture in access unit with size 6
2023-03-14 16:52:28,044 vision       : INFO     signal received, closing...
Process vision:
Traceback (most recent call last):
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\managers.py", line 810, in _callmethod
    conn = self._tls.connection
AttributeError: 'ForkAwareLocal' object has no attribute 'connection'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\process.py", line 314, in _bootstrap
    self.run()
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\site-packages\robomasterpy\framework.py", line 297, in _build_worker_and_run
    worker()
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\site-packages\robomasterpy\framework.py", line 164, in __call__
    self.work()
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\site-packages\robomasterpy\framework.py", line 559, in work
    self._outlet(processed)
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\site-packages\robomasterpy\framework.py", line 193, in _outlet
    self._out.put(payload, block=True, timeout=self.QUEUE_TIMEOUT)
  File "<string>", line 2, in put
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\managers.py", line 814, in _callmethod
    self._connect()
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\managers.py", line 801, in _connect
    conn = self._Client(self._token.address, authkey=self._authkey)
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\connection.py", line 505, in Client
    c = PipeClient(address)
  File "C:\Users\eddiw\.pyenv\pyenv-win\versions\3.10.6\lib\multiprocessing\connection.py", line 707, in PipeClient
    _winapi.WaitNamedPipe(address, 1000)
FileNotFoundError: [WinError 2] Das System kann die angegebene Datei nicht finden

Well, as it turns out the problem is Line 315 in framework.py of robomasterpy.
signal.sigwait((signal.SIGINT, signal.SIGTERM))
sigwait() is not known to python.

Thanks for the raise: https://github.com/nanmu42/robomasterpy/issues/25


When the Default template is used for a subcommand help does not provide docs for all subcommands anymore

Thanks for reporting this


(BKR-1151) Add port 8142 for masters PXP/PCP

Orchestration (PXP/PCP) needs port 8142 opened on all masters, MoM and compile.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3959/

Looks like this PR needs Unit Test changes as well as logic to add 8143 during "split" (and only "split") installs.

@doug-rosser your last comment looks current :trollface:

BKR-1151 resolved with #1433


Batch techniques for ECDSA, Schnorr and BLS signatures

Implement techniques for aggregating signatures and verification of ECDSA, Schnorr and BLS.

May be worth it to have a look at https://github.com/mratsim/constantine/pull/214 👍


No new media from location

I keep getting "No new media from location" whenever I add a new location. When I grab the coordinates from SnapMap the location is full of snaps, but as soon as I scrape them in Snapchat-map-scraper I just keep getting "No new media from location".

Does it find anything if you add the argument --randomize to the command? e.g.
python3 story_downloader.py scrape --randomize

The script uses a specific zoom value, which might differ from the zoom level you see in your SnapMap. Randomize will pick a random spot within ~1 mile of the target which may be nearer to snaps. You could also let it repeat with a small wait time and check after a few minutes to see if any of the random spots had snaps.
python3 story_downloader.py scrape --randomize --repeat --sleep 2

Does is still work >

I haven't tested it recently. It worked after Snap removed their public map but if it's not working for you, they may have removed or changed the server.

Just tested it, it's still working for me. It's a lot slower downloading videos than I remember, but if you keep waiting it will finish.


Resolve main to live conflicts

@rolfbjarne this PR is to merge latest main branch to live, could you please help to review and merge?

Docs Build status updates of commit ffb27d2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

[en/AddressBook/ABMultiValue1.xml](https://github.com/shawnwang-ms/apple-api-docs/blob/shawnwang/resolve_main_to_live_conflicts/en/AddressBook/ABMultiValue1.xml)
:warning:Warning
View
Details

en/Foundation/NSError.xml
:warning:Warning
View
Details

en/Foundation/NSObject.xml
:warning:Warning
View
Details

en/ObjCRuntime/Dlfcn.xml
:warning:Warning
View
Details

en/SceneKit/SCNMaterialProperty.xml
:warning:Warning
View
Details

en/System/nuint.xml
:warning:Warning
View
Details

en/UIKit/UIApplication.xml
:warning:Warning
View
Details

en/UIKit/UIApplicationDelegate.xml
:warning:Warning
View
Details

en/UIKit/UIImage.xml
:warning:Warning
View
Details

en/UIKit/UIView.xml
:warning:Warning
View
Details

en/UIKit/UIViewController.xml
:warning:Warning
View
Details

en/ns-CoreAnimation.xml
:bulb:Suggestion
View
Details

en/ObjCRuntime/BaseWrapper.xml
:bulb:Suggestion
View
Details

en/ObjCRuntime/MarshalManagedExceptionMode.xml
:bulb:Suggestion
View
Details

en/ObjCRuntime/MarshalObjectiveCExceptionMode.xml
:bulb:Suggestion
View
Details

en/ObjCRuntime/TypeConverter.xml
:bulb:Suggestion
View
Details

en/UIKit/UIGraphics.xml
:bulb:Suggestion
View
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

en/AudioToolbox/AudioFormatFlags.xml
:white_check_mark:Succeeded
View

en/AVKit/AVPictureInPictureController.xml
:white_check_mark:Succeeded
View

en/CallKit/CXErrorCode.xml
:white_check_mark:Succeeded
View

en/CallKit/CXErrorCodeIncomingCallError.xml
:white_check_mark:Succeeded
View

en/CoreAnimation/CABasicAnimation.xml
:white_check_mark:Succeeded
View

en/CoreAnimation/CALayer.xml
:white_check_mark:Succeeded
View

en/CoreData/UserInfo.xml
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.

[en/AddressBook/ABMultiValue1.xml](https://github.com/shawnwang-ms/apple-api-docs/blob/shawnwang/resolve_main_to_live_conflicts/en/AddressBook/ABMultiValue1.xml)

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.

en/Foundation/NSError.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.nativeint'.

en/Foundation/NSObject.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.UIntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.unativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.UIntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.unativeint'.

en/ObjCRuntime/Dlfcn.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.UIntPtr'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.unativeint'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.System.IntPtr'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


test(core): improve test coverage

Codecov Report

Merging #1 (7a8499e) into main (6d03d7d) will increase coverage by 4.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   89.56%   93.91%   +4.34%
==========================================
  Files           6        6
  Lines         115      115
  Branches       18       18
==========================================
+ Hits          103      108       +5
+ Misses          4        0       -4
+ Partials        8        7       -1

Flag
Coverage Δ

unittests
93.91% <ø> (+4.34%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

main.ts
95.12% <0.00%> (+12.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d03d7d...7a8499e. Read the comment docs.


Making cards with instances and cards with responsabilities

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1101 of 1110 (99.19%)  changed or added relevant lines in 22 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 99.189%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/Acceleration.class.st
22
25
88.0%

repository/IngSoft2-Model/Cancellation.class.st
66
69
95.65%

repository/IngSoft2-Model/Redo.class.st
52
55
94.55%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
1101

Relevant Lines:
1110

💛  - Coveralls


Extend GET endpoint to include resource as query param

Description
Two new properties: resource and resourceId have been defined for cloudEvents processed through Altinn.
Event subscribers should be able to request a list of events based on the resource attribute.
Consideration

Do we need to use source as a query parameter once resource is required?

No, support for source, will be removed as query param.

Consider if we need to check if after is defined in function

Tasks

[x] Add new required query parameter to endpoint
[x] Remove support for source as query parameter
[x] Update function in postgreSQL to match on resource and remove support for source
[x] Update function to use optimal queries for jsonb
[x] QA
[x] Update swagger
[ ] Test
[ ] Documentation

Acceptance Criteria

[x] It is possible to query events using the resource query parameter
[x] A request without resource parameter should fail with bad request
[x] A request with resource and after parameter is valid
[ ] Indexes are utilized when getevents function is called.
[x] Querying app events should also utilize resource, if not possible to consolodate procedures ensure seperate issues is created Moved to seperate issue

There are no index on resource.


make-socks-proxied-conn-manager doesn't work

I tried to use a SOCKS5 connection per the documentation and got a ClassCastException.
Started a SSH proxy locally:
ssh -N -D <IP_ADDRESS>:1080 localhost
Then tried using this connection as per the docs:
(clj-http.client/get "http://www.google.com", {:connection-manager (clj-http.conn-mgr/make-socks-proxied-conn-manager "localhost" 1080)})
Get the following ClassCastException:
java.lang.ClassCastException: org.apache.http.impl.conn.PoolingClientConnectionManager cannot be cast to org.apache.http.conn.HttpClientConnectionManager

I think this is a leftover from the move to non-deprecated APIs, the socks proxy connection manager is still using the deprecated one, so it cannot be cast. I'll check it out

I believe #328 fixes this.

@jstewart can you test with the latest master and see if this has already been fixed?

@dakrone Excellent. Yes, SOCKS proxying works again now with the latest master.

@jstewart great, I will make a release as soon as I get stable internet

Released 3.2.0 that has this fixed


Suggestion http://www.typescriptlang.org/: Add Github Stars upfront

Lots of OSS projects do this. Adding this to the homepage will definitely increase OSS interaction (stars matter). Most projects use https://ghbtns.com/
Link for us:
https://ghbtns.com/github-btn.html?user=Microsoft&repo=TypeScript&type=star&count=true&size=large
Code that needs to go in :
<iframe src="https://ghbtns.com/github-btn.html?user=Microsoft&repo=TypeScript&type=star&count=true&size=large" frameborder="0" scrolling="0" width="160px" height="30px"></iframe>

Demo :

More
If stars are used as a link to github it increases the users chances of actually staring the project.

We have some updates in the pipe -- feel free to revisit once you see them :wink:


Relocating shards not visible in 1.4.9

I upgraded from 1.4.4 to 1.4.9 and relocating shards are now longer shown. Unassigned shows and initializing shards are showing up, but relocating shards not not shown anymore.
I'm not sure what information you need in order to debug this. Let me know and I should be able to get you some data.

@SecEng not really sure what you mean, but I just installed v1.4.9 and did a simple test

:
seems to work ok(initializing shards are displayed in yellow and the relocated shards are displayed in black).
is that what you meant?

Sorry for not being specific, the count isn't being displayed like it used to.
So when unassigned and initializing shards are happening (in 1.4.9) right above the nodes (below the 4 symbols) it says,
"x shards unassigned" and "x shards initializing".
In 1.4.4 where it had the shards count(at the top of the page), in small letters it would say "x relocating". (that is also the same spot that had the X for unassigned and initializing).
Does that help?

@SecEng adding the number of relocating shards on the same place as initializing/unassigned works for you?

That works perfectly for me.


Ghidra Creates Local Variables with no known location then aliases them.  How to resolve this for export data?

I am trying export some data from a decompiled function, and I need to know the stack or register location of every parameter and local variable.
Occasionally, I struggle with finding the location data of local variables using the Ghidra API, if I try with the following method.
HighVariable hv = symbol.getHighVariable();
			if (hv != null) {
				Varnode vn = hv.getRepresentative();
				if (vn != null)
					offset = Long.toString(vn.getOffset());
				VariableStorage storage = symbol.getStorage();
				if (storage != null) {
					if (storage.hasStackStorage())
						locName = "Stack";
					else if (storage.getRegister() != null)
						locName = storage.getRegister().getName();

I am attaching an example binary.   If I look at puVar4 under the function  cgc_AcceptMove, the offset and locName I get from this ends up being unassigned.   However, this might not be too problematic because I see that puVar4 is assigned to auStack60, but I can't seem to get location information from auStack60 (other than by looking at the name).
My question is:

Is there a better way to get location information for parameters and local variables than what I am doing?
If not, does the API support a way where I can determine the location of variables like puVar4 by looking at what it's assigned to?

Here is an a snippet of the function for your convenience:
int cgc_AcceptMove(char (*b) [8],char *srcx,char *srcy,char *dstx,char *dsty)

{
  cgc_size_t cVar1;
  int iVar2;
  char *pcVar3;
  undefined *puVar4;
  InputStruct *apIStack80 [2];
  char *pcStack72;
  cgc_size_t acStack68 [2];
  undefined auStack60 [7];
  char cStack53;
  InputStruct s;
  cgc_size_t rxcount;
  int i;
  char *coord2;
  char *coord1;

  puVar4 = auStack60;
  s.input._0_4_ = 0;
  s.input._4_4_ = 0;
  s.input._8_4_ = 0;
  s.input._12_2_ = 0;
  s.input[14] = '\0';
  s.allowed_chars._0_4_ = 0x33323130;
  s.allowed_chars._4_4_ = 0x37363534;
  s.allowed_chars[8] = '\0';
LAB_0001356f:
  do {
    while( true ) {
      while( true ) {
        while( true ) {
          *(char **)(puVar4 + -0xc) = cgc_CURR_PLAYER;
          *(undefined **)(puVar4 + -0x10) = &DAT_00013ddc;
          *(undefined4 *)(puVar4 + -0x14) = 0x13585;
          cgc_printf(*(char **)(puVar4 + -0x10));
...
bunch of more stuff
...
}

Board_Game.zip

A did a little more digging and found that all the Ghidra variables except for the following:
  cgc_size_t cVar1;
  InputStruct s;
  int i;
  char *coord2;
  char *coord1;

Don't have locations for them.   Luckily, most of them are never used in the function, so most likely I can simply ignore them.  The one exception is puVar4.   puVar4 seems to be a magic variable that is used as a container for passing along arguments to the calls in the function.
A new question I would add is, can use the API to programmatically detect that this puVar4 variable has this special purpose?

Here is the associated source code used to compile the binary.   I see that most of the variables (with the exception of rxCount) that don't have storage locations also can not be mapped back to corresponding source code variables.
int cgc_AcceptMove(char b[X_MAX][Y_MAX], char *srcx, char *srcy, char *dstx, char *dsty) {
	struct InputStruct s = {"", "01234567"};
	char *coord1, *coord2;
	int i;
	cgc_size_t rxcount;

	while (1) {
		cgc_printf("@s: ", cgc_CURR_PLAYER);
		cgc_bzero(s.input, 15);
#if defined(PATCHED) && !defined(BUG_1)
		if ((rxcount = cgc_receive_until(s.input, '\n', 14)) == 0) {
#else
		if ((rxcount = cgc_receive_until(s.input, '\n', 16)) == 0) {
#endif
			if (rxcount == 0) {
				cgc__terminate(1);
			}
	    }

		if (s.input[cgc_strlen(s.input)-1] == '\n') {
			s.input[cgc_strlen(s.input)-1] = '\0';
		}

		// see if the player just wants to display the board
		if (!cgc_strcmp("9", s.input)) {
			cgc_PrintBoard(b);
			continue;
		}

		// see if the player wants to cgc_exit
		if (!cgc_strcmp("666", s.input)) {
			return(0);
		}

		if (cgc_strlen(s.input) > 7) {
			cgc_puts("incorrect input");
			cgc_puts("Not a legal move format");
			continue;
		}

		// try to parse move
		coord1 = coord2 = NULL;
		for (i = 0; i < cgc_strlen(s.input); i++) {
			if (s.input[i] == ' ') {
				s.input[i] = '\0';
				coord2 = s.input+i+1;
				coord1 = s.input;
			}
		}
		if (coord1 == NULL) {
			cgc_puts("incorrect input");
			cgc_puts("Not a legal move format");
			continue;
		}

		// parse each coordinate
		if (!cgc_strchr(s.allowed_chars, coord1[0]) ||
		    (coord1[1] != ',') ||
		    !cgc_strchr(s.allowed_chars, coord1[2]) ||
		    cgc_strlen(coord1) != 3) {
			cgc_puts("incorrect input");
			cgc_puts("Not a legal move format");
			continue;
		}
		*srcx = coord1[0] - '0';
		*srcy = coord1[2] - '0';
		if (!cgc_strchr(s.allowed_chars, coord2[0]) ||
		    (coord2[1] != ',') ||
		    !cgc_strchr(s.allowed_chars, coord2[2]) ||
		    cgc_strlen(coord2) != 3) {
			cgc_puts("incorrect input");
			cgc_puts("Not a legal move format");
			continue;
		}
		*dstx = coord2[0] - '0';
		*dsty = coord2[2] - '0';

		break;
	}

	return(1);
}


Move to version <IP_ADDRESS>

Description
Move to version <IP_ADDRESS>
Keeping the default OpenSearch build version to 1.3.0 until we have
resolved the breaking changes from core.
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is this PR only bumping security plugin version, but not bumping the OpenSearch dependency version? If so, can we clarify that in the PR title?

@cliu123 The PR description and commit message has this information

@cliu123 The PR description and commit message has this information

Ok. The security plugin version will be <IP_ADDRESS>. Updated the PR title and description.
LGTM!

Codecov Report

Merging #1695 (136a985) into main (e638c76) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1695      +/-   ##
============================================
- Coverage     62.94%   62.89%   -0.06%
+ Complexity     3261     3259       -2
============================================
  Files           253      253
  Lines         18126    18087      -39
  Branches       3258     3255       -3
============================================
- Hits          11410    11375      -35
+ Misses         5067     5063       -4
  Partials       1649     1649

Impacted Files
Coverage Δ

.../org/opensearch/security/support/Base64Helper.java
67.85% <0.00%> (-4.78%)
:arrow_down:

...ecurity/configuration/ConfigurationRepository.java
73.07% <0.00%> (-2.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e638c76...136a985. Read the comment docs.


True vs mc

Corrections and changes made in pull request #31 incorporated
New module for time uncertainty computation, instead of doing it inside TimeDistDiff

Thanks for this @mcolomermolla.  I suppose one can make this more generic by not requiring a particular pair of detectors?
The code may also be simpler using the alert() method, rather than update().
While looking through this, it occurred to me another (possibly clearer and more re-usable) arrangement could be as follows:

JUNO
IceCube
TimeDistDiff, observing JUNO and IceCube
a true time diff module (which just takes the diff between the true times in the payloads), also observing JUNO and IceCube
a comparison module which takes the difference between the dt's calculated in (3) and (4)

In order to keep the order of subtraction the same (i.e., JUNO - IceCube, or vice versa?), you can call Node.last_watch_index(), which gives you the index of the upstream node.  If you observe with ["IceCube","JUNO"], then an IceCube payload will come with an index 0, and JUNO with an index 1.
(By the way, I asked Sihan, one of our new students, to look at calculating the true times - relative to the neutrino wavefront passing the center of the Earth, or something like that - for each detector given a distant supernova in some given direction.  Do you already have code for something like this, for example, for use in TG3?)

Yes, in principle we could generically call det1 and det2.
Then, the point is that the two detectors (e.g. JUNO and IceCube) when called in the csv file, take from this config file the .txt (with the provided time profile from each detector). Where/how would be the best way to retrieve these data from the experiments?
For the steps, I fully agree, and it is actually the case how it is now. Just:
i) After 1) and 2) there is the Combine.py which enters
ii) I don't think 4) and 5) need to be separate modules, this will delay the chain, it can be done in the same one as now in True_VS_mc
Yes, this is in the code I sended you yesterday by email ! He can start having a look at it

I have taken into account all your comments in the new commits I pushed today.
Let me know if you have any additional comments or suggestions, and please feel free to modify whatever you consider convenient.

Thanks.  Let's go with this and evolve it along with all the other code.

@mcolomermolla please check that I resolved the merge conflict correctly. Thanks.

@mcolomermolla please check that I resolved the merge conflict correctly. Thanks.

How can I see which the conflict was? In principle everything seems ok to me however.

Just click on the last commit.

OK, yes, that's fine!
(I though this change in TimeDistDiff was already in the master, strange)


Add nil safe operator

Takes care of #147
Only thing this doesn't work on is when the env struct is predefined before compiling due to OpEqualString and OpEqualInt optimizations doing type casts.
Not completely happy with the way it's implemented, but it was the easiest to do without changing much core code.

Hmm just noticed this also doesn't short circuit the chain, so something like this: foo?.missing.test() == '' && bar['missing'] == nil would still fail. I'll see what I can do to fix that...

Awesome work! 👏 I'll try to take a closes look at this before merging.

Any news on this PR? :)

Sorry for delay! @davidklassen can you also take a look? Thanks.

LGTM

Found an error. In this case error should be returned, but instead  is returned.
package main

import (
	"fmt"

	"github.com/antonmedv/expr"
)

type S struct {
	S *S
	A string
}

func main() {
	env := map[string]interface{}{
		"s": S{S: &S{S: &S{A: "OK"}}},
	}

	code := `s?.S.NOPE.A`

	program, err := expr.Compile(code, expr.Env(env))
	if err != nil {
		panic(err)
	}

	output, err := expr.Run(program, env)
	if err != nil {
		panic(err)
	}

	fmt.Println(output)
}

Part with S.NOPE should throw error as not nil safe.
@zachbadgett can you take a look? Thanks.

The problem is with parser:
go run github.com/antonmedv/expr/cmd/exe -ast <<< 'a?.b.c'
PropertyNode{
	Node: PropertyNode{
		Node: IdentifierNode{
			Value: "a",
			NilSafe: true,
		},
		Property: "b",
-		NilSafe: true,
	},
	Property: "c",
-	NilSafe: true,
}

One year later, I think this is not error any more)))


some update

Fixes #ISSUSE_ID.
Changes proposed in this pull request:

support rename table and column
add MySQL alter table  composite operate for column
refresh proxy fro create table

Pull Request Test Coverage Report for Build 6146

26 of 41 (63.41%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 72.724%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/extractor/impl/definition/column/RenameColumnDefinitionExtractor.java
4
5
80.0%

sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/extractor/impl/definition/table/RenameTableExtractor.java
3
4
75.0%

sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/filler/impl/RenameTableFiller.java
5
6
83.33%

sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/filler/impl/ddl/RenameColumnFiller.java
8
10
80.0%

sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/backend/jdbc/JDBCBackendHandler.java
0
10
0.0%

Totals

Change from base Build 6145:
0.002%

Covered Lines:
9420

Relevant Lines:
12953

💛  - Coveralls


IRC channel

Could you please setup an IRC channel for gStore? Perhaps on freenode. Would be really useful to chat and get support.

As you wish, freenode #gStore


Remove Highlighting from typeaheads.

Added a common template typeahead_list_item.handlebars which is used by all the typeaheads. Eliminated calls to highlight_with_escaping from typeaheads. Further improvements to the look of the typeaheads can easily be done by modifying the template.
This is a follow-up for #5170.

Automated message from Dropbox CLA bot
@akhilmd, it looks like you've already signed the Dropbox CLA. Thanks!

I've been able to test this manually in my dev env and works great!
Got a couple questions:

Why do you .trim() the attributes/text you read in the tests?
Do we want to use bold in the cases when there will never be a secondary value? It looks a bit weird to me in the case of emoji typeahead (although I guess it's a matter of taste):

Looks good to me otherwise! Nice job, @akhilmd.

Thanks for the prompt review @YagoGG!
For the sake of a consistent UI, I feel that primary values across all typeaheads should have the same look. We should use something that would look good in most cases.

Yeah, I agree with you about having a consistent UI.
I guess that we can see how people feels about it, and if we get more user feedback we could consider making some modifications in the future.

Merged! thanks @akhilmd!


Feature 53

Checklist ✅

[x] I have followed the contributor guideline
[x] Tests are included
[x] Documentation is changed or added
[x] Related issue has been created
[x] Commits messages follows commit guideline

resolves [# 53]

You remember adding the info to Side Bar as: Reviewers, assigners, Labels, Projects, Milestone and Issue. too, add screenshot of the component in the PR.
Additional: My personal recommendation is to name the PR with the Issue Name, example: Feature 53 - Footer Component


Remove 'ssd1306' crate from dependencies in Nano 33 IOT

The ssd1306 crate is a display driver and has nothing to do with the board itself. The only place I can find it is in the i2c_ssd1306 example.

Go for it! I believe dependencies for examples Can be moved to dev-dependencies


Negative matcher should be failed if have_enqueued_job have 1 or more jobs

Fixing issue #1870
Examples:
ExampleJobs.perform_later
ExampleJobs.perform_later

expect(ExampleJobs).not_to have_enqueued_jobs(ExampleJobs)

It should be failed, but in our current negative matcher above will be passed because we have more than one jobs and in our current code is checking for exactly one jobs.
We can hack current state without changing any code with:
expect{ my_job.perform }.to have_enqueued_job(OtherJob).exactly(0).times
but it's wierd.

This changes the behaviour of the positive version, whats needed is to change how this is checked when negated only.

@JonRowe but in my logic, when we initialize this matcher without any arguments it will be at least one, not exactly one.
But, will try to only change the negated only

@whatdacode no it's exactly once to match the semantics of other rspec matchers.

@JonRowe okay, will fix it soon

@JonRowe Sorry, what do you mean about semantics? Incremental of jobs count?

@awcodify Semantics is the meaning of something. The matchers which perform similar tasks to this one use exactly once as a default, thus the positive version of this matcher needs to maintain its exactly once default in order to maintain its meaning. You cannot change its default behaviour.

@JonRowe Would you care to elaborate why the default is "exactly once"? I totally agree to be consequent but I'm curious as to why that would be more correct.
From reading the following specs I think it would be correct to assume "at least once":
# Should pass, does pass.
expect {
  MyJob.perform_later
}.to have_enqueued_job(MyJob)

# Should pass, does not.
expect {
  MyJob.perform_later
  MyJob.perform_later
}.to have_enqueued_job(MyJob)

# Should fail, does not.
expect {
  MyJob.perform_later
  MyJob.perform_later
}.not_to have_enqueued_job(MyJob)

This goes for the have_received matcher as well:
# Should pass, does pass.
my_spy = spy('spy')

my_spy.expected_method

expect(my_spy).to have_received(:expected_method)

# Should pass, does not.
my_spy = spy('spy')

my_spy.expected_method
my_spy.expected_method

expect(my_spy).to have_received(:expected_method)

# Should fail, does not.
my_spy = spy('spy')

my_spy.expected_method
my_spy.expected_method

expect(my_spy).not_to have_received(:expected_method)

Would you care to elaborate why the default is "exactly once"?

As you have shown this is ambiguous as to how it is interpreted, but which is correct is a matter of opinion. The current code has an established behaviour and thus we cannot change it without a major release and considering it is a matter of interpretation it won't change.

@JonRowe Definitely. No hard feelings at all. :)

@JonRowe so, in simple it means we can't change our long established behaviour, right? So, this is a known as issue, but don't 👍 . And we can't change because of major behaviour?
Still we need this PR or not?

@awcodify Exactly. He said it would be fine to make an exception for this matcher though. Basically implementing a custom version of the negated matcher to make it work as intended.
Do you want to implement this in another PR or should I? :)


[ptftest] Add decorator use_flow for test case fixture setUp/tearDown

Decorator use_flow can be used to enable flow lookup stage in p4 pipeline. It wrappers method setUp/tearDown of test class.

Author used P4 runtime directly to add a fixture to add underlay routing
PTF not using .py tests, so we will add more of a description and example
fyi SAI Challenger uses .py test


Finish finddungeon and finddungeons

Ask River about how to determine "priority" when one query matches multiple dungoens

hmm, good question. I think we'd probably want to do a combined heuristic based on J-W and release date of the dungeon. Nothing too fancy but like...
Sort by J-W when the gap is at least .05
when the gap is less than .05 sort by release date, maybe?
.05 may be too big, but for some constant like this. We can try on a few searches and see.


pgmq_list_queues errors if no queues were created

Extension version: 0.10
Postgres version: 15.3 (I'm running your docker image)
Current behaviour
Running select * from pgmq_list_queues() throws an error if no queues were created yet:
SQL Error [42P01]: ERROR: relation "public.pgmq_meta" does not exist

Expected behaviour
An empty result set.

This happens because some setup necessary setup is conditionally performed on create_queue, and list_queues doesn't check if such setup was performed, nor runs it.

I think we can solve this my moving it into the extension's sql, which will have that create table statement ran on create extension pgmq

Seems like a good approach. I can try sending a PR with this fix.

Seems like a good approach. I can try sending a PR with this fix.

Awesome! pgrx has a macro to help with that. Macro can reference a .sql or the sql can live in Rust directly
Let me know if you run into problems. There might be some unwinding needed of the create_*() stuff in ./core

I have written this:  https://github.com/tembo-io/pgmq/commit/0c2b8829dc57b59054b95e332b41b7d2d9a7decd
But it has a few problems:

Schema and table name are hardcoded
I didn't build it locally yet

The project is hard coded to the public schema at the moment, but we want to change that eventually to be set whatever comes on the create extension statement. e.g. create extension pgmq schema my_schema would put that in my_schema. So hardcoding it now is no different than how things are currently set up.

pgrx.

Fixed in https://github.com/tembo-io/pgmq/pull/66
pgmq=# create extension pgmq;
CREATE EXTENSION
pgmq=# \dt
            List of relations
 Schema |   Name    | Type  |   Owner
--------+-----------+-------+------------
 public | pgmq_meta | table | adamhendel
(1 row)

pgmq=# select * from pgmq_meta;
 queue_name | created_at
------------+------------
(0 rows)

pgmq=# select pgmq_list_queues();
 pgmq_list_queues
------------------
(0 rows)


Specified key was too long; max key length is 767 bytes'

As I am trying to "python -m cvrparser dbsetup -t" I get the following error,
---- CREATE TABLES ----
Create Tables
Creating Table Aarsbeskaeftigelse
Creating Table AarsbeskaeftigelseInterval
Creating Table AdresseDawa
Creating Table Adresseupdates
Creating Table Attributter
Creating Table Branche
Traceback (most recent call last):
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1193, in _execute_context
    context)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/default.py", line 509, in do_execute
    cursor.execute(statement, parameters)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 250, in execute
    self.errorhandler(self, exc, value)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/connections.py", line 50, in defaulterrorhandler
    raise errorvalue
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 247, in execute
    res = self._query(query)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 412, in _query
    rowcount = self._do_query(q)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 375, in _do_query
    db.query(q)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/connections.py", line 276, in query
    _mysql.connection.query(self, query)
_mysql_exceptions.OperationalError: (1071, 'Specified key was too long; max key length is 767 bytes')

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/anaconda3/envs/Virk/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/anaconda3/envs/Virk/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/cvrparser/__main__.py", line 125, in <module>
    getattr(Commands, args.pop('command'))(**args)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/cvrparser/__main__.py", line 18, in dbsetup
    crdb.create_tables()
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/cvrparser/cvr_makedb.py", line 22, in create_tables
    self.alchemy_model.create_tables()
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/cvrparser/alchemy_tables.py", line 406, in create_tables
    x.__table__.create(engine)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/schema.py", line 779, in create
    checkfirst=checkfirst)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1940, in _run_visitor
    conn._run_visitor(visitorcallable, element, **kwargs)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1549, in _run_visitor
    **kwargs).traverse_single(element)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/visitors.py", line 121, in traverse_single
    return meth(obj, **kw)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/ddl.py", line 796, in visit_table
    self.traverse_single(index)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/visitors.py", line 121, in traverse_single
    return meth(obj, **kw)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/ddl.py", line 823, in visit_index
    self.connection.execute(CreateIndex(index))
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 948, in execute
    return meth(self, multiparams, params)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/sql/ddl.py", line 68, in _execute_on_connection
    return connection._execute_ddl(self, multiparams, params)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1009, in _execute_ddl
    compiled
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1200, in _execute_context
    context)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1413, in _handle_dbapi_exception
    exc_info
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/util/compat.py", line 265, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/util/compat.py", line 248, in reraise
    raise value.with_traceback(tb)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/base.py", line 1193, in _execute_context
    context)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/sqlalchemy/engine/default.py", line 509, in do_execute
    cursor.execute(statement, parameters)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 250, in execute
    self.errorhandler(self, exc, value)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/connections.py", line 50, in defaulterrorhandler
    raise errorvalue
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 247, in execute
    res = self._query(query)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 412, in _query
    rowcount = self._do_query(q)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/cursors.py", line 375, in _do_query
    db.query(q)
  File "/anaconda3/envs/Virk/lib/python3.6/site-packages/MySQLdb/connections.py", line 276, in query
    _mysql.connection.query(self, query)
sqlalchemy.exc.OperationalError: (_mysql_exceptions.OperationalError) (1071, 'Specified key was too long; max key length is 767 bytes') [SQL: 'CREATE UNIQUE INDEX branche_index ON `Branche` (branchekode, branchetekst)'] (Background on this error at: http://sqlalche.me/e/e3q8)

I thought the problem could the charset - so I changed the config.ini but also within the mysql environment using ALTER DATABASE virkdb CHARACTER SET utf8 COLLATE utf8_general_ci;.
As a background information, I could setup the regnskab package (download the two large tables).

I do not have this error. I am guessing it is some sort of strict check in mysql since i can only get an error if i actually insert a key that is to long. I really need to make  better unique string key solution i am not to happy with but have not had the time.

The easiest thing is to reduce the string length of branchetekst to less than 188. It seems the strings i currently have in my local copy of the data which is somewhat outdated is 115.
I guess the best solution is to actually change it to text so no surprises come when new industri long industri descriptions suddenly appear and then handle the unique constraint in my program. I am not going to change that anytime soon. It is cause by the fact that industri code keys are not unique and have changed meaning over time, so the really best thing is to annotate the industri code with a reference to the specification it came from see https://www.dst.dk/da/Statistik/dokumentation/nomenklaturer/dansk-branchekode-db07#


proton.json: Add Proton 5.13 (1420170) and use it as default

https://steamdb.info/app/1420170/
https://github.com/ValveSoftware/Proton/releases/tag/proton-5.13-1b

@Lucki If you would like to release version 0.2.1 for the new Proton, you can open "Release 0.2.1" PR after merging this.

Not sure about this. 5.13 is still beta and has some huge regressions: https://github.com/ValveSoftware/Proton/issues/4289

I can't approve this. Using 5.13 in opengl mode (our default) crashes my gnome shell. DXVK works though (after I've activated the workaround again?).
Also controller hot-plugging worked to my surprise, not sure what's that known bug is about then…
Also there's a new error in the log when closing the game: wine: Unhandled page fault on read access to 00007F87F3743B30 at address<PHONE_NUMBER>125029 (thread 0108), starting debugger...

OK, thanks for the information. Let's wait at least until the known issues are fixed.

Using 5.13 in opengl mode (our default) crashes my gnome shell.

While in plasma I retested this and it seems working there so this might be somehow related to gnome.


Addresses #114 NTR catecholaminergic neuron

Addresses #114 NTR catecholaminergic neuron

#gogoeditdiff

It is strange that only noradrenergic neuron is inferred as a subclass of this term.

In GO this classes are inferred as SubclassesOf catecholamine secretion, neurotreansmission:

However, this is not reflected in CL:

@matentzn probably a justification for "base-plus".

@aleixpuigb I have a guess about this. GO gets this subsumption using some behind-the-scenes GCIs for CHEBI that aren't included in our base file. If CL is building on the GO base file, some necessary axioms might be missing.

Thank you, @balhoff! That makes it clear.

@balhoff - my first thought was that if base is build from go-plus it should have all the necessary axioms - and if not, this is a misfeature of the GO build.  But, thinking about it, there is a ticket somewhere about derivation of base and the problems of retaining GCIs.  I'd like to look again at how we might solve that problem as I increasingly have use cases for GCIs.  CC @matentzn

@dosumis you are right, I would call it a misfeature of go-base. I'm not sure that we should spread these CHEBI GCIs out into other ontologies (I'm referring to the "biochebi" stuff). But we need to include the reasoning results into go-base if don't don't include those GCIs.


Duplicating pull request from youtube-dl to yt-dlp

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS> (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Question
I just opened a pull request in the youtube-dl repository. Since I use yt-dlp and not the original, I also want it implemented here. Should I open a pull request here too or wait for you to rebase?
The README has me confused on what to do. First it says

The main focus of this project is adding new features and patches while also keeping up to date with the original project

Then it says

Based on youtube-dl 2021.12.17 commit/8a158a9

Verbose log
No response

Open a duplicate PR if you want it to be directly merged into yt-dlp. If you only want it to be pulled into yt-dlp after it has been merged in youtube-dl, you don't need to do anything.
Note that the two projects have differing contribution guidelines. Your PR will be merged here directly only if you follow our guidelines and address our reviews. On the other hand, if it is being pulled from upstream, the code will be treated as "legacy" and merged as-is without concern for code style

Could you clarify how that is confusing?

If I'm interpreting it correctly, the last merge was half a year ago, which to me doesn't seem like keeping up to date. I'd suggest adding a note about there possibly being a long time between merges with youtube-dl.

Open a duplicate PR if you want it to be directly merged into yt-dlp. If you only want it to be pulled into yt-dlp after it has been merged in youtube-dl, you don't need to do anything.
Note that the two projects have differing contribution guidelines. Your PR will be merged here directly only if you follow our guidelines and address our reviews. On the other hand, if it is being pulled from upstream, the code will be treated as "legacy" and merged as-is without concern for code style

Thanks for the quick reply. I'll open a pull request here then.
Also, was this stated somewhere that I missed? If that isn't the case, I'd suggest that it is added here.

Also, was this stated somewhere that I missed? If that isn't the case, I'd suggest that it is added here.

No. For now, I have linked this issue to the FAQ section of https://github.com/yt-dlp/yt-dlp/issues/3766


Feature/lyrics api

The command makes use of genius.com API to fetch lyrics of the requested song, if it is present in their database, else returns an error message.
For excessively large lyrics data, it returns the link to the site rather than embedding the lyrics.

@amanjha8100 please merge 🥲


code/data for reproducibility

Dear @mgruppi,
Thanks for the interesting research! I would like to investigate your method further. Much appreciated if you could share the codes/data for reproducibility.
Kind regards,
Ipek

Hi @isspek, thank you for your interest and sorry that we don't have the code and data up yet.
The work was under review not too long ago.
We plan on having the code and data available soon.
Best,
Mauricio


Content Corrections.

Why: Content Corrections.
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@SumaiyaTarannumNoor Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

Internal: asking about failed check here

@nguyenalex836 Thank you for the merge. 😊😊

Your welcome


Decoder implementation w/ scan and remat

This is resolved as a part of #23. Maybe I should've split the PR into multiple PRs, but I guess it's too late lol


add codecov-cli and deps

These changes were made by following the exact instructions on Readme.md, that is, running python3 -m add_pkg codecov-cli.
This is used in the codecov-ats.yml workflow and currently requires the extra index to Pypi to be installed.
See: https://github.com/getsentry/sentry/blob/d069119cee5dfc887cf3f0744e4c8ebdf9be8a9c/.github/workflows/codecov_ats.yml#L76C100-L76C100

Blocked by https://github.com/codecov/codecov-cli/pull/326 (to remove smart-open) and pending a new release being made


Update README.md

This PR is not linked to a task in ClickUp.  Please add the task ID starting with "CU-" (e.g. CU-1umz2q2) as the first word in the title.
To create a new task in the list click here.


ci-automation: Allow git to work on directory owned by other user

The get_git_channel function failed to work which resulted in the Alpha release job skipping the AWS publishing for the Alpha channel because it defaulted to the developer channel as fallback when git rejected to work on the directory owned by the build user while running as root user. A new version of git caused this behavior change and also prints an error message that explains to have to set safe.directory.
Set the git config entry safe.directory for the /work path when entering the mantle container where git runs as root while working on the directory owned by the build user.
How to use
Either test it by creating a new Alpha release tag that has this change and then rerun the release job from that git tag, or merge, cherry-pick the change, and retag Alpha and rerun the release job from that git tag.
Testing done
None

Oh, right, we need it for all channels, will do.

Ah, wait, I already did that but I missed the new beta major version because it wasn't on an active channel at that time.

Done, in the future I think we should better only do channel transitions only when we release all channels


Adding Id-Config overrides Config functionality

:id-config and :config don't play well together.  If I have just :config the buttons are removed from the toolbarRight but when I add :id-config the buttons reappear.
Configuration:

Web browser and it`s version: Chrome
Operating system and it`s version: Win 10
vue-pdf-app version: 2.1.0

Steps to reproduce the problem:
<vue-pdf-app :id-config="pdfIdConfig" :config="pdfConfig" :pdf="pdfDocument" style="height: 75vh;"></vue-pdf-app>
<BButton variant="primary" :id="pdfIdConfig.print">Print</BButton>

  data() {
    return {
      pdfIdConfig: {
        print: "printId",
      },
      pdfConfig: {
        toolbar: {
          toolbarViewerRight: {
            openFile: false,
            viewBookmark: false
          }
        }
      },
    };
  }

What is the expected behavior?
In my example bookmark and file open on toolbar would be hidden and print button would work
What went wrong?
toolbar buttons are not hidden
Attachments (screenshots, links, etc)

Hi! Yes, I confirm a bug


Make grad accum steps mutable on the Accelerator object

Mild regression and expansion on the new gradient accumulation API change.
Keeps all main areas of the gradient_state to be mutable if needed/wanted from the Accelerator object that users may wish to do (so sync_gradients and gradient_accumulation_steps)
Solves https://github.com/huggingface/accelerate/issues/1230

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Thank you for the quick fix and the test, @muellerzr - I validated it's back to working again.


Some cleanup of UnitOfWork

I removed duplications of the validation checks, now the methods are more in one level of abstraction.
Also fixed some typos and some minor PDM stuff, mostly spaces and brace positions.

@agarciaffdc these looks good to me. I added a review as well.

@agarciaffdc & @afawcett I have updated this PR and also refactored the commitWork method, to improve readability.

@wimvelzeboer thanks for your latest contribution. Really appreciate it.


Fix ticks leak

fix time.Ticker leaks
optimize ordering.EventBuffer to use lazy iteration of incomplete events
decrease maximum buffer size of ordering.EventBuffer from 2048 to 1024

Codecov Report

Merging #564 (2e921fc) into develop2 (a8b225e) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##           develop2     #564      +/-   ##
============================================
+ Coverage     46.51%   46.53%   +0.01%
============================================
  Files           169      169
  Lines         11202    11206       +4
============================================
+ Hits           5211     5215       +4
+ Misses         5467     5466       -1
- Partials        524      525       +1

Impacted Files
Coverage Δ

gossip/emitter.go
39.18% <0.00%> (-0.12%)
:arrow_down:

gossip/handler.go
49.18% <ø> (ø)

gossip/packsdownloader/peer_downloader.go
15.18% <0.00%> (-0.10%)
:arrow_down:

gossip/ordering/event_buffer.go
71.42% <100.00%> (+1.42%)
:arrow_up:

evmcore/tx_pool.go
74.73% <0.00%> (-0.91%)
:arrow_down:

inter/ascii_scheme.go
82.53% <0.00%> (+2.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b225e...2e921fc. Read the comment docs.


add bitnami helm test

This test currently fails with
kafka 16:05:25.%2N ERROR ==> The KAFKA_CFG_LISTENERS environment variable does not configure a secure listener. Set the environment variable ALLOW_PLAINTEXT_LISTENER=yes to allow the container to be started with a plaintext listener. This is only recommended for development.

After https://github.com/wolfi-dev/os/pull/6777 this now fails with
  kafka 13:05:33.%2N INFO  ==> ** Starting Kafka setup **
  kafka 13:05:33.%2N INFO  ==> Initializing KRaft storage metadata
  kafka 13:05:33.%2N INFO  ==> Adding KRaft SCRAM users at storage bootstrap
  kafka 13:05:33.%2N INFO  ==> Formatting storage directories to add metadata...
  /opt/bitnami/kafka/bin/kafka-run-class.sh: line 346: /opt/bitnami/java/bin/java: No such file or directory


Update xmlc-aeonclassic.json

just updating the logo, I was surprised to see this already here :smiley_cat:

got it thanks!


paths and moduleDirectory Conflict?

I have the following in my .eslintrc.json file:
"settings": {
  "import/resolver": {
    "node": {
      "moduleDirectory": ["src"]
    }
  }
}

When the "moduleDirectory" property is set VS Code does not complain about absolute imports (import/no-unresolved)
However, when I run eslint from the command-line, it throws a bunch of import/no-unresolved errors. If I set the "paths" property instead of "moduleDirectory", eslint no longer complains when run from the command line.
"settings": {
  "import/resolver": {
    "node": {
      "paths": ["src"]
    }
  }
}

But then VS Code throws the import/no-unresolved errors. My natural thought was that I just need to set both "paths" and "moduleDirectory", but this does not seem to work. VS Code is fine, but eslint from command line is not. When "moduleDirectory" is present it seems that the "paths" property is ignored.
"settings": {
  "import/resolver": {
    "node": {
      "moduleDirectory": ["src"],
      "paths": ["src"]
    }
  }
}

Setting "import/no-unresolved": "off" gets rid of the errors, but that's not how I want to them to go away.
Thoughts?

This is likely caused by your vscode settings not correctly scoping to the project dir.
The correct settings are always "what works on the command line"; anything else is a bug in yhour editor.


Where to manage change info regarding fixes?

dachar version: *
Python version: *
Operating System: Linux

Description
Proposed stores:

Dataset Character Store
Analysis Results Store
Fix Store

We should record the history of changes. I propose that:

The Fix Store only records the current Fixes that are published.
The Analysis Results Store records the history, including:

proposed fixes
rejected fixes
published fixes
withdrawn fixes

This has now been implemented, so closing the issue.


Debugging NaxRiSC V CPU in Verilator terminal and On chip debugger for NaxRiSC V

I am wondering of on chip debugger for NaxRISC V to monitor the change in register value like of CSR and any other variable.
If i have to run in Verilator terminal as of II. b) Debug Briey SoC with Verilator +OpenOCD + GDB
https://thuchoang90.github.io/project/2020/07/23/VexRiscv.html
like src/openocd -f tcl/interface/jtag_tcp.cfg -c "set NAX_CPU0_YAML /home/hsubedi/RISC_V_PROJECT/NaxRiscv/cpu0.yaml" -f tcl/target/Nax.cfg
I am wondering Why there is no Nax.cfg in https://github.com/SpinalHDL/openocd_riscv/tree/riscv_spinal/tcl/target
but for demo there is briey.cfg

Mostly, NaxRiscv used the regular RISC-V debug spec instead of a custom one, so doesn't realy need the openocd fork.
tcl script used are in https://github.com/SpinalHDL/NaxRiscv/tree/main/src/main/tcl/openocd

Thank you
https://github.com/SpinalHDL/NaxRiscv/blob/main/src/main/scala/naxriscv/debug/EmbeddedJtagPlugin.scala#L85
in this github link in from line 85 there is few useful tool to debug but i am not sure how to use it

EMBEDDED_JTAG is automaticaly set by scala code via getService[DocPlugin].property("EMBEDDED_JTAG","1") which endup into nax.h (generated by DocPlugin) and then i used by the testbench cpp

who is instantiating EmbeddedJtagPlugin?

It is a optional part of the Config.plugins function :
https://github.com/SpinalHDL/NaxRiscv/blob/3727ce674d26c98df68e257778aa93da93837c40/src/main/scala/naxriscv/Gen.scala#L91

Does changing withDebug and withEmbeddedJtagTap to true would help in debugging ?

Yes, you need them both

Then, in a compiled openocd, i use src/openocd -f ../NaxRiscv/src/main/tcl/openocd/naxriscv_sim.tcl to connect to a running simulation

But you have to run the simulation with  ./obj_dir/VNaxRiscv --timeout-disable --spike-disable


Installation of ESMValTool on OSX

HI,
A couple of the new ESMValTool users, @koir-su and @ytakano3 have had some issues with the installation of ESMValTool on their Mac OSX laptops at @zklaus's Crescendo Workshop.  For instance, @koir-su had to install the glib library before the esmvaltool environment could be created. @ytakano3 had to manually update his local conda installation.
I've added a couple extra lines to the installation documentation here but conda put up quite a fight before surrendering and this by itself might not be sufficient.
Most of the core ESMValTool developers seem to be using linux machines for their code development so we might be able to help with all Mac installations questions. This github issue was created to direct future users questions about installing ESMValTool on Mac OS.

We're encountering some OSX specific errors when running the unit tests:
python setup.py test

It's almost as if the OSX conda environment is not catching all the requirements and correct versions needed. Any one have any ideas?

@jvegasbsc just told us yesterday he had to fight a Mac too

Awesome! If @jvegasbsc could give some hints, that'd be great!

Thanks @ledm and @valeriupredoi , would be great if @jvegasbsc could share the yml of the conda environment that works on a mac.

note that we are in the process of moving to iris=2.2.0 and have a branch that will be merged in the trunk very soon; that entailed a few environment changes so I'd say you guys wait until that happens just in case the new slightly modified environment would not create a whole heap of new OSX issues

Sounds good, V. Keep us posted here. At some point, I had the tool running with the latest of all packages, i.e., with iris 2.2.0. When the time came for tests, there was an error saying the cube arithmetic between integer and float data objects is not possible. Just something to keep in mind during the update.

@koir-su yes we ran into those issues ourselves last week - we fixed them in https://github.com/ESMValGroup/ESMValTool/pull/832 and as soon as people run their test recipes and confirm all's good we will merge that into trunk and ready for you guys to test the environment installation

So, is the installation on OSX working properly at the moment? Should we add Mac specific installation instructions?

afraid I haven't actually touched a Mac since ages :grin: Maybe someone will bring a Mac to the workshop or @mattiarighi or @hb326 can get their hands on one? If so I will volunteer to smash it..ahem, try install the tool on it

So, is the installation on OSX working properly at the moment?

I just updated my environment yesterday to prepare for the workshop and found no problem. I have not done a clean installation for a while, though.

Should we add Mac specific installation instructions?

The question is, ¿can we test the MacOS installation automatically? If we can, I think we can make the extra effort to support it

I have not tried installing it again. Last time the issue was somewhat related to the iris. If that has been resolved, I can give it a go.

closing this since the installation procedure has changed quite a bit since February and we have a working method in #1253 please comment and work out stuffs there


Rasbian documentation update : add required dependencies for RandR library, libusb and GTK+

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Raspbian Stretch with desktop : 2018-11-13

Kernel Version (Linux Only)
4.14

Platform
Raspberry Pi

SDK Version
2.19.1

Language
python

Segment
Documentation

Issue Description
Was following the instruction to build librealsense on Rasbian. There are two issues

During the build step of librealsense, ./configure complains about missing RandR library and gtk+-3.0, libusb the documentation needs to be updated with following commands

sudo apt-get install libusb-1.0-0-dev
sudo apt-get install xorg-dev libglu1-mesa-dev
sudo apt-get install build-essential libgtk-3-dev

Is protobuf required, I built the library without it (because of build issues), and its working perfectly fine.

Hi @RitwikSaikia
Thank you for the report
Please consider opening a pull-request with your findings


Add SASS/SCSS support

Hi,
if I try to add a main.scss file from main.js, I always have an error like:
This relative module was not found:

* ./main.scss in ./src/main.js

The same behaviour with SASS files.
I'm also trying to use SCSS inside the style tag in my VueJS components and pages.
I've installed the sass-loader and the node-sass, but if I edits the style tag adding the lang="sass" and the . type="text/scss" attributes, I have the following error:
@media (min-width: 960px) {
                          ^
      Invalid CSS after "...width: 960px) {": expected "}", was "{"
      in /Users/lucacaprini/Development/Projects/CordovaF7Vue/src/app.vue (line 60, column 28)

 @ ./node_modules/vue-style-loader!./node_modules/css-loader?{"sourceMap":true}!./node_modules/vue-loader/
lib/style-compiler?{"vue":true,"id":"data-v-5ef48958","scoped":false,"hasInlineConfig":false}!./node_modul
es/sass-loader/lib/loader.js?{"indentedSyntax":true,"sourceMap":true}!./node_modules/vue-loader/lib/select
or.js?type=styles&index=0!./src/app.vue 4:14-383 13:3-17:5 14:22-391
 @ ./src/app.vue
 @ ./src/main.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server ./src/main.js

Can you help me to adding SCSS support in this template?
Thanks

Add node-sass module resolve the problem.
Thanks


SpreadSheet custom map add x: to defaultNamespace

Changing an OpenEmlElement in a CustomXmlMapping adds the prefix x to the default namespace.
This results in the new xlsx file cant map to the schemas in excel.

+1
I've the same problem using DocumentFormat.OpenXml.Spreadsheet.MapInfo that's write xl\xmlMaps.xml file inside xlsx package.
With prefix x: for default namespace http://schemas.openxmlformats.org/spreadsheetml/2006/main excel do not recognise properly xml maps.
Removing manually the x: prefix it works like a charm.

This is how I solved it
                    //add the default namespace without prefix -> this is a hack                     var mapOuterXml = spreadsheetDocument.WorkbookPart.CustomXmlMappingsPart.MapInfo.OuterXml;                     var xml = new XmlDocument();                     xml.LoadXml(mapOuterXml);                     if (xml.DocumentElement != null) xml.DocumentElement.SetAttribute("xmlns", "http://schemas.openxmlformats.org/spreadsheetml/2006/main");                     spreadsheetDocument.WorkbookPart.CustomXmlMappingsPart.MapInfo = new MapInfo(xml.OuterXml);                     //hack ended
But I dont like the solution...

your last comment is self describing: it is an hack! ;-)
Saving an xlsx file using ms excel the default namespace (without prefix) is http://schemas.openxmlformats.org/spreadsheetml/2006/main. But in the library in the file DocumentFormat.OpenXml.NamespaceIdMap.cs each namespace has a prefix.
Defining a xml default namespace for each output file seems an elegant solution like:

xlsx - http://schemas.openxmlformats.org/spreadsheetml/2006/main
docx- http://schemas.openxmlformats.org/wordprocessingml/2006/main
...

I've tried to remove the "x" value with "" from the _namespacePrefixList string array in NamespaceIdMap class and it works on excel.
This behaviour could be related to #34

Hi broegger111, there have been significant changes to the SDK in the past few months. Can you please verify whether or not this is still a problem that is occurring? If this is still a problem, could you please post some sample code that reproduces the issue?
Thank you.

@broegger111  @webartoli This seems like something we may want to integrate. Do you have a repro of what is the current behavior and what you are expecting?

Actually i found on Open-XML-SDK a working spreadsheet file with XmlMaps
DocumentFormat.OpenXml.Tests\assets\TestDataStorage\v2FxTestFiles\spreadsheet\XMLMap.xlsx but the file is not referenced by TestAssets.TestFiles or in general in any path.
So, I'll extract a repro with actual and expected files and I'll give you a reference shortly.
Talking about the bug: basically the file xl\xmlMaps.xml must be have as a default namespace this uri http://schemas.openxmlformats.org/spreadsheetml/2006/main.
Excel cannot handle that namespace with the x: prefix.

You can find a repro in this repo webartoli/Open-XML-SDK-issues-90-repro
Hope it helps.

It appears that a simpler repro would be this:
[Fact]
public void MapInfoTest()
{
    Assert.StartsWith("<MapInfo>", new MapInfo().OuterXml);
}

@webartoli  Is the MapInfo the only item you're noticing this issue on?

@tomjebo @Josh-Curry Do either of you have input as to what should be done? I doubt we just want to remove the x from the _namespacePrefixList, but I'll defer to what you guys think

@twsouthwick yes: MapInfo is the only item that case me some problems but opening files generated by Excel i notice that the http://schemas.openxmlformats.org/spreadsheetml/2006/main namespace is always a default for excel generated file.
After some searches i notice that each office programs has its own default namespace.

All, is this a bug in Excel or the SDK? In my mind, the prefix should not make a difference. Any client that reads the XML, with or without prefix but obviously with the corresponding and correct namespace definition, should be able to determine the namespace and see it is the one expected.
Other than Word and PowerPoint, Excel does not write XML with prefixes, probably to reduce the size of what gets written. Not sure whether the assumption is that no prefixes are used and whatever check is performed can‘t deal with prefixes.

Excel has a bug that any Date between 1st jan 1900 and 10th jan 1900 are affected by an offset so writing the 2nd jan 1900 with the SDK, the result on excel is different.
In that case it's an Excel bug and probably should not have impact on the SDK.
In the case of the issue, it is also definitely an Excel bug and generally I agree with you but in that specific case the SDK doesn't give a way to get the expected results.
In my opinion the SDK should manage a correct parsing by Excel (the goal of an SDK): in that case any usages of the MapInfo SDK has no effect on Excel.

@webartoli Microsoft would have to chime in at this point and say what level of compliance with the relevant standard both Excel and the Open XML SDK should achieve. In my view, both should be able to read, process, and write compliant Open XML. If compliance is a requirement, it seems Excel has a bug, which should be fixed.
There would be two ways to work around this Excel bug. Firstly, when using the strongly typed classes, the SDK could consistently produce Open XML without prefixes for all Excel-related parts.
Secondly, you don‘t have to use the strongly typed classes to produce Open XML. You can use the Linq to XML classes (e.g., XElement) as used in the Open XML PowerTools to produce Open XML as you see fit. This way, no change to the strongly typed classes would be required.


[Android] Elements with bleed should bleed top and bottom in addition to left and right

Automatically generated task. Any updates to the title and body will be overwritten. Do NOT modify the labels.
Android fix of #2702

@almedina-ms  / @RebeccaAnne is this required to be fixed explicitly for Android or is sharedmodel changes going to address things here?

There will be renderer specific work for Android once the shared model changes are in place.


Update AST builder between & hash_executor to accept different param …

…types
between, not_between and hash_executor functions accept two Into<ExprNode> params.
Update these to accept different Into<ExprNode> type params.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 3 files are covered.
36 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 97.976%

Files with Coverage Reduction
New Missed Lines
%

core/src/data/value/binary_op/i64.rs
36
96.29%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
37895

Relevant Lines:
38678

💛  - Coveralls


Unpin PySCF to allow latest 2.0.0

PySCF was released recently and wheels for Linux and Mac were added incrementally and during this time PySCF was pinned as otherwise attempts were made to compile it from the source tar.gz package.
I also unpinned h5py since the newer PySCF was fixed in regards of the deprecation issue (as far as I recall seeing before).
I am not sure if this will pass or not since before I had pinned it I had seen notebook kernel crash and other crashes. But this PR will let us view across CI what the outcome is and see how we might proceed in regards of this new version. One possibility might be to allow but pin CI to 1.7.6 if we have some failures but otherwise allow it for users as maybe it works in general. Lets see what happens with CI etc...
Update: I see there are issues related to seg faults on PySCF github and in fact I now see that the MacOS wheels have been removed due to problems so our tests under Mac will go nowhere, until they are restored, as it will attempt to compile the tar.gz which will fail.

2.0.1 has been released - no mac wheels yet so I expect that to fail in CI for now.


Adds check if paths are already absolute before joining the metalsmith path

Hi @doodzik what is the reason for this closure?

@doodzik I'm not sure if you would like to reopen this PR or not as #98 was declined by @ismay

Github shows me an error that this branch was "forced pushed or recreated" and I can't reopen it.
Can you submit it again?

Huh, yea I did a rebase. Will do

@doodzik created #99


Models to Profile on MultiNet Benchmark

Output: List of SoTA Models and justifications for why they should be profiled

Same as #41


repeats instead of limit

@rultor release, tag is 0.0.8

@rultor release, tag is 0.0.8

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.8

@yegor256 Done! FYI, the full log is here (took me 8min)


nixos/influxdb2: add provisioning and nixos tests

Description of changes
This PR adds provisioning options and nixos tests to influxdb2. This allows skipping the initial setup page and automatically creates/deletes the following entities:

organizations
buckets
users
remotes
replications
api tokens (auths)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg test influxdb2

Disclaimer: I'm no longer using influxdb.
Overall I like the idea of declarative setup, but the implementation looks overly complicated. Can we first get the part that can be done with influx setup in and figure out better ways to do the rest?

Overall I like the idea of declarative setup, but the implementation looks overly complicated. Can we first get the part that can be done with influx setup in and figure out better ways to do the rest?

Sure we could do that, but how would you propose to make this simpler? Since there's no first class provisioning in influx there'll always be a lot of "manual" work to get it done

Sure we could do that, but how would you propose to make this simpler? Since there's no first class provisioning in influx there'll always be a lot of "manual" work to get it done

That's why I said "figure out", maybe ansible, maybe terraform, surely there can be better ways than the current scripting.

surely there can be better ways than the current scripting

I'm happy for any suggestions. Although I just couldn't come with anything simpler that doesn't involve building a influxdb client from scratch..
Anyhow, this has now been reduced to the initial setup part, the provisioning support is now tracked in #249502 (which will have to be rebased if/when this is merged). Let's continue talking over there.

The passwordFile and tokenFile options are used even if provisioning is not enabled. Is this intentional?

The passwordFile and tokenFile options are used even if provisioning is not enabled. Is this intentional?

Oops that's not.

Definitely not intended, i thought I guarded against that here
https://github.com/NixOS/nixpkgs/blob/8a294d53a8d940ccd4b8a567f8cbfb35827061bc/nixos/modules/services/databases/influxdb2.nix#L127


Group chat - Group chat when left with only group creator shows up in Start chat list

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Start chat
Create a group chat
Send a message to the group chat
Go to chat header > Members
Remove all the members
Go to FAB > Start chat

Expected Result:
The group chat which is now left with only group creator will not show up in Start chat list
Actual Result:
The group chat which is now left with only group creator shows up in Start chat list and it can be added to group. As a result, the confirmation page shows two same admin
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/06b7f86b-43e8-4008-adb6-480e2855543d
View all open jobs on GitHub

@bfitzexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Proposal
Please re-state the problem that we are trying to solve in this issue.
Removed member of group chat with remaining one member listed in start chat option list
What is the root cause of that problem?
In here:
https://github.com/Expensify/App/blob/fa29a354df9be559c2e5008523562c7384fb2aeb/src/libs/OptionsListUtils.ts#L1764-L1767
In the comment, the code is intended to filters multiple participant chat, but the code filters expense/policy chat and we don't add proper filter for multiple participant / group chat yet.
What changes do you think we should make in order to solve the problem?
we could add check below that code to filter multiple participant chat / group chat, the code could be:
if (!includeMultipleParticipantReports && ((reportOption.participantsList.length > 1) || ReportUtils.isGroupChat(reportOption))) {
      continue;
}

Or we could add includeGroupChatReport parameter in getOptions function :
https://github.com/Expensify/App/blob/fa29a354df9be559c2e5008523562c7384fb2aeb/src/libs/OptionsListUtils.ts#L1532
then add check properly using ReportUtils.isGroupChat

@hoangzinh the self DM is also appear in staging and production. Is the expected result to exclude self-DM from recent list? We can filter the self DM if it is expected result...

Still working through the proposal here

This is ready to pay tomorrow

LGTM. Steps proposed in https://github.com/Expensify/Expensify/issues/403933.
Payments complete. Thanks everyone


Extremely slow TypeScript server on lowdb types

TypeScript Version:  3.2.2
Visual Studio Code Version: 1.30.0

Search Terms: slow, server
Code
Download the gist here. This is a single-file TypeScript project.
Steps to Reproduce:

Open project above in Visual Studio Code and install dependencies.
Open index.ts
Move cursor over any identifier, like Memory, low.lowdbSync<T>, or one after the other

Expected behavior:
TypeScript deduces a type and show it in hover. If you cannot reproduce this, try to add a statement like let a = 0 somewhere in the file.
Actual behavior:
Types take up to 35 seconds to show up.
tsc --diagnostics results:
Files:            38
Lines:         57828
Nodes:        291629
Identifiers:  108726
Symbols:     1177592
Types:       1095357
Memory used: 869000K
I/O read:      0.03s
I/O write:     0.00s
Parse time:    0.62s
Bind time:     0.30s
Check time:    7.27s
Emit time:     0.02s
Total time:    8.21s

Related Issues: #21221

Updated gist URL (I think).

@proteriax Are you still seeing this?  I tried with both TS nightly and TS 3.2.2 (from your package.json), but couldn't reproduce the delay in VS Code or the command line build.
It seems possible that the lowdb type declarations have been refined since then and no longer have this issue.

@amcasey I can’t reproduce this issue either.

@proteriax Glad to hear it.  Sorry it took so long to get you an update.


FileNotFoundError when attempting to load model

Expected behavior

I expected to be able to use GNNModel.load() on one of the paths reported by list_available_nagl_models, but it's not finding the relevant file.
Actual behavior

Code to reproduce the behavior

>>> import pathlib
>>> from openff.nagl_models import validate_nagl_model_path, list_available_nagl_models
>>> from openff.nagl.nn._models import GNNModel
>>> list_available_nagl_models()
['openff-gnn-am1bcc-0.0.1-alpha.1.pt']
>>> pathlib.Path(validate_nagl_model_path(list_available_nagl_models()[0])).exists()
True
>>> GNNModel.load(list_available_nagl_models()[0])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/mattthompson/mambaforge/envs/openff-interchange-env/lib/python3.10/site-packages/openff/nagl/nn/_models.py", line 265, in load
    model_kwargs = torch.load(model)
  File "/Users/mattthompson/mambaforge/envs/openff-interchange-env/lib/python3.10/site-packages/torch/serialization.py", line 771, in load
    with _open_file_like(f, 'rb') as opened_file:
  File "/Users/mattthompson/mambaforge/envs/openff-interchange-env/lib/python3.10/site-packages/torch/serialization.py", line 270, in _open_file_like
    return _open_file(name_or_buffer, mode)
  File "/Users/mattthompson/mambaforge/envs/openff-interchange-env/lib/python3.10/site-packages/torch/serialization.py", line 251, in __init__
    super(_open_file, self).__init__(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: 'openff-gnn-am1bcc-0.0.1-alpha.1.pt'
...

If I'm doing something obviously wrong, it would be nice to update the README to include how to actually load one of these models.
Current environment
I found this in a development environment but can reproduce it in a fresh environment (CONDA_SUBDIR=osx-64 mamba create -n nagl-model-issue -c conda-forge openff-nagl openff-nagl-models)
$ conda list openff
# packages in environment at /Users/mattthompson/mambaforge/envs/nagl-model-issue:
#
# Name                    Version                   Build  Channel
openff-amber-ff-ports     0.0.3              pyh6c4a22f_0    conda-forge
openff-forcefields        2023.02.1          pyh1a96a4e_0    conda-forge
openff-interchange        0.2.3              pyhd8ed1ab_1    conda-forge
openff-interchange-base   0.2.3              pyhd8ed1ab_1    conda-forge
openff-nagl               0.2.1              pyhd8ed1ab_0    conda-forge
openff-nagl-models        0.0.2              pyhd8ed1ab_0    conda-forge
openff-toolkit            0.12.1             pyhd8ed1ab_1    conda-forge
openff-toolkit-base       0.12.1             pyhd8ed1ab_1    conda-forge
openff-units              0.2.0              pyh1a96a4e_0    conda-forge
openff-utilities          0.1.8              pyh1a96a4e_0    conda-forge

I can load it from the absolute path but in my opinion that's not a great user experience, especially for those coming from openff.toolkit.ForceField's loading machinery:
>>> from openff.toolkit.typing.engines.smirnoff import ForceField, get_available_force_fields
>>> ForceField(get_available_force_fields()[-2])
<openff.toolkit.typing.engines.smirnoff.forcefield.ForceField object at 0x1a5140e50>

>>> from openff.nagl.nn._models import GNNModel
/Users/mattthompson/mambaforge/envs/nagl-model-issue/lib/python3.10/site-packages/lightning_utilities/core/imports.py:13: UserWarning: Module openff was already imported from None, but /Users/mattthompson/software/openff-interchange is being added to sys.path
  import pkg_resources
>>> from openff.nagl_models import validate_nagl_model_path, list_available_nagl_models
>>> GNNModel.load(validate_nagl_model_path(list_available_nagl_models()[0]))
GNNModel(
  (convolution_module): ConvolutionModule(
    (gcn_layers): SAGEConvStack(
      (0): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=19, out_features=512, bias=False)
        (fc_self): Linear(in_features=19, out_features=512, bias=True)
      )
      (1): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=512, out_features=512, bias=False)
        (fc_self): Linear(in_features=512, out_features=512, bias=True)
      )
      (2): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=512, out_features=512, bias=False)
        (fc_self): Linear(in_features=512, out_features=512, bias=True)
      )
      (3): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=512, out_features=512, bias=False)
        (fc_self): Linear(in_features=512, out_features=512, bias=True)
      )
      (4): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=512, out_features=512, bias=False)
        (fc_self): Linear(in_features=512, out_features=512, bias=True)
      )
      (5): SAGEConv(
        (feat_drop): Dropout(p=0.01, inplace=False)
        (activation): ReLU()
        (fc_neigh): Linear(in_features=512, out_features=512, bias=False)
        (fc_self): Linear(in_features=512, out_features=512, bias=True)
      )
    )
  )
  (readout_modules): ModuleDict(
    (am1bcc-charges): ReadoutModule(
      (pooling_layer): PoolAtomFeatures()
      (readout_layers): SequentialLayers(
        (0): Linear(in_features=512, out_features=128, bias=True)
        (1): Sigmoid()
        (2): Dropout(p=0, inplace=False)
        (3): Linear(in_features=128, out_features=2, bias=True)
        (4): Identity()
        (5): Dropout(p=0, inplace=False)
      )
      (postprocess_layer): ComputePartialCharges()
    )
  )
)

Thanks for raising this @mattwthompson. That wasn't how list_available_nagl_models was intended to be used, but I can see the confusion with the analogous method in the toolkit. I've updated the method to return the full path in #5.


Bot not working, last update

Hi !
I'm on Chrome + OSX
The bot isn't working anymore, there are all the texts, and when I press the keys, it updates on the screen, but no effects (bot and lines, but mass option and darktheme are working). The ball is following my mouse.
I first updated when prompted. And then tried to uninstall and reinstall clean, same effect.
Thanks

If you look on the top left, does it say:
Bot: AposBot 3.61

I'm having the same problem, and yes/no. The Bot: ApostBot isn't their. But the AsposLauncher 4.1 is except mine say AsposLauncher4.147

Can you go in your Greasemonkey / Tampermoney dashboard and remove AposBot from there?

I didn't install it but I can, I put the script into Ctrl+Shitft+J.

I'm not sure what that means, but if you didn't install it, then it's normal that it doesn't show up.


useFlexLayout plugin hook error

V7
I'm not sure if I am doing something wrong with the configuration of the useFlexLayout plugin but using it gives the following error: Cannot read property 'columns' of undefined
I am using the plugin as shown below.
  const { getTableProps, headerGroups, rows, prepareRow } = useTable({
    columns,
    data,
  },
  useFlexLayout
  )

This error occurs in version 7.0.0-alpha.13 and above

The flex layout hook is currently out of date. I'll be updating or deprecating the plug-in in the next few alpha releases.
On Aug 2, 2019, 9:32 AM -0600, Codar<EMAIL_ADDRESS>wrote:

V7
I'm not sure if I am doing something wrong with the configuration of the useFlexLayout plugin but using it gives the following error: Cannot read property 'columns' of undefined
I am using the plugin as shown below.
const { getTableProps, headerGroups, rows, prepareRow } = useTable({
columns,
data,
},
useFlexLayout
)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

If you urgently need it here's my updated version, works pretty much the same as the old one and is compatible with alpha.19. Since @tannerlinsley mentioned potential deprecation I guess it can be useful in the future.
import PropTypes from 'prop-types';

function sum(arr) {
  return arr.reduce((prev, curr) => prev + curr, 0);
}

function getFirstDefined(...args) {
  for (let i = 0; i < args.length; i += 1) {
    if (typeof args[i] !== 'undefined') {
      return args[i];
    }
  }
  return undefined;
}

function getSizesForColumn(
  { columns, id, width, minWidth, maxWidth },
  columnMeasurements,
  defaultFlex
) {
  if (columns) {
    columns = columns
      .filter(col => col.show || col.visible)
      .map(column => getSizesForColumn(column, columnMeasurements, defaultFlex))
      .filter(Boolean);

    if (!columns.length) {
      return false;
    }

    const flex = sum(columns.map(col => col.flex));
    const width = sum(columns.map(col => col.width));
    const maxWidth = sum(columns.map(col => col.maxWidth));

    return {
      flex,
      width,
      maxWidth
    };
  }

  return {
    flex: width ? 0 : defaultFlex,
    width:
      width === 'auto'
        ? columnMeasurements[id] || defaultFlex
        : getFirstDefined(width, minWidth, defaultFlex),
    maxWidth
  };
}

function getStylesForColumn(column, columnMeasurements, defaultFlex) {
  const { flex, width, maxWidth } = getSizesForColumn(column, columnMeasurements, defaultFlex);

  return {
    flex: `${flex} 0 auto`,
    width: `${width}px`,
    maxWidth: `${maxWidth}px`
  };
}

const propTypes = {
  defaultFlex: PropTypes.number
};

const useMain = props => {
  PropTypes.checkPropTypes(propTypes, props, 'property', 'useFlexLayout');

  const {
    defaultFlex = 1,
    columns,
    hooks: { getRowProps, getHeaderGroupProps, getHeaderProps, getCellProps }
  } = props;

  const visibleColumns = columns.filter(column => column.visible);
  const columnMeasurements = {};

  let sumWidth = 0;
  visibleColumns.forEach(column => {
    const { width, minWidth } = getSizesForColumn(column, defaultFlex);
    if (width) {
      sumWidth += width;
    } else if (minWidth) {
      sumWidth += minWidth;
    } else {
      sumWidth += defaultFlex;
    }
  });

  const rowStyles = {
    style: {
      display: 'flex',
      minWidth: `${sumWidth}px`
    }
  };

  getRowProps.push(() => rowStyles);
  getHeaderGroupProps.push(() => rowStyles);

  getHeaderProps.push(column => ({
    style: {
      boxSizing: 'border-box',
      ...getStylesForColumn(column, columnMeasurements, defaultFlex)
    }
  }));

  getCellProps.push(cell => {
    return {
      style: {
        ...getStylesForColumn(cell.column, columnMeasurements, defaultFlex, undefined, {
          rowStyles
        })
      }
    };
  });

  return props;
};

const useFlexLayout = hooks => {
  hooks.useMain.push(useMain);
};

export default useFlexLayout;

This is extremely helpful. And, extremely impressive that it fits into a single code block like that :). Can you imagine how this would even be feasible in v6?! 💯

Oh yeah, definitely, I really love the extensibility that v7 provides, I never actually used v6 but so far I only had rather unpleasant experiences with premade table components for React. With v7 I have to put a bit more work initially but I have absolute control over almost everything, which is just amazing, especially when the project I'm working at has very dynamically changing requirements.

This should be fixed in master now.

I don't think that this is actually fixed on master.
useFlexLayout still references hooks.columns, and no such value exists, there's certainly no such hook value defined in useTable where the set of hooks are defined.

Oh yeah... Sorry, the code for useFlexLayout is supposed to be deprecated for now. If you would like to know how to make the existing hook work, I could give you some direction, but I don't think I'm going to support it as a first-class citizen in this release.

that's fine, the version that paolostyle posted works fine, this was more a comment in response you yours saying that it should be fixed.
Do you think that you should just delete it from the repo if you're not going to fix it?

Yes. That's a good idea.

@tannerlinsley is useFlexLayout still deprecated?

@tannerlinsley is useFlexLayout still deprecated?

It's usable in the latest version.

Tanner added a new version a little while ago, I can't speak for him, but I think that it's fair to say that it's no longer deprecated.  I'm using the new version quite successfully.

So I tried using useFlexlayout, it seems to work okay but I am confused on how to make the table shrink as the container gets smaller?
The examples show scrollbars, but I actually want the table columns/cells to resize as I make the browser window smaller. Usually you use flex-basis with flex-shrink to make this happen, is this possible with useFlexlayout?

I've decided to just implement my own useFlexLayout which utilizes flex-grow, flex-shrink and flex-basis that are defined on the columns, like so:
  const getColumns = () => [
    {
      ...
      id: 'firstName',
      accessor: 'firstName',
      flexBasis: '10rem',
      flexShrink: 2,
      flexGrow: 1,
      ....
    },
    {
      ...
      id: 'Info',
      accessor: 'info',
      flexBasis: '20rem',
      flexShrink: 1,
      flexGrow: 1
      ...
    },

export default function useFlexLayout(hooks) {
    hooks.getTableProps.push(getTableProps)
    hooks.getTableBodyProps.push(getTableBodyProps)
    hooks.getRowProps.push(getRowStyles)
    hooks.getHeaderGroupProps.push(getRowStyles)
    hooks.getHeaderProps.push(getHeaderProps)
    hooks.getCellProps.push(getCellProps)
  }

  useFlexLayout.pluginName = 'useFlexLayout'

  const getTableProps = (props, { instance }) => [
    props,
    {
      style: {
        display: 'flex',
        flexDirection: 'column'
      },
    },
  ]

  const getTableBodyProps = (props, { instance }) => [
    props,
    {
      style: {},
    },
  ]

  const getRowStyles = (props, { instance }) => [
    props,
    {
      style: {
        display: 'flex',
      },
    },
  ]

  const getHeaderProps = (props, { column }) => [
    props,
    {
      style: {
        boxSizing: 'border-box',
        flex: `${column.flexGrow || 0 } ${column.flexShrink || 1 } ${column.flexBasis || '0px'}`,
      },
    },
  ]

  const getCellProps = (props, { cell }) => [
    props,
    {
      style: {
        boxSizing: 'border-box',
        flex: `${cell.column.flexGrow || 0 } ${cell.column.flexShrink || 1 } ${cell.column.flexBasis || '0px'}`,
      },
    },
  ]

Hmm, I've had no problem getting the columns to resize.  That said, there are all sorts of constraints in the standard useFlexLayout plugin.  It works with useGroupBy and the useResizeColumns plugins, getting the columns layout to work with grouped columns presents a lot of challenges - if you don't use that feature, then it's certainly easier to come up with a different implementation.

@ggascoigne are your columns automatically resizing based on the parent container, or are you manually dragging your columns to make them smaller?
In our case, we just want the table to be responsive based on how wide the user has their browser window, maybe we are doing something wrong with the default useFlexLayout?

take a look at https://github.com/ggascoigne/react-table-example,  Note that this is using a build of react-table including at least one fix that's been merged to master and not released yet.


test: error on hint for unacknowledged update/delete on server < 3.4

Description
NODE-2430 - update
NODE-2535 - delete
What changed?
Added new spec tests from SPEC-1651.
Are there any files to ignore?

@emadum does this only update tests? No additional behavior was changed?

@emadum does this only update tests? No additional behavior was changed?

I think so, they all passed right away given the changes from NODE-2477.


Move from 3.10-dev to 3.10

Move off the "3.10-dev" ci environment to the official "3.10" release.
Change requires quotes because YAML helpfully shortens 3.10 to 3.1 🙃

Codecov Report

Merging #2524 (874f7f2) into develop (aaaf789) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2524      +/-   ##
===========================================
- Coverage    95.31%   95.28%   -0.03%
===========================================
  Files           59       59
  Lines        11440    11440
===========================================
- Hits         10904    10901       -3
- Misses         536      539       +3

Impacted Files
Coverage Δ

botocore/httpsession.py
91.44% <0.00%> (-0.46%)
:arrow_down:

botocore/utils.py
95.51% <0.00%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaaf789...874f7f2. Read the comment docs.


Mapbased job blacklist

we need a blacklist to prevent jobs like chaplain being available on saltern (which doesn't have a chapel)

Fairly sure this is resolved by the game.yml file having roles per map.


Agent: important fixes for Kotlin codegen

Generate inherited members
Generate sealed classes for discriminated unions
Generate string constants
Generate val instead of var for data class members

Test plan
Green CI

I will self-review this PR tomorrow. I have to run out right now so the code may have a few ugly parts left.

CI failure for macOS is unrelated to this PR.