Another list

Just sharing in case it's useful
https://aclist.github.io/

Thanks for sharing! I saw this originally when you had submitted, but didn't have much to say about it. I don't mind having multiple sites, managed by different users, dedicated to the same purpose, but at the time I didn't know how I'd feel about it, or in the future. Right now, it seems that we are ahead of the list by a lot, and when I was starting out I had used this list even as a reference. It seems to have drifted out of sync, but I will keep it in my mind if that ever changes.


Recorder error in HA log: energy_usage_cycle has state class total_increasing but its state is negative

Logger: homeassistant.components.sensor.recorder
Source: components/sensor/recorder.py:396
Integration: Sensor (documentation, issues)
First occurred: 09:20:10 (2 occurrences)
Last logged: 09:20:10
Entity sensor.airco_a043b05ae41d_energy_usage_cycle from integration mitsubishi-wf-rac has state class total_increasing, but its state is negative. Triggered by state -50.25 with last_updated set to 2022-08-16T07:14:59.999999+00:00. Please report it to the custom integration author.
Entity sensor.airco_floris_energy_usage_cycle from integration mitsubishi-wf-rac has state class total_increasing, but its state is negative. Triggered by state -42.5 with last_updated set to 2022-08-16T07:14:59.999999+00:00. Please report it to the custom integration author.

Apologies, I should have checked the open issues first


circle becomes a marker

I am using this version:
http://leaflet.github.io/Leaflet.draw/leaflet.draw.js
from your example here:
http://leaflet.github.io/Leaflet.draw/
draw a circle in that example and do the following on console:
drawnItems.toGeoJSON()
you will get a point...

GeoJSON doesn't support circles currently, so Leaflet converts them tot points. (Documented here: http://leafletjs.com/reference.html#circle)

yeep, sorry.
see:
https://github.com/Leaflet/Leaflet/issues/2888


Update mssql driver

The mssql driver was blocked to an old version of 2016 because of a replace rule.
Changelog: https://github.com/denisenkom/go-mssqldb/compare/e32ca5036449...master

Migrations does not seem to work anymore

Looking at some of the logs it seems that during migration tests an earlier migration didn’t empty as there are errors about duplicate table:
Error: mssql: There is already an object named 'access_token' in the database.

Looks like dropping the database between the migration tests didn't work

They should be being dropped by:
https://github.com/go-gitea/gitea/blob/7dd983797c218d7ae45e67d79517e95ad3dd24b8/integrations/migration-test/migration_test.go#L199
But this doesn't seem to be happening and it doesn't seem to be complaining about it

Has some auto transaction support been added? It might be that it's expecting us to commit before it moving on?

I forget that I have done this PR before :man_facepalming:.
This is now superseded by #7306 and futur work in #7294 to completely remove the replace in go.mod.


Version 1.1.1

Lymui
Totoro is going to review your PR

What does this PR accomplish

[ ] Add a new feature supporting a new color type
[ ] Add a new binding supporting for a type color
[x] Provide a fix to the current project
[x] Add new test

We will check that

[ ] Make sure to have unit test
[ ] Make sure that any test is passing
[ ] Make sure to respect that when converting a type T to return a type T Rgb

🐷 Thanks for contributing ! 🐷

Coverage decreased (-0.08%) to 96.433% when pulling b20a3ad7617b6cfa6ba735b988ae4766e4771b66 on feat/refactor_hex_to_rgb into 81c97b03e6b990bbc8c81c69db93138ba80f77a4 on master.


Want to Redirect level #1 of path only

I'm using react-router@4 & react-router-redux@next
<Switch>
    <Route path="/components" component={FakeComponent} />
    <Route path="/components/a" component={A} />
    <Route path="/components/b" component={B} />
</Switch>

in FakeComponent
const FakeComponent = () => <Redirect exact from='/' to='/dashboard' />;

I just want redirect /components to /dashboard but when navigate to /components/a & /components/b, they're also redirected to /dashboard. How to fix;

sorry, I have some mistakes


Added List presentation requests method

Overview
Fixes #479
Description
Added a new endpoint with docs and tests.
How Has This Been Tested?
Added unit tests.

Codecov Report

Merging #504 (41f262d) into main (1194ecb) will decrease coverage by 0.05%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   21.05%   21.01%   -0.05%
==========================================
  Files          49       49
  Lines        5793     5805      +12
==========================================
  Hits         1220     1220
- Misses       4348     4360      +12
  Partials      225      225

Impacted Files
Coverage Δ

pkg/server/router/presentation.go
2.64% <0.00%> (-0.11%)
:arrow_down:

pkg/server/server.go
68.05% <100.00%> (ø)


Field error handling in serializer and ReferenceField error messages

I have a few related/different fixes in this pull request. If you would like me to do one at a time in the future please let me know!

Updated ReferenceField to show error messages (was getting an AttributeError on bad dereference)
Split the 'invalid' error messages in ReferenceField:

Error message when the DBRef could not be converted to an internal representation
Error message when a Document was not produce from dereferencing the DBRef object

Updated to_representation to catch SkipField in the same manner as DRF

I also tried to be descriptive in my commits. There is a little bit more information in there.
Thanks!
-Timothy

I forgot to try and run the tests. I will try and set them up tomorrow.

No regressions from master in tests (the both failed when I ran 'nosetests').

thanks!


⚠ Bofrost.com has degraded performance

In b84b2e2, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1118 ms

Resolved: Bofrost.com performance has improved in 1109de7 after 9 minutes.


New iAPS Release Available: v5.2.2

Hi @mkurlon,
The Artificial Pancreas ( iAPS ) project just released v5.2.2.
If you are receiving this message, your current code base is out of sync
with the main repository, and should be updated.
To do this, go to your Github fork, and you will notice a line that says
something like:

This branch is N commits behind ...

Click the 'Sync fork' drop down to the right of that line and choose:

Update Branch

Note that v5.2.0 introduced a new GitHub Action to eliminate the need to
manually sync your repo with the main one, and it is highly recommended
that this is enabled.
Please see the v5.2.0 Release Notes for instructions.
If you have any questions, or issues, please let me know and I will be
happy to help.

Thank you Marc.Wishing you a wonderful day.MikeOn Oct 5, 2024, at 6:49 AM, Marc G. Fournier @.***> wrote:
Hi @mkurlon,
The Artificial Pancreas ( iAPS ) project just released v5.2.2.
If you are receiving this message, your current code base is out of sync
with the main repository, and should be updated.
To do this, go to your Github fork, and you will notice a line that says
something like:
This branch is N commits behind ...
Click the 'Sync fork' drop down to the right of that line and choose:
Update Branch
Note that v5.2.0 introduced a new GitHub Action to eliminate the need to
manually sync your repo with the main one, and it is highly recommended
that this is enabled.
Please see the v5.2.0 Release Notes for instructions.
If you have any questions, or issues, please let me know and I will be
happy to help.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


about install-dependencies.sh

I would like to build tiscamera module in docker container.
Therefore, install commands in install-dependencies.sh like "sudo apt-get install $ASSUME_YES $(read_file "$TISCAMERA_DIR/dependencies/dependencies-debian-compilation.txt") " are desirable like sudo apt-get install -y $ASSUME_YES $(read_file "$TISCAMERA_DIR/dependencies/dependencies-debian-compilation.txt").
Actually I can change these points like that, but I want to use this repository as a git submodule.
So, if you don't have concerning points about these change, would you like to change install commands that adding -y.

install-dependencies.sh has a --yes flag. Does that do what you require?
0.13.0 introduced the dependency-manager as a more flexible replacement. It also has a --yes flag.


The binary doesn't work on alpine

The binary does not work on alpine linux:
# ./summon-s3
sh: ./summon-s3: not found

It seems it's because of glibc dependency. To fix it, the binary should either be statically compiled, or a separate binary for musl should be provided.
(Originally reported by @chrisdostert as https://github.com/conjurinc/summon/issues/20)

This is resolved with v0.2.0. We now build an alpine binary with the golang:1.9-alpine Docker image.


Need to select Image twice to upload image in Image Field. Same issue in Image repeater field as well.

Hi @aristath
Issue description:
The issue is we can't choose and upload image in single select. The first time when we choose images and choose select button nothing happens. We have to choose again and click on choose image button then only image get selected. Can you please look at this.

Version used:
2.2.5
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
Kirki::add_field( 'my_config', array(
'label'     => __( 'Background Image', 'my_textdomain' ),
'help'      => __( 'Upload your own custom background image or pattern.', 'my_textdomain' ),
'section'   => 'styling_settings',
'settings'  => 'bg_image',
'type'      => 'image',
'default'   => '',
'required'  => array(
array(
'setting'  => 'body_bg',
'operator' => '==',
'value'    => 'image',
)
)
) );
Thanks

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32242878-need-to-select-image-twice-to-upload-image-in-image-field-same-issue-in-image-repeater-field-as-well?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2030945&utm_medium=issues&utm_source=github).

I'm afraid that's not from Kirki, it's a standard WordPress Core media field and we have no control over it.
Kirki doesn't even include a control for these, we access the control that WP Core already has.


Weekly dev logs #1

So I decided to add support for React and Svelte, this week I'm gonna focus on refactoring the packages to make the core package ream framework-agnostic, @ream/server will be merged into ream, then @ream/app will become @ream/vue.

The current Ream package might be broken, but I won't fix it as I'm rewriting the whole thing now, the new architecture will be SPA by default, built-in API routes support, framework support can be added via plugins, same with SSR support.

Now it's back to Vue-only, I think it's better for this kind of framework to focus on a single target view library, Svelte Kit for Svelte, Next.js for React, and Ream for Vue, maybe someone will make a Vite-based React SSR framework soon.


Domain Driven Design

Hi,
I have a few OpenAPI definitions which are growing quite big.
I know I could separate different definitions into different files, but that'd force me to either organize the schema by function or to create a whole lot of "disjointed" files.
I think that being able to organize the schema following a domain-driven design would make it so much easier to read and maintain. For example:
index.yaml
swagger: "2.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
host: petstore.swagger.io
basePath: /v1
schemes:
  - http
consumes:
  - application/json
produces:
  - application/json
tags:
  - name: pets
tags:
  - name: owners
definitions:
  Error:
    type: "object"
    required:
      - code
      - message
    properties:
      code:
        type: integer
        format: int32
      message:
        type: string
$ref: './pets.yaml'
$ref: './owners.yaml'

pets.yaml
paths:
  /pets:
    get:
      summary: List all pets
      operationId: listPets
      tags:
        - pets
      parameters:
        - name: limit
          in: query
          description: How many items to return at one time (max 100)
          required: false
          type: integer
          format: int32
      responses:
        "200":
          description: A paged array of pets
          headers:
            x-next:
              type: string
              description: A link to the next page of responses
          schema:
            $ref: '#/definitions/Pets'
        default:
          description: unexpected error
          schema:
            $ref: '#/definitions/Error'
    post:
      summary: Create a pet
      operationId: createPets
      tags:
        - pets
      responses:
        "201":
          description: Null response
        default:
          description: unexpected error
          schema:
            $ref: '#/definitions/Error'
definitions:
  Pet:
    type: "object"
    required:
      - id
      - name
    properties:
      id:
        type: integer
        format: int64
      name:
        type: string
      tag:
        type: string
  Pets:
    type: array
    items:
      $ref: '#/definitions/Pet'

owners.yaml
paths:
  /owners:
    get:
      summary: List all owners
      operationId: listOwners
      tags:
        - owners
      parameters:
        - name: limit
          in: query
          description: How many items to return at one time (max 100)
          required: false
          type: integer
          format: int32
      responses:
        "200":
          description: A paged array of owners
          headers:
            x-next:
              type: string
              description: A link to the next page of responses
          schema:
            $ref: '#/definitions/Owners'
        default:
          description: unexpected error
          schema:
            $ref: '#/definitions/Error'
    post:
      summary: Create an owner
      operationId: createOwners
      tags:
        - owners
      responses:
        "201":
          description: Null response
        default:
          description: unexpected error
          schema:
            $ref: '#/definitions/Error'
definitions:
  Owner:
    type: "object"
    required:
      - id
      - name
    properties:
      id:
        type: integer
        format: int64
      name:
        type: string
      creditCard:
        type: string
  Owners:
    type: array
    items:
      $ref: '#/definitions/Owners'

Is there any way to achieve this?

You can structure the paths object in your index.yaml as
paths:
  /pets:
    $ref: './pets.yaml#/paths/~1pets'
  /owners:
    $ref: './owners.yaml#/paths/~1owners'

the internal definitions within pets.yaml and owners.yaml "just work" as internal $refs are scoped to their own resource.
shared definitions (such as Error in your example) could be also be referenced from a shared external resource (otherwise they will not resolve as the referring document is not in scope):
responses:
  default:
    description: unexpected error
    schema:
      $ref: './defs.yaml#/definitions/Error'


CI: migrate 20-identity-list.sh to Ginkgo, mark corresponding tests as validated

Signed-off by: Ian Vernon<EMAIL_ADDRESS>Related-to: #1841
Fixes: #2532

test-me-please

test-me-please

test-me-please

test-me-please


why do we need .../code/github/jumpscale/developer/scripts/devs

?

it is used to fill the authorized_keys when building the docker container so that developers can easily access each others js container to investigate problems if they occur, ...


Postpublish

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x ] There's a clear use-case for this code change
[x ] Commit message has a short title & references relevant issues
[x ] The build will pass (run ember test from the repo root - will be core/client if working from the submodule in Ghost).

More info can be found by clicking the "guidelines for contributing" link above.

@smithahebbar I'm going to close this PR as there's no description for why this test is being added and it's not using any of our test patterns so will result in quite a brittle test that will break any time markup or styles are changed.
If you want to create a PR for something, please open an issue first so that the problem can be validated and the appropriate path to fixing it can be discussed 🙂


Text and images around environment topologies for developent and build is outdated

The naming, menus and generally experience has changed significantly since the present content was released.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a74ae963-aca1-5622-b27a-05e40e40554c
Version Independent ID: 64745ceb-8444-d806-6a3c-a695c288d07a
Content: Deploy topologies that support continuous build and test automation - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/perf-test/continuous-build-test-automation.md
Service: dynamics-ax-platform
GitHub Login: @RobinARH
Microsoft Alias: shailesn

Thanks for the feedback. We are working on updating this topic.

The build VM contains the vNext build agent which was released as part of TFS 2015. When you deploy the Build VM, the build agent is configured by default to connect and sync with the Azure DevOps project.
This does not work for me. The Pipeline > Builds section in VSTS (Azure DevOps) is empty with message No builds were found.
Please could you provide troubleshooting section?


Release/1.6.0 beta.1

Update to 1.6.0-beta.1

Coverage decreased (-24.3%) to 53.05% when pulling bf6e30d316d42dde8ade70a4581ba695f6441552 on release/1.6.0-beta.1 into c062e11f27d8d3f3d5da40dae2a91f0230ce3e2c on develop.

Coverage decreased (-24.3%) to 53.05% when pulling bf6e30d316d42dde8ade70a4581ba695f6441552 on release/1.6.0-beta.1 into c062e11f27d8d3f3d5da40dae2a91f0230ce3e2c on develop.


Flow integration

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ x ] Code style update
[ ] Refactor (refactoring or adding test which isn't a fix or add a feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ x ] No

Did you test your solution?

[ ] I lightly tested it in one browser
[ ] I deeply tested it in several browsers
[ ] I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description

Solution Description

Side Effects, Risks, Impact

[ ] N/A

Aditional comments:

added flow-typed so users can use types from npm modules
Flow option all is enabled so no need to put @flow at the top of the files.
exact_by_default is enabled therefore no need to use {| |} or $Exact<{ }> syntax.

Looks good to me!

@namniak closing this PR as we internally decided to move forward with TS.


pull request for e2e test at 11/24/2016 16:56:07

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Use dagger static provider methods

Task/Issue URL: https://app.asana.com/0/414730916066338/1202075724102079/f
Description
Use Dagger static providers to avoid unnecessary (module) instance creation. More info here
Steps to test this PR
Smoke tests

Current dependencies on/for this PR:

develop

PR #1845   (this PR)

This comment was auto-generated by Graphite.


Add a mention of The Bullhorn newsletter in resources

Ansible now has a 'Bullhorn' email newsletter for major announcements and pertinent information: https://www.reddit.com/r/ansible/comments/g6knmz/the_bullhorn_issue_one/
It would be good to add it to the list of Ansible resources for further information/learning in the book's Preface (I believe that's where I mention other links... but maybe the Introduction or Chapter 1?)

I linked to: https://us19.campaign-archive.com/home/?u=56d874e027110e35dea0e03c1&id=d6635f5420


BinnedSpiketrain should accept a 0-1 matrix as an input

Currently, the BinnedSpiketrain class only accepts a list of spiketrains as an input. However, it would be very useful to also be able to convert a numpy array of 01 values into a BinnedSpiketrain object:
a=np.zeros((10,10))
b=BinnedSpiketrain(a,tstart=0s,tstop=10s)

First version see:  here

Coming back to this function after 2 two years I realized the functionality is a little different than desired from Michael's example. It requires quite a big restructuring of the Binned class and may need discussion, e.g. all internal consistency checks have to be circumvented when the input is a binary matrix.

Yes, I agree -- this means that the input must receive a completely different set of checks in terms of t_start, t_stop, number of bins, and bin width.

I started to implement this in a new branch, see here.
It was not as complex as I had imaged and I could use most of the functionality the Binning class provides to check for consistency etc in a straightforward manner.
The functionality is mostly done, just need a few more unit tests.

Free to review now.


[demo] better loading strategy

Avoid FUOC. A few alternatives:

[ ] Hide content until the x-slider WC is defined
[x] [advanced] Alt layout (e.g. x-slider with overflow: scroll and slides with display: inline-block?)

Added a demo scenario where the :not(:defined) is used to add styles applied before a custom element is defined https://developers.google.com/web/fundamentals/web-components/customelements#prestyle


wrong enable_if for const pointer (instead of pointer-to-const)

Hi ,
The following test fails to compile:
const json value = {{"one", 1}, {"two", 2}};
const json::object_t* p = value.get_ptr<const json::object_t*>();

But this compiles (note the extra const):
const json value = {{"one", 1}, {"two", 2}};
const json::object_t* const q = value.get_ptr<const json::object_t* const>();

I think that the problem is the additional check for the const overload of get_ptr
and std::is_const<PointerType>::value
I think what you intended was to check that the template parameter is a "pointer-to-const" but what you are actually checking is if you got a "const pointer".
I believe the right fix is to check for "pointer-to-const" like this:
and std::is_const< typename std::remove_pointer<PointerType>::type >::value
It works in VS2015.

PR #137 ready!

After merging #137, this issue can be closed.


Handling unallowed unicode value

Used Cerberus version: 1.0.1

I consulted these documentations:

[x] http://docs.python-cerberus.org/en/stable/
[x] http://docs.python-cerberus.org/en/latest/

[ ] I found nothing relevant to my problem in the docs.

[ ] I found the documentation not helpful to my problem.

[x] I have the capacity to improve the docs when my problem is solved.

[x] I have the capacity to submit a patch when a bug is identified.

I'm using Cerberus to validate data send by users, data can be unicode. One of the validated fields needs to be a certain allowed value. Value itself can be a unicode string but allowed list does not have any unicode elements.
This is a simple illustration of the problem.
from cerberus import Validator
schema = {'name': {'type': 'string', 'allowed': ['Joe']}
v = Validator(schema)

In [1]: v.validate({'name': 'Jo'})
Out[1]: False

In [2]: v.errors
Out[2]: {'name': ['unallowed value Jo']}

In [3]: v.validate({'name': u'Michał'})
Out[3]: False

In [4]: v.errors
---------------------------------------------------------------------------
/home/majki/.virtualenvs/cerberus-playground/lib/python2.7/site-packages/cerberus/errors.pyc in format_message(self, field, error)
    462         return self.messages[error.code]\
    463             .format(*error.info, constraint=error.constraint,
--> 464                     field=field, value=error.value)
    465
    466     def insert_error(self, path, node):

UnicodeEncodeError: 'ascii' codec can't encode character u'\u0142' in position 5: ordinal not in range(128)

As you can see an exception occurs when I try to display the error message.
At first I was encoding the data before validation, what worked, but than it would require to decode it back before rendering a response. So it seemed a bit off to do.
Since my allowed list does not contain any unicode strings as a workaround I have created a validator that rejects non ASCII string with a proper message and does manual check for allowed values.
Is this a bug? Or am I doing something horribly wrong with unicode?

though this could propably be fixed, i suggest you use Python 3.

What @funkyfuture said. However it would be nice if Cerberus would run smoothly over this, even on Py2. So @inirudebwoy, feel free to submit a patch 😄

Cheers guys.
Since I can't unfortunately move to Python 3, will have to submit a patch.


Prevent data loss from container being stopped while in disconnected state

Add ability to save pending changes made in a disconnected state and subsequently use previously saved state to reapply changes in a newly loaded container.

@wes-carlson , is it worth closing it? We will come back to it whenever interest from app comes back, I'm not sure there is value in keeping it around.


Overriding KnoxLoginView for Global usage on all views

Does it make sense to make authentication_classes = [BasicAuthentication] the default behavior for KnoxLoginView? Or is it more common to require a different authentication method, rather than basic, for KnoxLoginView?

Not sure what is more common, I also use BasicAuthentication. But I would guess keeping knox use the DRF setting, results in less people needing to override the LoginView. There's e.g. OAuth2 and custom classes that people may use.

close due inactivity


Specific NSFW

In short, I simply propose to be able to make an order only in NSFW channels ( -18 years old ).

There is already a tag nsfw that you can put in your commands, using the default 'message' event, commands won't execute in a non-nsfw channel, sending an "error" in an embed.
You can also modify the behavior by using a custom 'message' event.

There is already a tag nsfw that you can put in your commands, using the default 'message' event, commands won't execute in a non-nsfw channel, sending an "error" in an embed.
You can also modify the behavior by using a custom 'message' event.


Added changes for MPS

This PR adds support for running the model using the MPS backend on MacOS devices.
As per README, having pytorch>=2.0 is strongly recommended as it comes with a wider support for various operations on MPS. Also torchvision::nms is still not supported by MPS, so one has to use PYTORCH_ENABLE_MPS_FALLBACK=1 to enable a fallback on CPU.
Tested on M1 using vit_l model. Runtime of the amg script:

with device=cpu ~124s
with device=mps ~73s

Resolves the following issues:
https://github.com/facebookresearch/segment-anything/issues/119
https://github.com/facebookresearch/segment-anything/issues/94

It works but is it expected to get worse results?
MPS on macbook m1:

Cuda (Nvidia Tesla A30):

MPS support in PyTorch is still experimental, so I think the differences are due to that, however, I must admit I have not looked in detail what operations cause difference in this particular model (I did print some statistics of intermediate activations and they were comparable b/w CPU and MPS). I did first try using PyTorch 1.12.0 and it required many more code changes, which in the end still resulted in no masks being generated at all. PyTorch 2.0 came with more MPS fixes, so I imagine it would only get better with time.

I still get a segfault when I run the amg.py script:
python scripts/amg.py --input './notebooks/images/truck.jpg' --output ./out --checkpoint models/sam_vit_l_0b3195.pth --model-type vit_l --device 'mps'

Loading model...
Processing './notebooks/images/truck.jpg'...
[1]    97607 segmentation fault  python scripts/amg.py --input './notebooks/images/truck.jpg' --output ./out

@KevinColemanInc I was getting a segfault but was able to fix it after
pip install torch==2.0.0 torchvision==0.15.0

I'm not sure if this works yet, or maybe I'm dense. On a Mac M1 Ultra Studio
import os
os.environ["PYTORCH_ENABLE_MPS_FALLBACK"]="1"

import torch
from segment_anything import sam_model_registry, SamPredictor, SamAutomaticMaskGenerator
sam = sam_model_registry["vit_h"](checkpoint="~/GitHub/segment-anything/models/sam_vit_h_4b8939.pth")

import cv2
import urllib.request
import numpy as np

url = "https://upload.wikimedia.org/wikipedia/commons/e/e7/Everest_North_Face_toward_Base_Camp_Tibet_Luca_Galuzzi_2006.jpg"
req =  urllib.request.urlopen(url)
arr = np.asarray(bytearray(req.read()), dtype=np.uint8)
image = cv2.cvtColor(cv2.imdecode(arr, -1), cv2.COLOR_BGR2RGB)

#general code, returns "mps" on my system
device = "cuda" if torch.cuda.is_available() else "mps" if torch.has_mps else "cpu"
sam.to(device=device)

mask_generator = SamAutomaticMaskGenerator(sam)
result = mask_generator.generate(image)

Which then returns:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/Caskroom/mambaforge/base/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/opt/homebrew/Caskroom/mambaforge/base/lib/python3.10/site-packages/segment_anything/automatic_mask_generator.py", line 163, in generate
    mask_data = self._generate_masks(image)
  File "/opt/homebrew/Caskroom/mambaforge/base/lib/python3.10/site-packages/segment_anything/automatic_mask_generator.py", line 206, in _generate_masks
    crop_data = self._process_crop(image, crop_box, layer_idx, orig_size)
  File "/opt/homebrew/Caskroom/mambaforge/base/lib/python3.10/site-packages/segment_anything/automatic_mask_generator.py", line 245, in _process_crop
    batch_data = self._process_batch(points, cropped_im_size, crop_box, orig_size)
  File "/opt/homebrew/Caskroom/mambaforge/base/lib/python3.10/site-packages/segment_anything/automatic_mask_generator.py", line 277, in _process_batch
    in_points = torch.as_tensor(transformed_points, device=self.predictor.device)
TypeError: Cannot convert a MPS Tensor to float64 dtype as the MPS framework doesn't support float64. Please use float32 instead.

NVM, I am dense. Gotta install this specific branch, as main doesn't work. You can do so this way:
python -m pip install 'segment-anything @ git+https://github.com/DrSleep/segment-anything@cd507390ca9591951d0bfff2723d1f6be8792bb8'

This PR adds support for running the model using the MPS backend on MacOS devices.

yes, i install this specific branch Added changes for MPS #122
but this code will fall back to run on the CPU,  even slower than cpu. On a MacBook M1Pro
1、this is my code:
import os
os.environ["PYTORCH_ENABLE_MPS_FALLBACK"]="1"

import time
import cv2
import torch
import torchvision
from segment_anything import sam_model_registry, SamAutomaticMaskGenerator, SamPredictor
print("PyTorch version:", torch.__version__)
print("Torchvision version:", torchvision.__version__)
print("CUDA is available:", torch.cuda.is_available())

tt = time.time()

sam_checkpoint = "sam_vit_l_0b3195.pth"
model_type = "vit_l"
device = "mps"

sam = sam_model_registry[model_type](checkpoint=sam_checkpoint)
sam.to(device=device)

tt = time.time()
mask_generator = SamAutomaticMaskGenerator(sam)

image = cv2.imread('dog.jpg')
image = cv2.cvtColor(image, cv2.COLOR_BGR2RGB)

result = mask_generator.generate(image)

print("result", time.time() - tt, len(result))

2、this is the result log:
 PyTorch version: 2.0.0
 Torchvision version: 0.15.0
 CUDA is available: False

 /Users/felix/kuangkuang/gitkavin/segment-anything-mps-support/segment_anything/modeling/mask_decoder.py:126:
 UserWarning: MPS: no support for int64 repeats mask, casting it to int32 (Triggered internally at
/Users/runner/work/pytorch/pytorch/pytorch/aten/src/ATen/native/mps/operations/Repeat.mm:236.)
 src = torch.repeat_interleave(image_embeddings, tokens.shape[0], dim=0)
[W MPSFallback.mm:11] Warning: The operator 'torchvision::nms' is not currently supported on the MPS backend and
 will fall back to run on the CPU. This may have performance implications. (function operator())

result 65.58419871330261 66

3、if I change device = "cpu"
this is the result log:
 PyTorch version: 2.0.0
 Torchvision version: 0.15.0
 CUDA is available: False
 result 33.75937104225159 66

3、if I change env to new version
this is the error log:
PyTorch version: 2.1.0.dev20230512
Torchvision version: 0.16.0.dev20230512
CUDA is available: False
Segmentation fault: 11

How to solve this  problem, I want run segment-anything in MPS

Do we have a final solution for this in the meantime of getting segment-anything to run using MPS?

The following was performed on an M3 max 128gb macbook pro with pytorch 2.3 and torchvision 0.18. I set device to 'mlp'. I used the vit_h checkpoint.
The following preview times are for my 2nd attempt. The time to generate the masks were 17s and 43s respectively on the 2nd go. On the first go, not represented in the images, it took 33s and 46s respectively so it went quite a bit faster the 2nd time. Both times however, the amount of masks generated were 60 and 90 respectively.

So, though m1 might not produce the best masks, it is possible to get high quality masks if one upgrades their equipment.


Add role for adding openstack networks to existing instances (IDR-0.3.1)

If you need to add a new network to an existing openstack instance you can use this role. This role only handles the openstack side of things, you will also need to configure your instance to use the additional network. If you only require very basic configuration use the role from https://github.com/openmicroscopy/infrastructure/pull/200
See the example in the README of this role.

Testing with:
---
- hosts: localhost
  connection: local
  roles:
  - role: openstack-idr-instance-network
    idr_instance_network_server: adhoc-proxy
    idr_instance_network_networks:
    - adhoc
    - IDR_private # i.e. demo2
    - demo3
    - demo31

- hosts: adhoc-proxy
  roles:
  - role: network-cloud-interfaces

$ OS_CLOUD=ebi ansible-playbook -u centos playbooks/adhoc-network.yml

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [openstack-idr-instance-network : idr vm | get openstack servers] *********
ok: [localhost]

TASK [openstack-idr-instance-network : idr vm | get openstack networks] ********
ok: [localhost]

TASK [openstack-idr-instance-network : debug] **********************************
skipping: [localhost]

TASK [openstack-idr-instance-network : debug] **********************************
skipping: [localhost] => (item=adhoc)
skipping: [localhost] => (item=IDR_private)
skipping: [localhost] => (item=demo3)
skipping: [localhost] => (item=demo31)

TASK [openstack-idr-instance-network : idr vm | attach instance to network] ****
skipping: [localhost] => (item=adhoc)
changed: [localhost] => (item=IDR_private)
skipping: [localhost] => (item=demo3)
changed: [localhost] => (item=demo31)

PLAY [adhoc-proxy] *************************************************************

TASK [setup] *******************************************************************
ok: [adhoc-proxy]

TASK [network-cloud-interfaces : network cloud | get existing config] **********
ok: [adhoc-proxy]

TASK [network-cloud-interfaces : network cloud | add nics] *********************
skipping: [adhoc-proxy] => (item=lo)
changed: [adhoc-proxy] => (item=eth3)
changed: [adhoc-proxy] => (item=eth2)
skipping: [adhoc-proxy] => (item=eth1)
skipping: [adhoc-proxy] => (item=eth0)

TASK [network-cloud-interfaces : network cloud | start new nics] ***************
...

PLAY RECAP *********************************************************************
adhoc-proxy                : ok=4    changed=2    unreachable=0    failed=0
localhost                  : ok=4    changed=1    unreachable=0    failed=0

Very nice!


Added intitial support for animated sprites.

Description
This pull request implements basic sprite-sheet based animation as a Drawable inheriting from RectSprite. Sprite management has been moved into the SpriteManager class and all explicit references the the RectSprite class constructor have been updated to use the various SpriteManager.createSprite overloads instead.
Testing
Checking for bugs

Run the game
Start a new game - any settings will do
Check that nothing looks different/broken (are the scales wrong? do objects even appear? etc.)
Check that the collision shapes still align to their appearences (try bumping into things)

Testings that sprite animations work

Getting some animations:
I have created some sample animations to test that this feature works, they can be found on the "animated-sprites-example" branch on my fork. They are modified versions of the existing sprites. I may add a couple more of these to test various sizes and formats.

Download the drome.png and dromeAnimation.json files and place them in the modules/core/assets/ships/drome directory.
Download the station.png and stationAnimation.json files and place them in the modules/core/assets/ships/station directory.
Download the rockyGround.json, rockyGround_ff_2.png and rockyGround_ff_2Animation.json files and place them in the modules/core/assets/grounds/rocky directory.
Download the bulletProjectile.png and bulletProjectileAnimation.json files and place them in the modules/core/assets/textures/projectiles directory.

Run the game
Start a new game - any settings will do (unless stated otherwise)
Testing animations:

Drome animations:

Fly down to any planet and find a drome (the planetary merchant station)
Check if the drome has an animated arrow moving up and down above it
Check if the drome has each of the letters of the sign lit in pairs (except the last "$" letter) over a short duration (the animation is deliberatly sped-up)

Station animations:

When you start a new game, you should spawn at a station
Check if the station has some pulsating green 'lights' in front of it (not actual lights)

Rocky ground tile animation:

Fly down to any rocky planet and find a piece of terrain that has a metal box inside it (look at the texture for a reference)
Check that there are moving waves coming out of an 'antenna' that extrudes partially out of the tile
Check that there are rapidly changing symbols shown on the face of the underground box

Bullet projectile animation:

Start a new game with the "Loaded Imperial Large" ship
Press "left-shift" (or whatever key was configured) to activate the slow-down time in-game ability
Click the left or right mouse buttons (or any configured equivalent) to shoot a projectile
Check that the projectile changes colour rapidly once fired

Notes
This should not break existing sprites, although they have been upgraded to use the SpriteManager class so that they can use animated sprites without any other changes being needed. All the sprites produced by SpriteManager.createSprite are AnimatedRectSprites although this can be changed. You can use the SpriteManager.createStaticSprite method to create RectSprite objects directly.
~This pull request also adds a file directly from the LibGDX source tree, as it was extremely useful as a utility class for inplmenting these animations and the current LibGDX version referenced by Destination Sol was too old (it only supported TextureRegion objects). If absolutely essential, I can write a similar class (although fixed to only use AtlasRegion objects as frames) to replace this. This should not be needed if issue #312 is implemented, as the generic form of the class required should most certainly be in any version that is v1.9.5 or above.~ The Animation class from LibGDX is now used directly.
<!-- ### Pre Pull Request Checklist:
When scanning the code with SonarLint, just don't introduce any new issues, and maybe even fix a few existing ones
- [ ] Code has been scanned with [SonarLint](http://www.sonarlint.org/intellij/)
- [ ] Methods have been annotated with @ Nullable and @ Nonnull ([Read more](https://github.com/MovingBlocks/DestinationSol/wiki/@Nullable-&-@Nonnull-Quickstart))
- [ ] There are no errors present in the project
- [ ] Code has been formatted and indented
- [ ] Methods have appropriate Javadoc ([How to write Javadoc](http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html))

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

I believe that the planetary terrain issue should be fixed now.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hey @BenjaminAmos, what's the status on this? Is that LibGDX file needed anymore now that we have upgraded? Let me know if there's anything else to be aware of before I give this a review. :)

Uh oh, something went wrong with the build. Need to check on that

I have rebased this on-top of the latest commits and resolved the merge conflicts. The temporary Animation class is no longer needed and I have tested that it works without it. This should be ready for review.

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

The requested changes should have been made, apart from Assets.getAnimation, where I have committed an alternative approach.

I'm guessing that this is the planet terrain bug mentioned earlier...

Hooray Jenkins reported success with all tests good!

The commit that I just pushed should fix the bug, although I have not tested it extensively yet.

Hooray Jenkins reported success with all tests good!

I sometimes get the following crash while fighting with ships guarding the starting station. I'm not quite sure how to consistently reproduce it however.
I haven't so far gotten it on develop but it's so inconsistent that I can't say for certain it is introduced in this PR.
java.lang.NullPointerException
	at org.destinationsol.game.drawables.animated.AnimatedRectSprite.<init>(AnimatedRectSprite.java:37)
	at org.destinationsol.game.drawables.SpriteManager.createSprite(SpriteManager.java:124)
	at org.destinationsol.game.item.LootBuilder.build(LootBuilder.java:48)
	at org.destinationsol.game.ship.SolShip.throwLoot(SolShip.java:411)
	at org.destinationsol.game.ship.SolShip.throwAllLoot(SolShip.java:372)
	at org.destinationsol.game.ship.SolShip.onRemove(SolShip.java:356)
	at org.destinationsol.game.ObjectManager.removeObjNow(ObjectManager.java:191)
	at org.destinationsol.game.ObjectManager.addRemove(ObjectManager.java:178)
	at org.destinationsol.game.ObjectManager.update(ObjectManager.java:145)
	at org.destinationsol.game.SolGame.lambda$null$2(SolGame.java:304)
	at java.util.ArrayList.forEach(ArrayList.java:1257)
	at org.destinationsol.game.SolGame.lambda$update$3(SolGame.java:303)
	at java.lang.Iterable.forEach(Iterable.java:75)
	at org.destinationsol.game.SolGame.update(SolGame.java:302)
	at org.destinationsol.SolApplication.update(SolApplication.java:200)
	at org.destinationsol.SolApplication.safeUpdate(SolApplication.java:175)
	at org.destinationsol.SolApplication.render(SolApplication.java:139)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.update(Lwjgl3Window.java:392)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:137)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.<init>(Lwjgl3Application.java:111)
	at org.destinationsol.desktop.SolDesktop.main(SolDesktop.java:149)

I tried to reproduce the bug and found that it occurs when the item heavyArmor is dropped. As the ship "loot" is random, this would explain the unpredictibility of the crash. The asset core:heavyArmorIcon is not found, even though it is present within the assets directory. The line of code which causes the crash is this (found in Assets.getAnimation):
if (assetHelper.list(DSTexture.class, texturePath).size() == 0) {
    return null;
}

When testing the lastest develop branch commit (https://github.com/MovingBlocks/DestinationSol/commit/bfd67a49b80713b2490a12543fc8cec4e88210de), I was not able to reproduce the issue, as heavy armor is dropped and rendered correctly, so it is likely that it was introduced in this pull request.
It might be possible to solve this issue by rendering dropped item icons as static sprites, rather than animated ones. I will try to push some commits that change the item dropping code to use static sprites soon.

My most recent commit has disabled animated sprites in methods where they are known to cause crashes. This should prevent the crash that occurs when fighting the station ships.

Hooray Jenkins reported success with all tests good!

Nice work! Are you doing GCI this year? I can give you a task for this if you are :)

Oh another thing: if you have some time, would you mind just creating a brief wiki page on this? And feel free to make another PR with some of those animations, including the drome. :)

I am doing GCI this year, where time permits, although I would not take a task on this because it was actually one of my GCI tasks last year. I have created a new wiki page documenting the animation format here.


(@W-8946079) Updating groupId to the new com.evergage.thirdparty standard location.

@ispringer got the branch renamed, and updated the version string both here and in my related evergage-product PR at https://github.com/evergage/evergage-product/pull/2082/files

Fyi, I deployed this to Evergage Nexus, so we should be able to see if your evergage-product branch passes in Evergage Jenkins now.
Can you also create a 1.1.4-evg1 tag pointing at the current commit on this branch?

Tag has been created, @ispringer


Support CosmWasm 1.1 Schemas

Really excited for CosmWasm 1.1 schemas... would be great to get support for that so we can start using them.

@uint do you have any examples I can use for testing?

Hi, yes!
https://github.com/CosmWasm/cosmwasm/blob/main/contracts/hackatom/schema/hackatom.json
https://github.com/CosmWasm/cosmwasm/blob/main/contracts/cyberpunk/schema/cyberpunk.json
And other contracts in there. Does that work?

Thanks perfect, thank you @uint !

PR here https://github.com/CosmWasm/ts-codegen/pull/60


Enchanting sometimes takes 30 levels instead of 3

Plugin version: 4.20.26
Server type: Paper #103
Server version: 1.15.2
Describe the bug
As outlined in issue #28 and #26, sometimes enchanting an item takes 30 levels from a player rather than just 3. When this happens, no sound effects are played either.
Expected behavior
Minecraft has not taken 30 levels from a player during enchanting since 1.9 and the introduction of lapis as a key ingredient during the enchanting process.
To Reproduce

Install the plugin
Start the server
Enchant repeatedly until 30 levels are taken

Forgive my intrusiveness but I was forced to fix this myself by editing the code. Players losing 30 levels was frequently becoming an issue that I had to resolve manually. In EnchantingTableEvents, the code that removes the player's levels can easily be simplified to:

int levelCost = event.whichButton();
int newLevel = event.getEnchanter().getLevel() - levelCost;
if (newLevel < 0) {
newLevel = 0;
}

The button that is clicked is either button 1, button 2 or button 3 - corresponding to the power of the enchants. Each button always removes either 1 - 3 levels, again depending on the power of the enchants. Whilst this doesn't fix the fact that the bug occurs (the sound effects still don't play in the case of it happening, proving it's still there), it does fix the more serious problem of a player losing 30 levels since it now will only ever take a maximum of 3.
This has been an issue since at least 4.19.24.

My main issue with that fix is that it feels hacky, and I'm not sure why it wouldn't be correct in the first place.
I'll continue to see what I can find, though. Thank you!

I don't disagree but it's also entirely reasonable and is the exact methods provided by the onEnchant event. It's still way better than the alternative that is players losing 30 levels though.
Agreed it's frustrating and also confusing on why it's even doing it in the first place though. As I mentioned, Minecraft shouldn't ever take 30 levels at all anymore. There shouldn't be a single piece of code that causes that to happen.
If nothing else, it'd be appreciated if you implemented a temporary, admittedly hacky, solution.


Fix typo error

Fix the typo error in getting-started.md file.
Signed-off-by: Seungbaek Hong<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2030. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2030-202210311631280.82523107528687-36856aa2e76987b12db9e20be69d75fc6c6e850b/report/misspelling_result.txt.


yarn install error

hi there,
I clone the project and use yarn install. It has following errors:
yarn-error.txt

The error log seems to point at https://www.npmjs.com/package/httperrors. Beyond that it's hard to tell what's going on as the site wasn't designed to be used with yarn (no official support, pr welcome).

I create a pull request yesterday. Upgrade gh-pages to the latest version would resolve the issue.

Ok, looks like it was merged already. This might be safe to close then. Please verify that yarn works and close. 👍


Urcli assigns project that is not being pulled!

Guidelines to submit an issue

I'm opening this issue because:

urcli is doing something I don't understand.

What's going wrong?
I am certified for two projects A & B, but choose to pull request for Project A only. However, when I run the command urcli assign <Project_id> for A, I am getting notification for Project B.

I have updated my urcli to the latest, going through all the steps from the beginning.
My node is stable version.
I tried the urcli certs, which just displays only the projects I am certified for.
Yet pulling request for Project A only, still gives me notifications for Project B

supporting information:

[x] node -v prints: v8.0.0
[x] urcli -V prints: 4.0.6
[x] Windows, OS X/macOS, or Linux?: macOS

Hi @adbelis, I think I mistakenly closed the other issue before you had a chance to report on any changes. Sorry about that!
So let me get this straight: You are request project A, but only getting project Bs assigned?

Thanks for your kind response.
However, that's not exactly the case. From what I understand, if a request is made to a single project, it is assumed that other projects that is not being pulled, should not be assigned. right?
If I am pulling both projects, and I am getting more of one over the other, that's not a problem. But when I am pulling only one - Project A, and I am getting notification for Project B, which is not even pulled in the first place, then something might definitely be wrong somewhere. Yes?

What kind of notification are we talking about? Can you get more specific? Like, let me know what project IDs and names you are requesting and take me through exactly what is happening. If you have screenshots or you can paste in the text from the UI, that is super helpful too.

Thanks again. By Notification, I mean project assigned.

Also, try pressing the o key ("o" as in options), and select the debugging information. Paste it in. I will need you to be a lot more specific if I'm to help you :-).

Are the notifications correct? Do you actually get the reviews assigned that the notifications say you do?

The Debugger shows that I am actually pulling request for just one project. Which is the right thing.
Ok Let me elaborate.

I am certified for the Movie Trailer Website -with Project_ID -2 and Item Catalog - Project_ID 5

In the terminal, I type in urcli assign 5, pulling request for  just one project;  Item Catalog Project.

Yet, I am still assigned Movie Trailer Website project.

Could this be clear enough?

Here is the debug info
Debug INFO:
List of request IDs (2): 382327,382861
Submission Request returned from the server: {
  "user_id": 17050,
  "id": 382861,
  "submission_id": null,
  "closed_at": "2017-06-14T14:01:16.070Z",
  "created_at": "2017-06-14T11:02:51.031Z",
  "updated_at": "2017-06-14T13:01:16.082Z",
  "status": "available",
  "submission_request_projects": [
    {
      "project_id": 5,
      "language": "en-us"
    }
  ]
}
Stored Submission Request object: {
  "user_id": 17050,
  "id": 382861,
  "submission_id": null,
  "closed_at": "2017-06-14T14:01:16.070Z",
  "created_at": "2017-06-14T11:02:51.031Z",
  "updated_at": "2017-06-14T13:01:16.082Z",
  "status": "available",
  "submission_request_projects": [
    {
      "project_id": 5,
      "language": "en-us"
    }
  ]
}

That is clear, and it's a total mystery why that would happen. As you can see, the submission_request object that is returned from the servers, clearly show that you are only queued up for project_id 5. Remember that if you manually assign a project, using the dashboard, urcli will still notify you about it.

I understand very well what you're saying @trolster . And I am very thankful to you for your indulgence.
Am as equally mystified by this too. I don't manually assign a project from my dashboard. I Usually wait for the Notification from urcli. And when I see in the notification that I am assigned a project that I am not pulling, am stunned.

And just to be clear, the actual project, when you go to the dashboard to look, is it actually a Movie Trailer Website project?

Yes. And I am not making any request for that.

No, I can see that you are requesting project_id 5, not 2..
Well, I think I can safely say that this isn't a urcli issue. It simply has to be an API issue, since urcli doesn't change the SR (submission_request object) and cannot control what is being assigned. When the SR only contains project_id 5, then that is what the API itself is using. So urcli is creating the correct SR, and the API is assigning incorrect projects.
All I can recommend that you do is to write in to reviews support and put "urgent" in the subject line, so that they look at it asap. Let me know how it goes.

You are right that I am requesting Project 5, not 2, but project 2 keeps coming in.
Fair enough, I have written to review yesterday about this. Still waiting for a response. I will let you know if anything comes up.

Closing this as it's not a urcli issue, but I'd still like to hear what Udacity's response is, so let me know somehow when they get back to you.

I think we can close this, if the problem is not urcli.
Thanks @trolster you have been of great help.

OK, thanks for getting back to me! Good luck with the reviewing.


G2P release candidate

This release is coupled with the ga4gh.schemas/g2p and ga4gh.compliance/g2p repos.
It contains:

protocol buffer conversion
refactored API
sequenceAnnotations featureset implementation for feature search

@david4096 @jeromekelleher @kozbo  @diekhans :  can you take a look?  If possible I'd like to merge as soon as practical.   Thanks.

Seems like some minor changes to the feature branch +1 from me.

These look like minor changes to me too, +1.
Is the full PR for merging in G2P into master nearly ready @bwalsh?

@jeromekelleher : yes with this PR, we are ready to make PR to master on server/schema/compliance.  Thanks for the +1

Is there a reason we haven't merged this into the g2p branch yet?

Not that I'm aware.
-Brian Walsh
On Tue, Aug 9, 2016 at 10:49 AM, Danny Colligan<EMAIL_ADDRESS>wrote:

Is there a reason we haven't merged this into the g2p branch yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ga4gh/server/pull/1311#issuecomment-238633906, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC6wKrkJOAcBvLTEDGJSc4L4SoJVsTkks5qeL21gaJpZM4JVuPL
.


feat(sermux + crowtty): Move sermux/crowtty protocol into separate crate

This PR moves the sermux protocol format and definitions into a separate crate, removing the magic values from the crowtty crate

Note: This is going to conflict with #122 because I didn't plan ahead well. I'll fix the merge conflicts on whichever PR merges second.

oh, we might also want to add sermux-proto to the list of crates in source/, here: https://github.com/tosc-rs/mnemos/tree/main/source#folder-layout


add raw_field macro to compute raw ptr to field

Expose the part of offset_of! that computes a raw pointer to a field as a separate macro.
@Diggsey expressed that this would be interesting for their crate.
If rust-field-offset could depend on memoffset to use this macro, that would mean there is just one place we have to change once &raw (or an equivalent mechanism) becomes stable, so that everyone uses the blessed way to do this.
@Diggsey does this macro fit the needs of your crate?
@Gilnaa are you okay with adding this to the API surface of memoffset?

Sure. Has anything changed since this in Feb7?

That was about using offset_of!, which is not possible with the existing API of rust-field-offset.
This PR is implementing the proposal a bit up that thread:

If there was a crate which implemented this macro: raw_address_of!((*ptr_to_undef).bar) and which guaranteed in the future to compile down to the MIR operator your RFC introduced, whilst for the moment making a "best effort" attempt, then I would be happy to use that to implement (2) in this crate.

Before making a release, let's see if the API works for @Diggsey

Sure

Yeah, I'd be happy to depend on this crate for the raw_field function.

@RalfJung  Does this macro resolve your concern here? https://github.com/Gilnaa/memoffset/pull/21#issuecomment-526351780

@Amanieu this macro has nothing to do with container_of!. It just exposes something that we already did as part of offset_of! before, so there is no change to what happens to provenance.


AD410 Doorbell Alarm/Siren entity not exposed

this integration does not seem to expose the alarm entity as suggested in the documentation for the AD410 doorbell, everything else seems to work fine, including the strobe light functionality

Ip look into this today and get back with you

Ip look into this today and get back with you

I'm not able to find the API to control the siren yet. Still digging.

I'm not able to find the API to control the siren yet. Still digging.

Having a hard time finding the APIs to trigger the siren. Anyone else able to find it?

Nope.   I actually opened an Amcrest Support ticket asking specifically about the Siren API, and after several back and forths, got this absurd answer...
"_I was informed by the developers that this doorbell currently does not accept programable commands, and integrating that would require developing an entirely new firmware for the device.
In short, it looks like the siren command does not exist and is unlikely to be implemented I'm afraid._ "
What concerns me is this may be what to expect in a forthcoming firmware update - a complete neutering of the http server and API.    This appears to have already occurred with the equivalent Lorex doorbell and the latest firmware update to the Dahua DB6I.   Reports I've seen say they do NOT accept API commands.
Oh - there is a way to simulate a siren on the AD110/AD410.    Send a compatible G117 audio file that is long and loud of whatever siren sound you want.   The API for this is documented under 4.3.3 Post Audio Stream.    I've tested it sending an appropriately converted sound file with Home Assistant using curl system command and it works just fine.   It could be built in to the integration.


[question] Should "asIterable()" 1st element be equal to specified start datetime?

Assume a cron is set to trigger every day at midnight:
val builder = Builder().anyDays().hours(0).minutes(0).seconds(0)

When asIterable() with start datetime of 2050-01-01T00:00:00 is called, the first element would be 2050-01-02T00:00:00 (next day), not start datetime itself:
val start = LocalDate(2050, 1, 1).atTime(0, 0, 0)
val expected = start
val actual = builder.asIterable(start).first()
actual.shouldBeEqual(expected) // throws java.lang.AssertionError: 2050-01-02T00:00 should be equal to 2050-01-01T00:00

@Scogun Should it be like that? I think before introducing asIterable(start: LocalDateTime) this issue had no place (current datetime always been used) and the behaviour should be changed. This change would fix the issue.

Hey @Myshkouski,
This is a good catch!
However, the fix is not full. We have to compare seconds with the equal only in case the date time is not now.
Maybe will be better just decrise start time on one second and case it's not now?
Or even, we can just rename the parameter as from - means not include a provided value. So, in this case it will be a developer responsibility to provide from date a slightly earlier.


ExitArgs.Body should be []byte instead of string

To handle gzipped body content, its type should be string or we would meet the encoding error like "string field contains invalid UTF-8". I have tried to modify the source files but the problem is here in file_pluginsocket_proto_rawDesc.
var file_pluginsocket_proto_rawDesc = []byte{  	0x0a, 0x12, 0x70, 0x6c, 0x75, 0x67, 0x69, 0x6e, 0x73, 0x6f, 0x63, 0x6b, 0x65, 0x74, 0x2e, 0x70, 	0x72, 0x6f, 0x74, 0x6f, 0x12, 0x14, 0x6b, 0x6f, 0x6e, 0x67, 0x5f, 0x70, 0x6c, 0x75, 0x67, 0x69, 	0x6e, 0x5f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x63, 0x6f, 0x6c, 0x1a, 0x20, 0x67, 0x6f, 0x6f, 0x67, 	0x6c, 0x65, 0x2f, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x62, 0x75, 0x66, 0x2f, 0x64, 0x65, 0x73, 0x63, 	0x72, 0x69, 0x70, 0x74, 0x6f, 0x72, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x1a, 0x1b, 0x67, 0x6f, ... }
I suspect that file_pluginsocket_proto_rawDesc contains protobuf specs in binaries, right?

I saw https://github.com/Kong/go-pdk/pull/132 got merged, and it sounds like it fixes that you are describing, is that correct?

Closing this as resolved.


[5.2] Cannot mock request for testing

When I mock request for testing in Laravel 5.2
Request::shouldReceive('input')
            ->once()
            ->andReturn(['key' => 'value']);

I got this error:
BadMethodCallException: Method Mockery_0_Illuminate_Http_Request::setUserResolver() does not exist on this mock object.
I already disable Middleware in my test class.
Is it bug or my code is wrong ?
Please help, thanks

setUserResolver is getting called on the request by laravel, so your mock is insufficient.
I wouldn't recommend mocking this class anyway.

Not ideal, but works:
    protected function createRequest(         $method,         $content,         $uri = '/test',         $server = ['CONTENT_TYPE' => 'application/json'],         $parameters = [],         $cookies = [],         $files = []     ) {         $request = new \Illuminate\Http\Request;         return $request->createFromBase(             \Symfony\Component\HttpFoundation\Request::create(                 $uri,                 $method,                 $parameters,                 $cookies,                 $files,                 $server,                 $content             )         );     }


[$1000]  CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Click CTRL+K, it should open search
Click CTRL+SHIFT+K, it should open new group search
Again click CTRL+K, it closes everything instead of opening search

Expected Result:
App should reopen search page when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K
Actual Result:
App closes everything when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.55-3
Reproducible in staging?: y
**Reproducible in production?:**n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/32c4d539-5f40-4327-b64f-ab5d7dec5a79
https://github.com/Expensify/App/assets/43996225/8ff0059a-deae-447c-b06a-af35dcb79db7
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692434730707179
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e2284d0efa12310e
Upwork Job ID:<PHONE_NUMBER>544455168
Last Price Increase: 2023-08-21

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything
What is the root cause of that problem?
https://github.com/Expensify/App/blob/58dc0c9576f8c3d3fa8924a7fec0889232c4b537/src/libs/Navigation/linkTo.js?#L62-L74
here on the right side navigate present NewGroup_Root and Search_Root both are in different stack navigators once is first time opened it will push when second-time shortcut key pressed state not updating so again pressed whatever in the state its closed.

What changes do you think we should make in order to solve the problem?
return Navigation.navigate(ROUTES.SEARCH, CONST.NAVIGATION.TYPE.UP);
return Navigation.navigate(ROUTES.NEW_GROUP, CONST.NAVIGATION.TYPE.UP);

in up
action.type = 'REPLACE';
replace the route.

I don't reproduce
https://github.com/Expensify/App/assets/19537677/cab36df1-51eb-4389-8e4f-df0f0899aec0

@ShogunFire I am not sure why you are not able to reproduce. but this is still there even though staging is able to reproduce and I checked in locally with the latest code.
https://github.com/Expensify/App/assets/16595846/37aea6ef-4b4b-4937-9dc8-37a2ca56c7c7

Yes still able to reproduce

@pradeepmdk This is a deploy blocker, can you point to a change which introduced this behaviour? I dont see it in your proposal and without it its hard to judge as we want to know the root cause of why this is happening in staging but not in production

@mountiny I think this one I saw removed the replace https://github.com/Expensify/App/pull/22355/files

@mountiny Please revert https://github.com/Expensify/App/pull/24165
Reverting changes fixes the behaviour
Should I open a PR to revert this?

@mountiny Please revert #24165 Reverting changes fixes the behaviour Should I open a PR to revert this?

Meanwhile, I am investigating the problem with the current code.

I have created a revert here https://github.com/Expensify/App/pull/25572 could we make sure this bug is not repro there?

Here is the recording
https://github.com/Expensify/App/assets/58412969/0faa6ab3-ecd8-4c8b-92d1-a90a437b6aee

@mountiny @aimane-chnaif Maybe I have fixed the issue without revert

Proposal
Please re-state the problem that we are trying to solve in this issue.
CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything
What is the root cause of that problem?
This is happening due to multiple race conditions between window.history methods and the onStateChange method execution. Due to this, multiple window.history.go(-1) calls were made.
What changes do you think we should make in order to solve the problem?
By patching the series function in useLinking.js of @react-navigation/native cause original function has bugs.

I have already have branch ready for PR
If you want to make a PR, just confirm here. I will put one up immediately.

@shubham1206agra can you provide a proposal with the solution exactly and show its working as expected please? We wont steal your solution if it works but also want to avoid wasting time in case its not good solution.

https://github.com/Expensify/App/assets/58412969/e8a7ddde-6062-44a7-8e09-711395d12ed8

@mountiny @ShogunFire is correct this pr only causing this issue
in the previous historyDelta  is 0 means this will trigger history.replace({
path,
state
});
but now
they are checking the state and removing it from history and directly redirecting to the root one. by using
await history.go(-staleHistoryDiff);

that is why we are redirected to root one.

Issue https://github.com/Expensify/App/issues/20908
https://github.com/Expensify/App/assets/58412969/41d8c255-05f3-4701-ab17-26a8cb548e79

Issue https://github.com/Expensify/App/issues/21356
https://github.com/Expensify/App/assets/58412969/99098faa-2f11-4aa8-a6ba-58ac6f18150e

Issue https://github.com/Expensify/App/issues/23796
https://github.com/Expensify/App/assets/58412969/f148a25b-c3e3-49ec-941c-d4f410e0a81f

Does not fix https://github.com/Expensify/App/issues/25412

Does not fix #25412

Temp logs
{
    "index": 1,
    "indexGetter": 1,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 3,
    "indexGetter": 3,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 3,
    "indexGetter": 3,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 2,
    "indexGetter": 2,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/settings",
            "id": "OGJAC-QkjFmJLEzjNjci6",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings/about",
            "id": "dVlBM7I6DvSCwR2sv5eeY",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "path": "/r/7323501660300024",
            "id": "GhiTr-GpHH6SW8lA25iqS",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}
createMemoryHistory.js:7 {
    "index": 1,
    "indexGetter": 1,
    "items": [
        {
            "path": "/r/1705808921226559",
            "id": "8hugcF4Du91dOHzCvk6-l",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        },
        {
            "selected": "<<<<<<<",
            "path": "/settings",
            "id": "Ddpn6LV45RYRFw_ng7kjD",
            "state": "stack-bteljlS4gW7AcWp49NQpC"
        }
    ]
}

@shubham1206agra What is the change you've done in patch? the branch includes already existing patch code as well.

I just changed the series function in useLinking.js as the old implementation has bugs and does not work as intended.

Can you please specify this step a bit more, it will help @adamgrzybowski to review the changes please

I just used this function
const series = (cb) => {
  let queue = Promise.resolve();
  const callback = () => {
    queue = queue.then(cb);
  };
  return callback;
};

Which chains the promise to execute sequentially, which the previous function somehow fails to prevent.

@shubham1206agra i saw In the code node_modules currently we have this only after the patch apply

how this will resolve this issue

I just used this function
const series = (cb) => {
  let queue = Promise.resolve();
  const callback = () => {
    queue = queue.then(cb);
  };
  return callback;
};

Which chains the promise to execute sequentially, which the previous function somehow fails to prevent.

@shubham1206agra i saw In the code node_modules currently we have this only after the patch apply

how this will resolve this issue

I just used this function
const series = (cb) => {
  let queue = Promise.resolve();
  const callback = () => {
    queue = queue.then(cb);
  };
  return callback;
};

Which chains the promise to execute sequentially, which the previous function somehow fails to prevent.

I think you are misunderstanding the patch file here + or - is there right. that only is the changes of patch file

so in the current change of patch file nothing modifed in the series functions

I haven't put the updated patch in main repo.

Adding index instead of n in the and patching it would solve half of the issue. It's just brute force method.

@shubham1206agra So is your solution the same as the one presented here? https://github.com/react-navigation/react-navigation/pull/11485. That would make sense.

@shubham1206agra So is your solution the same as the one presented here? https://github.com/react-navigation/react-navigation/pull/11485. That would make sense.

Yes

@shubham1206agra So is your solution the same as the one presented here? react-navigation/react-navigation#11485. That would make sense.

And I have applied one extra try-catch block which was missed earlier
And I have returned Promise.resolve() instead of empty return in go method

@adamgrzybowski About #25412
I don't know what is the ideal behaviour
Can you confirm it?
Cause UI is getting messed up in this

@adamgrzybowski And should I remove log method which was left earlier in createMemoryHistory.js

@shubham1206agra
We should keep the log function but comment out lines where it is used
Not sure what about extra try-catch and Promise.resolve. What problem does it solve? Could you please elaborate on it more?
About #25412 we are looking into this one with @WoLewicki. This one is weeeeird 😄

About https://github.com/Expensify/App/issues/25412 we are looking into this one with @WoLewicki. This one is weeeeird 😄

This one won't happen if we add Navigation.dismissModal() before going to concierge in AboutPage.js

https://expensify.slack.com/archives/C049HHMV9SM/p1691856719118529
https://expensify.slack.com/archives/C049HHMV9SM/p1691838672213229
I see 2 above bugs that maybe relate to this issue. @mountiny @Ollyws  Could you check and decide if it could be fixed in this issue

https://expensify.slack.com/archives/C049HHMV9SM/p1691856719118529
This one is expected as Modal.close() maybe was called in the opening of KeyboardShortcutModal. So it closes the YearPickerModal

https://expensify.slack.com/archives/C049HHMV9SM/p1691838672213229
This one I am able to repro

Not sure what about extra try-catch and Promise.resolve. What problem does it solve? Could you please elaborate on it more?
Promise.resolve I used to make function behaviour on await more consistent. And try-catch was there so that if somehow await go was called with reject. It will not run the history.push does not run afterwards

@mountiny I think this report is related to this one https://expensify.slack.com/archives/C049HHMV9SM/p1691838672213229.
I reported this issue earlier in the slack

Making this weekly we are looking into getting https://github.com/react-navigation/react-navigation/pull/11485 merged to react navigation upstream for now

Looks like this is the reason behind revert failing
https://github.com/Expensify/App/pull/22437#issuecomment-1691525117

Although did we figure out the root cause in our code? Because this has worked before right? And the bug in react-navigation is there for a while now

Yes, it is happening due to the patch
Explained in this comment clearly which part causing the issue
https://github.com/Expensify/App/issues/25527#issuecomment-1686368464
And somewhat explained in this comment
https://github.com/Expensify/App/pull/25572#issuecomment-1686124384

@shubham1206agra thanks! too many comments these days
Alright @Ollyws @adamgrzybowski do you think we should wait for upstream fix or update this in a patch to react naivgation now?

I would say update the patch. We don't know when the upstream will be ready for 6.x and we need to bump the version anyway. But I would patch only the series function with the code from this PR and nothing else.

Ok ok @shubham1206agra Do you want to do that?

Yes I will do that

@shubham1206agra please go ahead and rasie the PR, thanks!

PR raised

@Ollyws You can do the checklisst

I have raised another PR cause the previous PR got reverted. Should be merged after the build fix

Hold on, Melvin. We're waiting for this PR to be merged and deployed before we process payment https://github.com/Expensify/App/pull/25989

@Ollyws @shubham1206agra this is not repro on main probably after the styling refactor
However there is a new issue with this switching:

Open the Search
Use CMD + SHIFT +K to open the new group
Use CMD + K  to go back to search

It closes the RHP
or if you do:

Open settings
CMD + K to open search
CMK + SHIFT + K to open new group
CMD + K again to open search
The Settings page shows

It seems like when you go there and back it also goeas one back in the RHP stack ie closes it if there is nothign
@shubham1206agra Could you check if your additional patch will fix these? If not would you be interested to investigate these aforementioned issues as part of this issue?

@mountiny I am able to repro the original issue on the latest main. Can you check this again, please?
I have done also npm ci after pulling main

I cannot reproduce, but can repro what I wrote here
https://github.com/Expensify/App/assets/36083550/33b77874-bb01-4b66-8e4f-83909809bcf5
@shubham1206agra

Perfect, thanks! could you update the Test and QA steps in the PR to follow what was described above and ask the C+ for new review and retest please? cc @Ollyws thank you!

I think we can give th ebonus as the delay was not your fault

@Ollyws I think you still need to accept the offer in Upworks. Can you also get started on the checklist?
@shubham1206agra and @dhanashree-sawant payments have been sent.

I think we can give th ebonus as the delay was not your fault

@tjferriss Can you confirm about bonus here?

@tjferriss Can you confirm this?

Confirmed, yes. I've updated both of your payments to include the bonus amount.
Payment summary:

@Ollyws Reviewer $1500
@shubham1206agra Contributor $1500
@dhanashree-sawant Reporter $250

Thanks for the detail. I think we're all good here.


fps not working correctly

The game_of_life.update() function gets called a lot more than it should, based on the generation.
Try adding window.set_title(game_of_life.generation.to_string()); to the event loop, uncomment the generation counting system and pass --fps 1 and it's pretty obvious. The effect is especially noticeable when you move your mouse cursor.
To fix this more should be learnt about what events actually get processed by the event loop and how to filter them.

Maybe game_of_life.update() should be moved to the drawing function, like:
window.draw_2d(&e, |c, g| {
    // ... snip ...
    game_of_life.update();
});

Maybe game_of_life.update() should be moved to the drawing function?

In bdd6661 I've done this, it seemed to improve performance.

Maybe game_of_life.update() should be moved to the drawing function?

I know that's a solution, it's why I originally put it there before you reverted my change.

Also, when passing --fps 1, the updating happens only once per second.

That's curious, it really didn't on my build (when it wasn't in the draw_2d()) and I checked it with println!("{:?}", e);.
The draw_2d() doesn't run it's closure unless &e is a render event.
I think I fixed it in this branch, should I create a pull request?

That's curious, it really didn't on my build (when it wasn't in the draw_2d()) and I checked it with println!("{:?}", e);.

No, I meant when it was inside the draw_2d closure.

I think I fixed it in this branch, should I create a pull request?

The current implementation works fine for me, so I think that's not necessary. I will close this now, but if you think there still is a problem, please reopen.


Add Clover Configurator.app v4.41.1

Add Clover Configurator.app v4.41.1 to homebrew cask
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the [token reference].
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no [open pull requests] for the same cask.
[x] Checked the cask was not already refused in [closed issues].
[x] Checked the cask is submitted to [the correct repo].

Verified locally.

@miccal This is an unversioned URL - isn't the standard to usually have sha256 :no_check and version :latest?

@numbermaniac but it has an appcast, meaning it also requires a version and sha256.


docs: Added matrix multiplication example

This adds a somewhat complex example, which does matrix multiplication. The examples has code to:

Load matrix in column or row major order from the advice tape using adv_pipe to memory. The format is optimized to stream the data from the tape, and not to be compact. This supports arbitrary sized matrices.
Code to multiply two matrices, the only limitation on the matrices sizes is that col and row size must be a u32, and the matrices must be compatible to perform the multiplication. The algorithm in cubic.

moving this to the example repository


Enable resizing the panes with the keyboard.

Summary of the Pull Request
Adds the ability to resize panes with the keyboard.

PR Checklist

[x] Closes #991
[x] I work here
[ ] Tests added/passed - this box makes me cry
[x] I actually kinda just went for this one.

Detailed Description of the Pull Request / Additional comments
This is accomplished by making the Column/RowDefinitions for a Pane use GridLengthHelper::FromPixels to set their size. We store a pair of floats that represents the relative amount that each pane takes out of the parent pane. When the window is resized, we use that percentage to figure out the new size of each child in pixels, and manually size each column.
Then, when the user presses the keybindings for resizePane{Left/Right/Up/Down}, we'll adjust those percentages, and resize the rows/cols as appropriate.
Currently, each pane adjusts the width/height by 5% of the total size at a time. I am not in love with this, but it works for now. I think when we get support for keybindings with arbitrary arg blobs, then we could do either a percent movement, or a number of characters at a time. The number of characters one would be trickier, because we'd have to get the focused control, and get the number of pixels per character, as adjacent panes might not have the same font sizes.

 Even if the horizontal split is nested inside the vertical one?

 Even if the horizontal split is nested inside the vertical one?

Yup.  I'll have another PR to follow this one for moving pane focus


Redesign website

What happened?
The website UI can be made better by choosing a better colour scheme as well as a better font. I will also try to fix as many broken image links as possible.
I am a GSSOC 22 contributor. Please assign. this issue to me.
How can we reproduce this bug?
Visit the awesome-chrome-extensions website
Desktop Information (Optional)
No response
Urgency (Optional)
No response

Go forward with it @Adhetya


[UBS.Order form] The user can't add a new address after typing the full name of city and street in the 'Місто' and 'Вулиця' fields when the system doesn't have any suggestion based on API in the 'Нова адреса' pop-up

Environment: Windows 10, Google Chrome Version 110.0.5481.78 (Official Build) (64-bit).
Reproducible: always.
Build found: 13/02/2023
Preconditions

Login to GreenCity as a User https://www.testgreencity.ga/GreenCityClient/#
UBS Order form is opened.
All required fields on the tab "Деталі замовлення" are filled in and the tab "Особисті дані" is active .
User can add only 4 addresses.

Steps to reproduce

Click on the "Додати адресу" button.
Type the full name of the city in the 'Місто' field
Type the full name of the street in the 'Вулиця' field
Fill in the  'Будинок' and 'Район' fields as required.
Pay attention to the 'Додати адресу' button.

Actual result
The 'Додати адресу' button is disabled when user type the full name of city and street in the 'Місто' and 'Вулиця' fields on the 'Нова адреса' pop-up
https://user-images.githubusercontent.com/120178274/230457050-2b163da7-b21b-4928-8fff-d3ee5ee959e8.mp4
Expected result
The 'Додати адресу' button is enabled.
Additional info
Bug is also reproduced in the Admin Cabinet
User story and test case links
"User story" #5101, #2199

It is impossible to select the street that not exist from google map search (Ростиславська)


Remove epoch, as it blocks the latest version from downloading

...Nevermind, this requires more changes to work properly.


Fix Opendatacam Darknet Base docker tag

We create the Opendatacam docker image on top of https://hub.docker.com/r/opendatacam/opendatacam-darknet-base.
However the every build always takes the most recent version. This is bad practice as changes in darknet base image as required for v4, could break the v3 releases if we need to create a new v3 image.
Therefore I want to introduce semantic versioning in the darknet base and fix the v3 branch to specific releases of darknet base.
Breakdown

[ ] Update the github workflow in https://github.com/opendatacam/darknet to create tagged releases
[ ] Release https://hub.docker.com/r/opendatacam/opendatacam-darknet-base v1.0.0
[ ] Use https://hub.docker.com/r/opendatacam/opendatacam-darknet-base v1.0.0 in v3.0.2

may i just ask what you think will break? you got some custom tweaks in there?

Exactly. Darknet was forked by @tdurand a while back and not updated since.
For the v4 release consider going back to the upstream version. As I don't know how far these have grown apart I see a real risk of breaking changes.
To ensure we can still build v3 images I therefore want to create a proper tag in GitHub and Docker.

The fork was very light, as darknet isn't versioned you can almost consider it as a tag. It is documented here: https://github.com/opendatacam/darknet/pull/7/files
Just a few comments and a .config file to use yolov4 with 416x416 config instead of 640x640
Not sure how darknet API evolved since.. but I don't think it changed.

why not use its binary and let python handle the changes?

How do you mean?

well if those small changes  are the only blockers  preventing you from using updated repos (anf i totally get why it is a risk) , id use libdarknet.so and build a tiny py app. youll have better control of the streams and will be version agnostic. ill gladly write a poc for you

It's a bit more then this. We also build different binaries for the different platforms to maximize performance.
Therefore we will probably keep the ODC Darknet repo and build process even after we update the code base to the upstream version.
One can probably find a work around but it's really no big deal to create our own tagged docker images. I just don't have Internet at home right now which is why this is delayed 🙄

It's a bit more then this. We also build different binaries for the different platforms to maximize performance.
Therefore we will probably keep the ODC Darknet repo and build process even after we update the code base to the upstream version.
One can probably find a work around but it's really no big deal to create our own tagged docker images. I just don't have Internet at home right now which is why this is delayed 🙄

is that even allowed to put nerds through in 2021?! 😅

In Germany they can as Internet is not considered a basic necessity compared to e.g. electricity. But we're getting off topic here....

Fixed in #446. Keeping this open until v3.0.2 is released.

Closed as v3.0.2 is now released.
See also https://github.com/opendatacam/opendatacam/releases/tag/v3.0.2

i know its closed but gz on release.

Thank you 😙


Add charts for Tenable Enclave Security

This will add in the helm charts for tenable enclave security and update the repo's index

LGTM!


Documentation: "Compatibility Version Information" is not up-to-date, since "Configuration Options" mentions also 1.26

"Compatibility Version Information" says max compat version is 1.18, but "Configuration Options" mentions 1.26 for bindingSyntax.
Also the whole description is not quite clear: What can I use for data-sap-ui-compatVersion? All major versions? Minor Versions?

Hi,
thanks for pointing this out,
you can specify all major and minor versions but certain features have toggles depending on the version, for example the binding syntax.
So writing compatVersion="1.26" is a valid entry
I agree that the documentation is not clear [here] (https://openui5.hana.ondemand.com/#docs/guide/9feb96da02c2429bb1afcf6534d77c79.html) .
1.26 is mentioned [here] (https://openui5.hana.ondemand.com/#docs/guide/91f2d03b6f4d1014b6dd926db0e91070.html)
traked internally:
Thanks for pointing it out
Best regards,
TObias

The issue number was missing:<PHONE_NUMBER>
but still there is no update in the ticket... sorry for this

Well it is a bit embarrasing but anyways i finally took the issue over.
I passed the documentation over to our docu team. So it will probably available soon. I will keep you updated here.
Sorry for taking ages

Hi,
finally we have a progress.
The updated documentation can be found here
The main point is

The concept of compatibility versions has been abandoned as of version 1.28. Therefore, there will be no new compatibility version flags in the future. If you start building a new application please set data-sap-ui-compatVersion="edge" on your OpenUI5 bootstrap tag.

We also adjustet the tables. It turned out that 1.28 is complex binding syntax together with edge.
Best regards,
Tobias

https://sapui5.netweaver.ondemand.com/sdk/#docs/guide/0c803921b1bf4b3a97a038fbd51ef542.html still mentions the configuration flag xx-bindingSyntax, which
a) should be bindingSyntax
b) should mention that with compatVersion="edge" and >=1.28 this is no longer necessary

I see that on https://openui5.hana.ondemand.com/#docs/guide/0c803921b1bf4b3a97a038fbd51ef542.html at least a) is correct.

But https://openui5.hana.ondemand.com/#docs/guide/daf6852a04b44d118963968a1239d2c0.html still mentions xx-bindingSyntax and also b) should be mentioned here.


PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/Downloads/php-ring-api-master/ring.php on line 96

When i run the example file. after add change to my username and passwd i got this:
PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/Downloads/php-ring-api-master/ring.php on line 96
The authenticating works as it should.
If i run this in chrome
Call: https://api.ring.com/clients_api/dings/active?api_version=9&auth_token=zzbGBjWFcvCZKArwFQfH
The only i got is this.
[ ]

@pixiandreas I hope that auth token isn't valid...

I have the same problem

Call: https://api.ring.com/clients_api/dings/active?api_version=9&auth_token=mytoken

PHP Warning:  Invalid argument supplied for foreach() in /home/pi/php-ring-api-master/ring.php on line 96

When i run this in chrome : https://api.ring.com/clients_api/dings/active?api_version=9&auth_token=mytoken
I have a correct answer :

{"doorbots":[{"id":123456,"description":"Porte de devant","device_id":"f12ae235687","time_zone":"Europe/Brussels", ......

an idea ?
thanks

I get this too, help!

I have the same issue.
Warning: Invalid argument supplied for foreach() in ring.php on line 98

I've pushed a new version, this should fix the foreach issue.

Working ok, when i run forsome hours but then the same eror again , a restart solving the problem.
Oct 06 09:49:16 hass php[16695]: PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/scripts/php-ring
Oct 06 09:49:19 hass php[16695]: PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/scripts/php-ring
Oct 06 09:49:23 hass php[16695]: PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/scripts/php-ring
Oct 06 09:49:27 hass php[16695]: PHP Warning:  Invalid argument supplied for foreach() in /home/andreas/scripts/php-ring


Insert Zotero item gives an error

Hi
Thanks so much for building the plugin. I was looking for this.
I setup the plugin and Zotero based on the instructions provided. The settings page also shows that the connection is working. However, when I try to insert a zotero item, it gives an error. Please see attached.

I am also providing the template and my settings for the plugin

Would really appreciate if you could give me an idea if I am doing something wrong here. I am using Zotero 7 and latest version of the plugin. Setup the whole thing in the last hour

For the second screenshot on the template could you do it without being in edit mode? Eg press Escape then take the screenshot.

This should be fixed in the latest version. Am going to close this issue for now but the original author can continue to reply to this issue (I'll look out for it) or create another issue if it still persists for them.


Amazing module... Can this be ported to non-webpack plain nodejs?

I'd love to run this for my nodejs server. Do you think you could port this to use without webpack?

Can you explain how you would expect to use a module in node to discover circular dependencies?
I feel like this could work easily with webpack using the node target, as a part of CI verification.
Without webpack would require overloading node's require() method.

I was thinking more as a static analysis tool for non-webpack stuff (like
servers).
I think this is also more likely to be run on a one-off basis before a
commit as part of a task than as continuously during dev. The performance
isn't bad but it does slow down my reload when I plug it into my webpack
watcher. Also I don't really think its necessary to be continuously
verifying, it's pretty rare that you'll make circular references.
ᐧ
On Mon, Oct 17, 2016 at 4:42 PM, Aaron Ackerman<EMAIL_ADDRESS>wrote:

Can you explain how you would expect to use a module in node to discover
circular dependencies?
I feel like this could work easily with webpack using the node target, as
a part of CI verification.
Without webpack would require overloading node's require() method.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aackerman/circular-dependency-plugin/issues/11#issuecomment-254366361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC__QCvAsU2o2f-p1sYM-9Gd4H6GMmrtks5q1Af8gaJpZM4KZLjt
.

ᐧ

@wlingke you can use madge for that.
We used it for a long time before and it works fine.

Ah okay thanks!
On Thu, Dec 1, 2016 at 10:12 AM, Vitaliy Potapov<EMAIL_ADDRESS>wrote:

@wlingke https://github.com/wlingke you can use madge
https://github.com/pahen/madge for that.
We used it for a long time before and it works fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aackerman/circular-dependency-plugin/issues/11#issuecomment-264248887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC__QA6pKpk1r25O50A7yyhK_nBgiZ_yks5rDw32gaJpZM4KZLjt
.