Wrong file naming error YoJson when Yojson was expected

Trying to get this working on OSX 10.12.3.
I've tried switching and un/installing 4.04 and 4.02.3 (my system version):
corebuild -r -pkg core -pkg yojson test.native

I get the following:
Error: Wrong file naming: /Users/blah/.opam/system/lib/yojson/yoJson.cmi
contains the compiled interface for
YoJson when Yojson was expected
Command exited with code 2.
Compilation unsuccessful after building 2 targets (1 cached) in 00:00:00.

Note, using ocamlbuild directly gives me the same error.

This has to come from something outside of yojson. I never use camelCase for new OCaml identifiers.
Feel free to reopen the issue if there's a bad interaction with some public component.


path argument is used to create an intersection with existing finder

ref #1719
@tifabien , please, could you heavily play with this change?
(especially from CLI user side and your hooks)

I'll test it asap but at the first look it seems it will solve my problem :)
Thanks a lot!

General question.
We could backport this change to 1.x as well (ref https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/1.12/Symfony/CS/Console/Command/FixCommand.php#L356)
It may be considered as behaviour change, and for that BC break - because one asked for fixing excluded file and it won't be fixed.
Also, it may be considered as bug fix, so not BC break - because one asked to fix file, use configuration that exclude this file so finally it should not be changed.
Any thoughts about change itself and then target version ?
cc @stof @sstok @GrahamCampbell @SpacePossum @gharlan @ceeram and everybody  ;)

I think it's fine on 2.x only.

It shouldn't. Please measure and show.
We will need to do it that way on 2.x when we will have cachingIterator to lint files before fixing them, and we need to ommit some files before linting

:+1: I tested my side and it works like a charm :)
Small question, Do you know when you'll plan to release the 2.x?
Thanks a lot !

Great to hear!
I'm still waiting for some more opinions on this PR.
About release - I won't give you exact date, but I think we are close:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/milestones/v2.0

Any thoughts about change itself and then target version ?

:+1: for change itself, but only 2.x

Besides https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1742#discussion_r52050731 I would like to have a little explaining about the new behavior if that is ok :)
(maybe we could at it to the docs somewhere as well?)
If I understand the issue correctly together with the PR; the fixer should only fix the given file / files in the directory passed on by command line argument, but still honor the finder exclude rules set in the config file (and fixers/level)?
(and not apply possibly broader finder rules that would be out of the directory passed on by the command line?)

@SpacePossum
it would create an intersection
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1742/files#diff-62b374855f5961454b817b144c531e27R425
So, if you run the tool with both finder in configuration and path as CLI arguments only the files that would be found by both finders will be fixed.

Thanks for the explaining :)
So if one would black list directory a/b/c in its config and than run the fixer using a/b/c as input path by the command line, what would happen?

Intersection would be empty.
That's the point of @tifabien #1719
If one configure his project to not touch sth, it should not be touched. If one decided to change that configuration - that's what config file is for.
Also remember that one can't exclude path by CLI.

I see, I would like the command line input to be leading in this case. I thought the issue reported was something like;

config blacklists dir a/b/c
run with command line a/b
a/b/c is still being fixed

your PR will fix that, so :+1:  :)
However as a result of the PR, it will be impossible to fix files in a/b/c using the command line without changing the config file. If one would explicitly pass a/b/c as command line arg, I would expected the fixer to ran over dir. Its a tricky one, I think both solutions have + and -, so I'm still :+1: for the change as it fixes the issue for some people and +0 for the side effect :)

Done from my side.
It would be really nice to close it fast ;)

@keradus please take a look at https://github.com/keradus/PHP-CS-Fixer/pull/15

@keradus please take a look at keradus#15

merged, thank you @gharlan !

looking good :)
:+1:

looks ready

:+1:

Thank you @gharlan.

thanks!


Linker works for joined issue reference text

Default issue pattern links following text lines:

ACM-123ABC-123
0ABC-123
ABC-123A

Seems, it should ignore such lines
Sugession for regex pattern: (^|[^a-zA-Z0-9])([a-zA-Z]+-[0-9]+)([^a-zA-Z0-9]|$) instead of [a-zA-Z]+-[0-9]+

We had the exact same issue but found that the app doesn't care for non-capturing groups or capture groups. Therefore we created this alternative regex which uses non-capturing look-behind and look-ahead groups and makes it possible to have certain special characters lead of trail the issue ID:
(?<=$|\s|\,|\;|\:|\.|\!|\?)[a-zA-Z]+-[0-9]+(?=$|\s|\,|\;|\:|\.|\!|\?)

We had the exact same issue (e.g. in situations like "abc123-456def-789ghi-jkl") but found that the app doesn't care for non-capturing groups or capture groups in general. Therefore we created this alternative regex which uses non-capturing look-behind and look-ahead groups and makes it possible to have certain special characters lead or trail the issue ID:
(?<=^|\s|\,|\;|\:|\.|\!|\?)[a-zA-Z]+-[0-9]+(?=$|\s|\,|\;|\:|\.|\!|\?)

Hi @yahesh! Thanks for your solution, regex lookaround is exactly what fixed the problem!
I've added lookbehind (?<=^|[^a-zA-Z0-9]) and lookaround (?=[^a-zA-Z0-9]|$) to issue pattern.
Also exclude pattern was added for markdown link like [...](https://...).


How to pass SSML language?

Hello,
I would like(as described in the google api doc) pass an SSML pause. How to do this please?
Thank you.

Hello! Please see this sample for synthesizing SSML! The main sample looks like this:
use Google\Cloud\TextToSpeech\V1\AudioConfig;
use Google\Cloud\TextToSpeech\V1\AudioEncoding;
use Google\Cloud\TextToSpeech\V1\SsmlVoiceGender;
use Google\Cloud\TextToSpeech\V1\SynthesisInput;
use Google\Cloud\TextToSpeech\V1\TextToSpeechClient;
use Google\Cloud\TextToSpeech\V1\VoiceSelectionParams;

$path = 'Path to SSML file to synthesize';

// create client object
$client = new TextToSpeechClient();

// get ssml from file
$ssml = file_get_contents($path);
$input_text = (new SynthesisInput())
    ->setSsml($ssml);

// note: the voice can also be specified by name
// names of voices can be retrieved with $client->listVoices()
$voice = (new VoiceSelectionParams())
    ->setLanguageCode('en-US')
    ->setSsmlGender(SsmlVoiceGender::FEMALE);

$audioConfig = (new AudioConfig())
    ->setAudioEncoding(AudioEncoding::MP3);
$response = $client->synthesizeSpeech($input_text, $voice, $audioConfig);
$audioContent = $response->getAudioContent();

// write output to mp3 file
file_put_contents('output.mp3', $audioContent);

You can run the sample by doing the following on your CLI:
git clone https://github.com/GoogleCloudPlatform/php-docs-samples
cd php-docs-samples/texttospeech
composer install
php src/synthesize_ssml_file.php path/to/your/file.ssml

Here is an example SSML file


Bcachefs support

I realized that in order to build an ISO with bcachefs support I need to build the ISO using nix, except I can't do that from macOS 😕
Would it be possible to include bcachefs-tools and the kernel module in the prebuilt ISO? It seems like it should be supported since Linux 6.7... However I don't see it in the kernel config file in this repository despite using the 6.9 kernel.

Actually, I might be able to use the prebuilt ISO with nix shell  for bcachefs-tools with an overlay that overrides fuseSupport. That way I can try using bcachefs format and bcachefs fusemount`. However it'd still be nice if btrfs/bcachefs were supported out of the box.

This is probably possible, I will have to check that everything cross-compiles properly. We would also have to enable the appropriate kernel config. If you have access to another Linux machine or VM it should be easy to build your own ISO with this feature.
I will consider it for next release, but no promises. Certainly no ZFS!


ignoreTrailingSlahes()

I'd like to help with this project. I forked repository and I'd like to start with something easy like trailing slashes, just to dive into javalin. So, I think I want to implement this feature.

How would you like to see this feature? I think it is nice work around full Javalin server, so
Javalin.setTrailingSlashesIgnored(boolean ignored).
But probably we could add rules for endpoints?

Thanks, @enchantinggg4, great that you want to help.
The current convention is to omit get/set from methods in Javalin, so port(0) is setPort(0), and port() is getPort().
This feature should be ignoreTrailingSpaces(), or if we flip it around, (as I think we should), it should be dontIgnoreTrailingSpaces(), or treatTrailingSpacesAsSeparateUrls(), or something similar.
I think most people expect /user/:id and /user/:id/ to map to the same resource these days, so that should probably be the default setting.

Hi,
I thought about it, I 'll fix it today.
On Aug 3, 2017 11:18, "David"<EMAIL_ADDRESS>wrote:

Thanks, @enchantinggg4 https://github.com/enchantinggg4, great that you
want to help.
The current convention is to omit get/set from methods in Javalin, so
port(0) is setPort(0), and port() is getPort().
This feature should be ignoreTrailingSpaces(), or if we flip it around,
(as I think we should), it should be dontIgnoreTrailingSpaces(), or
treatTrailingSpacesAsSeparateUrls(), or something similar.
I think most people expect /user/:id and /user/:id/ to map to the same
resource these days, so that should probably be the default setting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tipsy/javalin/issues/35#issuecomment-319901488, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQRo4HRV0PIJFpwEHD6gQ5B0judDaEjEks5sUYJTgaJpZM4Orb0k
.


Has keras interface to load dataset for image classification?

For image classification, in the folder 'keras-master/examples', there are just examples for simple mnist and cifar10. And in these two examples, datasets is downloaded from an url and then get x_train and x_test.  So has keras interface to load dataset and get x_train and x_test from anywhere in own local dirs?

Check out https://blog.keras.io/building-powerful-image-classification-models-using-very-little-data.html


Add support for displaying the version with wt --version

Summary of the Pull Request
Here's 3000 words:

References

#4632

PR Checklist

[x] Closes #5494
[x] I work here
[ ] Tests added/passed
[n/a] Requires documentation to be updated

Can we merge this in? If it's got enough approvals, we should get this in for v1.


Updated to NetStandard2 and added NLog Layout-support for Uri, HubName and MethodName

@toddmeinershagen Ready for review

@toddmeinershagen Updating nunit requires that you stop using your own custom version of nuget.exe and nuget.targets.

@toddmeinershagen But yes manually updating Nuget.exe is also an option :)


rename repo to zipkin-ruby?

We don't need to rename any code inside, but renaming the repository to zipkin-ruby might make it more obvious to people that this is where to go for ruby frameworks.
wdyt?

Yes, it was historically named like this, I'm all for the change of name

done. thanks!


/findsymbols returns elements of name 'event MyEvent'

Use /findsymbols on a project with the following code:
namespace SharpChess.Model
{
public static class Game
{
public static event GameEvent GameResumed;
}
}
This returns an element with the name 'event GameResumed'.
Expected: 'GameResumed'

fixed in #138


Add end-to-end integration tests for website

Should include tests for website as well as Hello World sample app.

Closing issue. End to end test are not currently being implemented.


Issue using iphone

I'm facing an issue when trying to import the generated vcard on iphone. Before the iOS 13 update, when the vcard opened, the user could click on "Open in contacts", but now this option doesn't even appear or appear very hidden as "Copy to Contacts" but it seens like a disabled button.
Does anyone how to overcome this?

Hello. As far as I investigate this issue, I found that it still be possible, but not fluid anymore.
When you click and download the .vcf file, a preview of the Contact appears. Click 1 second on the picture to get the new menu on screen, with fully functional "add to contact" and "update contact" links.

It worked! Didn't know about this function hehe thank you so much!


[TRG Check Dashboard] monorepos should not throw warnings

checks on repositories containing multiple components (e.g. frontend + backend) should not throw warnings regarding TRG 1.02 + TRG 2.03

Hi @hzierer, is this really a dashboard issue? or more general quality checks tool related? can you provide an example of a monorepo for which it is an issue?

AFAIK, the warning for TRG 1.02 regarding a missing INSTALL.md is intended. This was meant to remind people, that it could be a good idea. But I also see, that it leads to confusion, especially in the monorepo case @hzierer mentioned.
I saw repos, where there have been INSTALL.md files, but in /frontend and /backend directories. In this case the reminder is odd, since they actually have the file. Just in a different place
For TRG 2.03, I only see potential issues regarding the DEPENDENCIES file name. In monorepos, we add _FRONTEND or _BACKEND suffixes. If we search for a fully matching DEPENDENCIES, this could lead to issues. The INSTALL.md issues from above could also be included in the repo structure check

@SebastianBezold I wouldn't say the reminder is odd since the check just follows TRG description  which is very clear where the INSTALL.md should be located. At the moment I see that we either amend description first and check afterwards or recommend monorepo's guys to reference other INSTALL.md files of components within original one located at root.

We will get an exclusion mechanism which will make this green. We will also create a ticket to support monorepos and prioritize that accordingly


rclone.conf write issue

What is the problem you are having with rclone?
Every operation that writes config (rclone config and update of token in other operations) fails with:
Failed to save config after 10 tries: failed to create config directory: mkdir C:\Users\username\.config\rclone\: Cannot create a file when that file already exists.

What is your rclone version (output from rclone version)
v1.47.0
Which OS you are using and how many bits (eg Windows 7, 64 bit)
windows 7/amd64
Which cloud storage system are you using? (eg Google Drive)
GDrive, OneDrive, Yandex
The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone lsd yandex:
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)
C:\> rclone -vv lsd yandex:
2019/05/07 18:24:59 DEBUG : rclone: Version "v1.47.0" starting with parameters ["C:\\ProgramData\\chocolatey\\lib\\rclone.portable\\tools\\rclone-v1.47.0-windows-amd64\\rclone.exe" "-vv" "lsd" "yandex:"]
2019/05/07 18:24:59 DEBUG : Using config file from "C:\\Users\\username\\.config\\rclone\\rclone.conf"
2019/05/07 18:25:03 Failed to save config after 10 tries: failed to create config directory: mkdir C:\Users\username\.config\rclone\: Cannot create a file when that file already exists.

Recreation of config helped...


ARROW-11842: [Rust][Parquet] Use clone_from in get_batch_with_dict

This changes the code to use slice::clone_from (https://doc.rust-lang.org/std/clone/trait.Clone.html#method.clone_from) instead of x = y.clone() which saves some allocations.
This gives a small speed up when reading parquet files.

Codecov Report

Merging #9619 (cb1700e) into master (35daca2) will increase coverage by 0.00%.
The diff coverage is 85.57%.

@@           Coverage Diff           @@
##           master    #9619   +/-   ##
=======================================
  Coverage   82.32%   82.32%
=======================================
  Files         245      245
  Lines       56412    56507   +95
=======================================
+ Hits        46442    46522   +80
- Misses       9970     9985   +15

Impacted Files
Coverage Δ

rust/benchmarks/src/bin/tpch.rs
38.33% <ø> (ø)

rust/arrow/src/datatypes/field.rs
55.47% <47.61%> (-0.66%)
:arrow_down:

rust/arrow/src/datatypes/schema.rs
73.39% <78.57%> (+0.76%)
:arrow_up:

rust/datafusion/src/datasource/memory.rs
84.11% <98.03%> (+4.11%)
:arrow_up:

rust/arrow/src/csv/reader.rs
93.17% <100.00%> (+0.02%)
:arrow_up:

rust/datafusion/src/logical_plan/expr.rs
83.39% <100.00%> (+0.32%)
:arrow_up:

rust/parquet/src/encodings/rle.rs
92.66% <100.00%> (-0.02%)
:arrow_down:

rust/arrow/src/array/equal/utils.rs
75.49% <0.00%> (-0.99%)
:arrow_down:

rust/arrow/src/array/transform/fixed_binary.rs
84.21% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2dd59...cb1700e. Read the comment docs.


Using Cognito credentials to authenticate S3?

I am building an app that allows users to upload their files to Amazon S3. I am authenticating users with Cognito, how do I pass the authenticated credentials to S3 so that a user has to be signed in and verified to be allowed to upload?

These two blog posts address how Cognito can be used with the .NET SDK - Amazon Cognito Credentials Provider and Updated Amazon Cognito Credentials Provider.

Closing as I believe this is answered. Feel free to reopen if you have more questions.


Slow dashboard query for large memberships

Issue Summary
We are self-hosting Ghost on AWS and running into a scalability issue on the dashboard.
It looks like when loading the post editor, a handful of XHR requests are made to the back end to obtain additional data.
One of these hits the following API endpoint:
/ghost/api/admin/newsletters/?status=active&limit=all&include=count.active_members
In our case, there are over 100k members and this query takes >20s to load on average. Here is the query:
# Query_time: 21.560752  Lock_time: 0.000270 Rows_sent: 7  Rows_examined: 2778958
use prodghost;
SET timestamp=1694200263;
select `newsletters`.*, (select count(`members_newsletters`.`id`) from `members_newsletters` inner join `members` on `members`.`id` = `members_newsletters`.`member_id` where members_newsletters.newsletter_id = newsletters.id and `members`.`email_disabled` = false) as `count__active_members` from `newsletters` order by sort_order ASC, created_at ASC, id ASC;

The problem with this query taking unreasonably long is that the publish button and other features are disabled until this request completes. So our admin users are led to believe they "can't" publish their posts.
AFAICT this query exists to get the number of active users to be displayed in the messaging before publishing.
Is there a reason for counting all active members other than UX? If not, might I suggest eliminating this query after a certain number of members is reached and changing the publisher messaging to suit?
Alternative potential fixes:

Cache active member counts
Improve query performance
Utilize progressive enhancement to make this API request non-critical for functionality

I understand this is unique for just a few sites on Ghost at this time (we had no issues until passing the 100k member threshold) but this will likely cause issues for any platform with a large user base which will (hopefully) be more common as Ghost grows!
Steps to Reproduce

Have large number of members
Attempt to edit a post

Ghost Version
5.60.0
Node.js Version
16.18.0
How did you install Ghost?
Ubutnu, AWS, RDS Aurora DB
Database type
MySQL 8
Browser & OS version
All
Relevant log / error output
# Query_time: 21.560752  Lock_time: 0.000270 Rows_sent: 7  Rows_examined: 2778958
use prodghost;
SET timestamp=1694200263;
select `newsletters`.*, (select count(`members_newsletters`.`id`) from `members_newsletters` inner join `members` on `members`.`id` = `members_newsletters`.`member_id` where members_newsletters.newsletter_id = newsletters.id and `members`.`email_disabled` = false) as `count__active_members` from `newsletters` order by sort_order ASC, created_at ASC, id ASC;

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

We're currently caching the endpoint (/ghost/api/admin/newsletters/, all query strings) for 15 minutes to alleviate some of the delays while this performance issue is worked out.

@samrap If you have MySQL 8.0.18 or newer, could you run this query and paste the result? It will help to understand how MySQL executing the query on such a table and using indexes.. or not. This is your query with "EXPLAIN ANALYZE " prefixed.
EXPLAIN ANALYZE select `newsletters`.*, (select count(`members_newsletters`.`id`) from `members_newsletters` inner join `members` on `members`.`id` = `members_newsletters`.`member_id` where members_newsletters.newsletter_id = newsletters.id and `members`.`email_disabled` = false) as `count__active_members` from `newsletters` order by sort_order ASC, created_at ASC, id ASC;

@markstos does this help?
-> Sort: newsletters.sort_order, newsletters.created_at, newsletters.id  (cost=0.95 rows=7) (actual time=0.095..0.124 rows=7 loops=1)
    -> Table scan on newsletters  (cost=0.95 rows=7) (actual time=0.047..0.064 rows=7 loops=1)
-> Select #2 (subquery in projection; dependent)
    -> Aggregate: count(members_newsletters.id)  (actual time=3144.770..3144.771 rows=1 loops=7)
        -> Nested loop inner join  (cost=24859.04 rows=4104) (actual time=502.030..3141.465 rows=42312 loops=7)
            -> Filter: (members.email_disabled = false)  (cost=10494.05 rows=9876) (actual time=0.019..75.984 rows=98226 loops=7)
                -> Table scan on members  (cost=10494.05 rows=98763) (actual time=0.018..64.572 rows=101275 loops=7)
            -> Filter: (members_newsletters.newsletter_id = newsletters.id)  (cost=1.04 rows=0) (actual time=0.030..0.031 rows=0 loops=687582)
                -> Index lookup on members_newsletters using members_newsletters_member_id_foreign (member_id=members.id)  (cost=1.04 rows=4) (actual time=0.029..0.030 rows=3 loops=687582)

Perfect @samrap.
It shows what I suspected than an expensive full table scan is being used, in this case on members.email_disabled.
If you are comfortable with doing so, you could try adding an index on that column and re-testing the SQL query, with and without EXPLAIN ANALYZE. If Ghost later adds an index there, you should remove the index before upgrading so it doesn't interfere with upgrade automation.

This is much better (~4.5s). Thanks for the help! @markstos

@samrap To confirm: Adding the index on members(email_disabled) solved the performance problem?
That's great. I may see about making a PR to add that index for everyone.

It's a noticeable improvement. Here's my summary/thoughts:

Adding an index reduced the execution time from ~22s to ~5s
While this is a drastic improvement, it is still quite slow considering there are several XHR requests to the backend and this is just one of them
All things considered, it's ~8s after initial render to have a fully functional post editor
We'll continue to cache the HTTP response in addition to maintaining the index

Based on this I recommend adding that index as it is definitely an improvement 👍
I wonder if you can look directly into the performance of your largest cloud users to get more insights? I'm genuinely curious since this issue only causes problems around 100k members.

@samrap There might be more opportunities for indexes that are harder to see without the big scale that you have.
MySQL has an option to start the server with a "slow query" log enabled (https://dev.mysql.com/doc/refman/8.0/en/slow-query-log.html),  and the Ghost logs already log some slow queries.
If you see more indication of slow DB queries that might benefit, let us know.
When EXPLAIN ANALYZE shows a table scan for more than 10,000 rows, that's a strong indicator than index would help.

I'll keep you posted. We enabled slow query logs last week and so far it was only showing this one. But we'll be monitoring and I'll definitely update you if we see any others.
I don't expect this to be a huge priority for you guys and really appreciate the attention/help.

@kevinansfield Is a DB migration the best way to add a new index ( like this one) the best way to add a new index or is there a better way?

SELECT n.id, COUNT(mn.id) AS count_active_members FROM newsletters n LEFT JOIN (     SELECT DISTINCT mn.newsletter_id, mn.member_id     FROM members_newsletters mn     JOIN members m ON mn.member_id = m.id     WHERE m.email_disabled = false ) AS active_members ON n.id = active_members.newsletter_id GROUP BY n.id ORDER BY n.sort_order ASC, n.created_at ASC, n.id ASC;
In this query:
We use a subquery to select distinct pairs of newsletter_id and member_id from the members_newsletters table for members who have email_disabled set to false. This subquery filters the active members efficiently.
We then left join the newsletters table with this subquery on the newsletter_id to match newsletters with their active members. Using a LEFT JOIN ensures that newsletters without active members will still be included in the result.
We use the COUNT() function to count the number of active members for each newsletter.
Finally, we group the results by newsletter_id (renamed as id in the output) and order the result set as requested.
This query should perform more efficiently than the original one, especially when dealing with a large number of members, as it reduces the need for complex subqueries and calculations during the join operation.

@samrap Could you run both the old and new queries and see how the results and and execution time compare for you?

SELECT
  `newsletters`.*,
  (
    select
      count(`members_newsletters`.`id`)
    from
      `members_newsletters`
      inner join `members` on `members`.`id` = `members_newsletters`.`member_id`
    where
      members_newsletters.newsletter_id = newsletters.id
      and `members`.`email_disabled` = false
  ) as `count__active_members`
from
  `newsletters`
order by
  sort_order ASC,
  created_at ASC,
  id ASC;

--------------------------------------

SELECT
  n.id,
  COUNT(mn.id) AS count_active_members
FROM
  newsletters n
  LEFT JOIN (
    SELECT
      DISTINCT mn.newsletter_id,
      mn.member_id
    FROM
      members_newsletters mn
      JOIN members m ON mn.member_id = m.id
    WHERE
      m.email_disabled = false
  ) AS active_members ON n.id = active_members.newsletter_id
GROUP BY
  n.id
ORDER BY
  n.sort_order ASC,
  n.created_at ASC,
  n.id ASC;

@markstos Apologies for the late reply
That query gives an error Unknown column 'mn.id' in 'field list', so I tried the following instead:
SELECT
  n.id,
  COUNT(active_members.member_id) AS count_active_members
FROM
  newsletters n
  LEFT JOIN (
    SELECT
      DISTINCT mn.newsletter_id,
      mn.member_id
    FROM
      members_newsletters mn
      JOIN members m ON mn.member_id = m.id
    WHERE
      m.email_disabled = false
  ) AS active_members ON n.id = active_members.newsletter_id
GROUP BY
  n.id
ORDER BY
  n.sort_order ASC,
  n.created_at ASC,
  n.id ASC;

About the same time.


Update README.md

Description
Made Fill-in bolder in readme of this repo.
This PR fixes #523
Signed-off :    Rohan Anand<EMAIL_ADDRESS>Signed commits

[x] Yes, I signed my commits.

@sandramsc review it.

@sandramsc review it.
CC: @Mohith234 @Chadha93 @Modern-artist
Hi, maintainers are the ones who generally review, merge PR's here, not necessarily the person who creates the issue.

Thanks for the clarification.
As this issue was really minute, had nothing to discuss over it much, so I raised the PR. Now I've seen the guidelines thoruoghly of this repo, so next time I'll get issue assigned first then PR.

Ready for your next issue, @rohan472000?

Ready for your next issue, @rohan472000?

Yeah sure :)


Sharp fails to register module

Something that happens only when I try to use this theme which I totally in love with, is that I have this error: Sharp fails to register module

Error:
Something went wrong installing the "sharp" module

Module did not self-register.

- Remove the "node_modules/sharp" directory then run
  "npm install --ignore-scripts=false --verbose" and look for errors```

I know that it might not be related at all to the theme, but am curious what do you think about this since it only happens when I try to load liebling
I am using Nodejs 10.x and Ghost v3.x
😘

Weird nodejs stuff, fixed it by updating nodejs to 10.x


binding to a property getter uses dirty-checking

In the skeleton-navigation example app some text is bound to an es5 property

    Full Name

${fullName | upper}

export class Welcome{
  constructor(){
    this.heading = 'Welcome to the Aurelia Navigation App!';
    this.firstName = 'John';
    this.lastName = 'Doe';
  }

  get fullName(){
    return `${this.firstName} ${this.lastName}`;
  }
  ...
}

When I run the app (in chrome) I can see that the fullName getter is called roughly every 120ms, despite nothing changing. So it appears to be 'falling back' to dirty-checking. Is this the expected behaviour, and is there another way to write this code so that the binding uses one of the more efficient binding mechanisms?

Yes, this is expected. There is no way to observe a getter either with Object.observe or with auto-generated properties. So, it must fall back to dirty checking.
However, we have a number of improvements that are planned.

The binding system is pluggable and we have designed a mechanism for plugging in the notion of "dependencies". So, you could tell the binding system that fullName depends on firstName and lastName and then it won't use dirty checking, it will just update it whenever one of the dependencies changes.

Right now we poll all dirty checked properties every 120ms. This is so that we don't have to force a people to call something like digest. There are a few ways we think we can improve upon this. For example, since the bulk of the system is observable (in theory) we could just run the dirty checks after any normal observable changes. This only works if we're observing the dependencies though. But, it might be that we could combine this with some other technique and get rid of the polling altogether.

We could also monkey-patch the entire DOM and run dirty checking after every event or async operation. This is pretty hacky though and involves mangled a lot of parts of the DOM, so I don't want to do this if we can avoid it.

We plan to start with the first two improvements and then see how that works out practically before investing any time in the third option. We are holding off on some of this until after we make a few fundamental changes in our binding system.

@frankwallis when the next release of aurelia/binding goes out (v 0.3.5) you'll be able to use this aurelia plugin to do what's described in @EisenbergEffect 's first bullet point.
This may get incorporated into the aurelia framework.  Keep an eye on this issue for more details:
https://github.com/aurelia/binding/issues/15

that looks interesting, thanks for your responses.


[Feature Request] Invalid JSON error message should include line number

Insomnia 6.0.1
Details
I noticed that the work space editor has a JSON validator that spits out an error message like Unexpected token } in JSON at position 199. Overall this isn't that useful. It would be better if the line number could be mentioned along with the column (if possible).

What do you mean when you say workspace editor? Can you provide a screenshot?

Sorry - I meant environment editor :)

Good point. I wonder how hard that is to do.
FYI the error also shows inline in the environment JSON

Ah cool, didn't notice that 👍


Enhance error handling

@apollocarlos I Added traceable Error classes because JRuby errors cannot be traced on your implementation.

LGTM!

Could you give me the admin privilege on this repository?

Could you release a new version?

@civitaspo
done!

@apollocarlos Exactly released https://rubygems.org/gems/embulk-input-googlespreadsheet/versions/0.2.2 . But here is no release and no release commit. How did you do the release? Because users are confused as it is, I want you to create the tag and the release commit.

@apollocarlos I invited you to medjed organization. Can you transfer this repository to medjed organization?
You can do it from Settings > Transfer Ownership

@sonots @civitaspo
I have transferred ownership of this repo to medjed organization.
Also, there still exists something that needs to be fixed such as the .gemspec file.
Just do with it as you wish!

thanks!!


Update py2neo dependency

Switch from using PyPi prerelease version to the latest version of py2neo from conda-forge. The conda-forge version requires to add a dependency for monotonic. Closes #296.

@marimeireles I'm not sure how to fix the pre-commit-ci error.

nice catch @pwrose!
I didn't notice we were using the pypi version
idk about this pre-commit thing but I'll look into it now
thank you for the pr! 🌸


Update Nightwatch

Addresses CVEs related to netmask:

CVE-2021-29418
CVE-2021-28918

Addresses:

https://github.com/open-cluster-management/backlog/issues/11150
https://github.com/open-cluster-management/backlog/issues/11152

(Merging directly into release-2.2 because Nightwatch was removed from 2.3)

/hold


How can we show the list of items on single press not long pressed?

This widget is working  perfectly on long press. But what if we want the same functionality on single pressed button. After pressing it single time list shows and we can scroll and choose respective items and show it back again.
Can we do that?

Were you able to solve the problem with the longpress? If you did, can you share the solution please.

We thought that an open popup on single tap conflicts with the main idea of this package.
There is a DirectSelectList onUserTappedListener to show a hint for a user.


[merge] Nested gaps in 3-way merge can result in unneeded gaps.

See https://jsfiddle.net/c3rjpdxg/1/
I've tracked it down to seeing that chunk.editTo > rLine is true at the following line when the nested gap is encountered:
https://github.com/codemirror/CodeMirror/blob/master/addon/merge/merge.js#L382
It should account for the possibility of the gap having been nested.

What I'm seeing is (with the gaps styled as yellow):

The gap that you appear to have labeled 'MISALIGNED GAP' is necessary to make the 'Horse' line in the center and right editors line up. I.e. that part of the right document doesn't have gaps, so the gaps in the middle and left one are needed to make things align.
Or am I not understanding the issue correctly?

Sorry, I didn't clarify that the left pane has the bad gap in the jsfiddle. The problem is seen user-visible via the gap above "BAD GAP ABOVE" in the left pane. The MISALIGNED GAP in the center highlights the origin of the bad gap, which is why I pointed out the code block I mentioned as being the source of the error.

Here's a simplified version: https://jsfiddle.net/c3rjpdxg/2/

Where I've marked the two lines in between no gap is expected. The origin of the gap is the line below "Frog" in the center; it doesn't account for that there is no alignment needed since there's already a gap next to the gap, and instead offsets from the bottom of the left gap, which is why it's 6 lines below.

Right, I see what you mean now. Attached patch seems to solve the issue for me. Could you verify that it works for you?

sorry, I forgot to update this bug; yes, that fixes it.


Export FontSlant and FontWeight

Can you squash your commits please?

Done.  (I was somehow hoping github supports at least some rebase operations, but apparently, that's not the case...)

:+1:

Thanks!


RPC call "pending" returning active blocks

During investigation of Issue #1107 it was discovered that the RPC call "pending" may return active blocks.  As part of pull request #1028 active blocks were removed from "*_pending" RPC calls but may not have been removed from "pending".
Investigate if "pending" does or does not filter out active blocks, then update it to filter out active blocks unless the "include_active" object is specified with a value of true, just like "accounts_pending" and "wallet_pending"

If you're looking for a clear example on the live network, I have a few blocks that I sent myself listed as pending even though they're clearly processed: https://www.nanode.co/account/xrb_1ex3t617hfc4g17g4ttoosnwhszydiuibrr1o7d99eed4rrutmkdpcpdjkmo


Fix propTypes for tdStyle and thStyle

These were set to Proptypes.Object which results in the propType being  'undefined' .

@nickryall, thanks for fixing this stupid mistake... thank.


Missing Documentation: Types

I spent the past 6 weeks trying out over a dozen different ORMs in the typescript world. They all have their pros and cons, but Drizzle seems to be one of the best when it comes to type safety. However, those strong types are wasted because there's basically no documentation on how to use them in a more powerful way.
You should declare what types you need for passing around different parts of Drizzle:

queries - if you want to pass a query to a function, what type is that?
drizzle - I think it might be this: import type { MySql2Database } from 'drizzle-orm/mysql2', but I'm only guessing
tables/models - no idea

You should also be able to declare what types you need for the major part of query building, so that queries can be built programatically. For example

where() - I think maybe import type { SQL } from 'drizzle-orm/sql'
orderBy() - SQL is part of it, but there's certainly more
groupBy()
limit() - probably just number
offset() - probably just number

Yep, we plan to add the "Advanced" section to the docs where we'd explain all the user-facing types and how to use them. Thanks!

I just came here because this tripped me up. I'm still pretty new to TypeScript and didn't know how to use the InerModel type when the data I'm sending to a wrapper function to add a row leaves out fields with defaults or that are autogenerated.
Say I have...
export const videos = sqliteTable(
  'videos',
  {
    id: integer('id').primaryKey({ autoIncrement: true }),
    videoId: text('videoId').notNull(),
    title: text('title').notNull(),
    createdAt: integer('createdAt', { mode: 'timestamp' }).defaultNow().notNull(),
  },
  (videos) => ({
    nameIdx: uniqueIndex('videoIdx').on(videos.videoId),
  })
);

export type Video = InferModel<typeof videos>;

...and the following wrapper:
export const addVideo = (data: Video) => db.insert(videos).values(data).run();

Then I couldn't figure out how to call the wrapper without as Video because otherwise it complains about the missing id and createdAt fields:
    addVideo({
      videoId: uuidv4(),
      title: lorem.generateWords(randomNumber(20, 6)),
    } as Video);

@jschuur try to use export type Video = InferModel<typeof videos, 'insert'>;
It will generated needed types for insert. By default InferModel generates types for select

how to you infermodel with relations ?

Since there is no advanced documentation yet, does anybody have a hint regarding the types of the mentioned functions in the meantime:

where()
orderBy()
groupBy()

This would be great!

how to you infermodel with relations ?

On the enhancement backlog - see #695.

Since there is no advanced documentation yet, does anybody have a hint regarding the types of the parameters of the mentioned functions in the meantime?

where()
orderBy()
groupBy()

This would be great!

Here is what I used for orderBy
const model = mysqlTable(...)
type ModelColumns = keyof InferSelectModel<typeof modal>

function get(orderBy: ModelColumns, orderDir: "asc" | "desc") {
    db.query.model.findMany({
        orderBy: (model, {asc, desc}) => orderDir === "asc" ? asc(model[orderBy]) : desc(model[orderBy])
    })
}


[WIP] refactor(navbar): migrate bootstraps nabar to ant-d menus

SUMMARY
This pr will migrate the old react-bootstraps navbar into ant-d menus. This pr will also update smaller screen navbar views to more user friendly views.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Will update test and manually check that each submenu looks similar to existing specs.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up

A few little visual details remaining:

The padding to the right of the caret got smaller, and does not match the padding on the left of the text
There's still like 1px of space between the menu trigger, and the dropdown itself, which is easy to see with the little blue line.
The corners of the dropdown list are rounded. I don't mind it on the bottom corners, but the top corners again show the blue a little bit more than I think they should, so maybe we should un-round just those top ones.
The list items in the dropdown use do have a faint blue background and gray text... now they stay white, but the text color changes to blue. I don't mind it, but I want @steejay and/or @mihir174 to take a look, so I'll tag this PR with a need for design input.

... there also seem to be an issues with linting that're holding up CI.

/testenv up

The list items in the dropdown use do have a faint blue background and gray text... now they stay white, but the text color changes to blue. I don't mind it, but I want @Steejay and/or @mihir174 to take a look, so I'll tag this PR with a need for design input.

im okay with the change here. @rusackas

wondering if we can have the selected underline and the hover underline at the same weight so when they are side by side there isnt a jog

Inconsistent caret style and position
are those intentional?

looks like a bug. caret style and position shouldnt be switching locations

/testenv up

thank you for the PR. im seeing below

Nav bar jumpiness
Inconsistent caret style and position
are those intentional?

Screen.Recording.2021-04-23.at.11.28.21.AM.mov

This is weird. I'm not seeing that sqllab ui bug on my local.

SQL editor also has a funny gray gap between the left menu items and the right menu items... I think it's not using the same Menu component or something.

Also the "underline" in menu items looks bad and is inconsitant

These inconsistencies between sections of Superset are due to there being two React apps in a single page (one for the Menu and one for the rest of the page/content). There were multiple instantiations of Emotion packages in these situations, and this can be remedied via Emotion's CacheProvider package which will allow us to appropriately namespace these generated classes. Also, we want to make sure we're properly exporting all Emotion bits from Superset-UI so that they're imported in Superset consistently. This will lead to a little series of PRs:

Adding/updating exports in Superset UI. PR here.
Pulling in that package in Superset, and utilizing CacheProvider
Rebasing/merging this PR.
Making sure ALL Emotion scripts are imported via Superset-UI, removing Emotion packages from Superset, and adding an ESLint rule to forbid the use of the Emotion packages directly.
Continuing work to get rid of the multi-React-app issue (i.e. making Superset a Single Page App and deprecating legacy FAB views)

Related PR in progress: https://github.com/apache/superset/pull/14388

/testenv up

/testenv up

/testenv up

/testenv up

Fixes #13492


How to use RET to complete directory name in find-file?

In find-file, when typing RET on a directory, it's opened in dired. I personally never use dired, and I expect it to work as TAB in this situation.
I didn't find a way to do this in a single selectrum completing session. Here's what I'm using now:
(defun my-find-file (&optional default-dir)
  "An alternative for `find-file'.
This completes the directory when pressing `RET', rather than
open it in dired.

DEFAULT-DIR is used to specify the starting directory."
  (interactive)
  (let* ((file (read-file-name "Find file: " default-dir nil
                               (confirm-nonexistent-file-or-buffer))))
    (if (directory-name-p file)
        (my-find-file file)
      (pop-to-buffer-same-window (find-file-noselect file)))))

But there are 2 problems:

Minibuffer flickers (i.e. closes and reopens) when typing RET on a directory.
The directory goes into minibuffer history, and I don't want this.

Do you have any idea for a better implementation?

See #216, this seems to be a common demand, so it's worth thinking about providing a better interface for these things.

The solution you gave in #216 works, but breaks read-directory-name. I'll try to make this work only for find-file.

Thanks! Here is an alternate version skipping this behaviour in this case:
(add-hook 'minibuffer-setup-hook
          (defun selectrum-setup+ ()
            (when (and selectrum-active-p
                       minibuffer-completing-file-name)
              (let ((map (copy-keymap (current-local-map))))
                (define-key map (kbd "RET") 'selectrum-select-current-candidate+)
                (use-local-map map)))))

(defun selectrum-select-current-candidate+ (&optional arg)
  (interactive "P")
  (let* ((index (selectrum--index-for-arg arg))
         (candidate (selectrum--get-candidate index))
         (path (selectrum--get-full candidate)))
    (call-interactively
     (if (and (file-directory-p path)
              (not (eq minibuffer-completion-predicate
                       'file-directory-p)))
         'selectrum-insert-current-candidate
       'selectrum-select-current-candidate))))

How about this:
(defun selectrum-select-current-candidate+ (&optional arg)
  (interactive "P")
  (let* ((index (selectrum--index-for-arg arg))
         (candidate (selectrum--get-candidate index))
         (path (selectrum--get-full candidate)))
    (call-interactively
     (if (file-directory-p path)
         'selectrum-insert-current-candidate
       'selectrum-select-current-candidate))))

(defmacro selectrum-complete-dir-by-ret (&rest body)
  `(minibuffer-with-setup-hook
       (defun selectrum-setup+ ()
         (when (and selectrum-active-p
                    minibuffer-completing-file-name)
           (let ((map (copy-keymap (current-local-map))))
             (define-key map (kbd "RET") 'selectrum-select-current-candidate+)
             (use-local-map map))))
     ,@body))

(defun toki-find-file ()
  "An alternative for `find-file'.
This completes the directory when pressing `RET', rather than
open it in dired."
  (interactive)
  (selectrum-complete-dir-by-ret
   (call-interactively #'find-file)))

The user could wrap (or advise) commands by selectrum-complete-dir-by-ret on their own needs.

providing a better interface for these things and then mentioning it in the README/wiki

Yeah, I think this would be a great improvement! Ideally, the user doesn't need to do things with minibuffer-with-setup-hook; I don't think very many people are familiar with it other than in the Selectrum issue tracker ;)

The user could wrap (or advise) commands by selectrum-complete-dir-by-ret on their own needs.

This use case may be common enough to make it worth adding a selectrum-minibuffer-file-map similar to minibuffer-local-filename-completion-map. This would make easy enough for anyone to customize bindings for file completions. We could include some common commands like the one discussed here which we bind to unused keys and users can rebind those to other keys in case they want.

The macro is also a good idea, maybe we could generalize it to something like selectrum-with-keymap so one can easily instantiate a keymap for a single session.

In that case I think the macro should be a generic wrapper around completing-read which also works when not using selectrum.

This use case may be common enough to make it worth adding a selectrum-minibuffer-file-map similar to minibuffer-local-filename-completion-map.

A good thing about the above code is the keymap is generated on the fly, so any customization on selectrum-minibuffer-map is keeped. If we offer multiple maps, the user is likely to have to customize all of them.
Or maybe we can offer selectrum-with-keymap, which merges the keymap provided with selectrum-minibuffer-map, so only the differences are needed to be defined in selectrum-minibuffer-file-map.

Yeah, I thought we can set selectrum-minibuffer-map as the parent of selectrum-minibuffer-file-map and the macro would be used to force some bindings for a specific session.

I think it would be better to offer alternative commands similar to icomplete-fido-ret, icomplete-fido-delete-char and icomplete-fido-backward-updir. They check the current context, if it's a file name completion, do their special thing, and otherwise do the "normal" thing.
The users will be able to put them on the keymap manually, or maybe enable some special selectrum-ido-emulation-mode.

I think it would be better to offer alternative commands similar to icomplete-fido-ret, icomplete-fido-delete-char and icomplete-fido-backward-updir. They check the current context, if it's a file name completion, do their special thing, and otherwise do the "normal" thing.
The users will be able to put them on the keymap manually, or maybe enable some special selectrum-ido-emulation-mode.

Thanks, that would be convenient for users coming from ido/fido. We try to avoid including such workflow customizations usually, I think I would prefer when this selectrum-ido-emulation mode would live in its own package.

Thanks, that would be convenient for users coming from ido/fido. We try to avoid including such workflow customizations usually, I think I would prefer when this selectrum-ido-emulation mode would live in its own package.

I'll wait for someone to create it.

I'll wait for someone to create it.

I have included a reference to that in the issue name so users which have interest in such a package can find that there is demand for it.

I have included a reference to that in the issue name so users which have interest in such a package can find that there is demand for it.

@dgutov
I don't use ido/fido myself but the following should work for you as long there doesn't exists a more featured ido-emulation-mode:
(defun selectrum-fido-backward-updir ()
  "Delete char before or go up directory, like `ido-mode'."
  (interactive)
  (if (and (eq (char-before) ?/)
           (eq (selectrum--get-meta 'category) 'file))
      (save-excursion
        (goto-char (1- (point)))
        (when (search-backward "/" (point-min) t)
          (delete-region (1+ (point)) (point-max))))
    (call-interactively 'backward-delete-char)))

(defun selectrum-fido-delete-char ()
  "Delete char or maybe call `dired', like `ido-mode'."
  (interactive)
  (let ((end (point-max)))
    (if (or (< (point) end) (not (eq (selectrum--get-meta 'category) 'file)))
        (call-interactively 'delete-char)
      (dired (file-name-directory (minibuffer-contents)))
      (exit-minibuffer))))

(defun selectrum-fido-ret ()
  "Exit minibuffer or enter directory, like `ido-mode'."
  (interactive)
  (let* ((dir (and (eq (selectrum--get-meta 'category) 'file)
                   (file-name-directory (minibuffer-contents))))
         (current (selectrum-get-current-candidate))
         (probe (and dir current
                     (expand-file-name (directory-file-name current) dir))))
    (cond ((and probe (file-directory-p probe) (not (string= current "./")))
           (selectrum-insert-current-candidate))
          (t
           (selectrum-select-current-candidate)))))

(define-key selectrum-minibuffer-map (kbd "RET") 'selectrum-icomplete-fido-ret)
(define-key selectrum-minibuffer-map (kbd "DEL") 'selectrum-fido-backward-updir)
(define-key selectrum-minibuffer-map (kbd "C-d") 'selectrum-fido-delete-char)

@dgutov
I don't use ido/fido myself but the following should work for you as long there doesn't exists a more featured ido-emulation-mode:
(defun selectrum-fido-backward-updir ()
  "Delete char before or go up directory, like `ido-mode'."
  (interactive)
  (if (and (eq (char-before) ?/)
           (eq (selectrum--get-meta 'category) 'file))
      (save-excursion
        (goto-char (1- (point)))
        (when (search-backward "/" (point-min) t)
          (delete-region (1+ (point)) (point-max))))
    (call-interactively 'backward-delete-char)))

(defun selectrum-fido-delete-char ()
  "Delete char or maybe call `dired', like `ido-mode'."
  (interactive)
  (let ((end (point-max)))
    (if (or (< (point) end) (not (eq (selectrum--get-meta 'category) 'file)))
        (call-interactively 'delete-char)
      (dired (file-name-directory (minibuffer-contents)))
      (exit-minibuffer))))

(defun selectrum-fido-ret ()
  "Exit minibuffer or enter directory, like `ido-mode'."
  (interactive)
  (let* ((dir (and (eq (selectrum--get-meta 'category) 'file)
                   (file-name-directory (minibuffer-contents))))
         (current (selectrum-get-current-candidate))
         (probe (and dir current
                     (expand-file-name (directory-file-name current) dir))))
    (cond ((and probe (file-directory-p probe) (not (string= current "./")))
           (selectrum-insert-current-candidate))
          (t
           (selectrum-select-current-candidate)))))

(define-key selectrum-minibuffer-map (kbd "RET") 'selectrum-icomplete-fido-ret)
(define-key selectrum-minibuffer-map (kbd "DEL") 'selectrum-fido-backward-updir)
(define-key selectrum-minibuffer-map (kbd "C-d") 'selectrum-fido-delete-char)

Thanks, these seem to work. There is a typo in the bindings, though: selectrum-icomplete-fido-ret should be selectrum-fido-ret.
And selectrum--get-meta is a private function. So it doesn't seem like a third party package should call it.

Thanks, these seem to work. There is a typo in the bindings, though: selectrum-icomplete-fido-ret should be selectrum-fido-ret.
And selectrum--get-meta is a private function. So it doesn't seem like a third party package should call it.

Thanks, if a third party packages will get created it can also use the following instead:
(completion-metadata-get
 (completion-metadata (minibuffer-contents)
                      minibuffer-completion-table
                      minibuffer-completion-predicate)
 'category)

Thanks, if a third party packages will get created it can also use the following instead:
(completion-metadata-get
 (completion-metadata (minibuffer-contents)
                      minibuffer-completion-table
                      minibuffer-completion-predicate)
 'category)

Closing this since no action will be taken and the answer how to get this behavior was added to the wiki

I hope this helps

Does help, however when using M-x cd i can't pick a directory!

I hope this helps

Does help, however when using M-x cd i can't pick a directory!

Have you tried using selectrum-submit-exact-input(bound to C-j)? It is listed in the "Keybindings" section of the README.

Have you tried using selectrum-submit-exact-input (bound to)

I tried, it works, thanks.


Single orbit animation's inclination is not correct

Despite the inclination being properly provided to KeplerEllipse, the animation shows the orbit as extremely inclined as soon as the value goes above 0. This is a pretty big issue for the 3d views.

When calculating the xyz position list for a KeplerOrbit object, the 3d view always shows a 45 degree inclination whenever i > 0. This suggests it's an issue with matplotlib.

This was indeed a matplotlib issue, made the switch to pyplot and it worked like a charm


Draft: fix(groupBy) do not return wrapped in Partial<>

A previous MR https://github.com/ramda/types/pull/45 added to the return of groupBy that it should be wrapped in Partial<>. This makes a lot of sense in the fact that the function could return keys that don't actually exist on the object it creates.
Using the example from Ramda docs
const byGrade = groupBy((student: { score: number; name: string }) => {
  const score = student.score;
  return score < 65 ? 'F' : score < 70 ? 'D' : score < 80 ? 'C' : score < 90 ? 'B' : 'A';
});
const students = [
  { name: 'Abby', score: 84 },
  { name: 'Eddy', score: 58 },
  { name: 'Jack', score: 69 }
];

The type that byGrade(students) returned previously was Record<'A' | 'B' | 'C' | 'D' | 'F', Student[]>, which was accurate, but also misleading, because there was no guarantee at runtime that each of the union values existed as a key. This is why the Partial<> as added.
6 months later
HIndsight is 20/20 and we've come to learn that wrapping in Partial<> breaks other functionality in terms of mapping to other things. toPairs is a prime example.
const entries = toPairs(groupBy(students));

The return type previously was [<'A' | 'B' | 'C' | 'D' | 'F', Student[] | undefined][]. The | undefined is a problem. Because that it more inaccurate for runtime behavior that index accessing on Record<string, Student[]>
Typescript also allows for what we were trying to solve here via the tsconfig option https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess. Which if set gives a project a correct Students[] | undefined from index accessing Record<string, Students[]>. Which IMHO should be the default behavior for Record<>
This MR removes the Partial<> wrap in the return to account for this undesired behavior.

Closing per https://github.com/ramda/types/issues/91#issuecomment-1928793067


refactor: use PascalCase for components name

Codecov Report

Merging #4403 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4403   +/-   ##
=======================================
  Coverage   91.29%   91.29%
=======================================
  Files          56       56
  Lines        1919     1919
  Branches      482      482
=======================================
  Hits         1752     1752
  Misses        155      155
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b7c43...19af1ca. Read the comment docs.

My bad :see_no_evil:


build: added func to auto-create post branch/PR

:tada: This PR is included in version 1.27.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Bofrost.de has degraded performance

In 5854ea8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2262 ms

Resolved: Bofrost.de performance has improved in d01c47c after 6 minutes.


Fixed react 15.2 warning about Unknown props on DOM

Additionally:

Fixed propTypes: added missing forceOriginalDimensions.
Fixed examples: checkIf2xExists is checkIfRetinaImgExists; name
handleClick according to its purpose, cyclePics; show actual code;
fixed React warning "Rendering components directly into document.body
is discouraged".

Fixes https://github.com/KyleAMathews/react-retina-image/issues/61

Looks great! Thanks so much @sompylasar!

Released 2.0.2

Thanks!


fix: WithKeyUsage support multi key usages

Codecov Report

Merging #6 (5f09a2c) into main (d96edbf) will increase coverage by 4.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   47.22%   51.89%   +4.67%
==========================================
  Files           3        3
  Lines         144      158      +14
==========================================
+ Hits           68       82      +14
  Misses         74       74
  Partials        2        2

Flag
Coverage Δ

unittests
51.89% <100.00%> (+4.67%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

option.go
65.51% <100.00%> (+10.97%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


The better card component.

I wanna contribute to this by bettering the card component UI.

@Utsav631 Sure.
Do star 🌟 the repo.

I have to work on that will you please assign it to me.

@Pariyul it is already assigned.

Fixed.


[Suggestion] webpack md5 hash alternative

please refer to this issue https://github.com/erm0l0v/webpack-md5-hash/issues/7
it's not a reliable way for long term caching.
may want to consider other alternatives.
maybe this one
https://webpack.js.org/guides/caching/#deterministic-hashes

Using HashedModuleIdsPlugin doesn't fix the Cannot read property 'call' of undefined bug for me. There seems to be a solution in https://github.com/webpack/webpack/issues/4445.

@wppd This is done in 0e8e32d32d60f1f983a8a7bd1273c7962d45b095.


Can this push to iOS and android apps?

Can this push to iOS and android apps?

Yes it should be able to, I've not tested it personally though

The answer was here:
http://www.elabs.se/blog/66-using-websockets-in-native-ios-and-android-apps


Consider creating a Github Page for the project

We could consider creating a simple static website for the project using the 'Github Pages' feature.
This could serve as a "product presentation page" to promote the extension, and it would be aimed to end-users.
Its initial structure could be as simple as a single landing page explaining what the extension is about, the features it provides, and links to the Chrome Extension Page, Repository, etc.
This is in no way a priority, just a nice thing to have that wouldn't take that much effort!

Closing the issue as the page has already been created. Further discussion should occur on the page repo: https://github.com/animal-crossing-music-extension/animal-crossing-music-extension.github.io


commit changes on PeoplePicker added Styles Property

What's in this Pull Request?
Added Styles Property to the control to allow custom styles

@joaojmendes the build action failed. Could you please have a look?
Also, do you need the package-lock.json to update? Or was that just npm forcing an update?

Thanks @joaojmendes !


Error while fetching environemnts using /api/environments

Current Behavior

Expected Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@Yashsharma1911

Thanks for bringing up this issue I'll look

@Yashsharma1911 API is also not working for workspaces.
https://playground.meshery.io/api/workspaces

Please make sure you are providing orgId as param

Thank you for your input. However, for the 'mesheryctl workspace list' command, we list all workspaces associated with the user, regardless of the orgID parameter.

@Yashsharma1911 still getting error code 500 even by using ORG-ID.


Question about using a real backend

I am currently when using the --backend flag to exclude angular's $httpBackend. I have modified gulp tasks to drop off the build output to another location where my backend expects it. All this works great. However, I have been thinking about making the connect server that is spun up a proxy server. This way, you could have your api running wherever, and you can code your frontend against it. I wanted to see if you have any thoughts on this. Shouldn't be hard to wire it up, but do you think it belongs on fatarrow?

Hey any chance you will consider a pull request for this feature? Please feel free to let me know if you have any concerns around this.

Sorry. Still need to study this. I'll do it this weekend. :)

Will you be able to review/test a few pull requests I have?

yes, but it probably won’t be until the weekend
On Mon, Mar 9, 2015 at 4:31 PM, Nachiket Mehta<EMAIL_ADDRESS>wrote:

Will you be able to review/test a few pull requests I have?
Reply to this email directly or view it on GitHub:
https://github.com/CaryLandholt/fatarrow/issues/29#issuecomment-77947336

Ok great. Thanks.

No need to drop off files to IIS, Apache, etc. Just use the built in proxy to call a backend!


Add mintPolicy as not-applied mint policy hash to metadata

Include:

https://github.com/mlabs-haskell/plutus-use-cases/pull/362

Issue:

https://github.com/mlabs-haskell/seabug-contracts/issues/13

Both this branch and aleksandr/fix-efficient-nft-pab-for-seabug aren't running CI as the target branch - t4/testnet-script isn't in the workflows file.
I say we just push a quick commit to t4/testnet-script removing the explicit branch list on pull requests - every PR should run CI regardless of target.
After this, the merge back to these branches should trigger CI
(Do be sure to run make format and make lint on these PRs btw)


Avoid loading extensions from classpath

Avoid loading extensions over and over when parsing relational connections, and use the already loaded parser extensions.

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.


Avoid cmov instructions in constant time code

Fixes #9213

The description here is quite off. This is not a fix for #9213, and cmovs are not inherently a bad thing for constant-time code. On the contrary, they're quite desirable. Rather, the problem is:

RSA_padding_check_PKCS1_type_2 is doing questionable things w.r.t. uninitialized memory. It should not be doing that. This is #9213.
The compiler recognizes masks and sometimes emits cmovs. This is great. The problem is the compiler doesn't know it cannot further transform the cmovs into branches. That would not be great and, alas, sometimes does happen. This is the motivation for the BoringSSL change that this PR copies.

In neither of these is the cmov a problem. The cmov is merely an indication of the problem. In (1), it is related because valgrind apparently gets tripped up by the cmov. This PR does nothing useful for (1). It removes the indicator without fixing the problem.
This PR does help with (2). The relationship between (2) and cmov is that the compiler cannot possibly know to transform something to cmov while also knowing not to further transform it to a branch.  Their cost is we lose the cmovs, but such is life. In the long-term, the answer is to have language support to tell the compiler what's going on.

So what @davidben suggests is that the commit message should elaborate a bit more.  For a change like this, I agree.
Also, without having looked in depth, it seems to me like the Travis failures are quite relevant.

Okay, improved the commit message and fixed the travis failure.
BTW: I have experimented with measuring execution time of executed vs.
non-executed cmov, and I see a small bias (< 0.5%) of execution time.
This is what I derived from a test program which was initially posted by
Linus Torvalds https://yarchive.net/comp/linux/cmov.html:
#include <stdio.h>

/* How many iterations? */
#define ITERATIONS (100000)

/* Which bit of the counter to test? */
#define BIT 1

#define choose(i, a, b) ({			\
	unsigned long result, x,y;			\
	asm("testl %3,%4;  movl (%1), %k1; cmovne %1,%0; mov %2,%1"	\
		:"=r" (result), "=r"(x), "=r"(y)			\
		:"i" (BIT),			\
		 "r" (i),			\
		 "1" (&a),			\
		 "0" (b));			\
	result; })

int main(int argc, char **argv)
{
	int i, j, k;
	unsigned long sum;
        unsigned long lo0, hi0;
        unsigned long lo1, hi1;
        unsigned x;
        unsigned xx[2] = {-1, -1};

        for (j = 0; j < 1000; j++) {
        sum = 0;
	for (i = 0; i < ITERATIONS; i++) {
		static unsigned long a = 50; unsigned long b = 70;
                __asm__ __volatile__ ("rdtsc" : "=a"(lo0), "=d"(hi0));
                for(k=0; k<1000; k++) {
                __asm__ __volatile__ ("clflush (%0)" :: "r"(&a));
		  sum += choose(i, a, b);
                }
                __asm__ __volatile__ ("rdtsc" : "=a"(lo1), "=d"(hi1));
                x = (unsigned)(lo1-lo0);
                if (x < xx[i&1])
                   xx[i&1] = x;
	}
	printf("%u %lu %u %u\n", j, sum, xx[0], xx[1]);
        }
	return 0;
}

The output has 4 colums:
The first two colums are not relevant,
but column 3 prints the min. execution time of non-executed cmov
while column 4 prints the min. execution time of executed cmov.
On average non-executed cmov runtime is a tiny bit faster than executed cmov.
example (on Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz):
999<PHONE_NUMBER> 45593 45771
999<PHONE_NUMBER> 45590 45705
999<PHONE_NUMBER> 45590 45626
999<PHONE_NUMBER> 45581 45756

I assume, but didn't look at the generated code, that it would
generate 2 cmov instructions, with reversed conditions, and so one
of them does a move, and the other not. The total time of the 2
cmov's is the same.
But it might instead of turning it into a cmov, turn it into a real
branch. For instance if it sees this same constructions, based on
the same "select" variable 3 lines, it might decide to branch, and in
the first branch use 3 unconditional moves of the first value, and
in the other branch use 3 unconditional moves of the second value.

The Fixes line should probably be removed?

shrug.

updated commit message:
Avoid cmov instructions in constant time code

cmov instructions are compiled from constant_time_select
which are reportedly transformed into conditional
branches.  Which is of course not acceptable.

The valgrind errors are suppressed with the patch so I am not sure why not to put Fixes there although the error might be misleading.

ping @openssl/omc

I think it's better to describe this patch as avoiding the recognition of the select and turning it a conditional load or branch.

I think the code should have more comments then "avoids optimization".

Yes, I am open to suggestions.
The main reason is that the compiler knows that  x >> 31 can be either 0 or 1.
and mask = 1 - (x >> 31) can be 0 or -1, and when there are lots of x = x & mask
then it can replaced by a jump if mask is -1 and x = 0 if mask is 0.

I could say something like,
the barriers avoid the compiler from narrowing down possible value range
of the mask and ~mask in the select statements, which avoids the recognition of the select
and turning it a conditional load or branch.

theoretically also code like
x = constant_time_eq(a,b);
x &= constant_time_eq(c,d);...
could eventually need barriers.

So, how about that:
Add value_barriers in constant time select functions

The barriers avoid the compiler from narrowing down the
possible value range of the mask and ~mask in the select
statements, which avoids the recognition of the select
and turning it a conditional load or branch.

Merged to master as 04edd68, and 1.1.1 as 7fab431. Thanks!

Have you tried comparing the generated code before and after this
PR? It at least seems to generate other code for the padding
checks using gcc 8.3.
(I guess I should have asked before approving this.)

It depends a lot on the gcc version, with some versions there was no problem at all.
What I did observe, is the code is a lot smaller than before.

I wonder if I should back-port this to 1.1.0 and 1.0.2 since it is a potential security issue.

As far as I know, 1.1.0 is no longer supported, but I have no
problem with a backport for both.

Version 1.1.0 will be supported until 2019-09-11.


fix: Improve module resolution

This solves issues where some detections did not work properly due to
the way dependencies were resolved.
When using relative imports, the module resolution was working, but when
for example importing a control from a test, the complete namespace is
used, but the corresponding JS file was not found.
This change ensures that JS files are resolved and also that the types
for a framework library are loaded when it is linted.

I checked the difference and in SourceFileLinter.ts there is now less code covered in analyzeControlRendererDeclaration, as it takes a different path for the fixed case.
@d3xter666 do you know whether there is still a case that needs the handling in here?
https://github.com/SAP/ui5-linter/blob/e9a5812fec5bc3262174508ffce66d67a801bf9c/src/linter/ui5Types/SourceFileLinter.ts#L315-L331

I checked the difference and in SourceFileLinter.ts there is now less code covered in analyzeControlRendererDeclaration, as it takes a different path for the fixed case.
@d3xter666 do you know whether there is still a case that needs the handling in here?
https://github.com/SAP/ui5-linter/blob/e9a5812fec5bc3262174508ffce66d67a801bf9c/src/linter/ui5Types/SourceFileLinter.ts#L315-L331

It seems that this test/file test/fixtures/linter/projects/sap.f/src/sap/f/ProductSwitch.js
does not go through the moduleExportsSymbols... loop anymore. It's resolved here:
https://github.com/SAP/ui5-linter/blob/main/src/linter/ui5Types/SourceFileLinter.ts#L286
I believe this is caused by the new namespace resolve logic in here and also the conditional inclusion of the .d.ts files... I'm starting to question whether we need this custom module resolution logic anymore. But I suppose there might be cases where we intentionally might include the .d.ts files and then, we'll definitely need that

@d3xter666 thanks a lot 👍🏻 Then I'll go ahead with that. We can still revert it in case we encounter some relevant cases again.


framerate switching creates judder

Hello
Describe the bug
When activating the auto frame rate matching on Chromecast 4k with Google TV, strong judder happens when playing any mkv UHD Dolby Vision movies (which is the reason I use Just Player). Whereas this issue is only slighly present with the option off and refresh rate at 60Hz. Netflix doesn't have this problem, no judder at all after switching framerate, which leads me to believe it may have a better implementation.
EDIT 05/14/2024: as of now the best result is achieved when activating tunneled video playback in the advanced options.
To Reproduce
Steps to reproduce the behavior:

Set frame rate matching on "non smeamless" in the chromecast 4k options while having a general refresh rate of 60Hz.
Open any uhd dolby vision mkv movie with Just Player from NOVA Video Player interface.
Open advanced options long pressing the cog
Turn on Auto frame rate matching
Return to playing the movie, the frame rate of my "laser TV" (Hisense PL1) adjusts accordingly.
Judder is immediately there

Expected behavior
No judder at all as in Netflix app
Device:

Model: Chromecast 4k with Google TV plugged in Hisense PL1 laser TV
OS: Android TV 12
Chromecast 4k firmware : 1.68.374976, software up to date

Thank you for your time and effort

Yeah, the framerate matching switches display mode so it's slow and creates a judder. However it shouldn't be neede on newer devices / OS as ExoPlayer already supports all the fancy features:

ExoPlayer does support seamless frame rate switching by default.

When playing videos on my phone, display refresh rate matches the video framerate. So I don't really know what else to do.


[e2e]: delegator-lowperms release main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v43.0.348
Run: https://github.com/slsa-framework/example-package/actions/runs/9590568828
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.release.main.default.slsa3.yml
Trigger: release
Branch: v43.0.348
Date: Thu Jun 20 02:35:43 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v43.0.349
Run: https://github.com/slsa-framework/example-package/actions/runs/9607212014
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.release.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.release.main.default.slsa3.yml
Trigger: release
Branch: v43.0.349
Date: Fri Jun 21 02:46:27 UTC 2024
Tests are passing now. Closing this issue.


keybase on macOS - Command Q Does not Quit / Adhere to Apple's Human Interface Guidelines

According to Apple's Human Interface Guidelines, pressing "Command-Q" should "Quit the app" - these guidelines are defined here: https://developer.apple.com/design/human-interface-guidelines/macos/user-interaction/keyboard/.
Current Behavior:
"Command-Q" minimizes the application to the macOS Dock (note: I also do not know if macOS has user interface element called the "Tray" as described in the Keybase's "Keybase" menu item).
Expected Behavior:
It is expected that the Human Interface Guidelines be adhered to and "Command-Q" quits the particular application.
This behavior is not in accordance with the Human Interface Guidelines standards.
I have attached a screenshot of the functionality that does no adhere to these standards.

Agreed - there should just be a settings option to have command-Q quit instead. If you haven't figured it out, for now you can quit by clicking on the Keybase logo in your menubar up top and clicking quit

This is an easy thing to fix, I'm happy to make the PR for it if we can do this. I looked through the discussion and it seems there was some intent to make things the way it is on purpose?
It's a pretty suspicious experience to have a Mac app that doesn't quit with command-Q. Also suspicious when an app keeps inserting itself into the "start on launch" list without asking.

I am seeing this issue as well. Cmd+Q does not quit the app, and I do not have a “quit” option from the Keybase menu on the menu bar. I have to force quit the app to quit it.
The only other times I’ve seen this issue with software have been with spyware, malware, and viruses. I’m not implying Keybase is these, but it shouldn’t behave like them, either.

This is not how a native macOS app should behave. No option in the preferences to disable this forced behavior and also to remove it from "start on launch". This will get a hard uninstall from me until these issues are fixed.

Binding the "Minimize to Tray" to Command-Q is indeed very strange...!
It's not a perfect solution, but as a temporary fix, you can do this to revert Command-Q to mean Quit:
Go to System Preferences -> Keyboard -> Shortcuts -> App Shortcuts
Add a new shortcut using the "+" button.
Select Keybase.app in the list of apps, then in the "Menu Title" input type (exactly) "Quit Keybase Completely", then focus the "Keyboard Shortcut" input, and type Command-Q. Click the "Add" button to complete.
Then add another shortcut using the "+" button, select Keybase.app again, type "Minimize to Tray" in the "Menu Title" input, and use any other shortcut, for example, Command-Option-Q, the click the "Add" button.
This is what adding the first shortcut looks like:


WIP: Add fake DiscoveryInfo for development purposes

Don't merge. This is only for development purposes to have DiscoveryInfo in mesos-master's state.json.

Hi @sttts, out of curiousity: why did you create a PR for this and not simply a branch on your own repository?


bsb and refmt not running in a monorepo

plugin version: 0.85-2019.3
System: Windows
Description
Using a monorepo on Windows OS, bsprocess and refmt are resolved to "bsb" and "refmt" instead of "bsb.cmd" and "refmt.cmd"

The opening comment talks about Windows but I'm experiencing the same thing on OS X.

@Kingdutch which plugin version ? can the project be checkout ?

It's not in public code unfortunately. I can see if I can set up a small monorepo where I can reproduce this but not sure when I'll have time to do this.

can you install 0.89 ?


add node.deleted to indicate if a node is deleted

Backwards compat. Should make it possible to delete with a value which is useful for resolving conflicts

/cc @andrewosh

@andrewosh updated. wdyt?


Stats routing and fuzzy name matching

Three new routes. Not huge amount of contribution. Mostly a learning day as I refreshed myself on SQL. Messed with timestamp stuff. Read up a little bit on building sql strings in JS and then didn't do it.
/a/admin/stats/avg/:item_id

Returns the avg usage based on day. Usage as defined by checkouts only.

/a/admin/stats/:item_id

Returns the total net change per day based on the past week.

/dev/itemid/:name

name is a fuzzy string that will use the LIKE operator in SQL to attempt to find all names close to this.
Returns pairs of item_id and item_name that result from above query.

I think we really need a DB rule to enforce lowercase in name entries.

For the following routes:
-/a/admin/stats/avg/:item_id
-/a/admin/stats/:item_id
It is a little confusing by looking at these paths as to whether the stats/avgs are by day or week. Maybe it would be better to write the descriptions into the URL themselves, like:
-/a/admin/stats/avgperday/:item_id
Or at least make it clear to the person using it, the administrator, what this command does.


How do you unbox an [[String:Date]]?

I have the following JSON:
        {
            "58ed258d47919a00081c2d78": "2017-05-21T14:48:41.650Z"
        },
        {
            "58ed1ffd47919a004a1c2d51": "2017-05-21T14:52:38.775Z"
        },
        {
            "58e2e9da4daa7a347ddbfc2b": "2017-05-21T14:48:38.146Z"
        },
        {
            "58e2e9db4daa7a347ddc2032": "2017-05-21T14:53:32.642Z"
        },
        {
            "58e2e9da4daa7a347ddbfc1b": "2017-05-21T14:51:44.867Z"
        },
        {
            "58e2e9db4daa7a347ddc202d": "2017-05-21T14:53:43.968Z"
        }
    ],

Where the data is an array of hashes, where each hash is a [String:Date].
How should I setup unbox to decode this?  I setup a DateFormatter to decode the date correctly, but I haven't figured out which unboxer.unbox incantation to use.
Thanks.

@SuperTango Can you please post you full JSON, as well as your existing model code. You should be able to just use unbox(key: "key", formatter: formatter) to unbox any collection containing dates, but will need to look at your specific usecase to determine exactly how it'll work.

Unfortunately, I can't put my exact code since it's proprietary.  However, the salient portions of the model and JSON look like:
class MyObject: NSObject, Unboxable {
    let id: String
    let advanceAt: Date
    let guestInfo: [[String:String]]

    static let dateFormatter = DateFormatter()
    required init(unboxer: Unboxer) throws {
        if (MyObject.dateFormatter.dateFormat == "") {
            MyObject.dateFormatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"
        }
        self.id = try unboxer.unbox(key: "id")
        // this works.
        self.advanceAt = try unboxer.unbox(key: "advance_at", formatter: MyObject.dateFormatter)

        // this doesn't seem to work:
        self.guestInfo = try unboxer.unbox(key: "guest_info", formatter: MyObject.dateFormatter)
    }
}

JSON:
{
    "id": "1F2D004F-4775-434A-830F-AE313E5C918F",
    "advance_at": "2017-05-21T14:54:11.117Z",
    "guest_info": [
        {
            "58ed258d47919a00081c2d78": "2017-05-21T14:48:41.650Z"
        },
        {
            "58ed1ffd47919a004a1c2d51": "2017-05-21T14:52:38.775Z"
        },
        {
            "58e2e9da4daa7a347ddbfc2b": "2017-05-21T14:48:38.146Z"
        }
    ]
}

Thanks.


stage0,tests: support more Linux architectures

Rkt stage0 should support all Linux architectures specified by appc.
TestMissingOrInvalidOSArchFetchRun needs to skip the test case involving
the invalid arch, due to rkt failing it before reaching stage0.

I'm uneasy about adding this until we actually know that rkt successfully builds against these platforms; right now the only thing we're continuously testing against is amd64. I know a couple of people were investigating ARM support but haven't seen an update on that for a while. @monstermunchkin do you happen to have actually tried any of these platforms?

Yes, I have tried it on armv7l (Raspberry Pi) and it works perfectly.

oh, that's nice to know :-)
/cc @alban we should figure out a support matrix or something here and
determine how we can CI this stuff.
On Wed, Nov 18, 2015 at 11:44 AM, Thomas Hipp<EMAIL_ADDRESS>wrote:

Yes, I have tried it on armv7l (Raspberry Pi) and it works perfectly.
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/pull/1766#issuecomment-157839411.

Removed obsolete invalid-arch test.

LFAD.


[Enhancement] Eating Trigger

It's a suggestion of adding a trigger.
This trigger, triggers whenever a player consumes or eats an item/something.
For example: Whenever the player eats cooked beef give hunger effect.
Trigger: Eat/Consume; Target: Self; Condition: Item(cooked beef); Mechanic: Potion(Hunger).
This would be great for editing what happens when a player consumes or eats an item.
Hope is useful.
Thanks.

Duplicates #127. Though both will be considered when this is to be implemented.


Issues with dnssd v1.2.0

Hi everybody,
I'm facing issues with commit 4da759009452b2863db09ff6b03c349103ec5bd6. I haven't found the root cause, but it seems that dnssd detects conflicts even if there are none.

conflicts are always detected; the first name passing is with "(2)" added
since it's adding braces, the name might become invalid for Home

https://github.com/brutella/dnssd/blob/665cf86dce8e8a8b4c6164e2ac038d6b667dc80b/probe.go#L77
https://github.com/brutella/dnssd/blob/665cf86dce8e8a8b4c6164e2ac038d6b667dc80b/probe.go#L83
I tried patching the format, but still the .local address is being incremented. Reverting 4da759009452b2863db09ff6b03c349103ec5bd6 works for me.

On which platform are you using the library?

I'm on Ubuntu Server 20.04.1, Raspberry Pi 4 (arm64).

I encountered this issue running on a device with 2 interfaces to the same network. dnssd appeared to conflict with itself creating an "InstanceID (2)" entry which was unconnectable from homekit.
Disabling one of the two interfaces successfully works around the issue in my case, but it's something that should be looked at.

This issue should already be fixed by now.

I still encounter the same issue with the latest commit, but I could fix it like @rblenkinsopp suggested. I had two interfaces (eth and wifi) connected to the same network.
Thanks both of you.


Caching of REST data

We need a caching mechanism for data provided by Django rest framework!
Example: Server sends an auto update to all clients that motion 42 is updated. Each client which currently shows motion 42 sends a GET request to server to receive the current motion 42 object. Each get request makes a DB query. This is a big performance issue if you want to use OpenSlides in participant mode...
So maybe we find a quick solution for 2.0?
See also the discussion in Oskars old pull request #1444 (which wasn't merged).
@normanjaeckel Can you describe your cache suggestion?
@boehlke As discussed today: Please add your ideas for @normanjaeckel .

An important requirement: The caching mechanism have to check the permission of the requested user! (E.g. a manager is allowed to see more information from rest api than a normal user)

I am not sure whether the scenario is correct. The autoupdate data should  contain the updated motion data so that the clients do not have to fire new GET requests. But internally the server fires (multiple) GET requests to himself so build these data for the clients.

We have to separete any caching efforts from optimization of autoupdate process. See #2008.

@normanjaeckel Is this issue fixed by our current caching system?

Should be done.


[Nomination] giansalex for telegram bot

Who are you nominating?
@giansalex (Giancarlos Salas)
What are you nominating them for?
His incredible work on Juno Telegram Bot and creation of the code that allows a user to upload a wasm file on chain
Please provide links to their work.
https://github.com/Highlander-maker/juno-tg-bot

Nice. Would be cool if it supported token gated groups. I.E. own a certain amount of cw20 tokens to gain access to a telegram group.

interesting... So smart contract  that checks the balance of a wallet that knows how much of the token that can gain access ?

interesting... So smart contract that checks the balance of a wallet that knows how much of the token that can gain access ?

You shouldn't need to write any custom smart contact. Can be handled entirely by the bot. Basically, have the user connect their wallet, get the balance from the cw20 token contract. If the user's amount is larger than the minimum set in bot config, then they get access to the token gated channel.

you should have also nominated yourself @Highlander-maker. you have spent a great amount of time on the project and started it also. @JakeHartnell

ok Jake. Let me look in to it. :)

@JakeHartnell pretty sure omniflix have this working already for telegram: juno.omniflix.com

@JakeHartnell pretty sure omniflix have this working already for telegram: juno.omniflix.com

If they open source it, will nominate them. They deserve some $JUNO for that. Does theirs work with cw20s?

This sounds like https://collab.land/

@giansalex has been one of the most outstanding contributors during Hack Juno. :clap: :clap: :clap:
This ticket is a duplicate of his main nomination #13. So closing, but will link to this issue from there.


Enable arm64 build

Set build_engine_artifacts to false since we're cross-building on x64 (we don't need SDK artifacts)
Update azure-pipelines.yaml for continuous integration
Add the "common" device profile

I chose a profile factor of 0.5 for kCommon because it just looked good on my monitor. Actually the Tizen system info returns a dpi value of 210 which is larger than expected (around 91). I don't know how to choose a right value. Texts might be too small on higher dpi monitors.

Note that you need to update the toolchain (https://github.com/flutter-tizen/tizen_tools/pull/7) to build for arm64.

I've tried building it and found 2 fails (maybe my environment is affecting it).

flutter/tools/gn reports error, it expects pkgconfig directory in sysroot/arm64/usr/lib and fails to find it in sysroot/arm64/usr/lib64. I've symlinked ../lib/pkgconfig into lib64 to work around it.

ERROR at //build/config/linux/pkg_config.gni:103:17: Script returned non-zero exit code.
   pkgresult = exec_script(pkg_config_script, args, "value")
               ^----------
Current dir: /mnt/tizen/flutter/engine-build/engine/src/out/linux_release_arm64/
Command: python /mnt/tizen/flutter/engine-build/engine/src/build/config/linux/pkg-config.py -s /mnt/tizen/flutter/tizen_tools/sysroot/arm64 -a arm64 --system_libdir lib freetype2
Returned 1.
stderr:

Package freetype2 was not found in the pkg-config search path.
Perhaps you should add the directory containing `freetype2.pc'
to the PKG_CONFIG_PATH environment variable
No package 'freetype2' found
Traceback (most recent call last):
 File "/mnt/tizen/flutter/engine-build/engine/src/build/config/linux/pkg-config.py", line 248, in <module>
   sys.exit(main())
 File "/mnt/tizen/flutter/engine-build/engine/src/build/config/linux/pkg-config.py", line 143, in main
   prefix = GetPkgConfigPrefixToStrip(options, args)
 File "/mnt/tizen/flutter/engine-build/engine/src/build/config/linux/pkg-config.py", line 82, in GetPkgConfigPrefixToStrip
   "--variable=prefix"] + args, env=os.environ).decode('utf-8')
 File "/usr/lib/python2.7/subprocess.py", line 223, in check_output
   raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['pkg-config', '--variable=prefix', 'freetype2']' returned non-zero exit status 1

See //build/config/linux/BUILD.gn:30:1: whence it was called.
pkg_config("freetype2") {
^------------------------
See //build/config/BUILDCONFIG.gn:357:33: which caused the file to be included.
 _native_compiler_configs += [ "//build/config/linux:sdk" ]
                               ^-------------------------

ninja build failed with errors in flutter-tizen.cc related to long/long long mismatch like: ```
../../flutter/shell/platform/tizen/flutter_tizen.cc:194:53: error: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Werror,-Wformat]
FT_LOGE("can't find texture texture_id = %lld", texture_id);

@wiertel

I usually redirects PKG_CONFIG_PATH to the host's freetype.pc (see the bottom of this page) but your workaround looks better for me.
I already patched all occurrences of %lld (see the diff) so it shouldn't appear in the code.


fix: fixed ee test

Description
This PR fixes the EE test testExportApplicationJSON_withExistingDatasourceInStagingOnly_stillContainsDatasourceInExportedFile failing post merge of https://github.com/appsmithorg/appsmith/pull/28146
PR fixes following issue(s)
Fixes #28231
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test


Not an issue but a question!!!

I am trying to create an applet in python, following the examples here, and i want to test it.
How to do this?
Thanks in advance.

Save the .plugin and all associated modules to .local/share/budgie-desktop/plugins/yourpluginfolder
Then restart the panel to see the plugin appear in budgie settings

ok.Thank you.

With all respect can you help me to solve some problems with my applet.I am not so sure if its running .

Link to the code?

I don't have a link.Its a python script.I followed the examples for  python and it is in entry level.I made a button to open a drop down menu .But  now i have only the button.
Should I paste the code here?
Thanks.

Create a github gist or a test github repo

Ok. This is it.
https://gist.github.com/cgiannakidis70/85d8c7390dc265f2db6a4197fccc3bd3

line 35 onwards only adds a button with an image.  I don't see any code here where you have connected the "clicked" event for the button and then added code to respond to that click event.

So, with all respect, how should I go on with the code.
Thanks in advance.

def _respond_to_clicked(self, *args):
     # add the code here to display or do what you want
     # it really is up to you what you want to do with the clicked event
     print ("Hi you have clicked me")

self.button.connect('clicked', self._respond_to_clicked)

OK .Thanks a lot.I'll continue this as you said.


Use sinopia_api for export instead of trellis

Fixes #146
Some more cleanup and refactoring and cleanup coming. Will be working on tests and squashing WIP commits.

@aaron-collier do you want to test out this branch on AWS development? Happy to pair on this.

This is now working in AWS @jermnelson : https://sinopia-exports-development.s3-us-west-2.amazonaws.com/sinopia_export_all_2020-10-05T16%3A52%3A15.525Z.zip was exported from this branch.
Back to working out the tests since this required a couple of tweaks.


Feature request: Selector view when using - [x]  in md

@czzonet In what way is this issue different from #56?