Sorting direction

Hi, I'm trying to sort my object and set a fieldOrder in my for Loop. I have two rows. Everything works fine, if I drag my last element to the first one. If I try to drag the first after the last one, my model do not Change...
vm.sortableOptions = {
stop: function(e, ui) {
console.log("Sort");
for (var index in vm.bdConfigTable.bdConfigTableFields) {
$scope.safeApply(function() {
vm.bdConfigTable.bdConfigTableFields[index].fieldOrder = index;
});
}
},
'ui-floating': false
};

Can you provide an example by forking one of the two "Ordering" examples found in README?

Any feedback on this?
As noted in the README examples & details link, you should do the sorting inside the controller and not in the view (the ng-repeat).
Is this the case?

Any feedback on this?

I'm closing this for now.
Feel free to re-open, if you still have problems.


[BUG] install.sh fails to build Blender due to hardcoded path at link time

Describe the bug
install.sh fails to build Blender due to hardcoded path at link time
Steps to Reproduce

What version of the code were you using? Tell us the output of git log -n 1
'''
% git log -n 1
commit 258cf38e8601dc1d010dd4789eb322a0e40d26d3 (HEAD -> main, origin/main, origin/HEAD)
Author: pvl-bot<EMAIL_ADDRESS>Date:   Sun Jun 18 00:46:48 2023 -0400
Switch to BSD 3-Clause License
%
'''

What command did you run?

% bash install.sh

What are your output logs?

Add your logs here, preferably from a job run with --debug

** (If this is your first time running Infinigen) What are the full output logs of install.sh ?**
output log attached as a file because too long for the bug tracker, sorry

output.log
Platform

OS & OS Version: macOS Ventura 13.3.1
GPU (?) :
GPU Driver Version (?) :
RAM (GB): 16

Additional context
Add any other context about the problem here.

Thanks for the info, the hardcoded path is actually not fatal and not part of our code (it must have been left in by the developer of some dependency.  The real error is that you are missing required C headers, likely due to bad CPATH or LD_LIBRARY_PATH.
c-blosc/blosc/blosc-common.h:13:10: fatal error: 'string.h' file not found
      #include <string.h>
               ^~~~~~~~~~

This is Ventura specific and we are working on a proper fix. For now, the following has worked for us internally, but PROCEED WITH CAUTION:
`#Uninstall Xcode Command Tools
sudo rm -rf /Library/Developer/CommandLineTools ,
#Uninstall homebrew LLVM
brew uninstall llvm ,
#I also run brew doctor and brew cleanup, not sure if they are helpful.
bash install.sh.
#homebrew would install llvm, but still got compiling errors. As suggested by homebrew, run command
export LDFLAGS="-L/usr/local/opt/llvm/lib"
export CPPFLAGS="-I/usr/local/opt/llvm/include"
Then rerun bash install.sh`

Hello,
The workaround didn't help, I have no /usr/local/opt/llvm/include folder.
I've found stdint.h in /opt/homebrew/opt/llvm//include/c++/v1/,
So I tried export CPPFLAGS="-I/opt/homebrew/opt/llvm//include/c++/v1/" but install shows the same errors


Roll engine 6bf311f1d62c..7a77e3625dd1 (3 commits)

git@github.com:flutter/engine.git/compare/6bf311f1d62c...7a77e3625dd1
git log 6bf311f1d62c..7a77e3625dd1 --no-merges --oneline
2019-11-21<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from bC9Qy... to FQdiV... (flutter/engine#13936)
2019-11-21<EMAIL_ADDRESS>Roll src/third_party/skia 935a35d972e5..f9291b8942d8 (13 commits) (flutter/engine#13938)
2019-11-21<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from 7mmHP... to VHWsK... (flutter/engine#13939)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


Needs to be installable from either Conda and/or Pip

TINerator needs to be installable from a package distribution repository. Hosting it on conda forge would be the appropriate first step.

Conda Forge package is being worked on here: https://github.com/daniellivingston/staged-recipes


Fix ITEX TF2.12 regression issue

Type of Change
bug fix
API not changed
Description
ILITV-2790: ITEX TF2.12 OOB LLGA Int8 4 model functionality regression
Expected Behavior & Potential Risk
The 4 INT8 models functionality regression issues can be fixed.
How has this PR been tested?
Pre-CI, model test and OOB extension test.
Dependency Change?
No.

extension test:
https://inteltf-jenk.sh.intel.com/view/lpot-oob/job/intel-lpot-validation-top-extension-TFnewAPI/354/


Stop processing data for Australia AOI

The inclusion of Australia in the RTC image service impacts visualization in the webmap.
Until we hear from stakeholders, we'll continue to process new data, but keep it in a separate bucket.

Just heard from Lori that there's no need to continue processing new data for this AOI.
I've copied the data from RTC_services to an Australia prefix, so that it can still be used for testing global visualizations.
After confirming that NASA Disasters is no longer referencing the services for the Australia effort, we can remove all of the products from the RTC_services prefix. Until then, I will remove the RTC products from the RTC_services prefix so that they will not interfere with the remaining AOIs included in the service.


version numbers don't match

i've downloaded version 1.2 from GitHub but after download it claims to still be at version 1.1.6

the CFBundleShortVersionString in the Info.plist doesn't line-up with the release version

Thanks! I forgot to bump that.

I resolved this problem with the latest release. Thanks for reporting.

thanks, i can confirm the problem is resolved!


docs: add the installation guide with aqua

Close #34

Codecov Report

Merging #35 (f099ba0) into main (73b3f6a) will increase coverage by 0.74%.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   67.48%   68.22%   +0.74%
==========================================
  Files           7        7
  Lines         692      683       -9
==========================================
- Hits          467      466       -1
+ Misses        225      217       -8

see 1 file with indirect coverage changes

CI failed, but the error has nothing to do with the change of this pull request.
https://github.com/hirosassa/ksnotify/actions/runs/6451347195/job/17521863323?pr=35
Run cargo clippy -- -D warnings -W clippy::nursery
    Checking ksnotify v0.1.8 (/home/runner/work/ksnotify/ksnotify)
error: redundant pattern matching, consider using `is_ok()`
  --> src/config.rs:[8](https://github.com/hirosassa/ksnotify/actions/runs/6451347195/job/17521863323?pr=35#step:6:9)2:33
   |
82 |         let suppress_skaffold = matches!(env::var("KSNOTIFY_SUPPRESS_SKAFFOLD"), Ok(_));
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("KSNOTIFY_SUPPRESS_SKAFFOLD").is_ok()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
   = note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`

error: redundant pattern matching, consider using `is_ok()`
  --> src/config.rs:83:21
   |
83 |         let patch = matches!(env::var("KSNOTIFY_PATCH"), Ok(_));
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("KSNOTIFY_PATCH").is_ok()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

error: could not compile `ksnotify` (bin "ksnotify") due to 2 previous errors
Error: Process completed with exit code [10](https://github.com/hirosassa/ksnotify/actions/runs/6451347195/job/17521863323?pr=35#step:6:11)1.

Yeah, I agree with you, so I'll merge this PR.
I'll fix this problem in another PR 👍

Thank you!


feature request: photo frame

I want to request a feature to add frames like nothing os photo widget.

I love the app. thanks for everything 🫶🫶🫶

Hey @SeaItSelf, thanks for reaching out and submitting a suggestion!
I have considered adding support for simple frames like that, but never looked into it. I'm gonna investigate it in order to hopefully include the feature in an upcoming update.

Hi @HusniMuhammad, support for displaying text is also in my backlog but I haven't prioritized it yet. That's an interesting idea and I'll take note of it for whenever I'm working on it.
Thanks for the suggestion!

Hi @SeaItSelf, thanks for your patience! I'm happy to say that colored photo borders are finally coming in the next app update. You'll be able to apply border to any widget, except the ones that use the "Fill widget area" aspect ratio.
Thanks for your suggestion, I'll leave this issue open until a version that contains the change is released.

Hi @SeaItSelf, this feature is included in version 1.19.0, released today. Thanks for your suggestion!


Updated readme file for snake game gui

Issue #1702  Under GSSOC'23
Updated Snake Game (GUI) readme file for better understanding the code.

@avinashkranjan can you check this?


default-stackdriver-user

We had &authuser=1 argument in the stackdriver links that was opening with second logged-in user. While some users logged in to a personal gmail first, many other in the organization are logged in with their lyft accounts first.
It is better to not specify this argument and expect all L5 Flyte users are logged in to gmail with @lyft.com account first. If that isn't the case we will instruct them to sign out from all google accounts and sign in again with @lyft.com first.

PTAL @kumare3
CC @sumedhsakdeo

PTAL @migueltol22 @wzpher

🚀


Cannot open quickfix entry after (Telescope => send to quickfix) on dashboard/alpha

Issue
I often will open a new lvim and directly search with telescope (live_grep or git_files) some text and directly add it to quickfix entries to be able to walk through each occurrence.
The list is correctly sent to quickfix but i cannot open an entry.
Workaround

The solution is to already open one file and then search use telescope + send to quickfix.
Bizarrely this works if you have a split with one file one one side and alpha on the other (accessed with <space>;)

Potential source of problem
I suspect this is coming from alpha/dashboard that is a special buffer but I don't know how to tackle this 🙂

the issue comes from these lines
https://github.com/abzcoding/lvim/blob/df0e749e369c6a37c9e1a255efde0fa202f76005/lua/user/keybindings.lua#L198-L201
commenting them would solve this issue, but we need to find the actual root ( or a proper workaround

It kinda works when I comment these lines but it is opened in a vertical split (I would expect it to replace alpha buffer)
And we loose the functionnality of <CR> to maximize that i use a lot 🙂
https://user-images.githubusercontent.com/37271970/215800520-a910aad6-c8ae-4f9d-b9ae-fb2a3b0ec4ae.mov

Here is another error if this can help ! Triggered when trying to enter on the quickfix entry but opening a file before
https://user-images.githubusercontent.com/37271970/215845538-821dee17-8fe8-4f8b-976a-232b0df8b250.mov

@williamgoulois can you check this commit?

I have a different error does it work for you ?
https://user-images.githubusercontent.com/37271970/216054348-501c2345-0331-4908-a83f-1b11b0d568bb.mov

I have a different error does it work for you ?
Screen.Recording.2023-02-01.at.14.20.16.mov

nope pushed the wrong thing 🤦

should be fixed in the latest commit

nvim-bqf was loading on BufReadPost but it should've been loading on WinEnter

Thanks it works perfectly now 🚀


Add Documentation for Contributors

👍 Nice Project
It would be great if the CONTRIBUTING.md file is there. So that community can get started to contribute🚀.

The issue is resolved by #116 PR


Types for goto are not correct

Describe the bug

As you can see while opts.state is defined with a @param the actual type of the function uses an inline type so it's not being picked up by TS, this also causes svelte-check to fail
Reproduction

go to https://www.sveltelab.dev/kskm0b9gas4fxu9
observe goto has a type error
try to click the go button
observe the state is actually there and used by sveltekit

Logs
No response
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.10.5 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/adapter-auto: ^3.0.0 => 3.0.0
    @sveltejs/kit: ^2.0.0 => 2.0.3
    @sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1
    svelte: ^4.0.0 => 4.2.8
    vite: ^5.0.0 => 5.0.10

Severity
blocking an upgrade
Additional Information
I've added blocking an upgrade because we use svelte-check on the CI, i assume this might be something generally used

I'm gonna PR this fix


[site] chore: Fix padding and sizes

Description
fixes: https://github.com/dust-tt/tasks/issues/957
I do not understand : https://github.com/dust-tt/tasks/issues/957#issuecomment-2190672955 , where should the logo appear in mobile view ?
Risk

Deploy Plan
deploy front

Could appear next to the menu button:

Could you share a screenshot?


Create LICs 12-14 with corresponding unit tests

There exists at least one set of two data points, separated by exactly K PTS consecutive
intervening points, which are a distance greater than the length, LENGTH1, apart. In addition, there exists at least one set of two data points (which can be the same or different from
the two data points just mentioned), separated by exactly K PTS consecutive intervening
points, that are a distance less than the length, LENGTH2, apart. Both parts must be true
for the LIC to be true. The condition is not met when NUMPOINTS < 3.
0 ≤ LENGTH2

There exists at least one set of three data points, separated by exactly A PTS and B PTS
consecutive intervening points, respectively, that cannot be contained within or on a circle of
radius RADIUS1. In addition, there exists at least one set of three data points (which can be
the same or different from the three data points just mentioned) separated by exactly A PTS
and B PTS consecutive intervening points, respectively, that can be contained in or on a
circle of radius RADIUS2. Both parts must be true for the LIC to be true. The condition is
not met when NUMPOINTS < 5.
0 ≤ RADIUS2

There exists at least one set of three data points, separated by exactly E PTS and F PTS consecutive intervening points, respectively, that are the vertices of a triangle with area greater
than AREA1. In addition, there exist three data points (which can be the same or different
from the three data points just mentioned) separated by exactly E PTS and F PTS consecutive intervening points, respectively, that are the vertices of a triangle with area less than
AREA2. Both parts must be true for the LIC to be true. The condition is not met when
NUMPOINTS < 5.
0 ≤ AREA2

See the following issues: #44 #66 and pull request solving them.


Update README.md

Added Go.
Adds the following events or companies:

Checklist

[] I have updated the event or company counts
[] I have put the most recent relevant date in the "Last Update" column
[] I have linked to the article about the change, not the company's website

Hi there! We recently re-worked the site to use yaml data files. We'd be happy to accept your PR once it's been reworked to use the right format.
Thanks!


Fix

I would be great if we add a test case to cover this specific bug that we are fixing!

Great idea! Just added !


K8SPS-291: Add prestop hook to MySQL pods

CHANGE DESCRIPTION
Problem:
Terminated MySQL pods don't leave the cluster properly.
Solution:
Add a prestop hook to remove terminating pod from the cluster.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PS version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/f38dcc4581769bf36589b873fcf51d8fe1e7cfce
image: perconalab/percona-server-mysql-operator:PR-535-f38dcc4

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/63ad0e6ac45c0e6d0d176c343a963a09c28e3752
image: perconalab/percona-server-mysql-operator:PR-535-63ad0e6

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/9dc3973d633baeac210c141866a5781ab15492a6
image: perconalab/percona-server-mysql-operator:PR-535-9dc3973

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/9dc3973d633baeac210c141866a5781ab15492a6
image: perconalab/percona-server-mysql-operator:PR-535-9dc3973

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/9dc3973d633baeac210c141866a5781ab15492a6
image: perconalab/percona-server-mysql-operator:PR-535-9dc3973

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/2b58eff81e00ff7dc20e1183fb44107ccde785b1
image: perconalab/percona-server-mysql-operator:PR-535-2b58eff

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
failure

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/2ee6cb0ab9941d78635e036f67e35f0bb319f83c
image: perconalab/percona-server-mysql-operator:PR-535-2ee6cb0

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/9c1444191db65ded667303bf79662ed784713e60
image: perconalab/percona-server-mysql-operator:PR-535-9c14441

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
failure

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/9c1444191db65ded667303bf79662ed784713e60
image: perconalab/percona-server-mysql-operator:PR-535-9c14441

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
failure

gr-scaling
failure

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/b445bb885e831c9e79fbe8b3cfa7372748a921f5
image: perconalab/percona-server-mysql-operator:PR-535-b445bb8

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
failure

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
failure

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/3d12e3365e7591b26e3530aeb551e2942ba91554
image: perconalab/percona-server-mysql-operator:PR-535-3d12e33

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/3d12e3365e7591b26e3530aeb551e2942ba91554
image: perconalab/percona-server-mysql-operator:PR-535-3d12e33

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/3d12e3365e7591b26e3530aeb551e2942ba91554
image: perconalab/percona-server-mysql-operator:PR-535-3d12e33

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
failure

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
failure

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/e69d4b7c381e374238bc2a9c15d738affb6e7c96
image: perconalab/percona-server-mysql-operator:PR-535-e69d4b7

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-demand-backup-haproxy
passed

gr-haproxy
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-recreate
passed

gr-scaling
passed

gr-self-healing
passed

gr-tls-cert-manager
passed

gr-users
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

recreate
passed

scaling
passed

service-per-pod
passed

sidecars
passed

smart-update
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 30 out of 30

commit: https://github.com/percona/percona-server-mysql-operator/pull/535/commits/e69d4b7c381e374238bc2a9c15d738affb6e7c96
image: perconalab/percona-server-mysql-operator:PR-535-e69d4b7


feat(emergency_handler, mrm_handler): change to read topic by polling

Description
Based on the discussion, change emergency_handler and mrm_handler to read topic by polling instead of best_effort callback.
Tests performed
psim test were performed
Effects on system behavior
nothing
Interface changes
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Autumn60
Thank you for improving emergency_handler node!!
Actually, the emergency_handler node will be duplicated in several months and mrm_handler node will be used instaed.
Are you going to make the same changes to also mrm_handler ?
If yes, could you add the changes on mrm_handler to this PR?

@veqcc
OK, I'll make the change to mrm_handler .
Thanks for the info and suggestions!

@Autumn60
Could you fix the following bug soon?
Since it is merged to main steam so I want fix it right now.
If you cannot, please inform me
https://github.com/autowarefoundation/autoware.universe/pull/7264#issuecomment-2151740216

@veqcc
The bug is already fixed when I merged this PR with main to resolve conflicts.
https://github.com/tier4/autoware.universe/commit/45f1b9599c2b35f1840a310989405b6e4205586b#diff-60980d5de6dc4345c86fd9ee7241f0db5e7909dbad5fa181b3d6dcc75b1f384cR523

@Autumn60
The main branch doesn't look fixed. Is it true?
https://github.com/autowarefoundation/autoware.universe/blob/a3955e90cf849bb77f4f6e0444a6379b070d227f/system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp#L523

@veqcc
Oh, this is totally my mistake. :cry:
I have created another PR that fixes this, could you please check it?
https://github.com/autowarefoundation/autoware.universe/pull/7362


store dockerfile inside image

It should be a prebuild plugin. Path to the dockerfile should be configurable.

Resolved


Omnisharp intellisense neovim doesn't suggest classes from referenced projects.

Omnisharp intellisense doesn't work with referenced projects. Meaning it doesn't recognise or suggest classes from referenced project unless you manually import the namespace.
Without import.

With import.

@NeuSandeZ Have you enabled import completion in your OmniSharp.json? See https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options#roslyn-extensions-options

@JoeRobich  Hey, thanks for that tip, it solved the problem. I wonder why it doesn't come true by default.


perf(dashboard): make loading datasets non-blocking

SUMMARY
This will be one of the many PRs to address perf issues raised in #15518 .
Currently the Dashboard page will wait for both datasets and charts data to start rendering, however the datasets data are only used in filter indicators and filter boxes and should not block us from rendering other charts. In our case, the datasets endpoint is often much slower because we have a giant single-source-of-truth datasource with thousands of metrics and columns.
Unblocking rendering from the datasets endpoint should speed up the page rendering a little bit. In our use case, it's often a matter of a full second.
It's not easy to simply remove datasources from Dashboard state as that would involve letting the filter indicators and filter box fetching datasource metadata themselves.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Dashboard renders after /datasets is loaded:
https://user-images.githubusercontent.com/335541/125714566-d15131a0-ea12-4ce8-a532-eef8657cd8a9.mp4
After
Dashboard renders as soon as /dashboard/[id] and /dashboard/[id]/charts are loaded:
https://user-images.githubusercontent.com/335541/125715172-b6d614b3-3097-4dbb-9726-b51c28b04c29.mp4
TESTING INSTRUCTIONS
Go to dashboard page, make sure everything still renders correctly.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

this is a reasonable trade-off we can try. Is it possible that filter_box started query before dataset metadata is not ready, will that cause any issue?

this is a reasonable trade-off we can try. Is it possible that filter_box started query before dataset metadata is not ready, will that cause any issue?

Time Column and Granularity control in filter boxes may not have select choices. Filter indicators may show inexplicable filter values. But those are expected to be temporary and not very noticeable.
In case datasets loading fails, in previous case, the whole page won't render, while after this change you still have a largely functional Dashboard page.

Have we verified yet that none of the chart plugins use datasets? If so we should also stop passing datasets to the charts.

Have we verified yet that none of the chart plugins use datasets? If so we should also stop passing datasets to the charts.

Thanks for pointing this out. I did more vetting and realized that some charts do use info on datasource, mostly non-critical info such as column name verboseMap here: https://github.com/apache-superset/superset-ui/blob/61accc6ce9c546331b7407cde21d6ec163fe191d/plugins/legacy-plugin-chart-pivot-table/src/transformProps.js
Fixed a re-render issue now that charts will be updated accordingly once datasets are loaded:
https://user-images.githubusercontent.com/335541/125838954-c30b276b-24e2-4612-97c8-60d97f931065.mp4


missing  jak2_data.csv

can't find jak2_data.csv in the data folder.

@ylp812 @gmseabra I downloaded JAK2 dataset from CHEMBL and uploaded it into data folder. Now everything should work

Thanks!


idea: replace alert() with gif

Problem/Need:
Based on user test, alert()s are jarring and confusing. For example, it's not obvious that clicking on the "Add image" button is related to the alert() message. It looks more like an error happened.
Suggestion:
Show, don't tell. But using a tour (shepherd.js) is a little overkill. Show the user a gif instead.

[ ] show a brief animation that morphs out from behind specific buttons (decide which buttons based on recent user test),
[ ] by using morphing_button animation

[ ] (after fixing that original-position-to-absolute animation issue),

[ ] then make the gif disappear after a few seconds

[ ] (after deciding on the gif content).

going with #92 and #89 instead


outline panel not working

What steps will reproduce the problem?

Version 5.0.0
outline panel not showing functions and classes

Hey @binggu56, thanks for reporting. This is a duplicate of issue #15139.


ExtractTextPlugin cant get css file

use mix.sass or mix.less ,will add to style src to the first entry, and it auto push to Config.preprocessors which use ExtractTextPlugin,but it will not reload on change with
npm run hot,becuase  ExtractTextPlugin not work in hmr model
Other problem is the library model be umd,mix.sass and mix.less add the style src file to first entry ,this will brock the umd script file.
So I require('./../sass/app.scss') in app.js,hmr hot reload work,but cant generate css file by ExtractTextPlugin
The suggestion is remove sass and less ,stylus api,and let sass,less or other style file be require in script file, and check if is hot  model or not.if in hot model,not use  ExtractTextPlugin,else use  ExtractTextPlugin,this useful to do perfect compile by webpack!

Can you post your configuration and the package versions?

@ruchern
My config like this,is laravel default config
let mix = require('laravel-mix');

mix
	.js('resources/assets/js/app.js', 'public/js')
	.sass('resources/assets/sass/app.scss', 'public/css');

now I change it like this
const ExtractTextPlugin = require("extract-text-webpack-plugin");
let mix = require('laravel-mix');

/*
 |--------------------------------------------------------------------------
 | Mix Asset Management
 |--------------------------------------------------------------------------
 |
 | Mix provides a clean, fluent API for defining some Webpack build steps
 | for your Laravel application. By default, we are compiling the Sass
 | file for the application as well as bundling up all the JS files.
 |
 */
if (!Mix.isUsing('hmr')) {
	mix.webpackConfig({
		module: {
			rules: [{
				test: /\.scss$/,
				use: ExtractTextPlugin.extract({
					fallback: "style-loader",
					use: ['css-loader', 'sass-loader']
				})
			}]
		},
		plugins: [
			new ExtractTextPlugin({
				filename: (getPath) => {
					return getPath('css/[name].css').replace('css//js', 'css');
				},
				allChunks: true
			})
		]
	});
}

mix
	.js('resources/assets/js/app.js', 'public/js')
	// .sass('resources/assets/sass/app.scss', 'public/css');

and app.js
if (process.env.NODE_ENV === 'development') {
	if (module.hot) {
		module.hot.accept();
	}
}
require('./../sass/app.scss');
require('./bootstrap');

and index.blade.php
@if (!file_exists(public_path('hot')))
    <link href="{{ mix('css/app.css') }}" rel="stylesheet">
    @endif

It works,so @JeffreyWay please and ExtractTextPlugin to laravel-mix not only vue-loader,and add a determine if or not is hmr model to check use inline or generate css.
finally,can add somethine to laravel mix function,thx your work!


Document how to use rules from code

I assume it must be somehow possible to define rules in a Python module and have turq use those. In other words, I want to store the rules and run turq using those. How can one do that?

Ok this looks as simple as:
TurqHandler.code = """path('*').text("Hello World!")"""
TurqHandler.rules = parse_rules(TurqHandler.code)

Ok it was simple to figure it out from code. But it would be nice if this was documented as part of package docs.

Here's an example that you can use if you want (spawns turq server in a different process and then uses requests library to making an actual request to turq):
import BaseHTTPServer
from multiprocessing import Process

from turq import TurqHandler, parse_rules
import requests

HOST = "<IP_ADDRESS>"
PORT = 13085
RULES = """path('*').text("Hello World!")"""

def spawn_turq(host=HOST, port=PORT, rulecode=RULES):

    def serve(host, port, rulecode):
       handler = TurqHandler
       handler.rules = parse_rules(rulecode)
       server = BaseHTTPServer.HTTPServer((host,port), TurqHandler)
       server.handle_request()

    p = Process(target=serve, args=(host, port, rulecode))
    p.start()
    return p

if __name__=="__main__":
   p = spawn_turq()
   r = requests.get("http://%s:%i" % (HOST, PORT))
   print r.text
   p.join()

Of course it would be nice to add some log output, asserting that return text is hello world etc...  go ahead and add those if you like.

Here's also a handy context manager that can be used to "mock" a http server ;)
@contextmanager
def mock_http_server(host, port, rulecode):
    def serve(host, port, rulecode):
       TurqHandler.rules = parse_rules(rulecode)
       server = BaseHTTPServer.HTTPServer((host,port), TurqHandler)
       server.handle_request()
    p = Process(target=serve, args=(host, port, rulecode))
    p.start()
    time.sleep(1) # wait a sec so the server has time to get up for sure
    yield
    p.join()

Thank you for the sample code.
Turq was intended specifically for interactive use, which is why I did nothing to provide a sane API. Several people have since requested a way to use Turq programmatically, so I definitely want to make this easier in the future. For the time being, I will document the present interface as you suggest. I’ll try to get around to this in a couple weeks.
By the way, have you seen HTTPretty? At the time I wrote Turq, I believed HTTPretty was the way to go for automated tests. I’ve since heard about problems with HTTPretty so maybe there’s a place for Turq in automated scenarios as well.

This is now explained in the docs.


Change for CyaSSL on wifire

Signed-off-by: delme-imgtec<EMAIL_ADDRESS>

Replaced by another pull request


consensus: extract block gossiping into its own reactor

spawned by the discussion in https://github.com/cometbft/cometbft/issues/1742
Block gossiping is currently a big part of the consensus reactor, but it actually might not be that difficult to refactor it out, so the consensus reactor just has a blockAvailable signaling mechanism (like it has for transactions), and that thing has to be triggered before you can vote on a proposal.
The thing that populates blockAvailable could be another reactor that propagates the block parts however it wants, including having most of it from the mempool.

Related to https://github.com/cometbft/cometbft/issues/14

We should discuss this topic, possibly synchronously.
I agree that block propagation should be a component by itself, maybe a new reactor, although this is not a requirement. This enables, in particular, some optimizations for consensus heights with multiple rounds (currently we drop the block from the previous round once a new round is started, even thought the same block can be re-proposed).
This component that handles block propagation should be informed, in some way, by consensus about the blocks it has to retrieve. One of the problems of a "blind" block propagation component is that it can be flooded with an arbitrary and possibly invalid number of blocks.
We also have the problem of persisting the blocks we accept (or propose). This is necessary, as otherwise, a node recovering from a crash will likely misbehave, since it does not "remember" actions taken before crashing.

@cason
So I've got to agree with you, I guess that it fits at all possible it's probably good to source what a block is directly from the proposer. However if we look at CAT, maybe there's a solution here.
The proposer could reference the transaction hashes and I think we might be able to reduce bandwidth quite a bit. Overall I'm still of the opinion that we are unlikely to be able to comprehensively fix the mempool, but....
I would like to be wrong about this because I do actually like having it and the other changes that are necessary will in my opinion require a great deal of work from infrastructure operators just to get into production.

Copying over what I just wrote in #1776, which really belongs here.
The block gossip is currently an integral part of the consensus reactor, but its really orthogonal to the core logic. In principle it could be separated out, even into its own reactor. This would clean up the consensus reactor and allow it to align even further with the core consensus specification, which would be nice.
However, there's a few complications to consider in the interface between the consensus reactor and such a new block gossip reactor.
First, as discussed, we need to ensure its still possible to sync up securely through the consensus reactor. This means the Proposal will need to contain some kind of commitment to the block gossip mechanism, whatever it might be (this was the motivation behind this issue in the first place!). Since removing the PartSetHeader from the Block already requires us to add it to the Proposal, we could go ahead and call it "BlockGossipHeader" for generality sake, and have the type be dependent on the actual block gossip mechanism used. I'm not sure it should literally be a generic type, it could just be []byte that are interpreted as necessary by the block gossip (this would mean a bit of extra encoding, but probably a pretty minor thing).
Second, we need to synchronize the round state and the peer states between the two reactors. Block gossiping logic depends heavily on our own consensus state (height, round, proposal) and on that of our peers. Since this information is communicated/stored in the consensus reactor, it would be ideal if it could be reused in the block gossip reactor (without having to be gossiped independenlty). But this will either require some way to share state, which could get messy, or to have regular communication between the two. Basically every time we update our own RoundState or a PeerState, we'd have to notify the BlockGossipReactor as well. This way it would know what to be downloading, and what to be sending to peers.
Third, we need to figure out how proposals will work. Currently the consensus calls CreateProposal from the state package, which calls into the mempool to fetch txs to assemble into a block and then calls PrepareProposal. This could stay in the consensus, but once the block is assembled, we'd need to send it to the BlockGossipReactor to start gossiping. Alternatively this could be done in the BlockGossipReactor, but then the block hash and BlockGossipHeader needs to be sent back to the consensus reactor so it can form the proposal. This would probably be the more natural separation of concerns. That way the consensus doesn't actually need to know anything about blocks, since it would just operate on the block hash and an opaque BlockGossipHeader. And the BlockGossipReactor can start putting together its proposals whenever it wants (eg. in advance of actually becoming the proposer).
Finally, we need a way for the BlockGossipReactor to communicate back to the consensus reactor that it received a complete block. This should be straight forward.
So there's quite a bit to work out, but it definetely seems doable and like it would be a huge unlock, simplifying the consensus package and allowing for much easier experimentation with new block gossip mechanisms.

Oh, as for possible block gossip mechanisms, there's an old issue here https://github.com/tendermint/tendermint/issues/7932 with some ideas

Second, we need to synchronize the round state and the peer states between the two reactors. Block gossiping logic depends heavily on our own consensus state (height, round, proposal) and on that of our peers. Since this information is communicated/stored in the consensus reactor, it would be ideal if it could be reused in the block gossip reactor (without having to be gossiped independenlty).

Notice that we only need to know which block our peers are looking for. If the same block is proposed in multiple rounds, we don't need to propagate it multiple times (currently we need). I agree we need the height information.

Since removing the PartSetHeader from the Block already requires us to add it to the Proposal,

It is on the Proposal. It is part of the BlockID currently, although we have proposals to remove it from votes: https://github.com/tendermint/spec/issues/78

A general comment here is that consensus still needs to inform this block gossip component which blocks it needs. For instance, when accepting a Proposal, the included PartSetHeader must be passed to the block gossip component.
The same applies to when we realize that a block, which is not the Proposal block, becomes valid. This situation is actually an argument against removing the PartSetHeader from vote messages.

Currently the consensus calls CreateProposal from the state package, which calls into the mempool to fetch txs to assemble into a block and then calls PrepareProposal. This could stay in the consensus, but once the block is assembled, we'd need to send it to the BlockGossipReactor to start gossiping.

This requires more thinking, but I would keep the building of a block part of consensus. Consensus needs, in any way, to know the full proposed block, not only its ID.

Is there consensus on moving as much of P2P as possible to  libp2p?

It is on the Proposal. It is part of the BlockID currently, although we have proposals to remove it from votes: tendermint/spec#78

Yes by "remove PartSetHeader from the Block" I mean remove it from the BlockID which means it would need to be separately added to the Proposal. I think ideally the PartSetHeader would only show up in the Proposal and no where else.

A general comment here is that consensus still needs to inform this block gossip component which blocks it needs. For instance, when accepting a Proposal, the included PartSetHeader must be passed to the block gossip component.
The same applies to when we realize that a block, which is not the Proposal block, becomes valid. This situation is actually an argument against removing the PartSetHeader from vote messages.

Yep I was proposing the Proposal generalize over commitments to part sets so that the consensus doesnt need to be aware of how blocks will be gossiped, just that there will be some opaque commitment to a gossip protocol in the proposal.
Good point re another block becoming valid though, just another thing to consider re communication from consensus reactor to blockgossip reactor

This requires more thinking, but I would keep the building of a block part of consensus. Consensus needs, in any way, to know the full proposed block, not only its ID.

Can you say more here? I would think consensus really only needs to know the block id, and nothing else. Obviously it needs to know the block is available, and it needs to be able to get the block to pass it to the state for execution once the block is committed, but it can otherwise stay oblivious to it.
And since the mempool is already concerned with gossiping most of the content of what will ultimately make up the block, it makes sense to potentially consolidate the mempool, block gossip, and block creation functions.

Can you say more here? I would think consensus really only needs to know the block id, and nothing else.

Ideally, yes. Although even in the pseudo-code we round this valid(v) method to check whether a proposed value is valid, from the application (which can be seen as the blockchain) point of view. It is true, and this is a design we consider in Malachite, that consensus only need the output of valid(v), not to "call" this method. Consensus would receive, in this case, the information of a valid block with a given ID was received. Far enough.
But in terms of the existing implementation, is consensus that commits a block, call the application, persists the block, etc., etc. So, for all effects, it currently needs the full block.

Another point here: consensus needs to ensure that both ValidBlock and LockedBlock are available as well. So, at some extent, consensus needs to say to this propagation module that it must keep some blocks, not GC them.

A first step towards this is to remove this logic from the consensus logic implementation (state.go), while still using the same consensus reactor. In particular because we still need the full block in consensus. But I would start this de-coupling from that.


Restore searchParams to Visit and Frame Navigation

Closes hotwired/turbo#456
The changes made in hotwired/turbo#464 resolved an issue in how
GET requests merged query parameters into their URL instance.
Unfortunately, the changes were too loosely scoped, and they affected
all GET requests, including those initiated by  elements with
[href] attributes that declare search parameters directly (that do
not need to be "merged" into anything).
The change made in hotwired/turbo#464 to conditionally include
the FetchRequest.body based on the request's verb enables the changes
made in this commit.
In response to that change, this commit moves the
mergeFormDataEntries() function out of the FetchMethod module and
into the FormSubmission class. Since merging from FormData
instances into a URL is a concern of GET-powered Form Submissions,
moving the function out of the FetchRequest further simplifies that
class. Move the mergeFormDataEntries() to the FormSubmission
constructor to re-write its location property's searchParams prior
to constructing the instance's FetchRequest.

Seems like this is still broken if there's a get-form with params in the URL. Like: <form action="/show?var=1" method="get">. The fix appears to only be working for ahrefs?

https://github.com/hotwired/turbo/pull/461 and https://github.com/hotwired/turbo/pull/464 aimed to cover <form method="get"> whose [action] encoded query parameters.
They was guided by the to the HTML Specification's § <IP_ADDRESS> Form submission
algorithm section, submissions transmitted as GET requests mutate
the [action] URL, overriding any search parameters already
encoded into the [action] value:

Mutate action URL
Let pairs be the result of converting to a list of
name-value pairs with entry list.
Let query be the result of running the
application/x-www-form-urlencoded serializer with pairs
and encoding.
Set parsed action's query component to query.
Plan to navigate to parsed action.

Are the query parameters included, or ignored?

The query parameters are ignored. We just end up doing a visit to /show if the action is /show?key=value on a form with method get.

If Turbo were removed or JavaScript were disabled, does the browser include or omit the ?key=value from the next page's URL?

It's included. And it used to be with Turbo as well. I found this as a regression in a system test that verified that this used to work.

it used to be with Turbo as well

I can confirm this. The motivation behind #461, #464, and #466 (this PR) was to make Turbo's <form method="get"> behavior align with built-in browser behavior.
In an environment without Turbo, the encoded values are ignored. Consider this code sample:

    <form action="/destination.html">
      <button>form[action="destination.html"]</button>
    </form>
    <form action="/destination.html?from=index">
      <button>form[action="destination.html?from=index"]</button>
    </form>
    <form action="/destination.html?from=index">
      <button name="foo" value="bar">form[action="destination.html?from=index"] button[name="foo"][value="bar"]</button>
    </form>
    <form action="/destination.html">
      <input type="hidden" name="foo" value="bar">
      <button>form[action="destination.html"] input[type="hidden"][name="foo"][value="bar"]</button>
    </form>

    <form action="/index.html">
      <button>form[action="index.html"]</button>
    </form>
    <form action="/index.html?from=destination">
      <button>form[action="index.html?from=destination"]</button>
    </form>
    <form action="/index.html?from=destination">
      <button name="foo" value="bar">form[action="index.html?from=destination"] button[name="foo"][value="bar"]</button>
    </form>
    <form action="/index.html">
      <input type="hidden" name="foo" value="bar">
      <button>form[action="index.html"] input[type="hidden"][name="foo"][value="bar"]</button>
    </form>

When navigating the <form> elements that encode values into their [action] as query strings, those values are omitted from the next page's URL.
From what I'm experiencing, values are only included in the next page's URL when encoded onto the submitter as [name] and [value] pairs, or encoded as an <input type="hidden" name="..." value="..."> element.
You can experiment with the sandbox by visiting https://fuschia-abyssinian-planarian.glitch.me.
Is that a proper recreation of your circumstances?

Oh wow. Yeah, you're right. This was just a quirk of Turbo's. I guess it's a bit of regression on the Turbo side of things, but agree that it seems reasonable to match the native HTML experience. Thanks for the very thorough illumination ✌. All good letting things stay as they are.


This approach is good for code sharing, but it also complects the two features:

We have to be extra careful about changes we make to experimental types, because it could affect the current init types.
Type changes on strong init will affect normal init: For example, CardinalityInference has seeped through all our classes, even though the normal init does not have to deal with this at all.
Strong init is affected by normal init: For example, we need to handle the case where RoomSchema comes in a different position for arguments.

I went ahead and split the codepaths: init creates InstantReact, InstantCore, etc, while init_experimental creates InstantReactExperimental, etc
This will let us be a lot more bold with changes to strong_init, knowing we won't affect the current flow.
Once we land this, I am going to fast follow to:
a. Remove strong-init bits in the normal init flow
b. Remove the normal-init bits in the strong-init flow
Change 2: Remove strong-init parts from normal-init

Removes WithCardinalityInference from normal init flows
Removes InstantGraph checks in normal init flows

Change 3: cardinalityInference by default for strong-init

Updated strong-init so we do cardinalityInference by default

Change 4: Schema <- RoomSchema for strong init classes

We used to extract RoomSchema, but this was only due to backwards compatibility with normal init classes. Updated our strong init classes to just care about Schema

(Taking a different approach...will push up a different PR!)


Label PRs with gradle and groovy paths "platform-android"

Add gradle/ and .groovy (and anything else helpful) to the labeler:
https://github.com/flutter/flutter/blob/4b818b56c2607ed0f952db48613e0704b77a238f/.github/labeler.yml#L135-L139
Example of PR not being labeled: https://github.com/flutter/flutter/pull/158020

cc @reidbaker

packages/flutter_tools/lib/src/android would make sense as well.


improve GitHub icon

use font icon instead of image (scale w/o loss of quality)
make it the last icon (visually better imo)

Nice, thanks!


Cannot get fontawesome icons to work

Most icons don't show, and some show up as weird curly characters. I've tried to add a FontAwesome5Free line to my style, and I've played around with workspace names in my sway config + waybar config but I cannot get it to work. I've also re-installed fontawesome, but to no avail.

Did you install otf-font-awesome? the others seem to be bugging...

I installed otf-font-awesome, removed ttf-font-awesome, rebooted and also adjusted style.css, but it appears not to work. Are there any diagnostic commands I can run?

BTW, I'm not sure if it's reading my config correctly, since it still gives me a message Disabling module "battery#bat2, No battery named BAT2 even though I omit the module from my config.

For me it works with just in style.css font-family style: Roboto, Helvetica, Arial, sans-serif; and otf-font-awesome

With the latest update at least I'm certain it's loading my config (since when I launch it from terminal it tells me so, and it updates). I've managed to get some custom-module action going, but the fonts still don't work. They do work back home on my desktop, so I'll try to see if I can find what I've done differently there.
I guess this slightly relates to #107. Maybe the AUR package can list otf-font-awesome as an opt-depend?

Added otf-font-awesome as a optdepend in the PKGBUILD

Just adding a comment since I ran into this as well. This was due to the font I was using. Certain Fonts override the font awesome fonts. To check if yours is one of those go to nerd fonts and see if there is a patched version for you. The font I used DejaVu Sans Mono needed to use a patched version for icons to show.
https://github.com/ryanoasis/nerd-fonts

Even with otf-font-awesome installed, I only get some of the icons. In particular the volume icons don't work. If I change the font family to "Font Awesome 5 Free" they work, but that seems less than desirable.

I had the very same problem and the way I fixed it is to append Font Awesome 5 Free to the font-family in the style.css, like so:
font-family: Ubuntu, "Font Awesome 5 Free";

For the people like me using fedora, it seems that the font provided by the offical repos is incomplete. I had to download and manually install FontAwsome from the official website, and then append "Font Awesome 5 Free" in style.css, as initially proposed by tukusejssirs.

@Scafir, I did it the same way as you did (also use Fedora), however, I can presumahly all icons, incl charging, volume and weather icons.

@Scafir, I did it the same way as you did (also use Fedora), however, I can presumahly all icons, incl charging, volume and weather icons.

@tukusejssirs Problem solved, it was because of a conflict between sans serif (in the default config) and fontawesome. I should have suspected it but this is definitely finicky.


🍔✨ Hamburger animation

What ❓
Showing an indicator on the menu icon when a user has unread messages.
How to QA? 🤔

Verify the unadorned menu icon is shown when logged out.
Verify the unadorned menu icon is shown when logged in and there are no unread messages.
Verify the adorned menu icon is shown and animates when logged in and there are unread messages.

Story 📖
Trello Story
See 👀

 Hamburger Animaton when new activity/messages


Next_Larger_Element-tree_using_CPP

💥 Proposal
Given a generic tree and an integer n. Find and return the node with the next larger element in the tree i.e. find a node with a value just greater than n.
Note: Return NULL if no node is present with a value greater than n.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


In the case of weak networks, anomalies may occur, leading to flip-flop

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Turn on speech recognition.
2.Stop Speech Recognition
3.Wait for some time, no stop callback, and then an exception occurs.

Expected behavior
It is hoped that when speech recognition is stopped, callbacks for stop recognition can be triggered quickly.
Version of the Cognitive Services Speech SDK
'com.microsoft.cognitiveservices.speech:client-sdk:1.2.0'
Platform, Operating System, and Programming Language
Android  ARM   JAVA
Additional context
E/AndroidRuntime: FATAL EXCEPTION: FinalizerWatchdogDaemon
Process: com.transn.onemini, PID: 25828
java.util.concurrent.TimeoutException: com.microsoft.cognitiveservices.speech.internal.TranslationRecognizer.finalize() timed out after 20 seconds
at com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.delete_Recognizer(Native Method)
at com.microsoft.cognitiveservices.speech.internal.Recognizer.delete(Recognizer.java:32)
at com.microsoft.cognitiveservices.speech.internal.TranslationRecognizerBase.delete(TranslationRecognizerBase.java:37)
at com.microsoft.cognitiveservices.speech.internal.TranslationRecognizer.delete(TranslationRecognizer.java:37)
at com.microsoft.cognitiveservices.speech.internal.TranslationRecognizer.finalize(TranslationRecognizer.java:26)
at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:239)
at java.lang.Daemons$FinalizerDaemon.run(Daemons.java:226)
at java.lang.Thread.run(Thread.java:761)

你怎么停止认可？你只是破坏识别器，或者......？
在标题中你提到'弱网络'，你是否通过有线连接实现了不同的行为？
THX
沃尔夫冈

I use  recognizer.stopContinuousRecognitionAsync()         to stop


Open in Separate Window

I'd like the ability to have the Excel Labs interface pop-out into a separate movable window (controllable with Windows shortcuts) to be displayed on a secondary monitor. Is this something that can be added?

You can manually drag the task pane outside of the main Excel window. I usually resize it to the full size of my portrait secondary monitor. However, a there are a few usability shortcomings:

You have to drag the Window very slowly. If the mouse "outruns" the Window, it ceases the drag operation. (This seems like an issue from before Windows 3.1!! Incredible that something like this can still happen)
The position is not remembered. If you close the task pane and reopen it, it will do so inside the main Excel window. Combine this with nr. 1 above, and it becomes annoying.
You cannot use the Win+arrows shortcuts to position the task pane.

I agree that the windowing could be much improved, but it is probably outside the possibilities of the AFE team. That's likely an Office-level fix.


Skweak for text classification

Do you have any examples on how to apply skweak for text classification? All the examples I see are for NER.
Thank you.

Hi, @plison I have a quick question,
To find the sentiment of sentences we many many libraries from markets like TextBlob, NLTK, Transformers, Flair...etc.
so when we don't have labeled data to train the sentiment analysis model we can get the labels from those libraries. and then we can train our model.
and how can I get labels to my domain data?
for ex: I have text like "my printer is not working" and I want to label it as "Hardware problem".
How can I achieve this with Skweak? Is there any demo code for that kind of labeling?

Well, to label your data with domain-specific labels (such as HardwareProblem), you can either write some heuristic rules (such as a rule stating that, if the word "printer" occurs in the sentence, it is likely to be a hardware problem), or have crowdsourcing annotators label those by hand. If you have several of those heuristics / annotators applied to the same texts, you can then use skweak to aggregate their predictions and get a single annotation layer that merges all of them together. Then, the only remaining step is to learn a classical neural classification model (like a language model with a text classification head) based on those aggregated annotations.

Thank you much for the answer Lison.
it means that if my I data is domain-specific then I label some labels
manually and create an ML model and use that model in skwaek to label other
samples. if I am not willing to go with heuristic?
how can I get results like Donald trump-person, $700-money like this for
the example given for ner
On Thu, Jan 6, 2022 at 10:53 PM Pierre Lison @.***>
wrote:

Well, to label your data with domain-specific labels (such as
HardwareProblem), you can either write some heuristic rules (such as a rule
stating that, if the word "printer" occurs in the sentence, it is likely to
be a hardware problem), or have crowdsourcing annotators label those by
hand. If you have several of those heuristics / annotators applied to the
same texts, you can then use skweak to aggregate their predictions and get
a single annotation layer that merges all of them together. Then, the only
remaining step is to learn a classical neural classification model (like a
language model with a text classification head) based on those aggregated
annotations.
—
Reply to this email directly, view it on GitHub
https://github.com/NorskRegnesentral/skweak/issues/22#issuecomment-1006766793,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJHYKN4OUNP7F7UV4EGXUCTUUXFYHANCNFSM5GJLTC6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


YAPF applies custom column length wrong on the first save (and correct on the second one)

Environment data

VS Code version: 1.21.1
Python Extension version: 2018.1
OS and version: Microsoft Windows [Version 10.0.14393]
Python Version: 3.6.3
Relevant/affected Python packages and their versions: pep8 (1.7.1), yapf (0.20.2), pycodestyle (2.3.1)

Actual behavior
After saving a file YAPF first reformats it using default 80 characters column limit, but then after saving the same file for the second time (without any changes) the actually configured column limit is applied (120 in my case) and the file is reformatted again.
I have the following setup.cfg:
[pep8]
max-line-length = 120

[pycodestyle]
max-line-length = 120

[yapf]
based_on_style = pep8
column_limit = 120

.. and the following user settings:
    "python.linting.enabled": true,
    "python.linting.pylintEnabled": false,
    "python.linting.pep8Enabled": true,
    "python.linting.pep8Path": "pycodestyle",
    "python.formatting.provider": "yapf",
    "[python]": { "editor.formatOnSave": true },

Expected  behavior
Automatic formatting should by applied right first time.
Steps to reproduce:

Configure VS Code as per above snippets.
Create a file test.py with the following contents:

def foo():
    foo = ['f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ']
    return foo

Save it once, save it twice.

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
none

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
none

Screenshot

Note:  If I inject the column limit directly into YAPF command line like this (goes into user settings):
    "python.formatting.yapfArgs": ["--style={ based_on_style: pep8, column_limit: 120 }"],

.. then I get the correct behavior.

This is duplicate of #730

Agreed, closing as a duplicate


Investigate devfile flattening + devworkspace startup workflow

Investigate devfile flattening + devworkspace startup workflow.
During preparing a proposal, it's needed to take into account
Plugins in Devfile 2.0 https://docs.google.com/presentation/d/17qAUiTY752INugy3iajb8ujku8eJXWmOnPF1SaTBxMA/edit#slide=id.g7862af9181_0_0
Investigating faster workspace startup https://github.com/devfile/devworkspace-operator/issues/209
Git Clone First https://github.com/devfile/devworkspace-operator/issues/205

This one can probably be closed in favor of other issues we've created since. Flattening is more-or-less implemented as of https://github.com/devfile/devworkspace-operator/pull/269


Delete all releases regardless of failures

helm delete was aborting as soon as the attempt to delete a release caused an error. This changes the command to continue attempting to delete each provided release even if a previous release failed to be deleted, while still returning an error for failed deletions.
Closes #1665

Bump -- @viglesiasce / @technosophos  -- any issues with this one?

This PR's been sitting in the queue for a while with no follow up. Should we go ahead and merge this, or do we need to sit down and review at the next dev meeting?

ping @technosophos


DBZ-7130 ConvertCloudEventToSaveableForm can work with cloud events deserialized from JSON

https://issues.redhat.com/browse/DBZ-7130

The SerDe is out of context of Debezium and all other Kafka connector. all Connectors works with SinkRecord and SourceRecord internally. connectors uses Converter to convert  other type of messages such as Avro, Json, etc.

@rkudryashov I agree with @blcksrx about the SerDe remark. Could the configuration option be renamed to https://debezium.io/documentation/reference/2.4/integrations/cloudevents.html#cloud-events-converter-data-serializer-type to amke it symmetric with the converter config?

I know wonder if the code here and in the core could be refactored a bit more. I envision a class in the core repo that will be responsible both for serialization and deserialization. The converter will use the serialization side and the SMT deserialization.
It would end up with the logic cantralized and also could lead to easier unit testing if only serialization testing would be needed.

@jpechane
renamed the config property to serializer.type because it specifies how a whole CloudEvent is deserialized, not only the data field

The converter will use the serialization side and the SMT deserialization.

Is the idea to make the sink (JDBC or other) connector config looks like:
  "config": {
    "connector.class": "io.debezium.connector.jdbc.JdbcSinkConnector",
   ...
    "value.converter": "io.debezium.converters.CloudEventsConverter",
    "value.converter.serializer.type": "avro",
    "value.converter.data.serializer.type": "avro",
    "value.converter.avro.apicurio.registry.url": "http://schema-registry:8080",
    "value.converter.fields.mapping": "id,source,type,data:payload"
  }

where new optional property value.converter.fields.mapping specifies the conversion if needed and will delegate the conversion to the SMT? If so, it looks like the SMT will be moved to the core repo

@rkudryashov Let's keep the solution as is right now. We can always reconsider it in future.
The PR LGTM, I left one comment related to JSON assertions. Wen addressed we can merge the PR. Thanks

@rkudryashov OK, applied, thanks!


[BEAM-13498, BEAM-13522] Sickbay broken test and test category for Spark PVR tests

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java Spark PortableValidatesRunner Batch

Run Java Spark PortableValidatesRunner Batch

R: @ibzib @pabloem
Will merge sickbay on passing PVR postcommit to restore green test signal.

R: @ibzib @pabloem
Will merge sickbay on passing PVR postcommit to restore green test signal.


if more than 1 filter is being used when calling releases/assessment-types, a java exception is returned

At one point, fod-uploader contacts FoD to find out which assessment types are valid for the ReleaseID.  If there are parameters on the commandline of fod-uploader that would result in that API call to have more than 1 filter, the call will fail and Java uploader will report a very generic Java exception.  In the API Logs however a very specific error is shown indicating  "Input String was not in a correct format" regarding the following API call
http://hpfod.com/api/v3/releases/123750/assessment-types?scanType=1&filters=frequencyTypeId:2+isBundledAssessment:true
It appears the url is not getting encoded when it is sent to FoD's API which is a requirement.

https://github.com/HPFOD/fod-uploader-java/releases/tag/v3.0.1


azure driver question  - Docker Machine 0.5

I noticed that a vm and a cloud service, storage account, and directory were provisioned. I only want a vm, I don't need the cloud service. Is there a way to do this?

I wonder why azure can't be like digital ocean. I want to create a vm with an image that has docker pre installed. I want to be able to control the azure instance type - and i want to see the estimated pricing per hour,day,month for that instance. I don't need cloud services, I don't need a storage account - the vm I have will do just fine. I also want to have my ssh key copied, and I want to be able to destroy the vm on a whim.
In the current situation I'm billed for the cloud service, vm, and storage account, yea?

@hsingh23 Go ahead and use CoreOS or Ubuntu images, or any one of the other images that have docker preinstalled. Pricing for Cloud Services are located here.  Everyone gives you one of these, but people don't call it a "thing". I'm not clear why there's no entry for your ssh key; that's a strange thing to overlook in the driver. You can destroy the VM whenever you wish, it's a VM. You could also stop it and restart it again when you wish. It's a VM.
You are paying for the compute time down to the minute, egress, and VM storage footprint, and that's it. The last two are extremely small, depending upon what you're downloading. The rule of thumb is that you're always mostly paying for compute. Hope that helps.
I do not understand what this has to do with docker-machine, however.... What am I missing?

@hsingh23 Hello, to answer your question, cloud service only provides a DNS name for your VM (*.cloudapp.net) and you can place multiple VMs behind that (something you can't do on DigitalOcean). Also cloud services allow you to define specific firewall and load balancing rules. You're not charged for a cloud service, it's free.
The storage account however is used to store your operating system disk. You pay by the GB space you are using. When you delete the VM, the OS disk of the VM will be deleted as well and you will not be paying for it anymore. Also, an empty storage account is free as well.
I hope this answers your questions. We're in process of creating a new Azure driver for docker-machine, it will have a lot more resources (IP addresses, NICs, virtual networks, storage accounts, availability sets, networks security groups, virtual machines, ...) and I just want you to know that we' will be doing our best to clean up billable resources after your docker-machine is deleted.

Closing since, I believe @ahmetalpbalkan answer the question.
Please re-open, if this is not the case.


WaitForARMFeedback: GalleryApplication API

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-ruby

Can one of the admins verify this patch?

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Re: lintdiff failures:
The new API for application gallery does not implement PATCH so this new errors are expected.
The existing API for Gallery Image remains the same (body and parameters) although some base definitions are refactored to be used by Gallery Application.

@AutorestCI regenerate azure-sdk-for-go

@koralski - please set up a call to go over the review. I sent you an email about it. Thanks!

Signing off from ARM side.


chore: update GH Actions runner to use Ubuntu 22.04

What kind of change does this PR introduce?

https://github.com/actions/runner-images/issues/6002

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.311%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5089

Relevant Lines:
5931

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.311%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5089

Relevant Lines:
5931

💛  - Coveralls


[WIP]BIGTOP-3760. Bump Hadoop to 3.3.4.

https://issues.apache.org/jira/browse/BIGTOP-3760
Hadoop 3.3.4 RC0 is under vote.
https://lists.apache.org/thread/r41ftyrs4b6g67sf8nz8xypfwohov7qb

smoke-tests of hdfs,yarn,mapreduce passed on Rocky Linux 8 x86_64:
$ ./docker-hadoop.sh \
     --create 3 \
     --image bigtop/puppet:trunk-rockylinux-8 \
     --memory 8g \
     --repo file:///bigtop-home/output \
     --disable-gpg-check \
     --stack hdfs,yarn,mapreduce \
     --smoke-tests hdfs,yarn,mapreduce
...
BUILD SUCCESSFUL in 13m 14s
41 actionable tasks: 14 executed, 27 up-to-date

Building HBase 2.4.12 against Hadoop 3.3.4 failed. The cause seems to be added dependencies. Fixing exclusion rule in HBase side might be the fix.
[ERROR] Found artifact with unexpected contents: '/home/rocky/srcs/bigtop/build/hbase/rpm/BUILD/hbase-2.4.12/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-2.4.12.jar'
    Please check the following and either correct the build or update
    the allowed list with reasoning.

    okhttp3/
    okhttp3/Request$Builder.class
    ...
    kotlin/
    kotlin/collections/
    kotlin/collections/ArraysUtilJVM.class
    ...

Building Hive 3.1.3 and Spark 3.2.1 against Hadoop 3.3.4 worked. smoke-tests passed.
$ ./docker-hadoop.sh \
     --create 3 \
     --image bigtop/puppet:trunk-rockylinux-8 \
     --memory 8g \
     --repo file:///bigtop-home/output \
     --disable-gpg-check \
     --stack hdfs,yarn,mapreduce,hive,spark \
     --smoke-tests hive,spark
...
Now testing...
:bigtop-tests:smoke-tests:spark:test (Thread[Execution worker for ':' Thread 7,5,main]) completed. Took 1 mins 11.596 secs.

BUILD SUCCESSFUL in 2m 0s
36 actionable tasks: 11 executed, 25 up-to-date
Stopped 1 worker daemon(s).

Building HBase succeded with added patch1-relocate-okhttp.diff. smoke-tests passed.
$ ./docker-hadoop.sh \
     --create 3 \
     --image bigtop/puppet:trunk-rockylinux-8 \
     --memory 8g \
     --repo file:///bigtop-home/output \
     --disable-gpg-check \
     --stack hdfs,yarn,mapreduce,hbase \
     --smoke-tests hbase
...
ow testing...
:bigtop-tests:smoke-tests:hbase:test (Thread[Execution worker for ':' Thread 3,5,main]) completed. Took 3 mins 50.955 secs.

BUILD SUCCESSFUL in 5m 10s
36 actionable tasks: 10 executed, 26 up-to-date

@iwasakims thanks for working on this. any chance test this sqoop and Tez also..? and RC-0 will be re-place once the release is announced ..?

We can not build Tez until #963 is merged. I'm not willing to test all downstream products in this PR. Please test it after merging this PR then file a JIRA if you find issues. The download URL will be updated after 3.3.4 release then [WIP] will be removed from the title. @brahmareddybattula

We can not build Tez until #963 is merged. I'm not willing to test all downstream products in this PR. Please test it after merging this PR then file a JIRA if you find issues.
I assumed all the downstream will be verified when we introduced the major version.  Since sqoop and tez is not mentioned I asked. Saw the TEZ #963 which is blocking. Once TEZ PR merged, will check.. thanks.
The download URL will be updated after 3.3.4 release then [WIP] will be removed from the title. @brahmareddybattula
ok, thanks.

Let me test it on AArch64, thanks for working on it.

Building HBase succeded with added patch1-relocate-okhttp.diff. smoke-tests passed.
$ ./docker-hadoop.sh \
     --create 3 \
     --image bigtop/puppet:trunk-rockylinux-8 \
     --memory 8g \
     --repo file:///bigtop-home/output \
     --disable-gpg-check \
     --stack hdfs,yarn,mapreduce,hbase \
     --smoke-tests hbase
...
ow testing...
:bigtop-tests:smoke-tests:hbase:test (Thread[Execution worker for ':' Thread 3,5,main]) completed. Took 3 mins 50.955 secs.

BUILD SUCCESSFUL in 5m 10s
36 actionable tasks: 10 executed, 26 up-to-date

Tested it on aarch64 Rocky Linux8 :
HBase: 2.4.13
[root@2862226bc183 /]# hbase version
OpenJDK 64-Bit Server VM warning: Using incremental CMS is deprecated and will likely be removed in a future release
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/usr/lib/hadoop/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]
HBase 2.4.13

Hadoop: 3.3.4:
[root@2862226bc183 /]# hadoop version
Hadoop 3.3.4
Source code repository https://github.com/apache/bigtop.git -r 22a0813b12f244bb9ba3df05532505dd7fed73e7
Compiled by root on 2022-07-25T06:29Z
Compiled with protoc 3.7.1
From source with checksum fb9dd8918a7b8a5b430d61af858f6ec
This command was run using /usr/lib/hadoop/hadoop-common-3.3.4.jar

Gradle Test Executor 5 finished executing tests.

> Task :bigtop-tests:smoke-tests:hbase:test
Finished generating test XML results (0.039 secs) into: /bigtop-home/bigtop-tests/smoke-tests/hbase/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.052 secs) into: /bigtop-home/bigtop-tests/smoke-tests/hbase/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:hbase:test (Thread[Execution worker for ':' Thread 72,5,main]) completed. Took 7 mins 47.886 secs.

BUILD SUCCESSFUL in 32m 21s

what about to remove patch1-relocate-okhttp.diff patched for HBase 2.4.12?

what about to remove patch1-relocate-okhttp.diff which was just only for HBase 2.4.12?

I updated the patch1 based on HBase 2.4.13. We still need the fix for HBase 2.4.13. @guyuqi

It failed to build Hbase (on Rocklinux and Debian 11)  for x86_64/aarch64.
..........
...
[INFO] Apache HBase - Common .............................. FAILURE [ 40.535 s]
..........
....
[ERROR] Failed to execute goal on project hbase-common: Could not resolve dependencies for project org.apache.hbase:hbase-common:jar:2.4.13: Could not find artifact org.apache.hadoop:hadoop-common:jar:3.3.4 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

[ERROR] Failed to execute goal on project hbase-common: Could not resolve dependencies for project org.apache.hbase:hbase-common:jar:2.4.13: Could not find artifact org.apache.hadoop:hadoop-common:jar:3.3.4 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

You need to build Hadoop first (by ./gradlew hadoop-pkg) to install artifacts of Hadoop 3.3.4 to local repository. It is not found in public Maven repositories since it is not released yet.

On the other hand I successfully tested smoke tests of Hadoop-3.3.4 and Hbase 2.4.13 without patch1-relocate-okhttp.diff.

The patch is for building HBase against Hadoop 3.3.4. I guess you used HBase 2.4.13 already built against Hadoop 3.3.3 here.

[ERROR] Failed to execute goal on project hbase-common: Could not resolve dependencies for project org.apache.hbase:hbase-common:jar:2.4.13: Could not find artifact org.apache.hadoop:hadoop-common:jar:3.3.4 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

You need to build Hadoop first (by ./gradlew hadoop-pkg) to install artifacts of Hadoop 3.3.4 to local repository. It is not found in public Maven repositories since it is not released yet.

ok,  let me try to build Hadoop-3.3.4 and Hbase-2.4.13 in the single docker container.
docker run --rm -v pwd:/ws --workdir /ws bigtop/slaves:trunk-rockylinux-8 bash -c '. /etc/profile.d/bigtop.sh; ./gradlew hadoop-clean hbase-clean hadoop-pkg hbase-pkg'

+1.
Tested smoke tests of Spark and HBase with Hadoop-3.3.4 on Rocklinux8 and Debian-11 for both x86 and Arm64.
Hive smoke tests were also passed on x86_64 but it failed to build Hive on Arm64. I'd like to fix it tracked by BIGTOP-3763.

https://lists.apache.org/thread/y2779v6bw88q9lt25pqfc7fhlf4pz95k

Packaging and smoke-tests of Hadoop, HBase, Hive and Spark passed as expected on RC1.

+1
Verified Spark, hive, hbase, Zeppelin smoke tests against on this Hadoop-3.3.4-RC1 on Arm64/x86_64 rockylinux-8 and Debian-11.

@guyuqi We need to update download_path and site to make it point to released artifact. (It is the reason why the title is prefixed with [WIP] now..)
I will add addendum commit for this. The vote passed. The artifacts will be published soon.

@guyuqi No one is willing to cut another RC before new issue is found on ongoing vote. There is no veto now.

I'm sorry I misunderstand about "There is no vote now" and I don't konw when the stable version 3.3.4 would release.
As you mentioned that the 3.3.4 vote was recently passed,  please add the addendum commit after the 3.3.4 published, thanks.

17fc6eaa9a33241b4d3a7e917b110201d54a8931 is the addendum commit.


[Help] how to use electron-forge build app

how to use electron-forge in this tool build app

[ ] TODO
https://electron-vite.github.io/build/electron-forge.html

why not this template use electron-forge?

Just because electron-builder only focused on packaging Electron App.
There maybe plans for electron-forge in the future. I am working hard to make forge more friendly and support Vite.


create confirmation directive for cms admin

exchange inline confirmation in filemanager to new confirmation "window"
exchange import "reload" alert to confirmation window

create angular directive. directive template can be stored in admin/views/layout/main.php


Support version on waitForServices

If a service has version waitForServices() function was not able to find the service because the version is undefined when passed to registry.hasService()
it checks if the version can be extracted from the service names with format
v1.accounts
v2.users

Coverage decreased (-0.04%) to 98.541% when pulling 81de8c6abb96e2d52f4284819a0e0b6039795aa4 on imatefx:develop into 0eadc110a24b86ca80195274ac1d4ec4f36b7b2d on ice-services:master.

Thanks, but current solution works only with numeric version.
We should support all options, e.g.:

v3.users
staging.users
v2.order.saga
...etc

Would be better to set an object if you want to define version.
Normal current format
waitForServices("users");
waitForServices(["posts", "users"]);

New optional versioned format
waitForServices({ name: "users", version: "staging" });
waitForServices([{ name: "order.saga", version: 2 }, {name: "users", version: "staging"]);

Both format should be supported.
Could you change it? If not, I will do it later.

ok, i will change it

Coverage increased (+0.0006%) to 98.585% when pulling 17db54f45a70b5b671ce7a3fb75cb2be764f59d0 on imatefx:develop into 0eadc110a24b86ca80195274ac1d4ec4f36b7b2d on ice-services:master.

Coverage increased (+0.0006%) to 98.585% when pulling 17db54f45a70b5b671ce7a3fb75cb2be764f59d0 on imatefx:develop into 0eadc110a24b86ca80195274ac1d4ec4f36b7b2d on ice-services:master.

Coverage increased (+0.0006%) to 98.585% when pulling 2da950c4b16b4a26c856d7618fa7f694e8949eca on imatefx:develop into 0eadc110a24b86ca80195274ac1d4ec4f36b7b2d on ice-services:master.

I saw your edit only few minutes back 😄 , Added tests

Nice job! Thank you! :+1:

😄  Thats my contribution to Open Source after a long time 👍

Released in v0.11.2


Optimize masked Pedersen hashes in POSW

To achieve better amortization resistance, we should optimize the masked Pedersen hash.
Currently we use two-bit lookups for both coordinates of each generator and normal Edwards addition.
Main idea for optimization - use the Montgomery form of the Edwards curve, which would require us to use powers of the same generator for as long as we can (~50-70 powers). The main point we must take care of is that the identity point can't be added when using this form.

Transferred the issue to snarkVM, as posw no longer resides in snarkOS.


Add additional configuration for addressing Redshift servers

You cannot properly define a Redshift output port using the current specification. For example:
example:
  type: redshift
  account: '123456789012'
  database: analytics
  schema: analytics

The fragment only identifies the account the cluster is in, it doesn't provide the cluster’s identity.
My change adds the additional properties clusterIdentifier, host, port and endpoint to allow for more options when addressing Redshift output ports.
I've also updated the README to add documentation, provide examples and corrected property descriptions.

@jochenchrist @simonharrer 👋 Hi, could you please take a look at this PR, when you get some time? I’d really appreciate feedback. Accurately addressing Redshift would be a great help to us.


update travis badge and new org addresses

some of #314 fixed but not appveyor; that part still needs fixing.

Thanks. I assume @rvagg can fix the AppVeyor settings if it requires logging in to the account or such.

I believe that's done on my end now, pointing to iojs/nan


Tuple type vs. array-of-union-type

Have I made a silly mistake here? I thought the tuple type [string, number] was roughly equivalent to the array-of-union-type (string | number)[], and that the following was therefore legal:
function lengths (xs: string[]): [string, number][] {
   return xs.map((x: string) => [x, x.length])
}

However tsc 1.4 complains:
Config.ts(127,11): error TS2322: Type '(string | number)[][]' is not assignable to type '[string, number][]'.      Type '(string | number)[]' is not assignable to type '[string, number]'.
    Property '0' is missing in type '(string | number)[]'.

I believe (and others on the team should feel free to correct me) that this has to do with the way in which contextual typing takes effect (i.e. it doesn't take effect on the return type of a call expression).
In other words, the return type doesn't impact your call's type, and so the language computes the type (string | number)[].
You can get the behavior you want by giving your lambda a return type.
function lengths(xs: string[]): [string, number][] {
    return xs.map((x): [string, number] => [x, x.length]);
}

Interesting, the compiler infers the type (string | number)[] for the expression [x, x.length], rather than [string, number] as you would want in this case.
With a little extra hint, it works ok:
function lengths (xs: string[]): [string, number][] {
   return xs.map((x: string): [string, number] => [x, x.length])
}

Ah, interesting. Thanks.
As an aside, I've become wary of adding types to lambdas: at least, adding parameter types seems to be broken (code which didn't type-check without the type annotation type-checks fine with the annotation, and then fails at runtime). I'll probably post an example at some point. It looks like the inferred type isn't being checked against the annotation.
But here you're talking about adding a return type. It's certainly an improvement on my current workaround (which involves any <any> cast), so thanks again.

Glad this helps, though, we'd definitely like to see an example where you run into the situation you mentioned if you can reproduce it.