Add IReadOnlyCollection support to Counting methods

This is related to #128.
/cc @atifaziz  @Arithmomaniac

Did you check whether any tests could be updated?

Yes. Tests were updated too.

I'm guessing the comment for 70cc3eb is wrong? It doesn't seem to have anything to do with PadStart.

Yes. I forgot to replace PadStart for CountingMethods. Sorry.

after the change to implementation then would the test break if I remove the changes.

The current implementations already were optimized for ICollections, but tests did not cover that. So what I did on tests, was to add this coverage as improviment. But you are right, now, tests should check against IReadOnlyCollections too, and therefore fails.
@atifaziz
I added a validation for IReadOnlyCollection on 5d2c03c, this is why tests were failing, as you expected.
After this I revert your revert on 4d5c9df, changing the implementation to be optimized for IReadOnlyCollection again.

@atifaziz I should have time later today.

Can you add non-collaborators as formal reviewers?

As far as I understand, anyone with read access can submit a review.

But you are right, now, tests should check against IReadOnlyCollections too, and therefore fails.
Now test should correctly pass.

Thanks for breaking then fixing! 👍

Optimize PadStart for read-only collections should had added converage for IReadOnlyCollection  too, no?

I agree.

I considered optiomize

Optimize PadStart for read-only collections should had added converage for IReadOnlyCollection too, no?

The tests were not explicitly optimized for ICollection either.
I considered adding the optimized tests for ICollection and IReadOnlyCollection, but unlike most optimized methods, the enumerator is still used in the Concat statement, so actually checking the full results using Breaking(ReadOnly)List like we usually do is not feasible.
What one could do, in retrospect, is check that PadStart can at least be called on a Breaking(ReadOnly)List; it would fail even without enumeration without optimization.

BreakingCollection should inherit from BreakingReadOnlyCollection.

Can you explain me why, please?
@Arithmomaniac other changes were done, thanks for review.

Can you explain me why, please?

You are correct; I added the suggestions I actually meant.

@Arithmomaniac

Now that we have BreakingReadOnlyCollection, BreakingReadOnlyList should inherit form it

Make sense now. Improved already done. Something more you would like to point in your review?

What one could do, in retrospect, is check that PadStart can at least be called on a Breaking(ReadOnly)List; it would fail even without enumeration without optimization.

we can add a Take(collectionCount) on source before apply Concat, So MoveNext will be called exactly collectionCount times, not collectionCount + 1 which is the case when it returns false.

I am on vacation with limited desktop access, but I'll get back to you when
I can.
Re PadStart, we should open a new bug.

Sent from my phone. Please excuse brevity and typos.
On Thu, Mar 29, 2018, 22:06 Leandro Fernandes<EMAIL_ADDRESS>wrote:

@Arithmomaniac https://github.com/Arithmomaniac
Now that we have BreakingReadOnlyCollection, BreakingReadOnlyList should
inherit form it
Make sense now. Improved already done. Something more you would like to
point in your review?
What one could do, in retrospect, is check that PadStart can at least be
called on a Breaking(ReadOnly)List; it would fail even without enumeration
without optimization.
we can add a Take(collectionCount) on sourcebefore apply Concat, So
MoveNextwill be called exactly collectionCount times, not collectionCount

1 which is the case when it returns false.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/morelinq/MoreLINQ/pull/424#issuecomment-377433136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAn-MQ73QjkQMQ14kCBZjAVfT0145Zl_ks5tjaFFgaJpZM4S8IM3
.

@atifaziz I liked the idea of ArrangeCollectionTestCases. I implemented that with foreach in
82116b0.

However, I'd also like to explore how this can be refactored into test case data.

Maybe this should be moved to a separate story, but the new(ish) ability to add parameters to TestCaseSource should do the same thing as ArrangeCollectionTestCases while making it possible for each test case to fail independently.

Maybe this should be moved to a separate issue

Except will it ever get done then once all is green? 😉

while making it possible for each test case to fail independently.

Aye, that's the goal here.

What do you think about revert the collection validation for all tests and Just create a new test that check It (the approach used by @Arithmomaniac in other PR)

@leandromoh Any chance you can resolve the conflicts? We should merge this soon(-ish).

@atifaziz I can do It today. But testing optmization in each test or in a separate one?

@atifaziz resolved conflicts done!
thanks for a3dbf2e , it clarify alot! But I was wondering if this may go to master here or on the refactoring PR.

We don't have to wait for “the new(ish) ability to add parameters to TestCaseSource"

Huh? It landed a while ago already.
That's not to the exclusion of the above being brilliant 😃 It's just that it may make a good alternative to code like https://github.com/morelinq/MoreLINQ/blob/8d4e87139888a916c6c9f499596a7460e23630e1/MoreLinq.Test/TakeLastTest.cs#L66-L73

It landed a while ago already.

Oh, I see. My bad. I read “which is about to be released” in the linked SO answer and didn't even bother checking that we're already on 3.6.1 when it was referring to 3.2.


Production Ready?

Is this library production ready or should the original mal be used instead? Which branch is best to be used? It looks like there's no ci builds etc for this.

I'm planning to merge the cpp11-dev branch as soon as I get everything to compile on Windows. It doesn't bring a lot of changes for C11 users, but for C++ it's better.
What's the intended usage? platforms, language, type of application, etc.

Looking to integrate logging on Linux with C++17 in an application with low
latency call site requirements but not particularly large throughput. I was
also looking at PlatformLab/NanoLog which looks very interesting. I had no
luck building your benchmark repo to compare though, it looks like it
references repos external to GitHub which is probably the cause of the
failures.
On Thu, 19 Dec 2019, 6:52 pm RafaGago<EMAIL_ADDRESS>wrote:

I'm planning to merge the cpp11-dev branch as soon as I get everything to
compile on Windows. It doesn't bring a lot of changes for C11 users, but
for C++ it's better.
What's the intended usage? platforms, language, type of application, etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RafaGago/mini-async-log-c/issues/2?email_source=notifications&email_token=AL5LS3GPMERSJXQVEECQEFTQZODDZA5CNFSM4J5FPUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHJ24OQ#issuecomment-567520826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL5LS3BGJRXG45RA7HXRR5DQZODDZANCNFSM4J5FPUNQ
.

The benchmark project is definitely referencing external projects, as some of the loggers benchmarked aren't hosted on GitHub.
On Linux you should be able to compile the benchmarks with.
mkdir build && cd build && cmake .. -DNANOLOG=on -DMALC=on && make -j
If this doesn't compile then it's broken and I'd like to know how to be able to fix it.
From the synthetic testing I have done on my obsolete AMD Phenon 965 x4 on Ubuntu Server 18.04 using the "performance" cpu governor with a peak of 100000 mesages, malc using thread local storage is 1,5-2x faster than nanolog on the single-threaded case, they get more or less equal with 8 threads, and after that nanolog wins, as it scales almost linearly with the number of threads, while malc degrades.
On this same test, when passing 8MB as a tls buffer size to malc (which is enough to handle the 100000 messages peak), malc peak memory consumption was 13MB . nanolog 32MB.
As the benchmark is just launching threads continuously logging in a loop, one has to interpret its significance when running in an application. I guess that a textual logger is almost always uncontended.
If you own the threads that are going to log, you can enable a buffer on thread local storage on malc. This makes logging wait-free as long as there is space on that thread local storage buffer. Then if you don't want to drop messages on a full buffer, as fallback you can use the heap, a shared bounded buffer or both. On nanolog there are cases that take mutexes or initialize data the first time a logging site is hit.
I'm completely biased, so it's hard for me to tell what you should be using. Consider that this is a textual logger and nanolog is binary.
For C++ usage under Linux I'd take the cpp11-dev branch, it's not going to change much more before it's merged to master.

I finally got around to try and testing this a bit more throughly.

cpp11-dev branch contains a bad submodule reference to base_library @ 6fe7d2f which doesn't exist
master branch has a compile error with Linux RHEL 7.4 and gcc 8.3.1, details below.

'
[120/121] Compiling C++ object 'subprojects/base_library/b3ec909<EMAIL_ADDRESS>FAILED: subprojects/base_library/b3ec909<EMAIL_ADDRESS>c++ -Isubprojects/base_library/b3ec909@@bl-nonblock-mpmc-bpm-relacy@exe -Isubprojects/base_library -I../subprojects/base_library -I../subprojects/base_library/include -I../subprojects/base_library/src -I../subprojects/base_library/test/src -I../subprojects/base_library/dep/install/include -I../subprojects/base_library/gitmodules/relacy -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -g -pthread -MD -MQ 'subprojects/base_library/b3ec909<EMAIL_ADDRESS>-MF 'subprojects/base_library/b3ec909<EMAIL_ADDRESS>-o 'subprojects/base_library/b3ec909<EMAIL_ADDRESS>-c ../subprojects/base_library/test/src/bl/mpmc_bpm_relacy/mpmc_bpm_relacy.cpp
In file included from /opt/rh/devtoolset-8/root/usr/include/c++/8/map:61,
             from ../subprojects/base_library/gitmodules/relacy/relacy/pch.hpp:48,

             from ../subprojects/base_library/gitmodules/relacy/relacy/base.hpp:16,

             from ../subprojects/base_library/gitmodules/relacy/relacy/relacy.hpp:17,

             from ../subprojects/base_library/test/src/bl/mpmc_bpm_relacy/mpmc_bpm_relacy.cpp:304:

/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/stl_map.h: In instantiation of ‘class std::map<void*, long unsigned int, std::less<void*>, rl::raw_allocator<std::pair<void*, long unsigned int> > >’:
../subprojects/base_library/gitmodules/relacy/relacy/memory.hpp:178:30:   required from here
/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/stl_map.h:122:21: error: static assertion failed: std::map must have the same value_type as its allocator
   static_assert(is_same<typename _Alloc::value_type, value_type>::value,

                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/stl_map.h: In instantiation of ‘class std::map<const void*, long unsigned int, std::less<const void*>, rl::raw_allocator<std::pair<const void*, long unsigned int> > >’:
../subprojects/base_library/gitmodules/relacy/relacy/context_addr_hash.hpp:55:45:   required from here
/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/stl_map.h:122:21: error: static assertion failed: std::map must have the same value_type as its allocator
In file included from ../subprojects/base_library/gitmodules/relacy/relacy/base.hpp:17,
             from ../subprojects/base_library/gitmodules/relacy/relacy/relacy.hpp:17,

             from ../subprojects/base_library/test/src/bl/mpmc_bpm_relacy/mpmc_bpm_relacy.cpp:304:

../subprojects/base_library/gitmodules/relacy/relacy/platform.hpp:247:30: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
define RL_THROW_SPEC(ex) throw(ex)
                          ^~~~~

../subprojects/base_library/gitmodules/relacy/relacy/context.hpp:1256:41: note: in expansion of macro ‘RL_THROW_SPEC’
inline void* operator new (size_t size) RL_THROW_SPEC(std::bad_alloc)
                                     ^~~~~~~~~~~~~

../subprojects/base_library/gitmodules/relacy/relacy/platform.hpp:247:30: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
define RL_THROW_SPEC(ex) throw(ex)
                          ^~~~~

../subprojects/base_library/gitmodules/relacy/relacy/context.hpp:1264:44: note: in expansion of macro ‘RL_THROW_SPEC’
inline void* operator new [] (size_t size) RL_THROW_SPEC(std::bad_alloc)'

I'm moving some things from malc to the submodule under pressure (family) and I got it wrong. I was tired. I will be fixing this soon.

I fixed the submodule.
It seems that the error is related to the relacy race detector. My source the only thing that does is to #include <relacy/relacy.hpp>
Unfortunately I can't reproduce.
The file failing is a test that I did for checking the correctness of a queue, it is totally unnecesary for malc, so it is safe to comment out the 'bl-nonblock-mpmc-bpm-relacy' executable on the "meson.build" file if you want to keep things going.
There is the "bare" meson option that I added that just compiles the libraries and skips all the tests. too.
If I remember correctly, I bumped "relacy" recently to see if I could get rid of those throw warnings.
I'm on gcc 7.4 myself.

That's great thanks, both branches compile and tests pass once the relacy executable is disabled.

7f27e6daf8ec9b5ae27b185fe2abf49775506c77 Fixes the relacy issue. I was going to submit a fix for relacy when I realized that it was already submitted upstream.

The C++11 branch is merged. Closing this.


(FACT-3034) Use require_relative

Updates facter to use require_relative instead of require to reduce the amount of file IO needed to load facter. See also https://github.com/puppetlabs/puppet/pull/8595
Note this doesn't compute the shortest relative path to the file-to-be-required. So if the relative path includes .. then we traverse to the top and back down. This produces longer paths, but I find it to be clearer, since we don't omit directories. I may be the only one that thinks that?
Note the  .. doesn't result in extra file IO, because ruby realpath's the file to be included. For example, once we find facter/a.rb then it uses openat passing the absolute path to b.rb:
stat("/home/josh/work/facter/lib/facter/a.rb", {st_mode=S_IFREG|0664, st_size=48, ...}) = 0
openat(AT_FDCWD, "/home/josh/work/facter/lib/facter/b.rb", O_RDONLY|O_NONBLOCK|O_CLOEXEC) = 7

Hmm this doesn't seem to affect facter in any significant way on redhat or windows.
Before
$ strace -fc -e trace=file bundle exec facter > /dev/null
% time     seconds  usecs/call     calls    errors syscall
------ ----------- ----------- --------- --------- ----------------
 72.74    0.103014           2     35577     28142 openat
 13.95    0.019760           1     11503      4089 stat
  7.94    0.011241           1      9741         5 lstat
  2.62    0.003704           2      1310       351 access
  1.51    0.002132           7       298       116 execve
  0.39    0.000551           2       235       116 readlink
  0.33    0.000474           2       167        50 faccessat
  0.24    0.000340           4        72           readlinkat
  0.14    0.000198           2        87         8 statfs
  0.11    0.000149           4        36        10 newfstatat
  0.02    0.000025           2        11        11 mkdir
  0.02    0.000024           2        10           chdir
  0.01    0.000017           1        13           getcwd
  0.00    0.000000           0         2           unlink
------ ----------- ----------- --------- --------- ----------------
100.00    0.141629                 59062     32898 total

After
$ strace -fc -e trace=file bundle exec facter > /dev/null
% time     seconds  usecs/call     calls    errors syscall
------ ----------- ----------- --------- --------- ----------------
 70.64    0.095940           2     35576     28142 openat
 13.65    0.018534           1     11503      4089 stat
 10.78    0.014641           1      9741         5 lstat
  2.16    0.002929           9       298       116 execve
  1.90    0.002583           1      1310       351 access
  0.24    0.000323           4        72           readlinkat
  0.22    0.000300           3        87         8 statfs
  0.19    0.000263           1       167        50 faccessat
  0.10    0.000140           0       235       116 readlink
  0.07    0.000101           2        36        10 newfstatat
  0.01    0.000020           1        11        11 mkdir
  0.01    0.000018           1        10           chdir
  0.01    0.000014           1        13           getcwd
  0.01    0.000010           5         2           unlink
------ ----------- ----------- --------- --------- ----------------
100.00    0.135816                 59061     32898 total

I think it's because facter predominately calls require with an absolute path based on the location of the file_loader already, eg
require '/home/josh/work/facter/lib/facter/framework/core/../../resolvers/linux/docker_uptime.rb'

I'm going to close this for now.


updates to dumpling python client

-fix issue with display name containing '.'
-allow displayname, user, and distro to be overriden from the command line

LGTM :shipit:


Session persistence

In nginx Plus, one can use Session Persistence for load balancing.
For some apps, their data/state (session data) is not really separated
(e.g. PHP Sessions without special backend, legacy apps).
In that case, requests for a session should always go to the same backend (route).
Also when fabio instances are also used as backends (nested upstream),
Session Draining would be helpful, too, for the same kind of apps.
As session detection can be very different, some kind of go callback offered by fabio
would allow the admin to tailor it, like passing in a dump of HTTP headers and
the go callback would return a session ID for fabio to decide.

 In general, they show that your application needs refactoring since it wasn't designed to run in an HA setup and you are trying to push this problem into the load balancer instead of solving it in the application. Is this an actual problem you have or a hypothetical? Can you explain your use case a bit better?
Session draining is automatic behavior in fabio. Once a route is removed fabio won't send new requests to that target. Existing connections remain active but do not time out. Again, this is an application problem. You need to have proper timeouts there. Generally, when a service is removed from consul you are shutting it down and handling graceful shutdown there. Fabio cannot know what an acceptable timeout is for each service. If the service is not coming down by itself then something will kill it. In either case the TCP connection is reset and fabio terminates that connection.

Thank you for your answer.
I got some old legacy PHP apps I want to put into containers and behind fabio, too.
And those are not sharing their Session data.
I guess it would make more sense refactoring them so they use a central session storage.
With best regards

If a single instance can handle the load then you can make sure that one and only one instance is running at any given time. Maybe try to acquire a consul or mysql lock during startup and if you can't then shutdown again.

So I close this now because this is an issue with the backend app, not with the HTTP(S/2) frontend
which shouldn't be used to fix this on a wholly different level.
With best regards

this is still a problem. The issue is old, but after two years not all the applications are stateless. If you have weblogic or jboss you share a session ID among the cluster. If you don't have a clever application server, and you can't change the code of your application, you need to ask your load-balancer to perform the task.
If it's not a mobile app, you have plenty of options. Linux LVS is perfectly suitable.
Otherwise, Nginx, HAProxy are probably your best friends.


SSL using legit (non-self signed) certificate.

I tried to create a server hosted on the same server as my website with https on it. (https://hollowbit.net/vedi0boy/). You can see https works, but when I try using it for websockets, it doesn't. Is there a way to do it or is it simply not implemented yet.
When using applications made with gwt (java converted to javascript) for example, it doesn't allow you to connect to self-signed certificate servers for security reasons. Also, it looks a lot more legit if I don't use them.
Thanks!

Hello @vedi0boy,
I should be able to provide an example for you to use a certificate (Let's encrypt) for the server.
Gonna add a documentation.
Greetings
marci4

Here is the code I used to generate a keystore from a regular certificate; and here is an example usage.
The code is pretty old, I ended up not using this project because the code was old and full of weird quircks. But the idea is there.

Hello @vedi0boy,
please check out my wiki post with some examples here.
Greetings
marci4

Awesome! I will try it when I get the chance. Does this only work with Let's Encrypt? I use it but I'm just curious for people using other CAs.

Hello @ve


Hard configuration doesn't provide me an admin password

After I entered my nsec the process ends and doesn't provide me an admin password.
When I run $ npm run nsecbunkerd start I get this:

bunker://mynpub

❌ Admin interface not starting because no admin npubs were provided
✅ Connected to wss://relay.snort.social
✅ Connected to wss://relay.nsecbunker.com
✅ Connected to wss://nostr.vulpem.com
✅ Connected to wss://relay.damus.io
✅ Connected to wss://nos.lol
✅ nsecBunker ready to serve requests.
📡 5 connected, 0 disconnected, 0 connecting```

How do I resolve it? @pablof7z

Same problem for me also.. I noticed that at this point -
npm run nsecbunkerd -- add --name <your-key-name>
I don't get the output
nsecBunker generated an admin password for you:

So think maybe it bugged out somewhere there

yeah, I think when I added the web admin stuff I destroyed the CLI admin stuff. Need to revisit this.

can confirm that the admin CLI not working for me either. I get that same message with the red x when I try to set it up to get into highlighter.com.

I had to manually add the admin npub to config/nsecbunker.json, even though I had already added it to the .env.
When I start up the CLI, I get:
Running migrations
❌ no adminNpubs were provided
But then:
✅ Connected to wss://relay.damus.io/
✅ nsecBunker Admin Interface ready
✅ Connected to wss://relay.nsecbunker.com/
🔑 Starting keys []
✅ nsecBunker ready to serve requests.

@jeremycady Does it work then, when you have added it? 🤔
You have added it in .env and other file.. would you mind to show us which fields did you fill? Thanks

My steps to, what appears to be, working CLI:
gh repo clone kind-0/nsecbunkerd
cd nsecbunkerd/
mkdir config
cp .env.example .env
nano .env
Update DATABASE_URL to correct "nsecbunkerd/prisma/nsecbunker.db"
Update ADMIN_NPUBS with npub
npm install
npm run build
npx prisma migrate deploy
npm run nsecbunkerd -- add --name
nano config/nsecbunker.json
Add npub to admin.npubs
npm run lfg --admin
This yields this error at first:
Running migrations
❌ no adminNpubs were provided
Gives me a connection string.
Provides a signing.
Then the following output:
✅ Connected to wss://relay.damus.io/
✅ Connected to wss://relay.nsecbunker.com/
🔑 Starting keys []
✅ nsecBunker ready to serve requests.
✅ nsecBunker Admin Interface ready
I can now log into app.nsecbunker.com and unlock my key, create a policy and a token.
I haven't been able to log into anything using this though.
For example, at coracle.social, when you but in the bunker URL to login, it will give me the following error in the console:
You are not designated to administrate this bunker
I get no feedback from Nostrudel.
I have noticed, in the CLI, every event has "sig: undefined". I'm not sure if that's in an issue or not.

I forgot to add, I do get a DM when the bunker starts that states:
nsecBunker has started; use<EMAIL_ADDRESS>to connect to it and unlock your key(s)

Also, I just downloaded and ran the UI locally.
I've logged into and posted at nostrudel.ninja


Dialogue Runtime

Handle a runtime value for Dialogue elements.

Commit:
https://github.com/cjcodeproj/medialibrary/commit/7505be9e35964556215fb1ec288fe2278cb9939b


🚀 Feature: External developer Portal : Backstage Threat Model

🔖 Feature description
We are using backstage from past 2 years, we were building internal developer portal. Now more than 10 teams are contributing toward backstage internal portal.
We are exploring external developer portal. It will be public.  It will open for external developers as well as a malicious actor outside our organization.
When we go through backstage trust model: It seems like, we should not build external portal on  backstage. it is not secure.
for example a malicious actor outside of the organization. The security model of Backstage currently assumes that this group does not have any direct access to Backstage
ref: https://backstage.io/docs/overview/threat-model/
🎤 Context
is there any future planning for backstage support external portal capabilities? or is there any other solution for this issue?
is backstage token is not secure if we using OIDC for azure/okta?
✌ Possible Implementation
There are few thing. will this help to secure backstage external portal.

separate frontend and backend server and backend doesn't expose to public.
we don't use backstage auth plugin and create our own. we are planning to use OIDC flow for okta/azure etc.

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Hi @lalit774, there recent auth changes in 1.24.x and 1.25.x are working towards a more "secure by default" setup for Backstage which should get it closer to being able to have it more public.
There's some details on the plans for this in the State of Backstage talk at KubeCon EU in Paris that took place last week: https://www.youtube.com/watch?v=jBf3g79xcf4

This also could be helpful: https://www.youtube.com/watch?v=qQcVHbXjU2Q


Feat relation arrays

Just added all the kitchen sink fields to the preview frontend. 😅 Want to check it out quickly @dkirchhof ?

Nice.


fix: use timeout specified in playwright options

We needed this in kibana tests where often timout can increae from 30 seconds, so changing value in each selector is annoying
fixes  https://github.com/elastic/synthetics/issues/662

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-28T08:31:35.758+0000

Duration: 14 min 14 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
204

Skipped
2

Total
206

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

IMO, this change could be confusing considering PlaywightOptions type is documenting a different effect, :
 /**
   * Maximum time in milliseconds to wait for the browser instance to start. Defaults to `30000` (30 seconds). Pass `0` to
   * disable timeout.
   */
  timeout?: number;

Can we adapt the type object to provide the correct description?

@vigneshshanmugam isn't it possible to do also global timeout for all selectors. Can you please tell me what would you like me to change for this pr. Instead of using playwrightOptions, adding a new cli param timeout will that be ok with you?

Yeah there can be different behavior's for timeout as stated here on the issue - https://github.com/elastic/synthetics/issues/561#issuecomment-1215610563, But if you want to have a monitor with a specified timeout, then go for --timeout option.
But if you are concerned around timeout for PW actions. We cannot do that properly instead users can already do that via
journey("test", ({context, browser}) => {
  context.setDefaultTimeout(10000);
})

Closing this for now to have more discussions around it


display seems to draw in the wrong direction

Hi i just tried the code example but it seems to draw the image in the wrong orientation, leaving a band of noise on the right hand of the display ( assuming the usb-c port is left ). i assume that it might be an easy fix some where however i'm not wel versed with display drawing code and lcd libs

There are different display types.
I use
display:
  - platform: ili9xxx
    model: ILI9342
    rotation: 90
    spi_id: lcd
    cs_pin: 15
    dc_pin: 2

I haven't managed to fix the touch yet.

In the closed issue list, there is a similar reporting.
The solution that Leif suggested was the solution to fix the issue for that one. Hope it helps you too.

thanks for the quick responses i hadn't thought of looking at the closed issues. il try the purposed solution after work.
on a side note i'v gotten the "schematic/connection diagram" and arduino IDE examples from the seller of my board if your interested.


Fix for method parsing in computed binding

Quantifier should be greedy, otherwise it fails to parse correctly such construction:
<span attr="[[computed('(', foo)]]">

Could you create a corresponding issue for this? It seems clear in the PR, but an issue will help the conversation.

Issue: #2506

@tjsavage any word on this one?

LGTM


Github CI action, fix pot destroy leftovers

Slightly improve CI script (e.g., detect IPv6 missing), add github CI action (triggers on push to the branch and should be able to be run manually once it lands in master). As running it is quite expensive, I wouldn't run it automatically at the moment. The idea is to have the CI workflow in github actions, so we can run it before cutting a release.
Pot destroy left directories behind on destroy (side-effect of the previous partially reverted commit, but could also happen in other ways, hence the explicit fix by removing those directores).

See here for an example run (on push for the special branch), I hope you can see it:
https://github.com/grembo/pot/actions/runs/3295824125/jobs/5434775436


Add missing cpp bling options

What changes does this PR introduce?
(Bug fix)
model src routines missing BLING_OPTIONS.h CPP option
What is the current behaviour?
Improper handling of EXF CO2, including writing of sensitivity to apco2
What is the new behaviour
fixes this issue
Does this PR introduce a breaking change?
This will not effect any testers as none define USE_EXFCO2 in BLING_OPTIONS
Other information:

LGTM

LGTM +1


Elements in if and else blocks visible at the same time

See this demo and click the button twice. Text nodes are removed immediately, but it seems that elements are waiting for the transition (which really has nothing to do with the if/else block) to complete.

Not able to reproduce with test html page but able to reproduce on jsFiddle only.

Fixed in edge 😃


London car rent

If the intent is to drive in London then I would strongly recommend not doing it. For one thing, you can expect to get hit with the car rental London on top of your rental cost for any traveling you plan to do within the city center.

But I wanted to see the big wheel! :(


conclusion on regression

I have some merge conflict so please look at the branch instead of the master.

[x] Complete fitting testing data into regression
[x] Add conclusion

[x] solve merge conflicts


[Draft][zeus] Add support for Foxy Fitzroy

This isn't ready yet, because at least 2 recipes from ros-image-world are failing:
meta-ros2-foxy/generated-recipes/urdfdom/urdfdom_2.3.2-1.bb:do_compile
meta-ros2-foxy/generated-recipes/cartographer-ros/cartographer-ros_1.0.9001-1.bb:do_compile

I don't know when I'll have time to finish this one or if foxy will be supported on zeus branch at all. Sharing this as a draft just in case someone would find it useful as starting point to support foxy on zeus or older Yocto release.

Merged and tagged as zeus/milestones/13 now when it's consistent with milestone 13 in other branches.


[Runtime][ROCm] Enable ROCm host memory support

This PR enables the ROCMHost memory support in ROCm device API.

@tvm-bot rerun

@tvm-bot rerun

@tvm-bot rerun


Feat/settle-up-fe

Created reusable CurrencyInput component, which could be used in AddBillModal and other places where entering amount in currency is needed.
Created SettleUpSlider which lets user to set the settle amount by either entering it manually or by dragging slider handle.
Created SettleUpSubPage which shows a list of SettleUpSlider's. For now it is filled with mock data, so in the future it has to call API to get required data.

Coverage decreased (-0.09%) to 6.392% when pulling 60b7ab14d3ff2f0cd64a7befccb231e6d669d67c on feat/settle-up-fe into 466681028d935c2c251c995f9ebb08eef0aea4bb on master.

 Task 12: UI for settling bills


No SDKs are showing up in the onboard dropdown box - management plane

I was testing with a product that is associated with previously released SDKs  in PPE.  Here is filtered link to Azure SDK release page - https://azure.github.io/azure-sdk/?search=workload.

Nothing shows up the dropdown box.  It is confusing.  We should provide a message to make it clearer as to what we want the user to do.  I am not sure if I am supposed to enter a URL or what I am supposed to do if nothing shows up in the dropdown box.
Why is nothing showing up in the dropdown box?  The ARM namespaces exist and there are management libraries that have been released.

https://github.com/Azure/azure-rest-api-specs-pr/pull/10974

The package list is available in PPE.

Duplicated with https://github.com/Azure/azure-sdk-tools/issues/5508#issuecomment-1439358878


couple of changes to ebuild

using P and PN and PV (Package-x.y, Package, x.y)
moving the tarball to simple-power-manager-PV.tar.gz

Thanks palica!


PR: Better split test suite between slow and fast slots in CIs and other improvements for CIs

Description of Changes

Remove slow Pytest marker and instead mark all main window tests, and a percentage of the IPython console ones on Linux and Mac, as slow in CIs (locally there won't be any distinction between slow and fast tests).
This will make our slow slots finish faster compared to the fast ones (the first ones are taking two times more than the later).
This also allow us to adjust the amount of tests marked as slow/fast per operating system.

Use micromamba to create our test environment on CIs. This significantly reduces the necessary time to do that.

Remove script and code in our workflows that manually checked for [ci skip] in commit messages. That functionality is provided natively now by Github actions.

Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Pinging @juliangilbey about this one because you could interested on this change.


Getting error after launching the kafka-ui

I'm trying to setup the kafka-ui for my project. After launching the kafka-ui getting below error. I need to authenticate kafka cluster through kafka SASl.
500 Internal Server Error
Error while creating AdminClient for Cluster test-kafka
java.lang.IllegalStateException: Error while creating AdminClient for Cluster test-kafka
at com.provectus.kafka.ui.service.AdminClientServiceImpl.lambda$createAdminClient$3(AdminClientServiceImpl.java:45)
at reactor.core.publisher.Mono.lambda$onErrorMap$31(Mono.java:3733)
at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:94)
at reactor.core.publisher.Operators.error(Operators.java:198)
at reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:135)
at reactor.core.publisher.MonoFlatMap.subscribeOrReturn(MonoFlatMap.java:53)
at reactor.core.publisher.Mono.subscribe(Mono.java:4385)
at reactor.core.publisher.FluxSwitchIfEmpty$SwitchIfEmptySubscriber.onComplete(FluxSwitchIfEmpty.java:82)
at reactor.core.publisher.Operators.complete(Operators.java:137)
at reactor.core.publisher.MonoEmpty.subscribe(MonoEmpty.java:46)
at reactor.core.publisher.Mono.subscribe(Mono.java:4400)
at reactor.core.publisher.FluxFlatMap$FlatMapMain.onNext(FluxFlatMap.java:426)
at reactor.core.publisher.FluxPublishOn$PublishOnSubscriber.runAsync(FluxPublishOn.java:440)
at reactor.core.publisher.FluxPublishOn$PublishOnSubscriber.run(FluxPublishOn.java:527)
at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:84)
at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:37)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NullPointerException: null
at java.base/java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
at java.base/java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
at java.base/java.util.Properties.put(Properties.java:1301)
at com.provectus.kafka.ui.service.AdminClientServiceImpl.lambda$createAdminClient$2(AdminClientServiceImpl.java:39)
at reactor.core.publisher.MonoSupplier.call(MonoSupplier.java:86)
at reactor.core.publisher.FluxFlatMap.trySubscribeScalarMap(FluxFlatMap.java:127)
... 16 common frames omitted
2022-10-17 17:23:43,662 DEBUG [parallel-1] c.p.k.u.s.ClustersMetricsScheduler: Metrics updated for cluster: test-kafka
2022-10-17 17:24:13,660 DEBUG [parallel-1] c.p.k.u.s.ClustersMetricsScheduler: Start getting metrics for kafkaCluster: test-kafka
2022-10-17 17:24:13,662 ERROR [parallel-1] c.p.k.u.s.MetricsService: Failed to collect cluster test-kafka info

Hi, please follow the bug issue template and share the required details (app version, config, etc.)

Describe issue:
Once after the deploying the kafka ui jar through application yaml file on premises host, getting the below error. Basically we are trying to setup SASL connection with kafka-ui to our kafka cluster.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'http_proxy' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'no_proxy' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'ssl_keystore_location' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'https_proxy' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'ssl_truststore_location' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'ssl_truststore_password' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'keytab' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'sasl_jaas_config' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'ssl_key_password' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'principal' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'ssl_keystore_password' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'opts' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'sasl_mechanism' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'security_protocol' was supplied but isn't a known config.
2022-10-18 14:28:00,614 WARN  [parallel-2] o.a.k.c.a.AdminClientConfig: The configuration 'sasl_kerberos_service_name' was supplied but isn't a known config.
2022-10-18 14:28:00,614 INFO  [parallel-2] o.a.k.c.u.AppInfoParser: Kafka version: 2.8.0
2022-10-18 14:28:00,614 INFO  [parallel-2] o.a.k.c.u.AppInfoParser: Kafka commitId: ebb1d6e21cc92130
2022-10-18 14:28:00,614 INFO  [parallel-2] o.a.k.c.u.AppInfoParser: Kafka startTimeMs:<PHONE_NUMBER>614
2022-10-18 14:28:14,828 INFO  [kafka-admin-client-thread | adminclient-2] o.a.k.c.a.i.AdminMetadataManager: [AdminClient clientId=adminclient-2] Metadata update failed
org.apache.kafka.common.errors.TimeoutException: Call(callName=fetchMetadata, deadlineMs=1666099694756, tries=1, nextAllowedTryMs=1666099694928) timed out at<PHONE_NUMBER>828 after 1 attempt(s)
Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting to send the call. Call: fetchMetadata
2022-10-18 14:28:15,397 ERROR [parallel-2] c.p.k.u.s.MetricsService: Failed to collect cluster staging-kafka info
java.lang.IllegalStateException: Error while creating AdminClient for Cluster staging-kafka
at com.provectus.kafka.ui.service.AdminClientServiceImpl.lambda$createAdminClient$3(AdminClientServiceImpl.java:45)
at reactor.core.publisher.Mono.lambda$onErrorMap$31(Mono.java:3733)
at reactor.core.publisher.FluxOnErrorResume$ResumeSubscriber.onError(FluxOnErrorResume.java:94)
at reactor.core.publisher.FluxMapFuseable$MapFuseableSubscriber.onError(FluxMapFuseable.java:140)
at reactor.core.publisher.MonoFlatMap$FlatMapMain.onError(MonoFlatMap.java:172)
at reactor.core.publisher.MonoPublishOn$PublishOnSubscriber.run(MonoPublishOn.java:187)
at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:68)
at reactor.core.scheduler.SchedulerTask.call(SchedulerTask.java:28)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: org.apache.kafka.common.errors.TimeoutException: Call(callName=listNodes, deadlineMs=1666099695394, tries=1, nextAllowedTryMs=1666099695496) timed out at<PHONE_NUMBER>396 after 1 attempt(s)
Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment. Call: listNodes
2022-10-18 14:28:15,397 DEBUG [parallel-2] c.p.k.u.s.ClustersMetricsScheduler: Metrics updated for cluster: staging-kafka
2022-10-18 14:28:15,401 DEBUG [parallel-1] c.p.k.u.s.ClustersMetricsScheduler: Start getting metrics for kafkaCluster: staging-kafka
2022-10-18 14:28:15,402 INFO  [parallel-1] o.a.k.c.a.AdminClientConfig: AdminClientConfig values:
bootstrap.servers = [<IP_ADDRESS>:9092, <IP_ADDRESS>:9092, <IP_ADDRESS>:9092, <IP_ADDRESS>:9092]
client.dns.lookup = use_all_dns_ips
client.id =
connections.max.idle.ms = 300000
default.api.timeout.ms = 60000
metadata.max.age.ms = 300000
metric.reporters = []
metrics.num.samples = 2
metrics.recording.level = INFO
metrics.sample.window.ms = 30000
receive.buffer.bytes = 65536
reconnect.backoff.max.ms = 1000
reconnect.backoff.ms = 50
request.timeout.ms = 30000
retries =<PHONE_NUMBER>
retry.backoff.ms = 100
sasl.client.callback.handler.class = null
sasl.jaas.config = null
sasl.kerberos.kinit.cmd = /usr/bin/kinit
sasl.kerberos.min.time.before.relogin = 60000
sasl.kerberos.service.name = null
sasl.kerberos.ticket.renew.jitter = 0.05
sasl.kerberos.ticket.renew.window.factor = 0.8
sasl.login.callback.handler.class = null
sasl.login.class = null
sasl.login.refresh.buffer.seconds = 300
sasl.login.refresh.min.period.seconds = 60
sasl.login.refresh.window.factor = 0.8
sasl.login.refresh.window.jitter = 0.05
sasl.mechanism = GSSAPI
security.protocol = PLAINTEXT
security.providers = null
send.buffer.bytes = 131072
socket.connection.setup.timeout.max.ms = 30000
socket.connection.setup.timeout.ms = 10000
ssl.cipher.suites = null
ssl.enabled.protocols = [TLSv1.2, TLSv1.3]
ssl.endpoint.identification.algorithm = https
ssl.engine.factory.class = null
ssl.key.password = null
ssl.keymanager.algorithm = SunX509
ssl.keystore.certificate.chain = null
ssl.keystore.key = null
ssl.keystore.location = null
ssl.keystore.password = null
ssl.keystore.type = JKS
ssl.protocol = TLSv1.3
ssl.provider = null
ssl.secure.random.implementation = null
ssl.trustmanager.algorithm = PKIX
ssl.truststore.certificates = null
ssl.truststore.location = null
ssl.truststore.password = null
ssl.truststore.type = JKS
Expected Behaviors:
It should work normally after the connection
Configuration:
kafka:
clusters:
- name: kafka
bootstrapServers: 10.x.x.x:9092,10.x.x.x:9092,10.x.x.x:9092,10.x.x.x:9092
properties:
opts: "-Djava.security.auth.login.config=/home/kafka_client_jaas.conf -Djava.security.krb5.conf=/etc/krb5.conf -Dsun.security.krb5.debug=true"
principal<EMAIL_ADDRESS>security_protocol: SASL_SSL
keytab: /home/svc-kafka.keytab
sasl_mechanism: GSSAPI
sasl_kerberos_service_name: kafka
ssl_truststore_location: /home/kafka_broker.truststore.pks.jks
ssl_truststore_password: $$$$
ssl_keystore_location: /home/kafka_broker.keystore.pks.jks
ssl_keystore_password: $$$$
ssl_key_password: $$$$
sasl_jaas_config: 'com.sun.security.auth.module.Krb5LoginModule required useTicketCache=true renewTicket=true useKeyTab=true keyTab="/home/svc-kafka.keytab" principal="svc-kafka@GLOBAL.xyz.org";'
schemaRegistry: http://localhost:8085
ksqldbServer: http://localhost:8088
kafkaConnect:
- name: first
address: http://localhost:8083
metrics:
port: 9997
type: JMX
spring:
jmx:
enabled: true
auth:
type: disabled
server:
kafka-ui
port:
8080 #- Port in which kafka-ui will run.
kafka-ui App version:  kafka-ui-api-v0.4.0

@sunny092318 thanks, please take a look at this: #2118

@Haarolean Thanks for all your support, able to setup the kafka-ui for my project with SASL enabled mechanism.
Now trying to set authentication for kafka-ui dashboard, but its not working somehow. Below are my application.yml configuration. Any leads will be quiet helpful do we have define differently.
properties:
metrics_username: abc
metrics_password: abc

@Haarolean Thanks for all your support, able to setup the kafka-ui for my project with SASL enabled mechanism. Now trying to set authentication for kafka-ui dashboard, but its not working somehow. Below are my application.yml configuration. Any leads will be quiet helpful do we have define differently.
properties: metrics.username: abc metrics.password: abc

eh, do you want to set up auth for the ui itself?
Check this:

@Haarolean Thanks for the details. Does kafka-ui support on LDAP mechanism, because I have defined below parameter in application.yaml file but it doesn't change anything. From the log can see configuring LDAP authentication so means LDAP configuration done or in progress.
====
spring.ldap.url=ldap://localhost:18889
spring.ldap.base=dc=example,dc=com
spring.ldap.username=uid=admin,ou=system
spring.ldap.password=secret

This issue has been automatically marked as stale because no requested feedback has been provided. It will be closed if no further activity occurs. Thank you for your contributions.

bad bot

@Haarolean Thanks for the details. Does kafka-ui support on LDAP mechanism, because I have defined below parameter in application.yaml file but it doesn't change anything. From the log can see configuring LDAP authentication so means LDAP configuration done or in progress.
spring.ldap.url=ldap://localhost:18889 spring.ldap.base=dc=example,dc=com spring.ldap.username=uid=admin,ou=system spring.ldap.password=secret

Yes it does. The link is available in the same wiki, click here. Please use the env variables provided there.

I have tried providing the below parameter in application.yaml since installing on through servers not with containers approach.
Is there something doing wrong or any change require on ldap server also. Please suggest
spring:
jmx:
enabled: true
auth.type: "ldap"
spring.ldap.urls: "ldap://example:389"
spring.ldap.userfilter.searchbase: "dc=g,dc=first,dc=org"
spring.ldap.userfilter.searchfilter: "cn=one,ou=Service accounts,ou=Management,ou=india,dc=g,dc=first,dc=org"
spring.ldap.adminuser: "cn=one,ou=Service accounts,ou=Management,ou=india,dc=global,dc=first,dc=org"
spring.ldap.adminpassword: "xxxx"

This issue has been automatically marked as stale because no requested feedback has been provided. It will be closed if no further activity occurs. Thank you for your contributions.

bad bot

@sunny092318 if you're running the jar, your config should be a valid yaml file :)
spring:
  jmx:
    enabled: true
  ldap:
    urls: "ldap://example:389"
#...

auth:
  type: "ldap"

@Haarolean Thanks for providing the details. I think its not related to yaml syntax since if it was yaml error then it couldn't allow me to run kafka-ui app.
I think its something related to ldap configuration because even passing all parameter it doesn't allow me  to login.

@sunny092318 well, the example does work fine, all the credentials from rroemhild/test-openldap are getting accepted.
Can you provide a setup with docker-compose to reproduce to issue you're having?
On the side note, a suggestion to turn on finer logging via this env. property:
logger.level.org.springframework.security=DEBUG


Google colab error

2023-12-18 10:51:25.414454: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:9261] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2023-12-18 10:51:25.414507: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:607] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2023-12-18 10:51:25.415898: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1515] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-12-18 10:51:26.735947: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_5m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_5m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_11m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_11m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_384 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_384. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_512 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_512. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
Seed set to 0
[INFO] Using 16bit Automatic Mixed Precision (AMP)
[INFO] GPU available: True (cuda), used: True
[INFO] TPU available: False, using: 0 TPU cores
[INFO] IPU available: False, using: 0 IPUs
[INFO] HPU available: False, using: 0 HPUs
[INFO] LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0]
[INFO]
| Name       | Type                           | Params
0 | geometry   | ImplicitVolume                 | 12.6 M
1 | material   | DiffuseWithPointLightMaterial  | 0
2 | background | NeuralEnvironmentMapBackground | 448
3 | renderer   | NeRFVolumeRenderer             | 0
12.6 M    Trainable params
0         Non-trainable params
12.6 M    Total params
50.419    Total estimated model params size (MB)
[INFO] Validation results will be saved to outputs/dreamfusion-if/a_delicious_hamburger@20231218-105129/save
[INFO] Using prompt [a delicious hamburger] and negative prompt []
[INFO] Using view-dependent prompts [side]:[a delicious hamburger, side view] [front]:[a delicious hamburger, front view] [back]:[a delicious hamburger, back view] [overhead]:[a delicious hamburger, overhead view]
2023-12-18 10:51:35.993863: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:9261] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2023-12-18 10:51:35.993917: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:607] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2023-12-18 10:51:35.995116: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1515] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-12-18 10:51:37.289358: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_5m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_5m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_11m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_11m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_224 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_224. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_384 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_384. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
/usr/local/lib/python3.10/dist-packages/controlnet_aux/segment_anything/modeling/tiny_vit_sam.py:654: UserWarning: Overwriting tiny_vit_21m_512 in registry with controlnet_aux.segment_anything.modeling.tiny_vit_sam.tiny_vit_21m_512. This is because the name being registered conflicts with an existing name. Please check if this is not expected.
return register_model(fn_wrapper)
Process SpawnProcess-1:
Traceback (most recent call last):
File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/content/threestudio/threestudio/models/prompt_processors/deepfloyd_prompt_processor.py", line 58, in spawn_func
tokenizer = T5Tokenizer.from_pretrained(
File "/usr/local/lib/python3.10/dist-packages/transformers/tokenization_utils_base.py", line 1795, in from_pretrained
raise EnvironmentError(
OSError: Can't load tokenizer for 'DeepFloyd/IF-I-XL-v1.0'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'DeepFloyd/IF-I-XL-v1.0' is the correct path to a directory containing all relevant files for a T5Tokenizer tokenizer.
Traceback (most recent call last):
File "/content/threestudio/launch.py", line 301, in
main(args, extras)
File "/content/threestudio/launch.py", line 244, in main
trainer.fit(system, datamodule=dm, ckpt_path=cfg.resume)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py", line 544, in fit
call._call_and_handle_interrupt(
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py", line 44, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py", line 580, in _fit_impl
self._run(model, ckpt_path=ckpt_path)
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/trainer.py", line 970, in _run
call._call_lightning_module_hook(self, "on_fit_start")
File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py", line 157, in _call_lightning_module_hook
output = fn(*args, **kwargs)
File "/content/threestudio/threestudio/systems/dreamfusion.py", line 32, in on_fit_start
self.prompt_processor = threestudio.find(self.cfg.prompt_processor_type)(
File "/content/threestudio/threestudio/utils/base.py", line 83, in init
self.configure(*args, **kwargs)
File "/content/threestudio/threestudio/models/prompt_processors/base.py", line 337, in configure
self.load_text_embeddings()
File "/content/threestudio/threestudio/models/prompt_processors/base.py", line 393, in load_text_embeddings
self.text_embeddings = self.load_from_cache(self.prompt)[None, ...]
File "/content/threestudio/threestudio/models/prompt_processors/base.py", line 411, in load_from_cache
raise FileNotFoundError(
FileNotFoundError: Text embedding file .threestudio_cache/text_embeddings/03314739b354f88c2c2add8aa3ca71d4.pt for model DeepFloyd/IF-I-XL-v1.0 and prompt [a delicious hamburger] not found.

HI @GggggiitHHHHuuub
DeepFloyd/IF-I-XL-v1.0 needs to have an access token. Please login into huggingface to get that token or you can use dreamfusion-sd to replace guidance with stable diffusion.

Following @DSaurus suggestion at cell with:
!python launch.py --config configs/dreamfusion-if.yaml --train --gpu 0 system.prompt_processor.prompt="$prompt" trainer.max_steps=10000 system.prompt_processor.spawn=false
If you want to use
dreamfusion-if, you have to accept their license on hugging face and then login with huggingface-cli login and paste your token. You can generate your own token in your hugging face profile page.


Detecting Camel endpoint in xml files may pick non Camel

We can sometime hit mistakes like a  which refers to a AMQ broker which can use its own internal vm protocol to talk to it inside the same jvm.

We could either consider only scanning inside  or  for xml files. But then people cannot validate outside in their own  if they setup a bean with a hardcoded camel endpoint.

We need to skip brokerURL option as its not for Camel endpoint

We should also skip wsdl files, eg for xml it should be in an .xml file.

Okay what is left is some CXF stuff which can creep in as well in xml files.


Detach plugins in separate repos

Short Description of the issue
Enable a more flexible management splitting the development of the core components from the one dedicated to the specific plugins.

[ ]  Create separete repos for HTCondor sidecar
[ ]  Create separete repos for SLURM sidecar
[ ]  Create separete repos for Docker sidecar
[ ]  Create a doc page for link to plugins (To be evolved to a catalogue one, like the "daggerverse" page)

Environment

Operating System:
Other related components versions:

Steps to reproduce

Logs, stacktrace, or other symptoms

output

Summary of proposed changes

@Surax98

[ ] migrate SLURM plugin to a separate repo
[ ] Document how to make it run and config
[ ] test for the plugin only (unit testing http requests)
[ ] CI with gh actions for the build

closing this, please @Surax98 report the points above as issues in your slurm repo


exerciselist directive sometimes only shows the solution

seems to happen for all discussion directives, e.g. https://coderefinery.github.io/git-intro/exercises/#motivation
and also some exercises, e.g. the "Test your understanding" exercise on https://coderefinery.github.io/git-intro/basics/

Right now it is targeted only to the boxes of exact type exercise and solution:
https://github.com/coderefinery/sphinx-lesson/blob/master/sphinx_lesson/exerciselist.py#L55
I thought about making it adaptable, so that you could specify any directives you might want for inclusion, but left that off in the first version for simplicity.
What do you think we should do?

nothing, adjust lessons to follow an exercise and solution model.
Add discussion and possibly more boxes into the core directive (this may be good for carpentries lesson compatibility - I think solution was our replacement of discussion).  Most new things I have made haven't included many discussion blocks.
Add an option to the exerciselist directive so that each instance can decide what should be included.
Add a way to tag adminitions for inclusion

So, I guess the big picture discussion is how should this directive be used and how should lessons be organized?
I'm thinking do (2) for now, and then (3) when we have time (I think it will require a bit of reshuffling, since right now the list is made separately from looking at the directives - but that won't be too hard overall.).

maybe the solutions don't need to be included since there's a link to each exercise?
Separate but related issue: i see now that the "Test your understanding" exercise was left out (only showing the solution) because it uses not exercise but challenge - apparently they look identical. Not sure what's best to do with that. Two options:

Remove challenge directive from sphinx-lesson
Make challenge look visually different from exercise and include it with exerciselist

Yeah, I think challenge was the carpentries format equivalent of exercise.  But I got the idea they have different model, was it that they don't expect any learners to be looking at the lesson materials themselves and everything is hands-on, so there's no real concept of exercise but only "you can do a bit more if you want".  Hearing this, I had the idea we could try to remove challenges and migrate to exercise.
I can't find much about this except this issue (probably there was more in chat): https://github.com/coderefinery/sphinx-lesson/issues/12
OK, it's sort of documented here:
https://coderefinery.github.io/sphinx-lesson/directives/#list
... but all of this is open to discussion as we see what is useful.
(I guess git-intro had a direct transliteration to sphinx-lesson from markdown, but not a longer updating).
What do you think now?
(I personally think we can consider it deprecated, but not removed to not break other lessons that might use it)

If we are thinking to prepare exercise leaders, I wonder if type-along should be included, too?
I guess homework doesn't need to be there, since it's not so critical for preparation?

i would say that type-along isn't needed since that's always in the hands of the instructor, and the simpler the task looks to helpers the better.
Agree on homework, it shouldn't be included

FWIW when refactoring lessons from Jekyll to Sphinx I have been removing "challenge" and using "exercise" because it wasn't clear to me what a challenge would be that an exercise wasn't.


FIX: Missing the first & 0xFF

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description
Fix Issue #343

Thanks!!


raspberrypi 7 inch touch screen auto calibration

I want the touch screen to auto-calibrate. I'm doing my image file with core-image-sato (branch: dunfell).
bbfilesler files attached:: meta-qt5 ,meta-raspberrypi, meta-openembedded
MACHINE ??= "raspberrypi3"
rpi-ft5406.dts:
"
/dts-v1/;
/plugin/;
/ {
compatible = "brcm,bcm2835";
    fragment@0 {
            target-path = "/soc/firmware";
            __overlay__ {
                    ts: touchscreen {
                            compatible = "raspberrypi,firmware-ts";
                            touchscreen-size-x = <800>;
                            touchscreen-size-y = <480>;
                    };
            };
    };

    __overrides__ {
            touchscreen-size-x = <&ts>,"touchscreen-size-x:0";
            touchscreen-size-y = <&ts>,"touchscreen-size-y:0";
            touchscreen-inverted-x = <&ts>,"touchscreen-inverted-x?";
            touchscreen-inverted-y = <&ts>,"touchscreen-inverted-y?";
            touchscreen-swapped-x-y = <&ts>,"touchscreen-swapped-x-y?";
    };

};
"
Data from xinput_calibration:
"copy the snippet below into '/etc/X11/xorg.conf.d/99-calibration.conf' (/usr/share/X11/xorg.conf.d/ in some distro's)
Section "InputClass"
Identifier "calibration"
MatchProduct "raspberrypi-ts"
Option “CalibrationMatrix” "-0.968536 0.000731 0.984204 -0.009033 0.9033 0.964251 0.020888 0.00000 0.00000 1.00000"
EndSection "
The file "99-calibration.conf" does not exist.
UART Debug:
"
D-BUS per-session daemon address is: unix:abstract=/tmp/dbus-yH0mMaG9G9,guid=ced520525b30507c1e02b8c85aa28981
INFO: width=800, height=480
matchbox: Cant find a keycode for keysym 269025056
matchbox: ignoring key shortcut XF86Calendar=!$contacts
matchbox: Cant find a keycode for keysym 2809
matchbox: ignoring key shortcut telephone=!$dates
matchbox: Cant find a keycode for keysym 269025050
matchbox: ignoring key shortcut XF86Start=!matchbox-remote -desktop
[settings daemon] Forking. run with -n to prevent fork
matchbox-wm: X error warning (0x1200003): BadWindow (invalid Window parameter) (opcode: 12)
dbus-daemon[661]: Activating service name='org.a11y.atspi.Registry' requested by ':1.0' (uid=0 pid=657 comm="matchbox-panel --start-applets showdesktop,windows")
dbus-daemon[661]: Successfully activated service 'org.a11y.atspi.Registry'
SpiRegistry daemon is running with well-known name - org.a11y.atspi.Registry**
"
how do i do with yocto.

I typed the command into the file. worked automatically
"/root/usr/bin/xinput_calibration_once.sh into "
"xinput set-prop 8 "Coordinate Transformation Matrix" 0 -1 1 -1 0 1 0 0 1"


Force a Refresh without changing token.

Can you expose an API that would allow a forced redraw?  I am dynamically changing some effect icons and updated the document immediately redraws on the token, but not on VAE.

Updating an effect should already be refreshing the panel, as seen here.

In this case, I am updating the effect on an item that is apply the effect to the actor.  So the effect parent is the item, no the actor.  So the panel doesn't refresh.

I was able to cobble this together, but is pretty hacky...
async function changeHealth(actorUuid, health) {
        let actor = await fromUuid(actorUuid);
        let horse = getHorse(actor);
        let effect = horse.effects.find(e => e.name == "Mounted");
        if (!effect) {
            return false;
        }
        let icon = `modules/stroud-dnd-helpers/images/icons/saddle_health/saddle_health_${health}.webp`;
        await horse.updateEmbeddedDocuments("ActiveEffect", [{ "_id": effect.id, "icon": icon }])
        let style = $(`div[data-effect-uuid='${effect.uuid}'] div.effect-icon`).attr("style");
        style = style.replace(/modules\/stroud-dnd-helpers\/images\/icons\/saddle_health\/saddle_health_\d{2}\.webp/, icon);
        $(`div[data-effect-uuid='${effect.uuid}'] div.effect-icon`).attr("style", style);
    }

What version of the module are you using?

11.0.6

I am getting ready to migrate to V12 though...  Maybe I will just live with the hack for now.

The current version should already be supporting this (see the above link to the current code, it is effect.target rather than effect.parent).


Set/Delete Tags on Work Items

Description
As a user, I want or add or remove tags to/from work items on the work item detail view.
Function Acceptance Criteria

The user is able to view the currently associated tags on the view.
The tag list may be empty.
The user is able to add a new tag association by selection an available tag from a list.
The user can remove an already associated tag. Removing a tag does not need a confirmation.

Non-functional Acceptance Criteria

Adding or removing tags is performed in-place and is directly visible.

Dependencies

Userstory #298

Just to confirm - is the user able to assign one or many tags to a work item?

Are we going to allow Tag creation?

@nimishamukherjee we must, otherwise, where would the tags come from?

@nimishamukherjee @tsmaeder tag creation is #300.

@ldimaggi yes, none or more tags can be associated.


remove legacy/deprecated attribute

See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#Deprecated_attributes.
lang was specified here, so probably ignored by most browsers.

Thanks @efx!


Enable UndefOr operators for Unit | _ and _ | Unit

Could you motivate this please?

UndefOr and Unit | ? are essentially the same type
Some tools produce Unit | _ types when converting type definition from TypeScript

So, in fact in Scala.js 1.x js.UndefOr[A] is literally a type alias for A | Unit. I guess we could pimp the UndefOrOps[A] to A | Unit in 0.6.x to bridge the gap a bit.
That said, tools right now really should emit js.UndefOr[A] instead of A | Unit/Unit | A. I feel like this PR is trying to work around the tools inside the core, whereas in fact we should just fix the tools, not change the core.

Is there a plan for releasing Scala.js 1.0?

Not really. We "just" need to clear out https://github.com/scala-js/scala-js/milestone/64

Will the milestone break backward compatibility?

It's unlikely that we will break anything at the source level for user-visible stuff, at this point. So the release notes of M7 will be very similar to those of M6, and likewise for future milestones until the final release.

Since backward-compatibility will be kept from 1.0.0-M6, why not release now and let new features and internal refactoring go to Scala.js 1.1+?

Because the internal refactorings affect the binary compatibility of the artifacts.

It is to say it's only necessary to clear out IR related issues, isn't it? Is it possible to breaking change internal compiler API after 1.0?

Because the internal refactorings affect the binary compatibility of the artifacts.

The compiler API we break all the time (in fact we don't even consider it an API at all). But the surface of the linker API, as well as the JSEnv API, will also need to preserve binary compatibility after 1.x.

What is the state of this? @Atry would you still like us to consider this for merging or are you OK with using 1.0.x / improving tools?

I understand that the Scala.js maintainers are not willing to accept changes that do not help in future Scala 1.0.

I've thought more about this, and in particular how this is going to evolve in Scala 3. Since it will have real union types, String | Null will be equivalent to String, and therefore the proposed API will not be able to kick in. Unless Scala 3 receives non-nullable types as well, that means the change introduced here will be broken by Scala 3. For that reason I'm going to close this. It could be revisited if Scala 3 gets non-nullable types.


Init Maps Dashboard Plugin Repository

Description

Auto generate the skeleton code for the Maps Dashboard plugin
Add Readme

Issues Resolved

https://issues.amazon.com/issues/CloudSearch-22110

Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you add snapshot/image from your local host on how does this look ?

Also, create new issue here and link it in PR description

Can you add snapshot/image from your local host on how does this look ?

Can you recreate with plugin id as "mapsExplorerDashboards" ? You can refer this plugin as an example: https://github.com/opensearch-project/observability/tree/main/dashboards-observability We also want on left side as "Maps Explorer".

Hi Vijay, thanks for your comments. I just pushed the commit with changes you are asking to the PR.

Attached some screenshots.


std::set implementation for Container V2

Summary
Container V2 implementation for std::set. This closes #306.
Test plan
$ build/test/integration/integration_test_runner --gtest_filter='OilIntegration.std_set_custom_comparator_a' --verbose --preserve

Codecov Report

Merging #323 (410cb6f) into main (5071519) will decrease coverage by 21.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #323       +/-   ##
===========================================
- Coverage   67.94%   46.79%   -21.16%
===========================================
  Files         114      101       -13
  Lines       11044    10722      -322
  Branches     1853     1802       -51
===========================================
- Hits         7504     5017     -2487
- Misses       2578     4858     +2280
+ Partials      962      847      -115

see 72 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[feat] Add support for One framework and Tamagui

Describe the feature
Onlook is an amazing project. Is there any plan to add support for One framework  https://onestack.dev/ and Tamagui https://tamagui.dev/

Hey @ansarizafar,
Seems like One is using Vite so the manual setup will work (1 line change). We can also prioritize an official GUI import support as well
https://github.com/onlook-dev/onlook/wiki/How-to-set-up-my-project%3F#do-it-manually

Onlook will now work for any react framework with no setup. Let me know if this still doesn't work :)


[1.2] threadnetworkdiagnostics active-network-faults-list not according to spec

Reproduction steps
Issue this chip-tool command:
./chip-tool threadnetworkdiagnostics read active-network-faults-list 1 0
This can result in:
[1708709580.875154][6970:6972] CHIP:TOO:   ActiveNetworkFaultsList: 4 entries
[1708709580.875242][6970:6972] CHIP:TOO:     [1]: 0
[1708709580.875295][6970:6972] CHIP:TOO:     [2]: 0
[1708709580.875348][6970:6972] CHIP:TOO:     [3]: 0
[1708709580.875402][6970:6972] CHIP:TOO:     [4]: 0
The specification states:
"The ActiveNetworkFaults attribute SHALL indicate the set of faults currently detected by the Node.
When the Node detects a fault has been raised, the appropriate NetworkFaultEnum value SHALL be
added to this list. This list SHALL NOT contain more than one instance of a specific NetworkFaultEnum value. When the Node detects that all conditions contributing to a fault has been cleared, the
corresponding NetworkFaultEnum value SHALL be removed from this list. An empty list SHALL
indicate there are currently no active faults."
The current behaviour conflicts with:
"This list SHALL NOT contain more than one instance of a specific NetworkFaultEnum value"
The value 0 does not indicate no error according to the specification, but "Indicates an unspecified fault."
I beleive that in this case it should have been reported an empty list rather than a list with 4 unspecified faults.
Bug prevalence
Always
GitHub hash of the SDK that was being used
latest
Platform
core
Platform Version(s)
No response
Type
Spec Compliance Issue
Anything else?
No response

@olavt What is the server in this case?

Ah, I guess WriteThreadNetworkDiagnosticAttributeToTlv always does this?


Add function to gather kubernetes logs

For GKE scenario, customers need kubernetes logs, so gather kubelet.log, kube-proxy.log and docker.log under "C:\etc\kubernetes\logs" directory

/cc pjh

@pjh @dntczdx Please take another look

cc @ning-yang

@dntczdx @pjh please take another look

/retest

@pjh please take another look :)

@dntczdx Can you take another look if it's ok to merge? Thanks!

cc @adjackura

/cc adjackura


Sanitized godeps

Cleaned up redundant files in godep workspace.
Ran:
godep restore
rm -rf Godeps
godep save ./... github.com/progrium/go-extpoints

to recreate vendored godeps.
Without this I was getting loads of issues adding in new dependencies - could have done by hand but would rather rely on tooling to do it.

Can one of the admins verify this patch?

add to whitelist

LGTM, thanks @jimmidyson. I tried doing this after semi-manually updating the kubernetes dep, but it kept on removing necessary dependencies.

Yeah godep seems to have some problem with transitive side effect imports but doing it from a clean Godeps dir seemed to work nicely.

Oh, nice find.
Jenkins is failing in a weird way, but since all code and tests compile this is good to merge.


Official rules for rounding

Should the amount of profit be rounded (in Euros) for each row, or only for the resulting sum?

Hello, I've contacted Vero and they said that I must round up the value of each row, at least with my understanding

Super! Did you have anything in writing from them (email, screenshot) that could be added for a future reference?

I believe this function should return the rounded-up value:
https://github.com/jehna/kryptovero.fi/blob/cb0ce9494677c9bae462f9c6edf6ce84c5cd9d7d/ledger/src/index.ts#L55-L58


Feature: Add Typescript declarations

Hi,
it would be great to have typescript declarations because it would make it easier to use with Angular2 (Typescript) projects.
https://www.typescriptlang.org/docs/handbook/writing-declaration-files.html
Thanks and BR,
Michael

I'm happy to accept a pull request for this, even one that's incomplete!

The TypeScript declarations should live in the DefinitelyTyped repo, so I'm going to close this issue.

Added TypeScript type definitions to DefinitelyTyped under @types/humanize-duration.

@EvanHahn Any interest in maintaining types within this repo? That is the more modern approach.

Sure, happy to review a pull request. (If you can generate a .d.ts file from the existing JSDoc declarations, that would be ideal.)


Can not create queues with long slugs

The permission_name, and slug fields of Queue model are both limited to 50 chars.
Or permission_name is built as 'helpdesk.queue_access_%s' % slug...
Fix would be  increasing max_length for permission_name

Slugs are typically meant to be pretty short. What do you think is an appropriate max_length?

Don't disagree. I managed it locally by limiting my slugs, but was rather pointing out the inconsistency there (and you'll end up with ghost permissions in the db as hey are created before the failure)
Well, the minimum max length should be 72 chars. I guess with 100 it will be pretty safe from any update in the prepare_permission_name function.

Oh I understand now, thank you! Yes, the slug (50 chars) gets some stuff prepended to it and result is 72 chars, which doesn't fit in the 50 chars reserved for permission_name. Yep, definitely a bug!
I'll code up a quick patch to expand it to 72 chars to cover slug + prepend.


Add multipart form support

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5084231) 100.00% compared to head (5cde2cb) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines          925       963   +38
=========================================
+ Hits           925       963   +38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dependas

Resolves #791 aws-sdk
Resolves #790 tinymce
Resolves #789 googleapis
Resolves #787 chai
Resolves #785 fildpond
Resolves #784 react-srcipts
Resolves #782 pdf-lib
Resolves #778 darkreader
Resolves #777 sinon
Resolves #745 axios
Resolves #735 fortawesome

There seems to be issues with the jenkins image that was recently merged in. Looks like they fixed the react-scripts issue pertaining to docker in this recent update, so that's a plus, but I'm not sure about the error screenshotted below. I have not seen it before.


Drop the Algorithm requirement on JWK for direct

The Algorithm parameter on the JWK should be the algorithm used in the
key (e.g. A256GCM).
In Direct, the key is used as the Content Encryption key, and not as a
Wrapping key, which means that the Algorithm on the key should be
A256GCM.

I don't think your suggestion is appropriate. The DirectJweAlgorithm is intended for "Direct Encryption with a Shared Symmetric Key" (RFC7518 4.5). The alg parameter will always be "dir".


The segment identifiers are not standard PDB formats, but are additions used by Namd and Charmm to their simulation formats, and yes, it is an addition to that 73-76 empty spaces, with a maximum of four characters.
Originally posted by @leandromartinez98 in https://github.com/chemfiles/chemfiles/issues/361#issuecomment-664492964

This shouldn't be difficult to add!

In case you do implement this, I would suggest call the selection syntax segname to follow the same syntax used in VMD. VMD is the package used mostly by NAMD users, and since this is a feature mostly known by those users, using the same syntax is probably nice.

I envision this as being an atom property, like chainid/chainname. So the selection syntax would be [segnam] == PROT

Are segment a property of a given atom or a given residue? I.e. can we have different segments for the same residue?

No, every atom of the same residue (and even a whole protein) can only belong to (thus, have) the same segment.
Most generally, a segment is a subset of the system whose topology (connectivity, angles, etc) can be defined independently
of the rest of the system. Thus, no molecule can be split between segments. Typically, the organization is such that each protein chain belongs to a segment, the solvent molecules to other segment, ions to other segment, etc.

ok, thanks! It would make sense making it a Residue property then.


GaiException: android_getad

Expected behavior
See which emails I have in my inbox.
Actual behavior
It says "Poll<EMAIL_ADDRESS>and then again just shows the email (in the header, below Inbox). If I then go back in the overview, below drafts and inbox, both it says "GaiException: android_getad"
Environment
K-9 Mail version:
5.010
Android version:
6.0.1 MMB29M
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP
My server settings are correct since when I put in different (wrong) settings it says unable to connect to server right away.
My device is a chinese Xiaomi Redmi 3S, which uses a special android version without google in general and google play services in particular which makes using some apps impossible (and installing google play services does not work). maybe it has something to do with that special android version?

It'a a very cryptic message for a common problem, which is 'unable to contact server'.
Gai is 'GetAddressInfo' - basically DNS. We're showing the exception and the start of the message.
This is mainly a UI issue - our display of errors is currently very ugly.
If you go to the folder and poll for emails when you have a network connection it should be able to connect and update which will clear the meassage.

We can track this under #1058.


Add a LICENSE file

It would help to clarify a bit if this is an open-source or free software project. https://github.com/ianthehenry/codemirror-lang-janet seems to be licensed under the MIT license, is Bauble itself under that license?

Oh whoops. It was supposed to be. It is now!


Update the Visualization from API Libraries

What article on docs.github.com is affected?

Github API Libraries

What part(s) of the article would you like to see updated?

[ ] Organize the Links in tables instead of Bullet List
[ ] Show the real Github Repository from every Library, including the names of the users who created it
[ ] Make it simple to update in case of new Libraries, just putting new line on the Lists

Additional information

Take off the space in the phrase "Octokit comes in many flavors" and make it little smaller
Emphasize the Oficial libraries

Thanks for opening an issue using the template @F4NT0! It helps us to better understand what you're looking to get updated 💖

Added a comment here: https://github.com/github/docs/pull/376#issuecomment-713031558 Looks great!

Thank you


Cannot upload file from a local OneDrive folder

Storage Explorer Version:
1.0.0
OS Version:
Windows 10 (1709 Build 16299.402)
Steps to Reproduce:

Select a file in a local synced OneDrive folder (From SharePoint Online Document Library)

Expected Experience:
Upload file
Actual Experience:
Upload fail
Workaround
Moved file to a local path (downloads) and upload worked normally.

Hi @dsghi , the cause of this issue is a bug in NodeJS. They recently fixed the bug, and we're now waiting on Chromium/Electron to use a version of NodeJS which has the fix, at which point we'll upgrade to that version of Electron. Until then, you'll need to move the file out of your OneDrive folder before uploading.

+1
How is this issue related to Chromium/Electron?

@steveesp Storage Explorer is built using Electron, and Electron integrates with a specific version of Node. We use that version of Node's APIs to access local files and upload to Azure. Electron has to publish an update in which they integrate with a newer version of Node wherein these issues are fixed. Then we have to update the version of Electron we use to get the fix.

A few of workarounds are:

Copy files out of the OneDrive folder, and into a file that you have fill control over. IE: D:\FileTransfer
Download Red-Gate's Azure Explorer, which doesn't have this limitation, but doesn't have all of the features that we are used to for the storage explorer.
Get the paid version of Filezilla, which includes filestorage, and use it for uploads.

Not perfect options, but an ok collection triage solutions.

I am using version 1.4.1 and this is now working for me.

Ack, correct behavior confirmed. Thanks!
From: Derek Gabriel<EMAIL_ADDRESS>Sent: Monday, September 10, 2018 3:28 AM
To: Microsoft/AzureStorageExplorer<EMAIL_ADDRESS>Cc: Steve Espinosa<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/AzureStorageExplorer] Cannot upload file from a local OneDrive folder (#96)
I am using version 1.4.1 and this is now working for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAzureStorageExplorer%2Fissues%2F96%23issuecomment-419865469&data=02|01|steveesp%40microsoft.com|f303de92b1c04101dec408d6170823af|72f988bf86f141af91ab2d7cd011db47|1|0|636721721055705575&sdata=3vZgRrqExa4X4RiwF3bafBcwr1%2F1w9Tp96Q%2Fva913vI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAT5jdDQSiPR3D4GaoCsKmq-pcwq6VOjzks5uZj7GgaJpZM4TpduG&data=02|01|steveesp%40microsoft.com|f303de92b1c04101dec408d6170823af|72f988bf86f141af91ab2d7cd011db47|1|0|636721721055705575&sdata=0ZrTk%2BhKEdaOM%2BCK7vosgJxPFoZPO3HNUj9w37rID9s%3D&reserved=0.


ng-src on image tags in firefox and IE10

Using ng-src on an img tag in firefox or IE doesn't work. The src attribute is added however the image never loads in those browsers.
Tested with the 1.2RC using:

IE10 on win7
Firefox 23 on win7
Firefox 24 on OSX

Chrome and Safari render fine. I went through the issues however wasn't sure if any were exactly related to this - possibly similar to angular/angular.js#1352

Same issue, but manually changing the size has not effect for me. Has anyone found a solution yet?


Add support for exponentiation

Addressing #13.
Adds exponentiation to entire pipeline.

[x] scanning
[x] parsing
[x] IR
[x] codgen (doesn't include unit test for codegen)

Currently the exponent can only be a constant but in examples written by @bobbinth in the original discussion also allows the exponent to be a variable (example). Also, I'm wondering if there is any utility to allow more complex expressions as exponent, for example col ^ (m + n). What do you think @grjte?

Similar thought with the complex expressions - I think this should be added when support for parens is added, but for now the only atoms allowed inside the parens should be constants. In the future when variable support is added, we would then allow atoms that are either identifiers or constants, and we'll then need to do more type-checking in the IR (to tell the difference between allowed identifiers like variables and disallowed ones like trace columns)

Actually, thinking about the complexity of excluding variables now when we'll want to include them again later - I don't think it's worth it. I think even in the parens PR we should just keep the exponent rhs as a constant, and support for complex expressions can be added when variables are added (probably v0.2). What do you think?


npm run dev 'relative module was not found'

Case
Help Question
Issue
I got one error while executing dev: "* ./src/main.js in multi ./build/dev-client ./src/main.js"
Info

Operating System: OSX
Node-Version: 8.5.0
npm-Version: 5.4.2

Reproduce
After installing all dependencies -> npm run dev gave this error.

Can anyone reproduce this on OSX?
@unix-root at which folder did you run npm run dev ?

Sorry, it was all my fault, my node_modules folder had many different packages which were not needed. I tried reinstalling, It works great.


require 'rb-readline to avoid ruby 2.4 warnings about Fixnum

Example:
/opt/sensu/embedded/lib/ruby/gems/2.4.0/gems/rb-readline-0.5.3/lib/rbreadline.rb:13: warning: constant ::Fixnum is deprecated

Signed-off-by: Ben Abrams<EMAIL_ADDRESS>

https://github.com/ConnorAtherton/rb-readline/blob/v0.5.3/lib/rbreadline.rb#L13-L15 vs https://github.com/ConnorAtherton/rb-readline/blob/v0.5.5/lib/rbreadline.rb#L13-L15

@tas50 fixed.


Please publish 2.1.5

https://github.com/Semantic-Org/Semantic-UI/releases/tag/2.1.5

Done

@jlukic thank you!
It doesn't seem to be updated on npm: https://www.npmjs.com/package/semantic-ui-css

Ah yes, need to run another script.. ill getcha tomorrow


Texture & Materials Not Exported

@gildor2 from some reason your tool only export the mesh not the texture and materials
this is the only things been found , UE version is 4.16

There's no point to duplicate your forum questions at github
https://www.gildor.org/smf/index.php/topic,6070.msg35475.html#msg35475


DHCP failing to Nokia BNG: bngblaster sends DHCPDISCOVER to siaddr rather than broadcast address

DHCP failing to Nokia BNG: bngblaster sends DHCPDISCOVER to siaddr rather than broadcast address
We are testing bngblaster version 0.70 with IPoE sessions to a Nokia 7750 BNG (although the same behaviour/issue was also present using bngblaster version 0.6.6).
The BNG accepts the DHCP discover and replies with an offer which from the debugs, is received and processed by the BNG. The BNG however does not send a DHCPACK to bngblaster. The DHCPREQUESTs are retried by bngblaster:
# ./bngblaster -v
GIT:
  REF: main
  SHA: 2ba5a782d72b04f554a64c32cc4cc83c734e00e2
IO Modes: packet_mmap_raw (default), packet_mmap, raw

Apr 06 18:10:25.943151 Resolve network interfaces
Apr 06 18:10:25.943282 All network interfaces resolved
Apr 06 18:10:25.943320 DHCP (ID: 1) Start DHCP
Apr 06 18:10:25.948432 DHCP (ID: 1) DHCP-Discover send
Apr 06 18:10:26.032631 DHCP (ID: 1) DHCP-Offer received
Apr 06 18:10:26.035857 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:31.037336 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:36.041096 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:41.044076 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:46.048311 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:51.049583 DHCP (ID: 1) DHCP-Request send
Apr 06 18:10:56.050670 DHCP (ID: 1) DHCP-Request send
Apr 06 18:11:01.051205 DHCP (ID: 1) DHCP-Request send
Apr 06 18:11:06.056436 DHCP (ID: 1) DHCP-Request send
Apr 06 18:11:11.060699 DHCP (ID: 1) DHCP-Request send
Apr 06 18:11:16.060872 DHCP (ID: 1) Stop DHCP
Apr 06 18:11:16.060967 DHCP (ID: 1) Start DHCP
Apr 06 18:11:16.064548 DHCP (ID: 1) DHCP-Discover send
Apr 06 18:11:16.069751 DHCP (ID: 1) DHCP-Offer received
Apr 06 18:11:16.069832 DHCP (ID: 1) DHCP-Request send
Apr 06 18:11:21.074295 DHCP (ID: 1) DHCP-Request send

From a packet capture, the DHCP request is being sent by bngblaster to the siaddr in the received DHCPOFFER (the address <IP_ADDRESS> in the example below):
# tshark -T fields  -e ip.src -e ip.dst  -e _ws.col.Info  -e dhcp.option.dhcp_server_id -e dhcp.ip.server -E header=y -r bngblaster-0.70.pcap dhcp

ip.src  ip.dst  _ws.col.Info    dhcp.option.dhcp_server_id      dhcp.ip.server
<IP_ADDRESS> <IP_ADDRESS> DHCP Discover - Transaction ID 0xe4ffd06c               <IP_ADDRESS>
<IP_ADDRESS>      <IP_ADDRESS>    DHCP Offer    - Transaction ID 0xe4ffd06c       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS> <IP_ADDRESS>     DHCP Request  - Transaction ID 0xe4ffd06c       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS> <IP_ADDRESS>     DHCP Request  - Transaction ID 0xe4ffd06c       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS> <IP_ADDRESS>     DHCP Request  - Transaction ID 0xe4ffd06c       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS> <IP_ADDRESS>     DHCP Request  - Transaction ID 0xe4ffd06c       <IP_ADDRESS>     <IP_ADDRESS>

RFC 2131 section 3.1 says

the DHCPREQUEST message MUST use the same value in the DHCP message header's 'secs' field and be sent to the same IP broadcast address as the original DHCPDISCOVER message.

RFC 2131 Section 2 defines the intrepretation of the siaddr as:

the  address of the server to use in the next step of the client's bootstrap process.  A DHCP server may return its own address in the  'siaddr' field, if the server is prepared to supply the next   bootstrap service (e.g., delivery of an operating system executable  image).  A DHCP server always returns its own address in the 'server  identifier' option.

The above seems to imply that the behaviour should be to send the request to the broadcast address and not to the siaddr.
If the source code is changed to send the DHCP Request to the broadcast address, the DHCP transaction is successful and the session is established.
Diff:
$ git diff
diff --git a/code/bngblaster/src/bbl_tx.c b/code/bngblaster/src/bbl_tx.c
index b2b7ea2..c7bdd50 100644
--- a/code/bngblaster/src/bbl_tx.c
+++ b/code/bngblaster/src/bbl_tx.c
@@ -1367,6 +1367,8 @@ bbl_encode_packet_dhcp(bbl_session_s *session) {
             dhcp.type = DHCP_MESSAGE_REQUEST;
             session->stats.dhcp_tx_request++;
             LOG(DHCP, "DHCP (ID: %u) DHCP-Request send\n", session->session_id);
+           eth.dst = (uint8_t*)broadcast_mac;
+            ipv4.dst = IPV4_BROADCAST;
             dhcp.option_address = true;
             dhcp.address = session->dhcp_address;
             dhcp.option_server_identifier = true;

Logs:
Apr 06 17:48:53.339912 Resolve network interfaces
Apr 06 17:48:53.340028 All network interfaces resolved
Apr 06 17:48:53.340059 DHCP (ID: 1) Start DHCP
Apr 06 17:48:53.341119 DHCP (ID: 1) DHCP-Discover send
Apr 06 17:48:53.428681 DHCP (ID: 1) DHCP-Offer received
Apr 06 17:48:53.433917 DHCP (ID: 1) DHCP-Request send
Apr 06 17:48:53.439157 DHCP (ID: 1) DHCP-ACK received
Apr 06 17:48:53.449498 ALL SESSIONS ESTABLISHED

Packet trace
# tshark -T fields  -e ip.src -e ip.dst  -e _ws.col.Info  -e dhcp.option.dhcp -e dhcp.option.dhcp_server_id -e dhcp.ip.server -E header=y -r ./bngblaster-0.70-broadcast.pcap dhcp
ip.src  ip.dst  _ws.col.Info    dhcp.option.dhcp        dhcp.option.dhcp_server_id      dhcp.ip.server
<IP_ADDRESS> <IP_ADDRESS> DHCP Discover - Transaction ID 0x31725964       1               <IP_ADDRESS>
<IP_ADDRESS>      <IP_ADDRESS>   DHCP Offer    - Transaction ID 0x31725964       2       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS> <IP_ADDRESS> DHCP Request  - Transaction ID 0x31725964       3       <IP_ADDRESS>     <IP_ADDRESS>
<IP_ADDRESS>      <IP_ADDRESS>   DHCP ACK      - Transaction ID 0x31725964       5       <IP_ADDRESS>     <IP_ADDRESS>

json:
{
    "interfaces": {
        "qdisc-bypass": true,
        "io-mode": "packet_mmap_raw",
         "network": {
         "interface": "ens160.2016",
         "address": "<IP_ADDRESS>",
         "gateway": "<IP_ADDRESS>"
        },
        "access": [
        {
            "interface": "ens224f1",
            "type": "ipoe",
            "qinq": "false",
            "outer-vlan-min": 2016,
            "outer-vlan-max": 2048,
            "inner-vlan-min": 2,
            "inner-vlan-max": 4094,
            "ipv4": true,
            "ipv6": false,
            "vlan-mode": "1:1"
        }
     ]
    },
    "sessions": {
        "count": 1,
        "session-time": 0,
        "max-outstanding": 16000,
        "start-rate": 1000,
        "stop-rate": 1000
    },
    "ipoe-line": {
            "ipv4": true,
            "arp-timeout": 5,
            "arp-interval": 300,
            "ipv6": false
    },
    "access-line": {
        "agent-remote-id": "ABCDEFGHIJKLMNOP",
        "agent-circuit-id": "<IP_ADDRESS>/<IP_ADDRESS> eth 0:{session-global}"
    },
    "dhcp": {
        "enable": true
    },
    "dhcpv6": {
        "enable": true,
        "_enable": false,
        "rapid-commit": true
    },
   "session-traffic": {
        "ipv4-pps": 1,
        "ipv6-pps": 1,
        "ipv6pd-pps": 1
    }
}

Not a bug.
Issue resoved by setting broadcast flag to true in config:
    "dhcp": {
        "broadcast": true,
        "enable": true
    },

Thanks for your feedback which is valuable input for the documentation!
https://rtbrick.github.io/bngblaster/