[SPARK-7407][MLLIB] use uid + name to identify parameters

A param instance is strongly attached to an parent in the current implementation. So if we make a copy of an estimator or a transformer in pipelines and other meta-algorithms, it becomes error-prone to copy the params to the copied instances. In this PR, a param is identified by its parent's UID and the param name. So it becomes loosely attached to its parent and all its derivatives. The UID is preserved during copying or fitting. All components now have a default constructor and a constructor that takes a UID as input. I keep the constructors for Param in this PR to reduce the amount of diff and moved parent as a mutable field.
This PR still needs some clean-ups, and there are several spark.ml PRs pending. I'll try to get them merged first and then update this PR.
@jkbradley

Merged build triggered.

Merged build started.

Test build #32277 has started for   PR 6019 at commit a4794dd.

Test build #32277 has finished for   PR 6019 at commit a4794dd.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32277/
Test FAILed.

Build triggered.

Build started.

Test build #32285 has started for   PR 6019 at commit aa4a611.

Test build #32285 has finished for   PR 6019 at commit aa4a611.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class Pipeline(override val uid: String) extends Estimator[PipelineModel]
final class DecisionTreeClassifier(override val uid: String)
final class GBTClassifier(override val uid: String)
class LogisticRegression(override val uid: String)
final class RandomForestClassifier(override val uid: String)
class BinaryClassificationEvaluator(override val uid: String)
final class Binarizer(override val uid: String)
class ElementwiseProduct(override val uid: String)
class HashingTF(override val uid: String) extends UnaryTransformer[Iterable[_], Vector, HashingTF]
final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase
class Normalizer(override val uid: String) extends UnaryTransformer[Vector, Vector, Normalizer]
class OneHotEncoder(override val uid: String)
class PolynomialExpansion(override val uid: String)
class StandardScaler(override val uid: String) extends Estimator[StandardScalerModel]
class StringIndexer(override val uid: String) extends Estimator[StringIndexerModel]
class Tokenizer(override val uid: String) extends UnaryTransformer[String, Seq[String], Tokenizer]
class RegexTokenizer(override val uid: String)
class VectorAssembler(override val uid: String)
class VectorIndexer(override val uid: String) extends Estimator[VectorIndexerModel]
final class Word2Vec(override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase
class Param[T](val parent: String, val name: String, val doc: String, val isValid: T => Boolean)
class DoubleParam(parent: String, name: String, doc: String, isValid: Double => Boolean)
class IntParam(parent: String, name: String, doc: String, isValid: Int => Boolean)
class FloatParam(parent: String, name: String, doc: String, isValid: Float => Boolean)
class LongParam(parent: String, name: String, doc: String, isValid: Long => Boolean)
class BooleanParam(parent: String, name: String, doc: String) // No need for isValid
class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams
final class DecisionTreeRegressor(override val uid: String)
final class GBTRegressor(override val uid: String)
class LinearRegression(override val uid: String)
final class RandomForestRegressor(override val uid: String)
class CrossValidator(override val uid: String) extends Estimator[CrossValidatorModel]
trait Identifiable

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32285/
Test FAILed.

Build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #32306 has started for   PR 6019 at commit 629d402.

Test build #32306 has finished for   PR 6019 at commit 629d402.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Pipeline(override val uid: String) extends Estimator[PipelineModel]
final class DecisionTreeClassifier(override val uid: String)
final class GBTClassifier(override val uid: String)
class LogisticRegression(override val uid: String)
final class RandomForestClassifier(override val uid: String)
class BinaryClassificationEvaluator(override val uid: String)
final class Binarizer(override val uid: String)
class ElementwiseProduct(override val uid: String)
class HashingTF(override val uid: String) extends UnaryTransformer[Iterable[_], Vector, HashingTF]
final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase
class Normalizer(override val uid: String) extends UnaryTransformer[Vector, Vector, Normalizer]
class OneHotEncoder(override val uid: String)
class PolynomialExpansion(override val uid: String)
class StandardScaler(override val uid: String) extends Estimator[StandardScalerModel]
class StringIndexer(override val uid: String) extends Estimator[StringIndexerModel]
class Tokenizer(override val uid: String) extends UnaryTransformer[String, Seq[String], Tokenizer]
class RegexTokenizer(override val uid: String)
class VectorAssembler(override val uid: String)
class VectorIndexer(override val uid: String) extends Estimator[VectorIndexerModel]
final class Word2Vec(override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase
class Param[T](val parent: String, val name: String, val doc: String, val isValid: T => Boolean)
class DoubleParam(parent: String, name: String, doc: String, isValid: Double => Boolean)
class IntParam(parent: String, name: String, doc: String, isValid: Int => Boolean)
class FloatParam(parent: String, name: String, doc: String, isValid: Float => Boolean)
class LongParam(parent: String, name: String, doc: String, isValid: Long => Boolean)
class BooleanParam(parent: String, name: String, doc: String) // No need for isValid
class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams
final class DecisionTreeRegressor(override val uid: String)
final class GBTRegressor(override val uid: String)
class LinearRegression(override val uid: String)
final class RandomForestRegressor(override val uid: String)
class CrossValidator(override val uid: String) extends Estimator[CrossValidatorModel]
trait Identifiable

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32306/
Test PASSed.

Merged build finished. Test PASSed.

@mengxr Do we really need to have Param store a string for a parent instead of the actual parent?  I rather liked being able to say "lr.maxIter" and have it print out a full explanation.  I figured we could convert the parent to a string when the Param needed to be applied.

Btw, is this still a WIP, and if so, what else do you plan to put into this PR?

@jkbradley If a Param is identified by the parents' uid and its name, Param.toString shouldn't output the default value and user-supplied value for a particular parent, since a param is not attached to a single parent but also its derivatives. I think this is all I want to add into this PR. I was waiting for the OneVsRest to go in first and update this.

Right, that makes sense.  OK, I'll check the OneVsRest PR now.

Merged build triggered.

Merged build started.

Test build #32478 has started for   PR 6019 at commit 697fdf9.

Test build #32478 has finished for   PR 6019 at commit 697fdf9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32478/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #32560 has started for   PR 6019 at commit 5db5325.

Merged build triggered.

Merged build started.

Test build #32561 has started for   PR 6019 at commit 83a163c.

Merged build triggered.

Merged build started.

Test build #32562 has started for   PR 6019 at commit 409ea08.

Test build #32560 has finished for   PR 6019 at commit 5db5325.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Pipeline(override val uid: String) extends Estimator[PipelineModel]
final class DecisionTreeClassifier(override val uid: String)
final class GBTClassifier(override val uid: String)
class LogisticRegression(override val uid: String)
final class OneVsRest(override val uid: String)
final class RandomForestClassifier(override val uid: String)
class BinaryClassificationEvaluator(override val uid: String)
final class Binarizer(override val uid: String)
final class Bucketizer(override val uid: String)
class ElementwiseProduct(override val uid: String)
class HashingTF(override val uid: String) extends UnaryTransformer[Iterable[_], Vector, HashingTF]
final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase
class Normalizer(override val uid: String) extends UnaryTransformer[Vector, Vector, Normalizer]
class OneHotEncoder(override val uid: String)
class PolynomialExpansion(override val uid: String)
class StandardScaler(override val uid: String) extends Estimator[StandardScalerModel]
class StringIndexer(override val uid: String) extends Estimator[StringIndexerModel]
class Tokenizer(override val uid: String) extends UnaryTransformer[String, Seq[String], Tokenizer]
class RegexTokenizer(override val uid: String)
class VectorAssembler(override val uid: String)
class VectorIndexer(override val uid: String) extends Estimator[VectorIndexerModel]
final class Word2Vec(override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase
class Param[T](val parent: String, val name: String, val doc: String, val isValid: T => Boolean)
class DoubleParam(parent: String, name: String, doc: String, isValid: Double => Boolean)
class IntParam(parent: String, name: String, doc: String, isValid: Int => Boolean)
class FloatParam(parent: String, name: String, doc: String, isValid: Float => Boolean)
class LongParam(parent: String, name: String, doc: String, isValid: Long => Boolean)
class BooleanParam(parent: String, name: String, doc: String) // No need for isValid
class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams
final class DecisionTreeRegressor(override val uid: String)
final class GBTRegressor(override val uid: String)
class LinearRegression(override val uid: String)
final class RandomForestRegressor(override val uid: String)
class CrossValidator(override val uid: String) extends Estimator[CrossValidatorModel]
trait Identifiable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32560/
Test FAILed.

Test build #32561 has finished for   PR 6019 at commit 83a163c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32561/
Test FAILed.

Test build #32562 has finished for   PR 6019 at commit 409ea08.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32562/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32579 has started for   PR 6019 at commit 873caca.

Test build #32579 has finished for   PR 6019 at commit 873caca.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Pipeline(override val uid: String) extends Estimator[PipelineModel]
final class DecisionTreeClassifier(override val uid: String)
final class GBTClassifier(override val uid: String)
class LogisticRegression(override val uid: String)
final class OneVsRest(override val uid: String)
final class RandomForestClassifier(override val uid: String)
class BinaryClassificationEvaluator(override val uid: String)
final class Binarizer(override val uid: String)
final class Bucketizer(override val uid: String)
class ElementwiseProduct(override val uid: String)
class HashingTF(override val uid: String) extends UnaryTransformer[Iterable[_], Vector, HashingTF]
final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase
class Normalizer(override val uid: String) extends UnaryTransformer[Vector, Vector, Normalizer]
class OneHotEncoder(override val uid: String)
class PolynomialExpansion(override val uid: String)
class StandardScaler(override val uid: String) extends Estimator[StandardScalerModel]
class StringIndexer(override val uid: String) extends Estimator[StringIndexerModel]
class Tokenizer(override val uid: String) extends UnaryTransformer[String, Seq[String], Tokenizer]
class RegexTokenizer(override val uid: String)
class VectorAssembler(override val uid: String)
class VectorIndexer(override val uid: String) extends Estimator[VectorIndexerModel]
final class Word2Vec(override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase
class Param[T](val parent: String, val name: String, val doc: String, val isValid: T => Boolean)
class DoubleParam(parent: String, name: String, doc: String, isValid: Double => Boolean)
class IntParam(parent: String, name: String, doc: String, isValid: Int => Boolean)
class FloatParam(parent: String, name: String, doc: String, isValid: Float => Boolean)
class LongParam(parent: String, name: String, doc: String, isValid: Long => Boolean)
class BooleanParam(parent: String, name: String, doc: String) // No need for isValid
class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams
final class DecisionTreeRegressor(override val uid: String)
final class GBTRegressor(override val uid: String)
class LinearRegression(override val uid: String)
final class RandomForestRegressor(override val uid: String)
class CrossValidator(override val uid: String) extends Estimator[CrossValidatorModel]
trait Identifiable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32579/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32594 has started for   PR 6019 at commit 2569168.

Test build #32594 has finished for   PR 6019 at commit 2569168.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Pipeline(override val uid: String) extends Estimator[PipelineModel]
final class DecisionTreeClassifier(override val uid: String)
final class GBTClassifier(override val uid: String)
class LogisticRegression(override val uid: String)
final class OneVsRest(override val uid: String)
final class RandomForestClassifier(override val uid: String)
class BinaryClassificationEvaluator(override val uid: String)
final class Binarizer(override val uid: String)
final class Bucketizer(override val uid: String)
class ElementwiseProduct(override val uid: String)
class HashingTF(override val uid: String) extends UnaryTransformer[Iterable[_], Vector, HashingTF]
final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase
class Normalizer(override val uid: String) extends UnaryTransformer[Vector, Vector, Normalizer]
class OneHotEncoder(override val uid: String)
class PolynomialExpansion(override val uid: String)
class StandardScaler(override val uid: String) extends Estimator[StandardScalerModel]
class StringIndexer(override val uid: String) extends Estimator[StringIndexerModel]
class Tokenizer(override val uid: String) extends UnaryTransformer[String, Seq[String], Tokenizer]
class RegexTokenizer(override val uid: String)
class VectorAssembler(override val uid: String)
class VectorIndexer(override val uid: String) extends Estimator[VectorIndexerModel]
final class Word2Vec(override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase
class Param[T](val parent: String, val name: String, val doc: String, val isValid: T => Boolean)
class DoubleParam(parent: String, name: String, doc: String, isValid: Double => Boolean)
class IntParam(parent: String, name: String, doc: String, isValid: Int => Boolean)
class FloatParam(parent: String, name: String, doc: String, isValid: Float => Boolean)
class LongParam(parent: String, name: String, doc: String, isValid: Long => Boolean)
class BooleanParam(parent: String, name: String, doc: String) // No need for isValid
class ALS(override val uid: String) extends Estimator[ALSModel] with ALSParams
final class DecisionTreeRegressor(override val uid: String)
final class GBTRegressor(override val uid: String)
class LinearRegression(override val uid: String)
final class RandomForestRegressor(override val uid: String)
class CrossValidator(override val uid: String) extends Estimator[CrossValidatorModel]
trait Identifiable

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32594/
Test PASSed.

@mengxr A bunch of small comments, but other than those, it looks good.  At some point, it might be nice to add a test suite helper method which does standard checks to make sure models are handled correctly.  E.g.: take (Estimator, Model, paramMap passed to fit()), and check UID, parent, and parameter values copied to the model.  I'll make a JIRA for that.

Merged build triggered.

Merged build started.

Test build #32681 has started for   PR 6019 at commit c4c8120.

Test build #32681 has finished for   PR 6019 at commit c4c8120.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32681/
Test PASSed.

Merged into master and branch-1.4. I will send another PR for SPARK-7609.


fix: ensure middleware matchers evaluate default locale

Description
Middleware matching is performed at the edge and also in the edge function because there are some patterns we are unable to evaluate at the edge.
When i18n is enabled, the regex generated by Next matches paths with or without a locale in the first segment of the URL path. However, it does not match the specific list of locales and simply matches any string in the first segment.
This is a problem because /test will also match any page at the next level, e.g. /products/test because the matcher assumes products is a locale.
This PR splits URL normalizing and localizing into separate functions, for clarity and type-safety (buildNextRequest now returns a partial NextRequest object), and returns a localizedURL parameter to the middleware matcher so that the above case is avoided by always evaluating the match using the prefixed locale or the default, e.g. /en/products/test.
Tests

Tests have been updated to catch this case

Relevant links (GitHub issues, etc.) or a picture of cute animal
Fixes FRP-761

Superseded by a scaled down version https://github.com/netlify/next-runtime/pull/2555


⚠ Bofrost.nl has degraded performance

In 6b07820, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1207 ms

Resolved: Bofrost.nl performance has improved in fc72738.


check function

I check function like in the previous one would be great ;)

Nevermind 👍

NP :+1:


Add filtered period

When you use delta, the API will not modify the data if the data did not overcome a certain delta value.
I will expect something similar for "period".
If I set value.setReport("5") with period "10" but the 10 seconds have been not passed from the last update then setReport should not update the value.
I also would like to have a "force" command to force the update the Report even if "delta" or "period" are not satisfied. This could be useful if the user wants to trigger a forced refresh of the values without removing delta and period.

@StefanoMartin It is possible to create this behavior by setting delta to a very big number (Inf) then, only the value at the period will be send.


Twisted Leaves does not drop saplings

Minecraft v1.18.1
Forge v39.0.59
Architect's Palette v1.1.0
Twisted Leaves drop itself when it decays instead of a sapling.

Fixed in this commit
Thank you for reporting, will be released in 1.1.1


[FLINK-5867] [FLINK-5866] [flip-1] Implement FailoverStrategy for pipelined regions

This is based on #3772 , the relevant commits are the latter four.
The majority of the work has been done by @tiemsn , with some rebasing and additions from me.
Pipelined Region Failover
As described in FLIP-1, this pull request implements the detection of pipelined regions in the ExecutionGraph and failover within these pipelined regions.

Thanks you @shuai-xu for checking this. Merging this for 1.3, together with the updates proposed by you.
I think we need to initially make a small change that non-pipelined exchanges are NOT boundaries of failover regions, until we have the enhancement in that triggers upstream region restart when a result could not be fetched.


Recursive dependency build option

Implements: #2247

This is marked as a POC, but is also assigned to the 2.4.0 milestone. Do we realistically think we can get this done in the next week, or should we move this to 2.5.0?

I can finalize the code until next week. If you don't have further major concerns regarding the overall solution, we can remove the poc flag.

Yeah. I'd want to do some manual testing before merging, but the code looks good. I left a few minor comments there. I would feel much better if there was a test of the Build command (e.g. TestBuild`)... looks like we didn't implement one back when we wrote this package.

I planned to add some tests at least for the new part anyway.
If the full package/functionality shall be covered this week, I might need other volunteers help. But let's see.

I'll bump this to 2.5.0, since 2.4.0 is shipping in the next couple of days.

Any update on the tests for this?

Unfortunately no. You can bump it further is necessary. Thanks.

Bumping to 2.6

Hi @libesz! Any update on this?

This change is

@libesz We are interested in reviving this for use in kolla-kubernetes. Please let me know if you plan to continue with it or would like some help.

Good to hear that others also think this is useful 😄 . Unfortunately this feature became low priority in our user project, that why I can not step forward on my own.
I accept any help around the testing of the feature. I would happily resolve the conflicts and fix bugs in the code if you create tests for it. But please be aware that maintainers requested tests for the whole package, not only for the new stuff.

@libesz  Oh No! I am sorry. I wasn't meaning to say that it was required that this patch add tests for all the build patterns. I'm sorry for giving that impression. My intention was to express that I felt like we had to do a lot of manual testing because there were not existing tests. I wasn't intending to put you on the hook for fixing that.
I am very sorry for the confusion. I didn't realize I had come across as demanding you do work that was really outside the scope of the PR.

No problem. After re-reading the thread it is not really like that indeed 😄 .
Anyway, if @jascott1 and others would help to set up some frame for testing this PR and related things, that would be cool.

I've filed a relevant issue: https://github.com/kubernetes/helm/issues/2759

Just an update for anyone following this, I have been testing this manually and its looking good. Writing a test for it has been a challenge but I hope to have it completed today.

Ive noticed a difference in the output between no lock file and existing lock file. The final results are the same but user will see different log output where the no lock file does not report the subchart activity.
no lock file
$ helm dep build --recursive
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "test" chart repository (http://<IP_ADDRESS>:8879):
	Get http://<IP_ADDRESS>:8879/index.yaml: dial tcp <IP_ADDRESS>:8879: getsockopt: connection refused
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
	Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: getsockopt: connection refused
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Deleting outdated charts
Saving 1 charts
Downloading drupal from repo https://kubernetes-charts.storage.googleapis.com/
Unpacking: charts/drupal-0.9.2.tgz

clear charts but keep lock
$ rm -rf charts/*

after lock file
$ helm dep build --recursive
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "local" chart repository (http://<IP_ADDRESS>:8879/charts):
	Get http://<IP_ADDRESS>:8879/charts/index.yaml: dial tcp <IP_ADDRESS>:8879: getsockopt: connection refused
...Unable to get an update from the "test" chart repository (http://<IP_ADDRESS>:8879):
	Get http://<IP_ADDRESS>:8879/index.yaml: dial tcp <IP_ADDRESS>:8879: getsockopt: connection refused
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Deleting outdated charts
Saving 1 charts
Downloading drupal from repo https://kubernetes-charts.storage.googleapis.com/
Unpacking: charts/drupal-0.9.2.tgz
Getting requirements recursively for: charts/drupal
Deleting outdated charts
Saving 1 charts
Downloading mariadb from repo https://kubernetes-charts.storage.googleapis.com/
Unpacking: charts/drupal/charts/mariadb-0.7.0.tgz
Getting requirements recursively for: charts/drupal/charts/mariadb
No requirements found in charts/drupal/charts/mariadb/charts

@libesz I have a rebased version of this PR and have worked on the test for this. Were you wanting me to take over the PR or are you interested in continuing on it?

@jascott1 Although I didn't want to ignore and leave it completely to someone else, if you fixed it already, I am happy to let you push it further. Thanks! I don't know how it works on github, though.
Last time I struggled with the new approach what @apeschel suggested. Do we want to go even there or leave it as a future improvement?

Looks like we are going to have to bump this again. @libesz I haven't looked at the code itself, but based on the discussion, I think we should go ahead with this and leave @apeschel's solution for a future improvements. We can bring this in for the next release if so

@thomastaylor312 Okay. Blindly rebased, let's see 😄 .
@jascott1 Could you please add your unit tests?

@libez I regret to say I did not finish the tests as I had some difficulty and ran out of time.  I will revisit as soon as I get a chance but not sure I will get time before the deadline.

@jascott1 np. It is not urgent at least for me. This is already in 2.8.0.

How far along are we on this? We want to cut v2.8 as soon as #3234 is merged, which should be shortly after the holidays. It looks like we're in agreement to move forward with this, but the trail's gone cold. Is there anyone here more familiar with this PR that is willing to rebase and push this PR forward? If not we should knock it off the v2.8 milestone.

/remove-lifecycle stale

we're already far into 2.9's release process (we're on RC4 right now) so this won't make it into 2.9. If anyone wants to take on the effort of writing some unit tests and documentation around this feature that would be the next step to get this merged. :)

bug identified in this PR with a custom client: https://github.com/kubernetes/helm/issues/3974


[ADO Extension] E2E tests

E2E tests were disabled in #844 due to an issue in webpack. When it is resolved, the tests will need to be turned back on.

The GitHub Repo token usage is obsolete, therefor the Accessibility Insights team is going to investigate enabling new E2E tests

I'm moving this backed to blocked. https://github.com/microsoft/azure-pipelines-task-lib updated azure-pipelines-task-lib/mock-test with Node 16 but hasn't release yet. This means that the e2e tests run on Node 10 and then fails when it runs the scan package (which requires Node 16).


jdeps gets executed when jvm args are manually specified

Describe the bug
The app.jvm.modules are fully specified without detect, but the console shows that jdeps scanning failed
To Reproduce
Steps to reproduce the behavior:
fully specify app.jvm.modules without detect
Expected behavior
jdeps does not get executed
Screenshots

Additional context
The process doesn't fail, and subsequent calls seem to be cached, so it's a minor thing.
Internal bug link

This is fixed by Conveyor 2.1


Changing Color on Selction Tool active crashes App

 I couldn't find anything related to this. Even though I think it's not that uncommon to do that.
Lorien version:
Lorien v0.7.0-dev (run viaeditor debug, no build) - I think that's the latest available version
OS/device including version:
Windows 10
Issue description:
It says:
Invalid type in function '_modify_strokes_colors' in base 'Node (SelectionTool)'. The array of argument 1 (Array[Node]) does not have the same element type as the expected typed array argument.
Steps to reproduce:

Select Selection Tool via toolbar in app
Change color
App crashes

Thanks for the report! I just fixed it in 112ff31dea90b2cfddc085ca0be866ccb173f8b2.


Move API_Report folder and files to ROSS_Report repository

ROSS repository won't store the files corresponding to the rotordynamic report anymore, as it's explained in Issue #620.
We should move the API_Report folder (which we have discussed to be renamed) from this repository and to ross_report.
I think PR #613 should be closed and re-opened on ross_report too.

I think there's no need for reopening PR #613 on the report repo, all the changes are already included in the report repository!


Segmentation Fault with<EMAIL_ADDRESS>

Nuitka version, full Python version, flavor, OS, etc. as output by this
command.

1.7.1
Commercial: 2.2.0
Python: 3.10.7 (main, May 29 2023, 13:51:48) [GCC 12.2.0]
Flavor: Debian Python
Executable: /home/almightychang/Workspace/issue_nuitka/.venv/bin/python3
OS: Linux
Arch: x86_64
Distribution: Ubuntu (based on Debian) 22.10
Version C compiler: /usr/bin/gcc (gcc).

How did you install Nuitka and Python

Use python3 venv module to create virtual environment.
Then, installed nuitka 1.7.1 with pip.

The specific PyPI names and versions

attrs==23.1.0
jsonschema==4.18.0
jsonschema-specifications==2023.6.1
Nuitka @ git+https://github.com/Nuitka/Nuitka-commercial.git/@67181e37dde098f2e3be32bf6c356e4bacaad419
ordered-set==4.1.0
referencing==0.29.1
rpds-py==0.8.8
zstandard==0.21.0

Many times when you get an error from Nuitka, your setup may be special
Also supply a Short, Self Contained, Correct, Example

Simple example codes with<EMAIL_ADDRESS>reproduces the error.
from jsonschema import ValidationError, validate

if __name__ == '__main__':
    schema = {
        "type": "object",
        "properties": {
            "price": {
                "type": "number"
            },
            "name": {
                "type": "string"
            },
        },
    }

    validate(instance={"name": "Eggs", "price": 34.99}, schema=schema)
    try:
        validate(
            instance={
                "name": "Eggs",
                "price": "Invalid"
            },
            schema=schema,
        )
    except ValidationError as e:
        print(e.message)
        print(e.absolute_path)
        print(e.absolute_schema_path)

Provide in your issue the Nuitka options used

python3 -m nuitka example.py --show-modules --standalone --output-dir=build

Result
Segmentation fault happens when running the output binary. I think there is some compatibility issues around rust bindings in jsonschema's dependencies.

$ ./build/example.dist/example.bin
[1]    3079998 segmentation fault (core dumped)  ./build/example.dist/example.bin

I managed to reproduce this. I did not before I took your exact requirements, so this is probably something about new (?) versions too.

So, this is a bug of the files implementation of Nuitka, it does a OS_LISTDIR but ignores the error there. When I add that, it gives me this:
FileNotFoundError: [Errno 2] No such file or directory: '/home/hayen/repos/Py2C/Mini.dist/jsonschema_specifications/schemas

I do not recall seeing this package before, they probably factored out the data files, and this is now the first time, this implementation of modern API of Nuitka is hit with a missing data file. Not as a critique, but jsonschema people are very much always on the forefront of using newer APIs. I will add your code to Nuitka-Watch as well once I fixed this.
With --include-package-data=jsonschema_specifications it will not crash. I will be make a hotfix release with the actual fix of the underlying issue, and Yaml configuration that just does what's needed shortly.

I have published it on staging branch, but current factory (and by proxy staging) may be regressive at this point, so I cannot recommend it for your deployment.

Part of the 1.7.2 release.


Map addition and bug fixes

Farm Designer:

Display FarmBot's position in the map when the virtual FarmBot travels beyond the edge of the map.

Coverage increased (+0.02%) to 89.881% when pulling e43e32562fd42f81b68430ac266034e2145ba59e on gabrielburnworth:master into 8f1fef6aeced681b22d494e17a0a65ae821e9cc2 on FarmBot:staging.


clisp: explicitly disable build parallelism due to missing depends

This only causes 146 rebuilds, I think you can just target master.

Good point! Rebased against master.


C# v7.x: async Main

C# 7 feature: converting to a draft PR until we're ready to work on V7

I'm going to try to review this before next week's meeting.

Agreed with Bill's proposal to make this less normative, which side-steps some issues. Jon to propose tweaked wording, Bill will review.

@jskeet
Looks like this one got dropped. It was last assigned to you for wordsmithing. I can pick up the baton for updating the text if you don't have time for it.

I've done a bit more work on this in a fifth commit, but I think we should discuss other areas - the idea that the entry point can return Task<int> is pervasive for the rest, and I think it would be useful if we could describe it just in terms of the what the synthetic entry point does instead.

closing and reopening to re-run all actions.

Agreed on the call.


Clean up utils

Starts the refactoring of the utils.jl functions

There is a problem. I cannot follow the links  to see what you have done, when I click I end up in a wrong page. Can you fix it? Perhaps re-send PR?

For instance, clicking in your first commit, send me to:

https://github.com/andLaing/ATools/issues/10

Which doesn't make any sense...

It's weird, everything's public but it seems to think the commits aren't.
I tried force pushing to no effect so I think I'll close and try to resubmit.


Add support for SDK Resolvers

Sending the PR for some initial feedback. I haven't reviewed it as carefully as I'd like (I'm sure there are nit items), and things I know I still have left to do:

[ ] Test on CoreCLR (haven't tried it yet).
[ ] Further testing within Visual Studio.
[ ] Load resolver(s) in a unit test (didn't have a good way to do this, may have to come later).

@nguerrera

Let me know when packages are available and what version to use.


Versioning

Could you please take care for proper versioning of the app? Currently, all versions identify as
package: name='com.arturkowalczyk300.cryptocurrencyprices' versionCode='1' versionName='1.0'

This not only makes them hard to tell apart, but also complicates automatic updates.
Thanks in advance for considering!

PS: I also wonder what license your app falls under. Apache-2.0, as mentioned here?

Any word, @arturkowalczyk300 ?

Sorry, I didn't see this issue previously.
Thanks for pointing out lack of proper versioning - I fixed it in newest commit and I will keep using it in future releases.
And thing about license - I didn't think about it before, but I see that Apache-2.0 is quite libertarian license - so I can say, it is actual license of this project. Treat this software as open, feel free to re-use it.

Great, thanks! Then let me propose a nice deal: I add your app to my repo now¹ – and you add the license to your repo? :smiley:
¹ Oops, need to wait for the next release, when versioning is fixed :see_no_evil: So once that's done you'll probably close this issue, which should send me a ping, and I'll then add it to my repo :smiley:

Sounds perfect!
I've added license type information to the repository, also I increased version number again and this time forced to publish first app release with specified license. It's here: https://github.com/arturkowalczyk300/android-cryptocurrency-prices/releases/tag/v0.8.4

Deal! Then let's do it. With the next sync around 7 pm UTC, your app should show up here. As F-Droid repos aim for maximum transparency, it currently carries two so-called anti-features, at least one of which is easy to get rid of:

ApplicationDebuggable: your APKs are currently compiled for debug. Not a big deal, but you can easily turn that off if you wish (my updater then will automatically inform me to remove that anti-feature)
NonFreeNet: for the source of the prices. This is a quite common anti-feature (you can use the filters on the main page to find other apps) and rather a hint than a warning – so nothing to really be bothered about. Should the service you use be fully FOSS, that can be removed of course.

To get an idea how the listing will look like, here's a screenshot from the staging area:

Now if you wish:

you can pick a badge to link to the listing e.g. from your Readme :smiley:
I can send you the metadata I've set up via PR in Fastlane format so you can control how your app is presented (description & graphics) or even extend it with more details (like per-release changelogs); be welcome to my Fastlane Cheat Sheet for guidance then.

Thanks a lot for the fast adjustments! If you consider everything solved, feel free to close this issue. Sending Fastlane would mean a new one (aka PR) anyway – and the related details could be discussed there.

@Wjxfi because all releases are marked pre-releases, so my updater usually skips them. Thanks for the ping; as there's no single "stable release" yet I've told my updater to not ignore them. Manually triggered an update to confirm: works, it immediately fetched v0.9.2, which will become available with the next sync around 6 pm UTC.


Add explicit bean name and remove the value in sharedAgentTaskExecutor bean

Coverage remained the same at 93.904% when pulling 59dd7deb61d26cb9858b8e26263e00ff3b955133 on nvhoang:anguyen-shared-exec into 046eb6f70412b24688eb6a6fbeb0eb5ac95c8964 on Netflix:master.


Dockerfile: use Go 1.5.3

Go 1.5.2 is known to have security vulnerabilities in the standard
library. As such, we should use 1.5.3.
Signed-off-by: Aleksa Sarai<EMAIL_ADDRESS>

thx


Iss 686 replaced tqdm to rich package progress bar

Summary of changes (Bug fix, feature, docs update, ...)
This PR adds progress bars to the code using the rich package.

Please check if the PR fulfills these requirements

[x] Closes #686  (Replace xxxx with the Github issue number)
[x] Tests added and passed if fixing a bug or adding a new feature
[x] All code checks passing - black --line-length 110 run over code, mypy and flake8 not showing any errors
[x] Documentation and tutorials updated/added
[ ] Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
[x] Added any new requirements to requirements.txt and recipes/meta.yaml

Codecov Report

Merging #718 (e6849b9) into devel (fe38ee3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##            devel     #718   +/-   ##
=======================================
  Coverage   33.56%   33.57%
=======================================
  Files         175      175
  Lines       13877    13874    -3
=======================================
  Hits         4658     4658
+ Misses       9219     9216    -3

Impacted Files
Coverage Δ

openghg/__init__.py
0.00% <0.00%> (ø)

openghg/analyse/_scenario.py
0.00% <0.00%> (ø)

openghg/store/_obssurface.py
0.00% <0.00%> (ø)

openghg/store/_populate.py
0.00% <0.00%> (ø)

openghg/util/_download.py
0.00% <0.00%> (ø)

openghg/util/_versions.py
0.00% <ø> (ø)

Just to check: are the no progress bars for standardise_surface now? Or do they automatically somehow? (The "read_file" function that doesn't have tqdm anymore is basically what is called for standardise_surface.) I seem to remember @SutarPrasad you asked me to check this, but maybe we had problems with the tutorial?

@SutarPrasad @brendan-m-murphy @gareth-j Are we ready to merge this?


feat(pipelines): Add pipeline groups layout

What
Closes #155
Closes RHOAIENG-4186
Description
Adds a DagreGroupsLayout and PipelineDagreGroupsLayout which treats each group as its own layout. Groups are connected to tasks or other groups.
Type of change

[x] Feature

Screen shots / Gifs for design review
Horizontal

Vertical

/cc @andrewballantyne
Surge
https://pipeline-groups.surge.sh/

Question: You have a colour shift for the internal groups -- does this mean there are only allowed one layer of groups inside groups? If not, what does it look like if another group is inside the inner group?

Question: You have a colour shift for the internal groups -- does this mean there are only allowed one layer of groups inside groups? If not, what does it look like if another group is inside the inner group?

@andrewballantyne the group background alternates:

Wondering it if would make sense to update the default label positioning to "top"

@jenny-s51 Moved them to the top for vertical layout (this is in the app code not the toolkit)

Design wise this lgtm -- I didn't dive into the code.


Dependant queries

Describe the bug
Dependant queries leave an in between state after the first query has succeeded where the first query has a successful status and the following query is still in idle.
To Reproduce
const queryA = useQuery("queryA", fetchSomething);
const queryB = useQuery("queryB", fetchSomethingElse, { enabled: queryA.isSuccess });

console.log(queryA.status, queryB.status);

// loading idle
// success idle
// success loading

Expected behavior
I expect there to be no inbetween state and for queryB to go into a loading state as soon as queryA has succeeded. Expected console log would be:
// loading idle
// success loading
// success success

Desktop (please complete the following information):

OS: macOS Catalina
Chrome
Version: 3.2.0

This is purely because we use safe side effects as opposed to mutating or altering state during a render. If we were to do the opposite, you’d get some really really strange behavior, especially if and when you start using suspense.
Curious why this is an issue for you?

This is purely because we use safe side effects as opposed to mutating or altering state during a render. If we were to do the opposite, you’d get some really really strange behavior, especially if and when you start using suspense.
Curious why this is an issue for you?

Well, with something like this you end up seeing the loader flash, but perhaps there is some easy workaround that im missing?
<Loader visible={queryA.isLoading || queryB.isLoading} />

Hmm. I’ll take a deeper look.

I checked against v2.26.4 prints:
loading idle
success loading
success loading
success success

(success loading is printed twice). also, every window re-focus prints success success 3 times, so there seem to be 3 re-renders. repro: https://codesandbox.io/s/charming-frog-kz4cd
v3.2.0 prints, as OP says:
loading idle
success idle
success loading

every window re-focus also prints success success 3 times (not sure if this is a separate issue?)
repro: https://codesandbox.io/s/focused-hertz-yi541

The returned values from the hooks in v3 are read from the component state instead of directly from the observer. This will make sure no state update is skipped. So when using a hook, you can be sure you will be notified of all changes. I guess this could be important when dealing with side effects. The downside of this though, is that no state update is skipped ;) When rendering, the observer might already contain a newer state, which could be used instead of the component state, but any states in between will then never be rendered.

so how would we go about queryA.isLoading || queryB.isLoading ? I think this is a very valid use-case when dealing with dependent queries

I guess the only way to prevent this is to immediately returning the updated value instead of waiting for the state to update. Let me see what I can do here.

Cheers guys!


add support for formatting files in subdirectories of tests

Resolves #1820
The idea of the approach is that if at least one of the packages that's going to be formatted contains a test target, then look for files within subdirectories of the tests directory for that package. If there were any found, then those are passed (along with the typical src_path for each of the package targets) to rustfmt.
I've tested it with a mix of repositories, format strategies, etc., including on clippy to validate. AFAICT it is working as desired.
Opening this in draft to see whether folks think this might be a viable approach, if so I'll add some tests and do a bit of cleanup. It's not perfect, but my hope is that it's better than not having any support for these files at all.
To test this with clippy (or any other repo that has nested files under tests as described in #1820), create a formatting error in one of those nested files (I butchered tests/ui-toml/bad_toml/conf_bad_toml.rs for my below examples, make sure you add tests/ui/crashes/ice-3891.rs to the rustfmt.toml ignore config)
Without the new flags, no checking of nested files and no isses
$ cargo +nightly fmt -- --check

With the new flags:
$ cargo +nightly fmt --include-nested-test-files -- --check
Diff in rust-clippy/tests/ui-toml/bad_toml/conf_bad_toml.rs at line 1:
 // error-pattern: error reading Clippy's configuration file

-fn main()           {
-
-        }
+fn main() {}

I've made this an opt-in feature via a new flag for cargo fmt (--include-nested-test-files) given that this has the potential to introduce new formatting issues for folks (checking/formatting files that may have never been checked). We could potentially invert that (perhaps with 2.0?) to make this the default behavior with an opt-out flag as well.
I also added a cargo fmt option to allow for listed nested files under tests to be ignored. The ignore config option also works for excluding files in subdirs within tests, but I was having an issue with one of the ice files in the clippy repo that was still happening even with that file set in the rustfmt.toml ignore setting 🤷♂
Edit: #3782 eliminated the need for this duplicative ignore cli arg

Do you mean that formatting the file causes rustfmt to crash?

Correct. Without excluding that file from being passed to rustfmt in the first place, I always get the below error:
error: invalid suffix `x` for integer literal
 --> rust-clippy/tests/ui/crashes/ice-3891.rs:3:5
  |
3 |     1x;
  |     ^^ invalid suffix `x`
  |
  = help: the suffix must be one of the integral types (`u32`, `isize`, etc)

It looks like they were explicitly ignoring that file over in clippy too via their workaround
https://github.com/rust-lang/rust-clippy/blob/master/clippy_dev/src/fmt.rs#L51

Ok, looks like rustfmt is panicking inside the parser while trying to parse the file with invalid syntax.
The file is being parsed even though it is specified in ignore config option because we are filtering files with ignore after the module resolution, which requires parsing the file.
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L101-L109
We should probably pass ignore_path_set to ModResolver and not parse the file that matches to the ignore pattern.

The file is being parsed even though it is specified in ignore config option because we are filtering files with ignore after the module resolution, which requires parsing the file.

Ahh that makes sense, thank you so much! I spent a lot of time trying to figure out if I had a typo in the ignore setting 😄

We should probably pass ignore_path_set to ModResolver and not parse the file that matches to the ignore pattern.

👍 IMO that sounds like a useful change even independent of this PR. I can create a new issue to track that (feel free to assign to me), and will open up a separate PR for that change. In parallel I'll update this PR to remove the ignored-nested-testfiles option over here (which will help simplify things) if that sounds good to you?

👍 IMO that sounds like a useful change even independent of this PR. I can create a new issue to track that (feel free to assign to me), and will open up a separate PR for that change. In parallel I'll update this PR to remove the ignored-nested-test-files option over here (which will help simplify things) if that sounds good to you?

SGTM. Thanks!

CI failures seem unrelated AFAICT. Current master branch is also failing to compile against current nightly. Both this branch and master compile with passing tests against nightly-2019-10-13

I also made an udpate to fail if the user has included the --include-nested-test-files arg but we encounter an IO error while trying to discover those files.
I feel like this is the correct/desired behavior, as we wouldn't want to silently ignore such file discovery errors and give users the (potentially) incorrect impression that those files are formatted correctly.


Update axe version

Expecting this to fail.

Closing this, for details see https://github.com/BrightspaceUI/core/issues/1954


Allow to set image as background of explorer panel

VSCode Version: Any
OS Version: Any

Hi,
So I recently started testing vscode coming from atom, and I'm proooobably here to stay :-P
The one thing I'd like to do is set a background image in the explorer panel.
Nothing fancy, I don't need an easy way to do it.
In fact, it's probably already possible with some fancy CSS file I can drop somewhere?
But Atom lets you do it through themes, so I figured I'd create this ticket for the possibility.
I clicked the "Related projects" link in the guidelines for contributing, and it guided me to the "vs themes" project, but that only seems related to icon themes and syntax themes from what I could tell. So please do excuse me if this is the wrong place for the ticket.
Thank you.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

I don't understand that at all, so there's nothing to thank me for.
https://bugzilla.mozilla.org/show_bug.cgi?id=9940


FEAT: Improve error handling when reading file

Like printing file doesn't exist when file is missing.

(for chapter-12/minigrep)


Response status code does not indicate success: 401 (Unauthorized)

baget.env file:
ApiKey=7def3e24-f496-465b-8abe-798a5d9928b0
Storage__Type=FileSystem
Storage__Path=/var/baget/packages
Database__Type=Sqlite
Database__ConnectionString=Data Source=/var/baget/baget.db
Search__Type=Database

docker run command (docker for windows):
docker run --restart always --env-file ./baget.env -e "ASPNETCORE_URLS=http://*:5000" -d -p 5000:5000 -v bagedata:/var/baget anuraj/baget:latest
push nuget command:
dotnet nuget push -s target_host:5000/v3/index.json -k "7def3e24-f496-465b-8abe-798a5d9928b0" ./my_package.nupkg

push error:
info : Pushing my_package.1.0.0.nupkg to 'target_host:5000/api/v2/package'...
info :   PUT target_host:5000/api/v2/package/
info :   Unauthorized target_host:5000/api/v2/package/ 136ms
error: Response status code does not indicate success: 401 (Unauthorized).

Dashboard available at this address: target_host:5000/

Strange. I haven't had a change to reproduce this, but could you try again using the official image? https://hub.docker.com/r/loicsharma/baget
I'll try running BaGet on docker for Windows later to see if anything weird happens.

Sorry, yes correct docker run command end with loicsharma/baget:latest :)

Awesome! Out of curiosity, how did you choose the anuraj/baget image? Do you have any recommendations to make the official image easier to find?

@loic-sharma just stars and downloads. It might help if you add [Official] to description.

@loic-sharma just first hit in google

If you add docker hub link in README.md it will be more helpfull.

Okay I tweaked the description on Docker hub. I also added a link to the official Docker image on the homepage of the documentation.
I like your idea @rdcm to add a link in the README. Ideally, the entire Docker instructions would be right on the REAMDE, but before I do that, I'd like to streamline the experience a little.


a few fixes + gem re-arranged

Hey David, could we maybe get a release out (I do not have access to the repo) ?
Mostly I've updated akuma.jar (and now it's explicit external dependency jna.jar) to the latest version ... still not perfect but fixes 2.5 issues from the tracker.
I also took the opportunity to remove the .gemspec re-generation thus we can use the gem with bundler's :git option without having to re-generate in-case a file gets added/renamed, hope you don't mind.
// cc @calavera

also I do find it a bit cumbersome to manage and re-package the TrinidadDaemon.java
I've tried replacing it with some (plain-old :)) jruby:
https://github.com/kares/trinidad_daemon_extension/commit/41800c400b9f403aee8bb045c0ab798a5d0ad0dd
seems to be working ... is there any reason for the java version or may I add the commit here ?

hey @kares, I'm sorry but I didn't get any notification when this pull request was created. My only concert about the akuma update is that my fork solved some issues what we found in the pass caused by some assumptions that the original code included, check http://github.com/calavera/Akuma.
:+1: to get rid of the java class and use plain ruby.
I've added you as a owner of the gem, so you can release it, but I'd like to make sure we don't introduce any regression with the upgrade to the new akuma version before.

thanks for the reply David,
I've looked into your fork previously and found this commit:
https://github.com/calavera/Akuma/commit/bfd41ada2922d8de9bcd71a14928dfcb46dd781e
a workaround for akuma which is fixed on master (and some of the later releases) :
https://github.com/kohsuke/akuma/blob/master/src/main/java/com/sun/akuma/Daemon.java#L161-166
other than that my only concern about akuma is that I updated the jna.jar to a newer version than it "officially" declares to support (via it's pom.xml). it seems to be sticked to a 3.0.x version but later releases do fix some issues also reported e.g. #6 ... everything seems to work with the latest jar thus I think I'll release 0.3.0 with it.

Ohh, I just realized that Kosuke added this version of the daemon that doesn't change the current directory:
https://github.com/kohsuke/akuma/blob/master/src/main/java/com/sun/akuma/Daemon.java#L261
If we use that one we can get rid of my fork, I guess.

yy it's the latest one from maven central: http://mvnrepository.com/artifact/org.kohsuke/akuma

@calavera could you pls hook me up with the commit rights for the repo as well :) ?

thanks a lot man - released :)


About metrics reported on NYU and KITTI in Tab.1 and Tab. 4

Hi,
Thanks for sharing the great work!
I have questions regarding the metrics reported on NYU and KITTI in Tab. 1 and Tab. 4.

From Tab. 1, the $\delta_1$ on NYU are 0.925 and  0.944 for CSTM_image and CSTM_label respectively.
From Tab. 4, the $\delta_1$ on NYU are 0.963 and  0.966 for CSTM_image and CSTM_label respectively.

What causes the differences here?  Is it the different backbone used or just the affine-invariant alignment used only in Tab.4 but not Tab. 1?

Thank you for your interest! In tab1. it is metric depth comparison by comparing prediction and GT directly. In tab2. it is relative/affine invariant depth compared, where the median of prediction and GT label is aligned by linear transformation. We will clarify it in our upcoming paper.


Update migration needed

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Description
# Formula#migration_needed?

def migration_needed?
  oldname && !rack.exist? && (dir = HOMEBREW_CELLAR/oldname).directory? &&
    !dir.subdirs.empty? && tap == Tab.for_keg(dir.subdirs.first).tap
end

Return false for each of those cases rather than chaining with && since It makes it much easier to follow.
https://github.com/Homebrew/brew/pull/411#discussion_r69217519
cc @mikemcquaid

👍 other than a few tweaks

Two minor comments regarding distribution of empty lines and terminology, but otherwise :+1:.

LGTM 👍

I agree, hence the merge. The method is now much more readable. :+1:
Merged in fbac41d95bc7d9500eed195b46aba2a95ed89b18. Thank you for another contribution to Homebrew, @vladshablinsky! :tada:


Build code with cosmos

Need
As a developer
I want to build my code using cosmos
So that I don't need an extra setup for bundling my code
And it will increase DX

Deliverables
Cosmos will  bundle the code out of the box without headaches

How would you generate two HTML files and two .js bundles out of a single build task?

I don't think it makes sense using cosmos webpack setup to bundle your personal components. You would have to config webpack for multiple entries and config all your 3rd party libs as externals so they won't get bundled with your components. And would you bundle/build ALL components or just once that have matching fixtures?
I think it's way easier to just add a babel script task and have cosmos and that run at the same time...
// to build
babel src --out-dir lib
// to watch
babel src --out-dir lib --watch

I often use https://www.npmjs.com/package/concurrently when I need to run multiple npm scripts at once...

Cosmos is now a boilerplate and the devServer works for both your dev environment and the playground, based on an --env var.


z-index not working when the dragging container div has overflow:auto property

+1

This is what ng-drag-clone is used for.

me too


main/Bump pwb 2024.04.2

We merged our latest bump to 2024.04.2 to dev instead of main: https://github.com/rstudio/rstudio-docker-products/pull/794
This PR is to pull that commit into main, so that we can get the 2024.04.2 Workbench images out.

I'm re-running the GCW check as it failed on a timeout.
It looks like the R Session Complete Preview & Workbench Daily Preview checks failed during test execution verifying /usr/lib/rstudio-server/bin/code-server/bin/code-server exists - it looks like it's expecting false, but I think this should be true - @ianpittwood is it okay to merge despite these failing checks?

@skyeturriff actually, let's just merge the bump in dev to main. We have pending upgrades for PPM and fixes for the Workbench tests you mentioned in there already.
https://github.com/rstudio/rstudio-docker-products/pull/798


keep previous value when changing type like for value

Is your feature request related to a problem? Please describe.

When changing type, the previous value will be cleared even if you change back

It is quite unpleasant!
Describe the solution you'd like

Keep a cache in composer
Describe alternatives you've considered

Additional context

Similar to https://github.com/microsoft/BotFramework-Composer/issues/1074

Does the undo feature not work for this scenario?

Yes, undo could revert the change.
But I would like a more friendly approach like caching values for different types in the composer and when user changes/tries different types, user could always get the value for that type easily.

cc @sangwoohaan @mareekuh
We need control guidance for the following types

@cwhitten  - Sang is working on this. @sangwoohaan, maybe you can list a short update here?


MSQ: Consider PARTITION_STATS_MAX_BYTES in WorkerMemoryParameters.

This consideration is important, because otherwise we can run out of memory due to large statistics-tracking objects.

We might have to update this line Each sketch uses at most approximately 300 MB in [docs/multi-stage-query/concepts.md]

Pushed an update fixing merge conflicts, updating docs/multi-stage-query/concepts.md, and adjusting logic so the accounting for lookups happens on both controller and worker.

🚀


Typescript custom GlobalState type is not detected

Issue
Following the example at https://github.com/bluebill1049/little-state-machine#-type-safety-ts does not override the GlobalState
Steps to repro:

Created custom typings file in custom-types/global.d.ts
Added custom typings file to the tsconfig.json using typedRoots: ['./custom-typings']
Added the GlobalState declaration

import 'little-state-machine';

declare module 'little-state-machine' {
  interface GlobalState {
    yourDetail: {
      name: string;
    };
  }
}

Typescript throws on action handler definition:

Property 'yourDetail' does not exist on type 'GlobalState'.  TS2339

     8 |   ...state,
     9 |   yourDetail: {
  > 10 |     ...state.yourDetail,
       |              ^
    11 |     ...payload,
    12 |   },
    13 | });

Codesandbox
Please see issue at https://codesandbox.io/s/sad-lamarr-ko811?file=/src/App.tsx

want to take a look at this example: https://codesandbox.io/s/typescript-forked-xs30h

@bluebill1049 Thanks for the pointer. Moving the global.d.ts inside the src directory fixed the issue.

@bluebill1049 Also thank you for creating amazing libraries like LSM and RHF. Love the quality of documentation, examples, and your attention to detail! ❤ 🙏

Thanks, @sshquack for the kind words! my pleasure to help!


ExampleObjectDetection invalid graphDef

Hi i'm trying to get the ExampleObjectionDetection to work.
But i'm running into an error:
Downloading default label map
Unhandled Exception:
TensorFlow.TFException: Invalid GraphDef
at TensorFlow.TFStatus.CheckMaybeRaise (TensorFlow.TFStatus incomingStatus, System.Boolean last) [0x0003b] in :0
at TensorFlow.TFGraph.Import (TensorFlow.TFBuffer graphDef, TensorFlow.TFImportGraphDefOptions options, TensorFlow.TFStatus status) [0x00057] in :0
at TensorFlow.TFGraph.Import (TensorFlow.TFBuffer graphDef, System.String prefix, TensorFlow.TFStatus status) [0x00040] in :0
at ExampleObjectDetection.Program.Main (System.String[] args) [0x00091] in <6c7b5628a7d7430f86f9ae1f679f7ec6>:0
[ERROR] FATAL UNHANDLED EXCEPTION: TensorFlow.TFException: Invalid GraphDef
at TensorFlow.TFStatus.CheckMaybeRaise (TensorFlow.TFStatus incomingStatus, System.Boolean last) [0x0003b] in :0
at TensorFlow.TFGraph.Import (TensorFlow.TFBuffer graphDef, TensorFlow.TFImportGraphDefOptions options, TensorFlow.TFStatus status) [0x00057] in :0
at TensorFlow.TFGraph.Import (TensorFlow.TFBuffer graphDef, System.String prefix, TensorFlow.TFStatus status) [0x00040] in :0
at ExampleObjectDetection.Program.Main (System.String[] args) [0x00091] in <6c7b5628a7d7430f86f9ae1f679f7ec6>:0
How to fix this error?
Thank you in advance.

Does your Debug directory automatically generate the "faster_rcnn_inception_resnet_v2_atrous_coco_11_06_2017" folder? There is an automatically downloaded pb model in the folder.

Having the same issue here. Also with the OOTB .pb models.


.Net: pull

Motivation and Context

Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

@Bryan-Roe Thanks for creating this PR. You haven't provided any information about the context for the changes. Please take a look at our SK Contribution Guidelines. We have different teams working on .Net, Python and Java so I would suggest:

Create issues for the problems that need to be addressed
Our team will handle all build related changes so no need to create PR's for these changes
Create seperate PR's for the .Net, Python and Java for any code related changes you are proposing


Read contacts using Python

Code sample to read contacts using Nylas Python SDK.

I hope this PR meets the contribution requirements and guidelines. If there is a requirement for any modification, please let me know.
Thanks!

Thanks for jumping in @Divyessh.

@relaxedtomato I have already opened the PR, please check it out, and if matches the requirements, please merge it.
Thanks!
PR -> #45

Hi @Divyessh - will take a look shortly. Few comments to address:

I noticed your PR has multiple issues, can we separate create_email_label into a separate PR.
Also, I see you didn't ask to take on this issue.

Hey @relaxedtomato
Thank you for the heads up. I have reverted the last commit and added the readme file for the script. Please review it once.


Extraction of individual Alpha blends from Lightmapped_4WayBlend textures

Hi,
I was wondering if PyVMF is capable of extracting the individual Alpha Values from 4 blended textures using Lightmapped_4WayBlend and insert the Alpha Values for specifc textures of the blend into different displacements using WorldVertexTransition.

I'm very confused about what you're trying to achieve here, what alpha values would you extract from the textures? Where in the displacement do you want to "insert" those alpha values?
PyVMF doesn't do .vmt and .vtf stuff, though it does allow you to change the displacement values.

Im involved in porting Black Mesa maps to SFM and since SFM doesnt support the blending of 4 textures on displacements, these displacements have to be retextured. Right now were just using the dominant texture seen on the displacement however Im curious if PyVMF could extract the blend values of individual texturesfrom the vmfs so that they can be applied to displacements with a texture with a supported material type.
TL;DR: can PyVMF extract the blend data for 4 textures individually, inside the vmfs and apply it to a different vmf?

It's technically possible, but I haven't added support for 4 way textures yet so you would have to write it yourself.


Feature Idea: JSON Diff

What's the Problem?
It would be nice to be able to do a diff of json data.
Solution/Idea
Something similar to http://jsondiff.com/
Alternatives
I've tried http://jsondiff.com/ which I pasted above, and I have also tried some command line based tools.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

DevToys Version
0.0.10 macos
Comments
No response

Hello,
Thanks for the suggestion.
On the Windows app, you can already do this by first using the JSON Formatter (if you need to un-minify a JSON, for example), then using the Text Diff tool.

I see that you mentioned you're using a MacOS app. Please note that this repository is only for the original DevToys app for Windows and that all the app with the same name (and sometime logo) on other platforms are clones that we do not own, don't maintain and aren't responsible for issues encountered with.
I'd be curious to know what app you're using though. :)
Thanks !

@veler : Hi, yes, that's actually a great question... I didn't realize they were actually unrelated repos. The app I'm using is https://github.com/ObuchiYuki/DevToysMac
As for the workaround you presented, that's actually a great idea. Does the json formatter also sort the fields in an object? That's really the only thing it would need to do in order for a text-based diff to work consistently.

@rdavison Sorting like this? :D

I just added it following your comment ;-)
Pull request is available here: https://github.com/veler/DevToys/pull/578
It will be available in the next update for Windows. I have no idea if @ObuchiYuki will update his app. It looks like it's been a while the repository hasn't change and DevToys for Windows keep going its way without waiting for porting on other platforms (since we're not officially support them).


64-bit transaction nonce

I doubt we will ever see a valid transaction with nonce greater than that

Unfortunately this might be possible. The issue is not all chains start their nonce from zero, and we could have someone choosing for example the first bit to be 1. We'd better be able to support that.

And those are non-fringe chains? 256-bit nonce really is making mainstream case pay for what's not used. Geth has 64-bit nonce FWIW.


[Sage 9] - Why use BrowserSync and not webpack-dev-server on <IP_ADDRESS> with a proxy-target?

Would there be any advantages to using webpack-dev-server?
I find BrowserSync works well, has a nice interface and is easy to access from other devices. And, from memory when I worked on the Sage/webpack config, I found webpack-dev-server to be too much oriented toward js app and Sage is not that.

BrowserSync has better features, allows for multiple device testing out of the box, includes a great admin panel for more control and bandwidth throttling which is helpful to test for speed and loading. I see no reason to switch.

Despite the affiliation to Trellis, thanks to Docker for Mac/Windows Beta, a vanilla wordrpess site or even a bedrock config is one command away docker-compose up -d. However, Browsersync is pretty weird to configure inside of docker, webpack is much less so.

@jaredpalmer i haven't yet dug into docker (finally bout to) so i'm not sure what steps are needed in order to get browsersync working with it. can you provide more details?
normally it's recommended to run node on the host machine and not on your vm/dev box. is that not the case with docker?

@jaredpalmer @retlehs I run wordpress in docker, and i just run webpack on the outside. No problem.

@jeger Do you mind sharing your docker-compose.yml file?
If I recall, I was using a very very early version Docker for Mac Beta when I filed this issue when there was a bug in the native file watcher. Regardless, I still think browser-sync is kinda overkill.

If I recall, mine looked like this:
web:
    image: wordpress
    links:
     - mysql
    environment:
     - WORDPRESS_DB_PASSWORD=password
    ports:
     - "8080:80"
    volumes:
     - ./plugins:/var/www/html/wp-content/plugins
     - ./themes:/var/www/html/wp-content/themes
mysql:
    image: mysql:5.7
    environment:
     - MYSQL_ROOT_PASSWORD=password
     - MYSQL_DATABASE=wordpress

@jaredpalmer That would probably explain it, docker now runs much better on MacOS. My Docker files are kinda extensive and actually build from the (VVV)[https://github.com/Varying-Vagrant-Vagrants/VVV] project.
But there should be no problem with the file you pasted here. As far as i can see.
I didn't do anything special to get browsersync working.
Send me a message on twitter if you keep having problems with this tho :)
@Halvardos

@Jeger were you able to see live reload changes with browser-sync and docker? I wasn't able to. It served, but never updated. I also tried vanilla webpack-dev-server but was struggling to figure out the proxy config. I also found out that you have to use a wp filter to disable rel=canonical in order to prevent an auto redirect.
I know that sage is tied to trellis/roots/bedrock, but it's 2016 folks. People want immutable infra and twelve factor apps. IMHO this theme should work with docker-compose out of the box.

@jaredpalmer Did you run browsersync on the outside of the the container?

@jeger yup. Running it from my project root (and shared volume) locally outside any container. I was reading that there is a socket / port issue.
When I get to my office ~ 30min will post the link about the bSync ports. Can also publish a fork so we can talk apples to apples.

@jeger looks like I am also running an older version of sage 9. There has been some work done on the public path stuff recently. Will try again with a current fork. Stay tuned


Proposal: allow users on try.gitea.io to create organizations

Now the users on try.gitea.io can not create organizations.
Many organization related bugs can not be test on try.gitea.io, eg:

https://github.com/go-gitea/gitea/issues/17279
https://github.com/go-gitea/gitea/pull/17807

Might not affect all users, I can for example create orgs.

It was disabled by default due to spammers using it rather than having to pass a captcha and email verification for each spam account they wished to create.
I can enable for your user if you wish.

Oh, if it is done by purpose, that's fine.


bash typo in [docker cp] documentation for tar-piping out of a tmpfs

File: engine/reference/commandline/cp.md, CC @mistyhacks
I think the examples showing how to tar-pipe out of a tmpfs (because you can't docker cp from a tmpfs) are missing ${}. Viz
$ docker exec CONTAINER tar Ccf $(dirname SRC_PATH) - $(basename SRC_PATH) | tar Cxf DEST_PATH -
Should be
$ docker exec CONTAINER tar Ccf $(dirname ${SRC_PATH}) - $(basename ${SRC_PATH}) | tar Cxf ${DEST_PATH} -
and the same for the second example

Hi @JonJagger ! Thanks for this feedback. That syntax for Bash variables is to try to protect against spaces in the paths. If there were a space in a path, it would definitely break without either the curly braces or double quotes. However, the source for this page actually lives in the docker/cli repository. If you raise a PR there and update the examples, they will get into the docs when your change is cherry-picked into a release branch in docker/docker-ce.


Issue: Actions execute pass() whenever passing a policy instead of when passing all policies.

Leads to situations where, for example, passing Constitution Policies multiply.

hm ... this is actually more of a design question on second thought. default behavior is kind of strange but modifying for passing whenever all policies pass also leads to weird scenarios. closing for now.


Suggestion not being added on tapping

I am trying the example shared in Readme.md. When I tap on a suggestion, nothing happens. It is not added to the text. Is it a bug or am I missing something ?

@fayeed Mention Selection not working after certain time, also have miss selection issue, selecting one item select another item

any update on this issue?

Hello, I hope this isn't too late and maybe could help you. For me the fix was to move the Portal widget up in the widget tree. The issue for me was that I had scroll under the suggestions overlay and the tap was moving the scroll widget. So I moved the Portal a little higher and now it works

Hello, I hope this isn't too late and maybe could help you. For me the fix was to move the Portal widget up in the widget tree. The issue for me was that I had scroll under the suggestions overlay and the tap was moving the scroll widget. So I moved the Portal a little higher and now it works

This worked, moving Portal above everything else. Thank you so much, you are a lifesaver.

@amr1tv1rd1 @potecteodor, This isn't really a good solution. The actual issue is that the textfield looses focus while tapping on the suggestions and solution is to wrap the suggestions widget in TextFieldTapRegion, It makes the suggestions part of the textfield and it will no longer loose focus.

Can you give me a sample code please.

https://github.com/fayeed/flutter_mentions/issues/94#issuecomment-1283763645
Can you give me a sample code please.


Update testmsm from 3.8.3 to 3.8.5. Some bugs in msmbuider/tests fixed

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please rerender

@synapticarbors
Dear Sir, may I ask why I cannot merge this update version by myself? Thanks so much!

I'm not sure what you mean by "cannot merge this version update myself". A few things though:

Please do not modify the top-level README manually. That file is generated automatically via changes to meta.yaml and then re-rendering.
Typically you can make modifications to the automatically generated pull requests: https://github.com/conda-forge/testmsm-feedstock/pull/2. I'll do that now as a demonstration.

I'm not sure what you mean by "cannot merge this version update myself". A few things though:

Please do not modify the top-level README manually. That file is generated automatically via changes to meta.yaml and then re-rendering.
Typically you can make modifications to the automatically generated pull requests: testmsm v3.8.5 #2. I'll do that now as a demonstration.

Thank you very much for your suggestion and demonstration! However, I am still a bit curious that after checks, it shows that "Only those with write access to this repository can merge pull requests.", and there is not "merge pull request" button, so I cannot merge it in the end. Also, should I be the contributor of conda-forge/testmsm-feedstock and then I can maintain the package in the future? But I do not know why I am not the contributor of it.

Can you look back through your email from around the time the PR for this was merged in staged-recipes? I seem to remember that the first time you join a conda-forge project, there is an email that gets sent out that you need to confirm joining the team or something like that.

Can you look back through your email from around the time the PR for this was merged in staged-recipes? I seem to remember that the first time you join a conda-forge project, there is an email that gets sent out that you need to confirm joining the team or something like that.

Yes! I am very sorry that I just find that email. It seems like the invitation has been expired. May I join it again? Really sorry about that!

I just tried to retrigger it with https://github.com/conda-forge/testmsm-feedstock/issues/4. Please let me know if that worked.

I just tried to retrigger it with #4. Please let me know if that worked.

It worked! Thank you so much for your kind help and guidance all the time! I really appreciate it!


Patch UCP Azure instructions

Proposed changes
I have moved the warning to ensure a pod-cidr is within an Azure Subnet more obvious.
Unreleased project version (optional)

Related issues (optional)

@dockerpac WDYT?

Ahhh I've just seen you made https://github.com/docker/docker.github.io/pull/8484.
I kept the note within the installation instructions, however now made it bold in a markdown note. The reason I've kept it in the Install UCP section, is because the Pod-Cidr is not defined until down at the top of the page, only within the install section :)

Deploy preview for docsdocker ready!
Built with commit dbda110c4355d4e293334c3483fa2bf3d2aa63cb
https://deploy-preview-8485--docsdocker.netlify.com

Ok that makes sense.
Still I think it should be also noted in the "Prerequisites paragraph" because basically, if i'm not aware of this restriction, i could want to install my nodes in a small vnet, and use the default <IP_ADDRESS>/16 overlay network for pods cidr as in all other docker ee installations.
So for my point of view, with this information in mind, you would know at the design phase (not at the installation phase) that you need to provision a vnet large enough to have your nodes but also all of your pods.
This is explained in details in the paragraph "Considerations for IPAM Configuration", but I think it should be also explicitly put in the "Prerequisites" paragraph

@dockerpac Ok that makes sense, I've added a section specifically calling out the vnet/subnet sizes in the Pre-reqs, and referencing the "Considerations for IPAM Configuration".
WDYT?

👍


Update PVWatts module type options

For the crystalline silicon modules, I suggest updating your options for quality/efficiency of pv module. Currently, the help system identifies the options as:

PVWatts® Module Type
Cell Material
Approximate Nominal Efficiency
Module Cover
Temperature Coefficient of Power

Standard
Crystalline Silicon
15%
Glass
-0.47 %/°C

Premium
Crystalline Silicon
19%
Glass with anti-reflective coating
-0.35 %/°C

Consider updating this table to have Standard and Premium modules that are older and newer. Something like the following:

PVWatts® Module Type
Cell Material
Approximate Nominal Efficiency
Module Cover
Temperature Coefficient of Power

2015 Standard
Crystalline Silicon
14%
Glass
-0.47 %/°C

2020 Standard
16%
Glass with anti-reflective coating
-0.37 %/°C

2015 Premium
17%
Glass with anti-reflective coating
-0.32 %/°C

2020 Premium
20%
Glass with anti-reflective coating
-0.28 %/°C

Or add in an option to enter Beta Voc (and NOCT/NMOT) as part of System Information specs.

CdTe technology and the CIGS technology in efficiency, and they ae both lumped together as “thin film”. And likewise, there is some separation in the monocrystalline PV market between heterojunction vs other device structures in the temperature coefficients.
My request is to add a 4th module type called “custom”, and if that option is specified then there are two new inputs for module efficiency at STC and temperature coefficient of efficiency. I believe that’s all that you need to specify to model it with the simplified pvwatts equations.
This would allow the model to handle other types of modules that don’t match the three predefined technologies, and would somewhat “future-proof” the model since it’s always possible to override the built-in options as the technology evolves.

A couple points on this:

we updated the default panel characteristics in the 2020.2.29 release with version pvwattsv7, with significant input from industry. These new coefficients are shown in help, although we still have to complete an updated technical manual.
the capability to input one's own module characteristics is feature of the detailed PV model within SAM, and has historically been one of our differentiating factors between the two models. That type of capability may or may not be outside of the scope of PVWatts.


Head meta in pages not working first load!

I'm having a problem with head title and meta in pages not working for the first time on the web, but it works after I reload the page, I do not know where the error is for people to help!

Same for me, but I don't change the title for now. So, with a static title, it is cleared once finished first load (at the begining the title shows correctly). The issue doesn't only affect the title, but the htmlAttr too.
Can anyone reopen this issue? @alexchopin

Any updates on this? I have the same problem, althought I saw it on viewsource

I'm having the exact same issue which makes my icons to fail as well at first load (as they are a css linked sourced in the head property of the nuxt.config.js file).
Any found solution? I can't delete the store folder as I'm using it.. (as suggested by @Tajnymag)

We still have this issue. Why was this closed?

+1. Happening to me too.

Further things in #4052
Please add a reproduction repo there.


Remove experimental prefix from Swift SDK command

Since SE-0387 was accepted and available in Swift 5.9 and Swift 5.10, it's time to remove experimental prefix.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test windows

@bnbarham @euanh @kateinoigakukun do you think it's worth keeping old subcommand and argument and make them show a deprecation warning for backwards compatibility?

Yeah I think that'd be nice as long as we hide it from help in general.

Also, it might be a good timing to refine CLI option consistency with others.
e.g.

swift package plugin --list / swift sdk list
swift package config / swift sdk configuration

Not sure about that one, might require a proposal amendment as we've specified commands and their behavior explicitly in the proposal text.

@MaxDesiatov Ok, I created a proposal amendment https://github.com/apple/swift-evolution/pull/2424

IIUC amendments go through the same process as the rest of Swift Evolution. What I mean is that we'd probably have to run this as a pitch first, schedule this for review with the Swift Evolution stakeholders if there's enough positive feedback on the pitch, then run a formal review and follow on the review decision after that.

Given that this is a non-functional and just a naming change, I feel going through the evolution process is too much for this change TBH... I'd like to hear @bnbarham's opinion here.

Given that this is a non-functional and just a naming change, I feel going through the evolution process is too much for this change TBH... But I can follow the process if it's really necessary. I'd like to hear @bnbarham's opinion here.

It'd be worth posting in Evolution | Discussions and seeing if the core team feels a review is required. Interestingly the proposal actually has configure and not configuration, so either way we probably want to do something here.


feat: added method to save JSON manifest to disk

To be merged after https://github.com/PolusAI/polus-plugins/pull/295
Let Plugin represent any instance of any Plugin.
New attributes:

Plugin.manifest: Dictionary representation of the JSON Manifest of the Plugin.

New methods:

Plugin.save_manifest(path, indent (optional, default = 4)): Save manifest as JSON file to the specified path. Optional indent argument defines how many spaces of indentation the file will have.

This will be taken care of in a future PR that includes methods for old and new schemas


Support for /debug:embedded

The compiler is adding support for a new flag on /debug:.  This updates the targets for this feature.
Context of the change: https://github.com/dotnet/roslyn/pull/12711

CC @tmat

CC @nguerrera

:shipit:

:+1:

:+1: Thanks for making this work!


error: attribute 'i686-linux' missing

Context
No response
Bug description
When using the default overlay, I'm seeing the captioned error when trying to nixos-rebuild after upgrading from NixOS 23.11 to 24.05.  I noticed that this pr mentioned the same issue, which was supposed to be fixed by this commit, but unfortunately I'm still seeing it on the latest main branch.
error:
       … while calling the 'head' builtin
         at /nix/store/x6x48p4sc7x620zng1iqx4hikffnp32z-source/lib/attrsets.nix:1575:11:
         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'
         at /nix/store/x6x48p4sc7x620zng1iqx4hikffnp32z-source/lib/modules.nix:809:9:
          808|     in warnDeprecation opt //
          809|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          810|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'i686-linux' missing
       at /nix/store/221mhp3nr67c41c7k4dhxkh9mmh88rhm-source/pkgs/default.nix:11:5:
           10|   in
           11|     self.packages.${system};
             |     ^
           12|

I've managed to work around this for now by patching pkgs/default.nix:
--- a/pkgs/default.nix
+++ b/pkgs/default.nix
@@ -8,7 +8,7 @@
   flake.overlays.default = _final: prev: let
     inherit (prev.stdenv.hostPlatform) system;
   in
-    self.packages.${system};
+    self.packages.${system} or {};

Steps to reproduce

"ethereum-nix.overlays.default" overlay in the NixOS configuration
Upgrade to 24.05
Rebuild

Before submitting

[X] I have attached links to the documentation, and possibly related issues and discussions.

Some messing around with this, it appears to be a bug in NixOS itself. Something like import <nixpkgs> { overlays = [(_: prev: builtins.trace prev.stdenv.hostPlatform.system {} ]; } works perfectly well and prints the correct system. However if you try to make a simple NixOS config containing nixpkgs.overlays with the same debug overlay, with NixOS 23.11 it works as expected however starting in NixOS 24.05, for some reason the hostplatform just gets randomly changed to i686-linux.
I have created an issue on NixOS for this bug https://github.com/NixOS/nixpkgs/issues/325318


Exporting annotator information for each annotation

I tried exporting into CVAT XML and into COCO JSON format. Neither seems to have any information about annotators, i.e., which annotator provided which annotation. I can't find any mention of this in the manual, either. Is this possible and how?

@radoye ,
Could you please give us an example how you want to see the information in an annotation file?

@nmanovic We work mostly with COCO JSON, so let's start the discussion around that one. It should be backward-compatible to simply add another top-level key, e.g., "attributions", and list {"annotation_id": ..., "labeler_id": ..., ...}. In other words, the same indirect structure like the one between "images" and "annotations" in COCO JSON.
For context, we typically overlap jobs in large tasks by a few %. Jobs are randomly assigned and we use majority vote to spot and log outliers.

@radoye , if we generate extra meta information as a separate file it will work? It can be difficult to extend each format (e.g. MOT) with such information. I understand that you are working with COCO but in the tool our team wants to keep more or less general solutions.

For context, we typically overlap jobs in large tasks by a few %. Jobs are randomly assigned and we use majority vote to spot and log outliers.

If you and your team can share your experience with community and contribute some stories or even some features for CVAT it will be awesome.

@nmanovic A separate file would work great. As long as the data can be exported, in any way, merging is trivial. Sure, we can describe our process at some point, as we finish the PRs we already started.

@radoye , at the moment in DB we don't have an annotator for every shape. We have an owner and assignee for a task. As far as I remember the assignee field is dumped into CVAT XML. I think we are not going to add an annotator field for every shape in the future as well. I will close the issue.


NixOS 23.11: Gnome Session Crash

Describe the bug
After upgrading to nixos 23.11, I'm no longer able to start an X11 gnome session. It crashes with the "Oh no! Something has gone wrong" error. Starting a Wayland session works fine.
Steps To Reproduce

Install nixos 23.11.
When logging in choose "Gnome on Xorg"

Expected behavior
Gnome on Xorg should work without any issues just like it does on nixos 23.05.
Screenshots
I couldn't grab a screenshot. All I can see is the "oh no" error.
Additional context
I use an NVIDIA graphics card (GTX 3090).
I managed to grab the following from journalctl: journalctl.txt
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$  nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.65, NixOS, 23.11 (Tapir), 23.11.20231207.b4372c4`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

(I use flakes so I imagine that the "channels" bit above doesn't matter)

Add a :+1: reaction to issues you find important.

Looks like this issue may not be unique to NixOS: https://discussion.fedoraproject.org/t/second-monitor-crashes-gnome-on-x11/84395
I use a tiled monitor so it may be treated as two monitors.

Looks like it could be this issue: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7120

I was able to fix this by adding the patch as an overlay:
  nixpkgs.overlays = [
    (final: prev: {
      gnome = prev.gnome.overrideScope' (gfinal: gprev: {
        mutter = prev.gnome.mutter.overrideAttrs
          (old: { patches = old.patches or [ ] ++ [ ./mutter-patch.patch ]; });
      });
    })
  ];

mutter-patch.patch:
diff --git a/src/backends/x11/meta-monitor-manager-xrandr.c b/src/backends/x11/meta-monitor-manager-xrandr.c
index 128a34b9f..97ba112e8 100644
--- a/src/backends/x11/meta-monitor-manager-xrandr.c
+++ b/src/backends/x11/meta-monitor-manager-xrandr.c
@@ -770,9 +770,11 @@ meta_monitor_manager_xrandr_tiled_monitor_added (MetaMonitorManager *manager,
       xrandr_monitor_info->outputs[i] = meta_output_get_id (output);
     }

+  mtk_x11_error_trap_push (manager_xrandr->xdisplay);
   XRRSetMonitor (manager_xrandr->xdisplay,
                  DefaultRootWindow (manager_xrandr->xdisplay),
                  xrandr_monitor_info);
+  mtk_x11_error_trap_pop (manager_xrandr->xdisplay);
   XRRFreeMonitors (xrandr_monitor_info);
 }

Looks like it is included in 45.3 so once Nix updates to that version this should be no longer needed.

I had a similar issue that was due to my cursor set (phinger-cursors{-light}) not having all required cursor variants. Got rid of it by symlinking all variants that adwaita-cursors has for my cursor set as well, see here in my dotfiles (also includes the error message that showed up in journalctl when crashing). Just leaving this here for others that run into a similar problem :)

It works out of the box now that nixos-23.11 uses mutter 45.3!


Namespace header component

We've already namespaced the search component for use alongside Rizzo and we should do the same for the header component. This also includes all sub-components of the header; logo, navigation, mobile navigation, sub-navigation, avatar and notification badge.
I also think we should consider renaming .header to .global-header in order to make it more specific. It will also allow us to use .header as a more generic header for things such as articles.

How about .lp-global-header? Start using that lp namespace a bit?

That's what I was thinking. Eventually, I think all components will have lp-.

Yeah, I want to constantly be thinking of this too... https://github.com/lonelyplanet/rizzo-next/issues/312


Add support for internal address purpose (and possibly refactor variables)

This adds support for specifying internal address purposes, which is only supported from version 3.28.0 of the google-beta provider, so this requirement is also set in the module.
The module's interface has always been a bit ugly, and it's even uglier now that a new variable has been added. I would love breaking compatibility and putting all internal IP configuration options in a single internal_address_config variable. Upside is a cleaner interface more similar to other modules, downside is one needs to set all three configuration items (null can be used of course) even if a single one needs to be specified.
WDYT?

I like the internal_address_config idea but that will indeed break the interface. Your call ;)
In any case the PR LGTM.


Reset vBatGain calibration

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Set the vBatGain to 1.0 so it is uncalibrated but therefore directly usable in most cases

Version numbers increased @jaenrig-ifx


HTML tags got white color

Have a problem with svelte and HTML files
Every HTML tag got white
Using nvim 0.8.0

hey @Shrimp22 can you pull latest and try again please?

@ellisonleao It works now thank you so much!


View EnumSwitch styling discussion

Hi,
When changing the ButtonVariant property I expected the View EnumSwitch (month, week, day, work week) to also follow the selected variant. I was going to make a PR to do this, but wanted to discuss first as it's a little more complex than just adding a property (since the outlined and filled variants are used to display which view is selected). https://github.com/danheron/Heron.MudCalendar/blob/b1e7f901374564150a7e1a93feab73dc819285d5/Heron.MudCalendar/Components/EnumSwitch.razor#L10C33-L10C34

Instead of using MudButtonGroup we could use: https://www.mudblazor.com/components/togglegroup. However this doesn't use Variants but instead has an outlined property and styles (that could emulate the variants). This is experimental so I understand if you don't want this risk.
Instead of only using Outlined and Filled to represent which view is selected we could instead using some sort of styling or icon to represent which view is selected. For example, bolding the View Text or adding a checkmark next to the selected view while allowing the user to use any of the 3 variants.
Leave as is or other suggestions?

Thank you

Changing to MudToggleGroup would be a good idea when it is released - it is still experimental at the moment.
I think the current version is fine for Filled and Outlined variants because it is kind of a mixture of both and so looks fine with either.  Maybe some changes could be made for the Text variant, but I'm not sure what would look good.


Add accounts service to serum module to getting account information for given public key

Implement an accounts service to the serum module that supports the following solana api calls
https://docs.solana.com/developing/clients/jsonrpc-api#gettokenaccountsbyowner
https://docs.solana.com/developing/clients/jsonrpc-api#getbalance

feel free to ad an pull request