Feature: Setup a default limit for the maxHistory setting of tiller

Could this chart set a default, but configurable, value for the tiller maxHistory setting? This to prevent that the history created by helm/tiller release causes issues by having to many secrets stored. (Feature description: https://github.com/helm/helm/pull/2636)
The plan is that helm will set a default in v3: https://github.com/helm/helm/issues/5157
Then we do not manually need to cleanup the history.

Hi @tverhoeven ,
If you are using the k8s-tiller submodule, you should be able to already configure the tiller max history using the input var tiller_history_max.
If you are instead using kubergrunt helm deploy, then indeed this feature is missing. Can you refile the issue in the kubergrunt repo so we can track it there?

I'm actually using gke-cluster which then calls k8s-tiller. So I guess I need to log a ticket there that max history configuration is exposed.


Input#getRef receives a undefined reference if Icon is used in a floatingLabel Item)

Related issues: #591 #1514
React native 0.55.1, React 16.0.0-alpha.3, NativeBase 2.4.2
Hi,
I have an issue with Input, Item#floatingLabel and Input#getRef.
<Form>
  <Item floatingLabel>
    MyLabel
    <Input getRef={e => console.log(e)} />
    <Icon name="person" />
  </Item>
</Form>

With this simple code, getRef is triggered but e is undefined. Interestingly, if I remove the Icon component, it works fine.
I dug a little bit in the code of Item.js, and I think the problem is caused by the following code:
if (this.props.floatingLabel && icon.length) {
...
  newChildren.push(
     <Input // here, the ref attribute is not defined
          key="l2"
          {...inputProps}
...
} else if (this.props.floatingLabel) {
...
  newChildren.push(
     <Input
          ref={c => (this._inputRef = c)} // here, the ref attribute is defined
          value={this.state.text}
          key="l2"
          {...inputProps}
...
}

I added the missing ref={c => (this._inputRef = c)} in the first block and it solved the problem.

@akhil-geekyants  is it fixed at ? cause it happen with me today? do i have to update to 0.55.3

@akhil-geekyants  How do i make it work? i also update item.js file.. but no effect?

@ZeroCool00 can you post your code

<Form style={styles.inputContainer}>
            <Item
                floatingLabel
                success={this.state.inputEmailSuccess}
                error={this.state.inputEmailError}
                style={{ flexDirection: 'row-reverse' }}
            >

              Email
              <Input
                returnKeyType='next'
                onSubmitEditing={() => { this.password._root.focus(); }}
                onChangeText={(value) => this.setState({ email: value })}
                blurOnSubmit={false}
              />
              <Icon name={this.state.iconName} />
            </Item>

            <Item
              floatingLabel
              success={this.state.inputPasswordSuccess}
              error={this.state.inputPasswordError}
              style={{ flexDirection: 'row-reverse' }}
            >
              Password

              <Input
                getRef={(input) => { this.password = input; }}
                onChangeText={(value) => this.setState({ password: value })}
                secureTextEntry
              />
              <Icon name={this.state.iconName} />
            </Item>
          </Form>

@ZeroCool00 checked this. Fix is working. Attaching a gif
If you are making changes directly in the node_modules/native-base (not recommended), change
"main": "dist/src/index.js",

to
"main": "src/index.js",

in the main node_modules/native-base/package.json
Gif

Its working now.. Thank you for all your support.. I love native-base

@akhil-geekyants  Today i check node-module, every changes i made is all gone.. and all issue is still remain. floating label cut and getRef in keyboard..
How to solve this. do i need to wait until you update version? or there is a way?

@ZeroCool00 You will get the update tomorrow

@SupriyaKalghatgi  ok Thanks

Fixed with 2.4.3


Readme title and description does not talk about the service in auto generated mgmt plane packages

Taking Azure Compute as an example, the auto generated ARM package has the below title in the generated readme

Azure ComputeManagementClient SDK for JavaScript

And the below 1 line description

This package contains an isomorphic SDK for ComputeManagementClient.

For someone landing on this readme either in this repo or on npm, there is no indication as to what this package is used for.
Can we extract these two lines from the readme file with metadata that accompanies the swagger files used to generate these packages? This way the service owners can add the relevant details?
At the very least

The h1 should denote the service name
The description that follows should call out some common use cases
The description should have a link to the service docs

If the code generator supports extracting the above, then the mgmt plane team can look into adding the details to all the services.
cc @diberry who shared the feedback initially
cc @sarangan12, @deyaaeldeen for thoughts on the code generator side
cc @qiaozha for thoughts on the mgmt plane side

Actually. I have the same issues in Azure CLI generation.
Currently, there seems no probably information in the swagger that we can directly use for an overall description of what that service is about.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/cloudService.json#L5 There's is a description in here, but 1. not all the service had this description. 2. most RPs don't take this description seriously, it's inappropriate to use.
@nickzhums @lirenhe Do you think we should require service team to put a brief, valid, meaningful description for their service in swagger ?
About the link to their document.
I totally agree.  Just worried that there's no such mapping rule from doc to rp name in specification folder?

Do you think we should require service team to put a brief, valid, meaningful description for their service in swagger ?

Yes. I believe moving to Track 2 can be an opportunity to require the service teams to provide meaningful data in the swagger.
I have started offline discussions on this and will update this thread once we have a confirmation


--port is not working on the prisma2 studio

prisma2 studio command says that we can pass --port option to change the port it is running on but the flag currently doesn't affect the port number.

I just made a PR that should fix this issue: https://github.com/prisma/lift/pull/255


Add mutli rev support for function describe

fix: #144
In our current describe function we only accept one rev at a time and will try to get a reference for every reference in the repo. It will cost O(MN) in the exp show in which we try to get a ref for every single experiment.

Codecov Report
Base: 82.25% // Head: 81.34% // Decreases project coverage by -0.90% :warning:

Coverage data is based on head (406632a) compared to base (ed17985).
Patch coverage: 96.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   82.25%   81.34%   -0.91%
==========================================
  Files          25       25
  Lines        3353     3367      +14
  Branches      574      370     -204
==========================================
- Hits         2758     2739      -19
- Misses        515      536      +21
- Partials       80       92      +12

Impacted Files
Coverage Δ

src/scmrepo/git/backend/base.py
80.59% <ø> (ø)

src/scmrepo/git/backend/gitpython.py
63.07% <ø> (-1.35%)
:arrow_down:

src/scmrepo/git/backend/pygit2.py
77.31% <ø> (-2.07%)
:arrow_down:

src/scmrepo/git/backend/dulwich/__init__.py
80.94% <87.50%> (-0.49%)
:arrow_down:

src/scmrepo/git/__init__.py
83.72% <100.00%> (+0.21%)
:arrow_up:

tests/test_git.py
100.00% <100.00%> (ø)

src/scmrepo/utils.py
67.74% <0.00%> (-19.36%)
:arrow_down:

tests/conftest.py
86.00% <0.00%> (-9.00%)
:arrow_down:

src/scmrepo/asyn.py
96.55% <0.00%> (-3.45%)
:arrow_down:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@karajan1001, can you please post the new results of the profiling with this patch in the same way that you did on #144?
Also before/after runtime for a real dvc exp show would be great.

@karajan1001, can you please post the new results of the profiling with this patch in the same way that you did on #144?
Also before/after runtime for a real dvc exp show would be great.

In https://github.com/iterative/dvc/pull/8453.  In the same repo, this version of describe runs 5 times faster than the previous one. (With the experiment) grows the difference will be even bigger.


rpc/jsonrpc: Handle unquoted non-json string argument

Closes #666
This PR fixes the handling of unquoted non-json string argument in jsonrpc handler, as described in #666.

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Thanks @stevenferrer for the fix! We're looking into this, give us a bit of time since we have a sizeable backlog we're drilling through.

There is a ParseURI test that is failing: https://github.com/cometbft/cometbft/actions/runs/5046802700/jobs/9106148436?pr=864

#666 is a documentation issue (RPC behavior is consistent across all parameters with internal type string)


feat: add adv_2022_15

Codecov Report

Merging #40 (d530121) into master (3eac350) will decrease coverage by 0.11%.
The diff coverage is 99.40%.

@@             Coverage Diff             @@
##            master      #40      +/-   ##
===========================================
- Coverage   100.00%   99.88%   -0.12%
===========================================
  Files           14       16       +2
  Lines          737      904     +167
  Branches       137      162      +25
===========================================
+ Hits           737      903     +166
- Partials         0        1       +1

Impacted Files
Coverage Δ

solutions/adv_2022_15.py
98.82% <98.82%> (ø)

solutions/adv_2022_14.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Can't initialize GTK backend in function 'cvInitSystem'

Ouput of linux-enable-ir-emitter -v configure
configure command output
haorelian@localhost:~> sudo linux-enable-ir-emitter -v configure
[sudo] password for root:
INFO: Ensure to not use the camera during the execution.
INFO: Warning to do not kill the process !
INFO: Configuring the camera: /dev/v4l/by-path/pci-0000:05:00.3-usb-0:3:1.2-video-index0.
Is the video flashing? Press Y or N
terminate called after throwing an instance of 'cv::Exception'
  what():  OpenCV(4.8.0) /home/runner/work/linux-enable-ir-emitter/linux-enable-ir-emitter/opencv/opencv-4.8.0/modules/highgui/src/window_gtk.cpp:638: error: (-2:Unspecified error) Can't initialize GTK backend in function 'cvInitSystem'

ERROR: The configuration has failed.
INFO: Do not hesitate to visit the GitHub !
INFO: https://github.com/EmixamPP/linux-enable-ir-emitter/blob/master/docs/README.md
haorelian@localhost:~>

Output of v4l2-ctl --list-devices
haorelian@localhost:~> v4l2-ctl --list-devices
Integrated Camera: Integrated C (usb-0000:05:00.3-3):
        /dev/video0
        /dev/video1
        /dev/video2
        /dev/video3
        /dev/media0
        /dev/media1

Ouput of v4l2-ctl -d /dev/videoX --list-formats-ext

v4l2 device output
haorelian@localhost:~> v4l2-ctl -d /dev/video0 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
        Type: Video Capture

        [0]: 'MJPG' (Motion-JPEG, compressed)
                Size: Discrete 1280x720
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 320x180
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 320x240
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 352x288
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 424x240
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 640x360
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 640x480
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 848x480
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 960x540
                        Interval: Discrete 0.033s (30.000 fps)
        [1]: 'YUYV' (YUYV 4:2:2)
                Size: Discrete 640x480
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 320x180
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 320x240
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 352x288
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 424x240
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 640x360
                        Interval: Discrete 0.033s (30.000 fps)
                Size: Discrete 848x480
                        Interval: Discrete 0.050s (20.000 fps)
                Size: Discrete 960x540
                        Interval: Discrete 0.067s (15.000 fps)
                Size: Discrete 1280x720
                        Interval: Discrete 0.100s (10.000 fps)
haorelian@localhost:~> v4l2-ctl -d /dev/video1 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
        Type: Video Capture

haorelian@localhost:~> v4l2-ctl -d /dev/video2 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
        Type: Video Capture

        [0]: 'GREY' (8-bit Greyscale)
                Size: Discrete 640x360
                        Interval: Discrete 0.067s (15.000 fps)
                        Interval: Discrete 0.033s (30.000 fps)
haorelian@localhost:~> v4l2-ctl -d /dev/video3 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
        Type: Video Capture

Output of ls -l /dev/v4l/by-path
haorelian@localhost:~> ls -l /dev/v4l/by-path
total 0
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usb-0:3:1.0-video-index0 -> ../../video0
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usb-0:3:1.0-video-index1 -> ../../video1
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usb-0:3:1.2-video-index0 -> ../../video2
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usb-0:3:1.2-video-index1 -> ../../video3
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usbv2-0:3:1.0-video-index0 -> ../../video0
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usbv2-0:3:1.0-video-index1 -> ../../video1
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usbv2-0:3:1.2-video-index0 -> ../../video2
lrwxrwxrwx 1 root root 12 Oct  7 10:50 pci-0000:05:00.3-usbv2-0:3:1.2-video-index1 -> ../../video3

Give more information if you have
I'm on openSUSE Tumbleweed, installed Howdy and the IR Camera didn't work. I've checked with "ffplay /dev/video2" and IR Camera is too dark and the red light in IR Camera didn't light up. I don't really know what information would be useful, so specify it while asking, thanks.
Additional info

Computer (or camera) model: Lenovo ThinkPad E14 Gen 3
Linux distribution: openSUSE Tumbleweed
Version of linux-enable-ir-emitter: linux-enable-ir-emitter 5.0.2

Addition: I've tried to run it with "sudo DISPLAY=$DISPLAY linux-enable-ir-emitter configure" and switched back to X11 it throws this: Authorization required, but no authorization protocol specified
Authorization required, but no authorization protocol specified
Authorization required, but no authorization protocol specified
Authorization required, but no authorization protocol specified
^CTraceback (most recent call last):
File "/usr/bin/linux-enable-ir-emitter", line 118, in
configure(device, args.manual, args.emitters[0], args.limit[0])
File "/usr/lib64/linux-enable-ir-emitter/command/configure.py", line 49, in configure
exit_code = subprocess.call(
^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/subprocess.py", line 391, in call
return p.wait(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/subprocess.py", line 1264, in wait
return self._wait(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/subprocess.py", line 2046, in _wait
(pid, sts) = self._try_wait(0)
^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/subprocess.py", line 2004, in _try_wait
(pid, sts) = os.waitpid(self.pid, wait_flags)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt

How did you installed linux-enable-ir-emitter? Using the binary provided by this repo?

How did you installed linux-enable-ir-emitter? Using the binary provided by this repo?

Like this: Download the latest linux-enable-ir-emitter-x.x.x.systemd.x86-64.tar.gz here, then execute:
sudo tar -C / --no-same-owner -h -xzf linux-enable-ir-emitter*.tar.gz

Could you try manual building and installation? The instructions are in the README, but if you need help, please don't hesitate.

I've just released a new binary that contains a new version of OpenCV, I don't know if it contains a fix for your problem

Sorry for the very late response. I've tried a bunch of things to make it work, but when it didn't, I just gave up and switched to the Fedora 38 Workstation. Now it works as intended. Once again, sorry for taking your time.


How to set transparent proxy?

How to set  transparent proxy?
Mitmproxy Version:  0.18
Operating System:  centos

Have you reviewed Transparent Proxying and Transparent Proxying -> Linux?

Thanks, @javabrett! Help with these kinds of issues is always appreciated.


Annotator text is recreated into a different form after a selection is made

Text position is sometimes moved after a specific selection is made.

it is caused by resizing the container. cursor stays the same but text is recomputed to fit the new size.


updates all functions to require the use of contexts

Summary by CodeRabbit

Refactor

Enhanced context handling across various database operations, including creation, update, deletion, and retrieval, to ensure consistent context management.

@clowenhg Could you also add context to the U, F and D experimental methods?

I added it to D and U, which perform Delete and Update.
F doesn't directly call into the driver, it only modifies the data in the QuerySet like the other Filter functions.


Clarity on use of Doc extension tools

          I thought we were using the extension tools to manage the construction of the args documentation etc as you had in the original docs PR (and the other similar extension tools). It sounds like this is still in the air though so perhaps we need another discussion issue? What I mean is that yes we have the template but I thought when writing docstrings we would be automating large parts of them using the extension tools to make them less error prone (l;like the arg types).

Originally posted by @seabbs in https://github.com/CDCgov/Rt-without-renewal/pull/117#discussion_r1516594731

My understanding is that we aim for this for type and function docstrings.
The way we get there is using docstringextensions, but descriptions like #Arguments need to go in the DOCSTRING for the template. The types of the arguments are found by TYPEDSIGNATURES.

The way we get there is using docstringextensions, but descriptions like #Arguments need to go in the DOCSTRING for the template. The types of the arguments are found by TYPEDSIGNATURES.

Yes, issue is about using these which wasn't in the PR that this comment was pulled out of.

Noting that the lack of clarity here is starting to lead to increasing amounts of technical debt as some features are being implemented without any documentation and most have different standards being used. We should aim to resolve this ASAP.

I think we have clarity now.
DocStringExtensions.jl provides annotations in the the template macro but not used elsewhere.


Update issue templates

Only was to see where to place the files. I will create another PR with all the Community Standars together


Fixed EditorPlayState Input & Change beat text to section text.

This happened since 0.6 Update , So I fixed Input to prevent miss when spam or press too much keys :)
Oh & I change Beat text to Section text for not confusing too!

yeah but there’s an anti spam for a reason

Hmm That's weird , This doesn't happen in 0.5 - 0.5.2h but I want to make it like PlayState Input

I want to say more thing that when turn off ghost tapping then spam doesn't count miss

I tried it, it's really fixed Thank You 👍

https://user-images.githubusercontent.com/89444135/224872336-fc2a5ded-5183-4d78-82dc-e3f3fdc14d3d.mp4
Ghost Tapping mode

https://user-images.githubusercontent.com/89444135/224872489-769d2841-abb6-4d52-8d70-7ac311e65d4d.mp4
Non Ghost Tapping mode (when hit keys or spam now miss)

What happens if you let a note pass the strumline when ghost tapping is on? My best guess is that you can't miss any notes.

aw man


Add initial support for netdata

This went surprisingly well. I think with the official container, they seem to have catered for the holes that other container creators were experiencing.

@C-J1 Why'd you close this?

I was adding more to the branch on my end. Haven't finished it yet.

Oh ok, cool. Thought you'd changed your mind and binned it :-)
I've been fiddling with some cool stuff this weekend, will push it soon!


test: increase obfuscated provider coverage

Pull Request Test Coverage Report for Build 423038494

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 58.197%

Totals

Change from base Build 415947680:
0.005%

Covered Lines:
11402

Relevant Lines:
19592

💛  - Coveralls


Don't use local eslint unless it's explicitly listed in package.json

If I leave eslint.nodePath set to null (the default), and I edit an NPM project that does not have eslint explicitly listed in its package.json, yet one of its deps includes eslint, then this VSC extension will still use the local eslint rather than the global one. This is not preferred, because then global plugins will not be loaded.

As a work around you can set eslint.nodePath to your global install eslint.

Almost. The code 10 lines above needs to be changed to handle the case that only modules from the nodePath should be considered. Basically this line https://github.com/Microsoft/vscode-eslint/blob/master/server/src/eslintServer.ts#L414 needs to pass in a different directory in the case eslint.nodePath is set to null explicitly. My be we can pass the global install location as well.

Thinking about this again I have the feeling that this needs a setting as well since implementing this is a semantic breakage. Something like 'eslint.requirePackageDependency. The default would be true` to keep the current semantic.
This can not only be derived from nodePath since the resolver also takes global installs into account.


Different Android Studio code completion sorting then in VSCode

This tracker is for issues related to:

Analyzer

Flutter 3.8.0-8.0.pre.8 • channel master • https://github.com/flutter/flutter.git
Framework • revision bfea22db5c (vor 3 Tagen) • 2023-02-08 13:05:54 -0500
Engine • revision bdc5b6b768
Tools • Dart 3.0.0 (build 3.0.0-204.0.dev) • DevTools 2.21.1
Android Studio Plugin Dart Version: 221.6096
Android Studio Plugin Flutter Version72.0.2
In VSCode when you want to access a local variable, print statement etc. it is displayed at the top. But in Android Studio, this isn't the case. In the screenshot attached you see an example, where I want to use the print statement in a onPressed function, but the first suggestion is an Icon, that can't even be used there. Also attached are my code completion settings for android Studio.

@srawlins can you help triage? Tentatively marking area-analyzer - but I am not sure whether it is analyzer or plugin that does sorting.

CC @bwilkerson @jwren
We maybe cannot fix this as Android Studio (I believe) can re-order suggestions away from the order in which DAS sends them.

All the major clients provide their own sort order, though most use a stable sort, so some fraction of items remain in the order we gave them.


"New Function" submenu

Can you add Project Panel -> Right-Click on any folder -> Add - > New Function.
Thanks.

You can easily add the template yourself, go Tools > User Config Files... then look into /Templates folder


JWE encryption is missing base64url-encoded protected header as AEAD

Describe the bug
The JWE protected_header is not protected AEAD as expected by the RFC for JWE.
How to reproduce
n/a
CoCo version information
all
What TEE are you seeing the problem on
Snp
Failing command and relevant log output
No response

Yes. Currently we are using the function encrypt which will automatically append the auth tag to the returned ciphertext. To follow JWE RFC, we'd use encrypt_in_place_detached to explicitly mark the tag into responsed JWE.

Ok. To follow rfc7516, we have the following roadmap

[ ] https://github.com/virtee/kbs-types/pull/44
[ ] https://github.com/confidential-containers/guest-components/pull/820
[ ] https://github.com/confidential-containers/trustee/pull/597


Feature/compression

Hi,
since I was missing the COMP-LZO compression setting in openvpn.conf I added a config parameter "-z" to enable compression if desired.
If compression is set in server, this parameter is also set in client config files.
Bye, Chris

@kylemanna Could you consider merging #67 instead to solve this once and for all?

Hi,
since I am new to working with GIT I hope I did it right. Changed the :z and rebased.
Bye, Chris

Rebased and merged


Display summary statistics on stdout

Is there a way to output the summary statistics of the run on stdout? For example, if I run mistral_7b.yaml, how can I output the statistics on stdout?

you could add something to the end of train_lm if you wanted. wandb dumps something to stderr already. Happy to coach you through adding a new tracker if you want


Fix desktop application to destroy map on context destroy

So we don't retain the map instance memory when simulating loss of context on desktop apps.

The situation we want to test is when a map object is unchanged except for the fact that the GL context has been invalidated. If we destroy and re-create the map object whenever we simulate context loss, doesn't that mean we aren't actually testing how the map behaves after a context loss?

I agree with the deletion of the app, we would need to find something else; right now, none of the disposer gets assigned a call-back from GL resources destructors since none of the smart pointers for them gets decreased on desktop app when this happens. All we do is recreate and hold the gl objects and memory when simulating this.

I think what you're describing is intended behavior. When the GL context is invalidated the GL resources just disappear, without an application calling "destroy" functions or anything. So we don't need or want disposers to run when the context if invalidated, we only want to re-create the resources we need.

I really wish we didn't have to worry about this scenario, if we had some evidence that this is rare or nonexistent on most current Android hardware then I'd consider removing this behavior completely.

Ok I got confused while testing this with the opengl profiler on desktop, I forgot the pipeline wasn't close at all to the Android context loss. We're all good here.


Terraform Import blocks aren't working correctly between windows / linux

Hi, I have some code like this:
locals {
  level_2 = zipmap(
    flatten([for key, value in var.management_groups : formatlist("${key}/%s", keys(value.children)) if value.children != null]),
    flatten([for value in var.management_groups : values(value.children) if value.children != null])
  )
}

import {
  for_each = local.level_2

  id = "/providers/Microsoft.Management/managementGroups/${basename(each.key)}"
  to = module.base.azurerm_management_group.level_2[each.key]
}

On windows, when I run this it does this:

On my linux build agent, I get the following:

It looks like it's adding some "\"'s in the import statements for some reason. I can't reproduce locally, or on WSL. Only on my build agent using this task...
This is my build script so far, as bare bones as I could make it:

trigger:
  branches:
    include:
      - main
  batch: true

pool: usw-landing-zone-prod-vmss
stages:
  - stage:
    jobs:
    - job: "INIT_PLAN"
      steps:
      - checkout: self
      - task: TerraformInstaller@1
        inputs:
          terraformVersion: '1.9.8'
      - task: TerraformTaskV4@4
        inputs:
          provider: 'azurerm'
          command: 'init'
          workingDirectory: '$(System.DefaultWorkingDirectory)/environments/lhg'
          backendAzureRmUseEnvironmentVariablesForAuthentication: false
          backendServiceArm: 'usw2-shared-services'
          backendAzureRmResourceGroupName: 'rg'
          backendAzureRmStorageAccountName: 'acct'
          backendAzureRmContainerName: 'tstate'
          backendAzureRmKey: 'cf/coreresources/environments/lhg/main.tfstate'
      - task: TerraformTaskV4@4
        inputs:
          provider: 'azurerm'
          command: 'plan'
          workingDirectory: '$(System.DefaultWorkingDirectory)/environments/lhg'
          environmentServiceNameAzureRM: 'usw2-shared-services'

I think this may be due to permissions errors. Is there a better way to maybe surface those? When I enable trace logging I get this:
2024-11-11T08:49:37.301Z [DEBUG] provider.terraform-provider-azurerm_v4.7.0_x5: {"error":{"code":"AuthorizationFailed","message":"The client '' with object id '' does not have authorization to perform action 'Microsoft.Management/managementGroups/read' over scope '/providers/Microsoft.Management/managementGroups/lhg-sandboxes' or the scope is invalid. If access was recently granted, please refresh your credentials."}}

It was a permissions issue... Sorry for blowing you up and thanks for the help. Hopefully MSFT can surface that error a bit better in the future.

I'd like to request that this error be surfaced better. If there is a permissions error I feel like that should be displayed instead of a "not found" generic message. The only way to know you're hitting permissions errors is to enable trace logging.

Hi, sorry for late reply,  I will see if we can surface permission errors better.
br
Manuel

That would be great! Thank you
On Sun, Dec 15, 2024, 2:41 PM mericstam @.***> wrote:

Hi, sorry for late reply, I will see if we can surface permission errors
better.
br
Manuel
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azure-pipelines-terraform/issues/258#issuecomment-2544052761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKVIV2N4LD55VCXFXK3WA7D2FXSOFAVCNFSM6AAAAABRRIYRNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBUGA2TENZWGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Novelai changes

Changes from NovelAI Mobile. Decided to use a forked dep because it'd be cleaner.


trouble updating ink and julia-client in Atom/Juno[BUG]

Please search existing issues to avoid duplicates.
Details

Atom version: 1.35.1
Julia version: 1.1.0
OS: OSX 10.13.6
Package versions:

Atom.jl: 0.8.1
julia-client: 0.7.13
ink: 0.9.14

Steps to reproduce

Click "Update Packages" in lower right corner.
Click "Update All" or try to individually update ink or julia-client

Gives this error message for ink:
Updating to<EMAIL_ADDRESS>failed.Hide output…
npm ERR! code SELF_SIGNED_CERT_IN_CHAIN
npm ERR! errno SELF_SIGNED_CERT_IN_CHAIN
npm ERR! request to https://www.atom.io/api/packages/ink/versions/0.10.0/tarball failed, reason: self signed certificate in certificate chain
npm ERR!      /Users/phaverty/.atom/.apm/_logs/2019-03-21T14_39_30_056Z-debug.log
and a similar one for julia client.
(I hope this is the right repo for such a report).

Logging out of the corporate VPN was enough.


chore: correct doc link

:tada: This PR is included in version 2.6.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: bump cannon

Cannon v2.18.0 includes a new feature that validates that the settings used are defined, otherwise it will throw an error. These are the requested changes to make it work and attempt a smooth update. FYI: the values used are fake, feel free to update them with the correct ones.

release cannon packages with alpha tag
use https://github.com/Synthetixio/synthetix-deployments/actions/workflows/cannon-update.yml workflow to trigger cannon alpha update

Let me know if anything does not work for you for some reason. If everything is working well, you may want to add this action to cannon docs.

The example of such automatically created PR: https://github.com/Synthetixio/synthetix-deployments/pull/442


Dev loop stops on invalid application.yaml

When I broke the application.yaml in Helidon SE, the dev loop exited (I got the exception that the yaml is not valid).
How to break it:
app.greeting="Hello"

should be:
app.greeting: "Hello"

I think the dev loop should report the error, but not quit.
Version: 2.0.2 of Helidon and 2.1.0 of build tools

When I make the change above, it does not generate a YAML parser exception. However, if I simply add a new line with "xxx" it reproduces the issue.


Add missing cancellationToken

:shipit:

Without the commit that mysteriously disappeared :smile:

lol, I realized my mistake. :wink:


Create demo page for people to checkout

done! https://pokedextracker.com/u/ashketchum10 now it just needs to be added to the homepage, probably in #57


refreshTokenExpirationOffsetSeconds gives no effect on extExpiresOn

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.6.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Public
Description
Ref. to this article on Token Lifetimes, Expiration, and Renewal
refreshTokenExpirationOffsetSeconds has no effect and returns default "extExpiresOn" as follows:
"expiresOn": "2023-12-13T00:28:43.000Z",
"extExpiresOn": "2023-12-13T01:32:58.000Z",
MSAL Configuration
var request = {
    account: myMSALObj.getActiveAccount(),
    forceRefresh: true,
    refreshTokenExpirationOffsetSeconds: 20000
};

myMSALObj.acquireTokenSilent(request)... as per your examples

Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

A couple things to note here:

This is a new config value which has not been released yet, it will be released in version 3.7.0
This config value is not expected to affect extExpiresOn, or any other return value. Instead it affects how the library interprets the refresh token's expiration value and controls when refresh token redemption should be skipped.

When is 3.7.0 available?

Currently scheduled for early January

Hei, how to check expiration value of the refresh token?

Hi @tnorling, including your name in case you haven't not see my previous question. Could be so kind to clarify?

You can't check the expiration value of the refresh token. You should not take any direct dependency on the refresh token.
extExpiresOn refers to the access token and may be used in offline or outage scenarios to temporarily extend the lifetime of the access token

@tnorling : Is there any way for PWAs to control the refresh token expiration. We have special scenarios where the internet connectivity is really bad (A redirect or popup re-login) can block the whole application for more than 5 minutes.
Is there no way to skip this 24 hrs refresh token impediment?
Or at least give control about when a new refresh token (that is valid then for 24 hours) should be created?
Thanks!

Just another question in this regard.
My user needs to fill out a supplier form (quite big) and submit it. In some cases, the user would leave the form open and continue sometime later when the token/refresh token has already expired. There were cases when user pop-ups were blocked and redirect started, losing the form data.
I got it set up so:

Check if account is present with getAccount with loginHint and start acquireTokenSilent with this account
If account is not present, or Step 1 fails, start ssoSilent with loginHint
If Step 3 fais, start acquireTokenPopup
acquireTokenRedirect as a last resort.

I could save the form in cookies but that is the worst scenario. So my question is: how to ensure a seamless form-filling from a user perspective as far as refreshing token is concerned?

I got it set up so:

Check if account is present with getAccount with loginHint and start acquireTokenSilent with this account
If account is not present, or Step 1 fails, start ssoSilent with loginHint
If Step 2 fails, start acquireTokenPopup
acquireTokenRedirect as a last resort

Is this what you are using?
https://learn.microsoft.com/en-us/entra/identity-platform/msal-js-sso
Does this even work when the refresh token is expired? Is there any pattern when ssoSilent works or not?

I guess I have to explain a bit.
I have a Power Pages portal with Dataverse, set up with Azure Active Directory as an Identity provider. By default, you don't need MSAL at all as the portal gets own token from the identity provider which also allows to query dataverse with pages web api.
I ditched the "low-code" functionality provided by Power Pages as this is slow and cumbersome, and built custom business logic to render page elements and query data.
The main challenge with the pages web api is that it's limited in functionality, compared to the dataverse web api. But to use the dataverse web api you need a separate token, and that's where MSAL comes in.
So a user first authenticates automatically to power pages with own process (redirect) and the page is rendered. This process is independent of MSAL. Once it's done, I know who the user is.
I use email as a "loginHint" for MSAL to acquireTokenSilent. Dataverse Web Api has also own scope "/user_impersonation". Therefore, I don't have any redirects or pop-us the second time in 90% of the cases. Sometimes, however, a new token process fires redirect as I explained above.

SSO silent also fails sometimes, here is a log from a user:
<<<<< MSAL => acquireTokenSilent with existing account failed: InteractionRequiredAuthError: login_required: AADSTS50058: A silent sign-in request was sent but no user is signed in.
<<<<< MSAL => ssoSilent failed: InteractionRequiredAuthError: login_required: AADSTS50058: A silent sign-in request was sent but no user is signed in.
<<<<< MSAL => acquireTokenPopup failed: BrowserAuthError: popup_window_error: Error opening popup window. This can happen if you are using IE or if popups are blocked in the browser
I assume in this case, the session of the power pages user has also expired and therefore none of the silent methods worked with MSAL.

I can confirm we have the issue that @AndrewElans is mentionning just above.
We have an Angular PWA on Angular 16 and this error is raised everytime for iOS users (Safari or installed application) when we try to refresh the token even if their session is active:

getActiveAccount() is called a few seconds before and returns an account as expected
other requests requiring authentication are working as expected so I don't believe there is an issue with cookies as the error is suggesting

This is causing unexpected reloads of the application. For now we had to disable forceRefresh/refreshTokenExpirationOffsetSeconds and will need to investigate more to understand if it's due to our implementation or if it's a bug in MSAL but I just wanted to react here before our tests are done to say that you are not alone.
 {
  "errorCode":"login_required",
  "errorMessage":"AADSTS50058: A silent sign-in request was sent but no user is signed in. The cookies used to represent the user's session were not sent in the request to Azure AD. This can happen if the user is using Internet Explorer or Edge, and the web app sending the silent sign-in request is in different IE security zone than the Azure AD endpoint (login.microsoftonline.com). Trace ID: 812f2bfb-5f66-4cbf-ac8a-30087a1d6600 Correlation ID: daf0e4ac-1a35-47e8-a58b-d932339b25fd Timestamp: 2024-01-23 10:22:43Z",
  "subError":"",
  "name":"InteractionRequiredAuthError",
  "timestamp":"",
  "traceId":"",
  "correlationId":"daf0e4ac-1a35-47e8-a58b-d932339b25fd",
  "claims":""
}

As this issue is closed, I have created a new bug for the issue with iOS: https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/6858


Remove default contentType from Storage.compose and Bucket.create

This fixes #288

Coverage increased (+0.03%) to 83.228% when pulling 8840b33a9cfbb2ab780c846e12131716fda8e0ab on mziccard:remove-compose-content-type into 7d48ec786a79a79281d4edccee782b6a62d2959d on GoogleCloudPlatform:master.

Looks great. Thanks for doing that. Should we also add something to the integration test?
Also, I suspect this enforcment is no longer needed?

Coverage increased (+1.1%) to 84.321% when pulling 22636e276005b809e7bef8cc869a38cba786b162 on mziccard:remove-compose-content-type into 7d48ec786a79a79281d4edccee782b6a62d2959d on GoogleCloudPlatform:master.

Nice, few more comments/suggestions.

Coverage increased (+1.1%) to 84.318% when pulling 1855ae1a86370e90bc5fae34dff58bf39cb27671 on mziccard:remove-compose-content-type into 7d48ec786a79a79281d4edccee782b6a62d2959d on GoogleCloudPlatform:master.

LGTM. Feel free to merge after considering the 2 comments above.

Coverage increased (+1.1%) to 84.318% when pulling 5dd0292085c00ac79aed381d4192bc33b09e2b97 on mziccard:remove-compose-content-type into 7d48ec786a79a79281d4edccee782b6a62d2959d on GoogleCloudPlatform:master.


Recipe steps updates - Added new images

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

I think you meant to make a PR into 'development' not master

I did... and I have made another correct one.
Sent from Yahoo Mail on Android
On Mon, Jan 13, 2020 at 10:40 AM, Elijah<EMAIL_ADDRESS>wrote:
I think you meant to make a PR into 'development' not master
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


overscrolling of page

when inside any calculator, the page starts overscrolling which may cause poor user experince.
I would like to work on this issue under JWOC. Can you please assign it ot me?

@Laxmankohar Some pages need to scroll vertically. Don't change the css for all the pages. Use internal css to fix the pages you think scrolling is not needed.


pylint - partial fix up

fix wildcard-import and unused-wildcard-import
fix unused-variable
fix unnecessary-pass and format
fix redefined-builtin
fix anomalous-backslash-in-string
fix consider-using-f-string
fix dangerous-default-value

Partially addresses #210

@dstrain115 - PTAL


Fix the Readme so that it has valuable information

I want a better title and roadmap.

working on this now.

Included in pre-release verison 0.0.1-alpha


Fix typo

Description
I believe these are typos

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: WLun001 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


App Service Environment template design

This change also fixes a bug that caused builds to fail for documentation only changes.
All Submissions:

[YES] Have you followed the guidelines in our Contributing document?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[NA] I have added tests to cover my changes.
[NA] All new and existing tests passed.
[NA] My code follows the code style of this project.
[NA] I ran lint checks locally prior to submission.
[YES] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?

No design exists for the ASE template
Issue Number: https://github.com/microsoft/cobalt/issues/177
What is the new behavior?

Design for template exists
Does this introduce a breaking change?

[NO]

Note to reviewer

I suggest taking a look at this file as rendered markdown.

Note to self: add table for MS support similar to VSE support.


Vulkan: Artifacts with OmniLight shadows

Godot version: Git https://github.com/godotengine/godot/commit/11cd8b8e4afdbd42f82459c48c9f6fd604ea1455
OS/device including version: Fedora 31, NVIDIA 440.44, GeForce GTX 1080
Issue description: OmniLights exhibit artifacts when enabling shadows:

When the Reverse Cull Face property is enabled and the bias is set to -0.01, they barely light up anything:

If you go close enough, you can notice the pixelation pattern:

Steps to reproduce: Edit and run the attached reproduction project.
Minimal reproduction project: test_lights_4.0.zip

30d469a

Looks somewhat better, not sure if it's fixed.

Looks fixed to me, closing.


Slight Refactoring, Todos and fixmes

This PR is only for src/net/mod.rs and does the following.

simplifies matching
Reduce unsafe scope to the unsafe part.
add Fixme to the creation of the Context object. The documentation of MaybeUninit states the following regarding the assume_init() function: "It is up to the caller to guarantee that the MaybeUninit<T> really is in an initialized state. Calling this when the content is not yet fully initialized causes immediate undefined behavior." It is obviously working now, but in the future we should use a method that does not utilize UB.

While you are on it, could you maybe change the match Option statements in the file to if let Some()?

Besides this: LGTM! :+1:

@jschwe Can you rebase the PR? Afterwards the CI is able to test your PR.

@stlankes done.


meaning of the stylegan_latent sliders

Hi! Great work!
I was wondering what kind of attributes the stylegan_latent1 and stylegan_latent2 sliders were editing. Are those the same as dscribed in the paper i.e. the cheekbone structure and inter-ocular distance?

Yes!
slider1 is from styleGAN-v3 Layer 4 Neuron 847 (which seems to control inter-ocular distance)
slider2 is from styleGAN-v3 Layer 4 Neuron 77 (which seems to control cheekbone placement vertically)


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_c1da4537-459f-4ab9-b4c7-99fa6bdba9a3/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_c1da4537-459f-4ab9-b4c7-99fa6bdba9a3.git

Docs Build status updates of commit c4c2020:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-source' (branch: Release_Archive_main_2022-02-11-01-19-24) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


media_likes pagination

I've really enjoyed using this gem for the past few weeks but am getting stuck - am I correct in stating that pagination is not implemented for media_likes?

There is no mention of pagination on the API: https://instagram.com/developer/endpoints/likes/#get_media_likes
Other users have experienced a cap around 120 likes, but that's coming from the API and there is nothing the gem can do about it.

im doing a project that is related to tags/recent/media. i don't see pagination listed in the API documentation either. nor is the option to use pagination offered in the gem here either...

limit is 50. no pagination on likes.
On Fri, Oct 16, 2015 at 11:42 AM, David Chen<EMAIL_ADDRESS>wrote:

im doing a project that is related to tags/recent/media. i don't see
pagination listed in the API documentation either. nor is the option to use
pagination offered in the gem here either...
—
Reply to this email directly or view it on GitHub
https://github.com/Instagram/instagram-ruby-gem/issues/173#issuecomment-148668798
.

--
Colin Treseler
+46 (0) 72-361-60-63
Twitter: @Ctres
http://ctres.github.io
www.linkedin.com/in/ctres


rjags installation failed because of no JAGs

checking for pkg-config... /usr/bin/pkg-config
configure: WARNING: pkg-config file for jags 4 unavailable
configure: WARNING: Consider adding the directory containing `jags.pc`
configure: WARNING: to the PKG_CONFIG_PATH environment variable
configure: Attempting legacy configuration of rjags
checking for jags... no
configure: error: "automatic detection of JAGS failed. Please use pkg-config to locate the JAGS library. See the INSTALL file for details."
ERROR: configuration failed for package ‘rjags’

but PP does have JAGS module
module load R/4.0.0
Loading R/4.0.0
  Loading requirement: unixODBC/2.3.0 JAGS/4.2.0 texlive/20151117 gdal/2.4.0
    proj/5.2.0

probably similar issue as #12


Create basic pipeline using MASC data.

Make it possible to do sentence segmentation and tokenization using MASC, e.g. along the lines of: https://github.com/scalanlp/chalk/wiki/Chalk-command-line-tutorial

Is work on the NLP pipeline going on ?

No, sorry.


Memory requirements for RNAseq analysis

Hi all,
I want to use bcbio-nextgen to analyze human RNAseq data. I have two conditions that I want to compare and 10 samples for each (total of 20 samples).
I currently have a 12 core machine with 36 Gb of RAM but it's a virtual machine and I may be able to reallocate some extra resources temporarily. The server that runs the VM actually has a total of 24 cores and ~130 GB RAM.
I don't want to completely starve the other VMs on this system, but does anyone have thoughts on what a reasonable memory/hardware setup for that kind of experiment (20 RNAseq samples) could look like?
Thanks for any input you might have!
~Lina

Hi Lina,
That should be enough machine to run your analysis in a reasonable amount of time, as long as the samples aren't super super deep. STAR will need about 40 GB to run each alignment, so the alignments will happen one at a time, running with 12 cores each. There are some steps that run serially, so those will run 12 at a time using 1 core each.

Ok great -- thanks for the input!


B 19686 int customer can add third address

B-19686
Summary
Due to the feature flag each set of steps will need to be run both with FEATURE_FLAG_THIRD_ADDRESS_AVAILABLE both off and on.
With the feature flag on.

Log into any milmove customer under milmovelocal to view a PPM shipment (can be existing or new, but need to be able to see edit for mto and PPM).
Go under edit for a PPM shipment
Click through until you see origin/destination address.
Click "Yes I have a second address". Fill out the required fields for the secondary address.
The option to add a third address should show. Clicking yes on this should show the third address entry block.
Enter a third address, fill in the required fields. Click save.
Leave the shipment edit screen, doesn't need to be saved, but we want to review the shipment data.
The third pickup and destination address should show here if one was added.
edit the shipment and click no for third destination address and save. move to the next screen.
Backtrack to the previous screen and click yes again, the third destination address should have been removed.
Go back to shipment summary to verify the field has been removed. There should be no empty entry for third address.

Repeat these steps for HHG, and NTS shipments. they should all work functionally equivalent with the same rules. If there is no third address, then there should be no blank fields of thrid address for either destination or pickup.
with the feature flag off

Log into any milmove customer under milmovelocal to view a PPM shipment (can be existing or new, but need to be able to see edit for mto and PPM).
Go under edit for a PPM shipment
Click through until you see origin/destination address.
Click "Yes I have a second address". Fill out the required fields for the secondary address.
There should be no option to add a third pickup or destination address
Leave the edit screen and view the shipment under review shipment. there should be no third address visible

Repeat these steps for HHG, and NTS shipments. they should all work functionally equivalent with the same rules

Joey, you will also need to update these 3 files for FF work.

Can this extra directory be deleted?

for mto_shipment_creator.go /fetcher/updater and ppm creator/fetcher/updater, can you add tests for checking the tertiary address? Maybe just in ones where we are checking the secondary address

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against 27415a4f5ac298ce77b7b8d43e3b5fd6b48116f0


fix: broken Next.js link and image property

Description

fix: broken Next.js link and image property
add: more steps to README > Getting Started

Can you revert the package-lock.json changes?
Otherwise LGTM 👍

Reverted package-lock.json


Add announceForAccessibilityWithOptions method mock.

Summary:
Currently, tests on components that use the AccessibilityInfo.announceForAccessibilityWithOptions method fail because a mock for this method is not present in the jest setup file. This PR adds the mock for the before mentioned method in the appropriate setup.js file
Changelog:
[General][Added] - Added the missing announceForAccessibilityWithOptions function mock in the packages/react-native/jest/setup.js file.
Test Plan:
Here are the commands I executed after making the modification:

yarn prettier
yarn lint
yarn test

Test output

Thanks @ChrisMattew  -- what test was failing because of the missing mock? Or are you adding tests?


[Question] Isn't it insecure to put a RSA private key in the repository?

https://github.com/NetEase/pomelo/blob/master/template/shared/server.key

It is just an example, a template, so I think it is alright


Fix misc issues of Harbor charts

Fix the pull/push commands showed on UI are incorrect
Replace "insecureRegistry" with "externalProtocol"
Using the secret rather than pasting text if users want to use the certificate of themselves
Refine NOTES.txt

Pull Request Test Coverage Report for Build 7616

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 64.986%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
1
81.29%

Totals

Change from base Build 7608:
0.02%

Covered Lines:
11164

Relevant Lines:
17179

💛  - Coveralls


Antigen doesn't apply theme from .zshrc

My zshrc
export NVM_DIR="$HOME/.nvm"

source "$HOME/.zsh-plugins/antigen.zsh"
# Load the oh-my-zsh's library
antigen use oh-my-zsh

antigen bundle git
antigen bundle ssh-agent

antigen bundle zsh-users/zsh-syntax-highlighting
antigen bundle zsh-users/zsh-autosuggestions
antigen bundle zsh-users/zsh-completions

# Load the theme
antigen bundle lukechilds/zsh-nvm

antigen theme kobayashi/sushi-theme

antigen apply

Running antigen theme kobayashi/sushi-theme after the fact works fine, and all the other plugins seem to be working too.

Seems to work OK on 2.2.2/develop.

I am running zsh version 5.4.2 (x86_64-apple-darwin16.7.0)
and I just cloned antigen from git last night.

Glad you got it working! Maybe it was an issue between versions :/


onInit not called when model instance created in class method (Babel only)

I've discovered a Babel-only issue where onInit is not called when a model instance is created in a class method. However, when the same class method uses a factory function to create the model instance, it works fine.
I've created a reproducible example using create-react-app. One test case passes and one fails, but both should pass.
The same test cases pass without error when added to the mobx-keystone test suite.

The repo shows as empty to me :(

Sorry, it's available now.

Seems to be a bug with the babel decorator plugin :(
https://github.com/babel/babel/issues/11131

Thanks a lot for getting to the bottom of the issue and opening and issue in the Babel repository!
So what are the current options right now? If the decorator plugin receives a fix, I guess create-react-app still needs to bump the Babel version to receive the fix which may take some time. I could stick with the unnecessary factory function. Are there other options?

Only the recent decoratedModel comes to mind (maybe) :(
It only happens when using the class within the class itself though. Cross-classes should be ok.

Such a weird bug ... I only discovered it because some of my models have a clone method which creates a new instance of the same class with clones of its props. The logic for this kind of clone probably only makes sense in a class method. I like the decorator approach as it keeps the code clean and readable.
I guess I'll stick to the factory function workaround until Babel has fixed this bug and CRA has updated its dependencies.

btw if babel fixes it and you use yarn then you don't need to wait for CRA to update the package version, you can use yarn resolutions to force it
"resolutions": {
  "some package": "forced version
}

There's a slightly better workaround, but still meh-ish
@model(...)
class A {
  foo() {
    return new _A(...);
  }
}
const _A = A

Thanks! That's the workaround I'll use. I think it's the least awkward.
Should we close this issue? As it turns out, this is not a mobx-keystone issue.

Sounds good

As an alternative, do you see anything wrong with calling onInit() manually?
static create(modelData: any) {
    const result = new MyModel(modelData);
    result.onInit();
    return result;
  }

I'd use the workaround on the post above. something else might be broken if you create a new instance of the undecorated class


Updated the changelog for the 0.4.2 release

:+1:

[Current coverage][cc-pull] is 89.28%

Merging [#386][cc-pull] into [master][cc-base-branch] will increase coverage by 0.97%

@@             master       #386   diff @@
==========================================
  Files            18         18
  Lines          1240       1372   +132
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1095       1225   +130
- Misses          145        147     +2
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [df18298...09c5bc6][cc-compare]
[cc-base-branch]: https://codecov.io/gh/bigchaindb/bigchaindb/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/bigchaindb/bigchaindb/compare/df18298cc2c30fa983c824af0e807ce30a375b96...09c5bc6346f216a148b85902c9bee1272b1325db
[cc-pull]: https://codecov.io/gh/bigchaindb/bigchaindb/pull/386?src=pr


[Event Request] Record::"Sales Header" - OnLookup Trigger Payment Method Code

Another page is called (matrix) for appropriate payment choice.

We cannot accept requests with short text only. Please show the code and event specification.

local procedure "Sales Header_OnLookupPaymentMethodEvent"(var Rec: Record "Sales Header")
Code filters a matrix regarding circumstances of sales header data and opens a filtered matrix page. On this page you can choose (depending on set data) payment conditions fot the customer.

Asking again, can you provide this trigger code and event specification with list of parameters? Do you know what if we add code to this trigger, it will overwrite standard lookup behavior based on table relation?

We are not adding an alternate OnLookup code to the table field.
You can add OnLookup trigger by an extension to the pages where you need a special behavior.


DELEKDELEL

DELEKDELEL created by<EMAIL_ADDRESS>on 2018-04-22 15:42:36

<EMAIL_ADDRESS>replied, Is there a word DELEKDELEL?  If so, what does it mean and how is it
different from these other words we already have:
DEKTELEL which apparently means the source of one's fear.  For example,
"A Droteo a kmal dektelek el chad." Droteo is someone who I am very afraid
of.
DEKDEL which apparently means his/her/its fear (or awe).  For example,
"Ng ko er a kmal ungia a rengul a Ann me ng mla obes er a dektel me a
kodellel," which I guess means something like "Ann became happy and forgot
her fear and her death(?)."

<EMAIL_ADDRESS>replied, Same...dektelek:first sample Iâ€™m scared of Droteo.
Dekdelek: my fears
Dektel/dekdel: his/her fears
Delekdelel:delekdelir:delekdelam: deledkdem:-his/her fear:their fears:our
fears:your fears.
ðŸ˜

<EMAIL_ADDRESS>replied, Thanks Ulang!
Is there a difference between dekdel and delekdelel?

<EMAIL_ADDRESS>replied, I believe dekdel is simple fears rather than hibbejibbes ones for dekdelek,
not easily overcome fears. When itâ€™s used ina sentence, you can tell the
difference. Belauans, go figure hehe.

<EMAIL_ADDRESS>replied, n.redup Aleks?
All, so dekdel is relatively normal fears and dekdelel is bigger, scarier
fears?


feat(eslint-plugin,tsconfig): Use eslint to check for unused variables instead of typescript

Resolves #66

CI fix in #87


refactor(SIGMET): using custom DateTimePicker with custom NumberInput

Using mousewheel allows you to set time outside validity period.
Typing in hour field does not seem to work, always complains about invalid input
Typing in minute field is OK, but if you select the two digits and type two numbers, they appear reversed.

Merged. This pull request is an improvement to existing datepicker. Please have a look at the comments for other improvements.


SDC-7953. Improve Oracle CDC Config parser for more flexability

Allows to select wide range of schemas and tables instead of creating many pipelines for each schema. This fix seems for the next version.

Hi @estatic,
Thank you for your interest and contribution!
To submit a contribution, you will need to submit an ICLA with us. Details are here
Please file a jira here for this feature and that to the PR title: SDC-<jira#>.

Hi @harishreedharan,
Thanks for reply.
I've signed ICLA yesterday and once again today. Pull request title fixed.

Hi @estatic,
Can you also file the jira? Use the jira title as the title for PR.

Hi @harishreedharan,
The improvement is here https://issues.streamsets.com/browse/ANS-17.

I moved the jira to the SDC project: https://issues.streamsets.com/browse/SDC-7953
I will take a look at this soon. Thanks for your patch @estatic !

Hi @harishreedharan,
I've fixed all things. Hope it's fine for now.

Hi @harishreedharan,
What about this pull request? is it fine for you?

Hi @harishreedharan,
Main idea of these changes is to get wide range of SCHEMAS and TABLES and also unify logic of JDBC source and SDC Source as JDBC takes exactly do the same.
If we use just one schema and wide range of tables inside then it's not really "wide" range of data objects in database, but Using pattern for schemas and pattern for tables you can take as much as possible data sources for your streams.
Exclude field is optional, but it can be used for schemas and tables as well. Sure, we can add separated exclude fields for schemas and tables, but I think it would be really complicated for end user.
What do you think?

I will also put it here
About TABLE_SCHEM.
Please take a look carefully as this is a KEY for result set which returning from database. Growing inside java.sql.DatabaseMetaData class you can find method getTables which is using by JdbcUtil class to get list of schemas and tables. In getTables() method documentation there are description of returning values and columns from database. Here is from this documentation:
/* Retrieves a description of the tables available in the given catalog.

Only table descriptions matching the catalog, schema, table
name and type criteria are returned. They are ordered by
TABLE_TYPE, TABLE_CAT,
TABLE_SCHEM and TABLE_NAME.
*/

So, If I change "TABLE_SCHEM" to "TABLE_SCHEMA" then It wouldn't work at all.
About SchemaAndTable schemaAndTable = new SchemaAndTable(table, schema); yo

OK, I think I understand. What I am sort of wondering though is how to handle the current field where the user specifies schema. Do we simply make that optional and tell the user to specify schema.table in the table formats? I am ok with that, as long as we somehow handle the situation where both are specified.
If the schema/table were created with double-quotes then . is a valid one, so we will fail to split correctly. Might I suggest adding 2 fields to handle this case: schema pattern and List, same for excludes, so for each schema pattern, you can specify a list of table patterns.
Does that make sense? In that case, we can add logic in the upgrader to convert the old configuration where there was only one schema to the new one and this would work fine

I've tried to do clear logic, so, if you set schema name without any SQL
patterns and put table name without any patterns then it should load exact
set schema and exact set table.
So, in case you don't need SQL patterns you are free to use flow as it was
by setting schema and tables.
But in case need to load wide range on tables you can set just schema and
put % as first table name, then it loads all tables in schema.
And also you can set % as schema and specific table name, then it loads
tables with TABLE_NAME from all schemas.
And finaly if you set % for both schema and table it should loads all
schemas and all tables in database.
Moving to sources... Method JdbcUtil::getTableMetadata receives SQL pattern
as input, so, if you send just schema name and table name if should receive
exact schema and table.
About exclusions. I'm worry I didn't understand you. Do you suggest to add
one exclusion field for schemas and one for tables?
About splitting. I/m not split schema and name anymore. I'm receiveing
schema and table as spearated variables from ResultSet.
Hope I've explained all your questions. Current changes are not touch
already configured pipelines as without pattern symbols it should work as
was.
2017-12-06 22:39 GMT+03:00 Hari Shreedharan<EMAIL_ADDRESS>
OK, I think I understand. What I am sort of wondering though is how to
handle the current field where the user specifies schema. Do we simply make
that optional and tell the user to specify schema.table in the table
formats? I am ok with that, as long as we somehow handle the situation
where both are specified.
If the schema/table were created with double-quotes then . is a valid
one, so we will fail to split correctly. Might I suggest adding 2 fields to
handle this case: schema pattern and List
, same for excludes, so for each schema pattern, you can specify a list of
table patterns.
Does that make sense? In that case, we can add logic in the upgrader to
convert the old configuration where there was only one schema to the new
one and this would work fine
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/streamsets/datacollector/pull/43#issuecomment-349751630,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3fi0VQtmz2XMxctOet6GuzUuTT_ZZ_ks5s9u2KgaJpZM4Qhmqg
.

--
Best,
Ivan Grunev

Ah, ok. I misunderstood some of your code. Let me look through again. Thanks for the clarification!

Hi @harishreedharan,
I've fix identation and remove setters. Also I've made properties as final. Hope that's fine.

I was thinking about it a bit. This change is almost the same as what Multitable JDBC origin supports, but that origin supports both separate table patterns for each table pattern. See the screenshot attached. I think there is only minor set of changes to make that possible (you can use the TableJdbcConfigBean as guidance. I'd recommend slight changes from that where more than one table pattern is allowed per schema pattern.
You'd also need to make a corresponding change in the upgrader to move our current configuration to the new one.
If you prefer not to make that change, it is fine. I will merge this one and then follow up and add that support.
Multitable JDBC OriginScreenshot:

Let me know what you think.

Well, you can add as much patterns for tables as you want, one for schema
and many for tables.
I can add the same possibility for schema in this merge, but I think better
to do this in next pool request and multiple schema patter should takes a
little bit more time, especialy for testing.
8 дек. 2017 г. 6:50 PM пользователь "Hari Shreedharan" <
<EMAIL_ADDRESS>написал:

I was thinking about it a bit. This change is almost the same as what
Multitable JDBC origin supports, but that origin supports both separate
table patterns for each table pattern. See the screenshot attached. I think
there is only minor set of changes to make that possible (you can use the
TableJdbcConfigBean
https://github.com/streamsets/datacollector/blob/master/jdbc-lib/src/main/java/com/streamsets/pipeline/stage/origin/jdbc/table/TableJdbcConfigBean.java#L43
as guidance. I'd recommend slight changes from that where more than one
table pattern is allowed per schema pattern.
You'd also need to make a corresponding change in the upgrader to move our
current configuration to the new one.
If you prefer not to make that change, it is fine. I will merge this one
and then follow up and add that support.
Multitable JDBC OriginScreenshot:
[image: screen shot 2017-12-08 at 7 46 14 am]
https://user-images.githubusercontent.com/1481194/33773291-3ef33a0a-dbec-11e7-8883-efc270482cf7.png
Let me know what you think.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/streamsets/datacollector/pull/43#issuecomment-350296899,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3fiwwMO1iqdRKnlq9_Tfp0aL9uZGzLks5s-VragaJpZM4Qhmqg
.

Sounds good. Let me go ahead and merge this once the tests pass.

Thanks!

9 дек. 2017 г., в 0:41, Hari Shreedharan<EMAIL_ADDRESS>написал(а):
@harishreedharan approved this pull request.
I ran this through the tests and they still pass. I will merge this as soon as our internal pre-commit hook passes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/streamsets/datacollector/pull/43#pullrequestreview-82281294, or mute the thread https://github.com/notifications/unsubscribe-auth/AB3fi4yTzWPahFCgurWxNIJ0pEiBqbVmks5s-az6gaJpZM4Qhmqg.

Merged here. Please go ahead and close this. Thank you, @estatic!

done


Setup Ledger tests on windows

Feature Request
We test Ledger using Speculos emulator and use ledger-app-dev-tools Docker image. At the time of writing this issue, there no such image for Windows (I've created an issue for it). If that won't change, we should perform setup manually (most likely following this guide or simply install speculos, cargo and crate cargo-ledger.

Hi @franciszekjob, Please can you assign this task to me so I can start working on it immediately.

Hey @ScottyDavies, this task will be completed internally by our team, please see issues with good first issue label!


Possibility to automatically use "latest" Gradle version for wrapper task

I often use existing Gradle builds to bootstrap new Gradle builds.
But usually I want to start with the latest Gradle version and not the one from the project I use to bootstrap.
It would be nice for the wrapper and init tasks if you could specify something like --gradle-version latest.
Currently I always have to first go to the documentation or releases pages and check which version is the latest currently.

Adding this support to the wrapper task seems like a good idea indeed.
However for the init one, it might be slightly trickier because there would always be a possibility that the generated build is actually not compatible with the latest Gradle version. Let's say you use Gradle 2.x to generate a build and it sets the wrapper to 8.x ... who knows.

Then maybe run the wrapper task first and then start the generated wrapper to do the init work.
That would be better anyway as it would use the newer project template.

Updated title to reflect that this would be done for the wrapper task only and not for init at this point.

created a follow up

#23369


Fix slithering direction and slithering conditions

Sometimes the character does not slither even though there is an open space and sometimes they do, even if there is no open space. Usually happens near doors.

Note: this bug probably was introduced in b39c7c280cd3a9f3fd263bcb82fc0435069fa7a1 or a8e2f0f500d3bf4bf5c0d55c1cebf735c0fd3784


PSA: very lightweight HKT Language Suggestion

Hi,
I just created an language suggestion
that I think could be interesting for F#Plus.
Maybe some of you want to comment or so

Yes, looks interesting and would help type checking, but I wonder how much effort is to implement it, compared with implementing full HKT.

I can not assess how much more or less it might be compared to a full HKT implementation. Thou I somehow expect it to be less complex as there is already a lot of structure checking operators in STRPs.
But even if I assumed it is the same amount of work to implement either of 2 ... lets be realistic: HKTs wont happen in F#. There is massive resistance to anything that would somehow endanger the total seamless 2-way integration between F# and C# (even thou that seamless integration isn't the case as of today anyways).
So I'd be happy if you could weight in with your support on this.

OK. Let's continue the discussion on that thread.


fix(res): support formatted=false for strings

There is an error message in some cases when a percent sign (%) appears in a resources xml inside a string. The error message is e.g.:
/app/src/main/res/values/strings.xml:143:4: Multiple substitutions specified in non-positional format of string resource string/certificate_person_details_card_expiration. Did you mean to add the formatted="false" attribute?
Steps to reproduce:
Export this app to gradle and run a build: https://github.com/corona-warn-app/cwa-app-android / https://m.apkpure.com/de/corona-warn-app/de.rki.coronawarnapp
The problem is causes by strings like:
https://github.com/corona-warn-app/cwa-app-android/blob/d98f9c20c595ca5dc877f87f032b47d8b8175a79/Corona-Warn-App/src/main/res/values/covid_certificate_strings.xml#L34
Unlike the devs of SAP jadx does not place quotes around all strings. Apktool solves the issue by setting formatted="false": https://github.com/iBotPeaches/Apktool/blob/2b8121584624f0a1b1602992a48fcdbf60c0347d/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/data/value/ResStringValue.java#L59-L61
It's possible to borrow and reuse their implementation (https://github.com/iBotPeaches/Apktool/blob/2b8121584624f0a1b1602992a48fcdbf60c0347d/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/xml/ResXmlEncoders.java#L139-L142
and
https://github.com/iBotPeaches/Apktool/blob/2b8121584624f0a1b1602992a48fcdbf60c0347d/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/xml/ResXmlEncoders.java#L163-L208 ) directly in jadx to solve this issue. I suppressed all warning instead of fixing them - with less changes it's easier to sync with upstream.
(Btw: Fixing all resource issues of this app is one change ahead: set compileSdkVersion to 31, buildToolsVersion to 31.0.0 and update android gradle plugin to e.g. 7.4.0 and all resource issues are fixed)

Looks good to me. Thanks!


Support environment variables from a directory

This adds two new arguments, --env-dir and --label-dir and are modeled after envdir. See: http://cr.yp.to/daemontools/envdir.html
# ls -lh /env
total 12K
-rw-r--r-- 1 root root 4 May 14 22:34 foo
-rw-r--r-- 1 root root 4 May 14 22:42 foo2
-rw-r--r-- 1 root root 7 May 14 22:54 nullbyte

# cat /env/*
bar
bar
foobar

# /go/src/github.com/docker/docker/bundles/1.7.0-dev/binary/docker-1.7.0-dev run --env-dir /env ubuntu:14.04 env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=0241be89c367
foo=bar
foo2=bar
nullbyte=foo
bar
HOME=/root

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "env-dir" git@github.com:mattrobenolt/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

@mattrobenolt just curious, do other tools support things like this?  I've never seen this type of thing before.

Yeah, the tool I linked to envdir utilizes this pattern: http://cr.yp.to/daemontools/envdir.html
runit also has this built in as a part of it's suite of tools: http://smarden.org/runit/chpst.8.html (See the -e dir option)
mesos as well utilizes a similar pattern for defining attributes on a node. You can use a directory of files in this exact manner.

To add to it, it's also easier to manage from config management systems, since different pieces can just drop in a file without coordinating between each other. In our case, we're populating machines with a bunch of env variables into /etc/env.d, and would like to then just link up --env-dir /etc/env.d and see magic happen. :sparkles:

It's a pretty interesting idea and I have used this with mesos and it works really well for automation.  I guess my question is that if we add this do you see demand for other things out of env?  Is this useful only for env or can it be used other places?

@crosbymichael I'm not entirely sure of all of the options that would be suitable with docker. I'm a pretty light docker user myself, but this patch also covers labels, just because they utilize the exact same underlying code, so --label-dir is being exposed as well.

Anything else I can do here to help get this pushed through? This feature is becoming increasingly more useful for us, and I'd hate to run a fork in production. :(

@crosbymichael @calavera @duglin what are your thoughts on this? Is this something that's wanted? It looks fairly simple.
I wonder if there should be restrictions on the paths that can be used for the env-dir; should it be within the build context?

I do like the fact that the amount of code needed to support it is minimal.  Would need some testcases and docs too, if we go this route.
I'm just not familiar enough with this way of specifying env vars to have much of an opinion on whether this is something popular enough to add, or if its just a passing fad.  If I was forced to choose, I'd probably let it in since it doesn't break or complicate anything in Docker, it doesn't clutter things up, and if people don't like it then they don't need to use it.

Would need some testcases and docs too, if we go this route.

I have no issues helping in this area. Not entire sure where documentation is held atm, and none of this environment variable parsing stuff has tests atm. (also not super familiar with testing in Go, let alone for docker), but absolutely willing to contribute.

I wonder if there should be restrictions on the paths that can be used for the env-dir; should it be within the build context?

Not sure what all this entails, but we do this in say, /etc/env.d atm on our machines. Not sure what exactly the "build context" covers.

Also, might need some guards, pointing it to a directory with huge files in it would be interesting ;)

Is this different than pointing it at a 10MB env-file? Aside from all the IO of reading all of the files. I'm ok imposing an artificial limit, but not sure what is reasonable in that case. I wouldn't feel too comfortable with anything less than 1000. At least we won't recursively crawl directories and subdirectories. ;) That at least prevents something really bad from happening if you were to accidently do -env-dir=/.

I definitely don't like the extra flags. Seems like --env-file can be used to import a dir as well.

@cpuguy83 It can be, but I personally feel that seems a bit misleading IMO since it's literally named env-file. But I'm not super strongly opposed if others agree with that. I'll throw in my -1 though. :)

I've updated to ignore hidden files in the env-dir directory.

Thanks @mattrobenolt, that's an interesting feature :-)
+1 on design, even with an additional command-line flag (I hate adding flags, but I hate ambiguous inputs even more).
Pushing to code review.

One issue with implementation. Also this absolutely needs some tests: either unit tests through the regular go testing mechanism (*_test.go files basically), or look into integration-cli/ subdirectory for examples of integration tests.

@icecrime Thanks for the feedback. I'll happily write some tests for it. Just wanted to make sure that the idea was acceptable first before committing to that + docs.

Also, just double checked, and envdir does in fact only read the first line. Updating behavior today + tests.

@icecrime I've added some tests explicitly for the new ParseEnvDir function. I was going to add tests for the ParseEnvFile path as well, but see #13694.
Not sure why the "janky" build has failed, but tests passed locally for me and from what I can tell, shouldn't be related to what I've added.

Kicked janky to try again. Fingers crossed :-)

@thaJeztah Looks to have failed again for a different unrelated issue. :disappointed:

Let's try once more (kicked). I'm on my mobile now so didn't check which test failed this time.

I think we need some docs and, in particular, a statement about the order in which things will be processed? Which env var setting wins.

@duglin Feedback should be addressed. Not sure why tests are failing on the test-docker-py part, but they work for me locally. Seems highly unlikely to be related, but I'm open to ideas. :)

@icecrime Anything else to be done here? Seems we have stalled a bit. I was last waiting on #13694 since that's affecting similar code, but that seems to have been stalled for the past 5 days. Would like to push this forward since this is important to us. :)

Thanks, LGTM :+1: Ping @duglin!

@mattrobenolt did you want to wait for #13694?

@duglin It's not my call. :) I would have liked to wait for the rest of tests for this module, but nothing in this PR directly affects it, so it doesn't particularly matter to me.

Am I the only one who really doesn't want two new flags for little added value? :(
What's the usecase? If the usecase is "why not?" then I'd rather not add more features. People can just as well use --env-file and --label-file.

People can just as well use --env-file and --label-file

These are not replacements for my proposal. What I'm proposing is a very different semantic.  And env-dir is a directory, where each file is it's own variable, and the contents of the file is the value of the variable.

for little added value?

Isn't that a pretty subjective assumption? It's very valuable for me and our use case. :) As stated, this is a pre-existing pattern used by runit as well, so this isn't a new invention.

I totally agree with @tiborvass
In any case, docker could detect if the path you are specifying is a dir or a file and parse accordingly.

docker could detect if the path you are specifying is a dir or a file and parse accordingly.

I'm ok with that.
Do you think it'd be weird to have two different behaviors based on if the flag is pointed at a dir or at a file? This is my only objection, but it's not a strong one.

Oh, it seems this was already brought up here: https://github.com/docker/docker/pull/13234#issuecomment-105603646 :)

@mattrobenolt but what's the usecase other than having another way of representing the same thing and that others do it too?
for i in $dir*; do echo $(basename $i)=$(cat $i); done > $file converts easily a directory into a file.
I would prefer not to overload --env-file because that is really weird, nobody does that and nobody expects it to work. My question is do we really need to support --env-dir or can't we let others have a wrapper in bashrc.
/cc @tianon

I mean, at this point, I honestly don't care. It was a nice little feature that makes it nice for us to work with. I've explained my use case and cited examples of how this is used in the wild. For us, we utilize runit a lot, and runit has adopted the pattern of envdirs. There are many projects that have adopted envdir and different ports that provide the ability to parse envdirs.
For us, we dump out files from config management software which is much easier when you can manage single files, rather than one big file with everything in it.
 So we pass the --env-file now directly. There's no way for this to be wrapped in a bash script.
If there's such resistance, I'm ok closing the pull request.

@mattrobenolt sorry if you felt my tone was offending, it really is not my intention. I'm just one voice, other maintainers disagree with me so you don't need to close your pull request :)
I'm simply trying to understand the problem and try to find ways to solve it without adding more nice little features to docker.
Anyway, if really adding --env-dir and --label-dir is the best solution to the issue at hand, then so be it.

@tiborvass nah, it's fine. Just frustrating from a very avid open source contributor trying to contribute to a new project.
I also understand the burden of adding new things and needing to maintain that. I deal with it all the time for my own projects, so I respect that.
Just trying to find a middle ground that works within the project and satisfies our scenario. Trust me, I'd really rather not run a fork of docker and maintain that. ;) So I'm trying to do whatever I can to marshall this through.

@mattrobenolt thanks, no worries :)
Also, is everyone okay with --env-dir having highest precedence? I'm now also wondering if --env-file having higher precedence than --env is a good thing... Intuitively I would have put dir < file < var but maybe it's just me.

I'm fine, and still LGTM. @cpuguy83 @tiborvass Let's try and finish this one!

from spec:

If the file s is completely empty (0 bytes long), envdir removes an environment variable named s if one exists, without adding a new variable.

This case doesn't seem to be handled and actually errors with EOF in client atm.
There is also a rule for no = in filename. Not sure if this should error or trim though.

This case doesn't seem to be handled and actually errors with EOF in client atm.

I wasn't sure how to handle this case without a decent size refactor since as of now, all of the environment variables get collected and added up together into a list. It'd need to be refactored to change that to be able to remove items from that list while accumulating them.

There is also a rule for no = in filename. Not sure if this should error or trim though.

I'll double check against envdir source and see what it does.

Needs docs as well.

Would be happy to add after code review.

I wasn't sure how to handle this case without a decent size refactor since as of now, all of the environment variables get collected and added up together into a list. It'd need to be refactored to change that to be able to remove items from that list while accumulating them.

It at least needs to clear the variable then and not EOF.

I can clear the variable within the context of ParseEnvDir, but it won't be able to remove any other environment variables, so in my opinion, that'd be a bit misleading unless we were able to delete any environment variables. Also not even sure being able to arbitrarily delete environment variables like this is a good fit for docker. What happens if someone were to try and delete HOSTNAME, etc? I just think it's a bit more dangerous to do in docker than in runit. But I'm open to hearing opinions. Again, would also require a pretty large refactor likely and haven't looked into it. Right now, all variables that we add are additive and piggyback of the same internals. Would we want to allow people to delete vars through -e? It opens the door for lots of questions. :)

and not EOF.

Totally reasonable. Will update.

Sorry. I meant set the variable to be empty. This is what you can do with current -e as well.

Ah, alright. Updating.

@tagomoris Updated. One last question though re:

There is also a rule for no = in filename. Not sure if this should error or trim though.

In envdir.c, the file is ignored. In all of docker, this doesn't really break things, but it's also undesired behavior. This check doesn't exist for env-file nor passing through -e. If you do -e FOO=bar=baz, you end up with one variable named FOO value being bar=baz.
Is the sane default here to ignore the variable entirely for env-dir? That seems reasonable to me.

@tonistiigi Alright, since I've rebased and switched to using EnvironmentVariableRegexp, this will not return a ErrBadEnvVariable if there's an = in the name. This follows in line with what env-file does now as well.

code LGTM
Would not hurt to add an integration-cli test so that we actually test the functionality. Not only the parser function.

so far it looks good to me but as @tonistiigi said, let's add some integration tests to make sure the entire processing flow works end-to-end.

Alright, lemme look into how to do that. :+1:

Thanks for being so patient @mattrobenolt, sorry it's taking so long :+1:

Thanks for your patience @mattrobenolt! Any update on the integration tests?

Quick comments:

Overall LGTM (slight feature creep)
It isn't obvious to me that right now the priority is dir < file < var in terms of which env variable wins when there are competing variables. I'm not super familiar with the code, but there should be a test enforcing this behavior.
An integration test would be nice

I agree this is feature creeep and am still not convinced we need to support it :/

FWIW I haven't heard of anybody asking for something like this. @mattrobenolt is there a specific reason why you can't use a single file?

@bfirsh https://github.com/docker/docker/pull/13234#issuecomment-102208876

Hi @mattrobenolt ,
Thank you so much for taking the time to send this PR. And I am so sorry it has gone for so long and had so much back and forth. We are trying to make our process better and unfortunately this PR was opened when we are still in our "trying to be better about keeping things open for a long time" phase.
However, I do not think this feature is super necessary, but I do think if people really want it they should express their wishes for it here.
See my fear is this will become like docker rename something a lot of people wanted but unfortunnately no one used, so it took us 3 releases to realize it was broken. Since this PR lacks any integration testing, this possibility could totally come true. Again thank you so much for taking the time to submit this. And so sorry for the delay in feedback.
If it turns out a ton of people comment here about their wishes to have this feature, then I think we can reconsider.

@jfrazelle I appreciate the feedback. :heart:
Fortunately, we already worked around the issue 4 months ago, and this was just a nice-to-have, but not a deal breaker.
I didn't expect a resounding "yes", was just hoping to get some answer before investing more time into writing docs/integration tests on if the feature was even acceptable in the project. :)

Thanks for the understanding @mattrobenolt :+1:


add Kind to local-machine solutions

This is a...

[x] Feature Request
[ ] Bug Report

Problem:
kind is a tool for running local Kubernetes clusters using Docker container "nodes".
We can use it to create multi-control-plane or multi-node Kubernetes cluster.
Page to Update:
https://kubernetes.io/docs/setup/pick-right-solution/

It's already there under ecosystem tools https://kubernetes.io/docs/setup/pick-right-solution/#ecosystem-tools?

Oh! I see what you mean- perhaps delete it from Ecosystem Tools section if we're adding to the community supported tools. Will comment in the PR.

I seem to have ignored it before. :upside_down_face:
Thank you for pointing out. :+1:

haha. no worries! I totally agree with your PR though- it should probably be in the 1st section, so just remove the 2nd occurrence :)

OK, Thanks.


Adding Instance_ID as a parameter for Get-RubrikDatabase

Description
Adding InstanceID(instance_id) for Get-RubrikDatabase to provide more efficient database retrieval. Also added logic that if a hostname and instance name are provided (including ServerInstance), the cmdlet will use that to pull the correct InstanceID.
Related Issue
#278
Motivation and Context
Customer request and general enhancement.
How Has This Been Tested?
Tested in Rubrik Gaia lab. Ran the following commands to validate functionality:
Get-RubrikDatabase -ServerInstance am2-sql16-1 (6 seconds for completion)
Get-RubrikDatabase -InstanceID MssqlInstance:::dc54ad38-41d7-437c-9639-301d8f09e01a (1 second for completion)
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTION document.
[x] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks for your PR, we will review this and merge the changes intro the repo


Mandating Minimum Compiler Version

When looking at packaging libraries targeting very modern subsets of C++, they often only support more modern compilers than vcpkg supports. For example, if you need <optional> you need gcc-8 or better. However, vcpkg works with gcc-5.4 due to supporting Ubuntu 16.04. What is the recommended way of dealing with this? Is there a way of dealing with this?

I believe the correct way to handle this will be to add that compiler to a triplet but I don't see an amazing way documented to override the compiler right now. Doing it nicely might require adding a toolchain or modifying the existing Linux toolchain to have that knob: https://github.com/microsoft/vcpkg/tree/master/scripts/toolchains
(I observe that MinGW is in a similar state on Windows and it has its own toolchain)

Isn’t the chainload toolchain mechanism in vcpkg here for this reason? I remember doing something like this to force gcc version...

@cenit That helps if you're using vcpkg.cmake as your toolchain and want to use a different compiler but not if you want to change the compiler used to build the ports themselves.

You're right. I did it many years ago and was not remembering even the project anymore...

@BillyONeal: Custom triplet with VCPKG_CHAINLOAD_TOOLCHAIN set..... That is how I built everything with clang-cl

Ah yes, thanks @Neumann-A ! @cwfitzgerald can you confirm that's an acceptable workaround?

So it was real, I did it too...

Hmmm OK. Going to close this for now; if folks have similar issues please open a new issue.


Avoid using minDFA dimensions unless necessary

Using minDFA incurs performance penalty. We should try to avoid using it, unless necessary.
For example, consider a containment query asking whether the allowed connections of network-config A are contained in those of network-config B. If the allowed connections of B have no minDFA dimensions, there is no point in considering these dimensions when computing the allowed connections of A (because they can only refine the set of allowed connections).
We should probably have a flag to control whether or not to compute minDFA dimensions, and so we need to do it lazely, and store the results separately. Hence, this issue depends on #496.

Moved to NP-Guard repo. See here


Updating the wordcount pom.xml

Explicitely excluding the bigtable-hbase-1.1 dependency from the
bigtable-hbase-mapreduce include.
Adding an explicit dependency on the correct hbase-server version
Moving up the hbase-client dependency.

LGTM


Add a compiler version check in build scons scripts

refer Question for the issue #319 that happens for older g++ compilers

in short we should check for version 4.8 or above.
If we can test 4.6 that would be good. And then we can lower the version check to 4.6

To be clear, this task is to add a check at the beginning of the scons build to verify that gcc 4.8 or better is installed before running the build.

Fixed via PR #832