Cannot set headers after they are sent - authorizationChecker called twice?

Using develop branch, bruce:1234 as creds, calling api/users/me results in this:
info: [auth:AuthService] Credentials provided by the client
info: [auth:authorizationChecker] Successfully checked credentials
info: [auth:AuthService] Credentials provided by the client
info: [api:middlewares] GET /api/users/me 200 97.256 ms - 147

info: [auth:authorizationChecker] Successfully checked credentials
info: [api:services\UserService] Find one user
Error [ERR_HTTP_HEADERS_SENT] [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (_http_outgoing.js:485:11)
    at ServerResponse.header (node_modules\express\lib\response.js:767:10)
    at ServerResponse.send (node_modules\express\lib\response.js:170:12)
    at ServerResponse.json (node_modules\express\lib\response.js:267:15)
    at ErrorHandlerMiddleware.error (src\api\middlewares\ErrorHandlerMiddleware.ts:18:13)
    at src\driver\express\ExpressDriver.ts:60:74
    at Layer.handle_error (node_modules\express\lib\router\layer.js:71:5)
    at trim_prefix (node_modules\express\lib\router\index.js:315:13)
    at node_modules\express\lib\router\index.js:284:7
    at Function.process_params (node_modules\express\lib\router\index.js:335:12)

curl -X GET \
  http://localhost:3000/api/users/me \
  -H 'Accept: */*' \
  -H 'Accept-Encoding: gzip, deflate' \
  -H 'Authorization: Basic YnJ1Y2U6MTIzNA==' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Host: localhost:3000' \
  -H 'cache-control: no-cache'

Fixed by changing @Get('/:id') to @Get('/:id([0-9]+)')
Route handler was matching both routes, causing the error


intra_target_test number

hi， may i have a question? Is the intra_target test de and fr means new_comments_defr？but i find that the number of intra-target_test_de+the number of intra_target_test_fr ！= the number of new_comments_defr.

Hi @OceanSnape, thank you for pointing this out!
I assume you are referring to Table 2 in the paper? It seems that the "Test" and "Valid" counts are mistakenly swapped in the first column.
The fixed table should look like this:


Add padding prior to text that's below buttons in documentation

In the documentation page when there's a text that's below a button (for example basic buttons) padding should be added above the text. This should be done to all same cases throughout the page.

Hi, I would like to attempt to solve this!

Hi, I would like to attempt to solve this!

I have a fix and a PR ready to go. Please let me know if I need to be officially assigned before I submit PR. (This is my first open-source contribution)

I have a fix and a PR ready to go. Please let me know if I need to be officially assigned before I submit PR. (This is my first open-source contribution)

Hello @jleckron you may submit the PR

Hello @jleckron you may submit the PR


refactor custom file lookup

Looks good, except that (unless there's a reason) I'd rather it be called get_custom_file over get_cstm_file?

@SchrodingersGat no problem, I will change this

Thanks for the refactor :)

@matmair bad news. This has broken stuff..
https://github.com/inventree/InvenTree/runs/7837878419?check_suite_focus=true
Basically, the invoke script makes use of this file and must run before django is installed. Classic chicken and egg.
I think we might have to revert this one? LMK if you can see a cleaner solution otherwise I'll rewind this.

@SchrodingersGat I will create a patch


TST: test codecove again; Do not merge

Another test, do not merge.

So, basically code coverage now works.  If we make a PR, test coverage should not go down, and ideally should go up.  We should aim for 100% test coverage at some point, but no rush.


[AERIE 2053] Add Sphinx Documentation Generation and Publishing

I'm testing some the sphinx actions workflows. And need a PR with which I can trigger them.

Can we add a link to the new documentation site on gh-pages from the repos top-level README.md?

That's the plan as soon as this is up!

Can we add some instructions for how to test this locally?

I got an error when initially installing Poetry (not important but it was because my local PIP was pointing to Artifactory). The failure wrote a log file poetry-installer-error-_ih5ur0n.log. Can we add *.log to Aerie top-level .gitignore?

Also probably for a future PR but the search results seem to still point to the scylladb docs. Is this easy to change?


I cannot run the bot on Heroku

Hi,
I have setup my bot on Heroku by using heroku-node-telegram-bot code examples but I am getting below error
<EMAIL_ADDRESS>start
 node index.js

/app/bot.js:7
  bot = new Bot(token);
        ^

TypeError: TelegramBot is not a constructor
    at Object.<anonymous> (/app/bot.js:7:9)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/app/index.js:1:11)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)

Process exited

Is there a way to fix it?

Add const before "bot"
// Create a bot that uses 'polling' to fetch new updates
const bot = new TelegramBot(token, {polling: true});

@Drakoniwe Thank you, the pervious problem has been solved
But I am receiving a new error which the logs telling that my bot token is not defined
><EMAIL_ADDRESS>start
> node index.js

node-telegram-bot-api deprecated Automatic enabling of cancellation of promises is deprecated.
In the future, you will have to enable it yourself.
See https://github.com/yagop/node-telegram-bot-api/issues/319. node:internal/modules/cjs/loader:1105:14
Bot server started in the production mode
/app/web.js:20
  app.post('/' + bot.token, (req, res) => {
                     ^

TypeError: Cannot read properties of undefined (reading 'token')
    at module.exports (/app/web.js:20:22)
    at Object.<anonymous> (/app/index.js:2:17)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Process exited

I have already defined my Heroku URL with the bot token so what's the problem

I have found the problem which it was my code
I edited "bot.token" to "token" (String variable) and the error was resolved.


Positioning Previous button in footer

Problem
I have a project that supplies an extrafooter block. It uses super() to invoke the base block before itself.
Reproducible Project
Please give a link to a public reproducible project or provide an example of the Restructured Text that gives an issue.
{% extends '!footer.html' %} {% block extrafooter %}
 {{ super() }}

 This work is licensed under a Creative Commons Attribution-ShareAlike 4.0 International License

{% endblock %}```

```css
/* Centers the Creative Commons Logo */
#cca {
	display: block;
	margin-left: 44%;
	margin_right: auto;
	width: 12%;
}

.txtc {
	text-align: center;
}

footer {
	text-align: center;
}```

#### Error Logs/Results

Place any images or error logs that might be able to help solve the issue here.

#### Expected Results

The entire footer should have it's text centered. This is happening. However on pages that display the `Previous` button, the button is centered. It would look much better if it was left justified. I have found no way to do this without modifying the base theme which I would much prefer to avoid. An non-breaking enhancement that would fix this problem would be to add `float: left` to the CSS for the `Previous` button.

### Environment Info

- Python Version: 3.6.5
- Sphinx Version: current installed with pip
- RTD Theme Version: current installed with pip

I took the base footer.html, added my customizations and then changed the positioning of the Previous button from float to float-left and got exactly what I wanted so the change is trivial if you want to implement it.


Indentation problem with bundled rst indent plugin

Steps to reproduce
If I use gg=G or gggqG, then lists indentation get messed up.
For example, from the following:
#.  potato
#.  banana
#. pineapple
#.  cocumber

I have the following result:
#.  potato
   #.  banana
      #. pineapple
         #.  cocumber

after I  gggqG.
I tried to add a blank line between each item but the problem is still there.
I tried the solutions proposed here but:

By using setlocal indentexpr="" the problem won't show up,  but then all the other misindented parts of the documents won't be touched. Still on this point, if I add the line  setlocal indentexpr="" in .vim/after/ftplugin/rst.vim and then I :set indentexpr? in the rst file that I am editing, I get indentexpr=GetRSTIndent()
By using set formatoptions+=n does not solve the issue.

I am not sure if that is the wanted behavior, but to me it sounds a bit strange.
Expected behaviour
This:
#.  potato
#.  banana
#. pineapple
#.  cocumber

Should stay as it when issuing gggqG or gg=G.
Version of Vim
1-793 (Appimage)
Environment
WSL2 with Ubuntu 22.04. Windows Terminal.
Logs and stack traces
No response

I cannot reproduce this, but for me it fails differently, it joins all lines to a single line. In any case I think this is for you @marshallward

This is not just restricted to the example above.  Any list appears to do the same:
* potato
* banana
* pineapple
* cocumber

I believe that this is not strictly correct reST syntax, since a blank line is supposed to be placed in-between each line.  See the specification examples.
That's not to say that it could not be made to work.  Regardless of validity, this is a very common pattern.  But there may be certain cases which are unparseable.
As for the behavior, it appears to always indent by two spaces if the previous line is enumerated.  I would need to think about how to resolve this problem.

FWIW, gq is using formatprg/formatexpr/builtin formatting. There is no external tool I know of that can do format of an arbitrary reStructuredText document, bundled ftplugin/rst.vim doesn't define formatexpr -- thus gq uses internal formatting logic which knows nothing about rst lists.
So this is more about indentation with gg=G. My indent logic handles this case but it works different to bundled one: https://github.com/habamax/vim-rst/blob/master/indent/rst.vim

+1 for @habamax . Actually the plugin is for indenting, not formatting. However, here is what happens when I visually select text and then hit =:
FWIW, and only for the sake of sharing my findings,

I found someone else with the same issue.
The only formatter that I found is rstfmt that I associated to formatprg for rst files and that is not perfect but works reasonably good
I also tried esbonio along with yegappan/lsp but the former still needs more development, so I dropped it. I haven't found any other rst-LSP.
I found doc8  that could be associated to makeprg or one could place signs on the current buffer by relying on e.g. systemlist($'doc8 {expand("%")} -q'). However, the rule that we are discussing does not seem to be tackled by doc8.


shortcuts are incompatible with macOs

When you install brackets-emmet on macOs, it uses shift-command-up and shift-command-down  for the "increment/decrement number by one" functions. These shortcuts are used for basic editing on Macs (select to start/end of document) and probably shouldn't be taken.

I attached some plain text editing shortcuts on macOs. Since even the most zealous Apple fanboys won't know most of these, you can probably get away with just avoiding the primary shortcuts in the "cursor movement", "editing", and "search" sections.
macOs-shortcuts.txt


Revert "Protect the latest event from automatic deletion when using MySQL"

Reverts cantino/huginn#1974 due to #1991.

Btw @knu


Using this on the Stratis Bitcoin node

I wonder if this is stable enough to use on our fullnode instead of BC
https://github.com/stratisproject/StratisBitcoinFullNode

This wrapper is pretty minimal and I believe there are at least 2 usages of this in production. The native C lib is certainly stable (used by bitcoin and ethereum).

Awesome thanks will give it a try.


Update aybike.json

Cinsiyet added.

Hey @mrhasankoc,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: df4bec10-fa60-11e9-97f1-ff8640b58534


UnitTest -> Pytest

Updated tests to run with pytest
Updated lodash to latest version, per vulnerability alert
Updated circleCI to run all tests for all plugins, during build

Can you write a basic step by step tidbit about what changes you made to convert unittest => pytest? For me later when I do rb pipeline plugin

Main changes:

ensure class names start with Test
remove unittest.TestCase from class inheritence
import mock instead of from unittest import mock
use the setup_class(cls) class method instead of SetupClass (cls ~= self) (docs)
self.assertEqual(x,y) -> assert x == y
self.assertRaises(x,y,z) -> with pytest.raises(x): \n y(z)
other asserts need to be assert {boolean}


Create Apixu Provider

I created this for personal use, maybe someone else might enjoy using it as well.
They provide the weather details I desire with a free tier. Their location lookup supports zip codes, cities, or location codes like airport codes.

Cheers @tonsit, apologies for the late response, had a few offline things eating up all my free time recently.
I'll test this as soon as I get a chance and get it merged :+1:

Apixu was bought out by another provider.


Phone number: Canonical has changed.

A couple more tests have been added to canonical data in x-common for the phone number exercise.
Task List

[ ] pull exercism/x-common master branch
[ ] generate phone-number
[ ] review the new PR

References and Closures

references: exercism/x-common#745

@hilary is this something you are working on at the moment?  I have also pointed this issue out to an "Exercismologist" in the Ruby track that noticed the problem as well.  I don't know if they will tackle it...

@kotp I'm not working on updating individual exercises at this point. I'm hoping that we'll get more folks involved in doing that now that working with generators is more streamlined.

https://github.com/exercism/x-common/blob/master/exercises/phone-number/canonical-data.json


German time format

Hello
is it possible in German time format?
Day.Month.Year
05.06.2024
Best regards

Not possible today, but customizable date/time formats is something I have on the roadmap to add.

Nice! Please make sure to include the ISO8601 format (or make it the default) so YYYY-MM-DD


Do not error out on malformed yaml

Make default executor Graph method not completely error out when
encountering an unparseable yaml file.
Signed-off-by: Fredrik Lönnegren<EMAIL_ADDRESS>

Not sure about this one 🤔
Esp. given that yip runs on the client (mostly unattended), erroring out completely might be a better option that just a logging a warning. Errors might be hard to track down ...
Side node: We really need to find a way to export state/logs from a node to elemental-operator (resp. the UI).

Not sure about this one 🤔 Esp. given that yip runs on the client (mostly unattended), erroring out completely might be a better option that just a logging a warning. Errors might be hard to track down ...

Good point! I will probably need to test this with an upgrade as well, since the health-checker might detect this...
My original problem was that when installing a new system and accidentally leaving a malformed yaml in /system/oem, I would not be able to even log in to see what was the error.

Side node: We really need to find a way to export state/logs from a node to elemental-operator (resp. the UI).

Agree on the export of logs!

Not sure about this one 🤔 Esp. given that yip runs on the client (mostly unattended), erroring out completely might be a better option that just a logging a warning. Errors might be hard to track down ...
Side node: We really need to find a way to export state/logs from a node to elemental-operator (resp. the UI).

Just giving a bit of more context of what we are trying to solve here. Error managing in yip and its integration in elemental is not sophisticated. If yip fails, by default, we are not marking as failed the actual service invoking it. The reason for that is to not prevent to the system to boot. So even if there are errors in yip the boot process continues normally unless we set the strict flag in elemental toolkit configuration.
If a malformed yaml in /oem gets into the system this could potentially prevent any yip setup to be executed at boot. So probably a better behavior could be simply accumulate all errors until the process is done and only after error out if something occurred.
Also a long standing idea we never implemented was to distinguish error types and react differently accordingly. As of today yip is binary: error true or false. We can't easily the type of error (internal of yip or caused by yaml execution, etc.).

I'm mostly concerned about "it somehow doesn't work" bug reports because somewhere, some yaml failed to get parsed and there's no way (besides ssh-ing into the node) to know what's going on.
Currently such a problem is very obvious, simply because the node wouldn't even boot. I agree that this is bad (you can't ssh into a non-booted node) and good (errors bubble up spectacuously 😆 ) at the same time.

@kkaempf @davidcassany How do you feel about the new implementation? It will return the loading-error after executing the valid yaml-files.


Chocolatey Package?

Think you can make this a Chocolatey Package (apt-get on windows)? I don't mind helping you get it going.
Basically the advantage would be 2 fold:

people could just choco install psattack from their shells
updating would just be choco update psattack to update their versions

Thanks for the idea, I'll look into it and see if it's a good fit for the project. Do you know of any example packages that pull from github repos? I did some real quick googling but didn't find anything.

I believe that atom’s chocolatey package pulls from github.

On Jul 21, 2016, at 8:42 AM, Jared Haight<EMAIL_ADDRESS>wrote:
Thanks for the idea, I'll look into it and see if it's a good fit for the project. Do you know of any example packages that pull from github repos? I did some real quick googling but didn't find anything.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/jaredhaight/PSAttack/issues/20#issuecomment-234241784, or mute the thread https://github.com/notifications/unsubscribe-auth/AFJkaEu42GBT5LaL9lgOPt8nQH8AQpl0ks5qX2lOgaJpZM4JRAHL.

@jaredhaight  something like appveyor can do it pretty easily. appveyor has an environment variable that tells you if the current build has a tag for the sha you are building.
http://www.appveyor.com/docs/deployment#deploy-on-tag-github-and-gitlab-only
you could easily pack/push a package if that variable is set.
https://github.com/TerribleDev/QuikPak/blob/master/build.cmd
all you need is a nuspec file
https://github.com/TerribleDev/QuikPak/blob/master/QuikPak/choco/quikpak.nuspec
and some commands to push it
choco push ./path/to/yourpkg -apiKey %Secure_Variable_Here%
you can just place your exe, and files in the root of the package and chocolatey will automatically add those to your path.
My example isn't totally ci'd (like the version is not set, nor the package is pushed by the current tag), but my project was beyond simple, and I was too lazy. That being said it is 100% feasible to do so..

Closing this for now. Might revisit in the future. Thanks for the suggestion!


tests failing with move to coreutils 9.4 from 9.1

First example: tests/cp/backup-is-src.sh (fails in 9.4, passes in 9.1)

looking at the log, first thing that jumps out is:
-XXX: backing up 'a' might destroy source;  'a~' not copied
+Äø: backing up 'a' might destroy source;  'a~' not copied

A simpler example:
FULTONM@ZOSCAN2B /tmp>cp a a
��: 'a' and 'a' are the same file

FULTONM@ZOSCAN2B /tmp>/home/fultonm/zopen/usr/local/bin/cp -b a b
��: cannot backup 'b': EDC5111I Permission denied.

is another example (the permission denied is expected but the invalid characters at the start are not)

verified with 9.1, this works properly

gettext is driven from:
./src/system.h:#define _(msgid) gettext (msgid)

The expected result should be 'cp:' ...
./src/cp.c defines PROGRAM_NAME "cp"
AH-HA! Problem with 'getprogname' (saw this before) where it is getting an EBCDIC progname.

lib/getprogname.c - now to remember where this was 'fixed' elsewhere...

also fixed in man-dbport: https://github.com/ZOSOpenTools/man-dbport/blob/main/tarball-patches/getprogname.c.patch

it appears that there is nothing wrong with the getprogname code compared to man-dbport - the issue is that the underlying runtime service seems to be returning ASCII data already for the filename - and so we are double-converting.
Since the system I am running on is a z/OS 2.4 system, either I am doing something fundamentally wrong or a PTF was applied to LE, changing the behaviour (or another possibility would be that the clang compiler pulls in different header files?)

xlclang -qascii gives the same results...

changing this code reduced the number of failures by 62 for the subset of tests analyzed

total number of failures now 128, with 8 errors.


fix: issue with functions in useStore for typescript

Description
Please provide the following information:
Add ReturnType<...> to packages/core/src/helpers/get-typed-function.ts.
We don't want to return the complete function as a return type. Instead we want to return the return type of the function.
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

[x] format the codebase: from the root, run yarn fmt:prettier.
[x] update all snapshots (in core & CLI): from the root, run yarn test:update
[x] add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@samijaber sorry I missed this problem in my PR :(


2.x Add CODEOWNERS file

Ticket: #1945

@jarednova Ha, this is cool! A review is required, but I can’t self-review this 😄.

Review ✅ back to you for merging!


fix: always respect aztec image pull policy

with template for copy-pasta safety.

I suppose this is the way to make sure this doesn't churn


Improve error when an event signature isn't matched

Event signatures must be supplied without spaces in the subgraph manifest.  The error does reference an incorrect event signature which is great, but it is not obvious that one must remove spaces as well as supplying the right set of types.

I'm now thinking the preferable solution here is to remove white spaces when parsing the event signature, reducing the number of instructions/steps one must be aware of.  I haven't yet come up with a scenario where white spaces being removed would be undesirable.


Request data out of order when mixing strings & files

Laravel Version: 5.5.31
PHP Version: 7.1

Description:
When making a request with an input array that mixes strings and files the order is not the same as the original request, although the keys are correct.
I'm not sure if this is intended behaviour or if it's such a massive problem that's worth fixing.
Steps To Reproduce:
I've setup a failing test case in the laravel/framework repo that illustrates the issue.
It's probably more obvious with this example as in some production code I have a test that does something like this:
$response = $this->postJson('/my/endpoint', [
    'images' => [
        File::image('image1.jpg'),
        File::image('image1.jpg'),
        'already-uploaded-image.jpg',
        File::image('image3.jpg'),
    ]
]);

Then running dd(request('images')) in the controller outputs:
array:4 [
  2 => "already-uploaded-image.jpg"
  0 => Illuminate\Http\Testing\File {#984
    // ...
  }
  1 => Illuminate\Http\Testing\File {#986
    // ...
  }
  3 => Illuminate\Http\Testing\File {#982
    // ...
  }
]

So just doing a loop over this the results are out of order with what I am expecting.

Remove array_values() in your test function and retrieve the element of $request['images'] directly such as $request['images'][1], the test result should be green.
ksort() just sort keys and the order of values don't change
If you want to retrieve the original ordered array, you should use for loops like this:

$length = count($request['images']);

for ($i = 0; $i < $length; $i++) {
    var_dump($i);
    echo "=====>";
    var_dump($request['images'][$i]);
}

Closing as it's been decided it wont be fixed.


Fix extra spaces added around titles when escaping HTML

What is the context of this PR?
To fix a failing runner test because when testing escaping HTML for the address pattern it was adding spaces either side of the question title.
Also fixes some indentation in the address macro
How to review
Check question example and see that in the HTML the whitespace around the question title text is now gone

 Fix to remove whitespace around question titles for runner tests


How to use option '-p'

I create a file named "private_key"(maybe i'm right ^~^), and push the md5 value of example into "private_key".Then I perform './license_generator example -o example.lic -p private_key'. I try any ways i can do, but private_key likes is unuse , i have modified this, or delete this .So, is there anyone who knows how to use option '-p'?

I have the same problem, it seems that the option -p is not used.
Looking at the code in license-generator.cpp:

I don't see any use of the key "private_key".
generateAndOutputLicenses uses the hard-coded PRIVATE_KEY.

this is linked to issue #61
also it should also be possible to handle multiple private keys


Add type and prefix directory when importing main.js

RSB will not work in a hybrid mobile app environment (i.e. cordova) unless

This may not work when you open a page such as www.example.com/some/page

RSB is ideal for use with Cordova, but there are a few problems with the code that prevents cordova from symlinking the www to RSB public. I've worked through most of the incompatibilities and will post as an issue for discussion.
I'm not seeing the problem you describe of /some/page not loading.


Add molecule annotations/notes to MolDraw2D

Adds the general ability to do molecule annotations based on the molNote property:

Mol notes are rendered with the same font size as atom labels, not the smaller font size used by atom/bond notes)
Adds an option to add the "ABS" note to renderings when the chiral flag is set:

Adds an option to simplify the rendering of molecules where all specified chiral centers are in the same StereoGroup. So this rendering:

becomes this:

The equivalent situation where all atoms are in an and group is:

@greglandrum some conflicts popped up

@greglandrum some conflicts popped up

I'm shocked! Shocked!
;-)

Conflicts resolved

Thanks a lot for this feature! Does it work with multi-line annotations?


グノーシア (GNOSIA) [PCSG01277]

App summary

App name: グノーシア
App serial: PCSG01277
App version: 1.00

Vita3K summary

Version: v0.1.3
Build number: 2253
Commit hash: https://github.com/vita3k/vita3k/commit/96d5dba9
CPU backend: Dynarmic

Test environment summary

Tested by: jack
OS: Windows 10
CPU: Intel Core i7-7700HQ
GPU: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
RAM: 16 GB

Issues
Hangs on title screen.
Screenshots

Log
vita3k.log
Recommended labels

Intro
Crash

noàcrash and no intro, is like some game, just no more boot and stuck on splash screen

@sotakoira You tried to run the game without installing the PlayStation Vita firmware and font package into the emulator.
Please read the Vita3K quickstart guide and follow the "Installing the firmware" to install both packages (you will have to use the option twice, one for each package) and then try to run the game again.

Issue:

die on kernel abort

Log
vita3k.log

Vita3K v0.1.5 2724-4cc25397
still nothing
vita3k.log

please change title to Gnosia [PCSG01277]

Bootable with Unicorn

vita3k.log

as of https://github.com/Vita3K/Vita3K/commit/da8a6933d87478ca3425e27d47736a409b1bf85f, the game is now in intro with dynarmic, unlike unicorn in which it crashed with a illegal instruction error while attempting to boot.
Screenshot

Log
vita3k.log
Recommended Labels

Intro
regression


Pre-trained Weights

Hi there,
On the Ramp website it says:

Training Data, Model Weights – MLHub
To download the ramp training data and pretrained baseline model weights, visit our partner Radiant Earth Foundation’s MLHub using the button below.

But at that resource I cannot find any weights or .tf files.
Are the pre-trained model weights available or can the direct link be provided?

Actually, I just found where the weights are!  It would be helpful to include a direct link on the docs page. https://mlhub.earth/model/model_ramp_baseline_v1


String to bytes conversion issue

The given examples don't work as they will always created one single string and not multiple keywords. The first example creates a dictionary with only one string:
"aarskog's syndrome, abandonment, abasia, abderhalden-kaufmann-lignac, abdominalgia, abduction contracture, abetalipo proteinemia, abiotrophy, ablatio, ablation, ablepharia, abocclusion, abolition, aborter, abortion, abortus, aboulomania, abrami's disease, abramo"
But it should create multiple strings as array:
aarskog's syndrome
abandonment
abasia
abderhalden-kaufmann-lignac
abdominalgia
abduction contracture
abetalipo proteinemia
abiotrophy
ablatio
ablation
ablepharia
abocclusion
abolition
aborter
abortion
abortus
aboulomania
abrami's disease
abramo
The correct PowerShell command would be as follows:
$Keywords = "Aarskog's syndrome","Abandonment","Abasia","Abderhalden-Kaufmann-Lignac","Abdominalgia","Abduction contracture","Abetalipo proteinemia","Abiotrophy","Ablatio","ablation","Ablepharia","Abocclusion","Abolition","Aborter","Abortion","Abortus","Aboulomania","Abrami's disease","Abramo"; $EncodedKeywords = $Keywords | ForEach-Object{[system.Text.Encoding]::UTF8.GetBytes($_+"rn")}; New-DlpKeywordDictionary -Identity "Diseases" -Description "Names of diseases and injuries from ICD-10-CM lexicon" -FileData $EncodedKeywords
If you create the dictionary as described in your example, it won't match.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b014888-db76-1e1a-d067-bf03148815db
Version Independent ID: 22ed9044-8fd9-213b-44f9-8965846766b6
Content: New-DlpKeywordDictionary (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance-dlp/New-DlpKeywordDictionary.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @IngoGege, thank you for your feedback.
I think the examples are ok:

Second one is your example. Reading the parameter description:
The FileData parameter specifies the terms that are used in the DLP keyword dictionary. This parameter requires a comma-separated list of values that's binary encoded in UTF8. For more information, see the examples in this topic.

Hi @dariomws306 ,
I get that, but have you actually tried it? If so you will see that there won't be a match. You can compare the decoded bytes and you will see that the list is not a list. It's one line with comma separated words, which is treated by the DLPAgent as one string and therefore won't match.
Ciao,
Ingo

Thank you @IngoGege.
I didn't try it deeply, only saw that it looks good. I will try it again tomorrow.

Hi @IngoGege,
Sorry for the delay.
I have been testing it and it's true that the example doesn't match:

But I get the same behaviour with your example:

So I'm trying to find the right way to create the list of strings.
@chrisda maybe you can help.
Thanks to both!

@dariomws306 @yogkumgit sorry for the delay. Actually I just figured out that the special characters were removed:
$Keywords = "Aarskog's syndrome","Abandonment","Abasia","Abderhalden-Kaufmann-Lignac","Abdominalgia","Abduction contracture","Abetalipo proteinemia","Abiotrophy","Ablatio","ablation","Ablepharia","Abocclusion","Abolition","Aborter","Abortion","Abortus","Aboulomania","Abrami's disease","Abramo"; $EncodedKeywords = $Keywords | ForEach-Object{[system.Text.Encoding]::UTF8.GetBytes($_+"rn")}; New-DlpKeywordDictionary -Identity "Diseases" -Description "Names of diseases and injuries from ICD-10-CM lexicon" -FileData $EncodedKeywords
The character "`" was missing. I've tested 2 possible solutions and documented them here:
https://ingogegenwarth.wordpress.com/2019/10/31/office-365-dlp-pesky-keyword-dictionaries/
The change you merged needs to be updated.
Ciao,
Ingo

Thank you @IngoGege!
I have tested and it works perfect. I'm updating example 1 and example 2 also as it has the same problem.

@chrisda Please merge this PR #4446

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @IngoGege Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Compilation errors with rustc 1.64.0-nightly

Compiling 0.6.1 with current rustc 1.64.0-nightly (2643b1646 2022-07-27) results in multiple errors ambiguous associated type 'MetaData'.

I saw the same issue and I believe that I managed to fix it.  I am relatively new to Rust, so there may be a much better fix.   To fix the ambiguity, for each of the places where there was ambiguity, I clarified that the item has the type generic_json::Json.
Here is an example of one of the changes that I made to src/compaction/mod.rs.
I changed:
M: 'a + Send + Sync + Clone + Fn(Option<&J::MetaData>) -> K::MetaData;
to:
M: 'a + Send + Sync + Clone + Fn(Option<&J::MetaData>) -> ::MetaData;
Similar changes need to be made to all cases.

It almost seems like a bug in the compiler. Chasing the patch that you suggested, one of the suggestions from the compiler was
error[E0221]: ambiguous associated type `MetaData` in bounds of `K`
   --> src/indexed.rs:142:72
    |
142 |     fn as_json_with(&self, meta: impl Clone + Fn(Option<&J::MetaData>) -> K::MetaData) -> K {
    |                                                                           ^^^^^^^^^^^ ambiguous associated type `MetaData`
    |
    = note: associated type `K` could derive from `generic_json::Json`
    = note: associated type `K` could derive from `generic_json::Json`

I'd have expected duplicate identical derivations would unify

Also, for those interested, the build that broke this was nightly release 7c4b47696 2022-04-30. Last known good version was e85edd9a8 2022-04-28

Yes this is a recurrent issue that keeps popping with new nightly releases. My goal is now to remove the trait_alias feature that causes a lot of problems and is not going to be stabilized soon. See #37 for more info. Once GATs are stabilized, then json_ld will be usable with stable Rust, and we won't have this kind of issues anymore.

Sorry, drive-by-er at the moment. The GATs that this blog says are stable in 1.65 coming Nov 3rd (tomorrow)?
https://blog.rust-lang.org/2022/10/28/gats-stabilization.html

@FrankReh that's right, and I already released a beta version no crates.io that works with this version. I have some more testing and documentation to write before I can safely remove the -beta label.

I've just release version 0.9.1, which work with stable Rust 1.65. The transition from the old architecture may be rough, please don't hesitate to ask if you need help transitioning.
This should solve this issue.


[docs] Improve Dashboard template

Refactor of methods "handleDrawerOpen" and "handleDrawerClose" into only one.

[x] I have followed (at least) the PR section of the contributing guide.

@pak1989 Thanks!


libsForQt5.quazip: 0.9.1 -> 1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/quazip/versions.
meta.description for libsForQt5.quazip is: "Provides access to ZIP archives from Qt programs"
meta.homepage for libsForQt5.quazip is: "https://stachenov.github.io/quazip/"
meta.changelog for libsForQt5.quazip is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.1 with grep in /nix/store/jqdl9lm0n67829b2skl0jkbaa6mhsqqd-quazip-1.1

directory tree listing: https://gist.github.com/453e939ad1e1524f4a12d6bcf0b3a428

du listing: https://gist.github.com/0453e51028b57b614f7327d2cbdcc0b7

Rebuild report (if merged into master) (click to expand)

43 total rebuild path(s)

12 package rebuild(s)

12 x86_64-linux rebuild(s)
12 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
11 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gmic-qt-krita
keepassxc
krita
libsForQt5.quazip
libsForQt512.quazip
libsForQt514.quazip
libsForQt515.quazip
nomacs
qmapshack
quazip_qt4
screencloud
teamspeak_client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jqdl9lm0n67829b2skl0jkbaa6mhsqqd-quazip-1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libsForQt5.quazip https://github.com/r-ryantm/nixpkgs/archive/ded97a6900b6a8ea1bae5677f19c056c7ebc146f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jqdl9lm0n67829b2skl0jkbaa6mhsqqd-quazip-1.1
ls -la /nix/store/jqdl9lm0n67829b2skl0jkbaa6mhsqqd-quazip-1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 103254 run on x86_64-darwin 1

2 packages marked as broken and skipped:

gmic-qt-krita
quazip_qt4

2 packages failed to build and already failed to build on hydra master:

keepassxc: log https://termbin.com/e9qp
nomacs: log https://termbin.com/8y4t

3 packages built:

libsForQt5.quazip (libsForQt512.quazip)
libsForQt514.quazip
libsForQt515.quazip

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
keepassxc:

Please consider this feature to be alpha.
A substituteInPlace with an unused --replace got detected:
substituteStream(): WARNING: pattern '/usr/local/bin' doesn't match anything in file 'CMakeLists.txt'
substituteStream(): WARNING: pattern '/usr/local/share/man' doesn't match anything in file 'CMakeLists.txt'

Please check the offending substituteInPlace for typos or changes in source.
warning: build-tools-in-build-inputs
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/misc/keepassx/community.nix:95:3:
   |
95 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/applications/misc/keepassx/community.nix:85:3:
   |
85 |   checkPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/keepassx/community.nix:127:5:
    |
127 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 103254 run on x86_64-darwin 1

2 packages marked as broken and skipped:

gmic-qt-krita
quazip_qt4

2 packages failed to build and already failed to build on hydra master:

keepassxc: log https://termbin.com/e9qp
nomacs: log https://termbin.com/8y4t

3 packages built:

libsForQt5.quazip (libsForQt512.quazip)
libsForQt514.quazip
libsForQt515.quazip

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
keepassxc:

Please consider this feature to be alpha.
A substituteInPlace with an unused --replace got detected:
substituteStream(): WARNING: pattern '/usr/local/bin' doesn't match anything in file 'CMakeLists.txt'
substituteStream(): WARNING: pattern '/usr/local/share/man' doesn't match anything in file 'CMakeLists.txt'

Please check the offending substituteInPlace for typos or changes in source.
warning: build-tools-in-build-inputs
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/misc/keepassx/community.nix:95:3:
   |
95 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.
Near pkgs/applications/misc/keepassx/community.nix:85:3:
   |
85 |   checkPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/keepassx/community.nix:127:5:
    |
127 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 103254 run on x86_64-linux 1

1 package marked as broken and skipped:

screencloud

3 packages failed to build and are new build failures:

nomacs: log https://termbin.com/gx12
qmapshack: log https://termbin.com/k31u
quazip_qt4: log https://termbin.com/iqxj

7 packages built:

gmic-qt-krita
keepassxc
krita
libsForQt5.quazip (libsForQt515.quazip)
libsForQt512.quazip
libsForQt514.quazip
teamspeak_client

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 103254 run on x86_64-linux 1

1 package marked as broken and skipped:

screencloud

3 packages failed to build and are new build failures:

nomacs: log https://termbin.com/gx12
qmapshack: log https://termbin.com/k31u
quazip_qt4: log https://termbin.com/iqxj

7 packages built:

gmic-qt-krita
keepassxc
krita
libsForQt5.quazip (libsForQt515.quazip)
libsForQt512.quazip
libsForQt514.quazip
teamspeak_client


[polygon] Improve get function to return geometry of any region

Returns the MULTIPOLYGON data for the requested region.
Input: ISO3 Country Code, and further subdivisions
Examples:

get("IND") - Returns polygon of India
get("IND", "Uttar Pradesh") - Returns polygon of the state Uttar Pradesh
get("IND", "Uttar Pradesh", "Lucknow") - Returns polygon of district Lucknow

Checks:

[x] Improve get command
[ ] Change description of command
[ ] Write tests

Example

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           31        45   +14
=========================================
+ Hits            31        45   +14

Impacted Files
Coverage Δ

src/polygon.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c1c01...1510083. Read the comment docs.


Option to recycle soldiers

Sometimes you accidentally spawn a unit that you have no use for in a squad, for example you spawn an engineer instead of an AT Rifleman. There should be another way than shooting them :)

There is.... Group management inside the action menu

Whoops, totally missed that one, thought it was only for human players! My bad


Unable to run website locally

Hi all. I was trying to run website locally without Docker and it failed. I use Ruby 3.0.3 and it doesn't work. Seems like the issue comes from Jekyll itself based on this issue https://github.com/jekyll/jekyll/issues/8523
So, to solve this, I install webrick manually via bundle add webrick and now the local website is able to run locally.
Do I need to add this information in the README so anyone who faces this issue can solve it? Or are we planning to explicitly add webrick in Gemfile?

hi @lunchboxav thanks for raising this
im not too sure exactly how the website is currently put together, my inclination is to replace it with something js/react
what i do know is that netlify builds the site currently from the repo config, and jekyll build
if you are having trouble getting it to build, i would in the first instance look at the versions that are being used - eg https://github.com/envoyproxy/envoyproxy.github.io/blob/main/.ruby-version

Ah yes thanks for the reply @phlax. I did experience an issue but I found the solution. And yeah, I use Ruby 3.0.3, and the README only mentions using Ruby version 2.1.0 up.
Do you think it's better if I add a note in the README as a solution for this? In case somebody else has the same environment and face similar issue.

Do you think it's better if I add a note in the README

yep, i think that would be helpful
incidentally there is a netlify way of building where you reproduce ci - not sure if you need a netlify account to do that tho

as an update to this, i am adding a bazel workspace to this repo #235
this will make it much easier to manage versions, and have reproducible builds
with the new setup you will only need bazel to build the site locally, and builds will be hermetic etc
wrt the ruby version, it will be set to 2.7.2 as this is the version that comes by default with netlify so speeds up CI
if that version of ruby is not available on your host/env, it will compile ruby - which can be slow, but it only needs to do it once. Having the correct version avoids the need to do this.
i will update the README docs after i land this, it seems there are quite a few things out of date

this should be resolved now - README is updated with new way/s of running/developing the site locally


Coverage for CS

Coverage for Container Security.
REST API endpoints:
https://docs.tenable.com/cloud/containersecurity/api/Content/API.htm

This is done since last release.


Depth issue when post-processing is disabled.

To repro, run the RenderTarget demo with #3500.  Screenshot below.  Occurs with all backends.

@pixelflinger, this happens when post processing is disabled for an offscreen render target. Do we not allocate a depth buffer or something?

Not that I know. I would be interesting to look at the framegraph.

This is not a Filament bug, the demo is not creating a depth attachment.  facepalm


What about using next-routes?

I'm brand new to the Next.js world and I'm trying to see what packages everybody uses. I noticed you're not using next-routes in this boilerplate.
I'm just curious to know if this is something you considered? Are there any downsides to using it?

Hey @SachaG, "next-routes" is way better than "next-url-prettifier" (also I contribute to next-routes 😆 ) But When I started to work on RAN!, "next-url-prettifier" was more suitable for all config of RAN!. I'm thinking about it but off course, contributions are warmly welcome! :)

OK, thanks! Just wanted to confirm :) I'm still learning Next but I'll try to contribute when I'm a bit more familiar with everything!

Hey @SachaG, you can use RAN! with next-routes on the new version. :)
https://github.com/Sly777/ran/releases/tag/0.4.0

Really cool thanks!


Allow to tag a method that it should override another method.

I'd rather not add more Object extensions where there's already syntax for this. What about just using $Override instead of adding the re macro?

I'd also perfer $Override to additional macro.

The purpose of the re def is to make declaring the expectation of overriding a method very easily accessible (as syntactic sugar), as opposed to the Java @Override line, which consumes a full line, while re def consumes just 3 extra characters. I would also just like to consume 2 extra characters and have a redef method definition keyword, if this would be accepted.
Consider these examples
Without annotation, but error-prone:
  def visitClosureDefinition(classdef, expression)
    visitClassDefinition(classdef, expression)
  end

  def visitInterfaceDeclaration(idef, expression)
    visitClassDefinition(idef, expression)
  end

  def visitFieldAnnotationRequest(decl, expression)
    @types.getNullType()
  end

re def:
  re def visitClosureDefinition(classdef, expression)
    visitClassDefinition(classdef, expression)
  end

  re def visitInterfaceDeclaration(idef, expression)
    visitClassDefinition(idef, expression)
  end

  re def visitFieldAnnotationRequest(decl, expression)
    @types.getNullType()
  end

$Override, Java-style:
  $Override
  def visitClosureDefinition(classdef, expression)
    visitClassDefinition(classdef, expression)
  end

  $Override
  def visitInterfaceDeclaration(idef, expression)
    visitClassDefinition(idef, expression)
  end

  $Override
  def visitFieldAnnotationRequest(decl, expression)
    @types.getNullType()
  end

override def`:
  override def visitClosureDefinition(classdef, expression)
    visitClassDefinition(classdef, expression)
  end

  override def visitInterfaceDeclaration(idef, expression)
    visitClassDefinition(idef, expression)
  end

  override def visitFieldAnnotationRequest(decl, expression)
    @types.getNullType()
  end

redef:
  redef visitClosureDefinition(classdef, expression)
    visitClassDefinition(classdef, expression)
  end

  redef visitInterfaceDeclaration(idef, expression)
    visitClassDefinition(idef, expression)
  end

  redef visitFieldAnnotationRequest(decl, expression)
    @types.getNullType()
  end

Note that for bigger projects, a substantial amount of all methods are overridden, so the re macro will be there very often. To aid readability, the syntax to express the override-intent should be as small and as unintrusive as possible. Hence, it needs to be short, without visually strong (and thus detracting) symbols such as $. Also, re def reads "re-define [this method]", which essentially captures the override-intent.
Note that redef is actually not perfect, because sometimes the overridden method is actually not defined (e.g. if it was abstract or if it comes from an interfaces).
Another suggestion thus would be to have, instead of just def, 3 keywords to define a method:

def: define a new method and expect to not override an existing method of a supertype
redef: override an existing method
implement: define a method which overrides an abstract method of a supertype (superclass or superinterface)

Every time we add a new keyword (whether in the parser or by extending Object) we make it hard to interact with any java code which uses that as a package, class or member name. ("re" is a common abbreviation for "regexp" so I have a hard time imagining there's no java code using it.) I strongly prefer any option that does not require adding new keywords.

Every time we add a new keyword (whether in the parser or by extending Object) we make it hard to interact with any java code which uses that as a package, class or member name. ("re" is a common abbreviation for "regexp" so I have a hard time imagining there's no java code using it.)

Sure. However, the keyword(s) which would hide any package class or member name would be redef and maybe implement, if we would go the keyword route. The re macro would not hide any package class or member name, as it is a macro, which only applies to MethodDefinitions. Hence, there is no collision with an identifier "re" which may represent a regular expression or anything else.

I strongly prefer any option that does not require adding new keywords.

The re-macro satisfies your preference.


Backticks inserted into wrong place when executing DB::raw() expressions alongside ->withSum(...)

Laravel Version
10.42.0
PHP Version
8.2.12
Database Driver & Version
MySQL 8.2.0 on linux/arm64
Description
Recently upgraded to Laravel 10 from 9 - have substituted our DB::raw() expressions with the new (string) DB::raw(...)->getValue(DB::connection()->getQueryGrammar()) as directed in the upgrade guide because the ->withSum() no longer accepts an expression (presumably down to the loss of string casting).

As you can see from the above screenshot the expression has been grossly misinterpreted and the backticks have been placed in some pretty wacky places. Adding the backticks myself didn't work.
Here's a snippet of one of the offending withSum lines
$query->withSum([
            'revenueEntryLineItems as actual_revenue_gross' => function ($query) {
                $query->leftJoin('tax_rates', 'revenue_entry_line_items.tax_rate_id', 'tax_rates.id');
             },
        ], (string) DB::raw('((revenue_entry_line_items.unit_price * revenue_entry_line_items.quantity) / 100) * (100 + COALESCE(tax_rates.rate, 0))')->getValue(DB::connection()->getQueryGrammar()));

Steps To Reproduce
Try a funky expression in a withSum

Update: This also happens when avoiding DB::raw entirely and passing an expression as a string

From the upgrade guide:

Casting an expression to a string using (string) is no longer supported.

I'm sorry, but we no longer support casting to a string. Did you already try just using the DB::raw() call without the type cast?

@driesvints The string cast is just to make phpstan as happy as you are at hitting that close as completed button because the ->getValue(...) returns a string|int|float, however in this scenario this is always going to be a string.
The issue here is that the wrapping is being performed incorrectly.

as happy as you are at hitting that close as completed button

I don't really appreciate the passive/aggressive tone here. Feel free to attempt a PR to the docs or the framework if you want.

@driesvints
I can see the issue here, the wrap function in Grammar.php does a check to see if the value is an expression, however the changes implemented in #44784 (removing the __toString() method) have broken the ability for this check to work (at least with the relation aggregate methods) as we can no longer pass an expression through to this.

Its probably a missing expression handling somewhere in withSum. I'll look into it today and build a fix.

Thanks @tpetry

I've verified the issue and started working on a fix. The aggregate functions hadn't been documented to support expressions.

Thank you both!
@tpetry, a quick question if you don't mind (this could be me missunderstanding):
This line https://github.com/laravel/framework/blob/af2a7caa70ebe2d50c3aff8c222222e30cd83d12/src/Illuminate/Database/Query/Expression.php#L34 (and in the associated interface) forcibly requires that an instance of Grammar be passed through yet I can see nowhere that it is actually used or required?  Without forcibly requiring this then we would be able to re-implement the __toString() method which would fully resolve this issue and I believe would not break your original PR?
As my colleague @morganarnel has pointed out this morning, we believe this issue may extend further than just aggregate usages and in fact may impact any DB::raw() instance as we are forcing this to be a string, so the wrapping function will fail on any complex query.

The __toString method can not be implemented again. The Grammar is passed to the expression. The standard expression does not use it but special expressions like tpetry/laravel-query-expressions use it to generate database-specific output. That was the whole intention of the Grammar rewrite. So expressions can abstract the different syntax or functionality of databases into reusable components.

@tpetry thank you!
I understand now, greatly appreciate you working on a fix for this! 🙂

@morganarnel @john-dent PR #49912 will fix this issue


[AST] Ensure requirements are correctly identified as conditional.

Previously, the following code would result in different sets of
conditional requirements:
struct RedundancyOrderDependenceGood<T: P1, U> {}
extension RedundancyOrderDependenceGood: P2 where U: P1, T == U {}

struct RedundancyOrderDependenceBad<T, U: P1> {}
extension RedundancyOrderDependenceBad: P2 where T: P1, T == U {}

The T: P1 requirement is redundant: it is implied from U: P1 and T == U,
but just checking it in the signature of the struct isn't sufficient,
the T == U requirement needs to be considered too. This uses a quadratic
algorithm to identify those cases. We don't think the quadratic-ness is
too bad: most cases have relatively few requirements.
Fixes rdar://problem/34944318.

@swift-ci please test

@swift-ci Please test compiler performance

Build failed
Swift Test Linux Platform
Git Sha - 406fefe7d009f4308540a0e835166893048f2866

@swift-ci please smoke test

Build failed
Swift Test OS X Platform
Git Sha - 406fefe7d009f4308540a0e835166893048f2866

@swift-ci Please test compiler performance

This triggered a large regression in the time it takes to index the standard library.  On my machine it went from 1 second to 19 seconds.

Sorry! This is causing enough problems that I'll revert and look at it again from scratch.


Filtering doesn't seem to work

Summary:
I can't get metrics filtering to work. My goal is to filter on multiple different user metadata labels, but right now I can't get a single one to work.
Version: v0.12.0
Config (abridged, in a k8s deployment manifest):

 spec:
      containers:
      - args:
        - --monitoring.metrics-type-prefixes=cloudsql.googleapis.com/database
        - --monitoring.filters='cloudsql.googleapis.com/database:metadata.user_labels."my-label"="my-value"'

Given that config I'd expect the filter to be included in the debug log here but that doesn't seem to be the case. The log statements generally only include the metric.type filter:
ts=2023-01-24T06:45:40.496Z caller=monitoring_collector.go:290 level=debug msg="retrieving Google Stackdriver Monitoring metrics with filter" filter="metric.type=\"cloudsql.googleapis.com/database/postgresql/insights/aggregate/execution_time\""

and the metrics scraped include metrics from databases not tagged with my-label=my-value.
I'm new to GCP, and assume this is just something silly stemming from my lack of familiarity with Stackdriver. Would love any pointers.

That's very odd I can't reproduce this locally on v0.12.0 or on v0.13.0. I'm running,
make build && ./stackdriver_exporter --google.project-id=<redacted> --monitoring.metrics-type-prefixes='cloudsql.googleapis.com/database' --log.level=debug --monitoring.filters='cloudsql.googleapis.com/database:metadata.user_labels."my-label"="my-value"'
and all of the logged metrics filters look like
ts=2023-01-31T17:48:11.711Z caller=monitoring_collector.go:290 level=debug msg="retrieving Google Stackdriver Monitoring metrics with filter" filter="metric.type=\"cloudsql.googleapis.com/database/replication/network_lag\" AND (metadata.user_labels.\"my-label\"=\"my-value\")"
You posted an abridged config, are you by chance specifying a --monitoring.filters with multiple values that are comma delimited? If so, that's not supported ATM (it's supported with -monitoring.metrics-type-prefixes) but you can specify multiple --monitoring.filters params which will all be used. I was planning to take a pass at the docs + code to make the two params consistent in how they behave.

Yeah I'm specifying multiple --monitoring.filters.
It drove me crazy for a while, but I never found the problem.
For me it's however no longer an issue, we decided to look for a different solution due to lack of caching and no support for exporting user labels.

For me it's however no longer an issue, we decided to look for a different solution due to lack of caching and no support for exporting user labels.

I completely understand the labels aspect. Just wondering, what type of caching would be useful?


Remove Sigma Binary entries from Body lists in camera menus.

They should not be there. Implement change to filter them out.

Coded and tested.


Const correctness fixes for Mesh and ParMesh

This PR adds overrides for GetFaceElementTransformations and similar functions in Mesh and ParMesh which are callable using user-provided FaceElementTransformations and ElementTransformation objects and avoid use of the internal objects. It also improves const-correctness for the Get*Transformation methods in Mesh and ParMesh, with the following notable changes:

GetBdrElementTransformation and GetFaceTransformation no longer modify FaceElemTr.Loc1 as a temorary object for meshes with L2 nodes.
The Mesh * member of ElementTransformation is now const (this is appropriate since a user should probably not be modifying the mesh via an ElementTransformation object, but I'm open to feedback).
The CoarseFineTransformations members of Mesh and NCMesh are marked as mutable, so that GetRefinementTransforms can be const (it is usually const and but sometimes lazily constructs the refinement transformation data). This is required because of one place in Coefficient where this method is called on a const Mesh accessed from an ElementTransformation.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#4019
@sebastiangrimberg
@pazner
@pazner + @termi-official
12/9/23
1/5/24
⌛due 12/30/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Furthermore I noticed that it is likely not clear which functions for the mesh classes are thread safe and which are not. Especially these buffers here
https://github.com/mfem/mfem/blob/96e2fa95d8aecb5b1c2faac6784f7de4391dc9ad/mesh/mesh.hpp#L234-L240
might be a problem. Should I open an issue for this?

I agree it isn't very clear from the documentation. const-correctness is a first pass towards this: threads should be able to call const member functions safely at the same time, albeit mutable members kind of make this is a bit hairy. In my opinion adding comments of which methods are thread-safe versus not is a bit unwieldy, and it should probably be made at the class-level as done for C++ standard template library objects. For example, if it can be actually verified, we could guarantee thread-safety for const methods of Mesh and ParMesh if it is actually so. But while I'm confident in the methods I'm addressing here, I can't speak to the rest of these (huge) classes as being const-correct or thread-safe.

Merged in next for testing...

Re-merged in next for testing...


Rename Deployer health checks into readiness checks

How to categorize this PR?

/area deployers
/kind technical-debt
/kind api-change
/priority 4
What this PR does / why we need it:
Following up with a comment by @schrodit in PR #225 this PR renames the health check of the deployers into readiness checks to be in line with the Kubernetes naming convention and to pave the ground for potential future liveness checks.
Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
PR #225 must be approved and merged first before this one can be merged as it builds on top of the changes introduced by that PR.
PR will remain in Draft status until #225 gets merged.
Release note:

Deployer healthchecks renamed into readiness checks.

/needs rebase

/test

PR #225 got merged so...
/ready-for-review


TileWMS change tileurlfunction ?

Hi. I wrote a map class by inheriting the xyz class. I've since overridden the tileurlfunction.
projection = 'EPSG:5181'
const tileGrid = new TileGrid({
extent,
resolutions,
origin: getBottomLeft(extent)
});
...
return template
.replace(zRegEx, (this._maxZoom - tileCoord[0]).toString())
.replace(xRegEx, tileCoord[1].toString())
.replace(yRegEx, (-tileCoord[2] - 1).toString());
I'm trying to service a WMS layer on my geoserver, but the modified tileurlfunction doesn't work properly.
Are you having trouble writing a map class file? Or am I wrong to make a wms layer?
Let me know if there is an example.

You can take a look at this example: https://openlayers.org/en/master/examples/xyz-esri-4326-512.html
Please note that GitHub issues are intended for bug reports or feature request only. Thanks!

Sorry.
Excuse me, I'll ask again.
v6.0.0.md
// before
function tileUrlFunction(tileCoord) {
  const z = tileCoord[0];
  const x = tileCoord[1];
  const y = -tileCoord[2] - 1;
  // do something with z, x, y
}

You would now do something like this:
// after
function tileUrlFunction(tileCoord) {
  const z = tileCoord[0];
  const x = tileCoord[1];
  const y = tileCoord[2];
  // do something with z, x, y
}

I guess this is a problem caused by the tileGrid changing in wms of geoserver.
And where do I ask questions about openlayers?

This change is due to the way tile coordinates are expressed in OpenLayers, which is now aligned to most other systems.
You can ask usage questions on Stack Overflow as per the readme.

Thank you for your reply.
In the future we will ask about Stack Overflow.


1.x Speedups

Various fixes I've had in mind for improving Dialogic 1.x speed, which I had initally put aside when the Dialogic 2 development started but they're good for long term maintenance for people that for one reason or another can't move off of Godot 3

First improvement:

Dynamic cache for the built-in events. will load them only as used, then keep them in memory and pull them from the cache as needed. doesn't cache the custom events, just because they could changed much more commonly then the Dialogic core events

starting to address #1239, doing some initial observations as I try and step through from that. I've added timestamps to build_resource_folder() in the MasterTree.gd, since i gotta work backwards through all the steps to figure out whats happening where before I can do the full improved internal timeline/variable address dictionary changes
Umm

creating one single timeline folder probably shouldn't  be calling build_resource_folder() a total of 22 times...
`

wait... omg... it's calling that for every folder... the count of calls goes up for each new folder created. no wonder it keeps getting slower and slower!

Further observations tonight: every update_folder_structure() first loads all the firles, loads the folder strucutre JSON, does the recursive building, and then saves the JSON

with the comments syaing 'when files got deleted and on program start', its called once in _ready() on the main editor, once in _on_RemoveConfirmation_confirmed()... then once in each of the build functions: build_timelines(), build_characters(), build_definitions(), build_themes()
the read in first before saving seems a bit redundant to me, so might readjust that. really should only genuinely happen in the editor on startup, and all the other functions be write-only.

note to myself since I need to leave: the folder properties metadata isn't included in how this is built at the moment. needs to be added for Editor to use both for folder colors, as well as for preserving empty folders. can then be stripped out later for the runtime dictionaries because they don't matter there. also will need to add some additional sorting properties for editor, for when its exploded back into the folders.json organization
might be possible to add finer drag and drop sorting into the folder list with what I have in mind, though, so you can actually rearrange timelines in the same folder

ok FINALLY, lol. was really busy and couldnt focus a lot of time, but also recursion suuuuuuucks lol

now that the framework for both reading in to new file structure, then writing back again to folder_structure.json, I can clean it up and start hooking all the rest of the parts of 1.x into it

I just made a maze generator with path finding, so I feel that recursion hate.  Can't wait for the fix, really appreciate the effort!

ok hmm trying to put the rest of what's in DialogicClass.prepare() (which is where I was doing it only temporarily for step testing) into DialogicResources.get_resource_folder_flat_structure() makes the whole thing crash with cyclic errors, which seems to be a static typing issue with GDScript in 3.x, gotta think through that a bit differently then

reminder to myself to check what happens here when you actually have no name in the timeline file

todo:
make new files go down to the first item in the folder, so it doesn't appear above subfolders (it rebuilds on project reload to be in that position)

reopened the bug #1278 just so i can do a verify check to make sure that works propelry with these changes

need to be able to reverify colors in Characters if somehting changes, becuse otherwise it'll revert until full reload

reminder to myself that I will need to add some checks and documentation because this introduces the minorest of breaking changes that forward slashes will be disallowed in folder and file names and need to be stripped on names and renames - if they aren't already? might be alrady idk I'll need to check

todo: make sure loading saves works

current things needing to be addressed before this can be merged:

[ ] new definitions/glossaries are not being added to subfolders, but to root
[ ] correcting where new files of each category go if the new timeline/character/definition/glossary/theme button is pressed when that's not the current highlighted tree
[ ] the warning about forward slashes in names of folders and files, and the stripping of them for the breaking change

current things that would be nice too, but I'm not marking them as blocking:

[ ] the dropdown menus in editor for timeline events to use the new tree instead of older recursive tree
[ ] trying to restore jumping to the right position in the tree on new item creation, and automatically going into rename mode
[ ] restoring the actual event parts cache, since that was the beginning of this patch but something weird with instancing in Godot 3 makes it preserve values on reinstancing (I'm using the exact same dang method in Godot 4 for the Dialogic 2 event cache, and it doesnt do the same thing there??)

TODO: since I found a much simpler way of doing the dropdown menus, gotta do it for the other pickers too

Not sure how actively this is being worked on right now, or if I'll be upgrading to 2.x anyway before I finish development, but:
I noticed that 1.4.5 is loading every character file, apparently from disk, every time any character is looked up. (DialogicUtil.get_character_list(), which is called by get_character(id), get_sorted_character_list(), and get_characters_dict(). Does this PR already address that?


perf: stop stripe scriptloader when stripe is disabled

fixes: #722
Impact: minor
Type: perf
Issue
See backing issue.
Solution
checks defined payment methods for stripe_card before loading
Breaking changes
n/a
Testing

Disable stripe payment method hard-coded in paymentMethods.js
Do page reload with DevTools open.
Verify no call is made to js.stripe.com
Enable the IOU checkout method.
Add a product to the cart.
Start checkout and proceed to payment.
Verify Stripe does not appear as a possible payment method.

Thanks for the merge folks. If I'm able to use Stripe in the future (currently they don't allow sales of M. speciosa) I'll consider the benefit in helping with a lib upgrade to take better advantage of the dev affordances mentioned by @janus-reith.


installation: deprecation warning caused by rdflib

rdflib causes deprecation warnings because of use of operator << which is deprecated in pyparsing since version 2.0.1:
pyparsing.py:3546: DeprecationWarning: Operator '<<' is deprecated, use '<<=' instead
  ret << Group( Suppress(opener) + ZeroOrMore( ignoreExpr | ret | content ) + Suppress(closer) )

Solution would be to downgrade pyparsing to 2.0.0 (which breaks some existing code) or patch rdflib.

rdflib is not longer needed in Invenio 3.


Adding nonce in CSP response header and replace the nonce in index.html

Discussed in https://github.com/quarkiverse/quarkus-quinoa/discussions/750

Originally posted by bdevos September  3, 2024
I am currently transitioning a React frontend application to become part of the Quarkus backend, instead of using a separate Nginx container exclusively for the frontend.
The integration with Quarkus Quinoa seems really promising and it's been great for development thus far.
However, I encountered a challenge when attempting to add a nonce that is necessary for our Content Security Policy. I have implemented similar solutions in other applications and I'm conversant with the entire process when incorporating the frontend in a standalone Nginx container. Yet, I am unable to figure out how to implement this with Quinoa.
What I seek is a way to filter the request that is handling index.html. Once that's done, I should be able to insert the nonce into the CSP response header and modify the HTML content set to return in the response.
I've tried several filtering methods but none appear to give me access to the requests that Quinoa handles.
As the nonce is a requirement under my company's policy, skipping it isn't an option. I wonder if there's a simpler approach I might have overlooked. Alternatively, would it be smarter to run a development server with Quarkus Quinoa, and then build an Nginx image for the frontend during the release stage?
Vite: Its documentation for the nonce support is rather minimal, but works as expected: https://vitejs.dev/guide/features#nonce-random
In Vite you can configure a nonce, but in order for that nonce to have any effect, it needs to be randomised on every response.
When in the Vite config you set:
html: {
  cspNonce: 'NONCE_PLACEHOLDER',
},

The Vite build output in index.html will contain it in the script tag like this:
<script type="module" crossorigin src="/assets/index-DYyGYer9.js" nonce="NONCE_PLACEHOLDER"></script>

What I do now with other applications, is that I replace that NONCE_PLACEHOLDER with a random nonce on every request before sending the response to the user. To make it all work the same random nonce has to be included in the CSP response header.

@ia3andy there must be some clever way to add a RequestFilter on index.html to replace tokens?
We could maybe have :
quarkus.quinoa.nonce.token: NONCE_PLACEHOLDER

Which if detected would add a randomly generated NONCE UUID to the response.header as well as filter the index.html and replace that NONCE_PLACEHOLDER with the same generated UUID?

@ia3andy there must be some clever way to add a RequestFilter on index.html to replace tokens?
We could maybe have :
quarkus.quinoa.nonce.token: NONCE_PLACEHOLDER

Which if detected would add a randomly generated NONCE UUID to the response.header as well as filter the index.html and replace that NONCE_PLACEHOLDER with the same generated UUID?

The solution would also need some way to replace the random generated nonce value in the CSP header itself. This header can become quite complex and the nonce will probably only be a part of the value.
So I would imagine a way to replace the nonce placeholder when the response header is set in the properties:
quarkus.http.filter.index.header.Content-Security-Policy=img-src 'self' data:; object-src 'none'; script-src 'nonce-$NONCE_PLACEHOLDER' 'report-sample'; connect-src 'self' https://browser-intake-datadoghq.eu; style-src 'nonce-$NONCE_PLACEHOLDER'

@bdevos can you update this bare bones Vite Quinoa starter to have the CSP stuff in it (of course it will fail) so we have a test case.
vite-csp.zip

I extended the bare bones starter with a vite config and the CSP response headers to test it. I hope it is OK that I made it available on Github: https://github.com/bdevos/vite-csp
The changes are, this vite config: https://github.com/bdevos/vite-csp/blob/main/src/main/webui/vite.config.js
And the CSP headers are in the properties: https://github.com/bdevos/vite-csp/blob/main/src/main/resources/application.properties
I added some comments in the application.properties because you can actually test the NONCE working when changing which CSP value is provided.

excellent!

I don't know how to do this but it sounds like we need to:

Intercept the index.html on the way out of vert.X and do a replacement on the CSP_NONCE.
Inercept the response.getHeaders() and replace the CSP Policy CSP_NONCE.

I think this is out of the scope of Quinoa, this is server-side-rendering.
I would suggest to give a try to the web-bundler where the index.html can actually be rendered using Qute.
If you want to stick to Quinoa, then you should be able to introduce a vertx filter in your app code and tranform the index.html content in the response.

Here is an example of accessing the vertx router to add stuff: https://github.com/quarkusio/code.quarkus.io/blob/main/base/src/main/java/io/quarkus/code/rest/DownloadRerouteFilter.java

Thanks! I thought I had explored all my options, but I didn't know a Vert.x filter was possible. I will give it a try and report back on whether I was successful.

If it is successful let us know I think we should add to docs as Vite is so popular and CSP is a good thing.

@bdevos make any progress?

@melloware I haven't been able to figure out how to read the Vite-generated index.html in the route observer.
public void init(@Observes Router router) {
  router.route(HttpMethod.GET, "/").handler(ctx -> {
    // Have to access the body of index.html so I can replace the NONCE_PLACEHOLDER
    ctx.next();
  });
}

The problem is that I cannot read the body from the ctx. I could maybe delay my route observer to a point where the response is written, but that won't help because once the response is written, it is probably also committed, and I won't be able to rewrite it anymore.
I tried to read the index.html file from the Quinoa bundled resources, but I haven't been able to figure out how Quinoa stores this and if there are differences in dev vs build mode.
I do have several other options, but they all feel like hacks around the problem. For example, I could write the Quinoa bundle to a separate folder and serve everything myself, or I could use Quinoa for dev mode but build a separate frontend image for production.
The coming week, I won't be working on this problem, but I will revisit it afterward to see if I can find a way to process this file within the route observer. Any suggestions, code examples, or documentation that could help me out would be greatly appreciated.


Fix echo command failing due to inexistent WIREGUARD_DIR

This would cause the install script to fail.

Thanks for the fix!


Add autoaccept on the receiver node

Add autoaccept feature in order to auto-accept every message received.

Closed on behalf of d4cb9570caf1fca12e0cd1508aa4981f42bb072e


[CDR-1460] Align EHR controller with 1.0.3 spec

Changes

Aligned ehr API with spec

create returns now 201 instead of 204
Updated swagger doc for create with all possible return codes 201, 400 and 409

Refactored the EHR controller to have more control about the returned http codes
Added Unit tests for the EHR controller

Pre-Merge checklist

[x] New code is tested
[x] Present and new tests pass
[x] Documentation is updated
[x] The build is working without errors
[x] No new Sonar issues introduced
[x] Changelog is updated
[ ] Code has been reviewed

@micha1970 We need to switch back to the latest robot tests before merge -> https://github.com/ehrbase/ehrbase/pull/1371/commits/e003fee2131ea439753689dde4930995e171bf09#diff-f3bf042f595bb7cd2f582786da0bb18ee5da158fbda5d21be1d5cbc72096c296L47-R47


Epic: Consistent Formatting

Phase 1: For beta2 release

[ ] Preserve field ordering. (https://github.com/kubernetes-sigs/kustomize/pull/4021)
[ ] Preserve sequence node indentation.
[ ] Disable formatting for eval and render commands.

Solves issues:
https://github.com/GoogleContainerTools/kpt/issues/2104
https://github.com/GoogleContainerTools/kpt/issues/2101
https://github.com/GoogleContainerTools/kpt/issues/2332
https://github.com/GoogleContainerTools/kpt/issues/2342
https://github.com/GoogleContainerTools/kpt/issues/2068
Phase 2: Long term

[ ]  Design proposal when and how to format resources. (https://github.com/GoogleContainerTools/kpt/issues/2349)
[ ] Implement the items in approved proposal.
[ ] Related user issues (https://github.com/GoogleContainerTools/kpt/issues/2404, https://github.com/GoogleContainerTools/kpt/issues/2383, https://github.com/GoogleContainerTools/kpt/issues/2405)

@phanimarupaka is phase1 finished up with beta2 release?

@phanimarupaka is phase1 finished up with beta2 release?

Yes.


More easily import polygon points

Since the polygon points are a simple string of "x1,y1 x2,y2, ... xn,yn" in the SVG XML, I found it much simpler to modify your polygonArea function to utilize the string values rather than try to convert to your expected nested arrays.  Very minor tweaks adding a few splits, but it seems much more friendly for working with polygons on the fly.  Feel free to incorporate them if you find them useful.
            var svgDoc = document.getElementById("svg");
            var string = d3.event.target.id;
            var poly = d3.select(svgDoc).select("polygon#" + string);
            var points = poly.attr("points");
            var polygon = points.split(" ");
            var i = 0,
                n = polygon.length - 1,
                a,
                b = polygon[n].split(","),
                area = 0;
            while (i++ < n)    {
                a = b;
                b = polygon[i].split(",");
                area += a[1] * b[0] - a[0] * b[1];
            }
            area /= 2;

Defining a serialized representation for polygons is out-of-scope for this library.


Gramar error fix.

I just added an "a". (:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


chore: Enable custom build pipeline

Remove .tekton folder to enable custom build pipeline and related PR to get merged.

/ok-to-test

/retest

/retest

I'd expect to see the tests on the old pipelines being included on the new pipelines. Otherwise, we're not running our tests anymore.

@yftacherzog I have kept the old pull-requests file now to run all the tasks in that and all the checks are also running now. Please review again.

/test

I'd expect to see the tests on the old pipelines being included on the new pipelines. Otherwise, we're not running our tests anymore.

@yftacherzog I have kept the old pull-requests file now to run all the tasks in that and all the checks are also running now. Please review again.

What about the content of the push pipeline? Is it covered by the new pipeline?

I'd expect to see the tests on the old pipelines being included on the new pipelines. Otherwise, we're not running our tests anymore.

@yftacherzog I have kept the old pull-requests file now to run all the tasks in that and all the checks are also running now. Please review again.

What about the content of the push pipeline? Is it covered by the new pipeline?

@yftacherzog I just included the task from the old push pipeline to the new one.

I'd expect to see the tests on the old pipelines being included on the new pipelines. Otherwise, we're not running our tests anymore.

@yftacherzog I have kept the old pull-requests file now to run all the tasks in that and all the checks are also running now. Please review again.

What about the content of the push pipeline? Is it covered by the new pipeline?

@yftacherzog I just included the task from the old push pipeline to the new one.

Cool. Can you rebase so we get the tests running with the latest changes? I want to make sure that no test failures were introduced when CI was off.

@amisstea can you have a look?

We don't have some of our steps now. See for example step check-and-test-prometheus-rules on the pull-request yaml being deleted on this PR.

I deleted that for testing purpose, when we merge the old pipeline all the old tests are failing due to clone-repository being using different image.

We don't have some of our steps now. See for example step check-and-test-prometheus-rules on the pull-request yaml being deleted on this PR.

I deleted that for testing purpose, when we merge the old pipeline all the old tests are failing due to clone-repository being using different image.

You mean that the way we clone the repo for the o11y tests and the way the it's cloned by the new pipeline are not compatible with one another? i.e. if you use one of them to clone the repo, the tests of the other will fail? This might be about the directory in which the content is pulled into, but can also be about the way it's pulled (e.g. depth).
If so, is it true both ways? i.e. new clone fails old tests and old clone fails new tests?
@amisstea do you see the part of having everything in one pipelinerun a must-have for now?
What are the disadvantages of running to parallel pipelineruns here?
In any case, if we want to have it on a single pipeline, we can start by having the two clone tasks storing the code to a different workspaces and have the two "streams" of tests running in parallel on different workspaces., and we can later find the issue and optimize it.

@amisstea do you see the part of having everything in one pipelinerun a must-have for now?

It's not a must-have but we should try to identify the root problem before deciding if this is tech debt worth kicking down the road. It sounds like there may have been a small adjustment to the way the clone-repository checks out the code but that hasn't been confirmed AFAIK. @hmariset have you identified what changed in the task yet?

What are the disadvantages of running to parallel pipelineruns here?

Maybe not much but it could be harder to fix this later as more contributions are made to the pipelinerun definitions.

@yftacherzog Yes, they are not compatible. If I use old clone-repository for new pipeline the tasks are failing and same thing for old pipeline tasks as well. Yeah I too think the problem is with workspace/directory.
@amisstea Both clone-repository tasks are using same git-clone but the bundle images are different.

@amisstea @yftacherzog The problem is with the workingDir. When I modified the workingDir to /workspace/workspace/source  all the old tasks are passing with new clone-repository.

@amisstea Updated the code based on the suggestions. Please review again.


Create spatial partitions

I'm creating this PR early, please read the commit messages.
in the future a method will handle updating positions, which will have a side effect of moving said object having its position updated (a sprite) to the sprite group of respective spatial partition.

Coverage decreased (-0.4%) to 97.423% when pulling e0a2b5d8f4be5789df94b4c6784e2c946c9d8128 on feature/spatial-partitions into eb047edc09c97584b83d2343b23a0854c854f3c3 on master.

Coverage decreased (-0.4%) to 97.423% when pulling 1800275a3829b149a06dfe4adb97321026c3fb84 on feature/spatial-partitions into eb047edc09c97584b83d2343b23a0854c854f3c3 on master.

Coverage decreased (-0.4%) to 97.432% when pulling d61007f552aa9fabb8f27512de94a8f322ca41ed on feature/spatial-partitions into 58f72b6d04c1d0ec511026473f4475eed15c9bd5 on master.

Coverage decreased (-1.1%) to 96.711% when pulling d65434ce9b45e42b4377e7ed778d0f26eced3267 on feature/spatial-partitions into 58f72b6d04c1d0ec511026473f4475eed15c9bd5 on master.

Coverage decreased (-1.1%) to 96.711% when pulling 77b6e2be4bf557f86dc72b97c46ec4640d615351 on feature/spatial-partitions into 58f72b6d04c1d0ec511026473f4475eed15c9bd5 on master.

i think all that's left is to do actual group management and then it's done? it'd be nice to get it integrated into demo before merge.

you can use spatial partitions to selectively only update the contents of partitions that are on screen/nearby/etc. i should note of this.

Coverage decreased (-1.1%) to 96.7% when pulling 1d7e8a8d7d66d7d579ef34894563b05fe5d5e353 on feature/spatial-partitions into 58f72b6d04c1d0ec511026473f4475eed15c9bd5 on master.


[Feature] Be Able To Use Other Iptv Channels As Media Sources

Would Also Like To Have Fallback Iptv Channels

unless i cant find it this is still not implemented

Throwing a plus one into this with a usecase: You've got a scheduled TV lineup but wish to switch over to a live event or stream from a source for a specific time. Potentially adding a 'fall back to local' if/when the live stream drops out.
This is probably making things a lot more complex but being able to 'listen' for a stream coming online and then automatically switching over to that would be a fantastic feature as it would allow for periodic takeovers of a channel.

Not stale


Support keyboard navigation

Is there any reason why https://github.com/euvl/vue-js-toggle-button/pull/26 has not been merged?
I think it would be great to support keyboard navigation.
PS: Sorry for opening a new issue but I don't know if you get the notifications from closed PR 👼

Hey, I don't really remember as the PR was one year ago. I can take a look into it when i have a bit of free time.

I think that what put me of is the phraseI'm not 100% sure on that front.. It is not a great benchmurk for things that are used by hundreds of people 😄

Haha! Okay 😄I'll work on it when I have time.

I made a quick test on codepen and it seems that there is no need to check whether component is focused or not.
However it doesn't work on IE 11 (nothing happens when pressing the space bar) 😞 so I'll search a way to fix it.

Nice, thanks 👍

I've updated the codepen with a solution based on this article using opacity: 0 instead of display: none to hide the <input/>.
Then the <input/> is still accessible/focusable and natively reacts to keyboard events (no need to add @keydown.space) even on IE 11.
I'm not an expert in accessibility but I think we can also remove the role="checkbox" and the aria-checked.
I may have time to make a PR this week. It will be more clear than explaining the code modification 😄