Toil crashes when trying to add a child job function defined in an imported module

I'm trying to use @cmarkello's toil-vg, which defines a library of Toil jobs that I can use.
However, when I e.g. import toil_vg.vg_index and try to job.addChildJobFn(toil_vg.vg_index.run_xg_indexing, ...) inside one of the jobs in my module, Toil explodes:
=========> Failed job 'xg_index_job' h/q/jobUOl1eA
---TOIL WORKER OUTPUT LOG---
INFO:toil:Running Toil version 3.6.0-f930a841e79d1032a44670b85c319411ca539ede.
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
INFO:toil.fileStore:Starting job ('xg_index_job' h/q/jobUOl1eA) with ID (a39818eb68ba67ec5d5006144061d0113d878ba9).
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
Traceback (most recent call last):
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/worker.py", line 340, in main
    job._runner(jobGraph=jobGraph, jobStore=jobStore, fileStore=fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1271, in _runner
    returnValues = self._run(jobGraph, fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1218, in _run
    return self.run(fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1384, in run
    rValue = userFunction(*((self,) + tuple(self._args)), **self._kwargs)
  File "/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder/toilvgfacade.py", line 155, in xg_index_job
    disk=options.xg_index_disk).rv()
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 431, in addChildJobFn
    return self.addChild(JobFunctionWrappingJob(fn, *args, **kwargs))
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1346, in __init__
    self.userFunctionModule = ModuleDescriptor.forModule(userFunction.__module__).globalize()
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/resource.py", line 397, in forModule
    assert os.path.isdir(dirPath)
AssertionError
ERROR:toil.worker:Exiting the worker because of a failed job on host kolossus
WARNING:toil.jobGraph:Due to failure we are reducing the remaining retry count of job 'xg_index_job' h/q/jobUOl1eA with ID h/q/jobUOl1eA to 0
<=========

The job that's adding this child is defined in toilvgfacade.py in my module, while my module's build.py is the main Toil user script, and is called through the module entry points mechanism.
If, instead of passing the function I want to run to addChildJobFn, I pass a wrapper function defined in my module, the child job gets added successfully.
I am using Toil 3.6.0. The toil-vg module is installed in /cluster/home/anovak/python/lib/python2.7/site-packages/toil_vg-1.1.0a1-py2.7.egg/toil_vg and is thus available to my python without doing anything special.

OK, this is now blocking me. My workaround of wrapping the job with a function in my module works if I call a single job, but if I call a job in toil-vg that internally calls more jobs, I get the same error again:
=========> Failed job 'run_gcsa_prep_wrapper' d/l/jobmNylxQ
---TOIL WORKER OUTPUT LOG---
INFO:toil:Running Toil version 3.6.0-f930a841e79d1032a44670b85c319411ca539ede.
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
INFO:toil.fileStore:Starting job ('gcsa_index_job' d/l/jobmNylxQ) with ID (f5dc1ea54ecd42be27f73688880f57089ee7793c).
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
WARNING:toil.resource:Can't globalize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False).
WARNING:toil.resource:Can't globalize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False).
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
INFO:toil.fileStore:Starting job ('run_gcsa_prep_wrapper' d/l/jobmNylxQ) with ID (68c1e57a578c75551c5228fbc53f999701568bcd).
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
INFO:toil.fileStore:Starting job ('run_gcsa_prep_wrapper' d/l/jobmNylxQ) with ID (68c1e57a578c75551c5228fbc53f999701568bcd).
WARNING:toil.resource:Can't find resource for leader path '/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder'
WARNING:toil.resource:Can't localize module ModuleDescriptor(dirPath='/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src', name='hgvmbuilder.toilvgfacade', fromVirtualEnv=False)
INFO:toil-rt:Starting gcsa preprocessing...
Traceback (most recent call last):
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/worker.py", line 340, in main
    job._runner(jobGraph=jobGraph, jobStore=jobStore, fileStore=fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1271, in _runner
    returnValues = self._run(jobGraph, fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1218, in _run
    return self.run(fileStore)
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1384, in run
    rValue = userFunction(*((self,) + tuple(self._args)), **self._kwargs)
  File "/hive/users/anovak/ga4gh/hgvm/hgvm-builder/src/hgvmbuilder/toilvgfacade.py", line 221, in run_gcsa_prep_wrapper
    return toil_vg.vg_index.run_gcsa_prep(*args, **kwargs)
  File "build/bdist.linux-x86_64/egg/toil_vg/vg_index.py", line 176, in run_gcsa_prep
    disk=options.prune_disk).rv()
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 431, in addChildJobFn
    return self.addChild(JobFunctionWrappingJob(fn, *args, **kwargs))
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/job.py", line 1346, in __init__
    self.userFunctionModule = ModuleDescriptor.forModule(userFunction.__module__).globalize()
  File "/cluster/home/anovak/python/lib/python2.7/site-packages/toil/resource.py", line 397, in forModule
    assert os.path.isdir(dirPath)
AssertionError
ERROR:toil.worker:Exiting the worker because of a failed job on host kolossus
WARNING:toil.jobGraph:Due to failure we are reducing the remaining retry count of job 'run_gcsa_prep_wrapper' d/l/jobmNylxQ with ID d/l/jobmNylxQ to 0
<=========

It looks like you are trying to use eggs, right? I think that is the problem. Hot deployment does not support deployment of eggs

Yeah, the module I was using was installed as an egg. Installing it with setup.py develop lets it import its own files, and eliminates the need for wrapper functions.


posix: implement uname

Implementation for posix api: uname
*** Booting Zephyr OS build zephyr-v3.4.0-632-gfed4ab1928ba ***

Printing everything in utsname...
sysname[7]: Zephyr
nodename[7]: zephyr
release[7]: 3.4.99
version[53]: zephyr-v3.4.0-632-gfed4ab1928ba Jul  4 2023 19:01:24
machine[8]: riscv64

uart:~$ uname -a
Zephyr zephyr 3.4.99 zephyr-v3.4.0-632-gfed4ab1928ba Jul  4 2023 19:01:24 riscv64 qemu_riscv64

MacOS as a reference:
(.venv) ycsin-mba:zephyrproject ycsin$ uname -a
Darwin ycsin-mba 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:53:44 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T8103 arm64

fixes #59924

[x] update doc/services/portability/posix.rst
[x] add to the testsuite
[x] size_t

Some compliance fixes..

IIRC, we cannot yet build for native_posix. I would suggest filtering CONFOG_ARCH_POSIX in your sample

We actually do want to be fairly consistent here with e.g. the boot banner.

The version string is the same as the boot banner (I just copied & renamed)

a tagged release (e.g. v3.5.0)
something commit-ish (IIRC git short ref plus epoch time? I can't remember)

Should be covered by:
3.4.99 zephyr-v3.4.0-632-gfed4ab1928ba Jul  4 2023 19:01:24

Not epoch time though..

whether the build is dirty (Linux uses a +, not sure how Zephyr does it)

Looks like something to be done in the build system, not sure if @tejlmand has any idea?
I vaguely rmb that we used to have this somewhere..?

whether the build is dirty (Linux uses a +, not sure how Zephyr does it)

Looks like something to be done in the build system, not sure if @tejlmand has any idea? I vaguely rmb that we used to have this somewhere..?

Adding -dirty (or anything indicating a dirty build) has been rejected in the past, ref: https://github.com/zephyrproject-rtos/zephyr/pull/13608#pullrequestreview-206725920
But the use-case / reason for not having -dirty can be handled manually by those who has special needs, as described here:
https://github.com/zephyrproject-rtos/zephyr/issues/39503#issuecomment-961686122
As people has various ways of working / verifying patches, then I think a wider audience should be invited to discuss if we want to have -dirty (or similar) appended to short sha.
The implementation itself is very trivial, so just a matter of making a decision.

An alternative internal thing for uname.c is below, where we don't copy constant string data into an array.
With this setup, it would make sense to use strncpy() for each field.
struct utsname_internal {
	const char *const sysname;
	const char *const nodename;
	const char *const release;
	const char *const version;
	const char *const machine;
};

Not epoch time though..

__TIME_UNIX__ might work - I think it's epoch time

Adding -dirty (or anything indicating a dirty build) has been rejected in the past

how about having a separate define to indicate this in "version.h", rather than appending to the hash directly?

how about having a separate define to indicate this in "version.h", rather than appending to the hash directly?

Did you read the links ?
Especially: https://github.com/zephyrproject-rtos/zephyr/pull/13608#pullrequestreview-206725920 .
Even if placing this info in a separate define to use in version.h then it will impact the hex file when the repo goes from clean --> dirty (or other way around).
So if this is to be changed, then please open a dedicated issue for discussing, and not in this PR.

So if this is to be changed, then please open a dedicated issue for discussing, and not in this PR.

@tejlmand - I believe @ycsin's changes have addressed your concerns, and with a couple of small changes, I'm ready to approve. Can you take a look again to ensure that your concerns were addressed?

@keith-packard - does this one look OK to you now?

@ycsin - I'm OK getting 1 more approval for this and merging if you wouldn't mind a follow-up PR for namespacing <version.h> as <zephyr/kernel/banner_version.h> or something along those lines.


Issue when running rubocop -a

Hey all
When running rubocop -a on a project with Ruby 2.2.1, it gets a quarter of the way through then I get this error:
undefined method `begin' for #<Parser::Source::Map::Variable:0x007f980436c858>
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/style/and_or.rb:113:in `correctable_send?'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/style/and_or.rb:95:in `correct_send'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/style/and_or.rb:67:in `block (2 levels) in correction'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/style/and_or.rb:65:in `each'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/style/and_or.rb:65:in `block in correction'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/corrector.rb:46:in `call'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/corrector.rb:46:in `block in rewrite'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/corrector.rb:45:in `each'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/corrector.rb:45:in `rewrite'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/team.rb:91:in `autocorrect_one_cop'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/team.rb:66:in `autocorrect'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cop/team.rb:36:in `inspect_file'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:190:in `inspect_file'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:157:in `block in do_inspection_loop'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:151:in `loop'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:151:in `do_inspection_loop'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:93:in `process_file'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:58:in `block in inspect_files'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:56:in `each'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:56:in `inspect_files'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/runner.rb:34:in `run'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/lib/rubocop/cli.rb:26:in `run'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/bin/rubocop:13:in `block in <top (required)>'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/2.2.0/benchmark.rb:303:in `realtime'
/usr/local/var/rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/rubocop-0.35.1/bin/rubocop:12:in `<top (required)>'
/usr/local/var/rbenv/versions/2.2.1/bin/rubocop:23:in `load'
/usr/local/var/rbenv/versions/2.2.1/bin/rubocop:23:in `<main>'

any ideas?

Duplicate of #2482. Fixed on master.

So can be fixed with reinstall?

So can be fixed with reinstall?

It can be fixed by either waiting for the next release of RuboCop (and then upgrading), or cloning the RuboCop repository and running from your local repo, rather than using the gem.


VM deletion looks for resource in wrong namespace

What steps did you take and what happened:
When deleting a cluster that was spawned in an external infrastructure cluster, the pkg/kubevirt/machine.go Machine#Delete method looks for the Virtual Machine to delete in the correct cluster, but in the same namespace name than where the KubeVirtMachine resource is in the management cluster:
namespacedName := types.NamespacedName{Namespace: m.machineContext.KubevirtMachine.Namespace, Name: ...

Unless the same namespace name is used, then the VM failed to be found and the VM is not deleted as expected.
What did you expect to happen:
The logic should look in the correct namespace for the VM; which is already provided when creating the struct in the NewMachine function.
Anything else you would like to add:
The pkg/kubevirt/machine.go Machine#Delete also currently silences any other error that might prevent the VM to be found. In this case, the vm will most likely not be properly populated and the following call to delete it will fail, but with an unclear error. Instead, we should also directly fail when the Get of the VM fails with a non not-found error.
Environment:

Cluster-api version: v1beta1
Cluster-api-provider-kubevirt version: v1alpha1
Kubernetes version: (use kubectl version): v1.20.15
KubeVirt version: v1
OS (e.g. from /etc/os-release): CentOS 7

/kind bug

/assign @pjaton


The logic of merging query parameters may not belong to this module

In DsFilter::toFilters you can find a general logic of dividing query parameters into conjunctive and disjunctive.
It seems that this logic should be in core-java.
That's the code:
 /**
     * Performs the actual expression conversion.
     *
     * <p>This method divides the given params into conjunctive and disjunctive. The conjunctive
     * parameters are then merged into a single {@link Filter}. After that, the disjunction
     * parentheses are opened and the {@linkplain #multiply logical multiplication} is performed.
     */
    private static Collection<Filter> toFilters(Collection<CompositeQueryParameter> parameters,
                                                ColumnFilterAdapter columnFilterAdapter) {
        Stream<CompositeQueryParameter> parameterStream = parameters.stream();
        List<CompositeQueryParameter> conjunctionParams = parameterStream.filter(isConjunctive)
                                                                         .collect(toList());
        List<CompositeQueryParameter> disjunctionParams = parameterStream.filter(isDisjunctive)
                                                                         .collect(toList());
        Optional<CompositeQueryParameter> mergedConjunctiveParams =
                mergeConjunctiveParameters(conjunctionParams);

        Collection<Filter> filters = newLinkedList();
        TreePathWalker processor = new ColumnFilterReducer(columnFilterAdapter, filters);
        multiply(mergedConjunctiveParams.orElse(null), disjunctionParams, processor);
        return filters;
    }

@vlad-lubenskyi, let's discuss if this issue is still relevant in person.


archive in repo

Your repository weighs 4gb already. You should not save the binary archive to the repository. There is a releases section for that. Like this guy doing https://github.com/sayomelu/transmission-blocklist

@whoizit The repository you linked to also commits the archive, it's just not on the main branch. Pulling that repository will pull those objects too unless you use --single-branch.

yours repo still oversized

their repo 7.28MiB

@whoizit because when you git clone the repo, you will download all my branches which not only my master branch but also the old main branch. The main branch was discarded,  and still contains all the old files and histories.
And also just like what @antonagestam said, even using a release branch it just upload files to a sub-branch but will still take the size of the whole branch just like my main branch.  The way to solve it is submitting the binary files to Releases (Remember, not the branch, it is a function call Github Releases. check here for details: https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases)
Also, if you really need to save files in the repo, you have to remember clean out the binary files and other large files in the commit history. Otherwise it will like my main branch took lots of space.
Googling git filter-branch for more details about how to remove large files in repo history.

I don't know where you got this nice analyze screenshots, I can't find the function on Github, but the results I got is less than 1GB.
The master branch size:

The git push size:

yours repo still oversized  their repo 7.28MiB  I clone it for test and this absolutely right

https://github.com/Shywim/github-repo-size

1.86GiB
~/tmp > git clone https://github.com/Naunter/BT_BlockLists                                                          ± master | 06 Feb 04:33:15 (7)
Cloning into 'BT_BlockLists'...
remote: Enumerating objects: 1018, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 1018 (delta 1), reused 8 (delta 1), pack-reused 1009
Receiving objects: 100% (1018/1018), 1.89 GiB | 4.64 MiB/s, done.
Resolving deltas: 100% (345/345), done.

7.28MiB
~/tmp > git clone https://github.com/sayomelu/transmission-blocklist                                                ± master | 06 Feb 04:37:26 (7)
Cloning into 'transmission-blocklist'...
remote: Enumerating objects: 15, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 15 (delta 0), reused 1 (delta 0), pack-reused 12
Receiving objects: 100% (15/15), 7.28 MiB | 2.89 MiB/s, done.
Resolving deltas: 100% (1/1), done.

Receiving objects: 100% (1018/1018), 1.89 GiB | 4.64 MiB/s, done.
~/tmp > git clone https://github.com/Naunter/BT_BlockLists                                                          ± master | 06 Feb 04:33:15 (7)
Cloning into 'BT_BlockLists'...
remote: Enumerating objects: 1018, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 1018 (delta 1), reused 8 (delta 1), pack-reused 1009
Receiving objects: 100% (1018/1018), 1.89 GiB | 4.64 MiB/s, done.
Resolving deltas: 100% (345/345), done.

Receiving objects: 100% (15/15), 7.28 MiB | 2.89 MiB/s, done.
~/tmp > git clone https://github.com/sayomelu/transmission-blocklist                                                ± master | 06 Feb 04:37:26 (7)
Cloning into 'transmission-blocklist'...
remote: Enumerating objects: 15, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 15 (delta 0), reused 1 (delta 0), pack-reused 12
Receiving objects: 100% (15/15), 7.28 MiB | 2.89 MiB/s, done.
Resolving deltas: 100% (1/1), done.

As I said above, you are checking the size of all my branches under the BT_BlockLists repository, not just the master branch.

I fail to see the problem...
git clone https://github.com/Naunter/BT_BlockLists.git -b master --single-branch
Cloning into 'BT_BlockLists'...
remote: Enumerating objects: 12, done.
remote: Total 12 (delta 0), reused 0 (delta 0), pack-reused 12
Unpacking objects: 100% (12/12), 15.55 MiB | 1.37 MiB/s, done.

Thanks @bstivers , you made a simple and clear explanation.
Git has so many tricks and commands to discover, I'm still just a git noob.
I took few screenshots to comparison:
This is the main branch, which is the reason cause the large size. It has 1.87 GiB.

This is the master branch, which is the up to date branch we are using. It only 15.55 MiB.

This is the full repo, which contains both main and master branch. It is 1.89 GiB.

I think this issue is solved and I will close this issue.
After this, I will change the main branch to a new name call "old-branch".
If @whoizit you or any other still have questions, welcome to leave comments or open a new issue.


Add support for using C++ exceptions instead of setjmp/longjmp to support RAII

Hello,
We have a problem with RAII and automatic destruction via stack unwinding because duktape use setjmp/longjmp.
Lua proposes to use real C++ exception instead of setjmp/longjmp if compiled in C++. Can we add this for duktape too?
The following code will never call the Object destructor from test function.
#include <iostream>

#include "duktape.h"

class Object
{
public:
	Object() = default;
	~Object()
	{
		puts("Destroying object");
	}
};

duk_ret_t test(duk_context *ctx)
{
	Object o;

	duk_push_string(ctx, "hello");
	duk_throw(ctx);

	return 0;
}

int main(void)
{
	auto ctx = duk_create_heap_default();

	duk_push_global_object(ctx);
	duk_push_c_function(ctx, test, 0);
	duk_put_prop_string(ctx, -2, "test");
	duk_peval_string(ctx, "try { test(); } catch (ex) { print(ex); }");

	return 0;
}

+1. I'm waiting on C++ exception support to be able to use duktape.

I'm reworking call handling in 1.4 release, and this work includes refactoring code so that it'll be easier to replace setjmp/longjmp with C++ exceptions. If all goes as planned adding support for C++ exceptions within 1.4 release might be doable.

Please make sure exceptions can be turned off in C++ mode. Most games and many other embedded users compile with -fno-exceptions or their compiler's equivalent.
I don't think setjmp/longjmp are better for said cases but rather that throwing Duktape exceptions through C++ code needs to be handled with a more explicitly-controllable API, not implicit magic.
Bound functions should be required to signal that they want to throw and then return explicitly (removing the need for either longjmp or C++ exceptions entirely), and Duktape exceptions should not cross C function boundaries (C functions calling into Duktape can query if an exception was raised and then resignal+return as appropriate).

This is basically what a protected call is now: If you do duk_pcall() and the called code throws, the protected call returns with an error code and leaves the thrown object on top of the stack.

@seanmiddleditch Using C++ exceptions (internally) instead of setjmp/longjmp will certainly be a config option and off by default.
With regards to errors not crossing function boundaries, are you suggesting a change to current behavior (with setjmp/longjmp)?
In the current behavior longjmps do cross function boundaries unless the caller uses a protected call. Changing this would be quite awkward, because almost any API call anywhere may throw - property reads can cause getters to throw, coercions may throw, any value push may run out of memory, etc. That's why the API is split into unprotected and protected calls; call sites can use a protected call to ensure they capture control on an error and can then clean up properly. This pattern is used internally.

First version of this provided by #499.

Fantastic!


caddy1: remove

Motivation for this change
https://github.com/caddyserver/caddy/blob/master/.github/SECURITY.md#supported-versions
Caddy 1.x is unsupported.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg test caddy


Fix ControlCatalog DnD sample

What does the pull request do?
Fix DnD usage in the ControlCatalog DragAndDropPage.
What is the current behavior?
DnD uses the combination of DataFormats.Files and a string[] for file paths, which is invalid.
What is the updated/expected behavior with this PR?
Use DataFormats.Files and an IStorageFile[] instead.
How was the solution implemented (if it's not obvious)?
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
#11439

You can test this PR using the following package version. 11.0.999-cibuild0035076-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


fix(autok3s): Support disabling rollback in API

Currently disabling rollback only works in CLI. To change the field to string to support it in API.
The root cause is MergeConfig from pkg/utils/util.go. If setting rollback to bool false, it won't be set to sourceConfig as it is zero value of bool type. By changing it to string to fix it.
Refer to https://github.com/cnrancher/autok3s/issues/504

Closing this PR as it will be fixed in another PR.


Color of the cards in Blogs page

The color of the cards in blog pages are white which can be changed to the color that will match with the background too.
Please assign me this issue under Hacktoberfest

Is this issue is still available i will do this if its still opens

I would like to work on this issue , please assign it to me


⚠ Samsung has degraded performance

In 5cb1ced, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2971 ms

Resolved: Samsung performance has improved in 3b4a62e.


Added MRR stats service and endpoint

refs https://github.com/TryGhost/Team/issues/1470
Instead of counting the MRR by resolving all the deltas from the past until now, we should start with the current calculated MRR and resolve it until the first event. That would give a more accurate recent MRR (in exchange for a less accurate MRR for older data) and allows us to limit the amount of returned days in the future.

Includes MRR stats service that can fetch the current MRR
The service can return a history of the MRR for every day
New admin API endpoint /stats/mrr that returns the MRR history
Includes tests for these new service and endpoint

Blocked by a pending version bump of members-api package (required for a test to succeed)

@matthanley The rounding was a very interesting edge case. Apparently we floor MRR deltas, so it would be best to also floor individual results too. And since the plan_amount has an int type, SQLite already rounded intermediate results in the SUM (probably why I didn't notice it).  So I added some tests to check the rounding and added the rounding explicitly.
https://github.com/TryGhost/Members/blob/0eaae7cc83dba0484fe0b381f8fa60d5631ec9d3/packages/members-api/lib/repositories/member.js#L1164-L1166


Assign User - Wireframe #2

Task
Follow up on Assign User task with a simplified version of the Assign User modal.

Almighty Core Issue

Note
This will just have a scrollable list of Almighty users for someone to select from. There will also be the ability to unassign a user, as well as cancel the action.
Wireframes

Desktop
Mobile

@almighty/uxd - I will be testing the different wireframe layouts as demoed today. I'll share internally before posting externally.

Closing as it is completed in the UI


Bintray support

The old build script had a task to publish the libraries on Bintray. We should port this to the new version.

We can publish the releases here on GitHub


OIDC provider_config errors

Describe the bug:
Setting up OIDC with Google Suite as provider with the vault-operator gives an error.
    externalConfig:
      auth:
        - type: oidc
          config:
            default_role: default
            oidc_client_id: ...snip...
            oidc_discovery_url: https://accounts.google.com
            provider_config:
              provider: gsuite
              fetch_groups: true
              fetch_user_info: false
              groups_recurse_max_depth: 5
              gsuite_admin_impersonate: ...snip...
              gsuite_service_account: /vault/google/service-account.json
          options:
            listing_visibility: unauth
          roles:
            - name: default
              role_type: oidc
              user_claim: sub
              groups_claim: groups
              policies: default
              ttl: 1h

Results in vault-configurer logging
time="2021-01-29T15:17:30Z" level=error msg="error configuring vault: error configuring auth methods for vault: error configuring oidc auth on path oidc for vault: error putting oidc auth config into vault: json: unsupported type: map[interface {}]interface {}"

Since the error was for an unknown type, I tried converting the provider_config into a JSON string (i.e. provider_config: '{"provider":"gsuite",...}') and that resulted in vault-configurer logging:
time="2021-01-29T15:23:27Z" level=error msg="error configuring vault: error configuring auth methods for vault: error configuring oidc auth on path oidc for vault: error putting oidc auth config into vault: Error making API request.\n\nURL: PUT http://vault.vault-system:8200/v1/auth/oidc/config\nCode: 500. Errors:\n\n* 1 error occurred:\n\t* error converting input {\"fetch_groups\":true,\"fetch_user_info\":true,\"groups_recurse_max_depth\":5,\"gsuite_admin_impersonate\":\"...snip...\",\"gsuite_service_account\":\"/vault/google/service-account.json\",\"provider\":\"gsuite\"} for field \"provider_config\": '' expected a map, got 'string'\n\n"

so I'm pretty sure it should just be a map as above.
Expected behaviour:
bank-vaults operator should write the provider configuration to the auth config endpoint.
Steps to reproduce the bug:
Set up a clean vault, apply above config.
Environment details:

Kubernetes version: v1.18.9
Cloud-provider/provisioner: EKS
bank-vaults version: 1.10.0
Install method: Helm

/kind bug

Totally valid, I will need to push a fix for this.


Add tool version

This PR adds the tool version number to the validator report. for the issue #134

just to keep a note:
in this PR i have implemented writing version number in text report and summary report. while it is yet to be implemented in ODB report. that will require some structural changes possibly a new class for version number.


Consider using the new YNAB API?

Hi @schurig, I'm a developer at YNAB.  This project looks nice!  I wanted to let you know we are working on an REST based API which is currently in Early Access stage.  I'm hoping you would be interested in joining and evaluating usage of the API for this project.  We support creating transactions through the API and will be rolling out an update this week which provides first-class handling for imported transactions.  If you're interested, please fill out this quick survey: https://goo.gl/forms/TL87uGCl0tUAayD72 and then we can get in in the Early Access group.

Hey @bradymholt, thank you very much for reaching out to me. I just requested access to try it asap. If it works well, I can finally dump the selenium webdriver import and replace it with something very light that can run regularly on small devices like a raspberry pi.

Great!  We'll reach out to you soon with some instructions.


Missing video quality labels

Some of videos miss resolution overlays as OS not supporting that videos. Integration of ffmpeg library should help.

https://github.com/ARK-Builders/ARK-Navigator/issues/146#issuecomment-1128079950
It will resolve this as well.

Also, we should support .webm, .mpg and .ts extensions as video type as well.
Not sure about .ts though — this is old DVD format, if I remember correctly.


Update Productboard extension - Add Notes command + chore

Description
I wanted to add some more features as I've started using Productboard recently. However, this extension is old and so I wanted to work on modernizing some of the code before more features are added so to that effect:

added CHANGELOG
added updated metadata images in the metadata folder
added useForm in the index command
created a useProductboard hook that fetches and returns paginated data that we can use for future "GET"
I did NOT remove the existing use of got as we might need to keep it depending on how useFetch, POST and PUT requests are handled by Productboard API.
added ONE command Notes that will show Notes
updated the dependencies especially raycast api

I think we can move "Add Note" and turn it into a subcommand via Push within Notes but I think this needs to be discussed first.
Screencast
https://github.com/raycast/extensions/assets/30526133/1c94f375-bd70-43f2-8409-594e5b33a215
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@honzatmn can you check this update?

@honzatmn pinging you one last time

What a nice improvement with Notes listing! Thanks for your contribution @xmok! 👏

I think we can move "Add Note" and turn it into a subcommand via Push within Notes but I think this needs to be discussed first.

This also sound like a good thing, it might speed up adding a note significantly.

Awesome, thanks for the feedback 🔥

Hey so this update moved Add Note to be a subcommand via Push in Notes command.
I also updated ray deps.
Finally, got a new type of Error so I updated the ErrorResponse type to handle it.
No real functionality changes!

Hi! Is this ready for review again?

Hi yes this is ready to go ✅.

LGTM!


Document /logout/all

Fixes https://github.com/matrix-org/matrix-doc/issues/700

The paragraph about UI auth is almost a direct copy/paste from https://github.com/matrix-org/matrix-doc/issues/700#issuecomment-347614770


No panel icon for AppImage

Ubuntu 19.10
Set AppImage to executable and double click
App launches and works as expected however panel does not have an icon

This will need to be fixed in electron-builder, see https://github.com/electron-userland/electron-builder/issues/4186.


Scaffold-DbContext needs an environment variable connection string option

Opening this issue for discussion / new feature request. (Didn't see anything obvious in a search of open issues, so forgive me if duplicate.)
Problem
Currently, each time you run Scaffold-DbContext to generate a database-first model and context (a common workflow when adding columns to a table, etc), the connection string is hardcoded into the DbContext class, along with a #warning reminder to go replace it. While the warning is helpful, each time you must remember to go replace this, prior to committing changes.
It's easy to forget, not to mention Entity Framework full and Entity Framework core, by default, have always seemed to go against the official Microsoft recommendation and common sense architecture guidelines of "keep your connection strings out of your source code".
Proposal
Support an additional, optional argument in Scaffold-DbContext:
-UseConnectionStringEnvironmentVariable <name>
ex, -UseConnectionStringEnvironmentVariable MyConnectionString
... which would then produce a slightly different OnConfiguring section:
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
	if (!optionsBuilder.IsConfigured)
	{
		optionsBuilder.UseSqlServer(System.Environment.GetEnvironmentVariable("MyConnectionString"));
	}
}

The environment variable approach maps nicely to docker container configuration in AWS ECS, Kubernetes, and other orchestrators.
Alternatively, or in addition, offer an optional argument:
-ExcludeOptionsBuilderConfiguration (for lack of a better term)
... which skips the OnConfiguring method in generated code altogether, so that it's possible to place the OnConfiguring override in a separate partial class that doesn't get overwritten each time Scaffold-DbContext is run.

Not sure it it helps your situation, but with "EF Core Power Tools" you can choose to not generate the connection string, and then add a partial class like this, that you can configure with an OptionsBuilder
public partial class DataContext
    {
        public DataContext(DbContextOptions<DataContext> options) : base(options) { }
    }

Of course it does! 😁

We'll also support using a name= syntax in 2.1. The workflow:

Add your connection string to your ASP.NET Core configuration (environment variables, user secrets, json, etc.)
Reverse engineer using Scaffold-DbContext Name=MyConnectionStringKey My.EFCore.Provider
Behold the awesomeness. No #warning is generated since you're connection string just contains a configuration key.

That was issue #2464

@bricelam Suggested triage decision on this?

I think we can close it as a duplicate of #2464, but if @BrandonPotter has any additional ideas on how we can make this scenario better (keeping #831 in mind too), we'd love to hear it.


Test records should be converted to plaintext

Test data should be left in plaintext format for easier debugging. Currently, some test records are stored as actual NistBeaconValue objects. This makes debugging hard as loading the test data library will hit any breakpoints one might enter inside of NistBeaconValue.
Records for testing should all be converted, and loaded from, plain text.
You can see the current records, at time of this issue's creation, here:
https://github.com/urda/nistbeacon/blob/a3ad356f6a55857b79062766a2f3cbe3fe296abb/tests/test_data/nist_records.py

Looks like there is only a handful of records to port, starting work.

This was added with #30


Packwiz export ignores config

See https://github.com/Fabulously-Optimized/fabulously-optimized/releases/tag/v4.3.0-pw.1 for command and result. The input zip used can be found here.
I did provide the mmc-export.toml but that wasn't reflected in the output.

Seems.. Weird to me. Everything must work... Anyway, will dig deeper into this tomorrow, I'm mentally dead now.

Well, the problem is in your config actually. Script looking for matches by name OR filename, so, when first, it matches Farsight Mod by name, removes it, and second time it can't find any matches because mod was just removed. I suggest you to delete name in first Farsight Mod entry in your config to fix the issue.


auro-button: Focus outlines missing on Windows High Contrast mode

Describe the bug
When Windows High Contrast Mode is enabled, focus outlines are not shown when tabbing.

I believe this is because WHCM ignores border or background color changes and box shadows for focus states.
Desktop (please complete the following information):

OS: Windows 10
Browser: Firefox

Additional context
I think we should update the default focus styles in WCSS and inherit the changes here.

FWIW, this mainly seems to be a Firefox issue. Edge seems to apply a focus outline automatically:

Think it would be best if the same solution used in https://github.com/AlaskaAirlines/auro-radio/pull/8 was used here.

:tada: This issue has been resolved in version 5.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Undefined type

Undefined type 'Gumlet\ImageResize'
link to print
Any idea?

I try to reproduce the issue, but it's worked successfully. Here are my codes and running commands in the terminal:
localadmin@clickhouse02:~$ php  -v
PHP 8.1.11 (cli) (built: Sep 29 2022 22:28:23) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.11, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.11, Copyright (c), by Zend Technologies
localadmin@clickhouse02:~$ php ~/composer.phar require gumlet/php-image-resize
localadmin@clickhouse02:~$ vim test.php
localadmin@clickhouse02:~$ cat test.php
<?php
require_once __DIR__  . '/vendor/autoload.php';

use \Gumlet\ImageResize;

$image = new ImageResize('./image.jpg'); // assuming that the image.jpg file is existed in our local machine.
localadmin@clickhouse02:~$ php test.php
localadmin@clickhouse02:~$


Rc/v0.32.0

0.32.0 (2020-05-25)
Features

utils: add convertors of uint-to-le (16b6d80)
use signature provider in signWitnesses & signWitnessGroup (#434) (34d62bb)

Codecov Report

Merging #441 into master will increase coverage by 0.06%.
The diff coverage is 97.80%.

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   90.69%   90.76%   +0.06%
==========================================
  Files          27       29       +2
  Lines        1161     1180      +19
  Branches      272      273       +1
==========================================
+ Hits         1053     1071      +18
- Misses        107      108       +1
  Partials        1        1

Impacted Files
Coverage Δ

packages/ckb-sdk-core/src/index.ts
58.10% <66.66%> (ø)

packages/ckb-sdk-core/src/signWitnesses.ts
96.55% <85.71%> (-3.45%)
:arrow_down:

packages/ckb-sdk-core/src/loadCells.ts
100.00% <100.00%> (ø)

packages/ckb-sdk-core/src/signWitnessGroup.ts
92.00% <100.00%> (+0.69%)
:arrow_up:

packages/ckb-sdk-utils/src/address/index.ts
100.00% <100.00%> (ø)

packages/ckb-sdk-utils/src/const.ts
100.00% <100.00%> (ø)

packages/ckb-sdk-utils/src/convertors/index.ts
100.00% <100.00%> (ø)

packages/ckb-sdk-utils/src/crypto/blake160.ts
100.00% <100.00%> (ø)

packages/ckb-sdk-utils/src/ecpair.ts
97.50% <100.00%> (ø)

packages/ckb-sdk-utils/src/index.ts
100.00% <100.00%> (ø)

... and 4 more


Feature/reportng renewed threads view

Description
The old threads view was replaced with a new one using Apache ECharts.
Details of a testcase (method name, run index, start- and end-time and duration) are provided with a tooltip.
In Addition to the method filter, a status filter was added. With the selection of a status all testcases of that status are highlighted and zoomed in on. These two filters can not be active at the same time, instead they cancel each other out.
The Method filter itself highlights the selected testcase and performs a zoom event on that specific method.
New Threads View with active tooltip:

Status Filter active:

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

In case of many configuration methods (e.g. many BeforeMethods) the method list contains many entries with the same name:

Please add the run index in brackets like setUp (20) to increase clarity.

@TobiasAdler Please also update the ReportNG tests. We have some failed tests because of changed Threads view.


Fix tree iterator nextKey()

Have a test case?

Don't think this is a clean fix. But there does seem to be something wrong with the logic in the diff iterator:
This line: https://github.com/holepunchto/hyperbee/blob/de6c3e6454bfa42b8361f1e25f520649e673bc1c/iterators/diff.js#L137 returns undefined to line 110 https://github.com/holepunchto/hyperbee/blob/de6c3e6454bfa42b8361f1e25f520649e673bc1c/iterators/diff.js#L110 , which will result in a crash on line 113 (accessing n.key)
So either line 137 should be removed because if should never trigger (which is possible, given that it's being triggered by a buggy autobase)
Or line 137 should also return null' if it should be skipped over Or the undefined` return value should be special-cased on line 110


Automate Parameter Descriptions

The parameter descriptions should be generated from the information current on cchdo (paramters.json?) whenever the docs are built.
Alternatively have the parameters come from cchdo, but check the information into this repo manually so some version of the documentation may be built when offline.

Apparently I fixed this 6 months ago with 1c9cd80


IInspectable try_as awaly success on implements struct type

struct One1 : winrt::implements<One1, winrt::IInspectable > {};
struct One2 : winrt::implements<One2, winrt::IInspectable > {};

auto one1 = winrt::make<One1>();
auto one2 = one1.try_as<One2>(); // one2 always  return none null value.

This is because both One1 and One2 implement the exact same set of interfaces so there's no way to distinguish between them. Generally it's not recommended to directly access the underlying implementation type and winrt::implements is usually used to create opaque implementation of an interface.

From a standards PoV it's still a problem, that's illegal aliasing.

This is because both One1 and One2 implement the exact same set of interfaces so there's no way to distinguish between them. Generally, it's not recommended to directly access the underlying implementation type and winrt::implements is usually used to create an opaque implementation of an interface. In this case, it's not a problem since both classes are identical, however, that's not the case most of the time.

So how do change the code to distingish them ( the local implements winrt type) instead of dcelare them via idl?

Create an interface for them, then add it to winrt::implements:
MIDL_INTERFACE("7F9D905E-F955-4D52-B856-4851A5CBCA7C") IOne1 : IUnknown
{
    // since this is a private interface, functions declared there don't need to adhere to any COM/WinRT requirement
    std::string do_something();
};

MIDL_INTERFACE("7ABE3977-B188-4C4A-909E-8395B325801D") IOne2 : IUnknown
{
    int add(int a, int b);
};

struct One1 : winrt::implements<One1, winrt::IInspectable, IOne1> {};
struct One2 : winrt::implements<One2, winrt::IInspectable, IOne2> {};

auto one1 = winrt::make<One1>();
auto one2 = one1.try_as<IOne2>(); // will return null

Another case where this can occur is the following:
namespace Foo
{
    interface IBar {}

    runtimeclass Buz : [default] IBar {}

    [default_interface]
    runtimeclass FooBar : IBar {}
}

void test(winrt::Foo::IBar thing)
{
    if (const auto buzImpl = thing.try_as<winrt::Foo::implementation::Buz>()
    {
        // you will ALWAYS hit this code path
        // if thing is not actually a Buz, you will have very fun memory corruption issues on your hand.
        buzImpl->DoThing();
    }
    else if (const auto foobarImpl = thing.try_as<winrt::Foo::implementation::FooBar>())
    {
        // this code path will never be hit, even if "thing" is actually a winrt::Foo::FooBar
        fooBarImpl->DoOtherThing();
    }
}

Because [default] was used for Buz, it means there is no IBuz (and an associated GUID) for the try_as to check against. So it checks against IBar meaning that FooBar will succeed the check too, and then you effectively get an winrt::Foo::implementation::FooBar reinterpret-casted as winrt::Foo::implementation::Buz, which is a big problem.
I feel like catching these kinds of issues would be possible from within cppwinrt. Ideally, this wrong code shouldn't compile.


ByRef is the default, not ByVal, when using Sub statements with parameters

[Enter feedback here]
Hi Microsoft Docs team, I discovered an inaccuracy in the documentation article about ByVal, found at: https://docs.microsoft.com/en-us/dotnet/visual-basic/language-reference/modifiers/byval.
The documentation states that "If no modifier is specified, ByVal is the default. ... Because it is the default, you do not have to explicitly specify the ByVal keyword in method signatures. It tends to produce noisy code and often leads to the non-default ByRef keyword being overlooked."
However, as my Excel VBA code below demonstrates, ByRef is the default value, not ByVal, when using parameters with Sub statements.
Sub firstSub()
    Dim varOne As Byte
    varOne = 1
    Debug.Print "Value of varOne: ", varOne
    Call secondSub(varOne)
    Debug.Print "Value of varOne is now: ", varOne
End Sub

Sub secondSub(varTwo As Byte)
    Debug.Print "Value of varTwo is: ", varTwo
    varTwo = 2
    Debug.Print "Value of varTwo is now: ", varTwo
End Sub

' Prints the following:
' Value of varOne:             1
' Value of varTwo is:          1
' Value of varTwo is now:      2
' Value of varOne is now:      2

' Now, showing difference when ByVal keyword is used:
Sub firstSub()
    Dim varOne As Byte
    varOne = 1
    Debug.Print "Value of varOne: ", varOne
    Call secondSub(varOne)
    Debug.Print "Value of varOne is now: ", varOne
End Sub

Sub secondSub(ByVal varTwo As Byte)
    Debug.Print "Value of varTwo is: ", varTwo
    varTwo = 2
    Debug.Print "Value of varTwo is now: ", varTwo
End Sub

' Prints the following:
' Value of varOne:             1
' Value of varTwo is:          1
' Value of varTwo is now:      2
' Value of varOne is now:      1

Also, here's another source that confirms that ByRef is the default: https://bettersolutions.com/vba/macros/byval-or-byref.htm

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3085184c-671d-92b5-b596-3af0a848b7c8
Version Independent ID: 4b8973b8-47df-64cd-98ff-5b3ea17860cf
Content: ByVal - Visual Basic
Content Source: docs/visual-basic/language-reference/modifiers/byval.md
Product: dotnet-visualbasic
GitHub Login: @KathleenDollard
Microsoft Alias: kdollard

I don't know about VBA. However, this documentation is for VB.NET, not VBA. The information is correct for VB.NET.

I don't know about VBA. However, this documentation is for VB.NET, not VBA. The information is correct for VB.NET.

Thank you, Youssef. I appreciate your response, and that makes sense that it could be different in .NET vs VBA. I found this page when searching “Excel VBA is ByRef or ByVal defaulthttps://www.google.com/search?q=excel+vba+is+byval+or+byref+default” and also “ByVal VBAhttps://www.google.com/search?q=byval+vba,” so I assumed that the reference pertained to VBA without even checking. Thank you for clarifying that for me.
Ryan Parker
From: Youssef<EMAIL_ADDRESS>Sent: Saturday, January 30, 2021 10:47 AM
To<EMAIL_ADDRESS>Cc: Ryan<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dotnet/docs] ByRef is the default, not ByVal, when using Sub statements with parameters (#22566)
I don't know about VBA. However, this documentation is for VB.NET, not VBA. The information is correct for VB.NET.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/docs/issues/22566#issuecomment-770250268, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTOKID66KKNYQGHR6VTXALS4RAZTANCNFSM4WZL2WZA.

Thank you, Youssef. I appreciate your response, and that makes sense that it could be different in .NET vs VBA. I found this page when searching “Excel VBA is ByRef or ByVal defaulthttps://www.google.com/search?q=excel+vba+is+byval+or+byref+default” and also “ByVal VBAhttps://www.google.com/search?q=byval+vba,” so I assumed that the reference pertained to VBA without even checking. Thank you for clarifying that for me.
Ryan Parker
From: Youssef<EMAIL_ADDRESS>Sent: Saturday, January 30, 2021 10:47 AM
To<EMAIL_ADDRESS>Cc: Ryan<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dotnet/docs] ByRef is the default, not ByVal, when using Sub statements with parameters (#22566)
I don't know about VBA. However, this documentation is for VB.NET, not VBA. The information is correct for VB.NET.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/docs/issues/22566#issuecomment-770250268, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQTOKID66KKNYQGHR6VTXALS4RAZTANCNFSM4WZL2WZA.

closing per conversation.


I get the following message ... '3d6+3' is not a valid die code See /roll help for examples.
Suggestions?
I just installed the latest version of Mattermost ...
Mattermost Version: 5.15.0
Database Schema Version: 5.15.0
Database: postgres

I just tried /roll 3d6+3 on our install and it works fine; we're still on 5.14, but I doubt that's the problem.
Could you add a screen shot of the error?

Regular dice expressions work until I add a modifier of some kind (-/+).

What language settings have you got? I'm wondering if I need to expand my regex to account for Unicode... I've only tested this with English, unfortunately.

"not a valid die code" doesn't actually appear in the current code; can you make sure you're running the latest release? It should be 1.1.

What language settings have you got? I'm wondering if I need to expand my regex to account for Unicode... I've only tested this with English, unfortunately.

My Localization default languages are both set to English. Also, this is a fresh/clean install of Mattermost. I done no changes, modifications or odd-ball settings other than a few standard plugins and yours.

"not a valid die code" doesn't actually appear in the current code; can you make sure you're running the latest release? It should be 1.1.
Version 1.1 says something like this when it can't parse the /roll:

Wow! ... glad you asked. I have a different dice plugin installed, it is not yours at all ... DOH!


⚠ Bofrost.lu has degraded performance

In 4688afc, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 3062 ms

Resolved: Bofrost.lu performance has improved in 142d48f after 1 hour, 1 minute.


Fix melodic-devel

Replace Affine3d with Isometry3d and remove deprecated 'attempts' parameter from RobotState::setFromIK().

It seems that the moveit master branch is less functional on kinetic than previously thought

Did Plus One ask for the melodic migration?

It seems that the moveit master branch is less functional on kinetic than previously thought

What do you mean?

Did Plus One ask for the melodic migration?

I thought Shaun agreed to do this since it just makes sense for better support and updates. Especially since there are no breaking changes and features like TOTG can be used directly without copying code.
@davetcoleman ?

What do you mean?

Ci fails with this error msg.
/usr/include/eigen3/Eigen/src/Geometry/Transform.h:330:5: error: static assertion failed: YOU_PERFORMED_AN_INVALID_TRANSFORMATION_CONVERSION
     EIGEN_STATIC_ASSERT(EIGEN_IMPLIES(OtherMode==int(Affine)||OtherMode==int(AffineCompact), Mode!=int(Isometry)),
     ^

I believe the issue is that we changed from Affine3d to Isometry3d in master

Right, all dependencies using Eigen must be compiled from source when using MoveIt melodic/master under kinetic but this can be configured with the .rosinstall.

Looks like the dependency rosparam_handler is missing in rosdep, though the package should work under melodic. Otherwise it shouldn't be too difficult to setup an appropriate alternative for loading parameters.

Can we redirect this to the public fork now?


edge: throw some SLD/SRD state errors

as described in https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-18#section-5.5
and https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-18#section-5.6
(merging at next minor release is sufficient)

@MirkoBonadei can you take a look at this on too? (give me an inch... :-))


Network introspection endpoints

Description
Adds a pair of web endpoints to retrieve the internal network tables of Collector (normalized and deduplicated, same as what is sent to Sensor).
The endpoints are activated by an environment variable (ROX_COLLECTOR_ENABLE_INTROSPECTION DEBUG_ENABLE_INTROSPECTION). The default disabled.

I <3 this PR, it helps so much! Could we have it merged?

I rebased on top of @Molter73 's ContainerInfo introspection endpoint.
We now share a common base class.
The env var had already been merged, so removed it from this PR.
I merged the doc paragraphs, but kept the entry explaining DEBUG_ENABLE_INTROSPECTION references.md


Details Page of Other Resource Models

Details Page Edits:
Legislative Acts
Legislative Act Section: displaying None
Governments
Government Name Displaying none

Done in test


How did you evaluate ColBERT on BEIR benchmark?

Hello,
I have a little question regarding the ColBERT evaluation. ColBERT is trained on MS MARCO, where the passage in collection.tsv only contains one field. They prepend it with a special [D] token before feeding into the model to get token level dense representation.
However, for datasets in BEIR, passage in corpus.jsonl also contains a title field besides the text field.
May I know how did you evaluate ColBERT on your BEIR benchmark? In other words, how did you handle the title and text field in your BEIR datasets to fit the ColBERT input?

Hi @jordane95, I just released the ColBERT evaluation code on the BEIR benchmark today, you can find more details in this repository: https://github.com/NThakur20/beir-ColBERT.
I simply concatenate the title and text with a single whitespace and treat them as passages. More details can be found within the repository!
Kind Regards,
Nandan Thakur


Fix warnings.

Verified that @crousselle has signed the CLA. Thanks for the pull request!

@jlawton pushing since this is pretty minor


Post-rating uses event names "input" and "change" that conflict with native DOM event names

Has been fixed with #2843


🇬🇧 Integration with SSE smart meters

I've spotted some possible integration routes out in the wild using SEE home smart meters for gas and electricity.
This would be a web scraper unfortunately.
I'm a SSE (scottish and southern energy) customer so this is something I could take a look at.
https://community.home-assistant.io/t/uk-smart-energy-meters/16545/15

closing due to inactivity. Let's reopen if someone finds an API to fetch usage


Age detection not always working

If I select november 2002 as my birthday, it says that i am 17

If I select november 2002 as my birthday, it says that i am 17

When did you experience this issue? This should have been resolved in #27 so might need to update

Published an update which I think should fix this, let me know if you still see anything weird

Whoops made the same change and forgot PR it. Still an issue with the day part of the birthday will try to post a gif

Day of birth still seems to decrement after save. When I was working on the change you eventually made I was trying to find what was going wrong here but I didnt see anything stick out, looks like you are handling day pretty similar to year and it isnt happening to year. Could this be somewhere on something serverless/backend? Maybe a mismatch of using a date string with / somewhere and - somewhere else? Not sure @benawad

are you on the latest version, I'm not able to replicate

i was on 1.10 i think at the time, still doing this now on 1.12

Checking my birthdate, the bug was present on android but is now gone. Is it still present on VS code?

Closing due to lack of interest and further reports.

Closing due to lack of interest and further reports.


Is this project maintained?

Hi, it would be great if the project can move forward, either allow other people in, or transfer it to Jazzband

Hi, I'm the original developer of this django app. I'm no longer with the organisation, so I can't accept the pull requests or add new members. However, I'd love to see this project move forward too.
One option could be to fork this repo, resubmit the pull requests, and push the new package to PyPI under a new name.
Before we do that, I'd like to see if there's anyone at ctxis who could transfer the repo over to me - @sadreck, @SteveWare, @ZephrFish, @kevoreilly are some names I see recent commits by on the ctxis organisation - can any of you help transfer out this repo to me so we can keep this project going in the spirit of FOSS?

I'm not at CTXIS and haven't been in 7 years sadly

@discopatrick did you manage to get in touch with anyone at CTXIS?


 This was previously removed for several other commands because it broke piping.
When piping occurs, at least with how gru accepts piped arguments, the args[] slice is empty. In order for piping to work, we can not set a minimum number of arguments.
There may be another way to handle piping, assuming there's a way to get in front of Cobra.

This works by using Data, where you can define STDIN, which is then passed to the command in the call function.
./spec/functional/chassis_power_off_spec.sh
# validate piping to STDIN works
It "--config ${GRU_CONF}"
  BeforeCall use_valid_config

  Data "<IP_ADDRESS>:5000" # STDIN

  When call ./gru chassis power off --config "${GRU_CONF}"
  The status should equal 0
  The line 1 of stderr should include 'Asynchronously updating'
  The line 1 of stdout should equal '<IP_ADDRESS>:5000:'
  The line 2 of stdout should include 'PowerState'
  The line 2 of stdout should include 'Off'
  The lines of stdout should equal 3
End


AEP SDK Roku v1.2.0 Missing ~2000 lines of code, causing errors

Prerequisites

[X] This is not a Security Disclosure, otherwise please follow the guidelines in Security Policy.
[X] I have searched in this repository's issues to see if it has already been reported.
[X] I have updated to the latest released version of the SDK and the issue still persists.

Bug summary
My request is coming from Paramount.
We supplied the AEP Roku SDK to our client teams for installation. When the team attempted to install the upgrade in order to support the new features available, we noticed that ~2000 lines of code were removed between version 1.1.0 and version 1.1.0. When we attempt to initialize the SDK, the missing code creates exceptions and errors.
One of the errors we can see are as follows:
@ AEPSDK.brs Line=83, Function=adobeaepsdkinit()
_adb_logDebug("AdobeAEPSDKInit() - Initializing the SDK.")
_adb_logDebug function is not defined
Environment
SDK Version: v1.2.0
OS: Roku 12.5
Steps to reproduce

Observe v1.1.0 code of the AEP Roku SDK
Observe v1.2.0 code of the AEP Roku SDK
Observe that between the two SDKs, ~2000 lines of code have been removed

Current behavior
We are experiencing errors due to redacted code
Expected behavior
We expect that with the SDK upgrade that we do not lose functionality and introduce errors
Anything else?
No response

Hi @jonathanruggiero,
Did you download Source Code zip instead of AEPRokuSDK-1.2.0.zip? Please download and use AEPSDK.brs from AEPRokuSDK-1.2.0.zip
Thanks,
Arjun

Thank you @addb - The team we are working with internally was able to resolve the issue with your guidance.


Bug - utf8.decode not returning the same value when executed in flutter or from dart

Hello,
  // decode array of integers that correspond to byte values
  String decodedUtf8 = utf8.decode(data, allowMalformed: true);

I noticed a strange behavior of utf8.decode.
When the code above is executed:

directly from dart -> successful decode
executed in a flutter iOS project -> result incorrect or partial
executed in a flutter Android project -> Not check

I created a project here to reproduce this bug with the array of integers I'm trying to decode.
https://github.com/julien-fr/bugs_example-main/tree/main/flutter_utf8_decode
Is anybody have a solution for this?
Executed in a flutter IOS project
-> Incomplete decode
<hSTCP@

dart bytes_to_string.dart
-> Successful decode
<hSTCP@>$�Q
<STCP><hSTCP>name,size,date,hour,nlap,nbest,best,pilota,track_name,veicolo,campionato,venue_type,mode,trk_type,motivolap,maxvel,device,track_lat,track_lon,test_dur,ptype,ptime,pdist,pmaxv,
a_0161.hrz,11224,7/11/2022,12:27:30,1,,,Julien,,X30 Sodi Sigma 2017,,Generic testing,speed,closed,stop,99,Julien,0,0,5687,,,,,
...
a_0112.hrz,1281997,11/06/2022,12:34:40,11,10,54334,Julien,Sarree,X30 Sodi Sigma 2017,,Generic testing,speed,closed,stop,-2063597568,Julien,436894850,69611760,569750,,,,,
<STCPN�>

Flutter 3.3.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b8f7f1f986 (6 days ago) • 2022-11-23 06:43:51 +0900
Engine • revision 8f2221fbef
Tools • Dart 2.18.5 • DevTools 2.15.0

@julien-fr thanks for filing the issue. This issue is reproducible on the latest stable and master channels.

[!] Flutter (Channel master, 3.6.0-11.0.pre.25, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.6.0-11.0.pre.25 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 31ea315c3c (24 minutes ago), 2022-11-29 18:29:02 -0800
    • Engine revision 25a2ac85f6
    • Dart version 2.19.0 (build 2.19.0-430.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.121

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@julien-fr please include an open-source license into your repository (MIT, BSD, GPL, Apache, anything), otherwise we can't look at your code. Thanks.
Have you tried checking decodedUtf8.length? Because it can be difference in printing, rather than in decoding.

@mraleph I added the license to my repository.
You are correct. decodedUtf8.length returns the same length.
So the issue seems related to printing with probably bad characters in the first 100 characters.
 print(decodedUtf8.substring(100, decodedUtf8.length)); is printing correctly.

Thanks @julien-fr. I am able to reproduce this on the latest versions as here https://github.com/flutter/flutter/issues/116174#issuecomment-1331764784
stable, master flutter doctor -v

[✓] Flutter (Channel stable, 3.10.6, on macOS 13.0 22A380 darwin-arm64, locale
    en-NG)
    • Flutter version 3.10.6 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (5 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.0 22A380 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 115.0.5790.170

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[✓] Flutter (Channel master, 3.14.0-5.0.pre.26, on macOS 13.0 22A380 darwin-arm64, locale en-NG)
    • Flutter version 3.14.0-5.0.pre.26 on channel master at /Users/damilolaalimi/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 03aa95be67 (5 hours ago), 2023-08-16 01:53:05 -0400
    • Engine revision 7cc6a5832a
    • Dart version 3.2.0 (build 3.2.0-74.0.dev)
    • DevTools version 2.26.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • iPhone 14 Pro (mobile) • 6548B0D1-7674-4306-9852-198C465F1104 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 13.0 22A380 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 115.0.5790.170

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I think this issue belongs to dart-lang repo, specially as decodedUtf8 is part of dart:convert library and it seems to be also replicable using dart code.
Closing as such. If anybody disagrees, write in comments and I'll reopen it.


Docs nitpick: Operations aren't primitives

Brought up in discord.. discuss!

Thanks. I think the original doc meant to say "Primitives types, primitive operations, primitive containers" in a board sense. But it causes confusion we should fix that.


Dashboard with Edge Device health (presence) metrics

Follow-up for #146 adding Grafana dashboard panels for monitoring edge devices presence.

I wasn't able to open the dashboard in the browser with 40k devices.
Also, grafana's pod complains about:
t=2022-03-27T11:46:06+0000 lvl=eror msg="Request error" logger=context userId=1 orgId=1 uname=admin error="net/http: abort Handler"
t=2022-03-27T11:46:11+0000 lvl=eror msg="Request error" logger=context userId=1 orgId=1 uname=admin error="net/http: abort Handler"
t=2022-03-27T11:46:16+0000 lvl=eror msg="Request error" logger=context userId=1 orgId=1 uname=admin error="net/http: abort Handler"

The health panel will not report anything, while others do.

When I ran the deployment script it failed with the error- csv created in namespace with multiple operatorgroups, can't pick one automatically. I used that cmd- tools/deploy_grafana.sh docs/metrics/flotta-dashboard.json

I wasn't able to open the dashboard in the browser with 23k devices. Also, grafana's pod complains about:

Warned you:)That's what I was expecting for large numbers of devices - panels for all devices are good for smaller numbers of them, but with larger numbers it's better to limit scope by filtering device IDs or namespaces.
That said - it worked OK-ish for me with that number of devices when the time range was small (like 10,15, 30 minutes).
So - maybe a separate dashboard JSON with just these two panels plus a doc would be better?

When I ran the deployment script it failed with the error- csv created in namespace with multiple operatorgroups, can't pick one automatically. I used that cmd- tools/deploy_grafana.sh docs/metrics/flotta-dashboard.json

I think that's unrelated to the dashboard changes. @masayag - WDYT?

So - maybe a separate dashboard JSON with just these two panels plus a doc would be better?

It will be more useful for high scale. A parametrized dashboards that allows to select namespace will be more efficient in that case, e.g. how it is done in https://grafana.com/grafana/dashboards/11671
In our case namespace & time range can be configurable.

When I ran the deployment script it failed with the error- csv created in namespace with multiple operatorgroups, can't pick one automatically. I used that cmd- tools/deploy_grafana.sh docs/metrics/flotta-dashboard.json

I think that's unrelated to the dashboard changes. @masayag - WDYT?

Agree. that's an issue with the script that was developed and tested against SNO only in which there were no operatorgroup under flotta namespace.

@masayag - I've created a dedicated dashboard with filter box allowing users to pick desired deviceNamespace.


Add Installation section in README

Add a new Section in README

@jamesmoraless same as the comment in the PR, it's the Assignee's (me) responsibility to close the Issue

Please add a section how to set it up to get it running


merge package template from Kronos-Tools/npm-package-template

package.json

chore(scripts): update semantic-release@semantic-release from template
chore(devDependencies): update<EMAIL_ADDRESS>from template
docs(package): remove keyword null

Coverage remained the same at 85.38% when pulling a4fd2bfe6c37138748896ce91bfb2b688810d768 on template-sync-1 into 3f918b6540ce19c32a86ce895961978a8de9d8f9 on master.

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   86.07%   86.07%
=======================================
  Files           1        1
  Lines         237      237
=======================================
  Hits          204      204
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f918b6...a4fd2bf. Read the comment docs.


New version alert appearing even on the latest version.

This issue existed on 1.2.3 as well, but I just updated to 1.2.4 and it's still there.
"Neue Version verfügbar! Klicken Sie hier, um sie herunterzuladen." appears at the top of the web interface even when running the latest version. Not a big deal but figured I'd mention it.

Already saw that, currently fixing it :)

Should be fixed with next release!

Cool :)

At first launch of v1.2.5 the alert was gone. But once I refreshed the tab it came back and I see a new error.

@marcelGoerentz

I will have a look on this

Cheers. If there is any info you'd like me to provide from my settings that will help diagnose it, just let me know :)

I think I already fixed it 😄
Next version should not show the banner unless there is a new version

Nice! Thanks again mate :)

Please close the issue if the banner is not appearing anymore

Seems fixed for me now. Thanks again mate :)

You are welcome, thanks for the feedback.


[Improvement][Alert] Add timeout params for alert HTTP request

close #15172

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d6175f3) 38.23% compared to head (c000441) 38.24%.

:exclamation: Current head c000441 differs from pull request most recent head 281a379. Consider uploading reports for the commit 281a379 to get more accurate results

Files
Patch %
Lines

...scheduler/plugin/alert/feishu/HttpRequestUtil.java
0.00%
2 Missing :warning:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
50.00%
1 Missing :warning:

...dolphinscheduler/plugin/alert/http/HttpSender.java
0.00%
1 Missing :warning:

...cheduler/plugin/alert/telegram/TelegramSender.java
50.00%
1 Missing :warning:

...hinscheduler/plugin/alert/wechat/WeChatSender.java
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15174   +/-   ##
=========================================
  Coverage     38.23%   38.24%
+ Complexity     4695     4694    -1
=========================================
  Files          1285     1285
  Lines         45453    45409   -44
  Branches       4951     4926   -25
=========================================
- Hits          17381    17368   -13
+ Misses        26181    26151   -30
+ Partials       1891     1890    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remote server reinstall every boot!, says: No server install found in WSL, needs linux-x64

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
Version: 0.40.1
VSCode Version: 1.91.1
Commit: 58b91712431381a1b75817cd3437cee35dddcb30
Date: 2024-08-24T02:52:24.035Z
Electron: 29.4.0
ElectronBuildId: undefined
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

Shutdown laptop
Open VSCODE (or cursor) and connect to WSL
It should not re-download server. as it was previous installed.

37] Extension version: 0.81.8
[2024-08-28 11:09:48.937] L10N bundle: undefined
[2024-08-28 11:09:48.960] authorityHierarchy: wsl+ubuntu-24.04
[2024-08-28 11:09:48.960] WSL extension activating for a local WSL instance
[2024-08-28 11:09:48.989] Resolving wsl+ubuntu-24.04, resolveAttempt: 1
[2024-08-28 11:09:48.989] NodeExecServer run: C:\Windows\System32\wsl.exe --status
[2024-08-28 11:09:49.077] WSL feature installed: true (wsl --status)
[2024-08-28 11:09:49.077] NodeExecServer run: C:\Windows\System32\wsl.exe --list --verbose
[2024-08-28 11:09:49.163] 2 distros found
[2024-08-28 11:09:49.165] Starting VS Code Server inside WSL (wsl2)
[2024-08-28 11:09:49.165] Windows build: 22631. Multi distro support: available. WSL path support: enabled
[2024-08-28 11:09:49.165] Scriptless setup: false
[2024-08-28 11:09:49.166] No shell environment set or found for current distro.
[2024-08-28 11:09:49.403] WSL daemon log file:
[2024-08-28 11:09:49.408] Probing if server is already installed: if [ -d ~/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30 ]; then printf 'install-found '; fi; if [ -f /etc/alpine-release ]; then printf alpine-; fi; uname -m
[2024-08-28 11:09:49.408] NodeExecServer run: C:\Windows\System32\wsl.exe -d Ubuntu-24.04 -e sh -c if [ -d ~/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30 ]; then printf 'install-found '; fi; if [ -f /etc/alpine-release ]; then printf alpine-; fi; uname -m
[2024-08-28 11:09:53.880] Probing result: x86_64
[2024-08-28 11:09:53.880] No server install found in WSL, needs linux-x64
[2024-08-28 11:09:53.880] Getting server from client side
[2024-08-28 11:09:53.881] Downloading VS Code Server stable - 58b91712431381a1b75817cd3437cee35dddcb30 into C:\Users\ItaloG5\AppData\Local\Temp\vscode-remote-wsl\58b91712431381a1b75817cd3437cee35dddcb30\vscode-server-stable-linux-x64.tar.gz.
[2024-08-28 11:09:54.545] Download checksum: undefined

[2024-08-28 11:09:48.937] Extension version: 0.81.8
[2024-08-28 11:09:48.937] L10N bundle: undefined
[2024-08-28 11:09:48.960] authorityHierarchy: wsl+ubuntu-24.04
[2024-08-28 11:09:48.960] WSL extension activating for a local WSL instance
[2024-08-28 11:09:48.989] Resolving wsl+ubuntu-24.04, resolveAttempt: 1
[2024-08-28 11:09:48.989] NodeExecServer run: C:\Windows\System32\wsl.exe --status
[2024-08-28 11:09:49.077] WSL feature installed: true (wsl --status)
[2024-08-28 11:09:49.077] NodeExecServer run: C:\Windows\System32\wsl.exe --list --verbose
[2024-08-28 11:09:49.163] 2 distros found
[2024-08-28 11:09:49.165] Starting VS Code Server inside WSL (wsl2)
[2024-08-28 11:09:49.165] Windows build: 22631. Multi distro support: available. WSL path support: enabled
[2024-08-28 11:09:49.165] Scriptless setup: false
[2024-08-28 11:09:49.166] No shell environment set or found for current distro.
[2024-08-28 11:09:49.403] WSL daemon log file:
[2024-08-28 11:09:49.408] Probing if server is already installed: if [ -d ~/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30 ]; then printf 'install-found '; fi; if [ -f /etc/alpine-release ]; then printf alpine-; fi; uname -m
[2024-08-28 11:09:49.408] NodeExecServer run: C:\Windows\System32\wsl.exe -d Ubuntu-24.04 -e sh -c if [ -d ~/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30 ]; then printf 'install-found '; fi; if [ -f /etc/alpine-release ]; then printf alpine-; fi; uname -m
[2024-08-28 11:09:53.880] Probing result: x86_64
[2024-08-28 11:09:53.880] No server install found in WSL, needs linux-x64
[2024-08-28 11:09:53.880] Getting server from client side
[2024-08-28 11:09:53.881] Downloading VS Code Server stable - 58b91712431381a1b75817cd3437cee35dddcb30 into C:\Users\ItaloG5\AppData\Local\Temp\vscode-remote-wsl\58b91712431381a1b75817cd3437cee35dddcb30\vscode-server-stable-linux-x64.tar.gz.
[2024-08-28 11:09:54.545] Download checksum: undefined
[2024-08-28 11:12:05.093] Server available at C:\Users\ItaloG5\AppData\Local\Temp\vscode-remote-wsl\58b91712431381a1b75817cd3437cee35dddcb30\vscode-server-stable-linux-x64.tar.gz
[2024-08-28 11:12:05.095] NodeExecServer run: C:\Windows\System32\wsl.exe -d Ubuntu-24.04 sh -c '"$VSCODE_WSL_EXT_LOCATION/scripts/wslServer.sh" 58b91712431381a1b75817cd3437cee35dddcb30 stable cursor-server .cursor-server --host=<IP_ADDRESS> --port=0 --connection-token=3531962487-699883425-3950576905-4218093392 --use-host-proxy --without-browser-env-var --disable-websocket-compression --accept-server-license-terms --telemetry-level=all'
[2024-08-28 11:12:09.018] Setting up server environment: Looking for /home/italo/.cursor-server/server-env-setup. Not found.
[2024-08-28 11:12:09.018] WSL version: <IP_ADDRESS>-microsoft-standard-WSL2 Ubuntu-24.04
[2024-08-28 11:12:09.319] Updating VS Code Server to version 58b91712431381a1b75817cd3437cee35dddcb30
[2024-08-28 11:12:09.319] Removing previous installation...
[2024-08-28 11:12:09.319] Installing VS Code Server from tar available at /mnt/c/Users/ItaloG5/AppData/Local/Temp/vscode-remote-wsl/58b91712431381a1b75817cd3437cee35dddcb30/vscode-server-stable-linux-x64.tar.gz
[2024-08-28 11:12:10.521] Unpacking:   0%  1%  2%  3%  4%  5%  6%  7%  8%  9% 10% 11% 12% 13% 14% 15% 16% 17% 18% 19% 20% 21% 22% 23% 24% 25% 26% 27% 28% 29% 30% 31% 32% 33% 34% 35% 36% 37% 38%
[2024-08-28 11:12:10.824]  39% 40% 41% 42% 43% 44% 45% 46% 47% 48% 49% 50% 51% 52% 53% 54% 55%
[2024-08-28 11:12:11.426]  56% 57% 58% 59% 60% 61% 62% 63%
[2024-08-28 11:12:11.725]  64% 65% 66% 67% 68% 69% 70% 71% 72% 73% 74% 75% 76% 77% 78% 79% 80% 81% 82% 83% 84% 85% 86% 87% 88% 89% 90% 91% 92% 93% 94% 95% 96% 97% 98% 99%100%
[2024-08-28 11:12:11.726] Unpacked 1886 files and folders to /home/italo/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30.
[2024-08-28 11:12:11.726] WSL-shell-PID: 406
[2024-08-28 11:12:11.726] Node executable: /home/italo/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30/node
[2024-08-28 11:12:11.726] Starting server: /home/italo/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30/bin/cursor-server --host=<IP_ADDRESS> --port=0 --connection-token=3531962487-699883425-3950576905-4218093392 --use-host-proxy --without-browser-env-var --disable-websocket-compression --accept-server-license-terms --telemetry-level=all
[2024-08-28 11:12:12.026] Server bound to <IP_ADDRESS>:38607 (IPv4)
[2024-08-28 11:12:12.026] Extension host agent listening on 38607
[2024-08-28 11:12:12.026]
[2024-08-28 11:12:12.026] [08:12:10]
[2024-08-28 11:12:12.026]
[2024-08-28 11:12:12.026]
[2024-08-28 11:12:12.026]
[2024-08-28 11:12:12.026]
[2024-08-28 11:12:12.026] FaroSystemAppender constructor
[2024-08-28 11:12:12.026] [08:12:10] Extension host agent started.
[2024-08-28 11:12:12.034] [08:12:10] [cmake-tools]: Couldn't find message for key cmake-tools.configuration.cmake.deleteBuildDirOnCleanCconfigure.description.
[2024-08-28 11:12:12.034] Started local proxy server on 52208.
[2024-08-28 11:12:12.035] WSL resolver response: <IP_ADDRESS>:52208
[2024-08-28 11:12:12.035] To debug connection issues, open a local browser on http://<IP_ADDRESS>:52208/version
[2024-08-28 11:12:12.095] NodeExecServer run: C:\Windows\System32\wsl.exe -d Ubuntu-24.04 -e /home/italo/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30/node -e const net = require('net'); process.stdin.pause(); const client = net.createConnection({ host: '<IP_ADDRESS>', port: 38607 }, () => { client.pipe(process.stdout); process.stdin.pipe(client); }); client.on('close', function (hadError) { console.error(hadError ? 'Remote close with error' : 'Remote close'); process.exit(hadError ? 1 : 0); }); client.on('error', function (err) { process.stderr.write(err && (err.stack || err.message) || String(err)); });
[2024-08-28 11:12:12.192] NodeExecServer run: C:\Windows\System32\wsl.exe -d Ubuntu-24.04 -e /home/italo/.cursor-server/bin/58b91712431381a1b75817cd3437cee35dddcb30/node -e const net = require('net'); process.stdin.pause(); const client = net.createConnection({ host: '<IP_ADDRESS>', port: 38607 }, () => { client.pipe(process.stdout); process.stdin.pipe(client); }); client.on('close', function (hadError) { console.error(hadError ? 'Remote close with error' : 'Remote close'); process.exit(hadError ? 1 : 0); }); client.on('error', function (err) { process.stderr.write(err && (err.stack || err.message) || String(err)); });
[2024-08-28 11:12:13.060] Download in background is enabled

I work mostly in offline environment, and this is stopping me from using vscode! I tried reinstalling vscode, reinstalling windows from scratch again but no change!

I'm not able to reproduce with the latest version of the WSL extension (0.88.2) and VS Code (stable 1.93.0)
Please try these versions. Note that we don't support running the remote-WSL on non-VS Code distributions, so I can't help you there.

I have tested it again and this does not happen under vscode alone, i will close this issue!


Missing steps to start sever in Readme.md or setup guide

I have complete the setup for the project but won't be able to start the server or see the working application by any other mean.

Hi there! Thanks for flagging this issue. I've updated the README and setup scripts, which may resolve the issue for you if you're working on Mac OS X.
If not, please let me know and share some more details about your environment :-)

Gunna go ahead and close this issue for now, but please don't hesitate to reopen it if needed.


Extension icon is missing in activity bar.

VSCode Version:
OS Version:

Steps to Reproduce:

extension icon is missing in activity bar.

Please share a screenshot and version details of VS Code that you are using

Right-click the activity bar; ensure that "Extensions" is checked.


Update DG

Codecov Report

Merging #14 (303cbfc) into master (1e88b51) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e88b51...303cbfc. Read the comment docs.