Triplanar mapping

Hi,
I've started this implementation and would ask someone to have a look to see if this appears to be in the right track.
I am following this and I think I've got the "Basic Swizzle" method implemented

Questions:

Is this manipulation I did with the HitPoint ok?
Which of the normals should I use for blending? (Geometric/Interpolated/Shading)

Todo:

[ ] Finish interface implementation

[ ] Evaluate the other methods for blending

[ ] Test

I believe it is working ok enough to put on the main repo and let people on the forums play with it and show me all the 200 ways this is not working as intended.
I will wait for the checks to finish and then merge that, ok?

Hey, want to test but it seems i cannot download this branch from azure? It only let's me download logs.

Questions:
Is this manipulation I did with the HitPoint ok?

If you change the UV values, you need to update also all related values: dpdu, dpdv, dndu and dndv.  The code to initialize them is here: https://github.com/LuxCoreRender/LuxCore/blob/095a94b1f467894ef39f1590dcf905b771a97dee/src/slg/bsdf/hitpoint.cpp#L68
Just use a single temporary HitPoint and reuse it to evaluate all 3 directions: not only it is faster (avoid to copy the large HitPoint structure but it is also the only way it can work with OpenCL: there is the space for only a single temporary hitPoint there).
@Alpistinho, you have also to use a TextureMapping3D to transform the HitPoint.p, before to initialize the temporary Hitpoint, so the user can scale, translate rotate the trilineari mapping.

Which of the normals should I use for blending? (Geometric/Interpolated/Shading)

Geometric Normal si the triangle normal, Interpolated normal is the vertex normal interpolated and Shading normal is the Interpolated normal with bump mapping.
You have probably to use the Interpolated normal.
P.S. remove the 3 unused parsed textures src/slg/scene/parsetextures.cpp

This is a very useful feature, nice work.
Did you test how well the blending works with normal/bump maps yet?

I have not tried but I suggested to use the Interpolated normal (i.e. without bump applied) exactly to avoid problems if bump/normal mapping is enabled.

I meant blending three normalmaps and use the result for normal mapping.

Thanks for the review
I will check the hitpoint issues.
About the mapping, I have been using the mapping on textures that are fed to the Triplanar texture to change it. Do you think that using a 3D mapping is more correct or more intuitive?

Hey, want to test but it seems i cannot download this branch from azure? It only let's me download logs.

@acasta69 may have removed the possibility to store not official builds. You can can ask him to re-enable this feature.

It's because this comes from a pull request. For PRs, the build is done to check for errors, but no build artifacts are uploaded.
Personally I think this behaviour is desirable, otherwise anyone could submit a PR and have binaries published in our repo, but if you want I can change it.

Oh ok, I understand. Will wait until it's in official daily builds for testing :)

About the mapping, I have been using the mapping on textures that are fed to the Triplanar texture to change it. Do you think that using a 3D mapping is more correct or more intuitive?

It is a bit cumbersome to have to edit the mapping of 3 input textures; 99.99% of the times, just to input the same values on all 3 of them.
Adding a mapping option directly to the triplanar node will be handy, it is also faster (from the code execution point of view: a single mapping is executed). and it is easy to implement, it is like a single additional line of code (parsing aside).
The option to use the mapping of the 3 input textures will be also still available.

@Dade916, about the updating the partial derivatives for point and normal (dpdu, dpdv, dndu, dndv), my understanding is that the textures are being projected into a plane, so these assume fixed values, regardless of the underlying geometry, right?
Something like this (still missing the 3D mapping):

    hitPointTemp.uv.u = hitPoint.p.y;
    hitPointTemp.uv.v = hitPoint.p.z;

    hitPointTemp.dpdu.x = 0;
    hitPointTemp.dpdu.y = 1;
    hitPointTemp.dpdu.z = 0;

    hitPointTemp.dpdv.x = 0;
    hitPointTemp.dpdv.y = 0;
    hitPointTemp.dpdv.z = 1;

    hitPointTemp.dndu.x = 0;
    hitPointTemp.dndu.y = 0;
    hitPointTemp.dndu.z = 0;

    hitPointTemp.dndv.x = 0;
    hitPointTemp.dndv.y = 0;
    hitPointTemp.dndv.z = 0;

    Spectrum spectrum = texX->GetSpectrumValue(hitPointTemp)*weights[0];

Nope, it the " / ", how P/N changes at U/V change.
Delta U/V may be constant in your case but P is a point on the object surface, it is not constant. N will be also not constant for any, not planar, object.
Just add a call to GetDifferentials() and print the results, you will see they are not the values you are suggesting.

I think I understand what these partial deriavatives values mean.
However, I thought that since we're projecting the textures from a plane, using its UV values, and not directly into the mesh, the partial derivatives would be calculated using the plane geometry.
If that assumption is incorrect, as it appears to be, then I understand how the partial derivatives will assume values depending on the underlying geometry.
What is the best way for me to compare the results ? Bump Mapping?

The generic code (currently used by your Triplanar texture) is here: https://github.com/LuxCoreRender/LuxCore/blob/3def40b17cd9fa03f78bb7684215f23f3c74acf3/src/slg/textures/texture.cpp#L48
As you can see, it works by sampling the texture on P than again moving slightly along the U axis and than again along the V axis. The differences are used to do bump mapping.
It is a generic implementation that work fine with the vast majority of textures. You can have a custom implementation for various reasons, for instance, image map texture has one that is both faster and avoid artifacs: https://github.com/LuxCoreRender/LuxCore/blob/3def40b17cd9fa03f78bb7684215f23f3c74acf3/src/slg/textures/imagemaptex.cpp#L41
I assume your texture will work fine but it is worth checking. Just do a couple of renderings and check if you get the expected results and no artifacts.
At the end of the day is just a qualitatively evaluation: if it looks fine, it works fine.

@Alpistinho  ?

Sorry, a bunch of work stuff got into the middle this past two weeks.
I hope to be able to work on that again this week, although I was having a bit of trouble to understand everything I had to do.
Do you have any timing intention about this issue ?

Aside from writing the OpenCL, I assume it is pretty much done (?).

I am coming back to this.
Just rebased the branch and found out that I need to adapt for the new multiple UV feature.
I will let you know about that

Awesome, looking forward to it!

I'm facing terrible issues (as usual) to import my build into Blender.
I haven't tested the new code yet, but I hope it is kinda working. Will try to do that soon

I think I've got it working as intended again.
Would it be possible for someone else to give it a spin?
I don't really know what to expect outside the trivial cases

I'll check it out next year when I'm back on my PC.

This is not exposed in blender I assume. Gotta wait for Simon to implement this?

@lacilaci ,
There is a matching PR on BlendLuxCore repo, if you want to try that:
https://github.com/LuxCoreRender/BlendLuxCore/pull/320


Question: Regions

Is there any opposition to, as I'm editing the files for a pull request, Regioning the code to organize the file a little more? I was thinking something simple like the following (don't mind my cool color scheme):

I know some developers are not fond of regions so I figured it better to ask.

Well I like them,  but we can only use them if there are used in others parts. (consistently) .
I don't think we use them much.
Most people don't like regions,  because regions are used in too fat classes/files etc.

Damn. Alright, I'll leave the files as is.


Rust 2021 Edition

Rust 2021 Edition has been released and we should probably switch to this. Will bump MSRV to 1.56.0 and should be considered a breaking change.

Taken off v017 milestone, as this needs some more investigation regarding pros/cons, and if moving to Edition 2021 actually provides us or users with any real benefits.

As the MSRV for edition 2021 is 1.56 and we're on 1.57 as part of a minor release (which doesn't seem to have broken any depending builds), I think it's safe to move to 2021 edition now (the edition isn't forced on depending libraries, only the compatible rustc version). The compatible rustc version was also released more than a year ago. Thus, I'll be removing the breaking change and we can have this as part of a new minor release.


Draw 800km circles around both poles in Tissot example

The line of the 800km circle around the south pole can be seen in the current example when panning, but there was no corresponding circle around the north pole.

Thanks, @mike-000


Code Outline : a exportDefaultExpression does't show outline properly

VSCode Version:1.44.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

use vscode inter typescript version which is 3.8.3
open a test.js file , and input code as below

export default {
  a: 'string',
  b: 2,
  c () {

  }
}

a exportExpression outline is looks like

when i change  the typescript version to 3.7.5
the outline show below, i think this may be better, but i am not sure if this is a typescript bug or vscode's.

大纲 is outline

Does this issue occur when all extensions are disabled?: Yes

Duplicate of https://github.com/microsoft/TypeScript/issues/37877


fixes issue#164

fixes issue https://github.com/opensds/opensds-dashboard/issues/164

@wisererik @leonwanghui @anvithks @liuqinguestc

Please change the base branch to master


Javascript vars

I've set identing spaces in brackets by 2. Brackets automatically detects new line var so line by line vars are formatted like this:
var var1,
    var2,
    var3;

Beautifier leaves like this:
var var1,
  var2,
  var3;

Any workaround?

This would be #238.


Adding Horizon School of Digital Technologies

@midoblgsm First stage of verification passed, official domain is horizon-university.tn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://horizon-university.tn/admins

@midoblgsm Thank you for your patience while waiting for a review and processing your request. Pull request merged.


refactor(dbm-services): mysql、proxy升级版本升级联调

关联研发信息
dev_branch: refactor/adapt_mysql_upgrade_flow/#5584
target_branch: v1.5.0


Task - Filter Collection Object (refactor)

Biocuration

[x] Smart selector with biocuration types, user can click various on off, added to list; param is biocuration_class_ids[]=

Biological associations
We need fucntionality identical to the 2 nomeclature filter Taxon name relationship facets.

[x] Biological relationship facet
[x] In biological relationship - double check param is biological_relationship_ids[]=

Identifier

[x] In range fields are string input, not dates
[x] Add section "Identifiers"
[x] Add input 'Value' (param identifier)
[x] Add Boolean "Match" - 'Exact', 'Partial', param identifier_exact
[x] Add Subsection 'In range'
[x] Add fields 'Start', 'End', with params identifier_start, identifier_end
[x] Add Subsection 'Namespace'
[x] Add Namespace smart selector (only one value selected), param is namespace_id

Tags

[x] Add header "Tags"
[x] Add Keyword smart selector, multiple keywords can be selected.
[x] Update keyword smart selector to use CVT color in some way (if it doesn't already)
[x] param is 'keyword_ids[]='
[ ] Add top level option (Seomwhere top right) to Tag all in this set with Default keyword

Determinations

[x] " Both valid" => " Both valid/invalid"
[x] Remove "Include descendants" boolean under Determinations
[x] Add radio button where "Invlude descendants" was- "Current/historical", options "Both", "Current only", "Historical only".  nil, true, false to param current_determinations
[x] Add 'Taxon name' sub header under Determinations
[x] Add TN Autocomplete, selects only one name, param is ancestor_id
[x] Add radio button below autocomplete "Linked to" Both valid/invalid, Valid only,  Invalid only, values are nil, true, false for validity

"User"

[x] Add a "--None--" to User list, if selected it unsets dates, and locks both dates and target radio
[x] Add "Target" and radio buttons "Created at", "Updated at", default to created, disabled until user is selected
[x] Disable date range until user is selected
[x] Params: user_id, user_target (one of 'created', 'updated'), user_date_start, user_date_end

Collecting event

[x] Replace 'exact' with 'Partial', change param name to be collecting_event_wildcards[]=

Misc

[x] Bind ctrl-s to Search button (or whatever key we've been using); Include a ctrl-r or similar to reset
[ ] Disable "Search" until at least one facet has been populated? Not sure worth tracking though...
[x] Spinner not covering whole result should be at top of page- maybe spinning besides a result counter that +1s up as the results load?
[ ] Place count result at top of result page
[x] Increase max to 1k
[ ] Download CSV button (csv to start, DWCA version if we can get the binding to DWCA table)
[x] "No results" should display prominently on the screen if none returned
[x] shapes drawn on map do not persist
[x] instructions on map overlap shapes in distracting way.
[x] User list does not display
[x] Rename "Select user and date range" to "User"
[x] Create a new sub-section "Collecting Event", move "Select date" to there and rename "Date range".  If built correctly everyting in this subsection should be a component for the CE filter (or we take from CE and put here).
[x] Add Collecting Events facet - select one or more collecting events (passing their Ids to collecting_event_ids from a smart selector
[x] Add Boolean Collecting events are spatial
[x] Change Otu to Determinations, add a sub header "Otu" above the OTu selector, move descendants check below OTU autocomplete list

Initial competency questions (keep to under 10, these are all "AND" facets):

What are the specimens collected in this date range
What are the specimens collected for this taxon
What are the specimens collected in this area
What are the specimens collected by this collector (person)
What are the specimens collected in this catalog number range
What are the specimens collected in this collecting event(s)
What are the specimens collected in this nomenclatural range
What are the specimen on loan

[] What specimens has this biological association
[] Show type specimens
[*] Search for particular data attributes

Closing for individual issues at this point:

#1315
#1316


fix(license): Licensing

Description
Optimizes license pattern replacement using aho-corasick.
The aho_corasick crate implements the linear-in-string-length Aho Corasick algorithm for string searching using SIMD when available.
Under the hood, aho_corasick builds a finite state machine for executing string searches.
Using Aho Corasick in place of chained, native rust String replace method calls optimizes away multiple string reconstructions.
This PR also extends license construction with additional template patterns to match dynamic year and copyright owner values against.
Fixes #25

Current dependencies on/for this PR:

main

PR #61   👈

This comment was auto-generated by Graphite.


Randomly my badge goes back to silver from gold?

The badge randomly downgraded to silver, and when I checked the dashboard, it shows everything is 100% complete, and nothing is wrong.
Here is the project,
https://www.bestpractices.dev/en/projects/9451?criteria_level=2
Here is the repo,
https://github.com/DefinetlyNotAI/Logicytics

You're right, that's wrong.
I think what's happening is that the badge image is cached at the CDN, and for some reason the cached value is not being removed when there's an update. We need to figure out WHY that happened.
Did you recently complete things to earn gold?
I will investigate regardless. Thanks for the report!

Funny part was, I completed everything 2 days ago, GitHub didn't update the badge until 3 hours before I opened the ticket, so I refreshed the page, and its back to silver - I thought I was the problem as in I was hallucinating the gold status 💀

And now its back to gold - dunno if this helped or anything, but thanks anyways :)

Wait, no - In github it shows gold but the openssf website shows silver???

We use Fastly as our CDN. Fastly distributes cached data out quickly (as pitched by the name) to many locations. There may be an inconsistency. Another option is that slightly different request names are being interpreted as different cached results.
There are 2 big problems in Computer Science: Caching, naming, and off-by-one errors. Looks like we hit item #1. For scale we need caching.
Are there different URLs that are being requested when you see different results? If you have any other data that might give me a lead, please let me know.
Sorry for the trouble. The fix will probably be not too hard, but the trick will be to track it down.

Don't close it yet. I want to track this down.
It'll fix itself eventually, because cached data has a limited lifetime. But I'd like to fix it.

We use Fastly as our CDN. Fastly distributes cached data out quickly (as pitched by the name) to many locations. There may be an inconsistency. Another option is that slightly different request names are being interpreted as different cached results.
There are 2 big problems in Computer Science: Caching, naming, and off-by-one errors. Looks like we hit item #1. For scale we need caching.
Are there different URLs that are being requested when you see different results? If you have any other data that might give me a lead, please let me know.
Sorry for the trouble. The fix will probably be not too hard, but the trick will be to track it down.

Welp, I guess when a programmer finds something out of his ability to fix rn - he jumps to observing it 😅
Ehh, i dont really worry if it bounces from silver to gold and reverse, its not like I am depending my computer security on it - good luck on your bug-hunt - I have a feel you may need it

Ooh, at least it seems you have a plan!
Most bugs issue's are actually finding them - it seems you narrowed it down to caching problem's that may or may not be out of ur control - I would like to help, so if you need anything from me, do say

Thanks so much! If I can fix it on our end, I'd rather actually fix it. I'm going to see if I can find an actual bug to fix. Thanks for the offer. I'll have to figure out what to ask first :-).

Well, at least I can say I am the only project with 300% silver

This may help you, as it must have somthing to do with caching, as I have been in silver for almost 4 months, and in the end it does recognise I am 300% but doesnt get the proper badge for it, which is pretty weird, I have thought it was linked as in only the percent actually mattered and the Badge was then shown based on the percent

Hello, now it seems it has updated properly, Both the GitHub badge embed AND the openssf website shows gold

In some sense that's unfortunate, because it makes it harder for me to figure out what happened. I captured data using curl about the cached data before it fixed itself, and that didn't enlighten me.
That said, I have a hypothesis of what happened, and how we can make sure it stays fixed.

gl


Ctrl-D no longer pages down

Ctrl-D now deletes the character under the cursor instead of paging down.

Interesting, that's the emacs keybinding for Ctrl-D. Since that's part of the defaultKeymap for CodeMirror it's probably overriding what is set by codemirror-vim. I think it's the same cause as #16.

Maybe unrelated (or also shares a cause with #16), but Backspace now deletes the previous character in normal mode, instead of just moving the cursor.

This was fixed by the linked pull request. Thank you for the report.


Middleware inheritance

Now that I've converted our entire API to use route attributes, I've noticed some patterns that I would like to improve. In particular, it's a little cumbersome that overriding middleware set on the controller level is impossible:
use Spatie\RouteAttributes\Attributes as Routing;

#[Routing\Middleware('throttle:200')]
class FooController
{
    #[Routing\Middleware('throttle:2')]      <-- will add another throttle middleware
    public function expensiveCall(): Response;
}

While this makes perfect sense, it requires me to define the middleware on every method explicitly, only because I have single culprit with different requirements. I've been thinking about how to solve this, and would like to suggest adding a WithoutMiddleware attribute:
use Spatie\RouteAttributes\Attributes as Routing;

#[Routing\Middleware('throttle:200')]
class FooController
{
    #[Routing\WithoutMiddleware('throttle:200')]  <-- removes the middleware inherited from the controller
    #[Routing\Middleware('throttle:2')]
    public function expensiveCall(): Response;
}

This isn't really elegant, though. Would anyone have a better idea?

Feel free to PR this included tests and an updated readme. Thanks!

my solution is just adding middleware on specific endpoint by overide it

#[Middleware(['api'])]
#[Prefix('api')]
#[Resource('quotes', apiResource: true)]
class QuoteController extends Controller
{
    // ...

    #[Post(uri: 'quotes', name: 'quotes.store', middleware: 'auth')]
    public function store(CreateQuoteFormRequest $request): JsonResponse
    {
        // ...
    }

    // ...


stratified cv for python wrapper

two new parameters for python xgb.cv: stratified and folds
stratified = False per default to keep current behavior
user can pass sklearn KFolds or StratifiedKFolds via folds parameter
unit test added
stratified = True depends on sklearn (install check implemented)

refers to issue: https://github.com/dmlc/xgboost/issues/729

Looks good. Can you finalize the docstring (get rid of question mark) and rebase to resolve conflicts?

done (docstring changes squashed)

Thanks! Will merge when tests pass.

you're welcome

@Far0n
Hi Faron, I try to use stratified = True in python for a binary classification but got the following error :
/home/haozhen/temp/xgboost/python-package/xgboost/training.pyc in mknfold(dall, nfold, param, seed, evals, fpreproc, stratified, folds)
237         nfold = len(idset)
238     else:
--> 239         sfk = XGBStratifiedKFold(n_splits=nfold, shuffle=True, random_state=seed)
240         idset = [x[1] for x in sfk.split(X=dall.get_label(), y=dall.get_label())]
241
TypeError: init() got an unexpected keyword argument 'n_splits'
I know I can pre build the stratified folds  and pass them into the folds parameter. I just want to understand why this error happened.
Below is the code I used:
param = {'objective':'binary:logistic',
'booster' : 'gbtree',
'eta' : 0.05,
'max_depth' : 7,
'subsample' : 0.83,
'colsample_bytree' : 0.8,
'num_parallel_tree' : 1,
'min_child_weight' : 5,
'gamma' : 5,
'max_delta_step':1,
'scale_pos_weight':sum(dtrain.get_label()==0)/sum(dtrain.get_label()==1),
'silent':1,
'seed' : 2016,
'eval_metric': ['auc'],
}
# cross validation
cv = xgb.cv(param, dtrain, num_boost_round = 500, nfold=5, stratified = True,
early_stopping_rounds = 10, maximize = True,
callbacks=[xgb.callback.print_evaluation(show_stdv=True)])
Thank you very much!

This should be fixed. Please try the latest version.

@terrytangyuan
Hi Terry,
I just tried some similar code for a Kaggle competition and got the exact same error. I saw the recent latest commit made by you 63829d6 so I re-cloned the repo and built the package. However, it still throws the same error. Maybe I did something wrong when I rebuilt the package. Any suggestions?

What version of sklearn are you using? Could you share the stacktrace of error?

I am using sklearn 0.17.1 (I guess it might be the problem.)
And the Trackback error is like this:
File "/usr/local/lib/python2.7/site-packages/xgboost-0.6-py2.7.egg/xgboost/training.py", line 367, in cv
    cvfolds = mknfold(dtrain, nfold, params, seed, metrics, fpreproc, stratified, folds)
File "/usr/local/lib/python2.7/site-packages/xgboost-0.6-py2.7.egg/xgboost/training.py", line 239, in mknfold
    sfk = XGBStratifiedKFold(n_splits=nfold, shuffle=True, random_state=seed)
TypeError: __init__() got an unexpected keyword argument 'n_splits'

Confirming that I am able to use it after upgrading to the latest version of sklearn(0.18).


Add Fluentd custom configuration support

Fixed in https://github.com/OT-CONTAINER-KIT/logging-operator/pull/1


cloudwatch_common: 1.0.1-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository cloudwatch_common to 1.0.1-1:

upstream repository: https://github.com/aws-robotics/cloudwatch-common.git
release repository: https://github.com/aws-gbp/cloudwatch_common-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.7.2
previous version for package: 1.0.1-0

cloudwatch_logs_common
* adding unit tests for cloudwatch facade
* Merge pull request #4 <https://github.com/aws-robotics/cloudwatch-common/issues/4> from juanrh/improve-coverage-cloudwatch_logger
  Improve coverage cloudwatch logger
* Make LogManagerFactory mockeable
* Make cloudwatch_logs_common shared lib to use it in other libs
* Merge pull request #1 <https://github.com/aws-robotics/cloudwatch-common/issues/1> from xabxx/master
  [Bug Fix] Resolved false-positive error log messages
* Resolved false-positive error log messages
* Contributors: Abby Xu, Ross Desmond, Ryan Newell, Yuan "Forrest" Yu, hortala

cloudwatch_metrics_common

No changes

1.0.1-0 was mistakenly generated with dependencies from melodic.


Optimised python code and also fixed errors

I have optimised the given python code using Dynamic programming approach. I have reduced the time complexity of the by avoiding redundant calculations that occur in the naive recursive approach. The time complexity of this approach is O(n), as it computes each Fibonacci number from 2 up to n exactly once. The space complexity is O(1), since only a constant amount of extra space (for variables a, b, and c) is used regardless of the input size n. This function efficiently computes the Fibonacci number for any non-negative integer n using an iterative approach with dynamic programming principles, making it suitable for larger values of n where recursive approaches would be inefficient.

Make sure the branch name is as per the required. This one is not correct.

You mean the name should be "fix-python-syntax-error" ?
On Wed, 19 Jun, 2024, 22:44 Yash Srivastava, @.***>
wrote:

Make sure the branch name is as per the required. This one is not correct.
—
Reply to this email directly, view it on GitHub
https://github.com/yash-srivastava19/missing-semester-bdacc/pull/2#issuecomment-2179192496,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6X2STSCHHD7CHFJ3SYFIETZIG37HAVCNFSM6AAAAABJNMXFK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGE4TENBZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

You mean the name should be "fix-python-syntax-error" ?
…
On Wed, 19 Jun, 2024, 22:44 Yash Srivastava, @.> wrote: Make sure the branch name is as per the required. This one is not correct. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6X2STSCHHD7CHFJ3SYFIETZIG37HAVCNFSM6AAAAABJNMXFK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGE4TENBZGY . You are receiving this because you authored the thread.Message ID: @.>

Yeah, as per the instructions.  If you want, you can add your name(at the end) so there won't be any name conflicts.


SCSS file does not agree with compiled CSS file.

I'm interested in customizing the clock size, and would rather work by changing one SCSS variable than hand-tweaking 30 css properties. I forked and set up grunt for building the CSS from the included SCSS file, but building with no changes to flipclock.scss resulted in numerous changes to flipclock.css.
It seems like there's either a missing change to the SCSS file, or it's old/obsolete and should be removed from the repo.
Here's one example change in flipclock.css after rebuilding from flipclock.scss (there are many more):
.flip-clock-wrapper * {
-    -webkit-box-sizing: border-box;
-    -moz-box-sizing: border-box;
-    -ms-box-sizing: border-box;
-    -o-box-sizing: border-box;
-    box-sizing: border-box;
-    -webkit-backface-visibility: hidden;
-    -moz-backface-visibility: hidden;
-    -ms-backface-visibility: hidden;
-    -o-backface-visibility: hidden;
-    backface-visibility: hidden;
-}
+  margin: 0;
+  padding: 0;
+  line-height: normal;
+  -webkit-box-sizing: border-box;
+  -moz-box-sizing: border-box;
+  box-sizing: border-box; }

Hi @igmcdowell!
Yes, the SCSS file is not actually being used to compile in the main branch. It was something added a few versions back that wasn't quite a 1:1 conversion of the CSS.
Take a look at #161 so you can see where we are going with this. I actually have grunt compiling from new SCSS files and some of the markup is getting refactored. In addition, the SCSS files will have variables associated and there will also be a couple other theme options, responsiveness, etc.
There is a 1.0 branch we are working on now. I have not actually pushed my working Grunt file that is doing all this, but there should be something of this in the 1.0 branch sometime this week. We're real close to what you are wanting to do out of the box... and a lot more.
I am going to go ahead and mark this one as closed in reference to #161

Thanks @brianespinosa. You rock man.

@brianespinosa thanks for the clarification. Just read through #161, it sounds great. Excited for the coming changes.


Rename /opt/openshift to /opt/app-root

[test]

[test]

ok to test

ok to test

I assume this will fail until the sti-base changes get merged?

@bparees yes, the problem is that if we merge this and we don't fix other images then the other images might get broken....

@bparees will probably have to pospone the testing until the sti-base changes are merged and new sti-base images are build

LGTM


Idempotency

Various resources get executed even if there is no change needed. While this is fine it 'pollutes' chef's statistics about updated resources e.g. when someone is monitoring those data using a chef-handler will see changes/updates on each converge:
e.g. within
https://github.com/TelekomLabs/chef-os-hardening/blob/master/recipes/minimize_access.rb
I would probably split "group" and "other"  into separate resources and guard them by "only_if" filters using "find #{folder} -perm -g+w " and "find #{folder} -perm -o+w "

Coverage remained the same when pulling f7fb196ba01a6f0366bc1fd9247e817a576d3efd on ehaselwanter:issues-64 into 74ac9ef8370414e833b612981adf1fdeaed8bd05 on TelekomLabs:master.

@ehaselwanter amazing


ci(Mergify): configuration update

This change has been made by @kelvin-olaiya from the Mergify merge protections editor.

Closing, this will go here


chore: release v1.6.4

This pull request prepares the following release:

Repository
Branch
Update
Change

autocomplete
releases/v1.6.4
patch
1.6.3 → 1.6.4

Release Summary
This is going to be published with the following command:

Dir
Command

packages/autocomplete-core
yarn publish --access public --tag latest

packages/autocomplete-js
yarn publish --access public --tag latest

packages/autocomplete-plugin-algolia-insights
yarn publish --access public --tag latest

packages/autocomplete-plugin-query-suggestions
yarn publish --access public --tag latest

packages/autocomplete-plugin-recent-searches
yarn publish --access public --tag latest

packages/autocomplete-plugin-tags
yarn publish --access public --tag latest

packages/autocomplete-preset-algolia
yarn publish --access public --tag latest

packages/autocomplete-shared
yarn publish --access public --tag latest

packages/autocomplete-theme-classic
yarn publish --access public --tag latest

Merging Instructions
When merging this pull request, you need to Squash and merge and make sure that the title starts with chore: release v1.6.4.

See details
After that, a commit chore: release v1.6.4 will be added and you or your CI can run shipjs trigger to trigger the release based on the commit.

This pull request is automatically generated by Ship.js.

We can release tomorrow morning.


Return the exact status code for P4Runtime request

Signed-off-by: Nupur Uttarwar<EMAIL_ADDRESS>

One of the quality recommendations for code reviews is to "write good change descriptions."
Since you're changing the behavior of the method, it would be useful to the maintainer to know why. Is it to allow a higher-level to to make a decision based on the status code? To provide a better description for a log message?
One way of doing this is to provide a problem statement, followed by a statement of what you're changing (and an explanation if the connection between the two isn't obvious).
Otherwise, LGTM

Modified the commit messgae


Update arrow FIR example

Add mult prim and use it in FIR example

Please can you add milestone, relevant bug, and priority? I'd like to try and get as much help as I can to help me follow along with what's going on with all the bugs and PRs. I'll add an "Arrow Investigation" project for this. Thank you.

Is there a test for this either in Coq or as an extracted SystemVerilog testbench?

Yes, in build logs it is the part:
make[2]: Leaving directory '/workspace/arrow-examples/obj_dir'
obj_dir/Vfir_tb
                  10: tick = 0, in_stream = 1, out_stream = 0
                  20: tick = 1, in_stream = 2, out_stream = 1
                  30: tick = 2, in_stream = 3, out_stream = 4
                  40: tick = 3, in_stream = 4, out_stream = 10
                  50: tick = 4, in_stream = 5, out_stream = 20
                  60: tick = 5, in_stream = 6, out_stream = 30
                  70: tick = 6, in_stream = 7, out_stream = 40
                  80: tick = 7, in_stream = 8, out_stream = 50
                  90: tick = 8, in_stream = 9, out_stream = 60

Please can you add milestone, relevant bug, and priority? I'd like to try and get as much help as I can to help me follow along with what's going on with all the bugs and PRs. I'll add an "Arrow Investigation" project for this. Thank you.

It's part of #302


added The Haskell Tool: Stack

This is a new template:

Link to application or project’s homepage: http://docs.haskellstack.org/en/stable/README/

@khalilfazal is there any reason why this needs to be it's own template? We're already including this in https://github.com/github/gitignore/pull/1577...

Sorry, I missed that. You can disregard my pull request.


Increasing UT coverage

Description
Added unit tests to increase unit test coverage
Fixes https://razorpay.atlassian.net/browse/METRO-158
Type of change

[x] Increasing test coverage

How Has This Been Tested?

[x] Running unit tests on local

Is it a breaking change?
No
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added unit tests that prove my fix is effective or that my feature works (if applicable)
[ ] I have added integration tests for the new feature (if applicable)
[x] I have manually tested my code to the best of my abilities.

This is the first PR that attempts to increase the code coverage by 1.85%. I will create one more PR to increase it further to 65%


proto: inline the implementation of protoimpl.X.ExtensionDescFromType

Technically, this differs from before in that it doesn't assign a nil *ExtensionDesc if the assertion fails. I don't know how much this matters.


showLicensePage can't fit the ThemeData

Steps to reproduce

Run APP.
Click the app bar icon button to show the license page.

Expected results
License Page ListTile content padding will change with the difference ListTileThemeData.
Actual results
Nothing changed.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(
      MaterialApp(
        theme: ThemeData(
          listTileTheme: const ListTileThemeData(
            contentPadding: EdgeInsets.zero,
          ),
        ),
        home: const _HomePage(),
      ),
    );

class _HomePage extends StatelessWidget {
  const _HomePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        actions: [
          /// Not working
          Theme(
            data: ThemeData(
              listTileTheme: const ListTileThemeData(
                contentPadding: EdgeInsets.all(32),
              ),
            ),
            child: Builder(
              builder: (context) => IconButton(
                onPressed: () => showLicensePage(context: context, useRootNavigator: true),
                icon: const Icon(Icons.info_outline),
              ),
            ),
          ),
        ],
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
Launching lib/main.dart on sdk gphone64 arm64 in debug mode...
Running Gradle task 'assembleDebug'...
✓  Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app-debug.apk...
Debug service listening on ws://<IP_ADDRESS>:54229/y0j3pWPQ878=/ws
Syncing files to device sdk gphone64 arm64...

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.8, on macOS 14.2.1 23C71 darwin-arm64, locale
    zh-Hant-TW)
    • Flutter version 3.16.8 on channel stable at /Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 67457e669f (2 days ago), 2024-01-16 16:22:29 -0800
    • Engine revision 6e2ea58a5c
    • Dart version 3.2.5
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/chien/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_SDK_ROOT = /Users/chien/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 12
      (API 31) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS
      14.2.1 23C71 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 120.0.6099.234
    ! Error: Browsing on the local area network for Eric hu iPhone. Ensure the
      device is unlocked and attached with a cable or associated with the same
      local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code
      -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

After many attempts this worked for me：
import 'package:flutter/material.dart';

class MLicensePage extends StatelessWidget {
  const MLicensePage({super.key});

  @override
  Widget build(BuildContext context) {
    return Theme(
      data: Theme.of(context).copyWith(
        listTileTheme: Theme.of(context).listTileTheme.copyWith(
              contentPadding: EdgeInsets.all(32),
            ),
      ),
      child: const LicensePage(),
    );
  }
}

Hi @a1573595
This is WAI. In your first sample code, the theme is applied to the child on first page only. showLicensePage will trigger the navigator to navigate to LicensePage. If you apply the theme to LicensePage widget like in your second sample code, it will work.
Closing as explained. If you disagree, please write in the comments and I will reopen it.


Uncaught ReferenceError: ReactDOM is not defined

Context
I use Chrome and Windows 10.
AdminBro works pretty well when I test it in localhost.
However, when I tried to host it on OVH, it gave me the following error messages :

It seems it doesn't compile.

I saw a similar issue in the list.
It seemed it was due to the route.
However, I specified my route as "/admin" in express.

AdminBro options :

Hunches
To access the deployed server, I set up the path to be "myapplication/api".
Therefore, I try to access to AdminBro through "myapplication/api/admin".
Is it possibly a reason?

I love your library, by the way! :3
Thank you for your work!

How do you deploy your app, and what command do you use to run it on your server?

Thank you for your answer.
The server is deployed on a VPS with Nginx.
It is launched with the start command: "node src/index.js".
Here is the Nginx configuration :
server {
listen 80;
    index index.html

    server_name ***;

    client_max_body_size 10M;

    location / {
            root /var/www/webapp/build;
            try_files $uri /index.html;
    }

    location /api/ {
            proxy_pass http://<IP_ADDRESS>:9000/;
    }

    location /socket.io {
            proxy_pass http://localhost:9001/;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection 'upgrade';
            proxy_set_header Host $host;
            proxy_cache_bypass $http_upgrade;
    }

}

You can clearly see in your console that the bunde files are not being served properly. The fact that it mentions unexpected token "<" in red means it's serving an error on that url.
In the following image, you should look closely at the head section, where all the script are being loaded:

You mention that the start command you use is "node src/index.js", suggesting you are not building the code. You haven't talked about dependencies (do you run yarn or npm install on deploy?)

It is launched with the start command: "node src/index.js".

And in your config, you use a directory called /var/www/webapp/build. Does that mean you are serving the build files from there?
There's a lot of gap of information in your issue. It's hard to help without them. Best is to ask on #slack for these kind of problems

I'll try my best to decrease the lack of information.
Global architecture
I'm working on a application which is using following architecture :

a client side based on React (which is contained in the webapp folder).
an Express server using Mongoose and AdminBro.
I also use a reverse proxy (Nginx) to connect the two sides and socket.io.

In the deployment phase, the client is built and will run at http://myapplication/.
The server will on the other hand be running at http://myapplication/api.
Running locally the server
As you said, I don't build my server. I just run it. Maybe this is the reason! ^^
The package.json file use the following dependencies and scripts:

I use npm to install dependencies (locally and before deployment).
When I run the server locally (with nodemon or node), AdminBro does work:

Running the deployed server
After deployment, the server is working:

However, when I try to access to the route /admin of the server (myapplication/api/admin),
I have the error I previously spoke of.
In the head section, I get a script with an assignment of the window.REDUX_STATE variable:

Here is the full source file:
adminbro_not_compiled.zip

I was referring to the script tags in the head section, aka:
      <script src="/admin/frontend/assets/global.bundle.js"></script>
      <script src="/admin/frontend/assets/design-system.bundle.js"></script>
      <script src="/admin/frontend/assets/app.bundle.js"></script>
      <script src="/admin/frontend/assets/components.bundle.js"></script>

This is the part that is failing for you. You have to find out why these assets are not loading properly.
If you are accessing your server via myapplication/api/, then /admin will refer to the root path, aka myapplication/admin. Since you are serving those files under myapplication/api/admin/..., obviously these won't load properly.
Just try accessing myapplication/admin/frontend/assets/global.bundle.js and myapplication/api/admin/frontend/assets/global.bundle.js to see what I mean. One should load, and the other will return a 400 (or any other error response)

I see the issue now!
The scripts are indeed accessible through myapplication/admin/api/...,
and the page tries to load them through myapplication/admin/....
I will look into it when I can.
I will put the way I resolve the case here.
Thank you so much!

Hi @p-pcode !
If I remember well, I was under a nginx reverse proxy.
The URL that was called wasn't the one I wanted (https://myurl.com instead of https://myurl.com/api).
I just had to change the configuration to make it work.


Ensure explicit check for Play Services availability

Since we have moved (in 3.1.1-dev) the play services dep to 11.6.0 we now need to deal with the one issue in the release notes for that version:

"GoogleApi instances created with a Context in apps with targetSdkVersion 26 won't automatically prompt users to update Google Play services. Consider using GoogleApiAvailability.showErrorDialogFragment() under these conditions instead."

Yep, but we've been doing that for a while (and I don't plan on removing it until that bug is fixed):
https://github.com/firebase/FirebaseUI-Android/blob/ba9167d80e5c749ac84782d395770c00faf59e1e/auth/src/main/java/com/firebase/ui/auth/KickoffActivity.java#L41-L57

Ok great, I honestly was just too lazy to find out if we had already been doing that.  Thanks for checking!

Haha, NP! 😄


how to increase the timeout for the workflow ?

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar question on existing issues (including closed ones).
[x] I searched the Internet for related problems, but still couldn't solve it.
[x] My question is based on the latest code of master branch.

Description
hi there,
I tried the template for 1.5k posts, working fine built on 3m
once pushed 14.5k posts, on build reach the default 360 minutes (6h) timeout, wrote :
The job running on runner Hosted Agent has exceeded the maximum execution time of 360 minutes.

I dig @
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
made the needed modification on pages-deploy.yml as
jobs:
  continuous-delivery:

    runs-on: ubuntu-latest
    timeout-minutes: 1200

then complain as
You have an error in your yaml syntax on line 15
:1234:
please advise!

@pipiscrew Did you manage to figure out a solution?

finally I build it locally and upload to pages repo, took ~6h to build ;)
you can see the result at :
https://pipiscrew.github.io/
Im not happy as the search is not working, how I will find something on 14.5k articles!? ;)

finally I built it locally and upload to pages repo, took ~6h to build ;)
you can see the result at :
https://pipiscrew.github.io/
Im not happy as the search is not working, how will I find something on 14.5k articles!? ;)


Table detail wizard

Summary

New component - table detail wizard

ps. this PR depends on https://github.com/IBM/carbon-addons-iot-react/pull/210
Change List (commits, features, bugs, etc)

new component
updates on tests cases

Related Issues

Closes IBM/carbon-addons-iot-react#NUMBER

Acceptance Test (how to verify the PR)

Validate the component.

:tada: This PR is included in version 1.46.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.46.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Matt spin up on webapp development

I haven't done significant TypeScript development since last December.
Is there immediate technical debt? Does documentation need to be updated? Do dependencies need to be updated? Are there current practices we should be following?

✅ #33
Migrated from CircleCI to GitHub Actions helped simplify our CI config.

✅ #35
Upgraded dependencies with vulnerabilities detected by audit

✅ #36 enables connecting to a non-production API URL
Will make it easier to test #32

There haven't been any new releases of React in over a year, so dealing with dependencies has been fairly smooth sailing.
Some less-critical things have upgrades available:

Highcharts v11
Openlayers v8
Bootstrap v5

✅ #38 https://github.com/nsidc/snow-today-webapp-server/pull/30
Changed notprocessed regions to grey


Add HostHeader tunnel option

To let tunnels change the Host request header in web-forwarding, we need to pass this header to the service.

More changes are coming. We'll need an option to keep the host header "as is", and, maybe similar options for other request headers, like Origin.


a2e235e removes with support for null-ls integration

As the title says, when updating to a2e235e it breaks the with keyword when using the null-ls integration.
Failed to run `config` for null-ls.nvim

...ot/Users/datwaft/.config/nvim.lazy/fnl/conf/lsp/init.lua:69: attempt to call field 'with' (a nil value)

# stacktrace:
  - ~/.cache/nvim/hotpot/Users/datwaft/.config/nvim.lazy/fnl/conf/lsp/init.lua:69 _in_ **config**
  - ~/.config/nvim.lazy/init.lua:78

Here is the important code snippet:
    (let [{: formatting
           : diagnostics
           : hover
           : completion
           :code_actions actions} null.builtins
          typescript-actions (require :typescript.extensions.null-ls.code-actions)]
      [formatting.stylua
       (formatting.prettierd.with {:condition (fn [utils]
                                                (not (utils.root_has_file ["deno.json" "deno.jsonc"])))})
       formatting.markdownlint
       formatting.black
       formatting.isort
       (diagnostics.pylint.with {:prefer_local ".venv/bin"})
       (diagnostics.mypy.with {:prefer_local ".venv/bin"})
       (typescript-actions.with {:condition (fn [utils]
                                              (not (utils.root_has_file ["deno.json" "deno.jsonc"])))})]))

It is in Fennel but if you need I can translate it to Lua.

Whoops, my bad. I think f66d4472606cb24615dfb7dbc6557e779d177624 should take care of this, but let me know.

It works once again, thanks!
I will now close the issue.


Added BestTime.app Foot Traffic Data API

Besttime provides a free account for public usage. Students receive an additional amount of free API credits.

[X] My submission is formatted according to the guidelines in the contributing guide
[X] My addition is ordered alphabetically
[X] My submission has a useful description
[X] The description does not end with punctuation
[X] Each table column is padded with one space on either side
[X] I have searched the repository for any relevant issues or pull requests
[X] Any category I am creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

Thanks for your contribution @besttime-app 😄
This API does not have a free plan for renewed use in a certain period of time. It offers credits that, when exhausted, must be paid for use again.
To be listed here, the API must offer a free plan that is renewed again after a certain time.


<EMAIL_ADDRESS>install Fails in mac

With node version 4.4.7 and npm 2.15.8, npm install in my project fails at this point.
Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the node-expat package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs node-expat
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls node-expat
I have tried many workarounds from the internet world and nothing seems to work.

Terribly sorry that npm is that chatty, but it's not enough of the error message.

I've see the same problems. At the top of the logging it says:
xcrun: error: active developer path ("/Applications/Xcode.app/Contents/Developer") does not exist, use xcode-select --switch path/to/Xcode.app to specify the Xcode that you wish to use for command line developer tools (or see man xcode-select)
gyp: No Xcode or CLT version detected!
And this is the best hint: npm does not find XCode. You must install XCode or (like me) rename or symlink a XCode folder with version number from "XCode 8.0.app" to "XCode.app". That solved the problems on my machine.

I don't have a problem with my xcode AFAIK. Nothing about the xcode in the logs.


Androidndk standalone toolchain support

Motivation for this change
I wanted to use the android standalone toolchain ;)
Now a standalone toolchain is available via:
    let
      toolchain = (androidenv.androidndk.makeStandaloneToolchain 24 "arm64");
    in
    ...

CC @matthewbauer
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@matthewbauer ping

Sorry
@grahamcofborg build pkgsCross.androidndk.android64.gmp

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsCross.androidndk.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsCross.androidndk.android64.gmp, ensureUnaffected.androidndk
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

Cannot nix-instantiate `ensureUnaffected.androidndk' because:
error: attribute 'ensureUnaffected' in selection path 'ensureUnaffected.androidndk' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: pkgsCross.androidndk.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: pkgsCross.androidndk.android64.gmp, ensureUnaffected.androidndk
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

Cannot nix-instantiate `ensureUnaffected.androidndk' because:
error: attribute 'ensureUnaffected' in selection path 'ensureUnaffected.androidndk' not found

Sorry
@grahamcofborg build pkgsCross.android64.gmp

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsCross.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.android64.gmp' because:
error: attribute 'android64' in selection path 'pkgsCross.android64.gmp' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: pkgsCross.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.android64.gmp' because:
error: attribute 'android64' in selection path 'pkgsCross.android64.gmp' not found

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: pkgsCross.androidndk.android64.gmp, ensureUnaffected.androidndk
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

Cannot nix-instantiate `ensureUnaffected.androidndk' because:
error: attribute 'ensureUnaffected' in selection path 'ensureUnaffected.androidndk' not found

@grahamcofborg build pkgsCross.aarch64-android-prebuilt.hello

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsCross.aarch64-android-prebuilt.hello
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: pkgsCross.androidndk.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.androidndk.android64.gmp' because:
error: attribute 'androidndk' in selection path 'pkgsCross.androidndk.android64.gmp' not found

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: pkgsCross.android64.gmp
Partial log (click to expand)
Cannot nix-instantiate `pkgsCross.android64.gmp' because:
error: attribute 'android64' in selection path 'pkgsCross.android64.gmp' not found

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: pkgsCross.aarch64-android-prebuilt.hello
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: pkgsCross.aarch64-android-prebuilt.hello
Partial log (click to expand)
make[2]: Leaving directory '/build/hello-2.10'
make[1]: Leaving directory '/build/hello-2.10'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android
shrinking /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android/bin/hello
gzipping man pages under /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android/share/man/
aarch64-unknown-linux-android-strip is /nix/store/rrdhzmwx0n9s014hscdiggsa7d641169-ndk-gcc-binutils/bin/aarch64-unknown-linux-android-strip
stripping (with command aarch64-unknown-linux-android-strip and flags -S) in /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android/lib  /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android/bin
patching script interpreter paths in /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android
checking for references to /build in /nix/store/4y5a8x39fqmd10wva90r93dvzvbgzb4k-hello-2.10-aarch64-unknown-linux-android...

[IMO it would have been ever so slightly nice to just inline the thing into passthru and not need to reindent. I just hit some merge conflicts because of this, and it shows the the derivation itself doesn't depend on what's in the let-binding. Of course, this is all NBD :).]


solc: 0.5.9 -> 0.5.10

Update the package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Could someone with @GrahamcOfBorg MacOS access help test building on MacOS? Thanks!

@GrahamcOfBorg build solc

IMO this is ready to be merged

LGTM! tested locally on NixOS.
Hi, @marsam I think that this PR gets stuck. Could you merge this PR? Thank you!

Thanks!


update conference cg: siggraph, siggraph aisa

Which conference does this PR update?

CG conference: ACM SIGGRAPH
CG conference: ACM SIGGRAPH ASIA

Related URL

https://s2021.siggraph.org/
https://sa2021.siggraph.org/

Is SIGGRAPH ASIA in CCF list? I can't find it.

Yes, the Siggraph Asia and Siggraph are the same, the accepted papers will be collected by the ACM transactions on graphics (CCF A journal)。
You can refer to its official website.

OK. there are two issues:
First, it seems that we do not support timezone like UTC/GMT. I think it should be AoE.
Second, the dblp of SIGGRAPH ASIA should be siggrapha instead of siggraph aisa.
Please fix them.

I change the timezone from UTC/GMT-->UTC+0, and the dblp of siggraph asia is changed to '''siggrapha'''


Investigate template/fillable PDF fields in Adobe Acrobat

We think that Acrobat lets you name and specify certain fields as fillable on your PDF. Then there should be a library that lets you read those fields. Confirm!

@bion is anyone researching this?
cc @gcapiel

@neel-a-mehta A couple devs have looked into it a little bit. I've implemented PDF filling a couple times in other programming languages. Fields are identified by their "name" property and can be edited using Adobe acrobat: https://helpx.adobe.com/acrobat/using/pdf-form-field-properties.html
Whatever library we use will allow us to specify fields by name for filling.


Quick Look

Summary of the new feature/enhancement
Instead of explorer preview, quick look like in Mac would be more intuitive to the user
Proposed technical implementation details
If there was an tab in power toys with QuickLook, it would be more useful than just preview  which cannot show preview for various file types like .py, .kt etc..

I could see this as a useful feature, however I will comment that there are good equivalents in the Microsoft Store. (There is an app specifically called QuickLook in fact). I believe that app is open source, however and maybe the developer would be interested in working with the PowerToys developers, if they decide that they want to pursue this feature.

I agree. But most of the normal users might not know about the quicklook app on Microsoft store. If the developer is interested in working with powertoys, like Tadele's Window walker for powertoys run, it will more likely become a core feature.

Duplicate here: https://github.com/microsoft/PowerToys/issues/80

dup of #80


chore: allow long commit footer

:tada: This PR is included in version 2.14.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[Windows - V 2.0.0 ] bundling meteor -> shell.js internal error

Hi,
When I running app with :
cd leaderboard
electrify

works great =D
Now here is the error I by running :
electrify package

I had the same error 1.4.0 version in meteor shell
My username is :

The same path
C:\Users\RBOUDE~1.AEI\AppData\Local\Temp\Electrify\bundling\bundle exist
C:\Users\r.boude***.AEI_02\AppData\Local\Temp\electrify\bundling\bundle exist
An explanation ?
It's a great job ! Thanks ;-)

I resolved my problem by creating a project on disk C:
^^

Oh fine, it was something with file permissions.
Glad you've fixed. :)

Had the same problem...moved my entire project to C drive and it worked


Change antctl traceflow command to output results at timeout/failure

Output the Traceflow results, as long as there are any results returned,
so users can know the progress of the Traceflow session even the antctl
command is timeout, or the Traceflow operation fails.
Example output:
$antctl traceflow -S kube-system/coredns-74ff55c5b-6sz9g -D <IP_ADDRESS>
name: kube-system-coredns-74ff55c5b-6sz9g-to-<IP_ADDRESS>-2rx5fdlg
phase: Running
source: kube-system/coredns-74ff55c5b-6sz9g
destination: <IP_ADDRESS>
results:
- node: k8s1
  timestamp:<PHONE_NUMBER>
  observations:
  - component: SpoofGuard
    action: Forwarded
  - component: Forwarding
    componentInfo: Output
    action: Forwarded

Error: timeout waiting for Traceflow done

/test-all

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f93242a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage        ?   33.64%
=======================================
  Files           ?      199
  Lines           ?    17227
  Branches        ?        0
=======================================
  Hits            ?     5796
  Misses          ?    10573
  Partials        ?      858

Flag
Coverage Δ

kind-e2e-tests
33.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Linting fixes & wallaby.js cfg

Pull Request Test Coverage Report for Build 152

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 44.583%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

index.js
0
9
0.0%

Totals

Change from base Build 151:
0.08%

Covered Lines:
217

Relevant Lines:
459

💛  - Coveralls


Adding conditions and server id to gin endpoint tracing

What does this PR do
Add additional information (server id and condition state/kind) to jaeger traces

Only question I have about this is if we are happy with my naming convention. "conditionKind" for example, should it be camelCase? Or snake_case? Or flatcase?

yeah... for now lets leave it as is, since thats the convention followed in all other components. We can take up switching to snake_case separately - when we see its a pain to query


Selecting Token After Clicking Text-Box Under Dimension Causes Unexpected Behavior

Describe the bug
When clicking inside the text-box under the dimension section and then selecting a token from the dropdown menu, an unexpected behavior occurs. However, the functionality works as expected when the dropdown is selected directly or the reference is entered manually.
To Reproduce
Steps to reproduce the behavior:

Click inside the text box under the dimension section.
Select a token from the dropdown menu.
Observe the unexpected behavior.
Alternatively, directly select a token from the dropdown or manually enter the reference, and observe that the functionality works as expected.

Expected behavior
The functionality should work as expected when a token is selected from the dropdown, regardless of whether the text-box was clicked first. There should be no difference in behavior.
Screenshots or Screencasts
https://github.com/user-attachments/assets/f9393d43-5c17-4203-a1ae-93c2643d742e

@NuthanHyma when you test this one and replicate, can you please also test across all other token types?

This issue only occurs with Dimension token, and it's still reproducible in V 2.2.2


MINOR: update rocksDb memory management doc

In the RocksDb memory management doc, we mentioned in the footnote that there's a rocksdb bug caused the strict_capacity_limit boolean parameter in the LRUCache constructor can't be set to true. However, the bug is already fixed in 6.11.4 (see here), and we're using 6.22 now, so the note can be removed.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cadonna , please help review. Thank you.

Test failures are not relevant since the PR does only change docs.


安装失败

Please complete the following informations.

Expected behavior and actual behavior.
Steps to reproduce the problem.
Android or iOS? OS version? Brand?
More informations such as error messages and stack traces are welcomed.

Pod install 只能安装1.1.5的版本
请补充如下信息。

问题重现的步骤。
fork 后，直接pod install
iOS
其他的错误信息和堆栈信息如果有也可以一并提供出来。

Installing DoraemonKit (1.1.5)
errorInfo：
[!] CocoaPods could not find compatible versions for pod "DoraemonKit":
In Podfile:
DoraemonKit (= 1.1.7)
None of your spec sources contain a spec satisfying the dependency: DoraemonKit (= 1.1.7).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

更新本地仓库 pod install --repo-update

已解决，多谢，是pod版本的问题，更新后就可以了，我用的是pod update --verbose


Domain Join as computer account

Allow containers to be domain joined even if the host is not or even joined to a different domain.
Containers are meant to be a stripped down userland that contains everything the application needs to run without interacting with "the world outside the container".
Therefore the current approach of integrating containers into a domain by using service accounts is not great.
If I'm maintaining e.g. a web app that has ldap auth, the container should be able to perform this without requiring anything from the host, so that the container can be moved to another host without needing preparation.
Also I consider the secret that is used to connect to the AD "state" of the container and therefore the container should be able to store it on a volume itself controls. There is just no need for the host to treat these kind of information special.
Also as a service provider I want to be able to have the hosts within my activedirectoy, so that my admins and my automation can log into it, but also to offer the applications to customers. Now if the application is an domain integrated one it would (currently) require the host to be joint to the customer domain and an gMSA to be configured. I'd like it to be split. The container should be able to be joined to the customer domain (appear with a normal computer account) and be treated indistinguishable from normal computers but with stripped down services and functionality.
Such a setup would allow to make a service cut between providing the application and managing the host server. The service provider could than have the application running within a k8s cluster and providing automated fault tolerance and uptime monitoring while requiring no change to the containerized application (even applications not compatible with gMSA will work).

This issue is being evaluated as we plan for updates on gMSA. Given the nature of the Windows containers composition, we don't plan to provide support for domain-join. We do however want to solve for this: Allow containers to be domain joined even if the host is not.
Assigning the appropriate people and providing the right tags.

This issue is being evaluated as we plan for updates on gMSA. Given the nature of the Windows containers composition, we don't plan to provide support for domain-join. We do however want to solve for this: Allow containers to be domain joined even if the host is not.
Assigning the appropriate people and providing the right tags.

@mapalko Can you comment here on the plans for gMSA and if this would be accommodated?

We recently released a blog post with some new information on gMSA updates. Please check: https://techcommunity.microsoft.com/t5/containers/what-s-new-for-windows-containers-on-windows-server-2022/ba-p/2167036
As part of the update, we will support gMSA on non-domain joined container hosts. I believe this satisfies the requirements from this issue. We'll close the issue for now.


Add standalone contract public functions description

#[external(v0)]
fn my_function(ref self: ContractState){}

Public functions are not necessarily under impls blocks.

On hold until component release


Can't update rollup config

Current Behavior

I created a react + storybook project.
npm i rollup-plugin-react-svg --save-dev
I created tsdx.config.js in the root directory with the following contents:

const reactSvg = require('rollup-plugin-react-svg');

module.exports = {
  rollup(config, options) {
    config.plugins.push(
      reactSvg({
        // svgo options
        svgo: {
          plugins: [], // passed to svgo
          multipass: true
        },

        // whether to output jsx
        jsx: false,

        // include: string
        include: null,

        // exclude: string
        exclude: null
      })
    );
    return config;
  },
};

npm run test
And nothing is changed. SVG still not working. It looks like rollup() function is not called. I tried to add broken code to rollup() function and there is no errors in console.

Expected behavior
I need to add rollup plugin
Your environment

Software
Version(s)

TSDX
^0.13.2

TypeScript
^3.8.3

Browser
Chrome

npm/Yarn
npm 6.12.0

Node
12.13.0

Operating System
Win 10

tsdx test doesn't run tsdx build and therefore doesn't run Rollup. tsdx test runs Jest.
tsdx.config.js most certainly works, there are even integration tests for it.
@ildar-icoosoft you've made two issues that duplicate existing ones and now this in short succession. There are also plenty of working references to tsdx.config.js, including the HOWTOs.
That's not a good pattern I'm seeing from you so I feel like I have to very explicitly say this: Please recognize that issues aren't a support forum (including TSDX's issues) and most open-source maintainers are unpaid volunteers (including me), so please make sure to thoroughly check things on your side before reporting issues to open-source libraries. That means trying different options and searching the issues and not resorting to reporting a new thing until you've done so.


Reconsider license generation

Is your feature request related to a problem? Please describe.
Reconsider license generation

Clutters commits
Huge diffs
Generally annoying to work with and kills your merges and constantly is touched by prettier or something linting it for indentation I think?? Nobody wants to think about this when working

Describe the solution you'd like
Don't generate on postinstall. Something generated on a release or something post commit. Is this really needed?
Checklist:

[x] I have double checked that the issue does not currently exist.
[x] I have added the appropriate labels (e.g. feature, front-end, back-end).
[x] I have added the Platform Project project

Also it means that our builds have even less determinism and that there's going to be a diff everytime someone builds


YARN-3660. BackPort [GPG] Federation Global Policy Generator (service hook only).

Description of PR
YARN-3660. [GPG] Federation Global Policy Generator.
This JIRA has been merged into the YARN-7402 branch. This PR created the Global Policy Generator Moudle
In a federated environment, local impairments of one sub-cluster might unfairly affect users/queues that are mapped to that sub-cluster. A centralized component (GPG) runs out-of-band and edits the policies governing how users/queues are allocated to sub-clusters. This allows us to enforce global invariants (by dynamically updating locally-enforced invariants).
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
21m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 48s

trunk passed

+1 :green_heart:
compile
15m 45s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
15m  8s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
3m 44s

trunk passed

+1 :green_heart:
mvnsite
8m 57s

trunk passed

+1 :green_heart:
javadoc
9m  3s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 45s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 20s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
30m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 11s
/patch-mvninstall-hadoop-yarn-project.txt
hadoop-yarn-project in the patch failed.

-1 :x:
mvninstall
0m 11s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn in the patch failed.

-1 :x:
mvninstall
0m 13s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-server in the patch failed.

-1 :x:
mvninstall
0m  9s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed.

-1 :x:
compile
0m 13s
/patch-compile-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javac
0m 13s
/patch-compile-root-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
root in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
compile
0m 13s
/patch-compile-root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
root in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javac
0m 13s
/patch-compile-root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
root in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 10s
/buildtool-patch-checkstyle-root.txt
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 11s
/patch-mvnsite-hadoop-yarn-project.txt
hadoop-yarn-project in the patch failed.

-1 :x:
mvnsite
0m 12s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn in the patch failed.

-1 :x:
mvnsite
0m 12s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-server in the patch failed.

-1 :x:
mvnsite
0m 11s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed.

+1 :green_heart:
shellcheck
0m 24s

No new issues.

-1 :x:
javadoc
0m 13s
/patch-javadoc-hadoop-yarn-project-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-project in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 13s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 10s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

-1 :x:
javadoc
0m 11s
/patch-javadoc-hadoop-yarn-project-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-project in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javadoc
0m 11s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javadoc
0m 12s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

-1 :x:
javadoc
0m 11s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.

+0 :ok:
spotbugs
0m 14s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
0m 13s
/patch-spotbugs-hadoop-yarn-project.txt
hadoop-yarn-project in the patch failed.

-1 :x:
spotbugs
0m 12s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn in the patch failed.

-1 :x:
spotbugs
0m 12s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-server in the patch failed.

-1 :x:
spotbugs
0m 11s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed.

-1 :x:
shadedclient
0m 36s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 12s

hadoop-project in the patch passed.

-1 :x:
unit
0m 13s
/patch-unit-hadoop-yarn-project.txt
hadoop-yarn-project in the patch failed.

-1 :x:
unit
0m 12s
/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn in the patch failed.

-1 :x:
unit
0m 13s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-server in the patch failed.

-1 :x:
unit
0m 10s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-globalpolicygenerator.txt
hadoop-yarn-server-globalpolicygenerator in the patch failed.

+0 :ok:
asflicense
0m 13s

ASF License check generated no output?

165m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5625

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs spotbugs checkstyle

uname
Linux 9eacc3c878bb 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 13a4423e362cb7c4b6cd3c8f63ea8870bb304120

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/1/testReport/

Max. process+thread count
614 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
31m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 41s

trunk passed

+1 :green_heart:
compile
16m 35s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
15m  7s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
3m 52s

trunk passed

+1 :green_heart:
mvnsite
8m 25s

trunk passed

+1 :green_heart:
javadoc
9m 15s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 47s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 19s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
30m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 55s

the patch passed

+1 :green_heart:
compile
15m  2s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
15m  2s

the patch passed

+1 :green_heart:
compile
14m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
14m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 33s

the patch passed

+1 :green_heart:
mvnsite
8m 29s

the patch passed

+1 :green_heart:
shellcheck
0m 24s

No new issues.

+1 :green_heart:
javadoc
9m 21s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
8m  6s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 24s

hadoop-project has no data from spotbugs

-1 :x:
spotbugs
10m 15s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn.html
hadoop-yarn-project/hadoop-yarn generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
5m 45s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
9m 55s
/new-spotbugs-hadoop-yarn-project.html
hadoop-yarn-project generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
29m 11s

patch has no errors when building and testing our client artifacts.

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  0s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
19m 42s

trunk passed

+1 :green_heart:
compile
15m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
14m 27s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
3m 44s

trunk passed

+1 :green_heart:
mvnsite
8m 17s

trunk passed

+1 :green_heart:
javadoc
8m 53s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
7m 34s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 24s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
28m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 53s

the patch passed

+1 :green_heart:
compile
15m  2s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
15m  2s

the patch passed

+1 :green_heart:
compile
14m 30s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
14m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 33s

the patch passed

+1 :green_heart:
mvnsite
8m 28s

the patch passed

+1 :green_heart:
shellcheck
0m 24s

No new issues.

+1 :green_heart:
javadoc
9m 23s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
8m 11s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 25s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
29m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 23s

hadoop-project in the patch passed.

-1 :x:
unit
239m 22s
/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn in the patch passed.

-1 :x:
unit
158m 35s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-server in the patch passed.

+1 :green_heart:
unit
1m  4s

hadoop-yarn-server-globalpolicygenerator in the patch passed.

-1 :x:
unit
240m 54s
/patch-unit-hadoop-yarn-project.txt
hadoop-yarn-project in the patch passed.

+1 :green_heart:
asflicense
1m 10s

The patch does not generate ASF License warnings.

901m 12s

Reason
Tests

Failed junit tests
hadoop.yarn.server.timeline.TestEntityGroupFSTimelineStore

hadoop.yarn.server.timeline.TestEntityGroupFSTimelineStore

hadoop.yarn.server.timeline.TestEntityGroupFSTimelineStore

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5625

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs spotbugs checkstyle

uname
Linux c926d2d6bee5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 442e7cdfc41ff4902a71042e40ca7935842f29db

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/5/testReport/

Max. process+thread count
2776 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator hadoop-yarn-project U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5625/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri In the YARN-Federation documentation, it is mentioned that there is a Global Policy Generator component and its code exists in the YARN-7402 branch. Therefore, we need to backport the code from the YARN-7402  branch to the trunk branch.
I try to backport YARN-3660 from the YARN-7402 branch to the trunk branch. During the backport process, I mostly kept the original code and fixed issues flagged by Spotbugs.
I have compiled a list of Jira issues that need to be backported in the future.  I will submit 5-6 pull requests to backport this code to the trunk branch.
The list is as follows.  (These prs have already been merged into the YARN-7402 branch.)

YARN-3360 [GPG] Federation Global Policy Generator (service hook only)
YARN-6648 [GPG] Add SubClusterCleaner in Global Policy Generator
YARN-7599 [GPG] ApplicationCleaner in Global Policy Generator
YARN-7707 [GPG] Policy generator framework
YARN-7708 [GPG] Load based policy generator
YARN-8334 [GPG] Fix potential connection leak in GPGUtils
YARN-8534 [GPG] Add max heap config option for Federation GPG
YARN-8637 [GPG] Add FederationStateStore getAppInfo API for GlobalPolicyGenerator
YARN-8862 [GPG] Add Yarn Registry cleanup in ApplicationCleaner
YARN-8934 [GPG] Add JvmMetricsInfo and pause monitor
YARN-9013 [GPG] fix order of steps cleaning Registry entries in ApplicationCleaner

Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up the backport of other PRs.
The issue with the unit tests is not caused by our pr.

@goiri Can you help review this pr? Thank you very much!

The PR itself looks good.
How are we going to manage the rebase of the other branch after merging this?

The PR itself looks good. How are we going to manage the rebase of the other branch after merging this?

@goiri Thank you very much for reviewing the code! The YARN-7402 branch hasn't been updated for a long time. We could merge the YARN-7402 code into the trunk branch first to ensure it meets development requirements. After that, we can cherry-pick these changes from the trunk branch to other branches (mainly branch-3.3 and branch-3.2). Can we proceed with this plan?

Let's go with trunk then.

@goiri Thank you very much for your help in reviewing the code!


Log EKF output from initialization

The estimated states are not logged until EKF2 declares tilt_align = true. This is suboptimal since it makes it hard to discover issues with the EKF initialization such as https://github.com/PX4/ecl/pull/586

We'd need to make sure they're properly marked as invalid.

Still an issue

You should be seeing estimator_status from the beginning (which has the states). Are you talking about also wanting to see vehicle_attitude and vehicle_local_position?

yeah I was thinking about the output from the output predictor data before tilt align. But it is a very specific thing and I guess is not relevant enough to keep this open for now


add dataset disposal of b-mc2/sql-create-context for codegen

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@regisss could you help review the PR, also model save is fixed, the state_dict needs "to('cpu')" before being saved, so I use save_model api instead.

Does it save the whole model or just the adapter weights?

only adapter weights is saved

@mandy-li mandy, could you help review the PR? this PR also fix same issue in model save for deepspeed zero3

@regisss could you help merge it?


Minor: use venv in benchmark compare

Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/10022
(Note: this PR follows up on https://github.com/apache/datafusion/pull/10070 which worked on the same issue but looks like got kinda stale)
Rationale for this change
Make it more convenient to run bench.sh compare
What changes are included in this PR?
Updates to bench.sh to include a new command venv, and edit the compare command to use the respective venv
Separates requirements.txt in case compare.py would ever need something else
Are these changes tested?
I tested by hand ./bench.sh compare and ./bench.sh venv, in multiple scenarios:

create empty venv with bench.sh, then run compare
have existing venv, update with bench.sh venv, then run compare
have no venv but install rich into system, and just run compare
In all cases compare works correctly.

Are there any user-facing changes?
No -- if the compare worked for the user before, it will still do, regardless of whether they used venv or not.
If it didn't work, then the user would see improved error message, run ./bench.sh venv without a need to configure any env var, and the new venv would be created in a gitignored folder in the repo

I merged up to get a clean CI run


linux travis builds failing

This line eg should print detected electron versions: https://travis-ci.org/datproject/dat-desktop/jobs/205778457#L210

better: deactivate for now until this is fixed

inside the travis vm, this actually happens:
travis@6d4756e39f9c:~/dat-desktop$ ./node_modules/.bin/electron --version
travis@6d4756e39f9c:~/dat-desktop$

fixed by https://github.com/datproject/dat-desktop/pull/303, linux builds are back!

woot!

can we close this then?

yuss!