Exception when creating a default client AddTwilioClient

This is running under .net 6 (google cloud run). I'm getting numerous instances of this exception (see below). I think what's happening here is you have a function ChangeEmptyStringToNull which modifies the IConfigurationSection. It's called recursively to convert any empty strings to nulls. I assume this is because somewhere you check for null rather than IsNullOrEmpty in your configuration.  That code can be found here:
https://github.com/twilio-labs/twilio-aspnet/blob/93423276a3e05ea031c559eaba10d3adbbc24c96/src/Twilio.AspNet.Core/TwilioClientDependencyInjectionExtensions.cs
I think the better approach here would be to either in the Validate() function check for empty strings or just allow for them elsewhere (not sure where) and do IsStringEmptyOrNull checks instead of if (s==null). Perhaps in TwilioRestClient CreateTwilioClient(IServiceProvider provider)
System.InvalidOperationException: Operations that change non-concurrent collections must have exclusive access. A concurrent update was performed on this collection and corrupted its state. The collection's state is no longer correct.            at System.Collections.Generic.Dictionary2.FindValue(TKey key)
at System.Collections.Generic.Dictionary2.TryGetValue(TKey key, TValue& value)            at Microsoft.Extensions.Configuration.ConfigurationRoot.GetConfiguration(IList1 providers, String key)
at Microsoft.Extensions.Configuration.ChainedConfigurationProvider.TryGet(String key, String& value)
at Microsoft.Extensions.Configuration.ConfigurationRoot.GetConfiguration(IList1 providers, String key)            at Twilio.AspNet.Core.TwilioClientDependencyInjectionExtensions.ChangeEmptyStringToNull(IConfigurationSection configSection)            at Twilio.AspNet.Core.TwilioClientDependencyInjectionExtensions.ChangeEmptyStringToNull(IConfigurationSection configSection)            at Twilio.AspNet.Core.TwilioClientDependencyInjectionExtensions.<>c.<ConfigureDefaultOptions>b__6_0(TwilioClientOptions opts, IConfiguration config)           at Microsoft.Extensions.Options.OptionsFactory1.Create(String name)
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)            at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy1.CreateValue()            at Microsoft.Extensions.Options.OptionsManager1.Get(String name)
at Twilio.AspNet.Core.TwilioClientDependencyInjectionExtensions.CreateTwilioClient(IServiceProvider provider)`

One more comment... I think your service is Scoped rather than Singleton? Maybe it's a concurrency issue when there are several calls to the concurrent twilio API?

@Swimburger Thanks for looking at this. One alterative which might be easier to write is instead of calling  ChangeEmptyStringToNull before calling section.Bind(opts). Instead create a new function called CleanOptions(TwilioClientOptions opts) called after section.Bind(opts) and replace any empty strings with nulls. That way you aren't mutating the IConfiguration which is I think where the problem under a concurrent access.
If I have some time I'll take a shot at the PR.

@keltex That's what it used to do before I used Bind 🥹
Sounds good!

I released the fix with as a pre-release 8.0.1-rc, can you verify it fixes your problem?

8.0.1 released, closing this issue.


Ability to add pictures/images/photos of racks/devices

Add the ability to upload pictures and link this to racks and devices to assist during remote sessions. Racktables has this and it helps a lot during the daily operating duty

More generally, it would be practical to be able to attach any type of file to any object.
Some may need to link pdf contract (or bills) to device or somewhere else

yes, sounds good.
currently we use wiki for this.

I like the idea of being able to upload pictures of the racks.  However for other pieces like contracts/docs etc it would be nice to just be able to attach a URL/UNC that points to the location of the documents.

a vote from me on this.
Being able to upload images of whole racks to Rack object, builds to location objects and device images to specific devices would be very helpful.  Device Templates could also hold a generic image of that type of device.

I would also cast my vote for device images, it would help visibility a lot compared to just the colored boxes in the rack view. Given our day to day operations i would suggest the following
three to be added to a device/device type:

Front view of the device (also used in the rack view)
Rear view of the device (also used in the rack view)
Port Description, technical drawing with detailed port descriptions (maybe shown on mouse over or a details page)

In our current solution we have the first two but missing the last which
often leads to cables ending up in the wrong physical port (no matter how detailed you
describe ge-0/0/0 on the device .. there is always room for interpretation)

@martink2, curious, are the images of your actual devices, or stock images? Just wondering if they accurately represent installed modules and options. If the former, it seems like it would be a pain to collect images the correct size and quality needed to plug into the rack views.

Usually it's stock images, we rarely have to photograph something. Having the modules in would be  a definite bonus but i would gladly settle for devices only.

I don't know the feasibility of this, but most vendors have a decent set of visio stencils, and I wonder if there would/could be a way too import a stencil file, which would generally be an entire product line/category, and skim the image from that stencil?
That may be too lofty or too hard to implement, so starting with a per device field for picture data for front/rear images would be nice. The technical drawing would be really nice on servers. i.e., multiple NICs on add-in cards that aren't necessarily ge0/1, ge0/2, etc.

stencil support (or something similar) would be awesome, especially if the interfaces were usable as interactive objects

@jeremystretch Do you have ideas on how you'd like to see this implemented if someone were to begin work on code to contribute this feature?

@zevlag I was just pondering this yesterday, trying to determine how best to store the media files. Saving them to disk will require some additional configuration on the web server side and particular attention to filesystem permissions. This shouldn't be too complicated but will extend data outside of the database, so users will need to modify their backup and replication schemes to account for this.
Alternatively, we could store the files directly in the database. This isn't something I'd normally consider, but NetBox is typically a very low-traffic application, so I'm not too worried about the performance hit. Though it does, of course, greatly increase the size of the database. I'm open to suggestions.

I'd prefer it be in the database - ultimately the images are going to take up disk space somewhere and a simple backup procedure is nice. Also plus one for this feature.

Security is another consideration: We want to ensure that photos and other potentially sensitive media are not inadvertently exposed directly through the web frontend without the request being authenticated. This can be accomplished with either approach, but database storage removes the possibility of leakage due to web server misconfiguration.

I'm for the DB solution too.

There are some projects (such as Request Tracker) which had stored assets in the database, but run into scaling issues. If possible then an abstraction layer would be preferably. This could allow storing in a DB, S3, files, whatever.
And if files are used, then you probably don't want them stored under the doc root for the web server. ;)

I have to agree with @puck, we did blob store inside a Postgres once and
it became a mess pretty quickly. I would suggest to have the db store a
url reference to the file. For convenience an upload / download / browse
function for locally stored images in a directory would be very much appreciated.


Publisher fails when broker returns 201 response

In v4.4.3 the Publisher will fail if the Pact broker returns a 201 response.
See publisher.js:132 - the response is being explicitly checked for a 200 even though the broker can return a 201 CREATED response.

Nice pickup, will sort this one out asap.

good catch :)
On Wed, Jun 29, 2016 at 4:54 PM James Navin<EMAIL_ADDRESS>wrote:

In v4.4.3 the Publisher will fail if the Pact broker returns a 201
response.
See publisher.js:132 - the response is being explicitly checked for a 200
even though the broker can return a 201 CREATED response.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pact-foundation/pact-node/issues/16, or mute the
thread
https://github.com/notifications/unsubscribe/AAjA5Fw5P_6wH8Y5W4Qx7-W7O8Lss8eEks5qQhakgaJpZM4JA01h
.

Just awaiting Travis CI build to publish: https://travis-ci.org/pact-foundation/pact-node/builds/141193258. OSX builds are broken today which appear to be slowing down all builds.

Awesome. Cheers!

Build still struggling on at least one OSX agent - but it has published to NPM and should be sorted now. Thanks for raising!


The Shard, London

text: All cost-affecting cards operate no matter how the card is played ("as normal" or otherwise). All multiplication and division is handled first, followed by addition and subtraction. [LSJ 20070707]
link: https://groups.google.com/g/rec.games.trading-cards.jyhad/c/vSOt2c1uRzQ/m/LzAyEsp_1hkJ

Already listed, last ruling


Profiler hangs

Tested versions
V4.2.1 stable b09f793f5
System information
Godot v4.2.1.stable - Ubuntu 23.04 23.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (nvidia; 535.146.02) - AMD Ryzen 5 2600X Six-Core Processor (12 Threads)
Issue description
When profiling particularly slow code, the profiler hangs, the graph shrinks as to indicate a huge peak but fails to show said huge peak.

The game instance continues to run albeit at very reduced frame-rate, inputs are not handled. Including window buttons.
I would expect that profiling would work normally, a gigantic 6000ms or so peak appearing and game execution continuing as normal.
Steps to reproduce
Have a large project with a large convoluted procedural level generator written in GDscript.
Attempt to profile it
Minimal reproduction project (MRP)
N/A

The profiler received a crucial bugfix in 4.3, could you test if this bug still exists in that the latest dev version?

A convoluted procedural level generator is pretty much the opposite of a MRP, so I can't include that, no.
I will try the latest development version and report back, thanks.

I'm able to reproduce this issue with a build from master at 06d51891678e3abf360d6fcd2e8bd1ba96704fcc
The platformer demo suffices.
The steps to reproduce are:

Run the project and start the profiler.
Click on the profiler graph to inspect a certain data point.
The running project should hang in some way -- user input should no longer work.

This is more or less it, yes. I thought it was due to the size of the project, but evidently not.


Add doc.go for v1alpha1 API version

What this PR does / why we need it:
The doc.go file is required for generating API reference docs using the tool https://github.com/ahmetb/gen-crd-api-reference-docs in website repository. This PR is required by kserve/website#291 which adds the api docs generation script for v1alpha1.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

/lgtm
/approve


Error in the styles code

I want to debug the error

hey @aditiverma-21 kindly CLOSE one of your previous issues and then make a new one .

Okay thank you


Javascript error at the staticRules method while validating form in IE

I have encountered a JavaScript error because this very line: var validator = $.data(element.form, 'validator');  in the staticRules method. Somehow it sometimes returns null, thereby resulting in error when executing the next line. This problem only occurs in IE, including IE 6,7,8. I am using jquery validation 1.9 with jquery 1.7.1

@prgwiz Thanks for the tip. This actually didn't work for me for some reason, so I used this variation instead:
staticRules: function( element ) {
    var rules = {};
    var validator = $.data(element.form, "validator");
    if ( validator && validator.settings.rules ) {
      rules = $.validator.normalizeRule(validator.settings.rules[element.name]) || {};
    }
    return rules;
},

If anyone can tell me why validator is sometimes null despite having element.form, that will be great.

@afilina could you provide a simplified jsfiddle which demonstrates a situation in which it doesnt work?

@staabm Well someone is deleting my comments, so no, I won't spend hours putting up a jsfiddle. I'll just hack the core myself and use it in my legacy projects.

Well someone is deleting my comments

hmm? I can believe that someone intentionally deletes comments in this tracker..

I'll just hack the core myself and use it in my legacy projects.

feel free to PR your changes, so we have can discuss something.

staticRules: function( element ) {
var rules = {};
	if (!element.form)
	{ validator = $(element).parents('form').data('validator');
	}
	else
	{ validator = $.data( element.form, "validator" );
	}

	if ( validator.settings.rules ) {
		rules = $.validator.normalizeRule( validator.settings.rules[ element.name ] ) || {};
	}

	return rules;
},

I updated my post to include more background on my changes.


Correcting the intent in interactive learning mode may alter the entities

Rasa Core version: 0.13.2
Python version: 3.6.8
Operating system: windows
When one corrects the intent in the interactive learning mode, but leaves the entities untouched they get altered.
Look at this example:
Is the NLU classification for '[Am Mittwoch](time:2019-02-20T00:00:00.000+01:00)' with intent 'choose_appointment'
The date was recognized by duckling. Without altering the intent the entity would get saved as following in the tracker:
"entities": [
            {
              "start": 0,
              "end": 11,
              "text": "Am Mittwoch",
              "value": "2019-02-20T00:00:00.000+01:00",
              "confidence": 1,
              "additional_info": {
                "values": [
                  {
                    "value": "2019-02-20T00:00:00.000+01:00",
                    "grain": "day",
                    "type": "value"
                  },
                  {
                    "value": "2019-02-27T00:00:00.000+01:00",
                    "grain": "day",
                    "type": "value"
                  },
                  {
                    "value": "2019-03-06T00:00:00.000+01:00",
                    "grain": "day",
                    "type": "value"
                  }
                ],
                "value": "2019-02-20T00:00:00.000+01:00",
                "grain": "day",
                "type": "value"
              },
              "entity": "time",
              "extractor": "ner_duckling_http"
            }
          ],

After altering the recognized intent, but leaving the entity untouched, it gets reduced to:
"entities": [
              {
                "end": 11,
                "entity": "time",
                "start": 0,
                "value": "2019-02-20T00:00:00.000+01:00"
              }
            ],

Thanks for raising this issue, @wochinge  will get back to you about it soon.

@mauricedoepke You are right. However the additional fields are not considered by Rasa Core anyway, so that isn't a problem. Do you need these fields in the custom actions?

Yes I do.
I don't think it is a problem that needs to be immediately addressed as it only occurs in this special case. But it would be nice to have this fixed in some future version of the interactive learning mode.
Until then a note in the docs about that would be nice.

@mauricedoepke Labeled it is a bug and we will fix it as soon as possible. Of course, you are also very welcome to tackle the issue yourself 🤖

@mauricedoepke and @wochinge would the issue be solved if each entity includes a value for which extractor originally detected it or do you need the complete additional information that comes with duckling for example?

@paulaWesselmann So the steps would be

Include the extractor field in each entity at NLU
Check in interactive mode which extractor was used for the component and only export the ner_crf ones

Yes and
3. when correcting entities only overwrite annotation if it's changed.

@paulaWesselmann In my project, I also need all the additional values to be saved into the tracker store.


Exchange balance UI

Describe your changes
Exchange balance UI
Link the related issue
Closes #2692
Checklist before requesting a review

[x] Is this PR ready for merge? (Please convert to a draft PR otherwise)
[x] I have performed a self-review of my code.
[x] Did I request feedback from a team member prior to merge?
[x] Does my code following the style guide at docs/CODING-STYLE.md?

reviewed and approved


Make passwordlist check case insensitive

Make the password list and user provided password both lowercase, so bad passwords are always identified regardless of how many characters are capitalised

@unicodeveloper please can this be merged


Authentication failing on subsequent runs

All my scripts work but only the first time. After the first run I get "Could not authenticate you", code 32.

I'm unable to reproduce this.
Are you invalidating your access token?
Can you show how you're authenticating and as much of your code as possible?


[Work in progress] Marshmallow 3 port

I've initiated a Marshmallow 3 port. Feedback welcome.
I'm not sure how to let tox/Travis test on both Marshmallow versions.
Regarding test_error_handler_is_called_regardless_of_schema_strict_setting, see https://github.com/sloria/webargs/issues/187.

I agree--supporting both marshmallow 2 and 3 would be preferable, and it looks like doing so won't add too much complexity to the codebase.
Once you have this is in a working state, I can create a marshmallow-3 branch from it.

OK, great.
The failing test is linked to https://github.com/sloria/webargs/issues/187. I'm not sure what to do about it.
Apart from this, if you think this implementation is fine, then I shall

remove that print statement I forgot
squash
rebase

@lafrech Implementation looks good to me.
I've removed that pesky test. Will you take care of updating .travis.yml to test against both marshmallow 2 and 3?

Erm, nvm; we already test against marshmallow 3 pre-releases. I've added
matrix:
  allow_failures:
    - env: MARSHMALLOW_VERSION=""

...so that marshmallow releases won't break webargs builds in the meantime. I suppose you can remove that in this PR.

Great.
One more detail. I just noticed this in the tests:
MARSHMALLOW_VERSION_INFO = tuple(
    [int(part) for part in marshmallow.__version__.split('.') if part.isdigit()]
)

Do you think I should use something like this in the code rather than
    MARSHMALLOW_2 = ma.__version__.startswith('2')

?
I've been searching for good ways of determining if the version is 2 or 3 from a semver string but I didn't find anything obvious and I thought it would be a shame to add a dedicated lib just to do that. So I settled with that simple startswith which should work in all cases.
I could move
MARSHMALLOW_VERSION_INFO = tuple(
    [int(part) for part in marshmallow.__version__.split('.') if part.isdigit()]
)

to the lib code (rather than the tests) and use MARSHMALLOW_VERSION_INFO[0] to know the version.

Yeah, I think it makes sense to move MARSHMALLOW_VERSION_INFO to the lib code and use that everywhere.

Alright. I just pushed marshmallow-3 branch.

Went ahead and merged marshmallow-3 into dev. Since it's backwards-compatible, this can go into the 1.10.0 release.

OK.
Should we reallow failures for MA3 until v3 stable ships?

@lafrech I think we can keep dev up to date with the latest MA3 release, in which case we shouldn't allow failures.

Yeah, right. It's not like MA3 is moving that fast.


implementing TerraformOutput output for terraform output -json like s…

Prerequisites
Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[x] This pull request adds a feature.
[ ] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.

For more information, see the Contributing Guide.
Description
If we change a Terraform project and the only difference with the previous run is output changes (add, remove or modify a value), this is not considered as a change by terraform plan.
We should modify the plan script to gather the output after the plan. The output is not directly available as of Terraform 0.11.X
The idea is to extract the plan from the plan file (-out) and compare it with either the state file or the output.
This is what this new feature is doing (export the output like terraform output -json) to allow future comparison.
Checklist
Put an x into all boxes that apply:

[x] I have read the Contributing Guidelines.

Tests

[ ] I have added tests to cover my changes.
[ ] All tests pass when I run make test.

Documentation

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Code Style

[x] My code follows the code style of this project.

work done in another branch


Signatures from Emzy for version 4.3.1

Thanks!
Could you also build Electrum-sourceonly-4.3.1.tar.gz?
This is a new distributable, not present in previous releases, see https://github.com/spesmilo/electrum/pull/7594#issuecomment-1218437670.
For the tarball build script, set OMIT_UNCLEAN_FILES=1 to build the sourceonly tarball as opposed to the normal tarball.
So to build both, you would run the script twice, e.g.
$ ELECBUILD_COMMIT=HEAD ELECBUILD_NOCACHE=1 ./build.sh
$ ELECBUILD_COMMIT=HEAD ELECBUILD_NOCACHE=1 OMIT_UNCLEAN_FILES=1 ./build.sh

done.


Implementation of visualisation tools

[x] I'm ready to merge

What's the context for this pull request?
(this is a good place to reference any issues that this PR addresses)

Visualisation tools
References issues #116 #115 and #119 #118

What's new?

I've implemented visualisation tools for the following purposes:

plot_rich_club - for plotting the rich club values per degree along with the random rich club values created from a random network with a preserved degree distribution.

Result was before comments

Result now after comments

plot_network_measures - plotting network measures values along with the random network values values created from a random network

Result

plot_degree_dist - plotting the degree distribution along with the degree distribution of an Erdos Renyi random graph

Result was before comments

Result now after comments (no gap)

Kirstie's code was really helpful but mostly I've designed these functions by myself, so there are might be some features(changes) you would like to have and on the contrary not to have.
Basically, I tried to follow the Kirstie's code (like to have the same parameters to the functions), but the main implementation was either hard to reproduce or had errors while running. That's why I relied on my intuition and created functions from my perspective.
Feel free to point out me any wrong decisions I took while implementing visualization tools.
I have also tried to have the same outputs illustrated in issue #1.
The way how to use created functionalities I showed in the visualisations_tutorial.

What should a reviewer feedback on?

The design of the functions and the produced figures

Does anything need to be updated after merge?
(e.g the wiki or the WhitakerLab website)

Documentation is updated to include a new module - visualisations.py

This is SO COOL @wingedRuslan! Way to go!
I'll add some comments now 😸

Hey @wingedRuslan! I've had a great evening playing with your tutorial!! Super fun 💖
I've had a big edit of the tutorial - see https://github.com/wingedRuslan/scona/pull/2 for the changes.
There are only small changes in the other parts of the code.
The plot_network_measures code works (beautifully) but I find it really hard to read. Can you have a go at adding a bunch more documentation to it? I think I would create another function that builds the pandas data frames. That's the part that I'm really not following well when I read the code.

Thanks for the review @KirstieJane!
Do you mean to make docstring more detailed and well-explained or/and to make code to be read easily?

The plot_network_measures code works (beautifully) but I find it really hard to read. Can you have a go at adding a bunch more documentation to it?

Nice idea! I will create one in helpers.py

I think I would create another function that builds the pandas data frames.

Yeah, I agree about creating another tutorial for brain network visualisation and I will do that. I really wanted to make one today, but unexpectedly spent a lot of time on colormaps, sooorry :(

I’m not super sure why the function needs to be in helpers.py - I’m talking about building the specific data frame for plotting the nodal measures..... I think I’d keep it in visualisations.py because that’s the only place it will be called?? Happy to be convinced otherwise though.
On the documentation front, I mean both: more info in the doc string about what is happening with the function AND making the code more readable 😬
No problem on the timings!! You’ve done tonnes of great work here!

OH - and one last thing. Make sure to run the code through flake8 linting is you can. We have quite a lot of long lines at the moment ✏

Yes, right! it makes sense :)

I think I’d keep it in visualisations.py because that’s the only place it will be called??

My motivation to add a newly created function ( that builds the specific data frame for plotting the global measures) to the helpers.py because it will make files, modules (and work?) more organized.
I mean that in visualisations.py we have only functions to make plots and nothing else, in helpers.py -  any other functions needed for plotting ("helpers" functions that help to make plots and not only plots). But you are right, this function that builds a specific dataframe for plotting global measures will be used only once, so including in the same file as the plotting function might be better.
Speaking about more readable code, what makes my code bad in terms of readability? Do I use any bad practices? (I will ping @Islast as well)
Appreciate your feedback, as it is really important and will allow me to improve the quality of the code.

I don’t think you use any bad practices at all!! I think a lot of pandas code is really hard to read! There are so many things that pandas can do that it ends up being hard to see what’s going on.
That’s why some documentation that says: here’s the information we have, in this shape, and here’s why we need it to be in a different shape (so seaborne interprets it properly) is probably the solution.
Have a google next week for pandas style guides....I haven’t seen one, and they might not exist, but that’s the only part that’s hard for me to wrap my head around. And it isn’t that your code is bad at all!

Hey @wingedRuslan! This all looks great to me! If you can merge https://github.com/wingedRuslan/scona/pull/6 then I'm totally fine for you to merge!
@Islast - you requested changes and I think they're all addressed. Would you mind taking a look and approving when you have a chance?

@KirstieJane, Thank you a lot!  I would like to merge but as @Islast requested changes, her approval is needed.

Wooooo - click the big green button @wingedRuslan!! MERGE AWAY 🚀:star2:


[BackOffice DS] Removing other error types

Purpose
Related to https://github.com/wso2/apk/issues/1065

Codecov Report
Patch coverage has no change and project coverage change: +23.76 :tada:

Comparison is base (ac0484f) 33.62% compared to head (8173ee1) 57.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1068       +/-   ##
===========================================
+ Coverage   33.62%   57.39%   +23.76%
===========================================
  Files         176       32      -144
  Lines       19985     2408    -17577
  Branches     6172     1318     -4854
===========================================
- Hits         6720     1382     -5338
+ Misses      13145     1026    -12119
+ Partials      120        0      -120

Flag
Coverage Δ

admin-domain-service
52.11% <ø> (?)

backoffice-domain-service
47.20% <ø> (?)

idp-domain-service
79.22% <ø> (ø)

runtime-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 149 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add ATmega32A

SUMMARY

I have added the ATmega32A-PU microcontroller from Microchip. The PR has

a Symbol and a Component called ATmega32A;
a device called ATmega32A-PUPx with the 40 pin DIP package.

OPEN QUESTIONS / UNRESOLVED ISSUES

CHECKLIST

[x] I have read and followed the library conventions.
[x] For packages, I followed IPC7351C (see details in library conventions). No packages were created
[x] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
[x] I agree to publish all my changes under the CC0 Public Domain License, allowing everyone to use and modify the content without any restrictions.

Thanks @ianliu! Generally it looks very good! :smiley:
I have only some small review comments:

The signal RESET should be renamed to nRESET to make clear that it is inverted.
For consistency, the pins at the left of the symbol should be aligned to the top, not somewhere in the middle (i.e. RESET should be at the same Y-coordinate as PA0).
To make schematic design slightly more structured and for consistency with other microcontroller symbols, I'd change the order of the pins on the left of the symbol (from top to bottom): nRESET, VCC, GND, AREF, AVCC, AGND, XTAL1, XTAL2

Ah, and I almost forgot to write that you added a symbol named "Teste", I suspect this is not intended, so it should be removed :wink:

@ubruhin fixed your suggestions! Could you review?
Cheers,
Ian

Looks good, thank you very much @ianliu! :tada:

Looks good, thank you very much @ianliu! :tada:


Add proposal for mixins

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will this imply a new version number? it seems like we introduced a compatibility issue when removing commas without a version bump.
As for the BNF, is this a reasonable approximation?
structure_statement =
    "structure" ws identifier ws [mixins ws] shape_members

mixins =
    "with" ws root_shape_id *(ws comma root_shape_id) trailing_comma

@johnstonskj the removal of commas was never released. It's only in the idl-1.1 branch. This proposal would be built on top of that branch and eventually released with a new IDL version of 1.1. The ABNF is defined in the proposal as:
structure_statement = "structure" ws `identifier` ws [with_clause] shape_members
union_statement = "union" ws `identifier` ws [with_clause] shape_members
with_clause = "with" ws 1*shape_id ws

Awesome, thanks!


Add value as positional parameters to textarea form control.

Hi there,
This PR fixes displaying initial value on the textarea-field - when textarea-field is rendered and model already has some value it's not displayed it. When textarea-field is changed to text-field then the value is displayed correctly - i.e.:
{{#form-for person as |f|}}
  {{f.textarea-field "description"}}

  {{f.submit "Save"}}
{{/form-for}}

I would love to add tests to covers that but I didn't find any existing tests that covers such case. Some guidance here would be helpful :).

:umbrella: The latest upstream changes (presumably #44) made this pull request unmergeable. Please resolve the merge conflicts.

Closing because the one-way-controls merge fixes this.


ENH: Multi-tenant support via database schema  (database schema per tenant)

This probably requires 2 changes:

Add an interface that at runtime per request tells us the schema to use. You supply an implementation to ServerConfig ...

public interface MultiTenantSchema {

  /**
   * Return the DB schema that should be used for this request.  Typically use a
   * ThreadLocal / context to determine the current user and hence their schema.
   */
  String getTenantSchema();

}

Provide 3 implementation options:

Tenant per schema
Tenant per database
Add a tenantId column in all tables

When do you estimate do this? I'm really interest about it.

Not sure. Please ask again in a week, by which time I hopefully will be
close to clearing the elastic search integration.
Cheers, Rob.
On 19 Feb 2016 11:51 p.m., "Ivan Antonio Reffatti"<EMAIL_ADDRESS>wrote:

When do you estimate do this? I'm really interest about it.
—
Reply to this email directly or view it on GitHub
https://github.com/ebean-orm/avaje-ebeanorm/issues/493#issuecomment-186169660
.

+1 oh my! how this feature is so needed

hey rob any chance in the world this is coming soon? :)

Yes'ish.
It is not a sponsored feature so I need to do it in my 20% time. So right now it is competing against some cleanup I want to do and 'performance monitoring'.
The cleanup work is:

Support autotune to writing back to the original autotune file (Just to make it easier to use)
Support easier generation of "Finders" in maven (Probably maven plugin)
Pull out class path scanning internals replacing with 'avaje-class-path-scanner'
This work puts us in a position to support running DB Migration (without FlywayDB for example as there are some things I don't like about how that works).  It also puts us in a position to support migration of ElasticSearch indexes (in a automated fashion like DB migration).

Performance monitoring is important for many reasons. Ebean has collecting the performance metrics for many years but we ideally have a nice way to collect and display those metrics.
It is possible multi-tenant support bumps the performance monitoring enhancements.
If you ask this question again in a weeks time then I might be able to give you a real answer but that said I need to earn brownie points with the wife (been working too hard) so I'm not sure how much cleanup I'll get done (as that is now all after hours work now).
Cheers, Rob.

lol i totally understand (especially the brownie points :smile: , )
and i must say, its amazing to me how with the time constraints you
can singularly churn out bug fixes and add new features  at the rate
you do. It just beats me!.
Ebean is my go to ORM for most things these days and multi tenancy is
a feature i find the need for a lot (hence my continued asking)  and i
believe a good part of the Ebean community share my sentiment so:
"It is possible multi-tenant support bumps the performance monitoring
enhancements"
if it won't be too disruptive to your plans, i hope it does bump it
:smile: (and i totally respect if it can't).
if i understood the internals of Ebean enough i would submit PRs to
help. Anyways thanks again for this boon called Ebean!
On 3/28/16, Rob Bygrave<EMAIL_ADDRESS>wrote:

Yes'ish.
It is not a sponsored feature so I need to do it in my 20% time. So right
now it is competing against some cleanup I want to do and 'performance
monitoring'.
The cleanup work is:

Support autotune to writing back to the original autotune file (Just to
make it easier to use)
Support easier generation of "Finders" in maven (Probably maven plugin)
Pull out class path scanning internals replacing with
'avaje-class-path-scanner'
This work puts us in a position to support running DB Migration (without
FlywayDB for example as there are some things I don't like about how that
works).  It also puts us in a position to support migration of ElasticSearch
indexes (in a automated fashion like DB migration).

Performance monitoring is important for many reasons. Ebean has collecting
the performance metrics for many years but we ideally have a nice way to
collect and display those metrics.
It is possible multi-tenant support bumps the performance monitoring
enhancements.
If you ask this question again in a weeks time then I might be able to give
you a real answer but that said I need to earn brownie points with the wife
(been working too hard) so I'm not sure how much cleanup I'll get done (as
that is now all after hours work now).
Cheers, Rob.

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ebean-orm/avaje-ebeanorm/issues/493#issuecomment-202553979

Hi Rob,
I see this issue/future got the label Sponsor Me. About how much dollars/euros do we talk?
Cheers,
From a Ebean user/lover since 2013

I have a flat rate of USD $500 per feature.  This feature got a willing sponsor just 2 weeks ago so ... I'm not sure.  I've been away and haven't got into this work yet with the plan to kick into Postgis support first in the next couple of days.
Cheers, Rob.

Examples:
https://github.com/ebean-orm-examples/example-multi-tenancy-db
https://github.com/ebean-orm-examples/example-multi-tenancy-schema
https://github.com/ebean-orm-examples/example-multi-tenancy-partition
Yes, I need to work on some documentation for this...


tests: net: conn_mgr_monitor: increase stack size

Fixes (?) the broken conn_mgr_monitor test.
@jukkar @rlubos Not sure whether this is the right way to fix this - the test is however broken on mainline.

Chiming in as requested: LGTM!
The issue, it would seem, was introduced when switching to picolibc:
https://github.com/zephyrproject-rtos/zephyr/pull/57340
It doesn't seem too strange to me that a change to libc could require adjustments to stack sizes.


Fixed multiple scheduler service init

Codecov Report

Merging #184 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   62.33%   62.28%   -0.05%
==========================================
  Files          47       47
  Lines        3828     3829       +1
==========================================
- Hits         2386     2385       -1
- Misses       1052     1053       +1
- Partials      390      391       +1

Impacted Files
Coverage Δ

services/service_provider.go
75% <100%> (+0.45%)
:arrow_up:

workers/scheduler/scheduler.go
64.81% <0%> (-0.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c33fa...df382ca. Read the comment docs.


Shortcut to jump to search bar?

I think it would be nice to be able to use a shortcut to quickly focus on the search bar.
My vote would be on {cmd,ctrl} + l which Firefox, Chrome, and Safari use
Thoughts? Should be pretty straight forward.

closing for #1395 Keyboard shortcuts, https://github.com/lbryio/lbry-desktop/issues/1395


Subcategories for better filtering of Kestrel logs

Add Subcategories for better filtering of Kestrel logs
Check the what's new version first.
Share or link this with Kestrel docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7184a308-a254-9350-a5cd-5bced1f369ae
Version Independent ID: 726e3bf1-f367-d733-8933-bccc04da0e16
Content: Logging in .NET Core and ASP.NET Core
Content Source: aspnetcore/fundamentals/logging/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Associated WorkItem - 60754

Fixed by #23319


Automated cherry pick of #4459: Upgrade Antrea base image to ubuntu:22.04
#4499: Update remaining images to use ubuntu:22.04 base image

Cherry pick of #4459 #4499 on release-1.9.
#4459: Upgrade Antrea base image to ubuntu:22.04
#4499: Update remaining images to use ubuntu:22.04 base image
For details on the cherry pick process, see the cherry pick requests page.

/test-all

/test-all

/test-e2e


About / Board Page UI/UX

I will start designing it starting Wednesday when I'm more available!

Mostly finalized, I just want to make the first part more visually interesting/balanced.


Demo - Make Route53 Zone Optional

Allow not providing Route53 zone info, using default names instead?
Allow the user to set up their own R53 records
Ensure that the fields required for Route53 are the minimum number of fields needed
These examples show using CloudFront and API Gateway without custom domain names on either:

https://aws.amazon.com/premiumsupport/knowledge-center/api-gateway-cloudfront-distribution/
https://advancedweb.hu/how-to-use-api-gateway-with-cloudfront/#:~:text= How to use API Gateway with CloudFront,proxy caching on the CloudFront side. More

Unfortunately, R53 and certificates cannot be made 100% optional while retaining the same functionality as API Gateway will reject requests from CloudFront where the domain name used by CloudFront has not been registered with API Gateway AND the CloudFront name cannot be registered with API Gateway because no certificate can be selected which covers distribution.cloudfront.net.
For the purposes of making it easier to spin up 90% of the stack, the certificates and domains have been made optional with documentation indicating that the edge domain is not truly optional.

Moved S3 changes to #200


Show TAN methods

Hello,
I noticed when I use phpFinTS with my VR bank account I get 4 TAN methods back and show them. For example I not see SecureGo plus which I have. When I choose SecureGo it also works nevertheless.
But when I use the same bank data with my bank software MoneyMoney I see some more - even SecureGo plus. Even TAN methods which I don't have appear there.
Will phpFinTS always show the latest TAN methods that belong to a user? If so, why is SecureGo plus missing then?

had the same question 👍🏻

Will phpFinTS always show the latest TAN methods that belong to a user?

The phpFinTS library shows all the TAN modes that are available to the user according to the server's response. More specifically:

The BPD contains a list of all TAN modes that the bank supports, independent of the user. This should contain the "missing ones" -- you can verify this by doing print_r($fints->getBpd()->allTanModes).
From that list, the library only returns the subset available to the user according to the user data. You can inspect that subset with print_r($fints->allowedTanModes).

If so, why is SecureGo plus missing then?

My guess is that it's not on the allowlist from that second step above. So the new question is: Why does MoneyMoney show it?

It's possible that MoneyMoney just blindly shows all of the TAN modes from the BPD and disregards the user-specific data. (This theory is especially plausible if MoneyMoney prompts you to select the TAN mode before you've provided your username and password to log in.)
It's also possible that the bank server delivers a different set of allowable TAN modes to MoneyMoney (perhaps they recognize its client ID or perhaps MoneyMoney uses an older/newer protocol version that makes the server react differently). If you want to debug deeper into this, you need to log the FinTS traffic with both applications (use $fints->setLogger() for phpFinTS) and search for 3920, which is the serialized identifier of the data element that contains the allowed TAN methods.

Did you figure out the reason here?


Raise a warning for duplicated testcase contract name

Component
Forge
Describe the feature you would like
Currently it seems when there are testcase contracts with the same name, e.g.
contract ContractTest is DSTest { .. }
only one is being run with forge test and others are silently ignored.
Compilation warnings and errors can be seen for all testcase contracts, which adds to the confusion - they just don't run in forge test.
Additional context
No response

i thought we had fixed this? cc @mattsse

i thought we had fixed this? cc @mattsse

deployable_contracts in MultiContractRunner (used to figure out what contracts to deploy) is keyed by id.slug() which is just {contract_name}.json:{contract_name}. I think if we key it by id.versioned_slug() it should work? cc @mattsse again

Ref #392


feat: disable tslint

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Trouble with Login

This seems like a great package, thank you for making it!
Unfortunately on my end I'm having some issues logging in. Getting the error JSONDecodeError: Expecting value: line 1 column 1 (char 0). Any thoughts? I verified my username and pswd are correct, and even changed to a new pswd while I test the connection.

I'm having the same issue:
/usr/local/lib/python3.7/dist-packages/dune_analytics/init.py in authenticate(self, username, password)
17         transport = self.client.transport
18
---> 19         csrf = transport.session.post("https://duneanalytics.com/api/auth/csrf").json()['csrf']
20         r_auth = transport.session.post("https://duneanalytics.com/api/auth", data={
21             "csrf": csrf,
AttributeError: 'NoneType' object has no attribute 'post'


Use case description

This addon is doing something awesome, but I don't understand what exactly.
Can you please update the readme with a use case describing how this addon is useful?

My assumption going into this was that this addon is useful for exactly the set of people who already understand why they need it, which may have been totally off-base 🙂
If I can ask, what brought you here in the first place? Updating the README will be easier if I can understand how people are finding this without knowing they're looking for it.

Your addon has been mentioned in the Ember Weekly newsletter.
I have some experience with ember-cli-deploy, including writing a custom plugin, so I got interested with your efforts. I'm curious what can be achieved with this addon.

Ah! I didn't realize this had actually been picked up somewhere. I've fleshed out the README a little to hopefully be more explicit about what this is for :)

Ah, so it lets you deploy from the CI. :sweat_smile: That's all I needed to hear. :trollface:
Thank you for the readme update.

This was literally the first line in the README even before my update 😛

This is an ember-cli-deploy plugin for managing deployments to a git branch in a CI environment like Travis.

"managing deployments" sounds fancy, I didn't realize it means triggering a deploy. :finnadie:


Add GIF/MP4 generation for layout optimization visualization

Implemented a feature to visualize the layout optimization process as GIF/MP4.
Added GenGIF.py to handle input arguments and invoke visualization functions.
Enhanced layout_parser.py to correctly parse .lg, .opt, and .postlg files with support for merged FFs.
Updated layout_visualizer.py to progressively remove merged FFs and add the newly created MBFFs during visualization.
Introduced a draw_cell function to render layout cells on a Matplotlib axis.
Included generate_animation in layout_visualizer.py to compile visualization frames into a GIF/MP4.
Updated requirements.txt to list dependencies (matplotlib, Pillow, argparse).
Verified feasibility on self-generated small test cases, but functionality on larger test cases like testcase1_16900 is unverified due to longer runtime.

Hi can you add the usage and provide the sample of this program?

Single file of code should cover this, can you make them in one file?

How long will it need to run our public testcase, can you show me the result of the public testcase? I will review your work at night, thanks!

Thank you for your suggestions!

I have merged all Python modules into a single file (GenGIF.py) as requested. This file now includes all functionality, such as parsing input files, generating visualizations, and creating GIF/MP4 outputs.

I have also added usage instructions and provided small-scale test cases (testcase0 and testcase0_c) along with their corresponding input files (.lg, .opt, .postlg). Additionally, I have included the generated GIF outputs (testcase0.gif, testcase0_c.gif) to demonstrate the program's functionality.

Regarding the public test case runtime, it is difficult to estimate accurately at this point. For instance, when running testcase1_16900 on the server, the program has been executing for over an hour without completing. This indicates that there might be room for optimization in the implementation.
Additionally, I suspect that the generated GIF may face challenges in maintaining visual precision due to the large die size and the significant number of cells in this test case. If you have any suggestions or specific areas to focus on for optimization, I'd be happy to look into them.

Please let me know if there's anything else you'd like me to adjust or clarify.

Hi, the runtime and the quality should be one of the concern. However, this should be a good start for others to enhance the implementation. Will review it at night and try to merge it if possible!

I add GenMP4.py
Current Performance Bottleneck: visualize_steps
Function Overview
The visualize_steps function processes layout optimization steps by iteratively updating the current list of cells and generating frames for visualization. This involves:

Removing merged cells.
Adding newly generated cells.
Creating frames for each intermediate state.

Current Implementation Analysis
In the current implementation:

current_cells is stored as a list.
Removing a cell involves searching the list and removing the corresponding element (O(N)).
Adding a new cell is a simple append operation (O(1)).

Time Complexity:

For each optimization step, updating the list involves:

Removing k cells (O(k * N), where k is the number of inputs in the step).
Adding a new cell (O(1)).

With M optimization steps:
O(M * N)
Where N is the number of cells in the layout.

I will try using other data structures, such as a dictionary, later. This should reduce the overall time complexity of visualize_steps from O(M * N) to O(M).

Hi, I will merge these commit, if you have more time, please help enhance the program efficiency.
Also, please generate the readme for the usage.
Thanks

After that, I’ve tried various optimization methods, such as reusing the previous frame and only redrawing the cells that were moved, deleted, or added.
However, the rendering efficiency is still relatively slow.
For larger test cases, rendering a single frame takes approximately 15 seconds, and with the total number of frames being equivalent to the number of .opt file lines +1, the overall performance significantly lags behind other impressive methods shared by others, such as those utilizing OpenGL or web-based visualization.
That said, I will still upload the optimized and bug-fixed version of GenMP4.py via a PR later, along with the final execution results.
Additionally, I might include a README file for better clarity.

Hi,
I think you can focus on gif, the MP4 has been generated with relative high quality and speed!
And I think you can update per frame on 10-20 opt steps. Will that be more efficient?
Thanks
Coherent

The performance difference between the drawing functions is too significant. If I were to improve the GIF generation feature, I would prefer to base it on the code provided by @XCI9

Sure, you can reference his work to enhance the quality of gif!
Thanks


Are the RoomInstance.Doors sorted in order? How to use RoomInstance.Position?

Are the RoomInstance.Doors sorted in some order like clockwise or are they random? I have a corridor, how to check which door is connected to the left or right?
How to use RoomInstance.Position? Should I add it with the position of the GameObject Rooms?

Hey!
The Doors are in no particular order.
Internally, I use the following code to set the position of room templates:
roomTemplateInstance.transform.position = position;

where the position is equal to the RoomInstace.Position.
Do you have any specific goals in mind? I can probably give you some more information if I know what you're trying to achieve.

I had an instance of a corridor that connected to 2 rooms. How to know which RoomInstance.Doors of the corridor are connected to the left and which are connected to the right.

You can use DoorInstance.FacingDirection to do that. If there's a room connected on the left side of the door, its facing direction should be equal to Vector2Int.up. And the same holds for all the other directions.

Wait, I thought it should be Vector2Int.Left.

Yeah, you're right. It seems like I was reading a comment in the documentation which said "Up" and forgot that we're talking about a room facing to the left.


Add xattr support for Solaris/SmartOS

What should restic do differently? Which functionality do you think we should add?
Restic currently does not support xattrs for solaris.
See #1645 for the patch that added initial solaris support.
The xattr API for solaris is documented here: https://illumos.org/man/5/fsattr. See the Using the API section.

We use the xattr library which currently does not support Solaris, see https://github.com/pkg/xattr/issues/15 . Apparently this depends on a not yet resolved golang bug https://github.com/golang/go/issues/24381 .

It looks like Solaris support was added to pkg/xattr since this issue was opened.

@greatroar 13 days ago to be precise :-) . We still have to wait for the next release of the xattr package.

The xattr package has a new release. Anyone up for a PR?

The xattr package has a new release. Anyone up for a PR?

Once #3454 lands, we just have to add Solaris to node_xattr.go  and then we should have xattr support

Hi I would like to help with this issue. Do I just have to add a build tag in node_xattr.go ?


Updated helm for new version

@lohmag  I am away on holiday with very little net access, but we will review this issue next week when I am back. Thank you for the report!

@lohmag I am away on holiday with very little net access, but we will review this PR next week when I am back. Thank you for the submission!

Hey @lohmag,
I appreciate your patience while James and I were out.
Your changes look good to me.


Inconsistency with PROV for wasAssociatedWith use

A tern:Observation may have a property prov:wasAssociatedWith which, according to TERN Shapes, may indicate a sh:IRIOrLiteral but PROV-O does not allow for literal use. From PROV:
:wasAssociatedWith
    ...
    rdfs:domain :Activity ;
    ...
    rdfs:range :Agent ;
    rdfs:subPropertyOf :wasInfluencedBy ;
    owl:propertyChainAxiom (:qualifiedAssociation :agent) ;
    ...
.

So you need to either restrict your Shape or invent a looser property.

@nicholascar we will update the shape constraints


⚡ Improve FastAPI performance by +265% 🚀🚀

These performance improvement tips are from Marcelo Trylesinski, the maintainer of FastAPI. These insights are shared in a LinkedIn post, which you can find here
10 tips for performances improvement :

use uvloop +10%🚀, is a fast, drop-in replacement of the built-in asyncio event loop
use httptools - faster parsing +10%🚀, Python binding for nodejs HTTP parser, you just need to have it installed in your environment
use bigger threadpool +5%🚀
use simple async application, +15%🚀, no overhead of threads
remove duplicate validation, have only FastAPI do the validation +25%🚀
use ORJSON + 5% 🚀(if not using the latest Pydanctic version already)
consider running without validation is an option, 150%, without logging +25%. Both not a general recommendation!
use the most recent version of FastAPI, + 265% 🚀- this is related to pydantic going rust
use ASGI Middleware: see https://lnkd.in/eUW5-bwG
compress responses

Stay tuned for the recording of the conference, which will be released on the EuroPython channel in a few weeks, allowing us to dive deeper into these performance-boosting techniques. Happy optimizing!

According to the uvicorn documentation, the framework installs "Cython-based" dependencies like uvloop and httptools "if possible".
Using uvicorn, should automatically install and utilize the uvloop event loop, same for the HTTP protocol.
While it's safe to assume that using uvicorn would generally address points 1 and 2, let's explore the actual implementation to understand the specific conditions that determine whether these optimizations can be applied, and if there are indeed  used by Ralph.


Update enable-data-sharing.md

Removed Office references, to avoid confusion/overhead - but this change probably requires confirmation with Albert (related to 4843821):
| https://nexusrules.officeapps.live.com | For future functionality  |
| https://nexus.officeapps.live.com | For future functionality  |
| https://office.pipe.aria.microsoft.com | For future functionality  |
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)

@MSFTJerryAb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fix readme telemetry

Fixes bug from #827 where TrackPackageReadMeChangeEvent AI was logged under package push event name.
In addition, wanted to add tests to ensure that each API uses the correct event name. This required some refactoring to replace the static Telemetry class with an interface/wrapper for TelemetryClient.

@joelverhagen Removed all non-EF (schema) helpers from the entities.
Totally onboard with the separation of EF entities from helpers, which could help prevent accidental schema changes as well.  I believe EF schema generation originally used partials for this, but with code first maybe it makes sense for us to create extensions for entities instead?
We already have this problem with existing entities... maybe I should file an issue to refactor, so that this new pattern is adopted?

We already have this problem with existing entities... maybe I should file an issue to refactor, so that this new pattern is adopted?

Seems reasonable. One extreme would be mapping DAL entities to business logic types and baking all query patterns we need down into the DAL. Then we can have all of the business logic/convenience properties and methods that we want -- on the BL types. This is extreme and a big deviation from what we have today though. Perhaps a middle ground is writing all of these convenience methods/properties as methods of in our *Service classes.

@joelverhagen Oops, my last comment was intended for PR #4904. I've got too many tabs open :-)


How to add x-csrf-token in the request?

I want to add x-csrf-token in the request.

You can accomplish this by setting a header:
var options = {
    ...
    headers: {
        'X-CSRF-Token': token
    }
}

rp(options).then(...)


Windows support?

This tool seems very useful, does it support Windows, too? :)

It is not tested in Windows since I have no available Windows machine right now. I want to support Windows at least on ANSI compatible terminals (Windows 10 or previous versions with extra software). Also, I want to config CI to build/test project in a Windows environment, maybe using AppVeyor.
Feel free to test it and report any issue in Windows.

I only have Win 8.1 and would really like to use it in cmd.exe.
Why does it have such special requirements to the terminal, it's just batch renaming files, right? :)

Actually, it should work in Win 8.1 but without color support. I am using ansi_term crate to colorize output. The Windows builds I have tested in AppVeyor seem OK.


fix: vpc endpoint service s3

Description
AWS has some kind of bug on vpc endpoint service S3. S3 should be a "gateway" service however "gateway" and "interface" services shows up. This cause terraform to fail with the following error:
Error: multiple VPC Endpoint Services matched; use additional constraints to reduce matches to a single VPC Endpoint Service
Multiple S3 endpoint service (tested region: eu-central-1, eu-west-1)

Motivation and Context
I made this PR to able to deploy this able to deploy terraform code.

I am unable to make any VPC changes via Terraform and this module until this is fixed by adding the service_type

Continued in #573


Auto viewport resize in headless mode

I'm wondering why viewport size is set to 1440x900 by default when in headless mode. Is it not possible to do this in headless mode too?

The default in this case is 800 x 600. We just thought 1440 x 900 is a more sensible default. Open for discussion!

@schickling can auto sizing be done using window.innerHeight and window.innerWidth in headless instead of setting a default?

You setting this inside of a .evaluate call? I don't see the advantage of this approach over setting the viewport in the constructor?

@schickling I'm wondering if it possible to do full height, when it's an unknown.

You probably first need to find out the height using an .evaluate call and then use the .viewport method.

@schickling That's what I saw was being done here but not when isHeadless is true. Tried something like this, but renders a white image.
const screenshot = await chromeless
  .goto('https://www.graph.cool')
  .evaluate(async () => {
    const height = window.innerHeight;
    const width = window.innerWidth;
    await chromeless.viewport(width, height);
  })
  .screenshot()

What you want here (at least for the mean time) is to:
I think evaluate doesn't pass anything but what is returned to it, so screenshot would get a blank image.
const evalstuff= await chromeless
  .goto('https://www.graph.cool')
  .evaluate(async () => {
    const height = document.body.scrollHeight; //This gets the whole scrolled window height.
    const width = window.innerWidth;  // You probably don't need this.
    return {width:width, height:height}
  })

then you call:
const data = await evalstuff
const screenshot = await chromeless
  .setViewport({deviceScaleFactor: 0, scale: 1, fitWindow: true, width: data.width , height: data.height})
  .screenshot()

This worked for me, at least, putting here for others in the same boat.


How to Populate Grid Based on lookup values

Hello,
I have a Lookup dropdown with PO No. in Dialog.ts What I want to do is I want to populate Grid in Dialog.ts based on PO No.Selected in drop down. Can anyone please help me on this issue how can I achieve this ?

you can see the eaxmple below.
https://serenity.is/demo/BasicSamples/FilteredLookupInDetailDialog

A frequently asked question is how to pass some data from master dialog to a lookup editor in a detail dialog to filter items.
In this sample we have a custom Order dialog that has a Product Category selection.
When you click Add button in Order Details grid, Product editor in detail dialog will only show products in selected Category.
To achieve this, we need to flow selected category information on this route: Master Order Dialog -> Order Detail Grid Editor -> Order Detail Dialog -> Product Lookup Editor.
Source Files: Index.cshtml, FilteredLookupInDetailForm.cs FilteredLookupInDetailGrid.ts FilteredLookupInDetailDialog.ts FilteredLookupDetailEditor.ts FilteredLookupOrderDetailDialog.ts


Add name conflicts

https://github.com/konopski/awsome-name-conflicts
This list contains names of projects that conflicted with names of any other project. I think it is awesome to know what are you talking about when using a name of a project.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Has the Awesome badge on the right side of the list heading,
Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

Each link description starts with an uppercase character and ends with a period.Example: - [AVA](…) - JavaScript test runner.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

I wouldn't consider this an awesome list. You could add it to https://github.com/sindresorhus/awesome/wiki though :)

thnx, added.


Updated Std LB limits in azure-virtual-network-limits.md

Added limit for # of rules per backend NIC

#please-close


[Maintenance] Add spotless options

Relevant template
refarch-backend, refarch-eai
Problem description (optional)
Spotless has capabilities currently not used (import sorting, removing unused imports and so on)
Desired solution
Add the options
<importOrder/>
<removeUnusedImports />
<formatAnnotations />

I took a look at the currently used https://github.com/it-at-m/itm-java-codeformat/blob/main/formatter/src/main/resources/itm-java-codeformat/java_codestyle_formatter.xml.
Those options are not available there.
Alternatively to the standard import order mentioned above, we could think about a custom import order. An example:
<importOrder>  <!-- or a custom ordering -->
  <wildcardsLast>false</wildcardsLast> <!-- Optional, default false. Sort wildcard import after specific imports -->
  <order>java|javax,org,com,com.diffplug,,\#com.diffplug,\#</order>  <!-- or use <file>${project.basedir}/eclipse.importorder</file> -->
  <!-- you can use an empty string for all the imports you didn't specify explicitly, '|' to join group without blank line, and '\#` prefix for static imports. -->
  <semanticSort>false</semanticSort> <!-- Optional, default false. Sort by package, then class, then member (for static imports). Splitting is based on common conventions (packages are lower case, classes start with upper case). Use <treatAsPackage> and <treatAsClass> for exceptions. -->
  <treatAsPackage> <!-- Packages starting with upper case letters. -->
    <package>com.example.MyPackage</package>
  </treatAsPackage>
  <treatAsClass> <!-- Classes starting with lower case letters. -->
    <class>com.example.myClass</class>
  </treatAsClass>
</importOrder>

Considered alternatives (optional)
No response
Additional context (optional)
No response
No duplicate

[X] I confirm that this issue is not a duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I suggest using semanticSort set to true with
<importOrder>
    <semanticSort>true</semanticSort> <!-- Sort by package, then class, then member (for static imports). Splitting is based on common conventions (packages are lower case, classes start with upper case) -->
</importOrder>

The new mentioned options are only available in a later Spotless version thats currently available. With the problem mentioned in https://github.com/it-at-m/refarch-templates/issues/16 we need to set this issue to blocked for now.

We used https://github.com/revelc/formatter-maven-plugin before we switched to spotless. It's way more limited than spotless, but at least Eclipse JDT rules from https://github.com/it-at-m/itm-java-codeformat can be checked/enforced in CI without side-loading stuff from the internet as spotless currently needs.


Use OpInfos for operator tests

🐛 Describe the bug
Defining OpInfos for torchvision's operators would make it possible to run stock PyTorch correctness tests (that are generic over operators) in torchvision. For example, I want to add meta function support to torchvision operators but my preference is to reuse the testing infrastructure in PyTorch.
cc @pmeier @mruberry I don't know if it is actually supported to run tests in PyTorch with extra opinfos, doesn't feel like it.
Versions
master

We don't support this today but I don't think we're far off. We could just extend op_db with torchvision OpInfos when torchvision is available, for example, or we could require tests opt into ops_and_torchvision_ops like we do with Python Reference implementations currently.

Curious if there is any updates on this?

We now rely on optests.opcheck to check the correctness of the custom ops w.r.t to torch.compile().
https://github.com/pytorch/vision/blob/1de7a74a8b93483f1703eef0b306e0ec68e0cd9d/test/test_ops.py#L704
I'm not sure if that's exactly what "opinfos" are about though, as I'm not familiar with what happens within the torch core test base. But relying on opcheck addresses the original need above regarding testing meta functions.


Add support of gems.rb/gems.locked files

Thank you!

@n-rodriguez Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@n-rodriguez Thank you for signing the Contributor License Agreement!

I don't know much about this gems.locked file

https://github.com/rubygems/bundler/issues/694

@xtreme-shane-lattanzio I've fixed the bug so CI should be green now.

I don't know much about this gems.locked file but we will need to make sure we have tests to cover all these cases.

I think it's already the case. See: https://github.com/ruby/setup-ruby/pull/84#issuecomment-687349690

Please take a look at adding some tests when you have a chance!

I'd like to but :
nicolas@tchoum-laptop:~/PROJECTS/GITHUB/LicenseFinder$ bundle exec rake
LicenseFinder::GoDep: is not installed
LicenseFinder::Glide: is not installed
LicenseFinder::Gvt: is not installed
LicenseFinder::Govendor: is not installed
LicenseFinder::Dep: is not installed
LicenseFinder::Pip: is not installed
LicenseFinder::Bower: is not installed
LicenseFinder::Maven: is not installed
LicenseFinder::Gradle: is not installed
LicenseFinder::Rebar: is not installed
LicenseFinder::Nuget: is not installed
LicenseFinder::Mix: (elixir) is not installed
LicenseFinder::Sbt: is not installed
LicenseFinder::Dotnet: is not installed

@n-rodriguez Thanks for getting this green! As for the missing installations, the best way to get that running is by using the LicenseFinder docker image. That will guarantee that you have everything installed that you need to. Try out the Docker section in the readme and let me know if you need any help!

try out the Docker section in the readme and let me know if you need any help!

I won't have time for this, so can you please merge it?


Haskell-ghc-mod: ghc-mod crash freezes atom

Hello!
There is a somehow connected issue there: https://github.com/atom-haskell/haskell-ghc-mod/issues/112
I'm working on a pretty big, stack based project - about 20 custom libraries and a core library, which uses all of them. In the core library I've got several stack.yaml configs - one of them uses the sources of libraries by relative local paths (so for example it uses a library in ../libs/foo). These libraries depend on each other. While compiling the main library, all the needed local libraries are compiled with other local libraries as dependencies.
This workflow allows me to change multiple libraries and just fire stack and I'm sure that all changed code will be re-compiled. After making some changes I bulk-update all the libraries. The problem is, that if I edit the code of one of the libraries, it's stack.yaml is not aware of the local paths provided by the special stack.yaml in the main library, which causes ghc-mod to throw errors every time I open such file. It could be ok, but it almost freezes atom - in fact, these errors are thrown very frequently and after 10 - 15 seconds atom crashes or freezes completely.
In this bug report I would like to ask for fixing two issues:

giving the ability to silence errors in some special cases, or just not throwing them so frequently (currently if I press escape, after 2-3 seconds I see 4 - 5 errors)
make something with freezeing atom when ghc-mod crashes.

If I can provide any further info, I'd love to - just write what I should do.
Thank you,
Wojciech
EDIT:
An example stack trace from such crash is:
ghc-modi crashed
    at module.exports.Util.mkError (/Users/<user>/.atom/packages/haskell-ghc-mod/lib/util.coffee:171:15)
    at ChildProcess.exitCallback (/Users/<user>/.atom/packages/haskell-ghc-mod/lib/ghc-mod/interactive-process.coffee:76:20)
    at emitTwo (events.js:92:20)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

See https://github.com/atom-haskell/haskell-ghc-mod/issues/132 for a workaround.

TL;DR: haskell-ghc-mod will silently drop all ghc-mod commands if it finds .disable-ghc-mod file in the local root directory (nearest one to current file that contains *.cabal file).

Perfect! Is there any documentation where such features are described?

I just implemented this recently as a hot fix. So a) didn't have time to update docs and b) details might change down the line. Again, see #132 for discussion and background.

Letting you know that since haskell-ghc-mod-1.15.0 .disable-ghc-mod will not work anymore. Instead, see https://github.com/atom-haskell/haskell-ghc-mod#advanced-configuration
TL;DR create .haskell-ghc-mod.json in project root with following contents to replicate the behavior of .disable-ghc-mod:
{ "disable": true }

You can alternatively suppress error pop-ups if you want to (see readme)


Replace instances of $neq with $ne in Readme and tests

Coverage remained the same at 98.79% when pulling f47bc498e1303429c215e8273480b9ed1158df73 on blockspring:jtokoph-patch-1 into ce9400c1b4bcc0ad9714cfe5ef3785743a2f0aa5 on crcn:master.

Awesome - thanks for catching this!


feat: Config.exclude can be array

In progress
Fixes #558
Allow passing an array of strings to Config.exclude. Also allow string for this to be a non breaking change.
Should Config.include support arrays as well ?
To help everyone out, please make sure your PR does the following:

[x] Update the first line to point to the ticket that this PR fixes
[x] Add a message that clearly describes the fix
[ ] If applicable, add a test that would fail without this fix
[ ] Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
[ ] Includes a changeset if your fix affects the user with pnpm changeset

I added the code for include, but I can't manage to build the integration project to test.
I get this weird error, and can't figure out why it's thrown.
The files get included, and the artifacts generated.
Can be replicated starting here: https://github.com/HoudiniGraphql/houdini/pull/559/commits/f149302df95a2b08277a7ea580ca4979ebc4581d
The error I get:
file: /Users/danielhritcu/GitHub/houdini/integration/$houdini/runtime/lib/index.js:5:9
3: export { errorsToGraphQLLayout } from './errors';
4: export * from './types';
5: export * as log from './log';
            ^
6: export * from './deepEquals';
7: // putting this here was the only way i could find to reliably avoid import issues
[WebServer] error during build:
Error: Parse error @:5:10
    at parse$b (file:///Users/danielhritcu/GitHub/houdini/node_modules/.pnpm/vite@3.1.0/node_modules/vite/dist/node/chunks/dep-665b0112.js:33612:355)
    at Object.transform (file:///Users/danielhritcu/GitHub/houdini/node_modules/.pnpm/vite@3.1.0/node_modules/vite/dist/node/chunks/dep-665b0112.js:42799:27)
Error: Process from config.webServer was not able to start. Exit code: 1

@DanielHritcu are you still running into that error?

@AlecAivazis yes I am.

Oh, interesting it's happening on github too - alright so it must be related to your changes since these tests ran successfully in your other PR. I'll try to figure out what's going on

@DanielHritcu I pushed up a few changes that I think have fixed the problem. I'm really not sure how it's any different from what you have but i'm not getting the errors any more. Let me know what you think


Clear step logs the moment the step is included in another interactive run

Describe the problem this improvement solves
Right now it is confusing because it is unclear whether you are looking at logs of a previous run or the current run. Then suddenly all the logs are cleared and thus you know there are the new logs.
Describe the solution you'd like
Clear the logs the moment the step is included in a new run. Then when you inspect the logs and none are there, you know you just have to wait for the step to start executing.
Video
https://user-images.githubusercontent.com/26223174/178477117-0016751d-df9d-4776-b652-e82ba50e4a3d.mp4

Should this happen the moment the interactive run request is made (i.e. synchronously to the API request) or by the celery-worker when the run starts? The former doesn't scale too well with big pipelines but perhaps I'm overestimating, while the latter only clears the logs later, there will be PENDING steps that still have logs.

Should this happen the moment the interactive run request is made (i.e. synchronously to the API request) or by the celery-worker when the run starts?

I would say the former is the ideal situation, but if it doesn't scale well (e.g. a request has to be made for every step to clear its logs) then I think it is fine to go with the latter approach as long the described issue is solved (i.e. no longer confusion of whether you are looking at old logs or logs of the current run -- remember that in the logs view, you don't see the status of a step).

I would say the former is the ideal situation, but if it doesn't scale well (e.g. a request has to be made for every step to clear its logs

I think this can be taken care of transparently by the orchest_api.py module of the orchest-webserver when relaying the request of an interactive run from the client to the orchest-api. When it comes to scaling I was mostly worried about the number of steps and file deletion requests that would need to be synchronously sent during the execution of the endpoint logic (e.g. os.system) but I think I was too eager to be worried about that. I'll try to make a PR today about this, it has been lingering for too long imo


add ytt schema for external-dns package

What this PR does / why we need it

this provides defaults and validation for the package
Which issue(s) this PR fixes

Fixes: #
Describe testing done for PR

Tested rendering with different inputs to ensure the schema behaved as expected
Special notes for your reviewer

The package has changed, which would need a package bump. This PR or another?

The package has changed, which would need a package bump. This PR or another?

After some offline team discussion, the consensus is to merge this PR without releasing a new package artifacts and bumping the package in another PR when we better understand how we want to version new releases of the 0.11.0 package.


Restructure mappers

This is a draft because I need to test the existing mappers to ensure I didn't impact that inadvertently.

https://github.com/ucldc/rikolti/issues/219
https://github.com/ucldc/rikolti/issues/218

@amywieliczka and @barbarahui this PR contains cca_vault and chapman just to simplify things. Although I've done a comparison with Solr for a record for each, I'm sure the validation script will identify more issues with these mappers, and we're prepared to tackle those issues.

@lthurston this all looks good to me from an architectural perspective so I've accepted it and personally believe it's ready to merge into main. Once we start getting Solr comparisons really churning, we plan to open new tickets to adjust the specific details of the mappers. Does that work for you?


ghc: panic error on OSX

As per the current installation procedure on the readme, when one runs : stack install inside the molecularDynamics folder, on a Mac OS, we get the following error:
Error
ghc: panic! (the 'impossible' happened)
  (GHC version 8.8.3 for x86_64-apple-darwin):
        Prelude.chr: bad argument:<PHONE_NUMBER>

Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug

Error: [S-6374]
       While building simple Setup.hs (scroll up to its section to see the error) using:
       /Users/vandanrevanur/.ghcup/ghc/8.8.3/bin/ghc -rtsopts -threaded -clear-package-db -global-package-db -hide-all-packages -package base -main-is StackSetupShim.mainOverride -package Cabal-<IP_ADDRESS> /Users/vandanrevanur/.stack/setup-exe-src/setup-SvXsv1f_.hs /Users/vandanrevanur/.stack/setup-exe-src/setup-shim-SvXsv1f_.hs -o /Users/vandanrevanur/.stack/setup-exe-cache/x86_64-osx/tmp-Cabal-simple_SvXsv1f__<IP_ADDRESS>_ghc-8.8.3
       Process exited with code: ExitFailure 1

My PC specifications:
  Model Name:	MacBook Pro
  Processor Name:	6-Core Intel Core i7
  Processor Speed:	2,6 GHz
  Number of Processors:	1
  Total Number of Cores:	6
  L2 Cache (per Core):	256 KB
  L3 Cache:	12 MB
  Hyper-Threading Technology:	Enabled
  Memory:	32 GB

  System Version:	macOS 12.5.1 (21G83)
  Kernel Version:	Darwin 21.6.0
  Boot Volume:	Macintosh HD

I have figured out a fix. Will make a PR soon.


DeviceBuilder returns a RxBleDeviceMock instead of a RxBleDevice interface

It's not an issue in Java, but using language like Kotlin, this will trigger a compiler issue, because we can't access the package private class.
I don't have time for a PR right now but tell me if you need it.

@NitroG42 Should be available in the Snapshot release shortly.
Best Regards


AddTypeExtension, ExtendObjectType failing to extend objects

Describe the bug
Type Extensions do not extend types when using interfaces (perhaps others case too, but this is my primary case)
To Reproduce
Steps to reproduce the behavior:

see repro below

Expected behavior
Attempting to extend an object using interfaces (later I found that regular objects seems to fail too for some reason) does not appear to take effect.
HC v11.1 final
Additional context
repro:
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using HotChocolate;
using HotChocolate.Types;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;

namespace repro1
{
    [EnumType]
    public enum TemperatureKind
    {
        Celcius, Fahrenheit
    }

    [InterfaceType]
    public interface IHasTemperature
    {
        Task<double?> GetTemperature();
    }

    public class Thermostat : IHasTemperature
    {
        public Task<double?> GetTemperature()
        {
            return Task.FromResult<double?>(100d); // default to C
        }
    }

    [ExtendObjectType(typeof(IHasTemperature))]
    public class TemperatureConverter
    {
        public async Task<double?> GetTemperature(TemperatureKind? kind, [Parent] IHasTemperature device)
        {
            double? temperature = await device.GetTemperature();
            if (kind == TemperatureKind.Fahrenheit)
            {
                temperature = ((temperature / 5) * 9) + 32;
            }

            return temperature;
        }
    }

    [ExtendObjectType(OperationTypeNames.Query)]
    public class ThermostatQueries
    {
        public Task<Thermostat> GetThermostatAsync()
        {
            return Task.FromResult(new Thermostat());
        }
    }

    public class Startup
    {
        // This method gets called by the runtime. Use this method to add services to the container.
        // For more information on how to configure your application, visit https://go.microsoft.com/fwlink/?LinkID=398940
        public void ConfigureServices(IServiceCollection services)
        {
            _ = services
                .AddRouting()
                .AddGraphQLServer()
                .AddQueryType()
                .AddType<Thermostat>()
                .AddTypeExtension<ThermostatQueries>()
                .AddTypeExtension<TemperatureConverter>()
            .AddInterfaceType<IHasTemperature>()
            .AddEnumType<TemperatureKind>();

        }

        // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseRouting();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapGraphQL();
                endpoints.MapGet("/", async context =>
                {
                    await context.Response.WriteAsync("bug: getThermostat { temperature(kind: FAHRENHEIT) }");
                });
            });
        }
    }
}

So I tried to work around it with BindMember to ensure the names are different, but I may have discovered another bug:
  [ExtendObjectType(typeof(IHasTemperature))]
    public class TemperatureConverter
    {
        [BindMember(nameof(IHasTemperature.GetTemperature))]
        public async Task<double?> ConvertTemperature(TemperatureKind? kind, [Parent] IHasTemperature device) { ... }
    }

But now it seems that the magic binding doesn't map to the schema type correctly:
The field temperature must be implement by object type Thermostat

Fixed via https://github.com/ChilliCream/hotchocolate/pull/3426


Problem when I try to use INotification

When I call  _mediator.Publish(command) to publish INotification object, my notification handler calls several times.
But when I use IRequestHandler, IRequest and _mediator.Send(command) insted of INotification, and INoficationHandler, everything works fine.
Case
Handler.cs
public class CreateEventCommandHandler : INotificationHandler<CreateEventCommand>
    {
...
        public CreateEventCommandHandler(IEventTaskService taskService,
IHubContext<EventsHub> hubContext)
        {
 ...
        }

        public async Task Handle(CreateEventCommand cmd, CancellationToken cancellationToken)
        {
            var item = cmd.Adapt<Event>();
          ....
        }
    }

NotificationHandler.cs
  public class CreateEventCommand : INotification
    {
       ...
    }

AutofacModule.cs
...
base.Load(builder);
        // enables contravariant Resolve() for interfaces with single contravariant ("in") arg
        builder
            .RegisterSource(new ContravariantRegistrationSource());

        // mediator itself
        builder
            .RegisterType<Mediator>()
            .As<IMediator>()
            .InstancePerLifetimeScope();

        // request handlers
        builder
            .Register<ServiceFactory>(ctx =>
            {
                var c = ctx.Resolve<IComponentContext>();
                return t =>
                {
                    object o;
                    return c.TryResolve(t, out o) ? o : null;
                };
            })
            .InstancePerLifetimeScope();

  builder.RegisterAssemblyTypes(typeof(CreateEventCommand).GetTypeInfo().Assembly)
                .AsClosedTypesOf(typeof(INotificationHandler<>));

            builder.RegisterAssemblyTypes(typeof(StatusChangeCommand).GetTypeInfo().Assembly)
                .AsClosedTypesOf(typeof(INotificationHandler<>));

          builder.RegisterAssemblyTypes(typeof(DiscussionStatusChangeCommand).GetTypeInfo().Assembly)
                .AsClosedTypesOf(typeof(INotificationHandler<>));

<PackageReference Include="MediatR" Version="5.0.1" />
<PackageReference Include="Autofac" Version="4.8.1" />
<PackageReference Include="Autofac.Extensions.DependencyInjection" Version="4.2.2" />

I'm lost after trying to understand purpose of this line
public class CreateEventCommandHandler : INotificationHandler<CreateEventCommand>
What are you trying to achieve? 1 request = 1 handler, 1 notification = multiple handlers, why would you want to use notification handler for commands?
About multiple notification handler hits - its problem with your container configuration.
  builder.RegisterAssemblyTypes(typeof(CreateEventCommand).GetTypeInfo().Assembly)                 .AsClosedTypesOf(typeof(INotificationHandler<>));             builder.RegisterAssemblyTypes(typeof(StatusChangeCommand).GetTypeInfo().Assembly)                 .AsClosedTypesOf(typeof(INotificationHandler<>)); builder.RegisterAssemblyTypes(typeof(DiscussionStatusChangeCommand).GetTypeInfo().Assembly)                 .AsClosedTypesOf(typeof(INotificationHandler<>));
Here you are using some random command to get assembly, which is pretty bad approach, then you declare every class that implements INotificationHandler to be injected as this interface. You are doing it 3 times. Because request handler is resolved by getting first registered type and notification handler by getting all registered types you end up with your notification handlers being called multiple times (I bet it's 3 times ;) ).


Incorrect results for arithmetic expression

Seems there is an error when the expression contains arithmetic on one side.
Example:
>>>comparator = Comparator()
>>>print(comparator.compare("x - 1 < y", "x - 1 <= y"))
>>>The predicates are not equivalent and neither is stronger.
>>>print(comparator.compare("x + 1 < y", "x + 1 <= y"))
>>>The predicates are not equivalent and neither is stronger.

This is fixed with https://github.com/mojtaba-eshghie/PreDi/commit/f269a68aedd75d553a84a9024bbaefed54b100bc; I will close.


Missing labels for some states, provinces, and territories

I've noticed labels for some states, provinces, and territories are not shown at any zoom level using any style. I assume they're missing from the vector tiles.
Alaska, USA
Florida, USA
Puerto Rico, USA
Saskatchewan, Canada

Hi @brewin, thanks for your report. We have custom curated lists of states, seas and countries. You can simply add the missing items to the corresponding geojson and create a pull request.

@manuelroth shouldn't the above mentioned automatically appear on zoom levels like 5 or 6 - directly from Natural Earth?
There is a need for "seas" custom geojson probably - but aren't the states and countries sufficient in the Natural Earth Data itself?

@klokan The data like name, translations and geometry is based on OSM data. We extracted it with the overpass api. These custom geojson's were created because we wanted to add our own scalerank. Neither OSM nor Natural Earth provide a good scalerank, because of this we decided to do this solution.

I just figured out, that Alaska and Florida are not included because we did not extract them correctly. I will create a pull request and add them.

Added the missing states Alaska, Florida and Saskatchewan. I did not add Puerto Rica, because it is not a state of america


ORC-1556: Add Rocky Linux 9 Docker Test

This is a clone of #1695

This is resolved via https://github.com/apache/orc/commit/9414da763938940f2209313ec29552e2a2c35a0d


Add 🇨🇳 Chinese Translation

Description

Adding 🇨🇳 translation.
Update: Sorry I typed wrong PR id and link (should be #147, I typed #145)
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I wrote unit tests for my code (if tests are required for my changes)
[x] I have made changes in the CHANGELOG.md file

Please, revert change log file changes

Please, revert the markdown files changes

Ok, already reverted

You've done a tremendous job! Thank you!

Released in v2.19.0


[MRG] Appveyor cache

This PR addresses #98
We can see the cache is being used and being updated. I don't know how much time is really being saved (my builds were still taking ~12 minutes). The only additional change we might want to add is to skip updating cache unless we are on a specific branch, but I was watching these build in real time, and that step only took like 1 second each.

Nice:
Cache 'C:\Users\appveyor\AppData\Local\pip\Cache' - Restored

Thanks!


Add translations for Turkish

Issue: #313
Requirements

[ ]  issue was opened to discuss proposed changes before starting implementation.
[x]  during development, node version specified in package.json was used.
[x]  package versions and package-lock.json were not changed (npm install --no-save).
[x]  app version number was not changed.
[ ]  all new code has tests to ensure against regressions.
[x] npm run lint reports no offenses except the ones already there.
[x] npm run test is error-free.
[x]  README and CHANGELOG were updated accordingly.

Description of the Change

Added tr.json file for Turkish translations
Updated settings3.html & welcome.html to include new language.

Verification Process
Changing language in settings3 page works as expected across tray menu, app & tutorial.

Thanks ;] do you run app locally to test the translations?

Your very welcome. Yes, did run locally.
On Wed, Oct 24, 2018, 7:18 PM Jan Hovancik<EMAIL_ADDRESS>wrote:

Thanks ;] do you run app locally to test the translations?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hovancik/stretchly/pull/314#issuecomment-432725404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS9VEst8Dd1XonfvQtoju4KME4U2GbLks5uoJLXgaJpZM4X1edw
.


Use nova_get_setting into  config/* files ?

Hello,
I would like to use nova_get_setting into  config/* files   for notifications, mail and ldap settings
I've got the following error
Call to a member function connection() on null

Thank you for the help

You can't use nova-settings in the config files. The nova-settings depends on a database and config files are created before the database connection is set up (which is also set up using config files, so it's a loop pretty much).

We wanted to use these settings in config, so the approach was to create a helper to safely check for the value, then use it in our service providers to set config values:
Helper:
    function safe_nova_get_setting($settingName, $fallbackValue) {
        $return = $fallbackValue;
        if(Schema::hasTable('nova_settings')) {
            try {
                $return = nova_get_setting($settingName, $fallbackValue);
            } catch (Throwable $e) {}
        }
        return $return;
    }

In AppServiceProvider@boot:
        config([
            'app.timezone' => safe_nova_get_setting('APP_TIMEZONE', 'UTC'),
            // ...
        ]);

This is working fine so far, but hasn't been thoroughly tested.


✨ [REQUEST] ntfy as Addon

Checked

[X] If a new addon, I have checked on  Google that such as addon doesn't already exists
[ ] If a new feature, I have searched in the discussions & issues that it was not already covered

Which addon?
ntfy (http://ntfy.sh) is a notification service which works with topics. It is comparable to Nextpush or closer to Gotify. They offer a public shared instance, but every so called "topic" is technically public available.
The link to the instructions for Docker can be found here:
https://docs.ntfy.sh/install/#docker
Is your feature request related to a problem? Please describe
Couldn't find anything similar to it.
Describe the solution you'd like
It would be amazing to have this as an selfhosted Variant right from Hassio, so I can manage all my topics from my private instance. It doesn't need to run as an internal frame. A separate tab, which is reachable over the provided port would be enough.
All your integrations worked so far pretty well for me, so thank you for what you did so far!!!
👍

i would like this add on too please

Hi, I see there is an integration, would it help ? https://github.com/ivanmihov/homeassistant-ntfy.sh