lxd starting container failed

Trying to start a lxd container with trhe command :
lxc start seafile --debug -v
Output is :
2015/04/27 00:23:56 fingering the daemon
2015/04/27 00:23:56 raw response: {"type":"sync","status":"Success","status_code":200,"metadata":{"api_compat":1,"auth":"trusted","config":{"trust-password":false},"environment":{"backing_fs":"ext4","driver":"lxc","kernel_version":"3.19.0-15-generic","lxc_version":"1.1.2"}}}
2015/04/27 00:23:56 pong received
2015/04/27 00:23:56 putting {"action":"start","force":false,"timeout":-1}
to http://unix.socket/1.0/containers/seafile/state
2015/04/27 00:23:56 raw response: {"type":"async","status":"OK","status_code":100,"operation":"/1.0/operations/4db68203-527c-4453-9ac5-bce503e19677","resources":null,"metadata":null}
2015/04/27 00:23:56 1.0/operations/4db68203-527c-4453-9ac5-bce503e19677/wait
2015/04/27 00:24:01 raw response: {"type":"sync","status":"Success","status_code":200,"metadata":{"created_at":"2015-04-27T00:23:56.15638766+02:00","updated_at":"2015-04-27T00:24:01.202688119+02:00","status":"Failure","status_code":400,"resources":null,"metadata":"starting the container failed","may_cancel":false}}
error: starting the container failed
Tail -20 of /var/log/lxd/seafile/lxc.log :
lxc_container<PHONE_NUMBER>.174 DEBUG    lxc_start - start.c:__lxc_start:1137 - Not dropping cap_sys_boot or watching utmp
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 3
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 4
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 5
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 6
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 7
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 8
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 9
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 10
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 12
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 13
lxc_container<PHONE_NUMBER>.176 INFO     lxc_start - start.c:lxc_check_inherited:221 - closed inherited fd 14
lxc_container<PHONE_NUMBER>.178 INFO     lxc_start - start.c:resolve_clone_flags:848 - Cloning a new user namespace
lxc_container<PHONE_NUMBER>.180 ERROR    lxc_conf - conf.c:instantiate_veth:2660 - failed to attach 'vethKW155N' to the bridge 'lxcbr0': Operation not permitted
lxc_container<PHONE_NUMBER>.184 INFO     lxc_monitor - monitor.c:lxc_monitor_sock_name:177 - using monitor sock name lxc/92ea7555d42fc75c//var/lib/lxd/lxc
lxc_container<PHONE_NUMBER>.196 ERROR    lxc_conf - conf.c:lxc_create_network:2943 - failed to create netdev
lxc_container<PHONE_NUMBER>.196 ERROR    lxc_start - start.c:lxc_spawn:914 - failed to create the network
lxc_container<PHONE_NUMBER>.196 ERROR    lxc_start - start.c:__lxc_start:1164 - failed to spawn 'seafile'
lxc_container<PHONE_NUMBER>.196 WARN     lxc_commands - commands.c:lxc_cmd_rsp_recv:172 - command get_init_pid failed to receive response
lxc_container<PHONE_NUMBER>.197 WARN     lxc_cgmanager - cgmanager.c:cgm_get:963 - do_cgm_get exited with error
Ifconfig only shows a 'virbr0' and no 'veth*'...
I've checked that the libvirtd daemon is running... and really don't know what else I can do to investigate.
The system was freshly installed with an ubuntu 15.04. I'd think that lxc wasn't properly installed/configured by the lxd. Also, and strangely, I always need to start the lxd daemon manually after each reboot... (systemctl start lxd).

On Sun, Apr 26, 2015 at 04:01:23PM -0700, pxcluster wrote:

lxc_container<PHONE_NUMBER>.180 ERROR    lxc_conf - conf.c:instantiate_veth:2660 - failed to attach 'vethKW155N' to the bridge 'lxcbr0': Operation not permitted
...
Ifconfig only shows a 'virbr0' and no 'veth*'...

So there is no lxcbr0?  lxd uses that bridge by default.
I've had some trouble with lxc-net under systemd as well.  Can you do
ifconfig -a
sudo systemctl stop lxc-net
sudo systemctl start lxc-net
ifconfig -a
and see if lxcbr0 shows up in the second ifconfig output?
(I sometimes have to do it several times...)

On dim, 2015-04-26 at 19:32 -0700, Serge Hallyn wrote:

So there is no lxcbr0? lxd uses that bridge by default.

I know, this is what I found strange...

I've had some trouble with lxc-net under systemd as well. Can you do
ifconfig -a
sudo systemctl stop lxc-net
sudo systemctl start lxc-net
ifconfig -a
and see if lxcbr0 shows up in the second ifconfig output?
(I sometimes have to do it several times...)

Yes, it works !
Is there anything I can do, test, or what so ever, to help you find the
problem ?
My system is currently not in production and I can still use it a few
days to run some tests...
Thanks for the info
Daniel Cordey

I have reworked the lxc-net script in upstream LXC to make it a bit more robust, hopefully this is now resolved there (current upstream git though, so you'd only get it if you use daily builds from ppa:ubuntu-lxc/lxc-git-master).
Closing the issue as there's nothing we can do on the LXD side of this and we believe the LXC side of it has been resolved upstream.

FWIW, I've seen this on Ubuntu 15.10 when dnsmasq is not installed.

On 25. 06. 15 09:38, Geoff Teale wrote:

FWIW, I've seen this on Ubuntu 15.10 when dnsmasq is not installed.

Thanks for the tip.
I finally decided to go back to Ubuntu 14.10 since I started to have too
many problems with 15.04. It seems that 'systemd' is not fully
operational with lxc on 15.10 (something in between upstart and
systemd...) Some pieces are missing and it doesn't make sense to
implement horrible hacks while it's supposed to work. We probably just
need to wait a bit longer before everything is in sync :-)
Daniel Cordey

FYI: I get this error because lxc-net fails to start. I run bind and it listens on ipv6.
I was able to better configure bind by using  listen-on-v6 { 2601::/16; }; in my named.conf.options file.
Once in place, I can restart bind, restart lxc-net and start instances.

Ah yeah, anything which binds port 53 on all interfaces will interfere with lxc-net. There's unfortunately nothing we can do about this, besides telling people to configure such daemons to only bind the interfaces the service is actually needed on.

I found out, that this could be a timing problem in the lxc-net startup script
/usr/lib/x86_64-linux-gnu/lxc/lxc-net in Ubuntu whily.
There was a problem setting the ip address in the ifup() function. I added two sleeps before and after the "ip addr add" line and now it works without any problems every time.
Here is my changed ifup() function:
ifup() {
MASK=_netmask2cidr ${LXC_NETMASK}
CIDR_ADDR="${LXC_ADDR}/${MASK}"
sleep 2
ip addr add ${CIDR_ADDR} dev $1
sleep 2
ip link set dev $1 up
}

I was able to better configure bind by using listen-on-v6 { 2601::/16; }; in my named.conf.options file.

Thanks! I did this and once I restarted bind and restarted lxc-net, lxcbr0 showed up in ifconfig.

I have this same problem with Ubuntu 15.10 (Willy). It recently (december 2015) showed up.
For reference, this was the error I got:
There was an error executing ["sudo", "/usr/local/bin/vagrant-lxc-wrapper", "lxc-start", "-d", "--name", "aa_default_1449926068132_45691"]

I've had the same issue today.
Happens with 15.10 as is but also with the code from ppa:ubuntu-lxc/lxd-stable.
As Stephane already pointed out that is actually a lxc (and not lxd) issue.
I found steverdings workaround with the sleeps working for me.
If not applying the workaround I can see this in lxc-net
sudo systemctl status lxc-net
● lxc-net.service - LXC network bridge setup
Loaded: loaded (/lib/systemd/system/lxc-net.service; enabled; vendor preset: enabled)
Active: active (exited) since Mo 2016-02-15 16:17:56 CET; 3s ago
Process: 32179 ExecStop=/usr/lib/x86_64-linux-gnu/lxc/lxc-net stop (code=exited, status=0/SUCCESS)
Process: 32192 ExecStart=/usr/lib/x86_64-linux-gnu/lxc/lxc-net start (code=exited, status=0/SUCCESS)
Main PID: 32192 (code=exited, status=0/SUCCESS)
Feb 15 16:17:56 paelzer-ThinkPad-X1-Carbon-3rd systemd[1]: Starting LXC network bridge setup...
Feb 15 16:17:56 paelzer-ThinkPad-X1-Carbon-3rd lxc-net[32192]: dnsmasq: failed to create listening socket for <IP_ADDRESS>: Cannot assign requested address
Feb 15 16:17:56 paelzer-ThinkPad-X1-Carbon-3rd lxc-net[32192]: Failed to setup lxc-net.
Feb 15 16:17:56 paelzer-ThinkPad-X1-Carbon-3rd systemd[1]: Started LXC network bridge setup.
It instead should look like this (with the sleeps)
Feb 15 16:20:02 paelzer-ThinkPad-X1-Carbon-3rd systemd[1]: Starting LXC network bridge setup...
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq[32696]: started, version 2.75 cachesize 150
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq[32696]: compile time options: IPv6 GNU-getopt DBus i18n IDN DHCP DHCPv6 no-Lua TFTP conntrack ipset auth DNSSEC loop-detect inotify
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq-dhcp[32696]: DHCP, IP range <IP_ADDRESS> -- <IP_ADDRESS>, lease time 1h
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq-dhcp[32696]: DHCP, sockets bound exclusively to interface lxcbr0
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq[32696]: reading /etc/resolv.conf
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq[32696]: using nameserver <IP_ADDRESS>#53
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd dnsmasq[32696]: read /etc/hosts - 7 addresses
Feb 15 16:20:08 paelzer-ThinkPad-X1-Carbon-3rd systemd[1]: Started LXC network bridge setup.
Seems to need some hardening against racing several parts of the initialization.
Due to the ppa I have 2.0.0~beta2-0ubuntu2 installed as is current for xenial atm.
As it is lxc package Is there a related lxc bug already known?

I'm on Xenial with newest lxc and it also fails to create lxcbr0.

$ sudo systemctl status lxc-net
● lxc-net.service - LXC network bridge setup
Loaded: loaded (/lib/systemd/system/lxc-net.service; enabled; vendor preset:
Active: active (exited) since czw 2016-03-31 19:12:34 CEST; 3min 52s ago
Process: 2840 ExecStop=/usr/lib/x86_64-linux-gnu/lxc/lxc-net stop (code=exited
Process: 2915 ExecStart=/usr/lib/x86_64-linux-gnu/lxc/lxc-net start (code=exit
Main PID: 2915 (code=exited, status=0/SUCCESS)

mar 31 19:12:34 mateusz-desktop systemd[1]: Starting LXC network bridge setup...
mar 31 19:12:34 mateusz-desktop lxc-net[2915]: dnsmasq: failed to create listeni
mar 31 19:12:34 mateusz-desktop lxc-net[2915]: Failed to setup lxc-net.
mar 31 19:12:34 mateusz-desktop systemd[1]: Started LXC network bridge setup.

$ apt-cache policy lxc
lxc:
Zainstalowana: 2.0.0~rc14-0ubuntu2
Kandydująca:   2.0.0~rc14-0ubuntu2
Tabela wersji:
*** 2.0.0~rc14-0ubuntu2 500
500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages
500 http://archive.ubuntu.com/ubuntu xenial/main i386 Packages
100 /var/lib/dpkg/status

So I installed dnsmasq and after reboot I could start the container without problems.


How can I find out when a collection was last modified?

I need to know when a collection was last updated. Is this possible to do via SolrNet or at all outside of the web UI?

You're probably looking for this property: https://github.com/SolrNet/SolrNet/blob/87bbe48baaf8bd7ef5942ff4d164e4fecefd6afd/SolrNet/Impl/CoreIndexResult.cs#L53


kombu-sqlalchemy is deprecated since 2012

https://github.com/ask/kombu-sqlalchemy

Being introduced in Kombu core code back then,
but being removed in 4th version: https://github.com/celery/kombu/commit/1cd4e07f9ebb2fdbde0f86054e963f6bbd17e698 https://github.com/Erve1879/kombu/pull/2

Got rid of it in https://github.com/DanePubliczneGovPl/ckanext-archiver/commit/124c5bd57a2d0e3c8c28e4ef7e9aa97b1a67ecfd

This was resolved in #50


Consistent ArrayXD Python formatting + better NumPy/Pandas formatting

Return a list of lists instead of a list of NumPy arrays when converting the variable-shaped ArrayXD to Python. Additionally, improve the NumPy conversion by returning a numeric NumPy array when the offsets are equal or a NumPy object array when they aren't, and allow converting the variable-shaped ArrayXD to Pandas.
(Reported in https://github.com/huggingface/datasets/issues/5719#issuecomment-1507579671)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I turned it into a draft to fix the failing tests, but CI is now green, so there is no good reason for it :)


add Actor.prototype.getSpeedInMeterPerSecond

Added Actor.prototype.getSpeedInMeterPerSecond

it would be nice to become getSpeedInMetersPerSecond

thanks for your contribution


fix:modify license and workflow

Update the open-source license to MIT.
Resolve issues with the basic unit test scripts.

更新项目的开源许可证为MIT
修复基础的单元测试脚本

Successfully tested locally and on a custom branch. Proceeding with a direct merge.


(Client=55) FETCHPLAN out_*:-2 always sets specific out_X:N to out_X:0

When using wildcard, it should be overwritten by non-wildcard fetchplans. Currently, it always overwrites with depth-level=0. Below is an example.
This query
select from #5:5

returns
[{
    "@type": "d",
    "@rid": "#5:5",
    ...
    "out_UserWrotePost": [
        "#42:14682"
    ],
    "out_UserBuiltWorkout": [
        "#47:2640"
    ]
}]

And this query
select from #5:5
fetchplan out_UserWrotePost:1

returns
[{
    "@type": "d",
    "@rid": "#5:5",
    ...
    "out_UserWrotePost": [{
        "@type": "d",
        "@rid": "#42:14682",
        "@version": 3,
        "@class": "UserWrotePost",
        "out": "#5:5",
        "in": "#19:15459"
    }],
    "out_UserBuiltWorkout": [
        "#47:2640"
    ],
}]

But this query
select from #5:5
fetchplan out_*:-2 out_UserWrotePost:1

returns
[{
    "@type": "d",
    "@rid": "#5:5",
    ...
    "out_UserWrotePost": [{
        "@type": "d",
        "@rid": "#42:14682",
        "@version": 3,
        "@class": "UserWrotePost"
    }],
}]

@tglman is this similar to another one you had?

Fixed by introducing depth levels in Fetch Plans.


fix: ignore terminal pods

Fixes #40
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Didnt saw this PR, I also created a different one https://github.com/awslabs/eks-node-viewer/pull/49


Allow humans to make moves

One cool feature could be to play yourself with LLM, or make some interesting positions and let LLM continue

is a good idea, adding a few things today, including this one. Thank you for testing!


use rawgit for example

http://home.dev seems to be down.

@bradoyler thanks for the PR. I'll keep it open but we have to come with a smarter solution. Right now I'm using the example folder as a place for developing. So pointing to rawgit will prevent me from seeing the changes locally. However, in long term this change is indeed required. I'll think how to satisfy both cases.

Closing this one since the demo is now placed here http://work.krasimirtsonev.com/git/navigo/about
P.S.
The router is publicly available at http://krasimir.github.io/navigo/lib/navigo.js


Support building docker image with different python version

Currently the version is fixed (3.9)

closes by #83


Directive with '+' not handled correctly

Bad detection if presence of + in the directive.
$robotsTxtContentIssue = "
User-agent: *
Disallow: *telecommande++*
";

$parserRobotsTxt = RobotsDotText::withContent($robotsTxtContentIssue);
$rulesRobotsTxt = $parserRobotsTxt->getRules();
$robotsTxtValidator = new RobotsTxtValidator($rulesRobotsTxt);

if ($robotsTxtValidator->isUrlAllow('http://www.test.com/telecommandes-box-decodeur.html')) {
        echo "Allow.".PHP_EOL;
} else {
        echo "Disallow.".PHP_EOL;
}

Result :

Disallow

Should be :

Allow

Google search console - robots.txt Tester :

Per Google’s robots.txt documentation, the + has no special meaning, but * has one (it means: any sequence of characters).
So crawling of /telecommandes-box-decodeur.html would still be allowed.
Disallowed would be, for example, crawling of /foo/telecommande++bar.html.
Maybe one solution would be to add \ from some special regular expression characters except * (*telecommande++* => *telecommande\+\+*)

Hi @LeMoussel,
should be fixed by this line.
Please write if something else.


use keep_attrs in binary operations

[x] Closes #2582
Allows using xarray.set_option(keep_attrs=True) with binary operations [-, + , *, /]
Example see #2582

not done


Fix typos in kafka_tips.adoc

Fix typos in kafka_tips.adoc
typo corrections

serailzers -> serializers
deserilzartion -> deserialization
excepion -> exception
excpetions -> exceptions
errror -> error
applicaiton -> application
exaplain -> explain
partiton, partititon -> partition
biner -> binder
reipce -> recipe
becuase -> because
configurarion -> configuration
unncessary -> unnecessary
sedings -> sendings

@ByungjunYou Thank you for this cleanup PR! Merged upstream.


Different "delta_"-like keys can be thrown away from AMCKeys

Subj.
Looks like it can be computed in -continueWithTarget: with end_ & start_ values.

Changing label to "feature-amc" branch. feature-amc-actions will be merged to it soon.


Bug fix for local path pointer to pgcli and mycli

Not a new extension.  This PR is to fix a bug in which the extension cannot reference the pgcli and mycli packages unless it knows the relative path to those commands.  Also checking in rerun of test files.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

rdbms


Add export dialog

Allow to name output file
Allow to choose -> gb / json / both in a zip file
Maybe open path saver if possible?

Closed with:

https://github.com/manulera/ShareYourCloning_frontend/commit/028d55f514a46e842e160728a9177231ae519c57
https://github.com/manulera/ShareYourCloning_frontend/commit/c0c27faade631bd8d89c4d4456da01f07322ddde

(wrong commit message)


add exit command and improve print for listResources

Codecov Report

Merging #34 into release-rc2 will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             release-rc2     #34      +/-   ##
================================================
- Coverage           6.76%   6.68%   -0.08%
  Complexity            17      17
================================================
  Files                 15      15
  Lines                843     853      +10
  Branches             109     113       +4
================================================
  Hits                  57      57
- Misses               773     783      +10
  Partials              13      13

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/webank/wecross/console/Shell.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...va/com/webank/wecross/console/common/HelpInfo.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

.../com/webank/wecross/console/mock/MockResource.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...n/java/com/webank/wecross/console/rpc/RPCImpl.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7214a54...3b3ca11. Read the comment docs.


Supervision Orders (JSPUI Only)

From the release plan spreadsheet; no additional notes were included.
Estimate from release plan: TBD
Expressing interest: none
Depends on REST ticket https://github.com/DSpace/DSpace/issues/2878

We (at 4Science) are interested in this task. See also the note on the REST ticket https://github.com/DSpace/DSpace/issues/2878
On the angular side the following activities will be needed

mydspace: a new option in the dropdown Show (other than Your submission / workflow) will be added to provide access to the workspaceitem that you supervise. Please note that this entry will be always shown (see below to fully disable the supervision system)
a new Supervision orders administrative menu will be included similar to the Administer workflow focused on workspaceitems so that the administrator can check for existing supervision orders, delete or create new ones

A REST configuration flag will be introduced and exposed to angular so that the supervision system can be completely disabled to don't annoy users not using such feature.
Estimation for the angular part is: 40 hours

Thanks @abollini : That all sounds reasonable. I agree this should be a configurable feature which can be turned on/off.  When off, the REST API should not allow for any supervision orders.
I'll assign to your team for 7.5 & add the estimate.


success should consider 200-series status codes successful

I tried returning ACCEPTED (202) from my success endpoint, since I don't have anything to say, but Fine Uploader considers that a failure code. Anything in the 200 series is supposed to be treated as success; in particular, it's entirely likely that a 201 is appropriate.

What version of Fine Uploader?
On Sun, Apr 26, 2015 at 3:33 PM -0700, "Christopher Smith"<EMAIL_ADDRESS>wrote:
I tried returning ACCEPTED (202) from my success endpoint, since I don't have anything to say, but Fine Uploader considers that a failure code. Anything in the 200 series is supposed to be treated as success; in particular, it's entirely likely that a 201 is appropriate.
—
Reply to this email directly or view it on GitHub.

Acceptance of these statuses was added as part of 5.2.0 in #1314. If you are using 5.2.x and still seeing an issue, please include all details needed to reproduce and this can be re-opened.

I'm still on 5.1.3; I hadn't seen the new release. I'll move us over as soon as practical. Thanks!


Fixed BeaconBroadcastPackage compiler error

Fixes #5
Removed @Override annotations from BeaconBroadcastPackage

You aren't fixed it in a repot, please fix it for us :-)


Update Cargo.toml

This fixes compilation on ESP-IDF target, where 0.5 introduced support for.

Thanks, merged in #34.


add basic blog structure

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Test URLs:

Before: https://main--shredit--stericycle.aem.page/en-us/blog/10-documents-to-take-to-communtiy-shredding-event
After: https://related-content-blog--shredit--stericycle.aem.page/en-us/blog/10-documents-to-take-to-communtiy-shredding-event
https://related-content-blog--stericycle-shared--aemsites.aem.page/en-us/blog/10-documents-to-take-to-communtiy-shredding-event

Will add the 'dynamic' article pull logic styles in #31


Error: Client Side Exception after setting data view to all time

I am getting this client-side exception since setting the default view to all time on the profile settings page.
The error occurs on the main page and on the profile page.
The cause can be seen in the browser console.
running 2.1.0 in docker with postgres

I was able to reproduce this bug. Only way to get past it was clearing my browser history.


Automated cherry pick of #5774: fix: azure重装系统删除不必要的参数

Cherry pick of #5774 on release/2.13.
#5774: fix: azure重装系统删除不必要的参数

Codecov Report

Merging #5777 into release/2.13 will decrease coverage by 0.06%.
The diff coverage is 1.57%.

@@               Coverage Diff               @@
##           release/2.13   #5777      +/-   ##
===============================================
- Coverage          6.86%   6.80%   -0.07%
===============================================
  Files               519     534      +15
  Lines             88131   90377    +2246
===============================================
+ Hits               6052    6148      +96
- Misses            81580   83720    +2140
- Partials            499     509      +10

Flag
Coverage Δ

#aFlag
6.80% <1.57%> (-0.07%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/baremetal/cronjobs.go
0.00% <ø> (ø)

pkg/baremetal/manager.go
0.51% <0.00%> (-0.01%)
:arrow_down:

pkg/baremetal/tasks/baseprepare.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/metadata.go
8.74% <0.00%> (-2.16%)
:arrow_down:

pkg/cloudcommon/db/modelbase.go
1.42% <0.00%> (-0.05%)
:arrow_down:

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.94% <0.00%> (ø)

pkg/cloudcommon/db/paging.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/quotas/context.go
0.00% <0.00%> (ø)

... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4829e2...b80742d. Read the comment docs.

/lgtm

/approve

/approve


Help！Jenkins pipeline 50% completed with error.

Question
just set up a default project,
run a pipeline with
"Plugin": "jenkins",
"Options": {}
Screenshots

Additional context
run task failed with panic (github.com/merico-dev/lake/plugins/jenkins/tasks.ExtractApiBuilds.func1:62): runtime error: index out of range [0] with length 0

which version? v10.1 or main?

@yizhixiaotaozi Hi, sorry for the bug, already fixed, can you try it again?


Create a 10-minute introductory tutorial

A whirlwind tour of the Project:M36 features would better attract casually curious developers.

Merged to master. It's actually a 15-minute tutorial. Oh well.


Add ability to stop a process by clicking on it while it is active

refs #6

clicking on an active process stops it (doesn't work if the process creates child processes)

:+1: Just what I needed!
Only thing left is for atom to fix a bug related to killing buffered processes since my gulp serve has a child process spawned https://github.com/atom/atom/issues/7252

@jbtule yeah I saw that. Been trying to figure out a good fix for it, if I do I'll try to submit a patch upstream that will hopefully fix the problem.


3.4.1: Spot requests remain untagged.

In an effort to be vigilant with tagging, in 3.4.1, when CapacityType = SPOT, the spot requests themselves do not show tags despite Tags: being defined in the parallelcluster configuration.

Hi francisreyes-tfs,
just to clarify the issue with ParallelCluster version 3.4.1, with a configuration like the following, you do not find the Tags test-spot in your compute node instance tag?
Region: eu-west-1
Tags:
  - Key: test-spot
    Value: test-spot
Image:
  Os: alinux2
HeadNode:
  InstanceType: c5.large
  Networking:
    SubnetId: subnet-xxxxxxxxxxxxxxxxx
  Ssh:
    KeyName: <YOUR_KEY>
Scheduling:
  Scheduler: slurm
  SlurmQueues:
  - Name: queue1
    CapacityType: SPOT
    ComputeResources:
    - Name: c5large
      InstanceType: c5.large
      MinCount: 1
      MaxCount: 4
    Networking:
      SubnetIds:
      - subnet-xxxxxxxxxxxxxxxxx

Not the instances themselves, but the spot requests. I.e. the requests listed by aws ec2 describe-spot-instance-requests


Inserting empty array and document into boolean field

If I insert an empty array or an empty document into a boolean field, I would expect that the value of that field will be false. Exactly the same way as with empty strings.
What do you think?
genji> CREATE TABLE test(a bool, b bool, c bool);
genji> INSERT INTO test VALUES {a: "", b: [], c: {}};
genji> SELECT * FROM test;
{
  "a": false,
  "b": true,
  "c": true
}

Probably an error in their zero value in the document package

I've added this for the current milestone.


Update jelly.py

faster shifts

That seems a bit faster, although the difference isn't really that big.
I've merged, but I had to add floor = True to the division to replicate the old behavior.

Well, in Java, a%2 is significantly slower than a&1, so I thought that would be the same for python...


fix: Add gax-grpc dependency for native image configurations

It was just missing gax-grpc dependency... Nice fix.


Label text not updated after calling open_settings()

Software Versions

Python: 3.9.2
OS: WIN32 and Raspberry Pi (bullseye)
Kivy: 2.2.1
Kivy installation method: pip install kivy

Description:
After calling open_settings(), label texts are no longer updated on the screen. In the background the values and text properties do change and the color property will be updated, but the GUI still shows the text as it was before the first call to open_settings()
This gist shows the effect using the pong example expanded by a settings object and the call to open_settings() whenever player2 scores. All is well until the first time open_settings() is called, i.e. the label texts and colors are being updated after a score. However, after the first open_settings, only the label colors will be updated:
https://gist.github.com/avonderlieth/12669a4b4ff68da8a09662c29927763f
This is just an example to illustrate the behavior. My original project (much larger) was working with Kivy-1.9.1 but after a (forced) upgrade to 2.2.1 the code was no longer working. The behavior is present in both WIN32 and Raspian (bullseye)
Expected behavior
label text and label color are being updated after a score
To Reproduce
See example in gist

I was able to replicate the issue on Windows 11, using the default kivy settings screen.  Here is a minimal reproducer.  While the F1 key can be pressed to open the settings panel, I added a button to as well.
The clock continues to run, but the screen does not update.  Note that setting the text attribute of the Label in the callback shows the same behavior.
from kivy.app import App
from kivy.lang import Builder
from kivy.clock import Clock
from kivy.properties import NumericProperty

kv = """
BoxLayout:
    orientation: 'vertical'
    Label:
        id: label
        text: str(app.count)
        font_size: 60
    Button:
        size_hint_y: None
        height: dp(48)
        text: 'Open Settings'
        on_release: app.open_settings()
"""

class CheckSettings(App):
    count = NumericProperty(0)

    def build(self):
        return Builder.load_string(kv)

    def on_start(self):
        Clock.schedule_interval(self._count, 1)

    def _count(self, _):
        self.count += 1
        print(f'Count is now {self.count}')

CheckSettings().run()

Interesting the bug does not appear if kivy.uix.settings is imported prior to opening the settings panel:
@avonderlieth this is a potential workaround to your issue.
I've extended the example to put the settings panel beside the Label so I could better see when the change was occurring.
from kivy.app import App
from kivy.lang import Builder
from kivy.clock import Clock
from kivy.properties import NumericProperty
from kivy.uix.popup import Popup
from kivy.uix.label import Label
import kivy.uix.settings  # BUG does not occur if this line is here!

kv = """
BoxLayout:
    BoxLayout:
        orientation: 'vertical'
        Label:
            id: label
            text: str(app.count)
            font_size: 60
        BoxLayout:
            size_hint_y: None
            height: dp(48)
            Button:
                text: 'Popup'
                on_release: app.pop()
            Button:
                text: 'Open Settings'
                on_release: app.open()
    BoxLayout:
        id: box
"""

class CheckSettings(App):
    count = NumericProperty(0)

    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        self.settings_popup = None
        self.popup = None

    def build(self):
        return Builder.load_string(kv)

    def display_settings(self, settings):
        self.root.ids.box.add_widget(settings)
        return True

    def close_settings(self, *args):
        self.root.ids.box.clear_widgets()

    def on_start(self):
        Clock.schedule_interval(self._count, 1)

    def _count(self, _):
        self.count += 1
        print(f'Count: {self.count}')

    def open(self):
        self.open_settings()   # added to use as a breakpoint

    def pop(self):
        p = self.popup
        if not p:
            self.popup = Popup(content=Label(text='Pop'),
                                        title='Not Settings',
                                        size_hint=(0.8, 0.8))
            p = self.popup
        p.open()

CheckSettings().run()

Interesting the bug does not appear if kivy.uix.settings is imported prior to opening the settings panel: @avonderlieth this is a potential workaround to your issue.
I've extended the example to put the settings panel beside the Label so I could better see when the change was occurring.

Hi Elliot,
thanks a lot - this works. Just some additional comment: it appears that the import kivy.uix.settings statement needs to come AFTER setting the graphics config "fullscreen" to "auto" or else this will not be set (at least in my example it didn't).
In case someone else is having issues with this, another workaround is to remove the widget and re-creating it after closing the settings (though @ElliotGarbus fix is much nicer).
Thanks again.

Fixed via #8535


Add HighGear

We've been using F# for major components of our software since 2012. We don't use it for everything, as our application is very large, but we're fully committed to F# as an organization and use it as much as we can. If that is acceptable for the purposes of this list, I'd like to add HighGear please!

That's more than enough! Thanks for your contribution!


EnabledDates like DisabledDates

I was wondering if there could be something like enabled dates , an  array, like disabled dates, that would only enable the stated dates while all other dates would be disabled.
Thanks.

With this version this feature is not supported. You will be able to disable any number of days as per the need, and you will be able to disable weeks also.


Pass command options to changeset

We could provide command options while constructing a changeset object. For now, options are not passed down to the command being built inside the changeset.
Examples
When result is supposed to be :many instead of the default :one value for the command:
rel.changeset(:delete, command_options: { result: :many } )
# or directly
rel.changeset(:delete, result: :many )
# or
rel.changeset(:delete).with_command_options(result: :many)

Right now, it is not possible with the current changeset implementation (arguments are considered data, see this file) so we have to circumvent:
c = rel.changeset(:delete)
c.command_options[:result] = :many
c.commit

Note: Following a discussion on zulip with @solnic
https://rom-rb.zulipchat.com/#narrow/stream/191800-general/topic/rom-sql/near/193048419


[QA] unsolicited sharing

Setup via docker-compose-eos-test.yml from branch fix-yml-for-rc5 on localhost
From the WEB UI:

login as einstein
login as richard
"perform several other tests"
richard creates a folder 'sub' and enters that folder.
richard uploads several files and is surprised that these files are shared with einstein
einstein double checks, and no, he does not see them.

Note that this happens outside of the Shares folder.
Note how richard has advanced permissions on the just uploaded files.
Sorry, no idea how to get into this situation. Maybe the logs have a hint:

ocis.log.zip

https://github.com/cs3org/reva/pull/1302

Please re-open if not fixed.


"ibazel run" and "bazel run" of a nodejs_binary rule execute in different working directories

Describe the bug
"ibazel run" and "bazel run" of a nodejs_binary rule execute in different working directories. When running via bazel, the rule executes in the bazel sandbox, but with ibazel, it runs in the workspace directory.
Reproduction instructions
logdir.js
console.log(__dirname);

BUILD
nodejs_binary(
	name = "logdir",
	entry_point = "logdir.js",
	data = [
		"logdir.js"
	]
)

Steps to reproduce the behavior:

In a bazel project using nodejs_rules, create the two files above
Run ibazel run //src/path/to/folder:logdir and observe output
Run bazel run //src/path/to/folder:logdir and observe output

Expected behavior
Logged directory in both cases is the sandbox directory (e.g. C:\users\user\_bazel~1\6n4rhrox\execroot\repo~1\bazel-~1\x64_wi~1\bin\src\path\to\folder\logdirba~2.run\net_bu~1\src\path\to\folder
Actual Behavior
bazel's logged directory is in the sandbox as expected, but ibazel's logged directory is in the source tree
Version (please complete the following information):

OS: Win 10
ibazel Version: 0.15.10
Bazel version:

Bazelisk version: v1.10.0
Build label: 4.1.0
Build target: bazel-out/x64_windows-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Fri May 21 11:17:01 2021<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

Nit: It's not running in a sandbox directory, but rather the executable's execution directory, which is <executable>/<workspace>.
It should be relatively straightforward for ibazel to execute the process in this directory as well.

Ah yeah, thanks for the correction there.

ibazel run only runs bazel run on behalf of the user, it doesn't do anything special with working directories or anything like that. I am reluctant to implement something like this, because it means that people using ibazel run would have a different experience from people running bazel run which will lead to all kinds of confusion in other ways.
If you'd like this behavior, it would be best to contribute it back to the rules_nodejs project, or modify the main of your program to read the environment variables and behave accordingly.
If you think I'm totally off base here, please reopen the bug and let's talk about it.

I'm not requesting this behavior, I'm saying this is the behavior I'm seeing, and I don't want it. I want bazel run and ibazel run to be identical, but they are not.

I'd reopen, but I'm not sure how to, haha.


Static code analysis

Static code part

Hi, I'm in CI integration, I have a question about .nrvm file requested in workshop, I don't know were I have to create is in github or I create into root in vscode.
Also Is necesary  install all dependencies previously installed to run cypress test like the cypress itself.
I think that this CI I can run only every PR I made.


Export

Is your feature request related to a problem? Please describe.
Then sharing details about network issues I have to copy each measurement's data individually.
Describe the solution you'd like
In results panel an 'Export as CSV' option next to 'View' and 'Delete'. If any results are selected to export only selected.
Additional context
It may be a part of #294
Bonus: It would be cool if a report or a PNG could be generated for a period. Something similar to what speedtest does. It would be something easily sharable to compare with other user's in neighbouring networks to figure out if it's a local problem only.

I like the distinction for only exporting selected records. Export is what I'm currently working on so it'll be coming soon.


getDuration method returns 0

Hi, I can't retrieve the duration at all typing:
wavesurfer.getDuration();
All other methods work correctly instead.
any idea?

It may be caused by bad/missing headers in the audio file.

Related to #505?

This can occur if you're attempting to retrieve the duration before wavesurfer fires its ready event. See codepen: http://codepen.io/chrisparton1991/pen/EKpNxq.


Updating viper.js for snowplow and Pardot support

This update adds snowplow functionality to viper, which replaces the snowplow functionality in Tealium. This also manages the movement of data in Pardot pages, populating hidden form fields with utm variables for PCT, and taking a catID from the query string and creating a cookie from the data.  This also adds technical documentation for the mailstore_viper_config.js and for the release notes.

The error in processing is still due to an issue where we are using Karma v0.13.x and travis wants Karma v0.13.

+1!

+1


For custom components how to using prop "label" ?

I'm using Quasar with BlitzarForm, and want to use the q-input as a custom component.
However, Blitzar uses label to create its own label over the component. How would I pass label to the custom component rather than to Blitzar?

Nevermind, dug through the other issues a bit more and found a solution here
Best! And thanks for an awesome library!

good luck!
--Blitzar was made with 💜 by Luca Ban.You cannot sponsor every project, but next time you do, think of this one for its prolonged maintenance.


Fixing some rules & optimizing comp drc table

Enhancing the implementation of some drc rules in comp table

@FaragElsayed2 Could you please add some screenshots of violations in the description?

Could you please clarify what do you mean by violations here ? Is that mean DRC violations ?

@FaragElsayed2 Also, could you comment on speed? It's advisable to run in deep mode.

Before [61 min]

After [30 min]

I think we could optimize it more.

@FaragElsayed2 yes

Reimplementing DF.13 & DF.14 rules

Old implementation used sizing operation to detect maximum separation and this doesn't work for singular cases

For DF.13_3.3V as example:

Testing (old imp):

Testing (new imp):

More optimization is added for all rules & changes required are added.


METAMODEL-1210: Module to read .arff files

It's been a while and I could self-merge it based on "lazy concensus" but I'd love it if someone took a quick glance at this.

A short scan showed nothing worrying. It's rather self-contained, so I guess we can make a quick merge.
Interesting file format, btw!

Thanks for checking it @LosD. Merging! :-)


core.setSLMImage(java.lang.String slmLabel, byte[] pixels) doesnt work

maybe fixed by: https://github.com/micro-manager/micro-manager/pull/991 and https://github.com/micro-manager/pycro-manager/pull/174, but I don't have ability to test.
Misha?

Hi Henry,
I just upgraded my version of Pycromanager to 0.5. However, when I tried to use the SetSLMImageTo method, I was given an error:
'NoneType object is not subscriptable'.
I tried this with many different image formats - numpy arrays (dtype uInt32), lists, bytearrays, etc. What was the format that the method expects for the image?
Thanks for the help!
Misha

Also, attached is the file I've tried running, as well as the different image formats I've tried to use.
slm_v3.txt

Is the PIL Image a numpy array? the im in core.setSLMImage(DMD,im) should be a numpy array with shape (n,) where n is the number of pixels with dtype of uint8, uint16, or uint32, which correspond to java byte[], short[], or int[]. The uint8 version was the one I just fixed, but that change hasn't gone through yet into the nightly builds. So if you want to use it, you need to drop in pycromanager 0.9.5 to replace whatever version you have in the plugins/micro-manager directory of your micromanager install. Also, before you do any of this, you should upgrade to the latest nightly build of micro-manager

Thank you for walking me through how to integrate the updated version of pycromanager. I've updated to the 102620 nightly build of micromanager, and replaced my 0.9.3 version in the build with the 0.9.5 version you linked. I changed the image that I'm uploading to a uin8 using the matplotlib image reader. I think I'm close, as the error I'm currently getting:
java.lang.Exception: Image dimensions are wrong for this SLM.
mmcorej.MMCoreJJNI.CMMCore_setSLMImage__SWIG_0(Native Method)
mmcorej.CMMCore.setSLMImage(CMMCore.java:1396)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:498)
org.micromanager.internal.zmq.ZMQServer.runMethod(ZMQServer.java:337)
org.micromanager.internal.zmq.ZMQServer.parseAndExecuteCommand(ZMQServer.java:393)
org.micromanager.internal.zmq.ZMQServer.lambda$initialize$1(ZMQServer.java:102)
java.util.concurrent.FutureTask.run(FutureTask.java:266)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
java.lang.Thread.run(Thread.java:748)
Which points towards the wrong value for n. However, I think n is correct as I flattened the image (that has the dimensions equal to the height/width of the SLM) so I think n is correct. I've attached the updated file here. What do you suggest?
slm_v4.txt

Okay so it seems that the array is correctly making it from python to the Java side, but as you say the size is wrong. I'm not familiar with that imread function. What if you generate a test array like this:
h = get_slm_height(DMD)
w = get_slm_width(DMD)
im2 = np.random.rand(h * w).astype(np.uint8)

Also I dont know if uint8 is correct. What does core.get_slm_number_of_components(DMD) return?

and also core.get_slm_bytes_per_pixel

Agreed - there is a bug somewhere on the Java side. I tried generating a test array the same way you did - but I got the same error (Image dimensions are wrong for this SLM.).
for core.get_slm_number_of_components(DMD) the return was 1
for core.get_slm_bytes_per_pixel(DMD) the return was also 1

Is there a Java method for finding the number of pixels the SLMImage method needs?

it might be some improper conversion of numpy arrays to java arrays. Next thing to try would be to see if you can set it from the java side (i.e. in a beanshell script). Something like
pixels = new byte[mmc.getSLMHeight(DMD) * mmc.getSLMWidth(DMD)];
mmc.setSLMImage(DMD, pixels);

and then see if the size matches between java and python

That worked. Here is the beanshell file I used:
test_um_v1.txt
So it must be something to do with numpy to java array conversion.

Okay, will take a look

+1 for solving this, I'll be wanting to use this soon.  Thanks!

Thank you Henry! If there's anything I can do to help, let me know.

I think this should fix it: https://github.com/micro-manager/pycro-manager/pulls?q=is%3Apr+is%3Aclosed
Could you give it a try? You'll need to both upgrade to 0.10.0 and install pycromanager 0.6.0

@nicost could you merge this: https://github.com/micro-manager/micro-manager/pull/991 when you get chance? I had to make some potentially backwards incompatible changes in the bridge so pypi version and nightly builds might not work together until it goes in

Done!  Not sure if it makes it in tonight's build, but certainly tomorrow.  Thanks for your work on this @henrypinkard !

@henrypinkard @nicost I just updated to 0.10.0 and installed the latest version of pycromanager, and the setSLMImage worked! Like you said, as long as the image is a uint8 np array of length (n,) with n being the number of pixels, the image was successfully passed to the java backend. Thanks again for all the work towards fixing this bug.

Awesome! let me know if you run into anything else

Hello @henrypinkard , I have run into what seems to be the exact same problem. I am trying to display an image on a Mightex Polygon400 with the set_slm_image function in pycro-manager and get the same error message about the image dimensions. With the above beanshell script it worked though and set_slm_pixels_to works as well. I also checked the type and shape of the array that I pass.
What confuses me is that I am using pycro-manager 0.10.13 and one of the latest MM2.0 builds of the last weeks, even though this issue occured and was fixed versions before that.
Do you have any idea what I or the program might be doing wrong?

Looks like a bug was introduced when I changed some underlying stuff to improve speed. Should be fixed in https://github.com/micro-manager/pycro-manager/pull/261.
If you go here and download the latest pycromanager-java jar, and replace the previous version in your plugins/micro-manager folder in your micromanager install directory, that should give you the fix

It did indeed. Thank you for your work!


(ArgumentError) no extension found for oid '8661175'

I recently started working on a Phoenix app that shares a Postgres DB with an existing Rails app. The Rails app has a table that I am trying to also access in the Phoenix app called drivers, which has a geo_location column that is a PostGIS point.
Rails schema.rb:
create_table "drivers", force: true do |t|
  ...
  t.spatial  "geo_location", limit: {:srid=>4326, :type=>"point", :geographic=>true}
  ...
end

The Rails app has been working fine with this in development, the geo_location correctly gets stored and the PostGIS extension is definitely enabled on the db.
When I try to connect to the same table via my Phoenix app, I get (ArgumentError) no extension found for oid '8661175'
mix.exs
  ...
  defp deps do
    [{:phoenix, "~> 0.14"},
     {:phoenix_ecto, "~> 0.5"},
     {:postgrex, ">= 0.0.0"},
     {:phoenix_html, "~> 1.1"},
     {:phoenix_live_reload, "~> 0.4", only: :dev},
     {:comeonin, "~> 1.0"},
     {:geo, "~> 0.13.0"},
     {:cowboy, "~> 1.0"}]
  end
  ...

config/dev.exs
config :my_app, MyApp.Repo,
  adapter: Ecto.Adapters.Postgres,
  username: "postgres",
  password: "postgres",
  database: "my_db",
  extensions: [{Geo.PostGIS.Extension, library: Geo}],
  size: 10 # The amount of database connections in the pool

web/models/driver.ex
defmodule MyApp.Driver do
  use MyApp.Web, :model

  schema "drivers" do
    field :geo_location, Geo.Point

    field :created_at, Ecto.DateTime
    field :updated_at, Ecto.DateTime
  end
end

My attempt to connect via iex:
iex(4)> MyApp.Repo.all(MyApp.Driver)
** (ArgumentError) no extension found for oid `8661175`
    (postgrex) lib/postgrex/types.ex:282: Postgrex.Types.fetch!/2
    (postgrex) lib/postgrex/types.ex:215: Postgrex.Types.format/2
      (elixir) lib/enum.ex:977: anonymous fn/3 in Enum.map/2
      (elixir) lib/enum.ex:1261: Enum."-reduce/3-lists^foldl/2-0-"/3
      (elixir) lib/enum.ex:977: Enum.map/2
    (postgrex) lib/postgrex/protocol.ex:124: Postgrex.Protocol.message/3
    (postgrex) lib/postgrex/connection.ex:408: Postgrex.Connection.new_data/2
    (postgrex) lib/postgrex/connection.ex:309: Postgrex.Connection.handle_info/2

Any guidance is greatly appreciated

I've done a little digging and found out that the geo_location column is stored as a geography in PG. I assume this is why the error is occurring.
Is it hard to support both geometry and geography types? I'd try to submit a PR for this, but not sure I understand the concepts enough to do it properly.

Ah, yes the geography data type isn't yet supported, but doing a quick search I see that they are related and it might not be much work to add support for it. The basic idea would be to add another struct for geography, add more pattern matched functions in geo.postgis.extension and add another ecto type for geography. I think most of it would be copying what is there for geometry. I say that without knowing how geographies are returned in queries.
That may give you a high level idea of what's needed. I'll also take a look later tonight to see how simple it would be

Ok, yeah it won't be a big deal to add support for it. Since geographies are basically just geometries, they could both use the Geometry struct for the time being if that won't be too confusing?

Yeah, that sounds reasonable. Thanks for looking into it.

I just updated master with the change.
You can update the geo dep to use the version from github for now to see if it works out for you
{:geo, github: "bryanjos/geo"}

Like a charm! Thanks for the fast turn around.

Awesome! I'll update the docs and put another version into hex pretty soon as well.

Fyi, I updated the version in hex with the change
{:geo, "~> 0.14.0"}

Great, thanks.


Missing Mixer in the picture

Need policy and telemetry :)

oops.. fixed.. thanks for spotting that.


Error: Cannot find module '../../../utilities/find-up'

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Linux Ubuntu 16.04
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

    throw err;
    ^

Error: Cannot find module '../../../utilities/find-up'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/alex/node_modules/@angular/cli/packages/@angular/cli/ember-cli/lib/models/project.js:8:63)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

For node --version:
v6.10.0

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

Install the last version of angular-cli: v1.0.0-rc.0
The log given by the failure.

Normally this include a stack trace and some more information.

module.js:471
    throw err;
    ^

Error: Cannot find module '../../../utilities/find-up'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/alex/node_modules/@angular/cli/packages/@angular/cli/ember-cli/lib/models/project.js:8:63)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

@alxhotel Did you follow the updating guide? https://github.com/angular/angular-cli#updating-angular-cli

@sumitarora Yep. Same error.

It really looks like you have a broken install somewhere. I can't reproduce this myself either.

Running this command fixed my problem:
rm -rf ~/node_modules/@angular

Nope. I've been getting this error consistently. Reinstalled Node. Reinstalled Angular CLI
Windows 10


has critical status: ErrImagePull. DevSpace will continue waiting, but this operation might timeout

while trying to use aws ecr for image I get
has critical status: ErrImagePull. DevSpace will continue waiting, but this operation might timeout

I think I can close this I was using a wrong python image


Heavy battery drain.

Setup:

Android 5.1 (CM12.1)
GSMCore 0.2.2 from microG, as a replacement for Google play services. (https://github.com/microg/android_packages_apps_GmsCore)

I recently switched to the microG apps/services instead of the Google play ones.
On my mobile there is a heavy battery drain by matrix.
For me it seems, that the app is not really using the GCM service, bit is using the provided notification service instead.
Is there some kind of fallback to the notification service if there are issues with GCM?
Note: On my tablet, I don't have this issue with the same setup. But as the tablet is losing the Wifi connection sometimes during the day, I'm not sure if the two devices are comparable.

The issue got fixed by the vector-android guys.
So this one can be closed.


More maintainers needed

This project needs more maintainers. Are you willing to contribute? Please reply on this issue, or send me a message directly.

Not sure if I could commit to maintaining, but definitely interested in contributing!
Not really experienced with Vite, but very willing to dive in ;)

I might chime in soon as well.

Happy to try and help -- I saw recent storybook post saying pluggable builders are coming but nothing official.
Our team are vite + tailwind JIT + vue3 and the WebPack/storybook misalignment causes headaches

@17twenty That's great! If you run across any problems, you can open PRs here! Just send me a message if you're stuck with setting up the dev environment.

I'd love to help developing this in free time. I have little experience in bundlers space so it'd be great if you could give me some tips and resources to read

What you should do is join the Vite (https://chat.vitejs.dev/) and Storybook (https://storybook.js.org/community) spaces in Discord. In Vite land, there are some channels, like #dev-server and #ssr that are helpful. There is a #vite channel in the Storybook discord. Run a git clone of the Vite source code if you need to dig into its internals. It's also nice to clone the Storybook source code if you need to look at its internals, or make adjustments.
For this repo, run a git clone, npm install, and you should be good to go! You can tweak the example project (or create another example project for Vue or whatever), and they should run with the local Storybook builder.

@17twenty have you been able to get storybook-builder-vite working with vue3?  Have you hit any snags?

@eirslett Don't know much about storybook, but willing to contribute by looking into issues regarding vite. Thanks

@soulsam480 That's great! The most valuable contribution at this time is probably people who use Vite for their production Storybook, and finding bugs that happen in more complex scenarios. And then send bug fixes!

Are there any plans to rewrite things in typescript?

Are there any plans to rewrite things in typescript?

Not right now. We could, but (in my opinion) it's easier to use JavaScript in the backend/with Node.js because we don't need transilation or ts-node, and debugging/breakpoints is more ergonomic.
If TypeScript gives us a lot of value, we could use // @ts-check and JSDoc?

Typescript is not only about types, it's also about features that are not yet added in JS and the possibility to target specific versions of JS during transpile.
Regarding the ergonomic of running or debugging, I don't know how long has past since you last gave it a shot but things have dramatically change and debugging TS is completely transparent nowadays.
Now will those things bring value to the project, it's up to you ;)

Last time I tried stepping through/debugging TypeScript code was 3 months ago. I was writing this plugin and tried to figure out what was happening internally inside Storybook (which is written in TypeScript). I ran the server code via IntelliJ, and for me it was a painful experience. Which is why this project uses JavaScript. But I'm sure we could switch to TypeScript if somebody writes a good documentation about how to set up a good/ergonomical development environment for storybook-builder-vite! I use TypeScript in my daily frontend work in the browser, I love the language, but like mentioned, I had problems with it in backend code.

Happy to help on some of it if needed, I however don't have a major level of experience with vite. I will however try and help with some of the issues.

I'm also happy to lend a hand :)

I'm happy to help :) I've had a lot of fun digging into vite and storybook.

I'm happy to help 👯

Thanks!  I think the best thing that people can do right now is to test out the builder in their own projects, looking for problems or rough edges.  Aside from that, we have a few issues in the tracker that could use some investigation and troubleshooting, and we'd love any help you can give there.  We're on the storybook discord in the #vite channel throughout different parts of the day, so feel free to pop in and chat there, as well!

Happy to help solve any issues. We about to integrate core plugin this into nxext . So happy to help make this great

I will be glad to help to simplify the development process, more information in #188.

Hey! I would like to help! :)


Add logic for reflowing lines

Connects to #622
I believe this approach will be more stable and easier to manage than the one previously proposed in  https://github.com/sourcelair/xterm.js/pull/609
One thing I realised after working on the previous reflow PR was that you have a lot of instances where input intentionally writes over EOL and then expects to overwrite the wrapped characters using a carriage return or CSI Ps ; Ps H.
Using the dynamic reflow I had proposed previously, it's very difficult to compensate for this behaviour without a lot of trickery.
As it stands this PR appears to work very well, though I'm sure that it needs more testing.
I'd greatly appreciate people trying to break the implementation and then posting their feedback here.

Looks very good, I could only find one last bug, which seems to happen when the input line is wrapped after a resize. It is a little hard to reproduce, but I've been able to capture a video that demonstrates the bug. You can see that I enter lots of text into the input line, then i resize and the characters are shown incorrectly. I then resize back and everything is back to normal. I then run top, and after quitting top you can see that the last line of the top output is not cleared. I then hit enter until I would probably overwrite the uncleared line, but in that moment I get an exception.

Here's the full video that demonstrates my way down to the exception:

Here's a much simpler way to reproduce (hopefully) the same bug as @mofux mentioned:
Platform: macOS 10.12.4, stable Chrome 57, node v7.7.1
Steps:
0. Open xterm.js demo

Change current directory to the root of xterm.js
vim README.md
Change cursor to line 9 column 11 (on the letter "s" of "## Features")
Change column size to 91

Expected:
Resize to 91*24 and the cursor should be still on letter "s".
Actual:
An exception is thrown. Then xterm.js doesn't response any more.
Stack trace:
InputHandler.addChar (InputHandler.ts:88)
Parser.parse (Parser.ts:221)
Terminal.innerWrite (xterm.js:1280)
(anonymous) (xterm.js:1259)
setTimeout (async)
Terminal.write (xterm.js:1258)
term._getMessage (attach.js:64)

Opening in vim and fiddling with the size seems to break the normal buffer when you exit:

Notice the scrollbar, scrolling it does nothing.

@Tyriar @mofux The issues you came across should be resolved in the latest commits.
I'll update the PR with comments and descriptions later.

@Tyriar
How wrappedLines works -
When a line wraps, we store the line index in an array. When reflowing, we look up the index and if the line was previously wrapped we join it to the next line and then chunk it to the new width.
How WrappableList.transform works
Loop over every line in the list and chunk it to the new width, then each chunk is pushed into a new array. If the line was previously wrapped we join the next list item and then chunk the combined line.
The internals of the list are updated to use the new array.
What the changes in InputHandler do
Logic has been added to the InputHandler to mark a line as wrapped if it overflows onto the next line. This allows lines to unwrap when you increase the width of the terminal.
resize is now called when we switch back to a normal buffer from and alt buffer, forcing a reflow calculation. This has required the addition of a force parameter on the resize method, that will force the function to run even if the cols and rows haven't changed.
An additional change that has been made is to change blank character cells from ' ' to null. This has no effect on the renderer but helps differentiate between cells that have been added to pad lines and those that are written to the screen by program output.

@Tyriar I've made some good performance improvements. 👍
I'm testing the time it takes to run the resize command to resize the terminal between 20 and 21 lines after running grep -Rl ' ' . :

With a scrollback of 10000 resize time is down to around 30ms.
With a scrollback of 5000 resize time is around 11ms.

Running the same tests, but resizing between 40 and 41 cols:

With a scrollback of 10000 resize time is down to around 22ms.
With a scrollback of 5000 resize time is around 8ms.

@LucianBuzzo I sat down yesterday, studied the code and looked at how we could scale the code a little better by first breaking down the problem again now that we have a better understanding and looking at how we could solve it by doing minimal work on get/push and resize operations.
FYI I checked after your recent perf improvements and am still seeing 300+ms resizes sometimes

Repro steps:

Set scrollback to 10000
Run ls -lR ~
Resize 81 -> 40

Even with these improvements while they may be fine for most users, I think it's still an unacceptable performance regression in VS Code as the team and our users are particularly sensitive to performance issues. Another aspect of VS Code and likely other apps is that multiple terminals will be resized at the same time. Therefore I'm a little reluctant in pushing as it would prevent us from pulling the latest xterm.js.
The community work on this issue has been invaluable so far though as we have a much clearer view of the problem now.
What we need

Wrap lines when reducing width
Unwrap lines when increasing width
Scroll bar needs to support wrapped height
Don't change the way input interacts with the buffer - when an escape sequence operates on row x, it should operate on the unwrapped row at x

Issues with current implementation

Accessing private properties on CircularList could lead to instability. This essentially obsoletes the unit tests on CircularList for how we're using it and makes it more difficult to maintain going forward.
A lot of costly array/string manipulation inside reflow.

Proposal
WrappableBuffer's state
I'm proposing we change WrappableBuffer to store the start index of the row
CircularList     WrappableBuffer where size = 4
[0]: "abcdef"      [0]: 0
[1]: "abcd"        [1]: 2
[2]: "abcdefgh"    [2]: 3

With this we have a basic model of the wrapping with minimal information. For fast access of the actual rows we will also want WrappableBuffer to have a map going the other way:
WrappableBuffer.wrappedToNormalIndex
[0]: [0, 0]
[1]: [0, 1]
[2]: [1, 0]
[3]: [2, 0]
[4]: [2, 1]

These two arrays are all that will be evaluated when the terminal is resized, so the resize of WrappableBuffer will look something like this:
resize(width: number) {
  // Lots of optimization potential here
  this.normalToWrappedIndex = new Array(this.circularList.length);
  this.wrappedToNormalIndex = new Array(this.circularList.length);
  let currentNormal = 0;
  let currentWrappedCount = 0;
  for (let i = 0; i < this.circularList.length; i++) {
    const line = this.circularList.get(i);
    const wrappedCount = Math.ceil(line.length / width);
    this.normalToWrappedIndex[i] = currentWrappedCount;
    for (let j = 0; j < wrappedCount; j++) {
      this.wrappedToNormalIndex[currentWrappedCount + j] = [i, j];
    }
    currentWrappedCount += wrappedCount;
  }
}

Retrieving rows
Since we're only doing the above on a resize we need to actually serve the wrapped rows somehow. This can be done at the time the wrapped row is requested with WrappableBuffer.getWrapped at which point we can cache the chunked row and store it for later use since string construction is relatively expensive.
When the line's wrapped state changes we can discard the cached chunked row.
Composition over inheritance
In order to prevent future misuse let's use a member variable instead of extending and have both CircularList and WrappableBuffer share the ICircularList interface.
CircularList`s internal changes
To deal CircularList's trimming mechanism we could have CircularList extend EventEmitter and throw an onTrim(count: number) event and act accordingly in WrappableBuffer (probably by storing an offset to add to the indexes).
If there are any other internal movement that WrappableBuffer needs to know about it could be exposed in an event.
Exposing both wrapped and unwrapped buffers
I believe we want to expose both wrapped (getWrapped?) and unwrapped buffers (get?) as escape sequences should be operating on the unwrapped rows but we want to display the wrapped rows.
Scrollback
Currently it's a little ambiguous what scrollback means, in the new solution scrollback would strictly define the number of unwrapped rows.
Result
Here's a once over of the ICircularList interface summarizing the changes that WrappableBuffer would make:

length: Similar to CircularList but changes on resize
maxLength: Computed based on CircularList.maxLength and WrappableBuffer.length;
forEach: Little change
get: Create and cache wrapped row
set: Re-evaluates wrapped state of all rows after the current row, this will typically only be called towards the end of the buffer
push: Evaluate wrapped state of new row
pop: Remove row
splice: Like set, should only be used near end of buffer
trimStart: Will throw an event in CircularList
shiftElements: Evaluate wrapped state of new rows, reuse when possible

@LucianBuzzo let me know what you think. You're of course under no obligation to implement this but I'm very interested to hear you thoughts.

@Tyriar The issue that I think you will run into with this approach is that there are a number of behaviours where characters are expected to wrap and then written over with a carriage return or an  escape sequence.
This makes handling "unwrapped lines" very tricky, as you can't tell wether you are dealing with an over long line or characters that are intentionally being sent to trigger a linewrap.
For example, when writing a very long prompt input that wraps, you're sent a string that contains a duped character write before the \r which is then expected to be overwritten by the following character because the terminal has wrapped onto the next line.
I think you can get around this by clever management of how you handle incoming linewraps, but it's something to consider.

@LucianBuzzo that case where a character is duplicated before the \r, how did you end up handling that in your approach?

@Tyriar in my previous PR I never resolved the issue. I couldn't think of a robust way of handling these cases whilst taking the approach of ignoring the terminal width and storing the line data in an unwrapped state (I believe that is what you are proposing?). In this PR it's a non issue as we wrap lines when they go over the terminal width.
I think there's a possible approach where your line "source data" includes the line wraps for whatever width it was set at, and then we do on-demand reflow for the lines being rendered.

@Tyriar I've just tried using the latest branch in vscode with a 10000 line scrollback (full as well) and it works really well.

@LucianBuzzo I definitely see the difference (2 terminals, 10000 scrollback):

Also 46 tests are failing. https://travis-ci.org/sourcelair/xterm.js/jobs/228226085 @parisk Travis isn't erroring out :confused:
I'm going to have a look at perf improvements on top of your stuff now.

Was trying to get a quick proof of concept together of my design. Was running into a bit of an issue when wrapping get since the array returned is modified in multiple places, so slicing the array to get a subsection of it doesn't work.

@LucianBuzzo I put out a PR against your branch to clean up some types https://github.com/LucianBuzzo/xterm.js/pull/2

@Tyriar Should I keep working on this and sort the tests out?

@LucianBuzzo currently I don't think we can accept this until resize scales better and the problems with the design are fixed (breaking the private API of CircularList, scrollback increasing permanently on a resize) as they represent technical debt we would be taking on.

@Tyriar WRT the resize functionality scaling better, what are the benchmarks that you want to hit?
You had previously mentioned resizing a 5000 line scrollback in under a frame (~16ms?) - is this still the case?

@LucianBuzzo I was testing 1-2 terminals with 10000 sized buffers within VS Code. The issues with the scaling are:

At least in VS Code we will resize multiple terminals at once when resizing the window, multiplying the slowness of the function
With a single 10000 sized terminal buffer I was getting 300ms+ pretty consistently on a reasonably specced machine. For example see https://cloud.githubusercontent.com/assets/2193314/25672106/2ac1878c-2fe7-11e7-9595-e7c37325fba2.png which shows that it pushed the frame out to 1445ms
Resizing of the terminal happens not just on window resize but also when resizing the sidebar, toggling the activity bar, moving the window around at an OS-level
This also impacts battery life negatively if we max out the CPU for so long

It's difficult to define an exact benchmark, basically I would like to see a single terminal resizing in as little time as possible. Something more like < 30ms to resize a 10000 buffer while being hosted within VS Code (on my apparently slow machine).
But it's not the only issue with the implementation, the reaching into CircularList's implementation is a pretty big no-no and represents work that would need to be done on our side to fix it, and it doesn't really have an easy solution. For example I'm working on redoing how selection is handled which needs to modify the implementation of CircularList, this will break the reflow logic as it makes assumptions about the form of _array that will be broken.

@Tyriar Your comment reads like a dead-end for this PR. I understand your concerns, but I feel a lot of work and ideas that went into this PR and its previous iterations could lay the ground for a re-implementation from your side. I believe you will have to take the lead on this, as this feature has a direct dependency to the virtual selection and the link matcher (multiple lines) features, and you're the only contributor who has an insight knowledge about all of them.

@mofux unfortunately yeah. While this whole thing has been very valuable as we've learned a lot. I'm definitely going to do a better job in looking into how hard something is before encouraging PRs on it, I had no idea this would have been so hard and touching so many things until I started reviewing the PRs.

@Tyriar I've given this some thought and updated this PR with an implementation that attempts to resolve the issues you've described here.

Scrollback will no longer increase over its original size
The CircularList internal implementation is not used (or assumed)
I can see noticeable performance improvements (tested in VScode)

In theory, this means that there should be no conflict with the line selection work you are doing.
This is a rough draft and can certainly be improved on.
If you think this is moving in the right direction let me know.

ping @Tyriar ^^

Pretty flat out with work at the moment, will have to defer evaluating the changes for a bit.

@Tyriar Of course, no problem!

Closing this as it's not going to get merged for performance/design reasons and it's really out of sync now. It is very useful as a reference though so I've pulled some of the key findings out into https://github.com/sourcelair/xterm.js/issues/622


Add semantic themes to website

Description
Added a local version of semantic ui to allow the use of the overriding of variables to add customization to the semantic CSS.
Verification Steps
IMPORTANT To verify this PR it should work as normal load the index.html in your favorite browser to see the mount sion blue nav bar.
EDIT: New Steps to Verify or Change Semantic CSS
If you wish to customize semantic and play around with the themes you will need to follow the following steps.

Install Node (Latest long term support version)
Once you got node installed you will need to install gulp via the node package manager:

$ npm install -g gulp

With gulp installed globally navigate to the root directory of the project and run the following command in order to install the required node modules for semantic
$ npm run build:semantic

Now you are ready to go. If you navigate to semantic/src/site/site.variables here you can edit the color of blue or set other variables, see the semantic docs for more info on this.
Any changes you make to these variables will require you to rebuild the semantic CSS and this can be done in the following directory semantic/ by running:
$ gulp build

This will kick off the build and then you will see the changes in your browser, just use semantic as normal in the regular html.
I will document the steps in another PR, it is import to get this merged as soon as possible to allow all order PR's get rebased off of and get use of the new colors and any other changes we want to make to semantic

@laurafitzgerald yeah sure, its the site.variables file here. Any of the colors can be overriden from that file, and then run gulp build from here in order for the changes to take effect.

@JameelB awesome, yeah going to add new steps in a separate PR,
With two approvals I will merge this now, so other PR's can be rebased and we can get the proper colors into all changes.


TeXworks working snap

At the moment it needs a copy of texlive.
It wouldn't be bad to have a snap for that as well.
To access a local copy of texlive not installed in $HOME it needs to be installed with --devmode

I was thinking about TeXLive, but as a product doesn't it inherently require a lot of modification, which in a way makes snap a troublesome format?

Can you add a line to the top-level README.md maybe?

@dholbach I added two build dependencies.
Now it's working with the cleanbuild

Would it be possible to add texlive as part of stage-packages?

I was wondering what to do with that. I think it would be better to keep them separate.
I've had to install the upstream texlive version often in the last years, and being able to quickly install a specific version could be very useful

To have it bundled would be easier, so I guess we can add the version from the repo to stage-packages, and if somebody wants to install another version it can be done after.

adding texlive fails because of dangling symlinks

Can you pastebin the snapcraft.yaml somewhere - maybe we can figure this out together?

I added a couple of dependencies needed to integrate texlive:
gsfonts, poppler-data, and texlive-latex-base.
Now snapcraft says it copied the files needed for the symlinks.

I still get an error:
warning: kpathsea: configuration file texmf.cnf not found in these directories: /etc/texmf/web2c:/usr/local/share/texmf/web2c:/usr/share/texmf/web2c:/usr/share/texlive/texmf-dist/web2c:/snap/texworks/x1/share/texmf/web2c.
/snap/texworks/x1/usr/bin/mktexfmt: kpsewhich -var-value=TEXMFROOT failed, aborting early.
BEGIN failed--compilation aborted at /snap/texworks/x1/usr/bin/mktexfmt line 25.
I can't find the format file `pdflatex.fmt'!

I'm running snapcraft now to get the log.

This is the part of the snapcraft run with the symlink issue: https://paste.ubuntu.com/17356725/

The issue is that the snap is looking in the wrong directory:
/snap/texworks/x1/share/texmf/web2c
instead of:
/snap/texworks/x1/usr/share/texmf/web2c
https://paste.ubuntu.com/17356872/

Maybe you could use the following?
organize (yaml subsection) A dictionary exposing replacements, the key is the internal name whilst the value the exposed name, filesets will refer to the exposed named applied after organization is applied.

From https://developer.ubuntu.com/en/snappy/build-apps/snapcraft-syntax/

I'll have a look at that. I'm not sure how it works though.

The thing I don't understand is why it's looking outside the snap.
/etc/texmf/web2c:/usr/local/share/texmf/web2c:/usr/share/texmf/web2c:/usr/share/texlive/texmf-dist/web2c:/snap/texworks/x1/share/texmf/web2c

The youtube-dl example in the Playpen uses it like this:
    organize:
      usr/local/bin: usr/bin

ah ok! This might just be the thing we need

It's still searching in the same folder..
In this case I have to set this, right?
share/texmf/web2c: /usr/share/texmf/web2c
:

@dholbach This is my snapcraft.yaml:
https://paste.ubuntu.com/17362572/
The issue is not solved yet, it still reads the wrong directory

texworks/snapcraft.yaml, line 14 [r2] (raw file):
Previously, LyzardKing wrote…
> oh, sorry... That I copied from the snappy/parts webpage

Is this still required?

Comments from Reviewable

It'd be good to know if TeXworks needs texlive or how the effect on users is going to be.

Comments from Reviewable

I'll look at this again in the next few days. The qt4conf can be swapped out for "after: [qt4conf]"
I think the first thing to do then is to see if it works reliably with a local installed version of texlive.
As far as I can tell the issue with the bundled version is that texlive, after being installed runs two scripts, that a user can run again with dpkg-reconfigure.
These create the links/files missing.
the easy way out would be to install texlive and run those scripts (two bash scripts in the texlive bin) before installing texworks.

@sergiusens or @kyrofa - can you maybe explain what a good way to go about this would be?

Comments from Reviewable

texworks/README.md, line 13 [r5] (raw file):

Known issues:
  - texlive folder not recognized properly:
    - files in usr/share/texmf, program searches share/texmf

This is still being discussed.

Comments from Reviewable

@LyzardKing have you had the chance to follow up with someone from the snappy team to unblock this PR?

I'm looking at it now :)
The problem seems to be that texlive runs a script after the install via apt, to create the executables and configuration files.

Works with --devmode.
the binaries are created in bin/x86_64-linux, so this needs to be added to the path in texworks

Good work, can you rebase on current master again?

Comments from Reviewable

Sure! As soon as I test it one more time I'll rebase
On Thu, Jul 14, 2016, 15:46 Daniel Holbach<EMAIL_ADDRESS>wrote:

Good work, can you rebase on current master again?
Comments from Reviewable
https://reviewable.io:443/reviews/ubuntu/snappy-playpen/61#-:-KMde5bjxOGmtFeGLFzl:-861030627
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/snappy-playpen/pull/61#issuecomment-232669882,
or mute the thread
https://github.com/notifications/unsubscribe/AGyLRXiRJD440h6qBt_HKzK2GWy1dHADks5qVj23gaJpZM4I2E8t
.

@dholbach Fixed and rebased.
Still a couple of issues, as described in the Readme..

http://paste.ubuntu.com/19510579/

Comments from Reviewable

...what? I've never seen that error... Let me run a cleanbuild again

@dholbach It works for me...I only added the version number.

Nevermind. It works when I run it in snapcraft cleanbuild.

Comments from Reviewable

Reviewed 1 of 1 files at r4, 2 of 2 files at r5, 1 of 1 files at r11, 2 of 2 files at r12, 1 of 2 files at r13, 1 of 1 files at r14.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add Cetera's Suit Pack for TextureReplacerReplaced from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of Cetera, to add Cetera's Suit Pack for TextureReplacerReplaced to CKAN.
Mod details:
name = /mod/1595/Cetera%27s%20Suit%20Pack%20for%20TextureReplacerReplaced
author = Cetera
abstract = Cetera's Suit Pack contains class-specific custom suits for all KSP stock classes and for all classes included in MKS.
license = CC BY-NC-SA
Homepage = https://forum.kerbalspaceprogram.com/index.php?/topic/167869-131-ceteras-suits-for-texturereplacerreplaced/
description = ##Cetera's Suit Pack contains class-specific custom suits for all KSP stock classes and for all classes included in MKS.

EVA class suits for kerbal classes level zero through five
Alternate helmets used for any kerbals with the BadAss trait
Alternate veteran suits for any kerbals with the Veteran trait
Transparent EVA visors (used by default on the ground in an atmosphere when in an EVA suit)
Apollo-style EVA gold sun visors, mostly opaque, but with just enough transparency to let you get a feel for your kerbal's emotional state at any given moment while on EVA.  (default visor used in space)
The ability to flip back and forth between the clear and sun visors via right-click menu (select change EVA suit) thanks to TRR
Class-specific IVA suits with class icons on shoulder patches
Dedicated "Command" suits for the original four kerbals, Jebediah, Bill, Bob, and Valentina

NOTE: By default, veteran suits use the BadAss helmets, with an orange jetpack, and orange piping stripes on the EVA suits.  The command suits are exclusive to the Big Four.  If desired, you can copy the folders in the "Extras" folder to the "Suits" folder.  This will allow the Command suits to be used as veteran suits for the three stock classes.  Doing so will replace the BadAss helmet variant for veterans for these three stock classes only.
If adding this suit pack to an existing game, you must use the "Reset TRR" button in the TextureReplacerReplaced menu (lower right under the class selections) while in the Space Center view for settings to take effect.  New games started after the installation of this pack do not need this step.

##Cetera's Suit Pack REQUIRES the following mods:
TextureReplacerReplaced
Forum Thread
ModuleManager
Forum Thread

##Cetera's Suits is compatible/enhanced with the following mods:
Community Trait Icons
Forum Thread
Portrait Stats
Forum Thread
Modular Kolonization System
Forum Thread

##Screenshots here:
http://imgur.com/a/TZdy4

Please direct questions about this pull request to Cetera.

This is already indexed as Ceteras-Suit-Pack, but for 1.2.2. We should update that netkan file.


Update message when creating a migration

Recently I try to create a migration and it keeps saying to me that A {$class} migration already exists. but there was no migration with that $class name. Actually, it was a Seeder.
I know, the message isn't consistent, but, as migrations and seeder aren't namespaces, this PR makes sense?

Maybe it'd be better to namespace them?

@m1guelpf But then would be necessary to create a bug like Namespace migrations and factories and add this to a future version of Laravel, because would cause big changes :thinking:

@gabriel-caruso I can see how namespacing the seeders could cause some problems, but I don't think namespacing migrations could cause any. Aslo, if we move the database/ folder to PSR, we don't need to load it with composer every time Laravel makes a request...


test that UAT links works

Jira ticket
What changed and why
test
Guidance to review

Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing
Branch is generally up to date with main Github - definitely no conflicts
No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
PR description says what changed and why, with a link to the JIRA story.
Diff has been checked for unexpected changes being included.
Commit messages say why the change was made.

Can verify that this is the missing stringcheck-client-qualifies-legal-aid-uat in the URL.


Merge in IAP JWT verification nginx module.

Implementation of an nginx module to do automatic validation of IAP JWT assertions.
Not necessarily the final form, but has all the required functionality and is reasonably well-tested.
Not yet integrated with ESP, so checkin is a null op.

Is this a copy/paste of existing code, or is this a new implementation? (I.e. has this code been reviewed before?) If the former, could you link the existing implementation? Thanks.

This is entirely new implementation. Due to my novice GitHub abilities, it ended up being a single commit here. No prior review.

Thanks for the comments! All addressed but one that I wanted to ask a quick question about.
For dealing with the size of the review, I was going to suggest that I guide you through a few files at a time, as the factorization is clean enough to allow this. Start with base64_util{.h, .cc, _test.cc}, when we're happy with those we'll move on to the next chunk.
A few other things I should mention:

I've tried to stick exclusively to C++11 features and earlier for various reasons. If you want to discuss more, let me know.

The files module.h and module.cc follow aesthetic and idiomatic conventions that differ from the rest of the files, for consistency with how nginx code looks/functions, since I have to implement a lot of nginx interfaces there...all other files are devoid of nginx code references, and have a more modern C++ feel.

If you aren't familiar with nginx module writing, we should probably sync up so I can give you an outline of how things work before you review module{.h, .cc} and the integration tests (these will be the last things to review though, so it doesn't need to be right away).

Comments addressed, thanks! Hold off on merging until I see if someone from my team wants to review.

Thanks Matthew, comments replied to/addressed, please take a look.


Add prompt to name when extracting widget, local variable or method

Another idea inspired by coc-flutter, is to intercept code actions such that when a user selects ~wrap with widget~ extract widget or extract method we can show the user a prompt to collect the name to use and send that with the code action request.
I'm not sure how easy the idea of intercepting lsp actions is but this will be similar to how #38 is implemented in the end. There is also some prior art in coc-flutter but it won't really work exactly the same given the different underlying mechanics

Just a note to my future self I've dug into this a bit and should clarify that the wrap with widget method essentially doesn't perform a refactor but the codeAction contains edits to apply which already contain widget( etc. so can't really be updated without making a mess.
The more appropriate actions to target are

extract method
extract local variable
extract widget
Since these call workspace/executeCommand with refactor.perform this can then be intercepted by overriding the workspace/executeCommand handler possibly and showing a prompt and using the input to update the command.

See here for an example


Update firecrawl.py

Change 'FIREWALL' to 'FIRECRAWL' as I believe this may have been in error. Other docs refer to 'FIRECRAWL_API_KEY'.
Thank you for contributing to LangChain!

[ ] PR title: "package: description"

Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..."  for template changes, "infra: ..." for CI changes.
Example: "community: add foobar LLM"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change
Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!

[ ] Add tests and docs: If you're adding a new integration, please include

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/docs/integrations directory.

[ ] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

cc @nickscamara

@hicgboss that's right! Thank you for fixing it.


Proposing a DB schema

Wrote out some potential tables for the DB schema for the new service.
Organisations
Top level organisations. The organization has users and owns all of the scans run by that organization.
- id: UUID [primary key]
- name: String [unique]
- created_at: DateTime
- updated_at: DateTime

Users
User accounts for logging in. The session stores the access_token to make it easier to revoke and replace if need.
 - id: UUID [primary key]
 - organization_id: UUID [foreign key -> organisations]
 - name: String
 - password_hash: String
 - access_token: UUID
 - created_at: DateTime
 - updated_at: DateTime

ScanTypes
The different types of scans that can be run by the system. E.g. 'Accessibility', 'Security', etc.
 - id: UUID [primary key]
 - name: string

Templates
A template for a scan to be run. The token is provided through the API to specify which template to execute. Templates are owned by an organization and have a given name. Think, digitial.canada.ca as the template for run against the primary website.
 - id: UUID [primary key]
 - organization_id: UUID [foreign key -> organisations]
 - token: UUID [indexed]
 - name: String
 - created_at: DateTime
 - updated_at: DateTime

TemplateScans
Each template object can have multiple scans run against it. So, you may setup a scan for accessibilty and for security. When th template is executed all of the associated template scans are run. The scan_type_id specifies the type of scan to execute and the data stores any data needed to run the same. For example, the accessiblity scan my store the two top level urls for the website along with the spider flag and any other needed configuration for that scan.
 - id: UUID [primary key]
 - template_id: UUID [foreign key -> templates]
 - scan_type_id: UUID [foreign key -> scan_types]
 - data: jsonb <configuration data for the scan, URLs, spider, etc>

TemplateScanTriggers
The triggers are things that happen with a given TemplateScan encounters a violation. This maybe a callback to log a bug, or the response to the github action. (More info, or a data field maybe needed here to configure the callback?)
 - id: UUID [primary key]
 - template_scan_id: UUID [foreign key -> template_scans]
 - callback: text

Scans
The scans are the results table. So, a given organization executed a given template which had a given scan on a given date/time. This is the top level record of the scan that happend. Each TemplateScan would create a Scans record as they are run.
 - id: UUID [primary key]
 - organization_id: UUID [foreign key -> organisations]
 - template_id: UUID [foreign key -> Templates]
 - scan_type_id: UUID [foreign key -> scan_types]
 - created_at: DateTime
 - updated_at: DateTime

A11yReports
Specific scan type data for a scan. So, given a scan we can look up the table to retrieve the scan data from. This holds the basic information for an accessibility scan.
 - id: UUID [primary key]
 - scan_id: UUID [foreign key -> scan]
 - product: string
 - revision: string
 - url: string
 - ci: boolean [not null default false]
 - summary: jsonb
 - created_at: DateTime

A11yViolations
Stores individual violations from a given accessiblity report.
 - id: UUID [primary key]
 - report_id: UUID [foreign key -> A11yReports on delete cascade]
 - violation: string
 - impact: string
 - target: text
 - html: text
 - data: jsonb
 - tags: jsonb
 - message: text
 - url: string
 - created_at: DateTime

SecurityReports
Similar to A11yReports but for security reports.
 - id: UUID [primary key]
 - scan_id: UUID [foreign key -> scans]

SecurityViolations
Similar to A11yViolations but for security violations.
 - id: UUID [primary key]
 - report_id: UUID [foreign key -> SecurityReports on delete cascade]

I'm not a huge fan of the TemplateScans::data field. Could this be broken out more? Are there consistent things we'll care about for a scan? Like the set of URLs to run over, do we spider, other?
Should we have the following extracted out of the data?
TemplateScanURLs
 - template_scan_id: UUID [foreign key -> TemplateScans on delete cascade]
 - url: string

Wonder whether we actually need separate tables for A11yReports / SecurityReports, A11yViolations / SecurityViolations – seems that could just be a ScanType column on Reports and Violations tables, assuming all the other fields are the same.

If we store the data as a JSON blob, we could, but that also makes it harder to work with through SQL. Although, maybe we don't need that flexibility?

How do we deal with pages that require authentication? Do we store something in the TemplateScans::data? How do we secure the username/password used for authentication?


Enhance CONTRIBUTING.md guide and fix makefile missing commands

Description

Enhance CONTRIBUTING.md guide showcasing how to clone, make changes, test and create a PR for the repository.
Fix missing Makefile commands and add a new one running all prerequisites

How can this be tested?
make prerequisites

Checklist
- [ ] Unit tests have been updated/added

[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Please, write down if you think something is missing from the guide!
My missing points:

How to run the operator locally: We heavily depend on make build, which pushes the image to our private quay registry. Is there a way we could offer building and deploying locally without having access to our registries?