nodejs_22: 22.8.0 -> 22.9.0

Description of changes
https://github.com/nodejs/node/releases/tag/v22.9.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Would be great to get this in 💖

Sorry for the noise


Update ariaNotify (formerly Confirmation of Action) explainer

Re-visiting ariaNotify (Confirmation of Action). Updated explainer in this repo with latest changes.
@alisonmaher @Doug Geoffray (I can't find his github alias)

@microsoft-github-policy-service agree company="Microsoft"

@diekus friendly ping :) lmk if you have any questions

@diekus sorry can you merge the change for me as well, I don't think I have permissions :') Thanks!!


inconsistent postgres names

https://github.com/remind101/stacker/blob/master/stacker/blueprints/postgres.py#L9
https://github.com/remind101/stacker/blob/master/stacker/blueprints/postgres.py#L11
create something like:
PostgresRDSapiRdsDb
RdsSGapiRdsDb
the name should always go in the front to stay consistent with other camel cased names.

i don't think this is going to be a backwards compatible change

this is one reason I would push for these blueprint constants being properties of the class. if i wanted to customize these names, i could easily subclass the blueprint and change them to whatever i wanted.

One thing I've started to realize is that all the 'blueprint' specific naming of things isn't as important.  The resource names we give things just have to be unique inside a template, not unique across all templates.  So naming something PostgresRDSapiRdsdb doesn't make sense, unless we plan on having multiple resources of that type in the blueprint, which we usually don't.  That means you could name it something simple, like DBInstance and be done with it.
Unfortunately changes like this aren't backwards compatible.  It almost makes me want to start a whole new set of blueprints with changes like this.

yea, i like being able to see the names on all the aws entities and be able
to trace that back to the stack. i really wish we could just do
"api-postgres-rds" but they don't allow hyphens :(
On Wed, Aug 12, 2015 at 11:18 AM Michael Barrett<EMAIL_ADDRESS>wrote:

One thing I've started to realize is that all the 'blueprint' specific
naming of things isn't as important. The resource names we give things just
have to be unique inside a template, not unique across all templates.
So naming something PostgresRDSapiRdsdb doesn't make sense, unless we plan
on having multiple resources of that type in the blueprint, which we
usually don't. That means you could name it something simple, like
DBInstance and be done with it.
Unfortunately changes like this aren't backwards compatible. It almost
makes me want to start a whole new set of blueprints with changes like this.
—
Reply to this email directly or view it on GitHub
https://github.com/remind101/stacker/issues/52#issuecomment-130399643.

Honestly I don't think this is ever going to get changed.  We can try to be better about it going forward, but this isn't really a priority for fixing old resources.  It'd also cause updates on resources that could break things.  Going to close it.


Highlight Monster That Gives Most Points NMZ

Would it be possible to highlight or arrow the monster that gives the most points in an NMZ floor

The NMZ Optimal Points plugin on the hub does this.


Feat: Support VS2022 Preview new UI

This closes #29
I compared the visual trees between 2022 preview (left) <--> 2022 non-preview.

They renamed the Border control, and we cannot use the ControlBorder as the name to find it because there are tons of other borders named the same. The solution is simply find the uniquely-named part, then get its parent.
2022 release ver:

2022 preview:

I think it breaks in VS 17.8.2

@xprzemekw Works on my machine. Do you have a reproduce? If so, make another issue


Fix failing CSV tests

Hi,
This PR fixes some of the script tests issues highlighted in #83
The following two CSV tests now pass:
["0", "CHECKSEQUENCEVERIFY", "CHECKSEQUENCEVERIFY", "UNSATISFIED_LOCKTIME", "CSV fails if stack top bit 1 << 31 is set and the tx version < 2"],
["4294967296", "CHECKSEQUENCEVERIFY", "CHECKSEQUENCEVERIFY", "UNSATISFIED_LOCKTIME",
  "CSV fails if stack top bit 1 << 31 is not set, and tx version < 2"],

Coverage remained the same at 77.076% when pulling d35832acebd054b8fbb00c366950212123c646f9 on libbitc:picocoin into 3c3d50424088f877f2c792db8ff8bddd79723267 on jgarzik:master.

Coverage remained the same at 77.076% when pulling d35832acebd054b8fbb00c366950212123c646f9 on libbitc:picocoin into 3c3d50424088f877f2c792db8ff8bddd79723267 on jgarzik:master.

Merged - even though the struct passing is not my favorite thing to do.  Let's hope it doesn't confuse coverity or valgrind...

Hi @jgarzik,
Oh,  struct passing slipped in by accident during a bit of trial and error I was doing to fix issue. It can be changed on next pull request if/when a solution for other issue raised in #83 is fixed i.e. OP_0 and bools do not have identical byte representations


Controller memory issue

Description
Changes proposed in this pull request:

Istio install execution in external process as a temporary hack for memory leak in Istio
Integration tests check for memory usage of the controller

Related issue(s)

Fixes #157

/retest

/retest

/retest

/retest

/retest

/retest

/retest


plist available twice at tempo

att.plist lists <tempo> twice in the "Available at" list:
https://music-encoding.org/guidelines/v4/attribute-classes/att.plist.html

@kepper is there a quick fix for this?

No, but an assumption: <dynam> is also available twice. Both <dynam> and <tempo> are referenced in the <desc> on <dir>. Other attribute classes seems to have the same problem (att.partIdent also lists those elements twice). Apparently, the XSLT that extracts the elements also from the desc info, and doesn't do a distinct-values late enough in the game… Should be an easy fix, but I won't search just now…

put it on the list then ;)

@kepper any news on this?

I was hoping to find some time this week to work on such things for MEI – it's Thursday, and I haven't found that time so far :( I still have hopes for the afternoon, though. I'll prepare this for tomorrow, promised :-)

it seems like the current code for generating the guidelines (dev / v5) works just fine. The problem therefore affects the v4 guidelines only.  This means that a fix to this would have to be through a something – either a script or some manual corrections – that fixes those static files. I'll try to  find out how often the problem actually occurs to be able take a decision on this.

it is triggered by the inclusion of <gi>tempo</gi> and <gi>dynam</gi> in //elementSpec[@ident = 'dir']/desc. This is the only element in v4 that has such references in it's description (there are a couple of attribute classes with similar references, but apparently they don't cause the same issues). This is good news, because it's possible to do a simple search and replace in the right folder… I'll prepare a PR, to be discussed tomorrow.


Updated Custom directive templates code example

I have had a problem with the example code for the Custom directive templates. I was not able to bundle and minify this code with a .NET web optimization bundle. The error I was having:"Error: [$injector:unpr] Unknown provider: nProvider <- n <- mwlCalendarSlideBoxDirective ...".
By adding the right dependencies for the '$provide' and '$delegate' the minification works again. I hope this helps someone in the future, at least my four hours spent finding a solution was worth something ;).

Thanks for the PR!
PS you can do this automatically in the future with ng-annotate and if you enable strict di you can have angular notify you in dev mode whenever something isn't annotated! :smile:


Tunneling display

If it's of interest to the authors of the repository, I would be interested in either adding a short demo or some extra information in the README to show people how to tunnel localhost to a public URL with something like ngrok; this way, people running display on a remote shell (without access to a browser or X11 forwarding) can still view updates live.
On second thought, if such a feature already exists, it would be great to see more documentation on this?

You can forward the port through ssh.
Example, the display server is running on port 8888 on the remote server, then you ssh with:
ssh -L 8000:localhost:8888<EMAIL_ADDRESS>Then you can access the display server on your local server on port 8000.

Ah okay, I didn't know this. Do I mind if I add this small piece of information to the README?

@suryabhupa yes please do

@ilija139 Sorry for the delay; I just added it. Please feel free to review and pull.


build: let log level unlimited and add more explanations

Since we intend that most distros and users just use our
default configuration, reducing log levels, that only
would be useful for final products doesn't seem the
best approach.
Instead, we're improving documentation about it.
Signed-off-by: Bruno Dilly<EMAIL_ADDRESS>

merged with suggested changes


Assert the relationship between feature flags and verification key

In some circuits with inductive rules supporting different subsets of custom gates, a malicious prover could set the flags corresponding to the intersection of custom gates required, and effectively disable all of the others. To fix this problem we need to check that the feature flags given correspond to the commitments in the verification keys, ensuring that there is no flexibility in their choice while also maintaining soundness.

Done in https://github.com/MinaProtocol/mina/pull/15233. Closing.


remove extra parenthesis

remove the extra parenthesis.

A new inspection was created.

A new inspection was created.

A new inspection was created.

Refactored it 👍 Thanks for suggestion!

The inspection completed: No new issues

A new inspection was created.

A new inspection was created.

The inspection completed: No new issues


lm4flash: init at 0.1.3

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The package is mostly fine now. There are still things to do though:
If you're going to be maintaining this package, you're going to need to add yourself as the maintainer for it.
(CONTRIBUTING.md#commit-conventions has a section about adding yourself to the maintainer list.)
Also, as it stands now, the PR has multiple commits, but there should only be one commit per area changed (in this case, you only added 1 package, so there should be 1 commit for that)
If you need help with this, see https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_squashing
There should also be a separate commit which adds you to the maintainer-list. This commit should come before the package commit.


Public graphql API - Expected type AuthStrategy, found public.

Dear all,
I have an issuee with Amplify Graphql API,
I have node 8.9, node 10.9 and node 12.13 (and I have tested with all versions, obtaining the same error).
My schema is
type Ad
  @model
  @key(fields: ["id", "status", "createdAt"])
  @key(name: "byStatus", fields: ["status", "createdAt"], queryField: "itemsByStatus")
  @auth(rules: [
      { allow: owner },
      { allow: public, queries: [get, list], mutations: null },
      { allow: groups, groups: ["Users"], queries: [get, list], mutations: null }
    ]) {
  id: ID!
  type: Animal!
  title: String!
  description: String!
}

When i run amplify push I get the following error
Schema Errors:

Expected type AuthStrategy, found public.

GraphQL request (87:16)
86:       { allow: owner },
87:       { allow: public, queries: [get, list], mutations: null },
                   ^

Running "> amplify --version" I get 1.12.0.
The version installed of amplify-cli is<EMAIL_ADDRESS>Could you please help me finding a solution?
I double check all, also made the API again from zero but without success...
Thanks

@bagubits Looks like the CLI installation isn't successful. Can you run npm install -g @aws-amplify/cli and make the CLI is globakly installed correctly?
amplify -v should return 3.17.0.

Unbelivable... My global install of the cli, was not updated. Sorry. And many thanks for support.


Look over the design of the script

Right now the solution is kind of a mishmash of multiple solutions. Look through the script and rethink all design decisions.

A nice thing would maybe be to split the code into functions.


django 3.0 compatibility

Both django.utils.six and django.utils.functional.curry were removed in django 3.0.

Thanks for your work and this PR. I don't want to drop support for Python 2.7 just yet (not until 1.11 is no longer supported) so I'm going to add Django 3 support in a slightly different way. Thanks again!


Discarded invalid parameter '_meta'

Sentry 9.0.0
sentry.python 0.5.5
Discarded invalid parameter '_meta'

How to correct it?

Hi @tonal, this is fixed on the master branch of sentry. We realize that we should push out a new release of sentry but there are a few other blockers there. I would recommend installing sentry from the master branch.


Raster - improve low-zoom swisstopo coverage

In 2022, Swisstopo competed coverage, up to TMS zoom-level z12, of the following area:
48.19, 5.32 <> 48.14, 11.40
 ↓↑              ↓↑
45.40, 5.43 <> 45.35, 11.20

currently some of this is missing in etopo-alps

z12 has some border issues that seem to have been solved

eg Punta Tsanteleina tile was partial → now a couple more tiles down to Col du Carro 45.42 or even Roc du Mulinet 45.368 ; (Voiron 45.35 05.44  but 45.5 would be safer to go east)

z11 has much more missing than z12

it stops at 45.70 (S). misses eg grand-paradis
big corner missing right of adamello

both go a bit further east

Adding it would make map boundaries homogenous between 11 and 12

addded in 3a947d19


Automatically format Python snippets in the spec

Currently, these snippets are formatted manually, so we have to spend brain cycles thinking about that.

Closing as this is unlikely to be priority. Given the speed at which the spec evolves it is likely that writing such a tool would cost more than the updates of the next few years.


Fix #852: Add 30s timeout to pod waiting (should be configurable?)

What is the purpose of this change? What does it change?
Fix #852
Was the change discussed in an issue?
#852
How to test changes?
Not sure how to create a repeatable way to test the change…

@metacosm , there's some problem with rebase I guess, can you please check again ?

Superseded by #878. Thank you, @geoand!

Thank you for you help @metacosm!


Black screen

Hey, I just found a weird bug(at least I think it is library bug). The bug is that if you apply the fade animation to tabbarcontroller and if you press tabs back and forth, the whole screen goes black. Basically it just makes everything to disappear except tab bar.
Is there any hotfix I can do?
This is what I mean. I can’t show you the view debug since I am typing it from my phone. If necessary I can post it later.

Have you found solution yet? I've been thinking about delaying showing tab bar to user, but this solution is not really one I'm looking for...

Is this still happening in the 1.0.0-alpha? Thought I fixed this some times ago.

Still happening for me, on the latest pod version, even when using heroTabBarAnimationType = .none (on iOS 11 beta 5, real device, iPhone 6s+). Happens when I switch tabs fast.
Have tried this on an iPhone 6s (simulator) running iOS 10.3.1 and was not able to reproduce it so far (might be because I can't "tap" as fast on a simulator), will test on an iOS 10.3.1 device soon.
console right after it happened (on iOS 11 beta 5)

Y, still have it. Seems like it somehow put viewController under TabBar. Like it have problems with coordinateSystem. Will try to reproduce and add screen later


Add change log entry for #2704

Adding missing change log for #2704.

Codecov Report

Merging #2711 (ffeac97) into develop (184f7c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2711   +/-   ##
========================================
  Coverage    95.23%   95.23%
========================================
  Files           60       60
  Lines        12290    12290
========================================
  Hits         11704    11704
  Misses         586      586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184f7c8...ffeac97. Read the comment docs.


[404 fix] One character syntax fix

Fixes part of #4642
This PR:

Makes a one-character syntax fix to enable redirect_from statements and resolve a 404.

This change is

@chenopis This looked like a simple syntax fix, but the netlify preview still returns a 404. Any guidance?

/cc @steveperry-53 related to #3659

Just remove the redirect_from: directive since we are no longer using that mechanism, but make sure the redirect is in the _redirects file.

Oh, right! Thanks for the reminder--I swear I'll remember this going forward.

@chenopis The redirect works fine now. 👍


Amplify util mock/mock supports override

Description of changes

Add amplify mock supports override.ts.
Issue #, if available

https://github.com/aws-amplify/amplify-category-api/issues/1659
Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #12940 (9183671) into dev (ec9a2ba) will increase coverage by 48.45%.
The diff coverage is 58.63%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##              dev   #12940       +/-   ##
===========================================
+ Coverage    0.00%   48.45%   +48.45%
===========================================
  Files        1296      837      -459
  Lines      149743    38046   -111697
  Branches     1296     7748     +6452
===========================================
+ Hits            0    18436    +18436
+ Misses     148447    18022   -130425
- Partials     1296     1588      +292

Impacted Files
Coverage Δ

...y-category-function/src/commands/function/build.ts
0.00% <0.00%> (ø)

...ify-category-function/src/events/prePushHandler.ts
33.33% <0.00%> (+33.33%)
:arrow_up:

...ider-utils/awscloudformation/utils/layerHelpers.ts
21.80% <0.00%> (+21.80%)
:arrow_up:

...er-utils/awscloudformation/utils/storeResources.ts
30.38% <ø> (+30.38%)
:arrow_up:

...ib/S3AndCloudFront/helpers/configure-CloudFront.js
87.06% <ø> (+87.06%)
:arrow_up:

...lify-category-hosting/lib/S3AndCloudFront/index.js
89.65% <ø> (+89.65%)
:arrow_up:

...ifications/src/commands/notifications/configure.ts
0.00% <0.00%> (ø)

...e/src/amplify-node-pkg-detector/lock-file-types.ts
100.00% <ø> (+100.00%)
:arrow_up:

.../src/amplify-node-pkg-detector/yarn-lock-parser.ts
100.00% <ø> (+100.00%)
:arrow_up:

packages/amplify-cli-core/src/constants.ts
100.00% <ø> (+100.00%)
:arrow_up:

... and 47 more

... and 1249 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hotkey To Disable/Enable Keyboard Manager (and multiple sets of key remaps)

Description of the new feature / enhancement
A hotkey to Activate/Deactivate features, for example pressing numpad 0 could activate keyboard manager, it would also be handy to have the ability to make multiple sets of them, so you can quickly change between them with hotkeys.
Scenario when this would be used?
when using keyboard manager to change the functinoality of some important keys like 1-9 you could easily disable it to type some numbers, and then quickly re-enable it without having to open the program which is a clunky and slow process, you could also make multiple sets of keyboard managers for different programs or situations!
Supporting information
I like to use my key 1 for copy and 3 for paste, and 2 for select all, this way i can quickly move my intended statistics between programs, but if i have to type a number manually, i have to go disable the program, type it, and then go back to re-enable it, which is a very annoying process, and considering that this software is meant to help out, it would be supreme if it could have this feature as well!

Duplicate of #4879

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue to centralize the thread.
Thanks for helping us to make PowerToys a better piece of software.


use-workspace-logstash-if-exists.tar.gz is missing

bin/install_dependencies is looking for https://github.com/logsearch/logsearch-filters-common/archive/use-workspace-logstash-if-exists.tar.gz but it is missing

@drnic - oops - deleted that branch when I merged https://github.com/logsearch/logsearch-filters-common/pull/22
Link should now be fixed - could you try again please


How can I change the rules or add new rules?

Hi,
Is there any way to change the rules or add new rules?
eg: change the bug level from error to warning , or ignore specific type bug
thanks for any help :)

Let me answer your questions in reverse order:

To ignore a specific bug type there is a --disable-checks option. Use it on the command line: infer --disable-checks MEMORY_LEAK --disable-checks RESOURCE_LEAK or inside .inferconfig:

{
    "disable-checks": [
      "MEMORY_LEAK",
      "RESOURCE_LEAK"
    ]
}

Bug levels are hardcoded for each bug type and cannot be changed.
What rules would you like to change/add?

Thanks for the answer.
It's helpful for me.


Bump grpc to v1.51.0

Bumps grpc to v1.51.0
Bumps genproto to v0.0.0-20221118155620-16455021b5e6

Removed unrelated changes.
For some reason it wanted me to update two unrelated deps, so I did it
go.opencensus.io  has different values in the go.mod files require section:  v0.23.0 in root go.mod  v0.24.0 in integration/client/go.mod
github.com/stretchr/testify  has different values in the go.mod files require section:  v1.8.0 in root go.mod  v1.8.1 in integration/client/go.mod

/ok-to-test

I see kubernetes moved up to 1.51 grpc in main post k/k v1.26 which just went out. Is this change tied to an issue?

@mikebrow not tied to an issue, just keeping it up to date. Not sure why they waited in k8s to merge it.
Seems like this test keeps failing....


Save sync weekdays state

Thanks for the nice plugin, @SimeonGriggs!
So, I've notice that you define Sync Weekdays switch to be always starts with true state:
https://github.com/SimeonGriggs/sanity-plugin-availability/blob/6b8921f7cbd0ce849bda6c8d88e8c5b9d6798557/src/components/Availability.tsx#L25
It's possible to choose the state of this component as default or initial value?
Thanks in advance.

@SimeonGriggs


RFC-001: Composable Pipelines

This PR adds the first RFC. This is an experiment. We want to gather public
feedback for ideas and want to try a PR-based discussion in a Markdown document.

[sc-36531]

@dominiklohmann should we consider splitting out the infrastructure pieces of this PR into a dedicated one? Otherwise the docs changes will linger for a few weeks.

@dominiklohmann should we consider splitting out the infrastructure pieces of this PR into a dedicated one? Otherwise the docs changes will linger for a few weeks.

I would want to wait a bit until there's no more comments on the template itself.

NB: I'm planning to take the proposal infrastructure into a separate PR, merge it, and then rebase this one onto master. Speaking with @dominiklohmann, I think we have converged on a RFC architecture that's a solid first stab.

I am almost wondering whether we could separate this into 2 RFCs: 1 for the pipelined import/export, one for the vast exec proposal.

We could even go more fine-grained, agreed, but I think we don't have to. Given that RFC-003 is right behind this RFC, we can discuss a lot of the UX there.

Has anyone ideas on how to articulate requirements for this? I was thinking about the following:

Incremental deployability on top of import and export
Independent execution of pipelines
Separation of logical and physical representation


support disconnecting sessions

@ajaspers points out that if your account password was compromised, there's no way to disconnect any sessions controlled by an attacker.

We may want to rename the command to /ns clients, in keeping with a general trend away from using "sessions" in user-facing language. (See f5ca35ed722224bbfc5a0b8c98f103e0bd6ee40d for example; the problem is that the internal terms "session" and "client" mean the opposite of what they sound like.) /ns sessions could remain as an alias for /ns clients list.


ParameterSet count too low

Describe the bug
Hi,
In PR 32, the limit for ParameterSets was set to 5. As has been shown, this limit is somewhat too low in practice. As long as the loop implementation for large arrays is missing, i recommend to increase this value.
To Reproduce
Encode/Decode ServiceDetailRes with 6 or more ParameterSets
Anything else?
Why is there even this limit for more than 25 occurs? Everything seems to work for me if i remove that limit

We also noticed the same issue recently. By chance, our own products use a higher limit.
I agree with a size of 8, perhaps 16 is okay as well.


Fix CI post message

I did that based on https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
I couldn't test the post of the message itself, because the second job was not triggered for some reason on my repo (maybe it must be in main branch I don't really know...), but the artifact has been correctly created as you can see there https://github.com/b-ma/web-audio-api-rs/pull/1/checks
As the second script is very mostly a copy/paste from the github article I guess it should work properly (or a least don't be far).

The artefact has been correctly uploaded here too https://github.com/orottier/web-audio-api-rs/actions/runs/2846981432

Okay I skimmed the article and this looks alright, let's see!

Now we need a way to not run this only on pull requests, not an update of main :)
It tried to comment on issue 0: https://github.com/orottier/web-audio-api-rs/actions/runs/2847620236

Now we need a way to not run this only on pull requests, not an update of main :)

Damn I was thinking this https://github.com/orottier/web-audio-api-rs/blob/ab9cf1145dad18f7e2b9523bb6d6f50418ed0e01/.github/workflows/post-pr-result.yml#L18 would do the trick...

Seems there is a branches-ignore filter (cf. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-branches), so maybe adding in post-pr-result.yml would do the trick:
on:
  workflow_run:
    branches-ignore:
      - 'main'
    workflows: ["Rust"]
    types:
      - completed

Thanks, will try tomorrow. Posting the message from your delay-cycle branch worked, great success!


Export Lift

Prefer no lambda.
On Thu., Mar. 14, 2019, 11:54 a.m. andrei-sa<EMAIL_ADDRESS>wrote:

@andrei-sa commented on this pull request.
In Python/Source/Lift.cpp
https://github.com/eidolonsystems/rover/pull/15#discussion_r265640191:

dict args_apply(const std::function<object(Box&)>& func,

 KwargsCont& cont) {

auto result = dict();
for(auto& arg : cont) {

 result[arg.first] = func(arg.second);

}
return result;
}

class PythonLift {
public:

 using Type = object;

 PythonLift(object callable, args args, kwargs kwargs)

   : m_callable(std::move(callable)),

     m_args(args_apply([](object&& generator) {

Actually, here python_autobox<ReturnType, ArgFwd> uses perfect forwarding
by its second template parameter. I can use it in this way:
args_apply(python_autobox<object, object&&>, std::move(args)),
but I am not sure, is it acceptable or I should still prefer the lambda?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eidolonsystems/rover/pull/15#discussion_r265640191,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APzFGZkWvF7ddE8Oc_XMZYcf_-dD8z5Aks5vWnC4gaJpZM4bxYQo
.


static folder created and htmldiff.js htmldiff.css added

Created the static/ folder and added htmldiff library associated files.
Example usage of htmldiff can be found here
Added a js library  (static/js/htmldiff.js) to mark differences between to texts.
Original js library can be found here.
Added the necessary css file (static/css/htmldiff.css) for htmldiff.js library.

Thanks. Is there any way we can make this more readable?

Thanks. Is there any way we can make this more readable?

Do you mean non-minified version of .js file, or maybe some other library ?
I couldn't find non-minified htmldiff.js, but I can look for other implementations if you like.

Yes, I meant a non-minified version of the .js file.


Fix JobQueue thread safety

The implementation of JobQueue does not hold up to the thread safety promises in the header comments. I wrote a simple test case that stresses JobQueue a bit and easily crashes. The fixed JobQueue swaps out the m_jobs vector inside a lock and then processes the jobs.

I just added some cosmetic fixes - this should be done now.
Btw, I think this is an actual issue. If I understand it correctly, in Map::loadSceneAsync and Map::updateSceneAsync a call to JobQueue::add(...) is scheduled to Map::Impl::asyncWorker via Map::runAsyncTask. When the asyncWorker executes JobQueue::add, that should be a racy with JobQueue::runJobs in Map::update.

Thanks @cleeus for looking at this issue and submitting a complete PR with a test case to catch the issue. Merged in master now, will be available in the next release.


⚠ ClamAV has degraded performance

In 48a9b32, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: ClamAV performance has improved in 5399c26 after 4 minutes.


数据插入bug修复

Coverage remained the same at 98.992% when pulling 6f51a428d91e4d41ee5872bf516489c193b13958 on bottle0825:master into 623fcbdab8456142d2cf31376d49049db302c7d8 on rugao-web-fullstack:master.


Azure Application Insights Release Annotations script fails

The script provided in this section article fails wirh below error when used in devops release pipeline with linux (ubuntu-latest) agent, (it works if used in windows-latest but for other reasons we are not able to use windows):
ERROR: Bad Request({
  "error": {
    "code": "BadRequest",
    "message": "Value cannot be null.\r\nParameter name: input",
    "innererror": {
      "trace": [
        "System.ArgumentNullException"
      ]
    }
  }
})

I tried it with powershell core as well as bash script with same error.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4d3c69d0-fe29-7d1d-6302-c8f594e6a7f3
Version Independent ID: 75ad3140-7035-5a2d-ca0a-573c79203939
Content: Release and work item insights for Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/release-and-work-item-insights.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @AaronMaxwell
Microsoft Alias: aaronmax

@nvmkpk
Thanks for your feedback! We will investigate and update as appropriate.


React.forwardRef: Cannot create styled-component for component: [object Object]

System:

OS: macOS High Sierra 10.13.3
CPU: x64 Intel(R) Core(TM) i5-4288U CPU @ 2.60GHz
Free Memory: 2.49 GB
Total Memory: 8.00 GB
Shell: /bin/zsh - 5.3

Binaries:

Node: 9.7.1
Yarn: 1.5.1
npm: 5.6.0
Watchman: 4.9.0

npmPackages:
babel-plugin-styled-components:

wanted: ^1.2.0
installed: 1.5.1

styled-components:

wanted: ^3.1.6
installed: 3.2.5

Reproduction
https://codesandbox.io/s/ql7kx130vj
Expected Behavior
No error
Actual Behavior
Cannot create styled-component for component: [object Object]

Found this issue while implementing React.forwardedRef in this project: https://github.com/diegohaz/reas
The solution is probably accepting objects here: https://github.com/styled-components/styled-components/blob/f4762995db1455dd28b84918895492da3079eacc/src/constructors/constructWithOptions.js#L10
Or using the new package react-is: https://www.npmjs.com/package/react-is
Related issue on React repo: https://github.com/facebook/react/issues/12453


Adds a comment referencing a future golang feature that will simplify string interning

What does this PR do?
Adds context for future programmers who work on the string interner.
Motivation
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Test on Docker does not work

Describe the bug
I can't test with the Docker image.
To Reproduce

docker run --rm -it -p 4010:4010 stoplight/prism mock https://raw.githack.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore-expanded.yaml

Result

docker run --rm -it -p 4010:4010 stoplight/prism mock https://raw.githack.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore-expanded.yaml
[5:00:28 PM] › [CLI] …  awaiting  Starting Prism…
[5:00:29 PM] › [CLI] ℹ  info      GET        http://<IP_ADDRESS>:4010/pets?tags=sequi,sequi,aut,magni,nam,voluptatem,ut,ipsa,qui,inventore,molestiae,molestias,vitae,est,provident,consequatur,dolor,dicta,fuga,vel&limit=987
[5:00:29 PM] › [CLI] ℹ  info      POST       http://<IP_ADDRESS>:4010/pets
[5:00:29 PM] › [CLI] ℹ  info      GET        http://<IP_ADDRESS>:4010/pets/949
[5:00:29 PM] › [CLI] ℹ  info      DELETE     http://<IP_ADDRESS>:4010/pets/890
[5:00:29 PM] › [CLI] ▶  start     Prism is listening on http://<IP_ADDRESS>:4010

2. On another terminal:
➜ curl -s -D "/dev/stderr" http://localhost:4010/pets/123
➜ # It does nothing
➜ curl http://localhost:4010/pets/123
curl: (56) Recv failure: Connexion ré-initialisée par le correspondant

Expected behavior
Have a result
Additional context
Only one docker is running:
➜ docker ps
CONTAINER ID   IMAGE             COMMAND                  CREATED        STATUS        PORTS                    NAMES
46991cefacf7   stoplight/prism   "node dist/index.js …"   1 second ago   Up 1 second   <IP_ADDRESS>:4010->4010/tcp   competent_heisenberg

Ok it works with --host.
It is written here: https://github.com/stoplightio/prism#-faqs
Is it possible to have a customized README for https://hub.docker.com/r/stoplight/prism?
docker run --rm -v $(pwd):/tmp -p 4010:4010 stoplight/prism mock --host=<IP_ADDRESS> https://raw.githack.com/OAI/OpenAPI-Specification/master/examples/v3.0/petstore-expanded.yaml


Consider using go test flag -timeout for setting the timeout instead of KNUU_TIMEOUT

Related issue: https://github.com/celestiaorg/knuu/issues/165

not possible


Transpile to ES6: calls to super() fails when source maps are enabled

Source:
class Test {
  super()
}

Transpiled to ES6 with source maps leads to the error:
TypeError: Cannot read property 'line' of undefined
    at ParseTreeMapWriter.originate (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22573:26)
    at ParseTreeMapWriter.enterBranch (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22561:12)
    at ParseTreeMapWriter.visitAny (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22532:14)
    at ParseTreeMapWriter.visitExpressionStatement (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:21840:12)
    at ExpressionStatement.visit (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:7570:15)
    at ParseTreeMapWriter.visitAny (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:4161:20)
    at ParseTreeMapWriter.visitAny (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22533:81)
    at ParseTreeMapWriter.writeList_ (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22442:14)
    at ParseTreeMapWriter.writelnList_ (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:22419:14)
    at ParseTreeMapWriter.visitFunctionBody (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:21907:12)
    at FunctionBody.visit (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:7691:15)
    at ParseTreeMapWriter.visitAny (eval at loadModule (/Users/tbosch/projects/angular2/tools/transpiler/index.js:99:19), <anonymous>:4161:20)

Please list the version number and tell us how you are transpiling.
The example is a parse error we are not handling well.

@tbosch Can you provide valid syntax? Your example is not valid ES6.

Here is what should happen:
http://google.github.io/traceur-compiler/demo/repl.html#%2F%2F Options%3A --source-maps
class Test {
  super()
}
But I guess you are calling either the command line or API.

Sorry, my bad. Here is the correct example:
class Test {
  constructor() {
    super();
  }
}

We are using traceur 0.0.82.
Btw, the current master seems to have another problem when using es6 as output language: The PureES6Transformer now expects an options argument, which is not passed down by Compiler when it creates it. See http://google.github.io/traceur-compiler/demo/repl.html#%2F%2F Options%3A --output-language%3Des6
class Test {
  constructor() {
  }
}

Btw, the current master seems to have another problem.
Please report separate issues on .... separate issues ;-)

Seems like that example works fine:
http://google.github.io/traceur-compiler/demo/repl.html#%2F%2F Options%3A --source-maps
class Test {
  constructor() {
    super()%3B
  }
}

@johnjbarton Yes, but it does not set output-language=es6 :-)


⚠ Turnos 24x7 has degraded performance

In e325a54, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 9288 ms

Resolved: Turnos 24x7 performance has improved in 52bff79.


enhance upgrade iceberg to 1.4.3

and upgrade awssdk from 2.17.257 to 2.20.131.
Cherry-pick #30799

run buildall


tmux renders with wrong size when there are several terminals

I have the setup that was described by João Moreno (@joaomoreno) in his blog post https://medium.com/@joaomoreno/persistent-terminal-sessions-in-vs-code-8fc469ed6b41
Whenever I open a terminal tab in VS Code, i enter a tmux session (often attaching to an already present tmux session)
I love this setup! Among other things, it allows all the window control of tmux and it enables me to restart VSCode without losing my terminal session.
However, in the insiders edition (during my testing of #43683) I have experienced a new problem:
Whenever I have more than one Integrated terminal, and toggle visibility of the terminal window, the tmux window fills up with periods:

Steps to Reproduce:

Start VSCode Insiders edition (even without extensions)
Open the integrated terminal with Cmd-Ctrl-`
A tmux window is shown in the terminal window, as expected
Create a new integrated terminal by pressing the + icon at the top right of the terminal window
I am automatically switched to this window, as indicated by the 2: sh name of the terminal
In my setup, this actually shows the same tmux window as before, since the terminal window attaches to tmux when started. This is as expected in my environment
Hide the terminal window by toggling the panel, Cmd-J
Show the terminal again by toggling again, Cmd-J
Now, the tmux window shows a screen filled with “.” and in the lower right corner it says “(size 206x1 from a smaller client)” as if tmux was showing a much smaller window somewhere else (on the other “sh” tab?).
If I switch back to the “1: sh” terminal tab, the problem goes away and tmux is rendered correctly again.

This problem recurs every time I hide the terminal and then show it again. Then the screen is again filled with “.” as if it was actively showing on a much smaller window.
I have aggressive-resize turned on in tmux, but neither having it on or off makes any difference..
The problem also occurs if I resize Visual Studio Code while I have tmux visible and have two terminals.
You might well ask why I would create extra terminal windows, when tmux already has the functionality of multiple windows. The thing is that the debugger by default creates a new terminal (see #43683). So every time I start the debugger this problem occurs.

VSCode Version: 1.21.0-insider ce13bb0dabd06981913c46b5a94456647864c2e0
OS Version: macOS 10.13.3

This is a new problem for 1.21.0-insider. The release version 1.20.1 does not have this issue.

Does this issue occur when all extensions are disabled?: Yes

@Tyriar
https://github.com/tmux/tmux/blob/master/CHANGES#L141-L143 might be of your interest.
@joaomoreno

In my setup, this actually shows the same tmux window as before, since the terminal window attaches to tmux when started. This is as expected in my environment

I'm wondering if this is what you intended, or do you have an alternative setup. (Also I'm on tmux 2.6).
For me, this script breaks when you try to have more than 1 terminal:
#!/bin/bash
SESSION="vscode`pwd | md5`"
tmux attach-session -d -t $SESSION || tmux new-session -s $SESSION

The following works (dropped the -d), because when creating new terminal tabs it'll connect to the same session without dropping all others. If I have -d when creating second terminal, the first one will be detached and closed.
#!/bin/bash
SESSION="vscode`pwd | md5`"
tmux attach-session -t $SESSION || tmux new-session -s $SESSION

I'm also on tmux 2.6.

This is as expected in my environment

I'm wondering if this is what you intended,

I honestly didn't think of the -d parameter. I do sometimes run the same tmux window in different places, but I haven't actually used the fact that code starts two terminals with the same window, that's mostly confusing (until you realize what is happening). What I should have said was that I intended that a tmux window to be reattached rather than a completely new shell being started.
This is the script I'm using. It seems equivalent to your second one.
#!/bin/sh
SESSION="`pwd|sed "s#$CODE_DIR/##"|sed "s#$HOME/##"|sed "s#$HOME#~#"|sed "s#\.##"`-vscode"
tmux attach-session -t $SESSION || tmux new-session -s $SESSION

I actually think the -d version works pretty well. It destroys the original terminal when the debugger creates a new terminal, but the new terminal works. It also seems less prone to the problem of the periods.

I think there was a change in the way layout happens when splitting was introduced that was causing a bad layout to happen (cols = NaN).

Pushed to master and release/1.21


As a data editor, I want people records with VIAF URIs and no birth or death date to have dates automatically populated from VIAF data.

testing notes

From the main django admin page, access log entries in the administration section at the bottom
You should see log entries for all the person records that were updated by the data migration
Clicking a log entry should take you to the record for that person
Check a few records to confirm the birth and death dates are set as expected, and that the log entry accurately documents the change

dev notes
write data migration to:

find all person records with viaf id
populate birth/death date from viaf; save if changed
add log entry with script user to document the change

code for the first part is here: https://github.com/Princeton-CDH/mep-django/issues/801#issuecomment-2062202677

Perfect.


Feedback for: /fundamentals/getting-started/your-first-multi-screen-site/index.html

I'm not a UX/UI designer but I did not find it obvious that the "01" and "02" Guide links were actually links until I hovered over them.

Looked quite clear to me, honestly. What would you suggest that needs clarification?

I'm going to close this for now as we're working on a complete site refresh using material design lite which should fix this issue.