[CHANGE ME] Re-generated  to pick up changes in the API or client library generator.

This PR was generated using Autosynth. :rainbow:
Log from Synthtool
2020-07-18 04:26:40,729 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/nodejs-analytics-admin/synth.py.
On branch autosynth
nothing to commit, working tree clean
2020-07-18 04:26:40,861 synthtool [DEBUG] > Ensuring dependencies.
DEBUG:synthtool:Ensuring dependencies.
2020-07-18 04:26:40,870 synthtool [DEBUG] > Cloning googleapis.
DEBUG:synthtool:Cloning googleapis.
2020-07-18 04:26:43,211 synthtool [DEBUG] > Generating code for: //google/analytics/admin/v1alpha:google-analytics-admin-v1alpha-nodejs.
DEBUG:synthtool:Generating code for: //google/analytics/admin/v1alpha:google-analytics-admin-v1alpha-nodejs.
2020-07-18 04:29:59,386 synthtool [SUCCESS] > Generated code into /tmpfs/tmp/tmpf1m8x3ic.
SUCCESS:synthtool:Generated code into /tmpfs/tmp/tmpf1m8x3ic.
.eslintignore
.eslintrc.json
.gitattributes
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/publish.yml
.github/release-please.yml
.github/workflows/ci.yaml
.kokoro/.gitattributes
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/populate-secrets.sh
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/publish.sh
.kokoro/release/docs-devsite.cfg
.kokoro/release/docs-devsite.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.mocharc.js
.nycrc
.prettierignore
.prettierrc.js
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
Skipping: README.md
api-extractor.json
renovate.json
Skipping: samples/README.md
2020-07-18 04:30:00,096 synthtool [DEBUG] > Post-processing GAPIC library...
DEBUG:synthtool:Post-processing GAPIC library...
2020-07-18 04:30:00,096 synthtool [DEBUG] > Installing dependencies...
DEBUG:synthtool:Installing dependencies...
npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated<EMAIL_ADDRESS>Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

><EMAIL_ADDRESS>postinstall /home/kbuilder/.cache/synthtool/nodejs-analytics-admin/node_modules/protobufjs
> node scripts/postinstall

><EMAIL_ADDRESS>prepare /home/kbuilder/.cache/synthtool/nodejs-analytics-admin
> npm run compile-protos && npm run compile

npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>compile-protos /home/kbuilder/.cache/synthtool/nodejs-analytics-admin
> compileProtos src

installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>installing<EMAIL_ADDRESS>npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>compile /home/kbuilder/.cache/synthtool/nodejs-analytics-admin
> tsc -p . && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/watchpack-chokidar2/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 941 packages from 827 contributors and audited 943 packages in 33.172s
found 0 vulnerabilities

2020-07-18 04:30:33,666 synthtool [DEBUG] > Running prelint...
DEBUG:synthtool:Running prelint...
npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm ERR! missing script: prelint

npm ERR!
DEBUG:synthtool:Running fix...
npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>fix /home/kbuilder/.cache/synthtool/nodejs-analytics-admin
> gts fix

version: 12
2020-07-18 04:31:24,485 synthtool [DEBUG] > Compiling protos...
DEBUG:synthtool:Compiling protos...
2020-07-18 04:31:29,038 synthtool [DEBUG] > Post-processing completed
DEBUG:synthtool:Post-processing completed
2020-07-18 04:31:29,039 synthtool [DEBUG] > Wrote metadata to synth.metadata.
DEBUG:synthtool:Wrote metadata to synth.metadata.
ode.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm ERR! missing script: prelint

npm ERR!
DEBUG:synthtool:Running fix...
npm WARN npm npm does not support Node.js v12.18.2
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

><EMAIL_ADDRESS>fix /home/kbuilder/.cache/synthtool/nodejs-analytics-admin
> gts fix

version: 12
2020-07-18 04:31:24,485 synthtool [DEBUG] > Compiling protos...
DEBUG:synthtool:Compiling protos...
2020-07-18 04:31:29,038 synthtool [DEBUG] > Post-processing completed
DEBUG:synthtool:Post-processing completed
2020-07-18 04:31:29,039 synthtool [DEBUG] > Wrote metadata to synth.metadata.
DEBUG:synthtool:Wrote metadata to synth.metadata.

[ ] To automatically regenerate this PR, check this box.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0bb2cfd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   98.20%
=========================================
  Files             ?        5
  Lines             ?     6478
  Branches          ?      239
=========================================
  Hits              ?     6362
  Misses            ?      115
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb2cfd...c55728b. Read the comment docs.


Make GlobalRoles createable

more details to come

will need a UI change as well

need to protect against editing the built in roles

This functionality is needed for cluster templates RBAC

@cjellick note says we need to protect against editing built in role.
Yet this bug is referencing an issue which allows creating new global roles and setting them as default.
Could you provide more details please?

Closing in favor of https://github.com/rancher/rancher/issues/16216


Clearing color map from particle system in Editor leads to particles not playing

Create a particle system and set a color map
Launch
Clear the color map
Notice in launched tab that the particle system no longer plays

Fixed in https://github.com/playcanvas/engine/pull/415


Questions about Multi-type Joint Training in 2D-3D

     Hi，I had some questions during the joint training.In the process of 2D-3D single-class chair-based dataset training, the default image and voxel have separate file addresses. If we do multi-class joint training, do we need to write the addresses of all six categories of folders, or do we no longer need labels, and directly put the six categories of documents that need training on a single file, that is, the following Those two are the correct instructions for joint training.

one
parser.add_argument('-d','--data', default=['data/voxels/sofa','data/voxels/table','data/voxels/boat','data/voxels/car','data/voxels/plane','data/voxels/chair'], help ='The location for the object voxel models.' )
parser.add_argument('-i','--images', default=['data/overlays/sofa','data/overlays/table','data/overlays/boat','data/overlays/car','data/overlays/plane','data/overlays/chair'], help ='The location for the images.' )
another
parser.add_argument('-d','--data', default=['data/voxels/joint',], help ='The location for the object voxel models.' )
parser.add_argument('-i','--images', default=['data/overlays/joint',], help ='The location for the images.' )
  I don't know which one can be used, or my understanding of joint training is biased. I hope you can help me. Thank you.

I guess I didn't set it up well for joint training for this part. Neither of these would work though because that parameter is supposed to be a string not a list. I would suggest either using -d 'data/voxels//' and -i 'data/overlays//' or using Regex to select for the classes you want. I don't know what joint refers to here, maybe you altered the code?

Hi，I've changed the list to a string, and the ‘joint’ folder means to put together six voxel files downloaded and converted from the shapenet dataset,because I saw in your paper about the accuracy of joint training of multi-class data and so on, hoping to be able to use your code for multi-class training.
The main problem is that I don't understand the difference between training six class of data and the implementation of training single class like ‘chair’ based on code 20-VAE-3D-IWGAN.py.
Or do I mix six class of dataset to voxels folder and six kinds of image files together in overlays?
I don't know if it's right for many types of training. Six class of data can be directly mixed together without labels.
In addition, we need to generate the voxel model of 202020 for the operation of 2D-3D. I can't understand the reason, but I hope you can help me solve these problems. Thank you.

yes you just mix everything together, but should split by class when evaluating. I generate at 20/20/20 resolution because that is the resolution used to evaluate in the 3D GAN paper.

Thank you for your answer. It helps me a lot。


update issue template

it help to create a new issue.
and the issue gets more context than just some phrases..

Hey @Wenish, sorry the delay to reply here.
I believe requiring Expected Behavior, Current Behavior and Possible Solution might be too much, since most users of Colyseus have little to no knowledge of Node.js or networking. I like having Context and Your Environment, though.
Can you make this change? Cheers!

@endel np ;)
i took the 3 things out and added some more example lines in the "your environment" section.

Can you change "issue track" to "issue tracker"? Additionally, I think you should remove unity version from this template - if desired, it could be added to the unity plugin template.

@seiyria Agreed - Client-based frameworks should be restricted to their own repos issues, not colyseus

@seiyria i removed the line with unity and browser version

@endel what do u think?

Thanks @Wenish, it's looking good! 🤗


Build and Deploy GH pages failed

I have included the apollo theme as a submodule to my blog but there is an issue at build_and_deploy step. I will put down the errors below.
Error: Failed to build the site
Error: Error parsing templates from the /templates directory
Error: Reason: Io error while writing rendered value to output: NotFound
Error: Reason: Io error while writing rendered value to output: NotFound
I have tested in my local and it is working fine

If you still have this issue, feel free to reopen the issue. If you figured it out, you can mention how you solved it if others have the same issue.


[VSCode Extension] Version Mismatch

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
N/A
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
2.04
Describe the Bug
When I start the VSCode extension, it reports that there is an version mismatch. It looks like the client bundled with the extension has not been updated.
Relevant discord thread
[Info  - 8:05:35 PM] root uri: /var/folders/k2/bx96vkx13_g9hgmlc0pgj3600000gn/T/turbod/559b7a291e18e741/turbod.sock
[Error - 8:05:35 PM] Server initialization failed.
  Message: Internal error
  Code: -32603
[Error - 8:05:35 PM] Turborepo Language Server client: couldn't create connection to server.
  Message: Internal error
  Code: -32603
[Error - 8:05:35 PM] failed to connect to daemon: unable to make handshake: version mismatch: Some("version mismatch. Client 1.11.0 Server 2.0.0")

Expected Behavior
The VSCode extension should launch the client should connect to the daemon from the turbo 2.04 install.
To Reproduce
Install turbo > 2.0 and the latest VSCode extension (1.12) and try to start the extension.
Additional context
No response

Hey, thanks for this! A new 2.0 version has been released now.


HDDS-9072. Set isFile when creating OmKeyInfo for createFile code path

What changes were proposed in this pull request?
As part of change #3912 and #4448, isFile parameter was added to OmKeyInfo and OzoneKey but it was not set when new create file gets created it doesn't exist here.
This change is to set isFile on createFile code path so that it can properly identify if key is file or dir.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9072
How was this patch tested?
Updated unit tests.

Thanks @hemantk-12 for the patch. Thanks @aswinshakil @prashantpogde for reviewing it.


Refactor "check your answers" to be more modular

The old check your answers implementation grew organically to be very
brittle. Now that the requirements are clearer, refactor to a cleaner
solution.

Go all the way through to "check answers", then click, "Continue"
I18n::MissingTranslationData at /steps/details/check_answers
translation missing: en.steps.details.check_answers.show.heading

If you upload some documents (e.g. grounds for appeal or pro forma), then on the dropzone uploads page you check "I'm having trouble," the PDF version of the case still shows the documents you uploaded previously. It shouldn't do this, because the FTT staff have no way to access those documents.
The taxpayer MUST include those documents with their postal appeal, so it's important that we don't mislead them, and make them think we've already got some of their docs.

I've fixed the above issues and some more – now that today was a bit less rushed :)


Generation is not working

i am getting the above error but the data is in the txt file in the designated folder
even though this is not my data it is generating something else

pretraining is done good but getting errors.

Had the same error when using input text files which didnt have enough data and also when Augmentoolkit and the underlying LLM decided the data was not "worthy for questions" (check the folder with the same name there are files which say what and why)
Ive tried the following solutions which worked individually for me

adding more data, more text documents (it can handle more than one file)
Fiddling with the temperature of the AI model
retrying a few times from scratch

another thing i did was just change the files and say its Worthy for questions, though the results have been hit or miss

Hi!
Sorry for missing your issue for so long, had a crazy month over here. I appreciate your thorough error reporting.
There's recently been an update that lets you skip the filtering step entirely (under "SKIP" turn "FILTER_CHUNKS" on). This should help overcome the issue where your documents are something the AI doesn't really consider to be "traditional" educational questions.
Let me know if you're still encountering any problems, my schedule's stabilizing so I'll do my best to help you speedily.
And thanks for using Augmentoolkit!


Main Thread issue for iOS.

Hello !
I am a bit confuse with threading inside the MeetingObservers.h file.
Indeed, VideoTileObserver methods aren't implementing dispatch queue main. However, in the documentation it's specify that the method for VideoTileObserver are called on the main thread :
https://aws.github.io/amazon-chime-sdk-ios/Protocols/VideoTileObserver.html#/c:@M@AmazonChimeSDK@objc(pl)VideoTileObserver(im)videoTileSizeDidChangeWithTileState:
Am i missing something or is should we have :
- (void)videoTileDidAddWithTileState:(VideoTileState * _Nonnull)tileState {    dispatch_async(dispatch_get_main_queue(), ^{       [_bridge sendEventWithName:kEventOnAddVideoTile body:@{@"tileId":[NSNumber numberWithInt: (int)tileState.tileId], @"isLocal":@(tileState.isLocalTile), @"isScreenShare":@(tileState.isContent)}];    }); }
Instead of :
- (void)videoTileDidAddWithTileState:(VideoTileState * _Nonnull)tileState {   [_bridge sendEventWithName:kEventOnAddVideoTile body:@{@"tileId":[NSNumber numberWithInt: (int)tileState.tileId], @"isLocal":@(tileState.isLocalTile), @"isScreenShare":@(tileState.isContent)}]; }
Thanks for your answer !

Hi @LilianAlvarez123 ,
Thank you for reaching out!
VideoTileObserver callbacks were called using ObserverUtils.forEach() (example), which essentially implementing an async dispatch queue on main thread.
Let me know if that resolves your question. Thanks!
Best,
Tianyu


net/http: panic when a nil HandlerFunc is passed to http.HandleFunc

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.9.2
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
amd64 linux
What did you do?
package main

import "net/http"

func main() {
    http.HandleFunc("/", nil)
    http.ListenAndServe(":8080", nil)
}

What did you expect to see?
when I go run this file, the nil error appears not  in compilation time but in run time. The reason is that http.Handler(http.HandlerFunc(nil)) == nil is false. BUT use reflect we can know the value of http.Handler(http.HandlerFunc(nil)) is nil, so the error should be stopped in compilation time by fix Handle function.
What did you see instead?

Please finish filling in the issue template, specifically what did you see
when you ran your example.
What would be the ideal resolution to this bug for you?
On 7 March 2018 at 23:22, wangsong93<EMAIL_ADDRESS>wrote:

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.9.2
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
amd64 linux
What did you do?
package main
import "net/http"
func main() {
http.HandleFunc("/", nil)
http.ListenAndServe(":8080", nil)
}
What did you expect to see?
when I go run this file, the nil error appears not in compilation time but
in run time. The reason is that http.Handler(http.HandlerFunc(nil)) == nil
is false. BUT use reflect we can know the value of
http.Handler(http.HandlerFunc(nil)) is nil, so the error should be
stopped in compilation time by fix Handle function.
What did you see instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/24297, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA3FK20x0q5p1QSu-o8vnaJZTIaQ7ks5tb9ECgaJpZM4SgWre
.

I guess he would like to say that it is a matter of panic occurring after the mux actually received the request. It will be something like the following error:
http: panic serving [::1]:51880: runtime error: invalid memory address or nil pointer dereference

And it is possible to generate a more descriptive panic by actually checking whether it is nil at the timing when HandleFunc is called without using reflect. It would be something like:
diff --git a/src/net/http/server.go b/src/net/http/server.go
index a7ba753bf5..04a0444140 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -2358,6 +2358,9 @@ func (mux *ServeMux) Handle(pattern string, handler Handler) {

 // HandleFunc registers the handler function for the given pattern.
 func (mux *ServeMux) HandleFunc(pattern string, handler func(ResponseWriter, *Request)) {
+       if handler == nil {
+               panic("net/http: handler must not be nil")
+       }
        mux.Handle(pattern, HandlerFunc(handler))
 }

/cc @bradfitz @tombergan

We won’t be able to catch this at compile time. @namusyaka’s fix seems reasonable unless I’m missing something.

I mean how to reproduce the panic in following code even if the 2nd parameter is nil
func (mux *ServeMux) Handle(pattern string, handler Handler) {
	mux.mu.Lock()
	defer mux.mu.Unlock()

	if pattern == "" {
		panic("http: invalid pattern " + pattern)
	}
        // if reflect.ValueOf(handler).IsNil() { // this can be a solution
	if handler == nil {
		panic("http: nil handler")
	}
	if mux.m[pattern].explicit {
		panic("http: multiple registrations for " + pattern)
	}

@wangsong93 I don't think it is a solution about the issue. Since it is called on every request, it should not be an essential solution.
In order to solve the issue you reported, it is enough to check the second argument when http.HandleFunc is called.

@namusyaka  yes, your solution is better and I agree. My solution is just used to verify my idea. Nil parameters should be stopped as earlier as possible.


Release 1.1.16

on the docket:

#318
#322
#323

this is complete: https://pypi.python.org/pypi/pex/1.1.16


⚠ Turnos 24x7 has degraded performance

In 9ed358c, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 898 ms

Resolved: Turnos 24x7 performance has improved in 2571f80.


Add feature to append additional text to nomination reasons

Implements changes discussed for #2937

Hey @Esther-Goldberg, any updates on this PR? Thanks.


Layout Monitor Crashes

When I attempt to take three feeds and place them next to each other horizontally on a single row it causes my monitor to lose signal.  As soon as I stop the service the monitor comes right back.  I have tested the issue extensively with the 3x3 layout as well as a custom layouts and the key seems to be when the third feed horizontally is started the monitor crashes.  It doesn't matter where vertically I place that row.
When I stack three feeds vertically (row 1, row 2, row 3) it works just fine as long as I don't have three feeds in a single row.  This includes a row on the right of the screen.

Raspbian Buster Lite
Raspberry Pi 3
Fully Updated
Resolution Configured via raspi-config to 1920x1080

Any troubleshooting tips?  I can't find anything useful in logs.

What are you using for a display that you have to manually configure the display resolution?  I run 14 displays 24/7 in my office on a 3x3 layout on a 1080p monitor (with a 3b), and two RPis (1b units, believe it or not) with 6 streams on 1080p monitors (in a large_left layout).
What resolution and bit rate are your feeds?
Post your layout config file if possible.
What does this mean, "This includes a row on the right of the screen."?  Rows are positioned vertically, not horizontally.

I meant vertically.  I use a Samsung TV with a display of 1920x1080, I didn't have to set the resolution but I played with various resolutions trying to see if it would resolve my issues.
The feeds are 1024x576 at 3000 bit rate.
My layout is below:
# This is the camera feed/windows layout configuration file for the
# displaycameras service.  It ONLY configures the layout and feeds for
# the cameras; the rest of the configuration is in displaycameras.conf.
# See the comments in that file for notes on configuring the below.

# Window names

# 3x3 screen with 1 off-screen windows
windows=(main upper_right center_right lower_left lower_middle lower_right)

# Windows positions
window_positions=(
#main
"0 0 1279 719" \
#upper_right
"1280 0 1919 359" \
#center_right
"1280 360 1919 719" \
#lower_left
"0<PHONE_NUMBER>" \
#lower_middle
"640 720 1279 1079" \
#lower_right
"1280 720 1919 1079"
)
# Camera Names
camera_names=(cam1 cam2 cam3 cam4 cam5 cam6)

# Camera Feeds
camera_feeds=( \
rtsp://192.168.1.X:7447/[REMOVED] \
rtsp://192.168.1.X:7447/[REMOVED] \
rtsp://192.168.1.X:7447/[REMOVED] \
rtsp://192.168.1.X:7447/[REMOVED] \
rtsp://192.168.1.X:7447/[REMOVED] \
rtsp://192.168.1.X:7447/[REMOVED]
)

# Are we rotating cameras through the window matrix? (default false if not set here)
#rotate="false"

Everything displays fine until I try and include that 6th camera in the bottom right corner.  Playing around with the configs I also found that when I used the 3x3 as soon as the top right corner camera was getting displayed it would cause the issue as well which made me conclude it was related to the three feeds on a single row.

Your response made me realize I hadn't tried lowering the resolution (quality) of the feeds.  I replaced the feeds with low quality (640x360) and it worked perfectly.

I did some experimenting and determined if I have 3 feeds next to each other on a single row I can only have 1 of the 3 feeds at "medium" quality (1024x576) or I will trigger the issue.

I believe I am having similar issues.  I am trying to run a 4x4 grid of  low res 640x360 cameras and when it gets to the third row and second camera, it no longer displays.  After a minute or two, the whole screen goes blank.
A restart of displaycameras starts the camera streams again.
Here's my layout:
#Screen11Kiosk
# This is the camera feed/windows layout configuration file for the
# displaycameras service.  It ONLY configures the layout and feeds for
# the cameras; the rest of the configuration is in displaycameras.conf.
# See the comments in that file for notes on configuring the below.

# This example defines seven 1/2-HD windows, three of which are off-screen to the right,
# through which the service rotates six camera feeds (it actually uses only six windows)
# on a full-HD monitor.  If this suites your needs, modify only the camera names to taste
# and feed URLs to what your cameras or NVR provides.

# Window names

# 4x4 screen, 4 rows and 4 columns
windows=(1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16)
# Make sure to account for each window above in the list below.

# Windows positions

window_positions=(

#First Row
#1
"0 0 479 269" \
#2
"480 0 959 269" \
#3
"960 0 1439 269" \
#4
"1440 0 1920 269" \

#Second Row
#5
"0 270 479 539" \
#6
"480 270 959 539" \
#7
"960 270 1439 539" \
#8
"1440 270 1920 539" \

#Third Row
#9
"0 540 479 809" \
#10
"480 540 959 809" \
#11
"960 540 1439 809" \
#12
"1440 540 1920 809" \

#Fouth Row
#13
"0<PHONE_NUMBER>" \
#14
"480<PHONE_NUMBER>" \
#15
"960 810 1439 1080" \
#16
"1440 810 1920 1080" \

)

# Camera Names

camera_names=(FLR1HALL FLR15GR FLR15G FLR2GR FLR2HALL FLR2G FLR25GR FLR25G FLR3HALL FLR3GR FLR3G FLR35GR FLR4HALL FLR35G FLR4GR FLR4G)
# Make sure to account for each camera above in the list of feeds below.


link docs and add badge to readme

Adds link and badge to README
Adds basic readthedocs config file (with docutils fix because it creeps up and was hard to diagnose)
Combine Intro and Index into one page to improve landing page in RTD

Link to this version of the docs: https://ats.readthedocs.io/en/task-white238-link_docs/

@dawson6 I will leave merging up to you and I'm ready to address any concerns you bring up in this PR.

thank you


Allow |, &, and ^ operators to have null/undefined inputs

Fixes #22230
Would make #22088 simpler

I like this change, ofc. @rbuckton you're a real fan of the undefined-is-implicitly-bitwise-zero pattern; you agree with this?

TIL
I'm hesitant on this because (a) you could just use ! and (b) this reasoning applies equally to e.g. "foo" | 0 (which is 0). If the logic is "It doesn't return NaN" then [3] | { } should be legal too, because the binary bitwise operators always return an int. I'm strawmanning of course, but what about e.g. string | number as an operand? Probably most codebases with a flag value would treat null/undefined as 0 but I'm not convinced that it's all of them.

Ofc, the reason we want it is because we use the fact that null/undefined are effectively zero in bitwise ops extensively inside our codebase. Tbqh, I think the question to ask, is how often does forcing you to handle null/undefined explicitly here find an error, versus just forcing you to write (and slowly become blind to) nonnull assertions.

Note: "1" | 2 is 3, as is ({ toString() { return "1" } }) | 2, so not a good idea to rely on anything else being treated as 0.


Add-PnPFile fails when content-type switch is provided

Hi PnP !
I'm facing an issue when trying to upload a file to a SharePoint library using Add-PnPFile.
According to the docs I'm able to do this:
Add-PnPFile -Path "C:\Users\me\documents\file.docx" -Folder "My Library" -ContentType "My awesome CT" -Values @{customFieldName="value"}

It fails with this error:

Add-PnPFile: The folder specified does not have a corresponding list

Same error when uploading with the server relative path to the folder, like:
Add-PnPFile -Path "C:\Users\me\documents\file.docx" -Folder "/sites/myAwesomeSite/My Library" -ContentType "My awesome CT" -Values @{customFieldName="value"}

However, this works like a charm:
Add-PnPFile -Path "C:\Users\me\documents\file.docx" -Folder "My Library" -Values @{customFieldName="value"; ContentTypeId="0x0101..."}

Environment:

SharePoint Online
Team site collection (Office 365 group site created via Teams)
Connected using legacy Add-In ClientId/Secret (company won't grant me AAD app access)

Great job with this by the way, saves us a ton of time :)

@Tinathnath  - thanks for flagging this issue. It has been fixed. Will be available in the nightly tomorrow and in the next major release.


add a new project for SIM70x0

a new project to support sim70800, sim7090 ...

lib/cellular/modules/sim70x0 also requested a pull.


Remove Flutter from Dogfooding scripts

What does this PR do?
Removes all dogfooding steps that push new versions to the Flutter repo.
Motivation
Flutter is now developing off source and will "pull" new versions when it deploys. This removes the Android step of "pushing" the new releases as that is no longer necessary
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1120 (8c772af) into develop (8ba3c1f) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1120      +/-   ##
===========================================
+ Coverage    83.24%   83.29%   +0.05%
===========================================
  Files          273      273
  Lines         9372     9372
  Branches      1504     1504
===========================================
+ Hits          7801     7806       +5
+ Misses        1153     1147       -6
- Partials       418      419       +1

Impacted Files
Coverage Δ

...android/rum/internal/ndk/DatadogNdkCrashHandler.kt
87.57% <0.00%> (-1.62%)
:arrow_down:

...rc/main/java/com/datadog/opentracing/DDTracer.java
55.65% <0.00%> (+0.42%)
:arrow_up:

...ain/java/com/datadog/opentracing/PendingTrace.java
57.76% <0.00%> (+1.72%)
:arrow_up:

...droid/rum/tracking/FragmentViewTrackingStrategy.kt
86.96% <0.00%> (+4.35%)
:arrow_up:

...ndroid/core/internal/persistence/file/EventMeta.kt
90.00% <0.00%> (+10.00%)
:arrow_up:

...android/log/internal/logger/TelemetryLogHandler.kt
100.00% <0.00%> (+25.00%)
:arrow_up:


Bug Report (Submitted by 4880)

Description
Collection page keeps refreshing
Reproduction Steps
Go to Collection
Operating System
Windows
Browser
Chrome
Device
Mobile

duplicate


tcpbridge reconnect doesn't work

Traceback (most recent call last):
  File "/tcpbridge.py", line 65, in work
    buf = i.recv(2048)
ConnectionResetError: [Errno 104] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tcpbridge.py", line 97, in <module>
    tt.work()
  File "/tcpbridge.py", line 67, in work
    i.connect()
TypeError: connect() takes exactly one argument (0 given)

think I wrote the reconnect code blind so no wonder I got it wrong :/

Also, should handle late connect, i.e. we try to connect on start but the VR hasn't been brought up yet so we get connection failure:
kll@docker-ci:~/vrnetlab/tcpbridge$ docker logs drunk_hamilton
Traceback (most recent call last):
  File "/tcpbridge.py", line 96, in <module>
    tt.add_p2p(p2p)
  File "/tcpbridge.py", line 39, in add_p2p
    left.connect(src)
ConnectionRefusedError: [Errno 111] Connection refused

Seems to be fixed through 820296e - closing.


Fixing Spanish translation on index.md

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@chino1504 Please complete the checklist for a review.


Adding classification export to ee.ImageCollection() and updating classification values in Methods doc

Okay, not much tangible change here, except the added loop to export the classified images to a GEE Image Collection. This completed successfully for LS7 and I will be running the other missions ASAP. I also fixed my oopsie with the classification values in the Methods Summary.
Tagging both @lindsayplatt  and @hdugan here, so that whoever gets here first can look and approve and catch any spelling errors! :)

And now with image viewer links for Landsat 7-9.

That's perfect. I'll have something of more substance soon, going to add my code to grab the corresponding data from the volunteers to double check values (for user error) and to make sure we aren't including any cirrus-contaminated data in our labels.


can you share the old docs for python app which contains detailed steps about how to use git deployment?

The python web app doc seams changed. And in the old doc, it has detailed steps which we can specify the python version, and also use git deployment. can you share a link to the old docs? thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0077a811-b0b7-93b1-80b0-a4d45615ef4b
Version Independent ID: cc95198d-5560-2bf1-09ae-b8d210e45f2d
Content: Create Python app on Linux - Azure App Service
Content Source: articles/app-service/containers/quickstart-python.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@imeya, Looks like you're referring to this document Configure your Python app for Azure App Service, hope this helps!

@imeya, Just checking in to see if the above suggestions helped or you need further assistance on this topic.

@Imeya, Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


clamping in model

Hi Hzwer, hope you're well.
I wonder would it be useful to move 0, 1 clamping from model to the inference logic?
In vfx world it is normal to have values over 1 in images and it should be preserved when deaing with exr images
Thank you!

Hi talosh! I think it's easy to add a flag to control that clamp. I want to know what's the value range in vfx world? Is it possible to normalize all the values to 0~1?

It is normal to have bright areas hitting 3-4 and even more in the bright areas in linear space. If I just comment out line 191 with pred = torch.clamp(pred, 0, 1) it works perfectly fine, the question is rather do you think it should happen in the model or in, say, inference_image or inference_video code when we're more aware of the nature of incoming images.


^ Error [ERR_REQUIRE_ESM]: require() of ES Module

use  nestjs
const chatgpt_1 = require("chatgpt");
^
Error [ERR_REQUIRE_ESM]: require() of ES Module

It doesn't work in nestjs framework.
It still emit error "const { ChatGPTAPI } = await Promise.resolve().then(() => __importStar(require('chatgpt')));"

@h-gyeom other people have posted the same thing and gotten it to work with nestjs. Please search the github issues.

I created a starter repository for NestJS + ChatGPT:
https://github.com/mitkodkn/nestjs-chatgpt-starter
Hope it helps.


Adding: Password Changes, Password Resets, Temporary Sign-ins

Hi there, we've been using this package at our company for a little while now, and needed some additional features, and thought I'd contribute them back.
Our key requirement was that we needed a flow to reset passwords, temporarily sign-in with the reset token, and change the password. Those three actions are the basis of this PR.
Cheers!

Hi @kylecorbelli would you be interested in merging this or shall I close the PR? Cheers


Build : Manifest missing public url

Dear All,
I think I found a bug in the build of OHIF, if I use PUBLIC_URL=/viewer/ at build command, the index.html correctly integrates the relative path of OHIF viewer but not the manifest.json
And so I got some error message in the console saying the browser can't retrieve the chrome logo (for which the location is in the manifest.json)
this issue however do not impact viewer usability
Best regards,
Salim

Relates to #1125

probably solved, outdated issue


Activate app before showing alert

On macOS this would call NSApp.activate(ignoringOtherApps: true).
Our app is mostly living in the system tray (using https://github.com/leanflutter/tray_manager) and therefore might not be active when an alert is shown. This behaviour could be optional.

Fixed in 0.2.2.


Add angrymouse/remote-functions to made in Ukraine collection

Add my RPC framework because it has pretty good codebase for showcase and I live in Ukraine :)

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md.
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

I added this repo because it have good codebase and made in Ukraine

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi,
Thanks for starting this pull request. In order to review it for acceptance, we need to make sure that all of the prerequisites are satisfied. I see that you didn't check this:

I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee)

This is a requirement so that we can maintain a high level of independence in this project. Please update if you are able to verify that you meet that requirement.
Thanks!

We have to also add "as a maintainer friend" 😃 😈


Make dependencies are not working.

Describe the bug
I moved from the BLE_OTA demo to the OTAandHelloWorld demo. Changed aws_credentials.h file to a different device name from running  "py SetupAWS.py setup", but the old name was presented in the firmware after doing the build.
I did a make clean, then a make, and it fixed the problem. But this demonstrates the dependencies in the make files are not correct.
console output to explain the issue. If possible, include the call stack.
To reproduce
Steps to reproduce the behavior:

Run "py SetupAWS.py setup" with "device one" name. Do a "flash monitor" of the firmware.
Run "py SetupAWS.py setup" with "device two" name. Do a "flash monitor" of the firmware.
Watch the output from the device. The name of "device one" shows up in the serial output.
Do a "make clean"
Do a "flash monitor" of the firmware. Now you see the "device two" name.

The device name is just a leading indicator that the firmware is not built right. The entire debug output did not match. For example, wifi did not start up when going from a BLE only demo to a WiFi demo.   After doing the make clean, then WiFi init was part of the startup output.

Hello,
This was fixed in release-1.5 branch. It won't be carried over to this branch.
Hugues


Automated accessibility testing?

Should we add automated accessibility testing? There are a few tools which might help:

https://github.com/pa11y/pa11y
https://github.com/dequelabs/axe-core

Looks like pa11y uses axe-core, under the hood.

Lighthouse might also help here: https://github.com/GoogleChrome/lighthouse

Other things to consider:

https://www.npmjs.com/package/cypress-axe
https://github.com/pa11y/pa11y-ci


LoRa : Lower bandwidth settings are not listed/supported

https://github.com/zephyrproject-rtos/zephyr/blob/38e86c8e86f8bc9b0c0794edc26151f7907145cf/include/zephyr/drivers/lora.h#L34C1-L34C1
LoRa physical layer supports bandwidths lower than 125 kHz. 62.5 kHz for example. I am not sure why they are not supported here. I am developing some firmware on an NRF board and got stuck here trying to set the bandwidth lower.

It is difficult for me to tell whether you are reporting a bug or asking a question. If you are reporting a bug, please use our bug template when reporting bugs. You need to edit this issue to include the information requested in https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/001_bug_report.md

It is difficult for me to tell whether you are reporting a bug or asking a question. If you are reporting a bug, please use our bug template when reporting bugs. You need to edit this issue to include the information requested in https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/001_bug_report.md

@henrikbrixandersen Thank you for the guidance. Actually I'm not sure if it's a bug or a question at this point. Perhaps the Zephyr devs ommited those bandwidths for some reason? Otherwise, LoRa does support bandwidth as low as 7 kHz as well. If anyone who worked on the LoRa parts can comment on this, I can definitely edit the issue and add relevant details based on their comment.

While the physical layer may support it, loramac-node (which is the base of our LoRa support) only exposes the 125kHz, 250kHz and 500kHz bandwidths.
https://github.com/Lora-net/LoRaMac-node/blob/6384af8f4c4a57016c83f3d34430f0f68855e695/src/radio/radio.h#L210-L249
This is therefore not a Zepyhr limitation, but inherited from upstream. If this is an important issue for you, I would suggest contributing support in that project, which can then be integrated here.

@JordanYates Thank you so much, I'll take it up there and come back to this issue once it's fixed upstream.

I'll close this for now, feel free to re-open once loramac-node supports other settings


Handle LazyModuleMixin Properly

🚀 Feature
Is it possible to add an optional initialize_loop prior to configure_optimizer and compute model summary? The initialize_loop shall be supplied with a batch of training data that can be used to run through LazyModuleMixin so that unintialized parameters can be initialized.
Motivation
I don't know start from which version of PyTorch, it introduces a convenient way to construct a module that eliminates the need to calculate input shapes for each individual layer. However, the tradeoff is that it relies on passing one dummy batch of data to the model prior to configure optimizer and training the model.
Currently, the Trainer.fit does things in the following order:

attach data loader
configure accelerator strategy
call model.on_fit_start()
call model.configure_optimizers()
if sanity_check, run validation loop with num_sanity_val_steps batches of validation data.
start running training loop.
call model.on_fit_end()

However, the current flow throws UninitializedParameter error when configure_optimizers method is called. To get around the issue, currently I will have to initialize the parameters outside pl.Trainer by loading one batch of training data module to the model on my own, which involves manually setting up which accelerator I should for the initialization loop.
Pitch
I suggest adding an additional hook for the initialization loop and let lightning takes care of setting up proper accelerator and supplying one batch of training data. The proposed new workflow for Trainer.fit is presented as follows:

attach data loader
configure accelerator strategy
call model.on_fit_start()
run one optional initialization loop to initialize module parameters.
call model.configure_optimizers()
if sanity_check, run validation loop with num_sanity_val_steps batches of validation data.
start running training loop.
call model.on_fit_end()

Alternatives
Without the new features, I will have to write initialization loop that looks like the following:
model = ModelWithLazyModule()
for batch in train_loader:
  device = torch.device("cuda") if torch.cuda.is_available() else torch.device("cpu")
  batch = batch.to(device)
  model(batch)
  break
trainer = pl.Trainer()
trainer.fit(model, train_loader)

Additional context
To my knowledge, people mentioned UninitializedParameter in #7546 and #7642. It seems to focus on computing model summary table if I understand correctly.
Also, Lightning backend is complicated to me and I know I am not capable of implementing this feature on my own.
cc @borda @akihironitta

Thank you for the proposal. We should absolutely add tests that use lazy modules to ensure things work well

This also triggers errors when using DDP, which doesn't support PyTorch UnitializedParameter. The solution I am using right now is to implement a setup hook in my LightningModule:
    def setup(self, stage):
        match stage:
            case 'fit':
                dataloader = self.trainer.datamodule.train_dataloader()
            case 'validate':
                dataloader = self.trainer.datamodule.val_dataloader()
            case 'test':
                dataloader = self.trainer.datamodule.test_dataloader()
            case 'predict':
                dataloader = self.trainer.datamodule.predict_dataloader()
        dummy_batch = next(iter(dataloader))
        self.forward(dummy_batch)

I suppose a similar logic can be implemented natively in LightningModule or Trainer?

Could you instead use on_before_batch_transfer or on_after_batch_transfer for it? Then you wouldn't need to create the dataloader yourself.

Could you instead use on_before_batch_transfer or on_after_batch_transfer for it? Then you wouldn't need to create the dataloader yourself.

Thanks for the hint. I'll check it out.

Could you instead use on_before_batch_transfer or on_after_batch_transfer for it? Then you wouldn't need to create the dataloader yourself.

It seems on_before_batch_transfer and on_after_batch_transfer are called for every batch, whereas for DDP one forward call with a single dummy batch is sufficient to initialize UnitializedParameters in Lazy Modules.

You can use https://pytorch.org/docs/stable/generated/torch.nn.modules.lazy.LazyModuleMixin.html#torch.nn.modules.lazy.LazyModuleMixin.has_uninitialized_params to only do it when necessary

Using on_before_batch_transfer or on_after_batch_transfer didn't work for me since DDP is initialized prior to either of these methods being called. @libokj's method of a setup hook worked for me.

Using on_before_batch_transfer or on_after_batch_transfer didn't work for me since DDP is initialized prior to either of these methods being called. @libokj's method of a setup hook worked for me.

Thanks for the feedback. Been busy with research and haven't had time to try that yet.

@carmocca @tmlabonte https://github.com/Lightning-AI/lightning/blob/4ad8bdbe205787e7b06f3bd3f1e2ceb599414ef3/src/lightning/pytorch/trainer/trainer.py#L951-L990
At L996, the strategy is setup, which already triggers the RuntimeError in DDP:
https://github.com/pytorch/pytorch/blob/8820dda943ac471933d0d8cc4b640c78181c2a86/torch/nn/parallel/distributed.py#L765-L770
The model epoch hooks are not called until L990 where the trainer runs trainer loops. However, the model setup hook is called at L951, before the strategy is initialized. That is why the setup hook hack worked but on_before_batch_transfer (an epoch hook) hack doesn't work.

That makes sense. Thanks for taking a look.
What do you think here @awaelchli? Should the Trainer do this or should we leave it to the user?


Old Messages

Messages written before a user opens the page do not appear

You have to store each message in a database and load them on page load.

Thank you


PathVerifier should check specifically for invalid use of volume separator and tolerate alt dir separator

Fixes #283
Fixes #320
^ Lots of information on the issue (#320) about how things are handled in Unix, Mono and the .NET Framework reference implementation of File.Copy/File.Move.

PathVerifier.IsLegalAbsoluteOrRelative now throws NotSupportedException on Windows only when the path contains an invalid use of the drive separator char.
Renamed 8 tests to mention ArgumentException instead of NotSupportedException.
Added 8 tests for invalid drive separator specifically.
Updated 4 Windows only tests to test invalid path chars other than drive separator.

@fgreinacher Applied suggested changes. Made code simpler and easier to understand. Thanks.

@jpreese Made suggested changes, except for the volume separator one, which I don't know what to do for.

Merging this one. If we want to do something for the volume separator disuccuisb we can do that in a separate PR.


Post-ICON Merger stats page upgrade

This epic groups issues related to displaying new data related to the icon merger and burning icx.

#183
#177


Consider optionally use openssl for windows

Schannel crate is far from being feature-complete, does not support the server-side, and openssl works just fine on windows.
I suggest optionally use openssl for windows (add it as a feature to native-tls).
It could help build trust-dns on windows: https://github.com/bluejekyll/trust-dns/pull/103

Schannel does support server-side TLS.
If you want to use OpenSSL, then it seems to me like you should use OpenSSL? This crate is designed specifically for the use case of "I don't need any complex features, I just want a thing that works with the minimal possible effort".

The readme says otherwise: https://github.com/steffengy/schannel-rs/blob/master/README.md
I think this crate can achieve both goals: work with the minimal possible effort, and support more complex features.
After all, it's the only crate I know that provides a common interface to several tls libraries.

I've fixed the schannel readme, thanks.
Many crates support pluggable TLS implementations, including hyper, rust-postgres, etc.

Ha, looks like we ended up in the same place.
@sfackler there's a similar discussion I have over on https://github.com/bluejekyll/trust-dns/pull/103
Right now I'm using the @alexcrichton 's tokio-tls crate. This request to use OpenSSL instead of native. I see your comments above about everyone using pluggable TLS implementations, and I could do the same, but the concern I have is that we may end up with a lot of duplicate code, and some of it complex in the case of tokio.
My thought was, why not just have a feature on native-tls for always using OpenSSL, obviously defaulting to the native platform. This would allow for shared code up the stack, with native-tls being the common TLS abstraction layer (much like MIO is for async IO). Thoughts?

There isn't much complex duplication in my experience: https://github.com/sfackler/rust-postgres/blob/master/tokio-postgres/src/tls/openssl.rs.

This would allow for shared code up the stack, with native-tls being the common TLS abstraction layer (much like MIO is for async IO).

This is the wrong layer to abstract at IMO. If you want to use OpenSSL in particular and that had to be done through native-tls, you'd have to do half of the setup through native-tls APIs, import the trait that lets you downcast, and then do the other bit of configuration. It seems way simpler to just use OpenSSL's APIs directly and have the trait abstraction layer be at the level of "wrap this stream with TLS".

Yes, I've been considering a pattern around this, definitely. The hyper style interfaces look good. The concern I have is really duplicating the tokio support for MidHandshake in the tokio-tls library. This is currently a state machine over the native-tls libraries abstractions. I'd prefer not to duplicate that code unnecessarily.
Though I do agree with you that there is a lot of custom code that needs to exist to demux between the native libraries. Perhaps there is no way around having to duplicate some of this, but I was hoping not to.

I personally agree with @sfackler that if you want to use OpenSSL then you should use OpenSSL (the crate). Also note that we've got tokio-openssl as a crate as well.
Over time I've come to find native-tls switching backends via features a little odd. That means that downstream code which wants to use the extension traits now has no reasonable way to do so (b/c it doesn't know what will be activated without gymnastics).

Oh I missed the tokio-openssl crate... I was about to ask you if I shoudl start one. I guess this is a no-op for me.
I propose closing this issue then.

@alexcrichton thanks for the insight.


A draft one-pager around resource usage

Description of your changes
This PR seeks review of an initial draft of a one-pager (four-pager?) around the concept of a "resource usage", i.e. an association between a resource claim and a Kubernetes object consuming said claim. This is an early draft, in which I expect there to be a lot of holes, but I'd like to further the conversation around this concept.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the RBAC permissions in clusterrole.yaml to include any new types.

@lukeweber @bassam @ichekrygin @prasek I'd like to expedite the feedback process on this one pager. There's some pretty fundamental changes proposed (e.g. making resource classes and managed resources cluster scoped). Would it help to setup a call to discuss?

@negz would love to be included on call if it happens

@bassam You mentioned you wanted to discuss this design. Should we setup some time to do so in person, or would you prefer to leave feedback on this PR?

I synced with @bassam today to help sanity check this proposal. Some notes:

Cluster scoped managed resources and resource classes seem like a reasonable direction. The pattern has symmetry with PersistentVolume and StorageClass, which are cluster scoped. It helps model the Crossplane separation of concerns, in that the operator persona deals in cluster scoped resources, while the developer persona deals in namespace scoped resources (claims, usages).
Several Crossplane developers are meeting soon to discuss #580. We'd like to use that exercise to further validate that cluster scoped managed resources are sensible.
We won't introduce cluster scoped secrets - if we really wanted this it would fit better upstream. Instead we'll use a variant of an existing pattern in which cluster scoped resources write any sensitive connection details to plain old namespaced secrets.
We will require, at least by convention, a resource claim to exist in order to consume a managed resource. This means managed resource secrets will be consumed only by other Crossplane controllers, not humans, and their API/UX will reflect this.
It may be preferable to 'embed' resource usages in some cases, for example it may be preferable for a KubernetesApplication to specify its usages inline rather than via a distinct resource. Embedding resource usages ties the usage's lifecycle to the type using it, but requires more thought. This pattern is not possible for any consumer that is not part of the Crossplane ecosystem, such as a Deployment. It may also prevent us writing controllers to act upon specific kinds of usage.

We've made no progress on this PR in several months, so I am going to close it.


why is my loss so high ? and my val_loss is nan?

hi guys,
i configurate my yolov3_1c.cfg with
Line 3: set batch=24, this means we will be using 24 images for every training step
Line 4: set subdivisions=8, the batch will be divided by 8 to decrease GPU VRAM requirements.
Line 603: set filters=(classes + 5)*3 in our case filters=15
Line 610: set classes=1, the number of categories we want to detect
Line 689: set filters=(classes + 5)*3 in our case filters=15
Line 696: set classes=1, the number of categories we want to detect
Line 776: set filters=(classes + 5)*3 in our case filters=15
Line 783: set classes=1, the number of categories we want to detect
and i get the following output, here you can see that my loss is very high and my val loss ist nan.

i have read that i should to change my code referenced on this issue #79
but i downloaded the repository a few days ago
i have checked, that my code is updated with this reference #79
please help me :)
best regards

.

.

.

.

.

.

.

.

.

.

I trained the model without pretrain weights to solved this issue.

Why the loss is so big? Same issue. The loss is right?

I trained the model without pretrain weights to solved this issue.

How did you do this? Can you explain? I'm currently having this issue as well

@phamngocthanhtrung  have you resolved the problem yet?

Guys I recommend to reduce your batch size if you get a crazy high loss. Batch size 32 is pretty big and not suitable for some projects.

thanks your suggestion @remcova .
Actually, now I try to train with only one sample with batchsize =1 to see if the model can overfit this sample or not. But the  train_loss is converged at  ~ 5.00, I am trying to manually reduce the learning rate but it didn't help.
Am I right to say the train loss should be in range [0,1]
Do you have any idea?

@vuthede Makes sense but I'm not sure if it's correct. It's weird that the train_loss is converged at 5.00. If you want to know how well your model performs, I would recommend to use other metrics for example the F-measure (F1-score). That's what i'm using currently. It would be nice if @qqwweee takes a look at this issue.

I posted my solution in here. Hope it would help
https://github.com/qqwweee/keras-yolo3/issues/171#issuecomment-522287613


HDDS-1385. Make the ozonesecure-mr environment definition version

see: https://issues.apache.org/jira/browse/HDDS-1385
This is a PR on top of  HDDS-1333

@elek can you rebase against latest ozone-0.4 after HDDS-1333 is in?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

0
yamllint
1
yamllint was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ ozone-0.4 Compile Tests _

+1
mvninstall
983
ozone-0.4 passed

+1
compile
50
ozone-0.4 passed

+1
mvnsite
31
ozone-0.4 passed

+1
shadedclient
635
branch has no errors when building and testing our client artifacts.

+1
javadoc
20
ozone-0.4 passed

_ Patch Compile Tests _

-1
mvninstall
20
dist in the patch failed.

+1
compile
17
the patch passed

+1
javac
17
the patch passed

+1
mvnsite
22
the patch passed

+1
shellcheck
0
There were no new shellcheck issues.

+1
shelldocs
15
There were no new shelldocs issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
736
patch has no errors when building and testing our client artifacts.

+1
javadoc
14
the patch passed

_ Other Tests _

+1
unit
19
dist in the patch passed.

+1
asflicense
24
The patch does not generate ASF License warnings.

2741

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-695/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/695

Optional Tests
dupname  asflicense  mvnsite  compile  javac  javadoc  mvninstall  unit  shadedclient  yamllint  shellcheck  shelldocs

uname
Linux 484203be8dc3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
ozone-0.4 / 7ec6a31

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-695/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-695/1/testReport/

Max. process+thread count
410 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-695/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

+1


[BUG]AttributeError: module 'deepspeed' has no attribute 'ops'

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
ds_report output
Please run ds_report to give us details about your setup.
Screenshots
If applicable, add screenshots to help explain your problem.
System info (please complete the following information):

OS: [e.g. Ubuntu 18.04]
GPU count and types [e.g. two machines with x8 A100s each]
Interconnects (if applicable) [e.g., two machines connected with 100 Gbps IB]
Python version
Any other relevant info about your setup

Launcher context
Are you launching your experiment with the deepspeed launcher, MPI, or something else?
Docker context
Are you using a specific docker image that you can share?
Additional context
Add any other context about the problem here.

Could you give more details? We cannot clearly follow the "reproduce steps"

I was able to reproduce what I think the issue is but it only seems to happen on python 3.6. It appears this regression was introduced since v0.7.5 release. I am bisecting further now and will push a fix soon.

@SiTu1O, this should be resolved now. Please re-open if you still see the issue.


pagination added in project

Fixes Issue🛠

Closes #
#1127
Description👨💻

i added pagination in home screen ,per page 10 project card display
Type of Change📄

[ ] Bug fix (non-breaking change which fixes a bug)
[x] New feature (non-breaking change which adds functionality)
[x] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)
[x] Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project
[x] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@Rakesh9100 , i solve the issue #1127 ,review it and also merged it
as well as add the level label and assigned

if you want to any changes then tell me i will do it

@Rakesh9100 ,please merged it also add the labels

@Rakesh9100 Looks issue is solved.

@Rakesh9100 ,please merged it

@Rakesh9100 ,please merged it

Why the hover effect and animations are changed, check the present website and your deploy preview and pls fix it @Varsani2520

@Rakesh9100
now you can merge this

@Rakesh9100 ,i solved the style issue
Now you ready to merged my pr

@Rakesh9100 ,please merged it

When a keyword is searched and then cleared from the search bar, all the calculators are displayed on a single page @Varsani2520


Remove old multicall

fix https://github.com/DarkFlorist/TheInterceptor/issues/891

also fixes issue that when depositing or withrawing WETH, no token balances were shown for weth in the swap
also identifies if simulation state is corrupted, and recreates it

there's a type issue here test/tests/nethermindComparison.ts


FOSSA Scan - Do Not Merge

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (2b82750) to head (3e2eb41).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop     #69   +/-   ##
=======================================
  Coverage     0.00%   0.00%
=======================================
  Files            9       9
  Lines          428     428
  Branches        67      67
=======================================
  Misses         428     428

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use dns cluster info from lib common get function

Openshift coreDNS creates the domain name using an string located in dnses.operator.openshift.io. This string can change in the future, calling lib-common/GetDNSClusterDomain the responsability of gathering this information correctly only falls under lib-common intead of all operators.
Resolves: OSPRH-3627
Depends-on: openstack-k8s-operators/lib-common#580

/retest

recheck
/lgtm

/test infra-operator-build-deploy-kuttl
kuttl jobs fixed


Array splicing

Analogously with functional struct updates, we could also allow "functional array updates", or in other words splicing of fixed-length arrays:
let a: [int, ..3] = [1, 2, 3];
let b = [..a, ..a, ..a];

Here b: [int, ..9]. Unlike FSU, there can be any number of array splices in any positions.
This has some syntactic overlap with replication:
let c = ['c', ..10];
let d = ['d', ..x];

but even the latter case can always be disambiguated based on the type of x (it's either an integer or an array; it can't be both).
(Also, we may want postfix rather than prefix .. in this case, removing the overlap completely. But we should also want that for FSU.)

Triage: @glaebhoerl any thoughts on taking this to the "next level"?

Nah I just don't have stamina/motivation for the RFC process.

Ah ok; sad to hear that particularly since you always make great contributions.


Line chart resize causing height to differ from first time load

I have 2 directives I'm using in the angular js I'm working on. The first is a d3-map directive and the second is this chart.js library with the common angular-chart.js directive.
The issue : When my page first loads and I use the map I load the chart.js directive alongside it although hidden (ng-hide) but because the chart.js is getting rendered before the map (which is in the same div) the chart.js assumes a default height of 520px~.
This is fine, however when I update data which I'm using in my d3-map directive the chart.js map then feels the need to adopt the height of the container (which on the first load wasn't there but now is 800px) and then takes a height of 800px.
I can't really set a max-height property on the chart.js canvas tag because when I do the x-axis and y-axis labels are skewed (stretched).
Is there a valid work-around for this?

I think this is the same issue as #762


Protobuf extension

I've created protobuf-extensions per #3508 and #3509.

Factored out ProtoBuf parser from processing module to extensions-contrib/protobuf-extensions
Migrated from ProtoBuf v2 to v3
Add flattenSpec support.
Support composite message types.  Original implementation had an assumption that the descriptor file contains one message type only.  See this line.  In order to specify the message type, I added a mandatory key protoMessageType.
Load the descriptor file from URL as well as classpath.  Original implementation expected the descriptor file in the classpath.   It was inconvenient when using with the Kafka indexing service that can create indexing jobs dynamically.

The com.google.protobuf package might need shading because some part of Druid is still using protobuf 2.5.0.  I will include shade plugin in pom.xml if necessary.
Here is an example JSON that works with the Kafka indexing service.
{
  "type": "kafka",
  "dataSchema": {
    "dataSource": "metrics-kafka",
    "parser": {
      "type": "protobuf",
      "descriptor": "file:///tmp/metricskafka.desc",
      "protoMessageType": "MetricsKafka",
      "parseSpec": {
        "format": "json",
        "timestampSpec": {
          "column": "timestamp",
          "format": "auto"
        },
        "dimensionsSpec": {
          "dimensions": [
             "unit",
             "http_method",
             "http_code",
             "page",
             "metricType",
             "server"
          ],
          "dimensionExclusions": [
            "timestamp",
            "value"
          ]
        }
      }
    },
    "metricsSpec": [
      {
        "name": "count",
        "type": "count"
      },
      {
        "name": "value_sum",
        "fieldName": "value",
        "type": "doubleSum"
      },
      {
        "name": "value_min",
        "fieldName": "value",
        "type": "doubleMin"
      },
      {
        "name": "value_max",
        "fieldName": "value",
        "type": "doubleMax"
      }
    ],
    "granularitySpec": {
      "type": "uniform",
      "segmentGranularity": "HOUR",
      "queryGranularity": "NONE"
    }
  },
  "tuningConfig": {
    "type": "kafka",
    "maxRowsPerSegment": 5000000
  },
  "ioConfig": {
    "topic": "metrics",
    "consumerProperties": {
      "bootstrap.servers": "localhost:9092"
    },
    "taskCount": 1,
    "replicas": 1,
    "taskDuration": "PT1H"
  }
}

@knoguchi Shading would be good, I think, since we've had problems with protobuf version conflicts in the past -- in particular with Hadoop.
Also, are you using this in production?

Took a quick look. Sames issues as what @gianm pointed out but generally this looks good to me.

👍

I don't know why Travis failed for the last commit.  I just let it re-run, and it looks ok this time.  I think I addressed all the points.   Remaining issue is the performance but that will be another PR.
There is a PR #2354 that seems to perform better.   I might reuse some code from the PR and create the JSONPath Protobuf provider.

Travis is having timeout or dead lock problem.  The test passes in my local machine.

@knoguchi can you fix up the conflicts and we'll get this merged before next release

ProtoTestEventWrapper.java is a generated class by the protobuf compiler.   It seems the file was further modified by some kind of tool (Error Prone?) in the master branch besides the license header.  IMO we shouldn't edit the generated code unless absolutely necessary.  To fix the conflict, I have to apply the same tool, but I don't know how.

@knoguchi I think it'd be fine to re-generate the file using the generator, and add exclusions for it to the errorprone config. For example see common/pom.xml where antlr-generated files are excluded from certain checks. The config looks like this:
                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-compiler-plugin</artifactId>
                        <configuration>
                            <compilerArgs>
                                <!-- Antlr-generated classes miss @Override, that is not easy to fix -->
                                <arg>-Xep:MissingOverride:WARN</arg>
                            </compilerArgs>
                        </configuration>
                    </plugin>

@knoguchi can you fix merge conflicts and I'll merge this

@fjy the conflict has been resolved.

Migrate ProtoBuf from v2 to v3

Hi @knoguchi, I wonder how the version migration is done in this patch because it looks like the dependency is actually updated in https://github.com/druid-io/druid/pull/3682. Some users want to know which druid version starts supporting protobuf v3 (https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/druid-user/DaBeEA8Ca50/PXS7l4nUBQAJ).

Looks like Apache Calcite Avatica introduced by #3682 requires Protobuf3.  I started working on this PR last year Sept or Oct before SQL module was introduced.   Either way, the Protobuf3 com.google.protobuf package is shaded in this extension because Hadoop libraries still depend on Protobuf 2.  Maybe it's no longer necessary.
Out of curiosity I grep'd protobuf-java.  hdfs-storage acually "excluded" protobuf-java.
$ git grep -A2 protobuf-java
extensions-contrib/orc-extensions/pom.xml:                    <artifactId>protobuf-java</artifactId>
extensions-contrib/orc-extensions/pom.xml-                </exclusion>
extensions-contrib/orc-extensions/pom.xml-                <exclusion>
--
extensions-core/druid-kerberos/pom.xml:          <artifactId>protobuf-java</artifactId>
extensions-core/druid-kerberos/pom.xml-        </exclusion>
extensions-core/druid-kerberos/pom.xml-        <exclusion>
--
extensions-core/hdfs-storage/pom.xml:                <artifactId>protobuf-java</artifactId>
extensions-core/hdfs-storage/pom.xml-              </exclusion>
extensions-core/hdfs-storage/pom.xml-              <exclusion>
--
extensions-core/protobuf-extensions/pom.xml:      <artifactId>protobuf-java</artifactId>
extensions-core/protobuf-extensions/pom.xml-      <version>${protobuf.version}</version>
extensions-core/protobuf-extensions/pom.xml-    </dependency>
--
extensions-core/protobuf-extensions/pom.xml:      <artifactId>protobuf-java-util</artifactId>
extensions-core/protobuf-extensions/pom.xml-      <version>${protobuf.version}</version>
extensions-core/protobuf-extensions/pom.xml-    </dependency>
--
pom.xml:                <artifactId>protobuf-java</artifactId>
pom.xml-                <version>3.1.0</version>
pom.xml-            </dependency>

Ah, maybe there was a version conflict problem before this patch. Cool. Thank you for the explanation.


[subset/CFF] fails with a hinted empty path

pyftsubset fails with --no-hinting, --no-desubroutinize (default) on the attached font (mod copy of Source Code Pro Regular) at a glyph calling out a subroutine of a hinted empty path.
SourceCodePro-mod.otf.zip
% pyftsubset SourceCodePro-mod.otf --output-file=temp.otf --unicodes=20 --no-hinting
Traceback (most recent call last):
  File "/usr/local/bin/pyftsubset", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/fontTools/misc/loggingTools.py", line 375, in wrapper
    return func(*args, **kwds)
  File "/usr/local/lib/python2.7/site-packages/fontTools/subset/__init__.py", line 3320, in main
    save_font(font, outfile, options)
  File "/usr/local/lib/python2.7/site-packages/fontTools/misc/loggingTools.py", line 375, in wrapper
    return func(*args, **kwds)
  File "/usr/local/lib/python2.7/site-packages/fontTools/subset/__init__.py", line 3171, in save_font
    font.save(outfile, reorderTables=options.canonical_order)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/ttFont.py", line 173, in save
    writer_reordersTables = self._save(tmp)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/ttFont.py", line 212, in _save
    self._writeTable(tag, writer, done, tableCache)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/ttFont.py", line 629, in _writeTable
    self._writeTable(masterTable, writer, done, tableCache)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/ttFont.py", line 633, in _writeTable
    tabledata = self.getTableData(tag)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/ttFont.py", line 651, in getTableData
    return self.tables[tag].compile(self)
  File "/usr/local/lib/python2.7/site-packages/fontTools/ttLib/tables/C_F_F_.py", line 20, in compile
    self.cff.compile(f, otFont, isCFF2=False)
  File "/usr/local/lib/python2.7/site-packages/fontTools/cffLib/__init__.py", line 141, in compile
    children = topCompiler.getChildren(strings)
  File "/usr/local/lib/python2.7/site-packages/fontTools/cffLib/__init__.py", line 453, in getChildren
    children.extend(topDict.getChildren(strings))
  File "/usr/local/lib/python2.7/site-packages/fontTools/cffLib/__init__.py", line 2144, in getChildren
    items, strings, self, isCFF2=isCFF2)
  File "/usr/local/lib/python2.7/site-packages/fontTools/cffLib/__init__.py", line 370, in __init__
    self.items = self.getItems(items, strings)
  File "/usr/local/lib/python2.7/site-packages/fontTools/cffLib/__init__.py", line 537, in getItems
    cs.compile(self.isCFF2)
  File "/usr/local/lib/python2.7/site-packages/fontTools/misc/psCharStrings.py", line 1004, in compile
    self.check_program(program, isCFF2=isCFF2)
  File "/usr/local/lib/python2.7/site-packages/fontTools/misc/psCharStrings.py", line 997, in check_program
    assert self.program[-1] in ("endchar", "return", "callsubr", "callgsubr", "seac"), "illegal CharString"
AssertionError: illegal CharString

The offending CharString reads (as ttx output):
        <CharString name="space">
          -107 callgsubr
        </CharString>

    <GlobalSubrs>
      <!-- The 'index' attribute is only for humans; it is ignored when parsed. -->
      <CharString index="0">
        1000 10 20 hstem
        endchar
      </CharString>
    </GlobalSubrs>

Do you have a full font I can test?

I don't have a license to post the original font with which I found the bug, sorry. Attached is my result of attempt to repro the bug by modifying an open source font.

Ah sorry didn't see the attachment. Was on mobile.

Fixed.  Thanks.

Good to add a test some time.


make get-system-memory.sh support macOS, for debugging purposes

Confirmed working on macOS and Ubuntu 18.04.


Update ReadME / avoid chances for same attribute names in hijack / add h*w assertion

The cursed nature of hijack contains chances to make duplicate attribute names, especially ControlNet.
Some code snippets are changed for future references.

Note : Consider the following case.
8740 = 76 * 115
Whilas the aspect ratio is 1.5, the values are:
(8740*1.5)**0.5 =114.49890829173874
Thus the rounded value is 114.
This will fail the h*w = hw assertion.


Chats can't be started using images

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #support.

This seems to be a duplicate of issue #668

This seems to be a duplicate of issue #668

@CSab6482 any idea if this is still an issue?

Yes and I think it's one that can only be solved with private API usage as @sgtaziz has previously told me that it is a limitation from Apple's part. I'll test this today in BB as well as in the other apps.

I was unable to create a new chat with an image in BlueBubbles, below is a screenshot of how it looked on my phone as well as in the Terminal on my Mac.

In both WebMessage and SMServer, my first attempt at creating a new chat with an image failed, but my second attempt succeeded. I filmed both attempts for SMServer, and I filmed only the second attempt for WebMessage.
https://user-images.githubusercontent.com/53708281/122308975-70c43a80-cedb-11eb-8da1-3db73fae5b68.mp4
https://user-images.githubusercontent.com/53708281/122308987-76218500-cedb-11eb-8595-75abf733ee51.mp4
I was unable to test this in MyMessage as the create new chat button does not currently work.
https://user-images.githubusercontent.com/53708281/122309019-82a5dd80-cedb-11eb-8059-2f457aa1a6ef.mp4
Any thoughts for why it doesn't work in BlueBubbles, and why it takes two tries in WebMessage and SMServer? @iandwelker @sgtaziz.

It doesn't work on SMServer simply cause I haven't yet added support for creating a conversation and then immediately sending an attachment to it (which, in hindsight, is kind of stupid since I could easily add support for it, I just never did), so it creates the conversation but then doesn't send a message to it.
Since the conversation already exists when you send the second message, it allows you to send an image to it.

@CSab6482 when the message timeout happens in the logs, is the image still being sent in iMessage? Because I was dumb and set the image send timeout to 1 minute, when it should be much longer

@CSab6482 when the message timeout happens in the logs, is the image still being sent in iMessage? Because I was dumb and set the image send timeout to 1 minute, when it should be much longer

No, it never goes through, but maybe that 1 minute timeout is what causes this bug? I will test this with AirMessage and post my results.

i think the timeout is the issue cuz im pretty sure that after a certain amount of time the attachment gets deleted too

We are going to leave this as a limitation that isnt possible until private api chat creation


Should all server capabilities allow the corresponding dynamic registration options?

Some, but not all, of the server capability fields in the initialize response allow providing the corresponding registration options. It's helpful to be able to do so, since the registration options type usually includes additional fields, such as the documentSelector.
Examples:

completionProvider has type CompletionOptions and doesn't allow CompletionRegistrationOptions
typeDefinitionProvider has type TypeDefinitionOptions | TypeDefinitionRegistrationOptions

Is this just for backwards compatibility? Is there a way we could migrate the protocol to be more consistent here? It would make things simpler. For example, if you want to make use of the documentSelector capability, you can have many cases:

Client supports dynamic registration: dynamically register
Client does not support dynamic registration:

Options field supports dynamic registration options: statically register
Options field does not support dynamic registration options: give up

It's quite fiddly.

Is this just for backwards compatibility?

Yes, it is only for backwards compatibility. There could be old clients which don't support options. I tired to be consistent for all new requests I introduce.
The only solution that came to my mind when doing this was adding a client capability to inform the server. But it felt a little bit like overhead. If someone has an idea I am happy to look into this again.

Yes, I agree that you would probably need a capability (dynamicRegistrationDuringInitialize?). You can't just say the client can ignore the excess fields, since the server might prefer to dynamically register in order to make the settings have effect.
I agree it's some overhead, but it might be worth it. In particular, I don't know whether you have any plan to eventually mark some capability settings as deprecated, so as to push implementors towards the "recommended" way of doing things? If there's a path towards one day making the more sensible behaviour the default then it seems worth taking a step down that path.


[bug] score-compose init --provisioners flag doesn't document local file option and doesn't support stdin

the docs currently show
      --provisioners stringArray   Provisioner files to install. May be specified multiple times. Supports:
                                   - HTTP        : http://host/file
                                   - HTTPS       : https://host/file
                                   - Git (SSH<EMAIL_ADDRESS>                                   - Git (HTTPS) : git-https://host/repo.git/file
                                   - OCI         : oci://[registry/][namespace/]repository[:tag|@digest][#file]

But it also supports local file paths as well!
Also it would be very conventient to also support - as stdin so that we can run:
score-compose init --provisioners=- <<EOF
- uri: template://custom-env
  type: environment
  outputs:
    FIZZ: buzz
EOF

Hi @astromechza Can i contribute to this issue ? This will be a good learning opportunity for me : )

Sure thing, @rabelmervin, please go ahead, thanks!

Hi @mathieu-benoit I have made a pr. Could you please review my changes ?


settings: Replace the Theme select dropdown with the Theme switcher.

This PR includes the following changes:

The theme select dropdown in the Preferences section of the Personal settings is replaced with the theme switcher, similar to the one in the personal menu popover.
The theme select dropdown in the Default User Settings section of the Organization settings also follows the same set of changes.

Fixes: #32111.
CZO Thread

Screenshots and screen captures:

Interaction of Theme switcher in Personal Settings - Preferences

Interaction of Theme switcher in Organization Settings - Default user settings

Reverting back to the previous theme in Personal Settings - Preferences (when an error occurs).

Reverting back to the previous theme in Organization Settings - Default user settings (when changes are discarded).

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@sayamsamal can you review this one? I expect expertise with the theme switcher is more relevant than experience with settings.

@saubhagya-patel Sorry for the delay in review, I was busy with some design work. I have left you some comments regarding the code structure. Except that, everything else LGTM. LMK once you addressed the feedback so that I forward this PR for integration review.

I have updated this PR following the review received. The following changes are made:

Created a new event handler in the settings_preferences.ts file to handle the changes in user theme following this comment.
There are no visual changes.

As mentioned in this comment, the review delay is perfectly fine. I completely understand and respect your valuable feedback.
That being said, @sayamsamal, I have made the required changes. Please let me know if any further adjustments are needed.
Thank you.


The component prop is not allowed on a styled() MUI component

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/strange-hofstadter-6668qh?file=/src/App.tsx
Observe the Typescript error.
Current behavior 😯
The typings cause an error, saying component doesn't exist on the styled() MUI component, but it does exist on the same MUI component directly. Somehow the typings for that one prop is not transferred over properly to the typings of the output of the styled() function.
It does work, though with that typescript error.
Expected behavior 🤔
No error. I don't see why this prop wouldn't be allowed, especially given that it works perfectly fine at runtime.
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 114.0.5735.110
    Edge: Spartan (44.19041.1266.0), Chromium (114.0.1823.41)
  npmPackages:
    @emotion/react:  11.10.6
    @emotion/styled:  11.10.6
    @mui/base:  5.0.0-beta.4
    @mui/core-downloads-tracker:  5.13.4
    @mui/material:  5.13.4
    @mui/private-theming:  5.13.1
    @mui/styled-engine:  5.13.2
    @mui/styles:  5.13.2
    @mui/system:  5.13.2
    @mui/types:  7.2.4
    @mui/utils:  5.13.1
    @types/react:  18.2.0
    react:  18.2.0
    react-dom:  18.2.0
    typescript:  4.9.5

I'm on Firefox 114. Not that it matters.

There is a silly workaround:
- const StyledTypography = styled(Typography)({ ... });
+ const StyledTypography = styled(Typography)<{ component: string }>({ ... });

So basically forcing the component prop to exist again. The string type is obviously not correct, but it works in my scenario.

I need to dig deeper into it to have more context around the component prop, but if you want to pass a custom component/tag, you could use the as prop instead of component and it has a higher precedence than component as well.
cc: @siriwatknp You might have more details.

If I pass as="h2" then all MUI-related classnames are no longer applied. I think because the as prop is picked up by emotion, so the MUI component never comes into play.

This issue is not just limited to component prop, but any props that are inherited from some base props. For example,
import { Link as RouterLink } from "react-router-dom";

const StyledListItemButton = styled(ListItemButton)<ListItemButtonProps>(({ theme }) => ({
}));

<StyledListItemButton
   component={RouterLink}
   to={"/"}
/>

Both component and to will not be recognized.

I'll check and revert.

FWIW, I think this seems to work for styled:
export const CustomButton = styled(MuiButton)(({ theme }) => ({
  backgroundColor: theme.palette.success.dark,
})) as typeof MuiButton

also, seems to be ok for this as well:
export const Button3 = React.forwardRef((props, ref) => (
  <MuiButton {...props} ref={ref} />
)) as typeof MuiButton

a few storybook stories to prove it out a bit:
export const Ref: Story = {
  render: (args) => {
    const storyRef = useRef(null)
    return (
      <Button
        {...args}
        ref={storyRef}
        onClick={() => buttonAction(storyRef.current)}
      />
    )
  },
  args: {
    variant: "contained",
    color: "primary",
    children: "Click me",
  },
}

export const AsComponent: Story = {
  render: (args: any) => {
    return <Button {...args} component="a" href="/stuff" />
  },
  args: {
    variant: "contained",
    color: "primary",
    children: "Contained button",
  },
}

not great IMO, I really with the composition docs had a code example to do both ref forwarding and accept generics. The same behavior is desired with styled.

Duplicate of https://github.com/mui/material-ui/issues/29875


Fix search now that version numbers are returned by search

mas now returns version numbers with search result. For example:
➜  mac-app-store-chef git:(search-fix) mas search Xcode
   497799835  Xcode                                                                (10.1)
<PHONE_NUMBER>  Swiftify for Xcode                                                   (4.6.1)
<PHONE_NUMBER>  App School for Xcode and  iOS 10 Development Free                    (1.0)
<PHONE_NUMBER>  Code School for Xcode Free -Learn How to Make Apps                   (1.1.3)
<PHONE_NUMBER>  Course for Xcode 7 Lite                                              (1.0)
  ...

This change fixes the mac_app_store_app resource. I wasn't able to get the tests to run due to lots of gem version conflicts, so I haven't updated them yet. Happy to do so later, but it's going to require some rework of said tests.

Thanks! Trying to get this cookbook working again after a long period of neglect. Gonna merge all the pending PRs and proceed from there 🤞


add Makefile

Bringing over some of the useful tasks from our work on the automation
broker.

make help

$ make help
Usage: make <OPTIONS> ... <TARGETS>

Available targets are:

fmtcheck             Check go formatting
vet                  Run go vet
test                 Run unit tests
check                Pre-flight checks before creating PR
lint                 Run golint
help                 Show this help screen

LGTM, can you add theae ch3cks to travis next?


[stm32] PM restore console after sleep mode

With this change, the clock configuration is restored when leaving the low power mode.
Then the console of the nucleo_wb55 can operate after sleeping.
Remaining work:

adapt for the nucleo l476rg board
adjust the value for the residency for stop 0, 1, 2

Fix #31284
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

*** Booting Zephyr OS build v2.5.0-rc1-116-g9d9c34e27c13  ***
Running test suite power_management_test
START - test_power_idle
give way to idle thread
PASS - test_power_idle
START - test_power_state_trans
PASS - test_power_state_trans
START - test_power_state_notification
PASS - test_power_state_notification
Test suite power_management_test succeeded
PROJECT EXECUTION SUCCESSFUL

Remove the commit  to soc: arm: stm32wb low power mode for CPU2 too . The CPU2 lowpower mode is not set here (LL_C2_PWR_SetPowerMode(LL_PWR_MODE_STOPx);
and changes after review

Thank you for this PR @FRASTM ! It would help me a lot if it was merged since it's required for STM32L1x power management too (when using the stop mode).

Thank you for this PR @FRASTM ! It would help me a lot if this was merged since it's required for STM32L1x power management too (when using the stop mode).

@abel-NoelleC The best way to help in this direction is review, and approve when you're satisfied (in the scope on the proposal)

adding a commit to include nucleo_wb55rg and nucleo_l476rg boards for the tests/subsys/power/power_mgmt_soc

Add more target for the tests/subsys/power/power_mgmt
Fix compilation build error with tests/kernel/profiling/profiling_api by adding a weak pm_policy_low_power_devices, for each stm32 soc (in soc/power.c) in case the policy is not available.

adding the `include <stm32wbxx_ll_utils.h> for power.c of the stm32l4 and stm32wb, in case the PLL is enable here.

rebase

rebase

@dcpleung can you have a new look ?