Folder navigation UI

I've only implemented this for the Media library so far and there's a few areas where the UI could be polished - but I think it's good enough to ship.

Quest issues in build. Switching this to draft.

Works, but I feel like the font (for the directory name) is a bit too small, at least on my Q2. What do you think?

Yeah. I was slightly concerned about that as well as the overly thin lines around the button for each entry. I suggest we get this into the beta and gather feedback for a later PR that adds a bit more finesse to the UI. There's probably a few areas to polish up.


Add IncrementalParseResult

Motivation

https://github.com/apple/swift-syntax/issues/2267

Changes

Added

IncrementalParseResult  type
parseIncrementally with IncrementalParseResult  return type
IncrementalParseTransition init with IncrementalParseResult  type

Changed

parseIncrementally with tuple return type is deprecated
IncrementalParseTransition init with previousTree and lookaheadRanges is deprecated

@ahoppen
Hi! In the integration tests, there is an issue that you mentioned earlier. Can you advise on the next steps to fix this, please?
/Users/ec2-user/jenkins/workspace/swift-syntax-PR-macOS/branch-main/sourcekit-lsp/Sources/SourceKitLSP/Swift/SyntaxTreeManager.swift:110:64: error: cannot convert value of type 'Task<IncrementalParseResult, Never>' to expected argument type 'SyntaxTreeManager.SyntaxTreeComputation' (aka 'Task<(tree: SourceFileSyntax, lookaheadRanges: LookaheadRanges), Never>')
    self.setComputation(for: postEditSnapshot.id, computation: incrementalParseComputation

Could you clone https://github.com/apple/sourcekit-lsp and open a PR to it that makes it build with the changes you are making in this PR? I would expect it to be a fairly simple one or two-line change.

Could you clone https://github.com/apple/sourcekit-lsp and open a PR to it that makes it build with the changes you are making in this PR? I would expect it to be a fairly simple one or two-line change.

Thanks for your help!
https://github.com/apple/sourcekit-lsp/pull/895

@ahoppen @bnbarham Hi! I fixed the conflicts, could you please run CI again and merge MR?

https://github.com/apple/sourcekit-lsp/pull/895
@swift-ci please test

@ahoppen Both MRs passed all tests, could you merge this MR please? 🙃

Thanks for your contribution @divalue!


Multiple stamps per region

In README here: https://github.com/Azure/Mission-Critical-Connected/blob/main/src/infra/README.md is stated:
Stamp resources
A stamp is a regional deployment and can also be considered as a scale-unit. For now we only always deploy one stamp in an Azure Region but this can be extended to allow multiple stamps per region if required.
I am very new to terraform how can this be achieved? So basically deploy for example two stamps per region each stamp in different availability zone, having a total of four stamps: 2 per region and in each region 1 stamp in one AZ and 1 stamp in other AZ.

Duplicate of https://github.com/Azure/Mission-Critical-Online/issues/958


CSIPSTR3: Should we be more prescriptive about which compression algorithms shall be supported

This could be a MAJOR interoperability issue. If I deliver packages to an archive in ARJ format (a popular compression format in the 90s), how many will be able to process this?
SIARD 2 spec is also very prescriptive about the compression algorithms to use. We should be as well.

Lets see what comes from the review.

We may want to clarify use of archive/compressed formats and perhaps make recommendations based on these thoughts.


viz for leaf samples distribution

I would like to propose a new vizualisation type for leaf samples : by histrogram.
It is useful when you want to easily see the general distribution of leaf samples, instead of individual leaf samples.
More useful when there is a big tree with a lot of leaves and the bar plot vizualisation is hard to interpret.
For implementation, this will add another value ('hist') for display_type parameter from viz_leaf_samples function.
The new vizualisation will look like this :

when we want to include a subset of leaf samples (when we want to exclude the outlier leaves, like that leaf with ±350 samples from above viz)

@parrt what do you think about it ?

Heh, looks pretty cool!  I think it is useful. Let's add


A few improvements

A couple random things I had laying around:

most substantive change: allow a minPartitions parameter to the various interval-file-loading functions, which wrap sc.textFile.

I am having issues where 20MM-line bed files get loaded with maximum 2 partitions due to this (imho inadvisable) math.min in Spark, resulting in executor OOMs.

Thread a record-group parameter through some places that it was missing.
Style nits.

Fixes #969 #968

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1104/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1105/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1106/
Test PASSed.

LGTM, thanks
If you wouldn't mind, how about three issues (min partitions, record groups, style fixes)?

thx @heuermh I updated with two issues, I left off the style nits bc it seems ok for those to piggyback on the others but lmk if you want a 3rd one

bump

@fnothaft volunteered to merge this, grouping the commits by issue

cool, sorry for the trouble, lmk if you want me to break them out some
other way myself!
On Thu, Mar 24, 2016 at 1:37 PM Michael L Heuer<EMAIL_ADDRESS>wrote:

@fnothaft https://github.com/fnothaft volunteered to merge this,
grouping the commits by issue
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/bigdatagenomics/adam/pull/966#issuecomment-200942579

Just pinged you on gitter @ryan-williams but if you can rebase I will merge. I was going to yesterday but got distracted.

rebased; picked up two tiny style nits that weren't there before also jfyi https://github.com/bigdatagenomics/adam/pull/966/commits/d60b7fc8a8b921c1437bc467ca5511dba1413511

Thanks for the heads up! Will let the tests run and review.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1115/
Test PASSed.

Thanks @ryan-williams! I squashed down to https://github.com/bigdatagenomics/adam/commit/0d1bfd2dd27ad6726d19f08498a35408ce9c23d8, https://github.com/bigdatagenomics/adam/commit/af5f733dbfada0069f7bf0dc6a8b89125f60cef9, and https://github.com/bigdatagenomics/adam/commit/13e734605c27ef05eec43118a1ddd7bff15abaac and merged.


Module change callback being called twice

I just noticed that when I edit-config, my call-back is getting called twice. I can't recall if this always happened, or just started doing it. I'm getting the same result with the example application (application_asyncio.py)...
========================
Module changed event: change (request ID 5)
----- changes -----
ChangeModified(/sysrepo-example:conf/network/interface[name='ifC']/address: '<IP_ADDRESS>' -> '<IP_ADDRESS>')
----- end of changes -----

========================
Module changed event: done (request ID 5)
----- changes -----
ChangeModified(/sysrepo-example:conf/network/interface[name='ifC']/address: '<IP_ADDRESS>' -> '<IP_ADDRESS>')
----- end of changes -----

What's the reason for the double-tap? Is this correct, or do I have something wrong in the sysrepo configuration, or something?

Sorry, I realize now that the 1st is the "change", and the 2nd is the "done". Issue closed.


add Serbian Cyrillic language and dictionary

I also added Cyrillic symbols from other Slavic languages (including even Old Church Slavonic), so the layout can be used for any of them without switching, just like I type any Slavic Cyrillic symbols on Ukrainian layout on GNU/Linux. I suspect that making the digits less accessible this way is non-crucial as they can usually be got by holding a key anyway, and some layouts like Vietnamese have lots of symbols on one key anyway.
The dictionary might be a bit inaccurate as the autoreplacement borks some nuances like if dj should be converted to ђ or дј (on compound word boundaries).
It turns out that barely any keypad phones if any supported Serbian Cyrillic, as vendors just systematically ignored it, so I had to come up with the layout myself. I attempted to make it balanced by the letter frequency without compromising the alphabetic order too much; it rather resembles the Latin layout than the usual Russian Cyrillic and its derivatives which complicates the learning curve. I'd like to see a reference layout if anyone has encountered it in the wild.

Thanks for your contribution. This PR has some deficiencies that need to be addressed before merging.
First, it's the dictionary. Releasing a dictionary with misspelled words is against my philosophy of providing the highest typing experience possible. Sure, all dictionaries probably contains mistakes because it is not possible to verify millions of words one-by-one, but I never languages or code with problems knowingly.
And from user perspective, it will be very frustrating when trying to type a word correctly, but there is no corresponding suggestion.
A quick google search for an alternative led me to this word list which looks quite good. 2.8 million words is a bit more than what TT9 can handle, but probably using some frequency list either from Android Open Source Project or from Uni Leipzig, to reduce the words to about 1 million, will do the trick.
Unfortunately, I can not help with this right now, because I am focused on adding East Asian language support, but I do intend to go back to Serbian later.
Second, it's the alphabet definition. I am strictly against adding letters from other languages. They are going to be useless, if the dictionary contains no foreign words anyway. If you want to type in some language, then switch to that language.
Also, ask yourself, do you really need Old Church Slavonic? Will any user actually need it? I don't mind adding it for fun, but as a dead language, I'll treat it with lowest priority. I value my time.
As for the layout itself, as a person who uses a Cyrillic layout everyday, I find your suggestion confusing. If am a new user, but I am used to some old Nokia phone, I would be very surprised to see "Я" on the 1-key, as well as "Ю" on 8, "Ц", "Ч" on 9 and so on.
I would say the only "Russian" thing is putting "ъ" and "ь" on 9- instead of 8-key, but this is irrelevant to Serbian. Check out the other YML files here, in the repo, if you are curious about other languages. I have used my old Nokia 3310 for reference, as well as hints by native language speakers.
I believe a more logical Serbian layout is:
# ... previous definitions
  - [а, б, в, г] # 2
  - [д, ђ, е, ж, з] # 3
  - [и, ј, к, л, љ] # 4
  - [м, н, њ, о, п] # 5
  - [р, с, т, ћ, у] # 6
  - [ф, х, ц, ч, џ] # 7
  - [ш] # 8
  - [] # 9 remains empty because you don't use Ю, Я, Ъ, ...

Now, having said the above, I am not sure about "џ", because on my Nokia 3310, in Macedonian (I don't have Serbian, sadly), it is on the 8-key, but I think it makes more sense to be on the 7-key being a voiced counterpart of "ч", and not having anything in common with "ш". Also, since "ћ" is closely related to "ч" too, it may also be on the 7-key. I am open to suggestions about these two letters.


[BUG] triggering github's abuse systems

helix-editor version
24.3
helix-gpt version
0.31
Describe the bug
turns out github just emailed me!

Hello @lun-4,

On behalf of the GitHub Security team, I want to first extend our gratitude for your continued use of GitHub and for being a valued member of the GitHub community.

Recent activity on your account caught the attention of our abuse-detection systems. This activity included use of Copilot that was indicative of scripted interactions or of an otherwise deliberately unusual or strenuous nature. While we have not yet restricted Copilot access for your account, further anomalous activity could result in a temporary suspension of your Copilot access.

While I’m unable to share specifics on rate limits, we prohibit all use of our servers for any form of excessive automated bulk activity, as well as any activity that places undue burden on our servers through automated means. Please refer to our Acceptable Use Policies on this topic: https://docs.github.com/site-policy/acceptable-use-policies/github-acceptable-use-policies#4-spam-and-inauthentic-activity-on-github.

Please also refer to our Terms for Additional Products and Features for GitHub Copilot for specific terms: https://docs.github.com/site-policy/github-terms/github-terms-for-additional-products-and-features#github-copilot.

Sincerely,
GitHub Security

I do not use other editors than helix, in turn, there is no extension other than helix-gpt that could be triggering github's abuse systems for copilot. I am not automating helix in any way, but it's possible they ran some detection on the headers that helix-gpt uses to look like vscode. it doesn't look like the copilot vscode extension is under any kind of permissive license that would allow for reverse engineering, so I don't think an official GH ticket would give any results (it might even backfire and take the repo down, but that's the worst case), I am open to ideas though.
my current opinion is if GH is going to play cat-and-mouse, then we should act accordingly as the mouse. we should move towards continuously updating fingerprints such that we look more and more like vscode, that is a major maintenance request that I do not think I would be able to take on, myself. but it is a way. (of course, not even talking about possibly having to move the repo somewhere else, killing the social factor of having this plugin known, entirely. maybe a migration to codeberg could work, which is another major maintenance request, and is one I would put a lot of thought before actually going on with a random's requests).

I received a similar message. They actually suspended my Copilot access because of it. I also only used Copilot with this helix-gpt. I ended up just canceling my Copilot subscription as the GitHub support was threatening the termination of my GitHub account if the "abuse" continued.

I've been receiving the same, and tried to reply but never got a response. @oschwald did you try reaching out to support?

Yes, I reached out to support, but it was not very enlightening. They refused to provide any more details about the "abuse" (or even confirm if it was coming from my IP). They just kept repeating that if it continues they will terminate my Copilot access and my GitHub account.

Yes, I reached out to support, but it was not very enlightening. They refused to provide any more details about the "abuse" (or even confirm if it was coming from my IP). They just kept repeating that if it continues they will terminate my Copilot access and my GitHub account.

I've just merged a PR from someone that only allows one active request. Maybe this will help.

we should probably verify the headers sent in https://github.com/leona/helix-gpt/blob/2aba4d5809089ca68692f353affc37542110b351/src/providers/github.ts#L124 to update the vscode version, and get a way to store machine id and session id to be reused, so microsoft's internal systems don't think we have thousands of computers

The other OSS editors (like XCode/Sublime Text/etc) handled this by making sure to send their actual name in the headers instead of sending
https://github.com/leona/helix-gpt/blob/2aba4d5809089ca68692f353affc37542110b351/src/providers/github.ts#L126-L129

I also got an email from copilot yesterday. I hope this issue will be resolved. I like helix and being able to use copilot with it is great.


remove apiVersion param where it is not needed

Fixes https://github.com/openreview/openreview-py/issues/1941

This can be merged now.


Feature/react cli templates

Fixes PXBLUE-1443

Changes proposed in this Pull Request:

Add a bare, barebone for a static page component <Dashboard />
Test by using the following commands:

ts: pxb new react --name cli-template-test --lint --prettier --language ts, then choose "Dashboard" (other options are not working yet)
js: pxb new react --name cli-template-test --lint --prettier --language js, then choose "Dashboard"

Templates are not part of the cli flags. (So you cannot do pxb new react --template auth-workflow dashboard ... yet)

Notes on CRA templates
CRA requires your templates published to npm first. I think our current way is a little easier to maintain. Also, our current implementation is modifying, instead of replacing, the existing default cra templates, making it less troublesome (I think).

Screenshots
The CLI will give you this if you generate a ts & lint react project and select the "dashboard" option:

Just checked the default template thing in CRA.
CRA allows us to pass in a fixed set of template files and replace the existing ones but does not allow you to do crazy .ejs tricks. So CRA's templates are closer to that radio button thing you were suggesting, where you either go with a fixed set of files.

This looks good. For the sake of the POC, I would say it's good to go. I don't want to merge this PR in though, just because I don't think this is one of the templates we will officially have, but we should keep the branch around for reference when we implement the others.

Closing this but leaving the branch open for future reference


Crash when using Item Browser

Traceback (most recent call last):
  File "build\gui\itembrowser.py", line 159, in update_item_view
  File "build\assets\items.py", line 141, in get_item_icon
AttributeError: 'list' object has no attribute 'split'

Traceback (most recent call last):
  File "build\gui\itembrowser.py", line 159, in update_item_view
  File "build\assets\items.py", line 137, in get_item_icon
TypeError: argument of type 'NoneType' is not iterable

It seems to happen when selecting the 12th item in the dropdown

Fixed by a1b048de21496aba0b99d5f3e74bc67e3b766f8f


Fix accidental erasure of finishing request

Fix #138

Tested it and both robots manage to run the finishing task as intended. While viewing the tasks on the panel, the park task is shown as canceled because the dispatcher is also keeping track of the task. Similar logic/or filter should also be implemented on the dispatcher node. But for now, I think this can be neglected since we are revamping the entire task system on redesign_v2?
One side observation that I noticed, when the robot is executing a cleaning task (aka docking), it seems interruptable, which shouldn't be the case?

On certain occasions, while running some scenarios in the hotel world, "near miss" situation of 2 robots will interrupt the cleaning robot while it is still moving along the cleaning path. This will end the "dock" process, subsequently show a 'fleetadaptererror' log because of the diverged path that it follows.
 [cleanerBotA_fleet_adapter]: Fleet driver [cleanerBotA] reported interruption for [cleanerBotA_2]
[full_control-13] [ERROR] [1641781347.416469257] [cleanerBotA_fleet_adapter]: [RobotUpdateHandle::update_position] The robot [cleanerBotA/cleanerBotA_2] has diverged from its navigation graph

I guess the above mentioned interruption issue should be a different problem.

Thanks for the quick review @youliangtan

While viewing the tasks on the panel, the park task is shown as canceled because the dispatcher is also keeping track of the task.

Yeah with the legacy system, there seems to be two sources of "what are the tasks being performed", one by the dispatcher and the other by the fleet adapter (internal). With the redesign_v2 implementation, we hope to introduce a single source of this information.
Having said that, I think in your testing, you should have observed that despite the park task being "cancelled" after reassingment, when the robot does correctly begin the task, the task will appear as "Active".

On certain occasions, while running some scenarios in the hotel world, "near miss" situation of 2 robots will interrupt the cleaning robot while it is still moving along the cleaning path. This will end the "dock" process, subsequently show a 'fleetadaptererror' log because of the diverged path that it follows.

This problem should be solved with the new fleet adapter implementations https://github.com/open-rmf/rmf_demos/pull/109. If you still encounter the problem, let's open a separate ticket for that.


Support place2dTexture nodes

This might be difficult since glTF doesn't have a notion of this, meaning we should bake the UV transformations in the UV coordinates...

There does seem to be an extension to support transforming textures: https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_texture_transform
Please also note that there's been some discussion on the rotations it applies and whether it's inverted or not. So if you get wrong results it might be related: https://github.com/KhronosGroup/glTF/issues/1563


Upload causes download of xhr response on IE9

When uploading a file in IE9 the browser shows an download dialog. The download contains the content of the xhr response of the previous startet upload. This only happens when the upload backends response content type is application/json (what in my opinion should be the case).
Debugging brings up that it works fine with text/html content type (in IE9 too). As the response is json I consider this as bug that should be fixed.

Can you share me sample code ?
On Tuesday, June 14, 2016, Robert<EMAIL_ADDRESS>wrote:

When uploading a file in IE9 the browser shows an download dialog. The
download contains the content of the xhr response of the previous startet
upload. This only happens when the upload backends response content type is
application/json (what in my opinion should be the case).
Debugging brings up that it works fine with text/html content type (in IE9
too). As the response is json I consider this as bug that should be fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hayageek/jquery-upload-file/issues/108, or mute the
thread
https://github.com/notifications/unsubscribe/AChS7tVUSfCJW0u1z4DXbW-G31MAjGmBks5qLZLPgaJpZM4I0jd7
.

I have the same problem here.
Using this example:
Index.zip

select a file to upload.
press the green Start upload button.
after upload, the download message appears:

The content of the downloaded file:
{"msg":"File Uploaded","filename":"C:\\Users\\Kirill\\Desktop\\1502015062116768649.jpg","url":"c:\\users\\kirill\\documents\\visual studio 2017\\Projects\\WebApplication3\\WebApplication3\\App_Data\\uploads\\1502015062116768649.jpg"}


Ben/viewshed sample

Sample
Add preliminary Viewshed sample (working in URP only)

Latest batch of changes addresses most points in the review.  The Viewshed scene currently doesn't render the map correctly since downgrading to Unity 2021.3.2f1, but I'm looking into it.

Pressed the wrong button...didn't mean to convert this to a normal PR

Before going further into the implementation details, I'd like to discuss the approach:

Why did you decide to go with this approach instead of a post-processing effect or other options?

I did initially try to get it working as a custom post-processing effect, but ran into issues of passing the cameras' depth buffers as they would just be all 0's or uninitialized/cleared. The other approach I tried was a scriptable render pass, which can probably work but requires modifying the render pipeline asset used by other samples.
I was also not able to get the depth buffers correctly passed into a shadergraph, otherwise I would have used that. Hand-written shaders are not ideal.

I suppose changing my approach to dynamically create the effect planes in code might be a better solution.  I manually placed the planes in the scene thinking that might make the methodology easier to see/understand from a user perspective.

IMO the best approach is to use a custom material on the rendered objects and change color whether they are visible or not. This a bit difficult right now because there's no easy way to set a custom material on tile layers, but you could discuss adding it to the plugin with the team.
In the meantime, you can move your approach to a post-processing effect. I can help getting it to work once you have a first draft.

Also confirmed that the Full Screen Pass Render Feature isn't supported until URP 14 either. It is required to do custom post-processing effects correctly<EMAIL_ADDRESS>

at least according to Unity documentation

Can  you point me to the doc link where it says that? It seems it is supported in URP 12.1<EMAIL_ADDRESS>
Also confirmed that the Full Screen Pass Render Feature isn't supported until URP 14 either.

so how Tonemapping is implemented in 12.1<EMAIL_ADDRESS>

Post processing via volumes is available in 12.1, but not the ability to create custom post processing effects from what I can tell.  It just supports a pre-defined list of effects<EMAIL_ADDRESS>Behind the scenes, I'm sure Unity probably has a full screen/blit-based pass to create the pre-defined effects, but the API is not exposed to the user to define custom ones. For example, to create these effects in shadergraph you need to use a "URP Sample Buffer" node which doesn't exist in 12.1

Also, this page specifies that full screen pass and custom post-processing are officially supported starting with URP 14<EMAIL_ADDRESS>

Post processing via volumes is available in 12.1,

What do  you need volumes for?

but not the ability to create custom post processing effects from what I can tell. It just supports a pre-defined list of effects

<EMAIL_ADDRESS>?

Yes, like I said previously a custom render feature should be able to handle it but it requires modifying the URP asset shared by other samples.  Post processing is different than scriptable renderer features.

Closing this PR. will post a new one with rework branch


Syncing between two StorageEngines

Are there any examples patterns for building an app that actually does sync data remotely when online? IE store data in a local sqlite storage engine that is also automatically synced remotely?  Is it two separate StorageEngines? How do they interact together?

Hey @pnewell, thanks for the good question. If you don't mind I'm going to answer #46 and #47 together here since they're actually similar and related questions.
The short answer is that I don't have a great answer for this. In my app Plinky I have two targets, the main app and a share extension. A user can save a link from the share extension, and naturally they expect to see that link appear in the app.
To accommodate this I have this function run, listening to the app's foreground notification to know to fire.
func synchronizeExternallySavedLinks() async {
    do {
        // We create a temporary ObjectStorage to retrieve any links that were saved using the share extension.
        // Since the app's $links memory store does not get updated directly, when the app is launched post-save
        // it will not display the link that was saved in another target.
        //
        // To work around this we create an ObjectStorage based on the same database, pull the links out of there
        // and then re-save them. This is a somewhat clever shortcut to synchronizing the in-memory store since
        // the data is already saved on disk.
        //
        // Many approaches using multiple stores were tried, but left us with states that were highly unsynchronized.
        // I tried to manually synchronize them, but would run into conflicts when going between the main app
        // and another target (such as having saved a link in Safari).
        let objectStorage = ObjectStorage<RichLink>(storage: SQLiteStorageEngine.linksStorageEngine)
        try await self.$links.insert(objectStorage.allObjects())
    } catch {
        print("Failed to synchronize links", error)
    }
}

Now you may be saying, Joe, this doesn't look very good. And friend, I would be very inclined to agree with you. As you suggested in #47, I'm not opposed to having a re-synchronization process. One of the core principles of Boutique is data consistency, so I don't want changes to occur automatically in a way where the user isn't aware changes occurring. This mostly leaves me with pursuing a manual approach, one that's triggered infrequently, somewhat like what I came up with above.
I may not have a good answer, but what I am is very open to suggestions, ideas for patterns, and other thoughts you may have on the subject. Hope that helps!


[Feature] Add methods for switching and naming tabs

Reported by andrex42 on 2009-09-03 14:40 UTC
- Is should be possible to influence the naming of the tabs in the scheme editor from the API. Numbering them could get quite confusing when there are more than 2 or 3 tabs.
-  Add API for changing between tabs programmatically.

Updated by andrex42 on 2009-09-03 17:36 UTC

labels: 1030477 -->
assigned_to: andrex42 --> nobody


Fixup recent UX changes

Overview

Increases the font size of the OSHub id on the details page to 18px
Makes the claim description full-width and moves it to the last spot
Prevents reloading the facility search when navigating to details and back
Restores location in list when returning to search from details

List location is reset to the top when a new search is completed
If the user refreshes the page while on the details page, the search will be rerun and the list location will be reset to the top

Restores the map in mobile view on the homepage

Connects #2133, #2127
Demo

Notes
The scroll-to-location consistently returns the user to approximately the correct location, but sometimes is a little bit off. I've spent some time attempting to tweak it, but I think this is as accurate as we'll get without spending significantly more time on it.
I based this on Jacob's PR to handle merge conflicts.
Testing Instructions

Run `./scripts/server
View the map on the homepage on mobile
Run a search
Scroll the list
Navigate to a facility, then back using the back button on screen
Navigate to a facility, then back using the browser back button
Navigate to a facility with a claim description

Checklist

[x] fixup! commits have been squashed
[x] CI passes after rebase
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[x] This PR is targeted at the correct branch (develop vs. ogr/develop)
[ ] If this PR applies to both OAR and OGR a companion PR has been created

I've created a follow-up issue for the scroll restoration: https://github.com/open-apparel-registry/open-apparel-registry/issues/2150


Feature | Show blogs even if user has not signed in.

Where ?

Homepage route "/"

What ?

On 'Start Reading' button click, redirect user to /blogs (even if user not logged) and show all blog list.
If user clicks on any specific blog, perform the following action

If user is logged in, then redirect to /blog/:id and show the full blog (Already implemented ✅)
If user is not logged in, then redirect to /signup (Dev needed ❌)

@aadeshkulkarni I have opened a PR for this.

@aadeshkulkarni I have opened a PR for this.
One suggestion, how about we display header on the blogs page when the user is logged in? Currently it doesn't have a header, so it looks a bit weird when a logged in users goes from /blogs page to /blog/{id} page.

For the sake of UI consistency, let's keep the header visible for authenticated as well unauthenticated routes.
So, let us keep the header for blogs page if the user has / hasn't logged in.

#45 closes this


CMakeLists.txt is not syntax highlighted

Brief Issue Summary
CMakeLists.txt is not syntax highlighted
Expected:
When I open CMakeLists.txt, expected syntax highlight and intellisense.
Apparent Behavior:
It is opened as a plaintext, and if I want to change the language association, there is no "Cmake" - the closest thing is makefile.
CMake Tools Log
None
Platform and Versions
[[For issues, fill out the following. Otherwise delete this section.]]

Operating System: macOS
CMake Version: 3.11.4
VSCode Version: 1.26.1
CMake Tools Extension Version: 1.1.1
Compiler/Toolchain: Clang

There are addons providing syntax highliting for cmake... This one is concerned about building with cmake.

https://marketplace.visualstudio.com/items?itemName=twxs.cmake

ITNOA
I think it is very good to provide Colorization and Completion Lists features with this extension to see complete solution to work with cmake.
@vector-of-bool  did you can merge twxs.cmake with this project?
thx

I would also prefer if this extension provided the syntax highlighting.  I'm currently using the twxs.cmake, however, it differs from the highlighting that Microsoft themselves provide for cmake files in Visual Studio 2019.  In particular, variables and control flow statements are different.  I find the VS2019 highlighting to be better.
Also, in some environments, it's easier to get approval to use extensions provided by Microsoft themselves.

Thanks for the feedback.  This feature request is not yet on our roadmap.  Please make sure you add a 👍 to the first post to add your vote.

"CMake Tools provides the native developer a full-featured, convenient, and powerful workflow for CMake-based projects in Visual Studio Code."

It would be great if this can be addressed. Visual Studio does it and so do many other editors. Its high time Visual Studio Code also does syntax highlighting for CMakeLists.txt files.

@munsingh there is an extension that does syntax highlighting for CMakeLists.txt files in VS Code. It just isn't bundled with this extension.

@munsingh there is an extension that does syntax highlighting for CMakeLists.txt files in VS Code. It just isn't bundled with this extension.

That extension is missing several keywords, and looks like it's abandoned. Furthermore, I don't see why 2 CMake extensions should be required just to get syntax highlighting. "full-featured, convenient, and powerful workflow for CMake-based projects in Visual Studio Code." should include "syntax highlighting". Alternatively, CMake syntax highlighting could come natively with VSCode.

Thanks for the feedback. This feature request is not yet on our roadmap. Please make sure you add a :+1: to the first post to add your vote.

This feature has been the most :+1:'d for ages. Why is it still in the Backlog milestone, and not in the On deck one at least? Is not "ready to be looked into" yet?

Providing language services for CMake is currently out of scope for this extension because it's a significant investment that we haven't been able to justify funding while another extension exists that provides the feature already.  We'd certainly accept a pull request with the implementation if anyone feels like tackling it.
If folks are upset with the use of the term "full-featured", I will remove that from the description.  That was the previous maintainer's word choice and we didn't change it when we assumed maintainer responsibilities because it was part of the "legacy."

I image most other people will do exactly what I've just done.

Open a cmake project
Click to install the suggested extension with the prompt in the bottom right
Be confused that there's no syntax highlighting
Look at the other extensions in the marketplace
Be confused as to whether they overlap with the suggested one I just installed
Find this issue

Every other language I've tried in vscode will get highlighting after installing the suggested extension. Perhaps the twxs.cmake extension could also get suggested-status? That would give an actually full-featured experience.

I image most other people will do exactly what I've just done.

Open a cmake project
Click to install the suggested extension with the prompt in the bottom right
Be confused that there's no syntax highlighting
Look at the other extensions in the marketplace
Be confused as to whether they overlap with the suggested one I just installed
Find this issue

Every other language I've tried in vscode will get highlighting after installing the suggested extension. Perhaps the twxs.cmake extension could also get suggested-status? That would give an actually full-featured experience.

@johnmarkwayve same for me.
To the devs: how would you explain not taking into account the highlighting which is such a visual experience going all over the idea of vsc and its extensions leading to catch many people with less experience?

@johnmarkwayve same for me.
To the devs: how would you explain not taking into account the highlighting which is such a visual experience going all over the idea of vsc and its extensions leading to catch many people with less experience?

So CMake tools notification pop-up told me to remove the CMake extension by twxs, however now I don't have syntax highlighting??
CMake Tools said in this message they implemented those features in this cmake tools extension by Microsoft. But where is my syntax highlighting???
And where is there no update on this issue after 4 years?

Recently, I was trying to migrate from legacy CMake to modern CMake. before that, I was using ms-vscode.cmake-tools and twxs.cmake. However, I now find that the code highlighting and hinting in twxs.cmake is inadequate to support modern CMake.
In the extension marketplace, I found josetr.cmake-language-support-vscode, which appears to be a replacement for twxs.cmake. However, when I went to the repository for josetr.cmake-language-support-vscode, I found that the repository was blank and it also asked me to install ms-dotnettools.vscode-dotnet-runtime.
I think it would be better if ms-vscode.cmake-tools provides code highlighting and hints if possible. I believe people prefer to use official extensions rather than personal, non-open source extensions.

No syntax highlighting support (STILL) is ofc ridiculous. But do we at least get to know which highlighting extension do the developers use themselves? Must be a real shame using another tool for something your own tool was supposed to be doing.

@H-G-Hristov Only one syntax highlighting will be selected by VS Code, so there won't be bad behavior, but it may be indeterminate which extension will actually be being used.
As long as you haven't manually installed the twsx extension yourself, it will be uninstalled when we remove our dependency. Thanks.

This was closed as completed but there are no sign in the change log. What is the deal with this original FR? I see it was split in sub-tasks above. Do we get something in 1.19?

@H-G-Hristov Thank you for the notification. It got marked as completed, but we have not completed this work quite yet, re-opening to correctly reflect our status. Thanks!


[collaboration] Slack!

I went ahead and created a slack channel.
If you've not heard of Slack, its a chat/team collaboration tool that is starting to gain a strong foothold.  I've used many different tools; Google Hangouts and Hipchat  mostly, but I can say that slack is the easiest to use.
I'm online quite a bit, and I know others are as well.  I think it would be easier to just send a slack message for quick questions or discussions instead of creating an issue and waiting around for a reply.
https://zlsa-atc.slack.com/

It looks like it's invite-only? Can I get an invite to the slack channel?

@JasonMKurtz whats your email address?

<EMAIL_ADDRESS>On Sat, Jan 21, 2017 at 6:11 PM, Nate Geslin<EMAIL_ADDRESS>wrote:

@JasonMKurtz https://github.com/JasonMKurtz whats your email address?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zlsa/atc/issues/724#issuecomment-274294590, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACszUQ_EQal86Drpr4FfAYSH_gsdDLNjks5rUpCvgaJpZM4Kwvxc
.

--
Jason Kurtz

done

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


scripts: runners: improve error handling CLI

Trivial error handling improvement.

This is actually an nrfjprog problem. I'm going to close and replace with something else.


Uncaught Error: write EPIPE

Error: write EPIPE
at Object.exports._errnoException (util.js:753:11)
at exports._exceptionWithHostPort (util.js:776:20)
at WriteWrap.afterWrite (net.js:766:14)
Almost everytime I save a file, i have this error.

@i32ropie Can you share more debugging information? Also, where are the files you are saving located (local drive, network drive, ...)?

Possibly related: https://github.com/atom/atom/issues/4708

I've also experienced the linked issue (and commented there with my experience). Currently using Atom 0.181.0 on OS X 10.9.5.
Working with files saved on a local drive. It seems that this is again triggered for me when writing within an ERB tag in an .html.erb file.

Atom Version: 0.184.0
OSX Version: 10.9.5
For me I received the error because a linter plugin I had installed could not find the "clang-format" on my computer. Once I installed it correctly the error went away. So I would say this is not an issue with Atom.

Got same problem when saving.
Uncaught Error: write EPIPE
events.js:94
Error: write EPIPE
at Object.exports._errnoException (util.js:753:11)
at exports._exceptionWithHostPort (util.js:776:20)
at WriteWrap.afterWrite (net.js:766:14)

I guess this is caused by atom-clang-format.
@ChrisKdon
In the file atom-clang-format/lib/main.coffee at line 6, you can find executable is clang-format. But you may have to use clang-format + edition number to call the clang-format in the terminal, like clang-format-3.5. So atom-clang-format cannot find the clang-format.
What's more. formatOnSave is set to true in the file atom-clang-format/lib/main.coffee at line 5. So  atom-clang-format will format file every time when you save it. But atom-clang-format won't success since executable is clang-format.

@ChrisKdon
Finally I got it. In the settings for the clang-format you should be able to change the executable name.

Got this today too

@ahmetabdi Which packages do you have installed and which version of Atom are you using? Can you provide the output of apm list?

@izuzak https://gist.github.com/ahmetabdi/715920ca2b6aa94a6909
I'm on the latest 0.186.0

same problem, same fix, disabling clang-format

I remove the package "clang format" and it's alright.
You guys can try it.

Error when using Markdown to PDF package:
Uncaught Error: write EPIPE
events.js:141
Hide Stack Trace
Error: write EPIPE
    at Object.exports._errnoException (util.js:734:11)
    at exports._exceptionWithHostPort (util.js:757:20)
    at WriteWrap.afterWrite (net.js:753:14)

This should have been fixed by atom/notifications#62. Let us know if you can still reproduce this. /cc @kevinsawicki

I can confirm that atom/notifications#62 resolved the issue for me. Thanks!

Sorry to renege on my previous comment, but I just ran into this issue again on Atom OS X 1.0.2.
[Enter steps to reproduce below:]
1.Edit conditional statement within ERB tag <% %>
Atom Version: 1.0.2
System: Mac OS X 10.10.3
Thrown From: Atom Core
Stack Trace
Uncaught Error: write EPIPE
At events.js:141

Error: write EPIPE
    at Object.exports._errnoException (util.js:734:11)
    at exports._exceptionWithHostPort (util.js:757:20)
    at WriteWrap.afterWrite (net.js:753:14)
    at EventEmitter.ipc.sendSync (/Applications/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/ipc.js:21:31)
    at BrowserWindow.RemoteMemberFunction [as getPosition] (/Applications/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/remote.js:110:29)
    at Atom.module.exports.Atom.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:530:29)
    at Atom.module.exports.Atom.storeDefaultWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:563:25)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:104:21
    at handler (/Applications/Atom.app/Contents/Resources/app.asar/src/space-pen-extensions.js:115:32)
    at jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/space-pen/vendor/jquery.js:4681:9)

Commands
     -4:09.4.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -4:09.2.0 vim-mode:activate-normal-mode (atom-text-editor.editor.vim-mode.visual-mode.is-focused)
     -4:09.1.0 vim-mode:reset-normal-mode (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -4:08.8.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -4:07.3.0 command-palette:toggle (atom-text-editor.editor.vim-mode.is-focused.normal-mode)
     -4:06.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -4:06.1.0 open-on-github:blame (atom-text-editor.editor.vim-mode.normal-mode)
  2x -1:33 vim-mode:reset-normal-mode (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  2x -0:09.3.0 pane:show-next-item (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  4x -0:06.5.0 vim-mode:move-up (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
  2x -0:05.8.0 vim-mode:move-to-next-word (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:04.9.0 vim-mode:activate-insert-mode (atom-text-editor.editor.vim-mode.normal-mode.is-focused)
     -0:04.3.0 editor:select-to-end-of-line (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:02.9.0 editor:select-to-beginning-of-word (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:02.2.0 core:select-left (atom-text-editor.editor.vim-mode.is-focused.insert-mode)
     -0:01.7.0 core:backspace (atom-text-editor.editor.vim-mode.is-focused.insert-mode)

Config
{
  "core": {
    "disabledPackages": [
      "whitespace"
    ]
  },
  "editor": {
    "invisibles": {},
    "fontSize": 17
  }
}

Installed Packages
# User
color-picker, v2.0.11
linter, v1.2.4
linter-coffeelint, v1.0.0
linter-erb, v0.1.1
linter-jshint, v1.1.4
linter-ruby, v0.1.6
linter-scss-lint, v1.0.5
minimap, v4.12.0
symbol-gen, v1.0.0
vim-mode, v0.57.0

# Dev
No dev packages

It looks to me like a process spawned by the linter (maybe ruby or erb) is crashing. Is there any warning output in your console?

@maxbrunsfeld, do you mean the linter Error Panel at the bottom? Or the web inspector console (invoked with cmd + option + I)?
If the former, there are a couple errors on the file, and some warnings along with errors in the project.
If the latter, I see "activate linter-erb", "activate linter-ruby", and "activate linter-scss-lint". Then I see multiple instances of this error ("Uncaught Error: write EPIPE").

I'm getting this issue with Atom 1.0.6 on Windows 7.  I was connecting to a local VM via a Windows share, when I powered down the VM and the share was no longer accesssible, Atom starting throwing these errors.  Probably to be expected as the files were no longer available, but would be nice if the error message could reflect this and be handled more gracefully.


[Bug-FE] [Workflow] Deformation of timeout alarm interface

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Deformation of timeout alarm interface
What you expected to happen
reduce div space
How to reproduce

create workflow
create node
save workflow
click timeout alarm button

Anything else

Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will fix it.


TEMP FIX: How To fix for SD models not working on v2.0 docker.

Description
This PR fixes: Nothing for now, but I have had a few messages on discord about it
Notes for Reviewers
This is a temp fix, will fully remake the page when I know everything is working and updated! <3
Signed commits

[x] Yes, I signed my commits.

@mudler

@mudler or @dave-gray101 this needs merged so I can get the remake started when you get time <3

@lunamidori5 I think it's better to have it fixed properly, as this now would be just confusing (as it removes examples of how to use SDXL and replaces them with standard SD)

SDXL now should be working too, there is actually no need to specify a PipelineType anymore

it is in the docs: https://localai.io/model-compatibility/diffusers/#model-setup


Browser breakpoints should ideally go the breakpoints view

We should open up some contributinos such that the PWA extension can contribute breakpoints to the breakpoints view. Having a new view is a waste of space imho.
Until we have this, can you change your view to only be shown when debugUx is 'default' same as the breakpoints view does here
The name of the context is debugUx so you need to check if debugUx == 'default'

Being able to contribute something like this should be cool...

We will probably not have an inline + Add DOM Breakpoint, since that breaks the pattern which we use in other areas (for example Watch and Function breakpoints).
Idealy it would be a context menu action, or a BREAKPOINTS title area action.
fyi @weinand

Yea, that makes more sense 🙂  A title area "+" that opens the quickpick would work well.


beacon integration : MAID-952

It seems that a WIP of this task which uses fixed port has been merged. That may cause trouble if two instances of same test run in parallel. This PR improves on the last PR by adding a function to generate random port numbers.

Coverage increased (+0.26%) to 90.0% when pulling 15f1df60dc128f5abdea1a946bf55b2438eeb44b on mmoadeli:MAID-592-test into d7394cd79a43a363209b0d00e04fd55e17651dc6 on dirvine:master.

Reviewed files:

Cargo.toml @ r1

src/beacon.rs, line 193 [r1] (raw file):
might be better to initialise a static var and increment with every call

src/connection_manager.rs, line 340 [r1] (raw file):
think this duplication can be resolved by moving the tests in question to the /tests/lib.rs

Comments from the review on Reviewable.io


Use recommended options for "jsx-a11y/no-noninteractive-element-to-interactive-role"

At the moment, the rule is set to error without any options. The idea is to allow things like <ul role="menu" />, which is valid ARIA markup, as explained here: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-to-interactive-role.md#rule-details .

Thanks, must've overseen that, fixing!


add .gitignore for vim files

how is this related to #11 ? 🤔🤔🤔🤔🤔🤔

how is this related to #11 ? thinkingthinkingthinkingthinkingthinkingthinking

i got the grindset bro

yuh


Feature request: Enhance Parser Utility with JSON String Handling

Use case
Problem Statement
When working with AWS Lambda through API Gateway or Lambda Function URLs, request bodies are commonly sent as stringified JSON. The current Parser utility doesn't handle this case elegantly, requiring developers to implement manual parsing or workarounds that compromise type safety.
Current Limitations

Stringified JSON Handling: When receiving a stringified JSON payload (common in API Gateway and Lambda Function URLs), we need to:

Either manually parse the JSON before schema validation
Or create complex nested schemas that don't preserve type information effectively

Type Inference: When using the parser with API Gateway or Function URL handlers:

We lose the automatic response type inference that comes with APIGatewayProxyHandlerV2 or APIGatewayProxyEventV2
Need to explicitly specify response types, adding unnecessary boilerplate

Example of Current Issues
// Current approach with manual parsing - API Gateway or Function URL
const handler: APIGatewayProxyHandlerV2 = async (event) => {
  const body = JSON.parse(event.body ?? "{}");
  const filename = body.filename ?? "unknown";
  // ... rest of the handler
};

// Current attempt with parser (suboptimal)
const schema = z.object({
  body: z.string(), // Have to define as string, losing type information
  // ... other event properties
});

const handler = middy()
  .use(parser({ schema }))
  .handler(async (event) => {
    // Need manual parsing inside handler
    const body = JSON.parse(event.body);
    // Types are lost
  });

Solution/User Experience
Proposed Solutions
1. Built-in JSON String Preprocessing
Add a built-in preprocessor for JSON string fields, similar to the approach discussed in zod discussions:
const schema = z.object({
  body: jsonString(z.object({
    filename: z.string()
  }))
});

// Would automatically parse JSON and validate against schema

2. Enhanced Envelope Support
Add specific envelopes for common Lambda HTTP patterns:
const handler = middy()
  .use(parser({
    schema: mySchema,
    envelope: HttpJsonBodyEnvelope // New envelope type that works for both API Gateway and Function URLs
  }))
  .handler(async (event) => {
    // event.body is already parsed and typed
  });

Benefits

Remove the need for manual JSON parsing in handlers
Single validation step that handles both parsing and schema validation
Reduce boilerplate code in Lambda functions
Fewer places where JSON parsing errors need to be handled
Unified approach for both API Gateway and Lambda Function URLs
Better developer experience with simplified request handling

Alternative solutions
No response
Acknowledgment

[x] This feature request meets Powertools for AWS Lambda (TypeScript) Tenets
[x] Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET

Future readers
Please react with 👍 and your use case to help us understand customer demand.

Hi @garysassano, if I understand the request correctly, this is already possible with the current API.
A couple months ago we have added a helper called JSONStringified that does what I think you're describing. In the docs we don't have a code sample for API Gateway specifically, but we do for ALB and SQS, which follow the same idea: a json stringified field that you want to parse and validate.
I have tested the same setup you showed and it works:

Click on the image to enlarge it ⬆
This is the relevant piece of code:
import { APIGatewayProxyEventV2Schema } from '@aws-lambda-powertools/parser/schemas/api-gatewayv2';
import { JSONStringified } from '@aws-lambda-powertools/parser/helpers';
import { z } from 'zod';

const mySchema = APIGatewayProxyEventV2Schema.extend({
  body: JSONStringified(
    z.object({
      name: z.string(),
      age: z.number(),
    })
  ),
});

and below you have the full code.

import { Logger } from '@aws-lambda-powertools/logger';
import { injectLambdaContext } from '@aws-lambda-powertools/logger/middleware';
import { APIGatewayProxyEventV2Schema } from '@aws-lambda-powertools/parser/schemas/api-gatewayv2';
import { JSONStringified } from '@aws-lambda-powertools/parser/helpers';
import { z } from 'zod';
import middy from '@middy/core';
import { parser } from '@aws-lambda-powertools/parser/middleware';

const logger = new Logger();
const mySchema = APIGatewayProxyEventV2Schema.extend({
  body: JSONStringified(
    z.object({
      name: z.string(),
      age: z.number(),
    })
  ),
});
type MyEvent = z.infer<typeof mySchema>;

export const handler = middy(async (event: MyEvent) => {
  logger.info('body!', { body: event.body });

  return {
    statusCode: 200,
    body: JSON.stringify('Hello, World!'),
  };
})
  .use(injectLambdaContext(logger, { logEvent: true }))
  .use(parser({ schema: mySchema }));

I have opened a PR to add the helper to the API docs and create a standalone section in the Parser docs so that it's more discoverable.

Your solution works for validating the event schema, but it doens't parse the stringified JSON, so you cannot access the body object properties inside the Lambda handler, unless you parse it manually first.
index.ts
import { Logger } from "@aws-lambda-powertools/logger";
import { injectLambdaContext } from "@aws-lambda-powertools/logger/middleware";
import { JSONStringified } from "@aws-lambda-powertools/parser/helpers";
import { APIGatewayProxyEventV2Schema } from "@aws-lambda-powertools/parser/schemas";
import { S3Client, PutObjectCommand } from "@aws-sdk/client-s3";
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
import middy from "@middy/core";
import { z } from "zod";

const logger = new Logger({ serviceName: "presignLambda" });
const s3Client = new S3Client();
const rekognitionBucketName = process.env.REKOGNITION_BUCKET_NAME;

const presignRequestSchema = APIGatewayProxyEventV2Schema.extend({
  body: JSONStringified(
    z.object({
      filename: z.string().min(1).max(255),
    }),
  ),
});
type PresignRequest = z.infer<typeof presignRequestSchema>;

const lambdaHandler = async (event: PresignRequest) => {
  logger.info("Received event body", { body: event.body });
  const { filename } = event.body;
  logger.info("Extracted filename", { filename });
};

log-1
{
    "cold_start": true,
    "function_arn": "arn:aws:lambda:eu-central-1::function:presign-lambda-c8018142",
    "function_memory_size": "1024",
    "function_name": "presign-lambda-c8018142",
    "function_request_id": "718a6ce2-a1d3-4db6-a2f3-0acb6c7c319e",
    "level": "INFO",
    "message": "Received event body",
    "sampling_rate": 0,
    "service": "presignLambda",
    "timestamp": "2024-10-04T15:56:29.995Z",
    "xray_trace_id": "1-6700102d-293675c61163cffe0698113f",
    "body": "{\"filename\":\"cat.jpg\"}"
}

log-2
{
    "cold_start": true,
    "function_arn": "arn:aws:lambda:eu-central-1::function:presign-lambda-c8018142",
    "function_memory_size": "1024",
    "function_name": "presign-lambda-c8018142",
    "function_request_id": "718a6ce2-a1d3-4db6-a2f3-0acb6c7c319e",
    "level": "INFO",
    "message": "Extracted filename",
    "sampling_rate": 0,
    "service": "presignLambda",
    "timestamp": "2024-10-04T15:56:29.996Z",
    "xray_trace_id": "1-6700102d-293675c61163cffe0698113f"
}

At least in your code sample shared above, you are never using presignRequestSchema anywhere after declaring it, nor parsing the event.

I confirm the issue was on my side (forgot to add the use for parser on Middy), and now everything works wonderfully.


CPP-917 Fix infinite loop in token map calculation when using SimpleS…

…trategy

I've experienced this bug, I would like this in the master branch if there's no hold up.

Even further, would be nice to have a release with this since 2.15.1 is entirely unusable for a SimpleStrategy cluster without it.


Only legacy mode works on YK 4

Authenticator offers only legacy mode (adding OTPs to two slots) when YK 4 is used in mode 86 (OTP+U2F+CCID). It seems it is not able to detect CCID functionality of the new key.

If you're trying to add credentials to a YK4 in mode 86, go to File > Settings in Yubico Authenticator and make sure "read from slot 1" and "read from slot 2" are not selected. If you have these selected, you will only be able to add credentials to the configuration slots. If you already have credentials added, you should be able to view them regardless of the settings, as long as CCID is enabled.

Those two options are not selected and I still get only the "legacy" dialog. Old YK NEO works fine.
The device has CCID enabled - output of dmesg:
[214845.066579] input: Yubico Yubikey 4 OTP+U2F+CCID as /devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.4/1-1.4:1.0/input/input1091
[214845.066794] hid-generic 0003:1050:0407.042F: input,hidraw4: USB HID v1.10 Keyboard [Yubico Yubikey 4 OTP+U2F+CCID] on usb-0000:00:1a.0-1.4/input0
[214845.067815] hid-generic 0003:1050:0407.0430: hiddev0,hidraw5: USB HID v1.10 Device [Yubico Yubikey 4 OTP+U2F+CCID] on usb-0000:00:1a.0-1.4/input1

It looks like the problem is in the underlying pyscard or deeper - it does not recognize the SC reader at all:
>>> from smartcard.System import readers
>>> readers()
[]

But with NEO, I get:
>>> readers()
['Yubico Yubikey NEO OTP+CCID 00 00']

OS version? Are libccid and udev rules up-to-date?

Ah, mea culpa, it quickly pointed me to the solution - libccid product IDs were missing. Thanks!


add default entries in MANIFEST.MF file and extra Build-Time entry as well #2185

@mrniko

closing PR in favor of https://github.com/redisson/redisson/pull/2190


add shellcheck to pipeline + format code

PR:

Adds shellcheck to the CI
Severity level is at default (style)
PR also formats the code so the build passes the shellcheck step

Since it is trivial to add unsafe shell code, this enforces best practices when new shellcode is added.

Ah, it means I made sure to format the shellcode in this PR so it passes shellcheck in the CI 👍


Echo text refers to dqlite in 002-switch-to-flannel-etcd upgrade-scripts

At the beginning of the following scripts, the "echo" command mentions "dqlite upgrade" while the scripts are about switching to flannel-etcd. See:
https://github.com/ubuntu/microk8s/blob/master/upgrade-scripts/002-switch-to-flannel-etcd/commit-master.sh#L4
https://github.com/ubuntu/microk8s/blob/master/upgrade-scripts/002-switch-to-flannel-etcd/rollback-master.sh#L4
This seems to be a copy/paste from similar scripts in upgrade-scripts/001-switch-to-dqlite.
I also noticed a small typo here that could be fixed at the same time:
https://github.com/ubuntu/microk8s/blob/master/upgrade-scripts/002-switch-to-flannel-etcd/rollback-master.sh#L44
I created a PR with a suggestion of fix. Please let me know in case you think there are further changes to be made.

Thank you for the fixes @mercimat.


chore: create new @jest/console package

Summary
Keep cutting away at jest-util. First commit is from #8029, ignore it.

Test plan
Green CI

Codecov Report

Merging #8030 into master will decrease coverage by 0.01%.
The diff coverage is 37.5%.

@@            Coverage Diff            @@
##           master   #8030      +/-   ##
=========================================
- Coverage   63.31%   63.3%   -0.02%
=========================================
  Files         263     263
  Lines       10266   10268       +2
  Branches     2098    2100       +2
=========================================
  Hits         6500    6500
- Misses       3273    3275       +2
  Partials      493     493

Impacted Files
Coverage Δ

packages/jest-runtime/src/index.ts
68.98% <ø> (ø)
:arrow_up:

packages/jest-source-map/src/getCallsite.ts
75% <ø> (ø)

packages/jest-console/src/getConsoleOutput.ts
0% <ø> (ø)

packages/jest-runner/src/runTest.ts
2.53% <0%> (ø)
:arrow_up:

packages/jest-console/src/BufferedConsole.ts
70% <100%> (ø)

packages/jest-core/src/runJest.ts
33.78% <33.33%> (ø)
:arrow_up:

packages/jest-console/src/CustomConsole.ts
68.75% <50%> (ø)

packages/jest-util/src/clearLine.ts
0% <0%> (-50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c25942...110da28. Read the comment docs.


too many open files error occurs

Hi,
I faced "Unable to open temporary file after 10 attempts" error when I try to use POST method by asynchronous way.
Code (this code posts given isbn list to the openbd api):
method download-books(Str $filename = "coverage.json", $dir = "$*HOME/.p6openbd") {
    my @coverage = @(from-json(($dir ~ "/" ~ $filename).IO.slurp));
    my $http = HTTP::Tinyish.new(agent => "Mozilla/4.0", :async);

    my &converter = -> (:key($id), :value($batch)) {
        my $isbn-list = "isbn=" ~ @($batch).join(",");
        %(:$id, :content($isbn-list), :retry-count(0))
    };

    my &process = sub (%query, @retry-queue is raw) {
        $http.post("https://api.openbd.jp/v1/get", :content(%query<content>)).then: -> $p {
            my %res = $p.result;
            if !%res<success> {
                my %next-query = %query;
                %next-query<retry-count> = %query<retry-count> + 1;
                die if %next-query<retry-count> >= 10;
                @retry-queue.push(%next-query);
            } else {
# I commented out theses lines to ensure it's not caused by my code.
#                my $fh = open(sprintf("$dir/part-%05d", %query<id>), :w);
#                $fh.write: %res<content>;
#                $fh.close if $fh;
            }
        }
    };

    for @coverage.rotor(5000).pairs.map(&converter).rotor(3) -> $batch {
        my @retry-queue;
        @($batch).map(-> %q { process(%q, @retry-queue) });
        while @retry-queue {
            my %query = @retry-queue.shift;
            process(%query);
        }

    }
}

coverage.json (It's a isbn list);
["9780001971714","9780002110013","9780002110778","9780002112925","9780002113298","9780002113342","9780002114431","9780002114493","9780002116350","9780002151733","9780002151764","9780002151894","9780002151900","9780002160322","9780002160438","9780002161329","9780002161336","9780002161497","9780002161992","9780002163033","9780002167444","9780002168786","9780002171724","9780002175081","9780002175388","9780002175807","9780002176033","9780002177856","9780002178013","9780002178709","9780002179768","9780002179928","9780002180627","9780002182423","9780002182904","9780002190916","9780002190992","9780002191128","9780002254748","9780002550499","9780002550826","9780002555951","9780002556552","9780002558105","9780002558549","9780002571159","9780002725071","9780003750232","9780003750980","9780003831658","9780003833225","9780004330785","9780004332253","9780004334714","9780004334806","9780004356976","9780004586434","9780004588247","9780004588278","9780004705859","9780004707785","9780006169222","9780006172765","9780006174752","9780006177302","9780006267690","9780006326564","9780006326618","9780006331636","9780006334798","9780006335023","9780006338116","9780006338338","9780006339076","9780006341932","9780006357315","9780006359234","9780006369653","9780006369721","9780006386957","9780006432203","9780006531630","9780006531920","9780006541592"
・・・

Error:
# download-books method is called on via books command
$ PERL6LIB=lib perl6 --ll-exception ./bin/openbd books
Unhandled exception in code scheduled on thread 10
too many open files
  in method throw at SETTING::src/core/Exception.pm6 line 57
  in block  at SETTING::src/core/Supply.pm6 line 96
  in method run-catch at SETTING::src/core/Supply.pm6 line 1904
  in any  at /home/itoyota/.p6env/versions/rakudo-star-2018.10/share/perl6/runtime/CORE.setting.moarvm line 1
  in method throw at SETTING::src/core/Exception.pm6 line 54
  in block  at SETTING::src/core/Supply.pm6 line 96
  in block  at SETTING::src/core/Supply.pm6 line 1952
  in block  at SETTING::src/core/Supply.pm6 line 1988
  in method run-under-recursion-list at SETTING::src/core/Lock/Async.pm6 line 207
  in method run-with-updated-recursion-list at SETTING::src/core/Lock/Async.pm6 line 183
  in method protect-or-queue-on-recursion at SETTING::src/core/Lock/Async.pm6 line 146
  in method run-supply-code at SETTING::src/core/Supply.pm6 line 1986
  in block  at SETTING::src/core/Supply.pm6 line 1946
  in block  at SETTING::src/core/Supply.pm6 line 268
  in block  at SETTING::src/core/Supply.pm6 line 230
  in method run-under-recursion-list at SETTING::src/core/Lock/Async.pm6 line 207
  in method run-with-updated-recursion-list at SETTING::src/core/Lock/Async.pm6 line 183
  in method protect-or-queue-on-recursion at SETTING::src/core/Lock/Async.pm6 line 146
  in block  at SETTING::src/core/Supply.pm6 line 229
  in block  at SETTING::src/core/Supply.pm6 line 1723
  in block  at SETTING::src/core/Supply.pm6 line 1720
  in method quit at SETTING::src/core/Supply.pm6 line 1717
  in method quit at SETTING::src/core/Supply.pm6 line 1622
  in block  at SETTING::src/core/Proc/Async.pm6 line 267
  in block  at SETTING::src/core/Rakudo/Internals.pm6 line 594
  in method protect at SETTING::src/core/Lock/Async.pm6 line 132
  in method process at SETTING::src/core/Rakudo/Internals.pm6 line 592
  in block  at SETTING::src/core/Proc/Async.pm6 line 270
  in block  at SETTING::src/core/ThreadPoolScheduler.pm6 line 243
  in block  at SETTING::src/core/ThreadPoolScheduler.pm6 line 242
  in block  at SETTING::src/core/ThreadPoolScheduler.pm6 line 241
  in method run-one at SETTING::src/core/ThreadPoolScheduler.pm6 line 236
  in block  at SETTING::src/core/ThreadPoolScheduler.pm6 line 304

Unhandled exception in code scheduled on thread 4
Cannot do 'print' on a handle in binary mode

Perl6:
$ perl6 --version
This is Rakudo Star version 2018.10 built on MoarVM version 2018.10
implementing Perl 6.c.

Cheers,
P.S.
I saw the message of "Unable to open temporary file after 10 attempts" first time.
However, I couldn't easily reproduce this message now. Instead, I still can see "too many open files" error.

What files does your process open?
lsof -p PID

ls -al /proc/PID/fd

@skaji Thanks for your reply!
lsof:
https://gist.github.com/titsuki/67ad7430d03df1eb62656730a61c2d5a
ls -al /proc/PID/fd returns empty result
$ PID=`ps aux | grep perl6 | grep books | awk '{ print $2 }'`; lsof -al /proc/$PID/fd
$

Thanks.
Could you provide a simpler case that reproduces your issue?

@skaji OK, I'll try it ASAP.

@skaji I made a simpler reproducible code.
run.p6:
use v6;
use HTTP::Tinyish;

my $http = HTTP::Tinyish.new(agent => "Mozilla/4.0", :async);

^10000 .map: -> $url {
   $http.post("http://httpbin.org/post", :content("")).then: -> $p {
      my %res = $p.result;
   }
}

Error:
$ perl6 run.p6
Unhandled exception in code scheduled on thread 14
too many open files

Asynchronous HTTP::Tinyish.request returns a promise and creates 3 tempfiles implicitly.
These 3 tempfiles will be unlinked if the promise is kept or broken.
So, if you call HTTP::Tinyish.request repeatedly without awaiting promises, you will end up with many tempfiles open. This is expected.

IMHO, there are possible workarounds 1) create tmpfiles lazily; or 2) create tmpfiles thread-pool like way as the number of tmpfiles doesn't exceed the limit.
(I'm a curl noob and not sure these solutions are practical idea or not)

I don't think this is an issue, so closing.


Add .clang-tidy to the project

While Visual Studio has built-in clang-tidy integration, the clangd extension on VSCode does not trigger any checks without this file being present.
As a bonus, with the file checked in we can control exactly which checks we want uniformly for all developers.
Example:
---
Checks: 'clang-analyzer-*,concurrency-*,cppcoreguidelines-*,misc-*,-misc-non-private-member-variables-in-classes,modernize-*,performance-*,portability-*,readability-*'
...

Agreed, I thought I had already added this but I must of missed it when I first created the project. I'll add one in shortly. ^^


AMD style

any guide on how to use this with amd style?
i do have react.createClass is undefined with integrate with amd style. any idea?

Ist React undefined or createClass? Which version are you trying to use? Importing directly from lib or the concatenated version in dist? The one in dist should work, however you will need to have React available on the global (window) scope.

it is React undefined..i have imported 0.2.2 from lib.
if i try to build your fileds in src folder with webpack and i do have following error.
any idea?
addComponentAsRefTo(...): Only a ReactOwner can have refs.

You got a line number, file for me?

Uncaught Error: Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).
react-with-addons.js:20242

This sounds more like an issue with your build than with react-mentions.

i just using following command to build your src files.
webpack --output-library="ReactMentions" --output-library="umd" index.js react-mentions.js

Since you are using webpack, you should be able to require anything from within the libs without problems. Definitively you should not need to re-build react-mentions as your last post suggests.

thanks for your info.


Strange ERROR's in the Supervisor logs

Problem/Motivation
There are a couple of ERROR's appearing in my Supervisor log related to Portainer. Portainer works normally as far as I know. I use LetsEncrypt and have HomeAssistant running on HTTPS, so maybe it has something to do with that.
Expected behavior
Not having ERROR's in my logs. :)
Actual behavior
20-11-13 08:14:32 ERROR (MainThread) [supervisor.api.ingress] Stream error with http://<IP_ADDRESS>:1337/api/motd: Cannot write to closing transport

20-11-13 09:22:15 INFO (SyncWorker_4) [supervisor.docker.addon] Starting Docker add-on hassioaddons/portainer-amd64 with version 1.3.0

20-11-13 09:22:15 ERROR (MainThread) [supervisor.api.ingress] Ingress error: Cannot connect to host <IP_ADDRESS>:1337 ssl:default [Connect call failed ('<IP_ADDRESS>', 1337)]

20-11-13 09:22:15 INFO (MainThread) [supervisor.api.security] /host/info access from a0d7b954_portainer

Steps to reproduce
Just using Portainer as normal.
Proposed changes
No clue, as I am not sure where it's coming from.

Seems to have solved itself after a host reboot.


AC: revise async execution

move async from wait_for_any fo callback based api
TO DO:

[x] check flags for other devices
[x] check flags for multi device case
[x] update tests

Next steps

[x] add command line interface to switch between sync/async mode
[x] add command line interface to select the number of infer requests
[ ] extend tests
[ ] special value for automatic async requests
[ ] auto + multi
[ ] print info about num requests

Jenkins please retry a build


UITK - Deprecate Live versions of the Figma libraries and release a new version

### Tasks
- [ ] Add QA playgound for each component
- [ ] Remove guide components
- [ ] Update components where densities don't exist
- [ ] Add component meta data
- [ ] https://github.com/jpmorganchase/salt-ds/issues/2563

### Question
- [ ] split light from dark?

needs breaking into tickets

Split #2563, assigned @pseys. @bhoppers2008 to confirm target date for this mega ticket.

16 Oct - Single component library + Light & Dark libraries

23 Oct - add missing  density to components, starting QA next

All missing densities added, QA starting. @bhoppers2008 and @shey-v meeting tomorrow morning. Aiming for end of this week

3 Nov - A few more components lacking QA, need another week

6 Nov - work in progress.

15/60 components left to be QA'd. Issue discovered with text consistency being investigated/resolved

Update for wb 13/11. @shey-v @bhoppers2008 to complete the following:

Complete light component QA.
Generate dark component library and QA colours only.
Capture significant breaking changes (swap current library to 33.0 library and document significant impact/ manual effort).
Compile release notes (publish in confluence/ site).
Publish libraries.
Release announcements distributed through channels (symphony/ teams/ email).

13 Nov - working on this, expect to finish EOW, almost done on 1st item above

17 Nov - Finishing QA components, Data Grid left. rebuilding Form field. Release note to be done next.

20 Nov - more bug fixes, looking at List / FormField, update guide,

22 Nov - QA form field, more bug fixes, still good for ETA end of week

24 Nov - Light library complete, looking at Dark one on Monday. & release notes, Jira tickets for dev update

27 Nov - list of items to action, @shey-v to continue work until Wed

4 Dec - Data grid rebuilt, reviewing. Excel tracking memory reduced. WIP form field, date picker, aiming EOD. Released note in progress.

6 Dec - writing release note, moving guide to a new library, relinking dark library

8 Dec - Release note drafted, planning to release (publish in Figma) on Monday.

11 Dec - finish release note, test on kitchen sink upgrade test, update code, aim to release EOD

Released


Hover: links in documentation are not doing anything

There can be links from JSDoc in the hover but clicking them does nothing. Should we jump to the documentation maybe and provide a way to go back?

The vscode docs uses custom DocumentLinkProvider to support those links so we'll have to see if we can do something for those. However also don't support normal url such as http://example.com

Fixed normal urls with  d3bbec5.  Opened #35940 to track relative link support


Update docs to clarify package edit feature deprecation

https://github.com/NuGet/Engineering/issues/897

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Policies/NuGet-FAQ.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Not loading NFTs/collections, why is this keeping happening?

What happened?
I wanted to browse collections and NFTs, but some of them did not load. I tried RMRK, BSX, beta.kodadot, incognito mode. I also deleted the cache and cookies.
It keeps happening very randomly. Sometimes it loads them, sometimes not. Sometimes I can see 90% of NFTs, and it will not load 1-2 pieces. Sometimes it works 100%.
This is not happening for the first time; a few artists in the past also pointed it out to me. From a user perspective, it is very annoying, and frustrating, and it makes our platform look very buggy.
Can we come up with a permanent solution for this?

Waiting helps a little (only sometimes) but still, this is after 5 min of waiting:

Please reproduce in steps
Browse collections, open a collection... try also opening NFTs that are not loaded
Expected Behavior

Loading everything as it should
In case Im doing something wrong or I need to do something (delete cookies?), get a notification that will tell me what to do.
In case there is an issue with the platform get a notification: "We are sorry if some of our NFTs are not loading properly......"

What browsers are you seeing the problem on?
Desktop Chrome
At which address did you encounter bug?
beta.kodadot.xyz, kodadot.xyz
Are you logged in?
None
Which wallet you are using?
No response
At which chain did you encounter bug?
Basilisk, Kusama
Screenshots

Relevant log output
No response
Payment link for reward
https://kodadot.xyz/transfer/?target=<My_Kusama_Address_check_https://github.com/kodadot/nft-gallery/blob/main/CONTRIBUTING.md#creating-your-ksm-address>
Code of Conduct

[X] I agree to follow this project's Code of Conduct

On collections I can see some errors, but pictures loads to me well

on kodadot.xyz at items, it loads yet I still got some errors?

Found seems this is the error

https://github.com/kodadot/nft-gallery/issues/4889

aw, checking. let me rollback it first

seems service worker was delaying this I guess and yeah it's happening for me as well now.

Chuckles related

https://github.com/kodadot/workers/pull/29

okay works now, let's invetigate further

It seems okay now, the last thing that is not loading is this "newest list": Invarch banners

not loading is this "newest list": Invarch banners

yes, that was fix for this moring.. yet instead fixing 1%, that fix broke 100% of kodadot :D
continue to

https://github.com/kodadot/nft-gallery/issues/4872


fix: subset & export to encord button.

Subset: no longer crashes, generated project seems to work.
Export to encord: fixed via ignoring hash mappings. Double checking db hash remapping behaviour at the momement.
Found bug with exporting a subset project to encord failing, investigating currently.

Status: almost fully working except that the db migration step errors with:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(SqliteFailure(Error { code: ReadOnly, extended_code: 1032 }, Some("attempt to write a readonly database"))), transient: false })
Currently investigating

Works - digging into bizarre behaviour of prisma regarding caching connections long term.


Train loss and Validation loss are very high!!

I trained the whole LISA dataset, but when the train code was running. I found that the Train loss and Validation loss were up to 2600! Does anybody know what the problem is ??

I have the same problem. The trainning loss at beginning is over 800, and so as the validation loss. And after about 20000 round training, it drop to about 200.

I did some edit to some api, so it can train under tensorflow1.4.1

@xinxueying After training, did you test the images in samples_images folder? Did it have good results?

@Jasonsun1993
Problem solved， I changed the learning rate of training to 0.5 (original code use the default 0.01,which is very small considering training from scratch):
OPT = tf.train.AdadeltaOptimizer()
change to
OPT = tf.train.AdadeltaOptimizer(learning_rate=0.5)

@xinxueying Really? Did you trained the whole data set?? How about the results?? Besides, can I have your Wechat number? I want to discuss about this code further.

Have you got the dataset? I can't open the link  LISA Traffic Sign Dataset(http://cvrr.ucsd.edu/LISA/lisa-traffic-sign-dataset.html). If you got the dataset, could you please send it to me?

@xinxueying what is the val loss when u ended training?


Mutiple physical interface support for secondary network bridge

Describe the problem/challenge you have

When I used secondary network bridge feature, I specified more than one port in secondary bridge, but only one show up:
secondaryNetwork:
ovsBridges: [{"bridgeName": "br-kbear", "physicalInterfaces": ["enp1s0f1v0", "enp1s0f1v1"]}]
Given most SRIOV NICs have 8 HW queues, my request is to support up to 8 ports.
Describe the solution you'd like

secondaryNetwork:
ovsBridges: [{"bridgeName": "br-kbear", "physicalInterfaces": ["enp1s0f1v0", "enp1s0f1v1", "enp1s0f1v2", "enp1s0f1v3", "enp1s0f1v4", "enp1s0f1v5", "enp1s0f1v6", "enp1s0f1v7"]}]
Anything else you would like to add?

/assign

But in this case, do you assume OVS will add the VLAN tag for the traffic? That means we should include a VLAN ID parameter on the physical interface setting in the Antrea secondary OVS bridge configuration.

Humm.. Have you checked if no VLAN ID on the OVS port, will OVS still insert the VLAN tag before sending the packets out?
Also broadcast from one Pod will be sent to all physical interfaces. Maybe it is ok as physical network should drop the packets if the VLAN does not match.
@aroradaman is working on the implementation. He may comment with his test results.

Broadcast is exactly what I am worried about. The traffic from SRIOV interfaces may come from the same (set of) gateways; I didn't want ARP traffic broadcast between these sriov interfaces thus using vlan to isolate.

Humm.. Have you checked if no VLAN ID on the OVS port, will OVS still insert the VLAN tag before sending the packets out?

If I simply attach multiple physical ports with no VLAN ID to the secondary bridge then my kind of cluster networking gets affected and I lose connection to the API Server.
However, If I manually create a bond of all physical interfaces everything is fine and the reachability test passes.

In my case, I made one of physical port as trunk while all other tagged with one particular VLAN.

In my case, I made one of physical port as trunk (no tag) while all other tagged with one particular VLAN; they are all set with ovs-vsctl set port tag

I tried to replicate the same thing in the kind cluster, reachability/ping tests were working fine.
(infra setup: https://github.com/aroradaman/antrea/commit/3b138ee4b2ab29260ca8005e993e24e60ab04e1a)


Question regarding the IDeleteService & delete confirmation

Hi Jon
How you would implement the delete confirmation. The default ASP.NET scaffolding adds a delete confirmation page. You must have a reason for omiting this page. Would you just create a client side confirmation? I couldn't find a way to create a HttpPost controller method using the IDeleteService.
Regards
Jonathan

Hi @riffrack,
SampleMvcWebApp is a really basic example and I skipped some issues, like delete confirm.
In the most of my web sites I use Kendo UI and also a lot more Ajax forms/feedback. Kendo UI delete from a grid includes a confirm, albeit just a 'confirm' box which isn't that visually nice. The complex example SampleMvcWebAppComplex uses Kendo UI and delete is confirmed. Try deleting a pending order.
If you want to write your own then I would suggest say a bit of JavaScript to put up a confirm box, or for a nicer looking version a modal window, with Confirm/Delete buttons. The best way is to deal with the Confirm is to submit a form, as you can then use [ValidateAntiForgeryToken] to make the action more secure.


Missing tabs for getting started section

Getting started section has the following tabs migrated: Android, iOS (AEP) and iOS (ACP), missing Flutter and React Native (ACP) and others. Ref - https://github.com/AdobeDocs/aep-mobile-sdkdocs/pull/20#discussion_r945339047

@calebk1 if this is still an issue, I will let you decide if you want to add the content to the ACP section directly, but we will still need placeholder tabs for RN and flutter in this repo.

This is no longer an issue, as I added this as part of another PR. For tracking, I'll make a JIRA ticket on that instead.


1.9 is actually 1.8

Reported on the 5mods Discord Server, the 1.9 release is actually 1.8.
Checked the DLL with ILSpy, the file does not contains the changes added on #89.
This is critical so @Guad needs to release a 1.9.1 and not replace the existing versions (to avoid different versions as the same package).

Done, thanks for the heads up


Make forgot-password link removable

Is your feature request related to a problem? Please describe.
Make the forgot-password anchor removable as it is now working with the new-user one.
Describe the solution you'd like
Create a new AuthorizationFeature that will handle this behavior by checking a configuration property, and if the user is specified also that the user can update the password, i.e. org.dspace.app.util.AuthorizeUtil#authorizeUpdatePassword.

We @4Science can work on this issue!


Programming exercises: Fix repository export anonymization

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I documented the Java code using JavaDoc style.

Motivation and Context

After exporting an anonymized repository from Artemis I found a file called FETCH_HEAD containing the TUM identifier:
f6f04166d2beaa36d1e6cd819b72b92edb07855d	not-for-merge	branch 'main' of<EMAIL_ADDRESS>
Consulting with @maximiliansoelch and @krusche this seems to be an oversight and should be removed for anonymization reasons.
Description

Remove .git/FETCH_HEAD when anonymizing the .git directory.

FETCH_HEAD is a short-lived reference in Git that records the branch which has been fetched from a remote repository. It keeps track of the last fetched HEAD from all branches in the remote repository, including the specific commit hash that was last fetched.

Steps for Testing

Prerequisites:

1 Instructor
1 Programming Exercise with Submissions

⚠ Info
Ideally pick an exercise on a test server beforehand and check if it contains .git/FETCH_HEAD then deploy and check if it successfully removes this. On test server 3 I checked this with exercise 2717, those repos contain a FETCH_HEAD

Log in to Artemis
Navigate to Course Management
Navigate to any programming exercise
Press Scores (should have at least one score with a repository)
Press Export -> Download Repos
Check Anonymize repository and check Or download the repositories of all students
Export
Check if .git/FETCH_HEAD has been removed from the submissions
Check if you can find any other Personal Identifying Information (PII) in the .git directory -> You should not find any

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

unchanged
Screenshots

Before:

After:

@terlan98 Thanks for testing! This is very strange 🤔 logs is also there. The anonymisation does not work for that exercise at all, I don't know what's wrong. Something strange is going on, but this might be unrelated to my PR.

Thanks everyone for reviewing and testing the PR 🙏
@bassner I looked into this and it seems to be an issue with combineAllStudentCommits, everything is wrapped in this try (Git studentGit = new Git(repository)) {...} block and when it fails it just logs without aborting the export:
log.warn("Cannot reset the repo {} due to the following exception: {}", repository.getLocalPath(), ex.getMessage());
At least that is what I think is happening, I do not know how to access the ts5 logs.
Since I'm very occupied right now with reaching my thesis deadline successfully, I would rather create an issue for this and rename the PR


sessionStorage.redis.sentinel.connectionUrls creates array, but expects string

connectionUrls is of wrong type. Should be a list, but expects string.

Fixed by #268


Update BigQuery related doc to reflect recent changes

As 41cfacca49ab6fb7075970dba7d0c9026dbeb3d9 merged into master and new version released, the README example and related code snippets on Google Developers site need to get updated as well.

@dlackty Thanks for opening this issue! I will make the update for the README and API docs for this library. Unfortunately I have no control over snippets on the Google Developers site.


CMake: fixed how to find ocio header with OCIO_INCLUDE_PATH

Description
Hello there! This change fixes an issue when we try to find the ocio header with OCIO_INCLUDE_PATH defined (and not OCIO_PATH).
Example (with boost, python-2.7 and cmake installed on your system):
export OCIO_INCLUDE_PATH=/path/to/ocio/include
export OCIO_LIBRARY_PATH=/path/to/ocio/lib
cmake . -DVERBOSE=1
# should see:
# -- Found OCIO library...
# -- Found OCIO includes...

Tests
Tested with CMake 3.4.3.

LGTM, thanks for the fix.
Do you need me to also merge into a release branch, or is master sufficient?

It's sufficient to put this code to the master branch for me. Thanks!


Schema endpoint return no detail

Invoking the endpoint
https://swapi.dev/api/people/schema
the response is:
HTTP 404 NOT FOUND
Content-Type: application/json
Vary: Accept
Allow: GET, HEAD, OPTIONS

{
    "detail": "Not found"
}

According to documentation:

JSON Schema
All resources support JSON Schema. Making a request to /api//schema will give you the details of that resource. This will allow you to programmatically inspect the attributes of that resource and their types.

Got the exact same issue

Duplicate of #37


expect message receipt with args, ignoring receipt with different args

I think this is possible using something like:
allow(foo).to receive(:bar)
expect(foo).to receive(:bar).with("baz")

But it would be nice to be able to ensure that a message was received with args at some point whether it was before or after messages with different args.  something like: .at_some_point.
Used like this:
expect(foo).to receive(:bar).with('baz').at_some_point

it 'fails' do
  foo.bar('biz')
end

it 'passes' do
  foo.bar('baz')
end

it 'also passes' do
  foo.bar('biz')
  foo.bar('baz')
end

This is useful when the order of messages received is indeterminate and not important beyond whether the message with specific args was received or not.
Have a working implementation of this if it seems like a good idea for rspec :-)

I don't think this is widely useful enough for us to take it on and enlarge our API.  You can already easily achieve this using a spy:
foo = instance_spy(Foo)

do_something_with(foo)

expect(foo).to have_received(:bar).with("baz")

This only passes if foo.bar("baz") was called, and ignores any other messages sent to foo.

allow(foo).to receive(:bar)
expect(foo).to receive(:bar).with("baz")

Is also a common pattern if you have multiple uses and only care about one, so I'm siding with @myronmarston here and closing this as "not widely useful enough for us to take on", but thank you for taking the time to suggest it!


Unable to fetch data from bitbucket collector

Hi ,
I have tried to configure the bitbucket collector in hygieia .i am facing the following issues.

application.properties:
dbname=dashboarddb
	# Database HostName - default is localhost
	dbhost=localhost

	# Database Port - default is 27017
	dbport=27017

	# MongoDB replicaset
	dbreplicaset=false
	dbhostport=localhost:27017

	# Database Username - default is blank
	dbusername=dashboarduser

	# Database Password - default is blank
	dbpassword=dbpassword

	# Logging File location
	logging.file=./logs/bitbucket.log

	# Collector schedule (required)
	git.cron=0 0/1 * * * *

	# Mandatory parameters
	git.host=mybitbucketrepo.com/
	git.api=/rest/api/1.0/

	# Maximum number of days to go back in time when fetching commits
	git.commitThresholdDays=15
  logging.level.com.capitalone.dashboard=DEBUG
 logging.level.com.capitalone.dashboard.collector=DEBUG
	# Page size for rest calls
	#   Only applicable to Bitbucket Server.
	#   Only applicable to Bitbucket Cloud.
	git.pageSize=25

	# Bitbucket product
	#   Set to 'cloud' to use Bitbucket Cloud (formerly known as Bitbucket)
	#   Set to 'server' to use Bitbucket Server (formerly known as Stash)
	#   More information can be found here:
	https://github.com/capitalone/Hygieia/issues/609
	git.product=server

	# Bitbucket key for private repos

	git.key=fM0sYnrWPYxozSNuMX9dcwhhJtkOKkNz
	bitbucket.key=fM0sYnrWPYxozSNuMX9dcwhhJtkOKkNz

@cgorshing or @shishirchaturvedi Any thoughts?

It appears that the collector is not capable of handling redirects.

@rvema for this issue did i need to  change in collector code or application.properties

i am getting cannot decrypt this message error and 404  error when i trying public repo

can someone help on this issue

Is your bitbucket server behind Single sign on redirection of some type?

I have ran into issues with the api used in master, to the point where I've changed the api used on my local instance. I'll see if I can cause a similar issue.

@rvema This could be a proxy issue. HttpClient can be tweaked here for proxy information: https://github.com/Hygieia/Hygieia/blob/master/collectors/scm/bitbucket/src/main/java/com/capitalone/dashboard/collector/RestOperationsSupplier.java#L14
I have not faced this issue so far. But feels like HTTP client is not providing correct authentication or certs and proxy server endlessly trying to downgrade and upgrade HTTP/HTTPS protocol.

Configure your widget with repo url as https://api.bitbucket.org//, it should then be good.

It is a URL issue I used 2.0 version URL now it's working fine.
On Wed 31 Jul, 2019, 6:42 PM neeraj2k6<EMAIL_ADDRESS>wrote:

Configure your widget with repo url as https://api.bitbucket.org//, it
should then be good.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hygieia/Hygieia/issues/3068?email_source=notifications&email_token=AMWTIGQT4A2DZCZWUPMWOXTQCGFSHA5CNFSM4IGYAVXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HGHVY#issuecomment-516842455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMWTIGS2BSWMRWXULS5XDILQCGFSHANCNFSM4IGYAVXA
.


RFC/Classes: Some (hopefully uncontroversial) suggestions

The "Lost in Space" character goes by Dr. Zachary Smith
The example code to require a mimimum version for a base class
contained a version specification for the actual class, I
added the version specification for the parent class.
The class in the "Roles" example should be a copy of the
"Customer" class and not of the base class "Person"
If you overload with a method, its signature must match
the overloading spec and have two parameters, not zero

Ooops... GitHub magic surprised me.  My brute-force approach to include your recent commit closed the PR.  I can't reopen because GitHub claims I have new commits in my fork (that's your recent update) so I'll prepare a fresh one.