Created container terminal sizing

Issue Type

Bug report

Molecule and Ansible details
sam@taco ~ $ ansible --version
ansible 2.5.0
  config file = None
  configured module search path = [u'/home/sam/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

sam@taco ~ $ molecule --version
molecule, version 2.12.1

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behaviour
molecule login should inherit terminal size.
Actual Behaviour (Bug report only)
It seems that containers made with converge and accessed via login aren't getting  $COLUMNS and $LINES set properly, leading to tiny terminal sizes and lots of wrapping text:
sam@taco ~/projects/personal/columns $ echo $COLUMNS
211
sam@taco ~/projects/personal/columns $ molecule login
--> Validating schema /home/sam/projects/personal/columns/molecule/default/molecule.yml.
Validation completed successfully.
[root@instance /]# echo $COLUMNS
80

Once the container has been made, accessing with docker exec directly also shows the same issue, so it's possibly to do with the way the containers are being made, rather than the way they're  accessed with docker exec and login_cmd_template?
As terminal sizes may change from creation to login, changing the docker exec command to something like 'docker exec -e COLUMNS=$COLUMNS -e LINES=$LINES -e TERM=$TERM -ti {instance} /bin/bash' might do it.

https://github.com/moby/moby/issues/35407 is picking up loads of references from other projects seeing similar issues

$ENVIRONMENT and $LINES aren't the most portable and are bash builtins, so you can't capture with os.environ or os.getenv and shoehorn into https://github.com/metacloud/molecule/blob/master/molecule/driver/docker.py#L106.
May be better to use the output from tput cols and tput lines instead, but shelling out seems a bit gnarly and there's a large chance I'm barking up the wrong tree all together.


Documentation for LoadAsync, cancellation, and transactions

Well, this is more of a question than an issue but ... I guess it's an issue if the documentation doesn't tell me the answer :-)
Will the use of a transaction result in all-or-none loading when cancellation occurs (or for that matter if an error occurs), assuming I am using LoadAsync?
For example, it would be helpful to know that when I do an await dbSet.Skip(n).Take(p).LoadAsync(cancellationToken) within a using dbContext.Database.BeginTransactionAsync(), then definitely either the full page of p records is loaded or no records were loaded.
If it is possible that some but not all of the records get loaded, then I have to check for this and cleanup -- which is not convenient, especially if I am loading into a context that already contains some other records.
sjb

@sjb-sjb You can end up with a partial set of results loaded. However, if there is a failure or cancellation, then there should be no problem just executing the same query again because EF will do identity resolution to ensure that only one instance of each entity is loaded--there should not be a need to clean anything up.

Thanks for the comment. In my case the cancellation will be because I've moved on to loading a different page due to a new incoming user request. It seems like a waste though if I delete perfectly good entities just because it was a partial page load. Maybe I should think about the design a bit more.

@sjb-sjb A few things to note. First, the context is not thread safe, so if the same context is being used to load two pages at the same time, then that is an error. Second, if you want the entities from the first page to not be tracked by the context when loading the second page, then that will require some work regardless of whether all the entities were loaded or not. Third, if you find that you are having to attempt to detach/untrack entities a lot, then that usually means that the context lifetime is too long. A context should usually only live for a single unit of work.

Well, I agree about the threading. This is a client application and the tasks are all awaited from the UI thread, so I think the main challenge in my case is not threading per se but to make sure the tasks on that thread don't get in each others' way. I also agree there's got to be some work done somewhere, there's no free lunch.
About the context lifetime, I have seen this mentioned elsewhere and it seems to be the conventional wisdom. However, I don't get the rationale. The entities are going to be edited by the user (and in a group, not just one at a time) and then saved. If I detach them from the context then I have to keep track myself of which ones have been added, deleted, or modified; and then I have to reproduce that state change when I reattach the entities to a new context in order to save the changes. In other words I would have to do what the context would otherwise do for me. It seems a lot harder than just leaving them attached, no?
I am assuming that the context isn't constantly keeping an open database connection alive, or anything like that. In my mind, when it is not actually executing a transaction the context is basically a normal (i.e. resource-free) data structure that is doing something useful by tracking the entity state. Am I missing something?

@sjb-sjb With regard to detaching entities, it seemed like you were saying that you would need to detach entities for one page because another page is loading. I was trying to say that that might be an indication that each page is a different unit of work.

I agree. It would be nuts to have two tasks competing to load two pages into the same context.
Thanks again for your insights, I really appreciate the depth of your experience.


Present a view on top of a NavigationView

Hi,
I need to present a full-screen cover view. It must be half-transparent and with iOS 13 support, so I can't use fullScreen transition.
So I need to get NavigationView and wrap it into ZStack. There is the problem.
In Stinsen NavigationView created deep inside the lib, in MyNavigationViewCoordinatorView and I can't get it.
I solved it by rewriting MyNavigationViewCoordinatorView and removing the creation of NavigationView in it. Then I create NavigationView manually and wrap it in ContainerView.
Something with that:
class MainCoordinator: ViewCoordinatable {
    var children = ViewChild()

    enum Route: ViewRoute {
        case wallList
    }

    func resolveRoute(route: Route) -> AnyCoordinatable {
        switch route {
        case .wallList:
            let coord = WallsListCoordinator()
            return AnyCoordinatable(
                MyNavigationViewCoordinator(coord, customize: { view in
                    ContainerView {
                        view
                    }
                })
            )
        }
    }

    @ViewBuilder func start() -> some View {
        Resolver.resolve(StartView.self)
    }
}

struct ContainerView<Content: View>: View {
    @ViewBuilder var content: Content

    @StateObject var popup = Popup()

    var body: some View {
        ZStack {
            NavigationView {
                content
            }
            .environmentObject(popup)

            if self.popup.show {
                Color.black.opacity(0.8)
                    .edgesIgnoringSafeArea(.all)
            }
        }
    }
}

It works, but it's not a very good approach really. Is there any better way to do it?
I need to inform NavigationViewCoordinator that It shouldn't create NavigationView because I created and send it in customize variable.

Hi! Every coordinator has a non-documented function called "customize" that can be implemented if you intend to customize the views in the coordinator. You can probably put the @StateObject var popup = Popup() inside the coordinator, and use the customize function like this:
class MainCoordinator: ViewCoordinatable {
    var children = ViewChild()

    enum Route: ViewRoute {
        case wallList
    }

    func resolveRoute(route: Route) -> AnyCoordinatable {
        switch route {
        case .wallList:
            return AnyCoordinatable(
                NavigationViewCoordinator(WallsListCoordinator())
            )
        }
    }

    @StateObject var popup = Popup()

    public func customize(_ view: AnyView) -> some View {
        ZStack {
            view
            .environmentObject(popup)

            if self.popup.show {
                Color.black.opacity(0.8)
                    .edgesIgnoringSafeArea(.all)
            }
        }
    }

[...]

Hi!
I can't do it like this. Because you create NavigationView in NavigationViewCoordinatorView.swift and wrap customize inside it.
Something like that:
#else
        NavigationView {
            customize(AnyView(view))
        }
        .navigationViewStyle(StackNavigationViewStyle())
        .onReceive(coordinator.children.$childCoordinator) { (value) in
        ...

But I need to create a NavigationView myself, set environmentObject for it and send it in customize func. Otherwise my PopupWrapper won't be on the top of NavigationView as I need it to.

Hi! There's a version 2.0.0 now that has a ViewWrapperCoordinator that you could use. Please try it out!

Hi!
Our app is in production now. I'll try the new feature when I work on the next release.
Thanks


Require AWS provider 5.16+

what
Version v0.36.0 does not work with AWS Provider 4.X.
why
In PR #121 of v0.36.0, the preference key scale_in_protected_instances, which had been available only since AWS Provider 5.16.0 introduced by PR#33310, was added. That basically upgrades the required AWS provider version to 5.16.0+.
We will get errors like the below while planning with AWS provider <5.16.0:
│ Error: Unsupported argument
│
│   on .terraform/modules/autoscale_group/main.tf line 187, in resource "aws_autoscaling_group" "default":
│  187:           scale_in_protected_instances = lookup(preferences.value, "scale_in_protected_instances", null)
│
│ An argument named "scale_in_protected_instances" is not expected here.

references

https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pull/121
https://github.com/hashicorp/terraform-provider-aws/pull/33310

/terratest

/terratest

/terratest


Middleware server - make it survive API restart

currently the middleware server crashes when API is down
could we make the middleware server more robust by automatically re-esatablishing the api subscription in case of short downtime of API?

should be fixed with while loop, I guess

tested restart of api --> mw server now up and running


Wrap more objects with CGo

Tree
File
Tag
Commit.References
Commit.Blame
TreeWalker

[Current coverage][cc-pull] is 62.81%

Merging [#56][cc-pull] into [master][cc-base-branch] will decrease coverage by 7.50%

@@             master        #56   diff @@
==========================================
  Files            31         31
  Lines          1732       1732
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1218       1088   -130
  Misses          514        514
- Partials          0        130   +130

Powered by Codecov. Last updated by [8ab543c...0e1bc15][cc-compare]
[cc-base-branch]: https://codecov.io/gh/src-d/go-git/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/src-d/go-git/compare/8ab543c9911dfecbed4cbac5270306ea451537a0...0e1bc15f54d17c218c0c92a704fdf6a16db9cee2
[cc-pull]: https://codecov.io/gh/src-d/go-git/pull/56?src=pr


Compiling Issues (Experimental)

Describe your problem here.
I'm having trouble with compiling my build, I have seemingly installed every needed library (ran the hmm code) but I am getting an error that says I do not have a needed library. I have already tried looking at other posts about the same problem but I keep getting the same error. I also followed at least 3 different compiling tutorials to see if I was doing something wrong but I had everything correct.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I changed the build name/app name

forgot to add this

replace it with TeaCall

how would i do that? thanks

how?

how?

do like video https://drive.google.com/file/d/1qnVoUODGwAAosgqXzlSsuHrf5fz0pph1/view?usp=drive_link

go into the hscript.hx file in the source folder, scroll to line 168 and around characters 89-94, locate SCall and replace it with TeaCall


[Doc]: How to Build an AI Knowledge Base like AI-Ask with vLLM

📚 The doc issue
Hello,
I am interested in building an AI knowledge base similar to the AI-Ask feature provided by vLLM. I have a few questions regarding its implementation:
1.	How can I achieve the construction of such an AI knowledge base using vLLM?
2.	Is it based on any specific open-source solutions or frameworks?
3.	Are there any guidelines or documentation that could help in setting up a similar system?

Any insights or pointers would be greatly appreciated!

Thank you!
Suggest a potential alternative/fix
No response

you need to contact https://runllm.com/ .


Build error: header and sourcemaps are not compatible

Subject. Our header is 7 lines, and offset in debugging is 7 lines too.

This issue should probably be filed on https://github.com/pixijs/pixify instead.

Is this in minified or unminified mode?

unminified.

@bigtimebuddy is this one good to close?

No its not, its still a case and I'm very frustrated about it.


Fix some typos and grammatical mistakes in README

#3134
@ksigler7

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @Naman-Bhalla,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


the cubemap parameters of material are missing

the cubemap parameters of material (texture_prefilteredCubeMap128, texture_prefilteredCubeMap64, ... texture_prefilteredCubeMap4) are missing

Because I call the material.update function in the script update

pc.Material.prototype.update will set dirty flag of material to true.

if material.dirty is true, then pc.StandardMaterial.prototype.updateUniforms will be called and clears material.parameters first.

Then calling pc.StandardMaterial.prototype.updateLightingUniforms is required to reset the parameters of the cube map.

However, updateLightingUniforms is only called by pc.StandardMaterial.prototype.updateshader,
but the shader is not updated because it is determined that the shader of the material has not been changed.
pc.StandardMaterial.prototype.updateShader is not called, and the parameters of the cubemap are not set, they are all undefined.

Hi @Casval111, this is some great detective work! :)
Are you setting the cubemap on the material itself or on the scene?

Hi @Casval111, this is some great detective work! :)
Are you setting the cubemap on the material itself or on the scene?

the cubemap is set on the material itself in the editor. I don't set the cubemap in script, I change other parameters.

Could you possibly share a repro project with me so I can take a look?

Could you possibly share a repro project with me so I can take a look?

https://playcanvas.com/project/827498/overview/cubemap-test

Could you possibly share a repro project with me so I can take a look?

https://playcanvas.com/project/827498/overview/cubemap-test

Awesome, thanks! I've submitted #3455 to address this.


Feature Request - remove compendium folder backgrounds in v11

Feature request - Could you please make it an option to remove compendium folder backgrounds?  Thanks for this great module.  I love it!

Seems easy enough, will probably be included in next release

Awesome.  Thanks!
From: Dorako @.>
Sent: Wednesday, 28 June, 2023 23:47
To: Dorako/pf2e-dorako-ui @.>
Cc: ditzer252 @.>; Author @.>
Subject: Re: [Dorako/pf2e-dorako-ui] Feature Request - remove compendium folder backgrounds in v11 (Issue #202)
Seems easy enough, will probably be included in next release
—
Reply to this email directly, view it on GitHub https://github.com/Dorako/pf2e-dorako-ui/issues/202#issuecomment-1612149207 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATPJWJZ4LSWAZ27FIXE4C73XNSQ5ZANCNFSM6AAAAAAZXR5UZE .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ATPJWJY2EC2Z23PXAZ3PLA3XNSQ5ZA5CNFSM6AAAAAAZXR5UZGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTAC5Y5O.gif Message ID: @.*** @.***> >


lfs.attributes and lfs.symlinkattributes arguments renamed (online doc refresh)

ping

The online documentation is too hard to update ?
It is not important because nobody care about the doc ?


feature: QLoRA fine-tuning pipeline

Initial code for model fine-tuning using QLoRA.
This has successfully run on a private A40 GPU (44gb). However, it throws an Out of Memory exception on a 16gb V100 in AzureML, even though it should theoretically fit.

Codecov Report
Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (4c79762) 98.80% compared to head (421823c) 90.54%.

Files
Patch %
Lines

src/autora/doc/pipelines/train.py
32.35%
23 Missing :warning:

src/autora/doc/pipelines/main.py
77.77%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   98.80%   90.54%   -8.27%
==========================================
  Files           6        8       +2
  Lines         252      296      +44
==========================================
+ Hits          249      268      +19
- Misses          3       28      +25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MAINT: better exception message for Wavelet('continuous_familyname')

Motivated by user confusion on the mailing list.

Current coverage is 86.98% (diff: 75.00%)

Merging #263 into master will increase coverage by 0.01%

@@             master       #263   diff @@
==========================================
  Files            20         20
  Lines          2962       2965     +3
  Methods           0          0
  Messages          0          0
  Branches        297        297
==========================================
+ Hits           2576       2579     +3
  Misses          335        335
  Partials         51         51

Powered by Codecov. Last update 9b63a71...7eef5fa


Change the text about tax deduction on Min Side to how much less tax people will pay rather than how much they get to deduce.

The text on left hand side is not very useful, and for some users (like a donor who just sent us a message asking about it) it is confusing. Change this to say:
"I 2022 får du skattefradrag som kvalifiserer til XXX kroner mindre i skatt."
[If possible to do quickly] Also add for >500 kr donated: "I 2022 har du donert mindre enn 500 kr, og kvalifiserer dermed ikke til skattefradrag."

@fellmirr, target formulation now stated more clearly


Incorrect hexBinary validation

Consider checking this example:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<w:document
    xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main">
    <w:body>
        <w:p w:rsidR="00D7310A">
        </w:p>
    </w:body>
</w:document>

using wml.xsd scheme provided in ECMA-376 2nd edition Part 4. You will get following error:
xmlschema.validators.exceptions.XMLSchemaValidationError: failed validating '00D7310A' with XsdSingleFacet('length', value=4, fixed=False).

Schema:

    <xsd:length xmlns:xsd="http://www.w3.org/2001/XMLSchema" value="4" />

Instance:

  <w:p xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main" w:rsidR="00D7310A">
  </w:p>

After deleting 2 out of 4 octets document passes checking. In docs it is said that length of hexBinary element is counted in octets, not characters: https://www.w3.org/TR/xmlschema-2/#rf-length, so the xmlschema is wrong here.

The fix is available with release 0.9.29 (also for base64binary types).
Those types now use other validation functions (look at hex_length_validator(), hex_min_length_validator() and hex_max_length_validator() methods in facets.py).
Thanks

I don't think you can use same validator for hex and base64. Length restrictions are given for decoded data, in case of hex it is indeed 2 * encoded_length but for base64 it is encoded_length * 3 / 4 (maybe it's possible to miss some = placeholders in the end so final formula will be a little more complicated).
Also, from base64Binary you got XSD_BASE46_BINARY (46 instead of 64).

Yes, you are right. I made confusion between padded and unpadded data.
So the base64 length validator maybe written as:
    def base64_length_validator(self, x):
        if (len(x) // 4 * 3 - (x[-1] == '=') - (x[-2] == '=')) != self.value:
            yield XMLSchemaValidationError(self, x)

The same formula can be used for a min and max length validators.


Update Secvisogram to match current schema version

This is a broader update to match the schema version of oasis-tcs/csaf of branch editor-revision-2021-03-23. It includes:

full support of "Product Identification Helper" (oasis-tcs/csaf#197, fix #6)
parts of "Alphabetical order of properties" (oasis-tcs/csaf#194, #7)
minor refactoring

@pdamian: I finished updating the docs. Could you please have a look again?

Primarily tested the "Product Identification Helper" functionality. Could not identify any issues.
Could be helpful though for the end user to see examples of valid fields, especially for CPEs (instead of just the complex regex that needs to be satisfied). Examples would probably needed to be added to the CSAF JSON schema.

I was so confident of examples for CPEs inside the CSAF 2.0 prose / schema but ... we currently have not. I think in our discussions on the CPE regex we juggled with examples ...
I will consider adding such examples to the schema, thanks @pdamian


[Fix-15072][Resource Center] Non-admin user can not query resource recursively

Purpose of the pull request

close #15072

Brief change log
Before

After

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

We're currently processing your upload.  This comment will be updated when the results are available.

Hi @Gallardot , can you help check the CI error when free?


Fixed required_with_all message

Fixed required_with_all message like Laravel 5.7: https://github.com/laravel/laravel/commit/4b589c1a4a5ec04838408875fc3bd233dbcf5904#diff-9c04f727a922ad4f105b9ad764ec221d
Fixed message also for Italian.

Grazie


Check my pull request to see a problem. https://github.com/umair13adil/flutter_logs/pull/11


feat(root): adds badge guidance to site

Summary of the changes
Adds guidance, code and accessibility pages to site
Related issue
#539
Checklist

[x] I have manually accessibility tested any changes, if relevant.
[x] I have raised this pull request against the develop branch

The guidance says "Avoid attaching badges to non-interactive components. Aim to attach a badge to components that allow navigation to the information that the badge relates to."
but on the code tab we have an example on a chip, which is non-interactive


Avoiding Lockout / Username disclosure

After x tries at a username / password combination, we have the option of locking out the user for a period of time.
Once locked out, we need to let the user know they're locked out. Come back in five minutes. It's a useful feature to prevent brute force attacks etc.
The trouble is, I can abuse this feature to find out if a username (usually email) is a registered user. Just make x attempts, and see if I get the lockout. If the username is not registered, I can try indefinitely: I'll never be locked out, because there's nothing to lock me out from.
Unhelpfully, I can't think of a solution.

Vague yet informational messages (e.g. if you have gotten your password wrong X times, you will be locked out for N minutes) and time constant middleware.

Yes, but my point is that as soon as you do that, you know that that's an email that is registered. So, exploiting the lockout disclosure is a way of maliciously finding out if someone is registered.
The sample code goes to some lengths to stop that scenario, but the lockout notification is a trivial way of circumventing that.
e.g. If I know your email and want to see whether you're registered on mybank.com, I can just try logging on with your email five times. If you are registered, it'll say 'your're locked out'. If you're not, it'll just keep saying 'wrong password' indefinitely. I now know something about you you probably would rather I didn't.

Yes, but my point is that as soon as you do that, you know that that's an email that is registered.

How? If the password is right, then the user gets in and it's not an attacker. If the password is wrong, or the account is locked out you show the exact same error message that's vague but will let you know that if you get the password wrong too many times you'll be locked out. Additionally, sending an email to the account owner on lockout is another good mechanism to inform them what's going on.

Well if you show the same error message regardless (which I agree only way to ensure security). Something like "Your password may be incorrect, or maybe we've locked you out if you've been repeatedly trying. Come back in five."
Let's say I've inadvertently left on caps-lock, I've tried a few  times with what I'm sure is the right password, but keep getting that message. By now I have no idea whether I'm now entering an incorrect password, or whether I've actually entered it correctly but am locked out and it's not even trying to log me in.
I then spot the caps-lock, enter what I think is the correct password, but because I'm locked out exactly the same error appears. "Your password may be incorrect, or maybe we've locked you out if you've been repeatedly trying. Come back in five." The doubt sowed, I think "Did I change it last week? Maybe I did..." I don't know if I'm locked out, so I chance it and try another one. That won't work, Maybe I wait five minutes, but by now I've been told everything I've entered may be incorrect. And I'm not even sure if the lockout is still active or not - maybe it's still not trying?
Rationally, your suggestion might work, but I think would lead to some irate users who rapidly give up. In short, not telling users if they're locked out is not a good experience.
I suggest the only good solution, if Lockout is enabled, is to temporarily store invalid login usernames, and apply the same behaviour ie. show a "you're locked out, come back in five" after five tries.

Yep, it's not easy. Emailing the user when these things happen would be a nice back channel to the user so they know what's going.

Anyway, to the case in point - the Sample implementation tells you when you've been locked out, thereby allowing an easy route to discovering whether a user is registered.

I think that attacker could even block user account by repeatedly entering wrong passowrd in not too that pertiod of time.

I've seen this recommendation somewhere else.  IMO you should only return Locked Out, if the account is locked out and the username and password were correct.  I tested how identity works and I see that it returns locked out status regardless, so I will now have to write a wrapper for SignInManager.PasswordSignInAsync that does exactly that.
Seems like this would be reasonable functionality to add.  While you're at it, you should add password expiration handling.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


[macos] [metal] Support external textures

duplicate of https://github.com/flutter/flutter/issues/73826

duplicate of https://github.com/flutter/flutter/issues/73826


Add count element to Workspace

When I got to a Workspace URL or drag and drop a file of a bunch of components that creates a list, I'd like to have a count of the number of total components in the list.

This implementation has been addressed in #508

Since this has been implemented, we can close it.


problem

SHOW_MODAL_ERROR: An error occurred when showing a modal. DiscordAPIError: Interaction has already been acknowledged.

I tried to look at the other requests but it still gives me problems

Read the faq in the readme


add pg19 dataset

https://github.com/huggingface/nlp/issues/274
Add functioning PG19 dataset with dummy data
cos_e.py was just auto-linted by make style

@lucidrains - Thanks a lot for making the PR - PG19 is a super important dataset! Thanks for making it. Many people are asking for PG-19, so it would be great to have that in the library as soon as possible @thomwolf .

@mariamabarham yup! around 11GB!

I'm looking forward to our first deep learning written novel already lol. It's definitely happening

Good to merge IMO.

Oh I just noticed but as we changed the urls to download the files, we have to update dataset_infos.json.
Could you re-rurn nlp-cli test ./datasets/pg19 --save_infos ?

@lhoestq on it!

should be good!

@lhoestq - I think it's good to merge no?

dataset_infos.json is still not up to date with the new urls (we can see that there are urls like gs://deepmind-gutenberg/train/* instead of https://storage.googleapis.com/deepmind-gutenberg/train/* in the json file)
Can you check that you re-ran the command to update the json file, and that you pushed the changes @lucidrains ?

@lhoestq ohhh, I made the change in this commit https://github.com/lucidrains/nlp/commit/f3e23d823ad9942031be80b7c4e4212c592cd90c , that's interesting that the pull request didn't pick it up. maybe it's because I did it on another machine, let me check and get back to you!

@lhoestq wrong branch 😅 thanks for catching!

Awesome thanks 🎉


Fixed methods first() and toXpath()

I fixed two methods to make it works.

Could you add a test to locator_test.js to show the case you are fixing

Tests are failing... No replies. Closing


Which data is used under the synthetic room dataset

Hi, thanks for your work.
I have noticed that you randomly picked 50 shapes for each set (train/val/test) under the synthetic room dataset.
Would you like to share which data you have used (e.g., index)? I want to do the same exp as you.
Looking forward to your reply.

Hi,
for train/val sets, we use the same models for pre-training.
for the test-time optimization, we use 10 scenes of test set for each category of synthetic room dataset.
room_04:
00000820
00000826
00000827
00000830
00000831
00000832
00000839
00000840
00000988
00000994
room_05:
00000805
00000816
00000838
00000839
00000856
00000869
00000870
00000919
00000990
00000998
room_06:
00000899
00000930
00000931
00000943
00000944
00000945
00000946
00000955
00000960
00000968
room_07:
00000804
00000816
00000831
00000854
00000876
00000917
00000934
00000975
00000989
00000993
room_08:
00000806
00000809
00000810
00000938
00000939
00000940
00000949
00000974
00000981
00000994

Awesome! Thanks for your reply.


Backup in workspaces

Let's figure out a way to allow users to backup (automatically and/or manually) databases and files.

Duplicate of #11


issue

I am not able to see vitruvio component drop-down list, everything else ios coming except this drop-down folder where it has all the attributes

Do you mean the list of attributes is not showing? Have you already assigned a Rule Package? And does your rule file expose any attributes?
If it does not work, could you try:

Open the example map in the Vitruvio Plugin (Content/Demo/Vitruvio_Demo) and check if the attributes show up on the VitruvioActor.
Or download an example from the examples and check if the attributes show up on the VitruvioActor.

Ok I will give it a try Sent from Mail for Windows 10 From: Benjamin NeukomSent: Monday, March 22, 2021 7:52 PMTo: Esri/vitruvioCc: nisargpatel220303; AuthorSubject: Re: [Esri/vitruvio] issue (#40) Do you mean the list of attributes is not showing? Have you already assigned a Rule Package? And does your rule file expose any attributes?If it does not work, could you try:Open the example map in the Vitruvio Plugin (Content/Demo/Vitruvio_Demo) and check if the attributes show up on the VitruvioActor.Or download an example from the examples and check if the attributes show up on the VitruvioActor.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

I assume this has been solved. Otherwise please feel free to ask again on https://community.esri.com/t5/arcgis-cityengine-plugin/bd-p/arcgis-cityengine-plugin-questions


Missing parameters in validateJWT usage example

The example in how to use validateJWT() in oslo/jwt is missing the first two parameters:
https://github.com/pilcrowonpaper/oslo/blame/ef7b14b387c0dcf9c8c50e01e82137d6ba5def6d/docs/pages/reference/jwt/validateJWT.md#L35

Sorry duplicate of https://github.com/pilcrowonpaper/oslo/issues/67


Needs more information when referencing a project that targets multiple frameworks

We have a class library that builds both .NET Core and .NET Framework.
We create a Core console app and include a reference to the class library project file (CSPROJ).
The reference created by Visual Studio points to the .NET Framework version of the class library instead of the Core version.
This page should explain how to include a project reference to another project, ensuring that it will reference the correct version of .NET.
Note: I'm assuming I'm doing something wrong and that this isn't a bug.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1ab2b85e-d741-293c-b994-8673ebf9ec2b
Version Independent ID: a3697a8f-ea35-c2ca-9cb3-fd15c6bd5ca3
Content: Manage references in a project - Visual Studio (Windows)
Content Source: docs/ide/managing-references-in-a-project.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@ketchup201 -- thank you for your thoughtful feedback.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@TerryGLee -- please look into this issue.

user error :-(


Required Query Variables are optional

Is your feature request related to a problem? Please describe.
I'm frustrated that my GraphQL variables are not enforced in generated hooks
type Query {
    hello(foo: String!): String
}

query Bar ($foo: String!) {
  hello(foo: $foo)
}

Describe the solution you'd like
Hooks (Apollo 3) generated typically have optional baseOptions.  So callers of the generated hooks sometimes forget that a query requires a variable.   If a query document includes a variable - it would be ideal if the type signature reflected this requirement.
See:  https://codesandbox.io/s/apollo-server-de1p6
Describe alternatives you've considered
Create module level override hooks that add required fields from their signature and call the generated ones.

@tbrannam the query and fragment you mentioned are not valid. Can you please share a reproduction of the issue? in a repo or in a codesandbox.
Also, which version of codegen do you use?

I've created a mock server here: it has client.ts which shows how the generated hook variable contract isn't being typechecked.   It would seem that if a Query required variables, the baseOptions would no longer be marked as optional.
https://codesandbox.io/s/apollo-server-de1p6

closing pending further research

Why did you close this? baseOptions and baseOptions.variables should not be required  if the variable is required in the query.

@eyalw can you please share a reproduction?

@dotansimha Here's a sandbox reproducing the issue:
https://codesandbox.io/s/apollo-server-forked-fn0q5?file=/client.ts
In that sandbox you can see that the mutation UpdateUser requires an id as an input.
However in the component:
  // Does not throws an error with a missing id = INCORRECT
  // BaseOption should not be optional
  useUpdateUserMutation();

  // This throws an error, as it should = CORRECT
  useUpdateUserMutation({ variables: { input: { }});

  // The only correct way that should be valid = CORRECT
  useUpdateUserMutation({ variables: { input: { id: "hello" } } });

@dotansimha
Hello! Will the changes be completed? It would be great if this were merged as this optional variables type can cause a lot of trouble.


Fixing regression in Resources/ResourceGroups checkExistence because of code regen

also improving unit test to catch this in the future better

Can one of the admins verify this patch?

one of these was already covered by an existing unit test.
This PR actually includes an existing unit test enhancement to cover the other one (https://github.com/Azure/azure-sdk-for-java/pull/1486/files#diff-1e5fd1d3fcfe3dd6536da9366bd4ab0eR88)


Openshift overview charge graph shows total value but daily values are all 0

Describe the bug
Openshift overview charge graph shows total value but daily values are all 0
To Reproduce
Steps to reproduce the behavior:

Go to overview
look at charge graph

Expected behavior
Should see daily values presented in the graph when total value is not 0
Screenshots

Desktop (please complete the following information):

OS: Fedora
Browser Chrome
Version 66

Additional context
Testing again CI insightsbeta
I assume this is from the IPP12 API updates.

Verified


Update CLI for source addition:

Allow multiple urls
Allow setting max-documents and max-depth
Rely on server for default values

Will submit once https://github.com/fixie-ai/fixie/pull/1639 is in


Make the command system more modular.

In order to allow for EssentialCmds to be more modular, and to group command code together, a CommandLoader has been introduced that loads the commands. This command loader can be extended to selectively register commands in the future.
This should help with any work on https://github.com/hsyyid/EssentialCmds/issues/18, which seems to miss making commands modular!
The CommandExecutorBase contains getAliases() for the command names, getSpec() gets the CommandSpec, and getAssociatedModules() will provide a way to associate a command with a set of modules - though no modules have been assigned. This last method is designed to be scanned within the CommandLoader to choose whether to load a command or not.
Some commands use the AsyncCommandExecutorBase, which runs the command on an async thread, keeping some tasks off the main thread.
Some sub commands have been merged into the original base commands. Some other commands have had minor touch ups/fixes to use newer Sponge features (just as I saw them).
In particular: /r has been rationalised to reuse /m code, and a new TimespanParser has been added for /mute, and could be useful for /tempban and any other time limited commands.

Wow! Nice job on this! I'm going to read through it, test it, etc. Thanks for the help!  :smile:

@dualspiral Hello. I am happy to say I am beginning to start the modularization update. I would like your help, especially with using the command system you wrote for the plugin, please let me know if you've got some spare time and can lend a hand :smile:

@hsyyid - I've pinged you in #spongedev but I don't think you're there at the moment! Let me know when we can have a chat, I think your ideas need to be fleshed out before code is put down. This will be a very big task and may need a lot of changes.

@dualspiral refer to #13 for general structure that planned out early on. Would love some opinion on that. Either that or we can actually make each module its own repository...


Unable to query AZUREUSGOVERNMENTCLOUD sovereign cloud tenant

Describe the bug
I am unable to query any Azure AD tables in an AZUREUSGOVERNMENTCLOUD sovereign cloud tenant. I tried both Azure CLI and service principal client ID and secret for authentication. I can confirm I have the necessary permissions, and Azure CLI commands such as az ad user list work.
The specific error I receive when querying any table is:

response cannot be nil

Steampipe then produces an empty result set.
I have attached my azuread.scp config file and logs from running a query with STEAMPIPE_LOG_LEVEL=DEBUG.
azuread.spc.txt (renamed to .txt to allow for GH upload)
database-2023-08-02.log
plugin-2023-08-02.log
Steampipe version (steampipe -v)
v0.20.9
Plugin version (steampipe plugin list)
v0.12.0
To reproduce

Authenticate Azure CLI with an Azure US Government tenant. Example:
az cloud set --name AzureUSGovernment
az login --tenant TENANT_ID_HERE

Create the ~/.steampipe/config/azuread.spc file as attached.

Run any query. Example from docs:
steampipe query 'SELECT display_name, user_principal_name, user_type FROM azuread_user;'

@bryanburke, Thanks for using Steampipe!
Sad to see this this blocked you. You have provided a good set of information to start with. We will investigate this and revert.

@bryanburke, we appreciate your diligence in bringing this issue to our attention. We have successfully replicated the problem on our side. At the moment, we are actively investigating the matter and will certainly keep you informed as soon as we arrive at a resolution. Your patience is greatly appreciated. Thank you!

@bryanburke, just a quick update: we have gone ahead and raised an issue on the SDK side addressing this matter. Our plan is to continue our efforts once we've received feedback on that front. Thank you for your understanding!
Issue ref: https://github.com/microsoftgraph/msgraph-sdk-go/issues/552

Hi @bryanburke , I believe we're still blocked on https://github.com/microsoftgraph/msgraph-sdk-go/issues/552, which hasn't received a response yet. I'm closing this issue but we will re-open once we receive more info in the SDK issue.
If you have any other questions, please let us know!


Support for showing IP other than agent IP for port-mapping information

Rancher computes port-mapping information for services currently based on the IP that the agent is bound to, some users have requested the ability to use the IP address of another interface on the host, such as the interface for an internal management network that they access services in Rancher over. This is only an issue when the network they want to access services on is not the same network they want agents to bind to.

The default is <IP_ADDRESS>; if you want to bind to something specific you can and it will be reflected.

When i look at the UI, I see actual interface addresses however, and I haven't specified anything
(see screenshot)

Showing <IP_ADDRESS> is not very helpful/clickable, so the agent IP is shown in the UI.  But that doesn't mean it's listening only on that IP.  And if you add additional IPs to a host and request a specific IP, it will show there instead.  FWIW, 2.0 shows both, i.e. <IP_ADDRESS> (<IP_ADDRESS>).

Yea I understand it is actually listening on all interfaces, the issue is the customer has a lot of internal users who don't understand that fact and so they expect to be able to click the link in the UI and be taken to the correct URL.

What is the mechanism by which you would like it to divine the correct URL?

I don't have a preference. If your looking for ideas I could imagine a label on a host being a nice way to specify the "presentation" IP address for the host.

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


is x6 times slower compiling time a normal thing when migrating from 1.6 to 1.8?

Compile time went from 10 seconds to over a minute after upgrading from 1.6 to 1.8. Is this normal?

what version of node do you use?

v0.12.7

It looks like a known perf regression with node v0.12. Can you try to upgrade to node v5 and check if it improves the situation?

ok

version 5.x made it better, now it's about 30 secs which is only x3 slower, doesn't it look normal now?

it is better but still not good enough. Can you share a repro so we can look into this more closely?

I am afraid I can't, is there another way to get the data you need?

can you try to add --diagnostics to compiler options to see what compilation stage takes the majority of time? Ideally if you can do this for TS 1.7 and 1.8 and paste results here.

version 1.7.5
Files:            1040
Lines:          216063
Nodes:          996205
Identifiers:    365978
Symbols:        413474
Types:          136178
Memory used:   507589K
I/O read:        0.16s
I/O write:       0.45s
Parse time:      4.87s
Bind time:       1.52s
Check time:     64.69s
Emit time:       2.68s
Total time:     73.76s

version 1.8
Files:            1040
Lines:          216063
Nodes:         1010583
Identifiers:    380352
Symbols:      72631648
Types:          135632
Memory used:   586952K
I/O read:        0.31s
I/O write:       0.33s
Parse time:      5.36s
Bind time:       2.58s
Check time:     17.45s
Emit time:       1.81s
Total time:     27.21s

can you also put results for 1.6 for comparison?

version 1.6.2
Files:            1040
Lines:          216063
Nodes:          996161
Identifiers:    365961
Symbols:        146503
Types:          110017
Memory used:   501672K
I/O read:        0.16s
I/O write:       0.52s
Parse time:      4.97s
Bind time:       1.49s
Check time:     11.22s
Emit time:       3.14s
Total time:     20.82s

turns out 10 sec for 1.6 has never been a thing unless v0.12.7 did some magic to it
guess, the case is closed
thanks!

interestingly the nightly 1.9.0-dev from last night is the fastest
Files:            1040
Lines:          216063
Nodes:         1010599
Identifiers:    380359
Symbols:      72631437
Types:          135560
Memory used:   570245K
I/O read:        0.19s
I/O write:       0.36s
Parse time:      3.20s
Bind time:       1.25s
Check time:     11.90s
Emit time:       1.84s
Total time:     18.19s

gonna keep that

@aleksey-bykov, where the perf numbers look good, the number of symbols seem intriguing, we would love to take a look. is there a way we can get access to this code base? we would be open to singing relevant NDA.

let me see what i can do

Hi guys, same problem here.
1.6 twice as fast as later ones.
Ubuntu 14.04
Node v 5.5.0
npm 2.5.1
1.6
Files:             581
Lines:           72366
Nodes:          277997
Identifiers:     90330
Symbols:         60198
Types:          237089
Memory used:   492525K
I/O read:        0.02s
I/O write:       0.10s
Parse time:      0.75s
Bind time:       0.35s
Check time:      5.46s
Emit time:       0.95s
Total time:      7.50s
``

1.8

Files:             581
Lines:           72372
Nodes:          286345
Identifiers:     98412
Symbols:      27327413
Types:          575237
Memory used:   728993K
I/O read:        0.02s
I/O write:       0.16s
Parse time:      0.69s
Bind time:       0.38s
Check time:     10.62s
Emit time:       1.67s
Total time:     13.36s

1.9

Files:             581
Lines:           72461
Nodes:          286858
Identifiers:     98586
Symbols:      27388515
Types:          575043
Memory used:   717166K
I/O read:        0.02s
I/O write:       0.12s
Parse time:      0.68s
Bind time:       0.35s
Check time:     10.74s
Emit time:       1.43s
Total time:     13.21s

is it possible to share the code that reproduces the problem (we can sign the NDA if necessary)?

@vladima  Will ask our stakeholder, soon.

@vladima sorry guys, no permition

neither can I, sorry

I am having this problem as well. Build went from 32 sec to 70 seconds when upgrading from 1.7.3 to 1.8.10. Here is the diagnostic output for 1.8.10
Files:            1285
Lines:          294119
Nodes:         1483138
Identifiers:    465048
Symbols:     140768300
Types:           90686
Memory used:   542756K
I/O read:        0.14s
I/O write:       0.39s
Parse time:      2.40s
Bind time:       1.79s
Check time:     63.54s
Emit time:       2.65s
Total time:     70.39s
FWIW - I work @ Microsoft, so you should be able to view my code pretty easily if that would help.

I should also mention I am on node 0.12.13. I will attempt to upgrade to node v5, but that will likely cause more issues than it is worth.

Using node v5.11 just for tsc builds now in 16s. Much faster!!! Not sure the rest of my build will work on node v5 but will check

it does not have to be V5. anything that is not v0.12.* would be better.


Add requirements.txt

I add any other dependencies to requirements.txt that isn't referred to at README.md.
I add the instruction of installation of dependencies to README.md.

Thanks :)


Crash/conflict with TConstruct

I know this involves two separate mods, so I am posting this crash on both mods' threads/pages.  Crash detail as follows:
PasteBin link

Try updating Ex Compressum to v 3.0.6. Their release note is:
"Fixed crash due to Tinkers Construct API change."
And I could only get mine to crash by downgrading from 3.0.6.


Variables local to closures are showing as top-level vars in outline

As of version 0.0.8 JavaScript variables that are defined locally in closures are appearing as "top-level" variables in the code outline, rather than as variables of anonymous functions within their respective contexts.
Example below is the outline of a file defining an ES6 "class", the editor showing a method in which the highlighted variable in the outline is a variable defined locally within a closure within the method.  Each of the "blue" variables in the outline are similarly defined within closures within some method.

I may have jumped the gun here -- looks like I need to check the configuration for the plugin.

This is currently true. I have an idea on how to improve this for languages that report proper symbol ranges though.


update(modern_bpf_engine): add a check on the minimum kernel version

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-modern-bpf
/area libscap
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR adds:

a new API in scap to compute the semver check
a new check in the modern probe engine to ensure that we are on a supported kernel

Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
update(modern_bpf_engine): add a check on the minimum kernel version

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 1b69a158a3cb4681ce9e40361f96332c5960c4a6

/hold for milestone 0.10.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

If bpf helpers are correctly backported on the previous kernel we could also support older versions than 5.8.0, so maybe these changes are not so needed :thinking:
/hold

If bpf helpers are correctly backported on the previous kernel we could also support older versions than 5.8.0, so maybe these changes are not so needed 🤔 /hold

Is there a way to discover that all the helpers we need are available in the current kernel, perhaps with bpftool? If there was such a thing, we would need to check if the required helpers are available instead of enforcing a minimum kernel version.

Hi @jasondellaluce , @Andreagit97

If bpf helpers are correctly backported on the previous kernel we could also support older versions than 5.8.0, so maybe these changes are not so needed thinking /hold

Is there a way to discover that all the helpers we need are available in the current kernel, perhaps with bpftool? If there was such a thing, we would need to check if the required helpers are available instead of enforcing a minimum kernel version.

Thanks to @iii for some insights: The libbpf itself does a couple of "feature" probes, e.g.,

kernel_supports
(my favorite one :-) probe_kern_probe_read_kernel directly
or via the kernel_supports here

So seems there are ways to dynamically check for helpers.

Hi @jasondellaluce , @Andreagit97

If bpf helpers are correctly backported on the previous kernel we could also support older versions than 5.8.0, so maybe these changes are not so needed thinking /hold

Is there a way to discover that all the helpers we need are available in the current kernel, perhaps with bpftool? If there was such a thing, we would need to check if the required helpers are available instead of enforcing a minimum kernel version.

Thanks to @iii for some insights: The libbpf itself does a couple of "feature" probes, e.g.,
* [`kernel_supports`](https://github.com/libbpf/libbpf/blob/68e6f83f223ebf3fbf0d94c0f4592e5e6773f0c1/src/libbpf.c#L4839)

* (my favorite one grin ) [`probe_kern_probe_read_kernel`](https://github.com/libbpf/libbpf/blob/68e6f83f223ebf3fbf0d94c0f4592e5e6773f0c1/src/libbpf.c#L4638) directly

* or via the `kernel_supports` [here](https://github.com/libbpf/libbpf/blob/68e6f83f223ebf3fbf0d94c0f4592e5e6773f0c1/src/libbpf.c#L6643)

So there are ways to dynamically check for helpers...

yeah that's true but IIRC these are all internal APIs that libbpf doesn't expose to userspace :thinking:

Uh there is a public API libbpf_probe_bpf_helper :rocket:

Right now I will keep this check on the minimum required kernel version, in the next step we can try to probe some kernel features with libbpf, the only pain point is that some API that libbpf uses to probe specific features are not exposed to the user so we have to find some workaround :)
/unhold


Download all groups for an account

Given I have an account that's a member of many groups, I wish to download all groups at once. Provide a top-level command to allow for this.

The following API call returns this:
https://groups.yahoo.com/api/v1/user/groups/all?start=21&count=20&sortOrder=asc&orderBy=name&chrome=raw&tz=America%2FLos_Angeles&ts=1572288853696


Firebase API key & secret in plaintext

apiKey param clearly visible to anyone in app.js
https://github.com/mj66/shipit/blob/620242ec2d6f020f487e2ee5ab248b5862380e62/asset/js/app.js#L3
This is a critical security issue and should be addressed asap. Some solutions involve fetching apiKey from a separate gitignored file or from an env var.

Hmm... I interesting...
So I looked up the risk of exposing Firebase API Key, and I found that storing API key in front-end is not a security risk, ask Firebase will need an authorized domain in order to run. Therefore, just having the API key is not a security risk to the database, especially when we have strict i/o rules set up for the database.
Ref: StackOverflow

Ah ok, I thought that there weren’t any domain auth, restrictions or rules. I was just advising of a coming convention in OSS development.
Thanks for the insight.


Cilium-health cleanups

[x] Remove not-yet-implemented bits from the API
[x] Add documentation for cilium-health
[x] Restart cilium-health when killed (extend cilium-health/launch and/or pkg/launch)
[x] Don't overwrite newer samples (currently periodic sync may overwrite results of --probe)  (#2956)
[x] Garbage-collect results for nodes that have left the cluster (#5185)
[x] Improve representation of HTTP connectivity issues (#3563, PR #6402)
cilium-health endpoint shouldn't respond to requests from other regular endpoints
[ ] If any nodes or endpoints can't be reached in the cluster, --probe times out and does not print any output
[ ] Distribute pings better across the interval
[ ] Timestamps per individual probe rather than for all probes in the interval
[ ] Limit timeout of each probe to ~1-2s rather than the full 60s interval

[ ] Update entries more promptly when connectivity is lost in this case (current worst case is almost 2xinterval)

[ ] Allow cilium-health arguments in cilium-health/launch to be configured at runtime (#5713)
[ ] Add gingko tests for IPv6
[ ] Trust IP addresses directly rather than resolving them?

https://github.com/cilium/cilium/blob/94c02bb85aee1fe9116a5b43b1b39160d355ee12/pkg/health/server/prober.go#L218

[ ] Add unit tests

I think that some of the above checkboxes are still valid caveats to the current implementation, but it's clear that @mrostecki and I are not focusing our attention on this at the moment, so I've unassigned us to reflect reality.
Anyone interested in investigating this is welcome to post questions below or on Slack to get pointers on how to work on improving the cluster connectivity checking.


Tor can`t make an outgoing requests in Windows

Hi. It seems there is some problem with running your project in Windows. I've pulled it in Docker, started it as the instruction says, but tor doesn`t make outgoing connections. I can see in HAProxy stats that requests come to it, but then nothing happens. In Linux the projects with the same settings work in proper way. What can it be and can it be fixed? (And thanks for your work, by the way :) )

Well, it seems that this issue is identical to #10 "Any idea why when running in detached mode it doesn't work?". The problems I`ve told about happen only in detached mode, although in attached mode everything works.


Integrate Specter Desktop in new Connect menu

Having a guide about how to connect Specter Desktop with the RaspiBlitz is good – obsoleting it with software would be even better.
As the RaspiBlitz v1.7.0 will feature a new Connect menu, it would be good to integrate Specter Desktop there: The user can opt-in for making the bitcoind RPC available on the local network and a script could preconfigure the settings and firewall according to the guide. It could then restart bitcoind and show the user a confirmation and information on how to configure the connection in Specter Desktop.

Good news, you can try this in the dev branch already: https://github.com/rootzoll/raspiblitz/pull/2119

As testing now the workflow can be improved a it exits in the main menu after activatiing, but here is the option to show the details:

<IP_ADDRESS>
RPC username:
raspibolt

RPC password:
REDACTED

Host on the local network (make sure to connect from the same network):
<IP_ADDRESS>

Port:
8332

More documentation at:
https://github.com/openoms/joininbox/blob/master/prepare_remote_node.md

Awesome, so this will be part of v1.7? Then I can update the article and point to that feature instead. Great work! 💪

@openoms you are so fast, thanks for the great work.

Hmm OK .. I fixed some small problem with the port ... but on my tests for v1.7 it does not look as the connection with Specter Desktop App is sucessfull - see:

I will have the script in v1.7 (because its a generic RPC connection dialog anyway) but push this to v1.7.1 ... for finalization. @openoms if you have a quick fix for final v1.7 I am happy to add.

OK .. the raspiBlitz needed a reboot, then the connection was working with all checkmarks. Maybe this was due to the activation of the bitcoin wallet. So lets finalize this in v1.7.1

All checkmarks green - closing issue for v1.71. release.


Add google-cloud-tasks-pull-to-push chart to incubator

What this PR does / why we need it: New incubator chart for the google-cloud-tasks-pull-to-push tool. This tool is for a GCP-specific purpose: to work around the inability of Google Cloud Tasks push queues to target arbitrary URLs (they can currently only target App Engine hosted URLs).
Special notes for your reviewer: At the moment I don't know of any other users of this tool / chart. Is this suitable for adding to the chart repo? The guidelines don't mention 'notability' 😄. Being in the repo would at least simplify deployment for me.

@mattfarina @scottrigby Anything I need to do here? Is this suitable to add as a chart here, or should I be using my own repo?


Create LICENSE

README mentions MIT as a license but there is no license text. I assume that this is the license you meant to use?
Including the license is important, it is even needed to abide by the license itself:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

This is also needed to show the Go documentation in its newest update.


Missing Group Classes/Styles property from the BitCalendar component

Missing Group Classes/Styles property from the BitCalendar component

not valid anymore


Command unrecognized

Version
Microsoft Windows [Version 10.0.20348.169]
WSL Version

[ ] WSL 2
[X] WSL 1

Kernel Version
5.10.16
Distro Version
Ubuntu-18.04
Other Software
No response
Repro Steps
in powershell ：
Run the command：”wsl --set-default-version 2“ and ”wsl --set-default-version“
Expected Behavior
Change the default version of the WSL
Actual Behavior
but return

`PS C:\Users\Administrator> wsl --set-default-version 2
Copyright (c) Microsoft Corporation. All rights reserved.
Usage: wsl.exe [Argument] [Options...] [CommandLine]
Arguments for running Linux binaries:
If no command line is provided, wsl.exe launches the default shell.

--exec, -e <CommandLine>
    Execute the specified command without using the default Linux shell.

--
    Pass the remaining command line as is.

Options:
--distribution, -d
Run the specified distribution.
--user, -u <UserName>
    Run as the specified user.

Arguments for managing Windows Subsystem for Linux:
--help
    Display usage information.

--install [Options]
    Install additional Windows Subsystem for Linux distributions.
    For a list of valid distributions, use 'wsl --list --online'.

    Options:
        --distribution, -d [Argument]
            Downloads and installs a distribution by name.

            Arguments:
                A valid distribution name (not case sensitive).

            Examples:
                wsl --install -d Ubuntu
                wsl --install --distribution Debian

--set-default-version <Version>
    Changes the default install version for new distributions.

--shutdown
    Immediately terminates all running distributions and the WSL 2
    lightweight utility virtual machine.

--status
    Show the status of Windows Subsystem for Linux.

--update [Options]
    If no options are specified, the WSL 2 kernel will be updated
    to the latest version.

    Options:
        --rollback
            Revert to the previous version of the WSL 2 kernel.

Arguments for managing distributions in Windows Subsystem for Linux:
--export <Distro> <FileName>
    Exports the distribution to a tar file.
    The filename can be - for standard output.

--import <Distro> <InstallLocation> <FileName> [Options]
    Imports the specified tar file as a new distribution.
    The filename can be - for standard input.

    Options:
        --version <Version>
            Specifies the version to use for the new distribution.

--list, -l [Options]
    Lists distributions.

    Options:
        --all
            List all distributions, including distributions that are
            currently being installed or uninstalled.

        --running
            List only distributions that are currently running.

        --quiet, -q
            Only show distribution names.

        --verbose, -v
            Show detailed information about all distributions.

        --online, -o
            Displays a list of available distributions for install with 'wsl --install'.

--set-default, -s <Distro>
    Sets the distribution as the default.

--set-version <Distro> <Version>
    Changes the version of the specified distribution.

--terminate, -t <Distro>
    Terminates the specified distribution.

--unregister <Distro>
    Unregisters the distribution and deletes the root filesystem.

--mount <Disk>
    Attaches and mounts a physical disk in all WSL2 distributions.

    Options:
        --bare
            Attach the disk to WSL2, but don't mount it.

        --type <Type>
            Filesystem to use when mounting a disk, if not specified defaults to ext4.

        --options <Options>
            Additional mount options.

        --partition <Index>
            Index of the partition to mount, if not specified defaults to the whole disk.

--unmount [Disk]
    Unmounts and detaches a disk from all WSL2 distributions.
    Unmounts and detaches all disks if called without argument.`

but another command
PS C:\Users\Administrator> wsl --set-default-version
A version number could not be parsed.
“wsl --set-default-version”works fine, but when I add the version number, it can't recognize the version parameter
Diagnostic Logs
No response

Thanks for reporting this @MakesYT.
What exactly command are you running ? The correct syntaxes would be:

wsl --set-default-version 2

Or

wsl --set-default-version 1

Thanks for reporting this @MakesYT.
What exactly command are you running ? The correct syntaxes would be:

wsl --set-default-version 2

Or

wsl --set-default-version 1

both but only the “wsl --set-default-version 1” is working
when running the “wsl --set-default-version 2” returns command help

Oh I know what's happening @MakesYT:  You're on a Windows server build, and Windows server doesn't support WSL2, that's why you're getting this error.
We recently added WSL2 support to Windows Server, but at the moment it's only available on the insider preview builds.

Oh I know what's happening @MakesYT:  You're on a Windows server build, and Windows server doesn't support WSL2, that's why you're getting this error.
We recently added WSL2 support to Windows Server, but at the moment it's only available on the insider preview builds.

How soon will WSL 2 be available in the official release of Windows Server？


Update LICENSE

Fixes #153.  I need this fixed in order to use this internally for something

@PProfizi could you please cut a new minor release so that I can pull this change with pip?

@koubaa Yes, will do!

@koubaa Done, 0.2.5 is now online on PyPI.


after remount poll intervel is not working

i am setting pollintervel in  query but when i visited some other coment and mutate something and after return to the pollintervel componenet  then pollintervel is not working.
kindly help me out on this.
Regards
GM Chaturvedi

@gmchaturvedi1 this should be fixed via https://github.com/apollostack/apollo-client/pull/568
can you update to apollo-client 0.4.13 and see if this still exists?

thanks now its working


Request: control microphone (eg. mute)

Would be awesome to have the ability to mute the microphone.
Currently I either have to do it via GUI (fiddly) or have access to the laptop keyboard and hit an awkward key combo. There's also no quick/easy way to check if it's muted within Windows.
Thanks

Hi, I have a project that utilizes AudioDeviceCmdlets to do exactly what you are suggesting. The project (Mewt)  interfaces with a physical button and an RGB LED via microcontrollers (Arduino, MicroBit) for the control and status feedback.
https://github.com/dakota-mewt/mewt

Would be awesome to have the ability to mute the microphone.

It should be possible with the following command
Set-AudioDevice -RecordingMute $true # Sets the default recording device's mute state to the given <bool>


Alerting change file

Hello,
I've ELK and Beats plugin (auditbeat) for monitoring files and directories and works fine. Now integrate Elastalert, but dont have clarity for create rules for auditbeat index. Someone have any example, please.
Thanks.

Do you know what you want to alert on?

Hello,
yes, i'm alerting with email notification. I've some test rule (ssh, process) with logstash-* index and works fine, but auditbeat i've a little confusion .
thanks


add api endpoints and models for definition page

@miltontony Please review

@miltontony Ready for review

👍 🍰

👍

@miltontony Updated. . . . Please have a look.


feat(fastify): Added support for 2.x and 3.x

refs 52086

[x] add more tests e.g. for hooks
[x] fix ci tests
[x] try npm version name spaces again
[ ] afterwards: improve installations of major versions for fastify
[x] expect(deps['raw-body']).to.exist; clarify
[x] does logging work?
[x] do a manual round trip test
[x] code quality check

Rdy for review 👍

Please also add a CHANGELOG entry.


server/server: Watch OverrideHooksDirPath for hook updates

This avoids:

Hook loaded from /usr/share/containers/oci/hooks.d/abc.json.
Hook overridden /etc/containers/oci/hooks.d/abc.json.
User touches /usr/share/containers/oci/hooks.d/abc.json, which triggers CRI-O to update the hook, overriding the /etc/containers/oci/hooks.d/abc.json entry.

With this pull-request, /etc/containers/oci/hooks.d entries always override /usr/share/containers/oci/hooks.d entries.  I've also added documentation for this behavior.
An outstanding hole is if, instead of the touch in step 3 above, the user had removed /usr/share/containers/oci/hooks.d/abc.json.  I think the ideal behavior there would be attempting to reload the hook from /usr/share/containers/oci/hooks.d/abc.json and only removing the hook if it was unlisted in both locations.  But I've left that particular issue alone in this pull-request.
Spun off from this comment.  Discussed in that comment but not implemented here: I no longer monitor /usr/share/containers/oci/hooks.d.  Users (who don't read the new docs) might expect crio to notice changes there which were not masked by /etc/containers/oci/hooks.d entries, but I didn't have time to add the HookParams property discussed there.
The directory change is a breaking change for folks relying on the current logic.  But it's currently only in v1.10.0-beta.1, so if we're going to break the current logic, now's the time :).
CC @runcom.

Can we watch both locations?
If I am running cri-o and I install a new OCI Hook which drops its config in the /usr/share location, I would want CRI-O to pick it up.

Can we watch both locations?

Id you just add both, you get the /usr/shate-potentially-overriding-/etc issue outlines in my initial post here.  To fix that while watching both dirs, you need to track the source-dir for each hook you load.  That's possible, but would take more time than I have at the moment.  In the meantime, only watching /etc is easy to write, easy to understand, and forward-compatible with futue, improved implementations.

Couldn't we only see if the file changed in /usr and then stat if the same file exists in /etc, and do nothing

Couldn't we only see if the file changed in /usr and then stat if the same file exists in /etc, and do nothing

That's a good idea.  The extra stat call shouldn't be a performance isssue for these low-churn directories.

@wking Any update on this one?

I've rebased this onto master and taken a stab at watching both directories with 2eb689689 → 3b1abbc4b.  I think the new commit will work, but we don't have much in the way of Bats tests for this behavior, so I'm not sure.  If anyone has time to kick the tires (or ideally, file PRs with more thorough Bats tests), that would be great.
Longer term, I think the hook handling would benefit by being pulled out into its own library.  I see that libpod has done that for at least some of the hook handling.  But with both this repo and libpod having root-level vendor directories, neither seems like a good choice for an actual library (intended for external consumption) in the absence of some kind of double-vendor pruning.  For more on the issues with vendor in library repositories, see opencontainers/image-spec#528 and opencontainers/image-spec#532.  Do folks have plans for how they see this working?

I've pushed 3b1abbc4b2f → b06116bb7, which makes Travis happy, although I still think the Travis tests here are a bit thin.  I'm much more comfortable with the Travis tests in #1517, although it doesn't have the watched-directory change from this PR.  If folks want solid tests for this behavior, it's probably best to look at #1517 first, get that landed, and then I'll rebase this PR onto the new master and add more robust Go tests for a watched directory stack.

libpod has landed the hooks package from #1517, and I've rerolled #1517 to vendor that package from libpod.  That means any further improvements to hook handling will need to go in through libpod, so I'm closing this PR.


Manual approval required for workflow run<PHONE_NUMBER>: Release t0rn refs/tags/v1.12.8-rc.0

Please approve runtime upgrade with github release t0rn v1.12.8-rc.0
Runtime upgrade dry run output:
💈 Script started at 1844802 block in t0rn chain

🐡 Running with dryrun flag!

🐙 checking out v1.12.8-rc.0...
✅ tag checked out

🔎 making sure runtime version got updated...
✅ runtime versions updated

🫧 check WASM artifact...
🔢 WASM blake2_256 hash: 0x299e2209ae36046f741e5ba4fbc3d0330d1648c944e451cc4ad3853b97897f71
🔢 WASM blake2_256 hash fetched from release: 0x299e2209ae36046f741e5ba4fbc3d0330d1648c944e451cc4ad3853b97897f71
✅ WASM blake2_256 hash is matching
⚙ set_code runtime upgrade... dry
✅ runtime upgrade executed... dry

Workflow is pending manual review.
URL: https://github.com/t3rn/t3rn/actions/runs/4830041375
Required approvers: [AwesomeIbex MaciejBaj chiefbiiko petscheit palozano]
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.

Workflow cancelled, closing issue.


Error: NoOutboundPeerWithSufficientBalance

I don't understand this, no matter which channel I rebalance, it always comes up with this message. Does anyone have an idea?
err:
  - 404
  - NoOutboundPeerWithSufficientBalance

what's the exact command you are trying?
you have local balance with the peer?

I try for test:
bos --node <MY_NODE_NAME> rebalance --in <PEER1> --out <PEER2> --max-fee-rate 1
peer1: remote 90000 Sats and local 0 Sats
peer2: remote 5335 Sats and local 91000 Sats

If you are putting out it means the rebalance goes out that peer, meaning the payment spends funds you have in local balance with that peer
If the local balance is zero, it cannot pay out that peer and in to the other peer, so it will fail

Yes, but the error also occurs when I try with peers that have both local and remote balance.

ah ok, maybe the amount is too small, rebalance is not meant for very small amounts but you can also try specifying an amount

Ok. And when is the amount too small? Is there any rule?

50k would be the minimum

Ok, one last question before I go any further. Do I have to have a channel that contains more than 50k Sats on both sides?

the outbound side should have 50k and the inbound side should have remote balance of 50k, since you are paying the funds from out into in

Okay, thanks for the clarification!
I think then we can close the Issue, since it is a user error and not a program error ;)

I'm afraid I'll have to ask for help again. I thought I understood what the "outbound" and "inbound" capacity was all about. Now when I try to rebalance with BOS, the error still occurs:

I finally have enough Outbound Balance... or not?

There are some hidden balance elements like commitment tx fee and reserve amount
In general I wouldn't use rebalance for very small amounts, for that I would use bos send instead and send to your own public key specifying in and out, there is no limit there


Merging missing commits in open-power/ipl

In OpenBMC 1050 branch for some unavoidable reasons we have to create a mirror of open-power/ipl repo under ibm-openbmc. But that was a temporary solution and ultimately we need to move back to open-power/ipl in 1060 branch. This commit merges the missing/exclusive commits from ibm-openbmc/ipl repo into the open-power/ipl repo so that we can move back to original open-power/ipl repo in OpenBMC 1060 branch.
Missign commits which are merged are:
8c2272cc5a9030acc459e0ccb3f5e561511d344b from ibm-openbmc/ipl-1050 033bf30ce7a906e08d96790434174f706f607fb4 from ibm-openbmc/ipl-1050 (This one was ported to 1020 and 1030 as well)
The commits which were already availbale in open-power/ipl-main are: ec7d067c7dec06f61d92d186a23e9e8fe1ee4c99 from ibm-openbmc/ipl-1020 6a4a7696a94c06e34fece077236861d291df8508 from ibm-openbmc/ipl-1020 9e84ef27c631457f829166b383c64c9d90c792d4 from ibm-openbmc/ipl-1020 (Actually it combines the above two)
4882ca795c0e69b606860b79cc91d03f834ec92e from ibm-openbmc/ipl-1020
The changes are built without any error after merging the missing commits (PFA the build screenshot)

The commits which were already available is shown in the second screen shot

Signed-off-by: Swarnendu Roy Chowdhury<EMAIL_ADDRESS>

I thought you would create multiple commits. Each commit for one missing commit. That way it would be easier to understand and operate. For example, reverting a commit or something like that. Is there any challenge doing that?

I thought you would create multiple commits. Each commit for one missing commit. That way it would be easier to understand and operate. For example, reverting a commit or something like that. Is there any challenge doing that?

Actually it was practically only two commits which need to be merged that too not so big in changes. So I thought rather than creating multiple ones it is better to create one and mentions the details. In that way it would save time of rebuilding and re checking the changes merged.

I thought you would create multiple commits. Each commit for one missing commit. That way it would be easier to understand and operate. For example, reverting a commit or something like that. Is there any challenge doing that?

Actually it was practically only two commits which need to be merged that too not so big in changes. So I thought rather than creating multiple ones it is better to create one and mentions the details. In that way it would save time of rebuilding and re checking the changes merged.
libipl/p10/ipl0.C contains the changes from @devenrao and libphal/libphal.H along with libphal/phal_pdbg.C contain yours one @deepakala-k

you should cherry pick them rather than manually merging changes, we will loose history and commit message details


C++: Fix use-after-cast bug in SimpleRangeAnalysis

This should fix the FP reported at https://discuss.lgtm.com/t/c-false-positive-comparison-result-is-always-the-same/1857.

It turns out there was a difference in PointlessComparison.expected. The new alert looks correct to me, but I'm not sure if it's correct for the right reasons. Maybe a CPP-Differences job would be in order.

The failing test shows that we're losing good results in some cases. This is probably because we're not modelling that it's fine to cast to wider types. I'll see if that's easily fixed.

I've fixed the test failure in a way that should also fix other Conversion issues, and I've started a CPP-Differences job at https://jenkins.internal.semmle.com/job/Query-Changes/job/CPP-Differences/534/

CPP-Differences job showed some unexpected changes that I'm still trying to understand.

Most of the unexpected CPP-Differences changes were caused by some missing calls to getUnspecifiedType in my new code. I've fixed that and started a new CPP-Differences job.

The CPP-Differences results are in:
=== Overall changes (new / fixed) ===

                                                                           20 / 6

=== Changes per project (new / fixed) ===

linux                                                                      19 / 5
jdk8u                                                                       0 / 1
git                                                                         1 / 0

=== Changes per query (new / fixed) ===

PointlessComparison.ql                                                     11 / 4
SnprintfOverflow.ql                                                         9 / 0
ComparisonWithCancelingSubExpr.ql                                           0 / 1
StackAddressEscapes.ql                                                      0 / 1

The four "fixed" alerts in PointlessComparison.ql all look like instances of the use-after-cast bug that this PR is intended to fix. The "new" alerts from that query seem to arise because we now consider some enums to be >= 0. I don't know if it's the case for all enums, but at least it gives these 11 new alerts on defensive code in the Linux kernel. In any case, I think the "fixed" alerts are more obviously wrong than the "new" alerts.
There are some new results for SnprintfOverflow.ql in Linux. To me, they look similar to other code that tends to be flagged by this query.
@kevinbackhouse and @geoffw0, what do you think about these changes?

I just checked, and both Clang and GCC (in C mode) use unsigned int as the underlying type for enums unless there's a constant with negative value, in which case they use int. That means the new alerts about enums are technically correct although they rely on implementation-defined behaviour.

The CPP-Differences results are in:

The diff results look good to me except:

as you noted, there are some new results about range checks on enums that I'm not convinced about.
linux / drivers / gpu / drm / i915 / intel_dp.c line 1481 'Potentially overflowing call to snprintf' looks like a FP to me (I don't think this is high priority stuff, certainly shouldn't block this PR).

That means the new alerts about enums are technically correct although they rely on implementation-defined behaviour.

What will the situation be on LGTM?  If my code is written exclusively for a platform that uses signed int for enums, I'm not going to be interested in these alerts just because LGTM perhaps happens to use unsigned int.

I don't think we can justify those enum alerts based on platform-specific choices of signed vs. unsigned. Do you think we can justify them by saying that if x has type enum t, then the value of x can be assumed to be one of the constants in enum t? I'm not too confident that we can justify the alerts like that. The alerts I've seen are just flagging defensive code, not pointing to anything that's wrong.
If you agree, then I'll find some way to make the alerts go away. They appeared because the library changed, but I think the library is fine. We could exclude them syntactically in the query just by excluding all results that involve an enum access.

I think I've restored the previous behaviour for enums now. It turns out there was already an exclusion rule for them, but I had broken it.

Then LGTM.
I'm not confident enough to merge this without a second opinion (or a new run of the differences job) - because this isn't an area of code I know well.

I'll start a CPP-Differences job

There's a CPP-Differences job running here: https://jenkins.internal.semmle.com/job/Query-Changes/job/CPP-Differences/543

Diff LGTM.

Two test failures though:
[2019-04-08T11:23:53.535Z]     ql/cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/lowerBound.ql: Test failure (Expected output does not match)
[2019-04-08T11:23:53.535Z]     ql/cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/upperBound.ql: Test failure (Expected output does not match)

The changes on this branch have affected SnprintfOverflow.ql in ways I don't yet understand. I'll try to get to the bottom of it.

The central question in this PR is this: when we learn the result of a comparison like e1 >= e2, what do we learn about e1? If x is a 16-bit short, then we don't learn anything useful about x from (char)x >= 2. We do learn something useful from (int)x >= 2. The SnprintfOverflow query started acting up because I changed the library to say we don't learn anything useful from (unsigned int)x >= (unsigned int)2 either. Essentially we learn that either x is either negative or at least 2, but that's not helpful for the range analysis. With my latest change, I've restored the old behaviour of saying we learn that x is at least 2. That's technically wrong, but it's at least no more wrong than current master.

I'm also running https://jenkins.internal.semmle.com/job/Query-Changes/job/CPP-Differences/547 to make sure there are no more unforeseen consequences.

I've pushed a small commit, hopefully the last one, to fix a comment in a test that I forgot to update.
The CPP-Differences job produced 0 changes, which is surprising to me, but the new lines in upperBound.expected still look right, so I assume this PR still fixes the original problem. I think I got the parameters right in the CPP-Differences job. Here's the diff between the two SHAs from those parameters.


Lookup types do not work well with type guards

TypeScript Version:  2.1.4
Consider this simple property getter function (defined in What's New of TypeScript 2.1):
function prop<T, K extends keyof T>(obj: T, key: K): T[K] {
    return obj[key];
}

I would expect that prop(foo, "bar") works the same way foo.bar does. However, if the type of the property is narrowed using type guards, the prop function stops working as expected:
interface Foo {
    bar?: number;
}

function quux(foo: Foo) {
    if (foo.bar) {
        let baz: number = prop(foo, "bar"); // error TS2322: Type 'number | undefined' is not assignable to type 'number'.
    }
}

Expected behavior: The code should compile just fine.
Actual behavior: Compilation ends with a type error.

Tentatively a duplicate of #10065 - type guards affect properties, but don't synthesize the kinds of on-the-fly new types that would be required to identify this in the general case. But here we should be ending up at the same symbol and resolving this correctly

@ahejlsberg any cheap fix possible?

@RyanCavanaugh Nothing cheap comes to mind. The real fix would be to address the issue in #10065 (which would fix several other issues as well).


Actions.handler should return first enabled action, not first action if enabled.

The current code in Actions.handler uses Actions.maybeFind to find the closest action, and then returns a closure or not, depending on whether or not the action returns true for isEnabled.  What it should probably do instead is to look for an action the way that maybeFind does, but only look for actions that are enabled.
The subtle difference is that the current implementation will stop looking for actions once it finds one, regardless of whether it is enabled. The proposed solution would only stop looking if it finds an action that is enabled.

cc @LongCatIsLooong @HansMuller

I think that the current approach is better than looking for an enabled action ancestor.  When a descendant Actions widget includes an Action that's also defined by an ancestor, I don't think the descendant Action should lose the ability to disable the operation it encapsulates.

Good point. Closing this.


Highlight graph cursor offset in grid and vice versa

Make it easier to see where on the grid a given graph point is and vice versa.

This is now implemented.


it's better if you can provide where can we import the DataStore

it's better if you can provide where can we import the "DataStore"
otherwise user have to search that

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e60dd174-3b79-db95-a665-991bcf3b9579
Version Independent ID: 70221e45-7afe-7f3c-1fcd-373d7e92eb6b
Content: Trigger Azure Machine Learning pipelines - Azure Machine Learning
Content Source: articles/machine-learning/how-to-trigger-published-pipeline.md
Service: machine-learning
Sub-service: mlops
GitHub Login: @Blackmist
Microsoft Alias: larryfr

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@ccyjava thanks for the feedback. I may need more clarity to better understand your question. Are you trying to create a scheduled pipeline that will be triggered by file change on a datastore?  what do you mean by "import the datastore"?

I'm going to close this issue for now due to no response but let us know if you are still having a problem and we can answer your question and/or reopen the issue.
Thanks!
#please-close


Incorrect legend for Grade/Tonnage model

Fixed in https://github.com/DARPA-CRITICALMAAS/minmod-dashboard/commit/5e6b54953f54042de31ffb448cb53373cce45fa3 commit


API resources section contains Asgardeo references

Describe the issue:

API resources section contains Asgardeo references

How to reproduce:

1.Go to the console
2.Go to API resources section and try to create a resouce
Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Not reproducible in the latest (pre-alpha) pack.