Guest Access to AWS AppSync does not work properly

Describe the bug
As describe in the documentation it should be possible to grant guest access to the AppSync GraphQL API. Unfortunately, I was not able to configure this feature due to the error message: "User is not signed in, please sign in to use this API." via iOS SDK, even when I did every step as recommend in the docs. I choose "connected with AWS IAM controls" which will allow me to select Allow unauthenticated logins. I also double checked the console and under settings in my AppSync service the default configuration for authorization mode the default behaviour is ALLOW.
To Reproduce
Steps to reproduce the behavior:

Initialise new project with "amplify init"
Add api with GraphQL endpoint "amplify add api" go through each step and make sure that you choose "connected with AWS IAM controls" and later on "Allow unauthenticated logins". This will configure an api and auth service.

Expected behavior
I'm expecting to be able to grant access to users with guest role.
Screenshots
None
Desktop (please complete the following information):

OS: In my case its iOS, but I thinks it relates to any other platform too.

Smartphone (please complete the following information):

None

Additional context
It make amplify and unable for mobile clients. It must be possible to grant guest access to any application.
Sample code
None

@borisdering Please tell us which version of the CLI are you using, since in the latest release we added support for multiple authorization modes, for AppSync, which is covered here: https://aws-amplify.github.io/docs/cli-toolchain/graphql?sdk=ios
By using the @auth(rules:[{allow:public, provider: iam}]) directive on a type, the CLI will generate the appropriate IAM policies for you that will be deployed together with the API.
I'm closing the issue as the question is answered, but if something new comes up, feel free to reopen it.

Hi @attilah, first of all thank you for the fast response. I personally don't use any GraphQL Transform, because I couldn't design an appropriate schema with directives, I had to create custom resolvers instead. Anyways long story short, I did tried your solution but the cli framework did respond with a syntax error. I did found a nice solution on how to grant access to guests. I did attach a inline policy to the unauthenticated role:
{     "Version": "2012-10-17",     "Statement": [         {             "Effect": "Allow",             "Action": [                 "appsync:GraphQL"             ],             "Resource": [                 "arn:aws:appsync:<REGION_ID>:<ACCOUNT_ID>:apis/<API_KEY>/types/Query/*"             ]         }     ] }
and set the authentication mode in AppSync to IAM. Im currently working with iOS so I had to change the credentials provider to the mobile client, like this:
`            // You can choose the directory in which AppSync stores its persistent cache databases
let cache = try AWSAppSyncCacheConfiguration()
        // AppSync configuration & client initialization
        let config = try AWSAppSyncServiceConfig()
        let appSyncConfig = try AWSAppSyncClientConfiguration(appSyncServiceConfig: config,
                                                              credentialsProvider: AWSMobileClient.sharedInstance(),
                                                              cacheConfiguration: cache)
        self.client = try AWSAppSyncClient(appSyncConfig: appSyncConfig)
        // Set id as the cache key for objects. See architecture section for details
        self.client?.apolloClient?.cacheKeyForObject = { $0["id"] }

also make sure if anyone reads this, you need to change the authmode in your aws configuration file to
"AppSync": {
"Default": {
"ApiUrl": "API_URL",
"Region": "REGION_ID",
"AuthMode": "AWS_IAM"
}
},
`
By the way, my current version is 1.12.0.


[GEARPUMP-218] add shaded library as transitive dependencies

Current coverage is 71.11% (diff: 100%)

Merging #92 into master will increase coverage by 2.32%

@@             master        #92   diff @@
==========================================
  Files           186        186
  Lines          5985       5985
  Methods        5464       5464
  Messages          0          0
  Branches        521        521
==========================================
+ Hits           4117       4256   +139
+ Misses         1868       1729   -139
  Partials          0          0

Powered by Codecov. Last update 66017ab...bd4c672

+1


Safely and easily support CI checks on PRs from repo forks

This PR with no code changes was failing many required CI checks, which lead us to find that our repository is not set up well to accept PRs from repository forks, which is a very common contribution pattern in open-source.
This issue shed some light on other discussions, and led to this article from the GitHub Security Lab. There is some guidance there that I am trying to digest and map onto our repository's needs.
I am definitely not the best person to reason about the security implications of our GH Actions nor about how to reconfigure them to support external fork PRs in a safe manner, I just want to kick off the discussion so we can align on a course of action. I believe setting this up now will pay dividends in the future.

I should also say that I'm totally fine with the outcome of this discussion being to add a note to our CONTRIBUTING.md docs saying due to constraints we only accept PRs from permission-granted contributors.

Yes I think we need to whitelist thru github

I certainly don't want it that any joe shmo who opens a pr we've never encountered before gets access to CI, which is why by default github does that, and I think that is great

Yes I think we need to whitelist thru github

I totally support this, just don't want our seat count to explode. If there's a whitelist that doesn't add seats I'd love that.

no we whitelist CI this is a github built in ci doesnt run today unless you approve the contributor

you can read more here: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories

they dont need to be in the org


[Docs] Add documentation for the Firestore plugin

Documentation Link
We need to add documentation on how to use the Firestore plugin
This should be available at: https://docs.appsmith.com/core-concepts/connecting-to-databases/querying-firestore

Hi, also need this docs.
I don't understand field "Service Account Credentials"
, which credentials? To database secret like this? => DkgrgAHstvLju30XXXXXXzmdJ6mujXXdbT5LRX or what instead?
Please help :)
Happy New Year BTW :D

Hi, also need this docs.
I don't understand field "Service Account Credentials"
, which credentials? To database secret like this? => DkgrgAHstvLju30XXXXXXzmdJ6mujXXdbT5LRX or what instead?
Please help :)
Happy New Year BTW :D

@serwer20 Happy New Year to you too!
Appsmith does indeed support Firestore and we have a few people with apps connecting to their Firestore instance. Unfortunately, as you pointed out, the docs weren't ready. I opened a PR for this just some time ago, which you can check out / review.
For your specific question though, the service account credentials is the content of the JSON file that is generated when we click on "Generate new private key" in your Firestore project settings. The whole JSON contents of this file is to be pasted in this field on Appsmith. The document in the linked PR contains additional details as well.

@serwer20 Happy New Year to you too!
Appsmith does indeed support Firestore and we have a few people with apps connecting to their Firestore instance. Unfortunately, as you pointed out, the docs weren't ready. I opened a PR for this just some time ago, which you can check out / review.
For your specific question though, the service account credentials is the content of the JSON file that is generated when we click on "Generate new private key" in your Firestore project settings. The whole JSON contents of this file is to be pasted in this field on Appsmith. The document in the linked PR contains additional details as well.

This is now live at the URL posted in the issue description.

This is now live at the URL posted in the issue description.


NIFI-9605: Docker Images  for OpenShift

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The provided Docker images are not easily usable in OpenShift with its built-in security restrictions. To directly use those images you have to create specific Security Context Constraints (SCC) and give further capabilities to Service Accounts just to be able to have initContainers changing file ownership inside the images.
The new container image definitions, based on ubi8/OpenJDK11, are fully compatible with OpenShift and have the right files and directories ownership from the start, allowing to use them without relaxing security constraints. That makes them usable by standard users who would not normally have the rights to create those SCCs.
Images definitions are provided for nifi, nifi-registry and nifi-toolkit, in folders named openshift alongside the dockerhub folders in their respective location.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
Signed-off-by: Guillaume Moutier<EMAIL_ADDRESS>

Hello.  Thanks for contributing.  First we will need a JIRA to exist and the commit messsage should link to it.  The JIRA ideally will lay out the overall goal/intent (which appears to be to provide an openshift friendly image for NiFi).  Also, it looks like there are various versions/mechanisms for setting versions.  You'll want everything in maven version land set to 1.16.0-SNAPSHOT which is the current main and then where there need to be hardcoded version references in Dockerfiles and such presumably it would be 1.16.0.  I also see references to much older version of nifi in here.  Best to start fresh with what this would target which at present is 1.16.  So you can/should remove references to older versions of nifi and any associated special handling.

Thanks a lot! I've created the Jira issue and changed the title to point to it.
I'll make the changes for 1.16.0, no problem, but are there nightly builds or whatever so that I can test, or do I have to build them myself?

Hard-coded versions bumped to 1.16.0 as suggested.

@guimou There are no nightlies, so you can test with a release version such as 1.15.3. I know that complicates things with the hardcoded version in files such as DockerImage.txt. I'm actually thinking about a new approach so that we don't need those files / hardcoded versions in the code base.
To @joewitt's point though, the idea here is that we are always preparing the source code to be ready for the next release, so if someone downloads the source tarball for 1.16.0 (when it is ready) and builds the Docker images, it will default to fetching those artifacts. During development / testing on main, that does make it trickier. For this PR, if it is working with 1.15.3, I would say that is good for verifying everything is in good order

@kevdoran Perfect, thanks a lot. In this case everything has already been tested with 1.15.2 as part of this project, both as a simple Kustomize configuration and with the Open Data Hub operator. Built images are available here: Nifi, Registry and Toolkit.
As 1.15.3 was only a bug fix over 1.15.2 I would say it's pretty much ok, although I will surely find some time to rebuild images with 1.15.3 in the next few days. However it won't change anything for the PR as everything is already set to 1.16.0.

Hi @guimou, thanks for the PR! It looks like there's a lot of duplication here, particularly with the sh directories. It would be better from a maintenance perspective to not have the scripts duplicated and instead enhance the build scripts to be able to select different Dockerfiles. Did you have a goal in mind with duplicating the entire build directory?

Hi @dmnewber!
The idea of creating the openshift folders alongside the docker/dockerhub ones (btw naming and structure is not really consistent for those) was to minimize coupling, in the sense that I did not want to "get in the way" (I was not even sure the project would be interested by this). In my idea, people would be able to build the images themselves, or we could have an external automated build process generating these specific/custom images without putting too much burden on the project. Having their definitions integrated into the NiFi code would make it easier to find them though, even if people had to build themselves.
Now, if the project thinks it's a good idea and is keen to integrate those images, I could change the approach and extend the maven builds with openshift profiles that would source their files from the already existing docker/dockerhub folders, as well as from the openshift one, but that would then only contain its specific files. The thing I'm struggling with though is that the way the different images are built (nifi, registry, toolkit) is not really consistent (for registry for example it does not seem to be a maven build at all, whereas in nifi you find two different things, dockerhub and dockermaven...), so I'm not sure how I should do this...
Another less intrusive option would be to simply add instructions/script in the parent folder and build directly from there. Like this, the build context would authorize to pick files from diffent subfolders and minimize duplication. This would also allow to provide only "recipes" for OpenShift, but not integrate the full build and have to determine where to put and how to name those images.
I'm open to any suggestion, whatever is the simple for the project and the users!

Hi @guimou @dmnewber,
This is a nice contribution and good discussion. I agree with you @guimou that there are real benefits to making NiFi images easier to deploy directly on OpenShift. I also agree with @dmnewber that it would be best not to duplicate the entire directory of files. While it may leave things more decoupled, it does increase the maintenance burden, as any any improvements to the default NiFi image would not also have to be done in more places (as we would probably want those same enhancements everywhere). We already have this problem today across docker hub and dockermaven variants, and plan to try to combine those so that they only differ one way, which is how the assembly artifacts are provided.
I've started collecting ideas for how to improve our project structure for Docker images produced from the NiFi repository here, and I've added some of the goals of this PR to that list: https://cwiki.apache.org/confluence/display/NIFI/NiFi+Docker+Container+Improvements
If this is not urgent, I would suggest we tackle some of those goals, such as image build consolidation and then figure out how to incorporate base image variants as part of that, to take another look at this. I haven't looked at the PR closely yet, but aside from basing on ubi8/OpenJDK11, are there any other significant changes from the current NiFi Dockerfile?

Hey @kevdoran! This is definitely not an urgent thing. And if it's the occasion to rethink other aspects of the container images building process that may be a good occasion and I'd be happy to help. Meanwhile I can keep a separate project (in my repo or another Red Hat repo) only for the OpenShift building recipes, not keeping the whole NiFi tree.
Apart from the source image and the installed packages that differ a little bit because it's not the same base distro, the changes are all related to the way the NiFi files are installed: ownership (for OpenShift GID has to be set to zero to support arbitrary UID) and access writes. In fact this could even be applied to the way the images are currently built without that many consequences (although it would require some more reflexion).

Thanks @guimou. Given that we want to offer a variety of base images and platform architectures, I think the first step would be restructuring things such that NiFi image is built in two steps: first to prep the base image, and then the nifi-specific bits. Ideally the nifi-bits would be the same regardless of the base image.
Once we get a better handle on that, it should be easier to tackle some of the other wish-list items for docker improvements as there will be fewer files to edit and maintain.
Keep an eye out on the wiki/dev mailing list/jira/PRs for opportunities to get involved if you are interested and available!


The meaning of allowGlobalDebugging

I don't quite understand the meaning of allowGlobalDebugging in launch.json, as the latest commit uses allowGlobalDebugging = false in R Debug Function launch item and launching any of the test R scripts does not hit any breakpoint and browser() call. Am I missing something?
Explicit calling main() in the end of objects.R will make launch hit browser() but not any breakpoints.

In https://github.com/ManuelHentschel/VSCode-R-Debugger/pull/38 I made some changes to the debug config.
The (intended) effect of allowGlobalDebugging did not change, but it was not working properly before.
If allowGlobalDebugging = false the debugger is supposed to run the specified file or function and then exit. This is particularly useful when debugging a single main() function, since usually there are no interesting variables in the global workspace afterwards anyways.
If allowGlobalDebugging = true the debugger keeps running after executing a function or file and allows interactive use of the debug console, similar to a regular terminal window.
Especially the case allowGlobalDebugging = false was somewhat hard to get working properly, since the communication between vscode and R is very async due to the somewhat unpredictable behaviour of stdio, which made it hard to differentiate if e.g. a prompt was shown before or after running main(). In my test cases it works as expected now, but let me know if you have any problems or I missed any combinations of debugMode, breakpoints, and console input.

Thanks for the detailed explanation!
I'm trying the latest commit of vscDebugger and VSCode-R-Debugger by launching at objects.R, but the following error occurs:
Starting R session...
rDelimiter0: <v\s\c>
rDelimiter1: </v\s\c>
rPrompt: <#v\s\c>
rContinue: <##v\s\c>
rStartup: <v\s\c\R\STARTUP>
rLibraryNotFound: <v\s\c\LIBRARY\NOT\FOUND>
rAppend:  ### <v\s\c\COMMAND>
cwd: /Users/ken/Workspaces/github/VSCode-R-Debugger/test/R
rPath: /usr/local/bin/R
rArgs: --ess --quiet --interactive --no-save
library: vscDebugger
overwrite print(): true
overwrite cat(): true
overwrite source(): true
allow global debugging: false
set breakpoints in packages: false
program: /Users/ken/Workspaces/github/VSCode-R-Debugger/test/R/objects.R
main function: main()
Error in vscDebugger::.vsc.prepGlobalEnv(overwritePrint = TRUE, overwriteCat = TRUE,  :
  unused argument (debugGlobal = FALSE)

Looks like there's typo somewhere?

Are you sure you're on the latest version? The argument debugGlobal should not be used by the debugger anymore: https://github.com/ManuelHentschel/VSCode-R-Debugger/blob/develop/src/debugRuntime.ts#L216
And using ctrl+shift+f I can't even find the word anywhere in my code...

Sorry, my mistake, just found my git pull does not succeed. I redo git pull and everything looks good now.


UI goes black when using a non-cubemap environment texture.

The whole user interface of t3 goes 99.9% black if I connect a non-cubemap texture to the environment operator.
This doesn't create a crash but I haven't found a way to get out of this state, only restarting t3 works.
This happens in all versions of t3 I tried, from 3.3 standalone to the latest dev build of today.
Steps to reproduce:
Create a SetEnvironment operator.
Connect a texture2d with a frog to it.
Click on the Environment node or hover over it with the mouse.
Enjoy the darkness :-)
See attached screenshot - if you turn up brightness, you can see some outlines of the nodes.
Please complete the following information):

OS: Windows
Version: Latest dev
Graphics card and resolution: Geforce GTX 840M, 2GB VRAM, 1920x1080
Acer Laptop, 16 GB RAM. Windows 10.
All latest updates and drivers installed.

this can easily be solved .. by following the input parameters required by SetEnvironment .. which is .. data type CubeMap

which can easily be created by using the operator TextureToCubeMap2 .. which accepts a Texture2d input ..

It shouldn't bomb the application requiring a restart to continue. The solution is perhaps a message telling the user they need the TextureToCubeMap or the proper image format or just not working at all but allowing you to continue. I believe I've also encountered this whilst using the proper nodes but changing textures or possibly using a file that was 16bit or just not a format that Tooll supports.
I didn't see documentation for SetEnvironment supported image formats but thought .DDS was probably ideal since it's what the default resource is. I haven't found a good way to convert .EXR and .HDR into a working .DDS file.

yeh everyone encountered it in super old unupdated versions .. but it does CLEARLY ask for a CubeMap ..

The bug with the steps I reported above is still there in the latest dev version of today.
For me it is a bug if something brings an application into a state from which the user can't recover without closing and restarting the application.
Since other software like vvvv creates the cube map on the fly or at worst shows a wrong reflection, I   don't see why you go to such a length to deny the issue?

I think this was a very annoying issue that happened frequently and required a fix.
In the upcoming version v3.4 [SetEnvironment] will check if the incoming texture format is cubemap and will print warning level if this this is not case:

Although not a good as converting the texture on the fly, its a first fix to circumvent the black UI issue.
A better longer term approach would be to have a new [FallbackCubeTexture] operator that does the conversion automatically if the format doesn't match.


Corrected case on includeSubDomains

This is to correctly match rfc 6797 section 6.1.2
Which states:
6.1.2.  The includeSubDomains Directive
The OPTIONAL "includeSubDomains" directive is a valueless directive
which, if present (i.e., it is "asserted"), signals the UA that the
HSTS Policy applies to this HSTS Host as well as any subdomains of
the host's domain name.

Good catch. Thanks!

Are you planning to publish a new npm module soon?

Yes--will do very soon.

Done! Just published<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I'm building a list of contributors for a new Helmet.js website. Do you have a name and/or website you want me to use to credit you?
I'll also credit you for #4.


CLI: Ctrl+D should detach

Ctrl+D should detach from the running task without killing it.

This might be unreasonably difficult to do since we would have to read from stdin while printing the logs from docker/kubernetes


Handle ReplicaNotAvailable like LeaderNotAvailable when initializing a client

According to the logs, this was the cause of the kafka_sysv_mq_producer was not restarting during our testing. Apparently we already found that this caused issues when using LeaderNotAvailable (#144), and apparently ReplicaNotAvailable can happen to. We should handle them similarly
@Shopify/kafka

:+1:

@dalehamel FYI


v3-beta7: No support for Ionic Package?

I couldn't find any command that are equivalent to the v2 Package commans:

ionic package list
ionic package build PLATFORM_TAG --profile PROFILE_TAG
ionic package download BUILD_ID

https://github.com/driftyco/ionic-cli/blob/v3/docs/ionic.md mentions build, download, list and info but these don't exist or do different stuff.

@piotrowski We just needed to regenerate the documentation. I've fixed that issue. As for package, we're going to wait to implement it in the CLI. The package service itself also has work that needs to be done.
Thanks for reporting the issue!

Adding a few sentences about what is and what isn't supported in the v3 beta CLIs to the README would be great for us playing with it - especially if the docs are not always up to date.

@piotrowski Great idea. I will be updating the readme!


Refactor Component Link Teaser

Description
Refactor Component Link Teaser to allow for DRUPAL API data to get processed/transformed through data_service. This will allow the component to consume a basic object type.
What was completed

[x]   Update component to use the new transformed data
[x]   Create data_service to transform DRUPAL API and return new object
[x]   Update Unit tests
[x]   Update demo page
[x]   Add to storybook

Screenshots

Unfortunately the unit tests are not going to pass due to other errors.


Check if there's any missing dependencies for heron

Reported in #1165, reflectasm is missing due to the upgrade of kryo version. We need to do a complete dependency check for Heron to avoid potential issues.

@nlu90 - is this done?

@kramasamy yeah, I compared the jars in WORKSPACE file with the old heron repo. Most of the used jars remain the same.


Logging in causes an exception

expected hash for #[](key : string), not string (exception)
Not quite sure why this happens, will investigate further.

e7d3884


Adding new javascript APIs

There are new javascript APIs and some new data- attribute
Check the code please

Hi, we need to create an issue first to discuss features. Each Pull Request should have a single concern and this seems to have more than one concern.
If you want to help, please take a look in these links:

Contributing Guidelines
Current plan for impress.js


Add additional methods to manipulate Items

Additional player methods for Items:

drop

Drops an item from the player's inventory specified by name and amount. Amount is optional; should be 1 by default.

dropin

Drops an item from the player's inventory specified by name and amount into a container Object. Amount is optional; should be 1 by default.

wear

Allows a player to wear an item in their inventory specified by name.

takewear

Allows a player to wear an item in the current room specified by name.

undress

Allows a player to take off an item they are wearing specified by name, placing it into their inventory.

undressdrop

Allows a player to take off an item they are wearing specified by name, dropping it into the current room.

Edits to make to the Item methods:

Implement item amounts to take/drop methods

If multiple items of the same name, description, and weight exist, an additional 'amount' argument should be able to manipulate each of them.

Drop command implemented


SPARKC-396: Upgrade to Spark 2.0.0-preview

Removed Twitter demo because there is no spark-streaming-twitter package available anymore
Removed Akka Actor demo becaues there is no support for such streams anymore
Bring back Kafka project and make it compile
Update several classes to use our Logging instead of Spark Logging because Spark Logging became private
Update few components and tests to make them work with Spark 2.0.0
Fix Spark SQL - temporarily
Update plugins and Scala version

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with success

2.10 vs 2.11 issues it looks like :(
14:10:28 [error] /jenkins_data/jenkins/workspace/DSE_SparkCassandraConnector_2.10_PullRequest_Builder/spark-cassandra-connector/src/it/scala/com/datastax/spark/connector/repl/CassandraRDDReplSpec.scala:24: too many arguments for method runInterpreter: (input: String)String
14:10:28 [error]     val output = runInterpreter(
14:10:28 [error]                                ^
14:10:37 [error] one error found
14:10:37 [error] (spark-cassandra-connector/it:c

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with success

and assembly getting confused about netty-all vs subcomponents
{code}
[error] (spark-cassandra-connector/*:assembly) deduplicate: different file contents found in the following:
[error] /home/travis/.ivy2/cache/io.netty/netty-all/jars/netty-all-4.0.29.Final.jar:io/netty/bootstrap/AbstractBootstrap$1.class
[error] /home/travis/.ivy2/cache/io.netty/netty-transport/jars/netty-transport-4.0.33.Final.jar:io/netty/bootstrap/AbstractBootstrap$1.class
{code}

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.10 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.11 finished with failure

Build against Scala 2.10 finished with success

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with success

Build against Scala 2.11 finished with success

lgtm +1

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with success


rychrr portofolio_page issue

Rychrr Portofolio Page issue

[ ] Good job so far but there are a few issues to work on
[ ] I think it would be better if you reduce the with of the get in touch button to fit the Figma template.

Resolved  Thanks!


TextGen WebUI

Are there any plans to support models loaded in TextGen WebUI?

Hi, not at the moment. This is more of a baseline released to the community in hopes someone will fork it and create something better. My current focus is elsewhere.


Update config to reflect RESTBase changes

Incorporate changes from
https://github.com/wikimedia/restbase/pull/843
Add some options that will be needed later.

How can a brand new PR have merge conflicts?

How can a brand new PR have merge conflicts?

Oh, I missed one conflicting upstream change. Rebased now.


Update error message when project with same name already exists

Steps to reproduce:

Import a project from a database with the default name
Try to import the same database project again to the same location

Expected:
Project should be successfully created, possibly with an incremented counter appended to the folder name, or an error message that says that a project with the same name exists at that location
Actual:
This error message didn't get updated after the change was made to create a new folder when creating a project from a db. The existing .sqlproj is actually at /Users/kisantia/SqlProjects/DatabaseProjectskeep_AdventureWorks2017/

@kisantia should we have an item for auto increment separartely (thats not included in the PR right?)? @anjalia might have some cycles to help with that one.

@udeeshagautam opened up #11601 to track this. It would be great is @anjalia has time to get this added :)


Reporting how often people have taught

Report who has taught how often in downloadable CSV format.  Only remaining issue is the use of 'award.person.airport.country' in the template has to be wrapped with 'if' because 'award.person.airport' may not exist, so we sometimes get 'xxx-unset-variable-xxx' - haven't been able to find a filter that'll catch this and display '-' instead.

@gvwilson still WIP?

Closed via #552.


MAPREDUCE-7429 Application log link is not accessible via TimelineServer WebUI in IPV6 scenario

Application log link is not accessible via Timelineserver Web UI under IPV6 scenario owing to no ipv6 normalization for IP address.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 30s

trunk passed

+1 :green_heart:
compile
25m 19s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
22m 34s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 50s

trunk passed

+1 :green_heart:
mvnsite
2m 37s

trunk passed

-1 :x:
javadoc
1m  9s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 41s

trunk passed

+1 :green_heart:
shadedclient
22m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
24m 18s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
24m 18s

the patch passed

+1 :green_heart:
compile
22m 22s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
22m 22s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m  6s
/results-checkstyle-root.txt
root: The patch generated 1 new + 25 unchanged - 0 fixed = 26 total (was 25)

+1 :green_heart:
mvnsite
2m 34s

the patch passed

-1 :x:
javadoc
1m  3s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 55s

the patch passed

+1 :green_heart:
shadedclient
22m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 18s

hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 52s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

242m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 671a9b9df9f0 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 602842366b0a1f8e8e6a615ace60cfef9cb8734f

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/1/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 18s

Maven dependency ordering for branch

-1 :x:
mvninstall
25m 41s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
26m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
22m  0s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 41s

trunk passed

+1 :green_heart:
mvnsite
2m 38s

trunk passed

-1 :x:
javadoc
1m  8s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 28s

trunk passed

+1 :green_heart:
shadedclient
22m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 43s

the patch passed

+1 :green_heart:
compile
25m 35s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
25m 35s

the patch passed

+1 :green_heart:
compile
22m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
22m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 36s
/results-checkstyle-root.txt
root: The patch generated 2 new + 33 unchanged - 0 fixed = 35 total (was 33)

+1 :green_heart:
mvnsite
2m 37s

the patch passed

-1 :x:
javadoc
1m  3s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 47s

the patch passed

+1 :green_heart:
shadedclient
23m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 21s

hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 48s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

242m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a9e87bd18427 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b1a0e4fe3e940f10f20d2393fdd559332862887c

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/2/testReport/

Max. process+thread count
2105 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Daniel-009497 Thank you very much for your contribution, but we need to fix checkstyle issue.
Don't worry about javadoc issue, it seems to be a problem with jdk.
@slfan1989   Thanks for your remind,
All the compile issues are fixed except for javadoc ,  Pls help to merge once everything is done.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 58s

trunk passed

+1 :green_heart:
compile
24m 44s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m 59s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 43s

trunk passed

+1 :green_heart:
mvnsite
2m 40s

trunk passed

-1 :x:
javadoc
1m 10s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 35s

trunk passed

+1 :green_heart:
shadedclient
22m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 47s

the patch passed

+1 :green_heart:
compile
23m 52s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
23m 52s

the patch passed

+1 :green_heart:
compile
22m 24s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
22m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 43s
/results-checkstyle-root.txt
root: The patch generated 2 new + 33 unchanged - 0 fixed = 35 total (was 33)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

-1 :x:
javadoc
1m  7s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
5m  3s

the patch passed

+1 :green_heart:
shadedclient
23m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 49s

hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 35s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

241m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5b45a6eb4343 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2bfbf9c6c05dfce130de307b3756c755efc71a2b

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/3/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 26s

trunk passed

+1 :green_heart:
compile
25m 18s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m 19s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 44s

trunk passed

+1 :green_heart:
mvnsite
2m 41s

trunk passed

-1 :x:
javadoc
1m  8s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
5m  9s

trunk passed

+1 :green_heart:
shadedclient
22m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
24m 42s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
24m 42s

the patch passed

+1 :green_heart:
compile
21m 15s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
21m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 31s
/results-checkstyle-root.txt
root: The patch generated 1 new + 33 unchanged - 0 fixed = 34 total (was 33)

+1 :green_heart:
mvnsite
2m 41s

the patch passed

-1 :x:
javadoc
1m 11s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 51s

the patch passed

+1 :green_heart:
shadedclient
22m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 21s

hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 48s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

242m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 93b5d76dd322 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e1567242e829c26d96ff786f75a5e31efc8cad7a

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/4/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 29s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 38s

trunk passed

+1 :green_heart:
compile
23m 12s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 23s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

-1 :x:
javadoc
1m 14s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 30s

trunk passed

+1 :green_heart:
shadedclient
21m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 36s

the patch passed

+1 :green_heart:
compile
22m 23s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
22m 23s

the patch passed

+1 :green_heart:
compile
20m 15s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
20m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 33s

the patch passed

+1 :green_heart:
mvnsite
2m 40s

the patch passed

-1 :x:
javadoc
1m  6s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 43s

the patch passed

+1 :green_heart:
shadedclient
21m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 25s

hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 48s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

232m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5a11e656e915 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e8eba067aa4915792273e42181d5da05b83538bd

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/5/testReport/

Max. process+thread count
1278 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Daniel-009497 Thank you very much for your contribution, but we need to wait for MAPREDUCE-7428, MAPREDUCE-7428 brought some junt test issues, it is being processed. We need @goiri to help review again.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 44s

trunk passed

+1 :green_heart:
compile
24m 20s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 43s

trunk passed

-1 :x:
javadoc
1m 13s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 37s

trunk passed

+1 :green_heart:
shadedclient
21m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 41s

the patch passed

+1 :green_heart:
compile
24m  9s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
24m  9s

the patch passed

+1 :green_heart:
compile
22m 29s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
22m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 34s
/results-checkstyle-root.txt
root: The patch generated 36 new + 46 unchanged - 0 fixed = 82 total (was 46)

+1 :green_heart:
mvnsite
2m 33s

the patch passed

-1 :x:
javadoc
1m  2s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
5m 21s

the patch passed

+1 :green_heart:
shadedclient
22m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 26s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 41s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

237m 26s

Reason
Tests

Failed junit tests
hadoop.net.TestNetUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 428c2efd68f5 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e5ec449c27476ad2259f6c578358a30f033ed72c

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/6/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 37s

trunk passed

+1 :green_heart:
compile
23m  6s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 30s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 46s

trunk passed

+1 :green_heart:
mvnsite
2m 44s

trunk passed

-1 :x:
javadoc
1m 15s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 52s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 35s

trunk passed

+1 :green_heart:
shadedclient
21m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
22m 14s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
22m 14s

the patch passed

+1 :green_heart:
compile
20m 25s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
20m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 35s
/results-checkstyle-root.txt
root: The patch generated 36 new + 45 unchanged - 0 fixed = 81 total (was 45)

+1 :green_heart:
mvnsite
2m 39s

the patch passed

-1 :x:
javadoc
1m  7s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 52s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 44s

the patch passed

+1 :green_heart:
shadedclient
21m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 21s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 47s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

232m  8s

Reason
Tests

Failed junit tests
hadoop.net.TestNetUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b1314362804d 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 56eb9ec46673498a20179f0ba82d2442e9f02c4b

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/8/testReport/

Max. process+thread count
3152 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  7s

trunk passed

+1 :green_heart:
compile
25m 51s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m 40s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 33s

trunk passed

+1 :green_heart:
mvnsite
2m 38s

trunk passed

-1 :x:
javadoc
1m  9s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 36s

trunk passed

+1 :green_heart:
shadedclient
23m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 36s

the patch passed

+1 :green_heart:
compile
22m 44s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
22m 44s

the patch passed

+1 :green_heart:
compile
21m 39s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
21m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 49s
/results-checkstyle-root.txt
root: The patch generated 36 new + 46 unchanged - 0 fixed = 82 total (was 46)

+1 :green_heart:
mvnsite
2m 35s

the patch passed

-1 :x:
javadoc
0m 58s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
2m  6s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 49s

the patch passed

+1 :green_heart:
shadedclient
23m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 43s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 50s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

242m  3s

Reason
Tests

Failed junit tests
hadoop.net.TestNetUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ace99f698f9a 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bd10b58c439db021aef1377fa945bb9f3b27b968

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/7/testReport/

Max. process+thread count
1278 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 59s

trunk passed

+1 :green_heart:
compile
23m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

-1 :x:
javadoc
1m 16s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 34s

trunk passed

+1 :green_heart:
shadedclient
21m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 38s

the patch passed

+1 :green_heart:
compile
22m 19s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
22m 19s

the patch passed

+1 :green_heart:
compile
20m 28s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
20m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 37s
/results-checkstyle-root.txt
root: The patch generated 36 new + 46 unchanged - 0 fixed = 82 total (was 46)

+1 :green_heart:
mvnsite
2m 41s

the patch passed

-1 :x:
javadoc
1m  6s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 45s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 43s

the patch passed

+1 :green_heart:
shadedclient
21m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m  9s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
6m  2s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

232m 28s

Reason
Tests

Failed junit tests
hadoop.net.TestNetUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 29be43d6968f 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07973a07912148fb2a31cbcc7f09814ee4cf44f8

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/9/testReport/

Max. process+thread count
1657 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri
Lots of thanks for your review.
All the review comments have been fiexed as you mentioned.
Pls help to merge if everything is OK.
And could you pls help to review the rest pending PR I raised if you got time.

I found that this change is in the yarn module, but the title is mapreduce.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 29s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 45s

trunk passed

+1 :green_heart:
compile
23m 10s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m  6s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 47s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

-1 :x:
javadoc
1m 14s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 42s

trunk passed

+1 :green_heart:
shadedclient
21m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 38s

the patch passed

+1 :green_heart:
compile
22m 13s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
22m 13s

the patch passed

+1 :green_heart:
compile
20m 30s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
20m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 38s
/results-checkstyle-root.txt
root: The patch generated 36 new + 46 unchanged - 0 fixed = 82 total (was 46)

+1 :green_heart:
mvnsite
2m 42s

the patch passed

-1 :x:
javadoc
1m  6s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 50s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
4m 41s

the patch passed

+1 :green_heart:
shadedclient
21m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 27s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
5m 49s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
asflicense
1m  4s

The patch does not generate ASF License warnings.

232m 59s

Reason
Tests

Failed junit tests
hadoop.net.TestNetUtils

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5236

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1643625fca5d 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 85aa87771df96a2216e5db99fac9f68223c1c4c6

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/10/testReport/

Max. process+thread count
1278 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5236/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Why Does Jaspr Use a Different Syntax from Flutter?

I am curious about why Jaspr employs a distinct syntax compared to Flutter. For example, React Native for Web (https://necolas.github.io/react-native-web/docs/) uses React DOM and hence the HTML DOM for object manipulation, yet it does not introduce a separate syntax. Would it be feasible to directly translate standard Flutter code into HTML/CSS?

Hey, I am working on trying to add this right now. Trying to make Jaspr more approachable for Flutter devs. I think the creator just meant for Jaspr to be able to use Dart to interact with the DOM and include SSR and SSG.  I'm trying to build wrappers around Material UI with Jaspr right now for a UI Component Library:
https://github.com/cybertheory/caspr/tree/main
Fairly new project, would love some help getting it set up and developing!

Take a look at the UI library: https://github.com/schultek/jaspr/tree/main/packages/jaspr/lib/src/ui

Awesome! It's a good start!

I don't think the components in the UI library have any styling attached to it, but you can build a material type UI library on top of the existing one. May save you some work.

I don't think the components in the UI library have any styling attached to it, but you can build a material type UI library on top of the existing one. May save you some work.

Yup definetly 😀

Jaspr employs a distinct syntax compared to Flutter.

What exact syntax are you referring to? Jaspr is built to resemble Flutters syntax very closely. It has some differences (like Iterable<Component> instead of Component in build methods), the reasoning is documented here: https://docs.page/schultek/jaspr/jaspr-vs-flutter-web#differences-between-jaspr-and-flutter

Would it be feasible to directly translate standard Flutter code into HTML/CSS?

Manually sure, automatically probably not in the near future (its just not a priority right now).
Generally it is important to understand that Flutters Widgets will never be directly compatible with Jasprs Components (part of the reason I chose not to name it also Widgets to make it clear). Its just technically not doable and also not a goal of Jaspr.
As others pointed out there will be (and already are in the works) more high level ui component libraries for jaspr, some of which might be designed to more closely resemble flutters standard widgets. But I don't have a specific timeline for this.

I was thinking about a mechanism with two options: one for compiling into HTML/CSS code and the other for a typical Canvas Kit compilation. The idea is to use the identical Flutter code, yet the output would vary based on the selected rendering method.

Seems nice to have in theory, but its nice t feasible in practice. I mean Flutter has the html renderer already you can use, but it does not produce nice html at all.
But as I said compatibility with flutter is a non goal of jaspr. The compromises on quality and web best practices would be too great.

I think that's a good desicion! It gives Jaspr flexibility to become its own powerful framework. I have been using it on my personal site and it's surprising easy to pick up. I like how you can just transfer in your HTML/CSS know how and there's already a huge knowledge base for that. I think being compatible with Flutter should not be a goal, but Flutter interoperability on the client is definitely a cool feature! I think jaspr allows for this.
Also the UI component libraries should completely remove the need for low level web design concepts.


E2E Scale Tests - Attach persistent volumes at user configured scale

Aim: Have a working test code which will attach/detach/delete the volumes at user configured scale.
The following actions will be performed as part of this test.

Attach volumes to multiple pods on multiple nodes.

Based on number of volumes identify how many pods are to be created on a single node.
How many volumes needs to be attached to each pod on a single node.

Detach volumes on the nodes.
Delete the volumes.

Internally reviewed and approved by the team - https://github.com/vmware/kubernetes/pull/324

PR is out for review - https://github.com/kubernetes/kubernetes/pull/54018 few days back.

PR is merged. Closing the issue.


Run SAC in pyspark, and got "Cannot find active or default SparkSession in the current context"

I ran a sql query in pyspark, and got the following exception:
>>> spark.sql("create table tmp_case_q (key INT, value STRING)")
18/03/05 20:20:20 WARN SparkCatalogEventTracker:  Caught exception during parsing catalog event
java.lang.IllegalStateException: Cannot find active or default SparkSession in the current context
	at com.hortonworks.spark.atlas.utils.SparkUtils$.sparkSession(SparkUtils.scala:35)
	at com.hortonworks.spark.atlas.utils.SparkUtils$.getExternalCatalog(SparkUtils.scala:87)
	at com.hortonworks.spark.atlas.sql.SparkCatalogEventTracker$$anonfun$eventProcess$2.apply(SparkCatalogEventTracker.scala:120)
	at com.hortonworks.spark.atlas.sql.SparkCatalogEventTracker$$anonfun$eventProcess$2.apply(SparkCatalogEventTracker.scala:96)
	at scala.Option.foreach(Option.scala:257)
	at com.hortonworks.spark.atlas.sql.SparkCatalogEventTracker.eventProcess(SparkCatalogEventTracker.scala:96)
	at com.hortonworks.spark.atlas.sql.AbstractService$$anon$1.run(AbstractService.scala:24)
DataFrame[]

The exception is from here. @jerryshao Could you please help to look at this issue? Thanks.
cc: @dongjoon-hyun

Resolved in HWX spark side.

Same Problem,How to resolve that problem; Whats the meaning of 'HWX spark side'?

@weiqingy I meet the same problem, can you tell me how to resolve the problem, thank you

@weiqingy   I meet the same problem, can you tell me how to resolve the problem, thank you

@SimonWan1029 HWX(stands for hortonworks).
@weiqingy instead of pyspark use spark-shell or spark-submit(use spark-session of java or scala),
as SAC code is written in scala and unable to fetch active or default SparkSession from python since up to my knowledge it is able to search only in java environment(JVM).


Create New TLS Certificates for Testing

We have a tls folder that contains certificates and keys needed for testing tls in the driver. Some were added since forking from node-postgres and some are still old. We need to be able to test mutual TLS in the driver, but right now we don't have the correct certificates for it. We ought to have everything needed for someone to get configured without having to make any new certificates or keys on their own, so this would be CA keys and certificates for signing client and server certificates (maybe this could just be one CA that signs both). We need client key/certificate and server key/certificate. They should all be in PEM format. When creating we need to keep in mind the subjects needed for certificate verification in both server and mutual mode.

ideally we should dynamically create these certifiactes/CA instead of storing them in the repo unless there are some specially needs.
sql-go client has some examples on how to create all these certificates you might be interested in.
https://github.com/vertica/vertica-sql-go/blob/master/resources/tests/genCerts.sh

ideally we should dynamically create these certifiactes/CA instead of storing them in the repo unless there are some specially needs.
sql-go client has some examples on how to create all these certificates you might be interested in. https://github.com/vertica/vertica-sql-go/blob/master/resources/tests/genCerts.sh

I like that. I would prefer that approach. I'll look into modifying that genCerts script for vertica-nodejs to cover this issue. I'm not sure if what is being generated right now would support mTLS


Optimization for asyncio queue? only make a single AsyncQueueListener

Hey @ZhuYuJin  - you recently contributed in this area of the asyncio logging queue. I was reviewing this code a little more and it seemed to me that it might be unnecessary to create separate instances of these objects for each logger object:
AsyncQueueListener ->
   QueueHandler ->
       queue.Queue

As far as I can tell there's no harm in having a single AsyncQueueListener handle all the loggers within that process. Or am I maybe missing something? I wonder if you could perhaps try out this branch and let me know what you think.
It wouldn't be a major speed boost, but may some minor memory savings if there are a lot of loggers configured.

Hi, Preston. Could we use a boolean variable to switch between multiple listeners and a single listener. I have to submit logs to local agent with UDP socket, which may cause backlog of log in a single listener. Besides, a single listener may cause significant lock competition while we have too many logger objects.

Thanks @ZhuYuJin. I'm planning to study this area more because I don't understand it very well. However what you said makes sense suggests there would be minimal value to this change.
I am curious about your use case though, if you can provide any more info. Are your application processes only sending logging messages over UDP to an agent/server, and that agent is the one using concurrent-log-handler? Or are the app processes both writing with concurrent-log-handler and also sending message over UDP as a separate thing?

Our application uses concurrent log handler which writes local log files, and a remote log handler which sends logging messages over UDP to an agent. The agent will gather logs and send archive to remote server.
Besides, the application invokes function setup_logging_queues to write log in separate threads for each handler.


Update kubernetes version on AWS cloud

Signed-off-by: Artem Belov<EMAIL_ADDRESS>Description
Update EKS node image to kubernetes 1.14 (latest)
Motivation and Context

How Has This Been Tested?

[x] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@artem-belov Please rebase on master so we can see if it passes or not


IRGen: The partial application forwarder needs to cast { swift.refcounted* } to swift.refcounted* for AnyObject types on linux

SR-6547

@swift-ci Please smoke test


Payment takeover screen

UX Flow
• User logs in
• See Choose a Plan page
• Sees Add Payment page


Analysis Performance Degradation on Personal Edition

Occasionally certain binaries will exhibit poor analysis performance times on Binary Ninja Personal whereas Commercial would appear to analyze without issue.

There was an issue related to imported function symbol definitions. There were potential cases where the symbol definition could kickoff a cycle of redundant function updates, hindering analysis.
This issue is fixed on 1.3.2039-dev.


add a composing dataset to pack sequences of tokens

Stack from ghstack (oldest at bottom):

-> #125
#124
#123

messed up ghstack, making new PRs


The project repository takes a lot of disk space

Currently there is an issue with using submodules that points at subprojects kept as a branches in the islet-asset repository.
The main repository takes about 83GB disk space, it’s because git duplicates the islet-asset repo for each submodule.
$ du -sh .git/modules/third-party/*
4.9G    .git/modules/third-party/android-kernel
4.9G    .git/modules/third-party/cca-rmm-acs
4.9G    .git/modules/third-party/gki-build
4.9G    .git/modules/third-party/kvmtool
4.9G    .git/modules/third-party/kvmtool-rim-measurer
4.9G    .git/modules/third-party/kvm-unit-tests
4.9G    .git/modules/third-party/mbedtls
4.9G    .git/modules/third-party/nw-linux
4.9G    .git/modules/third-party/optee-build
4.9G    .git/modules/third-party/realm-linux
4.9G    .git/modules/third-party/tf-a
4.9G    .git/modules/third-party/tf-a-rss
4.9G    .git/modules/third-party/tf-a-tests
4.9G    .git/modules/third-party/tf-rmm

This is also the reason why the initialization process (./scripts/init.sh) takes a lot of time. I think that if we’re going to make the project more user friendly for potential open source contributors, this should be fixed somehow. The easiest way seems to be keeping these subprojects as separate git repositories. But, I’m not a git/GitHub guru on that matter, and maybe there is a better solution.

Good to report this issue with the visualization! I also agree that this huge disk consumption issue should be resolved.
We've avoided this issue by using only a minimum dependency on ci (e.g., using init_sh_min.sh instead of init.sh), yet another solution seems to be needed.


Epochs

Any way to specify no. of epochs while training?

hello @rajvijay68 for which package?

For any model, say DecisionTreeClassifier, or Regressor ...

We have to check each package implementation. As far as I saw there's no epoch on decision tree classifier, so in this case it needs to be added


Add +pic variants to common/packages.yaml to enable position-independent code (PIC) compiler flag where needed

This issue appears to have been included in the 1.4.0 release but it only affects platforms without pixman installed. I suspect this issue hasn't come up because many of our targets already have pixman and preventing spack from attempting to build it. Without this flag we will get the following error during spack install.
/usr/bin/ld: .libs/pixman-implementation.o: relocation R_X86_64_TPOFF32 against `fast_path_cache' can not be used when making a shared object; recompile with -fPIC

After making this change locally I have observed the following concretize output for pixman, fontconfig, and freetype.
^pixman<EMAIL_ADDRESS>build_system=autotools arch=linux-ubuntu22.04-
^freetype<EMAIL_ADDRESS>build_system=autotools arch=linux-ubuntu22.04-icelake
^fontconfig<EMAIL_ADDRESS>build_system=autotools arch=linux-ubuntu22.04-icelake

@eap Can you address the comments in the PR review please? I think it's ok to merge the +pic flags, but we don't want those versions hardcoded. Thanks

A different way to fix this to edit the site/compilers.yaml and add the cc flags manually:
example (includes -O3)
flags:
      cflags: -O3 -fPIC
      cxxflags: -O3 -fPIC
      cppflags: -O3 -fPIC

The last time I edited this I was still struggling to find all packages that needed the variant. I'm not sure if I should attempt to continue or not.

A different way to fix this to edit the site/compilers.yaml and add the cc flags manually:
example (includes -O3)
flags:
      cflags: -O3 -fPIC
      cxxflags: -O3 -fPIC
      cppflags: -O3 -fPIC

The last time I edited this I was still struggling to find all packages that needed the variant. I'm not sure if I should attempt to continue or not.

It's fine to close it. We can fix it later if it comes up again. I don't want to throw blanket -fPIC flags over everything using the default compiler flags.

Sounds good - closing now. We can revisit later if needed. For the moment I've only had this issue on one platform. If it comes up elsewhere we can reopen.


phoniebox plays only mp3

Hello,
maybe somebody can help me. I have installed phoniebox with spotify. after some trouble to get music out off the speaker i have the next problem. Spotify links will not be played and from the locale files phoniebox plays only mp3. Anyone here who can help me?
OS Distribution
Raspbian
Description
Raspbian GNU/Linux 9.9 (stretch)
Release
9.9
Codename
stretch
Phoniebox Setup
Version
1.1.9
Edition
Plus edition (feat. Spotify integration)
Mopidy Server Status
active (running) since Thu 2019-06-13 23:40:54 CEST; 18min ago

Hi @Spuckiii
if I remember correctly, you have had at least one Phoniebox install running perfectly. What you describe is so weird that I don't know how to investigate this over the forum. Did you get it fixed? Did a reinstall fix it? If so, please add your solution here and close the thread.
Sorry to be of such little help.

Hi @Spuckiii
there are two scripts in the scripts/helperscripts directory:

scripts/helperscripts/CreateSampleAudiofoldersStreams.sh

This will create sample folders with different kinds of media. One folder will be created that is called ZZZ-AudioFormatsTest and contains a number of different audio files. Please have a look if these are not played at all, if only the mp3 file is played or if some are played and others not.
You can remove the sample folders and files with this script:

scripts/helperscripts/DeleteSampleAudiofoldersStreams.sh

Silence is golden? :)


Readme needs updated.

The link to the developer program overview (found at https://developer.microsoft.com/en-us/games/xbox/docs/xboxlive/get-started/developer-program-overview) is a 404.

Thanks for letting us know, @killa78. We have created a service request to update the Readme.  In the meantime, here is the correct link to the developer program overview: https://docs.microsoft.com/en-us/windows/uwp/xbox-live/developer-program-overview

Thanks, fixed


URL used in request should use '?' before first parameter and not '&'

The URL syntax is:
http://server:5000/viaroute&start=52.501477212889,13.402305318941&dest=52.507994749658,13.412168925167&z=15&output=json&jsonp=showResultsRoute&geomformat=cmp&instructions=true

but instead the more standardized syntax should be used, where the first parameter follows after a question mark. Ampersand should be only used afterwards.
http://server:5000/viaroute?start=52.501477212889,13.402305318941&dest=52.507994749658,13.412168925167&z=15&output=json&jsonp=showResultsRoute&geomformat=cmp&instructions=true

i would agree.


Export MQTT_PORT & VDB_PORT by default as environment variables

When you deploy K3D and the containerized runtime and apps, for successfully running the integration tests, the ports of MQTT broker and Vehicle Data Broker that are exposed from the cluster, have to be exported as environment variables.
The documentation for this is easy to miss and hard to find when looking for it.
Proposal:

Export MQTT_PORT=31883and VDB_PORT=30555 automatically, e.g. as part of a task
Update the documentation accordingly

Acceptance criteria:

Developer can run integration test of containerized app without having to configure anything additionally/explictly

Plan is to deprecate K3D -> will not provide fix


recaptcha is in french

my google account is set up to be in the french language, and that is the account i created my API key under. it appears that the recaptchas served by the API key I am using are always in french, even though my device is in the US English locale. Any ideas about this?

The recaptcha classes don't specify a locale and Google decides to use your account locale. I will make it request to display in a configurable locale

This issue is resolved in version 2.0.0.


Update helm files

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

None

/kind cleanup
/lgtm
/approve

/triage accepted


Fixes #1155: intersection of CropBox and MediaBox

The CropBox of the PDF in #1155 is much bigger than its MediaBox. As per the spec, it should be reduced to the intersection of the two.

@pdfjsbot test

good to go after cropBox fixes


Fix test on non-English locales

Fix test on non-English locales. If user has LC_ALL set, it takes precedence over empty LANG

thanks!

thanks!


Add Terser for Better Optimisation (read full description)

Terser is a code optimization engine that allows you to do more than you can with standard Webpack (which uses a lightweight version of Terser) and thus causes pages to load faster. It is a maintained fork of Uglify-ES with additions like name compression etc.
Webpack uses terser by default but by using the plugin you get way more control, for example, you can remove console.log calls or whatever you want. You can also tell it to optimize some stuff further as Webpack does not enable all by default.
Using the Terser plugin also improves Split-Chunk Optimisation as Webpack does not do this by default (as to keep build lengths down, usually takes Terser 15 secs to fully optimize split-chunks)

If we do need more control, we might reconsider this, for now it's not needed.
Before opening any other pull request I ask you to discuss any changes with us in discord.


fix bugs with the save pdf

Only the first page it is in A4 size
If someone choose to press "cancel" in the save pdf dialog you get an error.

All bugs fixed


[stable/prometheus-operator] make alert rule annotations consistent

Is your feature request related to a problem? Please describe.
Yes, it is difficult to create templates for formatting the alerts (e.g. into a slack message) as the annotations are inconsistent between different alerts.
Some alerts have the annotations e.g. here

message

And others have e.g. here

description
summary

Describe the solution you'd like
Personally I like the summary and description approach. Where the summary has a static  human readable title (that can then be grouped by) and the longer description that has the details of what has offended and how. I believe that this way is more flexible.
But I'd be happy with anything that is consistent.
Describe alternatives you've considered
I have tried to get my noobish template-foo on and make an advanced template that handles either case, but short of duplicating the whole thing wrapped by some if statements, I haven't had much luck. When I try default or coalesce functions they don't seem to exist.

I think you raise a good point and it would be useful to address it.
@gregbacchus The alerts are sourced from two different upstream repositories, outlined here: https://github.com/helm/charts/tree/master/stable/prometheus-operator/hack, and are merged into the repository using the scripts. I think the best option would be to ask the two repos to converge on a standard way of labelling the alerts, but as that may be a longer-term goal, I think it would be feasible to amend the scripts so that labels are standardized in this repo. What do you think?
cc: @paskal

I think preparing PR to change things on etcd side for consistency and then importing changes there is the right way to do that.

Yea sounds like a good idea. I think many of the contributors are the same, so it should make sense