could you offer  the lib file ?

could you offer  the lib file directly be called by the C++ project which can omit the step to compile it? Indeed tried many times also modified the part of the code but still a lot of errors which led to unsuccessfully compile

Hi @joefung thank you for your suggestion. I will check if there is an easy way to do it and I will let you updated about this.

For Linux users, after CMake procedure, a libbgs.so is generated and then copied to /usr/local/lib/lib. The include files of package_bgs is copied to /usr/local/include/package_bgs.
For Windows users, a lib file called bgs.lib is also generated.
To do this, please follow the instructions in the README_CMAKE_USERS.txt file.

I'm working on Ubuntu14.04, Opencv 3.2.0.
After the instruction of
I have encountered the same question of libbgs.so
As you said above, I have done these:
sudo cp -r package_bgs/ /usr/local/include/ sudo cp libbgs.so /usr/local/lib
But the time I try to python Demo.py
The problem's still there:

Traceback (most recent call last):
File "Demo.py", line 3, in
import libbgs
ImportError: No module named libbgs

Can you give me any suggestion?
Very thank you!


Implent time range and/or daylight-trigger

First of all, thanks for this great blueprint!
Would it be possible to add fields to set the time in which the sensors be active? Like 8pm to 7am?
Best Regards

The easiest way I can think of — using the current blueprints with your desired requirements — is to add an input boolean that is controlled by another automation using time tracking, etc., and use it to pause the automation with pause support built-in.
If you wanted something more integrated into a blueprint than the above, then it would require writing another blueprint with an on/off schedule built-in, since I won't add it to the existing ones. The less complex type of schedule would use a single time range for any day of the week or month, while the more complex type of schedule would allow for any multiples of time ranges for any day of the week or month. It probably makes more sense to keep it to a weekly instead of monthly basis, if support for a more complex schedule were to be added. As for how to implement either type of schedule; I don't know yet, since I've never tried.
Personally I will recommend trying out the automation with pause built-in combined with an input boolean that is controlled by another automation to toggle the boolean on or off depending on the time first, to see if that covers your needs well enough.

Thanks for the quick reply. I'm new to Home Assistant and using it only for a few components which i can't control with my Ikea Dirigera. In addition i have not enough time to write a blueprint or a complex shedule.
I've imported your blueprint with pause, so you mean with boolean an entity right?


Rework anti-tiling

This implements a new anti-tiling method. The UV is moved around a point (UV+0.5). The result is jittered/dithered and less chaotic than the old broken rotation. Obviously no anti-tiling is made for every texture.
I removed 'noise3' and used the textures alpha to blend the domain transitions. This is because the noise blending looked messy when blending two or more of the same texture together.
I also removed normal map rotation as it is redundant because nothing is rotated anymore.
Closes(?) #145
Fixes #201

This is an improvement over the old uv_rotation. And it may help some users with a cheap, psuedo detiling on some textures, so it can close #201.
However, it's not an adequate detiling option so #145 can stay open and be renamed.
v0.8.2 vs this PR
https://github.com/TokisanGames/Terrain3D/assets/632766/e08fbe3d-ad68-40db-8c53-8593ec25cbd7

I removed 'noise3' and used the textures alpha to blend the domain transitions. This is because the noise blending looked messy when blending two or more of the same texture together.

I'm conflicted about this. noise3 is used to add noise to the blending edge of textures. I see that it does strengthen the normals in the textures that are rotated. However removing the noise makes the blending pattern between textures much blocker and far more difficult to blend naturally.
Blending between textures is far more important to me than the rotation feature.
However this does consider the height on the blend more so than before, so some textures like rock through grass do blend better. But other textures very easily turn into squares and are much more difficult to blend without these squares.
Without noise3

With noise3

Perhaps we can keep noise3 and average it into the height with a user settable factor.

Here is the blend with this PR and no noise3

With noise3

Here is both averaged

Here is both added. So far, I think this is the best option. Painting is good and the height of rocks is improved over the main branch. And the rotated textures still has most of its height.

I think added might be the best option.

This is an improvement, so I will add noise3 to the height (unless you want to) and merge in this PR today or tomorrow.

Thanks!


Fix rich text link modal window tabs

Some or all of the 'Internal link | External link | Email link' tabs at the top of the modal disappeared when changing tabs. This was caused by the allow_external_link/allow_email_link context variables not consistently being set across all instances where the tabs were printed.
A new shared_context(request) function has been added that generate these context variables, which can easily be used to add these variables to any context that needs them.

Thanks!


Hard Subtitles not working

The following is the download directory structure from Bilibili
download/
└── s_34641
    └── 359301
        ├── 64
        │   ├── audio.m4s
        │   ├── index.json
        │   └── video.m4s
        ├── id
        │   └── f9171d78e6aa73b2079d15ceb9b5e4f9139cd157.ass
        └── entry.json

For the download results from Bilibili, I found that the downloaded subtitle format was .ass rather than .json
when I run the command
./bilibili_extractor_cli compile download output

✔ Compiled Anime Name EP01!

it worked and didn't show any errors, but when I watched the video the subtitles didn't appear
and when I saw the download directory structure of bilibili changed like this
download/
└── s_34641
    └── 359301
        ├── 64
        │   ├── audio.m4s
        │   ├── index.json
        │   └── video.m4s
        ├── id  (empty)
        │   └──
        └── entry.json
        └── subtitle.ass

Is there a way for the compilation to include subtitles in .ass format in the ID directory combined with video and audio? Thank You

bilibili-extractor should be able use the .ass subtitle without converting it to other formats. I don't know what happened here.
Can you give me the output of ffprobe path/to/output_file?
Can I also ask what anime this is?

the name of the anime that I want to compile is Solo Leveling
Example of the structure
download/
└── s_2097863
    └── 13079919
        ├── 64
        │   ├── audio.m4s
        │   ├── index.json
        │   └── video.m4s
        ├── id
        │   └── f9171d78e6aa73b2079d15ceb9b5e4f9139cd157.ass
        └── entry.json

okay, here is a video when I compile the anime
I am using termux and ffmpeg version 6.1.1
https://github.com/nanashi-1/bilibili-extractor/assets/122751959/df7585e4-b219-4f5b-8855-6549f689c503
I changed this line of code
https://github.com/nanashi-1/bilibili-extractor/blob/7355724b6efa962da09dd69cd9c030639ba5c86b/src/cli/main.rs#L51
by changing it to "id" because I speak Indonesian and compiling the source code
when I watch a video in the SL directory the subtitles don't appear

Do you have access to ffprobe? I want to see if the subtitle is indeed in one of the streams. This is because some players doesn't display subtitles by default.

it turns out I have to select the subtitles first so they appear, I tried using VLC😭, is there a way to make the subtitles appear without selecting them by default? and this is a screenshot from ffprobe By the way, thank you for making this bilibili-extractor very helpful for me, very grateful🙏

I have to make it work by default. I will release a fix in the next update.
By the way, thanks for the contribution.


EVEREST-704 Removed duplication of consts

CHANGE DESCRIPTION
Problem:
EVEREST-704
Short explanation of the problem.
The previous PR was accidentally merged so this is the follow-up PR to address comments
Related pull requests

[link]

Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira

[ ] Is the Jira ticket created and referenced properly?

Tests

[ ] Is an Integration test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (40d9439) 5.52% compared to head (a5cace2) 5.52%.

Files
Patch %
Lines

pkg/monitoring/enable.go
0.00%
3 Missing :warning:

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #243   +/-   ##
=====================================
  Coverage   5.52%   5.52%
=====================================
  Files         13      13
  Lines       2750    2750
=====================================
  Hits         152     152
  Misses      2571    2571
  Partials      27      27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Method called with NIL pointer receiver when using interfaces

What version of Go are you using (go version)?
1.10.1 + 1.10.2
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
linux amd64
What did you do?
Please have a look at the programm below.
I'm just building a simple list using an interface type as parent attribute.
When traversing the list the recursion base test checking this parent attribute against NIL does not work.
The recursion continues, with calling the method on a NIL pointer receiver.
Further investigations shows that all of the following changes would solve the problem:
a) don't use the interface type (Node) for the parent attribute, but the pointer to struct type (*_Node)
b) change the argument type of new from *_Nodeto Node
c) Not using the direct assigment this.parent = p, but the strange construct
      if p == nil {
          this.parent = nil
      } else {
          this.parent = p
      }

This is really a strange behaviour. It seems not to be possible to assign a pointer variable containing nil to an interface variable reflecting nil after the assignment. Instead it points to a pointer pointing to nil which is evaluated with the == nil expression to false.
This is really contra-intuitive.

package main

import (
	"fmt"
)

type Node interface {
	Map(s string) Node
	Process(string) string
}

type _Node struct {
	parent Node
	data   string
}

var _ Node = &_Node{}

func NewNode() Node {
	return (&_Node{}).new(nil, "")
}

func (this *_Node) new(p *_Node, s string) *_Node {
	this.parent = p
	this.data = s
	return this
}

func (this *_Node) Map(s string) Node {
	return (&_Node{}).new(this, s)
}

func (this *_Node) Process(data string) string {
	fmt.Printf("THIS: %+v\n", this)
	if this.parent == nil {
		fmt.Printf("parent :NIL\n")
		return data
	}
	fmt.Printf("recursion %p\n", this.parent)
	return this.parent.Process(data) + "->" + this.data
}

func main() {
	n := NewNode().Map("a").Map("b")
	fmt.Printf("%s\n", n.Process("start"))
}

What did you expect to see?
THIS: &{parent:0xc42000a7c0 data:b}
recursion 0xc42000a7c0
THIS: &{parent:0xc42000a7a0 data:a}
recursion 0xc42000a7a0
THIS: &{parent:<nil> data:}
parent :NIL
start->a->b

What did you see instead?
THIS: &{parent:0xc4200a22a0 data:b}
recursion 0xc4200a22a0
THIS: &{parent:0xc4200a2280 data:a}
recursion 0xc4200a2280
THIS: &{parent:<nil> data:}
recursion 0x0
THIS: <nil>
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x48bdf9]

goroutine 1 [running]:
main.(*_Node).Process(0x0, 0x4c111b, 0x5, 0x1, 0x1)
	/main.go:40 +0x79
main.(*_Node).Process(0xc4200a2280, 0x4c111b, 0x5, 0x1, 0x1)
	/main.go:45 +0x106
main.(*_Node).Process(0xc4200a22a0, 0x4c111b, 0x5, 0x1, 0x1)
	/main.go:45 +0x106
main.(*_Node).Process(0xc4200a22c0, 0x4c111b, 0x5, 0x4d34a0, 0xc4200a22c0)
	/main.go:45 +0x106
main.main()
	/main.go:50 +0xee

See also https://github.com/golang/go/issues/22729 and related proposals.
Unfortunately, there is nothing we can do to make this less confusing in Go 1.

Ok, that's what I expected, but is there at least a possibility to check for a nil pointer (==nil does not work)
to be able to avoid the nil pointer dereference.


Performance issue when sending the log through JAX RS

What
The performance is good when we did the local testing, but when we push to our test environment, there are 5~8 users are doing the requests at the same time, our target server became slow and slow. And revert the logback-logtail as our log dependency, everything backs to normal. 🤣
Why
After doing some research, it was caused by the JAX RS Client.
As we can see the client is a "singleton", it can not deal with massive requests at the same time. It likes our application has one database connection to process the massive user queries.
I suggest:

if the JAX RS is the lib required, then we can use the connection pool to improve the performance.
if the request client can decide by some customized code, like the Spring users may use the Feign or RestTemplate, it will be helpful for these users not bringing the JAX RS and Jersey related dependencies.

some findings: it's better to add the jersey-apache-connector to benefit the connect pool feature from it.
Refer to: http://www.theotherian.com/2013/08/jersey-client-2.0-httpclient-timeouts-max-connections.html

more reference LogglyBatchAppender from org.logback-extensions:logback-ext-loggly.
It's easy to rewrite the getHttpUrlConnection and processEntries methods to customize the request with Authorization and the request body content format.

For what it's worth, Jetty's HTTP Client is quite similar to JAX-RS's and it's supposed to scale very well.


fix: 触发懒加载时，需要同步更新notify内容，更新component监听变更的ns

触发懒加载时，需要同步更新notify内容，更新component监听变更的ns；因为sync也会触发component返回，所以component不需要重新 start，期间两秒的时间足够configComponent变更appconfig
component 依赖 appconfig 的内容更新

Summary by CodeRabbit

Refactor

Improved code readability and consistency in configuration management.

Tests

Enhanced testing for configuration changes.

Documentation

Updated comments for better clarity and understanding of configuration settings.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

11 of 11 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 74.556%

Totals

Change from base Build<PHONE_NUMBER>:
0.09%

Covered Lines:
1301

Relevant Lines:
1745

💛  - Coveralls

Could you assist in including a test case that this pull request resolves?

Could you assist in including a test case that this pull request resolves?

sure, completed

Could you assist in including a test case that this pull request resolves?

sure, completed

Thank you! Could you also assist in addressing the concerns mentioned by @coderabbitai?

I need more time to test this feature before release.


can't use proxy-authorization in header

hi, i try to use Proxy-Authorization header with my request, but it doesn't appear in request headers. If i change header name to 'Proxy-Authorization1', for example, everything is ok, i can see it in output.
proxy = {'http': 'http://ip:port/'}
token = base64.encodestring('user:pass').strip()
headers = {'Proxy-Authorization': 'Basic ' + token, 'Proxy-Connection': 'Keep-Alive', 'Accept': '*/*'}

r = requests.get('http://url', headers=headers, proxies=proxy)

the reason why i'm trying to do this - with authentication like<EMAIL_ADDRESS>or via HTTPBasicAuth request fails with 407 Authentication Required
so, is there a way to explicitly define Proxy-Authorization header ?

Well, in the sample code above you aren't actually telling requests which proxy to talk to. =)
This is easiest to do by using the username and password in the proxy URL, and then not providing the header at all:
proxy = {'http': 'http://user:pass@ip:port/'}
r = requests.get('http://url', proxies=proxy)

yep, tried this way, but proxies were still returning 407. however, now everything is ok again, i begin to suspect this is proxy's issue.


config [timeout: :infinity] does not seem to be working

My config:
config :hound, driver: "phantomjs"
config :hound, http: [timeout: :infinity]
config :hound, http: [recv_timeout: :infinity]

But I am still getting timeout errors when doing navigate_to:
** (MatchError) no match of right hand side value: {:error, %HTTPoison.Error{id: nil, reason: :timeout}}
      (hound) lib/hound/request_utils.ex:43: Hound.RequestUtils.send_req/4

@thisdotrob Thank you for reporting, I am going to give it a look!

@thisdotrob I am not really sure why this is happening yet, but it seems that it is fixed when removing the _build directory and recompiling.
I am going to investigate a little more, but could you try this temporary fix for now.
Thank you!

@tuvistavie This seems like a hackney bug that I came across recently (that affected httpoison). It has been fixed since.
Closing this.

This bug still exists. The HTTP options are read from the application config here: https://github.com/HashNuke/hound/blob/master/lib/hound/request_utils.ex#L4-L6
However, because they are assigned to the constant @http_options, the value of the config is only evaluated at compile time. This is why the behavior is "fixed" when Hound is recompiled.
I would recommend replacing references to @http_options (e.g. here), @retry_time, and any similar values meant to be configured at runtime with direct calls to Application.get_env, rather than compile-time constants.


SINGA-238 RBM on mnist

Implement RBM python version on mnist data set

The model is following: http://www.cs.toronto.edu/~hinton/science.pdf
This model is implemented using python tensors
Users should first download mnist.pkl.gz

  File "train.py", line 32, in load_train_data
    train_set, valid_set, test_set = cPickle.load(f)
  File "/home/wangwei/miniconda2/envs/py2/lib/python2.7/gzip.py", line 268, in read
    self._read(readsize)
  File "/home/wangwei/miniconda2/envs/py2/lib/python2.7/gzip.py", line 303, in _read
    self._read_gzip_header()
  File "/home/wangwei/miniconda2/envs/py2/lib/python2.7/gzip.py", line 197, in _read_gzip_header
    raise IOError, 'Not a gzipped file'
IOError: Not a gzipped file


Marking certain bindings as Preview

Marking external file as experimental https://github.com/Azure/azure-webjobs-sdk-templates/commit/08f06f3277371db586419172021b77fb5a8f208c


Improve how supported APIs can be checked

Returning a set makes it easier to check if a certain function is supported or not:
local supported_apis = fbinstant.get_supported_apis()
if supported_apis["getInterstitialAdAsync"] then
   -- load/show interstitial
end

Or maybe even utility functions such as fbinstant.is_ads_supported() would be event better?

Both would be good. Easy helper functions for specific API features that are unique to some platforms like ads, and to be able to check in a cleaner way any API feature.


Example_compare_mutual_info_correlation.py

print doc at the beginning of the example
I would show the samples in a scatter plot to make it clear that you are sampling points from a dataset.
Less iterations and a smaller dataset to reduce computation time...

Example_compare_mutual_info_correlation.py ->  example_compare_mutual_info_correlation.py (for all examples)


Fix multiple definitions error

Currently there is a problem for library consumers where the non-inline C API function definitions can cause errors due to multiple definitions.
From the name WEBVIEW_HEADER I would make an assumption as a library consumer that the purpose of this definition is to only expose declarations/definitions that can be used safely without side effects. Unfortunately defining WEBVIEW_HEADER currently has the side effect of hiding the C++ API.
This PR brings a minimum amount of changes for solving the problem:

New behavior

Always expose C API function declarations.

Always expose C++ API in C++ mode, and never expose it in C mode. This is safe because functions defined in class definitions are implicitly inline and the free functions used by the classes are marked as inline.

Never expose C API function definitions in C mode because they are implemented in C++.

Expose C API function definitions in C++ mode unless WEBVIEW_HEADER is defined.

This way WEBVIEW_HEADER no effect when compiling in C mode.
If we still want to conditionally hide the C API function definitions then my personal preference is to invert the condition, e.g. by defining WEBVIEW_IMPLEMENTATION instead of not defining WEBVIEW_HEADER, even though that introduces changes for library consumers.
Usage
I suggest that library consumers define WEBVIEW_HEADER globally so that the C API function definitions are hidden by default.
Place this in a C++ source file to define the C API function definitions if there is a need to consume the C API in C++ mode:
#undef WEBVIEW_HEADER
#include <webview.h>

Those who use CMake and FetchContent could do something like this paired with the snippet above:
[...]
add_library(webview INTERFACE)
target_include_directories(webview INTERFACE ${webview_SOURCE_DIR} ${WEBKIT2GTK_INCLUDE_DIRS})
target_link_libraries(webview INTERFACE ${WEBKIT2GTK_LIBRARIES})
target_compile_features(webview INTERFACE cxx_std_11)
target_compile_definitions(webview INTERFACE WEBVIEW_HEADER)
[...]

Alternatively, do something like this instead of both of the examples above:
[...]
add_library(webview STATIC ${webview_SOURCE_DIR}/webview.cc)
target_include_directories(webview PUBLIC ${webview_SOURCE_DIR} ${WEBKIT2GTK_INCLUDE_DIRS})
target_link_libraries(webview PUBLIC ${WEBKIT2GTK_LIBRARIES})
target_compile_features(webview PUBLIC cxx_std_11)
target_compile_definitions(webview INTERFACE WEBVIEW_HEADER)
[...]

For your information, making the functions inline instead works fine for my own use case but that can be left up for discussion because the purpose of this PR is simply to stop blocking people from using the library with the least amount of changes. I will be more than happy to make further edits to this PR to improve the solution.

I am working on another PR to replace this one because I am not happy with this approach.


Feature/pdf

Pull Request Test Coverage Report for Build 189

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.6%) to 97.414%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/format_parser/document.ex
0
3
0.0%

Totals

Change from base Build 184:
-2.6%

Covered Lines:
113

Relevant Lines:
116

💛  - Coveralls

Pull Request Test Coverage Report for Build 189

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.6%) to 97.414%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/format_parser/document.ex
0
3
0.0%

Totals

Change from base Build 184:
-2.6%

Covered Lines:
113

Relevant Lines:
116

💛  - Coveralls


chore(actions): Add verified commits check

Goal
To alert contributors early if their commit is unsigned. Using https://github.com/Nadock/verified_commits_check.

:tada: This PR is included in version 1.26.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Rename readme.md to README.md

For consistency and  http://dev.office.com/patterns-and-practices-detail/7203 was redirecting to github.

Hi @DevArvindsa, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

thx


Sorting for Combos With Zero Decks Is Inconsistent

It seems to me that the sorting the site does when combos have a deck count of 0 is inconsistent and doesn't seem to follow any form of logic. Before, the sorter would sort by EDHREC # decks, and then by color identity (after that I'm not sure). It doesn't seem that's the case anymore. See: https://commanderspellbook.com/search/?q=cabaretti
Before it would sort by Color Identity in descending number of colors (5s to 4s to 3s etc.). I personally always said it should have been sorted the opposite (colorless, 1 color, 2 color, etc.), because the fewer colored combos have higher potentials to be useful due to the sheer increase of decks that can use them. Either way, the sorting should follow a hierarchy that makes sense.

Now they are sorted by identity_count, then by cards_count, then by reverse creation date


Looking for Docker instead of docker

Description
Seems that it's just a Docker vs docker issue with the external call:
2018-07-30T21:05:38.441Z - debug: [] args 0=--version
2018-07-30T21:05:38.441Z - debug: [] relativized args 0=--version
2018-07-30T21:05:38.442Z - debug: [] spawnOptions cwd=/tmp, ATOM_HOME=/home/robo/.atom, NODE_PATH=/usr/share/atom/resources/app.asar/exports, NODE_ENV=production, J2SDKDIR=/usr/lib/jvm/java-10-oracle, USER=robo, TEXTDOMAIN=im-config, XDG_SEAT=seat0, SSH_AGENT_PID=3074, XDG_SESSION_TYPE=x11, J2REDIR=/usr/lib/jvm/java-10-oracle, SHLVL=0, QT4_IM_MODULE=xim, HOME=/home/robo, DESKTOP_SESSION=gnome, GTK_MODULES=gail:atk-bridge, DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus, MANDATORY_PATH=/usr/share/gconf/gnome.mandatory.path, IM_CONFIG_PHASE=2, LOGNAME=robo, GTK_IM_MODULE=ibus, DEFAULTS_PATH=/usr/share/gconf/gnome.default.path, USERNAME=robo, XDG_SESSION_ID=11, GNOME_DESKTOP_SESSION_ID=this-is-deprecated, WINDOWPATH=2, PATH=/home/robo/bin:/home/robo/.local/bin:/home/robo/.pythonz/bin:/home/robo/.zplugin/plugins/ogham---exa:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/lib/jvm/java-10-oracle/bin:/usr/lib/jvm/java-10-oracle/db/bin:/home/robo/code/go/bin, DERBY_HOME=/usr/lib/jvm/java-10-oracle/db, SESSION_MANAGER=local/robo-unseptium:@/tmp/.ICE-unix/13113,unix/robo-unseptium:/tmp/.ICE-unix/13113, XDG_MENU_PREFIX=gnome-, XDG_RUNTIME_DIR=/run/user/1000, DISPLAY=:1, LANG=en_US.UTF-8, XDG_CURRENT_DESKTOP=GNOME, XDG_SESSION_DESKTOP=gnome, XMODIFIERS=@im=ibus, XAUTHORITY=/run/user/1000/gdm/Xauthority, SSH_AUTH_SOCK=/run/user/1000/keyring/ssh, SHELL=/bin/zsh, QT_ACCESSIBILITY=1, GDMSESSION=gnome, TEXTDOMAINDIR=/usr/share/locale/, GPG_AGENT_INFO=/run/user/1000/gnupg/S.gpg-agent:0:1, XDG_VTNR=2, QT_IM_MODULE=ibus, JAVA_HOME=/usr/lib/jvm/java-10-oracle, PWD=/home/robo, CLUTTER_IM_MODULE=xim, XDG_DATA_DIRS=/usr/share/gnome:/usr/local/share:/usr/share:/var/lib/snapd/desktop, XDG_CONFIG_DIRS=/etc/xdg/xdg-gnome:/etc/xdg, GIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/atom.desktop, GIO_LAUNCHED_DESKTOP_FILE_PID=23426, GJS_DEBUG_OUTPUT=stderr, GJS_DEBUG_TOPICS=JS ERROR;JS LOG, GOOGLE_API_KEY=~~[REDACTED]~~, CHROME_DESKTOP=Atom.desktop, OLDPWD=/home/robo, ZSH_THEME=fishy, Z_LSBASE=exa, Z_LSARG_LONG=--long, Z_LSARG_ALL=-aa, Z_LSARG_HUMAN=--git, Z_LSARG_FORCE_COLOR=--color=always, ZPFX=/home/robo/.zplugin/polaris, MANPATH=:/home/robo/.zplugin/polaris/share/man, PAGER=less, LESS=-R, LC_CTYPE=en_US.UTF-8, FPATH=/home/robo/.zplugin/completions:/usr/local/share/zsh/site-functions:/usr/share/zsh/vendor-functions:/usr/share/zsh/vendor-completions:/usr/share/zsh/functions/Calendar:/usr/share/zsh/functions/Chpwd:/usr/share/zsh/functions/Completion:/usr/share/zsh/functions/Completion/AIX:/usr/share/zsh/functions/Completion/BSD:/usr/share/zsh/functions/Completion/Base:/usr/share/zsh/functions/Completion/Cygwin:/usr/share/zsh/functions/Completion/Darwin:/usr/share/zsh/functions/Completion/Debian:/usr/share/zsh/functions/Completion/Linux:/usr/share/zsh/functions/Completion/Mandriva:/usr/share/zsh/functions/Completion/Redhat:/usr/share/zsh/functions/Completion/Solaris:/usr/share/zsh/functions/Completion/Unix:/usr/share/zsh/functions/Completion/X:/usr/share/zsh/functions/Completion/Zsh:/usr/share/zsh/functions/Completion/openSUSE:/usr/share/zsh/functions/Exceptions:/usr/share/zsh/functions/MIME:/usr/share/zsh/functions/Math:/usr/share/zsh/functions/Misc:/usr/share/zsh/functions/Newuser:/usr/share/zsh/functions/Prompts:/usr/share/zsh/functions/TCP:/usr/share/zsh/functions/VCS_Info:/usr/share/zsh/functions/VCS_Info/Backends:/usr/share/zsh/functions/Zftp:/usr/share/zsh/functions/Zle:/home/robo/code/configs/zsh/fpath, LSCOLORS=Gxfxcxdxbxegedabagacad, LS_COLORS=, RTAB_PWD=~, GOPATH=/home/robo/code/go, Z_LSARG_DEFAULTS=-g, EDITOR=nvim, _=/usr/bin/env
2018-07-30T21:05:38.442Z - debug: [] spawn /usr/bin/docker 0=--version
2018-07-30T21:05:38.461Z - debug: [] spawn done -2
2018-07-30T21:05:38.505Z - debug: [] spawn done 0  Docker version 0.0.0-20180727163649-46d3079, build 46d3079

2018-07-30T21:05:38.505Z - verbose: [] spawn result, returnCode 0
2018-07-30T21:05:38.505Z - verbose: [] spawn result, stdout Docker version 0.0.0-20180727163649-46d3079, build 46d3079

2018-07-30T21:05:38.505Z - verbose: [] spawn result, stderr
2018-07-30T21:05:38.505Z - info: [] Version text: Docker version 0.0.0-20180727163649-46d3079, build 46d3079

2018-07-30T21:05:38.506Z - error: []  TypeError: Cannot read property 'slice' of null
    at Executable.parse [as versionParse] (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:384:94)
    at /home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:92:18
    at tryCatcher (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromiseCtx (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:606:10)
    at Async._drainQueue (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:138:12)
    at Async._drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
2018-07-30T21:05:38.506Z - debug: []  Error: Could not find 'Docker'. The program may not be installed.
    at Function.Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:277:10)
    at Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:269:18)
    at /home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:115:25
    at tryCatcher (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
2018-07-30T21:05:38.506Z - debug: [beautifiers/beautifier.coffee] Error loading executables Error: Could not find 'Docker'. The program may not be installed.
    at Function.Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:277:10)
    at Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:269:18)
    at /home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:115:25
    at tryCatcher (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
2018-07-30T21:05:38.506Z - error: [beautifiers/index.coffee]  Error: Could not find 'Docker'. The program may not be installed.
    at Function.Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:277:10)
    at Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:269:18)
    at /home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:115:25
    at tryCatcher (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
2018-07-30T21:05:38.506Z - info: [beautifiers/index.coffee] Analytics is enabled.

Steps to Reproduce

Add code to Atom editor that uses a docker beautifier engine
Run command Atom Beautify: Beautify Editor
Get this error:

See Docker installation instructions at https://github.com/Glavin001/atom-beautify#beautifiers or go to https://www.docker.com/get-docker
You can configure Atom Beautify with the absolute path to 'docker' by setting 'Executable - Docker - Path' in the Atom Beautify package settings.
Your program is properly installed if running 'which Docker' in your Terminal returns an absolute path to the executable.

Error: Could not find 'Docker'. The program may not be installed.
    at Function.Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:277:10)
    at Executable.commandNotFoundError (/home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:269:18)
    at /home/robo/.atom/packages/atom-beautify/src/beautifiers/executable.coffee:115:25
    at tryCatcher (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/home/robo/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Debug
Here is a link to the debug.md Gist: https://gist.github.com/robobenklein/9e90c723f3634a89d590d3ed4b21e454
Also - just FYI having people upload these gists that also spit out envvars is a security risk and I think that should be addressed at some point. (E.x. API keys and IDs used for user tracking.)
Checklist
I have:

[x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues so I know this is not a duplicate issue
[x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
[x] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

It's trying to run beautysh, but fails:
2018-07-30T21:05:38.438Z - debug: [] error Error: spawn beautysh ENOENT
    at _errnoException (util.js:1024:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
2018-07-30T21:05:38.438Z - debug: [] error Error: spawn beautysh ENOENT
    at _errnoException (util.js:1024:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

It then looks for Docker with the regex [version [0]*([1-9]\d*).[0]*([0-9]\d*).[0]*([0-9]\d*)](https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/executable.coffee#L384).  Since the version you have installed starts is 0.0.0, it doesn't match since the first needs to match a number between 1 and 9.
Where did you download Docker from?

Docker version 0.0.0-20180727163649-46d3079, build 46d3079

That's very bizarre...
My Docker source:
deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic nightly
# deb-src [arch=amd64] https://download.docker.com/linux/ubuntu bionic stable

I'll try the stable branch and see if that changes...

Just switched to deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic stable and it works as expected.
Docker version 18.06.0-ce, build 0ffa825

Did docker change the nightly versioning scheme?

I'm not sure, I only use stable Mac.  Their docs aren't very clear on the version naming scheme, https://docs.docker.com/install/.

Sounds like the solution is to use the stable version of Docker.
@robobenklein: I would accept a PR changing https://github.com/Glavin001/atom-beautify/blob/bb9428a4fa483fa6ffe958cdcb519b27e00cb770/src/beautifiers/executable.coffee#L384 to be more robust.

I'll leave this open as a bug, assuming someone else would like to contribute a fix to the parse function I referenced above.

For more information on this, it's specifically because the nightly builds are being tagged with versions composed of 0.0.0-DATE-HASH instead of positive versioning.
Just checked the bionic nightly of today:
Docker version 0.0.0-20180926205650-117ee8c, build 117ee8c

Once again, we are accepting PRs to fix this: https://github.com/Glavin001/atom-beautify/issues/2190#issuecomment-425608736 👍


Systemd configuration files

Expects vpnserver/vpnclient/vpnbridge to be in /opt.
Having a file do_not_run within these directories inhibits launch of a respective module.

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.
SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

I choose option 1 which which allows you to apply the same patch into PacketiX VPN.

I have built a RPM package for CentOS 7 based on the CentOS 6 spec files.
I have used the latest RTM version and it seems to be built nice.
I was wondering about the way that the project build and install it's files.
The vpn service files location is rather odd to the linux world.
Is there a way to improve the location of the files compared to the linux FS standards? like instead of as it is either use /usr/sbin/ or use a /usr/local/softethervpn/X/Y ?
I can modify the build files but I am unsure what is going in the compilation stage which will might make it impossible to change the location of the executable files.

Within the distribution, there are currently few places that it can end up, depending on how you install it.
From source, doing 'make install', looks like most ends up in /usr/bin, with setting files in /usr/vpnserver, /usr/vpnbridge, /usr/vpnclient, and /usr/vpncmd.
Current debian config file expects /opt
I think this from the fact that the code expects that the config file to sit in the same directory as an executable itself.
Considering anyone can pretty much specify any place with the prefix. Perhaps I suppose I (or someone else) can add sed script of some sort to Makefile to adopt to the PREFIX on the Makefile.

Superseded by #180 because of my fault handling the commit. Sorry!


Denizens or Sentry bug

Sentry or Denizens bug ?
When I come into some area with NPC trait sentry

http://timings.aikar.co/?url=14608817

TPS range : 2 - 5

What version of MC are you running?

My server is running CraftBukkit version git-Spigot-db6de12-d3e0b6f (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)

Not according to your timings, it says 1.8.5 and the latest is 1.8.6.  You are also a few versions behind on Citizens (1292 vs 1298).

Yes but, when I download the latest sentry, It give me this version

http://ci.citizensnpcs.co/job/Sentry/28/artifact/target/sentry.jar
==> 1.8

That's weird, mcmonkey probably did something weird with the versions then.  Try updating your Cit and see if that helps.  Are you seeing any errors in the console?

No errors, I'll describe you the problem :
We have some areas on our server that contain many NPCs - sentries. Recently, two of these areas experience this problem : when we enter these places, as soon as the NPCs start looking for targets (that means, as soon as they are able to attack you if they see you : they are no longer iddle, passive), the TPS drops dramatically. We changed nothing in the affected areas, it just happened suddenly for no apparent reason. This problem does not occur in other areas, even if there are as many NPCs as in the affected places.

Same problem with older Citizens versions.

Why the flip did you PR Denizen branches to report a Sentry bug?
Either way, Sentry is shite, use dSentry: http://mcmonkey.org/denizen/repo/entry/0


Bookmarks revamp

Task/Issue URL: https://app.asana.com/0/488551667048375/1206202020825288/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #4034   👈

This stack of pull requests is managed by Graphite.


Undefined reference to adjustorCode

Windows 32bit.
Error when running Shake build system:
* utils/compare_sizes/stage1/build/tmp/compareSizes.exe
user error (Development.Shake.cmd, system command failed
Command: inplace/bin/ghc-stage1.exe -hisuf hi -osuf o -hcsuf hc -static -hide-all-packages -no-user-package-db -package-id base-<IP_ADDRESS> -package-id directory-<IP_ADDRESS> -package-id filepath-<IP_ADDRESS> -i -iutils/compare_sizes/stage1/build -iutils/compare_sizes/stage1/build/autogen -iutils/compare_sizes -Iutils/compare_sizes/stage1/build -Iutils/compare_sizes/stage1/build/autogen -IC:\Neil\ghc\libraries\directory\include -IC:\Neil\ghc\libraries\time\lib/include -IC:\Neil\ghc\libraries\Win32\include -IC:\Neil\ghc\libraries\bytestring\include -IC:\Neil\ghc\libraries\base\include -IC:\Neil\ghc\libraries\integer-gmp\include -IC:/Neil/ghc/rts/stage1/build -IC:/Neil/ghc/includes -IC:/Neil/ghc/includes/dist-derivedconstants/header -optP-include -optPutils/compare_sizes/stage1/build/autogen/cabal_macros.h -XHaskell2010 -odir utils/compare_sizes/stage1/build -hidir utils/compare_sizes/stage1/build -stubdir utils/compare_sizes/stage1/build -rtsopts -H32m -O2 -no-auto-link-packages -optl-luser32 -optl-lgdi32 -optl-lwinmm -optl-ladvapi32 -optl-lshell32 -optl-lshfolder -optl-lwsock32 -optl-luser32 -optl-lshell32 -optl-lm -optl-lwsock32 -optl-lgdi32 -optl-lwinmm -optl-LC:\Neil\ghc\libraries\directory\stage1\build -optl-LC:\Neil\ghc\libraries\time\stage1\build -optl-LC:\Neil\ghc\libraries\filepath\stage1\build -optl-LC:\Neil\ghc\libraries\Win32\stage1\build -optl-LC:\Neil\ghc\libraries\bytestring\stage1\build -optl-LC:\Neil\ghc\libraries\deepseq\stage1\build -optl-LC:\Neil\ghc\libraries\array\stage1\build -optl-LC:\Neil\ghc\libraries\base\stage1\build -optl-LC:\Neil\ghc\libraries\integer-gmp\stage1\build -optl-LC:\Neil\ghc\libraries\ghc-prim\stage1\build -optl-LC:/Neil/ghc/rts/stage1/build utils/compare_sizes/stage1/build/Main.o -o utils/compare_sizes/stage1/build/tmp/compareSizes.exe
Exit code: 1
Stderr:
C:/Neil/ghc/rts/stage1/build/libHSrts.a(Adjustor.o):Adjustor.c:(.text+0x6b): undefined reference to `adjustorCode'
collect2.exe: error: ld returned 1 exit status
`gcc.exe' failed in phase `Linker'. (Exit code: 1)

Right, this is something new to me.
File src/Settings/Packages/Rts.hs takes care of all options used when building various pieces of rts. Some of them are still not implemented and are commented out below the code. I can see that Adjustor actually needs special treatment:
 -- rts/Adjustor_CC_OPTS    += -Wno-strict-prototypes $(LIBFFI_CFLAGS)

Maybe this is the reason.

From a quick grep I see that Adjustor is in assembly:
rts/AdjustorAsm.S:adjustorCode:

I imagine that's part of it at least.

Oh, we still don't deal with *.S files in any way. I wonder why we didn't need this on Linux (Travis) or on my Windows installation.

That does seem a bit weird - I don't see where else it could be getting adjustorCode from... Or maybe there are #ifdef's that only make it relevant on Windows 32bit.

#if defined(i386_HOST_ARCH)
extern void adjustorCode(void);

So only a 32bit issue.

@ndmitchell I've committed a first step towards a full solution. It covers only *.S files in rts. Could you please test?

Works for me, managed a complete GHC build on 8 cores in 21 minutes.

Great!

I guess that's the only one required on Win 32.


[Filestore] Change compaction policy inside IndexTablet

There is reason to believe that lack of policy leads to peaks in memory consumption.

You can take the blockstore policy as the default:
https://github.com/ydb-platform/nbs/blob/main/cloud/blockstore/libs/storage/core/tablet_schema.cpp#L11
Important notes:

The number of levels can only be increased, if you try to decrease it, there will be a drop in verify (I tried doing a rollback to the default policy in testing and I didn't have verify, everything worked properly. It's worth repeating the experiment again).
If there are two versions of code that apply different policies, you should make sure that on version rollback there is no attempt to decrease.

Features config was implemented earlier for filestore, so we can try enabling the new compaction policy for new tablets, and leave all the old ones on the old policy via features-config. So now the following is left to do:

[ ] Add compaction-policy feature in nfs-features.txt and add there all existing filesystems.
[ ] Roll out a new release with compaction-policy enabled (you can use the PR as a basis: https://github.com/ydb-platform/nbs/pull/431 ).
[ ] After a few weeks enable the feature for all filesystems (remove the list from nfs-features.txt).

There is reason to believe that lack of policy leads to peaks in memory consumption.

It's not the main problem. Bad compaction policy causes terrible commit latency. If we take a look at the traces of our write requests, we will see that we spend the majority of the time waiting for tx commit.
The chart above is for the sensor {service="tablets", host="cluster", queue="queue_compaction_gen*", sensor="InFlyTasks", database="total"}. The background compaction operations have drastically decreased. This had virtually no effect on the performance.


Multiple bug fixes.

Add support for viewing indirect diffuse of ground truth render for easier comparison with bakes.
Fix bug where the ground truth render didn't respect the area light shadows toggle.
Fix bug where the ground truth didn't respect the direct lighting toggle.

Thanks again Pablo, I appreciate you taking the time to publish your fixes!


Add audio and video options example for users

Users have requested a way to restrict audio or video input so with minimal code changes there is now an example to set options with each SimpleWebRTC instance.
index.html

Line 58 to 66 have two examples for setting the audio and video options by passing in the media options object.

simplewebrtc.js

Create a first option for the config object and allowing to fall back to original options if and opts.media object was not passed in.

simplewebrtc.build.js and latest.js

Changes resulted from "node build.js" changes.

*** Note: users should note they need to deal with empty containers in the id:remotes div if the video feed is restricted.

This functionality is already available. See L59 where any options passed in are set on the config object, media included. As for the example comment, there are some more detail examples being fleshed out on the not so simple examples. Sound good @theptrk?

Yeah, I guess the not so simple example incapsulates enough info for anyone interested in changing the options.


RA-91: The error message has been expanded + UTs have been added

Fix / remove unit tests if needed


"[Site Setting] 'Revert' button  does not return to default value after ckicking on it

Environment: Windows 11 Home Version 22H2 Build	22621.2506
Chrome Версія 118.0.5993.118 (Official build) (64-bit)
Reproducible: always
Build found:
Preconditions

https://zero-waste-staging.onrender.com/uk is opened in browser
User is logged in as admin
'Admin' page is opened
English locolization is chosen

Steps to reproduce

Go to 'Site Setting' tab
Click on 'Site Setting' tab
Fill in 'Title' with "ZeroPlus"
Click on 'Revert' button
Click on 'Ok' in 'Are you sure you want to revert the title and favicon to their default settings?' pop-up window
Actual result
Title "ZeroPlus"  does not return to "ZeroWaste" defaul value
Expected result
"ZeroWaste" default value is displayed

Postconditions
User story and test case links
E.g.: "User story #426
[Test case]
Labels to be added
"Bug", Priority ("pri: medium "), Severity ("severity: low"), Type ("Functional").
https://github.com/ita-social-projects/ZeroWaste/assets/152202895/b1b6d156-432f-4a5b-a8fe-455b0eea8a89

Done


musl support

Simple patch to add musl support.
There is no reliable way to detect musl I am aware of, but we can detect glibc which defines _USE_GNU, then we fall back to musl.
This successfully builds on alpine.
LMK if this approach works for you, and I can at least take a look at CI.
Linking #324

Well, it passes CI.
I assume that you've tested it with your own musl setup?

Confirmed the above was related to gcc13 removing automatic includes of stdint, which was fixed in later versions of rust. We will need to backport a patch to make rust 1.54 compile with gcc13 but a non issue for this PR.
I have now confirmed builds both in alpine and my own from-scratch musl-based distro with musl 1.2.4 and GCC12.


Remember me cookie cannot be configured as HTTPs only

Laravel allows setting the session cookie as HTTPs only, however there is no such setting for the remember me cookie and the guard class does not allow for it.
https://github.com/laravel/laravel/blob/master/app/config/session.php#L138
https://github.com/laravel/framework/blob/4.2/src/Illuminate/Auth/Guard.php#L508
I propose that the Guard class is modified to read a settings from the auth.php config file in similar style as the session cookie.
If there is interest in this I can submit a pull request to integrate this into either 4.2 or 5.0.

Would it make sense to use the same setting here?
That said, the config value should simply be passed to the Guard class, it shouldn't be coupled to the config component.

I would not personally be opposed to using the same configuration variable but it's also not something that strikes me as immediately intuitive.
The way it's handled for the session cookie is that the Session Middleware asks the SessionManager for the session config array and then simply checks if secure is set or not.
There is an AuthManager which interacts with the auth configuration section, however it is not being used by the Guard class which sets the remember me cookie.
There are essentially two ways to implement this.
The login method can be modified to take a secure flag: https://github.com/laravel/framework/blob/4.2/src/Illuminate/Auth/Guard.php#L420 which can then be passed all the way down to the method which sets the cookie.
The benefit is that this is fairly clean and self-explanatory when reading the code.
The down side is that it would be some time before abstraction layers would integrate this into their own libraries. For instance anyone using Confide will call Confide::logAttempt instead of directly accessing Auth::login() and will thus have to wait for Confide to update.
See: https://github.com/Zizaco/confide/blob/master/src/Confide/Confide.php#L122
The other way would be to pass in the AuthManager to the Guard class and implement a method to check if a configuration setting is set. This is a lot more involved but would allow everyone to easily set whether to use a secure cookie or not around their authentication abstraction layer.
I'm not sure what the preferred Laravel way is.

We're open to pull requests. :)

You could also create a useSecureCookies(bool toggle) method, or pass a useSecureCookies argument to the Guard constructor. Either one would set a property that would be passed on to the CookieJar->forever method call. Once implemented, you could call Auth::useSecureCookies(true) somewhere early in your app's lifecycle.
What's up with all this closing of issues that are clearly unresolved?

I ran into the same issue. I had to create my own Auth Driver and also extend the Guard class. In my extended guard class I did the following
class CustomGuard extends Guard {
/**
 * Create a remember me cookie for a given ID.
 *
 * @param  string  $value
 * @return \Symfony\Component\HttpFoundation\Cookie
 */
protected function createRecaller($value)
{
	$secure = Config::get('auth.secure',false);
	return $this->getCookieJar()->forever($this->getRecallerName(), $value, null, null, $secure);
}

}
This isn't how I would propose the framework handle this but it did solve my problem.


Fix overflow in Windows

Reorder operations to avoid overflows.
Behavior Fixed:
import scanpy as sc
import numpy as np
X = np.random.randint(0,1000, size= (3000,2000))
ann = sc.AnnData(np.log(X+1))
gsize = X.shape [0] / 2
ann.obs['group'] = ['a']* int (gsize) + ['b']*int (gsize)
sc.tl.rank_genes_groups(ann, 'group', method = 'wilcoxon', n_genes=2000)

... storing 'group' as categorical
C:\Users\patou\Anaconda-p3.7\envs\py36\lib\site-packages\scanpy\tools\_rank_genes_groups.py:372: RuntimeWarning: overflow encountered in long_scalars
  (ns[imask] * (n_cells - ns[imask]) * (n_cells + 1) / 12))
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-7-bccdb587a644> in <module>
      5 gsize = X.shape [0] / 2
      6 ann.obs['group'] = ['a']* int (gsize) + ['b']*int (gsize)
----> 7 sc.tl.rank_genes_groups(ann, 'group', method = 'wilcoxon', n_genes=2000)
      8
      9

~\Anaconda-p3.7\envs\py36\lib\site-packages\scanpy\tools\_rank_genes_groups.py in rank_genes_groups(adata, groupby, use_raw, groups, reference, n_genes, rankby_abs, key_added, copy, method, corr_method, **kwds)
    370                 scores[imask, :] = (scores[imask, :] - (ns[imask] * (n_cells + 1) / 2)) / sqrt(
    371                     (ns[imask] * (n_cells - ns[imask]) * (n_cells + 1) / 12))
--> 372
    373                 scores[np.isnan(scores)] = 0
    374                 pvals = 2 * stats.distributions.norm.sf(np.abs(scores[imask,:]))

ValueError: math domain error

After the fix, the same code no longer raises an error

Addresses #1061

Using / 12 instead of *(1/12) works too, right?
Or is there some weird numpy behavior here?

It should work I believe

But I am not sure about the readability and the order of operations.
a/bc is equal to a/(bc) or (a/b)*c?
that why I did it with parenthesis.

They all have the same precedence in every programming language and in math, and therefore evaluate from left to right.


Document using simulation framework without near_bindgen

If developer not using near_bindgen for some functions because of using direct exports - simulation framework won't have these functions to be called.
We should have documentation to how to use simulation directly.

Discussed this with @chadoh, and I think we need to rework the API so that user.call/user.view don't use PendingContractTx and instead just take method, args, etc.

sim tests deprecated


Source to dashboard quick-start

Adding a button to quick-start a dashboard for sources.

Adding a menu item beside any source with timestamp column.

Adding a button in onboarding to quick start for imported sources with timestamp column.

Adding an async method (will be async thunk once Source is moved to its slice) that,

Creates a model with select * from <>
Creates a metrics definition with the modelId from ^ and the 1st timestamp column.
Auto populates measure and dimensions using existing action for this.
Focuses the newly created dashboard

There will be an overlay until dashboard is created.

@AdityaHegde thanks for filing ~ at a high level this looks good. Marissa is thinking through the actual UX we want. Let's circle back on this PR in a day or two once we have a better idea about how to tweak the UX.
It's pretty neat going directly to a dashboard :)

@AdityaHegde , thanks for this PR!  A few changes requested around the UX:
Three Dot Menu for Sources

Remove the repetitive name of the asset from the menu.
Maintain styling highlight on the asset when using the three dot menu .
Change Labels for menu:

quick dashboard
new model
rename
delete

Always present all labels

Grey out “quick dashboard” if they are missing 1 DIMENSION or a time series.
Users can’t interact with  greyed out “quick dashboard” options.
If the option is grey, we should provide subtext justified to the right to let them know what they need to do to make a valid dashboard. (eg: ”create time series”; “create dimension”)

Onboarding
Please remove the CTA buttons directing people to the dashboard on the Getting Started screen for now.

@magorlick Talked to @hamilton . I have removed the changes to onboarding. He will fix the rest of the UX issues.

This UI feels like a really nice update to the menu.  No changes.  Thanks!


check for trait as well as class and interface

The test case that shows this failing
#serialization.yml
Gedmo\Timestampable\Traits\TimestampableEntity:
    attributes:
        createdAt:
            groups: [Default]

Yo @tacman! Can you re-open this over at https://github.com/symfony/symfony? This is just a read-only repository that mirrors that one :).
Thanks!

Hello, I invite you to resubmit on symfony/symfony, with a test case please.


Why the page is always stoping in "Round 1, Step 1, HostAgent: Analyzing the user intent and decomposing the request..."

I find the page is always stopping at "Round 1, Step 1, HostAgent: Analyzing the user intent and decomposing the request..."" when I use Gemini, please help me how to fix it.

@vyokky Please help me

You may need to print some logs to see where it get stuck... It is most likely because the Gemini is not responding.

@vyokky Thank you, but it can work normally when I use another computer with the same Gemini key.


pad hex for values in pipeline registers

after some considerations, decided that this was not needed.

after some considerations, decided that this was not needed.


Domain with two dashes not being detected

https://5b0ee223b312746c1659db3f--thelounge-chat.netlify.com/docs/ is a valid subdomain, but it's not being linkified.
From the looks of it hyphens are allowed except for certain restriction: https://tools.ietf.org/html/rfc5891#section-<IP_ADDRESS>

Thanks for report and clear sample.
See https://github.com/markdown-it/linkify-it/blob/cbc0833d3355dc04122c7a666122a61e58392555/lib/re.js#L104-L106. I think this can be added via options (disabled by default). Is this really necessary (need your opinion)?

After thinking a bit... no options needed. Two dashes should just work, according to RFC.
I can't promiss to make this soon, but PR will be accepted without delay.

Would it be just removing these lines?
https://github.com/markdown-it/linkify-it/blob/cbc0833d3355dc04122c7a666122a61e58392555/lib/re.js#L103-L107
It's a bit hard to tell from just looking at the code.

No, src_domain_root (top level domain) does not allow dashes at all. This line should exist, but be more clever. I can't say more immediately. Those regexes are mad even with comments :)

For info: There are top domains with two dashes too: www.a--b.com www.c--u.com

That's not TLD-s. TLD-s are .com, .eu etc.

I didn't say TLDs?

Yeah my bad.

Nevermind, i think we understand each other. Fixed rule should be "allow dashes according to RFC in all domain parts except TLD".

@puzrin, is there any chance you could take a look at this?
We switched to linkify-it (in https://github.com/thelounge/thelounge/pull/2397) a few months back, and about to release a new major version of our project, it would be so nice if this was fixed :)


[promcord] add new chart

Description of the change
Added a chart to the incubator for promcord
Benefits
Support the only chart for promcord
Possible drawbacks
Additional maintenance overhead
Checklist

[X] Chart version bumped in Chart.yaml according to semver.
[X] Title of the PR starts with chart name (e.g. [home-assistant])
[X] Variables are documented in the README.md (this can be done with using our helm-docs wrapper ./hack/gen-helm-docs.sh stable <chart>)

Tested and working nicely in our environment

You can release this to stable instead, looks good!

@all-contributors add @ChipWolf for code


account_saver: Remove nested options

Problem

Nested options here is confusing in the accounts_db code.
In reality, they are either all Some or the outer is None

Summary of Changes

Remove nested options
Get rid of unneccessary Boxes

Fixes #

@jstarry & @LucasSte as a follow-up to this I plan to move this out of SVM.
This functionality, as far as I can tell, is not actually used inside the svm crate - it is really needed by our runtime.
The reason I'd like to move it is to make the transition to the new transaction type not depend on the geyser interface changing, since I am seeing push-back on that front.
Instead, an extension-trait of SVMTransaction will be provided to create a SanitizedTransaction from the abstracted tx type, which will then be fed to geyser.
That behavior really has no place being part of SVMTransaction imo, so this module living here makes the abstraction difficult.
Instead of this collecting whatever transaction-type we pass in, it will (until geyser transitions) return SanitizedTransaction regardless of input type.
Once geyser transitions it will instead return the transaction interface type.
Additionally, these transactions will only be collected if geyser is enabled - otherwise we do not want to waste time for the conversion.

Wherever you move account_saver, I think account_loader should be moved as well I think. Wouldn't it be strange if account loading was part of the SVM but account saving was not?

@jstarry & @LucasSte as a follow-up to this I plan to move this module out of SVM.
This functionality, as far as I can tell, is not actually used inside the svm crate - it is really needed by our runtime.

You read my mind. I was going to look into this as well, but I didn't want to block anyone pushing bugfixes for now.

Wouldn't it be strange if account loading was part of the SVM but account saving was not?

I don't really think it'd be that strange - this is not actually where we "save" accounts anyways. We're just unrolling the TransactionProcessingResult into a more convenient form to then be saved (by accounts-db).
That said, I think I could probably work around the conversion issue I mentioned previously and just put the conversion trait in runtime - so we could leave this here.
Think @buffalojoec has some opinions on what should/should not be in SVM, so he may want to weigh in here.

I'm fully on board with this approach. I just did something similar with rent evaluation/collection in https://github.com/anza-xyz/agave/pull/2753 and may also do something similar with other pieces like fees. Are you going to take it on for account saver @apfitzge ? If not I can do it!


Add description, URI and other metadata to the project

@data-henrik Can you elaborate?

Enhance the visibility of this repo. Complete the setup. Add a description. Add links / URIs for the IBM Cloud docs, etc.


Add queryset and lookup_field to BasePermissions

#44 Adds a queryset and lookup_field to BasePermission so that you can query on your models in custom permissions classes. Passes all tests in runtests.py and solves the issue mentioned in #44

So I think this makes sense as a custom permission class but I wouldn't change the base permission class to require a queryset.


Add command for "update" and "outdated"

Implement the solution mentioned in #427

@isc-shuliu this PR is related to #550 where part of running "update" should upgrade a module and run its upgrade steps (if any).

@isc-shuliu this PR is related to #550 where part of running "update" should upgrade a module and run its upgrade steps (if any).

Thanks for the heads-up! I'm aware of that hence posting it as a draft.


Linters fail to work after the version update

VSCode Version: 1.4.0
OS Version: Mac (El Capitan) 10.11.16

Steps to Reproduce:

Download ESLint from the marketplace
Enable it by reloading Visual Studio Code
Attempt to generate an eslint error (i.e. Write an incomplete function declaration)
No errors show when an error should be detected

This issue was moved to Microsoft/vscode-eslint#110

Moving to eslint repository.


Bottom navigation space css fix

Bottom navigation was too close to translation links due to inline elements not respecting padding. Changing display property of navigation links to block solves the issue.

PR was containing way to much, than I planned to merge. Closed!


Increased visuals size. Using python3.

@bjoernrost I increased visualization sizes and also ran with python3.

I'll commit straight to master after this. But since this was my first commit, and plus I changed to using Python 3, I wanted to make sure this all worked for you the first time. Also... I removed the annoying empty code block at the beginning.

The issue with python3 is that Apache beam is not supported on it and we
are using it somewhere down the line to extract from bq to GCS. But maybe
we can fake our way around that and just use precreated extracts as it is
not too exciting to just watch a dataflow job take 5 minutes to write a
bunch of CSV files.
I also think there are public buckets with those csvs already. I'll look
into that
On Tue, Oct 16, 2018, 9:52 AM Stewart Bryson<EMAIL_ADDRESS>wrote:

I'll commit straight to master after this. But since this was my first
commit, and plus I changed to using Python 3, I wanted to make sure this
all worked for you the first time. Also... I removed the annoying empty
code block at the beginning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bjoernrost/ml-live/pull/1#issuecomment-430245774, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHk1msB_wc8aujJVxUH_3GqTbZiGmJRdks5uleStgaJpZM4XeZLx
.

--
--

The issue with python3 is that Apache beam is not supported on it and we are using it somewhere down the line to extract from bq to GCS. But maybe we can fake our way around that and just use precreated extracts as it is not too exciting to just watch a dataflow job take 5 minutes to write a bunch of CSV files. I also think there are public buckets with those csvs already. I'll look into that
…
On Tue, Oct 16, 2018, 9:52 AM Stewart Bryson @.***> wrote: I'll commit straight to master after this. But since this was my first commit, and plus I changed to using Python 3, I wanted to make sure this all worked for you the first time. Also... I removed the annoying empty code block at the beginning. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHk1msB_wc8aujJVxUH_3GqTbZiGmJRdks5uleStgaJpZM4XeZLx .
--

Do you want me to rollback to python 2?

@bjoernrost I went ahead and rolled back to python2. No big deal.


esprint linting job hits ENOMEM errors, but task does not fail

Hey there,
I installed esprint (^0.7.0) with yarn (1.12.3) and am running yarn esprint check with a list of ~1k files as xargs.
I was at first experiencing ENOMEM failures, but then started using a circleci node with resource_class: large (4 vCPUs and 8GB RAM) which caused the job to pass.
However, when I look at the output it looks like I am still hitting Error: ENOMEM: not enough memory, read at the beginning of the run.
It appears esprint keeps retrying after running out of memory and the job eventually succeeds - can you confirm that this is the case?
If so, it looks like the retries cause the task to take about as long as running eslint. Let me know where I could be going wrong here.
Thanks!

@caitlinard could you see if this is still an issue with the the latest version of esprint? Closing for now but feel free to re-open


Queries api improvment

Add /<execute>/execute endpoint for be able test new queries and updated queries
Inside queries worker add block number as parametr for procide consistently of data.
Add /queries/<query_name>/params endpoint
Add /queries/<query_name>/execute endpoint

Stale.


How to add a copywebpackplugin to storybook webpack config in full control mode.

I have tried to add the plugin like this
baseConfig.plugins.push(
		new CopyWebpackPlugin([
			{
				from: `src/assets/customer/locale`,
				to: 'locale',
				debug: true
			}
		])
	);

but it does not work.
Below is how the storybook plugins list looks when consoled to terminal
plugins:
   [ DefinePlugin { definitions: [Object] },
     HotModuleReplacementPlugin {
       options: {},
       multiStep: undefined,
       fullBuildTimeout: 200,
       requestTimeout: 10000 },
     CaseSensitivePathsPlugin { options: {}, pathCache: {}, fsOperations: 0, primed: false },
     WatchMissingNodeModulesPlugin {
       nodeModulesPath: '/Users/c-client/node_modules' },
     ProgressPlugin { profile: undefined, handler: undefined },
     { apply: [Function: bound apply] } ],

That's a mystery to me..

@ssbiswal1987 how exactly does your .storybook/webpack.config.js look like?

`const path = require('path');
const CopyWebpackPlugin = require('copy-webpack-plugin');
module.exports = (baseConfig) => {
// Custom loaders
baseConfig.module.rules = [
...baseConfig.module.rules,
scssLoader,
fileLoader,
imageLoader
];
baseConfig.plugins.push(
	new CopyWebpackPlugin([
		{
			from: `src/assets/customer/locale`,
			to: 'locale',
			debug: true
		}
	])
);

// Custom module paths
const resolvedCustomModulePaths = [
	'../src/js',
	'../src/fonts',
	'../src/css'
].map(toResolvedPath);

baseConfig.resolve.modules = [
	...baseConfig.resolve.modules,
	...resolvedCustomModulePaths
];

return baseConfig;

};
const scssLoader = {
test: /.scss$/,
loaders: ['style-loader', 'css-loader', 'sass-loader'],
include: path.resolve(__dirname, '../src')
};
const fileLoader = {
test: /.(otf|ttf|eot|svg|woff(2)?)(?[a-z0-9]+)?$/,
loader: 'file-loader',
query: {name: '[name].[ext]'}
};
const imageLoader = {
test: /.(jpe?g|png|gif|svg)$/i,
loader: 'file-loader',
query: {name: '../img/[name].[ext]'}
};
const toResolvedPath = targetPath => path.resolve(__dirname, targetPath);
`
@Hypnosphi

Looks like this { apply: [Function: bound apply] } object is the CopyWebpackPlugin (at least, ProgressPlugin is the last one in base config). Another question is, why it doesn't work

Yeah that is the one. It does not work.

any help ?

I facing the same issue, opening a new ticket


Fixes2

@mcollina this should be better now

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

34 of 36 (94.44%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 85.327%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

index.js
34
36
94.44%

Files with Coverage Reduction
New Missed Lines
%

index.js
1
87.16%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
278

Relevant Lines:
312

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-2 of 36 (94.44%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 85.327%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

index.js
34
36
94.44%

Files with Coverage Reduction
New Missed Lines
%

index.js
1
87.16%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
278

Relevant Lines:
312

💛  - Coveralls

This is better, however those changes make the test fail when using yarn :(

When using yarn? That's weird.

Yes you need to update https://github.com/pinojs/thread-stream/blob/main/test/commonjs-fallback.test.js.

(it's not run when on npm)

This works locally but seems to be some trouble on CI. @mcollina would you mind letting me start the CI jobs?

irst-time contributors need a maintainer to approve running workflows. Learn more.

Settings updated.

@mcollina What is the

// TODO handle deadlock

I'm suspecting I might be hitting that or some other timing bug that causes a deadlock.

Seems to occur especially for test/string-limit.test.js and I can't repro locally :/

@mcollina it's only string-limit that fails on CI now... any ideas?

All green 🎉

@mcollina all should be good now

Thanks! You fixed so many bigs in ths pr!


Add fixed point {mult, smult}_pipes.

Dahlia changes in Dahlia #366.
No changes in calyx-py necessary since there is no frontend generation.

@cgyurgyik feel free to merge. If you want to skip the task to combine the two implementations, let's just merge it and start using it in the Polybench FP stuff.

@cgyurgyik feel free to merge. If you want to skip the task to combine the two implementations, let's just merge it and start using it in the Polybench FP stuff.

Ok. Its not immediately clear to me how to combine the two, but I imagine it is doable given that you did something similar for std_div_pipe. I'll make an issue since std_mult_pipe is also not combined.


Error when cancel creating new document

Scenario
Adding a new bank account from wallet
Clicking on cancel
What happens
We get an Internal server error

@vi-fu Could you take this?

@vi-fu Could you take this?

yes


Creating columns/rows/flex with padding is noisy

I often find myself wrapping Column, Row, and Flex in padding.
new Padding(
  padding: const EdgeInsets.all(15.0),
  child: new Column(
    children: [
      new Item(),
      new Item()
    ]
  )
)

I would love it if these widgets all learned the padding property. The extra nesting, indentation, and noise from constantly wrapping things in padding reduces the delight of using flutter.
new Column(
  padding: const EdgeInsets.all(15.0),
  children: [
    new Item(),
    new Item()
  ]
)

You could create your own PaddedColumn widget that takes the arguments of Padding and Column and combines them into a Padding and a Column. This is more or less what Container does with ConstrainedBox, Padding, DecoratedBox, and Transform. I'd be wary of adding padding knowledge to RenderFlex itself, because that class is already one of our most complicated classes.

I agree it would be trivial to write my own Padded{Row,Column,Flex} widgets. It still feels like something that should be part of the default widget library.
The only similar framework I have used in the past supported this:
http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/mx/containers/HBox.html
Doing a quick look most other frameworks have this built in:

http://help.eclipse.org/juno/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fswt%2Flayout%2FRowLayout.html
https://docs.oracle.com/javase/8/javafx/api/javafx/scene/layout/HBox.html

We could add it to Column by making Column into a component that has both a Padding and a Flex, instead of the current setup of having it just extend Flex. That would avoid making RenderFlex more complicated.
As a general philosophy, we expect to be different from other frameworks on issues like this because we've taken the approach of having many dedicated trivially simple widgets rather than few complicated widgets. The latter approach is used by most frameworks. The Web, in particular, takes the latter approach to an extreme, where <div> supports almost all the layout algorithms itself. Once you add padding, the next question is why not add decoration? Then when you have decorations, Why not add margins? Then why not add knowledge of clipping, or the ability to have some children take part in the flex and others be just stacked on top?
There's a slippery slope here which we're very wary about going down.
But that doesn't mean we shouldn't consider this specific request. We have some precedent, like the Container example I mentioned before.

I'm going to WONTFIX this. We are happy with our composition approach and in practice this hasn't been a particularly notable pain point.


fixing double underscores

we should probably add tests for this; I'm going to try to add some later tonight.

ok i looked into tests here. I didn't have much success; the schema by itself isn't enough to trigger an error in this block.
will merge this and think about this when it's an issue next.


CFFI support

This is to improve performance on PyPy.

I don't understand this issue could you elaborate please?

I don't understand this issue could you elaborate please?

PyPy uses a different internal representation of Python objects than CPython does.  For this and other reasons, its implementation of the CPython C API uses an emulation layer, which is rather slow.  CFFI, on the other hand, is very fast on PyPy due to dedicated code in PyPy’s JIT compiler.  It’s also pretty fast on CPython.

OK so no I have no plans to implement this myself. I'd be happy to review a PR though, provided there are benchmarks for both CPython and PyPy so we can make an informed decision.


particles_per_macroparticle should be removed from beambeam3d

particles.weight should be used instead.
https://github.com/xsuite/xfields/blob/6779856fd21f6f60809e70d26b293f34bc9606bf/xfields/beam_elements/beambeam3d.py#L104

Done in latest xfields release


Remove Mac OSX DS_Store directory index from repo

Just cleaning up the repo

Thank you @setar this should be fixed in the most recent release


OADP-849: fix replicationDestination race condition

Tested changes with app with multiple PVCs and was unable to reproduce race condition. Ty for the fix

Cherry-pick PR: https://github.com/migtools/volume-snapshot-mover/pull/163


l10n + search by dialCode + custom countries list + improvment

This contribution is a fork of #227  with some improvements. The initial PR message can be found at the end.
Modification

add autofillHint with the possibility of disabled it
search starting with '+' is treat as search by dialCode (prevent returning empty list of country when user type only "+")
fix sorting countries name after search
default validator return error if not numeric
add sizeBox before dropdown, better visibility and prevent flag to touch border if no dropdown icon
update countries argument :
After seeing a lot of issues requesting the change of min & max length (#225, #238,...), some PR (#218,#212, ...)and also personally wanted to change the file. I found it will be better changing the format of the argument countries to accept a list of Country instead of list of ISO code. Like this you can still provide a limited list of country but you can also change parameters of the initial country list. In addition after adding l10n, this change is perfect for adding new locales to the file. I think it will reduce the time of maintaining the package and if the package is no longer maintained people can still use it without fork it.

I hope this PR will help and feel free to ask me modifications or question !
Initial message
This contribution contains a set of improvements to the package,
It contains:

Added a new property to the Country model called nameTranslations, it is a map that has a language code as a key and the localized name that correspond to the language.
Contain search results when typing the name in any of the provided translations
Fix searching for country code does not work when there's a "+".
Use flag emojis instead of png to reduce the package size (Personal opinion).
Sort Countries ascending by name ... for all languages

@marcaureln @ vanshg395 Any chance you can take a look at this and hopefully merge?

@jimmyff for sure. I took a look, everything look great. @launay12u thanks for your work. Can you allow edits from maintainers? I'd a few commit to push before merge. The change is about flags png, the emojis are great on mobile, but they aren't rendering on browser. We got black and white outline drawings instead. So, we'll keep the images for now. But, if you have an idea on how to fix it, it'll be great!

@all-contributors please add @launay12u for code

Hey !
Thanks for looking to merge my PR 😄
I think you already allow to edit :

Do I need to do something else ?
As I say it's a fork from another fork is it a problem ?

I'm still not able to push my changes. Can you do I for me and I'll directly merge the PR.
This is what I did:

I first restore the assets folder and uncomment the pupspec.yaml
Update the lib/country_picker_dialog.dart and lib/intl_phone_field.dart to use the flag when running the app on browser, I dit something like this:

import 'package:flutter/foundation.dart' show kIsWeb;

....

kIsWeb
                          ? Image.asset(
                              'assets/flags/${_filteredCountries[index].code.toLowerCase()}.png',
                              package: 'intl_phone_field',
                              width: 32,
                            )
                          : Text(
                              _filteredCountries[index].flag,
                              style: TextStyle(fontSize: 18),
                            ),
                      ...

@marcaureln  It's done, I also resolve conflict on the lock file (take the current lockfile instead of mine).
Feel free to ask me other change.
Just I now run Flutter in version 3.10.0 so I can't run flutter pub get anymore (But if needed I can downgrade)
Maybe it will be good to accept new version of flutter 😄

PR merged, huge thanks to @launay12u and @jimmyff!
@launay12u I would be glad to merge another PR for Flutter 3.x :wink:

I've included the fix for Italy (along with Malaysia and Switzerland too) on my branch. Although my PR also includes a breaking API change, it now includes a validates bool in the onChanged callback:
https://github.com/vanshg395/intl_phone_field/pull/286


Resolved #1219 - Support load and save for CookieJar

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes
[x] Add yourself to CONTRIBUTORS.txt

The format is <Name> <Surname>.
Please keep alphabetical order, the file is sorted by names.

[x] Add a new entry to CHANGES.rst

Choose any open position to avoid merge conflicts with other PRs.
Add a link to the issue you are fixing (if any) using #isuue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

Current coverage is 98.51% (diff: 100%)

No coverage report found for master at 0f74eae.

Powered by Codecov. Last update 0f74eae...ebd173a

Thanks!


Enable branch protection for main

I'd prefer if everything went through PRs. I can't do it until we make the repo public though.

I've added require PR with one approval for now. We can add more if we think it is necessary.


Add dual-stack support for coredns

How to categorize this PR?

/area networking
/kind enhancement
What this PR does / why we need it:
Add dual-stack support for coredns.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Add dual-stack support for coredns.

/retest

/retest

/lgtm

/retest

/retest

/retest


Client sent an HTTP request to an HTTPS server

Hello,
getting Client sent an HTTP request to an HTTPS server. when going on http://myip:5757/
Where can I disable HTTPS?
I only want to use HTTP.
Thank you!

Sorry, you'll need to show me how you are starting the exporter. If you only want http, do not pass -web.tls.listen-address. The default port for http is 9999


Clarify what consensus/majority means

Thank you, @jethrogb, for the suggestion!
Fixes #258

This is just a messaging tweak.  Can it be merged without CI validation passes, @anp?  I can drop the rust-toolchain update commit if need be.

Let's run this through travis again :)

✅!


extra arguments to Range.setEndAfter()

Search the codebase for .setEndAfter(), and you'll see Range.setEndAfter being called in a few places with what appears to be an extra 0 argument after the node?
According to Mozilla's DOM reference, that method takes one argument:
https://developer.mozilla.org/en-US/docs/Web/API/Range/setEndAfter

There are calls to Range.setStartAfter passing an extra second argument as well.

I'll check with @OliverJAsh in case of any undocumentated behaviour but it looks like the additional parameters could be removed

:+1: