WIP Use repartition in window functions

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

benchmark run
Benchmarking window empty over, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.9s, enable flat sampling, or reduce sample count to 60.
window empty over, aggregate functions
                        time:   [1.1699 ms 1.1755 ms 1.1811 ms]
                        change: [-37.629% -36.780% -36.002%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

Benchmarking window empty over, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.3s, enable flat sampling, or reduce sample count to 60.
window empty over, built-in functions
                        time:   [1.0180 ms 1.0236 ms 1.0299 ms]
                        change: [-26.237% -25.544% -24.778%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

window order by, aggregate functions
                        time:   [8.0163 ms 8.0741 ms 8.1409 ms]
                        change: [-3.3019% -1.9941% -0.6139%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

window order by, built-in functions
                        time:   [7.4822 ms 7.5313 ms 7.5843 ms]
                        change: [-0.8959% +0.1569% +1.1590%] (p = 0.77 > 0.05)
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild

window partition by, u64_wide, aggregate functions
                        time:   [20.548 ms 20.664 ms 20.789 ms]
                        change: [+7.8065% +9.0739% +10.344%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

window partition by, u64_narrow, aggregate functions
                        time:   [7.2287 ms 7.2704 ms 7.3122 ms]
                        change: [+11.989% +13.130% +14.218%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  4 (4.00%) high mild

window partition by, u64_wide, built-in functions
                        time:   [19.238 ms 19.360 ms 19.488 ms]
                        change: [+16.724% +18.053% +19.384%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

window partition by, u64_narrow, built-in functions
                        time:   [6.4687 ms 6.5140 ms 6.5591 ms]
                        change: [+8.1468% +9.2522% +10.283%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

window partition and order by, u64_wide, aggregate functions
                        time:   [27.575 ms 27.785 ms 28.013 ms]
                        change: [+9.4015% +10.538% +11.674%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

Benchmarking window partition and order by, u64_narrow, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 5.5s, or reduce sample count to 90.
window partition and order by, u64_narrow, aggregate functions
                        time:   [54.981 ms 55.324 ms 55.702 ms]
                        change: [-0.6417% +0.7593% +2.0563%] (p = 0.29 > 0.05)
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

window partition and order by, u64_wide, built-in functions
                        time:   [25.673 ms 25.817 ms 25.969 ms]
                        change: [+7.6207% +8.7502% +9.8676%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

window partition and order by, u64_narrow, built-in functions
                        time:   [16.124 ms 16.211 ms 16.308 ms]
                        change: [+0.5055% +1.5834% +2.6646%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

Nice, almost 5 times improvement for some queries!
But do those have to do with the changes wrt sort or with regards to partition by?

Nice, almost 5 times improvement for some queries!
But do those have to do with the changes wrt sort or with regards to partition by?

I don't expect that much of an improvement. let me redo the benchmark after #573 is merged.

latest against the master
window empty over, aggregate functions
                        time:   [38.093 ms 38.813 ms 39.557 ms]
                        change: [+7.9976% +10.144% +12.365%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

window empty over, built-in functions
                        time:   [28.492 ms 29.010 ms 29.571 ms]
                        change: [-9.6876% -6.5061% -3.1331%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  4 (4.00%) high mild
  3 (3.00%) high severe

Benchmarking window order by, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 18.2s, or reduce sample count to 20.
window order by, aggregate functions
                        time:   [180.14 ms 182.30 ms 184.63 ms]
                        change: [-3.2247% -1.5082% +0.1867%] (p = 0.10 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  8 (8.00%) high mild
  2 (2.00%) high severe

Benchmarking window order by, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 16.7s, or reduce sample count to 20.
window order by, built-in functions
                        time:   [164.02 ms 165.72 ms 167.55 ms]
                        change: [-3.0666% -1.6099% -0.2141%] (p = 0.04 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

Benchmarking window partition by, u64_wide, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 26.9s, or reduce sample count to 10.
window partition by, u64_wide, aggregate functions
                        time:   [279.31 ms 283.97 ms 288.78 ms]
                        change: [+5.6067% +7.9223% +10.288%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

Benchmarking window partition by, u64_narrow, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 13.2s, or reduce sample count to 30.
window partition by, u64_narrow, aggregate functions
                        time:   [119.82 ms 122.24 ms 124.91 ms]
                        change: [-10.403% -8.3916% -6.3109%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

Benchmarking window partition by, u64_wide, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 23.7s, or reduce sample count to 20.
window partition by, u64_wide, built-in functions
                        time:   [229.23 ms 232.16 ms 235.14 ms]
                        change: [+1.8582% +3.3754% +4.9304%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

Benchmarking window partition by, u64_narrow, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 10.9s, or reduce sample count to 40.
window partition by, u64_narrow, built-in functions
                        time:   [109.41 ms 111.44 ms 113.55 ms]
                        change: [-9.5580% -7.6470% -5.5888%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild

Benchmarking window partition and order by, u64_wide, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 46.0s, or reduce sample count to 10.
window partition and order by, u64_wide, aggregate functions
                        time:   [451.08 ms 454.83 ms 458.61 ms]
                        change: [-8.3071% -6.4767% -4.6734%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Benchmarking window partition and order by, u64_narrow, aggregate functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 60.7s, or reduce sample count to 10.
window partition and order by, u64_narrow, aggregate functions
                        time:   [564.17 ms 568.36 ms 572.64 ms]
                        change: [-17.391% -16.295% -15.200%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

Benchmarking window partition and order by, u64_wide, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 41.1s, or reduce sample count to 10.
window partition and order by, u64_wide, built-in functions
                        time:   [396.51 ms 401.62 ms 407.54 ms]
                        change: [-10.962% -8.9661% -6.8683%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

Benchmarking window partition and order by, u64_narrow, built-in functions: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 34.4s, or reduce sample count to 10.
window partition and order by, u64_narrow, built-in functions
                        time:   [331.09 ms 334.20 ms 337.40 ms]
                        change: [-16.892% -15.883% -14.890%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

@Dandandan turns out it's not that clear cut


Added HasRepeat expectation

Closes #57

@gcrespi @giuliano64 please drop a comment here :smile_cat:

@gcrespi, are you alive? :skull:

Sorry for the delay!


Issue in setting up Smart Edge Open branch 22.03.02

Hi,
I am having issue in setting up smart edge open on branch 22.03.02. The issue that I have encounter is the playbook does not able to find the role 'infrastructure/ptp/node' in playbooks/infrastructure.yml.
The full logs are as below:
2022-08-17 02:30:31.997 INFO: esc_smart_edge_cluster network_edge.yml: command: "/usr/bin/ansible-playbook -vv /opt/apps/backend/tasks/seo/dek/network_edge.yml --inventory /opt/apps/backend/tasks/seo/dek/inventory/automated/esc_smart_edge_cluster/inventory_esc_smart_edge_cluster.yml --limit controller_group"
2022-08-17 02:30:31.998 INFO: esc_smart_edge_cluster network_edge.yml: log file: "/opt/apps/backend/tasks/seo/dek/logs/esc_smart_edge_cluster_dek_2022-08-17_02-30-31_network_edge.yml.log"
2022-08-17 02:30:37.004 INFO: Only one cluster is being deployed. Redirecting logs to stdout.
ansible-playbook [core 2.11.6]
config file = /opt/apps/backend/tasks/seo/dek/ansible.cfg
configured module search path = ['/home/controller/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/lib/python3.9/site-packages/ansible
ansible collection location = /home/controller/.ansible/collections:/usr/share/ansible/collections
2022-08-17 02:30:37.021 INFO: <Command '/usr/bin/tail -n 100000 -f /opt/apps/backend/tasks/seo/dek/logs/esc_smart_edge_cluster_dek_2022-08-17_02-30-31_network_edge.yml.log', pid 13111>: process started
executable location = /usr/bin/ansible-playbook
python version = 3.9.13 (main, Jul 26 2022, 13:12:30) [GCC 10.3.1 20211027]
2022-08-17 02:30:37.023 ERROR: esc_smart_edge_cluster network_edge.yml: failed. Please check the logs: /opt/apps/backend/tasks/seo/dek/logs/esc_smart_edge_cluster_dek_2022-08-17_02-30-31_network_edge.yml.log
jinja version = 3.0.1
libyaml = True
Using /opt/apps/backend/tasks/seo/dek/ansible.cfg as config file
[DEPRECATION WARNING]: [defaults]callback_whitelist option, normalizing names
to new standard, use callbacks_enabled instead. This feature will be removed
from ansible-core in version 2.15. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.
redirecting (type: modules) ansible.builtin.selinux to ansible.posix.selinux
redirecting (type: modules) ansible.builtin.selinux to ansible.posix.selinux
redirecting (type: modules) ansible.builtin.sysctl to ansible.posix.sysctl
redirecting (type: modules) ansible.builtin.make to community.general.make
redirecting (type: modules) ansible.builtin.make to community.general.make
redirecting (type: modules) ansible.builtin.make to community.general.make
redirecting (type: modules) ansible.builtin.modprobe to community.general.modprobe
redirecting (type: modules) ansible.builtin.modprobe to community.general.modprobe
statically imported: /opt/apps/backend/tasks/seo/dek/tasks/reboot_server.yml
ERROR! the role 'infrastructure/ptp/controlplane' was not found in /opt/apps/backend/tasks/seo/dek/playbooks/roles:/opt/apps/backend/tasks/seo/dek/roles:/opt/apps/backend/tasks/seo/dek/roles/baseline_ansible:/opt/apps/backend/tasks/seo/dek/playbooks
The error appears to be in '/opt/apps/backend/tasks/seo/dek/playbooks/infrastructure.yml': line 59, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
roles:
- role: infrastructure/ptp/controlplane
^ here
2022-08-17 02:30:38.025 INFO: ====================
2022-08-17 02:30:38.026 INFO: DEPLOYMENT RECAP:
2022-08-17 02:30:38.026 INFO: ====================
2022-08-17 02:30:38.026 INFO: DEPLOYMENT COUNT: 1
2022-08-17 02:30:38.027 INFO: SUCCESSFUL DEPLOYMENTS: 0
2022-08-17 02:30:38.027 INFO: FAILED DEPLOYMENTS: 1
2022-08-17 02:30:38.027 INFO: DEPLOYMENT "esc_smart_edge_cluster": FAILED
2022-08-17 02:30:38.028 INFO: ====================
2022-08-17 02:30:38.028 INFO: Deployment failed, pulling logs
2022_08_17_02_30_38_SmartEdge_experience_kit_archive.tar.gz                                                                                100%  783KB  22.1MB/s   00:00
log_collector                                                                                100%   15KB  10.5MB/s   00:00
log_collector.json
May I know if this is a known issue and is there any ways that we can used to fix this installation issue?

After I disable the following lines in playbooks/infrastructure.yml, I am able to do the installation.
- hosts: controller_group
any_errors_fatal: true
roles:
- role: infrastructure/ptp/controlplane
when: ptp_sync_enable | default(False)
- hosts: edgenode_group
any_errors_fatal: true
roles:
- role: infrastructure/ptp/node
when: ptp_sync_enable | default(False)
- role: baseline_ansible/infrastructure/time_verify_ntp
reference_host: "{{ groups['controller_group'][0] }}"
when: ptp_sync_enable | default(False)
May I know if this will be fixed in the next release, or is there any hotfix to address the issue?

The roles in roles/infrastructure/ptp/ no longer exists, but are still referenced by the playbook, create empty folders as workaround.
mkdir -p infrastructure/ptp/{controlplane,node}


Datagrid columns do not align correctly when new rows are added dynamically to the datagrid

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
If you dynamically add row elements to the datagrid, the length of columns should change accordingly.
Actual behavior
At the moment if you add dynamically row elements to the datagrid, column width does not change and the text overlaps. A horizontal scroller appears and if try to use it the data does not align with the column headers.
Reproduction of behavior
https://plnkr.co/edit/RhbX8K4OhX72HHRT8fEZ?p=preview
Environment details

Angular version: 2.3.1

Clarity version: 0.8.11

OS and version: Win 10 Enterprise

Browser: all

Actually, if you look at it precisely, the columns do align nicely. The "Long Id user" is positioned right where it should be, it's just the first cell that overflows on top of it.
This is the expected behavior. We do not want to use overflow: hidden on the cells by default because the could contain anything, including stuff that should overflow (like tooltips). On top of that, if you were using actual text rather than an id, you'd see that the text wraps over several lines to avoid overflowing.
So in your specific case, all you need to do is to put an overflow: hidden on the ID cell, and a text-overflow: ellipsis for good measure. See it in action here: https://plnkr.co/edit/Giu24gt6JCdSQI8Zw5h4?p=preview
I only added a class to ID cells, and put the 2 styles mentioned in the CSS.

Hi youdz,
Thank you for your example with ellipsis option for the text. My case is a little bit different.
The text that I display in the datagrid call should be displayed in one line even if there are spaces in the text(this is a hard requirement). Based on this, my only option is to use ellipsis but as most of the cells contain such texts this becomes unreadable. The only option to use tooltips is also unacceptable because the user is not able to have the information presented at a glance.
Having all that in mind, I cannot use the datagrid in it's current form.
Is it possible to force the datagrid to recalculate the width of the columns when new rows are added?

@rreymer I am a little confused on the requirement, are we saying that we need text not to wrap, not to have ellipses and force the datagrid to react to that? That does not seem like a typical use case or one that would scale. What if the text is far larger than the whole screen? Coding this into the datagrid itself for such a non-typical use case is not the right approach, in my opinion. Let me know if you're able to provide more concrete use cases and examples of why this is the case here.


export embrio::io::BufRead

It seemed to be missing given that some of the util::io functions use it.

bors r+


[Bug]: My stiles are broken

What happened?
When I apply uploadthing styles to my code, they break my styles. I have read the documentation and followed the recommendations. In my layout.tsx I declare them in the following order:
import<EMAIL_ADDRESS>import "./globals.css";

What breaks is that it hides my navbar, which is made with shadcn  this has a "hidden" style for when it is being displayed on non-mobile devices, that is, I have a navbar for mobile and another for desktop:

Navbar that is not visible: <div className="mr-4 hidden sm:flex">.

If I remove the uploadthing styles, the navbar works normally. Also in my tailwind.conf.ts I have withUt added as recommended in the documentation:
import {withUt} from "uploadthing/tw";

module.exports = withUt({})

What did you expect to happen?
Styles should display normally, showing the navbar.
With uploadthing styles:

Without uploadthing styles:

Version
My package.json:
"next": "13.4.15",
"@uploadthing/react": "5.6.1",
"uploadthing": "5.6.1",

Reproduction Steps
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Are you on latest version?

Are you on latest version?

Yes, I have uploadthing on the lastest (5.6.1) and next on (13.5.2)

We have a canary out fixing some stuff with the withUt function.
pnpm add<EMAIL_ADDRESS>
This will be released in the next version

We have a canary out fixing some stuff with the withUt function.
pnpm add<EMAIL_ADDRESS>
This will be released in the next version

Still not working, so I have to wait for the next version?

Are you able to share a reproduction of this so we can debug further?

I can confirm that I get this in the newest versions of UploadThing. What works for me is to move uploadthing CSS into the globals.css end of the file. This is an example: https://github.com/AntonioErdeljac/next13-discord-clone/issues/18#issuecomment-1720244154

Are you able to share a reproduction of this so we can debug further?

Its a big project, but I tried to make a little reproduction here, it works on my computer and has the same bug so try it.
project

I can confirm that I get this in the newest versions of UploadThing. What works for me is to move uploadthing CSS into the globals.css end of the file. This is an example: AntonioErdeljac/next13-discord-clone#18 (comment)

seems that works, thanks!

If you are using the withUt() helper, you do not need to (and should not) add any import for the uploadthing styles. You should only have one or the other.


Need Help? Show/Hide Password

How can i attache event on eye icon in Input control for show/hide password?

Duplicate of https://github.com/akveo/kittenTricks/issues/197


Move gcr.io/heptio/ to projectcontour/ for master only

Updates #1434
Signed-off-by: Nick Young<EMAIL_ADDRESS>

I'd like to wait on this a few days to make sure the :master builds are working well.

No problem. Let's leave it to soak then.


modelViewer is not defined at HTMLButtonElement(Animations are not working)

Description
Hello Guys, I'm experiencing a wired bug with animations all of sudden and animations stopped working and console throw's this error.
"Uncaught ReferenceError: modelViewer is not defined at HTMLButtonElement."
Live Demo
https://glitch.com/~humdrum-half-wanderer

model-viewer: 0.9.0

I think you're just missing const modelViewer = document.querySelector('#your-id');

I think you're just missing const modelViewer = document.querySelector('#your-id');

thank you, @elalish I have declared const but button click still not calling animations and everything was working fine before 2days
https://glitch.com/edit/#!/join/21998466-27a6-4fe4-b41b-735f0fdad32f


Improve exception handling to reduce unnecessary stack traces

The ready_middleware function in admin/server.py has the following implementation:
@web.middleware
async def ready_middleware(request: web.BaseRequest, handler: Coroutine):
    """Only continue if application is ready to take work."""

    if str(request.rel_url).rstrip("/") in (
        "/status/live",
        "/status/ready",
    ) or request.app._state.get("ready"):
        try:
            return await handler(request)
        except (LedgerConfigError, LedgerTransactionError) as e:
            # fatal, signal server shutdown
            LOGGER.error("Shutdown with %s", str(e))
            request.app._state["ready"] = False
            request.app._state["alive"] = False
            raise
        except web.HTTPFound as e:
            # redirect, typically / -> /api/doc
            LOGGER.info("Handler redirect to: %s", e.location)
            raise
        except asyncio.CancelledError:
            # redirection spawns new task and cancels old
            LOGGER.debug("Task cancelled")
            raise
        except Exception as e:
            # some other error?
            LOGGER.error("Handler error with exception: %s", str(e))
            import traceback

            print("\n=================")
            traceback.print_exc()
            raise

    raise web.HTTPServiceUnavailable(reason="Shutdown in progress")

This needs a makeover. In particular, the way that base exceptions are handled with an error log and stack trace being printed out.
In many cases, the stack trace is wholly uninformative, and just clutters the logs. For example: invalid token, record not found, or any other bad client requests, will print a redundant stack trace as follows:
Handler error with exception: Token not valid.
=================
Traceback (most recent call last):
  File "/home/aries/.local/lib/python3.12/site-packages/aries_cloudagent/admin/server.py", line 310, in setup_context
    profile = await self.multitenant_manager.get_profile_for_token(
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/aries_cloudagent/multitenant/base.py", line 381, in get_profile_for_token
    raise MultitenantManagerError("Token not valid")
aries_cloudagent.multitenant.base.MultitenantManagerError: Token not valid
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/aries/.local/lib/python3.12/site-packages/aries_cloudagent/admin/server.py", line 141, in ready_middleware
    return await handler(request)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/aries_cloudagent/admin/server.py", line 212, in debug_middleware
    return await handler(request)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/aries_cloudagent/admin/server.py", line 326, in setup_context
    raise web.HTTPUnauthorized(reason=err.roll_up)
aiohttp.web_exceptions.HTTPUnauthorized: Token not valid.

In the coming days I'll post a PR to handle exceptions more gracefully, and help reduce the cases where stack traces are printed.

Passing a bad tenant token (cannot be decoded by jwt library) results in:
2024-10-31 12:07:33,884 acapy_agent.admin.server ERROR Handler error with exception: Unauthorized
=================
Traceback (most recent call last):
  File "/home/aries/.local/lib/python3.12/site-packages/acapy_agent/admin/server.py", line 310, in setup_context
    profile = await self.multitenant_manager.get_profile_for_token(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/acapy_agent/multitenant/base.py", line 365, in get_profile_for_token
    token_body = jwt.decode(token, jwt_secret, algorithms=["HS256"], leeway=1)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/jwt/api_jwt.py", line 211, in decode
    decoded = self.decode_complete(
              ^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/jwt/api_jwt.py", line 152, in decode_complete
    decoded = api_jws.decode_complete(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/jwt/api_jws.py", line 210, in decode_complete
    self._verify_signature(signing_input, header, signature, key, algorithms)
  File "/home/aries/.local/lib/python3.12/site-packages/jwt/api_jws.py", line 317, in _verify_signature
    raise InvalidSignatureError("Signature verification failed")
jwt.exceptions.InvalidSignatureError: Signature verification failed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/aries/.local/lib/python3.12/site-packages/acapy_agent/admin/server.py", line 141, in ready_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/acapy_agent/admin/server.py", line 212, in debug_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aries/.local/lib/python3.12/site-packages/acapy_agent/admin/server.py", line 328, in setup_context
    raise web.HTTPUnauthorized()
aiohttp.web_exceptions.HTTPUnauthorized: Unauthorized


Add Search Guard support

This PR adds basic Search Guard support. Version hardcoded to 5.1.1 currently because Kibana Search Guard plugin for 5.1.2 not yet released.
Default configuration of Search Guard in this repo is:

Basic authentication required to access Elasticsearch/Kibana
HTTPS disabled
Hostname verification disabled
Self-signed SSL certificate for transport protocol (do not use in production)

Close https://github.com/deviantony/docker-elk/issues/84

Sweet ! :trophy:


fix(dap): add debugger to filetypes mapping for launch.json

The .vscode/launch.json detection added in https://github.com/LazyVim/LazyVim/pull/1839 doesn't support many filetypes
This adds the support of debug adapter to file types mappings.

Thanks!


Floating "Visit the Cirriculum" button on forums

Describe the Issue
The "Visit the curriculum" text is floating outside of the tool bar.
Affected Page
https://forum.freecodecamp.org/
Steps to Reproduce

Go to the home page.
Look in the upper lefthand corner
See error

Expected behavior
It should remain stationary in the upper left hand part of the screen where it belongs.
Screenshots

System

Device: Desktop
OS: Windows 10
Browser: Firefox
Version: 123.0

Additional context
No response

Thank you for reporting this issue.
This is a standard message notifying you that this issue appears to be very similar to issue #53910, so we are closing it as a duplicate.
If you think we're wrong in closing this issue, please request for it to be reopened and add further clarification. Thank you and happy coding.


WIP: better use of store properties in irmin-pack

Note: this breaks the tests and the testing framework as dune exec -- test/irmin-pack/test.exe test LAYERED_PACK just never completes properly. @CraigFe or @icristescu do you know why this makes Alcotest unhappy?
Running the test manually gives:
$ dune exec -- test/irmin-pack/test.exe test LAYERED_PACK 2 -v
[...]
FAIL line lcas 1

   Expected: `[{ hash = 53d68d5787b8de001aa1f184d99b7ddfbfa8a2f2;
                 value =
                  { node = be233efe3beb0c78b12eba0d01c007ceccd9ba1a;
                    parents = [494e789634937fa382fb9bf6848b78ef64b1a0ee];
                    info =
                     { date = 3;
                       author = "test";
                       message = "Test commit" } } }]'

   Received: `[]'

@icristescu do you know where that could come from? Are flushing too often maybe?

@samoht: running with strace:
❭ strace -s 1024 dune exec test/irmin-pack/test.exe test LAYERED_PACK 2>&1 | tail -n 10
futex(0x559f46b08da8, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x559f46b08da8, FUTEX_WAKE_PRIVATE, 1) = 1
futex(0x559f46b08d40, FUTEX_WAKE_PRIVATE, 1) = 1
pselect6(4, [3], [], [], {tv_sec=0, tv_nsec=0}, NULL) = 1 (in [3], left {tv_sec=0, tv_nsec=0})
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
read(3, "\1\0\0\0\0\0\0\0", 8)          = 8
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
write(2, "Fatal error: exception Unix.Unix_error(Unix.ENOENT, \"unlink\", \"_build/test-db-pack/lock\")\nRaised at Stdlib__map.Make.find in file \"map.ml\", line 137, characters 10-25\nCalled from Sexplib0__Sexp_conv.Exn_converter.find_auto in file \"src/sexp_conv.ml\", line 156, characters 10-37\n", 278) = 278
exit_group(2)                           = ?
+++ exited with 2 +++

So looks like a lock file race condition causing a child to fail w/ ENOENT.

Closing and tracking via https://github.com/mirage/irmin/issues/1426


the current version depends on old versions of skll and nltk

Hi,
the current discourse parser requires specific skll and nltk versions: 0.27 of skll and 3.0.0 of nltk.
It will be great if the parser supports the latest versions of skll and nltk.

I've filed a separate issue to update skll. nltk was updated in develop through PR #45


Updated README.md

Description
I have made the README.md file more captivating.
Checklist

[x] I am making a proper pull request, not a spam.
[x ] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Fix #96
Add relevant screenshot or video (if any)

Hey @nilisha-jais ,
I have made changes in README.md file which is quite more attractive,
Kindly Review this PR !


Bust-a-Move 4: Can't connect on BizHawk

HintMachine version: Dev Branch
Game: Bust-a-Move 4 (PAL image)
Game / Emulator version: BizHawk 2.9.1 - Nymashock Core
Bug description
Doesn't connect. Setting breakpoints points to the RAM signature not being found.
Screenshots

Could be that the image wasn't dumped in the same way maybe?

It was working on the previous version that was on ePSXe though

The previous version of the connector didn't perform any kind of signature check.
I suspect it could be because we're using a different BIOS?
Inside Bizhawk's "Firmware" window, I see this:

Also, if you open hex editor and go at the same address, what do you see?

A second interesting test would be to comment out the signature check and see if the quest works (and if my guess is right, it should)

I have to step out. I'll give these a try when I get back.

Previous version was on ePSXe yeah, maybe we have to redo the thing for BizHawk

Same BIOS.
Memory region is completely different.

If I remove the RAM signature code, it connects but then does a bad read and immediately disconnects.
Are we sure this is really for the PAL version of the disc?

I think the reworked version using the generic BizHawk connector is not using the European version although the instructions say that's what's needed

I might have worked on the wrong version, I might have used an US image but I'm not certain and cannot verify at the time.
I'll double check tomorrow. Thanks for testing as usual.

Yeah it works with the US version, I think we'll switch description to US, 60Hz will be better anyway

Done in 89cd5cf


cmake, doc: Update build-osx.md

Following the instructions on a fresh install revealed a few inaccuracies.

@pablomartin4btc
Thank you for fixing the docs!
How about https://github.com/hebasto/bitcoin/commit/8f492874f92810771bd6ba0b4ed33833fe2a3315, which is more concise and does not assume autodetection of the sqlite package?
Feel free to grab it, if you agree.

Feel free to grab it, if you agree.

Yeah, it makes sense, thanks!


Ctrl and shift keys are not working with InputText.

When using ctrl to copy and paste from and to an InputText the frame rate starts going down until no keyboard input is received.
It takes some seconds before it is up to speed again and able to receive input.
When holding shift it also happens but a little slower.

Hey! I'll check this issue out, and hopefully, it'll be fixed with the next update.

That sounds great. Any idea when the next update is going to be? I am looking forward to following MonoGame.ImGuiNet.

That sounds great. Any idea when the next update is going to be? I am looking forward to following MonoGame.ImGuiNet.

Not sure, but maybe in a few weeks? Since I'm having some issues with my computer atm

If you need any help just ask.

Hey 👋
The issue should be fixed, and both BeforeLayout and AfterLayout were renamed to BeginLayout and EndLayout.


Bug: Calling to 'DeleteAll' operation with the list of PrimaryKeys and Transaction object is failing. Reported by Christian Franck.

The library is automatically committing or rollbacking the transaction when the DeleteAll operation is being called with the list of primary keys and transaction object.
The case was reported by Christian Franck of Orsted.
var rowsDeleted = connection.DeleteAll<OutagePeriod>(primaryKeys, transaction);

The author has investigated and it is a single-liner bug in RepoDb. The fix must be done at this line.
Set to 'false' value instead.

Deployed and is available at v1.10.11-beta1.


🐛 [ALL] Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.13)

Bug report
Describe the bug
MACOSX_DEPLOYMENT_TARGET for a number of the plugins' dependencies is too low, leading to warnings when running on macOS (and likely iOS). It seems at least PromisesObjC, GoogleUtilities, nanopb, GoogleDataTransport need to be updated.
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.10, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'PromisesObjC' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'GoogleUtilities' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.9, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'nanopb' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'GoogleDataTransport' from project 'Pods')

Steps to reproduce
Steps to reproduce the behavior:

git clone https://github.com/flutter/gallery
flutter run -d macos

Expected behavior
No warnings

@guidezpl Hello,
I tried the gallery demo app and got following in console:
Launching lib/main.dart on macOS in debug mode...
Updating minimum macOS deployment target to 10.14.

Indicating the tool seems to update the minimum deployment to the version as required. Does this help ?

No, on an M1 mac, this is what I get with Flutter @ HEAD
 flutter run -d macos
Launching lib/main.dart on macOS in debug mode...
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, id:00006000-000224643C38801E }
{ platform:macOS, arch:x86_64, id:00006000-000224643C38801E }
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.9, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'nanopb' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.10, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'PromisesObjC' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'GoogleUtilities' from project 'Pods')
/Users/plg/development/gallery/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.1.99. (in target 'GoogleDataTransport' from project 'Pods')

Thanks for the feedback. I am unable to see above logs running on Intel though:
dhs@Dhss-MacBook-Pro gallery % flutter run -d macos
Launching lib/main.dart on macOS in debug mode...
Building macOS application...
2023-02-22 14:43:12.890 Flutter Gallery[9853:137149] [Firebase/Crashlytics] Version 10.3.0
Syncing files to device macOS...                                   178ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

An Observatory debugger and profiler on macOS is available at: http://<IP_ADDRESS>:50992/t-bLCLespeU=/
The Flutter DevTools debugger and profiler on macOS is available at: http://<IP_ADDRESS>:9100?uri=http://<IP_ADDRESS>:50992/t-bLCLespeU=/

Keeping this issue open for team's insights.

I'm also seeing this after upgrading my host OS to MacOS 13.3.1. It seems that newer versions of XCode / on newer versions of MacOS don't support pods with a deployment target < 10.13 anymore?

/cc @Lyokone

All those warnings are from transitive dependencies from the native SDK. There is nothing we can do about it on FlutterFire. If you really want the warnings gone, you could update their deployment target from your Podfile using the post_install hook. Something like:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    if target.name == 'GoogleUtilities'
      target.build_configurations.each do |config|
        config.build_settings['MACOSX_DEPLOYMENT_TARGET'] = '10.13'
      end
    end
  end
end

Not sure of the unintended consequences, you're effectively telling it to use a deployment target it isn't designed for.


Remove IBM.SemeruRuntimeOpenEdition.JDK <IP_ADDRESS> to IBM.Semeru.21.JDK <IP_ADDRESS>

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/ibmruntimes/semeru21-binaries/releases/download/jdk-21.0.2%2B13_openj9-0.43.0/ibm-semeru-open-jdk_x64_windows_21.0.2_13_openj9-0.43.0.msi
OK
(Automated message - build 882)


(%Akoof) gen9tsaaa: fixing mistake with ori pom pom ban

%Akoof: "fixing mistake with ori pom pom ban"
Created via Iolanthe on Thu, 30 Mar 2023 14:26:28 GMT.

Fixed in bce4641


SVM change to reduce memory use

When SVM is computing the change in lake or reservoir volume as a function of water level, it retains a set of coordinates from each triangle objects derived from the Tinfour Delaunay triangulation.   These are intermediate results which are retained in addition to the Delaunay triangulation itself.  Once the full set of triangle coordinates are collected, Tinfour runs a summation operation to compute lake volumes.  To reduce memory use, this issue proposes to not retain the triangle elements.  Instead, it will maintain a set of running sums for each depth of interest and discard each triangle object (and associated data) as it is added to the sums.
Background
Tinfour, itself, avoids explicitly retaining triangle objects because of the high-memory use required to do so (instead, Tinfour retains edges and constructs triangles on an as-needed basis).  However, SVM runs a loop in which it collects triangles from the Delaunay triangulation, extracts their coordinates, and stores the relevant information in a set of objects that are used downstream to compute the depth-versus-volume values.  So memory must be allocated to store these coordinates. This is relevant because

In Java, the memory footprint for the data retained from each triangle is about 100 bytes
In a Delaunay triangulation, the there are approximately two triangles for each vertex
Many of the lake samples we process involve a large number of data points.  The Lake Victoria data set includes 17 million sample points, which leads to a memory of 3.2 gigabytes for the intermediate analysis.

Proposal
Rather than waiting until all triangle data is collected to perform the SVM calculations, this issue proposes to compute partial results as triangles are processed.  One set of partial results will be retained for each depth-of-interest (typically a few hundred depths at the most).
Even in the current implementation, the time required to perform SVM computation is not large.  The 17-million point data set requires only 40 seconds of real time.  But by reducing the number of objects that are created by the Java Virtual Machine, and reducing the amount of memory that needs to support them, the proposed approach should also expedite processing by a small degree.

Changes implemented and code pushed to repository.   In general, this modification reduces the memory use of the program by about 40 percent.


python binding for velocity based object control

Motivation and Context

Extending Python bindings to control object's linear and angular velocities.

https://github.com/facebookresearch/habitat-api/issues/356

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thank you for the PR.  Please see https://github.com/facebookresearch/habitat-sim#code-style for fixing the cpp_lint test.

@erikwijmans Thanks for pointing out. Fixed the cpp_lint.

you'll want to look at the VelocityControl structure.

See PR #571
I've added bindings for this now, so once this is ready all velocity functionality should be available in python. 😄 Thanks for prompting this!

Thanks a lot for the prompt response @aclegg3
I was confused between bullet based MotionType.DYNAMIC and MotionType.KINETIC.
There are getter/setter functions for bullet based control defined here as well- https://github.com/facebookresearch/habitat-sim/blob/ae6ba1cdc772f7a5dedd31cbf9a5b77f6de3ff0f/src/esp/physics/bullet/BulletRigidObject.cpp#L396 .
Is there a factor of accuracy while applying velocities with MotionType.DYNAMIC and MotionType.KINETIC. While using with the agent, would it be more accurate if used with MotionType.DYNAMIC enabled?

Is there a factor of accuracy while applying velocities with MotionType.DYNAMIC and MotionType.KINETIC.

Yes, there are a few key differences.

You can use MotionType.KINEMATIC without Bullet installed via the VelocityControl structure. There will be no collision detection (the agent can move through walls, floors, etc...) if commanded and will not be constrained to move on the NavMesh without some modifications. The setter functions wrapped in this PR will not affect MotionType.KINEMATIC objects.

An object with MotionType.DYNAMIC will still be affected by collisions, gravity, damping, etc... and you will only be setting the initial velocity before each simulation step. Don't expect accurate velocity control via this method unless you account for this by stepping the simulation more often for smaller timesteps. e.g. ( for(time): sim.step_world(0.00416) )

Solved by https://github.com/facebookresearch/habitat-sim/pull/571

Right okay, I think best would be to use MotionType.KINEMATIC without bullet compiled and control the agent via VelocityControl structure.


Train a CNN model to recognize face masks in real-time.
Create an interface to upload images or use a webcam for real-time mask detection.
Ensure the UI is intuitive and visually appealing.

Screenshots 📷

N/A

:white_check_mark: To be Mentioned while taking the issue :

Full name :
What is your participant role? (Mention the Open Source Program name. Eg. GSSOC, SSOC, JWOC, etc.)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Please assign this to me.
I will train a model to detect masks and use OpenCV to  do real time mask detection in both laptop and external webcams.
It will have options for both images and real time video.
Name : Chirag Gupta
Role : Contributor, SSoC

@ChiragGupta16 go ahead.


Tests: fix use of deprecated AbsolutePath.init in tests

This was also an opportunity to convert some of Result-returning properties to get throws effectful properties, which simplified some code.
cc @neonichu

@swift-ci please test

@swift-ci please test macOS

@swift-ci please test Linux

@swift-ci please test Linux

closing as superseded by #1231

Sorry @MaxDesiatov, completely forgot about this.

No worries, I couldn't merge it at that time, had no commit access for this repository. Looks like that has been resolved since then.


[CP] Fix a type casting error in text_input.dart

issue_link
https://github.com/flutter/flutter/issues/109632
Commit Hash
8caa14e6291667a972936ebc210380995e82f5df
Target
stable
pr_link
https://github.com/flutter/flutter/pull/114806
Impacted Users
All Flutter devs
Impact Description
The exception will be thrown during regular text inputs in a high frequency.
Workaround
Modifying Flutter SDK locally can solve the issue, which means no workarounds.
Risk
high
Test Coverage
yes
Validation Steps
Should check out the internal: b/240501546.

@HansMuller can you review this CP request? If it should be approved to stable, please add the cp: approved label to this issue.

This seems like a good CP however https://github.com/flutter/flutter/pull/114806 is failing some dashboard tests:
| Analyzing dashboard...
|
|   error • The method 'insert' can't be unconditionally invoked because the receiver can be 'null' • lib/widgets/commit_box.dart:59:25 • unchecked_use_of_nullable_value
|   error • The property 'context' can't be unconditionally accessed because the receiver can be 'null' • lib/widgets/task_grid.dart:363:76 • unchecked_use_of_nullable_value
|   error • The method 'insert' can't be unconditionally invoked because the receiver can be 'null' • lib/widgets/task_grid.dart:371:27 • unchecked_use_of_nullable_value
|
| 3 issues found. (ran in 10.0s)

Seems like customer tests are using APIs that are not changed in stable?

The customer tests failures are (unfortunately) expected. I'll go ahead and double check the tests tomorrow before merging.

I've submitted another PR for the request to see if test failures will be resolved but got no luck. https://github.com/flutter/flutter/pull/114923/checks

I've submitted another PR for the request to see if test failures will be resolved but got no luck. https://github.com/flutter/flutter/pull/114923/checks

We're cutting a new beta branch next week. I would recommend on holding off unless it's urgent.

We're cutting a new beta branch next week. I would recommend on holding off unless it's urgent.

I believe it's urgent and you can see this in https://github.com/flutter/flutter/pull/109635.

Released in 3.3.8.

I believe it's urgent and you can see this in https://github.com/flutter/flutter/pull/109635.

We'll be cutting a new beta next week based on flutter-3.6-candidate.0 which will include the fix.


Build changes to gradle 2.2.1 and new netflixoss plugin

This will create jdk7 bytecode. We can add a sourceCompatibility line if you prefer jdk6.
I removed the ide lines because the nebula.netflixoss plugin auto applies those.

eureka-pull-requests #414 SUCCESS
This pull request looks good

eureka-pull-requests #415 SUCCESS
This pull request looks good


Question on the usage of the server.

I understood the main purpose of the project's server is to create endpoints which will host one's own patterns of system.md instructions to then forward requests to the OpenAI API. Did I get this right?
I wonder if we could simply "bake" all of the ready to use patterns in the patterns folder into the fabric CLI directly and then make them discoverable via a built-in fabric --help command. We could perhaps allow users to add their own patterns (assuming they won't contribute them back to this repo) into our ~/.fabric/ config folder. Any folder name containing say ~/fabric/foobar/system.md would then become discoverable for and usable by the CLI.
Does that make any sense? I suppose the alternative is that people should manually add endpoints to the Flask API.
@danielmiessler Thoughts?

That's already available. If you don't use the server option, it does exactly what you were describing.


FBP-345. Fix for wrong element selection

Fixes: #345

Codecov Report

Merging #347 (28498e6) into master (696c3ad) will increase coverage by 0.02%.
The diff coverage is 80.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff              @@
##             master     #347      +/-   ##
============================================
+ Coverage     63.87%   63.89%   +0.02%
- Complexity     1347     1351       +4
============================================
  Files           203      203
  Lines          7036     7047      +11
  Branches        889      892       +3
============================================
+ Hits           4494     4503       +9
  Misses         2208     2208
- Partials        334      336       +2

Flag
Coverage Δ

unittests
63.89% <80.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../valb3r/bpmn/intellij/plugin/core/render/Canvas.kt
63.43% <80.00%> (+0.51%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


healthcheck: Allow non-200 status codes as healthy HTTP healthchecks

Title: healthcheck: Allow non-200 status codes as HTTP healthchecks
Description:
We have certain services that do not return a 200 on a successful healthcheck. The most common one I've seen is returning an HTTP 204. Envoy marks these as unhealthy because it is checking explicitly for a 200
I think a good default would be 2xx or 3xx is considered healthy. Whether a given status code should be considered healthy is up for debate, but i think this is pretty standard for proxies right now, and so i think it makes sense to do this.
For extra credit, we can have configuration for what constitutes healthy. e.g. regex check on the body of the response.

Just to add, a couple of useful isNxx functions are available here.

There are environments like kubernetes, where any 2xx response is considered healthy. We have many applications returning 204 as it has minimal size. This makes it hard to use envoy, because we would need to deploy healthcheck changes in many applications.
I understand you want to retain your 200-only healthcheck policy, but would you consider making this behaviour configurable?

Yes we can definitely make this configurable.

How would you like to have this behaviour configured? Possibly the simplest way would be to add a boolean, default false, field to HttpHealthCheck such as expect_2xx. I don't think there is a need to specify individual HTTP codes, but who knows...
I could probably make a PR with implementation.

@bartebor I know we have had other requests for configurable HC codes, so TBH it wouldn't be that bad to allow it to be fully configurable. What about just a repeated list of acceptable codes?

I'm fine with that. Would an expect_codes array of ints do?

@bartebor yup SGTM

I think it's more common to express this as a range, because the common settings are:

200 only
exactly code X (such as 204)
any 2xx or 3xx
any 2xx, 3xx, or 4xx

For each of the above, expressing it as a range is as-good or better. Or if you need extreme flexibility, a repeated range.

Yeah sure, range SGTM.

Ok, so now we have more options, and it becomes a little bit complicated. We could:

make expected code set a string, something like "2xx, 301-307, 401" - this is quite readable, but one must know string syntax and we would need a parser (should not be a big deal though)
repeated messages HttpCodeRange with either individual or wider range of codes; this objects could expose oneof properties for individual int code , bool any_2xx, bool any_3xx, and maybe {int from, int to} - this is the most flexible and well-defined approach

I would prefer some form of latter approach.
Which one would be in line with Envoy API guidelines?

@bartebor I would probably just use https://github.com/envoyproxy/envoy/blob/master/api/envoy/type/range.proto#L18. Technically you could make a new UInt64Range type if you want, but I would just do a repeated list of ranges and keep it simple.

Thanks for your suggestions. Now it's time to dive into coding and make it work. I'll get back with a PR when it's ready.


array of objects to alamofire put and post

I have array of mappable objects:
var arr = [MappableObject]

now i need to use Alamofire and .PUT method to save that array on server.
How can i do that?

@mirzadelic are you asking how to convert the array into a JSON string that you can submit to a server?

Yes, and to send it to server with Alamofire.

I just realized ObjectMapper doesn't have a method for generating JSON strings for arrays. I will add that shortly.
For now you can do the following:
var JSONString = "["
for object in array {
    JSONString += Mapper().toJSONString(object) + ","
}
JSONString += "]"

Now you can submit that JSONString to the server using Alamofire. If you have questions about Alamofire usage, please post those in the Alamofire Github issues.

I actually just pushed an update that includes the new toJSONString function that takes an array of objects. If you use latest on master you will have those changes.


Make ILogger context-aware out of the box

Consider the following base class:
public abstract class MessageHandlerBase<T> : IHandleMessages<T>
{
    private readonly ILogger _logger;

    protected MessageHandlerBase(ILogger logger)
    {
        _logger = logger;
    }

    public async Task Handle(T message)
    {
        _logger.Log($"START :: HANDLING {typeof(T)}");
        await HandleCore(message);
        _logger.Log($"END :: HANDLING {typeof(T)}");
    }

    protected abstract Task HandleCore(T message);
}

When inheriting from this class and letting roslyn or resharper generate the missing parts, you'll get something like this:
public class MyMessageHandler : MessageHandlerBase<MyMessage>
{
    public MyMessageHandler(ILogger logger) : base(logger)
    {
    }

    protected override Task HandleCore(T message)
    {
    }
}

When you try to run this, the DI framework will complain that ILogger is not registered. I would expect injecting an ILogger to try to resolve ILogger. Could we have this tiny QoL upgrade - ability to forego having to add silly generic arguments to simple stuff like ILogger - just for code generation to work properly please?

The DI container doesn’t expose enough context to implement this (nor can it because that would impose more requirements on other container adapters). So no, this can’t work out if the box. If you’re using a third party container however, it might be possible I write a factory for ILogger


[BEAM-12596] Validate that @GetSize always returns a value greater then zero.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem

Run Java PreCommit

Run Java PreCommit


Fix #308 - Add null check for removing item from uninitialized QuadTree

I was able to repro #308 NPE by trying to remove an item before any item was inserted - I added a test case that repro's this NPE at the beginning of PointQuadTreeTest.testMultiplePoints():
response = mTree.remove(item1);
assertFalse(response);

Adding a null check in PointQuadTree.remove() fixes this.

Awesome, can't wait for the merge.

@stephenmcd a friendly reminder to PTAL,  when you have a moment.  I was able to repro the bug within the unit test and then fix to make it pass,  so it's a pretty straightforward fix.

Thanks for the reminder! Looks good.

Thanks all


Insufficient funds (0) to process payments (12312.5); possibly waiting for txs.

i am deploying bitcoinz pool and my config:
Coin:
{
"name": "Bitcoinz",
"symbol": "btcz",
"algorithm": "equihash",
"requireShielding": true,
"txfee": 0.0001
}
pool:
`"coin": "bitcoinz.json",
"coin": "bitcoinz.json",
"address": "t1PPKiaskZsSXZb.....",
"_comment_address": "a transparent address to send coinbase rewards to and to transfer to zAddress.",
"zAddress": "zcNus9QdXx3skhE5KzQx9.......
"_comment_zAddress": "a private address used to send coins to tAddress.",
"tAddress": "t1JrZXDy5N......",
"_comment_tAddress": "transparent address used to send payments, make this a different address, otherwise payments will not send",
"walletInterval": 2.5,
"rewardRecipients": {
"t1diyf84HoFYztg.....":1.5
},
"tlsOptions": {
"enabled": false,
"serverKey":"",
"serverCert":"",
},
"paymentProcessing": {
"minConf": 10,
"enabled": true,
"paymentMode": "prop",
"_comment_paymentMode":"prop, pplnt",
"paymentInterval": 20,
"minimumPayment": 100,
"maxBlocksPerPayment": 1,
"daemon": {
"host": "<IP_ADDRESS>",
"port": 3333,
"user": "xxxx",
"password": "xxx"
}
},`
but always show the error
017-10-07 04:50:39 [Payments] [bitcoinz] Insufficient funds (0) to process payments (12312.5); possibly waiting for txs.
my balance
ubuntu@ip-172-31-34-70:~/bitcoinz-pkg$ ./zcash-cli z_gettotalbalance
{
"transparent": "12312.5001",
"private": "0.00",
"total": "12312.5001"
}
i changed
z-nomp/libs/paymentProcessor.js starting line 294
Code:
var amount = satoshisToCoins(zBalance - 10000);
// unshield no more than 100 ZEC at a time
if (amount > 20000.0)
amount = 20000.0;
But not work the pasyment process

How many RAM and zec/zcl/btcz nodes running on your server do you have?

only one BTCZ node, 512 RAM

512mb is not enough for shielding process

Yes, safe amount for shielding is 4 GB of RAM or more. Without this payment wont be prcoessed.

You can try by adding swap space

thanks guys.. i did all your recommendations..my VPS 1G RAM and 4G swap..
pool@btcz-pool:~/z-nomp$ ./zcash-cli z_gettotalbalance
{
"transparent": "0.00",
"private": "12312.4999",
"total": "12312.4999"
}
but.. allways show me.. this
2017-10-11 19:39:41 [Pool]	[bitcoinz] (Thread 1) Block notification via RPC polling
2017-10-11 19:39:47 [Payments]	[bitcoinz] sendTToZ is waiting, too many z_sendmany operations already in progress.
2017-10-11 19:39:47 [Payments]	[bitcoinz] Insufficient funds (0) to process payments (12312.496); possibly waiting for txs.
2017-10-11 19:39:47 [Payments]	[bitcoinz] Finished interval - time spent: 119ms total, 19ms redis, 102ms daemon RPC
2017-10-11 19:40:27 [Payments]	[bitcoinz] Shielding operation in progress opid-b284ebaf-0914-4a9c-aae1-0993a22c0219
2017-10-11 19:40:36 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 19:41:24 [Payments]	[bitcoinz] Shielding operation in progress opid-b284ebaf-0914-4a9c-aae1-0993a22c0219
2017-10-11 19:41:31 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 19:41:47 [Payments]	[bitcoinz] Insufficient funds (0) to process payments (12312.496); possibly waiting for txs.
2017-10-11 19:41:47 [Payments]	[bitcoinz] Finished interval - time spent: 174ms total, 106ms redis, 147ms daemon RPC
2017-10-11 19:42:21 [Payments]	[bitcoinz] Shielding operation success opid-b284ebaf-0914-4a9c-aae1-0993a22c0219  txid: 36e72f26a9c6b68d31aa5975f11ab25a33b9d56f262ef9343c57a6defcd59a47
2017-10-11 19:42:26 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 19:43:21 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 19:43:47 [Payments]	[bitcoinz] Insufficient funds (0) to process payments (12312.496); possibly waiting for txs.
2017-10-11 19:43:47 [Payments]	[bitcoinz] Finished interval - time spent: 20ms total, 12ms redis, 5ms daemon RPC
2017-10-11 20:18:37 [Payments]	[bitcoinz] Shielding operation success opid-05a24be1-4af7-48a4-83a8-e71114ee5de1  txid: 0eb48f4b29862fe123e78eedbf32597f76321cc17a4a6241ce6e6324a146b99d
2017-10-11 20:18:37 [Payments]	[bitcoinz] Shielding operation failed opid-4c8d2bd9-b111-4389-b315-24fb3f951325 -6, Insufficient funds, no unspent notes found for zaddr from address.
2017-10-11 20:19:31 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 20:19:34 [Payments]	[bitcoinz] Shielding operation success opid-05a24be1-4af7-48a4-83a8-e71114ee5de1  txid: 0eb48f4b29862fe123e78eedbf32597f76321cc17a4a6241ce6e6324a146b99d
2017-10-11 20:19:34 [Payments]	[bitcoinz] Shielding operation failed opid-4c8d2bd9-b111-4389-b315-24fb3f951325 -6, Insufficient funds, no unspent notes found for zaddr from address.
2017-10-11 20:19:41 [Payments]	[bitcoinz] Insufficient funds (0) to process payments (12312.496); possibly waiting for txs.
2017-10-11 20:19:41 [Payments]	[bitcoinz] Finished interval - time spent: 12ms total, 2ms redis, 4ms daemon RPC
2017-10-11 20:20:26 [Pool]	[bitcoinz] (Thread 1) No new blocks for 55 seconds - updating transactions & rebroadcasting work
2017-10-11 20:20:32 [Payments]	[bitcoinz] Shielding operation success opid-05a24be1-4af7-48a4-83a8-e71114ee5de1  txid: 0eb48f4b29862fe123e78eedbf32597f76321cc17a4a6241ce6e6324a146b99d

zcash-cli z_getoperationstatus shows what?
Seems like finds stay in z address

pool@btcz-pool:~/z-nomp$ ./zcash-cli z_getoperationstatus
[
]
today is working!! thanks Guys.. i'll invited the beers!!

I'm having the same error on Komodo.   The wallet seems to be just short like the smallest ammout.  Im sure it has to be what i am using on txs.  Any ideas.  I have a found about 75 blocks and it just now started.
Its not a ram issue.  I have 16 gigs and another 8 virtual.
2017-10-13 08:30:13 [Payments]	[komodo] Insufficient funds (0.20565227) to process payments (0.20565233); possibly waiting for txs.
Any clue what adjustments I need to make?

i upgraded RAM and created swap in the vps
You can try by adding swap space
Yes, safe amount for shielding is 4 GB of RAM or more. Without this payment wont be prcoessed.

Hi, I have the same problem:
but my founds was missing from my pool wallet!
https://explorer.bitcoinz.site/address/t1SMoBVY7mhXYFRuFrgsQguGRcMM2kqYoB7

Hi, now I saw this:
[Payments]  [bitcoinz] Insufficient funds (800) to process payments (12374.99999); possibly waiting for txs.
Also I don't understand very well payment process, I have this balance:
root@Pool:~/bitcoinz-pkg# ./zcash-cli z_gettotalbalance
{
  "transparent": "800.00",
  "private": "11574.9991",
  "total": "12374.9991"
}

And,  in pool_config/bitcoinz.json I have:
    "address": "t1SM.....B7"

    "zAddress": "zcZM......pQ"

    "tAddress": "t1Sk......GL"

    "rewardRecipients": {
        "t1b4....is": 1.0
    },

If I check transactions, I see:

T(Public) +12375,00 --> MINED --> t1SM.....B7
T(Public) +125,00 --> MINED --> t1b4....is
Z(Private)+12374.9999 --> IN --> zcZM....pQ
T(Public) -12374.9999 --> OUT --> Z Address not listed by wallet
Z(Private)+12274.9998 --> IN --> zcZM....pQ
T(Public) +100,00 --> IN --> t1Sk......GL
Z(Private)+12174.9998 --> IN --> zcZM....pQ
T(Public) +100,00 --> IN --> t1Sk......GL
Z(Private)+10274.9998 --> IN --> zcZM....pQ
T(Public) +100,00 --> IN --> t1Sk......GL

.....
I don't know why payments goes to
(address --> zAddress --> not listed --> tAddress --> ¿Miners?)
It's normal?
Thanks in advance!!

var amount = satoshisToCoins(zBalance - 10000);
// unshield no more than 100 ZEC at a time
if (amount > 100.0)
amount = 100.0;
change to
var amount = satoshisToCoins(zBalance - 10000);
// unshield no more than 100 ZEC at a time
if (amount > 20000.0)
amount = 20000.0;

jcreyesb,  did this solve your problem?
I am still having  it.

this should resolve the problem..

hi @neurans , @sennevb . I resolve problem, check

memory
swap https://www.digitalocean.com/community/tutorials/how-to-add-swap-space-on-ubuntu-16-04
paymentProcessor.js

var amount = satoshisToCoins(zBalance - 10000);
// unshield no more than 100 ZEC at a time
if (amount > 100.0)
amount = 100.0;

change to

var amount = satoshisToCoins(zBalance - 10000);
// unshield no more than 100 ZEC at a time
if (amount > 20000.0)
amount = 20000.0;

Charge a minimum of 10 coins in tAddress, during payment transaction I lose 0.0001 or 0.0002 fee, if I need to pay 12000 coins I only have 11999.9998, for this leave a minimum of coins in this tAddress for fee...

> "tAddress": "",
>     "_comment_tAddress": "transparent address used to send payments, make this a different address, otherwise payments will not send",

I had the same problems
after which I "maxBlocksPerPayment": 3,
set to 1, the matter was done


Go To Definition not working

I see in the README file that we are supposed to be able to right click on a function call and then go to the definition of that function.  When I do that I get the following No Definition Found for <insert function name>. Is there a setting we need to turn on somewhere or is this a bug?
Version: 1.45.0
Commit: d69a79b73808559a91206d73d7717ff5f798f23c
Date: 2020-05-07T15:57:33.467Z (6 days ago)
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 <IP_ADDRESS>
Extension version 0.1.5

The feature was worked successfully in my code.
May you post some parts of your code that trigger No Definition Found for ? I think the regex pattern something wrong with some case.

I created a sample repo at https://github.com/mbush92/urscript-test/tree/master/src/scripts with various sample functions.  The only definition or peek function I can make work is when the definition and usage of the function are in the same file, check out the add2Numbers() function, you can go to the definition in the file where it is defined, but not from the file beside it.
We have our code structured in folders like the examples in this.  We often define the functions in one folder and then we are using them in another folder.
Here is what I see when I try to go to the definition or use the peek function

But if its defined in the same file I get this:

I have the following extensions installed in this workspace

Hi @mbush92 ,
I have update v0.1.6, please update and try again 😄
The problem is ...
fs.readdirSync(workspace.uri.fsPath)

only get files in workspace.uri.fsPath (without subfolders). so I add a new function getAllFiles to search all files.
BTW, Go to definition and Hover only works when you use Open Folder... or Open Workspace.... The search will failed when use Open File... because workspace.uri.fsPath will be null.

Search failed when Open File...

Search successfully when Open Folder...

Thanks for the update, this is still not working for me.  I have disabled all other extensions and have tried opening as both a folder and a named workspace.  The one difference I can see is I am running a Mac and it appears you are running windows.
I will try to take a look at this as well and see if I can find any issues that would cause it to work on Windows and fail on Mac

Oh, that's really strange 😨
I will try to get a Mac OS virtual machine and try this issue on it when I have free time this weekend.

@ahernguo I was able to get VSCode installed on a Windows machine that I have (Mac running bootcamp) and I can say that this feature is working on Windows.  Man it sure is handy!  Have you had any luck figuring out what is going on with Mac?
Now that I know that it works I may try to poke around the code and see if I can find anything that would cause it not to work on Mac when I get a little free-time

Great NEWS!  I got it working.  I was able to finally find a message on the log(window) for the output tab on the terminal and noticed that there was an issue with a directory with a symboilic link

This directory did not even show up in VSCode but when I went to my file finder you could see there was a directory there and the link had been broken.  I deleted the directory and viola it all started working!!
Going to close this out now.

OK, that's really a good news 😁


Add Elastic Net algorithm

Add Elastic Net algorithm

CI: Id_ea5c5c4b-50bb-f199-8233-8cdcd4b723a1

Do you have any plans to include columnar heterogeneous data format optimizations for this pull request?


Anatomy {ext} vs. {representation} keys

At this moment it is used {{
{ext}
}} key in workfiles anatomy and {{
{representation}
}} elsewhere. We should use only ext because representation is not the same in all cases (e.g. thumbnail repre).
[PYPE-652] created by jakub.trllo

Also value for {ext} should always already contain "dot" (.ma, .nk, ...) -> In templates we should not use {subset}.{ext} but {subset}{ext}.

Is that because splitext return the value with the . by default?

Just opened discussion today. We should not care about this only in anatomy templates, but globally in pipeline where we are working with file extensions. In my point of view is dot part of extensions but I don't want to stuck with that opinion, just suggest possible solution of unification because we currently use both variants, with and without dots which is annoying and possible future bug. BTW: In avalon's workfiles are used extensions with dots, so we have to use .replace("..", ".") to be sure we're ok.


Why is _____ happening?

b 404 not found ?

You just launched C-REAL? did you try a command?

I deleted the news.txt that the bot will check for during startup
The 404 note found error is probably the bot was unable to find the news.txt that was here in the last update


[CardHeader] Do not pass CardHeader property titleColor to the DOM

Using the titleColor property on CardHeader, react gives a warning

"Warning: Unknown prop titleColor on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop"

Note that the titleColor works properly, the header text is displayed in the given color, the only problem is the warning.

@wuzzeb Thansk!


Jupyter Notebook Cell in Dark Theme in WSL not colored

Forwarding an issue that was priginally filed in the main vscode repo, but is still an issue
The TLDR; is that the dark theme in the jupyter notebook doesn't distinguish with colour between code cells and output (background)
https://github.com/microsoft/vscode/issues/104863
Environment data

VS Code version: 1.53.2
Extension version (available under the Extensions sidebar): ms-python.python
OS and version: Windows/WSL/Unix Remote
Python version (& distribution if applicable, e.g. Anaconda): 3.8.8 (deadsnakes)
Value of the python.languageServer setting: Pylance

Expected behaviour
See linked issue https://github.com/microsoft/vscode/issues/104863
Actual behaviour
See linked issue https://github.com/microsoft/vscode/issues/104863

Thanks for bringing it up @david-macleod. Our new Notebook Experience solves this. You can try it now with VS Code Insiders.
https://code.visualstudio.com/insiders/

Ok thanks!


Possible inversion of GteField and LteField

It appears that the GteField and LteField validators are inverted and comparing the wrong less/greater than.
Ex. Failing on "createdAt" : ISODate("2014-10-15T16:30:10.000Z"),  "updatedAt" : ISODate("2015-03-20T14:45:06.061Z")

Tested with the exact dates provided and validation is working as expected.


How do i get baseurl using restangular?

I only wanted to get the restangular baseUrl. how do i get only baseUrl ?

As far as I know, there's no way to do this. It wouldn't be that hard to implement a getConfig() method. Feel free to submit a PR if you want to.
I'm going to close this for now, since I did already answer it, but feel free to re-open if you need to elaborate more.


Add preset for memorial=stolperstein

We have a lot of those special memorial stones in Germany and both the Wiki(data)/Data Item and OSM Community are recording them. It think a preset would be a nice recognition of this work.
However, the tagging seems be in a process of change, so we need to find a good preset tagging here.
Here is my research:

Wiki https://wiki.openstreetmap.org/wiki/DE:Stolpersteine + Discussion https://wiki.openstreetmap.org/wiki/DE_talk:Stolpersteine
Should only apply for Germany since this is where most of those stones are (right?)
The recommended tagging changed in 2018 which was discussed on the forum and the wiki-talk-page and the wiki page shows the result of this change. It was not a formal voting proposal process, though
The existing tagging was never updated, which means the old tagging still has a lot more use

memorial=stolperstein 4.499 https://taginfo.openstreetmap.org/tags/memorial=stolperstein
memorial:type=stolperstein 24.784 https://taginfo.openstreetmap.org/tags/memorial%3Atype=stolperstein
I assume the other "unusal" tags will show similar numbers.

There are two JOSM presets which also still follow the old tagging guideline

https://josm.openstreetmap.de/wiki/Presets/Stolpersteine
https://josm.openstreetmap.de/wiki/Presets/StolpersteineLight

There is an active community adding this data as Wikidata Data Item, eg. https://www.wikidata.org/wiki/Wikidata:WikiProject_Stolpersteine with a map of this data => I think we should recommend Wikidata as a preset field as well

Preset
What tags to add to the preset:

historic=memorial – Required
memorial=stolperstein – Required, The presets reference

And not the IMO outdated memorial:type=stolperstein

name – Name of person

And not the IMO outdated memorial:name

inscription – Text on stone

And not the IMO outdated memorial:text

website – There are whole websites about his (example), which are useful to have so lets nudge users to add them
wikidata

More fields-Area:

image - Wikipedia image URL
memorial:addr – Wikipage was not sure which address, and I don't see it adding a lot of value, since this is geo referenced; therefore place in "more fields"
wikipedia- I would nudge for the wikidata ID instead, therefore place in "more fields"

What I would leave out:

memorial:ref=<123> – I don't understand where this official number should come from

Discuss
Questions we should talk about

See tagging above; @dieterdreist you wrote about this in 2018, what are your thoughts
How should iD handle the outdated tags? Should we add another, non-searchable preset for the old tags? Or even recommend a tag-update in iD?

Should only apply for Germany since this is where most of those stones are (right?)

Austria also has quite a few of them mapped: currently about 1.1k when including both tagging variants vs. 24k in Germany which is about the same order of magnitude when considering their relative population sizes. If I'm counting correctly, this leaves about 1.3k mapped objects remaining, most of which are probably scattered throughout Europe (I found about 230 in Italy and 100 in France, 70 in Spain).
According to wikipedia, these countries would in principle have Stolpersteine:

wikidata […] wikipedia

Wouldn't the subject:wikidata (and subject:wikipedia) tags be more appropriate?

from my understanding, subject:wikidata would be about the people who are commemorated on the stones, most of which are not famous and there is neither a wikidata nor a wikipedia article about them.

Since the raw wikidata tag should be about the individual Stolperstein memorials themselves, I assumed these would be even more unlikely to exist, but I was wrong: There are currently 16400 wikidata entries of individual Stolperstein memorials (14500 of which are geolocated – here's an example: https://www.wikidata.org/wiki/Q87722039). Not bad!

@tyrasd what are your plans on those issues that rely on https://github.com/openstreetmap/id-tagging-schema/issues/351. Can we move them forward for the time being and refactor them once there is more login in to im prove the situation for translators? Or do you consider them blocked until that issues is resolved?
I would love to see this present going. But also the bike related issues that I started a while back.

About the open discussion above:

wikidata vs. subject:wikidata

I the preset should stick with wikidata. Mappers are asked to add the wikidata entry of the corresponding stone, which is what the top level wikidata tag is for IMO.

How should iD handle the outdated tags? Should we add another, non-searchable preset for the old tags? Or even recommend a tag-update in iD?

To keep thinks simple, I would add unsearchable preset to at least show those old tags the same way. The question of how to harmonize the two schema can be raised later / elsewhere.


No license

This repo has no license applied. I believe it is intended to be publicly available, in which case it is probably important to clarify that intent (and explicitly limit author liability) with a common OSS license.

Thanks.  Fixed


RBD: TODO: check image needs flattening and completed? for clone/snapshot

Describe the bug
This issue is to track progress on
https://github.com/ceph/ceph-csi/blob/3c852199625333c8ccf8db18e592bb5627270d6b/internal/rbd/rbd_journal.go#L314

@Rakshith-R this is not required anymore?

@Rakshith-R this is not required anymore?

Yes this is no longer required.


Permit window resizing

Honor minimal size --- the one we have currently that fits the whole HUD. One difficulty of this issue is technical, catching the resize event and redrawing correctly. Another is generalizing various UI-drawing code to cope with bottom line having a different number, etc. It's mostly hard-coded now and sometimes wrongly bound to dungeon level size instead of windows. Lastly, the improved code should really use the extra screen space, not just pad with spaces.

To simplify things, let's stick to fixed window size per game (defined in game content) and let resizing only zoom the view by changing font scale. Then it reduces to #127. Closing in favour or #127.


Added A_star.cs

Assigned Issue Number ?
#597
Language Opted ?
C#
Number of files added or updated ?
1
Name of these files ?
Algorithms => Graph_Algorithms => A_Star => A_star.cs
example :
Algorithm => Search_Algorithm => Linear_Search => Linear_Search.py
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

@ahampriyanshu sorry, must have been some misbehaviour within gitkraken. i force pushed the corrected commit to my fork. is this enough, or do i need to create a new pr?


how to get rid of the gap between the left section and right section when window lost focus

environment

nvim-0.1.5 / macvim-8.0
vim-airline: lastest verson. with 'solarized' theme
OS: macOS 10.11.6

if you are using terminal:

terminal: tmux in iTerm
$TERM variable: screen-256color
color configuration (:set t_Co?):

actual behavior
there is a gap between the left section and right section when window lost focus.

expected behavior
how to make the gap invisible?

i cannot reproduce this. does it happen without screen? How about the gui?

reproduce by MacVim, ENV:

version:   VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Sep 14 2016 03:42:03) / MacOS X (unix) version
minimal .vim dir:  airline installed only
minimal vimrc:

set laststatus=2
let g:airline_powerline_fonts = 1
set guifont=Monaco\ for\ Powerline:h13

reproduce:

launch MacVim
open help page by ':h whatever'
back to the '[No Name]' window , and there is a  gap in "help page" window's status line

please check #1271


[3.12.2] adding {@inheritdoc} breaks phpstan

Following change in 3.12.2 breaks the phpstan
https://github.com/slimphp/Slim/compare/3.12.1..3.12.2#diff-0662ca8cf8d9ad2868ffab7a85a61847R21
Not sure if it's a slim regression or phpstan issue, See the relevant report in phpstan repo for more details: https://github.com/phpstan/phpstan/issues/2561
To workaround it in my code I had to change
$request = Slim\Http\Request::createFromEnvironment(Slim\Http\Environment::mock([...]));

to
/** @var Slim\Http\Environment $env */
$env = Slim\Http\Environment::mock([...]);
$request = Slim\Http\Request::createFromEnvironment($env);

Seems like a Slim issue https://github.com/phpstan/phpstan/issues/2561#issuecomment-552135751

Hi @jacekkarczmarczyk
PHPStan does not currently support overriding of @inheritdoc. But as I understand, overriding of @inheritdoc should be allowed, although there is no standard and PSR-5 is still a draft. Hence I think this is not really a Slim issue.

I understand, feel free to close the issue, workaround is fine for me

We could also change the phpdoc of \Slim\Interfaces\Http\EnvironmentInterface to return static and remove the override from \Slim\Http\Environment::mock().
interface EnvironmentInterface
{
    /**
     * Create mock environment
     *
     * @param  array $settings Array of custom environment keys and values
     *
     * @return static
     */
    public static function mock(array $settings = []);
}


Optimize to judge whether it is a power of two

Motivation:
Optimize to judge whether it is a power of two.please review the pr,thk.
Modification:
Result:
If there is no issue then describe the changes introduced by this PR.

@netty-bot test this please

the stack trace is:
io.netty.handler.codec.CorruptedFrameException: invalid JSON received at byte position 24:<PHONE_NUMBER>656420646f755c22626c652071756f746573205c2220696e204a534f4e207374725c22696e6722
at io.netty.handler.codec.json.JsonObjectDecoder.decode(JsonObjectDecoder.java:174)
Maybe I forgot to consider some aspects, so I'm going to make some changes to run this test case

I made a stupid mistake. . . , 1 is the power of 2, but here 1 should return false

So this is a wrong pr...can turn it off, sorry


Optimizer fixes and refactor

Changes:

api fixes so that all parameters get forwarded to underlying public methods in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/training/optimizer.py (this also solves global step issues)
refactor YellowFin optimizer to inherit from TF Optimizer class, like other TF optimizers
cleanup and small improvements (removed unused imports, some doc updates, removed trailing white spaces, improved formatting for better readability)

I've tested it as a stand-alone module in my current TF 1.2r Python 3 setup on multiple GPU-s, working okay.

Hi @mfernezir,
Thanks for the wonderful pull request on refactoring. It will be a great help to the smooth use in the community. It is super that it works smooth with multiple GPU now. We are very happy to merge the pull request!
As a double sanity check before merging, could you please do me the following favor:

Could you run the one or two of the experiments (ideally one LSTM and one ResNet) in the repo with  YF before/after the pull request, using a single GPU. Do you get reasonably similar performance? Maybe using the same random seed? (I totally understand even with the same seed, numbers maybe slightly different).

Could you please run synchronous multiple-GPU YF on an experiment in the repo? If it gives similar results as the single gpu results (using same effective batchsize, say single gpu use batch size 100 and 2-gpu each with 50 batch size), it would be strong evidence to verify the the multiple gpu version.

Thanks again for the contribution. Please let us know about the results.
Best

Hi! I've just started tests on CIFAR 10 on a single GPU. I'll have the results in the morning and post them later on tomorrow.
I am using Python 3 and there were some print issues that I had to fix, unrelated with this merge request. I'll setup TF 1.2. Python 2 for further tests.
For easier comparison, I have added tf.set_random_seed(1729) right after tf.reset_default_graph() in CIFAR10-release.py.
For multiple GPU tests, the scripts in this repository don't support that. However, the YF optimizer can be used as a stand-alone module and I have a framework at work that can take any TF optimizer. I don't have the exact networks that you have readily available, but I'll use it on our own convolutional networks that we are using for large scale image classification (millions of images and hundredths of classes). I'll run some tests in the next few days and post some results.
Regarding the actual merge request, I've thought about it some more and I'll make some additional changes. None of it should break anything and in any case, I'll test it again with my most recent version.

@mfernezir Thanks for the efforts and detailed info. Please keep us updated. :)

CIFAR 10 graphs look okay:
new_fig_loss_iter_40000.pdf
original_fig_loss_iter_40000.pdf

@mfernezir Thanks for the figures. Once you have a results from a multiple GPU setting, which is OK comparing to the 1 gpu case with the same setting, I will merge them to the repo. Please keep us updated.
Thanks

I have made some additional changes and updated the pull request description. Here are the new graphs for CIFAR 10, still looking very similar to the original implementation's graph like they should.
original:
https://github.com/JianGoForIt/YellowFin/files/1206803/original_fig_loss_iter_40000.pdf
new implementation:
v2_new_fig_loss_iter_40000.pdf
new implementation with Nesterov=True
v2_new_nesterov_fig_loss_iter_40000.pdf
I am going to do more tests later on today and tomorrow.

@mfernezir Thanks for the following up.
Our method is designed from Polyak momentum, slightly different from Nesterov's. Some of the argument/reasoning there might not strictly holds with Nesterov's. But it is great to see it also empirically works with Nesterov's momentum. My suggestion is keep default to be nesterov=False.

Sure, I've kept the default for tf.train.MomentumOptimizer which is use_nesterov=False.
Here are the comparisons for single GPU vs 2 GPU on a large classification dataset I'm working with.
Setup:

2 cards: batch size 128 for each card, optimizer = YFOptimizer(learning_rate=0.01, momentum=0.0)

1 card: batch size 256, optimizer = YFOptimizer(learning_rate=0.01, momentum=0.0)

1 card: batch size 256, optimizer = YFOptimizer(learning_rate=0.01, momentum=0.0, use_nesterov=True)

It would take a lot of time to fully train this dataset from scratch. Here are the results after one night of training:
Accuracy

Total loss

As you can see, all validation curves are close to each other and likewise for training curves in all three tests. In addition, I've tracked the internal optimizer._lr_var and optimizer._mu_var:
Learning rate

Momentum

Note that I had to reduce the initial learning rate to 0.01 or I would otherwise get NaN errors. This is surely related to the actual neural network choice (no batch normalization) and dataset at hand.
All in all, these plots confirm that the optimizer works as a standalone module in a multi GPU training framework.

Hi @mfernezir,
Thanks for all the efforts on the standardization of YellowFin. I have merged the PR.
Regarding lr=0.01, it is one possible solution. Alternative approach is gradient clipping, we have some users reporting it to be useful and give good performance.


Readme Typo

Hello,
I stumbled upon your file and when I went to use your example, I found you have a typo in one section

https://github.com/akiojin/decode-base64-github-action/blob/ede4b5ee0fdfa2e6160a70cff9f925f40a6653fe/README.md?plain=1#L46

I believe that line should match this one

https://github.com/akiojin/decode-base64-github-action/blob/ede4b5ee0fdfa2e6160a70cff9f925f40a6653fe/README.md?plain=1#L10

@mvirnoche
Thank you for your report.
We have corrected the problem.


this logic should go to ShopView but in data access layer, even it requires a second call to dao layer

https://github.com/nsaladie/MP03_POO_Shop/blob/623f9d16b64c47e192811347386c7e1448bea5bd/src/dao/DaoImplFile.java#L108

it is ok, it does not worth it use time to fix this extra functionality, it would require extra methods passing folder/file since view to dao, closed


Use Host URL as API baseURL

Signed-off-by: Frank Jogeleit<EMAIL_ADDRESS>What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

What this PR does / why we need it:
Add NodePort and Ingress support for API calls.
Which issue(s) this PR fixes:
Fixes #50

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 9a8e33a9842a37bd29455b39425dc224e811a9aa


Adding hindi translation

Pull Request type
Documentation content changes
What is the current behavior?
Resolves: https://github.com/keep-starknet-strange/madara/issues/926
What is the new behavior?
madara beast article.md is translated to hindi.
Does this introduce a breaking change?
No

@apoorvsadana Is it something you can review?

Hey @tdelabro, sure, I will try to review this in some time.

@gryptoo I have added some comments. Along with those comments, I noticed we are using exact English words in a lot of places. That's fine if we are using proper nouns like Starkware and Madara or techincal terms like L1s or validity proofs. But for general English words like consider, generate etc. we should ideally use the Hindi words. Otherwise, lgtm

@gryptoo can you take a look at the comments, please? Otherwise, @apoorvsadana can you take over this pr?
If there are no updates within the next week, I think we should close this cc @tdelabro

my bad, missed the previous comments. I'd used general english terms for words that aren't really used in colloquial hindi and would make the article confusing imo

@gryptoo, can you refer to which words you were talking about. I feel consider and generate have easy to understand hindi terms. Also, can you reply to the comments above as well regarding the typos/suggestions


MmGetSystemRoutineAddressEx doesn't exist

MmGetSystemRoutineAddressEx doesn't exist.
This API doesn't exist in the listed version of the Windows kernel.
Repro steps:
    RtlInitUnicodeString(&unicode_string, L"MmGetSystemRoutineAddressEx");
    *(PVOID*)&mm_get_system_routine_address_ex = MmGetSystemRoutineAddress(&unicode_string);

Expected result:
MmGetSystemRoutineAddressEx should be found.
Actual results:
MmGetSystemRoutineAddressEx is not present.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4873b0f3-f061-4fa1-de0c-ebb3b626dabe
Version Independent ID: 9783a8d3-b25a-bbfa-4a2e-19739c8afd78
Content: MmGetSystemRoutineAddressEx function - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-mmgetsystemroutineaddressex.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Hi @Alan-Jowett, thanks for the feedback.
(In your first sentence above you say MmEnumerateSystemImagesEx, but I'm pretty sure you mean MmGetSystemRoutineAddressEx since you use that in other references.)
I'm thinking you might be seeing this behavior due to the conditional that appears in wdm.h:
#if defined(XBOX_SYSTEMOS) || defined(XBOX_GAMECOREOS)

_IRQL_requires_max_(PASSIVE_LEVEL)
NTKERNELAPI
PVOID
NTAPI
MmGetSystemRoutineAddressEx (
    _In_ PUNICODE_STRING ModuleName,
    _In_ PSTR FunctionName
    );

#endif // defined(XBOX_SYSTEMOS) || defined(XBOX_GAMECOREOS)

Thanks, I fixed the title. My issue is that the MSDN doc appears to be wrong as it states minimum version is Windows 10, version 2004, which is clearly not true (kernel doesn't appear to have the symbol at all).

Just pushed a doc update to change the requirements listing to Xbox.  Should appear on the live site within 30 min.
Thanks for the head-up @Alan-Jowett!