binder has sympy 1.0

Need to change to master.

I was thinking about sympy@master to our anaconda channel, maybe under a dev label, don't know how to reference that in environment.yml though

dependencies:
  - pip:
    - https://github.com/sympy/sympy/archive/master.tar.gz

or if you want a specific commit,
dependencies:
  - pip:
    - https://github.com/sympy/sympy/archive/7efbee85cf49d767a11de8344b2b99b2b2460769.tar.gz

One of the packages in the env.yml seems to have a dependency on sympy, so removing sympy and adding this creates a double install of sympy.

It's python-symengine -- I was actually thinking about just that.

That's interesting. It's sort of circular to have sympy be a dependency of python-symengine.

I was wrong, it's only the tests that actually require SymPy:
https://github.com/conda-forge/python-symengine-feedstock/blob/master/recipe/meta.yaml

It is our own package... scipy2017codegen, so easily fixed. I'm on it.

Now we have sympy@master in our binder environment. Thanks @isuruf!
I just realized that the Docker image that binder v2 comes with does not contain gcc. I'll add a separate environment.yml called environment-binder.yml which also lists gcc as a dependency. Becuase I think most people prefer relying on system provided compilers, right?


Booting Bazzite-Deck hangs on 39.20240130.0.

Describe the bug

Booting into 39.20240130.0 hangs on a black screen with a single white "_" (underscore) character in the top left. In this state it is completely unresponsive and requires a hard shutdown.
Plugging in a USB keyboard and attempting to change TTYs with Ctr+Alt+F# is also unresponsive.
Pressing B/Escape to show boot logs shows the following error right before the hang: "[FAILED] Failed to start<EMAIL_ADDRESS>- User Manager for UID 1000"
Booting into 39.20241329.0 boots as normal with no issues.

What did you expect to happen?

That 39.20240130.0 should boot with no issues just like 39.20241329.0 does.

          OS: Fedora Linux 39 (Kinoite) x86_64
    .:cccccccccccccccccccccccccc:.        Host: Jupiter (1)
  .;ccccccccccccc;.:dddl:.;ccccccc;.      Kernel: 6.6.14-201.fsync.fc39.x86_64
 .:ccccccccccccc;OWMKOOXMWd;ccccccc:.     Uptime: 7 mins
.:ccccccccccccc;KMMc;cc;xMMc;ccccccc:.    Packages: 2776 (rpm), 174 (flatpak), 183 (brew)
,cccccccccccccc;MMM.;cc;;WW:;cccccccc,    Shell: fish 3.7.0
:cccccccccccccc;MMM.;cccccccccccccccc:    Display (ANX7530 U): 1280x800 @ 60Hz [Built-in]
:ccccccc;oxOOOo;MMM000k.;cccccccccccc:    DE: KDE Plasma 5.27.10
cccccc;0MMKxdd:;MMMkddc.;cccccccccccc;    WM: KWin (Wayland)
ccccc;XMO';cccc;MMM.;cccccccccccccccc'    WM Theme: CatppuccinFrappe-Classic
ccccc;MMo;ccccc;MMW.;ccccccccccccccc;     Theme: Breeze (CatppuccinFrappeBlue) [QT], Vapor [GTK2], Catppuccin-Frappe-Standard-Blue-dark [GTK3/4]
ccccc;0MNc.ccc.xMMd;ccccccccccccccc;      Icons: breeze-dark [QT], breeze-dark [GTK3/4]
cccccc;dNMWXXXWM0:;cccccccccccccc:,       Font: IBM Plex Sans (11pt) [QT], IBM Plex Sans (11pt) [GTK3/4]
cccccccc;.:odl:.;cccccccccccccc:,.        Cursor: Catppuccin-Frappe-Blue (24px)
ccccccccccccccccccccccccccccc:'.          Terminal: konsole 23.8.4
:ccccccccccccccccccccccc:;,..             CPU: AMD Custom 0405 (8) @ 2,80 GHz
 ':cccccccccccccccc::;,.                  GPU: AMD Custom GPU 0405
                                          Memory: 3,36 GiB / 14,47 GiB (23%)
                                          Swap: 0 B / 4,00 GiB (0%)
                                          Disk (/run/media/vagrantwinds/Bazzite-SD1): 769,02 GiB / 953,55 GiB (81%) - btrfs
                                          Disk (/run/media/vagrantwinds/Windows11-OS): 214,22 GiB / 256,00 GiB (84%) - fuseblk
                                          Disk (/sysroot): 1,40 TiB / 1,61 TiB (87%) - btrfs [Read-only]
                                          Local IP (enp4s0f3u1u1): REDACTED
                                          Battery: 100% [Full]
                                          Locale: en_DK.UTF-8

Extra information or context
The first entry listed there in rpm-ostree status fails to boot. The second (and third) entries boot with no issue.
Might be potentially related to https://github.com/ublue-os/bazzite/issues/724 ? Only in my case the Steam Deck refuses to boot into Gaming Mode/Bazzite-OS at all, instead of booting but into Desktop Mode like their issue. But the build where the issue happens and the inability to boot into Gaming Mood seems to be related?

PEBCAK/PICNIC  Error.
I had forgotten I had edited /etc/passwd last night to fix the prompt error of showing var/home/username in terminal instead of just ~ due to a default config error in silverblue/kinoite. Changing the user line from /home/username to /var/home/username fixes this.
My dumb self typo'd and forgot the / in front of var.And thanks to the quirks of read-only file systems I can't modify that change on that deployment, only the previous one.
Never mess with config files when half-asleep (especially when you don't remember you messed with them till hours later). I apologize for the bug report made in error.


Add docstrings to public functions

This PR fix this issue: https://github.com/iterative/dvclive/issues/755
I was inspired by the dvc.org documentation for most arguments and descriptions. Let me know if you were hoping for something more technical.
I'm still struggling to find a nice description for cache, post_to_studio and save_dvc_exp. If you could enlighten me so I can finish this MR, that would be great.
I notice some missing type hints in the methods. I would love to correct those, but I'll do it on another PR.

[x] ❗ I have followed the Contributing to DVCLive guide.
[x] 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thanks @AlexandreKempf! The one question I have is how much to make the docstring match the actual docs. It looks like you copied a lot from the existing docs but also added or changed the language in some parts.
We aren't likely to auto-generate the docs from the docstrings anytime soon (the docs include some additional info that wouldn't fit well into docstrings, and the docs are integrated with the rest of the products and we don't want to take on a project to separately generate them with a different engine). However, if we don't have some guideline on how to keep them in sync, I worry we will end up having to review two sets of docs for every change we make.

Yeap I 100% agree @dberenbaum!
There will always be a problem with syncing documentation on change if we don't autogenerate one or the other.
Maybe we need to discuss who the readers for both docs (website and docstrings) are :)
My feeling (and the way I wrote this initial PR) is:
The website doc feels like it was designed for developers (technical terms, lots of code blocks), especially the API reference part we are discussing. My personal feeling is that the docstrings also target technical people. There are only two advantages over the web doc that I see:

when you don't have internet but DVClive is already installed. This means that there is no problem with having a duplicate between the web doc and the docstring (except for maintenance cost).
when you just want a quick glimpse at the doc from VScode. This means that the docstring can be much shorter than the web doc.

What would you suggest the readers are? Do you see additional use for docstrings? How would you change the current PR according to these points? Do you think there is a need for docstrings or correct and extensive typing is enough?

@dberenbaum I took your comment into account. Docstrings are now literally the same as our official doc!

I think one of the next steps here is to have some good quick start snippets as well or links to them in docs string ... so that people can copy / paste basic stuff. Good work, thanks @AlexandreKempf !

@shcheklein 100% agree. Let's do that in another PR :) I'm creating an issue.

@AlexandreKempf Feel free to merge approved PRs. Do you have access to merge?


GDCM JPEG2000 compliance tests

PR Checklist

[ ] :no_entry_sign: Makes breaking changes
[ ] :no_entry_sign: Makes design changes
[ ] :no_entry_sign: Adds the License notice to new files.
[ ] :no_entry_sign: Adds Python wrapping.
[X] Adds tests and baseline comparison (quantitative).
[X] Adds test data.
[ ] :no_entry_sign: Adds Examples to ITKExamples
[ ] :no_entry_sign: Adds Documentation.

@issakomi reviews are welcome.

I don't have currently testing build, but i don't remember any issues with reading JPEG2000 ICT and RCT images. BTW, there is one small issue in debug mode with scalar JPEG2000 images sometimes, discussed in this post.


Swipe back on Android and iOS

I wish a TransistionType that supports the swipe back gesture on both platforms.
That would be so nice!
Or is there a simple way to do it ?
Thank you! 👍

I want too


move chart source into chart folder

Despite the fact source-folder is configurable, code makes silly
assumptions and got broken if chart source is hidden depper than one
directory. It is cheaper for now to switch to default chart location.
Signed-off-by: Dinar Valeev<EMAIL_ADDRESS>

https://github.com/dave-mcconnell/helm-gh-pages-microservices/blob/master/index.js#L59
results into chart packaged into samlet/sourceRepo/destinationRepo/charts which is definetely wrong


Feature: Fake Responses

The idea is to create an environment variable or a launch argument which when set to true will use the fake responses if available.
This will remove the dependency of server while developing modules.

Fyi - I’d encourage leveraging this code base
OHHTTPStubs
https://github.com/AliSoftware/OHHTTPStubs/blob/master/Examples/Swift/MainViewController.swift
I took this code one step further and allowed Charles saved traffic to replay with one line
https://github.com/johndpope/HAR-playback-swift

Thanks for sharing!
OHHTTPStubs are good but adding it as a dependency is something I would like to avoid. I am thinking more of a variable containing response as a string that will simulate the actual API on the basis of launch argument.
So it is more aligned to testing your views with the api contract before the actual api is created.
I am not sure about the implementation right now and what all things to consider while implementing this functionality.
Thoughts?

I've seen this cruder approach with json string payloads from junior coders - when the end point api  mutates - you end up with a bunch of rotten code.
It also leaves a lot of case switching out to if test // load this string just creates a pile of poo.
You can always fork OHHTTPStubs and simply rename it StubFire
The crux of use case from my POV -  boils down to
enable stubbing
intercept specified end points.
if url == "/getFriends"
then load /parse using alamofire from a corresponding versioned json file with http status code 200.
api changes / load a different one.
disable stubbing.
Here's some code I crafted to load a response from swagger.
https://gist.github.com/johndpope/009b9301ef422daca4c3588aad7b337b

https://github.com/AliSoftware/OHHTTPStubs/blob/master/Examples/Swift/MainViewController.swift
If you want to avoid  third party dependencies - then by that rational you're also saying you want to not include Alamofire - which is crazy talk.

Thanks for sharing links. HAR-playback-swift looks very cool.
And nothing against using third party libraries but stubbing is a part of testing. Adding OHHTTPStubs as a dependency will force users to embed the framework inside their IPAs which they won't want to do. I will let users add them separately and create their own stubs.

you can target framework dependencies for different build configurations.
eg.
pod 'OHHTTPStubs'  #, :configurations => ['Debug']

Thanks! Will investigate how can this be integrated with Carthage and SPM also.


Split globals and global variables, provide eloquent global variable repository

If/when https://github.com/statamic/cms/pull/8343 lands in core we need to be ready to support an eloquent global variables repository.
This draft PR is a work in progress to move towards it.
It also relies on https://github.com/statamic/eloquent-driver/pull/168 being merged.
Closes https://github.com/statamic/eloquent-driver/issues/172

@jasonvarga any idea why StyleCI is broken?

Thank you

Not sure why it wasn't working though. 🤷


Support for parallel testing?

About
Currently, the tests are failing when running in parallel (unable to start the worker).
To run tests in parallel, I'm using --parallel flag available in Pest v2 (uses brianium/paratest under the hood).

Strange it should work with integrated server.
It fails randomly or always?

Always.

Can you try to enable debug and see if there is something useful in the error?
In my project it works so I need some more info to debug the issue

Can you try to increase the sleep time in TemporalTestingServer::startTemporalServer (line 81) and see if it works?

The config is updated at runtime when running test in parallel mode:

When running with TEMPORAL_TESTING_SERVER=true (which runs the integrated server) it changes the port so it runs a temporal server for each testing process.
When running with TEMPORAL_TESTING_SERVER=false (so you need to run a temporal server externally) it changes the namespace to avoid conflicts (if namespace is default, it would become default-1, default-2,...). In this case the namespaces must be created in the temporal server before running the tests (the test server started with php artisan temporal:server creates the namespaces dinamically)

@michael-rubel I've build a docker image with the temporal dev server (useful for CI or local)
You can find it here if you want to give a try
To use it with parallel testing you need to create the required namespaces on start:
# Example for 4 processes
docker run -p 7233:7233 -p 8233:8233 keepsuit/temporalio-dev-server -n default-1 -n default-2 -n default-3 -n default-4


feat: agent install prompt & nci

As per https://github.com/antfu/ni/pull/5
Here's the agent install prompt feature.
nci PR https://github.com/privatenumber/ni/pull/2

Thanks! The nci looks good too and let's have it ;)

Just merged nci in
Thanks @antfu

Thanks!


Dynamic transaction fees

Description
First draft

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Updated to simplify how the transaction fees are split up.
The new proposed way is to split them int a known part and unknown part (for the lack of better words). The only way to the unknown part is to actually run the transaction.

Nice proposal, I know for sure you calculated, but what is the current situation with transaction fees vs staking rewards for nodes? How much percentage of the rewards coming from transaction fees?
I am curious how transaction fees will scale as network scales. Economic side of things are pretty interesting.

@bluesign There is an event that indicates how many rewards come from fees every week and last week, that number was a bout 13.9 FLOW, so currently that puts it at about 0.001% coming from fees currently, but that number should go up as we enable this fee structure and the chain gets more and more usage.
reference:
https://flowscan.org/transaction/df669cd5b615708e54d5589761906ca5137d4860f1f78a11ea3bed48ff458e82?eventTypeFilter=A.8624b52f9ddcd04a.FlowIDTableStaking.EpochTotalRewardsPaid

How is the priority given to 2 different users aiming to get their transaction done ? Is it on a FCFS basis ? or other rules ? Hope it is not like Ethereum where it is basically designed as an auction where the one who pays more gets his transaction first.

How is the priority given to 2 different users aiming to get their transaction done ? Is it on a FCFS basis ? or other rules ? Hope it is not like Ethereum where it is basically designed as an auction where the one who pays more gets his transaction first.

Without going into details and edge cases on how network latency and other network attributes affect the transaction ordering, we can say that the transaction ordering is based on the time a transaction was received. Also, the fee is determined by the network based on the resources your transaction consumes, so a user can’t give their transactions priority by offering to pay more.


Increment time every minute and remove timer for battery percentage

Hopefully this should increase battery time...

This requires more testing...


:printer: weird print with -err option

If I type up -err and there is no errors, eMerger prints twice "No errors found"

Line 33 of emerger.sh
elif [[ $ARGV =~ "-err" ]]; then
    if [[ *finds error* ]]; then
        puts RED "Errors found\nOpen .log in $ROOT to see what's wrong"
    else
        puts GREEN "No errors found"
    fi

It's intended!

I didn't read "twice"

Line 33 of emerger.sh
elif [[ $ARGV =~ "-err" ]]; then
    if [[ *finds error* ]]; then
        puts RED "Errors found\nOpen .log in $ROOT to see what's wrong"
    else
        puts GREEN "No errors found"
    fi

It's intended!

I didn't read "twice"

I see

I can't reproduce this issue... I guess it works on my machine!

At the moment it works on my machine too. I don't know why it occured this thing

Perfect, we can't see the bug, the bug is not there!


Show profile picture and status in buddy list

 Fixes #19999.
This PR does not contain the display settings (which is mentioned in the issue). As per the discussion on CZO ,display setting can be implemented after it is tested on CZO
Testing plan:
GIFs or screenshots:

Update:
Made circle border 1px solid and circle radius 4px

There's several issues with the visuals here, see the feedback in https://chat.zulip.org/#narrow/stream/101-design/topic/display.20status.20and.20profile.20picture.20in.20right.20sidebar.20.2321035/near/1338145
I think the other technical thing that we need to do here is support the old view and new view at the same time -- this means you can't make unconditional CSS changes; instead, we need them to be conditional on a new global CSS class for the sidebar.  You can probably do this part without introducing a major setting by having the UI for toggling whether we're doing this view or the existing view to be manually adding a CSS class on #user_presences using the browser inspector.
(We'll want to implement a setting following the new application feature tutorial as well, but that's essentially orthogonal work to making this decently polished).

closing in favor of #32128


GlobalProtect description fields

Hey guys!
I was reviewing some of the GP logs in our deployment to get a better sense of what is being captured.
I see that the following are extracted from the description field:

user
src_ip
agent_version
agent_message

However, I took a quick pull of the different 'header' fields, and 'Message' doesn't seem to exist anymore.
Instead, here is a sample of what I'm able to pull from last 24h of GP logs:

Auth type
Client OS version
Client version
Config name
Device name
Login from
Private IP
Reason
User name
VPN type
error

Only 4 of these are currently captured. Can we update for the rest of them? I'm particularly interested in the Device name, Reason, Auth type, and error clauses. I can customize myself, but wanted to share w you guys as well.
Thanks!

Resolved in App/Add-on version 6.3.1 and PAN-OS 9.1.0. GlobalProtect logs are now a distinct log type with parseable fields supported by Splunk.


Move util functions into utils.py

Util functions like converting iso to dt objects or display name and id checks could be moved in a user accessible utils file

Thanks for the suggestion. The change will be available from v3.0.0


Reformat the output filename -- 1) make it shorter; 2) check how unicode works and change extension accordingly

Currently the plaintext input filename that comes from OpenAI's Whisper is usually something like: SID0574.mp3.txt
Please reformat the paragraph chunked output filename so that everything after the first period is truncated and then followed by ".txt"
A successful output file should then look like: SID0574.txt (or possibly SID0574.rtf but see below.)

If Unicode is present please check to see that a browser will open the .txt file and show the Unicode characters correctly.
If it does not we will have to change the default output to a file format that supports Unicode such as .rtf.
.rtf supports Unicode but it is not clear to me that modern browsers show .rtf files correctly.  If .txt does not show unicode characters properly please try testing the same output file with a .rtf file extension and see if a browser opens and displays it properly. If it does then change the default output extension to .rtf.
See: https://stackoverflow.com/questions/55212444/unicode-characters-within-text-document-display-on-browser

Looking back at this issue -- the problem is that currently output files that include unicode, such as music symbols, don't process correctly in Quint, not that the .txt file is the incorrect file type to use for unicode ( https://sites.psu.edu/symbolcodes/software/textfile/ )   -- so is there a way to address that issue such that Quint will accept, and output, all characters including Unicode?

as such this issue is already listed https://github.com/V3ntus/quint/issues/1


Build from master fails/inconsistent on macOS 10.12

Hey everyone, trying to build atom from master branch. I have been successfully building and installing it up until today when I ran my usual
script/build --code-sign --install
NOTE: After upgrading git to 2.10.1 from 2.10
Then build failed with the following output
~ ➜ atom-build
Node:	v6.7.0
Npm:	v3.10.8
Installing script dependencies
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.

gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:305:16)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Darwin 16.0.0
gyp ERR! command "/usr/local/Cellar/node/6.7.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/kononnik/git/atom/script/node_modules/minidump
gyp ERR! node -v v6.7.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm ERR! Darwin 16.0.0
npm ERR! argv "/usr/local/Cellar/node/6.7.0/bin/node" "/usr/local/bin/npm" "--loglevel=error" "install"
npm ERR! node v6.7.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the minidump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs minidump
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls minidump
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/kononnik/git/atom/script/npm-debug.log
child_process.js:506
    throw err;
    ^

Error: Command failed: npm --loglevel=error install
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.

gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:305:16)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Darwin 16.0.0
gyp ERR! command "/usr/local/Cellar/node/6.7.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/kononnik/git/atom/script/node_modules/minidump
gyp ERR! node -v v6.7.0
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm ERR! Darwin 16.0.0
npm ERR! argv "/usr/local/Cellar/node/6.7.0/bin/node" "/usr/local/bin/npm" "--loglevel=error" "install"
npm ERR! node v6.7.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the minidump package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs minidump
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls minidump
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/kononnik/git/atom/script/npm-debug.log

    at checkExecSyncError (child_process.js:483:13)
    at Object.execFileSync (child_process.js:503:13)
    at module.exports (/Users/kononnik/git/atom/script/lib/install-script-dependencies.js:10:16)
    at Object.<anonymous> (/Users/kononnik/git/atom/script/bootstrap:26:1)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)

It seems to be complaining about missing XCode tools and node-gyp rebuild but

I have Xcode CL tools installed (that's how I got brew package manager working).
I use latest git and node from brewmaster
No build failures until I updated todays git which I highly doubt is causing troubles.
latest npm installed as well, I check on daily basis.
Reboot and all standard troubleshooting like script/clean were performed to no avail.

Please advise!

After reinstalling Xcode CLT once again it downloaded a new version 8.0 instead of 7.3 most likely due to an upgrade to macOS 10.12.
Here is the kicker, build seems to be going fine but now it throws a clang deprecated warnings.
atom-build
Node:	v6.7.0
Npm:	v3.10.8
Installing script dependencies
	xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
Installing apm
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

In file included from ../src/main.cc:1:
In file included from ../node_modules/nan/nan.h:196:
../node_modules/nan/nan_maybe_43_inl.h:220:17: warning: 'CloneElementAt' is deprecated [-Wdeprecated-declarations]
  return array->CloneElementAt(GetCurrentContext(), index);
                ^
/Users/kononnik/.node-gyp/6.7.0/include/node/v8.h:3032:36: note: 'CloneElementAt' has been explicitly marked deprecated here
                MaybeLocal<Object> CloneElementAt(Local<Context> context,
                                   ^
In file included from ../src/main.cc:1:
In file included from ../node_modules/nan/nan.h:202:
In file included from ../node_modules/nan/nan_new.h:189:
../node_modules/nan/nan_implementation_12_inl.h:40:29: warning: 'New' is deprecated [-Wdeprecated-declarations]
  return v8::BooleanObject::New(value).As<v8::BooleanObject>();
                            ^
/Users/kononnik/.node-gyp/6.7.0/include/node/v8.h:4007:56: note: 'New' has been explicitly marked deprecated here
  V8_DEPRECATED("Pass an isolate", static Local<Value> New(bool value));
                                                       ^
In file included from ../src/main.cc:1:
../node_modules/nan/nan.h:2017:15: warning: 'SetAccessor' is deprecated [-Wdeprecated-declarations]
  return obj->SetAccessor(
              ^
/Users/kononnik/.node-gyp/6.7.0/include/node/v8.h:2751:22: note: 'SetAccessor' has been explicitly marked deprecated here
                bool SetAccessor(Local<Name> name,
                     ^
3 warnings generated.
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^
1 warning generated.
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

../deps/libgit2/deps/zlib/inflate.c:1507:61: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
    if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
                                                        ~~~ ^
1 warning generated.
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
Installing modules

Otherwise it seems to be building just fine. Might be something Atom team wants to take a look at?

Fast google search got me this https://github.com/nodejs/node-gyp/issues/569. Check it I suppose it will solve your problems.

@stereobooster build no longer fails + solution there is no viable, I saw it. I do not wish to install a 4GB Xcode which i am not going to use so I only install xcode command line tools instead.


Show better error message on lapsed account

Feature request
I'm submitting a proposal to ...

[ ] new feature
[x] change an existing feature

Describe your request
On an account that needs renewal (that I didn't know about), I get the standard “check the log file” error when trying to access any user.
Looking at the log file, this shows up in the stack trace
2020-07-12 21:43:21.470 T:2227532656   ERROR: [plugin.video.netflix (0)] IPC callback raised exception: FORMER_MEMBER

In those cases, it would be good to show a modal dialog, rather than a notification, explaining that the account needs reactivating.
Traceback
2020-07-12 21:43:21.471 T:2227532656   ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 185, in make_return_call
                                                result = call(instance, func, data)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 209, in call
                                                return func(instance)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession_base.py", line 35, in ensure_login
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 85, in fetch_initial_page
                                                api_data = self.website_extract_session_data(response, update_profiles=True)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 273, in website_extract_session_data
                                                return website.extract_session_data(content, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/logging.py", line 143, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/api/website.py", line 94, in extract_session_data
                                                raise InvalidMembershipStatusError(user_data.get('membershipStatus'))
                                            InvalidMembershipStatusError: FORMER_MEMBER
2020-07-12 21:43:21.477 T:2114220912   ERROR: [plugin.video.netflix (7)] IPC call fetch_initial_page returned InvalidMembershipStatusError: FORMER_MEMBER
2020-07-12 21:43:21.478 T:2114220912   ERROR: [plugin.video.netflix (7)] Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 207, in run
                                                route([part for part in g.PATH.split('/') if part])
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 38, in lazy_login_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 72, in route
                                                _execute(nav_handler, pathitems[1:], g.REQUEST_PARAMS)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/run_addon.py", line 100, in _execute
                                                executor(pathitems=pathitems)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/navigation/directory.py", line 59, in root
                                                common.make_call('fetch_initial_page')
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/logging.py", line 143, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 88, in make_call
                                                return make_http_call(callname, data)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 118, in make_http_call
                                                _raise_for_error(callname, result)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 173, in _raise_for_error
                                                raise apierrors.__dict__[result['error']](result['message'])
                                            InvalidMembershipStatusError: FORMER_MEMBER

thanks for the info
there are a lot of unknow error codes
i will add a message


Uploading the captions does not work

Hi. I tryed to upload images and captions txt files to Instance Images cell, and get this. All images saved as png.
If I tried to upload captions manually, that is, directly to the caption s folder,  the neural network did not see them during training, as if they did not exist at all.

are you using the latest notebook ? https://colab.research.google.com/github/TheLastBen/fast-stable-diffusion/blob/main/fast-DreamBooth.ipynb

yes, I followed your link, the same error

I'll check it out

Launched Instance Images cell, selected png images and txt files, after uploading all the files gives this error when it comes to the first txt file.
it seems that for some reason this uploads txt into both the captions folder and the instance folder.

that error was fixed, the process is to make two lists, one for the txt files and one for the images, then send each list to a different folder, I tried doing what you mentioned and it worked perfectly, try only one images with only one txt file and see if there is an error.

I'm having the same error.

try with on image and one text file


fix: Provider cache and resolver are accessed safely

Flaky test, but could reproduce this every 3/4 runs:

testConfidenceContextOnContextChange seems to still be flaky

New flaky test spotted and hopefully fixed

More errors: testResolveAndApplyIntegerFlagError

"testResolveAndApplyIntegerFlagError" hopefully fixed in latest commit


Fixes #9 Remove non-functional features

If possible these changes should be tested and reviewed before merging. If the reviewer doesn't know how to set up a local version for testing we can walk through it.

Went in a different direction.


refactor(http): Remove HTTP wrappers

Why?

Seriously jank
Restricts what you can do (and forces you to use _request when you are missing something)
Less magic with switching between form data and JSON
Maintaining them is a huge pain, every time a optional arg/kwarg is added, we have to go through every single HTTP wrapper and add the param and documentation. This has caused issues in the past like #37

This does cause a worse developer experience for simple cases sadly, however should be better for more complex cases.
Better documentation / examples might remedy this.
TODO

[ ] Update examples
[ ] Create documentation around creating your own Routes and using them
[ ] Fix gateway references

so long HTTP wrappers 😢


CAMEL-13741 - Allow to convert a Map to an Iterable

The conversion from Map to Iterable used to be handled by the converter CollectionConverter.toSet(Map<K,V>)
Now that ObjectConverterOptimised is used before searching for a converter the Map to Iterable converter need to be handled at ObjectHelper.createIterable() level.

Hello @oscerd ,
I did your requested changes and replaced my commit.
Tell me if you need something else.

Looks good, I'm merging. Can you please create a PR on camel-2.x? I'll backport where needed.

Merged on master. Thanks

Thank you for merging it


Bug of recognizing a JavaScript comment instead of URL

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: October 2021 (version 1.62)
OS Version: 21354.1

Here is a picture for contract:

Please share the text of the code along with screenshots
/needsMoreInfo


edit_submission_section template: fix switched breadcrumb links

Oops. these links were the wrong way round.

I'm creating a tech debt ticket to rename these views to something less confusing...


[UNDERTOW-1762] Error page for custom exception-type is not is not displayed in jsp development mode

https://issues.redhat.com/browse/UNDERTOW-1762

This causes a failing TCK test: https://github.com/eclipse-ee4j/jakartaee-tck/blob/8.0.2/src/com/sun/ts/tests/servlet/spec/errorpage1/URLClient.java#L101 The problem is when a custom exception extending ServletException is wrapped in ServletException and that custom exception is used in mapping.
Maybe the mapping check should be performed for each level of unwrap?

Ah, yes, made an adjustment to fix that.


[feat]: react-hook-form output is in order of the visual list

Feature description
Changing the sort order of the list does not change the output in the react hook form, it would be amazing if that order can also change.
Additional Context
Additional details here...
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

This already works my bad.


HOTFIX: Do not allow GRUB re-installs at the moment!

@wkennington @lethalman @edolstra
What do you think?  At the moment there seems to be an issue with GRUB not finding a boot menu after calling grub-install.

Are you using the code in master? What does your /boot look like.
On Wed, Jul 8, 2015, 10:23 ts468<EMAIL_ADDRESS>wrote:

@wkennington https://github.com/wkennington @lethalman
https://github.com/lethalman @edolstra https://github.com/edolstra
What do you think? At the moment there seems to be an issue with GRUB not
finding a boot menu after calling grub-install.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/8710#issuecomment-119669713.

I think grub configuration is split over two directories:
/boot/grub/grub.cfg
/boot/boot/grub/...

That should be fixed in master, try deleting /boot/boot and forcing a
reinstall.
On Wed, Jul 8, 2015, 10:28 ts468<EMAIL_ADDRESS>wrote:

I think grub configuration is split over two directories:
/boot/grub/grub.cfg
/boot/boot/grub/...
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/8710#issuecomment-119670869.

Eh, what is this for? If there is a bug, shouldn't we fix it instead?

The bug should be fixed but you have to force a reinstall of grub, maybe we
need a parameter in the update file to be able to force updates when we
have fixes like this?
On Wed, Jul 8, 2015, 10:44 Eelco Dolstra<EMAIL_ADDRESS>wrote:

Eh, what is this for? If there is a bug, shouldn't we fix it instead?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/8710#issuecomment-119674379.

Maybe we should revert the recent changes to the GRUB menu builder? They seem to have made it significantly more complex, and this is the one critical part of NixOS - if we mess up here, users can't roll back to previous configurations.

I would prefer not to revert as it should be in working order if you did not get caught installing between d4fc2b4d99122ba6592835aa84f659b22aeea433 and cb343e7be6445a643a22992871a76e4911af2c49
The problem in this case seems to be that c38a9b607fada946bedefcd45f1ec836583a0e1d forced a rebuild prior to cb343e7be6445a643a22992871a76e4911af2c49 which caused broken installations. I've done some testing on my own fat32 systems which shows everything is now in working order. I'm trying to get confirmation from ts486 and roconner.
I'm also working on a test case for fat32 /boot's to make sure we don't see the regression in the future.

My system could boot with GRUB successfully. I've deleted /boot/boot---as it shouldn't be there?---and /boot/grub/state to trigger a reinstall of GRUB.
@wkennington thanks for the quick fix! @edolstra sorry for the noise.

Correct, I think we can say this is resolved.

Building in master worked for me.


fix(job-run): add index for run_meta_nomad.node_id

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#811
#810  👈
#807
#806
#804
#803
#802
#801
#805
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Add optional App re-creation

Towards https://github.com/giantswarm/giantswarm/issues/31499
This PR:

adds an optional pre-upgrade job that deletes an existing App CR instead of updating it in place.

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

This currently also bumps falco to 0.9.0, since I was testing it anyway

I have a couple of concerns about this:

This seems like a bit too dangerous and feels like it should be a platform feature instead.
I know sometimes this works as intended (deleting the app, re-creating it and everything just works). However, I feel there could be some edge cases where chart-operator could get stuck while deleting the chart and then trying to install it again.
This also means that every config change made to the bundle values would trigger the deletion and re-creation of the app, which in some environments could mean the app is constantly being created/deleted. Imagine gitops and this happening in multiple clusters at the time.

I know this has been motivated by the Falco changes in v0.9.0. I haven't checked it personally, but couldn't something have been done on the app side instead?
Beside those points, happy to review the actual feature on Monday 😄

This seems like a bit too dangerous and feels like it should be a platform feature instead.

I completely agree, but :upside_down_face: this is the boat we're in

I know sometimes this works as intended (deleting the app, re-creating it and everything just works). However, I feel there could be some edge cases where chart-operator could get stuck while deleting the chart and then trying to install it again.

Also agree, but short of re-implementing app platform or building something very heavyweight, I don't think we can account for them all. This does wait until the App CR is deleted

This also means that every config change made to the bundle values would trigger the deletion and re-creation of the app, which in some environments could mean the app is constantly being created/deleted. Imagine gitops and this happening in multiple clusters at the time.

I've tested that updating metadata of the user-values CM doesn't roll the app again. Changing the actual config of any app of course does. Do you know of cases where there is flapping config? That shouldn't be happening anyway

I know this has been motivated by the Falco changes in v0.9.0. I haven't checked it personally, but couldn't something have been done on the app side instead?

When we dug into it before (also with Honeybadger), we thought it couldn't be done inside the app because Helm will enforce not changing immutable fields when it compares the "new" release to the "old" release. The release must actually be removed. I suppose we could have a pre-upgrade hook there that nukes its own chart, but that also seems risky.

Beside those points, happy to review the actual feature on Monday 😄

Nah enjoy your P32 and we can talk about it on Tuesday. I have one other idea but I think it might mean spanning two releases. I noticed when starting to test this that the current Falco release actually doesn't run on v29, so there's at least a little time pressure, but I'm not married to this solution by any means

I took deeper look and the only immutable fields in the immediate Falco issue are actually in Falco sidekick, so I'm thinking we can toggle sidekick off and on again via config during the upgrade. See the tracking issue comment


Deleting snippets enhancement

Currently you can only delete a snippet directly within the edit page for the snippet. It would be good if you could delete them from the snippet listing, ideally in batch to improve UX.

@gasman I would like to take on this Issue and have a proposed UI flow in mind.
I understand this does not cover the full Bulk Actions as per #121 but it will mean we have solved a simple use case.
View 1 - No Items Selected

New column 5% wide that will contain checkboxes.
By default no items will be selected on any Snippets listing.
Column will have no header.
Delete Selected button is disabled in the header.

View 2 - One or More Items Selected

When an item is selected, this is indicated by the row being a different colour.
I would need direction on what colour/css class would be suitable.
Delete Selected button is now enabled in the header with red serious class.

View 3 - Delete Snippets Confirmation

When the Delete Selected button is clicked, the behaviour will be similar to a single page being deleted.
A new view at a URL like /admin/snippets/demo/advert/multiple/delete/?id=1 will contain the View for confirming the delete action.
The view will list the titles (or whatever is set) for reference.

Thanks @lb- - all looks good to me!

Epic - @gasman I have started progress on my own fork, you can see the branch here:
https://github.com/lb-/wagtail/tree/675_deleting_snippets_enhancement
Question: Where should I put my custom Javascript for the specific template in admin (should I use hooks to put it in?)

@lb- Use a {% block extra_js %} section, preferably with the Javascript in an external file (rather than inline on the page), like this: https://github.com/wagtail/wagtail/blob/5278e005a0c77f9d8ea82215057d38c7fc512fc9/wagtail/wagtailimages/templates/wagtailimages/images/url_generator.html#L37-L42

@gasman epic, that helps heaps.

Pull request includes the changes described above with a few modifications:

Added a 'select all' checkbox on the header row
delete-multiple url will act like delete url if one snippet ID is provided

I need to add a js function call on page load to sync up the view when users click back still

Completed in #3802 / #4610.


EXC_BAD_ACCESS on iOS build (CreateCVPixelBufferForImageFramePacket crash)

Plugin Version or Commit ID
v0.9.1
Unity Version
2020.3.30f1
Your Host OS
Windows 10 Pro / Mac OS
Target Platform
iOS
Target Device
iPhone 7 plus
[Windows Only] Visual Studio C++ and Windows SDK Version
No response
[Linux Only] GCC/G++ and GLIBC Version
No response
[Android Only] Android Build Tools and NDK Version
No response
[iOS Only] XCode Version
13.3
Build Command
python build.py build --ios arm64 --linkopt=-s -vv
Bug Description
App crash within 30 seconds after inferencing. It frequently occurs on iPhone 7 plus. Currently, I haven't seen this issue on iPhone 12 and 13.
Attached files are Xcode stack trace and inspector when bug occurs.
Steps to Reproduce the Bug

Update mediapipe version to over 0.9.0
Build app and run on iPhone 8 or lower.

Log
.
Screenshot/Video

Additional Context
No response

Thank you for reporting the issue.
Will you test to see if this error also occurs in the official sample app (at v0.8.9)?
If it also occurs, will you further test to see if it also occurs in the latest commit?

Update mediapipe version to over 0.9.0

I'm a little curious, does that mean it doesn't happen with older versions?

@homuler  It didn't happen with 0.8.3 on iPhone 7 plus (at least it didn't crash within 10 seconds)
How can I test it? just running sample app on iPhone 7 plus?

How can I test it? Just running an official sample app on iPhone 7 plus?

Yes.
Depending on the scene you tested, the app you build should be different (if you tested the Face Detection scene, then please build the Face Detection sample app).
But if it doesn't happen with v0.8.3, the built app would likely work fine.

It didn't happen with 0.8.3 on iPhone 7 plus (at least it didn't crash within 10 seconds). I think It is a newly occurred issue. I skipped the 0.8.4 release and upgraded to 0.9.1.

I am very sorry, but if possible, I would like you to investigate which commit caused the problem using git bisect.
I don't have an old iPhone and have no idea what caused it, so it is difficult for me to determine the cause.

If it can happen with v0.8.3, then I can think of one possible cause.
In sample scenes, input ImageFrames are built from NativeArray<byte> returned from Texture2D.GetRawTextureData.
Perhaps the memory address has been changed in the middle of the process by GC, etc.

I have same issue. I build and run with two devices. iPhoneXs woks find but iPhone 6s occurred above error always.
Plugin Version or Commit ID
v0.9.1
Unity Version
2021.3.1f1
Your Host OS
Mac OS
Target Platform
iOS
Target Device
iPhone 6 s

I have the same issue. I ran it on my iPhone 7 and the error occurred always when starting the app for the first time I sometimes have to restart it like 3 times for it to work.
Plugin Version or Commit ID
v0.10.0
Unity Version
2021.3.2f1
Your Host OS
Mac OS / Mac M1
Target Platform
iOS
Target Device
iPhone 7

I'm a little curious, does that mean it doesn't happen with older versions?

Yes I was using an older version with the same phone I didn’t get this issue

Hi, homuler! I've been busy with other things lately, so I haven't been paying attention.   Is there any update related to this issue?

No.
As I mentioned in https://github.com/homuler/MediaPipeUnityPlugin/issues/544#issuecomment-1112074794, I don't have any devices where the issue can be reproduced.
Unless someone who has those devices identifies the cause, I don't think this issue will be solved.

Hi Homuler! I built sample app of previous commits of this repo(MediaPipeUnityPlugin). This issue started to occur on  9d7e390. I hope this is useful to you 👍🏻
If you have any idea please let me know. Thank you:)

@siisee11 Thank you. With https://github.com/homuler/MediaPipeUnityPlugin/commit/9d7e390b6012b2f5ebed14de599d90821f4f7f62, GetTextureName is not called until it is needed. If you call TextureFrame#GetTextureName in TextureFrame#SetPixels32 (after _texture.Apply()), does that solve the issue?
Unfortunately, I still have no way to fix it without devices.
For now, I'm thinking it is related to the behavior of Texture2D#GetTextureNativePtr, but we need to find out more about what is happening on the iPhone 7.
However, since this seems to be only a sample code issue, it is not a high priority at present.

I tested your solution on the sample app and It didn't crash for an hour. I'll test it in my application. This is related to sample code, but I think many users of this plugin would utilize your sample code!
I'll test further and If there is no issue I'll close this issue.
Thank you, you are the best! 👍🏻

Please leave this issue open until it's fixed in the master branch.
Of course, I'd like to fix it, but in order to merge the fix, we need a rational and logical explanation of why it will solve the problem.
And as I don't have devices, I need to wait for someone to do a detailed investigation.

Sure, thank you. I'll take a closer look when I have time.


[Snyk] Upgrade @mui/icons-material from 5.15.6 to 5.15.9

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @mui/icons-material from 5.15.6 to 5.15.9.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.
The recommended version was released 21 days ago, on 2024-02-08.

Release notes

Package name: @mui/icons-material

5.15.9 - 2024-02-08Feb 8, 2024
A big thanks to the 7 contributors who made this release possible. Here are some highlights ✨:

🐛 A critical fix to remove non-published library usage in @ mui/material peerDependencies.

<EMAIL_ADDRESS>
[autocomplete] Avoid spread operator (#40968) @ oliviertassinari
[material] Remove zero-runtime from peer dep (#41003) @ brijeshb42

<EMAIL_ADDRESS>
[base-ui] Update props using Array to ReadonlyArray type (#40754) @ RaghavenderSingh

<EMAIL_ADDRESS>
[system] use ReadonlyArray for CSS related types (#40972) @ siriwatknp
[zero] Migrate to use wyw-in-js instead of linaria (#40866) @ brijeshb42

Docs

[docs] Polish codemod git diff format @ oliviertassinari
[material-ui][docs] Migrating from deprecated apis follow up (#40981) @ DiegoAndai

Core

[code-infra] Move next config to ESM (#40869) @ Janpot
[code-infra] Update prettier (#40772) @ Janpot
[code-infra] Add codemod for light prop removal (#40947) @ sai6855

All contributors of this release in alphabetical order: @ brijeshb42, @ DiegoAndai, @ Janpot, @ oliviertassinari, @ RaghavenderSingh, @ sai6855, @ siriwatknp

5.15.8 - 2024-02-06 Read more

5.15.7 - 2024-01-31 Read more

5.15.6 - 2024-01-22 Read more

    from @mui/icons-material GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

duplicate


Should we extract crowdastro.crowd into its own project?

https://github.com/chengsoonong/crowdastro/tree/master/crowdastro/crowd
This would mean that we may need to tinker a bit with the interface, but it might be a tool that is of broader interest than just applying it to RGZ.

Yes, I think we should. Generic crowd algorithms are notably different from astronomical applications. (Then again, it is crowdastro...)
If we do that, we should do it after the thesis, and we should also discuss the API.

I will explicitly tag issues with thesis if I think you should include it.


Add models US-GAN and GP-VAE, update docs, refactor testing cases, add cal_internal_cluster_validation_metrics()

What does this PR do?

fixing #175, adding US-GAN and GP-VAE;
update docs;
refactor testing cases;
add pypots.utils.metrics.cal_internal_cluster_validation_metrics();

Before submitting

[x] This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
[x] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have written necessary tests and already run them locally.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 493 (0.0%)  changed or added relevant lines in 17 files are covered.
2982 unchanged lines in 72 files lost coverage.
Overall coverage decreased (-82.8%) to 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pypots/base.py
0
1
0.0%

pypots/classification/grud/data.py
0
1
0.0%

pypots/imputation/brits/data.py
0
1
0.0%

pypots/imputation/mrnn/module.py
0
1
0.0%

pypots/data/saving.py
0
2
0.0%

pypots/imputation/gpvae/init.py
0
2
0.0%

pypots/imputation/saits/data.py
0
2
0.0%

pypots/imputation/usgan/init.py
0
2
0.0%

pypots/imputation/init.py
0
3
0.0%

pypots/data/base.py
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

pypots/utils/init.py
1
0.0%

pypots/classification/brits/init.py
2
0.0%

pypots/classification/grud/init.py
2
0.0%

pypots/classification/raindrop/init.py
2
0.0%

pypots/clustering/crli/init.py
2
0.0%

pypots/clustering/vader/data.py
2
0.0%

pypots/clustering/vader/init.py
2
0.0%

pypots/data/load_preprocessing.py
2
0.0%

pypots/forecasting/bttf/init.py
2
0.0%

pypots/forecasting/init.py
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-82.8%

Covered Lines:
0

Relevant Lines:
4114

💛  - Coveralls


Including Amount field in Custom Opportunity Naming should not show pennies!

If you have {!Amount} in your Opp naming rule, it will get rendered as $500.00, which I'm sure all users would prefer seeing as just $500

I believe it was @judisohn who wanted the pennies shown consistently!

really!?

From what I recall! Let's see what she says :)

Yes - it was something that was requested of me a few times when I did workflow rules for the name. I think it was because $98.50 displays as $98.5 if you just do TEXT(Amount) which bothered folks, so I suggested to Nic making the 2 decimals.
Maybe only do the 2 decimals if pennies are involved at all?

Included in beta release version 3.40 (Beta 3) and higher

Included in production release version 3.40


Question about 1-N (One To Many) relation

Hello,
I have a 1-N (One To Many) relation between two tables :

a personne belongs to one structure
in a structure there is many personnes

So i have a personnes table :
idPersonnes, name, firstname, idStructures
And a structure table :
idStructures, name, adress
In my personne Model i have :
public function structure()
{
     return $this->belongsTo('App\Models\Structure', 'idStructures', 'idStructures');
}

In my personne controller i have :
$this->crud->addField([
            'label' => 'Structure',
            'type' => 'select2',
            'name' => 'idStructures', // the db column for the foreign key
            'entity' => 'structure', // the method that defines the relationship in your Model
            'attribute' => 'nom', // foreign key attribute that is shown to user
            'model' => 'App\Models\Structure' // foreign key model
        ]);

This is working well. I have select2 dropdown when i edit a personne and i can choose and save a structure.
Now when i edit a structure i want to show all the personnes that belongs to that structure.
In my structure model i have :
public function personnes()
{
    return $this->hasMany('App\Models\Personne', 'idStructures', 'idStructures');
}

In my structure controller i have :
$this->crud->addField([
            'label' => 'Personnes',
            'type' => 'select2',
            'name' => 'idStructures', // the db column for the foreign key
            'entity' => 'personnes', // the method that defines the relationship in your Model
            'attribute' => 'nom', // foreign key attribute that is shown to user
            'model' => 'App\Models\Personne' // foreign key model
        ]);

It's not working.
Am i doing something wrong ?
Thanks for your help.

Hi @adbmdp ,
I don't see the "nom" column in your table. Maybe this should work:
$this->crud->addField([
            'label' => 'Personnes',
            'type' => 'select2',
            'name' => 'idStructures', // the db column for the foreign key
            'entity' => 'personnes', // the method that defines the relationship in your Model
-            'attribute' => 'nom', // foreign key attribute that is shown to user
+            'attribute' => 'name', // foreign key attribute that is shown to user
            'model' => 'App\Models\Personne' // foreign key model
        ]);

Cheers!

Thanks for your reply.
I have a "nom" column in my table.
The problem does not comes from that.
Is it ok to use  'type' => 'select2' in my addField ? I'm supposed to display multiple personnes here so it should be logic to use select_multiple  right ? But as it is supposed to be for N-N relation. I'm a bit confused.
I'm still discovering BackPack and i love your work ! That's really cool.

Hmm... I think it's a 1-N relationship. There's no pivot table, so it's not an N-N relationship.
I've looked more closely to your first post and I think I understand it better now. So what you want is:

from the "Edit Structure" page, show all persons related to that structure;
when saving, also edit all Persons you chose and make connect them to that structure;

Unfortunately, we have nothing that works that way, as it's a pretty peculiar use case. CRUDs usually only edit the entity you've opened, not connected entities too.
Solution:

You should already be able to see and add Persons in the Edit Structure form (front-end), but it won't actually save them.
In order to save them, you need to edit the store() and update() methods in your controller, and include the logic for that. Something like:

    public function store(StoreRequest $request)
    {
        $result =  parent::storeCrud();

        // TODO: go through all persons the admin chose and make sure they belong to the current structure

        return $result;
    }

Hope it helps.
Cheers!

OK i understand that CRUDs usually only edit the entity you've opened, not connected entities too.
But do you think it's possible in the edit form of a structure to just print out a list of all persons related to that structure and a link to their edit form ?
I found kind of a workaround by using your blog post here but that's not exactly what i want as it is from the list view : https://backpackforlaravel.com/articles/tutorials/nested-resources-in-backpack-crud

Sure, you can do that by creating a custom field type. It can look and work any way you need it. You'll find the entries inside the $entry variable and you can output them any way you want.
Cheers!

Thanks i'll do that!
Do I have to use an existing field type and modify it or can i create a brand new one. Like mynewfield.blade.php ?
And call it like that :
$this->crud->addField([
            ...
            'type' => 'mynewfield',
           ...
        ]);

Exactly - "mynewfield" will work if your field is mynewfield.blade.php

Thanks you for your replies! Much appreciated.

Sorry to bother you again. But i can't make my 1-N relation to work to get all personnes that belongs to a structure. I've tried everything.
I got the same relations that on my first post.
I've created a new blade personnesliste.blade.php that just var_dump $entry and $field.
 $this->crud->addField([
            'label' => 'Personnes',
            'type' => 'personnesliste',
            'name' => 'idStructures', // the db column for the foreign key
            'entity' => 'personnes', // the method that defines the relationship in your Model
            'attribute' => 'nom', // foreign key attribute that is shown to user
            'model' => 'App\Models\Personne' // foreign key model
        ]);

All i got is  when i edit the structure that got id 1, look like the relation is not working properly, it's brings personne with id 1 ?
object(App\Models\Structure)#391 (23) { ["table":protected]=> string(10) "structures" ["primaryKey":protected]=> string(12) "idStructures" ["timestamps"]=> bool(true) ["fillable":protected]=> array(6) { [0]=> string(12) "idStructures" [1]=> string(3) "nom" [2]=> string(7) "adresse" [3]=> string(2) "cp" [4]=> string(5) "ville" [5]=> string(4) "pays" } ["connection":protected]=> NULL ["keyType":protected]=> string(3) "int" ["perPage":protected]=> int(15) ["incrementing"]=> bool(true) ["attributes":protected]=> array(8) { ["idStructures"]=> int(1) ["nom"]=> string(6) "SATEST" ["adresse"]=> string(14) "11 rue de Bois" ["cp"]=> int(75000) ["ville"]=> string(5) "Paris" ["pays"]=> string(6) "France" ["created_at"]=> NULL ["updated_at"]=> string(19) "2017-01-05 13:09:26" } ["original":protected]=> array(8) { ["idStructures"]=> int(1) ["nom"]=> string(6) "SATEST" ["adresse"]=> string(14) "11 rue de Bois" ["cp"]=> int(75000) ["ville"]=> string(5) "Paris" ["pays"]=> string(6) "France" ["created_at"]=> NULL ["updated_at"]=> string(19) "2017-01-05 13:09:26" } ["relations":protected]=> array(0) { } ["hidden":protected]=> array(0) { } ["visible":protected]=> array(0) { } ["appends":protected]=> array(0) { } ["guarded":protected]=> array(1) { [0]=> string(1) "*" } ["dates":protected]=> array(0) { } ["dateFormat":protected]=> NULL ["casts":protected]=> array(0) { } ["touches":protected]=> array(0) { } ["observables":protected]=> array(0) { } ["with":protected]=> array(0) { } ["exists"]=> bool(true) ["wasRecentlyCreated"]=> bool(false) }
array(7) { ["label"]=> string(9) "Personnes" ["type"]=> string(14) "personnesliste" ["name"]=> string(12) "idStructures" ["entity"]=> string(9) "personnes" ["attribute"]=> string(3) "nom" ["model"]=> string(19) "App\Models\Personne" ["value"]=> int(1) }

Hi @adbmdp ,
Hmm... then the problem must be with the way you've defined your relationship. You can try it elsewhere (in a blank controller, for example) and play there until the relationship is fully working.
Cheers!
P.S. Since this isn't a bug, I'll go ahead and close this issue so we don't clog the section. Feel free to comment if you have follow-ups.

Still can't get it to work :-(
I did everything like in this post :
https://github.com/Laravel-Backpack/Base/issues/50

@adbmdp
Have you tried adding 'pivot' => true to your addField calls?
(I haven't read the whole thread)

I don't need it as it's not a many to many relation but a 1-N relation.
I don't have any pivot table for that relation.

Hi @adbmdp ,
As far as I can see, you were able to dump the structure in your field (object(App\Models\Structure)#391 (23)). If you have the relationships defined on your Structure model (one-to-many), you should be able to easily get the persons from a structure.
If you got the structure with $entry, and your relationship is calles "personnes", you should be able to do $entry->personnes.
Hope it helps. Cheers!

OK it works.
Once again thanks you my friend!

<input type="submit" name="submit" class="btn btn-danger" value="update">

<input type="hidden" name="_method" value="PUT">

Please don't blame me as this is not directly related to this topic.
But I will be highly appreciating if someone can help me on this:
https://stackoverflow.com/questions/47114109/eloquent-using-wrong-key-for-some-tables
if you guys just cant tolerate this request here then delete it or let me know. I will do.
I seriously need help. So i posted here


Oblivious DNS

https://tools.ietf.org/html/draft-annee-dprive-oblivious-dns-00
Would you be adding support for it ?

If it ever gets finalized and deployed.
I proposed the same idea 6 years ago, but deployment seems complicated. Authoritative DNS servers have too much inertia.


Delete SQL 2016+ lines from 2014 Archive docfx.json.

Delete SQL 2016+ lines from 2014 Archive docfx.json.
GeneMi

No Build, so I will now Merge.


ci: add option to run e2e twice

Add option to run default e2e tests twice in CI. Always run twice in merge queue.
We want to ensure that the default e2e tests are never dependent on the system state.
Adds ~8 minutes to mergequeue times.

Summary by CodeRabbit

New Features

Introduced a new output variable TWICE_TESTS to conditionally run tests multiple times based on pull request labels.
Added a new input parameter run-twice to the reusable E2E testing workflow, allowing for a second execution of tests.
Implemented additional steps for a second test run and log monitoring based on the run-twice input.

Bug Fixes

Enhanced the conditional execution logic for tests in the E2E workflow.

Can't we run these concurrently instead of sequentially?

No since the point of the second run is to ensure that the tests work given the state leftover from the second run.

Can we just add the TSS MIGRATION test when merging instead ?

Yeah we could do that but it would take a bit longer.

Yeah we could do that but it would take a bit longer (looks like +5 minutes)

Just curious, is 5 minutes a significant delay here? It does provide the value of testing the TSS migration as well.

Just curious, is 5 minutes a significant delay here? It does provide the value of testing the TSS migration as well. And reuse exiting code

Yeah maybe an extra 5 minutes isn't very significant. And I think the tss migrations tests may be stable enough to run in the mergequeue now too.


Questionable async performance

Hello,
I have a questionable asynchronous call performances using Beanie.
For this particular example, I do N calls of get_payload using asyncio.gather()
In [164]: async def get_payload(zone_id: int) -> DasPayload:
     ...:
     ...:      examples = await Example.find(
     ...:         Example.zone_id == zone_id,
     ...:     ).to_list()
     ...:

A single call takes 3.03 ms
In [165]: await get_payload(1)
time: 3.03 ms (started: 2022-06-03 04:48:02 +09:00)

On the other hand calling 1000 of the very same fucntion takes far longer than my expectation:
await asyncio.gather(*[get_payload(1) for _ in range(1000)])
time: 1.56 s (started: 2022-06-03 04:48:14 +09:00)

I expected the performance to resemble similar to below:
In [187]: async def hello():
     ...:     await asyncio.sleep(1)

In [188]: await hello()
time: 1 s (started: 2022-06-03 04:53:02 +09:00)

In [190]: await asyncio.gather(*[hello() for _ in range(1000)])
time: 1.05 s (started: 2022-06-03 04:53:10 +09:00)

Diving it a bit further,
seems like having greater number of MOTOR_MAX_WORKERS actually decreases performance of a single query.
https://motor.readthedocs.io/en/stable/configuration.html
setting MOTOR_MAX_WORKERS=1
[ins] In [3]: await get_payload(1)
Out[3]: []
time: 24.4 ms (started: 2022-06-03 11:30:41 +09:00)

[ins] In [4]: await asyncio.gather(*[get_payload(1) for _ in range(16)])
Out[4]: [[], [], [], [], [], [], [], [], [], [], [], [], [], [], [], []]
time: 62.2 ms (started: 2022-06-03 11:30:44 +09:00)

Without MOTOR_MAX_WORKERS settings (using the default value of 5 per CPU)
[ins] In [14]: await get_payload(1)
Out[14]: []
time: 26.3 ms (started: 2022-06-03 11:30:13 +09:00)

[ins] In [15]: await asyncio.gather(*[get_payload(1) for _ in range(16)])
Out[15]: [[], [], [], [], [], [], [], [], [], [], [], [], [], [], [], []]
time: 96.3 ms (started: 2022-06-03 11:30:14 +09:00)

MOTOR_MAX_WORKERS=1  is in fact faster, indicating one with less concurrency is actually faster.
What is going on here?
Is it due to the fact that the underlying Motor library actually wraps blocking library Pymongo and uses async to sync call to pymongo using run_in_executor? https://github.com/mongodb/motor/blob/2f75a4030c6fbf076d5a50d2b0e6a492a5bcaa9c/motor/frameworks/asyncio/init.py#L73
Would there be any way to further improve on this performance?
For now, it seems like the performance improvement using async Beanie is rather minimal.

Found this driver for reference: https://github.com/sakal/aiomongo

So for some reason they arent actually using asyncio futures..... Probably because that was written 8 years ago...
The actual advantage to using async in your main thread is that it is not blocked. So for something very short you may not see much if any speedup but if you make the actual calls more complex like downloading a lot of data or slow outbound connection you will see the boost. Because ur not doing any connection checking on the front end connection one of the largest advantage spots is missed by your test.
But as far as the worker count yea it should probably just be one. Their code doesn't actually make sense unless you have multiple workers above it.


[HUDI-4326] add updateTableSerDeInfo for HiveSyncTool

What is the purpose of the pull request

This pull request fix https://github.com/apache/hudi/issues/5861*
The issue is caused by after changing the table to spark data source table, the table SerDeInfo is missing. *

Brief change log

add updateTableSerDeInfo for HiveSyncTool

Verify this pull request
This change added tests and can be verified as follows:

Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Hi @kk17 Would you please file a Jira ticket for this fix.

@hudi-bot run azure

and please create a jira and link it to the patch.

can we please write a test for the changes made.

any instruction on how to write a test?

Hi @kk17 Would you please file a Jira ticket for this fix.
@yanghua created https://issues.apache.org/jira/browse/HUDI-4326

can we please write a test for the changes made.

any instruction on how to write a test?

Hi @kk17, you can refer to the ut in TestHiveSyncTool, mock a table performed in 0.8, and  call the new sync function to make hive sync in 0.11 success.

hey @kk17 : is there any updates on this patch. once its ready, let me know. I can take another look.

@nsivabalan @minihippo minihippowill try to add a test in the next two coming weeks

@minihippo : I hope you can assist in adding a test on this regard.

cool man. @codope thanks.


How can get the kubectl describe output to a table format

I am using Kubernetes VPA as a resource recommender tool for my cluster and its generating the recommended specification for each deployment. But I would like to get a automated way to create the vpa recommendation to all the existing VPAs in a much readable format ( preffered way is table format) dynamically.
I tried to create an Azuredevops pipeline and when parsing the json path from the kubectl get command I am not getting the resulted output.
k get  vpa myvpa -n mynamespace -o jsonpath='{status.recommendation.containerRecommendations.containerName[*]}'

Hi @vivuu1989,
To create a table format output from the VPA recommendations, you can use tools like jq to parse the JSON output and format it as a table. Here's how you can achieve this:
Step 1 : Ensure you have jq installed on your system. If it's not installed, you can typically install it using your package manager (e.g., apt-get, brew, yum, etc.).
Step 2 : Run the kubectl get command to retrieve the VPA recommendations and pipe the output to jq for formatting. You can use the --output flag with jq to format the data as a table. Here's an example command:
kubectl get vpa -n mynamespace -o json | jq -r '.items[] | [.metadata.name, .status.recommendation.containerRecommendations[].containerName] | @tsv'

This command retrieves the VPA recommendations in JSON format, extracts the VPA name and container recommendations, and formats the output as a tab-separated table.
I hope you find this helpful : )

I believe that this https://github.com/kubernetes/kubectl/issues/1491#issuecomment-1732034732 could be a useful workaround. I don't think, we would want to add this in kubectl describe as it's main aim is to print the data in a human readable way in terminal.
/close


Kanban Board Submission

There are two members working on this ROR group project:

@aamir-asaram
@hassanShakur

This is the link to our Kanban Board

Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

good job creating the board as requested

Required Changes ♻

[ ] to make sure you are complying with the requirement please at least create a card for each bullet point in the requirements list:

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mikethreels should there be a card for each main bullet point (just the dark ones) or for all of them? (separate card for each lighter bulltet)

@aamir-asaram one card for each main bullet should be enough, just make sure to add the lighter bullet to the description.

Noted. Thanks for clarifying @mikethreels :smile:

Hi @aamir-asaram and @hassanShakur,
APPROVED 🟢
Highlights
✔ Descriptive issue and tasks
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete!  There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Allow non-global Sinon to be used if requested

If the user requests Sinon without making sinon.spy globally available:
require("console-fail-test").cft({
    spyLibrary: "sinon",
});

...then they should still be allowed to use the framework. It's not great practice to ask folks to create globals.
How about making two Sinon spy factories? One that's called upon spyLibrary: "sinon" request that does the require/import, and one that attempts global auto-detection?
This is blocked by figuring out how to work with browser-only test frameworks such as QUnit, where the entire console-fail-test framework might need to be transpiled into roughly a single .js file to be included via a script tag.

Cute solution!
require("console-fail-test").cft({
    spyLibrary: require("sinon"),
});


Is the WEBSITE_HEALTHCHECK_MAXUNHEALTYWORKERPERCENT documentation correct?

Two things:

Looks like there's a typo in WEBSITE_HEALTHCHECK_MAXUNHEALTYWORKERPERCENT, is that the correct spelling we should use?

Is the documentation correct that a higher value for this setting means less unhealthy instances allowed? The way the setting name reads, it sounds like it controls the percentage of instances that are allowed to be unhealthy and still be routed to. Meaning a lower setting would mean less unhealthy instances allowed to be routed to. This would also be consistent with Service Fabric's analogue setting (no idea if they're related).

Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2526d6f8-e90d-5ecc-dbca-14540fcad599
Version Independent ID: e308750d-5a63-db74-9113-38cad322d48c
Content: Get started with autoscale in Azure - Azure Monitor
Content Source: articles/azure-monitor/platform/autoscale-get-started.md
Service: azure-monitor
Sub-service: autoscale
GitHub Login: @rboucher
Microsoft Alias: robb

@jslamartina Thank you for your query, we will look into it and get back to you at the earliest.

@jslamartina Thanks again for reaching out to us. I have reached out to respective team about the typo in the config and the instructions, based on that feedback can confirm that the usage instructions are correct. it's the max percent that are removed, not the percent that's kept. Not particularly aware of Service Fabric's setting.
Hope the above information helps, once I have more clarity on the typo on the config will update the thread accordingly.

@jslamartina I did hear back from our team and it has been called out that its an issue on how its spelled in the config and they have a work item to fix it. We really appreciate you taking time and bringing this to our notice.
However for the time being if you want to use please continue to use on how its called out in the documentation currently.
The work item above is to fix the spelling and the documentation will also be corrected accordingly.
Once its fixed I will make sure to update this thread.
For now will go ahead and close this issue, however if you have any further queries please tag us in your reply and will be happy to reopen the thread and continue the conversation. Thanks again.


Percent complete try2

Add inference_steps, num_steps as scalars.  To resolve https://github.com/sillsdev/serval/issues/44

This change is

machine/jobs/nmt_engine_build_job.py line 73 at r1 (raw file):

    def _send_clearml_config(self) -> None:
        if self.clearml_task:
            self.clearml_task.get_logger().report_single_value(name="total_steps", value=self._config["max_steps"])

As long as this is logged as other values are and is accessible via the ClearML API in the same way, I should be good to go. I haven't worked with machine.py, so I can't comment intelligently on the rest.

@johnml1135 You said the inference updates still aren't working?

I fixed it.

machine/jobs/nmt_engine_build_job.py line 23 at r2 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I was specifically trying to avoid any dependencies on ClearML in this class. I would pass in a callback function for reporting progress.

We will also need functions for updating inference status, etc.  Either we pass 2-3 functions, or we pass the task (or a null).

machine/translation/thot/thot_smt_model_trainer.py line 63 at r2 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
What is the typing issue here?

I think pyright was squalking.

If you really think it needs implemented substantively differently, then do it.  I think this is clear and clean enough for what we want to accomplish.  We will also need to report back the max_steps, as Machine will no longer inherently know it (and is needed for % complete estimations).


Humble AMCL Particle Swarm doesn't work

OS: Ubuntu 22.04.1
ROS Distro: Humble
Installed
(Package version: H.1.2. Create3)
CycloneDDS, Simple Discovery mode

Expected behaviour
Normally in RViz it is possible to see the estimated locations given by Amcl Particle Swarm.
Actual behaviour
After starting RViz the Amcl Particle Swarm doesn't work.
LaserScan works only sometimes, otherwise the error is:

Could not transform from [rplidar_link] to [map]

To Reproduce
Runned code from Turtlebot4 (ssh connection)
ros2 launch turtlebot4_navigation localization.launch.py map:=my_map.yaml
Other terminal:
ros2 launch turtlebot4_navigation nav2.launch.py
Launched RViz from an Humble PC:
ros2 launch turtlebot4_viz view_robot.launch.py
Please help!

Here is the RViz terminal messages:

For additional informations, we attach the message generated by localization and navigation terminals:
Localization: (ros2 launch turtlebot4_navigation localization.launch.py map:=my_map.yaml)

Navigation: (ros2 launch turtlebot4_navigation nav2.launch.py)

I have also encountered this problem, have you solved it?

This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.


Update README from branch example

##Updates
I updated a readme file. Please review and accept

Thoughts
I probably shouldn't, but okay. 👍


amsmath intertext problem with phase-II and phase-III (without math tagging)

I know that compatibility with amsmath is not guaranteed or expected at this point, but I stumbled upon this error in my document, which could be easy to fix.
Consider the following document
\DocumentMetadata{
    testphase={phase-II}
}
\documentclass{article}
\usepackage{amsmath}

\begin{document}
    \begin{gather*}
        A = B \\
        \intertext{where}
        B = C
    \end{gather*}
\end{document}

Compiling with current lualatex results in the following error.
This is LuaHBTeX, Version 1.18.0 (TeX Live 2024)
 restricted system commands enabled.
(./test3.tex
LaTeX2e <2023-11-01> patch level 1
L3 programming layer <2024-04-11>

(/usr/local/texlive/2024/texmf-dist/tex/latex/latex-lab/documentmetadata-suppor
t.ltx
(/usr/local/texlive/2024/texmf-dist/tex/latex/pdfmanagement-testphase/pdfmanage
ment-testphase.sty
(/usr/local/texlive/2024/texmf-dist/tex/latex/tagpdf/tagpdf-base.sty)
(/usr/local/texlive/2024/texmf-dist/tex/latex/pdfmanagement-testphase/pdfmanage
ment-testphase.ltx)))
(/usr/local/texlive/2024/texmf-dist/tex/latex/l3backend/l3backend-luatex.def)
(/usr/local/texlive/2024/texmf-dist/tex/latex/pdfmanagement-testphase/l3backend
-testphase-luatex.def)
(/usr/local/texlive/2024/texmf-dist/tex/latex/latex-lab/phase-II-latex-lab-test
phase.ltx
(/usr/local/texlive/2024/texmf-dist/tex/latex/latex-lab/latex-lab-testphase-new
-or-1.sty (/usr/local/texlive/2024/texmf-dist/tex/latex/etoolbox/etoolbox.sty)
Patching header in \@outputpage
Patching footer in \@outputpage
Patching \@makecol for tagging
Patching \@makecol for tagging
)
(/usr/local/texlive/2024/texmf-dist/tex/latex/latex-lab/latex-lab-testphase-new
-or-2.sty
(/usr/local/texlive/2024/texmf-dist/tex/latex/latex-lab/latex-lab-footnotes.ltx
)) (/usr/local/texlive/2024/texmf-dist/tex/latex/tagpdf/tagpdf.sty
(/usr/local/texlive/2024/texmf-dist/tex/latex/tagpdf/tagpdf-luatex.def)
(/usr/local/texlive/2024/texmf-dist/tex/latex/tagpdf/tagpdf-mc-code-lua.sty)))
(/usr/local/texlive/2024/texmf-dist/tex/latex/pdfmanagement-testphase/pdfmanage
ment-firstaid.sty)
(/usr/local/texlive/2024/texmf-dist/tex/latex/base/article.cls
Document Class: article 2023/05/17 v1.4n Standard LaTeX document class
(/usr/local/texlive/2024/texmf-dist/tex/latex/base/size10.clo))
(/usr/local/texlive/2024/texmf-dist/tex/latex/amsmath/amsmath.sty
For additional information on amsmath, use the `?' option.
(/usr/local/texlive/2024/texmf-dist/tex/latex/amsmath/amstext.sty
(/usr/local/texlive/2024/texmf-dist/tex/latex/amsmath/amsgen.sty))
(/usr/local/texlive/2024/texmf-dist/tex/latex/amsmath/amsbsy.sty)
(/usr/local/texlive/2024/texmf-dist/tex/latex/amsmath/amsopn.sty)) (./test3.aux
) (/usr/local/texlive/2024/texmf-dist/tex/latex/base/ts1cmr.fd)

Package tagpdf Warning: Parent-Child 'P/' --> 'text-unit/user'.
(tagpdf)                Relation is not allowed (struct 4, /text --> struct 5)
(tagpdf)                on line 14

Package tagpdf Warning: Parent-Child 'P/' --> 'text/user'.
(tagpdf)                Relation is not allowed (struct 5, /text-unit -->
(tagpdf)                struct 6) on line 14

! LaTeX Error: Control sequence \g__tag_struct_5_prop already defined.

For immediate help type H <return>.
 ...

l.14     \end{gather*}

The same error occurs with lualatex-dev or other engines. The error also happens with \shortintertext and other amsmath environments. The error disappears when \intertext is removed or the tagging project phase is dropped to phase-I.
Additionally, the error also disappears when the math option is added to the testphase (which is probably the path forward).

As you note yourself, you need the math testphase module for this.

Tagging of documents involving math is not  supported in testphases I to III, the fact that it didn't generate an error in testphase I doesn't indicate a regression. We have not yet integrated math tagging into any phase but kept it as a separate module as it is still under development. So for documents involving math you need to enable it explicitly for now.

Ah, thank you for your answers, I misunderstood the testphases. So, the fact that something like $a$ compiles at all without the math testphase module is not guaranteed.
I'd close the issue, but the label you added suggests to me that you want to keep it open.

At some point we will integrate math directly (probably testphase IV) --- we can close then.  Currently without math the testphases will try to do something with math content and often will compile, but they aren't tagging the math content as "math" and for more complicate environments/commands they may fail as in your example.


Right click to create class does not appear when VS Code start

This extension is wonderful and helps me make my work a lot easier. Now, i am facing this odd problem. When i first start up vs code and after all the extensions have been loaded, i find that when i right click on in the left tree panel, the option to create classes, traits etc do not show. It shows up after I create a php file and use the command palette - Generate Class  Code.
Anyone facing this problem. My version of the extension is 1.13.1.

Hi,
Is there are help on the problem that i am facing?

@jaguadoromero
Composer.json file is always there. Its odd, it only happens when i start up vscode. It works fine after i have created a sample class file using command palette. Please refer to my initial post.

I have tried with the code you have provided in the zip, the extension load correctly and the menu appears immediately the workspace is loaded. On what Operating System are you running vscode?

@jaguadoromero
I am running on Windows 10.  I have attached the setting.json file as well, just in case you need it.
settings.zip

@jaguadoromero
Ok thank you for all the good effort. From your test, it appears that some other extension may be conflicting. I will try this on a fresh machine and eliminate any extension conflict.
Please close this issue and thank you for all the assistance.


max_iter of should be 500K

according to the change made in m2 in common/cnns.py

All stuff in solver.prototxt should be modified if need. The parameters I used may not good, you should tune all parameters yourself, maybe the network structure if needed. The cnn structure I used is  not the same as the paper presents.