[release-v1.15] Add Konflux configurations

Add Konflux components and pipelines

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-v1.15@fbec00e). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.15     #100   +/-   ##
================================================
  Coverage                 ?   82.26%
================================================
  Files                    ?       25
  Lines                    ?     1607
  Branches                 ?        0
================================================
  Hits                     ?     1322
  Misses                   ?      189
  Partials                 ?       96

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm

/lgtm
/approve
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / net-istio-controller-115"
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / net-istio-webhook-115"


Notebooks can have thumbnail and name

You can do:
binstar notebook upload your-notebook.ipynb --thumbnail http://... --name your-name

@srossross @LilaHickey

I think you should pull the image into a data url.

@malev I'm not seeing my thumbnails show up anywhere, and I don't see the thumbnail called anywhere in the notebook templates; where should I expect to see this?

@srossross it's uploading local images as data-uri. Couldn't do that with remote images so far
@LilaHickey you can see them in https://github.com/Anaconda-Server/anaconda-server/pull/354

@LilaHickey in order to see the thumbnails you will need to run anaconda-server with https://github.com/Anaconda-Server/anaconda-server/pull/354

@malev can you check that the image is smaller that a specific size?

@srossross yes I can :) 512Kb limit


Compile readline into the compiled ruby

So readline is now being compiled... but for some reason Ruby doesn't detect it when Ruby is compiled.


Consider ford for Fortran documentation

We could consider using FORD for automatically documenting the Fortran code (similar to Doxygen for C++ or sphinx for python)

Repo: https://github.com/Fortran-FOSS-Programmers/ford
Docs: https://forddocs.readthedocs.io/en/latest/

This is the remaining issue left to reach Milestone 1 (pending PR reviews).
I have started adding some FORD.
Do we want to shelve this or commit to fully implementing it?


Fix #396, workaround for https://developer.blender.org/T93896 introduced in Blender 3.0+

Revert previous fix attempt #374

In Blender 3.0.0+, applying a Vertex Weight Mix modifier invalidates existing references to vertex groups on the mesh the modifier was applied on. Therefore, when calling the mix_weights function we must avoid keeping, and later using, old vertex group references. I checked all other calls to mix_weights for existing references to vertex groups used after the function call and I could not find any, so the other calls to mix_weights throughout Cats should be fine left as they currently are.
It seems like this may be a Windows specific issue. I'm waiting on additional feedback to the Blender bug report as the mix_weights docstring may need to be updated for additional info.

From https://developer.blender.org/T93896, it seems questionable as to whether the vertex groups becoming invalided after applying a Vertex Weight Mix modifier is considered a Blender bug or whether it is simply bad programming practice to have been relying on the references remaining valid in older Blender versions.
Certainly, if all references to types belonging to an object became invalidated after applying any modifier, then a lot of addons and other parts of Cats would probably break. Maybe it will be changed in Blender at some point, but for now, this commit should be enough to fix the current issue.


Axis out of bounds error

When I tried testing the data containing 3d point clouds an error occurred in the _makeKernel module. The error is as mentioned below
Traceback (most recent call last):   File "fishDeformable.py", line 39, in <module>     main()   File "fishDeformable.py", line 35, in main     reg.register(callback)   File "/home/ashok/libraries/Python-CPD-master/core/DeformableRegistration.py", line 26, in register     self.initialize()   File "/home/ashok/libraries/Python-CPD-master/core/DeformableRegistration.py", line 82, in initialize     self._makeKernel()   File "/home/ashok/libraries/Python-CPD-master/core/DeformableRegistration.py", line 112, in _makeKernel     diff = np.sum(np.multiply(diff, diff), self.D);   File "/usr/local/lib/python3.4/dist-packages/numpy/core/fromnumeric.py", line 1840, in sum     out=out, keepdims=keepdims)   File "/usr/local/lib/python3.4/dist-packages/numpy/core/_methods.py", line 32, in _sum     return umr_sum(a, axis, dtype, out, keepdims) ValueError: 'axis' entry is out of bounds
Looks like the axis value is not supportive for 3D yet. Otherwise the algorithm works fine for 2D cases. Since I am not that much familiar with this algorithm, is it possible for the author to make known the possible fix?
Regards,
#0K

I have added a fix. There is also an example for 3D point clouds under tests/fishDeformable3D.py
I am closing this issue, but feel free to reopen it if the fix does not work for you.

I hereby confirm that the code works fine with 3D datasets too. Thanks to the author for fixing it quick


Impossible to leave the change pincode screen

Repro steps

Go to change pincode
Attempt to go back without changing the pin

Expected Result
Back button works and the pin is not changed
Actual Result
User can not leave the page without closing the app and restarting or picking a new pin
System Info
Type: Staging
Git hash: be307eb
Time: 2020.01.07-14.27.57
Size: 24883962
MD5: b9af2e939d61ee43574c73b5579299a1

Fixed in latest build


Implement OSM ingest plugin

I'm leaning away from making this a plugin, and instead a separate package.  If we only supported a one time ingest then we could probably work within the ingest framework, but we want to support delta updates, and for that we need to maintain a persistent ways/nodes/relations table.
This means ingest looks like
files -> mapreduce -> ways/nodes/relations -> mapreduce -> simple features
And for the case of delta updates we ideally don't want to do a full ways/nodes/relations -> mapreduce -> simple features step, but rather only process changed items.
There's also the case of simple feature representations are typically a subset, or view on the ways/node/relations data, and there may be use cases where we want to make multiple different views - so it's a bit different than the standard ingest workflow.

Let's discuss.

Re: discussion earlier - here's my initial cut at a proposal for the feature:
https://github.com/ngageoint/geowave/wiki/Support-Full-OSM-Stack-Toolchain

Due to dependencies and other requirements it makes more sense to build this as a separate project with a dependency on geowave.   Refactoring existing code and will move to here:
https://github.com/ngageoint/geowave-osm


Add ZippedImageDataset and MultiZippedImageDataset to document

This PR is to add document of ZippedImageDataset and MultiZippedImageDataset to chainer document.
No code modification is included.

Thanks, LGTM!
Jenkins, test this please.

Jenkins CI test (for commit b248250eb422924699e21ae73da6643ba40e6672) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

LGTM!

Jenkins CI test (for commit b248250eb422924699e21ae73da6643ba40e6672) succeeded without errors!


[Oracle] Use primary key as chunk key

[Oracle CDC] Use primary key as chunk key
Fix #2093

@e-mhui  Thanks your contribution, This feature is supported by pr https://github.com/ververica/flink-cdc-connectors/pull/2976 .


[Feature request] Run with... on certain filetypes

I don't even know if this is possible but maybe a feature that adds a 'Run with' in the context menu on certain filetypes.
For example if I right-click on a python script and run it in Powershell that it automatically enters the command and runs ith with the relevant program.
Or even just puts in the command so you can add extra args yourself?
I'm no powershell master but I don't think it would be that hard compared to what you already have (I really have no idea).

https://devblogs.microsoft.com/commandline/windows-terminal-preview-v0-9-release/
There is no such argument from Windows Terminal to open a file, so currently what you wanted cannot be implemented.

I delved into the code a bit and tried myself and now I see what you mean. Although this would be a nice option in your script.
Do you have any knowledge about such arguments being implemented or in the feature request list? Maybe for V1.0?
Perhaps i could fork, try it myself and create a pull request when this feature is implemented and functional?

I did some research after finding out what to google and there's a lot of talk about this subject indeed, even some talk of implementing the context menu by default.
I don't think it will be much longer until the command argument will be added since they've laid the groundwork already with the split pane argument stuff. I think this is the best place to follow up on the progress/ look at how they will implement it: terminal/doc/specs/#607.


feat: add logic for database migration handling downgrade

Perform a clean downgrade of the database when the app is downgraded from a newer test flight version to an older production version.
This ensures that the database schema is compatible with the older version by removing all existing tables.

Task linked: https://app.clickup.com/t/8695g1yw6


sm3_mb: Add performance test

Change-Id: Ib8f0007bff1ead6811c388be9a986e9a44d0c1cd
Signed-off-by: Jerry Yu<EMAIL_ADDRESS>

@gbtucker ，It is stolen from sha1_mb . Please review


Would be nice to be able to generate all/multiple tables at once.

You can do
schemats generate -c postgres://conn_url_here -t table_1 -t table_2 -t table_n -n SameNameSpace -o out.ts

I also believe this would be helpful. I think we could add an argument -s or --schema where if you provide it, we'd take all tables in this schema. I think schema is granular enough, I think all tables in database is too much because of information_schema and pg_catalog which we probably don't want.

I think we could add an argument -s or --schema where if you provide it, we'd take all tables in this schema.

Yes, good suggestion, and also very easy to implement

I think this issue can be close, it works now (there's a pending PR to update the readme).


Broken not import the game into HLTB

Have you defined the platforms?

yes ! platform is defined

no extension.log on my computer

here is my extensions.log

Same issue here, attaching my extensions.log as well in case it's needed
extensions.log


⚠ Samsung has degraded performance

In c58baec, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2378 ms

Resolved: Samsung performance has improved in cdf543a.


NIFI-10067: enable use of script when updating documents in Elasticsearch via PutElasticsearchJson or PutElasticsearchRecord

Summary
Cherry Pick of https://github.com/apache/nifi/pull/6628 from main to include the functionality with future NiFi 1.x versions.
NIFI-10067 enable use of script when updating documents in Elasticsearch via PutElasticsearchJson or PutElasticsearchRecord
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 11
[x] JDK 17

Licensing

~[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy~
~[ ] New dependencies are documented in applicable LICENSE and NOTICE files~

Documentation

~[ ] Documentation formatting appears as expected in rendered files~

Changes pushed to branch.


[BUG] - Modal not working with Next.js 14.2.x

NextUI Version
2.3.6
Describe the bug
I just tried to update from Next.js 14.1.4 and NextUI 2.5.6 to the latest Next.js stable version 14.2.3.
If I try to use and Next.js version that is 14.2.x (stable, not talking about canary), NextUI modals break.
I don't get any errors or warnings but the modals are invisible.
They are still opening and are added to the DOM but they have opacity: 0
This happens with any Modals without any configurations. They all work properly in 14.1.4 so I guess something gets incompatible starting with Next.js 14.2.0 with the NextUI animation so that the opacity animation is not working anymore.
The effect is that all modals are completely gone for the user.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Any Next.js 14.2.x project with any NextUI modal
Expected behavior
Modals are opacity: 0 -> expected to animate to opacity: 1
Screenshots or Videos
No response
Operating System Version
Windows / macOS
Browser
Chrome

I used 14.2.1 and didn't see any problem. Please provide a stackblitz project to demonstrate the issue.

Closing due to inactivity.


build: first time init issue

issues:

add fltk-dev and glut-dev to ubuntu init
cmake314 as root dep

pretty sure this is no longer relevant


E2C: OC's Network visualization

Who is your user?
OCF, Caroline Woolard
What are they trying to achieve?

As a host I want to be able to easily identify and visualize the biggest collectives I am hosting and the number of contributors. I would also like to notice overlaps between admins and contributors.

As a platform with a commitment to e2c we want to be able to visualize the active hosts, collectives, and contributors in our constellation so that we can engage each other as peers.

Follow-ups:

[ ] Visualize network connection between Collectives, Hosts and Platform
[ ] Visualize Collectives by volume raised and number of contributors in the past quarter.


Turn off unwanted verbosity from eksctl

Fixes #7
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I just noticed my editor did a lot of whitespace housekeeping... let me know if you want me to revert and push new commits with just the actual changes @couchgott


Review regarding how to block consumer apps

I think the following statement should be reviewed because now we have a save way to allow customers to block consumer services when the request come from behind a firewall:

Recommendation to block consumer access when the request to login.live.com came from behind a firewall capable of header injection: https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/tenant-restrictions#blocking-consumer-applications

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7dc5655-eddb-360e-8906-d61b8e12f667
Version Independent ID: c7939a12-24ce-5b98-c958-94a66b90ff1a
Content: Managing Office 365 endpoints - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/managing-office-365-endpoints.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@deividfoggi Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/6271
Thanks
Sri

@pandrew1  PR merge request pending. Thanks


mime: FormatMediaType doesn't allow to create Content-Disposition

On Go 1.4 (darwin), mime.FormatMediaType checks whether the first argument (aptly called mediatype) contains a forward slash, and returns an empty string if it doesn't. This doesn't allow to use this function to format a Content-Disposition header, because the values for such header are not proper media types (they are usually inline or attachment). Notice that the documentation of the reverse function mime.ParseMediaType explicitly says that it can be used to parse Content-Disposition headers, so it looks like this limitation should be lifted.

Yeah, looks like we're inconsistent here. Content-Dispositions are different, but we've supported them in ParseMediaType forever (my fault, I guess), despite them not being media types technically. So I guess we could be looser in FormatMediaType for symmetry.

Too late for Go 1.5.

If you wouldn't mind @rasky, could you provide me with some failing test samples or just values that should be accepted yet are failing? Thanks.

@odeke-em
fmt.Println(mime.ParseMediaType(`attachment; filename="????.png"; filename*=UTF-8''%E6%95%B0%E6%8D%AE%E7%BB%9F%E8%AE%A1.png`))
fmt.Println(mime.FormatMediaType("attachment", map[string]string{"filename": "数据统计.png"}))
fmt.Println(mime.FormatMediaType("attachment", map[string]string{"filename": "test.png"}))

Seems to be working with current Go (go1.11).

@andrius4669, does it? https://play.golang.org/p/ndwGaJDMBO4
I see:
attachment map[filename:数据统计.png] <nil>

attachment; filename=test.png

@zensh, do you expect the middle case to work? I guess it should encode it with UTF-8 the same way as the first line parses?

@bradfitz sorry, I didn't meant samples specified by zensh.
Initial issue about FormatMediaType and ParseMediaType not being symmetric about both allowing disposition has been fixed apparently, it now allows that.
It currently cannot encode non-ASCII unicode chatacters because it doesn't implement encoding specified in RFC 2231 section 4, and instead intentionally fail if it detects such input.
https://github.com/golang/go/issues/28849 was somewhat related to this (and I was told to fill separate feature request about RFC2231 encoding).
I guess this issue could be used for discussion about that encoding, if you think this is right.

Sorta working on this now.

https://github.com/golang/go/pull/29328

@andrius4669  👍


Simple project won't compile -- no error message.

I was trying to use a bump as a signer. When trying to recreate the issue with the minimum reproducible code, I noticed that this program that I would expect to compile, wouldn't
Source code:
# bugreport
# Built with Seahorse v0.2.5

from seahorse.prelude import *

declare_id("Fg6PaFpoGXkYsidMpWTK6W2BeZ7FEfcYkg476zPFsLnS")

class Protocol:
    bump: u8

@instruction
def init_protocol(signer: Signer, protocol: Empty[Protocol]) -> Program:
    protocol = protocol.init(payer=signer, seeds=["protocol"])
    protocol.bump = u8(0)

Error message on seahorse build
seahorse build
⠋ Compiling bugreport...thread 'main' panicked at 'explicit panic', src/core/compile/build/mod.rs:248:18
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
⠙ Compiling bugreport...%

Hi, sorry for missing this! This isn't a compiler bug, but there is an unreported reason behind the error. You need to make Protocol inherit from Account:
class Protocol(Account):
    bump: u8


Troubleshooting steps for the section related to "kubectl get pods -n voting"

4 out of 5 of my pods are stuck in a 'pending' state.  Any troubleshooting steps / workarounds? Thanks.
"voting-analytics-1-0-57c7fccb44-6t4cr   0/2     Pending   0          29m
voting-app-1-0-956756fd-dpsbl           0/2     Pending   0          29m
voting-app-1-0-956756fd-qnc6x           0/2     Pending   0          29m
voting-app-1-0-956756fd-t2p5l           0/2     Pending   0          29m
voting-storage-1-0-5d8fcc89c4-27zvg     2/2     Running   0          29m
"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b1812f-e2f3-f798-2788-611787994794
Version Independent ID: 3c593804-a3ef-24dc-cc82-0c4af12eb833
Content: Intelligent routing and canary releases with Istio in Azure Kubernetes Service (AKS)
Content Source: articles/aks/istio-scenario-routing.md
Service: container-service
GitHub Login: @paulbouwer
Microsoft Alias: pabouwer

Thanks for the feedback! We are currently investigating and will update you shortly.

If a Pod is stuck in Pending it means that it can not be scheduled onto a node. Generally this is because there are insufficient resources of one type or another that prevent scheduling. Look at the output of the kubectl describe pods ${POD_NAME} command. There should be messages from the scheduler about why it can not schedule your pod.
One of the reason could be, you don’t have enough resources: You may have exhausted the supply of CPU or Memory in your cluster, in this case you need to delete Pods, adjust resource requests, or add new nodes to your cluster.
Refer to this document.

@kristianjaeger If a Pod is stuck in Pending it means that it can not be scheduled onto a node. Generally this is because there are insufficient resources of one type or another that prevent scheduling. Look at the output of the kubectl describe pods ${POD_NAME} command. There should be messages from the scheduler about why it can not schedule your pod.
One of the reason could be, you don’t have enough resources: You may have exhausted the supply of CPU or Memory in your cluster, in this case you need to delete Pods, adjust resource requests, or add new nodes to your cluster.
Refer to this document.

@Karishma-Tiwari-MSFT Thanks.  I will try again and use those steps if needed.  Cheers.

Thanks @kristianjaeger for the update.
We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


sparcc returns no results?

Would this be expected? Found on qa

Found again on qa today

Rserve says
Error in if (correlationCoef < 0) { :
  missing value where TRUE/FALSE needed

fixed in rserve 8.1.3


Error Code 199 Protractor

Below is my the error i see. I am new to protractor and i keep getting error 199. I am using Protractor version 5.1.1
PS C:\Users\a6mh1zz\Documents\visual studio 2015\projects\nodejsconsoleapp13\nodejsconsoleapp13> protractor conf.js
[14:49:24] I/launcher - Running 1 instances of WebDriver
[14:49:24] I/hosted - Using the selenium server at http://localhost:4444/wd/hud
[14:49:24] E/launcher - Unable to parse new session response:

Selenium  v.

      Whoops! The URL specified routes to this help page.

      For more information about Selenium  please see the
      docs and/or visit the wiki.

        Or perhaps you are looking for the Selenium  console.

      Happy Testing!

      Selenium is made possible through the efforts of our open source community, contributions from
      these people, and our
      sponsors.

[14:49:24] E/launcher - WebDriverError: Unable to parse new session response:

Selenium  v.

      Whoops! The URL specified routes to this help page.

      For more information about Selenium  please see the
      docs and/or visit the wiki.

        Or perhaps you are looking for the Selenium  console.

      Happy Testing!

      Selenium is made possible through the efforts of our open source community, contributions from
      these people, and our
      sponsors.

    at WebDriverError (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdriver\lib\
error.js:27:5)
    at doSend.then.response (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdrive
r\lib\http.js:445:19)
    at process._tickCallback (internal/process/next_tick.js:103:7)
From: Task: WebDriver.createSession()
    at Function.createSession (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdri
ver\lib\webdriver.js:777:24)
    at Function.createSession (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdri
ver\chrome.js:709:29)
    at createDriver (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdriver\index.
js:167:33)
    at Builder.build (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\selenium-webdriver\index
.js:623:16)
    at Hosted.getNewDriver (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\lib\driverProviders\driverProvi
der.ts:60:29)
    at Runner.createBrowser (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\lib\runner.ts:225:39)
    at q.then.then (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\lib\runner.ts:391:27)
    at _fulfilled (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\q\q.js:863:3
0)
    at Promise.promise.promiseDispatch (C:\Users\a6mh1zz\AppData\Roaming\npm\node_modules\protractor\node_modules\q\q.js
:796:13)
[14:49:24] E/launcher - Process exited with error code 199
Here is my conf.js file
//conf.js
exports.config = {
framework: 'jasmine',
seleniumAddress: 'http://localhost:4444/wd/hud',
specs: ['spec.js']

Hi there!
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
Also, please properly format your test output and configuration file when posting on StackOverflow.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


Transition from NavContainerHelper to BcContainerHelper is not easy

I decided to move from navcontainerhelper to bccontainerhelper. The move is more complex that it looked. Biggest issue is, that I need to recreate all running containers, because they are now mapped to c:\programdata\navcontainerhelper but the bccontainerhelper needs them to be mapped to c:\programdata\bccontainerhelper.
Example is cmdlet Publish-BcContainerApp, which fails with error:
'''
Could not find a part of the path 'C:\ProgramData\BcContainerHelper\Extensions<containername><appfilename>'
'''
Yes, because the container was created from navcontainerhelper.
BcContainerHelper 1.0.1-preview146
Is there some simple tool/path how to remap the containers to the new folder?
Could bccontainerhelper support such a containers? (backward compatibility).

if you place a file in c:\programdata\bccontainerhelper called bccontainerhelper.config.json
containing
{
    "hostHelperFolder": "c:\\programdata\navcontainerhelper",
    "containerHelperFolder": "c:\\programdata\navcontainerhelper"
}

Then it should use the same folder as navcontainerhelper.

Thanks!
It is working as expected.


Enable traversal of graph on UI by depth

Currently the Superglue UI only allows us to see the lineage of depth 1. However, the backend API has capabilities for different depths (1 through 4, -1 for full lineage), so we want to augment the UI to display those lineages to the user.
Describe the solution you'd like
We want to have a drop down that will let you choose the depth, and make a call to the backend with the new depth. Then the UI can display the new lineage with the new depth once the fetching is complete.
Describe alternatives you've considered
We are open to other approaches in displaying different depths on the UI.
Additional context
Add any other context or screenshots about the feature request here.

Hello, I am interested in this issue and the Superglue project as a whole. I have had an issue with setting up the development environment. Once I finished loading the example data with superglue elastic --load, I went to http://localhost:8080 and saw the following screen:

I have attached the docker logs:
superglue_docker.log
that have this error:
nginx       | <IP_ADDRESS> - - [16/Oct/2020:17:34:46 +0000] "GET / HTTP/1.1" 502 560 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.80 Safari/537.36"
nginx       | 2020/10/16 17:34:46 [error] 6#6: *1 connect() failed (113: No route to host) while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:3000/", host: "localhost:8080"

Hello, I am interested in this issue and the Superglue project as a whole. I have had an issue with setting up the development environment. Once I finished loading the example data with superglue elastic --load, I went to http://localhost:8080 and saw the following screen:

I have attached the docker logs:
superglue_docker.log
that have this error:
nginx       | <IP_ADDRESS> - - [16/Oct/2020:17:34:46 +0000] "GET / HTTP/1.1" 502 560 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.80 Safari/537.36"
nginx       | 2020/10/16 17:34:46 [error] 6#6: *1 connect() failed (113: No route to host) while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "GET / HTTP/1.1", upstream: "http://<IP_ADDRESS>:3000/", host: "localhost:8080"

This is a very old issue, but I am commenting for those who are encountering the same issue. Try increasing the RAM of the docker container to more than 2G, and restart all the services. Then try the steps from superglue parse and then on.

I'm interested in working on this issue but would like to better understand what language the graph traversal should be coded in.


Automatic instrumentation fails after setup

Describe the bug
After setting up .NET tracing using DataDog documentation web application starts logging errors non-stop. Error example:
[2018-09-18 14:25:41] [Error] An error occured while sending traces to the agent at http://localhost:8126/v0.3/traces System.Net.Http.HttpRequestException: Response status code does not indicate success: 400 (Bad Request).    at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()    at Datadog.Trace.Agent.Api.<SendAsync>d__81.MoveNext()`
And at the same time there is an error on trace-agent side:
2018-09-19 08:11:26 ERROR (receiver.go:386) - cannot decode v0.3 traces payload: msgp: attempted to decode type "nil" with method for "str"
Attempts to turn off automatic instrumentation do not work (there is no clear documentation on how to turn it off):

Set apm_config:enabled: false
Turn off trace agent
Do iis_reset
Redeploy the application

To Reproduce
Steps to reproduce the behavior:

Follow the documentation available at official website.
Find yourself in a quite of a pickle.

Expected behavior
Application does not throw exceptions after being set up.
Runtime environment (please complete the following information):

Instrumentation mode: automatic
Tracer version: 0.3.0
OS: Windows Server 2012 R2
CLR: .NET Framework 4.5.1

Additional context
Our application includes MsgPack library. Maybe it conflicts with the one used in the injected CLR code Data Dog is using.

It looks like the agent is more restrictive in the format its allowed to receive than what the tracer is producing. I think we can add code to where the tracer sends spans to remove nil strings or set them to the empty string.
To disable automatic instrumentation you have to remove an environment variable. (SET COR_ENABLE_PROFILING=0) We should document this, but we should also provide a way to configure this through the apm section of the datadog agent config yaml. We should also limit the amount we log on errors, since the trace agent being down is entirely possible under normal usage.
@vasiliy0 besides the noise in the logs, did this break the application? Or did IIS continue to work properly?

@dd-caleb thank you for quick response. I will try your suggestions to turn off instrumentation.
Regarding the application, it works as intended without breaking. The excessive logging might be the issue though, if someone is using cloud log aggregators with limited number of events allowed.
What can be an ETA on the new version with fixed tracer?

Regarding the environment variables, the installer sets these only for the IIS service, not system-wide, otherwise we would attach the profiler to every .NET process in the host. You can find the Environment values in the Windows Registy at:
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\W3SVC

Remember also that IIS won't recognize changes to the environment variables until the host is rebooted. Instead of modifying these values by hand, uninstalling the msi will remove the environment variables and delete the files installed into the GAC and Program Files folder.
If you don't have a UI (e.g. Windows Server Core), you can use the following commands from an administrator command prompt:
msiexec.exe /qn /norestart /uninstall DatadogDotNetTracing-0.3.0-x64.msi

If you don't have the msi file handy, use the Product Code:
msiexec.exe /qn /norestart /uninstall {359AD4E1-5CD3-4920-A5BF-2A12DD812D1C}

@lucaspimentel thank you for your comment.
Removed tracer and ran iisreset, logging errors stopped. Seems like it is enough for IIS to update environment variables.

@vasiliy0: We released 0.3.1-beta which should fix this errors. Thanks again.


Navbar

rebuilt using only material ui.

Does not look mergeable to me.  I cant see the inputs on login page, landing page and the dashboard and activities page are not right.  For example, see the login page below

A small oversite - forgot to re-add materialize and I fixed the overlap issue. Should be fine now

Nice !


Unable to build

Hi Axel,
I've been wanting to try this add-on; however, when I try to build it I get following errors:
C:\projects\simple-content-stores-master>mvn clean install
[INFO] Scanning for projects...
Downloading: https://oss.sonatype.org/content/repositories/snapshots/de/acosix/a
lfresco/maven/de.acosix.alfresco.maven.module.parent/<IP_ADDRESS>-SNAPSHOT/maven-meta
data.xml
Downloading: https://oss.sonatype.org/content/repositories/snapshots/de/acosix/a
lfresco/maven/de.acosix.alfresco.maven.module.parent/<IP_ADDRESS>-SNAPSHOT/de.acosix.
alfresco.maven.module.parent-<IP_ADDRESS>-SNAPSHOT.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for de.axelfaust.alfresco:de.axelfaust.alfresc
o.simplecontentstores:<IP_ADDRESS>-SNAPSHOT: Could not find artifact de.acosix.alfres
co.maven:de.acosix.alfresco.maven.module.parent:pom:<IP_ADDRESS>-SNAPSHOT in ossrh (h
ttps://oss.sonatype.org/content/repositories/snapshots) and 'parent.relativePath
' points at wrong local POM @ line 5, column 13
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project de.axelfaust.alfresco:de.axelfaust.alfresco.simplecontents
tores:<IP_ADDRESS>-SNAPSHOT (C:\projects\simple-content-stores-master\pom.xml) has 1
error
[ERROR]     Non-resolvable parent POM for de.axelfaust.alfresco:de.axelfaust.alf
resco.simplecontentstores:<IP_ADDRESS>-SNAPSHOT: Could not find artifact de.acosix.al
fresco.maven:de.acosix.alfresco.maven.module.parent:pom:<IP_ADDRESS>-SNAPSHOT in ossr
h (https://oss.sonatype.org/content/repositories/snapshots) and 'parent.relative
Path' points at wrong local POM @ line 5, column 13 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e swit
ch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please rea
d the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildin
gException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableMo
delException

Apologies for that. I have published a new version of the parent POM last week (http://search.maven.org/#search|ga|1|a%3A"de.acosix.alfresco.maven.module.parent") which has resulted in its SNAPSHOT being automatically deleted a few days later.
I am still figuring out how to properly deal with the delays inherent with Maven Central hosting. E.g. I cannot switch the reference immediately in the project because the new parent version takes up to 24 hours to be available after publication. This is not the only addon affected by this - some even have multi-level dependencies (A -> B -> C) which means I can update them only 24 hours apart so they don't fail their builds. This all isn't very satisfying...
The build is now fixed - the project now uses the released variant of the parent POM.


Temperature Events doesn't work when using AdvancedSeasons 1.5.1

Describe the bug
Couple hours ago i installed AdvancedSeasons 1.5.1 on minecraft purpur 1.21.1 server and temperature effects doesn't seem to work basically no freezing, sweating etc.. Everything in the configs is default however i managed to fix this issue when downgrading to 1.5.0
Also seasons 1.5.1 starts normally no console errors
How to reproduce
My setup
1# Mc server running purpur build #2324 1.21.1
2# AdvancedSeasons 1.5.1 and default config
Screenshots / Videos
No response
Server Log
No response

Fixed for an update soon!


fix configMapKeyRefs example in kaminion values.yaml

https://github.com/redpanda-data/kminion/blob/4ad4177ce644b794ee3807f4da3fe793ce93aeec/charts/kminion/templates/daemonset.yaml#L80

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bugfix/dubbo attachment

Motivation:

Fix the problem: "When a server received dubbo requests and send another duubo reuqest to other server, its client span is lost."

Modification:

Remove usage of ConcurrentHashMap in 2.6.X DubboSofaTracerFilter, bacause Invoker is reused, we cannot use it as a map key. And invokers between invoke and onResponse are different, which causing the lost of spans.
remove tracer-key from RpcContext when serverReceived
use traceId+spanId as key o remove usage of ConcurrentHashMap in 2.6.X DubboSofaTracerFilter in 2.7.X DubboSofaTracerFilter
put tracer string into RpcContext in 2.6.X and 2.7.X DubboSofaTracerFilter

Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

CI MUST BE PAAS


Other formats other than markdown? Popular Plugin shortcuts?

I will put your markdown into many other formats if you'd like. Ill fork it and maybe put these all in a PDF.
Maybe shortcuts to some more popular plugins could be added? Just a thought.

If you have suggestions for adding additional shortcuts, feel free to create a PR. I've created this list based on what I'm using - other people are probably using other plugins...
Feel free to create a PDF if you like - this repo is using the MIT license: https://github.com/nwinkler/atom-keyboard-shortcuts/blob/master/LICENSE.md

Cool thanks :+1:


Unable to install edgex-go related package

Wanted to use EdgeX Ireland version (2.0.0), for that:
To build the edgeX-go natively I am following the READme file.
Started to install the dependency packages,
1.My Go version is 1.17
2. For having :pkg-config- I executed the below command,
go get github.com/rjeczalik/pkgconfig/cmd/pkg-config
rakshitha@xxx:~/Ireland$ go get github.com/rjeczalik/pkgconfig/cmd/pkg-config
When executed that I am getting the following,
go get: installing executables with 'go get' in module mode is deprecated.
Use 'go install pkg@version' instead.
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
AS per the information above, I did as below,
rakshitha@xxx:~/Ireland$ go install pkg@version
go install: pkg@version: malformed module path "pkg": missing dot in first path element
For information: my go env is:
rakshitha@xxx:~/Ireland$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/rakshitha/.cache/go-build"
GOENV="/home/rakshitha/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/rakshitha/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/rakshitha/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3725321080=/tmp/go-build -gno-record-gcc-switches"
Kindly help me to natively build the edgex go services successfully.

Okay, thank you @cloudxxx8

opened https://github.com/edgexfoundry/edgex-go/issues/3689 to update the Readme file.


I have implemented superselectfield along with component Focustrap(focus-trap-react": "^3.0.3") for focusing fields in a form and tabbing purpose.In this case, the textfield of superselect field is not focused although the menu opens properly.This happens on mouse click and keyboard enter as well.

Hello @nitupune
Can you rewrite properly your issue please ? ie not in the title ...

Did you ever fix this? I'm having the same issue when using superselect inside a dialog component from material-ui 3.x (note that I still keep 0.2.x for this component)


enable kuberay to run in one single namespace scope.

Why are these changes needed?
enable kuberay to run in one single namespace scope.
Related issue number
#227
Checks

[X] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[X] Manual tests
[ ] This PR is not tested :(

@wilsonwang371 I merge #254 and this can be rebased and updated


App is not install.

HI there.
After cloning your project app is not install on android phone, or this project is not maintain by developers
Steps:-

Clone the project.
Npm install.
react-native run-android  it's throw error
Scanning 627 folders for symlinks in /home/sunny/projects/React-Native-Music-Player/node_modules (4ms) JS server already running. Building and installing the app on the device (cd android && ./gradlew installDebug)... Could not install the app on the device, read the error above for details. Make sure you have an Android emulator running or a device connected and have set up your Android development environment: https://facebook.github.io/react-native/docs/android-setup.html

Issue is self explanatory, there is issue with your testenvironment. You need have a device or emulator to running so that react can install app.


Drop custom SQLite and libco

Signed-off-by: Free Ekanayaka<EMAIL_ADDRESS>

jenkins: test this please


Fix the keystone endpoint error in dashboard

What this PR does / why we need it:
Change the service ip to <IP_ADDRESS> in image_builder.sh under dashboard folder.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 43.944% when pulling 853ad0c6c007cfe0d56ce31648456191175c395c on leonwanghui:fixer into 859a9e875858249a20b83e965a0793eb7de9b0af on opensds:development.


Switching to Garnet Causes "ERR unknown command" Redis Error in Node.js Application

There is a nodejs application that uses redis without problems, but if I switch to garnet this error will appear:
node:internal/process/promises:288
             triggerUncaughtException(err, true /* fromPromise */);
             ^

[ErrorReply: ERR unknown command]

Node.js v18.19.1

This is the client configuration
const client = redis.createClient({
     url: 'redis://<IP_ADDRESS>:3278'
});

This is garnet's log
08::57::25 dbug: GarnetServer[0] [****:3278] Accepted TCP connection from <IP_ADDRESS>:48968
08::57::25 dbug: Session[0] [****:3278] [<IP_ADDRESS>:48968] [0014B75E] Starting RespServerSession
08::57::25 dbug: Session[0] [****:3278] [<IP_ADDRESS>:48968] [0014B75E] Disposing RespServerSession

which command did you run? see the list of commands currently supported here: https://microsoft.github.io/garnet/docs/commands/api-compatibility

which command did you run? see the list of commands currently supported here: https://microsoft.github.io/garnet/docs/commands/api-compatibility

It looks like I executed the unsupported command "FLUSHALL"

How is it completed? Seems like a good issue to leave open to the community to fix to me.
Strawman unit test...
        [Test]
        public void SeFlushAllDatabasesTest()
        {
            using var redis = ConnectionMultiplexer.Connect(TestUtils.GetConfig(allowAdmin: true));
            IServer server = redis.GetServer($"{TestUtils.Address}:{TestUtils.Port}");

            for (int dbNum = 0; dbNum <= 1; dbNum++)
            {
                var db = redis.GetDatabase(dbNum);

                string origValue = "abcdefghij";
                db.StringSet("mykey", origValue);

                string retValue = db.StringGet("mykey");
                Assert.AreEqual(origValue, retValue);
            }

            server.FlushAllDatabases();

            for (int dbNum = 0; dbNum <= 1; dbNum++)
            {
                var db = redis.GetDatabase(dbNum);
                string retValue = db.StringGet("mykey");
                Assert.AreEqual(null, retValue);
            }
        }

The workaround is to use FLUSHDB which is supported and identical.


keyboard do not work

keyboard work only with tview - github.com/rivo/tview v0.0.0-20200507165325-823f280c5426

Fixed in 493c730

Fixed in 493c730


Implement Project Infrastructure in New Rest-API Repository

Parent Feature
#1
Task Description
As an AaC Developer, I want my project infrastructure implemented within the rest-api repository, so that I provide a consistent and quality plugin.
Acceptance Criteria

[ ] Include pertinent pieces from /.github directory.

[ ] Include pertinent workflows for pipelines.
[ ] Include pertinent issue templates for requests and tracking.

[ ] Update to reference new repository housing location.

[ ] Include pertinent documentation requirements and configurations.

[ ] Ensure from the /docs directory that the necessary documentation configurations and structure were brought over.

[ ] Include pertinent project requirements and configurations.

[ ] Root level configuration and infrastructure pieces, i.e. setup.py or pyproject.toml.

[ ] Configure repository for proper permissions.

[ ] Match configuration of core AaC Repo.

should have closed with PR, looks like something didn't link. Also moved a chunk of this task's responsibility up to org level so we only have to maintain one instance and not keep re-initiating them in each repo.


feat(date-picker): add clear button to reset the date-picker value

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Right now there is no way to clear the value from the date-picker unless using a mouse or keyboard to delete character by character.
This PR introduces a way to use clear btn do this for you.

The button has to be visible only when there is a value into the date-picker.

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Close: #2718

There is this change right now, that the icon is changed from times-circle to times only - The original icon from the design proposal is not part of the Core icons so until we decide to change it - I gonna leave it like that.
Other option will be to copy and import the icon manually as part of this component?

Other option will be to copy and import the icon manually as part of this component?

That's not a viable option until we have the @clr/core icons available.
Why was times-circle chosen in the first place? The additional stroke around the 'X' seems to be visual noise to me and I don't know what an encircled 'X' communicates that a normal 'X' would not...

It's part of the original story and the design mockups.

I also, find the simple X good enough on indicating what will be the end result.
If everyone is fine with that, let's keep the times icon that is already part of the Core Icons and if in feature release we need to add the circle we could just patch it. Or the best case will be to use it from @clr/core/icons

I have a much simpler implementation to show you. There is too much manual handling, we just need to have a simple button that uses the NgControl.reset() method to clear the input.

It looked a lot more simple but it's not working in the cases that we don't use the NgControl. I tested it inside the dev app and have a 50% success rate. For example on the first demo, that relay on ngModel it was false. There are few ways to send manage the internal state of the date-picker and this just don't cover all of them.
I didn't get why we need to have this clrClearEnabled - is there any need to enable/disable the clear button or even providing the option to do it?

I have the clrButtonEnabled option to allow people to turn it on or off. I would want this to be applied to all inputs if we make it on by default. I haven't dug far enough into your implementation, but having to use ChangeDetectorRef is a concern that I don't think we should have to have for this.

I've updated my demo example of what I would be expecting to address the non-angular form case.
https://github.com/gnomeontherun/clarity/commit/56eb233beb924726a73142cbda3ee4e5fda3a5e0


Configure Renovate - 7

[Auto generated]
Number: [#7]

python-simple-logger: Closing issue for PR: Configure Renovate - autoclosed.
PR was closed.


Add compat function to ensure a type is text like

Not entirely sure this is the right approach in both versions.

Current coverage is 97.53% (diff: 20.00%)

Merging #1103 into develop will decrease coverage by 0.11%

@@            develop      #1103   diff @@
==========================================
  Files            44         44
  Lines          7007       7017    +10
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6842       6844     +2
- Misses          165        173     +8
  Partials          0          0

Powered by Codecov. Last update 93d01c5...a66ef14

Moving to cli.


Updated Contributors Section in readme.md

Fixed Issue #126

@puyuan1996 I have added Contributors section in reame.md kindly review it !! Thank you !!
ps:- I have also added the same in Readme.zh.md in another PR.


Fix the dependabot config

A quote was missing in the config due to which dependabot.yml is invalid.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/test check-pr-has-kind-label

/test all

/retest

/test pull-tekton-pipeline-integration-tests

/assign @vdemeester
Are yamllint tests running? Do we have those disabled for pipelines?

They might not run on .github 🙃


#182: Fixed issue with content-type getting set when using the gitlab…

… token. Surpressing Accept header as well.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 76.809%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ui/modules/urlExport.ts
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
478

Relevant Lines:
616

💛  - Coveralls

Setting up this draft PR for review. I still need to run some tests with my colleague to make sure this is working properly before this is merged in.
@lukasoppermann you will notice this code suppresses any changes to the content type. The Authorization header was already doing the same check so I changed the code to include a single IF statement. I felt it made sense to include the Accept header as well but please let me know if you want me to remove that from this check.

Hey @dgmartin makes sense generally, however I like to avoid nested if statements, as they make reasoning about the code more difficult.
Could we adjust this so that we have only 1 level of if statements without nesting?

@lukasoppermann I was able to make the changes required the headers. Hopefully your ok with the changes I've made but let me know if there is anything else you need fine tuned.
This is the first time I've tried to write unit tests for any web language. I hit a few major hurdles but I managed to complete what I wanted too. Please review the code and let me know if it looks good to you. I still need run a manual test with my colleague to make sure everything exports to Gitlab as intended  but he is unavailable until tomorrow morning. I hope to run a final test with him then and mark this as ready for final review.

Hey @dgmartin thank you very much, this looks very good.
I only have 2 tiny comments I added to the code.

🚀  Okay, it is shipped. Thank you for your great work. 👍


Add Flows to CALM

Feature Request
Description of Problem:
CALM as of 2024-09 provides a flexible solution for capturing detailed technical architectures and control requirements to enable us to apply constraints onto individual system architectures and reusable patterns. Furthermore we have proved that we can go from architectural constraints in CALM to infrastructure as code / configuration in deployed environments, specifically k8s.
As we look to address more architecture control domains such as resiliency, it becomes apparent that in any sufficiently complex system we will have multiple flows going through the same nodes and relationships. This poses a problem when we're looking to add controls as a requirement such as latency or recovery time must represent the most critical flow.
This can have the effect of obscuring where 99% of flows may have very different requirements to the 1% (e.g. 24 hour recovery vs. 5 minutes). This actually means we can't make decisions such as moving the critical flows to separate systems / components.
Additionally, it is very hard to communicate to developers, especially on older systems, what business processes it is that the system they're developing pertain to or to ask questions about what business flows are impacted by particular changes to the software.
Potential Solutions:
We should add a new "Flow" construct into the CALM model. This would allow us to capture, in business terms, the purpose of a flow and should enable us to map that flow to the technical components (nodes / relationships) that it flows through and in what order. We should also be able to attach control requirements / configurations to business flows; this would enable us to place controls where they make most logical sense (note, I am not suggesting controls can't be put on the technical architecture, different controls make sense to be places in technical vs. business architecture depending on the control).
There seem to logical options we could pursue:

Add a new top level collection to CALM which would allow us to capture business flows related to specific architecture document.
Add a standalone construct which would enable us to capture individual flows as discrete artefacts which could be stored in a suitable artefact store, but which could reference one or more technical architectures using a similar mechanism to the detailed-architecture link.

I am leaning to the second option being more versatile, although think discussion is required.

@LeighFinegold
@develontopia
@dc-ms

Adding a "Flow" construct to the CALM model will significantly enhance our ability to manage and understand complex systems. With an observable architecture, there are lot of benefits that can be had:-
Dynamic Flow Views: This will allow us to dynamically build flow views of our architecture, providing clearer insights into how various components interact within the system.
Change Management: Communication around change management becomes much more straightforward. If we can clearly identify how changes impact business flows, it streamlines discussions and decisions.
Risk Assessment: We can calculate risk scores more effectively of a change. For example, if I change component X, we can immediately see its impact on 20 business flows, allowing for more informed decision-making.
Component Strain: This approach also enables us to rationalize whether we are placing too much strain on certain components, leading to better resource allocation and system performance. (
I’ve taken a stab at a first version https://github.com/finos/architecture-as-code/issues/426 to kick off the discussion. I think flows only require relationships from main architecture definition, as nodes can then be derived.  It’s possible I've conflated another concept that CALM needs/will have in relation to data lineage when trying to come up with flow business requirements. Also I assume maybe this spec needs to also link evidence that we have implemented the flow?
Looking forward to see how this definition evolves.

@rocketstack-matt @LeighFinegold duplicate issue of: #303 ?


React 16.4 warnings Unsafe lifecycle methods

When updating to React 16.4 It throws warnings because of the use of lifecycle methods that are unsafe for async rendering.

ReactQuill v2 is now fully TypeScript and React16+, and uses no deprecated lifecycle methods anymore.
Please try the latest v2 beta. The upgrade should be drop-in.


How to download to the brick?

Hi there!
The instructions read, "Once connected you can start a running program by choosing its slot."
However it doesn’t say where or how to choose its slot.  Can you please elaborate?
Thanks in advance!
Philip

Hey @dphaine , there are two ways to select a slot:

When you use the "LEGO Hub: Run program" you will be asked for a slot and also the type of the program you are uploading. This is show on the screenshots just below the text you quoted above.
The other way is by specifying a predefined file header comment as explained here: https://github.com/PeterStaev/lego-spikeprime-mindstorms-vscode#automatic-uploadstart-of-a-python-file

Thank you for your quick response Peter!
The (obvious) bit that we missed was Cmd-Shift-P and then start typing the command.  It might be nice to include this for the noobs.
Big thanks for creating this tool. The Lego editor is painfully buggy so we look forward to using vscode.
Philip

On Aug 6, 2022, at 7:55 AM, Peter Staev @.***> wrote:
Hey @dphaine , there are two ways to select a slot:
When you use the "LEGO Hub: Run program" you will be asked for a slot and also the type of the program you are uploading. This is show on the screenshots just below the text you quoted above.
The other way is by specifying a predefined file header comment as explained here: https://github.com/PeterStaev/lego-spikeprime-mindstorms-vscode#automatic-uploadstart-of-a-python-file
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Yes, the Ctrl+Shift+P is one way to run the program. But also you can use the buttons at the top right of the editor:

Just keep in mind that the first one ("Run Python File") is the default python one that executes locally, which can't work as locally you do not have the hub sepcific libs. Just look for the "Lego Hub:" prefixed ones, those are the ones coming from this extension :)


Support for descriptions on third-party subcommands in cargo --list

What does this PR try to resolve?
This PR implements my proposal in #10662 to enable cargo --list to show descriptions of third-party subcommands, not only the subcommands which are built into Cargo.
How should we test and review this PR?
I have included an ELF note containing a description in the most recent version of the cargo-expand crate. You can confirm that cargo --list is able to print a description for that subcommand (on Linux only, to begin with).
$ cargo install cargo-expand --force
$ gh pr checkout 10663
$ cargo run -- --list

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

:umbrella: The latest upstream changes (presumably #10804) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased to resolve conflict with #10804 due to touching adjacent lines of /Cargo.toml.

:umbrella: The latest upstream changes (presumably #11029) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased to resolve conflict with #11029

:umbrella: The latest upstream changes (presumably #11159) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased to resolve conflict with #11159

:umbrella: The latest upstream changes (presumably #11369) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased to resolve conflict with #11369 in Cargo.toml

:umbrella: The latest upstream changes (presumably #11807) made this pull request unmergeable. Please resolve the merge conflicts.

I'm sorry for not responding sooner. I'm going to close since nobody on the team has the capacity to help with this at this time. I've followed up on #10662 with some thoughts we had on the design. I think there might be some more discussion needed on the design, but I don't think any of us can follow up with it right now. Hopefully at some time in the future we can engage with this idea more.


Fixes for stuff and things

Mostly fixes to make the P2A bridge usable for updating the BMC flash. There's also some cleanups to the AHB tracing code to make it a bit easier to use.

Merged at 1f644d180eeb7752e1c4d12bbfb6fcc40b0d4676
Thanks @oohal!


Add build status badge to readme

Signed-off-by: Kathryn Baldauf<EMAIL_ADDRESS>

thank youuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu


add User-Agent

Implemented (https://github.com/Kyabc/splatoon-notificator/commit/47a02ddec5689680443fcb913a55ba9553b4074a)


Always use Modflow way of storing layers (no 3d top in layer Datasets anymore)

Right now we use two definitions to store a layer/model Dataset:
1 With a 3d top, where top and bottom can contain NaN's: a layer Dataset
2 With a 2d top (or 1d for vertex grids), where top and bottom do not contain NaN's: a model Dataset
This creates a problem where methods only work for one of the above Datasets. I propose to adopt the Modflow-way of storing data for every layered Dataset, so to only store the top of the top layer, and the bottom for all layers.
This means that the method nlmod.read.get_regis() will then return something different. Regis sometimes has some holes in the layer model: the bottom of one layer is not equal to the top of the next layer. I think we should notify the user in which layer this takes place, when we remove the layer-dimension from top, using some log-messages.
This would break some peoples code, but will make life easier in the future, and saves us a lot of checking for a layer-dimension in top.

This is implemented. If you want to know how large in the holes in the layer model are, you can run:
regis = nlmod.read.regis.get_regis(extent, drop_layer_dim_from_top=False)
nlmod.layers.remove_layer_dim_from_top(regis, return_inconsistencies=True)


Support JSR305 Nonnull and Nullable annotations

J2objc has a partial support of nullability annotation with swift.
https://groups.google.com/forum/#!topic/j2objc-discuss/zNt2eMcLvlY
I think we can achieve this by writing a plugin, but I am not really sure.
I want to do is add the annotation to the spec fields:
@Nonnull String exampleVariable;
And the expected getter/setter would be:
@Nonnull public String getExampleVariable() {
return get(EXAMPLE_VARIABLE);
}
public String setExampleVariable(@Nonnull  exampleVariable) {
    set(EXAMPLE_VARIABLE, exampleVariable);
    return this;
}

Do you think that a plugin is the right way to do it? Do you have any hints on how can this be implemented ?
Thanks

Yep! A plugin is definitely the right way to do this if you want this functionality right now. Note also though that issue #155 is still open, and I'm hoping to add the JSR305 annotations across the public API of squidb in a future release. This effort would probably include some kind of code generation enhancement for model objects like what you've suggested, so such a plugin would become unnecessary at that point. No timeline at this point, but the effort is ongoing, slowly and steadily.
Adding a nullability annotation to the getter/setter with a plugin are fairly easy. You could simply create a plugin that overrides beforeEmitGetter() and beforeEmitSetter(). In the former, you'd simply write out the proper annotation:
public void beforeEmitGetter(JavaFileWriter writer, PropertyGenerator propertyGenerator,
    MethodDeclarationParams params) throws IOException {
    if (propertyGenerator.getField() != null && propertyGenerator.getField().getAnnotation(Nonnull.class) != null) {
        writer.writeAnnotation(new DeclaredTypeName("java.annotation", "Nonnull"));
    }
}

Doing it for the setter is a little hackier, but you could probably fake it by including the annotation in the setter parameter name:
public void beforeEmitSetter(JavaFileWriter writer, PropertyGenerator propertyGenerator,
    MethodDeclarationParams params) throws IOException {
    if (propertyGenerator.getField() != null && propertyGenerator.getField().getAnnotation(Nonnull.class) != null) {
        String newArgName = "@Nonnull " + params.getArgumentNames().get(0);
        params.setArgumentNames(Arrays.asList(newArgName));
    }
}

Hope that helps! I'm going to close this issue as a duplicate of #155 and link back to it from there. You can watch that issue for updates on the effort to include nullability annotations.

Thanks @sbosley, very useful. I changed the beforeEmitSetter method because it writes the annotation after the type. It doesn't work with java 1.7.
I created a plugin here: https://github.com/aminelaadhari/squidb-nullable
One remaining problem is that ModelMethodPlugin doesn't copy the annotations.

Yeah, until we get full nullability support throughout the squidb codebase, the default code generator plugins won't support it either. We'll probably have to make some modifications to our apt-utils library too, since it was written for Java 1.6 and doesn't have good APIs for annotations on method params.
Still, if you like you can easily reimplement the ModelMethodPlugin yourself and disable the default one with a flag!

I will do that, thanks !


Accept windows paths for image processing

This enhances our regex to support windows style paths.  The regex will match invalid path specifications, but we'll still validate file existence and filter out mismatches
Fixes #1794

Example usage:
PS C:\Users\Daniel\code\ollama> .\ollama.exe run llava
>>> describe this image c:\Users\Daniel\Downloads\download.jpg
describe this image c:\Users\Daniel\Downloads\download.jpg
Added image 'c:\Users\Daniel\Downloads\download.jpg'
 The image displays two hot dogs placed on a table, with mustard drizzled on top. One of the hot dogs appears to be half-eaten or
partially gone. They are accompanied by some chips which seem to have a few pieces missing. The scene creates an impression of
enjoying a meal together.

The description isn't quite right, but the image did have 2 hot dogs.


Feature/#45 nadir pointing science mode

Description
Closes Issue #45
Added functions to perform Continuous Nadir Scanning. Now, if in imaging mode and within the attitude requirements, it will constantly store new data.
How should this pull request be reviewed?

[X] By commit
[ ] All changes at once

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[X] Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
[X] Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

Python: [e.g. 3.11.5]
Basilisk: [e.g. 2.2.1]
Plaform: [MacOS 13.5.2]

Checklist:

[X] My code follows the style guidelines of this project (passes Black, ruff, and isort)
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Change the name NadirImagingActions to NadirImagingAction for consistency with other single-action actions, then you're good to rebase into develop!


$VideoID in addition to $URL

Thanks for developing Telik, I really appreciate the app! I have a feature-request.
It would be great if the "Custom URL"-Option would offer a variable for YouTubes $VideoID.
So one could easily use alternativ frontends like INVIDIOUS with "Custom URL" an
https://yewtu.be/watch?v=$VideoID
Right now i can use
https://yewtu.be/search?q=$URL as a workaround and have to click just once more, but a variable for the ID would make it seamless.

Thanks for suggestion, done in 1.10.


docs: Right-to-left breaks snackbars

[X] The issue is present in the latest release.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Expected Behavior 🤔
That period shouldn't be all over the place
Steps to Reproduce 🕹
Just head to the docs and go from LTR to RTL, and wait for the snackbars to appear.
Steps:

Head to the docs
Go from LTR to RTL
Wait for the snackbars to appear
See 🐛

Context 🔦
It just looks kinda bad
Your Environment 🌎
Browser = chrome latest

This is expected. Replace the content with RTL characters, it should be fine.


rkt: add --force option to gc?

Users can get into a situation where pods are in a half-formed state - for example, some metadata is removed but overlayfs mounts are still present - and gc is completely broken.
We should consider some kind of nuclear option to gc which will forcefully remove all traces - i.e. by doing a recursive umount and then rm -fr.

:+1:

I've put together a rkt-cleanup bash script a while ago that supposedly cleans all possible messes up, except for netfilter rules.
rkt gc --grace-period=0s
for p in `mount | grep -oP "/tmp/[^\s,\)]*"`; do umount -l $p; done
for p in `mount | grep -oP "/var/lib/rkt/pods/[^\s,\)]*"`; do umount -l $p; done
rkt gc --grace-period=0s
for i in `rkt image list | grep -oP '^sha512[^ \t]*'`; do rkt image rm $i; done
for ns in `ip netns l | grep -o -E '^[[:alnum:]]+'`; do ip netns del $ns; done
ip l del cni0
for veth in `ip l show | grep -oE 'veth[^@]+'`; do ip l del $veth; done
rm -Rf /var/lib/cni/networks/*
rm -Rf /var/lib/rkt/*

This is not really thought out but I'm sure we can extract some bullet points.

We could add something like that as a helper script in the interim, although it would be good to split apart images from pods.

I'm wondering why exactly we should have a --force for GC. It's clear that we need a brute-force way to GC the pods in cases where standard GC fails as described above. However, if it's obvious that the pod needs to be GC'd (it's in ExitedGarbage), I'd like to avoid intervention from the user and just do the right thing.
/cc @jonboulle

@blixtra you mean it would essentially always be in --force mode? I guess I don't have a strong reason why not - my initial thinking was that it would make sense to abort if a rkt gc fails for some reason, but maybe that's less expected than just avoiding any intervention as you suggest.

@jonboulle Implementing without the required interaction for now and will see how it feels.


Use get_filename_componet to get real path of serialbox

You get something less confusing, because it does not end with "../". Just a proposal.

I didn't write that code, maybe @pspoerri should review this


Adding SOVABIDS to the NeuroDesk Conda environment container

Hi Angela,
Can SOVABIDS be included in the container with the Python conda environment if it needs to be cloned from Github and then piped (https://sovabids.readthedocs.io/en/latest/README.html#installation), or do you only include things that can be conda-installed or piped directly from repositories? Is there a specific problem to clone things from Github first?
If we can add the SOVABIDS installation from Github, where should we do it? @  @yjmantilla Steff, any of you want to try it out?
NOTE: there is already an old version of SOVABIDS in the bidstools container, but since SOVABIDS also has a python interface (https://sovabids.readthedocs.io/en/latest/autoapi/index.html), some would like to use it from VSCode (or other tools available inside the Conda environment container), I guess

This is possible, but we first need to finish #66 before we can do this

I'm hella busy but maybe ring me when #66 is done.

#66 is now completed.
If anyone is keen to add Sovabids you can follow this example:
https://github.com/NeuroDesk/neurocontainers/tree/master/recipes/mne
Cheers
Steffen

@stebo85 I'll keep that in mind although my time has been really limited

Hi Steff (
@neuro-sevas)
I tag you on this issue, in case you want to give a SOVABIDS container a go. If you use the mne example, you can just keep VScode in, as people might like to interact with SOVABIDS through python code.
Best,
Oren

Right now the urgency is to have the newest version of BIDScoin, so I will work on SOVABIDS only later. Marked as "wontfix right now".

From Oren_
If one of you finds time to build a SOVABIDS container for Neurodesk, I just wanted to let you know that I already built a BIDScoin container with the latest version:
https://github.com/NeuroDesk/neurocontainers/tree/master/recipes/bidscoin
So you can use it as a template for the SOVABIDS container.

SOVABIDS is a special case because it has GUI that can be used independently, but it can also be used via Python. So I'm not sure what will be the best solution for it:
One option is to include it only in the Python environment, but add a menu entry for the GUI (but then people need to download the whole environment, in case they don't work with CVMFS)
Another option is to include SOVABIDS both in the Python environment and in a separate container.
Third option is to only have SOVABIDS in a separate container -- that might be easier for the developers because the python environment is complicated, and it might be too much overhead to make it build properly everytime we want to only upgrade SOVABIDS (which will be frequent, given that SOVABIDS is still a young software)
Any thoughts?

I think the third option (separate container) seems to be the most healthy one overall.

closing because it's completed


Growl Notification can not handle RTL Correctly, Inversed Images

Hi,
I work on an RTL app, but I just noticed that the growl notification have an issue, might be two,
see,

The issue on the left side, Local Growl
     <hc:ScrollViewer
                Grid.Column="1"
                Grid.Row="0"
                Background="Transparent"
                VerticalScrollBarVisibility="Hidden" HorizontalAlignment="Right" IsInertiaEnabled="True"
                IsPenetrating="True">
                <StackPanel
                    hc:Growl.Token="AllMToken"
                    hc:Growl.GrowlParent="True" VerticalAlignment="Top" Margin="0,10,10,10" />
            </hc:ScrollViewer>

the alignment works correctly, but the image of states was inversed: this means that this image inherited the FlowDirection from its parent
which should not happen, it should explicitly be FlowDirection="LeftToRight"
The issue on the right side : Global Growl
Growl.ErrorGlobal() // and so on.

this seems to use LTR direction, so it produces a culture-specific alignment issue, view RTL language in LTR context
so the question here is, how to change the global Growl  FlowDirection, if it is not possible, then it is an issue 😄

@AlBannaTechno  Thank you, I will send a PR to solve this problem soon

if #801  accepted, you can use this code:
Growl.AskGlobal(new GrowlInfo
            {
                Message = "سلام خوش آمدید",
                FlowDirection = FlowDirection.RightToLeft,
                ActionBeforeClose = b =>
                {
                    if (!b) return true;
                    return true;
                }
            });

closed in 2fbcc1a6


water dispenser is leaking

https://catapultpgh.slack.com/archives/space-ops/p1450735614000036
"you may know this already but the water dispenser is leaking and has washed at least two bottles of water out into the carpet today"

on hold with water company

also: https://github.com/catapultpgh/main/blob/master/services.md#services

i think it's not anymore


Accommodate models without system_prompts (like o1 class models) by not passing a system prompt if no Agent defined

The o1 model family is sufficiently different that we need the InferenceService to create a different model:

No temperature
No system prompt
No logprobs
Different name for max_tokens (max_completion_tokens)


Respect 'Condition' settings on ItemGroup and Project/Package references in csproj files

I'm wanting to support project references for local development, but CI using package references.  By default, dotnet will fallback to project-references if they're present, so I'd like to conditionally exclude the project references thus forcing the CI builds to only be aware of the PackageReferences.
Currently, outdated will not "see" packages that are within conditions, and will not ignore references that should be excluded by conditions.

You can work around with  env vars,  eg
<ItemGroup>
  <ProjectReference Include="../../mylocalproj.csproj" Condition="'$(OUTDATED_RUNNING)'!='True' And '$(Configuration)'=='Debug'" />
  <PackageReference Include="MyProjPackage" Version="1.0.0" Condition="'$(OUTDATED_RUNNING)'=='True' Or '$(Configuration)'!='Debug'" />
</ItemGroup>

Then
OUTDATED_RUNNING=True dotnet outdated --upgrade


[Help Wanted] Shorten "Edit on GitHub" to "Edit"

The "Edit on GitHub" option seems to be causing layout issues on pages with long titles. Shortening the label probably solves a lot of corner cases.

I was working on this but running make html in the repo failed with the error:
writing output... [ 68%] install/heroku
Exception occurred:
  File "/Users/tejas/opensource/mattermost-docs/venv/lib/python2.7/site-packages/docutils/writers/html4css1/__init__.py", line 381, in depart_enumerated_list
    self.compact_simple, self.compact_p = self.context.pop()
ValueError: need more than 0 values to unpack

Same as the travis failures for #723, #724 and #725 example: https://travis-ci.org/mattermost/docs/builds/182612761

Thanks for the note @tejasbubane, I'll check what might be going on here.
Looks like something is breaking the build on the docs repo.

Hey @tejasbubane, and sorry for the issues here.
It looks like Travis updated to a bad version of a library (which we use to build the repo) - reverting a commit that potentially caused the issue didn't help resolve it so we'll look into moving this over to Jenkins.
Thank you so much for your interest in contributing, I'll let you know as soon as the build errors are resolved.

Hey @tejasbubane, the build errors should now be fixed.
Would you still be interested helping with a fix and participate in our Holiday Hackfest?  Four PRs wins you an exclusive Mattermost shirt!

Thanks @jasonblais PR sent.

Thank you @tejasbubane, much appreciated! We'll have a PM start the review process soon

Closed as resolved, thanks @tejasbubane!
https://github.com/mattermost/docs/pull/746


cmake.prefix entry-point can fail when it is pointing to a MultiplexedPath

I am experimenting with building a compiled non-python project within scikit-build-core, and I've encountered an issue if you point the entry-point to a non-pythonic object, i.e.:
[build-system]
requires = ["scikit-build-core"]
build-backend = "scikit_build_core.build"

[project]
name = "CMake-Template"

[project.entry-points."cmake.prefix"]
CMakeTemplatePrefix = "cmake_template"

[tool.scikit-build]
wheel.install-dir = "cmake_template"

The verbose log shows:
    set(CMAKE_PREFIX_PATH [===[MultiplexedPath('/home/lecris/CLionProjects/Template/venv/lib64/python3.12/site-packages/cmake_template');/home/lecris/CLionProjects/Template/venv/lib/python3.12/site-packages]===] CACHE PATH "" FORCE)

Probably should address in #880. But I need to debug more why did it even create MultiplexedPath in this case when I've installed it without editable or such.

Edit: So this is fun. It's a MultiplexedPath with a single item :shrug:

We should be able to handle multiplexed paths, that could be a fix before 0.11.

That could be a bit tricky to detangle from 836c51ecfa5f898e3bb25407eb45954332a24ba0.
Could be easier if we keep the _handle_search_paths and _sanitize_path parts, but remove the settings_val part from it. Wdyt?


Add automatic pushing to CocoaPods for tagged builds

Did this in UnrarKit - use the same approach (and, most likely, scripts).

Looks good in branch - will test with next release


[SPARK-18772][SQL] Avoid unnecessary conversion try and add missing cases for special floats in JSON

What changes were proposed in this pull request?
This PR is based on  https://github.com/apache/spark/pull/16199 and extracts the valid change from https://github.com/apache/spark/pull/9759 to resolve SPARK-18772
This avoids additional conversion try with toFloat and toDouble and adds missing cases that is discussed in https://github.com/apache/spark/pull/9759.
For avoiding additional conversions, please refer the codes below:
Before
scala> import org.apache.spark.sql.types._
import org.apache.spark.sql.types._

scala> spark.read.schema(StructType(Seq(StructField("a", DoubleType)))).option("mode", "FAILFAST").json(Seq("""{"a": "nan"}""").toDS).show()
17/05/12 11:30:41 ERROR Executor: Exception in task 0.0 in stage 2.0 (TID 2)
java.lang.NumberFormatException: For input string: "nan"
...

After
scala> import org.apache.spark.sql.types._
import org.apache.spark.sql.types._

scala> spark.read.schema(StructType(Seq(StructField("a", DoubleType)))).option("mode", "FAILFAST").json(Seq("""{"a": "nan"}""").toDS).show()
17/05/12 11:44:30 ERROR Executor: Exception in task 0.0 in stage 0.0 (TID 0)
java.lang.RuntimeException: Cannot parse nan as DoubleType.
...

How was this patch tested?
Unit tests added in JsonSuite.
Closes #16199

Test build #76841 has started for PR 17956 at commit 660a284.

cc @NathanHowell, @cloud-fan and @viirya.
(I just want to note this will not change any input/output but just the exception type and avoid additional conversion try.)

Test build #76846 has started for PR 17956 at commit aa7c658.

LGTM

Test build #76841 has finished for PR 17956 at commit 660a284.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76841/
Test PASSed.

LGTM except for a minor comment.

Test build #76846 has finished for PR 17956 at commit aa7c658.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76846/
Test PASSed.

Test build #76851 has started for PR 17956 at commit e858789.

This PR description is misleading. This PR is actually a bug fix, I think

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76851/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test build #76854 has started for PR 17956 at commit e858789.

@gatorsmail, I added some more cases I could identify based on http://docs.oracle.com/javase/7/docs/api/java/lang/Double.html#valueOf(java.lang.String) (this looks calling java.lang.Double.parseDouble which toDouble calls).
And also, for sure, I made this falls back to toDouble or toFloat and throw the same exceptions.

Test build #76857 has started for PR 17956 at commit d581467.

Could we update the JIRA, PR title, and PR description?
Also check the JSON flag allowNonNumericNumbers when doing the conversion?

Test build #76858 has started for PR 17956 at commit fa63ff4.

We should upgrade Jackson accordingly to support that option correctly. This looks reverted due to dependency problem - https://github.com/apache/spark/pull/9759#issuecomment-222759764. It sounds a bigger problem to me. (Also, strictly, it looks rather related with parsing itself). We already support the special floating cases and it might be fine just to improve this case.
I updated PR title and description already. I will fix JIRA as well (I was hesitated because that was not open by me).

If we do not upgrade Jackson, is that possible we can do it by checking the flag allowNonNumericNumbers before doing the conversion?

uh... That is different... This is String. That is Float. nvm. They are different issues.

Yes, thanks.

Do we need to follow allowNonNumericNumbers when parsing  """{"a": "-Infinity"}"""? cc @cloud-fan @viirya

I didn't understand what ^ means. Could you elaborate please? allowNonNumericNumbers option here for now is incomplete up to my knowledge.

Do we need to follow allowNonNumericNumbers when parsing """{"a": "-Infinity"}"""? cc @cloud-fan @viirya

allowNonNumericNumbers supports it and Scala supports it too. It seems to me that we should follow them.

(Ah, it was about Jackson's JsonParser.Feature.ALLOW_NON_NUMERIC_NUMBERS ... I see.)

Test build #76854 has finished for PR 17956 at commit e858789.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76854/
Test PASSed.

Test build #76857 has finished for PR 17956 at commit d581467.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76857/
Test PASSed.

Test build #76858 has finished for PR 17956 at commit fa63ff4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76858/
Test PASSed.

Before this PR, the option allowNonNumericNumbers affects the results of the following four cases:
{"a": NaN}
{"a": Infinity}
{"a": +Infinity}
{"a": -Infinity}

We should also enable this flag for the following cases too.
{"a": "+INF"}
{"a": "INF"}
{"a": "-INF"}
{"a": "NaN"}
{"a": "+NaN"}
{"a": "-NaN"}
{"a": "Infinity"}
{"a": "+Infinity"}
{"a": "-Infinity"}

In addition, we almost introduced a very serious regression defect, because we do not have the test case to cover the following scenarios:
{"a": "4.0"}

Thus, we also should include the above test case.

allowNonNumericNumbers option is undocumented and incomplete for now - https://github.com/apache/spark/pull/9724#r44883828

allowNonNumericNumbers is undocumented for now, since I can't figure out how it works.

This PR also introduces the following behavior changes.
    def floatRecords: Dataset[String] =
      spark.createDataset(spark.sparkContext.parallelize(
        """{"f": "18.00"}""" ::
          """{"f": "18.30"}""" ::
          """{"f": "20.00"}""" :: Nil))(Encoders.STRING)

    val jsonDF = spark.read.schema("f float").json(floatRecords)

Before this PR, the output is like
+----+
|   f|
+----+
|null|
|null|
|null|
+----+

After this PR, the output is like
+----+
|   f|
+----+
|18.00|
|18.30|
|20.00|
+----+

Yea, I am aware of it because we support special floating cases in string and I think we'd expect other doubles could be in string?

Hey @gatorsmile, how about picking up the commits here and opening a PR?

We really need to be careful when making the code changes. If we support such a feature, we need to support all the data types. This is unexpected to users.

WDYT? I think it'd be faster to get this merged.

Let me share my understanding.
First, we do not have a deadline for any non-urgent fixes. This PR is an example. How many JSON writers write a float "INF" as a string?
Being a committer needs to make a judgement to see how critical a PR is. My personal judgement is that we do not need to rush to merge it. I even want to wait for understanding how the other platforms handle such a string-represented "INF" in a float-type column. I believe we are not the first platform to face such an issue. That is why @cloud-fan and I asked the question above.
Second, we have to be careful to avoid introducing bugs when fixing the old issue. Spark is an infrastructure open-source project. We have to be very careful when doing the code reviews and code changes. If we accidentally introduced some supports, it is painful to remove the support and thus we have to keep it maybe forever. @viirya just found it very recently. Thus, please be careful when you do the code review and code changes.
If the users really need such a fix, they also can fix it and make a build by themselves. I believe that is why people like open source projects.
At the end, I want to share you a slides about bug costs. You might already saw similar figure before.

It is not good to hold off PRs. If a PR looks good and coherent, I think we could merge.

"How many JSON writers write a float "INF" as a string?", if it is your worry, I will take out the all newly added cases here. This is why I am thinking we should add this case via options.

My question was to ask taking over this. Please answer to this question.

Other information looks not related with the topic in this PR.

Based on my previous work experience, I am very conservative to introduce any behavior change unless we are sure this is the right thing to do. I do not think this is a high priority PR. I can put it in my to-do list. When I am free, I can work on it.
To prove the significance of this change, we need to check whether the other projects/products have the same/similar behavior? We do not want to introduce anything new or different. This is my concern.
Below is the list we need to check.
{"a": "+INF"}
{"a": "INF"}
{"a": "-INF"}
{"a": "NaN"}
{"a": "+NaN"}
{"a": "-NaN"}
{"a": "Infinity"}
{"a": "+Infinity"}
{"a": "-Infinity"}

Note, the above is different from the following JSON strings.
{"a": NaN}
{"a": Infinity}
{"a": +Infinity}
{"a": -Infinity}

In my previous comment, I just want to share something for the people who want to be a committer in Spark. It is not related to this PR.

BTW, if we want to support the JSON strings like {"a": "-Infinity"} as the FLOAT type, I think we also should support the float data in a string. Below is an example.
    def floatRecords: Dataset[String] =
      spark.createDataset(spark.sparkContext.parallelize(
        """{"f": "18.00"}""" ::
          """{"f": "18.30"}""" ::
          """{"f": "20.00"}""" :: Nil))(Encoders.STRING)
    val jsonDF = spark.read.schema("f float").json(floatRecords)

If we want to support parsing float data in a string, we should also support the other data types. Thus, this is another to-do issue, we should do an investigation.

Yea, Let's focus on the topic. For the cases below:
{"a": NaN}
{"a": Infinity}
{"a": +Infinity}
{"a": -Infinity}

They are related with allowNonNumericNumbers and related tests are already being ignored.
Okay. So the point is behaviour change, right? Let me give a shot to remove the behaviour changes here.

Given the existing logic below:
if (lowerCaseValue.equals("nan") ||
  lowerCaseValue.equals("infinity") ||
  lowerCaseValue.equals("-infinity") ||
  lowerCaseValue.equals("inf") ||
  lowerCaseValue.equals("-inf")) {
    value.toFloat

It looks we have try all the combinations (lowercase and uppcass) of "nan", "infinity", "-infinity", "inf", "-inf" sofar.
import itertools
items = ["nan", "infinity", "-infinity", "inf", "-inf"]
comb = []
for item in items:
   comb.extend(map(''.join, itertools.product(*zip(item.upper(), item.lower()))))

print("Set(%s)" % ", ".join(map(lambda c: '"%s"' % c, comb)))

This code is to generate the combinations. (I feel convenient for dealing with strings in Python).
val s = Set("NAN", "NAn", ... "-inf")
s.foreach { w =>
  try {
    w.toDouble // or w.toFloat
    println(w)
  } catch {
    case _ => // pass
  }
}

It looks we have supported the cases below so far:
NaN
-Infinity
Infinity

Let me update this.

Test build #76894 has started for PR 17956 at commit 90330bc.

We are handling the Json data sources here. Are the following inputs widely used?
{"a": "+INF"}
{"a": "INF"}
{"a": "-INF"}
{"a": "NaN"}
{"a": "+NaN"}
{"a": "-NaN"}
{"a": "Infinity"}
{"a": "+Infinity"}
{"a": "-Infinity"}

Note, we do not support the following cases
    def floatRecords: Dataset[String] =
      spark.createDataset(spark.sparkContext.parallelize(
        """{"f": "18.00"}""" ::
          """{"f": "18.30"}""" ::
          """{"f": "20.00"}""" :: Nil))(Encoders.STRING)
    val jsonDF = spark.read.schema("f float").json(floatRecords)

Basically, we do not assume users are use string in double columns for JSON data sources.

Unfortunately, we already support
"NaN"
"-Infinity"
"Infinity"

Now, this PR targets primarily to avoid unnecessary conversion try primarily.

@gatorsmile, @cloud-fan and @viirya, could you take another look please? I tried to get rid of all the behaviour changes existing in both previous PRs but only leave the change to avoid the conversion.
I tried to generate combinations of the existing supports - https://github.com/apache/spark/pull/17956#issuecomment-301230679 and extracted three cases - "NaN", "-Infinity" and "Infinity" which I believe we have supported so far.

Test build #76894 has finished for PR 17956 at commit 90330bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76894/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master/2.2!
I think this change is pretty safe, we can discuss 2 things later:

if we want to support more special strings like Inf
if we want to make it case-insensitive

Thank you everybody sincerely.


Why is Gnet splitting requests when a request is split over multiple packets

not always but only at random times, react is triggered two times with the first frame containing the first 1024 bytes of the request and the second the rest of the request, which obviously leads to errors.  I never had this problem when using http.Serve. Wireshark tells me that the request is split into two packets, but I don't see why that would be a problem, seems like pretty normal behaviour.  Is this a bug, wrong configuration or am I meant to handle this myself? Where/how would be the best way to do it?

The React() will be triggered every time one complete pakcet is decoded by your codec of gnet, so you might want to take a look at your codec you passed into gnet.


Run Ollama on multiple GPU using ollama run

Hi,
I have 2 gpus each having 40 gb of memory and i want to run llama3.1 70b  using these GPUs, are there any features to run ollama on distributed way

ollama will use multiple GPUs if available.  If you tried it and it didn't work, adding server logs will aid in debugging.

@atharvnagrikar let us know if you have any problems loading the model and if so I'll reopen.


release trigger

:tada: This PR is included in version 1.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[discussion] Use typescript?

I find it quite useful to use TS with the AWS SDK, I was wondering if we should look at doing it here? It works with serverless webpack I believe.

@QuantumInformation I personally haven't had a chance to use TS yet. But if you find a way to set it up, I'd like to try it.

heres how you can do it with raw ts
https://github.com/serverless/examples/pull/93

@QuantumInformation Nice work! Just looking through your example; do you know if there is an example with Serverless Webpack and TS anywhere?

I don't know, but serverless webpack does support Ts
Kind regards
Nikos
quantumjs.com

I'll take a look when I get a chance. But if anybody comes across this thread and has an example, please post a link to it here.


bump lightning-terminal for wasm-client & mobile

This PR bumps the lightning-terminal version for the wasm-client and mobile to v0.10.5-alpha.
Happy to address any feedback :)!

LGTM!

Thanks for the reviews @jbrill & @guggero 🎉!!