chore(python): add Python 3.12 in test matrix

Proposed change

This PR adds Python 3.12 in CI.
Note: I had to allow pre releases as Python 3.12 is still in beta and will land soon in release candidate.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[ ] I've followed the contributing guidelines
[ ] This PR is filed against beta branch of the repository
[ ] This PR doesn't contain any merge conflicts and has clean commit history
[ ] The code style looks good: make pre-commit
[ ] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[ ] The related documentation has been added/updated (check off the box for free if no updates is required)

Hi @stegayet
thanks for your efforts for keeping the things updated 👍 (checked your recent PRs)!
I submitted similar PR for beta branch (our dev branch) a couple weeks ago. I guess it'll need to be updated to the stable release version once it's out.
So I'm not really sure whether this PR brings something new to the table and going to close it. Please feel free to submit another after 3.12 is released as we definitely want to cover that.
Let me know if I'm missing something.


qemu: uncaught target signal 11 (Segmentation fault) - core dumped on ppc64el

https://travis-ci.org/laarid/package_android-bionic/jobs/204324498
dpkg-deb: building package 'android-bionic-build-deps' in '../android-bionic-build-deps_0.1.5_all.deb'.
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
dpkg-deb: error: subprocess <compress> from tar -cf was killed by signal (Segmentation fault), core dumped
dh_builddeb: dpkg-deb --build debian/android-bionic-build-deps .. returned exit code 2

This seems to happen since qemu version 1:2.8+dfsg-2ubuntu1 and is reproducible locally. No such issue in 1:2.6.1+dfsg-0ubuntu9.

Debian 1:2.6.1+dfsg-0ubuntu9  👍
Debian 1:2.7+dfsg-3+b1 👍
Debian 1:2.8+dfsg-2 👎

Tested with the same laarid/devel:ppc64el image, so it's definitely qemu's regression.


Render multi item entries (DO NOT MERGE)

This changes the way records and entries are rendered in various formats taking account of Entries now referring to multiple Items. These are breaking changes and this PR is just for review. It should not be merged.
Also the build will fail until related changes to the conformance tests have been done.

Where can I find documentation of the breaking changes to the API?  It looks like item-hash field is to be changed to item-hashes.
Is the TSV output for a record going to change? e.g. Currently for https://local-authority-eng.register.gov.uk/record/KIN.tsv the record TSV looks like:
entry-number	entry-timestamp	item-hash	local-authority-eng	local-authority-type	name	official-name	start-date	end-date
357	2017-01-26T12:34:10Z	sha-256:3f4da33a33c24de11cca3539f14ee663359608be0ba218d4fc05792c1d19c00f	KIN	NMD	King's Lynn and West Norfolk	Borough Council of King's Lynn and West Norfolk

Some of the resources don't match the new API design All the record resources need to have item-hash removed and key added as per the new API design https://github.com/openregister/specification/blob/pu/API-changes.txt. The following changes are still required:

add key to /record/key and /records
remove item-hash from /record/key and /records
/entry/1 needs to be an array to be consistent with /entries
/record/key needs to be turned into a map object to be consistent with /records

{
  "AE": {
    "index-entry-number": "190",
    "entry-number": "190",
    "entry-timestamp": "2016-04-05T13:23:05Z",
    "key": "AE",
    "item":
    [
      {
        "country": "AE",
        "official-name": "The United Arab Emirates",
        "name": "United Arab Emirates",
        "citizen-names": "Citizen of the United Arab Emirates"
      },
      {
        "country": "AE",
        "official-name": "The United Arab Emirates",
        "name": "United Arab Emirates",
        "citizen-names": "Citizen of the United Arab Emirates"
      }
    ]
  }
}

The TTL representations are missing the index-entry-number property.


Bug fix about grouped convolution

This PR is to fix a but related to grouped convolution. Please apply this before testing https://github.com/chainer/chainer/pull/3494.

jenkins, test this please.

LGTM, will merge after CI pass!

The backport is to be made after #748 is merged to v2 branch.


[AutoPR servicefabric/data-plane] Swagger specification for Service Fabric runtime version 7.0

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7828

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/8916


command line prime function -in filename

feature suggestion for the command line 'prime' function in addition to #19208
Unless the ability is already there and I'm not seeing it - if there can be a way for 'prime' to obtain the prime number from a disk file, for numbers too long for the command line.

For Unix like shells: openssl prime $(cat -n file)

Hello, can I work on this as my first contribution ?
If I understood it correctly, we have to add -in parameter to "openssl prime" operation which accepts file, right ?

That's the suggestion.

Yes, with the intent that it's a way to support numbers larger than can fit in the Windows command line.
If it helps to have a sample to work with, you could use one of the Mersenne primes, such as 2^9689-1, which is the hex string of '1' followed by 2422 "F" digits.

@maroonbells thank you for clarifying that, I will start working on it

Please note that the BIGNUM implementation in OpenSSL is not supposed to be able to handle arbitrarily large numbers - especially some computations that handle private keys or key parameters expect the input to be "reasonably sized" in terms of values being used in usual algorithms such as RSA DSA DH or EC. Especially the consttime operation is not guaranteed to work or the operations might completely fail if the values are bigger than that.


Add diagnostic message.

Should contain:

Robot status.

Raw encoder values.
Raw motor PWM values.

Wi-Fi status.

SSID.
Signal strength.
Connected.

This is no fun to do so parking it.


controller: Fix event message recorded by migration

What this PR does
Before this PR:
VirtualMachineInstanceMigration events:
Events:
  Type     Reason                           Age                  From                       Message
  ----     ------                           ----                 ----                       -------
  Normal   SuccessfulCreate                 34m                  virtualmachine-controller  Created migration target pod virt-launcher-i-be12131d9a184d72830f-h6tpd
  Normal   SuccessfulDelete                 29m                  virtualmachine-controller  unschedulable pod timeout period exceeded%!(EXTRA string=virt-launcher-i-be12131d9a184d72830f-h6tpd)

After this PR:
Events:
  Type     Reason                           Age                  From                       Message
  ----     ------                           ----                 ----                       -------
  Normal   SuccessfulCreate                 5m52s                virtualmachine-controller  Created migration target pod virt-launcher-ecs-test0-dmc5s
  Warning  migrationTargetPodUnschedulable  52s (x5 over 5m52s)  virtualmachine-controller  Migration target pod for VMI [default/ecs-test0] is currently unschedulable.
  Normal   SuccessfulDelete                 52s                  virtualmachine-controller  unschedulable pod virt-launcher-ecs-test0-dmc5s timeout period exceeded

Why we need it and why it was done in this way
Fix event message error.
Release note
NONE

Now looks good, thanks!
/approve

/lgtm
Thanks again!


[UI] Migrate from material-ui to mui

Aka migrate the durablefunctionsmonitor.react project from @material-ui/core to @mui/material.
There might be a lot of breaking changes, if I understand it correctly.
The migration guide is here: https://mui.com/guides/migration-v4/

Done in v6.3


Can't login to desktop normally (without xrdp) anymore - Debian Bullseye

Hello, it seems that the version of xrdp that is included in the repositories for Debian Bullseye is not compatible with it. Therefore, I had to build and install the new version of xrdp from source using this link: https://c-nergy.be/downloads/xRDP/xrdp-installer-1.4.4.zip. This fixed the issue with the Remote Desktop Protocol (RDP), but now I am unable to log in to my laptop without using RDP. When I enter my password for my user account, it takes me to a black screen and remains there indefinitely. Sometimes, if I wait for a few hours, it will eventually show me my desktop. Can you please help me with this issue? Thank you.

We can't help with issues introduced by 3rd part scripts I'm afraid.
As far as I am aware, the author of the link you include has made no effort to engage with this project. I suggest you talk to them about any incompatibilities their script has introduced with your system.
We'll be more than happy to help with any compatibility issues you might have with Bullseye. That should be fine out-of-the-box.

Yes but I have completely read the script myself, it doesn't do anything out of ordinary, I think the xrdp is at fault here, it must have broken gdm3 or x11 somehow because startx doesn't run automatically on boot anymore and when I run it myself from a ssh, it takes like a minute for the desktop to show up, I've already removed and reinstalled dbus-x11 gdm3 gnome-session gnome-session-bin gnome-shell-extensions but to no success, so I asked here for help. Thanks.

@Saya47
When you executed the cenergy script did you use the "-s -c" command line options to compile from Source (-c) and Enable Sound (-s).
At a minimum use (-c) to make sure you build/compile xrdp from latest source.

Hello @bmullan
Yes I did, I first installed it with -c and was happy that it works but I thought maybe I should enable sound redirection too so I ran the script again with -c -s.
I've been trying for days to remotely connect to my laptop, I tried vnc servers such as tightvnc and then xrdp, to be honest I don't know what broke my system.

@Saya47
_Are you using freerdp as the client?
If so... did you install the freerdp-wayland or freerdp-x11??
Also, if using freerdp what command line are you using?   Something like the following:_
example - all one line
xfreerdp /cert-ignore +gfx /rfx /rfx-mode:video /video /bpp:32 /dynamic-resolution +clipboard /sound:sys:pulse,format:1,quality:high,rate:44100,latency:50 /v:
obviously port 3389 or whatever you are using must be open

@bmullan
I'm using a Windows laptop's RDP client to connect to my Debian running laptop. So, no I didn't install freerdp, but I did a check and it seems to be installed for some reason:
$ apt list --installed | grep freerdp
libfreerdp-client2-2/stable,now 2.3.0+dfsg1-2+deb11u1 amd64 [installed,automatic]
libfreerdp2-2/stable,now 2.3.0+dfsg1-2+deb11u1 amd64 [installed,automatic]


[SDE Version] Merging code to master branch for app-version change in helm charts SDE

name: App-version change in helm charts.
'[chore]: App-version change in helm charts.'
Description

app-version changed and marked as chart version for Sementic-versioning.
appversion 0.0.3 and helm chart version 0.0.3.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] Copyright and license header are present on all affected files

Additional information

To request a review, check out who's involved to see a list of contributors and committers
Use the mailing list if you are unsure, who to contact, or if want to engage in a general discussion
Check out our guide on how to contribute
Check out our Release Guidelines
Check out the Eclipse Foundation contribution guidelines

Closing for charts link issue.


⚠ Bofrost.be has degraded performance

In e755d04, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1342 ms

Resolved: Bofrost.be performance has improved in 1819f4b.


Grapher step fails ("Unknown column 'shortName' in 'field list'")

I'm trying to execute the grapher step of the Electricity Mix dataset in my local grapher, but it fails with the following error:
1. grapher://energy/2022-08-03/electricity_mix...
Verifying namespace is present
Upserting dataset
2022-08-04 17:52.58 [error    ] Error encountered during import: (1054, "Unknown column 'shortName' in 'field list'")
2022-08-04 17:52.58 [error    ] Rolling back changes...

I realised that the new column shortName did not exist in my local grapher datasets table, even though I have deleted and re-built the local docker volume owid-grapher_mysql_data_public twice. Anyway, I run yarn buildTsc && yarn runDbMigrations and now the new columns are there.

even though I have deleted and re-built the local docker volume

Eh, sorry, I thought that would work. Glad you figured it out!


Verbose logging specific to compilation

Adds a keyword argument verbose to the solve method. When
verbose=True, CVXPY will log information related to both problem
compilation and solving.
For beginners, the distinction between compilation and solving is sometimes not
clear; this can lead some users to conclude that the solver is taking
too long, when compilation was the bottleneck (or vice versa). This
logging is meant to help alleviate that confusion.
For beginners and advanced users alike, when compiling very large
problems, it can be helpful to have logging output describing the
various stages of compilation and noting when they finish.
Sample output:
-------------------------------------------------------------------------------
                                     CVXPY
                                    v1.1.10
-------------------------------------------------------------------------------
Feb 26 05:54:27 PM: Your problem with 20 variables, 2 constraints, and 0 parameters.
Feb 26 05:54:27 PM: (If you need to solve this problem multiple times, but with different data, consider using parameters.)
Feb 26 05:54:27 PM: It is compliant with the following grammars: DCP, DQCP
Feb 26 05:54:27 PM: CVXPY will first compile your problem; then, it will invoke a numerical solver to obtain a solution.
Feb 26 05:54:27 PM: Compiling problem (target solver=OSQP).
Feb 26 05:54:27 PM: Reduction chain: CvxAttr2Constr, Qp2SymbolicQp, QpMatrixStuffing, OSQP
Feb 26 05:54:27 PM: Applying reduction CvxAttr2Constr
Feb 26 05:54:27 PM: Applying reduction Qp2SymbolicQp
Feb 26 05:54:27 PM: Applying reduction QpMatrixStuffing
Feb 26 05:54:27 PM: Applying reduction OSQP
Feb 26 05:54:27 PM: Finished problem compilation.
Feb 26 05:54:27 PM: (Subsequent compilations of this problem, using the same arguments, should take less time.)
Feb 26 05:54:27 PM: Invoking solver OSQP to obtain a solution.
-----------------------------------------------------------------
           OSQP v0.6.0  -  Operator Splitting QP Solver
              (c) Bartolomeo Stellato,  Goran Banjac
        University of Oxford  -  Stanford University 2019
-----------------------------------------------------------------
problem:  variables n = 50, constraints m = 70
          nnz(P) + nnz(A) = 700
settings: linear system solver = qdldl,
          eps_abs = 1.0e-05, eps_rel = 1.0e-05,
          eps_prim_inf = 1.0e-04, eps_dual_inf = 1.0e-04,
          rho = 1.00e-01 (adaptive),
          sigma = 1.00e-06, alpha = 1.60, max_iter = 10000
          check_termination: on (interval 25),
          scaling: on, scaled_termination: off
          warm start: on, polish: on, time_limit: off

iter   objective    pri res    dua res    rho        time
   1   0.0000e+00   1.95e+00   6.37e+02   1.00e-01   1.63e-04s
 200   1.9831e+01   2.92e-05   5.58e-06   1.29e+00   8.10e-04s
plsh   1.9831e+01   3.35e-16   8.89e-15   --------   9.09e-04s

status:               solved
solution polish:      successful
number of iterations: 200
optimal objective:    19.8313
run time:             9.09e-04s
optimal rho estimate: 4.33e+00

Feb 26 05:54:27 PM: Summary:
Feb 26 05:54:27 PM: Problem status: optimal
Feb 26 05:54:27 PM: Optimal value: 1.983e+01
Feb 26 05:54:27 PM: Compilation took 5.548e-03 seconds
Feb 26 05:54:27 PM: Solver took 1.704e-03 seconds

This looks good to me!

Thanks for the review, Steven! I made some improvements/enhancements. Here's new sample output.
===============================================================================
                                     CVXPY
                                    v1.1.10
===============================================================================
(CVXPY) Feb 26 10:30:24 PM: Your problem has 20 variables, 2 constraints, and 0 parameters.
(CVXPY) Feb 26 10:30:24 PM: It is compliant with the following grammars: DCP, DQCP
(CVXPY) Feb 26 10:30:24 PM: (If you need to solve this problem multiple times, but with different data, consider using parameters.)
(CVXPY) Feb 26 10:30:24 PM: CVXPY will first compile your problem; then, it will invoke a numerical solver to obtain a solution.
-------------------------------------------------------------------------------
                                  Compilation
-------------------------------------------------------------------------------
(CVXPY) Feb 26 10:30:24 PM: Compiling problem (target solver=OSQP).
(CVXPY) Feb 26 10:30:24 PM: Reduction chain: CvxAttr2Constr -> Qp2SymbolicQp -> QpMatrixStuffing -> OSQP
(CVXPY) Feb 26 10:30:24 PM: Applying reduction CvxAttr2Constr
(CVXPY) Feb 26 10:30:24 PM: Applying reduction Qp2SymbolicQp
(CVXPY) Feb 26 10:30:24 PM: Applying reduction QpMatrixStuffing
(CVXPY) Feb 26 10:30:24 PM: Applying reduction OSQP
(CVXPY) Feb 26 10:30:24 PM: Finished problem compilation (took 5.444e-03 seconds).
(CVXPY) Feb 26 10:30:24 PM: (Subsequent compilations of this problem, using the same arguments, should take less time.)
-------------------------------------------------------------------------------
                                Numerical solver
-------------------------------------------------------------------------------
(CVXPY) Feb 26 10:30:24 PM: Invoking solver OSQP to obtain a solution.
-----------------------------------------------------------------
           OSQP v0.6.0  -  Operator Splitting QP Solver
              (c) Bartolomeo Stellato,  Goran Banjac
        University of Oxford  -  Stanford University 2019
-----------------------------------------------------------------
problem:  variables n = 50, constraints m = 70
          nnz(P) + nnz(A) = 700
settings: linear system solver = qdldl,
          eps_abs = 1.0e-05, eps_rel = 1.0e-05,
          eps_prim_inf = 1.0e-04, eps_dual_inf = 1.0e-04,
          rho = 1.00e-01 (adaptive),
          sigma = 1.00e-06, alpha = 1.60, max_iter = 10000
          check_termination: on (interval 25),
          scaling: on, scaled_termination: off
          warm start: on, polish: on, time_limit: off

iter   objective    pri res    dua res    rho        time
   1   0.0000e+00   1.95e+00   6.37e+02   1.00e-01   1.61e-04s
 200   1.9831e+01   2.92e-05   5.58e-06   1.29e+00   7.50e-04s
plsh   1.9831e+01   3.35e-16   8.89e-15   --------   8.37e-04s

status:               solved
solution polish:      successful
number of iterations: 200
optimal objective:    19.8313
run time:             8.37e-04s
optimal rho estimate: 4.33e+00

-------------------------------------------------------------------------------
                                    Summary
-------------------------------------------------------------------------------
(CVXPY) Feb 26 10:30:24 PM: Problem status: optimal
(CVXPY) Feb 26 10:30:24 PM: Optimal value: 1.983e+01
(CVXPY) Feb 26 10:30:24 PM: Compilation took 5.444e-03 seconds
(CVXPY) Feb 26 10:30:24 PM: Solver took 1.555e-03 seconds


Fix bug stopping CloudWatch Container Insights from working

Container insights was broken, sed query searching for cluster-name rather than cluster_name. This fixes it!

Minor AppMesh region fix added.

Also added the beta CloudWatch Agent with Prometheus Metrics Collection to the CloudWatch Container Insights section.


ValueError: not enough values to unpack (expected 3, got 2)

I'm trying to implement your code and I came across this error. I pass in a picture and want to see if the iris is correct or not.
` image = cv2.imread('data/kimjisoo/3.jpg')
gaze = GazeTracking()

gaze.refresh(image)

new_frame = gaze.annotated_frame()

cv2.imwrite('data/output/0.png', new_frame)

if gaze.is_right():
    print("Looking right")

elif gaze.is_left():
    print("Looking left")

elif gaze.is_center():
    print("Looking center")`

And the error on terminal: File "main.py", line 63, in
gaze.refresh(image)
File "/home/tienhv/Project/LivelyFace/gaze_tracking/gaze_tracking.py", line 64, in refresh
self._analyze()
File "/home/tienhv/Project/LivelyFace/gaze_tracking/gaze_tracking.py", line 50, in _analyze
self.eye_left = Eye(frame, landmarks, 0, self.calibration)
File "/home/tienhv/Project/LivelyFace/gaze_tracking/eye.py", line 22, in init
self._analyze(original_frame, landmarks, side, calibration)
File "/home/tienhv/Project/LivelyFace/gaze_tracking/eye.py", line 117, in _analyze
self.pupil = Pupil(self.frame, threshold)
File "/home/tienhv/Project/LivelyFace/gaze_tracking/pupil.py", line 17, in init
self.detect_iris(eye_frame)
File "/home/tienhv/Project/LivelyFace/gaze_tracking/pupil.py", line 46, in detect_iris
_, contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)
ValueError: not enough values to unpack (expected 3, got 2)`

According to here : https://github.com/facebookresearch/maskrcnn-benchmark/issues/339
The line
_, contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)
should be changed to
contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)

According to here : facebookresearch/maskrcnn-benchmark#339
The line
_, contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)
should be changed to
contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)

Thanks you. I get it worked. But it seem to miscaculate the direction of the eye a lot. Do you know how to fix it?

No idea at the moment, I've just known this repo for 2 days. But I'll try to investigate when I have the time !

Hello, it looks to me like the issue is that you are using opencv_python version 4.0 or greater, while the current requirements.txt specifies opencv_python == <IP_ADDRESS>.
It seems that the findContours call signature changed in version 4 from:
image, contours, hierarchy	=	cv.findContours(	image, mode, method[, contours[, hierarchy[, offset]]]	)
to
contours, hierarchy	=	cv.findContours(	image, mode, method[, contours[, hierarchy[, offset]]]	)
Refer version 3.4.5 docs vs version 4.0.0 docs.
So I'd suggest possible resolutions would be:

roll back your installed opencv version to that specified in requirements.txt, or
update the pull request #24 to specify in requirements.txt that the opencv_python version must be at least 4, or
update the pull request to support both versions

Option 3 would look something like:
if cv2.__version < 4:
    _, contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)
else:
    contours, _ = cv2.findContours(self.iris_frame, cv2.RETR_TREE, cv2.CHAIN_APPROX_NONE)

(Note I'm not sure what's the best way to perform the version check).
I'd go for option (2), but that's probably down to whether @antoinelame is happy to drop support for opencv v3.

Hi guys,
As @tim-fan said, you face this error because you use OpenCV 4 instead of OpenCV 3. It would be nice to support both versions though!
With 3.x, it returns 3 values:
image, contours, hierarchy  = findContours(image, mode, method[, contours[, hierarchy[, offset]]])

With 4.x, it returns 2 values:
contours, hierarchy  = findContours(image, mode, method[, contours[, hierarchy[, offset]]])

So we can do a if and check the version, but I think the most elegant way to do it is to write:
contours, hierarchy = cv2.findContours(...)[-2:]

@barrelsrider @tim-fan Feel free to update #24 or to create a new PR, and I'll approve it


Add ItemFinder util

Resolves #1070

This is a handy class for sure, though does it fully solve the issue that you originally requested? Is there any caching going on that reduces the number of calls being made to client.getItemContainer(), which this helper class does internally whenever it is used?

Once we get inventory change events it should be fine, right now every plugin will still be calling this class every tick so it's not ideal performance-wise; but it at least reduces code duplication, so we will only have one place needing optimization.

Will be reworking this to be part of the query system instead of a util


MaddreMod duplicate construction id

Name the mod
MaddreMod
Describe the bug
DEBUG    : Error: data/mods//MaddreMod/construction/madd_construction.json: line 3:10: Duplicate construction id
[
{
"id":
^
"Assemble_metal_compactor",
"type": "construction",
"description": "Assemble metal compactor",
FUNCTION : bool main_menu::load_character_tab(bool)
FILE     : src/main_menu.cpp
LINE     : 1103
Solution
Change the id maybe? im bot really sure why there are two maybe its a me thing
Additional context
Add any other context about the problem here.

ill have a look into this but prob the other mods you mentioned

could you provide your mod list for this error, i think you have Maddremod and MaddremorBundle active. Maddremod included in MaddremorBundle. i will remove the bundle from the mod pack

you are correct good sir that was my bad


[Question] What is ESS in PPO?

Here ppo.py from PPO source code is the definition.

Does ESS stand for Effective Sample Size or something else?
What is the purpose logging this info?
A reference for 'ESS' would be helpful. Thank you.

The ESS is indeed the Effective Sample Size, specifically for weighted i.i.d. observations. If replacing log_weight with log_prob - prev_log_prob, the equation of ess with `logsumexp' can reduce to the standard form as in this blog What do we mean by effective sample size?

As you figured out, the ESS is the expected sample size.
Since PPO is a derivation of importance sampling, we thought that having the ESS registered could give you an indication of how much the policy that you're training is differing from the one used for data collection during a training epoch.
If the two distributions match, the ESS is equal to the number of samples, but as they drift away, the ESS decreases. With PPO your ESS should never be too slow because it is "proximal", if it falls below a reasonable threshold (say, like your saturation, ie. normal is above 95%) you (or we, developer) should check that everything is fine.


Annotated packages exception, builder, reflect and partially time.

Annotated and suppressed warnings to remove errors completely from the following packages:

Exception

Builder

Reflect

Time(only the following classes)-
FastTimeZone.java
DateUtils.java
FastDatePrinter.java

You should discuss why we want this vast a change to the component on the development mailing list. As of now, this is way too many changes for one PR. I am not sure if we will even agree on decorating sources all over the place with annotations. You should start a discussion in the ML...


Replaced 'domain' with 'site_name' in email templates.

I've replaced domain with site_name in the email templates.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Thank you @subodhu for your work, missed this PR as it wasn't linked to the issue.
Compared with your code, also added missing translations in #6053 so it will all be ready after merge.


Crash on Launch

Already reported ? *

[ ] I have searched the existing open and closed issues.

Regression?
Yes
System Info and Version
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] [10de:1c03] (rev a1) (prog-if 00 [VGA controller])
NVRM version: NVIDIA UNIX x86_64 Kernel Module  565.57.01  Thu Oct 10 12:29:05 UTC 2024
os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo
Description
I updated the system a few days ago, this probably happened then, but I'm only now facing it because I only rebooted the system today
The issue persists in dkms drivers. The issue also persists on -git versions on AUR. I've also followed all instructions on the wiki regarding nvidia.
How to reproduce
Boot system, login, type 'Hyprland' in tty.
Crash reports, logs, images, videos

Hyprland Crash Report
All these computers...
Hyprland received signal 6(ABRT)
Version: 12f9a0d0b93f691d4d9923716557154d74777b0a
Tag: v0.45.2
Date: Tue Nov 19 21:47:18 2024
Flags:
System info:
System name: Linux
Node name: pigeonbox
Release: 6.12.1-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Fri, 22 Nov 2024 16:04:27 +0000
GPU:
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] [10de:1c03] (rev a1) (prog-if 00 [VGA controller])
os-release:
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo
Backtrace:
# | Hyprland(_Z12getBacktracev+0x61) [0x63f6b401aef1]
getBacktrace()
??:?
#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0xb88) [0x63f6b3f99f08]
CrashReporter::createAndSaveCrash(int)
??:?
#2 | Hyprland(_Z25handleUnrecoverableSignali+0x71) [0x63f6b3f12351]
handleUnrecoverableSignal(int)
??:?
#3 | /usr/lib/libc.so.6(+0x3d1d0) [0x793a12d5d1d0]
??
??:0
#4 | /usr/lib/libc.so.6(+0x963f4) [0x793a12db63f4]
??
??:0
#5 | /usr/lib/libc.so.6(gsignal+0x20) [0x793a12d5d120]
??
??:0
#6 | /usr/lib/libc.so.6(abort+0xdf) [0x793a12d444c3]
??
??:0
#7 | /usr/lib/libstdc++.so.6(+0x97b2c) [0x793a13097b2c]
??
??:0
#8 | /usr/lib/libstdc++.so.6(+0xadf3a) [0x793a130adf3a]
??
??:0
#9 | /usr/lib/libstdc++.so.6(_ZSt10unexpectedv+0) [0x793a1309752a]
??
??:0
#1 | /usr/lib/libstdc++.so.6(+0xae1f6) [0x793a130ae1f6]
??
??:0
#11 | /usr/lib/libstdc++.so.6(+0xa0b2d) [0x793a130a0b2d]
??
??:0
#12 | /usr/lib/libhyprcursor.so.0(_ZN10Hyprcursor18CHyprcursorManager4initEPKc+0xa5a) [0x793a133bb5ca]
??
??:0
#13 | Hyprland(_ZN14CCursorManagerC2Ev+0xc2) [0x63f6b4052932]
CCursorManager::CCursorManager()
??:?
#14 | Hyprland(_ZN11CCompositor12initManagersE18eManagersInitStage+0x1342) [0x63f6b3f180f2]
CCompositor::initManagers(eManagersInitStage)
??:?
#15 | Hyprland(_ZN11CCompositor10initServerENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEi+0xd93) [0x63f6b3f19203]
CCompositor::initServer(std::__cxx11::basic_string<char, std::char_traits, std::allocator >, int)
??:?
#16 | Hyprland(main+0xb15) [0x63f6b3ecced5]
main
??:?
#17 | /usr/lib/libc.so.6(+0x25e08) [0x793a12d45e08]
??
??:0
#18 | /usr/lib/libc.so.6(__libc_start_main+0x8c) [0x793a12d45ecc]
??
??:0
#19 | Hyprland(_start+0x25) [0x63f6b3f0e575]
_start
??:?
Log tail:
[LOG] EGL: GPU Supports Format HD01 (0x31304448)
[LOG] EGL: | with modifier INVALID (0xffffffffffffff)
[LOG] EGL: GPU Supports Format UHD0 (0x30444855)
[LOG] EGL: | with modifier INVALID (0xffffffffffffff)
[LOG] EGL: 54 formats found in total. Some modifiers may be omitted as they are external-only.
[LOG] Creating the ProtocolManager!

[LOG] Creating the ThreadManager!
[LOG] Creating CHyprCtl
[LOG] Hypr socket started at /run/user/1000/hypr/12f9a0d0b93f691d4d9923716557154d74777b0a_1732965008_1379812370/.socket.sock
[LOG] Creating the InputManager!
[LOG] Creating the HyprRenderer!
[LOG] DRM driver information: nvidia-drm v0.0.0 from 0 description NVIDIA DRM driver
[WARN] NVIDIA detected, please remember to follow nvidia instructions on the wiki
[LOG] Creating the XWaylandManager!
[LOG] Creating the SessionLockManager!
[LOG] Creating the HyprDebugOverlay!
[LOG] Creating the HyprNotificationOverlay!
[LOG] Creating the PluginSystem!
[LOG] Creating the DecorationPositioner!
[LOG] Creating the CursorManager!
[hc] CHyprcursorManager: attempting to find theme from env
[hc] themeNameFromEnv: env unset
[hc] CHyprcursorManager: attempting to find any theme

this is quite odd. Can you build hyprcursor from source in debug and get a debug stacktrace? https://wiki.hyprland.org/Crashes-and-Bugs/#obtaining-a-debug-stacktrace
You likely have some permissions messed up, tho I should make hyprcursor not crash, but I am not sure where it crashes from the trace above

this is quite odd. Can you build hyprcursor from source in debug and get a debug stacktrace? https://wiki.hyprland.org/Crashes-and-Bugs/#obtaining-a-debug-stacktrace
You likely have some permissions messed up, tho I should make hyprcursor not crash, but I am not sure where it crashes from the trace above

I compiled Hyprcursor from source and launched Hyprland with HYPRLAND_TRACE=1 and AQ_TRACE=1 variables
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
Maybe you should try dusting your PC in the meantime?

Hyprland received signal 6(ABRT)
Version: 12f9a0d0b93f691d4d9923716557154d74777b0a
Tag: v0.45.2
Date: Tue Nov 19 21:47:18 2024
Flags:

System info:
	System name: Linux
	Node name: pigeonbox
	Release: 6.12.1-arch1-1
	Version: #1 SMP PREEMPT_DYNAMIC Fri, 22 Nov 2024 16:04:27 +0000

GPU:
	01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] [10de:1c03] (rev a1) (prog-if 00 [VGA controller])

os-release:
	NAME="Arch Linux"
	PRETTY_NAME="Arch Linux"
	ID=arch
	BUILD_ID=rolling
	ANSI_COLOR="38;2;23;147;209"
	HOME_URL="https://archlinux.org/"
	DOCUMENTATION_URL="https://wiki.archlinux.org/"
	SUPPORT_URL="https://bbs.archlinux.org/"
	BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
	PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
	LOGO=archlinux-logo
Backtrace:
	# | Hyprland(_Z12getBacktracev+0x61) [0x63fde0047ef1]
		getBacktrace()
		??:?
	#1 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0xb88) [0x63fddffc6f08]
		CrashReporter::createAndSaveCrash(int)
		??:?
	#2 | Hyprland(_Z25handleUnrecoverableSignali+0x71) [0x63fddff3f351]
		handleUnrecoverableSignal(int)
		??:?
	#3 | /usr/lib/libc.so.6(+0x3d1d0) [0x7586a755d1d0]
		??
		??:0
	#4 | /usr/lib/libc.so.6(+0x963f4) [0x7586a75b63f4]
		??
		??:0
	#5 | /usr/lib/libc.so.6(gsignal+0x20) [0x7586a755d120]
		??
		??:0
	#6 | /usr/lib/libc.so.6(abort+0xdf) [0x7586a75444c3]
		??
		??:0
	#7 | /usr/lib/libstdc++.so.6(+0x97b2c) [0x7586a7897b2c]
		??
		??:0
	#8 | /usr/lib/libstdc++.so.6(+0xadf3a) [0x7586a78adf3a]
		??
		??:0
	#9 | /usr/lib/libstdc++.so.6(_ZSt10unexpectedv+0) [0x7586a789752a]
		??
		??:0
	#1 | /usr/lib/libstdc++.so.6(+0xae1f6) [0x7586a78ae1f6]
		??
		??:0
	#11 | /usr/lib/libstdc++.so.6(+0xa0b2d) [0x7586a78a0b2d]
		??
		??:0
	#12 | /usr/lib/libhyprcursor.so.0(_ZN10Hyprcursor18CHyprcursorManager4initEPKc+0x11e6) [0x7586a7b8f3c6]
		??
		??:0
	#13 | Hyprland(_ZN14CCursorManagerC2Ev+0xc2) [0x63fde007f932]
		CCursorManager::CCursorManager()
		??:?
	#14 | Hyprland(_ZN11CCompositor12initManagersE18eManagersInitStage+0x1342) [0x63fddff450f2]
		CCompositor::initManagers(eManagersInitStage)
		??:?
	#15 | Hyprland(_ZN11CCompositor10initServerENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEi+0xd93) [0x63fddff46203]
		CCompositor::initServer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int)
		??:?
	#16 | Hyprland(main+0xb15) [0x63fddfef9ed5]
		main
		??:?
	#17 | /usr/lib/libc.so.6(+0x25e08) [0x7586a7545e08]
		??
		??:0
	#18 | /usr/lib/libc.so.6(__libc_start_main+0x8c) [0x7586a7545ecc]
		??
		??:0
	#19 | Hyprland(_start+0x25) [0x63fddff3b575]
		_start
		??:?

Log tail:
[LOG] EGL: GPU Supports Format HD01 (0x31304448)
[LOG] EGL: | with modifier INVALID (0xffffffffffffff)
[LOG] EGL: GPU Supports Format UHD0 (0x30444855)
[LOG] EGL: | with modifier INVALID (0xffffffffffffff)
[LOG] EGL: 54 formats found in total. Some modifiers may be omitted as they are external-only.
[LOG] Creating the ProtocolManager!

[LOG] Creating the ThreadManager!
[LOG] Creating CHyprCtl
[LOG] Hypr socket started at /run/user/1000/hypr/12f9a0d0b93f691d4d9923716557154d74777b0a_1733023507_507092007/.socket.sock
[LOG] Creating the InputManager!
[LOG] Creating the HyprRenderer!
[LOG] DRM driver information: nvidia-drm v0.0.0 from 0 description NVIDIA DRM driver
[WARN] NVIDIA detected, please remember to follow nvidia instructions on the wiki
[LOG] Creating the XWaylandManager!
[LOG] Creating the SessionLockManager!
[LOG] Creating the HyprDebugOverlay!
[LOG] Creating the HyprNotificationOverlay!
[LOG] Creating the PluginSystem!
[LOG] Creating the DecorationPositioner!
[LOG] Creating the CursorManager!
[hc] CHyprcursorManager: attempting to find theme from env
[hc] themeNameFromEnv: env unset
[hc] CHyprcursorManager: attempting to find any theme

...Try LTS kernel?

...Try LTS kernel?

Issue persists.

I had this issue too. the only way i got Hyprland to start again was by setting fbdev=0, but this causes an issue where hyprctl monitors all only shows 1 monitor, even when more are connected, and it's shown as Unknown-1, meaning all my monitors are just duplicated

...Try LTS kernel?

Issue persists.

I had this issue too. the only way i got Hyprland to start again was by setting fbdev=0, but this causes an issue where hyprctl monitors all only shows 1 monitor, even when more are connected, and it's shown as Unknown-1, meaning all my monitors are just duplicated

Where do I set this?


Google tests run twice

Describe the bug
I am unit testing my C++ code with google test framework in Zephyr. When, inside of the tests folder prj.conf file, I enable
CONFIG_CPLUSPLUS=y
CONFIG_LIB_CPLUSPLUS=y
tests are executed twice.
Expected behavior
I want tests to run once.
Logs and console output
The following screen shot represents the structure of my project:

The following is the content of CMakeLists.txt file in test folder.
cmake_minimum_required(VERSION 3.13.1)

set(CMAKE_CXX_COMPILER /usr/bin/g++ CACHE PATH "" FORCE)

set(CMAKE_C_FLAGS -m32)
set(CMAKE_CXX_FLAGS -m32)

set(BOARD native_posix)
set(ZEPHYR_TOOLCHAIN_VARIANT zephyr)
set(TOOLCHAIN_ROOT ${ZEPHYR_BASE})
set(ZEPHYR_EXTRA_MODULES $ENV{ZEPHYR_BASE}/../greyp-zephyr-packages/modules/googletest
                         $ENV{ZEPHYR_BASE}/../greyp-zephyr-packages/modules/nanopb
                        )

include_directories("../impl/src/greyp_connectivity"
                    "../impl/src/greyp_messages"
                    "../impl/src/conversion_utilities"
                    "../impl/src/serial_driver"
                    "../impl/src/micro_messaging"
                    $ENV{ZEPHYR_BASE}/../greyp-zephyr-packages/build
                    )

find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
project(cyklaer_test)

FILE(GLOB app_sources ../impl/src/greyp_connectivity/*.cpp
                      ../impl/src/greyp_messages/*.cpp
                      ../impl/src/micro_messaging/*.cpp
                      )
FILE(GLOB test_sources src/*.cpp)
target_sources(app PRIVATE ${test_sources} ${app_sources})
target_link_libraries(app PUBLIC gtest_main)

At this point, prj.conf file in test folder is empty. Running the tests results in the following output:

However, when in test prj.conf file, I add
CONFIG_CPLUSPLUS=y
CONFIG_LIB_CPLUSPLUS=y

tests are executed twice:

I cannot figure out what is the root cause of this behavior. Is -gtest_repeat=2 set somehow? I don't know really how to debug this and find the reason. Any help is greatly appreciated.
Thanks.

There is another piece of information I came across, which I also do not understand why is it happening, and for which I think it is a pre-requisite for C++ configs to work.
In in test/prj.conf file, instead of having
CONFIG_CPLUSPLUS=y
CONFIG_LIB_CPLUSPLUS=y

I put
CONFIG_EXTERNAL_LIBC=n
CONFIG_NEWLIB_LIBC=y

and try to build that, I get the following output:

And I cannot figure out why is always external lib taken as C library. How do I instruct it to use new lib instead?

There is another piece of information I came across, which I also do not understand why is it happening, and for which I think it is a pre-requisite for C++ configs to work.
In in test/prj.conf file, instead of having
CONFIG_CPLUSPLUS=y
CONFIG_LIB_CPLUSPLUS=y

I put
CONFIG_EXTERNAL_LIBC=n
CONFIG_NEWLIB_LIBC=y

and try to build that, I get the following output:

And I cannot figure out why is always external lib taken as C library. How do I instruct it to use new lib instead?

Are you using native_posix as the target board?  That's probably the only environment where gtest is going to function at all.  For that board you can't select newlib.

Are you using native_posix as the target board?  That's probably the only environment where gtest is going to function at all.  For that board you can't select newlib.

One likely cause:  Zephyr initializes C++ static objects during the kernel startup code, rather than when the C runtime infrastructure iterates over them before starting.  If gtest uses static objects (probably does) then they may be being initialized twice, which might cause them to run twice.
I don't think gtest is likely to work well with C++ in Zephyr, where C++ is not a first-class citizen.

One likely cause:  Zephyr initializes C++ static objects during the kernel startup code, rather than when the C runtime infrastructure iterates over them before starting.  If gtest uses static objects (probably does) then they may be being initialized twice, which might cause them to run twice.
I don't think gtest is likely to work well with C++ in Zephyr, where C++ is not a first-class citizen.

Yes, I am using native_posix as target board. So basically, the only way to keep using gtest and C++ would be to somehow pass gtest_repeat = 1 from command line, before starting tests?

Yes, I am using native_posix as target board. So basically, the only way to keep using gtest and C++ would be to somehow pass gtest_repeat = 1 from command line, before starting tests?

If that works, yes.  I've never used gtest with Zephyr.

If that works, yes.  I've never used gtest with Zephyr.

I'm going to close this, because there's a workaround even though the use of gtest with Zephyr and C++ isn't really supported.  If there are objections it can be re-opened as a low-priority enhancement.

I'm going to close this, because there's a workaround even though the use of gtest with Zephyr and C++ isn't really supported.  If there are objections it can be re-opened as a low-priority enhancement.

@mejtejt I am trying to integrate gtest into my Zephyr project and was hoping you could share some insight on how you integrated the library - did you use gmock as well? And were you able to get past this double running issue? I'm finding it really hard to find any resources on how to do this integration. Any pointers would be much appreciated!


⚠ Bofrost.be has degraded performance

In c367606, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1482 ms

Resolved: Bofrost.be performance has improved in bfb02b7.


[Code Addition Request]: CHANAKYA_NITI  Full Stack Web Application

Have you completed your first issue?

[ ] I have completed my first issue

Guidelines

[X] I have read the guidelines
[ ] I have the link to my latest merged PR

Latest Merged PR Link
N/A
Project Description
CHANAKYA_NITI is a web application designed to provide an engaging platform for exploring and learning about the teachings of Chanakya, an ancient Indian philosopher, economist, and strategist. The frontend of this application will offer a seamless and interactive user experience. It will connect users with multimedia content, including audio files, books, and videos, and feature an AI-powered personalized recommendation system. The goal is to make Chanakya's timeless wisdom accessible to a modern audience, with features like user authentication, secure backend integration, language translation, and easy API access for users who want to create their own Chanakya-Niti websites.
This is a feature-rich web application that blends tradition with technology, offering an exceptional user experience.
Full Name
Sk Anarul
Participant Role
GSSOC-EXT

@skanarul8002 what tech stack you are planning to use?

@UTSAVS26 , i will use MERN Stack + different style library.

@skanarul8002 give me tech stack you are planning to use

Yeah sure @UTSAVS26, Technologies Used:
Frontend:

React.js: A JavaScript library for building user interfaces.
Redux: State management for handling complex state across the application.
Axios: Promise-based HTTP client for making API requests.
Material-UI: React components for faster and easier web development.
React Router: Declarative routing for React applications.
Vite: A build tool that provides a faster and leaner development experience for modern web projects.

Backend:

Node.js: Server-side JavaScript runtime.
Express.js: Web application framework for Node.js.
MongoDB: NoSQL database for storing application data.
JWT: JSON Web Tokens for secure user authentication.
TensorFlow: AI model integration for personalized recommendations and language translation.

Some important unique Features:

Audio Sound implement
Video player
Dark/ light toggle
Hindi language is used in some part of  website.
Entire Web page is responsive
And all related functionality, design of Website

Thank you for interaction with me

@skanarul8002 if you confirm that you will use python then only I can allow the project.

@UTSAVS26 , I will use the MERN stack (MongoDB, Express, React, Node.js) for web development, and additionally, I will implement machine learning-related technologies to develop a chatbot feature.
I'm sure this is the unique project. So please consider it then i will start my work.

@skanarul8002 based on the work done I will add the level.

ok @UTSAVS26


Add DbFunctionParameter support for DbFunctions

Adds the ability to map properties for DbFunction parameters.  See #13752

@ajcvickers - Should DbFunction's parameter have ValueConverter also?
One weird issue which can come in the absence of it, is if you are passing a column vs a constant. They both would have different types.

I need to review this PR this weekend to make sure I didn't miss anything.
I was not planning implementing the code which is going to use the new properties.  Since the query pipeline is being rewritten it doesn't make sense to update the old one.
@smitpatel - Does the new query work live in the smit/query branch?

@pmiddleton - Yes, that is the branch. I was thinking the same that we can commit & merge API to master and new query pipeline will make use of it when rebased. It would be good if we have tests to verify the behavior but skipped in old pipeline.

@smitpatel I think it needs to be possible to specify the actual type mapping to use (which could have a value converter on it) rather than only allowing the database type name. The database type name could be nice sugar for getting to the type mapping in common cases.

@pmiddleton - I discussed with @ajcvickers about ValueConverters area. Essentially query needs TypeMapping for parameters so that it can generate literal/parameter correctly in SQL. So IDbFunctionParameter should store RelationalTypeMapping (& also IDbFunction should store RelationalTypeMapping as return type).
Currently, there is no way to specify type mapping directly in fluent API. So for now we can have sugar method to specify database type and run a convention to assign type mapping whenever database type is set. TypeMappingConvention does the same for columns.

@smitpatel
Does it make more sense to look up the mappings at query translation time vs storing it?  I am not completely familiar with the RelationalTypeMapping but is is possible for the mappings to be changed at runtime after model creation?  If so then we shouldn't be precomputing and storing them.

@pmiddleton - I believe we can differ that for now since IProperty also does not change TypeMapping at runtime.

@smitpatel - Ok I will cache the values for parameters and return type, we can change to a realtime lookup later if needed.

@smitpatel - Take a look now and let me know if this is what you had in mind for RelationalTypeMapping.  If so I still need to add unit tests.

Requesting review from @ajcvickers for what to store in function parameter for type mapping.

@smitpatel @ajcvickers - Rebased on latest master.  Was there something else that needed changing for this PR before merging?
Sorry I'm in process of trying to buy a house and move this spring so I haven't had as much time as I would like to work on things.

@smitpatel Are we still waiting for anything here?

                if (RelationalDependencies.TypeMappingSource.FindMapping(methodInfo.ReturnType) == null)

This should be outside of Translation == null check. Even if they are providing translation, they cannot pass in TypeMapping for the translated expression.
Also see below for parameter

Refers to: src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs:84 in a99735f. [](commit_id = a99735f850e3a45bf6ab8a88f2c978e382b82bb3, deletion_comment = False)

                    if (RelationalDependencies.TypeMappingSource.FindMapping(parameter.ParameterType) == null)

This should go away. All parameters on method info should be inside dbFunction.Parameters check below. And that loop should handle parameters

Refers to: src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs:94 in a99735f. [](commit_id = a99735f850e3a45bf6ab8a88f2c978e382b82bb3, deletion_comment = False)

This actually does not add any API to configure the parameter & functions return type's database type. Let me discuss with team and get back to you in terms of API shape and data storage necessary.
Columns remember the annotation which specify string format of the type on database. If we don't store that info, I am not sure how would we get type mapping source to use that info to set the type mapping accurately.

When merging, check if #14990 is still needed.

@smitpatel  Did you confirm with the team that a return type parameter mapping on dbfunction is required?  If so I will get it added in.

@pmiddleton - I haven't got a chance yet. Give me about 2 more weeks to sort it out. Presently I am dealing with bigger chunks missing in new pipeline since it is blocking AspNetCore Identity to take new EF packages.

@smitpatel - No problem.  I am moving in 2 weeks so I don't have a ton of time right now myself.  We will get this done in June.

Design meeting decision:
There will be API taking string type name only. Which would map to TypeMapping.

@pmiddleton - Would you have chance to complete this in next 1 week? If not I can take over and make modifications to merge. Release deadlines to meet.

@smitpatel - sorry to do this to you, but I'm not going to be able to get to this in that time frame.  Too much stuff to deal with from my move.  We are still trying to stop living out of boxes :)

@pmiddleton - No worries. I will wrap up the pending work.

@pmiddleton - I have created #16182
Thanks for contribution.

@smitpatel  Thanks for finishing this up for me.  Sorry I wasn't able to get this done.


Add SQLite3 filebased database

Retire our current CSV database, and opt for using an ORM database, specifically SQLite3.
Acceptance criteria
Add a SQLite3 database, which should replace the CSV database
Definition of Done (DoD)
It should be possible to read Cheeps from an SQLite3 file based database, and also write to the SQLite3 database. If possible use DI when using the database. Make sure prepared statements are used when needed, such that we don't see any SQL injections.

This is done


Fix vs-table and vs-collapse

the .styl files got deleted when I merged in master.  I have pulled them out and reapplied them.  I also added the .vs folder added by visual studio to the

hello @Jacrys I update vuesax package by running npm update vuesax but it didn't solved select component issue + table styles are not in dist folder


Shutdown of server initialized classes in reverse order of initialization

Problem
Server initializes several classes, but not all of them are on server shutdown
Change overview
This PR adds shutdown calls for the modules that had some formal shutdown method. It also reversely orders them according to initialization sequence.

Some submodule changes made into this PR. Removing them


Couple of suggestions for the WebSocket page

Overall the content is very good (as usual). But I have a few small corrections:

The WebSocket diagram shows only server-push, but that is half of what you can do (as you correctly indicate in the description above). I think it would be good to add independent arrows that go from client to server, to indicate that both the client and the server can freely initiate an exchange at any time.

The following sentence is incorrect with respect to the client-side:

Both a JavaScript library on the web browser and a WebSockets implementation on the server are necessary to establish and maintain the connection between the client and server.

There is native support for the WebSocket protocol in most browsers. In many cases clients use a wrapper library, but that is technically not required, as browsers expose the WebSocket object.
I think that either here in this place, or later in the document you have to describe Socket.IO as pair of client and server libraries that wrap WebSocket. The nice thing about Socket.IO is that if you run it on a browser that doesn't have native WebSocket support, it can emulate the real-time communication using long polling or other methods and the implementation differences are hidden by the library. The important point here is that WebSocket != Socket.IO, which I think is not totally clear now.

WebSocket friendly servers for Python

A discussion on how to support WebSocket server-side is missing. You mention gevent a couple of times, but I think it would be helpful to discuss the implications of WebSocket on the server. Something on the lines of: since the connection is long lived, a multi-threaded or multi-process based server cannot scale appropriately, so you need an asynchronous server such as gevent for any practical implementation.

Definitely agree on all these points @miguelgrinberg. Working on a couple of updates to the page I think will clarify, especially the point about needing a JS library instead of the libraries just exposing the browser API in a more developer-friendly cross-browser way.


Will chokidar_usepolling=true start up the server faster in my docker container?

I read in the guideline that this setting might be necessary in VMs.
I have noticed that the server takes longer to start in my docker container. is this setting supposed to help it start up faster?

It's mandatory to trigger updates when you make changes to files -- if anything, it might slow it down, but your save-and-refresh will work.


Javascript Section already shows waypoint cleared

Challenge http://www.freecodecamp.com/challenges/waypoint-declare-string-variables has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

It shows that I have already cleared this waypoint, although I haven't even started yet, infact I ain't even given any input.
The text editor section is still completely empty, but still shows completed???

@shaikhatik0786 I can't reproduce this bug. Can you check that you are still getting the bug?

Well, unfortunately, I couldn't wait for it, so I went ahead with clearing it.

I'll close this for now, but please reopen if you can replicate this issue.


Text documentation is outdated

Issue type

[x] bug report
[ ] feature request

Issue description
Current behavior:
For the Text component the documentation says:
TextComponentProps | TextComponentProps

So you would expect to have:
import { Text } from 'react-native-ui-kitten'

<Text TextComponentProps={{ numberOfLines: 1 }}>
    Foo
</Text>

Expected behavior:
Whereas you have:
<Text numberOfLines={1}>
    Foo
</Text>

I think the second and current behavior is correct, and that you just need a way to update the documentation.

Maybe state ...TextProps | TextProps in the docs so the spread is intended.


Fuzzing: Run FuzzInitContext on OSS-fuzz

Enables FuzzInitContext to run continuously by OSS-fuzz.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @AdamKorcz. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AdamKorcz: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
194785bde74d757655cd17995b47083917f5c571
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AdamKorcz: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
194785bde74d757655cd17995b47083917f5c571
link
/test integ-telemetry-k8s-tests_istio

integ-cni-k8s-tests_istio
194785bde74d757655cd17995b47083917f5c571
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


gopacket cooperation

i'm watching on https://github.com/google/gopacket for sometime, and now found this project. do you plan cooperate work for packet creating/parsing with single lib ?

There are no plans at the moment to use gopacket. It would probably require significant amount of rework to use gopacket.

Further, gopacket seems to rely on cgo which isn't allowed in gVisor (the main user or netstack).

Someone else is using my account, Cheryl Correll<EMAIL_ADDRESS>

It looks like gopacket is more for offline processing and would support a larger number of user level protocols (e.g. I see ntp, tls). I think it would be hard to generally reconcile this with netstack, which will likely continue to need specialized parsing code. I'll close this for now, as there are no concrete plans to use gopacket.


changes for API version 2.1 compatibility

added v2_1.py; modified MySportsFeeds_API.py, init.py for v2.1 compatibility

@bradbarkhouse The latest commits for v2.1 doesn't seems to be released on PyPi https://pypi.org/project/ohmysportsfeedspy/
Is this scheduled in near future?


Does backcall support generators?

Neither <-* nor *<- works out.

+1
Wanted to post the same issue lol.
Works:
  router.get "/#{resource-name}/:id" ->*
    @body = (model-name): yield @models[model-name].find @params.id

Doesn't work:
  *<- router.get "/#{resource-name}/:id"
  @body = (model-name): yield @models[model-name].find @params.id


Add mechanism to disable rule for all projects

Hi,
I like the plugin a lot, what I am missing is an option, to have a few rules disabled not on a project-level, but for all projects together. I would see it as kind of a hierarchy, that you have the rules that are disabled for all projects, and then you have the rules that are disabled for one particular project

Hello! I'm glad you're enjoying the plugin 😄
I'll give this suggestion some thought – I'm wary of adding functionality that isn't a part of ktlint by itself, because I want to maintain parity between command-line usage and IDE usage.
Maybe I can open a PR on ktlint to add a ~/.global_ktlint configuration of sorts 😅

I see your point. I would say as it is a commandline you could have 2 boxes, one for the project and one that is global. Then you could combine the 2 in the command line. But I do like your idea with having a global ktlint file. I guess you could add more functionality to that than just disabling rules as well, if there are any that would make sense :)

The plugin should not support this. I think it is an essential part of the project configuration to know which rules are disabled/enabled and as of that this information needs to be stored in the .editorconfig file (and it should be stored in VCS as well). If you really want to achieve something like this, then it is possible with .editorconfig files. When you omit property root = true from the .editorconfig file, then the parent directories are scanned until an .editorconfig is found in which this property is set. For this you need to create an .editorconfig at a higher level than your project directories.


Add background to HUD

The value for the background can be expressed in hex numbers as 0xaarrggbb (a=alpha, r=red, g=green, b=blue).
The default value is 0x77000000 (=<PHONE_NUMBER>) which makes the background semi-transparent.

Done.


Support Storm 1.0.0+

See individual commits in this PR for more info.
Haven't tested yet, will update the PR when I have.

I've tested with some extra changes in the vagrant setup of this project.  I need to spend a bit more time refining the vagrant-related settings, but the basis of the storm-1.0+ support is here.  I had to make some other minor tweaks that I've rebased appropriately.
I considered collapsing the remaining shims, but opted against it for now.  I suspect they might prove useful once storm-2.0 lands given that it is a huge rewrite (storm-core being changed from Clojure to Java).
Another thing I left out is support for nimbus.seeds -- so we're still reliant on the deprecated nimbus.host config option.  When we understand how to use marathon we will come back to that.
@DarinJ can you please review when you have a chance?

@erikdw my team was just discussing working on stom-1.0.2 a few days based off the WIP branch.  I pulled this PR, will test out and make comments.

Did a quick review of the code ... mostly just package name changes - nothing to worry about.  LGTM.  Going to run some test topo's a cluster.

Hi @erikdw , you got it to run successfully on a cluster I'm guessing? I just tried running a test topo and got some version conflicts
2016-11-01 19:06:47.161 o.a.s.d.worker [ERROR] Error on initialization of server mk-worker java.lang.RuntimeException: Fail to construct messaging plugin from plugin backtype.storm.messaging.netty.Context 	at org.apache.storm.messaging.TransportFactory.makeContext(TransportFactory.java:53) ~[storm-core-1.0.2.jar:1.0.2] 	at org.apache.storm.daemon.worker$worker_data.invoke(worker.clj:266) ~[storm-core-1.0.2.jar:1.0.2] 	at org.apache.storm.daemon.worker$fn__8555$exec_fn__2466__auto__$reify__8557.run(worker.clj:611) ~[storm-core-1.0.2.jar:1.0.2] 	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.7.0_91] 	at javax.security.auth.Subject.doAs(Subject.java:415) ~[?:1.7.0_91] 	at org.apache.storm.daemon.worker$fn__8555$exec_fn__2466__auto____8556.invoke(worker.clj:609) ~[storm-core-1.0.2.jar:1.0.2] 	at clojure.lang.AFn.applyToHelper(AFn.java:178) ~[clojure-1.7.0.jar:?] 	at clojure.lang.AFn.applyTo(AFn.java:144) ~[clojure-1.7.0.jar:?] 	at clojure.core$apply.invoke(core.clj:630) ~[clojure-1.7.0.jar:?] 	at org.apache.storm.daemon.worker$fn__8555$mk_worker__8650.doInvoke(worker.clj:583) [storm-core-1.0.2.jar:1.0.2] 	at clojure.lang.RestFn.invoke(RestFn.java:512) [clojure-1.7.0.jar:?] 	at org.apache.storm.daemon.worker$_main.invoke(worker.clj:771) [storm-core-1.0.2.jar:1.0.2] 	at clojure.lang.AFn.applyToHelper(AFn.java:165) [clojure-1.7.0.jar:?] 	at clojure.lang.AFn.applyTo(AFn.java:144) [clojure-1.7.0.jar:?] 	at org.apache.storm.daemon.worker.main(Unknown Source) [storm-core-1.0.2.jar:1.0.2] Caused by: java.lang.ClassNotFoundException: backtype.storm.messaging.netty.Context 	at java.net.URLClassLoader$1.run(URLClassLoader.java:366) ~[?:1.7.0_91] 	at java.net.URLClassLoader$1.run(URLClassLoader.java:355) ~[?:1.7.0_91] 	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.7.0_91] 	at java.net.URLClassLoader.findClass(URLClassLoader.java:354) ~[?:1.7.0_91] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:425) ~[?:1.7.0_91] 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) ~[?:1.7.0_91] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ~[?:1.7.0_91] 	at java.lang.Class.forName0(Native Method) ~[?:1.7.0_91] 	at java.lang.Class.forName(Class.java:195) ~[?:1.7.0_91] 	at org.apache.storm.messaging.TransportFactory.makeContext(TransportFactory.java:38) ~[storm-core-1.0.2.jar:1.0.2] 	... 14 more
Any thoughts on this?

@clharris : don't recognize those errors.  Yes, I tried this on a "cluster", but really it's the vagrant setup in this project.  My guess would be that this is a storm conflict between previously deployed stuff and the newer version.  I'm pretty sure it's not backwards compatible.  i.e., if that was the case then you would need to:

wipe out storm state in storm-local on the Nimbus
wipe out ZooKeeper
make sure all the existing workers/supervisors are dead

@clharris : upon looking closer at the error, I think this is a problem with your configuration somehow:

Error on initialization of server mk-worker java.lang.RuntimeException: Fail to construct messaging plugin from plugin backtype.storm.messaging.netty.Context

^ Note: backtype.storm.messaging.netty.Context
That should be:  org.apache.storm.messaging.netty.Context
If not your configuration, then maybe a problem with how you're building?
Here's how I built:
STORM_RELEASE=1.0.2 MESOS_RELEASE=1.0.1 bin/build-release.sh

@erikdw, oops, you're right, I was using an old storm.yaml which had the wrong storm.messaging.transport. Sorry I didn't notice that one sooner. It still seems that I have something that's not configured quite right, but I'll have to look at it more tomorrow.  Thanks for your help

@clharris : phew, glad to help!

@erikdw: just tinkered with it again this morning and everything is running great now! LGTM

Tested +1 LGTM

@DarinJ & @clharris : thanks for the help with testing and reviewing!  Gonna merge and release the 1st storm-1.0+ image.

I woulod like to test upgrading our storm-mesos framework to use storm 1.0. Is there documentation for upgrade step ? Can I just upgrade nimbus to storm 1.0 and have new workers/existing works on restart pull in storm 1.0 ?
This is assuming backward compatibility with a given topology running both new worker 1.0 and old worker 0.9.6.

@maverick2202 : sorry for delayed response.  This is not a storm-mesos question really, it's a storm question.  But I can tell you that storm 1.0 is not directly backwards compatible with storm 0.9.x -- they changed the package paths for all classes from backtype.* to org.apache.*.
There is a parameter-based workaround you can try for allowing storm 0.9.x topologies to run on storm 1.0+, but I haven't ever tried it.  It's been discussed on the storm user mailing lists. See these links:

<EMAIL_ADDRESS>https://storm.apache.org/releases/1.0.0/index.html

It sounds like you need to wipe a lot of state to upgrade to storm-1.0 from the emails in that thread.


WebChat into a React Application

Hi,
I have a existing React Application into which I am thinking of inserting some "conversational" UI elements using the BotFramework. Problem I am having with this is since BotFramework-WebChat has a copy of react that it brings in as part of its node_modules this is conflicting with the copy of react that I am already importing in my application. Are there some suggestions of how I can get around this?
Thanks,

Yes, please read this which talks about the right way to do this pattern.

Which one exactly please? A little more pointed feedback would be more
helpful.
Thanks,
On Thu, 14 Dec 2017 at 00:30, Bill Barnes<EMAIL_ADDRESS>wrote:

Yes, please read this
https://github.com/Microsoft/BotFramework-WebChat#medium-in-your-react-website-incorporate-the-web-chat-react-component
which talks about the right way to do this pattern.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotFramework-WebChat/issues/812#issuecomment-351570107,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKCvfoCu9QOc7J1fKE-HAKvGJi4UsGVPks5tAGw8gaJpZM4RBPSr
.

I'm not sure what you mean when you say "which one". If you follow the indicated link you will get to a section of the README providing specific instructions about how to include Web Chat as a React component. Have you read that, and if so, what specific questions do you have?


OK - Onboarding - Test HL7 with fake data

Problem statement
The HL7 structure needs to be tested with OK. This con be completed in parallel with the work for the REST transport.
Acceptance criteria

[ ] OK accepts HL7 structure

To do

[x] Create HL7 files from CLI with fake data
[x] received feedback
[ ] implement settings changes as needed

test site: https://labupload-uat.health.ok.gov/#/login

Test data passed validation. Ready for transport.


Add round robin executor slots reservation policy for the scheduler to evenly assign tasks to executors

Which issue does this PR close?

Closes #371.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Hi @thinkharderdev and @andygrove, could you help review this PR?


Action executed Twice while redirecting

What steps will reproduce the problem?
public function actionLaunch()
 {
   return $this->redirect(['site/index']);
 }

public function actionIndex()
    {
       if(!empty($_SESSION['basic']))
			$_SESSION['basic']++;
		else
			$_SESSION['basic']= 1;

		echo $_SESSION['basic'];
    }

What is the expected result?
Session will be incremented by one while redirect
which mean the action is executed once
What do you get instead?
Session will be incremented by two ( not always )
which mean the action is executed twice
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.0

Operating system
windows

Who is calling actionLaunch? Maybe is the caller make two time the same call?

@FabrizioCaldarelli
we are calling the launch action manually in the browser.
@samdark
we have test it in different cases and it's still reproducible
Thanks.

Are you clearing the sessions between each test so it's reset?

@mmezzawi are you testing it on Google Chrome?
I faced something similar to this case. But I realized that the problem is caused by Google Chrome.
It only happens when I enter the url manually in the address bar.
I suspect that Google Chrome launch a anticipated request while you are typing the address.

Try Firefox. It's the only browser that behaves strictly according to standards nowadays. If it doesn't work in FF then it's something in Yii. If it does and it's a Chrome thing then I'm not surprised. The way it maintains sessions when closing-opening browser is totally against standards but well, it is how it is.

@berosoboy ,  @samdark
The issue is only occurring on google chrome, another request is made without been logged in the dev tools , i have used wireshark to monitor this behavior.
The following issue https://bugs.chromium.org/p/chromium/issues/detail?id=64810 and other issue related to the same topic were reported but none has a solution.
Any advice about this  ?
Thanks in advance

I suspect that is caused by one of these Chrome default settings:

My only advice is to not rely on GET method if you want to change sensitive data in your application.

Dear @berosoboy ,
That right seems those two features are responsible of this issue.
Currently the issue appear while redirecting to another action ( note no params are sent )
Thanks.

I guess that the issue will happen regardless of redirection.

Since it's Chrome issue and not Yii issue, closing.

@samdark @berosoboy,
Appreciated !!!

You're welcome ;)


Use 3D curl in vector hyperdiffusion

Purpose

To-do

Content

[ ] I have read and checked the items on the review checklist.

https://buildkite.com/clima/climaatmos-longruns/builds/1161

There's probably some small numerical change, but it shouldn't be behavior changing.

There's probably some small numerical change, but it shouldn't be behavior changing.

Right, I meant the mse change. The results look good to me.

Longruns available here: https://buildkite.com/clima/climaatmos-longruns/builds/1166
@szy21 do they look okay?

The longrun looks good to me.

bors r+


Create python3_Esha.py

December 17th solution

Hi Hope you're doing well.
Thank you for taking the time to solve the all the questions. We really appreciate your efforts. We will verify your submission and your certificate will be sent to you in your email. Thank you for participating. Keep an eye on our social media page for our upcoming events.
Can you please specify your college/institution name and your mail for the certificate.

Also kindly specify your full name for the certificates.

Name:  Esha H
Email : @.***
Institution: PES UNIVERSITY
Thanks & Regards
Esha
On Wed, 18 Jan 2023, 14:34 Deepika-Govindaswamy, @.***>
wrote:

Also kindly specify your full name for the certificates.
—
Reply to this email directly, view it on GitHub
https://github.com/SVCE-ACM/A-December-of-Algorithms-2022/pull/38#issuecomment-1386710875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM5J3LOPUO7XJOM3HSKIBT3WS6W2BANCNFSM6AAAAAATB6JKOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi,
There has been some issue in contacting you via mail. Can you please share the following details to the specified mail Id.
Full name, college/institution name and your mail id.
Share the details to<EMAIL_ADDRESS>

I have sent
Thanks
Esha
On Thu, 19 Jan 2023, 19:32 Deepika-Govindaswamy, @.***>
wrote:

Hi,
There has been some issue in contacting you via mail. Can you please share
the following details to the specified mail Id.
Full name, college/institution name and your mail id.
Share the details to @.***
—
Reply to this email directly, view it on GitHub
https://github.com/SVCE-ACM/A-December-of-Algorithms-2022/pull/38#issuecomment-1397028328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM5J3LKKSFS6JB2B2LYWF4DWTFCQVANCNFSM6AAAAAATB6JKOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Dave week 24

Hello @pbalm! Thanks for submitting the PR.

In the file src/main/python/server.py, following are the PEP8 issues :

Line 11:1: E402 module level import not at top of file
Line 12:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 60:121: E501 line too long (121 > 120 characters)
Line 66:13: E128 continuation line under-indented for visual indent
Line 67:13: E126 continuation line over-indented for hanging indent
Line 73:13: E128 continuation line under-indented for visual indent
Line 74:13: E126 continuation line over-indented for hanging indent
Line 80:13: E128 continuation line under-indented for visual indent
Line 81:13: E126 continuation line over-indented for hanging indent
Line 87:13: E128 continuation line under-indented for visual indent
Line 88:13: E126 continuation line over-indented for hanging indent
Line 94:13: E128 continuation line under-indented for visual indent
Line 95:13: E126 continuation line over-indented for hanging indent
Line 101:13: E128 continuation line under-indented for visual indent
Line 107:13: E128 continuation line under-indented for visual indent
Line 113:13: E128 continuation line under-indented for visual indent
Line 114:13: E126 continuation line over-indented for hanging indent
Line 122:13: E128 continuation line under-indented for visual indent
Line 123:13: E126 continuation line over-indented for hanging indent
Line 131:13: E128 continuation line under-indented for visual indent
Line 132:13: E126 continuation line over-indented for hanging indent
Line 142:13: E128 continuation line under-indented for visual indent
Line 143:13: E126 continuation line over-indented for hanging indent
Line 149:13: E128 continuation line under-indented for visual indent
Line 150:13: E126 continuation line over-indented for hanging indent
Line 162:13: E128 continuation line under-indented for visual indent
Line 163:13: E126 continuation line over-indented for hanging indent
Line 171:13: E128 continuation line under-indented for visual indent
Line 172:13: E126 continuation line over-indented for hanging indent

In the file src/main/python/utils/dataset_helper.py, following are the PEP8 issues :

Line 18:8: E713 test for membership should be 'not in'
Line 27:42: E211 whitespace before '('
Line 49:46: E211 whitespace before '('
Line 75:43: E261 at least two spaces before inline comment
Line 75:44: E262 inline comment should start with '# '
Line 138:36: E211 whitespace before '('
Line 140:26: E127 continuation line over-indented for visual indent
Line 142:25: E127 continuation line over-indented for visual indent
Line 145:36: E211 whitespace before '('
Line 161:44: E211 whitespace before '('
Line 162:44: E211 whitespace before '('
Line 168:22: E211 whitespace before '('
Line 172:1: E265 block comment should start with '# '
Line 175:24: E703 statement ends with a semicolon
Line 198:1: E265 block comment should start with '# '
Line 200:31: E226 missing whitespace around arithmetic operator
Line 201:9: E265 block comment should start with '# '
Line 254:37: E211 whitespace before '('
Line 264:36: E211 whitespace before '('
Line 265:33: E128 continuation line under-indented for visual indent
Line 316:30: E225 missing whitespace around operator
Line 317:27: E225 missing whitespace around operator
Line 321:121: E501 line too long (172 > 120 characters)
Line 330:1: E302 expected 2 blank lines, found 1
Line 330:18: E211 whitespace before '('
Line 339:12: E713 test for membership should be 'not in'

In the file src/main/python/utils/dave_endpoint.py, following are the PEP8 issues :

Line 42:1: E265 block comment should start with '# '
Line 43:1: E302 expected 2 blank lines, found 1
Line 59:35: E261 at least two spaces before inline comment
Line 213:121: E501 line too long (121 > 120 characters)
Line 266:121: E501 line too long (127 > 120 characters)
Line 309:33: E127 continuation line over-indented for visual indent
Line 338:49: E128 continuation line under-indented for visual indent
Line 346:33: E127 continuation line over-indented for visual indent
Line 374:49: E127 continuation line over-indented for visual indent
Line 385:4: E111 indentation is not a multiple of four
Line 386:4: E111 indentation is not a multiple of four
Line 387:8: E111 indentation is not a multiple of four
Line 389:4: E111 indentation is not a multiple of four
Line 390:4: E111 indentation is not a multiple of four
Line 391:8: E111 indentation is not a multiple of four
Line 392:8: E111 indentation is not a multiple of four
Line 393:12: E111 indentation is not a multiple of four
Line 395:4: E111 indentation is not a multiple of four
Line 396:4: E111 indentation is not a multiple of four
Line 397:8: E111 indentation is not a multiple of four
Line 398:8: E111 indentation is not a multiple of four
Line 399:12: E111 indentation is not a multiple of four
Line 401:4: E111 indentation is not a multiple of four
Line 402:4: E111 indentation is not a multiple of four
Line 403:8: E111 indentation is not a multiple of four
Line 405:4: E111 indentation is not a multiple of four
Line 406:4: E111 indentation is not a multiple of four
Line 407:8: E111 indentation is not a multiple of four
Line 408:8: E111 indentation is not a multiple of four
Line 409:12: E111 indentation is not a multiple of four
Line 411:4: E111 indentation is not a multiple of four
Line 412:4: E111 indentation is not a multiple of four
Line 413:8: E111 indentation is not a multiple of four
Line 414:8: E111 indentation is not a multiple of four
Line 415:12: E111 indentation is not a multiple of four
Line 417:4: E111 indentation is not a multiple of four
Line 418:4: E111 indentation is not a multiple of four
Line 419:4: E111 indentation is not a multiple of four
Line 420:4: E111 indentation is not a multiple of four
Line 421:4: E111 indentation is not a multiple of four
Line 422:4: E111 indentation is not a multiple of four
Line 423:4: E111 indentation is not a multiple of four
Line 424:4: E111 indentation is not a multiple of four
Line 425:4: E111 indentation is not a multiple of four
Line 426:4: E111 indentation is not a multiple of four
Line 427:4: E111 indentation is not a multiple of four
Line 428:4: E111 indentation is not a multiple of four
Line 429:4: E111 indentation is not a multiple of four
Line 430:4: E111 indentation is not a multiple of four
Line 431:4: E111 indentation is not a multiple of four
Line 432:4: E111 indentation is not a multiple of four
Line 434:4: E111 indentation is not a multiple of four
Line 438:4: E111 indentation is not a multiple of four
Line 440:4: E111 indentation is not a multiple of four
Line 479:121: E501 line too long (124 > 120 characters)
Line 506:45: E128 continuation line under-indented for visual indent
Line 526:33: E128 continuation line under-indented for visual indent
Line 556:49: E128 continuation line under-indented for visual indent
Line 564:29: E127 continuation line over-indented for visual indent
Line 565:29: E127 continuation line over-indented for visual indent

In the file src/main/python/utils/dave_engine.py, following are the PEP8 issues :

Line 53:17: E265 block comment should start with '# '
Line 58:13: E265 block comment should start with '# '
Line 91:56: E226 missing whitespace around arithmetic operator
Line 91:121: E501 line too long (124 > 120 characters)
Line 92:85: E128 continuation line under-indented for visual indent
Line 93:85: E128 continuation line under-indented for visual indent
Line 104:55: E261 at least two spaces before inline comment
Line 105:50: E261 at least two spaces before inline comment
Line 268:59: E703 statement ends with a semicolon
Line 269:41: E262 inline comment should start with '# '
Line 270:37: E262 inline comment should start with '# '
Line 271:45: E262 inline comment should start with '# '
Line 342:1: E265 block comment should start with '# '
Line 378:13: E265 block comment should start with '# '
Line 383:121: E501 line too long (121 > 120 characters)
Line 393:121: E501 line too long (142 > 120 characters)
Line 455:44: E261 at least two spaces before inline comment
Line 458:73: E226 missing whitespace around arithmetic operator
Line 458:121: E501 line too long (157 > 120 characters)
Line 458:126: E226 missing whitespace around arithmetic operator
Line 465:48: E225 missing whitespace around operator
Line 466:60: E225 missing whitespace around operator
Line 495:1: E265 block comment should start with '# '
Line 515:13: E265 block comment should start with '# '
Line 522:121: E501 line too long (159 > 120 characters)
Line 523:77: E128 continuation line under-indented for visual indent
Line 554:33: E127 continuation line over-indented for visual indent
Line 563:41: E128 continuation line under-indented for visual indent
Line 570:20: E711 comparison to None should be 'if cond is not None:'
Line 607:33: E127 continuation line over-indented for visual indent
Line 634:40: E211 whitespace before '('
Line 642:16: E711 comparison to None should be 'if cond is not None:'
Line 645:25: E711 comparison to None should be 'if cond is not None:'
Line 667:20: E711 comparison to None should be 'if cond is not None:'
Line 751:41: E211 whitespace before '('
Line 763:41: E211 whitespace before '('
Line 770:27: E711 comparison to None should be 'if cond is not None:'
Line 771:27: E711 comparison to None should be 'if cond is not None:'
Line 783:9: E265 block comment should start with '# '
Line 804:44: E225 missing whitespace around operator
Line 806:52: E225 missing whitespace around operator
Line 807:31: E201 whitespace after '['
Line 807:54: E202 whitespace before ']'
Line 810:46: E225 missing whitespace around operator
Line 812:54: E225 missing whitespace around operator
Line 813:32: E201 whitespace after '['
Line 813:57: E202 whitespace before ']'
Line 818:21: E711 comparison to None should be 'if cond is not None:'
Line 820:21: E711 comparison to None should be 'if cond is not None:'
Line 845:1: E265 block comment should start with '# '
Line 857:26: E225 missing whitespace around operator
Line 879:80: E703 statement ends with a semicolon
Line 880:48: E226 missing whitespace around arithmetic operator
Line 918:121: E501 line too long (125 > 120 characters)
Line 921:21: E225 missing whitespace around operator
Line 936:72: E128 continuation line under-indented for visual indent
Line 943:121: E501 line too long (130 > 120 characters)
Line 949:121: E501 line too long (130 > 120 characters)
Line 951:51: E231 missing whitespace after ','
Line 954:44: E231 missing whitespace after ','
Line 955:62: E231 missing whitespace after ','
Line 956:70: E231 missing whitespace after ','
Line 991:22: E111 indentation is not a multiple of four
Line 995:27: E211 whitespace before '('
Line 1026:33: E128 continuation line under-indented for visual indent
Line 1031:41: E128 continuation line under-indented for visual indent
Line 1037:27: E128 continuation line under-indented for visual indent
Line 1040:77: E502 the backslash is redundant between brackets
Line 1064:45: E262 inline comment should start with '# '
Line 1065:51: E226 missing whitespace around arithmetic operator
Line 1112:29: E127 continuation line over-indented for visual indent
Line 1113:29: E127 continuation line over-indented for visual indent
Line 1120:41: E128 continuation line under-indented for visual indent
Line 1141:62: E127 continuation line over-indented for visual indent
Line 1146:41: E128 continuation line under-indented for visual indent
Line 1158:77: E502 the backslash is redundant between brackets
Line 1215:5: E265 block comment should start with '# '
Line 1261:26: E211 whitespace before '('
Line 1267:1: E302 expected 2 blank lines, found 1
Line 1267:38: E211 whitespace before '('
Line 1274:1: E302 expected 2 blank lines, found 1
Line 1274:41: E211 whitespace before '('
Line 1276:36: E261 at least two spaces before inline comment
Line 1278:48: E225 missing whitespace around operator
Line 1291:26: E211 whitespace before '('
Line 1318:9: E125 continuation line with same indent as next logical line
Line 1324:121: E501 line too long (140 > 120 characters)
Line 1328:9: E265 block comment should start with '# '
Line 1330:40: E211 whitespace before '('
Line 1350:47: E211 whitespace before '('
Line 1350:121: E501 line too long (123 > 120 characters)
Line 1354:121: E501 line too long (127 > 120 characters)
Line 1384:33: E128 continuation line under-indented for visual indent
Line 1408:36: E211 whitespace before '('
Line 1422:30: E211 whitespace before '('
Line 1427:59: E211 whitespace before '('

In the file src/main/python/utils/dave_reader.py, following are the PEP8 issues :

Line 14:10: E225 missing whitespace around operator
Line 16:1: E302 expected 2 blank lines, found 1
Line 48:9: E265 block comment should start with '# '
Line 57:48: E128 continuation line under-indented for visual indent
Line 58:48: E128 continuation line under-indented for visual indent
Line 63:57: E128 continuation line under-indented for visual indent
Line 75:65: E231 missing whitespace after ','
Line 148:36: E128 continuation line under-indented for visual indent
Line 149:36: E128 continuation line under-indented for visual indent
Line 175:37: E128 continuation line under-indented for visual indent
Line 176:37: E128 continuation line under-indented for visual indent
Line 202:45: E128 continuation line under-indented for visual indent
Line 204:5: E265 block comment should start with '# '
Line 217:30: E128 continuation line under-indented for visual indent
Line 218:30: E128 continuation line under-indented for visual indent
Line 231:69: E127 continuation line over-indented for visual indent

In the file src/main/python/utils/exception_helper.py, following are the PEP8 issues :

Line 4:1: E302 expected 2 blank lines, found 1
Line 11:1: E302 expected 2 blank lines, found 1

In the file src/main/python/utils/model_helper.py, following are the PEP8 issues :

Line 17:10: E111 indentation is not a multiple of four
Line 20:10: E111 indentation is not a multiple of four
Line 23:10: E111 indentation is not a multiple of four
Line 26:10: E111 indentation is not a multiple of four
Line 29:10: E111 indentation is not a multiple of four
Line 58:53: E703 statement ends with a semicolon
Line 60:49: E703 statement ends with a semicolon
Line 81:18: E111 indentation is not a multiple of four
Line 83:18: E111 indentation is not a multiple of four
Line 85:18: E111 indentation is not a multiple of four
Line 87:18: E111 indentation is not a multiple of four
Line 87:121: E501 line too long (124 > 120 characters)

In the file src/main/python/utils/np_encoder.py, following are the PEP8 issues :

Line 8:1: E302 expected 2 blank lines, found 1


[seti] ts icon should be blue

You're my boy, Blue!

VSCode Version:  1.20.0-insider
OS Version: Windows 10 1709 (16299.125)

Please, return back dark-cyan color for *.ts files, Yellow really annoying.

Still yellow for me:

@bpasero I don't see this. Are you sure you are on the latest? You should also see an icon for test.jsonc

Ah, spec.ts is should be yellow, as defined in the seti theme: https://github.com/jesseweed/seti-ui/blob/16dc5ccb7db6329f99c20c75fc7b536965765a96/styles/components/icons/mapping.less#L315

IMO all is fine. @bpasero Please reverify: .ts should be blue .spec.ts yellow

Yeah that is what I see.


Add support for optional param names

api-pagination uses params[:page] and params[:per_page] to set the current page and per-page options in the controller by default. This commit allows user to actually override those and use their own getters or specify the name of the parameter. So they can use for example params[:page][:number] for current page by default.
No breaking changes (just one more feature)

Nice work here, @JiriChara! I really like the solution you came up with. If you could just fix that one issue I mentioned above, I'm more than happy to merge this in

Thanks @davidcelis! I am happy to help :-). I have fixed the issue you mentioned.

Thanks a ton!