Endless gulp rebuild cycle in gulp watch in project as templated from yo generator

Category

[x] Bug

Describe the bug
I built a fresh SharePoint 2016 SPFX web parts solution using the yo generator (@microsoft/generator-sharepoint). When trying to develop/debug the solution with gulp serve I was seeing near constant rebuilds causing near constant reloads which made it difficult to develop/debug in the SharePoint Workbench.
It appears that the solution seems easy and it is a bug in the basic generator output: Adding an "outDir": "lib" to the solution's tsconfig.json file keeps Typescript's generated outputs from compiling to the src directory and confusing the gulp watch with changing .d.ts/.js files on every Typescript build. Given other things about the build setup and the .gitignore I presume something like "outDir": "lib" was intended in the first place.
(Though this may have something to do with tech debt changes in the build pipeline caused by npm audit fix.)
I'd file a PR directly to the generator template, but a quick search did not turn up a repository for it, only a suggestion to file feedback in the issues of this repository. (Apologies if I'm mistaken and this is not the correct place.)
Steps to reproduce

yo @microsoft/sharepoint
Select a target of SharePoint 2016
npm audit fix (to fix up several Critical package updates)
npm i @microsoft/rush-typescript-compiler-3.2 (to get the build and the Workbench working)
npx gulp serve

Expected behavior
The watch build process in npx gulp serve should compile only on user file changes.
Environment details (development & target environment)

Your Developer Environment: Windows 10
Target Environment: SharePoint Server 2016
Framework: Node.js v10
Browser(s): FireFox v78 | Chromium Edge v83
Tooling: VS Code | SPFx v1.10.0

Couple things...

If you're working with SP2016 & this, SPFx v1.1, you should be using Node.js v8 (see the docs for more details)
Do not run npm audit fix... that upgrades dependency package to versions that have not been tested with the SPFx build pipeline.
Changing the version of TypeScript is not supported in SPFx v1.1 projects... this capability was added to SPFx v1.8.

Maybe remove the SPFX v1.1 option from the yeoman generator if critical-level npm audit flaws cannot be easily addressed? That seems to me that clearly security support has ended for that framework version.
It also sounds like there should should have been a semver-major version bump somewhere between 1.1 and 1.8 to stop automated tools for assuming backward compatibility. I certainly assumed coming into this that a change in supported SharePoint version would be a semver-level breaking change, and it would have avoided some immediate confusion in the above thread that 1.10 is not 1.1.

The core of the issue is your version of Node that you're using. As I said in my response, SPFx v1.1 requires Node.js v8.
@WorldMaker said:

That seems to me that clearly security support has ended for that framework version.

The report of issues has nothing to do with SPFx itself... it's simply with the tooling. None of those packages are included in the bundle you create and deploy to SharePoint.
@WorldMaker said:

It also sounds like there should should have been a semver-major version bump somewhere between 1.1 and 1.8 to stop automated tools for assuming backward compatibility. I certainly assumed coming into this that a change in supported SharePoint version would be a semver-level breaking change, and it would have avoided some immediate confusion in the above thread that 1.10 is not 1.1.

Not sure I follow this.
Think of the SPFx generator like Visual Studio. You can use any version to create a .NET v2 project. It's usually ideal to use the latest version and not an older version... just like SPFx. You use the most current version to create your project.
Once the project is created, the generator (v1.10) doesn't matter at all... the project defines the SPFx version it uses (look in package.json). SP2016 FP2 has SPFx v1.1 installed, so that's what your project targets.

Node v8 has been EOL since December. Again, it doesn't seem like this version of the framework can be considered in active security support if all of its build tools are out of security support, and have known critical vulnerabilities. I return to my recommendation that to avoid confusing other potential users of the generator that you remove the SharePoint 2016 option if you aren't going to update the build tools for it to a more recent supported version.

Thanks for the feedback.
Simply repeating what MSFT has said: all feedback & change requests should be submitted to User Voice. When I add the label to this issue, it will automatically close it as that's where MSFT triages their backlog for changes/feature requests, not this list.


Tag 0.1.3 (from hex.pm) does not validate patternProperties?

Json example:
{
        "configs": {
                "ba117f6-e26c-4dca-83e6-d397d90889d4": {
                        "cpu": "a"
                 }
         }
}

Schema:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "properties": {
        "configs": {
        "type": "object",
        "additionalProperties": false,
        "patternProperties": {
          "^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$": {
            "type": "object",
            "properties": {
              "cpu": {
                "type": "string",
                "enum": ["a", "b"]
              }
          }
        }
      }
    }
  }
}

enum does not work as expected.

You have additionalProperties: false, and since you do not defined any properties, that means configs must be an empty object.
Next time you open an issue, please explain a. what is the current output b. what is the expected output. Thanks.


Mypy in PyCharm doesn't know about the PyDantic new functions

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using Mypy extension inside PyCharm
it shows error for

But when I try to do mypy from cli it works just fine:

It shows expected errors - just to demo the bug -

I am using the mypy plugin:
[mypy]
plugins = pydantic.mypy

I don't know where the bug exactly, is it related to mypy, PyCharm, or PyDantic?
Example Code
class Model(BaseModel):
    model_config = {"from_attributes": True}
    age: int
    last_name: str | None = None
    signup_ts: datetime | None = None
    list_of_ints: list[int]

Model.parse_obj({"age": 1, "last_name": "a"})
Model.parse_raw(b'{"age": 1, "last_name": "a"}')
Model.model_validate({"age": 1, "last_name": "a"})
Model.model_dump()
Model.model_copy()
Model.model_json_schema()
Model.model_dump_json()
Model.model_rebuild()

Python, Pydantic & OS Version
pydantic version: 2.3.0
        pydantic-core version: 2.6.3
          pydantic-core build: profile=release pgo=false
                 install path: /Users/abdullahhashim/Projects/Job/REGA/rei-api/venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (v3.11.4:d2340ef257, Jun  6 2023, 19:15:51) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
                     platform: macOS-13.4.1-arm64-arm-64bit
     optional deps. installed: ['typing-extensions']

Well... It only works on instances of BaseModel. They are not classmethods/staticmethods.
If you instantiate a Model object, and try to run the methods, it should work as expected.

@Kludex How would I do it if I want to map ORM object to Pydantic object?
How would I instantiate without the mypy complaining?

I'm not following your use case. The "methods" you are trying to use doesn't exist for the class, so mypy is correct.

@Kludex Thanks for you response
I tried to instantiate a model. But still mypy is complaining:

It's hard to be certain without seeing more details, but this appears to me to be a bug specifically with the PyCharm Mypy extension you are using. If you can reproduce those mypy errors using just the CLI (and not the PyCharm UI), we can look into it (though I will be surprised if you can, since I think this would be a very obvious issue with pydantic or mypy).
I also don't think this is a general-PyCharm issue as I use PyCharm (without the mypy extension) and don't have this issue, which is why I think it's probably an issue with the PyCharm mypy extension and/or your configuration of it. If that extension has a public GitHub or similar, it might make sense to report the issue there and see if they suggest anything.

Thanks for the heads up @dmontagu
You are correct the extension was pointing to to different version for mypy not the one in the venv
It was pointing to:
/Library/Frameworks/Python.framework/Versions/3.11/bin/mypy

Which could be the default behavior for the default configs for mypy-pycharm plugin -

The fix:
/Users/user/Projects/my-project/venv/bin/mypy
Thanks,
Problem fixed 🙏


Plagiarism checks: Add more plagiarism result stats

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server..
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[x] I followed the coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context
Instructors cannot quickly check basic plagiarism checks statictics. They also don't know who (other instructor or cpc) triggered the job.
Description
This PR introduces several new statistics to be displayed on the plagiarism results page. They are:

number of detected submissions
average similarty
maximal similarity
duration of the check (in a simplified form, will close #6143)
start time
start by (specific user or the cpc)

Because new DTO is created, this PR includes small refactor of moving other plagiarism related DTOs into a separate package.
Steps for Testing
Prerequisites:

1 Instructor
2 Students
1 Exercise

Create an exercise.
Create two similar submissions for that exercise.
Go to the exercise as instructor and open Check plagiarism
Run the check
Verify that stats are correct

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress
Performance Review

[x] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[x] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[x] Code Review 1
[x] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Class/File
Line Coverage
Confirmation (assert/expect)

PlagiarismResultResponseBuilder
86%
✅

Screenshots
New statistics (wide screen):

New statistics (narrow screen):

@jakubriegel some server tests are failing, please fix them before setting the PR to ready to merge

@krusche tests are fixed


Cannot Curl the service within the cluster

I'm new to K8S, so happy to be pointed to the right direction.
I've been struggling to understand why my setup doesn't work. I have a Vagrant file that creates 3 VMs. 1 K8S master and 2 Nodes. https://github.com/AntAreS24/containerisation
I can see the service and rc of my cluster up and running:
core@master ~ $ kubectl get rc
NAME          DESIRED   CURRENT   AGE
test-be-rc   2         2         1d

core@master ~ $ kubectl get services
NAME               CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
kubernetes         <IP_ADDRESS>     <none>        443/TCP    1d
test-be-service   <IP_ADDRESS>                 7000/TCP   10m

and the pods are running:
core@master ~ $ kubectl get pods
NAME                READY     STATUS             RESTARTS   AGE
test-be-rc-8me95   1/1       Running   0          33m
test-be-rc-86ij0   1/1       Running   0          33m

If I check the logs for the pods, I get what I expect and if I curl the pod on the specific node, I get a response:
core@node02 ~ $ docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED              STATUS              PORTS               NAMES
329f0dd70f41        drr.test.com:5000/businessevents    "/bin/sh -c /start.sh"   About a minute ago   Up About a minute                       k8s_k8be.deeefc6_test-be-rc-8me95_default
11e6-a673-080027a75e9e_6db5d57b
d05393f2b4d7        gcr.io/google_containers/pause:2.0   "/pause"                 About a minute ago   Up About a minute                       k8s_POD.253600cc_test-be-rc-8me95_default
11e6-a673-080027a75e9e_faca0cf8

core@node02 ~ $ curl http://<IP_ADDRESS>:7000/Channels/HTTPChannel/trigger_processing?name=normal&number=1
[1] 2578
{test: 'body'}

I tried setting the service type as nothing, NodePorts and LoadBalancer, but I'm getting the same result.
core@master ~ $ kubectl describe service test-be-service
Name:                   test-be-service
Namespace:              default
Labels:                 name=test-be-pod,tier=backend
Selector:               name=test-be-pod,tier=backend
Type:                   LoadBalancer
IP:                     <IP_ADDRESS>
Port:                   http    7000/TCP
NodePort:               http    32149/TCP
Endpoints:              <none>
Session Affinity:       None
No events.

core@master ~ $ kubectl describe rc
Name:           test-be-rc
Namespace:      default
Image(s):       ddr.test.com:5000/businessevents
Selector:       app=test-be-pod,tier=backend
Labels:         name=test-be,tier=backend
Replicas:       2 current / 2 desired
Pods Status:    2 Running / 0 Waiting / 0 Succeeded / 0 Failed
Volumes:
  beconfig:
    Type:       HostPath (bare host directory volume)
    Path:       /home/core/be
Events:
  FirstSeen     LastSeen        Count   From                            SubobjectPath   Type            Reason                  Message
  ---------     --------        -----   ----                            -------------   --------        ------                  -------
  13m           13m             1       {replication-controller }                       Normal          SuccessfulCreate        Created pod: test-be-rc-8me95
  13m           13m             1       {replication-controller }                       Normal          SuccessfulCreate        Created pod: test-be-rc-oxag4
  10m           10m             1       {replication-controller }                       Normal          SuccessfulCreate        Created pod: test-be-rc-86ij0

core@master ~ $ kubectl describe pods
Name:           test-be-rc-86ij0
Namespace:      default
Node:           <IP_ADDRESS>/<IP_ADDRESS>
Start Time:     Tue, 10 May 2016 05:27:34 +0000
Labels:         app=test-be-pod,tier=backend
Status:         Running
IP:             <IP_ADDRESS>
Controllers:    ReplicationController/test-be-rc
Containers:
  k8be:
    Container ID:       docker://87b3e1bc1a57ca0383556a889a688347c914b69ea083ba1c2dc3e01dec2f7845
    Image:              ddr.test.com:5000/businessevents
    Image ID:           docker://sha256:48e6bd0642a752cc871eb7f2151f23da719c30654c53dbc8801d0c43b5fae9a2
    Port:               7000/TCP
    QoS Tier:
      cpu:              BestEffort
      memory:           BestEffort
    State:              Running
      Started:          Tue, 10 May 2016 05:27:38 +0000
    Ready:              True
    Restart Count:      0
    Environment Variables:
      BE_ENGINE_EAR_1:  /data/be/sample.ear
      BE_ENGINE_CDD_1:  /data/be/sample.cdd
      BE_ENGINE_UNIT_1: sample-inf
      BE_ENGINE_TRA_1:  /data/be/be-engine.tra
      BE_ENGINE_JMX_1:  9990
Conditions:
  Type          Status
  Ready         True
Volumes:
  beconfig:
    Type:       HostPath (bare host directory volume)
    Path:       /home/core/be
  default-token-v4sdg:
    Type:       Secret (a volume populated by a Secret)
    SecretName: default-token-v4sdg
Events:
  FirstSeen     LastSeen        Count   From                    SubobjectPath           Type            Reason          Message
  ---------     --------        -----   ----                    -------------           --------        ------          -------
  11m           11m             1       {default-scheduler }                            Normal          Scheduled       Successfully assigned test-be-rc-86ij0 to <IP_ADDRESS>
  11m           11m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulling         pulling image "ddr.test.com:5000/businessevents"
  11m           11m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulled          Successfully pulled image "ddr.test.com:5000/businessevents"
  11m           11m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Created         Created container with docker id 87b3e1bc1a57
  11m           11m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Started         Started container with docker id 87b3e1bc1a57

Name:           test-be-rc-8me95
Namespace:      default
Node:           <IP_ADDRESS>/<IP_ADDRESS>
Start Time:     Tue, 10 May 2016 05:23:59 +0000
Labels:         app=test-be-pod,tier=backend
Status:         Running
IP:             <IP_ADDRESS>
Controllers:    ReplicationController/test-be-rc
Containers:
  k8be:
    Container ID:       docker://329f0dd70f414008b860aea8eeb5112b5b4d72a3d41bf6058ec2ab4a1cb0b41c
    Image:              ddr.test.com:5000/businessevents
    Image ID:           docker://sha256:48e6bd0642a752cc871eb7f2151f23da719c30654c53dbc8801d0c43b5fae9a2
    Port:               7000/TCP
    QoS Tier:
      cpu:              BestEffort
      memory:           BestEffort
    State:              Running
      Started:          Tue, 10 May 2016 05:24:03 +0000
    Ready:              True
    Restart Count:      0
    Environment Variables:
      BE_ENGINE_EAR_1:  /data/be/sample.ear
      BE_ENGINE_CDD_1:  /data/be/sample.cdd
      BE_ENGINE_UNIT_1: sample-inf
      BE_ENGINE_TRA_1:  /data/be/be-engine.tra
      BE_ENGINE_JMX_1:  9990
Conditions:
  Type          Status
  Ready         True
Volumes:
  beconfig:
    Type:       HostPath (bare host directory volume)
    Path:       /home/core/be
  default-token-v4sdg:
    Type:       Secret (a volume populated by a Secret)
    SecretName: default-token-v4sdg
Events:
  FirstSeen     LastSeen        Count   From                    SubobjectPath           Type            Reason          Message
  ---------     --------        -----   ----                    -------------           --------        ------          -------
  14m           14m             1       {default-scheduler }                            Normal          Scheduled       Successfully assigned test-be-rc-8me95 to <IP_ADDRESS>
  14m           14m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulling         pulling image "ddr.test.com:5000/businessevents"
  14m           14m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulled          Successfully pulled image "ddr.test.com:5000/businessevents"
  14m           14m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Created         Created container with docker id 329f0dd70f41
  14m           14m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Started         Started container with docker id 329f0dd70f41

core@master ~ $ curl http://<IP_ADDRESS>:7000
curl: (7) Failed to connect to <IP_ADDRESS> port 7000: Connection refused
core@master ~ $ curl http://<IP_ADDRESS>:7000
curl: (7) Failed to connect to <IP_ADDRESS> port 7000: Connection refused
core@master ~ $ curl http://<IP_ADDRESS>:7000

[ctrl+c]
core@master ~ $ curl http://<IP_ADDRESS>:32149

[ctrl+c]

This last 2 commands actually never complete.
What am I missing? Do I need an Ingress even if it's running locally? I don't really want the full load balancing setup, I just want to be able to call the service on a specific port and get it to route to any pod available.
Any help really appreciated.
Ben

After further testing and reading, I've realised that my service wasn't actually picking up the template defined in the RC. I've fixed that following the guide http://kubernetes.io/docs/user-guide/debugging-services/
I now have endpoints to my service, but they look weird... They don't seem to match the IP of the node or pod.
core@master ~ $ kubectl get svc
NAME              CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
kubernetes        <IP_ADDRESS>       <none>        443/TCP    2d
tibcobe-service   <IP_ADDRESS>   nodes         7000/TCP   16m
```console
core@master ~ $ kubectl get pods
NAME                         READY     STATUS    RESTARTS   AGE
service-loadbalancer-1ictu   1/1       Running   0          20m
tibcobe-m5xgj                1/1       Running   0          18m
tibcobe-yfymc                1/1       Running   0          20m

core@master ~ $ kubectl describe po -l app=tibcobe
Name:           tibcobe-m5xgj
Namespace:      default
Node:           <IP_ADDRESS>/<IP_ADDRESS>
Start Time:     Wed, 11 May 2016 05:25:40 +0000
Labels:         app=tibcobe,tier=backend
Status:         Running
IP:             <IP_ADDRESS>
Controllers:    ReplicationController/tibcobe
Containers:
  k8be:
    Container ID:       docker://2d4274053e73744f2cd3cc41b861d753864e4d12fe38d8161431e657438dd25c
    Image:              ddr.tibco.com:5000/businessevents
    Image ID:           docker://sha256:48e6bd0642a752cc871eb7f2151f23da719c30654c53dbc8801d0c43b5fae9a2
    Port:               7000/TCP
    QoS Tier:
      cpu:              BestEffort
      memory:           BestEffort
    State:              Running
      Started:          Wed, 11 May 2016 05:25:42 +0000
    Ready:              True
    Restart Count:      0
    Environment Variables:
      BE_ENGINE_EAR_1:  /data/be/sample.ear
      BE_ENGINE_CDD_1:  /data/be/sample.cdd
      BE_ENGINE_UNIT_1: sample-inf
      BE_ENGINE_TRA_1:  /data/be/be-engine.tra
      BE_ENGINE_JMX_1:  9990
Conditions:
  Type          Status
  Ready         True
Volumes:
  beconfig:
    Type:       HostPath (bare host directory volume)
    Path:       /home/core/be
  default-token-v4sdg:
    Type:       Secret (a volume populated by a Secret)
    SecretName: default-token-v4sdg
Events:
  FirstSeen     LastSeen        Count   From                    SubobjectPath           Type            Reason          Message
  ---------     --------        -----   ----                    -------------           --------        ------          -------
  19m           19m             1       {default-scheduler }                            Normal          Scheduled       Successfully assigned tibcobe-m5xgj to <IP_ADDRESS>
  19m           19m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulling         pulling image "ddr.tibco.com:5000/businessevents"
  19m           19m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulled          Successfully pulled image "ddr.tibco.com:5000/businessevents"
  19m           19m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Created         Created container with docker id 2d4274053e73
  19m           19m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Started         Started container with docker id 2d4274053e73

Name:           tibcobe-yfymc
Namespace:      default
Node:           <IP_ADDRESS>/<IP_ADDRESS>
Start Time:     Wed, 11 May 2016 05:23:20 +0000
Labels:         app=tibcobe,tier=backend
Status:         Running
IP:             <IP_ADDRESS>
Controllers:    ReplicationController/tibcobe
Containers:
  k8be:
    Container ID:       docker://bf3f946cff897f341801b553f304d63d4cdeb7931b93be7338bf24df41249461
    Image:              ddr.tibco.com:5000/businessevents
    Image ID:           docker://sha256:48e6bd0642a752cc871eb7f2151f23da719c30654c53dbc8801d0c43b5fae9a2
    Port:               7000/TCP
    QoS Tier:
      memory:           BestEffort
      cpu:              BestEffort
    State:              Running
      Started:          Wed, 11 May 2016 05:23:25 +0000
    Ready:              True
    Restart Count:      0
    Environment Variables:
      BE_ENGINE_EAR_1:  /data/be/sample.ear
      BE_ENGINE_CDD_1:  /data/be/sample.cdd
      BE_ENGINE_UNIT_1: sample-inf
      BE_ENGINE_TRA_1:  /data/be/be-engine.tra
      BE_ENGINE_JMX_1:  9990
Conditions:
  Type          Status
  Ready         True
Volumes:
  beconfig:
    Type:       HostPath (bare host directory volume)
    Path:       /home/core/be
  default-token-v4sdg:
    Type:       Secret (a volume populated by a Secret)
    SecretName: default-token-v4sdg
Events:
  FirstSeen     LastSeen        Count   From                    SubobjectPath           Type            Reason          Message
  ---------     --------        -----   ----                    -------------           --------        ------          -------
  21m           21m             1       {default-scheduler }                            Normal          Scheduled       Successfully assigned tibcobe-yfymc to <IP_ADDRESS>
  21m           21m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulling         pulling image "ddr.tibco.com:5000/businessevents"
  21m           21m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Pulled          Successfully pulled image "ddr.tibco.com:5000/businessevents"
  21m           21m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Created         Created container with docker id bf3f946cff89
  21m           21m             1       {kubelet <IP_ADDRESS>}  spec.containers{k8be}   Normal          Started         Started container with docker id bf3f946cff89

core@master ~ $ kubectl describe service tibcobe-service
Name:                   tibcobe-service
Namespace:              default
Labels:                 name=tibcobe-service
Selector:               app=tibcobe
Type:                   NodePort
IP:                     <IP_ADDRESS>
Port:                   http    7000/TCP
NodePort:               http    31176/TCP
Endpoints:              <IP_ADDRESS>:7000,<IP_ADDRESS>:7000
Session Affinity:       None
No events.

Again, I can't curl the service on any IP and port combination. What am I missing?


api for verticegateway and time type changes

@vijaykanthm28  Lets make this change in the subsequent builds.
args := api.NewArgs(m, UPDATEBALANCES ).

So this helps us to do  in one line.
api.NewClient(api.Args(m, Path: UPDATEBALANCES));


Add Qt5 packages (using aqt installer)

Let's give xmake the feature to install Qt!

Only macOS and iPhoneOS are failing now, but I lack the knowledge to fix them, as I think they should use frameworks and not classical include dirs, could you help with me that when you have time?

Only macOS and iPhoneOS are failing now, but I lack the knowledge to fix them, as I think they should use frameworks and not classical include dirs, could you help with me that when you have time?

You can disable them first, I'll merge this patch first. I'll try to improve it when I have time later.

QCoreApplication on macOS
/Users/ruki/.xmake/packages/q/qt5base//5.15.2/9ae68b2268d94ba9925f0671be6c4f44//lib/QtCore.framework/Versions/5/Headers/QCoreApplication
not include/QtCore


Update IBM Cloud registry for IAM

Updates the topic to describe how to use IAM to authorize clusters to pull images from registry.

/assign

/lgtm
/approve


Feature/#30 finalize schema

@briandoconnor , can you take a look at this new version of the metadata_schema.json? I think it is ready to merge with develop. Jean has been using it as to validate his merged metadata, and it seems to be working.

I went ahead and added an analysis-only schema for validating analysis-only objects. The file for that is analysis_schema.json.

Missing dependency in the pip install:
Traceback (most recent call last):
  File "generate_metadata.py", line 23, in <module>
    import semver
ImportError: No module named semver

Is the receipt.tsv output feature broken?  I ran the sample call and don't see a receipt.tsv file in the current directory (or sub-directories).
(env) boconnor@Work-MacBook-Pro:~/Development/gitroot/BD2KGenomics/dcc-storage-schemas$ python generate_metadata.py         --inputMetadataSchema input_metadata.json         --metadataSchema metadata_schema.json         --outputDir output_metadata         --receiptFile receipt.tsv         --awsAccessToken `cat ucsc-storage-client/accessToken`         --skip-upload         sample_tsv/sample.tsv
2016-07-29 16:35:01,004 INFO main:730 couldn't read sample_tsv/sample.tsv as excel file
2016-07-29 16:35:01,004 INFO main:731 ---now trying to read as tsv file
2016-07-29 16:35:01,280 INFO main:766 validated all metadata objects for output
2016-07-29 16:35:01,302 INFO main:770 number of metadata files written: 43
2016-07-29 16:35:01,302 INFO main:773 Skipping data upload steps.
2016-07-29 16:35:01,303 INFO main:774 A detailed log is at: output_metadata/generate_metadata.log
2016-07-29 16:35:01,303 INFO main:776 program ran for 0.299878 s.
(env) boconnor@Work-MacBook-Pro:~/Development/gitroot/BD2KGenomics/dcc-storage-schemas$ find . | grep receipt.tsv
(env) boconnor@Work-MacBook-Pro:~/Development/gitroot/BD2KGenomics/dcc-storage-schemas$

I haven't tested upload but the metadata looks OK.  Also, I just tested generate_metadata.py and not the downstream index builder since Jean is working on this.


NU5131 is now an error, not a warning

This is now an error, not a warning.

@zivkan - NU5131 is a warning right?

NuGet raises it as a warning, yes. If the project opts into "warnings as errors", it will be raised as a error, as requested.  @bgavrilMS Can you check your project to see if warnings are elevated? It might be in a Directory.Build.props file, or another imported file, rather than the project file directly. Since you're Microsoft internal, you can reach out directly if you need help checking your project.

@bgavrilMS, I believe the docs are accurate. If you have specific product isues, please open a bug on the nuget home repo - https://github.com/nuget/home/issues


Creating a game with no password silently fails

If you leave the password field blank and click "Create Game", nothing happens.

Seems to work fine now


examples: add hash and nested

Closes #24. Nested example was adapted from @timoxley's example https://github.com/yoshuawuyts/wayfarer/issues/21#issue-88187680
Changes

examples: initialize hash and nested

Assuming everything was good; merged! 💁


jhack sync is not syncing

I did find issue (https://github.com/canonical/jhack/issues/73) but I figured I should open a new one.
jhack utils sync validator01

ready to sync to:
        validator01/0
watching:
        /home/leo/xxx/src/ansible_runner_helper.py
        /home/leo/xxx/src/charm.py
        /home/leo/xxx/src/ops_helper.py
        /home/leo/xxx/src/error_handler.py
        /home/leo/xxx/lib/charms/operator_libs_linux/v0/apt.py
        /home/leo/xxx/lib/charms/operator_libs_linux/v1/systemd.py
Ctrl+C to interrupt
synced /home/leo/xxx/src/charm.py -> validator01/0

I can then see that the /var/lib/juju/agents/unit-validator01-0/charm/src/charm.py file has not changed
I did re-install jhack a couple times, ran both sudo snap connect jhack:dot-local-share-juju snapd and sudo snap connect jhack:ssh-read snapd but still with no luck.

Just noticed I have so weird ssl errors by trying to run jhack fire:
jhack fire validator01/0 update-status
ERROR:jhack.simulate_event:cmd juju ssh validator01/0 sudo /usr/bin/juju-exec -u validator01/0 JUJU_DISPATCH_PATH=hooks/update-status JUJU_MODEL_NAME=local-network JUJU_UNIT_NAME=validator01/0 ./dispatch terminated with 127
ERROR:jhack.simulate_event:stdout=b''
ERROR:jhack.simulate_event:stderr=b'ssh: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory\n'
Fired update-status on validator01/0.

I did tried this with no luck.

I'm assuming you're on a lxd model?
I think there's something wrong with juju ssh. Can you shell into the unit? Can you juju scp to the unit? I'd start by debugging from there: if that doesn't work, it's not an issue with jhack (aside possibly some better error surfacing)
you can set the LOGLEVEL envvar to DEBUG before your jhack commands to see if you catch some more error messages.

Hey @PietroPasotti, thanks for helping
Both juju ssh and juju scp work:
juju ssh validator01/0 date

Wed Jan 17 10:50:08 UTC 2024
Connection to fd42:77c2:c77f:12a9:216:3eff:fe1d:5ab5 closed.

juju scp validator01/0:/var/log/syslog .

head -n2 syslog
Jan 17 10:42:38 juju-a50ad2-0 keyboard-setup.sh[63]: Couldn't get a file descriptor referring to the console.
Jan 17 10:42:38 juju-a50ad2-0 keyboard-setup.sh[65]: Couldn't get a file descriptor referring to the console

Here's the output of LOGLEVEL=DEBUG jhack fire validator01/0 update-status:
INFO:jhack:jhack running in snapped mode. Checking configuration...
INFO:jhack:juju command is b'/snap/jhack/277/bin/juju\n'
DEBUG:parse:format '{_}: {timestamp:ti} {_}' -> '(.+?): (?P<timestamp>(\\d{4}-\\d\\d-\\d\\d)((\\s+|T)(\\d{1,2}:\\d{1,2}(:\\d{1,2}(\\.\\d+)?)?))?(Z|\\s*[-+]\\d\\d:?\\d\\d)?) (.+?)'
DEBUG:parse:format '{_}: {timestamp:tt} {_}' -> '(.+?): (?P<timestamp>(\\d{1,2}:\\d{1,2}(:\\d{1,2}(\\.\\d+)?)?)?(\\s+[AP]M)?(\\s+[-+]\\d\\d?:?\\d\\d)?) (.+?)'
::= Verbose mode (DEBUG). =::
INFO:jhack.simulate_event:juju ssh validator01/0 sudo /usr/bin/juju-exec -u validator01/0 JUJU_DISPATCH_PATH=hooks/update-status JUJU_MODEL_NAME=local-network JUJU_UNIT_NAME=validator01/0 ./dispatch
ERROR:jhack.simulate_event:cmd juju ssh validator01/0 sudo /usr/bin/juju-exec -u validator01/0 JUJU_DISPATCH_PATH=hooks/update-status JUJU_MODEL_NAME=local-network JUJU_UNIT_NAME=validator01/0 ./dispatch terminated with 127
ERROR:jhack.simulate_event:stdout=b''
ERROR:jhack.simulate_event:stderr=b'ssh: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory\n'
Fired update-status on validator01/0.

What's weird is that running juju ssh validator01/0 sudo /usr/bin/juju-exec -u validator01/0 JUJU_DISPATCH_PATH=hooks/update-status JUJU_MODEL_NAME=local-network JUJU_UNIT_NAME=validator01/0 ./dispatch manually does work...

Yeah probably something to do with jhack snap confinement... I assume you're using jhack from snap. If you're willing to install it from sources you should be able to use all commands more freely until I figure out what's going on.
For me it doesn't actually work manually either, which is fun.

Yeah probably something to do with jhack snap confinement... I assume you're using jhack from snap. If you're willing to install it from sources you should be able to use all commands more freely until I figure out what's going on.
For me it doesn't actually work manually either, which is fun.

Installing via pip did the trick. sync is now working as expected.
Thanks again :+1:

It will also work again from snap once I release #123 which should be in a few minutes


<EMAIL_ADDRESS>+saE2QGoeQMbKMRS6J3vQ>\

<EMAIL_ADDRESS>+saE2QGoeQMbKMRS6J3vQ>\
Originally posted by @AVIJEET7415 in https://github.com/OfficeDev/BotBuilder-MicrosoftTeams/pull/244#discussion_r841027903

@AVIJEET7415 - Could you please elaborate your issue?


init commit

todo:

[x] add env variables
[x] typescript stuff
[x] checking off todos
[x] adding svelte logo
[x] cleaning up

@TorstenDittmann  The update todo functionality might need some tweaking. The line-through class is doesn't seem to be applying.

Also, in the login screen , The login button is enabled even If the email and password is empty,
Similarly in the signup screen.

@christyjacob4 should be fixed now 👍🏻

@TorstenDittmann  Looks good 👍


upgrade from v1.9 to v1.10

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Release 1.10 is coming, with new documentation for upgrading from v1.9 to v1.10.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

/hold
Waiting for local upgrade verification

Please assign it to me once it's ready for review.

/hold cancel
cc @RainbowMango


Dynamic Tab Name change

Is any way to change the name of tabs.
I have to show array count beside the tab name like this. Apple(8), Banana(7)
These counts come from API.

Hi @ErAshu ,
Did you try invalidateTabs() method of ViewPager ?
Update your array of ViewPagerTab and then call invalidateTabs() of ViewPagerController object.

I didn't get this?


Added Download button to all podcast

Added download button for all podcast in all files
for the issue: #33
https://github.com/user-attachments/assets/b6dcce06-2daf-40d9-8ae5-dc65545ff128

So far so good @IngaleChinmay04 can you just update the download icon.

will this one work?

Yes sure

I was thinking Green instead red


[share_plus] Sharing Image + text does not work anymore with Whatsapp on iOS

since the official plugin is deprecated in favor of this one here my issue there has been closed https://github.com/flutter/flutter/issues/83338
I migrated to share_plus but the bug still remains
here is the minimal code sample from the original issue
// Copyright 2019 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// ignore_for_file: public_member_api_docs

import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';
import 'package:share_plus/share_plus.dart';

import 'image_previews.dart';

void main() {
  runApp(DemoApp());
}

class DemoApp extends StatefulWidget {
  @override
  DemoAppState createState() => DemoAppState();
}

class DemoAppState extends State<DemoApp> {
  String text = '';
  String subject = '';
  List<String> imagePaths = [];

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Share Plugin Demo',
      home: Scaffold(
          appBar: AppBar(
            title: const Text('Share Plugin Demo'),
          ),
          body: SingleChildScrollView(
            child: Padding(
              padding: const EdgeInsets.all(24.0),
              child: Column(
                crossAxisAlignment: CrossAxisAlignment.start,
                children: <Widget>[
                  TextField(
                    decoration: const InputDecoration(
                      labelText: 'Share text:',
                      hintText: 'Enter some text and/or link to share',
                    ),
                    maxLines: 2,
                    onChanged: (String value) => setState(() {
                      text = value;
                    }),
                  ),
                  TextField(
                    decoration: const InputDecoration(
                      labelText: 'Share subject:',
                      hintText: 'Enter subject to share (optional)',
                    ),
                    maxLines: 2,
                    onChanged: (String value) => setState(() {
                      subject = value;
                    }),
                  ),
                  const Padding(padding: EdgeInsets.only(top: 12.0)),
                  ImagePreviews(imagePaths, onDelete: _onDeleteImage),
                  ListTile(
                    leading: Icon(Icons.add),
                    title: Text("Add image"),
                    onTap: () async {
                      final imagePicker = ImagePicker();
                      final pickedFile = await imagePicker.getImage(
                        source: ImageSource.gallery,
                      );
                      if (pickedFile != null) {
                        setState(() {
                          imagePaths.add(pickedFile.path);
                        });
                      }
                    },
                  ),
                  const Padding(padding: EdgeInsets.only(top: 12.0)),
                  Builder(
                    builder: (BuildContext context) {
                      return ElevatedButton(
                        child: const Text('Share'),
                        onPressed: text.isEmpty && imagePaths.isEmpty
                            ? null
                            : () => _onShare(context),
                      );
                    },
                  ),
                  const Padding(padding: EdgeInsets.only(top: 12.0)),
                  Builder(
                    builder: (BuildContext context) {
                      return ElevatedButton(
                        child: const Text('Share With Empty Origin'),
                        onPressed: () => _onShareWithEmptyOrigin(context),
                      );
                    },
                  ),
                ],
              ),
            ),
          )),
    );
  }

  _onDeleteImage(int position) {
    setState(() {
      imagePaths.removeAt(position);
    });
  }

  _onShare(BuildContext context) async {
    // A builder is used to retrieve the context immediately
    // surrounding the ElevatedButton.
    //
    // The context's `findRenderObject` returns the first
    // RenderObject in its descendent tree when it's not
    // a RenderObjectWidget. The ElevatedButton's RenderObject
    // has its position and size after it's built.
    final RenderBox box = context.findRenderObject() as RenderBox;

    if (imagePaths.isNotEmpty) {
      await Share.shareFiles(imagePaths,
          text: text,
          subject: subject,
          sharePositionOrigin: box.localToGlobal(Offset.zero) & box.size);
    } else {
      await Share.share(text,
          subject: subject,
          sharePositionOrigin: box.localToGlobal(Offset.zero) & box.size);
    }
  }

  _onShareWithEmptyOrigin(BuildContext context) async {
    await Share.share("text");
  }
}

and here is the flutter doctor -v from the original issue
[✓] Flutter (Channel stable, 2.2.0, on macOS 11.3.1 20E241 darwin-x64, locale
    en-GB)
    • Flutter version 2.2.0 at /Users/tahatesser/Code/flutter_stable
    • Framework revision b22742018b (11 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.22.0

[✓] Connected device (3 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS
      14.6
    • macOS (desktop)        • macos                     • darwin-x64     •
      macOS 11.3.1 20E241 darwin-x64
    • Chrome (web)           • chrome                    • web-javascript •
      Google Chrome 90.0.4430.212

• No issues found!

Hi is there any solution on Whatsapp not being able to share the image on IOS ?

I haven't looked deep into this but this looks like an issue on WhatsApp side.
Do you have the same issue when text and subject are not provided? e.g. await SharePlatform.instance.shareFiles([path])

Yes the same issue as the above. Is it from whatsapp side that block for ios to return image ? Android works fine sir

@miquelbeltran I am facing the same issue.
Case 1: When you provide shareFiles([path]);  - Image shared
Case 2: When you provide shareFiles([path], text: "Something");  - Only Text is shared.
Case 3: When you provide shareFiles([path], subject: "Something");  - Only Image is shared.

@miquelbeltran I am facing the same issue.
Case 1: When you provide shareFiles([path]); - Image shared
Case 2: When you provide shareFiles([path], text: "Something"); - Only Text is shared.
Case 3: When you provide shareFiles([path], subject: "Something"); - Only Image is shared.

really? that would be great, just need the image. didn't try without text/subject
could be a flutter2 issue, i know that it worked some time ago

I think this may be an issue on WhatsApp side, that they change the code to only use the text if text != null, since sharing text + images still work with other apps.

@miquelbeltran I am facing the same issue.
Case 1: When you provide shareFiles([path]); - Image shared
Case 2: When you provide shareFiles([path], text: "Something"); - Only Text is shared.
Case 3: When you provide shareFiles([path], subject: "Something"); - Only Image is shared.

Yes this is what I get as well

I am more inclined to add a bit of documentation to the shareFiles method saying that some apps can't accept text + files and instead you should only provide files.

Apps affected:

WeChat
Facebook
WhatsApp

Apps not affected:

Mail
Viber
Signal

can confirm that it works when only specifying an image (without text and/or subject).
even though it's a pity that it does not work anymore with text and/or subject, my problem is solved. issue can be closed as far as I'm concerned. thanks everyone

@miquelbeltran text+image also not works for Messages in iOS

@expertdev-designer can you open a new ticket for the Messages app issue?

Okay Sure @miquelbeltran


Use dev=true to get complete language files, with all the keys

Original issue:
In one of our projects, with multiple languages, when more than one language was active and the keys/values differed between the languages, we were getting compile errors after fetching the translations because the Translations.swift was generated for a language that didn't have all the keys.
After talking to CR and JOSO, the fix was to use ?dev=true when fetching the languages. This returns all the keys for all the languages, so the Translations.swift will have all the properties it should.

@mariusc can you make a new release?

Yup


Added parsing of protein sequences, v0.0.5 candidate

Automatic build & test pipeline via github included

Thank you for your contribution and the effort you put into this pull request! As we have discussed, it will be more manageable to split the changes into multiple pull requests, each focused on a specific improvement or feature. In addition, we agreed that it’s better to create a new branch for each pull request that describes its purpose and not to directly merge into the main branch. This helps manage pull requests more efficiently and allows further adjustments and additions before releasing a new version.
I am closing this pull request for now. Please feel free to submit the separated changes as individual pull requests. Thanks again!


NO CARD even if a card is present

I try your sample code a Debian GNU/Linux:
$ deno run --unstable --allow-ffi https://deno.land/x/pcsc/examples/select-mf.ts
Reader Gemalto PC Twin Reader 00 00: NO CARD

To know if a card is present you use:
  get isPresent(): boolean {
    return (this.#state.currentState & StateFlag.Present) != 0;
  }

I used pcsc-spy to log all the PC/SC calls. I get:
SCardEstablishContext
 i dwScope: SCARD_SCOPE_SYSTEM (0x00000002)
 o hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.001505]
SCardIsValidContext
 i hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000073]
SCardListReaders
 i hContext: 0x3D4C873E
 i mszGroups: (null)
 o pcchReaders: 0x0000001E
 o mszReaders: NULL
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000161]
SCardListReaders
 i hContext: 0x3D4C873E
 i mszGroups: (null)
 o pcchReaders: 0x0000001E
 o mszReaders: Gemalto PC Twin Reader 00 00
 o mszReaders:
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000277]
SCardIsValidContext
 i hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000065]
SCardGetStatusChange
 i hContext: 0x3D4C873E
 i dwTimeout: 0x00000000 (0)
 i cReaders: 1
 i szReader: Gemalto PC Twin Reader 00 00
 i  dwCurrentState:  (0x00000000)
 i  dwEventState:  (0x24000000)
 i  Atr length: 0x00000000 (0)
 i  Atr:
 o szReader: Gemalto PC Twin Reader 00 00
 o  dwCurrentState:  (0x00000000)
 o  dwEventState: SCARD_STATE_CHANGED, SCARD_STATE_PRESENT (0x00000022)
 o  Atr length: 0x00000014 (20)
 o  Atr: 3B FA 94 00 00 81 31 20 43 80 65 A2 01 01 01 3D 72 D6 43 21
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000383]
SCardIsValidContext
 i hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000068]
SCardCancel
 i hCard: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000042]
SCardIsValidContext
 i hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000043]
SCardReleaseContext
 i hContext: 0x3D4C873E
 => Command successful. (SCARD_S_SUCCESS [0x00000000])  [0.000123]

Thread 1/1
Results sorted by total execution time
total time: 0.007725 sec
0.001505 sec (  1 calls) 19.48% SCardEstablishContext
0.000438 sec (  2 calls)  5.67% SCardListReaders
0.000383 sec (  1 calls)  4.96% SCardGetStatusChange
0.000249 sec (  4 calls)  3.22% SCardIsValidContext
0.000123 sec (  1 calls)  1.59% SCardReleaseContext
0.000042 sec (  1 calls)  0.54% SCardCancel

Note that you call correctly SCardGetStatusChange() but only the field dwEventState is updated. The field dwCurrentState is NOT modified and is still 0 (SCARD_STATE_UNAWARE). So the bit SCARD_STATE_PRESENT is not set.
As documented in SCardGetStatusChange:

The new event state will be contained in dwEventState.

I modified isPresent to use:
  get isPresent(): boolean {
    console.log(`state ${this.#state.eventState}`);
    return (this.#state.eventState & StateFlag.Present) != 0;
  }

But eventState is also 0 and not 0x00000022 as seen in the PC/SC traces i.e. no flag set.

I also note that in, my case, the method #updateState() is NOT called in the constructor at https://github.com/cryptographix/pcsc-deno/blob/master/deno-pcsc-ffi/reader.ts#L82
The eventState is 0 in handleChange() https://github.com/cryptographix/pcsc-deno/blob/master/pcsc/reader-state.ts#L50
On Debian if I run this code:
	printf("SCARD_READERSTATE: 0x%lX\n", sizeof(SCARD_READERSTATE));
	printf("szReader: 0x%lX\n", offsetof(SCARD_READERSTATE, szReader));
	printf("pvUserData: 0x%lX\n", offsetof(SCARD_READERSTATE, pvUserData));
	printf("dwCurrentState: 0x%lX\n", offsetof(SCARD_READERSTATE, dwCurrentState));
	printf("dwEventState: 0x%lX\n", offsetof(SCARD_READERSTATE, dwEventState));
	printf("cbAtr: 0x%lX\n", offsetof(SCARD_READERSTATE, cbAtr));
	printf("rgbAtr: 0x%lX\n", offsetof(SCARD_READERSTATE, rgbAtr));

I get:
SCARD_READERSTATE: 0x50
szReader: 0x0
pvUserData: 0x8
dwCurrentState: 0x10
dwEventState: 0x18
cbAtr: 0x20
rgbAtr: 0x28

In the code you use https://github.com/cryptographix/pcsc-deno/blob/master/pcsc/reader-state.ts#L10
 * SCARDREADER_STATE, 64bits
 *
 * [ 00 .. 07 ]   Pointer to READER_NAME
 * [ 08 .. 0F ]   Pointer to UserData
 * [ 10 .. 13 ]   Current State
 * [ 14 .. 17 ]   Actual State
 * [ 18 .. 1B ]   ATR (size)
 * [ 1C .. 3F ]   ATR[36]

This is NOT correct on pcsc-lite.
The SCARD_READERSTATE structure uses
typedef struct
{
	const char *szReader;
	void *pvUserData;
	DWORD dwCurrentState;
	DWORD dwEventState;
	DWORD cbAtr;
	unsigned char rgbAtr[MAX_ATR_SIZE];
}
SCARD_READERSTATE, *LPSCARD_READERSTATE;

and on pcsc-lite DWORD is unsigned long so 64-bits and not 32-bits as on Windows and macOS.
https://github.com/LudovicRousseau/PCSC/blob/master/src/PCSC/wintypes.h#L90
The patch (for pcsc-lite only) is then easy:
diff --git a/pcsc/reader-state.ts b/pcsc/reader-state.ts
index 3eaa7c2..e9f8d06 100644
--- a/pcsc/reader-state.ts
+++ b/pcsc/reader-state.ts
@@ -2,7 +2,7 @@ import { StateFlag, StateFlags } from './pcsc.ts';

 export const isWin = (typeof Deno != "undefined") ? Deno.build.os == "windows" : false;

-export const DWORD_SIZE = 4;
+export const DWORD_SIZE = 8;
 export const POINTER_SIZE = 8; // 64 bits only

 export const SCARD_ATR_SIZE = (isWin ? 33 : 36);

Hello
Any progress on this issue?
I guess you will have to use an equivalent of:
#ifdef __LINUX__
export const DWORD_SIZE = sizeof(long);
#else
export const DWORD_SIZE = sizeof(int);
#endif

Thanks. I'll check it out.

Works for me now.


Split fine directional prediction search causes visible desyncs in some clips

Still researching the cause, and will update this issue as I figure it out.
Commit: https://github.com/xiph/rav1e/commit/01052fc7121114904501f81f52a234c96373829d
Sample: https://drive.google.com/file/d/1UrXkq8pDKBFhq8wojWd7W_VOBOIY-pb2/view?usp=sharing (3840x2160)
Command lines and output:
$ cargo run --bin rav1e --release -- surfing_50f.y4m -s 10 -r surfing_50f_rec.y4m -o surfing_50f.ivf
$ dav1d -i surfing_50f.ivf -o surfing_50f_dec.y4m
$ cmp <(tail -n+2 surfing_50f_dec.y4m) <(tail -n+2 surfing_50f_rec.y4m)
/dev/fd/63 /dev/fd/62 differ: byte 318238388, line 19122

Blocky artifacts pop in and out in the decoded output, so this affects image quality significantly. Definitely should block any release, assuming it is not also present in past ones. Visible artifacts appear concentrated in the top-right corner of the visible part of the frame in this sample.
Occurs in both constant quantizer and single-pass bitrate target mode. Could reproduce down to speed 7, with very visible artifacts at levels 9 and 10.

Bisect points to 5d7599c9bbdcbd1ff44d100d806003bd7021544d.

Hey- if possible, could you revert the suspected commit 5d7599c9bbdcbd1ff44d100d806003bd7021544d and test please? That way, we can confirm that the bisected commit is the sole cause.

@ycho As expected, reverting fixes the desync.

@ycho As expected, reverting fixes the desync.

Oh, indeed. Thanks a lot for testing this again!

@barrbrain , Hey- I think this issue is wanting your help! :)

Forgot to mention in writing, the issue is present in v0.3.2. In the future I recommend avoiding merging non-bugfixes for patch releases.

We found that enabling CDEF while disabling loop restoration (done at speed level 10) is another cause. It's likely that there is a bug at that level that was exposed by the RDO commit.

Please test with applying https://github.com/xiph/rav1e/pull/2488 , since this can be possible culprit as @barrbrain stated.

It seems the test input, https://0x0.st/ivbO.zip, does not have real .y4m file?
Download and unzipped it, then I have: 'ivbO.zip.cpgz', 441 bytes?

This is possibly related to #2453, which is a desync case at speeds 9 & 10. These are the only presets for which enable_inter_tx_split is set.

That desync is reproducible on all speed levels >=7 at least, so I guess not.

Download and unzipped it, then I have: 'ivbO.zip.cpgz', 441 bytes?
For some reason the file host deleted it.

Please test with applying #2488 , since this can be possible culprit as @barrbrain stated.
Another fact I expect is that, our rdo-based mode decision does not include skip case for intra mode, but we skip enforcing feature (
https://github.com/xiph/rav1e/blob/fe61a877488da642ae8c0844d31ff62f8b2ba66e/src/encoder.rs#L2314
, 3bf1c46), which partially achieves skipped intra mode block. And this converted-to-skip intra block can happen in a inter frame, which again possibly can update wrong tx size context as I reported in #2488.
In addition, the merged commit, c41325d, can be related as well. Since this commit fix to correctly update tx_size context for such case, i.e. 'converted-to-skip intra block'.
So, testing with rebasing upto c41325d, (which does not include open-partition yet) and cherry-pick 8394849 is recommended.

FYI: Both two commits I've recommended to test with has been merged, so if you'd like just rebase on current master head will include all new fixes from my side.

Unfortunately the desync is still present on master.

Unfortunately the desync is still present on master.

Alas... but thanks a lot for trying this promptly! I wanted to help.

./target/release/rav1e ~/Downloads/surfing.y4m  -o test.ivf -r test_rec.y4m --speed=10 --limit=50

Encoding settings: keyint_min=12 keyint_max=240 quantizer=100 bitrate=0 min_quantizer=0 low_latency=false tune=Psychovisual rdo_lookahead_frames=40 min_block_size=32x32 max_block_size=32x32 multiref=true fast_deblock=true reduced_tx_set=true tx_domain_distortion=false tx_domain_rate=false encode_bottomup=false rdo_tx_decision=false prediction_modes=Simple include_near_mvs=false no_scene_detection=false cdef=true use_satd_subpel=false non_square_partition=false enable_timing_info=false fine_directional_intra=true
CPU Feature Level: AVX2
Using 1 tile
encoded 50/50 frames, 0.244 fps, 29831.88 Kb/s, est. size: 7.11 MB, est. time: 0s,  elap. time: 3m 24s
Key frame:             1 | avg QP:  79.00 | avg size:     140 B
Inter frame:          49 | avg QP: 134.00 | avg size:  152200 B
Intra only frame:      0 | avg QP:   0.00 | avg size:       0 B
Switching frame:       0 | avg QP:   0.00 | avg size:       0 B

There is 1st difference at frame 15 (starting from 1) and more at following frames.

With hard coded disabling fine_directional_intra_preset(), i.e. return false, the desync is persistent.
./target/release/rav1e ~/Downloads/surfing.y4m  -o test.ivf -r test_rec.y4m --speed=10 --low_latency --rdo-lookahead-frames=1
So, as rzumer just changed the title of this issuem fine dir intra pred does not seem the cause of desync.


Implementation complete for trackEvent

Moved contents from dashx-react-native/ios to here
Address pod lint warnings and errors
Added MIT license
Standardized gitignore

Closing the PR in favor of a new one containing only the new changes to the main branch.


DDT-981: Add consignment item to the SQL

Signed-off-by: Niels Thykier<EMAIL_ADDRESS>

Replaced by #249


Use upstream nixpkgs

The iohk fork of nixpkgs often causes us pain however it will be essential to use when it comes to integrating plutus and cardano. We would like to work with the tooling team I think to get to a situation where we can use external libraries + upstream nixpkgs rather than an IOHK fork of nixpkgs.

We did this!


iOS crash when ping interval is defined

I was not able to get this plugin working on iOS (havn't tried android). It crashes when I defined pingInterval. If I leave it the success callback fires, but I don't receive any events.
var accessToken = "abcdefghiklmnopqrstuvwxyz";
var wsOptions = {
    url: "wss://echo.websocket.org",
    timeout: 5000,
    pingInterval: 10000,
    headers: {"Authorization": "Bearer " + accessToken},
    acceptAllCerts: false
}

CordovaWebsocketPlugin.wsConnect(wsOptions,
                function(recvEvent) {
                    console.log("Received callback from WebSocket: "+recvEvent["callbackMethod"]);
                },
                function(success) {
                    console.log("Connected to WebSocket with id: " + success.webSocketId);
                },
                function(error) {
                    console.log("Failed to connect to WebSocket: "+
                                "code: "+error["code"]+
                                ", reason: "+error["reason"]+
                                ", exception: "+error["exception"]);
                }
            );

Device console reports:
+[NSTimer scheduledTimerWithTimeInterval:repeats:block:]: unrecognized selector sent to class 0x379d8ed4

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[NSTimer scheduledTimerWithTimeInterval:repeats:block:]: unrecognized selector sent to class 0x379d8ed4'
	*** First throw call stack:
	(0x2104791b 0x207e2e17 0x2104d1d1 0x2104aee1 0x20f76238 0x114cff 0x118175 0x20bb5823 0x20bb580f 0x20bc3ba9 0x21009b6d 0x21008067 0x20f57229 0x20f57015 0x22547ac9 0x2562b189 0x71ef3 0x20bff873)

This is the problem: https://stackoverflow.com/questions/40521799/trivial-nstimer-scheduledtimerwithtimeintervalrepeatsblock-unrecognized
Your plugin is only compatible on iOS10 or greater

@boedy thanks for the report. I will try to fix it next week.


Tag Input component

I wrote a component to do input for tags, similar to this jquery one http://xoxco.com/projects/code/tagsinput/example.html it relies on your typeahead component, it would just require some work to bubble up properties from the typeahead to be inputs to the component. After I'm finished would you be interested in a pull request to merge it into this project? Even though it's not strictly bootstrap it is a nice ng2 component that uses bootstrap.

like this? https://github.com/valor-software/ng2-select

Yeah pretty much, except the code I wrote made use of the ng2-bootstrap typeahead to be able to query a web service for results. It looked like that ng2-select only worked with a static list of components. Also I made use of bootstrap button styling to differentiate values from the autocomplete or manually typed ones.


ocaml-menhir: update from 20130116 to 20140422

Builds fine locally. I don’t know how to read travis log.


org.owasp.dependencycheck.exception.NoDataException: Autoupdate is disabled and the database does not exist

I configure dependency-check on Jenkins，My server has no network permissions, set isAutoupdateDisabled: true，dependencyCheckAnalyzer datadir: '/app/jenkins/dependency-check/nvdcve-2.0-2018.xml.gz'
dependencyCheckAnalyzer datadir: '/app/jenkins/dependency-check/nvdcve-2.0-2018.xml.gz',
isAutoupdateDisabled: true,
hintsFile: '',
includeCsvReports: false,
includeHtmlReports: false,
includeJsonReports: false,
outdir: '',
scanpath: '/app/jenkins/jenkinsworkspace/guanwang/guanwang/ec-web/WEB-INF/lib/*.jar',
skipOnScmChange: false,
skipOnUpstreamChange: false,
suppressionFile: '',
includeVulnReports: true,
zipExtensions: ''
But the following error occurred：

Please see Internet Access Required.

I have the same problem, and the previous configuration was successful, and suddenly reported this error, who can answer what is the cause?

Please see the documentation regarding this type of setup: https://jeremylong.github.io/DependencyCheck/data/index.html


Font color on disabled buttons should take the button background color into account

Background on disabled buttons was recently fixed in #9022, but the font color on disabled buttons doesn't take the background color into account. If one has a lighter secondary color, the text on the button is almost invisible. Shouldn't the color on the disabled button be determined by some sort of contrast control? Maybe we can usesmart-color() with some darkening magic?
Test case:
http://codepen.io/anon/pen/ZpNVpK

Just wondering why you used version 6.2.1 of Foundation in your codepen and not the latest version 6.2.4?

Just wondering why you used version 6.2.1 of Foundation in your codepen and not the latest version 6.2.4?

Good question! I just forked the already defined Codepen draft that was in the issue placeholder text. Did not think to look for the version there. Sorry for that! I have updated the Codepen example in the main issue with the latest Foundation now.

@rafibomb can you take a look at the predefined codepens and update the versions of Foundation in them?

So address this (better later than never), I created an updated pen.
However, please note that setting background via CSS is not part of Foundation's responsibilites as we can only work with values inside SCSS.
What is indeed one of the frameworks responsibilities is to ensure readable and thus accessible default values. What's also in scope is a proper warning if background- and font-color have not enough contrast to meet certain requirements (whether it is AA or AAA).
As WCAG states, inactive elements have no contrast requirement, but I for myself am struggling with the low contrast on my own in some cases...
As a fix, it might be good to increase the opacity for disabled buttons to 0.5 instead of the current 0.25.
Ping @ncoden @JeremyEnglert @colin-marshall

I agree with @Owlbertz. We can only control the design and accessibility of the components we generated ourselves. If a component design is changed in CSS, we can only expect the developer to also take care of the hover/active/disabled states design and accessibility by himself.
About the text color of a disabled button, I would like to add 2 things:

Having the text color of a disabled button more difficult to read is intended. This is a common way to explicitely indicate that there is no possible interactivity.
If the text color of a disabled button is not readable by an healthy person, there is high chances for disabled people to not being able to read the non-disabled button. So you should not choose these background/text colors in the first place.

We may incread the disabled button opacity to 0.33 (I find that 0.5 is way too high), but I personally don't think this is really necessary.

Maybe we should move away from the opacity solution in general, as this has side effects with the background color. Imo we could easily mimic the current design using SASS functions (is there a way to reduce saturation or do similar color manipulation while keeping the initial base color?) and avoid opacity to indicate the disabled state.

as this has side effects with the background color

Yes, and it's what I expect. To be less visible, so darker on a dark background and lighter on a light background.

Ok, but disabled !== less visible.

Yes, but this is according to me the best way to indicate "no interactivity".

Ok, maybe we can get some more opinions involved.

I am no accessibility expert, so take what I say with a grain of a salt.
I personally think the combination of a 0.5 opacity with cursor: not-allowed gets the point across. I do see how it is kind of difficult to read due to contrast issues. What if we made it so that on hover, the disabled buttons go to a higher opacity? You still have the not-allowed cursor to let you know it's disabled. Or does having the color change on hover go against it being an element with no interactivity?

Or does having the color change on hover go against it being an element with no interactivity?

I think it does yes.

Ok, maybe we can get some more opinions involved.

@SassNinja what do you think?
darken / lighten / combine may make sense here.
In our own projects we use the color function of Sass.

We can't control colors once a user starts making changes. That's up to them.
However, we have a lot of colors that are problematic in the default color palette. I'll work on this and the disabled buttons this weekend.

@JeremyEnglert any updates on your side?


Add support for RSpec to previews as test cases

What are you trying to accomplish?
I've noticed that the (Experimental) Previews as test cases don't support RSpec yet, because of how it builds the class name in which it expects the preview:
https://github.com/github/view_component/blob/1a2e39d044f2be8c4dd18fe14d4aa5a3812b79f0/lib/view_component/render_preview_helper.rb#L13-L16
What approach did you choose and why?
This PR adds support for RSpec by checking self.respond_to?(:described_class) and if so, using "#{self.described_class}Preview" as the preview class name.
Anything you want to highlight for special attention from reviewers?

I haven't added a note about this to the docs. Not sure if that is needed in this case, because if you follow the naming conventions, it will just work.
I haven't touched any tests. Not sure how RSpec compatibility is handled in the project.
I haven't added myself to the docs/index.md as I hope #1383 gets merged before this one (or eventually).

IMO we should add example rspec tests to the example app. Would you mind doing so in this PR?

Good idea, I'll do that 👍🏼

Excuse the 👊🏼 -pushing but I've added the rspec-rails gem and made it so that appraisal rake spec runs all rspec tests.
For now there is only one rspec file covering the fix in this PR. I've added :nocov: comments around the code that is covered with RSpec.
@joelhawksley Should I go ahead and enable this also on CI by running rake test spec instead of rake in the test job?

For now there is only one rspec file covering the fix in this PR. I've added :nocov: comments around the code that is covered with RSpec.

@thutterer yes, let's enable this on CI and remove the :nocov:. Simplecov should collate all of the builds to include the Rspec coverage.

@joelhawksley

let's enable this on CI and remove the :nocov:. Simplecov should collate all of the builds to include the Rspec coverage.

Done, test coverage back to 100% 💚 I had to move the rspec-rails gem into the top-level Gemfile for rake spec to work without appraisal.

Fantastic! Thanks so much for adding this support ❤


HBASE-23858 Set version as 2.1.10-SNAPSHOT in branch-2.1

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.1 Compile Tests _

+0 :ok:
mvndep
1m  1s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 10s
branch-2.1 passed

+1 :green_heart:
compile
3m  0s
branch-2.1 passed

+1 :green_heart:
checkstyle
2m 56s
branch-2.1 passed

+1 :green_heart:
shadedjars
4m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
11m 56s
branch-2.1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  4s
branch-2.1 passed

+0 :ok:
mvndep
5m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  7s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

+1 :green_heart:
checkstyle
2m 56s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 51s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedjars
4m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
21m 37s
Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.

+1 :green_heart:
javadoc
12m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
211m 41s
root in the patch passed.

+1 :green_heart:
asflicense
18m 18s
The patch does not generate ASF License warnings.

325m 31s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1178/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1178

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile checkstyle

uname
Linux 8227ef44b170 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1178/out/precommit/personality/provided.sh

git revision
branch-2.1 / c540d906df

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1178/1/testReport/

Max. process+thread count
4834 (vs. ulimit of 10000)

modules
C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-protocol-shaded hbase-common hbase-metrics-api hbase-hadoop-compat hbase-metrics hbase-hadoop2-compat hbase-protocol hbase-client hbase-zookeeper hbase-replication hbase-resource-bundle hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-rsgroup hbase-shell hbase-endpoint hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-hbtop hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-testing-util-tester hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1178/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Password length is locked between [6, 32]. Avatar URL length is chopped off after 64 characters.

router.post("/signup", [
    check('username').trim().isLength({ min: 3, max: 32 }),
    check('password').isLength({ min: 6, max: 32 }),
    check('color').isHexColor()
]

This is especially strange, because required password length is said to be at least 8 characters, with no maximum.
        const user = new User({
            username: username,
            password: password,
            color: color.slice(0, 6),
            avatarURL: avatarURL.slice(0, 64)
        });

This could chop up a valid url.

well the reason i limited password and avatarURL is because i dont want my db to fill (at least not yet). and you can use a url shortner for the avatarURL.

True, but these limits are not stated anywhere. Also, the avatar URL one doesn't even fail - it just uses a chopped off URL. For passwords, I would recommend a limit of at least 128 characters. 32 characters of valid UTF-8 only allows 224 bits (28 bytes) of entropy, which may be insufficient.

oh yeah i forcing it xd
will let the users know about it when they are signing up and updating their profiles


Document lacking support for symbolic links

File::Find support symbolic links, but it comes at a price, so it is not supported by yak for now.

Done


The property "environment.docker.base_dockerfile" is not passed through correctly in pipeline jobs

There seem to be a bug on the AML Pipeline side if a custom dockerfile is used. The runconfig property environment.docker.base_dockerfile is not being passed through correctly in pipeline jobs (for PythonScriptStep).
Is there any workaround, excluding building the docker image and specifying it with environment.docker.base_image?
This is the code snippet:
myenv.docker.enabled = True
with open("./ml_service/pipelines/build_env/DockerFile", "r") as f:
        dockerfile_contents_of_base_image=f.read()
myenv.docker.base_dockerfile=dockerfile_contents_of_base_image

run_config = RunConfiguration()
run_config.environment = myenv

train_step = PythonScriptStep(
        name="Test",
        script_name=e.train_script_path,
        compute_target=aml_compute,
        source_directory=e.sources_directory_train,
        runconfig=run_config,
        inputs=[model_path],
        arguments=[…],
        allow_reuse=False
    )

I tried adding myenv.docker.base_image = None, but it didn't help.

@LianaN based on the above-shared code snippet it looks perfect. However, I don't see the content of your docker file, if you can please share the docker file and error logs for further troubleshooting?
Also, how do you verify that the submitted image being used ? do you see a new image create in the ACR instance attached to your Azure Machine Learning workspace?

Related Open Issue


feat(11): add props for displaying edit button and refactor project with react hooks

Description

Add showEditButton, editButtonContent, and editButtonProps for displaying and customising edit button
Refactor project with React hooks and functional components
Update all unit tests

Fixes #11
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have updated the documentation accordingly where applicable.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


backend setup

I have finished the setup of the rails api app.

I ensured there were no linter errors
I ensured gitflow was followed judiciously.

@summyalena
Kindly remove the logo from the ReadMe of your frontend!
Cheers!


fix: maintaining context in UI Editor first changes

Description
This PR's changes helps in maintaining UI Editor's context while switching from one page to other.
Fixes #11009

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: maintainEditorContext

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.71 (0)
38.65 (-0.02)
36.26 (0.04)
56.96 (0)

:sparkles: :new:
app/client/src/actions/contextActions.ts
83.33
100
50
76.92

:red_circle:
app/client/src/components/editorComponents/PropertyPaneSidebar.tsx
96.77 (0.41)
82.35 (-4.32)
100 (0)
96.77 (0.41)

:green_circle:
app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx
65.79 (0.44)
55.77 (-0.33)
39.02 (0.13)
66.67 (0.9)

:red_circle:
app/client/src/components/editorComponents/CodeEditor/index.tsx
76.8 (-0.17)
59.36 (0.95)
62.5 (-2.72)
78.07 (-0.39)

:green_circle:
app/client/src/pages/Editor/utils.ts
26.19 (0.59)
16.85 (0)
39.13 (0)
24.35 (0.67)

:red_circle:
app/client/src/pages/Editor/PropertyPane/PropertyControl.tsx
54.14 (0.4)
32.08 (-2.61)
22.22 (-2.78)
55.03 (0.35)

:red_circle:
app/client/src/pages/Editor/PropertyPane/PropertyPaneView.tsx
75.86 (-13.88)
42.86 (-26.71)
62.5 (2.5)
78.18 (-16.41)

:red_circle:
app/client/src/pages/Editor/WidgetsEditor/index.tsx
91.94 (-1.61)
60 (0)
100 (0)
91.53 (-1.69)

:sparkles: :new:
app/client/src/reducers/uiReducers/contextReducer.ts
27.66
27.27
25
31.43

:green_circle:
app/client/src/sagas/OnboardingSagas.ts
22.15 (0.53)
1.28 (0)
4.35 (0)
25.19 (0.57)

:red_circle:
app/client/src/sagas/PageSagas.tsx
23.28 (-0.86)
4.13 (-1.13)
13.51 (-0.78)
25 (-0.67)

:sparkles: :new:
app/client/src/selectors/contextSelectors.tsx
82.35
46
88.89
80

:red_circle:
app/client/src/utils/WidgetPropsUtils.tsx
87.88 (-0.78)
76 (0)
80 (-5.71)
84.42 (-0.91)

Closed in favour of https://github.com/appsmithorg/appsmith/issues/17975


Upgrade to webpack 2

General comment:
I upgraded us to webpack 3 without any more changes requiured, so you should be able to go straight to webpack 3 in this PR:
https://medium.com/webpack/webpack-3-official-release-15fd2dd8f07b

@pocketjoso
Tx a lot for this review,
I upgraded to webpack 3.3.0, and it seems to work indeed :).


Unify g49a and g4a1

I just had a closer look at devices/stm32g491.yaml and  devices/stm32g4a1.yaml they seem to have diverged quite a bit. However looking in the RM they are even in the same column under available peripherals so should be pretty much identical, I think, with AES being the only difference.
Also adds TIM20 to both devices

I have just taken the config from G491 (except the first line with the svd file) and put into G4A1. Since from what I can tell G491 is the one which has gotten most attention.


feat: enable code splitting

Remove the code splitting override from plugin.ts.

@sportshead This package is already at 0.3.2. You may have missed merging upstream commits. Please do so first, and avoid bumping the version number so I can bump (and publish) locally.


Roadmap to 1.0 beta

Back end:

[x] set up the server
[x] create the main page
[x] fix the Fateful encounter flag
[x] change format of response so that pk6 comes up as a download instead of a string

Front end:

[x] make the box settings come up in a modal
[x] Pokémon settings (#205)
[x] display Pokémon notes (dependent on #205)
[x] moving Pokémon around a box (#20)
[ ] account settings (#13)
[x] user page
[x] add download link for public Pokémon
[x] populate the main page (#160, #282)
[x] provide feedback to user when a pk6 is uploaded
[x] provide additional feedback (failed upload, invalid pk6, upload to other box) (#283)
[x] multiple file uploads / drag and drop (#132)
[x] add a token description for Box 1 (#196)
[x] update on-site docs
[x] finish footer

Other:

[x] pk6parse: region names
[x] pk6parse: memories
[x] pk6parse: move power
[x] add CONTRIBUTING.md

On top of everything listed in the 1.0 beta milestone.

Account settings won't be done for 1.0 beta.


Fixes bug in wasm-builder with cargo publish

There was a bug in wasm-builder which resulted in generating a
Cargo.lock in the project directory because of running cargo metadata. This resulted in commands like cargo publish to fail (if
there was no Cargo.lock before building), because it checks that the
project directory isn't modified.
Fixes: https://github.com/paritytech/substrate/issues/7116

New version needs to be published and should be good to merge afterwards.


[SPARK-34140][SQL][3.1] Move QueryCompilationErrors.scala to org/apache/spark/sql/errors

A backport for #31211 to branch 3.1
What changes were proposed in this pull request?

QueryCompilationErrors.scala uses the org.apache.spark.sql.errors package, but this file resides in the org/apache/spark/sql directory. This PR proposes to move this file to org/apache/spark/sql/errors.
Why are the changes needed?

To match the package name with the directory structure.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests

Thanks!

Thanks!

Test build #134152 has started for PR 31212 at commit 3a4bd3c.

Test build #134152 has started for PR 31212 at commit 3a4bd3c.

Merged to branch-3.1 for Apache Spark 3.1.1.
cc @HyukjinKwon

Merged to branch-3.1 for Apache Spark 3.1.1.
cc @HyukjinKwon

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38734/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38734/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38734/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38734/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38734/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38734/

Test build #134152 has finished for PR 31212 at commit 3a4bd3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134152 has finished for PR 31212 at commit 3a4bd3c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134152/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134152/


WP: Cache failures in cache

Still a lot of pending tasks:

Check / Add test
Update models / signals
Update command line tasks
Manually tests

Tests are failing

Yes, as I said there are some pending task, I will work on this soon

Hey Guys,
I have worked a little bit again, tests are working now and also I have covered python3. I guess what I should do now is:

To add new test for caching.
To add caching workflow in management commands / signals / models.

Coverage decreased (-0.3%) to 88.235% when pulling 19affea1babfcf4d76e943ffa681e9e8c7d2fa4d on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Coverage decreased (-0.6%) to 87.994% when pulling 2357a4616bd7e200f2d262d144f29dddddae7da5 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Ok, I have finished my pending tasks, let me know your thoughts.

Coverage increased (+0.2%) to 88.777% when pulling 5b791f65f40d6a08c2304f4d1f6dc3f3eee9d896 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Coverage increased (+0.3%) to 88.873% when pulling f277007e46b7c6d8c978011d7356b7527ba91133 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Coverage increased (+0.3%) to 88.873% when pulling f277007e46b7c6d8c978011d7356b7527ba91133 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Coverage increased (+0.5%) to 89.076% when pulling de9fe09f5c37e484e0a782282a4658e108350a50 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Coverage increased (+0.5%) to 89.076% when pulling de9fe09f5c37e484e0a782282a4658e108350a50 on jorlugaqui:cache-attemps into 634c542dad93faf888008330409302c0b8005da0 on jazzband:master.

Looks good to me.
@aclark4life What do you think?

@camilonova I'm of the "merge now ask questions later" school :-D That said, looks like just some signals added? Probably fine …


If there is a gap of more than five minutes in Timesheet then that should be displayed.

Describe the Feature
If the gap between two timesheet is more than 5 minutes then that should be highlighted to facilitate the user.

in FUTURE


Parse og:image:url meta property

You can specify attributes for the og:image property and in some cases no image would be returned.
<meta property="og:image:url" content="http://...">
<meta property="og:image:width" content="1200">
<meta property="og:image:height" content="630">
<meta property="og:image:type" content="image/jpeg">

@ageitgey Hope you can review this soon, really need the fix. Thank you!

Thanks!


"isDoorbellEnabled": true, Not exposing doorbell

Hi.
Today I added "isDoorbellEnabled": true, to the configuration, sadly the opener does not show up in the doorbell configuration of homekit. The opener was already used in homekit before I added this line.
Thanks
Steve

Today i installed this Plugin and i have the same problem/question. The opener appears in HomeKit and i can set ring to open and continuous mode. In Homebridge the "doorbell" is listed, but not in HomeKit.
Any ideas? Homebridge, the Plugin, iOS... all are up-to-date.

You could use the myHome or Eve app where the doorbell is visible as a Button and set up a dummy switch to integrate it in Home.

You could use the myHome or Eve app where the doorbell is visible as a Button and set up a dummy switch to integrate it in Home.

Nope... the Eve app doesn't show the doorbell in any room. Only Homebridge UI list the doorbell as device.

In the HomeKit section for Camera and Doorbell is only my Cam from the living room listet (the doorbell should appear there).

The doorbell is exposed in the sub menu of your opener in the Eve app.

OK, found it :) thx
But how can i integrate it, so that's listet as doorbell in HomeKit and the HomePods play a chime sound?

Just set up a dummy switch, tell your doorbell switch to control that dummy in Eve, and control everything else in homekit with that dummy switch.
For the chime sound just enable notifications for the door in homekit settings.

Just set up a dummy switch, tell your doorbell switch to control that dummy in Eve, and control everything else in homekit with that dummy switch.
For the chime sound just enable notifications for the door in homekit settings.
I'm probably missing some steps here. Downloaded the Eve app, see the doorbell, added a dummy switch accessory to Homebridge. Maybe this is too advanced for me, but I'm not seeing how to put this all together. Is this the way this plugin is supposed to work, or is it supposed to show up in Homekit with just the Nuki plugin?

This plugin should expose every component you defined as true to homekit, but your doorbell will only show up in "Doors & Locks" in the settings.
For your Eve rule: did you activate it? If yes, try something else as a trigger just to see if the rule itself works.

Thanks for replying. Yes, I checked that it's enabled. And I tried a smart light in addition to the dummy switch to see if it triggers. Attached the image to show my setup but maybe I'm doing something obviously wrong?

If the issue still persists, feel free to re-open, closing for now.


Violates Heroku ToS?

Not sure.
It seems this specific repository was flagged as I was able to deploy from a random up to date fork.
You can do the same by replacing GITHUB_URL with a link to a fork below.
https://heroku.com/deploy?template=GITHUB_URL
I'll see what I can do.

I have created a clone of this repo which will automatically sync the auto branch (current default branch).
The button will deploy from the clone.
This will be my solution unless the clone is also blocked.


[Monitor] Add functional tests

Adds a basic set of functional-tests, which are end to end tests run with a mocked monitor ingestion service

Scenario is a test app + envelope structure expectation (including parent/child expectations)
Test runner runs all scenarios and asserts all envelope expectations

Future integration-tests will be the functional tests run with an actual monitor ingestion service

/azp run js - monitor - tests


feat(scripts): add global typescript support

This PR adds global Typescript support to the included images script
Closes #567

Yes that is correct AFAIK


How to add vhost domain aliases using config script

Hi,
Can you modify the setup script so it will also read a vhost file ext to the vmailbox and virtual files?
I'd like to be able to use this docker images for multiple domains without losing the config every time I restart the container.
Thnx in advance.

Hi @techgourmet, "setup script" is setup.sh?
You can provide a user account list and a virtuals list. They are used on startup to configure the container, they're not lost.
https://github.com/tomav/docker-mailserver/wiki/Configure-Accounts
https://github.com/tomav/docker-mailserver/wiki/Configure-Aliases

I'd like to add a similar for domains the mailserver will respond to.
a Config-Vhosts via a file in the configuration directory.

+1

Nevermind, this is working now using the postfix-virtual.cf and the postfix-accounts.cf
Didn't expect that but it's working well :)

Great!


image/config: Replace '%s' with %q

As I suggested earlier.  Fewer characters for us, and safer quoting for consumers.

lgtm


Fixes #566

getAvailableLanguageKeys() reuses internal table management logic, in order to avoid user mistakes and redundancies.

I'm closing this now. In case of being urgent again, we should re-discuss this again.

@knalli @PascalPrecht May I take it that with return $availableLanguageKeys; I could use (apart from feeling really dirty with calling register as a getter) registerAvailableLanguageKeys() to get the registered languages?


toThrow() is not implemented in test-runner.

I just checked the test runners, matchers.js and it seems like it hasnt been implemented. It def is needed to test for thrown exceptions.

Happy to accept a PR 👍
In the meantime you can do something like
try {
  something()
  expect(false).toBe(true)
} catch (err) {
  expect(true).toBe(true)
}

Yup, thats exactly what i did! Ill try and work something out later.


Autoloading and Rails

We are getting a NameError: uninitialized constant Runtime exception from jmespath at random intervals from threaded calls. The app is rails 4.2 with puma running with 2 clustered mode workers with 16 threads.  This generally does not make sense because the constant is defined. After much research, it seems that this is probably an issue with the use of autoload. In fact I have successfully resolved this issue in a few other GEMS by either using straight require or plugging into rails autoloading.
https://bugs.ruby-lang.org/issues/921 confirms that for 1.9.3 and older, autoload is not thread safe while 2.x is. Further @headius seems to indicate that autoload is only thread safe is the same autoload mechanism is used across the board. headius/thread_safe#15 (comment). So here is where I believe that issue to be: Rails uses it's own autoloading systems, while this gem uses another. There is some race condition that is causing the Runtime class to only be partially loaded when it is called.
To address this issue we could take one of a couple of approaches
Dump autoloading and use require. This would make the gem slower to load, but this should be trivial since the gem is pretty small.
Hook into the rails autoloading system. Each file using autoloads would add the following to the class
extend ActiveSupport::Autoload if defined?(ActiveSupport::Autoload). The net result is that the activesupport autoloader which is used by rails would also be used by this gem. Doing this would allow lazy loading for ruby files in development and eager loading in production.
I believe that 1 is the simplest with very little performance tradeoff, but if load performance is important to you option 2 would work as well. Let me know what you think. I am happy to code this up.

@trevorrowe Since this is actually happening for us in the AWS ruby gem, I thought you would be interested.

Well - for this particular gem, the issue could be http://urbanautomaton.com/blog/2013/08/27/rails-autoloading-hell/
In either case, avoiding autologous would solve the issue.

Given the small size of the library, I am in favor if removing the use of autoload. On a side note, we are investigating modularizing the 70+ services into their own gems. The end goal is to possibly remove the need for autoload in aws-sdk. Still in a very early stage considering this.

Perfect. I will get in a pr.

Merged #31, this will go out with the next release.


Add benchmarker running on Github Actions

Example runs can be seen at https://github.com/alxndrsn/odk-central-backend/actions
Currently depends on https://github.com/getodk/central-backend/pull/620.

It looks like there's a conflict now that #619 is merged. Might be worth rebasing?


remove flag -a (already in "params) and change "params" for "p"

and put   -p                     amount of padding for generating labels. Default value = 30
in the new -p


Pin dependencies + more verbose instructions and less podcast

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

I like the new style, less to read!
https://github.com/vespa-engine/sample-apps/blob/master/test/_test_config.yml#L29 to enable testing

Have we looked at why installing the runtime dependencies, e.g torch fails on screwdriver.cd ?

Disable for now: Downloading torch-1.8.1-cp36-cp36m-manylinux1_x86_64.whl (804.1 MB) fails on Screwdriver.cd


Write user stories

As a user, I would like to easily view all currently assigned calendars and the current opening hours for each service point, with sorting of each column.
As a user, I would like to be able to create new calendars and apply them to multiple service points.
As a user, I would like to be able to create new calendars with opening hours that can span multiple days
As a user, I would like to be able to edit existing calendars
As a user, I would like to be able to add exceptions to calendars to override their openings for some certain day(s).
As a user, I would like to be able to add exceptions to calendars to close them when they would normally be open.
As a user, I would like to be able to view all of the information for an existing calendar, including hours, exceptions, and assignments.  Note: maybe add a preview calendar of how the hours/exceptions will look together?
As a user, I would like to be able to delete existing calendars.
As a user, I would like to be able to duplicate an existing calendar to make a new one without manually copying the information over.
As a user, I would like to be able to view all calendars, not just those that are currently in effect, with sorting in each column.
As a user, I would like to be able to purge old calendars with a selectable date (3 months, 6 months, 1 year, 2 years, etc).
As a user, I would like to be able to purge calendars that are not assigned to any service points.
As an administrator, I would like to be able to add and control permissions for viewing, editing, and deleting opening hour information.

@sjturner-ua when you get a chance, would you let me know if there are any use cases you can think of that might be missing (and comment on number 7's note)?