AV_OPT_TYPE_* may not exist

From @tab1293 on #112:
I just tried to do a fresh install from master and there are some errors when I run make
src/av/option.c: In function ‘PyInit_option’:
src/av/option.c:1706:51: error: ‘AV_OPT_TYPE_DICT’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_DICT); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 23; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1706:51: note: each undeclared identifier is reported only once for each function it appears in
src/av/option.c:1730:51: error: ‘AV_OPT_TYPE_IMAGE_SIZE’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_IMAGE_SIZE); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 25; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1742:51: error: ‘AV_OPT_TYPE_PIXEL_FMT’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_PIXEL_FMT); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 26; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1754:51: error: ‘AV_OPT_TYPE_SAMPLE_FMT’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_SAMPLE_FMT); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 27; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1766:51: error: ‘AV_OPT_TYPE_VIDEO_RATE’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_VIDEO_RATE); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 28; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1778:51: error: ‘AV_OPT_TYPE_DURATION’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_DURATION); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 29; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1790:51: error: ‘AV_OPT_TYPE_COLOR’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_COLOR); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 30; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
src/av/option.c:1802:51: error: ‘AV_OPT_TYPE_CHANNEL_LAYOUT’ undeclared (first use in this function)
   __pyx_t_2 = __Pyx_PyInt_From_enum__AVOptionType(AV_OPT_TYPE_CHANNEL_LAYOUT); if (unlikely(!__pyx_t_2)) {__pyx_filename = __pyx_f[0]; __pyx_lineno = 31; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
                                                   ^
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
make: *** [build] Error 1

The only difference from these instructions is that I am using pip to install pillow instead of pil. Anyone else experiencing this?

@tab1293, Seems like my assumption that those macros exist everywhere is not true.
Can you confirm if you have FFmpeg or Libav?

I definitely have FFmpeg and I installed all the dependencies listed in the instructions for Ubuntu 14.04. Pretty sure I don't have libav installed, how would I confirm?

I just reinstalled ffmpeg from the latest source and pulled the newest commit from this repo. When trying to make I get this error
(venv)tom@thinkpad:~/PyAV$ make
CFLAGS="-O0" LDFLAGS="" python setup.py build_ext --inplace --debug
running build_ext
running config
running reflect
looking for avformat_open_input... missing
looking for pyav_function_should_not_exist... missing
looking for av_calloc... found
looking for av_frame_get_best_effort_timestamp... found
looking for avformat_alloc_output_context2... missing
looking for avformat_close_input... missing
looking for AVStream.index... found
looking for PyAV.struct_should_not_exist... missing
looking for AVFrame.mb_type... found

We didn't find `avformat_open_input` in the libraries.
We look for it only as a sanity check to make sure the build
process is working as expected. It is not, so we must abort.

Please open a ticket at https://github.com/mikeboers/PyAV/issues
with the folowing information:

PyAV: 0.2.4 v0.2.3-59-g553f98e
Python: 2.7.6 (default, Jun 22 2015, 17:58:13) \n[GCC 4.8.2]
platform: Linux-3.13.0-61-generic-x86_64-with-Ubuntu-14.04-trusty
extension_extra:
	libraries: ['SDL', 'X11', 'Xau', 'Xdmcp', 'Xext', 'asound', 'ass', 'avcodec', 'avdevice', 'avfilter', 'avformat', 'avutil', 'bz2', 'caca', 'crystalhd', 'dl', 'enca', 'expat', 'fdk-aac', 'fontconfig', 'freetype', 'fribidi', 'harfbuzz', 'jack', 'lzma', 'm', 'mp3lame', 'ogg', 'opus', 'png12', 'postproc', 'pthread', 'pulse', 'pulse-simple', 'swresample', 'swscale', 'theoradec', 'theoraenc', 'va', 'va-x11', 'vorbis', 'vorbisenc', 'vpx', 'x264', 'xcb', 'xcb-render', 'xcb-shape', 'xcb-shm', 'xcb-xfixes', 'z']
	library_dirs: ['/home/tom/ffmpeg_build/lib']
	include_dirs: ['/home/tom/ffmpeg_build/include', 'include', '/usr/include/python2.7']
config_macros:
	PYAV_VERSION=0.2.4
	PYAV_VERSION_STR="0.2.4"
	PYAV_COMMIT_STR="v0.2.3-59-g553f98e"
	PYAV_HAVE_LIBSWRESAMPLE=1
	PYAV_HAVE_AV_CALLOC=1
	PYAV_HAVE_AV_FRAME_GET_BEST_EFFORT_TIMESTAMP=1
	PYAV_HAVE_AVFRAME__MB_TYPE=1
make: *** [build] Error 1

It looks like PyAV is having trouble finding my ffmpeg installation even though it is looking in the correct include and library directories where I have ffmpeg installed. Any suggestions of what to do?

I don't immediately know what is wrong, but I am very happy to have written that message. =D

That is the only one that isn't found that should be. So the system seems to be working fine...
Has that function been depreciated?

No that function is still valid. It is documented here and still used in ffplay.

It seem pretty key, and I don't see any discussion of it going away. I guess the detection system is broken, somehow.

I just removed the check from setup.py but now am getting this make error.
x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -O0 -fPIC -g build/temp.linux-x86_64-2.7/src/av/packet.o -L/home/tom/ffmpeg_build/lib -lxcb -lva -lenca -lpostproc -lexpat -ldl -lharfbuzz -lvorbis -lva-x11 -lvorbisenc -lpthread -lx264 -lavutil -lpng12 -lasound -lbz2 -lmp3lame -lavcodec -lfontconfig -lavformat -lopus -lxcb-shape -lxcb-shm -ltheoraenc -lxcb-xfixes -lass -llzma -lfreetype -ltheoradec -lvpx -lpulse-simple -lXext -lcaca -lpulse -lX11 -logg -lavdevice -lXau -lfribidi -lavfilter -lm -lxcb-render -lcrystalhd -lswscale -lSDL -lswresample -lz -lfdk-aac -lXdmcp -ljack -o build/lib.linux-x86_64-2.7/av/packet.so
/usr/bin/ld: /home/tom/ffmpeg_build/lib/libavutil.a(avstring.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
/home/tom/ffmpeg_build/lib/libavutil.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

This error happens pretty far in the compile process so maybe the latest ffmpeg build is giving it trouble? What version of ffmpeg are you using?

looks its might be a static linking issue try building ffmpeg with  --enable-shared --disable-static

@markreidvfx You were right I had to build ffmpeg with shared libraries instead of static. Here the config command I used for reference.


compileAsync causes infinite chain of requests when metaschema is specified

What version of Ajv are you using? 8.8
Does the issue happen if you use the latest version? yes
Ajv options object

{
  loadSchema: async (url) => {
    if (url.startsWith("http://")) {
      url = "https://" + url.substring(7)
    }
    const ans = await (await fetch(url)).json()
    console.log(ans)
    return ans;
  }
}

JSON Schema

{ "$ref": "http://json-schema.org/draft-04/schema#", "$schema": "http://json-schema.org/draft-04/schema#" }

Sample data
The schema never finishes compiling
Your code

const ajv = new Ajv(options)

async function compile() {
  await ajv.compileAsync(schema)
  console.log("Done compiling")
}

Here's a sandbox replicating the problem: https://runkit.com/yesennes/619429f6e904c40008bcc644
Validation result, data AFTER validation, error messages
The schema never finish compiling.

What results did you expect?
The schema to finish compiling.
Are you going to resolve the issue?
I can take a stab at it.

Hello! Not sure if you solved this, but I believe there are two problems here: one with your code, but the other really is with Ajv.
First, the issue with Ajv: I changed the $schema and $ref in your schema to draft-07, and it worked fine. I then tested this with draft-06, but this also started an infinite request loop, just like you're experiencing with draft-04. This implies that when Ajv reads a $schema value of exactly http://json-schema.org/draft-07/schema, it understands that this is its default, pre-cached meta-schema and so it does no additional requesting/processing. However, when it reads a $ref or a $schema linking to an older draft, such as http://json-schema.org/draft-04/schema, it actively makes a request to that URL. The schema is fetched, but before being cached, Ajv needs to process said schema to resolve any additional references. But since every meta-schema has its own $schema property pointing to itself, and meta-schemas aren't cached until all its references can be resolved, Ajv requests that schema, see its schema reference, requests that schema, sees its schema reference, and so on.
To work around that, you can simply preload meta-schemas in advance. If I was using draft-06, I could preload draft-06 before attempting compilation, like so:
const draft06 = require('ajv/dist/refs/json-schema-draft-06.json');
ajv.addMetaSchema(draft06);

However, this will not work with draft-04 because draft-04 is not included with Ajv, since it doesn't work with Ajv out of the box. That's where the issue with your code comes in, but there's an easy fix.
From this documentation:

You can use JSON Schema draft-04 schemas with Ajv from v8.5.0 and the additional package ajv-draft-04 both ajv and ajv-draft-04 should be installed).

const Ajv = require("ajv-draft-04")
const ajv = new Ajv()

This will add a version of Ajv that works with draft-04, and has draft-04 preloaded as its meta-schema already.

Facing the same problem with draft-07, but the suggested solution does not (maybe no longer) work.
const draft07 = require('ajv/dist/refs/json-schema-draft-07.json');
ajv.addMetaSchema(draft07);
´´´

This solves the infinite loop problem, but the loadSchema function is still called for this schema, which should already be known.

ajv then fails with:

Error: schema with key or id "http://json-schema.org/draft-07/schema" already exists

The only way I was able to pass this step was to actually remove the schema from the loaded files:

```ts
delete schema.$schema


New Neovim highlight groups

A new update with support for semantic tokens has been pushed into the master branch of Neovim.
It also features new highlight groups, i tought it was ok to let you know.

By the way, great work with the theme! I use it everywhere.

I think I'll leave it like that for the moment, this is still a new feature and it's being worked on. I'll consider tweaking it once its stable enough (i.e. modifiers support)
p.s. thanx :)

@Lamarcke  you can link them yourself if you can't wait for the official support:
For example I really want the C-preprocessor skipped code to be shown as comments, so adding lsp.type.comment link to @comment is enough for this limited use case. I tested it with the 0.9 nightly.
function M.setup(colors, config)
    config = config or require("kanagawa").config
    local theme = colors.theme
    return {
            --<EMAIL_ADDRESS>= { link = "Structure" },
            --<EMAIL_ADDRESS>= { link = "Function" },
            --<EMAIL_ADDRESS>= { link = "Structure" },
            --<EMAIL_ADDRESS>= { link = "Constant" },
            --<EMAIL_ADDRESS>= { link = "Function" },
            --<EMAIL_ADDRESS>= { link = "Structure" },
            --<EMAIL_ADDRESS>= { link = "Macro" },
<EMAIL_ADDRESS>= { link = "@method" }, -- Function
<EMAIL_ADDRESS>= { link = "@comment" }, -- Comment
<EMAIL_ADDRESS>= { link = "@namespace" }, -- Structure
<EMAIL_ADDRESS>= { link = "@parameter" }, -- Identifier

They are supported after the "overhaul"

They are supported after the "overhaul"

Awesome! Thanks for the great work


Fix cookie functionality

Another issue I have spotted is that we are having some trouble placing cookies on Chrome.

These issues relate to first or third party cookies (i.e., our own extension cookies or the DAA opt out cookies, for example)? Google is phasing out third party cookies, however, only by 2023. So, maybe the issues are mv3 related?

It is a problem with our first-party cookies.

This is resolved.


⚠ Bofrost.at has degraded performance

In 5408b69, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1979 ms

Resolved: Bofrost.at performance has improved in 2d5056c after 7 minutes.


Responsive?!?

I have been reading the issues about how to make the sparkline responsive, but I am having trouble making this happen.
My goal is to force the height to be some dimension in pixels (like 100px) and have the width be 100% of the containing div.
This is what is happening:

I have tried setting all combinations of svgWidth/Height and width/height with both numbers and percentages, and it is not working... I must be missing something.
I am sure I am missing something simple.  Please advise!  And thank you for a great product!

No worries... I will use something else.  Great product though...


Use JIRA task ID as a tag, if present

If the task was imported from JIRA using bugwarrior, use the JIRA task ID as an additional tag.

Migrated here from https://github.com/GothenburgBitFactory/timewarrior/pull/235

As far as I understand https://taskwarrior.org/docs/design/task.html#atts, jiraid is not a standard attribute of Taskwarrior but entered by Bugzilla. How is this handled for other bug-trackers (of whom Bugzilla supports a lot)?
I would argue it is a bug of Bugzilla not to add the JIRA-ID as a tag to the task...
The hook script should not depend on/implement other project's features than Taskwarrior's.

From @fdcds:

How is this handled for other bug-trackers (of whom Bugzilla supports a lot)?

They would need to be added to the hook individually.

I would argue it is a bug of Bugzilla not to add the JIRA-ID as a tag to the task...

Well, bugwarrior adds key:value attributes to the task, which can be queried like tags. So from a taskwarrior point of view having an additional tag would be redundant. Only for timewarrior these key:value attributes need to be translated into tags.

The hook script should not depend on/implement other project's features than Taskwarrior's.

I understand your POV, but that would mean that the ~/.task/hooks/on-modify.timewarrior needs to call additional ~/.timewarrior/hooks/extract-tags-from-taskwarrior.bugwarrior hooks to turn other project's taskwarrior task attributes into timewarrior tags (~/.task/hooks/on-modify.* is the only place where we can get it without jumping through nasty hoops). Doable, but makes on-modify.timewarrior more complex.

I agree that this is a simple solution, but it feels like opening Pandora's box by allowing jiraid in and then having all the other services come knocking at the door...
I wonder whether an (user-defined-)attribute-2-tag-map could solve this situation (in the future).

from @fdcds:

I wonder whether an (user-defined-)attribute-2-tag-map could solve this situation (in the future).

I like the idea, but it would have to be a more general function. For JIRA I can take the jiraid, which includes the project, to create a unique ID tag. But bugwarrior's GitHub support, for example, sets githubnumber and githubrepo attributes, which one would want to combine into githubrepo#githubnumber to produce a unique ID tag. My suggestion would be to pass the complete taskwarrior task JSON object to the function and have it produce a list of timewarrior tag strings.

From @xeruf:
yeah, this needs a more generic solution, supporting a single custom property would be weird

From @bserem:
In bugwarrior github, we can add the issue-id as a tag in taskwarrior using this inside bugwarrior:
github.add_tags = {{githubnumber}}
Similarly, I would expect that this would work:
jira.add_tags = {{jiraid}}
This would add the tag in the task, so the list of tags would already be ok when the hook is called.
You would need to prepend it with something so that timewarrior will get triggered, like:
github.add_tags = #{{githubnumber}}
jira.add_tags = #{{jiraid}}
or use the approach in https://github.com/GothenburgBitFactory/timewarrior/pull/425
So, my suggestion is that this can be handled in bugwarrior right away actually.


Fix template and test bugs from PR #4541

Sorry about that everyone.
@MaximeMorin-Devolutions, can you check the changes and propose changes for anything else you found?

@paulomorgado LGTM, thanks for the quick fixes!

Is this ready to merge and will fix the problem? What about the open comment?

Is this ready to merge and will fix the problem? What about the open comment?

As far as I could assert from the tests, yes!
I have more coming up, but I want to keep them bite sized.


Support Relay

Looks like Relay has a thin layer on top of GraphQL. Would adding (optional?) Relay support be in scope for juniper?

I have started working on relay support, implementing the Relay Cursor Connections Specification specification here.

@bbqsrc can we now use relay with Juniper? any updates?

FWIW, I found https://github.com/bbqsrc/juniper-relay. @bbqsrc can speak to the state of it of course.

There is a specification page about the assumptions Relay makes of a GraphQL server. https://relay.dev/docs/en/graphql-server-specification, work could begin from there.

So any progress on Relay?

@UkonnRa see my comment above. You can use it, you just have to check a few things manually and to conform to the three specs I linked to.

I wonder if the relay additions could be a separate library built on top of juniper and not necessarily something that is built in 🤔

IMO, if it exists it really should be separate of juniper. Relay is a spec
on top of GraphQL, so should it be for juniper and a Relay layer on top of
it.
Le ven. 10 janv. 2020 à 2:01 PM, David Pedersen<EMAIL_ADDRESS>a écrit :

I wonder if the relay additions could be a separate library built on top
of juniper and not necessarily something that is built in 🤔
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/graphql-rust/juniper/issues/42?email_source=notifications&email_token=ADEAHRU5SVCNPXT42MYDQDTQ5BWTHA5CNFSM4DIVMG22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIT3BBA#issuecomment-573026436,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADEAHRQPTCPOGUVIN2SDPT3Q5BWTHANCNFSM4DIVMG2Q
.

I guess that means someone can build a library crate for relay support?

Just for information, digging on with Github search i found an implementation that seems to work made by @dyedgreen on a rust project he made. The implementation can be found here.
I don't know if he intends at some point to publish this as a separate crate, but meanwhile it could be useful to anyone that would like to use relay pagination.

If people find it useful, I could try to update the library if necessary and publish it as a stand-alone crate.
I made this a while ago, but iirc it’s mostly just a trait that you can implement which then gets plummed through to the correct Juniper traits. (Plus a default implementation for (cursor, node) tuple values.)

If people find it useful, I could try to update the library if necessary and publish it as a stand-alone crate.
I made this a while ago, but iirc it’s mostly just a trait that you can implement which then gets plummed through to the correct Juniper traits.

For my own use i just made a copy of your implementation mentioning the source.
However if you intend to publish it as a crate i'd be happy to use it as a dependency :D.
I can't speak for all but i'm pretty sure people would find it useful as even if it is a few traits and structs, it might be not so trivial to many as no other implementation ( aside of @bbqsrc's one ) can be found on GH.

I've moved the Relay connection package into it's own repo and published that on crates.io. (I also added an async version, so the load closure may be async ...) (cc @Asone)

How do you support Global ID with Juniper?
having the node query:
node(id: "") {
    id
    ... on Model {
      name
    }
  }

I can't think in a good way to resolve  this node query to get the exact model resolver. I have seen in other language implementations that the id has a shape like: model-id an then converted to uuid with that when the node query is requested deserialize that and uses the model to resolve.
How do you implement this resolver?


[Coding Dojo] Review, Feedback, and Requests for the future.

The tutorial is flawed, and I got lost frequently :/ but I got the overall idea behind it. Thanks @alecsantos96


[feature request] assign a tuple to one row of recarray

test code:
import numpy as np
from numba import njit

@njit
def foo(arr, name, age, height):
    items = (name, age, height)
    arr[1] = items
    return arr

dtype = [("Name", "U10"), ("Age", "i4"), ("Height", "f4")]
recarr = np.empty((2,), dtype=dtype)
recarr[0] = ("John", 25, 180.5)

print(recarr)
print(foo(recarr, "John", 25, 180.5))

np supports directly assign a tuple of given types to one row of recarray, but numba doesn't.
No implementation of function Function(<built-in function setitem>) found for signature:

 >>> setitem(unaligned array(Record(Name[type=[unichr x 10];offset=0],Age[type=int64;offset=40],Height[type=float64;offset=48];56;False), 1d, C), Literal[int](1), Tuple(unicode_type, int64, float64))

If could, the user code can be only one-line, rather than multiple lines to assign each item.
kind of relating with #8471

Yes, this is doable without too much difficulty.
We should expect to see as output from the OP's program:
[('John', 25, 180.5) ('',  0,   0. )]
[('John', 25, 180.5) ('John', 25, 180.5)]

Example in-progress I had:
import numpy as np
import operator
from numba import cuda
from numba.core import types
from numba.core.extending import lower_cast
from numba.core.typeconv import Conversion
from numba.core.typing.templates import (AbstractTemplate, infer_global,
                                         signature)

@lower_cast(types.UniTuple, types.Record)
@lower_cast(types.Tuple, types.Record)
def tuple_to_record(context, builder, fromty, toty, val):
    breakpoint()

possible_conversions = (
    Conversion.exact,
    Conversion.promote,
    Conversion.safe,
    Conversion.unsafe
)

@infer_global(operator.setitem)
class SetItemRecordArray(AbstractTemplate):
    def generic(self, args, kws):
        assert not kws
        ary, idx, val = args
        for a, b in zip(ary.dtype.fields.values(), val.types):
            conv = self.context.can_convert(b, a.type)

            if conv not in possible_conversions:
                return

        return signature(types.none, ary, idx, val)

def test():

    dt = np.dtype([('x', np.float32), ('y', np.float32)], align=True)

    @cuda.jit
    def f(input, output):
        # v = input[0]
        # x, y = v.x, v.y
        # output[0] = v # works
        #output[0] = np.record((3.14, 2.71), dtype=dt)  # nope
        # output[0].x = 3.14 # OK
        # output[0].y = 2.71 # OK
        output[0] = (3.14, 2.71)

    input = np.array([(3.14, 2.71)], dtype=dt)
    output = np.zeros_like(input)

    f[1, 1](input, output)
    cuda.synchronize()

    print(input, output)
    assert np.allclose(input.view(dtype=np.float32),
                       output.view(dtype=np.float32))

test()

Just talked about this in triage, maybe it is not that straightforward once nested structs are considered.

Thanks for the impl draft! Will follow up soon. I think it's still good if the case without nested structs can work for now.

I think @stuartarchibald has a better draft than me - taking mine and going further with it might not be the best way forward.

Can @stuartarchibald's draft be shared with me? Thanks! I can follow up to make it as a PR.

maybe I can directly change some code in https://github.com/numba/numba/blob/42616dc0bb40752ae1d2ca08328435144caa8a6c/numba/core/typing/arraydecl.py#L217-L218 for typing.

I think another way of doing this would involve using literal_unroll to unroll the assignment expression across the record/tuple, am still working on the details as the nested case (assignment to a record containing records) is a little tricky and might not be possible via this approach.


Dependabot

Codecov Report

Merging #43 (152d84f) into main (e8b7117) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   70.17%   70.17%
=======================================
  Files          41       41
  Lines         399      399
  Branches       29       29
=======================================
  Hits          280      280
  Misses        119      119

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


zoom in to see the difference between big numbers in line chart

Hi,
it would be nice to have an auto zoom option.
I have numbers betweeen 2000 and 2050 and I can not see any difference between them in the line chart. Even if I set the minY option to 2000 I have a maxY value of 2760 and a horizontal line near the beaseline.
I suggest to provide to new option:
autoZoom: {
enabled: true,
paddingBottom: 10, // minY is set to the min value of the provided numbers - 10
paddingTop: 10 // maxY is set to the max value of the provided numbers - 10
}
Is this a good idea or do you have a better one to solve my problem. Maybe I missed an option.
Regards,
Simon

does setting maxY manually (like this) make the chart look good? If so for now you can update the max Y either up front or every time you update the data.

I've tried to set maxY manually but this value was ignored.
I think the problem is that you take the largest number in the data array and multiply it with 1.2 twice. If this result is larger than the maxY value you ignore this option.
max = m*1.2;
max*=1.2
if (self.options.maxY) {
  return Math.max(max, self.options.maxY)
}

Maybe this is a bug and you want to apply Math.min()?
If this is the case I can follow your advice and update maxY and many manually after every update of my data ;)
Regards,
Simon

so if you hard code your maxY in blessed-contrib source (just for testing) you see the desired output?

Hi,
yes! If I modify line.js
max = m*1.2;
max*=1.2
max=2100 // HARDCODED
if (self.options.maxY) {
  return Math.max(max, self.options.maxY)
}

or
max = m*1.2;
max*=1.2
if (self.options.maxY) {
  return Math.min(max, self.options.maxY) // change Math.max to Math.min
}

I see the correct result:

Chart without modification of line.js:

I don't think using Math.min is the right choice. I added a pull request, which takes any value you provide as maxY. The whole point of providing a maxY is that you do not want the library to use the calculated value. So I think this is the only correct solution.
However, while I am writing this, it comes to my mind that maybe I should have added a check for maxY > minY?


ENH: implement human-readable repr for PeakStats

Implements human-readable __repr__ for the PeakStats (continuation of improvements of #1478).
Description

This PR adds the __repr__ and __dict__ methods to easily see the data for the stats and derivative stats.
Used a hint from https://stackoverflow.com/a/34166604 regarding ._asdict() for namedtuple objects.
Motivation and Context

The previous way of reporting the PeakStats information was hard to use. Example from @gfreychet:
bec._peak_stats
Out[29]: {'bd52e883-7422-4b3b-94a4-a4b5adbaaebc': {'pil1M_stats1_total': <bluesky.callbacks.fitting.PeakStats at 0x7f046f6b9850>}}

With this update:
In [15]: bec._peak_stats
Out[15]:
{'f38cbe6a-029f-493a-a07c-73c4eb45a799': {'det': {'derivative_stats': {'cen': 0.0999999999999998,
                        'com': -0.8,
                        'crossings': array([0.1]),
                        'fwhm': None,
                        'lin_bkg': None,
                        'max': (-0.8, 0.1196183773610574),
                        'min': (1.0, -0.1196183773610574),
                        'x': array([-0.8, -0.6, -0.4, -0.2,  0. ,  0.2,  0.4,  0.6,  0.8,  1. ]),
                        'y': array([ 0.11961838,  0.10912117,  0.08784613,  0.05708233,  0.01980133,
         -0.01980133, -0.05708233, -0.08784613, -0.10912117, -0.11961838])},
   'stats': {'cen': 5.551115123125783e-17,
             'com': 0.0,
             'crossings': array([-0.65865934,  0.65865934]),
             'fwhm': 1.3173186844780238,
             'lin_bkg': None,
             'max': (0.0, 1.0),
             'min': (-1.0, 0.6065306597126334)}}}}

How Has This Been Tested?

Tested locally.

attn @gfreychet

Hi All, any chance it could be reviewed/merged this week?

Can someone post an example of the repr from the current code base?  Is the example above the most recent example.

Can someone post an example of the repr from the current code base? Is the example above the most recent example.

This is the first code block in the "Motivation and Context" section of the description:
bec._peak_stats
Out[29]: {'bd52e883-7422-4b3b-94a4-a4b5adbaaebc': {'pil1M_stats1_total': <bluesky.callbacks.fitting.PeakStats at 0x7f046f6b9850>}}

I meant to ask: What does the new version look like?

The second block from the description is for the repr with the code from this PR. That should be current.
In [15]: bec._peak_stats
Out[15]:
{'f38cbe6a-029f-493a-a07c-73c4eb45a799': {'det': {'derivative_stats': {'cen': 0.0999999999999998,
                        'com': -0.8,
                        'crossings': array([0.1]),
                        'fwhm': None,
                        'lin_bkg': None,
                        'max': (-0.8, 0.1196183773610574),
                        'min': (1.0, -0.1196183773610574),
                        'x': array([-0.8, -0.6, -0.4, -0.2,  0. ,  0.2,  0.4,  0.6,  0.8,  1. ]),
                        'y': array([ 0.11961838,  0.10912117,  0.08784613,  0.05708233,  0.01980133,
         -0.01980133, -0.05708233, -0.08784613, -0.10912117, -0.11961838])},
   'stats': {'cen': 5.551115123125783e-17,
             'com': 0.0,
             'crossings': array([-0.65865934,  0.65865934]),
             'fwhm': 1.3173186844780238,
             'lin_bkg': None,
             'max': (0.0, 1.0),
             'min': (-1.0, 0.6065306597126334)}}}}

Thanks, @prjemian! I'll use the "Before" and "After" titles for clarity next time.

Thanks for clarifying.  Since there were commits after, it was not obvious that the second example was the final result.

Thanks for clarifying. Since there were commits after, it was not obvious that the second example was the final result.

FWIW, these commits are mostly related to CI/tests, not the changed code.

FYI: I've added a commit https://github.com/bluesky/bluesky/pull/1486/commits/48b0a538fc8223b384d5629acdc20e354d3d9698 to add better visibility of the PeakStats attributes when doing dir(ps) (and the tab-completion in IPython). Here are examples (before and after):
Preparation
In [1]: from bluesky.callbacks.best_effort import BestEffortCallback
   ...: from databroker import Broker
   ...: db = Broker.named("smi")
   ...: hdr = db["<UID>"]
   ...: hdr.table()
   ...: bec = BestEffortCallback(calc_derivative_and_stats=True)
   ...: for name, doc in hdr.documents():
   ...:     bec(name, doc)
...

In [2]: ps = bec._peak_stats["<descriptor-UID>"]["pil1M_stats1_total"]

Before:
In [3]: dir(ps)
Out[3]:
['__call__',
 '__class__',
 '__delattr__',
 '__dict__',
 '__dir__',
 '__doc__',
 '__eq__',
 '__format__',
 '__ge__',
 '__getattr__',
 '__getattribute__',
 '__getitem__',
 '__gt__',
 '__hash__',
 '__init__',
 '__init_subclass__',
 '__le__',
 '__lt__',
 '__module__',
 '__ne__',
 '__new__',
 '__reduce__',
 '__reduce_ex__',
 '__repr__',
 '__setattr__',
 '__sizeof__',
 '__str__',
 '__subclasshook__',
 '__weakref__',
 '_calc_stats',
 '_dispatch',
 'bulk_datum',
 'bulk_events',
 'compute',
 'datum',
 'datum_page',
 'descriptor',
 'emit',
 'event',
 'event_page',
 'log',
 'reset',
 'resource',
 'start',
 'stop']

After:
In [3]: dir(ps)
Out[3]:
['__call__',
 '__class__',
 '__delattr__',
 '__dict__',
 '__dir__',
 '__doc__',
 '__eq__',
 '__format__',
 '__ge__',
 '__getattribute__',
 '__getitem__',
 '__gt__',
 '__hash__',
 '__init__',
 '__init_subclass__',
 '__le__',
 '__lt__',
 '__module__',
 '__ne__',
 '__new__',
 '__reduce__',
 '__reduce_ex__',
 '__repr__',
 '__setattr__',
 '__sizeof__',
 '__slots__',
 '__str__',
 '__subclasshook__',
 '__weakref__',
 '_calc_stats',
 '_dispatch',
 'bulk_datum',
 'bulk_events',
 'cen',
 'com',
 'compute',
 'crossings',
 'datum',
 'datum_page',
 'derivative_stats',
 'descriptor',
 'emit',
 'event',
 'event_page',
 'fwhm',
 'lin_bkg',
 'log',
 'max',
 'min',
 'reset',
 'resource',
 'start',
 'stats',
 'stop',
 'x',
 'y']

@mrakitin I have been playing with the new peak_stats implemented in bec and it works nicely. I have one modification to suggest, which is to have the x and y values stored in stats. Currently, I am trying to build an efficient procedure for the sample alignment of gisaxs. I need to scan sample height and angle and find the maximum for the angle and the inflection point for the height (that is why I needed the derivative). I want to be able to display the position of max / cen / com calculated superposed with either x, y or the derivated x, y. Currently in bec._stats only the derivated x and y are stored, not the initial x and y. I would like a time efficient way to access the x and y without having to open db.table which takes 3s or so

@gfreychet was testing the feature on the beamline with my remote assistance, and earlier posted a comment (currently removed) about missing x and y attributes in the ps.stats object (an attribute of the ps object in my comment above). The concern was that they are not exposed the same way as it was done for the derivative_stats attribute. The reason is that I did not want to duplicate the already existing ps.x_data and ps.y_data fields, so the ps.stats object's fields are slightly different than the ps.derivative_stats' fields. Guillaume told me that it works for his purposes.
I just added the x_data and y_data attributes to the __slots__ via https://github.com/bluesky/bluesky/pull/1486/commits/5998ea01046ab31859ad3dba6e11dbbd1da0376d for easier discovery on the client side:
n [4]: dir(ps)
Out[4]:
['__call__',
 '__class__',
 '__delattr__',
 '__dict__',
 '__dir__',
 '__doc__',
 '__eq__',
 '__format__',
 '__ge__',
 '__getattribute__',
 '__getitem__',
 '__gt__',
 '__hash__',
 '__init__',
 '__init_subclass__',
 '__le__',
 '__lt__',
 '__module__',
 '__ne__',
 '__new__',
 '__reduce__',
 '__reduce_ex__',
 '__repr__',
 '__setattr__',
 '__sizeof__',
 '__slots__',
 '__str__',
 '__subclasshook__',
 '__weakref__',
 '_calc_stats',
 '_dispatch',
 'bulk_datum',
 'bulk_events',
 'cen',
 'com',
 'compute',
 'crossings',
 'datum',
 'datum_page',
 'derivative_stats',
 'descriptor',
 'emit',
 'event',
 'event_page',
 'fwhm',
 'lin_bkg',
 'log',
 'max',
 'min',
 'reset',
 'resource',
 'start',
 'stats',
 'stop',
 'x',
 'x_data',
 'y',
 'y_data']

Ready for final review.

Hi everyone, is there anything that I should address? I would like to merge it by Friday this week.

Very timely.  APS beam line 29ID wants to lineup on the derivative of a scan such as this one (so we want a release with the PeakStats derivative code in it):

Any objections to merging it today?

Thanks, @dmgav!


Add a faster torch based version of the whisper feature extractor

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fix for crashing menus using colors

Added loading text to menu items

A workaround issue #59 by showing that the menu item is still loading

Thanks for fixing this! Sorry for the long wait.


getViewport returns incorrect viewport height

getViewport returns the viewport height the same as the scene height when the page is taller than the browser window. The viewport height should be less than the scene height.
Oddly, an SSCCE for Ellie doesn't reproduce the issue: https://ellie-app.com/9LzKBNqhf7Va1 (see console logs)
I've tried on two different computers, same problem. Same in Chrome and Safari. I suggest downloading the Ellie to try it on your machine to reproduce the problem.

We've been affected by this as well.
Our workaround was to use a "reference" element in the viewport, that is at position 0, and use its position to compute the actual viewport offset.


Consider integrating Phenolyzer.

can get gene:disease pairs from this: https://raw.githubusercontent.com/WGLab/phenolyzer/master/lib/compiled_database/DB_COMPILED_GENE_DISEASE_SCORE

related to #571

perfect. If we just have a --hpo-term, then we are good.

we'll have to have it as an option as it's free for academic us license. I assume that relates to the data as well as the software.


question about maximum disparity

Hi, thanks to your code.I have some problems about maximum disparity in cost volume building.I see in your code, you build cost volume use maximum disparity/4, and in the end you upsample it as original maximum disparity.I just don't know the reason for disparity/4, maybe this will lost disparity information.

Oh, I just figure it out.

Oh, I just figure it out.

I had the same question when reading the code. Later I realized that it is due to the 4x spatial downsampling


Refactor UI to use structured output util

Describe This Problem
Currently sqlness outputs everything with println!. This is hard to maintain.
Proposal
Consider a structured way to organize our outputs. Either using existing util like TestReporter from nextest or wrap our own.
Additional Context
No response

Any user case to collect stdout output?

Any user case to collect stdout output?

No for now, just for refactoring

Then I guess we define a trait to collect those info
trait Collector {
  fn append(&self, &str) -> Result<()>
  fn flush(&self) -> Result<()>
}

Not sure if these are enough. This collector may also be exposed to users to replace their println in their sqlness runner


[QUESTION] How to to pull the test title for each test item into the test rail report

Hi again cenfun ,
Previous you helped me put the test project name into the test rail comment by using :
if (item.type === ''suite && item.suiteType === 'project') {
projectName = item.title;

return projectName;
}

But I am trying to get the case title which is in a subs[array] and when I try to get properties of subs, I get undefined returns
I have tried :
if (item.type === ''case' && item.expectedStatus === 'passed' ) {
testName = item.title;

return testName;
}

which results in no test results for testrail.
I have also tried :
if (item.type === ''suite' && item.suiteType === 'describe' ) {
testName = item.subs[item].title;

return testName;
}

which results in undefined.
testName = item.subs[0].title results in the first record

Did you get those data in onEnd hook?
In fact, rows is a tree structure, and I suggest getting information in this way:
{
  onEnd: async (reportData, capability) => {
    capability.forEach((item) => {
            if (item.type === 'case' && item.caseType === 'passed') {
                // your code
                return;
            }
            if (item.type === 'suite') {
                // your code
                return;
            }
        });
  }
}

All I needed was to call item.title in the default if statement
if (item.type === 'case' && item.testrail) {
const status_id = item.ok ? : 5;
results.push({comment : `${item.title}`})
}


Remove unnecessary SDK exports

@danderson00

On closer look, I realized we need neither the underscored export nor the tests. These are stale tests from the time when we had to explicitly request the backend to send system properties. Updated the PR.

Awesome love all that deleted code :D :shipit:

:shipit:


Support for nullable fields in JsonSchema generation from POJO's

When sending POJO's using the JSON data format, the schema that gets generated do not allow for nullable fields. There is also no way to pass this intent as part of the configuration.
In particular, I'm referring to the following:
com.amazonaws.services.schemaregistry.serializers.json.JsonSerializer
serializes using the default configuration
this.jsonSchemaGenerator = new JsonSchemaGenerator(this.objectMapper);
However, the mbknor-jackson-jsonSchema library used has a configuration that, when generating a schema allows for nullable files , see the Nullable types section here
JsonSchemaConfig config = JsonSchemaConfig.nullableJsonSchemaDraft4();
JsonSchemaGenerator generator = new JsonSchemaGenerator(objectMapper, config);

This library needs to be extended with a configuration to allow for the generation of a schema that supports nullable types as described above.
without nullable fileds
"properties": {
        "addressId": {
          "type": "string"
        },

vs
with nullable fields
"properties": {
        "addressId": {
	      "oneOf": [
		      {
			  "type": "null",
			  "title": "Not included"
		      },
		      {
			    "type": "string"
		      }
	      ]
        },

Hello,
Thanks for reaching out to us. I think it would make sense to add this configuration into GlueSchemaRegistryConfiguration that will be consumed in the JsonSerializer. By default it will be disabled.
We are happy to accept a PR if you can raise one. It would be great if you can include a test. Thanks!


DialogFlow Import beta

Rasa version: Rasa 1.2.3
Rasa X version (if used & relevant):
Python version: Python 3.7.3
Operating system (windows, osx, ...):
Distributor ID: Debian
Description:    Debian GNU/Linux 9.9 (stretch)
Release:        9.9
Codename:       stretch
Issue:
I am following the tutorial below:
https://rasa.com/docs/rasa/migrate-from/google-dialogflow-to-rasa/
That instructs the user to export the agent in Dialog Flow and them copy the agent to the data directory.
After that, run
$ rasa train nlu
Got error message : that there was no trrainning examples in the intent.
BUT what happens is the followin:
when you download an intent directly from the intent list, you download ONE file with all information. but when you make an export from configuration menu, there is actually TWO files, the intent and another one intent_user_says.
I am providing copies of the files attached.
Error (including full traceback):
2019-08-23 12:34:58 WARNING  rasa.nlu.training_data.formats.dialogflow  - No training examples found for dialogflow file data/intents/888-faq-atendimento.
json!
No NLU data given. Please provide NLU data in order to train a Rasa NLU model using the '--nlu' argument.

Command or request that led to error:
rasa train nlu

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: pt
pipeline: supervised_embeddings
# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: KerasPolicy
  - name: MappingPolicy
[Intent.zip](https://github.com/RasaHQ/rasa/files/3536119/Intent.zip)

Content of domain file (domain.yml) (if relevant):

Ops.. even with the json with the trainning phrases included I still get the same error message...

Thanks for raising this issue, @erohmensing will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Ops.. even with the json with the trainning phrases included I still get the same error message...

Do you mean that even if only the training data (the first file you mentioned) is put in the data directory, you still get the error?

Hi Erohmensing ! Exactly ! I have attached the examples in the issue.

I dion't see any attached files -- I think the upload got pulled into the code formatting. Would you mind re-attaching?

Hi @Cristianasp! Thanks for your patience. I've figured out the issue. First of all, you only want the FROMZIP files, pulled from the configuration as described here: https://rasa.com/docs/rasa/migrate-from/google-dialogflow-to-rasa/, and for what it's worth, you won't be able to train a rasa NLU model with only one intent.
That being said, it seems like the error is happening here -- that language parameter isn't actually being set anywhere (should be set to pt-br), and so it's defaulting to en and can't find the file FROMZIP_888-faq-atendimento_usersays_en.json.
I'll have to look into the best way to get this language param (I think it should come from the original file FROMZIP_888-faq-atendimento.json since it is in there), but in the meantime, jsut changing the name of your FROMZIP_888-faq-atendimento_usersays_pt-br.json to FROMZIP_888-faq-atendimento_usersays_en.json should be a workaround.

I have a mockup of a potential solution, but I don't know that much about the DialogFlow format. Is it always the case that the lang param inside the responses > messages in intent.json matches up with the intent_usersays_lang.json? What does it mean to have multiple responses and/or messages in this case?


Add unbonding periods to chains so relayers can set trust_periods

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

I like this, but how do we make sure this is updated after a governance proposal changes the param? Responsibility of chain.json maintainers?

Is this something the lens tool could verify? and then have a script to submit a change if needed?

What should be the unit of duration? It probably goes technically always goes by number of blocks, but we'll probably also want an estimated time duration. And in what units should that time be? I suppose day is common enough, but we may end up having to change to hour, and seconds would be best unit with very high precision. Shoul.d it be a number with assumed unit? Or allow for a regex'd string? or some kind of datetime format?
I might propose:
"staking": {
  "staking_tokens": [
    {
      "denom": "uatom",
      "mininim_lock_duration": {
        "blocks": 12345678,
        "approx_time": "15 days"
      }
    }
  ]
}

why did I put the duration inside the staking token object? same reason as why the staking tokens is an array and not a single denom: in case different tokens have different locking durations.
E.g., ION staking is not for the chain, but might be nice to be able to record that here.

Should we change the entire staking section to look like this?
osmosisd q staking params
bond_denom: uosmo
historical_entries: 10000
max_entries: 7
max_validators: 118
min_commission_rate: "0.050000000000000000"
min_self_delegation: "0"
unbonding_time: 1209600s


Editor GPU: Support strikethrough text

This should be easy the way we do it in xterm.js; just draw a line through the middle of the glyph. We should also consider doing this on the shader level, if the shader knows the cell's metadata, it could do the check and draw the line in the middle of relevant cells which would save some memory (maybe not much unless there's a lot of strikethrough text?).
https://github.com/microsoft/vscode/blob/bd21f3c8f268b741edac137fc109d75a555c0541/src/vs/editor/browser/gpu/raster/glyphRasterizer.ts#L89-L91

Merging into https://github.com/microsoft/vscode/issues/233992


broken Statistics page v0.59.0

Statistics only in pending state

[root@abf-slave ~]# docker version
Client:
Version:      1.10.0
API version:  1.22
Go version:   go1.5.1
Git commit:   35sfs44t
OS/Arch:      linux/amd64
Server:
Version:      1.10.0
API version:  1.22
Go version:   go1.5.1
Git commit:   35sfs44t
Built:
OS/Arch:      linux/amd64
Rancher: v0.59.0
If i downgrade back to docker 1.9.0 all working fine again.

2/13/2016 12:21:10 PMtime="2016-02-13T09:21:10Z" level=info msg="Invalid HostUuid." hostUuid=a7477703-031b-4c93-a8b6-e7dde14c395b
2/13/2016 12:21:10 PMtime="2016-02-13T09:21:10Z" level=error msg="could not find host uuid"
2/13/2016 12:21:11 PMtime="2016-02-13T09:21:11Z" level=info msg="Registering backend for host [a7477703-031b-4c93-a8b6-e7dde14c395b]"
2/13/2016 12:22:05 PMtime="2016-02-13T09:22:05Z" level=info msg="Invalid HostUuid." hostUuid=a7477703-031b-4c93-a8b6-e7dde14c395b
2/13/2016 12:22:05 PMtime="2016-02-13T09:22:05Z" level=error msg="could not find host uuid"
2/13/2016 12:22:07 PMtime="2016-02-13T09:22:07Z" level=info msg="Registering backend for host [a7477703-031b-4c93-a8b6-e7dde14c395b]"

+1
Don't mean to sound negative by the following comment; After-all Rancher is something I'm not paying for and absolutely love.
These sort of regressions in the UI seem very common. How are tests not catching these issues?

@bacheson This issue has nothing to do with the UI, it can't show data that isn't sent.
If you think you can do a better job of testing the infinitely variable combinations of hardware, network & storage configs, distros, kernels, docker versions, user software and random vendor patches applied to all of those levels, and separating the actual issues from the majority that end up being "lolz firewall"/user error, we're hiring.

I believe this is due to an incompatibility between cadvisor and Docker 1.10, @fedya can you share what is your host OS?
@bacheson The tests cases for this functionality have not been ran against 1.10.  This is basically a case of "OMG DOCKER 1.10 WAS RELEASED 9 DAYS AGO WHY HAVENT YOU FIXED EVERYTHING IT BREAKS!!!"

@vincent99 @ibuildthecloud
For the record, 1.10-rc was release 1 month ago. Projects like Weave released updates immediately addressing incompatibilities.
I meant no offence guys ... I love and respect what you are doing

@ibuildthecloud i tested ubuntu, centos and openmandriva.
Issue valid only for docker 1.9.1+ , on 1.9.0 everything works as expected

@bacheson Whoa.... don't poke the bear here.  You have no idea the amount of testing we have done against 1.10 already.  https://github.com/docker/docker/issues?utf8=✓&q=is%3Aissue+author%3Aibuildthecloud+  I have personally filed and help addressed 29 issues in 1.10 dating back to Dec 21 (yes before rc1 because we test against master in order to give us more time to get bugs fixed).  Not to toot our own horn here but Rancher is probably the largest contributor in QA of pre-releases of Docker.  We really really have to bite our tongue when people complain about quality or not fixing things fast enough because you really have no idea how much effort we already put into this.

@fedya Just to clarify you are seeing this issue with 1.9.1 and 1.10.0?  I'm personally not aware of an issue with 1.9.1

@ibuildthecloud I apologize if you feel I was challenging your work ... that was not my intention ... please accept my sincere apologies ... the community and people like myself owe an immense debt to trailblazers like yourself ... I'm a heavy user / huge fan of Rancher; I champion your platform on a daily basis to friends and colleagues

@bacheson Hey, no worries.  We love our users and are happy that they are forgiving of our mistakes.  When someone complains we take it as at least that means there is something they like about the product and wish it worked better.  If we get no complaints/issues then obviously nobody is using it :)

@ibuildthecloud i tested it with 1.9.1 1.10.0 and 1.10.1 on Ubuntu 15.10 and OpenMandriva 2014.2
Issue not in host system but in docker, they changed something in containers data and new rancher can't parse it.

Ubuntu server 15.10
Stats in pending state too.
root@ub0:~# docker version
Client:
 Version:      1.10.1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   9e83765
 Built:        Thu Feb 11 19:32:54 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   9e83765
 Built:        Thu Feb 11 19:32:54 2016
 OS/Arch:      linux/amd64

Btw i found weird thing.
One of my hosts still live with 1.9.0 and if i switch to 1.9.0 host and go back to 1.10.x i see stats.

issue in Cadvisor
2016-02-17 09:23:53,626 INFO process-manager [140370331438288] [process_manager.py:65] Launching ['cadvisor.sh', 'cadvisor', '-logtostderr=true', '-listen_ip', '<IP_ADDRESS>', '-port', '9344', '-housekeeping_interval', '1s', '-docker_root', u'/var/cache/docker']
2016-02-17 09:23:53,627 INFO process-manager [140370331438288] [process_manager.py:68] Launched ['cadvisor.sh', 'cadvisor', '-logtostderr=true', '-listen_ip', '<IP_ADDRESS>', '-port', '9344', '-housekeeping_interval', '1s', '-docker_root', u'/var/cache/docker'] as pid 4048
016-02-17 09:23:55,627 INFO process-manager [140370331438288] [process_manager.py:79] Process 4048 is dead, return code 255
2016-02-17 09:23:55,628 INFO process-manager [140370331438288] [process_manager.py:65] Launching ['cadvisor.sh', 'cadvisor', '-logtostderr=true', '-listen_ip', '<IP_ADDRESS>', '-port', '9344', '-housekeeping_interval', '1s', '-docker_root', u'/var/cache/docker']
2016-02-17 09:23:55,629 INFO process-manager [140370331438288] [process_manager.py:68] Launched ['cadvisor.sh', 'cadvisor', '-logtostderr=true', '-listen_ip', '<IP_ADDRESS>', '-port', '9344', '-housekeeping_interval', '1s', '-docker_root', u'/var/cache/docker'] as pid 4082
2016-02-17 09:23:57,629 INFO process-manager [140370331438288] [process_manager.py:79] Process 4082 is dead, return code 255

Well, i fixed this issue in my host
Culrpit is here
https://github.com/rancher/rancher/blob/master/agent/Dockerfile#L18

Let me explain what's going wrong with 1.9.1 and 1.10.x dockers and why Statistics can't work as expected.
At first look at this string
https://github.com/rancher/cadvisor-package/blob/master/cadvisor.sh#L6
DIR=$(docker inspect rancher-agent | jq -r '.[0].Volumes["/var/log/rancher"]')
It is okay for docker < 1.9.1
but in modern version should be something like this
`DIR=$(docker inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/log/rancher" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent)
Then look this
https://github.com/rancher/rancher/blob/master/agent/run.sh#L157
local dir="$(docker inspect -f '{{index .Volumes "/var/lib/cattle"}}' rancher-agent-state)"
For 1.9.1+ is wrong, should be:
local dir="$(docker inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/lib/cattle" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent-state)"
Why? Docker docs says that after 1.8 they moved to the 'new structure'.
Docker 1.10.1, stats page working as expected

why is this closed?  How do we fix this or what is the work around?

error:
docker run -d -e CATTLE_HOST_LABELS='com.XXX.role=master&com.XXX.awszone=a' --privileged -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/rancher:/var/lib/rancher --name rancher-agent-core-000 rancher/agent:v0.9.2 http://rancher-server.mgmt.XXX.com:32772/v1/scripts/905D7A51624CB1B8E5FC:1456347600000:A6kCzL0d4QW78fau5uzwSJzJNSM

Launch 1.10.x + Ubuntu 15.x + EC2
docker run -d -e CATTLE_HOST_LABELS='com.xxx.role=master&com.xxx.awszone=a' --privileged -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/rancher:/var/lib/rancher --name rancher-agent-core-000 rancher/agent:v0.9.2 http://rancher-server.mgmt.xxx.com:32772/v1/scripts/905D7A51624CB1B8E5FC:1456347600000:A6kCzL0d4QW78fau5uzwSJzJNSM

What is the release mechanism for your change to the agent docker image? I don't see a pull request or reference here yet you closed this ticket.

@composer22 Where do you see that the issue is closed?

@deniseschannon Sorry. My misread.
Here is some additional testing info.
systemd logging driver with Docker 1.10.x daemon
running rancher/agent:v0.9.2
shell into the agent container....
This build appears to use when I log in:
#docker --version
Docker version 1.6.0, build 4749651

although...
# ls -lah docker*
-rwxr-xr-x 1 root root 15M Feb  2 21:33 docker
-rwxr-xr-x 1 root root 29M Feb  2 21:34 docker-1.9

#docker-1.9 --version
Docker version 1.9.1, build a34a1d5

Experiment based on cadvisor-package/cadvisor.sh and proposed changes:
# 1.6 w/ current:
docker inspect rancher-agent | jq -r '.[0].Volumes["/var/log/rancher"]'
/var/log/rancher

# 1.6 with proposed change:
docker inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/log/rancher" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent
null

# 1.9.1 with current:
docker-1.9 inspect rancher-agent | jq -r '.[0].Volumes["/var/log/rancher"]'
null

# 1.9.1 with proposed change:
docker-1.9 inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/log/rancher" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent
/var/log/rancher

moving on to rancher/agent/run.sh
# 1.6 with current:
docker inspect -f '{{index .Volumes "/var/lib/cattle"}}' rancher-agent-state
/var/lib/docker/volumes/609f517a8fb81d1fd02d812be45e0b143a43589ba259b10d40850d230ae83b5c/_data

# 1.6  with proposed change:
docker inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/lib/cattle" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent-state
null

# 1.9.1 with current:
docker-1.9 inspect -f '{{index .Volumes "/var/lib/cattle"}}' rancher-agent-state
Template parsing error: template: :1:8: executing "" at <.Volumes>: Volumes is not a field of struct type types.ContainerJSON

# 1.9.1 with proposed change:
docker-1.9 inspect --format '{{ range .Mounts }}{{ if eq .Destination "/var/lib/cattle" }}{{ .Source }}{{ end }}{{ end }}' rancher-agent-state
/var/lib/docker/volumes/609f517a8fb81d1fd02d812be45e0b143a43589ba259b10d40850d230ae83b5c/_data

@composer22
this issue is complex issue.
Well, part of this is connected to wrong PATH's detection, where
docker version |grep Client\ version | cut -d":" -f2
can't grep anything
and second part connected with websocket.
If you want, guys, i can push my own image where issue fixed.

@fedya
No rush, but it would be nice. Just ping us here when you get some time.
Nothing is ever simple :dancers:

@fedya, docker inside the rancher agent is docker 1.6, which will use the API from 1.6 to talk to a Docker daemon regardless of version(so long as its greater). So it will continue to be able to use the current grep and .Volumes. It looks like your testing is done with both a newer client and newer Docker version and would explain what you are observing.
The Docker version check is only to make sure that Docker 1.6 is less then the server version. If its not we die early and the agent will not start. After that, we do not use that command for anything else.
The PR for agent/run.sh and the suggestions for the cAdvisor script will be needed once we upgrade the base docker in the rancher/agent container.
With Docker 1.10.x our suspicion it is the version of cAdvisor that needs to be updated. We have seen errors in the rancher-agent saying it can't get file system stats, and based on cAdvisors releases, they had issues to resolve with 1.10.x.
Which OS are you you running?

:+1:

sorry been offline and busy.
Running on Ubuntu 15.10 Wily

related to #3384

interesting if its only a package change

Tested with latest build from master:
Set up -  Hosts - Ubuntu 15.10  with docker - 1.10.3
Able to view graphs  for cpu , memory,network, storage for containers and host,

thanks sangeethah

@sangeethah, unfortunately i still have this error with rc1:
Rancher	v1.0.0-rc1
Cattle	v0.156.2
User Interface	v0.96.0
Rancher Compose	v0.7.3-rc2
rancher/agent:v0.11.0
Ubuntu 14.04.4 LTS  -Linux 3.13.0-24-generic #46-Ubuntu SMP Thu Apr 10 19:11:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Docker version 1.10.3, build 20f81dd

@MichaelErmer can you clarify which error/behavior you are seeing?
Can you attach logs from the rancher-agent and/or rancher/server that show the errors?

@MichaelErmer Ubuntu 14.04.4 never had an issue with stats not showing up.  Sleeping 1 second and trying again." Attempt=7 reportedUuid="83fbcf8f-769d-4e8d-ba1f-3fadbfcfaa0d"
time="2016-03-23T18:30:11Z" level="info" msg="Host not registered yet. Sleeping 1 second and trying again." Attempt=8 reportedUuid="83fbcf8f-769d-4e8d-ba1f-3fadbfcfaa0d"
time="2016-03-23T18:30:12Z" level="info" msg="Connecting to proxy."

This seems to be broken again using docker 1.11.0

@StorminGorman are u using an nginx proxy?

@StorminGorman @MichaelErmer This is a known issue for Docker 1.11 and v1.0.1. v1.0.1 supports Docker 1.10.3.

@StorminGorman @MichaelErmer This is a known issue for Docker 1.11 and v1.0.1. v1.0.1 supports Docker 1.10.3.

Is there an open issue? Should this issue be re-opened?

https://github.com/rancher/rancher/issues/4406


alias-model-in-controller to restrictive?

I just started using eslint-plugin-ember. One thing I noticed is that i get a lot of alias-model-in-controller errors. The rule makes sense, but some times we have routes where we're not interested in the model. e.g a login route or a forgot password route.
I wonder if we have any alternative. Maybe detect if the model hook was implemented or not?

We've run into the same thing. I think that although it would be nice, that type of check is out of the scope of linting.
As a solution for this and another issue we've considered creating a set of blueprints that:

Follow rules so that a freshly generated file does not have lint failures.
Optionally? include an eslint disable for certain rules like alias-model-in-controller

Hey @miguelcobain, I don't think we can check in controller if model hook is implemented on corresponding route, unfortunately..
All of those rules are not mandatory however. You can always disable any rule in .eslintrc or per file using /* eslint-disable ember/alias-model-in-controller */. I don't see any better solution to this problem at this moment.
@scottkidder Blueprints' topic is something I'd rather keep it in another issue as proposal to consider :)

Absolutely. What I did was to disable it globally. But I can imagine a good workflow to disable it on a controller by controller basis.
Feel free to close this issue if no further action is required.


Update overview-office-cloud-policy-service.md

Updated requirement statement regarding Azure AD group support to address customer questions on using cloud-only versus synchronized groups.

Need to change edit.


mis-name for vector mask instruction vmxnor.mm

In category of Vector Mask-Register Logical Instructions, there are both xor and not_xor instructions:
vmxor.mm vd, vs2, vs1
vmxnor.mm vd, vs2, vs1
The latter separates x-or with the additional "not", which seems a typo since xor better be kept together.

xor(a, not(b)) and not(xor(a, b)) are equivalent, and XNOR is a common way of describing this operator (see e.g. https://en.wikipedia.org/wiki/XNOR_gate)


size of tensors in cosine_simiarity function

Hi , I'm trying to understand the code in :
loss/nt_xent.py
we are sending "representations" on both arguments
    def forward(self, zis, zjs):
        representations = torch.cat([zjs, zis], dim=0)
        similarity_matrix = self.similarity_function(representations, representations)

But when receiving it in cosine_similarity func somehow the sizes are:
(N, 1, C) and  y shape: (1, 2N, C), how can it be double if you sent the same argument
    def _cosine_simililarity(self, x, y):
        # x shape: (N, 1, C)
        # y shape: (1, 2N, C)
        # v shape: (N, 2N)
        v = self._cosine_similarity(x.unsqueeze(1), y.unsqueeze(0))
        return v

Thanks for your help.

@BattashB I don't understand it either

I don't understand it either

I have the same question

I have the same question

@BattashB
I think this should be just a small mistake, the correct comment should be the following，same for the  _dot_simililarity function
    def _cosine_simililarity(self, x, y):
        # x shape: (2N, 1, C)
        # y shape: (1, 2N, C)
        # v shape: (2N, 2N)
        v = self._cosine_similarity(x.unsqueeze(1), y.unsqueeze(0))
        return v

@BattashB
I think this should be just a small mistake, the correct comment should be the following，same for the  _dot_simililarity function
    def _cosine_simililarity(self, x, y):
        # x shape: (2N, 1, C)
        # y shape: (1, 2N, C)
        # v shape: (2N, 2N)
        v = self._cosine_similarity(x.unsqueeze(1), y.unsqueeze(0))
        return v

Hello guys, that is a general message to say that I have refactored the whole project. I believe the project is much easier to understand now. Please have a look at the new impl and free to submit PR if you find any bugs. Thanks.

Hello guys, that is a general message to say that I have refactored the whole project. I believe the project is much easier to understand now. Please have a look at the new impl and free to submit PR if you find any bugs. Thanks.


Include columns with boolean tests in filter_expression output

Currently columns with IS true/false or IS NOT true/false are ignored in filter_expression output. Since we are including tests for IS null, it seems reasonable to include the boolean tests as well.

@pashamur Nice, thanks for noticing & submitting the patch!


Deprecating hashbrown reexports

Objective

The exported hashtypes are just re-exports from hashbrown, we want to drop that dependency and (in the future) let the user import their own choice.
Fixes #11717

Solution

Adding a deprecated tag on the re-exports, so in future releases these can be safely removed.

Sorry, why only the stable ones: as in, the other 2 seem to only be also just a reexport without any added functionality

Yeah, we use the faster ones internally all over the place, and they're a good default for games.

Let me know if the wording for the deprecated note is okay.

Done, should be ready to go!

Looks great, thanks for the prompt and friendly responses to the reviews :)


Some simplification of ExecutionPlan API

Fixes #?
Context
Previously selectNext() would return nodes that are already complete (don't need to be executed), for example if a task in an included build happened to already run to build some plugins, or nodes that must not run because their dependencies  failed. In this PR, only return nodes that are ready to start execution.
Also, make this API more explicit about why a node could not be selected, so the worker can make better decisions about whether to stop taking work or wait for more work.
Also, do not add nodes to the plan at all if they have already completed at the time the plan is assembled.
Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test and merge

OK, I've already triggered a build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.


puzzles 10274

I guess the most recent Debian release is from before they switched to git, so I used that revision as the version number. The git repo has no tags yet.
The automatic .app bundle caveats made these seem redundant.

Thanks!


I tried to run manual_contro.py in scenario runner and I am getting this error "    from examples.manual_control import (World, HUD, KeyboardControl, CameraManager, ModuleNotFoundError: No module named 'examples'

I am able to run "python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld" succesfully but when I try to run the manual_control I get this no module error. I have added the python paths as directed in the getting started page.
export UE4_ROOT=~/UnrealEngine_4.26  export CARLA_ROOT=/home/*username*/carla export SCENARIO_RUNNER_ROOT=/home/*username*/scenario_runner export PYTHONPATH=$PYTHONPATH:${CARLA_ROOT}/PythonAPI/carla/dist/carla-0.9.12-py3.6-linux-x86_64.egg export PYTHONPATH=$PYTHONPATH:${CARLA_ROOT}/PythonAPI/carla export PYTHONPATH=$PYTHONPATH:${CARLA_ROOT}/PythonAPI/carla/agents

Try to add "export PYTHONPATH=$PYTHONPATH:${CARLA_ROOT}/PythonAPI/examples"

As a follow up to what Kron610 said, we recently removed that dependency (this is the commit, as it wasn't really a good idea to begin with.

Hi @glopezdiest
I'm facing the same issue. I am on windows and after a added:
set PYTHONPATH=%PYTHONPATH%;%CARLA_ROOT%\PythonAPI\examples\
The error persists. Any idea what is causing the issue? I'm usgin Scenario Runner 0.9.12

HI @LucasFKobernic, I am facing the same error. Did you find any fix?. Thanks


TypeError: 'unicode' object does not support item assignment

The Issue
Unable to publish file because of TypeError
Steps to reproduce

Attempt to publish a file

Expected behaviour
The file should be published to the network.
Actual behaviour
Console output when running publish command:
017-03-17 01:10:43,670 INFO     lbrynet.lbrynet_daemon.Daemon:1738: Publish: {'fee': None, 'bid': 1, 'metadata': {u'ver': u'_0_0_1', u'description': u'A image obtained from a computer glitch showing Heavy from Team Fortress 2 holding a glowing dove.', u'license': u'Creative Commons Attribution 3.0 United States', u'author': u'Stephen', u'title': u'St. Hoovy', u'language': u'en', u'nsfw': u'False', u'content_type': u'Image', u'sources': u''}, 'name': u'hoovy', 'file_path': u'/home/stephen/Pictures/hoovy.jpg'}
2017-03-17 01:10:43,670 INFO     lbrynet.lbrynet_daemon.Publisher:35: Starting publish for hoovy
2017-03-17 01:10:56,128 INFO     lbrynet.lbryfile.EncryptedFileMetadataManager:243: Saving sd blob hash c083bd36127b63ef4afa8fc737b9417d3ed4776a76feba45bcff159e65518f5fd70be86f373cef441db895b48705f9e9 to stream hash 15a96713badfceddebc3a6cae3f472a34bf10e623b9b9188423257b7c69fb0ffb0454565ee74d8b85136cd46c56de912
2017-03-17 01:10:56,135 ERROR    lbrynet.lbrynet_daemon.auth.server:352: Failed to process publish: 'unicode' object does not support item assignment
Traceback (most recent call last):
  File "site-packages/twisted/internet/defer.py", line 1297, in _inlineCallbacks
  File "site-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
  File "site-packages/lbrynet/lbrynet_daemon/Daemon.py", line 824, in _publish_stream
  File "site-packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
  File "site-packages/lbrynet/lbrynet_daemon/Publisher.py", line 46, in publish_stream
TypeError: 'unicode' object does not support item assignment

System Configuration

LBRY Daemon version:

[
  {
    "lbrynet_update_available": false,
    "lbrynet_version": "0.9.0",
    "lbryum_version": "2.7.13",
    "os_release": "4.4.0-66-generic",
    "os_system": "Linux",
    "platform": "Linux-4.4.0-66-generic-x86_64-with-Ubuntu-16.04-xenial",
    "remote_lbrynet": "0.9.0",
    "ui_version": "not loaded yet"
  }
]

u'ver': u'_0_0_1'

You experimenting with lbryschema? If so, it isn't supported yet - and publish will autofill this field.
There's a few parameters you've got that are automatically filled in or have the wrong type, try
{
    'bid': 1.0,
    'description': 'A image obtained from a computer glitch showing Heavy from Team Fortress 2 holding a glowing dove.',
    'license': u'Creative Commons Attribution 3.0 United States',
    'author': u'Stephen',
    'title': u'St. Hoovy',
    'language': 'en',
    'nsfw': False,
    'name': 'hoovy',
    'file_path': '/home/stephen/Pictures/hoovy.jpg'
}


chore: lint with flake8 and black 🔥

Description
Fixes #7

Hello @HarshCasper! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file metacall_jupyter/install.py:

Line 70:80: E501 line too long (87 > 79 characters)

In the file metacall_jupyter/kernel.py:

Line 22:80: E501 line too long (88 > 79 characters)

In the file setup.py:

Line 9:80: E501 line too long (90 > 79 characters)


Crash: AttributeError: 'SyntaxError' object has no attribute 'end_lineno'

Issue
Hi, encountered that error multiple times now. It completely crashes aider and forces me to manually revert the partial changes then relaunch aider.
It seems to happen when gpt4o botched an edit so bad that it ends up creating a syntax error, which is not properly catched by the linter.
Full trace:
Applied edit to VideoFlow.py
Traceback (most recent call last):
  File "/home/USER.local/lib/python3.9/site-packages/aider/linter.py", line 130, in lint_python_compile
    compile(code, fname, "exec")  # USE TRACEBACK BELOW HERE
  File "/home/USERDownloads/VideoFlow/VideoFlow.py", line 39
    Initialize the VideoFlow class with a video path.
               ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/USER.local/bin/aider", line 8, in <module>
    sys.exit(main())
  File "/home/USER.local/lib/python3.9/site-packages/aider/main.py", line 457, in main
    coder.run()
  File "/home/USER.local/lib/python3.9/site-packages/aider/coders/base_coder.py", line 545, in run
    list(self.send_new_user_message(new_user_message))
  File "/home/USER.local/lib/python3.9/site-packages/aider/coders/base_coder.py", line 783, in send_new_user_message
    lint_errors = self.lint_edited(edited)
  File "/home/USER.local/lib/python3.9/site-packages/aider/coders/base_coder.py", line 825, in lint_edited
    errors = self.linter.lint(self.abs_root_path(fname))
  File "/home/USER.local/lib/python3.9/site-packages/aider/linter.py", line 80, in lint
    linkres = cmd(fname, rel_fname, code)
  File "/home/USER.local/lib/python3.9/site-packages/aider/linter.py", line 98, in py_lint
    compile_res = lint_python_compile(fname, code)
  File "/home/USER.local/lib/python3.9/site-packages/aider/linter.py", line 133, in lint_python_compile
    line_numbers = list(range(err.lineno - 1, err.end_lineno))
AttributeError: 'SyntaxError' object has no attribute 'end_lineno'

Version and model info
Aider==0.2.4
Aider-chat==0.36.0
GPT-4o
Edit format: the one by default for GPT-4o

Thanks for trying aider and filing this issue. I've fixed this bug. The change is available in the main branch. You can get it by installing the latest version from github:
python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Add NAdam Baseline

NAdam Baseline
Implementation: Internal NAdam implementation
Tunable hyperparameters: learning_rate, b1, b2, weight_decay
Fixed hyperparameters: epsilon=1e8, eps_root=0.0

Addressed by #306.


"'XMLElement' is ambiguous for type lookup in this context" when compiling for Mac Catalyst

Describe the bug
Compiler complains about "'XMLElement' is ambiguous for type lookup in this context" when compiling for Mac Catalyst
To Reproduce
Steps to reproduce the behavior:

In an iOS project target, enable Mac Catalyst
Compile code that uses XMLElement

Expected behavior
compiles without error message
Environment:

Xcode version: 13.2.1
OS running SWXMLHash: MacOS 12.2.1 running Xcode

Additional context
appears to be a known problem when directly compiling for MacOs. XMLElement Sourcecode says
// Workaround for "'XMLElement' is ambiguous for type lookup in this context" error on macOS.

Confirmed - I put together a quick repro of it up at https://github.com/drmohundro/swxmlhash-test-xmlelement-catalyst-repro.
That being said, it is possible to get around it by scoping the XMLElement with SWXMLHash.XMLElement. See https://github.com/drmohundro/swxmlhash-test-xmlelement-catalyst-repro/commit/07bad9daf75a469f3b9cb96b57ce6c4473172bcd - that compiles for me.
Does that solve your issue?

Yes, replacing XMLElement with SWXMLHash.XMLElement works for me

Great! I'll close this as the only alternative I'm aware of would be a rename... and there have already been multiple renames! (#140, #242).


Hdr.mergemertens.fixalgo

Fix for #5807:

In the MergeMertensImpl::process method, the implementation of the formula to compute the well-exposedness map is false and is missing a call to cv::exp to get a gaussian curve.

OK, I've just reverted the commit.
The current default parameters are not wrong, the point is that it is not the default values recommended by the author of the algorithm.

BTW, Current failures is not related to this PR

thanks! :+1:


Build about this site page

We need text for this. I would also like to see all people contributed in this project acknowledged, similar to https://elect.thematter.co/about.
Possibly, in a long run, we might possibly need a script that automatically pull contributors' names from Github.

Auto pull contributors has been done #50

Close this. Let's update content on #73


[chip-test, spi_device] chip_sw_spi_device_pass_through_flash_model

Test point name
chip_sw_spi_device_pass_through_flash_model
Host side component
Rust?
Opentitantool infrastructure implemented
Yes
Silicon Validation (SiVal)
Yes
Emulation targets

[ ] None
[ ] CW310
[ ] Hyperdebug + CW310

Contact person
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] Test added to dvsim nightly regression (and passing at time of checking)
[ ] For SiVal test cases, test is running relevant FPGA or silicon regression

Duplicate: https://github.com/lowRISC/opentitan/issues/14158
Though looks like it might be closed.


[backport] Remove chainerx.square fallback since it is implemented in C++

Backport of #6823

[automatic post] Jenkins, test this please.

https://github.com/chainer/chainer/pull/6486 must be backported first.

Jenkins CI test (for commit cb7d737d61ea6bc396c66416aec06cd0dc907bf7, target branch v6) failed with status FAILURE.

LGTM!


package created

Sir please have a look at the commit

Never mind, it's way too messed up right now


Backend change to fix the bug of archiving status in raw request.

Fix for iterim status named as Open in rawrequest table. Renamed to Archived.
DOD

[ ] Fix
[ ] Unit Testing

Status changed from Open to Archived.


Restructure CLI arguments

Currently, it's mandatory to use either one of -nt or -t. It makes no sense to use one of those when we only want to print something in the terminal and exit like -la, -ls or the upcoming -hal and -hs.
It's required to make -nt or -t only mandatory when used with any arguments except the ones mentioned above.

Hi, I just came across this. Could I pick this up?

Hi @MohamedYasser97 I would like to be assigned this issue as i would love to contribute to the project.


Convert OpenControl plain-texts to Markdown

Problem statement
NIST published controls (source) are well structured and hierarchical. Our content here, however, is unstructured plain-text.
The plain-text looks nice in TXT editor, however rendering the controls elsewhere (web, word processor) leads into problems with padding, text overflows, alignment etc. Having the unstructured text in our yaml files leaves us with little options, but developing custom parser and re-formaters.
Proposed Solution
Parse NIST structured and hierarchical text to standardized text format.
I considered putting here HTML, Markdown (.md), restructured text (.rst). But ultimately, I believe Markdown is the best fit.

First of all every modern ui framework nowdays offers methods to render markdown nicely
It makes only minor changes to our texts (just adds bullets to the bullet lists)

In the OSCAL repo at https://github.com/usnistgov/OSCAL/tree/master/src/utils/util/publish/XSLT we have XSLT transformations in various flavors and states, which produce HTML from OSCAL sources. They have not been touched in a few months so they might be a little behind. Another utility XSLT in there will convert from HTML to Markdown.
For a one-time conversion, those would be enough to get the job done (with some tuning). To run repeatedly (over for example, resolved OSCAL profile inputs, not just the NIST catalog), you have a choice between the XSLT dependency, and building it on another stack. 😎
Building out and supporting these better is on our (long) list of tasks. So is encouraging parallel implementations. I would be interested in seeing a spec for conversion into .rst. FTM, our XSLT could provide a starting point for an HTML or a Markdown mapping (both pretty simple).

In the OSCAL repo at https://github.com/usnistgov/OSCAL/tree/master/src/utils/util/publish/XSLT we have XSLT transformations in various flavors and states, which produce HTML from OSCAL sources.

Thank You @wendellpiez for bringing my attention to OSCAL repo. Nevertheless, it seems that OSCAL repo contains XSL Transformations that expect XML in OSCAL format. (Noticing xmlns:oscal="http://csrc.nist.gov/ns/oscal/1.0").
While the source XML used by opencontrols, however, is https://nvd.nist.gov/static/feeds/xml/sp80053/rev4/800-53-controls.xml and that one does not seem to be in OSCAL format.
This means, that I would have to go through hurdle of amending the OSCAL XSLT to work with the source xml. In that case, howeve, we would loose the benefits of using OSCAL as we would diverge from it on day 0.
Thus, I am not sure I can see a viable path to adopt OSCAL to build opencontrols data at this point. It seems significantly more effort, than just adding two characters to the build script (this PR adds just 2 characters).

Nevertheless, the OpenControl data seems to be similar to OSCAL, OpenControl data is just much more simpler and easier. Since OSCAL repo contains various transformation to various forms and formats I think I may make a sense for OSCAL to provide transformation to OpenControl as well along all the other transformations. WDYT?

If the existing YAML files are converted to Markdown, would/could that break downstream apps consuming this content? Would it be better to create nist-800053-latest.md files?

This PR edits nist-800-53-latest.yaml along the way of nist-800-53-rev4.yaml. Do you want me to drop edits of nist-800-53-rev4.yaml and keep edits of nist-800-53-latest.yaml only?

If the existing YAML files are converted to Markdown, would/could that break downstream apps consuming this content? Would it be better to create nist-800053-latest.md files?

This PR edits nist-800-53-latest.yaml along the way of nist-800-53-rev4.yaml. Do you want me to drop edits of nist-800-53-rev4.yaml and keep edits of nist-800-53-latest.yaml only?

To give the community a some time to review/comment, why don't we let this sit until Weds 27-NOV? Pending no objections lets merge then.

@isimluk Apologies for my confusion: I had assumed since you referred to the "NIST controls" that you meant OSCAL -- I should have looked at the link and seen the NVD XML. (We have the same data set, with more granular markup and Annex A integrated, in the OSCAL repo.) Of course you are correct that the OSCAL XSLTs will not work satisfactorily, unmodified, starting from another data format.
Maintaining data in OSCAL and transforming "downhill" into simpler formats does make a lot of sense, if you need the complexity. One of the reasons for OSCAL is that NVD XML doesn't give quite enough 'semantic leverage' for the profiling functionality that OSCAL is intended to support.

Has sat for a few weeks with no comment/objections. Merging!

In the OSCAL repo at https://github.com/usnistgov/OSCAL/tree/master/src/utils/util/publish/XSLT we have XSLT transformations in various flavors and states, which produce HTML from OSCAL sources. They have not been touched in a few months so they might be a little behind. Another utility XSLT in there will convert from HTML to Markdown.
For a one-time conversion, those would be enough to get the job done (with some tuning). To run repeatedly (over for example, resolved OSCAL profile inputs, not just the NIST catalog), you have a choice between the XSLT dependency, and building it on another stack. sunglasses
Building out and supporting these better is on our (long) list of tasks. So is encouraging parallel implementations. I would be interested in seeing a spec for conversion into .rst. FTM, our XSLT could provide a starting point for an HTML or a Markdown mapping (both pretty simple).

@wendellpiez, bumping this year long discussion. I have implemented conversion from OSCAL Catalog to OpenControl Standard the same way you mentioned here in the thread.
You can see the results at https://github.com/opencontrol/standards/pull/14 If you want to see the code, you can start at https://github.com/GoComply/oscalkit/blob/master/pkg/opencontrol/standard.go#L32


Upgrade to rails 7

Trello
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Tested on Integration, LGTM.


feat: Readme setup

Fixes #3397
Describe the changes you have made in this PR -
added command to setup postgres in setup.md markdown file
Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tachyons @vedant-jain03  WDYT?


Add a CoffeePot

Describe the solution you'd like
A CoffeePot would be a simple Thread wrapper for Tasks. One advantage: Automatic Integration for the TaskPriority enum for Task#priority value.

API Declaration:

CoffeePot.start(Task<?>)
*CoffeePot.startAll(TaskRegistry)
CoffeePot.interrupt(Task<?>)
CoffeePot.interruptAll(TaskRegistry)


Adding Contributor section in readme  ( Automatically )

I will like to add a feature this will update contributor list in read me automatically !! Will start to work on this issue as soon as i get assigend !!

Go ahead @rohank2502

Thanks !!
On Fri, Mar 12, 2021 at 8:06 PM Tejas1510 @.***> wrote:

Go ahead @rohank2502 https://github.com/rohank2502
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Tejas1510/Athavani/issues/117#issuecomment-797528540,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASIJKMYKNKCMWEUJTKISMOLTDIRFRANCNFSM4ZCLPGQA
.

Its already present !!


Parse error lines cols

Added line and column number to parse error

defined input position struct in exceptions.hpp (maybe there is a better place?)
used by lexer to record line / column (based on '\n')
used by parse_error to report line / column

I removed the raw char count from the error message; column will work if there are no lines. Not sure if we might still want to include it.
The position is added as a public member of the exception; the client can catch & extract it if they want.
I left a parse_error::create function that only takes the char count; wasn't sure what to do with, e.g., the binary reader.
All tests passed / amalgamated.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[ ]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.
[ ]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

@efp Can you check the errors that Travis and AppVeyor detected?

Aha, I didn't run amalgamate before the unit tests. Have to update some call signatures in the tests.

Gah, I'm down to having to change all the unit test strings from parse error.
I think it'd be better if the exception class stored the pieces of the error message... along with 'id', 'type', 'desc', etc., and tested against those, instead of comparing string literals. Then you could tweak the error messages without re-writing any unit tests.
To not have to deal with changing interfaces in sax_parse (I don't know what that is for) I made an explicit conversion from input_position to size_t (#chars read).

I feel like I don't know the use cases well enough to know how best to proceed.
Thus far, only parse errors thrown from parser.hpp will report the line col format (not from binary_reader or json_sax). That was all I needed for my use case--just reading a json text file. So one approach is to change the unit test strings just for those. I did one such case in the previous commit.
Or perhaps we'd want all the errors to give line and col; in which case I'd need to change the call signatures from the other objects and change all the unit test strings. Most of them only test one line, so could be mass replaced, but some have '\n' characters in there.
In either case, a few additional tests to see the lines/cols get processed correctly would be in order.

Or perhaps we'd want all the errors to give line and col; in which case I'd need to change the call signatures from the other objects and change all the unit test strings. Most of them only test one line, so could be mass replaced, but some have '\n' characters in there.

Which errors do you mean?

@efp What can we do to get this PR forward? Do you need any assistance?

Sorry, I got stuck on the question of what to do about the error message unit tests. Since some of them changed.
I'm just not familiar enough with all the use cases to know the best way to proceed. All I ever do is read a JSON text file. In which case, I like line * col of the error reported.
The easiest way to proceed would be to not change the error messages, but just let the user catch a parse_error and use the stored line & col information if they so please.

I see. Would you mind if I would try to make a PR myself?

Gosh no, have at it.

@efp I opened #1282 with your ideas. It would be great if you could have a look. Then maybe we can close this PR and focus on #1282.


Add note about Pipeline API recommended usage

I think it's important to make this clarification. Without it I fear people may get excited about the shiny new thing or go too wild with it just because of how much it can do, which IMO would be a mistake. I view this as an advanced feature, like descriptors or something: when you need it it's awesome it's there and saves you a lot of pain, but use it everywhere for everything and you'll end up with a spaghetti codebase that's hard to navigate and reason about.
Happy to word this comment differently or even give a concrete example of what I mean by UserIn and UserOut.

Added an example

Happy to merge once we fix CI :)


Unbump version to 0.0.0

This PR changes the library-wide version to 0.0.0

This has two approvals and a passing CI and doesn't need a ChangeLog entry or new tests, so "ready for merge".