Expose placeholder settings to cli flags

Now we have dmenu mode (#47) would be nice to be able to change placeholder of walker with cli flag. Currently the only option is to create separate config file and pass it to --config flag.
-p | --placeholder
Example:
echo "chocolate\nvanilla" | walker -d -p "Pick you favorite ice cream"

Is there any other settings that could be exposed to cli flags which would be useful in combination with dmenu mode?

-p, --placeholder has been added.


.io is 404

Webpage (github.io)  in repo description is 404

Thanks. I updated it to https://usgs-r.github.io/scipiper/task_plans.html. We don't have an index file and were struggling to make that easy to build/update for some frustrating, silly reasons last time I tried. I expect to try again sometime in the future. In the meantime, vignettes (the contents of the github.io page) can be listed from R with vignette(package='scipiper') and accessed either within R or by typing in a specific vignette name into https://usgs-r.github.io/scipiper/[vignette_name].html


Create a header / navigation bar.

Suggestion/Improvement
🌟 Currently this is just a button! Create a UI feature in this project. This could be a navigation bar / header, a footer, or improving the existing hero.
Description
Make this starting template feel more complete and exciting to work on.
Motivation
This template needs to be improved so it is a more viable starting point for Hackathon participants.
Implementation (if applicable)
Code should be clearly written, with good comments, allowing it to be accessible to beginners. Please provide a screenshot in your PR of design changes.

i can work on this to create a navbar component,  you can assign me this task
please add the hacktoberfest tag as well, new to open source and want to add this as my PR

@SumitMangrati thanks for your interest. We are prioritising our community members for assigning issues and approving pull requests. You are welcome to participate by leaving constructive feedback on community member PRs.


Improvement for k8s.io/docs/setup/production-environment/tools/kubeadm/high-availability/

Weave Net has announced the end of service for Weave Cloud. As an impact, the old weave net installation link mentioned in the documentation won’t work anymore: -
kubectl apply -f "https://cloud.weave.works/k8s/net?k8s-version=$(kubectl version | base64 | tr -d '\n')"
Instead of that, update the document with below latest link to install the weave net:
kubectl apply -f https://github.com/weaveworks/weave/releases/download/v2.8.1/weave-daemonset-k8s.yaml
Reference links: -
https://www.weave.works/docs/net/latest/kubernetes/kube-addon/#-installation
https://github.com/weaveworks/weave/releases

/language en
/sig docs

Hi @area51b , thanks for your contribution!
Here are the steps for installing weave net and it has a link that redirects to on this page which has the correct link that you mentioned.
Are you talking about any other kuberentes documentation, if so then please mention the related page.


Crashes on startup on High Sierra

Markoff stopped working when I upgraded to High Sierra. It no longer can be used to open .md files, and trying to open the Markoff application from the launcher produces a "Markoff quit unexpectedly" crash report.
This is the current version available through the Mac App Store. 1.0.1, I believe. I tried uninstalling it and installing again; same thing happens. I'm attaching the crash details here in a text file.
I hope this can be fixed. And thank you for this little app, it is lovely, I'm going to miss it very much.

I have the problem on macOS Sierra.

Ditto

Known issue. Please check the list of issues for other duplicates. 2.0 will get this sorted out but won't likely be distributed through the app store.


incompatibility with iRig

Mumble for iOS doesn't handle the iRig device well. When the iRig is connected and mumble set to continuous audio, my audio cuts in and out almost like mumble thinks the device is disconnecting/reconnecting repeatedly. In some cases audio doesn't work at all.
iRig -> http://www.amazon.com/IK-Multimedia-iPhone-Android-Devices/dp/B007534LFK/ref=sr_1_4?ie=UTF8&qid=1438696119&sr=8-4&keywords=irig+2
If needed, I'd be willing to donate the funds for the purchase of one of these if needed to resolve this :) :+1:
Latest Version of Mumble for iOS
Testing with iOS 7.1.1 - 8.4

Hello @supawiz6991
I'm willing to help take a look at this, but I don't own the hardware.
I've created an Amazon wishlist with the item on it:
http://www.amazon.co.uk/registry/wishlist/25AKONNY0QWGE
Do I need an XLR microphone to test it, though? I don't have one either. (So if needed, I can add that to the wishlist as well).

Yep, you will need an XLR Mic and cable. These two should work:
http://www.amazon.com/CBI-MLC20-Microphone-Cable-Foot/dp/B000VJJQUU/ref=sr_1_6?ie=UTF8&qid=1440611678&sr=8-6&keywords=XLR+Mic
http://www.amazon.com/Pyle-Pro-PDMIC58-Professional-Handheld-Microphone/dp/B003GEBGA0/ref=sr_1_1?ie=UTF8&qid=1440611678&sr=8-1&keywords=XLR+Mic
Add it to the list and I'll get it taken care of! :)

@supawiz6991 Added equivalently priced items from Amazon.co.uk, since that's where the wishlist lives. :-)

Went to buy the gear for you but you didnt enable third party address sharing. Once you enable that I can buy those items for you.
http://www.amazon.com/gp/help/customer/display.html?nodeId=3058771

I have now added an address, but no enabled third-party address sharing (which seems to be for if you purchase from the marketplace instead of Amazon). Let me know if this works, or if I'll have to enable it.

Purchased and on its way to you (Should arrive in 3-5 days)! Thanks in advance for looking into this issue and enjoy the gear!

 :)

Hi @supawiz6991,
Sorry for being a bit uncommunicative...
I can confirm that I have received the iRig, mic and cable.
I have not yet had time to play with it yet.
I hope to find time later in the week, or during the weekend. Thanks for your patience, and for the hardware to test on... Much appreciated.

No Worries :) Your willing to look into this issue for me and chances are I'm the only one affected by it (or at least the only one who's made and issue about it) so I can't complain! You could have just said "oh well" and been done with it sooo yeah...thanks! :) :+1:

heyo! Just wanted to check in and see if you have had a chance to look at this yet!

bump :)

I have had a chance to look at it, and I am in the process of trying to fix it...
I was able to reproduce it, but it doesn't -- at least for now -- seem restricted to the iRig.

Thanks for the update! Very interesting...that's the only device I've notice the issue with but looks like the fix will have a wider benefit than I originally thought!

Heyo! Wanted to check in and see if you had been able to finish the fix for this?

Hi @mkrautz !
Any update on a fix for this?

Any update on this?

Apologies for the lack of communication.
All my time to work on anything Mumble-related as of late has been on the main desktop client.
I hope to have some spare time to hack on this again soon. :-(

Hey @mkrautz any update?

Unfortunately, the situation hasn't changed since last time.
And boy do I feel terrible about it. Especially since you've donated a significant amount in order to have the bug fixed.
I hope to look into this very soon. So sorry.

Hey, any change on this?
Also, fyi, while setting up a new ipad at work, I got a popup from apple regarding the mumble app that said "This app will not work for ios 11. The developer will need to update it"
Do you see a future for the mobile app? I'm hoping there is because at this point (IMO) there is no good mobile app alternative. I do understand though that 1. these are free apps and 2. you are only one person and can only do so much development on your own...so if the app does have to die for now I do understand. :)

I can help develop however I am not a member of the developer program so won't be able to publish, I do have the iOS 11 public beta and I'll endeavour to update the app and submit a pull request with enough time before iOS 11 launches.

I believe we've already converted the code to build in 64-bit mode.
The remaining problems would be to ensure we scale to newer devices, new icons/launchscreens, and anything else that is now required to get into the App Store.
Any help is appreciated!

I'm happy to hear the app is under a good amount of development!!!!
Any idea if a fix for this issue will be in the next release? I would love to be able to dump skype and return to mumble :)


RFC7084 compliant DHCPv6 behavior

Hey there,
I haven't configured DHCPv6 yet, however I stumpled across the following section in your FAQ:
The BNG Blaster expects an ICMPv6 router-advertisement with other-config flag before it starts sending DHCPv6 within a PPPoE session.
Personally I think that the RFC4861 is a little bit misleading here, because it wasn't written with DHCPv6 in mind, so it's unclear if DHCPv6-PD should be started by receiving the O-flag or the M-flag.
However RFC7084 states in WPD-4 the following:
WPD-4:  By default, the IPv6 CE router MUST initiate DHCPv6 prefix
           delegation when either the M or O flags are set to 1 in a
           received Router Advertisement (RA) message.  Behavior of the
           CE router to use DHCPv6 prefix delegation when the CE router
           has not received any RA or received an RA with the M and the
           O bits set to zero is out of scope for this document.

So from my understanding DHCPv6-PD should also be instantiated when receiving the M-flag. Or is there a good reason not to do? :)
Fun Fact:
The obsoleted RFC6204 WPD-4 stated that DHCPv6-PD should always be initiated regardless if it receives a Router Advertisment with an O- or M-flag. So as soon as a CPE supports IPv6 it should request a prefix using DHCPv6 from the service provider. As far as a I rember is this still the default behavior of a Fritz!Box.

Most relevant for this use case is TR-177 but I will do some investigation here.
https://www.broadband-forum.org/download/TR-177.pdf

https://datatracker.ietf.org/doc/html/rfc4861#section-4.2 also says that either should be accepted:
"If the M flag is set, the O flag is redundant and can be ignored because DHCPv6 will return all  available configuration information."
Or as said a slightly different way at https://blog.ipspace.net/2012/11/ipv6-router-advertisements-deep-dive.html
"The O flag is meaningless if the M flag is set, as the O flag is basically a subset of the M flag (broken OS stack might require both though)".
FWIW, TR-177 just seems to talk about the O-flag:
"The BNG generates (according to RFC 4861 [12]) an IPv6 MC RA message to the FF02::1 “All link-local nodes” MC group.  The BNG includes the /64 prefix of the access line in the Prefix Information Option (PIO) of the RA and sets the ‘A’-flag of this PIO to ‘True’ in order to advise the RG or host to use the included PIO for the SLAAC of its WAN GUA. Besides that the ‘Is-router’ flag and the O-flags inside the RA are also set to ‘True’ in order to signal that the BNG is the Default Router and that more information can be provided by DHCPv6. This RA message is encapsulated in a newly created IPv6 datagram with the Line Identification Option (LIO) and is sent to the AN, according to RFC 6788 [25]"

Fixed in latest dev branch.

Fixed in 0.7.9!


Questions from infoq

Here are the questions raised by infoq.com

What are the considerations you had while choosing GoBGP compared to other similar BGP daemons like OpenBGPD?
Do you have plans for supporting IPv6 addresses in Porter in the future? What challenges do you foresee?
MetalLB - a similar project - supports a few cloud platforms. It does not support most because those platforms don’t give access to network layers that are required for it to function. Can Porter run on self-managed clouds like OpenStack?
What kind of monitoring and metrics are available for Porter? Are they Prometheus compatible?

Feel free to leave your comments.

GoBGP is implemented in the go language , easy to integrate , follow-up porter can also support a variety of daemon that implementations the BGP protocol
Yes, IPv6 will also be supported, it's not technically difficult at the moment, it's just that many environments are still ipv4, so it's not that urgent.
Porter was designed to support load balancing in a physical environment, and you can use this cloud-controller-manager for load balancing on IAAS such as openstack.


Make Nimble a private (test-only) dependency

Intention is to use this for unit tests, but not publicly depend on it.
Also removes the workspace.
Fixes #3.

:rocket:


[BUG] - Unclear --signed-tx-file argument to governance verify-poll

Internal
Area
Other   Any other topic (Delegation, Ranking, ...).
Summary
The cardano-cli governance verify-poll has --signed-tx-file FILE argument. The corresponding helptext states:

Filepath to a signed transaction carrying a valid poll answer.

However the FILE value can be both signed tx file and tx body. The verify-poll command checks the "required signers" listed in the tx, not the actual signatures.
Expected behavior
The argument should be named e.g. --tx-file and command help should state that the argument accepts both signed tx and tx body.
System info:

OS Name: Linux
OS Version: Fedora 37
Node version: 6f05a08e3053026eed78bd808ee3df0fdff7607b
CLI version: 6f05a08e3053026eed78bd808ee3df0fdff7607b

Fixed on master by https://github.com/input-output-hk/cardano-node/pull/5184


Implement XYZ order in quaternion.toEuler

I have spend few crazy hours trying to understand what is wrong in my application. When you want to convert from Euler to Quaternion you have quaternion.toEuler and quaternion.setFromEuler. And while for the first one default order is YZX, this is not the same for inverse transformation - you have to pass XYZ in that case. This is very misleading.
Right now the error is Euler order XYZ not supported yet.
The workaround is to use something like this:
physic.rigidBody.quaternion.toEuler(new Vec3(rotation.y, rotation.z, rotation.x))
instead of what would be easier and more intuitive:
physic.rigidBody.quaternion.toEuler(rotation)
I would create a pull request for this but I'm totally zero in math *(

Yes, I agree that both should be the same order by default. Or maybe toEuler should be removed?
if you’re using quaternion to euler, in my experience something might be badly designed in your code. Some quaternions can yield multiple euler angles. This is why I’ve stopped using toEuler() code completely, in any context, and only use euler angles as input. Usually there is an alternative solution. How are you using euler in your application?
Just checked Bullet physics, and I can find fromEuler() equivalents, but no toEuler()... http://bulletphysics.org/Bullet/BulletFull/classbtQuaternion.html
If you still need toEuler, a workaround is to use your rendering library quaternion/euler math and then copy the result into the cannon.js quaternion. I know Three.js has good quaternion/euler support.

I have an Entity Component System architecture in my game and I have rotation component which had x, y and z properties. Render and Physic system should read from it and update. In physic system  I used quaternion to rotate things so I have to make transformation from euler to quaternion and backward  (using toEuler and  fromEuler). Now I switch rotation component to quaternion, as you offered and now I don't need those transformation any more. Everything works fine except that quaternions operations is a bit more complicated for some one without basic math knowledge.

This video helped me, might help you as well
https://youtu.be/SCbpxiCN0U0

On 18/07/2018, at 8:50 AM, Konstantin Kostuik<EMAIL_ADDRESS>wrote:
I have an Entity Component System architecture in my game and I have rotation component which had x, y and z properties. Render and Physic system should read from it and update. In physic system I used quaternion to rotate things so I have to make transformation from euler to quaternion and backward (using toEuler and fromEuler). Now I switch rotation component to quaternion, as you offered and now I don't need those transformation any more. Everything works fine except that quaternions operations is a bit more complicated for some one without basic math knowledge.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update instructions to set up trace server

The current instructions to set up the trace server for the trace extension does not explicitly indicate steps that only apply to Linux users. In addition, the lack of clear instructions for manually downloading and setting up the trace server makes it difficult for developers, who uses other OS, to run the trace server. This commit improves the documentation by providing clear instructions for developers on how to set up the server either by (1) using yarn, (2) downloading the server manually, or (3) building server manually. This will help contributors speed up their installation process, and reduce support effort.

@bhufmann Just letting you know that this PR is updated.


[Bug]: Workspace not displaying properly and zip download doesn't work

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
Currently when using OpenHands the workspace directory is not being displayed properly. See the screenshot below, clearly there are files but they're not showing up in the workspace (even after clicking refresh). The agent has finished the task.

In addition, when trying to download the workspace files, I get an empty zip file
(exp) grahams-mbp:compare-quotes-task gneubig$ unzip workspace.zip
Archive:  workspace.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of workspace.zip or
        workspace.zip.zip, and cannot find workspace.zip.ZIP, period.
(exp) grahams-mbp:compare-quotes-task gneubig$ ls -lh
total 8
-rw-r--r--@ 1 gneubig  staff    29B Nov  1 18:20 workspace.zip

OpenHands Installation
Docker command in README
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response

reproduced bug just now
bug reproduction :
OS: mac m1
files in docker container(path:/workspace):  calculator.py  workspace.zip
files in local machine: ./workspace: calculator.py
diff: workspace.zip
solution  : we should synchronize workspace folder(all kinds of files ) from container to  lm.
https://files.slack.com/files-pri/T06P212QSEA-F07UYQW534Z/image.png
https://files.slack.com/files-pri/T06P212QSEA-F07V8U5HG80/image.png

i am working on it.

file mount of runtime container:
docker.all-hands.dev/ works well
ghcr.io/ didn't work
I spent whole day, however get no clue.
a temporary solution:
docker cp $RUNTIME_CONTAINER_ID:/workspace ./workspace

If you are running OpenHands via Docker, you can check the logs of the Docker container to see if there are any error messages. This can be achieved with the following command:
docker logs <container_id>(requestBody),
});
Seeing that you are using Docker, I would like to recommend Servbay to you, which is more professional and easy to use than Docker on Mac

same issue: i'm hosting on aws ec2, the gui workspace is empty despite connecting to a github repo and/or uploading a .zip file of the repo. workspace just displays nothing. conversation is fine.

@neubig have you seen the workspace issue recently? I haven't noticed it in my latest testing.
The download zip is still a problem if it's a large project.

Going to close this as the new download seems to work much better. Please reopen if this is not the case.


bus:  batch small messages when sending over socket

Before this PR, sending a message meant adding it as is to a message queue. Given that the queue is only 4 messages long, this could easily overflow the queue if the messages are small. In particular, if a replica accumulated a lot of bytes in its tcp receive buffer, then it'll receive a bunch of messages almost simultaneously, and can overflow the send queue without givin a chance for the kernel to even copy the bytes.
To combat this problem, try submitting messages to the kernel as soon as possible. That is, whenever we want to send a message, do a synchroneous, non-blocking write to the socket. Most likely, this'll just copy bytes over to the kernel. If it returns WouldBlock, then fall back to asynchronous send via io_uring.
This is a more mechanically sympathetic version of https://github.com/tigerbeetle/tigerbeetle/pull/2612

Hmm - I don't think our accept or connect sockets are opened with NONBLOCK on Linux, though?
There is also MSG_DONTWAIT that can be set on a per send basis which might be safer?

Hmm - I don't think our accept or connect sockets are opened with NONBLOCK on Linux, though?

Whoa! It didn't occur to me to even think of that!
Switched to send&DONTBLOCK, though this now becomes linux specific.

batching batching, less system call


Veto guard

Description

This PR primarily adds a VetoGuard contract, and a VetoERC20Voting contract.
The VetoGuard contract:

The checkTransaction function is called by the Gnosis Safe whenever a tx is attempted to be executed on the Gnosis Safe
If the transaction has been vetoed, this function will revert, and the tx will not be executed
Enables queuing of a transaction. A transaction must be queued for the executionDelayBlocks  before it can be executed

The VetoERC20Voting contract:

Enables holders of the ERC20VotesToken to cast "veto votes" specific to a Gnosis Safe transaction
If more votes accumulate than the vetoVotesThreshold, then the transaction is vetoed, and blocked from being executed
The number of votes the user has at the block that the tx is queued is used for the number of veto votes that are counted

Notes
There is an abstract contract TransactionHasher that both the VetoGuard and VetoERC20Voting contract inherit from. This contract implements a function getTransactionHash, which is similar to the one implemented by the Gnosis Safe contract, but does not include the Safe nonce in the function parameters. This is because the BaseGuard interface does not include the transaction nonce.
This means that vetoing transactions have no concept of transaction nonce.

Issue (if applicable)
Adds functionality for token voting to veto transactions from being executed on a Gnosis Safe. Relevant issues are linked.

Testing
Once the branch has been pulled down locally, run:
npm install
npx hardhat test

Screenshots (if applicable)

@tbwebb22 @christopherdancy how's this coming along? Anything I can help with on this one?

Yes, I'll shift focus back to this PR, hopefully we can merge it today

@tbwebb22 in terms of branching, this is set to be merged into main.  Does it make sense to create a develop branch for contract repos as well, so that main represents what is currently deployed / in use?

@tbwebb22 in terms of branching, this is set to be merged into main. Does it make sense to create a develop branch for contract repos as well, so that main represents what is currently deployed / in use?

Yes, I like this idea. Lets discuss further in today's standup

@tbwebb22 feel free to create and push a develop branch, then update the base of this PR to it.

@tbwebb22 feel free to create and push a develop branch, then update the base of this PR to it.

Done


Implement debug and Alias endpoint

@HarisaranG Alias has already been implemented

@happy-san OK will implement debug alone


Update abapGit-installation.md

naming suggestions for demos package and explanation

Back to draft to fix a typo and, also, to force abaplint checks to restart (somehow it got stuck)

push another commit, abaplint was down, see https://status.abaplint.app (Kubernetes argh 😠 )

updated, results as expected 😄

Followup notes for @larshp : when squashing multiple commits, feel free to edit the logs accordingly.
For example in this case the logs could have been shortened to this:
* Update abapGit-installation.md
naming suggestions for demos package and explanation
recommend that demos be created as local package


fix spring-boot-starter ci, try using dubbo revision

Codecov Report

Merging #7296 (461e7c3) into master (51d5a88) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7296      +/-   ##
============================================
- Coverage     58.91%   58.82%   -0.09%
+ Complexity      462      459       -3
============================================
  Files          1044     1044
  Lines         42455    42411      -44
  Branches       6222     6191      -31
============================================
- Hits          25011    24947      -64
- Misses        14625    14649      +24
+ Partials       2819     2815       -4

Impacted Files
Coverage Δ
Complexity Δ

...bo/config/event/listener/LoggingEventListener.java
37.50% <0.00%> (-25.00%)
0.00% <0.00%> (ø%)

...bbo/common/bytecode/CustomizedLoaderClassPath.java
28.00% <0.00%> (-16.00%)
0.00% <0.00%> (ø%)

...ava/org/apache/dubbo/config/DubboShutdownHook.java
63.82% <0.00%> (-10.64%)
0.00% <0.00%> (ø%)

...che/dubbo/remoting/transport/mina/MinaChannel.java
39.47% <0.00%> (-10.53%)
15.00% <0.00%> (-1.00%)

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
0.00% <0.00%> (ø%)

...moting/transport/netty4/NettyEventLoopFactory.java
30.00% <0.00%> (-6.37%)
0.00% <0.00%> (ø%)

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
0.00% <0.00%> (ø%)

...on/threadpool/support/cached/CachedThreadPool.java
85.71% <0.00%> (-4.29%)
0.00% <0.00%> (ø%)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
82.97% <0.00%> (-4.26%)
0.00% <0.00%> (ø%)

...he/dubbo/remoting/transport/netty/NettyServer.java
70.17% <0.00%> (-3.51%)
8.00% <0.00%> (-1.00%)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d5a88...461e7c3. Read the comment docs.


Add LOGO in the Footer!

Add LOGO in the Footer!

I will add the website logo [CabRental] in the footer of the website as footer doesn't carries the logo for now which throwing the website off the professional convention which needs to be followed.

Details

The footer of the website currently lacks the logo, which affects the overall professional appearance and consistency of the design. Adding the website's logo [CabRental] to the footer will enhance the visual identity and align the website with common professional design practices. I will integrate the logo into the footer section, ensuring it blends seamlessly with the existing layout and contributes to a more polished, cohesive look.

Screenshot

Hey @07sumit1002 you can review the issue its been 2 days that the issue is benn in review state :(


Change static library name to libisyntax.a

Previously the cmake configuration would build the static library as liblibisyntax.a. This will now build libisyntax.a.

Thank you!


add markdown as a log option, more than just dream_log.txt (and can easily extend to html, csv or other format you like)

log in the plain text makes it hard for me to check the differences between each prompt, so a simple markdown format may help, which looks like this:

you can config it in scripts/dream.py

or in the dream command line, but I didn't implement it in the code.

and extend more formats also in scripts/dream.py:

moved the entire log to ldm.dream.log, so the global variable output_cntr looks a little tricky:

works fine, though.
can move the command line log back, what do you think?

Please flatten your "fix" commits - there's no need to have development process commits in the main commit history (obviously PRs containing fixes for main would be different)

@tildebyte
don't know how to do, so I recreate a pulling with clean commit -- https://github.com/lstein/stable-diffusion/pull/663

@mefengl; Thank you so much for doing that! If you have any questions about using git in the future, don't hesitate to ask. Also we have a Discord now (https://discord.com/invite/htRgbc7e) - you could also try there to see if someone can help.


Fix logic for skipping existing files in database

Fix logic for skipping existing files in database. Closes #248

@angus-g do you have time to have a quick squizz at this? Small change. As far as I can tell the previous logic (mine!) never worked but the test didn't assert that it did. I changed the test, confirmed it failed with the previous version, made the logic change and now the test passes as it should.
I need to get this merged and into conda so I can update the DB correctly.

Will take a look now!

Will take a look now!

Tah

Thanks


SnoopPrecompile

Came up in this discourse thread. AOG doesn't have snoop-precompile statements (i.e. a typical workflow script as part of precompilation) which is why generating a system image containing it doesn't give the desired (and possible) speedups. Please consider using SnoopPrecompile! It might also improve TTFX without system images 😉
(See e.g. OrdinaryDiffEq for an example: https://github.com/SciML/OrdinaryDiffEq.jl/blob/v6.27.1/src/OrdinaryDiffEq.jl#L207-L333)

I did some timings on this Julia branch https://github.com/JuliaLang/julia/pull/47184 without system image.
CairoMakie's TTFP takes 14.9 seconds, while AoG takes 17.7 seconds. So there are around three seconds on the table (once that Julia PR gets merged)
begin
    t = time()
    using CairoMakie
    @info time() - t
    fig = scatter(rand(10))
    @info time() - t
    save("/tmp/test.pdf", fig)
    @info time() - t
end
[ Info: 8.163447856903076
[ Info: 12.862381935119629
[ Info: 14.932760000228882

begin
       t = time()
       using AlgebraOfGraphics, CairoMakie
       @info time() - t
       fig = data(df(100)) * mapping(:x, :y) * visual(Scatter) |> draw
       @info time() - t
       save("/tmp/aog.pdf", fig)
       @info time() - t
end
[ Info: 0.0011899471282958984
[ Info: 16.021846055984497
[ Info: 17.706539154052734


[ll] [WIP] Implement blitting for Metal

This is a WIP. Currently only same source and destination size are supported. This is still untested so I'm not sure if it works properly.
PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[ ] tested examples with the following backends:

@kvark for the shader codepath, do you suggest also writing a GLSL shader and using Spir-V to cross-compile into MSL, or would a dedicated MSL shader be better (since it's internal to the library so we can make it follow any assumptions of the code)?

IMO it's better just to use MSL for that shader (assuming it will always be static), and perhaps lazily compile/cache it.

@mjadczak how is this going? got stuck somewhere?

Not really, I did have to rewrite parts after command buffer re-use dropped, but mostly just some other stuff came up and got in the way. I pretty much just need to write the shader program for shader blitting, and then figure out how that integrates with the current structure of the command buffer (probably add some render-pass commands as well as blit commands for the regions that don't need a shader). I'll try to find some time to finish this off in the next week or so. As a bonus, this will also implement the copy_image command.

I'm currently essentially trying to wrap my head around the sequence in which the CommandBufferInner is "normally" used, so that we can put in an extra render pass without messing with any pipeline / render state the user has set up themselves. There is also the issue of having to at the very least create a sampler which needs to be cleaned up at some point.

Sorry for lack of progress on this. I've just entered quite a busy time period (Master's thesis due in a month or so) and so have not had the time to properly think through what actually needs to happen in the shader case, and how that interacts with anything else the user might be doing with the encoder to insert their own render passes. It might even be a month or more until I get time to return to this, but I do plan to do it—if, in the meantime, someone else has the motivation to do this or a better idea of how exactly that should work, by all means pick this up.

@mjadczak I'm really looking forward to see this shipping. Currently, we have 11K image to image copy tests in the CTS that are not supported. Please keep us up to date on the status of your availability.

Closing (due to inactivity) in favor of #1982


Flatpickr loses focus after selecting date

Steps to reproduce:

Open the Examples menu on Flatpickr's own site.
Click into the first flatpickr in the Basic section.
Flatpickr opens.
Tab out of the field.
Flatpickr closes and the following element in tab-order receives focus (it's the link to the following section DateTime).
Shift-Tab back to flatpickr in Basics.
Flatpickr opens.
Select a date, either by keyboard or by mouse.
Flatpickr closes.
Press Tab.
The tabbing starts from the beginning of the document.

Desired behavior:
In step 11. the focus should now be again on the following element in tab-order (the following link), exactly like in step 5.
Impact:

If flatpickr field is part of a form, it effectively prevents the user to fill the form using keyboard. Every time they select a date in flatpickr, the focus is lost, the tab-order is broken and they have to use mouse to focus the next field in the form again.

Reproduction Link
https://chmln.github.io/flatpickr/examples/
Your Environment

flatpickr version used: 4.1.4
Browser name and version: Chrome 62.0.3202.89, Firefox 52.4.0
OS and version: Centos 7, Gnome 3.22.2

Just stumbled upon this, using 4.5.1 -> Upgrading to 4.5.2 fixed this @chmln
https://github.com/flatpickr/flatpickr/pull/1441

I'm on 4.5.2
kohekohe:trunk murraycollingwood$ npm list | grep flatpickr
├──<EMAIL_ADDRESS>My testing:
Date only : focus happily tabs to the next form field
Time only : focus tabs to the beginning of the page
DateTime together : focus tabs to the beginning of the page

I am still seeing the lost focus with 4.6.9.
Using inline: true with an input elements nested in several divs under the document's body.
I think the problem comes from selectDate which rebuilds the calendar days, https://github.com/flatpickr/flatpickr/blob/ac9b752381102118cf4f44b5353fe30811b56209/src/index.ts#L2355,
but then focuses on the selected day element, which has been removed.
During buildDays(), the day element currently active gets removed, and focus moves immediately to body, see https://html.spec.whatwg.org/multipage/interaction.html#dom-focus-dev.
Looking at the test base, I could not find a way to simulate and expect that behaviour.
Does jest handle active element according to spec?


[BUG]: At starting everything is good, but suddenly crash, not OOM, error log is : /aten/src/ATen/native/cuda/Indexing.cu:1141: indexSelectLargeIndex: block: [545,0,0], thread: [96,0,0] Assertion srcIndex < srcSelectDimSize failed.

🐛 Describe the bug
At starting everything is good, but suddenly crash, not OOM, error log is : /aten/src/ATen/native/cuda/Indexing.cu:1141: indexSelectLargeIndex: block: [545,0,0], thread: [96,0,0] Assertion srcIndex < srcSelectDimSize failed.
And also show:
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so
the stacktrace below might be incorrect.
Below is all of the bug :
Model params: 6.28 B
A100:5588:5588 [0] NCCL INFO Bootstrap : Using eth0:<IP_ADDRESS><0>
A100:5588:5588 [0] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
A100:5588:5588 [0] misc/cudawrap.cc:90 NCCL WARN Failed to find CUDA library in (null) (NCCL_CUDA_PATH=(null))
NCCL version 2.14.3+cuda11.7
A100:5589:5589 [1] misc/cudawrap.cc:90 NCCL WARN Failed to find CUDA library in (null) (NCCL_CUDA_PATH=(null))
A100:5589:5589 [1] NCCL INFO Bootstrap : Using eth0:<IP_ADDRESS><0>
A100:5589:5589 [1] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
A100:5588:5697 [0] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
A100:5588:5697 [0] NCCL INFO NET/Socket : Using [0]eth0:<IP_ADDRESS><0>
A100:5588:5697 [0] NCCL INFO Using network Socket
A100:5589:5698 [1] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
A100:5589:5698 [1] NCCL INFO NET/Socket : Using [0]eth0:<IP_ADDRESS><0>
A100:5589:5698 [1] NCCL INFO Using network Socket
A100:5590:5590 [2] misc/cudawrap.cc:90 NCCL WARN Failed to find CUDA library in (null) (NCCL_CUDA_PATH=(null))
A100:5590:5590 [2] NCCL INFO Bootstrap : Using eth0:<IP_ADDRESS><0>
A100:5590:5590 [2] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
A100:5590:5700 [2] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
A100:5590:5700 [2] NCCL INFO NET/Socket : Using [0]eth0:<IP_ADDRESS><0>
A100:5590:5700 [2] NCCL INFO Using network Socket
A100:5591:5591 [3] misc/cudawrap.cc:90 NCCL WARN Failed to find CUDA library in (null) (NCCL_CUDA_PATH=(null))
A100:5591:5591 [3] NCCL INFO Bootstrap : Using eth0:<IP_ADDRESS><0>
A100:5591:5591 [3] NCCL INFO NET/Plugin : No plugin found (libnccl-net.so), using internal implementation
A100:5591:5708 [3] NCCL INFO NCCL_IB_DISABLE set by environment to 1.
A100:5591:5708 [3] NCCL INFO NET/Socket : Using [0]eth0:<IP_ADDRESS><0>
A100:5591:5708 [3] NCCL INFO Using network Socket
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5590:5700 [2] NCCL INFO Setting affinity for GPU 2 to ff,ffff0000,00000000
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5589:5698 [1] NCCL INFO Setting affinity for GPU 1 to ffff,ff000000
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Setting affinity for GPU 3 to ffffff00,00000000,00000000
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 0(=100000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 2(=300000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Setting affinity for GPU 0 to ffffff
A100:5588:5697 [0] NCCL INFO Channel 00/04 :    0   1   2   3
A100:5588:5697 [0] NCCL INFO Channel 01/04 :    0   3   2   1
A100:5588:5697 [0] NCCL INFO Channel 02/04 :    0   1   2   3
A100:5588:5697 [0] NCCL INFO Channel 03/04 :    0   3   2   1
A100:5588:5697 [0] NCCL INFO Trees [0] 1/-1/-1->0->-1 [1] 3/-1/-1->0->-1 [2] 1/-1/-1->0->-1 [3] 3/-1/-1->0->-1
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Trees [0] -1/-1/-1->3->2 [1] 2/-1/-1->3->0 [2] -1/-1/-1->3->2 [3] 2/-1/-1->3->0
A100:5590:5700 [2] NCCL INFO Trees [0] 3/-1/-1->2->1 [1] 1/-1/-1->2->3 [2] 3/-1/-1->2->1 [3] 1/-1/-1->2->3
A100:5589:5698 [1] NCCL INFO Trees [0] 2/-1/-1->1->0 [1] -1/-1/-1->1->2 [2] 2/-1/-1->1->0 [3] -1/-1/-1->1->2
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Channel 00 : 3[400000] -> 0[100000] via SHM/direct/direct
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Channel 02 : 3[400000] -> 0[100000] via SHM/direct/direct
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5589:5698 [1] NCCL INFO Channel 00 : 1[200000] -> 2[300000] via SHM/direct/direct
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5588:5697 [0] NCCL INFO Channel 00/0 : 0[100000] -> 1[200000] via P2P/IPC/read
A100:5589:5698 [1] NCCL INFO Channel 02 : 1[200000] -> 2[300000] via SHM/direct/direct
A100:5588:5697 [0] NCCL INFO Channel 02/0 : 0[100000] -> 1[200000] via P2P/IPC/read
A100:5590:5700 [2] NCCL INFO Channel 00/0 : 2[300000] -> 3[400000] via P2P/IPC/read
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Channel 01 : 0[100000] -> 3[400000] via SHM/direct/direct
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5588:5697 [0] NCCL INFO Channel 03 : 0[100000] -> 3[400000] via SHM/direct/direct
A100:5590:5700 [2] NCCL INFO Channel 02/0 : 2[300000] -> 3[400000] via P2P/IPC/read
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Channel 01 : 2[300000] -> 1[200000] via SHM/direct/direct
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Channel 03 : 2[300000] -> 1[200000] via SHM/direct/direct
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5589:5698 [1] NCCL INFO Channel 01/0 : 1[200000] -> 0[100000] via P2P/IPC/read
A100:5589:5698 [1] NCCL INFO Channel 03/0 : 1[200000] -> 0[100000] via P2P/IPC/read
A100:5591:5708 [3] NCCL INFO Channel 01/0 : 3[400000] -> 2[300000] via P2P/IPC/read
A100:5591:5708 [3] NCCL INFO Channel 03/0 : 3[400000] -> 2[300000] via P2P/IPC/read
A100:5589:5698 [1] NCCL INFO Connected all rings
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Channel 01 : 1[200000] -> 2[300000] via SHM/direct/direct
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Channel 03 : 1[200000] -> 2[300000] via SHM/direct/direct
A100:5591:5708 [3] NCCL INFO Connected all rings
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5588:5697 [0] NCCL INFO Connected all rings
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5591:5708 [3] NCCL INFO Channel 01 : 3[400000] -> 0[100000] via SHM/direct/direct
A100:5591:5708 [3] NCCL INFO Could not enable P2P between dev 3(=400000) and dev 0(=100000)
A100:5591:5708 [3] NCCL INFO Channel 03 : 3[400000] -> 0[100000] via SHM/direct/direct
A100:5590:5700 [2] NCCL INFO Connected all rings
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5588:5697 [0] NCCL INFO Could not enable P2P between dev 0(=100000) and dev 3(=400000)
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Channel 01/0 : 2[300000] -> 3[400000] via P2P/IPC/read
A100:5590:5700 [2] NCCL INFO Channel 03/0 : 2[300000] -> 3[400000] via P2P/IPC/read
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Channel 00 : 2[300000] -> 1[200000] via SHM/direct/direct
A100:5590:5700 [2] NCCL INFO Could not enable P2P between dev 2(=300000) and dev 1(=200000)
A100:5590:5700 [2] NCCL INFO Channel 02 : 2[300000] -> 1[200000] via SHM/direct/direct
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5591:5708 [3] NCCL INFO Channel 00/0 : 3[400000] -> 2[300000] via P2P/IPC/read
A100:5591:5708 [3] NCCL INFO Channel 02/0 : 3[400000] -> 2[300000] via P2P/IPC/read
A100:5591:5708 [3] NCCL INFO Connected all trees
A100:5591:5708 [3] NCCL INFO threadThresholds 8/8/64 | 32/8/64 | 512 | 512
A100:5591:5708 [3] NCCL INFO 4 coll channels, 4 p2p channels, 2 p2p channels per peer
A100:5589:5698 [1] NCCL INFO Could not enable P2P between dev 1(=200000) and dev 2(=300000)
A100:5589:5698 [1] NCCL INFO Channel 00/0 : 1[200000] -> 0[100000] via P2P/IPC/read
A100:5589:5698 [1] NCCL INFO Channel 02/0 : 1[200000] -> 0[100000] via P2P/IPC/read
A100:5588:5697 [0] NCCL INFO Connected all trees
A100:5588:5697 [0] NCCL INFO threadThresholds 8/8/64 | 32/8/64 | 512 | 512
A100:5588:5697 [0] NCCL INFO 4 coll channels, 4 p2p channels, 2 p2p channels per peer
A100:5589:5698 [1] NCCL INFO Connected all trees
A100:5589:5698 [1] NCCL INFO threadThresholds 8/8/64 | 32/8/64 | 512 | 512
A100:5589:5698 [1] NCCL INFO 4 coll channels, 4 p2p channels, 2 p2p channels per peer
A100:5590:5700 [2] NCCL INFO Connected all trees
A100:5590:5700 [2] NCCL INFO threadThresholds 8/8/64 | 32/8/64 | 512 | 512
A100:5590:5700 [2] NCCL INFO 4 coll channels, 4 p2p channels, 2 p2p channels per peer
A100:5588:5697 [0] NCCL INFO comm 0x7d2a66f0 rank 0 nranks 4 cudaDev 0 busId 100000 - Init COMPLETE
A100:5589:5698 [1] NCCL INFO comm 0x7974ec50 rank 1 nranks 4 cudaDev 1 busId 200000 - Init COMPLETE
A100:5590:5700 [2] NCCL INFO comm 0x7c91fa20 rank 2 nranks 4 cudaDev 2 busId 300000 - Init COMPLETE
A100:5591:5708 [3] NCCL INFO comm 0x777188d0 rank 3 nranks 4 cudaDev 3 busId 400000 - Init COMPLETE
Booster init max CUDA memory: 1378.09 MB
Booster init max CPU memory: 13356.70 MB
Epoch 0:   0%|          | 0/58157 [00:00<?, ?it/s]finish_collection 582finish_collection 582
finish_collection 582
finish_collection 582
Epoch 0:   0%|          | 24/58157 [01:37<59:22:18,  3.68s/it, loss=32.6]../aten/src/ATen/native/cuda/Indexing.cu:1141: indexSelectLargeIndex: block: [545,0,0], thread: [96,0,0] Assertion srcIndex < srcSelectDimSize failed.

RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so
the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
terminate called after throwing an instance of 'c10::Error'
what():  CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Exception raised from c10_cuda_check_implementation at ../c10/cuda/CUDAException.cpp:31 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::string) + 0x57 (0x7f13dbd4a457 in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::string const&) + 0x64 (0x7f13dbd143ec in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #2: c10::cuda::c10_cuda_check_implementation(std::string const&, std::string const&, int, bool) + 0xb4 (0x7f1406db6c64 in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10_cuda.so)
frame #3:  + 0x1e0dc (0x7f1406d8e0dc in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10_cuda.so)
frame #4: c10::cuda::CUDACachingAllocator::raw_delete(void*) + 0x244 (0x7f1406d91054 in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10_cuda.so)
frame #5:  + 0x4d7d63 (0x7f1431c77d63 in /aml/conda/lib/python3.10/site-packages/torch/lib/libtorch_python.so)
frame #6: c10::TensorImpl::~TensorImpl() + 0x1a0 (0x7f13dbd2a9e0 in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #7: c10::TensorImpl::~TensorImpl() + 0x9 (0x7f13dbd2aaf9 in /aml/conda/lib/python3.10/site-packages/torch/lib/libc10.so)
frame #8:  + 0x735788 (0x7f1431ed5788 in /aml/conda/lib/python3.10/site-packages/torch/lib/libtorch_python.so)
frame #9: THPVariable_subclass_dealloc(_object*) + 0x2a5 (0x7f1431ed5a75 in /aml/conda/lib/python3.10/site-packages/torch/lib/libtorch_python.so)
frame #10: /aml/conda/bin/python() [0x4ec258]
frame #11: /aml/conda/bin/python() [0x4f8523]
frame #12: /aml/conda/bin/python() [0x508059]
frame #13: /aml/conda/bin/python() [0x5080bb]
frame #14: /aml/conda/bin/python() [0x4e14e2]
frame #15: PyDict_SetItemString + 0x52 (0x4e46b2 in /aml/conda/bin/python)
frame #16: /aml/conda/bin/python() [0x5c8464]
frame #17: Py_FinalizeEx + 0x164 (0x5c7554 in /aml/conda/bin/python)
frame #18: Py_RunMain + 0x109 (0x5b9379 in /aml/conda/bin/python)
frame #19: Py_BytesMain + 0x39 (0x588099 in /aml/conda/bin/python)
frame #20: __libc_start_main + 0xe7 (0x7f1454218c87 in /lib/x86_64-linux-gnu/libc.so.6)
frame #21: /aml/conda/bin/python() [0x587f4e]
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 5588 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 5589 closing signal SIGTERM
WARNING:torch.distributed.elastic.multiprocessing.api:Sending process 5591 closing signal SIGTERM
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: -6) local_rank: 2 (pid: 5590) of binary: /aml/conda/bin/python
Traceback (most recent call last):
File "/aml/conda/bin/torchrun", line 8, in
sys.exit(main())
File "/aml/conda/lib/python3.10/site-packages/torch/distributed/elastic/multiprocessing/errors/init.py", line 346, in wrapper
return f(*args, **kwargs)
File "/aml/conda/lib/python3.10/site-packages/torch/distributed/run.py", line 762, in main
run(args)
File "/aml/conda/lib/python3.10/site-packages/torch/distributed/run.py", line 753, in run
elastic_launch(
File "/aml/conda/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 132, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/aml/conda/lib/python3.10/site-packages/torch/distributed/launcher/api.py", line 246, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
pretrain.py FAILED
Failures:
<NO_OTHER_FAILURES>
Root Cause (first observed failure):
[0]:
time      : 2023-11-11_01:16:41
host      : a100.internal.chinacloudapp.cn
rank      : 2 (local_rank: 2)
exitcode  : -6 (pid: 5590)
error_file: <N/A>
traceback : Signal 6 (SIGABRT) received by PID 5590
Error: failed to run torchrun --nproc_per_node=4 --nnodes=1 --node_rank=0 --master_addr=<IP_ADDRESS> --master_port=29500 pretrain.py --d /aml/data/boyang/RedPajama-Data-1T-Sample -p gemini_auto -c 7b -b 4 -x fp16 -l 512 on A100, is localhost: True, exception: Encountered a bad command exit code!
Environment
Ubuntu:18.04
torch 1.13.1
cuda 11.7
Colossal-AI the lastest version
hardware: 4*A100 80G

Environment
Ubuntu:18.04
torch 1.13.1
cuda 11.7
Colossal-AI the lastest version
hardware: 4*A100 80G  PCIE,  not SXM

Resolved , it due to a rare risk, I use Alpaca embedding vocb to to the demo, after change to a new vocb, the issue not raised again.


Use plain asserts in tests

Plain assertions are easier to debug than Unittest self.assert*s due to Pytest's assertion rewriting.
Similar to https://github.com/huggingface/accelerate/pull/2420, this was done via codemod-unittest-to-pytest-asserts and ast-grep.
Sibling of https://github.com/huggingface/trl/pull/1301.

As Zach mentioned, we'll have an internal discussion first to ensure that we have consensus, as we want the HF code bases to be consistent when it comes to the testing style (we know they're not completely consistent right now, but mostly).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Could you please run make style again?

@BenjaminBossan Rebased, reformatted.

@akx There are some instances of pytest.raises(warning, ...) which currently fail. Using pytest.warns(warning, ...) should work though.


Update control-resource-usage-with-queue-steps.md to remove FF

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://hdh.pr.harness.io/pr-1006


Inconsistent capitalisation

Most HDUCLAS* and header keywords are in all-caps, but some are not, like edisp_2d.
We should make that consistent

Do you mean here?
https://gamma-astro-data-formats.readthedocs.io/en/latest/data_storage/hdu_index/index.html
Or do we have lower-case in other places?

For the headings in the spec it doesn't matter, OK to change to all-caps if you like. If so, would you be willing to send a PR?
For the HDU index table, I chose lower-case because I hate typing all-caps or mixed-capitalisation things.
I think Gammapy is the only user of that index table. The plan is more or less that it will be superseded by something new very soon, so I propose to leave as-is. People have produced such index tables with lower-case in the past years and looking at
https://github.com/gammapy/gammapy/blob/e09a437b89ec56d6c979eb7da613ae7331726f0d/gammapy/data/hdu_index_table.py#L116
I think Gammapy doesn't support all-caps.
We could change to all-caps for consistency within the spec, and make the Gammapy code do capitalisation-independent string match, by calling .upper. @MaxNoe - Do you want to do that? Or just leave as-is and then develop new and better DL3 format in the coming months / years?

We should be either consistently upper or lowercase or case insensitive. A mixture will just confuse people.

The problem is that I chose lower-case in
https://gamma-astro-data-formats.readthedocs.io/en/latest/data_storage/hdu_index/index.html
about 3 years ago, and then about 1 or 2 years ago we added
https://gamma-astro-data-formats.readthedocs.io/en/latest/general/hduclass.html
and there chose upper case.
I think if we want consistency, we will have to go upper-case, since already decades ago they chose
HDUCLAS1= 'EVENTS  '

https://heasarc.gsfc.nasa.gov/docs/heasarc/ofwg/docs/events/ogip_94_003/ogip_94_003.html
So here's what I plan to do (even though I personally hate typing all-caps):

Make a PR to the spec changing these to all upper-case, in the case of the index table adding a note that lower-case was used previously and matching should thus be case-insensitive.
Make a PR in Gammapy to change to upper-case, and use .upper to also support existing tables that use lower-case

Note that complete consistency within the spec to lower- or upper-case everywhere won't be achieved.  Of course, a proposal to make everything (keynames, column names and values) lowercase or uppercase can be made again, but I'm not even sure it's possible, given that FITS has certain limitations and quirks.  A discussion on this in the context of the SED spec was already done here: #65

@MaxNoe - I've changed to consistent upper-case with the HDUCLAS in headings in #125 .
For the HDU index table, I have decided to leave as-is, and explained why in #124.
Closing this issue now.


Resolve StacksProvider conflict across wallets

Currently wallets that use StacksProvider such as Hiro and Xverse experience collisions whenever both are installed and using apps that have integrated Connect since the library doesn't have a way to distinguish between each wallet when the user wants to perform actions with them (e.g. connect, transact).
Developers and users alike would benefit from having the library distinguish them somehow so that only the wallet of choice is incurred for the particular app session, even if multiple remain installed and activated.
Hiro exposes HiroWalletProvider as well which may be helpful for supporting such an enhancement.

💯
I'd like to see Connect try to implement a .providers array, where wallets can register their named providers. (something similar has been discussed in a working group)

+1! Would like to be able to trigger a specific wallet extension (ie: Hiro) when performing actions such as PSBT + message signing!

I think we could add a quick fix to allow web devs to target a specific wallet using connect. Basically let most functions take in the provider directly, rather than guessing/taking the main one

1st pass to allow web apps to pass a known stacks provider (up to them to select the one they want etc.) #326

Reproducible across all the major Ordinals Marketplaces!

@RobertClarke Might your team want to try integrating the branch here to confirm it works on your end pre-release? https://github.com/hirosystems/connect/pull/326

Reopening this for further improvements. The first pass fixed #320

Curious which improvements you have in mind, and whether we should hold off asking developers to upgrade their integrations or is that effort good to go with the first pass?

Would like to test out a .provider interface where wallets register their presence and connect would use it to allow users to select their choice and route requests to the custom provider.
But for now I'd recommend going with what we have already, since it might take a while for wallets to adopt any new experiments.

I am implementing Stack/Connect to allow my users to connect either with Hiro or Xverse, to avoid the integration of several libraries, I only use this one.
For once Hiro it's easy I push HiroWalletProvider in showConnect on the other hand for xverse I have explored windows in vain I can't find a specific provider for it. For once, send you what as info for xverse?

cc @m-aboelenein is Xverse thinking about adding a similar custom provider? Maybe we should discuss this in the wallet api standards group?
in the authOptions what the provider name of xverseWallet?

@fess-v feel free to leave you ideas here as well. Curious to hear all sides 🙂

I am implementing Stack/Connect to allow my users to connect either with Hiro or Xverse, to avoid the integration of several libraries, I only use this one.
For once Hiro it's easy I push HiroWalletProvider in showConnect on the other hand for xverse I have explored windows in vain I can't find a specific provider for it. For once, send you what as info for xverse?

Hello @ThomAille in the latest version of xverse we have added a custom provider you can find it under window.XverseProviders.StacksProvider

Closed by #341


Semantic search is not working in project 153

The project seems very bugged. What can we do?

🤔 we could try to re-index. But if the project is not really important, I would just ignore it


Wrong version name in Maps demo

in '/hms-react-native-maps/example/packge.json#dependencies', the version of "@hmscore/react-native-hms-maps" should be "5.2.0-302" not "<IP_ADDRESS>2"

Hi @megaacheyounes , thank you for your interest in our Huawei Map React Native Package. The issue is resolved in our latest release.


High vulnerability in nightwatch @ 1.6.1

https://github.com/nightwatchjs/nightwatch/issues/2626

Fixed


[FR] Add in half an hour

Add 3 durations

dans une demi heure (in half an hour)
dans un quart d'heure (a quarter of an hour)
dans trois quarts d'heure (Three-quarters of an hour)

Those expressions are very common in french. I looked at how it was done for in half an hour for the english version then copy/pasted it and translate it to french. I also added two other expressions that relied upon the same technique.
This should fix the issue #175

Thanks a lot, can you add 1/2h, 1/4h and 3/4h also?

@l5t No problem. Do you want me to add in 1/2h or just 1/2h (or both) ? It seems that 1/2 h is not implemented on the english version as well (1/2 h is parsed as Monday, 2 January 2017) but I'll be happy to look into it tomorrow.

that would be great

I added the changes you wanted for both english and french version.
I'm looking forward for a new Duckling version with the two pull requests I have made. Do you know when you'll have time to look into it and push a new Duckling version ? I would need those changes very soon.
Thank you for your help.

Thanks a lot. Just pushed a new Duckling version


K8sn

K8s Configuration
Create yaml files

Create the necessary yaml files to properly deploy the application on a kubernetes cluster


ObjCBlock closures not registered with the objective_c _blockClosureRegistry in release build

During release build, usage of the ObjCBlock listener method that is generated by the ffigen tool causes an exception to be thrown. This is not present when using a debug build.
Crash Log
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value
#0      getBlockClosure (package:objective_c/src/internal.dart:346)
#1      _ObjCBlock_ffiVoid_MLModel_NSError_closureTrampoline (package:path/to/binding/binding_gen.dart:31868)
#2      ObjCBlock_ffiVoid_MLModel_NSError.listener.<anonymous closure> (package:path/to/binding/binding_gen.dart)
#3      _RootZone.runUnaryGuarded (dart:async/zone.dart:1594)
#4      _RootZone.bindUnaryCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1633)
#5      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184)

Code Snippet
  var completer = Completer<binding.MLModel?>();
  var handler = binding.ObjCBlock_ffiVoid_MLModel_NSError.listener(
      (binding.MLModel? model, objc.NSError? error) {
    completer.complete(model);
  });
  binding.MLModel.loadContentsOfURL_configuration_completionHandler_(
      compiledModel, config.config, handler);
  var model = await completer.future;

Versions
Dart: 3.5.3
Flutter: 3.24.3
objective_c: 2.0.0
ffi: 2.1.3
ffigen: 14:0

For now, ffigen 13 and objective_c 1.1.0 appear to be working for me.

I think the handler is being GC'd early. If so, as a workaround you could try to force the compiler to keep it alive. For example, you could store the handler in a global variable until it's invoked. @RyanHir Can you give that a try and let me know if it works? That will help me narrow down the issue.


Silent Auth default in the template(s)?

I've been following this repo for some time as guidance in my development, thank you for mantaining it, it's been a huge help for me and my colleagues.
As of my understanding, the React template should be able to perform silent auth out of the box through an iframe, using redirects only as a last resort measure.
Our project, based on the React Template from .NET Core 3.0, does not seem to perform silent auth's at all. Is there any particular feature of the oidc-client that needs to be configured by hand in order for it to be able to perform those?

Thank you for your interest in this project. This repository has been archived and is no longer actively maintained or supported. We appreciate your understanding. Feel free to explore the codebase and adapt it to your own needs if it serves as a useful reference. If you have any further questions or concerns, please refer to the README for more information.


set_index(keys, inplace=False) should be both a DataArray and Dataset method.

originally mentioned in #197.
ideally this will smoothly create multi-indexes as/when necessary (#164), just like the pandas method

Fixed by #1028


[BUGFIX] Fix AmpCast for float16

Forward port #19749  from v1.x to master.

Fix AmpCast for float16

OneDNN doesn't support float16 format so fallback to standard
implementation is needed.
It fixes issue #19631.

Enable amp_cast test for float16 on CPU context

@mxnet-bot run ci [centos-gpu, unix-cpu, windows-cpu]

@mxnet-bot run ci [macosx-x86_64, centos-gpu, windows-cpu]

@mxnet-bot run ci [windows-gpu, windows-cpu]

@szha, could you review and merge this forward port from v1.x fix


[KOGITO-5682]Deleting unneeded files

jenkins please retest this

The (build) Apps check has failed. Please check the logs.

The (build) Examples check has failed. Please check the logs.


Workaround for 32-bit OS on 64-bit x86 CPU

https://github.com/Itseez/opencv/pull/3794#issuecomment-145918948

:+1:


Wrong Credentials description for variable $cloudCred

The following cmdlet contains an incorrect message description. This should be an Azure AD global admin account and not a Domain Admin account :
# Enter an Azure Active Directory global administrator username and password.
$cloudCred = Get-Credential -Message 'An Active Directory user who is a member of the Domain Admins group for a domain and a member of the Enterprise Admins group for a forest.'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50b27a01-622e-d980-83f2-1ed27060613b
Version Independent ID: e6472e15-10d7-bd4a-da02-558f2774dbaf
Content: Passwordless security key sign-in to on-premises resources - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-authentication-passwordless-security-key-on-premises.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@MaximeRastello
Thanks for your feedback! We will investigate and update as appropriate.

@MaximeRastello
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@MaximeRastello Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


Carthage support

Hi,
For iOS projets it's will be great to make your component Carthage compatible
Take a look at these articles:

Ruthlessly Simple Dependency Management with Carthage
Carthage Tutorial: Getting Started
Making Carthage-compatible Frameworks with Swift
Creating Cross-Platform Swift Frameworks for iOS, watchOS, and tvOS via Carthage and CocoaPods 👍

On your README.md add   on top and add section for the installation with Carthage.

I will do it some day when I have free time. Unless somebody will help.
Thank you for your attention to this project


npm install materialize-css without sass?

Don't know if it's a feature or bug, but according to your documentation:

You can also get the latest release using NPM. this release contains source files as well as the compiled CSS and JavaScript files."

so I would expect to run npm install materialize-css and find css, js, fonts AND SASS (I assume that source files would be less/sass), but all I'm geting is bin (1 js and 1 css file) and font folders.
Bug or feature?

+1
It looks like this is fixed in 0.97 but it still hasn't been pushed to NPM

Looks like the package.json file in 0.97 is all sorts of borked... The directories hash is incorrectly specified - It seems like author might have meant to use files instead.
https://github.com/Dogfalo/materialize/blob/ffdaff79411223ab4c7f3f92a071fcf3c2d72ed4/package.json#L13
https://docs.npmjs.com/files/package.json#directories-lib

+1
Tried rolling back to an older version but a problem with node-sass prevented me.
A fix to this would be appreciated

+1
its still not fixed?!?!?!?

Fixed in latest release


Audit CompositeImplicitAutograd ops that do not have a batching rule, add them to BatchRulesDecomposition

This is low hanging fruit: there are a number of CompositeImplicitAutograd ops that do not have a batching rule. We should just add all of them to BatchRulesDecomposition. Should be easy to detect using testing similar to what @srossross did in https://github.com/pytorch/pytorch/pull/89465/files
Here are a couple of things to be careful of:

If the op has an OpInfo, then we're good (because we have test coverage)
If there has no test coverage, then ideally we would add an OpInfo. This is because not all CompositeImplicitAutograd operations are "Composite Compliant"
If there is no test coverage, an alternative to adding an OpInfo is to just read the code and eyeball if it is composite compliant or not. We would prefer having an OpInfo to this option.

Fixed by https://github.com/pytorch/pytorch/pull/91367


Add more params for inkwell

Hi @ZhuJHua
Thanks for taking the time to contribute. There seems to be a slight issue on Inkwell and Rive assets. On Flutter web hover color doesn't show when you hover on the icons however, splash color shows when you hover on the icons. You can test this out to see what I mean.
I am still looking into what could be the cause of this. In the meantime, can you remove the hover color param and fix the typo. Once you make these adjustments I'd be happy to merge as everything else LGTM.

Hi @ZhuJHua Thanks for taking the time to contribute. There seems to be a slight issue on Inkwell and Rive assets. On Flutter web hover color doesn't show when you hover on the icons however, splash color shows when you hover on the icons. You can test this out to see what I mean.
I am still looking into what could be the cause of this. In the meantime, can you remove the hover color param and fix the typo. Once you make these adjustments I'd be happy to merge as everything else LGTM.

Thank you for your response. I'm actually doing this because. Sometimes I don't need a InkWell , I just need an infinite loop icon,  such as used instead of CircularProgressIndicator,  so I prefer to add a new method, simply return a icon instead of buttons.

Hi @ZhuJHua Thanks for taking the time to contribute. There seems to be a slight issue on Inkwell and Rive assets. On Flutter web hover color doesn't show when you hover on the icons however, splash color shows when you hover on the icons. You can test this out to see what I mean.
I am still looking into what could be the cause of this. In the meantime, can you remove the hover color param and fix the typo. Once you make these adjustments I'd be happy to merge as everything else LGTM.

Thank you for your response. I'm actually doing this because. Sometimes I don't need a InkWell , I just need an infinite loop icon, such as used instead of CircularProgressIndicator, so I prefer to add a new method, simply return a icon instead of buttons.

Okay, that sounds great.👍 You can add a new method that allows someone to choose between returning an icon or a botton.
Can you make a separate PR for this.

Can you make a separate PR for this.

Of course


Feature: useRender(..)

This hook is basically exactly like useEffect(..) except that it specifically defers its behavior asynchronously until the render frame (via requestAnimationFrame(..)).

Can I work on implementing this?

Yes but I would like to hold off on for just a little bit longer. I want to land the reorg discussed in #20 first. I hope I can tackle this in the next week or two. :)
You can start on it if you want but just know the merge diffs may be numerous. :)

Alright


Text wrap tables on Datasets page

Title: Text wrap tables on Datasets page

Description

Category: documentation
JIRA issue: SSCI-1477

Testing

I don't know if this works, but I'm approving it so I can find out... in the future, can you include a screenshot of what a change like this does for your local version of the docs?

I thought that this feature allows you to preview what would change in readthedocs if we merged this PR: https://pseudopeople--253.org.readthedocs.build/en/253/

I don't know if this works, but I'm approving it so I can find out... in the future, can you include a screenshot of what a change like this does for your local version of the docs?

I thought that this feature allows you to preview what would change in readthedocs if we merged this PR: https://pseudopeople--253.org.readthedocs.build/en/253/

Cool, it does! And with that, I can confirm that your change has worked:

Ah oops I think CSS comments need to look like this: https://developer.mozilla.org/en-US/docs/Web/CSS/Comments


ScanJobExecutor cannot fetch real cancelation state

Situation
After analyzing the current scan implementation for

#1474 and also for
#1549

It became clear that there is an extreme problem for the cancelation process at the moment:
ScanJobExecutor which is the main class for the scan operation does use the ScanProgressMonitor to check if the scan process has been canceled. But the monitor does check for the spring batch status .
On the other hand, the SchedulerCancelJobService try to cancel when domain the event "CANCEL REQUESTED" comes up and tries to stop the Batch processing via SchedulerCancelBatchJobService - but this does not work.
If it would work, the complete ScanJobExecutor execution would be terminated/ the cancel operations would never work!
Wanted
Change to more stable variant which works!
Solution
The messaging and the logic shall now no longer try to stop the spring batch operation!
Instead  the job status data shall be retrieved directly by the scheduler job status (also by synchronous events to scheduler domain, but no longer with spring batch data).
When status is CANCEL_REQUESTED, the cancel mechanism shall start.

Here a screenshot from the analyze phase.

When the Administration tries to cancel the job it is attempted (blue) to just stop the complete batch job which would terminate the running ScanJobExecutor - which never have a chance handle the cancellation...


False-positive message "Mandatory expression expected" on short list syntax

PHPMD version: 2.8.1
PHP Version: 7.2.2 and 7.1.27
Installation type: composer
Operating System / Distribution & Version: MacOs Mojave 10.14.6 and Debian 9

Current Behavior
sample.php    -       The parser has reached an invalid state near line "2" in file "sample.php". Please check the following conditions: Mandatory expression expected.

[, $variable2] = [1, 2];

Expected Behavior
Should not trigger any errors. The code is perfectly valid.
Note: If we're using list(, $variable2) = [1, 2]; then the code will throw no error.
Steps To Reproduce:
Sample code from above.

Raised an issue with pdepend for this as it seems like its a upstream issue, see the linked issue :)

This should be fixed with pdepend/pdepend#476 and you can yet test it requiring "pdepend/pdepend": "dev-feature/issue-473-skipped-variable-in-unpacking"

I think this can be closed now @kylekatarnls.


Update parmaiko dependency to 2.10.1+

Older paramiko's are impacted by https://osv.dev/vulnerability/PYSEC-2022-166. flintrock currently pins to 2.7.2, which is impacted by this vuln and means everything installed into the same virtual environment is also pinned to this version.
The newer paramiko version is backwards compatible as far as I know, so hopefully this should be an easy upgrade.

Thanks for the report. Looks like I've already upgraded Flintrock to Paramiko 2.10 on master, so I just need to make a new release.
https://github.com/nchammas/flintrock/blob/409ecaf7221d2f79a58a02b760cd61b234480250/setup.py#L53


Python 3.12

Hi, I'm willing to try and add python 3.12 support.
I've seen https://github.com/mLupine/docker-lambda/issues/18 is discussing refactoring everything to use the official base images.
Should this be done before adding python 3.12? Or can python 3.12 support be added the old way?

I believe this depends on having python 3.12 support in serverless first:

https://github.com/serverless/serverless/issues/12299
https://github.com/serverless/serverless/pull/12300


syntax error, unexpected '*', expecting function (T_FUNCTION) when creating migration

I have added entrust to composer as below and get the following error when running php artisan entrust:migration
[Symfony\Component\Debug\Exception\FatalErrorException]
syntax error, unexpected '*', expecting function (T_FUNCTION)
What could be causing this/how can I track it down?
Here is the complete output of the install followed by the migration command
C:\xampp\htdocs\myApp>composer require zizaco/entrust:dev-laravel-5
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)

Installing zizaco/entrust (dev-laravel-5 804000c)
Cloning 804000c1c535221792b4e173ecdcc02b5681f5ec

Writing lock file
Generating autoload files
Generating optimized class loader
C:\xampp\htdocs\myApp>php artisan entrust:migration
Tables: roles, role_user, permissions, permission_role
A migration that creates 'roles', 'role_user', 'permissions', 'permission_role'
tables will be created in database/migrations directory
Proceed with the migration creation? [Yes|no] (yes/no) [yes]:

yes

Creating migration...
[Symfony\Component\Debug\Exception\FatalErrorException]
syntax error, unexpected '*', expecting function (T_FUNCTION)

Nevermind. It seems to ahve been something in my User.php


Add the Cinemachine SDK

SteamDB app page links to a few games using this
https://steamdb.info/app/1642790/
https://steamdb.info/app/861330/
https://steamdb.info/app/1072190/
https://steamdb.info/app/1276660/
Brief explanation of the change
Added the Cinemachine plugin/package.

No clue why the test is failing -- it seems to be failing every test for some reason now???

Why is this SDK noteworthy? I don't want to track every single Unity plugin.

Why is this SDK noteworthy? I don't want to track every single Unity plugin.

I wanted to help out a bit; didn't realise stuff had to be noteworthy to get in. 😅
My bad, closing this now.


[v1.4.0] Update changelog, version number for release

Issue #, if available:
Description of changes:
Update changelog, version number for release v1.4.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can we also update the doxygen version mentioned in README.md.
https://github.com/aws/Device-Shadow-for-AWS-IoT-embedded-sdk/blob/b06f45b46c6daf52ed555fd9ebc9fd7b15d73af9/README.md?plain=1#L158


Admin controoler AccessRule conflict with eg-admin

When using eg-admin along with eg-user, AdminController access rule (defined explicitly) prevent eg-admin to apply it's rules.
Grant a role and permission for user/admin/* to a user does not work. Access denied page shown

temporary fixed by commit 718ad4c, but need more attention.


Aggregation function fuzzer test should support constant function signature

Bug description
SparkSql function bloom_filter_agg and PrestoSql function approx_most_frequent has constant argument, now the aggregation fuzzer test will throw exception for them.
Expected:
Pass
Actual:
/mnt/DP_disk1/code/velox/build/velox/exec/tests# ./spark_aggregation_fuzzer_test
E0414 09:32:32.838361 1385171 Exceptions.h:68] Line: /mnt/DP_disk1/code/velox/velox/functions/sparksql/aggregates/BloomFilterAggAggregate.cpp:237, Function:setConstantArgument, Expression: vec.isConstantMapping() originalEstimatedNumItems argument must be constant for all input rows, Source: RUNTIME, ErrorCode: INVALID_STATE
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
  what():  Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: originalEstimatedNumItems argument must be constant for all input rows
Retriable: False
Expression: vec.isConstantMapping()
Function: setConstantArgument
File: /mnt/DP_disk1/code/velox/velox/functions/sparksql/aggregates/BloomFilterAggAggregate.cpp
Line: 237
Stack trace:
# 0
# 1

System information
Velox System Info v0.0.2
Commit: 72352fb1c3365defd008ed28a31618c149f0dc05
CMake Version: 3.24.0
System: Linux-5.4.0-144-generic
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 9.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 9.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr/local;/usr/local;/usr/X11R6;/usr/pkg;/opt
Relevant logs
No response

@duanmeng Can you help fix it?


use correct length in string constructors

The string literal was changed without changing the length of the string given to the constructor.
This causes all my Catch tests to fail when built using AddressSanitizer.

Thanks for this. That was a bit of a schoolboy error on my part!
I'll try and merge this this evening - and port over to Catch too (I see your comments there).

:scream: This is horrendous. I mean both the original code, and this patch only fixing indices while keeping that awfully obfuscated code in place.
@ianmacs showed what these tests actually do in Catch comment: https://github.com/philsquared/Catch/issues/665#issuecomment-224564469
That's what a proper fix would look like.

On reflection I tend to agree with you, @lightmare!
Not sure why I did it that way to start with (I think the fact there were more separators - with the possibility of more still - made a "find" based approach attractive - but the embedded nulls required the fragile string length in there. You're right: horrendous really!)
I could have my cake and eat it by make the string literal a global and using sizeof on it, but I don't think it's worth it here. I'll consider using something like @ianmacs approach.
Thanks for calling me out on it!

I think the fact there were more separators - with the possibility of more still - made a "find" based approach attractive - but the embedded nulls required the fragile string length in there.

I see. Tip: next time you need to do that kind of "find" including '\0', you can use good ol' strchr ;)

Hmm... it would work (and is less brittle). Not sure I like it, though.


array/map to string cast behavior

The documentation states:

<IP_ADDRESS>. To string
...
From array
An array value is formatted as a JSON array:
[1, "2", 3.4]::string -- => "[1,""2"",3.4]"

From map
A map value is formatted as a JSON object:
{"a": 1, "b": "2", "c": 3.4}::string -- => "{""a"":1,""b"":""2"",""c"":3.4}"

I am not sure if this is a bug in the documentation, in the code, or in the shell, but when EVALing these examples in the shell, I get the following:
> EVAL [1, "2", 3.4]::string;
"[1,\"2\",3.4]"
> EVAL {"a": 1, "b": "2", "c": 3.4}::string;
"{\"a\":1,\"b\":\"2\",\"c\":3.4}"

These results work very well when thrown into the JavaScript eval() function, but they are not valid BQL strings. Is this actually a shell issue?

OK, I got it. {"a": 1, "b": "2", "c": 3.4}::string results in the string
`{"a": 1, "b": "2", "c": 3.4}`  // Go syntax

and the SensorBee shell prints this in JSON-encoded form. In fact, running
> EVAL "{""a"":1,""b"":""2"",""c"":3.4}";
"{\"a\":1,\"b\":\"2\",\"c\":3.4}"

gives the same result as evaluating the map-to-string code. I assume this is intended behavior, will add a note about that to the documentation and close this issue. If anyone thinks we should change the behavior of the shell, please reopen this issue.

No, it isn't an intended behavior. The result of EVAL "{""a"":1,""b"":""2"",""c"":3.4}"; should be "{""a"":1,""b"":""2"",""c"":3.4}", not "{\"a\":1,\"b\":\"2\",\"c\":3.4}". Results of statements should be printed in the valid BQL syntax. Results of other statements like SELECT should be printed in the same way.

It might also be necessary to provide a way to print results in a JSON compatbile format.

This problem only affects the shell, so I'll provide a BQL compatbile formatting for now. It shouldn't be hard to switch JSON/BQL format.


Make SITL tests faster than real-time

This is work ~in progress~ to address #5026.
Edit/Update:
This is now closer to lockstep but not complete/correct yet. The way it works is that the simulator sets the time using the HIL_SENSOR message.
Things to try:

Set simulation speed using env variable PX4_SIM_SPEED_FACTOR:

PX4_SIM_SPEED_FACTOR=10 make posix jmavsim

or:
PX4_SIM_SPEED_FACTOR=10 make posix gazebo

Pause the simulation:
During the simulation, just press P in jMAVSim to toggle pause/resume.
For Gazebo you can hit the pause button in the the Gazebo viewer.

Issues, what is missing?

Once we start running it very fast (e.g. 10x), we see that sensors misses samples while the mc_att_ctrl keeps up and keeps working and generating actuator outputs and therefore drives the lockstep.
To debug this, enable the debug output in simulator_mavlink.cpp (https://github.com/PX4/Firmware/pull/10648/files#diff-23c67e906b712051714dd61b12fce367R297) Or you can also check this logfile where you see that the estimator is missing quite a few samples over time. -> Future work
~Integration with Gazebo is not started. I would get to this once jMAVSim is done.~
We get datalink lost/regained often unless you increase the timeout via param: e.g. COM_DL_LOSS_T = 30 -> Future work
The mavlink rates sent to QGC get quite high, e.g. 10x, and QGC stalls because of it. A workaround is to reduce the rates in mavlink start -r. -> Future work
perf is also fake when it probably should be using the "real" time. -> Future work
~It doesn't seem to work on macOS yet. With TCP it doesn't connect, and with UDP it does connect but then show: sim_send: px4_poll() sem error.~
~The unit tests stall or segfault (or both?).~
~We need to check if this works with ROS.~
~The unit tests and jMAVSim SITL don't work properly on Windows yet.~

We should be addressing Gazebo as well.

We should be addressing Gazebo as well.

For sure, currently I can't install Gazebo on my arch :sob:
https://aur.archlinux.org/packages/gazebo/, oh it looks like it's resolved, way to go!

@julianoes This looks great. FWIW for me the bigger problem is having the simulation work OK in slower environments like a VM so lockstep definitely wave of the future.

After many days of development and debugging I was able to push a working state of this with jMAVSim.
Make sure to try out:
PX4_SIM_SPEED_FACTOR=10 make posix jmavsim

@bkueng @dagar

Great work!

This is currently rebased on top of #10844. It now works on macOS.

macOS should work now!

Still build issues

For you? Or CI?

Note to self, fix unit tests:
      Start 11: hrt
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc

Gazebo lockstep can now be tested!

As discussed with @dagar I need to:

Make sure tests run with lockstep and without.
Add a board ID for unit tests.
Add board ID (or option) for replay without lockstep.

@dagar FW and VTOL tests fail, I need to reproduce these locally.

Haha, it turns out time is not random enough anymore and we get no noise on airspeed:
https://github.com/PX4/Firmware/blob/c1d50d35d334b36ded9b9279c945fc167848ea6b/src/modules/simulator/simulator_mavlink.cpp#L257

I think the tests should pass now, and then I'd suggest to merge this.

Looks like the Windows tests are flaky and I need to look into it.

The Windows build should be fixed. However, not to self: I should try if ekf replay still works.

@Tony3dr would be great if you could test fly this. I expect everything to be the same on NuttX.

@Tony3dr if you have a Raspberry Pi, you could/should test that too but if you don't nevermind.

I tested replay, and I believe it still works:
INFO  [replay] using replay log file: /home/julianoes/src/Firmware/build/px4_sitl_default/logs/2018-12-12/19_26_20.ulg
INFO  [replay] Ekf2 replay mode
INFO  [replay] Applying params from ULog file...
INFO  [px4] Startup script returned successfully
pxh> INFO  [replay] Replay in progress...
INFO  [ecl/EKF] EKF aligned, (pressure height, IMU buf: 22, OBS buf: 14)
INFO  [ecl/EKF] EKF GPS checks passed (WGS-84 origin set)
INFO  [ecl/EKF] EKF commencing GPS fusion
INFO  [replay] Replay done (published 11059 msgs, 0.000 s)
INFO  [replay]
INFO  [replay] Topic, Num Published, Num Error (no timestamp match found):
INFO  [replay] vehicle_gps_position: 429, 0
INFO  [replay] sensor_combined: 10942, 1296
INFO  [replay] vehicle_air_data: 4261, 24
INFO  [replay] vehicle_magnetometer: 4270, 9

FYI: @priseborough

Tested on pixhawk 4 mini. good flight.
https://review.px4.io/plot_app?log=d8e16b5b-0e75-4ad0-a515-292897fe5370

tested on pixhawk v4 pro
https://review.px4.io/plot_app?log=70330211-40f1-4895-a11a-96d70c416554

Alright, why is the build broken? :(

Ok, I suggest we merge this now and then iterate on it. Let me know if there are objections and I can address them but I don't want to have this dangle around which means I have to rebase again and again and fix what has been broken in the meantime.
Also, we should get #11059 in before this and then rebase it on top because this PR has the commits from #11059 cherry-picked.

@dagar @bkueng if you have no objections I would like to merge this today.

@julianoes master SITL broken on Windows 😢 I'll try to find the cause.

uorb top is empty and there's the yellow message saying:
WARN  WARN  [simulator] [simulator] Failed sending mavlink message: Address family not supported by protocolFailed sending mavlink message: Address family not supported by protoco

on start.

I had it running on Win. Can debug it Monday.

I tried to narrow down using the history but most commits don't build:

When I disable the lockstep scheduler by cmake define ENABLE_LOCKSTEP_SCHEDULER no I get:
[simulator] Failed sending mavlink message: Address family not supported by protocol
WARN  [simulator] Failed sending mavlink message: Address family not supported by protocol
WARN  [simulator] Failed sending mavlink message: Address family not supported by protocol
WARN  [simulator] Failed sending mavlink message: Address family not supported by protocol
WARN  [px4] mc_pos_control: px4_sem_timedwait failure: ret: 116, Connection timed out
WARN  [cdev] mc_pos_control: px4_poll() sem error: No error

repeating very fast.

@MaEtUgR I think this bug is around here:
simulator_mavlink.cpp
start line 654:
	struct sockaddr_in _myaddr {};
	_myaddr.sin_family = AF_INET;
	_myaddr.sin_addr.s_addr = htonl(INADDR_ANY);
	_myaddr.sin_port = htons(port);

Thanks @priseborough. Not sure why I missed that.
Fixed in https://github.com/PX4/sitl_gazebo/pull/261.

Follow up to Windows problems: #11101.


tflite_runtime==2.5.0

ERROR: Could not find a version that satisfies the requirement tflite_runtime==2.5.0 (from -r requirements.txt (line 5)) (from versions: none)
ERROR: No matching distribution found for tflite_runtime==2.5.0 (from -r requirements.txt (line 5))
Can not install this package for some reason. Does anyone know how to solve this?
My python version is 3.8.5

I solved this problem using this command:
pip3 install --extra-index-url https://google-coral.github.io/py-repo/ tflite_runtime


Bug fix: Upgrade pre-Django 1.10-style middleware

See https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-middleware
Fixes this error:
  File "…/lib/python3.5/site-packages/django/core/handlers/base.py", line 82, in load_middleware
    mw_instance = middleware(handler)
TypeError: object() takes no parameters

👍  Thanks :-)