Constant duplicates

Proposed change
When passing the arguments for the function _try_command() the string "Setting operation mode of the miio device failed."
is being repeatedly duplicated each time the function is called. In order to ensure good maintainability, a constant SET_OPERATION_MODE_FAILED has been defined. This makes it much easier for the developer in the future, if the string were to change, then it doesn't have to be changed in all eight instances.
Sonarcloud issue: https://sonarcloud.io/project/issues?directories=homeassistant%2Fcomponents%2Fxiaomi_miio&rules=python%3AS1192&issueStatuses=OPEN%2CCONFIRMED&id=salmonth_core&open=AZIe0iqbX8ftgn-d5jOH

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[ ] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

This PR has two aims. You should split them into two distinct PRs.


[WIP] cmd/govim: provide GOVIMGoImports and GOVIMGoFmt range commands

Currently blocked on https://github.com/golang/go/issues/31150

Added skips for now to bypass issues created by https://github.com/golang/go/issues/31759 and https://github.com/golang/go/issues/31150


Add id-attribute for suggest

please add the same to https://github.com/narqo/bem-suggest/blob/master/blocks/suggest/__control/suggest__control.bh.js

@tadatuta done

ok


one test for ft_strtrim is missing

Moulinette tests if ft_strtrim works properly when the set string has 2 or more same characters, like ",," or "...,,,,".

Added test for this test case


[AST] Mark '_functionBuilder' attribute as 'UserInaccessible' for now

This makes sure that it doesn't show up in code completion, as it's an underscored attribute.
Resolves SR-12916

@swift-ci please smoke test

This also affects SymbolGraph. Just to make sure, @bitjammer, now @_functionBuilder attribute doesn't show up in declaration fragments. Is it OK?

@swift-ci please smoke test macOS

Yes, it's ok. We don't show underscored attributes by default there. Thanks @rintaro!

@rintaro Does this need to be cherry-picked to 5.3 as well?

I'm not 100% sure it'll be approved. But yeah, I think it's worth it.


mangled names not correct for visual studio

Brief Description
With version 0.11.2 of cppSharp  I tried to wrap a small c++ test dll for csharp. Native dll was compiled with visual studio 2019 msvc compiler.
The produced binding source Sample.cs did not work.
The mangled names in for P/Invoke in Sample.cs  e.g. contain @@QEAA,
while the native dll exports @@QAE
(the header files as well as the native .lib were given to ILibrary.Setup() )
Should cppSharp work with msvc in general, or are there settings possible for this?
OS: Windows 10
class SampleLibrary: ILibrary
{
public override void Setup(Driver driver)
{
var options = driver.Options;
options.GeneratorKind = CppSharp.Generators.GeneratorKind.CSharp;
var module = options.AddModule("Sample");
module.IncludeDirs.Add(@"........\cd_native\src");
module.Headers.Add("ICurve.h");
module.Headers.Add("CCurve.h");
module.Headers.Add("Sample.h");
module.LibraryDirs.Add(@"........\Debug");
module.Libraries.Add("cd_native.lib");
}
...
export of a class constructor e.g.
??0CCurve@@QAE@ABV0@@Z = @ILT+2175(??0CCurve@@QAE@ABV0@@Z)
does not match generated sample.cs:
[SuppressUnmanagedCodeSecurity, DllImport("Sample", EntryPoint = "??0CCurve@@QEAA@AEBV0@@Z", CallingConvention = __CallingConvention.Cdecl)]
Thank you for any hints

This seems like a 32/64-bit mismatch.
Set your target triple to either x86_64-pc-win32-msvc or i686-pc-win32-msvc.
Like so: parserOptions.TargetTriple = "triple";

This was the amazingly fastest answer I've ever got, thank you !
And it works indeed.
I didn't find that point in the documentation it there  another documentation place that I have missed?
And so I understood correctly: I cannot build a C# wrapper, that works as AnyCPU  with 32bit and 64bit (by loading the correct native dll), because the native names are different?
Thank you very much!

Indeed, we do not support universal AnyCPU C# wrappers since the symbols and offsets are different per architecture/OS.
It wasn't documented so far, I've updated the users manual with this information now: https://github.com/mono/CppSharp/blob/main/docs/UsersManual.md#3-native-targets

Thank you very much again!


[BUG] Unable to generate report for GoLang

Describe the bug
Unable to get dependency report with Go 19.1 on Windows or MacOS.
To Reproduce
Steps to reproduce the behavior:

Open a clone of a Go repo (like https://github.com/spiffe/spire).
Right-click on the go.mod file and click "Dependency Analytics Report"
I get the error below

CMD :go get -u github.com/fabric8-analytics/cli-tools/gomanifest && C:\Users\Keegan\AppData\Local\Temp\gomanifest\bin\gomanifest "c:\Users\Keegan\Documents\GitHub\forks\spire" "c:\Users\Keegan\Documents\GitHub\forks\spire\target\golist.json" "go"
 STDOUT :
 STDERR : go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

VSCode(please complete the following information):

OS: MacOS and Windows 10
VSCode version 1.73.1
Dependency Analytics Version 0.3.6

Additional context
This might be related to #504.

I am running into the same issue. It looks like it worked on go 1.17, but after switching to g1.18, this issue popped up.
 CMD :go get -u github.com/fabric8-analytics/cli-tools/gomanifest && /tmp/gomanifest/bin/gomanifest "/home/jreimann/git/argo-cd" "/home/jreimann/git/argo-cd/target/golist.json" "go"
 STDOUT :
 STDERR : go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

 error : Error: Command failed: go get -u github.com/fabric8-analytics/cli-tools/gomanifest && /tmp/gomanifest/bin/gomanifest "/home/jreimann/git/argo-cd" "/home/jreimann/git/argo-cd/target/golist.json" "go"
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Maybe the reason is: https://tip.golang.org/doc/go1.18#go-get

Looks like the PR linked is helpful. Can someone with write access please check ?

https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/pull/608 seems to address this.


[Feature] Support get k8s pod log for interactive RayJob

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently, RayJob supports interactive submission, but there is a problem that without the submitter pod, the log information of RayJob cannot be obtained on the k8s cluster. Is there any solution?
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Hi @Moonquakes,
You can find job logs at /tmp/ray/session_date/logs/job-driver-{job_id}.log in your ray cluster pods.


PySpectra Exception: Binary is broken, please check the key again

Hei I got this issue "PySpectra Exception: Binary is broken, please check the key again" how to fix it?

Thank you sir, it seems there's something wrong with the images


[1.18.2] Client crash while playing

game mod with errors, as follows:

create-diesel-generators-1.18.2-1.2f
valkyrienskies-118-forge-2.1.1-beta.6+b1ee932637
create_interactive-forge-1.0.0-beta.1+fead03adaf
create-1.18.2-0.5.1.f

game crash log: crash-2024-01-31_00.53.41-server.txt
When I structure the train, if there are Huge Diesel Engines  above the train, the game will crash.

After the game crashes and I re-enter the map, the game still crashes.
If Huge Diesel Engines is placed on a already structured train, the game will also crash.

It's gonna get fixed in 1.2g

should be fixed


Fixed Android SDK install crash when updating the Tools package

We no longer update the Tools package as part of Android SDK configuration step. The Tools package already comes installed by default with the Android SDK zip file.
This essentially is a workaround for the current Android SDK crash when updating from Tools 24.3.3 to Tools 24.4 on Windows. This also speeds up the install-reqs process, and helps being future-proof against breaking changes, because we now use a static version of the Tools package.

:+1:  but this should go into Release branch instead...

Closing this PR, I have created a new one against Release branch.


bug: flowchart does not render

The following content does not render:
Prompt:

Create a diagram using mermaid.js that shows the architecture of a browser extension

Code:
graph TD;
  A[Browser] -->|1. Loads Extension| B[Extension Background];
  B -->|2. Communicates with Content Scripts| C[Content Scripts];
  B -->|3. Interacts with Browser APIs| D[Browser APIs];
  C -->|4. Manipulates Web Pages| E[Web Pages];
  D -->|5. Accesses and Modifies Browser Features| E;
  E -->|6. Sends Data and Events to Content Scripts| C;
  C -->|7. Sends Data and Events to Background| B;
  B -->|8. Updates UI and Listens for User Actions| F[Extension UI];
  F -->|9. Communicates with Background| B;

Screenshot:

Interestingly, it does seem like content might be there, just not visible

Seemed to be a packaging issue w/ the old extension


functions should extend from function icon class

Reported by dietmarw on 29 Jun 2012 16:38 UTC
There are several functions in (at least) Spice3 don't extend from the Modelica.Icons.Function class as they should.

Migrated-From: https://trac.modelica.org/Modelica/ticket/770

Comment by majetta on 31 Jul 2012 09:59 UTC
Please see !#782

Modified by dietmarw on 31 Jul 2012 10:38 UTC


Add support for module versions on el8

CentOS-8 - AppStream 1.14
CentOS-8 - AppStream 1.16
Extra Packages 1.17

# dnf-epel module list nginx
CentOS-8 - AppStream
Name                             Stream                             Profiles                                 Summary
nginx                            1.14 [d]                           common [d]                               nginx webserver
nginx                            1.16 [e]                           common [d] [i]                           nginx webserver

Extra Packages for Enterprise Linux Modular 8 - x86_64
Name                             Stream                             Profiles                                 Summary
nginx                            mainline                           common                                   nginx webserver

Hint: [d]efault, [e]nabled, [x]disabled, [i]nstalled

Fixed and released.
https://github.com/jfut/nginx-module-auth-pam-rpm/releases/tag/v1.5.2-2


remove use of log4jv1 - no longer supported and has security vulnerabilities

BUG REPORT
Related to but separate from https://github.com/apache/rocketmq/issues/3816
https://github.com/apache/rocketmq/blob/develop/pom.xml#L582
log4j v1 is not supported (EOL) and numerous CVEs are open against it

ideally use log4jv2 instead
reload4j is a drop-in replacement for log4jv1 - but ideally, rocketmq should standardise on one log framework and log4jv2 is  used in rocketmq too

log4jv1 is still in use in some subprojects
[ERROR]   The project org.apache.rocketmq:rocketmq-logappender:4.9.3-SNAPSHOT (/home/travis/build/apache/rocketmq/logappender/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for log4j:log4j:jar is missing. @ org.apache.rocketmq:rocketmq-logappender:[unknown-version], /home/travis/build/apache/rocketmq/logappender/pom.xml, line 35, column 21
[ERROR]
[ERROR]   The project org.apache.rocketmq:rocketmq-test:4.9.3-SNAPSHOT (/home/travis/build/apache/rocketmq/test/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for log4j:log4j:jar is missing. @ org.apache.rocketmq:rocketmq-test:[unknown-version], /home/travis/build/apache/rocketmq/test/pom.xml, line 31, column 21

rocketmq-logappender supports a few log frameworks - would it be possible just to remove RocketmqLog4jAppender (the log4jv1 support)?

@pjfanning Support for Log4j v1 is still necessary for users who send log message to RocketMQ through Log4j V1 interface. And a discuss has launched for moving rocketmq-logappender to rocketmq-externals repo, please find it in dev mail list.


Why are these repeated?

<requestCaching> Element (Network Settings)	Specifies the modules used to request information from Internet hosts.
<requestCaching> Element (Network Settings)	Configures basic network options for the System.Net namespace.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 489be477-8555-f4f3-06c2-c65419786c3a
Version Independent ID: feff90fe-26a0-bf8b-3a87-260f5cd59611
Content: Network Settings Schema
Content Source: docs/framework/configure-apps/file-schema/network/index.md
Product: dotnet-framework
GitHub Login: @mcleblanc
Microsoft Alias: markl

Thanks for pointing this out, @hagatorn. The duplication is an unintentional one that has persisted for a long time in our documentation set. I've opened PR #6585 to eliminate the duplicate item and correct the description.


Add setting to not treat indented empty lines as trailing whitespace

VSCode currently treats any whitespace at the end of a line as "trailing" whitespace.
However, I would consider the below 2 lines to be different:

The first line unambiguously has trailing whitespace, and I'd like to automatically trim that (with files.trimTrailingWhitespace set to true).
But I'd consider the second line to be an empty line with indentation (the line contains only whitespace, or more specifically: indentation == trailing whitespace).
I'm moving to VSCode from Atom, which has a "Remove Trailing Whitespace" config option, but also has "Ignore Whitespace Only Lines", enabling this kind of functionality.

"Ignore Whitespace Only Lines" would be good enough (I'd be very happy if this was added), but "Keep Indentation on Empty Lines" would be perfect. If the second line in the above example had 6 spaces, I'd like it to be trimmed to 4 spaces (the indentation in the current block).
I'm not sure how VSCode tracks indentation internally, but the way I do this in a custom lint script, is to look at the next non-whitespace line (backwards loop over all lines), and copy the indentation on that line to the empty lines before it. So, the end result (in Python) is:

(line 132 has 4, not 8, spaces)
I realize that this may be way too specific (I'll look into writing an extension, if you feel this doesn't apply to very many users), and "Ignore Whitespace Only Lines" would be much simpler to implement, and based on Atom's config options, lots of users would probably like to see this.

Ah, I didn't find https://github.com/Microsoft/vscode/issues/49661, but I'll leave this open for now, since this has a slightly wider scope ("keep indentation" vs. "ignore whitespace-only lines").
But feel free to close this, if "keep indentation" isn't something you would implement (I'd be happy with the "ignore" option).

yep
we need
Keep Indentation on Empty Lines

:+1: Let's track in #49661


Add sample for pubsub_commit_avro_schema

This is a Node sample for schema revisions.
ref: 266567049

Closed in favour of https://github.com/googleapis/nodejs-pubsub/issues/1741


How to ?

Hey mate !
Thanks for the job you did for this API.
Just questioning about the used cases. I'm not very familiar with API and I don't want to mistake.
My aim is to keep return from my oven, to know when something is cooking, door open / close , etc..
I'm using HomeBridge (to make smart product working with Apple Home platform) and I'm wondering if this is something that can be done easily ?
If you have some time to share about that it would be nice ! :)
Thanks for your time!

Hey,
searching for electrolux open api I found this new official website
https://developer.electrolux.one
I think they will close the other way sooner or later.


Whitelist +

+ doesn't have a special meaning in any mainstream shell as far as I can tell.  I have a case where a path like /usr/include/c++ is unnecessarily quoted.

Thanks!


Add User Ops

Add support for user defined operators or "user ops". User ops can call other ops within the same scope but recursive op calls are not allowed.
Closes #4152

In addition to the suggestions I've made, two other things:

I know this one was a bit complex to implement, and the docs as they stand seem to reflect some of the underlying complexity of the implementation. It's not clear to me if the user needs to have user-defined ops explained to them with terms like "context" and "scope". I don't feel proficient enough with language concepts to know quite what to suggest instead, though. Maybe it's reasonable that a user advanced enough to be wanting to create user-defined ops is going to be comfortable with the concepts. So, maybe no action required there, but just wanted to make the observation.

Yeah this is fair, a lot of this is because I was in the weeds while writing this. I think the term "scope" will be necessary and I wanted to refer to the "lateral scope" section of the docs but this doesn't quite capture the evolving nature of scopes. When I put up my scope pr I plan on moving scopes to its own section towards the top of the language overview. A scope is basically:
(
  decl
  sequence
)

Adding a new numbered section early in the doc does break a bunch of links as you've already fixed within the PR. However, there's cross-links from other docs that are going to break as well. We went through a similar exercise when user-defined functions went in, so you can see at db57e46 which other files I had to hit. If you want me to take care of that again and push a commit directly to the PR just let me know and I can put that on my to-do list.

I think we should remove the numbered sections in the docs. They are nice to have but they are pain to manage especially with the language evolving as it is.

Thanks @mattnibs. Responses on two topics:

Yes, on further reflection and after hearing your clarifications, I agree that "scope" surely needs to stay, and I like your idea about having a separation section just talking about scope as an independent concept. Other language docs have it. If we can find a way to avoid having to say "context" I still think that would  be an improvement.

I'm on the fence about the numbered sections. On one side there's things like RFCs that have always had numbered sections. I don't recall if I had a hand in introducing numbered sections to our docs back in the day, but if I had to guess, maybe it started because there were data format specs and such that had the feel of RFC-like docs that would hopefully get locked in place and similarly referenced almost like legal texts. Then on the other hand there's plenty of docs out there laid out somewhat like ours (Kubernetes, Grafana, Docusaurus, ...) that don't have numbered sections. I figure we can talk about it as a team and if nobody's super attached to them, I'd be happy to make the changes.

As for the deeper decisions on wording, I'm game to let @nwt have a look with fresh eyes, then see where that lands us.


docs: update install instruction

paddlepaddle2.0.0rc instruction can be found from main page
only two steps, install paddlepaddle and paddlegan, other than 3step

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Changes in UI

Added some  tags to some lines of code in the index.html

if you think this is a better style, it should be addressed via CSS not markup


[fakeintake] add low-level public API for fakeintake client

What does this PR do?

Add public functions to get payloads from the fakeintake, following squad discussions on possible designs. This adds a low-level public API, allowing for custom data manipulation after filtering by payload's name. It also adds a higher-level filtering function, accepting functors, with some out of the box ones.
Metric payloads name is the metric name, check runs uses the Name field, logs use the service field.
Examples in client_test can help usage in e2e tests. I might move Payload interface and its implementations to a separate package, and move helpers there (FilterByTag, etc)
Initially we fetch & parse payloads at each call to GetMetric, depending on performances we might improve this in the future.
Motivation

Allow for testing against the fakeintake.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

https://github.com/DataDog/datadog-agent/pull/16020#discussion_r1137518436
Wonder if we should return a MatchResult struct with err: error, isMatch: bool and matchScore: float. Maybe follow up


Correction to the docs on 'Enabling the content pack'

The documentation says:

In the admin center, expand the left nav, and go to Reports > Usage.
On the _Usage- page, locate the Microsoft 365 usage analytics card, and choose Get started.
On the Reports panel that opens, set Make data available the Microsoft 365 usage analytics for Power BI to On > Save.

That doesn't seem correct as Make data available the Microsoft 365 usage analytics for Power BI is currently available under Settings > Services & add-ins >> Reports.
Regardless of if the Admin preview is on or off.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ec8961e-4fc1-eb46-1e71-3147b55ac90e
Version Independent ID: 2c66ebfb-53b5-18ab-e560-702d4cae057f
Content: Enable Microsoft 365 usage analytics
Content Source: Office365-Admin/usage-analytics/enable-usage-analytics.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

@veronicageek  and @AndreaBarr - the steps in the topic are actually correct. The green field experience has the "Get Started" button there if you never set this up before.
In the Service&add-ins > reports you can uncheck to turn it off, I believe.
I am going to close the associated PR.


Segregating Keplr and Metamask Implementations

The PR divides the Keplr and Metamask implementations, to allow making it easier to modify the code while ensuring each module focuses on its specific tasks - Separation of Concerns
What I did:

Separated methods that interact with Keplr interaction in playWrightKeplr.js as a separate object. The Meta-mask-specific methods are placed inside an object in playWrightMetamask.js.
Separated methods relevant to Keplr operations in keplr.js in the commands folder. In the same folder, Meta-mask-specific stuff is present in metamask.js.
Separate plugin configs for Meta-mask and Keplr in plugins folder.
Test cases for Keplr are placed in keplr.spec.js file. While Meta-mask-specific test cases are in metamask.spec.js.
The differentiation between using Keplr-relevant configs and test cases is being identified through an environment variable EXTENSION that is passed through a package.json script. If EXTENSION has a value of keplr, we run Keplr relevant things otherwise meta-mask configs and test cases are run.

an important change that i think we should make regarding our plugins folder:
currently we have defined plugin function with the names setupMetamask or setupKeplr. rather than doing this we should have generic function names like setupWallet
later when someone else uses this library and decides to use it on a dapp that uses both metamask and keplr, they can just change the env variable instead of chaning every instance where they have written: cy.setupMetamask to cy.setupKeplr

an important change that i think we should make regarding our plugins folder:
currently we have defined plugin function with the names setupMetamask or setupKeplr. rather than doing this we should have generic function names like setupWallet
later when someone else uses this library and decides to use it on a dapp that uses both metamask and keplr, they can just change the env variable instead of chaning every instance where they have written: cy.setupMetamask to cy.setupKeplr

I'm somewhat mixed on this one! 😄 I believe that using explicit names helps in revealing intentions and minimizes confusion.
Also, it's super helpful when searching for files. For example, if I search setupWallet in the codebase, there will be lots of noise in my search results. That becomes tedious. On the other hand, if I were to search using specific names like setupKeplr, it would help me pinpoint exactly where that functionality is being used. I feel this helps improve the developer experience.
But yeah, it's very opinionated and subjective. 😄


Modify attr when djangorestframework_camel_case installed

Hi, thank you for this great package. After using it, I realized that we don't update the field attribute when djangorestframework_camel_case exists, so the field names still appear in snake_case. Do you think it would be nice to have this feature (especially since drf-spectacular supports it too)? If so, I am willing to help out.

Thank you for the comment, I will take a look on that solution 👏


Select Text Editor

It would be great if you could add preferred text editor options to OdinRunes. Currently, it only opens Notepad, while I want to test this on Notepad++
I could change my *.txt file association to Notepad++, but I really don't want to, lol.
Anyways, very cool, unique program.

@i486 Thank you for your feedback, great suggestion indeed. Will include that in future updates. Until then you can easily achieve your desired behavior as follows:

Just save your chat with your desired extension (for example chatplusplus) and set the default application for your desired extension to your desired editor.


Issue 12558 - Catch statement without an Exception specification should be disallowed

https://issues.dlang.org/show_bug.cgi?id=12558
Rationale:
The language should not encourage catching non-recoverable Error / Throwable exceptions, which the current syntax allows (and with ease):
import std.stdio;

void main()
{
    try {
        assert(0);
    } catch  // this catches any Throwable!
        writeln("Caught a Throwable");
}

At the very least this feature might have been useful for catching Exception types only. But implicitly catching Throwable's is IMHO way out of line. This is why I believe this syntax should go through a deprecation stage.
Note that this will only break code which compiles with -de (make deprecation an error).
Pinging for approval: @andralex @WalterBright
Before it can go green it requires:

https://github.com/D-Programming-Language/druntime/pull/772
https://github.com/D-Programming-Language/phobos/pull/2092

@ all, this pull request has conflicts and Andrej apparently deleted his GitHub account, so I think it can only be closed now. Is anyone interested in resurrecting it?

This can be rebased.  I see no strong arguments against this change.


libtensorflow.dll leaks icu symbols on Windows

System information

OS Platform and Distribution: Windows 10
TensorFlow installed from (source or binary): Self-compiled with bazel & from https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-windows-x86_64-1.12.0.zip
TensorFlow version: 1.12.0 & 1.13.0-rc2

Describe the problem
libtensorflow.dll exports a ton of symbols from icu. They should be private to the dll.
Any other info / logs
C:\Users\mfischer\Desktop>dumpbin /exports tensorflow-1.12.0.dll
Microsoft (R) COFF/PE Dumper Version 14.16.27027.1
Copyright (C) Microsoft Corporation.  All rights reserved.

Dump of file tensorflow-1.12.0.dll

File Type: DLL

  Section contains the following exports for libtensorflow.so

    00000000 characteristics
    5BDBAEF0 time date stamp Fri Nov  2 02:57:04 2018
        0.00 version
           1 ordinal base
        3078 number of functions
        3078 number of names

    ordinal hint RVA      name

          1    0 01841AA0 ??0?$MaybeStackArray@D$0CI@@icu_62@@AEAA@AEBV01@@Z
          2    1 023BC120 ??0?$MaybeStackArray@D$0CI@@icu_62@@QEAA@$$QEAV01@@Z
          3    2 023BC180 ??0?$MaybeStackArray@D$0CI@@icu_62@@QEAA@H@Z
          4    3 023BC200 ??0?$MaybeStackArray@D$0CI@@icu_62@@QEAA@XZ
          5    4 023C5F90 ??0Appendable@icu_62@@QEAA@AEBV01@@Z
          6    5 023C5F90 ??0Appendable@icu_62@@QEAA@XZ
          7    6 0245DC70 ??0BreakIterator@icu_62@@IEAA@AEBV01@@Z
          8    7 0245DCD0 ??0BreakIterator@icu_62@@IEAA@AEBVLocale@1@0@Z
          9    8 0245DD20 ??0BreakIterator@icu_62@@IEAA@XZ
         10    9 02399020 ??0ByteSink@icu_62@@QEAA@XZ
         11    A 02454B40 ??0BytesDictionaryMatcher@icu_62@@QEAA@AEBV01@@Z
         12    B 02454B70 ??0BytesDictionaryMatcher@icu_62@@QEAA@PEBDHPEAUUDataMemory@@@Z
         13    C 023CC750 ??0BytesTrie@icu_62@@AEAA@PEAXPEBX@Z
         14    D 023CC770 ??0BytesTrie@icu_62@@QEAA@AEBV01@@Z
         15    E 023CC7A0 ??0BytesTrie@icu_62@@QEAA@PEBX@Z
         16    F 0245BA10 ??0BytesTrieBuilder@icu_62@@QEAA@AEAW4UErrorCode@@@Z
         17   10 02458DB0 ??0CStr@icu_62@@QEAA@AEBVUnicodeString@1@@Z
         18   11 023D3F10 ??0CacheKeyBase@icu_62@@QEAA@AEBV01@@Z
         19   12 023D3F30 ??0CacheKeyBase@icu_62@@QEAA@XZ
         20   13 02459A80 ??0CanonicalIterator@icu_62@@QEAA@AEBVUnicodeString@1@AEAW4UErrorCode@@@Z
         21   14 02399030 ??0Char16Ptr@icu_62@@QEAA@$$T@Z
         22   15 02399030 ??0Char16Ptr@icu_62@@QEAA@PEAG@Z
         23   16 02399030 ??0Char16Ptr@icu_62@@QEAA@PEA_S@Z
         24   17 02399030 ??0Char16Ptr@icu_62@@QEAA@PEA_W@Z
         25   18 02459090 ??0CharString@icu_62@@QEAA@$$QEAV01@@Z
         26   19 023BC220 ??0CharString@icu_62@@QEAA@AEBV01@AEAW4UErrorCode@@@Z
         27   1A 023BC270 ??0CharString@icu_62@@QEAA@PEBDHAEAW4UErrorCode@@@Z
         28   1B 023BC2C0 ??0CharString@icu_62@@QEAA@VStringPiece@1@AEAW4UErrorCode@@@Z
         29   1C 023BC320 ??0CharString@icu_62@@QEAA@XZ
         30   1D 02459730 ??0CharacterIterator@icu_62@@IEAA@AEBV01@@Z
         31   1E 02459760 ??0CharacterIterator@icu_62@@IEAA@H@Z
         32   1F 02459790 ??0CharacterIterator@icu_62@@IEAA@HH@Z
...

@mika-fischer Could you explain more details on the problem and its context? Thanks!

I'm not sure what to say. libtensorflow.dll exports symbols for applications to use. It should only export the TF... symbols. Instead it also exports all of the symbols of its internal(!) dependency libicu. This is almost certainly a mistake.
The status quo creates problems when trying to link libtensorflow.dll into an application that already uses libicu because then the icu symbols would be present twice.
The build process needs to be fixed to not export those symbols. Looking at http://userguide.icu-project.org/packaging#TOC-Link-to-ICU-statically all you have to do is most probably define the C preprocessor symbol: U_STATIC_IMPLEMENTATION...

I think @hamatake did something to address this in 7e090f6a5412fd5f22b5b75ca7ae7844c3d025e9, but perhaps the fix didn't completely solve the problem?

Actually 7e090f6 should fix this issue. But it definitely is not fixed in https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-windows-x86_64-1.13.1.zip
Are there nightly master libtensorflow zips that I could check to see if it's fixed in master?

I'm not sure if we publish nightlies for that build.
@av8ramit I noticed that you made a change internally (209826891) that caches artifacts for a libtensorflow CPU build on Windows, but do you know if these are published anywhere?

Well, it's easy enough to check: dumpbin /exports tensorflow.dll will print all exported symbols.

@mrry that was for the release packages unfortunately.

Unfortunately that change was rolled back because it didn't actually fix
the build in question. This dropped off my radar for awhile but it's back
on. I've reproduced the link failure on a windows machine and am working on
a fix.
On Fri, Mar 1, 2019 at 3:35 PM Amit Patankar<EMAIL_ADDRESS>wrote:

@mrry https://github.com/mrry that was for the release packages
unfortunately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/26084#issuecomment-468847701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEnCCPY-80fZC5C1w7tZqQ9VGBOr6DApks5vSbkjgaJpZM4bPnbn
.

This should be fixed by https://github.com/tensorflow/tensorflow/commit/025aa34d77b0ba1c9035cfa7b3c7f98bcccb1435#diff-76ffb659afb259c45a6303f170a6613a

Thanks @hamatake!


User request: a button to reset the progress in all of the chapters of a study

Also see https://github.com/Siderite/lichessTools/issues/861


TXTExport produces duplicates

As highlighted by @rekomodo on discourse, TXTExport produces duplicates in the output file, what may confuse a user.
Some suggestions from @RemDelaporteMathurin to improve this behaviour:

I guess the internal FESTIM process should be:

if there is only one material (or no conservation of chemical potential) then project to CG instead of DG
If there are interfaces, since TXTExport is only used in 1D, project to DG but only keep the duplicates where there are interfaces (based > on the materials border argument)

I think to start with we could at least make sure that values in the txt file are sorted by x

@RemDelaporteMathurin

If there are interfaces, since TXTExport is only used in 1D, project to DG but only keep the duplicates where there are interfaces (based > on the materials border argument)

Based on your recent example , such filtering might be more complex.

@RemDelaporteMathurin

If there are interfaces, since TXTExport is only used in 1D, project to DG but only keep the duplicates where there are interfaces (based > on the materials border argument)

if vertices of a mesh do not match the interfaces (borders), shall we try to keep duplicates near the interfaces?
Say:
model.materials = [
    F.Material(
        id=1,
        D_0=1,
        E_D=0,
        S_0=1,
        E_S=0,
        borders=[0,0.5]
    )
    F.Material(
        id=2,
        D_0=1,
        E_D=0,
        S_0=2,
        E_S=0,
        borders=[0.5,1.0]
    )
]

model.mesh = F.MeshFromVertices(
    np.linspace(0, 1, 30)
)

The closest vertices to the interface at x=0.5 are x=0.48275862 and x=0.51724138

We shouldn't condone this behaviour from users. Of course FESTIM would run but we should maybe throw a warning "vertices don't match interfaces" or something
if users still decide to do this for whatever reason, then we only keep the duplicate where the "fenics" interface is. I guess it's the closest vertex.

So in your example, we could do something along the lines of:
for vertex in vertices:
    if not isclose(vertex, interface_x):
        # remove duplicate

I think the first point can be addressed in a separate issue.


How to access Laradock from other VM (Parallels)

Info:

Docker version 18.09.0
Laradock commit d8c36ab86007f04293d380bcf8325cb70c76fdd0
System info Mac
System info disto/version: macOS Mojave 10.14.2

Issue:
Hi everyone and happy new year,
and thanks a lot for this great repository! It completely removes the need of Homestead! I use Laradock to serve multiple projects (as described in Installation: B) Setup for Multiple Projects) and it works like a charm!
I wonder, how I can access my sites through another computer on my local network; e.g. I use a Windows VM in Parallels and I need to test the web application in IE/Edge and I don't know how to access them. I tried to use the following entry in C:\Windows\System32\drivers\etc\hosts
<IP_ADDRESS>     laravel.test

But this didn't work.
Can you give me any tips how to connect to a Laradock app from my VM?!
Thanks in advance and have a nice day!

if laradock host ip is <IP_ADDRESS>
all other computer need set hosts file <IP_ADDRESS>  laravel.test
and laradock host must open firewall port 80
nginx container need  a site .conf file server_name laravel.test;


[core] Upgrade to Next.js 8

https://twitter.com/zeithq/status/1094882435714691072

The changes to with withTM have been released in 1.1.0
https://github.com/martpie/next-plugin-transpile-modules/commit/a290879b790bb59fea0b8d16bb629e3fc17cf6a0
I think the weco npm package is not maintained. Hence I used martpie's package.

@azizhk Sweet, I'm trying that out :)


[Feature request] Support for named group syntax in no-custom-classname

Is your feature request related to a problem? Please describe.
Tailwind CSS 3.2 introduced a new syntax for naming groups, see https://tailwindcss.com/blog/tailwindcss-v3-2#nested-group-and-multiple-peer-support-using-variant-modifiers
This syntax is incorrectly reported as a custom class by tailwindcss/no-custom-classname rule.
Describe the solution you'd like
The rule should be updated to recognize named groups.

Looking forward to this feature!

Hi! Thanks for creating the issue @cmlenz 🙏 Have you found a clean way to make the warning disappear?

Have you found a clean way to make the warning disappear (instead of disabling tailwindcss/no-custom-classname)?

@atoulmet No, that's what we've done for now.


fix: use ethereum.isMetamask for connect

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
1.0.1

Your semantic-release bot :package::rocket:


Broken multi WYSIWYG behat test

tests/Behat/features/multiple-wysiwyg-configs.feature:17
https://github.com/silverstripe/silverstripe-elemental/actions/runs/7726060510/job/21083852150

This issue should be already fixed in 5.1 by this PR

Sweet. Doing a merge-up now to see if that resolves it for 5

CI passed https://github.com/silverstripe/silverstripe-elemental/actions/runs/7736041586


Show pool asset images

Show pool assets in pool pages. Will help people scan the composition of the pool and will provide visual interest.
May be worth looking into cache policy for assets to reduce request counts.
Contributes to issue #152.

Closing due to refactor/redesign


Specify version of imageio to download from conda-forge

Specify version of imageio in order to download from conda-forge. This is required to make imageio.plugins.ffmpeg.download() work.
Should fix https://github.com/udacity/CarND-LaneLines-P1/issues/15.

thanks @markito


vlc+scummvm: Update plugs and confinement

Can you update the relevant README.md files too?

Brilliant work!


Rework intro

Closes #41

Do we want to leave out external usages of the safe contracts completely?

I don't remember why I removed it. -> re added.


Send and receive messages with threads

For now just adding support on RTM.
@gilbertw1 please review

Reviewing now. Thanks for the contribution!

Merged. Sorry for the huge delay!


feat(turborepo): implement --affected flag

Description

Testing Instructions

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8884  👈
#8883
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NicholasLYang and the rest of your teammates on  Graphite


Should we be testing for _FieldSet / FieldSet directly

We're not currently checking to see if a _FieldSet (Fed 1) / FieldSet (Fed 2) scalar is available in the implemented products subgraph. Let's confirm:

If we should be testing for this
That we should test for _FieldSet with Fed 1 and FieldSet with Fed 2
Find out why _FieldSet was renamed to FieldSet

https://community.apollographql.com/t/why-was-fieldset-changed-to-fieldset/4035
:-)


Enable commenting on blog posts

Copying info from the comment thread on issue #205:
Initial suggestion of adding comments to the blog comes from @pdmack
From @abhi-g :
[We] need to figure out how to enable comments with Hugo.
Since Hugo is a static site generator, there is no out of the box solution for comments. They do suggest using Disqus for comments, and that can be easily plugged in. Other options are listed at bottom of that page. Anyone has experience with either of those?
From @pdmack :
https://utteranc.es/ looks interesting. Basically the comments would become GitHub issues in our website repo?
When Utterances loads, the GitHub issue search API is used to find the issue associated with the page based on url, pathname or title. If we cannot find an issue that matches the page, no problem, utterances-bot will automatically create an issue the first time someone comments.

Closing this issue, as we've moved the Kubeflow blog to Medium:
https://medium.com/kubeflow
/close


Write Active Sessions Endpoint Issue #6

Status:
🚧
Description
I basically wrote the Create getAllActive sessions endpoint which operates on three conditions. If there are >= 10 active sessions, all will be displayed. Else, if there are <10 active sessions, inactive sessions will populate until there are 10 sessions on the home page in ascending start time order. Else, if the sum of active and inactive sessions is <10, all will be displayed. And eureka, it works! (so far)
Fixes #6
Todos

Make a test case for the last condition in Postman
run more thorough test cases for sessions

Screenshots

d a r n, forgot format again


add to z control config

please meanwhile Avalon-extras/scripts/build-avalon-image.sh file.

@yangjun2017
Thanks for your PR.
SmartSpeed+ is not same as SmartSpeed.
You can find some develop information through GitHub.
https://github.com/Canaan-Creative/avalon7-docs/wiki/AvalonMiner-721-development#Run_with_ssplus


[imgui] Support building as shared library

Describe the pull request

What does your PR fix?
Support building ImGui as a shared library.
ImGui author does not recommend building the library as shared libraries, as the author is concerned about function call overhead of shared libraries, and also that the library uses global states throughout may cause problems. But anyway, it is better to have this option.

Which triplets are supported/not supported? Have you updated the CI baseline?
All; no.

Does your PR follow the maintainer guide?
Yes.

Yes.

Imgui author said this library always needs to be built as a static library.

Imgui author said this library always needs to be built as a static library.

IIRC this is because imgui don't have a stable ABI and therefore breaks when just replaceing the dll/so with a newer version.
So the imgui target should then have the SOVERSION with the full version property set and the dll should get the full version inserted to the resulting dll name, to not allow a updating by just replacing the dll/so file.

Do we still need to care about the ABI when vcpkg just maintains a single version for each library so that every package compiles and links fine together? If someone is using vcpkg there is no chance that they link their binary with an incorrect version of ImGui right?

The thing with dlls is, that a user should be able to replace dlls with a compatible dll. So a user could build a newer imgui and expect that he could just replace it. However this would not work in this case, therefore we have to link with the exact version

See https://github.com/ocornut/imgui/pull/1713 and https://github.com/eliasdaler/imgui-sfml/issues/113

I am pretty sure we had a big argument about this and resolved to respect upstream's wishes to not provide a shared library of imgui, but I'm not being successful at finding it right now...

I am pretty sure we had a big argument about this and resolved to respect upstream's wishes to not provide a shared library of imgui, but I'm not being successful at finding it right now...

See https://github.com/microsoft/vcpkg/pull/15063#issuecomment-749991792

Since the owner clearly stated that this port should not be built as a dynamic library, and when it is built as a dynamic library, obvious bugs will occur, close this PR.


STM32H7 SPI123 incorrect clock source used for prescaler calculation

Describe the bug
In the STM32H7 series the assumed clock source is incorrect when using SPI1, 2 or 3. This incorrect clock source is then used to calculate the clock prescaler (SPI_CFG:MBR), which can then potentially be calculated incorrectly. More specifically, it assumes the SCK clock source is, for example APB2, while it's by actually by default PLL1Q. This resulted that our custom STM32H743 implementation is outputting an incorrect SPI clock frequency.
This is because for the H7 series the SPI1, 2, and 3 has a seperate clock domain that governs the SCK speed. See the following snippet from RM0433 Figure 609.

Here spi_ker_ck is the SCLK source, not PCLK (f.i. APB2). The value of the spi_ker_ck is set by RCC_D2CCIP1R : SPI123SEL, which is pll1_q_ck by default.
To Reproduce
We can slightly adjust the nucleo_h743zi DTS and abuse the led_ws2812 app to easily see this behaviour.

I'm running this commit from the main branch e2588d6a42
Slightly adjust your code by either:
a. Checking out this branch
b. Applying the patch nucleo-configuration-patch supplied below.

[Optional] Add print-clocks-output patch to print out debugging clock information

west build -p auto -b nucleo_h743zi samples/drivers/led_ws2812/
west flash onto a nucleo_h743zi
Probe CN7:10 (D13 or SPI_A_SCK or SPI_1_SCK) with an oscilloscope
Witness the SCK frequency incorrectly being 6MHz instead of the desired and calculated 3MHz.

It will also output the following with the optional logging patch
[00:00:00.005,000] <err> spi_ll_stm32: Is this SPI1? 1
[00:00:00.005,000] <err> spi_ll_stm32: spi clock bus: STM32_CLOCK_BUS_APB2
[00:00:00.005,000] <err> spi_ll_stm32: STM32_CLOCK_BUS_APB2 freq: 96000000
[00:00:00.005,000] <err> spi_ll_stm32: LL_RCC_SPI123_CLKSOURCE: LL_RCC_SPI123_CLKSOURCE_PLL1Q
[00:00:00.005,000] <err> spi_ll_stm32: pllq freq: 192000000
[00:00:00.005,000] <err> spi_ll_stm32: Desired frequency: 3000000
[00:00:00.005,000] <err> spi_ll_stm32: BR: 5 should create clock of freq: 3000000
[00:00:00.005,000] <err> spi_ll_stm32: Resulting actual clock clock with PLL: 6000000

Expected behavior
Expect the prescaler calculation to use the correct clock source to output the desired frequency.
Impact
Hard to notice issues with incorrect SPI frequencies meaning devices run slower/faster than designed for.
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK 0.13.2
Commit SHA: e2588d6a42

Additional Context
I created #40998 to attempt to fix this issue, but ABOSTM found a showstopping flaw in my implementation. We then proposed a new sollution would be to:

Use the default spi_ker_ck value, since it's not possible to set two clocks the DTS. This means SCK source will always be PLL1Q.
When calculating the prescaler use PLL1Q clock value.
Add checks to ensure PPL1Q is enabled and #error if not.

I will try to create a fix for this implementation soon. However, I'm not sure yet what would be the best way to calculate the PLL1Q frequency, and would like some thoughts on that. The way I did it in the patch below is quite ugly.
It's coincidance that this has gone unnoticed during previous SPI driver testing. If I understand correctly then the Nucleo H743zi is popular for STM32H7 testing, and the PLL1 Q divider usually sets the clock up by chance that PLL1Q == APB2. Therefore I had to change the dts in the patch below to change pll1_q divisor from 4 to 1 to highlight this issue.
Patches
nucleo-configuration-patch
From 21c48a1f7ec70e773cf7639c3d0a3175ab390ff3 Mon Sep 17 00:00:00 2001
From: Hein Wessels<EMAIL_ADDRESS>Date: Fri, 7 Jan 2022 14:19:30 +0100
Subject: [PATCH] nucleo config

---
 .../led_ws2812/boards/nucleo_h743.conf        |  2 +
 .../led_ws2812/boards/nucleo_h743zi.overlay   | 39 +++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 samples/drivers/led_ws2812/boards/nucleo_h743.conf
 create mode 100644 samples/drivers/led_ws2812/boards/nucleo_h743zi.overlay

diff --git a/samples/drivers/led_ws2812/boards/nucleo_h743.conf b/samples/drivers/led_ws2812/boards/nucleo_h743.conf
new file mode 100644
index<PHONE_NUMBER>..319a42ce98
--- /dev/null
+++ b/samples/drivers/led_ws2812/boards/nucleo_h743.conf
@@ -0,0 +1,2 @@
+CONFIG_WS2812_STRIP_SPI=y
+CONFIG_SPI=y
diff --git a/samples/drivers/led_ws2812/boards/nucleo_h743zi.overlay b/samples/drivers/led_ws2812/boards/nucleo_h743zi.overlay
new file mode 100644
index<PHONE_NUMBER>..0d1fba0ac4
--- /dev/null
+++ b/samples/drivers/led_ws2812/boards/nucleo_h743zi.overlay
@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2021, STMicroelectronics
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include <dt-bindings/led/led.h>
+
+arduino_spi: &spi1 {};
+
+
+&arduino_spi {
+	led_strip: ws2812@0 {
+		compatible = "worldsemi,ws2812-spi";
+		label = "WS2812";
+
+		/* SPI */
+		reg = <0>; /* ignored, but necessary for SPI bindings */
+		spi-max-frequency = <3000000>;
+
+		/* WS2812 */
+		chain-length = <16>; /* arbitrary; change at will */
+		spi-one-frame = <0x70>;
+		spi-zero-frame = <0x40>;
+		color-mapping = <LED_COLOR_ID_GREEN
+				 LED_COLOR_ID_RED
+				 LED_COLOR_ID_BLUE>;
+	};
+};
+
+/ {
+	aliases {
+		led-strip = &led_strip;
+	};
+};
+
+&pll{
+	div-q = <1>;
+};
\ No newline at end of file
--
2.25.1

print-clocks-output
From e376b740607da0f007265748cdae4defbb02bc1e Mon Sep 17 00:00:00 2001
From: Hein Wessels<EMAIL_ADDRESS>Date: Fri, 7 Jan 2022 14:46:26 +0100
Subject: [PATCH] Add log output

---
 drivers/spi/spi_ll_stm32.c | 94 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/drivers/spi/spi_ll_stm32.c b/drivers/spi/spi_ll_stm32.c
index 47a5ae01d6..d779329ca0 100644
--- a/drivers/spi/spi_ll_stm32.c
+++ b/drivers/spi/spi_ll_stm32.c
@@ -451,6 +451,72 @@ static void spi_stm32_isr(const struct device *dev)
 }
 #endif

+#include <stm32_ll_rcc.h>
+
+#define PLLQ_FREQ(pllsrc_freq, divm, divn, divq)	(((pllsrc_freq)*\
+							(divn))/((divm)*(divq)))
+
+static inline uint32_t get_pllsrc_frequency(void)
+{
+	switch (LL_RCC_PLL_GetSource()) {
+	case LL_RCC_PLLSOURCE_HSI:
+		return HSI_VALUE;
+	case LL_RCC_PLLSOURCE_CSI:
+		return CSI_VALUE;
+	case LL_RCC_PLLSOURCE_HSE:
+		return HSE_VALUE;
+	case LL_RCC_PLLSOURCE_NONE:
+	default:
+		return 0;
+	}
+}
+
+static uint32_t get_pllq_frequency(void)
+{
+	uint32_t sysclk = 0;
+	uint32_t hpre = 0;
+	uint32_t hsidiv = 0;
+
+	/* Get the current HSI divider */
+	switch (LL_RCC_HSI_GetDivider()) {
+	case LL_RCC_HSI_DIV2:
+		hsidiv = 2;
+		break;
+	case LL_RCC_HSI_DIV4:
+		hsidiv = 4;
+		break;
+	case LL_RCC_HSI_DIV8:
+		hsidiv = 8;
+		break;
+	case LL_RCC_HSI_DIV1:
+	default:
+		hsidiv = 1;
+		break;
+	}
+
+	/* Get the current system clock source */
+	switch (LL_RCC_GetSysClkSource()) {
+	case LL_RCC_SYS_CLKSOURCE_STATUS_HSI:
+		sysclk = HSI_VALUE/hsidiv;
+		break;
+	case LL_RCC_SYS_CLKSOURCE_STATUS_CSI:
+		sysclk = CSI_VALUE;
+		break;
+	case LL_RCC_SYS_CLKSOURCE_STATUS_HSE:
+		sysclk = HSE_VALUE;
+		break;
+	case LL_RCC_SYS_CLKSOURCE_STATUS_PLL1:
+		sysclk = PLLQ_FREQ(get_pllsrc_frequency(),
+				   LL_RCC_PLL1_GetM(),
+				   LL_RCC_PLL1_GetN(),
+				   LL_RCC_PLL1_GetQ());
+		break;
+	}
+
+	return sysclk;
+
+}
+
 static int spi_stm32_configure(const struct device *dev,
 			       const struct spi_config *config)
 {
@@ -486,13 +552,41 @@ static int spi_stm32_configure(const struct device *dev,
 		return -EIO;
 	}

+	LOG_ERR("Is this SPI1? %d", spi == SPI1);
+	LOG_ERR("spi clock bus: %s", cfg->pclken.bus == 3 ? "STM32_CLOCK_BUS_APB2" : "something else" );
+	LOG_ERR("STM32_CLOCK_BUS_APB2 freq: %d", clock);
+
+	switch(LL_RCC_GetSPIClockSource(LL_RCC_SPI123_CLKSOURCE)){
+		case LL_RCC_SPI123_CLKSOURCE_PLL1Q:
+			LOG_ERR("LL_RCC_SPI123_CLKSOURCE: %s", "LL_RCC_SPI123_CLKSOURCE_PLL1Q");
+			break;
+		case LL_RCC_SPI123_CLKSOURCE_PLL2P:
+			LOG_ERR("LL_RCC_SPI123_CLKSOURCE: %s", "LL_RCC_SPI123_CLKSOURCE_PLL2P");
+			break;
+		case LL_RCC_SPI123_CLKSOURCE_PLL3P:
+			LOG_ERR("LL_RCC_SPI123_CLKSOURCE: %s", "LL_RCC_SPI123_CLKSOURCE_PLL3P");
+			break;
+		case LL_RCC_SPI123_CLKSOURCE_I2S_CKIN:
+			LOG_ERR("LL_RCC_SPI123_CLKSOURCE: %s", "LL_RCC_SPI123_CLKSOURCE_I2S_CKIN");
+			break;
+		case LL_RCC_SPI123_CLKSOURCE_CLKP:
+			LOG_ERR("LL_RCC_SPI123_CLKSOURCE: %s", "LL_RCC_SPI123_CLKSOURCE_CLKP");
+			break;
+	}
+	LOG_ERR("pllq freq: %d", get_pllq_frequency());
+
+	LOG_ERR("Desired frequency: %d", config->frequency);
+
 	for (br = 1 ; br <= ARRAY_SIZE(scaler) ; ++br) {
 		uint32_t clk = clock >> br;

 		if (clk <= config->frequency) {
+			LOG_ERR("BR: %d should create clock of freq: %d", br, clk);
 			break;
 		}
 	}
+
+	LOG_ERR("Resulting actual clock clock with PLL: %d", get_pllq_frequency() >> br);

 	if (br > ARRAY_SIZE(scaler)) {
 		LOG_ERR("Unsupported frequency %uHz, max %uHz, min %uHz",
--
2.25.1

Thanks for raising this @heinwessels.
I'm currently looking at supporting multiple/alternate peripheral clock source by STM32 clock_control driver.
One of the advantage would be to centralize most of the work in one common driver, rather than splitting
it in multiple peripheral drivers (which would also have to support similar problem for multiple series)
I still need to give it more thoughts before sharing more details but it looks like the case you mention would be a good starting point.
Btw, and this is a different topic but I see that the sample you're using is led_strip: ws2812.
This is worrying me a little since we have identified a different issue with this driver, along with a different solution.
Would you mind having a look to following points ?

https://github.com/zephyrproject-rtos/zephyr/issues/38683 (identified issue)
https://github.com/zephyrproject-rtos/zephyr/pull/40860 (proposed solution)
I'd like to be sure this is orthogonal to the problem you're seeing on H7 SPI clocks.

Btw, and this is a different topic but I see that the sample you're using is led_strip: ws2812. This is worrying me a little since we have identified a different issue with this driver, along with a different solution. Would you mind having a look to following points ?

@erwango I do believe this not at all a framing issue, and therefore not related to the issue you mentioned. It's also not limited to the ws2812 at all. I picked up this issue when using the SPI for normal communiation (controlling a ili9341 LCD display). I simply used ws2812 sample as it seemed like the fastest way to get a dummy SPI peripheral running as minimal working example.

I'm currently looking at supporting multiple/alternate peripheral clock source by STM32 clock_control driver.
One of the advantage would be to centralize most of the work in one common driver, rather than splitting
it in multiple peripheral drivers (which would also have to support similar problem for multiple series)

Do you think I should still do an temporary fix for this SPI case in the mean time? A more comprehensive clock driver is the better solution, but it might still be some while off. There might be users running at different SPI frequencies without knowing it until then.

@erwango I do believe this not at all a framing issue, and therefore not related to the issue you mentioned. It's also not limited to the ws2812 at all. I picked up this issue when using the SPI for normal communiation (controlling a ili9341 LCD display). I simply used ws2812 sample as it seemed like the fastest way to get a dummy SPI peripheral running as minimal working example.

Ok. I didn't want to say this was the root cause of the clock issue you've identified, as it seems to be a well established issue.
I just wanted to be sure we're not colliding 2 different issues here by picking up an already broken example. And if not the case then I wonder if #40860 is required if you're able to get the sample working w/o it.
Though, anyway as mentioned, this is a totally different topic.

Do you think I should still do an temporary fix for this SPI case in the mean time?

One idea would be to push it as a PR and not getting it merged, so it is available to people that may face the issue.
It may also be a good comparison point to the upcoming clock_control driver enhancement.
I'm reluctant to merge this code if we already know it has to be removed rather soon, but in case of known delay, it is still an option.

I just wanted to be sure we're not colliding 2 different issues here by picking up an already broken example.

I don't think that's the case :) I made really sure that it's indeed a bug, because it's been giving me quite a few headaches.

I'm reluctant to merge this code if we already know it has to be removed rather soon, but in case of known delay, it is still an option.

I understand completely. Then it will be lower priority for me to create a temporary fix. In our implementation I will simply change the PLL Q divisor so that it matches the expected clock source frequency for now, since it's not used for anything else. Hacky, but should suffice until your refactoring at some point.


Moving generated libraries to generated directory

Issue #, if available: 1888
Description of changes:

Moved generated code to generated directory
modified legacy codebase to generate, build, and install using the new location for generated code

Check all that applies:

[x] Did a review by yourself.
[ ] Added proper tests to cover this PR. (If tests are not applicable, explain.)
Manually tested by running configuration, build, unit test, and install from clean environment with and without BUILD_ONLY parameter.
[x] Checked if this PR is a breaking (APIs have been changed) change.
No an API breaking changing, but forces upgrade of CMAKE for those having older than 3.12 in their toolchain. We were warning in every build about it since a year ago, and we are going to hold this from reaching main branch until version 1.10 is released.
[x] Checked if this PR will not introduce cross-platform inconsistent behavior.
[x] Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

[x] Linux
[ ] Windows
[ ] Android
[x] MacOS
[ ] IOS
[ ] Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Why don't you split the PR into 2 commits

update config and generator
manual re-generation run?

Why don't you split the PR into 2 commits

update config and generator
manual re-generation run?

The code in legacy cmake was used for finding where to generate, where to remove and  where to include all intertwined, by separating in 2 first commit would effectively be broken without extra work.

Isolated real change from generation for easier review. This commit does not run by itself, needs a regeneration to be buildable and runable.


Fix keyboard shortcut bugs on mobile

Problem
We are creating a new library that adds keyboard shortcuts functionality to mobile and since our current keyboard shortcut logic wasn't built for that, we uncovered 13 bugs when implementing the new feature. We should fix all of them
Why is this important
There are bugs that lead to broken functionality
Solution
Each of them will likely have it's own solution. We need to investigate and fix them!

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@azimgd would you mind commenting on this issue so I can assign it to you?

📣 @azimgd! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Any update here?

We reverted the PR that introduced this functionality due to App Store Connect issues. So we'll have to wait until the ew PR gets merged to work on these bugs.

No updates yet. We reverted the initial PR and we are still waiting for the next one to be merged!

PR is in prod. We can start working on this. You expressed some concerns about the complexity/payout of Issues 1&2 below, but would you like to get started on issues 3-5? If so, I can create them to track it separately from the current issue.
Issue 1 - OptionsSelector

iOS: SearchPage: Not able to scroll up in the list on the OptionList page(Search Page, newChat page, new Group Page)
iOS: New Group Page Behaviour is buggy. When we Press enter on any item, sometimes it selects two items
iOS: New Group Page: Try to unselect the last checked/selected item via Enter Key, deselects it, and reselect it
Android: SearchPage: Pressing the arrow down jumps two items at once in the list. (Hard to reproduce). There is no exact reproduction. Every time it occurs differently
Bug: Android: Long pressing arrow keys does not continuously navigate the list

Issue 2 - Form submission

iOS | Android: DisplayNamePage: Clicking enter on the keyboard does not submit the form and close the page. (Applies to all pages which support pressing Enter to submit)
Android mWeb Chrome | Android: Pressing Enter does not submit the message.

Issue 3 - Attachment modal

iOS: Add attachment modal does not navigate based on arrow keys
iOS | Android: Left & Right arrow keys does not work (seems to be duplicate of the issue above)

Issue 4 - Closing modals

Android: Pressing ESC on SeachPage does not close it
Android mWeb Chrome: iOS safari: Using the Escape key to close the attachment menu freezes the app

Issue 5 - Shortcut modal

Android: The keyboard shortcut modal closes immediately after opening it.
iOS Safari: iOS: [Inconsistency issue] Shortcuts to open the keyboard shortcut modal also closes it.

@luacmartins I can start working on issues 3-5 tomorrow, as the 7 day prod regression period for the #6883 finishes on May 3rd. Could you please create a separate issue and assign me there?

Great! I created the issues. Please comment on each so I can assign them to you:

https://github.com/Expensify/App/issues/18268
https://github.com/Expensify/App/issues/18269
https://github.com/Expensify/App/issues/18270

we're working on the separate issues linked above

working on separate issues linked above

Workin on separate issues

I'm actually gonna close this one in favor of the individual issues.


a merge bug fix.

The same name of the header can not add more than two.
http://php.net/manual/zh/function.array-merge.php array_merge function  Returns the value before the override.
http://php.net/manual/zh/function.array-merge-recursive.php merge and append values.

👍
I like this. Here is a 3v4l showing what you describe: https://3v4l.org/N9gG6
According to the PSR7 spec:

Existing values for the specified header will be maintained. The new value(s) will be appended to the existing list. If the header did not exist previously, it will be added.

Using array_merge we will not maintain existing values.
@freedompy Can you provide a unit test for this fix?

This is good website.
Code: https://3v4l.org/9eHnp
Just looked at the manual again, I found myself ignoring this sentence:
If, however, the arrays contain numeric keys, the later value will not overwrite the original value, but will be appended.


Add ability to disallow archives for PageLink field

I noticed that by default the "allow_archives" setting of the ACF Page Link field type is set to true. Because of this, the WordPlate Page Link field's "allowArchives" method is essentially redundant, and doesn't allow us to modify the default ACF behavior. It seems like ACF's behavior is inconsistent with their typical conventions in this case.
Proposed Changes

Add the ability to pass a boolean to "allowArchives" to allow the setting to be overridden, while maintaining backwards compatibility with previous versions.
We could alternatively add a "disallowArchives" method but it seemed to defy conventions.

Thanks for the pull request Matt! I've added a couple of comments we need to sort out before we can merge this.

Wow sorry about that. It turns out I was originally trying to type hint boolean rather than bool, which sent me down that overly complicated path.

No worries. This has been released in version 8.1.1. Thanks!


img alt output isn't enabled

@capjamesg's #5 tried to enable mf2py's new img alt output flag, but it's evidently not working. eg the h-entry u-photo in https://snarfed.org/2022-12-06_48532 has an alt, but https://python.microformats.io/?url=https://snarfed.org/2022-12-06_48532 isn't showing it.

fixed by @sknebel in #10, thanks!


Can't compile on rustc 1.74.1

Hi,
The latest version uses std::ptr::from_mut (it looks like to fix a clippy warning), but that was only just stabilized in 1.76.0.
Nushell is building on 1.74 at the moment, and can't build anymore with the latest version. This is a breaking change to minimum Rust version.
See: https://github.com/nushell/nushell/pull/12182#issuecomment-1992734092
Would you please replace with something that works on 1.74, or bump major and clarify minimum rust version in Cargo.toml?
Thanks.

I'll fix this today.
I've never specified (or worries about much) minimum rust version...but
doing to is good I think...
I'll probably need to test it in the matrix too.
1.74 stable,.right?
On Wed, Mar 13, 2024, 12:40 AM Devyn Cairns @.***>
wrote:

Hi,
The latest version uses std::ptr::from_mut (it looks like to fix a clippy
warning), but that was only just stabilized in 1.76.0.
Nushell https://github.com/nushell/nushell is building on 1.74 at the
moment, and can't build anymore with the latest version. This is a breaking
change to minimum Rust version.
See: nushell/nushell#12182 (comment)
https://github.com/nushell/nushell/pull/12182#issuecomment-1992734092
Would you please replace with something that works on 1.74, or bump major
and clarify minimum rust version in Cargo.toml?
Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/andrewdavidmackenzie/libproc-rs/issues/127, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKF4LEWE726CUQ7WKXEM5DYX6G63AVCNFSM6AAAAABETEVKM6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DEOBVGQ2TCNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Yes. Thanks!

I'm not seeing the failure in CI on 1.74.1 or locally (on macos using act).
PR (so far just added that version of rust to the matrix) here
Any ideas?

These are the errors it's giving in nushell. I think ptr_from_ref may have been stabilized recently.
error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/proc_pid.rs:241:22
    |
241 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidinfo).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/pid_rusage.rs:389:22
    |
389 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidrusage).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

error[E0658]: use of unstable library feature 'ptr_from_ref'
   --> /Users/fdncred/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libproc-0.14.5/src/libproc/file_info.rs:168:22
    |
168 |     let buffer_ptr = std::ptr::from_mut::<T>(&mut pidinfo).cast::<c_void>();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #106116 <https://github.com/rust-lang/rust/issues/106116> for more information

Can you give some more details about where those errors are from, OS versions, rustc versions etc - as I'd like to reproduce the problem in CI before putting in place fixes for it, and controls to avoid a re-occurrance?
When I try with stable 1.74.1 on macos and linux, I do not see those failures.
thanks

Sure. They're from me building nushell with cargo install --path . --features=dataframe
❯ sw_vers
ProductName:            macOS
ProductVersion:         14.4
BuildVersion:           23E214

❯ rustc --version --verbose
rustc 1.74.1 (a28077b28 2023-12-04)
binary: rustc
commit-hash: a28077b28a02b92985b3a3faecf92813155f1ea1
commit-date: 2023-12-04
host: aarch64-apple-darwin
release: 1.74.1
LLVM version: 17.0.4

OK, reproduced locally - now I need to "fix" (i.e. break) CI....

At last!
https://github.com/andrewdavidmackenzie/libproc-rs/actions/runs/8267240156/job/22617146403?pr=128
There was a bug in my GH Action that hid this. I will now push a fix and release later tonight.

Fixed and a new minor version pushed to crates.io.
https://crates.io/crates/libproc/0.14.6
I'll do the github release later tonight.

Thanks so much for your help and responsiveness @andrewdavidmackenzie !!!

Seconded. Thank you!


N-API version 6 required

Fix #177

Fix #178

Well. I don't know what to say. While Build 322 failed for Node 10, Build 323 failed randomly für Node 12.
I scratch my head

Now its fine. We'll see how this will go once it's merged to master...


LiDAR horizontal Field of View parameter missing

Many Autonomous Vehicles along with Velodyne (360 FOV) uses multiple Ibeo lidars (145 FOV) link  usually mounted in the bottom of the vehicle.
Current lidar sensor implementation in Carla doesn't have the parameter to set horizontal FOV. I believe it would be very helpful for many if the support for Ibeo like lidars (with FOV less then 360 degrees) is added.

Hey man have you figured it out. I met the same problem and want solutions......


Custom fee option for Auto transfer

This screen comes when transfer policy is triggered and the user clicks on the CTA in the UAI. This screen itself needs to be implemented as per UX
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/ba99370f-771e-49e4-8675-5e30e573006b/

Changed the assignee to @Raheel1258  as he was looking into it

Fixed crash when navigating from UAI to this screen. For the remaining updated UI, creating a new issue in Sprint 33.

UI is done as per the design but it is decoupled by this commit as transder priority is hidden for autotransfer
https://github.com/bithyve/bitcoin-keeper/commit/7eecee71f1b258aef34f24fb36eb967fd3bf1043

This is linked to send max now. It should work now

Verified this issue on keeper app v 1.2.10(374)


fix: add IsNotFoundErr when get headlessSvc

get client error, there are two types of errors: "NotFound" error and others. If it is a "NotFound" error, it should be created. If it is not, the original error should be returned.

/ok-to-test

Code looks good to me but not sure if this is the logic we want.
@ahg-g @danielvegamyhre WDYT?

/lgtm
/approve


Use the type system to verify version again

Depends on: #63.
Reverts: 78ed4ac2a1641c208844600c0fbea4b23bbd0b06

PRing this, but it should be noted that I can't reproduce the as const requirement. It works fine on my machine :)

Yeah, I fully reverted, and my example works fine with the old one. I don't think you need to as const at all. TS seems to be able to infer it.
I'll go take a look at the code from Lume.

Hmmm. There's a CI failure, but I didn't touch the actual code, just the types. I'll look at it later.

Huh. I can reproduce locally, but the diff clearly shows that I didn't change anything.
Well, I got to fly, but I'll look into it later.

Figured it out 😀
My example was getting tested, and the types aren't quite right. You have to have another value, it seems.

Thanks a lot for looking into this !

Hey, so I just finished some more investigation and this turns out to be more of a docs issue :)
It did seem a little weird to use generics here.
Basically, typescript assigns types sequentially and assumes everything is mutable... so it doesn't know how it'll be used ahead of time. Therefore, it assigns the type string b/c it doesn't know the object is an xml_document until later, when it's used. All of my code called it directly, so TS had the context, but the Lume code assigns it to a variable, setting the type in stone. I'm looking into ways to make TS recognize it otherwise, b/c I think I've fixed this before somehow. Maybe just by inlining it? I figure that's the best option, but I'm looking at some casting options as well.

Ok, a few options:
a) Don't merge this, lose typesafety (I'm usually a purist, but this clearly trips some people up, so maybe?)
b) Recommend as consting the version or the whole object. TS surprisingly seems fine with as consting dynamic values. (You seem against this, reasonably)
c) Recommend the satisfies operator (i.e., {...} satisfies Partial<xml_document>). (Provides a better error than b.)
d) Recommend as const satisfies Partial<xml_document> (My favorite option, almost certainly too verbose)
e) Recommend casting to the value (Loses typesafety, verbose)
f) Recommend explicitly defining the type : Partial<xml_document> (verbose, not as useful as just using satisfies)
I'd probably just go with c.

One thought I just had—does libs follow SemVer? What's the public API? Presumably this is a major? It feels rather mundane, but I guess it is technically breaking. Yeah, I'm very much a purist. Oh well :)
Feel free to make this a patch or a minor. I don't really care, I don't use libs personally. Though do I plan on it soon-ish, probably. I like the APIs 😁

Ok, should be go to go!

a) Don't merge this, lose typesafety (I'm usually a purist, but this clearly trips some people up, so maybe?)
b) Recommend as consting the version or the whole object. TS surprisingly seems fine with as consting dynamic values. (You seem against this, reasonably)
c) Recommend the satisfies operator (i.e., {...} satisfies Partial<xml_document>). (Provides a better error than b.)
d) Recommend as const satisfies Partial<xml_document> (My favorite option, almost certainly too verbose)
e) Recommend casting to the value (Loses typesafety, verbose)
f) Recommend explicitly defining the type : Partial<xml_document> (verbose, not as useful as just using satisfies)
g) Recommend inlining the value into the function when possible.

I think it'd be best to go with a mixed solution of a/c:

Strict typing for parse() (i.e. keeping the revert you've applied so @version: 1.${number} and @standalone: "yes" | "no" which means that end-users will have narrowed values but can choose to use them like they want
Lax typing for stringify() using document: Partial<Omit<xml_document, "@version"|"@standalone"> & { "@version": string, "@standalone": string}>, and recommend satisfies for better typing from a user-side like you said

The reasoning behind is, in addition to avoiding releasing a new major, is that while I want to enforce strict typing in the internal code of @libs, I don't want to enforce a particuliar way of coding on end-users
I'm already quite annoyed by explicity typing slow-types since I always prefer to let TS infer stuff so I can be less verbose, so I can imagine end-users also being annoyed to find-out that stringify() wouldn't work out-of-the-box if you don't explicitly set typings, especially for a such a detail of standalone/version. I think this is a nice compromise between conveniency and strict typing

I think it'd be best to go with a mixed solution of a/c:

Strict typing for parse() (i.e. keeping the revert you've applied so @version: 1.${number} and @standalone: "yes" | "no" which means that end-users will have narrowed values but can choose to use them like they want
Lax typing for stringify() using document: Partial<Omit<xml_document, "@version"|"@standalone"> & { "@version": string, "@standalone": string}>, and recommend satisfies for better typing from a user-side like you said

The reasoning behind is, in addition to avoiding releasing a new major, is that while I want to enforce strict typing in the internal code of @libs, I don't want to enforce a particular way of coding on end-users

Ok, I'll do that. I just finish rebasing this a bunch, so I should be ready to edit it again. The stack should now be #66 (so that I don't ruin formatting), #63 (so that the prose wrapping is included), #62 (this one).

I'm already quite annoyed by explicitly typing slow-types since I always prefer to let TS infer stuff so I can be less verbose, so I can imagine end-users also being annoyed to find-out that stringify() wouldn't work out-of-the-box if you don't explicitly set typings, especially for a such a detail of standalone/version. I think this is a nice compromise between conveniency and strict typing

Yeah. I get slow-types (TS 5.5 is releasing with it built in soon), but it's weird. I don't plan on turning it on, none of my projects are slow enough for it to be beneficial.

Ping, @lowlighter :)

Hi ! Sorry for the delay
Is it possible to rebase this PR ? It still list 33 files changed

Hi ! Sorry for the delay Is it possible to rebase this PR ? It still list 33 files changed

Oh, oops. I can get to that in a minute.

Thanks a lot for your contribution @lishaduck 😄 !

Thanks a lot for your contribution @lishaduck 😄 !

 Have a nice day/night/whateve


[RPGF-99] Migrate Production API Round 6

Description
What
Since sign up and review period of retro funding round 6 already end, we're migrate data to static from Agora API
Why
The dataset more up to date and filter ineligible project out for faster SEO and UX of user when landing to page.
Type of change
Please check the relevent option with x.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if needed)
[x] My changes generate no new warnings
[x] I have tested on my Local Machine

@Billy19191 deployment failed.

Got it @wit03 , also skip some part about metric garden, let merge this to branch metric garden first then I will fix all stuff in that branch.

@coderabbitai review


updated .gitignore file to ignore *~ while doing git push

you have deleted everything and re added files again, this cannot be merged


[WIP] Adding pool controller

Some next steps..

refactor createNS into namespace.go
decide whether to wait for ready in createNS (move to goroutine) or watch owned clowdenvs (via owned ns?)
transfer ns ownerref to reservation

@psav Latest commit adds a new controller for clowdenvironments, and removes the goroutine/wait from the pool reconciliation loop. Clowdenv reconciler filters non pool events. When the clowdenv is ready it will create the frontendenv and update the ns annotation to trigger a pool reconciliation.
Next step is adding tests around the new controllers and deploying to dev

@psav Updated and rebased this refactor. A few items mentioned in review I'm going to move to Jira tickets and let @maknop work on them.


work on some new FAQs re: support emails

We need to develop some new FAQs related to standard answers for support email use.

This will happen in an upcoming update to our documentation.


Error compiling basicExample for STM32

Arduino: 1.8.9 (Windows 10), Board: "Generic STM32F103C series, STM32F103C8 (20k RAM. 64k Flash), STM32duino bootloader, 72Mhz (Normal), Smallest (default)"
F:\Libraries\Documents\Arduino\libraries\Arduino-ThermistorLibrary-master\thermistor.cpp: In member function 'float thermistor::analog2temp()':
F:\Libraries\Documents\Arduino\libraries\Arduino-ThermistorLibrary-master\thermistor.cpp:41:38: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
 for (i = 1; i < heater_ttbl_map[e]; i++) {

                                  ^

exit status 1
Error compiling for board Generic STM32F103C series.
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I am trying to compile the example for my STM32F103C but I get this error. I am simply using the example. works perfectly with Arduino Uno

Morning.
We regret the fact that you have not compiled the code, we have reviewed and the problem is due to an error in your compiler for the selected board (this error occurs because he does not interpret the source code correctly), we recommend using an arduino one / mega for processing and data acquisition and the Generic STM32F103C series, STM32F103C8 as a display card communicated through serial port.
Our target architecture is AVR and your processor is ARM, we have fixed this bug in the lib.prop file. We thank you for your Issue and apologize for the inconvenience caused.
Translated with www.DeepL.com/Translator


Buffer Overflow @User_dependence

Hi,
The size parameter sizeof in file md5/md5_kernel_1.cpp is  dependent on the user input temp in file md5/md5_kernel_1.cpp
Following lines seems to be the problem
md5\md5_kernel_1.cpp
void md5 (
...
int num = inputbuf.sgetn(reinterpret_cast<char*>(temp),64);
...
std::memset(x, 0, sizeof(x));
Can you help me solve this

This isn't a bug. And please stop posting these auto generated messages.


add runtests

cc: @nohwnd for review

You'll also want to update the Traversal SDK to recurse the Test target I think.
Does it just work for slns by executing the target ("Test") on every project in the sln?

~You'll also want to update the Traversal SDK to recurse the Test target I think.~
EDIT: Disregard. It's already here: https://github.com/microsoft/MSBuildSdks/blob/b54b4a19dd55281bd87e2f8dd482d444c44dc666/src/Traversal/Sdk/Traversal.targets#L181C19-L181C19. Probably for dotnet test support already.
Does it just work for slns by executing the target ("Test") on every project in the sln?

Yes

I have been doing quite a lot of changes to vstest targets and tasks, I would love this to take dependency on stable version of https://www.nuget.org/packages/Microsoft.TestPlatform.Build which ships them.

@microsoft-github-policy-service agree company="Microsoft"

Microsoft.TestPlatform**.Build** contains the msbuild task and target that we use to invoke vstest.console, depending I think that depending on it could avoid duplicating the task and target in this sdk, e.g. src/RunTests/RunVSTestTask.cs, we also have a new task and target that integrates better with msbuild and terminal logger that we are actively developing.


Stage current version to alphanet branch and freeze for testnet

We need a workplan to

Have some version we call "alphanet". This version will have its own docker / digital ocean and keep running forever for hackathon purpose.
Have another version where we can keep deploying and testing new features.

I think this is already done.


Rebuild embed.js to use React and handle embeddable Rays (e.g. using Beam Checkout)

Summary of changes:

Rebuild in React with Tailwind for CSS
Modal opens when an anchor or button has data-chec-embed-url="..." attribute
CSS is lazy loaded once JS is loaded
Frame closes when you press ESC (unless focus is within the iframe)

Todo:

Add linting
Put build/deployment into CI
Handle multiple instances on a page gracefully

Example embed code to test this with:

Buy now!

Approved verbally by @ScopeyNZ


Fix borderless fullscreen unexpectedly running in exclusive mode on windows

This employs the age-old hack that we've been relying on in stable/osuTK of misaligning the window with the screen. On a quick check, many other games use this same method, so it seems like the best we're going to do for the time being.
I've left the existing borderless operation mode for non-windows platforms, since it works better.
Closes https://github.com/ppy/osu-framework/issues/4068
Addresses part of https://github.com/ppy/osu-framework/issues/4074#issuecomment-739690107
Brings back issue mentioned in https://github.com/ppy/osu-framework/issues/3456 (i believe we may be able to solve this, but this is a separate task which requires further investigation into how other games/windowing systems get it working).

This seems to update WindowedSize to my screen resolution + 1x1 when switching between modes 99% of the time, making windowed like borderless and impossible to resize.

Yeah, I've seen this happen more than once, but I can also seem to repro that on master at random. Maybe easier with this change due to there no longer being a huge lag period when changing to borderless?
Was planning on addressing it as a separate issue, but maybe it's best to fix here..

This is giving me borderless unresizable windows once switching back to windowed:

Sure it's not something to do with maximised state or otherwise? can you set a breakpoint and see why the border restoration call isn't being hit?


Why does number of epochs exceed the max_epochs variable

Hello
For instance, in training I set max_epochs=5, then I will see:
Epoch 5.38/5, i = 20000/21000, loss = ...
How can the epoch be a float number, and also it can exceed the value of max_epochs?
Thanks

The epoch counter starts at 1.0, whereas the max_epochs value starts from 0.0. So for with -max_expochs=5, it will actually run until Epoch 6/5.


[BUG] Error when printing output from network device

Describe the bug
Thank you for developing Rich! Amazing! Currently using Netmiko for SSH connections to networking devices.  The device outputs something like below:
Copying configuration: [\]
Copying configuration: [|]
Copying configuration: [/]
Copying configuration: [-]
Copying configuration: [\]
Copying configuration: [|]
Copying configuration: [/]

To Reproduce
from rich import print

mystring = """
Copying configuration: [\]
Copying configuration: [|]
Copying configuration: [/]
Copying configuration: [-]
Copying configuration: [\]
Copying configuration: [|]
Copying configuration: [/]
"""

print(mystring)

Traceback
Traceback (most recent call last):
  File "/home/juliopdx/git/multi-vendor-python/test.py", line 13, in <module>
    print(mystring)
  File "/home/juliopdx/git/myvenv/lib/python3.8/site-packages/rich/__init__.py", line 60, in print
    return write_console.print(*objects, sep=sep, end=end)
  File "/home/juliopdx/git/myvenv/lib/python3.8/site-packages/rich/console.py", line 1466, in print
    renderables = self._collect_renderables(
  File "/home/juliopdx/git/myvenv/lib/python3.8/site-packages/rich/console.py", line 1333, in _collect_renderables
    self.render_str(
  File "/home/juliopdx/git/myvenv/lib/python3.8/site-packages/rich/console.py", line 1224, in render_str
    rich_text = render_markup(text, style=style, emoji=emoji_enabled)
  File "/home/juliopdx/git/myvenv/lib/python3.8/site-packages/rich/markup.py", line 145, in render
    raise MarkupError(
rich.errors.MarkupError: closing tag '[/]' at position 80 has nothing to close

Platform
Ubuntu 18.04
Diagnose
rich==10.0.1
Thank you again!

Glad you like Rich!
See the docs on console markup, which you may escape or disable.

Thank you Will!


[README] Correct some broken grammar & spelling.

@Arcterus : thanks for reviewing the changes! I'll try to revise my commit tomorrow since it's getting late here.

@Arcterus : I revised the changeset based on your commentary and rebased. Sorry it took me so long - I woke up late and it slipped off my mind.
BTW, your family name reminds me of this jamendo band: https://www.jamendo.com/artist/440873/lyonn . I like their "We'll light the sky" and "Shining Eyes" songs (YKMV).

No worries, a day isn’t very long, and I was preoccupied anyway.
I’ll give them a listen. :)

Thanks, @Arcterus !


Add LogicalPlan::ViewTable support in datafusion-proto

Which issue does this PR close?

Closes #3874
Rationale for this change

See #3874
What changes are included in this PR?

Add ViewTableScanNode in datafusion.proto file
Modify logical_plan file for support scan view table
Add roundtrip_logical_plan_with_view_scan test

Are there any user-facing changes?

None

Thanks @r4ntix


What to do next?

My question
I have extracted it's .zip on my PC. I have node.js 15.0.1 installed in my system.What to do next,type the given code in node?If yes,what is the application of This there/?

@SparkScrach-P hi. There's nothing to do with a .zip. You seem unfamiliar to npm, please search a bit on how to use it on your OS of choice. Then see https://github.com/jiahaog/nativefier#installation and https://github.com/jiahaog/nativefier#usage .

thanks


Dataset is not provided that used in this project.

please provide the data set link too.

Can anybody kindly share the data-set used  in this project

Please Provide the dataset.

any progress ?

No... No reply
On Fri, 7 May, 2021, 6:48 am Shahab Ud Din Gohar, @.***>
wrote:

any progress ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ramonidea/DietImprovement/issues/2#issuecomment-833988482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQT3KDQFNS6Z3IPUTL4CANTTMM5VLANCNFSM4LT4RAKA
.


CMake build files aren't engineered to allow building CppUTest as a sub-project of a cross-platform application

The CMake files in this repository aren't immediately ready for cross-platform builds. The top level CMakeLists.txt discovers platform-specific build options based on the build host; but these may not apply to the target platform. A project needing to embed CppUTest for a different target (other than the host platform) cannot therefore simply do a add_subdirectory(<path/to/cpputest>). Since the meat of the build is defined within src/CppUTest/CMakeLists.txt, a reasonable alternative is for the enclosing project to do add_subdirectory(<path/to/cpputest/src/CppUTest>).
I propose the following version for src/CppUTest/CMakeLists.txt to ease embedding CppUTest into an external project:
add_library(CppUTest
        CommandLineArguments.cpp
        MemoryLeakWarningPlugin.cpp
        TestHarness_c.cpp
        TestRegistry.cpp
        CommandLineTestRunner.cpp
        SimpleString.cpp
        TestMemoryAllocator.cpp
        TestResult.cpp
        JUnitTestOutput.cpp
        TeamCityTestOutput.cpp
        TestFailure.cpp
        TestOutput.cpp
        MemoryLeakDetector.cpp
        TestFilter.cpp
        TestPlugin.cpp
        TestTestingFixture.cpp
        SimpleMutex.cpp
        Utest.cpp
)

if (CPP_PLATFORM)
    target_sources(CppUTest
        PRIVATE
            ../Platforms/${CPP_PLATFORM}/UtestPlatform.cpp
    )
endif(CPP_PLATFORM)

target_include_directories(CppUTest
    PUBLIC
        ../../include
)

if (WIN32)
    target_link_libraries(CppUTest winmm.lib)
endif (WIN32)
install(FILES ${CppUTest_headers} DESTINATION include/CppUTest)
install(TARGETS CppUTest
    EXPORT CppUTestTargets
    RUNTIME DESTINATION bin
    LIBRARY DESTINATION lib
    ARCHIVE DESTINATION lib)

I've made the following changes:

add a section to declare the include folder as a PUBLIC property. This means that any project depending on this CMakeLists.txt would automatically inherit the include folder.

target_include_directories(CppUTest
    PUBLIC
        ../../include
)

use a relative path for referring to include. This removes the need for an external definition of the variable CppUTestRootDirectory.

remove STATIC from add_library(CppUTest STATIC ${CppUTest_src} ${CppUTest_headers}). There is no need to be specific about building a STATIC library. The enclosing project could choose alternatives to static linking.

remove the unconditional addition of ../Platforms/${CPP_PLATFORM}/UtestPlatform.cpp to the sources that get compiled into the CppUTest library. It may be that the enclosing project wants to provide its own Platform.cpp without re-using one of the standard Platforms or dropping in a new one under ../Platforms/ . Platform.cpp could be project-specific, and therefore a user should have the flexibility to add it to the build externally.

add_library(CppUTest ...) should not need to mention the headers as dependencies.

Finally, I request that there should be a README containing an example CMakeLists.txt showing how CppUTest could be embedded into a project.
The CMake files in this project could also benefit from modern cmake idioms. Refer to https://github.com/onqtam/awesome-cmake#resources and https://www.youtube.com/watch?v=bsXLMQ6WgIk

You should definitely open a PR for this!


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4608

Questions ?
Please refer to the Backport tool documentation