Vietnamese Translation Progress

For New Translators
To translate a page:

Check that no one else has claimed your page in the checklist and comments below.
Comment below with the name of the page you would like to translate. Take only one page at a time.
Clone this repo, translate your page, and submit a pull request!

Before contributing, read the glossary and style guide to understand how to translate various technical and React-specific terms.
You can use the Crowdin as a base for your translation. Make sure to compare the content with the current React website to makes sure everything is up to date! (NOTE: delete this if the language doesn't have any Crowdin contributions)
Please be prompt with your translations! If you find that you can't commit anymore, let the maintainers know so they can assign the page to someone else.
For maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:

[x] Home Page (@tesseralis) #1

When PRs are merged, make sure to mark that page as completed!
Core Pages
To do before releasing as an "official" translation. Please translate these pages first.

[x] Home Page (@nampdn) #3
[x] Tutorial

Basics

[x] Hello World (@ltmylinh ) #9
[x] Introducing JSX (@phonglk) #7
[x] Rendering Elements (@ltmylinh) #12
[x] Components and Props (@tuyengabi)
[x] State and Lifecycle (@vkhanh74 #69)
[x] Handling Events (@ntban15) #17
[x] Conditional Rendering (@pnminh1710) #21
[x] Lists and Keys (@NhanHoang8195) #19
[x] Forms (@pnminh1710)
[x] Lifting State Up (@cuongtran8) #28
[x] Composition vs Inheritance (@cuongtran8) #32
[x] Thinking in React (@cuongtran8) #25

API Reference

[x] React (@Quynh-Nguyen) #20
[ ] React.Component (@pthanh1703)
[ ] ReactDOM (@Quynh-Nguyen)
[ ] ReactDOMServer (@mduclehcm)
[x] DOM Elements (@hweeTan) #39
[x] SyntheticEvent (@hweeTan) #39
[x] Test Recipes (@luubinhan) #78
[x] Shallow Renderer (@hweeTan) #53
[x] Test Renderer (@hweeTan) #53
[x] JS Environment Requirements (@Ryan-LT)
[ ] Glossary (@DungGramer) #226

Navigation
These are the navigation links that appear in the sidebar. Possibly wait until
the corresponding sections are translated to do these.

[x] tutorial/nav.yml
[x] docs/nav.yml (@fozg) #199
[x] docs/footerNav.yml @fozg) #199
[x] docs/headerNav.yml @fozg) #199

Next Steps
These are the next most important translations, ordered by importance:
Installation

[x] Getting Started (@quyctd) #113
[x] Add React to a Website
[x] Create a New React App (@nguyenary) #162
[x] CDN Links (@hiimnhan ) #157
[x] Release Channels (@vovantamvn) #232

Hooks
Everyone is hooked on hooks! People are really excited about these and it would be great for them to be translated.

[x] Introducing Hooks (@hieuhani) #22
[x] Hooks at a Glance (@hieuhani) #23
[x] Using the State Hook(@phonglk)
[x] Using the Effect Hook (@luubinhan) #44
[x] Rules of Hooks (@luubinhan) #44
[x] Building Your Own Hooks (@lPaths) #195
[x] Hooks API Reference (@fozg) #210
[x] Hooks FAQ

Testing

[x] Testing Overview (@lequangnamsoraly2009) #159
[x] Testing Recipes
[x] Testing Environments (@danglequocbao001) #182

Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.

[x] dont-call-proptypes (@kctrnn) #174
[x] invalid-aria-prop (@dinhtrung1308) #200
[x] invalid-hook-call-warning (@dinhtrung1308) #200
[x] legacy-factories (@dinhtrung1308) #183
[x] refs-must-have-owner (@lequangnamsoraly2009) #208
[x] special-props (@dinhtrung1308) #190
[x] unknown-prop (@lequangnamsoraly2009) #198

Advanced Guides

[x] Accessibility (@ThinhNu) #29
[x] Code-Splitting (@ThinhNu) #24
[x] Context (@hweeTan)
[ ] Error Boundaries (@hweeTan)
[x] Forwarding Refs (@huykon) #191
[x] Fragments
[x] Higher-Order Components (@hiimnhan) #215
[x] Integrating with Other Libraries (@ncnthien) #222
[x] JSX In Depth (@pthanh1703) #203
[x] Optimizing Performance (@hoangvanhoa1701) #212
[x] Portals (@huykon) #176
[x]  Profiler API (@fozg) #199
[x] React Without ES6 (@hoangvanhoa1701) #180
[x] React Without JSX (@hoangvanhoa1701) #184
[x] Reconciliation (@hoangvanhoa1701) #193
[x] Refs and the DOM (@nguyentran-se) #206
[x] Render Props (@hphuocthanh) #205
[x] Static Type Checking (@qhuu2742) #207
[x] Strict Mode (@nhannv) #224
[x] Typechecking With PropTypes (@hoangvanhoa1701) #219
[x] Uncontrolled Components (@ThaoLe366) #167
[x] Web Components (@nguyentran-se) #186

FAQ

[x] APIs and AJAX
[x] Babel, JSX, and Build Steps
[x] Passing Functions to Components
[x] Component State (@nguyenary) #168
[x] Styling and CSS
[x] File Structure (@tedle1997) #172
[x] Versioning Policy (@nguyenary) #204
[x] Virtual DOM and Internals (@qhuu2742) #181

Contributing
Priority: Low

[ ] How to Contribute (@kvphan5)
[x] Codebase Overview (@beebapcay) #239
[ ] Implementation Notes
[x] Design Principles (@beebapcay) #234

Components
Components in src/components that have some text in them.

[x] CodeEditor
[x] CodeExample
[x] ErrorDecoder
[x] LayoutFooter
[x] LayoutHeader
[x] MarkdownPage

Additional Translations
These are not the primary translation targets.

[ ] Blog
[ ] Community

Seems like the link to the glossary is dead. I believe it's supposed to be https://github.com/reactjs/vi.reactjs.org/issues/2

I'll do the tutorial page.

@anhphamduy D'oh, this issue is autogenerated and I forgot to actually make a glossary issue. Feel free to create one!

Hello @anhphamduy, when will you plan to start the Tutorial translation?

@nampdn By next week probably. Is it urgent?

I will translate * Hello World * this weekend.

I will translate * Hello World * this weekend.

I will do Introducing JSX

Nam (@nampdn) ơi em update bạn @phonglk và @anhphamduy vào danh sách đóng góp translate tiếng việt nhé. Cám ơn em.

I will continue to do Components and Props by this weekend

@nampdn By next week probably. Is it urgent?

@anhphamduy It's the most high priority because we will need to complete home and tutorial first in order to make the first PR to official repo. Could you do it by the end of this week?

@nampdn Hmm, I wouldn't say you needed to do those two first. The entire "Core Pages" section, including "Basics" and "API Pages" should be done first, but in any order you feel okay with.

Should we have a discussion channel that we can discuss things more actively, may be Slack ?

@phonglk I totally agree with you. It would be great if we have a Slack channel to discuss something about translation.

Nam @nampdn  ơi, em có xài Slack không?

@phonglk @nampdn there's a global React Translation slack that you can join here: rt-slack-invite.herokuapp.com
A couple of the other translation groups started their own channels there!

Just joined there. also created the channel and invited you guys.
I am a bit busy now so my progress will be slow. Thank you for your understanding.

Hi. I'll do Handling Events this weekend.

Hi all.
I'll help API Reference - React page at nights and weekend.

Hi all.
I will do Conditional Rendering page.

Hi all,
I will do Lists and Keys page.

I'm going to do React.Component.

Hi all,
I'm going to do Forms page

Hi all,
I'm going to do ** ReactDOM** page.

Hi all, I will do Accessibility.

Hi, I finished "Thinking in react", can maintainer please have a look on that? Thanks

I will translate 'Lifting State Up' page next

Thanks, @cuongtran8. I just finished the review in Your PR. Thank you so much for a good translation.

I'm going to do FAQ

I'm going to do FAQ

Thanks @tuantvk

I will translate "Composition vs Inheritance" next. One small question does it make sense to create a PR with [WIP] in the title, so everyone knows that part is in progress/done rather than keeping communication on this page?

Hi @cuongtran8 : Yes, you can create a PR with [WIP] in the title, then you don't need to comment on this issue. Or you can pick up the available part, then edit this issue and add your name beside it.

Hi @cuongtran8 : Yes, you can create a PR with [WIP] in the title, then you don't need to comment on this issue. Or you can pick up the available part, then edit this issue and add your name beside it.

Unfortunately, I am not able to edit that. I guess that there is only a permission issue.

Hi @cuongtran8 I will add you as a maintainer for Vietnamese translation.

Hi @tesseralis: Currently, @nampdn is busy with his project, so may I add @cuongtran8 and @ThinhNu as maintainers for the Vietnamese team?

@ltmylinh sure! I'll add them.

Thank you @tesseralis

Hi @locronaldo, if you want to contribute for Vietnamese translation team, please comment here. Thanks.

Hi @ltmylinh
I will translate "ReactDOMServer" this week!

Thanks @mduclehcm (y)

Hi , i am Tuyen (junior developer in France) i would like to join of translating with you . I am translating the page Components ans Props . Bạn @phonglk có đánh dấu sẽ dịch trang này từ tháng Hai, mình xin phép dịch hoàn thành trang này. Thank you

Hi, I'm Huy and I want to help translating ReactJS. May I do the DOM Elements and SyntheticEvent pages, permalink docs/dom-elements.html and docs/events.html respectively? Thanks

Hi, I'm Huy and I want to help translating ReactJS. May I do the DOM Elements and SyntheticEvent pages, permalink docs/dom-elements.html and docs/events.html respectively? Thanks

Thanks a lot @hweeTan

Hi , i am Tuyen (junior developer in France) i would like to join of translating with you . I am translating the page Components ans Props . Bạn @phonglk có đánh dấu sẽ dịch trang này từ tháng Hai, mình xin phép dịch hoàn thành trang này. Thank you

Cảm ơn bạn @tuyengabi

Hi all, I will translate Test Utilities page

Thank you @pnminh1710 (y)

Hi , i am Tuyen (junior developer in France) i would like to join of translating with you . I am translating the page Components ans Props . Bạn @phonglk có đánh dấu sẽ dịch trang này từ tháng Hai, mình xin phép dịch hoàn thành trang này. Thank you

Cám ơn bạn, mình bận quá ko giúp được. Xin gỡ tên mình ra khỏi mục đó nhé ^^

I will take the 'Using the State Hook' Just got inspired by a talk in jsconf.asia ^^

I will take "Hooks FAQ"

Hi all, may I take the Shallow Renderer and Test Renderer pages?

Hi all, may I take the Shallow Renderer and Test Renderer pages?

Sure, you can take any page you want. Thanks.

Hi all, may i take the page JS Environment Requirements page ?

Hi team, may I take Context and Error Boundaries pages?

Hi all, can I take Building Your Own Hooks page?

Hi all, is this repo still active? I would like to help translate ReactJS. If this repo still active then may I take Building Your Own Hooks page and others in the future?

Yes, of course. Thanks a lot.

Hi team, may I take Context and Error Boundaries pages?

@hweeTan , Yes, please :D

Hi all, is this repo still active? I would like to help translate ReactJS. If this repo still active then may I take Building Your Own Hooks page and others in the future?
Yes, sure. We still have a lot of parts need to be translated. Feel free to pick any page without a blue check for translation. Thank you so much.

I will translate Fragment

Hi everyone, now I want to contribute translations to the community. Where can I contact other authors or contributors. Slack for example? Are people using slack?

Hi everyone, now I want to contribute translations to the community. Where can I contact other authors or contributors. Slack for example? Are you using slack?

Hi @dunggnguyen , we do have slack but we haven't communicated much there. You can pick the page to translate by making a comment here or editing the description of this issue above.

Hi everyone, can I translate the Getting Started page?

Hi everyone, can I translate the Getting Started page?

Thanks @quyctd , feel free to do it. Happy Lunar New Year!

Wow, ⌛ hope to see it complete in future 😄

Hi, I saw that File Structure Page is not translated (faq-structure.html). Can I translate that page?

Hi, I saw that File Structure Page is not translated (faq-structure.html). Can I translate that page?

Hi @tedle1997, Surely! We are edger for your help here!

Hi guys, can I translate Create a New React App  in Installation? It seems like nobody has translated it so far.

Hi everyone, topic Component State (docs/faq-state) still hasn't been translated. May I contribute translation for this?

@Ryan-LT Could someone edit the original issue description to reflect the taken status when new volunteer takes a page? It is quite hard for new guy to keep track of which page is being translated in the comment section.
Thanks!

Hi everyone, topic Component State (docs/faq-state) still hasn't been translated. May I contribute translation for this?

Yes, thanks. Go for it :)

I'm translating docs/addons-two-way-binding-helpers.md, docs/addons and docs/cdn-links.md because when I see it, nobody has translated it yet.

Hi, I noticed that the testing overview section of the testing section has not been translated yet. Can I go for it?

Hi, I noticed that the testing overview section of the testing section has not been translated yet. Can I go for it?

Yes thanks. Please do so.

@Ryan-LT I'm done, pls come to review and give me feedback, thank you!
https://github.com/reactjs/vi.reactjs.org/pull/170

@Ryan-LT I'm done at #162 and #168, please come to review and give me feedback.
This is my first pull request for open source contributions. I am so happy to get more suggestions.
Thank you!

@Ryan-LT I'm done at #162 and #168, please come to review and give me feedback.
This is my first pull request for open source contributions. I am so happy to get more suggestions.
Thank you!

Sure! It would take some time, The number of PR is increasing, but I will try to merge yours within today.

@Ryan-LT I'm done at #162 and #168, please come to review and give me feedback.
This is my first pull request for open source contributions. I am so happy to get more suggestions.
Thank you!

Sure! It would take some time, The number of PR is increasing, but I will try to merge yours within today.

Thank you so much!

I will translate Create a New React App.

I will translate Create a New React App.

This page is being translated by another member, could you please pick another one?

I will translate Create a New React App.

This page is being translated by another member, could you please pick another one?

Can I translate "Add React to a Website"?

I will translate Create a New React App.

This page is being translated by another member, could you please pick another one?

Can I translate "Add React to a Website"?

Sorry, We have missed updating the page's status, Could you please visit here to check for a page that has not been translated yet?

I will translate Create a New React App.

This page is being translated by another member, could you please pick another one?

Can I translate "Add React to a Website"?

It could be aweseom if you can translate this page. :D

I will translate Create a New React App.

This page is being translated by another member, could you please pick another one?

Can I translate "Add React to a Website"?

It could be aweseom if you can translate this page. :D

That's OK. I will translate this page.

I am now on Higher-order Components. Let me know if there is any conflict.
On Wed, Sep 15, 2021 at 10:29 AM Võ Văn Tâm @.***>
wrote:

I will translate Create a New React App.
This page https://github.com/reactjs/vi.reactjs.org/pull/162 is being
translated by another member, could you please pick another one?
Can I translate "Add React to a Website"?
It could be aweseom if you can translate this page
https://vi.reactjs.org/docs/release-channels.html. :D
That's OK. I will translate this page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/vi.reactjs.org/issues/1#issuecomment-919669924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINYQ2OM4PVAJ5Q2253PG2TUCAHIPANCNFSM4GVLJS2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Best Regards =========================== NGUYEN CHI VINH NHAN Mobile: +84
34560111 Email: @.***

Sure! Please go ahead, I marked your name there

I'm going to translate cross-origin-errors.md page.

Hi guys, can I translate Create a New React App in Installation? It seems like nobody has translated it so far.

Sure! Please go ahead

Hi, I see that this section was translated by someone else. Do I need to translate it anymore? If so, may I do Render Props in Advanced Guide instead?

Sure! That could be awesome! I will mark your name to Render Props section

Hi, can i translate "JSX In Depth" part?

@Ryan-LT I am working on Forwarding Refs page

Hi, I'll be doing the navigation bar today. For those that the titles have been translated to Vietnamese I will make them identical to the translator's wordings. For those that have not been translated I will do them with my own wording then you guys can change them later.

Hi, can i translate "JSX In Depth" part?

Sure! Please, that'd be great!

Hi, I'm going translate testing-environments.md because nobody has translated it yet, help me a confirm please.

Hi, I'm going translate testing-environments.md because nobody has translated it yet, help me a confirm please.

Yes, there is none translation for it yet. I will mark your name to the topic

Hi @Ryan-LT,
Can I translate the "Typechecking With PropTypes / Optimizing Performance" part?
Can you mark my name on those the topic? I will translate those pages. Thanks!

@hoangvanhoa1701 Sure! Why not? 👏

I will translate FAQ Versioning Policy page! 🍕🍕

where can I see the list of remaining work or selected work?
On Wed, Sep 15, 2021 at 6:53 PM Nguyen Truong Nguyen <
@.***> wrote:

I will translate FAQ Versioning Policy page! 🍕🍕
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/vi.reactjs.org/issues/1#issuecomment-919950733,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINYQ2NKEAFLQ5LBC2N4X5DUCCCKFANCNFSM4GVLJS2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Best Regards =========================== NGUYEN CHI VINH NHAN Mobile: +84
34560111 Email: @.***

@hiimnhan Right above you, there is a checklist

I can help translating the page "Static Type Checking", if nobody is working on it then please mark it with my name. Thanks!

Hi, Can I translate "Refs and the DOM" in Advanced Guides part?

Hi @Ryan-LT, can I do the Strict Mode translation?

Hi, I'm going to translate addons-test-utils.md because nobody has translated it yet, please help me a confirm, thank you.

Hi, I'm going to translate the page hooks-reference.md.

Hi, I'm going to translate the page hooks-reference.md. #210

Great! I marked your name there

Hi, Can I translate "Refs and the DOM" in Advanced Guides part?

Please, Go ahead @tranminhwang, I will mark your name there

I can help translating the page "Static Type Checking", if nobody is working on it then please mark it with my name. Thanks!

Sure! Done

Since I almost finish this so can you stop to work on anything else?
On Thu, 16 Sep 2021 at 12:16 Ryan Le @.***> wrote:

I can help translating the page "Static Type Checking", if nobody is
working on it then please mark it with my name. Thanks!
Sure! Done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/vi.reactjs.org/issues/1#issuecomment-920584043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINYQ2PAP4ZDXTCL4RVBPX3UCF4S7ANCNFSM4GVLJS2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Best Regards =========================== NGUYEN CHI VINH NHAN Mobile: +84
34560111 Email: @.***

I am on it but forgot to let you know 🙏🙏
On Thu, 16 Sep 2021 at 12:17 VNhan @.***> wrote:

Since I almost finish this so can you stop to work on anything else?
On Thu, 16 Sep 2021 at 12:16 Ryan Le @.***> wrote:

I can help translating the page "Static Type Checking", if nobody is
working on it then please mark it with my name. Thanks!
Sure! Done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/vi.reactjs.org/issues/1#issuecomment-920584043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AINYQ2PAP4ZDXTCL4RVBPX3UCF4S7ANCNFSM4GVLJS2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Best Regards =========================== NGUYEN CHI VINH NHAN Mobile: +84
34560111 Email: @.***

--
Best Regards =========================== NGUYEN CHI VINH NHAN Mobile: +84
34560111 Email: @.***

I finished the task "static type checking", pls check it <3

Hi guys! It's unbelievably great to see so many of you have joined to translate this site
Currently, there seems to be only me reviewing all the PRs, so It would be expected to take a bit more time to finish.
Please be patient, I will try to review all of that, keep up the good works!
Cheers!
Ryan

I finished the task "static type checking", pls check it <3

Ok great. So now I stop on that

@hiimnhan Please, shorten your message. 🙏

Hi, Can I translate "Refs and the DOM" in Advanced Guides part?

Please, Go ahead @tranminhwang, I will mark your name there

Oops! I have just finished and created PR this topic last night :'(

Oops! I have just finished and created PR this topic last night :'(

Sorry, You will need to inform me here, I will then mark your name on the checklist first. Sorry for wasting your time 😢

Hey, Since @tranminhwang hasn't stared his translation yet. I will review yours @nguyentran-se .

@tranminhwang Sorry, you will need to pick another page then. Thanks a lot for your contribution

I’ll translate “Glossary” part if there’s no conflict

I finished "addons-shallow-compare". Can you check it?

@Ryan-LT help me check it https://github.com/reactjs/vi.reactjs.org/pull/211, thank you!

@Ryan-LT help me check it #211, thank you!

Sure! Within today

Hi Ryan-LT, I know your work from ReactJS - VietNam, how can I register to contribute my work . I can see there are some left tasks on : "APIs and AJAX
Babel, JSX, and Build Steps
Passing Functions to Components"

I'll translate the How to Contribute page under FAQ section

I can translate How to Contribute under Contributing if that's ok

Hi, since the high-priority sections are mostly translated, can we move on to the low-priority part? If that's a go I will do the Design Principle part.

Hi Ryan-LT...

Hi @hoangnv170752, You could follow the steps that I've comment in the post. Please DM me if you face any difficulties.
Welcome to the team!

Hi @kvphan5 and @vuon0029,
Since @kvphan5 is the first to register for this, Could you please pick another one? @vuon0029?

Hi @kvphan5 and @vuon0029,
Since @kvphan5 is the first to register for this, Could you please pick another one? @vuon0029?

Hey Ryan, can you mark my name next to the How to Contribute. I will be spending time on it 👍

Hey @kvphan5 on it

Ryan, I saw @vuon0029 next to How to Contribute instead of mine. Should I proceed still or move on to Codebase Overview? Since I have been working on the translation.

@kvphan5 it was a mistatke. Updated it. Many thanks

Hi Forks!
There are a few stale translations that need your help still, they're abandoned for a while now and it could be amazing if you can help us on that too.
To name a few:

React.Component (@NhanHoang8195)
ReactDOM (@Quynh-Nguyen)
ReactDOMServer (@mduclehcm)
Release Channels (@vovantamvn)
Error Boundaries (@hweeTan)
How to Contribute (@kvphan5)
Codebase Overview
Implementation Notes
Design Principles

Again, Your help means a lot! 🙏

Hi Ryan, I’m working on it. Just juggling between work/school/contributions right now 😁. I will definitely get my section done by 11:59PM Saturday PST timezone, then move on to other sections if there’s any to be filled.

@kvphan5 sure, please take your time. no rush at all 😄

@Ryan-LT Can you check #232 for me? Thank you.

@Ryan-LT i'll translate "React.Component" part. Please mark my name on the list

@Ryan-LT i'll translate "React.Component" part. Please mark my name on the list

Done! Thanks 🙇

I will translate "Design Principal" part.

Hi team, Can I help to translate the FAQ:  Passing Functions to Components part or any part that is still available?

I will translate "Codebase Overview" page

I will translate "Implementation Notes" page

Hi @mqnguyen5. I have already started translating that part

@Ryan-LT are there any parts that need translation at the moment?

Hi! I found some typos on translated pages. What should I do?

Thanks to everyone who contributed to the old website translation!
Started a new issue for the new website: https://github.com/reactjs/vi.react.dev/issues/345


Unconstrained problems are not still considered

Currently the project does not support problems with side constraints.

This feature is now included


[MWPW-134688] Create Page LCP Fix + Promotion Block After loadBlocks

Description:
added fragment to LCP blocks for pages with show-relevant-rows metadata
added .then before addPromotion to always load after loadBlocks
Resolves: MWPW-134688
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/create/flyer/party?lighthouse=on
After: https://mwpw-134688--express--adobecom.hlx.page/express/create/flyer/party?lighthouse=on

Codecov Report

Merging #159 (b732691) into stage (376aa73) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #159      +/-   ##
==========================================
- Coverage   35.59%   35.37%   -0.23%
==========================================
  Files          27       27
  Lines        9488     9488
==========================================
- Hits         3377     3356      -21
- Misses       6111     6132      +21

Files Changed
Coverage Δ

express/scripts/scripts.js
42.57% <100.00%> (-0.89%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


I'm getting did you register the component correctly?  error while trying to use vue-rangedate-picker component

Hi everyone,
I followed the instruction on the https://bliblidotcom.github.io/vue-rangedate-picker/
but. code gives me the following error;

Vue warn]: Unknown custom element:  - did you register the component correctly? For recursive components, make sure to provide the "name" option.

My vue code is the following;
<template>
    <vue-rangedate-picker ></vue-rangedate-picker>
</template>

<script>
    import Vue from 'vue';
    import VueRangedatePicker from 'vue-rangedate-picker';

    Vue.use(VueRangedatePicker);
</script>

What am I missing?

@zeuyanik I also had the same problem.
You will not be able to register the plugin globally since it is not exporting a vue package.
I had to import locally into each component in order to work.
`

`

Try to register it manually like this
import Vue from 'vue';
import DateRangePicker from 'vue-rangedate-picker';

Vue.component('vuejs-daterangepicker', DateRangePicker);

new Vue({
  ...
});

You can change 'vuejs-daterangepicker' with whatever name you want.
Notice that Vue.component method should be called before new Vue.

@bondansebastian thanks. works great. Seems like something that should be documented? @bliblidotcom?

@bondansebastian -- The critical information for me was the simple but cogent advice:

Notice that Vue.component method should be called before new Vue.
That was the reason for my getting the error message.  Thanks.

This worked in my case.

Create a config folder right where main.js is.

In that folder create setup-component.js file.

`
import WHAT from '../where/notsurewhere';
function setupComponents(Vue) {
Vue.component('what', WHAT);
}
export { setupComponents };
// Note: Same as file
`


Add: Retry logic for waiting webdriver initialization.

context: windows CI was failing due to connection failure to local webdriver. Because all of the tests were passing on the local windows machine, I decided to implement #9 to see if it's related to uninitialized webdriver.


Fix poor web style on partners page

This PR Fixes #48225

/area web-development

This does seem to fix it
/retitle Fix poor web style on partners page

/lgtm

/assign natalisucks

This also resolve Case Studies poor web style on footer as well.

/retitle Fix poor web style in some page footers


Manual saving of a frame collage as png

User story

As a user
I want to save Video 1, Video 2 and Difference in one colllage
So that I can get a analyze the difference between the three frames

Acceptance criteria

add menu list to video player screen
there should be button with the text "export frame collage"

when clicking the button a frame collage of the current selected frames should be created
there should be option to choose the location where the file is stored in the file explorer
the frame collage should look like this:

one the left side video 1, in the middle difference video and on the right side video 2

Definition of done (DoD)

Create feature branch
Implement the functionality
Opened pull request and assigned reviewer
If necessary: required changes are implemented
Delete feature branch
If necessary: Component Test has been written
Code review has been completed and code has been merged

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

https://developer.android.com/jetpack/compose/components/app-bars


🍒 Cherry pick PR #19759 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/19759 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.19-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.19-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Vulnerability suppression through API and UI

It would be beneficial to be able to suppress vulnerabilities or matchings through the UI and through the API.
There are at least two reasons to suppress:

files are mismatched - typically a client library for a database will sometimes be matched with vulnerabilities which only affect the server - in this case one might one to suppress on a global scale (all projects)
vulnerable functionality is not used - a vulnerability exists in a (transitive) library, but the vulnerable functionality is not in use (or other mitigations are in place)

In both cases a mandatory suppression reason/justification should be provided

More information about how the matching is performed would also be useful. Which parts of the component information was used to match which parts of the NVD information etc.

Duplicate of #65 - This is scheduled for inclusion in 3.1.
I plan on documenting how the matching works.

Ok, we can close this, but please include both types of suppression in #65, because they are very different in nature (wrong matching vs. mute for specific project)


CI: Touch up CircleCI configuration

Slightly rework the circleci config to:

Use YAML anchors to avoid obvious duplication
Use large machines (4 vCPUs, 15GB RAM) (we could also consider using xlarge - 8/32GB)
Leverage docker_layer_caching (decent speedup!)

Closes #2759

upgrading to large machines has significantly decreased the dsXXX runtimes, so we can punt that refactor for a later time.


adding allow list for new core template

This makes the C# queuetrigger template show the right fields during create-time.

@soninaren & @alrod Please give this a look

Looks good to me


Rename mapK to flatMapF

This is both clearer and more consistent with e.g. Kleisli's flatMapF in Cats.

Current coverage is 92.98%

Merging #60 into master will decrease coverage by -1.04% as of f30990f

@@            master     #60   diff @@
======================================
  Files           17      17
  Stmts          452     456     +4
  Branches        37      37
  Methods          0       0
======================================
- Hit            425     424     -1
  Partial          0       0
- Missed          27      32     +5

Review entire Coverage Diff as of f30990f

Powered by Codecov. Updated on successful CI builds.


Feature to disable named routing in flutter web

please provide an option to disable named routing in flutter web. (eg.  domain.com/#/{namedroute} )
some PWA's require to hide URL routes

would be nice to have an option to set a blank routeName


AeroDyn 15 mesh refinement

Feature overview
For coupling AeroDyn to CFD codes, it would be really useful to have a method built directly into AeroDyn 15 to refine the aero mesh.  In issue #1232, there was a mismatch in position between the aero position mesh and the force mesh passed to CFD codes such as NALU-Wind, AMR-Wind, and SOWFA.  This issue had come about as a result of including the structural mesh in the mesh interpolation within the OpenFOAM module (OpFM).  While the structural mesh was removed with PR #1324, the interpolation of the aero mesh to a finer mesh that the CFD requires is still handled within the OpFM module.  This refinement might be giving rise to discontinuities in the aero loads passed back to the CFD as shown in the following figure.
Figure:  Comparison of CFD couplings with blade resolved (BR) CFD. Note the discontinuities in the normal force in the BEM, Vortex-Method, and ALM curves .  These discontinuities are likely due to a combination of changes between airfoils in AD15 and mesh mapping from the course aero mesh to the finer CFD mesh near the airfoil change.

In addition to possible discontinuities from the mesh mapping, it would be very convenient to include a simple mesh refinement in AD15 directly.  This would greatly simplify using OpenFAST with a CFD code.
Describe the solution you'd like
We would like to include a mesh refinement parameter in the AD15 input file.  This would trigger AD15 to interpolate additional nodes along the blade span, and would require some interpolation of airfoils.
From @mchurchf (comment https://github.com/OpenFAST/openfast/issues/1232#issuecomment-1317119119 from #1232)

Tony and I just had a conversation about interpolation of Cl/Cd polars between airfoils. There is a method implemented in this old NREL tool AirfoilPrep that does a Cl/Cd polar interpolation that makes most sense that you may want to consider. I use it when I prepare actuator line or Aerodyn input files to have more resolution than whatever I am given to start with. I will try to find a reference, but the main idea is that it transforms the alpha in these tables to what I'd call alpha'. In this transformed space, peak Cl occurs at the same alpha' no matter the airfoil (so, for each airfoil, you need to know alpha for Cl,max), then it does linear interpolation based on thickness of airfoil. Once the interpolation is complete, the inverse alpha transform is applied and all is done. The effect is that as you blend between two airfoils with different max Cl alphas, the peak in Cl will smoothly move left or right. If you don't do this, you get double Cl peaks for blended polars, which is completely undesirable. I'm happy to explain this process in more detail. It is a feature we've really wanted for a long time directly in OpenFAST, instead a preprocessing step.

To summarize, AD15 would get the following changes:

new input file refinement parameter (maybe in blade file, but likely in main input file)
algorithm for refinement of mesh
algorithm for interpolation of airfoils to refined locations

nearest neighbor with above Cl/Cd polar interpolation

In addition, the following changes would be made to the OpFM module:

Removal of the intermediate ActForceMotionsPoints and ActForceMotionsPoints meshes and all interpolation to generate them
direct passing of AD15%u%BldMotion mesh positions to CFD (this is now a refined mesh)
direct passing of AD15%y%BldLoads mesh positions and values to CFD (this is now also a refined mesh)
renaming of the OpenFOAM module (#1323)

And some API changes for communication with CFD codes:

NumActForcePtsBlade passed from CFD would be removed
NumActForcePtsTower passed from CFD would be removed
NumPtsBlade new parameter to pass to CFD
NumPtsTower new parameter to pass to CFD
there may be some additional changes in the OpenFOAM_Types.h file

Describe alternatives you've considered
The current best practices method of refining the AD15 mesh is to preprocess the AD15 blade file and polars to create a more refined blade file with modified polars.  This method still leaves some room for error as the CFD mesh is linearly spaced along the blade span or tower, but the AD15 meshes are not uniformly spaced.  As show in the figure above, this may be leading to artifacts.
Those who may want to weigh in on this proposal
@tonyinme
@mchurchf
@michaelasprague
@gantech
@jjonkman
@ebranlard

This feature would indeed be great.
As a note, on top of the careful interpolation of polars (to avoid double stall), we should implement 3D polar corrections into AeroDyn, because 3D polar corrections typically depend on the radial location (c/r).
The Snel and Du-Selig implementation can be found here together with a fairly standard blending procedure (to blend the corrected polar to the uncorrected polar). This will require:

new AeroDyn input file parameters to choose which 3D correction to apply to the polar.
Possible knowledge of the tip-speed ratio (either from ElastoDyn initial rotor speed), or a user input.
Robust routines to calculate $C_{l,\alpha}$ and $\alpha0$. I believe we already have some in AFI, but we should test the robustness of the methods.
Possibly some new AeroDyn inputs for the blending of the 3D correction.

It's likely fine to first implement the interpolation of polars, and then implement the 3D correction. The error introduced by omitting the 3D correction are likely small. Interpolating

I agree that this feature would be great to have.  In addition to the comments above, I would add:

This feature would be useful not just for OpenFAST/AeroDyn coupled to actuator-line CFD, but also for standalone OpenFAST/AeroDyn.  Just like CFD users, often users of standalone OpenFAST/AeroDyn what to specify airfoil polars only at stations were the airfoil geometry is exact and use a finer resolution of nodes with interpolated airfoil data in between.
Applying 3D corrections is just as much an art as it is a science.  3D-correction models like Snel and Du-Selig are great, but often require good engineering judgement to be applied correctly.  As such, when this feature is added to AeroDyn, it will be important to output and plot the the airfoil data at the interpolated cross sections so that users can verify that the airfoil data they are using make good physical sense.  So, I would be sure to include this functionality when adding this feature to AeroDyn.

Best regards,

This issue is related to https://github.com/OpenFAST/openfast/issues/374.

Dear all,
Subroutine “ReadBladeMeshFileAD” in ElastoDyn.f90 reads in the AeroDyn v14.00.00 input file to get the blade discretization used in the structural dynamics module. When employing AD15, how the program get the blade discretization？I do not find the codes that get the blade discretization from AD15 input file.

Dear @ietqlw,
When AeroDyn v15 is enabled, the aerodynamic blade discretization used by AeroDyn is defined in the AeroDyn blade input file and the structural blade discretization used by ElastoDyn is defined by ElastoDyn input BldNodes.  (That is, the aerodynamic and structural discretizations are independent.)  Basically, when AeroDyn v15 is enabled, the ElastoDyn blade is discretized into BldNodes equal-length elements with the blade structural analysis nodes located at the centers of these elements.
Best regards,

Dear @jjonkman,
Thank you for your kind answer.
I set _AFTabMod_as 3 in AD15 primary input file for enabling 2D interpolation on AoA and UserProp. The following AD15 blade definition input file was selected from the reference NREL-5MW wind turbine.  Eight airfoil-data tables (BlAFID=1~8) were originally used.  Now I choose a element to apply UserProp and set BlAFID as 9.
The following doubt confuses me a lot:
(1) The table defines 19 blade span properties. what about the properties between two blade nodes? If BlSpn = 9m, which number is the corresponding BlAFID, 2 or 3?
(2) I used to guess that the blade airfoil kept the same within each "DRNodes" as indicated in the following figure. But I am not sure whether the gusess is correct.
(3) I change BlAFID to 9 for enabling UserProp at BlSpn = 47.15 m. With this setting, I am confused about the span location range which enables UserProp. From 43.05 m to 47.15 m ? Or the "DRNodes" containg BlSpn = 47.15 m?
(4) As you mentioned above, the aerodynamic and structural discretizations are independent. If I want to employ a trailing edge flap at span location 70~90%, I first change the corresponding aerodynamic discretizations to contain 70~90% span location in AD15 blade files. But the structural discretizations is defined by ElastoDyn input BldNodes. I am not sure whether the span location where ElastoDyn uses the aerodynamic forces with trail edge flaps is 70~90%.
------- AERODYN v15.00.* BLADE DEFINITION INPUT FILE -------------------------------------
NREL 5.0 MW offshore baseline aerodynamic blade input properties; note that we need to add the aerodynamic center to this file
======  Blade Properties =================================================================
19   NumBlNds           - Number of blade nodes used in the analysis (-)
BlSpn        BlCrvAC        BlSwpAC        BlCrvAng       BlTwist        BlChord          BlAFID    BlCb    BlCenBn    BlCenBt
(m)           (m)            (m)            (deg)         (deg)           (m)              (-)     (-)     (m)        (m)
0.0000000E+00  0.0000000E+00  0.0000000E+00 0.0000000E+00  1.3308000E+01  3.5420000E+00        1      0.0     0.0        0.0
1.3667000E+00 -8.1531745E-04 -3.4468858E-03 0.0000000E+00  1.3308000E+01  3.5420000E+00        1      0.0     0.0        0.0
4.1000000E+00 -2.4839790E-02 -1.0501421E-01 0.0000000E+00  1.3308000E+01  3.8540000E+00        1      0.0     0.0        0.0
6.8333000E+00 -5.9469375E-02 -2.5141635E-01 0.0000000E+00  1.3308000E+01  4.1670000E+00        2      0.0     0.0        0.0
1.0250000E+01 -1.0909141E-01 -4.6120149E-01 0.0000000E+00  1.3308000E+01  4.5570000E+00        3      0.0     0.0        0.0
1.4350000E+01 -1.1573354E-01 -5.6986665E-01 0.0000000E+00  1.1480000E+01  4.6520000E+00        4      0.0     0.0        0.0
1.8450000E+01 -9.8316709E-02 -5.4850833E-01 0.0000000E+00  1.0162000E+01  4.4580000E+00        4      0.0     0.0        0.0
2.2550000E+01 -8.3186967E-02 -5.2457001E-01 0.0000000E+00  9.0110000E+00  4.2490000E+00        5      0.0     0.0        0.0
2.6650000E+01 -6.7933232E-02 -4.9624675E-01 0.0000000E+00  7.7950000E+00  4.0070000E+00        6      0.0     0.0        0.0
3.0750000E+01 -5.3393159E-02 -4.6544755E-01 0.0000000E+00  6.5440000E+00  3.7480000E+00        6      0.0     0.0        0.0
3.4850000E+01 -4.0899260E-02 -4.3583519E-01 0.0000000E+00  5.3610000E+00  3.5020000E+00        7      0.0     0.0        0.0
3.8950000E+01 -2.9722933E-02 -4.0591323E-01 0.0000000E+00  4.1880000E+00  3.2560000E+00        7      0.0     0.0        0.0
4.3050000E+01 -2.0511081E-02 -3.7569051E-01 0.0000000E+00  3.1250000E+00  3.0100000E+00        8      0.0     0.0        0.0
4.7150000E+01 -1.3980013E-02 -3.4521705E-01 0.0000000E+00  2.3190000E+00  2.7640000E+00        9      0.0     0.0        0.0
5.1250000E+01 -8.3819737E-03 -3.1463837E-01 0.0000000E+00  1.5260000E+00  2.5180000E+00        8      0.0     0.0        0.0
5.4666700E+01 -4.3546914E-03 -2.8909220E-01 0.0000000E+00  8.6300000E-01  2.3130000E+00        8      0.0     0.0        0.0
5.7400000E+01 -1.6838383E-03 -2.6074456E-01 0.0000000E+00  3.7000000E-01  2.0860000E+00        8      0.0     0.0        0.0
6.0133300E+01 -3.2815226E-04 -1.7737470E-01 0.0000000E+00  1.0600000E-01  1.4190000E+00        8      0.0     0.0        0.0
6.1499900E+01 -3.2815226E-04 -1.7737470E-01 0.0000000E+00  1.0600000E-01  1.4190000E+00        8      0.0     0.0        0.0

Dear @ietqlw,
I agree with your approaches.
In AeroDyn v15 you can have nodes close together as you indicated.  My only concern would be if the nodes are so close together that they would be within the internal tolerances used by the spatial mesh mapping.
Best regards,

Dear @jjonkman,
Thank you for your patient answer.
As you mentioned above, error was reported because the nodes were too close. I changed 47.1499 m to 47.1490 m and 57.4001 m to 57.4010 m. The error was then addressed.
Sincerely


Add "power" state

Hello, thanks for the great plugin!
Are you planning on adding "power" states? Like sleeping and on?
That would be amazing and the plugin could be used to trigger scenes when the Apple TV is turned on or off.

Hi @sftsk ,
thank you for your festure request. However, it is already possible to trigger an automation based on the power state. In order to achieve that you just need to select "when a device is controlled" or something similar, I dunno since I do not have English as my system language.

Hello @maxileith,
Thanks for the swift answer.
Your are right but unfortunately Apple has decided not to expose the device status for Apple TVs.
There have been multiple threads over the years (https://www.reddit.com/r/HomeKit/comments/pmx7po/use_appletv_on_as_trigger_for_automation/) and as far as I can tell no good solutions that still work.

Maybe I am overlooking something but from what I can tell from the thread, people are complaining that there is no option to trigger power state related automations based on the vanilla integration of Apple TV in HomeKit.
But exactly that can be achieved by setting the trigger like the following

If I am still missing something you need to describe your desired automation trigger more clearly.

@sftsk can you confirm that this is what you are looking for?

Hello @maxileith ,
sorry it took me little while to give it another try and debug some related issues. Indeed as you were saying it is possible to use the "enhanced" device as a trigger. I did not notice it at first because the devices had disappeared from the Home app.
It might have been connected with #2. I have now given static IPs to my Apple TVs but the plugin still seems to forget the settings (I don't want any of the additional states and only the main power state). As soon as I reboot Homebridge, all the settings for the plugin are back to default.
I don't know if it's connected but the state of the Apple TV does not always update when it should, therefore the automation is not 100% reliable.
Sorry for mixing up issues within this issue.

Hi @sftsk ,
the IP does not need to be static. #2 is fixed in the latest version.
What do you mean by resets to default? Are only the defaults music, video, playing, paused and stopped there or every possible motion sensor?


Dev

Sign in/Login Functionality added.
Onclick Events fixed.

Ok looks good : )

I will merge it now


SyncSetInputStreamHandler with cc->SetOffset(TimestampDiff(0)); can not work together

SyncSetInputStreamHandler sync set has seprate timestamp.
may be one is more less than anther.
if more large stream first arrived, and with SetOffset(TimestampDiff(0)), the calculator tiemstamp update the more large number, and the less timestamp arrived may corrupt.
how do I solution this?
sync set A: 9->10->11->12->13
sync set B: 1->2->3->4->5
calculator: SetOffset(TimestampDiff(0))
arrive order: 9->1->2->10
when 9 arrived, the next timestamp is 10, the 10 is update to the all outputstream, but the 1 is more less than 10, it may corrupt

I Think achieve an InputStreamHandler like DefaultInputStreamHandler would be better,
first, define a main inputstream, and the inputstream also be processed when it arrived.
and side inputstream,
if side inputstream packet's timestamp is less than the current main packet timestamp, it will be processed with the main current packet.
if side inputstream packet's timestamp is larger than the current main packet tiemstamp, and it will be wait for the main bound is large than the side inputstream, and will be processed with the main packet in future.

Hi Jiqimaogou,
Yes, it's true that SetOffset(0) normally requires DefaultInputStreamHandler.
SyncSetInputStreamHandler and ImmediateInputStreamHandler normally violate SetOffset(0).
You suggest an InputStreamHandler that processes each "main-packet" as soon as it arrives, and couples it with a recent "auxiliary-packet".  Behavior similar to this can be arranged using the "PacketClonerCalculator".  The main-packet is used as the "tick input" to the "PacketClonerCalculator", while the auxiliary-packet is used as a "base input" to the "PacketClonerCalculator".  The "PacketClonerCalculator" can be configured with "ImmediateInputStreamHandler", so that it produces output immediately for each "tick input".  With this configuration, each main-packet is coupled with the most recent available "auxiliary-packet".
Let me know if PacketClonerCalculator can address your use case.

Hi Jiqimaogou,
Yes, it's true that SetOffset(0) normally requires DefaultInputStreamHandler.
SyncSetInputStreamHandler and ImmediateInputStreamHandler normally violate SetOffset(0).
You suggest an InputStreamHandler that processes each "main-packet" as soon as it arrives, and couples it with a recent "auxiliary-packet". Behavior similar to this can be arranged using the "PacketClonerCalculator". The main-packet is used as the "tick input" to the "PacketClonerCalculator", while the auxiliary-packet is used as a "base input" to the "PacketClonerCalculator". The "PacketClonerCalculator" can be configured with "ImmediateInputStreamHandler", so that it produces output immediately for each "tick input". With this configuration, each main-packet is coupled with the most recent available "auxiliary-packet".
Let me know if PacketClonerCalculator can address your use case.

thank you, let me try, i have waiting for some days for your answer...

if I use PacketClonerCalculator everytime the option come everytime, I must store the lastImagePath to decide  wether to decode the image.
if I use SyncSetInputStreamHandler, I just decide weahter packet is empty, if not empty decode it.
and PacketClonerCalculator is more complicated if have a PacketClonerInputStreamHandler.
I think multi stream control should be in InputStreamHandler which is more flexible than in calculator.


Update $refs type declaration

According to the doc, $refs is a dictionary of Vue instance or Element. This pull request reflect this by a union type. So users can declare html elements in $refs.
A test is also added. User defined components may have better knowledge about $refs' data structure. So users can also reify special properties to more specific types.
@ktsn your review is appreciated, thanks.

CI breaks... Any idea on it?

It seems like dist files need to be rebuilt.

Yeah, it happens recently... Don't mind about that.


Accept an empty /add command

[x] If /add is empty, show a message explaining how to use /add, be it with or without arguments
[x] Accept the same arguments as /add title,start,repetition

Current coverage is 87.21% (diff: 100%)

No coverage report found for develop at 7a47b9c.

Powered by Codecov. Last update 7a47b9c...2052372


mac m1 inference

i can not run python setup.py build_ext --inplace in my mac m1.
there is  error :
error: could not create 'monotonic_align/core.cpython-39-darwin.so': No such file or directory

mkdir monotonic_align/monotonic_align

then run
python setup.py build_ext --inplace

I even can't install requirements in my Mac m2:

Collecting numpy==1.18.5 (from -r requirements.txt (line 4))
Using cached numpy-1.18.5.zip (5.4 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... error
error: subprocess-exited-with-error

× Preparing metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [54 lines of output]
  Error compiling Cython file:
  ------------------------------------------------------------
  ...
              self.rng_state.ctr.v[i] = counter[i]

          self._reset_state_variables()

          self._bitgen.state = <void *>&self.rng_state
          self._bitgen.next_uint64 = &philox_uint64
                                     ^
  ------------------------------------------------------------


DBZ-2021 Updates to event flattening SMT per Chris's review

After merging, please backport this to 1.1.

Applied to master and 1.1.


Better commits paging

Load only commits of the current page directly in RepositoryBrowser.
I test it on a 11000 commits repository and it take less than 800ms for any page.
(Debug mode + standard HDD)

Very useful change, awesome! :)

Any idea when the next build is scheduled?  Would like to get this fix in a build if possible.  Thanks!

You can download the recent build from here - but take a backup of your existing data and version of bonobo, as there might be some undetected bugs etc :)

Thanks!
From: Lars<EMAIL_ADDRESS>Sent: Friday, January 29, 2016 5:05 PM
To: jakubgarfield/Bonobo-Git-Server<EMAIL_ADDRESS>Cc: Eric Sontag<EMAIL_ADDRESS>Subject: Re: [Bonobo-Git-Server] Better commits paging (#402)
You can download the recent build from herehttps://ci.appveyor.com/project/jakubgarfield/bonobo-git-server/build/artifacts - but take a backup of your existing data and version of bonobo, as there might be some undetected bugs etc :)
—
Reply to this email directly or view it on GitHubhttps://github.com/jakubgarfield/Bonobo-Git-Server/pull/402#issuecomment-176989945.


add energy unit

add energy unit

Thanks @capalmer85, this is similar to another PR  cms-cat/cmsstyle#39 which addresses the same problem. I would go for that one since it uses the same strategy as SetLumi, just for consistency reason. Thank you very much anyway for your contribution.

No problem. Just checking that I still remembered how to do it. :-)


Upgrade - Clojure 1.8 and Clojurescript 1.8.x

Does it works with latest versions,  Clojure 1.8 and Clojurescript 1.8.40 ?
If yes, its time to update the project.clj generated

Since this template is pinned to figwheel, I generally try to follow what bruce recommends, which looks like it's still clojure 1.7. Also, I think re-frame is still on 1.7.
That said, if @mike-thompson-day8, @danielcompton et al. have no objections, and I can bump.

TBH we haven't actually tested it on the latest versions of ClojureScript, so I wouldn't be comfortable just merging this. A template is a one-off generator anyway, so people will need to upgrade their Clojure and ClojureScript versions themselves after the first time. Once we upgrade to the newest CLJS version, we would look at updating the template.

Been running latest Clojure & Clojurescript & re-frame & reagent for a few weeks now. No problems.


Progress reporting when building

Builds happen really fast, but on bigger sites it would still be cool to have progress reporting built out.  Maybe wait till there is a site that this could benefit from.

Everything builds in less than 2s, so not really worth it.


fix: export MikroORMs provider

For complex scenarios involving multiple DB connections where context specific decisions are to be made having full access to the 'MikroORMs' token will enable full access to the entire array of MikroORM connections available in the application.

hello guys? can you merge this?


j2objc - building for iOS Simulator, but linking in object file built for iOS, for architecture arm64

Getting below error while running application for iOS deveices:
j2objc-dist/lib/libjre_emul.a(IOSClass.o), building for iOS Simulator, but linking in object file built for iOS, for architecture arm64

Is it really an error, as in, the build fails to complete? Messages like that are generally warnings.
Have you cloned j2objc's repository, then built it and used that new distribution building your app? The release bundles are intended to just a starting point for new j2objc users.

Since 2.8, we've fixed several issues with xcframework generation, due to Xcode 12.4/12.5 changes as well as support for Mac M1 systems. Please clone our repository, then build it -- if you want to continue working with a distribution bundle, you can run scripts/build_distribution.sh with your own version number. Please reopen this issue if you still have problems with a a bundle built from the latest source.
FYI, the Maven plugin was developed by external developers who have long since stopped working on it. It's great as long as it keeps working for you, but be aware it's passed its end-of-life. The Gradle plugin has also been dropped by its contributors, but was written more recently. We're working on j2objc support using Bazel (https://bazel.build/), which though less popular publicly is what Google uses internally.

@tomball  Still getting this error while running application for iOS, both for master and 2.8.
But seems that it only happened with some libraries -- for me this is javax.inject:

in j2objc/lib/libjavax_inject.a(Named.o), building for iOS Simulator, but linking in object file built for iOS, file 'j2objc/lib/libjavax_inject.a' for architecture arm64.

Is it possible that something is wrong with this library?
I have Mac M1, Xcode 12.5 and everything works fine with Rosetta x86_64 emulation

It's possible that you didn't run "make clean" in the master's top-level directory ("j2objc"), before building it. All libraries use the same build definitions in j2objc/make, so they should either all work or all fail.


Bug : In footer section the icon of "twitter" is assigned but it should be "X"

Add an Icon of "X"

Assign this issue to me


adding a straight through estimator for relaxed categorical

Here @fritzo  and me are adding a pyro distribution with a sketch for the straight through estimator for Gumbel softmax-type thingies and a test for it.
Current state of test: passes shapes, but we did not find it to converge to categorical as temperatures decrease.
Tasks:

[x] RelaxedCategorical ST estimator
[x] Test for RCST estimator
[ ] Do the same for Bernoulli
[ ] More tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

cc @karalets take a look should be ready to go

lgtm after my questions in person, please merge


Refactor ReadBufferFromFileProvider/WriteBufferFromFileProvider

What problem does this PR solve?
Issue Number: ref #6233
Problem Summary: ReadBufferFromFileProvider and WriteBufferFromFileProvider is not easy to use because they severely coupled with FileProvider.
What is changed and how it works?

Introduce ReadBufferFromRandomAccessFile and WriteBufferFromWritableFile with their logic mainly copied from ReadBufferFromFileProvider and WriteBufferFromFileProvider;
Make ReadBufferFromFileProvider and WriteBufferFromFileProvider a subclass of ReadBufferFromRandomAccessFile and WriteBufferFromWritableFile and their responsibility is just to create a RandomAccessFilePtr or a WritableFilePtr;
Implement sync explicitly in WriteBufferFromWritableFile and FramedChecksumWriteBuffer, previously we assume that WritableFile will return a valid fd, and do the sync in WriteBufferFromFileDescriptor. But after introduce S3WritableFile, this assumption is broken, and we should explicitly call fsync on WritableFile instead;

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/merge


Cannot download the mujoco Walker2D dataset

I tried to reproduce the mujoco walker2D experiment reported in the paper, however it seems the dataset url is invalid now. Here is the output of wget:
Connecting to pub.ista.ac.at (pub.ista.ac.at)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-04-27 16:29:36 ERROR 404: Not Found.

@wutianyuan1 Thanks for letter me know.
I have updated the URL to https://www.mit.edu/~mlechner/walker.zip


Feat/structural witin add

Work for #654

Please resolve the merge conflicts.

Hey @naure would kindly request you to have a quick review on this design, see whether any frontend/backend information leaked in between

Please see https://github.com/scroll-tech/ceno/pull/790 for some improvements inspired by reviewing this PR.


Dynamically set replicas for seed-admission-controller deployment.

How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
In our test setup we can only have a single node seed cluster. However, the seed-admission-controller is deployed with strong pod anti affinity into the seed's garden namespace with a static amount of 3 replicas. This causes the managed resource for this controller to go unhealthy (the desired replica count cannot be reached).
We deal with this problem by manually adding a HPA that reduces the replica count to 1 after every seed reconciliation. This PR aims for a cleaner solution by dynamically detecting the amount of nodes in the seed cluster, reducing the number of replicas for seed clusters with less than 3 nodes.
Which issue(s) this PR fixes:
~
Special notes for your reviewer:
This is the follow-up of https://github.com/gardener/gardener/pull/3808.
Release note:

Seed clusters with less than three nodes are now supported. In earlier versions of Gardener the seed-admission-controller deployment was causing unhealthy managed resources for small seed clusters, preventing seed bootstrapping from succeeding.

Thank you @Gerrit91 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Thanks @Gerrit91 :) For me it looks good, only #3811 (review) is open.

I think it is safe to switch from pdb.spec.minAvailable=1 to pdb.spec.maxUnavailable=1.

Thanks to both of you for your reviews. I am not so experienced with PDBs and therefore I am not really sure if this configuration is perfect. Switched to pdb.spec.maxUnavailable=1 as proposed by vpnachev.

Thanks a lot for merging! Very much appreciated. :)
With metal-stack we're a bit behind (currently on 1.14 release), so I hope we will soon come to the point where I can see this working in our real environments. :)


Request : Dehydrated support for using ECDSA in account creation

Hi,
Our system restricts usage of RSA when running in secured crypto mode (FIPS/ Common criteria).
In latest release, the dehydrated by default uses RSA for account creation, is it possible to provide ECDSA support for account creation.

https://community.letsencrypt.org/t/ecdsa-availability-in-production-environment/150679

Experimental support has been implemented. Would be great if some people could test it. For now ACCOUNT_KEY_ALGO has to be set in the config before registering an account. Documentation / Example configuration will follow when it's proven stable.


Derive Hash for Reference

This PR implements Hash for Reference. It makes possible to use references as key of HashMap etc.

Thanks.


Enables set_mavlink_callback to be passed None. Fixes #115

Blocked by #199.

can we add a unset_mavlink_callback or similar as well? just for consistency
(pseudo-code)
def unset_mavlink_callback(self):
  set_mavlink_callback(None)

aside from this lgtm :+1:


[#2921] fix(catalog-lakehouse-iceberg): Add width param to bucket and truncate functions in Gravitino SortOrder

What changes were proposed in this pull request?
Add width param to bucket and truncate functions in Gravitino SortOrder.
for example:
change bucket([id]) to bucket(10, id)
change truncate([name]) to truncate(2, name)
Why are the changes needed?
bucket and truncate functions are missing width param in Gravitino SortOrder.

Fix: https://github.com/datastrato/gravitino/issues/2921
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UTs and ITs.

Hi @FANNG1 could you help review this PR when you are free? Thanks

Hi @FANNG1 do you have time to review this PR? thanks

Hi @Clearvive could you help review this PR? Thank you

@caican00 , sorry for the delay,  this PR is related to API which we should check it carefully.

@caican00 , sorry for the delay, this PR is related to API which we should check it carefully.

It seems that i only added a new api name functionSortOrder

@caican00 , sorry for the delay, this PR is related to API which we should check it carefully.

It seem that i only added a new api declared as SortOrder functionSortOrder(       String name, int width, int id, SortDirection direction, NullOrder nullOrder).

gently ping @Clearvive, could you help review this PR when you are free? Thank you

gently ping @Clearvive, could you help review this PR when you are free? Thank you

@caican00 , Clearvive if not focused on Gravitino now

gently ping @Clearvive, could you help review this PR when you are free? Thank you

@caican00 , Clearvive if not focused on Gravitino now

got it, thank you @FANNG1
is there anyone else who can help review this PR?

gently ping @Clearvive, could you help review this PR when you are free? Thank you

@caican00 , Clearvive if not focused on Gravitino now

got it, thank you @FANNG1 is there anyone else who can help review this PR?

@yuqi1129 and  I could review this, but before viewing we'd better keep consistent about the necessary to do this in #2921

Hi @FANNG1  may i ask do you have time to help review this PR? Thank you.

Hi @FANNG1 could you help review this PR again? Thank you.

Hi @yuqi1129 could you help review this pr if you are free? Thank you.

@FANNG1 could you please help review this PR? Thank you!

@FANNG1 could you please help review this PR? Thank you!

ok

@mchades @FANNG1 all comments have been addressed, and could you please help review again? Thanks!

LGTM except the comment, @mchades do you have time to review again?

@FANNG1 all comments have been addressed, could you help review again? Thanks!


PKG_CONFIG_PATH not exported from windows to msys2

This is a new error that I'm getting in GitHub CI.  It started about 2 weeks ago.  Seems like cygpath might be provided by git for windows, which I have never explicitly installed...  Maybe GitHub changed something about their environment and cygpath is no longer in there?
/usr/bin/bash: line 1: cygpath: command not found
/usr/bin/bash: line 1: source: filename argument required
source: usage: source filename [arguments]
Error: Process completed with exit code 1.

@eine Okay, I found a solution to my problem.  I'll describe it here and the different things that I tried.  Hopefully it will save someone time in the future.  If you don't have time to read it, here's the trick: Use ~/.bash_profile instead of $GITHUB_ENV for everything.
Problem
Attempt 1: $GITHUB_ENV
We want to use a single GitHub CI for all builds, macos, Windows, and Ubuntu.  This makes our CI smaller and more manageable.  macos and unix are pretty easy because they are mostly compatible but Windows is a little trickier, especially about the environment variables!  The issue is that if you put something like this in your CI:
- name: Set env variable FOO to bar
  run: |
      echo "FOO=bar" >> $GITHUB_ENV

It will set the variable in the environments for macos and for ubuntu, but it won't work the same for Windows.  That's because it is setting the environment variable in the windows environment, which is, like the powershell.  But you want the environment variable set inside of msys2.
Attempt 2: path-type: inherit
The solution should be to use path-type: inherit.  You can read about how it works.  If you look at the code for it here and here, you'll see that inherit only affects PATH and not other things that you might set, like PKG_CONFIG_PATH.  That's a bummer because we'd like those to work, too.
Attempt 3: source a different file
One solution would be to instead write to a different file, maybe called ~/my_env and then source it at each command.  So you would need to modify every single command in your CI file to have a source line at the top.  Like this:
       - run: |
         source ~/.my_env
         do_the_rest.sh

That's annoying!  We don't want to have to do that.
Attempt 4: source it in the shell
GitHub will let you change the shell command for your platform.  So you might try something like this:
    defaults:
      run:
        shell: source ~/my_env; /bin/bash {0}

Now it should source your file before running the shell each time.  I tried that but it didn't work.  GitHub was complaining that source wasn't an executable file on the disk.  That's true, source is a command that bash know about, it's not a file that can be executed.
Attempt 5: Put it in .bashrc
We know that bash will always run .bashrc before it starts.  So we could just put the lines that we want in .bashrc.  However, one problem: .bashrc is only run for interactive shells.  This is described in the man page for bash:
       When an interactive shell that is not a login shell is started, bash reads and executes commands from /etc/bash.bashrc and ~/.bashrc, if these files exist.  This may be inhibited by  us‐
       ing the --norc option.  The --rcfile file option will force bash to read and execute commands from file instead of /etc/bash.bashrc and ~/.bashrc.

So we need to make bash interactive.  So we need to modify the shell to be interactive.
    defaults:
      run:
        shell: source ~/my_env; /bin/bash -i {0}

This causes other problems, though, because if the shell is interactive then some of the stuff that you do in your CI will behave differently and your tests will fail in a weird way.  So this is no good.
Attempt 6: Put it in .bash_login.
~/.bash_login is run only for login shells.  And we can fake that by running bash with a -l.  So that's a good technique for us!
Solution
So in the end, here's what the CI script could looks like:
jobs:
  my_job:
    name: ${{ matrix.os }}_job
    strategy:
      matrix:
        os: [ubuntu, macos, windows]
        include:
          - os: windows
            shell: msys2 {0}
          - os: ubuntu
            shell: '/usr/bin/bash -l -e -o pipefail {0}'
          - os: macos
            shell: '/bin/bash -l -e -o pipefail {0}'
    runs-on: ${{ matrix.os }}-latest
    defaults:
      run:
        shell: ${{ matrix.shell }}
    steps:
    - name: Setup paths and env
      run: |
        rm -f ~/.bash_profile
        echo "export FOO=bar" >> ~/.bash_profile

What this does is:

Create a matrix of jobs, where the variable os is one of ubuntu, windows, and macos.  So matrix, if we converted it to json, would be 3 jobs, each with a different value of os.  Here's what the job matrix looks like in yaml:

          - os: windows
          - os: ubuntu
          - os: macos

Now we have the include lines, which attach the shell variable to all elements of the matrix with os that matches.  This way, if you have an even more complex matrix with lots of rows you don't have to attach the shell to each one.  This is what we have now in yaml for our matrix.

          - os: windows
            shell: msys2 {0}
          - os: ubuntu
            shell: '/usr/bin/bash -l -e -o pipefail {0}'
          - os: macos
            shell: '/bin/bash -l -e -o pipefail {0}'

Then we set runs on an the default shell.  Those come from the matrix so we'll have a job running windows with the windows shell, a job running ubuntu with the ubuntu shell, etc.
Our first step is to delete the ~/.bash_profile.  It starts as all comments except for a line that causes it to exit when we are not interactive.  Any lines that we place after that won't be executed because we are not interactive, so we need to remove that.  Might as well just remove it all, there is nothing useful in there.  (If you want to check for yourself, put cat .bash_profile into a CI command and see it in the logs.)
Now we are ready to add environment variables.  We append them to the ~/.bash_profile.  I used export but I'm not totally sure if that is necessary.  No harm in it anyway.

That's it!  Now a single CI will work for windows and ubuntu and macos.  The pcb2gcode project is using this successfully with a fairly complicated build for all three platforms and they all use the same steps, more or less.


Support for Dispatcherless version

Hey guys, at first thanks for tackling the big amount of work of writing this from scratch in Rust, awesome!
I wonder if you have any plans on moving to the newest, dispatcherless version of the reference implementation, or if you are open for contributions in this direction?
Cheers,
Marten

Hey Marten and thanks for checking in.
Yes, we definitely want to support the new version, we have been tracking this in https://github.com/MystenLabs/scion-rs/issues/13.
Currently, @jpcsmith and I are focusing on a different project, so we are not planning to work on this in the next few months.
If you are interested in working on this, that would be amazing. In this case it would be great if you could describe the proposed changes in this PR, so that we can align on design, architecture, etc.


Fixing typo

[x] This is a small change
[ ] This change has been discussed in issue #<?> and the solution has been agreed upon with maintainers.

Description:

Thank you!


Estimator altitude error

I'm having an issue with the estimator altitude - it exhibits large deviation from baro altitude. This is flying on a somewhat unusual platform - a mid-power model rocket. It only shows up on some flights. This is a Pixracer, with EKF2_HGT_MODE set to zero (baro is primary altitude source).
The issue looks like this:
(I flipped and offset the estimator z position such that it matches up with the baro)

Here's another flight, without the issue:

Here's the log for the flight with the issue. Here's the log for the flight without the issue.
Looking at the estimator innovations, it appears that the estimator is having serious issues reconciling the sensors, to the point of rejecting baro measurements. For example, hgt_test_ratio approaches 15 on rocket ascent. I suspected it may be an excess vibe issue, but the vibe metrics are very low - I don't think rockets have the same high energy tonal harmonics that motors or props would. Is it possible this is due to something other than vibe? I'm also investigating incorrect baro delay and low design baro sampling rate (compared to inertial sensors).

@zfurman56 Hi Zach, very interesting log file, never seen one from a rocket before.
I just had a quick look at both of your logs and have the following comments:

I think you can see the problem in both logs, however, a height reset only occurred in one of them.
The vertical velocity innovations have the opposite sign to the vertical height innovations. It actually looks like the gps vertical velocity measurements don't get up to speed. Are you sure that the gps receiver you are using is suited for this kind of application?
In this case a replay logfile would be very nice since it would allow us to tune the estimator offline and you could do stuff like disabling gps velocity fusion...
You can find instructions of how to use the replay tool here
https://dev.px4.io/advanced-replay.html
I think @priseborough has a lot of experience with rockets, maybe he can also help.

We're currently using a Ublox M8N GPS, set to maximum dynamics (which is unfortunately "4g", but it's not a hard limit, and it's not clear what the exact effect is on GPS output). Do you have a recommendation of a better GPS with a larger dynamics range? In terms of replay logs, we're hoping to fly again next weekend, so we should be able to get a replay log then.

Unless the baro is sensing pressure via a properly placed static pressure port, it will be unusable at high speed due to positional errors.

The accelerometer is limited to 16g internally, and because of the effect of filtering, for short burn time model rocket motors this can be exceeded even if the output is not saturated. your g's are peaking at over 13 post filtering, so I would not be surprised if the IMU accel is saturating. Try a lower peak thrust, longer burn time motor with the same impulse.

Hello,
Can anybody tell me how to get delta velocities used as control inputs NOT observations here practically from pixhawk.
Thanks

@priseborough Thanks for the quick reply. The baro is placed in a chamber with four small holes as pressure ports (fairly standard for model rockets). The delay should be around 50 ms and the noise should be plus or minus a foot.
The engine we're currently using is the AeroTech F52. As you can see, the peak thrust is about 80 Newtons. Our rocket currently weighs 620 grams, so a quick calculation tells us that the peak acceleration should be about 130 m/s^2. This matches the acceleration observed in the data. I doubt accelerometer saturation is the problem - it has happened before in previous launches, until the accel range was set to 16g - and the symptoms look different. I suspect high acceleration over such short time intervals may be causing this problem, however. Here's a log from an earlier flight with a lower peak thrust engine, for comparison. We did in fact try to find engines with the same impulse but longer burn time, but for altitude reasons. Our search was eventually unsuccessful - we're limited to engines with an impulse no higher than 80 Ns (class F engines), and we're very close to that limit, making engines with the thrust and impulse we want hard to find.

Further Observations
Structural dynamics can produce high frequency vibration on motor ignition that can clip the IMU's internal 16g limit, so the IMU can still be saturating internally as you are operating close to sensor limits.
All position, height  and velocity innovations fail innovation checks immediately after motor ignition.
Spin rate on boost is high given the scale factor errors that the MEMS gyros have .
There is a negative g transient at motor burnout which causes a 15m step change in baro height
On the flight with the issue, chute opening does saturate the IMU.
Things to try

Stop sending GPS and baro data to the EKF during the boost phase
soften the shock cord
reduce launch spin rate
shock mount the IMU

@tumbili I'm trying to get a replay log tomorrow, but I'm not sure what exactly I'm supposed to change to get a replay log. You linked me to the documentation for replay here: https://dev.px4.io/advanced-replay.html. But the instructions there seem to indicate that the topics are logged at full rate by default, and that no changes need to be made to get a replay log. And replay appears to work with the logs we gathered from last week. What am I missing here?

@zfurman56 I was referring to the old depriciated replay method. You should be able to run a replay on your log file. Just follow the instructions.

This issue has gone stale and is a low priority use case.


Use Namespace and name on kafka consumer group

In the past we used to use namespace/name on the consumergroup:

https://github.com/knative/eventing/blob/release-0.5/contrib/kafka/pkg/dispatcher/dispatcher.go#L171

But https://github.com/knative/eventing/pull/1057 changed that to only use a UID on it.
Problem:
(re)creating subscriptions is ending up in different consumer groups.
The issue was raised by @yuzisun chatting, while looking at #758
Proposed Changes

use a more reliable consumer group setup

Release Note

Consumer groups will no longer have random UID (subscription UID) names, they will go back to the old behavior of using a stable combination of namespace and name

So that means that everytime a new subscription subscribe to the channel, it won't restart processing from beginning right?

So that means that everytime a new subscription subscribe to the channel, it won't restart processing from beginning right?

yes, for a given subscription the consumer group name should be stable. If a subscription is deleted and recreated it should not create a new consumer group(currently it is using the subscription UID) and consume again from beginning.

/lgtm

cool /lgtm

/hold
we should NOT use the channel name ... will fix this

/hold
we should NOT use the channel name ... will fix this

good catch ! should be the subscription name

With this, we now get exactly stable consumer groups, like:
kafka DOT namespace DOT channelName DOT subscriptionName

/lgtm

/hold cancel


#[reflect(Default)] for generic when T: Default only

What problem does this solve or what need does it fill?
bevy_inspector_egui in its inspector complains that it cannot instantiate a new value for my generic type because it's missing #[reflect(Default)]. But the generic type only implements Default if the parameter T does:
#[derive(Reflect, FromReflect)]
// #[reflect(Default)] //< Doesn't work obviously
struct MyType<T> { ... }

impl<T: Default> Default for MyType<T> { ... }

What solution would you like?
Have a way to do what #[reflect(Default)] does but manually, whatever that is (I have no idea where all those #[reflect(xxx)] are documented).
What alternative(s) have you considered?
I don't know of any.
See discussion on Discord: https://discord.com/channels/691052431525675048/742569353878437978/1089576631594668115

I have no idea where all those #[reflect(xxx)] are documented

The attribute is documented here. For #[reflect(Default)] it will register the ReflectDefault struct, documented here.
"it will register" means that it will generate an implementation of GetTypeRegistration that inserts an appropriate instance of ReflectDefault in the TypeRegistration before returning it.
Since the impl is automatically generated you can't modify it, but even if you were able to I doubt you would be able to insert the ReflectDefault if and only if T: Default, since that would require specialization, and unstable (and unsound) rust feature.
What you could do though is to call App::register_type_data, specifying MyType<SpecificDefaultTypeYouNeed> for T and ReflectDefault for D.

Thanks for all the explanations. I'd make a note that the docs:

#[reflect(Default)] will register the ReflectDefault type data as normal.

doesn't explain anything that a regular non-Reflect-expert user can make sense of. I agree there's no good place (except The Book?) to document those attributes, but since we started there we might as well try to fix the existing docs to explain a bit more maybe? Can we put some of the explanations above in the docs?


Revamped the style & added search functionality

• Changed JavaScript to TypeScript
• Changed the Style (used brand colors)
• Added search functionality

In case the "snippets" are folders, it will redirect to the github repo. Otherwise, it will display it on the site.

Added the missing files:

README.md
vercel.json
The prettier configs

Next seems to be unable to find the code directory on the server-side. I am unable to fix it as I've tried a bunch of different methods. However, if someone manages to fetch the files either by using the Github API or filestream, it will be great.
Note that I did attempt to use the Github API, but the hard task is to prevent getting Ratelimited.

Next seems to be unable to find the code directory on the server-side. I am unable to fix it as I've tried a bunch of different methods. However, if someone manages to fetch the files either by using the Github API or filestream, it will be great.
Note that I did attempt to use the Github API, but the hard task is to prevent getting Ratelimited.

This would be less problematic if we fetched data from client side

AHA! I managed to fix the issue!
It works splendidly - you can check it out https://code-examples-puce.vercel.app/ - there are two small steps in order to make it work.
You must create a Personal Access Token, and then add the following .env variables to Vercel in order to work;

NAME equal to your username (for instance, Nemika-Haj)
TOKEN equal to the token
So it must look something like this;

NAME=Nemika-Haj
TOKEN=YourPersonalAccessToken

AHA! I managed to fix the issue! It works splendidly - you can check it out https://code-examples-puce.vercel.app/ - there are two small steps in order to make it work. You must create a Personal Access Token, and then add the following .env variables to Vercel in order to work;

NAME equal to your username (for instance, Nemika-Haj)
TOKEN equal to the token
So it must look something like this;

NAME=Nemika-Haj
TOKEN=YourPersonalAccessToken

I don't reckon you need a token for public repositories, do you? You can fetch data un-authenticated.

@DevAndromeda could you do this? ^


Added additional SUSE redirect

Proposed changes
Closes https://github.com/docker/docker.github.io/issues/8981
Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit b5659dd1debdf9285c4c43fc94ef4728766034bb
https://deploy-preview-8983--docsdocker.netlify.com


charts.helm.sh not available in belarus

The https://charts.helm.sh/stable not available in belarus.
Why?
Maybe you can get me some alternatives?

Already fixed


Why not create a script or GUI action in server management?

Too many steps to config Windows Hello for business. Why not create a script or GUI action in server management?

@officedocsbot assign @e0i

@wayyt
Somehow your issue has been opened without being associated to a documentation topic.
Could you clarify which documentation you're referring to? A link would be helpful.
Thanks.

@wayyt
We are closing this issue as there hasn't been a response from your side regarding the specific article where the issue stems from.
Feel free to re-open this issue by clarifying the problematic document and we'd be glad to come up with content updates.
Thank you for providing feedback.

@officedocsbot close

I apologize for this communication breach.  Tech support told me this was possible.  A lot of emails, messages, etc could be blocked or very late to receive.  I am very sorry to take your time and 18 days wow.  Please excuse my communication breach. It explains why accusations of conduct and more have been filed against me.  I do not have complete access to my accounts.     Thank You for much clarification.  Handling with priority.


add middleware to expand eip association embedded inside eip

Q
A

🐛 Bug fix?
yes

🚀 New feature?
no

⚠ Deprecations?
no

❌ BC Break
no

🔗 Related issues
#563

❓ Documentation
no

Description
add middleware to expand eip association embedded inside eip

Didn't we remove the driftctl_test.go file on purpose?

idk but where should we add these kind of test now ?


Support Endpoint Stats

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

Add support for enabling per endpoint stats in envoy
https://github.com/envoyproxy/envoy/pull/29709
https://gateway.envoyproxy.io/latest/api/extension_types/#proxymetrics
Will help with traffic splitting telemetry https://github.com/envoyproxy/gateway/issues/2809

I want to try doing this, but I'm not sure if I have the right idea. Do we just need a bool as a switch to enable per endpoint stats on envoy? can you tell me more :)

yup bool pointer is the way to go here :)

When implementing this feature: I will put EnableEndpointStats in ir.Metrics, since adding this feature will require setting the cluster in the buildXdsCluster function.
There is currently a problem: buildXdsCluster is called by different processXXXListenerXdsTranslation, and the parameters of these functions are not consistent. If we plan to support endpoint metrics for all protocols, this will change the parameters of many functions. Big changes to the code.
Currently we are considering whether to enable EnableEndpointStats only under HTTP, or whether to enable it under all protocols. I want to hear your opinions. Thanks  :)
@envoyproxy/gateway-maintainers

cc @zirain @Xunzhuo

@arkodg  WDYT comment

not sure I exactly understand @ShyunnY, here's what Im thinking

add a new field under ir.Metrics as youve suggested
add another field in xds cluster args https://github.com/envoyproxy/gateway/blob/a5bedbc71037b9ea7c07b9aa69d3d9218c92d0dc/internal/xds/translator/cluster.go#L40
build/translate in https://github.com/envoyproxy/gateway/blob/a5bedbc71037b9ea7c07b9aa69d3d9218c92d0dc/internal/xds/translator/cluster.go#L77

Yes, you're absolutely right, that's exactly what I was thinking.
But another problem arises at this time:
The upper caller of buildXdsCluster is addXdsCluster, and addXdsCluster is called by different callers. We will find a phenomenon: *ir.Metrics seems to only appear in processHTTPListenerXdsTranslation:
https://github.com/envoyproxy/gateway/blob/a5bedbc71037b9ea7c07b9aa69d3d9218c92d0dc/internal/xds/translator/translator.go#L118-L124
Based on the information above, going back to the original comment, do we currently only support endpoint stats under HTTP? This question has made me hesitant about how to proceed with writing this PR, because I'm not sure.

we should support for all, the existing field in that IR (virtualHostStats) is related to HTTP, so the initial commit was only applied to HTTP

will this cause high cost of memory?


bgpv1: check services for reconciliation if iTP=local

In cluster IP advertisement, we need to reconcile services with iTP=Local and have changes in its endpoints.

/test

ci-ipsec-e2e: https://github.com/cilium/cilium/issues/27762


Expand ~ in commands

This expands '~' in commands so I can do things like '~/some/path/something.sh'.

Thanks for the contribution!


Honor #if when preprocessing

Now that https://github.com/cake-build/cake/pull/1858 is merged it would be nice if script processing also would honor defines. E.g. conditionally load files or install addins/tools.

@mholo65 According to @devlead's integration tests, this should work ootb with the Roslyn script engine (unless I misunderstood something).

@mholo65 Ah, I read your issue again, and I misunderstood. Sorry.

😄 np. Yeah, according to @devlead's testing, not even csi.exe supports it. See https://github.com/cake-build/cake/issues/1766#issuecomment-333958357

@mholo65 This is not a trivial problem to solve unless we want to implement our own preprocessor evaluator.
#if (DEBUG && !MYTEST)
        Console.WriteLine("DEBUG is defined");
#elif (!DEBUG && MYTEST)
        Console.WriteLine("MYTEST is defined");
#elif (DEBUG && MYTEST)
        Console.WriteLine("DEBUG and MYTEST are defined");
#else
        Console.WriteLine("DEBUG and MYTEST are not defined");
#endif

I rather see us implementing conditionals in the directives themselves,  than doing our own compiler, while there's great reward, I feel there's great risk, with the potential of coming back to haunt us multiple times. Also the more we diverge from standards, the harder tooling will be.


New preset positions for arm.

Also, split shelf preset between cone and cube.

Will merge after a quick test


☀ Enhancement: Log Support

Summary
Like other programs the scripts should log their activity in some temporary log file if any error occurs the script should prompt the user to check the log file.
Description
The implementation of logs will help with future debugging. Logs will also help the future community to tackle each other's problem with ease as well.

Logs will be handled by NPM as of now.


Just check name of exception to avoid an issue if ClassCastException …

…comes from different class loader
@bjorncs or @jonmv PR

I guess this doesn't hurt, but I didn't think this was possible.

No, this is just be my guess to how you can end up with
java.lang.IllegalArgumentException: java.lang.ClassCastException@1b0496ad
at jdk.internal.reflect.GeneratedMethodAccessor304.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.yahoo.processing.request.CloneHelper.cloneByReflection(CloneHelper.java:121)
at com.yahoo.processing.request.CloneHelper.objectClone(CloneHelper.java:99)
at com.yahoo.search.query.properties.CloneHelper.objectClone(CloneHelper.java:17)

We need the full stack trace to be sure. My guess is that whatever code path logging the exception only includes the cause (not outer exception), or some code of the stack is wrapping or partially unwrapping the exception before rethrowing.

We have strong confirmation the cause is indeed null, and we're confused by a message string which is ClassCastException@<some hash> ... Ü


Add parallax scrolling to background

Adds separation of background and midground, scrolling at different speeds.
Adds two new assets ("images/backgroundp.png" and "images/foreground.png").

That's really, nice however I'm getting quite a big black line between the 2 background images:

If you can get that fixed, I would merge.

I've resized the sprites and updated the code, and that seems to have fixed the issue.


Refactor URLSession tests to only run with a single instance server

Previously any test that needed a server would create it's own. While not an issue at the moment it's clear this wouldn't scale very well. This change creates a single server at the start of the tests, and then all the tests use this server.
This PR addresses SR-4676.
I've run the tests on both Mac and Linux to confirm they all pass.

Thanks for getting this done!
@swift-ci please test and merge


Leave pickadate always open.

Hi,
Thank you for this awesome lib.
I am trying to permanently display pickadate. I am displaying it using api: picker.open()
Is there a way to disable auto-close on focusout?
Thank you.

picker.open(false) will prevent initial closing when focus-out as per #973
unfortunately, it seems to still close on focusout after selecting a date then focusout.