BlueprintCircuit does not respect modifications when being rebuilt

Information

Qiskit Terra version: 0.18
Python version: any
Operating system: any

What is the current behavior?
Derived classes of BlueprintCircuit will let the user modify the circuit without comment, for example by adding gates or registers, but anything that triggers a rebuild of the circuit will behave unpredicatbly, often overriding all modifications.
This issue is a follow on from a previous discussion: https://github.com/Qiskit/qiskit-terra/pull/6828#discussion_r679360956.
Steps to reproduce the problem
Example taken from @Cryoris' comment:
>>> from qiskit.circuit.library import RealAmplitudes
>>> circuit = RealAmplitudes(1, reps=1)
>>> circuit.h(0)
<qiskit.circuit.instructionset.InstructionSet object at 0x7fb3e95039d0>
>>> circuit.draw()
     ┌───────────────────────────┐┌───┐
q_0: ┤ RealAmplitudes(θ[0],θ[1]) ├┤ H ├
     └───────────────────────────┘└───┘
>>> circuit.num_qubits = 3
>>> circuit.draw()
     ┌────────────────────────────────────────────────┐
q_0: ┤0                                               ├
     │                                                │
q_1: ┤1 RealAmplitudes(θ[0],θ[1],θ[2],θ[3],θ[4],θ[5]) ├
     │                                                │
q_2: ┤2                                               ├
     └────────────────────────────────────────────────┘

The Hadamard has gone missing.
What is the expected behavior?
We shouldn't be able to get ourselves into a situation where our modifications will be overwritten without warning.
Suggested solutions
Possibilities:

BlueprintCircuit (or derived classes) reject modifications outside their expected set.
On modification, return a concrete QuantumCircuit instance without the _build() functions, and emit a suitable warning.  Ensure there's a method we can call first to turn it into a concrete class, so the warning is avoidable if that's something the user wants to do.
Attempt to do some crazy trickery to maintain the spirit of the instructions.  This could be something like keeping track of a "modification queue", and re-applying it on rebuild.  This would be the most difficult, and probably not a good idea at all - it basically assumes that _build() will never change the structure of the circuit, which runs somewhat counter to the purpose of that method at all.

I'd prefer option 1, because it doesn't include implicit casts to ordinary circuits 🙂


some issue using this in angular

hi,
when I try to use is in angular, it gives me warning:
WARNING in ./node_modules/moment-holiday/build/moment-holiday-us.min.js
10:53-60 Critical dependency: require function is used in a way in which dependencies cannot be statically e
xtracted
WARNING in ./node_modules/moment-holiday/build/moment-holiday-us.min.js
6:3284-3296 Critical dependency: the request of a dependency is an expression

and when it's loaded in browser:
Uncaught TypeError: Cannot read property 'fn' of undefined
I'm new to js and typescript, so couldn't figure out a way to fix it. so if anyone could take a look would be awesome.
what I did in code is to test some functions:
import * as holidays from 'moment-holiday';
   this.locales = holidays.load('united_kingdome');
Thanks!

Did you find a solution for this? I am having the same problem.

See this PR:
https://github.com/kodie/moment-holiday/pull/31
You can use my fork like this:
    "moment-holiday": "https://github.com/lwensveen/moment-holiday.git#require",

Hi there, we at @nesto-software are currently open sourcing a new moment-holiday library which further improves this great approach by kodie. There is only a small number of supported countries yet. However if you want to check it out: https://github.com/nesto-software/moment-holiday/
For the frontend, there is an usage example.

Not super pretty, but this works in an angular cli project as such:

add the following to the scripts array of your angular-cli.json file:
 "./node_modules/moment/min/moment.min.js",
 "./node_modules/moment-holiday/build/moment-holiday-us.min.js"

In the file where you want to import moment-holiday, instead just add declare var moment: any; at the top of that file. Then use this library as normal: moment().holidaysBetween(<some_moment_object>)

Still an issue - any update on this would be much appreciated.


Substitution for fortran.gfortranExecutable

Hi,
It would be very nice to have the fortran.gfortranExecutable command substitution in order to set it up programmically, for example to keep it in sync with the toolchain in effect, instead of having it hard coded.
Consider something like
{
  "fortran.gfortranExecutable": "${command:cmake.buildkit.fc}"
}

Totally agree. I think the extension should set header and compiler path based on something like compile_commands.json similar to clangd server. This file can be generated by most high level make tools https://www.jetbrains.com/help/clion/compilation-database.html#compdb_generate

That would certainly be an interesting feature to have. I am not a big user of CMake, I tend to use GNU autotools, but I suspect that  if we were to integrate build systems like CMake in the extension, it would have to happen at a level that does not affect the VSCode settings, since depending how you have setup VSCode project these settings could be synced across all other projects.
I suspect that a similar option could be applied for the includePaths option as well, allowing for Modern Fortran to locate modules that are not in the default include directories and in linterExtraArgs which would include the compilation flags used.
I am more than happy to hear your thoughts on how this could be implemented in a reasonable manner.

Well, to be more specific, I run the MSYS2 extension for VS Code where C/C++ support is pretty complete though the MS' CMakeTools and CppTools extensions and FORTRAN support is lagging behind due to lack of such substitution.

@okhlybov Out of curiosity wouldn't ${config:cmake.buildkit.fc} also do the trick?

@okhlybov Out of curiosity wouldn't ${config:cmake.buildkit.fc} also do the trick?

No. The cmake.buildkit.fc is not a static configuration parameter but a function which lazily creates the path according to the build kit currently  in effect.

That is unfortunate, I was hoping we could squeeze this into PR #238 but if the settings string uses ${command:} we might not be able to. Would you be able to provide a Minimal Working Example using CMake with fortran for me to have a look?
On a related note, is the functionality that you are mentioning available in the C/C++ extension?

Well, I don't think that the ${command:} handling is any different from the ${config:}.
As for example, take a look at my  CMakeWorks project.
It covers both the CMake and the VS Code and is meant to be a complete
new project template.

On a related note, is the functionality that you are mentioning available in the C/C++ extension?

Yes, the C/C++ part works pretty well.
There are some glitches even within the core VS Code's code itself concerned with various string interpolation issues in certain parts of the code, though. For instance, the terminal.integrated.shell setting is not interpolated, so ${command:} can't be used here to obtain the build kit -specific shell. Also, while the cmake.cmakePath gets interpolated so the ${command:cmake.buildkit.cmake.exe} can be used to obtain the build kit -specific CMake executable, its value gets evaluated eagerly resulting in an inability to track the subsequant changes to the build kit. Hence, a window reload is required after the build kit switch in order a new value of the cmake.cmakePath to take effect.
These issues should be considered when adding interpolation support to the Fortran extension.

Variable interpolation has been added to v2.6.1 it probably is unable to do what is requested in this issue but we are tracking this request in #133 . Please move any further queries there or if not applicable open a new issue.


Adapt design into RTOS?

I've recently took a course about Real Time Operating Systems, and was wondering, how difficult would it be to adapt the current OS design into a bare-bones RTOS?

@JohnPeng47 I am not very familiar with RTOS design, but as far as I understand an RTOS should have more advanced scheduling algorithms and provide some guarantees about how fast a process should be waked in case some signal arrives Currently the RPi OS don't support signals and waitlists (it should be implemented in the lesson 7) Only after this functionality is ready we can discuss how to adopt the RPi OS to be an RTOS.


Support multiple statements within one query

C# PostgreSQL clients send multiple statements within one query to build a connection, which is not currently support yet. Can we add this feature?
   Unhandled exception. System.Exception: Error connecting to database: XX000: only a single statement at a time is currently supported
    ---> Npgsql.PostgresException (0x80004005): XX000: only a single statement at a time is currently supported

Sure, it is a common usage. Let's look into this in the coming weeks.


[Event Request] report 393 "Suggest Vendor Payments" - SetTempPaymentBufferDims

Hello,
Please add this event:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Adds test for blockheight for all endpoints

A method is added to NetworkAPI that sanitizes the endpoints; where the endpoints that are unreachable or are un-synced (based on their given blockheight) are removed.
This fixes issues like #140

Why didn't the tests trigger?

Why didn't the tests trigger?

Good question. We've always had this issue I believe. The tests are supposed to run on your fork. I'll see if there's some settings preventing this in this repo.

Settings look OK...

Anyway, I'll review and test locally for now.

This is very clever! Nice work!

I'm thinking a way to mitigate this would be to cache the provider so the block height is not fetched every time.

I implemented a time-to-live cache for blockheight with cache time limit of 120s.

Implementation
Wall time

No blockheight based sanitation
365ms

Cached blockheight, first hit
2.71s

Cached blockheight, second hit
1.05s

Cached blockheight, no unresponsive bitcoin.com api, first hit
1.34s

Cached blockheight, no unresponsive bitcoin.com api, second hit
514ms

We can remove the second default API in BitcoinDotComAPI, which is the now unresponsive rest.bitcoin.com. It causes much delay in blockheight retrieval.

Thanks! Yes we can definitely remove rest.Bitcoin.com and drop Python 3.8 support.
However, there is already a caching system present in BitCash for currency conversion support: set_rate_cache_time
Why not use something like this instead? Just a question, no need to re-implement everything. I'll submit a PR removing rest.Bitcoin.com in the meantime.

@yashasvi-ranawat I have prepared a PR removing rest.Bitcoin.com. Feel free to review it if you have the time (I completely understand if not; in which case I will merge).
https://github.com/pybitcash/bitcash/pull/143

However, there is already a caching system present in BitCash for currency conversion support: set_rate_cache_time

yeah, good idea! I'll have a look.

I had a look at the cache setup for rates API! It was similar to the one I added to utils, but was specific to use for rates API. I refactored the one in utils to cache multiple entries with LRU cache. This is now usable by both blockheight caching and rates caching. I updated the tests accordingly.

I further refactored to caching of sanitized endpoints, instead of endpoint's blockheight. This drastically improves wall time.

Implementation
Wall time

No blockheight based sanitisation
365 ms

Cached sanitized endpoints, first hit
1.28 s

Cached sanitized endpoints, second hit
198 ms


gradlew koverHtmlReport koverVerify launches "Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException"

Hi,
When I try to run "gradlew koverHtmlReport koverVerify" to generate a report, I receive the following error. It seems something has changed in my application that generates an error as some commits ago I was able to do it without encountering problems. Now it happens and I don't understand where to find the problem or how can I debug this.
[ERROR] [system.err] Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 7 out of bounds for length 7
[ERROR] [system.err]       at jetbrains.coverage.report.idea.IDEACoverageClassInfo.getStatementStats(IDEACoverageClassInfo.java:129)
[ERROR] [system.err]       at jetbrains.coverage.report.impl.StatisticsCalculatorImpl.computeForClass(StatisticsCalculatorImpl.java:51)
[ERROR] [system.err]       at jetbrains.coverage.report.impl.StatisticsCalculatorImpl.doCompute(StatisticsCalculatorImpl.java:40)
[ERROR] [system.err]       at jetbrains.coverage.report.impl.StatisticsCalculatorImpl.compute(StatisticsCalculatorImpl.java:34)
[ERROR] [system.err]       at jetbrains.coverage.report.impl.html.HTMLReportBuilderImpl.generateReport(HTMLReportBuilderImpl.java:80)
[ERROR] [system.err]       at jetbrains.coverage.report.impl.html.HTMLReportBuilderImpl.generateReport(HTMLReportBuilderImpl.java:76)
[ERROR] [system.err]       at com.intellij.rt.coverage.report.Reporter.createHTMLReport(Reporter.java:53)
[ERROR] [system.err]       at com.intellij.rt.coverage.report.Main.main(Main.java:48)
[DEBUG] [org.gradle.process.internal.DefaultExecHandle] Changing state to: FAILED
[DEBUG] [org.gradle.process.internal.DefaultExecHandle] Process 'command 'C:\Program Files\Java\jdk11015\bin\java.exe'' finished with exit value 1 (state: FAILED)
Can you help me to understand what should I check and what should I do to solve the problem?
Thanks a lot!

Hi,
is your project open source?

Related #166

I've experienced same issue; in my case with android modules. Switching to intellijEngineVersion.set('1.0.671') solved it

Seeing the same issue with engine 10.0.668, but only when run on our Linux CI machine.  The same task locally on an M1 Mac succeeds.

Same here using Cover 0.5.1 on Apple M1. Setting intellijEngineVersion.set("1.0.674") fixed it as well.

You can get the latest IntelliJ engine version from looking at the versions in Maven Central: https://search.maven.org/artifact/org.jetbrains.intellij.deps/intellij-coverage-agent

@shanshin I think that's because I got some ignored test method

Must be fixed in 0.6.0, feel free to reopen if the problem reproduced again.


Add-on hangs Up and starts Big CPU consuption

Add-on hangs Up every day it stops working and starts to consume 26% of muy CPU power. If i restart it, everything works ok til Next day.

I have the same issue. Even reaches 40% of CPU. And yes it stops working every day even if the service seems to be still running. @fmartinou any idea ?

Take a look at tydom app. It is very possible that you have a pending update of your tydom box. It seems that i solve the problem 3 days algo. I havent post it yet cos its very soon, but for me, since the update, it work.

Ok. I will try. You are right, I have a pending update. I did not do it on purpose as I thought it would make it worse as it seems that this update has big things.

Hi,
I'm aware of that high cpu usage problem; I don't known yet where it comes from.
Unfortunately, these days I have absolute no time to investigate so don't put too high expectations on me :/

In the meantime and until we have a bug fix, how can we automate a daily restart of the integration ?

The continous hand up makes this addon unusable to driver the covers. This is quite disappointing. A new version 3.2.0 was released this week and I was hoping that the bugs would be fixed. But no change. Does every have these bugs or did you find a turnaround ?

Hi,
Along with every new release there is a changelog you can read: https://fmartinou.github.io/tydom2mqtt/#/changelog/
As you can see it doesn't mention this bug so... don't expect it to be resolved ;)
Unfortunately, I don't have neither time nor enough devices to troubleshoot it so I cannot work on it right now; sorry about that.
If someone with more time or hardware is able to troubleshoot it; he's welcome 😃 .

I also have this problem.
I checked the code rapidly, I think we need an outer while loop in the main function to handle connection exceptions (Error 1000… etc…) rised by the websocket (and so, re-do the setup in the outer loop.
The current while loop catch all exceptions, and, if the websocket is closed, it will rise an infinite number of exceptions, leading to massive logs and cpu usage.
I didn’t try this theory for the moment, but i will do my best to check it soon.

Thanks mate. That would be great if you can solve this issue. The only solution I found is to restart the service every hour with an automation.

I had the same issue as you guys.

With the new HA update today, there is a new warning that devices and entities name can't be the same. This issue is raised with most of the mqtttydom entities and it says that this needs to be fixed before the 2024 02 update of HA as it won't be compatible anymore. Hummm

I made a PR here #119 for this bug.

With the new HA update today, there is a new warning that devices and entities name can't be the same. This issue is raised with most of the mqtttydom entities and it says that this needs to be fixed before the 2024 02 update of HA as it won't be compatible anymore. Hummm

I saw the changelog regarding this. There is a PR here #116 which improves the naming of devices and entities, but it's only for sensors. I think we need to do the same on other types (covers, switch, light...).
Maybe you can create another issue about this improvement, so we can keep track of the progress.

Hi,
The #119 is available in the version 3.3.0; please give it a try and report here if the app is more stable or not.
Thanks!

See what it says now for the entities names:
Some MQTT entities have an entity name that starts with the device name. This is not expected. To avoid a duplicate name the device name prefix is stripped of the entity name as a work-a-round. Please inform the maintainer of the software application that supplies the affected entities to fix this issue.
List of affected entities:
binary_sensor.battdefect_tydom_volet_tele
binary_sensor.battdefect_tydom_volet_chambre_mylene
binary_sensor.onfavpos_tydom_volet_sejour
binary_sensor.onfavpos_tydom_volet_fenetre_salon
binary_sensor.obstacledefect_tydom_volet_sejour
sensor.position_tydom_volet_sejour
binary_sensor.intrusion_tydom_volet_chambre_parent
binary_sensor.battdefect_tydom_volet_fenetre_salon
binary_sensor.battdefect_tydom_volet_sejour
sensor.position_tydom_volet_bureau
binary_sensor.obstacledefect_tydom_volet_chambre_parent
binary_sensor.intrusion_tydom_volet_chambre_mylene
binary_sensor.obstacledefect_tydom_volet_tele
binary_sensor.thermicdefect_tydom_volet_dressing
sensor.position_tydom_volet_fenetre_salon
binary_sensor.obstacledefect_tydom_volet_fenetre_salon
binary_sensor.intrusion_tydom_volet_dressing
sensor.position_tydom_volet_chambre_mylene
binary_sensor.onfavpos_tydom_sejour
sensor.position_tydom_volet_cuisine
binary_sensor.thermicdefect_tydom_volet_tele
binary_sensor.intrusion_tydom_volet_tele
binary_sensor.onfavpos_tydom_volet_bureau
binary_sensor.thermicdefect_tydom_volet_fenetre_salon
binary_sensor.intrusion_tydom_volet_cuisine
binary_sensor.battdefect_tydom_volet_cuisine
binary_sensor.intrusion_tydom_volet_canape
binary_sensor.thermicdefect_tydom_volet_cuisine
sensor.level_tydom_sejour
sensor.position_tydom_volet_chambre_parent
binary_sensor.onfavpos_tydom_volet_tele
binary_sensor.obstacledefect_tydom_volet_dressing
binary_sensor.thermicdefect_tydom_terrasse
binary_sensor.onfavpos_tydom_volet_chambre_mylene
binary_sensor.obstacledefect_tydom_volet_canape
sensor.position_tydom_volet_dressing
binary_sensor.thermicdefect_tydom_volet_bureau
binary_sensor.thermicdefect_tydom_sejour
sensor.position_tydom_volet_tele
binary_sensor.battdefect_tydom_volet_dressing
binary_sensor.onfavpos_tydom_terrasse
sensor.position_tydom_volet_canape
binary_sensor.obstacledefect_tydom_volet_cuisine
binary_sensor.intrusion_tydom_volet_fenetre_salon
binary_sensor.battdefect_tydom_volet_canape
binary_sensor.onfavpos_tydom_volet_cuisine
binary_sensor.thermicdefect_tydom_volet_chambre_mylene
binary_sensor.intrusion_tydom_volet_sejour
binary_sensor.thermicdefect_tydom_volet_sejour
binary_sensor.battdefect_tydom_volet_chambre_parent
binary_sensor.obstacledefect_tydom_volet_bureau
binary_sensor.intrusion_tydom_volet_bureau
binary_sensor.onfavpos_tydom_volet_dressing
binary_sensor.onfavpos_tydom_volet_canape
binary_sensor.battdefect_tydom_volet_bureau
binary_sensor.obstacledefect_tydom_volet_chambre_mylene
sensor.level_tydom_terrasse
binary_sensor.thermicdefect_tydom_volet_chambre_parent
binary_sensor.thermicdefect_tydom_volet_canape
binary_sensor.onfavpos_tydom_volet_chambre_parent
Avertissement - 04/08/2023

This warning appears with HA 2023.8.0 (see #121).
I personally also have this warning for all my sensors reported by zigbee2mqtt 🤷♂ .
It doesn't cause any issue right now (we just have to fix the code until 2024.2.0 is released ;)

Hi,
Unfortunately, the stability is still not there. Although the  bug of the CPU load seems to be solved, the connection with the Tydom seems to continue to drop. I still have to reload periodically the service.
The observed difference is that when the connection is dropped, the CPU load is now zero instead of 24% or higher with previous version.

Do you have any logs from when the connection drop ?
The fix only catch the ConnectionClose exception (which is websocket related).

Where should I look for those logs ?


Add Extract Quantisation Tables operation

Quantisation tables are 8x8 matrices embedded in every JPEG image. They are used for lossy compression and are needed to decode the image.
Different camera makes, models and image processing programs may use different preset quantisation tables for different levels of image compression. Therefore it may be possible to fingerprint the device or program used to produce an image even when other metadatas like EXIF are removed:
Using JPEG Quantization Tables to Identify Imagery Processed by Software
Digital Image Ballistics from JPEG Quantization: A Followup Study

Hey!  This pull request has gotten rather old and that's our fault.  This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust.  Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

Hey, this PR has remained without updates for four weeks now.  I'll close it now, but feel free to re-open if you find time to contribute! 😄


10.0.18362.267 not supported

10.0.18362.267 not supported

Please, attach your RDPConf screenshot and termsrv.dll.

Offsets here: https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini
I can't find first issue with correct title.

Duplicate of https://github.com/stascorp/rdpwrap/issues/871


Suggest to use flag before subcommand if not used correctly

Suggesting to use the flag before the subcommand would make the application a bit more user-friendly.
Sample Code
App::new("myapp")
    .arg(Arg::with_name("foo")
        .long("foo"))
    .subcommand(SubCommand::with_name("bar"));

myapp bar --foo

Actual Behavior
error: Found argument '--foo' which wasn't expected, or isn't valid in this context

USAGE:
    myapp bar

For more information try --help

Expected Behavior
error: Found argument '--foo' which wasn't expected, or isn't valid in this context
      Did you mean to put '--foo' before the subcommand?

        myapp --foo bar
              ^^^^^

USAGE:
    myapp bar

For more information try --help

Apologies for the late reply, I was travelling the past week.
This would be a cool feature! I'd be willing to mentor anyone who wants to take a swing at this, although I'd change the wording slightly:
error: Found argument '--foo' which wasn't expected, or isn't valid in this context
      Did you mean to put '--foo' after the subcommand?

        myapp bar --foo
                  ^^^^^
USAGE:
    myapp bar

For more information try --help

The key code to add would be:

Adding a variant here, to DidYouMeanMessageStyle
Handling the new variant here
One would probably be best off simply adding a new did_you_mean_child_args type function, which could use did_you_mean as a template of sorts.
And finally calling this new function inside here, but using some logic like

if no subcommands, don't check for child args [obviously]
re-scan env::args_os for possible subcommands using find_subcmd!(self, arg_os) which correctly checks aliases.
You can get all the long version of flags and options with by Chaining the longs in Parser::flags and Parser::opts as in self.flags.iter().filter_map(|f| f.s.long).chain(self.opts.iter().filter_map(|o| o.s.long)) which could probably be passed to your did_you_mean_child_args

We'd need to ensure that when re-scanning env::args_os if an arg returns that it is a valid subcommand, but does not contain --foo, we continue searching (one level deep only). This will prevent prog foo --bar baz from accidentally checking foo for --bar which we already know doesn't exist or we wouldn't be here. And only return the error if after exhausting the list we still haven't found anything. I'd also like to see how this interacts with large argvs...such as shell glob expansions that could be in the thousands or tens of thousands (although I think this would be rare case).


New package: JulGame v0.0.1

Registering package: JulGame
Repository: https://github.com/Kyjor/JulGame.jl
Created by: @Kyjor
Version: v0.0.1
Commit: 0acef047ff886a8ab206800242824411023221c1
Git reference: HEAD
Description: julgame is a game engine based on the julia programming language with the help of SDL2.

You might be able to get away with the name as a clever play on https://en.m.wiktionary.org/wiki/jól#Icelandic

I'd prefer to get away with it, but if need be I can change it to get it merged I can

If you want to keep the name, you’ll have to get one of the maintainers’ attention on Slack

Thank you, will do

I'd like to make an argument for why I would like to keep the name. I've been working on this project on and off for about a year, and finally came upon the name JulGame. I think that it is short and sweet. I think it feels good to say. This name encapsulates what the project is about. "Jul" is the etymological root of “jolly” as well as the prefix for Julia, making it a pun that works well with “Games”. I am not associated with Julia (obvious to us here). This is also a play on pygame. They are also not associated with python. The reason I started working on this project is that I think that it could help create a new game dev community for Julia, as it is extremely small at the moment. I'd like to see it through with this name. Thank you for the consideration.


Update common-file files to master

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_client-go
c7109dc3d6b74e64354312349471f452fca01eb9
link
/test gencheck_client-go

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Schemas with default values for fixed and bytes fields do not parse.

A schema containing a record with the following field:
{ "name": "binary",
        "type": {
          "type" : "fixed",
          "name" : "FixedField",
          "size" : 1
        },
        "default": "\u0000"
      }

will fail to parse because parseAvroJSON does not handle parsing JSON strings into Fixed or Bytes values:
Could not resolve type 'string' with expected type: Fixed {name = "FixedField", namespace = Nothing, aliases = [], size = 1}

The same problem for a field with type "bytes":
Could not resolve type 'string' with expected type: Bytes

I have a couple of failing test cases for this and I'm pretty sure I know how to fix it, but I figure I'd throw up an issue while I start working on a PR for it.

Yes, default is a bit of a gray area. We have never used it until recently, and I fixed a bug regarding default=null a couple of days ago, so there may be more corner cases about it.

Luckily, the code for dealing with defaults is basically a subset of the code for dealing with JSON-encoded values, so I'll be adding tests and fixing issues around defaults as part of exposing the JSON functionality.
I'm actually already part of the way through a patch for this issue. I've just run into a problem with the TH deriving code that needs debugging.

Okay, I believe this is fixed now.


Fixed #28602 - file watch based autoreload for Windows

Currently utils/autoreload.py has implementation for inotify based file system watcher. On Windows it scans all files for changes every 1 second which takes a lot of CPU. Windows provides file system watching API (FindFirstChangeNotification) which does the same thing as inotify on Linux. Django should take advantage of the API to make autoreload more efficient.

Is all the code covered by existing tests?
Do you have any colleagues familiar with the win32 libraries who could review the code? I don't think we have that expertise among the few people regularly reviewing patches.


Feature push notifications

Description
This PR adds notifications to the app. It allows the user to receive notifications by subscribing to the topic "new_post" using Firebase FCM. Notifications are sent to the topic using an Appwrite cloud function.
Checklist

[x] ✅ Ran tests locally
[x] 🧹 Ran dart format
[x] 📸 Uploaded a Video/Screenshot

I mean why does the string say development
....sent from my phone
On Sat, Dec 21, 2024, 11:25 AM David Allen @.***> wrote:

@.**** commented on this pull request.
In ios/Runner/Runner.entitlements
https://github.com/anirac-tech/gordon-ferguson-app/pull/11#discussion_r1894660868
:

@@ -0,0 +1,8 @@
+
+
+
+

aps-environment
development

This is an entitlement needed for push notifications on apple
—
Reply to this email directly, view it on GitHub
https://github.com/anirac-tech/gordon-ferguson-app/pull/11#discussion_r1894660868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBGYLEHPSC4VXX3IGWMB32GWQAZAVCNFSM6AAAAABTOUQZP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJYGY4TGMZZG4
.
You are receiving this because your review was requested.Message ID:
@.***>


Build both kuiper and plugins with -trimpath

Some built plugin cannot be loaded by kuiper. It happens when building my tflite plugins. I got the problem solved by add -trimpath to kuiper and plugin build according to this go issue.

Done for https://github.com/emqx/kuiper/pull/714


Australian Stock Exchange tickers e.g. ASX:TLS

Hi RomelTorres,
I am trying to get Australian Stock Exchange tickers. e.g.
https://www.alphavantage.co/query?function=TIME_SERIES_DAILY_ADJUSTED&symbol=ASX:TLS&outputsize=full&apikey=
It works on the https request, but I think there may be a problem with your class in parsing the ':' in the symbol.
Either way, thanks for a great project!
Anton

nevermind. got it working by this:    (" as oposed to ')
data_ext, meta_data = ts.get_daily_adjusted(symbol="ASX:TLS", outputsize='compact')
as opposed to:
data_ext, meta_data = ts.get_daily_adjusted(symbol='ASX:TLS', outputsize='compact')


"Address in use" from wasm-pack test, wasm-bindgen-test-runner works directly

🐛 Bug description
running wasm-pack test --firefox fails with
     Running target/wasm32-unknown-unknown/debug/deps/web-3188965b70e2da5b.wasm
error: failed to spawn server
        caused by: Address in use (os error 98)
error: test failed, to rerun pass '--test web'

Running the tests directly with wasm-bindgen-test-runner works:
GECKODRIVER=~/.cache/.wasm-pack/geckodriver-9eb5869638f1c05c/geckodriver ~/.cache/.wasm-pack/wasm-bindgen-b893d03f14529eb0/wasm-bindgen-test-runner target/wasm32-unknown-unknown/debug/deps/web-3188965b70e2da5b.wasm
Running headless tests in Firefox on `http://<IP_ADDRESS>:34315/`
Try find `webdriver.json` for configure browser's capabilities:
Not found
running 1 test

test web::pass ... ok

test result: ok. 1 passed; 0 failed; 0 ignored

🤔 Expected Behavior
Running the tests from wasm-pack should have worked.
👟 Steps to reproduce
Work through the wasm-book on a fresh VM? I have vscode remote installed, and just-enough-GUI to permit firefox (see #720 for context) - given that that also had an address in use error, I suspect the gui nature was irrelevant)
🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: 0.8.1
rustc version: 1.38.0 (625451e37 2019-09-23)

I suspect this is trying to use a port I have in use in a docker container, but it is not documenting what port it is trying to use, nor letting me control it.

Encountered the same problem. Using strace I found that it's trying to bind port 8000.

Still a problem, and still no way to configure it from what I can find. A workaround is to use --headless.


Rails 3.1 compatible branch doesn't work w/o Asset Pipeline

Please fix the Rails 3.1 compatible branch and release a version 3.1.6.
Thanks!

Ohnoes, this should be merged into 3-1-stable.


Locale separator

As result of conversation at https://github.com/rubenv/angular-gettext/issues/288
Changes to support locales like "en-US" with separator "-".
Separator is configurable.

Apart from the comment above, I don't think this should be a configuration option. Let's just do the right thing and support both - and _.
So this:
langCode.split('_').shift();

Would become:
langCode.split(/\-|_/).shift();

No other changes needed, apart from a unit test.

@rubenv your solution is well, I revert changes and add patch to support both separators.

Cool, could you add a unit test as well? Just copy the two we have here and add a version that uses -: https://github.com/rubenv/angular-gettext/blob/master/test/unit/fallback_language.js

Correction, the tests for plurals are here: https://github.com/rubenv/angular-gettext/blob/master/test/unit/plurals.js
We'll also need to add a hardcoded mapping here: https://github.com/rubenv/angular-gettext/blob/31a175c4d85e793a694bc5dfeb956fccabd05d76/src/plural.js#L3-L5
   var languageCodes = {
        "pt_BR": "pt_BR",
        "pt-BR": "pt_BR",
    };

@rubenv please look at last changes

Excellent, merged, thanks a lot!

Released as v2.3.5.

@rubenv cool, thanks)


Unable to specify length of TinyInt in MySQL engine

Hi,
We are attempting to port over our code from Sequelize to Prisma. However we have an issue where some of our database fields are TinyInt(1), but also actually represent Integers.
Introspect defaults to mapping them to boolean, which is understandable. We can correct the mapping to Integer @db.TinyInt, however this wants to map to TinyInt(3), altering the database schema and attempting to wipe the dev database.
According to https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#mysql-1 it is possible to specify @db.TinyInt(1) as a type, however in practice prisma complains that TinyInt doesn't take any arguments.
I found this Issue - https://github.com/prisma/prisma-engines/issues/1182 which appears to implement this, however the associated PR was closed without ever being merged.
Can I ask why this support was abandoned, if it is still being considered, and if there is any way around it for our problem?

Hi @tomhoule, thanks for following up. So we have an existing database. Some tables have fields which are TinyInt(1). They are intended to represent a low range of numbers, eg 0-5. Maybe in postgres they would have been an enum.
So the prisma schema heuristic seems to be that TinyInt(1) == Boolean, so prisma migrate --pull generated fieldName Boolean. However that isn't what we want, as they are actually integers. So we can change the schema manually to fieldName Int @db.TinyInt. However now, upon running prisma migrate --dev, prisma will complain that the db's type is TinyInt(1) and prisma thinks it should be TinyInt(3). So it will reset the database, and generate an unwanted migration. And when creating a db with prisma db push, it creates columns of TinyInt(3) instead of TinyInt(1).
So ideally we'd be able to specify fieldName Int @db.TinyInt(1), removing migrate --dev's perceived mismatch, and allowing devs to create tables with a schema that matches production.
Hope this helps!

Thanks!

However now, upon running prisma migrate --dev, prisma will complain that the db's type is TinyInt(1) and prisma thinks it should be TinyInt(3). So it will reset the database, and generate an unwanted migration.

I think that would be considered a bug, we'll try to reproduce and fix that in the migrate tests, thanks for the detailed report!

Per https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#mysql-1 fieldName Int @db.TinyInt(1) should work. Is that not the case?

Hey @janpio it is documented that way, but in practice it's an invalid schema, as TinyInt doesnt have arguments.. Prisma will complain that you have provided an argument to TinyInt when it takes 0.

Note that there is a closed PR that could be part of changing this: https://github.com/prisma/prisma-engines/pull/1191

Any updates on this issue?


C-c C-l causes it to keep loading, and typing it again will get an S-expression parsing failure.

Agda version: 2.6.4
agda-mode version: 0.4.4
Windows 11
When trying to load a module, the window shows loading all the time. And when typing C-c C-l again, it provides the following messages:
Connection Error: Internal Parse Error
Something went wrong when parsing S-expressions. Error code: S4 "cannot read: IOTCM "PATHTOFILE\Test.agda" NonInteractive Direct( Cmd_load "PATHTOFILE\Test.agda" [] )"

This looks like a problem caused by 0.4.4. When I rolled back the plugin version to 0.4.2, it worked fine. Thank you!

Should be fixed in the coming release!


fix: make pinojs work pm2 in verdaccio

There is an open issue with pm2 and pinojs that logs are hijacked by pm2 if  we set pino.destination.
In order to fix this according to https://github.com/pinojs/pino/issues/491, we  don't need to set destination.
so in case verdaccio logs are set to stdout pino destination  is not set

Thanks @juanpicado for the update, I'll look what you did and try to fix it accordingly

closing this, logger not longer in 5.x branch


Gulp port of Iconizr

Is there any chance to see gulp version of this tool soon?

Hi @yoyurec,
I know it's been a long time, but ... just wanted to let you know that I'll start rewriting iconizr from scratch during the next days and then there will be a Gulp version as well (just as I did it for svg-sprite a couple of days ago). Besides that, Happy New Year! :)
Cheers,
Joschi

Sounds good!
happy NY!

@jkphl Hows the Gulp port coming? :)

never )))

@lukewhitehouse @yoyurec I'm very sorry guys, but this is all due to my extreme workload. We moved to a new office in April, we are drowning in complex long-term projects and at some point my daughter wants to meet me as well. As soon as I see the chance to pursue my side projects, I will do.
In the meantime, a new version of node-iconizr is available in the dev-branch, as is a new grunt-iconizr. However, there's no proper documentation yet (as this is about the most time consuming part) and also the Gulp port is still to be done.
I do my very best, but as this is an absolute side project, there are other tasks with higher priority at the moment.

@jkphl completely understand, no reason to apologise. There's more important things in the world than this, take it easy :)

:+1:


Big revamp:

Remove Tensor to fuse with TensorView (the price to pay for shape
cloning should be small enough that it shouldn't make too much of a
difference (less surface is easier to manage).
Added TensorView sanity check at instantiation.
Remove deserialize_file, now that we have safe_open facility.
Tried to remove torch dependency on numpy (Still need the
torch.Tensor to bytes without copying facility for now).
Revamped the speed tests to show metrics side by side. They need
to be taken with extreme caution, timings are never reproducible.

@sgugger Merging, feel free to try the new
with safe_open(..) as f:
    metadata = f.metadata()


fix: binary completion not working on windows

if on windows, tab completion for binaries does not work correctly, but file completion still works.
don't know why especially since it did work in a previous release (woo regressions)

got someone to test it and apparently it works so ill close


Edit initCalendar to work properly with jQuery

Resolve #267 "calendar.fullCalendar is not a function" This is simply the change mentioned in the comments on that issue. I haven't seen anything stating that this breaks the build for others or has a negative consequence, so I think this would be a good change to fix it so others do not have this issue going forward.

Sounds like a good change, reducing friction for those wanting to use ui-calendar this way.
Need to ask for some further effort,

needs a unit test :-)
we need to figure out why the ci test failed, that might be at my end, updating deps
needs a backport to maint-1.0

Thanks Martin.
This is my first pull request for ui-calendar, so I'm new to this.

Where does the unit test belong and how do you think it will be different from what is already testing this functionality?
It seems like the ci test failed because of a bower install "Unable to find suitable version for angular"? I'm not sure how that might have happened, but it doesn't seem like it would be related to my change?
I'm not sure how to create a backport to maint-1.0, or even where to start.

Thanks for the quick response!

All good questions!

Let me look into the bower complaint, I think that's not your fault :-)
Please do add a test that checks for the thing you are after -- that calendar.fullCalendar() is a function. Should fail without your patch, succeed with it.
I can do the backport.

👍

+1

@LukeSchlangen -- master has now been updated, can you rebase? The automated tests are fixed, so if your rebased branch is clean it'll be good. Apologies for the delay.

Your rebase isn't clean, you've ended up with conflict markers in an intermediate commit. Think you can clean up your branch to contain just one commit with the desired change. AFAICS if you just do that the CI tests should work. Thanks.

Ah, you fixed it up, so the branch is now good, however there's the intermediate broken commit. Can you fix up the branch (via a rebase interactive for example)?

Oh no, you're watching this. Embarassing 😄
I've actually never rebased before, so I'm learning as I go, so this might be a little ugly. I'll see what I can do to clean this up.

So I think I cleaned it up? The one thing that seems off is that it says I made a change to the last line by not having no new line at the end of the file, but I'm looking at the current code, I don't see that there either? Should I add an empty line at the end of my file and try rebasing one last time?

Looks like you've cleaned it up already. That's good.
CI is failing with a minor error re that missing last newline. Trivial fix :-)

Do you want me to add it? I think I've got the idea now.

This fix is not available in bower yet. Is there a way to fix this?

It wasn't available in npm the last time I tried either. I'm not sure how to update those? I'm using my own local branch still for this reason (the branch merged here), is there something I can do to update npm and bower or does it need to be an owner?

You should commit the changes to github, because if you look at https://github.com/angular-ui/ui-calendar/blob/master/src/calendar.js#L284 it still says calendar = angular.element(elm).html('');

I think I committed them to my branch and the branch I had control over? I don't have access to this repo at this time, so I'm not sure if I can do it from here. It's a quick change so I could do it again, but I guess I'm not sure why it isn't working? I'm not the owner of angular-ui/ui-calendar, so I don't think I can control the file you mentioned? maybe @martin-langhoff can help us with how to proceed?

Any updates on this issue? Will your change @LukeSchlangen be published to npm?

I'm not sure how to do this. I don't have access to that repo at this time (I stopped working for the organization where that branch exists). The change is small and I can recreate the change and make another pull request. I'm just not sure how this works. If there are instructions on how to do this or what I am missing, I'd be open to trying to fix or redo. I'm wondering if @martin-langhoff could provide some direction?

It seems like your pull request has been reverted in this commit 568e4311206de68beeac5cc2d47a9241a8247f78
While I agree that angular-ui-calendar should not dictate the usage of jQuery, your fix is still needed in my opinion

I supppose @peterver @joshkurz or someone else would need to make that decision.

+1


[stable/prometheus-adapter] Conditionally create custom metrics APIService

Describe the bug
Similar to issue #13716 that was fixed by #14389, custom.metrics.k8s.io needs to be conditionally created based on something like {{- if or .Values.rules.default .Values.rules.custom }}.
Version of Helm and Kubernetes:
$ helm version
Client: &version.Version{SemVer:"v2.15.2", GitCommit:"8dce272473e5f2a7bf58ce79bb5c3691db54c96b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.15.2", GitCommit:"8dce272473e5f2a7bf58ce79bb5c3691db54c96b", GitTreeState:"clean"}
$ kubectl version
Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:16Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
prometheus-adapter version 1.4.0
What happened:
The chart registers custom.metrics.k8s.io APIService but does not serve metrics if custom metrics is disabled, causing future Helm install/upgrades to complain.
UPGRADE FAILED
Error: Could not get apiVersions from Kubernetes: unable to retrieve the complete list of server APIs: custom.metrics.k8s.io/v1beta1: the server could not find the requested resource
Error: UPGRADE FAILED: Could not get apiVersions from Kubernetes: unable to retrieve the complete list of server APIs: custom.metrics.k8s.io/v1beta1: the server could not find the requested resource

How to reproduce it (as minimally and precisely as possible):
Disable default custom metrics rules. e.g. the following values file.
rules:
  default: false

Please re-open it


add ESBAM to list

@luizhcunha lib/domains/br/edu/esbam: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.


Add the list of confirmed speakers

What happened

Append the list of confirmed speakers below the existing list of keynote speakers
Reused the same styles as for keynote speakers for now

Insight

Based on the branch speakers created by @citizen428
Eventually, it would be better to differentiate the keynote speakers from the general speakers but we don't have a design for it yet. To be checked.

Proof Of Work

Nice, thanks!
On 14 Jul 2019 14:53 +1000, Olivier Robert<EMAIL_ADDRESS>wrote:

What happened
• Append the list of confirmed speakers below the existing list of keynote speakers
• Reused the same styles as for keynote speakers for now
Insight
• Based on the branch speakers created by @citizen428
• Eventually, it would be better to differentiate the keynote speakers from the general speakers but we don't have a design for it yet. To be checked.
Proof Of Work
You can view, comment on, or merge this pull request online at:
https://github.com/bangkokrb/rubyconfth/pull/97
Commit Summary
• Add Radoslav Stankov to speakers list
• Add Piotr Murach to speakers
• Add Giovanni Sakti to speakers
• Add URLs to speaker descriptions
• Add Vishal Chandnani to speakers.yml
• Add Dmitry Salahutdinov to speakers.yml
• Add Leandro Ostera and Tae Noppakun Wongsrinoppakun to speakers.yml
• Add Kazuma Furuhashi to speakers.yml
• Add Gabriel Fortuna to speakers.yml
• Add Rodrigo Urubatan to speakers.yml
• Add Sergey Dolganov to speakers.yml
• Add Jaroslava Košanová to speakers.yml
• Add Harley Davidson Karel to speakers.yml
• Add Shweta Kale to speakers.yml
• Add Phil Nash to speakers.yml
• fix typo Shweta
• other minor grammar tweaks
• Remove Dmitry Salahutdinov from speakers.yml
• Add missing bio for Rodrigo
• Add Vipul AM to speakers.yml
• Add Melvrick Goh Aik Chun to speakers.yml
• Add Enrique Mogollan to speakers.yml
• Add Anton Davydov to speakers.yml
• Add Elle Meredith to speakers.yml
• Fix speaker name
• Add Janko Marohnic to speakers.yml
• Resize all speakers portrait photos
• List general speakers below the keynote speakers
• Shorter speaker bios to fit in the rectangle box on large screens
• Linkify bio to add as many external links as possible (SEO food)
• Use the small screens styles for medium screens
• Fix inconsistently links in bios to the same company
File Changes
• M _data/speakers/keynote.yml (10)
• A _data/speakers/speakers.yml (120)
• M _includes/list-keynote-speaker.html (14)
• A _includes/list-speaker.html (16)
• R _sass/components/_list-speaker.scss (15)
• A assets/images/pages/home/speakers/ajey-gore.jpg (0)
• D assets/images/pages/home/speakers/ajey-gore.png (0)
• A assets/images/pages/home/speakers/anton-davydov.jpg (0)
• A assets/images/pages/home/speakers/elle-meredith.jpg (0)
• A assets/images/pages/home/speakers/enrique-mogollan.jpg (0)
• A assets/images/pages/home/speakers/gabriel-fortuna.jpg (0)
• A assets/images/pages/home/speakers/giovanni-sakti.jpg (0)
• A assets/images/pages/home/speakers/harley-davidson-karel.jpg (0)
• A assets/images/pages/home/speakers/janko-marohnic.jpg (0)
• A assets/images/pages/home/speakers/jaroslava-kosanova.jpg (0)
• A assets/images/pages/home/speakers/kazuma-furuhashi.jpg (0)
• A assets/images/pages/home/speakers/leandro-ostera.jpg (0)
• A assets/images/pages/home/speakers/melvrick-chun.jpg (0)
• A assets/images/pages/home/speakers/phil-nash.jpg (0)
• A assets/images/pages/home/speakers/piotr-murach.jpg (0)
• A assets/images/pages/home/speakers/radoslav-stankov.jpg (0)
• A assets/images/pages/home/speakers/richard-schneeman.jpg (0)
• D assets/images/pages/home/speakers/richard-schneeman.png (0)
• A assets/images/pages/home/speakers/rodrigo-urubatan.jpg (0)
• A assets/images/pages/home/speakers/saron-yitbarek.jpg (0)
• A assets/images/pages/home/speakers/sergey-dolganov.jpg (0)
• A assets/images/pages/home/speakers/shweta-kale.jpg (0)
• A assets/images/pages/home/speakers/tae-wongsrinoppakun.jpg (0)
• A assets/images/pages/home/speakers/tim-riley.jpg (0)
• D assets/images/pages/home/speakers/tim-riley.png (0)
• A assets/images/pages/home/speakers/vipul-am.jpg (0)
• A assets/images/pages/home/speakers/vishal-chandnani.jpg (0)
• M assets/stylesheets/application.scss (2)
• M index.md (2)
Patch Links:
• https://github.com/bangkokrb/rubyconfth/pull/97.patch
• https://github.com/bangkokrb/rubyconfth/pull/97.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


CIVIC logo license

What is the license of the CIVIC logo. I'm working on integrating CIVIC data into cBioPortal and would like to use the favicon for representing a CIVIC link-out in the result display. Is this covered by the MIT license and/or fair use?

Good question. Initially covering the logos under the Creative Commons license that applies to the data seemed reasonable, but we don't want the logo to be modified or re-used, either for commercial or non-commercial reasons. So now I'm thinking that we should probably cover the logos under a more restrictive license - we'll discuss at the next CIViC meeting. In the meantime, feel free to use the favicon around links or material that refers directly to CIViC.

Thanks.
Here is my humble attempt at linking between cBioPortal and CIVIC: https://github.com/cBioPortal/cbioportal/pull/1077

Perfect, that looks great! Thanks for integrating CIViC data into your application.


separate folders for client and server?

❓Question
Hi, I really fancy this project but for large scale applications I prefer to separate the client and the server inside the src folder. I can't quite get the configuration right in the razzle.config.js in order to make it work. I came across this error "Entry module not found: Error: Can't resolve 'C:\Users\Pontu\Desktop\code\TypeScript\razzle-test\src\client'". As you can see, the project is also coded in TypeScript, if that changes anything.

If you use typescript I recommend the canary release. For setting custom paths I would have to see your razzle.config.js :)
https://github.com/jaredpalmer/razzle/releases/tag/v3.2.0-canary.1

I tried having an approach like this comment suggested in another issues like mine. Please see here: https://github.com/jaredpalmer/razzle/issues/714#issuecomment-640131773. FYI: I added "typescript as a plugin aswell in my config. Other than that I have not tried anything further.

 As the client.tsx was located in src/client i had to resolve the path to src/client/client as it was not named index.tsx.. I solved it!

@fivethreeo I tried your recommendation of trying the canary release, but all I get is:
$ tsc -b && razzle build
/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:10
throw err;
^
ReferenceError: resolve is not defined
at getModules (/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/modules.js:86:24)
at /mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/createConfigAsync.js:136:27
at new Promise ()
at module.exports (/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/createConfigAsync.js:71:10)
at /mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:97:30
at new Promise ()
at build (/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:93:14)
at /mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:52:16
What might I do wrong?

More like what I did wrong :)
On Sun, 9 Aug 2020 at 16:46, Pontus Salenbo<EMAIL_ADDRESS>wrote:

@fivethreeo https://github.com/fivethreeo I tried your recommendation
of trying the canary release, but all I get is:
$ tsc -b && razzle build
/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:10
throw err;
^
ReferenceError: resolve is not defined
at getModules
(/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/modules.js:86:24)
at
/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/createConfigAsync.js:136:27
at new Promise ()
at module.exports
(/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/config/createConfigAsync.js:71:10)
at
/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:97:30
at new Promise ()
at build
(/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:93:14)
at
/mnt/c/Users/Pontu/Downloads/razzle-3.2.0-canary.1/razzle-3.2.0-canary.1/examples/with-typescript/node_modules/razzle/scripts/build.js:52:16
What might I do wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaredpalmer/razzle/issues/1374#issuecomment-671060789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAADGWNBTRZWGA6MK3ZBDLR72ZFXANCNFSM4PVQG36A
.

--
Øyvind Saltvik

Try v3.2.0-canary.2 now :)

npx create-razzle-app@canary --example with-typescript with-typescript --ignore-existing

I can confirm that the new release works. Is it possible for me to enable eslint for linting when building or is the plugin yet not released?

Not yet released, currently noone is working on it either. Not sure if eslint handles typescript properly either. So that is a no ;)

Sorted it out with an extra lint command. TSLint in deprecated so Eslint has plugin for full support of TypeScript. I have one extra question tho as I am slowly learning to razzle. I know that you use hot module reloading but I can't get it to work when using custom paths in razzle config file.  I have to manually type rs in the console each time for the server to reload, even though it outputs "server-side HMR enabled" in the console.
I use this approach for modifying entries for server and client, found from a previous issue.
`_'use strict';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const path = require('path');
const defaultOptions = {
server: null,
client: null,
};
function modifyEntryPoints(baseConfig, env, webpack, userOptions = {}) {
const options = { ...defaultOptions, ...userOptions };
const webpackConfig = { ...baseConfig };
const { client, server } = options;
/* This is required to rename the entry points instead of using the defaults */
if (env.target === 'node' && server) {
webpackConfig.entry = [server];
}
if (env.target !== 'node' && client) {
webpackConfig.entry.client = client;
}
return webpackConfig;
}
module.exports = {
plugins: [
{
func: modifyEntryPoints,
options: {
// main server file is index.ts, thus we dont need it as imports default to index files
server: path.join(__dirname, './src/server'),
// need the double client, as the main file is not named index.tsx
client: path.join(__dirname, './src/client/client'),
},
},
],
};
`

I think this breaks this part
https://github.com/jaredpalmer/razzle/blob/canary/packages/razzle/config/createConfigAsync.js#L338
Reloading in server might also be broken. But still trying to debug that.
On Sun, 9 Aug 2020 at 23:51, Pontus Salenbo<EMAIL_ADDRESS>wrote:

Sorted it out with an extra lint command. TSLint in deprecated so Eslint
has plugin for full support of TypeScript. I have one extra question tho as
I am slowly learning to razzle. I know that you use hot module reloading
but I can't get it to work when using custom paths in razzle config file. I
have to manually type rs in the console each time for the server to reload,
even though it outputs "server-side HMR enabled" in the console.
I use this approach for modifying entries for server and client, found
from a previous issue.
`_'use strict';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const path = require('path');
const defaultOptions = {
server: null,
client: null,
};
function modifyEntryPoints(baseConfig, env, webpack, userOptions = {}) {
const options = { ...defaultOptions, ...userOptions };
const webpackConfig = { ...baseConfig };
const { client, server } = options;
/* This is required to rename the entry points instead of using the
defaults */
if (env.target === 'node' && server) {
webpackConfig.entry = [server];
}
if (env.target !== 'node' && client) {
webpackConfig.entry.client = client;
}
return webpackConfig;
}
module.exports = {
plugins: [
{
func: modifyEntryPoints,
options: {
// main server file is index.ts, thus we dont need it as imports default
to index files
server: path.join(__dirname, './src/server'),
// need the double client, as the main file is not named index.tsx
client: path.join(__dirname, './src/client/client'),
},
},
],
};
`
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaredpalmer/razzle/issues/1374#issuecomment-671105233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAADGVOCB554FVC2RVXPLLR74K5RANCNFSM4PVQG36A
.

--
Øyvind Saltvik

@fivethreeo I noticed that a new version of the canary branch was available. May I ask how I setup the razzle config in order to just modify my entry paths for client and server?

https://github.com/jaredpalmer/razzle/blob/canary/packages/razzle/config/paths.js#L67
// razzle.config.js

const path = require('path');

module.exports = {
  modifyPaths(
    {
      webpackObject, // the imported webpack node module
      options: {
        pluginOptions, // the options passed to the plugin ({ name:'pluginname', options: { key: 'value'}})
        razzleOptions, // the modified options passed to Razzle in the `options` key in `razzle.config.js` (options: { key: 'value'})
      },
      paths // the default paths that will be used by Razzle.
    }) {

    paths.appServerJs = path.join(paths.appPath, 'src/server');
    paths.appServerIndexJs = path.join(paths.appPath, 'src');
    paths.appClientIndexJs = path.join(paths.appPath, 'src/server');
    return paths;
  },
}

Thank you, worked like a charm! Is HMR still broken with custom paths? Or does it require some further configuration?

Not sure that custom paths is the issue. Will be a new StartServer webpack plugin in razzle 4.0. It is in my github repo aswell so can tweak it myself if I or someone find any issues.

I am trying out your canary release 4 and encountered som problem with the newSplitChunks(?).
C:\Users\Pontu\Desktop\code\TypeScript\razzle-canary\node_modules\razzle\config\createConfigAsync.js:101
hash.update(module.libIdent({ context: dir }));
^
ReferenceError: dir is not defined.
Do you want a new issue for this error or? I cant seem to understand what's wrong. I use all experimental features. experimental: {
newBabel: true,
newContentHash: true,
newExternals: true,
newMainFields: true,
newSplitChunks: true,
},

I know whats wrong. Will fix it tomorrow :)
On Thu, 10 Sep 2020 at 23:53, Pontus Salenbo<EMAIL_ADDRESS>wrote:

I am trying out your canary release 4 and encountered som problem with the
newSplitChunks(?).
C:\Users\Pontu\Desktop\code\TypeScript\razzle-canary\node_modules\razzle\config\createConfigAsync.js:101
hash.update(module.libIdent({ context: dir }));
^
ReferenceError: dir is not defined.
Do you want a new issue for this error or? I cant seem to understand
what's wrong. I use all experimental features. experimental: {
newBabel: true,
newContentHash: true,
newExternals: true,
newMainFields: true,
newSplitChunks: true,
},
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaredpalmer/razzle/issues/1374#issuecomment-690751917,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAADGRVIPRRZBV6RWUHIELSFFDFJANCNFSM4PVQG36A
.

--
Øyvind Saltvik

@fivethreeo Update: It failed due to the @fortawesome/react-fontawesome, is that of any use?

Attempted a fix now, try canary.5 :)

I Can confirm, your fix works. However, it seems to have had an impact on build times, in both dev and production. Is that expected or shall I investigate it further?

It may be that it bundles wrong somehow, so please do :)
On Fri, 11 Sep 2020 at 21:10, Pontus Salenbo<EMAIL_ADDRESS>wrote:

I Can confirm, your fix works. However, it seems to have had an impact on
build times, in both dev and production. Is that expected or shall I
investigate it further?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaredpalmer/razzle/issues/1374#issuecomment-691266018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAADGV4M4XZWMKDRK43LR3SFJYZDANCNFSM4PVQG36A
.

--
Øyvind Saltvik

Can you figure out if it is newBabel og newExternals that slows it down?

It was none of them. The problem was my incorrect usage of plugins i razzle.config.js. I used the old way with the plugins array, instead of .modifyWebpackConfig (as output in console, totally my mistake). This combined with treeshake error in fortawesomes svg icons package caused the slow down.
When configured correct, It works like a charm and takes only a few seconds, bundle looks good! (checked with webpack-bundle-analyzer). So it's all good in the new canary.5 :)

@fivethreeo I tried migrating to v4.0.0-finch.2 and encountered some problems.
When running yarn build or yarn start:
Error: Cannot find module 'mini-css-extract-plugin'
When running yarn test
Error: Cannot find module 'razzle-dev-utils/logger'
Is seems like mini-css-extract-plugin is missing from the  package.json file. For the test I noticed that the logger is a peerDep, so I tried running npx install-peerdeps<EMAIL_ADDRESS>but encountered further problems.
TypeError: Cannot read property 'getVersion' of undefined
at Object. (C:\Users\Pontu\Desktop\code\TypeScript\razzle-canary\node_modules\razzle\config\createJestConfig.js:7:48).
Is there anything further that I can try in order to provide you/the team all information needed? Maybe move it to another issue as this issue is not really related to my original issue.

mini-css-extract-plugin is now a peer dep aswell so you have to provide it
did a new release finch.3 now to fix the other issue :)

The original issue is solved. Just open new issues as they crop up 😀

By the way do you have your bundle analyzer setup for razzle? I would like to make it a razzle plugin.

I did not do any specific configuration for this issue. I just pushed an instance of the Webpack-bundle-analyzer into the webpackconfig.plugins.


reconcile does not work on objects

Hello, thank you for your package in solid.
when I try to update a state with objects the reactivity is lost. if you leave the setState normal this works..
if you are in the discord you can verify the error.
https://discord.com/channels/722131463138705510/722349143024205824/812487789525598218
thx :)!

@aguilera51284 Hi, thanks for your interest.
Unfortunately, I don't have Discord account so please provide information from the URL into this issue.


Bug: Hash is sporadically invalidated

Current behaviour
When building an external sprite with webpack, the hash of the sprite-chunk is sometimes invalidated (changes) without the source files (the svgs) having been modified.
Expected Behaviour
When building an external sprite with webpack, the hash of the sprite-chunk should never be invalidated (change) without the source files (the svgs) having been modified.
Demo
A simplified demo can be found at wanecek/svg-sprite-loader-hash-invalidation
Environment

Node.js version: 8.5.0
webpack version: 3.8.1
svg-sprite-loader version: 3.4.0
OS type & version: macOS Sierra 10.12.6

Other information
I've found that importing less than 6 symbols seriously diminishes the rate at which chunks are invalidated, but does however not completely dispell the issue. To try this, comment out one (or more) of the imports in src/main.js.

This bug baffles me. If you need help in debugging, please do not hesitate to ask; however, I'm not sure where I'd begin...

@wanecek thanks a lot for reporting! Fix shipped with v3.4.1

Neat! Thank you for the quick fix @kisenka!


benchmarking and testing scripts for squiggle-lang

(copy-pasting the README from the diff for reference; I've been using these to help with #1119, and it's useful to have them in develop branch too)
Various scripts used for development, benchmarking and testing.
None of these are bundled in the NPM package yet.
run.mjs
scripts/run.mjs allows quick testing of Squiggle programs:
$ ./scripts/run.js '2+2'
Running 2+2
Ok 4
@{__result__: 4}

run-file.mjs
scripts/run-file.mjs can be used to run and benchmark squiggle scripts stored in files:
$ ./scripts/run-file.mjs ./path/to/file.squiggle
Time: 3.18 Ok

To see the result and bindings, add the -o or --output flag.

Note: there's some copy-pasting going on, e.g. with measure function, but it shouldn't be important, none of this is mission-critical.
I didn't want to spend too much time figuring out the infrastructure (should I write these in Rescript? in Typescript? how to organize common code? etc.)

Codecov Report

Merging #1140 (a78797b) into develop (4c0b5e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1140   +/-   ##
========================================
  Coverage    59.44%   59.44%
========================================
  Files           98       98
  Lines         4502     4503    +1
========================================
+ Hits          2676     2677    +1
  Misses        1826     1826

Impacted Files
Coverage Δ

...butions/SampleSetDist/SampleSetDist_ToPointSet.res
94.28% <100.00%> (+0.16%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Yeah, I wrote these scripts for my own use initially, before I realized that they are useful in general and shoult be commited.
Will do more cleanups later (and hope to bundle and merge with cli-experimental at some point).

(Once I approve, feel free to merge when you feel is appropriate)