How to use nilaway for a Golang project involved conditional compilation?

I tried running nilaway cmd for our internal project, but it failed with the following error
internal/app/xxx/domain/task.go:244:18: undefined: settings.XXXXX

settings.XXXXX is indeed defined in a source file with "//go:build $flagname" statement declared at the first line
The golangci-lint has the build-flag option while nilaway's analyzer deprecated it
user% ./nilaway --help
nilaway: Run NilAway on this package to report any possible flows of nil values to erroneous sites that our system can detect

Usage: nilaway [-flag] [package]

Flags:
  -V	print version and exit
  -all
    	no effect (deprecated)
  -c int
    	display offending line with this many lines of context (default -1)
  -cpuprofile string
    	write CPU profile to this file
  -debug string
    	debug flags, any subset of "fpstv"
  -exclude-errors-in-files string
    	A comma-separated list of file prefixes to exclude from error reporting. This takes precedence over include-errors-in-files.
  -exclude-file-docstrings value
    	Comma-separated list of docstrings to exclude from analysis
  -exclude-pkgs value
    	Comma-separated list of packages to exclude from analysis
  -fix
    	apply all suggested fixes
  -flags
    	print analyzer flags in JSON
  -include-errors-in-files string
    	A comma-separated list of file prefixes to report errors, default is current working directory. (default "/Users/tiger/Downloads/working/nilaway")
  -include-pkgs value
    	Comma-separated list of packages to analyze
  -json
    	emit JSON output
  -memprofile string
    	write memory profile to this file
  -pretty-print value
    	Pretty print the error messages
  -source
    	no effect (deprecated)
  -tags string
    	no effect (deprecated)
  -test
    	indicates whether test files should be analyzed, too (default true)
  -trace string
    	write trace log to this file
  -v	no effect (deprecated)

Any suggestion for this issue? Thanks~

We are using the singlechecker package from x/tools package: https://pkg.go.dev/golang.org/x/tools/go/analysis/singlechecker, and the flags you see there are not directly related to NilAway (populated by the singlechecker linter driver).
Here it seems that the singlechecker does not have proper support for build tags and we have very little control over that since singlechecker takes the entire main function entry away and handles the package loading logic (other than writing our own linter driver of course). There has been https://github.com/golang/go/issues/61324 that tries to implement an importable checker driver API, which would provide some flexibilities to configure the package loader. We are waiting for that to be available.
In the meantime, we can also hack around to see if it's possible to fix this (feel free to do so yourself and send a PR 😃 ). I'm keeping this issue open to track this.


cmake: Allow overriding flags in compiler/linker flag checks

The APPEND_{CPP,C,CXX,LD}FLAGS flags are now considered when checking compiler/linker flags.
Fixes https://github.com/hebasto/bitcoin/issues/279.

Reading https://cmake.org/cmake/help/latest/variable/CMAKE_TRY_COMPILE_PLATFORM_VARIABLES.html, one of the first things it says is:

This variable should not be set by project code. It is meant to be set by CMake's platform information modules for the current toolchain, or by a toolchain file when used with CMAKE_TOOLCHAIN_FILE.

So I think this needs some documentation, or an explanation of what it's doing.

Reading https://cmake.org/cmake/help/latest/variable/CMAKE_TRY_COMPILE_PLATFORM_VARIABLES.html, one of the first things it says is:

This variable should not be set by project code. It is meant to be set by CMake's platform information modules for the current toolchain, or by a toolchain file when used with CMAKE_TOOLCHAIN_FILE.

So I think this needs some documentation, or an explanation of what it's doing.

All CMake checks are implemented using the try_compile() command, which internally creates a tiny temporary test project. This PR applies to that test project the same approach as has been used since https://github.com/hebasto/bitcoin/pull/184.
Setting the non-cache CMAKE_TRY_COMPILE_PLATFORM_VARIABLES variable before the project() command ensures that it will be available in all contexts mentioned in https://cmake.org/cmake/help/latest/variable/CMAKE_TRY_COMPILE_PLATFORM_VARIABLES.html. In that case, I can't see any drawbacks to not following "This variable should not be set by project code." statement.

The APPEND_{CPP,C,CXX,LD}FLAGS flags are now considered

Note that this also isn't just append flags. DCMAKE_CXX_FLAGS_RELEASE weren't being included either.

Note that this also isn't just append flags. DCMAKE_CXX_FLAGS_RELEASE weren't being included either.

Testing this branch it seems like they are also still being ignored? The test case from https://github.com/hebasto/bitcoin/issues/279 is still broken.

Note that this also isn't just append flags. DCMAKE_CXX_FLAGS_RELEASE weren't being included either.

Testing this branch it seems like they are also still being ignored? The test case from #279 is still broken.

It is possible to override only using APPEND_* flags.

An explaining comment has been added per @fanquake's offline request.

I've been playing with this all day and it's.. a mess.
From my tests I don't see a better way to get the flags appended, so utACK that I guess :(
For @fanquake's complaint, it seems this is our problem: https://gitlab.kitware.com/cmake/cmake/-/issues/19512
I'm able to get build_type flags into the try_compiles by moving the default build type selection up and setting CMAKE_TRY_COMPILE_CONFIGURATION:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index fe6eab74f01..27e96e5b278 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -73,6 +73,10 @@ set(CMAKE_CXX_EXTENSIONS OFF)

 list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake/module)

+include(ProcessConfigurations)
+set_default_config(RelWithDebInfo)
+set (CMAKE_TRY_COMPILE_CONFIGURATION ${CMAKE_BUILD_TYPE})
+
 #=============================
 # Configurable options
 #=============================
@@ -457,9 +461,6 @@ else()
   )
 endif()

-include(ProcessConfigurations)
-set_default_config(RelWithDebInfo)
-
 # Redefine/adjust per-configuration flags.
 target_compile_definitions(core_interface_debug INTERFACE
   DEBUG

@hebasto Mind having a look at that? Maybe it'd make sense to set that flag as part of set_default_config instead? Either way, it seems it's necessary to move the default selection up towards the beginning of the file.


Get current process window failed when enumeration window in thread_.

hey @chifandeyu, Thanks for your contribution, can you explain under what circumstances the thread error occurs?

@cloudwebrtc After debugging webrtc. I found the function "GetWindowListHandle" call "IsWindowResponding(hwnd)" return false. set "uTimeoutMs = 3000"  will still timeout and return false.I haven't found any detailed information for the specific reasons.

hey @chifandeyu, Thanks for your contribution, can you explain under what circumstances the thread error occurs?

I found the problem when the worker thread tries to SendMessageTimeout to check Is window responding but now the main thread is waiting and the main thread is blocking.


Issues trying to run tests locally

I'm having issues trying to run tests locally. I followed all the steps described here:
http://sorl-thumbnail.readthedocs.org/en/latest/contributing.html#running-testsuit
But I kept receiving errors like the following when running tox:
ERROR collecting tests/thumbnail_tests/test_templatetags.py

import file mismatch:
imported module 'tests.thumbnail_tests.test_templatetags' has this __file__ attribute:
  /Users/caio/Projects/sorl-thumbnail/tests/thumbnail_tests/test_templatetags.py
which is not the same as the test file we want to collect:
  /vagrant/tests/thumbnail_tests/test_templatetags.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules

Am I missing something?
Thanks

pycache folders and the pyc firles were probably be generated by your host instead of the vagrant machine, or other wise, so there is probably a permission issue.
Either delete those files, or run and develop just in your in host or inside the vagrant vm so you make sure those files are always related to the environment

@mariocesar it worked, thanks.
For future references, this is what I did in the host machine:
find . -name "*.pyc" -delete
find . -name __pycache__ -type d -delete


OSERDESE2 and ISERDESE2 primitives testing

Data serialisation/de-serialisation process need to be tested with Xilinx primitives. There are no ready ip cores with these primitives. Firstly, two ip cores will be created and instantiated as illustrated in document.pdf
Test performing:
Sending data from Linux mmap() application to the base_addr of axi_gpio_0 ip core. It keeps the data and takes it out to SDIO port. SDIO and SDIO2 are 5-wires ports. The data is serialised through OSERDESE2_0 primitive into 1-wire. Artix-7 reverts data back to ISERDESE2_0 where it de-serialised into parallel 5-wires. The data is delivered back to axi_gpio_0 ip core via GPIO2 port. If initial data will the same as data in base_addr+8 the test may be considered successful.
Test includes options:

DDR mode
SDR mode
100MHz clock (the same as input)
200MHz clock
300MHz clock

IP cores are pushed into liquid-router repository 27a0c637d510cbac971cb898140179be403717d0
Test passed successfully in following parameters:

Serialisation rate 8:1, High speed clock 50MHz; SDR mode
Serialisation rate 8:1, High speed clock 100MHz; DDR mode

Serialisation rate 8:1, High speed clock 200MHz; DDR mode. Passed

Zynq PL Fabric clock configuration has a limitation in 250 MHz. In order to test on frequency 300MHz it requires to use PLLE2_BASE, PLLE2_ADV or  MMCME2_BASE, MMCME2_ADV clock managers. These managers has a lot of configuration settings and I'm going to dedicate separate issue for that.


Error in beforeCreate hook: "TypeError: Cannot read property 'defaultOptions' of undefined"

I get this error when I include "Vue.use(VueApollo)" in my main.js
my apollo.js:
import Vue from "vue"
import VueApollo from "vue-apollo"
import { ApolloClient, createBatchingNetworkInterface } from "apollo-client"

Vue.use(VueApollo);

const apolloClient = new ApolloClient({
    networkInterface: createBatchingNetworkInterface({
        uri: "http://localhost:1234/graphql"
    }),
    connectToDevTools: true
});

let apollo = new VueApollo({
    defaultClient: apolloClient
});

export default apollo

my main.js:
import Vue from "vue"
import App from "components/app"
import axios from "axios"
import router from "./router"
import apollo from "./apollo"

Vue.prototype.$http = axios;

const app = new Vue({
    router,
    apollo,
    ...App
});

export {
    app,
    apollo,
    router
}

What am I doing wrong?
Notes:
I am using the latest version of all packages.
I already tried cleaning npm cache and reinstalling everything.

It should be apolloProvider:
const app = new Vue({
    router,
    apolloProvider: apollo,
    ...App
});

I am having the same issue, provider: apollo does not solve it


added popcorn-time cask

url is https://popcorntime.io/
tested locally
brew cask audit popcorn-time --download ==> passed

See #3582, and many others.


Esformatter --config

Hi,
how do I pass in another esformatter config file ?
From the command line I'd normally do esformatter --config customconfig.json
Cheers,
Stephen.

FYI esformatter will try to look for a config file and/or package.json
relative to your pwd
http://vim.wikia.com/wiki/Set_working_directory_to_the_current_file
Right now there is no way to pass custom args to the Vim plugin, but Pull
Requests are greatly appreciated ;)


cannot open oracle connections via SSH tunnel

Description
I use tunneled connections for Oracle, and I'm receiving `Cannot invoke "String.length()" because "input" is null

DBeaver Version
Community Edition <IP_ADDRESS>405191503
Operating System
macOS Sonoma 14.5
Database and driver
DB: Oracle Exadata 19.c
Driver: oracle.jdbc.OracleDriver

com.oracle.database.jdbc:ojdbc11:RELEASE [<IP_ADDRESS>]
com.oracle.database.nls.orai18n:RELEASE [<IP_ADDRESS>]
com.oracle.database.xml.xdb6:RELEASE [<IP_ADDRESS>]
com.oracle.database.xmlparerv2:RELEASE [<IP_ADDRESS>]

Steps to reproduce
No response
Additional context
SSH tunneling using JSch.

"Test tunnel configuration" returns success
dbeaver-debug.log

It looks like during an upgrade, the "save credentials" box got checked.  If I uncheck the box, the error goes away, which says to me the thing it's trying to run String.length() against is the saved password that I haven't provided.

Seems like unchecking "save credentials" was a one time fix (for each connection).  The error re-appears intermittently with subsequent application sessions.

Thank you for the bug report.
Perhaps you have exact steps required to reproduce the issue? Are you using TNS/Custom connection type?

Perhaps you have exact steps required to reproduce the issue? Are you using TNS/Custom connection type?

Basic setup
My oracle connections are set up using ldap based DSN, e.g.
jdbc:oracle:thin:@ldap://oidprd1-ora.example.edu:3060/mydatadev,cn=OracleContext,dc=example,dc=edu

authentication is set to "Oracle Database Native", with the credentials (username and password) stored.
No changes to Oracle Properties or Driver Properties.
On the SSH tab, the hostname is set to a server that has permission to access the tablespace.
I specify the username, but not the password.  I leave "save credentials" unchecked.  I do not modify anything under "Jump Servers" or "Advanced Settings", although the "Share this tunnel with other connections" box is checked.
replicate the issue?
I double click on the connection name, and am prompted with "Specify password for SSH tunnel".  The username is pre-filled and I supply the password.  I leave "Save password/passphrase" unchecked.  I get prompted for 2fa (Duo), which I supply.
and then, maybe I get, and maybe I get the error Cannot invoke "String.length()" because "input" is null
My initial investigation seemed to support that at some point the "save credentials" checkbox under the SSH tab in the connection details became checked, and I could fix it by unchecking it... but subsequent tries have been hit-and-miss.  I seem to be able to get it working again (briefly) if I change the host that I'm tunneling through.
dbeaver-debug.log.txt

Please try this version and let me know if it helps: https://dbeaver.io/files/ea/

@lhoekenga did you have a chance to test the new version? https://github.com/dbeaver/dbeaver/issues/33849#issuecomment-2129747750

@lhoekenga did you have a chance to test the new version? #33849 (comment)

Not yet.  I'll pull it down and try.

It seems to be better.  I was not able to replicate the issue.

@lhoekenga Thank you for testing!


Takes padding and border into account for content size calculations

This fixes an issue where you would get a vertical scrollbar if your viewport has less height then the image.
You can see it for yourself : jsfiddle.net/aoejbz8s/9/ just adjust the viewport so it is smaller then the image.
As stated in https://github.com/noelboss/featherlight/issues/43 after it was closed, the calculation for big images was still missing the inclusion of padding+border
This issue is also discussed here : https://stackoverflow.com/questions/32148937/featherlight-js-large-images-still-scrolling

This looks promising.
Is it possible the padding is not taken into account correctly though? It should probably be taken into account into the calculation of w and h, no?

I don't think the padding should affect w and h during the calculation, since the padding should always be the same and not be affected by the ratio calculations. The padding shouldn't change when the image gets smaller , i think ?

You're right, not in w and h. But they should matter for the "available" width and height for the image (i.e. parseInt(this.$content.parent().css('width'),10)), and thus in ratio.

Thanks to your comments, I think I found a way cleaner solution, check my new commit.
WithparseInt(this.$content.parent().css('width'),10) the margin and border was included in the ratio calculation, so the calculated ratio made the content bigger than it actually could be, resulting in the showing of a scrollbar. With changing this to this.$content.parent().width() , margin is not included in the ratio calculations.

@marcandre could you take another look at this ?

This fix works for me. Seems to behave naturally and the result handles live resizing, which I don't consider a necessity.

Sorry for the delay, I'm traveling. Merged and released, thanks!


Tencent WeChat API App ID

Description
Please include a summary of the change and which is fixed.

Add pattern Tencent WeChat API App ID

How has this been tested?
Please describe the tests that you ran to verify your changes.

[x] UnitTest
[ ] Benchmark

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.06%. Comparing base (8682ea7) to head (e2a48c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   91.06%   91.06%
=======================================
  Files         146      146
  Lines        4972     4972
  Branches      805      805
=======================================
  Hits         4528     4528
  Misses        290      290
  Partials      154      154

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Hires Fix

There are still some things that can be added, but this is able to do a basic second pass.

Thank you for the PR. Lets test out the next exe to see how it works.


Home screen widget

Maybe notification summary? Like notifications per repo? Idk.

Hijacking: was also thinking about quick actions from the home screen, eg. immediately opening search + search bar

I also saw you on Twitter a couple weeks ago mentioning repo health, could be cool to have that as a widget to see like any new issues, prs, etc?

+1 for repo health, bus factor, notifications per bookmarked repo

Maybe needs it’s own card but home screen widget is just a minified today widget, so could then expand it and have it breakdown by top 3 repos or something - depends on deep linking capabilities though but would be a powerful alternative to opening app fully.
Rate limits tho? Do we have any tracking on how the limits are doing in a given period?
Sent with GitHawk

@@@
Sent with GitHawk


Generating Postgres Schema fails

When I use the generate_postgres_schema method as explained in the README I receive the following error from the API:
Traceback (most recent call last):
  File "/home/rishabhsriv/fsd-research/similar-vector-app/./app.py", line 204, in get_postgres_schema_gsheets
    temp_df = pd.read_csv(StringIO(csv))
  File "/home/rishabhsriv/.local/lib/python3.8/site-packages/pandas/util/_decorators.py", line 311, in wrapper
    return func(*args, **kwargs)
  File "/home/rishabhsriv/.local/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 586, in read_csv
    return _read(filepath_or_buffer, kwds)
  File "/home/rishabhsriv/.local/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 488, in _read
    return parser.read(nrows)
  File "/home/rishabhsriv/.local/lib/python3.8/site-packages/pandas/io/parsers/readers.py", line 1047, in read
    index, columns, col_dict = self._engine.read(nrows)
  File "/home/rishabhsriv/.local/lib/python3.8/site-packages/pandas/io/parsers/c_parser_wrapper.py", line 223, in read
    chunks = self._reader.read_low_memory(nrows)
  File "pandas/_libs/parsers.pyx", line 801, in pandas._libs.parsers.TextReader.read_low_memory
  File "pandas/_libs/parsers.pyx", line 857, in pandas._libs.parsers.TextReader._read_rows
  File "pandas/_libs/parsers.pyx", line 843, in pandas._libs.parsers.TextReader._tokenize_rows
  File "pandas/_libs/parsers.pyx", line 1925, in pandas._libs.parsers.raise_parser_error
pandas.errors.ParserError: Error tokenizing data. C error: Expected 3 fields in line 7, saw 5

I simply used the function, without doing anything else to the schema objects sent to the API.
Some particularities in my database:

I exported 16 tables all linked with foreign keys among them
I have some user defined columns
I am using a lot of different postgres types such as: JSON, JSONB, ARRAY, DATE, etc.

P.S.: It's the same schema I sent over email yesterday

Thank you for the bug report @damianr13! We're working on fixing this. It is being caused because there are more words in the generated schema than our system was tested with. We have some ideas of how to fix this – will do that in the next 2 days!

We have partially fixed this issue – full fix coming in another 2 hours or so.

Hi there! I think the issue is fixed. We are able to generate queries from your schema right now – though the quality might not be very high because we have not made any changes to the auto-generated metadata. Please do give it a shot and let us know? :)
>>> r = requests.post(url, json={
...   "question": "what are 10 products that are available and have the highest average ratings?",
...   "api_key": api_key,
...   "db_type": "postgres"
... })
>>> print(r.json()['query_generated'])

SELECT bp.name, bp.url, AVG(rp.review_average) AS avg_rating
FROM brand_product bp
JOIN retailer_product rp ON bp.id = rp.brand_product_id
WHERE rp.availability = 'available'
GROUP BY bp.name, bp.url
ORDER BY avg_rating DESC
LIMIT 10;
>>>

Query quality will improve significantly with better metadata definition. We will make further improvements in the near future too – like being able to define what a table is for etc.
Thanks for the bug report again! Would love to get your feedback and will fix any issue as soon as we can.


Feature request: Allow for remote Push server

Hi all,
I am really liking the work you did in this library. However it does not allow to implement my scenario. I want to be able to create a separate meteor server for only sending push notifications.
This is the scenario I would like to achieve.

However, in this file, there are several calls done as Meteor.call, which will always use the server assiciated to the client.
This forces me to implement it as this:

The stuff marked in red is what is wrong with the current setup.
Would it be possible to allow the client to configure a Connection which can be used for registering on instead of always using the Meteor.call.

you can set the client appCollection and notificationsCollections on the client to use a different ddp connection? Or you can have the two apps share the appCollection and notification collection - only adding the push package client-side on one and server-side on the other

Thanks for you suggestions, but I think the problem that I'm faced with is of a different nature. Let me clarify:
As far as I understand the internals of the push package, the client app is registering its token at the push server by invoking meteor methods (e.g. Meteor.call('raix:push-update') in here). However, Meteor#call always uses the default DDP connection to the server of its application. What I would like to accomplish is that multiple client apps reuse the same push server. Thus, they would need to register at a different server than the server which is invoked by Meteor.call(...). Is there any way I can configure this?


boards: arm: max32655evkit: Add JLink support

Adds JLink as an optional runner, which can be selected with west via --runner jlink.
OpenOCD is left as the default runner for debug and flash.

Will this be added somewhere else? I think it's a useful addition to support the faster, and very common J-Link.

Its look good feature, please send PR to the inner source,
We decided to deleted public branches. These PR been closed due to the branch has bee deleted.


This pull request Implements the method mockCalc_ValueFromCSV

CSV Interface library has been added to process data from CSV files. Some hot patches have been made to the original code base provided at https://github.com/ws-garcia/VBA-CSV-interface.

Hi @ws-garcia,
Thanks a bunch for the PR!
Just noticed there were no changes to src/mockMain.bas I assume these were just added to the xlsm but not to the file system?

So, yes. All the changes was made in the xlsm file

I'll fix and merge :)

I'll fix and merge :)

Hi @sancarn, fixed now! Also the syntax of the previous method was improved a bit, it seemed redundant.


[User Story] UUID mapper

[User Story]
UUID mapper

Epic Title
#333

User Story Title
UUID mapper

T-shirt size: S(mall), M(edium), L(arge)
M

User Story
A user that exists in AD should also be able to exist in AAD without creating a duplicate user record, to support companies who may migrate from AD to AAD or otherwise utilize multiple identity providers and identity provider migrations.

Description
Maps multiple UUIDs from providers or other sources to the UUID used by NEXT.

Acceptance Criteria/Tests

a relic of a design meeting that we are rejecting now.


Update palette

Updates palette to latest version.
See https://github.com/artsy/palette/pull/109/files for the associated PR on palette.
#trivial

Fails

:no_entry_sign:

No CHANGELOG added.

Warnings

:warning:

This PR comes from a fork, and won't get JS generated for QA testing this PR inside the Emission Example app.

  Generated by :no_entry_sign: dangerJS

merge on green


Design a best practice for putting "change #" in an output filename

Paraphrased from #291
We have rules internally in vmware that put "change numbers" in file names. Some observations from experience

this is error prone on CI systems that do incremental builds. Changing file names will cause files to accumulate over time, filling up disk space.
if some piece of CI does not know the parameter passed into the build it may have to heuristically choose the "latest" file found with a glob. Which make me :( .

We have been batting around the idea of "pkg_install" that would produce an "install script" that would copy (or link) from bazel-out file locations derived from targets to a directory outside of bazel-out, renaming as it goes. Ideally the pkg_install script would be the only place that would need to know about command line parameters that change file names and we would not need this capability on all of the pkg_* rules.
@mzeren-vmw @nacl

What we do at Google separates the concerns of continuous testing vs. integration.  We specify a package as
pkg_rpm(name="foo", version="@DATE@", release="@CHANGE@", ...)

and let the continuous test system build with the strange names. We don't fill up cache with new names all the time. If a user builds locally, they see @DATE@ rather than a real date. We don't let users create valid releases (or release candidates) from code that is not checked in, so we don't need the local build or test systems to produce high quality package names.
releases are more intentional. The release system

lets the user specify the change to build from
injects the date and change # into the build environment
asks a secure build system to build and sign the release from checked in code.

This split also avoids the fragility you describe about some piece of CI not knowing what to do. We can write multi-binary integration tests that simply refer to components as  foo-@DATE@-@CHANGE@ and they will get what was just built for the test. We don't have to go through each test to be able to parameterize the names of binaries our test harness runs.

When we get around to this, we might consider if package_file_name expansion could support a default, like a shell escape.  So
package_file_name = "foo-${COMMIT-head}"

What people might really want is a conditional, so that the file name is either "foo" or "foo-PR. Something like
package_file_name = "foo-$(if COMMIT -${COMMIT})

I would be very resistant to adding that complexity.  If people want that, they could make the COMMIT variable being with a '-', and do package_file_name="foo${COMMIT}"


Update link to Github

Link points to docusaurus instead of FVM.

@all-contributors add @rhalff for doc


Update readme

Status
Type
⚠ Core Change
Issue

Ready
Tooling
No
Closes #35

Problem
What problem are you trying to solve?
Readme updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 49.106%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1242

Relevant Lines:
2480

💛  - Coveralls


Integrating Do Not Sell with an existing ad blocker

One additional thought. Maybe, it is worthwhile to take a close look at how ad block browser extensions (e.g., uBlock origin) work. In principle, most ad blockers (1) filter out HTTP requests for ads based on blocking lists (e.g., EasyList) and (2), if ad requests make it through, identify and remove ads in the browser via dimensions of an image and other heuristics. This second aspect is not important in our context, but perhaps we can learn something from the first.
Originally posted by @SebastianZimmeck in https://github.com/privacy-tech-lab/privacy-rights-platform-browser-extension/issues/9#issuecomment-624744919

One idea we discussed today is to package our extension in a library and make it easily accessible to ad blockers and others interested via an API. As this work would likely require quite a bit of restructuring and refactoring of code, we should make sure that there is really interest before going through all the effort, though.

On other thought on this is also to implement our own ad blocker. If a site accepts the GPC signal allow ads, otherwise block.

Closing this issue for now but we can re-open it later if we decide to go that route.

Closing this issue for now but we can re-open it later if we decide to go that route.


Add #[diagnostic]

https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html

#[diagnostic::on_unimplemented] was already added to IntoHandler, but idk where else it would be useful.

#[diagnostic::on_unimplemented] was already added to IntoHandler, but idk where else it would be useful.

ah I did not notice this. Let me look and see if I think it would be useful anywhere.


Add shflags library version to CI maintenance docs

Document that the shflags library version used by Shipyard's shared
scripts must be updated. This will make maintenance more consistent.
Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

@dfarrell07 can you please fix the conflict


Unnecessary logic double-checks whether user has roles, creates extra ma...

...p object, loses order. Changed to use a single LinkedHashMap to preserve order, simplified logic to only do the 'contains' check one time for each role.

Thanks for your contribution @jstell !
Nice refactoring :)
Would you have time to resolve conflicts and provide a test?

Haha! That pull request is over 5 years old! I'm not sure I remember what I was doing that long ago.

No problem @jstell .  I completely understand.
I like the refactoring and will keep this PR open until I have some time to recreate it without conflicts and with a test.
Thank-you! ✨

Closing.  This has been reimplemented in PR #80 and documented in issue #79


Build(deps-dev): Bump @types/node from 17.0.26 to 17.0.29 (#3400)

Pull request opened by the merge tool on behalf of #3400

Merged in eea9eb36dcf0543a6cc3a697aa8494d86a882346


feat: add observability plugin system

Description
See #203 for background; summary of that issue is that we'd like to have a somewhat more abstracted plugin system for observability/tracing so that we can have our own house-built telemetry plugin. I ultimately opted for the relatively lightweight option of just copying Langfuse's API for this PR; I wasn't confident enough in a refactor that was any more different.
In particular, the substantive changes made here are:

Creates an "observer" plugin system modeled off the existing plugin systems in this repo
That includes talking with profiles.yaml, pyproject-based entrypoint discovery for plugins, etc.
Pulling out the langfuse's integration observe_wrapper decorator into a method that calls all registered observers
Mostly moves current langfuse_wrapper.py code into observers/langfuse.py; I didn't really touch the code in there much. Also makes that plugin a default
Review commit-by-commit for the logical flow here.

Testing

I wrote a few unit tests. I checked that both goosewide and exchange tests all passed locally.

I also did some manual testing, with a couple minor hacks to get around not actually being able to test fully end-to-end with Langfuse (the environment I'm using didn't make that easy+fast so I just did this instead).

With the following temporary patches on top of this branch:

disabling actually authenticating Langfuse

and instead just logging to a file for visibility
, as well as this profile:

we can see that Goose runs correctly, with startup messages showing that it's correctly (trying to) initialize the Langfuse client:

and we correctly log method calls.

Without the --tracing flag, goose runs without errors as expected:

nice - looks good to me cc @ahau-square

I'm getting some different behavior in this for the langfuse tracing - seems like my traces are no longer registering to the same session. Have to dig in more to see why

Hey @ajgray-stripe
Nice work! Codes are clean and easy to read. Thank you!
I had the same issue with @ahau-square. I had a look, it seems to be related to this code
@wraps(fn)
                def wrapped_fn(*fargs, **fkwargs) -> Callable:  # noqa: ANN002, ANN003
                    # group all traces under the same session
                    if fn.__name__ == "reply":
                        langfuse_context.update_current_trace(session_id=fargs[0].name)

                    return langfuse_context.observe(*args, **kwargs)(fn)(*fargs, **fkwargs)

                return wrapped_fn

It seems that the langfuse_context.update_current_trace needs to be called within the observe context. Doc
I tried to fix it and created a temp draft PR with the fix and it seems to work https://github.com/block/goose/pull/238.

Thanks for the patches, @lifeizhou-ap -- incorporated those here! (and managed to get langfuse running locally, so confirmed that I see traces there with those changes)


⚠ Bofrost.lu has degraded performance

In 6363422, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2241 ms

Resolved: Bofrost.lu performance has improved in cafa58a after 6 minutes.


Does this broker have a /.well-known/openid-configuration end point?

I installed the demo, and I can log in from the app. But what I really want to do is integrate with several 3rd party sites that connect over OIDC to our Cognito instance as the user pool provider. Currently the only way to use Cognito as an OIDC provider is to go through the Cognito Hosted UI, which is not acceptable for one of the apps (magento - ecommerce). It's not very user friendly.
My hope was that I could plug this in as the OIDC provider instead. But it doesn't seem to have a /.well-known/openid-configuration end point, only /.well-known/jwks.json. All the 3rd party plugins I know of require a .well-known/openid-configuration file to work.
Am I missing something?

Hi @uclaeamsavino , news regarding this issue? We are also facing this problem. Our idea is to create a new lambda for the .well-known/openid-configuration endpoint, but the configuration file should contain something that makes sense and we are struggling to understand what it should contain and why it is not already exposed/made available by default.

No, I think they just didn't implement it, and it seems like they're done with this project.
Here's the spec on the .well_known file: https://openid.net/specs/openid-connect-discovery-1_0.html
Here's an example from AWS Cognito: https://cognito-idp.us-west-2.amazonaws.com/us-west-2_cbitCudrT/.well-known/openid-configuration


Feature/admin dashboard - header, sidebar-nav and footer added

Description:

Update and create new header elements
Created new side-bar navigation
Created footer

[X ] My changes generate new warnings:
Warning: Encountered two children with the same key, link. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
Fixes

What work was done?
The admin dashboard contains AntD components to be consistent with the application.
Why was this work done?
produce a better design on the admin dashboard.
What feature / user story is it for?
Admin/dashboard
Any relevant links or images / screenshots
Trello card link: [(https://trello.com/c/Npb2pDTY)]

Type of change
Please delete options that are not relevant.

[ x] New feature (non-breaking change which adds functionality)

Change Status

[ x] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[ x] Yes

Checklist

[ x] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

The Bug/Error issue noted above has been fixed and the branch updated.
The error was given for duplicate "keys" in the sidebar nav menu.

Very clean sidebar and footer!


nxengine: init at <IP_ADDRESS>

Motivation for this change
Add a game.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

So far, I've done:
nix-env -i nxengine
to install it, then started a new game and played a bit.  For some reason, the music seems to be going fast, but that's the only issue I've encountered.  (So, only a cosmetic bug.  It is still fully playable, and the game itself is at the right speed.)
I see that the instructions say there should be a maintainer, but I don't know what to put there.
Note that the game has 2 parts:
the engine, which is opensource
the data, which is freeware and obtained separately
This package only has the engine.  So, it is not playable by itself.

@GrahamcOfBorg build nxengine

Fails for me after installation with:

Yes.  This is intentional as written.  I looked around to see what other tools do.  I found archlinux does this:
https://aur.archlinux.org/cgit/aur.git/tree/nxengine.sh?h=nxengine
So, there's a wrapper script.  It downloads the freeware game, then sets up a directory, and cd's into there.  That way, it will be able to find all of its files, and will be sanely laid out.
I'm also not sure how mixing in the freeware would work legally.
So, I took the more conservative approach.
I can set it up with a script like that one, if so desired.  Then, it would start the game right away, which is convenient.
Please tell me your preference.

@scubed2 I think it would be nice to have this working out of box. So a kind of script/wrapper to do that, plus moving the package to unfree if required.

It wasn't immediately obviously to me where to get the data from when looking at the homepage. Is the data unfree and not redistributable?

Okay, the package should be completely working now.
mmahut:

the game assets are now included in share
the license is changed to be gpl3, unfreeRedistributable to account for having the assets
instead of a wrapper, I sed $out into the binary

the assets are released with the binary version, so this seems reasonable to me

music plays at the correct speed

aanderse:
The game assets are redistributable.
https://www.cavestory.org/forums/threads/cave-story-freeware-license.13817/
Note that this is Cave Story, not to be confused with Cave Story+, which is fully proprietary and non-redistributable.

For reference, the patches have been sent as:
https://github.com/nxengine/nxengine-evo/pull/150
https://github.com/nxengine/nxengine-evo/pull/151

@scubed2 I see your changes have been merged upstream. Great work!
Please fetch the patches from upstream so we don't need to maintain them in NixOS.

I've downloaded the patches from upstream and put them into pixtone.patch.  So, now it matches.
Either way, the patches wouldn't need to be maintained, since the next release would make both patches obsolete.
I also recompiled and ran it for a few minutes to sanity check.

@scubed2 I was referring to using fetchpatch so we directly reference the patch upstream instead of keeping a local copy in nixpkgs. If you want to update your PR to use fetchpatch we can merge now, or if there is no rush just wait for the next release and update.

I've changed it to use fetchpatch from the github commits of the upstream changes.  So, hopefully it should be good now.
For my own curiosity, how different is it to have the patch locally vs. using fetchpatch?

I've switched to using nativeBuildInputs.  It still builds and runs.
The pxt files are the sound effects.  If some are missing, then it just won't play that sound effect (that is, it will be silent).  So, missing some would be innocuous.  I've played the game and haven't noticed anything missing.  So, it seems to be working.  I'm not sure how to be certain if sound effect 8 is used.  That is, at worst it will cause some sound effects to be missing, but likely it is working as intended.

@scubed2 You should add yourself to maintainers/maintainer-list.nix as the first commit to this PR. Then you can amend your second commit to include yourself in the meta.maintainers field.
Aside from that, we're good to go. Thanks!

Added myself as a maintainer in a separate commit.

@GrahamcOfBorg build nxengine-evo


Symfony 4.1 update - Error

@lchrusciel Today after updating to the latest Symfony 4.1 I start getting this error in my tests:
Error : Call to undefined method Symfony\Bundle\FrameworkBundle\Test\TestContainer::getMockedServices()
 /vendor/lakion/api-test-case/src/ApiTestCase.php:117

Problem related to getting MockedContainer Services for unmocking:
public function tearDown()
    {
        if (null !== $this->client && null !== $this->client->getContainer()) {
            foreach ($this->client->getContainer()->getMockedServices() as $id => $service) {
                $this->client->getContainer()->unmock($id);
            }
        }

        \Mockery::close();
        $this->client = null;
        $this->entityManager = null;
        $this->fixtureLoader = null;

        parent::tearDown();
    }

As symfony update states they have simplified testing container =) So this code should be removed/changed and docs updated.
As temporary solution/workaround until fix would be released create your own TestCase wrapper and override tearDown() like this:
use Lakion\ApiTestCase\JsonApiTestCase;

/**
 * TestCase wrapper.
 */
class TestCase extends JsonApiTestCase
{
    public function tearDown()
    {
        \Mockery::close();
        $this->client = null;

        static::ensureKernelShutdown();
    }
}

Same happening for Sylius, I think it's a bug introduced by Symfony.

@pamil are you going to work on this?

@pamil @lchrusciel Is it work now ? cause sylius 1.2.0 is released with symfony 4.1 support.

3.1.0 is working with Symfony 4.1


Merge Utils with EntityUtil

Merge catalog-rest-service/src/main/java/org/openmetadata/catalog/util/Utils.java
into
catalog-rest-service/src/main/java/org/openmetadata/catalog/util/EntityUtil.java

hey @sureshms, I would like to work on this issue please assign to me

Done

hey @sureshms, I just need to merge the functions and member of the util class into the Entity Util Class and verify the test cases right?

That is correct

Please review the PR @sureshms
PR : #1010

@dec0deit, closing this issue. Thank you for your contribution.


wrong checkboxList items checked

What steps will reproduce the problem?
echo \yii\helpers\Html::checkboxList('test', ['5.1'], ['5' => '5', '5.1' => '5.1', '5.10' => '5.10']);
What is the expected result?
only one checkbox are checked  (key 5.1)
What do you get instead?
two checkboxes are checked (5.1 & 5.10)
Additional info

Q
A

Yii version
2.0.36

PHP version
7.4

Operating system
Linux

The same behavior is observed in default selection on a dropdown and radio list

If your $selection is a string it'll work,
e.g.
echo \yii\helpers\Html::checkboxList('test', '5.1', ['5' => '5', '5.1' => '5.1', '5.10' => '5.10']);

When $selection is an array is does a different type of comparison (https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseHtml.php#L971).
I think we'd need to change the comparison type to strict on the ArrayHelper::isIn call or add a new option to allow it's setting.

Thanks for the answer. Unfortunately, changing $selection to string doesn't work for me. I can have multiple default values.

@samdark Do you think we should make the ArrayHelper::isIn checks strict by default for:
Html::checkboxList
Html::radioList
Html::renderSelectOptions
Or have an extra option?

@alex-code are there any possible breaks that may be caused by it?

There could be with numeric keys and selections.
echo \yii\helpers\Html::checkboxList('test', 5.1, ['5' => '5', '5.1' => '5.1', '5.10' => '5.10']);

This wouldn't match with a strict check.
Maybe an extra option is better.

Yes. Agree.


Ancient version of DiffMatchPatch

I love BBUncrustifyPlugin. Imagine my surprise when I found out that it is using code that I wrote/ported. :)
Just a heads-up that you are using an ancient version of DiffMatchPatch in BBUncrustifyPlugin-Xcode. Get the current one here:
https://github.com/JanX2/google-diff-match-patch-Objective-C

Thanks Jan for the feedback. It's now up-to-date (https://github.com/benoitsan/BBUncrustifyPlugin-Xcode/commit/93b026719548c5a13e40795659eae9ba434d310b). It's a very useful library ;)

Great! Glad to be of service. :)


Any way to merge the index.json for multiple framework hosting on single Static site ?

May related to https://github.com/apple/swift-docc/issues/328
Issue
Currently seems the index.json is used for left search filed searching the symbols.
However, the swift-docc-render/src/utils/data.js here seems only support query single one index.json in the whole site.
So, for Static site hosting, does this means I need to merge all the other frameworks into the final big index json files ? Is there any tools to do this ?
Alternate way
Currently in my example, I change this into index/${framework_name}/index.json and hosting multiple frameworks documentation.
- documentation/
  foo/index.html
  bar/index.html
- data/
  foo/foo.json
  bar/bar.json
- index/
  foo/index.json
  bar/index.json

You're right that the index.json is currently hardcoded to fetch the navigator data for a single framework. Ideally, I think there should be multiple "index" JSON files that map to each individual framework/module so that this kind of hosting setup is achievable (similar to your described workaround).
It might also be possible to merge the index data for every framework/module into a single file, however I believe the specification of that file was designed in a way to map to a single one, so I think the right thing to do would be to update both DocC and DocC-Render in a coordinated way to support multiple index files in a built single archive.

I think the implementation of this will likely be heavily impacted by https://github.com/apple/swift-docc/issues/317

Ideally, I think there should be multiple "index" JSON files that map to each individual framework/module so that this kind of hosting setup is achievable (similar to your described workaround).

I think this would work well. Could we build this in a backwards-compatible way, where DocC Render first tries to find the framework-specific index.json and falls back to a global one?

@franklinsch I just hacked around locally and to me it honestly seems like it can be covered in a backwards-compatible way.
Note, I'm not a project member / official contributor / whatever, but so far it seems like I could merry multiple library products in one doc'. But had to go pretty deep, like for example:
{
  "kind": "symbol",
  "metadata": {
    "externalID": "Beton",
    "symbolKind": "module",
    "role": "collection",
    "title": "Beton",
    "roleHeading": "Framework",
    "modules": [
      {
        "name": "Beton"
+      },
+      {
+        "name": "XCTBeton"
+      },
    ]
  },
///  ...

btw, I just learned this cool "diff" feature from @vknabel
Right path?
I'm not sure though if this route I took was the right path, since practically in our case, though both Beton and XCTBeton are intentionally in the same Swift Package, they aren't practically different modules of the same Framework, but instead two libraries.
One enhances Foundation and the other XCTest. These boxes shouldn't touch.
they're in the same Package & repo because they would otherwise cross-depend in a weird way.
Is help needed?
I'm personally all up to put in some meat into this issue if someone, anyone could be my tourguide for an hour to teach me the ins and outs of this renderer and how things end up here from docc. I mean, for real. With an initial swing I'm willing to take responsibility for this issue. My company needs it ¯\(ツ)/¯

Merging the index is part of the plan for combined documentation for multiple targets in DocC.
@franklinsch Should we move this issue to the swift-docc repository instead?

Yes that makes sense. Is there a way by which @adam-rocska can help with some of the work?


Take down InvisibleMan-XRay v2.3.2!

You should take down InvisibleMan-XRay v2.3.2 as it's broken. It simply does not work! Works once, after that it stops working.
Try to disconnect and connect again: IT DOES NOT WORK!

Hello @pps83,
That's not the solution!
Currently, many users already download the latest version and can work with it.
Can you give me more description about your problem? In which mode you can't connect? Did you check all files extracted correctly? Provide me more description and we can investigate the problem.

It's the same problem described here.
x64 win11 pro, with TUN interface. It works only once. If  you disconnect, and then reconnect client shows as if it's all connected and working, while it's actually NOT connected to any vpn. That's why you should take done this version, as it's broken.
I did install it properly, no need to ask. I had it installed on multiple PCs, all had the same issue. I rolled back to previous one InvisibleMan-XRay v2.1.2 and it has no issues.

@pps83 I need to investigate all the possibilities. Thus I ask about them. So be patient and answer them. OK, so based on your test we know the problem is not related to the Invisible Man TUN and we need to find the problem in the Invisible Man XRay app. Also, the problem occurs in some scenarios and some people are faced with this issue. Let me check in details.

Just trying your service before pay - no result.

Hello @Budi8888
I think the main problem is that you put the app in a non-English directory. This is one of the bad problems in this app, but I fixed it and it will be OK from the upcoming release (see this). For now, just put the app in a fully-English directory and then try to use.

Referring to the #126 issue, the problem is related to the TUN service and it will fixed now. So, you need to wait for the next release of Invisible Man XRay or update the Invisible Man TUN to the latest version that has already been published (InvisibleMan-TUN v0.3.5)


[onebusaway] [obaco] Production NoMethodError: undefined method `web_url' for nil:NilClass

View full error details at:
https://api.heroku.com/myapps/app58523565@heroku.com/addons/airbrake:free-hrku?url=https%3A%2F%2Fherokuapp58523565herokucom.airbrake.io%2Fprojects%2F135959%2Fgroups%2F1866082199715019853%2Fnotices%2F1866082199372355717
Error type:
NoMethodError
Error message:
undefined method `web_url' for nil:NilClass
Where:
stops#trips
File:
[PROJECT_ROOT]/app/controllers/stops_controller.rb, line 24
URL:
http://www.onebusaway.co/regions/12/stops/wemapp_195/trips?trip_id=wemapp_42_17&service_date=1484694000000&stop_sequence=20
Backtrace summary:
[PROJECT_ROOT]/app/controllers/stops_controller.rb:24:in arrivals
[PROJECT_ROOT]/app/controllers/stops_controller.rb:28:in trips

Looks like it's due to calling find_by instead of find_by! in StopsController#arrivals.


Tentalus Boss Room Softlock without Goddess Sword

If you defeat Tentalus without the Goddess Sword you cannot escape the room because you cannot hit the goddess crest. A way out needs to be implemented in a way that still allows getting the crest check and beating the dungeon later.

https://github.com/lepelog/sslib/tree/sandship-bossroom-fix seems to work, only problem is, that it's possible to trigger the escape sequence again after defeating tentalus and leaving the dungeon due to no goddess sword. This can be fixed by adding a storyflag, that deactivates the loadingzone behind the boss door (which is already done with the beat sandship storyflag currently).
This enables "tentalus skip RBM" on the main deck too, to skip 99% of the dungeon, although that can be prevented by adding a storyflag requirement to the event, that is set when tentalus dies


[ALLUXIO-2119] Heartbeat context test cleanup

https://alluxio.atlassian.net/browse/ALLUXIO-2119

Checking that constants are not null is a waste of space.
checkInstanceOfTest is generalized to check that all heartbeat threads use SleepingTimer by default.
addNewTimerClassesTest is changed to use ManuallyScheduleHeartbeat to test a more realistic scenario.

alluxio-bot, check this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11007/
Test PASSed.

LGTM


Updates/optimize user service

This PR fixes the error handling for supplying incomplete parameters during new users' account creation or update.
This PR also optimizes by incorporating Redis cache during user registration and updating and retrieving user details.
Fixes #36

Fixes #36


Updated Slack community info link

Description

The previous link was linking to an old Slack announcement on the blog--the newer link points directly to the Slack community info page which is more detailed and has up to date info (http://creativecommons.github.io/community/#slack)
Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I added tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Thanks @sgrepos! I think that text predated the community page.


Further blocking tweaks

This PR moves 2 additional potentially blocking operations into blocking tasks; they were found to be significant using tokio-console, which was also used to double-check that these changes decrease the Busy time of the associated tasks.

@vicsn @onetrickwolf @iamalwaysuncomfortable We will need to validate this branch with at least 12 hours of burn-in prior to approvals.

I'll fix the clippy issue shortly; as far as I can tell, it will not affect performance.

Double-clicking on this. @vicsn @onetrickwolf @iamalwaysuncomfortable Did we get a chance to burn-in test this change?

@vicsn @onetrickwolf @iamalwaysuncomfortable When will this be addressed?

Starting to test this now

Starting to test this now

Looks good. Ran for 12+ hours with 1.6 TPS and 3 blocks/second.


Pass down machine types through TestWorkflow

This PR also

Does some minor cleanup in fixtures.go regarding CreateNetwork, making the MTU setting a separate method instead of a copy-paste of CreateNetwork with one extra parameter.
Refactors networkperf test suite to take advantage of the now-available machine type field. We pass the target number directly instead of a large map string.

Also use the MachineType to prevent Tier_1 tests from running if the machine type is not supported.

This looks great, much cleaner way to handle things.
/lgtm


Windows: System.Console driver

Currently the only backend in use for gui.cs is the ncurses backend.   There is a partial implementation of a System.Console based driver but it is not complete.
Currently we use mainloop.cs to monitor input on standard input and wake up the mainloop to read the input.  We need a variant that works for Windows, likely using Console.ReadKey and using some AutoResetEvent to wake up the thread.
Generally, we can either make mainloop.cs fully cross platform, or we could surface Windows/Unix codepaths, and let the consumer (in this case, gui.cs) deal with it.
In addition to that, the backend itself needs to be completed.

I think it will be great to have a fully cross platform without dependency to ncurses so it could work on OS that have neither ncurses neither a C API (as Cosmos).

Right, we need to auto-detect the platform at startup and choose the right driver, currently it is hardcoded to NCurses and I change it when I work there.
https://github.com/migueldeicaza/gui.cs/blob/c5325c55272d5e35b824e99076ad1c67d7719be3/Terminal.Gui/Core.cs#L1160

In you opinion C# Console can do all NCurses does?

Thank you! I'll test this soon...


How to open RAW16 RGB stream on Ubuntu 22

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 22.04

Kernel Version (Linux Only)
5.19.0-32-generic

Platform
PC

SDK Version
<IP_ADDRESS>23

Language
Python

Issue Description
Hello. I would like to open a stream of RAW RGB data. This is my code:
import pyrealsense2 as rs

img_width = 1920
img_height = 1080
pipeline = rs.pipeline()
config = rs.config()
config.enable_stream(rs.stream.color, img_width, img_height, rs.format.raw16, 30)
pipeline.start(config)

try:
    while True:
        frames = pipeline.wait_for_frames()
        color_frame = frames.get_color_frame()
        if not color_frame:
            continue
        else:
            print(color_frame)
            break
finally:
    pipeline.stop()

This code works for RGB8 format but results in a runtime error for raw16 and raw8.
RuntimeError: Couldn't resolve requests

My goal is to get uncompressed but rectified colour data from the camera. My current approach is to get the raw readings, and then convert and rectify them myself. The reason why I want to do it like this is that if I get data from the RGB8 stream directly, the data appears compressed (somewhat blurred, with finer details of my object lost). I would like to see if I can maybe get higher-quality images by processing raw readings myself. However, I am open to suggestions regarding achieving better RGB images.

Thanks for the suggestions @MartyG-RealSense. FPS is not relevant for me, as my object of interest is static. I will investigate the effect of sharpness in my setup further, but I am afraid there might have been a small misunderstanding. I am aware that RAW data cannot be displayed by RealSense SDK. My issue is that I am unable to start a stream, i.e. the code fails at pipeline.start(config)
You suggest converting raw frames to a usable RGB format using an OpenCV function. However, I cannot start the RAW stream in the first place.

Please try changing the resolution in your config instruction for RAW16 to 1280x800 instead of 1920x1080.  This may overcome the RuntimeError: Couldn't resolve requests error, though the stream could not be visually displayed.

Hi @daniellehot  Do you require further assistance with this case, please?  Thanks!

Hi @MartyG-RealSense. Sorry for the late response. We can close this issue for now, although I have not managed to start the raw stream. I have decided to use another RGB camera and RealSense as a depth sensor.

It's no problem at all.  Thanks very much for the update!


Improve version sensor

Description:
This PR builds on the updated version sensor (https://github.com/home-assistant/home-assistant/pull/18067). It improves validation and adds a name that makes sense with the new functionality.
Currently it always shows 'Current Version' as name, which is confusing when using the component to check the latest version available.
I think this is not a breaking change, but maybe someone can verify (@ludeeus reminded me the entity_id is linked to the name):

If a user specified a custom name before it still uses that one
If a user is not using the new functionality it still has the same default value

Edit: this now also sets the icon property which was forgotten
Related issue (if applicable): fixes # NA
Pull request in home-assistant.io with documentation (if applicable): https://github.com/home-assistant/home-assistant.io/pull/7409
should be cherry-picked for the beta 0.82 release
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Can be merged if CI passes.

It's fixed now, Travis hasn't started here yet but succeeded on my personal repo.


Look in parent classes when parsing signal and method identifiers

Fixes #57337
Added two tests for this scenario
Bugsquad edit:

Fixes #54172

It seems this didn't pass the tests, but the error message is extremely unclear. I don't really see how my changes could have caused this. Does anyone have an idea?

It seems this didn't pass the tests, but the error message is extremely unclear. I don't really see how my changes could have caused this. Does anyone have an idea?

The leak sanitizer found that your tests are leaking memory (you instantiate a Node, which is not RefCounted, so it needs to be freed somehow).

It seems this didn't pass the tests, but the error message is extremely unclear. I don't really see how my changes could have caused this. Does anyone have an idea?

The leak sanitizer found that your tests are leaking memory (you instantiate a Node, which is not RefCounted, so it needs to be freed somehow).

Thanks for the help, should be fixed now.

Hi there. There is another PR for the same problem: #56830 (and a duplicate corresponding issue #54172). I am the author of the other PR, so somewhat biased - they seem roughly equivalent so it would probably be good for whoever reviews to compare. I don't have unit tests in the other one, only a test file in the PR description. The main differences seem to be:

the method of walking up the hierarchy: scr->_base vs. base_class->base_type.class_type  - I couldn't check easily if they are always equivalent.
one collapses the try in native base loop with the new loop walking up the hierarchy. I am not completely sure why that is kept separate in the original code, so I left it separate.
Use of base_class->has_member and base_class->get_member which I think improves the code readability.

Feel free to integrate as you see fit!

I actually prefer @strank's solution TBH. But I like that this PR includes a test case which helps to avoid future regressions.

We merged #56830 which solves the issue, but it would be good to add the test cases from this PR indeed. @Piet-G Could you rebase to keep the tests only?

Superseded by #56830 and #58757. Thanks dir the contribution nevertheless!


Example for doing a POST request

I'm trying to do a post request to a website with this module and I can't quite figure out the correct correct settings. Could you provide an example?

hi, here is an example that does a POST:
`
var phantomJsCloud = require("phantomjscloud");
var browser = new phantomJsCloud.BrowserApi();
    browser.requestSingle(
          { url: "https://phantomjscloud.com/examples/helpers/requestdata",
          renderType: "plainText",
          urlSettings: { operation: "POST" },
          }
          , (err, userResponse) => {
        //can use a callback like this example, or a Promise (see the Typescript example below)
        if (err != null) {
            throw err;
        }
        console.log(JSON.stringify(userResponse.content));
    });

`


Added support for CycloneDX and SPDX manifest files to the CLI. Also …

…improved build script

Seems fine, but we should probably pull these glob patterns from the API instead of hard coding them. @bcomnes do we have an API for this?

If we do have an API for this, or even just an established pattern for generating the glob patterns in the JS sdk, I can incorporate that into the changes I'm working on right now.
I'm working through the cli, replacing all the direct API calls with the associated methods from the python SDK.


Msbuildify tools

Microsoft.DotNet.Watcher.Tools

Expect to run independently, via the CLI
Project “inputs”: Source files, resource files, etc.
Needs to know the literal globs so it can identify folders to watch
P2P graph

TODO

Fork tools repos to rel/1.0.0-preview3 branches for "October" release. Dev branches will continue to be used for 1.1 release.
Use desktop msbuild to start our work until the new msbuild is ready for   consumption

Notes

This tracks the work across the tools repos.
This is the previous discussion on the topic.

From #156
project.json and Microsoft.DotNet.ProjectModel are being retired in favor of xplat MSBuild. dotnet-watch should update to support the new project system for dotnet-cli.
Open questions

How should we interpret the project system to discover files to watch? Two options:

Make dotnet-watch an msbuild task
Host MSBuild and execute a design-time build to discover items and properties

Can we ensure we detect files are added when MSBuild uses globs?
Can we reuse components from https://github.com/dotnet/roslyn-project-system to do this?

@natemcmaster any progress here? We depend on this feature in VS Templates. Minimally we need to know the file location where the tool will be looking for the secrets.

We are still waiting on design decisions from MSBuild before we proceed, but if this is blocking you let's talk more in detail. I may be able to provide enough concrete details to unblock you.

@natemcmaster thanks. Please chat with @abpiskunov or @mlorbetske.

Some progress from MSBuild: https://github.com/Microsoft/msbuild/pull/1080. This will help us as we build tools that need to perform project evaluation.

Blocked by https://github.com/dotnet/cli/issues/4213

@natemcmaster good to close?

Yes, basic work is done now.


feat: added job which checks if code is formatted correctly in Circle…

…Ci, code formatted using black

I have read the CLA Document and I hereby sign the CLA

:tada: This PR is included in version 1.4.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.7.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


'Value and (max - min) should be divisible by step' - could be more leniant.

In cases where the specific step value isn't particularly important, it's a bit annoying to have errors thrown. That might mean that I won't use this component for the time-being (admittedly I am in a bit of a rush just now, I'll likely revisit later).
I tried value={value - (value%step)} but with floating-point being what it is, that doesn't cut it.
Actually, I'm not sure that the internal logic is quite right either:
        if (this.value % this.step || (this.max - this.min) % this.step) {
            throw new Error(
                'Value and (max - min) should be divisible by step.',
            )
        }

What if one wanted to have a step of 1, but always falling at 0.5 offset, so you might have
min={-2.5} max={2.5} step={1} value={-1.5}

but your code wouldn't allow it.
Perhaps you could consider some of

allowing step not to be specified
exposing a property that would allow the user to specify whether to automatically quantize, throw an error...
reviewing the math somewhat

Cheers

Actually I think what I'll do for now is essentially wrap this component in something that keeps an internal value with a range 0..200 & step=1, then normalise & map back to desired range as appropriate.

Hi @xinaesthete , your idea to rap the component is good.
Currently, only whole numbers are supported.


Fix typo

Evi:

@changeworld : Thanks for your contribution! The author, @vladvino, has been notified to review your proposed change.

@GitHubber17 : Thanks for your contribution! The author, @vladvino, has been notified to review your proposed change.

@GitHubber17 : Thanks for your contribution! The author, @vladvino, has been notified to review your proposed change.

Verified editorial correction in URL syntax.


BUG: Update viewAction to accept only valid verbs

See http://resources.infosecinstitute.com/http-verb-tempering-bypassing-web-authentication-and-authorization/
Co-authored-by: Matt McCormick<EMAIL_ADDRESS>Co-authored-by: Michael Grauer<EMAIL_ADDRESS>

Cc: @thewtex @mgrauer

LGTM.


Enable html5 database in webViewShow webView

From @GoogleCodeExporter on May 31, 2015 11:27
In the android browser surfing to an html page as follows:-

hi

you will then have access to an sqlite database. calling webViewShow() on an
html file with the same code in it always returns NULL from the openDatabase
function.

Searching the web shows that you have to call setDatabaseEnabled and
setDatabasePath on the webView that is created. See for example:

http://stackoverflow.com/questions/2474475/how-do-i-call-window-opendatabase-fro
m-a-webview-hosted-in-an-android-application

http://www.rohanradio.com/html5-database-api-support-in-an-android-webv

We should enable database for scripts since it is already enabled in the
standard android browser.

Find attached a minimal html file that opens a database, lets you add simple
key / value entries and lists all values in the database. This code works in
the android browser, but not in the webViewShow.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Sep 2010 at 11:46
Attachments:

db.htm

Copied from original issue: damonkohler/android-scripting#425

From @GoogleCodeExporter on May 31, 2015 11:27
Do you have any solutions for the webview/webchromeclient ?

Original comment by<EMAIL_ADDRESS>on 15 May 2012 at 8:33

From @GoogleCodeExporter on May 31, 2015 11:27
Code in those links is as follows:-

WebSettings settings = myWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setDatabaseEnabled(true);
String databasePath = this.getApplicationContext().getDir("database",
Context.MODE_PRIVATE).getPath();
settings.setDatabasePath(databasePath);
myWebView.setWebChromeClient(new WebChromeClient() {
	@Override
    public void onExceededDatabaseQuota(String url, String databaseIdentifier, long currentQuota, long estimatedSize,
        long totalUsedQuota, WebStorage.QuotaUpdater quotaUpdater) {
        quotaUpdater.updateQuota(estimatedSize * 2);
    }
});

Original comment by<EMAIL_ADDRESS>on 10 Sep 2010 at 11:48

From @GoogleCodeExporter on May 31, 2015 11:27
Hi,

I tried out the code above but i am experiencing an error "webstorage cannot be
resolved to a type".

please help.

Original comment by<EMAIL_ADDRESS>on 24 Oct 2013 at 2:49


Add field value from import form

Hi!
Need advice about how to add field value which is not in import file. Created custom InputForm, but stucked with getting value from my select in before_import function

Just invented solution. I added hidden field in my import forms, then added these values in dataset in  process_import and import_action methods in my ImportExportActionModelAdmin class.
There might be a simpler solution, but my also works!

@justkrevedko I like that!  Would you be willing to throw together a little more information about how you did that?  I think that's a common problem (I have a similar need but haven't worked out a complete solution yet) so would love to have some documentation on ways to solve it.

Hello, @mgrdcm
First I created custom forms.py in my project to add new fields:

forms.py

from django import forms
from import_export.forms import ImportForm, ConfirmImportForm
from .models import Contract

class CustomImportForm(ImportForm):
    ...
    #this is my custom field
    input_contract = forms.ChoiceField(label = "Contract", choices=())

    def __init__(self, import_formats, *args, **kwargs):
        super(CustomImportForm, self).__init__(import_formats, *args, **kwargs)
        ...
        #get values for select
        choices = []
        contracts = Contract.objects.all()
        for c in contracts:
            choices.append((str(c.pk), c.name))
        choices.insert(0, ('', '---'))
        self.fields['input_contract'].choices = choices

class CustomConfirmImportForm(ConfirmImportForm):
    #need to set custom field value to save after import preview
    input_contract = forms.CharField(widget=forms.HiddenInput())

Then I overrode methods in my ImportExportActionModelAdmin class

admin.py

from .forms import CustomImportForm, CustomConfirmImportForm
...
class CameraAdmin(ImportExportActionModelAdmin):
    resource_class = CameraResource
    #not needed all formats
    formats = (base_formats.XLS, base_formats.CSV)
    ...
    # return my custom import form here
    def get_import_form(self):
        return CustomImportForm

    def import_action(self, request, *args, **kwargs):
        ...
        if request.POST and form.is_valid():
            input_format = import_formats[
                int(form.cleaned_data['input_format'])
            ]()
            import_file = form.cleaned_data['import_file']
            #here saving select value
            input_contract = form.cleaned_data['input_contract']
            ...

           #modify dataset to see value on import preview
            contract_field = [int(input_contract)] * dataset.height
            dataset.append_col(contract_field, header='contract')
            ...

            if not result.has_errors():
                context['confirm_form'] = CustomConfirmImportForm(initial={
                    'import_file_name': tmp_storage.name,
                    'original_file_name': import_file.name,
                    'input_format': form.cleaned_data['input_format'],
                    # set hidden value in confirm form
                    'input_contract': form.cleaned_data['input_contract']
                })
     ...

    @method_decorator(require_POST)
    def process_import(self, request, *args, **kwargs):

        confirm_form = CustomConfirmImportForm(request.POST)
        if confirm_form.is_valid():
            import_formats = self.get_import_formats()
            input_format = import_formats[
                int(confirm_form.cleaned_data['input_format'])
            ]()
            # get value here
            input_contract = confirm_form.cleaned_data['input_contract']
            ...
            # modify dataset berore save
            contract_field = [int(input_contract)] * dataset.height
            dataset.append_col(contract_field, header='contract')
            ...

I am having a bit trouble implementing this. I see the custom field on the import form, but the value does not get set in the actual import. Did anybody else make this work?

I found a simpler way of doing this: If you override ImportExportModelAdmin.get_resource_kwargs(), you can store the request object in your Resource class, then use it in before_import_row().
Most of the magic happens in the resource:
class CameraResource(ModelResource):
	... your resource definition...

	# Override the constructor to store the request
    def __init__(self, request=None):
        super()
        self.request = request

    # Insert the contract into each row
    def before_import_row(self, row, **kwargs):
        row['import_contract'] = self.request.POST.get('import_contract', None)

In order to get the request to the resource constructor:
class CameraAdmin(ImportExportActionModelAdmin):
    resource_class = CameraResource

    def get_import_form(self):
        return CameraImportForm

    # add the request to the resource constructor call kwargs
    def get_resource_kwargs(self, request, *args, **kwargs):
        rk = super().get_resource_kwargs(request, *args, **kwargs)
        rk['request'] = request
        return rk

Also, if your custom form is just querying a model's instances for a ForeignKey reference, you don't need a special form constructor. Just use a ModelChoiceField with the queryset argument:
class CameraImportForm(ImportForm):
    input_contract = forms.ModelChoiceField(label = "Contract", queryset=Contract.objects.all())

The only difference I can see is that this way doesn't allow for a custom ConfirmImportForm. Currently there's no ImportExportActionModelAdmin.get_confirm_import_form(), which is a shame. The good news is that the use of before_import_row() means you don't need it anyway.

@yozlet what are you refering here as 'import_contract'
contract = self.request.POST.get('import_contract', None)?

@Wolverine7 Thanks for catching that typo! I meant input_contract (from @justkrevedko's original code).
I've also taken the opportunity to move the logic around a little, as I talked about in #899. This is the code you were asking for; sorry for not replying sooner!

@yozlet thank you for your prompt response! really appreciate your help!

10

is there any new solution using : get_form_kwargs instead of get_resource_kwargs?

Yes there should be @Milstein!  That's what I'm using it for.  Apologies I don't have a full example to share right now.


Approval permission for 1.24 release

As the 1.24 Release Docs lead, I would like to add myself to the approver list for the dev-1.24 branch.
/cc @jimangel @divya-mohan0209 @sftim

/cc @JamesLaverack, FYI

/lgtm

/approve

/hold

I think this PR targets the wrong branch @nate-double-u

I thought that the system would only pickup permissions from the main branch.
Previous sample PR: https://github.com/kubernetes/website/pull/26114

I'm pretty sure that Prow takes its idea of permissions from the target branch. I'm willing to be proved wrong, mind.

Let's try it, I've changed the target branch.

/lgtm
/approve
LGTM also from https://github.com/kubernetes/website/pull/31373/files/92268803a7e00c8b4182e568058acfd047312eda..b8aa75a5600eb460194ee011e9c8738e77eb694f (thanks @kbhawkey)

/hold cancel
/lgtm

Thanks everyone!

Come release day, I may need permissions on main as well,  but that's something we can look into.

Fwiw, previous PRs targeted main for this. But as long as it works, all good.
For reference, this PR is step 2 from 'Ensure access is set up' in the docs timeline.
For release day, you'll need to be temporarily added to the maintainers org. That's this step.
Hope that helps!

The problem with targeting main is that:

you get access to main before it's needed
you have to merge that change into dev-1.24 (which you can't yet approve!) before it works


Integrity constraint violation

I am on Magento 2.2.6. I installed using composer. I want to restrict the Net30 payment to only on the Net30 customer group. When I save customer group I get this error-
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '7912-0-1' for key 'PRIMARY', query was: INSERT INTO catalog_product_index_price SELECT index.entity_id, 0 AS customer_group_id, index.website_id, index.tax_class_id, index.price, index.final_price, index.min_price, index.max_price, index.tier_price FROM catalog_product_index_price AS index WHERE (customer_group_id = '4') ORDER BY index.entity_id ASC, index.customer_group_id ASC, index.website_id ASC LIMIT 50000
Any Ideas?

Hi @niners52
Sorry but this error sounds like it may be coming from another module or somewhere else?! There would be no reason for the table catalog_product_index_price to be affected by this module. The module has been installed and tested on a fresh version of 2.2.6.I'd suggest maybe looking through the stack trace to see where this error is occurring.
You could also try disabling this module, flushing all the usual caches etc... and saving the Customer Group to make sure this issue only occurs when the module is enabled.
Let me know if the issue persists and we'll try to resolve 🙂

I started troubleshooting and walked through everything one more time and it worked. Not sure what I screwed up the first time around but it is working now. Thank you for the response and the extension!


Html in stored in columns may draw over results table

Issue Type: Bug
I have a table that stores html in a column and the values draw on top of the entire results area. The results area is basically completely white.

SQL Operations Studio version: sqlops 0.31.4 (e026ab85a72c190cc4ccc834503aa9fe36dd6407, 2018-07-18T02:14:21.826Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.68GB (6.61GB free)

Process Argv
C:\Program Files\SQL Operations Studio\sqlops.exe

Screen Reader
no

VM
0%

Extensions: none

This should be fixed in the insiders build and will be in the next release

looks like this is a duplicate of #1971, which is already closed.


Top level: incorrect display of infinite list

?- L=[a|L].
   L = [a,a|L] % ok
|  % alternatively
   L = [a|L] % would be more compact, both ok
?- append("a",L,L).
   L = [a,a,a|_A], unexpected. % expected, as above

?- append("a",L,L).
   L = [a|_A], unexpected.

Again, the original problem


Support for newer scikit-image is needed

Tested with Docker (Docker version 23.0.1, build a5ee5b1) on Ubuntu 22.04.2 built with this file:
FROM python:3.11-slim
ENV DEBIAN_FRONTEND=noninteractive
RUN apt update && apt install -y build-essential patchelf && rm -rf /var/lib/apt/lists/*
RUN pip install scikit-image numpy Nuitka
ADD so-3.py /
RUN python -m nuitka so-3.py --standalone --onefile
CMD ["./so-3.bin"]

and this script (so-3.py):
import sys
import numpy as np
from skimage.measure import label, regionprops

print(sys.executable, sys.version, sys.version_info)

image = np.zeros((8, 8), dtype='i1')
image[2:4, 2:4] = 1
labels, _ = label(image, background=0, return_num=True, connectivity=2)

for prop in regionprops(labels, image, cache=True):
  print(prop.coords)

I'm getting this output:
Traceback (most recent call last):
  File "/tmp/onefile_1_1678566288_604959/so-3.py", line 3, in <module>
    from skimage.measure import label, regionprops

  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "/tmp/onefile_1_1678566288_604959/skimage/__init__.py", line 74, in <module skimage>
  File "/tmp/onefile_1_1678566288_604959/lazy_loader/__init__.py", line 243, in attach_stub
ValueError: Cannot load imports from non-existent stub '/tmp/onefile_1_1678566288_604959/skimage/__init__.pyi'

The script itself runs fine, i.e. Docker image build with:
FROM python:3.11-slim
ENV DEBIAN_FRONTEND=noninteractive
RUN apt update && apt install -y build-essential patchelf && rm -rf /var/lib/apt/lists/*
RUN pip install scikit-image numpy Nuitka
ADD so-3.py /
CMD ["python", "so-3.py"]

produces:
/usr/local/bin/python 3.11.2 (main, Mar  1 2023, 14:56:17) [GCC 10.2.1 20210110] sys.version_info(major=3, minor=11, micro=2, releaselevel='final', serial=0)
[[2 2]
 [2 3]
 [3 2]
 [3 3]]

as expected.

Make your docker output what reports need, python -m nuitka --version  and the compilation report for better reports.

This is really ugly, but admittedly clever by them, to use .pyi files. This must be a newer skimage version that added it. I imagine this trick will get copied over time, since it kind of makes sense to avoid the duplication.
Now, Nuitka is not including .pyi files as data files on purpose, because they are supposedly unused. We will need a new annotation in the Yaml configuration that does cause the inclusion of the .pyi file for a given more, since I want to stay firm on that. As a bonus, for the commercial version, these .pyi files could be embedded automatically. I have to assume it's pretty easy to modify a deployed program by modifying these .pyi files otherwise. Compare with https://nuitka.net/doc/commercial/protect-data-files.html

Do you still need more logs from Docker image building? What is the flag to get them? They disappear from the terminal after each line of Dockerfile is processed.

Docker is really a bad tool to debug apparently. But reports are written to a file, surely you can get that artifact, and it will contain the version outputs too. I have however managed to reproduce it, and will have a fix soon, nothing needed from you here. I will however add it to the report template, that I want these informations even and esp. from container builds.

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback if this is working is very welcome, just please do not share plans of doing it, but rather confirmations or denials of it working.

This is neither a regression of 1.5 nor related to using 3.11 for all I know.

The test runs fine with a factory branch of Nuitka. Thank you for very fast response.

This is part of the hotfix release 1.5.1 that I just made.

Is release 1.5.1 going to be available on PyPI? It's not there yet.

Should be now, the CI failed to upload indeed.


Move dependabot to ecosystem

PTAL: @chrisleck / @kr-project/ecosystem

@vaskevich or @chrisleck can you merge this? I don't have the right access


Add content under phone and email

o   (under email) This email address will be used to send you a confirmation and instructions for this application. The phone number will be used to contact you if additional details are required.
o   (A checkbox needs to be added under phone number with the text) Are you happy for the email address and/or phone number to be used for other Council communications?

closes #261


Add invariant to constants

At the moment, constants only have ensures clauses. We defined that as a property that holds at the end of the module evaluation.
It would also be nice to have invariant clauses, that hold at every function entry/exit.

The simplest thing to do would be to forbid contracts on mutable constants.


Create changelog from merge commits

Build the changelog entries from merge commit PR details instead of the individual commits. This could be cleaned up a bit but wanted to get feedback on the idea of using gh to do this, requiring you to be logged in to generate the changelog entries.
Example:
## v0.146.0, 5 May 2021

- fix(Go mod): detect when remote end hangs up [#3469](https://github.com/dependabot/dependabot-core/pull/3469)
- Final pass on bundler1 test cruft [#3466](https://github.com/dependabot/dependabot-core/pull/3466)
- Handle repo not found errors for go modules [#3456](https://github.com/dependabot/dependabot-core/pull/3456)
- Disabled poetry experimental new installer (@honnix) [#3459](https://github.com/dependabot/dependabot-core/pull/3459)
- Implement delete/create action in GitLab Client (@jerbob92) [#3414](https://github.com/dependabot/dependabot-core/pull/3414)

wanted to get feedback on the idea of using gh to do this,

👍
This (PR titles) is what I tend to do manually when I'm not familiar enough with a diff to summarize.
Aside: https://github.com/atlassian/changesets / https://github.com/changesets/action provides some neat tooling here too, but that's a much bigger leap than "CHANGELOG.md, but easier". :shipit:

Alternatively, what about a process that encourages CHANGELOG.md be modified as part of each PR? That solves the summarization problem, and lets contributors decide themselves if they want a shoutout, etc...
Meh, that's manual and tedious - this is ✨magic✨ .

Aside: https://github.com/atlassian/changesets / https://github.com/changesets/action provides some neat tooling here too, but that's a much bigger leap than "CHANGELOG.md, but easier". :shipit:

This looks cool! Up for testing it out.
Yeah keen to improve the current flow a bit as I frequently reach for the PRs to reach for author/title.

👍🏻  I like this approach, as _thepwagner notes this is automating what I already do when I don't have context on the change. I think it's a good forcing function to encourage expressive Pull Request naming by authors and their reviewers over time.


Software crashes any attempt to publish via file->publish

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug

NPE version: (e.g. 3.12) (see Help -> about)
v3.18
Installed from:
ClickOnce
In case of a BUG:

What is the current result?
The software crashes
What is the expected result?
The software to continue in functional state
Please post full exception details in case of an Exception (message, stacktrace, inner exceptions)

System.Security.Cryptography.CryptographicException was unhandled
Message: An unhandled exception of type 'System.Security.Cryptography.CryptographicException' occurred in System.Security.dll
Additional information: Key not valid for use in specified state.

Are there any work arrounds?
no.

Is there a version in which it did worked?
I used this tool two months ago on a machine with near similar configurations without trouble. Uninstalling/Reinstalling does not refresh or amend the problem.

Is there a package on Nuget.org which shows the bug? I suspect all of them, but the one I wanted to look at the time of the crash was package id: Microsoft.VisualStudio.SDK.VsixSuppression

edited misspelling in title

Did you have upgraded your Windows?

This must have been my machine's fault. We had a power blackout yesterday, after which I had to manually service the image with new updates using the "DISM.EXE". Once finished, I tried package explorer and It was working fine.
I would like to thank you for what you do and for this project. Take care!

Thanks for the feedback!


fix intermittent test in user_mailer_test

changed the way @random_repo gets a random user so it never returns a nil and consequently fixing the intermittent error on the test.
Also fixed a tiny typo in repo.rb :smile:  #801

Thanks ❤