HBASE-22565

HBASE-22565: Fixed Javadoc Warnings: @see cannot be used in inline documentation

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
267
master passed

+1
compile
79
master passed

+1
checkstyle
102
master passed

+1
shadedjars
278
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
263
master passed

+1
javadoc
53
master passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
263
the patch passed

+1
compile
73
the patch passed

+1
javac
73
the patch passed

+1
checkstyle
23
The patch passed checkstyle in hbase-common

+1
checkstyle
75
hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
278
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
791
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
255
the patch passed

+1
javadoc
51
the patch passed

_ Other Tests _

+1
unit
154
hbase-common in the patch passed.

-1
unit
14762
hbase-server in the patch failed.

+1
asflicense
62
The patch does not generate ASF License warnings.

18245

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

hadoop.hbase.client.TestAsyncTableAdminApi

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/300

JIRA Issue
HBASE-22565

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 423737def0ee 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 934d469fd5

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/testReport/

Max. process+thread count
4556 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

0
mvndep
14
Maven dependency ordering for branch

+1
mvninstall
233
master passed

+1
compile
72
master passed

+1
checkstyle
88
master passed

+1
shadedjars
261
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
231
master passed

+1
javadoc
50
master passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
234
the patch passed

+1
compile
70
the patch passed

+1
javac
70
the patch passed

+1
checkstyle
22
The patch passed checkstyle in hbase-common

+1
checkstyle
66
hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
251
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
693
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
220
the patch passed

+1
javadoc
49
the patch passed

_ Other Tests _

+1
unit
161
hbase-common in the patch passed.

+1
unit
8431
hbase-server in the patch passed.

+1
asflicense
61
The patch does not generate ASF License warnings.

11565

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/300

JIRA Issue
HBASE-22565

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 60f5fcfdc2d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / ef44f30006

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/testReport/

Max. process+thread count
4972 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@syedmurtazahassan You changed the title of the PR, but not the commit message. Could you please do that?

message

@HorizonNet Thanks for the feedback. I have changed the commit message.

@syedmurtazahassan Thanks. Will merge it later today.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
167
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
1
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
296
master passed

+1
compile
96
master passed

+1
checkstyle
119
master passed

+1
shadedjars
329
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
318
master passed

+1
javadoc
65
master passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
298
the patch passed

+1
compile
92
the patch passed

+1
javac
92
the patch passed

+1
checkstyle
28
The patch passed checkstyle in hbase-common

+1
checkstyle
82
hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
322
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
939
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
331
the patch passed

+1
javadoc
63
the patch passed

_ Other Tests _

+1
unit
189
hbase-common in the patch passed.

-1
unit
16562
hbase-server in the patch failed.

+1
asflicense
61
The patch does not generate ASF License warnings.

20804

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/300

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux a5d243f18046 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 863b7b9412

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/testReport/

Max. process+thread count
4752 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


CMake needs patching to build on Windows

What
See: https://github.com/JellyfishPictures/OpenAssetIO-rez-pkgs/blob/075d1823255446930901b3ed0eb6e0674a4e6a28/openassetio/rezbuild.py#L30
It seems that CMake is having trouble finding python on Windows in some configurations.
We need to figure out the cause for this, and support out-the-box where possible.

Found two issues on Windows:
What I did:
git clone https://github.com/OpenAssetIO/OpenAssetIO.git
cd openassetio
python -m venv .venv
./.venv/Scripts/activate.ps1

python -m pip install --update pip
pip install pybind11[global]

I had to add manually pybind11_DIR for cmake find it. I've tried pip install pybind11 and pip install pybind11[global] both without success.
Running:
cmake -S . -B build -D pybind11_DIR=.\.venv\share\cmake\pybind11

solved the issue.
Bigger problem was error with linking of python39.lib that wasn't found no matter what I've tried. I've managed to quickly hack it by just copying the lib to  pre-configured vcpkg directory that was auto added to the linker.
Last thing I had to do was to manually copy openassetio*.dll and _openassetio.pyd to .venv/Lib/site-packages/openassetio to make it work.

To answer specifically about the patching required in the linked Rez package in the description:
Our development/testing both on CI and locally on Windows, with both Conan and external (via cibuildwheel) Python environments, didn't require such a patch, so it seems like a Rez environment-specific issue.
We are currently in the process of getting a Rez deployment to test OpenAssetIO packaging, and will be able to investigate this more thoroughly once this is set up.


fix: fix property type 'date' when backend returns an iso string

Fixes issue related to https://github.com/SoftwareBrothers/adminjs/issues/1691
@AshotN this fixes a bug where date values were rendered as NaN-NaN-NaN if backend returned an ISO string instead of a simple date string while having the property's type set to date instead of datetime.

Makes sense, I haven't been able to test on my actual project yet. But looking at the changes it looks good to me. Sorry for introducing that issue

I'll have to give this more thought. If the database/backend stores datetimes using UTC timezone and the user's timezone is i.e. GMT+4, this will convert backend's 2024/08/13 11:00PM to 2024-08-13, while that should be 2024-08-14 in the user's timezone.

My thought process was for date's with no time. We should display exactly what the DB is storing, so 2024-01-01 no matter where you are should display 2024-01-01. For editing I can see it either way, if your local timezone should be converted to UTC, or just write it as you input it. The latter is more intuitive at face value. But I'm not sure what people would expect more

Hi there,
Upgrading from 7.8.1 to 7.8.12 gave me the NaN-NaN-NaN issue.
Waiting for this fix to be deployed.
Thanks

I'll merge this for now. We should consider using https://www.npmjs.com/package/@formkit/tempo for dates in the meantime


Lyrics don't scroll when casting to a device

OS:
Windows 10
Issue Descriptions:
When casting to an external device, lyrics don't scroll
Steps to Reproduce:

Open GPMDP. Play a song that has lyrics
Click the overflow dots and click "Show Lyrics (Beta)".
Note how the lyrics scroll as the song progresses
Click the Chromecast icon and select a device (I'm using a Google Home in this instance). Play a new song.
Click the overflow dots and click "Show Lyrics (Beta)"
Now how the lyrics don't scroll as the song progresses.

Given that the lyrics don't "scroll back" if you rewind the song, my guess is that scrolling and / or the position of the lyrics isn't tied to the elapsed / total time. Tying it to that would (I'd presume) scroll when casting, but also shift around as you fast forward / rewind the song.

General timing things are a bit broken in the current release and work fine in current master


Blank Tab

Anki: 2.1
Operating system: Mac os
Hi! I hope this is the right place to say this. I recently downloaded this add-on alongside ankiconnect. I followed the instructions.
However, my new tabs are staying blank without showing any of my cards.

Hey! Are you still having this problem? If so, could you provide a list of all the steps that you took to get to that point? Thanks!

Hello, I'm having the same problem. I downloaded the AnkiConnect addon, installed it, and then installed the AnkiTab extension from the Chrome store.

@amarcozzi Could you open the developer tools console with F12 and copy everything that appears there please?

I'm not sure what happened, but I came back to my computer a couple of hours later, and the addon worked! Thanks for your help anyways, and here's the contents tab of the console with the addon working if it helps you at all. Let me know if there's any other information you need from me – maybe it can help someone else.

Interestingly, the problem has come up again. I didn't change anything as far as I can tell, but the blank card on a new tab issue is back. The following screenshot shows my Chrome screen with the developer console on the left, and my Anki screen on the monitor to the right. Let me know if there's anything else I can provide you with!

Seems like it's a problem related to ankiConnect but I'm afraid that I can't really help much (tried again to reproduce it locally but failed). If somehow you find a pattern that increases the chance of this type of error popping up please let me know.


Release preparations for 2.2.0 release

[x] Checklist update
[x] Checklist tests
[x] DUK_VERSION bump
[x] Website download link
[x] RELEASES reorganization
[x] RELEASES read-through
[x] 2.2 migration notes read-through and finalization
[x] Benchmarks automatic heading anchors
[x] Update jQuery snapshot
[x] ARM/Thumb size test runs
[x] ARM/Thumb size tests to benchmark page
[x] Website index figures update, benchmarks links

Pretty close now, found a few bugs with the (very long) stress test runs, fixes are in master. Still need to manually test a few specific targets (covering all endianness cases) and manually test the debugger basics.

Updated index page footprint/RAM figures, now include Thumb in addition to x86:

ConfigCode footprint (kB)Startup RAM (kB)
thumb default14673
thumb lowmem9626
thumb full lowmem1201.5
x86 default17674
x86 lowmem12127
x86 full lowmem1461.5


fix: error message in PublicState::read

Fix misleading error message
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[x] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

replacing with: https://github.com/AztecProtocol/aztec-packages/pull/4149, for some reason applying this to HEAD is getting rejected


Fix main ci - cranky didn't understand

What
Worked locally already, but ci didn't find the clippy config file so far, trying to address that here.
Tested that config is still picked up by putting let _ = std::time::SystemTime::now(); into space_view.rs
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check

still red!


Mover prettier to dependencies vs. devDependencies

Often we put prettier in the devDependencies of package.json, because we only use it to format files during development.  However, since you are using it in your runtime code, you need to include it in dependencies.  This is important because people often install only the dependencies vs. devDependencies when using vs. developing a project, and your code will break without prettier.

I didn't know about "devDependencies" and Prettier went inside there without my intention. Thank you for checking the details!


Leverage nsi-survey-tool css styling to have a consistent style

in order to maintain a consistent user interface, we need to leverage consistent css for our toolset.
Right now this tool is using bootstrap and the sandstone bootswatch, but nsi survey tool is using a different solution. Lets move to the nsi-survey-tool css set.

please use the rgoss branch for reference

Ok, the login page is the same for both the download and survey tools. However, do you really, really, really want to go with all black colorings for the main map page?

Sweet.
What do you think? One think I have considered is to have different color schemes for different sites, but keeping the same icon or things like that.

That's a good idea, it would be kind of like the MS Office Suite where there is a clear color association across the apps ie Excel-green, Word-blue, etc. If the location of the icons/functions do not change, then there shouldn't be an issue with the usability. Also, while developing, when I have both the download and the survey tool pulled up, having the same color theme makes it really confusing which tool I'm looking at sometimes. The user probably won't run into that issue though.

@trietmnj propose a color scheme for the download tool the blue house stays the same color, so make it feel good with the blue house. I dont generally like white color schemes.

How about the coloring in the middle picture? Gray with a shade of dark blue for the darker tone (banner) and grayish beige for the highlight? The lighter tone goes really well with the map natural color.

Can we make the popup the light gray color of the map  and loose the background and color on the state name.

Something like this?

Yes! beautiful.

make a pr and ask for review.


Moicylinder

Moment of inertia blurb and github link ready to rumble.

Do you want to put the picture in the post? (could look nice)
If not, we probably want to remove it from the PR.

The picture seems so out of context without the equations... Wouldn't you agree?

Yup. I'll delete the picture and merge, then.


As a User, the app should behave correctly whitout any unpredictable behavior, so I can have a smooth experience

PR #171
PR #163
PR #133
PR #141
PR #159
PR #132
PR #127
PR #128
PR #136
PR #131
PR #134
PR #168


Notify user in discord

Hello,
I use your functions,but I can't notify user when I sent a meassage to discro. Coudl you help me perhaps?

User should subscribe to channel to get nottified.

I find my answer :)

To notify anybody by webhook, we need to use the "real" id of user (recover in discord with @<username>) and use $msg="<@id_recovered> ..."

Thank you!


Add import to code snippets - https://docs.serverless-stack.com/migrating-from-serverless-framework#sqs

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


[Enhancement] Add yarn as a pkg manager.

Feature Request
Look into https://github.com/yarnpkg/yarn and use it inside covalent.

Some nice docs on usage: https://yarnpkg.com/en/docs/usage
And command comparison between npm and yarn: https://yarnpkg.com/en/docs/migrating-from-npm

Already using this on my fork, install is faster as you would expect. No breakage from changes in packages due to the deterministic nature of yarn.
Throw in a little guidance on how far you want this yarn'd i.e just the lock, lock + travis, "all the things" and i'll throw up a PR.

Awesome! For now i think just the lock + travis would suffice. 😄


Can not get the lang patch resource pack to work

As per title, I can not get the resource pack you linked to get the enchantments to be in number format e.g. Fortune 8
{
"langpatch.conf.enchantment.default.type": "default",
"langpatch.conf.potion.default.type": "default"
}
Any help would be appreciated

Greetings,
The Vanilla resource pack has already defines enchantment.level.<1~10>, which ain't be overridden by LangPatch. In fact, LangPatches for enchantments/potions never override any language keys that are defined in loaded resource pack(s).
To solve this, simply make a language file on your own which overrides level 1 to 10, and the rest (11 or above) are taken charge of by the mod itself.


Drop rustc-serialize dependency

It has been deprecated: announcement.
Is there any functionality you would require from another library before this would be possible?

Thanks @dtolnay! I'm aware it has been deprecated. It's a bit finicky to remove because we want a different serialization strategy to be used when serializing to JSON versus when serializing using bincode. I don't know if there's an easy way to do that that I've overlooked?

I didn't look at the codebase too closely but maybe something like this? #18


Renamed: MockRedisClient

Description
Renamed: MockRedisClient
Context: we'll need to introduce mocked Redis pipeline soon
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Unit tests

/lgtm

/approve


[core-amqp] only compute retry delay when retrying

Add a small optimization that only computes the delay if we are retrying.

Notice this while debugging.  Worth doing?


[feat] Log parent package when erroring during dependency install

When installing a package that pulls in additional dependencies, and a dependency of those dependencies fails to build, there is no indication of which parent package required the failing package or version.
It would be helpful if the chain of package dependencies was shown for failing packages, that way it is easier to find the problematic package and fix any version issues.
Currently, a failing dependency install looks like this. numba is not directly required in pyproject.toml or by pyannote-audio
[1/2] STEP 12/13: RUN uv pip install -r pyproject.toml     --no-cache --override overrides.txt     pyannote-audio
Resolved 136 packages in 1.37s
error: Failed to prepare distributions
  Caused by: Failed to fetch wheel: numba==0.53.1
  Caused by: Build backend failed to determine extra requires with `build_wheel()` with exit status: 1
--- stdout:

--- stderr:
/tmp/.tmpXEpsT6/built-wheels-v3/index/b2a7eb67d4c26b82/numba/0.53.1/pa9iWh_E6d_DuuXIyvWlT/numba-0.53.1.tar.gz/versioneer.py:335: SyntaxWarning: invalid escape sequence '\s'
  LONG_VERSION_PY['git'] = '''
Traceback (most recent call last):
  File "<string>", line 14, in <module>
  File "/tmp/.tmpXEpsT6/builds-v0/.tmpLn5qoW/lib/python3.12/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
    return self._get_build_requires(config_settings, requirements=[])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/.tmpXEpsT6/builds-v0/.tmpLn5qoW/lib/python3.12/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
    self.run_setup()
  File "/tmp/.tmpXEpsT6/builds-v0/.tmpLn5qoW/lib/python3.12/site-packages/setuptools/build_meta.py", line 503, in run_setup
    super().run_setup(setup_script=setup_script)
  File "/tmp/.tmpXEpsT6/builds-v0/.tmpLn5qoW/lib/python3.12/site-packages/setuptools/build_meta.py", line 318, in run_setup
    exec(code, locals())
  File "<string>", line 50, in <module>
  File "<string>", line 47, in _guard_py_ver
RuntimeError: Cannot install on Python version 3.12.5; only versions >=3.6,<3.10 are supported.
---
Error: building at STEP "RUN uv pip install -r pyproject.toml     --no-cache --override overrides.txt     pyannote-audio": while running runtime: exit status 2

Makes sense to me, I like the idea.


RequireConfirmedAccount for Identity doesn't send an email.

In the Razor Page code file for Identity's External Login process, an account confirmation email is only sent if account confirmation isn't required. Here's part of the source in question:
if (_userManager.Options.SignIn.RequireConfirmedAccount)
{
    return RedirectToPage("./RegisterConfirmation", new { Email = Input.Email });
}

// -snip-

await _emailSender.SendEmailAsync(Input.Email, "Confirm your email",
    $"Please confirm your account by clicking here.");

This can be verified by checking against the source for the RCL version, here. I think the order just needs to change to match that.
I can provide a PR for this, if it gets confirmed as a real issue. @HaoK Could you verify what I've stated here, please? I just spotted this when looking through the code, so I might have missed something.

Sure you can submit a PR, this is a change we took for servicing and it hasn't been ported yet, so that'd be great thanks @serpent5


Use proper condition when displaying ahead prompt

The copy seems to have diverged quite a bit, maybe I should just copy the whole file instead?


go-swagger mixin outputs json with the --format=yaml option

Problem statement
go-swagger mixin outputs json with the --format=yaml option.
Steps to reproduce
From the root of this repo the following is expected to generate (nicely formatted) YAML:
go run<EMAIL_ADDRESS>mixin --format=yaml --output /dev/stdout examples/authentication/swagger.yml examples/stream-server/swagger.yml

Instead the following is outputted:
2022/08/30 12:06:59 args[0] = examples/authentication/swagger.yml
2022/08/30 12:06:59 args[1:] = [examples/stream-server/swagger.yml]
{"consumes": ["application/keyauth.api.v1+json", "application/json"], "produces": ["application/keyauth.api.v1+json", "application/json"], "schemes": ["http"], "swagger": "2.0", "info": {"description": "Example server for emitting newline delimited JSON", "title": "keyauth debug", "version": "0.3.0"}, "basePath": "/api", "paths": {"/customers": {"get": {"tags": ["customers"], "summary": "Get a customerId given an SSN", "operationId": "getId", "parameters": [{"name": "info", "in": "body", "schema": {"$ref": "#/definitions/social_id"}}], "responses": {"200": {"description": "OK", "schema": {"$ref": "#/definitions/customer"}}, "401": {"description": "unauthorized", "schema": {"$ref": "#/definitions/error"}}, "404": {"description": "resource not found", "schema": {"$ref": "#/definitions/error"}}, "default": {"description": "error", "schema": {"$ref": "#/definitions/error"}}}}, "post": {"tags": ["customers"], "summary": "Create a new customer to track", "operationId": "create", "parameters": [{"name": "info", "in": "body", "schema": {"$ref": "#/definitions/customer"}}], "responses": {"201": {"description": "created", "schema": {"$ref": "#/definitions/customer"}}, "default": {"description": "error", "schema": {"$ref": "#/definitions/error"}}}}}, "/elapse/{length}": {"get": {"description": "Count down the seconds remaining", "summary": "Count down the number of seconds", "operationId": "elapse", "parameters": [{"maximum": 30, "minimum": 2, "type": "integer", "description": "How many seconds to count down", "name": "length", "in": "path", "required": true}], "responses": {"200": {"description": "Secondly update on remaining time", "schema": {"type": "string", "format": "binary"}}, "403": {"description": "Contrived - thrown when length of 11 is chosen"}}}}}, "definitions": {"Mark": {"type": "object", "required": ["remains"], "properties": {"remains": {"type": "integer"}}}, "customer": {"type": "object", "required": ["customerId", "name", "surname", "ssn", "fipsCode"], "properties": {"agentId": {"description": "agent associated with this customer", "type": "integer", "format": "int32"}, "customerId": {"description": "internal identifier of a customer", "type": "integer", "format": "int64", "readOnly": true}, "fipsCode": {"type": "string", "format": "string", "minLength": 1}, "name": {"type": "string", "format": "string", "minLength": 1}, "ssn": {"description": "Lookup identifier to find a customer in the system", "type": "string", "format": "string", "minLength": 11}, "surname": {"type": "string", "format": "string", "minLength": 1}}}, "error": {"type": "object", "required": ["message"], "properties": {"code": {"type": "integer", "format": "int64"}, "fields": {"type": "string"}, "message": {"type": "string"}}}, "principal": {"type": "string"}, "social_id": {"type": "object", "required": ["ssn"], "properties": {"ssn": {"type": "string", "format": "string", "minLength": 11}}}}, "securityDefinitions": {"key": {"type": "apiKey", "name": "x-token", "in": "header"}}, "security": [{"key": []}]}

Strictly speaking it is YAML, but not the YAML that was expected :laughing:
Environment
swagger version: 0.30.0
go version: 1.17.10
OS:   linux

same issue for swagger flatten

I ran a git bisect and found that this was introduced with c6796a61a9480af3ca7439cabfa85e894d2c236b

it's as a result of upgrading to yaml.v3 in the swag package. I got something mostly working locally for mixin, I'll check flatten as well.

Could you give the branch issue-2817 a try?
go run github.com/go-swagger/go-swagger/cmd/swagger@issue-2817 <your args here>

it still introduces a change to the yaml output, as it adds a type tag to the number values. Let me know if that's acceptable otherwise I'll have some more work to do


DVE-2017-0011: GitBook CDN nameservers return A records on any QTYPE

@oerdnj I updated your Zendesk Ticket following a deploy last night.
@jelu @oerdnj Do you think you guys could rerun your tests ? With the new changes our DNS now only responds to DNS queries with the following:

QClass is ANY or INET
QType is ANY, A or AAAA

All other queries get rcode=NOERROR with no answer records. Any unexpected errors that happen on our end whilst processing the query now currently return rcode=SERVFAIL

@AaronO There's a great tool called ZoneMaster that can help you with the basics of DNS protocol: https://www.zonemaster.net/test/eb9ee1ee90c5b526
But right now it fails, because you don't handle NS queries.
BTW, since you write your DNS in Go, are you aware of CoreDNS (https://coredns.io/)?

@oerdnj Do you mean that if fails because I don't return the SOA on NS queries ? Or that for dig IN NS cdn.gitbook.com @ns1.gitbook.me. I should return two NS records : ns1.gitbook.me and ns2.gitbook.me ?
Yep I'm aware of CoreDNS, but the master nodes of our CDN do a few extra things on top of answering DNS queries, such as:

Tracking healthy edge nodes (edge nodes send heartbeats to the master nodes)

So if an edge node is down it can't be returned in DNS replies

DNS geo-balanced replies (matching the closest healthy edge node to the user)
Providing an API to control edge nodes (cache clearing, etc ...)
Provisioning SSL certs
Auto-clustering via etcd

That's all nicely packaged and deployed as a single binary. Maybe we could re-use some code from CoreDNS, but I wouldn't want to use it through it's binary and config files, because that would make things harder to maintain and develop than our current setup.

Or that for dig IN NS cdn.gitbook.com @ns1.gitbook.me. I should return two NS records : ns1.gitbook.me and ns2.gitbook.me ?

This ^^^
I am not forcing CoreDNS upon you. It's just ... DNS seems simple at first, but it is hard :), so reusing as much code as possible might prevent some of the mistakes already encountered by others.

We started and maintain this list exactly for the reason for others to see what tiny little mistakes have other people made (without judging anyone), so the new implementors could avoid making them.
@AaronO Also I would like to express yet again, that I appreciate the fast response and will to fix your DNS implementation!

@AaronO If you have special domain names which you would like to control then RRs for there are ways of doing it within the authoritative nameserver software that exists today, Knot-DNS has Lua as do PowerDNS and the PowerDNS team also made dnsdist which can act like a proxy.

Thanks, I'll get that NS fix out sometime later this week.
Sorry if that came across as agressive, CoreDNS is cool, we actually use the developer's underlaying dns library :) So I'll look into using some of CoreDNS' code if possible.
I totally agree, the devil is in the details, I appreciate the community effort to help DNS implementations become standards compliant, hopefully avoiding


[Bug]: Non-Obvious Failed Validation on Form Options

What happened?
If you edit a form field's options and there is a validation issue, but the accordion is not expanded for that particular option, it's not apparent that it failed validation.

These screenshots were taken in order, the only difference being that the Accordion was open in the second one.
How to reproduce the bug
The images above tell the story fairly well, but to spell it out in detail:

Open field options.
Enter options that do not fit validation. The easiest one I found is leaving the "Data Validation" field blank on TextInput.
Collapse all Accordions or open a different Accordion than the one you know has the validation issue.
Submit options modal form.

Modal won't close, so it's obvious that something errored, but it's difficult to tell what without expanding the Accordion(s).
Package Version
3.0.52
PHP Version
8.2.19
Laravel Version
11.10.0
Which operating systems does with happen with?
macOS
Notes
This was truthfully reproduced on the custom-schema branch, but it is up to date with the 3.x branch, and I don't see any reason why this feature branch would impact this aspect of the UI.
I'm unfamiliar with the Accordion internals, but it should be as "simple" as bubbling up the error to highlight the section and indicate an error inside.
Edit: Added some horizontal lines around the images. They were bleeding together, making it hard to see which was which.

hopefully this will fix the issue, just do a composer update and check :)


update() method doesn't raise an error when key does not exist

Describe the bug
The update() method of Version2() class does not raise an exception when the key does not exist.
To Reproduce
Steps to reproduce the behavior:
import config_handler

a = config_handler.Version2("temp.config")
a.new("Test", "someone")
a.load()
a.add("thisexists", "arr", [1, 2, 3], "int")
a.update("thisdoesnotexist", "anything")  # The key does not exist in the dictionary.

Expected behavior
update() method must raise an exception when the key does not exist in the dictionary.

Advanced mode (formerly Version2) is now simplified. The available methods to call are set() and get().


Draft mini-language spec

Needs to be available for any sort of release, even a v0.1. Otherwise, nobody will know how to test it out!

Completed as of 1c589df.


more precise modules list

add info for HW-0815 -> can be found as "BS01 or MT-3608"
push buttons are D6R30F1LFS

changed buttons again, to have better mounting options


Change to use new ClimaParameter handling

We should apply the new clima parameter handling. An example of how to do this is in this PR.
A success metric for closing this issue involves:

Having a centralized module for where clima parameters from dependency packages can be accessed (see, e.g., CloudMicrophysics.jl's Parameters module, which forwards methods for handling thermodynamic variables).
Removing Land.jl's dependence on CLIMAParameters (i.e., using CLIMAParameters / import CLIMAParameters does not live in Land/src/).
All parameters that were previously obtained from CLIMAParameters methods are obtained from the CLIMAParameters toml file

It may be more efficient to clean up / remove any old / unused code / tests before applying these changes since it's a bit involved.

refer to #70


Info and Navigation

GIVEN I need to sample a potential employee's previous work
WHEN I load their portfolio
THEN I am presented with the developer's name, a recent photo or avatar, and links to sections about them, their work, and how to contact them

All sections complete. Not using real name or photo on this page.


Missing support for fish

There is fish_command_not_found handler, which can be reprogrammed in /usr/share/fish/vendor_functions.d to do The Right Thing™ (whatever it is).

Tried in a freshly installed Tumbleweed and it works right after zypper in cnf fish
michal@tumbleweed:~> fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
michal@tumbleweed ~> cmake

The program 'cmake' can be found in following packages:
  * cmake-full [ path: /usr/bin/cmake, repository: repo-oss ]
  * cmake-mini [ path: /usr/bin/cmake, repository: repo-oss ]

Try installing with:
    sudo zypper install <selected_package>

There's an integration test verifying the fish support, see https://github.com/openSUSE/cnf/blob/main/test/test.bats#L66C34-L66C94 - the /usr/share/fish/functions/fish_command_not_found.fish should be sourced automatically and it calls /usr/bin/command-not-found on SUSE systems, which is provided by cnf.rpm.
michal@tumbleweed ~> grep -A 3 suse /usr/share/fish/functions/fish_command_not_found.fish
else if contains -- suse $os || contains -- sles $os && type -q command-not-found
    function fish_command_not_found
        command-not-found $argv[1]
    en
michal@tumbleweed ~> rpm -qf /usr/bin/command-not-found
cnf-0.6.0~0-3.2.x86_64

You are right, I had to have something screwed up. SOrry.


cannot open the game , crashes after start game

Describe the bug
A clear and concise description of what the bug is.
Screenshots
If applicable, add screenshots to help explain your problem.
System Information (please complete the following information):

macOS:1 4.5 (23F79)
Device: macbook pro 2022
CPU: Apple M1 Pro

RAM: 16

Additional context
Add any other context about the problem here.
Logs (if any)

If it's related to the launcher, upload neutralinojs.log in Yaagl Data Directory

If it's related to the game, upload `logs/game_{timestamp}.log in Yaagl Data Directory

We can't see the screenshot.

https://ibb.co/HxD54DD

I have uploaded the image here :   https://ibb.co/HxD54DD

Try toggling ac patch

what I do now I can't open it

Reinstall launcher, make sure to delete yaagl os folder in /Application support


MINOR: Updating files with latest release 2.7.0

Changes to trunk for the 2.7.0 release
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping one of  @ijuma @mjsax @vvcephei

Merged #9772 into trunk


Fix leaked completions (leading to leaked calls in thread_stress_test)

LGTM. I'll keep an eye out for greenness.


Where is the ImageEditor cropped file on Android?

As far as I know , ImageStore is not implemented on android , but when I crop an image by ImageEditor.cropImage()  it saves the Image somewhere like this
file:///data/user/0/com.shopfort/cache/ReactNative_cropped_image_1980504058.jpg

And the uri is valid also as the image is displayed for it . But when I look for the image manually on cache folder on my device , I can't find it there . Where is it actually stored and as react-native documentation says it's important to remove the image from ImageStore , is  it still applies to android ?
UPDATE
However I could find the file by react-native-fs and was able to unlink (delete) the file using RNFS.unlink() .
But will this approach going to clear the memory ?

@facebook-github-bot stack-overflow

@PARAGJYOTI you manage to get the cropped image path? I am working on it on android but no matter what I do the successURI is just null despite no error being thrown.

Hey @LEE19 , yes I managed it . Can you show me your code snippet?

crop() {
var cropData = {
offset: {
x: width * 0.25,
y: height * 0.45,
},
size: {
width: width * 0.5,
height: height * 0.1,
},
}
ImageEditor.cropImage(
this.state.path,
cropData,
(croppedImageURI) => {
this.setState({croppedImageURI: croppedImageURI});
console.log("succes");
},
(cropError) => {
this.setState({cropError: cropError});
console.log("fail");
}
);
}
thank you for your help

Seems everything good
But is that a remote image url? If it is it can be null due to remote url . And as far as I remember , uri is returned as a data object  like {data: 'file:///someurl' } . Try logging the uri or failures .

@PARAGJYOTI problem is that, even the console.logs are not being fired, it means that neither the success or failure callback functions were being called.

@PARAGJYOTI must i import ImageStore as well?

Did you fix the issue? I'm on the same problem


Strategy to upgrade my project the latest Discover (SDKs v68)

Hello,
so I have my project developed using the previous Discover release, prior to the release of the SDKs upgrades to v68.
What would be the preferred/suggested workflow to upgrade my project to the latest Discover release?
Thank you!
Carlo

It depends how much changes you have and how it differs from where you original forked from. I have a couple of suggestions:

If you forked from this repo you might be able to pull and merge, there might be some merge conflicts but it should be manageable.
You can add this repo as a remote to your repo, git remote add, pull latest main and try to merge to your project, or Cherry pick each commit and fix issues.
You can create a patch and apply them to your project. Clone an additional copy of this repo and git diff > {patchFile}.patch and the git apply {patchFile}.patch
Comparing to the commits directly in here can also help.

In all cases depending on the changes you made from the original you might encounter conflicts. In code it shouldn't be too hard to address, if you have conflicts in scenes or prefabs, I would suggest you open a fresh clone of the project and compare the inspector side by side. We didn't modify many prefabs and they are core prefabs that you might not have updated either.
Let me know how it goes.

Thank you @AlexThiv
I might go for a fresh copy then. I'll keep you posted.

@AlexThiv pulled a fresh new copy of the repo and rebuilt the project. It works nicely, thank you for updating it!


Edit and Continue means a lot of waiting

I'm writing a fairly sizeable Blazor Server app and sometimes, Edit and Continue leaves me waiting so long I have to kill VS 2022 and restart it. I'm sure this has been reported, just testifying that it can really affect work time.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9bd35f01-ab8a-78ff-028a-e3bac4370161
Version Independent ID: 40f17fad-6b3b-66b2-2644-a267a76b4cc9
Content: Stop Code Changes - Visual Studio (Windows)
Content Source: docs/debugger/how-to-stop-code-changes.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@bmusical -- Harvey, thank you for your feedback.  Please add this product-related issue here:

Report product issues to us via the Report a Problem tool that appears both in the Visual Studio Installer and in the Visual Studio IDE.
Use the new Suggest a feature for Visual Studio IDE menu item.
Suggest a feature, track product issues, and find answers in the Visual Studio Developer Community.


summarize function and last interval

Hello, folks!
We are working with Graphite and have data for 24 hours, one value per second (86400 points). We want to summarize they to 144 points and get one point for 10 minutes interval.
We are using following code:
http://xxxx:8000/render?format=json&from=-24hours&target=summarize(traffic.total.outgoing.bps,%2210min%22,%22avg%22,true)

But unfortunately it's not working as expected. We are getting summarized data for 23 hours and 50 minutes. But last 10 minutes from this interval (data arriving infinitely) missed from output.  They just ignored for some strange reasons.
We've played with last parameter "alignToFrom" and checked true and false. Both are not working well.
How we could add last 10 minutes interval to output?

There is illustration about this issue. I've graphed this both graphics at 22/34.
That's not summarized data. We have all data points up to 22/34.

That's data with applied summarize function. As you can see we have data only up to 22/30:

Graphite version: 0.9.12+debian-3

Hello, again!
Looks like I've found issue. It's related with function "summarize" from this file: https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/functions.py
I've traced this code and got following output:
Sat Apr 16 23:44:22 2016 :: Current timestamp<PHONE_NUMBER>
Sat Apr 16 23:44:22 2016 :: Bucket interval is:<PHONE_NUMBER>

As you can see we calculated bucket interval is lesser than current timestamp. That's because Graphite rounding down timestamp value when creating "bucket".
Actually data for last interval calculated correctly but we are using rounding down and store all this data on rounded down bucket (which lesser than current time for up to 599 seconds with 600 seconds interval).
For example for current timestamp<PHONE_NUMBER>, interval 600 we could store<PHONE_NUMBER>. So we store more recent data in bucket which older than this value in 240 seconds (in worst case this value lower than 599 seconds).
So I've changed folllwing code to (I've just replaced rounding down to rouding up):
bucketInterval = timestamp_ + (timestamp_ % interval)
newEnd = series.end + (series.end % interval) + interval
bucketInterval = timestamp_ + (timestamp_ % interval)

In this case we are using rounding up and will store data for latest 599 seconds in "future" value.
That's not perfect solution. As perfect solution we could align start and end of interval by interval value (in my case 600 seconds).
But it produces more complicated code and I could not implement proof of concept for it.

You're using a very outdated version of Graphite. I strongly encourage you to upgrade to 0.9.15 and try again. I don't think the problem you're seeing is with the summarize function at all, but rather with the way we were retrieving data in the first place. This was fixed in recent versions.
Note that although I feel pretty confident about this, I haven't actually dug through your problem and the associated code deeply because you're running such an old version of the Graphite stack.


Feature/WD-18 Features Pages

Description
Added features pages:

Upvote
Roadmap
FAQ
Showcase of the latter

Fixes WD-18
Type of change
Please delete options that are not relevant.

[X] New feature (non-breaking change which adds functionality)

Is the solution different from the one proposed during the grooming?
No.
How Has This Been Tested?

[X] Locally in browser

Checklist
Please delete the options that are not relevant.

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] My changes generate no new warnings

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced a dedicated Features page, including popular features with images, titles, and links.
Added an FAQ page for commonly asked questions.
Launched a Roadmap page to showcase upcoming developments.
Implemented an Upvote page to engage users in feedback and feature voting.

Enhancements

Enhanced the footer with a new "Features" section for improved navigation.

Documentation

Updated web routes to include new feature-related pages.

I tried fixing it, but it broke me internally. The problem I think is regarding the gradient or at least this is the most similar issue I found on StackOverflow.
P.S. I'm not leaving without an alternative. - A simpler solution, it isn't any similar to what you did, but it shows off one major feature and 2 less important ones. You can use something If it helps.

I'll check them out. Thanks!

@coderabbitai review


AI not use casus belli to take core state(s)

cb_types (acquire_core_state)
it does not work for the AI (against not sphered nations)
have tried it this with the basic game (acquire_core_state)  casus. what works
the Issue is the line i think:
NOT = { THIS = { ai = yes } part_of_sphere  = yes } # the ai shall not attack a sphered nation.
That is my suggestion:
OR = {
THIS = { ai = no }
part_of_sphere = no
}

The problem is that we should not use multiple conditions under one NOT as it means none of the conditions should be met.The AIs as they are,they cannot declare the war with this CB in any circumstances.It is of necessity to add an AND.

"Annex Core Country" need the same correction


amend: updated deps

:tada: This PR is included in version 2.5.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I finally managed to figure out how to force make to print more information, hence the traceback below:
Making src/NotoSansDevanagari' due to always-make flag. Must remake target src/NotoSansDevanagari'.
bash build.sh build_one src/NotoSansDevanagari
Putting child 0x02020b30 (src/NotoSansDevanagari) PID 28657 on the chain.
Live child 0x02020b30 (src/NotoSansDevanagari) PID 28657

Checking Glyphs source for illegal glyph names
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/lib/python2.7/dist-packages/fontmake/main.py", line 51, in
main()
File "/usr/local/lib/python2.7/dist-packages/fontmake/main.py", line 39, in main
project.run_from_glyphs(glyphs_path, **args)
File "/usr/local/lib/python2.7/dist-packages/fontmake/font_project.py", line 129, in run_from_glyphs
glyphs_source = self.preprocess(glyphs_path)
File "/usr/local/lib/python2.7/dist-packages/fontmake/font_project.py", line 46, in preprocess
with open(glyphs_path) as fp:
IOError: [Errno 21] Is a directory: 'src/NotoSansDevanagari'
Reaping losing child 0x02020b30 PID 28657
make: *** [src/NotoSansDevanagari] Error 1
Removing child 0x02020b30 PID 28657 from chain.

/cc @brawer @behdad

Looks like something that @jamesgk can fix. Just to clarify, “all other input files” means Monotype feature files?

all other input files={*GPOS.txt,*GDEF.txt,GSUB}

A user error (aka mine) because a directory which contains a glyphs file and {*GPOS.txt,*GDEF.txt,*GSUB*.txt} may contain more than one glyphs file. Each glyphs file might be associated with a subset of {*GPOS.txt,*GDEF.txt,*GSUB*.txt} files.
A mapping between an instance of a font is contained in the .plist file which contains all of the files required to build this font.
The two directories that didn't build were Myanmar related. The didn't build because we had no  .plist files there.
Closing the bug.


how do i install this im confused

Hey danny this is supposed to be a chrome extension you can install from a web store link, however I switched jobs while working on this program and it never got finished/published. Since then, pixiv has changed quite a bit and some of the assumptions this program makes are no longer valid. I'm going to come back to this and attempt to modernize it at some point in the near future but it is currently not ready for public use. Sorry about that.

No problem man do your best!

Hey @dannyx3 you (and anime) inspired me to pick this back up again. I have a version that builds and has a few of the old features working again. I'm doing a feature inventory and tracking it here with the initial issue here. I'll be going through the code and the old features to see what still works, what doesn't, and what needs to change with pixiv's updates.
You can install the extension here:
https://chrome.google.com/webstore/detail/pixiv-assistant-beta/lohdokmlnkfnkmnejklhjpidincnbfji
but the new version from today (0.3.0) is still awaiting review. Any lower version (the current 0.2.6, for example) will be very broken.


SourceRecordReader implementations should use milliseconds to create their records

Kafka record timestamps are defined in milliseconds, but the StreamSourceRecordReader class and the KeySourceRecordReader class use the following to create their records:
		return new SourceRecord(..., Instant.now().getEpochSecond());

These should be switched to Instant.now().toEpochMilli().
The effect is that when the source connector appends a message to a topic, if the topic has retention.ms set to a reasonable value, the messages are immediately deleted from the topic.
This can be worked around by setting the topic configuration value:
message.timestamp.type: LogAppendTime

Thanks for the quick turnaround. Any idea when will this make a release?

Thank you for your contribution. This is included in version 7.2.

🎉 This issue has been resolved in v0.7.5 (Release Notes)


Add sendManyCorrelated to ReactiveMessageSender

Fixes #22

Don't forget this PR :) pls
It's what I currently need

replaced by #115


Protocol for linux users

Write a protocol for how to modify and remix the repository for own work, from the perspective of a linux PC user with admin permissions.

This is going to be written on protocols.io
Users on windows machines will be directed to:

Simply get a linux computer
Install WSL to run ubuntu as an app


Migrations for postgresql

Few fixes so that migration works better with postgresql.
Also foreign key constraints to product table prevented use of different product model.

I have to close this because it's outdated. Thanks, @jrutila.


[WIP] Spellcheck

Initial stab at adding a spellchecker.

Proselint found issues
_posts/helllow.markdown

Line
Message
Severity

  Generated by :no_entry_sign: danger

Hrm - https://github.com/mtuchowski/mdspell
   artsy.github.com   danger_3 ✔  mdspell _posts/2016-01-26-swift-at-artsy.markdown                                                   14:01:21
_posts/2016-01-26-swift-at-artsy.markdown:3: 'Teaching
_posts/2016-01-26-swift-at-artsy.markdown:3: Artsy'
_posts/2016-01-26-swift-at-artsy.markdown:6: ios
_posts/2016-01-26-swift-at-artsy.markdown:6: oss
_posts/2016-01-26-swift-at-artsy.markdown:10: Orta
_posts/2016-01-26-swift-at-artsy.markdown:14: repo
_posts/2016-01-26-swift-at-artsy.markdown:14: Orta
_posts/2016-01-26-swift-at-artsy.markdown:19: genoming
_posts/2016-01-26-swift-at-artsy.markdown:23: iOS
_posts/2016-01-26-swift-at-artsy.markdown:25: chatroom
_posts/2016-01-26-swift-at-artsy.markdown:27: img
_posts/2016-01-26-swift-at-artsy.markdown:27: chatroom
_posts/2016-01-26-swift-at-artsy.markdown:27: png
_posts/2016-01-26-swift-at-artsy.markdown:29: Orta
_posts/2016-01-26-swift-at-artsy.markdown:29: TA'd
_posts/2016-01-26-swift-at-artsy.markdown:31: Xcode
_posts/2016-01-26-swift-at-artsy.markdown:31: Xcode
_posts/2016-01-26-swift-at-artsy.markdown:33: TA'd
_posts/2016-01-26-swift-at-artsy.markdown:33: Xcode
_posts/2016-01-26-swift-at-artsy.markdown:35: Orta
_posts/2016-01-26-swift-at-artsy.markdown:35: colleagues'desks
_posts/2016-01-26-swift-at-artsy.markdown:37: favourite
_posts/2016-01-26-swift-at-artsy.markdown:41: Orta
_posts/2016-01-26-swift-at-artsy.markdown:41: favorites
```

vs  https://www.npmjs.com/package/markdown-spellcheck

 artsy.github.com   danger_3 ✔  mdspell _posts/2016-01-26-swift-at-artsy.markdown -r                                                14:02:09
_posts/2016-01-26-swift-at-artsy.markdown
10 | While the Artsy engineering team includes man
10 | ngineers. So last Summer when Orta and I had some down time, it
14 | open-source-by-default.html). Orta and I chatted and realized th
19 | g – the digital marketing and genoming teams specifically were keen
29 | Orta taught the beginner course an
29 | ght the beginner course and I TA'd it, answering questions as he
31 | classes of both tracks: Swift 2 was in beta, and getting ever
33 | ing. It reminded me of when I TA'd intro-to-Java courses in Univ
35 | interest dropped off quickly. Orta would help by physically goin
37 | gnificant impact, both within Artsy and in the larger Swift commu
39 | ed down) data structures that Artsy actually uses. We presented p
41 | reat sense of accomplishment. Orta and I had taken time during a

12 spelling errors found in 1 file

Using my fork of markdown-spellcheck

   artsy.github.com   danger_3 ✘ ✹  mdspell _posts/2016-01-26-swift-at-artsy.markdown -r                14:58:51
    _posts/2016-01-26-swift-at-artsy.markdown
       10:193 | While the Artsy engineering team includes man
       10:505 | ngineers. So last Summer when Orta and I had some down time, it
       14:908 | open-source-by-default.html). Orta and I chatted and realized th
       19:1258 | g – the digital marketing and genoming teams specifically were keen
       29:2085 | Orta taught the beginner course an
       29:2123 | ght the beginner course and I TA'd it, answering questions as he
       31:2536 | classes of both tracks: Swift 2 was in beta, and getting ever
       33:2918 | ing. It reminded me of when I TA'd intro-to-Java courses in Univ
       35:3404 | interest dropped off quickly. Orta would help by physically goin
       37:3572 | gnificant impact, both within Artsy and in the larger Swift commu
       39:4379 | ed down) data structures that Artsy actually uses. We presented p
       41:4818 | reat sense of accomplishment. Orta and I had taken time during a

>> 12 spelling errors found in 1 file
```

hrm, those indexes ain't perfect, but it's better than nothing 👍


[Question C#] Update Nuget 3.5.8 PromptDialog.Choice + SuggestedActions on Skype

Probably I am just impatient. Sorry :-) Since my bot causes some random channel failures on Skype (the new context.UserData.GetValue might help) I like to test the new nuget version, but therefore PromptDialog.Choice needs to work (#2685).
So, here are my questions:

When are you planning to release a fixed version?
Will Skype support SuggestedActions? (I think quick replies are really useful)

Btw thanks for your work. You are doing a great job 👍.

You need to be on a recent version of Skype - https://web.skype.com/ supports suggested actions so please test there and let us know if you still see an issue.

So SuggestedActions are already implemented on Skype? Cool!
But currently they aren’t working for me? Probably, it’s an issue with my code:
IMessageActivity reply = context.MakeMessage();
List<CardAction> cardButtons = new List<CardAction>();
CardAction button1 = new CardAction()
{
Type = "imBack",
Title = buttonText1,
Value = buttonText1
};
CardAction button2 = new CardAction()
{
Type = "imBack",
Title = buttonText2,
Value = buttonText2
};
CardAction button3 = new CardAction()
{
Type = "imBack",
Title = buttonText3,
Value = buttonText3
};
CardAction button4 = new CardAction()
{
Type = "imBack",
Title = buttonText4,
Value = buttonText4
};
CardAction button5 = new CardAction()
{
Type = "imBack",
Title = "Cancel ❌",
Value = "Cancel ❌",
};
cardButtons.Add(button1);
cardButtons.Add(button2);
cardButtons.Add(button3);
cardButtons.Add(button4);
cardButtons.Add(button5);
reply.Text = text;
reply.SuggestedActions = new SuggestedActions(actions: cardButtons);

FYI - A new package with fix #2685 was just published (https://www.nuget.org/packages/Microsoft.Bot.Builder/3.5.9)

I opened a new issue #2712, since SuggestedActions still don’t work for me on Skype.


Cannot reopen websocket after calling $close()

ng-websocket will not allow you to re-open a websocket if you have called $close() on it. After working through the code I've found the problem is in the function $websocketService line 68:
if (typeof ws === 'undefined') {
If the socket was previously opened and then closed, then wss.$get() will return the ws that was closed, so ws is not equal to 'undefined' and it never actually trys to create a new WebSocket. I changed line 68 to:
if (typeof ws === 'undefined' || ws.$status() === ws.$CLOSING || ws.$status() === ws.$CLOSED) {
I can send a pull request if required.

Could this be noted in the documentation? After a few reads of the docs, I ended up making the same mistake as the original posted of this bug report. Only finding the bug report clarified things for me...
thanks! :-)

+1 — it's very surprising that $websocket.$new can return a closed websocket (and, in fact, also quite surprising that it $new will re-use existing sockets).

My fix has been monkeypatching $websocket.$get so it always returns undefined:
$websocket.$get = function() { return undefined; }

Ofc this isn't entirely backwards compatible… but also works around this otherwise remarkable behavior.


Small revisions and fixes For Wasm templates

This PR updates Wasm templates in the following ways:

makes the templates more consistent with each other
removes workflows (polywrap.test.yaml, cue file, and yarn scripts)
removes polywrap.deploy.yaml files
fixes bugs in the rust template
fixes bugs in the TS template
updated to latest app codegen in tests

The TS template doesn't build due to https://github.com/polywrap/cli/issues/1923
The Go template doesn't build due to https://github.com/polywrap/cli/issues/1925
For reasoning on why we would remove workflows: https://discord.com/channels/796821176743362611/1166324052164628560
I removed the deploy manifests because the default behavior of npx polywrap deploy is IPFS deployment. Since we are encouraging use of IPFS and Wrapscan URIs, most users will not need to customize deployment. Our documentation will provide ample guidance for users who do wish to use a deploy manifest.

I'm good with merging this, but the CI is still red for the templates, looks like some of them aren't properly building:
https://github.com/polywrap/cli/actions/runs/6706112620/job/18221943589?pr=1924


[Feature] Update train

Following pr#8461, pr#8480  and this commit in mmdet, 1. '--amp' option 2. auto-scale lr 3. auto-resume
are supported in this pr.

It's ok to me.


[Feature Request] Change encoding of volume number

Describe the bug
Every chapter of every series since the update to 1.3.5  has Vol -1000000 in its name
Expected behavior
For it to not be there
Screenshots

I'm also getting the same issue, however, I do notice that if I have a volume number defined, it then switches to the chapter being -100000.

Updated per #17 , will wait for it to be merged in

Thanks for your great work! I have reviewed and merged it to main.


Test native token wrapper interface

What problem does your feature solve?
Merged #338 without tests.
What would you like to see?
We need to figure out how to efficiently test this kind of thing. There's not really any machinery for preparing accounts/trustlines right now.
What alternatives are there?
N/A

Tests were added in https://github.com/stellar/rs-soroban-env/pull/525, but I'll leave this issue open as a reminder that we still need to audit the code and make sure the tests thoroughly cover all trustline and non-trustline scenarios.

@sisuresh , assigned this to you as you've reopened this. I suspect this can be closed now though.

Yeah this can be closed.


rspec on other_action returns undefined method trigger_action_by_name for nil:NilClass

New Issue Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Issue Description
When I am testing my own fastlane plugin via the provided bundle exec rake task, my tests fail with the following:
Failures:

  1) Fastlane::Actions::CustomConfigAction#run retrieves app config data
     Failure/Error: other_action.team_id(app.team_id)

     NoMethodError:
       undefined method `trigger_action_by_name' for nil:NilClass
     # ./lib/fastlane/plugin/custom_config/actions/custom_config_action.rb:31:in `run'
     # ./spec/custom_config_action_spec.rb:6:in `block (3 levels) in <top (required)>'

Looking at the code it looks like it is called via self.runner and should be loaded in. This works okay when actually running fastlane, however,  it fails when I run it via the supplied test setup.
I looked at #10675 which seems to look at improving the documentation for this, which is great.
As I basically look through #4707 and got it all working except for the rspec test above.
I will probably look at just returning the value of my action and call team_id from within the Fastfile itself, but it would be nicer if this could be more implicit and I would rather not copy all the environment variables and duplicate the team_id action within my code.
Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.6

Ruby
2.4.2

Bundler?
true

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.rbenv/versions/2.4.2/bin/fastlane

Host
Mac OS X 10.12.6 (16G29)

Ruby Lib Dir
~/.rbenv/versions/2.4.2/lib

OpenSSL Version
OpenSSL 1.0.2l  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-8.3.3.app/Contents/Developer/

Xcode Version
8.3.3

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.63.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-custom_config
0.1.0
💥 Check failed

Loaded gems

Gem
Version

did_you_mean
1.1.0

bundler
1.15.4

io-console
0.4.6

json
2.1.0

rake
12.1.0

CFPropertyList
2.3.5

public_suffix
2.0.5

addressable
2.5.2

ast
2.3.0

babosa
1.0.2

claide
1.0.2

coderay
1.1.2

colored
1.2

colored2
3.1.2

highline
1.7.8

commander-fastlane
4.4.5

safe_yaml
1.0.4

crack
0.4.3

declarative
0.0.10

declarative-option
0.1.0

diff-lcs
1.3

docile
1.1.5

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

dotenv
2.2.1

excon
0.59.0

multipart-post
2.0.0

faraday
0.13.1

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

fastimage
2.1.0

gh_inspector
1.0.3

jwt
2.1.0

little-plugger
1.1.4

multi_json
1.12.2

logging
2.2.2

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.1

httpclient
2.8.3

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.1.0

representable
3.0.4

retriable
3.1.1

google-api-client
0.13.6

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.3.0

rubyzip
1.2.1

security
0.1.3

slack-notifier
1.5.1

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

tty-screen
0.5.1

word_wrap
1.0.0

nanaimo
0.2.3

xcodeproj
1.5.3

rouge
2.0.7

xcpretty
0.2.8

xcpretty-travis-formatter
1.0.0

fastlane-plugin-custom_config
0.1.0

hashdiff
0.3.7

method_source
0.9.0

parallel
1.12.0

parser
<IP_ADDRESS>

powerpack
0.1.1

pry
0.11.1

rainbow
2.2.2

rspec-support
3.7.0

rspec-core
3.7.0

rspec-expectations
3.7.0

rspec-mocks
3.7.0

rspec
3.7.0

ruby-progressbar
1.9.0

rubocop
0.50.0

simplecov-html
0.10.2

simplecov
0.15.1

webmock
3.1.0

generated on: 2017-11-01

@jdee it looks like you are using other_action, did you run into this issue? If so, how did you solve it?

I'm getting this as well, did you manage to fix this @svanzoest ?

@Vivekxk I did not. I worked around it for now. I'd love to do this correctly though.

So, my work around is as follows:
   results = Fastlane::FastFile.new.parse("lane :test do
       app = custom_config(params)
   end").runner.execute(:test)

The above gives other_action the right context apparently, which causes my test to pass.

@svanzoest @Vivekxk Sorry I missed the @ mention. Too many notifications!
Is this only happening in tests? One thing you might think about doing in unit tests is mocking calls to other_action. This better separates code units anyway. Something like:
other = double :other_action
expect(action).to receive(:other_action) { other }
expect(other).to receive(:team_id).with "ABCDEFG"

Or you can do something with fixtures, but either way you're not actually calling the team_id action in your tests. There also may be a way to set something in your spec_helper or in your tests that makes other_action work in a test environment. I'll post it here if I find something like that.
There is an issue with calling actions from dependent plugins in your plugin: #9917. But it looks like you're only calling the built-in team_id action.

@jdee yes, it works fine outside of tests. So your mock example helps a lot.  I haven't done enough mocking for something like that to come that easily. :)

Here's some more involved mocking if you want more examples:
https://github.com/BranchMetrics/branch_io_cli/blob/master/spec/ios_helper_spec.rb#L211
https://github.com/BranchMetrics/branch_io_cli/blob/master/spec/ios_helper_spec.rb#L302
That tests verification of a signed apple-app-site-association file using PKCS7 by mocking not only the HTTP request but also the verification by OpenSSL.
And of course see the RSpec docs: https://relishapp.com/rspec/rspec-mocks/docs


Filter failed and Broken pipe (DNP DS620)

Before you write the report
Read the REPORTING_ISSUES.md file in the main repository and prepare data mentioned there which looks relevant to you issue.
Describe the bug
Task stopped and show "Filter failed" error.
In logs, got cfFilterGhostscript: Unable to open raster stream - : Broken pipe
Screenshots

System Information:
Ubuntu 24.04
Firefox up-to-date
Gutenprint 5.3.5-pre1
CUPS 2.4.7
Additional context
EDIT zdohnal: Github accepts .txt files as attachments - if the log is longer than 10 lines it is more readable to attach .txt file with log -
error-log-1121.txt

Hi @theamnesic ,
I have tried to reproduce the issue with CUPS 2.4.11, gutenprint 5.3.5pre1, cups-filters 2.x and ghostscript 10.02.01 - I can't get the error you see, but based on the other logs:
146 D [12/Dec/2024:16:41:15 +0100] [Job 276] PID 8741 (/usr/lib/cups/filter/rastertogutenprint.5.3) crashed on signal 11.

and the fact the Ghostscript error you see if generated when output pipe can't be opened and the ouput pipe from ghostscript in this filter chain goes to rastertogutenprint.5.3, it looks the gutenprint filter died first, so it looks like issue in the filter.
It would be great if you reported this to Gutenprint folks - you can try their mailing list , or there is bug tracker on Sourceforge.


Add bio and avatar to website for Sarah

Add my bio and avatar to the website - relates to https://github.com/2i2c-org/team-compass/issues/116

[x] TODO: Add 2i2c email once it has been set up

I don't mind having a professional email out there, especially in this world where we're not meeting anyone to swap addresses :)

@sgibson91 do you want to press the green button :wink: ?

Yay, thanks everyone!


Vue emits "Extraneous non-emits event listeners" warning for events on RouterView

Reproduction
https://stackblitz.com/edit/vitejs-vite-jy1j3d
Steps to reproduce the bug
Listen for an event on router-view which is emitted by a child component.  Vue will display a warning about "Extraneous non-emits event listeners" even though a child component emits the event, if the initial path loaded renders a child component that doesn't emit the event.
Expected behavior
Vue detects that one of the child components that may be rendered by the router view emits the event, and doesn't give the warning.
Actual behavior
Vue gives the warning.
Additional information
No response

This is not related to the router: the Home component doesn't declare that emit, that's why so you see the warning

@posva But why should the Home component need to?  There needs to be a mechanism to allow any child component that may be rendered by a router-view to emit events through the router-view.


proxy: iterate modified request handling

had an API bug where updating a token and then requesting it again returns the previous token. Also have other branches which require use of the flattened request.
I was originally doing this using a lot of lua but just copying the string a few times has some better properties:

should actually be faster with less lua + fewer allocations
can be optimized to do minimal copying (avoid keys, append new flags, etc)
might be optimized to avoid re-parsing (or do minimal re-parsing) in some cases.

TODO:

[ ] A few more tests before merging.
[ ] Update docs to reflect that updated tokens are now returned.

need this to support updated request objects in the internal code, but it was easy to split out so I'm reviewing and merging it ahead of the main change.

Fixed an off-by-one in raw token access.
Made sets work and armored against some buffer issues.

Fixed excess space when removing tokens.
Blast radius is limited with this code. Need to do better test suite soon.

Think this change is done... I did a bunch of tests and fixed/updated a few things. need to merge it soon since it fixes a confusing API bug.

I've tested this a bunch. real unit tests would improve confidence more and I will fill those in soon...
I'm going to merge this to next now. The code is a lot simpler and it fixes a real bug that I keep running into.


Correct indention of example github_automerge_feature

I would have saved two hours today if I was just looking at this closely. I'm surprised I didn't get a syntax error every time I tried to run a CCI command or at least do the info command for github_automerge_feature.

Julian, I do see a warning:

I actually just started seeing this today so please disregard the part about no warning 🤷🏽. Maybe I was using an older CCI version on a different computer.


HDDS-6058. Bump aws-java-sdk to latest 1.12

What changes were proposed in this pull request?
Upgrade aws-java-sdk to 1.12.
https://issues.apache.org/jira/browse/HDDS-6058
How was this patch tested?
CI
https://github.com/adoroszlai/hadoop-ozone/actions/runs/1526858610

Thanks @ayushtkn for the review.


feat(nx-cloud): setup nx workspace

feat(nx-cloud): setup nx cloud workspace
This commit set up Nx Cloud for your Nx workspace enabling distributed caching
and GitHub integration for fast CI and improved Developer Experience.
You can access your Nx Cloud workspace by going to
https://cloud.nx.app/orgs/670f1d733124545da3595ecc/workspaces/670f1d8b22b1a18844d39587
Note: This commit attempts to maintain formatting of the nx.json, however you may need to correct formatting by running an nx format command and committing the changes.

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MXFileStore takes too long time to open and call onStoreReady callback

When the mainactivity is created i open the store. it takes 5 seconds the store to be ready. if i close the app and open it again, it takes 5 seconds again the store be ready. in this 5 second till store be ready, just few KB transfers through network.
whats the problem that store takes too long to be ready?

The store de-serializes all data that has been stored in files. It can take a long time to be performed.
This is one of the reason why we are entirely rewriting the APK in RiotX.


window.open not working on iOS

Short description of the problem:
When clicking on the "Tweet" button in the speakers list on iOS, nothing happens. window.open in goToSpeakerTwitter in speaker-list.ts does nothing.
What behavior are you expecting?
The page opens in an external browser.
Steps to reproduce:

Open the "Speakers" page.
Click on "Tweet" of speaker "Burt Bear"

goToSpeakerTwitter(speaker) {
    window.open(`https://twitter.com/${speaker.twitter}`);
}

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.3.0
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.36
Ionic App Lib Version: 2.0.0-beta.19
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3 Build version 7D175

Added the InAppBrowser plugin which now opens the link externally in iOS. Please let me know if this still isn't working for you with the latest code, thanks!


Entity stuff, see #1905

Supersedes #1905, mapping entity stuff

hmm, someone mind review this one, like point out the problems?


Make order of KubernetesDiscoveryClient configurable

Currently there is no possibility to define the order for KubernetesDiscoveryClient via property.
This is already possible for the SimpleDiscoveryClient and EurekaDiscoveryClient.
When the discovery client is used as delegate of a CompositeDiscoveryClient this could be useful.

See pull-request #538


How can I disable auto-includes on completion?

Hi
https://github.com/clangd/vscode-clangd#include-management

Code completion works across your codebase and adds #include directives where needed

Code completion adds too many includes. How can I disable adding includes on using completion?
Thank you
UPD: Steps

Insert fo
Press Enter

Actual behaviour:

fo was replaced with foo
#include "foo.h" was added

Desired behaviour:

fo was replaced with foo

Actual behaviour:

fo was replaced with foo
#include "foo.h" was added

Actual behaviour:

fo was replaced with foo

Did you mean desired behaviour in the second case?
To disable the header insertion, pass --header-insertion=never (default is iwyu) to clangd.
Either way, we're interested why you don't find this feature useful: is it adding the includes that are actually not used or is it just a matter of the code style in your codebase? If it is, do you use umbrella headers instead or is there any other reason to not include the used headers directly?

Oh, and since you're using the VSCode extension, the way to pass flags is putting the following into settings.json:
  "clangd.arguments": [
    "--header-insertion=never"
  ],

Did you mean desired behaviour in the second case?

Yes, my bad. Excuse me please.

is it adding the includes that are actually not used

No, all of them are actually used.

is it just a matter of the code style in your codebase?

Probably it is right description.

sometimes feature includes "something_fwd.h" files - in this cases common header is required
always feature includes header,  which already was included from other included header - i.e., for string. It is not our style
feature adds #include "....h" but codestyle requires #include <....h> - from project root

--header-insertion=never helped a lot. Thank you very much


Update to 5.2.0-wp-2

I didn't realize that we had already created a 5.2.0-wp-1 tag when I updated to that version (commit, PR). Bumping the version and rebuilding the tarball just so I can tag the merge commit from this PR with 5.2.0-wp-2 (that seemed better than moving the 5.2.0-wp-1 tag even though I don't think we're using it).

Shall we remove the 5.2.0-wp-1 tarball? I think that we access the tarball via the tag/hash anyway and only 1 tarball would need to be avail in the file tree?

Shall we remove the 5.2.0-wp-1 tarball? I think that we access the tarball via the tag/hash anyway and only 1 tarball would need to be avail in the file tree?

Thanks for catching that. Leaving that was just a miss on my part. Should be gone now.

PR looks good to me Matt, wondering if you have a gutenberg-mobile PR to test it from, just to be sure that it can be consumed correctly?


ENYO-5245: Fixed not focusing scroll buttons from items via 5way

Issue Resolved / Feature Added
Fixed not focusing scroll buttons from items via 5way
Fixed not focusing next items via 5way
Resolution
When VirtualList's container's width happened to have a value between x.5 ~ x.0, the content of VL and scroll buttons seem to overlap.
To remedy this, when we set the content width/height of VL, minus 1px to make sure the item and scroll buttons can't overlap.
Links
ENYO-5245, PLAT-58103
Comments
Enact-DCO-1.0-Signed-off-by: Mikyung Kim<EMAIL_ADDRESS>

LGTM


about android with Flutter Mixture develop

When I only run flutter module , pick image very fast and nice.
But when android with flutter mixture develop ：
print('start');      ✅
var image = await ImagePicker.pickImage(source: style);    ❌
print('111111111111111');     ❌

or
print('start');      ✅
ImagePicker.pickImage(source: style).then((file){ doSomething...});    ❌
print('111111111111111');     ✅

logcat:
I/flutter: start
I/Timeline: Timeline: Activity_launch_request time:94986931 intent:Intent {act=android.intent.action.GET_CONTENT typ=image/* }
D/LogServer: foreground switch background
D/LogServer: background to foreground
and no other error

use image_picker: ^0.4.12+1
because AndroidX need 28 ,but 28 have a bug about edit

Hi @moonway0127
are you still experiencing this issue with the latest version of Flutter?
If so can you please provide your flutter doctor -v?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.


Mangakakalot

Source information
1.4.8
Source language
English
Source new URL
Https
Other details
https://chapmanganato.to
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

This is a mistake. Please reopen


[$500]  Deeplinks - Public room conversation opened when tapped on user share profile deeplink

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open app
Sign Out
Paste this link in other app (messenger or notes) https://staging.new.expensify.com/r/3504895439653267
Click on the deeplink from previous step
Once app opened and public room displayed as a guest click on Sign In button
Sign In with valid account
Click back button to navigate to LHN
Kill the app
Paste this link in other app (messenger or notes) https://staging.new.expensify.com/a/15548487
Click on the deeplink from previous step

Expected Result:
User profile should be displayed
Actual Result:
Public room conversation opened
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/2a4fb900-4a1d-43c1-aad0-1854337f7f8e
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f7fa12128d4cc313
Upwork Job ID:<PHONE_NUMBER>381797888
Last Price Increase: 2023-11-11

Related, maybe same rca: https://github.com/Expensify/App/issues/31150

Please re-state the problem that we are trying to solve in this issue.
Universal deeplinking for profile page
What is the root cause of that problem?
Noticed that as of today, current implementation for universal linking seems to be only supporting chat report and no other pages(Ref). so links starts with https://*.new.expensify aka universal linking only supports chat report which may not be the case for traditional deeplinking(starts with new-expensify://*).
Addressing this issue might mean, setting up universal deeplinking support similar to linkingConfig by extending  Linking.getInitialURL().
What should be the next step here if this is known limitation?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~015764c2295330a830

The proposal made by @dukenv0307 looks good and the root cause and the solution makes sense to me!
https://github.com/Expensify/App/issues/31239#issuecomment-1807199905
🎀 👀 🎀 C+ reviewed

I checked https://github.com/Expensify/App/issues/31239#issuecomment-1812931346 and it's the current behavior on staging/main.
IMHO it makes sense if the public room opens after i killed the app then reopened it and i am not confident removing the current behavior. @dukenv0307's proposal will fix this issue while keeping that behavior.
@bernhardoj to know whether we should remove this behavior or not could you raise this to expensify-open-source i am happy to re-consider after confirmation.

@bernhardoj I don't understand how the issue is similar to this behavior. The bug is when you open the app from deep link not when reopening, which definitely should be fixed.

Wrong, it also happens by opening it normally. It doesn't matter how you open it.

It does matter, if i am opening a link for specific chat i want that specific chat to open, if i am opening the app directly without any link and it happens that's the expected behavior and not a bug for now.

Newbie here!.  As per the issue description, issue seems to be related to universal deeplink not working for profile page(CMIIW) - I have replied here in details

why should a user be brought back to the last opened public room when they reopen the app?

I thought this could be product ask.

I don't know if we are on the same page but every statement doesn't make sense to me.

Idk why but it feels like you are very afraid of my proposal 😅

@bernhardoj As I said, in my opinion, it makes sense for the app to open the public room I recently accessed when I reopen the app, after having accessed the room anonymously, clicked sign in and then closing the app.
However, if I open the app by clicking on a specific link to a specific page (profile page in this case) and it instead opens the recently accessed public room, this would be considered a bug. that's my opinion and it is why i suggested you to raise this to expensify-open-source

Now, let's say everything you said is correct. Then, what would you say with this case:

Log out
Open public room
Press sign in
Close the app
Deeplink to ANOTHER public room

@dukenv0307 could you confirm if this case is handled in your proposal?

Again, why should a user be brought back to the last opened public room when they reopen the app? Why only public room? Why only when logged out? Why only after they press sign in? Is it a very special room?

Let's keep our conversation civil 🙂. We can discuss this matter in more depth if you raise it on expensify-open-source. It seems like there might be an assumption that I'm not fully understanding your concern and the expected outcome. Therefore, it would be better if you could address this issue. Can you confirm if you're able to do so? Otherwise, I can get the conversation started.

Let's chill out a bit here and wait for @MariaHCD to come back this week and take a look/weigh in. 👍

Issue not reproducible during KI retests. (First week)

Waiting on @kbecciv to confirm that this is still reproducible.

Issue is not reproduced
https://github.com/Expensify/App/assets/93399543/c89f2d08-6ce8-48c0-9296-e59e009e20a1

Okay, perhaps we can close this then?

I think the majority opinion is to do nothing since either way will work https://expensify.slack.com/archives/C01GTK53T8Q/p1700580479451839?thread_ts=1700455132.577509&cid=C01GTK53T8Q https://expensify.slack.com/archives/C01GTK53T8Q/p1700584101131529?thread_ts=1700455132.577509&cid=C01GTK53T8Q when reopening the app, as of this issue it is not reproducible anymore when we open the app from a link to specific page, i'd say to do nothing.

I think the issue is definitely a bit niche and I don't think it's worth the effort to fix it, IMHO. So I agree with @greg-schroeder's decision to close this.


Execution failed for IdentityTransform, File/directory does not exist: intermediates/runtime_library_classes_jar/release/classes.jar

Current behavior
Plugin cannot find classes.jar
Failed to transform classes.jar (project :features:checkout-v2-data:cash-drawer:public) to match attributes {artifactType=android-classes, com.android.build.api.attributes.AgpVersionAttr=7.2.2, com.android.build.api.attributes.BuildTypeAttr=release, com.android.build.gradle.internal.attributes.VariantAttr=release, org.gradle.category=library, org.gradle.jvm.environment=android, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=androidJvm}.
      > Execution failed for IdentityTransform: /Users/malcolmn/Development/android-register/features/checkout-v2-data/cash-drawer/public/build/intermediates/runtime_library_classes_jar/release/classes.jar.
         > File/directory does not exist: /Users/malcolmn/Development/android-register/features/checkout-v2-data/cash-drawer/public/build/intermediates/runtime_library_classes_jar/release/classes.jar

Expected behavior
Plugin should be able to find classes.jar
Steps to reproduce
./gradlew analyzeReleaseBundle &  ./gradlew analyzeDebugBundle
Versions
AGP = 7.2.2
Gradle =  7.5
Ruler = 1.4.0
Anything else?
It looks like DependencyParser is looking at RuntimeClasspath, but it seems like for our project and sub projects we are only generating CompileClasspath for certain modules. Should we update DependencyParser to look at other places for classes.jar, or change our build scripts to also generate the runtimeClasspath jars for each module?

Hi @malcolmn-sq!
Could you share a bit more of what your Gradle setup looks like for both the app and library projects?
We're having trouble reproducing the issue.

Hi @nathan3d It looks like within our own project, we are either creating a fat jar outside of where DependencyParser is looking or not generating the RuntimeClasspath classes.jar, instead using CompileClasspath. Is there a way to normalize this?

I'm not sure what the solution is yet, so far everything I've tried still results in generating the runtime classes.jar. Any way you can provide a sample project or more details on the setup?

I think what was happening was that our project's build never resolved any internal dependencies. I was able to fix this by removing the filter, but is it possible for ruler to enforce/generate runtimeClasspath dependencies in its own step?
  fun Configuration.externalArtifactViewOf(
    attrValue: String
  ): ArtifactView = incoming.artifactView { view ->
    view.attributes.attribute(attributeKey, attrValue)
    // If some dependency doesn't have the expected attribute, don't fail. Continue!
    view.lenient(true)
    // Only resolve external dependencies! Without this, all project dependencies will get _compiled_.
    view.componentFilter { id -> id is ModuleComponentIdentifier }
  }

@malcolmn-sq If you'd like to create a PR for this, would be happy to merge it.


[Missing Functionality] Only apps of type "game" are shown

I added a game demo some time ago to my steam account but they don't seem to show up in the menu

Thanks for your Nix support @legendofmiracles
I was thinking of extending the config in step with Nix (which would address this issue). Do you know of any projects that might be worth using for reference?


generator builder not working

I'll get this error when trying to use the generator builder
[2016-05-25 05:07:21] local.ERROR: exception 'ErrorException' with message 'mkdir(): Permission denied' in /Applications/XAMPP/xamppfiles/htdocs/playground/vendor/infyomlabs/laravel-generator/src/Generators/Scaffold/ViewGenerator.php:36
Before this I needed to give writing access to several folders like Models, Controllers, Migrations etc
But what can I do now? And why is this?
Regards
kay899

I think something related to your own permissions.


Complete the port of security_validation tests to Elixir

Overview
This PR completes the porting of security_validation.js test into Elixir.
security_validation.js was partially ported and this PR completes that work.

Testing recommendations
 make elixir

Related Issues or Pull Requests
N/A

Checklist

[X] Code is written and works correctly
[X] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

Thanks @dottorblaster! We're near to switch off the javascript test suite


First update of Slate API documentation framework

Make sure you've checked off all these things before submitting:

[ ] This pull request isn't for a company's fork, it's intended for the upstream Slate shared by everybody.
[ ] This pull request is submitted to the dev branch.
[ ] If it makes frontend changes, this pull request has been tested in the latest version of Firefox, Chrome, IE, and Safari.

1st update


How to avoid loading LoggingConfiguration from app.config

Hello,
I opened #4464 maybe 3 years ago and I still face the same issue.
But now, I'm able to upgrade to the last version of NLog, so I wanted to fix that.
I look at the code, and seems I'm still not able to bypass the internal load of app.config if my build target is  .Net4.8.
The constructor of LogFactory which allow to force the usage of LoggingConfigurationFileLoader is internal (the LoggingConfigurationFileLoader also)
So If you have any idea of how I can drop this app.config load, I will be happy ;)
Thanks in advance for your help
NLog version: 5.2.8
Platform: .Net 4.8
Current NLog config
 string loggerName = "loggername";
string workingDirectory = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), @"log\", DateTime.Now.ToString("yyyy-MM-dd"));
LoggingConfiguration config = LogManager.Configuration ?? new LoggingConfiguration();

FileTarget logfile = new FileTarget("logfile")
{
	Layout = "[${level}] ${time} ${callsite} line ${callsite-linenumber}\r\n${message}\r\n" + new string('-', 200),
	FileName = Path.Combine(workingDirectory, "${shortdate}_appA.log"),
	MaxArchiveFiles = 5,
	ArchiveAboveSize = 10485760, // 10Mo
	ConcurrentWrites = false
};

config.AddRule(LogLevel.Debug, LogLevel.Fatal, logfile, loggerName);

MethodCallTarget methodCallTarget = new MethodCallTarget("methodCallTarget", DisplayLogToUser);
config.AddRule(LogLevel.Warn, LogLevel.Fatal, methodCallTarget, loggerName);
LogManager.Configuration = config;
LogManager.ReconfigExistingLoggers();

What is the current result? Crash when try to read nlog config from XML
What is the expected result? don't try to read app.config stuff
Did you checked the Internal log? no
Please post full exception details (message, stacktrace, inner exceptions)

Are there any workarounds? no

NLog will only scan for possible locations that can contain an NLog Configuration, when creating NLog Logger and no NLog Configuration has been loaded.
Try manually loading/assigning the NLog Configuration before the first NLog Logger is created (Ex. before calling LogManager.GetCurrentClassLogger() or LogManager.GetLogger()).

In fact the code posted previsouly is already called at the beginning.
I tried to add LogManager.Configuration = new LoggingConfiguration(); right after the assembly load but, I face the exact same Exception, just sooner.

Can you provide the stack trace?
Sent from my Galaxy
-------- Original message --------
From: David Ducatel @.>
Date: 15/03/2024 11:58 (GMT+01:00)
To: NLog/NLog @.>
Cc: Rolf Kristensen @.>, Comment @.>
Subject: Re: [NLog/NLog] How to avoid loading LoggingConfiguration from app.config (Issue #5483)
In fact the code posted previsouly is already called at the beginning.
I tried to add LogManager.Configuration = new LoggingConfiguration(); right after the assembly load but, I face the exact same Exception, just sooner.
—
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/5483#issuecomment-1999411553, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HHNMJQGSVEONOGHMM3YYLH3PAVCNFSM6AAAAABEWIMQVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGQYTCNJVGM.
You are receiving this because you commented.Message ID: @.***>

Sure here the main thread where the init of NLog is done

And here the thread which throw the exception (only Ms code here)

Not sure what NLog-project can do about other threads throwing exceptions.
Again NLog will not probe app.config if you assign NLog LogManager.Configuration upfront, before creating the first NLog Logger.
Avoid using the LogManager.Configuration-property-getter, so avoid doing it like this:
NLog.LogManger.Configuration ??= new LoggingConfiguration();

And avoid doing it like this:
NLog.LogManger.Configuration = NLog.LogManger.Configuration ?? new LoggingConfiguration();

I add the creation of the configuration on the very first line of my assembly entrypoint

And it seems to crash here

Looking forward to hear if you have any findings. Sounds like a bug if LogFactory-constructor is throwing exceptions, before having loaded the NLog-configuration.

Seems to come from static object initialization which occur on Assembly.load() done on my C++ cli side.
It's very difficult to debug because seems to have kind of timing issue. When I put breakpoint into static constructor of LogFactory, the exception isn't throw.
As I try to load the assembly which use NLog from a custom AppDomain where I set a different app.config, maybe the config isn't properly initialized when NLog try to read into

Yes not a big fan of static constructors, as type-load-exceptions are really nasty. But sadly enough this is currently the way that NLog hookup to the AppDomain-event-handlers to ensure automatic flush on application-exit.

Closing due to inactivity. Hopefully with NLog v6, then auto-loading and static-constructors will be removed.

Yes, I keep using my old v4 version with my own workarround until you release the V6. Do you have any ideas about when you when to release it ?

NLog is a spare time project, and we the current speed, then I guess NLog v6 RTM will be in year. But maybe a NLog v6 Preview will arrive in 3-6 months.

@Ducatel To avoid issues with existing NET Framework applications that rely on app.config. Then I'm reluctant to remove the app.config support with NLog v6.
Will try and remove any static class initializers from LogFactory / LogManager with NLog v6, so it will be easier to see what is failing when doing early assignment:
LogManager.Configuration = new LoggingConfiguration();