Template literal type check to symbol is loose

Bug Report

🔎 Search Terms

template literal, symbol, #19666
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for
entries about all

⏯ Playground Link

Playground link with relevant code
💻 Code

declare const a: symbol;
declare const b: symbol | string;
declare const c: {} | symbol;
declare const d: {};
declare const e: unknown;

const _a = `${a}`; // Error
const _b = `${b}`; // Error
const _c = `${c}`; // Error
const _d = `${d}`; // Ok
const _e = `${e}`; // Ok

🙁 Actual behavior
No type error if symbol is implicitly included.

🙂 Expected behavior
Type error on unknown and {}.

In TypeScript, symbols are a unique data type that represents a unique identifier. When you try to interpolate a symbol into a string using template literals, it results in a type error because symbols are not implicitly convertible to strings.

What do you think about providing like strictTemplateLiteral as a compiler option?

That seems extremely niche. I have seen appetite for a broader compiler flag that covers any implicit string coercion at all, which I think would be more palatable.

I agree with you!

@TomokiMiyauci You may be interested in https://typescript-eslint.io/rules/restrict-template-expressions/


train batch_size

Hi, what is the minimum batch size that needs to be maintained for stage 2 and stage 3 refining?
I have resources for batch_size-1024 stage2 refining but i'm unable to do the same for stage 3.
i was wondering if we have to kwwp the batch_size same for both stage2 and stage3? if so what is the minimum batch_size that wouldn't affect the ID heads learning capability.
Dataset: 27k classes, with 20 images in each class.

We always kept batchsize the same for stage2 and stage3, but I dont think that is strictly necessary.
You can also go lower than 1024, for example we used 512 for the ViT-H and ViT-2B experiments and it worked quite well.
However, note that batchsize and temperature are related hyperparameters because there are more negative samples in the loss. For ViT-H and ViT-2B higher temperatures are good (0.3 for ViT-H and 0.35 for ViT-2B)
As the best temperature can vary anyways based on the dataset/number of classes, I'd suggest to simply try a smaller batchsize (512 or 256) with temperature 0.2 to get a baseline result. If that model is not good enough you can then try to increase batchsize and tweak the temperature.
In my experience, the temperature and batchsize are not "make-or-break" parameters, and as long as you they are in a reasonable range (around temperature=0.2 and batchsize around 512) the model should converge just fine; but if you want optimal performance you'd have to tune it.

Thanks for the detailed information. Where do i adjust the temperature for the NN objective?
I coundln't find it in the config files.

each yaml file is "preprocessed" by either the stage2_processor or stage3_processor to make the config file cleaner
each head is named something with "_temp02", the 02 stands for 0.2 and temp for temperature. So renaming it to temp025 would change the temperature from 0.2 to 0.25

Thank you so much.


Fallback for Fee Rates

As fee-rates are an external dependency and are prone to non-availability, we will need to have a fallback mechanism(beyond the fee/ex-rates patch). In such a scenario where fee rates aren't available in the app, we'll disable the send max option and would remove the priorities from the confirmation screen. The user would be able to enter the fee via the Custom fee option and continue the send.

@cakesoft-swati check with @Parsh to test this.

@cakesoft-swati check with @Parsh to test this.

-Verified this issue on Dev app v1.4.1(193)

-Verified this issue on Dev app v1.4.1(193)


bump development release triggers for bundle

Issue #, if available:
Description of changes:
Bumping staging bundle release triggers for 0.7.0 release.
Holding until we confirm everything is in for the bundle release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/override eks-anywhere-release-tooling-presubmit
/override eks-anywhere-presubmit
/override eks-anywhere-e2e-presubmit
/override eks-anywhere-attribution-files-presubmit


WIP: Update Apache HttpClient to version 5.x

Sneak preview of the changes made so far. Note that this PR is not complete, but work-in-progress. See below for some comments from my side.
HttpWebConnection
This is of course the place where most of the changes were made. There are still a lot of TODOs:

Have each and every setting configured correctly. I'm still busy finding all the now-needed builders.
Find out how to build a multi-part request body the "new way".
Find out how to correctly invalidate entries in the authentication cache if the credentials have changed.
For now, the code uses a SimpleHttpResponse which buffers the response in memory. Once everything works okay, we can rework this to use a streaming response. Need to find out how this works, though.
Previously, HU handled compressed responses itself. Not sure yet if we can keep this feature. Looks like HC 5.x wants to do that.
When the dust has settled, get the code back in shape (refactoring, renaming, formatting, comments).
The reconfiguration of the HTTP client on changes of the WebClient options is not addressed yet. Needs to be redone when everything else works.
Get all existing unit tests green again.
HTTP/2 is not covered yet in the unit tests. Hopefully, browsers do not behave that much differently when using HTTP/2 compared with HTTP/1.1.
Maybe add another option to WebClientOptions to enforce either HTTP/1.1 or HTTP/2 instead of using the auto-negotiate default?

Other Changes
pom.xml
Still uses HC 4.x for the tests. I tried to rework the LocalTestServer to use 5.x classes, but some of them are no longer available on Maven Central. Maybe we can replace this later. I also had to add httplient as test dependeny since the tests-jar needs it.
DefaultCredentialsProvider
Now implements CredentialsStore. The ANY_* constants are no longer provided so I recreated them here for now. AuthScope takes protocol and auth scheme as additional parameters now. Passwords are char[] now.
HtmlUnitBrowserCompatCookieHeaderValueFormatter
We can no longer overwrite certain methods of BasicHeaderValueFormatter so I had to reimplement this class completely, i.e. I copied the relevant code.
HtmlUnitBrowserCompatCookieSpec
There are a couple of changes here and some TODOs. In HC 5.x, cookies don't provide version and comment any longer. Since the current code depends on the version attribute, we have to carefully review/rework this class.
NetscapeDraftHeaderParser
This class is no longer available in HC 5.x. I readded it as HtmlUnitBrowserCompatCookieSpec relies heavily on it at the moment. We need to check if all copyright requirements are satisfied.
HtmlUnitVersionAttributeHandler
Since the version cookie attribute is no longer supported, we can probably delete this class.
HtmlUnitSSLConnectionSocketFactory / SocksConnectionSocketFactory
Cannot set plain/SSL socket factories any longer. Most functionality has been moved to HttpWebConnection. Once we are confident that all is covered elsewhere, we can remove these classes.
CookieManager3Test
The DefaultCookieSpec used in the test previously is no longer available. Don't know if we still need the httpClientParsesCookiesQuotedValuesCorrectly test case.
HtmlUnitCookieStoreTest
Had to implement the store-contains-the-cookie check in a different way as we can no longer inherit from the now final BasicClientCookie class.
HttpWebConnection3Test
HC 5.x now uses "Connection: keep-alive" (lower-case) so I had to adapt the expectations.
The remaining modifications are mostly trivial.

Have opened a separate kanban board for this https://github.com/HtmlUnit/htmlunit/projects/2

Many thanks for this huge contribution. Finally i found some time to work on this.
Have done some preparation in the existing code to at least centralize the httpclient usage a bit. Maybe we can do more here in the future to be able to use different clients (e.g. OkHttp).
Your changes are now merged into a separate branch and we have a jenkins build for this branch also.Hope we can improve the branch in the next weeks.


Modify regex split

Closes #33
This removes mean, sqrt, and \d from the regex.split command for the arithmetic.
Currently, if a variable/group/collection contains a number or 'mean' or 'sqrt' in its name, it will fail. This should fix that. However, we will still need a solution eventually for dealing with 'functions' (mean, sqrt, others)

Yeah that would likely make sense for now. Just turn off all this install. And then we wont have to have this strange dependency on a fixed version.


Provide access to real XMLHttpRequest object

I'd like to implement a proxy in sinon. I tried restoring, sending the request to the real server and then creating the fake server again, which doesn't work because sinon invalidates requests upon restoring. It would be really nice to be able to access the real XMLHttpRequest to send actual, working AJAX requests.

Based on the code, it looks like there's a copy of the original XHR stored at sinon.xhr.XMLHttpRequest. Is this not the case?

I wouldn't bet on that being available in 2.0. We're hoping to tidy up the API considerably.

This has been resolved with https://github.com/sinonjs/sinon-docs/pull/7


Watch for model data changes

cc @gtramontina @fgrehm

Sorry... :stuck_out_tongue: All of the comments should've been on the lib files, not dist.


[Features] Fine-Tuning

This is a really cool project. I hope you don't mind me putting down a few ideas on how I think it could be improved for other use cases!

Some modules, like watchify, are highly dependent on lockstepped to another module, like browserify. However, it doesn't matter so much that its other dependencies are being updated. It would be good to be able to only enable greenkeeper on a specific set of dependencies within a module.
It would be nice to avoid the pinning of dependencies. This way I can reduce commit/version clutter and just stick to patching when a Greenkeeper PR + Travis fails.
It would also be nice to only listen for "major" version changes (or some other specifier)
It might be nice to "batch" PRs or provide a "weekly digest" sort of system. It's a bit overwhelming when you have many modules, each with many dependencies.

Thanks for the tool! :tada:

Hey @mattdesl,
thanks for the great feedback.
I'm happy to tell you that we're already working, or planning on working on these features. We will roll them out over the coming days and weeks.

And there are good news: We think we've found a better way to solve the root of the problem
We think the actual problem you and others reported is that all these pull requests can get overwhelming and quickly become too noisy – a valid complaint.
We've just now deployed a new feature. You can now add version ranges to your dependencies again and we will treat them right.
For new versions inside the existing range you’ll get pull-requests only if the update breaks your build. We are doing this by only creating the branch and then waiting for results from your CI. If it passes the branch gets deleted again, if it fails however the pull requests gets opened, because it should definitely have your attention.
-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

When a new version is outside of your existing range you’ll just get the pull request right away.
-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

You can now define the level of "noise" per dependency by using "^", "~", or pin.
We hope you like this change and would be very happy to get your feedback on this.
Best,
Stephan

So I can use 3.0.x and greenkeeper will test in the background if tests pass on new patches and if not do a PR?

@AdriVanHoudt We're currently not supporting the .x syntax, but for ~3.0.0 that's exactly how it works now :)

Oh so if the tests fail you will do a PR with pinned version?

@AdriVanHoudt We'll pin if you're using another range than "^" or "~". Otherwise we reuse what is already there.

So .x will pin?


Allow including only used LODASH functions in app bundle

Using e.g.
import isEqual from 'lodash/isEqual';
if (!isEqual(obj1, obj2)) return;

instead of
import * as _ from 'lodash';
if (!_.isEqual(obj1, obj2)) return;

can save app bundle size.
e.g. if using JSPM package manager with Rollup Optimization.

Duplicate of #830, see this comment: https://github.com/Semantic-Org/Semantic-UI-React/issues/830#issuecomment-259785072

We have this done automatically by babel using https://github.com/lodash/babel-plugin-lodash. Compare the src and dist directories to see it in action.

@jcarbo, that's great, thanks for clarification.


Feature Request: Catch Events and run again after all is ready?

I have a large dashboard with over 7.000 lines and 22 of your great pop-ups.
My most annoying "problem" behavior is, that after starting the app my wife or i quickly start clicking on a room to open the corresponding pop-up. In most cases it's not ready at this moment and nothing happens.
Clicking again, after all should be loading doesn't work in this case too.
Only solution is to reload the dashboard and wait until all is ready and then click.
Would be great if you find a solution for this? Is it possible to check for presence of an anker  in URL ("#livingroom" for example) after all is ready and do the same, like you do, when i click then?

Hi and thanks for your feedback! This issue was annoying me a lot too and I've just fixed it, and a lot of other issues as well!
Now just wait for 1.6.0 in a few days 😀

Yeah! Can't wait! 😊👍

This is now fixed in the new v1.6.0 beta!
https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.0-beta.1

This is now fixed in the new v1.6.0 beta!
https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.0-beta.1

@Clooos on a desktop browser (chrome for example) it's working very nice now with the beta version.
On iOS App i have a new issue: if i start/restart the app, some icons will not be displayed, the your button slider is missing and after a few seconds the whole dashboard went to grey.
Only help is to reload the dashboard by dragging down. Then the whole dashboard does a restart and now it's working fine.

Yeah, tried that. Does not change anything. :-(
Same problem on mobile safari.
Don't get any suspicious logs in mobile safari web inspector panel. :-/
Now try to switch back to last version and hopefully will get the problem under control.

Ok, it's not related to horizontal-buttons-stack.
The dashboard crashes without this card too. :-/

I'm on it, I've maybe found what can cause this issue 🤞

I'm on it, I've maybe found what can cause this issue 🤞

Sounds good. Create a new beta and i will try it. 😊

Everything should be fixed now 🤞
https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.0-beta.5


Update sbt-ci-release to 1.5.6

Updates com.geirsson:sbt-ci-release from 1.5.4 to 1.5.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.geirsson", artifactId = "sbt-ci-release" } ]

labels: sbt-plugin-update, semver-patch

Part of https://github.com/chipsalliance/treadle/pull/314 now.


How to handle saves stored in %userprofile%/Local Settings/Application Data

I'm on Linux and I noticed Darksiders Genesis saves are not detected by ludusavi.
The game seems to stores saves in %userprofile%/Local Settings/Application Data, but Windows redirects that to %localappdata% (%userprofile%/AppData/Local).
However wine does not redirect it in that way so they are not found by ludusavi when %localappdata% is specified as the path on PCGW.
So, should the path on PCGW be changed to %userprofile%/Local Settings/Application Data which would seem wrong to Windows users, or should ludusavi check that location when %localappdata% is being used.

That's a good find :+1: I think Ludusavi should be responsible for checking it automatically. It doesn't strike me as something that would go on PCGW since it's more a quirk of Wine that of the game itself.
I found this interesting:

If you put %userprofile%/Local Settings/Application Data in Windows Explorer, you get an error that it doesn't exist.
If you cd to it in Command Prompt, that works. dir says "file not found". but if you echo to a file, it will show up in %userprofile%/AppData/Local successfully.

I read it was used on Windows XP but Windows 7 and later redirects it to %appdata%. A bit strange some modern games still seem to store saves there.

I also noticed this does not work <home>/Documents/My Games/Borderlands 3, because in the wineprefix it is My Documents for some reason, I wonder if proton has wineprefix set to windows XP or something.
Chaning it to <winDocuments>/My  Games/Borderlands 3 makes it work.
Maybe in this chase it should just be changed to {{p|userprofile\Documents}} on PCGW.

Yeah, that one's a mistake on the wiki, since {{p|userprofile\Documents}} is meant to be used for it: https://www.pcgamingwiki.com/wiki/Template:Path

It seems wine simply redirects to XP paths.
%appdata% -> Application Data
%localappdata% -> Local Settings\Application Data
I don't know if there is a environment variable for the documents folder but newer windows uses Documents and wine/xp uses My Documents.
My guess is that any game that I have used in wine that has stored files in the AppData folder simply has the path hardcoded as %userprofile%/AppData/ and is not using the %appdata% or %localappdata% variables.


NuclearRNA compatibility

This is polishing some of the work that @lpantano was doing with some improvement reviews by @olgabot and @ewels 👍
I adjusted some of the stuff that Olga was suggesting, tried to fix MarkdownLint errors in the usage documentation and hope that this meets our requirements now:
PR checklist

[x] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[ ] README.md is updated

@nf-core/core Ready for review / comments / merge...


Return a piped response with compression enabled causes an unexpected error

What version of Hono are you using?
4.5.8
What runtime/platform is your app running on?
Node
What steps can reproduce the bug?
Enable the built-in compression:
app.use(compress());

Inside a hono route, do the following:
return await fetch(targetUrl, {
    method: req.method,
    headers,
    body: req.raw.body,
    duplex: 'half',
});

What is the expected behavior?
Response piped correctly.
What do you see instead?
TypeError: immutable
at _Headers.delete (node:internal/deps/undici/undici:3303:17)
at set res [as res] (file:///D:/whitewall/proxy/node_modules/hono/dist/context.js:62:31)
at compress2 (file:///D:/whitewall/proxy/node_modules/hono/dist/middleware/compress/index.js:12:13)
Additional information
It works on latest version of 3.x. Stopped in 4.x.

Related lines:
https://github.com/honojs/hono/blob/main/src/context.ts#L477
https://github.com/honojs/hono/blob/main/src/middleware/compress/index.ts#L43-L44
Potential solutions:

implement a proxy for modifying response.headers (recreating the response)

    const headers = new Headers(res.headers)
    headers.delete('Content-Length')
    headers.set('Content-Encoding', encoding)
    // Compress the response
    const stream = new CompressionStream(encoding)
    ctx.res = new Response(res.body.pipeThrough(stream), {
      status: res.status,
      statusText: res.statusText,
      headers
    })

and rework https://github.com/honojs/hono/blob/main/src/context.ts#L477 to avoid overwriting the headers

This was closed by https://github.com/honojs/hono/pull/3318. Thanks.


strange issue

Tried running your code to investigate styled component not working in dist...
I'm confused by what I found...
yarn build && yarn preview then visit http://localhost:4173/ with dev tools open so the debugger triggers
Dev tool console logs:
<style data-styled="active" data-styled-version="5.3.3"></style>
Inspect the first card element...

You see that style:

Is applied by <style>... Click <style> and see it references the tag added by styled-components:

This is where things get strange. Notice the <style data-styled="active" data-styled-version="5.3.3"></style> has no styles or content... Yet somehow this tag is supposedly applying the green border?
Try deleting the tag and the green borders dissapear. CMD+Z and the <style data-styled="active" ... reappears in the DOM inspector where it was before but the green borders do not reappear...

I don't understand how this tag can be applying styles to elements when it has not content... So strange.

So learned something... cssRules can be applied to the sheet associated with the style node without affecting textContent...

https://stackoverflow.com/questions/54850845/empty-style-element-with-working-css-rules
Note that the border rule is there but the background rule is missing...

Change background rule to:
const CardArt = styled.div`
  border: 2px solid ${props => props.bgcolor};
	background: ${props => `url(${props.iconRef})`} red;
`;

Dev:

Dist:

Looks like your prop is being given some unique hash in dist...
cssText: ".dJjuXT { border: 2px solid green; background: url(\"work.48189dc5\") red; }"

Here is a better way to see the difference in dev vs dist:
import styled from "styled-components";

const CardArt = styled.div`
  border: 2px solid ${props => props.bgcolor};
	&:after {
    content: "${props => `${props.iconRef}`}";
  }
`;

export default CardArt;

Ah, that makes sense, the bundler is bundling your files...

You probably need to update this regex to be smarter if you're going to keep using this strategy of using regex....
	const iconRef = icon.match(/(?<=icon-)([\s\S]*)[^.svg]/)[0];

Maybe best if you get rid of 	icon={images[title.replace(" ", "").toLowerCase()]} and the regex icon.match(/(?<=icon-)([\s\S]*)[^.svg]/)[0];... Too much magic. Instead maybe just add a field to to your json that maps back to your constants.

oof, didn't see that coming, since I'm not yet used to bundlers...  I've applied the regex logic with the title, doing essentially the same and guess what, it worked this time >.> I was just overcomplicating things haha
I can't express how grateful I am with your help, thank you very much for it! This was killing me 😅


Visual work. Added notebook and .py files

Description
This PR adds my work on the visualizations for the parent dashboard. It adds the score_visual notebook which includes the various mockups we presented to Graig and Darwin. It also adds the histogram.py and line_graph.py files which create the Plotly json files for web to display on the parental dashboard. All corresponding README's have been updated.
To be implemented in the visualization endpoint of our application.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[x] Yes
[ ] No
[ ] Not necessary

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

oops I fixed a merge conflict in the notebooks/readme.md and now we have to resubmit the reviews, I was hoping that it would let me just merge with incoming changes


[Core] BREAKING CHANGE: az extension add/update and az upgrade: Set default --allow-preview value from True to be False

Related command

Description

This pr changes the default value of allow-preview from True to False during az extension add/update, az upgrade and dynamic installation. It's based on the discussion of pr https://github.com/Azure/azure-cli/pull/28913
Testing Guide

History Notes

[Extension] BREAKING CHANGE: az extension add/update: Set default --allow-preview value from True to be False
[Upgrade] BREAKING CHANGE: az upgrade: Set default --allow-preview value from True to be False

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Thank you for your contribution! We will review the pull request and get back to you soon.

@AllyW
Base on my understanding:
The installation won't fail because there is fallback logic. If no stable version is available, we will install the latest preview version. The only impact is that some extensions that default to installing the preview version may, due to this change, default to installing the stable version instead.

@AllyW Base on my understanding: The installation won't fail because there is fallback logic. If no stable version is available, we will install the latest preview version. The only impact is that some extensions that default to installing the preview version may, due to this change, default to installing the stable version instead.

Yes, that's the breaking part of this pr. For now we added a pre-announcement for it.  Warning log as below should have been displayed to users since like a year ago.

Set default --allow-preview value from True to be False does not explain the real logic, I suggest using install stable version by default unless there is no stable version is available.


Refactor to MiniRx Signal Store

Just battle testing the upcoming MiniRx Signal Store.
See the MiniRx Signal Store RFC here:
https://github.com/spierala/mini-rx-store/discussions/188

The checks are currently failing because of npm install @sentry/angular and storybook.
But the app itself works locally after running npm i --force


Wallet not loading

My wallet for some reason does not want to load and show assets. I re started both my browser (brave) and computer a couple of times to see if those where the problems but when I open my wallet it keeps on looking as the picture. When I go on dapps if it connects it doesn't show balance, or I simply get a prompt stating that the wallet cannot be recognized.
I also verified on cardanoscan if maybe it was because my wallet was drained but my assests are all there.

There is a new version 3.4.7 available that should fixed this again.

Hi @nevcol   have this issue been resolved yet ? I suggest you contact wallet support developers on their web3chain website for assistance. SUPPORT for assistance


Not access to http://ec2-3-131-244-37.us-east-2.compute.amazonaws.com

Hello ,
Could you help me, please?
Now we don't have  access to http://ec2-3-131-244-37.us-east-2.compute.amazonaws.com

Dublicate


Build deployment process -- startup a new instance #18

https://github.com/throneless-tech/piecewise/issues/18

https://cloud.google.com/appengine/docs/standard/java/how-instances-are-managed#startup


Question CI/CD workflow

Thanks a lot for the content you create to help get up and running with helm, it is really helpful!
I have one little question.
What do you recommend to organize the git repo for CD with helm?
Does it make more sense to have one git repo with all the charts definition?
So it would mean having a git repo lachie83/charts with croc-hunter inside.
From this repo, in CD, we would just provide the image tag for instance.
And we would have separate release cycle, the Docker image and the helm chart for croc-hunter.
Or does it make more sense to keep things locally? (I think I prefer this option)
But in this case, how do you manage dependencies, and especially, public dependencies.
(For instance: https://github.com/kubernetes/helm/issues/2209)
(I guess, it would mean building dependencies, and then running upgrade command)
Thanks for your help!

And also :) What is the tool chk8s you use at 7m32? https://www.youtube.com/watch?v=eMOzF_xAm7w

Hi! Sorry for the delayed response. I honestly would like to see me flip this to use the helm registry plugin and publish all my charts to quay and let it handle generating the repo. I hope from there I can fire a webhook when a container is built into a service that runs deployment against tiller. Does that make sense?
I'm for keeping the chart in the app repo asking with the build pipeline.
Chk8s was inspired by a friend of mine. His code is here https://github.com/slack/dotfiles/blob/master/bin/chkube


Feature request: Increase the size of "Send to multiple" tabs

When using the Send to Multiple feature, on several occasions I've accidentally clicked the "x" icon on the tab bar, which removes the tab altogether.
It would be helpful if the tabs were a bit taller so that the clickable area would be larger.

Tab header width increased in 20df1dbd. It's not a big change, but space is limited. This reduces the number of visible tabs from five to four.

Maybe one could get rid of the close icon and instead use a middle/right mouse click for removing the tab? Question is how to convey this possibility to the user?!

IMO even a few extra pixels is a big improvement. Thanks!


Connector request: fanburst

Please, add https://fanburst.com (soundcloud analogue) support.

Will be available in the next release.


RTL Support!

Can you plz add RTL Support, so we can use it in "RTL" language websites! :)

Yes having RTL support will be really nice for this theme

How can i mold right to left?

Yes having RTL support will be really nice for this theme

How can I change LTR to RTL

All you need is to add the RTL version of bootstrap. you will find it on internet. for example
https://github.com/MahdiMajidzadeh/bootstrap-v4-rtl
don't replace the current version of bootstrap, just add this one below it.


Prepare addon for Asset Library

Following the submission docs [1]

Use the export-ignore Git attribute so only the addon is in the resulting ZIP file.

Copy LICENSE and README to the addon.

Create an empty docs/screenshot folder for the Asset Library assets like icon, screenshots. And make the Godot editor ignores these files (ie. doesn't automatically import them).

[1] https://docs.godotengine.org/en/latest/community/asset_library/submitting_to_assetlib.html

Hmm I just figure out that, because Godot Asset Library uses git archive --format zip and the zip format doesn't support symbolic links, we can actually avoid duplicating the license too. I'll open a separate PR.

No, it doesn't work, I was just reading the output wrong. Never mind.

No, it doesn't work, I was just reading the output wrong. Never mind.

That was my initial hope as well. It will be messy to keep the files in sync, but hopefully that can be added to the release automation?


Astronomy page is cluttered in small screens

Is this issue for : https://github.com/kylecorry31/Trail-Sense/issues/74#issuecomment-631418867

Here's another option to get that text out of the way (it follows the moon as it moves around):

That's perfect


Support shuffle for data type smaller than 32-bit (e.g., fp16)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ZHENG,Zhen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


The ollama api add new “keep_alive” paramater

Hello, I'm new to this project. Your wrapped Ollama client is really handy. However, I noticed that there are a few new fields added compared to the latest Ollama documentation. Could you please update it to accommodate these changes?
https://github.com/ollama/ollama/commit/128fce54953f355adb8921662a175a30a0c38494

Actually, I really need the newly added keep_alive field. The default 5-minute interval provided by Ollama is too short for my needs, and I'd like to customize it.


New save output

Saving diffraction intensities into different file formats

import skxray.io.save_powder_output as spo
spo.save_output(range(5), range(5)[::-1], 'dummy', 'Q')

outputs:
 dummy
        This file contains integrated powder x-ray diffraction
        intensities.
        First column represents Q values (Angstroms) and second
        column represents intensities and if there is a third
        column it represents the error values of intensities.
        Number of data points in the file : 5
        ######################################################
        0.000000000000000000e+00 4.000000000000000000e+00
1.000000000000000000e+00 3.000000000000000000e+00
2.000000000000000000e+00 2.000000000000000000e+00
3.000000000000000000e+00 1.000000000000000000e+00
4.000000000000000000e+00 0.000000000000000000e+00

which does not look right to me.

@tacaswell I added a newline to fix that issue with the output file

This now outputs
 dummy
        This file contains integrated powder x-ray diffraction
        intensities.
        First column represents Q values (Angstroms) and second
        column represents intensities and if there is a third
        column it represents the error values of intensities.
        Number of data points in the file : 5
        ######################################################
0.000000000000000000e+00 4.000000000000000000e+00
1.000000000000000000e+00 3.000000000000000000e+00
2.000000000000000000e+00 2.000000000000000000e+00
3.000000000000000000e+00 1.000000000000000000e+00
4.000000000000000000e+00 0.000000000000000000e+00

I is it supposed to have leading tabs on the header?

No, I just put it(the tab) in that way thinking it will easy to read.

I can even make it without the tab  too

I thought that these file formats had specifications, you should follow what ever that is.

They don't have specifications. If you take output files created by fit2d and SrXplanner it is totally differnt @tacaswell I will e-mail the files to you


🧪 TESTS: Add tests for JS tab functions

Got a few tests working here, but additional steps needed before it's complete:

[x] Add test for #105
[x] Get testing to run with tabs.js in it's current location. Tests currently require you to move tabs.js to the project root...
[x] Add JS testing to CI workflow

Actions seems to run properly, so this should be good to include now. It doesn't alter any functionality, so shouldn't need a new version from just this


Improve testing for models

We currently have very limited testing for the models in torchvision.
In most cases, we only test for the output shape to be correct, see
https://github.com/pytorch/vision/blob/8635be94d1216f10fb8302da89233bd86445e449/test/test_models.py#L29-L59
While this allows to catch bugs such as Py2-Py3 differences, it is not enough to ensure that refactorings of the models keep the behavior the same (and that pre-trained weights are still valid).
We should come up with a better testing strategy.
Ideally, we would not want to download the pre-trained weights, because this can make the tests prone to failure due to IO issues.
One possible approach would be to fix the random seed and initialize the models in a particular way and compare the output we get for a particular input with an expected output, ensuring that the output is non-trivial (such as all-zeros or empty, which could happen due to ReLU or for detection models). Something in the lines of
torch.manual_seed(42)
m = torchvision.models.resnet18(num_classes=2)
torch.manual_seed(42)
i = torch.rand(2, 3, 224, 224)
output = m(i)
expected_output = torch.tensor([[0.0002, 0.3], [0.245, 0.001]])
assert output.equals(expected_output)

The problem with this approach is that we do not guarantee that the RNG is the same between different versions of PyTorch, which means that this way of testing the model would lead to failures if we change PyTorch's RNG.
This issue will be particularly important to be addressed soon, because we will be adding some slight modifications to the model implementations in order for them to be traceable / ONNX-exportable. @lara-hdr is currently looking into making the torchvision models ONNX-ready.
cc @fbbradheintz , who showed interest in addressing this issue.

I'm on it, @fmassa - I'll post a comment here here with a plan.

My current plan:

Introduce fixed seeds for all pseudo-random processes.
Provide known inputs to pseudo-randomly initialized models. (With the fixed seeds, this should have the same effect as using a set of fixed weights.)
Pass input to the model.
Check a sampling of output values from the output tensor - enough to provide high statistical confidence that the whole output is correct without making the test long-running - to verify that they are within some epsilon of a target value.

This process will be repeated for all models covered by the test, probably in a subclass that specializes the initialization, input, and output based on the needs of the model.
One possible pitfall is PRNGs giving different results for same seeds on different platforms/stdlib versions. I'll try to test a cross-section of build environments to see whether this is the case. If it is, the fallback will probably be some other algorithmic generation of weights that provides a reasonable distribution of values (perhaps based on the statistical distribution of values in the pretrained versions of the models).

@fbbradheintz This sounds good to me!
The PRNGs are going to be different between CPU/GPU for sure, but I'm not sure if it will be different depending on the platform -- to be tested.
This will at least be a good starting point, and if we make the model initialization it's own method in a tester class, then we can change the initialization of all models in a single function change.

Just an idea but if you could select the RNG in torch.random and maybe have a basic one for testing purposes that would solve the problem, no? Since it's for testing it doesn't even need to be super random.

@SebastienEske yes, that's an idea that could work. It might be a bit more complicated to make it work for detection models (which have lots of conditional and dynamic blocks) though, as we would want to have a non-trivial solution to be output (like a solution with some non-empty boxes).

The non-determinism is a real complication, and I believe @fbbradheintz has hit some of those non-determinisms with a few models.

I've seen it with the Inception v3 model for sure. The rest seem well behaved when using default constructors and a seeded PRNG.
Once I have the deterministic models sorted out, I'll circle back to Inception and any others that need attention.

Just in case: For the forwards (which seems most relevant for tracing, nll_loss2d and scatter_* are the prime suspects for non-determinism).

Just to follow up on the non-determinism thread: The culprit was the numpy PRNG. This is sorted out in the draft PR.

#1424 for cross reference.

@fmassa - my last PR covered the classification models. Do we want to handle video, detection, and segmentation as well before we call this complete?

@fmassa - There are currently multiple test failures (mostly related to scriptability) for segmentation, detection and video models. I'll watch for those to clear up before I start building on them (unless you have a suggestion for a branch besides master to build on).
There are some other passing tests that still need correctness tests added, I'll address them in the meantime.

@fbbradheintz CI should be green now


Allow configuration of auto-register behavior

Describe the feature you'd like
Based on https://www.bookstackapp.com/docs/admin/third-party-auth/, I understood that it is possible to allow auto-register functionality even in AzureAD scenarios, which is great as I don't have to add every user manually. Unfortunately, not every single user in our AD should have access to the wiki. Would be a lot more useful if it could be restricted, for example, based on an AD group.
Describe the benefits this feature would bring to BookStack users
Less work for the admin user as he would not have to add every user and/or more security in cases where auto-register is enabled.

Hi @nmehlei,
If you want to manage things on an AD group level, might the LDAP authentication option be better for you:
https://www.bookstackapp.com/docs/admin/ldap-auth/
You can map BookStack roles to LDAP groups if using LDAP auth.
Otherwise, it may be a while before we add custom auto-register behaviour.

@ssddanbrown interesting idea, but as far as I know, Azure AD does not support LDAP.

I have my authorization managed by a group that is assigned to the application.
AzureAD > Enterprise applications > BookstackApplication > Users and groups
That way I have that the user auto registers with edit rights. No way to assign a specific group to a role afaik...

I'm going to close this off as there's been little further request for this and I'm not looking to widen the scope much further for the social auth providers.
As mentioned above, I'm pretty sure AzureAD itself offers some controls to application access (Although IIRC some of the group-based controls require a specific license level).
Upon that, if handy with code, there is the logical theme system which does have hooks for registration events:
https://github.com/BookStackApp/BookStack/blob/master/dev/docs/logical-theme-system.md


CI breaking with poetry.lock errors

poetry-check.............................................................Passed
poetry-lock..............................................................Failed
- hook id: poetry-lock
- files were modified by this hook

Resolving dependencies...

Writing lock file

Sync with Poetry.........................................................Passed
isort (python)...........................................................Passed
black....................................................................Passed
prettier.................................................................Passed
rstcheck.................................................................Passed
pylama...................................................................Passed
bandit...................................................................Passed
make: *** [Makefile:7: lint] Error 1
Error: Process completed with exit code 2.

I don't see this locally.  But instead I see:
pylama...................................................................Failed
- hook id: pylama
- exit code: 1

Traceback (most recent call last):
  File "/home/cbm/.local/bin/pylama", line 8, in <module>
    sys.exit(shell())
             ^^^^^^^
  File "/home/cbm/.local/lib/python3.12/site-packages/pylama/main.py", line 115, in shell
    errors = check_paths(
             ^^^^^^^^^^^^
  File "/home/cbm/.local/lib/python3.12/site-packages/pylama/main.py", line 68, in check_paths
    errors += run(path=path, code=code, rootdir=rootdir, options=options)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/cbm/.local/lib/python3.12/site-packages/pylama/core.py", line 36, in run
    linter.run_check(ctx)
  File "/home/cbm/.local/lib/python3.12/site-packages/pylama/lint/pylama_pydocstyle.py", line 33, in run_check
    for err in PyDocChecker().check_source(
  File "/usr/lib/python3.12/site-packages/pydocstyle/checker.py", line 158, in check_source
    error = this_check(
            ^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/pydocstyle/checker.py", line 527, in check_imperative_mood
    and not function.is_property(self.property_decorators)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/pydocstyle/parser.py", line 223, in is_property
    return any(
           ^^^^
  File "/usr/lib/python3.12/site-packages/pydocstyle/parser.py", line 224, in <genexpr>
    decorator.name in property_decorator_names
TypeError: argument of type 'bool' is not iterable

bandit...................................................................Passed

I think pylama might not be maintained...  it seems broken on Python 3.12: https://github.com/klen/pylama/pull/254, https://github.com/klen/pylama/issues/249
AFAICT, pylama is a frontend to a bunch of linters: we might need to use those directly if upstream pylama doesn't make a new release.


PHOENIX-6429 Add support for global connections and sequential data generators

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
14m 22s
4.x passed

+1 :green_heart:
compile
0m 35s
4.x passed

+1 :green_heart:
checkstyle
0m 24s
4.x passed

+1 :green_heart:
javadoc
0m 18s
4.x passed

+0 :ok:
spotbugs
0m 57s
phoenix-pherf in 4.x has 50 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
0m 37s
the patch passed

+1 :green_heart:
javac
0m 37s
the patch passed

-1 :x:
checkstyle
0m 26s
phoenix-pherf: The patch generated 96 new + 507 unchanged - 31 fixed = 603 total (was 538)

-1 :x:
whitespace
0m  0s
The patch 8 line(s) with tabs.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 15s
the patch passed

-1 :x:
spotbugs
1m 17s
phoenix-pherf generated 2 new + 50 unchanged - 0 fixed = 52 total (was 50)

_ Other Tests _

+1 :green_heart:
unit
9m 35s
phoenix-pherf in the patch passed.

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

36m 11s

Reason
Tests

FindBugs
module:phoenix-pherf

Switch statement found in org.apache.phoenix.pherf.rules.RulesApplier.getRuleBasedDataGeneratorForColumn(Column) where default case is missing  At RulesApplier.java:where default case is missing  At RulesApplier.java:[lines 555-573]

A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:[line 69]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1185

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux d97d90b96f85 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 3535708

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/testReport/

Max. process+thread count
1842 (vs. ulimit of 30000)

modules
C: phoenix-pherf U: phoenix-pherf

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 29s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 32s
4.x passed

+1 :green_heart:
compile
1m 38s
4.x passed

+1 :green_heart:
checkstyle
0m 51s
4.x passed

+1 :green_heart:
javadoc
1m  1s
4.x passed

+0 :ok:
spotbugs
3m  1s
phoenix-core in 4.x has 941 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 54s
phoenix-pherf in 4.x has 50 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 49s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

-1 :x:
checkstyle
0m 26s
phoenix-pherf: The patch generated 107 new + 501 unchanged - 37 fixed = 608 total (was 538)

-1 :x:
whitespace
0m  0s
The patch 8 line(s) with tabs.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 59s
the patch passed

-1 :x:
spotbugs
1m  9s
phoenix-pherf generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)

_ Other Tests _

+1 :green_heart:
unit
132m 23s
phoenix-core in the patch passed.

+1 :green_heart:
unit
8m 54s
phoenix-pherf in the patch passed.

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

179m 47s

Reason
Tests

FindBugs
module:phoenix-pherf

A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:[line 76]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1185

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux c056d5298868 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 3535708

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/testReport/

Max. process+thread count
6019 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-pherf U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 10 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 12s
4.x passed

+1 :green_heart:
compile
1m 37s
4.x passed

+1 :green_heart:
checkstyle
0m 49s
4.x passed

+1 :green_heart:
javadoc
1m  1s
4.x passed

+0 :ok:
spotbugs
3m  2s
phoenix-core in 4.x has 941 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 52s
phoenix-pherf in 4.x has 50 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 40s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

-1 :x:
checkstyle
0m 27s
phoenix-pherf: The patch generated 104 new + 504 unchanged - 34 fixed = 608 total (was 538)

-1 :x:
whitespace
0m  0s
The patch 8 line(s) with tabs.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 59s
the patch passed

-1 :x:
spotbugs
1m  7s
phoenix-pherf generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)

_ Other Tests _

+1 :green_heart:
unit
175m 10s
phoenix-core in the patch passed.

+1 :green_heart:
unit
8m 33s
phoenix-pherf in the patch passed.

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

226m 30s

Reason
Tests

FindBugs
module:phoenix-pherf

A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.tenantoperation.PreScenarioOperationSupplier$1.apply(TenantOperationInfo)  At PreScenarioOperationSupplier.java:[line 76]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1185

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux 5a1aa1daf60a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 3535708

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/testReport/

Max. process+thread count
5949 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-pherf U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1185/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Make spin not stop on center

Is your feature request related to a problem? Please describe.
The spinning wheel indicator always stop on center,
Describe the solution you'd like
The spinning wheel indicator not always stop on center of FortuneItem. maybe use double as StreamController value?

@chitoadinugraha can you please reply to this? it would be nice feature to have. Thanks


Env Vars intellij-idea cask

First, thanks for the software, i am new to it and love it.
This is mostly a question that i can not find the answer to so i figure i would go to src.
When running maven in intellij, i can not get it to use my M2_HOME from brew. It always points to built in maven bundled in the cask.
Yosemite
i use zsh
I have set the env var in .zshrc, .profile, .bash_profile, .MacOSX/environment.plist and /etc/launchd.conf.
Is there another place i should so all my intellij projects will use the correct one by default?
Thanks

I am not very familiar with IDEA, but I would venture that the locations it checks for environmental vars are not affected by the installation method. When installed manually, does IDEA use the correct M2_HOME?

Closing on account of no reply.

Damn, not sure how i missed this. I was never able to figure it out. Had to set settings in my intellij projects


Don't hide the error being thrown by Gurobi when it fails to compute …

…the IIS
We shouldn't be hiding this error, because Gurobi behaves differently with continuous and mixed-integer models. See #307 for details.

Closes #307.

@ohmsweetohm1, thoughts?

I like it! Now it is clearer:
ERROR: LoadError: Gurobi.GurobiError(10015, "Cannot compute IIS on a feasible model") in both the LP and the MIP case.

Great. We were trying to be too clever before.


iPhone X view change after a few swipe

At first, it display nicely, but after a few swipes the text is truncated
It only happens in iPhone X.

Hello, Did anyone find a solution on this issue?
I have the same problem on iOS

When I go back to "react-native": "^0.49.5", this swipeout lib works fine.
Maybe there are something changed in newest react-native version, so this lib is not compatible with it.

Hi, I solved this issue by wrapping  only with  instead of wrapping the whole  with

Your Text

Thank you.

Check out this closed issue here: https://github.com/facebook/react-native/issues/19302

Facing the same issue on iPhone (not on Android). Has anybody been able to figure this out ?
I couldn't understand how to solve this issue from @mysport12's referenced issue facebook/react-native#19302

PR #274 is addressing the issue @kunalqss

try instead of
<Swipeout {...swipeSetting}>
                <View style={{}}>
                   ...
                </View>
</Swipeout>

<Swipeout {...swipeSetting}>
                <TouchableWithoutFeedback style={{}}>
                   ...
                </TouchableWithoutFeedback>
</Swipeout>

@mysport12 So is this issue fixed in the latest release ? Or is it pending ? Because I installed the latest version and the problem still persists in iPhone.

@kenanlalic I was already using  as the child of , changing to  didn't help unfortunately.

Just tried to fix it in my local node module (SwipeOut) using the PR as suggested by @mysport12  and I can confirm that it has fixed this issue. Thank you @mysport12 :)

I got the same issue on iPhone X, and still have it when using the PR #274 from @kunalqss:

I'm having the same issue. (Just to emphasise importance of this issue)

@dancormier Can you prioritize this issue please ?

You guys should try release 2.3.6 out

ok， update 2.3.6 well done！


Sparse-vector implementation based on fastutil (MAHOUT-1640)

The collections currently used by Mahout to implement sparse vectors are extremely slow. The proposed patch (localized to RandomAccessSparseVector) uses fastutil's maps and the speed improvements in vector benchmarks are very significant. It would be interesting to see whether these improvements percolate to high-level classes using sparse vectors.
I had to patch two unit tests (an off-by-one bug and an overfitting bug; both were exposed by the different order in which key/values were returned by iterators).
Some more speed might be gained by using everywhere the standard java.util.Map.Entry interface instead of Element.

still need to look at this.

Ok here are the quick sparse multiplication performance results in our unit tests. In short, looks like 30% improvement for sparse opeartions on average. Which is decent. I will test the rest of the tests and report back. If everything is ok, looks like a very valuable addition for the time being. Thank you very much @vigna !
Fastutil PR over current master (the second numbers are pragmatically important):
Asr %% Bsr: (26.0,14.333333333333334)
Asr' %% Bsr: (1214.0,16.0)
Asr %% Bsr': (96.0,19.0)
Asr' %% Bsr': (1002.6666666666666,13.666666666666666)
Asr'' %*% Bsr'': (14.333333333333334,14.333333333333334)
Asm %% Bsm: (1523.3333333333333,18.0)
Asm' %% Bsm: (1929.0,21.0)
Asm %% Bsm': (1428.6666666666667,20.666666666666668)
Asm' %% Bsm': (1669.6666666666667,17.333333333333332)
Asm'' %*% Bsm'': (1541.3333333333333,14.333333333333334)
Asm %% Bsr: (1160.0,14.0)
Asm' %% Bsr: (1609.3333333333333,20.333333333333332)
Asm %% Bsr': (1142.3333333333333,17.666666666666668)
Asm' %% Bsr': (1408.6666666666667,14.333333333333334)
Asm'' %*% Bsr'': (1154.6666666666667,14.0)
Current master:
Asr %% Bsr: (30.0,22.0)
Asr' %% Bsr: (1918.6666666666667,26.0)
Asr %% Bsr':<PHONE_NUMBER>6666667,27.0)
Asr' %% Bsr': (1551.6666666666667,21.666666666666668)
Asr'' %*% Bsr'': (22.333333333333332,21.666666666666668)
Asm %% Bsm: (2191.0,26.333333333333332)
Asm' %% Bsm: (2543.6666666666665,30.333333333333332)
Asm %% Bsm': (2067.0,30.333333333333332)
Asm' %% Bsm': (2274.0,22.666666666666668)
Asm'' %*% Bsm'': (2167.0,22.666666666666668)
Asm %% Bsr: (1717.3333333333333,21.666666666666668)
Asm' %% Bsr: (2254.0,32.0)
Asm %% Bsr': (1762.3333333333333,26.666666666666668)
Asm' %% Bsr': (2004.6666666666667,21.666666666666668)
Asm'' %*% Bsr'': (1711.0,24.333333333333332)

If you merge this, I promise I'll look into the other improvements (e.g., not using Element). :)

@vigna i apologize it took so long. it completely went off the radar.

@vigna is 0.7.2 fastutil is still the best version to use? I can't immediately find the license on it?
@smarthi et. al. : need a few votes on inclusion of fastutil as a dependency

ok all tests are passing for me.

@dlyubimov no, actually there are newer versions. I am doing a release in few days with a lot of small glitches fixed thanks to the Guava test suite. Current version is 7.0.10.

so it's Apache 2.0 now, great.
On Mon, Mar 7, 2016 at 4:56 PM, Sebastiano Vigna<EMAIL_ADDRESS>wrote:

@dlyubimov https://github.com/dlyubimov no, actually there are newer
versions. I am doing a release in few days with a lot of small glitches
fixed thanks to the Guava test suite. Current version is 7.0.10.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/81#issuecomment-193532497.

Seems like it's ASL 2.0 -
https://github.com/vigna/fastutil/blob/master/LICENSE-2.0
+1 from me, good to go.
On Mon, Mar 7, 2016 at 7:21 PM, Dmitriy Lyubimov<EMAIL_ADDRESS>wrote:

@vigna https://github.com/vigna is 0.7.2 fastutil is still the best
version to use? I can't immediately find the license on it?
@smarthi https://github.com/smarthi et. al. : need a few votes on
inclusion of fastutil as a dependency
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/81#issuecomment-193522992.

+1 from me too

@vigna Please also update the LICENSE.Txt file for fastutil.
https://github.com/apache/mahout/blob/master/LICENSE.txt
Thanks again for this.

@smarthi Do you want me to modify that file and add "fastutil" to the list of projects to which the license applies?

BTW, I noticed that SparseMatrix can undergo the same improvement with near-to-zero effort. Do you want me to pack everything into this pull request or do you prefer to merge this part and then I'll work on SparseMatrix?

Yes
Sent from my iPhone

On Mar 8, 2016, at 3:31 AM, Sebastiano Vigna<EMAIL_ADDRESS>wrote:
@smarthi Do you want me to modify that file and add "fastutil" to the list of projects to which the license applies?
—
Reply to this email directly or view it on GitHub.

Let's merge this first, please create another PR for sparsematrix. Thanks again for this.
Sent from my iPhone

On Mar 8, 2016, at 3:50 AM, Sebastiano Vigna<EMAIL_ADDRESS>wrote:
BTW, I noticed that SparseMatrix can undergo the same improvement with near-to-zero effort. Do you want me to pack everything into this pull request or do you prefer to merge this part and then I'll work on SparseMatrix?
—
Reply to this email directly or view it on GitHub.

It's all done.

Thanks @vigna.  We'll merge this in the next day or two.

Not sure it's still needed but +1 from me. I've used fastutils in other projects quite successfully. This might also be the basis for faster BiMap implementation. Will look into this for a future release.

Its great to see this getting merged!

@vigna https://issues.apache.org/jira/browse/MAHOUT-1801

@vigna if i may suggest a topic: we need a fast way to approximately estimate sparsity inside a matrix and reconstitute it into a dense matrix (with a given row- or column-major order) and vice versa. It is right now a big performance issue with distributed (and in-memory) algebra as many distributed operators tend to always form sparse structures even if result doesn't warrant it (completely dense).
so it would be nice to have a method on a matrix, something like "sparsityAnalysis" that accepts sparsity threshold (double) and returns a matrix: self if sparsity is within threshold for the current data structure, or rewrite itself as a dense/sparse counterpart using requested row or column major order (this is known as part of matrix "flavor").

@vigna so for example:
def MatrixOps$sparsityAnalysis(sparsityThreshold:Double=.25):Matrix

i have SparseRowMatrix mxA which is 95% dense. I then call
mxA = mxA.sparsityAnalysis()

and now mxA is a DenseMatrix.
This internally will of course rely on some implementation-specific api that can tell us sparsity estimate (or that it doesn't know how to estimate sparsity).

@dlyubimov created M-1801 today, its best to capture the above comments in the Jira there.

Er... this says that there are unmerged commits. Why?

where u see that @vigna ?

Oh well. It just vanished. I'm new to this stuff. Probably something happened in the last few minutes.

I created a new pull request https://github.com/apache/mahout/pull/186 for the sparse matrix implementation.


not able to see the .npy arrays as images

I am not able to see the mask and ROI generated as images.. What is the code to do so? Help required

@chiranjeev1111  you should run the scripts in Data process folder. So when you execute second script properly you will get numpy array for the corresponding training and testing images and mask.

@chiranjeev1111 you should run the scripts in Data process folder. So when you execute second script properly you will get numpy array for the corresponding training and testing images and mask.

excuse me, do you konw what saved in data.npz?
here is the error message : FileNotFoundError: [Errno 2] No such file or directory: 'data.npz'


Updated status of raw_identifiers feature

Depends on https://github.com/rust-lang/rust/pull/53236.

@alexreg can you fix the conflicts please? :)

@Centril Done!

@alexreg  unfortunately the build fails ;)

@Centril Yeah, it's just waiting on https://github.com/rust-lang/rust/pull/53236 now (which removes the need for the feature gate for raw idents, of course). Just look how many failed roll-up merge attempts there have been. 😄

@alexreg Jesus...!  Oh well; please cc me when it is OK to merge this :)

@Centril Haha yes. I'll try to remember! My Rust Book PR is also blocked on the main stabilisation PR so...

Thank you!


Remove virtualenv from the docker image

Don't use virtualenv in the docker image, but install metricq globally, which makes basing images on top of the image easier.

Fixed in 35d64efa56cd455640dd3c8e8276ba0c33336eda


[Beta 2.0.0] Template Error

When trying use a feed in a template, the following error is returned:

Neither the property "feed" nor one of the methods "feed()", "getfeed()"/"isfeed()" or "__call()" exist and have public access in class "Craft\FeedMeVariable"

Sorry about that, fixed as of the latest master!

Thanks, Josh!


Word-wrap SCSS helper applied to summary component

Trello: https://trello.com/c/Wyvjf3eH/475-entering-long-words-into-the-title-summary-body-displays-over-other-content-on-the-page
This borrows from this helpful CSS tricks article 1 a technique to
break up long lines of text that can break our applications layout.
Aside from extreme user testing (e.g. massive 100+ character words) the
most likely place we will see this is when a user has a URL in their
text.
This resolves the issue by forcing the word wrap. This does
unfortunately have a consequence that in IE11/Edge/Firefox we get breaks
in the middle of words rather than at the end (as they don't support the
non-standard property of break-word). I don't think there's a way around
that so we may have to decide to just drop this functionality if it
provides more confusion than problems it resolves.
This works with no problems in Chrome:

breaks words in Firefox/Edge 😞:

@alex-ju with regard to the word breaking aspect, do you think this is a net improvement or not? and do you have any ideas how we can defeat that?

Indeed, not ideal. But I don't see other solution. It does what the card says.
It's a shame that for for this edge case when someone enters an insane number of alphanumeric characters (without any space or non-alphanumeric characters - which I don't think it's a real use case) we'll have to worsen the experience for all Firefox and IE users. 😞

Closing this as we're hoping to avoid having to degrade the IE/Firefox wrapping experience and hope to look at this again when we have more time.


Consume SOAP Web Services in SAP Cloud Application Programming Model (CAP)

Tutorials: https://developers.sap.com/tutorials/cap-soap-service.html
I understand connecting to SOAP service residing in the On-Prem system is not in the scope of this tutorial but is it possible to add notes or something as a guidance or workaround in case someone is working on similar requirement? There are plenty of SOAP services which we need to expose to BTP platform for consumption on our CAP JS project but not getting any official guidance or best practice.

https://help.sap.com/docs/connectivity
https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/cloud-connector


fix: [new-components] 'id' attribute isn't rendered for some components.

🐛 Bug Report
FluentComponentBase got Id parameter and needs to be rendered explicitly now. In version 2.x.x Id was captured by AdditionalAttributes and rendered with @attributes="AdditionalAttributes".
Many components don't render Id: FluentAccordion, FluentAccordionItem, FluentAnchor, etc. These affects cases when JS interop relies on 'id' e.g. Tabs - Dynamic example - overflow badge doen't show menu on click 'cause FluentBadge doens't render id and anchored menu cannot subscribe to badge's clieck event using id.
Btw, Tabs demo page isn't working at the moment because of missing icons - size 12:
The requested icon (Dismiss, Size12, Regular) is not available in the collection.
💻 Repro or Code Sample

🤔 Expected Behavior
id attribute rendered for components that inherit FluentComponentBase
😯 Current Behavior

💁 Possible Solution

🔦 Context

🌍 Your Environment

OS & Device: [e.g. MacOS, iOS, Windows, Linux] on [iPhone 7, PC]
Browser [e.g. Microsoft Edge, Google Chrome, Apple Safari, Mozilla FireFox]
.NET and FAST Version [e.g. 1.8.0]

FluentComponentBase got Id parameter and needs to be rendered explicitly now. In version 2.x.x Id was captured by AdditionalAttributes and rendered with @attributes="AdditionalAttributes". Many components don't render Id: FluentAccordion, FluentAccordionItem, FluentAnchor, etc. These affects cases when JS interop relies on 'id' e.g. Tabs - Dynamic example - overflow badge doen't show menu on click 'cause FluentBadge doens't render id and anchored menu cannot subscribe to badge's clieck event using id.

Id needs to be rendered explicitly indeed. That is a deliberate choice we made so we don't put Id's into the HTML everywhere (even when they are not being used). We made it a nullable property in FluentComponentBase so it won't get rendered if it is null. Where needed, we changed the constructor for components so a value will be set for the Id. For example:
public FluentAccordionItem()
{
      Id = Identifier.NewId();
}

And you HTML looks like this:

Apparently, we forgot to do this for the example/components you mentioned. I added the Id to the FluentBadge and that seems to do the trick:

Btw, Tabs demo page isn't working at the moment because of missing icons - size 12:
The requested icon (Dismiss, Size12, Regular) is not available in the collection.

See, I told you we would need extra required icon settings in project file sooner or later 😁. I added one for size 12 (with this icon) to the project file.

Hi Vencent,
Thank you for a quick response)
It just feels that Id parameter sets an expectation that if it's set, it will rendered in HTML element. If it's rendered only for a subset of components, this creates confusion and may limit options for composite controls creation

Maybe we can add it to every web component rendering? By default, it is null and won't be outputed. We will add it in constructor for components where needed. If you need/want to create a value for it yourself, that could be done in OnParameterSet or OnInitialized. Would that work? @dvoituron any thoughts?

If Id is assigned in constructor, it can also be overridden in .razor. Tabs-Dynamic example and DemoSection.razor set id for FluentTab-s, replacing value assigned FluentTab's constructor.
The issue is more how to have it rendered consistently across all components, rather than how to assign it. Seems like the only option is to add id="@Id" to the components where it's missing)

Hi @andreisaperski are you clear on how we intended it to work? Can this be closed?

yeah, it can be closed


Use retrying instead of our own implementation.

Our implmentation does not account for time spent trying stuff. When we're
trying slow things that fail, this ends up being the lion's share of the time.

looks good

Thanks. I'll push Monday after making sure the tses pass.


The demo site show carrier name as ??? when locale is fa

Hi there.
I checked the demo site of libphonenumber with fa locale. It can show English names of carriers. But It can't show carrier name when locale is fa(Persian/Farsi). You can check here and here and compare Location Field of them.
I think it's because encoding of html page which is not UTF-8! Please fix it.

Yes, we know ;)  Thanks for the report; we'll try and fix this although our metadata updates have priority right now, so it might have to wait a short time.

This was fixed with https://github.com/googlei18n/libphonenumber/issues/1646


[FEATURE] Support GZIP and Deflate Compression

Issue
Setup:
Add support for deflate and gzip encoding in body-parsers.
Details
Currently gzip and deflate are not supported in Opine and throw a 415 error. This issue is to add support to Opine for these two standard options which is now possible due to modules being made available in the Deno userland.
Relevant file: ./src/middleware/bodyParser/read.ts Line 117.
Modules to explore:

<EMAIL_ADDRESS><EMAIL_ADDRESS>https://deno.land/x/denoflate

@asos-craigmorten i think i will grab this one and give it a shot!

Im assuming this would be a deno idiomatic port of https://github.com/expressjs/body-parser/blob/master/lib/read.js?


SyntasticInfo shows Xml for ts

Trying to use tslint checkers "tsc" or "tslint" and getting this report on SyntasticInfo for any *.ts file.
Syntastic version: 3.7.0-67 (Vim 704, Darwin)
Info for filetype: xml
Global mode: active
Filetype xml is active
The current file will be checked automatically
Available checkers: plutil xmllint
Currently enabled checker: xmllint

My config
let g:syntastic_javascript_checkers = ['jshint']
let g:syntastic_typescript_checkers = ['tslint', 'tsc']
let g:syntastic_check_on_open=1
let g:syntastic_enable_signs=1

What am I missing?  Thanks.

Info for filetype: xml

Syntastic decides what checkers to run based on Vim filetypes (see :h filetype).  Vim doesn't automatically detect TypeScript files, so you need some other Vim plugin to do that for you.  From a quick search, an example of such plugin is typescript-vim.

I've the same problem, and I've typescript-vim installed.

@janbaer If it is "the same problem", then you're complaining to the wrong forum.  I suppose we'll never know. :)

In the meantime I found a solution:
autocmd BufNewFile,BufRead *.ts setlocal filetype=typescript

@janbaer Then please post a PR to typescript-vim.  It has nothing to do with syntastic.


Upload new LIVD table

Problem statement
The LIVD team sent over a new LIVD table that needs to be uploaded into ReportStream.
What you need to know
https://app.zenhub.com/files/304423150/73edc4fc-503a-44dd-a7e2-029b9a6432af/download
To do
Run livd-table-update command with new table

Closed as duplicate of #7956


Plugins overview has swapped descriptions for output and processor

URL for relevant page?
https://docs.influxdata.com/telegraf/v1.11/plugins/
What products and version are you using?
Telegraf (v1.6 - v1.11)
Where did you look before opening the issue?
Issues page

I noticed that the descriptions for output and processor plugins seemed swapped in a bunch of places.
It should be changed so that:

Output plugins are always described as "write metrics to various destinations."
Processor plugins are always described as "transform, decorate, and filter metrics."

Thanks, @kevin-cantwell!

Hi @stevebang thanks for closing, but just fyi the PR you submitted only fixes a subset of the typos. I do have a PR open that fixes them all I believe. Please take a look at merge it if it looks good to you: https://github.com/influxdata/docs.influxdata.com/pull/2320


Remove password used in tests

This password is used in some tests and consequently was causing failures.

This is also my password for all my production accounts so it would be good to allow it here too.


Clustered KSQLDB support

Is your proposal related to a problem?
We decided to deploy multiple ksqlDB per use case (e.g one service one ksqlDB) as recommended by ksql docs in one kafka cluster. However, when we try to integrate ksqlDB to kafka-ui, we don't see any setting to setup this configuration.
Describe the solution you'd like

Support multiple ksqlDB in one cluster like kafka connect.
As environment variable
KAFKA_CLUSTERS_0_KSQLDBSERVER_0_NAME=first
KAFKA_CLUSTERS_0_KSQLDBSERVER_0_ADDRESS=http://localhost:8088

or as config YAML file
kafka:
  clusters:
    - name: local
      ksqldbServer:
        - name: first
          address: http://localhost:8088
      kafkaConnect:
        - name: first
          address: http://localhost:8083
      jmxPort: 9997

Describe alternatives you've considered
Deploy multiple kafka-ui for each ksqlDB
Additional context
ksqlDB docs - Deploy recommendation and best practices

Hey, thanks for the suggestion. We'll schedule this for the future releases (1-2 probably).

@next-govejero #4255 -> https://github.com/kafbat/kafka-ui


Godot 4.3

Update dependencies for using in Godot 4.3

This has been fixed with commit 988cf34bf8cd468135a15663e33d68502f04b5b9. This PR is no longer needed.  Thanks.


Quick start improvement suggestions

I went through the Quick start and I have a few suggestions. I did not know how to suggest improvements better than opening a ticket.
Suggestions:

All runnable scripts should have a bash or script notation so I can run them directly from the IDE. Found one issue here: https://github.com/stargate/stargate-mongoose/blob/5a27c8bb85356be248fa249407c5b115638a73e4/README.md?plain=1#L19-L22
I would prefer an option with yarn, rather than npm.. Or at least list both options, so people can chose..
Type script must be default, it has become de-facto standard..
Running the file with node v12 (which was by accident default), results in following, set the desired node version in the npm init and add to README.md (v14 seems to work):node index.js
/home/ise/workspace/open-source/mongoose-stargate-sample/node_modules/mongodb/lib/operations/add_user.js:16
        this.options = options ?? {};
                                ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/ise/workspace/open-source/mongoose-stargate-sample/node_modules/mongodb/lib/admin.js:4:20)
    at Module._compile (internal/modules/cjs/loader.js:999:30)

sample code is very hard to read, I would separate it into logical blocks (comment only before the block, not between the lines):

imports
driver override (very important)
schema setup
endpoint defintions and app running

sample code should be formatted with prittier (currently not formatted at all)

@ivansenic Thanks for opening a ticket with the feedback/suggestions, this will really help improving the 'Quick Start' experience. I'll work on these and will update.


[production] Long string in wiki overruns project overview page

Behavior: A long string in a wiki (i.e. a long URL) runs over the "wiki" area in the project overview page:

Expected: String would be truncated or forced to wrap to the next line so as not to run into the "components" area of project overview page.
Possible solution: I think it makes most sense to truncate the string.

any updates on this?

@caneruguz This in your arena? Maybe can/will be tackled via you and @brianjgeiger with 0.25.0 Wiki improvements?

This is a tiny change that nearly anyone could do in a hotfix if we wanted. Should just be adding {word-wrap: break-word;} to the css for the wiki widget.

@huangginny You feel like knocking this one out? TY

I am not seeing this issue's behaviour.

@jlcohoon and/or @saradbowman can you confirm?

I am still seeing it:

This is an issue with Chrome and Safari..... works fine with Firefox

@lbanner @GaryKriebel I can quickly fix this.

FYI, site.css already has this helper class:
.break-word {
    word-wrap: break-word;
}

so this will work
<div class="break-word">
  longlonglonglonglonglongtext
</div>

OK @caseyrollins  -- switched from @lyndsysimon -- he has other priorities in any case -- TY!


UI: Added support spark and script files in archive

This adds support to correctly display py files referenced from spark and script operators

closing as pointing to the wrong branch


Accept paths to user-controlled SSL cert

This PR makes it so the user can control the SSL certificate used by moto_server. This is particularly useful to whitelist the certificate when writing blackbox tests: for example, being able to pass in an AWS_CA_BUNDLE for boto, or REQUESTS_CA_BUNDLE for requests, which points at your self-signed certificate.
The existing behavior is unchanged: run with an auto-generated SSL certificate by doing
$ moto_server --ssl

Now you can alternately specify the certificate and private key files:
$ moto_server --ssl-key key.pem --ssl-cert cert.pem

Coverage decreased (-0.006%) to 92.752% when pulling 86fed8ba27a489d09a6c590dcdd76053c2357dd6 on jbergknoff-10e:jbergknoff/ssl into cb364eedc6e4edcfa3c65f152c7d13f1e5fe2ea4 on spulec:master.

Coverage decreased (-0.006%) to 92.752% when pulling 86fed8ba27a489d09a6c590dcdd76053c2357dd6 on jbergknoff-10e:jbergknoff/ssl into cb364eedc6e4edcfa3c65f152c7d13f1e5fe2ea4 on spulec:master.

This is great, thanks. Welcome to Moto!


Detail question regarding StreamingAggregator methods and characteristics

In order to implement digest calculation of all binary data in a partitioned cache I started looking at the streaming aggregator and I found some aspects of it very suitable for the task.
When starting to develop with it I realized there where a few things I was not sure I had understood correctly.
Firstly I am not sure how some of the characteristics really work:
PARALLEL - felt fairly obvious and and an option I generally always want. In combination with BY_MEMBER one aggregator will run on each storage enabled node and with BY_PARTITION as many aggregators will run on each storage enabled node as there are partitions owned by them each. A question mark for me is however if it is the "instance itself" that have the characteristic that will be parallelized or its "sub aggregator" created by calling the supply method? Assuming the initial aggregator have options PARALLEL and PER_PARTITION what options should the aggregato(s) created by "supply" have? Just PARALLEL or?? Is characteristics only valid/obeyed on the initial top-level aggregator object? If not what is the effect when applied to member or partition level aggregator objects??
PRESENT_ONY is however a weird one - when would an aggregator EVER be passed non-existing entries? I do not get the meaning of this one...
RETAIN_ENTRIES is not clear for me either - in my case I will, while an instance of an digest aggregator is running be holding on to passed in entries to be able to to order them by binary key in a canonical order before feeding them into the digest calculation (so that I get the same result irrespective of data insert order to the cache or whatever that could result in different processing order between different caches with the same data). Am I then supposed to specify this characteristic? My guess is that this is to isolate the aggregator from other operations mutating the entries it hold on to - something that is not a cosern for me as I only intend this operation to be used when no mutation is going on....
Also I would like to know HOW the aggregators that are run on the members (storage enabled nodes) in the cluster are "created" - initially I assumed the "supply" method to be called to provide an aggregator instance that is then serialized, sent and executed as many times as was requested (BY_MEMBER or BY_PARTITION) but from my program behaves I am now guessing the original passed in aggregator object itself is serialized and once it is received by each "member" the "supply" method is called to create one or more "sub aggregators" or?
As I understand the documentation the operations described by the StreamingAgregator interface can logically be group as belonging in the top-level aggregator (supply, combine and finalizeResult) or the sub-aggregators (executed once per member or partition) i.e. accumulate, getPartialResult - is this right?
I would like to understand if the "accumulate" method passing in a "streamer" always will be the one that is called and the default implementation of the method calls the single entry "accumulate" method?! And how does the "aggregate" method relate to the "accumulate" ones?
Finally is it correct to say that accumulation will always be just two "levels" first a single top level aggregator and then a second tier running either once on each member or once per partition - or is it possible to create deeper architectures where one aggregator run per member that in turn specify the "PER_PARTITION" would be able to aggregate a third level of aggregators that are run one per partition?

Eventually I also figured out what the meaning of RETAIN_ENTRIES - it seems like the aggregator framework makes some optimization and REUSES the entry object passed in to the accumulate method calls (I had naively assumed these where the actual backing map entries but this is not the case so unless one immediately "consumes them" this "flag" is needed...
Still not sure about PRESEN_ONLY and the question about how to use these settings affects sub aggregators...

Hi @javafanboy, that's good sleuthing, this looks correct to me.
RETAIN_ENTRIES saves on serialization cost at the (slight) risk of processing stale data. If your cache is stable you can do this. PRESENT_ONLY is for cases where entries may have been removed. That can absolutely be due to expiry when the backing map supports it. Most OOB aggregators use this setting as they work off of values.


fix: do not print timestamps in diff output

Fix #142

he guys, the title is "do not print timestamp", does that mean it will still sync them, but just not showing them?

thx for the clarification!


Using Cookies

Is it possible to specify cookie params (via yml file or programmatically) which are automatically injected into the SUT?
I would really like to give this project a try but our System heavily relies on this feature.

You can configure your Chrome browser by using chromeOptions param. For example,
  chrome:
    desiredCapabilities:
      version: "48.0"
      browserName: chrome
      chromeOptions:
        prefs:
          profile:
            default_content_setting_values:
              geolocation: false

But not all browsers support it.


[breaking change] remove global variables and functions (item(), exec(), _, items, current)

The following variables and methods are globally available when defining menus :

item()
exec()
_
items
current

These references should be imported using regular "require" statements as in :
var item = require('hotshell').item
var exec = require('hotshell').exec
var _ = require('underscore')

item({desc: 'topten'}, function () {

    var topTen =
        'echo "history" | bash -i 2>/dev/null | sed "s/^ *[0-9]* *//" | ' +
        'sort | uniq -c | sort -nr | head | sed "s/^ *[0-9]* *//"'

    _(exec(topTen).split('\n')).each(function (el, ix) {
        item({key: ix, cmd: el})
    })
})

Wow!
I'd not noticed this breaking change while upgrading HotShell to last version.
This add a lot of boilerplate code (like the Java's imports btw).
But I believe you made this change with good reason 😉
Maybe provide an "upgrade guide" when encountered these error messages:
ReferenceError: 'item' is not defined
motto: motto: ReferenceError: 'exec' is not defined
ReferenceError: '_' is not defined

Going to change all HotShell menus in several QS projects 🤘


An error occurred during the push operation: / Inaccessible host

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
16.1.0
Amplify CLI Version
8.3.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
Not applicable
Amplify Commands
push
Describe the bug
In attempting to migrate. to the v2 transformers, upon running 'amplify push', i run into the following error and output from the CLI:
An error occurred during the push operation: /
Inaccessible host: amplify-lacarte-lacarteenv-122559-deployment.s3.ap-southeast-2.amazonaws.com' at port undefined'. This service may not be available in the `ap-southeast-2' region.
Following this, I am unable to run 'amplify push' again unless i delete deployment-state.json from S3.
Subsequently, for whatever reason, every time I run 'amplify push' and it begins 'updating files', my internet also dies out...
Seems to be related to the issue as I am able to reproduce it consecutively.
I was able to run 'amplify migrate api' successfully and convert my schema to the new format. Strangely enough, the 'amplify push' was successful on one occasion and it partially updated my environment.
I am now also unable to revert to the v1 transformers as the above issue occurs again when I modify cli.json to version 1 and run the 'amplify push' command again.
Any help would be appreciated!
Expected behavior
Running 'amplify push' would update the environment with the new migrations.
Reproduction steps

Run 'amplify migrate api' to update schema to new format
Run 'amplify push'
At 'Updating Files' phase, error occurs & internet loses connection.

 LocateConnection
  searchLocations(input: String!): LocalesConnection
}

input LocateUserInput {
  type: String!
  coordinates: [Float]!
}

type LocateConnection {
  items: [City]
  total: Int
  nextToken: String
}

type LocalesConnection {
  items: [Locale]
  total: Int
  nextToken: String
}

Log output

# Put your logs below this line

Additional information

Thanks for the prompt reply @josefaidt. No the partial migration had other errors, certain tables updated successfully and other had UPDATE_FAILED.

When migrating back to transformer v1 we will also want to change useexperimentalpipelinedtransformer to false, and we can confirm the manual migration back to v1 by running amplify api gql-compile.

Can confirm useexperimentalpipelinedtransformer was set to false in cli.json. I was able to run amplify api gql-compile and have my schema compile successfully (the same occurred when i ran amplify push), however the same error mentioned above still persists.

Hey @mnikolic10 thank you for clarifying and as a note, this line sticks out:
Cannot perform more than one GSI creation or deletion in a single update

Prior to migrating were there @key directives in your schema that were later changed in favor of the newer relationship directives like @hasMany?

No, I wasn't using any @key directives, I do have quite a few @connection directives though.

@josefaidt any updates or recommendations? Keen to avoid having to recreate all of my tables

Hey @mnikolic10 can you share the contents of your amplify/cli.json file?

@josefaidt sure, shared below:
{
"features": {
"graphqltransformer": {
"addmissingownerfields": false,
"improvepluralization": true,
"validatetypenamereservedwords": true,
"enableiterativegsiupdates": true,
"secondarykeyasgsi": true,
"skipoverridemutationinputtypes": false,
"transformerversion": 2,
"suppressschemamigrationprompt": true,
"securityenhancementnotification": true,
"showfieldauthnotification": false,
"securityEnhancementNotification": false,
"useexperimentalpipelinedtransformer": true
},
"frontend-ios": {
"enablexcodeintegration": false
},
"auth": {
"enablecaseinsensitivity": false,
"useinclusiveterminology": false,
"breakcirculardependency": false,
"forcealiasattributes": false,
"useenabledmfas": false
},
"codegen": {
"useappsyncmodelgenplugin": true,
"usedocsgeneratorplugin": false,
"usetypesgeneratorplugin": false,
"cleangeneratedmodelsdirectory": false,
"retaincasestyle": false,
"addtimestampfields": false,
"handlelistnullabilitytransparently": false,
"emitauthprovider": false,
"generateindexrules": false,
"enabledartnullsafety": false
},
"appsync": {
"generategraphqlpermissions": false
},
"latestregionsupport": {
"pinpoint": 0,
"translate": 0,
"transcribe": 0,
"rekognition": 0,
"textract": 0,
"comprehend": 0
},
"project": {
"overrides": true
}
}
}

Hey @josefaidt  no worries, It was in the initial push with V2 transformers. I have had to create a new amplify backend instance and migrate my data across. Was not able to get passed the above issue without data loss (hence why i opted to migrate).
Happy for you to close the issue.


Remove All Influx/Graphite Code

Let me know if there is any code I missed (or anything I shouldn't have removed).
Still need to get tests_basic.py working.

❤

delete everything!

@elainearbaugh Got the tests working. Let me know when would be the best time to roll out these changes.

Yay! Thanks for the review. I'll deploy this to stage tomorrow.


[browser-wallet] Guarantee type safety for rich objective feeds

🥞 stacked on https://github.com/statechannels/statechannels/pull/3511
The browser wallet store defines feeds. The feeds are event emitters wrapped in an observable. This pattern does NOT provide type safety. The store can emit an event where the event name does not match the event data type.
With rxjs subjects, we guarantee type safety as well as reduce a level of indirection. Only rich objective feeds have been refactored. Legacy feeds from wallet
v1 remain as is.

Closing in favor of https://github.com/statechannels/statechannels/pull/3520


change installation strategy for pyright

Using npm to install a "python" language server might confuse new neovim/LSP users.
This PR changes the docs to use pip for installing pyright which automatically takes care of installing node etc.

https://github.com/microsoft/pyright is a node project though.

https://github.com/microsoft/pyright is a node project though. Going to skip the indirection unless there is a stronger reason for it.

No issues. It's just that the python package takes care of installing necessary node related stuff so users don't have to.


Creating html-report from Vacuum report does not support custom rules

When creating an html-report from a vacuum report, the html page only contains results for the default rules.
This is because when re-creating the nodes from the report data, the rule data is taken from the OpenAPIDefaultRuleSet and retrieved via the rule-id..
As custom rules are not contained in the default ruleset, the rule definition is nil.
This has the effect that the function for getting rules by category will exclude the results for custom rules by checking that the rule must not be nil.
I guess one option could be to put the ruleset used for creating the report into the report as well. Another one to let the user hand in the same ruleset again when creating the html-report and reading from the vacuum report file. (although that feels strange)

This is a bug.