Specify user secret directory with environment variable DOTNET_USER_SECRETS_DIR

Provide the possibilty to specify the user secret directory with the environment variable DOTNET_USER_SECRETS_DIR.
This can be used for development teams to store the secrets in a shared folder and protect them with the windows security.

Why not use one of the normal config providers in this scenario and read the environment variable in Startup.cs?
That said, is an environment variable granular enough when you're working on multiple projects?

Why not use one of the normal config providers in this scenario and read the environment variable in Startup.cs?

Because then the tool support with the dotnet user-secrets will not work

That said, is an environment variable granular enough when you're working on multiple projects?

Good question, maybe it makes sense to check environment variables in this order:

DOTNET_USER_SECRETS_DIR
DOTNET_USER_SECRETS_DIR_<USER_SECRET_ID>
APPDATA
…

But the question is, how the user secret id should be mapped to the environment variable, because not all characters are allowed here. E.g. in a linux bash, only charasters, digits and underscores can be used.

Since this is a feature request that requires additional design, please open a corresponding issue.

Closing this for now. As @Tratcher said, we really need to talk about a way to design this properly, based on the underlying problem (sharing user secrets). There are a lot of concerns we need to review before we could make a change to support that scenario and just adding support for an env var here might not be the right approach.
Please do file an issue and we can discuss the underlying request!

@Tratcher, @anurse Done: https://github.com/aspnet/Extensions/issues/2739


Features todo

map, adding the location of the house in a map just like airbnb
continuous integration/delivery: gitlab/travis ci -> heroku & netlify
Listing and User update features on server and web
caching for the backend (zero db reads, zero reads on submission)  , similar to update caching shown in the udemy video "caching techniques" by the reddit founder!
Server Pagination done properly on the server for web and app

Hi Ben,
If you have time could you consider doing search server side for app and web?
Bw

I'm not going to do the web, but I will be doing the app and it would be a similar task on the web


Trying to Get domain on  ec2-34-206-8-177.compute-1.amazonaws.com throws exception

Trying to parse to get the domain from ec2-34-206-8-177.compute-1.amazonaws.com and getting an exception.
Using:
var domainParser = new DomainParser(new FileTldRuleProvider("public_suffix_list.dat");
domainParser.Get("ec2-34-206-8-177.compute-1.amazonaws.com");
The exception is:
throws Exception of type 'Nager.PublicSuffix.ParseException' was thrown.
Unknown domain ec2-34-206-8-177.compute-1.amazonaws.com
"ec2-34-206-8-177.compute-1.amazonaws.com" was returned from a reverse DNS on the IP address.  So it should be valid.

Hi Guys I'm still having this issue, also with ec2-3-28-82-165.compute-1.amazonaws.com ... was this fix confirmed?


Updated-SharePoint Framework development with SharePoint Server 2019 & SharePoint Server SE

Category

[ ] Content fix
[ ] New article
[ ] Example checked item (delete this line)

DELETE THIS LINE BEFORE SUBMITTING | For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

DELETE THIS LINE BEFORE SUBMITTING | If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

What's in this Pull Request?

DELETE THIS LINE BEFORE SUBMITTING | Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Submission guidelines

!!IMPORTANT!! - All submissions must complete the baseline sections included in this template. Ignoring or deleting this template may result in closing the issue with the label type:incomplete-submission.
Follow our guidance on How To Create Good Pull Requests.
Target the main branch of this repo.
When changing a page, ensure you update the ms.date front matter wih the current date in the format MM/DD/YYYY.
Review all build checks and address the automated errors, warnigns, and suggestions.
NOTE: The live site is based on the live branch. Site owners periodically refresh live branch from the main branch so merged PRs won't immediately appear on the live site. Please be patient to see your changes appear on the live site.

DELETE THIS SECTION BEFORE SUBMITTING

I'm closing this with prejudice because you're duplicating your previous PR submissions without addressing the issues I've raised in your previous submissions. This also applies to #8770

When submitting a PR, the new PR includes a template & form for you to complete. This must be completed, but you're ignoring it. This makes it easier to understand what the PR is for and what it covers. This is REQUIRED. (ref).
You've added a tutorial on creating an SPFx project for SP 2019. We do not want to have this in this doc. There is nothing special about creating or deploying an SPFx component for an on-prem SharePoint deployment vs. SharePoint Online. Thus the docs already have tutorials. We don't want to add more tutorials that duplicate existing ones as it adds more maintenance work and can increase the chance tutorials get out of sync confusing customers.
The purpose of this page, and the associated one for SP2016, is to highlight differences between SPO & the on-prem deployments WRT developing SPFx components. That includes the dev tooling installs and their versions. We don't want to repeat the steps already documented for general environment setup... we only want to list different versions. Thus, no tutorial is intended for this doc.
You've split the doc into two things: one for SP2019 & one for SP SE. This is unnecessary. The SPFx development story for SP2019 & SP SE is identical. The existing doc already addressed this.

Please don't do this again.
If you repeat this, future submissions will be closed without explanation.

Closing this PR as i have created a new "https://github.com/SharePoint/sp-dev-docs/pull/8820" with the template.


Personal Device backup not getting reconfirmed.

Personal Device backup not getting reconfirmed.

Unable to replicate, the personal device backup got reconfirmed after logging into the keeper app.

Verified this issue on dev app v2.0.70(431)


[Additional Parameter Request] Codeunit 408 DimensionManagement - OnBeforeGetDimensionSet

Hi team,
In Codeunit 408 DimensionManagement procedure GetDimensionSet we would like to have the ability to customize how the code works, for that we would need some additional parameters added to event OnBeforeGetDimensionSet: DimSetID: Integer and IsHandled: Boolean, also IsHandled: Boolean would need to be added as local variable:

[IntegrationEvent(false, false)]
local procedure OnBeforeGetDimensionSet(var TempDimensionSetEntry: Record "Dimension Set Entry" temporary; var DimSetID: Integer; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Write an explanation of the different repositories in this starlarky repo

Explain how the syncing happens upstream
Explain how larky depends on libstarlark
Explain how the patches work on libstarlark and why they're needed
Explain the general layout of the project and additions by VGS to create Larky Script

@blaisep-vgs @aslepakurov did this get resolved with #75 ?

https://github.com/verygoodsecurity/starlarky#readme


AKAudioFile Export Fails

I've been trying to record and save audio files in my app, but have been getting errors like this:
Export Failed Optional(Error Domain=NSURLErrorDomain Code=-1 "unknown error" UserInfo={NSLocalizedDescription=unknown error, NSErrorFailingURLStringKey=/private/var/mobile/Containers/Data/Application/AA50830D-157C-4940-BBB5-2003D9B1A586/tmp/D44BFA64-D3BF-4166-9A16-8C3D8A04E49C.caf, NSErrorFailingURLKey=/private/var/mobile/Containers/Data/Application/AA50830D-157C-4940-BBB5-2003D9B1A586/tmp/D44BFA64-D3BF-4166-9A16-8C3D8A04E49C.caf, NSURL=/private/var/mobile/Containers/Data/Application/AA50830D-157C-4940-BBB5-2003D9B1A586/tmp/D44BFA64-D3BF-4166-9A16-8C3D8A04E49C.caf, NSUnderlyingError=0x17004edc0 {Error Domain=NSOSStatusErrorDomain Code=-12935 "(null)"}})
I thought it might be something I'm doing wrong with my own app, so I tried building RecorderDemo. It works perfectly if you use ./build_frameworks.sh and include AudioKit as an embedded framework. But if you use cocoapods instead without changing anything else, the error above occurs.
It seems like there's been a lot of recording/saving issues recently, so maybe this can point us in the right direction to get this resolved.

yeah, this is probably related to https://github.com/audiokit/AudioKit/issues/754 but we can keep both issues open until its resolved.  Interesting that Cocoapods behaves differently.  Are you on the master branch?  There have been a few pull requests to master that its possible that its more up to date than Cocoapods.  We should probably make a release soon to see if that at least normalizes things.

Not entirely sure where cocoapods is pulling from, but I know it's on 3.5.3.

I'm also seeing a similar issue with a variation of the RecorderDemo exercise file. Also using Cocoapods with 3.5.3.
deleteFileWithFileName "79F0E6E7-DD78-450B-8E7F-4550FEEFC362.caf" deleted. cleanTempDirectory() 1 files deleted initialize() AKAudioPlayer Warning:  "6096A844-A3AB-4A79-8C32-927FA0EFA247.caf" is an empty file record() AKNodeRecorder: recording record() AKNodeRecorder writing (file duration: 0.1 seconds) record() AKNodeRecorder writing (file duration: 0.2 seconds) record() AKNodeRecorder writing (file duration: 0.3 seconds) record() AKNodeRecorder writing (file duration: 0.4 seconds) record() AKNodeRecorder writing (file duration: 0.5 seconds) record() AKNodeRecorder writing (file duration: 0.6 seconds) record() AKNodeRecorder writing (file duration: 0.7 seconds) record() AKNodeRecorder writing (file duration: 0.8 seconds) record() AKNodeRecorder writing (file duration: 0.9 seconds) record() AKNodeRecorder writing (file duration: 1.0 seconds) record() AKNodeRecorder writing (file duration: 1.1 seconds) stop() AKNodeRecorder: Recording Stopped. exportAsynchronously(name:baseDir:exportFormat:fromSample:toSample:callback:) internalExportSession session created queueExportSession(session:) ExportFactory: exporting session #0 Export failed: Optional(Error Domain=AVFoundationErrorDomain Code=-11800 "The operation could not be completed" UserInfo={NSLocalizedFailureReason=An unknown error occurred (-12936), NSLocalizedDescription=The operation could not be completed, NSURL=/tmp/6096A844-A3AB-4A79-8C32-927FA0EFA247.caf, NSUnderlyingError=0x60800005c3b0 {Error Domain=NSOSStatusErrorDomain Code=-12936 "(null)"}}) completionHandler() ExportFactory: session #0 Completed completionHandler() ExportFactory: All exports have been completed 2017-03-27 18:38:34.847 Sampler[96192:1527313] *** Terminating app due to uncaught exception 'com.apple.coreaudio.avfaudio', reason: 'player started when in a disconnected state'

@gazebofire 'player started when in a disconnected state' usually means your AudioKit's output is not set to the player node. You should probably use an AKMixer to connect the recorder and player nodes and then set AudioKit.output to be the mixer.


Getting error RejectedAccessException with TFvarplugin

Hi,
I am using TFVarplugin and getting below error. Pipeline working ok without this plugin.
I tried with v5.3, v5.5,v5.8-dev.
Error: org.jenkinsci.plugins.scriptsecurity.sandbox.RejectedAccessException:
Can you please suggest. If I need to update any config in my jenkinsfile or shall I use any other branch.

Can you share the Jenkinsfile code that your using?  Or the stack trace?

If needed, please reopen this issue with a copy of the Jenkinsfile that you're using.


No batman post 2010s eating pasta included. Need implementation urgently

Duplicate of #9 and #3

Please do not close issue, very important


Add a name getter on meta.

Looks like this was partially removed in a previous commit, but the setter
was still there. What do you think of adding it back in? If not, we can just
remove the setter as well.
This is still used by HTTP headers in the resource namespace, but I can add
the getter/setter in Fury instead if no other elements will use a name in
their meta.
cc @smizell

I almost think the header should now use the member element instead of name. Thoughts?

Yeah we may want to do that for consistency. HTTP headers are kind of a special case object type though since both the keys and values must be strings.

Just realized too that name is no longer in meta in the refract spec.
On Mon, Jun 1, 2015 at 10:45 PM Daniel G. Taylor<EMAIL_ADDRESS>wrote:

Yeah we may want to do that for consistency. HTTP headers are kind of a
special case object type though since both the keys and values must be
strings.
—
Reply to this email directly or view it on GitHub
https://github.com/refractproject/minim/pull/39#issuecomment-107701516.

Closing this for now, as this is currently no longer in the Refract spec.


Define testing directives, vectors, protocols

Idea of how to implement it:
A decorator used with the component, that contains the fully measurable circuit (fmc). The decorator identifies the grating couplers and electrical pads and labels them accordingly (including a common reference to the fmc). Additionally, it provides measurement ranges (e.g. current/voltage ranges incl. compliance and Fixed Wavelength/Wavelength ranges, optical power etc.) and routines (e.g. one slow sweep one fast sweep) in a directive. Going even further we might add directives to deembed the device characteristics.
The directives are added as annotations to the gds.

How about using the info settings from components?
    import gdsfactory as gf

    dft = dict(wavelength=1.55, polarization="te", hastags=["optical", "te"])
    c = gf.components.straight(info=dict(dft=dft))
    print(c.info)
    c.write_gds_with_metadata("a.gds")
    c.show(show_ports=True)

Documented here
https://gdsfactory.github.io/gdsfactory/notebooks/07_mask.html#metadata


Create reem.md

I'm adding my take on a static site generator Reem. Coming up on its two year anniversary it has not received much exposure but I do believe its feature set is powerful and unique, deserving at least to be played with for experiment's sake. I was recommended to submit it here.

Sorry for taking so long to merge this in - thanks for submitting it!


Add _IrcTestCase.messageDiffers + Make testCapRemovalByClient not specific to Oragono

Works for me --- feel free to substitute two caps that are more widely supported, if you prefer.

That's what I did initially, but the test relies heavily on them being echo-message + server-time to check server-time was actually disabled :D
I can rewrite the test later though

shipit


WIP: fix(themes): powerlevel10k_classic renders without gaps on startup

fix: powerlevel10k_classic renders without gaps on startup
Related to #201
Prerequisites

[x] I have read and understand the CONTRIBUTING guide
[x] The commit message follows the conventional commits guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Description
My solution is pretty much replacing postfix spaces with \u2588 and the correct color.
The session segment could not be fixed that way here I had to remove the postfix color.
Reviewing my changes made me realize it could be related to inline coloring code for the prompt since the session segment added a gap every time I restored the original color on this segment.
Off-Topic: I see you require a test for the bug fix and documentation to be updated.
I would need guidance here though because I am not a Go programmer and I've never written an integration test in any language where PowerShell was a component. The documentation part is a bit unclear because it could mean that you require an entry in a CHANGELOG file which I understand or in the actual documentation which I wouldn't understand since the PR is fixing unexpected behavior.

@SirJson I've made a new PR #209 which tackles this all across the board. Thank you so much for this idea!


node flake "Call propagation Cancellation With a unary call" timeout.

Call propagation Cancellation With a unary call:
     Error: Timeout of 8000ms exceeded.

https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux/5004/testReport/junit/(root)/node_linux_opt_native/tools_run_tests_helper_scripts_run_node_sh/

Similar error in "Call propagation Deadline With a bidi stream call": https://grpc-testing.appspot.com/job/gRPC_master_windows/2523/testReport/junit/(root)/node_windows_dbg_native/tools_run_tests_helper_scripts_run_node_bat/

Same failure, different test: https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux_opt/562/testReport/junit/(root)/node_linux_opt_native/tools_run_tests_helper_scripts_run_node_sh/


Carefully prepare migration guidelines for 1.8.0

Recent refactorings were too massive to create deprecation notices / update changelog with migration guidelines. This means that we should take an especially good look at this aspect of the upcoming release.

@olafurpg Can you help me with this one please? I'm neck-deep in the 2.x refactoring, so I'll very much appreciate if you can take care of release notes this time.


SDK methods and events for Start/Stop Continuous recognize and send dtmf

Description
Added SDK methods and events for following features.

Start/Stop continuous DTMF recognition by subscribing/unsubscribing to tones.
Send DTMF tones to a participant in the call

All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-callautomation


SelectedTextBlock crash

Double-click here will cause the demo application crash.

refer to https://github.com/AvaloniaUI/Avalonia/issues/10731

Closed by https://github.com/AvaloniaUI/Avalonia/pull/11231


[WIP] Fix sync issue with policy enablement and check enablement

More testing needed, but I think this addresses the issue (https://github.com/istio/istio/issues/11699).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: douglas-reid
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
08b0f24899b394e2f1583f6897a98cf8c7c9f1c4
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
08b0f24899b394e2f1583f6897a98cf8c7c9f1c4
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
08b0f24899b394e2f1583f6897a98cf8c7c9f1c4
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

For configmap change,
/lgtm

@kyessenov: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

For configmap change,
/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: douglas-reid, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
08b0f24899b394e2f1583f6897a98cf8c7c9f1c4
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
08b0f24899b394e2f1583f6897a98cf8c7c9f1c4
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e0524c7c4689d2255eb9ef56129db3c4cfba92bf
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid What happens in case I want policy but also want to disable the policy checks just in case if it goes down it doesn't affect my data path. I may want the features of Policy but not let it affect my data path.

@harpratap I think that is what this flag is for:
    # policyCheckFailOpen allows traffic in cases when the mixer policy service cannot be reached.
    # Default is false which means the traffic is denied when the client is unable to connect to Mixer.
    policyCheckFailOpen: false

@douglas-reid pls correct me if I am off :)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, kyessenov, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenchenglu please merge, this ensures that options work as expected when policy checking is disabled or mixer is not installed at all.


Opensource :  6.2  Compare npm vs yarn

Description

Description 📜
Opensource :  6.2  Comapare npm vs yarn
NOTE 👇
Please put your doc 6.Popular_Projects with the name 6.2_npm_vs_yarn.md

Domain
Open Source
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Add client unpack opts

Added RemoteOpt to initialize remote context unpack option.
Signed-off-by: Brandon Lum<EMAIL_ADDRESS>

Hmm... is it possible to restart the CI? Seems to be failing on something not touched by changes.
--- FAIL: TestDaemonCustomCgroup (0.11s)
    daemon_config_linux_test.go:93: failed to dial "/tmp/containerd-test-new-daemon-with-config210406959/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /tmp/containerd-test-new-daemon-with-config210406959/containerd.sock: connect: connection refused": time="2019-11-14T01:55:09.357896091Z" level=info msg="starting containerd" revision=36194b9e80fac6ed22c2487a6aa82f3752bd5906 version=v1.3.0-111-g36194b9

LGTM


bug: Creating Personal Access Tokens on selfhosted site creates undefined error

Provide environment information
System:
OS: Linux 6.8 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
CPU: (4) x64 Intel(R) N100
Memory: 11.64 GB / 15.37 GB
Container: Yes
Shell: 5.1.4 - /bin/bash
Binaries:
Node: 20.11.1 - /usr/local/bin/node
npm: 10.2.4 - /usr/local/bin/npm
pnpm: 8.15.5 - /usr/local/bin/pnpm
Describe the bug
After creating a Personal Access Tokens and adding the name (any string) I then trigger the following error:

Reproduction repo
not applicable
To reproduce

I am running this on a coolify project using the following docker compose:

# documentation: https://trigger.dev
# slogan: The open source Background Jobs framework for TypeScript
# tags: trigger.dev, background jobs, typescript, trigger, jobs, cron, scheduler
# logo: svgs/trigger.png
# port: 3000
x-common-env: &common-env
  PORT: 3030
  REMIX_APP_PORT: 3000
  NODE_ENV: production
  RUNTIME_PLATFORM: docker-compose
  V3_ENABLED: true
  INTERNAL_OTEL_TRACE_DISABLED: 1
  INTERNAL_OTEL_TRACE_LOGGING_ENABLED: 0
  POSTGRES_USER: $SERVICE_USER_POSTGRES
  POSTGRES_PASSWORD: $SERVICE_PASSWORD_POSTGRES
  POSTGRES_DB: ${POSTGRES_DB:-trigger}
  MAGIC_LINK_SECRET: $SERVICE_PASSWORD_64_MAGIC
  SESSION_SECRET: $SERVICE_PASSWORD_64_SESSION
  ENCRYPTION_KEY: $SERVICE_PASSWORD_64_ENCRYPTION
  PROVIDER_SECRET: $SERVICE_PASSWORD_64_PROVIDER
  COORDINATOR_SECRET: $SERVICE_PASSWORD_64_COORDINATOR
  DATABASE_HOST: postgresql:5432
  DATABASE_URL: postgres://$SERVICE_USER_POSTGRES:$SERVICE_PASSWORD_POSTGRES@postgresql:5432/$POSTGRES_DB?sslmode=disable
  DIRECT_URL: postgres://$SERVICE_USER_POSTGRES:$SERVICE_PASSWORD_POSTGRES@postgresql:5432/$POSTGRES_DB?sslmode=disable
  REDIS_HOST: redis
  REDIS_PORT: 6379
  REDIS_TLS_DISABLED: true
  COORDINATOR_HOST: <IP_ADDRESS>
  COORDINATOR_PORT: 9020
  WHITELISTED_EMAILS: ""
  ADMIN_EMAILS: ""
  DEFAULT_ORG_EXECUTION_CONCURRENCY_LIMIT: 300
  DEFAULT_ENV_EXECUTION_CONCURRENCY_LIMIT: 100
  DEPLOY_REGISTRY_HOST: docker.io
  DEPLOY_REGISTRY_NAMESPACE: trigger
  REGISTRY_HOST: ${DEPLOY_REGISTRY_HOST}
  REGISTRY_NAMESPACE: ${DEPLOY_REGISTRY_NAMESPACE}
  AUTH_GITHUB_CLIENT_ID: ${AUTH_GITHUB_CLIENT_ID}
  AUTH_GITHUB_CLIENT_SECRET: ${AUTH_GITHUB_CLIENT_SECRET}
  RESEND_API_KEY: ${RESEND_API_KEY}
  FROM_EMAIL: ${FROM_EMAIL}
  REPLY_TO_EMAIL: ${REPLY_TO_EMAIL}
  LOGIN_ORIGIN: $SERVICE_FQDN_TRIGGER_3000
  APP_ORIGIN: $SERVICE_FQDN_TRIGGER_3000
  DEV_OTEL_EXPORTER_OTLP_ENDPOINT: $SERVICE_FQDN_TRIGGER_3000/otel
  OTEL_EXPORTER_OTLP_ENDPOINT: "http://trigger:3040/otel"
  ELECTRIC_ORIGIN: http://electric:3000
services:
  trigger:
    image: ghcr.io/triggerdotdev/trigger.dev:v3
    environment:
      SERVICE_FQDN_TRIGGER_3000: ""
      <<: *common-env
    depends_on:
      postgresql:
        condition: service_healthy
      redis:
        condition: service_healthy
      electric:
        condition: service_healthy
    healthcheck:
      test: "timeout 10s bash -c ':> /dev/tcp/<IP_ADDRESS>/3000' || exit 1"
      interval: 10s
      timeout: 5s
      retries: 5
  electric:
    image: electricsql/electric
    environment:
      <<: *common-env
    depends_on:
      postgresql:
        condition: service_healthy
    healthcheck:
      test:
        - CMD-SHELL
        - pwd
  redis:
    image: "redis:7"
    environment:
      - ALLOW_EMPTY_PASSWORD=yes
    healthcheck:
      test:
        - CMD-SHELL
        - "redis-cli -h localhost -p 6379 ping"
      interval: 5s
      timeout: 5s
      retries: 3
    volumes:
      - redis-data:/data
  postgresql:
    image: postgres:16-alpine
    volumes:
      - postgresql-data:/var/lib/postgresql/data
    environment:
      <<: *common-env
    command:
      - -c
      - wal_level=logical
    healthcheck:
      test: ["CMD-SHELL", "pg_isready -U $${POSTGRES_USER} -d $${POSTGRES_DB}"]
      interval: 5s
      timeout: 20s
      retries: 10
  docker-provider:
    image: ghcr.io/triggerdotdev/provider/docker:v3
    platform: linux/amd64
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    user: root
    depends_on:
      trigger:
        condition: service_healthy
    environment:
      <<: *common-env
      PLATFORM_HOST: trigger
      PLATFORM_WS_PORT: 3030
      SECURE_CONNECTION: "false"
      PLATFORM_SECRET: $PROVIDER_SECRET
  coordinator:
    image: ghcr.io/triggerdotdev/coordinator:v3
    platform: linux/amd64
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    user: root
    depends_on:
      trigger:
        condition: service_healthy
    environment:
      <<: *common-env
      PLATFORM_HOST: trigger
      PLATFORM_WS_PORT: 3030
      SECURE_CONNECTION: "false"
      PLATFORM_SECRET: $COORDINATOR_SECRET
    healthcheck:
      test:
        - CMD-SHELL
        - pwd

Create a new access token
Error will then trigger

Additional information
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.
tokens:24
   GET https://static.cloudflareinsights.com/beacon.min.js/vcd15cbe7772f49c399c6a5babf22c1241717689176015 net::ERR_BLOCKED_BY_CLIENT

root-JWRAFXBJ.js:9
   POST https://trigger.claasen.cc/account/tokens?_data=routes%2Faccount.tokens 400 (Bad Request)

window._fetchProxy @ root-JWRAFXBJ.js:9
window._highlightFetchPatch @ root-JWRAFXBJ.js:9
Fr @ chunk-JBSYHZX3.js:18
await in Fr
da @ chunk-JBSYHZX3.js:24
action @ chunk-JBSYHZX3.js:24
m @ chunk-JBSYHZX3.js:2
ot @ chunk-JBSYHZX3.js:2
wa @ chunk-JBSYHZX3.js:1
Ea @ chunk-JBSYHZX3.js:1
(anonymous) @ chunk-JBSYHZX3.js:2
w.createElement.ce.onSubmit @ chunk-JBSYHZX3.js:2
oc @ chunk-LYHQCUWL.js:5
ac @ chunk-LYHQCUWL.js:5
cc @ chunk-LYHQCUWL.js:5
po @ chunk-LYHQCUWL.js:5
As @ chunk-LYHQCUWL.js:5
(anonymous) @ chunk-LYHQCUWL.js:5
ku @ chunk-LYHQCUWL.js:8
cs @ chunk-LYHQCUWL.js:5
Fl @ chunk-LYHQCUWL.js:5
Xi @ chunk-LYHQCUWL.js:5
Nc @ chunk-LYHQCUWL.js:5
chunk-LYHQCUWL.js:8 TypeError: Cannot read properties of undefined (reading 'split')
at L (chunk-4QLYPARN.js:1:2114)
at chunk-GVVQJ7TX.js:1:1694
at Object.pa [as useMemo] (chunk-LYHQCUWL.js:6:23795)
at r.useMemo (chunk-FTYKMG53.js:1:6137)
at oe (chunk-GVVQJ7TX.js:1:1644)
at re (account.tokens-CBMHX44X.js:1:4940)
at du (chunk-LYHQCUWL.js:6:19466)
at _i (chunk-LYHQCUWL.js:8:3133)
at Ba (chunk-LYHQCUWL.js:8:44432)
at Ua (chunk-LYHQCUWL.js:8:39459)
overrideMethod @ hook.js:608
xi @ chunk-LYHQCUWL.js:8
i.componentDidCatch.t.callback @ chunk-LYHQCUWL.js:8
Co @ chunk-LYHQCUWL.js:6
Ao @ chunk-LYHQCUWL.js:8
Ra @ chunk-LYHQCUWL.js:8
If @ chunk-LYHQCUWL.js:8
Bf @ chunk-LYHQCUWL.js:8
hn @ chunk-LYHQCUWL.js:8
Fa @ chunk-LYHQCUWL.js:8
Sl @ chunk-LYHQCUWL.js:1
hl @ chunk-LYHQCUWL.js:1
Show 1 more frame
Show less
chunk-JBSYHZX3.js:2 React Router caught the following error during render TypeError: Cannot read properties of undefined (reading 'split')
at L (chunk-4QLYPARN.js:1:2114)
at chunk-GVVQJ7TX.js:1:1694
at Object.pa [as useMemo] (chunk-LYHQCUWL.js:6:23795)
at r.useMemo (chunk-FTYKMG53.js:1:6137)
at oe (chunk-GVVQJ7TX.js:1:1644)
at re (account.tokens-CBMHX44X.js:1:4940)
at du (chunk-LYHQCUWL.js:6:19466)
at _i (chunk-LYHQCUWL.js:8:3133)
at Ba (chunk-LYHQCUWL.js:8:44432)
at Ua (chunk-LYHQCUWL.js:8:39459) {componentStack: '\n    at re (https://trigger.claasen.cc/build/route…claasen.cc/build/_shared/chunk-DGKAL6G7.js:1:186)'}componentStack: "\n    at re (https://trigger.claasen.cc/build/routes/account.tokens-CBMHX44X.js:1:4909)\n    at div\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:3847\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:4583\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:3130\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:2725\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:3847\n    at https://trigger.claasen.cc/build/_shared/chunk-Y6JHH73C.js:1:384\n    at https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:3527\n    at https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:2339\n    at Ce (https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:7705)\n    at https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:2087\n    at div\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:3130\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:2725\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:3847\n    at https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:7410\n    at Ce (https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:7705)\n    at u (https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:996)\n    at se (https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:1327)\n    at ee (https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:4672)\n    at https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:5173\n    at u (https://trigger.claasen.cc/build/_shared/chunk-HLDNCM5C.js:1:996)\n    at ne (https://trigger.claasen.cc/build/_shared/chunk-XJK4FH5I.js:1:601)\n    at div\n    at j (https://trigger.claasen.cc/build/_shared/chunk-WZVPZJ3P.js:1:1895)\n    at div\n    at div\n    at div\n    at G (https://trigger.claasen.cc/build/_shared/chunk-WZVPZJ3P.js:1:1047)\n    at div\n    at fo (https://trigger.claasen.cc/build/_shared/chunk-ALXCXKJV.js:1:3658)\n    at X (https://trigger.claasen.cc/build/routes/account.tokens-CBMHX44X.js:1:3588)\n    at So (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:18639)\n    at _n (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:21220)\n    at div\n    at yt (https://trigger.claasen.cc/build/_shared/chunk-ALXCXKJV.js:1:3548)\n    at div\n    at div\n    at vo (https://trigger.claasen.cc/build/_shared/chunk-ALXCXKJV.js:1:3424)\n    at L\n    at So (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:18639)\n    at _n (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:21220)\n    at body\n    at html\n    at rs (https://trigger.claasen.cc/build/root-JWRAFXBJ.js:14:109345)\n    at So (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:18639)\n    at dr (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:22722)\n    at Qo (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:30169)\n    at gr (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:21257)\n    at Mn (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:2:28244)\n    at $t (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:14:2378)\n    at Ui (https://trigger.claasen.cc/build/_shared/chunk-JBSYHZX3.js:24:2690)\n    at x (https://trigger.claasen.cc/build/_shared/chunk-XEZL6SGQ.js:1:185)\n    at y (https://trigger.claasen.cc/build/_shared/chunk-DGKAL6G7.js:1:186)"[[Prototype]]: Object
overrideMethod @ hook.js:608
componentDidCatch @ chunk-JBSYHZX3.js:2
i.componentDidCatch.t.callback @ chunk-LYHQCUWL.js:8
Co @ chunk-LYHQCUWL.js:6
Ao @ chunk-LYHQCUWL.js:8
Ra @ chunk-LYHQCUWL.js:8
If @ chunk-LYHQCUWL.js:8
Bf @ chunk-LYHQCUWL.js:8
hn @ chunk-LYHQCUWL.js:8
Fa @ chunk-LYHQCUWL.js:8
Sl @ chunk-LYHQCUWL.js:1
hl @ chunk-LYHQCUWL.js:1
Show 1 more frame
Show less
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-redemption'.
Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.

Error with Permissions-Policy header: Origin trial controlled feature not enabled: 'private-state-token-issuance'.
Error with Permissions-Policy header: Unrecognized feature: 'browsing-topics'.

I am happy to share access if required.

Seems to also have an issue when trying to create a token via the CLI. I am guessing it's related.

Hi there! I've analyzed your issue with Personal Access Token creation, and I think I can help resolve this.
The error you're experiencing appears to be related to known token handling issues that have been fixed in recent versions. Based on the error patterns and similar reported issues, here's what we need to do:

First, let's verify and upgrade your Trigger.dev version:

The token-related issues have been fixed in versions 3.1.1 and 3.2.1
Update your docker-compose configuration to use the latest v3 image:

image: ghcr.io/triggerdotdev/trigger.dev:latest-v3

Check your environment configuration:
Make sure these environment variables are properly set:

SESSION_SECRET
ENCRYPTION_KEY
MAGIC_LINK_SECRET
These are critical for token generation and authentication.

After upgrading, clean up your existing state:
docker-compose down
docker volume prune  # Be careful with this if you have other important volumes
docker-compose up -d

When creating new tokens, ensure you're using the correct scope format:
const publicToken = await auth.createPublicToken({
  scopes: {
    read: {
      runs: true
    }
  }
});

If you're still experiencing issues after implementing these changes, please provide:

Your current Trigger.dev version
The specific CLI error message
Any error messages in the server logs

References:

Issue #1477: Token permission fixes in v3.2.1
Issue #1443: Token access improvements in v3.1.1

Important Notes:

Backup your data before performing any upgrades
Existing tokens may need to be regenerated after the upgrade
Monitor the logs during the upgrade process for any migration errors

Let me know if you need any clarification or run into any issues during the upgrade process!

Thank you'll have a go at it.

FYI ran into the same issue and it seems to be due to one of the environment variables that trigger needs. What I did:

Regenerate keys
Update all environment variables, restart containers

List of keys:
echo MAGIC_LINK_SECRET=$(openssl rand -hex 16)
echo SESSION_SECRET=$(openssl rand -hex 16)
echo ENCRYPTION_KEY=$(openssl rand -hex 16)
echo PROVIDER_SECRET=$(openssl rand -hex 32)
echo COORDINATOR_SECRET=$(openssl rand -hex 32)

FYI ran into the same issue and it seems to be due to one of the environment variables that trigger needs. What I did:

Regenerate keys
Update all environment variables, restart containers

List of keys:
echo MAGIC_LINK_SECRET=$(openssl rand -hex 16)
echo SESSION_SECRET=$(openssl rand -hex 16)
echo ENCRYPTION_KEY=$(openssl rand -hex 16)
echo PROVIDER_SECRET=$(openssl rand -hex 32)
echo COORDINATOR_SECRET=$(openssl rand -hex 32)

Yes, this solves it for me also. This is a bug on Coolify side (template generation issue). It was said from Coolify team that it will be fixed soon.
Happy triggering!


Migrate from functorch to torch.func

This will change the traker requirements from torch>=1.13 to torch>=2.0.0

https://github.com/MadryLab/trak/commit/f1e3cb0e38daf418f093a96ba31b4c2f42ad45ef

https://github.com/MadryLab/trak/commit/8191f3b3933da1be31b0b99aeea94eb85693d105


[Dialog] RootProps does not satisfy the constraint Props

The Dialog Component https://github.com/cschroeter/park-ui/blob/main/components/panda/react/src/components/ui/dialog.tsx
has an error of
Type 'RootProps' does not satisfy the constraint 'Props'.
  Index signature for type 'string' is missing in type 'RootProps'.ts(2344)

on RootProps

// Dialog.tsx

import type { Assign } from '@ark-ui/react'
import { Dialog } from '@ark-ui/react/dialog'
import { type DialogVariantProps, dialog } from 'styled-system/recipes'
import type { JsxStyleProps } from 'styled-system/types'
import createStyleContext from '@lib/create-style-context'

const { withRootProvider, withContext } = createStyleContext(dialog)

export interface RootProps extends Dialog.RootProps, DialogVariantProps {}
export const Root = withRootProvider<RootProps>(Dialog.Root)

export const Backdrop = withContext<HTMLDivElement, Assign<JsxStyleProps, Dialog.BackdropProps>>(
  Dialog.Backdrop,
  'backdrop',
)

export const CloseTrigger = withContext<
HTMLButtonElement,
Assign<JsxStyleProps, Dialog.CloseTriggerProps>
>(Dialog.CloseTrigger, 'closeTrigger')

export const Content = withContext<HTMLDivElement, Assign<JsxStyleProps, Dialog.ContentProps>>(
  Dialog.Content,
  'content',
)

export const Description = withContext<
HTMLParagraphElement,
Assign<JsxStyleProps, Dialog.DescriptionProps>
>(Dialog.Description, 'description')

export const Positioner = withContext<
HTMLDivElement,
Assign<JsxStyleProps, Dialog.PositionerProps>
>(Dialog.Positioner, 'positioner')

export const Title = withContext<HTMLHeadingElement, Assign<JsxStyleProps, Dialog.TitleProps>>(
  Dialog.Title,
  'title',
)

export const Trigger = withContext<HTMLButtonElement, Assign<JsxStyleProps, Dialog.TriggerProps>>(
  Dialog.Trigger,
  'trigger',
)

export {
  DialogContext as Context,
  type DialogContextProps as ContextProps,
} from '@ark-ui/react/dialog'

I am on the latest dependencies "@ark-ui/react": "^3.2.0" and "@park-ui/panda-preset": "^0.38.0",

@renchris
Thanks for reporting the issue. I checked on the. Park repository and the Ark UI repo (consumer) and I could not find any typescript issue. Please try to restart the TypeScript Server, ensure you have the latest dependencies and all Panda and Ark related dependencies are identical (monorepo).

@cschroeter
From the create-style-context.tsx file, the Props type is
type Props = Record<string, unknown>

https://github.com/cschroeter/park-ui/blob/5cfd0a344493d8be849d5010b1c3eb8393adf212/components/panda/react/src/lib/create-style-context.tsx#L13C6-L13C11
From the dialog.tsx file, the RootProps type is
export interface RootProps extends Dialog.RootProps, DialogVariantProps {}

https://github.com/cschroeter/park-ui/blob/5cfd0a344493d8be849d5010b1c3eb8393adf212/components/panda/react/src/components/ui/dialog.tsx#L9
Dialog.RootProps is
export interface DialogRootProps extends UseDialogProps, UsePresenceProps {
    children?: ReactNode;
}

{     children?: ReactNode; } does not satisfy on Record<string, unknown>
I re-ran my server and am on the latest dependencies  "typescript": "5.4.5" and "@ark-ui/react": "^3.2.1",
What is Dialog.RootProps for you? It makes sense that a ReactNode children object does not conform to the string key Record type


Functional Test Failed

After downloading the source play-java-grpc-example, the application compiles and would run as expected.
When running the HelloFunctionalTest,  in the sample application play-java-grpc-example we get the following error. Any pointers?
java.lang.IllegalArgumentException: gRPC client can't automatically find HTTP/2 connection: no valid endpoints available. ServerEndpoints(List(ServerEndpoint(Netty HTTP/1.1 (plaintext),http,localhost,45727,Set(1.0, 1.1),Some(netty),None), ServerEndpoint(Netty HTTP/1.1 (encrypted),https,localhost,33173,Set(1.0, 1.1),Some(netty),Some(ClientSsl(javax.net.ssl.SSLContext@6d0be7ab,sun.security.ssl.X509TrustManagerImpl@1d4fb213)))))

Hi @mdsabz,
I suspect the problem is you are running the tests on a vanilla sbt session. Because gRPC requires HTTP/2 support, running this sample requires appending the ALPN Agent to the JVM that runs sbt. To handle this complexity the play-java-grpc-example includes a script called ssl-play which is effectively an sbt launcher with support for SSL and HTTP/2. SO, instead of using sbt, use ssl-play.

@mdsabz, I'm closing this issue because it's likely related with what @ignasi35 indicated.
Please feel free to re-open it if this is not the case.


Getting started steps don't work

I just tried these steps: https://microsoft.github.io/just/docs/doc-start.

I created a new npm package:

mkdir play
cd play
npm init -y

I installed just-task:

npm install -D just-task

I used VS Code to create a new file "just-task.js" containing:

const { task, option, logger, argv } = require('just-task');

option('name', { default: 'world' });

task('sayhello', function() {
  logger.info(argv().name);
});

Then I tried running the sayhello task:

npx just sayhello

RESULT:
[5:34:29 AM] x Cannot find config file "null". Please create a file called "just-task.js" in the root of the project next to "package.json".

Hmmm I can't repro this, @akrantz... Can you try to see if there's a old global copy of just-task sitting around your HD? I just tried this in a clean env (inside a docker) in Linux, and then on Windows was okay as well as Mac...
Would you mind doing a little investigation here?

@kenotron Well, I just tried this steps and it worked now.


[master] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

/cc we don't use Prow
/assign we don't use Prow

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   96.18%   96.18%
=======================================
  Files          16       16
  Lines         446      446
=======================================
  Hits          429      429
  Misses         15       15
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5293cc...5650f17. Read the comment docs.

switching bots


[Concurrency] Distributed actor's unownedExecutor should be optional

Implements the Swift Evolution feedback that it'd be better to implement this customization point properly with an UnownedSerialExecutor? which makes it more logical (and possible!) to implement correctly.
@kavon's question https://forums.swift.org/t/se-0392-custom-actor-executors/63599/13
and my writeup: https://forums.swift.org/t/se-0392-custom-actor-executors/63599/16
Note that we never shipped distributed actors that had an unownedExecutor synthesized, so we don't have to be compatible with past implementations which had it configurable or synthesized -- it never was.
The tests show various use-cases.
I took care to not break compatibility with previous implementations and we still detect "is default actor" using the old synthesized method. Though previously ALL distributed actors were default actors, even if you had provided the method yourself.
I believe this yields the right semantics but would really really ask for a review if I got the default implementation of unownedExecutor right -- the availability dance there I was unsure of.

@swift-ci please smoke test

Though I'm working to get rid of the unownedExecutor completely, if I'll manage to adjust the LowerHopToActor properly

This weird failure again:
37366     error: 'miscellaneous_atmainsupport': Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/bu      ild/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsov      erlay", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/TemporaryDirectory.VfUFtV/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-      smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinke      r", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86      _64-apple-macosx/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx11.0", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/Ma      cOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-F", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Framew      orks", "-I", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode-beta.app/Content      s/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "5", "-I", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/bra      nch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode-beta.app/Contents      /Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-package-description-version", "5.5.0", "-module-cache-path", "/Users/ec2-user/je      nkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release", "/private/var/fold      ers/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/Miscellaneous_AtMainSupport.0rtTka/Miscellaneous_AtMainSupport/Package.swift", "-Xfrontend", "-disable-implicit      -concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T      /TemporaryDirectory.YQgBzl/miscellaneous_atmainsupport-manifest"])
37367     /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/lib/swift/Foundation.swiftmodule/x86_64      -apple-macos.swiftinterface:4:8: error: no such module 'Combine'
37368     import Combine
37369            ^
37370     /private/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/Miscellaneous_AtMainSupport.0rtTka/Miscellaneous_AtMainSupport/Package.swift:1:8: error: f      ailed to build module 'Foundation'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.5 (swiftlang-13<IP_ADDRESS> cl      ang-13<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.9-dev (LLVM 7d764ce82d6ec7f, Swift bf54bfe483bacd7)'). Please select a toolchain which       matches the SDK.
37371     import Foundation
37372            ^

@swift-ci please clean smoke test macOS

@swift-ci please clean smoke test

rdar://84054793


compiling problem

most people are not gonna use the if statement like this but...
basically:
let num1 = 100
let num2 = 150

if (num1 < 150) { }
else {
    printFlush()
}

// expected output is to be nothing on message1

output:
set num1:1:4 100
set num2:2:4 150
op greaterThan &t0 num1:1:4 num2:2:4
jump 5 always
print "num1 is less or equal than num2"
printflush message1
end

i think the jump instruction shouldn't be "always"
but instead a not equal

The fix is available in the online editor.

The fix is also available in the version 0.4.10 of the compiler


"REQUEST BLOCKED BY CLOUDFLARE ERROR" while downloading from Crunchyroll

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Provide a description that is worded well enough to be understood
I've read other issues and tried playing a video on crunchyroll site, still the same error persists, I've trying using user agent but still not luck, before this error a "error 403" was also there but now this error is occurring. For the error 403 the code given by dev is "--extractor-args "crunchyrollbeta:format=vo_adaptive_hls" I couldn't test it because of the given erorr.
Thank You
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp --verbose --cookies-from-browser chrome https://www.crunchyroll.com/watch/G7PU4MZ1G/the-journeys-end
[debug] Command-line config: ['--verbose', '--cookies-from-browser', 'chrome', 'https://www.crunchyroll.com/watch/G7PU4MZ1G/the-journeys-end']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [f2868b26e] (pip)
[debug] Python 3.12.2 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 3.0.13 30 Jan 2024)
[debug] exe versions: ffmpeg 2024-03-14-git-2129d66a66-full_build-www.gyan.dev (setts)
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.43.1, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
Extracting cookies from chrome
[debug] Extracting cookies from: "C:\Users\USER\AppData\Local\Google\Chrome\User Data\Default\Network\Cookies"
[debug] Found local state file at "C:\Users\USER\AppData\Local\Google\Chrome\User Data\Local State"
Extracted 2812 cookies from chrome
[debug] cookie version breakdown: {'v10': 2884, 'other': 0, 'unencrypted': 4}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1803 extractors
[crunchyroll] Extracting URL: https://www.crunchyroll.com/watch/G7PU4MZ1G/the-journeys-end
[debug] [crunchyroll] Using cxApiParam=noaihdevm_6iyg0a8l0q
[crunchyroll] Authenticating with grant_type=etp_rt_cookie
ERROR: [crunchyroll] G7PU4MZ1G: Request blocked by Cloudflare; navigate to Crunchyroll in your browser, then pass the fresh cookies (with --cookies-from-browser or --cookies) and your browser's User-Agent (with --user-agent)
  File "C:\Users\USER\AppData\Local\Programs\Python\Python312\Lib\site-packages\yt_dlp\extractor\common.py", line 732, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\USER\AppData\Local\Programs\Python\Python312\Lib\site-packages\yt_dlp\extractor\crunchyroll.py", line 333, in _real_extract
    response = traverse_obj(self._call_api(
                            ^^^^^^^^^^^^^^^
  File "C:\Users\USER\AppData\Local\Programs\Python\Python312\Lib\site-packages\yt_dlp\extractor\crunchyroll.py", line 127, in _call_api
    result = self._call_base_api(
             ^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\USER\AppData\Local\Programs\Python\Python312\Lib\site-packages\yt_dlp\extractor\crunchyroll.py", line 108, in _call_base_api
    self._update_auth()
  File "C:\Users\USER\AppData\Local\Programs\Python\Python312\Lib\site-packages\yt_dlp\extractor\crunchyroll.py", line 94, in _update_auth
    raise ExtractorError(

Getting the same probleme here, noticed it this today and doesn't seem to be working even after refreshing my IP, deleting cookies and redownloading them, also tried adding user agent.
If it can help, I am also using selenium (web scraper) to scrape crunchyroll pages and it is also failing to load the pages in the remotely controlled browser that gets launched when startying selenium (chrome)
"yt-dlp"
["--username=",
"--password=",
"--cookies=/home/rico/www.crunchyroll.com_cookies.txt",
"--user-agent='Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'",
"--output=/home/rico/personal/download-files/Frieren: Beyond Journey's End/Season 1/E27 - An Era of Humans/original.mp4",
"--format=""best[height=1080]""",
"https://www.crunchyroll.com/watch/GEVUZD0V9/an-era-of-humans"]
[crunchyroll] Extracting URL: https://www.crunchyroll.com/watch/GEVUZD0V9/an-era-of-humans
[crunchyroll] Authenticating with grant_type=etp_rt_cookie
ERROR: [crunchyroll] GEVUZD0V9: Request blocked by Cloudflare; navigate to Crunchyroll in your browser, then pass the fresh cookies (with --cookies-from-browser or --cookies) and your browser's User-Agent (with --user-agent)

Also we can notice some ppl reporting more issues than usual on downdetector https://downdetector.com/status/crunchyroll/

Also we can notice some ppl reporting more issues than usual on downdetector https://downdetector.com/status/crunchyroll/

Looks like a problem from the crunchyroll site. Till yesterday this (https://github.com/yt-dlp/yt-dlp/issues/9439) error was there.

Yeah seems like we might have trouble for a bit of time...

crunchyroll is broken. Even if you get past the cloudflare blockage (#7442), and even if you're on nightly/master or pass the extractor arg to get past #9439, then you're still going to run into #9453. And if you take the time to read #9453, you'll see that there's a high likelihood of crunchyroll support never being fixed.


Use Narval as test runner

Pull Request Test Coverage Report for Build 174

1 of 11 (9.09%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.551%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/bases/server/api/Security.js
0
2
0.0%

lib/bases/Client.js
0
8
0.0%

Totals

Change from base Build 127:
0.0%

Covered Lines:
810

Relevant Lines:
1493

💛  - Coveralls


Choices for a fan PWM Frequency

Moving a discussion over from #595
In the current codebase the fan PWM frequency is 150kHz. I think this is probably too high but am going to follow up with some actual measurements. @cyoung says most people are using an AO3400 MOSFET for switching.
Will post more here later.

OK, I got a PI-FAN LD3007MS. The fan acts pretty strange. It seems like it needs to warm up before it even responds to the higher PWM frequency. Sometimes it won't even start at 256/256 with the frequency set at 150 kHz. So I've introduced a failsafe because a number of users that are testing v1.3b2 have reported the same issue.

If the fan doesn't start at 256/256 then something is wrong- there is no PWM happening at all there, that's just 100% on.
Can you tell me more? Happy to take a look. Ordered some of the FETs most folks are using but that'll take a week or two.

I have a 25x25x7mm 5V 0.1A DC Brushless fan. Model FSY27S05L. I just tried update-stratux-v1.3b2-0678955b01.sh which I think Chris said has some code to turn the fan PWN all the way up if the temperature doesn't start coming down. I put the box in front of a heater and the CPU got to 68C. I tried giving the fan a spin by hand, but it did not start. I then shutdown the Stratux, removed the AHRS/Fan control board, and plugged the fan directly into the 5V pins. As soon as I connected power, the fan started up. Does that help any?

Did you give it ~10 minutes or so?

@pp4life I have a few ideas for you. First though, would you mind telling me more about the fan control board you mentioned?

This is the board being talked about.
https://github.com/stratux/ahrs/
It will probably be the most common implementation of fan control other than the DIY types like me.

@cyoung I did not give it 10 minutes. I can do the test again and wait longer. @Helno thanks for answering @lukepalmer's question about the AHRS/fan control board.

Hmm shouldn't need 10 minutes. I'll make some measurements using that hardware and come back with a recommendation.
Also, if there is a forum, etc for the AHRS stuff, I'd love to hear about it.

https://stratuxadsb.slack.com  There's an AHRS channel on there.

@lukepalmer - https://github.com/cyoung/stratux/blob/master/main/fancontrol.go#L74-L81
Works out to about 10 minutes for one cycle. Could take longer.

Yes. I'm not aware of what effect that code could have though. A PWM duty cycle of 100% is exactly equivalent to setting the output high.

Two tests here. In both cases "pwmDuty" was 250 (of 256).
pwmClockDivisor=128:

pwmClockDivisor=1:

Doesn't seem to work as we're expecting.

Oh, this was measured at "GPIO1" (pin 12).

Just dropping by to say I have this same board AHRS + Fan Control.  Built the Stratux tonight and the fan barely runs.

I did some work on this and have a fairly satisfying explanation for why some people see bad behavior. Should have a PR in the next day or two along with writeup.
@daveholland86 the fan barely running is a feature, not a bug! I'll look into adding wiki info on how to adjust that if you want to.

@daveholland86 - if it's running slowly then it's working fine. The speed will increase as the temperature does.

Looks like frequency varies with duty cycle:
https://raspberrypi.stackexchange.com/questions/4906/control-hardware-pwm-frequency

There are a couple issues. The built-in balanced PWM mode does odd things
at times. There is also a library incompatibility issue and a weird setup
ordering issue that only shows up after rebooy... Will send a PR once I'm
certain.
On Wed, May 24, 2017, 12:35 PM cyoung<EMAIL_ADDRESS>wrote:

Looks like frequency varies with duty cycle:
https://raspberrypi.stackexchange.com/questions/4906/control-hardware-pwm-frequency
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cyoung/stratux/issues/599#issuecomment-303779968, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AExJAb9kwj6mELRp8obTZ2wEeS6E_yUFks5r9FxDgaJpZM4Naivt
.

The PWM duty range also seems to affect the frequency. This is getting a little more complicated than it is worth for the ~8% power savings maximum. From the PI-FAN that I have, it seems like this fan has a very narrow controllable speed range. The SUNON fan is much better in this aspect.
Here are some measurements on a bench power supply.

SUNON: 0.029W
PI-FAN: 0.16W
Max power:
SUNON: 0.46W
PI-FAN: 0.69W
The SUNON fan blows considerably more air than the PI-FAN in any case, so I'm going to conclude that the SUNON is far more efficient. If I've got nothing better to do one day, I'll get out the anemometer and do some actual measurements on this part. But considering that the SUNON fan is worth less than $2 in bulk, I can't see how this decision is anything other than trivial. Send me an email with your address and I'll send you one and a fan controller.

If its supposed to operate like that then I am not worried about mine.  I fly out in Phoenix and it was 103, 110 on the ramp and 125 in the plane and the fan was spinning slow sometimes.  I was worried it would over heat but if its set to not overheat than I wont worry about it.  I am using a 10,000 mah battery and a 6000mah backup and fly maybe 4 hours max, not too worried about battery life.

I ran update-stratux-v1.3b2-0678955b01.sh this morning for way more than 10 minutes. It was running for hours this morning and got over 60C, but the fan never came on. I updated to update-stratux-v1.3b2-46233e704c.sh and walked away from my desk. About an hour later I came back to my desk and the fan was running. Temperature was around 50C.
I rebooted and the fan came on, what seems to be full force, after about 5 minutes. The temperature is about 55C and stabilized at 40C after the fan came on. Doesn't seem like the fan ever slowed down since it came on. I think I understand that's how this update works now. "If doesn't like the PWM, then just turn on to full PWM."
I see Chris' commits above that change the PWM mode and some other stuff. When a .sh is available, I'll try that.

Ha! Just tried the dangerzone update-stratux-v1.3b2-7c33203672.sh. I had my headphones on at work and could hear a tone coming from somewhere step decreasing in frequency. I took off my headphones and it was coming directly from the Stratux, then BAM!, tone stopped and fan turned on what seems to be full blast. I assume that's the, "I give up, just turn the fan on"

@pp4life there are some known problems here, give it a day or two and I'll
gave something new ready.
On Wed, May 24, 2017, 5:59 PM pp4life<EMAIL_ADDRESS>wrote:

Ha! Just tried the dangerzone update-stratux-v1.3b2-7c33203672.sh. I had
my headphones on at work and could hear a tone coming from somewhere step
decreasing in frequency. I took off my headphones and it was coming
directly from the Stratux, then BAM!, tone stopped and fan turned on what
seems to be full blast. I assume that's the, "I give up, just turn the fan
on"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cyoung/stratux/issues/599#issuecomment-303863680, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AExJAQIMiLe_g7ebld6KSPrpf2TodNkaks5r9KgsgaJpZM4Naivt
.

Don't stress about it or anything. Just trying to give as much feedback as possible on my use case with the FSY27S05L fan.
Thanks for working through this!

#595 should be ready for another look now

Is there anyone looking to implement a PID control solution to the fan PWM? All you need is a target temp and the PID will control the fan at whatever speed is necessary to maintain temperature. Could add a user setting for min PWM duty cycle for those with issues turning on below 30%.

@Joelbear5 you're the first to mention it, but PID is something we could look at down the road if folks are having thermal issues. It may be more than we need for now.
#595 as-is provides both a configurable target temperature and minimum duty cycle for those who would like to adjust.

Can someone post the Kp Ki and Kd values for the PWM controller

The tuning is going to be really tricky since not only do we have massively different heat loads but also different cases and fans. The delay in sensed temperature vs airflow will also cause problems if you try to have really tight control.
My initial script left it pretty loose and just ramped things up slowly with 2 degrees of deadband, the slow refresh rate seemed to work really well for this application.

Are folks having heat problems they'd be willing to describe? There are
some known bugs at HEAD that #595 fixes, and once that is merged we may be
in good shape.
We are actually not doing anything terribly far removed from the original
by @helno, the software is just toughened up a bit and is more configurable.
On Tue, Jun 6, 2017, 8:26 PM Helno<EMAIL_ADDRESS>wrote:

The tuning is going to be really tricky since not only do we have
massively different heat loads but also different cases and fans. The delay
in sensed temperature vs airflow will also cause problems if you try to
have really tight control.
My initial script left it pretty loose and just ramped things up slowly
with 2 degrees of deadband, the slow refresh rate seemed to work really
well for this application.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cyoung/stratux/issues/599#issuecomment-306651193, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AExJAXLspHOOGh3yZflEY2bSjU6-oWt3ks5sBe4agaJpZM4Naivt
.

The tuning is going to be really tricky since not only do we have massively different heat loads but also different cases and fans. The delay in sensed temperature vs airflow will also cause problems if you try to have really tight control.
yes I agree
Ignore the heat load and start the fan first. then begin a control method. You cannot get to cold.

The temperature insensitivity of this whole thing is why a simple temperature control method works well.
The only things I would have added if I were able to would be to have thresholds to put the  fan at full power or turn it off completely. If it is between those two limits a 5 second refresh time with a 1% output change seems to work just fine.

Then make it bang bang control at first. if the temp is high bang on, set a time period say 60sec, then turn it off for 30sec. wait 15sec and measure, start over, until you can determine a control PWM duty cycle while the fan is running at speed.

Why do bang bang when starting at 50% and moving 1% every 5 seconds works so well.
I think you guys are really overthinking this. We don't need to actually control the temperature at a precise temperature we just want to reduce the fans power consumption when it it not needed. It is more important that the temperature changes slowly than to have it at any specific temperature.
I tune PID loops for a living and can tell you that PID is a bad idea for this application since the process can change so much from unit to unit and from day to day. Integral only control with limits would work just fine.

+1 on what @helno says. I am optimistic that we will be in pretty good
shape once #595 gets merged.
On Tue, Jun 6, 2017, 9:07 PM Helno<EMAIL_ADDRESS>wrote:

Why do bang bang when starting at 50% and moving 1% every 5 seconds works
so well.
I think you guys are really overthinking this. We don't need to actually
control the temperature at a precise temperature we just want to reduce the
fans power consumption when it it not needed. It is more important that the
temperature changes slowly than to have it at any specific temperature.
I tune PID loops for a living and can tell you that PID is a bad idea for
this application since the process can change so much from unit to unit and
from day to day. Integral only control with limits would work just fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cyoung/stratux/issues/599#issuecomment-306656788, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AExJATXhjbSXsb62SJm3CFp7wg8TGhN-ks5sBffMgaJpZM4Naivt
.

Because people are saying the fan does not start. each fan has a different startup current. once started you can change to 50% or whatever
post your kp ki and kd for integral only control
I myself use conduction cooling and do not use a fan.

@D35Bonanza agree, there are bugs in the current version at head that cause the fan to not start for some people. Once changes are merged we should be good.

I just did a side-by-side test between the SunOn MagLev fan that @cyoung recommended and the PI-FAN that comes with some of the cases. I updated #595 with recommended settings for the SunOn fan, as well as suggested settings for the PI-FAN.
If you have the option, the SunOn fan appears to be much better in every way.

Luke, I wish you the best of luck. My "avionics fan" runs full speed, squirrel cage blower, there is plenty of air in and around the radio stack. I'm very unclear why a fan is used with Rpi3 and two SDRs, conduction cooling works for me. I may give the fan circuit a try for fun when I get a chance.

Chris is correct
"This is getting a little more complicated than it is worth for the ~8% power savings maximum"
http://www.mouser.com/ds/2/256/MAX31740-253424.pdf
This is what is used when needed. No software required.
PCB on linux to make the single layer board. ultra-simple
http://pcb.geda-project.org/

Not sure what benefit that chip does for us other than replace the software.
It still needs an external temperature sensor (We have that with the pi cpu) It still needs an external transistor (which we have on the AHRS board)


chore: add more logs in EtcdElectionClient

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As titled, this PR adds more logs when the etcd lease keeper response stream is closed.
Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

I miss the fact the resp_stream.message() will keep returning Ok(None) if the stream is closed. This PR will cause excessive logs being printed when the stream is closed. I will clost this PR instead.


Rerank search results

Use an LLM to rerank search results

Basic version of this is done, it will probably be tweaked more


Added Line Separator Override Feature to ExtractedTextFormatter

about #1913
Changes
Added the ability to override the Line Separator in ExtractedTextFormatter. The default remains System.lineSeparator() to ensure backward compatibility.
Background
Relying on System.lineSeparator() has caused unexpected behavior in different environments. Specifically, while PDF files generally use \n as a line separator regardless of the operating system, Windows environments use \r\n as the default System.lineSeparator(). This discrepancy could lead to formatting failures.
My Thoughts
I reviewed related issues and noticed that Line Separator behavior varies significantly depending on the operating system and environment.
To provide a flexible solution that maintains backward compatibility, I implemented an override option to let developers customize the Line Separator based on their needs.
If you have other better ideas, I’d love to discuss them together.

Merged via https://github.com/spring-projects/spring-ai/commit/636f3aee4f53b3e2e5a553390908106165572ab4.

great! thanks.


Add support for other datatypes to  ConvertToNumpyArray

I like to use HashedMorganFingerprints for working with them in scikit-learn and end up having to write something like :
nbits = fp.GetLength()
elements = fp.GetNonzeroElements()
arr = np.zeros(nbits,dtype=int)
for idx,val in elements.items():
        arr[idx] = val

and using np.put might be better.
Is there a reason ConvertToNumpyArray only excepts ExplicitBitVect's?

There doesn't seem to be a good reason for that function not being there.
It should be easy enough to add.

let me know if you want a Python PR. I would offer for the C++ but I don't think it would qualify as an "enhancement" ;)

Thanks for offering, but this makes sense to have in C++.
I'll do it.

thanks.
also it might be a good idea to throw a warning if the length is long as in the non-hashed morgan fingerprints or else it will consume quite a bit of memory...

I would do this the same was as the current code: the calling code needs to allocate the memory (you pass in the array to be filled).


Bridge: Subwallet + Metamask + Chromium

https://bridge.gnosischain.com/
Subwallet takes over Metamask when trying to connect with Metamask using Firefox on Ubuntu 22
Sorry for being so short and not on the right repo, but I am short on time so alternative would be no report

Hi @Neozaru, thanks for heads up, we've fixed the issue of Subwallet extension


Treat any en-* dialect as default

Today we seem to look for a language pack when e.g. en-GB is declared. But the fast path is to let it through as our default locale since we have no language pack for it as far we are concerned.
https://github.com/microsoft/vscode/blob/963bd989c442ab6d70b99405b40f7bed1189ef14/src/vs/base/node/languagePacks.js#L126-L130

We use to have an en-GB language pack. I took it down because the localization team didn't want to maintain it. However there are folks that still want it (@Tyriar being one):
https://github.com/microsoft/vscode-loc/issues/443
I've thought about offering tooling for folks to make languages packs... en-GB would be a perfect candidate for this.
So at first glance, I don't like this idea.

What's the performance impact of this? Is it just a single request one time for en-* language packs that gets cached after that?

Around 15-20ms on my Windows machine. We mainly seem to be using require calls, so the stack ends up in node.js.

@TylerLeonhardt is there a way this could be cached so it's only done on a cold start or when some change is detected?

The require call you are seeing is here: https://github.com/microsoft/vscode/blob/70c7237d867fad780af5fa04f6136a1db73163f1/src/main.js#L563 which loads the languagePacks.js file which isn't huge. So I guess the time we are seeing is actually spent in getNLSConfiguration() which tries to find a language pack on disk in case the locale is not en or en-US which we can extend to en-*. So we can't avoid that code for locales !== 'en'.
If we write the locale into argv.json we still need to spend that time. We could simply start doing it a little earlier. @bpasero do you now the time we spent between having the content of the argv.json file and the app ready event?

app.on("ready") is mystical to us and can be anything from milliseconds to seconds: https://github.com/microsoft/vscode/issues/22087
We track it in Kusto and I think its typically in the 100ms range.

OK. Good to know.

I'm fine with treating all en locales like en but if we do get to a point where we have nice tooling around crafting language packs, I will want to remove that optimization to enable en-GB and all the rest.

Yeah that was my suggestion.
Nevertheless, if we can revisit how NLS is blocking startup in a waterfall or not, I am also happy.

Is there any reason vs/base/node/languagePacks isn't included in the bundle if it's relatively small?

The code is executed in the main thread and not the renderer. That is why it is not bundled into the renderer. To my 'old' knowledge we don't have a main bundle (@bpasero is this still correct). If we do we should definitely bundle it there.

Yeah, at that point its just commonJS, not AMD.

Could we use esbuild to bundle main.js? Then we don't need to use AMD.

We can for the languagePacks.js but it would not help for:
https://github.com/microsoft/vscode/blob/a5c0f6c1919e429b29f584aa42f5b209344d2f08/src/vs/base/node/languagePacks.js#L73-L82

Agree, but we could easily replace this with a async read since the call to getLanguagePackConfigurations is already in a async function.

That would be very cool! To prevent sync fs reads.

Opened https://github.com/microsoft/vscode/issues/159894 for that with a PR.


ClickHouse is not support Timestamp?

like 2017-02-05 15:20:22:222

ClickHouse does not support a data type for time with more than one second resolution.
Suggested solution is to store time with resolution up to seconds in one column of type DateTime and to store milliseconds/microseconds in separate column of type UInt16 or UInt32.
This is reasonable, because fractional part of time is usually pseudorandom and compresses much worse, so when you just need to read time up to seconds, it would be read much faster if it is stored separate of fractional part.
Another soultion is to store unix timestamp multiplied by 1000 or 1000000 with added number of milliseconds/microseconds in field of type UInt64. But in that case, it is more difficult to implement date and time calculations than with DateTime data type.

oh ,This is bad  info.
ClickHouse  used LZ4 compresses ？
If i used Timestamp need tow column?

Yes, ClickHouse uses LZ4 compression algorithm for compressing column data. Optionally you can configure it so that ZSTD algorithm is chosen (see comments in config.xml)

@ztlpn  Thanks

when support datetime with millisecond?

https://github.com/yandex/ClickHouse/issues/4860


Angular Bootstrap 1.0 support

Would be nice to make this library to support the new version of Angular Bootstrap.
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes
As far as I can see, everything works. It is just the annoying dependency warning that needs to be fixed.

+1

+1

Done, sorry for the delay.


MS CodeCoverage + SourceLink + ReportGenerator = No Code Coverage Report

When using MS CodeCoverage with SourceLink (Microsoft.SourceLink.GitHub in this case), and setting the ContinuousIntegrationBuild element in the csproj to true, the output reports will have the file path removed from the filename attributes.
Using SourceLink will cause the PDB to be altered, adding the CustomDebugAttribute and removing part of the file paths to be replaced with /_, which will result in the following code coverage report:
<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<coverage line-rate="0.5" branch-rate="1" complexity="2" version="1.9" timestamp="1728997951" lines-covered="1" lines-valid="2">
  <packages>
    <package line-rate="0.5" branch-rate="1" complexity="2" name="NoCodeCoverage">
      <classes>
        <class line-rate="0.5" branch-rate="1" complexity="2" name="NoCodeCoverage.MyMath" filename="/_/src/NoCodeCoverage/MyMath.cs">
          <methods>
            <method line-rate="1" branch-rate="1" complexity="1" name="Add" signature="(int, int)">
              <lines>
                <line number="15" hits="1" branch="False" />
              </lines>
            </method>
            <method line-rate="0" branch-rate="1" complexity="1" name="Subtract" signature="(int, int)">
              <lines>
                <line number="24" hits="0" branch="False" />
              </lines>
            </method>
          </methods>
          <lines>
            <line number="15" hits="1" branch="False" />
            <line number="24" hits="0" branch="False" />
          </lines>
        </class>
      </classes>
    </package>
  </packages>
</coverage>

Tooling like ReportGenerator use the filename to access the file to build the code coverage report, but no such file path exists on the local machine for /_/src/NoCodeCoverage/MyMath.cs.
Other tooling like coverlet do not seem to have the same issue when using SourceLink.
I've attached a sample application that will exhibit the issue, it just needs to be setup with a git repo.  NoCodeCoverage.zip
Thanks,
Raymond

@rainman-63 thanks for reporting this. ReportGenerator works good with /_/ we are using it in our pipelines. You can maybe try to upgrade ReportGenerator in your pipeline and/or provide argument -sourcedirs.
You can also try to use: <Configuration><DeterministicReport>False</DeterministicReport></Configuration> in your configuration to try to resolve those paths. I think you need to upgrade Microsoft.CodeCoverage package to latest in your project to take effect.
@fhnaseer could you please add DeterministicReport option to our public documentation?

I see the same issue with my bat file here: https://github.com/jbe2277/waf/blob/34629b5f4a9d83d320050fa0b8b4da0528b07fd5/build/BuildRelease.bat
Output of reportgenerator:
reportgenerator -reports:../out/CodeCoverageReport/System.Waf.cobertura.xml -targetdir:../out/CodeCoverageReport -reporttypes:"MarkdownSummaryGithub"
2024-11-06T21:42:42: Arguments
2024-11-06T21:42:42:  -reports:../out/CodeCoverageReport/System.Waf.cobertura.xml
2024-11-06T21:42:42:  -targetdir:../out/CodeCoverageReport
2024-11-06T21:42:42:  -reporttypes:MarkdownSummaryGithub
2024-11-06T21:42:42: File '/_/src/System.Waf/Samples/BookLibrary/BookLibrary.Library.Presentation/App.xaml.cs' does not exist (any more).
2024-11-06T21:42:42: File '/_/src/System.Waf/Samples/BookLibrary/BookLibrary.Library.Presentation/Converters/LanguageToStringConverter.cs' does not exist (any more).
2024-11-06T21:42:42: File '/_/src/System.Waf/Samples/BookLibrary/BookLibrary.Library.Presentation/Converters/StringToUriConverter.cs' does not exist (any more).
...

I'm using the latest version of dotnet-coverage and reportgenerator.

@Cjewett I have added documentation for DeterministicReport https://github.com/microsoft/codecoverage/blob/main/docs/configuration.md
@jbe2277 I see that you are using 17.11.1 version of sdk https://github.com/jbe2277/waf/blob/34629b5f4a9d83d320050fa0b8b4da0528b07fd5/src/Samples.UITest/Directory.Packages.props#L9. Can you please use 17.12.0 and try again?

@fhnaseer With version 17.12.0 it looks good now. Thanks.


More dedup clarification based on feedback

coverage: 94.293%. remained the same when pulling 0782d928318e9a3cdb682a71db68ed9a1962babe on rahul-clarify-dedup-2 into f992290be3c3cfdd8f221b2432d4172d8546de63 on main.


modifying type check to be more specific and correcting api test reference

…rence

this will resolve #9

This seems to be missing additional Unit Tests @f0zz . And Unit Test data.

@m-hintz-42 the changes should all be there now. Sorry about that.


enhancement: Add demos of each of the commands in the website documentation

This docs was added from v1.0.0-rc.4


Issues with free on Windows?

I am running into segfaults when using jdz_allocator on Windows, for example zig build test crashes:
PS D:\Projects\jdz_allocator> zig build test
test
└─ run test failure
Segmentation fault at address 0x136aa230018
D:\Projects\jdz_allocator\src\arena.zig:88:38: 0x890f30 in deinit (test.exe.obj)
            while (self.cache.tryRead()) |span| {
                                     ^
D:\Projects\jdz_allocator\src\shared_arena_handler.zig:42:45: 0x8716f0 in deinit (test.exe.obj)
                spans_leaked += arena.deinit();
                                            ^
D:\Projects\jdz_allocator\src\shared_allocator.zig:61:59: 0x85169e in deinit (test.exe.obj)
            const spans_leaked = self.arena_handler.deinit();
                                                          ^
D:\Projects\jdz_allocator\src\shared_allocator.zig:227:31: 0x8513fe in test.small allocations - free in same order (test.exe.obj)
    defer jdz_allocator.deinit();
                              ^
C:\Users\zenshixd\.zvm\0.13.0\lib\compiler\test_runner.zig:95:29: 0x815a28 in mainServer (test.exe.obj)
                test_fn.func() catch |err| switch (err) {
                            ^
C:\Users\zenshixd\.zvm\0.13.0\lib\compiler\test_runner.zig:35:26: 0x8112bb in main (test.exe.obj)
        return mainServer() catch @panic("internal test runner failure");
                         ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\start.zig:363:53: 0x811043 in WinStartup (test.exe.obj)
    std.os.windows.ntdll.RtlExitUserProcess(callMain());
                                                    ^
???:?:?: 0x7fff509a257c in ??? (KERNEL32.DLL)
???:?:?: 0x7fff528caf27 in ??? (ntdll.dll)
error: while executing test 'shared_allocator.test.small allocations - free in same order', the following command exited with code 3 (expected exited with code 0):
D:\Projects\jdz_allocator\.zig-cache\o\354cf489fe516b0b40cb86089b8e61db\test.exe --listen=-
Build Summary: 1/3 steps succeeded; 1 failed; 65/65 tests passed (disable with --summary none)
test transitive failure
└─ run test failure
error: the following build command failed with exit code 1:
D:\Projects\jdz_allocator\.zig-cache\o\4243a8c8e641ec349c481257cce3f2f5\build.exe C:\Users\zenshixd\.zvm\0.13.0\zig.exe D:\Projects\jdz_allocator D:\Projects\jdz_allocator\.zig-cache C:\Users\zenshixd\AppData\Local\zig --seed 0xba5b4683 -Z45839ca1b6a8fe75 test

Its always freeing memory that crashes, allocations usually work fine.
Another one I also run into is:
Segmentation fault at address 0x26611550018
C:\Users\zenshixd\AppData\Local\zig\p\122041a5792fa779a0aff08c1fb75e8ab847b8ec102666c309dd0fe07550d3249249\src\arena.zig:181:38: 0xc95aeb in getSpanFromCacheOrNewSplitting (test.exe.obj)
            return self.cache.tryRead() orelse
                                     ^
C:\Users\zenshixd\AppData\Local\zig\p\122041a5792fa779a0aff08c1fb75e8ab847b8ec102666c309dd0fe07550d3249249\src\arena.zig:165:52: 0xcac458 in allocateFromCacheOrNew (test.exe.obj)
            const span = self.getSpanFromCacheOrNew() orelse return null;
                                                   ^
C:\Users\zenshixd\AppData\Local\zig\p\122041a5792fa779a0aff08c1fb75e8ab847b8ec102666c309dd0fe07550d3249249\src\arena.zig:135:44: 0xc95aac in allocateGeneric (test.exe.obj)
                self.allocateFromCacheOrNew(size_class);
                                           ^
C:\Users\zenshixd\AppData\Local\zig\p\122041a5792fa779a0aff08c1fb75e8ab847b8ec102666c309dd0fe07550d3249249\src\global_allocator.zig:157:61: 0xc77fe6 in allocate (test.exe.obj)
                arena.allocateToSpan(utils.getSmallSizeClass(size))
                                                            ^
C:\Users\zenshixd\AppData\Local\zig\p\122041a5792fa779a0aff08c1fb75e8ab847b8ec102666c309dd0fe07550d3249249\src\global_allocator.zig:86:32: 0xc1a081 in alloc (test.exe.obj)
                return allocate(len);
                               ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\heap\arena_allocator.zig:167:50: 0xca0313 in createNode (test.exe.obj)
        const ptr = self.child_allocator.rawAlloc(len, log2_align, @returnAddress()) orelse
                                                 ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\heap\arena_allocator.zig:184:29: 0xc80e62 in alloc (test.exe.obj)
            (self.createNode(0, n + ptr_align) orelse return null);
                            ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\mem\Allocator.zig:225:53: 0xc7b5cc in allocBytesWithAlignment__anon_9315 (test.exe.obj)
    const byte_ptr = self.rawAlloc(byte_count, log2a(alignment), return_address) orelse return Error.OutOfMemory;
                                                    ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\mem\Allocator.zig:211:40: 0xc1dae7 in allocWithSizeAndAlignment__anon_5461 (test.exe.obj)
    return self.allocBytesWithAlignment(alignment, byte_count, return_address);
                                       ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\mem\Allocator.zig:193:41: 0xc80b23 in alignedAlloc__anon_9367 (test.exe.obj)
    return self.allocAdvancedWithRetAddr(T, alignment, n, @returnAddress());
                                        ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\array_list.zig:457:67: 0xc805a6 in ensureTotalCapacityPrecise (test.exe.obj)
                const new_memory = try self.allocator.alignedAlloc(T, alignment, new_capacity);
                                                                  ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\array_list.zig:434:51: 0xc21f52 in ensureTotalCapacity (test.exe.obj)
            return self.ensureTotalCapacityPrecise(better_capacity);
                                                  ^
D:\Projects\zapts\src\lexer.zig:129:44: 0xc22e3f in next (test.exe.obj)
                try str.ensureTotalCapacity(100);
                                           ^
D:\Projects\zapts\src\lexer.zig:397:36: 0xc26552 in nextAll (test.exe.obj)
        const token = try self.next(current_char);
                                   ^
D:\Projects\zapts\src\parser.zig:394:37: 0xc271cb in init (test.exe.obj)
    const tokens = try lexer.nextAll();
                                    ^
D:\Projects\zapts\src\compile.zig:39:33: 0xc373ec in compileBuffer (test.exe.obj)
    var parser = try Parser.init(arena.allocator(), buffer);
                                ^
D:\Projects\zapts\src\tests_runner.zig:136:37: 0xc177d4 in runTest (test.exe.obj)
    const result = try compileBuffer(allocator, case_filepath, buffer);
                                    ^
D:\Projects\zapts\src\tests_runner.zig:57:20: 0xc164f4 in main (test.exe.obj)
        if (runTest(jdz.allocator(), root_dir, case_file.filename, case_file.expect_filename)) |_| {
                   ^
C:\Users\zenshixd\.zvm\0.13.0\lib\std\start.zig:363:53: 0xc1956c in WinStartup (test.exe.obj)
    std.os.windows.ntdll.RtlExitUserProcess(callMain());
                                                    ^
???:?:?: 0x7fff509a257c in ??? (KERNEL32.DLL)
???:?:?: 0x7fff528caf27 in ??? (ntdll.dll)

Do you know why this could be happening ?

Have not tested on Windows yet so thanks for the report, will try fixing this tomorrow.

just fyi, i did some digging, and it seems its caused by how VirtualFree with MEM_RELEASE frees up memory. It doesnt use size parameter at all, and deallocates the entire region at base_ptr
So from my understanding, the flow looks like this:

we bulk allocate 65 spans (64 default + 1 padding) - what we get from VirtualAlloc is some base_ptr
arena claims only 1 span for itself - the ptr address of this span happen to be at base_ptr
during deinit(), we free spans 1 by 1 (or rather by span_count) and span at base_ptr happens to be freed first
which means that all 65 spans will be deallocated at once, since VirtualFree deallocates everything at once.

Quick fix on my side was to change MEM_RELEASE to MEM_DECOMMIT, since this mode does respect size parameter, but not sure if its good solution.

ah interesting, I think ideal way to fix this would also result in adding huge page support which is nice (as same issue applies there)
as a temporary band-aid fix I might just make os == windows result in mapping spans individually + disbabling large span splitting, but will check what other allocators are doing first

Same issue under Windows 10
Well, the current base code can't be used under windows


Support audio src='' for u- properties

I use this gem with Jekyll to pull reply contexts for my site. I often repost content from my podcast site where posts appear in an h-feed as h-entry with a u-audio on the <audio /> tag inside of the e-content. (Here's an example).
Before this patch, I would get back an empty audio property. With this patch, audio now contains the URL for the media file as I'd expect.

Looks awesome, perhaps we should do the same for the video tag?

Looks good to me. Add video too and I'll merge it and package a new gem release.

Added video src='' as well as source src='' (to fully match the bullet point in the parsing a u-property docs)

Good catch @martymcguire

Release 2.1.
https://rubygems.org/gems/microformats2

Thanks for the new release! 🎉


Run relevant test_tracetools tests with all instrumented rmw impls

Fixes #131
This is equivalent similar to #116 but for Jazzy.
See explanation in #132. For Jazzy, rmw_connextdds is supported (compared to Iron), but rmw_fastrtps_dynamic_cpp is not (compared to Rolling).

I don't think we have a manual version of the Jci__nightly-fastrtps-dynamic_ubuntu_noble_amd64 job, so I'll just run manual CI:

Linux
Linux-aarch64
Linux-rhel
Windows

I did test locally by setting RMW_IMPLEMENTATIONS=rmw_fastrtps_dynamic_cpp when running colcon build and the tests were skipped.

I think the failure in test_pub_sub__rmw_connextdds on RHEL is a flake and should be resolved by backporting #125 to Jazzy.

I think the failure in test_pub_sub__rmw_connextdds on RHEL is a flake and should be resolved by backporting #125 to Jazzy: #135.

Done. I rebased this. Re-running CI just to be sure:

Linux
Linux-aarch64
Linux-rhel
Windows

@clalancette @fujitatomoya can one of you review this?


map iNat sequences to MO

Map iNat Observation Fields with sequences to MO sequences.
Issue: iNat lacks uniform treatment of isequences. The data can be in a  variety of user-created Observation Fields. It's a free-for-all.
Tasks

[x] Map iNat DNA-type Observation Fields
[x] Ensure that Sequences work on Sigrid Jakob observations.
[x] Ensure that Sequences work on Danny Miller observations.
[ ] Check other observations in 2023 NEMF list
[ ] Check non-DNA type Observation Fields

Danny MIller iNat Observations with sequences. https://api.inaturalist.org/v1/observations?ofv_datatype=DNA&user_id=dannymi&order=desc&order_by=created_at&only_id=true

Sigrid uses "DNA Barcode ITS" which is a DNA-type field, so we're good.