Dragon Age: Inquisition

Meta-issue for Dragon Age: Inquisition.

[ ] Working
[ ] Tessellation
[ ] ???

Logs from current master ( 6a0e4d860f55eb4f5cdef00e97bd95bca788505b )
grvk.log
grvk_axl.log
Crashes during launch.

Thanks, I have a branch that makes it boot, I can go in-game but it crashes during the first dialog scene.

@Nerellus the game should boot and go ingame with this build: https://github.com/libcg/grvk/suites/4708213536/artifacts/129087929 (make sure tessellation is disabled in the settings). However I'm seeing a crash in the first dialog scene when starting a new game.

Unfortunately I still don't make it to the menu, I get
wine: Unhandled page fault on execute access to<PHONE_NUMBER>000000 at address<PHONE_NUMBER>000000 (thread 0520), starting debugger... at launch now.
origin.log
grvk.log (with GRVK_LOG_LEVEL=trace)
grvk_axl.log

@Nerellus try this build: https://github.com/libcg/grvk/actions/runs/1605043031 I fixed a few validation errors.
The in-game crash I mentioned earlier is caused by unhandled tessellation shaders.

I still get the page fault at launch with d9ca03e74ef21e6699342a23338fcd77d4b02a15.

OS: Arch Linux
KERNEL: 5.16.0-rc6-1-mainline
CPU: AMD Ryzen 7 3800XT 8-Core
GPU: AMD Radeon RX Vega (vega10, LLVM 13.0.0, DRM 3.44, 5.16.0-rc6-1-mainline)
GPU DRIVER: 4.6 Mesa 22.0.0-devel (git-222487fabe)
RAM: 32 GB
GRVK: d9ca03e
steam-1222690.log
grvk.log
grvk_axl.log
Result.

Game starts up with GRVK, nicely goes through the menu, race and what type of character its gonna be, then the heper cards, and than..... The picture above. Have to shoot down the processes through ssh and reboot the computer to get back the screen.

So, just ran it again, made sure everything i know of what can cause my system to hang up is off (PBO, no OC nothing, just default system).
Same result. Settings: Low preset, fullhd, mantle.
Its loading into world, walked away from the moment when first you can controll the character, up halfway on the mountain side while i was checking the game works with dxvk. Then there made a save, and loading back there. The game loads in the first few frame, and crash. i think its crashing the gpu (resulting in the same screen as above), probably tries to do something stupid, or not yet implemented, and pulls down the whole 3d engine, and probably mutter too. If i SSH in and do a sudo reboot, console comes back and shows the normal messages as its shutting down modules, and does the reboot process.
One note: I think GRVK needs a check on what vulkan implementation its loading in. As im building mesa-git, RADV, lavapipe, Intel, vrtio all gets build, and for some reason grvk tries to load in a different one then what it should on my amd vega gpus, until i remove all the others and only leave radv in vulkan/icd.d.
logs with GRVK_LOG_LEVEL=trace
dragonagecrashgrvk.zip

Hoi! New month, new testruns. Game loads into menu, but on high settings it crashes as its loading the game, on low it loads in the first few frames, (like5-10) and than its crashing.
Logs:
high settings:
grvk_axl.log
high settings-grvk.zip
high settings-steam-1222690.zip
Origin_d3d11.log
Origin_dxgi.log
low settings:
grvk_axl.log
low settings- steam-1222690.zip
Origin_d3d11.log
Origin_dxgi.log
Not sure why, but the low settings grvk.log github does not accept it, none compressed its obviously to big, but even compressed its reject it, so ive uploaded it to my google drive: https://drive.google.com/file/d/1E1CGZ_aiBmWTEASUTZMroE4AeaSbFg0a/view?usp=sharing

@plasticbomb1986 the crash you were seeing should be fixed by https://github.com/libcg/grvk/commit/02ae2a5db29a8aab3b1787da844dd8db241a3172

The game should be playable as of 2bb8b8e (build available here: https://github.com/libcg/grvk/suites/9530381740/artifacts/452852535)
Make sure to disable tessellation in the settings to make the terrain visible. Also, there's a rendering bug where shadows disappear depending on the camera position.


NEW: PPRS action

The last core functionality PR for q2-fmt

[x] rebase this PR so that all my new changes are included
[x] added PPRS method
[x] Write unit tests
[x] add examples

This PR:

refactors _engraftment to have two new helper functions (get_to_baseline_ref, _get_series_from_col).   get_to_baseline_ref is a method that creates a baseline reference column from metadata and  _get_series_from_col was a nested helper that I exposed so I could use it 😈 .
adds pprs methods

closes #81

I wanted to use some helper methods from _engraftment.py but they were nested and I wasn't able to access them so I had to do some minor engraftment refactor. Open to suggestions if there is a better way to do this.

Back at ya @lizgehret.

Thank you!

closes #69

@cherman2 and I discussed offline a few additional changes that resulted from user testing:

update peds-heatmap with different nomenclature (depending on if the input is peds or pprs)
fix the sampleSize issue in heatmap
update usage example description to not just be peds methods
update sample-pprs name to include (features) in each recipient sample

Hi @lizgehret, I was able to fix these issues pretty quickly! Thank you so much for the reviews!

Is this just specific to PEDS, or should this be updated to PEDS/PPRS?

Looks like this also needs to be updated to PPRS

Should the input table be called peds-table? Or pprs-table? Maybe just simplify to table, so it can be used for both methods?

 Is this just specific to PEDS, or should this be updated to PEDS/PPRS?

This is PEDS and heatmap will fail if PPRS is handed with these stats because they are not relevant.

 Is this just specific to PEDS, or should this be updated to PEDS/PPRS?

This is PEDS and heatmap will fail if PPRS is handed with these stats because they are not relevant.

that's right - i remember seeing that error message now. just wanted to double check!

ok one final user review and then this should be ready to merge

ok LGTM!!!!!! 🚀


Handle correctly Not Provided/ Not Collected data

As a developer, I want to handle the special cases of "Not Provided" / "Not Collected" when looking for suggestions because those are not literal values to look for, especially since some ontologies can contain some of those words but mean something totally different.

need to discuss


Update 2015-12-25-support-powerbi-tableau9.md

Corrected some typos in the doc.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@NickJain07 Thanks Nick. LGTM.


The $Env:OS Variable Should Be Set for both Windows and Linux versions of powershell

Steps to reproduce
On Linux:
pwsh
PS /home/thebtm/Downloads> echo $Env:os
PS /home/thebtm/Downloads> echo $Env::os
PS /home/thebtm/Downloads> echo $Env:os

PS /home/brad/Downloads> get-childitem Env:
##OS is missing

On Windows:
PS E:\tmp> echo $env:os
Windows_NT

PS /home/brad/Downloads> get-childitem Env:
...
OS                             Windows_NT
...

Expected behavior
PS /home/thebtm/Downloads> echo $Env:os
RHEL/CentOS/Ubuntu/Debian/OS_X/Etc

Actual behavior
Its not set for the linux version

Environment data

PS /home/brad/Downloads> $psversiontable

Name                           Value
----                           -----
PSVersion                      6.0.1
PSEdition                      Core
GitCommitId                    v6.0.1
OS                             Linux 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 20:13:58 UTC 2018
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

PS E:\tmp> $psversiontable

Name                           Value
----                           -----
PSVersion                      5.1.14393.2068
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2068
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

$env:OS is a Windows-specific system environment variable - it has nothing to do with PowerShell per se.
Letting PowerShell define its own environment variables - which can affect any processes launched from a PowerShell session - should be avoided.
Instead, PowerShell Core already offers the PowerShell-internal automatic $IsWindows, $IsLinux and $IsMacOS variables.
The only problematic aspect is that $IsWindows is not defined in Windows PowerShell.
(By contrast, given that undefined variables are "falsy", something like if ($IsLinux) and if ($IsMacOS) will work as expected in older versions - unless Set-StrictMode -Version 2 or higher is in effect).
Thus, you can use one of the following methods to detect running on Windows in a backward-compatible fashion (both approaches work even with Set-StrictMode -Version 2 or higher in effect:
# Backward-compatible way to detect if code is running on Windows.
$runningOnWindows = $env:OS -eq 'Windows_NT'

# Alternative:
# Also uses this approach with $IsLinux and $IsMacOS, if needed,
# so as to avoid Set-StrictMode -Version 2+ issues.
$runningOnWindows = (Test-Path variable:IsWindows) -and $IsWindows

Thank you for the information then I will work with what I can.


Type "IF_SATC_CI_VARIANT_ACCESS" is unknown (731 regression)

ZCL_ABAPGIT_CODE_INSPECTOR

argh, I'll have a look


feat(event-handling): Add Ace library that embeds OnEvent for supporting non-overwriting event handlers

Summary from discord:

Use AceAddon's NewModule for files/modules that need their own event handling logic
Use RegisterEvent on said module to avoid main addon handler conflicts


Server setup - digital ocean example

I'm hoping to run the server on a Digital Ocean droplet. Is the following a good plan?

Create a new droplet (let's assume I use my SSH key instead of password-based)
Create a dedicated sirtunnel user so I'm not running as root
Create an SSH keypair id_sirtunnel for this new user. The private key is what will be used by users/clients
Clone SirTunnel to the droplet, run the install.sh and then run_server.sh
Register a dedicated domain for this (let's say rarkinstunnel.com)
Configure a wildcard DNS entry for rarkinstunnel.com pointing to my droplet IP
ssh -i ~/.ssh/id_sirtunnel -tR 9001:localhost:8080 rarkinstunnel.com sirtunnel.py sub1.rarkinstunnel.com 9001

Is that enough, including for Caddy to somehow fetch certs from LetsEncrypt for rarkinstunnel.com?
BTW I'm not sure I understand the 9001 port, which I've copied directly from your example. Does that need to be unique for each different user/tunnel I wish to run?

Hey @rarkins, I haven't used SirTunnel in a while (I use boringproxy, which you might consider taking a look at), but this sounds basically right. You'll probably need to do a bit of tweaking, and I'd recommend using a newer version of Caddy (by updating install.sh).
And yes 9001 is an arbitrary port for the example, and you'll need to use a different port for each tunnel.


Fix #147: Correctly get channel name in notifications

eslint failed:

/home/travis/build/thelounge/lounge/client/js/lounge.js
697:36  error  Strings must use doublequote  quotes

Fixed.

:+1:


Move colormap to utils.

Moves colormap from svg to utils. It doesn't make sense to leave it in svg and import svg from utils which leads to circular imports anyway.

:+1:


Avoid double translation of the same strings

If one submit a translation and itsn't immediately marged, it could be that somebody else submit a translation, maybe different, but of the same strings.
So, why don't show a message to inform that those strings were already translated or, better, avoid any translation for those strings there?

So far I can remember just an couple of double submits the last years, so I think it is not a big issue..
For most plugins and dokuwiki itselft, the translations are merged relatively fast.

Some thoughts about possible improvements:

If something is merged it takes some time for the translation tool sees this because it checks at frequency of hours (or even 24hours) the state of the repository.
Store and mark submitted strings. But this requires parsing stored update files and use that info in the displaying of the strings in the interface. Knowing which update files are already merged in the repository, can be performed by comparing dates of update files and the respectively language file in the repository.

improvement 2 is quite an effort and complexity. Is that it worth?

would be simple to improve by using a webhook. This way github could tell us when a branch gets merged

@tormec , with #100 a message is now shown above the translation form with the number of open pull request for the current language. This requires a small effort of the user to investigate the situation, but the system gives at least a hint about the situation.
A string-by-string comparison is technical an extensive job to build into the tool. Therefore I consider that current solution is reasonable trade-off between complexity and user comfort. Or do you see more possibilities to inform?


Redeploy djcompute.internationalbrainlab.org into kube-cluster

Currently deployed in djcompute-new in IBL's AWS.


Clang errors about the std::uint64_t not being in namespace std

I'm seeing:
error: use of undeclared identifier 'std'
        using ID = std::uint64_t;

Super simple fix, add
#include <cstdint>

closed by: 518f050b5c1f6e072197a8d5a4f2f71468bb1a81


eventAuditor: NETNEXT kernel without proper bpftool

event-auditor branch
The bpftool is needed to dump the vmlinux.h from the kernel. The NETNEXT kernel version 5.13.0-051300rc3-generic doesn't provide a proper packaged bpftool.

Officially, the most up-to-date ubuntu package that contains bpftool is linux-tools-common 5.11.0-20.21+21.10.1.
https://packages.ubuntu.com/search?keywords=linux-tools-common

Probably for this kernel:
https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.11.21/amd64/

I've tested the 5.11.21 kernel to get along with the bpftool. A full Ubuntu upgrade is required for clang and bpftool work correctly. In other words, the bionic version has been upgraded to impish. I suppose it would be easier to just start with impish release.
@nyrahul @nam-jaehyun Is there any requirements that don't allow this?

@geyslan yes, NETNEXT=1 just increases the kernel version (5.13).
you can add an option to change the base image. the current base image is ubuntu/bionic64 (i.e., ubuntu 18.04).
according to the option, you can use ubuntu/impish64 (i.e., ubuntu 20.10).

@geyslan also, please add the required packages (e.g., linux-tools-common) in setup.sh.

I updated the NETNEXT option.
NETNEXT=0 -> ubuntu/bionic64 (ubuntu 18.04, kernel 4.15)
NETNEXT=1 -> ubuntu/impish64 (ubuntu 20.10, kernel 5.11)
NETNEXT=2 -> ubuntu/focal64 (ubuntu 20.04, kernel 5.4)
@geyslan can you add any required packages (e.g., linux-tools-common) in contribution/self-managed-k8s/setup.sh?


RDS replicas don't have password exported

The postgres RDS replicas require that null is passed in for the password, given that it's assigned the same password as the source database. However, the replica's password is exported as "null" rather than the actual value that it's given.
This causes missing information for modules that are dependent on the correct password, such as creating a Secrets Manager record that contains the database credentials.

hi @jtai-omniex  - I would recommend not exporting passwords from the replicas as the passwords are set/controlled in the read/write (primary) instance. Replicas are just that, an exact copy of the primary

@antonbabenko we can close


auto allocate ip while updating the store

Auto allocate IPs during store update to avoid DeepCopy in Services() call as Services() is frequently used.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
33ff8ae7ddf4c23983bdec5f618ea7bae182aa72
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I am still working on this. not ready for review yet.

autoAllocateIPs starts at the same base IP each time. Calling it multiple times will lead to overlapping allocated IPs?

Yes. Conversion is not the right place. I am changing to do at the time when we add a new service for all services.

If we want to allocate once per service, the right direction should be ipadm, and also be care of sync between multi instances

If we want to allocate once per service, the right direction should be ipadm, and also be care of sync between multi instances

I am not planning to do that but allocate them all at once today but only do when services are added to store rather than when they are retrieved to avoid deepcopy and repeated autoallocations as gets are lot more than updates

@hzxuzhonghu @howardjohn This is ready for review except for one TODO I left in the code which I will finish it before merging. But I want you to look at overall approach and see if it makes sense?

Will have a look, this is hot path

@howardjohn @hzxuzhonghu I think this is ready for review. Can you PTAL?

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c1685dbfee8344f7fb15310f63295d5b3c8b148
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn can you please remove the requested changes as well?


Webpack compatibility with angular versions.

Need
I need to know the compatibility of various webpack versions with various angular/angular-cli/node-js/typescript versions.

please ask in angular related issue trackers, thanks


i18n setDateLocale breaks keyboard input and timezone processing for date input

Reproduction link
https://codesandbox.io/s/agitated-haslett-gyhgv?file=/src/app/app.component.ts
Steps to reproduce
use setDateLocale to setup locale for the date, default en_US will work as well
use keyboard to copy and paste or manually input date
or even with mouse but in that case error is not that obvious because click on calendar is using current time and not 00:00:00 point
see output date to be adjusted to current timezone, i.e. if GMT 2 timezone and date is 2021-10-22 | json output would be "2021-10-21T22:00:00.000Z"
if setDateLocale is not used output is "2021-10-22T00:00:00.000Z" i.e. date object is UTC(2021-10-22)` in that case
What is expected?
to have same behaviour for default and setDateLocale usage
What is actually happening?
See steps to reproduce.

Environment
Info

ng-zorro-antd
12.0.1

Browser
Chrome

I am not sure what behaviour is better (default or after setting locale for dates) but it must behave the same way using any type of inputs.
Small video demonstration:
https://user-images.githubusercontent.com/24417201/138439326-13bd07de-b0eb-4aae-952a-b9d86850d3de.mov

That behaviour is basically due to using date-fns
return i18n.getDateLocale() ? new DateHelperByDateFns(i18n, config) : new DateHelperByDatePipe(i18n, config);
without DateLocale service just calls new Date(text) and with
return fnsParse(text, formatStr, new Date(), {
      locale: this.i18n.getDateLocale(),
      weekStartsOn: this.getFirstDayOfWeek()
    });


Migrate to Flowzone

- What I did
- How I did it
- How to verify it
- Description for the changelog

One way to hand over state from compose tests to custom publishing pipeline, would be to just upload the source artefact after docker_tests have concluded (i.e.):
      # ... after docker-compose sut

      - name: Compress source
        run: tar -acvf ${{ runner.temp }}/docker.tgz .

      - name: Upload artifact
        uses: actions/upload-artifact@v3
        with:
          name: docker-${{ github.event.pull_request.head.sha || github.event.head_commit.id }}
          path: ${{ runner.temp }}/docker.tgz
          retention-days: 1

This approach will allow us to continue (miss)using docker-compose tests flow to not only run tests, but to also generate and extract assets for publishing into the source tree as this PR demonstrates. The subsequent custom publish steps would then pick up the assets from the source tree and publish them as GH releases, or whatever.
The other option I suppose, is to just do all of the build/test/publish work in the custom flow, like we've done for Etcher/CLI, but that will require recreating a lot of logic that already exists in the Docker flow and disabling the core Docker logic somehow.
I am leaning towards the first option. Thoughts @Page- @lmbarros @klutchell ?

@Page- @lmbarros here is the minimum set of changes I was able to come up with to move balena-engine to Flowzone and have it test, build and publish a GitHub release.
Unit tests are executed using docker-compose SUT pattern, reusing moby's DinD scripts. The build is done using docker buildx bake action, reusing moby's bake hcl. Everything is wrapped using Flowzone custom workflow.
We should review the skipped unit tests as well as give these binaries a solid test before merging. If that all works, we should probably consider consuming these releases in Jenkins balenaOS builds instead of rebuilding them there.
current run: https://github.com/balena-os/balena-engine/actions/runs/3471627690
upcoming draft release: https://github.com/balena-os/balena-engine/releases/tag/untagged-a3a09667183da3f1b5e3
cc @klutchell @alexgg @jakogut

@nucleardreamer @vipulgupta2048 folks, https://www.balena.io/engine/ will most likely be invalidated by a new release here. Are one of you able to prepare a PR to match or let me know who else I can talk to about this please...

https://www.balena.io/engine/ will most likely be invalidated by a new release here. Are one of you able to prepare a PR to match or let me know who else I can talk to about this please...

cc: @iamsolankiamit Can help with the PR to balena-site so that the release is correct.

So, I'd like to keep as close as possible to 22.10 to avoid merge conflicts in future merges from upstream. I suspect many of the changes that are coming from master/22.06 aren't really necessary for the Flowzone migration.

@lmbarros I've done a quick sync with moby/20.10 and have managed to condense the number of changes to effectively 4 files. If you can reduce these even further, that would be awesome, but this is the best I was able to come up with.

Unfortunately the current 20.10 Dockerfile, does not build in the GH Actions runner environment, even though it seems to work locally.

I got it to build with a few more external dependency bumps from 20.10 @lmbarros, over to you I guess...

So, @ab77 :

I added a commit that moves the creation of the symlinks from the installer to the build process itself. This ensures that people downloading the archive directly from the GitHub releases will get the symlinks too.
The tests being skipped are fine to be skipped.
I tested some of the binaries (on a 32- and a 64-bit Raspberry Pi OS) and they are fine.

I believe at this point we are much better than we were before.
If you don't scream about this last commit I made, I'll merge this PR.
And thanks again for doing this! :pray:

If you don't scream about this last commit I made, I'll merge this PR.

Ship it @lmbarros !

And thanks again for doing this! 🙏

You are welcome, as always.


Disable/Remove mako

Hi,
Some time ago I replaced mako with SwayNotificationCenter. The way I did it was to create the file ~/.config/sway/definitions.d/40-notifications.conf with the following content:
# set $notifications mako -c $HOME/.config/mako/config
set $notifications swaync

It worked for a while but I recently updated SwayNotificationCenter and it stopped working (it runs mako after every boot).
If I kill -9 <mako's pid> and then run swaync, the notifications work exactly as expected but I'm unable to get it working after boot.
What can I try?

I think what you do is exactly right.
recording_20220922-104015.webm

Hi @boredland 😄, thanks for stopping by.
This was my first thought too but I couldn't find any:
$ grep -rnw /etc/sway/ -e mako
/etc/sway/definitions:69:set $notifications /usr/share/sway/scripts/mako.sh --font "$term-font" --text-color "$text-color" --border-color "$accent-color" --background-color "$background-color" --border-size 3 --width 400 --height 200 --padding 20 --margin 20 --default-timeout 15000

$ grep -rnw ~/.config/sway/ -e mako
<HOME>/.config/sway/definitions.d/40-notifications.conf:1:# set $notifications mako -c $HOME/.config/mako/config

I also wanted to try the hard way and remove mako completely off my system but it is required by manjaro-sway-settings so I though on not removing it for now unless there is no other option. 😞
What I don't get is how is mako even being run? Even if swaync command failed misserably, what is pulling mako up?

depending on how old your config is, there may be an issue in .config/sway/config - you could diff that with the version in /etc/skel/.config/sway/config.

Good point! Still no luck tho 😞
$ md5sum ~/.config/sway/config
13aa86f26eaaa7347a4bce9e2d12f3f8  <HOME>/.config/sway/config

$ md5sum /etc/skel/.config/sway/config
13aa86f26eaaa7347a4bce9e2d12f3f8  /etc/skel/.config/sway/config

For record, this is the content of those files:
# Default config for sway
#
# Copy this to ~/.config/sway/config and edit it to your liking.
#
# Read `man 5 sway` for a complete reference.

# styles - set the folder for your theme definition file
set $theme /usr/share/sway/themes/matcha-green

# theme variables
include $theme/definitions

# global variables
include /etc/sway/definitions

# user variables
include $HOME/.config/sway/definitions.d/*.conf

include /etc/sway/inputs/*
include /etc/sway/outputs/*

# enable modes
include /etc/sway/modes/*

# only enable this if every app you use is compatible with wayland
# xwayland disable

# include additional configs e.g. to autostart applications
include /etc/sway/config.d/*

# user config
include $HOME/.config/sway/config.d/*.conf

I've been checking this file and the order of definition/execution seems correct. It also seems like it is redeclaring the variable in the right order.
I'm really puzzled with this behaviour... 🤔
I'm tempted to think that maybe the ~/.config/sway/ files aren't being loaded but I do have other configurations in there and they are picked up correctly.

Hard to find out, I guess. Is there perhaps anything calling it from config/sway/config.d ?

And just like that, it got solved... 🤷🏼♂
Another update came today plus a bunch of other packages and it got resolved alone. I still don't know what happened or why mako was being executed.
So, in conclusion, the configuration was correct and sway was, apparently, following the configuration but something got mako invoked which prevented swaync to run.

Ok, it happened again... For whatever reason, mako is running again.
I've remembered the pstree command and, as expected it is running and it seems to be running off systemd:
$ pstree
systemd-+-NetworkManager---2*[{NetworkManager}]
        |-systemd-+-(sd-pam)
        |         |-mako

However, I can't find any obvious service that runs it:
$ systemctl list-units --type=service
  UNIT                                                LOAD   ACTIVE SUB     DESCRIPTION
  apparmor.service                                    loaded active exited  Load AppArmor profiles
  auto-cpufreq.service                                loaded active running auto-cpufreq - Automatic CPU speed & power optimizer for Linux
  avahi-daemon.service                                loaded active running Avahi mDNS/DNS-SD Stack
  bluetooth.service                                   loaded active running Bluetooth service
  cups.service                                        loaded active running CUPS Scheduler
  dbus.service                                        loaded active running D-Bus System Message Bus
  docker.service                                      loaded active running Docker Application Container Engine
  greetd.service                                      loaded active running Greeter daemon
  kmod-static-nodes.service                           loaded active exited  Create List of Static Device Nodes
  lvm2-monitor.service                                loaded active exited  Monitoring of LVM2 mirrors, snapshots etc. using dmeventd or progress polling
  NetworkManager-wait-online.service                  loaded active exited  Network Manager Wait Online
  NetworkManager.service                              loaded active running Network Manager
  polkit.service                                      loaded active running Authorization Manager
  rtkit-daemon.service                                loaded active running RealtimeKit Scheduling Policy Service
  snapd.apparmor.service                              loaded active exited  Load AppArmor profiles managed internally by snapd
  snapd.service                                       loaded active running Snap Daemon
  systemd-backlight@backlight:intel_backlight.service loaded active exited  Load/Save Screen Backlight Brightness of backlight:intel_backlight
  systemd-backlight@leds:dell::kbd_backlight.service  loaded active exited  Load/Save Screen Backlight Brightness of leds:dell::kbd_backlight
  systemd-binfmt.service                              loaded active exited  Set Up Additional Binary Formats
  systemd-journal-flush.service                       loaded active exited  Flush Journal to Persistent Storage
  systemd-journald.service                            loaded active running Journal Service
  systemd-logind.service                              loaded active running User Login Management
  systemd-modules-load.service                        loaded active exited  Load Kernel Modules
  systemd-random-seed.service                         loaded active exited  Load/Save Random Seed
  systemd-remount-fs.service                          loaded active exited  Remount Root and Kernel File Systems
  systemd-sysctl.service                              loaded active exited  Apply Kernel Variables
  systemd-tmpfiles-setup-dev.service                  loaded active exited  Create Static Device Nodes in /dev
  systemd-tmpfiles-setup.service                      loaded active exited  Create Volatile Files and Directories
  systemd-udev-trigger.service                        loaded active exited  Coldplug All udev Devices
  systemd-udevd.service                               loaded active running Rule-based Manager for Device Events and Files
  systemd-update-utmp.service                         loaded active exited  Record System Boot/Shutdown in UTMP
  systemd-user-sessions.service                       loaded active exited  Permit User Sessions
  tlp.service                                         loaded active exited  TLP system startup/shutdown
  udisks2.service                                     loaded active running Disk Manager
  upower.service                                      loaded active running Daemon for power management
<EMAIL_ADDRESS>                     loaded active exited  User Runtime Directory /run/user/1000
<EMAIL_ADDRESS>                                 loaded active running User Manager for UID 1000
  wpa_supplicant.service                              loaded active running WPA supplicant

LOAD   = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB    = The low-level unit activation state, values depend on unit type.
38 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

Any idea how can I check what service is triggering it?

what happens if you edit the /etc/sway/definitions file directly and comment out the
set $notifications /usr/share/sway/scripts/mako.sh line
as I am petty sure that is the only thing that starts mako for us.

I'll try it and report it back but, if this is true, it means there is something very wrong in the way sway loads the configuration files 😞.  From what I can tell, any other config file is loaded correctly but this one 🤔.

Well I just installed swaync and
int my ~/.config/sway/definitions.d/00-user-define.conf
put
set $notifications swaync
rebooted and it started with no mako

@Mathew-D I'm afraid it didn't work.
I updated /etc/sway/definitions as per your suggestion leaving it as follows:
$ cat /etc/sway/definitions
...

###Notification daemon configuration
# set $notifications /usr/share/sway/scripts/mako.sh --font "$term-font" --text-color "$text-color" --border-color "$accent-color" --background-color "$background-color" --border-size 3 --width 400 --height 200 --padding 20 --margin 20 --default-timeout 15000
set $notifications swaync

...

It did not make any difference. After a full restart, mako is again the running notifications daemon 😩.

well the shit answer is to
 sudo mv /usr/bin/mako /usr/bin/mako-b
I am not sure what could be running mako.
When  you ps ux is mako near the top that might give you some idea when it is starting.

I think I found your problem.
"NetworkManager-wait-online.service blocks until NetworkManager logs "startup complete" and announces startup complete on D-Bus."
That service is trying to announce which I think means it is trying to use mako to do it.  Try turning that service off and see if that fixes your problem.

Fyi, I stumbled here because I had the same issue that mako magically was started on boot even though I overrode the $mako and $notifications definition like this:
$ cat ~/.config/sway/definitions.d/custom.conf
set $notifications swaync
set $mako swaync

I noticed this line in the journal:
 dbus-daemon[977]: [session uid=1000 pid=977] Activating via systemd: service name='org.freedesktop.Notifications' unit='mako.service' requested by ':1.34' (uid=1000 pid=1161 comm="poweralertd -s -i line power")

And found that a systemd user session was still active (using the /usr/lib/systemd/user/mako.service service definition).
I disabled it by systemctl --user mask mako.service and now it doesn't start anymore.

Yes! YEEEEEEES!
It worked! I almost had an orgasm when I finally saw swaync starting on it's own after all this time!
It turns out I was not only missing the systemctl call but also the set $mako swaync part!
A million thanks for sharing it.
Definitely not all heroes wear capes!

Yes! YEEEEEEES!
It worked! I almost had an orgasm when I finally saw swaync starting on it's own after all this time!
It turns out I was not only missing the systemctl call but also the set $mako swaync part!
A million thanks for sharing it. @varac you are a true hero!
Definitely not all heroes wear capes!

Very nice! We should probably rename $mako to something less vendor-specific and add this to our support.md - In general I'd be open to a PR switching out mako with another default. I have not strong opinions on that and never missed anything with mako.

@carlosV2 Nice that it works for you, you're welcome!


Hide actual tables from information_schema in Google Sheets

Fixes #2115

Please add tests that cover #2115.

Updated. The added test will be failed when we add a new table to inforamtion_schema, though.


Short break timer isn't starting or available after pomodoros.

The last 2 pomodoros I have started have run their 25-minute "active" course and simply stopped. Usually, at the end of a pomodoro, a desktop notification occurs and (depending on the status of the "Start breaks manually" toggle) will either automatically start the break or allow you to click to start the break. Neither is occurring, and I'm instead getting the same pale blue screen that you would normally see at the end of a long break. The short break cannot be started automatically or manually, and clicking the button just starts a new 25-minute active window. My settings are as follows:
Pomodoro duration: 25
Skip to break button: 0
Short break duration: 5
Break extension: 2
start breaks manually: 0
reset timer after break extension: 0
long break after: 4
long break duration: 30
Pomodoro end sound: 9
Break end sound: 8
Ambient sound: clock
If there is anything I can try on my end to potentially resolve this, that would be awesome!

Wait, I also just realized that this could be caused by the current 502 server issues habitica is having? If that is the cause, could there be something the dev(s) could do to prevent similar habitica server errors from causing these pomodoro timer errors?

Hi Dylan,
Yes, The issue you're experiencing may be due to current server problems
with Habitica. I'm not an official Habitica developer, so I can't directly
address it. Please check their official channels for updates.
In the meantime, you can disconnect my Pomodoro extension from Habitica in
the settings so you won't get errors, and reconnect it when the server
issue is resolved.
Let me know if you have any questions :)
On Sat, 16 Sept 2023 at 19:56, Dylan R @.***> wrote:

Wait, I also just realized that this could be caused by the current 502
server issues habitica is having? If that is the cause, could there be
something the dev(s) could do to prevent similar habitica server errors
from causing these pomodoro timer errors?
—
Reply to this email directly, view it on GitHub
https://github.com/ofekmiz/Habitica-Pomodoro-SiteKeeper/issues/124#issuecomment-1722270264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJOEOFWSGM7S2RE4ZTNLGFLX2XK4FANCNFSM6AAAAAA4257YEY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>


[BUG]:Typescript error in schema file

What version of drizzle-orm are you using?
0.28.3
What version of drizzle-kit are you using?
0.19.13
Describe the Bug
Title: Type Error in schema.ts - Type 'string' not assignable to type '"id"'
Description:
I encountered a type error with the following code in schema.ts while working on the project:
import { pgTable, serial, text, varchar } from "drizzle-orm/pg-core";

export const users = pgTable('users', {
  id: serial('id').primaryKey(),
  fullName: text('full_name'),
  phone: varchar('phone', { length: 256 }),
});

The error message I received is: "Type 'string' is not assignable to type '"id"'." It seems to be related to the assignment of serial('id').primaryKey() to the id property. I'm unsure how to resolve this issue. Could you please provide guidance on how to fix this type error?
Expected behavior
No response
Environment & setup
No response

I'm with this bug too 😅.
TypeScript error.


Pages Builder: Allow to work with pages from Template modules.

The same improvement is needed for Module selector in all Studio Builders.


Update phobos-core to 0.17.0

Updates ru.tinkoff:phobos-core from 0.14.1 to 0.17.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ru.tinkoff", artifactId = "phobos-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "ru.tinkoff", artifactId = "phobos-core" }
}]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #146.


Feature - Shipping Addon

Oh... so the package is being brought into core?

Oh... so the package is being brought into core?

Yeah, for 1.x

Oh... so the package is being brought into core?

It's just being added as part of the mono repo, it'll still function as an add-on. So that it's easier to keep track of changes and provide any fixes in one hit rather than being spread out and having to think what might need fixing across repos

Nice

Also, the price field is very wide...

Does the Base Price need to consider currency also?

Can the name and description be translated?

Also, the price field is very wide...

Base price
Can be changed to just "Price" like it is on product pricing?
Min Spend.
Would this be something that admins can choose? Currently, it's on the sub-total since the total will account for shipping costs already applied and could put itself over the threshold.
Currency
Yeah, it should however, nothing in the panel currently handles currencies with pricing and it didn't seem like it should be part of this PR. It would need to be updated when this is done properly.
Pricing
ShippingRates are purchasables so they use the same logic as other purchasables.
Can name/desc be translated?
Are you asking if they are capable of being translated or if they can be made so they can be translated? If the former, then no, just a text column.


Video overlay doesn't work from exe (Trac #65)

The video overlay function works when the program is run through the python interpreter, but not from the pyinstaller generated .exe.
Tested on version v0.1-384-gfcc3177, WinXP and Win7.
Migrated from http://microfluidics.utoronto.ca/ticket/65
{
    "status": "closed",
    "changetime": "2014-04-17T19:39:01",
    "description": "The video overlay function works when the program is run through the python interpreter, but not from the pyinstaller generated .exe.\n\nTested on version v0.1-384-gfcc3177, WinXP and Win7.",
    "reporter": "ryan",
    "cc": "",
    "resolution": "fixed",
    "_ts": "1397763541728826",
    "component": "microdrop",
    "summary": "Video overlay doesn't work from exe",
    "priority": "major",
    "keywords": "",
    "version": "0.1",
    "time": "2012-03-09T14:27:44",
    "milestone": "Microdrop 1.0",
    "owner": "cfobel",
    "type": "defect"
}

Trac update at 20120309T14:31:53: ryan changed status from "new" to "assigned"

Trac update at 20120312T18:22:22:

cfobel commented:

This is fixed by commit 206741e.
It was caused by a PIL import error, in turn causing camera capture to be disabled.

cfobel changed resolution from "" to "fixed"
cfobel changed status from "assigned" to "closed"

Trac update at 20140417T19:39:01: ryan changed component from "gui" to "microdrop"


i can't move in roblox, in any game whatsoever.

i don't know if this is a problem with bloxstrap, or roblox, but i've also tried plugging in another keyboard, switching the build channel, and nothing worked.

Uninstall Bloxstrap and see if the issue persists.

never have gotten this, most likely a roblox fault rather then bloxstrap

i fixed it by doing that
thanks pizzaboxxer because i also thought it was roblox but when i tried everything i came to here lol


Update the bug template

Update the bug template, based on o11y team.

@kimwnasptd This one is still in Draft.

@kimwnasptd I switched this one from draft for review ready. It is good to go. Let me know if there are any reservations. I will merge it before start of next business week.

@i-chvets should now be ready for review


Eval Header

User story
As a site user with any evaluation role, in order to build my trust using challenge.gov site, I would like to see consistent branding and styling from any page of the site.
Acceptance criteria:

[x] Challenge.gov header and main nav are displayed for logged-in users using Eval capability
[x] When the user is logged-in, Logout button is displayed (instead of Login), #24

Definition of Done
Doing (dev team)

[x] Code complete
[x] Code is organized appropriately
[x] Any known trade offs are documented in the associated GH issue
[x] Code is documented, modules, shared functions, etc.
[x] Automated testing has been added or updated in response to changes in this PR
[x] The feature is smoke tested to confirm it meets requirements
[x] Database changes have been peer reviewed for index changes and performance bottlenecks
[x] PR that changes or adds UI

[x] include a screenshot of the WAVE report for the altered pages
[x] Confirm changes were validated for mobile responsiveness

[x] PR approved / Peer reviewed
[x] Security scans passed
[x] Automate accessibility tests passed
[x] Build process and deployment is automated and repeatable
[x] Feature toggles if appropriate
[x] Deploy to staging
[x] Move card to testing column in the board

Staging

[x] Accessibility tested (Marni)

[x]  Keyboard navigation
[x]  Focus confirmed
[x] Color contrast compliance
[x] Screen reader testing

[ ] Usability testing: mobile and desktop (Tracy or Marni)
[ ] Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)

[ ] Windows/Chrome
[ ] Windows/Edge
[ ] Mac/Chrome
[ ] Mac/Safari
[ ] iOS/Safari

[ ] AC review (Renata)
[ ] Deploy to production (production-like environment for eval capability) (dev team)
[ ] Move to production column in the board

Production

[ ] User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
[ ] PO / PM approved (Jarah or Renata)
[ ] AC is met and it works as expected (Jarah or Renata)
[ ] Move to done column in the board (Jarah or Renata)

Figma link: https://www.figma.com/design/VfdBFG8ShVnOStdSNYy9fR/Challenge.Gov-Component-Library?node-id=323-6373&t=23ggyjqm8eBwgZ81-1

Accessibility issue: Fail for Success Criteria 1.4.4
https://www.w3.org/WAI/WCAG21/Understanding/resize-text.html
When user zooms to 200% the Login button disappears. This is a fail. The button needs to remain or the menu convert to hamburger/mobile menu.

@stonefilipczak I just retested this on https://challenge-dev.app.cloud.gov/ and it works now that the menu is added.
@stepchud I believe you can close this card now.

A11y testing complete


Add saved_model support for tensorflow model

Currently MLeap Tensorflow Bundle use frozen graph as model format.
But frozen graph do not support ResourceVariable which is the default variable create by tf.keras.layers.Embedding
And starting from tensorflow 2.0 saved_model format become the official tensorflow serialization format for both keras model and tensorflow model.
It's will be great to add saved_model as a addition bundle format inside tensorflow bundle.
This PR is inspired by https://github.com/spotify/zoltar/blob/b2c4c86f06c043aae505c533467e8a42d12da2d8/zoltar-tensorflow/src/main/java/com/spotify/zoltar/tf/TensorFlowModel.java
And to keep the interface as same as graph mode, we keep using the old session.run() API instead of ConcreteFunction API
This change is backward compatible

@ancasarb @jsleight @voganrc
As described, add saved_model support for tensorflow.
Feel free to review it when you  have time.

looks good overall, one change is needed (i think) to make this backward compatible.

@ancasarb Since the None is cover the old format, It's OK to merge it?

looks good overall, one change is needed (i think) to make this backward compatible.

@ancasarb Since the None is cover the old format, It's OK to merge it?

@austinzh yes, sorry, I missed the None part initially, Ryan pointed it out earlier too.


[ADAP-16]: Test conversion for simple snapshot into a functional test

resolves #

Description
converting simple snapshot into a functional test after simplifying the adapter tests in core
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

do you need to change the dbt-core pointer in dev_requirements to test this?

There were core changes needed to get these to pass. https://github.com/dbt-labs/dbt-core/pull/7296.
Tests are passing, but I'm going to make sure the core changes are good across all adapters prior to merging.


💡[FEATURE]: Add a preloader in website

Is your feature request related to a problem? Please describe.
I want to add a preloader to give an enhanced look when loading the home page
Describe the solution you'd like
I would like to add this
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@komal-agarwal5  where do you want to add the preloader?

@komal-agarwal5 where do you want to add the preloader?

I was thinking to add when home page is loaded
Any other suggestion if you have you can give,will do like that only then

@komal-agarwal5 but there is no delay in loading of the home page. I think its not necessary.

@Abidsyed25 Ok do let me know if you want it for any other page ,I will be happy to do it


Removed firebase Chatapp due to authentication error

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
2, because the PR involves a significant amount of deletions across multiple files related to a specific feature (Firebase chat application). The changes are straightforward as they involve removing entire files and references, which simplifies the review process. However, ensuring that no essential parts of the application are affected indirectly by these deletions requires some attention.

 🧪 Relevant tests
No

 🔍 Possible issues
Possible Bug: Removing the Firebase chat feature might leave orphaned dependencies or configurations which could lead to runtime errors if not properly cleaned up.

 🔒 Security concerns
No

 Code feedback:
relevant fileClient/Client/src/Routes/Routes.jsx
suggestion

Ensure that removing the route '/homechat' does not affect other parts of the application that might be expecting this route to exist. Consider implementing a redirect or a placeholder page if the route is accessed. [important]

relevant line-        } />
relevant fileClient/Client/src/main.jsx
suggestion

After removing AuthContextProvider and ChatContextProvider, ensure that there are no remaining imports or usage of these contexts elsewhere in your application to avoid runtime errors. [important]

relevant line-import AuthContextProvider from './components/Context/AuthContext.jsx';
relevant fileClient/Client/firebase.jsx
suggestion

Since all Firebase related components and contexts are removed, ensure that the Firebase initialization and its configurations are also cleaned up if they are no longer needed elsewhere in the application. This might involve removing Firebase SDK imports and usage in other parts of the application. [important]

relevant line-import { initializeApp } from 'firebase/app'
relevant fileClient/Client/src/components/LandingPage.jsx
suggestion

Verify that the removal of the 'Home Chat' link does not impact the user navigation experience. Consider updating the navigation structure if necessary to maintain a smooth user flow. [medium]

relevant line-            Home Chat

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


Fixed #26424 -- Allowed bypassing schema validation of URLValidator.

https://code.djangoproject.com/ticket/26424

Please rebase your branch so that the unrelated commits don't appear.

Please squash commits and use the commit message from the PR title. Also uncheck "Patch needs improvement" on the ticket so that it appears in the review queue.

buildbot, add to whitelist.

Please include a mention in the 1.10 release notes.

This looks mostly good but can you replace remove the unrelated whitespace changes?

Hi Tim, I did not make any whitespace changes (just did a rebase from master). Can you tell me which part?

Click on the "Files changed" tab of this PR and you should see them.

I made some edits you can apply from this diff: http://dpaste.com/2SDVK38
However, I noticed that the RFC says schemes should also accept dashes and periods so I think you need to make that improvement as well.

Hey @timgraham anything pending on this one?

Don't forget to uncheck "Patch needs improvement" on the ticket so it returns to the review queue. Anyway, I've been busy getting 1.10 alpha out the door and haven't had a lot of review time this week. Will get to it in due time.

I wrote a test script and there are still some valid schemes from the IANA list such as ms-transit-to that aren't passing the current regex.
Also the patch needs to be targeted for 1.11 now.

Closing due to inactivity. Please send a new PR if you update it.


No tests found when gradle cache entry is used

We are using gradle as a build tool. For our CI Setup we use GitHub actions and that includes this one, which generally we like.
Unfortunately now we ran into the issue for the first time, that the action reported a failure because there were no tests found. I like that feature, because it actually prevented me disabling all test by accident once. But in this case we used a gradle cache and so we expected that there might not be any tests.
Any idea how we can accommodate that without disabling the check of missing tests?

Do you know how can gradle "publish" the information that you're using cache for tests (whatever that means, I don't have experience in that regard) so that the action can use it to disable no-tests check?

Many thanks for your quick reply and sorry for the late answer.
I cannot reproduce the error anymore, so I would close the issue for now and would create one with more information once that happens again


Lift limitations in on-window-detected.run

The limitations are:

'layout floating', 'layout tiling' and 'mode-node-to-workspace' are the only commands that are supported in 'on-window-detected'
'move-node-to-workspace' must be the latest instruction in the callback (otherwise it's error-prone)
'move-node-to-workspace' can be mentioned only once in 'run' callback

I would like to use resize width 250 to be able to force some layout. I'm using it to have terminal on the left and small iOS simulator on the right side. Probably move-through left would be useful as well.

Being able to use the resize command inside on-window-detected would be useful. In my case, I'd like the mobile emulators to start with a smaller width.

I'm using sketchybar and would like to only display those workspaces that are non empty + the currently focused one.
So far, there is no robust way to:

Detect a new window being openend, and signal sketchybar that it should recompute which workspaces are active.
Do the same thing when a window is closed, or conversely, when a workspace becomes empty.

I am solving it in a hacky and not foolproof way, basically with a trigger every time I change workspace or whenever an app is moved to another workspace, as well as when the front app changes.
I thought I could do part of it by detecting any new window being opened, but I can't run an execute-and-forget command to signal sketchybar :)

I would like a "do nothing" command that just intercepts the event and stops further events from being called (with check-further-callbacks = false).
My use use case is that I'm often opening up Chrome debug windows, and my current setup has a rule to always send Chrome windows to a certain workspace when they're opened. I would like to setup a rule that just uses the default behavior of opening the dev tools window in the same workspace as the parent window so that I don't have to go looking for it.

@vcooley have you tried this to use empty list run = []?

@nikitabobko I hadn't tried that, but had tried empty string. The empty array did the trick, thanks!

I'm using sketchybar and would like to only display those workspaces that are non empty + the currently focused one.

I am doing the same (or at least I am trying). Do you have a workaround for this. Or is it possible to implement this in AeroSpace? cc @nikitabobko

So far, there is no robust way to:

Detect a new window being openend, and signal sketchybar that it should recompute which workspaces are active.
Do the same thing when a window is closed, or conversely, when a workspace becomes empty.

@dekked @tobiasgiese your use case is better covered by #230 which will be implemented in the next version

@nikitabobko using on-focus-changed in combination with aerospace list-windows --workspace $ws is pretty slow as it uses alot of resources.
My current implementation is:
.aerospace.toml
on-focus-changed = [
    'exec-and-forget sketchybar --trigger aerospace_workspace_change FOCUS_CHANGE=true'
]

my event script:
if [[ "$FOCUS_CHANGE" == "true" ]]; then
    FOCUSED_WORKSPACE="$(aerospace list-workspaces --focused)"
    if [[ "$NAME" = "space.$FOCUSED_WORKSPACE" ]]; then
        rewriteSketchybar "$FOCUSED_WORKSPACE"
    fi
fi

Is it maybe possible to add the focused workspace to every event? This would reduce alot of aerospace queries.
Also the focused monitor would be helpful. WDYT?

It would be useful to be able to set the accordion layout for some of the workspaces, either in a workspace config or in the window detected be able to check if startup and set the right workspace layout

I'd like the ability to set fullscreen for an application. I'm using it as a workaround to the big sur tabs issue in #68.

I'd like to:
[[on-window-detected]]
run = ['join-with right', 'mode main']

So each new window is automatically merged.
Is there another way to do this?

I'd love to
[[on-window-detected]]
if.app-id = 'com.foo.bar'
run = 'layout fullscreen'

so that a particular app is always open in apple fullscreen mode

I'm using sketchybar and would like to only display those workspaces that are non empty + the currently focused one.
So far, there is no robust way to:
* Detect a new window being openend, and signal sketchybar that it should recompute which workspaces are active.

* Do the same thing when a window is closed, or conversely, when a workspace becomes empty.

I am solving it in a hacky and not foolproof way, basically with a trigger every time I change workspace or whenever an app is moved to another workspace, as well as when the front app changes.
I thought I could do part of it by detecting any new window being opened, but I can't run an execute-and-forget command to signal sketchybar :)
I understand the reason not to allow this would be not to execute any command that would create a window and suddenly we have an infinite cascade?

I'm currently using space_windows_change to update my workspaces when windows are created/destroyed, I haven't found a way yet to detect when a window is moved to a different workspace.

@kronolynx I am using a dirty hack like
alt-shift-1 = ['move-node-to-workspace 1', 'exec-and-forget sketchybar --trigger aerospace_workspace_change NEW_WORKSPACE=1' ]

not the best, but it does the job

Can floating windows be configured to always be on top? I don't know if it's more of a OS thing

In a tile layout, I would like my windows to automatically arrange themselves in a tree structure. For example, if I have 2 windows in h_tiles and I add a third one, I want it to be positioned in the bottom right corner of my screen like this:
h_tiles
├── window 1
└── v_tiles
├── window 2
└── window 3
And when a fourth window is opened, it should resize into this layout:
h_tiles
└── v_tiles
├── window 1
└── window 4
└── v_tiles
├── window 2
└── window 3
I tried to achieve this using a bash script triggered by the command:
[[on-window-detected]]
check-further-callbacks = true
run = ['exec-and-forget ~/.scripts/layout.sh']
But I encountered this error:
on-window-detected[0]: For now, 'layout floating', 'layout tiling' and 'move-node-to-workspace' are the only commands that are supported in 'on-window-detected'. Please report your use cases to https://github.com/nikitabobko/AeroSpace/issues/20
If you need help with this issue or want to know how to work around it, let me know!

[[on-window-detected]]
if.window-title-regex-substring = "Alert window"
run = ["layout floating", "move-node-to-monitor 2"]

I want it to appear on second monitor without taking the focus as the window is timed notification that will disappear in x seconds and sometime is not important.

It would be useful to be able to set the accordion layout for some of the workspaces, either in a workspace config or in the window detected be able to check if startup and set the right workspace layout

Same. For some apps, like VS Code, I like using the accordion layout but I can't find a way to do that.

would love it support close action so that it can auto close the non meeting zoom window when Zoom app is opened by a meeting link:
[[on-window-detected]]
if.app-id = 'us.zoom.xos'
if.window-title-regex-substring = 'Zoom Workplace'
run = 'close'

I have a use case where one of my workspaces contains zellij + neovim on the entire screen.
I'd like to unbind most aerospace related keys as this is the only window in the workspace for me,
So doing something like:
[[on-window-detected]]
if.app-id = 'net.kovidgoyal.kitty'
run = ['mode terminal']

[mode.terminal.binding]
alt-h = []
alt-j = []
alt-k = []
alt-l = []
....

Can be very beneficial.

I would like to have the option to set the accordion layout for a specific workspace.
[[on-window-detected]]
if.workspace = 'Z'
check-further-callbacks = true
run = 'layout accordion'

I wanted to not only make it float, but also put it in the center with rectangle's help
[[on-window-detected]]
if.app-id = 'com.google.Chrome'
if.window-title-regex-substring = 'Sign In - Google Accounts'
run = ['layout floating', 'exec-and-forget open -g "rectangle://execute-action?name=center"']

I have some examples of commands that could be run with it:

resize -- to allow set different sizes for windows, this is especially useful for floating windows, either to use custom sizes or create quake mode (e.g. Dropdown terminal).
move -- to place new window on specific position.
position -- (new) sets position for floating windows.
exec-and-forget -- for many custom commands, especially used with the upcoming tree command

Can floating windows be configured to always be on top? I don't know if it's more of a OS thing

I would also love that. Sometimes my floating windows are lost/hidden behind other windows.

It would be useful to be able to set the accordion layout for some of the workspaces, either in a workspace config or in the window detected be able to check if startup and set the right workspace layout

Same for me: ms teams is opening windows in new windows, which is a bit annoying. To solve that I would like to change to accordion layout for this workspace whenever teams is opened:
[[on-window-detected]]
if.app-id = 'com.microsoft.teams2'
run = 'layout accordion'

Just in general: is there a reason why the actions that can be triggered by on-window-detected is so restricted?

Can floating windows be configured to always be on top? I don't know if it's more of a OS thing

I would also love that. Sometimes my floating windows are lost/hidden behind other windows.

@dellacf the focus command allows to focus floating windows too, so you just need some shortcuts for it (defaults to alt-hjkl, I use cmd + arrows).

[[on-window-detected]]
if.window-title-regex-substring = "Alert window"
run = ["layout floating", "move-node-to-monitor 2"]

I want it to appear on second monitor without taking the focus as the window is timed notification that will disappear in x seconds and sometime is not important.

Second this - I use the iTerm as a drop-down terminal and would love it to always be on the main monitor.

@dellacf the focus command allows to focus floating windows too, so you just need some shortcuts for it (defaults to alt-hjkl, I use cmd + arrows).

I know, I just don't like that the floating windows are hidden behind my tilling windows.

I group apps by spaces. For instance, R stands for "reading" and apps like LiquidText, Kindle, Preview go there. I don't normally use those apps side-by-side (i.e., tiling layout), so ideally I'd want them to be fullscreen and the space R to have accordion layout, so I can quickly switch between those apps.

:+1: on the 'resize'-related stuff that adjust layout and positioning.
One particular reason this is necessary is that lots of apps have "naturally small" windows for particular purposes; and sometimes I would like those to be in the tiled grid, but I don't want them zoomed up to taking up ⅓ of the space on a Pro Display XDR.
As a specific (but not the only) example, the Tags window in Things 3 is a separate window instead of a drawer, and I do want it open (and not occluding the main window / 'floating') during normal usage of the app:

However, if I set it to layout tiling, I end up with this ridiculousness every time I open the app:

I'd like to:
[[on-window-detected]]
run = ['join-with right', 'mode main']

So each new window is automatically merged.
Is there another way to do this?

Also extremely interested in this! Seems strange to me to need to manually join to nest windows.

Similar to @qskkk I'd like to implement an auto spiral/dwindle layout and there seems to be a pretty easy way to do this with the on-window-detected callback, but it's missing the ability to run join-with commands and the ability to check the layout of the current node. Something like:
[[on-window-detected]]
if.node.layout = 'horizontal'
run = ['join-with left']

[[on-window-detected]]
if.node.layout = 'vertical'
run = ['join-with up']

Another use:
There's (often?) bugs with some niche applications using application-hiding oddly (https://bluebird.app/), or a fullscreen-mode (many games), where that particular poorly-behaved application ends up leaving a "gap" in a tiled layout. With arbitrary commands, a workaround would be possible - detect the launch of those oddities, and set them to 'floating' mode, so they don't affect the grid.

Hi, would it be possible to add the resize option in the [on-window-detected] ? I would love to use it to set certain apps that are in floating to a certain size on my screen.
A simple option to center elements would also be great. I'm using Hammerspoon right now to re-center all the floating windows at the moment, but it would be much easier if you could add a 'center-window' option, furthermore than the resize option.
Thanks a lot, keep up the great work!

I would like to be able to automatically make secondary windows of a specific app accordion.
For example, if I'm in Firefox and hit cmd+n to open a new window, I'd like it to automatically join the original Firefox window's layout and vertically accordion with it.

Just to add to what's already been mentioned.
Jetbrains IDE's allow you to combine/attach multiple windows into a single window on MacOS. (i.e Open new Project -> Attach Window) They appear as tabs above your editor tabs, which is a very nice feature.
Aerospace interprets these as individual windows and attempts to tile them, which results in large blank spaces where these windows would normally be.  (they remain attached to a single window, but Aerospace will display a blank tile for each additional window)
A great way of handling this is to always join new jetbrains windows, and then put them in an accordion. It's really slick if you set the accordion gap to 0, and you essentially get to ALT-J/K through your open projects.
The only hassle is that you have to micro-manage it. It would be great if we could automatically join up all jetbrains windows and set them to a vertical accordion layout.

I believe that my use cases would be covered by suggestions made already, such as auto-full-screening and perhaps switching to accordion mode. But the use case I have has not been mentioned: running photo and video viewers from a file manager. I'm now using floating layout, but in i3 and sway I used to be able to run full-screen automatically and that was better.


Contributor contextualisation

We want to be able to contextualise the contributor component.
My suggestion to start would be to provide intelligent defaults, with overrides.
Examples
Examples in events
Org

Series

Normal

@Heesoomoon did you say we were going to get some defaults from the content team?


Storage error when installing k3os

I am getting a wrong fs type bad option bad superblock when both PXE booting k3os or when running sudo k3os install.  It appears to be related to this block:
https://github.com/rancher/k3os/blob/df70745790416bb37f6eccb4226647cc634e1041/overlay/libexec/k3os/live#L17-L22
It looks like this line is attempting to mount the disk and not a partition.
lsblk -o NAME,TYPE -n | grep -w disk | awk '{print $1}'
sda

sudo mount /dev/sda /.base
mount: /.base: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.

Am I missing something?

I have seen this a couple times.  The first time is was caused by a bad USB stick.  The second time it happened when /dev/sda wasn't the actual drive in the machine.  I had a newer intel NUC with a nvme drive, the USB stick was /dev/sda and the system drive was /dev/nvme0n1p1, so when the install ran it was trying to overwrite the USB stick.
Long story short.  Make sure /dev/sda is the system drive.  If its not, change the grub.cfg or specify the correct one during k3os install.

Thanks for the reply @joharper54SEG
I tried a couple of different USB drives and had the same problem.  This is a NUC as well (NUC5PPYB).  There isn't much going on here, just a loop device and a USB drive.  I can mount the /dev/sda1 device with no problem and write data to it so it appears the USB device is working ok.

so /dev/sda is definitely your usb drive then.  What is the system drive?  What are you specifying for the install disk after running k3os install?
I had to look through dmesg or pay close attention to boot process to find that crazy /dev/nvme0n1p1 drive on my system.

Here is the relevant stuff from my iPXE config:
set root_dev sda

set k3os_args k3os.mode=install k3os.install.silent k3os.install.device=/dev/${root_dev} k3os.install.iso_url=${iso_loc} k3os.install.config_url=${boot_url}/k3os/config.yml k3os.install.power_off=true k3os.install.debug=true

This fails and reverts to just a live install.
On the live install, when I run sudo k3os install I get mount: /run/k3os/iso: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error. error, the installer downloads some things, and then (previously the install was straight crashing and I would lose video and have to hard reset) I get this output:

try recreating your usb drive with the ISO.  Then do a live install and see if you at least get the installer asking questions.
To me, it still sounds like /dev/sda is your USB disk and not your system drive.  If you attempted to install and set /dev/sda as the install target, then it probably wiped out data on the USB drive before bombing out.

So going old-school the install is at least working:
* Burn k3os to USB using Etcher
* Insert two USB drives into NUC
* Boot off bootable k3os drive
* Install k3os to other USB drive using wizard
* Remove bootable install drive
* K3os starts booting but fails with `echo '[FATAL]' Failed to determine boot mode

I ran iPXE with basically the same config and had the same issue:
set k3os_args k3os.mode=install k3os.install.debug=true

Does your NUC not have an internal sata disk attached?  I would imagine the steps would look like this.

Burn k3os to USB using Etcher
Boot off bootable k3os drive
Install k3os to internal sata drive using wizard
Remove bootable install drive

Not at the moment.  Initially, I wanted to run a k3os cluster all in-mem but it doesn't look like there is currently a way to apply a config.yaml to a pxe-booted live install.  I had a few USB drives sitting around (and this NUC has USB 3.0 ports) so I figured I would install to a USB drive and boot from that (currently what I'm trying to do).

Ah ok.  I have never tried running from RAM or USB drive.  You are in new territory!

Seems like it.  A USB device shouldn't be any different than any other block device (like a sata disk) but I have no idea what's going on at this point.  Thanks for your time...definitely appreciate it!

Whats happens when you try something like this for your PXE settings?
set k3os_args k3os.mode=live k3os.install.config_url=${boot_url}/k3os/config.yml

That was actually the first config I was working on.  It just PXE boots into live mode (it doesn't pull the config.yml).  Looks like live mode is literally either a single instance or just an installer environment.  I was going to create an issue on that as well because that would be an awesome feature.
Someone else had the same issue, waiting to hear back if they found a workaround.

This resembles a problem I'm seeing reported earliest at #376: I'll post my assessment of the issue there.


Bug in the generated C# code when building final model - vector of structs

For the following schema:
domain TestDomain

package TestClient

version 1.0

struct Field1
{
   uint64 Whatever;
}

message Field2
{
    Field1[] ListOfWhatever;
}

The generated C# code presents errors when building with --final flag.
In the public long Get(out HashSet<T> values) method of the following classes:

FinalModelVectorValueType
FinalModelVectorReferenceType
FinalModelVectorOptionalReferenceType
FinalModelVectorOptionalValueType

For this this line of code
values = new HashSet<T>((int)fbeVectorSize);
The error says:
Error CS1503 Argument 1: cannot convert from 'int' to 'System.Collections.Generic.IEnumerable<T>'
The generic constructor of HashSet doesn't expect a capacity parameter. Leaving the call parameterless solves the issue:
values = new HashSet<T>();
I'm using the latest version of the package.

https://learn.microsoft.com/en-us/dotnet/api/system.collections.generic.hashset-1.-ctor?view=net-8.0#system-collections-generic-hashset-1-ctor(system-int32)
// Initializes a new instance of the HashSet<T> class that is empty,
// but has reserved space for capacity items and uses the default
// equality comparer for the set type.
public HashSet (int capacity);

Sure thing, I was targeting .NET Standard 2.0. Problem goes away in .NET Standard 2.1.
Thank you


chore(build): copy source for sourcemaps

copy TS source to amd/cjs/ES6 distros
use sourceRoot option to make sourcemaps point to appropriate paths

closes #1089

@robwormald it looks like there's a minor hiccup with this:
ENOENT: no such file or directory, open 'dist/cjs/add/observable/src/add/observable/bindCallback.ts'
I think it's just because something is trying to reference a file that was recently removed from the library. Also, can you rebase?

I think it's just because something is trying to reference a file that was recently removed from the library.

I'm conflating util/bindCallback.ts and observable/bindCallback.ts. So something screwy is going on here.

@robwormald just waiting for a rebase on this.

:+1:

@robwormald btw I fixed the merge commits in https://github.com/trxcllnt/RxJS/tree/pr-1093 but github is complaining about unresolvable merge conflicts when I try to issue a PR to your branch... so if you just want to copy the package.json from my branch and git push -f your branch then we can close this out.

closing this so Ben stops abusing me on twitter (also cuz its a bit wrong, but that's secondary). will re-open after discussion.


[Thinkit] Use int64_t for packets_num in SflowResult. collect proc/bcm/knet-cb/psample/map data during setup and teardown. Use state/actual-ingress-sample-rate to read the sample rate for backoff test.

Key_word Check:
~/pins_upstream/sonic-buildimage/src/sonic-p4rt/sonic-pins/tests/sflow$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 638 targets (0 packages loaded, 0 targets configured).
INFO: Found 638 targets...
INFO: Elapsed time: 0.533s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Test result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 638 targets (0 packages loaded, 0 targets configured).
INFO: Found 426 targets and 212 test targets...
INFO: Elapsed time: 161.150s, Critical Path: 115.30s
INFO: 266 processes: 321 linux-sandbox, 18 local.
INFO: Build completed successfully, 266 total actions
//dvaas:port_id_map_test                                                 PASSED in 1.5s
//dvaas:test_run_validation_golden_test                                  PASSED in 0.1s
//dvaas:test_run_validation_test                                         PASSED in 1.0s
//dvaas:test_run_validation_test_runner                                  PASSED in 0.1s
//dvaas:test_vector_stats_diff_test                                      PASSED in 0.1s
//dvaas:test_vector_stats_test                                           PASSED in 0.1s
//thinkit:mock_control_device_test                                       PASSED in 1.0s
//thinkit:mock_generic_testbed_test                                      PASSED in 1.4s
//thinkit:mock_mirror_testbed_test                                       PASSED in 1.2s
//thinkit:mock_ssh_client_test                                           PASSED in 0.2s
//thinkit:mock_switch_test                                               PASSED in 1.6s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 1.3s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 1.6s
  Stats over 5 runs: max = 1.6s, min = 1.1s, avg = 1.3s, dev = 0.2s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 43.6s
  Stats over 50 runs: max = 43.6s, min = 0.9s, avg = 3.3s, dev = 8.2s

Executed 212 out of 212 tests: 212 tests pass.


Firefox v103.0.1+ does not show popup screen during authentication

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
^2.22.0
Wrapper Library
Not Applicable
Wrapper Library Version
N/A
Public or Confidential Client?
Public
Description
The Microsoft Graph Toolkit uses the msal-browser package in their Teams Provider for authentication. There are issues where the pop up doesn't show in the latest versions of Firefox. This is because Firefox has implemented a Total Cookie Protection policy which prevents cross-site sharing of cookies, in this case the clientId in the browser.
Error Message
No response
Msal Logs
No response
MSAL Configuration
N/A

Relevant Code Snippets
N/A

Reproduction Steps
This issue https://github.com/microsoftgraph/microsoft-graph-toolkit/issues/1866 contains all the reproduced steps.
Expected Behavior
The authentication popup should appear in the latest Firefox browser.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Firefox
Regression
No response
Source
Internal (Microsoft)

CC @EmLauber. Can we confirm if firefox supports AAD logins in total cookie protection mode?

We are still investigating this.

@EmLauber assigning to you just for traction, please pull me in as needed.


Fixing incorrect width

Hey @robdmoore, what's with all the changes to the yarn.lock file?
The actual changes don't seem to require updating dependencies.

@robdmoore does this fix include the Managed Services template?

Should do.
--
From: Tien Phan<EMAIL_ADDRESS>Sent: Wednesday, 25 September 2019 1:41 PM
To: Readify/telstra-purple-signatures<EMAIL_ADDRESS>Cc: Rob Moore<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Readify/telstra-purple-signatures] Fixing incorrect width (#33)
@robdmoorehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobdmoore&data=02|01|rob.moore%40readify.net|baa8b1c8876e4e9b18df08d7417ae978|413504eb862247d2aa72ddbba4584471|0|0|637049868476140242&sdata=E2PjfS2fvPpoCSZ3Vq6gHFpi7tZp0LrVTXwe7xuDxNo%3D&reserved=0 does this fix include the Managed Services template?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FReadify%2Ftelstra-purple-signatures%2Fpull%2F33%3Femail_source%3Dnotifications%26email_token%3DAAEMCX7AZHLAYD2XPAK6AFTQLL2VXA5CNFSM4I2HZSZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QVOUI%23issuecomment-534861649&data=02|01|rob.moore%40readify.net|baa8b1c8876e4e9b18df08d7417ae978|413504eb862247d2aa72ddbba4584471|0|0|637049868476150232&sdata=wmgTzAKGsL%2FxsiVtd%2FBbpt%2FAY3iSuTtLR5TCKO2pd5U%3D&reserved=0, or mute the threadhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEMCX7FZSJLNFWPZZ7CJBLQLL2VXANCNFSM4I2HZSZA&data=02|01|rob.moore%40readify.net|baa8b1c8876e4e9b18df08d7417ae978|413504eb862247d2aa72ddbba4584471|0|0|637049868476150232&sdata=1DLwxHWtz676CDwG48F9mKCG%2BQkRgs44JInu%2FGvhQWM%3D&reserved=0.

Yeah that was weird. I just ran yarn and it did that, someone mustn’t have run yarn before?
--
From: Mickaël Derriey<EMAIL_ADDRESS>Sent: Wednesday, 25 September 2019 1:26 PM
To: Readify/telstra-purple-signatures<EMAIL_ADDRESS>Cc: Rob Moore<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Readify/telstra-purple-signatures] Fixing incorrect width (#33)
Hey @robdmoorehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobdmoore&data=02|01|rob.moore%40readify.net|94753361843d4f706e8508d74178d6c4|413504eb862247d2aa72ddbba4584471|0|0|637049859580544788&sdata=69ISRFjBQE6zj%2BpaiY76BhN7MH1q94DKmzau6E%2Foe%2BA%3D&reserved=0, what's with all the changes to the yarn.lock file?
The actual changes don't seem to require updating dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FReadify%2Ftelstra-purple-signatures%2Fpull%2F33%3Femail_source%3Dnotifications%26email_token%3DAAEMCX7JMAGUKM74Q5F7A2TQLLY6BA5CNFSM4I2HZSZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QUTJI%23issuecomment-534858149&data=02|01|rob.moore%40readify.net|94753361843d4f706e8508d74178d6c4|413504eb862247d2aa72ddbba4584471|0|0|637049859580544788&sdata=b%2FHhIuX%2B0bf3NqtzY2fqqjJVRYa%2Fs7doGkP7dKQEsEY%3D&reserved=0, or mute the threadhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEMCX2FO4KDDB3NLE6SBATQLLY6BANCNFSM4I2HZSZA&data=02|01|rob.moore%40readify.net|94753361843d4f706e8508d74178d6c4|413504eb862247d2aa72ddbba4584471|0|0|637049859580554784&sdata=UQWvPQVrNzMoKwRYnhTqcOrvH2z%2F41RS02OsXCnVNus%3D&reserved=0.

yolo!


run link check weekly at saturday midnight

Run link (Pull Request) check weekly on Saturday midnight to improve QA.
See #1072.

@mashb1t I think it will send us a mail if it's failing. Have something similar in one of my checks.


Support configuration of max_concurrent_streams

server::Builder should support set_max_concurrent_streams(&mut self, u32) so that a server can constrain the number of streams per client.
Similarly, client::Builder should have this, though I think a client can only configure the number of concurrent server-initiated streams (i.e. Push Promises).  While we're here, client::Builder should probalby also have a set_push_promise_enabled(&mut self, bool)

While we're here, client::Builder should probably also have a set_push_promise_enabled(&mut self, bool)

There's builder.enable_push(bool): https://github.com/carllerche/h2/blob/6ec7f38cd7378a6d99ab4300a07763ab1722dcb4/src/client.rs#L181

Looks good to me.

Started (9a4204b379a3ef7d9d9c4fec0eb238d85411c771), working on tests.


Emmet - capital letter

VSCode Version: 1.15.1
OS Version: win7x64

Every time you write any word starting with capital letter - Emmet pitches in process and suggests you it's abbreviation. So, if you wanna write "Some (Enter) Text (Enter)" - it's gonna be two tags, not words.
GIF:

@user3323 I am not able to repro using VS Code 1.15.1 I tried in Mac and Windows 10
Can you share your settings?
Can you also run code --disable-extensions and see if you can repro in the absence of other extensions?

@ramya-rao-a, hello. I found the reason. It's all about the setting called "emmet.syntaxProfiles", in particular in values of "tag_case" property of "html" group.
In the GIF above, the setting configuration was:
"emmet.syntaxProfiles": {
  "html": {
    "tag_case": "lower"
  }
}

Very strange behavior. This setting has to be responsible for absolutely another thing. So, when it's set to "lower" it will suggest you to expand snippet after any word started from capital letter. And when it's set to "upper" - it will suggest after any word started from lower case letter. And the only value "asis" - doesn't cause any problems.
Here is another GIF, that shows everything:

PS: also by testing this "tag_case" setting and trying to expand simple "div", I found that not all three values of this setting actually work, as they should. Gonna make a new issue.

Got it, found the issue. Will push the fix tomorrow and the Insiders for 25th Aug will have the fix.
Thanks for reporting!

Fixed with https://github.com/Microsoft/vscode-emmet-helper/commit/1359d5d4d7f14c47821074cc0d9b0eb0d15afb7b
Please try out our Insiders build tomorrow and it will have the fix


Option to ignore Do-Not-Track and/or to track anonymous data

Hi,
This plugin looks very nice. One thing that I don't like, however, is that it forces plugin users to honor Do-Not-Track (DNT).
I believe website owners have the right to ask visitors for consent to track them, and that such an explicit consent overrules any DNT setting. Currently, this plugin doesn't allow users to do this, however.
Even if you are not willing to give plugin users the choice whether they honor DNT or not – at least there should be an option to collect anonymous data (I'm new to Matomo, but it seems, it is possible to collect anonymous data).
Anonymous data are no personal or personally identifiable information, so they don't fall under any privacy law (as far as I know).

@d4h0 Feel free to test #129 which is temp. published at @revathskumar/gatsby-plugin-matomo.
Let me know if there is any issues.

@revathskumar: Looks great, thank you.


Cannot install dependencies

Detailed description of the problem
Hi,
I tried it various times on debian nad ubuntu, but I am not able to install the php dependencies which are required for lychee to operate. Someo f them cannot be found in the official repos, and also not if I use external repositories.
Some of the PHP extension are included in other packages, some are renamed. Please solve the confusion so I can make use of lychee.
Steps to help with the issue
Create a detailled manual how to install lychee and dependencies
Update the same documentation to make use of PHP7.X (latest)

I'm not sure what is the minimum for Lychee, but I would think that something similar from your disto's
selection would apply.
 The repository of Lychee will stay available, but the main development continues under the Lychee Organisation. A fork maintained by the community. Important issues have been migrated. Feel free to re-add your issue(s) when necessary.


RealPnL

Enhance the core functionalities of naive_pnl to calculate more realistic strategy PnLs by considering realistic position rebalancing, trading costs and risk management.

moved to Issue #895 , PR #927


Improve Background to Trace and Gridline Contrast by default

Most noticeably with dark mode and dark blue or purple traces,
they are especially difficult to tell apart from the background with dark and/or low contrast screens.
The default colors for traces could be changed to either:

change depending on the brightness mode,
or changed so that the varieties of trace colors available contrast better with a background

With regards to gridlines, most notably the minor gridlines are difficult to see especially on dark mode.

REW doesn't seem to have this issue as an example.

 the filter type and equalizer name text is also unreadable.


Unexpected error

superset Version: 2.0.1

[object Object]

Hello @nimei66 we are not supporting this version of Superset at this time. If you are still experiencing this problem in one of the most recent versions of Superset (3.x and above), please feel free to open another issue. Thank you!


How do I push a page with Super Tabs with a preselected tab index?

Hi,
How can I open up a page that has super tabs in it with a predetermined tab index?
For example, I want to open a page with the 3rd tab already selected
Is this possible?

<super-tabs height="100%" selectedTabIndex="1" indicatorColor="dark" >   <super-tab [root]="tab1Root" id="ShopNav"></super-tab>   <super-tab [root]="tab2Root" id="HomeNav"></super-tab>   <super-tab [root]="tab3Root" id="InveNav"></super-tab> </super-tabs>


Make entityTypes optional

Should entityTypes should be optional for very basic usage?

Not familiar enough with the API to say :)  Before/after example?

export const pokemonApi = createApi({
  reducerPath: 'pokemonApi',
  baseQuery: fetchBaseQuery({ baseUrl: 'https://pokeapi.co/api/v2/' }),
  entityTypes: [],
  endpoints: (builder) => ({
    getPokemonByName: builder.query({
      query: (name: string) => `pokemon/${name}`,
    }),
  }),
});

vs
export const pokemonApi = createApi({
  reducerPath: 'pokemonApi',
  baseQuery: fetchBaseQuery({ baseUrl: 'https://pokeapi.co/api/v2/' }),
  endpoints: (builder) => ({
    getPokemonByName: builder.query({
      query: (name: string) => `pokemon/${name}`,
    }),
  }),
});
```

It's not required to specify `entityTypes` unless you're interested in invalidation, which some folks may not be. They might just want the convenience of `const { data, status } = hooks.getThing.useQuery()`

sure. like I've said, my main goal here is to make as much of this stuff optional / inferred defaults as possible. anything we can do to cut down the lines of code you have to write, the better.


fix: add Abhishek Kushwaha

Changes proposed

Added my own developer profile on LinkFree

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Done with requested Changes 😁

LGTM!

I didn't get it ?
LGTM means?

Looks Good To Me

Could you resolve the linting errors? -
public/data/Abbhiishek.json
Error:   24:49  error  Trailing comma  json/*
Error:   31:72  error  Trailing comma  json/*
Error:   38:46  error  Trailing comma  json/*
Error:   45:44  error  Trailing comma  json/*


[New-Command] Request: Move-DbaDatabaseFile

Is this:

[x] feature
[ ] bug:

System Details

Operating system name and version: Windows Server 2012 R2
Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.14409.1005
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1005
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

SQL Server version for source/target: 2012, 2014, 2016

Can a cmdlet be created that will take standard arguments that must include:
SqlServer/Instance
DestinationDataFilePath
DestinationLogFilePath
Request based on the in-place upgrade process. If SQL installed using standard paths, upon upgrade (ex. 2014 to 2016) user databases will remain in Drive:\Program Files\Microsoft SQL Server\MSSQL12.INSTANCENAME\MSSQL\Data.
IF upgrading with standard paths, the desired action would be to detach and reattach data files after moving to version specific directory, in this example Drive:\Program Files\Microsoft SQL Server\MSSQL13.INSTANCENAME\MSSQL\Data but MSFT leaves the files in the original version directory.
Example call to this new cmdlet would be:
Move-DbaDatabaseFiles -Instance 'localhost\InstanceName' `
-Database 'myDbName' `
-DestinationDataFilePath 'MDFDrive:\Program Files\Path\To\My DB Root\Data' `
-Destination 'LDFDrive:\Program Files\Path\To\My DB Root\Data'

Retrieve current path using Get-DbaDatabaseFile and retrieve physical path of mdf and ldf files
Move or Copy mdf files from ($DBFileObj | ?{$_.TypeDescription -eq 'ROWS'}).PhysicalPath to $DestinationDataFilePath\$($DBFileObj.LogicalName).mdf
Move or Copy ldf files from ($DBFileObj | ?{$_.TypeDescription -eq 'LOG'}).PhysicalPath to $DestinationDataFilePath\$($DBFileObj.LogicalName).ldf
Offline/Single User mode the Database
Detach database/db files from SQL Instance
Attach database/db files to SQL instance using new path
Upon success dbcc, delete original files $DBFileObj | %{ Remove-Item -Force -Path $_.PhysicalPath}

You would have to exclude AG databases from this command as those require special methods that involve all replicas. Moving a file on a secondary replica can be done but it will suspend data movement until the AG is failed over to that replica.
If you are doing this AFTER the in-place upgrade is completed you don't have to detach/attach the database. This would work as well:

Retrieve paths of database files
Update paths to new directory
Take database offline (you can't use single user mode)
Copy files to new directory
Bring database online
Confirm path of database files
Drop files from the old directory.

[You do have to take the database offline, setting it to single user mode would still mean the database is being accessed so the files would be locked.]

I have had several requests for this command this week at SQL Bits and also requests for Move-DbaSystemDatabaseFile as well so I am bumping up this one


config tests

Codecov Report

Merging #42 into master will increase coverage by 5.21%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f52ad...353bf64. Read the comment docs.


Improve JUWELS jobqueue config for safe operation on the diskless nodes

For example, the memory request is very "optimistic". Here, rather choose the reported "available" value:
$ srun --account=??? --time=00:05:00 --partition=??? free -h
srun: job 2730378 queued and waiting for resources
srun: job 2730378 has been allocated resources
              total        used        free      shared  buff/cache   available
Mem:           92Gi       5.9Gi        83Gi       2.7Gi       3.1Gi        83Gi
Swap:            0B          0B          0B

Also, with the current way of importing the Dask jobqueue configuration there is no way of e.g. injecting Dask distributed options via configuration files, e.g. disabling worker disk spilling. This would be important for a smooth operation of Dask jobqueue workers on the diskless nodes, though.

And/or set local_directory to $SCRATCH.


Temporal Coverage Styling looks wrong - Discover feature parity

The Start and End date boxes inside the Temporal Coverage Filter don't fill the width of their parent element. This looks makes the styling look inconsistent with the rest of the page. To fix this, expand the start and end date boxes to fill the width of the Temporal Coverage Filter.
As currently implemented:

Recommended styling:

This has a solution and has been submitted to @ndebuhr @martinseul last week for evaluation. Once a response is received, we will know if this  will be released as a part of Feature Parity + or later.

This is a known issue. This will be resolved and undergo extensive testing after Feature Parity+ Oct 21 release.

Issue resolved as a part of the Discover redesign


Allow caches to be removed via a Workflow

One thing I really feel is missing on this action is to allow to cleanup of cache keys. For example, when I close a PR, I want all the caches from that ref to get removed.
Right now either I need to make cURL requests or the new UI feature to delete one per one. On repositories that have a massive amount of runs (such as https://github.com/nodejs/nodejs.dev), this becomes a little bit unmaintainable...

An alternative to manual HTTP requests is the gh-actions-cache extension for the gh CLI, e.g. from bash
gh extension install actions/gh-actions-cache
gh actions-cache list | tail -n +5 | cut -f1 | xargs -I@ gh actions-cache delete @ --confirm

Thanks @w-bonelli for suggesting the gh CLI approach.
Hi @ovflowd, we have added some guidance in our tips-and-workarounds docs. It provides a sample workflow that you can introduce to remove caches for PRs. It uses the same gh CLI and the logic is similar to the one mentioned by @w-bonelli.
You can use this workflow as an alternate to making cURL requests or using the gh CLI directly.


cmd/doc, go/doc: update for generics

Belated tracking issue: go/doc and cmd/doc needs to be updated for generics.  @jba and I have an in-progress CL to do this.

Closing this release blocker, since we should now support generic code in go/doc and cmd/doc. But historically go/doc changes have been subtle. @jba will be updating pkgsite, which contains a fork, and may file additional issues as needed.


Implement humanizeCustom and toHumanized helper functions

This pull request builds on the implementation of humanizeCustom in my previous pull request.

LGTM 👍

Thanks @rcook


--custom-command  and IGREP_CUSTOM_EDITOR not working

I am on Arch Linux, I tried using both --custom-command  and IGREP_CUSTOM_EDITOR but neither seem to be working. I use fish as my shell and wezterm as my terminal.
When I try the environment variable, ig ignores it completely. When I try --custom-command, I just get the following error.
.
Let me know if there is any more information I can provide.

--custom-command will be available in the next version, which I am going to release soon. Sorry for the confusion, I need to be more precise in README in the future.


Add isKnowType property to type parameters

A function with an input map Map<K, V> signature right now, were K is a a type variable allow K to be bound to unknown.
this task is to create a property isKnowType that can be assigned to to type variables to make them more precise and complete.

CC: @majetideepak @aditi-pandit @karteekmurthys