Winget shows wrong package id for Java 8

Brief description of your issue
winget id for java 8 changes after installation causing issues with uninstall as id then changes.
Steps to reproduce
when running winget search "java 8" I get the below results
Name   Id                            Version    Source
Java 8 Oracle.JavaRuntimeEnvironment 8.0.4210.9 winget
when attempting to uninstall using the above id it wont remove this is because the id is changing upon install
so if i run winget list
it outputs the result like this
Name                                              Id
Java 8 Update 421 (64-bit)             ARP\Machine\X64{77924AE4-039E-4CA4-87… 8.0.4210.9
Because of this I am unable to automate its uninstall via Intune which this did work previously as the id did not change,
Expected behavior
expected behavior is to output the same ID after installation so it can used as an identifier for uninstall
Actual behavior
the uninstall command fails and i have to manually look up the application, but this is not feasible in an environment with over 2000 laptops.
Environment
Windows Package Manager v1.8.1911
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.4037
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

@Trenly or @mdanish-kh do you think this is this a manifest issue, an installer issue or a WinGet issue?

@Maccamh Can you share the full output of winget list java?

the uninstall command fails and i have to manually look up the application

As a workaround, you can use a command like winget uninstall --name "Java 8 Update 421 (64-bit)", but I understand if all machines have a different java version, then this command may not be applicable

@ Trenly or @ mdanish-kh do you think this is this a manifest issue, an installer issue or a WinGet issue?

I couldn't repro the issue on my VM. Looks to me that the installed package for user isn't getting correlated back to a source, hence the ARP/Machine/... package id being displayed.

Hi,
I'm out of the office til Tuesday but I'll test soon as I get in
On Sat, 31 Aug 2024, 09:47 Muhammad Danish, @.***>
wrote:

@ Trenly or @ mdanish-kh do you think this is this a manifest issue, an
installer issue or a WinGet issue?
I couldn't repro the issue on my VM. Looks to me that the installed
package for user isn't getting correlated back to a source, hence the
ARP/Machine/... package id being displayed.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/winget-cli/issues/4776#issuecomment-2322831707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7YCX7WJGCKP4V2ZWDHJVTZUF7IVAVCNFSM6AAAAABNL5TL7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHAZTCNZQG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have attached the output log
WinGet-2024-09-03-14-06-13.810.log

Looks like some manifest fields had incorrect values, which would definitely have an effect on correlation and the issue you're seeing. @ItzLevvie pushed PRs to update these. Once those have been published (within an hour or so), I'll drop a comment and ask you to try again

@Maccamh All PRs should now be published. Can you check again if you're still able to repro the issue?

Hi Mdanish-kh,
That's now resolved the issue. Thanks for the quick support on this!

Credit to @ItzLevvie for the PRs
Close with reason: Resolved;


better handling of versions

work across commit titles, make auto generate?

remove changelog and use github auto-releases for it?


Migrate 'Supported Platforms' to AsciiDoc

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
The content of the Adoptium 'Supported Platforms' page should be migrated to AsciiDoc.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Hey, there I will love to work on this issue.


Villagers do not allways have their permanent trades available

As per title, using a permanent villager trade makes them randomly pick a new trade, this is not always the permanent trade one

They also show a + sign indicating that they give villager experience while they do not contribute to that

Fixed mandatory trades not refreshing. Opening the GUI issue as a new ticket.

New Ticket created as #361


compile error solved with QT_SELECT=5

Building the create qt_core on a Neon docker image (kdeneon/plasma:dev-stable) gives this compile error:
error: failed to run custom build command for `qt_core v0.2.2`
process didn't exit successfully: `/home/neon/q/target/debug/build/qt_core-714aeaf1eb8ac892/build-script-build` (exit code: 101)
--- stderr
Executing command: "qmake" "-query" "QT_VERSION"
Stdout:
Stderr:
qmake: could not exec '/usr/lib/x86_64-linux-gnu/qt4/bin/qmake': No such file or directory
Error:
   0: command failed with exit code: 1: "qmake" "-query" "QT_VERSION"
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Msg("command failed with exit code: 1: \"qmake\" \"-query\" \"QT_VERSION\""), (None, None))', src/libcore/result.rs:837
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Cargo picks up qt4 instead of 5. This can be avoided by setting the environment variable QT_SELECT=5:
$ QT_SELECT=5 cargo build
   Compiling qt_core v0.2.2
   Compiling q v0.1.0 (file:///home/neon/q)
    Finished debug [unoptimized + debuginfo] target(s) in 177.57 secs

I propose that the qt executables are called with that environment variable set.
See also qtchooser.

It's up to the user to make the proper qmake executable available in the environment before building Qt. There are many platform-dependent ways to do that (QT_SELECT only works if qmake in your PATH is qtchooser wrapper so that only works on some systems; you may also just modify PATH to point to a specific qmake). I don't think it's a good idea to intervene with this process in some automatic way. And on modern OSs Qt 5 should already be the default.


Enable cross compilation

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Based on this: https://github.com/nanomsg/nng/blob/master/docs/BUILD_CROSSCOMPILE.adoc I think tool build (nngcat) is disabled when cross compiling, so you should either not test it, or enable it manually in the build flags.


How do I report CPU, memory, load balancing?

How do I report CPU, memory, load balancing?
System Cpu Usage empty

@lpvus
What's  load balancing?

@lpvus
Sorry, Not support right now.


TypeError: forward() got an unexpected keyword argument 'causal_mask'

Hey there,
I followed the installation, and managed to replicate the Collab: https://colab.research.google.com/drive/1oW55fBmwzCOrBVX66RcpptL3a99qWBxb?usp=sharing#scrollTo=QmUBVEnvCDJv
However, when I get to training the model (trainer.train()) I instantly get:
TypeError: forward() got an unexpected keyword argument 'causal_mask'
Am I missing something?

Hey @danielhanchen
After a lot of testing I believe I found the issue.
On the README the command
pip install --upgrade --force-reinstall --no-cache-dir torch triton
--index-url https://download.pytorch.org/whl/cu118
was installing Torch 2.1.1 but we really do require 2.1.0. The solution was to switch up the command to:
pip install --upgrade --force-reinstall --no-cache-dir torch==2.1.0 triton
--index-url https://download.pytorch.org/whl/cu118
I Hope this helps anyone having the same issue!

Oh interesting on torch 2.1.1 - I shall investigate this actually - very interesting

Hi, just wanted to note that I also had this same error message, and @JoaoBone 's suggested fix worked for me.

@araleza Oh neat! Ok looks like as a temporary fix I'll update the documentation

@araleza @JoaoBone I think I might have fixed Pytorch 2.1.1 support - not sure if you want to try it out (it'll be cool if you can :) ) Hopefully Unsloth is useful to you both!

Closing now! One can use the Pytorch 2.1.1 route:
pip install "unsloth[cu118_torch211] @ git+https://github.com/unslothai/unsloth.git"
pip install "unsloth[cu121_torch211] @ git+https://github.com/unslothai/unsloth.git"
pip install "unsloth[cu118_ampere_torch211] @ git+https://github.com/unslothai/unsloth.git"
pip install "unsloth[cu121_ampere_torch211] @ git+https://github.com/unslothai/unsloth.git"


Downloading YouTube History fails on parsing JSON

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', ':ythistory', '--username', 'PRIVATE', '--password=PRIVATE', '-f', 'worstvideo+worstaudio']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2018.10.05
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg N-91712-g26dc763245, ffprobe N-91712-g26dc763245
[debug] Proxy map: {}
[youtube:history] Downloading login page
[youtube:history] Looking up account info
[youtube:history] Logging in
[youtube:history] Checking cookie
[youtube:history] Youtube History: Downloading webpage
[download] Downloading playlist: Youtube History
[youtube:history] Youtube History: Downloading page #1
[youtube:history] Youtube History: Downloading page #2
[youtube:history] Youtube History: Downloading page #3
[youtube:history] Youtube History: Downloading page #4
[youtube:history] Youtube History: Downloading page #5
[youtube:history] Youtube History: Downloading page #6
[youtube:history] Youtube History: Downloading page #7
[youtube:history] Youtube History: Downloading page #8
[youtube:history] Youtube History: Downloading page #9
[youtube:history] Youtube History: Downloading page #10
[youtube:history] Youtube History: Downloading page #11
ERROR: Youtube History: Failed to parse JSON  (caused by ValueError('Invalid \\escape: line 1 column 587495 (char 587494)',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 871, in _parse_json
  File "C:\Python\Python34\lib\json\__init__.py", line 318, in loads
  File "C:\Python\Python34\lib\json\decoder.py", line 343, in decode
  File "C:\Python\Python34\lib\json\decoder.py", line 359, in raw_decode
ValueError: Invalid \escape: line 1 column 587495 (char 587494)
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 871, in _parse_json
  File "C:\Python\Python34\lib\json\__init__.py", line 318, in loads
  File "C:\Python\Python34\lib\json\decoder.py", line 343, in decode
  File "C:\Python\Python34\lib\json\decoder.py", line 359, in raw_decode
ValueError: Invalid \escape: line 1 column 587495 (char 587494)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\YoutubeDL.py", line 803, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\YoutubeDL.py", line 963, in process_ie_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\youtube.py", line 2796, in _entries
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 864, in _download_json
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 848, in _download_json_handle
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5xdqinp2\build\youtube_dl\extractor\common.py", line 875, in _parse_json
youtube_dl.utils.ExtractorError: Youtube History: Failed to parse JSON  (caused by ValueError('Invalid \\escape: line 1 column 587495 (char 587494)',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
<end of log>

Description of your issue, suggested solution and other information
I am trying to download all of the videos I have watched on YouTube.  I've provided the correct username and password.  However, the program fails after downloading page 11 of the history list.
My suggested solution is to check if the JSON format that the page is provided in has changed, as this is probably a rarely used feature, and YouTube's redesign may have messed things up.

The surrounding area is
class=\"yt-uix-sessionlink
with the l being the character that causes the failure.
Note: I've watched more videos since making this issue, so I went to the new location the error was at.


update ros2 launch files if needed

Some launch files changed on develop since ros2 branched off, which can be seen in the merge PR #594.
We should check if these changes impact the corresponding ROS2 *.launch.py files.

just checked that the affected launchfiles were not yet migrated to ros2 (uncommenting things from main launchfiles as nodes are migrated to ease independent debugging)


fix: request captcha v3 token just before submitting the data, preven…

…t token from expiring

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?

Issue Number: Closes #
What Is the New Behavior?
Does this PR Introduce a Breaking Change?

[ ] Yes
[ ] No
Other Information
AB#82803

fixed with #1347


Only create render layers when Opacity is animating.

Add AvaloniaObject.IsAnimating(property) to allow us to check if a property has an active animation on a property
Only create a render layer when a property:

Has an animating Opacity property and
Has child controls

Don't render controls with 0 opacity

We should also create a new render layer when a control has an animating RenderTransform but that would be best to put in a separate PR I think.

There is a failing test here which has made me realize that some of the logic is wrong. Need to fix this before merging.


Server Channel configuration and HTTP1 timeout

Add configuration struct for HTTP1 and HTTP2 channels
Add idle timeout parameter for HTTP1
Add HTTP1 config to HTTP2 config for stream channels

I intend to use the HTTP2 config to add main channel support, like idle, ping timeout, close timeout etc

Let's discuss this change a bit more, I think we can improve it a bit more


Whats the purpose of angular-linq

I was browsing for a linq.js bower package and stumbled over here...
Then I asked myself and YOU of course what is the advantage of wrapping linq.js with angular to do something like:
$linq.Enumerable()
without angular-linq I just do:
Enumerable.from
I just do not get it...

yes you can do Enumerable.from in a plain javascript way.
$linq.Enumerable() can be injected where ever it is needed without polluting global namespace using angular way. Other than that it does the same that linq.js does.
Also, I did not had an option to include linq.js using bower for my angular application.

its just bower install linqjs, that worked for me and it has the latest beta5 :-)


Fixed Rules for Racism

Added more Slurs to check for racist users to easily detect them in the future.

You've done a fantastic job of adding a bunch of potential false positives. 'Spook', 'Gringo', 'Jew', '13%' and others. 'MattHaynie' is an interesting one.
Go back to Reddit.

You've done a fantastic job of adding a bunch of potential false positives. 'Spook', 'Gringo', 'Jew', '13%' and others. 'MattHaynie' is an interesting one.
Go back to Reddit.

Im not sure how "Going back to Reddit" is going to help anyone here, but i tried and had a few laughs on r/Funny (/s!). Anyways id like to address these additions, 'Spook' is a common term to refer to a person of color (this is a very old term) and hopefully (i didnt check) the regex being used to identify these words only checks the words and not sub-words. i can understand the confusion here because you might want to avoid flagging someone for saying 'spooky' and i agree. of course with all other changes in this PR these are up to the owner and are merely a suggestion. 'Gringo' is a slur, no debate here. "Jew" is rarely used in actual conversation about people of jewish faith because of the negative connotation surrounding it when used by alt-right white supremacists. the correct term is "person of jewish faith" and if referring as a verb "jewish". "13%" is a common white supremacist dogwhistle used by members of the alt right to refer to a (long outdated and racist) statistic supporting the idea that male persons of color make up 13% of the american population but commit 50% of the crimes(yes they actually believe this).
As i said before, all these changes are up for vetting by the author of this software, please accept my changes with a grain of salt and feel free to remove what you dont agree with. I wont be offended, others might, but ill be fine.
Thanks for reading!

how about we just dont.
this is a terrible idea, wordfilters do not work and 90% of people that play video games shrug off racial slurs to begin with regardless of race. this is a non issue.

Looks great!

did u actually look at it

Looks great!

did u actually look at it

Yes, i have! I think its a fairly complete list of racial slurs, maybe a few could be removed to prevent false positives but overall the idea is great. The original filter would not suffice.
Regarding your previous comment condoning online hate in video games, that is disgusting and you should be ashamed of yourself. please consider taking the anykey pledge: https://www.anykey.org/en/pledge

Looks great!

did u actually look at it

Yes, i have! I think its a fairly complete list of racial slurs, maybe a few could be removed to prevent false positives but overall the idea is great. The original filter would not suffice.
 'Spook', 'Gringo', 'Jew', '13%' and others. 'MattHaynie' is an interesting one.
Go back to Reddit.

Im not sure how "Going back to Reddit" is going to help anyone here, but i tried and had a few laughs on r/Funny (/s!). Anyways id like to address these additions, 'Spook' is a common term to refer to a person of color (this is a very old term) and hopefully (i didnt check) the regex being used to identify these words only checks the words and not sub-words. i can understand the confusion here because you might want to avoid flagging someone for saying 'spooky' and i agree. of course with all other changes in this PR these are up to the owner and are merely a suggestion. 'Gringo' is a slur, no debate here. "Jew" is rarely used in actual conversation about people of jewish faith because of the negative connotation surrounding it when used by alt-right white supremacists. The use of the term can be quite disgusting, and i have personally been using this list while running TF2BD and have had 0 false flags. Heres one of the messages caught by the system: Image, as you can see, its rarely used in actual reference to people of the jewish faith but rather used as an insult. please refer to the ADL's page on this aswell. correct term is "person of jewish faith" and if referring as a verb "jewish". "13%" is a common white supremacist dogwhistle used by members of the alt right to refer to a (long outdated and racist) statistic supporting the idea that male persons of color make up 13% of the american population but commit 50% of the crimes(yes they actually believe this).
As i said before, all these changes are up for vetting by the author of this software, please accept my changes with a grain of salt and feel free to remove what you dont agree with. I wont be offended, others might, but ill be fine.
Thanks for reading!

Why did you send an image of a naked black man, and why is 'MattHaynie' a slur? Additionally, the '13%' dogwhistle is completely legitimate, it's real crime statistics, and obviously there is a LOT of potential for all of these to come up in normal conversation, for example, it is always racist to say 'nigger', it depends on the context. Context is completely ignored, so implementing this functionality will always have false positives.

A repo I work on frequently, https://github.com/tgstation/tgstation, nearly got permabanned by github for just having slurs scattered about in a few places, even when used in a non-racist context. See https://github.com/tgstation/tgstation/commit/8dbf1cf4ec8dd1d90988ce24d3986833197ed097
Before this is pushed, and in fact, ASAP, the maintainers of this repo should contact github to preemptively clarify the use of slurs in the codebase so that people behind the TF2 bots can't report this repo.
Side note, does this program auto-kick people just for being racist? I'd rather preserve my kick cooldown for actual hackers if that's the case, so I'd like this clarified, perhaps in the readme.


Modified frequencies for longevity test triggers

Modified frequencies for bellow longevity test triggers:

AppTaskDown
RebootNode
CrashVolDriver
RestartVolDriver

@vinayakshnd is this PR still relevant?


Time stamping warning messages

Add time stamps to warning messages to enable easier debugging. I propose using an environment variable to enable/disable this feature.

@oesteban I've added logic to paramrun that will provide timestamps on warning and error messages if set/export LAUNCHER_TS to any non-zero value it will prepend date/time warning/error messages sent to stderr. stdout messages are not affected. Unsetting LAUNCHER_TS or setting it to 0 will disable the timestamps.
Change is in branch warning-timestamps  (https://github.com/TACC/launcher/commit/a84fdd8f50bd9d5df0da252dbd9369416b6cff17).

This has been merged into master


Fix LinkedIn link

Haha, I figured that out a little while after I updated the README and fixed it. Thanks for bringing it up though!


Search Activity Loaders

Implement Loaders with List instead of Cursor data.

This will not move forward due to implementing AAC


macOS app: better error if trying to start non-orthogonal R version

Because I think currently we just crash?

We could also just run rig system make-orthogonal after an install, but we still need a better error, because the user might not run rig add at all.

It does not crash, it "just" starts up the default version for me, instead of the selected one.


[1.3.7-prepare#5727][Fix-5726] When we used the UI page, we found some problems such as parameter validation, parameter update shows success but actually work

issue:#5726
pr:#5727
Only the invalidation time parameters of creating token verification are merged, and the other parts involve the repair of new functions on the dev branch. The 1.3.7 branch does not support.

+1


Sync branches so v3 uses latest master

@Peter-Schorn merging master into v3 was conflicting a bit, I think in the future it'll be easier to do the v2 change in v2 first, and then incorporate that change in v3
Otherwise rebasing becomes difficult, as git isn't clever enough to detect that 2 different commits can have the same piece of code. Feature should be committed once, and then merged into other branches so they share the same references

Yes, I should've committed the non-breaking changes to master first. That was my mistake.


What's the right way to serve PDF using this Dockerfile

I have a small website and I love that.
However, I want to serve a PDF file as well.
Right now, the PDF file is not being served with correct mime type causing the browsers to display garbled output.

This is not an issue with the busybox http server itself since I can serve PDF files without an issue. I'd check the file encoding and try to encode the PDFs to UTF8 if possible.


[NEW] Support deep links

Idea coming from RocketChat/Rocket.Chat#6820
Initial URLs to be supported

Authentication;
Server + Chat;

@laggedHero when this feature will works?

@narlei Authentication is already working, just missing the chat now.

That's already implemented in 3.2.0. 👍


Backport DESE/nature-walk improvements to LeafPack

save immediately on change of inputs
eliminate redundant creation of model instances
eliminate maintenance of isDirty/isSaved state variables since we're auto-saving

@mklewandowski Changes ended up being more extensive than I expected. Worth doing some testing to make sure nothing's broken, but the things we talked about seem to be fixed.

@kswenson Also seeing that the chemistry tests rest when we run the sim.  So both the habitat checkboxes and the chem tests reset when the sim is run.

The macro panel does not reset when we rerun the sim.  That seems to be a clue.  Both the habitat checkboxes and the chem tests should behave like the macro sorting panel.

I added a commit which should fix it.

@kswenson I just discovered that the bug with the progress bar was already there.  It looks to have nothing to do with your changes.

The clearing on rerun issues should be fixed now.

if we select a stream and run the sim, rewind the sim, move to a different stream, and then return to the first stream, the progress bar says 3 weeks and is full, but should be in the initial state.

I'm pretty sure that's preexisting and is beyond the scope of this PR. That would require pulling in the DESE changes to the handling of TransientState which I decided were too intrusive to attempt right now.


the audio player of the demo does not work.

The last demo of the pack to download does not work the audio player.

The demo in the release download is the same as https://plyr.io/#audio, which is working great. I can also run it locally with for example python -m SimpleHTTPServer 8080 and then going to http://localhost:8080/demo/. If it doesn't work for you locally it's probably your server. You need the right mimetypes etc. See your console for errors.

Yes or if you need to be on a server? since the direct PC does not work?

A server is a computer (or software depending on the context). You can run server software on your PC. Anyway, it's not a bug, has nothing to do with the functionality of Plyr, and you have to figure this out on your own.

In the future, please use slack https://bit.ly/plyr-chat for questions or issues, if they're not happening on https://plyr.io


Marty.renderToString and nested routes.

Routes:
<Route name='Root' path='/' handler={App}>
  <Route name='SomePage' handler={SomePage}>
    <Route name='SomeSection' handler={SomeSection}/>
  </Route>
</Route>

App - wrapped in container with fetches(eg. asset paths). renderToString waits on fetches and returns proper html and diagnostics.
SomePage - wrapped in container with fetches(eg. some dynamic menu elements and sidebar data). renderToStrings starts fetches, but returns only App fetches, without waiting on SomePage fetches.
SomeSection - wrapped in container with fetches(eg. user lists and other data). Same problem here.
Nested fetches are not timing out, they are completed under 100ms.
They are not registered in diagnostics.
They are not waited on, but they are executed outside of renderToString. renderToString starts them, but returns html as soon as App fetches are ready.
Server already sent finalized html, but nested fetches are still been executed in background.
When container is removed from App, SomePage fetches are waited on and added to diagnostics.
Same code is working on client side without problems.

I think I've worked out what the issue is.
In Marty.renderToString we

Render a component tree
Check to see if any components made fetches and wait for them
Re-render the component tree

This makes the assumption that your components will not make subsequent fetches as the result of the initial fetch. This assumption falls down because the page container won't render the section component until it has finished all of its fetches.
I will update renderToString to continue trying to re-render until there are no more fetches.

Well that was a fun bug! I've just released v0.9.15 which resolves this issue


Please make this package Laravel 10 compatible/compliant

As per version 10 of Laravel, they recommend/require the minimal-stability attribute in the composer.json to be stable.
[Minimum Stability](https://laravel.com/docs/10.x/upgrade#updating-minimum-stability)

You should update the minimum-stability setting in your application's composer.json file to stable

This causes the upgrade to fail if you have this package installed.
  Problem 1
    - Root composer.json requires jigarakatidus/laravel-http-to-curl ^1.0.0-alpha -> satisfiable by jigarakatidus/laravel-http-to-curl[1.0.0-alpha].
    - jigarakatidus/laravel-http-to-curl 1.0.0-alpha requires jigarakatidus/command-line-generator ^1.0.0-alpha -> found jigarakatidus/command-line-generator[1.0.0-alpha] but it does not match your minimum-stability.

I tried reverting the minimum stability back to what it was before but that breaks the upgrade process  entirely.
You don't need to update any code, the version numbering should be fixed.

Done.
Let me know if you still face any issues.
Thanks for reporting.

Thank you! The upgrade ran without any issues now.


chore: lib upgrades and nodejs 16 => 18

Fixes #5

@johnf, wdyt?

Done. Thanks for reminding me!

thanks @johnf !


Update license year to 2016

For consistency with README and source files, could you rename it to just 2016 instead of 2014-2016?

I have updated it to 2016

Thanks!


Puzzles about codes in segmentation.cpp

Hi, recently, I have read your paper (Geometrically Consistent Plane Extraction for Dense Indoor 3D Maps Segmentation), and I have found the code you provided, it's really of great help to me, thank you.
I have some puzzles and have tried to send you an e-mail, but the e-mail was not sent successfully. Therefore, I'm here to post my puzzles.
As the main procedure is done in doSegmentation in segmentation.cpp, my puzzles are mainly caused by code of the function.

In line 209, why min_num_supervoxel_per_plan is equal to config_.min_plane_area/(config_.seed_resolution*config_.seed_resolution/4/M_PI)
From line 170 to line 172, the steps of Hough accumulator are defined as
double step_theta = 1;double step_phi = 1;double step_rho = 0.025; are they empirically set? In my experiment, step_rho is set to 0.2, and I also set the other two steps as yours , however, as the bin effect, I don't obtain the desired result even two planes with 0.5 degree angle difference and 0.1 meter rho difference  (the two planes don't vote to the same bin in Hough accumulator).
Are the thresholds ( 0.8, 0.5, and 0.25)()  set empirically?(line 245: float normal_dis = dotprod < 0.8 ? 100 : 1; line 295: dot_prod = dot_prod < 0.5 ? dot_prod : 1 - dot_prod; line 296: double angle_cost = 1 - exp(-dot_prod/0.25);)
From line 254 to line 256, I'm puzzled about  the way of processing plane_score and the reason of setting confidence_threshold to 0.1, I tried to find some information from your paper, but nowhere referred to this.
Additionally, there are no label cost terms in the energy functions you constructed, I think this is probability because you treated the model selection as label cost, is this right?
Hoping for your reply!

Hi, recently, I have read your paper (Geometrically Consistent Plane Extraction for Dense Indoor 3D Maps Segmentation), and I have found the code you provided, it's really of great help to me, thank you.
I have some puzzles and have tried to send you an e-mail, but the e-mail was not sent successfully. Therefore, I'm here to post my puzzles.
As the main procedure is done in doSegmentation in segmentation.cpp, my puzzles are mainly caused by code of the function.

In line 209, why min_num_supervoxel_per_plan is equal to config_.min_plane_area/(config_.seed_resolution*config_.seed_resolution/4/M_PI)
From line 170 to line 172, the steps of Hough accumulator are defined as
double step_theta = 1;double step_phi = 1;double step_rho = 0.025; are they empirically set? In my experiment, step_rho is set to 0.2, and I also set the other two steps as yours , however, as the bin effect, I don't obtain the desired result even two planes with 0.5 degree angle difference and 0.1 meter rho difference  (the two planes don't vote to the same bin in Hough accumulator).
Are the thresholds ( 0.8, 0.5, and 0.25)()  set empirically?(line 245: float normal_dis = dotprod < 0.8 ? 100 : 1; line 295: dot_prod = dot_prod < 0.5 ? dot_prod : 1 - dot_prod; line 296: double angle_cost = 1 - exp(-dot_prod/0.25);)
From line 254 to line 256, I'm puzzled about  the way of processing plane_score and the reason of setting confidence_threshold to 0.1, I tried to find some information from your paper, but nowhere referred to this.
Additionally, there are no label cost terms in the energy functions you constructed, I think this is probability because you treated the model selection as label cost, is this right?
Hoping for your reply!

Hi, Recently, I am beginning to study the 3D  segmentation, but I don't know how to build this code in my computer, so could tell me how do you build this project and setup this code?(my<EMAIL_ADDRESS>


"CARACAL" is listed in the drop-down menu

Description:
"CARACAL" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "CARACAL" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oraș CARACAL, OLT (CARACAL)".


fix: fix height of context menu and dropdown items (Issue #460)

Issue: https://github.com/epam/ai-dial-chat/issues/460

/deploy-review


updated project list

Coverage remained the same at 100.0% when pulling 77203078ff84e4494f80c5e7ebd79c14f137489d on gale93:master into c986a6c4dd91c8729670738e5eee7401c487c652 on skypjack:master.

@gale93 Why did you close this?

@skypjack A mistake ^^"


Add oldest-newest-commit-list feature

This feature adds two new links (Oldest and Newest) to the commit list pagination.
The api3 url is now exposed because I didn't want to make too many changes to support head requests.
Test
https://github.com/sindresorhus/refined-github/commits/master
Before

After

How often do you need to reach the first commit though?

Personally, I need that often when trying to investigate something in open source projects. The blame feature isn't enough for me.

I could see the use-case for "Newest" to go back to the first page, but I don't think I ever needed to see the oldest commits. And I don't think either are useful enough to make the default navigation noisy. I think these would be better as either keyboard shortcuts or links somewhere that are not visually disturbing the normal navigation.

Maybe they could be small faded out links, not buttons, in positions like this:

The links could be more discrete chevrons «»
Newest is technically already accessible by selecting the current branch in the branch selector (two clicks though)
There’s a big implementation difference between Newest and Oldest, if we decide that Oldest isn’t worth the hassle (2 API calls on every Commits page), we could just add a Newest link

Well, I'd love to have the oldest button.
But if you think it's not worth the hassle, I don't think there's a reason to add only the newest button.

Please run this to delete the tags from your fork and locally, we keep pulling them from your fork and pushing them to this repo (we no longer use tags)
git tag -d $(git tag | grep -E '.')
git ls-remote --tags --refs origin | cut -f2 | xargs git push origin --delete

Please run this to delete the tags from your fork and locally, we keep pulling them from your fork and pushing them to this repo (we no longer use tags)
git tag -d $(git tag | grep -E '.')
git ls-remote --tags --refs origin | cut -f2 | xargs git push origin --delete

I did that, is it ok now?

It is thanks! And sorry if it sounded like it was your fault, I worded it badly

It is thanks! And sorry if it sounded like it was your fault, I worded it badly

That's fine. :)
Really appreciate your hard work!

Well, I'd love to have the oldest button.
But if you think it's not worth the hassle, I don't think there's a reason to add only the newest button.

Please let me know what's your decision about this feature, going forward with both of the buttons or just close this PR?
Thanks!

I'll close this for now and I'll only implement the Newest button

fwiw I wish Oldest button got merged. I frequently just want to see how old a project is and where it started off out of sheer curiosity.

@corysimmons how old is already there

@yakov116 I can't seem to find it. :\

@corysimmons its on the repo bar. It was one of the last features added

Ah, that explains why I missed it. Thank you so much.


Fix olcGlobalConf chracter case attributes + allow complex access rules

@lchanouha I guess this PR is related to #134.
Could you please provide an acceptance test that proves the bug so that we can validate that your fix works (and don't break anything on other Operating System and/or OpenLDAP version) and to prevent regression.
Also, please do not mix features in the same PR (send another PR for the complex access rules fix).
Thanks

OK, i will send a specific PR for complex acls fix.
Related to #134, i don't have the knowledge to work on travis test. I will remove my related PR until i found some to look at that (could be long...).

@lchanouha I've merged 77b51ba. Are you still interested in rebasing the other commit and providing tests?


Correlation spectrum example

Coverage remained the same at 88.884% when pulling<PHONE_NUMBER>2e11131aee6b2575d00102d19897c7 on david-pl:spectrum-example into 9e40c61e9eb961bb2c7218bed333d22b0cc9b4e7 on bastikr:master.


Support for all-language lexical

See https://github.com/kiteco/kiteco/issues/11793.
This PR expands the list of languages for which the plugin can activate.
The languages for which the plugin activates by default remain the same: only python.  However the user can change this by setting the g:kite_supported_languages variable in their vimrc, as documented already.
I wasn't able to test this as kited doesn't seem to support these extra languages yet.

Thanks! I'll handle checking this against the feature branch that has kited support.


add calls to flush_audio for say() and rtvi action

Call flush_audio() after direct calls to TTS say() and when processing TTSSpeakFrames.

LGTM!


I failed in test

Fix the test-unit and test-unit-integrations and help me pass the test

I have updated the executecmd function in test case to capture the stdout. Do take a look at pr.


About code of HybridSemanticFusion

A wonderful work!
I have a question regarding the implementation of the cluster center calculation. In the original paper, the HSF module is described as follows:
The HSF module follows a three-step paradigm: ① Cluster patch embeddings into K groups using KMeans. ② Compute the anomaly scores of individual clusters by averaging the scores of the corresponding positions in the anomaly map M. ③ Select the cluster with the highest anomaly scores, calculate its centroids, and aggregate them into the final semantic-rich image embedding FI, which encapsulates semantic information about the most abnormal clusters.
However, in the code implementation, after performing KMeans clustering, the code calculates the mean of the cluster centers for each batch, and then takes the mean of these centers to produce the final semantic-rich image embedding. This approach seems to imply that regardless of the initial clustering, the final result might be the same since it's an average of averages.
Here is the relevant part of the code:
class HybridSemanticFusion(nn.Module):
    def __init__(self, k_clusters):
        super(HybridSemanticFusion, self).__init__()
        self.k_clusters = k_clusters
        self.n_aggregate_patch_tokens = k_clusters * 5
        self.cluster_performer = KMeans(n_clusters=self.k_clusters, n_init="auto")

    # @torch.no_grad()
    def forward(self, patch_tokens: list, anomaly_maps: list):
        anomaly_map = torch.mean(torch.stack(anomaly_maps, dim=1), dim=1)
        anomaly_map = torch.softmax(anomaly_map, dim=2)[:, :, 1] # B, L

        # extract most abnormal feats
        selected_abnormal_tokens = []
        k = min(anomaly_map.shape[1], self.n_aggregate_patch_tokens)
        top_k_indices = torch.topk(anomaly_map, k=k, dim=1).indices #(1,100) index
        for layer in range(len(patch_tokens)):
            selected_tokens = patch_tokens[layer]. \
                gather(dim=1, index=top_k_indices.unsqueeze(-1).
                       expand(-1, -1, patch_tokens[layer].shape[-1]))
            selected_abnormal_tokens.append(selected_tokens)

        # use kmeans to extract these centriods
        # Stack the data_preprocess
        stacked_data = torch.cat(selected_abnormal_tokens, dim=2)

        batch_cluster_centers = []
        # Perform K-Means clustering
        for b in range(stacked_data.shape[0]):
            cluster_labels = self.cluster_performer.fit_predict(stacked_data[b, :, :].detach().cpu().numpy()) # cluster label for each abnormal token

            # Initialize a list to store the cluster centers
            cluster_centers = []

            # Extract cluster centers for each cluster
            for cluster_id in range(self.k_clusters):
                collected_cluster_data = []
                for abnormal_tokens in selected_abnormal_tokens:
                    cluster_data = abnormal_tokens[b, :, :][cluster_labels == cluster_id]
                    collected_cluster_data.append(cluster_data)
                collected_cluster_data = torch.cat(collected_cluster_data, dim=0)
                cluster_center = torch.mean(collected_cluster_data, dim=0, keepdim=True)
                cluster_centers.append(cluster_center)

            # Normalize the cluster centers
            cluster_centers = torch.cat(cluster_centers, dim=0)
            cluster_centers = torch.mean(cluster_centers, dim=0)
            batch_cluster_centers.append(cluster_centers)

        batch_cluster_centers = torch.stack(batch_cluster_centers, dim=0)
        batch_cluster_centers = F.normalize(batch_cluster_centers, dim=1)

        return batch_cluster_centers

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Thank you for your question!
I apologize for any confusion caused by the differences between our implementation and what is described in the paper. In our approach, we:

Extract the most abnormal tokens.
Group these tokens into clusters.
Calculate the average center of each cluster and fuse them together.

We use a hyperparameter, k_clusters, to control the number of abnormal tokens extracted. Our goal is to gather information from multiple potentially abnormal clusters rather than focusing on just the most abnormal one, as we found this method to provide more stability.
This approach can be thought of as a weighted average function with adaptive weights, rather than a simple average of all abnormal tokens. We welcome any further discussion on this topic and would appreciate suggestions for improvements.
Best regards,

As I understand it after reading the code implement, the process involves:

Selecting 100 abnormal patch tokens.
Clustering these tokens into 20 clusters.
Calculating the center of each cluster by averaging the tokens within each cluster.
Averaging these 20 cluster centers to get a final representation.
My question is, would this final representation be significantly different from directly averaging the 100 abnormal tokens? Intuitively, it seems like both methods should yield a similar result since both involve averaging, albeit at different levels of aggregation.

I am trying to understand if there is a substantial difference in the outcome or if one method provides certain benefits over the other.

Thank you for your insightful question! To be honest, I haven't tried directly averaging all the abnormal tokens, but intuitively, the difference might not significantly impact the final performance. It could be worth running a quick experiment to validate this.
I should also mention that the design of the HSF is somewhat heuristic. The primary contributions of AdaCLIP lie in its hybrid multimodal prompts. While developing a more refined image-level fusion method would indeed be beneficial for anomaly detection, AdaCLIP may not fully address this aspect as elegantly.


TheAltF4Stream: Install Default LSPs

Though you can currently run my neovim environment in a Docker container - the image does not provide any lower level language server protocols directly.
It would be good to have some defaults included in the image (node, go, rust, etc) but will need to make sure we don't make the image massive after doing so.

This is no longer an issue as I use coc.nvim now which packages its LSPs with plugins.

This is no longer an issue as I use coc.nvim now which packages its LSPs with plugins.


Upload File Problem!

Hi.
I tried to upload a file, but surprisingly the hash and content of the uploaded file are different from the hash and content of the original file.
I created a sample code to show you the error.
This error happens rarely and is not always.
https://github.com/mbtolou/beetlex-error

Hello.
You can see two other beetlex errors in the following repository:
CROS Origin does not work.
The cookie parser does not work and you must call the parser before using it.


Building grpc on 32bit Linux fails with number-string-conversion issue

On Ubuntu 16.04 i386 I get the following error:
test/cpp/thread_manager/thread_manager_test.cc: In member function 'void grpc::ThreadManagerTest::PerformTest()':
test/cpp/thread_manager/thread_manager_test.cc:121:49: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'int' [-Werror=format=]
           gpr_atm_no_barrier_load(&num_do_work_));

I can probably fix this myself if someone can point me to the printf formatting guidelines?

Is 32bit not supported anymore? Or am I doing something wrong?

Posted a fix

Cool thanks!


Using OpenSSL 3 in code: Converting DES_crypt to EVP APIs

As stated in OpenSSL 3, DES_crypt macro is deprecated. We are encouraged to use the sequence EVP_EncryptInit_ex(3), EVP_EncryptUpdate(3) and EVP_EncryptFinal_ex(3) as stated here: https://www.openssl.org/docs/manmaster/man3/DES_crypt.html
Our old code is like this
char* theDESCrypt (const char *myBuf, const char *mySalt)
{
    // some code here
    // ...
    return DES_crypt(myBuf, mySalt);
}

Is the following converted code correct?
char* theDESCrypt (const char *myBuf, const char *mySalt)
{
    // some code here
    //

    /* setup Cipher Ctx */
    const EVP_CIPHER *des_cipher = EVP_CIPHER_fetch(NULL, "DES", NULL);
    EVP_CIPHER_CTX *p_Ctx =  EVP_CIPHER_CTX_new();
    EVP_CIPHER_CTX_init(p_Ctx);

    /* encrypt data*/
    int outLen = 0;
    int outLenFinal = 0;
    unsigned char *outBuf = (unsigned char *)calloc(32, 1);

    EVP_EncryptInit(p_Ctx, des_cipher, (unsigned char*)myBuf, (unsigned char*)mySalt)
    EVP_EncryptUpdate(p_Ctx, outBuf, &outLen, (unsigned char*)myBuf, strlen(myBuf))
    EVP_EncryptFinal(p_Ctx, outBuf + outLen, &outLenFinal)

    /* finalize encypted data */
    outLenFinal += outLen;
    unsigned char *returnData = OPENSSL_zalloc(outLenFinal);
    OPENSSL_strlcpy(returnData, outBuf, outLenFinal);

    /* free pointers */
    EVP_CIPHER_free(des_cipher);
    EVP_CIPHER_CTX_free(p_Ctx);
    free(outBuf);
    return (char*)returnData;
}

I used the buff as the key.
Then I used the salt as the iv.
Is my use of EVP_EncryptInit, EVP_EncryptUpdate and EVP_EncryptFinal correct?
Do I have to call EVP_EncryptFinal or EVP_EncryptUpdate is enough?
I'm also not sure if "DES" is the proper cipher to be fetched since our old code is just "DES_crypt(..)".

DES_crypt() cannot be directly replaced with EVP_Encrypt* functions because it implements the password crypt function.

Does OpenSSL 3 have other APIs that we can use as alternative for DES_crypt?

Would this be a regression?  It seems like it.

I would assume yes. As I understand, I can remove this old code(with DES_crypt) since we will not be using it anymore in our future releases.
I'm just curious if OpenSSL 3 have any APIs to support it.

The DES_crypt API is available in 3.0 although deprecated. There is IMO no reason to add it to providers (although it would be probably possible to add it to the legacy provider as a KDF) as the DES_crypt is truly useless. With the current computing power of contemporary CPUs it does not provide sufficient protection for the hashed passwords in addition to the limitation of only up to 8 characters passwords being supported by it.

If we should add it back, it should end up in the legacy provider, and most probably as a KDF.

I recall that we deliberately decided to not implement a DES_crypt replacement - although I can't find a record of that in CHANGES.md. We at least deliberately decided to remove its use from the passwd app without any replacement (see c87a7f31).

Side thing:
this sparked me during a pause from work, and well: https://github.com/provider-corner/extra


chore: upgrade Spark to 3.4, and Deequ to 2.0.5

Issue #, if available: https://github.com/awslabs/python-deequ/issues/151
Description of changes:
Upgrade Spark to 3.4 and Deequ to 2.0.5
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The test failures are because some new optional parameters were introduced with the new version of Deequ (e.g. the analyzerOptions). Today the Python land cannot leverage the default parameters in Scala land... so it throws an error.
If the interface have to be an exact match, the code will bifurcate (since older version of Deequ won't have this parameter) e.g. below fixed the issue for deequ 2.0.5 but broken deequ <2.0.5
-        self._Check = self._Check.hasMaxLength(column, assertion_func, hint)
+        analyzer_options = self._jvm.scala.Option.apply(None)
+        self._Check = self._Check.hasMaxLength(column, assertion_func, hint, analyzer_options)

We have been busy with re:invent - expect some progress  in Dec.

Hi, is there a potential date for supporting Spark 3.4 ? :)  Is it more December/January or even later ?

Hello, @chenliu0831! Is there a expected date for supporting this Spark version?

Hi is there any update on this please?

Hi All, i created a new pull request to accommodate spark 3.4 version and deequ later than 2.0.3. Welcome to take a look.
https://github.com/awslabs/python-deequ/pull/178

@anqini thanks so much for looking into this and submit the PR. Unfortunately, we cannot drop the support to older Spark/Deequ version yet. I will take a closer look in #178.
All - we have discussed with Deequ team and we will be working on a longer term solution including supporting plan for older Spark versions. There's no ETAs yet (some plan in Jan) but good news is we merged the maintainer groups from both repo.  I will be looking into if we can have a safe short term solution in PyDeequ only this weekend.

Hi, @chenliu0831! Any news on this upgrade?

Hello all! Any news on version upgrade?

Hi. Is there any update on this please?

Closing this for now, see my comments in https://github.com/awslabs/python-deequ/issues/192#issuecomment-1972385951 and we can provide updates there


Solved scrolling with key arrows

Hello Mark,
I've solve the situation for the Scroll using the arrow keys. Please let me know what do you think.
Best regards,
Juan Felipe

great job!


Logo Proposal for Electron music player

Hi @Sogrey
I'm interested in collaborating with this project by delivering a series of logotype options that fits this project for the best!
If interested let me know so we can get started!
Cheers!

First of all, thank you very much. It is very nice to have a nice logo. In fact, this project is a electron training project, a simple version of local music player, and the online music search and play function may be added later, so the project may not be released online, are you still willing?

Hi @Sogrey
Of course I would like to collaborate.
It would be very helpful to know if you want any specific characteristics in the logo?

Dear @memoryskull
I'm not very good at it, so you're free to design it, and I'm sure I'll like it.
对此，我并不是很擅长，所以你可以自由设计它，我相信我会喜欢它。

ok perfect @Sogrey

@Sogrey  I would like to know if they would update the read me information?

@memoryskull
Yes, it will be updated to show the logo and some development environment information, usage and help
是的，会更新的，会展示您设计的logo和一些开发环境信息，使用方法和帮助


fix(module:time-picker): make keyboard navigation possible

Tabbing away from time-picker overlay was not possible: It wrapped
around and usually ended up in browser's address bar. Also, once you
selected time-picker wrapper span, there was no way to open the overlay
via keyboard.
This fixes this. Tabbing away from overlay now focuses on time-picker
wrapper span. Pressing enter on the wrapper span opens the overlay.
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Tabbing away from time-picker overlay was not possible: It wrapped
around and usually ended up in browser's address bar. Also, once you
selected time-picker wrapper span, there was no way to open the overlay
via keyboard.
Issue Number: N/A
What is the new behavior?
Tabbing away from overlay now focuses on time-picker
wrapper span. Pressing enter on the wrapper span opens the overlay.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
The behavior (both current and new) can be observed on the main demo page (npm run site:start).

Hi @jimmytheneutrino , we're very grateful for your work! It would be better to provide the actual usage scenario for this PR (as i think there is no need to handle the enter key on <input> only, unless we provide the full set of keyboard processing mechanisms such as "left/right arrow to select a specified time value").

@wilsoncook
This onEnter is for the case when the user inputs values by hand using digits on the keyboard.
IMHO the user does not need any arrow key bindings when they already can input just digits.

@wilsoncook
Hi! Do you need something else fixed?

@wilsoncook Could you please tell me what else needs to be done?

@jimmytheneutrino Thanks for your PR, this belongs to a11y (#1651) which contains full set of keyboard processing as @wilsoncook said, not just OnEnter. It will be helpful that if you provide a full solution of this component.

@wenqi73 @wilsoncook
I understand that the full a11y solution would be preferable. Unfortunately, this seems to be a large task and I do not have time to do all of its nuances.
However, isn't a partial improvement better than no improvement? Please see the videos:
https://imgur.com/a/IhI9R6i .
I think that just this little bit could be a huge improvement in usability for some users.

@wenqi73 plz check this again

As there is no update for a long time, the PR will be closed.
If you have any questions, feel free to open another PR, thanks a lot.


rememberStep doesn't seem to be working?

I've checked the activeStep property and it's updating but not stored on localStorage. Should I call anything aside from .start()?
PS: Also isFinished() when called on onAfterExit() always returns false.
Thanks!

Hey if you could check again with latest version 0.0.10 on NPM and let me know if still encountering the issue. Thanks

Closing due to inactivity.


Dep ensure not installing the dependencies in Gopkg.toml

What version of dep are you using (dep version)?

$ dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.9.1
 go compiler : gc
 platform    : darwin/amd64`

What dep command did you run?
dep ensure

$dep ensure -add github.com/braintree/manners
Fetching sources...

"github.com/braintree/manners" is not imported by your project, and has been temporarily added to Gopkg.lock and vendor/.
 It threw a warning saying the package would be removed if I did a dep ensure without importing the package.
I imported the package in my code and ran dep ensure again.
dep status says it has the package installed. But the package is missing in the vendor directory.

hi, welcome! sorry you ran into this.
this is a bit odd. could you provide the output of dep hash-inputs?

dep hash-inputs                                                                                ruby-2.2.0@helpkit
-CONSTRAINTS-
github.com/braintree/manners
svc-^0.4.0
github.com/cihub/seelog
svc-~2.6.0
github.com/dgrijalva/jwt-go
svc-~3.1.0
github.com/go-redis/redis
svc-~6.7.3
github.com/gocql/gocql
r-33a5f3c1bcc2c421b3221c5858312afb141bf605
github.com/hashicorp/golang-lru
r-0a025b7e63adc15a622f29b0b2c4c3848243bbf6
github.com/julienschmidt/httprouter
svc-~1.1.0
github.com/orcaman/concurrent-map
r-d4c23bd0e01134806215ffe65ba3fd22ec6721f7
github.com/urfave/negroni
svc-^0.3.0
github.com/vmihailenco/msgpack
svc-~3.2.0
-IMPORTS/REQS-
github.com/braintree/manners
github.com/cihub/seelog
github.com/dgrijalva/jwt-go
github.com/go-redis/redis
github.com/gocql/gocql
github.com/hashicorp/golang-lru
github.com/julienschmidt/httprouter
github.com/orcaman/concurrent-map
github.com/spf13/viper
github.com/urfave/negroni
github.com/vmihailenco/msgpack
-IGNORES-
-OVERRIDES-
-ANALYZER-
dep
1

Its weird. I see the package now after running dep hash-inputs.
Not sure what happened.

hmm, dep hash-inputs is a read-only operation, so that shouldn't have changed anything.
are you able to reproduce the original problem from scratch?

No. I'm unable to reproduce it now. Will close this for now.
Thanks

I am facing the same issue.
$ dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.9.1
 go compiler : gc
 platform    : darwin/amd64

In Homebrew the version of dep is 0.3.2
$ dep status
PROJECT                           CONSTRAINT     VERSION        REVISION  LATEST   PKGS USED
github.com/gorilla/websocket      ^1.2.0         v1.2.0         ea4d1f6   ea4d1f6  1
github.com/streadway/amqp         branch master  branch master  ff791c2   ff791c2  1
gopkg.in/natefinch/lumberjack.v2  ^2.1.0         v2.1           a96e638   a96e638  1

$ dep hash-inputs
-CONSTRAINTS-
github.com/gorilla/websocket
svc-^1.2.0
github.com/streadway/amqp
b-master
gopkg.in/natefinch/lumberjack.v2
svc-^2.1.0
-IMPORTS/REQS-
github.com/gorilla/websocket
github.com/streadway/amqp
gopkg.in/natefinch/lumberjack.v2
-IGNORES-
-OVERRIDES-
-ANALYZER-
dep
1

$ dep ensure

The package github.com/streadway/amqp is not being fetched in the vendor directory.

So I start to see the package too after few minutes. Maybe the package is just taking time to get downloaded? Does ensure not wait until the download is over?

@vaibhav-sinha dep is pretty powerful, but it's not magical enough to do things when the process isn't running 😄
if you still have the terminal history, that'd help to figure out how you ran into this. the only known hole through which this should be able to occur is if you manually delete something out of your vendor directory - dep sometimes won't repopulate it if Gopkg.lock is already in sync, unless you run dep ensure -vendor-only.
we've chosen to leave that hole in place temporarily while we work on #121, because the alternative would entail absolutely always unconditionally repopulating vendor completely on every dep ensure run.

I ran into a similar issue and found that deleting my vendor directory and running 'dep ensure' retrieved the missing package. Unfortunately I don't have steps to reproduce. I've run into the issue before and will be more diligent recording the steps next time.
Otherwise solid tool, very grateful to the devs/maintainers!

I faced the same issue. Deleting the vendor directory and then running dep ensure worked but I'm not sure what caused it.


OpenGL Errors With Immersive Vehicles

Immersive Vehicles (MTS) dev here.  Just got though debugging a Stack Overflow error that was affecting one of my users, and from what we could figure out, it's due to some sort of incompatibility between our two mods.  Best I can tell, somewhere an additional RenderPlayerEvent.Pre event is being called, which results in two Pre events but only one Post event.  Not entirely sure where this might be, but I'd like for us to be able to get together and figure out how to have our mods play nice.
Relevant issue is: https://github.com/DonBruce64/MinecraftTransportSimulator/issues/95
Relevant MTS code section is: https://github.com/DonBruce64/MinecraftTransportSimulator/blob/061d84214fc9f417a5c09d6c18013737b9ceca57/main/java/minecrafttransportsimulator/systems/ClientEventSystem.java#L270

Hey, thanks for reaching out to me 🙂. I can only guess that the additional RenderPlayerEvent.Pre event is being called due to the system I used in the latest official Mo' Bends releases. I basically cancelled the rendering of the player during the event, and called my own renderer.
I since changed the system, which instead of replacing the vanilla model, mutates it, so as of the yet unreleased version of the mod it should play nice. If you'd like to test out the current unreleased version of the mod, you're more than welcome to join our Discord server 😄. We've got a bunch of great modders on board, would love it if you could join in as well!
https://discordapp.com/invite/Epf7atm

Can-do!  Am I allowed to distribute the un-released version to the user who is having the issue?  I only have contact with them on GitHub, so I'd have to post a download in the issue itself.  Not sure if that's something you would want done or not.

I usually try to not release test versions to the public, since I don't want to spread unofficial versions to the target audience, since they may not understand the concept of "test version". If you're able to share it privately, that would be preferable. If not, I don't think it would be that much of a problem 😄.

No worries.  I'll just see if the user can get it themselves.  Would be easier for all, plus since he's the one with the issue, he'll be a better source for feedback than me.  Mentioning this issue on my end so he sees it.

Just got a response from the user.  They say that your new test build does indeed fix their problem, so it appears that once it drops as a final release this bug will go away.  I'll keep the issue open on my end until the final release drops for tracking purposes, so if you could let me know when it does so I can close out the issue, I'd appreciate it.


Higher bitrate?

Hello! Maybe I dont know how to use it, but Im not getting the highest bitrate.
Thats the highest i get: Bit rate: 1 121 kb/s . I already checked "Automatically select best bitrate available"
Thats from Last kids on earth s03e10

turn off vp9 from extension options you will get 1734

turn off vp9 from extension options you will get 1734

Thanks, it worked.

Thanks, it worked.

If everything is sorted out, I will close this issue now. I would also like to point out, that this repo has the new Discussions feature enabled, which is perfect for these kind of non-bugreport support questions.

If everything is sorted out, I will close this issue now. I would also like to point out, that this repo has the new Discussions feature enabled, which is perfect for these kind of non-bugreport support questions.


Unstable behaviour when setting a relationship between 2 objects of 2 different EpcDocument

For example, try to use
AbstractProperty::void setRepresentation(class AbstractRepresentation * rep);
on a property belonging to EpcDocument A
with a representation belonging to EpcDocument B

It looks using AbstractProperty::void setRepresentation(class AbstractRepresentation * rep); regarding 2 objects of 2 different EpcDocument has a different behaviour between Linux and Windows.

EpcDocument has been changed into DataObjectRepository.
It is not more intended to be able to set relationships across DataObjectRepositories.


Pixelmon Reforge isn't opening on Technic.

I've been trying to get on just to keep my claims but ever time i get on it's giving me an error saying something is missing. I took a screen shot of it and posted it in the wrong discord.. (Opps), and thought i'd just post here for now. I've tried reinstalling the mod multiple times with the same error showing up.

Not sure what could be causing that on Technic, but have you tried our specific pack on Technic? Apex Pixelmon. You could also use AT Launcher to download the official pixelmon pack.

ill have to find them then. I haven't tried them before because Technic worked so well with me.

https://www.technicpack.net/modpack/apex-pixelmon-reforged.1449772
https://atlauncher.com/downloads

well the other technic pack did the same thing, Im gonna try the atlauncher now.

ATLauncher worked just fine, thank you!


Sending Messages from Parent to IFrames seems to not work

Hi,
I have a child page running at localhost:8080/apps/child.html, as below.
<!DOCTYPE html>

I have a parent page where the child is included in an iFrame.
<!DOCTYPE html>

The scenario is simple, when thebutton testIFrame is clicked, it triggers the sendMessage() method which post the getUser to the Iframe.
    let poFrame=document.getElementsByTagName("iframe")[0]
    let poAppSpot=poFrame.contentWindow.parent // tried with .top as well.

This results in an error No handler found for post message: getUser from http://localhost:8080 in http://localhost:8080/apps/index.html.
Testing in Chrome Version 90.0.4430.212
Do let me know what I am missing as I can't find documentation with regards to sending to iframe.

Instead of let poAppSpot=poFrame.contentWindow.parent just try let poAppSpot=poFrame.contentWindow


[Feature Request] Support push metrics to Prometheus Pushgateway

The push mode will be more convenient and more real-time. We have implemented it. If necessary, I will create a PR

Why will the push mode be more convenient and more real-time? Could you give some examples?

1.We need install node exporter in every host, and if not, real-time performance cannot be ensured.
2.We need change the configration of node exporter after we add an instance.

1.We need install node exporter in every host, and if not, real-time performance cannot be ensured.
2.We need change the configration of node exporter after we add an instance.

In our production environment, we use crontab to fetch the servers' metrics every minute and push the metrics to our prometheus server. I don't get the difference if we use exporter.

This depends on operation and maintenance. If automation tools is well, it may not be inconvenient.

@jerqi Can you share how do you collect metrics in your k8s cluster?

@jerqi Can you share how do you collect metrics in your k8s cluster?

We plan to use a k8s sidecar to collect the metrics.

I think we should support export metrics, like hadoop,hbase etc. Users can implement custom export plugin to export metrics to their monitoring system. WDYT? @jerqi

I think we should support export metrics, like hadoop,hbase etc. Users can implement custom export plugin to export metrics to their monitoring system. WDYT? @jerqi

I'm not familiar with this aspect. If other mature systems have this , I think it will be ok for me. @zuston Do you have some suggestion?

The similar mechanism is supported by other systems, like Flink: https://nightlies.apache.org/flink/flink-docs-release-1.13/docs/deployment/metric_reporters/
I think this is a good improvement of observability

Let's reopen this?

Let's reopen this?

OK.

Should we have a concept of MetricsReporter refer to Flink first?


Add rating back to feed with fake data

To keep existing clients from breaking.

Pranav, weren't you already doing this (or is this already complete?)

Fixed in changeset 116ab4961649c5be0d14d164f885ededb2274361


fix(obstacle_avoidance_planner): deal with wider path interval (#1616)

fix(obstacle_avoidance_planner): deal with wider path interval

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>port universe's main bug fix commit to x1 release branch
https://github.com/autowarefoundation/autoware.universe/pull/1616
ticket
https://tier4.atlassian.net/browse/T4PB-22568

@YoheiMishina Is this PR okay not to be merged?

LGTM.
However We would like to merge beta/v3.2.0(pilot-auto).
Let me check which branch I should put it in.

@YoheiMishina @takayuki5168
Change base branch to beta/v3.2.0 and merge.


Un-hide "UserTokenBuilder::set_csrf" from docs

This may be me misunderstanding how to use this lib, or not seeing the obviously correct solution, but right now I do not see a good solution to implement a  authorization code flow in a server scenario without either keeping a map of active user session => UserTokenBuilder  around, or storing the generated CSRF secret for a session, and re-creating the UserTokenBuilder  and calling set_csrf  when the redirect comes in.
What is the suggested way to implement this right now? Since set_csrf is doc(hidden) with a comment that we should preferably not use this, I assume its keeping the actual UserTokenBuilder in memory and "find it" so we have it around when the response comes in. This would - imho - be more complex than just serializing the CSRF token in a (encrypted & signed) cookie and reading that from the redirected response again. The UserTokenBuilder::generate_url method even returns the CSRF token which makes this pretty easy. I am getting mixed messages here ;)
Am I missing something obvious?
For me,  right now, it seems like set_csrf  should be displayed in the docs, or we need a UserTokenBuilder::new_with_csrf  constructor that also accepts a pre-existing CSRF token (how to handle that in generate_url? Guess that is the reason for hiding set_csrf?).

I think it would be ok to unhide it, there's no real reason for the library to hide it.


fix urls

Problem
refreshing doesn't reopen last location / tabs
Changes

updated how router is used in FE

https://user-images.githubusercontent.com/445122/194516590-096a5864-3599-433c-9764-88772e3958d3.mp4

Main branch dependencies

Neodora Analysis ⚠
 ⚠ Bad use of docker image

Message: Only pipedrive base images must be used
File: Dockerfile.CI
Actual image:
node:16-alpine

🔍 How to fix it

Commit 101046a  Job 90718


Use descriptor, not metadata, to stay close to spec semantics.

Fixes #88.
@vitorbaptista @roll @amercader @akariv for review.

Coverage remained the same at 98.991% when pulling 4371e22746dcf39cda9ff7731a9e29529d919cd8 on feature/descriptor-not-metadata into f5cc6b92bb9138ddda293d8d3884ede2288a08cc on master.

@pwalsh
looks good for me

also I've found metadata term in registry code - I'm not sure should it be also replaces
version could be bumped to 0.7.0 inside the PR if you prefer to release

@roll i left the registry stuff on purpose.

Looks good to me as well, but I was thinking: does a "resource's descriptor" make sense? We use this term for the datapackage itself, but am not sure if we use it for resources as well.
Even if not, I don't like using descriptor for the datapackage and metadata for the resources.

@vitorbaptista yes, it does. I get your point, but resource as a concept to contain data + schema (int he tabular data case) is increasingly emerging as one of the most useful aspects of the spec work, to the point that we'll likely also start describing a "resource object" as either a spec, or a "pattern" ( cc @rgrp )

@pwalsh In that case, I'm happy to merge this. We will probably need to update ckanext-datapackager as well when a new version is published with these changes.


AS3 auto-testing is complete

AS3 auto-testing is complete

LGTM -  only thing I saw that was a little concerning, which wasn't a deal breaker was that your commit for  01c4ede  - was titled  as a Reworking of AS3 Http,  however there were tuns of other changes in this commit that were not even related to the Http reworking, so a little better separation of commits would have been nice.  or a better comment to describe the changes.


Added navbar to index.html with required CSS and JS

Related Issue
Issue No.: [#242 ]
Email ID used to register for VSoc'24
Email ID<EMAIL_ADDRESS>Description
I have designed a navbar as per your requirements. It features a sleek and classy look, providing an extraordinary visual experience. The text '50 Days, 50 Web Projects' has been replaced with a logo image, which is customized with hover and other effects using CSS to enhance its interactivity. Please find the attached video showcasing the design and its functionality.
Type of PR

[ ] Bug fix
[X] Feature enhancement
[X] Documentation update
[ ] Security enhancement
[ ] Other (specify): _______________

Screenshots / Videos (if applicable)
https://github.com/dhairyagothi/50_days_50_web_project/assets/136626840/52d24ea9-7433-416b-a452-e21f6886995d
Checklist

[X] I have performed a self-review of my code.
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have followed the code style guidelines of this project.
[X] I have checked for any existing open issues that my pull request may address.
[X] I have ensured that my changes do not break any existing functionality.
[X] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[X] I have read the resources for guidance listed below.
[X] I have followed security best practices in my code changes.

Additional Context
I have designed a logo and created the navbar as per your requirements. The logo replaces the text '50 Days, 50 Web Projects,' and the navbar includes customized hover and other effects using CSS to enhance its interactivity.

done @atharva012004


Adding required field: role_arn

I'm getting the following error while running the previous version:
Error: module.dynamodb_autoscaler.aws_appautoscaling_target.read_target: "role_arn": required field is not set
Error: module.dynamodb_autoscaler.aws_appautoscaling_target.write_target: "role_arn": required field is not set

My fault, I was using an older version of aws provider (1.2)

Great! Glad you figured it out.


Can't change setState

db.find({title:data.title}, function (err, result) { 			this.setState({colorBar:'red'}); 		});
the error this.setState is not a function.

It is not related to this package.
You could also save a reference to this; or use arrow functions; or user bind;
Please, see: http://stackoverflow.com/questions/31045716/react-this-setstate-is-not-a-function

{ this.setState({colorBar:'red'}); }.bind(this)
that's mean you bind the inner function


[Dashboard] Hide slice titles when they're empty

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
After https://github.com/apache/incubator-superset/pull/7084 slices can no longer have whitespace as a name. This means that there's no way to remove the title from a slice in a dashboard. This PR removes the <empty> text from a slice when viewing it in a dashboard.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

View slices with and without titles in dashboards. See titles when not set to NULL, but see no titles when the slice doesn't have one
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@graceguo-supercat @john-bodley @kristw

Codecov Report

Merging #8018 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8018   +/-   ##
=======================================
  Coverage   65.58%   65.58%
=======================================
  Files         469      469
  Lines       22461    22461
  Branches     2438     2438
=======================================
  Hits        14730    14730
  Misses       7611     7611
  Partials      120      120

Impacted Files
Coverage Δ

...et/assets/src/dashboard/components/SliceHeader.jsx
24% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebffe0...05d97df. Read the comment docs.

Oh wait, we need to make sure there's an easy way to edit (currently you'd click on the <empty> text) in the explore view when the text is empty. Different handling of the empty text for dashboard and explore?

@etr2460 How to make slice title in dashboard is hidden but in chart list view it has the title?


refactor code to use encoding methods in encoder.ts

Refactor the entire codebase to use encoding methods in encoder.ts as opposed to directly referencing underlying dependencies/libraries. This allows us swap out implementation if needed.
See example usage in signer.ts

Hi again could i get a little explanation on how this could be carried out as well

to be more specific the files that would need to be refactored

#115 attempts to tackle this issue

@Cxxshyy, thanks for the contribution!! What you did is exactly what the issue was intended. There is still the replacement for new TextEncoder().encode(...) occurrences, but did not hold #115 for it, approved and merged it.

like i said before i'll take a look tomorrow at this encoder

@thehenrytsai pr #116 looks to implement a new feature and hopefully solves the new TextEncoder().encode(...) occurrences issue


browse: delete duplicate -closing tags in default template

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thank you!


[Login-Signup backend service setup] npm install and npm start errors

git cloned and git checkout to the right branch, then ran npm install and npm start, got the following errors

EDIT : looks like you forgot to add cd ./travel in your wiki.
Add your commit id here

[ ] Fixed npm install errors.
[ ] Fixed npm start errors.
[ ] Service is up and running.

@KalaRaja Wiki did not specify the file directory you need to go in the last commit. Have updated the wiki for the same.


cli: support show tables statement

we can hint parse error:xxx like other databases.

Actually  this is a PostgreSQL-specific statement SHOW <variable>, not show tables.

Oops, it turns out that only MySQL supports show tables. For Postgres, we can only use \dt to list tables. Therefore, I think it's better to warn users that show xxx is not supported. At the same time, we should not panic in case of such error. We should only show an error on screen.

Oops, it turns out that only MySQL supports show tables. For Postgres, we can only use \dt to list tables. Therefore, I think it's better to warn users that show xxx is not supported. At the same time, we should not panic in case of such error. We should only show an error on screen.

good idea


[SPARK-33591][SQL][3.0] Recognize null in partition spec values

What changes were proposed in this pull request?

Recognize null while parsing partition specs, and put null instead of "null" as partition values.
For V1 catalog: replace null by __HIVE_DEFAULT_PARTITION__.

Why are the changes needed?
Currently, null in partition specs is recognized as the "null" string which could lead to incorrect results, for example:
spark-sql> CREATE TABLE tbl5 (col1 INT, p1 STRING) USING PARQUET PARTITIONED BY (p1);
spark-sql> INSERT INTO TABLE tbl5 PARTITION (p1 = null) SELECT 0;
spark-sql> SELECT isnull(p1) FROM tbl5;
false

Even we inserted a row to the partition with the null value, the resulted table doesn't contain null.
Does this PR introduce any user-facing change?
Yes. After the changes, the example above works as expected:
spark-sql> SELECT isnull(p1) FROM tbl5;
true

How was this patch tested?
By running the affected test suites:
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *SQLQuerySuite"
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *CatalogedDDLSuite"

Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Wenchen Fan<EMAIL_ADDRESS>(cherry picked from commit 157b72ac9fa0057d5fd6d7ed52a6c4b22ebd1dfc)
Signed-off-by: Max Gekk<EMAIL_ADDRESS>

Test build #133849 has started for PR 31095 at commit 4fef8be.

Test build #133849 has started for PR 31095 at commit 4fef8be.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38438/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38438/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38438/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38438/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38438/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38438/

Test build #133849 has finished for PR 31095 at commit 4fef8be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133849 has finished for PR 31095 at commit 4fef8be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133849/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133849/

thanks, merging to  3.0!

thanks, merging to  3.0!


WIP: Generalize building of Elixir interpreter

Motivation for this change
This is a continuation of #26381 based on #17240
This only includes Elixir generalization. It also includes derivations for Elixir 1.3 and 1.4
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

/cc @gleber, @LnL7, @ericbmerritt, @yurrriq

Nice! This was my next step, thanks for doing it! :)

Glad I could help. I can also take a crack at LFE if you would prefer?

#26668 should be merged before this. Once it is, I will need to make a couple modifications.

Current state of PR built successfully built on NixOS with sandboxes:
$ nix-shell -p nox --run "nox-review pr 26668"
...
 Results for this PR are also positive:
$ nix-shell -p nox --run "nox-review pr 26716"
...
Result in /run/user/1000/nox-review-bmd3mwgi
total 0
lrwxrwxrwx 1 gleber users 57 Jun 19 20:36 result -> /nix/store/lvx8d5cw7nm3780ahw0gvi4h74hj12qf-hex2nix-0.0.5
lrwxrwxrwx 1 gleber users 56 Jun 19 20:36 result-2 -> /nix/store/jizvhrng4p4wqk3wdagr74d8fqavs8vl-elixir-1.4.4

@ankhers my previous work on LFE might be helpful if you do. There should be a link on the old generalized Erlang PR. Please don't update to 1.3.0 in the process because there are some known issues and we're waiting on 1.3.1.

@yurrriq Noted. Do you have any idea how long until 1.3.1 will be released?

@rvirding has identified the problem and is working on a fix, but I'm not sure about the timeline.

I just did a rebase from master. Unfortunately I do not seem to have Elixir being built for different version of Erlang. nix-shell -A beam.packages.erlangR18.elixir and nix-shell -A beam.packages.erlangR19.elixir both seem to be using R18.

I fixed the issue with the incorrect Erlang version being loaded for Elixir. I am not sure if this is the best solution or not.
I am running nix-build -A beam.packages.erlangR19.elixir-1_3 . and it is building Elixir 1.3 for me (I tested to make sure I was getting the proper version). When I run nix-shell -A beam.packakges.erlangR19.elixir-1_3 . I seem to get Elixir 1.4.

And today I am receiving the following error when trying to build Elixir with R19
Uncaught error in rebar_core: {'EXIT',
                               {undef,
                                [{crypto,start,[],[]},
                                 {rebar,run_aux,2,
                                  [{file,"src/rebar.erl"},{line,165}]},
                                 {rebar,main,1,
                                  [{file,"src/rebar.erl"},{line,58}]},
                                 {escript,run,2,
                                  [{file,"escript.erl"},{line,757}]},
                                 {escript,start,1,
                                  [{file,"escript.erl"},{line,277}]},
                                 {init,start_it,1,[]},
                                 {init,start_em,1,[]}]}}

=ERROR REPORT==== 23-Jun-2017::15:23:46 ===
Unable to load crypto library. Failed with error:
"bad_lib, Library version (2.11) not compatible (with 2.10)."
OpenSSL might not be installed on this system.
make: *** [Makefile:68: erlang] Error 1

I will look into it a little bit later.

The various Elixir versions build with the given erlang versions.
If anyone knows of a way to have the erlang and rebar packages that are in scope be passed into the generic builder instead of having to specify for each one, I would appreciate the help.

@0xABAB, or anyone else. Would it be possible to get clarification on the last review?


plot/vs draws lines between points

Reported by sirott on 23 Dec 2001 01:54 UTC
The plot/vs command now (as of v5.33) connects all points with lines. v5.22
doesn't have this problem. This occurred in both the linux and solaris versions.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/351

Comment by<EMAIL_ADDRESS>on 21 Oct 2003 20:15 UTC
Moving from the<EMAIL_ADDRESS>user to the<EMAIL_ADDRESS>user.


Sorting indicators does not update when using React.memo

Describe the bug (required)
When React.memo is used to render the columns/headers, the sorting booleans, does not trigger a re-render.
Provide an example via Codesandbox! (required)
https://codesandbox.io/s/quizzical-feynman-f2y8l?file=/pages/index.js
Steps To Reproduce (required)
Try to sort using the codesandbox above.
Expected behavior (Recommended)
It should trigger a re-render.
Desktop (please complete the following information):

OS: [e.g. iOS] MacOS
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] 87+

Additional context
Use the code that is commented out to see a working version.

React.memo uses shallowEquals unless told otherwise and is supposed to stop rerenders, this is working as intended

also unrelated to react-table

@datner Hey, sure. Whats the fix then? I am forced to use memo to stop huge amount of re-renders.

Try to change the diff function, for more in-depth help ask on stack overflow or something, sorry

Found a workaround. First of all even though you would use table instance state it would not be useful, because it is mutated as well. So in stateReducer I added a setter for component state. It gives me immutable state which I can use in memo equality callback.
For more explanation here is codesandbox: https://codesandbox.io/s/eloquent-dream-516xnl?file=/src/App.js

The same thing happens when trying to use memo to speed up rendering of table rows.
React Table's row selection breaks when a table row is memoized.
https://codesandbox.io/s/eloquent-dream-516xnl?file=/src/App.js
This is a major performance issue. If I remove memo() the onScroll re-renders in my app go from 22-28ms to 80-120ms. The scroll re-renders in question being triggered by TanStack's own react-virtual.
React Table should not be re-using and mutating the row object when it when it has changed, and assuming that table components are not memoized for performance. This is fundamental to react, if this is intended behaviour then react-table is wrong. Beyond performance I understand there's also the possibility that examples like Sub Components (Lazy) and others that use extra components could encounter tearing in concurrent mode due to row being mutated during render.
It feels quite absurd that the React Table docs say:

It's important that we're using React.useMemo here to ensure that our data isn't recreated on every render. If we didn't use React.useMemo, the table would think it was receiving new data on every render and attempt to recalculate a lot of logic every single time. Not cool!

Yet when it comes to memoizing table elements. React Table's intended behaviour that you cannot optimize element rendering for the exact same reason.


[Breadcrumb] Change last item for TextBlock

Changes the last item visual for a TextBlock
Description
Adds an extra TextBlock item that is only shown when the element is the last item, that way we avoid changing between the different visual states as well as raising click events
Motivation and Context
VSO: 32191841
How Has This Been Tested?
Not tested but perhaps may break some tests, have to verify tests
Screenshots (if appropriate):

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run


fixes #33

Coverage remained the same at 100.0% when pulling a4919749047a7d834d06bf35a2b7458b8d8befa8 on stdin into fe700213998a5ab7576621c7e722fb4ae8c343cd on master.


[Feature] Show direction in which the mouse cursor is moving

Example: https://www.youtube.com/watch?v=F1bazIjJ2xw

I think I replied this, but I didn't, so I reply now.
I don't think this is necessary, if you are streaming or recording with it, you probably already record your cursor, this program is for the problem that watchers cannot see your modifier keys.
And your example, it's a gaming video, AFAIK most gaming streamers use OBS plugin for it, and I think the video also uses OBS plugin. If you want to use this program for gaming, I suggest not. When you play games you want best performance and then game takes full screen, prevents compositor redirect, so no window can be above your game, and this program just cannot show, it's a floating window, requests compositor redirect.
That's why you should use OBS plugins for game, they are running inside OBS Studio, directly into your video stream, not your desktop compositor.


Instancing crash

Trigger condition seems to be:

On every frame:

Render a vertex buffer without instancing
Render same buffer with instancing

Then, after doing this for a few frames, submit an empty frame.

Modified instancing example to exhibit the crash:
http://pastebin.com/GkEfBRTB

You have to switch program that doesn't expect instancing data, or at least provide 1 instance data.

Thanks. Is this by design or a bug?
Also, just to clarify, does this mean any program that declares i_data vars in its varying.def.sc requires instance data to be submitted every frame?
If so, what about hardware with no instancing support? Is it safe to still declare instance data inputs in a shader on that hardware? Or do I need to write a different shader with no reference to instancing at all?

You can declare it, but if you use it (if you read i_data values), hardware has to support it.

You have to have alternative shader, you can check support by caps flags:
https://github.com/bkaradzic/bgfx/blob/master/examples/05-instancing/instancing.cpp#L145

I'm turning instancing on and off with a uniform. When off, the shader doesn't read any i_data variables. Is this supported?
Sorry for the repeated questions, I just need to know what exactly my app is doing that is against bgfx's contract.

Not sure, probably not, but I never tried that. If driver converts program to be branchless then both branches are taken, and result is just masked. My suggestion is, if you care your stuff works on HW that doesn't have instancing (this is like 10+ and older GPUs) would be to ignore whole instancing completely.