Consider exposing wallet commands as an API

Currently, the entire wallet interaction goes through CLI commands. A client application is not capable of creating a transaction, getting balance and so on.
An example: To enable test-harness, rpc package is calling cli.SendBidTx directly as a temporary patch.
Proposal:
Wallet commands can be moved to a separate package so that both CLI and RPC  packages can use them via RPCBus.
Other option could be to deprecated CLI entirely and build RPC API only for interaction with the wallet.
Let me know your thoughts on that.
@julesdesmit @autholykos

I've been working on something similar for #27, it currently features a Transactor process which other components can invoke through event bus calls, to construct and propagate transactions.
I'm still working out the details, I was debating maybe to remove the event bus from the equation and instead just passing it around, or instantiating it in the components which need this, as there's no advantage (as far as I could tell) for this component to really be asynchronous, or decoupled as such. If it were decoupled, it would need the RPCBus for balance calls, which I would rather avoid as it would (needlessly) complicate the design and the tests (for one, the timeout would be variable since we can't infer how long the sync would take).
Other than that, the name needs a change because Transactor is not really a proper name as it also syncs the wallet and checks the balance, but again, still working out the details. :)

it currently features a Transactor process which other components can invoke through event bus calls, to construct and propagate transactions.

It' would be good to allow retrieving result from the wallet command executing. E.g When sending a tx, a client would need the txid or error as an output. Eventbus between producer and consumer wouldn't handle this easily.

passing it around, or instantiating it in the components which need this
Could be. Maybe in that case we'll need to protect both walletDB and wallet.dat from simultaneous reads/writes

(for one, the timeout would be variable since we can't infer how long the sync would take)

Do we really need syncing to be performed on each wallet command? I assume long syncing make sense on loading a wallet for the first time but once loaded, the walletDB can be re-synced automatically on acceptedBlock event

It' would be good to allow retrieving result from the wallet command executing. E.g When sending a tx, a client would need the txid or error as an output. Eventbus between producer and consumer wouldn't handle this easily.

Agreed, also part of the reason why I was debating removing the event bus from this process and instead just creating a struct with the proper methods and return values.

Maybe in that case we'll need to protect both walletDB and wallet.dat from simultaneous reads/writes

wallet.dat would be fine, we should check for walletDB though. wallet.dat only contains the bytes for a seed. walletDB could be in trouble if two components sync simultaneously, so a simple mutex would get rid of that issue.

Do we really need syncing to be performed on each wallet command?

Yes. Unless we are synced before doing any action, we can not guarantee we are retrieving unspent outputs, and we can not guarantee a proper balance either.

the walletDB can be re-synced automatically on acceptedBlock event

Possible, but again it makes things a bit more complex than they need to be. If the Transactor is owned by whatever component needs it, it would be a lot simpler to just sync whenever any method is called on it.

wallet.dat would be fine, we should check for walletDB though

Regarding the wallet.dat, I meant the case where createWalletCMD is used by different go-routines. Then, some synchronization might be needed.

Possible, but again it makes things a bit more complex than they need to be. If the Transactor is owned by whatever component needs it, it would be a lot simpler to just sync whenever any method is called on it.

Not sure what you mean by complex as we've got many components collecting acceptBlock already. Note that if sending a transaction is delayed by minutes because of scanning blocks/txs for the past week, this might be obstacle in some situations.

Regarding the wallet.dat, I meant the case where createWalletCMD is used by different go-routines. Then, some synchronization might be needed.

createWalletCMD would still be something only the CLI can do. The Transactor would just create transactions after a wallet is loaded. It can then be passed around for all components to be using the same wallet.

Not sure what you mean by complex

The Transactor would need to be hooked up with an acceptedBlockChan and needs a goroutine to listen for it. This can be done, but it would be simpler to just have it done on the method call as it involves no extra wiring of channels and no extra goroutine, hence extra complexity.

Note that if sending a transaction is delayed by minutes because of scanning blocks/txs for the past week, this might be obstacle in some situations.

Like we do currently, printing the sync progress could do just fine, as it provides feedback about why it is taking a while. As far as E2E testing goes, I do not assume we are going to have to sync a ridiculous amount of blocks, so it should not slow down testing.
I do also see the positives of syncing it on each accepted block, but I would rather keep things simple for now. Regardless, this isn't a big point of contention for me, if you think it would be greatly advantageous to go with that route, then we can go for it.

Up to you! My wish is that we can provide instant transactions with guaranteed confirmation time, if that makes sense.


Change of API permission on atlassian => which permission to select instead?

Api of confluence just change today apparently. which permission are required now?
Those didn't work

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ede08aa-7a5b-9566-1372-32f533c3cda3
Version Independent ID: 674e409b-7ce6-3366-c559-0fd63bd41c59
Content: Confluence Cloud Graph connector for Microsoft Search
Content Source: MicrosoftSearch/confluence-cloud-connector.md
Service: mssearch
GitHub Login: @TheKarthikeyan
Microsoft Alias: kam1

@Bvanderstraeten In which version of Confluence you are seeing this?

On confluence cloud. I follow the documentation on saturday but it was not working, and this monday, on the développer app of atlassian, it state that the old api were deprecated and that I need to change permission and that the call back URL had to be changed
Regard

From: Karthikeyan M @.>
Sent: Thursday, January 27, 2022 9:26:54 AM
To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.>
Cc: Brice Vanderstraeten @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Change of API permission on atlassian => which permission to select instead? (Issue #222)
@Bvanderstraetenhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBvanderstraeten&data=04|01||5847be1bd11d4dcc851508d9e16ec772|6792afc2362e403bb394f5ba78e99373|0|0|637788688248022801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=O8LLhpKtxKw8n8ozLR1vJNDz4PbFBlD%2FDQn9CAoAqqw%3D&reserved=0 In which version of Confluence you are seeing this?
—
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-MicrosoftSearch%2Fissues%2F222%23issuecomment-1022962082&data=04|01||5847be1bd11d4dcc851508d9e16ec772|6792afc2362e403bb394f5ba78e99373|0|0|637788688248022801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=F%2B3%2BpfPccsvhTnfnKjUlzxO%2BnA%2BBGXks0osHIL6kiXA%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP4B5HLNVBYLLKDSZRMP24TUYD6U5ANCNFSM5MYLJ6SQ&data=04|01||5847be1bd11d4dcc851508d9e16ec772|6792afc2362e403bb394f5ba78e99373|0|0|637788688248022801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rSKT%2Bz8d6kix2luN3%2F2wlBjo1dIpwhpLSblH5Msv%2FzI%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||5847be1bd11d4dcc851508d9e16ec772|6792afc2362e403bb394f5ba78e99373|0|0|637788688248022801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=xe054L8act9lnH7YvGV5OSCd4R%2F2Z8IDh5rmNaES43M%3D&reserved=0 or Androidhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||5847be1bd11d4dcc851508d9e16ec772|6792afc2362e403bb394f5ba78e99373|0|0|637788688248022801|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=t9K1T42D93P1uDrGroseg5LGcu9qlrJrACgCWFp66W0%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>
[https://webfiles.eortc.org/signature/eortc-logo-60years.jpg]
Disclaimerhttp://www.eortc.org/email-disclaimer        |      Privacy Policy https://www.eortc.org/privacy-policy/  [https://webfiles.eortc.org/signature/sig-twitter.png] https://twitter.com/EORTC      [https://webfiles.eortc.org/signature/sig-facebook.png] https://www.facebook.com/EORTC-1475078969460195       [https://webfiles.eortc.org/signature/sig-linkedin.png] https://www.linkedin.com/company/eortc

@Bvanderstraeten could you please share the link to the API deprecation announcement?
Thanks,

I didn't find any annoncement. Today it roll back to another interface in the permission  of atlassian, probably a glitch or an upcoming change.
Still didn't work (but work well for Jira)

Please contact Atlassian support for help.


adding -Wno-inconsistent-missing-override to avoid build errors on mac

I was having build errors when building for ARM architecture through this command "scons build/ARM/gem5.opt"
I was receiving the following errors at multiple places -
**overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
**
Ex -
build/ARM/mem/ruby/system/DMASequencer.hh:62:10: error:
'isDeadlockEventScheduled' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
bool isDeadlockEventScheduled() const { return false; }
Some research led me to this http://stackoverflow.com/questions/32626171/xcode-7-how-to-suppress-warning-overrides-a-member-function-but-is-not-marked
I added the flag and here is the pull request.

Hi Arjun,
Thanks for taking an interest in gem5. We currently can't accept pull requests since the git repository is a read-only mirror. See http://www.gem5.org/Submitting_Contributions if you wish to learn how to submit a patch to gem5's review system.
As for the patch, we don't want to disable this particular warning. We might want to consider making it a non-fatal warning. There is a reason for the warning and we should try and fix the problem rather than silencing a useful warning.
Regards,
Andreas


Create ProductTrainingContext and Clean existing tooltips to use a hook

Part of the Migrate Existing Users to NewDot project
Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.mvu5k3qn2ftd
Project:
Feature Description

Create ProductTrainingContext and Clean existing tooltips to use a hook useProductTrainingContext instead of individually rendering tooltips in their respective components.
Existing tooltips in product right now:

Get started tooltip on concirge chat LHN
Rename Saved Search
QuickAction Button: Global Create
Workspace chat - Create "+"

Detailed Implementation https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.vt3o5zhw550v
Issue OwnerCurrent Issue Owner: @ishpaul777

It looks like the latest re-merge of the PR caused https://github.com/Expensify/App/issues/54600


events: Rename realm_bot remove and delete events.

related issue: #15893

Testing Plan: tools/test-backend, /tools/test-js-with-puppeteer, /tools/test-js-with-node

@timabbott @showell can you please give this a look.


TLS Option VersionTLS12 denies TLS1.1 but still allows TLS1.0

Do you want to request a feature or report a bug?

Bug

What did you do?

I use Traefik on our Kubernetes cluster and have deployed an IngressRoute with a TLS option that specifies minVersion: VersionTLS12.
When testing the security of the deployed site on ssllabs.com, I noticed that TLS1.1 is no longer accepted if I specify this option. This is correct.
However, TLS1.0 is still supported. See the outcome of https://www.ssllabs.com/ssltest/analyze.html?d=poc2.jkcencrypt.decosasp.com.
What did you expect to see?
I expected to see that only TLS1.2 and TLS1.3 are supported, and TLS1.1, TLS1.0 and lower not.
What did you see instead?
I see that TLS1.1 is not supported, but TLS1.0 is.
When I don't set any VersionTLS12 at all, then TLS1.1 is supported. This indicates to me that the specified TLS option is actually applied, but that it is just not restricting TLS1.0.
Output of traefik version: (What version of Traefik are you using?)

2.0.2

What is your environment & configuration (arguments, toml, provider, platform, ...)?
My Kubernetes IngressRoute and TLSOption
# minimum TLS1.2
apiVersion: traefik.containo.us/v1alpha1
kind: TLSOption
metadata:
  name: mintls12
  namespace: traefik2
spec:
  minVersion: VersionTLS12
---
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: ingressroutetls
  namespace: poc
spec:
  entryPoints:
    - websecure
  routes:
  - match: Host(`poc2.jkcencrypt.decosasp.com`)
    kind: Rule
    services:
    - name: nginxinternal
      port: 80
  tls:
    certResolver: default
    options:
      name: mintls12
      namespace: traefik2

@jcjwent what the tool is reporting is that clients that do not support SNI are able to connect using TLS1.0.
while that is true, if you use a client without support to SNI you can also connect using TLS 1.1, 1.2 and so on. That is because without the server name Traefik is just returning a 404 with it's default certificate and there is no restriction on TLS version on your default configuration.
You can check that by hitting your service with the ip address using openssl and not specifying a server name:
openssl s_client -tls1 -connect <IP_ADDRESS>:443
To fix that you can set the tls default option to deny clients that do not specify the server name as stated here: https://docs.traefik.io/https/tls/#strict-sni-checking
You can also set the minimum TLS version for the default config as well to affect any request that fails to hit a backend and is answered with the Traefik default certificate.
apiVersion: traefik.containo.us/v1alpha1
kind: TLSOption
metadata:
  name: default
  namespace: default

spec:
  minVersion: VersionTLS12

Hi @jcjwent , is this answer fixing your initial issue?

@ddtmachado Thanks for your answer.
While it looked very promising I'm still stuck. I added the following to my Kubernetes envrionment:
kind: TLSOption
metadata:
  name: default
  namespace: default
spec:
  minVersion: VersionTLS12
  sniStrict: true

But this does not make any difference. If I hit my server by its IP I still see the 404, and the SSLLabs site still reports TLS1.0 is allowed. As if nothing has changed. I also redeployed my Traefik deployment.
My Traefik deployment is deployed in namespace 'traefik2' (while the example adds it in 'default'). Adding the above yml to namespace 'traefik2' does not make a difference. Apart from that, I am almost identical to the Kubernetes & Let's Encrypt walkthrough on https://docs.traefik.io/user-guides/crd-acme/.

Thanks for the feedback @jcjwent !
I just tried and can confirm it.
When setting the default tls options minVersion to VersionTLS12, Traefik will still accept connections from TLSv1 and reply with it's default certificate for unknown server names (SNI).
Also setting sniStrict is only affecting the certificate selection on the router and has no effect on the initial connection, even for unknown SNI's as well.

Thank you @ddtmachado .
So what is the state? Is this a bug?

FYI, we are re-evaluating this issue and the associated behavior to determine if it is considered a bug, or if we should document and describe it (e.g. expected behavior and solution for your requirements)

Thanks @ddtmachado for explanation.
Same problem for me here, even with
  minVersion: VersionTLS12
  sniStrict: true

Traefik still offer TLS 1.0, a non-SNI connection and then the self-signed certificate

Hi @jcjwent @GreyXor ,
Can you try with the 3 following elements?

Using the image traefik:v2.1 ?
Setting a tls option object named default , from the file provider (see below):

Enabling file provider by adding the flag --providers.file.filename=/traefik-dynamic.yml to Traefik Deployment
Mount a file (configmap?) in Traefik pod, to the path /traefik-dynamic.yml, containing the following directive:

tls:
  options:
    default:
      sniStrict: true

Enable Traefik debug logs

And if it does not work, can you provide Traefik's log please?
Side note: it might be easier  if you use the experimental Helm chart: https://github.com/containous/traefik-helm-chart (which should soon become the official one of course)

Side note: related  to https://github.com/containous/traefik/issues/5849#issuecomment-559166453

@dduportal Yes! TLS1.0 is now prohibited. My site scores an A rating now. You're the hero.

@dduportal I confirm it's working for me!

No more non-sni
No more TLS 1.0
No more traefik self-signed certificate

My dynamic_conf.toml
[tls.options]
  [tls.options.TLSOptions]
    minVersion = "VersionTLS12"
    sniStrict = true
  [tls.options.default]
    sniStrict = true


Tasks sometimes ask me for which task to run

In some cases when I execute the default build task (workbench.action.tasks.build), I see a picker asking me for the task to pick. Then after a window reload or restart, this does not happen anymore.
Do we have an understanding of what this is?

was this in the latest insider's today @bpasero ?
same as https://github.com/microsoft/vscode/issues/183989
having a hard time reproducing

@meganrogge yes, todays insider. but tbh have seen this for months sporadically. could it be timing related based on extension startup timing?

Do both of you have task reconnection enabled?
And when this happens, do you already have the build task running?
And does the default build task get run?

I think this is related to task reconnection. @roblourens can you repro with that disabled?

I did not even know I could disable task reconnection, but yes I heavily rely on the build tasks showing up again in the status bar when I do a window reload. But when this issue appears, I am quite certain that the build tasks are not showing in the status bar.

/duplicate #183989


refactor: compactify checks flattening

this reduces repetition and increases code locality

Huh, the rules are weird. @wegank now that you seem to have co-authored the commit, your approval isn't good enough any more. Sigh.


Can't place liquids through portals.

https://user-images.githubusercontent.com/72220838/116672981-17439300-a9a3-11eb-8245-99d9da1a8839.mp4

Mod version? Forge version?

Fabric version.
Immersive Portals 0.90-1.16

I can confirm


Trained model generating inaudible samples

Hello,
I have trained a model on LJSpeech 1.1 (downsampled to 16k, verified to be good), using the training scheme outlined in the README.md, with distributed.py for ~800k iterations.
I then attempted to do inference using several checkpoints (10k, 150k, 780k), but all I get is silence.
Here are some samples from the 100k model.
What could be the problem?

What's the training loss at ~800k iterations? It surprises me that it doesn't produce speech.

@ghostcow I trained LJSpeech with down sampling with default config.json with 4 Volta and it converge within 100K training you could use my docker container which I tested. You could reproduce my result using command docker pull hryu/pytorch:t2-2   images which I use. dockerhub  and build nv-wavenet and make python wrapper.

@yhgon Hi I trained a model with your docker image, on my 4 V100 just like you- cloned the code, compiled & built, and trained using only default settings, but the same thing happened again- samples are total silence. were you using some old commit to train? if so what's the diff?
@rafaelvalle The loss can be seen here although this time I only trained til ~400k. It seems to be minimal at about ~200k.
next step i'll try and just train on the arctic voice to see what happens.

Update: I trained with the arctic voice data from the README example and it worked as expected. what does that mean? do I have some problem with my data?
@yhgon can you share your data converting script?

@ghostcow   see closed issue #34
when I check your loss log, it dramatically drop to 0.2 in few iter.   I guess your  input dataset have problem.  below is my loss log for 22khz large (n layer _24) is below..
Initializing Distributed
Epoch: 0
i:      0       lr:     0.001000        red loss:       6.787214756     speed:  1.99 s/it
i:      1       lr:     0.001000        red loss:       6.129778385     speed:  1.00 s/it
i:      2       lr:     0.001000        red loss:       5.762661934     speed:  0.67 s/it

i:      10137   lr:     0.001000        red loss:       2.466446877     speed:  0.66 s/it
i:      10138   lr:     0.001000        red loss:       2.497747183     speed:  0.66 s/it
i:      10139   lr:     0.001000        red loss:       2.445697784     speed:  0.66 s/it
259.00s/epoch
Epoch: 26

Epoch: 52
i:      20280   lr:     0.001000        red loss:       2.131881714     speed:  0.72 s/it
i:      20281   lr:     0.001000        red loss:       2.231127501     speed:  0.66 s/it

So, turns out that I downsampled the wav files incorrectly, and they were saved as floats in range [-1,1] instead of the expected int16s. This apparently broke the training script.
Thanks for the tip @yhgon , I just trained the model on the original sample rate.


chore(ci): add openresty <IP_ADDRESS> to ci matrix

Waiting for <IP_ADDRESS> official release.

Reopen if needed.


Move Offset by 1 when kafka consumer poll error

Coverage decreased (-0.1%) to 28.571% when pulling 3975fd568f354f6079ab39c642cd9362520a4d70 on alyiwang:kafka into a6b726d26c1f05842524bdeaf767aa448b19cad1 on linkedin:master.

Coverage decreased (-0.2%) to 28.545% when pulling 4d4dedfe19b561a9f40c2af12ccd1bfe05d3493d on alyiwang:kafka into a6b726d26c1f05842524bdeaf767aa448b19cad1 on linkedin:master.


kachery-token list should conceal the token strings...

... unless some flag is provided such as --show-tokens or --tokens-visible

Fixed


Embeddings after tiling process

Hello,
Thank you for sharing the code for such a great project.
I am getting embeddings that are not meaningful and I wanted to check if I might be doing something that is not what the model is expecting.
I am running the gigapath tile encoder on tiles that I generated through a custom pipeline where I discard the background and only generate tiles that have enough content. I am testing this on tissue microarrays cores which are relatively small. For example, for one core, after removing background, I end with 14 tiles, each being 512x512.
When I run the tile encoder, after saving the embeddings as pytorch tensors, I get as an output a total of 14 files, summing up to 11 mb. As I remove the background, my coordinates are from the only parts of the images where we have content, for example, I have tiles that start from X: 0 Y: 922, or X: 1383, Y 1383, where many parts of the image are not covered (there was only background in that section).
Then, I run the slide encoder with these images, and I get back, for the whole core, an embedding that when saved as a pytorch tensor is only 42kb.
Is the slide encoder expected to deal with situations with background removal and incomplete coordinates or should I just pass all the tiles to it (including pure background ones)? Are the file sizes that I am getting expected? the slide embedding for me looks kind of small, but wanted to double check and I might be wrong on what is expected
Thank you

Hi, thanks for reaching out! The output of the slide encoder is the [CLS] token and that is used for finetuning the slide encoder on downstream tasks, e.g., classifications. That's why the file size seems to be smaller.

Okay, thank you!
So, should this tiling strategy of avoiding the background be fine with the gigapath embedding? Could you please confirm the coordinate format?
For downstream tasks, in the slide embedding, I have the following keys (as explained in the demo in this repository) 'layer_0_embed', 'layer_1_embed', 'layer_2_embed', 'layer_3_embed', 'layer_4_embed', 'layer_5_embed', 'layer_6_embed', 'layer_7_embed', 'layer_8_embed', 'layer_9_embed', 'layer_10_embed', 'layer_11_embed', 'layer_12_embed', 'last_layer_embed'
Which layer is recommended to use for downstream tasks? Or if the idea is to use multiple ones, what is the recommended strategy for that?
Thanks!

Hi sorry for the late response! I determine the layers to use based on a hold-out validation set. Yes, you're right, using multiple ones could be better than single layer.


raftstore: renew leader lease in advance when handle read request

Signed-off-by: linning<EMAIL_ADDRESS>
ref #11579
What problem does this PR solve?
Problem Summary:
Currently, the leader lease will be renewed when there are successful writes or read index, but if there are only read requests on the leader, the lease will not be renewed until it is expired and then the leader send read index request to renew it, which cause latency jitter, https://github.com/tikv/tikv/pull/6427 try to renew lease when raft basic tick triggered, but it is not compatible with the hibernate region feature which will skip raft basic tick.
Blocked by #6427
What is changed and how it works?
What's Changed:
When the local reader handle a read request, it also checks if the region's leader lease is gonna expired in near future, if so it sends a message to raftstore and tries to renew lease
TODO: add test
Check List
Tests

Unit test
Integration test

Side effects

Performance regression

Consumes more CPU

Release note

raftstore: renew leader lease in advance when handle read request

Any stats or graph to show the improvement?

/release

/release

/release

what need to do if I want this merge this PR? @NingLin-P

what need to do if I want this merge this PR? @NingLin-P

@slow-zhang  We need benchmark (a read-only workload) to verify the improvement, the key metrics to verify are the same as  https://github.com/tikv/tikv/pull/9292#issuecomment-755105740

/release

what need to do if I want this merge this PR? @NingLin-P

@slow-zhang We need benchmark (a read-only workload) to verify the improvement, the key metrics to verify are the same as #9292 (comment)

Can I help here? How to set up and what kind of benchmark? Is there any relevant documentation?

what need to do if I want this merge this PR? @NingLin-P

@slow-zhang We need benchmark (a read-only workload) to verify the improvement, the key metrics to verify are the same as #9292 (comment)

Can I help here? How to set up that kind of benchmark? Is there any relevant documentation?
BTW, there is one Jenkins job failed.

Sure! You can use go-ycsb and workloadc, and check out this blog for guide. Also, you can set up a cluster quickly with  tiup playgound (don't forget to replace the TiKV binary though

Sure! You can use go-ycsb and workloadc, and check out this blog for guide. Also, you can set up a cluster quickly with tiup playgound (don't forget to replace the TiKV binary though

I can not download the /release tar.gz, so can I just run make in that branch to create a binary?
can I just use my mac(with ssd) for that test or need I to run in ubuntu?

I can not download the /release tar.gz, so can I just run make in that branch to create a binary?

You can run make dist_release to get a release build

can I just use my mac(with ssd) for that test or need I to run in ubuntu?

Mac will be okay.

Is this work still advancing?  @NingLin-P

@NingLin-P may I ask why the work is paused? this should improve the read performance.

/release

/run-all-tests

@BusyJay @NingLin-P Just realized we need a config item for disabling that local reader renewing the lease in advance in some tests. So I added renew_leader_lease_advance_duration to set the time that checks the lease ahead.

sysbench read_only with 256 concurrency and 15k regions shows that there is a little improvement with this patch. There are still some regions that will go hibernate in my test.

Any updates?

/merge


Corrupted vsix is cached preventing extension install

Type: Bug
A corrupted file is stored in CachedExtensionVSIXs and never re-downloaded, preventing extension from being installed until the file is manually deleted.
Repro:

Attempt to install an extension while the Azure DevOps service is not available and returning 500 errors.
Result in this comment: https://github.com/microsoft/vscode/issues/190233#issuecomment-1832871083

VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:52:57.054Z)
OS version: Darwin arm64 23.1.0
Modes:
Connection to 'SSH: ox' could not be established  Canceled

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 4, 5

Memory (System)
32.00GB (0.07GB free)

Process Argv
--crash-reporter-id c5db302d-a456-4380-8e2f-7d11ad0a619e

Screen Reader
no

VM
0%

Connection to 'SSH: ox' could not be established  Canceled
Extensions (31)

Extension
Author (truncated)
Version

vscode-ron
a5h
0.11.0

vscode-eslint
dba
2.4.2

prettier-vscode
esb
10.1.0

kotlin
fwc
0.2.32

copilot
Git
1.139.0

copilot-chat
Git
0.10.2

copilot-labs
Git
0.17.1121

vscode-github-actions
git
0.26.2

better-cpp-syntax
jef
1.17.2

vscode-peacock
joh
4.2.2

vscode-clangd
llv
0.1.25

membrane
mem
1.6.1

vscode-dotnet-runtime
ms-
2.0.0

vscode-postgresql
ms-
0.3.0

remote-containers
ms-
0.321.0

remote-ssh
ms-
0.107.1

remote-ssh-edit
ms-
0.86.0

cpptools-extension-pack
ms-
1.3.0

hexeditor
ms-
1.9.12

makefile-tools
ms-
0.7.0

remote-explorer
ms-
0.4.1

proto
pet
0.0.4

vscode-yaml
red
1.14.0

vscode-gitweblinks
red
2.9.3

rust-analyzer
rus
0.3.1748

even-better-toml
tam
0.19.2

shellcheck
tim
0.35.0

es6-string-html
Tob
2.12.1

vscode-lldb
vad
1.10.0

vim
vsc
1.27.1

clang-format
xav
1.9.0

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
vscrp:30673768
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30887143
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232

cc @sandy081 who was looking into this in #190233

This bug has been fixed in the latest release of VS Code Insiders!
@juancampa, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 92772dcc29bd74108ab61ba9da5ad1f5154639ff of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

@sandy081 @juancampa bumping to see if this issue is still occurring and if the fix has been verified!

@justschen It's somewhat fixed. You can try again and the second time it will work. But the error message that appears doesn't indicate that. @sandy081, perhaps it should retry at least once if the zip is corrupted before showing this error?

@juancampa Thanks for the feedback. This bug is to fix not to cache corrupted  VSIXs and please validate that. Regarding trying again, I do not think we should be showing this as this might be random.

Verifying with a code review


Change bridge_name to name and bridge_params to parameters

🦟 Bug fix
Summary
I'm proposing that we change the attribute names because "bridge_" in the attributes seems redundant. The change I propose also alignes the attributes with the attribute names of Node (<node>), which are name and parameters.
Example:
Before:
RosGzBridge(
    bridge_name="bridge1",
    config_file=[FindPackageShare("ros_gz_sim_demos"), "/config/air_pressure.yaml"],
    use_composition=False,
    bridge_params=[{"qos_overrides./air_pressure.publisher.reliability": "best_effort"}],
)

After:
RosGzBridge(
    name="bridge1",
    config_file=[FindPackageShare("ros_gz_sim_demos"), "/config/air_pressure.yaml"],
    use_composition=False,
    parameters=[{"qos_overrides./air_pressure.publisher.reliability": "best_effort"}],
)

https://github.com/gazebosim/ros_gz/pull/600 changed name to bridge_name, but I'm not sure why that was necessary. @Amronos?
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

#600 changed name to bridge_name, but I'm not sure why that was necessary. @Amronos?

If I remember correctly, it was to differentiate between entity_name and bridge_name in https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim/launch/ros_gz_spawn_model.launch.py, and then I had decided to change it throughout for consistency.

I see. I think it makes sense to have bridge_name as input in https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_sim/launch/ros_gz_spawn_model.launch.py to differentiate it from other names, but I would prefer to keep the attribute of the RosGzBridge action itself as name since it's pretty clear from usage that it is the name of the bridge. i.e, in RosGzBridge(name="bridge1") or <ros_gz_bridge name="bridge1"> , the name attribute is not ambiguous that it belongs to RosGzBridge.


Add More Committee Icons

Overview
There are currently onl 3 icons committees. Add Various Icons that could possibility represents all the committee
Task

[ ] Add more icons
[ ] Add option in the committee edit/create screen

Additional
The reason why we're doing preset icons is because these icons are used in the event screen and committee screen, so dev must confirm in the icon fits before adding them. Also need to be svg and transparent.

once a committee is created, how can I edit or delete it from the app?
clicking the representative memberCard leads to my own user card?
pending request button is not formatted correctly
why show rep/lead positions if no user is selected for those roles
back button is very slow and takes multiple clicks
joined committee and approved request, member count for committee didn't increase


[Queues] WIP: Add Queues web crawler to Queues examples

This PR adds a new tutorial for Queues: a web crawler using Puppeteer and Cloudflare's Browser Rendering API.
I'd appreciate any feedback, especially on the clarity and tutorial writing conventions!
TODO:

[ ] Add GitHub repository link for web crawler

Thanks for this tutorial @kewbish! I broke down the tutorial into numbered steps, and each step has its subtitle.

@Maddy-Cloudflare - Thanks for taking a look! I don't think you have permission to push to this branch as it's on a repository fork, so I can't see your changes. Could you please add them as suggestions in a code review instead? (Files Changed > Blue + button beside a line > file-shaped ± button in the textbar)

@Maddy-Cloudflare - Thanks for taking a look! I don't think you have permission to push to this branch as it's on a repository fork, so I can't see your changes. Could you please add them as suggestions in a code review instead? (Files Changed > Blue + button beside a line > file-shaped ± button in the textbar)

Are you able to see the suggestions now?

Are you able to see the suggestions now?

Yes, thanks so much for the review! I've applied your suggestions and am just waiting on approval to open-source the repository.

Will do. Thank you!

@Maddy-Cloudflare - I've added the example repository's GitHub link so we can ship this PR now! Could you please merge it when you get a sec? (I don't have permissions.)

I have added some more suggestions. Can you please apply them? :)

I have added some more suggestions. Can you please apply them? :)

Done, thank you for checking things over!


bug: code-mockup only working with postcss.config.cjs but not postcss.config.js

What version of daisyUI are you using?
v2.51.6
Describe your issue
I found out that if you use this js:
export default {
  plugins: {
    tailwindcss: {},
    autoprefixer: {},
  },
}

it does not work but with this cjs:
module.exports = {
  plugins: [require('tailwindcss'), require('autoprefixer')],
};

it does.
Might also be a postcss bug but I am unsure and also wantet to leave a hint for other people.
What browsers are you seeing the problem on?
Other
Reproduction URL (optional)
No response

nevermind I just changed it back and it still worked.
The buttons and themes worked before but I didn't test other mockups


Properly init the sandbox compiler packages repo

The sandboxed compiler packages repository is created in a temporary directory. Only whether the target directory exists was checked before skipping initialisation.
Initialisation was skipped, which Opam was complaining about.

Opam was treating the repository as if it targeted version 1.3, which could have unexpected consequence I'm not aware of.


Add Starting/Advance to Characteristics

Can you make it look something like, at least in what data is available.

Main
WS
BS
S
T
Ag
Int
WP
Fel

Starting
26
39
29
31
38
44
31
35

Advance
10
15
5
5
10
20
10
10

Current
26
44
29
31
48
54
36
45

Secondary
A
W
SB
TB
M
Mag
IP
FP

Starting
1
12
2
3
4
0
0
3

Advance

1

Current
1
14
2
3
4
0
0
3

I'm going to have to rework the sheet for this presentation, but it's definitely possible and actually needed to reflect character development.
I'm thinking something that may be closer to the current presentation that includes a series of "checkboxes" to reflect advances taken as well.

Coming back to this almost a YEAR later. But I'm not sure I can do the advancement stuff (see restriction of Roll20 documentation below).

No Character Creation or Advancement
Due to copyright restrictions, please don't attempt to include functionality for advancing a character automatically to the next level or creating a new character from scratch automatically. It's fine to have attributes that auto-calculate based on other attributes (including the current level). We'll let you know if your submitted sheet violates this rule.

I was hoping for a reference point more than anything automated. So when I
am spending xp and I know career X gets a 20% boost to fellowship, how do I
know what my starting fellowship was? I have to go back and check all my
previous careers and remember if I've already gotten to 15%.
Or have I been leveling up characters wrong this whole time?
On Sun, Mar 27, 2016, 9:34 PM Timothy Stone<EMAIL_ADDRESS>wrote:

Coming back to this almost a YEAR later. But I'm not sure I can do the
advancement stuff (see restriction of Roll20 documentation below).
No Character Creation or Advancement
Due to copyright restrictions, please don't attempt to include
functionality for advancing a character automatically to the next level or
creating a new character from scratch automatically. It's fine to have
attributes that auto-calculate based on other attributes (including the
current level). We'll let you know if your submitted sheet violates this
rule.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/timothystone/roll20-character-sheets/issues/4#issuecomment-202184777

Got it. I'm actually over a hurdle that prevented my from mastering github (time and practice). I'm redesigning the whole sheet.


Update 2015-10-10-PhoenixIn10Minutes.markdown

The single quotes should be double quotes. :) nice write up!

Thank you very much ! :heart:


Update picker.js

Now... when you close datepicker, it STOP scroll to bottom.

I haven't seen any scrolling behavior. So I don't think this fix is necessary. Can you explain when this is happening to you?

This occurs when scrolling in the browser because the content occupies more than one page and using the datepicker in a form located above, to close the datepicker this makes it Toggles between down completely, the document.

This isn't reproducible by me and nobody else has complained of this issue.


failed to build using gradle

hello:
I am using lombok in an Android project. I included lombok in build.gradle as  compile 'org.projectlombok:lombok:1.16.10'.
However, when I build the project, seems the tags like getter, setter, builder etc does not work, it got compile errors like, entity.setId() undefined.
Is there any hints when using gradle?
Thx in advance

NOTE: You'll still need to download lombok, or doubleclick on the lombok.jar file downloaded by maven / ivy / gradle, to install lombok into your eclipse installation.
the https://projectlombok.org/mavenrepo/index.html

@georgeworkhard This is strange, on my Java Development using Gradle, it worked automatically.


Tests are not written for app

No testing appears to have been written.  Please at least have some boilerplate so we can get up and running.

What makes you assume that there are no tests in admin-on-rest? You probably haven't looked long enough.


Convert the Project from Nodejs to Static HTML

Changing the platform Nodejs to Static HTML in a single webpage.

resolve


Documentation clarity

Description
[Documentation]
Clarifying that TLS modules need to be presented inside annotations in the service definition
Related Issues
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Todos

[ ] Tests
[ ] Documentation

Other

If this is a documentation change, please open the pull request against the stable branch.
Code changes should occur against stable.

Hi, thanks! I think you branched this from master and are merging into stable. This means that to merge this PR we would implicitly be merging master into stable, which we wouldn't want to do as part of this PR.
Do you mind creating a branch off of stable?

This issue was addressed with a slight refactor of the docs.


Surround schema information table with back quotes

Overview
We have to surround the schema information table with back quotes.
Error logs
05:20:19  target not specified in profile 'elementary', using 'default'
Pulling query history from BigQuery (!)  in 0.9s (4.32/s)
Traceback (most recent call last):
  File "/Users/yu/anaconda2/envs/python3.8/bin/edr", line 8, in <module>
    sys.exit(cli())
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/cli/../lineage/cli.py", line 253, in generate
    queries = query_history_extractor.extract_queries(start_date, end_date)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/lineage/query_history.py", line 85, in extract_queries
    self._query_history_table(start_date, end_date)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/lineage/bigquery_query_history.py", line 98, in _query_history_table
    rows = list(job.result())
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/cloud/bigquery/job/query.py", line 1447, in result
    do_get_result()
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/api_core/retry.py", line 286, in retry_wrapped_func
    return retry_target(
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/api_core/retry.py", line 189, in retry_target
    return target()
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/cloud/bigquery/job/query.py", line 1437, in do_get_result
    super(QueryJob, self).result(retry=retry, timeout=timeout)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/cloud/bigquery/job/base.py", line 727, in result
    return super(_AsyncJob, self).result(timeout=timeout, **kwargs)
  File "/Users/yu/anaconda2/envs/python3.8/lib/python3.8/site-packages/google/api_core/future/polling.py", line 135, in result
    raise self._exception
google.api_core.exceptions.BadRequest: 400 Syntax error: Expected ")" but got "-" at [7:33]

Hi @yu-iskw! thanks so much for opening this pull request, I'll run a few tests tomorrow with this change on BigQuery and let you know how it goes

Thanks @yu-iskw, validated it and merged it back to master.


AttributeError: 'NoneType' object has no attribute 'TF_NewStatus

In the latest sources the issue: https://github.com/tensorflow/tensorflow/issues/3388 is fixed in the thensorflow/python/client/session.py, But I now receive the following error instead:
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7fb2e08cee48>>
Traceback (most recent call last):
  File "$HOME/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 595, in __del__
AttributeError: 'NoneType' object has no attribute 'TF_NewStatus'

I compiled the model manually using the latest version sources and using Bazel 0.4.5. The same seems to be true as with the issue 3388: The error is not always popping up and the run seems to have ended normally. However, now and then to above error message is displayed.

@naatje80 can you provide a script to repro this?

Dear skye,
thank you for your response. Triggered by your question, I found out that this issue is only occurring when using the Keras module. When I use the Tensorflow module directly I'm not able to reproduce the issue. I assumed that the tensorflow was the issue, as issue #3388 was also occurring at the same moment when I ran my Keras test scripts. Next to that, the error message also reported the issue was occurring in the session.py python script that is part of tensorflow. I will report the issue at the Keras project. Sorry for the inconvenience....

No problem, thanks for digging into this!

Hi @skye and @naatje80 I got the same issue. After installing tensorflow 1.0.1 from source, I no longer get the error. Used keras v2 with MNIST dataset and it took 799s using the terminal.
For some reason, when I use jupyter notebook, it gets blocked. From terminal using py files, everything works ok

Hi, I also have this issue. It pops up from time to time. Keras 2.0.3 and tensorflow 1.1.0.

This issue reproduces with the following code, which is based on this example:
import sys

import numpy as np
import tensorflow as tf
import tensorflow.contrib.keras as keras

def main(argv):
	# Get data into numpy arrays of size (?,num_unroll) where ? is the number of
	# data points and num_unroll is the number of time steps...
	x_train = ...
	x_test = ...
	y_train = ...
	y_test = ...

	# Build and run the model
	model = keras.models.Sequential()
	model.add(keras.layers.Embedding(MAX_FEATURES, 128))
	model.add(keras.layers.LSTM(128, dropout=0.2, recurrent_dropout=0.2))
	model.add(keras.layers.Dense(1, activation='sigmoid'))
	model.compile(loss='binary_crossentropy',
	              optimizer='adam',
	              metrics=['accuracy'])
	print('Train...')
	model.fit(x_train, y_train,
	          batch_size=FLAGS.batch_size,
	          epochs=15,
	          validation_data=(x_test, y_test))
	score, acc = model.evaluate(x_test, y_test,
	                            batch_size=FLAGS.batch_size)
	print('Validation score:', score)
	print('Validation accuracy:', acc)

if __name__ == "__main__":
	main(sys.argv)

I don't get the error when I import keras instead of import tensorflow.contrib.keras as keras.

It happens to me as well, from time to time.
I used tensorflow-gpu

It's happening in Tensorflow 1.1.0 tensorflow-gpu
Exception ignored in: <bound method BaseSession.del of <tensorflow.python.client.session.Session object at 0x000001A62301DC50>>
Traceback (most recent call last):
File "D:\Programs\Anaconda\envs\tensorflow\lib\site-packages\tensorflow\python\client\session.py", line 587, in del
AttributeError: 'NoneType' object has no attribute 'TF_NewStatus'

Getting similar error. Has only happened in last 24-36 hours or so:
AttributeError: 'NoneType' object has no attribute 'update'

I had the same problem and checking the code in the file /lib/python3.5/site-packages/tensorflow/python/client/session.py shows this:
try:
        status = tf_session.TF_NewStatus()
        tf_session.TF_DeleteDeprecatedSession(self._session, status)

the error could be avoided with something like this:
try:
        if tf_session is not None:
            status = tf_session.TF_NewStatus()
            tf_session.TF_DeleteDeprecatedSession(self._session, status)

windows, python 3.5 in anaconda, tensorflow 1.1.0, keras 2.0.5
when I try to run example perceptron from documentation (https://keras.io/getting-started/sequential-model-guide/) get error
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x0000026A0153E978>>
Traceback (most recent call last):
  File "C:\Miniconda2\envs\tensorflow\lib\site-packages\tensorflow\python\client\session.py", line 587, in __del__
AttributeError: 'NoneType' object has no attribute 'TF_NewStatus'

Code that I run
import keras
from keras.models import Sequential
from keras.layers import Dense, Dropout, Activation
from keras.optimizers import SGD

# Generate dummy data
import numpy as np
x_train = np.random.random((1000, 20))
y_train = keras.utils.to_categorical(np.random.randint(10, size=(1000, 1)), num_classes=10)
x_test = np.random.random((100, 20))
y_test = keras.utils.to_categorical(np.random.randint(10, size=(100, 1)), num_classes=10)

model = Sequential()
# Dense(64) is a fully-connected layer with 64 hidden units.
# in the first layer, you must specify the expected input data shape:
# here, 20-dimensional vectors.
model.add(Dense(64, activation='relu', input_dim=20))
model.add(Dropout(0.5))
model.add(Dense(64, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(10, activation='softmax'))

sgd = SGD(lr=0.01, decay=1e-6, momentum=0.9, nesterov=True)
model.compile(loss='categorical_crossentropy',
              optimizer=sgd,
              metrics=['accuracy'])

model.fit(x_train, y_train,
          epochs=20,
          batch_size=128)
score = model.evaluate(x_test, y_test, batch_size=128)

Same as me.

I'm running windows, python 3.5 in anaconda, tensorflow 1.1.0, keras 2.0.6.
When I run the code @jabacrack quoted, I do not get the error.  However I do get the error when running keras/examples/pretrained_word_embeddings.py.  FYI.

@baloodevil, I get this error sometimes, even if I run some code several times.

@Pr0duktiv's solution worked for me.

any ideas? I only get when I LOAD a model on Py27 Keras 2.0.4 TF 1.1

This happens to me as well, but python guide warns about usage of __del__ method, that the other variables can be already garbage collected and thus set to None
https://docs.python.org/3/reference/datamodel.html#object.__del__

I'm not sure if this is the same error or not; it's saying not callable rather than the attribute, but seems to be in the same method anyway...
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7f4cfbc42e10>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 696, in __del__
TypeError: 'NoneType' object is not callable

using tensorflow 1.4.1 in docker, using tensorflow/tensorflow:latest-gpu-py3
not using keras, but I am using sess = tf.Session() and sess.close() instead of with tf.Session() as sess: but that doesn't seem to be sufficient to recreate the error reliably in say ipython3, it only happens when I run my script. perhaps some sort of race condition?

I'm using tensorflow 1.5.0 via docker (gcr.io/tensorflow/tensorflow:1.5.0-devel-gpu-py3) and keras 2.1.3. The following exception sometimes occurs:
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7fa52147f898>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 702, in __del__
TypeError: 'NoneType' object is not callable

I'm not sure if it's related, but other times my script does not exit and keeps hanging. This makes automatic parameter tuning a hassle.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Same here. I'm usingpython 3.5, tensorflow 1.4.0 and keras 2.1.0 and I get the following error:
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7fe252d53dd8>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 696, in __del__
TypeError: 'NoneType' object is not callable

I noticed that in the relative code block only the AttributeError exception is catched, but not the TypeError we are getting, probably it should be added.
if self._session is not None:
    try:
        status = c_api_util.ScopedTFStatus()
        if self._created_with_new_api:
            tf_session.TF_DeleteSession(self._session, status)
        else:
            tf_session.TF_DeleteDeprecatedSession(self._session, status)
    except AttributeError:
        # At shutdown, `c_api_util` or `tf_session` may have been garbage
        # collected, causing the above method calls to fail. In this case,
        # silently leak since the program is about to terminate anyway.
        pass
    self._session = None

Reproduced on an EC2 p2.xlarge (GPU) instance, running ubuntu 16.04.3, keras 2.1.3, tensorflow 1.5.1
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7f37d83267b8>> Traceback (most recent call last):   File "/home/ubuntu/safedk/dl_env/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 587, in __del__ AttributeError: 'NoneType' object has no attribute 'TF_NewStatus'

I get the same error.
'''python
from keras import backend as K
K.clear_session()
'''
This seems to fix it. It feels like a work around though.

It worked for me too. Thanks

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Same problem. I was able to fix this (tensorflow 1.7.0 keras 2.1.5) by simply adding import tensorflow as tf before importing keras.

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

same issue as reported above.import tensorflow as tf solution worked for me

Nagging Assignee @fchollet: It has been 34 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@assif I am also running my job on AWS p2 instance and having the same issue. Did you solve it?

@xiaohk I used the snippet provided by @Nimi42 and it worked.
(using k.clear_session() at the end of the code).
I agree it's an ugly hack though :)

@assif Thanks! I will try it when I get connection to AWS again. I think I have cuda 8.0 on P2 and I am using Tensorflow 1.4. Are you using Tensorflow 1.5 with cuda 8.0?

@xiaohk Indeed. I'm using tensorflow 1.5.1 with CUDA 8.0.61

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Im using tf 1.4 with keras 2.1.5
Exception ignored in: <bound method BaseSession.__del__ of <tensorflow.python.client.session.Session object at 0x7fda61cd9828>>
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 696, in __del__
TypeError: 'NoneType' object is not callable

this message pops up every 5 or 6 times when I run my code, even with the same code. but besides
this message, nothing really effects me, my code still can run correctly with this error message.

Nagging Assignee @fchollet: It has been 16 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Using python 3.5.2, tf 1.9, and tensorflow.contrib.keras
Seeing this issue intermittently as well. It is fairly annoying as it sometimes splits my output in half.

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 75 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Solution of Nimi42 worked for me as well to solve this issue. I added:
from keras import backend as K
K.clear_session()

Closing this out since I understand it to be resolved, but please let me know if I'm mistaken.


thread safety issue

Julia crashed, when Makie function was called in multiple threads.
reproduce code:
using GLMakie
# scatter(rand(1000),rand(1000)) # julia will crash without this
tasks = map(1:30) do i
    Threads.@spawn scatter(rand(1000),rand(1000))
end
scenes = fetch.(tasks)
display(scenes[1])

the font of the images also has problem.

What backend is this?

What backend is this?

What backend is this?

it's CairoMakie

What backend is this?

it's CairoMakie

The Cairo fontrendering itself may not be threadsafe

The Cairo fontrendering itself may not be threadsafe

I have tested GLMakie, it has the same problem.
The code still has bug, with my PR https://github.com/JuliaPlots/AbstractPlotting.jl/pull/597
julia> scenes = fetch.(tasks)
ERROR: TaskFailedException:
Can't represent character � with any fallback font nor DejaVu Sans!
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] find_font_for_char(::Char, ::FreeTypeAbstraction.FTFont) at C:\Users\x\Documents\GitHub\AbstractPlotting\src\utilities\texture_atlas.jl:169

I have added repo code in above comment. Could you have a look? thanks.

I have tested GLMakie, it has the same problem.
The code still has bug, with my PR https://github.com/JuliaPlots/AbstractPlotting.jl/pull/597
julia> scenes = fetch.(tasks)
ERROR: TaskFailedException:
Can't represent character � with any fallback font nor DejaVu Sans!
Stacktrace:
 [1] error(::String) at .\error.jl:33
 [2] find_font_for_char(::Char, ::FreeTypeAbstraction.FTFont) at C:\Users\x\Documents\GitHub\AbstractPlotting\src\utilities\texture_atlas.jl:169

I have added repo code in above comment. Could you have a look? thanks.

Sorry, I don't have time to look into this right now. Making Makie threadsafe is a bigger project than just quickly looking into it.

Sorry, I don't have time to look into this right now. Making Makie threadsafe is a bigger project than just quickly looking into it.

I had no problem creating heatmaps with Cairomakie using a threaded for loop. GLMakie however crashes when used on more than one thread.

Any updates on this?
using CairoMakie
tasks = map(1:30) do i
   Threads.@spawn scatter(rand(1000),rand(1000))
end
scenes = fetch.(tasks)
display(scenes[1])

Note that with CairoMakie I also crash Julia with the above example.

Another example that crashes. Start Julia with julia -t 4. Then:
using CairoMakie
function do_a_plot(name)
  fig = scatter(randn(10), randn(10))
  save(name, fig)
end
@sync for i = 1:5
  Threads.@spawn do_a_plot("/home/cossio/temp/$i $(Threads.threadid()).pdf")
end

A workaround is to use locks to make sure only one thread plots at a time. Useful if plotting is not the bottleneck.
using CairoMakie

const plotting_lock = ReentrantLock()

function do_a_plot(name)
	lock(plotting_lock) do
		fig = scatter(randn(10), randn(10))
		save(name, fig)
	end
end

@sync for i = 1:5
	Threads.@spawn do_a_plot("/home/cossio/temp/$i $(Threads.threadid()).pdf")
end

Thanks @jpsamaroo for clarifying the use of locks here.


Could not use Durable Entities with Azure functions .NET isolated worker and SQL Storage Provider

We are trying to use Azure Durable Entities with .Net Isolated + SQL storage provider. We are getting exceptions while using Entities indicating that Durable Entities are not supported with SQL backend configuration.
configurations:
host.json:

local.settings.json:

Exception:

code snippet:

Referenced this article Durable entities - Azure Functions | Microsoft Learn and came to an understanding that Durable Entities are supported in .Net isolated mode.
Also tried another below code snipped resulting in similar exception.

Exception:

Also, we've made an update to the documentation to help clarify that Durable Entities are not yet supported with the MSSQL backend when using .NET Isolated. Apologies for the confusion.
https://learn.microsoft.com/azure/azure-functions/durable/durable-functions-storage-providers#comparing-storage-providers


Lock viewport by axis

I would love if we could lock viewport on only a certain axis, could be useful for like working on scrolling animations, although very few people would need it. Just an idea for a little improvement.

Could you give an example of how this could be used?

The only reason that i would see possibly is for working with scrolling animations or something, or like a scroll puzzle.
Therecould also certainly other random reasons it would be useful.
Prob should be put at the bottoms of to do list though I imagine, would be rare that anyone would really really need it.

Bottom of to-do list indeed. I'll close this as not-planned for now.


Every time loading all scripts and css not act like SPA ?

How can i handle like SPA(Single Page Application). Whe ever the URL navigate to different at that time all scrips css are loading?

All the files are only loaded the first time that the app loads.
You have to use routerLink to prevent the app reload.
For example:
 Dashboard v2
before click clear your network log and check it.


Update execute-batch-operations-using-web-api.md

calling out that the operations are performed sequentially in the order they are specified.

Hi guys. Can you apply this small change?


Problem with large repository

We have a large repository (~2GB .git) with a bit under ~40k commits and over 30k files in the master branch. It cannot be pushed to an empty repository in gogs without errors. Unfortunately I cannot publish the repository as it is a commercial software product.

I'd like to add another data point:
We maintain a 1.2 GB repository with less than 100 commits (manually tracking a vendor).
A first push to Gogs 0.6.1 via https works, but trying to view the repository in the web interface afterwards results in a HTTP 500:
[Macaron] Completed /vw-it/test 500 Internal Server Error in 3.783941ms
2015/06/12 14:35:42 [repo.go:281 func·008()] [E] GetTags:

Only after we restart Gogs web, the error goes away. Subsequent (smaller) pushes seem to work without problem. How Tags fit in this (GetTags from the log), I don't know, this particular repository doesn't have any Tags.

Everyone on this thread please checkout develop branch.

Tested with https://github.com/torvalds/linux with SSH as well.

Close as fixed.

Is is required to use SSH to fix this problem? We are having the same issue pushing 1.4GB repo with 1255 commits over http.

@Longshot123

Is it required to use SSH to fix this problem?

Yes...


Demonstrate 2 intermediate use cases around the dependency management

The core team may have time to take up the work or promoting 2 intermediate snippets from the dependency management user manual as samples.

@gradle/dependency-management Could you provide us with 2 user manual samples that you feel are important, focused, use cases for intermediate users? We should be able to provide assistance in migrating them over, removing the duplication that it will create (snippets vs samples) and provide links from the user manual to the samples.

Samples have been updated massively recently. We'll add more in the future and open individual issues for them.


Don't pad short usernames (OSBS-5391)

Docker versions since 1.12 have not placed any minimum length requirement on the namespace portion of a repository name.
Reference: https://github.com/moby/moby/commit/6f0068f
Fixes #552.
Signed-off-by: Tim Waugh<EMAIL_ADDRESS>

Updated release notes:

usernames shorter than 4 characters are no longer padded to length, since newer Docker versions no longer require that


fix: Remove PathwayStopsConsistencyValidator

Fix issue #990
PathwayStopsConsistencyValidator is superseded by PathwayEndpointTypeValidator - see pull #961

Thanks for cleaning this up! LGTM!


oledump.py is missing

MS Office. .doc, .xls, .ppt, … are OLE files (docx, xlsx, … is the new file format: XML inside ZIP).
This program is need to oledump.py because its too good analyzer for office files. I think flare-vm is need this tool.
https://blog.didierstevens.com/programs/oledump-py/

@brkalbyrk I added this tools under the Office tool category directory. I also created shortcuts for all the tools provided by oletools in the Office directory as well.


operator [N] [CI] loki-operator (0.1.0)

Signed-off-by: Periklis Tsirakidis<EMAIL_ADDRESS>Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you considered whether you want to use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

Thank you for your contribution, let us investigate the failure.

/merge possible

/retest

/merge possible

/test 4.11-deploy-operator-on-openshift

/merge possible

@J0zi @mvalarh PTAL

/merge

/merge possible


Pull request Sprint 0 disalvoj

This pull request was submitted after the deadline, so it will not be closed.


Add support for relationship properties

In Neo4j a relationship can have properties
MATCH
  (a:Person),
  (b:Person)
WHERE a.name = 'A' AND b.name = 'B'
CREATE (a)-[r:RELTYPE {name: a.name + '<->' + b.name}]->(b)
RETURN type(r), r.name

But in the Cypher DSL there are no option to pass these properties
public interface ExposesRelationships<T extends RelationshipPattern> {

	@NotNull @Contract(pure = true)
	T relationshipTo(Node other, String... types);

	@NotNull @Contract(pure = true)
	T relationshipFrom(Node other, String... types);

	@NotNull @Contract(pure = true)
	T relationshipBetween(Node other, String... types);
}

We need to use withProperties method of ExposesRelationships


close the closed chan on Close()

I think this is a fix to a bug. Unless i'm missing something

i think you're right


twill/jenkins-dind-ansible, repository does not exist or may require 'docker login'

Expected behavior
download of docker image
Actual behavior
reply repository does not exist or may require 'docker login'
Information about the Issue
Response that you cannot download an image that has just been uploaded does not make sens
Steps to reproduce the behavior

create image, push image
pull the same image

Although the image is create its impossible to download the same

Please try to login using your Docker ID (hub username) instead of your email. This should fix the issue.
It's difficult for me to troubleshoot your issue as the image seems to be private and thus cannot be accessed publicly.


Terraform 12 - Testing Parallelism Issues with newer Terraform Versions

Operating System Version: Windows 10
Provider (VirtualBox/VMWare): Terraform
Vagrant Version: N/A
Packer Version: N/A
Are you using stock boxes (downloaded) or were they built from scratch using Packer? Terraform
Is the issue reproducible or intermittent? Attempting to reproduce DetectionLab - Terraform issue #370

Please verify that you are building from an updated Master branch before filing an issue. - Oops, I forgot about this, though I should have a mostly up-to-date repository.
Description of the issue:
As per #370, while attempting to build the WEF machine, I noticed that Terraform was hanging on provisioning, even though the machines were (mostly) usable after 30+ minutes of provisioning. I found another issue online which implicates the newer version (0.12.x) as having provisioning issues when building multiple machines.
https://github.com/hashicorp/terraform/issues/22006
Note that the workaround in that above issue "might" not work for this issue as it requires all of the machines to be ready? ( -parallelism=1 ) - Never mind! Scratch this until I learn to use the right IP Whitelisting.
This issue is mainly for me to diagnose and triage the Terraform shenanigans as of late and to serve as information for others running into 0.12.X issues with Terraform.
Link to Gist Containing Build Logs:
None (Yet)

@ProtoDroidBot any updates on this issue? I'm hoping to push out some new AMIs this coming weekend that will hopefully address the WEF intermittent stuff

@clong no updates as I've been busy with work unfortunately. :(

Running the terraform apply operation on the latest commit now, will update if it passes/fails/hangs. Apologies for the delay!

@clong whatever you did with WEF could you propagate those changes to the win10 and dc machines in terraform? I am no longer getting the hangs on WEF but win10/dc are in a perpetual state of "still creating"
Used Terraform 0.12.21 (latest version as of 2/29/20)
Will create a separate issue for suricata as I ran into an error with Logger on that app. :(

Actually, WEF builds fine but the ATA license expired for the terraform version. :(
I'll create a new issue and close this one @clong as dc and win10 machines are still in a state of "still creating" and win10/dc cannot see the wef IP. :(

@ProtoDroidBot if you have time this week can you re-test? New AMIs have been deployed but I want to make sure they work for ya!

Closing due to inactivity


Future of Tiny-lr

Given that this project just went through what is apparently at least it's second almost-abandonment in the last few years, can we bring more contributors on board as maintainers who can manage releases for this project? The fact that it took 3 months after the npm v3 hotfix was merged to cut a release for it was a serious problem for a lot of projects (tiny-lr averages over half a million downloads each month).
I made my own fork, mini-lr to be a stand-in npm@3-compatible release in the meantime, but I'm not planning to continue that fork if we can be confident that the main project will be maintained moving forward. I'm not suggesting that I necessarily become a maintainer, either...I'd be happy to do so if you felt that was the right move, but given that only two people have more than 2 commits in the entire project, it's hard to say that anyone has the right knowledge to help maintain the project.
Regardless, something needs to be done to make sure this doesn't happen in the future. Thoughts? Pinging @shama as seemingly the only maintainer who is still around these days.

Sorry about that! I am now watching this repo and dedicating more time to maintaining it. Feel free to ping me in an issue or call me out on https://twitter.com/shamakry if I'm ever being slow.
I think adding additional maintainers to prevent hold ups in the future is a good idea. It sounds like you are interested in at least having commit and publish access @elwayman02. @mklabs if you wouldn't mind, could you add him as a collaborator?
I understand we are all volunteers and our lives are more important than open source. So I don't think any individual should be held responsible to maintain a library. But we can mitigate that by continually opening a project to new contributors who currently have capacity and drive to help.

:+1: not trying to call anyone out, it happens. Just working for a way forward to keep the project alive :)

@shama @mklabs any updates?

@elwayman02 I haven't heard anything and don't have access to give out collaborator access. I am considering this option: https://twitter.com/shamakry/status/649396015515086848 as that would give collaborators more permissions.

@shama this is an intriguing idea, and one that I'd be interested in helping out with. Happy to chat about it at some point if you want.

Hi
and sorry for the huge delay.
I agree, bringing in more collaborators couldn't hurt.
@elwayman02 I've added you as collaborator for both the github repo, and the npm package over at npmjs.com
Thanks!

Thank you @mklabs! I really appreciate it!

:+1: thanks!


Uninstall is not happening for some plugins in mac

🐛 Bug
Plugins cannot be uninstalled
To Reproduce
Steps to reproduce the behavior:

Instal several plugins
Click on Uninstall button for a bunch of them

https://user-images.githubusercontent.com/63799148/157497851-56f78252-8ad4-4794-89ac-5cd3ea4c1813.mov
Expected behavior
Plugins should be uninstalled
Environment
napari: 0.4.15rc3
Platform: macOS-11.6.4-x86_64-i386-64bit
System: MacOS 11.6.4
Python: 3.9.10 | packaged by conda-forge | (main, Feb 1 2022, 21:28:27) [Clang 11.1.0 ]
Qt: 5.12.9
PySide2: 5.13.2
NumPy: 1.22.3
SciPy: 1.8.0
Dask: 2022.02.1
VisPy: 0.9.6

this should be addressed as part of #4283, if anyone experience this again please reopen this issue


Check log messages for Pii

ex. u/p w/common instead of organizations

Even though it's a duplicate to some extend, I think it's great to have a special focus on properly marking the right things for PII, where as #28 to me is more about the functionality of being able to log, with and without PII

All logging has been removed from the packages.  We now return our information in messages, where the user has the choice to log or not log with whatever logging package they want.
If you want to change this to scrubbing error messages, then please reopen with a different title.

All logging has been removed from the packages.  We now return our information in messages, where the user has the choice to log or not log with whatever logging package they want.
If you want to change this to scrubbing error messages, then please reopen with a different title.


[1.11.x] Updating SLF4J to 1.7.36 and reload4j to 1.2.19

Clone of https://github.com/ops4j/org.ops4j.pax.logging/pull/475.

Fixed by 9c28bb51


[HELP] AWSProductRequest to download SAFE files no longer in the codebase?

I have not used SentinelHub for a while, and so the code I have (version 3.3.1) for downloading Sentinel-2 level-1C SAFE files is:
from sentinelhub import AwsProductRequest

def download_sentinel_2_imagery(s2_1c_dir: Path, product_id: str):
    """Download Sentinel-2 Level-1C .SAFE products from Amazon Web Services."""

    product_request = AwsProductRequest(product_id=product_id, safe_format=True,
                                        data_folder=s2_1c_dir)
    product_request.save_data()

Where the product_id is in this format S2A_MSIL1C_2023T**_N****_R***_T****_2023T**  (asterisks in place of actual values)
What function has sentinelhub replaced AwsProductRequest with in the most recent version 3.10?
Many thanks in advance for help.

There was an example for download of Sentinel-2 SAFE files:
https://github.com/sentinel-hub/sentinelhub-py/blob/4753c158b84855b2727de6eb391208f299f28c96/examples/aws_request.ipynb
But this was removed in November 2023 (so quite recently): https://github.com/sentinel-hub/sentinelhub-py/commit/29737dcc854c40f75f1ee073e48485542cbd72c4
Is there anything to replace the data_request AWSProductRequest function?

Hi @datalass1,
the aws module is no longer actively maintained, hence the removal of the example.
However the code is still there, but i cannot guarantee for how long (currently there are no plans to remove it in the near future, but that could change). But now you need to import things more directly via from sentinelhub.aws import AWSProductRequest.
You will also get some deprecation warnings, but you can ignore those if this is what you need

You can also check out how to access the data through the Copernicus Data Space Ecosystem

hello @zigaLuksic, I have amended all my code now to use CDSE, the blog was perfect with python code examples to use. Many thanks!


Add tag check to release draft creation

Fixes #3725

Codecov Report

Merging #3729 into master will increase coverage by 0.01%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #3729      +/-   ##
==========================================
+ Coverage   35.76%   35.78%   +0.01%
==========================================
  Files         289      289
  Lines       41604    41620      +16
==========================================
+ Hits        14879    14892      +13
- Misses      24527    24529       +2
- Partials     2198     2199       +1

Impacted Files
Coverage Δ

models/release.go
47.55% <82.35%> (+1.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6e170...394e826. Read the comment docs.

LGTM

Needs @lafriks and @lunny review


RTL support.

Related #388
I have checked manually that it works as much as possible,
Please let me know if I've missed something or need to add\change something.
@mathuo  Thank you very much.

Related #388
I have checked manually that it works as much as possible, Please let me know if I've missed something or need to add\change something.
@mathuo Thank you very much.

So fast!
Could you raise a PR vs this branch 388-rtl-support-1? Doing this I can merge that code from your fork back onto a branch under this repo which will allow me to publish an experimental build without having to immediately merge it to master since I assume having an experimental build for this may be useful for people to try out.
After checking etc I will then merge that branch into master.

Sure, done.
Thank you very much, if there's anything else I can help with - please let me know :)


Update backstop.conf.js

move export into the top

Description

Code sample

Why I should have export in the top? There are any problem?

@teerapat1739, you can't do that because the project doesn't use babel.