Avoid injecting unnecessary preload function if no dependencies are found in glob import

Description
I have a very small entry file, which does a lazy glob import. None of the files that are resolved by this glob import have dependencies.
Vite injects a function in the output, that allows preloading any dependencies. However, this code is never used. This results in the output size being doubled, so this seems wasteful.
Suggested solution
It seems this code is injected as part of the buildImportAnalysisPlugin. It would be nice if the plugin was smart enough to detect if no async imports have any dependencies. In that case, the values of the object that import.meta.glob injects would not need to be wrapped with the preload function, and the preload function itself would not need to be injected. The following example is minified, but I think it's still sufficiently readable:
In stead of:
// ... injected preload functions
p = Object.assign({
    "./components/tab-list.js": () => h(() => import("./tab-list-941ff699.js"), []),
}),

You would just get:
p = Object.assign({
    "./components/tab-list.js": () => import("./tab-list-941ff699.js"),
}),

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Duplicate of #13952


Add an "About" tab/box/pop-up

Add an About tab/box/pop-up that references back to the webpage (http://stlvault.com/), Facebook, and/or GitHub.
Given the open source nature it may get legs and that would make it easier for folks to find help/latest versions.

I'll update the user feedback dialog for the next version.
You'll also get (ignorable) popups for new versions.
Thansk for the suggestion!


instrument bitcoin core json tests vectors better (include comments

This replaces #265 which I abandoned due to either git bug or personal fail.
It improves test instrumentation, by including comments from the bitcoin core json test vectors in the test output.

I am trying again on #265, now that I understand merge process better, so pausing here.


Add short forme aliases for Gourgeist

I quite often see Gourgeist formes referred to Gourgeist-S and Gourgeist-XL. Because that naming is quite popular, I decided to add those aliases to the Showdown source code.
While I didn't really see Gourgeist-L (because it's not really viable), I decided to add it as well for consistency with two other aliases.

Gourgeist-M tho

I don't see any references to Gourgeist-M, usually that forme is referred just by Gourgeist, as confusing as it is.
Although I guess could be Gourgeist-H for Gourgeist-Super.

Yeah, those are fine to add.

@xfix can you add the aliases you mentioned so it can be merged?


Add AudioWebSocket close event

Solves #11
Adds a Flux stream to the API for handling close events. The flux uses a generic interface, so that other types of events can be added in the future.
This is a non-breaking change.

Completed all the requested changes besides the one about initializing lifecycleSink


chore: prep for 8.22.0

This PR resolves []
Description
prep for 8.22.0

#noChangelog

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against a11b9909341c529f55764caf18b3544086607c49


ContainerRegistry: easy way to support docker login

Type of Demand: enhancing features

Detailed Description: we can not get cr temp credential directly. when you run aliyun cr GetAuthorizationToken it return an JSON object, if you want to do docker login, you must parse the json and the the correct value.

Design: run command like aliyun cr GetAuthorizationToken with a param can get the pure authorizationToken value.

Or make it like aws, output a docker login command:
aws ecr get-login

output:
docker login –u AWS –p password –e none https://aws_account_id.dkr.ecr.us-east-1.amazonaws.com

Sorry we don’t have this feature yet, but we will add this feature in the future, you can now consider using jq tool to filter the returned json.


Please add the missing 3.0.0 release artifact into releases page

Please add the missing 3.0.0 release artifact into releases page.

Do you mean this page? https://pulsar.apache.org/download/

Do you mean this page? https://pulsar.apache.org/download/

This one
https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-3.0.0
So the actual release URL is this one:
https://github.com/apache/pulsar-helm-chart/releases/download/pulsar-2.9.4/pulsar-2.9.4.tgz
And as it is missing for the 3.0.0, then in my automation I would have to change the URL to this:
https://github.com/apache/pulsar-helm-chart/archive/refs/tags/pulsar-3.0.0.tar.gz
And of course I would like it to be like this
https://github.com/apache/pulsar-helm-chart/releases/download/pulsar-${PULSAR_VERSION}/pulsar-${PULSAR_VERSION}.tgz

The helm chart index is hosted here: https://pulsar.apache.org/charts/index.yaml. The index points to https://downloads.apache.org/pulsar/helm-chart/3.0.0/pulsar-3.0.0.tgz for the 3.0.0 release, and the pattern should continue to be as you suggested. Does that solve your request?

I second @michaeljmarshall's comment above should solve this issue. @lk-1984 does it answer your question?


[ignore this] no-op

I have local test failures on master.
Let's see what CI says.

bah, one git clean later the tests are green again ¯\_(ツ)_/¯


[cli] allowinsecure does not working for subutai update

on agent.gcfg:
changing cdn host
changing allowinsecure to true
root@rh1465911326:~# cat /apps/subutai/current/etc/agent.gcfg | grep allowinsecure
allowinsecure = true
root@rh1465911326:~# subutai update rh
FATA[2016-06-16 04:58:58] GET: https://kg.cdn.subut.ai:8338/kurjun/rest/file/info?name=subutai_4.0.0_amd64-dev.snap, Get https://kg.cdn.subut.ai:8338/kurjun/rest/file/info?name=subutai_4.0.0_amd64-dev.snap: x509: certificate is valid for *.subut.ai, subut.ai, not kg.cdn.subut.ai

@p1gmale0n fixed in subos/dev, please test

done


Update a typo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@tonghuaroot Hello! Thank you for creating a PR!
It seems like this phrase might be understood differently. Our intention was to invite people to community's Slack as another channel of communication apart from GitHub. With your change it might seem that it is Slack's community, not Infracost's one :). For that matter I think we'd prefer to keep the original sentence.

I fixed the "slack" typo already. Going to close this PR, thank you for bringing our attention to it! 👍


Since RG <IP_ADDRESS>9 the options are no longer stored (and previously stored options are lost after update)

Since RG <IP_ADDRESS>9 the Options are no longer stored (and previously stored are lost)
STR

Install RG <IP_ADDRESS>8 in fresh profile of Chrome 66/Firefox 60.
Go to RG Options,
add in "Features to disable" e.g. hide-useless-newsfeed-events
and/or enable the 'Show the features enabled on each page in the console' checkbox.
close and re-open Options: notice that your options are stored.
Now update to either <IP_ADDRESS>9 or <IP_ADDRESS>0: notice that your previous options are lost and if you modify them and close+reopen Options, they are not stored.
Note: when I access RG Options in 1609/1610:

there's no relevant entry in Chrome extension's 'Background page'|Console.
In Firefox Browser Console there are these errors (the former -probably irrelevant- occurs as I mouseover on the RG toolbar button):

Security Error: Content at moz-extension://9644575b-2193-449d-a7f4-2c78cf89d053/options.html may not load or link to chrome://mozapps/skin/extensions/extensions.css.

TypeError: storm_textarea.init is not a function        options.js:74:5

Thanks for this report! Previous options were safe but they just weren't shown nor updated. I'll push a hotfix soon


Docs: Add page about fetching data from frontend code using the data proxy

What this PR does / why we need it:
Adds documentation about how to use the data proxy.
This documentation teaches and follow similar concepts to https://grafana.com/developers/plugin-tools/create-a-plugin/extend-a-plugin/add-authentication-for-data-source-plugins#authenticate-using-the-data-source-proxy but it focuses in general usage for data fetching and not only on authentication. The add authentication page is linked in the sections where authentication is mentioned
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

I have edited the PR for style, consistency, structure, and clarity. See commit at 48015df0e936b20236d499c64525b8d57538ccc6. Please take a look and let me know if you have any questions about any of my suggestions.

I have edited the PR for style, consistency, structure, and clarity. See commit at 48015df. Please take a look and let me know if you have any questions about any of my suggestions.

Thank you for all the changes and style fixes they look good

Thanks for working on this @academo - afraid I won't be able to review this week. Happy for it to be merged assuming Joe and Marcus we're ok with the content 👍

I might have a few more suggestions :)


Use "var: type" instead of "var : type"

When having typed auto-completion enabled, I noticed that it completes as var : type, and my question is, why?
In Python, the syntax is var: type, and as GDScript's syntax is Python-like, I don't see why not have it as this instead.
@vnen

Python has typed variables?

@raymoo https://docs.python.org/3.5/library/typing.html

Python has typed variables?

Yes, as of 3.5 (PEP 484 -- Type Hints).

I'd be totally fine with var:type, as it's done in Monkey and ActionScript.  As long as these are all valid syntax, I don't necessarily care what the IDE defaults to.  Having an option to retain user formatting the way it does with other operators is fine.  I'm somewhat surprised the IDE enforces a space, but I'm guessing this is probably to reduce ambiguity with :'s usage in stuff like one-line if statements or something.

@nobuyukinyuu It doesn't. The issue is about the auto-completion.
var: type and var:type compile fine.

Is there other case than when completing virtual functions and making methods for signal connections?
In any case, I'm can change if people prefer that way.

I'm personally used to var : type because I work in ML languages fairly often, but I can see the var: type thing from python and scala and such...  Personally var: type seems very unbalanced to me, but I'm biased.  ^.^;

No strong opinion either, being close to Python is good in my book, but at the same time var : type avoids the confusion with the colon that starts a code block (func <...>:, if <...>:, etc.).

I feel that var : type is clearer.  I use var := val much more frequently in any case.

When a language wants its syntax to resamble another, it should stick to it, and deviate only when necessary.
There's a lot of people that don't like GDScript for being a language of its own. Looking like an already exiting and popular one (Python) medigates that effect, but if the default syntax starts deviating too much, that strength starts to weaken.
@akien-mga If this confusion didn't happened in the Python world, I don't see it happening here.

In general, I've seen var: type in more languages than var : type — for instance, TypeScript and Rust recommend the former syntax in their official style guides.

Yet I've seen var : type in (a lot) more languages than var: type, it depends on the coding world in which you've existed.

but at the same time var : type avoids the confusion with the colon that starts a code block (func <...>:, if <...>:, etc.).

This is a good point though, I didn't think of this...


Updated projects to use nunit 3.0 beta 4

Ready to merge
Working on #9, I have update all the projects to use the NuGet of the latest version of NUnit 3. I still need to ensure that we are counting test results properly with recent changes to the framework.

I have updated the code to handle the new Explicit result state. I will merge.


Problem with abstract class and assisted inject after migration to Java 8

With migration change [1] to Java 8, Gerrit Code Review doesn't start any more: [2]. This diff fixed this: [3]. All is fine with the code on Java 7. Is this expected?
[1] https://gerrit-review.googlesource.com/57852
[2] http://paste.openstack.org/show/176620
[3] https://gerrit-review.googlesource.com/64820

Java8 does change a few things, but the error & diff you pasted don't seem to have anything to do with java8.  Can you point to 'com.google.gerrit.server.config.GerritGlobalModule' & 'com.google.gerrit.server.change.Module'?  I'd like to see how the factory is being installed.

com.google.gerrit.server.config.GerritGlobalModule: [1]
com.google.gerrit.server.change.Module: [2]

[1] https://gerrit.googlesource.com/gerrit/+/master/gerrit-server/src/main/java/com/google/gerrit/server/config/GerritGlobalModule.java
[2] https://gerrit.googlesource.com/gerrit/+/master/gerrit-server/src/main/java/com/google/gerrit/server/change/Module.java

This indeed looks like a problem with the way assistedinject scans for factory methods & the way java8 introduces new synthetic/bridge methods.  I have an idea of what's wrong and will write up a testcase + fix.  Thanks for reporting it!

Hi,
I have been banging my head against this problem this week. Hopefully the following will aid you in your testing.
Any updates on a fix will be greatly appreciated, as my shop can't wait to upgrade to Java 8.
Kind regards.
package java8;

import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
import com.google.inject.Module;
import com.google.inject.assistedinject.Assisted;
import com.google.inject.assistedinject.AssistedInject;
import com.google.inject.assistedinject.FactoryModuleBuilder;

public class InyeccionAsistida
{

    public interface AbstractClass {}

    public interface AbstractConstructionParam {}

    public interface AbstractFactory <T extends AbstractConstructionParam>
    {
        AbstractClass create( T param );
    }

    public static class ConcreteClass implements AbstractClass
    {
        private ConcreteConstructionParam mValue;

        @AssistedInject
        ConcreteClass( @Assisted ConcreteConstructionParam value )
        {
            mValue = value;
        }

        @Override
        public String toString()
        {
            return mValue.toString();
        }
    }

    public static class ConcreteConstructionParam implements AbstractConstructionParam {}

    public static interface ConcreteFactory extends AbstractFactory<ConcreteConstructionParam>
    {
        ConcreteClass create( ConcreteConstructionParam param );
    }

    public static void main( String[] args )
    {
        Module module = new AbstractModule()
        {
            @Override
            protected void configure()
            {
                Module factoryModule = new FactoryModuleBuilder()
                    .implement( AbstractClass.class, ConcreteClass.class )
                    .build( ConcreteFactory.class );

                install( factoryModule );
            }
        };

        Injector injector = Guice.createInjector( module );

        ConcreteFactory concreteFactory = injector.getInstance( ConcreteFactory.class );
        System.out.println( concreteFactory.create( new ConcreteConstructionParam() ) );

        AbstractFactory<AbstractConstructionParam> abstractFactory = cast( concreteFactory );
        System.out.println( abstractFactory.create( new ConcreteConstructionParam() ) );
    }

    @SuppressWarnings("unchecked")
    private static <T extends AbstractConstructionParam> AbstractFactory<T> cast( ConcreteFactory concreteFactory )
    {
        return (AbstractFactory<T>) concreteFactory;
    }
}

Fix will be merged soon, in the latest pull request.  Sorry for the troubles.

Thanks for the pointers to your commit.
Unfortunately the fix is not quite there yet. I've attempted to modify your unit test to demonstrate the problem:
diff --git a/extensions/assistedinject/test/com/google/inject/assistedinject/FactoryProvider2Test.java b/extensions/assistedinject/test/com/google/inject/assistedinject/FactoryProvider2Test.java
index f58352b..26e6f21 100644
--- a/extensions/assistedinject/test/com/google/inject/assistedinject/FactoryProvider2Test.java
+++ b/extensions/assistedinject/test/com/google/inject/assistedinject/FactoryProvider2Test.java
@@ -29,6 +29,7 @@ import com.google.inject.Key;
 import com.google.inject.Provider;
 import com.google.inject.Stage;
 import com.google.inject.TypeLiteral;
+import com.google.inject.assistedinject.FactoryProvider2Test.ConcreteAssistedWithOverride.Factory;
 import com.google.inject.assistedinject.FactoryProvider2Test.Equals.ComparisonMethod;
 import com.google.inject.assistedinject.FactoryProvider2Test.Equals.Impl;
 import com.google.inject.matcher.Matchers;
@@ -1133,8 +1134,8 @@ public class FactoryProvider2Test extends TestCase {
   }

   static abstract class AbstractAssisted {
-    interface Factory<T extends AbstractAssisted> {
-      T create(String string);
+    interface Factory<T extends AbstractAssisted,P extends CharSequence> {
+      T create(P string);
     }
   }

@@ -1145,26 +1146,33 @@ public class FactoryProvider2Test extends TestCase {
   static class ConcreteAssistedWithOverride extends AbstractAssisted {
     @Inject ConcreteAssistedWithOverride(@SuppressWarnings("unused") @Assisted String string) {}

-    interface Factory extends AbstractAssisted.Factory<ConcreteAssistedWithOverride> {
+    interface Factory extends AbstractAssisted.Factory<ConcreteAssistedWithOverride,String> {
       @Override ConcreteAssistedWithOverride create(String string);
     }
   }

   static class ConcreteAssistedWithoutOverride extends AbstractAssisted {
     @Inject ConcreteAssistedWithoutOverride(@SuppressWarnings("unused") @Assisted String string) {}
-    interface Factory extends AbstractAssisted.Factory<ConcreteAssistedWithoutOverride> {}
+    interface Factory extends AbstractAssisted.Factory<ConcreteAssistedWithoutOverride,String> {}
   }

   // See https://github.com/google/guice/issues/904
   public void testIgnoresSyntheticFactoryMethods() {
     // Validate the injector can be successfully created.
-    Guice.createInjector(new AbstractModule() {
+    Injector injector = Guice.createInjector(new AbstractModule() {
       @Override protected void configure() {
         install(new FactoryModuleBuilder().build(ConcreteAssistedWithOverride.Factory.class));
         install(new FactoryModuleBuilder().build(ConcreteAssistedWithoutOverride.Factory.class));
         install(new FactoryModuleBuilder().build(
-            new TypeLiteral<AbstractAssisted.Factory<ConcreteAssisted>>() {}));
+            new TypeLiteral<AbstractAssisted.Factory<ConcreteAssisted,String>>() {}));
       }
     });
+
+    Factory concreteFactory = injector.getInstance( ConcreteAssistedWithOverride.Factory.class );
+    concreteFactory.create( "" );
+
+    AbstractAssisted.Factory abstractFactory = concreteFactory;
+
+    abstractFactory.create( "NPE" );
   }
 }

If you run the modified unit test, you get this result:
$ java -cp "build:lib/*" junit.textui.TestRunner  com.google.inject.assistedinject.FactoryProvider2Test
.E
Time: 0,262
There was 1 error:
1) testIgnoresSyntheticFactoryMethods(com.google.inject.assistedinject.FactoryProvider2Test)java.lang.NullPointerException
	at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:674)
	at com.google.inject.assistedinject.$Proxy6.create(Unknown Source)
	at com.google.inject.assistedinject.FactoryProvider2Test.testIgnoresSyntheticFactoryMethods(FactoryProvider2Test.java:1174)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

FAILURES!!!
Tests run: 1,  Failures: 0,  Errors: 1

As you probably already know, this is not a problem with the Eclipse compiler, since it doesn't insert the additional method to the interface.
BTW, if you run the code I posted before, you get the same error:
java8.InyeccionAsistida$ConcreteConstructionParam@1defd3f
Exception in thread "main" java.lang.NullPointerException
	at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:674)
	at com.sun.proxy.$Proxy5.create(Unknown Source)
	at java8.InyeccionAsistida.main(InyeccionAsistida.java:68)

I hope you find this useful, and thanks for looking into this.

Thanks for the expanded test, I'll give this another shot.

I hacked a crude fix for FactoryProvider2.invoke() to look up the AssistData for the synthetic method using only its name. I'm not really suggesting that as a proper fix, but for what it is worth, with that fix in place nothing else broke in our code base.
In other words, we are eagerly awaiting the proper fix.
Thanks again.

I have a hack in the works. The JDK unfortunately gives no good way to do this.  The problem is we need to identify and call default methods with the default (not proxied) implementation.  The MethodHandles class is supposed to let you, but it doesn't let you override visibility restrictions.  Supposedly it's possible to use reflection to hack up MethodHandles to let you do it, but I couldn't get it working reliably, and it's also not safe to not use the public API.  So regardless, we need a backup way of doing it... I've got a backup, but it isn't foolproof, so I'm going to take another stab at MethodHandles.

FYI, latest push to #905 includes a fix for the NPE too.  Could you give it a shot and let me know if it works for you?

I tested my code and didn't run into any more issues.
Thanks for the outstanding work!

Thanks for the fix. Any ETA for new release that contains it?


Question - How to modify zAppBuild on our installation while benefiting from the developments made by the IBM team?

Hi,
zAppbuild is a component that seems essential to us to use IBM Dependency Based Build: it provides a very large number of basic services that would be difficult to write ourselves, and it offers many use cases as initial models.
However zAppbuild is not an IBM Dependency Based Build component and it must be adapted to the context of the user site because it is rare that it can be used directly from its recovery.
My question is: how to benefit from the developments of zAppbuild if we modify certain elements ourselves?
Shouldn't rules be implemented to allow changes and postponements of zAppbuild -specific developments in our modified version, not necessarily compatible?
Shouldn't it identify elements "not to be modified", and elements "authorized in modification"?
Can be cut certain current elements to dissociate the "heart" parts not to be modified, and the "peripheral" parts authorized in modification?
Thanks.

Hi @FALLAI-Denis,
sorry for the delay in answering your questions/requests. I was on a longer family leave, back now. A bit unfortunate that nobody else has responded to it, while I was away. Customers seem to be very cautious about collaborating / sharing their views through GitHub - still on a learning curve to share their views/opinion through those platforms. But, I see plenty of requests coming in via email.
We are not intending to lock any specific areas of the zAppBuild sample implementation. It is a community driven project and everyone can propose updates to it through GitHub. Certainly, sharing the idea in advance through an Github Issue makes sense, so that it can be discussed with the community and the maintainers of the project, before preparing a PR to the project.
To answer your questions - it might sound simple, but why not using Git to synchronise the open source project with your customised internal version of it? Certainly, everyone has a slightly modified configured/customised version of zAppBuild running at their shops. If you start with a fork of zAppBuild and retain the history (which means to maintain a remote reference to this project), you can update your fork easily by using git. We have shared some instructions via this paper: zAppBuild Introduction and Custom Maintenance Strategy. Let me know, if you have any questions on that. And yes, I have seen customers, who have strict rules about the committers in their internal git server, but there are always ways around it.


Remove test dependency SNAPSHOT version of kmp-tor-resource

Before a 0.1.0 publication can be had, this needs to be a hard dependency. Unfortunately I'm not ready to publish that just yet as kmp-tor still needs some work done on it to ensure everything is copacetic. Also, ios executable publications are no longer published (they were just the macOS binaries, so). Will need to rework things here in this repository to adapt.
Things that need to happen to achieve this:

[x] Publish kmp-tor-common (Currently a snapshot)
[x] Publish kmp-tor-resource
[ ] Rework how tests consume and utilize kmp-tor-resource executables
[ ] Publish 0.1.0

In the meantime, I'm comfortable publishing an rc01.

Removed the blocked label, as kmp-tor-resource now has its first release. Work on this can move forward.


rootless: cleanups

remove some dead code and fix a regression where we don't report correctly if are trying to use "mount" with something different than "vfs"

LGTM

@baude @mheon @vrothberg @TomSweeneyRedHat PTAL


Where can I find the script to test retrieval zero-shot performance?

Thanks for the impressive work. By the way, where can I find the script to test retrieval zero-shot performance?

@1338199 https://github.com/LAION-AI/CLIP_benchmark


rosie: 1.3.0 -> 1.4.0

https://gitlab.com/rosie-pattern-language/rosie/-/blob/master/CHANGELOG
Description of changes
update rosie to version 1.4.0
https://gitlab.com/rosie-pattern-language/rosie/-/blob/master/CHANGELOG

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build rosie rosie.passthru.tests


improve the check that the hydra files are still valid using buildkite

Description

Linked issue

Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

@cleverca22 What do we do with the PR? Wait or close


Error locating target:  'autoalbument.faster_autoaugment.search.FasterAutoAugmentSearcher'

I was trying to run an example using as shown in https://albumentations.ai/docs/autoalbument/how_to_use/. However I got this error.

Is there something I am doing wrong? Help would be very much appreciated.

same issue, how did u solve it?

Ahh, thanks for the comment, closed it somehow by mistake. Yet to find a solution.

First: using an image to display the error message is a bad idea, especially a partial one!
Next time copy and paste the full error message.
You likely need to do one of the tips given in this comment  this comment:

Change line 6 in envs/name/lib/site-packages/timm/models/layers/helper.py from "from torch._six import container_abcs" to "import collections.abc as container_abcs"

I managed by downgrading to timm==0.4.12

Same issue!

I managed by downgrading to timm==0.4.12

Downgrading to timm==0.4.12 does not seem to work (and it introduces incompatibilities):
autoalbument 0.4.0 requires timm==0.3.2, but you have timm 0.4.12 which is incompatible.
segmentation-models-pytorch 0.1.3 requires timm==0.3.2, but you have timm 0.4.12 which is incompatible.

Ran into the same issue, I would just use the docker method.


App crashes on Android 15

Hi, I just downloaded the app (2.00 Alpha) and after giving the all files access, the app crashes.
Here's the log
app.simple.peri_2024-09-11T19_01_15.794.log

The log says AppOp is blocked for Peristyle, are you using any tool that blocks app ops?

The log says AppOp is blocked for Peristyle, are you using any tool that blocks app ops?

Nope, using no app that blocks app permission. (I'm rooted though)
Anything more I can do to help with the error?

Anything more I can do to help with the error?

You can manually allow storage permission, if you are using Android 10+ you'll have to grant the all files access to the app, and you'll be good to go.

Is it still crashing?

Is it still crashing?

Yep, with the same error log :/

Is it still crashing?

Yep, with the same error log :/

Try running this command using adb shell or any terminal of your choice
appops set app.simple.peri READ_EXTERNAL_STORAGE allow
What is your android version?

Is it still crashing?

Yep, with the same error log :/

Try running this command using adb shell or any terminal of your choice
appops set app.simple.peri READ_EXTERNAL_STORAGE allow
What is your android version?
Tried that, still crashing.

I'm running Android 15 QPR1 Beta 1.1 on Pixel 7a

Reinstall the app

Reinstall the app

nope, didn't work.
I think it has something to do with this:
https://issuetracker.google.com/issues/237124750

It should be intended behavior and should work unless there is some different underlying issue causing this.

It should be intended behavior and should work unless there is some different underlying issue causing this.

Hmm, so what could be the issue? Something with the app permission in Android 15?

Same issue on my Pixel 8 Pro With Android 15 Beta 2. I was able to setup all file access and external memory folder with app setup screen. But after clicking continue, the app crashed with this error.

Android 15 is still in Beta and Peristyle is only tested up to Android 14, they're maybe changing something in the 15, some new permissions restrictions maybe they do it all the time every year.

I have found the source of the issue. It is caused by the same issue, they changed how the permissions work in Android 15, having All Files access doesn't get the system wallpaper anymore.

app-prod-release.zip
The issue is fixed now, you can update the app using this APK and let me know if it works.

app-prod-release.zip
The issue is fixed now, you can update the app using this APK and let me know if it works.

Hi! Thanks for the fix, but the app still seems to be crashing
But I think it's a different issue now
Here's the log
app.simple.peri_2024-09-18T10_59_36.970.log

Does it need the combination of both? Can you also manually grant the MANAGE_EXTERNAL_STORAGE and see if it works?

they changed how the permissions work in Android 15, having All Files access doesn't get the system wallpaper anymore.

Will try it out right away!

Does it need the combination of both? Can you also manually grant the MANAGE_EXTERNAL_STORAGE and see if it works?

Would you know the adb command to manually grant the permission by any chance?

Would you know the adb command to manually grant the permission by any chance?

It should be this appops set app.simple.peri MANAGE_EXTERNAL_STORAGE allow or can manually search All Files in settings.

I just went to settings, and gave it all files access. and the app works now!
Thanks a lot

This isn't fixed yet, but so far it's confirmed that you'd need both READ_MEDIA_IMAGES and MANAGE_EXTERNAL_STORAGE permission to access the system wallpapers. Both of them are really sensitive permissions and Android could have easily added GET_WALLPAPERS or something like that to make it easier for both developers and users, but here we are. I'm glad it worked, and the fix will be available in the next release.

This isn't fixed yet, but so far it's confirmed that you'd need both READ_MEDIA_IMAGES and MANAGE_EXTERNAL_STORAGE permission to access the system wallpapers. Both of them are really sensitive permissions and Android could have easily added GET_WALLPAPERS or something like that to make it easier for both developers and users, but here we are. I'm glad it worked, and the fix will be available in the next release.

Yep, a very frustrating issue, I faced it with another app as well ://
Nevertheless, thanks for adding support for Android 15 as well, really appreciate it and love the app 👍


发送和接收功能优化

Is your feature request related to a problem? Please describe.
发送功能中没有历史记录查询，如果本地使用者想要查询本地用户发送的历史记录是无法查询的。但是接受方时候接受的历史记录的。

Describe the solution you'd like
发送是否可以增加一个发送历史记录查询功能，和接收历史记录对应，便于使用者查询，最好去掉可以去掉随意删除历史记录的功能，以便后续追踪。
Describe alternatives you've considered
No response
Additional context
No response

没看懂，发送和接收不都是你自己吗？

It would be nice if the issue was written in English for the whole community to be able to understand it.

That's right, in fact, I prefer that it be directly made into a conversational chat window, which is more intuitive and convenient.


Implementation of the final API for clustered lighting, shadowType support

Clustered lighting API has been updated to its final form.
New API (still private)
        app.scene.clusteredLightingEnabled = true;

        app.scene.lightCells = new pc.Vec3(30, 2, 30);
        app.scene.maxLights = 20;

        app.scene.shadowsEnabled = true;
        app.scene.shadowType = pc.SHADOW_PCF1;
        app.scene.shadowAtlasResolution = 2048;

        app.scene.cookiesEnabled = true;
        app.scene.cookieAtlasResolution = 1500;

        app.scene.areaLightsEnabled = true;

Old API (removed)
        pc.LayerComposition.clusteredLightingEnabled = true;
        app.scene.layers.clusteredLightingCells = new pc.Vec3(16, 12, 16);
        app.scene.layers.clusteredLightingMaxLights = 80;
        app.scene.layers.clusteredLightingShadowsEnabled = true;
        app.scene.layers.clusteredLightingCookiesEnabled = true;
        app.scene.layers.clusteredLightingAreaLightsEnabled = true;

Other changes

The Scene object now accepts GraphicsDevice as a parameter. This constructor has been made private as well, as the engine does not support multiple Scenes at all.
Added controls to Clustered spot and omni shadow examples

Clustered shadow filtering: support for PCF1, 3 and 5 filtering for clustered shadows (PCF5 is WebGl2 only, falls backs to PCF3 on WebGl1). Details about added PCF1:

on webgl1 this is a single sample with point filtering (linear filtering would need 4 samples)
on webgl2 this is a single sample with linear depth filtering (hardware depth filter)

If there is one scene per app, so one clustered lighting per app, would it be better to have such API (less depth): app.clusteredLighting.enabled and similar.
Also easier on documentation, can be separately found in own section instead of scene.

The longer team goal is to make multi Scene supported. Scene would represent its set up - global lighting, fog, clustered lighting and similar. But due to many shortcuts taken in how this was put together, this is not possible at the moment, and so there is no reason to expose Scene constructor. But I don't want to close this door.

My knee-jerk reaction is that the property names are quite verbose. So presumably we're heading for a world where it's not really 'clustered lighting' any more but just 'lighting' (because we plan to dump the current lighting system).
So, I'm thinking more along the lines of:
        app.scene.lightingCells = new pc.Vec3(30, 2, 30);
        app.scene.maxLights = 20;
        app.scene.shadowsEnabled = true;
        app.scene.cookiesEnabled = true;
        app.scene.areaLightsEnabled = true;
        app.scene.shadowAtlasResolution = 2048;
        app.scene.cookieAtlasResolution = 1500;

I've not included app.scene.clusteredLightingEnabled above because presumably, that will go away when clustered lighting is the only option?
Also, keep in mind that the Editor codebase does call the Scene constructor in at least a couple of places.

great suggestions @willeastcott - I've done just that, but additionally renamed lightingCells to lightCells.

This PR introduces Scene#shadowType but we already have LightComponent#shadowType. How do we manage this API change?

This PR introduces Scene#shadowType but we already have LightComponent#shadowType. How do we manage this API change?

Clustered lighting ignores shadowType on the LightComponent, and all cluster lights use the same shadow filtering. If at some point we switch to clustered lighting as a main lighting system, only directional lights will have shadowType exposed on the component. Similarly to shadow resolution - this is automatically assigned from the atlas.
We could possibly do the same with light attenuation - this is per light, as it's reasonably cheap .. but personally I would make it global for cluster lights to save all dynamic branches we can.

Do we prefer enableXXX or xxxEnabled?
I can find a few precedents for enableXXX. For example:

StandardMaterial#enableGGXSpecular
ElementComponent#enableMarkup
Application#enableBundles (currently private)

Good question.
I like enabled vs 'enable' as that matches the Component.enabled which is commonly used. In a way, its used in a similar way to for example entity.camera.enabled' or scripts.bloom.enabled`
We also have lightmapFilterEnabled.
But I don't mind either way.

the naming agreed to in a discussion:
scene.lighting
	.cells
	.maxLightsPerCell
	.shadowsEnabled
	.shadowType = pc.SHADOW_PCF1;
	.shadowAtlasResolution = 2048;

	.cookiesEnabled = true;
	.cookieAtlasResolution = 1500;

	.areaLightsEnabled = true;

Do we prefer enableXXX or xxxEnabled?
I can find a few precedents for enableXXX. For example:

StandardMaterial#enableGGXSpecular
ElementComponent#enableMarkup
Application#enableBundles (currently private)

To me xxxEnabled sounds informative, not something I can set. Since this is lighting API for setting config, I'd probably prefer enableXxx form. From a quick look around the engine I see use of both forms, but probably more enableXxx at this point.

to me, xxxEnabled matches with the style of entity.enabled and component.enabled.
enableXXX sounds like a name of a function to me, not a getter & setter.
@willeastcott any thoughts on this?

OK, @mvaligursky, while I'm still a little torn on this, I'll go with xxxEnabled.


[DSA]:2.10.3 explain Quick sort

Description
Explain quick sort in video format
Task

[ ] Video

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
In case you see that the issue has already been assigned, try to request for a different task within the same issue.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

Domain
DSA
Type of Contribution
Video
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Tanvi Deshmukh
Batch 7
Documentation

Mandeep Kaur
batch - 5
video

@tanvideshmukh29 go ahead

It is for documentation .


Eslint does not check for errors when the file is closed

Issue Type: Feature Request
Eslint does not check for errors when the file is closed
Why is that? I've added the project to the workspace
Extension version: 2.0.15
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

Support is there using a task in VS Code. See the settings eslint.lintTask.*. Triggering it needs an additional user action since it is an expensive operation.


Create additional info blocks

You can make your resume less official by adding more entertaining info, like your hobbies and interest, or what do you like, some interactive content or joke, easter egg, etc.

You have cool hobbies!


Ensure consistent code style across the project

I was going to have a look at #223 but I thought having a clean code base from the beginning would make it easier.
Using arrow functions instead of regular ones also removes the hoisting we got going on.

I've been running this today and didn't notice any problems.

@kevva Thanks for the huge cleanup :)

Sweet. Glad it didn't cause any unforeseen errors.

@kevva After this PR, the ratio selection stopped working:


Automated push from build 42117

Fixes #
https://github.com/Microsoft/botbuilder-tools/issues/641
Proposed Changes

Testing

Pull Request Test Coverage Report for Build 1743

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.113%

Totals

Change from base Build 1736:
0.0%

Covered Lines:
3961

Relevant Lines:
5628

💛  - Coveralls


Adding auto_assigning IP logic to containers

This is almost exactly the same as #506, but with a few extra bits. We clearly had the same idea in mind! Great minds.
I'm still adding a few more tests, but since there's already another PR for the same type of change, I thought I would throw mine up for discussion. I don't expect the tests to pass yet.

Thanks for putting this up. It's more feature rich so I'd take it in preference to #506.
Would you consider extending it to the calicoctl container <CONTAINER> ip (add|remove) commands too?
Before I can merge the PR, you'll need to sign a contributor agreement - see here http://docs.projectcalico.org/en/latest/contribute.html#contributor-agreements

Hey @tomdee,
Thanks for the quick response! The change already extends to calicoctl container <CONTAINER> ip (add|remove). You can see it with the get_ip_and_pool call within def container_ip_add. I ran the commands a few times in testing and it appears to work correctly. Sorry for the delay on the tests, as I'm having a bugger of a time getting make test to work locally. I should be able to finish it up by tomorrow however.
Also, although I haven't submitted code yet, I did already sign the contributor agreement. I have an email from Jon Flynn about it. Let me know if you need anything else from me on this front.

Sounds good! If you need help getting tests running I can offer support on our slack channel - sign up here https://calicousers-slackin.herokuapp.com

Assuming this latest build passes the tests (the st tests still fail for me locally), this PR should be good to go.

Rebased this morning to make sure we're not drifting.

A few comments but it's looking good. My main concern is about the skipped IPv6 tests.
@lxpollitt or @spikecurtis are you happy with this design? It's fine by me...

@tomdee: As to IPv6 not working, I don't know. Unfortunately, I still cannot get st tests to work locally, but Semaphore's log showed that node was not configured for IPv6 (https://semaphoreci.com/calico/calico-docker--5/branches/pull-request-508/builds/10). I tried to get it to work by adding a calicoctl checksystem --fix to the node setup in tests, but it didn't seem to help. The other container tests didn't have IPv6 either.

I'm happy with the design and just made a few small suggestions in the code.
I do think we want more regression tests to go with this change.  I couldn't find code coverage output on CircleCI.  @tomdee aren't we supposed to get that from Circle, or am I thinking of a different repo?

We have coverage on coveralls.io but I'm not sure if it's working on PRs
https://coveralls.io/github/projectcalico/calico-docker

I've also implemented something that does this, but I'm happy to ditch mine and replace with this (which on the face of it is more feature rich).

OK, I'm happy on the IPv6 tests. I forgot we didn't have them working. @robbrockbank was going to take a look at getting them working on Semaphore but that shouldn't block us merging this PR.
How can I help you get the STs running locally. What error output are you seeing?

So I think we're pretty much ready to merge this. THe final thing to check is the test coverage.

@tomdee I'm happy as long as test coverage looks good.

Hey all. I'm back in the states, and thus have much more reliable internet. Let me know whatever you need on this.

CircleCI has test coverage - which is higher than we've got on master at the moment. So merging.
@insequent I would love for you to be able to run the STs. I'm around all day today if I can offer you any help on Slack.


empire.py crash when using management/runas

When attacking a test machine, the run as command causes a hang in the Command and Control server.
The error that I get is:
Traceback (most recent call last):
File "./empire", line 20, in
main.cmdloop()
File "~/empire/lib/common/empire.py", line 170, in cmdloop
self.do_agents("")
File "~/empire/lib/common/empire.py", line 302, in do_agents
raise e
KeyError: 'DomainName'
C2 setup:
Two empire listeners running:
ID    Name              Host                                 Type      Delay/Jitter   KillDate    Redirect Target

1     test              https://192.168.xx.xxx:443           native    5/0.0
2     msf               https://192.168.xx.xxx:8443          meter     5/0.0
I also have a MSF exploit/handler running:
Payload options (windows/meterpreter/reverse_https):
Name      Current Setting  Required  Description

EXITFUNC  process          yes       Exit technique (Accepted: '', seh, thread, process, none)
LHOST     192.168.xx.xxx   yes       The local listener hostname
LPORT     8443             yes       The local listener port
The target machine is a windows 7 box which is NOT domain joined.  The agent is running as admin.

Thanks for the detail, we will look into this soon.

Should be fixed with https://github.com/PowerShellEmpire/Empire/commit/bcb2f4677f0fd767cb3c638200398bd08a42d8b7


Define bootstrap callout uses

@sploiselle, can you add more detail here? I'm not sure what this is about.

@jseldess Meant to close this issue in commit 12a43d9. Thanks for cleaning this up!


Really fix featured channel icons on discovery page

The previous fix to use rootNodes didn't work since that's populated asynchronously. Rather than try to block on that, this just repeats the channel lookup and mutates the node to have the channel's thumbnail fallbacks.
Fixes: #780

Looks good!


Missing default export in "es" module version of actionTypes

Are you submitting a bug report or a feature request?

bug
What is the current behavior?

Error thrown when using tree shaking like suggested here https://redux-form.com/7.1.1/docs/faq/bundlesize.md/ when using actionTypes as shown for actions.
This should work:
import {actionTypes} from 'redux-form'

const {SET_SUBMIT_SUCCEEDED} = actionTypes;

It works in develop build without tree shaking, but fails during prod build:
/home/hoschi/repos/gis/frontend/node_modules/@gis-ag/gravity-frontend-buildtools/lib/dynamic-gulp-tasks/webpackBuild.js:41                                    throw new gutil.PluginError('webpack', buildError);
      ^
Error: ./src/services/formHelper.js
5:27-38 "export 'default' (imported as 'actionTypes') was not found in 'redux-form/es/actionTypes'                                                          at HarmonyImportSpecifierDependency._getErrors (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:65:15)
    at HarmonyImportSpecifierDependency.getWarnings (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:39:15)
    at Compilation.reportDependencyErrorsAndWarnings (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/Compilation.js:694:24)
    at Compilation.finish (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/Compilation.js:552:9)                                                   at applyPluginsParallel.err (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/Compiler.js:506:17)
    at /home/hoschi/repos/gis/frontend/node_modules/tapable/lib/Tapable.js:289:11                                                                           at _addModuleChain (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/Compilation.js:498:11)
    at processModuleDependencies.err (/home/hoschi/repos/gis/frontend/node_modules/webpack/lib/Compilation.js:468:14)                                       at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

What is the expected behavior?
actionTypes should be build as actions so this error won't appear.
Sandbox Link

What's your environment?

redux-form: 7.1.1
npm: 3.10.10
webpack: 3.6.0
Other information

hotfix patched from v7.0.3 https://github.com/hoschi/redux-form/tree/hotfix/3509
and build so it can be used as npm dependency https://github.com/hoschi/redux-form/tree/hotfix/3509-build

This works for me: https://runkit.com/bertho-zero/59de0d619bf4d50012d3b285

It works in develop build without
yes, because it isn't configured to use tree shaking. But when this gets transformed to import actionTypes from 'redux-forms/es/actionTypes' it fails.

import { SET_SUBMIT_SUCCEEDED } from 'redux-form/es/actionTypes';

works


Desugar multiple assignment such that it returns rhs

We were not being faithful to what Ruby does with our multiple
assignment desugar. We were returning the result of a call to our magic
expand splat method which is almost always not what actually happens at
runtime.
Here is the result of the attached test case before this commit:

extend T::Sig

sig {returns(T.nilable(T::Array[Integer]))}
def foo
  nil
end

T.reveal_type((a, b = foo)) # Revealed type: T.any(T::Array[Integer], [NilClass, NilClass])
T.reveal_type((c, *, d = 100)) # Revealed type: [Integer(100), NilClass] (2-tuple)

Motivation
Fix #981 and be more faithful.
Test plan

See included automated tests.

Can you take the example from #981 and make it a test?

Ah sorry I missed it in the scroll back. It's there thank you.


Remove deprecation warnings

We had these deprecation warnings (among many others from inside pylint(!?)):
Warning: option required-attributes is obsolete and it is slated for removal in Pylint 1.6.
/src/edx/src/edx-lint/edx_lint/pylint/layered_test_check.py:44: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  dunder_test = node.locals.get("__test__")
/src/edx/src/edx-lint/edx_lint/pylint/right_assert_check.py:79: PendingDeprecationWarning: 'Getattr' is deprecated and slated for removal in astroid 2.0, use 'Attribute' instead
  if not isinstance(node.func, astroid.Getattr):

@cpennington sometimes you just have to clean things up.

:+1:


Probabilistic ".Next" page override

I have an experimental feature that I would like to implement on my website. The general concept is to model all page -> page transitions as a probabilistic event.

In the case of a permalink from one page to another, you can say it is drawing from a distribution over pages with 100% chance on that permalink'd page.
In the experimental case, all words on a page function as "links" -- they can send you to a page that is drawn from a distribution over a set of pages.

I see that Hugo already models a collection of pages for each page to support the .Next page-variable. Is there a way for me to flag a page such that the .Next operation is overridden by my own logic which does the probabilistic transition? I'm guessing this can be flagged as a custom front matter field.
One requirement is that, while the server-side may maintain a "prior" distribution of next pages for any given content page, I would like to be able to provide additional context with the next-page-request made from the frontend, such that the backend can produce a modified "posterior" distribution, i.e. a modified distribution based on the word that a user clicked.
Let me know if there is a path to implementing "customizability" of the .Next page handler. I am willing to contribute if desired, or simply fork and host my own custom version. Or, if there is already a way to implement my probabilistic feature, advice on how to best approach this within Hugo would be much appreciated. Thank you!

Thanks for getting in touch, but it feels like this is a question  that would be better suited to the Hugo Discussion Forum.  We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.


Wrong relative path for aggregate datasets

Depending on which of their file records is returned first, aggregate datasets are not found. The reason is that when the FI file record is returned, the additional "public" in the file path leads to the relation being returned as "aggregates" instead of correcty as "subjects"
I made a momentary fix by setting all FI recrods to exists=False, so they are no longer returned, but this should be fixed
https://github.com/int-brain-lab/ONE/blob/main/one/api.py#L1761
https://github.com/int-brain-lab/ONE/blob/main/one/util.py#L95

PR #105

Also set all file records to exist=True once this is released


Adding glibc-vs-musl examples

Adding some examples developed by @tdunlap607 for a guide comparing glibc and musl. There may need to be some fine tuning with a few files but this is the initial commit.

@erikaheidi thanks for clarifying!


fix assay generation / library input

PR checklist

[x] This comment contains a description of changes (with reason)
[x] CHANGELOG.md is updated
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Documentation in docs is updated
[x] If necessary, also make a PR on the nf-core/diaproteomics branch on the nf-core/test-datasets repo

should fix #41 #40

Very nice!

Thanks I will adress the points next week!

Ok, if you agree with the changes I'd be ready to merge.
The linting is failing because of sth. I changed about the AWS settings, as I'll need to do another template-update it will be fixed in the next PR.

ok, merging this into dev


Liquidity Mining, week 62

Co-authored-by: bakamoto20<EMAIL_ADDRESS>Ballers vote link: https://snapshot.org/#/ballersvote.eth/proposal/QmTiBKhkWVxJU4v1y8nZhbZeYyf4ghNuCznAx6e8RSvLfW
ETHEREUM CHANGES
None.
POLYGON CHANGES
WMATIC/USDC/QI/BAL/MAI pool moved from T3 to T4. This now receives 1,000 BAL per week.
WMATIC/USDC/WETH/BAL pool given an extra T3 slot, had a T4 slot removed. This now receives 7,500 BAL per week.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Other

How should this be tested?

[x]  Set system date to sometime next week; on mainnet the same pools should display the same LM APR in preview and prod
[x]  Set system date to sometime next week; on polygon,  the same pools should display the same LM APR in preview and prod, except for the changes in the pools mentioned above

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[x] My changes generate no new console warnings
[x] The base of this PR is master if hotfix, develop if not

6 votes in favor, ready to be merged @garethfuller ty


Wip file inputs

[x] I've read the CONTRIBUTING guidelines

This PR add support for make like file dependencies. Sbt will now track the output files of tasks that return Seq[File], File, Seq[Path], Path. Other tasks can then depend on these tasks and avoid re-running the dependent task if the output paths of the parent tasks have not changed. Moreover, the input files that are specified using the fileInputs key are automatically tracked in a continuous build.
To illustrate the power of this new functionality, I added a scripted test nio/make-clone that demonstrates the make like dependency management.
I copied the scripted test to a different console and ran a local version of sbt published off this build. I then ran the following commands:
sbt:make-clone> ~executeMain 1 2 3
[info] Not compiling libfoo: no inputs have changed.
[info] Not running linker: no outputs have changed.
[info] Not building /Users/ethanatkins/work/scratch/make-clone/out/main/main.out: no dependencies have changed
[info] Running /Users/ethanatkins/work/scratch/make-clone/out/main/main.out with arguments: '1', '2', '3'
[info] f := x * x * x
[info] f(1) = 1
[info] f(2) = 8
[info] f(3) = 27
Total time: 21 ms
  make-clone / executeMain                    : 9 ms
  make-clone / compileLib                     : 2 ms
  make-clone / linkLib                        : 1 ms
  make-clone / compileMain                    : 1 ms
  make-clone / compileLib / changedOutputPaths: 1 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:40:14 PM
[info] 1. Monitoring source files for updates...
[info] Project: make-clone
[info] Command: executeMain 1 2 3
[info] Options:
[info]   <enter>: return to the shell
[info]   'r': repeat the current command
[info]   'x': exit sbt

// I rewrote the file lib.c to change the function definition from `x * x * x` to `x * x` to trigger a build

[info] Build triggered by /Users/ethanatkins/work/scratch/make-clone/src/lib/lib.c. Running 'executeMain 1 2 3'.
[info] Compiling /Users/ethanatkins/work/scratch/make-clone/src/lib/lib.c to /Users/ethanatkins/work/scratch/make-clone/out/lib/objects/lib.o
[info] Linking /Users/ethanatkins/work/scratch/make-clone/out/lib/libfoo.dylib
[info] Building executable /Users/ethanatkins/work/scratch/make-clone/out/main/main.out
[info] Running /Users/ethanatkins/work/scratch/make-clone/out/main/main.out with arguments: '1', '2', '3'
[info] f := x * x
[info] f(1) = 1
[info] f(2) = 4
[info] f(3) = 9
Total time: 250 ms
  make-clone / compileMain                 : 101 ms
  make-clone / compileLib                  :  73 ms
  make-clone / linkLib                     :  54 ms
  make-clone / executeMain                 :   8 ms
  make-clone / linkLib / changedOutputPaths:   1 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:40:25 PM
[info] 2. Monitoring source files for updates...
[info] Project: make-clone
[info] Command: executeMain 1 2 3
[info] Options:
[info]   <enter>: return to the shell
[info]   'r': repeat the current command
[info]   'x': exit sbt

// Here I just touched the lib.c file

[info] Build triggered by /Users/ethanatkins/work/scratch/make-clone/src/lib/lib.c. Running 'executeMain 1 2 3'.
[info] Not compiling libfoo: no inputs have changed.
[info] Not running linker: no outputs have changed.
[info] Not building /Users/ethanatkins/work/scratch/make-clone/out/main/main.out: no dependencies have changed
[info] Running /Users/ethanatkins/work/scratch/make-clone/out/main/main.out with arguments: '1', '2', '3'
[info] f := x * x
[info] f(1) = 1
[info] f(2) = 4
[info] f(3) = 9
Total time: 25 ms
  make-clone / executeMain: 9 ms
  make-clone / compileMain: 1 ms
  make-clone / compileLib : 1 ms
  make-clone / linkLib    : 1 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:40:26 PM
[info] 3. Monitoring source files for updates...
[info] Project: make-clone
[info] Command: executeMain 1 2 3
[info] Options:
[info]   <enter>: return to the shell
[info]   'r': repeat the current command
[info]   'x': exit sbt
sbt:make-clone> compileLib/clean
Total time: 30 ms
  make-clone / compileLib / clean: 8 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:40:41 PM
sbt:make-clone> executeMain 4 5 6
[info] Compiling /Users/ethanatkins/work/scratch/make-clone/src/lib/lib.c to /Users/ethanatkins/work/scratch/make-clone/out/lib/objects/lib.o

// notice that compileLib / clean did force a rebuild of the lib.c file

[info] Linking /Users/ethanatkins/work/scratch/make-clone/out/lib/libfoo.dylib
[info] Building executable /Users/ethanatkins/work/scratch/make-clone/out/main/main.out
[info] Running /Users/ethanatkins/work/scratch/make-clone/out/main/main.out with arguments: '4', '5', '6'
[info] f := x * x
[info] f(4) = 16
[info] f(5) = 25
[info] f(6) = 36
Total time: 239 ms
  make-clone / compileMain: 100 ms
  make-clone / compileLib :  75 ms
  make-clone / linkLib    :  50 ms
  make-clone / executeMain:   8 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:40:46 PM
sbt:make-clone> linkLib / clean
Total time: 34 ms
  make-clone / linkLib / clean: 6 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:48:53 PM
sbt:make-clone> executeMain 1 2 3
[info] Not compiling libfoo: no inputs have changed.

// Notice that running linkLib / clean did not invalidate lib.o but did invalidate everything else in the chain

[info] Linking /Users/ethanatkins/work/scratch/make-clone/out/lib/libfoo.dylib
[info] Building executable /Users/ethanatkins/work/scratch/make-clone/out/main/main.out
[info] Running /Users/ethanatkins/work/scratch/make-clone/out/main/main.out with arguments: '1', '2', '3'
[info] f := x * x
[info] f(1) = 1
[info] f(2) = 4
[info] f(3) = 9
Total time: 235 ms
  make-clone / compileMain                            : 108 ms
  make-clone / linkLib                                :  92 ms
  make-clone / executeMain                            :   8 ms
  make-clone / compileLib                             :   2 ms
  make-clone / linkLib / changedOutputPaths           :   1 ms
  make-clone / compileMain / inputFileStamps          :   1 ms
  make-clone / compileLib / changedOutputPaths        :   1 ms
  make-clone / compileLib / allInputPathsAndAttributes:   1 ms
  make-clone / compileLib / changedInputFiles         :   1 ms
[success] Total time: 0 s, completed Apr 28, 2019 10:48:58 PM

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@a5ab32c775af39cd44a8b97fee2c9f7b70588d30

zinc
develop
sbt/zinc@dc94df28346eae2a6d1486ba59be6aeb96d9c3ce

io
pull/226/head
sbt/io@eae491f96e51670dfb8b2b3fd516bdb43d55692d

librarymanagement
develop
sbt/librarymanagement@f073dde812848ef443619578f55e290f3863bcaa

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@a5ab32c775af39cd44a8b97fee2c9f7b70588d30

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@eae491f96e51670dfb8b2b3fd516bdb43d55692d

librarymanagement
develop
sbt/librarymanagement@f073dde812848ef443619578f55e290f3863bcaa

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@a5ab32c775af39cd44a8b97fee2c9f7b70588d30

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@eae491f96e51670dfb8b2b3fd516bdb43d55692d

librarymanagement
develop
sbt/librarymanagement@f073dde812848ef443619578f55e290f3863bcaa

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

I need to fix a few scripted tests tomorrow and add a few commit messages, but I'm otherwise very happy with this.

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@a5ab32c775af39cd44a8b97fee2c9f7b70588d30

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@eae491f96e51670dfb8b2b3fd516bdb43d55692d

librarymanagement
develop
sbt/librarymanagement@18f4fc75e5b307bb8afef49865be23cff57c9111

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@7e80be7a020320252085695f39f93e9bcf0fdb42

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@a365362e35d56e0b578b2f6b8455f068169a8a57

librarymanagement
develop
sbt/librarymanagement@18f4fc75e5b307bb8afef49865be23cff57c9111

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@7e80be7a020320252085695f39f93e9bcf0fdb42

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@a365362e35d56e0b578b2f6b8455f068169a8a57

librarymanagement
develop
sbt/librarymanagement@18f4fc75e5b307bb8afef49865be23cff57c9111

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

I ran the scripted tests locally on my machine and there are 5 failing tests as of the current revision. I should be able to fix them without too much trouble.

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@9bf8076e22f30589942d0ccb1baf9d0abd7003b0

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@d1c6f0b1487f90f107e9fd954f52daa15b6c373a

librarymanagement
develop
sbt/librarymanagement@18f4fc75e5b307bb8afef49865be23cff57c9111

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@58c377e943040d94f8b831c85ca1e91d4e26a37f

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@d1c6f0b1487f90f107e9fd954f52daa15b6c373a

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@58c377e943040d94f8b831c85ca1e91d4e26a37f

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@d1c6f0b1487f90f107e9fd954f52daa15b6c373a

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@58c377e943040d94f8b831c85ca1e91d4e26a37f

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@d1c6f0b1487f90f107e9fd954f52daa15b6c373a

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@6d4a6457c35ff086df3eec97cfe30454cdb0384e

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@b630b5531d4554dcf6556970cea9cbeb3ff8a449

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@2a4c7d1204c54c3d0050482196948136772e418e

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@b630b5531d4554dcf6556970cea9cbeb3ff8a449

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@2a4c7d1204c54c3d0050482196948136772e418e

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@b630b5531d4554dcf6556970cea9cbeb3ff8a449

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@2a4c7d1204c54c3d0050482196948136772e418e

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
pull/226/head
sbt/io@b630b5531d4554dcf6556970cea9cbeb3ff8a449

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

Rebuilding since IO 1.3.0-M8 is out.

A validation involving this pull request is in progress...

For the record, Dbuild failed with
[sbt212] [error] Error: Total 15, Failed 0, Errors 1, Passed 14
[sbt212] [error] Error during tests:
[sbt212] [error] 	sbt.internal.util.SettingsTest

[sbt212:error] java.lang.StackOverflowError
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)
[sbt212:error] 	at sbt.internal.util.Init$Value.$anonfun$apply$3(Settings.scala:823)

AppVeyor failed on both Visual Studio 2015 and Visual Studio 2017
Running actions/clean-keep
[error] java.nio.file.FileSystemException: C:\Users\appveyor\AppData\Local\Temp\1\sbt_d62fda52\project\target\config-classes\$17a69f0703746b7bed64$.class: The process cannot access the file because it is being used by another process.
[error]
[error] 	at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
[error] 	at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
[error] 	at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
[error] 	at sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
[error] 	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
[error] 	at java.nio.file.Files.deleteIfExists(Files.java:1165)
[error] 	at sbt.io.IO$.$anonfun$delete$3(IO.scala:559)
[error] 	at scala.collection.Iterator.foreach(Iterator.scala:941)
[error] 	at scala.collection.Iterator.foreach$(Iterator.scala:941)
[error] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[error] 	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[error] 	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
[error] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
[error] 	at sbt.io.IO$.$anonfun$delete$2(IO.scala:557)
[error] 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[error] 	at sbt.internal.io.Retry$.liftedTree2$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.impl$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:50)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:24)
[error] 	at sbt.io.IO$.delete(IO.scala:555)
[error] 	at sbt.io.IO$.$anonfun$delete$3(IO.scala:558)
[error] 	at scala.collection.Iterator.foreach(Iterator.scala:941)
[error] 	at scala.collection.Iterator.foreach$(Iterator.scala:941)
[error] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[error] 	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[error] 	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
[error] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
[error] 	at sbt.io.IO$.$anonfun$delete$2(IO.scala:557)
[error] 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[error] 	at sbt.internal.io.Retry$.liftedTree2$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.impl$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:50)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:24)
[error] 	at sbt.io.IO$.delete(IO.scala:555)
[error] 	at sbt.io.IO$.$anonfun$delete$3(IO.scala:558)
[error] 	at scala.collection.Iterator.foreach(Iterator.scala:941)
[error] 	at scala.collection.Iterator.foreach$(Iterator.scala:941)
[error] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[error] 	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[error] 	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
[error] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
[error] 	at sbt.io.IO$.$anonfun$delete$2(IO.scala:557)
[error] 	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[error] 	at sbt.internal.io.Retry$.liftedTree2$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.impl$1(Retry.scala:38)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:50)
[error] 	at sbt.internal.io.Retry$.apply(Retry.scala:24)
[error] 	at sbt.io.IO$.delete(IO.scala:555)
[error] 	at sbt.io.IO$.$anonfun$delete$1(IO.scala:535)
[error] 	at sbt.io.IO$.$anonfun$delete$1$adapted(IO.scala:535)
[error] 	at scala.collection.Iterator.foreach(Iterator.scala:941)
[error] 	at scala.collection.Iterator.foreach$(Iterator.scala:941)
[error] 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[error] 	at scala.collection.IterableLike.foreach(IterableLike.scala:74)
[error] 	at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
[error] 	at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
[error] 	at sbt.io.IO$.delete(IO.scala:535)
[error] 	at sbt.scriptedtest.ScriptedTests.$anonfun$runBatchedTests$1(ScriptedTests.scala:332)
...
[error] (scripted) java.nio.file.FileSystemException: C:\Users\appveyor\AppData\Local\Temp\1\sbt_d62fda52\project\target\config-classes\$17a69f0703746b7bed64$.class: The process cannot access the file because it is being used by another process.

Yeah. I don’t understand the dbuild failure yet because the test doesn’t fail on my computer. I’ll investigate the windows issue.

Travis failed only on header check:
[error] (mainProj / Test / headerCheck) There are files without headers!
[error]   /home/travis/build/sbt/sbt/main/src/test/scala/sbt/internal/FileStampJsonSpec.scala

@eatkins Maybe try https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Thread.html#yield() instead of sleep(0) in retry? On .NET for instance apparently they mean slightly different things.

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@2a4c7d1204c54c3d0050482196948136772e418e

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
develop
sbt/io@984ec85b609664800366d375a49596487c7c3d9f

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:x: The result is: FAILED
(restart)

I have a reproduction of the windows issue on my VM. I should likely be able to fix it by tomorrow.

For Dbuild stackoverflow, I am bumping up the stack to see if it helps - https://github.com/sbt/sbt-validator/pull/46

A validation involving this pull request is in progress...

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project
Reference
Commit

sbt
pull/4627/head
sbt/sbt@479c2c21a9c6222655fc11fbb0407b391ae2b6b7

zinc
develop
sbt/zinc@b6fc35f27615f129f91de9ac14400101fb8b9b7e

io
develop
sbt/io@984ec85b609664800366d375a49596487c7c3d9f

librarymanagement
develop
sbt/librarymanagement@984de6fe7281eb715ad270245f7c6eb190f23def

util
develop
sbt/util@3568b13a2e257f33957dd32c51c56ce9c378c9f9

:white_check_mark: The result is: SUCCESS
(restart)


SPIKE: Forward proxy discussion with Team

Describe the issue
We foresee scenarios requiring a CPF controlled forward proxy that would allow us to Pathfind quickly without the delays to clients or iStore delays.
Additional context
Add any other context, attachments or screenshots
Definition of done

Jon to present to tech, PO and compliance and lead a 60min discussion around use cases, value prop
Draw.io drawings
Create tickets for any next steps

Let's pick this up next sprint (barring emergencies)


Plugin architecture

Introduce the plugin architecture: all readers are moved to a plugin.
A plugin can be static and embedded into libf3d or shared and have its own library.
The idea is to make heavy third-party dependencies (OpenCASCADE, Assimp, Alembic) completely optional at runtime, so people can install f3d and the plugins separately (e.g. Linux packagers can provide f3d relying on vtk only, and f3d-assimp depending on f3d and assimp).
Also, it makes f3d extendable if the users want to support proprietary formats by creating their own plugins.
Currently, f3d provides 5 plugins:

core: contains all the readers from VTK (built by default and forced to static plugin)
exodus: contains the Exodus reader (from the VTK module IOExodus)
alembic: contains the .abc reader
occt: contains the igs and stp readers
assimp: contains all the Assimp supported readers

Currently, it's not possible to create a plugin from the libf3d SDK, it has to be done from f3d source, but I plan to do it in the future.

Currently, it's not possible to create a plugin from the libf3d SDK, it has to be done from f3d source, but I plan to do it in the future.

I have a hard time imagining how to do that.

Currently, it's not possible to create a plugin from the libf3d SDK, it has to be done from f3d source, but I plan to do it in the future.

I have a hard time imagining how to do that.

Of course we cannot create static plugin in this case, but it does not look that difficult to me. We just have to deploy f3dPlugin.cmake, readerTpl.h.in, and other required files in the SDK.


Make "plan" optional when there is only one plan to choose from

Per the discussion in #1010 and our design meeting on Aug 7th, we agreed that:

ServiceInstance.Plan should be made optional, and when "plan" is not specified then:
If there is only one plan for the specified ServiceClass then we'll default to that plan
If there is more than one plan for the specified ServiceClass then we'll reject the request to create the new ServiceInstance

Related to this we should:

change the docs for UPS in the walkthru to remove the use of "plan" just to make a nicer U

Closes #1010

This will need to be implemented as an admission controller.

@duglin @vaikas-google do you have someone in mind to implement this?

@vaikas-google tells me he wants this one.


Is there any tutorial on converting ppt to markdown language, besides examples?

I tried to convert ppt to markdown language through python-pptx, but the converted result has no effect on md2pptx. How can I prefetch results similar to the markdown example you gave? Any good ideas?
And can it retain the original format, such as font style, size, position, etc.?
This is a good project! !

Hi. Thanks for your kind words.
Unfortunately md2pptx doesn't do what I think you're looking for:

It doesn't deal with .ppt at all (only .pptx).
It doesn't convert from .pptx to Markdown. It's the other way round: Generating .pptx from Markdown.

I don't expect it to ever do either of these. It is perhaps feasible to write a python-pptx script to extract elements from a .pptx file and convert some of them to Markdown format. But I don't intend this project to do that.


i have some issues about the independance of the circular progress bar

How can i run it own circle progress when 2 have multiple video, and when i run 1 video, all of circle have ran. Why and how to fix it?

Prepare a working example on codepen.io
Unfortunately, I can't help without it.


last v0.18 pre-release fixes

Fixes #2617
PR checklist:

[x] tested examples with the following backends: GL, DX11

Everything is running fine, no objections are raised, merging.
bors r=justice

bors r+


Upgrades the library "rand" version

Pull Request Test Coverage Report for Build 529063685

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-27.4%) to 52.731%

Files with Coverage Reduction
New Missed Lines
%

rsfbclient-native/src/connection.rs
1
73.49%

rsfbclient-rust/src/client.rs
3
79.37%

src/transaction/simple.rs
3
54.26%

src/connection/simple.rs
4
66.67%

Totals

Change from base Build 444519206:
-27.4%

Covered Lines:
1931

Relevant Lines:
3662

💛  - Coveralls


Directory structures should work for loading data

Provide user apis for loading data from GDrive.
Also @kayur.

This version of colaboratory is no longer supported, please switch to https://colab.research.google.com.


regression-test enhance the robustness and stability of Doris in handling semi-structure types

Proposed changes
Issue Number: close #xxx

Robustness and stability in handling semi-structured types, including JSON and VARIANT type data, were examined, and we aimed to comprehensively test the parsing behaviour of these types in a variety of invalid JSON formats

run buildall


fix(error): Report UnknownVariant

Don't unify it with syntax errors.

I will update my PR on https://github.com/serde-rs/json/pull/11 if this one is merged.

Ooh nice catch before I cut the release :)

On serde_json, I've also got 0.7 almost merged in. Give me a moment to do that.

I just saw another method invalid_value on de::Error trait, maybe you want to forward it through value::Error also.

@tomprogrammer: I'll take care of it, and the travis build failure.

Meh, the failure is a typo...
Thanks!

Closing as mentioned in #249.


Why making it this hard?

This is so hard to enable https. For cloud service or app service it is way easier.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ac102a5-e9ad-0046-f217-446f1ad263c5
Version Independent ID: a47523e2-0c30-dee4-0037-5f58836fa37f
Content: Add an HTTPS endpoint to an Azure Service Fabric application
Content Source: articles/service-fabric/service-fabric-tutorial-dotnet-app-enable-https-endpoint.md
Service: service-fabric
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@vturecek @masnider for FYI!


[FIZZ-152] initial SQL work and simple test, note integration tests not working yet

You will need to delete the old sqlite db (if exists) before running.  Or at least delete the Courses table.


Feature/sdk 8 save pin

Issue https://github.com/Tonomy-Foundation/Tonomy-ID-SDK/issues/8

wrong branch


fix PublishEvent: Add ClientInfo

In centrifuge-go a publish event (Publication struct) has 3 values - Offset, Data and Info (view implementation). But the java client only has 2 - offset and data.
This commit adds info to the PublishEvent class and sets it in the Client class.

@FZambia I've made the changes you've requested.

ClientInfo set to null if the protocol.ClientInfo == null
Added ClientInfo for PublishEvent
Added the same for ServerPublishEvent

Please review and let me know

@clmno great, thanks!


Ditched Meebey Entirely

Switched to the web socket wrapper for the actual IRC connection.
I added a very basic test console client for your evaluation.
This is what I mentioned at the end of the issue I opened regarding a port of SmartIrc4net to .NetStandard.
This is just here for evaluation now, would need to leave it running for a while, log messages / message counts with both clients and see how it holds up. It's basically the implementation twitch use themselves on the website.
Gets you down to 0 non Microsoft dependencies =)
(Well.. Newtonsoft.Json, but still :P)

Good work! Wow, I was planning on doing this when I got some free time from school but wow, this is awesome! I'll test it quite a bit before merging because it's an integral part of the library, so I want to make sure it's really stable.
Regarding Newtonsoft, ya there's no real way of getting around a json dependency I think. 3ventic offered Jil, a slightly more efficient json library, but it's not really important.
Going forward, I think I'm going to completely rewrite the parsing for events/messages  because right now time complexity is like quadratic, for no real reason.
Anyways, I digress. Will test this and merge!

Np man :)
There could be a bit of work required with reconnecting - possibility that the websocket isn't fully closed on a crash, but we will see :)
It's important to note Sends have to be done Synchronously over websockets

So a few things:

I merged this pull request into its own branch by the name of remove_smartirc4net ( https://github.com/swiftyspiffy/TwitchLib/tree/remove_smartirc4net ). Feel free to check that out and make pull requests to it as issues are discovered with the websocket client.
I just committed a fix for the \r\n appended to each irc message received by Trimming. This should suffice for this. Commit: 45dc25717f6d1717713c06d9116540ceaad7ead4
IsConnected is not being set to true I think because OnConnected is not firing (there might be a parsing issue that is causing this). This is a problem because a number of implementations I've seen rely on IsConnected to determine whether or not it's safe to send a message. I wasn't able to figure this one out in the limited time I had, but I'll give it another go tonight or tomorrow.

Cool man :)
We might be able to just use the state of the WebSocket, like this:
public bool IsConnected
{
 get
   {
      return Client.State == WebSocketState.Open;
   }
}

Ohhh, good idea. Will commit that now.

I've found why the connection event isn't processed.
It seems over the web sockets connection, the initial message from twitch on open is combined.
A single string is received:
":tmi.twitch.tv 001 prom3theu5 :Welcome, GLHF!\r\n:tmi.twitch.tv 002 prom3theu5 :Your host is tmi.twitch.tv\r\n:tmi.twitch.tv 003 prom3theu5 :This server is rather new\r\n:tmi.twitch.tv 004 prom3theu5 :-\r\n:tmi.twitch.tv 375 prom3theu5 :-\r\n:tmi.twitch.tv 372 prom3theu5 :You are in a maze of twisty passages, all alike.\r\n:tmi.twitch.tv 376 prom3theu5 :>"


Something interesting in your paper

📚 Documentation
i noticed the formula between (2) and (3) in your original paper:
log(P_bg) = log(P(bg | O_k = 1)P(O_k = 1) + P(O_k = 0))
the assumption P(bg | O_k = 0) = 1 can be easily understand, but i wonder what's your understanding of $P(bg | O_k = 1)P(O_k = 1)$ in the rvalue of the formula shown above. here's my opinions:
you use the law of full probability to decompose the entire process into 1st proposal stage and 2nd refine & classfication stage. P(O_k = 1) means the probability of foreground proposal prediction, while P(bg | O_k = 1) means given a foreground proposal but actually it belongs to background, the 2nd stage revise it to the background.
is that understanding correct?
/*
following that, here's another question: how to model the P(bg | O_k = 1) in you network and how to prove you do not acutally model the P(bg | O_k = 0) instead? is that the assumption P(bg | O_k = 0) = 1 works?
*/
i noticed something wrong with the question annotated above: the last linear layer (i.e. logistic/softmax regression) actually model the P(C_k | O_k) rather than specific condition O_k = 0 or O_k = 1, so the last question may not exist. backup for more people with the same misunderstanding.
appreciate your reply, thanks!

Links to the relevant documentation/comment:

Documentation
文件
i noticed the formula between (2) and (3) in your original paper:
我注意到你原始论文中第二和第三个公式:
log(P_bg) = log(P(bg | O_k = 1)P(O_k = 1) + P(O_k = 0))
Log (p _ bg) = log (p (bg | o _ k = 1) p (o _ k = 1) + p (o _ k = 0)
the assumption P(bg | O_k = 0) = 1 can be easily understand, but i wonder what's your understanding of $P(bg | O_k = 1)P(O_k = 1)$ in the rvalue of the formula shown above. here's my opinions:
假设 p (bg | o _ k = 0) = 1很容易理解，但我想知道你对上述公式 rvalue 中的 $p (bg | o _ k = 1) p (o _ k = 1) $的理解是什么。我的意见是:
you use the law of full probability to decompose the entire process into 1st proposal stage and 2nd refine & classfication stage. P(O_k = 1) means the probability of foreground proposal prediction, while P(bg | O_k = 1) means given a foreground proposal but actually it belongs to background, the 2nd stage revise it to the background.
使用完全概率法则将整个过程分解为第一阶段提案阶段和第二阶段精化分类阶段。
is that understanding correct?
这样理解对吗？
/* following that, here's another question: how to model the P(bg | O_k = 1) in you network and how to prove you do not acutally model the P(bg | O_k = 0) instead? is that the assumption P(bg | O_k = 0) = 1 works? */
/* 接下来，还有一个问题: 如何在你的网络中建立 p (bg | o _ k = 1)的模型，以及如何证明你实际上不建立 p (bg | o _ k = 0)的模型？假设 p (bg | o _ k = 0) = 1有效吗？*/
i noticed something wrong with the question annotated above: the last linear layer (i.e. logistic/softmax regression) actually model the P(C_k | O_k) rather than specific condition O_k = 0 or O_k = 1, so the last question may not exist. backup for more people with the same misunderstanding.
为更多有同样误会的人做后援。
appreciate your reply, thanks!
谢谢你的回复，谢谢！

Links to the relevant documentation/comment: 相关文件/评论的链接:

hello,I have some question about how to understand $P(bg | O_k = 1)P(O_k = 1)$... Do you understand the mean of  $P(bg | O_k = 1)P(O_k = 1)$ now?


Error: release dapper-woodpecker failed: no objects visited

Hi team,
I've used multi environment values in helm. when i try to do helm install with --debug i'm get below error
**helm install . --set tags.qa-values=true --tiller-namespace eait-sovereign-poc --debug
[debug] Created tunnel using local port: '36084'
[debug] SERVER: "<IP_ADDRESS>:36084"
[debug] Original chart version: ""
[debug] CHART PATH: /home/manoj/sovereign-cloud-helm-prime/charts/sovereign-prime-qa
Error: release dapper-woodpecker failed: no objects visited**
and my directory structure is. Please help me to understand the issue
.
├── charts
│   ├── sovereign-prime-int
│   │   ├── Chart.yaml
│   │   └── values.yaml
│   └── sovereign-prime-qa
│       ├── Chart.yaml
│       └── values.yaml
├── Chart.yaml
├── Chart.yaml_imp_bck
├── requirements.yaml
├── templates
│   ├── deployment.yaml
│   ├── _helpers.tpl
│   └── service.yaml
├── values.yaml
└── values.yaml_imp_bck
Output of helm version:Client: &version.Version{SemVer:"v2.8.1", GitCommit:"6af75a8fd72e2aa18a2b278cfe5c7a1c5feca7f2", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Output of kubectl version: kubectl version
Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.0", GitCommit:"fff5156092b56e6bd60fff75aad4dc9de6b6ef37", GitTreeState:"clean", BuildDate:"2017-03-28T16:36:33Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3+coreos.0", GitCommit:"f588569ed1bd4a6c986205dd0d7b04da4ab1a3b6", GitTreeState:"clean", BuildDate:"2018-02-10T01:42:55Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.): kubernetes

it seems like there are several issues here:

under the charts directory, each required chart should be in its own directory.
I see no templates in the required chart.

Does this help?

@maorfr thanks for very quick response, I've charts in each directory and template directory is also in place. could you please elaborate, I'm new to helm. If i use --dry-run, it is working. without dryrun it is failing with error no objects visited
├── charts
│   ├── sovereign-prime-int
│   │   ├── Chart.yaml
│   │   └── values.yaml
│   └── sovereign-prime-qa
│   ├── Chart.yaml
│   └── values.yaml
templates:
├── templates
│   ├── deployment.yaml
│   ├── _helpers.tpl
│   └── service.yaml

notice that there aren't any templates directories under the charts/* directory, which means there aren't any resources to deploy...
I would expect something along the lines of:
├── charts
│ ├── sovereign-prime-int
│ │ ├── templates/ (and more files here)
│ │ ├── Chart.yaml
│ │ └── values.yaml
│ └── sovereign-prime-qa
│ │ ├── templates/ (and more files here)
│ |  ├── Chart.yaml
│  | └── values.yaml

notice that there are 2 directories now, sovereign-prime-int and sovereign-prime-qa, and no files outside of them.

In addition, if both sovereign-prime-*  are the same chart as the name indicates, you should provide different values using the default values.yaml instead of treating them as two different charts.

perfect, now it is working.  i didnt create template in environment directories. Thank you very much for ur help.


Playground fails to load - session storage value for "redux" is null

Page is blank. Console shows this error:
8cc65fe859fbd039fa13.js:1 Uncaught TypeError: Cannot read property 'version' of null
    at deserialize (8cc65fe859fbd039fa13.js:1)
    at 8cc65fe859fbd039fa13.js:1
    at 8cc65fe859fbd039fa13.js:1
    at 2db6ccab5336953f0406.js:1
    at u (2db6ccab5336953f0406.js:1)
    at Module.334 (8cc65fe859fbd039fa13.js:1)
    at i (8cc65fe859fbd039fa13.js:1)
    at Object.176 (8cc65fe859fbd039fa13.js:1)
    at i (8cc65fe859fbd039fa13.js:1)
    at n (8cc65fe859fbd039fa13.js:1)
deserialize @ 8cc65fe859fbd039fa13.js:1
(anonymous) @ 8cc65fe859fbd039fa13.js:1
(anonymous) @ 8cc65fe859fbd039fa13.js:1
(anonymous) @ 2db6ccab5336953f0406.js:1
u @ 2db6ccab5336953f0406.js:1
334 @ 8cc65fe859fbd039fa13.js:1
i @ 8cc65fe859fbd039fa13.js:1
176 @ 8cc65fe859fbd039fa13.js:1
i @ 8cc65fe859fbd039fa13.js:1
n @ 8cc65fe859fbd039fa13.js:1
(anonymous) @ 8cc65fe859fbd039fa13.js:1
(anonymous) @ 8cc65fe859fbd039fa13.js:1

Specifically, at this line:
https://github.com/integer32llc/rust-playground/blob/master/ui/frontend/local_storage.ts#L32
the deserialized parseState value is null because the string given to JSON.parse is "null"
The value comes from the caller here:
https://github.com/integer32llc/rust-playground/blob/master/ui/frontend/storage.ts#L45
where the storage.getItem() call added in https://github.com/integer32llc/rust-playground/commit/f2f84d172df07ede11b8a0f6f105c0bf13d52940 returns "null". The key is "redux" This is in fact the only key in the session storage.
$ window.sessionStorage
> Storage {redux: "null", length: 1}

The "null" stored in session storage comes from the try-catch here:
https://github.com/integer32llc/rust-playground/blob/master/ui/frontend/storage.ts#L36-L37
The first time the page is loaded and the key doesn't exist, storage.getItem() returns null, which the storage.setItem in the next line stringifies and stores as "null". The next storage.getItem() will then load the same "null" back.
Since the setItem was explicitly added there to test for being able to set session storage in https://github.com/integer32llc/rust-playground/commit/f2f84d172df07ede11b8a0f6f105c0bf13d52940, perhaps deserialize should handle both undefined and JSON.parse() returning null to mean the same.

Spot on analysis! I... wish I had read my issues before doing my own investigation 😊

which the storage.setItem in the next line stringifies

This was my key mistake. That's behavior I didn't want and didn't expect.

perhaps deserialize should handle both undefined and JSON.parse() returning null to mean the same.

I agree. Done in #434
Thank you for providing such thorough analysis!

The fix has been pushed; because the playground has stronger caching, you will either need to wait 24h or force a reload of the page.


Hanging on for a long time and exiting with NPE

It seems like a timeout issue with the OPENAI interface, but even after enabling a global proxy, the problem remains unresolved.
The error message is too vague to locate the bug.
Platform: Windows 11
JDK: Oracle JDK 11
Maven: 3.9.1

After some debugging, it was found that there was indeed a network connection issue. I switched to a foreign server, and finally, it ran successfully.
VPS: Vultr
Region: Bangalore
OS: Ubuntu 22.10 x64
JDK: OpenJDK 11
Maven: 3.6.3

Resolved by this commit, we added the support of running with proxy.