upgrade to guice 4.2.0

Hi, thanks. Sorry it took so long.
I committed your first set of changes. Not sure about the second force push, so I left it out.
Regards.

Hi, i'm sorry, that commit was intended for another repository, ignore it
but since you have seen it: I'm planning to use your library in a new project and my toolchain can't really handle gradle, so i'm converting it to maven; maybe both can live alongside or i can push only the other changes

Hi, thanks for the comment. I see, I am glad to hear you are using the project!
Honestly I am not ready for maven maintenance, quite yet, so if you could help me with just the application itself for now that would be great 👍

But there’s no need, maybe it’s better to look into publishing the artefact in github as it is and then you can install it in your project however you wish.
https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-apache-maven-for-use-with-github-packages

On 7 Mar 2020, at 13:16, Rodion Moiseev<EMAIL_ADDRESS>wrote:

Hi, thanks for the comment. I see, I am glad to hear you are using the project!
Honestly I am not ready for maven maintenance, quite yet, so if you could help me with just the application itself for now that would be great 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

But there’s no need, maybe it’s better to look into publishing the artefact in github as it is and then you can install it in your project however you wish.

You're right, but i've found some "bugs" and missing features i need to implement (that i will share) and i'm more comfortable with maven

Yeah the thing is that gradle is more popular these days so it might be better for a open source tool to be in gradle :/

On 7 Mar 2020, at 17:43, Michele Preti<EMAIL_ADDRESS>wrote:

But there’s no need, maybe it’s better to look into publishing the artefact in github as it is and then you can install it in your project however you wish.
You're right, but i've found some "bugs" and missing features i need to implement (that i will share) and i'm more comfortable with maven
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yeah the thing is that gradle is more popular these days so it might be better for a open source tool to be in gradle :/
don't get me wrong, but i think this is debatable,
anyway i will try to push only fixes without maven related things

Hi guys!
Maybe I am missing something, but I think you are talking about different things. I will quickly summarize my thoughts:
c10n build system: gradle or maven?
For compiling, testing and building/publishing packages, I would like to stick to gradle. I have nothing against maven, but I am not so enthusiastic about this system.
I understood that @lelmarir was offering to use maven build in parallel with gradle. This is possible, but would complicate maintenance, hence my response.
Package repository: maven central vs. github packages
Currently, I prioritize maven central. It makes it easy for others to use c10n as dependency, as maven central is well integrated into most build systems I know, including gradle and maven.
For some time, I was publishing to a custom-made repository directly in github (under the c10n-maven-repo/ folder). Honestly, I forgot why I really had to do that. Probably it was before I had publishing access maven central.  This repository is very dependent on how Github exposes static resources, and afaik the URLs have changed a few times and are not stable. Now that Github is offering its own package repository system with disk quota, I would not be surprised if they restricted my custom-made repository all together. I will probably need to remove it sometime soon.
As for Github Packages, I took a quick look, and in conclusion it seems superfluous in the context of c10n project. For users that use my mainstream c10n dependencies, maven central should do the trick.
Individual repository needs
If you need to make fixes/updates to c10n and make them quickly accessible to your own projects, then I will recommend that you maintain your own fork and your own package repository, as @lelmarir seems to be doing. This way you can ensure you can deploy your fixes fast an in the way that works best for you.
I will try merge your fixes as fast as I can into the mainstream, but realistically I may not be able to build an official mainstream package with your fixes fast, as I have to verify the patch and prepare a release. Also, I may not accept the merge request as-is as it may conflict on some levels.
Conclusions for now
For the mainstream c10n project:

Build system will be gradle (I will eventually look into updating it to the latest version, as it's getting pretty old)
Package publishing will be maven central (via sonatype)
I will look into removing the c10n-maven-repo/ as it seems to be going against Github Packages project, and is pretty old and not bringing value afais

Thanks

I'm sorry to have caused problems,
as i said, the maven thing push was a mistake, it was never intended to be in this repository.
My other project uses maven, so I had to convert this to maven to allow me to do fast integrations with my IDE (can't mix maven and gradle projects).
I understand that this project uses gradle and i have no intention to change it, but since i'm using maven anyway i let you know just in case.

@lelmarir (cc: @kevinrobayna) no worries! I appreciate any constructive feedback!
Let's close the topic for now.
If any of you would like to propose some new build management or package management for the future, please open a new issue and we can discuss it there. Cheers!

Hi,
not sure if this is the right place, but i'd like to share with you that I've pushed my latest commit to my fork.
Unfortunately right now i don't have time to create te push request (as i told you i neet to use maven and i don't have the time right now to filter it out).
But I was to think that meanwhile i could share my changes so you can peek :)

thanks! Will take a look later this weekend.

@lelmarir Hi. I took a quick look at what you did in the last two commits. Here are my thoughts:

The ICU4J formatter works best as a custom message formatter using C10NConfigBase.setMessageFormatter().  The custom implementation of MessageFormatter can exist in your source base, so there is no need to modify C10N source, as far as I can tell. For Guice users you can do something like this (not tested):

       C10N.configure(new C10NConfigBase() {
            @Override
            protected void configure() {
                setMessageFormatter( new ICU4JMessageFormatter() );
            }
        });
        ... Guice.createInjector(C10NModule.scanAllPackages()).getInstance( MessageInterface.class );

With regard to automated Enum mapping binding for Guice, I do like the idea. After some thought, I think it would be better to achieve it by extending C10N like I have described in #47. Please take a look and tell me what you think 👍
Seems like you added a addC10NConfig method to C10NModule class, to extend C10N configuration. I think you should be able to equally do this by a prior call to C10N.configure( <your custom C10N config >), just like I did in the example above. Currently, Guice extension relies on the global static configuration object declared at the beginning of C10N class, because internally it's just making a call to C10N.get(<interface class>) static method. If you need to create multiple separately-configured C10NMsgFactory instances using C10N.createMsgFactory(), then this approach will not work. In that case you'll need to pass your own C10NMsgFactory instance to the scanAllPackages() method, and make it use that factory, instead of the global static root factory referenced by the C10N.get() method.

Also it looks like you have moved guice extension source into its own top-level module (i.e. c10n/ext-guice/ directory. This is definitely a good idea 👍 . I should do the same.

The custom implementation of Message Formatter can exist in your source base
ok, no problem, i just thought it would be usefull in the base library.

I think you should be able to equally do this by a prior call to C10N.configure
Yes, but I don't really like to call a static config method inside a guice module (i know it will anyway), using a mode guice-oriented configuration seem more clean to me.
I know that multiple modules would fail (they will use the same static instance); maybe i need to add a ceck to ensure only one exists.

Seems like you added a addC10NConfig method to C10NModule class, to extend C10N configuration

i almost forgot: I added the method because if i call C10N.configure as you suggest it would replace the previous config made by the module (or the module one would be replaced).
Instead i need to extend the base configuration provided by the module (the enum binding)
is this legit?


healthcheck filter: min_length constraint on headers to match

Hi
We have observed in our internal tests a set of counters not increased after implementation of a graceful shutdown mechanism using /healthcheck/fail endpoint.
We followed suggestion from this comment  and our solution looks good enough for our scenario.
But we noticed an unexpected side-effect when it comes to the Dynamic HTTP stats. None of them are increased.
Repro steps:
We are using v1.13.0.
We reproduced in a simpler setup with docker-compose, still happening. One envoy routing requests to service1 or service2 according to the header in the request.

Configure the http_filter for envoy.healthcheck.
Send an HTTP request towards a service.
Get stats.

expected behaviour -> upstream_rq_completed = upstream_rq_total = 1 for the service who got the request
current behaviour --> upstream_rq_completed = 0 , upstream_rq_total=1
Removing the envoy.healthcheck filter behaviour is the expected one.
Conf:
envoy.config.txt
Our sample services are based on Docker image tiangolo/uwsgi-nginx-flask:python3.6-alpine3.7 running a python service.
Logs:
We added two traces in router.cc just to confirm problem was with stream_info.healthcheck() method:
L323
ENVOY_STREAM_LOG(debug, "sokaran - chargeUpstreamCode '{}'", *callbacks_,                      callbacks_->streamInfo().healthCheck());
L1307
ENVOY_STREAM_LOG(debug, "sokaran - onUpstreamComplete '{}'", *callbacks_,                      callbacks_->streamInfo().healthCheck());
We can see in both cases this is true:
[2020-04-01 22:18:20.008][18][debug][conn_handler] [source/server/connection_handler_impl.cc:353] [C2] new connection
[2020-04-01 22:18:20.008][18][debug][http] [source/common/http/conn_manager_impl.cc:263] [C2] new stream
[2020-04-01 22:18:20.008][18][debug][http] [source/common/http/conn_manager_impl.cc:731] [C2][S14309476495007524334] request headers complete (end_stream=true):
':authority', 'localhost:8000'
':path', '/service/2'
':method', 'GET'
'user-agent', 'curl/7.58.0'
'accept', '*/*'
'x-service', '1'

[2020-04-01 22:18:20.008][18][debug][http] [source/common/http/conn_manager_impl.cc:1276] [C2][S14309476495007524334] request end stream
[2020-04-01 22:18:20.008][18][debug][router] [source/common/router/router.cc:476] [C2][S14309476495007524334] cluster 'service1' match for URL '/service/2'
[2020-04-01 22:18:20.009][18][debug][router] [source/common/router/router.cc:616] [C2][S14309476495007524334] router decoding headers:
':authority', 'localhost:8000'
':path', '/service/2'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.58.0'
'accept', '*/*'
'x-service', '1'
'x-forwarded-proto', 'http'
'x-request-id', '6f80cca1-cbf4-4498-ada8-f7262fe6d85a'
'x-envoy-expected-rq-timeout-ms', '15000'

[2020-04-01 22:18:20.009][18][debug][pool] [source/common/http/http1/conn_pool.cc:95] creating a new connection
[2020-04-01 22:18:20.009][18][debug][client] [source/common/http/codec_client.cc:34] [C3] connecting
[2020-04-01 22:18:20.009][18][debug][connection] [source/common/network/connection_impl.cc:691] [C3] connecting to <IP_ADDRESS>:8080
[2020-04-01 22:18:20.009][18][debug][connection] [source/common/network/connection_impl.cc:700] [C3] connection in progress
[2020-04-01 22:18:20.009][18][debug][pool] [source/common/http/conn_pool_base.cc:55] queueing request due to no available connections
[2020-04-01 22:18:20.009][18][debug][connection] [source/common/network/connection_impl.cc:563] [C3] connected
[2020-04-01 22:18:20.009][18][debug][client] [source/common/http/codec_client.cc:72] [C3] connected
[2020-04-01 22:18:20.009][18][debug][pool] [source/common/http/http1/conn_pool.cc:244] [C3] attaching to next request
[2020-04-01 22:18:20.009][18][debug][router] [source/common/router/router.cc:1715] [C2][S14309476495007524334] pool ready
[2020-04-01 22:18:20.010][18][debug][router] [source/common/router/router.cc:1117] [C2][S14309476495007524334] upstream headers complete: end_stream=false
[2020-04-01 22:18:20.010][18][debug][router] [source/common/router/router.cc:324] [C2][S14309476495007524334] sokaran - chargeUpstreamCode 'true'
[2020-04-01 22:18:20.010][18][debug][http] [source/common/http/conn_manager_impl.cc:1615] [C2][S14309476495007524334] encoding headers via codec (end_stream=false):
':status', '200'
'content-type', 'text/html; charset=utf-8'
'content-length', '93'
'server', 'envoy'
'date', 'Wed, 01 Apr 2020 22:18:19 GMT'
'x-envoy-upstream-service-time', '1'
'x-envoy-upstream-healthchecked-cluster', 'test'

[2020-04-01 22:18:20.010][18][debug][client] [source/common/http/codec_client.cc:104] [C3] response complete
[2020-04-01 22:18:20.010][18][debug][router] [source/common/router/router.cc:1308] [C2][S14309476495007524334] sokaran - onUpstreamComplete 'true'
[2020-04-01 22:18:20.010][18][debug][pool] [source/common/http/http1/conn_pool.cc:201] [C3] response complete
[2020-04-01 22:18:20.010][18][debug][pool] [source/common/http/http1/conn_pool.cc:206] [C3] saw upstream close connection
[2020-04-01 22:18:20.010][18][debug][connection] [source/common/network/connection_impl.cc:101] [C3] closing data_to_write=0 type=1
[2020-04-01 22:18:20.010][18][debug][connection] [source/common/network/connection_impl.cc:192] [C3] closing socket: 1
[2020-04-01 22:18:20.010][18][debug][client] [source/common/http/codec_client.cc:91] [C3] disconnect. resetting 0 pending requests
[2020-04-01 22:18:20.010][18][debug][pool] [source/common/http/http1/conn_pool.cc:136] [C3] client disconnected, failure reason:
[2020-04-01 22:18:20.010][18][debug][connection] [source/common/network/connection_impl.cc:531] [C3] remote close
[2020-04-01 22:18:20.011][18][debug][connection] [source/common/network/connection_impl.cc:531] [C2] remote close
[2020-04-01 22:18:20.011][18][debug][connection] [source/common/network/connection_impl.cc:192] [C2] closing socket: 0

stats:
cluster.service1.upstream_rq_active: 0
cluster.service1.upstream_rq_cancelled: 0
cluster.service1.upstream_rq_completed: 0
cluster.service1.upstream_rq_maintenance_mode: 0
cluster.service1.upstream_rq_pending_active: 0
cluster.service1.upstream_rq_pending_failure_eject: 0
cluster.service1.upstream_rq_pending_overflow: 0
cluster.service1.upstream_rq_pending_total: 2
cluster.service1.upstream_rq_per_try_timeout: 0
cluster.service1.upstream_rq_retry: 0
cluster.service1.upstream_rq_retry_overflow: 0
cluster.service1.upstream_rq_retry_success: 0
cluster.service1.upstream_rq_rx_reset: 0
cluster.service1.upstream_rq_timeout: 0
cluster.service1.upstream_rq_total: 2
cluster.service1.upstream_rq_tx_reset: 0

So, did we understand something wrong when we implemented this /healthcheck/fail endpoint?
We have found several issues related with stats and healthchecks but I did not see any actual relation with our problem.
Any help it is very appreciated. Thank you so much.

@mattklein123 seems like a bug to me, what is your take on this behavior?

The issue is that you have not specified any headers to match on: https://github.com/envoyproxy/envoy/blob/6a5c3c2b43b83044ccba3510ec6c725cbdc12f2e/api/envoy/extensions/filters/http/health_check/v3/health_check.proto#L46
So I think every request is being counted as a health check request. I don't think this is the configuration you want. I'm going to leave this as as bug and marked help wanted as I think now that the deprecation is complete and we an freeze v0, we should be able to add a min_length constraint on the v3 proto, but I need to check with @htuch on that. At minimum we could do it in the code.

@mattklein123 in general we can't add additional constraints to a frozen/active API, unless there was no possible sensible behavior if that constraint wasn't there before, i.e. it was 100% implied. So, if it's in that category, sure, let's do it.


additional functions

They're useful and easy to add, but may as well wait until they become relevant, i.e. when enketo-validate is there or they have been merged in javarosa.
https://bitbucket.org/m.sundt/javarosa/pull-requests/9/added-sin-cos-tan-exp-and-more-trig/diff

done


build(deps): bump snakeyaml from 1.33 to 2.0

should resolve CVE-2022-1471

That's finally a 2.0? Woohoo! Thanks for the PR!

Thanks for the quick merge, I'll look forward to the release (and hopefully dep-check can stop nagging about it) :laughing:


Question

Hello bro I want to know where did you get the files for the greeting challenge ?

I just inspect the elements
I am still trying to reverse engineer the back end
But I am very new to node


[spring boot] Add commercial (HeroDevs) support for EOL versions

The changes planned are:

update dates for commercial support
add HeroDevs as support option in support table
add herodevs tag.

@AndreAngelantoni if herodev commencial support is mentioning in  related product's own webpage we can add it otherwise it will bring responsibility to us which we never accept. So Does herodevs mentioned in springboot's own page or not ? if not we need to close this issue record


Vagrant dev and integration testing environment

The PR here contains the start of a nice little dev and integration testing environment. It launches a virtual network with multiple virtual machines:
There are a few things that are not done. This epic is to add those missing parts.

You can also use ansible if you like to provision the environment instead of using embedded shell provisioning blocks like I did. Here's more information on them in case this sounds interesting:

No changes to your machine but changes virtual machines in env https://www.vagrantup.com/docs/provisioning/ansible_local.html
Needs changes to your host machine https://www.vagrantup.com/docs/provisioning/ansible.html

Also note that we have several devops scripts already written for Gorjun. Might be worth taking a look at those too.

https://github.com/marcoarthur/gorjun-perl-cli/blob/master/lib/Gorjun/Build.pm is specifically suited for building Gorjun and control startup, shutdown, and logging. Helping deploying gorjun for dev environment.


Release 1.0.0

Added

Build an OFX file
Add sample project

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.711%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
597

Relevant Lines:
597

💛  - Coveralls


fix wallet search when gt, gte, lt, lte and like are used with encryp…

Bugfix. Now error is properly returned when wrong type is used.
I also added tests for $like (that exist for other predicates) which were missing before

@Artemkaaas @vimmerru please review. CI is passed


Line statements eat newlines

Line statements eat not only the spaces until the beginning of the line as documented at  http://jinja.pocoo.org/docs/templates/#whitespace-control , but also all the previous newlines.
As of  2.7-dev, the following code generates no empty lines:
%% for i in range(3)
{{i}}, next line should be empty

%% endfor

This is an issue in languages where newlines matter (generated LaTeX).

Newlines after a end control bloc (endif, endfor) are still eaten up:
%% for i in range(2)
hello
%% endfor

I want to be alone

renders as =>
hello
hello
I want to be alone

Is this expected behavior? This doesn't make sense to me regarding the documentation.

This has been resolved a long time ago, but I'm not sure why. I still see my newlines eaten up with line statements on version 2.10.3...
Any way of getting this to work?


why random labels are used for training of d_g?

In 03_CGAN_MNIST
(1) d_loss_real = discriminator.train_on_batch(x=[X_batch, real_labels], y=real * (1 - smooth))
(2) d_loss_fake = discriminator.train_on_batch(x=[X_fake, random_labels], y=fake)
(3) d_g_loss_batch = d_g.train_on_batch(x=[z, random_labels], y=real)
To train the discriminator, you first train for X_batch with real_labels then X_fake with random_labels. I think this should be real_labels instead of random_labels in equation 2.
To train the generator, in equation (3), why you take random_lables for training the d_g instead of real_labels?
Thank you.

Thank you for your reply.


[hdf5] fix: add support for aarch64 _Float16 16-bit floating point type

Fixes #39759 .

@microsoft-github-policy-service agree

@WangWeiLin-MV   The check on the x86_windows platform seems to be not quite right

Please run vcpkg x-add-version hdf5 --overwrite-version to fix version db.


ComboxPopUp DefaultTemplate not correct

Hi,
In your demo project, if you remove the margin "16" in the MainWindow and also in TextFields, then you add a new row in the grid, then add
<ComboBox Grid.Row="20" Grid.Column="0"  Grid.ColumnSpan="10" materialDesign:HintAssist.Hint="OS">                 <ComboBoxItem>Andoid</ComboBoxItem>                 <ComboBoxItem>iOS</ComboBoxItem>                 <ComboBoxItem>Linux</ComboBoxItem>                 <ComboBoxItem>Windows</ComboBoxItem>             </ComboBox>
Launch it full screen and you will see that the combo box is not drawn properly.
In fact, the SelectedItem is not inside the "comboxpopup header". So you think that this element is not belonging to the popup.

I hope you can fix this template.
Thanks,

When combobox doesn't have enough space to show suggestion list right under the selecteditem, it shows list out like standard combobox do.
Maybe the solution of this problem is to somehow mark the selecteditem that this list belongs to it or show selecteditem in the suggestion list when it stands out.
Also, you can use ComboBoxAssist.ShowSelectedItem in order to show selecteditem in the drop down list.

@l1pton17 I think if we have to display in "classic Windows" mode we should probably do the ShowSelectedItem==true behaviour by default.

@ButchersBoy yeah, i thought about it when i was typing previous message :smile:

Excellent Thanks!


unknown import: ethereum::ethereum.call has not been defined

Summary
This happens when a file data source handler uses contract calls directly or is in the same AssemblyScript file as other handlers which use contract calls. If the contract call is done by a different handler in the same file, this can be fixed by putting the file data source handler in its own file, which is best practice.
Potential Fix
Contract calls in file data source handlers could be enabled by somehow passing the ethereum.call host fn when instantiating an offchain data source, relevant code:
https://github.com/graphprotocol/graph-node/blob/92670f27d93ed08a6e83805ad644d9004d4d77ee/runtime/wasm/src/host.rs#L137-L141

This is still relevant - @leoyvens does this fail at build-time or at runtime?


manage lsst-daq interface name on dhcp client nodes

Repushed with a whitespace fix (I'm surprised the linter didn't catch it).


updating github documentation structure

As the previous PR suggested, it is important to keep a small overview on the github repo of all the contents of the repo. We started with adding all README documents, I will add info into them as soon as possible. But in the meanwhile we should urge every new module PR to include this information themselves!
Spread the word!

:+1:


Issue: <Title for brief intro about this issue. 'Issue: ' prefix>

Issue you'd like to raise.
微信群已满，可不可以再开一个新群？
Suggestion:
No response

On the way 了


Updated documentation for latest release and added troubleshooting

Referenced Issue: None
Description
I found it a bit confusing as someone who is not too familiar with Maven why the command for generating the maven archetype was not working after following the README.
Turned out the the documentation wasn't updated for the latest release, so I was instead trying to invoke the previous snapshot version, causing the error.
To try and help other devs that may run into this issue, I updated the documentation to the latest snapshot version and added a troubleshooting section explaining how to find the latest version of the archetype.
Please review :)

Hey @asharron, thanks for opening the PR! Now that https://github.com/adobe/aem-spa-project-archetype/pull/102 is merged, it should no longer be necessary to specify a version once we release to the Central Repository. So, I suggest we close this PR to keep the README simple :)


Line Chart missing axis Y

The Axis Y disappear in my case.
Here is image of my chart
https://imgshare.io/image/sans-titre.HSQQi
Here is my code
<XYPlot width={700} height={700}>
                        <XAxis
                            on0={true}
                            tickSize={0}
                            title="X"
                            style={{title: {fontSize: '1rem'}, line: {stroke: '#b5b5b5'}, text: {display: 'none'}}}/>

                        <YAxis
                            on0={true}
                            tickSize={0}
                            title="y"
                            style={{title: {fontSize: '1rem'}, line: {stroke: '#b5b5b5'}, text: {display: 'none'}}}/>

                        <LineSeries key="coupon-maximum"
                            color="#041d5e" strokeWidth={3}
                            data={[{x: 100, y: 10}, {x: 130, y: 10}]} />

                        <LineSeries key="seuil-autocall"
                            color="#97b749"
                            data={[{x: 100, y: 0}, {x: 100, y: 10}]} />

                        <LineSeries key="barriere-to-seuil-autocall"
                            color="#041d5e" strokeWidth={3}
                            data={[{x: 40, y: 0}, {x: 100, y: 0}]} />

                        <LineSeries key="coupon-to-barriere"
                            color="#041d5e" strokeWidth={3}
                            data={[{x: 26, y: -3}, {x: 40, y: 0}]} />

                        <LineSeries key="support"
                            color="#041d5e" strokeWidth={0}
                            data={[{x: 100, y: 13}, {x: 130, y: 13}]} />

                    </XYPlot>

I can't say for sure, but it might be a few things

i don't think setting the on0 prop is necessary (tbt i didn't know that was a prop)
try setting the tickSize to not zero
make sure you've imported the css file (see readme for more details)

Thanks for your reply :)
For the setting on0 prop, i saw it in this example
. It work correctly before, but after a few modify on data, i got a problem above.
I tried to take of on0 and tickSize.
Here is the case that I take of on0
https://ibb.co/YhspbKR
Here is the case that I take of tickSize
https://ibb.co/n1RGN1f
And here is the chart I need to do:
https://ibb.co/TMpBPPN
I've already checked css imported. It's ok. Do you have any suggestion?


fix(v2): use page title from config if not set

Motivation
Fixes #4549
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try remove title prop from Layout component of any page and make sure that title from config has been used.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

LGTM thanks 👍


Mismatched .net support for managed functions.

The table lists support for .NET 7.0, for managed functions, but the constraints version of the same table is missing .NET 7.0 making it unclear if it's supported or not.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 173dedb1-f043-0f9f-4799-7bad3e146d60
Version Independent ID: b544c1e4-6df2-0604-f125-423a196528fe
Content: API support in Azure Static Web Apps with Azure Functions
Content Source: articles/static-web-apps/apis-functions.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@LittleBoxOfSunshine
Thanks for your feedback! We will investigate and update as appropriate.


Issue in IE while removing nodes and batch select.

Hi, I got an error in IE while it tries to remove the nodes.
Fixed it by replacing node.remove();  by $(node).remove();
Also, (and just as a suggestion), the event that can be captured for selectionContainer can be 'click'. In this way, IE will trigger the event even when the checkbox properties indeterminate is true and checked is false.
Great work! and hope this helps to you
Cheers!
Leo

Ok, some other people have commented on the IE node.remove() thing so I'll fix it for now. As for the click event, can you explain that more? Thanks.

When you click on a node that is indeterminate = true, IE doesn't triggers the OnChange event.
This means that all the code involved in the event listener for selectionContainer is not going to run.
However, if you change the event to click, it will make the deal. Basically when you click the checkbox you are changing the value, so it will behave as expected in any browser.
Make sense ?
Cheers!
Leo

c7c9acaf84762fe91781a1f1b51856c59d8c8443


Add instances method

Summary
To be consistent with qiskit-ibm-provider, there should be an instances() method that returns all instances the user is in (quantum channel only).
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 4 (25.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 73.981%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/qiskit_runtime_service.py
1
4
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
2468

Relevant Lines:
3336

💛  - Coveralls


Return specific Problem when form version in submission not found

Closes #629, where if the submission XML is missing the version string or has a version that doesn't match any known version for that form, the response returns a generic 404 error message. Now it returns a more informative 404 error message.
The 404 resource not found is an artifact of how when we have a specific version to look for, our form query has these specific constrains and it's easy to reject if we don't find what we are looking for.
The approach of this PR changes that flow a bit: if we don't find the right form and form def/version that the submission is targeting, we look again without the specific version constraint. If we find something when we look that way, then it's a problem with the form version. It feels like extra work, but it'll lead to clearer error messages.
It seems like we only check for the form version when dealing with a published form. For draft forms, the version in the submission doesn't actually have to match (maybe it should? it would be more code..) It may not be that necessary because all the submissions for that draft will be purged when the draft is purged (via publishing or deleting).

What has been done to verify that this works as intended?
Tests.
Why is this the best possible solution? Were any other approaches considered?
Open to discussing other options... this is very focused on the version. I think if the user gets the project ID or xmlFormId wrong, the original rejection is appropriate.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Clearer error messages, which will especially help API users and ourselves when writing tests!
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
I don't think we document the nuances of such errors.
Before submitting this PR, please make sure you have:

[x] run make test-full and confirmed all checks still pass OR confirm CircleCI build passes

It seems like we only check for the form version when dealing with a published form. For draft forms, the version in the submission doesn't actually have to match (maybe it should? it would be more code..)

Ah very interesting, it's good to know it works that way. I don't have strong feelings about whether it's important to check that. Maybe it'd be sensible to do so, but it also feels low-priority.

Open to discussing other options... this is very focused on the version. I think if the user gets the project ID or xmlFormId wrong, the original rejection is appropriate.

If the user gets the project ID or xmlFormId wrong, then I think they'll get stopped before they reach the code that you're modifying. I think in that case today, they'll get stopped by the getOrNotFound before ensureDef.
Right now, Forms.checkWrongFormVersion() calls Forms.getByProjectAndXmlFormId() again in order to decide whether to reject with a Problem.user.formVersionNotFound() or with the Problem from ensureDef() (a generic Problem.user.notFound()). But I'm wondering whether the latter case is a real possibility / whether there are two different cases here. If getOrNotFound() is catching cases where the project ID or xmlFormId is wrong, then I think the only way that form.def.id == null is if the form version string in the submission doesn't match a published form version, which is the Problem.user.formVersionNotFound() case. So could we skip the second Forms.getByProjectAndXmlFormId() and just reject with a Problem.user.formVersionNotFound() if form.def.id == null? Or maybe I'm misunderstanding how the flow here works. 😅

I don't think we document the nuances of such errors.

Not yet! Though hopefully we will at some point once we've completed #753.

if the submission XML is missing the version string or has a version that doesn't match any known version for that form, the response returns a generic 404 error message.

I don't think it's inherently a problem if the submission is missing the form version string. If it's missing the form version string, then I think it falls back to an empty string:
https://github.com/getodk/central-backend/blob/c90025b65f3232c1b6b61f9ee99eecf43a23a910/lib/model/frames/submission.js#L63
Then if there's a published form version whose version string is an empty string, then the submission will match that.


Missing comma on fallbackOnBody and fallbackClass

Adding a comma after the following statement, will make the options section valid javascript.
fallbackOnBody: false to fallbackOnBody: false,

thx


Adding support for json responses from CLUSTER_SERVERS

Adding json support to RemoteFinder and RemoteReader. Some existing tests verified on inconsistent behavior, and this calls for thorough review.

Looks like I have some character encoding issues to fix in py3.x. Will tackle tomorrow.

I think you should use StringIO instead of BytesIO

Is there a particular reason for wanting to use json over say msgpack?  I ask because the payloads are much larger with json so performance is likely to suffer quite a lot for larger queries.

@DanCech , based on some analysis that I ran recently and shared in this gist, json should be more performant on all metrics. Since the names of metrics aren't schema'd, there's really few savings in either space or compute (at least where I was testing on 2.7). If we wanted to take on an additional dependency, ujson is an amazing drop in replacement json library (the perf is bananas).
Again, the above tests are local, somewhat contrived, and on python2.7, but the differences were pretty stark. The implementation of umsgpack embedded in graphite does not appear to be particularly performant, probably because it's a pure-python implementation (as opposed to something with native bindings).

@clusterfudge : did you test proper msgpack module, like u-msgpack-python ?
Json just can't be faster then msgpack, that's completely counter-intuitive. :)

Serializer: test_json_buffer Payload Size: 80000
0.0690968036652
Serializer: test_json_stream Payload Size: 80000
0.0695509910583
Serializer: test_pickle_buffer Payload Size: 90006
0.590715885162
Serializer: test_pickle_stream Payload Size: 90006
18.5478489399
Serializer: test_umsgpack_buffer Payload Size: 90003
0.598016023636
Serializer: test_umsgpack_stream Payload Size: 90003
4.51842188835
Serializer: test_msgpacku_buffer Payload Size: 90003
0.0120220184326
Serializer: testumsgpacku_stream Payload Size: 90003
0.0128359794617```

I used the message pack module that's embedded in graphite-web. Is that a fall back if the native implementation isn't installed?

Sorry, not really getting what you mean, @clusterfudge
Pure python version of modules is good for fallback, but performance sucks, obviously.
If you need speed - just install an optimized version of the module.
msgpacku is the same drop-in replacement for msgpack, as ujson for json.

Serializer: test_json_buffer Payload Size: 80000
0.0708241462708
Serializer: test_json_stream Payload Size: 80000
0.0717329978943
Serializer: test_ujson_buffer Payload Size: 70001
0.0287759304047
Serializer: test_ujson_stream Payload Size: 70001
0.0259568691254

Serializer: test_umsgpack_buffer Payload Size: 90003
0.641237020493
Serializer: test_umsgpack_stream Payload Size: 90003
4.80740189552
Serializer: test_msgpacku_buffer Payload Size: 90003
0.012020111084
Serializer: test_msgpacku_stream Payload Size: 90003
0.0133380889893

msgpacku is the same drop-in replacement for msgpack, as ujson for json.

Ooh, I was wrong, disregard that. msgpack is proper implementation, umsgpack is pure pyton, msgpacku is utf-8 wrapper.

Just did serialize benchmark one more time - looks like json is still fastest serializer from default Python distribution, both for 2 and 3. Msgpack is fastest when msgpack module is installed, with cbor on 2nd place, but CBOR also suffering from stream deserialization...
py2
Serializer: test_json_buffer Payload Size: 80000
0.111679077148
Serializer: test_json_stream Payload Size: 80000
0.0857601165771
Serializer: test_pickle_buffer Payload Size: 90006
0.968269109726
Serializer: test_pickle_stream Payload Size: 90006
19.1805100441
Serializer: test_msgpack_buffer Payload Size: 90003
0.0109009742737
Serializer: test_msgpack_stream Payload Size: 90003
0.0110709667206
Serializer: test_umsgpack_buffer Payload Size: 90003
0.940215110779
Serializer: test_umsgpack_stream Payload Size: 90003
4.4617190361
Serializer: test_cbor_buffer Payload Size: 90003
0.0151782035828
Serializer: test_cbor_stream Payload Size: 90003
3.91015386581

py3
Serializer: test_json_buffer Payload Size: 80000
0.11116572699999999
Serializer: test_json_stream Payload Size: 80000
0.10955180199999998
Serializer: test_pickle_buffer Payload Size: 90026
0.040406074000000014
Serializer: test_pickle_stream Payload Size: 90026
3.492091802
Serializer: test_msgpack_buffer Payload Size: 90003
0.018487617999999983
Serializer: test_msgpack_stream Payload Size: 90003
0.01901640300000018
Serializer: test_umsgpack_buffer Payload Size: 90003
1.0347651600000005
Serializer: test_umsgpack_stream Payload Size: 90003
4.593411390999999
Serializer: test_cbor_buffer Payload Size: 90003
0.022226440000000736
Serializer: test_cbor_stream Payload Size: 90003
3.972988451000001

Well, IIRC cluster transport is an internal thing and was never published as a public API. Before Graphite 1.x only picklie was supported, which is python internal and schemaless, then @DanCech implement msgpack for speed and Metrictank interoperability...

Are you still interested in implementing this, @clusterfudge ?

I'm not; with the native python-msgpack library is installed, performance is perfectly acceptable.


Nimble Python SDK modules, setup and README files

Looks good! My only suggestion is to add the parameter type to docstrings. So:
id : Identifier for the access control record.
becomes
id (NSObjectId) : Identifier for the access control record.

But an NsObjectId is really a string at the end of the day.  Shouldn't we just deal with a string rather than a wrapper type?

It seems to me that using the Nimble (wrapper) types will be clearer in the long run as they often carry restrictions that, say, a Python string doesn't. My (perhaps outdated) documentation indicates that a NSObjectId is not just a string, but rather, "A 42 digit hexadecimal number", for instance. So, providing the Nimble type, rather than the base type forces the user to be aware of any such restrictions that might exist.
But, my larger point was just that types would be helpful. Both "id (string)" and "id (NSObjectId)" provide more  information to the user than just "id".

Yes, it's a 42 digit hexadecimal number but its json-type is a string.  I think part of the purpose of having the SDK is to eliminate this type of complexity.  When it matters, we should expose it.  When it doesn't, we should strive to keep it simple.


[inetstack] Move to async functions

Context
The inetstack is still using futures directly instead of async functions.
Proposed Solution
Remove all direct uses of Future and replace with async fn to let the compiler generate futures.

Closed with #977


Users are very confused about how cuddling with their spouse could be high risk

Not sure what to do about this. Your risk from someone depends on that person's behaviors in the past 10 days, not on your relationship status with them. But people have been told seeing people in their own household is extremely safe. I don't really know how we want to clarify this or what the users' mental model is.
see also #173

and in general I think people are not using "partner" to represent "hoookup with stranger". I think we do need to provide a better "hookup with stranger" option.

We could split the scenario into "Intimate with a random person in your city" and "Intimate with a partner with whom you live and socialize exclusively" to set it on the other end of the spectrum.
We seem to not be the only ones struggling here - covidcanidoit lists kissing a live-in partner as a moderate risk https://covidcanidoit.com/US/ca/activity/kissing-live-in-partner and watching a movie with a live-in partner as a high risk https://covidcanidoit.com/US/ca/activity/see-a-movie-with-live-in-partner.

I think I'd fix this as follows:
Interaction type -> Frequency:

One time - something you do once. 6% per hour
Housemate / repeating - something you do regularly. 30% flat rate.

Partner / Spouse - Remove from this list! It doesn't describe a frequency

Distance:

10 ft
6 ft
3 ft
touching mouths - We don't know why spouses have higher transmission rates, but all possible transmission modes (large droplets, aerosols, fomites) are maximized if you make out. Use the partner transmission rate regardless of duration.


Change the spread of background cards

Hi, I have a question, is there a way to change the spread of background cards?. I would like to change it to zero. I mean, just one photo on top of stack without using fullscreen image or Positioned.fill .

Thank you!

Wow, sorry but I realize what I can do for this issue. I can use a SizedBox which wrap my SwipableStack. Sorry again and thank you!


Cannot run "gpte" on macOS 14.2.1 -- zsh: command not found: gpte

I installed via:
python3 -m pip install gpt-engineer
(the default python is python2 on macOS, so I used python3)
neil@neils-MacBook-Pro ~ % pip3 show gpt-engineer|grep Location
Location: /Users/neil/Library/Python/3.9/lib/python/site-packages
I verified my path includes the site-packages of python 3.9:
export PATH=/Users/neil/Library/Python/3.9/lib/python/site-packages:$PATH
I restarted my terminal
Still, every time I get "zsh: command not found: gpte"

Hi @laphlaw! It seems that if you're using the command:
export PATH=/Users/neil/Library/Python/3.9/lib/python/site-packages:$PATH
and then restarting your terminal, the PATH variable isn't retaining the Python path. When you use export directly in the terminal, it only applies to the current session. Once you restart or open a new terminal, the setting is lost, which is why you're encountering the issue.
To make the change permanent, you should add that export command to your .zshrc file. This way, the Python path will automatically be set every time you open a new terminal or restart it.


make utility functions (xml2ebml, ebml2xml, etc.) CL utilities

The setup.py script can be configured to turn the utility functions for this package (i.e., any of xml2ebml, ebml2xml, and view) into command-line utilities. The aim is to improve accessibility for these utilities. See links for details on how to do so:

https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html#the-scripts-keyword-argument
https://docs.python.org/3/distutils/setupscript.html#installing-scripts

Some brief looking into things, here's my proposed changes:

Fix utils.py in place, fix the imports so that it can be imported in another file as ebmlite.utils.  This will not work as a command line utility.
Create a new file in a separate module to use as a command line tool.
Modify the directory structure as such:

\ebmlite\

\ebmlite\  # the actual regular ebmlite stuff

\utils.py  # assorted utility functions

\tests\  # just tests
\bin\  # command line utillities

\ebmlite_utils.py  # command line interface to ebmlite.utils that imports things correctly

Suggestion: if the utilities are going to be separated from util.py, they might as well be individual tools, e.g. ebml2xml.py, xml2ebml.py, and ebmlview.py.

yeah, that would make the CLI easier to use.

I think this was resolved in PR #46.


Windows host support

This project could fill a contentious gap for cross-platform development. On Windows, many devs are now using WSL2 as a Linux dev environment with all the advantages that are usually lost when developing in a Linux guest i.e. automatic file sharing, networking etc.
When you enable WSL2 on Windows 10, you must enable the hyper-v hypervisor, this is what the actual WSL2 VM runs on. But this causes complications and performance issues when using other hypervisors like VirtualBox and VMware. Using vagrant-libvirt inside WSL2 is possible on Windows 11 (and through live patching on Win10) but the created networks aren't available in Windows and port forwarding doesn't work.
On Windows, its possible to install a msys2 compiled variant of QEMU from https://qemu.weilnetz.de/ which can use the 'whpx' accelerator on Windows, think KVM for Windows. Android devs would be familiar with this since that's what Android Studio uses to emulate and accelerate (x86 only) android devices.
But as of v0.1.9 of this plugin, it uses at least two features that the Windows version of QEMU doesn't support, namely:

The -nodaemonize arg
Use of unix sockets

So in combination with vagrant-sshfs for folder sync, this plugin could be a truly portable, non-root solution for vagrant on Mac, Windows and Linux.
Another win for this approach, is the seamless cross-arch support that it implies i.e. arm-on-x86 and vice-versa
Please consider this a placeholder ticket for others who hit this issue, and as a possible launch point from where these issues can be resolved.

plan:
*[ ] add "control_port", "debug_port" to use tcp socket instead of unix socket
*[ ] use ruby's build-in socket support, remove the dependency on "nc"
*[ ] skip the "-nodaemonize" arg for Windows

Since my opening comment I've learned two additional data points:

Vagrant is planning on migrating to golang for v3.0 and they've already embedded a prototype binary along with the recently released v2.3, so I wonder what the future viability for Ruby plugins is...perhaps they will be parsed in some way, along with the planned HCL format.
Lima recently integrated barebones Windows host support, more info here https://github.com/lima-vm/lima/issues/909

I think their may still be room for this plugin, and if it aligns with Vagrant's v3 golang migration plan, it will be ready for that key cross-platform, cross-arch use case.

Please try 0.3.0

Thanks @ppggff I tested 0.3.1 and got further, qemu is running in background but it looks like getpgid() is not implemented on Windows.
2: from C:/Users/admin/.vagrant.d/gems/2.7.6/gems/vagrant-qemu-0.3.1/lib/vagrant-qemu/driver.rb:27:in `get_current_state'
         1: from C:/Users/admin/.vagrant.d/gems/2.7.6/gems/vagrant-qemu-0.3.1/lib/vagrant-qemu/driver.rb:170:in `running?'
C:/Users/admin/.vagrant.d/gems/2.7.6/gems/vagrant-qemu-0.3.1/lib/vagrant-qemu/driver.rb:170:in `getpgid': getpgid() function is unimplemented on this machine (NotImplementedError)

Thanks a lot.
Please try 0.3.2, I replaced getpgid() with kill(0, ) to check wether qemu process is running.

Yes my VM will boot in 0.3.2, it can set the hostname and ssh works, but with some caveats:

Needed to set cpu as qemu64 since default 'host' raised unable to find CPU model 'host' on Windows. Might be better to not set this at all, and let qemu infer it from machine type
Had some issues related to UEFI EDK2 firmware that are known issues on Windows, at least as of v7.1.0. Worked around this by rebuilding VM using default BIOS. Maybe using pflash for x86_64 like you do for aarch64 instead of -bios extra arg might fix this (untested)
Needed to comment out hardcoded -vga none I guess my VM (CentOS 6) requires a video card to boot, but difficult to diagnose without console! I think an option to easily enable GUI is needed soon.

Some initial bugs remaining, destroy fails with:
2: from C:/Users/admin/scoop/apps/vagrant/2.3.0/embedded/mingw64/lib/ruby/2.7.0/fileutils.rb:1474:in `platform_support'
         1: from C:/Users/admin/scoop/apps/vagrant/2.3.0/embedded/mingw64/lib/ruby/2.7.0/fileutils.rb:1460:in `block in remove_dir1'
C:/Users/admin/scoop/apps/vagrant/2.3.0/embedded/mingw64/lib/ruby/2.7.0/fileutils.rb:1460:in `rmdir': Directory not empty @ dir_s_rmdir - C:/Users/admin/git/packer/.vagrant/machines/c6/qemu/b0CWnXJBZSs (Errno::ENOTEMPTY)

It's good news that it can boot. Please provide your Vagrantfile, I thinks I need to find a Windows machine to fix remained problems.

Heres the snippet of config I'm using for this plugin:
    config.vm.provider "qemu" do |qe,override|
        qe.arch = "x86_64"
        qe.machine = "type=q35,accel=whpx"
        qe.smp = "1"
        qe.memory = "1G"
        # default 'host' causes qemu-system-x86_64: unable to find CPU model 'host' on windows
        qe.cpu = "qemu64"  # max causes 'Unexpected VP exit code 4'
#         qe.extra_qemu_args = %w(-bios c:/Users/admin/scoop/apps/qemu/current/share/edk2-x86_64-code.fd)
        qe.net_device = "virtio-net-pci"
        qe.qemu_dir = "c:\\Users\\admin\\scoop\\apps\\qemu\\current\\share"
        qe.no_daemonize = true
        qe.control_port = 33333
        qe.debug_port = 33334
        override.vm.synced_folder ".", "/vagrant", type: 'sshfs'
      end

Sorry I won't be able to share the complete Vagrantfile since its internal, I'll setup a generic example perhaps using the stock CentOS 7 box like in your example. You could possibly use Github Actions to test functionality on all platforms, although without acceleration.


feat(Storage): Refactor header modification and PR review comments iteration.

Is this a better design?
https://github.com/googleapis/google-cloud-php/pull/6055


ability to change default fling springDescription of AnimationController

i'm proposing to allow changing the default springDescription for the AnimationController. changing it for a single fling call is already possbile via parameter on the same name. to not change it every time we use the fling, we could just allow changing the default one for a whole controller

As mentioned on the PR: Not sure why this would be useful. The spring description can already be modified directly when calling the fling method. Adding another property that's only relevant for one methods would make the API more confusing, though.

this would make it more convenient if you often use fling per some controller instance. i don't agree this would make api any more complicated, i could remove this from constructors though
a controller design mistake that we have only one controller both for simulations and ordinary transitions - this what can make people be more confused than this i believe


specify multiple columns in a single hash

For example when I do
tp systems, :system => {:display_method => :name}, :epic => {:display_method => :xyz}
The second column will never be displayed. It is also not called it seems. I can specifiy any symbol, existing method or not. Only system column is displayed.
-@ostraaten

Make it possible to specify two columns within a single hash, instead of forcing you to add curly braces to turn each column into its own hash

lol, should have looked at issues sooner, I just found this issue 😜
require 'table_print'
tp [{first: "Josh", last: "Cheek"}],
   :first,
   :last,
   # full:     -> u { "#{u[:first]} #{u[:last]}"}, # <-- uncommenting this causes username to be omitted
   username: -> u { "#{u[:first][0]}#{u[:last]}"[0, 8].downcase }

# >> FIRST | LAST  | USERNAME
# >> ------|-------|---------
# >> Josh  | Cheek | jcheek


Media mute button requires double click to toggle it's state

Current Behavior:
On page load, before player has started playing, the media mute button requires double clicking before it's able to toggle on/off.
Once audio is playing, the mute button seems to behave as normal (single click on/off).
Not sure whether this is only related using vidstack in a Wails app (desktop app framework, similar to Electron but with Go backend).
Expected Behavior:
Mute button should toggle on/off with a single click regardless of media player state.
Steps To Reproduce:

Install wails CLI.  https://wails.io/docs/gettingstarted/installation
Clone minimal repro: https://github.com/dominictwlee/vidstack-repro-mute
cd frontend
npm install
cd ..
wails dev

Environment:

Framework: React
Meta Framework: Wails/Vite
Node: 16.16.0
Device: Desktop
OS: Pop!_OS 22.04 LTS (Linux/Ubuntu)
Browser: WebView (webkit2gtk)

Anything Else?
Hard to show behavior in screenshot. Try clicking/double clicking the mute button in the minimal repro.

This issue is outdated now since our new 1.0@next release. If the issue persits after upgrading, feel free to let me know here and we can reopen. If the issue has changed then please open a new one.


Implemented navigation helpers rb file

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RST-2859
Description

Created a navigation helpers rb file and added go_to method to it to avoid having go_to method in page objects

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

These changes have been incorporated into RST-2950 ticket.


defer should not be in loop

Signed-off-by: Sonia Singla<EMAIL_ADDRESS>

Codecov Report

Merging #584 (bf6c2e3) into master (8431671) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   48.55%   48.55%
=======================================
  Files          73       73
  Lines        3359     3359
=======================================
  Hits         1631     1631
  Misses       1572     1572
  Partials      156      156

Impacted Files
Coverage Δ

db/kubernetes/convert.go
61.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8431671...bf6c2e3. Read the comment docs.

@Z0Marlin Can you review this PR.?

@soniasingla Can you update on this PR?

cc: @soniasingla


AzureFileCopy: fix vm copy issue

Task name: AzureFileCopyV5 and V6
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N) https://github.com/microsoft/azure-pipelines-tasks/issues/19685
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected

When will this be available as Version 7 of the AZCopy Task??
We cannot deploy because of the careless bug that this change is supposed to have fixed.
This is a critical, urgent problem for us.


VM crashes when opening kitty through default installation

Hyprland Version
v0.33.1
Bug or Regression?
Bug
Description
Installed basic hyprland setup for arch linux inside a vm. 3D acceleration is active. I triple-checked that all dependencies are installed.
Running Hyprland shows the default installation with the basic config. Pressing SUPER + Q to open kitty crashes the entire vm.
Says it wants to read some specific memory address. The address never changes. No crash report was generated.
The file manager dolphin works just fine, though I did not test any other applications.
How to reproduce

Install basic arch linux using the latest iso on a vm.
Follow the hyprland installation tutorial.
Run hyprland and press SUPER + Q

Crash reports, logs, images, videos

Translation:
The instruction in first address points to memory in second address. The process read couldn't be executed.

I think that's a problem with your vm. There is a nullptr deref somewhere in it, it seems.

So, looked for some vm settings I could change, but none seemed to fix it. I found this stack trace using journalctl. Not sure if it helps. I have no idea what is happening here. This error repeats a few times before the vm crashes.

that looks like a throw from a failed init, check your logs


How to get the depth value corresponding to the color in the depth image?

I got some depth images that were previously taken by others using the Intel RealSense Viewer tool and stored as ".RAW" files and ".PNG" files. I want to be able to get depth data directly from these depth images instead of the Intel Realsense D435 device.Our project requirements require specific depth values, at least to the nearest 0.01.  How can I open a ".RAW" file or a ".PNG" file and get depth data?Or how to get the depth value corresponding to the color in the depth image?

Three days ago, I mentioned this question, but it was not completely solved. See
https://github.com/IntelRealSense/librealsense/issues/2200

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
You can refer to "rs-align" example. And, use below code to get the depth value in the aligned color. Hope this is helpful.
const int w_other = other_frame.asrs2::video_frame().get_width();
const int h_other = other_frame.asrs2::video_frame().get_height();
cv::Mat otherMat(cv::Size(w_other, h_other), CV_8UC3, (void*)other_frame.get_data(), cv::Mat::AUTO_STEP);
const int w_aligned = aligned_depth_frame.asrs2::video_frame().get_width();
const int h_aligned = aligned_depth_frame.asrs2::video_frame().get_height();
cv::Mat alignMat(cv::Size(w_aligned, h_aligned), CV_16U, (void*)aligned_depth_frame.get_data(), cv::Mat::AUTO_STEP);
imshow("AlignFrame", alignMat);
.....
To get the frame center's depth: alignMat.at(w_aligned/2, h_aligned/2)

Hello @njnydxzc ,
The ".RAW" data is just a blob of the data transmitted over USB. The data layout is according to the UVC spec for the depth stream . It is intended for machine vision and tools such as matlab/opencv , as suggested in  #2200.
Depth ".PNG" provides a colorized version of the depth suitable for human representation. Since the colorizer uses histogram equalization It is not possibly to extract depth data directly.
As for the other question, in order to create depth<->rgb correspondence librealsense provides "align" processing block (see rs-align demo).
In case you only have recorded depth and color in raw/bin formats then you'll still be able to use the "align" APIs but you'll have to write code to perform it manually:
Prerequisites:
Depth frames in ".RAW/.BIN" format + stream intrinsic.
Color frames in RGB/PNG format + stream intrinsic.
Depth<->Color extrinsic.
A sync map between Depth to Color frames that can be based on frame id or timestamp.
Flow:

Create "rs2::software_device"(rs-software-device demo).
Add synthetic streams for depth and color including  intrinsic/extrinsic data.
Create and feed a synchronized pair of depth/color to synthetic streams with data obtained from ".RAW"/".PNG" files.
Use the synthetic frames as inputs to "align" block to produce "A aligned to B" frame.
Repeat [3,4] for all pairs of depth/color

Sorry, I didn't find the code of "rs-align" example in the SDK.
Which header files do I need to use to run this code?

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
The rs-align sample code in below link. And, you need to include the opencv header like "#include <opencv2/opencv.hpp>" if you like to use above code.
https://github.com/IntelRealSense/librealsense/blob/53537d4a5115d0abbd79e5379eaa93d701344e4f/examples/align/readme.md

Depth data is available through the Realsense D435 device. Why can't I get deep data when I open a picture with OpenCV? Is it because the depth data is not saved?

Depth data is available through the Realsense D435 device. Why can't I get deep data when I open a image with OpenCV? Is it because the depth data is not saved?

Thank you for your reply.@RealSense Customer Engineering
If I don't have a Realsense D435 device connected, how do I define the types of  other_frame and aligned_depth_frame in the code  and load the image?

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
My way is for active streams from D435. How about @ev-mp's suggestions to handle the RAW and PNG data?
Or, you can have the RGB and depth aligned, and then have the record and playback as the example "record-playback".

Thank you for your reply.@RealSense Customer Engineering
Our project wants to use a deep learning algorithm, so we will collect the images in advance and then process them.So, I want to know if there is a way to get deep data from a saved image without D435.

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
Suggest to try @ev-mp's align flow if the saved PNG/RAW files used. And, RAW file has the depth data.

Is there a function that can be used directly to get deep data in a ".RAW" file?

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
Since the RAW data layout is according to the UVC spec for the depth stream, you can try below sample code to get the 16bit depth data:
FILE fp = NULL;
int framesize = IMAGE_WIDTH * IMAGE_HEIGHT;
fp = fopen(fileName, "rb");
imagedata = (char)malloc(sizeof(short) * framesize);
fread(imagedata, sizeof(short), framesize, fp);
cv::Mat depthMat(Size(IMAGE_WIDTH, IMAGE_HEIGHT), CV_16U, (void*)imagedata, cv::Mat::AUTO_STEP);
// show the depth frame central value from the raw data
printf("Depth RAW Central Value: %d mm", depthMat.at(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2));

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
still need any support for this topic?

Thank you for your reply.@RealSense Customer Engineering
When I run the code,“ depthMat.at(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2)" reports an error.
Which header files do I need to use to run this code?

"depthMat.at(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2)" is ok .

"depthMat.at(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2)" is ok .

"depthMat.at(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2)" is ok .

Thank you for your reply.@x-jeff.
Which header files do I need to use to run this code?

#define _CRT_SECURE_NO_WARNINGS #include<iostream> #include<opencv2/opencv.hpp>; using namespace std; using namespace cv; int main(){ 	int IMAGE_WIDTH = 424, IMAGE_HEIGHT = 240; 	FILE* fp; 	char* imagedata; 	int framesize = IMAGE_WIDTH*IMAGE_HEIGHT; 	fp = fopen("C:/personal document/SegmentationAlgorithm/grabcut/GrabcutTest/record/frame1/d_Depth.raw", "rb"); 	imagedata = (char*)malloc(sizeof(short)* framesize); 	fread(imagedata, sizeof(char), framesize, fp); 	cv::Mat depthMat(Size(IMAGE_WIDTH, IMAGE_HEIGHT), CV_8U, (void*)imagedata, cv::Mat::AUTO_STEP); 	printf("Depth RAW Central Value: %d mm", depthMat.at<uchar>(IMAGE_HEIGHT / 2, IMAGE_WIDTH / 2)); 	fclose(fp); 	free(imagedata); 	return 0; }
This is my code, the code can run normally, you can refer to it.

Thank you for your reply.@x-jeff.
I got some data from the code, but it doesn't seem to be very accurate. Does the data need to be extra processed to make it more accurate?

[Realsense Customer Engineering Team Comment]
Hi @njnydxzc,
you mean your depth data from RAW is not accurate? How is its accuracy error? ex: more than 2% error within 2m?

@RealSense Customer Engineering
I first got deep data through the "Intel RealSense Viewer" tool. Then, I save the depth image and get the depth data of the same coordinate through the code. The two data are not the same.

@x-jeff @RealSense Customer Engineering
I have solved the problem. Thank you very much for your help.
If I have other problems, I will  create another new issue.

@x-jeff @RealSense Customer Engineering
I have solved the problem. Thank you very much for your help.
If I have other problems, I will create another new issue.

Hello, I  have the same problem as you, could you tell me how you solved it in the end？

【Realsense客户工程团队点评】 你好@njnydxzc,
你的意思是你的RAW深度数据不准确？它的精度误差如何？例如：2m 内误差超过 2%？

There are errors in my depth image. I filtered the depth flow, but I could not extract the depth flow after filtering.
There is an error in the program.
`align_to = rs.stream.color
align = rs.align(align_to)
# Streaming loop
while True:
    # Get frameset of depth
    frames = pipeline.wait_for_frames()
    aligened_frames=align.process(frames)
    aligened_depth_frame=aligened_frames.get_depth_frame()

    color_frame=frames.get_color_frame()

    spatial=rs.spatial_filter()
    spatial_depth=spatial.process(aligened_depth_frame)

    temporal = rs.temporal_filter()
    temporal.set_option(rs.option.filter_smooth_alpha, 0.1)
    temporal.set_option(rs.option.filter_smooth_delta, 20)
    tem_depth = temporal.process(spatial_depth)

    hole_filling = rs.hole_filling_filter()
    filled_depth = hole_filling.process(aligened_depth_frame)

    # Colorize depth frame to jet colormap
    depth_color_frame = colorizer.colorize(filled_depth)

    # Convert depth_frame to numpy array to render image in opencv
    depth_color_image = np.asanyarray(depth_color_frame.get_data())
    depth_colormap = cv2.applyColorMap(cv2.convertScaleAbs(depth_color_image, alpha=0.41), cv2.COLORMAP_JET)
    color_image=np.asanyarray(color_frame.get_data())

    w=filled_depth.get_width()
    h=filled_depth.get_height()

    dis=round(filled_depth.get_distance(int(w/2),int(h/2))*100,2)
    print("the dis are",dis,"cm away")

`


Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode

Moved to a different pull request because the comments on the other CL were making github timeout.

This change is breaking the Fuchsia build. Is there any way it can be reverted and phased-in a different way?

Unfortunately the change is breaking. Let me go ahead and create a CL that
fixes the Fuscia build break.
On Tue, Jul 25, 2017 at 10:45 AM, Zachary Anderson<EMAIL_ADDRESS>
wrote:

This change is breaking the Fuchsia build. Is there any way it can be
reverted and phased-in a different way?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/11359#issuecomment-317814197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK4PNknJD7m1049MO6lvW2vWvqFin7Nks5sRimkgaJpZM4OhkPL
.

Build times on windows spiked with this patch, but it's not clear if that's a coincidence or not. Will monitor.


Nanocubes Added

add Nanocubes, metro extracts, Geofabrik

Ok, thanks for mentioning that. I have just updated it.


/messages does not provide a way of saying that you cannot paginate further

We need to define the error code or mechanism to inform the user that they can't back-paginate further via /messages because the server has run out of DAG.

see https://github.com/matrix-org/synapse/issues/1623 and https://github.com/vector-im/riot-web/issues/2566

Do we really need to invent anything here if /messages returns state changes and m.room.create is still the very first event no matter how you purge messages?

it's not really a spec-bug imho: it's something we need to agree on and spec.
@KitsuneRal: that is one solution, but there are others which would make just as much (or more) sense. It's worth remembering that /messages lets you go both ways so we could do with a solution that works in the other direction too.

err, yes - it should be an improvement not a bug. I wonder which issue I was trying to label as a bug....

According to https://github.com/matrix-org/matrix-doc/pull/1763#discussion_r318864900 @turt2live thinks that the absence of a next_batch token should be specced to mean "you cannot paginate further", which feels very sane to me.  Shall we do that (if it's not already?)

/messages doesn't have a next_batch. I think you mean end, in which case +1

Do we really need to invent anything here if /messages returns state changes and m.room.create is (supposed to be) still the very first event no matter how you purge messages?

Yes. The same problem occurs when you specify a to parameter (to fetch missing backlog in a limited /sync response for example), in which case you don't know what the final event is going to be. The only solutions right now are:

Checking whether the amount of results is less than the limit (fragile, will break in 1/Nth of cases)
Continuing to paginate until an empty chunk is produced (seemingly reliable, but requires a pointless extra request)

Continuing to paginate until an empty chunk is produced (seemingly reliable, but requires a pointless extra request)

not entirely reliable, sadly. Synapse will sometimes return empty chunks if there is a section of timeline you're not allowed to see (eg because you weren't in the room).

For the record, it looks like matrix-js-sdk currently decides that it's at the end of the timeline if start == end in the response.

This got fixed by #3353.

To be clear, accepted solution is "you can detected the end of the line by the absence of an end token in the response", right?
I note that this is not the behavior on matrix.org currently, which will always return an end token. That's fine, but it's a bit annoying that someone just reading the spec [e.g. me] is going to end up in an infinite loop when trying to write a client against the matrix.org homeserver.

I note that this is not the behavior on matrix.org currently, which will always return an end token.

please file an issue against https://github.com/matrix-org/synapse


When using offline map from assets or from filesystem cannot find images

I created an offline map following the instructions from the Readme. Add to the app assets, everything like the example.
But then it's trying to find coordinates in the url template that don't exist in the offline directory structure. Thus it shows that cannot find the file in the path. For example, zoom level 4, there are directories 5, 6 and 7. It's trying to find directories 8, 9, 10, for example.
Wasn't it supposed to only use the files that are present?
Or what am I doing wrong? I added the swPanBoundary, nePanBoundary and center points correctly, I believe, accordingly with TileMill.
Please help.
Thanks.

Sorry, TileMill was giving the coords inverteded. :~(
I fixed it and it worked.


Dependancy update

I had not added the dependancies for tests. I tried to avoid adding these, but I think its not worth it as we need the mock objects to work even if the original library makes changes.
cc @stephenwithav

I'll rebase #81 on this PR when it's merged, then rebase #33 on the merged #81.


web: https://uct.ac.za [ University of Cape Town ]

student email using @myuct.ac.za
course website: https://cs.uct.ac.za

@mavhungutrezzy I am sorry for a delay with processing your request.
Pull request merged. Thank you!


NIFI-4794: Updated event writers to avoid creating a lot of byte[] by…

… reusing buffers. Also removed synchronization on EventWriter when rolling over the writer and just moved the writing of the header to happen before making the writer available to any other threads. This reduces thread contention during rollover.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1 LGTM, ran unit tests and numerous flows on a running NiFi instance. I didn't do performance testing but did visually verify improvements in the code, and verified stability on the running instance. Thanks for the improvement! Merging to master


WebApp - Improve UI for mobile

[x]  1. Remove auto-focus in NFT, History on mobile

2. Fix modal height in mobile:

[x] Select Account
[x] Customize network
[x] All select modal

[x] 3. Add enter trigger on screen create master password

4. Data on the search box is being reset when expanding or shrinking the screen size

Haven't had solution for this yet

[X] 5. Improve in case the screen has 1 banner (DApp)

[x] 6. UI bug in search hasn't data

[x] 7. Hide tooltip on mobile

8. UI bug when scrolling on the Homepage screen(Token Detail)

Will be fixed in #2104

Version test: https://59aabbab.subwallet-webapp.pages.dev/

[ ] UI bug

Version test: https://ecf25797.subwallet-webapp.pages.dev/home
Continue troubleshooting in https://github.com/Koniverse/SubWallet-Extension/issues/2141


Move from <p> to <div> for anything that could contain markdown content

Is this a BUG REPORT or FEATURE REQUEST?:
feature
What happened:
Currently <p> is being used in some places, which might lead to issues.
What you expected to happen:
Use <div> instead of <p>.

Might already be done, but could be checked to make sure.


Don't pause spinner when code is just loading slowly

Instead, pause it when launch actually fails
Ref #433

I think @Carreau should comment on this one - the reason the change was made was in order to avoid using too much CPU, which he was concerned about

Updated wording, @betatim

If the spinner is taking up too much CPU, IMO we should remove the spinner or fix it. I think currently it is making mybinder.org look much more unstable than it is, which makes for a very sad panda.

Let's remove the timeout (for now), and try to add a metric for "after how long does a user leave the page if it's not launching".
That would give us some measure of what could be reasonable for an alternative UI or timeout.
We can also stop the spinner when the windows loose focus.
Infinite animation on the web sucks.

stopping the animation when the window looses focus after the timeout seems like a good compromise to me, though I think it we should leave that for another PR...merging!


First attempt at some tests.

These are really 'release tests' rather than unit tests, as they require a lot of data to be loaded in the database first (at the moment, it requires North America). A better test suite would load some minimal static fixture data first.
But this is a nice first step, and we can refine it later.
These first few tests are items we added in v0.6.0 which should be, but currently aren't, being displayed on production. The tests pass against dev, though.
@nvkelso could you review, please?

Reads well, and so good to have these! Give me a day or two to verify it locally.

In the latest commit, I changed the config format a bit, adding a feature so that we can test against the tile proxy server while prod is generating. If you've already generated a config file, you'll need to update it to replace the URL with a dict with a url key and optional use_all_layers key. The latter should be set to true when using the tile proxy, e.g:
proxy:
  url: http://localhost:8080/osm/all/%(z)d/%(x)d/%(y)d.json
  use_all_layers: true

An important step! :+1:

Please add test.log to the .gitignore list.

I ran this against dev and prod and got results within range for both, good!

I think this is fine, but noting it here because it's different than the other pattern:
[  18/22] FAIL: 'test/443-swimming-pools.py'
Traceback (most recent call last):
  File "test.py", line 137, in run_test
    'features_in_tile_layer': features_in_tile_layer
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 240, in run_path
    return _run_module_code(code, init_globals, run_name, path_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 82, in _run_module_code
    mod_name, mod_fname, mod_loader, pkg_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "test/443-swimming-pools.py", line 9, in <module>
    { 'kind': 'swimming_pool' })
  File "test.py", line 128, in assert_has_feature
    % properties
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "test.py", line 112, in features_in_tile_layer
    yield features
  File "test.py", line 121, in assert_has_feature
    raise Exception, "Layer %r empty" % layer
Exception: Tile 'http://vector.mapzen.com/osm/water/16/19273/24652.json': Layer 'water' empty

I had been expecting:
Did not find feature including properties {'kind': 'swimming_pool'}.

Other than that, looks good.

I had been expecting: Did not find feature including properties

Hmm... okay. I thought that having a more specific error message would be better. When debugging, it's helpful for me to know if there were any features at all. Would a better message be "Did not find feature including properties ... (because layer 'blah' was empty)" instead?

LGTM

Would a better message be "Did not find feature including properties ... (because layer 'blah' was empty)" instead?

Yes.


Add new beer functionality

After https://github.com/kehittamo/oluttamo-api/issues/1 is done, maybe we should implement "Add New Beer"-functionality to Oluttamo extension?
There could be something like "This is not the beer I was looking for"-button that opens simple form with necessary inputs:

beerName
breweryName
rateBeerId

https://github.com/kehittamo/oluttamo-browser-extension/commit/fd73702cbdad58fad28ab930519e24e232264a63


issues out the box

Connecting to public(<IP_ADDRESS>:27015) ...
Server using 'friends' lobbies, requiring pw yes, lobby id ffffffffffffffff
Connecting to public(<IP_ADDRESS>:27015) ...
Server using 'friends' lobbies, requiring pw yes, lobby id ffffffffffffffff
Connected to <IP_ADDRESS>:27015
just get that and my server stops after trying to load in
and ssj is broken as well:
3A3[4Timer3] 2- 5Jump: 41 5| PreSpeed: 4260
3A3[4Timer3] 2- 5Jump: 42 5| Speed: 4360 5| Gain: 455.22%
3A3[4Timer3] 2- 5Jump: 43 5| Speed: 4440 5| Gain: 464.90%

This seems odd, i linked my steam on the alliedmods post, if you add me there, i could possibly look at the server to help you diagnose this issue. There are multiple people running latest release without a problem so I need to see it to understand the issue and help you further.

i tried adding you, my steam is sklm

Alright, i have 277 pending requests, so i generally check in the afternoon for comments lol. I’ll add you in a moment.

Did you remove the SSJ by Alatraz? Had the same problem with SSJ.

Seems like it was a client sided issue, he changed his csgo font. After reverting his font it seems to be fixed.


[#6826] Cleanup logger dependency

Codecov Report

Merging #7123 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7123      +/-   ##
==========================================
- Coverage   38.93%   38.92%   -0.01%
==========================================
  Files        3290     3290
  Lines       95791    95791
  Branches    11964    11964
==========================================
- Hits        37294    37291       -3
- Misses      55523    55529       +6
+ Partials     2974     2971       -3

Impacted Files
Coverage Δ

...rp/pinpoint/rpc/control/ControlMessageDecoder.java
64.28% <0.00%> (-14.29%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
60.00% <0.00%> (-6.43%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0.00%> (-2.13%)
:arrow_down:

...java/com/navercorp/pinpoint/rpc/DefaultFuture.java
72.50% <0.00%> (-1.67%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.07% <0.00%> (-0.33%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.28% <0.00%> (+1.05%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0.00%> (+2.43%)
:arrow_up:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
73.33% <0.00%> (+3.33%)
:arrow_up:

...pinpoint/profiler/instrument/AccessorAnalyzer.java
65.71% <0.00%> (+8.57%)
:arrow_up:

...p/pinpoint/rpc/stream/StreamChannelRepository.java
85.00% <0.00%> (+10.00%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6a1a0...9507c4e. Read the comment docs.


apply/removeSet messages

Hi again,
Could we possibly have another command to silence the  [applied|removed] message? I'm using BetterQuesting to dynamically apply/remove sets which has two problems with the current implementation.
(a) It tells the player which ruleset is applied so unless I chose horrible names they're going to get a general idea of what the ruleset does, something I want to avoid in most circumstances
(b) It can get a little spammy when multiple sets are applied/removed in succession.
If possible, it would be nicer if the silence was per set not for the entire mod.
Thank you :)

Just to make sure I understand everything involved (I've been meaning to check out BetterQuesting, but, haven't had the time just yet): when it applies the command, does it actually print out the command it's running, or is this just a matter of the console log being spammed with all the logging for each set?

BetterQuesting has an option to execute the command (ie, /ch applySet name) silently but CH then prints 'name applied' or 'name removed' to the chatbox. Thats the part I want to supress. Outputting a message in the log would be fine.
So currently, switching from iron to gold level drops prints 'dropsIronLevel removed' and 'dropsGoldLevel applied' in the chatbox.

Aha.  Alright.  That makes sense.  That should be a lot easier than what I was imagining I was going to have to do. :)
Thanks.


Kernel updates for 2024-10-04

https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.11.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested on the usual things.


More questions

Added a question about the first female Prime Minister of Europe and added my name to the contributors sections of the README.md file!

@dinaelhanan Please add a category to your question in your PR, thanks!

Ok, it should have add the category "politics" now :100:

Thank you very much @dinaelhanan!


Bug in open api rules processing - AnyConverter

Hello,
Thank you for this repo.
Discovered a bug when trying to add some documentation to route parameters.
In our use case we want to document an enumerated list of possible values for a url path parameter like so:
/<any(\"enum1\", \"enum2\", \"enum3\"):parameter_name>
This works, but the problem is the generated openapi.json also pulls in some other schema info from the request body, which ends up looking very strange in swagger.
The cause of this bug is the schema dictionary variable is reused from the above code. See https://github.com/pgjones/quart-schema/blob/main/src/quart_schema/extension.py#L590
I am attaching a patch file. Tried to submit a PR but couldn't
Note: should also consider setting the type at line 590 like so:
params_schema.update({"type": "string", "enum": list(converter.items)})
Patch file:
fix_bug_-_do_not_reuse_schema_dictionary_from_above_logic_Improve_the_decorator_typing.patch

Thanks fixed in 125e218d7a35a2eb9fc8216de2905f5479939dd3


[2541] Remove redundant MCB functionality

Context
MCB now replicates quite a bit of functionality that can be completed via publish.
Changes proposed in this pull request

Remove grant admin access
Remove functionality from the course editor

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

🔥 🔥 🔥 🔥 🔥 🔥

 Remove functionality from MCB that can be done in the UI now

@davidgisbey - Interesting that coverage has decreased (reason for the build failure). The SimpleCov threshold is 75% and it's only this low because of (apparent) lack of coverage in mcb console. If mcb is deprecated perhaps it could be worth excluding the mcb files in simplecov (and Code Climate)... might be worth a discussion?

@TobyRet good idea. I think some of this really should be tested if we're going to continue to use it. Particularly the access wizard.

After discussing with @dankmitchell we think it's best to remove mcb commands from Simplecov coverage for two reasons.

MCB should be gone soon
It would require a lot of time to add the coverage that would be required to bring the coverage % up.


Negotiated MTU size keeps changing after each new connection

Describe the bug
Whenever I connect to my BLE peripheral from my web app using the capacitor ble plugin the negotiated mtu size keeps changing and gets larger and larger. This does not happen when I connect with google chromes Web Bluetooth sample code online (see Additional Context for link)
To Reproduce
Steps to reproduce the behavior:

npm run server and open web browser / localhost
click connect button on web app
connect to available BLE peripheral (in this case an ESP32 microcontroller running micropython)
peripheral tries to negotiate 128 bytes (for ex)
Print out the negotiated mtu size
first time I print out the mtu it's 31
disconnect and then reconnect, mtu size is now 100
disconnect and then reconnect, mtu size is now something like 123
Keep repeating and mtu size keeps increasing by 23 bytes

Expected behavior

mtu size negotiated should be 128 bytes and not keep increasing on each connection

Plugin version:

@capacitor-community/bluetooth-le: [e.g. 0.4.0]
@capacitor-community/bluetooth-le: "1.8.3"

Desktop (please complete the following information):

OS: Mac OS Monterey 12.2.1
Browser: Chrome
Version: 109.0.5414.119 (Official Build) (x86_64)

Additional context
I've used google Web Bluetooth sample connect to connect to my BLE peripheral and the mtu size is accurate (I negotiate mtu size of 100 for example) and does not change
ex: https://googlechrome.github.io/samples/web-bluetooth/device-disconnect.html

closing this ticket, has been resolve