IndicatorView is not visible only on iPhone 5

Encountered an issue that the IndicatorView is not visible on the iPhone 5.
I created a clean project and here is my code:
var loader: NVActivityIndicatorView?

override func viewDidLoad() {
        super.viewDidLoad()

        loader = NVActivityIndicatorView(frame: CGRect(x: self.view.center.x - 20,
                                                            y: self.view.center.y + 70,
                                                            width: CGFloat(40),
                                                            height: CGFloat(40)),
                                              type: .ballGridPulse ,
                                              color: UIColor.red,
                                              padding: CGFloat(0.0))
        view.addSubview(loader!)
        loader?.startAnimating()

The indicator is visible on any iPhone except iPhone 5 (not sure about 4s)
EDIT: details: when i open the view debugger i DO see the 'box' with the loader. but it's just invisible. not white color. i this it's clear color.. but doing po loader.color returns correct color..

@tungfam: Thanks for reporting 👍. Confirm this issue on iPhone 5. I tried running the demo project on iPhone 5 10.3 simulator and got the same thing you reported here. However some of animations don't have this issue, you can open the demo to see what works and not. In the meantime, I suggest using working ones, I'll be looking into this issue, update later then.

Got it, thanks.
Pointing to 3.5.2 also solves the issue:
pod 'NVActivityIndicatorView’, ‘3.5.2’

@tungfam: 3.6.1 is out with fix for this 🚀. Thanks @shady-gabal for helping figure out the cause.


Use irradiance data for predictions

With #34 we introduced predictions. Once we are successfully capturing irradiance data (probably via v1.4.1) we should also include that data in our predictions.
Currently blocked via #42 #44.

This is no longer blocked!


Album grouping.

Would kindly love to have album grouping as or like Samsung Gallery. Reason being.
1.Organized access to multiple albums.
2.Reduces scrolling and confusion (if there are multiple albums, as in my case.)
Aves is currently the best third-party Gallery app out now imo. Wishing you the best for the future. Much appreciation for building and providing this app for us. Blessings

Welcome to GitHub!
I think your suggestion is a duplicate of this one:

#268

You can upvote it by adding a thumb-up reaction 👍 to the top post. You can also subscribe to the issue to get updates (discussion, progress).


Documentation: how to operate on current file?

The documentation (with its link to your dotfiles) appears to suggest that the file to be linted has to be hardcoded in init.vim as:
 init_options = {
        journalFile = "~/repos/beancount/journal.beancount",
}

Is there no way for the language server to operate on the current buffer, or (in the case of an included file) the master file of the current buffer?

the file linked is the root file to find account declarations, etc. the language server processes the current buffer but uses that file to determine other needed info for completions (for now). I could make this option optional but some completions might not show up


hi, there is somethong wrong on windows 10, but I don't know how to fix it.

I'm working on Win10 and the mysql version:
E:\>mysql --version
mysql  Ver 14.14 Distrib 5.7.13, for Win64 (x86_64)

this is my test code:
extern crate mysql;

// use mysql::{OptsBuilder, Opts};
use mysql::value::from_row;

fn main() {
	let pool = mysql::Pool::new("mysql://root:system@<IP_ADDRESS>:3306/example").unwrap();
	let result = pool.prep_exec("select ? * ?", (20i32, 0.8_f32)).unwrap();
	for row in result {
		let c: Option<f32> = from_row(row.unwrap());
		println!("{:?}", c);
	}
}

and the dependence:
[dependencies]
mysql = "*"

when I  try to complite it, there is something wrong:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: DriverError { Could not connect to address `\\.\pipe\MySQL': 系统找不到指定的文件。 (os error 2) }', src\libcore\result.rs:859
note: Run with `RUST_BACKTRACE=1` for a backtrace.
error: process didn't exit successfully: `target\debug\mysql_read.exe` (exit code: 101)

I try to create a opts on myself:
let mut db = OptsBuilder::new();
db.ip_or_hostname(Some("<IP_ADDRESS>"))
    .db_name(Some("example"))
    .user(Some("root"))
    .pass(Some("system"))
    .tcp_port(3306);

the same error happened, so how can I do it?

I once again read the document, found that the opts perfer_socket this property is the default open, I try to close it, then it can normal interaction with the mysql on Win, so the problem should be solved

Hi!
The problem here is that somehow the driver could not connect to the pipe address (\.\pipe\MySql) reported by a server because there is no pipe with this address (i.e. server doesn't listen on the pipe it reports). I hope this problem is not related to every win10 mysql installations..
Anyway you can check that named-pipe is enabled in mysql configuration (there should be enable-named-pipe option in [mysqld] section of my.ini)

There is no enable-named-pipe option in the file my.ini.
I don't enable the named-pipe on my computer, so it can't find the named-pipe, so I change the perfer_socket to false, then it can interact with tcp/ip.
But thanks for your answer@blackbeam

Change #enable-named-pipe to enable-named-pipe in my.ini works on XAMPP on Win10.


Fix jsonEditor

Coverage remained the same at 100.0% when pulling eea4f6663f3bde865331eccc518f77281579b154 on mmiszy:JSON_EDITOR into ac10128667b70ade6b9adb5fb676595d3dab9ff6 on glennjones:master.


should  increased mating efficiency/mating without nitrogen starvation be related?

increased mating efficiency (FYPO:0001043)
A biological process phenotype in which the observed mating efficiency is higher than normal.
mating without nitrogen starvation (FYPO:0003031)
A cellular process phenotype in which conjugation takes place in cells that are not subject to nitrogen starvation.
"increased mating efficiency" is  sometimes used to curate
mating without nitrogen starvation (FYPO:0003031)
since  obviously the mating efficiency is improved.
I don't  really know if this was the intended use  of "increased mating efficiency" though. It seems quite different from over expressing a gene and seeing  increased mating.

duplicates #3920


portfile.cmake question

Why most portfile calls vcpkg_build_cmake() and vcpkg_install_cmake()?
vcpkg_install_cmake build package too, so we can remove vcpkg_build_cmake()

I think removing vcpkg_build_cmake() from most portfiles should be fine; as you've mentioned it serves no purpose most of the time (and overbuilds sometimes). We additionally are unaffected by a partial installation (say the build fails halfway through installation) because we "stamp" the package as good only after the portfile completes successfully.

(and overbuilds sometimes)

Yeah, it increases build time of about two times

Thanks for bringing this up.


Bump server packages from 0.1014 -> 0.1015

Updates to the latest server packages to fix bug with Webpack 5 and local dev server scenarios.

Closing PR until test issues are addressed


Lost precision

Several data points in the SMHI API specify data type as Decimal number, one decimal but this library uses Int instead which means lost precision.

I don't see anything specific when I check. Maybe you can be a bit more precise on which data points you mean are having lost precision?
As example I see temperature is typed as int but it's actually saved as float but I guess you have some real world issues here?

Home Assistant SMHI Integration only returns whole numbers
rounded_temp = int(round(temperature)) is probably where precision is lost


version 0.3.9 no longer silently ignores unknown block names

Hi,
useref 0.3.9 breaks my gulp build, because unknown block names are no longer silently ignored.
I think it should either be called 1.0.0 or simply issue a warning that no handler for the custom block type was found.

I see. Would having this behavior as an option fix the problem?

Since it was upgraded automatically (it's used by gulp-useref), the warning would have to be switched on by default.
I assume my use of console.log is not appropriate for your project, but this is what wanted: https://github.com/hn3000/useref/commit/65e996e2dc0a09b3358dec57162bd6e6d695e7f5

Ok, should be fixed on 0.3.10.

yup, it's fixed
thanks!


terraform, aws: encrypt cluster wide EFS instance by default (or transition to not using cluster wide instance by default)

From https://github.com/2i2c-org/infrastructure/issues/4542:

We should consider enabling encryption if this is the standard practice.

We currently have two ways of deploying EFS infra via terraform, one for cluster wide setups, and one that accepts one or more setups.
We default to using the cluster-wide setup, but that doesn't default to encrypting things. This makes us not encrypt by default overall.
I propose we either transition away from using a cluster wide setup, or start encrypting it by default.
Definition of done
We encrypt new AWS clusters EFS instances by default one way or another.

If the question is 'encryption yes or no' the answer is clearly 'encryption yes by default'. I'm happy for that to be split out into a separate task that can be scheduled appropriately - there's no current blocker for that.
If the question is 'should we have one EFS per hub?' that should be considered and determined based on experience of completing https://github.com/2i2c-org/infrastructure/issues/4453, and should be based on the outcome there.

Thanks @yuvipanda for following up on this! I've updated the issue to be about encrypting the cluster-wide instance by default for new clusters, and I'm dropping the ball on driving change towards using hub-specific EFS instances by default.
I'm not sure if you prefer to have me add this to the refined column at this point in time or not, but I figure I'll go with action over inaction and do it.


What happens when ownership of a solution-aware cloud flow is shared with a user who isn't Dataverse?

This section heading is missing the word "in"
What happens when ownership of a solution-aware cloud flow is shared with a user who isn't Dataverse?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a50a5424-6bb4-c34c-bb82-991a5dd3e0df
Version Independent ID: ea8ac9ee-e014-ad33-59f5-5d15f8a38ad8
Content: Learn how to share a cloud flow with other users - Power Automate
Content Source: articles/create-team-flows.md
Service: power-automate
Sub-service: cloud-flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

@apomphre Thanks for reporting this issue. We've fixed it.


Removed MXNET_USE_MKLDNN definition when option USE_MKLDNN is disabled

Description
Builds were failing to wrong include.
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)

Changes

[x] Added condition for MXNET_USE_MKLDNN define

LGTM

@zheng-da could you verify?

LGTM :+1:


[Style][Java] fix typo and invalid reference in comments

@tianchen92 build fails with Line is longer than 120 characters

@tianchen92 build fails with Line is longer than 120 characters

Thanks for your reminder, fixed.

Codecov Report

Merging #4832 into master will increase coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4832      +/-   ##
=========================================
+ Coverage   87.44%   89.6%   +2.15%
=========================================
  Files         997     662     -335
  Lines      139804   96427   -43377
  Branches     1418       0    -1418
=========================================
- Hits       122246   86399   -35847
+ Misses      17196   10028    -7168
+ Partials      362       0     -362

Impacted Files
Coverage Δ

cpp/src/arrow/json/converter.cc
90.53% <0%> (-1.78%)
:arrow_down:

cpp/src/arrow/json/chunked-builder.cc
79.91% <0%> (-1.68%)
:arrow_down:

cpp/src/arrow/io/readahead.cc
95.91% <0%> (-1.03%)
:arrow_down:

r/src/recordbatch.cpp

r/R/Table.R

js/src/util/fn.ts

go/arrow/array/bufferbuilder.go

r/src/symbols.cpp

rust/datafusion/src/execution/projection.rs

rust/datafusion/src/execution/filter.rs

... and 329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f767ce...a01222c. Read the comment docs.

+1, LGTM. Thanks


Request to Add Icons for Fusion 360 and Bambulab Slicer

Hello, I'm using Sketchybar and I would like to request icons for Fusion 360 and Bambulab Slicer.
I have prepared SVG icons here:

Those icons will need to be in a stamp-like single color format as the others.
Follow the guide in the README and prepare a PR and I'll gladly merge it.

Oh didn't mean to close it


Payload value?

Hi.
I'm trying to get logstash to post to a specific topic (routing key) and a specific payload.
Topic works fine, no problem.
But the payload starts with "2017-07-06T18:30:44.559Z %{host}......."
I've tried mutate and replace message field with the value, and that's what comes after {host} in the above example. Is there a way to remove the timestamp and host variable and only have a single field in the payload?
I assume I'm doing something wrong, but I can't find an answer with my google-fu. :\

This is probably best a question for https://discuss.elastic.co/

I know that it is a bit old thread but i got there while searching for how to format logstash output in rabbitmq output plugin. To get only message value in payload you have to add format option to the codec as shown in the example below.
output {
 rabbitmq {
  (...)
  codec => plain {
   format => "%{[message]}"
  }
 }
}


update error code

https://github.com/vesoft-inc/nebula-ent-docs/issues/415

@dutor The following error codes need to be interpreted：
E_HISTORY_CONFLICT:
E_PRIVILEGE_ALL_TAG_EDGE_SETTLED:
E_NO_TRANSFORMED:


Update to MkDocs 1.0-style configuration

I merged a pull request to set the existing document up correctly with the new documentation format, but I still need to rewrite the generator.


[Improvement][api] Worker group data returned incorrectly

Which version of DolphinScheduler:
-[dev]

who can fix it?

who can fix it?

i will fix it

i will fix it


Do you want me to add GitHub Actions?

If you want, I can contribute some advanced CI to your repository in a PR. Let me know if you want that.

Hi! Can you clarify what you would consider setting up? We don't have any tests for this component…

I can contribute hassfest and HACS validation, the recognized combo by HACS, and I can add flake8 to your preferences if you want. I can also contribute optional auto-formatting that amends to the last commit.

Neat; that seems cool! Thanks for offering! I think flake8 would be great, but we can probably do without the auto-formatter, at least for now. 🙏

Packaged or independent? I made a combined GH action, but it's totally optional, however it means that it will constantly get better.

Cool! Let's try your combined GH action and see how it goes.


List issues by project

https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/issues.md
Get a list of project issues. This function accepts pagination parameters page and per_page to return the list of project issues.


WinNF: Add version 1.0.0

[x] I have read the Contributing Guide.

/verify

The project looks quite new, it doesn't fit criteria for Extras bucket in terms

Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)

ah i didn't notice that :( my bad.

Closing this for now.
Feel free to can come back at a later time when the Extras bucket requirements will be met (it's more preferable to open package request first).


Remove "embulk selfupdate" to the latest version

At first, embulk selfupdate won't support updating to the latest version.

Thanks!


internal: Reduce the number of direct fields in CompletionContext some more

Doesn't make the code much simpler yet.
bors r+

bore retry

bors retry


Update machinery interface conf

See closed pull request #691
I took my motivation to do as @jbremer suggest =)

Good stuff, thanks!


ListBox cannot override padding

Current Behavior
The docs say that you can provide ListBox and ListBoxItem with custom padding. However, the built-in padding, px-4 py-2 is always included first. Which means the only way to override is to use a !px-2 !py-2 for e.g.
Steps To Reproduce
Create a new ListBox with custom padding:
<ListBox multiple padding="px-2 py-2">
  ...
</ListBox>

You'll notice that the rendered HTML contains both built in and "overridden" values:
e.g.
<label class="listbox-item px-4 py-2 cursor-pointer rounded-token px-2 py-2 hover:variant-soft " ...
Anything else?
No response

The same is true for regionCell when it comes to Table 🙂
Steps To Reproduce
<Table regionCell="px-2" />
"px-2" will be overwritten by the default style.
If we want this to be separated to its' own issue, please do tell.

@coryvirok There's a bit of and overlap for setting the Listbox parent padding and the padding padding down to the child. We do need to give this another review.
@Zantonius not quite the same. With regionCell you can use Tailwind's arbitrary syntax to access child elements:
https://www.skeleton.dev/docs/styling#tailwinds-arbitrary-variants

@coryvirok ok this one ended up being a very simple fix. Essentially we have base classes we apply to each element within the component template, then we append the prop classes immediately following. Looks like we forgot to nix the base padding for this so both the base + prop padding were being added.
I've removed this the base padding in favor of the prop now, so this should now behave as expected.
The fix is merged into our dev branch which will drop as part of our new release on Tuesday of next week. Thanks for bringing this to our attention!


German translation (without explanation of most of the ideologies)

I did not have the time (yet), to explain all the ideologies, but the rest should be ok.

Sadly, due to how github works, this won't be possible to merge, I'd suggest you add your changes to the dev build of version 3 I'll release soon: https://github.com/Ideosorter/ideosorter.github.io/tree/dev


Stream Binder Health Indicator creates Admin client every times

Hi,
we are testing Hoxton.RC1 and we notice that our logs are spawned by AdminClient creation. It is caused by Health indicator changes introduced in #773. The health check creates kafka admin client every time the health check needs to be calculated.
We have several services that calls health endpoint causing to create admin client every few seconds.
The admin client should be cached. Eg. org.springframework.cloud.stream.binder.kafka.KafkaBinderHealthIndicator does it.
Cloud Version: Hoxton.RC1

@Delorien84 This issue is addressed in the latest snapshots. We will release an RC2 next week. Could you confirm if the issues you raised have been addressed? Thanks!


Draggable

please make the Draggable component

This can be considered. when bootstrap is removed as a dependency.


Problem with upload

Hi, upload of files in list suddenly stopped working. When Im trying to upload a file, I got an error:
An error occurred while trying to upload the file fade-pas-min.png
Undefined index: *
Blueprint:
title: Features
'@extends': default

form:
  fields:
    tabs:
      fields:
        features:
          type: tab
          title: Loga

          fields:
            header.id:
              name: id
              type: text
              label: ID Sekce

            header.items:
              name: features
              type: list
              label: Ikony

              fields:
                .icon:
                  type: file
                  label: Logo
                  destination: 'self@'

                .width:
                  type: number
                  label: Šířka
                  size: medium

                .alt:
                  type: text
                  label: Popis obrázku
                  size: medium

Thanks

Duplicate of #3245. You can work it around by saving the page after adding the item but before uploading the image.


Error about missing cargo-sweep in post job cleanup.

I got the following in the post-job cleanup of cargo-cache:
Post job cleanup.
Post job cleanup.
Restoring timestamp from state.
Using timestamp: {"secs_since_epoch":1735565006,"nanos_since_epoch":191004420}.
Sweeping unused build files.
/home/runner/work/_actions/BD103/cargo-sweep/v1/dist/post/index.js:5682
                    throw new Error(`Unable to locate executable file: ${tool}. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.`);
                          ^

Error: Unable to locate executable file: /home/runner/.cargo/bin/cargo-sweep. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.
    at Object.<anonymous> (/home/runner/work/_actions/BD103/cargo-sweep/v1/dist/post/index.js:5682:27)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/BD103/cargo-sweep/v1/dist/post/index.js:5535:58)

Node.js v20.18.0
Warning: Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.

Post job cleanup.
/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/work/extol_image_font/extol_image_font --files-from manifest.txt --use-compress-program zstdmt
Cache Size: ~879 MB (921695332 B)
Cache saved successfully
Cache saved with key: <...>

Manually installing cargo-sweep fixed the problem, but it feels like this action should be making sure that cargo-sweep is installed, not I. I used the latest released version (or, to be specific, Leafwing-Studios/cargo-cache@v2).

Hi, thanks for the bug report! The bug you encountered was fixed in v2.5.0, but it looks like I never updated the v2 tag. Whoops! 🤦
v2 has now been set to v2.5.0, so this shouldn't happen anymore. Could you please confirm that this error is now fixed in your CI?

I can confirm that your update to the tag has fixed my issue. Thank you. 😊


query supported header by [[file#header]]

from supported [[file]], I want [[file#header]] to show all backlinks of this header, is this possible??

Sounds like this will be supported in the successor plugin datacore that is under development.


server side dryRun should be used before apply

One of the problem with kubectl apply is that it can apply some resources before encountering problem with another.
Many of errors can be caught dryRun (https://kubernetes.io/blog/2019/01/14/apiserver-dry-run-and-kubectl-diff/) , which has an added benefit of invoking validating admission controllers.
kapp apply should make a single dryRun apply and if comes clean proceed to the actual apply.

that sounds like a good idea. ill check it out shortly.

We will need to make the value of a flag like this available as a part of :

ResourceImplOpts
So that we can pass the DryRun option to api-machinery for Create(), Update(), Patch() and Delete() API  calls.
AddOrUpdateChangeOpts
So that kapp does not wait for changes to appear and does not attempt to do a Get() API call for the resource.

Take some care with this - I've seen situations where a dry-run will fail, but apply succeeds. Usually due to a prior incomplete or broken apply. It'll be important to support a flag to skip the dry-run.


[ConstraintSystem] NFC: Unify logic used to fix requirement failures

There was duplicate code used in simplifyConformsToConstraint and
repairFailures, both places should be using fixRequirementFailure
instead.

@swift-ci please test


Help: pcweb tutorial describing the project structure and concepts

Thank you for pynecone. I was looking for a webframework to build a landing page and webapp for my startup, and stumbled upon pynecone, looking at the vast capabilities I decided to use it for building the site.
It's a B2B webapp so I want it to be responsive. I found that pcweb is a great start as an example project that makes use of most of the features offered by pynecone.
I've even setup my basic project structure based on pcweb. The thing is I have to keep jumping around the codebase to know how things are sticthed together and made use of.
It would be awesome if there was a tutorial (written or video) explaining the pcweb codebase. It'll also serve as a great resource for other devs looking to build a full-scale webapp with pynecone.

Good idea, we should make a tutorial that goes more in-depth on pcweb

The tutorial was added a while ago.


AMP implementation request

I was wondering if it would be possible to use my AMP website console manger with this tool. Maybe talk to the dev at that website to see if it's even possible. I have ask one of the devs if it would be.

I'm guessing you're talking about: https://cubecoders.com/AMP

Yes it's the one at https://cubecoders.com/AMP. I have it installed already running a minecraft server and have another key for ARK but was wondering if I could use it to mange your tool with it.

One could develop a C# application module to manage arkmanager with AMP.  The server would be arkmanager run @instancename.  Configuration could be passed through environment variables.
Alternatively, one could implement an application module in C# that does most of what arkmanager does.


Pretrained Models

Hi, thank you for your great work.  Would you release the pretrained model of the teacher contrastive network? I am looking forward to it.

Hi, for now, the pre-trained model of the teacher contrastive network would not be released temporarily, but I will consider releasing the pre-trained teacher model if I am available. Since when sorting out the repo a few months ago, I did not include this model. Sorry for the inconvenience.
You can try to train the model from scratch using the script I provided. I had ever tried to train the model and the performance is comparable to that in our paper in terms of PSNR.


added algorithms related to bits and binary numbers

Created a Bits and Binary Operations folder.
Added algorithms for left and right shift, decimal to binary conversion and vice versa

Remove .vscode configuration files

I removed the .vscode config files

@all-contributors please add @bamblebam for code, ideas


No source CODE?

No source CODE?

Source code is available of course.
Electron framework has source code here:
https://github.com/electron/electron/
VoteCoin GUI Wallet has source code here:
https://github.com/Tomas-M/VoteCoin-wallet/tree/master/resources/app


Dockerfile and guidelines for usage

Closing PR for lack of activity
If interested in finding updated code and instructions to operate gcr-lifecycle-manager from a Docker, visit https://github.com/ferpizza/gcr-lifecycle-policy


Link to the map or embed the map on the event creation page

We should also include the general room capacity so people can know what rooms will fit their rooms. For each item in the dropdown you can have multiple lines with information. Use this to include room capacities, equipment in the room, etc.

As part of our roadmap we are working on a new .NET and React site to replace the existing Ruby and Pakyow site. As part of this transition, this enhancement has been removed from our roadmap.


Fixed #27776 -- Merge py3.txt tests requirements files into base.txt

Now django is moving away from python 2 some files within the
test/requirements directory can now be merged, cleaned
and removed. This commit also updates the documentation around
installing requirements for tests.

I'd like to keep things as they are because changing this causes unneeded complexity to support current and older versions of Django in build systems.

No problem

You could move tests/requirements/base.txt  into py3.txt, but please keep it alphabetized.


Show lack of test data with an N/A

Countries are often very slow in reporting test results. As a result the test graph shown at the beginning of the simulation often  shows a value of 0 tests over last week. This is nearly always false. Aurelien has asked us to replace this with an "N/A". In the past we already did this for "recoveries" (no longer present in simulation but available in all versions until this week).

Done


feat: Add Github as source for codepipeline pipeline

Description

Adds Github as a source to source stage in codepipeline in order to clone the repo directly rather than using an s3 asset and codecommit repo, using a codestar connection that was included as a new stack.
Fixes route association issue depicted below when trying to deploy VPC stack from scratch:

LokaFoldVpcStack | 9:01:08 AM | CREATE_FAILED        | AWS::EC2::SubnetRouteTableAssociation | LokaFoldVPC/PrivateSubnet0Subnet1/RouteTableAssociation (LokaFoldVPCPrivateSubnet0Subnet1RouteTableAssociation8BE64629) Resource handler returned message: "the specified association for route table rtb-0cb8cd6df0b73a5cd conflicts with an existing association

Removes all code that created zip asset and code commit repo.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Deployed infrastructure and launching a downloading job using the API successfully according to cloudwatch logs.
[x] Launched SageMaker notebook and verify that repo was cloned successfully.
[x] Destroyed whole infra after testing it using CDK CLI successfully.

Tickets

101
103

Awesome changes, did you add any new env var ?


Ability to have forms with multiple pages, field groups with headers, and conditional fields based on earlier choices

@danblah Headers for groups of fields is already possible. Use the "Paragraph" field that is listed in "Other" when you edit an application form.

https://github.com/OpenTechFund/opentech.fund/issues/1163 and the group fields function are more what this is referring to.


Add course outline link to offering

Scrape the course outline URL for an offering and add it to the model and frontend.

The course outline can be dynamically created for each offering like so.
def parse_offering_node(node: Node, course: Course, term: Term) -> Offering
    crn = node.css_first('li[class="sctn-block-list-item crn"] span').text(False)
    outline = f"https://www.bcit.ca/outlines/{date.today().year}{term}{crn}"

One temporary issue is, until BCIT adds the course outline, you will receive response status code 404 not found.

The course outline can be dynamically created for each offering like so.
def parse_offering_node(node: Node, course: Course, term: Term) -> Offering
    crn = node.css_first('li[class="sctn-block-list-item crn"] span').text(False)
    outline = f"https://www.bcit.ca/outlines/{date.today().year}{term}{crn}"

One temporary issue is, until BCIT adds the course outline, you will receive response status code 404 not found.

@0x53616D75656C That's awesome! Are you interested in opening a PR?


Bastion terraform

This moves all the AWS resource declarations to terraform.
The terraform state has been imported from the existing resources and is clean. It's not the cleanest terraform since it's just a straight import.
The nixops state can probably be destroyed and re-created since we don't care about the old resources anymore and the state is not needed anymore.
Now it's possible to nixos-rebuild switch --flake .#bastion --use-remote-sudo to deploy from the bastion host.
Fixes #171

I'd prefer not to do this until we can do the entire deployment using only terraform. This change will make deployment harder/uglier since you now need two tools to manage the infrastructure. And NixOps cannot reference output values from terraform, so you get ugly things like deployment.targetHost = "bastion.nixos.org".

Ok.
Note that the current NixOps deployment is broken and is blocking the fixes to the channel script in https://github.com/NixOS/nixos-channel-scripts/pull/49
The latest commit deploys with terraform, but I'm hitting another issue now: https://github.com/tweag/terraform-nixos/issues/60

I'd prefer not to do this until we can do the entire deployment using only terraform. This change will make deployment harder/uglier since you now need two tools to manage the infrastructure. And NixOps cannot reference output values from terraform, so you get ugly things like deployment.targetHost = "bastion.nixos.org".

I am not very excited about terraform as a NixOS deploy tool. I've found it a bit slow, and doesn't handle partial network deployments very well. I've had good success using a combination of Terraform + Morph. Perhaps I could demo how that works?

I don't really care, just pick something so I can deploy the channel script updates. With the implementation in this branch, it will also be possible to nixos-rebuild switch from the bastion directly.

I had to fork tweag/terraform-nixos to make it work with our sub-folder flake.

Assuming that this is fine.


[Feature Request]: Enhance "Enhanced JSON Output" to generate Arrays on field level

What would you like to happen?
With #3287 you can now create json arrays on the top level.
It might also be interesting to add a flag on field level to produce Arrays.
This way using the grouping you can create arrays in the elements.
Issue Priority
Priority: 3
Issue Component
Component: Transforms

Hi,
Good idea. I'm happy I could contribute and I might be able to continue doing so. I have issues imagening the expected outcome.

Nr
Name
Option

1
Feature
Column

1
Request
Wise

With #3287, grouped by Nr.:

outputValue
Nr

{  "result": {    "name": [      "Feature",      "Request"    ],    "option": [      "Column",      "Wise"    ]  }}
1

How would it look like with mixed column specific selection, e.g. "name" in array, "option" not?Should the inner Array be replicated?

outputValue
Nr

{  "result": [    {      "name": [        "Feature",        "Request"      ],      "option": "Column"    },    {      "name": [        "Feature",        "Request"      ],      "option": "Wise"    }  ]}
1

Best regards
Dennis

You are right, I think with the option you added you should be able to create all you need.
You might need some extra steps but you should be able to create whatever json you need now, using the json fragment feature and the array feature...
Fyi was thinking about something like this:

client
host
options

client1
host 1
option a

client1
host 1
option b

client1
host 1
option c

client1
host 1
option d

client1
host 2
option a

client1
host 2
option b

client1
host 2
option c

client1
host 2
option d

to convert to
{
 "client1" : [
   {
    "host": "host 1",
    "options" : [
       "option a",
       "option b",
       "option c",
       "option d"
       ]
    },
    {
     "host" : "host2"
     ....
     }
     ]
}


Bulk edit menu does not show on multiple single checkbox selection

Bug description
1st part of the video: If you select multiple findings via the severity of a finding, resulting in multiple checkbox to be set, the bulk edit menu shows up.
2nd part of the video: If you select multiple findings manually, the bulk edit box never shows up.
Steps to reproduce
Steps to reproduce the behavior:

Expected behavior
Selecting multiple checkboxs manually should show the bulk edit box.
Deployment method (select with an X)

[ ] Kubernetes
[x] Docker
[ ] setup.bash / legacy-setup.bash

Environment information
Latest dev

What page are you on and what does the javascript console say? For me this works. What commit are you on?

1c431de0feaa95e79e7afb512b4313160184d829
http://localhost:8080/test/3
nothing much?

ah, the view_test page is the only view that does not use the findings_list.html. let me check


argo logs is truncating the pod logs

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
argo logs <podname> truncating the logs
What you expected to happen:
argo logs <podname> should not truncate the logs
How to reproduce it (as minimally and precisely as possible):
I ran a workflow whose logs are 5067 lines (using kubectl logs). When I use argo logs to fetch the pod logs, I only see 3395 lines.
Anything else we need to know?:
Environment:

Argo version:

% argo version
argo: v2.1.0-beta2
  BuildDate: 2018-03-29T20:49:33Z
  GitCommit: fe23c2f651a61a2d7aa877a86edff9802d7b5b47
  GitTreeState: clean
  GitTag: v2.1.0-beta2
  GoVersion: go1.9.3
  Compiler: gc
  Platform: darwin/amd64

Kubernetes version :

% kubectl version -o yaml
clientVersion:
  buildDate: 2018-02-09T21:51:54Z
  compiler: gc
  gitCommit: d2835416544f298c919e2ead3be3d0864b52323b
  gitTreeState: clean
  gitVersion: v1.9.3
  goVersion: go1.9.4
  major: "1"
  minor: "9"
  platform: darwin/amd64
serverVersion:
  buildDate: 2018-01-31T21:39:04Z
  compiler: gc
  gitCommit: 192ccad06d24af9828cbf42330e1d915cb586406
  gitTreeState: clean
  gitVersion: v1.8.7-gke.1
  goVersion: go1.8.3b4
  major: "1"
  minor: 8+
  platform: linux/amd64

hello @ankushagarwal ,
I'm unable to reproduce the issue. Tried to submit workflow belong and argo logs correctly printed all 5067 lines. I've tried to introduce new line characters, used -f -w flags, but still unable to reproduce it.

I am unable to reproduce this either. I no longer have access to the pod on which this was happening. Feel free to close this bug. I'll reopen if I come across this issue again.

Ok, closing it for now


Basis Compression: allow user to prioritize VRAM over quality

Currently with Basis the "most desirable gpu texture compression format given the device's capabilities" is defined in the following function.
https://github.com/playcanvas/engine/blob/master/src/resources/basis.js#L268
However, there are cases where a developer needs to choose the format that consumes the least VRAM rather than the format with the best quality.
It would be most flexible if the user could choose "per texture",  via the texture inspector basis settings, whether to prioritize VRAM or quality.
Here is the forum thread
https://forum.playcanvas.com/t/basis-compression-ios-android-issue/20317

I believe this is based on what compressed texture file formats are supported by the end platform and can be transcoded from basis.
PVRTC for example, does support 2-bit and 4-bit per block, few other texture formats do support different block sizes too.
It is worth investigating the list of supported by transcoder formats.


Add barrier=toll_booth to pois layer

Connects to https://github.com/mapzen/vector-datasource/issues/479
The first test, http://www.openstreetmap.org/way/25814380 , also has a building tag. It is showing up in the buildings layer, and now it will be showing up in the pois layer too. It also has a landuse_kind=park on it. Is it a problem that it will start showing up in multiple layers?
@nvkelso, @zerebubuth could you review please?

It's normal for us to harvest "icon-able" features from the buildings and put them into the pois layer instead. I expect the feature in the buildings layer to be a polygon of kind:roof, while the feature in the pois layer is a point with kind:tool_booth. (It's getting landuse_kind:park from the landuse intercut.) In this case the POI isn't going to intersect with the road (centroid of the building isn't on the road), but that's a minor problem we'll ignore for now.

LGTM

Added migration in 0522f11 and updated docs in a2611a2.

👍


GraphViz: RuntimeException: Tree has not been constructed

Setup:

Docker version 20.10.17, build 100c701 on WSL2
php:7.4-fpm with all recommended and optional Rubix dependencies installed, except Extras Package
Laravel v8.83.23

Example code from https://docs.rubixml.com/2.0/regressors/regression-tree.html
use Rubix\ML\Regressors\RegressionTree;
use Rubix\ML\Helpers\Graphviz;
use Rubix\ML\Persisters\Filesystem;

$estimator = new RegressionTree(20, 2, 1e-3, 10, null);

$dot = $estimator->exportGraphviz();

Graphviz::dotToImage($dot)->saveTo(new Filesystem('tree.png'));

Thrown RuntimeException stack: https://flareapp.io/share/LPl1A227#F44

What am I missing?

Hey @Anecho, it looks as though you are trying to export the graph of a tree that has not been constructed yet. To construct the tree, call the train() method on the Regression Tree with a training dataset object and then called exportGraphviz().

@Anecho and @RubixML/engineering, I think we should maybe say something like "Tree has not been constructed, must train learner." or something like that. Users might not understand that training is equivalent to constructing a decision tree under the hood. Thoughts?

A more actionable error message was implemented in 2.2


Adjustments and taxes

Hello,
What will happen with the adjustments and taxes on line items when the price of variant is changed? I think adjustments and taxes also needs to be recalculated. Am I wrong?

I didn't test it with adjustments and taxes.
This extension changes price of line items and then calls "update!" method on order. I don't really know if adjustments and taxes are recalculated or not.
It would be great if you test its behavior and tell me if it should recalculate anything.

I will try to use your gem and test it for few days. I will update you with results.
In this gem you made to recalculate prices of line items when variant price changes. It should update tax value and promo value of line item being updated. I think that this will be ok.
There is another thing that should be considered:
Similar like changing prices, the shop could change promotion. For example, I put product in cart that had 50 percent discount. I dont go to checkout for few days and promotion percent changes to 30 percent. I think that price of line item should be recalculated then, similar like you made it for price changes.


Renewable percentage calculation is broken on BETA

For a generic NL 2050 scenario it gives a renewable percentage of 230%:

And the chart seems fishy as well:

This is due to a change I made in ETEngine yesterday. I'll revert it and try to come up with an alternative.

This was indeed due to the "fix" for incorrect shares on the fertilizer CCUS input. I reverted that commit and came up with an alternative which should not have any such side-effects. 😬


BUG/GRID-314

@rdepena @joneit

Looks simple enough. Don't know what it's about. Trusting you on this one.


Literature index has nonsensical dates for older publications

When I look at the literature table there are ~636k publications which have publication dates in the future.
See bad publication count:
SELECT count(pmid)
FROM ot.literature
WHERE YEAR(date) != year

Query id: 0cb00f14-bf93-45df-8cde-1f5582d895b4

┌─count(pmid)─┐
│      636008 │

Note, there are 13.4 million records in the literature table.
When we select the records whose year in the year column doesn't correspond to the year in the date column we see:

SELECT
    pmid,
    date,
    year,
    month,
    day
FROM ot.literature
WHERE YEAR(date) != year
LIMIT 15

Query id: 7de87be5-30b6-42c1-8110-4b575908003d

┌─────pmid─┬───────date─┬─year─┬─month─┬─day─┐
│ 20985261 │ 2125-06-07 │ 1946 │     1 │   1 │
│ 12988629 │ 2131-04-07 │ 1951 │    11 │   1 │
│  6016195 │ 2146-06-07 │ 1967 │     1 │   1 │
│ 13010623 │ 2131-06-07 │ 1952 │     1 │   1 │
│ 13163690 │ 2133-07-08 │ 1954 │     2 │   1 │
│  6003639 │ 2145-06-07 │ 1966 │     1 │   1 │
│ 18153560 │ 2128-12-05 │ 1949 │     7 │   1 │
│ 14454364 │ 2141-08-05 │ 1962 │     3 │   1 │
│  5598625 │ 2147-05-07 │ 1967 │    12 │   1 │
│ 13067135 │ 2132-08-05 │ 1953 │     3 │   1 │
│ 21433993 │ 2121-03-07 │ 1941 │    10 │   1 │
│  5757548 │ 2147-11-06 │ 1968 │     6 │   1 │
│ 13072249 │ 2132-07-08 │ 1953 │     2 │   1 │
│ 24545753 │ 2140-06-07 │ 1961 │     1 │   1 │
│ 21002167 │ 2126-03-07 │ 1946 │    10 │   1 │
└──────────┴────────────┴──────┴───────┴─────┘

All of the dates with incorrect values are for publications published between 1781 and 1969:
SELECT
    min(year),
    max(year)
FROM ot.literature
WHERE YEAR(date) != year
LIMIT 15

Query id: 4e1644ea-4cca-45e4-b39a-65efa18229bb

┌─min(year)─┬─max(year)─┐
│      1781 │      1969 │
└───────────┴───────────┘

This problem potentially blocks opentargets/platform#2578.

@saha-shyamasree will check whether date column is coming from EPMC or if it is an artifact of the literature ETL.

@ireneisdoomed : I didn't try to debug the previous code as with the new XML format we have less noise around pub_date for the abstracts and I think this issue should resolve. We will still have future dates, but that will be due to the original data and not due to a bug.

This is likely a problem in POS used to prepare Clickhouse.
When I look at the literature table DESCRIBE TABLE  ot.literature I see:

┌─name──────┬─type─────────────┬─default_type─┬─default_expression─┬─comment─┬─codec_expression─┬─ttl_expression─┐
│ pmid      │ UInt64           │              │                    │         │                  │                │
│ pmcid     │ Nullable(String) │              │                    │         │                  │                │
│ date      │ Date             │              │                    │         │                  │                │
│ year      │ UInt16           │              │                    │         │                  │                │
│ month     │ UInt8            │              │                    │         │                  │                │
│ day       │ UInt8            │              │                    │         │                  │                │
│ sentences │ Nullable(String) │              │                    │         │                  │                │
└───────────┴──────────────────┴──────────────┴────────────────────┴─────────┴──────────────────┴────────────────┘

date is of type Date. Consulting the Clickhouse documentation for date, we see that "Supported range of values: [1970-01-01, 2149-06-06].". Since all the publications whihc exhibit this behaviour are before the beginning of the Unix Epoch the problem lies in the insertion of the data into Clickhouse.
Unfortunately the best we can do is to use the Date32 data type (docs) but even that stores dates as 'the number of days since 1925-01-01'. We would lose 5666 records (they'd be there, but querying behaviour would not be what we want) out of 13.4m. When these records are accessed via the API through `literatureOccurences.rows.publicationDate they would have incorrect dates (as they currently do).


Rent retrieval

The reducing resize calls weren't executed in inscriptions_test - I edited the condition and changed so this runs.

Reducing resize now refunds rent down to rent exemption, making claim_excess_rent redundant for that purpose

Added assertions to tests that claimed size equals data length, and that inscriptions balance stays at rent exempt minimum after a resize op (that the refund works).

slot warping removed

P.S. Verify that the tests work with warps removed.
I added a warp function to skip forward n slots from the root slot instead of tracking the slots in the loop, and accidentally did runs without warping at all (did nothing when warp_to > 0` instead of the inverse) , so I removed them. I can add them back, but removing them didn't change anything on my end.


✨Help Query - Add a see all questions button

Cc: @adamcogan @ravidhaduk

Hi @jimmidier
Pain
When I am using SophieBot I want to be able to see all queries I can run from within SophieBot
Suggested Solution
When I say "help" and SophieBot gives me a welcome message, it should have an option to see all questions.
Tasks

[x] Implement "See all questions"

More Information

N/A
Screenshots

Figure: Add "See all questions" here
Thanks!

Done by adding a button and a collapsible card.

Figure: "See all commands" button on the greeting card


Fix tag becomes disabled when renaming

Details

Renaming a tag will switch it to disabled because when trying to merge with the old tag state, we get the old tag incorrectly, so the old state is empty.
Fixed Issues

$ https://github.com/Expensify/App/issues/38666
PROPOSAL: https://github.com/Expensify/App/issues/38666#issuecomment-2009456290
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite: have a collect workspace, enabled the tag feature, and have a tag that is enabled

Open the collect workspace page
Open the tag page
Press the enabled tag to open the edit tag page
Press the tag name to open the edit name page
Rename it to anything and save
Verify the tag is renamed and the state is still enabled

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/3ce3e84f-672a-4aa9-b7ef-4a6c15e89892

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/733882bf-0030-4e27-9a7b-23a5d7582f8d

iOS: Native

https://github.com/Expensify/App/assets/50919443/3b67dc14-47b0-428f-822f-fe9396a6b4eb

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/e8056986-d54f-4b9d-943c-77cd37b51b5b

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/e1071d42-659e-4654-800a-4b5cfaeec6b5

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/3821e188-3fa4-440f-83e8-815f8ab3c749

@bernhardoj Please merge main to fix TS errors

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Done

Merging since @mountiny is ooo today!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Incorrect image orientation when uploading from an iPhone

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
Hi,
when uploading images from Safari on an iPhone that were taken in portrait mode, they will appear in Media Manager rotated 90-degree CW. Tina assumes every uploaded photo is horizontal (0 degrees), and does not auto-rotate images according to their EXIF data.
Reproduction
https://github.com/tinacms/tinacms
Steps to reproduce
A simple way to reproduce it is using an iPhone.

Take a photo in portrait orientation (vertical)
Go to Safari and open Tina Media Manager and upload it
It will load rotated 90 degrees CW

System Info
System:
    iOS: 16.4
  Browsers:
    Safari: 16.4
  npmPackages:
    @tinacms/cli: ^1.5.3 => 1.5.3
    tinacms: ^1.4.3 => 1.4.3

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

This has not been fixed. The problem is still there


Submission 20210417-lce-ca

I've fix my team name in metadata the same as last submission.
And whether the foo in yyyymmdd-foo format should keep the same among submissions?


Yuanzhou/for charles local

Following merge PR #254 #259 but for TEST and PROD release later.
Will need to set up spatial-api on PROD

@ChuckKollar I'll merge this PR and get ingest-api redeployed on TEST just to make sure nothing is breaking, before we release to PROD.
@shirey I also created this card https://github.com/hubmapconsortium/spatial-api/issues/22 for running spatial-api on TEST environment later.


actvation: add atxs to tortoise if they are stored

this codepath fails to call OnAtx because node can't broadcast malfeasence proofs for some reason

bors merge


Add threads survey

https://doc.scheme.org/surveys/threads/

Guile uses pthreads:
$ ldd /usr/local/bin/guile|grep thread
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f6c4c2b8000)

And implements SRFI-18, plus some extra procedures:
https://www.gnu.org/software/guile/manual/guile.html#Scheduling

Bigloo supports SRFI-18
https://www-sop.inria.fr/mimosa/fp/Bigloo/manual.html
and uses pthreads .
It also implements fair cooperative threads:
https://www-sop.inria.fr/mimosa/fp/Bigloo/manual-chapter16.html

Co-operative multitasking is used in coroutines. Schemes with virtual threads usually implement some form of preemptive multitasking.

Gauche uses Windows threads on MinGW version as well.
What qualifies "Re-entrant interpreter"?

Thanks a lot for the feedback!
Added Guile and Bigloo.

Co-operative multitasking is used in coroutines. Schemes with virtual threads usually implement some form of preemptive multitasking.

Confusing wording on my part: the OS threads cooperate to preempt the virtual threads.
However, at least Bigloo's Fair Threads require co-operation to be implemented by user code, so it's doubly cooperative.

What qualifies "Re-entrant interpreter"?

Also confusing wording. "Multiple interpreters per OS process" would be clearer.
Basically, the whole interpreter state is contained in a C struct, allowing the C programmer to create a separate interpreter for each C thread if he so chooses. So the interpreter doesn't need any provisions for multi-threading, but also doesn't get in the way of the C programmer's multi-threading. An interpreter that keeps state in global variables is not re-entrant in this way. TinyScheme and s7 ought to be re-entrant, and Guile is probably close enough. Can one process host multiple independent embedded Gauche's?

Hey, nice initiative!
Maybe I'm misunderstanding something, but what is a "virtual machine" thread? In the case of implementations that don't have a "virtual machine" (a la  JVM and BEAM), is that the "main thread" of the program?
The table seems to me to suggest that CHICKEN supports OS threads with the SRFI-18 API, but that's not the case (at least not OOB). The threads provided by the SRFI-18 egg are green threads (please forgive and correct me if this is not the correct/exact terminology). I believe there's an egg that makes it easier to use pthreads, however.
So, shouldn't CHICKEN have "No" in "OS threads"?
I'm not sure about the "Virtual threads" part...

Basically, the whole interpreter state is contained in a C struct, allowing the C programmer to create a separate interpreter for each C thread if he so chooses. So the interpreter doesn't need any provisions for multi-threading, but also doesn't get in the way of the C programmer's multi-threading. An interpreter that keeps state in global variables is not re-entrant in this way. TinyScheme and s7 ought to be re-entrant, and Guile is probably close enough. Can one process host multiple independent embedded Gauche's?

Ah, I see.  Then Gauche is "no", for some global environments are shared process-wide.


Add personal profile on website

Hey @yjcheong : This issue for adding your personal profile to the group website (we use issues to help us keep track of things). It also serves as a practice run for the GitHub fork--branch--pull request workflow (see here for reference).
Also make sure to master writing markdown as it will be handy here and other places, including on Slack.
For adding your profile, follow instructions here.

Closing this as it is addressed in #54 .


refactor the _compile function

The goal here is to produce a skylark function we can call to compile source or source jars. The first step is to stop getting all the arguments implicitly from the ctx which implies that they were set up by a rule.
Instead, we want to have a function we could call inside any other rule, which may not have the right attrs or files.
This does not get all the way there, maybe halfway, but I'd rather send the PR.

@ittaiz @ianoc can you take a look?


Allow the images input to be empty, which outputs just the raw tags

Addresses #212

@crazy-max Can I get eyes on this before I resolve conflicts?

Intended usage is for build tools which only take the tags as input, not the full image url. For example, this is working today:
    - name: Docker Metadata
      id: docker-metadata
      uses: jasondamour/metadata-action@4a2a7878d3f53d548dc904024c8873d1fdb152be
      with:
        sep-tags: ','
        sep-labels: ','
        tags: ${{ env.DOCKER_TAGS_CONFIG }}
    - name: Maven Build
      run: >
        mvn jib:build
        -Djib.to.tags=${{ steps.platfom-svc-docker-metadata.outputs.tags }}
        -Djib.container.labels=${{ steps.platfom-svc-docker-metadata.outputs.labels }}

jasondamour:empty-images

// docker-bake.hcl
target "docker-metadata-action" {}
target "build" {
inherits = ["docker-metadata-action"]
context = "./"
dockerfile = "Dockerfile"
platforms = [
"linux/amd64",
"linux/arm/v6",
"linux/arm/v7",
"linux/arm64",
"linux/386"
]
}

@tatality173 ??? What are you trying to say?

@crazy-max thoughts?

any updates on this ?

Updated from master. @crazy-max I don't really understand the testing framework, can you give some pointers

Updated from master.

Can you do a proper rebase instead of merge commit please?

I don't really understand the testing framework, can you give some pointers

Would need extra tests https://github.com/docker/metadata-action/blob/master/tests/meta.test.ts to test the case when no image is set. One in this suite https://github.com/docker/metadata-action/blob/879dcbb708d40f8b8679d4f7941b938a086e23a7/tests/meta.test.ts#L125 would be fine.

any news on this ? @crazy-max @jasondamour


More examples (compute, 2D charts)

I would like to get to know your library. But I need more examples, much more.

hardware accelerated 2D charts (is that possible)
what to do to build a fully working 3D control like HelixViewPort3D
compute stuff, which algorithms can be accelerated using the GPU
what about shader compiler

Those are all very specific requests.

I don't even know where to begin with HW accelerated 2D charts.
We don't support WPF, so that's a no-go.
Will definitely consider adding some compute examples once we have OpenCL in!
Shader compilers are included in the graphics APIs.

Out of curiousity, how familiar are you with OpenGL?


[DOC] Add note about leftover resources in Rollback

Description
Check each of the following when appropriate to help reviewers verify work is complete.
Modifying an existing version

[ ] I modified operator permissions in the OLM CSV and operator.yml
[ ] I modified the operator deployment in the OLM CSV and operator.yml
[ ] I modified operand permissions in the OLM CSV and ansible role
[ ] I modified CRDS in the OLM CSV and ansible role

Adding a new release version

[ ] I created a new z release directory in deploy/olm-catalog/crane-operator
[ ] I updated channels in the crane-operator.package.yaml
[ ] I created a new release directory in deploy/non-olm
[ ] I created or updated the major.minor link in deploy/non-olm
[ ] I updated the spec.skips parameter in the CSV

Merging this as a result of 1 acceptance ACK and the changes only exist in docs.


memory consumption

Hi huber,
Thanks for reply！I have viewed your updating codes. Actually I have solved my problems by rewriting codes in many places, please forgive my behaviors. Besides, I also encountered new problems: I use helen database with 2000 labeled pictures on iBug website, and scale 15 times and rotate 5 times , totally about 30000 training images. I train it on 64G rams server. Unfortunately it consumes all rams, that is , it needs very large memory in training step. Can you optimize this problem? please forgive me my pool english, happy everyday!

Hi Xiao-Hu,
Thanks for getting back to me and reporting this issue!
I was able to reproduce your problem. I will have a look and update this issue.
Happy day :-)

I have remove multi-thread and that works ok,no memory problems.So I think your code may has some problems in ThreadPool.h,you have better check it,happy day

Thank you very much for the information, that's very useful to know.
It's good to have multi-threading in the feature extracion, as that part can be quite slow. I'll try to find a solution!

Hi Patrik,
I also receive insufficient memory exceptions from OpenCV when training a model with just the first 100 images (and corresponding annotations) of the lfpw dataset. I am using the landmark_detection sample application. I have 16GB of RAM and 10 GB are consumed by the application causing my system to run out of memory.
Any thoughts?
Just to clarify, the mean shape file format should be all x coordinates followed by all y coordinates and should be comma-delimited.
Thanks,
Steven

Hi Patrik,
Have you resolved the insufficient memory exception problems?

@scadavid Sorry, I kind of overlooked your post!
The number of images is not relevant to the memory consumption I think - it's mostly the number of landmarks used. As the example uses 68 landmarks, you'll naturally run out of memory - I definitely need to change the sample app.
If you're interested in training a model, have a look at the RCR in #3, and then use rcr-train.cpp as a starting point.
If you just want to run the pretrained model, #3 should explain it all.
And yes, you're correct regarding the format of the mean shape.
@shangguanxiaohu: Same for you: Not yet, but we should be fine training a model with 20 to 40 landmarks. Leave me a note here and I'll upload the guide.

Hi Patrik,
Thank you for your efforts on this!
Yes, I would like to train my own model asap. When you can, please send me the required configs and a more detailed explanation. I will take a look at RCR in #3 as you indicate.
Thanks again.

On Jun 3, 2015, at 2:24 PM, Patrik Huber<EMAIL_ADDRESS>wrote:
@scadavid Sorry, I kind of overlooked your post!
The number of images is not relevant to the memory consumption I think - it's mostly the number of landmarks used. As the example uses 68 landmarks, you'll naturally run out of memory - I definitely need to change the sample app.
If you're interested in training a model, have a look at the RCR in #3, and then use rcr-train.cpp as a starting point.
If you just want to run the pretrained model, #3 should explain it all.
And yes, you're correct regarding the format of the mean shape.
@shangguanxiaohu: Same for you: Not yet, but we should be fine training a model with 20 to 40 landmarks. Leave me a note here and I'll upload the guide.
—
Reply to this email directly or view it on GitHub.

Steven,
You're welcome, I'm glad to see your interest in my work. I've just added the configs to the devel branch and I've set up a wiki page here explaining the process. I'm a bit busy until the 15th, but then I'll have time to look at the two larger issues mentioned in the wiki.
Let me know how it goes. If you have questions or any issues with it, do not hesitate to open a new issue, let's keep this one for the memory issue.

I figured out the memory issue today. It's actually dependent on the number of images and perturbations. Even though we only copy around pointers, and not data, it turns out that 7500 pointers copied to 7500 tasks, each pointer being 96 bytes, occupies over 5GB. I'll push a fix in the next few days.

@patrikhuber  thanks so much， hope it will not crash again

I just fixed it in the devel branch. I'm going to close this issue, if there's still problems with memory usage, we can always reopen it.

I have viewed your code, and found that there was no change in threadpool.h  , so I guess you may change your code in features' extraction stage, isn't it?

Yep you're right. It wasn't a problem with the threadpool. std::async had the same behaviour - after all, the state variables (in this case the images, or the pointers to them) of the feature extraction object have to be copied. I changed the feature extraction class to only hold a reference to the images now. (there might be other, better solutions, but I'm happy with this for now)

haha,I know it! thanks for your updation.by the way, I wanna to note that "vector &images " is not a good choose for reading data or saving momery(because there may be lots of trainning data), you can use "vector images_path_list" , and images_path_list is the path of trainning data.


Cannot use import statement outside a module import { KeycloakModule } from './module'

im having SyntaxError: Cannot use import statement outside a module import { KeycloakModule } from './module';  even after adding "type": "module" in my package.json
using the "nestjs-keycloak-admin": "^2.0.0" version
here is my tsconfig
{
  "compilerOptions": {
    "module": "node16",
    "declaration": true,
    "removeComments": true,
    "noEmitOnError": true,
    "moduleDetection": "force",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": true,
    "target": "ES2020",
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "incremental": true,
    "resolveJsonModule": false,
    "moduleResolution": "node16",
    "skipLibCheck": true,
    "strict": true,
    "strictNullChecks": true,
    "strictPropertyInitialization": false,
    "noImplicitAny": true,
    "strictBindCallApply": false,
    "forceConsistentCasingInFileNames": false,
    "noFallthroughCasesInSwitch": false,
    "useUnknownInCatchVariables": true,
    "esModuleInterop": true,
    "allowJs": true,
    "paths": {
      "@application/*":["./src/application/*"],
      "@helpers/*":["./src/helpers/*"],
      "@infra/*":["./src/infra/*"],
      "@test/*":["./test/*"]
    },
  },
}

Here's the guide to converting a typescript project to output ESM. You're missing couple of steps.
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#how-can-i-make-my-typescript-project-output-esm

We are using nestjs project on our side and it's not easy to convert to esm.
Ended up making a fork for commonjs support.

Here's the guide to converting a typescript project to output ESM. You're missing couple of steps.

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#how-can-i-make-my-typescript-project-output-esm
is there a step by step instructions for updating a NestJS project? The above documentation is extremely cumbersome to understand what is required and what doesn't for a nestjs project. Thanks in advance.!


Bump github.com/google/go-jsonnet to v0.17.0

... to allow std.objectValues().

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @Al2Klimov


Configure federation

Summary of changes

Moved seeder config to backend/services.yml because it is dependant on API service and not necessarily a "common" service
Moved proxy service to its own config file as not all services need it for local dev (eg, federation does not always need it. Same with backend. There are times we will want it, but we don't always need it running)
Added a docker-compose file for running dependency services for federation service

Reason for tagging of so many people for approvals
Frontend team

frontend/services.yml was touched to reference the new proxy config file

Backend team

backend/services.yml was touched to reference seeder (see above)

Federation team

Well.. I mean, the point of this PR is for the federation team so... 😄

Core Developers

Sorry (not sorry), you get pinged on all PRs for this repo 😜

Hmm... it says I can merge now with just the single approval. I wonder if we should change it to block so that all code owners have a say?

Hmm... it says I can merge now with just the single approval. I wonder if we should change it to block so that all code owners have a say?

From a quick search there doesn't appear to be an easy way to require all codeowner groups to approve a PR. At least not in GitHub settings. If we really want it we may have to create a GitHub action that verifies it for us. Not sure if it's worth it.

Hmm... it says I can merge now with just the single approval. I wonder if we should change it to block so that all code owners have a say?

From a quick search there doesn't appear to be an easy way to require all codeowner groups to approve a PR. At least not in GitHub settings. If we really want it we may have to create a GitHub action that verifies it for us. Not sure if it's worth it.

Looks like you can only have just "CodeOwners..." Should be fine enough.
I have these options for example on a infra repo

@kgilles

Looks like you can only have just "CodeOwners..." Should be fine enough. I have these options for example on a infra repo !

@Jelloeater From what I can tell that only requires approval from one code owner, rather than an approval from all code owners affected by a PR. Like with this one which had three different code owner groups. But I haven't tested that setting extensively.

I mean, might be overkill? I don't even have that for work heh heh
On Fri, Mar 22, 2024 at 4:10 PM kgilles @.***> wrote:

Looks like you can only have just "CodeOwners..." Should be fine enough. I
have these options for example on a infra repo !
@Jelloeater https://github.com/Jelloeater From what I can tell that
only requires approval from one code owner, rather than an approval from
all code owners affected by a PR. Like with this one which had three
different code owner groups. But I haven't tested that setting extensively.
—
Reply to this email directly, view it on GitHub
https://github.com/sublinks/sublinks-docker/pull/2#issuecomment-2015829654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB37QYKDVI4XIAJOUGTOKQTYZSF3PAVCNFSM6AAAAABEZXVGTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHAZDSNRVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Jesse S
@.***

I mean, might be overkill? I don't even have that for work heh heh

Agreed that it might be overkill. Just something to consider on a repo like this that can affect multiple projects. It's possible one team might think a change is benign but another team has insights that the change would actually cause problems with their service.
I'm going to merge this for now and we can look into it more in the future (besides, I have all the approvals I needed since you 2 belong to multiple groups covering all required "code owner" approvals)


Can change an option value in a dynamic parallel coordinate plot after rendering for the first time, but not for the next time

Version
4.9.0
Reproduction link
https://jsfiddle.net/ramgorur/zswuac4b/latest
Steps to reproduce
Just follow the JSFiddle link and run the code. No setup required.
What is expected?
Once an option for a dynamic parallel coordinate plot is set and the plot is rendered, I should be able to change option parameters and the changes should be reflected on the plot on the fly.
What is actually happening?
I'm trying to make a dynamic parallel coordinate plot, where a user should be able to choose if the lines will be straight or smooth. In my case, I have a plot and a toggle button.

The idea is every time when a user clicks the button, the lines of the parallel plot should become smooth from straight, and it should toggle every time when a user clicks it.

The problem is the option values changes only for the first time only, but not on the next click. What I mean, if I make it smooth from straight, next click doesn't turn it back to straight from smooth (or vice-versa). The change in the option is done this way:
function toggleSmooth(){
  console.log("Toggling smooth");
  // get the current option
  option = myChart.getOption();
  console.log("Previous myChart.option.series[0].smooth = " + option.series[0].smooth);

  // change and set it
  option.series[0].smooth = !option.series[0].smooth;
  myChart.setOption(option);

  // check it again
  option = myChart.getOption();
  console.log("Current myChart.option.series[0].smooth = " + option.series[0].smooth);
}

On the console.log, I'm seeing the value option.series[0].smooth is changing but the change is not being reflected on the plot.

Not sure if it's a bug or I'm not doing it in a correct way.

It seems to be a bug.
Before it fixed, perhaps we can only work around with chart.setOption(option, { notMerge: true }).

It seems to be a bug.
Before it fixed, perhaps we can only work around with chart.setOption(option, { notMerge: true }).

Thanks for the follow-up. But still no luck. Appreciate your help.


Numpy large array map works on py3 and breaks down in Codon

Was planning to parallelize a map, but before I could even // that simple code, which runs fine in python3, just made my computer go crazy with Codon, I'm probably missing something:
import time

def fn(x):
    return x + x*x + x*x*x

def calc(x):
    return fn(x)

@python
def create_data():
    import numpy as np
    x = np.random.randn(10000, 10000).astype(dtype='float32')
    return x

x = create_data()

n = 5  # number of times to run the function

times = []
for i in range(n):
    start_time = time.monotonic()
    result = calc(x)
    end_time = time.monotonic()
    times.append(end_time - start_time)

avg_time = sum(times) / n
# std = np.std(times)

print(f"Average time: {avg_time:.4f} seconds")
# print(f"Standard deviation: {std:.4f} seconds")

High memory usage using Numpy object in Codon.
MRE of Numpy object in Codon:
@python
def create_data():
    import numpy as np

    x = np.random.randn(10000, 10000).astype(dtype='float32')

    return x

x = create_data()

result = x + x*x + x*x*x

Timing:
user@ubuntu:~$ /usr/bin/time -v codon run i330.py

Command being timed: "codon run i330.py"
User time (seconds): 8.07
System time (seconds): 4.20
Percent of CPU this job got: 74%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:16.39
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 2137948
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 14554
Minor (reclaiming a frame) page faults: 254646
Voluntary context switches: 15593
Involuntary context switches: 1736
Swaps: 0
File system inputs: 306432
File system outputs: 0
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 0

MRE of Numpy object in Python:
@python
def create_data():
    import numpy as np

    x = np.random.randn(10000, 10000).astype(dtype='float32')
    result = x + x*x + x*x*x

    return result

result = create_data()

Timing:
user@ubuntu:~$ /usr/bin/time -v codon run i330.py

Command being timed: "codon run i330.py"
User time (seconds): 7.59
System time (seconds): 0.88
Percent of CPU this job got: 110%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.64
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 1382748
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 3
Minor (reclaiming a frame) page faults: 36854
Voluntary context switches: 100
Involuntary context switches: 95
Swaps: 0
File system inputs: 0
File system outputs: 0
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 0

Ok, so does that mean I can't use a function to compute result?

I think it means you probably don't want to mix numpy and codon too much - you don't really need numpy for speed as codon likely compiles to a similar speed.   Codon has a random library (source: https://github.com/exaloop/codon/blob/develop/stdlib/random.codon)

This would roughly be the numpy-free equivalent (not optimised):
import time
import random   ## changed

def fn(xs):
    return [x + x*x + x*x*x for x in xs]   ## changed

def calc(x):
    return fn(x)

"""
@python
def create_data():
    import numpy as np
    x = np.random.randn(10000, 10000).astype(dtype='float32')
    return x

x = create_data()
"""

x = [random.normalvariate(0,1) for _ in range(10000*10000)]   ## replaces create_data()

n = 5  # number of times to run the function

times = []
for i in range(n):
    start_time = time.monotonic()
    result = calc(x)
    end_time = time.monotonic()
    times.append(end_time - start_time)

avg_time = sum(times) / n
# std = np.std(times)

print(f"Average time: {avg_time:.10f} seconds")
# print(f"Standard deviation: {std:.4f} seconds")

As for numpy, Codon claims to work seamlessly with numpy when actually it does not, which is a bit of a disappointment.

@ianxek Could you kindly provide more specificity? Which code did you attempt? I am unable to reproduce any segfaults.

That code fails: (if I put n = 5 it works)
import time
import random   ## changed

def fn(xs):
    return [x + x*x + x*x*x for x in xs]   ## changed

def calc(x):
    return fn(x)

"""
@python
def create_data():
    import numpy as np
    x = np.random.randn(10000, 10000).astype(dtype='float32')
    return x

x = create_data()
"""

x = [random.normalvariate(0,1) for _ in range(10000*10000)]   ## replaces create_data()

n = 10  # number of times to run the function

times = []
for i in range(n):
    start_time = time.monotonic()
    result = calc(x)
    end_time = time.monotonic()
    times.append(end_time - start_time)

avg_time = sum(times) / n
# std = np.std(times)

print(f"Average time: {avg_time:.10f} seconds")
# print(f"Standard deviation: {std:.4f} seconds")

$ codon build -release test_np_codon_suggested.py
$ ./test_np_codon_suggested
Segmentation fault (core dumped)

@ianxek Good catch. Thank you for bringing this to our attention.
@arshajii The for loop is causing high memory usage. Even when the result variable is deleted after each iteration, memory is not freed. When the stop argument of the range is greater than or equal to 10, the program terminates with the following error message: 'Command terminated by signal 11'.
import random

a = [random.normalvariate(0, 1) for _ in range(10000 * 10000)]

for i in range(10):  # fails if range's stop argument is >= 10
    result = [i for i in a]

    del result

Build:
codon build -release --cost-kind=latency i330.py
Run:
/usr/bin/time -v ./i330

Command terminated by signal 11
Command being timed: "./i330"
User time (seconds): 8.01
System time (seconds): 0.77
Percent of CPU this job got: 98%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.92
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 2354200
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 1
Minor (reclaiming a frame) page faults: 587520
Voluntary context switches: 419
Involuntary context switches: 63
Swaps: 0
File system inputs: 0
File system outputs: 0
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 4096
Exit status: 0


python311Packages.aiosmtpd: 1.4.4.post2 -> 1.4.5

Diff: https://github.com/aio-libs/aiosmtpd/compare/refs/tags/v1.4.4.post2...v1.4.5
Changelog: https://github.com/aio-libs/aiosmtpd/releases/tag/v1.4.5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Done in https://github.com/NixOS/nixpkgs/commit/4a2260a4b3ff0e12e8815b70ab94325a610ea715?

Commits were cherry-picked into #305152


Chore: Update to .NET 8

Once .NET 8 enters RC status, let's migrate to .NET 8

[ ] Migrate projects
[ ] Migrate container scripts
[ ] Migrate GitHub actions

With RC1 released on Sept 12, 2023, this item is unlocked for us to begin development


Create the database with models/relations and connect it to project

#19
@tushar5526
Pending approval.


Fixing logout

Fixed logout button.
Implemented cancel button on Login page, goes back to sign-up page.
Moved dialogue panel logic for Signup page cancel button into anonymous actionlistener.

oops


jwalk appears to swallow PermissionDenied

I was playing with converting the app i'm working on from walkdir to jwalk,
In figuring i should probably look at the error formatting. I noticed that jwalk
seems to swallow up PermissionDenied type errors, when failing to descend
into a directory where walkdir seems to emit them.
I'm not sure but just reading the code, it could be happening at
https://github.com/jessegrosjean/jwalk/blob/master/src/lib.rs#L178
The directory still ends up being listed, it just doesn't descend.
I should note: this appears to happen with both WalkDir::new("./no_permission_dir") as well as
WalkDir::new(".") when no_permission_dir/ is a subdirectory.

Thanks for the report.
Looking into this and I think it is working as intended when the unreadable directory is a subdirectory. In that case the directory is included in the results, but it has dir_entry.content_error set to the underlying permissions error.
But when the unreadable directory is the root of the traversal it looks like that content_error isn't getting set. I'll try to fix that soon.

I'm not sure but just reading the code, it could be happening at
https://github.com/jessegrosjean/jwalk/blob/master/src/lib.rs#L178

I think that part is working correctly. It is saying that a read of the dir entries content should only be scheduled (that's what a content_spec is, a scheduled read) if the dir_entry is a directory. If it's not a directory, or if there was an error reading the file type then don't schedule content read.
In the case where there was an error reading the file type a DirEntry is returned, but the file_type value is set to the underlying error.

Thanks, I had indeed overlooked the existence of the content_error field of DirEntry,
and assumed that such errors would up as part of the iteration results


rox-filer: pull upstream fix for -fno-common toolchains

Without the change build agaist -fno-common toolchains like upstream
gcc-10 fails as:
$ nix build -L --impure --expr 'with import ./. {}; rox-filer.overrideAttrs (oa: {   NIX_CFLAGS_COMPILE = (oa.NIX_CFLAGS_COMPILE or "") + "-fno-common"; })'
...
ld: session.o:/build/rox-filer-2.11/ROX-Filer/build/../src/session.h:13:
  multiple definition of `session_auto_respawn';
    main.o:/build/rox-filer-2.11/ROX-Filer/build/../src/session.h:13:
    first defined here

While at it normalized local patch against top-level source tree
to ease application of upstream patches as is.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Spelling mistake in commit message

Fixed typo. Thanks!


please clarify variable name

@sarahgp we in houston were wondering whether the weeArc variable in your sketch means "wee" like small or "wee" like "weeee i'm on a roller coaster". please let us know   👻

Oooo. Definitely the former. The latter has an h. :mouse: :roller_coaster:

👍👍👍👍👍


Annotate a couple of +1-returning functions appropriately

Annotate a couple of +1-returning functions appropriately instead of trying to compensate in the caller.
One of the callers was apparently not _cocoaStringSlice trying to compensate, so this probably also fixes a leak.

@swift-ci Please test and merge.

Hah, I typo'ed the attributes.

@swift-ci Please test and merge.


noSwipingSlide: Unable to get property 'parentElement' of undefined or null reference

Hey,
my log tells me that user with Win7 IE11 get following error. I cannot replicate it, but at a first glance this could be fixed by extending the while condition and check if el exists.
Unable to get property 'parentElement' of undefined or null reference

in Methode noSwipingSlide:
el = el.parentElement;  // now we iterate up (parent node)
} while (!noSwiping && el.parentElement && !hasClass(el, params.wrapperClass)); // also include el.parentElement truthy, just in case.

Cheers
Marcel

Can't say much as Swiper 2.x is not supported anymore and there will no any updates or fixes for it


dotzu eat my parameters？

hello..
when i use dotzu and alamofire together
i wrote a small project, when i click button, send a request to api
first time click it's work nice, but when i click second times my parameters is gone...

but when i remove Dotzu.sharedManager.displayWindow() it's work great
is there something wrong with my code？

Fixed, thanks for reporting the issue, and making Dotzu better.
You can update the framework, version 1.5.


Renames option for 'spo user get'

Closes #5515

Seems like this option was renamed from loginName to userName. This clearly was a mistake since the expected value is not a UPN.

I'll take it and process it today

ready to merge 🚀

merged manually.