is there a way to install the dependencies automatically ?

is there a way to install the dependencies automatically ?

Yes, using a package manager and the appropriate package. I use Archlinux, so I maintain ly-git and ly in the AUR, but for other distros you will have to install them manually (or wait for someone to make the package).


[BUG] Working in 3.5 system

Module Version: v0.0.0
Describe the bug
Quests dont show in 3.5 system
To Reproduce
Steps to reproduce the behavior:
Activate module in 3.5 system. Created quest dont shown in UI (but created in module folder)
Expected behavior
Screenshots

Browser:
chrome and standalone app
Foundry Version:
0.6.6
Game System:
Dnd 3.5
Additional context
in 5e test system i installed all worked properly

Okay. My friend found solution.


Error when using submenu with "showSearchInput": true and "multiple": true

The following error occurs when using submenu with "showSearchInput": true and "multiple": true :

Uncaught TypeError: Cannot read property 'before' of null                   in selectivity-full.js:3611

with selectivity-full.js:3611 being the this.$searchInput.before from _renderSelectedItem
Basic example :
  $('#example-1').selectivity(
  {
    "items": [
    {
      "id": 1,
      "text": "one",
      "submenu":
      {
        "items": [
        {
          "id": 1,
          "text": "subOne"
        },
        {
          "id": 2,
          "text": "subTwo"
        }],
        "showSearchInput": true
      }
    }],
    "placeholder": 'No filter selected',
    "multiple": true
  });

A basic example reproducing the error is available here : https://jsfiddle.net/XavM75/fwnjx1b9/3/

Thanks for the fiddle, really helped in reproducing and writing the test case!


Starting Rustdesk automatically on Windows

I hope this is useful for other people.
Recently install Rustdesk Server on a Windows and maybe there are other ways to improve this. But to run the server automatically create a simple .bat for this.
echo Open RustDesk Automatically
cd C:\Program Files\RustDeskServer\bin\
start hbbr.exe
start hbbs.exe

And I added the bat in the Windows startup folder, if you don't know where this folder is, just add the
just open the run keyboard Windows + R
and modify shell:startup then just put the bat inside the folder, every time windows restarts, when turned on it will start your server Rustdesk Server

you could also use nssm, I should do a script for that actually

this has already been implemented by RustDesk themselves rustdesk-server-windows-x86_64.zip under https://github.com/rustdesk/rustdesk-server/releases is the most recent release up to date


Check the website badge [NEW]

What is the badge for?
Similar to read the docs, a visit the website or something similar would be cool.
Provide any preferred icons/text (icons must be SVG)
None.
Example if needed
None.

Will be available next release, coming sometime soon


Add support to perform kubernetes build in "odo deploy" using Kaniko build strategy

What type of PR is this?

/kind feature

What does does this PR do / why we need it:
This PR extends the current implementation of odo deploy to make it  kubernetes generic and allow performing unprivileged builds

Adds support for performing kaniko builds in odo deploy and pushing the built image to either an external registry or internal registry
Adds support for pushing images built using default BuildConfig path to external registries
Adds an optional dockerconfigjson flag to pass reference to a config.json file

NOTE:  This PR builds on top of work contained in #3478 , and must only be merged after #3478 has been merged
Which issue(s) this PR fixes:
Fixes #3583
PR acceptance criteria:

Unit test

How to test changes / Special notes to the reviewer:

create a new directory, cd into it and run odo create nodejs --starter=nodejs-starter
run odo url create
replace created devfile with the following sample :

schemaVersion: 2.1.0
metadata:
  name: nodejs
  version: 1.0.0
  alpha.deployment-manifest: "https://raw.githubusercontent.com/groeges/devfile-registry/master/devfiles/nodejs/deploy_deployment.yaml"
projects:
  - name: nodejs-starter
    git:
      location: "https://github.com/odo-devfiles/nodejs-ex.git"
components:
  - container:
      name: runtime
      image: registry.access.redhat.com/ubi8/nodejs-12:1-36
      memoryLimit: 1024Mi
      mountSources: true
      endpoints:
        - name: http-3000
          targetPort: 3000
          configuration:
            protocol: tcp
            scheme: http
            type: terminal

  - dockerfile:
      name: dockerfile-build
      source:
         sourceDir: "src"
         location: "https://github.com/ranakan19/golang-ex.git"
      dockerfileLocation: "https://raw.githubusercontent.com/jaideepr97/OpenShift-guides/master/Dockerfile"
      destination:
      Rootless: true

commands:
  - exec:
      id: install
      component: runtime
      commandLine: npm install
      workingDir: /project
      group:
        kind: build
        isDefault: true
  - exec:
      id: run
      component: runtime
      commandLine: npm start
      workingDir: /project
      group:
        kind: run
        isDefault: true
  - exec:
      id: debug
      component: runtime
      commandLine: npm run debug
      workingDir: /project
      group:
        kind: debug
        isDefault: true
  - exec:
      id: test
      component: runtime
      commandLine: npm test
      workingDir: /project
      group:
        kind: test
        isDefault: true

run odo deploy --tag=<imageTag>

NOTE: setting Rootless: true  will trigger a kaniko build. The default value is false and will trigger a build using buildConfig
NOTE: Please supply complete destination under --tag
( for ex: image-registry.openshift-image-registry.svc:5000/namespace/imagestream or docker.io/username/repository-name)
NOTE: (Relevant to external registry push only) if --dockerconfigjson is not specified, config.json is picked up from ~/.docker. Please ensure the default config.json file contains a valid auth token. External registry push is currently only configured for Dockerhub

cc @wtam2018 @sbose78 @EnriqueL8 @neeraj-laad @groeges @kadel

/ok-to-test

/status blocked
let's get https://github.com/openshift/odo/pull/3478 merged first

@kadel Makes sense
Are these prerequisites for the PR to just be reviewed or merged?

@kadel Makes sense
Are these prerequisites for the PR to be reviewed or merged?

Just for merging.
It would be great if someone from @wtam2018 @reginapizza @ranakan19 @Shraddhak22 reviews it.

did a partial pass through of the code, will take a look again soon.

did a partial pass through of the code, will take a look again soon.

Thanks for the feedback @girishramnani
Will rebase and work on the changes requested for the code introduced in this PR for now

Closing this PR as it has diverged


v2.7.1

Fixes

builder: use warn only for mismatched dependencies (#5723)
webpack: correctly resolve consola for the client bundle (#5729)

Dependency Upgrades

postcss-import-resolver: prefer style property when resolving (jsless/postcss-import-resolver#2)

Thanks to

Blake Kostner (@btkostner)

Codecov Report

Merging #5733 into 2.x will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              2.x   #5733      +/-   ##
=========================================
- Coverage   95.65%   95.6%   -0.05%
=========================================
  Files          82      82
  Lines        2669    2662       -7
  Branches      684     683       -1
=========================================
- Hits         2553    2545       -8
- Misses         97      98       +1
  Partials       19      19

Impacted Files
Coverage Δ

packages/builder/src/builder.js
100% <100%> (ø)
:arrow_up:

packages/webpack/src/config/base.js
94.94% <100%> (ø)
:arrow_up:

packages/vue-renderer/src/renderer.js
93.49% <0%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121d481...c741bb4. Read the comment docs.

The postcss-import-resolver change will align for postcss-import behaviour
, so it should be OK to include in release.

@clarkdo  A fresh install will get this update anyway and seems not a breaking change. We may do a patch if got breaking reports.


Edge CH speedup

there are still some api limit reached errors in the tests.

there are still some api limit reached errors in the tests.

Probably increasingly more people are testing the code base (or some misusage ;)). Will fix.
Would it be ok to merge #1447 now - i.e. before this here?

Would it be ok to merge #1447 now - i.e. before this here?

Yes sure, this here can wait.

Ah, cool you already updated it - thanks!

Do you think we can merge?

yes


GraphQL errors on new clone

Bug report

What is the current behavior?
On a clean clone, ran npm install and gatsby develop. Receiving multiple GraphQL errors of which the following is a sample:
 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "featuredimage" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "featuredimage". If you didn't expect
"featuredimage" to be of type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\components\BlogRoll.js:96:33

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

If the current behavior is a bug, please provide the steps to reproduce.

Clone repo
Run npm install
Run gatsby develop

What is the expected behavior?
Development site starts correctly and can be served from localhost.

Other relevant information:

Node.js version: 18.10.0
NPM/Yarn version: 8.19.2
Operating System:  Windows 10
Additional tools:  Gatsby CLI 4.24 (installed via choco)

More context: the first time I did this I followed recommendations and deployed to Netlify first and verified that site and CMS were up and running fine.  It was only when I cloned locally for local development that it fell over as I described above.  And I believe at that time I did run npm run build because I was following instructions in the readme.

I did not try to edit anything from the CMS on Netlify. I have since taken down the Netlify site so I can focus on getting it running locally.

I just clone it with use this template button and when I just run yarn develop. It shows error message like the image

@intelcoder Howdy can you give the system stats for what you're running? Operating system, node version and package manager version?
I'm trying to recreate this error but I can't seem to reproduce it on three different systems from a fresh install, using the same node versions and everything. Locally this error never occurs for me. Could someone provide their repository for me so I can investigate it from there? Maybe there was a missing update in between installs?

Ran it again, with the following:

Brand-new clone of this repository.
 This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

added 1962 packages, and audited 1963 packages in 1m

333 packages are looking for funding
  run `npm fund` for details

44 vulnerabilities (23 moderate, 21 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

Results of npm run build:
><EMAIL_ADDRESS>build
> npm run clean && gatsby build

><EMAIL_ADDRESS>clean
> gatsby clean

info Deleting .cache, public, C:\Users\Zach\Projects\gatsby-starter-netlify-cms\node_modules\.cache\babel-loader,
C:\Users\Zach\Projects\gatsby-starter-netlify-cms\node_modules\.cache\terser-webpack-plugin
info Successfully deleted directories

success compile gatsby files - 1.636s
success load gatsby config - 0.103s
success load plugins - 8.798s
warn gatsby-plugin-react-helmet: Gatsby now has built-in support for modifying the document head. Learn more at
https://gatsby.dev/gatsby-head
success onPreInit - 0.014s
success initialize cache - 0.185s
success copy gatsby files - 1.161s
success Compiling Gatsby Functions - 1.851s
success onPreBootstrap - 1.924s
success createSchemaCustomization - 0.011s
success Checking for changed pages - 0.001s
success source and transform nodes - 0.322s
info Writing GraphQL type definitions to C:/Users/Zach/Projects/gatsby-starter-netlify-cms/.cache/schema.gql
success building schema - 0.431s
success createPages - 0.100s
success createPagesStatefully - 0.132s
info Total nodes: 135, SitePage nodes: 20 (use --verbose for breakdown)
success Checking for changed pages - 0.001s
success onPreExtractQueries - 0.001s

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "featuredimage" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "featuredimage". If you didn't expect
"featuredimage" to be of type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\components\BlogRoll.js:96:33

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\index-page.js:122:15

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\index-page.js:136:19

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:158:15

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:167:19

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:182:19

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:190:19

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "image". If you didn't expect "image" to be of
type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:198:19

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

 ERROR #85922  GRAPHQL

There was an error in your GraphQL query:

      Field "full_image" must not have a selection since type "String" has no subfields.

      This can happen if you e.g. accidentally added { } to the field "full_image". If you didn't expect "full_image" to
 be of type "String" make sure that your input source and/or plugin is correct.
      However, if you expect "value" to exist, the field might be accessible in another subfield. Please try your query
in GraphiQL.

      It is recommended to explicitly type your GraphQL schema if you want to use optional fields.

File: src\templates\product-page.js:210:20

See our docs page for more info on this error: https://gatsby.dev/creating-type-definitions

failed extract queries from components - 2.043s

I have the same problem, did you solve it?

I have the same problem, did you solve it?

Me also, was this ever solved?

I solved the warning messages as @matheusdamiao indicated but I never did solve the underlying issue. I am no longer actively working on this and I decided to go with first a different Gatsby template and later a different static site generator altogether (not because of this.)

Bumping gatsby-remark-relative-images to "^0.3.0" and adding these changes to gatsby-node.js worked for me

I had the same issue and tried aforementioned troubleshooting steps to no avail. What did work for me was instead of using gatsby-remark-relative-images-v2 plugin, I used this instead: https://www.npmjs.com/package/gatsby-plugin-netlify-cms-paths to get it working locally.
See https://github.com/gatsbyjs/gatsby/issues/5990#issuecomment-1266701511.


Add custom parameter encoding example.

Adds an example of how to write and use a custom parameter encoding.
Closes https://github.com/Moya/Moya/issues/1257

Is there a way to run the CI again?

Triggered a rebuild @pietrocaselani! :)

Codecov Report

Merging #1343 into master will increase coverage by 0.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   81.81%   82.73%   +0.91%
==========================================
  Files           7       24      +17
  Lines         187      753     +566
==========================================
+ Hits          153      623     +470
- Misses         34      130      +96

Impacted Files
Coverage Δ

Sources/Moya/Plugins/NetworkLoggerPlugin.swift
91.8% <0%> (ø)

Sources/Moya/Cancellable.swift
100% <0%> (ø)

Sources/Moya/MoyaProvider.swift
81.53% <0%> (ø)

Sources/Moya/Plugins/AccessTokenPlugin.swift
100% <0%> (ø)

Sources/Moya/Plugins/CredentialsPlugin.swift
100% <0%> (ø)

Sources/Moya/Plugin.swift
75% <0%> (ø)

Sources/Moya/Response.swift
95.65% <0%> (ø)

Sources/Moya/Plugins/NetworkActivityPlugin.swift
100% <0%> (ø)

Sources/Moya/MoyaError.swift
31.81% <0%> (ø)

Sources/Moya/URL+Moya.swift
100% <0%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8789f8f...3341f21. Read the comment docs.

Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.


CodeTriage site is down!

No, this is NOT an April Fools' joke.  The site is down as of 6:39PM Centray Daylight Time (23:39 UTC).  When I go to https://www.codetriage.com/, I see the message "We're sorry, but something went wrong."

The site is up and running now, so I'm closing this issue.


Add jarret-dyrbye.json

bump.
Any feedback or chance of this getting merged? thanks.

This doesn't appear to be something I wish to be involved in. Thanks.


Torrent list styling

Download button is a lot easier to read: white down arrow when off, animated and pulsating green down arrow when downloading, solid green up arrow when seeding

Play button shows a spinner if you click play before a torrent is ready, then an exclamation point if the torrent still isn't ready after 10 seconds

Drop target shows up always, not just when the torrent list is empty. Lights up when you drag something

Fixed alignment, the Xs to delete torrents are now aligned with the + to add a new torrent

One bug: if you drag a file over the app but don't drop it, then move the mouse away again, the drop target stays lit up.
I think this is because of https://github.com/feross/drag-drop/issues/21

@feross might want to retroactively review. also try it / LMK if it feels right!


Broken disconnection handling since 1.0.132 in Linux

Before 1.0.132, when the remote SSH got disconnected, Terminus would show it and a press on Enter (or clicking "Reconnect" in the top right '...' menu) would reconnect the session.
Now, disconnection is not detected. The session window does not respond (but it's not frozen, the cursor is still blinking). The '...' menu toolbar does not who when hovering the button as it was. The '...' button disappears on hovering.
The same problem occurs when connection is not successful, there is no way to reconnect. The tab must be closed and opened new again.

Happens in windows too
Version: 1.0.128-nightly.0
Platform: win32 6.3.9600


Replace dependencies types from compile to api, implementation

Per Android studio logs:

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

This commit fixes this warning

Thanks for the PR! Sadly this conflicted with some other changes, so I'll have to close. My bad since I was slow at merging.


Add write_csv to DataFrame

Which issue does this PR close?

Closes #1777 task 7
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@alamb would you mind checking this out to see if going in right direction?  I took the logic for writing csvs and put it in new function plan_to_csv within src/physical_plan/file_format/csv and moved testing there.  Then just used that function in both ExecutionContext and DataFrame
currently failing because of the signature of write_csv having impl AsRef<str> which i took from the existing implementation on ExecutionContext but doesnt work because trait object cant have method with generic type parameter.  Is there a reason we cant use &str?  More details here https://doc.rust-lang.org/error-index.html#E0038  and i dont think any of the proposed workarounds are good for our use case.

I took the logic for writing csvs and put it in new function plan_to_csv within src/physical_plan/file_format/csv and moved testing there. Then just used that function in both ExecutionContext and DataFrame

Looks good to me 👍

currently failing because of the signature of write_csv having impl AsRef which i took from the existing implementation on ExecutionContext but doesnt work because trait object cant have method with generic type parameter. Is there a reason we cant use &str?

I think taking &str is totally fine in the DataFrame trait

@alamb thanks!

Hi thanks for the contribution
I wonder if we can use an extension trait for Csv writing method so that users can choose to use the method if they import the trait - same goes to other potential methods like write json files, etc.
This way we can reduce the minimal dataframe struct size

@Jimexist im not opposed, but would the idea be to do this only for methods that are writing? or should this be generalized to all IO methods? Im just wondering where we draw the line between core dataframe methods and extensions.

@Jimexist what would you think about merging this as is and then tackling that point as part of convos on #1712 where there is interest in moving DataFrame from trait to struct.


Does not work with git worktrees - does not autodetect branches and does not find manually entered branches

Bug description

Open an IntelliJ project workspace on a git worktree.
Machete does not autodetect the repo's branches.

Diagram area displays message "Provided machete file (xxxx) is empty and branch layout can't be automatically detected"
The "empty machete file" path points to the "gitdir" value in the .git worktree file: (gitdir value path)\machete
Note: .git is a file in a worktree, not a directory, containing the "gitdir" value.

Clicking "Discover Branch Layout..." button as an additional invocation does not discover them; displays an empty branches dialog.
Manually editing the machete file and adding any branches does not work.

Diagram area displays message "None of the branches provided by machete file (xxxx) exists within the local repository"

Would like Machete to use the machete file from the main location vs have its own, if possible.
Running environment

Git Machete plugin version: 1.2.0
IDE type: IntelliJ
IDE version: Ultimate 2021.3.3
Operating system Windows

Thanks for reporting, I'll try to get that sorted over the weekend. Seems related (albeit not identical) to the issue recently reported by @kgadek & resolved recently in the CLI: https://github.com/VirtusLab/git-machete/issues/360.
Out of curiosity, how did you learn about this plugin?

will try to get it sorted over the weekend

Thank you.

Out of curiosity, how did you learn about this plugin?

It was mentioned in a post with some other plugins.

Done! check v1.2.1. I'd appreciate any additional feedback, on the now-fixed worktree support or otherwise

Works well now with my worktrees across many repos!  Thank you for making it work.


Fix heading structure on browse pages

What
Fix heading structure on browse pages.
Review URL(s):

births, deaths, marriages and care
business
benefits

Why
After changes in https://github.com/alphagov/collections/pull/3437, the heading structure across browse pages (excluding benefits and business) are now incorrect due to a missed heading level.
Anything else
I've tested the following pages with HeadingsMap
Births, deaths, marriages and care
Births, deaths, marriages and care - GOV.UK
    2 Navigation menu
1 Births, deaths, marriages and care
    2 Certificates, register offices, changes of name or gender
    2 Child Benefit
    2 Death and bereavement
    2 Having a child, parenting and adoption
    2 Lasting power of attorney, being in care and managing finances
    2 Marriage, civil partnership and divorce
    2 Is this page useful?
    2 Services and information
    2 Government activity
    2 Support links

Business and self-employed
Business and self-employed - GOV.UK
    2 Navigation menu
1 Business and self-employed
    2 Popular tasks
    2 Topics
        3 Setting up
        3 Business tax
        3 Business finance and support
        3 Running a limited company
        3 Expenses and employee benefits
        3 Business debt and bankruptcy
        3 Business premises and business rates
        3 Food, catering and retail
        3 Importing
        3 Exporting and doing business abroad
        3 Licences and licence applications
        3 Selling your business and closing down
        3 Sale of goods and services and data protection
        3 Childcare providers
        3 Manufacturing
        3 Patents, trade marks, copyright and designs
        3 Business waste and environmental impact
        3 Scientific research and development
        3 Maritime vessels and work at sea
    2 Is this page useful?
    2 Services and information
    2 Government activity
    2 Support links

Benefits
Benefits - GOV.UK
    2 Navigation menu
1 Benefits
    2 Popular tasks
    2 Topics
        3 Manage an existing benefit, payment or claim
        3 Benefits and financial support if you're looking for work
        3 Benefits and financial support if you're temporarily unable to work
        3 Benefits and financial support for families
        3 Benefits and financial support if you're disabled or have a health condition
        3 Benefits and financial support if you're caring for someone
        3 Benefits and financial support if you're on a low income
        3 Benefits and financial support when someone dies
    2 Is this page useful?
    2 Services and information
    2 Government activity
    2 Support links

https://github.com/alphagov/collections/pull/3474


Generation of implementation stubs for "operationId"-specified functions

Description
I'm just starting out with connexion, so please forgive me if this is a naive question, but is there any way to generate server-side implementation stubs for functions defined using "operationId" in the yaml OpenAPI spec?
Expected behaviour
Ideally, if there is a function specified by operationId, it would be possible to generate a function definition including:

the correct input arguments
return values/logic
docstrings

Actual behaviour
As far as I can tell this is not implemented.
I see there is "mocking" behavior implemented (https://github.com/zalando/connexion/blob/master/connexion/mock.py), but this doesn't seem to be what I want.

There is https://github.com/swagger-api/swagger-codegen/wiki/Server-stub-generator-HOWTO#python-flask-connexion but the code is very clumsy and not extendible.
I think a better way would be having an abstract base class with some static abstract functions. This class can then be inherited in a separate file and the IDE would tell you which methods you need to implement. A good IDE will also generate a stub from that for you.


[SPARK-41008][MLLIB] Follow-up isotonic regression features deduplica…

What changes were proposed in this pull request?

A follow-up on https://github.com/apache/spark/pull/38966 to update relevant documentation and remove redundant sort key.
Why are the changes needed?

For isotonic regression, another method for breaking ties of repeated features was introduced in https://github.com/apache/spark/pull/38966. This will aggregate points having the same feature value by computing the weighted average of the labels.

This only requires points to be sorted by features instead of features and labels. So, we should remove label as a secondary sorting key.
Isotonic regression documentation needs to be updated to reflect the new behavior.

Does this PR introduce any user-facing change?

Isotonic regression documentation update. The documentation described the behavior of the algorithm when there are points in the input with repeated features. Since this behavior has changed, documentation needs to describe the new behavior.
How was this patch tested?

Existing tests passed. No need to add new tests since existing tests are already comprehensive.
@srowen

Can one of the admins verify this patch?

Just modified tests I added in my previous PR. In one, just used same values as in the ticket. In the other, just modified to test exact equality instead of approximate.

SGTM. Merged to master


Add 'resisable' option for matplot

Fixes #363

Hi @dmitriy-serdyuk! Sorry for the delay here - taking a look now 👍

@JackUrb , done

Thanks for the update!


Compute the camera calibration matrix and distortion coefficients given a set of chessboard images

CRITERIA

[ ] Briefly state how you computed the camera matrix and distortion coefficients.
[ ] Provide an example of a distortion corrected calibration image.

MEETS SPECIFICATIONS
OpenCV functions or other methods were used to calculate the correct camera matrix and distortion coefficients using the calibration chessboard images provided in the repository (note these are 9x6 chessboard images, unlike the 8x6 images used in the lesson). The distortion matrix should be used to un-distort one of the calibration images provided as a demonstration that the calibration is correct. Example of undistorted calibration image is Included in the writeup (or saved to a folder).


Keep a lineage graph state in query params

So that users would be able to:

Share lineage graph
Keep lineage graph state after changing a context

Lineage state:
depth: int
full/compact: boolean
expanded all degs: boolean
load more upstream: [int]
load more downstream: [int]
expanded items: [int]
coordinates: (x, y)
controls: boolean


Configuration mode.

Have this code support for configuration mode?

I can not add the ¨question¨ labe for the issue.

@denisacostaq there is no suppose to Eddystone configuration mode in this library currently. However, it should be straightforward to add, pull requests welcome.


Warnings for failed data import

When importing data, if some required properties of records (nodes) are missing, these nodes are not imported. But in the UI it will still display successfully imported.
Expected: Warnings are given, telling the user how many records are imported, how many failed.

There is a "continue_on_error" option while use lgraph_import tools, and this option is "yes" by default using web import.
It should have logs when import completes, we will add logs in the future.


Delay start payment after delegate vote

Hello,
I voted for the delegate arkpool for two days and have not yet received any payment (settlement announced every 6h). Is there a timeout or is this a bug? What can I do to unlock...
Previously I had voted for another without problem. I followed the procedure of unvote and new vote, which seems to have gone correctly.
Thank for your help.

You should contact arkpool delegate owner (best in Ark slack) - delegates are community members and Ark team cannot assist you in this matter.

Thanks ! I do this... and sorry for this error.

yes this is not linked to this software, but to the delegate. Closing as it is unrelated.


update eas-build-job

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
eas-build-job was not updated for a while, e.g current version does not support explicitly specifying latest macOS version by name in eas.json

/changelog-entry chore Update eas-build-job.


add-loader in project.janet unknown symbol

Was trying to do jpm rules and got the output:
./project.janet:8:1: compile error: unknown symbol add-loader

What is add-loader in project.janet?  Is that something from spork?
Oh wait, may be it's from cgen?

It is definitely cgen. I am seeing the same in gp.

@pepe Ah I see.
With the latest jpm, I think this won't work because add-loader got removed (possibly unintentionally).

Indeed. I am sure you are right.

I mentioned the removal of add-loader at the help channel so may be we'll get a response there about it.

Looks like it's back: https://github.com/janet-lang/jpm/commit/6771439785aea36c76c5aec7c2d7f67df83c46bb


UI binding as button for better accessibility

Feature Request

Please describe the problem you're trying to solve and explain how you would like to solve it. Try to make a strong point to support your case.
Also please indicate whether you are willing to implement the feature yourself if pointed in the right direction.

https://naja.js.org/#/ui-binding
Currently it's only possible (to my knowledge) to bind .ajax or data-naja on a and form.  It would be good for accessibility to be able bind it to button or any other element, eg. button[data-naja] with data-naja-url and aria-label which would be more accessible than a[href] link in most use cases.

Hi, thank you for your suggestion. I have to respectfully reject it.
One of Naja's fundamental goals is to provide a progressive enhancement over the standard web experience – it makes things run asynchronously, but if the user has disabled/broken/not-yet-loaded JS, they can still click a link or submit a form to accomplish their intention. From where I see it, the best thing accessibility-wise is to stick to these web primitives, and make everything either a link, or a form, depending on the nature of the operation.
That's what Naja aims to provide and I'd like to keep it that way. That being said, your suggestion seems fairly trivial to implement in user land if you wish so:
const buttons = document.querySelectorAll('button[data-naja]');
buttons.forEach((button) => {
    if (button.form) return; // ignore form-bound buttons, Naja already handles those
    button.addEventListener('click', () => naja.makeRequest('GET', button.dataset.najaUrl));
});

this shouldn't be link, accessibility wise it doesn't do navigation and it's confusing for users with screen readers and what happens if you open the link in new window? This should be button, that's why this tag exists.

Oh, I agree with you completely. But a button on its own is useless without JS. I believe the correct solution in this case is to wrap that button in a form because that covers a lot of the bases for little effort. It's a solution that works perfectly without JS – it can use POST which is the better method for a state-changing and possibly non-idempotent operation, and it can easily be made accessible – and JS can build on top of that to progressively enhance the experience.

And thanks for the js snippet, but if I'm not wrong this wouldn't trigger interaction event right? I guess that can be added manually too, but it would just be nice if this was possible by default without workarounds.

Right. I can imagine adding a helper method to UIHandler that would process custom interactions like this 🤔

Yeah agree form would be best for this, to make it also work without js. But I'm afraid no one does this. At least from my experience everyone always takes the easier  route with link. :/

@jiripudil any update on that helper method for UIHandler? Should I perhaps create a new issue for that?

any update on that helper method for UIHandler? Should I perhaps create a new issue for that?

Thanks for the nudge, I've come up with #395


c++ Parquet StreamWriter Dictionary Encoding

Describe the usage question you have. Please include as many useful details as  possible.
Hi team,
We extensively use Arrow / Parquet files for data analysis with Pandas, it's excellent! We are attempting to use the parquet stream writer to build parquet files which are then consumed in Python for research.
The code below works except for dictionary fields types. These are important to our work as we have billions of rows and a large number of repeating short strings. In Pandas with the dictionary field type it will load columns as the category dtype rather than object which results in unmanageable memory requirements.
Our original approach first builds arrow tables with an arrow schema using StringDictionaryBuilder and then writes the parquet files. This method works with the dictionary fields but does not offer the streaming approach we require.
We would really appreciate any support on how to set the baz column to be a dictionary field? Many thanks!
Versions:
C++:
libarrow 16.1.0-1
libparquet 16.1.0-1

Python:
pyarrow 16.1.0
Python 3.12.3

Parquet Stream Writer
// parquet writer options
auto parquet_properties = parquet::WriterProperties::Builder()
        .compression(arrow::Compression::SNAPPY)
        ->data_page_version(parquet::ParquetDataPageVersion::V2)
        ->encoding(parquet::Encoding::DELTA_BINARY_PACKED)
        ->enable_dictionary()
        ->enable_statistics()
        ->version(parquet::ParquetVersion::PARQUET_2_6)
        ->build();

// parquet schema
auto fields = parquet::schema::NodeVector{};
fields.push_back(parquet::schema::PrimitiveNode::Make(
        "foo",
        parquet::Repetition::REQUIRED,
        parquet::Type::INT64,
        parquet::ConvertedType::INT_64)
);
fields.push_back(parquet::schema::PrimitiveNode::Make(
        "bar",
        parquet::Repetition::REQUIRED,
        parquet::LogicalType::Timestamp(false, parquet::LogicalType::TimeUnit::MILLIS, false, true),
        parquet::Type::INT64)
);
fields.push_back(parquet::schema::PrimitiveNode::Make(
        "baz",
        parquet::Repetition::REQUIRED,
        parquet::LogicalType::String(),
        parquet::Type::BYTE_ARRAY)
);
auto schema = std::static_pointer_cast<parquet::schema::GroupNode>(parquet::schema::GroupNode::Make("schema", parquet::Repetition::REQUIRED, fields));

// open filestream
auto file_system = arrow::fs::LocalFileSystem{};
auto outfile = file_system.OpenOutputStream("new.parquet").ValueOrDie();

// open parquet stream writer
auto parquet_file_writer = parquet::ParquetFileWriter::Open(outfile, schema, parquet_properties);
auto parquet_stream = parquet::StreamWriter{std::move(parquet_file_writer)};

Pandas Reading New parquet::StreamWriter
import pandas as pd
import pyarrow.parquet as pq

df = pd.read_parquet("new.parquet")
df.dtypes

foo             int64
bar    datetime64[ms]
baz            object <-------- should be category
dtype: object

schema = pq.read_schema("new.parquet")
schema

foo: int64 not null
bar: timestamp[ms] not null
baz: string not null <-------- string not dictionary

Pandas Reading Original parquet::arrow::WriteTable
import pandas as pd
import pyarrow.parquet as pq

df = pd.read_parquet("original.parquet")
df.dtypes

foo             int64
bar    datetime64[ms]
baz            category <-------- correct
dtype: object

schema = pq.read_schema("original.parquet")
schema

foo: int64 not null
bar: timestamp[ms] not null
baz: dictionary<values=string, indices=int32, ordered=0> <-------- correct

Component(s)
C++

read_parquet/read_table would have read-dictionary api, perhaps you should also use that

thanks @mapleFU for the suggestion. It unfortunately doesn't work for our use case; it would require the user to be aware of the dictionary columns. We need the parquet to be written with the correct schema.

Can you elaborate a case that this doesn't work? I'll recheck it

Hi @mapleFU, with the example code above, using pyarrow.parquet.read_table doesn't work for our needs as; 1. users would need to use pyarrow instead of pandas; 2. users would need to be aware of the dictionary columns fields for each file (should be part of the schema); and 3. the data is not stored in the format we require i.e. dictionary int fields rather than compression string encoding.
We want to be able to build parquet files with the dictionary fields (which works for the non streaming C++ API) and utilise the stream C++ stream writer. thanks

We need the parquet to be written with the correct schema.

I've check this
// parquet writer options
auto parquet_properties = parquet::WriterProperties::Builder()
        .compression(arrow::Compression::SNAPPY)
        ->data_page_version(parquet::ParquetDataPageVersion::V2)
        ->encoding(parquet::Encoding::DELTA_BINARY_PACKED)
        ->enable_dictionary()
        ->enable_statistics()
+        ->store_schema()
        ->version(parquet::ParquetVersion::PARQUET_2_6)
        ->build();

Maybe you can try to add a store_schema here. So sorry for delaying

Thanks @mapleFU, with our current non-streaming approach, see below, we're building an arrow schema which provides the string dictionary fields. These are then stored into the parquet file using the store_schema approach as you suggest.
With the the streaming API, see top of the issue, we're unable to set dictionary fields. I would have thought it will always store these fields as byte array strings rather than integers with dictionaries?
  // schema and builder
  auto schema =
      arrow::schema({
                     arrow::field("foo", arrow::timestamp(arrow::TimeUnit::MILLI)),
                     arrow::field("bar", dictionary(arrow::int8(), arrow::utf8())),
                     arrow::field("baz", arrow::float64())
     });

  auto foo_builder = arrow::TimestampBuilder(arrow::timestamp(arrow::TimeUnit::MILLI),
                                                   arrow::default_memory_pool());
  auto bar_builder = arrow::StringDictionaryBuilder{};
  auto baz_builder= arrow::DoubleBuilder();

  ...

  // parquet file output
  const auto parquet_properties = parquet::WriterProperties::Builder()
                                      .compression(arrow::Compression::SNAPPY)
                                      ->data_page_version(parquet::ParquetDataPageVersion::V2)
                                      ->enable_dictionary()
                                      ->encoding(parquet::Encoding::DELTA_BINARY_PACKED)
                                      ->version(parquet::ParquetVersion::PARQUET_2_6)
                                      ->build();

  // required to store the arrow schema for pandas to retrieve categorical types
  const auto arrow_properties = parquet::ArrowWriterProperties::Builder().store_schema()->build();

So sorry to be misleading...
void WriteParquetFile() {
  std::shared_ptr<arrow::io::FileOutputStream> outfile;

  PARQUET_ASSIGN_OR_THROW(
      outfile, arrow::io::FileOutputStream::Open("parquet-stream-api-example.parquet"));

  parquet::WriterProperties::Builder builder;

  // schema and builder
  auto arrow_schema =
      arrow::schema({
                     arrow::field("foo", arrow::timestamp(arrow::TimeUnit::MILLI)),
                     arrow::field("bar", dictionary(arrow::int8(), arrow::utf8())),
                     arrow::field("baz", arrow::float64())
     });

#if defined ARROW_WITH_BROTLI
  builder.compression(parquet::Compression::BROTLI);
#elif defined ARROW_WITH_ZSTD
  builder.compression(parquet::Compression::ZSTD);
#endif

  // parquet schema
  auto fields = parquet::schema::NodeVector{};
  fields.push_back(parquet::schema::PrimitiveNode::Make(
          "foo",
          parquet::Repetition::REQUIRED,
          parquet::Type::INT64,
          parquet::ConvertedType::INT_64)
  );
  fields.push_back(parquet::schema::PrimitiveNode::Make(
          "bar",
          parquet::Repetition::REQUIRED,
          parquet::LogicalType::Timestamp(false, parquet::LogicalType::TimeUnit::MICROS, false, true),
          parquet::Type::INT64)
  );
  fields.push_back(parquet::schema::PrimitiveNode::Make(
          "baz",
          parquet::Repetition::REQUIRED,
          parquet::LogicalType::String(),
          parquet::Type::BYTE_ARRAY)
  );
  auto parquet_schema = std::static_pointer_cast<parquet::schema::GroupNode>(parquet::schema::GroupNode::Make("schema", parquet::Repetition::REQUIRED, fields));
  auto parquet_writer = parquet::ParquetFileWriter::Open(outfile, parquet_schema, builder.build());
  auto serialized_schema =
                        ::arrow::ipc::SerializeSchema(*arrow_schema, ::arrow::default_memory_pool()).ValueOrDie();

  // The serialized schema is not UTF-8, which is required for Thrift
  std::string schema_as_string = serialized_schema->ToString();
  std::string schema_base64 = ::arrow::util::base64_encode(schema_as_string);
  parquet_writer->AddKeyValueMetadata(::arrow::KeyValueMetadata::Make({"ARROW:schema"}, {schema_base64}));

  parquet::StreamWriter os{std::move(parquet_writer)};

  os.SetMaxRowGroupSize(1000);

  for (auto i = 0; i < TestData::num_rows; ++i) {
    os << int64_t(1000000);
    os << UserTimestamp{std::chrono::milliseconds{1000000 * i}};
    os << "def";
    os << parquet::EndRow;

    if (i == TestData::num_rows / 2) {
      os << parquet::EndRowGroup;
    }
  }
  std::cout << "Parquet Stream Writing complete." << std::endl;
}

@adampinky85 The core point here is
  // The serialized schema is not UTF-8, which is required for Thrift
  std::string schema_as_string = serialized_schema->ToString();
  std::string schema_base64 = ::arrow::util::base64_encode(schema_as_string);
  parquet_writer->AddKeyValueMetadata(::arrow::KeyValueMetadata::Make({"ARROW:schema"}, {schema_base64}));

It's a hack, but I think it could be use

With the the streaming API, see top of the issue, we're unable to set dictionary fields. I would have thought it will always store these fields as byte array strings rather than integers with dictionaries?

Nope...This is hack in arrow. Parquet dictionary is unrelated to dictionary schema. This schema is set by arrow parquet writer. The stream writer lacks this.

I've verified with my file:
>>> df = pd.read_parquet("parquet-stream-api-example.parquet")
>>> df.dtypes
foo             int64
bar    datetime64[us]
baz          category
dtype: object
>>> schema = pq.read_schema("parquet-stream-api-example.parquet")
>>> schema
foo: int64 not null
bar: timestamp[us] not null
baz: dictionary<values=string, indices=int32, ordered=0> not null

So sorry for misunderstanding

@adampinky85 Have this solve the problem?

Hi @mapleFU, thanks for the details, I’m on leave currently. I’ll be back in a week and will confirm. Thanks!

Hi @mapleFU, thank you, that works! Much appreciated :)

Sorry for mistake so many times


Wrapping field value with DBMS functions on insert/update

New feature:
Allow using user-defined field value wrapper functions on insert/update queries avoiding raw SQL.
Why avoiding raw SQL?
If you want to minimize your code with a single db.save() operation, especially when you have a lot of nesting related objects, you can just set a wrapper tag instead of moving to raw SQL.
Usage:
type Object struct {
    ...
    field1 string `gorm:"wrapper:ST_GeomFromText(?)"`
    field2 string `gorm:"wrapper:UserFunc(?)"`
}

Use case:

Spatial functions. If you have geometry type fields but want to use WKT instead of WKB to write values into DB.
Date/string functions. If you want to perform extra actions on DBMS side (eg. extract only a part of value, transform a value etc.) to avoid in-app implementation.
User-defined DBMS functions to pre-process values.

Closed for improvements


Issues with the (broadcast)dates within the app

There was a request to add dates of broadcast to the stream, they are added and the issue was closed but it seems there is something wrong with them.
First

Look at the dates below the thumbnails (they are ltr: 13-10, 06/10, 30/9, 23/9 amd 16/9).
Now look at the dates from NPO.nl, check the corresponding thumbnails.

It seems the have the wrong month.

Hey Renzo,
Thanks for letting me know! Could you create two issues for this (one for
the wrong dates and one for the "missing" ones), to keep the conversation
public and allowing others to look into this?
Thanks again!
-- Jeff
On 16 November 2015 at 10:43, iAmRenzo<EMAIL_ADDRESS>wrote:

There was a request to add dates of broadcast to the stream, they are
added and the issue was closed but it seems there is something wrong with
them.
First
[image: img_1953]
https://cloud.githubusercontent.com/assets/1183790/11178634/47334178-8c4e-11e5-98f1-1da5d74d9c94.JPG
Look at the dates below the thumbnails (they are ltr: 13-10, 06/10, 30/9,
23/9 amd 16/9).
Now look at the dates from NPO.nl, check the corresponding thumbnails.
[image: webcheck]
https://cloud.githubusercontent.com/assets/1183790/11178689/ab0f3238-8c4e-11e5-8063-d0e142d39232.jpg
Second
The dates are only on this view (episode view?). But I miss them on the
search results view (and also the new and popular views).
[image: img_1954]
https://cloud.githubusercontent.com/assets/1183790/11178702/ca57310e-8c4e-11e5-954d-33ec3c50a945.JPG
Because I have know idea how those views are sorted, you always have to go
to the episode view to select the right broadcast date.
—
Reply to this email directly or view it on GitHub
https://github.com/jeffkreeftmeijer/UitzendingGemist/issues/23.

Hey @iAmRenzo,
Thanks for reporting this issue, great catch! This seems to be a off-by-one error, as Date.getMonth() is zero-based.
I've opened #24 for the other issue, so we can close this one when it's fixed without having to wait for the other issue to be resolved too.

Is it possible to use the same string for the date as the NPO app? I mean "Vr 16 okt 2015 20:25" instead of "16/10/2015 20:25"? Most of the time I want to see a broadcast original aired on a certain day (for instance last Friday) without the need to check my agenda (which date was last Friday?).

Totally agree! I hate sites/apps using dates without day of the week. Even better would be to omit year when it's not older than 11 months or maybe even 'last Friday 20:25". Some frameworks have a function for that. Dunno about ios

@bluevoice @amphorainteractive yes, that'd be possible. We'd be able to use the getDay() function on date and keep a list of weekdays in Dutch. While we're at it, we could also add month names. Could you open a new issue (or a pull request) for this, @bluevoice?

Done, see https://github.com/jeffkreeftmeijer/UitzendingGemist/issues/25


Update README.md Signed-off-by: Dhruv Aggarwal<EMAIL_ADDRESS>

Corrected Typo's.
Signed-off-by: Dhruv Aggarwal<EMAIL_ADDRESS>

Thanks for the contribution, as the commit can't be accepted because of the missing DCO I've taken the changes in this PR: #39


when one of the navs items is clicked it open the dropdown but when clicked again it does not close the dropdown.

I think the main problem is that when you click on a drop-down button, it redirects you to the corresponding page (and opens the drop-down list). If you click again, you should be redirected to another page for the dropdown to close, but which one? I think this would give unexpected behavior to users.

@lennygir I think it is better to close the drop down when clicked the second time be cause it makes more sense.

@AliSinaYOusofi and @lennygir  has anyone been assigned to this issue? if not I would like to work on it.

@lennygir  I don't think so

Yeah, this is intentional because it "expands" for the page you're viewing. If the page didn't navigate on click, it would make sense to collapse it. That UX might be weird to some, but the alternative could also be weird for others.


Please retain linebreaks between tags

The scribus output XML has linebreaks and indentation to make it easier to read; some step of the SG process removes the linebreaks between the tags. (I don't know python well, but presumably this is a matter of changing result = result + line to result = "\n".join(result, line) or something.)

fyi, fix is not that quick, as the output XML gets serialized in ElementTree module, which has no "pretty print" output.
I'm trying to find infos on availability of XML output modules shipped with Scribus, as LXML would do the trick nicely but is not shipped with all distributions.

fixed. I just hope that OSX ships the minidom library along python. If you can test it on mac that'd be great. thanks for the suggestion.

btw: indentation can be disabled by setting INDENT_SLA = 0 in the backend config section.


FINEMAP for univariate fine-mapping

Since for susie_rss() (for GWAS data integration, not for xQTL where we use susie()) we decide to use the polyfun::finemapper.py wrapper, we can implement the FINEMAP method in it for free (--method FINEMAP).

(Notice that in our recent paper we showed that generally susie_rss is preferred over FINEMAP in GWAS setting)


[Fix #9716] Support deprecated Socket.gethostbyaddr and Socket.gethostbyname

Fixed https://github.com/rubocop/rubocop/issues/9716

Refactored original class to add functionality to not autocorrect and suggest replacing with instance method.
Added Socket.gethostbyaddr and Socket.gethostbyname

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Looks good. Thanks!
One bit of feedback for down the road - it'd be nice to add to the deprecation message the Ruby version in which the deprecation has happened.


Implemented new charts (Light-weight)

Now we have the new chart library! Light-weight charts is an open-source library that brings us many chart types and customization.
I have implemented these simply (very similar functionality to old charts), but there could be more changes to fit our requirements.

Turned into draft until we fix the mac bug and fix any other bugs with the charts


Deprecate function

closes https://github.com/rust-bitcoin/rust-bitcoin/issues/3602

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.459%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
19735

Relevant Lines:
23933

💛  - Coveralls

const unwrap() is only available in nightly rn I believe. :facepalm:

I dunno if this is jumping the gun too much by marking from_vb_unwrap() as deprecated so early.  It probably should be removed from deprecation until unwrap() is available in const context.

I don't see any real benefit in this bro. Also the deprecation version is wrong (this is not bitcoin crate), should use TBD.

I don't mind deprecating this but I'm confused by all the MSRV comments. We implemented from_vb_unwrap in a const context by unwrapping the result of from_vb. Yes, you have to do it with a match rather than the unwrap method. That's true of every result/option-returning function, so I don't see why this one would be special.
But yes, the version should be TBD not any specific method.

@tcharding I have a mild preference for this method to go away, since it's extra API surface for the sake of saving users 3 LOC in a few obscure const contexts. So we ought to deprecate it ASAP.

Good points.  I think I've addressed them all.  Also just tossed out a test that was really only testing if something is const which doesn't need testing imo.

I'm acking but FTR usually when deprecating we call through to the deprecated function.

Actually can you fix it bro please, sorry for missing it in earlier version of the PR.

Actually can you fix it bro please, sorry for missing it in earlier version of the PR.

I don't really see what the rational is for this and I haven't seen it done before.  Hopefully the change is what you meant though.  My eyes hurt from staring at this screen so much today, so if not I'll fix it tomorrow.

I don't really see what the rational is for this

It does a few things:

Reduces line count
Makes review easier because the diff shows the deprecation message and the call to the same function
Stops later readers having to check that the code is in sync with the non-deprecated version
Saves maintenance if the non-deprecated version gets patched at a later date

And we have a soft policy now to keep deprecated code around for the indefinite future so these things have gotten even more important since that came in.

Alright, thanks for the further explanation.  It's just that it's not as simple as calling through since there's still conditional logic required for the panic() branch.  Although I partially agree on your points.

I"m a little confused now, wasn't the point of the from_vb_unwrap function to provide a const constructor that returns Weight (as opposed to an Option<Weight>)? We decided to deprecate it because we have from_vb_unchecked. Why does this not call that function and direct users to it in the deprecation message?
Currently the, now deprecated, from_vb_unwrap provides slightly different functionality to either of the other two functions.

I"m a little confused now, wasn't the point of the from_vb_unwrap function to provide a const constructor that returns Weight (as opposed to an Option)?

I'm a little confused about why this is here as well.  I originally opened the issue because _unwrap() suffix isn't standard and I thought it should be renamed.  It has the same behavior though of from_vb_unchecked except the odd behavior of panic in release mode (instead of what would normally be an overflow in release).

We decided to deprecate it because we have from_vb_unchecked. Why does this not call that function and direct users to it in the deprecation message?

I agree, this should point to from_vb_unchecked in the deprecation message since that is the closest in behavior.  My mistake.

Currently the, now deprecated, from_vb_unwrap provides slightly different functionality to either of the other two functions.

I'm not sure what the use case is for always panic instead of the normal behavior of panic in debug mode, overflow in release.

I updated this to point to from_vb_unchecked, however I don't agree with calling through to it like:
    pub const fn from_vb_unwrap(vb: u64) -> Weight {
        from_vb_unchecked(vb);
    }

The reason I don't think we should do that in this case is it's kinda a weird rug pull since from_vb_unchecked(vb) will not panic in release mode.  Better to just let people switch over and not change the behavior of from_vb_unwrap.


Show '' and '.[!.]' if such files exist

Really simple change that prevents us from ignoring strange file names that look like unexpanded globs but really do exist.

LGTM


pretty print json in debug endpoints

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
7a98cfb192bcd518a0b8859ae3ca1a894d86c6ff
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
7a98cfb192bcd518a0b8859ae3ca1a894d86c6ff
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

not only endpoints, all debug interface json output has no indent

can we make this configurable? sometime json output with indent will render too much lines, and will be difficulty to copy.

not only endpoints, all debug interface json output has no indent

I meant debug endpoints not istio endpoints

can we make this configurable? sometime json output with indent will render too much lines, and will be difficulty to copy.

Made it configurable via query param

IMO this is something that is not responsibility of the server - use jq on client side.
Fine with it if everyone else wants this though

one use case I found this useful is to view smaller configs like mesh config with formatted output in the browser it self without using any other tools


Feature request

I'm sorry if this request shouldn't be here. If that is the case, please remove it, I won't mind.
I have this request that came out of a need on a site I'm working on for a photographer.
It's basically about cropping images.
Would it be possible to extend this plugin, or perhaps create a new one based on this that allows a user to; - Create a FIELD that contains an image you select from assets, AND the crop control of this plugin. Then the system would create a copy of the original asset, only with the cropping you selected. Instead of saving it over the original asset? This could be used to create specific cropping on images for phones, tables and desktops. Without cruttering the actual assets folder.
I'm aware there are some plugins that allows this, also Craft has ways of doing this, based on a dropdown where you can select 'top, center, bottom' etc. But that would hardly suffice for the photographer who needs exact control of the cropping.

This is certainly possible to incorporate, although its probably more for down the track when a full editor experience is implemented. This would allow for essentially a 'save as', and much more. Marking as a feature request for now - the best approach would be to fork this plugin and create something for your specific needs.


fix rounding to 0 decimals

will give full mg/dL targets and mmol/L will just convert fine, also setting in mmol/L works as intended in single decimal digits

Thanks. Did you test it also with mmol/L?

mmh, the status line shows the TT in single digits for mmol/L but history shows 2 digits - even for the ones I entered in mmol/L (the middle one at 18:52)

could that be the conversion in History tab and the setting there to 2 digits?


Add pci address lock for allocated devices

This commit add a type of lock to allocated pci address
Fixes: https://github.com/k8snetworkplumbingwg/sriov-cni/issues/219
Signed-off-by: Sebastian Sch<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 18 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 35.619%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/utils/utils.go
0
18
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
213

Relevant Lines:
598

💛  - Coveralls

Hi @SchSeba, what will happen in case the ADD command fails because of the new lock?
Will there will be one less interface in the Pod?

Hi @orelmisan nope. the pod will stay in ContainerCreating and multus will retry
example:
testpod-2jnht   Successfully assigned sriov-cni-test-2/testpod-2jnht to sriov-worker2
3m54s       Warning   DNSConfigForming         pod/testpod-2jnht   Search Line limits were exceeded, some search paths have been omitted, the applied search line is: sriov-cni-test-2.svc.cluster.local svc.cluster.local cluster.local eng.lab.tlv.redhat.com lab.tlv.redhat.com tlv.redhat.com
4m11s       Normal    AddedInterface           pod/testpod-2jnht   Add eth0 [<IP_ADDRESS>/24] from kindnet
4m11s       Warning   FailedCreatePodSandBox   pod/testpod-2jnht   Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "f10739216389f1cb0b1dced00febb5612c27e2117e2312ffbce2b9ceb832d60d": [sriov-cni-test-2/testpod-2jnht:sriov-network]: error adding container to network "sriov-network": error the deivce is already allocated for pci address 0000:04:0a.4
3m57s       Normal    AddedInterface           pod/testpod-2jnht   Add eth0 [<IP_ADDRESS>/24] from kindnet
3m57s       Normal    AddedInterface           pod/testpod-2jnht   Add net1 [] from sriov-cni-test-2/sriov-network
3m57s       Normal    Pulling                  pod/testpod-2jnht   Pulling image "fedora"
3m55s       Normal    Pulled                   pod/testpod-2jnht   Successfully pulled image "fedora" in 1.767141498s
3m55s       Normal    Created                  pod/testpod-2jnht   Created container test
3m55s       Normal    Started                  pod/testpod-2jnht   Started container test
3m53s       Normal    Killing                  pod/testpod-2jnht   Stopping container test

Thank you for the answer @SchSeba.

Hi @ormergi I am not sure if that function is even implemented today via multus

Hi @ormergi I am not sure if that function is even implemented today via multus

@SchSeba The code looks like it does, check this out https://github.com/k8snetworkplumbingwg/multus-cni/blob/v3.7/cmd/main.go#L56
It may save a few iterations of the plugin when a VF is already allocated, isn't it?

@ormergi I think it's I can open an issue so we track the request to implement the check function from the CNI API definition

Hi @SchSeba Does the new locking mechanism supports the following scenarios:

A graceful reboot of the node.
A non graceful reboot of the node (for example from a power outage).

Hi @SchSeba Does the new locking mechanism supports the following scenarios:

There is also, reboot of node then force delete of pod from k8s API, in this case, when node comes up i dont think cni will be called

Thank you for your answer @SchSeba.
Will there be leftover files that could grow in number, and thus in size over time?

they may be files overtime but I don't think that can impact a system if you ask me.

they may be files overtime but I don't think that can impact a system if you ask me.

Will it work if these files will be written to /tmp so they will be automatically deleted on reboot?

we can do it. but I am scared that some auto clean in the node if there is storage pressure, will remove the files and then we can again have the same issue

also it would be great if you could add more info in commit message about the issue and the changes introduced
and even better ( : - D ) if you can split PR to 2 commits (adding the locking mechanism and the other, integrating it in CNI code) with info on each would be even better :)
the latter is not a must ofc, depends on you.

@adrianchiris Thanks for the comments!
I make the changes let me know how it looks now :)

Hi @adrianchiris thanks for the great comments!
when you have time please have a look and let me know if you have any other comments

Thanks for addressing my comments ! LGTM


[MINOR][BUILD][BRANCH-2.2] Fix Java linter errors

What changes were proposed in this pull request?
This PR cleans up a few Java linter errors for Apache Spark 2.2 release.
How was this patch tested?
$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.

Test build #78228 has started for PR 18344 at commit 0737370.

Were this already in master? or only in 2.2?

For now, it's only for 2.2. In master branch, there are 26 errors.
Shall I create another PR for master branch, too?

Yeah you can start with master for completeness. If the changes for 2.2 are pretty similar, we can just back-port that. If it's very different, OK, we can merge a manually crafted change for 2.2 like this one.

Sure. Thank you!

Test build #78228 has finished for PR 18344 at commit 0737370.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78228/
Test PASSed.

OK do we need this PR or will https://github.com/apache/spark/pull/18345 contain all of these changes?

This is a subset of #18345 . I'll close this after #18345 is backported.

@dongjoon-hyun I back-ported your other change successfully. It was identical to this except I picked up one comment length fix as well.

Thank you for handling that!

Also, sorry for missing that comment things.


Can not import selective_scan_cuda_oflex. This affects speed.

Hello, this is a great job! I am now using vmamba as backbone on other models, but I get the following warning message, Can not import selective_scan_cuda_oflex. This affects speed. So what should I do and expect your reply

Hello, this is a great job! I am now using vmamba as backbone on other models, but I get the following warning message, Can not import selective_scan_cuda_oflex. This affects speed. So what should I do and expect your r

This issue has been resolved

此问题已解决
hello！i have meet the same problem，could you please tell me your way to fit this problem?

此问题已解决
hello！i have meet the same problem，could you please tell me your way to fit this problem?

hello！I just reconfigured the environment, and hope it was helpful!

Excuse me, can you please explain in more detail what exactly you have done to resolve this issue. I have the same problem and it led to a bug that made training time go up to 245 days. I install selective_scan sucessfully following the instruction but still the problem prevails. Thank you

Excuse me, can you please explain in more detail what exactly you have done to resolve this issue. I have the same problem and it led to a bug that made training time go up to 245 days. I install selective_scan sucessfully following the instruction but still the problem prevails. Thank you

Oh, my God！ I'm sorry to hear that. In my opinion you should choose to install the environment requirements provided by the author and then increase them accordingly. If you get a 245-day run time, I'm guessing there's something wrong with your environment.

I use framework mmcv v1.5.2 cuda 11.1 and pytorch 1.9, python 3.8. However, selective scan did not work on cuda 11.1 so there is no optimization either.

I use framework mmcv v1.5.2 cuda 11.1 and pytorch 1.9, python 3.8. However, selective scan did not work on cuda 11.1 so there is no optimization either.

It is recommended that you upgrade the CUDA version and install the environment strictly according to the author's requirements.txt.


[Feature] Add transaction api endpoints to network package

Use the following template to create your pull request
Description
For details refer to issue #1131
Type of Change

[X] New feature
[ ] Bug fix
[ ] API reference/documentation update
[ ] Other

Does this introduce a breaking change?
No.
Are documentation updates required?
No.
Testing information
Does not break tests.
Checklist

[x] Code is commented where needed
[x] Unit test coverage for new or modified code paths
[x] npm run test passes
[ ] Changelog is updated
[ ] Tag 1 of @yknl or @zone117x for review

@yknl

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can you add more details on the purpose of this PR?

@saralab -- most block explorers have an endpoint for looking up transaction details via a transaction's hash. Stack's libraries currently do not make this endpoint easy to find or use.

@saralab -- most block explorers have an endpoint for looking up transaction details via a transaction's hash. Stack's libraries currently do not make this endpoint easy to find or use.
prior art: https://web3js.readthedocs.io/en/v1.2.11/web3-eth.html?highlight=gettransaction#gettransaction

This endpoint is available via the Hiro API: https://docs.hiro.so/api#operation/get_transaction_by_id
stacks.js isn't meant to provide a JS client for that API. Feel free to use a Rosetta client (and https://docs.hiro.so/api#operation/rosetta_block_transaction) or https://www.npmjs.com/package/@stacks/blockchain-api-client
Thanks for your contribution, but it's out of scope 🙏🏽


Interstellar: Gargantua

Mod uniqueName
Tandicase.interstellargargantua
Mod name
Interstellar: Gargantua
GitHub repository URL
https://github.com/Tllya/interstellargargantua
Parent uniqueName
xen.NewHorizons
Utility mod
No response

The mod was re-uploaded because the author of the original mod was banned from the discord server Outer Wilds modding and the original mod was deleted


Use pip for python-oauth2

Since ubuntu from wily no apt package python-oauth2 is available, this package should be installed via pip.

Looks like python-oauth2 was a fork of python-oauth that has been dropped by Debian/Ubuntu since trusty (https://packages.ubuntu.com/trusty/python-oauth2). There is still a python-oauth2client being releasaed in all distros as well as python-oauth. I don't know if they provide the same functionality though

@dirk-thomas @mikaelarguedas Thank you for comments. Unfortunately python-oauth2 is for OAuth1.0 (regardless of its name) but not for OAuth2.0 (supported by python-oauth2client)
Maybe the right way to fix is just dropping this key for wily and later ubuntu distros (where this package is no more available)?

@furushchev what about python-oauth doesnt it provide OAuth1.0 ?
Regarding python-oauth2, yes we should change the rule to cover only the distributions where it's available (for Ubuntu and Debian)

@mikaelarguedas Got it! Updated.
About python-oauth, I found the reason that we should use v2 package: https://github.com/joestump/python-oauth2#history


[Security] Make Alpine image compliant with CIS Docker Community Edition Benchmark v1.1.0.

Current alpine image is not compliant with CIS Docker Community Edition Benchmark v1.1.0. Section 4 - Container Images and Build File
Please refer to [docker/docker-bench-security](https://github.com/docker/docker-bench-security.
To reproduce issues

docker pull  alpine:latest

docker run --net host --pid host --userns host --cap-add audit_control -e DOCKER_CONTENT_TRUST=1 -v /var/lib:/var/lib -v /var/run/docker.sock:/var/run/docker.sock -v /usr/lib/systemd:/usr/lib/systemd -v /etc:/etc --label docker_bench_security docker/docker-bench-security:latest -t "alpine:latest" -e "check_[12367].|check_5.[1-57-9]."

Specially, but maybe not only,  (COPY should not be used anymore. Use COPY instead.)

[INFO] 4.9  - Ensure COPY is used instead of ADD in Dockerfile
[INFO]      * ADD in image history: [alpine:latest]

This is what we in the official images program call a "base image" --
you'll note that every base image uses ADD, and there's not any other way
to accomplish what they are without doing so.
They're built from a rootfs tarball which needs to be extracted into an
empty image (FROM scratch), but we don't have any tools in an empty image
to do the extraction so we have to rely on the magic extraction behavior of
ADD (which COPY does not have).

Hi Tianon,
Thanks for your answer, this is very interesting. I understand your point.
I checked and I saw that Debian minimal image has the same behaviour. However, RHEL has not.
I see the point in official docker documentation: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
In the other hand, the point I suggested is also on official docker recommendation (docker bench security). And this official tool point it out. You could reply the CIS specification apply a not scoring check, and the actual scoring is a bug.
I am really interested in such topics.
Please let me know if I'm missing something.
Would really appreciate your feedback on this.
Best regards,
Anthony.

I think it's difficult to write a good check for ADD vs COPY. It's indeed recommended to use COPY if you don't need the added features of ADD (extracting archives and/or remote sources), but there are still valid use-cases.
Most of those use-cases can be addressed through multi-stage builds, but those cannot (yet) be used for the official images, due to how the build-system for the official images is rigged up.
Perhaps the Docker Bench tools should skip some checks for official images, or check if the ADD is done on a FROM scratch image (which is the case when you're creating a base-image from scratch; see https://docs.docker.com/develop/develop-images/baseimages/)
Might be worth opening a ticket to discuss that in the docker-bench issue tracker

I think it's difficult to write a good check for ADD vs COPY. It's indeed recommended to use COPY if you don't need the added features of ADD (extracting archives and/or remote sources), but there are still valid use-cases.
Most of those use-cases can be addressed through multi-stage builds, but those cannot (yet) be used for the official images, due to how the build-system for the official images is rigged up.
Perhaps the Docker Bench tools should skip some checks for official images, or check if the ADD is done on a FROM scratch image (which is the case when you're creating a base-image from scratch; see https://docs.docker.com/develop/develop-images/baseimages/)
Might be worth opening a ticket to discuss that in the docker-bench issue tracker

To add to the last reply... They have distro specific images with fixes for those.
https://github.com/docker/docker-bench-security/tree/master/distros


Spacing on drop down lists isn't correct on mac

Azure Data Studio Version: master

Steps to Reproduce:

Open the Connection Dialog

Expected: Spacing before text in drop down lists
Actual: Text is flush with the left side of the control
Note check the appearance of the editable combo box text below

dupe #8608


Failed adding PHOTO_LIBRARY_USAGE_DESCRIPTION

Im getting error on trying adding description for cordova-plugin-image-picker plugin.
Cli command:
$ ionic cordova plugin add cordova-plugin-image-picker --variable PHOTO_LIBRARY_USAGE_DESCRIPTION="My app wants to use library photos!"
Output:
> cordova plugin add cordova-plugin-image-picker --variable "PHOTO_LIBRARY_USAGE_DESCRIPTION=My app wants to use library photos!" --save
Error: Failed to fetch plugin git+https://github.com/abelabbesnabi/cordova-plugin-image-picker.git via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Failed to get absolute path to installed module

ionic: 3.20.0
cordova: 7.1.0

Looks like it's having issues pulling the repo. Not sure why..

Hi, I just retested it - got the same issue on Windows/Mac/Linux platforms :(


Audible emotes

About the PR
Adds new framework for emotes and their audio. I tried to make it as universal as possible. It should help to write systems that can handle emotes using custom logic (override sound, flip sprites, randomize stuff, etc).
All game logic should be exactly same. I decided to leave emotes selection UI outside this PR scope.

Tech details
Emotes can be defined using new EmotePrototype:
- type: emote
  id: Scream
  category: Vocal
  chatMessages: [screams, yells]
  chatTriggers:
    - scream
    - screams
    - screaming
    - screamed

This prototype doesn't use fluent, because different languages has different forms of verbs (depending on time, gender, etc). So some forks will have to translate this yaml directly.
When player typed emote or some code forced entity to emote, chat system raises EmoteEvent. Other systmes listen to this event and can do custom stuff. For example here is how BodyeEmotesSystem checks that entity has hands to do clapping sound:
private void OnEmote(EntityUid uid, BodyEmotesComponent component, ref EmoteEvent args)
{
    if (args.Handled)
        return;

    var cat = args.Emote.Category;
    if (cat.HasFlag(EmoteCategory.Hands))
    {
        args.Handled = TryEmoteHands(uid, args.Emote, component);
    }
}

private bool TryEmoteHands(EntityUid uid, EmotePrototype emote, BodyEmotesComponent component)
{
    // check that user actually has hands to do emote sound
    if (!TryComp(uid, out HandsComponent? hands) || hands.Count <= 0)
        return false;

    return _chat.TryPlayEmoteSound(uid, component.Sounds, emote);
}

In most cases you would use EmoteSoundsPrototype which is collection that contains emote - sound mapping:
- type: emoteSounds
  id: MaleHuman
  params:
    variation: 0.125
  sounds:
    Scream:
      collection: MaleScreams
    Laugh:
      collection: MaleLaugh

You can force entity to emote using new chat system API. For example:
if (ShowInChat)
    chatSys.TryEmoteWithChat(args.SolutionEntity, EmoteId, hideGlobalGhostChat: true);
else
    chatSys.TryEmoteWithoutChat(args.SolutionEntity, EmoteId);

Screenshots

Changelog

:cl:

add: Added new emotes with sound! Simply type into emote chat: scream, laugh, clap or snap.

I decided to leave UI emotes selection out of scope for this PR. Need to more ideaguy where to place this UI and how it should work.
Code stuff is ready for review.

a good UI for this kind of thing (although high effort) would IMO be like how stardew valley emotes work

I just fixed merge conflicts and fixed the filename type. Summary of the merge:

Changes from #13429 were removed, because this PR already handles that itself.
Moved SetSex() to SharedHumanoidAppearanceSystem, because it is now networked (#13009)
Other conflicts were trivial.


[bug]:  npm reports vulnerability in the CLI

CLI Version
0.1.1+2
Firebase Tools version
11.1.0
Flutter Doctor Output

Flutter Doctor Output
[√] Flutter (Channel stable, 3.0.2, on Microsoft Windows [Version 10.0.18363.2274], locale en-US)
• Flutter version 3.0.2 at C:\Programming\Flutter\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision cd41fdd495 (6 days ago), 2022-06-08 09:52:13 -0700
• Engine revision f15f824b57
• Dart version 2.17.3
• DevTools version 2.12.2
[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at C:\Users\xxxxxx\AppData\Local\Android\Sdk
• Platform android-31, build-tools 32.0.0
• ANDROID_HOME = C:\Users\xxxxx\AppData\Local\Android\Sdk
• ANDROID_SDK_ROOT = C:\Users\xxxxxx\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.1.5)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.1.32414.318
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.2)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
[√] VS Code (version 1.68.0)
• VS Code at C:\Users\xxxxx\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.36.0
[√] Connected device (4 available)
• ONEPLUS A5000 (mobile) • bc18175a • android-arm64  • Android 10 (API 29)
• Windows (desktop)      • windows  • windows-x64    • Microsoft Windows [Version 10.0.18363.2274]
• Chrome (web)           • chrome   • web-javascript • Google Chrome 99.0.4844.84
• Edge (web)             • edge     • web-javascript • Microsoft Edge 101.0.1210.47
[√] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

Description
I am upgrading my app to the latest version of Crashlytics, and since FlutterFire was changed in the latest versions to use the CLI I started by installing the CLI first, so I run this command:
C:\Users\xxxxx>npm install -g firebase-tools
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

changed 696 packages, and audited 697 packages in 53s

39 packages are looking for funding
  run `npm fund` for details

22 vulnerabilities (15 moderate, 7 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

And as we can see the npm is reporting that CLI has 7 high risk vulnerabilities. This is very serious in my opinion and should be fixed as soon as possible. Maybe I am missing something here because I am not experienced with npm, if that's the case I would appreciate an explanation.
Steps to reproduce
run npm install -g firebase-tools.
Expected behavior
No vulnerabilites are found.
Screenshots
No response
Additional context and comments
No response

Sorry this should be reported on the Firebase CLI repo instead.


Documentation

WIP: filling out stream documentation, other minor docs edits

Thank you for all this.
Your english is perfect :)
tell me we can merge this.

I think it's ready!

Now scipy 0.18 is released. So we can completely remove this scipy==0.16 warning.

I totally forgot about this PR. Looks ready to merge to me..

I forgot too! And I have just saw that I made comments that were not submitted!! Sorry.


Update libraries.json

Is used for example to build this designer framework: https://node-projects.github.io/web-component-designer-demo/index.html

This looks very cool, but it appears to be TypeScript only? Is this possible to use in a browser straight from a CDN?

Yes, why not. The lib is compiled to ES6, it works directly as NPM package.
With newest browser Technologies like importmaps, no build step is needed

my complete designer is also in typescript, but then only translated to ES6, no webpack, parcel or anything.
But after that not more transpilation is done. So it only uses current browser features. Cause of that it also only works in Chrome, Safari and Firefox, so no IE support

You also see here: https://www.npmjs.com/package/@node-projects/base-custom-webcomponent?activeTab=code in the dist folder (wich is linked in paackage.json) there is only .js code (okay and d.ts files)
(I also saw that I included the source in the NPM, I will remove it in the next one)


TypeError: Cannot read property 'isProvided' of undefined

After upgrade to 3.1.0, I've started to get this error when I'm running the tests.
FAIL src/Recordings/recordings.model.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'isProvided' of undefined

      at log (node_modules/@craco/craco/lib/logger.js:4:17)
      at Object.<anonymous> (node_modules/@craco/craco/lib/paths.js:36:1)
      at Object.<anonymous> (node_modules/@craco/craco/lib/config.js:3:25)

Looking into the source code, you have circular dependencies between loggger.js and args.js, so one of them is resolved to an empty object, resulting in this error.

@patricklafrance
After commenting that line:
https://github.com/sharegate/craco/blob/3dfbc5089459f9a9af88e9cb8523e8d07655bf2f/packages/craco/lib/args.js#L37
my tests are passing, so it's clearly circular deps problem.
I can reproduce it also on v3.0.0.

Hi @19majkel94
Thanks for the issue.
You're right about that circular dependency. I don't understand why the tests in my local sandbox were running without that error.
Anyway, it's fix in 3.1.1
Thank you :)


fix(cdk): only enable deletion protection if the ddb table is retained

Summary
If deletion protection is on, then the DDB table can't get deleted after a staging deployment closes.

It's very simple! I can explain...


Allow PHPUnit 7

Based on #71, here is just one new commit: 0a4f55d
/cc @froschdesign

Thanks, @webimpress!


gripper width - gripper open/close confusion

The last index of robot_obs is gripper open or close [-1/1] and 7th index is gripper width in original Calvin, see here. But it vice-verse for your case in line: https://github.com/denizyuret/calvin-scripts/blob/183fb06cba9466d8bedd72c32994bba4e8b931b9/loaddata.py#L221. Did you change it specifically Hocam or it is a small issue?
I am going to drop gripper-open/close variable in robot_obs while training action-decoder; to make it 96-dimensional and make it divisible by number of heads..

ohh okay, my bad.. its true, sorry for that..


fix warning emitted from gcc 7.3

config_int.h needs to include <sys/types.h> for useconds_t
The rest of the fixes are because gcc 7.3 warned about buffer overflow
when copying strings longer than the destination buffer.

Coverage remained the same at 80.441% when pulling 4cc58ae458c6e8a160257e92546cfdc3286080f5 on rrojo/fix-warnings into 5962e181f38cf4d404d770d3d5ec8fcef4912b64 on master.


Exclude patterns to avoid unnecessary logging

Addresses #182 #177
This PR attempts to add a migration option called exclude which is an array of patterns. If any file that is not a migration file and compiles any of these patterns, it will be ignored, otherwise the usual log will show up.

Hey @PascalPflaum would you mind to take a look or let me know who I should ping to in order to get this reviewed?

By the way, with https://github.com/sequelize/umzug/pull/190 being merged (which removes the log line altogether), I don’t think these changes are necessary anymore.


Fog doesn't work

I just noticed that the fog post processing is no longer set. This is a recent regression, most likely with https://github.com/webaverse/app/pull/2795.

This might have to do with the depth render fog overriding the main scene fog during postprocessing.


[WIP] KNOX-2095 - Adding in DefaultDispatch code and tests to handle 504 errors

What changes were proposed in this pull request?
Currently, Knox masks all connection errors as 500 errors, when they may be more accurately described using other error codes, especially 504. A change has been made to display a 504 error in the event of a socket timeout..
How was this patch tested?
Ran ant verify under Knox 1.2.0. The patch was generated against the Knox 1.2.0 branch, and subsequently applied to Knox 1.4.0. Currently ant verify is failing, but these are most likely transient errors as the same errors appear in master. Still running tests.

Hmm. It looks like the check at https://api.travis-ci.org/v3/job/607855611/log.txt failed, but the logs suggest that it may be running plugins that aren't thread safe. Assuming that this is a threading issue, is there any way to rerun the tests, possibly without parallelism?

The error was
[ERROR] Failures:
[ERROR]   GatewayCorrelationIdTest.testTestService:209
Expected: is <46>
     but: was <45>

Not an error I've seen before. I retriggered the JDK 11 job. We have some flaky tests related to ZK but not that test.

Hi Kevin, sorry for the late followup; was out yesterday. Seems like it failed on gateway-service-remoteconfig again; was it still the testTestService test? I don't have JDK 11 installed on this machine and I'd like to confirm before trying to pursue the error.
(On that note, is there any good way to check the Surefire reports/view build artifacts?)

Grasping at straws here, but looking through the test case at https://github.com/apache/knox/blob/89caa5feeed706abc8d7ce1407830ae00d97d405/gateway-test/src/test/java/org/apache/knox/gateway/GatewayCorrelationIdTest.java, is it possible that the reduced timeout might be causing the issue? I'm not completely sure how the test works, but with the change in this PR, all connection attempts that experience a socket timeout are automatically given a 403, whereas without the change, there would at least be an attempt to contact the failover nodes.
...then again, I suppose this wouldn't explain the successes in JDK8. It's a bit difficult to tell without looking at the reports unfortunately.

@jameschen1519 I don't think the test failures are related to your change.

(On that note, is there any good way to check the Surefire reports/view build artifacts?)

The Travis build details are linked in the pr and then you go to the specific build and build log. That has the same output if you were to run locally.

This PR has not been touched for over a year ago; closing it.


$els isn't available through this.vm in directives in v-for.

Vue.js version
1.0.16
Reproduction Link
https://jsfiddle.net/crswll/3c2p9bgk/6/
Steps to reproduce
View the console. You'll see it works when not in a v-for.
What is Expected?
I expected it to work in the v-for.
What is actually happening?
It's returning undefined.

The problem is should we return an array? What if there are nested v-fors? Do we return an array of arrays? That doesn't seem to be useful...
I think it's better to describe the exact scenario that led you to want this feature. What are you trying to achieve?

Actually it was me who raised this question in gitter, but later realized that I was tackling the problem in the wrong way.
Basically wanted to create a directive to slideToggle an element. The v-el would be bounded to the element to be toggled, so I could check if the v-el is visible or not.

@yyx990803 I just messed around with v-el a bit more and I think I understand the situation a lot better now. I was under the impression that vm.$els held all the elements for that component. It appears you can only get to $els from the root component.
This is what helped me to understand: https://jsfiddle.net/crswll/3c2p9bgk/7/