Failed to place sign

Trying out the plugin -  great idea!
As an example file I use
return {
  "tris203/precognition.nvim",
  lazy = false,
  config = {
    startVisible = true,
    -- hints = {
    --     ["^"] = { text = "^", prio = 1 },
    --     ["$"] = { text = "$", prio = 1 },
    --     ["w"] = { text = "w", prio = 10 },
    --     ["b"] = { text = "b", prio = 10 },
    --     ["e"] = { text = "e", prio = 10 },
    -- },
    -- gutterHints = {
    --     --prio is not currentlt used for gutter hints
    --     ["G"] = { text = "G", prio = 1 },
    --     ["gg"] = { text = "gg", prio = 1 },
    --     ["{"] = { text = "{", prio = 1 },
    --     ["}"] = { text = "}", prio = 1 },
    -- },
  },
}

On startup I often see
Failed to place sign: G
Failed to place sign: G

After some timeout that gets replaced with
Failed to place sign: {
Failed to place sign: }

How I can I help debug this? And maybe as a future feature - how would I suppress these errors?

Thanks for your report @oschrenk
I have pushed a new branch with an open PR. I will continue to fix a few bugs in this branch and then will merge it shortly.
If you wanted to test with that branch and give feedback that would be awesome!

Thank you. The branch does indeed seem to help. I don't see any error messages pop up anymore!


CTRL/CMD+F on Desktop app puts cursor in Mattermost search box filtered to channel

[x] Complete Mattermost Contributor Agreement
[x] Execute npm run prettify to format codes
[x] Write about environment which you tested

Operating system: OS X 10.11.6

For #229. Ctrl/CMD+F puts cursor in the search box and fill in:[channel_handle]  to filter with current channel.
This is not related to operating system, so only need testers.

Working as expected on win10 x64
Your missing the changelog part and deocumentation.
You might also want to squash this down to one commit, but totally optional.

Thanks, updated docs.
Artifacts for testing is available at https://circleci.com/gh/mattermost/desktop/603#artifacts

Does not put the cursor into the search field when I didn't click into the WebView after switching tabs or clicking somewhere into the Tab header.
However in:town-square  is being filled in still.

@jnugh Thank you for testing! The problem should be tracked at #231 as jasonblais referenced.


Change response header to request header for content type

I'll be making a PR for the #3, but the test uses default case if specified fails due to the before_send_callback uses get_resp_header instead of get_req_header for content-type.

Coverage remained the same at 96.721% when pulling 6bf7925b07695c7f41dfd643490d7d3cb9782474 on iceniveth:master into 9f5011677827d98e2cedf976f4120132b719004c on sticksnleaves:master.

Please see https://github.com/malomohq/accent/issues/9#issuecomment-568802893.


qLoRA support

I tried adding Flash Attention into qLoRA, I receive the following error:
RuntimeError: FlashAttention only support fp16 and bf16 data type
Is it possible to add support for 4-bit qLoRA?

The related issue in qLoRA
https://github.com/artidoro/qlora/issues/221

My full stack trace:
Traceback (most recent call last):
  File "/home/eric/git/qlora/qlora.py", line 846, in <module>
    train()
  File "/home/eric/git/qlora/qlora.py", line 808, in train
    train_result = trainer.train()
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/trainer.py", line 1539, in train
    return inner_training_loop(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/trainer.py", line 1809, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/trainer.py", line 2654, in training_step
    loss = self.compute_loss(model, inputs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/trainer.py", line 2679, in compute_loss
    outputs = model(**inputs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/accelerate/utils/operations.py", line 581, in forward
    return model_forward(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/accelerate/utils/operations.py", line 569, in __call__
    return convert_to_fp32(self.model_forward(*args, **kwargs))
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 14, in decorate_autocast
    return func(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/peft/peft_model.py", line 922, in forward
    return self.base_model(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 806, in forward
    outputs = self.model(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 685, in forward
    layer_outputs = torch.utils.checkpoint.checkpoint(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 249, in checkpoint
    return CheckpointFunction.apply(function, preserve, *args)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/autograd/function.py", line 506, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 107, in forward
    outputs = run_function(*args)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 681, in custom_forward
    return module(*inputs, output_attentions, None)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 408, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/home/eric/git/qlora/patch_flash_attn.py", line 87, in forward
    output_unpad = flash_attn_varlen_qkvpacked_func(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/flash_attn/flash_attn_interface.py", line 408, in flash_attn_varlen_qkvpacked_func
    return FlashAttnVarlenQKVPackedFunc.apply(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/torch/autograd/function.py", line 506, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/flash_attn/flash_attn_interface.py", line 123, in forward
    out, q, k, v, out_padded, softmax_lse, S_dmask, rng_state = _flash_attn_varlen_forward(
  File "/home/eric/miniconda3/envs/qlora/lib/python3.10/site-packages/flash_attn/flash_attn_interface.py", line 52, in _flash_attn_varlen_forward
    out, q, k, v, out_padded, softmax_lse, S_dmask, rng_state = flash_attn_cuda.varlen_fwd(
RuntimeError: FlashAttention only support fp16 and bf16 data type

We're not planning to write custom kernel for 4-bit. Can you just cast the input (q, k, v) to fp16/bf16, call FlashAttention, then convert the output to whichever dtype?

Understood thank you

Understood thank you

hi, do you check the result of flash_attention 2 and qlora 4bit?
I use  flash_attn_func function to calculate the attention of GQA ,and i cast the input (q, k, v) to bf16. Durning the training process, the loss is healthy but the qlora adaper model file sames error. When I use the qlora adaper model file, the generatation result is error.
query_states, key_states, value_states = query_states.to(torch.bfloat16), key_states.to(torch.bfloat16), value_states.to(torch.bfloat16)
output = flash_attn_func(query_states, key_states, value_states, dropout_p=0.0, causal=True)
output = output.float()
output = output.contiguous().view(bsz, q_len, -1)


Add japanese translation for 0.20.0 release

Tested ACK 95b1d9214b5f24c0baae9bf3dde3a06c8935f49d (using Google Translate).  Thanks!


infinite loop for one rare image

So I've been using your efficient lib to extract the exif of some 6 billion images
and of course there were 2 images among them that couldn't simply work!
https://mls-east.iqcdn.net/mls_midtennessee/images/2119991/2119991_00.jpg here it is
import exifread
exifread.process_file(open("evil_image.jpg", "rb"), details=False)

results in an infinite loop
I'm trying to identify what could be causing it. Will PR if I do
Happens both with the last version released (2.3.2 and master)

investigation comment:
getting stuck at list_ifd there https://github.com/ianare/exif-py/blob/2e95262b7cb55e1b1a871036039e995c042f8f5b/exifread/classes.py#L131
when I print i there, I'm getting this:
295
72
8
295
72
8

it seems there's a cycle of ifd in that file


Issue with streamlit 1.14.0

Hi,
Great work on the library, but when using it, I get an exception :
AttributeError: module 'streamlit' has no attribute 'rerun'
I guess it's due to the fact that the argument got deleted in 1.14
Maybe I'm wrong and this is just a rookie's mistake also, I don't know :)
Thanks for the support in advance,
Youssef

Hi, thanks, you need to upgrade your Streamlit version. The rerun method was introduced later (it used to be experimental for a while). See docs here - https://docs.streamlit.io/library/api-reference/control-flow/st.rerun


Initial Docs Setup

Description of Change
This PR brings in a GitHub Pages hosted documentation site using DocFX.
#121 has a discussion about possible solutions, this is just a temporary measure until the docs can be added to the official MS site like Essentials but being that this is using the same technology it could mean minimal effort to transfer over but allows for proper documentation to be written whilst there is on-going development.
The workflow yml shows the Actions being used.
One manual step to make, if merged, is you need to toggle:
Settings | GitHub Pages | Source to master branch then to gh-pages branch for the first build to trigger then subsequent pushes work fine.
You can see an example on my fork here.

Awesome work @AlexHedley ! Thank you so much :D
I'm not entirely familiar with GH Pages, and I think you mention it, but the branch switch is just once right?

@jfversluis yes, just the once or it doesn’t trigger the initial release of the website unfortunately, but then new pushes will update fine

Hi @AlexHedley, I want to generate the docs for the Behaviors PR #126 so it is available whenever it is merged.  Can I follow the instructions on the DocFX site to generate the docs?  Or is there a better tutorial somewhere else?  Thanks.

Hi @SunnyMukherjee
The DocFX site is what I used to produce this,
I guess it depends, if this PR is completed first you could then pull that into yours.
If you create a new docs site in your branch you’d need to copy over this one to stop MCs and get all my config
You could add just a single markdown file with some Doco in it then when both are merged a maintainer could move it over,
I’m not sure the best way to handle multiple forks atm

I would hold of on doing too much work here right now. As much as I appreciate the effort, we probably get more news about hosting our documentation on the Docs pages this week. Let’s wait for that a little to decide the right course of action and see if we can still use something from this PR

Hi @SunnyMukherjee
The DocFX site is what I used to produce this,
I guess it depends, if this PR is completed first you could then pull that into yours.
If you create a new docs site in your branch you’d need to copy over this one to stop MCs and get all my config
You could add just a single markdown file with some Doco in it then when both are merged a maintainer could move it over,
I’m not sure the best way to handle multiple forks atm

I read through their site.  I thought it was a matter of adding their NuGet package and it would generate the documentation in a docs folder using the comments in our classes.  It sounds like what you have done in your PR and you are describing is different than what I understand.  I may have used DocFX or something similar a long time ago, but I guess I need to understand your approach to be on the same page.

@SunnyMukherjee there’s two parts to the documentation.
One is the API side which is auto generated, just add good xml docs to your classes etc.
The other side it the hand written Articles which you write in Markdown i.e. example of how to use your behaviours with images, notes etc

I think all this moved to the Docs repo now, so we can close this here


Plugin Compatibility with Economy++

Are the rewards compatible with the Economy++ plugin? Just so i can keep the same economy going.

Money rewards are issued through Vault, so you should check whether Economy++ is supported by Vault (or vice versa).


Final Fantasy XIII Trilogy (2014/2015)

Describe the bug

All Final Fantasy XIII games hang without even creating a window, All FF13 ports use DX 9.0c
.0.2
RTX 4070
536.23
Steam

Attach logs!
NvRemixBridge.log
d3d9.log
ffxiiiimg_d3d9.log
To Reproduce
Steps to reproduce the behavior:

Obtain FF13 or similar game in the franchise
Place RTX Remix files in white_data/prog/win/bin/ or Alba_data/prog/win/bin for Final Fantasy XIII-2 or the root directory of the game for Lightning Returns.
3.Open ffxiiiimg.exe

Expected behavior
A clear and concise description of what you expected to happen.
Final Fantasy XIII would open and display some graphics.  All three games open with a Bink based FMV sequence
Using Vanilla DXVK in the config does not change this at all

I'm pretty sure FFXIII is much too recent for RTX Remix to work. Games released after 2006 have a pretty slim chance of working with RTX Remix at all.

it is a dx9 game so it's worth having listed anyway.

Portal came out in in late 2007. NVIDIA literally released Remix for a game that came out after 2006.

REMIX-2484 for tracking.

It seems like progress is being made with the 0.5 release, NvBridge errors with 0xc0000005 exception in the memory dump
d3d9.log
ffxiiiimg_d3d9.log
NvRemixBridge.log


⬆ Chat-UI > Recall previous chats by default by pressing ⬆

❔ About
Currently, when, on  a chatApp, we want to replay the previous command(s), we need to copy/paste it from the history... or at least this is the default behaviour.
👉 The purpose of this issue is to enhance DEVEX so 🦥 are happy 🤣
💡 Feature request
By default, when using the chatApp :

[ ] Add the copy/paste icon/button so we just have to click to get it (instead of actualy having to select it with the mouse)
[ ] In the chat input, when the ⬆ is pressed, browse previous input and select the currently chosen by hitting ↵

Nice. Those are good suggestions. I think we will end up with a copy paste for code snippets in the markdown, but we'll see if it is feasible to add copy and paste for the whole markdown. Mainly an API consideration.
We likely won't be able to handle the up arrow key to browse previous inputs. But I do agree that it would be nice to have.
We are planning to make a much fancier chat component (https://github.com/google/mesop/issues/712), so we may add that feature to that fancier chat component once we get to it.


Backward compatibility fix

Hi @BarredEwe I didn't notice it. Next time please also send an email to me.


Using primary/accent colors at different levels

Several components have a color prop on them, which can be 'inherit' | 'primary' | 'accent' | 'default'. This works fine out of the box most of the time, but when dealing with primary or accent there's also the possibility of wanting to use a particular level (50, 100, 200, etc.) As I understand it, the standard way to do this currently is something like
const colorIndex = 200;

const MyComponent = withStyles(theme => ({
  colorAccent: {
    backgroundColor: theme.palette.secondary[colorIndex],
    color: theme.palette.getContrastText(theme.palette.secondary[colorIndex]),
  },
})(({ classes }) =>
  <AppBar position="static" color="accent" classes={classes}>
    ...
  </AppBar>
);

This obviously offers unlimited power, but for something I find myself wanting to do with some regularity it's not very convenient. It'd be nice if this could be accomplished by something as simple as
const MyComponent = () => (
  <AppBar position="static" color="accent" colorIndex={200}>
    ...
  </AppBar>
);

It seems like this might require #7633 to implement practically.

It's also related to https://github.com/callemall/material-ui/issues/8717.

@yzorg yep, I’d say so


handle encoded equal sign in value

BTW I'm looking through the qson code and like it less and less as I go through it -- it's a good PoC, but some things are janky. If one day we find a better library we should switch over :slightly_smiling_face: (though I remember looking extensively and not finding stuff)


fixed undefined reference to _write on Teensy31 boards

This PR is related to this issue https://github.com/micro-ROS/micro_ros_arduino/pull/388 but to fix Teensy 3.1 boards instead.

@mergify main foxy

@mergify backport main foxy


docs(dev-guide): update migrate guide

What's Changed in this PR
Provides the guide to migrate from old version.
Checklist

[x] Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
[ ] This change requires follow-up update in localized docs.

LGTM for the wording parts. Please take a look at technical parts @killme2008 @shuiyisong


java error when trying to runany iepy command

(scipyla)jmansilla@altair:~$ iepy -h
Traceback (most recent call last):
  File "/home/jmansilla/.virtualenvs/scipyla/bin/iepy", line 9, in <module>
    load_entry_point('iepy==0.9.4', 'console_scripts', 'iepy')()
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/pkg_resources/__init__.py", line 521, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2632, in load_entry_point
    return ep.load()
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2312, in load
    return self.resolve()
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2318, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/iepy/instantiation/command_line.py", line 27, in <module>
    from iepy.preprocess.corenlp import download as download_corenlp
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/iepy/preprocess/corenlp.py", line 28, in <module>
    JAVA_VERSION = detect_java_version()
  File "/home/jmansilla/.virtualenvs/scipyla/lib/python3.4/site-packages/iepy/preprocess/corenlp.py", line 25, in detect_java_version
    return int(jversion.strip())
ValueError: invalid literal for int() with base 10: b'Picked up JAVA_TOOL_OPTIONS: -javaagent:/usr/share/java/jayatanaag.jar \n8'

(limo) limo@limo-ubuntu:~/limo$ iepy -h
Traceback (most recent call last):
File "/home/limo/limo/bin/iepy", line 9, in
load_entry_point('iepy==0.9.4', 'console_scripts', 'iepy')()
File "/home/limo/limo/lib/python3.4/site-packages/pkg_resources/init.py", line 521, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/home/limo/limo/lib/python3.4/site-packages/pkg_resources/init.py", line 2632, in load_entry_point
return ep.load()
File "/home/limo/limo/lib/python3.4/site-packages/pkg_resources/init.py", line 2312, in load
return self.resolve()
File "/home/limo/limo/lib/python3.4/site-packages/pkg_resources/init.py", line 2318, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/home/limo/limo/lib/python3.4/site-packages/iepy/instantiation/command_line.py", line 27, in
from iepy.preprocess.corenlp import download as download_corenlp
File "/home/limo/limo/lib/python3.4/site-packages/iepy/preprocess/corenlp.py", line 28, in
JAVA_VERSION = detect_java_version()
File "/home/limo/limo/lib/python3.4/site-packages/iepy/preprocess/corenlp.py", line 25, in detect_java_version
return int(jversion.strip())
ValueError: invalid literal for int() with base 10: b'Picked up JAVA_TOOL_OPTIONS: -javaagent:/usr/share/java/jayatanaag.jar \n7'
Also having this issue


feat(checkout) CHECKOUT-6236 Update Translations

What?
Update checkout-js translations based on the lastest files(21 Jan, 2022) from the translation team.
File: https://jira.bigcommerce.com/browse/LOCAL-917?focusedCommentId=1108346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1108346
Why?
This includes new messages like tax service provider unavailable.
Testing / Proof
Replacing language packages only. No code change.

Hello, @clopezh. I noticed that the new translations from the translation team might conflict with your recent updates. Could you please take a look?


chore: set reachabilityOverridePublic build flag in docker image

Checklist

[ ] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Way to use build flag when creating docker image:
docker build --build-arg REACHABILITY_OVERRIDE_PUBLIC=true -t bee-image-name -f Dockerfile .

If we needed to support other flags defined in the makefile here as well, we would end up maintaining variables in 2 places.
Would it work if we exposed the variable in the makefile to the environment so that the value can be passed to make?
makefile
export REACHABILITY_OVERRIDE_PUBLIC ?= false

Then use it with the build arg as you suggested

If we needed to support other flags defined in the makefile here as well, we would end up maintaining variables in 2 places. Would it work if we exposed the variable in the makefile to the environment so that the value can be passed to make?
makefile
export REACHABILITY_OVERRIDE_PUBLIC ?= false

Then use it with the build arg as you suggested

we could add this to Makefile:
# Load .env if it exists
ifneq (,$(wildcard ./.env))
	include .env
	export
endif

And if we locally have .env file with the specific flag set to the value. Then no other changes or maintinance is needed.
Another way would be that we have a new target in Makefile that will be responsibile for building the image itself:
docker-build:
	docker build -t $(IMAGE) . --no-cache

And this is example how it can be used:
make docker-build REACHABILITY_OVERRIDE_PUBLIC=true IMAGE=ethersphere/bee:latest

Another way would be that we have a new target in Makefile that will be responsibile for building the image itself:

I would vote on this option.
having .env variable is error prone between builds.

Another way would be that we have a new target in Makefile that will be responsibile for building the image itself:

I would vote on this option.
having .env variable is error prone between builds.

@acha-bill @nugaon
Proposed solution will not work without .env file.
The only idea I have now is back to build arguments.
@darkobas2 do you have any other better idea?

As binding an app inside a docker container to <IP_ADDRESS> has very limited use or use cases i would suggest we always build docker with :1633 with the existing way to override the api port host

Default Values:

REACHABILITY_OVERRIDE_PUBLIC: false (default)
BATCHFACTOR_OVERRIDE_PUBLIC: 5 (default)
IMAGE: ethersphere/bee:latest (default Docker image tag)

How to Use:

To build the Docker image using default values: Simply run:
make docker-build

To override the default values:
make docker-build REACHABILITY_OVERRIDE_PUBLIC=true BATCHFACTOR_OVERRIDE_PUBLIC=2 IMAGE=ethersphere/bee:v1.0


Changeling metashield

About the PR
Adds changeling in metashield rules
:cl:

tweak: Updated Metashield rule for changeling

Summary by CodeRabbit

New Features

Introduced a new section on "Changelings" in the roleplay rules, clarifying their shielded nature and interaction guidelines for players.
Specified conditions under which players may gain knowledge about Changelings, including their abilities and behaviors.

We don't have metashield rules because theyre nigh impossible to enforce in LRP. This would fit in MRP more.

We don't have metashield rules because theyre nigh impossible to enforce in LRP. This would fit in MRP more.

wdym, we have wizden metashield rule in game 😱

Admin review period will be over in two days (only posted it yesterday, sorry)


Upgrade to ScanCode 3.x

@pombredanne, any hints about what would be a good 3.x version to switch to? Is 3.0.2 already expected to be reasonably stable, or should we wait for another imminent patch release?

In general and here in particular tags are as stable as it gets. So you can go with 3.0.2 alright. There will be more releases pretty soon anyway. But that's always the case, so it is likely best to jump on the 3.x bandwagon sooner than later


Added quick start guide for produce and consume in rhoas cli

Technically looks on. Couple typos that can be fixed after merge. Draft true would allow us to merge it jnow

Updated to be a draft 👍


How to create multiple events?

The problem
Website Agent receives a JSON object in data_from_event mode like this:
{
  "items": [
    {"name": "item1"},
    {"name": "item2"},
    {"name": "item3"}
  ]
}

I configure the extract mode like this:
"extract": {
  "event": {
    "path": "items"
  }
}

Actual output
1 event has been created:
{
  "event": [
    {"name": "item1"},
    {"name": "item2"},
    {"name": "item3"},
  ]
}

Expected output
3 events have been created:
{
  "event": {"name": "item1"}
}

{
  "event": {"name": "item2"}
}

{
  "event": {"name": "item3"}
}

Is it possible to achieve that? So I would like to create multiple output events from a single incoming event.
I'm happy to switch to a different agent if needed, but I think this is the closest what I am trying to do.

Hi @elvetemedve,
yes that is possible with .items[*] it will retun everything inside the items array.

Hi @dsander,
It worked well. Thank you. :)
I think it would be useful to point this out in the agent description.


feat: add catch all routes

hey :wave:
this is my first contribution to a rust project.
Description
This PR introduces a catch-all route segment to the route definitions. The catch-all segment is defined as [...segment]  and allows for handling routes that haven't been matched by previous patterns.
i don t know how the actix server should behave when two catch-all-routes are defined
ex:

/[...segment_a].js
/[...segment_b].js
/[...segment]/other.js

but it is quite the same with dynamic params

/api/[id]/index.js
/api/[slot]/index.js

Testing

Added unit tests to ensure proper functionality of the catch-all route.
Verified that existing tests pass without regressions.

Checklist

[x] Code compiles and passes tests locally
[x] Unit tests cover the new functionality
[ ] Documentation is updated to reflect the new feature

It closes #199

hello @Angelmmiguel
i had some changes so that route /sub/[id] is better than route /[id]/sub
if you don't like it, i'll revert and fix the
 (Some(_), Some(_)) => return RouteAffinity::CanManage(i32::MAX - depth),

Thank you for the code review and the advices.
I've been rusting for a few weeks and I like it ;P
I'll try to be there tomorrow, if you have any other comments.

Sorry for that... Will fix it tonight

There is only one remaining linting issue.

Sorry again. You can fix it yourself if you want. Otherwise I'll do it late at night 😁

The only thing missing for this feature to be considered complete is to write docs at https://github.com/vmware-labs/wasm-workers-server/tree/main/docs.
I think is fine to address it on a separate PR.

@mtt-artis, again thanks for your contribution! And a very nice Rust contribution for being your first one on this language!
I have filed https://github.com/vmware-labs/wasm-workers-server/issues/213 too in case you also want to document this feature. I can take over on that if you prefer, as you wish :)

It's cool if you take over.
Thanks for helping me improve by reviewing this pr.


Angular CDN 404

The CDN's for Angular 1.5.4 and 1.5.5 return 404's:
https://ajax.googleapis.com/ajax/libs/angularjs/1.5.4/angular.min.js https://ajax.googleapis.com/ajax/libs/angularjs/1.5.5/angular.min.js

1.5.5 is up now.
There were some errors with 1.5.4, so we skipped it.

When is https://ajax.googleapis.com/ajax/libs/angularjs/1.5.6/angular.min.js available?

Soon (hopefully today)...


pass sort=True to df.append() to avoid warning

While running the script, I noticed that the sort warning popped up for the append() method. Link to pandas documentation mentioning the change.

@jgbarah please have a look

Thanks! It would be worth exploring if sort=False (which is less time-consuming) is also ok (I think it is, but I'm not completely sure). I would appreciate if you can have a look and find out.
But for now, I'm merging this, since it is better than the current situation ;-)

Thanks for the reply. I'll find out

So first I tested the append method directly by timing the creation of a Code_Changes object for different counts as shown below:
sort_true_times = list()
sort_false_times = list()

def time_test(sort):
    changes = Code_Changes('git-commits.json', sort)

for i in range(100):
    sort_true_times.append(timeit.timeit("time_test(True)", setup="from __main__ import time_test", number=i))
    sort_false_times.append(timeit.timeit("time_test(False)", setup="from __main__ import time_test", number=i))
    print(i, end=" >> ")

plt.plot(sort_true_times, 'r')
plt.plot(sort_false_times, 'b')
plt.show()

red -> sort=True
blue -> sort=False
The output:

Next, I checked for each class method, which were making use of self.df:
sort_true_times = list()
sort_false_times = list()

changes_true = Code_Changes('git-commits.json', True)
changes_false = Code_Changes('git-commits.json', False)

functions1 = [
                "changes_true.total_count()",
                "changes_true.count(since='2018-01-01', until='2018-07-01')",
                "changes_true.by_month()"
             ]

functions2 = [
                "changes_false.total_count()",
                "changes_false.count(since='2018-01-01', until='2018-07-01')",
                "changes_false.by_month()"
             ]

for i in range(3):
    sort_true_times.append(timeit.timeit(functions1[i], globals=globals(), number=500))
    sort_false_times.append(timeit.timeit(functions2[i], globals=globals(), number=500))
    print(i, end=" >> ")

plt.plot(sort_true_times, 'r')
plt.plot(sort_false_times, 'b')
plt.show()

The output:
0 -> total_count()
1 -> count(since='2018-01-01', until='2018-07-01')
2 -> by_month()
red -> sort=True
blue -> sort=False

Thanks for the detailed analysis!


Add Slurm to Orchestration & Management category

Pre-submission checklist:
As mentioned during Kubecon EU 2024 Keynote, Slurm + Kubernetes!
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

/cc @pritianka @caniszczyk

might as well ;)


Add ACPI Samples

Hi
I really like your work and I tested your kext and it's absolutely amazing!
In this PR I want to make things easier and simpler and add _OSI which prevents the ACPI from operating under any OS but macOS.
Also, I was so busy and forgot to add Including ACPI Samples feature inside the releases, can you please add it?
Thanks!

I'm not very fond of adding _OSI check to every SSDT. I don't think SSDT-PNLF will cause problems for Windows. WhateverGreen's SSDT-PNLF also doesn't include _OSI check, so I think we don't need to do so.
Also, I don't want to split SSDT-PNLF into multiple versions for different platforms. Are there any specific reasons to do that (apart from setting custom _UID)?

Hi, thanks for replying.
the point of this PR is to provide a short-and-light ACPI table that serves as yours, for me personally, not a fan of using DSDT when a couple of SSDTs can do the trick, you can add both each the single SSDT-PNLFs and the general SSDT-PNLF.
Regards

Not sure what you mean with "using DSDT".

Hi, I meant having a couple of SSDTs is better than having DSDT

SSDT-PNLF automatically detects the platform and inject the correct _UID. It doesn't do anything with DSDT.


Rebase release-4.14-azure from upstream/release-4.14

Rebased from the latest installer branch(https://github.com/openshift/installer/commits/release-4.14/) to include the recent rhcos change.
Files changed in the PR seems not the diff between release-4.14-azure HEAD and my branch HEAD. (probably the diff between the parent of d4cd653 and my branch HEAD).
Please use git diff to see the diff.

/lgtm


lightning(dm): ignore checkpoint error should using ExtStorage

Signed-off-by: lance6716<EMAIL_ADDRESS>
What problem does this PR solve?

Issue Number: ref #7114
What is changed and how it works?
in old code, (l *LightningLoader) ignoreCheckpointError forget to use engine's injected S3 to cleanup checkpoint
Check List
Tests

Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/cc @D3Hunter @okJiang

but the progress becomes 0% 😂

    "finished_unit_status": {
        "mysql-01": [
 ...
            {
                "Unit": "DMLoadTask",
                "Task": "mysql-01",
                "Stage": "Finished",
                "CfgModRevision": 0,
                "StageUpdatedTime": "2022-11-24T05:20:55.336177527Z",
                "Result": {},
                "Status": {
                    "totalBytes": 614,
                    "progress": "0.00 %"
                },
                "Duration":<PHONE_NUMBER>0
            }
        ]

Codecov Report

Merging #7702 (88b0f41) into master (6d24a57) will decrease coverage by 0.0386%.
The diff coverage is 47.6190%.

Additional details and impacted files

Flag
Coverage Δ

engine
64.0047% <ø> (+0.0078%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7702        +/-   ##
================================================
- Coverage   59.9034%   59.8648%   -0.0386%
================================================
  Files           810        810
  Lines         93255      93260         +5
================================================
- Hits          55863      55830        -33
- Misses        32535      32567        +32
- Partials       4857       4863         +6

/merge

/run-engine-integration-test


New release schedule?

I'd like to make use of #45 in our project; would you please make a new release sometime soon? Thanks!

Done!


[Docs]: Add installation

I don't know if this is the best installation guide, but this is what makes sense to me.
And linking to a third party isn't that easy either since gdscript is mainly intended to work with the editor.
So I had to come up with my own "workaround" to get it to work as more of a ci application.
I am open to suggestions for improvements.

@pfertyk, I think we need a rebase here to make configlet CI happy, and then we can iterate on these docs more as needed.


Changed spark-api project name to source{d} engine in documentation

As first step to renaming, only those references to spark-api in documentation that don't brake links or commands have been changed to source{d} engine

Related to https://github.com/src-d/spark-api/issues/66

Changes in links and code examples have been changed based on https://github.com/src-d/spark-api/pull/111
For links and jitpack coordinates I supposed the project namespace will be github.com/src-d/engine instead of github.com/src-d/spark-api

Jupyter notebook has been updated to include an UAST extraction example and use the renaming module sourced.engine

MORE CHANGES

Updated notebook and examples to be aligned with the last api changes
Added examples of the new XPath query feature

@mcarmonaa 9033f80 fixes line number 31 for spark but line 17 for pyspark is still there

@bzz solved

Great job @mcarmonaa !
One thing I have noticed, while going though all https://github.com/mcarmonaa/spark-api/blob/fix/doc-project-name/_examples/scala/ - is that it's very annoying not to be able to copy the full commands from the docs.
I.e if https://github.com/mcarmonaa/spark-api/blob/fix/doc-project-name/_examples/scala/spark-shell-xpath-query.md#querying-uasts-with-xpath-example we have
$ spark-shell --packages com.github.src-d:engine:master-SNAPSHOT --repositories https://jitpack.io
scala> import tech.sourced.engine._
import tech.sourced.engine._

scala> val engine = Engine(spark, "/path/to/siva-files")
engine: tech.sourced.engine.Engine = tech.sourced.engine.Engine@7e18b9e6

engine.getRepositories.getHEAD.getFiles.classifyLanguages.where('lang === "Python").extractUASTs.queryUAST("//*[@roleIdentifier]", "uast", "result").extractTokens("result", "tokens").select('path, 'lang, 'uast, 'tokens).show
+--------------------+------+-------------+--------------------+
|                path|  lang|         uast|              tokens|
+--------------------+------+-------------+--------------------+
...

but if that would have been
$ spark-shell --packages com.github.src-d:engine:master-SNAPSHOT --repositories https://jitpack.io

import tech.sourced.engine._
val engine = Engine(spark, "/path/to/siva-files")
engine.getRepositories.getHEAD.getFiles.classifyLanguages.where('lang === "Python").extractUASTs.queryUAST("//*[@roleIdentifier]", "uast", "result").extractTokens("result", "tokens").select('path, 'lang, 'uast, 'tokens).show

it would have next advantages:

look better due to syntax hightligh
be copy-able for a user

What do you guys think?

#111 has been merged, we can merge this as soon as it's ready

LAST CHANGES

Fixed some wrong words.
The examples have been changed to follow @bzz suggestions.

Python build fails for latest changes. Also, can you rebase? There were massive changes with the renaming  in the code

Looks great, thank you @mcarmonaa !
LGTM sans minor issue from above


Fix prompt detection in runme.expect (I think)

I confess that I am just myself learning expect (it seemed like a good idea at the time), but from what I can understand (see, e.g. the expect manual, paragraph beginning with "Both types of patterns are "unanchored"."  http://www.tcl.tk/man/expect5.31/expect.1.html), ^ is the start of the buffer being scanned by expect.
The patterns in runme try very hard to always consume always exactly an entire line, since the host OS may occasionally dump several into a read() done by expect.

Ah, it seems like you are right. I don't fully understand why expect tests the buffer like that (and don't have time to now to research, since we're at T-14:20:00 until submission time), but merging this doesn't break anything, so I'll go ahead and do it.
Thanks :)


TypeError: Handler is undefined

It runs through this method about 5 times with a handler, and then it is invoked without one:

Called from here:

Moved to rails/rails


Image URLs are only allowed for messages with role 'user', but this message with role 'assistant' contains an image URL.

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
Hello,
I have a very simple process that I think used to work with GPT-4 turbo, or a previous version of this library, but that no longer works because of a rule in the nodejs lib.
Everything happens in the same chat:

I create a chat in my chatbot app
I make Dalle 3 generate an image
I ask a question to GPT-4mini, I get the error:

handleLLMError 400 Invalid 'messages[2]'. Image URLs are only allowed for messages with role 'user', but this message with role 'assistant' contains an image URL.
passing this message array:
[
  {
    "role": "user",
    "content": "Draw a cat"
  },
  {
    "role": "assistant",
    "content": [
      {
        "type": "image_url",
        "image_url": {
          "url": "[URL of generated image stored somewhere]"
        }
      }
    ]
  },
  {
    "role": "user",
    "content": "Describe this image"
  }
]

I don't think it's logical not to be able to describe the image generated by Dalle 3 in GPT-4o. What do you think?
To Reproduce
Everything happens in the same chat:

I create a chat in my chatbot app
I make Dalle 3 generate an image
I ask a question to GPT-4mini, I get the error:

handleLLMError 400 Invalid 'messages[2]'. Image URLs are only allowed for messages with role 'user', but this message with role 'assistant' contains an image URL.
Code snippets
No response
OS
macOS
Node version
node 21
Library version
openai 4.57.0

Thanks for reporting!
This sounds like an issue with the underlying OpenAI API and not the SDK, so I'm going to go ahead and close this issue.
Would you mind reposting at community.openai.com?


Errors Encountered Following ReadMe

For context, I am new at anything tech/coding-related. I tried to follow your ReadMe instructions but I kept on encountering errors:

On Step 2 Create Collections, it kept on returning an error message that showed the username, password, and host were not given even though I already added that to the .env file. What I did was I added an import os, from dotenv import load_dotenv, and load_dotenv() lines on the cli/admin.py file and it worked. -> Was what I did wrong? How should I have addressed the issues instead?

On Step 3 Launching the API, when I run uvicorn src.whyhow_api.main:app I get this error:

Hey @ttuvera1125, looks like the script is not able to access the environment variables. Can you confirm that you copied .env.sample to .env? Also, depending on where you're running this code, you may need to restart your terminal/IDE for the .env changes to propagate. (This sometimes happen to those who run using the terminal in VS code). Hope that helps.

We also just pushed a new version of the src/whyhow_api/cli/admin.py script. Could you pull the latest and create the db + collections + indexes using this new script. Thx!

Hey @ttuvera1125, looks like the script is not able to access the environment variables. Can you confirm that you copied .env.sample to .env? Also, depending on where you're running this code, you may need to restart your terminal/IDE for the .env changes to propagate. (This sometimes happen to those who run using the terminal in VS code). Hope that helps.

Hi @recchris yep, I did copy the .env.sample to .env. I also restarted my terminal, VS Code, and re-tried running python admin.py setup-collections --config-file collection_index_config.json but I still get a ValueError: 'username', 'password', and 'host' must be supplied.

Hey @ttuvera1125, you might find this comment thread helpful from our Discord...someone had a similar issue - https://discord.com/channels/1218729941982646272/1218731001056989214/1313574010646302761. If you're continuing to run into issues, you might just try hardcoding the values directly into the config.py just to see if you can get it working.
Please also try deleting and re-installing with the newer version we pushed on Friday. Thx!


hr tag is different in each sections

Proposal
Hey @Shruti3004,
(A clear and concise description of what the proposal is.)
hr tag ( underlined content) border is different in each section. Please assign this to me to make it even in all sections

Go ahead @archanagandhi


python3Packages.python-izone: 1.1.5 -> 1.1.6

Motivation for this change
https://github.com/Swamp-Ig/pizone/releases/tag/v1.1.6
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128260 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.python-izone
python39Packages.python-izone


docs to reflect the code

Coverage remained the same at 97.06% when pulling 088b47b1c0b91186881d8106579f4cf9786af56a on opyate:patch-1 into ca5c6d2c6d780fd3c61c88cc35b0e26d1b56b40c on jpvanhal:master.

Coverage remained the same at 97.06% when pulling 088b47b1c0b91186881d8106579f4cf9786af56a on opyate:patch-1 into ca5c6d2c6d780fd3c61c88cc35b0e26d1b56b40c on jpvanhal:master.

Coverage remained the same at 97.06% when pulling 088b47b1c0b91186881d8106579f4cf9786af56a on opyate:patch-1 into ca5c6d2c6d780fd3c61c88cc35b0e26d1b56b40c on jpvanhal:master.

Thanks!


add parameter support for non inlined functions

Closes #21

Codecov Report

Merging #26 (648b029) into main (ad41cfc) will increase coverage by 6.85%.
The diff coverage is 67.64%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   40.20%   47.05%   +6.85%
==========================================
  Files          60       61       +1
  Lines        5323     5402      +79
==========================================
+ Hits         2140     2542     +402
+ Misses       3121     2739     -382
- Partials       62      121      +59


Test attribute setting on model

wip, don't merge

Is this still in progress, or is it okay to close @knownasilya?

I think you can merge this.

This test feels a little over broad for a unit test. I think we probably want to test that the Model class invokes setAttribute on the adapter (by stubbing out an adapter), rather than tying this test to the MemoryAdapter implementation.

Ah, yes good point.

Closing for lack of activity. Happy to reopen if anyone wants to pick up the ball here - more tests are always welcome!


Investigate why GA shows an unusually low bounce rate for August

We go from ~30% in the months prior to 1% in August. That can't be right. Most other metrics (pageviews, visitors, etc.) seem fine, though.
I suspect this may have something to do with GA event tracking or the feedback widget.
References: https://www.reddit.com/r/startups/comments/1ke8jg/my_bounce_rate_on_my_startup_website_went_from_40/
cc: @jess-edwards

Based on info here, I've set docs trackers to non-interactive hit = true. This means that the events should not be factored into bounce rate calculations at all. I'll monitor bounce rate over the next few days.

DivisionOf noticed that we had 2 GA scripts on docs pages, one put there explicitly, another added automatically via Google Tag Manager. They suggested I remove one. I did, and the bounce rate is now accurate again.


Example two_shocks.txt requests Riemann_1D, but should request Riemann.

The Riemann_1D requested by the "tests/1D/two_shocks.txt" tests file does not exist, and the file should request the "Riemann" ics instead.

Fixed! Thank you.


Enhance kettle gpload plugin to support unicode (non-printable ASCII …

Enhance kettle gpload plugin to support unicode(non-printable ASCII) delimiter
Use case of non-printable ASCII character delimiter is very common. however the current gpload plugin doesn't support unicode (non-printable ASCII character) delimiter correctly, this enhancement will fix it.
With this PR, unicode delimiter can be accepted in UI with prefix of \u , e,g, \u001b, as shown below:

Later on running the plugin will produce gpload control file having a unicode 'DELIMITER' field, quoted with double quote (instead of single quote on common printable delimiter), as shown below:

As GPLOAD command line utility usage stated below:

A produced sample gpload load0.data file (with ESC(\u001b) delimiter):

And the file shall be successfully imported into Greenplum database:

Test delimiter with the format $ [value] , e.g. $ [01], it doesn't work. the gpload control file do not produce.
There is error on console: "A delimiter must be specified"
Screen capture follow:

The environment substitute on '$[1b]' produce empty:


library design

currently _vroom_xx.so is installed in the root of site-packages while the python stuff is in site-packages/vroom. what do you think about taking it all into the vroom directory? a little bit cleaner IMO. then it's a relative import for the extension import ._vroom.
just bit me when pip didn't properly uninstall for whatever reason and I manually deleted vroom but didn't see the _vroom lib.

Yea, agrreed,å that is a good idea.
Either feel free to fix it yourself, or I'll get around to it later.


Pass original tap to formula when loaded from the API via TapLoader

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Fixes https://github.com/Homebrew/brew/issues/16213
Follow-up to https://github.com/Homebrew/brew/pull/16207
Supercedes https://github.com/Homebrew/brew/pull/16215
This PR fixes the TapLoader refactoring to properly pass the old tap to the newly created formula, even though it is referencing the new formula file. This is consistent with the old behavior. This also fixes the newly-created issue where migrating to a different non-core tap but with the same name as a core tap incorrectly chooses the core formula.
Finally, this PR adds some more tests.
CC @MikeMcQuaid, @Bo98, and @amancevice

formula_name_path not updating the updated tap is very likely an error I made in https://github.com/Homebrew/brew/commit/44f058edb514c0cb10deefe62397963a57a94334

very sporting of you @Rylan12 — cheers 🍻


Fix broken links in README.md

Hi,
thanks for making help in populating Django Framework! 🖤
I did go through README and found several broken links, this PR fixes them.
Also, PR applies comments from VS Code plugin, called markdownlint.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: amureki sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


pdf.js screws up openload

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Chrome Version 66.0.3348.0 (Official Build) canary (64-bit), also in Chrome Version 66.0.3343.3 (Official Build) dev (64-bit)
Operating system and its version: Win 10 x64
PDF.js version: 2.0.301
Is a browser extension: Yes

Steps to reproduce the problem:

Go to https://openload.co/f/eWCiP4gSM80/NBA-2018.02.14_MIA-PHI-2.torrent

What is the expected behavior? (add screenshot)
A screen to download a file should open

What went wrong? (add screenshot)
openload thinks there's an embedding violation

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

I can't reproduce this in Chromium 64.0.3282.167 on Linux. I installed the PDF Viewer and uBlock Origin (as seen in your screenshot), visited the page and clicked on the Free Download button (I also tried waiting before clicking).
What makes you believe that this issue is caused by PDF.js?

I'm on Chrome Version 66.0.3346.8 (Official Build) dev (64-bit), Win 10 x64.
PDF Viewer is the only extension.
Without it there's no problem with openload.
With it, the problem occurs.
PS
1.No need for uBlock Original
2.It's Win 10, not Unix
3.It's Chrome, not Chromium

@qwer1304 If I look at your screenshot, I clearly see that uBlock Origin is installed (and at least one other extension). Did you try to reproduce this bug without those other extensions enabled? Or similarly, can you reproduce the problem if you temporarily disable PDF.js's PDF Viewer?
Before testing, could you visit chrome://net-export to capture the network requests, and upon completion of the test stop the capture and mail it to me? Then I can check whether there is anything special going on.

I repeated the experiments with ONLY PDF Viewer installed and the results are as reported above.
Sent you two logs w/ and w/o

The above log entry does not indicate that PDF.js itself is blocking anything. It merely shows that PDF.js was at some point notified of a request, and that the request handling was blocked until the PDF viewer extension returned.
I've managed to reproduce the issue in Chrome on Windows 10, and found a specific snippet in the page that is responsible for the behavior you're observing. Deobfuscated, the snippet is:
function isSandboxed(_0x7089x2) {
    try {
        if (window.frameElement.hasAttribute("sandbox")) {
            _0x7089x2();
            return
        }
    } catch (err) {};
    if (location.href.indexOf("data") != 0 && document.domain == "") {
        _0x7089x2();
        return
    };
    if (typeof navigator.plugins != "undefined" && typeof navigator.plugins.namedItem != "undefined" && navigator.plugins.namedItem("Chrome PDF Viewer") != null) {
        var _0x7089x3 = document.createElement("object");
        _0x7089x3.onerror = function() {
            _0x7089x2()
        };
        _0x7089x3.setAttribute("type", "application/pdf");
        _0x7089x3.setAttribute("style", "visibility:hidden;width:0;height:0;position:absolute;top:-99px;");
        _0x7089x3.setAttribute("data", "data:application/pdf;base64,JVBERi0xLg0KdHJhaWxlcjw8L1Jvb3Q8PC9QYWdlczw8L0tpZHNbPDwvTWVkaWFCb3hbMCAwIDMgM10+Pl0+Pj4+Pj4=");
        document.body.appendChild(_0x7089x3);
        setTimeout(function() {
            _0x7089x3.parentElement.removeChild(_0x7089x3)
        }, 150)
    }
}
isSandboxed(function() {
    location.href = "/embedblocked?referer=" + encodeURIComponent(document.referrer.substring(0, 150))
})

They are trying to detect whether the Chrome PDF Viewer plugin exists in the browser, and if so, they try to load the plugin and see if an error event is dispatched (and if so, assume that the embed is blocked).
As a side effect of how embedded PDFs are detected in PDF.js, the "error" event is triggered when PDF.js renders the viewer in <object> elements, and there is no good way to prevent the "error" event from triggering.
I'm closing this bug since I currently don't plan to add a work-around to support this website, but I will follow up by mail so you can use the site again.

Could you add a workaround for this? Or at least disable PDF.js from loading on openload.co?


Namespace nesting in precompiled function

When using C# precompiled azure functions there seems to be some issues around namespace resolution. eg.
namespace AcuteCompiled.Nested
{
    public class NameFunction
    {
        public static async Task<HttpResponseMessage> Run(HttpRequestMessage req)
        {

If I namespace my precompiled function as above, I would expect that my function.json should read:
"entryPoint": "AcuteCompiled.Nested.NameFunction.Run"

However, this results in the following error:
Error:

Function ($NameFunction) Error: The function type name 'AcuteCompiled.Nested.NameFunction' is invalid.

However, if I incorrectly ignore the namespace and reference it as:
"entryPoint": "AcuteCompiled.NameFunction.Run"

It works!
I haven't tested further (I've already burned enough time) but it looks like it resolves on three parts as such:
{AssemblyName}.{ClassName}.{MethodName}

I think better namespace support would be very useful as projects expand and code organization becomes more important.

Apologies, I think this is because I wasn't restarting the app when I deployed a new version of my .dll. I assume it is cached somehow at app start and when I was moving files around I was getting unexpected results.

@sburman that is indeed the behavior, but with the next drop, the functions runtime will detect assembly file changes and restart in order to pick up those changes (similar to the behavior you'd experience with a standard ASP .NET application). Assembly locking issues, if you were running into them, should be addressed as well.

@fabiocav, this is great news regarding the upcoming changes.
While I am here, is there a gitter or similar for this project? There is a lot of unknowns/uncertainty at the moment and it would be great for there to be a comm channel with friendly ears.

We don't have a real time channel, but that might not be a bad idea. We do try to be very responsive here, on SO and MSDN Forums, though.

I am getting the same error and have restarted the Function app several times. Any other ideas?


WIP CocoaUI for DPF (take 2)

Current output of auval:
VERIFYING CUSTOM UI
Carbon View Components Available: 0

GetPropertyInfo asked for CocoaUI
GetPropertyInfo asked for CocoaUI
GetProperty asked for CocoaUI
ERROR: Cocoa Views Information cannot be retrieved

Install path for PLUGIN_DSP.component -> /Library/Audio/Plug-Ins/Components
Install path for PLUGIN_UI.bundle -> $(HOME)/Library/Bundles

Above force-pushed commit detects the UI correctly

The reason that the above failed CI is because DSSI UI was attempted to be built with direct access enabled.
# error DSSI UIs do not support direct access!


fine tune

Hello, is it possible (will it be) to fine tune with peft lora and quantization?

Finetune code for MiniCPM-V 1.0 is available in swift  .


[ZEPPELIN-846] Fix Long Notebook Dropdown

What is this PR for?
This PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu.
Reason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus.
In term of dropdown layout, I think we have 2 options:

The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu.
The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus)

Reworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best.
What type of PR is it?
Hot Fix
Todos

[ ] - Rebase & Double Check the filtering and Notebook ordering after #1066

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-846
How should this be tested?
Just play with the folder structure and check the notebook dropdown
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@corneadoug Awesome! I tested and it works really well 👍

@corneadoug Tested and works well. Further work doesn't need to be addressed in this PR I think.
By the way, CI build is failing with error
INFO] src/components/expandCollapse/expandCollapse.directive.js
[INFO]   line 16  col 3   Missing "use strict" statement.
[INFO]   line 20  col 55  Strings must use singlequote.
[INFO]   line 21  col 54  Strings must use singlequote.
[INFO]   line 22  col 52  Strings must use singlequote.
[INFO]   line 24  col 46  Strings must use singlequote.
[INFO]   line 25  col 38  Strings must use singlequote.
[INFO]   line 31  col 10  Missing semicolon.
[INFO]   line 19  col 13  '$' is not defined.
[INFO]   line 20  col 18  '$' is not defined.
[INFO]   line 21  col 17  '$' is not defined.
[INFO]   line 22  col 17  '$' is not defined.
[INFO]   line 24  col 17  '$' is not defined.
[INFO]   line 25  col 19  '$' is not defined.
[INFO]
[INFO] ✖ 13 problems

@Leemoonsoo Just fixed that and a few HTML problems when minified.
Jshint didn't run during dev mode which is a bit fishy.

@corneadoug Can you rebase please?

@minahlee Rebased and ready

Awesome!! Works like a charm. Merge if there is no more discussion


Stacked Popups via Router

I have multiple popups defined via routes. One popup is opening another. They show up correctly and stack well. But when closing via popup-close attributed link, only the second click has an effect and closes both.
Video:  https://holtwick.de/download/20190805-214052-popup-stack.mp4
Console says: Error: Framework7: it is not allowed to use router methods on global app router. Use router methods only on related View, e.g. app.views.main.router.back(...)
Routes:
{
      path: '/settings/',
      popup: {
        component: iosSettings,
      },
    },
    {
      path: '/sync/icloud',
      popup: {
        component: iosICloud,
      },
    },

Template:
<template>
  <f7-popup>
    <f7-view
      :push-state="false"
      :master-detail-breakpoint="0"
    >
      <f7-page>
        <f7-navbar>
          <f7-nav-left>
            <f7-link popup-close
                     icon-ios="f7:close"
                     icon-md="f7:close">
            </f7-link>
          </f7-nav-left>
          <f7-nav-title>Apple Cloud</f7-nav-title>
        </f7-navbar>

        <icloud></icloud>
      </f7-page>
    </f7-view>
  </f7-popup>
</template>

Well, actually all correct :) With first click it closes underlying popup and with second one current one. Just make popup-close link more specific, e.g. add popup-1 and popup-2 classes to Popups, and use the following on links: <f7-link popup-close=".popup-1" ...> and <f7-link popup-close=".popup-2" ...>

Ah great! Thanks. That works much better. Even in Vue I can programmatically do this now:
this.$f7.close('.popup-1')


More info-level logging for CLI

display of internal uploader command, scheduler command under info mode. Also consider improve ShellUtils.

related https://github.com/twitter/heron/issues/1588


Feature/1427 notifications unsubscribe

What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):
update User's model to have a notification preference field, as discussed in #1427

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[ ] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[x] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

@ddveloper @mannykary do I merge this with feature/1637-notifications-web-backend? or it's still WIP?

@ddveloper @mannykary do I merge this with feature/1637-notifications-web-backend? or it's still WIP?

Yes @Zaydme please merge it


ICMP firewall rules always modified

When deploying a firewall ruleset that has two ICMP rules the following changes are always recorded, meaning that the deploy isn't idempotent and we submit unnecessary changes:
I, [2014-12-15T10:48:05.108600 #10137]  INFO -- : Updating EdgeGateway d627d7c2-8e48-438e-9f77-98a7fb164ee9
- FirewallService.FirewallRule[39].IcmpSubType: any
- FirewallService.FirewallRule[63].IcmpSubType: any

I believe this may happen because the rules move position when they are configured (though I don't have any actual proof :neutral_face: ). I might see if it could be fixed by specifically ordering the ICMP rules at the top of the rule which I think can be specified using the rule Id as per https://github.com/fog/fog/blob/master/lib/fog/vcloud_director/generators/compute/edge_gateway_service_configuration.rb#L214
Requires some investigation.

This tool is no longer in active use and the repository will be archived so we're closing this issue. Thank you for your interest and involvement in this project.


Move QUIL output to cirq-rigetti

Is your feature request related to a use case or problem? Please describe.
RIght now some of the functionality to output quil programs is intermixed with cirq-core. We have things like cirq/protocols/quil.py and cirq/contrib/quil.py and cirq/circuits/quil_output.py. There are also modules like these in cirq-rigetti as well.
Describe the solution you'd like
We should move all of the quil related functionality into cirq-rigetti
What is the urgency from your perspective for this issue? Is it blocking important work?
P2

Hi @MichaelBroughton, I'm Rishabh from India. Any RFC required for this issue/feature ?

Taking this.

Hey @erichulburd @kalzoo @dbanty. We are going to deprecate the quil protocol. This will come down to also removing all __quil__ implementations in order to replace it with a standalone method in cirq-rigetti. The standalone method will be in the same vein as quil_import except custom gates will not be supported.
Please let us know if you have any concerns.

@vtomole Thank you for the heads up. Let us know if you want any input on the preliminary migration.
Moving forward, if new features or breaking changes are made in Cirq, can we expect any support for the necessary updates to the new Quil exporter?

Is this a general approach towards language interoperability? I notice that cirq/protocols/qasm.py is also present in Cirq core. Why I ask: Quil is owned by the quil-lang organization, of which Rigetti is part; it just so happens that we are the only backend provider for the language, but it is not inherently coupled to Rigetti.

I notice that cirq/protocols/qasm.py is also present in Cirq core

I feel like OpenQasm is different from Quil in the amount of support it has. There is Qasm support in Pytket, Braket, Qiskit, q#... Even Quilc supports Qasm.  I think there is a push in industry and academia to have OpenQASM be an interop standard so it makes sense for us to support it natively.

Moving forward, if new features or breaking changes are made in Cirq, can we expect any support for the necessary updates to the new Quil exporter?

We want to make breaking changes before the 1.0 release; hence why we are doing this QUIL stuff now. Once they are moved to cirq-rigetti, we don't plan on adding new features or breaking stuff related to cirq-rigetti. We want to move all Rigetti-related code out of cirq-core before we won't be able to after the 1.0 release.

@vtomole How is this project going?  Cirq 1.0 is quickly approaching!  Do you need assistance on this task?

@dstrain115 Thanks for the ping! I have a local branch that removes the call to protocols.quil in class QuilOutput. I'll clean it up and open a draft PR before next week's sync and we can iterate on it.

Rough outline of the PRs I'll open:

Create a quil_output.py in cirq-rigetti that doesn't call off to the protocols.
Add deprecation messages to all the __quil__ methods and the quil protocol in cirq-core.
Move cirq.contrib.quil_import to cirq_rigetti. Won't deprecate this because it's in contrib.
Remove cirq.protocols.quil.py and cirq.circuits.quil_ouput.py once 0.15 is released.

The only part left is to remove the QUIL functionality off cirq-core; but this will be done during the 1.0 release. Will close this because the move has been done.


Export/backup Favorites

I would be great to be able export my save favorites to be able to restore at a later time.
Bonus: be able sen export/backup settings for the extension, as well.
thanks

Already done! The entire database is contained in a single directory<EMAIL_ADDRESS>Just make copies of that and you have your backup. Overwrite the directory and that's a restore.

Closing since there's no further action on my part.


BITE Tokenization and BERT fine-tuning Query

Thank you for sharing your insightful research work and implementation. While trying to understand the implementation, got stuck in one fundamental step. Let me explain it .
Below is the step BITE follows with Wordpiece tokenizer for the tokenization.
Input text --> Whitespace/punctuation based tokenizer --> Base Inflection Encoding --> Wordpiece Sub Tokenizer --> Integer IDs for tokens --> Model Training/Finetuning
In this process, we update the tokenizer vocab list with the new tokens based on the Inflection symbols(POS tags). Since these are completely new tokens for the tokenizer, the base model needs to learn all those syntax and semantics during the pre-training. And the first layer of the model(here, BERT base) is embedding layer, which has already a fixed dimension ( ~30K, 768) based on the initial pre-training. How does the BITE manage to incorporate new tokens while fine tuning tasks like SQuAD and MNLI .
According to me, we need to pre-train the model (here, BERT base) on the updated vocabs(which includes the Inflection symbols + Original BERT base Wordpiece vocabs) and then fine tune it on the specific tasks like SQuAD and MNLI. Please help me to clarify this confusion.
The Next one is below.
For example, the word  took would be tokenized as below.
took ---> BITE---> take + [VBD] ------> Wordpiece ---> [token ids]
In the above case, if the word take is again tokenized to different sub-tokens(for example, tak, ##e) by wordpiece(if the exact token is not available in wordpiece vocab list), How is it going to preserve the root(lemma) intact during the training.
Would appreciate  your comments.

According to me, we need to pre-train the model (here, BERT base) on the updated vocabs(which includes the Inflection symbols + Original BERT base Wordpiece vocabs) and then fine tune it on the specific tasks like SQuAD and MNLI. Please help me to clarify this confusion.

Since all parameters are updated during fine-tuning, we found fine-tuning to be enough for the model to adapt to the new tokens. It is possible that doing more pretraining with the new tokens would improve downstream performance further but it's not necessary to achieve a similar level of performance as the control.

In the above case, if the word take is again tokenized to different sub-tokens(for example, tak, ##e) by wordpiece(if the exact token is not available in wordpiece vocab list), How is it going to preserve the root(lemma) intact during the training

We do not need to ensure the lemma is a single token for improved robustness; we only need the lemmas of different inflected forms belonging to the same lexeme to be represented similarly. For example, using a hypothetical tokenization,
took -> take [VBD] -> [ta, ##ke, VBD]
taking -> take [VBG] -> [ta, ##ke, VBG]
take -> take -> [ta, ##ke]
as opposed to
took -> [too, ##k]
taking -> [ta, ##king]
take -> take -> [ta, ##ke]
You can easily see that the final wordpiece representations in the latter tokenization are all very different from each other, compared to the former (BITE).

Thank you for the response.
Since all parameters are updated during fine-tuning, we found fine-tuning to be enough for the model to adapt to the new tokens. It is possible that doing more pretraining with the new tokens would improve downstream performance further but it's not necessary to achieve a similar level of performance as the control.
So, with BITE + wordpiece, fine-tuning is done on specific tasks for all the parameters. After adding new tokens(POS tags) to wordpiece vocab list, the initial embedding layer must be changed to new count of tokens(~30k + POS tokens, 768) for fine-tuned BERT base model.This changes would be reflected in the config.json of the updated model. Is that correct understanding ?
Are these models available publicly for reference.

We did not add new tokens to the vocab but used some of the existing unused ones. The modified vocab for BERT-base can be found here: https://github.com/salesforce/bite/blob/master/src/bite/bert_base_wordpiece_vocab.txt

Thanks for the clarification.


Need fix, that display only build under Linux works.

We need a build configuration, where a Linux build without XCB and XLIB but with VK_KHR_display extension enabled is possible. Added pull request for SDK 1.0.21 (which can be dropped) and master branch:
Fix for 1.0.21:
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/893
Fix for master branch:
https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/925

I'd like to pick up this fix in the next day or so, but I would also like to add some tests to make sure that this doesn't break if someone modifies the cmake files again, since we don't test this config regularly.
Can you suggest a test that can be run on a Linux/X machine to test this build config?   About all I can think of is to build with the flags to disable XLIB and XCB support to make sure it still builds, and then run vulkaninfo and make sure we don't see the KHR Xlib abd Xcb surface extensions.

Thanks for having a look at this.
You can build e.g. under Ubuntu 16.04 - without a cross compiler enabled - the following way:
cmake -H. -Bdbuild -DCMAKE_BUILD_TYPE=Debug -DBUILD_WSI_XCB_SUPPORT=OF
F -DBUILD_WSI_XLIB_SUPPORT=OFF -DCMAKE_SYSTEM_PROCESSOR=arm
It builds and also vulkaninfo can be executed. The other examples are currently not build, as the VK_KHR_display code is missing in the examples. Either VeriSilicon or we will implement this at a later point of time.
We use this build configuration to cross compile for our i.MX8 target having Linux with no X11 on it - but the WSI extension VK_KHR_display is available and working.
From my tests, the changes do not harm the current available build configurations.
PS: Writing form my private account - FslNopper is me as well :-)
PS PS: You can assume, that VeriSiliicon and NXP will test this configuration for the future.

Another complication is that many of these files propagate to the https://github.com/LunarG/VulkanTools and https://github.com/LunarG/VulkanSamples repos.  In places where these changes overlap, like disabling the build of demos like cube, things are pretty straightforward.  But in other places, there will be additional items in VT and VS that need similar disabling.  For example, would it be correct to disable the build of all executables in VulkanSamples?
In short, I'll need to consider the impact of these changes into these other two repos as well.  I don't know how much you care about these other two repos, but I'll still have to handle things somehow.

For now, I would suggest to disable the build of the VulkanSamples in the other repos. In a next step, the necessary code to use the VK_KHR_display extension can be added.
Most important is, that the loader and validation layers do build. Regarding the samples, let's see if VeriSilicon and/or we can commit our changes as soon as possible.

In my opinion, this is not just an enhancement.
It is a bug, as building for just having the WSI extension "VK_KHR_display" present is valid and not an optional feature.
Hope this fix makes it into the next LuanrG SDK as well.

https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/925 closed.


Add indirect sorting routines to HPPC. [HPPC-21]

Indirect sorting routines are very useful in many applications and they are missing from the JDK. I'll move Carrot2 implementation to HPPC.

Issue: HPPC-21 (migrated from JIRA), created by Dawid Weiss (@dweiss), resolved Mar 12 2010

Comment by Dawid Weiss (@dweiss) (migrated from JIRA)
In trunk.


Fix/dark cover

Is this still needed? Looks like dark cover works now.

Is this still needed? Looks like dark cover works now.

This PR adds a white animating logo for dark mode. Please check if the current dark mode displays correct logo. If everything is OK, you can remove this PR.


Blockly Bug? Show text together with logic block

This is a minor blockly problem which we cannot fix easily.


Proposal: Modal input stack changes

The modal input stack is a hold over from the HoloToolkit, where we essentially had one input source (air tap). The intent of this feature is to allow application developers to display an object and route all events to that object, even if the user is not actively focusing upon it.
In MRTK, we added many more events, each of which are routed to the modal input stack. This issue is magnified when there are more than one control source in use (ex: two hands) as the number of events is multiplied.
It is believed that the modal input behavior shoud be modified to limit the types of events that are sent to that stack. We have landed on three possiblities.

Only send pointer events

pro: best performance, minimal event traffic
con: behavior change, events that may be relied upon will no longer be sent

Send pointer and source detected / lost events

pro: improved performance, applications can handle source lost mid click/tap
con: behavior change, events that may be relied upon will no longer be sent

Allow developers to specify the types of events to send

pro: most flexible, developers can balance features / performance, can replicate current behavior
con: highest performance cost, added complexity raising modal input

If we choose option 3, we can avoid behavior change by defaulting to sending all event. Alternatively, we can default to the most performant option and document how to restore the legacy behavior.

@davidkline-ms what is the status on this issue? Assuming it will be moot for XRI, but was there a 2.x-era resolution?

MRTK3 should not have this issue at all. Also, MRTK2 is unlikely to get such a large change at this point.


make check fails with segfault

Original issue 119 created by s.suerbier on 2012-09-22T15:46:40.000Z:
When running
make check
I see
    ***** Running arena_test
    /bin/sh: line 1: 21470 Segmentation fault: 11  ./$t

in version 1.5.0 on Mac OS X 10.7.4.
In fact all tests fail with a segfault immediately.
I wont even see output from a simple printf statement from main() in arena_test.cc.

No activity - and old. Closing issue.


Update gfastats

This PR updates gfastats.
Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot test this

@galaxybot deploy this


Replace flume with crossbeam in HTTP

We're getting a really weird panic in this area of the code and it seems to be a result of flume unwinding.
This is a shot in the dark experiment to see if using the much more popular and battle-tested crossbeam will resolve this issue. Long term we need to agree on what panic hooks should do (exit DD? try to handle when an error is expected (like HTTP)? just return something and let DM code fail silently?) and get them in. If this PR actually should be merged because flume is erroneous, then we need to remove it completely in redis as well, so this is a draft.

Dumb/unrelated question but would this solve the issue we have where we need dedicated start_http_client() and shutdown_http_client() methods to wipe out old http clients after a round between DD restarts? We had some issues with safety and bad memory accesses until we did this approach.
Relevant patch: https://github.com/ParadiseSS13/rust-g/blob/master/paradise-rust-g-patches/0005-Paradise-HTTP-Module-Tweaks.patch

Also please check out these 3 commits, it could give some inspiration.
https://github.com/ss220-space/rust-g-tg/compare/a4800676b265337ff4ade5534c6692c678e7579a...fcc86bc4b0432d7d41bf86c3309e119b3c01db81

This didn't actually fix it and the stack traces we're getting are the same. I'm going to get my panic hooks PR in better shape and get a better understanding


App unresponsive while looking up avatars

Gogs version (or commit ref): <IP_ADDRESS>4 / 0.10 RC
Git version: 2.11.1
Operating system: RPi 3 (dockerized)
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist (usually found in log/gogs.log):

Entire log not needed, relevant parts of a single request below (notice the timing):
2017/02/26 22:24:45 [ERROR] [...modules/base/tool.go:189 AvatarLink()] LibravatarService.FromEmail<EMAIL_ADDRESS>lookup _avatars-sec._tcp.gmail.com on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:48949-><IP_ADDRESS>:53: i/o timeout
2017/02/26 22:24:55 [ERROR] [...modules/base/tool.go:189 AvatarLink()] LibravatarService.FromEmail<EMAIL_ADDRESS>lookup _avatars-sec._tcp.gmail.com on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:47631-><IP_ADDRESS>:53: i/o timeout
2017/02/26 22:25:05 [ERROR] [...modules/base/tool.go:189 AvatarLink()] LibravatarService.FromEmail<EMAIL_ADDRESS>lookup _avatars-sec._tcp.gmail.com on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:36239-><IP_ADDRESS>:53: i/o timeout

Description
I just spent the last few hours trying to understand why Gogs took 20-30 seconds to load pages on my environment. The odd part was that it always took multiples of 10000 milliseconds to load, plus a few hundred ms depending on the page, just to render the template, on almost every page (installation and login pages being the few exceptions).
I found out that, since my Docker container has no access to the physical network, it waits 10 seconds for each avatar before finally giving up. So depending on how many times an avatar had to be retrieved, it took 10*n seconds + a few ms to render the page. I found out that configuring Gogs in Offline mode works as a temporary solution.
The reason I'm opening this issue is because I don't think an application should hang so many seconds just because it cannot retrieve an user avatar. In general, a web page should really not wait for a cosmetic element to be ready before displaying something to the user. Couldn't the avatar be loaded asynchronously by the browser, after the actually useful information had been loaded?
If this cannot be done, for whatever reason, I think the following should be done to mitigate the time the application is unusable due to a network problem with gravatar (it could be everything, from a misconfiguration like in my case, to a temporary network outage):

A wait of 10 seconds seems exaggerated to me, shouldn't a few seconds be enough?
Cache the avatar responses and do not try to re-download an avatar for some time. In my case, the avatar being retrieved is always the same (mine, being the only user of the system atm), there is no need trying to fetch it 3 times in 30 seconds.
Look-up avatars concurrently, so that in all cases, in at most timeout seconds, all requests will have either succeeded or failed.

Thanks

Hi,

If you have connectivity problems to federated avatar servers, you can disable it and just use the Gravatar: https://github.com/gogits/gogs/blob/master/conf/app.ini#L267
Or simply use offline mode: https://github.com/gogits/gogs/blob/master/conf/app.ini#L48

Hi @Unknwon,
I have stated in my initial report that I have resolved the issue on my environment for now by using offline mode.
I think however that addressing the issue could still be useful, for temporary problems (like network outages or gravatar being down), or for other people misconfiguring Gogs (having a page rendered without avatar in 300ms is better than waiting 30 seconds for the exact same page to be rendered without avatar).

Thanks for the advice, but try to compatible with network errors is:

Hard
Dirty
Nor worth investigating time specifically for Gogs, majority of use are in local network which offline mode is often enabled.


Prevent setting too big or too small Collision Mask and Layer

In CSGShape, PhysicsBody and Area, I added checks to prevent to set too big or too low mask or layer bits(0-31)
Some arguments in function definition was renamed because there had different names than in its declarations.

@AndreaCatania yeah you remember right, in TailQuest we make aggressive use of CollisionLayers for performance reason and I was afraid coming close to the limit, but I was reassured the limit in reality is higher

Yep, the limit is now increased to 32 which is the real limit. It's fine merge this now.

@qarmin Needs a rebase and some style fixes, otherwise should be good to merge.


Update README

I should update README.md file and points important things about the portfolio, terms of usage etc.

I've successfully updated description and attached a screenshot


Can't use ZHA mode with Xiaomi Gateway 3 (1.5.6)

Hi all,
I've researched all issues here and didn't find any which fits my issue.
A can't connect to getaway with ZHA, openmiio agent fails on connection from ZHA:
# /data/openmiio_agent miio mqtt cache central z3 --zigbee.tcp=8888
22:27:10.321 INF openmiio_agent version 1.2.1 linux/mipsle
22:27:10.360 INF [miio] connected to miio_client
22:27:11.380 INF [zigb] listen TCP port=8888
22:27:11.380 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
22:27:11.428 INF [miio] accept conn app=central
22:27:11.429 INF [miio] accept conn app=zigbee
22:27:11.435 INF [miio] accept conn app=gateway
22:27:11.532 WRN [cent] can't open socket
22:27:11.537 INF [mqtt] online
22:27:11.797 INF [miio] accept conn app=automation
22:27:12.788 INF [miio] accept conn app=hardware
22:27:14.790 INF [miio] accept conn app=homekit
22:27:14.792 INF [miio] accept conn app=bluetooth
22:27:28.757 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
22:27:33.455 INF [zigb] accept conn remote=<IP_ADDRESS>:56520
22:27:33.463 INF [zigb] probe fail error="wrong response" baud_rate=115200 read=0d0a4765636b6f20426f6f746c6f616465722076312e382e300d0a312e2075706c6f61642067626c0d0a322e2072756e0d0a332e2065626c20696e666f0d0a42
22:27:33.467 INF [zigb] close app=Lumi_Z3GatewayHost_MQTT
22:27:33.482 INF [zigb] probe fail error="wrong response" baud_rate=38400 read=6c6f19c8474071b83b723a71b06b1ce838ae63c41e53ee677aa3c1474071b83b723a71b06b1ce838ae63c41e53eee77aa3c1474071b83b723a71b06b1ce838ae
22:27:33.483 FTL [zigb] can't open serial error="wrong response" port=/dev/ttyS2

I've tried also on stock firmware 1.5.0 - no luck.
Any ideas how to work it out? Or where I'm wrong.
Thanks in advance.

HA: 2024.10.3
Xiaomi Gateway 3 for Home Assistant: 4.0.6
Device: Xiaomi Gateway 3
FIRMWARE: 1.5.6_0001 (custom)
UPD
Found an error in Lumi_Z3GatewayHost_MQTT
# Lumi_Z3GatewayHost_MQTT
Reset info: 11 (SOFTWARE)
gatewayInfo.txt was not found
gateInfo.Vaild = FF gateInfo.state=00
Directory "" was created failed
Begin to Reset NCP
ERROR: ezspForceReset 0x21
Lumi_Z3GatewayHost_MQTT: ../../../protocol/zigbee/app/framework/util/af-main-host.c: 382: emAfResetAndInitNCP: Assertion `0' failed.

Probably you have broken zigbee chip firmware. You can try to flash new firmware via this integration:
https://github.com/AlexxIT/XiaomiGateway3?tab=readme-ov-file#gateway-controls

So you have problem on stock or not?

Originally I had a problem on a stock fw for getaway as well

device was able to connect with getaway

Show integration diagnostics.

@AlexxIT first of all thanks for your time!
Let me try to give you all the information:
I have:
Xiaomi Multimode Gateway (EU) (YTC4044GL)
Acara Wireless Button (YTC4044GL)
Gateway at that moment was on stock fw 1.5.0

First of all I discovered and added button on Mi Home with gateway
Then I installed module Xiaomi Gateway 3 for Home Assistant
Configure and added Gateway integration. Button was also discovered.
After several tests I found that button works unstable. Sometimes it ignores events. Hold/release event worked time to time. So I was looking for improvements.
I've tried to configure ZHA at that time and I got an error Filed to connect (see screenshot above)
Than I tried to flash chip from integration - got an ERROR:
Diagnostics log file
"<IP_ADDRESS> [FWUP] Can't update firmware"
sock.connect((host, 8889))\nConnectionRefusedError: [Errno 111] Connection refused",
I realized that button doesn't work in Mi Home (automations didnt trigger) although it worked time to time in HA
I did reset gateway (10 times press button), added it to Mi Home again. And after this reset I couldn't add button anymore in Mi Home. After research I found information that Xiaomi Multimode Gateway doesn't support Acara buttons. IDK how I added it at the first time... But I gave up with it and concentrated on ZHA mode.
I've tried to flesh chip via telnet but failed https://github.com/AlexxIT/XiaomiGateway3/issues/1042
I successfully flashed gateway FW to custom 1.5.6_0001 and nothing changed
I also tried use zigbee2mqtt mode but zigbee2mqtt add-on also fails to start:

[2024-10-28 22:17:28] error: 	z2m: Error while starting zigbee-herdsman
[2024-10-28 22:17:28] error: 	z2m: Failed to start zigbee
[2024-10-28 22:17:28] error: 	z2m: Check https://www.zigbee2mqtt.io/guide/installation/20_zigbee2mqtt-fails-to-start.html for possible solutions
[2024-10-28 22:17:28] error: 	z2m: Exiting...
[2024-10-28 22:17:28] error: 	z2m: Error: spawn udevadm ENOENT

Zigbee2MQTT add-on config:
data_path: /config/zigbee2mqtt
socat:
  enabled: false
  master: pty,raw,echo=0,link=/tmp/ttyZ2M,mode=777
  slave: tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5
  options: "-d -d"
  log: false
mqtt:
  base_topic: zigbee2mqtt
  server: mqtt://core-mosquitto
  user: mqtt
  password: 123$mqqt@
serial:
  serial:
    port: tcp://<IP_ADDRESS>:8888
    adapter: ezsp

Mosquitto broker add-on config:
logins:
  - username: mqtt
    password: 123$mqqt@
require_certificate: false
certfile: /ssl/fullchain.pem
keyfile: /ssl/privkey.pem
customize:
  active: false
  folder: mosquitto

At the end I did followed this manual https://github.com/AlexxIT/XiaomiGateway3/issues/1328 But I couldn't configure Silicon Labs Multiprotocol addon with Device '/dev/ttyS2' and still have issues with ZHA and z2m modes.

Here is latest diagnosis file:
xiaomi_gateway3-01JBAB5ZDSY0Q0F4RDZ70WY12M-Mi Smart Home Hub-6b27152d9593e2ecd151070cb5737591-3.json

You gateway in some crazy state. It has broken zigbee fw. And it has broken gateway fw.
I haven't checked zigbee chip flashing logic several months. Maybe it's broken.
But first, you should to do, is to fix zigbee chip firmware.
If you really has 1.5.0 firmware (as diagnostics said), you can try to flash zigbee chip with this script
https://github.com/zvldz/mgl03_fw/tree/main/zigbee

Diagnostic says 1.5.0 but when I login via telnet it says FIRMWARE: 1.5.6_0001
And when I fetch device from cloud with integration it says 1.5.6

Try to flash older gateway firmware. Linked script not support new ones.

A flashed gateway and zigbee chip but still cannot access with ZHA :(
Here is outputs:

Flashing gateway output: (mgl03_1.5.0_0026_stock)
* Trying to free up space in /data

* Downloading ...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12.3M  100 12.3M    0     0   280k      0  0:00:45  0:00:45 --:--:--  350k

* Content-Length: 12917839
* Firmware size: 12917839
* Firmware size is correct
* Unpacking ...
Archive:  /data/update.zip
  inflating: full_ble_1.5.0_0102.gbl
  inflating: linux_1.5.0_0102.bin
  inflating: root_1.5.0_0102.bin

* Flashing BLE firmware
uart-dfu /dev/ttyS1 /tmp/full_ble_1.5.0_0102.gbl 1 OTA_STATE:0
do app!!
start update ble firmware!!
killall: start_ot.sh: no process killed
ota_state.txt is exist
killall: ncp_daemon: no process killed
sh: write error: Device or resource busy
sh: write error: Device or resource busy
reset in loader now
Bytes to send:377280
Syncing..DFU OK
Bootloader version: 17432581 (0x10a0005)
DFU packet size:377280
99%
finish
ncp target version:130
--200--->app ota_state:0
----->ble app updated

* Flashing kernel
Info: Open /tmp/linux_1.5.0_0102.bin, size: 2157588
Info: Firmware type: RTX Linux
Info: data_sum: cad3
Info: Upgrade linux bank 0
Info: Write to /dev/mtdblock5, size:2157572 ...
Process: 100%
Done
Info: Verify ...
Process: 100%
Success

* Flashing root
Info: Open /tmp/root_1.5.0_0102.bin, size: 10502164
Info: Firmware type: RTX Root
Info: data_sum: f527
Info: Upgrade rootfs bank 0
Info: Write to /dev/mtdblock6, size:10502148 ...
Process: 100%
Done
Info: Verify ...
Process: 100%
Success

*** Congratulations ***
Gateway will restart in 10 seconds

Flashing zigbee chip output: (ncp-uart-sw_mgl03_6_7_10_z2m)
Select firmware: 2
You selected: ncp-uart-sw_mgl03_6_7_10_z2m.gbl

Preparing
Killing default zigbee software
killall: socat: no process killed
Done

Press Ctrl+C to cancel in 5 seconds!

Detected EZSP v7
Rebooting to bootloader
Sending upload command
/tmp/mgl3_zigbee_flash.sh: line 185: /data/sx: not found
Sending restart command
Detected EZSP v7

Flashing completed!

Reload XiaomiGateway3 integration or restart Home Assistant
Configure zigbee2mqtt port address to: tcp://<IP_ADDRESS>:8888

/data/openmiio_agent miio mqtt cache central z3 --zigbee.tcp=8888
21:04:59.849 INF openmiio_agent version 1.2.1 linux/mipsle
21:04:59.880 INF [miio] connected to miio_client
21:05:00.898 INF [zigb] listen TCP port=8888
21:05:00.898 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
21:05:00.925 INF [miio] accept conn app=zigbee
21:05:00.983 INF [mqtt] online
21:05:01.824 INF [miio] accept conn app=automation
21:05:02.819 INF [miio] accept conn app=hardware
21:05:04.820 INF [miio] accept conn app=homekit
21:05:04.824 INF [miio] accept conn app=bluetooth
# Lumi_Z3GatewayHost_MQTT restarting in loop
21:05:18.759 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
21:05:36.699 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
21:05:54.639 INF [zigb] run app=Lumi_Z3GatewayHost_MQTT
# Trying to connect from ZHA
21:05:56.230 INF [zigb] accept conn remote=<IP_ADDRESS>:39368
21:05:56.247 INF [zigb] close app=Lumi_Z3GatewayHost_MQTT
21:05:59.227 INF [zigb] probe fail error="wrong response" baud_rate=115200 read=
21:06:02.227 INF [zigb] probe fail error="wrong response" baud_rate=38400 read=
21:06:02.227 FTL [zigb] can't open serial error="wrong response" port=/dev/ttyS2

Lumi_Z3GatewayHost_MQTT -n 1 -b 115200 -p /dev/ttyS2 -d /data/silicon_zigbee_host/ -r c
Reset info: 11 (SOFTWARE)
gatewayInfo.txt was not found
gateInfo.Vaild = FF gateInfo.state=00
Directory "/data/silicon_zigbee_host/" was created successfully
Begin to Reset NCP
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=0
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=0
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=0
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=0
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=1
ZIGBEE_RESET VALUE=0
ZIGBEE_RESET VALUE=1
ERROR: ezspForceReset 0x21
Lumi_Z3GatewayHost_MQTT: ../../../protocol/zigbee/app/framework/util/af-main-host.c: 382: emAfResetAndInitNCP: Assertion `0' failed.
Aborted

Hi @AlexxIT
No any idea how to flash zigbee chip in my case?

You can send me telnet access to your gateway. You can open port on router or use ngrok (same idea but 22 port):
https://github.com/AlexxIT/go2rtc/wiki/Tunnel-RTSP-camera-to-Intenet
You can find contacts in github profile.

Did you manage to find a fix? I think I have the same issue. I've got the same gateway and ZHA randomly stopped working about 3 days ago


bub-comments-group

group comments of the binary upload boom project night

Hope i did this right