[full-ci] [tests-only] Remove scenarios tagged skiponocis

Description
This PR removes @skipOnOcis tagged scenarios from ocis.
We cannot set Sharing settings in ocis https://github.com/owncloud/ocis/issues/1328.
Related Issue

Part of https://github.com/owncloud/ocis/issues/5337

How Has This Been Tested?

:robot:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

[ ] Forward port to master

https://github.com/owncloud/ocis/tree/remove-scenarios-tagged-skiponocis
"This branch is 128 commits ahead, 583 commits behind master."
That is a bit scary. Please rebase to get really up-to-date CI. I don't want to merge this and then find that there is some unexpected problem.

https://github.com/owncloud/ocis/tree/remove-scenarios-tagged-skiponocis "This branch is 128 commits ahead, 583 commits behind master."
That is a bit scary. Please rebase to get really up-to-date CI. I don't want to merge this and then find that there is some unexpected problem.

I will make forward port pr to the master branch.

Oh, I forgot that this is to stable-2.0 branch, sorry. The message about being behind is not relevant.


Typo - Windows has "ctrl"

@merica199 Fixed by https://github.com/google/WebFundamentals/pull/4649
Ticket can be closed.

thanks y'all !


[kmac] Make entropy valid in reset state.

ROM_CTRL sends SHA3/cSHAKE operations through KMAC Application Interface when no SW is loaded. It is to verify ROM code is genuine and not corrupted.
Current KMAC requires some SW configurations to run the module. Need to check the CSRs and revise the design to use pre-defined value right out of reset.
To Be Added to the list

[ ] CFG.entropy_ready: Make rand_valid to 1 and send garbage data to SHA3.

implemented for rom


Add project type to slack name

I updated the doc to have another optional field for the slack naming convention. This one adds one for DS, SE etc projects.

I was on the fence on this.. but i like your optional solution. So, LGTM

works for me!


Why does instruction_len need to subtract 2?

https://github.com/SafeAILab/EAGLE/blob/667ba930db7ea0075421f3c7df94ffbc10b93805/eagle/ge_data/ge_data_all_llama2chat.py#L114-L115
For the llama3 model, does instruction_len also need to subtract 2?

done

do you know why?@cdliang11


Does the face model support other file formats, such as glbx?

Does the face model support other file formats, such as glbx?

Can you clarify what you mean by “face model”? Do you mean the occluder? Or the masks? Or do you mean attaching an object to be animated by facial expressions?

On Nov 12, 2024, at 9:07 PM, angel_promise @.***> wrote:
Does the face model support other file formats, such as glbx?
—
Reply to this email directly, view it on GitHub https://github.com/hiukim/mind-ar-js/issues/550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIO2L66O3ISLUXNLWJWKV32AKX7DAVCNFSM6AAAAABRVL2YJ2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TGOBZGQ3TCMA.
You are receiving this because you are subscribed to this thread.

Israel Alvarez
@.*** @.***>
https://www.arlo.boston https://www.arlo.boston/
617-291-8489


Add support for running tests

Allows running of tests using buildTarget/test BSP request
There appears to be no JVM specific TestParamsDataKind defined in the BSP spec, only Scala based ones.  These should be fine to use on any JVM language (Java, Scala, Kotlin etc.)
The following TestParamsDataKind types are supported...
scala-test which allows the client to run a list of tests at the class level per build target.
scala-test-suites-selection which allows the client to run a list of tests at the method level in a list of classes but only for 1 build target.
There are a number of caveats to testing...

Gradle >= 2.6 is required to run tests
Gradle >= 3.5 is required if environment variables are passed
TaskStartParams and TaskFinishParams do not contain a Location as Gradle only supplies the suite, class, method for each test, not the file uri.  That information is then lost as BSP has no way of reporting location except by file uri.
BSP has no structured way of reporting back the stacktrace on failed tests so that is done in the TestFinish#message

@jdneo Added TestStartEx and TestFinishEx

@jdneo I've raised this https://github.com/build-server-protocol/build-server-protocol/issues/674
I've gone for new data types as I don't think suite and class would be applicable to all languages but feel free to comment otherwise

Thank you @Arthurm1, I'll continue the integration work between this work and the java test runner extension.
BTW, I guess we need to update this proposal: build-server-protocol/build-server-protocol#674 as well?

I'll update it when we're completely happy with the structure here.

BTW, during the integration, I found an issue about the JUnit 5 @Nested support for Gradle Test Launcher: https://github.com/gradle/gradle/issues/29603
Just in case you may have the same problem.

Added TestNG and Spock tests.  I've just used whatever is currently sent back for display name etc.  I'm not sure if that's what's wanted but it's a start.

Some test cases failed. Except for that, the PR LGTM. One last thing I hope to do is to separate the related test cases to another file.
I can do that as well. @Arthurm1 Let me know if you want me to do that.

@jdneo I can't get the test classes to fail locally.  And I can't see why they would fail in the way they have.  I've added a commit to test out whether there is an issue with messages appearing on listeners from previous tests.  This commit doesn't use the connection cache for tests.  I don't intend for it to be merged - I'm just hoping to see if the tests return a different result.  Could you run the github test actions on this PR again please

I tried to run test on my mac and windows (without the last commit:
Connector cache test - do not merge). Mac passed. While windows testSpock() failed. Haven't got a chance to look into it.
But if it's related with cache. I think we need to separate the test to more small pieces. Like: one test case only to cover one test class/method, which makes it more maintainable.

@jdneo I think Github failing is down to the changes in https://github.com/gradle/gradle/pull/28019.
I don't know why Github is picking up that change but locally we are not.  I've updated the tooling API to 8.8 in the latest commit and it should solve the Github issue.
I think there's another issue with Github - I don't think it picks up env vars for some reason.  So I think testSingleMethodJunit and testSingleMethodTestNg will fail.
Do you know why that would be?  Can we disable those 2 tests for Github?  It's possible that I'm wiping out other env vars that Gradle needs to run - I've had to include SystemRoot for Windows.  Maybe more are needed for Github but I don't know which ones.  Gradle seems to only add SystemRoot...
https://github.com/gradle/gradle/blob/5cf3ebb43a13d610dd617187498faa61f475df44/platforms/extensibility/test-kit/src/main/java/org/gradle/testkit/runner/internal/DefaultGradleRunner.java#L342

Wait... The GitHub Action runs on ubuntu, I thinking it's nothing todo with the Windows and SystemRoot stuff.
Is that because the gradle version used by java-test? If I add the gradle-wrapper.properties file into it. The test will pass. Otherwise, the test fails, where gradle complain that getTestDisaplayName() does not exist.

But is that safe to call getTestDisplayName()? Since it's a new API.

I'm not sure.  I don't know whether the we can use it because the tooling API is at 8.8 or whether Gradle also needs to be at 8.8.
If I try different versions of Gradle locally I can't get getTestDisplayName to fail.
What happens when you get it to fail - is there a NoSuchMethodError?

It says:
AbstractMethodError@93 "java.lang.AbstractMethodError: Receiver class org.gradle.internal.build.event.types.DefaultTestDescriptor does not define or inherit an implementation of the resolved method 'abstract java.lang.String getTestDisplayName()' of interface org.gradle.tooling.internal.protocol.events.InternalTestDescriptor."

See this commit: https://github.com/microsoft/build-server-for-gradle/pull/144/commits/4c01d1c5115ae3b3934fc28e1fa230208fee40c8, I forced the test project gradle version fix to 8.7 by adding the wrapper property file. Now more cases failed. Which highly like due to the API getTestDisplayName() I guess.

I think maybe we need to:

rollback the getTestDisplayName() since it looks like now back compatible.
Disable the two failing env tests. I can track it as a debt and solve it in another PR.

I've wrapped getTestDisplayName so it should handle older versions.
Don't know how to disable tests purely on Github - is there an env var?

Added an additional sourceset to test

Here is says that "CI=true" will be set for github actions.
I've disabled the 2 env var tests based on this.  Also fixed formatting

Thank you @Arthurm1 for your contribution.
We can consider to support test debug delegation. Looks like BSP does not have that flag in request body. Maybe another extended point?

@jdneo I think Metals used debugSessionStart but for DebugSessionParamsDataKind used the same data kinds we use for tests e.g. scala-test-suites-selection and scala-test.
What's kind of interesting is that different clients might want different debug adapters....
Metals is primarily for Scala development so it uses https://github.com/scalacenter/scala-debug-adapter
For Kotlin there is https://github.com/fwcd/kotlin-debug-adapter
Java has https://github.com/microsoft/java-debug
I imagine the Java one is good enough for all but it would be handy to be able to specify the type in the BSP command and have the build server kick start the relevant one.  Another thing to propose to add to BSP spec.

Hi @Arthurm1, is the test feature working as expected on your Windows? I tested it today on Windows it's not working unless I remove launcher.setEnvironmentVariables(envVars);. But it's fine on Mac.

@jdneo Yes it works for me running gradlew server:test.
Are you on your cs/fix-test branch?  I see you've removed the SystemRoot env var setting on that branch and that was needed for Windows to work.

Ah, I mean the code itself. Not test.
I'm testing the integration with the gradle build server test support feature. Everything works fine one Mac. But on my windows, I have to comment launcher.setEnvironmentVariables(envVars);, otherwise the tooling api won't run the selected tests successfully.
Not sure if it's related with issue: https://github.com/gradle/gradle/issues/29785. Or it's caused by my own environment.

Ah - it works if I add SystemRoot property...
        // Running Gradle tests on Windows seems to require the SystemRoot env var
        // Otherwise Windows complains "Unrecognized Windows Sockets error: 10106"
        String systemRoot = System.getenv("SystemRoot");
        if (systemRoot != null) {
            env.put("SystemRoot", systemRoot);
        }

I should probably add this to GradleAPIConnector#runTests.  It's unfortunate that there is no TestLauncher#addExtraEnvVars method


Flask allows register functions with same name for before_request functions

Bug
Flask allows you to register multiple times a function with the same name when using the before_request decorator.
Is that how it's intended? I tried to find something on this issue in docs, but couldn't.

Minimal reproducible example
Code:
from flask import Flask

app = Flask(__name__)

@app.route('/')
def main():
    return "42"

@app.before_request
def f():
    print('hi')

@app.before_request
def f():
    print('hi again')

app.run()

Console log:
(env) C:\X\x\Project>py my_app.py
 * Serving Flask app 'my_app' (lazy loading)
 * Environment: production
   WARNING: This is a development server. Do not use it in a production deployment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
hi
hi again
<IP_ADDRESS> - - [21/Apr/2022 22:17:40] "GET / HTTP/1.1" 200 -

Expected behavior
Flask will throw an error like it does when you try to do the same for the route decorator
Environment

Python 3.8.2
Flask 2.1.1
Werkzeug 2.0.2

For route functions the name matters, for before_request it doesn't... so there's no problem in using the same function name more than once.

Oh. Okay. Thank you!


Weird filter behaviour

https://warthunder.com/en/news/7916-development-tcm-20-hail-of-bullets-en was not posted in non-filtered channels

Might do a full filter rework


Fix access level can not sort

Issue description:
In project list page. User click sort according access level, it does not work.
Fix:
Remodify the compare method.

Pull Request Test Coverage Report for Build 7921

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 63.949%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/scheduler.go
2
81.29%

src/common/scheduler/policy/alternate_policy.go
3
80.29%

Totals

Change from base Build 7920:
-0.005%

Covered Lines:
11979

Relevant Lines:
18732

💛  - Coveralls


Change topLevel check to topActive check

Commit changes from
https://github.com/satago/tapestry-jpa-transactions/pull/1
add a simple testing framework that allows testing JPA down the
database level and few tests to cover nested transactions. Need better
tests for covering the commit hooks

I made a new test case for EntityListeners and looks like transactional units in @PostUpdate are not committed. Do you want to keep following in-progress work? If so, I can keep making intermediate commits. Alternatively, if you prefer to preserve the state of this module as is, you could just kill the pull request and I can instead bring what I have right now to T5.5 and work on it there.

Intermediate commits are fine, let's continue with this PR.

Ok I see what you are saying about the committed but still active transaction. Creating a transactional unit in @PostUpdate has exactly the same problem and I agree that using the transaction.isActive() and the way it's done in the pull request #1 is just not going to work. I'll have to experiment with it some more. Given that this is the crux of the issue, it makes sense to continue here instead of trying to rush the merge into T5.

There are several issues with the codebase. The beforecommit and aftercommit hooks are only fired for the transactionalunit that is at the top of the stack. The fix for beforecommit should be simple and aftercommits should be handled in a separate transaction. This is more complicated for JPA @Post listeners that create transactional units since the events are fired during the commit operation while transaction is still active. Even still, transactions from multiple entityManagers are using the same stack which won't work. Since JPA doesn't support it natively, it would be useful to be able to trigger cascading sequential commit but it requires complete refactoring of how the transactional units are currently handled.

The latest push represents a semantically correct or at least consistent refactoring of the concept, with several tests backing it up. I'm going to go with a version of it for T5.4 mainline. It would certainly be useful to have more eyes on testing issues with thread safety and multiple persistence contexts in real world platforms but I fully understand that for you, it may be better to kill this pull request and let your module stand as a standalone offering for pre-T5.4, given that the implementation has drastically changed (but you should at least warn the users of the shortcomings, e.g. meant for a single persistence unit only and that the hooks not reliably being fired).

Hey Kalle,
Regarding different entityManagers in one transaction stack -- that was an design decision that it won't support different persistence units in one context, because otherwise it might give you a false guarantees of consistency. There were no intention to implement any support for distributed transactions. What's missing from original implementation is an assertion that throws a RuntimeException in case a user would try to mix different PUs in one stack -- I'll fix that in current implementation.
Note that you can still choose which PU to use in a transactional unit, it was missing from the TransactionalUnitBuilder though, assuming it would build a unit for default PU. That should be an easy fix too.
As for the rewrite, there are few features missing comparing to original implementation:

invokeAfterCommit & invokeBeforeCommit are now instance methods, which requires that classes participating in a transaction need to have a reference to an instance of EntityTransactionManager, meaning that you need to pass/@Inject it to the participating class somehow. I've checked our use cases, it's not a problem to us -- all our participants are tapestry services, but still could be a slightly limitation to some cases.
invokeAfterCommit & invokeBeforeCommit methods don't check that there's an active enclosing transactional unit when you register the callbacks. Meaning that newly registered afterCommit callback will never be invoked, because there's no active transaction that could trigger it, or it may be invoked as a part of another (next) transactional stack -- which could be even more misleading. This feature saved as a few times, allowing to catch some bugs early.
There's no more equivalent of TransactionalUnitBuilder that allowed constructing an instance of transactional unit with attached before/after callbacks outside of the transactional unit, decoupling a logic of transactional unit from callbacks, i.e.:

    private <T> void workInTransaction(
        final List<T> entities,
        final Worker<T> worker,
        final Runnable beforeCommit)
    {
        transactionalUnits
                .prepareRun(() -> entities.forEach(worker::work))
                .beforeCommit(beforeCommit)
                .runInTransaction();
    }

I couldn't find a way how you could do it with this rewrite.
Few notes/questions:

There's no more stack trace in the nested transaction warning which would make it nearly impossible to see what caused it.
Why is afterCommit callback can now interrupt the flow of other callbacks? Is it for cascaded commits?

Thanks, good points.

I think it's more honest that it's a service. Static operations can not be easily overridden later.
I was thinking that it's more flexible to be able to add the callbacks for whatever transaction happens next, but agree, perhaps its safer to not allow registering them at all if a transaction isn't open.
Yeah, so regarding before/after callbacks in transactional units, I couldn't figure out how to consistently execute a tree model (each unit having its all callbacks that can spawn new transactions) given that JPA doesn't allow actual nested transactions. Once I removed the callbacks from the units, there was no convincing reason for keeping the transactional unit either. Now, I'm fond of the build pattern but I didn't see a pressing need for it here. I considered chaining, and while that's not usually the style for service operations, I could change the signature to allow entityTransactionManager.invokeBeforeTransaction(invokable).runInTransaction(runnable)

Makes sense to add the warning about nested transactions back. Yes, I added the afterCommit callback's return value for symmetry to make it possible to explicitly stop a sequential transaction flow - though I'm not sure that the semantics are obvious to the user.

Should have referenced this PR instead of #2 from commit 950fbe26df5ff7dba1a79957ca7c9b3a7ef773c0.
I've back ported the tests to master (hence merge conflicts).
Mentioned commit should address most of above issues except when multiple different persistence contexts used in the same transactional stack -- this won't be supported unless there's a real need (i.e., all our applications use one persistence unit per application).
I'm thinking to add some sort of "strict mode" that would throw a RuntimeException if different PU names were used in the same stack. That mode should probably be enabled by default, and may be disabled with a symbol, or via TransactionalUnitBuilder's API if user wants to force this for some reason. But this is a low priority now.

Closing this PR without merge, because it has too many incompatible changes.
Most of the issues mentioned in this PR were addressed in commit 950fbe26df5ff7dba1a79957ca7c9b3a7ef773c0 (see previous comment) and covered with tests from this PR.
Work made in this PR was merged to the Tapestry5 repo via this commit https://github.com/apache/tapestry-5/commit/5047220cfe9a6f8a640fb10f0e3de266af51630f.
Thanks for working on this Kalle!

Agreed. Well thank you @dmitrygusev, while the implementation that ended up in the mainline differed a bit, the feature might never have found its way to Tapestry without you.


[Controller] Service Injection

We have to use an interface to give a concrete typehint for our constructor. This means all services that want to be injectable need to implement an interface.
Controller Code
instead of
$emailHelper = $this->getService('EmailHelper');

We can do this

use ContactModule\Interfaces\EmailHelper;

function __construct(EmailHelper $emailHelper {
    $this->emailHelper = $emailHelper;
}

Framework Code for Service Injection
<?php
$deps = array();
$controller = new \ReflectionClass($controllerName);
$params = $class->getMethod('__construct')->getParameters();
foreach($params as $p) {

    $export = ReflectionParameter::export(
        array(
           $p->getDeclaringClass()->name,
           $p->getDeclaringFunction()->name
        ),
        $p->name,
        true
    );

    // Example: string(EmailHelper)
    $type = preg_replace('/.*?(\w+)\s+\$'.$p->name.'.*/', '\\1', $export);
    $deps[] = $serviceManager->get($type);

}
$method->invokeArgs(new $controllerName(), $deps);

@noisebleed we are going with controller factories - so this is no longer something we're worried about.


named routes not available to pages_controller

I'm trying to integrate refinery with an existing application.  I'm finding that none of the named routes are available to the pages controller.  So, for instance, if you "link_to ..., root_path" in your application.html.erb it works on non-refinery pages, but fails for any page generated by refinery.  (refinerycms v2.0.0)

Yes this is due to engine isolation.
Currently you have to:
main_app.root_path
Soon you'll have to:
refinery.root_path
(once #1234 gets merged which is very shortly)
Do we need to update something or is this recommendation suitable?
Thanks!

I think that will work.  Where does / how does main_app get set?

It's a magic rails attribute


Linking issue with protobuf

Plugin project is dependent on protobuf.
Protobuf is already present on the device, but it's a version built with other compiler and using it causes incompatibility.
Therefore I built protobuf with llvm and added it into project.
PROJECT_ROOT/tizen/lib  Directory structure is:
libprotobuf-lite.so -> libprotobuf-lite.so.25.0.0
libprotobuf-lite.so.25 -> libprotobuf-lite.so.25.0.0
libprotobuf-lite.so.25.0.0

Since only libprotobuf-lite.so contains .so ending, only it gets copied into device, however the one in
/lib/libprotobuf-lite.so.25 is being linked instead.
I tried renaming the lib file from libprotobuf-lite.so.25.0.0 to libprotobuf-lite.so, but the issue persists.
running
ldd ./libflutter_plugins.so  | grep protobuf

on the target armel device
returns
libprotobuf-lite.so.25 => /lib/libprotobuf-lite.so.25 (0xb6b79000)

I was able to fix the issue by adding all files from PROJECT_ROOT/tizen/lib to
/opt/usr/globalapps/com.example.flutter_blue_tizen_example/lib manually
or using flutter-tizen tool from https://github.com/JRazek/flutter-tizen/tree/developjrazek.
Issue can be reproduced by running example in https://github.com/JRazek/flutter_blue_tizen

I managed to fix the issue by changing the SONAME of libprotobuf.so.25.0.0 to libprotobuf.so with patchelf tool.


Detect OS and architecture to allow building on macOS/non-amd64 systems

The Java FFI POC Makefile is hard-coded to support Linux/amd64.  To compile the shared library on macOS requires manual editing.
This PR detects the architecture and operating system within the Makefile.

This works for amd64 and i386 architectures only - I don't have access to an ARM-based Apple M1 machine at the moment

I've taken this, and Fabrizio's suggestion, and made it work on all 3 main platforms in https://github.com/Iotic-Labs/iotics-identity-go/pull/31.


Impossible to restore quarantined files on networksshare

The guide does not work if you want to restore files that was located on network-share.
Thanks for eating my files and giving me no opportunities to restore them again.

It would be more helpful if you could link the docs.microsoft.com page in question.
Do you have a suggestion for improving the docs page?
If you can provide a suggestion, it would help for future readers of the document page.

Sure.
https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-antivirus/restore-quarantined-files-windows-defender-antivirus
Defender just ate my files and tried to restore them using the above guide. No luck. The files flickers in GUI as like they are being restored from quarantine to my NAS (FreeNAS) and therefor removed from the list. But then they reappears in the quarantine list and are never restored. Fortunately I had a copy stored elsewhere.
It is so frustrating that Defender is just eating my files without asking - usually antivirus gives you a toast message with options.
Sorry for not including the link to begin with.

On 25 Apr 2019, at 06.33, Trond B. Krokli<EMAIL_ADDRESS>wrote:
It would be more helpful if you could link the docs.microsoft.com page in question.
Do you have a suggestion for improving the docs page?
If you can provide a suggestion, it would help for future readers of the document page.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@officedocsbot assign @mypil

@peteringemann - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket so this can get resolved ASAP. Based on outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for Windows 10 products:
https://support.microsoft.com/en-us/hub/4338813/windows-help?os=windows-10
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

@officedocsbot close


create Dockerfile

@vsourcesoft Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Hi @vsourcesoft .  For this guide creating a Docker file is out of scope.  For future reference if you want to create an image from a Spring Boot application check out support for cloud native buildpacks.


Examples for loading resources from JSON

Hi there! I'm trying to use your library. Would really appreciate some examples for reading fhir resources from JSON files.

You can just use any serde compatible JSON library like serde_json to deserialize the resource. I do this here for example: https://github.com/FlixCoder/fhir-sdk/blob/main/crates/generate/src/parse/codes.rs#L308
So you can choose any way of reading the file and deserializing.
let file = File::open("bla.json")?;
let buf_reader = BufReader::new(file);
let resource: Resource = serde_json::from_reader(buf_reader)?;

Done in https://github.com/FlixCoder/fhir-sdk/commit/4c1a3f507915b1ff08cc39f7a78c97bb24dbe5c1


Produce statically linked binaries

Signed-off-by: Kemal Akkoyun<EMAIL_ADDRESS>Fixes #332 #328
TODO

[x] Clean up Dockerfiles
[x] Make sure CGO cross-compilation works (using Goreleaser)
[x] Test against arm64

Does this mean we can also get rid of copying them in our dockerfile here? https://github.com/parca-dev/parca-agent/blob/0c05f0048b6773011bcbeeb26221e6e8cadb5e0e/Dockerfile#L45-L52

@brancz Good call. Let me make check that.

Thanks again for implementing this, just learned that ASAN doesn't run on statically linked binaries
github.com/parca-dev/parca-agent/pkg/discovery
github.com/parca-dev/parca-agent/cmd/parca-agent
# github.com/parca-dev/parca-agent/cmd/parca-agent
/usr/lib/golang/pkg/tool/linux_amd64/link: running clang failed: exit status 1
/usr/bin/ld: /usr/lib64/clang/14.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_linux.cpp.o): in function `__asan::AsanDoesNotSupportStaticLinkage()':
(.text+0x37): undefined reference to `_DYNAMIC'
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)

so build-dyn unblocked me 🎉


Building IQueryable not from DbSet then attach to DbSet

I wans to build IQueryable from Enumerable.AsQueryable()
then send the IQueryable to some DbContext class for excution
something like this
public class Querying<T>
    {
         public T BuildQuery()
         {
            return Enumerable.Empty<T>().AsQueryable().Where(...);
         }
    }

    public class DatabaseContext<T>:DbContext
    {
        DbSet<T> _set;
        public List<T> ExecuteQuery(Querying<T> query)
        {
              return _set.AttachQuery(query.BuildQuery()).ToList();
        }
    }

Can you elaborate why you want to do that? If this is just about refactoring the query generation then you can do this way
public class Querying<T>
    {
         public IQueryable<T> BuildQuery(IQueryable<T> root)
         {
                return root.Where(...);
         }
    }

    public class DatabaseContext<T>:DbContext
    {
        DbSet<T> _set;
        public List<T> ExecuteQuery(Querying<T> query)
        {
              return query.BuildQuery(_set.AsQueryable()).ToList();
        }
    }

Can you elaborate why you want to do that? If this is just about refactoring the query generation then you can do this way
public class Querying<T>
    {
         public IQueryable<T> BuildQuery(IQueryable<T> root)
         {
                return root.Where(...);
         }
    }

    public class DatabaseContext<T>:DbContext
    {
        DbSet<T> _set;
        public List<T> ExecuteQuery(Querying<T> query)
        {
              return query.BuildQuery(_set.AsQueryable()).ToList();
        }
    }

i don't want any component to have the ability to execute anything
only building up the query and execution handler will handle that and return the results
your code the component can simply call .ToList() and it will execute which will break my pattern

I believe if you do not want any code to be executed while building expression tree but want to execute with EF on demand, you need to re-create expression tree with all query roots replaced.
Can you describe what is the reasoning behind this kind of separation?

segregate execution from preparing

Refactoring I posted also segregate execution from preparing. Such segregation does not require having execution blocked. So I am still not able to get why you would need to block execution altogether. But if that is what you want to do then you can rewrite expression tree once you have prepared it.

@moataz1991 - If you want to block execution then you can write wrapping IQueryable and override Execute method and throw exception unless a specific method is called. That would avoid rewriting whole tree and still allow you to block.
We don't plan to add anything in EF to support this scenario.


Kubernetes 1.6.1

Signed-off-by: Ken Simon<EMAIL_ADDRESS>

Targeting the branch-1.6.1 branch so that we can coordinate with documentation updates, since a few things are broken on 1.6 that we need to address in docs (helm, RBAC breaks the admin dashboard, etc.)


feat: soft constraints about encoding and scale preferences

Please make the issue title more descriptive of the content.

Regarding the title, what is an encoding preference?

Regarding the title, what is an encoding preference?

Like shape_high_cardinality, multiple non-position encodings, use non-pos before position?

Ahh ok. Sounds good to me.


Add security scanning tool (CodeQL)

Thank you for making this PR. While we appreciate the interest, PRs should have clear description and documentation of the problem they are solving. Closing this PR for now.


TMM: Redesign party ui

First we are throwing together something that works, but after that we will need to redesign the UI to be more user friendly (and hopefully pretty too).
Need a nice way of:

Inviting someone to your party
Seeing who you have invited
(Cancelling an invite?)
Seeing who has invited you to a party
Kicking players from your party
Seeing what factions each player has selected (is this feature really that important?)
Seeing who has readied up
Other player info like rating/country/avatar

Here's a preliminary mockup which may provide inspiration:

https://imgur.com/a/8YfjPwQ
And another one:

Wanna have the bug fixed quickly?
Visit Issue hunt...

https://github.com/FAForever/downlords-faf-client/tree/feature/new-tmm-ui
Closing as this is now part of the TMM branch and all dev work is done based on it, so we don't have a ton of dangling issues.


Rollback a failed transaction causes server crash

Description
When pg_tle is installed, ROLLBACK a failed transaction causes server crash
BEGIN;

-- Run a query that throws ERROR
SELECT 1/0;

-- ROLLBACK would cause a server crash
ROLLBACK;

Steps to reproduce
BEGIN;

-- Run a query that throws ERROR
SELECT 1/0;

-- ROLLBACK would cause a server crash
ROLLBACK;

server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.

Expected outcome
Without pg_tle installed, ROLLBACK would run as usual.
 One thing I'll raise from this: is it better for us to allow list the commands we want to process with the ProcessUtility hook? I believe there's only a small subset that we need -- we should probably check if its one of those at the beginning of the hook and return.
I think this could be addressed in a future commit as I preferred to err on the side of fixing the crash.


Make peer review allocation pluggable

The function repomate.util.generate_review_allocations should be made pluggable to allow for other allocation algorithm definitions.

As this will introduce the first default plugin, need to check what happens if it is also specified in the config and/or on the command line. Without special handling, I'm not sure what will happen.


azkaban.executor.ExecutorManagerException: java.io.IOException: executor became inactive before setting up the flow 8

This error is reported for all tasks performed, including the official example. The database executor is active. What is the reason for this。
The details of the error are as follows：
2019/03/09 10:02:42.736 +0800 INFO [ExecutorManager] [Azkaban] Using dispatcher for execution id :8
2019/03/09 10:02:42.943 +0800 ERROR [ExecutorManager] [Azkaban] Rolling back executor assignment for execution id:8
azkaban.executor.ExecutorManagerException: java.io.IOException: executor became inactive before setting up the flow 8
at azkaban.executor.ExecutorApiGateway.callWithExecutionId(ExecutorApiGateway.java:80)
at azkaban.executor.ExecutorApiGateway.callWithExecutable(ExecutorApiGateway.java:43)
at azkaban.executor.ExecutorManager.dispatch(ExecutorManager.java:1113)
at azkaban.executor.ExecutorManager.access$600(ExecutorManager.java:73)
at azkaban.executor.ExecutorManager$QueueProcessorThread.selectExecutorAndDispatchFlow(ExecutorManager.java:1344)
at azkaban.executor.ExecutorManager$QueueProcessorThread.processQueuedFlows(ExecutorManager.java:1316)
at azkaban.executor.ExecutorManager$QueueProcessorThread.run(ExecutorManager.java:1254)
Caused by: java.io.IOException: executor became inactive before setting up the flow 8
at azkaban.executor.ExecutorApiGateway.callForJsonObjectMap(ExecutorApiGateway.java:108)
at azkaban.executor.ExecutorApiGateway.callWithExecutionId(ExecutorApiGateway.java:78)
... 6 more
2019/03/09 10:02:42.951 +0800 WARN [ExecutorManager] [Azkaban] Executor node154:42491 (id: 3), active=true responded with exception for exec: 8
azkaban.executor.ExecutorManagerException: azkaban.executor.ExecutorManagerException: java.io.IOException: executor became inactive before setting up the flow 8
at azkaban.executor.ExecutorManager.dispatch(ExecutorManager.java:1119)
at azkaban.executor.ExecutorManager.access$600(ExecutorManager.java:73)
at azkaban.executor.ExecutorManager$QueueProcessorThread.selectExecutorAndDispatchFlow(ExecutorManager.java:1344)
at azkaban.executor.ExecutorManager$QueueProcessorThread.processQueuedFlows(ExecutorManager.java:1316)
at azkaban.executor.ExecutorManager$QueueProcessorThread.run(ExecutorManager.java:1254)
Caused by: azkaban.executor.ExecutorManagerException: java.io.IOException: executor became inactive before setting up the flow 8
at azkaban.executor.ExecutorApiGateway.callWithExecutionId(ExecutorApiGateway.java:80)
at azkaban.executor.ExecutorApiGateway.callWithExecutable(ExecutorApiGateway.java:43)
at azkaban.executor.ExecutorManager.dispatch(ExecutorManager.java:1113)
... 4 more
Caused by: java.io.IOException: executor became inactive before setting up the flow 8
at azkaban.executor.ExecutorApiGateway.callForJsonObjectMap(ExecutorApiGateway.java:108)
at azkaban.executor.ExecutorApiGateway.callWithExecutionId(ExecutorApiGateway.java:78)
... 6 more

maybe executor  is down

Take a look at the startup log to see if the executor is really alive, and judging from the error messages, the connection did time out when web connection exec was reconfirmed after the selection

Take a look at the startup log to see if the executor is really alive, and judging from the error messages, the connection did time out when web connection exec was reconfirmed after the selection

maybe executor is down

The problem was solved temporarily, but not in a reasonable way:
I had no intention of trying to process the request: http://node151:12321/executor? Activate action=activate this address so that all my tasks can run as normal.
I tried again and again, but the error was not resolved when the execution port was not fixed.
Is this because something is not configured properly?

Is the log level debug or info?

Is the log level debug or info?

INFO

property active in class FlowRunnerManager is false default, there should be true by some way, it confuse me ,too

We had this problem. We run in ECS with one container called azkaban-webserver and another called azkaban-executor. In our db there is only one executor named "azkaban-executor". We suspect during upgrade the old azkaban-executor must have marked the executor inactive in database.
As a workaround we changed our container entrypoint to start azkaban-executor and then call curl http://localhost:port/executor?action=activate to make sure the new executor is active.

你好! 解决了吗?

Take a look at the startup log to see if the executor is really alive, and judging from the error messages, the connection did time out when web connection exec was reconfirmed after the selection

maybe executor is down

The problem was solved temporarily, but not in a reasonable way:
I had no intention of trying to process the request: http://node151:12321/executor? Activate action=activate this address so that all my tasks can run as normal.
I tried again and again, but the error was not resolved when the execution port was not fixed.
Is this because something is not configured properly?

Take a look at the startup log to see if the executor is really alive, and judging from the error messages, the connection did time out when web connection exec was reconfirmed after the selection

maybe executor is down

The problem was solved temporarily, but not in a reasonable way:
I had no intention of trying to process the request: http://node151:12321/executor? Activate action=activate this address so that all my tasks can run as normal.
I tried again and again, but the error was not resolved when the execution port was not fixed.
Is this because something is not configured properly?

你好! 找着原因了吗? 怎么解决的呢, 方便说下吗?

do request by this
curl http://${executorHost}:${executorPort}/executor?action=activate

I also got this error, because I don't active executor node by call curl http://${executorHost}:${executorPort}/executor?action=activate.
I did this, add executor node from the table executors, this make me got the error.
call curl http://${executorHost}:${executorPort}/executor?action=activate is work.

I also got the error but the issue was in DB where the executors config lies. It has canonical hostname instead of The IP address and web node was not able to communicate with the executor node.
there is a configuration in executor azkaban.server.hostname If it is not set the executor register itself with canonical hostname(hotname -f). and for this there should be the host entry mapping in web node  fopr the executor node <hostname -i> . If the above config is set the executor registers itself with the provided value of in config zkaban.server.hostname

I also got the error but the issue was in DB where the executors config lies. It has canonical hostname instead of The IP address and web node was not able to communicate with the executor node.
there is a configuration in executor azkaban.server.hostname If it is not set the executor register itself with canonical hostname(hotname -f). and for this there should be the host entry mapping in web node  fopr the executor node <hostname -i> . If the above config is set the executor registers itself with the provided value of in config zkaban.server.hostname


Fixed bug when converting currencies stronger than base currency

In the previous logic, if the ratio is less than 1, it divides, otherwise it multiplies. This only works if the converted currency is stronger than the base currency.
For example: if the base currency is US Dollar and the converted currency is EURO, the ratio could be 1,14 (EUR to USD) or 0,88 (USD to EUR). So if i want to convert EUR 100 in the first case it will divide, in the second multiply but we will always get USD 114 as a result.
The problem with this logic is when converting currencies which are not stronger than USD.
For example: if the converted currency is Uruguayan Peso, the ratio will be 33 (1 USD = 33 UYU).
With the previous logic, the conversion would have been 100 UYU = 3300 USD, which is wrong.
So my proposal is change the logic, and always multiply. So the ratio should always be: from converted currency to base currency.
To summarize, if 1 converted currency = X Base Currency, then Ratio = X.

Hey, any chance to review this pull request?
Thx

Seems like a good fix that I would like to see in the software since this bug affects me too. @denisdulici Can you review it?


🐛 Coerce dynamic function return to str (when replacing content)

As found by @ubmarco, the return type of a dynamic function may not be a string, as so we need to make sure it is coerced to one, otherwise str.replace will except
I guess for your exception @ubmarco perhaps a field value was changed from an empty string to None (going from v2.1.0 to v3.0.0) 🤔

This is the problematic code on my side
needs_global_options = {
    "style": [
        (
            "status_[[copy('status')]] needs_style_release_[[link_copy('release')]]",
            "type in ['story', 'release', 'specification', 'phase', 'problem']",
        ),
    ],
}

The call "copy('status')" returns None, so it's not a self-defined dynamic function.
In my case I need to make sure every affected need has a valid status field.
Coercing None to an empty string fixes the problem immediately, but might have hard-to-debug side effects.
E.g. in my case the style field would have the value status_ set which is only visible when looking at the output.
A warning would make sense. I don't see a case in which having a dynamic function return None is not an exception.

Superseded by #1262


Create diagram showing modes in AutoML

There are 3 modes available:

Explain - To be used when the user wants to explain and understand the data.
Perform - To be used when the user wants to train a model that will be used in real-life use cases
Compete- To be used for machine learning competitions (maximum performance)

The Explain mode:

Uses algorithms: Baseline, Linear, Decision Tree, Random Forest, XGBoost, Neural Network, and Ensemble
Uses 75%/25% train/test split
Has full explanations in reports: learning curves, importance plots, and SHAP plots. (explain_level=2)
Steps: simple_algorithms, default_algorithms,  ensemble

The Perform mode:

Uses the following models: Linear, Random Forest, LightGBM, XGBoost, CatBoost, Neural Network, and Ensemble.
Uses a 5-fold CV (Cross-Validation) with shuffle and stratification.
Has learning curves and importance plots in reports. (explain_level=1)
Steps: simple_algorithms, default_algorithms, not_so_random, golden_features, insert_random_feature, feature_selection, hill_climbing_1, hill_climbing_2,  ensemble
There are 4 models created for each algorithm in not_so_random step.
There are 2 top models for each algorithm tuned in hill_climbing step.

The Compete mode:

Uses the following models: Linear, DecisionTree, Random Forest, Extra Trees, XGBoost, CatBoost, Neural Network, Nearest Neighbors, Ensemble, and Stacking.
Uses 10-fold CV (Cross-Validation) with shuffle and stratification.
It has only learning curves in the reports. (explain_level=0)
Steps: simple_algorithms, default_algorithms, not_so_random, golden_features, insert_random_feature, feature_selection, hill_climbing_1, hill_climbing_2,  ensemble, stack, ensemble_stacked
There are 9 models created for each algorithm in not_so_random step.
There are 3 top models for each algorithm tuned in hill_climbing step.

Available modes

explain
perform
compete

Uses models:

Baseline
+

Linear
+
+
+

Decision Tree
+

+

Random Forest
+
+
+

XGBoost
+
+
+

Neural Network
+
+
+

Ensemble
+
+
+

Light GBM

+

CatBoost

+
+

Extra Trees

+

Nearest Neighbors

+

Stacking

+

Validation:

Uses 75%/25% train/test split
Uses a 5-fold CV   (Cross-Validation) with shuffle and stratification
Uses 10-fold CV   (Cross-Validation) with shuffle and stratification

Explanations:

explain_level=2
explain_level=1
explain_level=0

Steps:

Learning   curves
+
+
+

Importance   plots
+
+

SHAP   plots
+

Steps

simple_algorithms
+
+
+

default_algorithms
+
+
+

not_so_random

+
+

golden_features

+
+

insert_random_feature

+
+

feature_selection

+
+

hill_climbing_1

+
+

hill_climbing_2

+
+

ensemble
+
+
+

stack

+

ensemble_stacked

+

Is it helpful?

Thank you @aplonska ! That's what I need!


My Tools temporarily shows no tools registered

Describe the bug
If you have tools, when you go to My Tools, you see a message "You have not registered any tools" until your tools are fetched. It's confusing.
For me, it takes 3 seconds to load my tools (I might be an outlier or this might be another bug), so it's pretty visible.
To Reproduce
Steps to reproduce the behavior:

Log in
Go to /my-tools
See "You have not registered any tools"  message, which eventually goes away.

Expected behavior
We should only display "you have not registered any tools" if you haven't registered any tools.
Additional context
If you go to My Workflows, there's also a delay (much shorter than for My Tools for me) before it loads your workflows, but it does not display "You have not registered any workflows", so we should follow that pattern.
Webservice - b08519d
UI - 2.8.5-137-g2662a269
Compose Setup - 638b53a
Deploy - <IP_ADDRESS>-127-g7c9a8a0
galaxyParsingLambdaVersion: 0.0.4
┆Issue is synchronized with this Jira Story
┆friendlyId: DOCK-2096
┆sprint: Backlog
┆taskType: Story

I still see it on dev.dockstore.net. It's more noticeable for me probably because I clearly have something in my tools in particular that is making the API respond super slowly (which is a separate issue), but you should be able to simulate this by throttling your network connection.
Made a GIF, but I don't think it plays back at real-time, seems slower. But like I said, it is there for 3-4 seconds.

Interesting, I don't get this with a bunch of different speeds in Firefox or Chrome.
I wonder if there is something different that triggers it, for example I have a github app tool and some glitchy looking Amazon ECR tools

Interesting, I don't get this with a bunch of different speeds in Firefox or Chrome.

I had only been trying it on Firefox; just tried on Safari and Chrome with the same results. On a Mac.
The call to https://dev.dockstore.net/api/users/<userid>/containers is taking 3 seconds for me; I'm surprised throttling didn't reveal the issue.


preallocation for multiplication

For a GBMatrix A (dense) and a GBMatrix B (sparse) multiplication, is it possible to do pre-allocation or inplace opereation to further minimize the time?

If you have a GBMatrix C that has the right internal storage type then yes you can do mul!(C, A, B). If C does not have the right sparsity (ie. If it is dense but the result is actually sparse) it will reallocate. Otherwise it should be in place.

Note that almost every operation supports a bang (!) version that is semantically in place. Whether or not it reallocates is up to the internals of the matrix and whether it needs to change sparsity.

I observed the following (counterintuitive) behavior:
julia> using SuiteSparseGraphBLAS, SparseArrays, BenchmarkTools

julia> X = GBMatrix( sprand(10, 1000, 0.9) );

julia> # without pre-allocation
       @btime $(X') * $X;
  34.615 ms (9 allocations: 8.58 MiB)

julia> # use the correct type for preallocation
       D = X' * X;

julia> # with preallocation
       @btime mul!( $D, $(X'), $X );
  31.978 ms (4 allocations: 8.58 MiB)

Although the number of allocations is halved, the amount of data allocated is practically the same. It is unclear why there are still 8.58 MiB of allocations made. The format of D is correct; it is the same in both cases. Any ideas or workarounds, @Wimmerer?

@fcdimitr this is a peculiarity of GraphBLAS. If you try the final invocation with accum = + as a kwarg you'll see the allocation disappear since the library is able to realize that it can do this in-place. The reason this doesn't work with the default second accumulator is that in order to be in-place the current implementation requires that accum matches the monoid of the semiring being used. I'm uncertain if this can be relaxed.
@DrTimothyAldenDavis do you have any advice on the comment directly above this one? Masking with D doesn't seem to help.

I would have to see the underlying calls to GraphBLAS.
I can only do things in place if the output is full, and the accum operator is used (as in C += A*B where C is full).  But D=X'*X where X is sparse should normally lead to a sparse matrix D, not a full one.

Oh duh @fcdimitr this is a full matrix on output, I thought this was sparse. @DrTimothyAldenDavis despite it being full there are still allocations, as expected. I guess we'll have to wait on JIT, though, to allow second accum?

It's full by chance.  I have to figure out that it's full, so I have to compute the pattern first.  Then I realize it's full and then I convert the result to full.

I have to do this even with a JIT.
If instead you want to force the output to be full, you can do this:
C = full matrix of the right size, all zero.
C += X'*X
then in principle, the 'dot2' method could exploit the accumulator.  But I don't think I have a kernel that exploits this case yet.

Thank you both, @DrTimothyAldenDavis and @Wimmerer! Your suggestions successfully address the issue of unnecessary space allocation in the dense output case.
However, when dealing with sparser matrices and expecting a sparse output, I noticed that a significant amount of allocation is still happening despite my efforts to enforce the desired output format, order, and sparsity pattern.
I am adding below a new benchmark script:
julia> using SuiteSparseGraphBLAS, SparseArrays, BenchmarkTools, Random

julia> Random.seed!(0); # reproducibility

julia> X = GBMatrix( sprand(10, 1000, 0.9) );

julia> # without pre-allocation
       @btime $(X') * $X;
  31.497 ms (9 allocations: 8.58 MiB)

julia> # use the correct type for preallocation
       D = X' * X;

julia> # with preallocation
       @btime mul!( $D, $(X'), $X );
  32.156 ms (4 allocations: 8.58 MiB)

julia> # enforce accum to be + to avoid allocations
       @btime mul!( $D, $(X'), $X; accum = + ) setup=( D=GBMatrix(zeros(size(X,2), size(X,2))) );
  29.042 ms (6 allocations: 272 bytes)

julia> ## Let's check the same with sparser matrices (and output)
       X = GBMatrix( sprand(10, 1000, 0.1) );

julia> # without pre-allocation
       @btime $(X') * $X;
  923.561 μs (17 allocations: 1.50 MiB)

julia> # use the correct type for preallocation
       D = X' * X;

julia> # with preallocation
       @btime mul!( $D, $(X'), $X );
  911.409 μs (12 allocations: 1.50 MiB)

julia> # empty out D, but keep the correct sparsity/format
       # (maybe there is a better way to do this?)
       ptr,idx,nzval,repack! = SuiteSparseGraphBLAS.tempunpack!(D);

julia> nzval .= 0;

julia> repack!();

julia> # enforce accum to be + to avoid allocations
       @btime mul!( Dtmp, $(X'), $X; accum = + ) setup=( Dtmp=copy(D) );
  3.278 ms (25 allocations: 3.02 MiB)

julia> # enforce accum to be + to avoid allocations using mask
       M = SuiteSparseGraphBLAS.Structural(D);

julia> @btime mul!( Dtmp, $(X'), $X; accum = +, mask = $M ) setup=( Dtmp=copy(D) );
  5.781 ms (15 allocations: 1.50 MiB)

I suspect this additional allocation occurs because the library needs to determine the pattern of X'*X and verify if it matches the preallocated output's pattern. Is there a way to inform the GraphBLAS library that the preallocated output pattern aligns with the expected result? This way, the multiplication could be performed in place, even when the output is sparse. I tried using a mask with the same sparsity as the output, but it did not remove allocations.
Thank you very much!
PS: Tested under Julia 1.9.0. The versions of the packages used:
  [6e4b80f9] BenchmarkTools v1.3.2
  [c2e53296] SuiteSparseGraphBLAS v0.9.0
  [9a3f8284] Random
  [2f01184e] SparseArrays

That's a smart way to set everything to 0 without making them iso! Good find.
Unfortunately I don't think this kernel exists yet. With the new JIT it will be somewhat easier to add but it's a rare case.
I'll try to keep this use case in mind and look for some solutions. On the Julia side and the SSGrB side (for instance I'm working on a way to use Finch.jl to fill in missing kernels so we get Tim's Uber fast hand tuned code with (still fast) autogenerated code for less common kernels.

I've tried MKL Sparse and GraphBLAS is often much faster.  But perhaps the preallocation would differ.
If there is an expected sparsity pattern of the result, it might be possible to use the pattern of the result itself as its own mask. This would be C<C,structural> += whatever.  The accumulator also tells me that no entry in the output can be deleted.
I exploit this kind of thing for GrB_assign, but not for GrB_mxm where this use case would be rare.  I would need to write a new kernel to exploit this particular case, and to reduce the number of reallocations.  This is something I could consider in the future.  We would need to categorize all the use cases in Julia where this sort of thing occurs, map them to GraphBLAS, and then make sure my kernels exploit those particular use cases.

Yeah I would only recommend the use of mkl_sparse_sp2m in the case where you know exactly the memory required ahead of time and you will reuse this memory often. Indeed I would recommend unpacking GBMatrix, running just that function with MKL, and then repacking into GraphBLAS for all the other fast operations.
Removing allocations by specifying mask = structural(output) is the most common request I have seen Tim.

Preallocation isn't currently planned for this library. It may be possible in the future but the spec doesn't really make room for pre-allocation.


Taking improvements from 1.9.x into master [7824]

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:


Why I set the 1080p resoltion, it seems not like that high?

Here is the source streaming

And the streaming at the destination

It seems not at the same resolution, any comments on this?

When you set the resolution under camera settings then you are setting  what the camera captures at. This resolution is used directly for videos and images captured to files.
The web interfaces streams a preview of this data which is converted from the raw camera resolution. This allows for a lower network bandwidth if required.
You can control the quality of the conversion using the preview settings (under camera settings.
The width will determine how the resolution is converted. So if it is set to say 512 then that will be the horizontal resolution and the vertical will be that needed to keep the aspect ratio. If you set the width to be the same as the raw width then the original resolution is kept.
The quality determines the level of jpeg compression used in the stream. This can be set low to keep bandwidth low but with some fuzziness or high to avoid any image degradation.
The divider determines the preview frame rate relative to the original frame rate. 1 will keep frame rate the same, 2 will halve the frame rate etc. Again this allows trading of bandwidth for smoothness of the video when there is movement.


Update winauth-azuread-setup-modern-interactive-flow.md

adding |Azure subscription under the same Azure AD tenant you plan to use for authentication. |  to match what we have under
https://docs.microsoft.com/en-us/azure/azure-sql/managed-instance/winauth-azuread-setup?view=azuresql#modern-interactive-authentication-flow

@mudeeb : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@srdan-bozovic-msft
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"

@srdan-bozovic-msft Could you take a look at the proposed change in this public PR? There are merge conflicts that I can help resolve if you approve the change. Otherwise, you can comment in this PR with your feedback. Thanks!

Hi @mudeeb, looks like this change was already made in this commit https://github.com/MicrosoftDocs/sql-docs/commit/15850ee3ecbce4b28c0d28aedaa3b780abf692bd :) thanks so much for your contribution!


Restore "Check failure stack trace" message on LOG(FATAL)

https://github.com/google/glog/pull/1074 refactored some of the code to enable the failure function to throw.  This made it so when the LogMessageFatal class was used, the error ended up being printed differently.
Before:
LOG_AT_LEVEL(google::LogSeverity::FATAL) << "Crash: Hello world!"; ->
F20240621 18:12:44.710584<PHONE_NUMBER>12672 log_demo.cc:16] Crash: Hello world!

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.56%. Comparing base (45f99f5) to head (939dba6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   63.57%   59.56%   -4.02%
==========================================
  Files          20       15       -5
  Lines        2578     1783     -795
  Branches      894      656     -238
==========================================
- Hits         1639     1062     -577
+ Misses        671      539     -132
+ Partials      268      182      -86

Files
Coverage Δ

src/logging.cc
65.77% <0.00%> (-4.37%)
:arrow_down:

... and 13 files with indirect coverage changes


vim: add vim-closer

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-darwin 1

1 package built:

spacevim

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-darwin 1

1 package built:

spacevim

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-closer
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-closer
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

1 package failed to build and are new build failure:

vimPlugins.vim-closer: log was empty

8 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

1 package failed to build and are new build failure:

vimPlugins.vim-closer: log was empty

8 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via
❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

and then nix-build -A vimPlugins.vim-closer . executed correctly.

hash mismatch in fixed-output derivation '/nix/store/1jmj0qzwai9prjrm0hg6cvqad58caa65-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch':
  wanted: sha256:0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9
  got:    sha256:065q30d913fm3pc7r5y53wmnb7q7bhv21qxavm65bkb91242d409
cannot build derivation '/nix/store/j0fh8ykvja3ik6cnf0q3n2wkszh3zwfb-vimplugin-vim-closer-2020-10-24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/srr39xzn69w98zniwcam584h4ck1qzar-env.drv': 1 dependencies couldn't be built

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via
❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

and then nix-build -A vimPlugins.vim-closer . executed correctly.

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via
❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

put it into derivation definition and then nix-build -A vimPlugins.vim-closer . executed correctly.

That does not work because the patch is normalized and edited before being put in the nix store and because we have no input aware fetchers nothing fails on your end.

Sometimes I don't understand how to work with sha256 correctly.
I've obtained my hash via
❯ nix-prefetch-url https://github.com/rstacruz/vim-closer/commit/a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch
path is '/nix/store/q69cj0n5l7j7lcqdcj024p9s39dvwm5i-a504be8c7050e41b7dfc50c2362948e2cf7c5422.patch'
0ni9mg86fdpa8pk4x80m5k48bm1hwpazrg644239q28vwplk2qf9

put it into derivation definition and then nix-build -A vimPlugins.vim-closer . executed correctly.

That does not work because the patch is normalized and edited before being put in the nix store and because we have no input aware fetchers nothing fails on your end.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-closer
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108949 run on x86_64-linux 1

9 packages built:

spacevim
vimPlugins.deol-nvim
vimPlugins.nvcode-color-schemes-vim
vimPlugins.nvim-dap
vimPlugins.vim-closer
vimPlugins.vim-floaterm
vimPlugins.vim-lsp
vimPlugins.vimspector
vimPlugins.yats-vim


How to set up multiple docker for the same website to conduct the parallel evalution.

Hello, do you have any advise on how to set up multiple dockers for the same website. For example, we can set up 10 shoping weisite with different port. So we can parallel evaluate it. Thank you!

We've only tried setting it up on multiple servers (e.g., launching the AMI on 3 ec2 servers). This seems to be the easiest way to evaluate in parallel. You can probably set it up to map to different ports with docker but not sure if it will break something else.


When logged in as user I see no option to "schedule a trip"

Requirement #3 for users seems to indicate the user should be able to schedule a new trip.  I see no such a option for trip unless that is a requirement defect unless that is supposed to say "disaster".

What has to be done before this issue can be closed?

This should be closed as the vocabulary on the requirements has changed.


Mismatched CSS when switching theme with Remix

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When you switch between themes, a CSS mismatch error is thrown in the console and that breaks the color scheme like text-color inside TextInput. I think this breaks in the client-side hydration process.
Expected behavior 🤔
Switching themes should break anything and hydration should work just fine
Steps to reproduce 🕹
Here's the example repo: https://github.com/arpitdalal/remix-mui
Steps:

open up the site on your local
hit the theme switch in the header
you'll see the theme switch but the text-color of the TextInput will be broken

Context 🔦
Just trying to build a theme switcher using MUI and Remix, handling the theme state in the cookie.
Your environment 🌎

`npx @mui/envinfo`
System:
    OS: Linux 5.10 Ubuntu 20.04.3 LTS (Focal Fossa)
  Binaries:
    Node: 14.17.4 - ~/.nvm/versions/node/v14.17.4/bin/node
    Yarn: 1.22.11 - ~/.nvm/versions/node/v14.17.4/bin/yarn
    npm: 7.21.1 - ~/.nvm/versions/node/v14.17.4/bin/npm
  Browsers:
    Chrome: 97.0.4692.99
    Firefox: 96.0.3
  npmPackages:
    @emotion/react: ^11.7.1 => 11.7.1
    @emotion/styled: ^11.6.0 => 11.6.0
    @mui/base:  5.0.0-alpha.66
    @mui/icons-material: ^5.3.1 => 5.3.1
    @mui/lab: ^5.0.0-alpha.66 => 5.0.0-alpha.66
    @mui/material: ^5.3.1 => 5.3.1
    @mui/private-theming:  5.3.0
    @mui/styled-engine:  5.3.0
    @mui/system: ^5.3.0 => 5.3.0
    @mui/types:  7.1.0
    @mui/utils:  5.3.0
    @types/react: ^17.0.24 => 17.0.38
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.1.2 => 4.5.5

Fixed: I wasn't putting children inside the <ThemeProvider> inside of my root. Here's the final commit: https://github.com/arpitdalal/remix-mui/commit/28e89dbe13d80799d995fe1fba4003e0ce85526a

Fixed: I wasn't putting children inside the <ThemeProvider> inside of my root. Here's the final commit: https://github.com/arpitdalal/remix-mui/commit/28e89dbe13d80799d995fe1fba4003e0ce85526a


BERT - Vocabulary not getting increased post fitting

I am fine tuning BERT with custom data and found that new words are not added to the oevrall vocabulary and accuracy of the model is only around 10%. Any suggestions ?

Adding new words for task fine-tuning (whether it is MT, Text classification or QA) with BERT is not a good practice, because you won't have proper embeddings for such words. You would need to train the MLM (masked language model) BERT with text that have this vocabulary to have a proper representation for such words.
However, even if there are some domain specific words in your data that are not in BERT vocabulary, the model can still have a satisfactory performance. We test it using financial text (which has a lot of technical terms) as data and it performed well.
In order to understand better what is happening with your custom data, can you please answer the following questions:

What does 10% of accuracy means here? For QA tasks we use F1-score or Exact Matching (EM). You can check the definitions here: https://arxiv.org/pdf/1606.05250.pdf
What is the size of your dataset (how many question-answer pairs)?
Are you using the raw version of the model (i.e., before fine-tune on SQuAD)? Maybe it will perform better if you fine-tune on SQuAD and then on your dataset (especially if your dataset is small)

I have tested around 50 questions and didn't get even 5 of them correctly predicted by the model
I am fine tuning BERT model with my custom date (around 250 QA pairs) => using .fit method
For retrieval purpose, I am fitting the retriever with the same 250 Questions again

I am afraid you do not have enough data to fit the model for QA.
So I advise you to:

First: fine-tune your model on SQuAD (as per our tutorials), or load one of our models fine-tuned on squad
Second: do a SECOND fine-tune on your data
Third: evaluate the performance using f1-score and exact matching, so that it is possible to compare with official metrics

I am pretty confused with the prediction part as well. First whether the code finds top_n predictions based tf-idf score and then use bert prediction to get one out of it?
2) Whether the text vectorization will include words from the pre -trained + fitted data as well?

The tf-idf retriever find the closest documents indices:
https://github.com/cdqa-suite/cdQA/blob/a05b4dd667f5021b2c0f66d2ab912b579f733d92/cdqa/pipeline/cdqa_sklearn.py#L155

The BERT reader selects the best answer inside these documents:
https://github.com/cdqa-suite/cdQA/blob/a05b4dd667f5021b2c0f66d2ab912b579f733d92/cdqa/pipeline/cdqa_sklearn.py#L160

Which text vectorization are you talking about, tf-idf vectorization or BERT embeddings?


Nonlinear_obc

Codecov Report
Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (c3cc4d8) 87.09% compared to head (b21f75c) 37.44%.

Files
Patch %
Lines

src/MacroModelling.jl
5.55%
102 Missing :warning:

src/plotting.jl
0.00%
29 Missing :warning:

src/get_functions.jl
46.15%
7 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #60       +/-   ##
===========================================
- Coverage   87.09%   37.44%   -49.65%
===========================================
  Files           8        8
  Lines        5153     5055       -98
===========================================
- Hits         4488     1893     -2595
- Misses        665     3162     +2497

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


A connection's message counts remain zero when messaging is in progress

Describe the bug
In the Console's connection tab, the messages in and messages out values remain at zero even when messaging is in progress.    This is a regression since 0.22.0.
To Reproduce
Steps to reproduce the behavior:

Create a standard address space.
Create a Pooled Queue
Run JMS client's HelloWorld modified with a System.in.read() before the connection close.
Examine the connection in the Console.
Connection is present, but the Message In and Message Out values are at 0.

Expected behavior
Message In and Message Out values should be 1.

On the brokered space issue, in my previous comment, the absence of the message out value is expected.  The Broker does not provide that information.  The column ought to be hidden.

@k-wall Column is hidden by the second commit in PR #1723


Problem: arbitrary big transactions might fail

Solution: add a new configuration parameter max_transaction_size to
limit the size of transactions accepted by the web API. The parameter is
also exposed by the root API endpoint using the same key
max_transaction_size, so drivers can act accordingly and eventually
fail early if the transaction to be sent is bigger than the upper limit.
This issue was first reported in #2222.
By default Flask will accept file uploads to an unlimited amount of
memory, but you can limit that by setting the MAX_CONTENT_LENGTH
config key. Spoofing the Content-Length is also considered: see the
integration test under
acceptance/python/src/test_max_transaction_size.py.
I had troubles creating a unit test to check this feature. It seems that
the pytest fixture for testing Flask ignores the MAX_CONTENT_LENGTH
setting. If you have better ideas on how to test that, please make a
patch.
To be honest, I'm not sure that having the parameter
max_transaction_size in the BigchainDB configuration file is a good
idea. It should be a Network wide configuration parameter, shared and
accepted by every non-byzantine node. We should have something like the
genesis.json file in Tendermint, and it should be updated using the
Election Process specified by BEP-18. If we do that, then
max_transaction_size should be checked also in the validation rules.

Please add some documentation about this new parameter in the page docs/server/source/server-reference/configuration.md:

Note that the number is in bytes
Link to the docs for the associated Flask configuration setting (MAX_CONTENT_LENGTH): http://flask.pocoo.org/docs/1.0/config/#MAX_CONTENT_LENGTH

I don't know how we could enforce all nodes having the same setting value. A Byzantine node could just lie about its value of max_transaction_size when asked. Each node could test another node, but then we have to ask which one, and how often it does the test (i.e. a real rabbit hole of complexity).

On a different note, it seems that this new setting is under the same umbrella as server.bind, server.loglevel & server.workers, so maybe it should be server.max_transaction_size.

I'm okay with having the max_transaction_size as a top-level setting (for each node). I just wondered your reasoning for it.

I'm arguing that this setting should be something implemented on a Network level, be written somewhere on the blockchain, and integrated at a validation logic.

Oh, I understand now: a transaction validation rule of the form
size(transaction) <= network_max_transaction_size
That's a nice idea. We could consider it for the v3 transaction model (or later). To ensure we don't forget, we could create an issue with the tx_model label so we don't forget about it: https://github.com/bigchaindb/bigchaindb/labels/tx model
For now, letting each node implement its own size check (using the web server) is probably okay, so long as there's a good default (less than Infinity).

In issue #2393, @CosmicCoder96 posted an example genesis.json file, for the latest Tendermint: see https://github.com/bigchaindb/bigchaindb/issues/2393#issuecomment-406074148
I noticed some new things in there:
{
  "genesis_time": "2018-07-18T15:48:46.24269529Z",
  "chain_id": "test-chain-cl61op",
  "consensus_params": {
    "block_size_params": {
      "max_bytes": "22020096",
      "max_txs": "10000",
      "max_gas": "-1"
    },
    "tx_size_params": {
      "max_bytes": "10240",
      "max_gas": "-1"
    },
    "block_gossip_params": {
      "block_part_size_bytes": "65536"
    },
    "evidence_params": {
      "max_age": "100000"
    }
  },
  "validators": [...],
  "app_hash": ""
}

In particular, there's a tx_size_params.max_bytes parameter. Since it's in the genesis.json file, it's the same for the whole (Tendermint) network.
Does this mean we can just rely on Tendermint to limit the size of a transaction (and also the size of a block)? Does Tendermint actually use these parameters?
If so, we should still point our users to the Tendermint documentation about all these parameters, i.e. from the BigchainDB documentation.

On August 12, I asked a question in the dev-tendermint channel on Slack:

In newer genesis.json files, there is a consensus_params.tx_size_params.max_bytes parameter. Is that maximum enforced by Tendermint?

and one of the core devs answered:

not currently
will be in the next release

(The latest release, at that point in time, was Tendermint v0.23.0.)
Therefore I guess we don't need to have a similar parameter in the BigchainDB configuration settings (especially since it would be per node, whereas genesis.json is for the whole network).

Update
Now it seems that Tendermint might not add the new max transaction size parameter after all! See https://github.com/tendermint/tendermint/issues/2347

This is interesting: there's another limit on the size of a transaction, currently hard-coded into Tendermint...
@ebuchman wrote:

Also note that the mempool must have an upper bound on message size - it's currently hardcoded to 1MB but perhaps we can make it dependent on the block size (ie. it should be the max size of data for the block)


cargo new: automatically add to workspace

Problem
When running cargo new in a workspace a warning is printed, but you have to manually add the new crate to the members = [] section.
Proposed Solution
Add a new --workspace / -w flag to cargo new that automatically adds the new crate with the correct path to members.
Print a hint about the flag when cargo new is run in a workspace.
This is admittedly a small quality of life feature, but I do it often enough that it becomes annoying.

Thanks for the report. This is a known issue, closing as a duplicate of #8365.

Sorry, I should have linked to #6378.

Any news about this proposal ? What's the current situation ? Thanks.