I can heart myself

Here is a screenshot from FastLBRY GTK that uses the comment API a little bit more straightly than odysee. Meaning hearts are one of the reactions that could be made to comments. In theory even multiple people can heart the same comment, if they are using the API or any non-standard client to LBRY. FastLBRY GTK is just one way of using it like this.

It's clearly me who hearted this comment. But Odysee's UI shows it to come from the publisher channel. I think there are 3 ways to deal with it.

Ban all hearting not done by the publisher channel. Perhaps could work, but also not the best option. It's nice to have the hearts as a metric that could have more than one hearts. Perhaps a comment moderator might add a heart, and a publisher might add another heart.
Show hearts only when they are done by publisher channel. A bit better. And I know that you can do it. The API knows that I hearted the comment even long after I did it. Because each reaction is signed by the channel that makes it. Perhaps you can find out who actually signed it and if it's not the publisher, do not show it at all.
Make the whole hearts system more flexible. I noticed ( while playing around with comments ) that there are more things than just Fire, Slime and Hearts. As you can see on the first screenshot. I exposed all of the option to the users. Now, think about this. Let's make hearts an interactive "show your appreciation game" that exposes whoever hearts. For each heart, a small user's logo will appear, just like it is now, with the original Publisher having the LARGEST LOGO that is the closest one to the heart. So people could know. So Fire will be an anonymous like. While heart will be a non-anonymous like. While if the heart is done by the publisher, it will be VERY PROMINENT to have the same effect as it is now.

Thanks for the bug report, will move this over the comment repo since that's where it would need to be solved. Don't have an ETA on this for now.

Issue moved to OdyseeTeam/commentron #107 via ZenHub


Type level contains operation without using unstable #[marker_trait]

Hi Nathanial,
I'm that person that suggested this wired Nathanial with the many No and Yes types after your talk at eurorust. You've suggested that it might be useful to have a writeup of that idea, as that might be easier to follow. As I had some time on my way back I've produced this blog post about the problem and my proposed solution.
(Sorry about opening an issue about that, it just seems to be the easiest way to get that to your attention)
Best,
Weiznich

Hey! Thanks for following up! I really appreciate it :)
Sorry it took a bit to get back to you. My github notifications need some cleaning up honestly :)
I'll take a look at this in the near future and see if I can remove another unstable feature flag!
Will close this for now


Upgrade to Junit 5 #249

packages org.junit moved to org.junit.jupiter.*
@Ignore replaced by @Disabled
Parameterized test using new annotations now @ParameterizedTest

Signed-off-by: Aurélien Pupier<EMAIL_ADDRESS>Pull Request informations
Rebase & Merge default requirements

Green build for master branch
Wait 24 hours after PR creation
Green job for PR
Approved PR

PR labels default process

READY_FOR_REVIEW  →  REVIEW_DONE  →  READY_FOR_MERGE

Tests

[ ] Are there Unit tests?
[ ] Are there Integration tests?
[ ] Do we need a new UI test?

PR workflow progress

[ ] Tagged with relevant PR labels
[ ] Green job for PR
[ ] PR was created more than 24 hours ago or All committers approved it
[ ] Green master branch build

Though I'm all for upgrading to new versions of tools, what are the benefits of moving to JUnit 5?

Though I'm all for upgrading to new versions of tools, what are the benefits of moving to JUnit 5?

more compact writing (+170 -218)
more power
some reasons explained here https://www.baeldung.com/junit-5-migration in chapter 2
Junit 4 is in maintenance mode, new features are coming only with Junit 5


bonsai_tag variable gets set several times

Set it once during initialization
Then remove default checks for len(sys.argv)

Resolved by #114


"Cannot read properties of undefined (reading 'status')"

After install, selecting any of the options (heat/cool/auto), gives the visual error "Cannot read properties of undefined (reading 'status')", and causes a Homebridge restart.
[25/01/2022, 18:44:56] Error: read ECONNRESET     at TCP.onStreamRead (node:internal/stream_base_commons:220:20) [25/01/2022, 18:44:56] Got SIGTERM, shutting down Homebridge... [25/01/2022, 18:44:56] [Homebridge UI] [HapClient] [<IP_ADDRESS>:51974 (0E:74:17:9A:4D:6A)] Failed to set value for Office Conditioner. [25/01/2022, 18:44:58] [Homebridge UI] [HapClient] [<IP_ADDRESS>:51974 (0E:74:17:9A:4D:6A)] Failed to set value for Office Conditioner. [25/01/2022, 18:44:59] Error: read ECONNRESET     at TCP.onStreamRead (node:internal/stream_base_commons:220:20) [25/01/2022, 18:45:00] [Homebridge UI] [HapClient] [<IP_ADDRESS>:51974 (0E:74:17:9A:4D:6A)] Failed to set value for Office Conditioner. [25/01/2022, 18:45:01] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null [25/01/2022, 18:45:01] [Homebridge UI] [HapClient] [<IP_ADDRESS>:51974 (0E:74:17:9A:4D:6A)] Failed to set value for Office Conditioner.
I notice the ECONNRESET reference which is the same error I get with another similar plugin (@bstuff).

@Lennys26 most likely your model is not supported. Write the air conditioner model and the homebridge version. And check that you have entered the source data correctly: mac, ip

@oxystin My model is an AS25S2SF2FA-SL.  I have checked and double-checked the MAC and IPs (on both units) several times hoping that I was making an error, but...no.
{     "accessory": "HaierAC",     "name": "Office Conditioner",     "ip": "<IP_ADDRESS>",     "mac": "04fa83817844",     "treatAutoHeatAs": "fan" }
I guess that you are correct that this model is not supported. Oh well.


Add --git-timeout configuration flags

Closes #1414
This PR adds a ~--git-time-out~ --git-timeout flag to both fluxd and the helm operator.
I was unsure what to do with the gitOpTimeout constant in daemon/loop.go:25. If someone could give me guidance in this I am more than happy to make additional changes.
Resulting builds from changes in this PR can be pulled and tested from:
hiddeco/flux:1414-git-timeout-9dc6b2181744
hiddeco/helm-operator:1414-git-timeout-9dc6b2181744

I don't know who takes care of the helm chart, but it would be nice to add the option there as well.
the current values -> https://github.com/weaveworks/flux/blob/master/chart/flux/values.yaml has quite a few options.
I tested and it fixed the problem I was having, thanks a lot.

the gitOpTimeout constant in daemon/loop.go:25 which is currently 15s gets hit on slower/remote networks, and it waits for entire loop cycle until its retried.
Is it possible for it to use--git-timeout argument for gitOpTimeout constant. I understand the concerns that it will slow everything down to timeout, but it should be fine to whoever is changing it.
Having the --git-timeout default of 20s to gitOpTimeout constant shouldn't be that big of a deal since its additional 5s

@latchmihay your reasoning makes sense to me and the additional 5s probably does not hurt anyone.
I will turn it into a PR tomorrow and see what others think.


[Feature Request] Add option to hide specific containers

I use GitLab CI with Docker to run the builds in my environment. It creates a container for each project it runs builds for. When you have a lot of projects Rancher starts looking like this:

So I'd like to have a option to hide specific containers in Rancher.
e.g. just add runner-* in a field in the control panel. Thoughts?

+1

Does Gitlab not delete the containers?

No, they are just being stopped and started again each time you push something. Each container represents a build step for a project. (e.g. check:lint, check:dependencies, deploy etc. pp.)

@smw355 you can upvote my first post by the way. No need for the +1 anymore :smile:. Here is a explanation.

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.

@will-chan can't reopen, still relevant

any news on this, I got the same problem. Hiding system stacks is working, so I suppose there is some filter mechanism already. Could this be adapted for custom filters?

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Example workbooks for the time series academy track

Summary of the changes / Why this is an improvement
An initial workbook in a series that will describe how to build ML-driven time series applications with CrateDB.
Checklist

[X] CLA is signed

Hi. Because conflicts on this branch haven't been able to be resolved properly, the new notebook has been broken out into a different PR.

GH-293

There is also a followup patch for that, adding a few copy-edits.

GH-294

Thus, I am closing this PR. Feel free to re-open if you think anything has been forgotten.


Static link zmq

It would be nice if the zeromq library was statically linked into the node binding.
this would reduce the amount of install problems

I agree it would resolve most issues people have, and would allow us to stay uptodate with ZMQ's releases independent of peoples' environments (whether that's a positive or a negative can be debated).
Arguments for or against welcome!

so like a pre-compilied lib directory with a .a file of libzmq for every single platform and architecture where iojs/node gets shipped? damn.. we'll probably need a speadsheet for starters..
if we supported a matrix of zmq versions, shit, that npm package would be among the fatest and largest known downloads on npm. but potentially everyone would be happy. image no matter where node works you could hit the ground running with a bunch of zmq sockets and no trouble. sounds like paradise :palm_tree:
i guess we could potentially combat the fatness by breaking it up into subpackages with platform specific static libs that the install script just somehow figures out how to pull down accordingly, or dont even use npm, but maybe do tagged releases on github and download them from a shell script like how nvm works...  is that what we're talking about here?

Rather than static linking, bundling the source could work. But it's GPL, so I'm guessing that would not be legal. We could also do what node-sqlite3 seems to do, which is download it and build it on demand.

I am for the bundling the source, and downloading on demand for avoid GPL issues.
We use zeromq.node in a distributed system and the deploy systems vary, it would also simplify our docker version as would not have to install any additional packages.
I could try and work on this and provide a pull request, though my experience in this type of thing is limited.

by all means! and at that point i think we'd need to bump this repo to version 3

Ok, I have started work on a commit regarding linking local version of libzmq downloaded and compiled for OS X (my default os)

@reqshark a bump would be appropriate.
By the way, this would be a great opportunity to unify the Windows and *Nix flavors of this module.

@ronkorving is the windows version separate from this module?
also what would be your opinions on using node-pre-gyp to supply precompiled library

I have no knowledge on that, so no opinion yet either.
Regarding Windows, see: https://github.com/JustinTulloss/zeromq.node/tree/master/windows

Thanks

Node-pre-gyp seems like a good solution for many problems of this nature. @springmeyer would you recommend using node-pre-gyp for this purpose?

:+1: for node-pre-gyp

Rather than static linking, bundling the source could work. But it's GPL, so I'm guessing that would not be legal.

libzmq's license is "LGPL with a static linking exception", i.e. static linking should be treated the same as dynamic linking. A binary that statically links libzmq specifically does not inherit LGPL.

Ah, you're right. That's great.


[PREGEL] Report worker status to conductor every 1000 loaded vertices

Add infrastructure to report pregel worker status to conductor
Based on Draft PR https://github.com/arangodb/arangodb/pull/16338

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/22445/ successful jenkins.


Console in the Chrome Inspector doesn't do anything if not suspended on a breakpoint

As per @entlicher comment in Gitter https://gitter.im/graalvm/graaljs?at=5c38d67b83c7e37765536b57

(tracked internally as GR-27550)


Added two new FAQs.

Learn Build status updates of commit f230376:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:x:Error

Details

docs/microsoft-365-developer-program-faq.yml

Line 39, Column 9: [Error: yaml-syntax-error] While parsing a block mapping, did not find expected key.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit e87586e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:warning:Warning
View
Details

docs/microsoft-365-developer-program-faq.yml

Line 134, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#how-many-microsoft-365-developer-program-accounts-can-i-create' in 'microsoft-365-developer-program-faq.yml', did you mean '#how-many-microsoft-365-developer-program-accounts-can-i-create-'?

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 0aeaf3b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:warning:Warning
View
Details

docs/microsoft-365-developer-program-faq.yml

Line 136, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#how-many-microsoft-365-developer-program-accounts-can-i-create' in 'microsoft-365-developer-program-faq.yml', did you mean '#how-many-microsoft-365-developer-program-accounts-can-i-create-'?

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 0aeaf3b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:warning:Warning
View
Details

docs/microsoft-365-developer-program-faq.yml

Line 136, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#how-many-microsoft-365-developer-program-accounts-can-i-create' in 'microsoft-365-developer-program-faq.yml', did you mean '#how-many-microsoft-365-developer-program-accounts-can-i-create-'?

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 724f9b4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:warning:Warning
View
Details

docs/microsoft-365-developer-program-faq.yml

Line 136, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#how-many-microsoft-365-developer-program-accounts-can-i-create' in 'microsoft-365-developer-program-faq.yml', did you mean '#how-many-microsoft-365-developer-program-accounts-can-i-create-'?

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 0616a3f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/microsoft-365-developer-program-faq.yml
:warning:Warning
View
Details

docs/microsoft-365-developer-program-get-started.md
:white_check_mark:Succeeded
View

docs/microsoft-365-developer-program-faq.yml

Line 136, Column 190: [Warning: bookmark-not-found] Cannot find bookmark '#how-many-microsoft-365-developer-program-accounts-can-i-create' in 'microsoft-365-developer-program-faq.yml', did you mean '#how-many-microsoft-365-developer-program-accounts-can-i-create-'?

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


IotProcessorManagement Post Build events

Hi thanks for the samples,
In the IoTProcessorManagement project, in the PostBuild events better to replace :
xcopy /y $(TargetDir). $(TargetDir)PowerShell
by
xcopy /y "$(TargetDir)." "$(TargetDir)PowerShell"
Better to keep quote if project is unzip inside ...\Documents\Visual Studio 2015....
Regards

closing this out, the newest version of the sample uses a different build script.


Use preloadAssets helper from ember-asset-loader

Follow up to https://github.com/dgeb/ember-engines/pull/184.
ember-asset-loader is a more logical place for the preloadAssets helper to come from (since it is not specific ember-engines).
Also worth noting that the preloading assets approach was chosen to avoid introducing order-dependency into test suites and to make it easy to do unit and integration tests (which will fail without first loading assets). It is also safe to preload assets since the actual act of loading them should have test coverage through this addon and the ember-asset-loader addon.

LGTM


Rename MAINTAINER

As all other images have the same MAINTAINER, so should this. Right ?
@bparees ptal :)

The Scl team is likely going to create their own base image in the near future, not sure I'd consider them the maintainers of this one. If you just want your name off it since you switched teams, you can put my name on it.

Just thought that all the our images should have the same MAINTAINER. Going to close this. Thanks


Attach errors to Fields that are dynamically generated?

I'm majorly confused by mapChildren in childrenTraversal.ts
On first blush I thought it was mapping through the entire form.  But I think it's only targeting children on the root level?  Even though it looks like it iterates through children.
I say this because it is unable to find Field components in child components inside the form AND even if the components are using childrenProps.  Unless I place a field as follows:
<Field name="options.0.name" type="text">
  {({ Errors }) => (
    <>
      <Stack spacing={4}>
        <FormInput
          control={control}
          name={`options.0.name`}
          placeholder="e.g. Color, Size"
        />
        <Text size="xs" color="red">
          <Errors />
        </Text>
      </Stack>
    </>
  )}
</Field>

It will not be found.
Doing this:
<ProductOption
    Field={Field}
    control={control}
    setValue={setValue}
    watch={watch}
/>

Nothing found in here.  Even though Fields exist.
Doing this:
<Hello Field={Field}>
  {({ Field }) => (
    <>
      <Field name="options.0.name" type="text">
        {({ Label, SmartInput, Errors }) => (
          <>
            <Stack spacing={4}>
              <Label size={14}>Page Title</Label>
              <FormInput
                control={control}
                name={`options.0.name`}
                placeholder="e.g. Color, Size"
              />
              <Text size="xs" color="red">
                <Errors />
              </Text>
            </Stack>
          </>
        )}
      </Field>
    </>
  )}
</Hello>

Again, the Field here is not found.  🤔
Also the fieldErrors function doesn't work for "options.0.name" situations.  But I resolved that with a new function fieldArrayErrors.
const fieldArrayErrors = (key: keyof SchemaType) => {
    const [newKey, index, name] = String(key).split(".")

    function getMessageByIndexAndName(obj, index, name) {
      const keys = Object.keys(obj)
      const key = keys[index]

      if (key && obj[key].hasOwnProperty(name)) {
        return obj[key][name].message
      }

      return undefined
    }

    const message =
      formErrors[newKey] !== undefined &&
      getMessageByIndexAndName(formErrors[newKey], index, name)

    return browser() ? message && [message] : errors && errors[key]
  }

The error param for the return array from makeField has been updated:
errors: key.includes(".") ? fieldArrayErrors(key) : fieldErrors(key),

But for the life of me.  I cannot extend remix-forms to go through an entire form and find Fields in children.  😓
Would really like this use case.  So any ideas?
Thanks

In the end, I've opted to write a helper function and append it to the return params of Form.

In the component where the fields are outputted:
const optionsErrors = flattenErrors(formState.errors["options"])

the using for the error message:
{optionsErrors[`options.${index}.name`]}

the function:
form.flattenErrors = errors => {
    if (errors === undefined) return {}

    function getMessages(data) {
      const messages = {}

      data.forEach(item => {
        for (const key in item) {
          if (item.hasOwnProperty(key)) {
            const ref = item[key].ref.name
            const message = item[key].message
            messages[ref] = message
          }
        }
      })

      return messages
    }

    return getMessages(errors)
  }

Would be awesome if this was native, but it's a good next step for now...

related to #74


#132 - Allow connecting to any IEnumerable

Added IEnumerable extension methods to convert to a
IObservable<IChangeSet<TObject, TKey>>
and a
IObservable<IChangeSet>

Yep. I’ll adjust

No dice on moving them. Still fails tests. Renaming to AsObservableChangeSet() solves the issue however, if that’s a reasonable name?

Change it to that for now. I will merge it and have a play about to see fix the overload resolution issue.

Ok, I 'think' you should have the additional changes. Never quite clear to me what magic the GitHub website is doing :-)


[QUESTION] Protection against SQL-Injections

Hello,
from what I saw while skimming through the repository and documentation, this Node does not have built-in protection against SQL-Injections, correct?
So if I want a secure app, I would have to manually sanitize my inputs beforehand?

I decided to just try and do an Injection into my database using this node - there is no protection.
You could document this somehwere, just so that people that maybe don't think about security a lot get a heads up.
Thank you for your work on this node :)

The node's job is precisely to run arbitrary SQL commands.
However, just like in other systems, you should use parameterized queries when working with untrusted variables: https://github.com/alexandrainst/node-red-contrib-postgresql/blob/main/README.md#parameterized-query-numeric


print(..., file=stdout) breaks compatibility with python2

python2 complains about this line saying 'invalid syntax':
https://github.com/dirk-thomas/vcstool/blob/c20d4b48df4e5c36976cab19d00577a19649027c/vcstool/executor.py#L31
it will need
from __future__ import print_function

to keep supporting python2?

ah I am sorry, you already dropped python2 support with the master branch.


chore(release): 2.11.0

Version bump in package.json and package-lock.json for release 2.11.0

:tada: This PR is included in version 2.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Attention! All issues are closed with release of new Swiper 3!

Note, that i have closed all issues with the release of Swiper 3. Which was rewritten from scratch, it has new API, new layout, compatible with different browsers, and has a bit different usage purpose. First of all, it is absolutely doesn't compatible with IE < 10 and Android < 4.
So, old closed issues are not really related to new Swiper, or outdated, or their authors doesn't provide more required information or dropped discussion.
Anyway, you may reopen your closed issue or create new one if it is actual for Swiper 3

Nice work! Looking forward to exploring 3.0!

@nolimits4web I just started looking into implementing this earlier in the morning, are the API Docs linked in the README current to 3.x?

@LucasKA Yes, everything is related to 3.x now. If you need to 2.x docs, you may found it here https://github.com/nolimits4web/Swiper/blob/Swiper2/API.md

Will 2.x be discontinued?

@Rikk yes

Ok.
I didn't follow the development of the new version and couldn't find in the site but I think it would be interesting for users to know: what improvements were made to the new version, what features are new¹ and which ones were removed? Maybe it could be added to readme or changelog, it would be specially useful for people thinking about upgrading. Thanks!
¹ Was hash-navigation plugin incorporated, right?

@Rikk Hard to say like that, because it could be a long list:) As a quick review
Removed features:

totally dropped old browsers support
removed scollContainer in favor of using pure CSS overscroll:auto, which as much better performance and more native look on mobiles

Totally new features:

new layout, now it uses flexbox instead of float:left with nasty size calculations like in 2.x. It should fix a lot of errors and cases with wrong/long/heavy sizes in 2.x
all 2.x plugins (3D Flow, Progress, Hahshnav, Scrollbar) are incorporated and parts of the core in Swiper 3
new built in transition effects: Fade, Cube, Coverflow
true RTL support
built in navigation buttons/arrows
controller. Now one Swiper can be controlled by another one and contra versa
multi row slides layout
touch events handling with "captures". This allows to create horizontal in horizontal swipers
pagination works in different way, it is now dynamic and number of bullets is always equal to number of so called "snaps", not to number of slides like in 2.x

So, as you see, most of 2.x features are here, but reworked, improved and increased with new great things ;)

Thanks for keeping the great work!
(Now we need MS to kill IE up to 9, so the web can evolve too...)

Thank you for continuous developing of such a good plugin. We are still using it to support ie9 but i agree that such browser must be forgotten in the past. Just one quick note - it works perfectly in Chrome and ie11, but in Firefox 35.0.1 mouse drag events are not working. I believe it is because of great update and can be fixed. Once again - thank you for your work.

@Taras123
With 3.0.1 should work ok in FF. And here is info about Swiper 2 if you still use it https://github.com/nolimits4web/Swiper#swiper-2xx

I'm migrating from 2.7.5 to 3.0.1, and I am using Swiper on my Hybrid mobile application, which relies on the 'pull down to refresh' feature heavily. And it seems the demo of that is missing. And since I'm using backbone.js, I realize when used with listviews with backbone items with delegated touch events ( like tap ) the scrolling gesture on freemode, also triggers the 'tap' event easily.

hi nolimits4web ,
I'm using swiper version3.0.8, and i found that in all IE 9, 10 and 11 having problem when click to next slide. The error shown
SCRIPT438: Object doesn't support property or method 'transition'
swiper.jquery.min.js, line 15 character 31485
could you please guide me how to solve this in ie?

use this in head tags to work with IE9 or less
`<!--[if lt IE 10]>

<![endif]-->`
https://github.com/eligrey/classList.js


Add support for loadavg

This is my first contribution to this project.
This PR adds support for parsing /proc/loadavg.
fixes #239

@mdlayher
Could you review this PR when you're free? 🙇


[SPARK-22549][SQL] Fix 64KB JVM bytecode limit problem with concat_ws

What changes were proposed in this pull request?
This PR changes concat_ws code generation to place generated code for expression for arguments into separated methods if these size could be large.
This PR resolved the case of concat_ws with a lot of argument
How was this patch tested?
Added new test cases into StringExpressionsSuite

Test build #83978 has started for PR 19777 at commit 1714c88.

Test build #83978 has finished for PR 19777 at commit 1714c88.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83978/
Test PASSed.

Test build #84030 has started for PR 19777 at commit 2a15b33.

Test build #84034 has started for PR 19777 at commit 7344fa4.

Test build #84030 has finished for PR 19777 at commit 2a15b33.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84030/
Test PASSed.

Test build #84034 has finished for PR 19777 at commit 7344fa4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84034/
Test PASSed.

thanks, merging to master/2.2!


2.0 post-migration helper: restructuring Location/LocationType hierarchy

As ...
Dan - Data Owner
I want ...
To redefine the root hierarchy of LocationTypes and Locations to something other than the "Region" (-> "Region" -> "Region" -> ...) -> "Site" hierarchy, which is what I get by default when migrating to 2.0, to something more structured and more representative of my business's expected hierarchy of locations.
So that ...

I can have Nautobot automatically enforce appropriate hierarchies of locations (e.g. I can only create a "Building" as a child of a "Campus", not as a child of a "Country") -- if "Country" and "Campus" are both represented as generic "Region"s, then Nautobot can't enforce this for me.
I can filter or retrieve locations based on their appropriate location types (e.g. /api/dcim/locations/?location_type=Country)

I know this is done when...

A tool exists that lets me re-map a single nestable LocationType (e.g. "Region"), which corresponds to a hierarchy of Locations of depth up to N, to a hierarchy of N distinct, non-nestable LocationTypes (e.g. "Continent", "Country", "City" for a hierarchy of depth 3) and automatically replaces in place the existing LocationType and its associated Locations of this type with the new hierarchy. (E.g. root-level "Region" records are remapped to "Continent", depth-1 "Region" records are remapped to "Country", depth-2 "Region" records are remapped to "City")
UUIDs and all other attributes (except location_type) of the migrated Locations are preserved (i.e., it's an update to the existing Locations, not a delete-and-recreate of new Location records).

Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[X] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[X] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
None.
External Dependencies
None.

Hey team! Please add your planning poker estimate with Zenhub @glennmatthews @gsnider2195 @HanlinMiao @jathanism @timizuoebideri1


Add ability to reference icons in external links

Add new parameter to external links to reference and print icons in front of external links.

@zjedi not sure if there is a nicer (more Go-like) way to reference/call the other shortcode, but copy&paste works locally.

This looks very useful, thanks for contributing!

@zjedi not sure if there is a nicer (more Go-like) way to reference/call the other shortcode, but copy&paste works locally.
As long as it works it's fine in my eyes :) You can have look at https://gohugo.io/templates/shortcode-templates/ for more details on custom shortcodes.

The only imperfection in my eyes is having the space between icon and text underlined - but that would complicate the implementation, not a big deal :)

@zjedi I've added the space as the icon is glued to the text otherwise. Would you think a   would be a better solution? Thanks.

One can alternatively use extlink and icon separately, if it's not required to have the icon linkeable


Changing the broker path of event log internal

Changed the event logger paths

@kamath-prasad done the change in scheduler config as well. Could you please review?


Added Postman collections.

When I import the collection into Postman, the url variables aren't found (sclAutoAlignServiceBaseUrl).
Are these in the collection variables, or in an environment?


Add test suite

This library is getting reasonably popular, so we really need to get our stuff together and add a test suite.

I feel like this is blocked by #46, since we would need to shim S3 for these tests to avoid publishing keys on this public repo.


Add support for GKE Autopilot

What this PR does / why we need it:
This PR is adding support for GKE Autopilot. GKE Autopilot is a mode of operation in GKE in which Google manages your cluster configuration, including your nodes, scaling, security, and other preconfigured settings.
Which issue(s) this PR fixes
Issue # https://github.com/rancher/gke-operator/issues/136
Special notes for your reviewer:
Checklist:

[x] squashed commits into logical changes
[ ] includes documentation
[x] adds unit tests
[ ] adds or updates e2e tests
[ ] backport needed

Changes look good, side question only: why we can't use AutoPilot with NodePools?

GKE AutoPilot will manage NodePools by itself, so we don't control it.


Creating a higher-fidelity mockup

Just a question, should we consider a higher-fidelity mockup for the site, so we are aligned on the look/feel of the site?
just a thought

Hey Doug,
I think this is a good idea. Did you have any platforms in mind? Otherwise we can draw up some pictures/processes (i.e. crud cycle).

Chaz

I was thinking either  figma or invision. They are both free. I think figma is a little easier to get ramped up quicker. I'm not too familiar with either, just have dabbled here and there, so i'm up for whatever. Also, I think we only need a hi-fi mockup for 1 page, maybe just the home page?
www.figma.com
https://www.invisionapp.com/

Closing this question as I opened a task item here
Thanks for the suggestion, @drcox23


Add an example that shows how to use the Neo4j data source

Setup:

incoming data from external source (e.g. CSV)
running database in Neo4j

Workflow:

connect incoming data to existing Neo4j graph
issue updates "ad-hoc" through Cypher queries

Fixed by https://github.com/opencypher/cypher-for-apache-spark/pull/313


Powershell Script for Identify function apps to upgrade is out of date and doesn't work

The Powershell script found under the Identify function apps to upgrade section is using Get-AzFunctionApp, which as of Nov 14, 2023 no longer includes the applications settings (per this GitHub Issue).
Would changing it to the following be reasonable?
$FunctionApps = Get-AzFunctionApp

$AppInfo = @{}

foreach ($App in $FunctionApps)
{
     if ($App.Runtime.ToLowerInvariant() -eq 'dotnet')
     {
          $AppInfo.Add($App.Name, $App.Runtime)
     }
}

$AppInfo

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ebb94eda-541d-913f-0668-64690a8320a7
Version Independent ID: 4fe76422-6653-a93f-d6c4-3bc510da6cf0
Content: Migrate .NET function apps from the in-process model to the isolated worker model
Content Source: articles/azure-functions/migrate-dotnet-to-isolated-model.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@willyt150
Thanks for your feedback! We will investigate and update as appropriate.

@willyt150 Yes, your changes look good. I have updated the doc and it will be published soon. We appreciate the feedback!


Document overrides in @statsig/js-client

🚀 Deployed on https://66a17e8a65ce0657d0dcbbe6--cozy-fox-0defec.netlify.app


Add option to compress blobs on import

Change the default back to leave uncompressed and add option to do the compression.
Fixes #3453
$ time ctr images import /tmp/kube-apiserver.tar
unpacking gcr.io/google-containers/kube-apiserver:v1.15.1 (sha256:91db5f34e0511159cb0eb24cd334f80be45561867f570b54b8aff9bcd3201073)...done
ctr images import /tmp/kube-apiserver.tar  0.85s user 0.17s system 15% cpu 6.537 total
$ time ctr images import --compress-blobs /tmp/kube-apiserver.tar
unpacking gcr.io/google-containers/kube-apiserver:v1.15.1 (sha256:2245106da92a70e3ed831b597641dcfefd5489a3e736598fb5598a14e37eb350)...done
ctr images import --compress-blobs /tmp/kube-apiserver.tar  18.03s user 6.20s system 81% cpu 29.866 total

As seen from above, the compression may add a non-trivial amount of time on import and therefore should not be the default. The option is useful when importing before a push or to reduce the size of the import blob. Note this only affects archives created through docker save, which does not compress today. Archives exported from containerd will preserve manifests and blobs.

LGTM

LGTM


SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server hello A

Hello!
I am getting the following exception when first communicating with the API via Savon:
HTTPI::SSLError: SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/httpi-2.4.2/lib/httpi/adapter/net_http.rb:51:in `rescue in request'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/httpi-2.4.2/lib/httpi/adapter/net_http.rb:33:in `request'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/httpi-2.4.2/lib/httpi.rb:161:in `request'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/httpi-2.4.2/lib/httpi.rb:127:in `get'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/resolver.rb:43:in `load_from_remote'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/resolver.rb:33:in `resolve'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/document.rb:142:in `xml'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/document.rb:160:in `parse'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/document.rb:147:in `parser'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/wasabi-3.5.0/lib/wasabi/document.rb:64:in `soap_actions'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/savon-2.11.1/lib/savon/operation.rb:22:in `ensure_exists!'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/savon-2.11.1/lib/savon/operation.rb:15:in `create'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/savon-2.11.1/lib/savon/client.rb:32:in `operation'
    from /home/deployer/27shops.com/shared/bundle/ruby/2.1.0/gems/savon-2.11.1/lib/savon/client.rb:36:in `call'

I've tried using ssl_version: :TLSv1 instead in the Savon client, and it works. Apparently, AFIP doesn't support SSLv2/3. This is our current monkeypatch:
module Bravo
  class Reference
    def self.set_client
      opts = { wsdl: Bravo::AuthData.wsfe_url }.merge! Bravo.logger_options
      @client = Savon.client(opts.merge(ssl_version: :TLSv1))
    end
  end
end

Does it make sense to submit a PR to make sure that we use TLSv1 as default in every Savon.client?
Let me know!

At a first glance, looks like the fix is correct. Even tho I've never run into this error before, AFIP tends to be very secretive about their changes, which makes this harder to identify.
Can you provide more information about your environment? Ruby version, gemfile/lock? Thanks!


Fix Katana rotations in hand with new texture

@TheOnlySilverClaw You can do this better than me :D

sigh
As soon as we have a new build ready, since the transformhelper does not work in Eclipse anyway. >.<


Switching to vendor

Switching from godep's _workspace to the now standardized vendor dir.
For review: @chrisbutcher

LGTM


Add logging to Integration test runs in local and local-cluster mode

This PR adds logs to integration test runs in local and local-cluster modes
Today, the integration logs only write output to the console making it difficult to go back and check test failures without re-running the failing test suite. This is useful when debugging integration test failures in a dev environment. This can also be used in auditing and identifying all the execs/expressions that are currently being tested by our integration tests if one is to set PYSP_TEST_spark_rapids_sql_explain=ALL before running the suite.

After running integration tests, the logs will be generated under PROJECT_ROOT/integration_tests/target/run_dir-xxx directory

Please add a better description stating exactly what this adds, how a user would use it, and why its being added.
What are Working logs?

Please add a better description stating exactly what this adds, how a user would use it, and why its being added.
What are Working logs?

Thanks for reviewing, I have updated the PR description. PTAL

@tgravescs @gerashegalov PTAL

so this one is just for the pytest driver/framework to write to the logs?
Yes, regardless of parallelism. This logger is used for logging pytest request.node.nodeid

Above we modify the spark driver_opts so when the spark session is created it uses the log4j.properties file specified there, correct?
Only when TEST_PARALLEL > 1 otherwise we use log4j properties defined in run_pyspark_from_build.sh

I will add more comments on this line to make this clear.

@tgravescs I have addressed your concern about only enforcing this in local mode. PTAL

mostly looks good, I had one question I'm waiting on

build

@gerashegalov PTAL

build

build


Az Cli Message Auto upgrade failed. 'pypi' display despite running latest version

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
Every Az CLI command I run generates this message at the end despite successfully running the command. "Auto upgrade failed. 'pypi'"
To Reproduce
run "az --version" or any az cli command at command line.
Expected behavior
Displays this WITHOUT "Auto upgrade failed. 'pypi'"
az --version
azure-cli                         2.30.0
core                              2.30.0
telemetry                          1.0.6
Extensions:
azure-devops                      0.22.0
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\schwinbp.azure\cliextensions'
Python (Windows) 3.8.9 (tags/v3.8.9:a743f81, Apr  6 2021, 13:22:56) [MSC v.1928 32 bit (Intel)]
Legal docs and information: aka.ms/AzureCliLegal
Unable to check if your CLI is up-to-date. Check your internet connection.
Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy
Auto upgrade failed. 'pypi'
Environment summary
Windows 10
MSI and CMD.exe CLI for Azure DevOps extension.

Resolved!
I still don't know why this message is displayed since I have the latest Python version installed. So I think it is still a bug.
But I was able to fix it by turning off auto upgrade in my config file in c:\users<username>.azure\config file.
[auto-upgrade]
enable = no

@jiasli for awareness

If you can repro this issue, please kindly provide the --debug log. Thanks.

I still have this issue:
➜ az --version --debug
cli.knack.cli: Command arguments: ['--version', '--debug']
cli.knack.cli: __init__ debug log:
Enable color in terminal.
cli.knack.cli: Event: Cli.PreExecute []
urllib3.connectionpool: Starting new HTTPS connection (1): azure.microsoft.com:443
urllib3.connectionpool: https://azure.microsoft.com:443 "HEAD / HTTP/1.1" 301 0
cli.azure.cli.core.util: Connectivity check: 0.2612989000000141 sec
urllib3.connectionpool: Starting new HTTPS connection (1): raw.githubusercontent.com:443
urllib3.connectionpool: https://raw.githubusercontent.com:443 "GET /Azure/azure-cli/main/src/azure-cli-core/setup.py HTTP/1.1" 200 1265
urllib3.connectionpool: Starting new HTTPS connection (1): raw.githubusercontent.com:443
urllib3.connectionpool: https://raw.githubusercontent.com:443 "GET /Azure/azure-cli/main/src/azure-cli-telemetry/setup.py HTTP/1.1" 200 676
azure-cli                         2.30.0

core                              2.30.0
telemetry                          1.0.6

Python location '/opt/az/bin/python3'
Extensions directory '/home/kristianb/.azure/cliextensions'

Python (Linux) 3.6.10 (default, Oct 29 2021, 10:11:34)
[GCC 9.3.0]

Legal docs and information: aka.ms/AzureCliLegal

Your CLI is up-to-date.

Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x7f2b73c49378>]
cli.__main__: Command ran in 0.612 seconds (init: 0.084, invoke: 0.528)
cli.__main__: Auto upgrade failed. 'pypi'
cli.azure.cli.core.decorators: Suppress exception:
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/azure/cli/__main__.py", line 60, in <module>
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/__main__.py", line 53, in <module>
    sys.exit(exit_code)
SystemExit: 0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/decorators.py", line 76, in _wrapped_func
    return func(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/telemetry.py", line 306, in set_custom_properties
    actual_value = value() if hasattr(value, '__call__') else value
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/telemetry.py", line 171, in <lambda>
    'x-ms-client-request-id'])
KeyError: 'x-ms-client-request-id'

auto-upgrade is currently not maintained very actively. Please refrain from using auto-upgrade.

Interestingly enough, never got this message before I upgraded to 2.44.1 today, have never enabled the auto upgrade either, but I thought it was strange that I got an auto-upgrade warning to this version from the previous 2.43. since I have never done that before.

This issue popped up for me just now, which breaks the use of AzureCliCredentials in the SDK:s since it expects a json, but gets the warning-message instead!
Seems to have been turned on by default again?

@kejne  No, it's disabled by default.
You can list all config by az config get.

az config set auto-upgrade.enable=no

auto-upgrade is currently not maintained very actively. Please refrain from using auto-upgrade which is by default turned off.

Then maybe the default output (a year and a half later) shouldn't say:
Upgrade finished.You can enable auto-upgrade with 'az config set auto-upgrade.enable=yes'. More details in https://docs.microsoft.com/cli/azure/update-azure-cli#automatic-update
(Which makes no mention of the fact it's unsupported/not in development/known issues.)

Here we are, a year later and it still saying the same thing.
You can enable auto-upgrade with 'az config set auto-upgrade.enable=yes'. More details in https://docs.microsoft.com/cli/azure/update-azure-cli#automatic-update

when this feature, apparently is not being maintained.


OpenVPN Widget missing Remote IP for client instances in 23.1.6

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
The OpenVPN Widget on the Lobby Dashboard does not show the the "Remote" IP address, aka the "Real Address", of client connections.
Some of the MVC refactoring work @AdSchellevis committed on April 2 - which is the last commit for the file - missed correcting a reference at line 123 to remote_host, which should now be real_address instead.
For reference: #6464 and my comment.
Editing the file in-place resolves the problem.
To Reproduce
Steps to reproduce the behavior:

On 23.1.6
Go to 'Lobby: Dashboard'
Observe in the OpenVPN widget under Client Instance Statistics: the Remote IP address is missing.

Expected behavior
The OpenVPN widget to show the "Remote" IP address, aka the "Real Address", of client connections.
Describe alternatives you considered
N/A
Screenshots
N/A
Relevant log files
N/A
Additional context
No multi-client server instances are present in my environment.
Environment
OPNsense 23.1.6

@AdSchellevis, apologies for not catching it, I saw Line 91 and thought that was it... If I'm not mistaken, Line 91 is for servers.
Also just realised I deleted the reference to which file whilst drafting the above; it's src/www/widgets/widgets/openvpn.widget.php.

@benyamin-codez no problem, I missed it too. https://github.com/opnsense/core/commit/8a3040fecdd93bd9bf457c281b7994e92c166ede should be the final part then.

@AdSchellevis that did the trick..!
Thanks again, and for the prompt fix.


why does solr update data slowly?

Hello , These days i am confused, i tried to write data from spark to solr , After spark jobs are done successfully, i opened solr to lookup datas ,there are nothing ,and the logs are not errors ,what happend ?
And the shards show something below :
                                  Version         Gen     Size

Master (Searching)<PHONE_NUMBER>208    362  1.11 GB
Master (Replicable)<PHONE_NUMBER>972   434
help me please.

Did you check by doing a hard commit?

Sorry , i can't understand what you mean .  I wonder why i can't find data in solr  after spark cluster has done successfully ? whether  are they cached in the  memory of solr cluster?

Please read https://cwiki.apache.org/confluence/display/solr/UpdateHandlers+in+SolrConfig#UpdateHandlersinSolrConfig-Commits

You could also try soft commit option https://github.com/LucidWorks/spark-solr#soft_commit_secs which should make the docs visible automatically


feat: Automate released image signing

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This PR proposes automating released nephio image signing using cosign. Currently, signing is done manually after the release. This PR aims to integrate signing into the release pipeline.
Which issue(s) this PR fixes:

Fixes https://github.com/nephio-project/nephio/issues/553
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/lgtm

/ok-to-test

/retest

/lgtm


Action Breaks with Nested Branch Names

Hi, there!
We are using this action to deploy our review apps for Pull Requests and it is working quite nicely for the most part. The action runs and creates the new Github page successfully.
The problem comes right after the folder is successfully created in our gh-pages branch. It's trying to fetch the origin of the original PR branch and fails.
At first glance, it looks like it is only grabbing the branch name after the /.
For example... we have a branch called feat/migrate-to-github-actions. Creating a PR against our main branch, everything works perfectly fine. All of our tests run, the review app kicks off, and then creates our new folder in our gh-pages directory.
Then the action throws an error, because it's trying to fetch origin on migrate-to-github-actions and not feat/migrate-to-github-actions where our actual branch is. A real example error encounter and output can be seen below:
/usr/bin/git push origin gh-pages
To https://github.com/orgNameRedacted/repoNameRedacted
   86a2253..a75c6a5  gh-pages -> gh-pages
/usr/bin/git fetch origin migrate-to-github-actions
fatal: couldn't find remote ref migrate-to-github-actions
Error: The process '/usr/bin/git' failed with exit code 128
(node:14081) UnhandledPromiseRejectionWarning: Error: The process '/usr/bin/git' failed with exit code 128
    at ExecState._setResult (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:1026:25)
    at ExecState.CheckComplete (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:1009:18)
    at ChildProcess.<anonymous> (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:903:27)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:430:11)
    at Socket.emit (events.js:210:5)
    at Pipe.<anonymous> (net.js:659:12)
(node:14081) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14081) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

(I redacted org and repo name above since the is for a private setup)

I have observed a similar problem in a repo I work on. The error message is different, but so far I've only seen it occur on branches with / in the name:
1 Run<EMAIL_ADDRESS>11 /usr/bin/git config --global user.name review-app-action-user
12 /usr/bin/git config --global user.email review-app-action-email
13 (node:2397) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'substr' of undefined
14     at createReviewApp (/home/runner/work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:10167:60)
15     at processTicksAndRejections (internal/process/task_queues.js:93:5)
16     at async /home/runner/work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:10206:5
17 (node:2397) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of  an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
18 (node:2397) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
19 /usr/bin/git config pull.rebase true
20 Error: Cannot read property 'substr' of undefined

Fixed in #14  !
I made a huge refactor in this PR together with this fix, the issue was that I was getting the branch name information from a wrong source! Hope it works for you guys now


Add dropdown trigger slot

Allows the developer to specify their own custom trigger element via the trigger slot. This lets developers create a really custom trigger that we may not want to add configuration properties to support. It will override any API property in px-dropdown that currently deals with styling/changing the content of the trigger. It's opt-in, developers using px-dropdown today don't need to know about it at all. It's also not the recommended way to use px-dropdown, developer should first use the out-of-the-box properties to style and only use this if their UI spec calls for something that can't be done with the current API.
Example usage:
  <px-dropdown
      items='[
        {"key":"1","val":"iPhone","icon":"px-utl:phone","color":"red"},
        {"key":"2","val":"Android","icon":"px-utl:phone","color":"green"},
        {"key":"3","val":"Blackberry","icon":"px-utl:phone","color":"blue"},
        {"key":"4","val":"Windows Phone","icon":"px-utl:phone","color":"orange"},
        {"key":"5","val":"Flip Phone","disabled":true,"icon":"px-utl:phone","color":"#C5D1D8"}
      ]'
      sort-mode="key">
      <button slot="trigger">Custom dropdown button</button>
  </px-dropdown>

/cc @randyaskin for code review when you return
Still to-do:

[ ] add tests to cover
[ ] add demo config (maybe)

I added to the simple demo in order to test the slot in action, and also made a small fix to the documentation (it was rendering the  so that half of the documentation, including the slot stuff, wasn't showing up). 👍


Use new zigpy request kwarg format

Proposed change

Once https://github.com/zigpy/zigpy/pull/1481 is merged, unit tests in this repo will start failing. This PR fixes them and ensures that we will have an easier time fixing them in the future, once we add new kwargs to the request method.
Additional information

Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Bumped the minimum required zigpy version to 0.68.1 now.
0.68.0 should be fine as well, but I guess this avoids any potential future test issues with request and expect_reply=False on 0.68.0.
This PR should be good to go then, right?

Yes. Coverage isn't 100% because I had to edit a few methods that weren't tested.


Parse Hive SQL surrounded by parentheses

HMS view_expanded_text allows outer parentheses.
SELECT tbls.view_expanded_text FROM sys.tbls LIMIT 1;

+--------------------------+
| tbls.view_expanded_text  |
+--------------------------+
| ( (select 1 as `c1`) )   |
+--------------------------+

@ljfgem @funcheetah Please review this PR when you have time.

Could you clarify how to get a view with parentheses? i.e., in what cases does Hive insert those parentheses especially that CREATE VIEW does accept a view definition surrounded by parentheses?

@wmoustafa Hive wouldn't insert parentheses. This case is caused by users.

Thanks! How can they cause it?

@wmoustafa The simple HQL example is:
CREATE VIEW test_view_parenthesis AS (SELECT 1 AS c1);

SHOW CREATE VIEW test_view_parenthesis;

+----------------------------------------------------+
|                   createtab_stmt                   |
+----------------------------------------------------+
| CREATE VIEW `test_view_parenthesis` AS (SELECT 1 AS `c1`) |
+----------------------------------------------------+

Interesting that throws a parse exception on Hive 1.1.

I tested in Apache Hive (version <IP_ADDRESS>.1.0.0-78).


Use absolute URLs for images in the README.md file

According to the Visual Studio Code documentation, Image URLs in README.md and CHANGELOG.md need to resolve to https URLs.
See: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions
🔗 Related

#74

right now on the published app the first screenshot is visible but the fix gif is not. seems like only the gif is breaking.


eosio produce block end

2098548ms thread-0   http_plugin.cpp:440           add_handler          ] add api url: /v1/wallet/sign_transacti
on
2098548ms thread-0   http_plugin.cpp:440           add_handler          ] add api url: /v1/wallet/unlock
2098548ms thread-0   producer_plugin.cpp:580       plugin_startup       ] producer plugin:  plugin_startup() beg
in
2098548ms thread-0   producer_plugin.cpp:595       plugin_startup       ] Launching block production for 1 produ
cers at 2018-08-13T00:34:58.548.
2098664ms thread-0   producer_plugin.cpp:607       plugin_startup       ] producer plugin:  plugin_startup() end

My scene is as follows:
I have a eosio node,it is my first node.At the beginning, only the eosio block was produced. Now I use the other two nodes to connect to the eosio node, and after voting to become the producer, then one node produces the block. When the two nodes are not connected, my eosio node cannot produce blocks, resulting in Unable to access. In order to prevent this, I hope that when the other two nodes are not connected, my eosio node can produce blocks, what do I need to do?Sir.

Have you enabled enable-stale-production = true in your config? by default it's set to false.

I have added enable-stale-production = true

Ok. I guess you also need to add
producer-name = eosio and
signature-provider = EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV=KEY:5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3

enable-stale-production = true
producer-name = eosio
signature-provider = EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV=KEY:5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3
I have added all three，sir
@ 2018-08-13T02:01:03.500 signed by initb [trxs: 0, lib: 8710, conf: 0, latency: 3 ms]
64003ms thread-0   producer_plugin.cpp:294       on_incoming_block    ] Received block 605bc7bce769180b... #8712
@ 2018-08-13T02:01:04.000 signed by initb [trxs: 0, lib: 8711, conf: 0, latency: 3 ms]
64507ms thread-0   producer_plugin.cpp:294       on_incoming_block    ] Received block ce607342639e3093... #8713
@ 2018-08-13T02:01:04.500 signed by initb [trxs: 0, lib: 8712, conf: 0, latency: 7 ms]
64930ms thread-0   net_plugin.cpp:2190           operator()           ] Peer <IP_ADDRESS>:9877 - c19abf2 closed con
nection
79773ms thread-0   net_plugin.cpp:1970           connect              ] host: <IP_ADDRESS> port: 9877
79773ms thread-0   net_plugin.cpp:2012           operator()           ] connection failed to <IP_ADDRESS>:9877: Con
nection refused
109773ms thread-0   net_plugin.cpp:1970           connect              ] host: <IP_ADDRESS> port: 9877
109774ms thread-0   net_plugin.cpp:2012           operator()           ] connection failed to <IP_ADDRESS>:9877: Co
nnection refused

bnet-endpoint = <IP_ADDRESS>:4321
bnet-follow-irreversible = 0
bnet-no-trx = false
bnet-peer-log-format = ["${_name}" ${_ip}:${_port}]
blocks-dir = "blocks"
chain-state-db-size-mb = 1024
reversible-blocks-db-size-mb = 340
contracts-console = true
filter-on = *
https-client-validate-peers = 1
http-server-address = <IP_ADDRESS>:8888
access-control-allow-origin = *
access-control-allow-credentials = false
max-body-size = 1048576
verbose-http-errors = true
http-validate-host = false
p2p-listen-endpoint = <IP_ADDRESS>:9876
p2p-peer-address = <IP_ADDRESS>:9877
p2p-max-nodes-per-host = 10
agent-name = "EOS Test Agent"
allowed-connection = any
max-clients = 25
connection-cleanup-period = 30
network-version-match = 0
sync-fetch-span = 100
max-implicit-request = 1500
use-socket-read-watermark = 0
peer-log-format = ["${_name}" ${_ip}:${_port}]
enable-stale-production = true
pause-on-startup = false
max-transaction-time = 3000
max-irreversible-block-age = -1
producer-name = eosio
signature-provider = EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV=KEY:5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3
keosd-provider-timeout = 50
txn-reference-block-lag = 0
wallet-dir = "."
unlock-timeout = 9000
plugin = eosio::chain_api_plugin
plugin = eosio::net_api_plugin
plugin = eosio::wallet_api_plugin
plugin = eosio::chain_plugin
plugin = eosio::history_plugin
plugin = eosio::history_api_plugin
plugin = eosio::http_plugin
plugin = eosio::net_plugin
plugin = eosio::producer_plugin
plugin = eosio::wallet_plugin
Sir,this is my all config.

Just FYI.
https://github.com/meet-one/Testnet/blob/master/how-to-set-up-testnet.md


(re-)exposing upstream (nixpkgs) modules

Context: https://github.com/ngi-nix/ngipkgs/pull/305#discussion_r1654628524
TLDR:
Currently, in ngipkgs, we are re-exposing nixpkgs modules like this:
modules.services.forgejo = "${sources.inputs.nixpkgs}/nixos/modules/services/misc/forgejo.nix";

But the ideal way to expose those modules would be this:
modules.services.forejo = nixos.modules.services.forejo;

Proposed solution:
We can call evalModules on https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix (AFAIK this is where all default NixOS modules are imported from) and get options on the result, finally, use unsafeGetAttrPos to get the file location.
Am I missing anything? I want to double check here before I go on and implement this

cc @fricklerhandwerk

This is in principle possible but likely very inefficient. I recommend doing a quick hack and running a comparison.
Also file location should be stored in the module value IIRC, please check the module system source.

I tried running the following for a couple times, and the result seem to settle around 0.72s
$ time nix-instantiate --eval --expr 'let lib = import <nixpkgs/lib>; in (lib.evalModules { modules = (map (m: lib.setDefaultModuleLocation m m) (import (<nixpkgs> + "/nixos/modules/module-list.nix"))) ++ [{ nixpkgs.hostPlatform = builtins.currentSystem; }]; }).options' > /dev/null
nix-instantiate --eval --expr  > /dev/null  0.71s user 0.08s system 97% cpu 0.805 total

However, in the REPL, unsafeGetAttrPos seem to return null for all attrsets under options


GEODE-3683: fix intermittent failure of CacheConnectionTimeoutJUnitTest

The old condition wasn't quite right. I don't think Awaitility is
actually the right thing to use here.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@PivotalSarge

merged, missed the commit.


[Feature] Expose ports for key Ray services by default

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Ports for the key Ray services (GCS, Dashboard, Client, Serve) should be exposed by default in the Ray head service.
Right now, these ports must be specified in the Ray head container config to be picked up in the service configuration. This is not good UX.
Use case
Simplify Ray cluster configuration.
Related issues
https://github.com/ray-project/kuberay/pull/399
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Default ports are already correctly configured when the head container's ports are left out.
Otherwise the head container's ports are used for the service.
I think the behavior is described in the Ray docs.


Planner: Add planner

This will be quite a feature:

plan which wire to use
how to build up a coil
which mod to use
display coil performance (watts)
create coil/build/setup from it

The biggest feature could be display of related vapes to see what to expect, eventually with mix/liquid filter.

Basically done in a quite nice way.


[DialogContent] Extra padding does not work when wrapped in form

We often wrap the dialog's content and actions in a form element to allow form submission to work when hitting enter for example. When you do that, you trigger this CSS rule that adds padding-top to the content as it thinks there's no title:
https://github.com/mui-org/material-ui/blob/8109f08888d7f8ed506632106e5ee16d1d83202e/packages/material-ui/src/DialogContent/DialogContent.js#L14
I think this rule should be removed or adjusted to work all the time, maybe with context?

Duplicate of #13253

It's kind of a separate issue though. This is only about the way the extra 20px padding is applied on DialogContent.
It happens simply if you have a non conventional DOM structure in your Dialog.


[Icon Updates] Adds CirclePlusIcon and CircleMinusIcon

Figma

Including in this PR are two additional Icons, which were designed as part of the Duplicate Patient Workflow.
CircleAddIcon

CircleRemoveIcon

IconLibrary
https://curology-radiance-pr-220.herokuapp.com/?path=/story/icon--icon-library

👍 - will go ahead and make that change since we seem to have consensus. @Shemoel1 let us know if you disagree or have other thoughts and we can discuss further.

@ipc103 👍

Thanks gang. @daigof I know you have a release coming up. Am I okay to publish this change as 6.4.1?

yes please release it as 6.4.1 same process thanks
On Thu, Apr 16, 2020, 18:32 Ian Candy<EMAIL_ADDRESS>wrote:

Thanks gang. @daigof https://github.com/daigof I know you have a
release coming up. Am I okay to publish this change as 6.4.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/curology/radiance-ui/pull/220#issuecomment-614907833,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACVNEWPLBQ4BO57DBW5KU23RM52QRANCNFSM4MKCMELA
.


pcli position replication should support ranged liquidity

Is your feature request related to a problem? Please describe.
Currently pcli tx lp replicate supports full-range xyk liquidity. However, this is not very capital-efficient.
Describe the solution you'd like
It would be good to support liquidity in a range, like UniV3. Maybe we call it univ3 and have the same parameters as UniV3 liquidity?

Closed as duplicate of #4112


feat: Remove support for .NET 6.0, 7.0

When this passes. My new Request will to.
I only Target .NET 6 as per your suggestion.
After you merge this, my PR  should work.
Alternatively, you can accommodate for the request only as well.
I'll be here if there's anything i should do.

With this PR we'll target .NET 8 as the new min. version. This is currently on hold until the other PRs are merged, so that anyone still using .NET 6 or 7 can benefit from the fixed that you submitted in https://github.com/parse-community/Parse-SDK-dotNET/pull/402.

Done.
I fundamentally did 3 things

Fixed Tests (log out etc), PR is submitted
Fixed Relations. PR submitted
Added more UT to hopefully increase coverage. Submitted as well !

That sounds good


[HOLD for payment 2023-11-01] Stop saving receipt in IOU action

Problem
We're unnecessarily saving the receipt object in the IOU reportAction object
Why is this important
Keeps data format consistent with what's expected
Solution
Stop saving the receipt in the IOU action
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013916d2c5796f424f
Upwork Job ID:<PHONE_NUMBER>755682816
Last Price Increase: 2023-10-20

@akinwale offer sent

@akinwale offer sent

Accepted. Thanks!

Nope - just had to pay you. Done!


Add LaTeX Rendering

This adds basic LaTeX rendering functionality. Surely this could be improved, but it works.

Thanks for the PR!
I'll spend some time looking at it this weekend


One-to-many properties not loading correctly

Ok, this is not a request for lazy loading or eager loading. I simply can't load the data I should.
I am using  "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0-rc2-final"
public class Property
{
    public int Id { get; set; }
    public int PropertyTypeId { get; set; }
    public PropertyType PropertyType { get; set; }
}

public class PropertyType
    {
        [DatabaseGenerated(DatabaseGeneratedOption.None)]
        public int Id { get; set; }
        public virtual ICollection<Property> Properties { get; set; }
    }

If I do
var properties = from x in _context.Properties
                             select x;
return properties;

propertyType is null. (Should it not be eager loaded since I didn't use virtual?)
If I do
return properties.Include(p => p.PropertyType);

I get first property with the propertyType. However, within the propertyType, there is an empty properties array which causes an infinite loop for the rest of the properties to show.
The workaround I can do is to add Newtonsoft.Json.ReferenceLoopHandling.Ignore. But this is just a one-to-many relationship. It shouldn't need it, right?

However, within the propertyType, there is an empty properties array

I cannot repro this using EF Core 1.0 RC2 final and the code your provided. For me the Properties collection navigation property is populated correctly and is of type HashSet<Property>.
Assuming you are referring to a problem you get when you serialize the graph of objects using Json.NET, this is not the right place to report it :smile:, but FWIW, my limited understanding is that any cycle (even a one-to-many relationship with navigation properties pointing in both directions) can be a problem with JSON serialization. Common approaches to solve it include removing one of the navigation properties, annotating one of them with one of the supported "ignore" attributes and taking advantage of Json.NET's serialization settings, e.g. ReferenceLoopHandling.Ignore or ReferenceLoopHandling.Serialize.

I am closing this issue because I pretty confident that it is not an actual bug report for EF Core, but feel free to reopen it if I am wrong and please provide any additional repro code (e.g. if you have any code in OnModelCreating()).

@divega Thanks for the reply.
I agree that it is probably not a bug. The problem is caused by HashSet<Property> in PropertyType. I can fix it by using [NotMapped]:
 [NotMapped]
 public virtual ICollection<Property> Properties { get; set; }

Is that possible for you to clear a couple of things for me?

Is it by design that in my case PropertyType in Property is not eager loaded even when it's not using virtual?
Is it by design that virtual Properties in PropertyType is eager loaded (HashSet<Property>) when I only used properties.Include(p => p.PropertyType) instead of properties.Include(p => p.PropertyType).ThenInclude(t => t.Properties)?

Is it by design that in my case PropertyType in Property is not eager loaded even when it's not using virtual?

Yes. Neither EF Core nor any previous version of EF has ever automatically eager loaded a property. You have to use Include().

Is it by design that virtual Properties in PropertyType is eager loaded (HashSet) when I only used

Yes, it is a graph of objects and EF will normally fix up any relationships between objects that are retrieved. The behavior may change if you use AsNoTracking(),  e.g. EF will not fix up navigation properties to objects retrieved by previous queries.

The problem is caused by HashSet<Property>

If the problem is really the type, you can use a different collection type.

Got it. Thanks @divega!


REQUEST

fix regex for labels with "(?<=\s|^):[^\s:]+"

also add command line stuff  / api

done


[stable/hazelcast] Use hostPort as containerPort (#70)

Please approve @hasancelik @leszko @mesutcelik @googlielmo @eminn

/ok-to-test


Support for += in List/SetProperty

Expected Behavior
+= syntax is supporter for List/SetProperty in build.gradle
pitest {
    fileExtensionsToFilter += ['xml', 'orbit']
}

with:
final ListProperty<String> fileExtensionsToFilter

and some default fileter extentions set by the plugin - extendable in a user configuration.
Current Behavior

MissingMethodException: No signature of method: org.gradle.api.internal.provider.DefaultListProperty.plus() is applicable for argument types: (ArrayList) values: ...

Context
On a migration from List<String> to ListProperty<String> people have to change their configuration. Adding the plus() method could help.

@adammurdoch I feel this should just be decorated on the List/SetProperty given it's specific to the Groovy DSL. At the same time, I feel like it's more magic then necessary. We could add the decoration but issue a deprecation warning so the migration is easier to tell users to use addAll or map. What do you think?

Note that, if desirable, this could also be added to the Kotlin DSL by leveraging operator overloading.
Here is an example with ListProperty<T> for +=:
operator fun <T> HasMultipleValues<T>.plusAssign(element: T) =
    add(element)

operator fun <T> HasMultipleValues<T>.plusAssign(provider: Provider<T>) =
    add(provider)

operator fun <T> HasMultipleValues<T>.plusAssign(elements: Iterable<T>) =
    addAll(elements)

operator fun <T : Any> HasMultipleValues<T>.plusAssign(providers: Provider<Iterable<T>>) =
    addAll(providers)

// ...

val list: ListProperty<String> = ....

list += "some"
list += listOf("some")
list += provider { "some" }
list += provider { listOf("some") }

I as a Groovy fan totally miss this. As you can already set property values with =, I would also expect += to work for list-like properties. Currently you can't do:
def listProperty = objects.listProperty RegularFile
listProperty += file 'some.file'

And having to call add() is not idiomatic Groovy for a list-like property.
Note: I would also define minus() for the -=.

Also, I'm wondering what we can do about assigning a list, as we cannot do this either:
listProperty = layout.projectDirectory.with { [file('some.file'), file('some.file2')] }

> No signature of method: java.util.ArrayList.get() is applicable for argument types: () values: []
  Possible solutions: get(int), get(int), set(int, java.lang.Object), set(int, java.lang.Object), grep(), grep()

There is a balance to strike here between usability and expectation here. We understand that those convenience methods are great during migration to the Provider API but also need to be mindful that those magic decorator (such as setting a value to a Property using =) can be confusing to beginner users. It definitely have some value as a feature even if it's a stop-gap migration one.

The work actually continues in #23637.


remove all confirmations after message posted

fixed in https://github.com/niles-bot/niles/commit/59917a35375c6efaa259c9cce8a87cc9c9009ae2


installation error

i am trying to install create-react-app using npx but it shows

Based on the provided info it's hard to help. Which version of node and npm do you use? node --version and npm --version.

Based on the provided info it's hard to help. Which version of node and npm do you use?
node --version and npm --version.

i am using the latest version of both  node v12.19.0, npx+npm  6.14.8

@rkg-37 , I would suggest you to go through this Create React App Docs


should hoax be in Vm.sol?

The following doesn't work in a test.
vm.hoax(address(0));

And I would expect it to? I see that it's not in Vm.sol, but should it be?

 Thank you.


[Bulk] Validation: fix missing descriptions II 5/26

This PR fixes 30 missing descriptions.

Docs Build status updates of commit 0754c86:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/uiref/-$-S_2148-Column-Filter-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2149-Order-By-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2150-Control-Add-ins-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2151-Namespaces-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2155-Chart-List-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2162-Error-List-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2170-Image-List-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2180-Access-By-Permission-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2181-Start-Data-Upgrade-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2182-Resume-Data-Upgrade-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_22401-Query-Designer-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2335-Open-Database-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2338-New-Database-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2339-Alter-Database-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2341-Available-Microsoft-SQL-Servers-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2342-Available-Databases-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2345-Select-Server-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2347-Available-Server-Instances-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2349-Database-Information-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2354-License-Information-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2355-Options-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2356-Application-Languages-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2401-Navigation-Pane-Designer-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2410-Create-Item-$-.md
:white_check_mark:Succeeded

dynamics-nav/uiref/-$-S_2420-Create-Menu-$-.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@buck1ey
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


Text wrap option

I think you should add an option to wrap text. I am writing a larger project report in latex using vscode and github.
However when I write latex in vscode I have autowrap text on, but when reviewing pull requests the text is not wrapped, when using this extention for PRs, I think it should at least be an option.
NB! This is related to #446 , which I think is a good idea, but im not talking specifically about the comments here.

VS Code lets you wrap text in diff editors now: diffEditor.wordWrap.


fix(*): Clarifies additional licenses based off of CNCF license list

This involved removing a dependency that we weren't commonly using or wasn't even documented in some cases (file loading a .env file in 2 providers). Things should be good to go now

I am going to override the automatic tag of host-maintainer reviewer since this most definitely doesn't touch host code. It was tagged because I removed a dep in the top level Cargo.toml, which was only used in providers


v6 chatbot - investigate why chatbot styles are being overridden in Red Hat Developer Hub

It looks like chatbot style sheets are being overridden by individual PF React component sheets in Red Hat Developer Hub. I discussed this briefly yesterday with @mcoker, @kmcfaul, and @dlabaj. It might be a webpack issue we can solve by adding a nullloader. However, their webpack configuration appears to be hidden. They are using Backstage. We should investigate further.

Backstage does not support custom webpack configuration. We may not be able to fix this. I tried switching us to @patternfly/patternfly instead of core and we still wound up with multiple imports.


Colored MOTD

I would like to look into adding color support to the MOTD system. My main reason for wanting to do this is to allow cave/nether mapping in Rei's Minimap: http://www.minecraftforum.net/topic/482147-100b181b19pre5dec12-reis-minimap-v29/
Can one of the maintainers take a look at the instructions on enabling cave mapping on that forum thread? You guys are much more familiar with the ins and outs of SimpleServer than I am. Thanks.

It seems to be broken... Cos I keep on getting:
§0§0§1§e§fWelcome to...
=[?]0[?]0[?]1[?]e[?]fWelcome to...


Update demo project to .NET 8

@MarvinKlein1508 Thank you for the PR. I'll review and test this after all other PR's.

@MarvinKlein1508 This is handled part of https://github.com/vikramlearning/blazorbootstrap/pull/670. Updated webAssembly and Server projects to the latest templates.


privacy lock - incorrect label for Android

What happened:
On Settings page, "Secure with face recognition" is displayed even though it's not active on device. When you toggle it, it shows fingerprint.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

@thedoublejay
The API provided by expo is only able to tell what types of authentications hardware supported, but not exactly the type that the user decided to use.
E.g.: samsung galaxy s21 has both face recognition and fingerprint hardware, but user can choose to use fingerprint, but expo API will not be able to return this info.
But this is only on Android devices, there isn't any device currently that support both Face ID and Touch ID hardware, so we are able to use the expo API to decide what label to use.
My suggestion:

iOS: maintain what we have done
android: replace face recognition, fingerprint, iris scan as "biometric authentication"

@thedoublejay The API provided by expo is only able to tell what types of authentications hardware supported, but not exactly the type that the user decided to use. E.g.: Samsung galaxy s21 has both face recognition and fingerprint hardware, but user can choose to use fingerprint, but expo API will not be able to return this info.
But this is only on Android devices, there isn't any iOS device currently that support both Face ID and Touch ID hardware, so we are able to use the expo API to decide what label to use.
My suggestion:

iOS: maintain what we have done
Android: replace "face recognition", "fingerprint", "iris scan" label with "biometric authentication"

I'm good with this. Let's proceed with this fix. Cc @izzycsy


Optimize some floating point operations, but maintain parity with Java

This uses mul_add in some cases, but maintains parity with Java and passes the unit tests.

Looks good now.
Thanks @julianbraha


Check over the use of --shallow-submodules when clonning the eta repo

It seems that the use of the --shallow-submodules does not clone correctly all the submodules, at least with some versions of git
As @rajcspsg reported in gitter (and tested by myself), it throws an error: Server does not allow request for unadvertised object [hash], Fetched in submodule path 'codec-jvm', but it did not contain [hash]

My git version is 2.11.1

Cloning without the --shallow-submodules option works correctly

I've updated the docs to remove --shallow-submodules. Thanks @jneira!


Add DS CI/CD workflow template

The CI/CD workflow template contains:
CI/CD principles
Example workflow for a Java project
Discuss the shortcomings of using DS to build CI/CD workflows

I'm so glad to see your practice on CI/CD, and contribute it to the Community
you can contact me through<EMAIL_ADDRESS>or wechat(my wechat id: taskflow) when you meet any problem
Welcome to join the DolphinScheduler Community!

I think you need to add a link to make this template appear in the website, please refer this doc
https://github.com/apache/dolphinscheduler-website#guide-for-adding-a-new-document
welcome to contact me if you have any question


Generated Avatars

How can I make generation of users' avatars instead using sinlge default avatar? I read docs but did not understand how to do this.

If you want generate default avatars with Gravatar, follow steps below:
0. Install django-avatar, follow steps 1, 2 and 3 on official django-avatar documentation.

Insert AVATAR_GRAVATAR_DEFAULT variable in settings.py file and set value (identicon, monsterid, wavatar or retro).  For example:

AVATAR_GRAVATAR_DEFAULT='retro'

You can read more about values on Gravatar documentation

In your html file, load template tags:

{% load avatar_tags %}

Show generated avatar on html. For example for current user:

{% avatar request.user %}

???
Profit!

In my opinion, you should use your own generator, or other open source. I'd suggest Dicebear.


supersonic.ui.navigationBar.hide() Not working on Andriod

Hi,
From the example app I modified the settings controller as follows:
angular
.module('example')
.controller('SettingsController', function($scope, supersonic) {
$scope.navbarTitle = "Settings";
    supersonic.ui.navigationBar.hide();

});

Adding only the hide() call.
On my Iphone the Navbar is hidden as expected however in all three of my Android devices the calls have no effect on the Navbar.

I'm seeing the same error on my Android phone and the Genymotion emulator. Also I've noticed that the navigation bar is always shown even if I remove the <super-navbar> element (as well as its children).

+1

I'm not able to replicate this, navigation bar (though not the black status/notification center bar) hides correctly with the API call. Can you provide a simple repro app e.g. as a GitHub repository where this happens?

@harsaharsa I think that problem appears when page is preloaded (structure.coffee file)

+1
yes this happens if you preload the webview in the structure.coffee. any suggestions to solve this problem? i need the webview to be preloaded but i dont want any navbar. only if i pop the webview with no navbar, then the navbar should come back, but this does not seem to work.

Does the preloaded WebView have a <super-navbar> element?

no it has not. also the WebViews with NavBar don't have a  element. maybe thats the problem?

+1
happens on android. Not preloading the view.  Running the hide() function in browser console works but not in controller.

This should be now fixed with Android nativ runtime v4.0.5, please update your scanner and let me know if it still perisist! If it does, I'll reopen the issue.

I am facing the same issue. I pushed a view using supersonic.ui.layers.push(view) and it automatically creates a navbar with a back button. I want to hide that navbar but supersonic.ui.navigationBar.hide() is not working on android.

@sunny061 please post your issue with example code to http://community.appgyver.com – this sounds like a separate issue from this one, and more people will be available to help you on the forums. :)

@sunny061, were you able to fix this? I'm facing the same issue using .layers.push(view) on Android.
navigationBar.hide() is doing nothing.

@marcussaad Try wrapping the code around this...
supersonic.device.ready.then( function() {
//add your navigationbar hide code here
});


Generated Key Vault v7.1-preview client

Like it says on the tin, this is the autorest-generated client code for Key Vault v7.1-preview.

Can one of the admins verify this patch?


Fix warning in PSK parsing

Description
The algorithm in RFC4279 requires 16-bit value, and nothing more than 16 bits could be obtained from combining two 8-bit values.
Therefore it would be appropriate to use uint16_t instead of possibly too wide size_t.
Then the range check (n > 65535) could go away together with the warning.
The same type change applies to ssl_cli.c, even though the mentioned check was in ssl_srv.c only.
Status
READY
Requires Backporting
NO
Which branch?
Development
Migrations
NO

@gilles-peskine-arm
Thanks for reviewing.

Or let us know if you prefer us to write it (we are picky about English and style consistency in the changelog).

That would be great if you take of that changelog entry.

Proposed changelog entry, under Bugfix:

Remove a spurious check in ssl_parse_client_psk_identity that triggered a warning with some compilers. Fix contributed by irwir in #2856.

New full CI run (internal link): https://jenkins-internal.mbed.com/job/mbedtls-pr-multibranch/job/PR-2856-merge/11/

This already has ChangeLog entry, so I'm removing the label "needs: ChangeLog".

The CI is passing, except the known-broken mbed-os test, and the API/ABI check which finds a change in PSA Crypto, so unrelated to this PR. With two approvals and a passing-enough CI, this is ready for merge.


Add support to mount OverlayFS filesystems

OverlayFS just allow to access to the content of several folders from one place, similar to how Plan9 bind mounts work. Since the underlaying content needs to be already available on the container filesystem there's no security issues here. All underlying filesystems are read-only, being the top one optionally read-write.
OverlayFS is one of the alternatives being used by Docker to implement its multi-layer scheme, so it could be easily used by vagga itself when several containers are being used by a command.

Yes. I plan to do that. The only reason it isn't done yet, is that it requires patched kernel. Overlayfs in user namespaces (i.e. by unprivileged user) is not supported by mainline kernel. Ubuntu has a patched kernel for that.

Didn't know it needs a patched kernel to add support for that, I thought it would only be a matter of define capabilities or something similar, but in any case good to know that's possible :-) Knowing that, I'll mark this as done on NodeOS and do a release-candidate waiting to get this issue fixed to finish it there :-) Thanks a lot! :-D


Fastnlight: Watch stallmansupport.org

Fastnlight requests the watch of the watch_keyword stallmansupport\.org. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

stallmansupport\.org has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Cow in Charcoal HQ


Single-quoted string in uaa.yml.erb fails to interpolate variable

Commit 286bad8da2d1a73bf17bee5cf7cc6c1d359471e7 replaces double-quotes around the zone "login.#{domain}" with single quotes. Since this is inside ruby code, it breaks UAA.

PR https://github.com/cloudfoundry/uaa-release/pull/33


Configure Protocol Muxing sequence

With https://github.com/libp2p/js-libp2p/pull/166/files, the libp2p constructor will be fully refactored and with it comes the option to pass a Protocol Muxing sequence.
My proposal is on communicate this is on https://github.com/libp2p/js-libp2p/pull/166/files#r193032278, however, I'm not married to that solution just yet. Example below:
protocolMuxing: {       // Protocol muxing sequence. libp2p uses sane defaults (below). You can override these with:
  transport: {
    secio: {
      spdy: '*',        // '*' means, from this point forward, accept any protocol
      mplex: '*'
    }
  }
}

This is now an array in the config and it will prioritize based on the order, although we currently only support mplex.