Keyboard focus going on hidden elements in smaller resolutions

Describe the bug
When Navigation items are opened on smaller resolutions and keyboard is used for navigation elements on the page then focus goes to page elements (which are actually hidden) after nav list.
To Reproduce
Steps to reproduce the behavior:

Go to https://accessibleweb.dev/ (in mobile view)
Click on hamburger menu icon on top right
Use keyboard to navigate through focusable elements
Focus will move to hidden elements after completing nav list

Expected behavior
Focus should not move to hidden elements.
Recording
https://github.com/AccessibleForAll/AccessibleWebDev/assets/17885747/7f25aeb7-878f-4b56-8f50-5d6b10c3d4ee

Hi @SatyamSetia thanks for noticing the issue. Since this is not a modal element it does not need to hold the focus and the page content should remain in the DOM. A better solution would be that the mobile menu closes when the last element is tabbed out of. This is how the theme picker element behaves. I will assign you.

Acknowledged 👍


Pickaxe not the effective tool anymore on stone blocks and alike

When i enable this mod, there seems to modify the blocks somehow?
pickaxe is useless agains all stone blocks.
Note,
i have commented out "EldritchMobsBlocks.init();" and i run this mod on server side only.
any ideas? :)

I wasn't able to replicate this error, are you using the latest version of Eldritch Mobs?

Yeah, i downloaded the latest comitted version here on git and made myself a new jar after commenting out that line.
It works when i use the regular file downloaded from curse

That's a bit strange. Just to clarify, the version you downloaded from curseforge is working normally but the version that you built from the latest committed version on GitHub doesn't?


No real documentation anywhere, project dead or alive?

The last commit was years ago and there has not been ANY recent activity. I tried mailing the developers but was ignored. Is this project even alive? There is no documentation. The 'readme' and 'readme-developers' both did not have any info. The Documentation folder was absolutely useless too. Where can I get a list of all the bits functions and classes with what they do? Is there any documentation or help for people that want to use this project? Or has this project been abandoned?

I know that this project was meant to be a tool to test BIOSes, but I am actually trying to use it to code an Operating System of my own using only python. But I can't find any instructions anywhere on how to use the different modules bits has, like efi. What all functions and classes are there? What do they do? How to use them? Nothing. I read ALL the code but there are very few comments and the code is quite messy. Please, help!

Maybe us 3 can figure it out together.


schedule run failure issue but manual run ok (failed to write record with work unit - HTTP Status:500) - ingestion tried to run twice at once.

Describe the bug
every day I observe the same error when normal ingestion completes with errors but after manual startup everything turns green.
There is no same time run alredy but ingestion try to run twice and goes to falues on both due to unable to write twice at a time.
To Reproduce
Steps to reproduce the behavior:

Go to ingestion at the morning

Click on ingestion logs

Scroll down to 'error'

See error
    '⏳ Pipeline running with at least 1 failures so far; produced 40 events in 19.18 seconds.\n'
    '[2023-01-16 22:00:58,266] ERROR    {datahub.ingestion.run.pipeline:62} -  failed to write record with workunit '
    'container-urn:li:container:78b34191380acf4a4b739734d71b8348-to-urn:li:dataset:(urn:li:dataPlatform:s3,datalake%28EDL%29.edp-edl-prod/data/parsed/lms/transaction,PROD) '
    "with ('Unable to emit metadata to DataHub GMS', {'exceptionClass': 'com.linkedin.restli.server.RestLiServiceException', 'stackTrace': "
    "'com.linkedin.restli.server.RestLiServiceException [HTTP Status:500]: javax.persistence.PersistenceException: Error when batch flush on "
    'sql: update metadata_aspect_v2 set metadata=?, createdOn=?, createdBy=?, createdFor=?, systemmetadata=? where urn=? and aspect=? and '
    'version=?\\n\\tat com.linkedin.metadata.restli.RestliUtil.toTask(RestliUtil.java:42)\\n\\tat '
    "com.linkedin.metadata.restli.RestliUtil.toTask(RestliUtil.java:50)', 'message': 'javax.persistence.PersistenceException: Error when "
    'batch flush on sql: update metadata_aspect_v2 set metadata=?, createdOn=?, createdBy=?, createdFor=?, systemmetadata=? where urn=? and '
    "aspect=? and v', 'status': 500, 'id': "
    "'urn:li:dataset:(urn:li:dataPlatform:s3,datalake%28EDL%29.edp-edl-prod/data/parsed/lms/transaction,PROD)'}) and info {'exceptionClass': "
    "'com.linkedin.restli.server.RestLiServiceException', 'stackTrace': 'com.linkedin.restli.server.RestLiServiceException [HTTP Status:500]: "
    'javax.persistence.PersistenceException: Error when batch flush on sql: update metadata_aspect_v2 set metadata=?, createdOn=?, '
    'createdBy=?, createdFor=?, systemmetadata=? where urn=? and aspect=? and version=?\\n\\tat '
    'com.linkedin.metadata.restli.RestliUtil.toTask(RestliUtil.java:42)\\n\\tat '
    "com.linkedin.metadata.restli.RestliUtil.toTask(RestliUtil.java:50)', 'message': 'javax.persistence.PersistenceException: Error when "
    'batch flush on sql: update metadata_aspect_v2 set metadata=?, createdOn=?, createdBy=?, createdFor=?, systemmetadata=? where urn=? and '
    "aspect=? and v', 'status': 500, 'id': "
    "'urn:li:dataset:(urn:li:dataPlatform:s3,datalake%28EDL%29.edp-edl-prod/data/parsed/lms/transaction,PROD)'}\n"

Expected behavior
Scheduled run - runs as manual run with success results once at a time.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
I observe it on each shcedule run on each ingestion. at the moment, the error is observed in 19 ingestions.
Maybe there is a some bug fix solution? does anyone know?

The "status 500" indicates that our GMS backend is getting overwhelmed by all of the requests. I'd recommend staggering your ingestion runs a bit so that they don't overlap.
You can also try setting the rest sink's retry_max_times config option to add retries

thanks @hsheth2 I will try retry_max_times soon

@hsheth2 I doubt that the problem is overloading and starting at the same time.
i tryed to run all the ingestion manual at once and during some time it is all green.

last two runs takes takes a bit more time but iam sure it will be green.
I think problem only is in schedule run and in an attempt to write the same object at the same time.

two last logs...
exec-urn_log_success_manual_run.log
exec-urn_log_with_error.log

@hsheth2 any ideas?

The 500 error indicates that our backend system is getting overwhelmed by the volume of metadata your ingestion source is producing. Having multiple ingestions running at the same time is likely the reason for it. If this is truly blocking you, you can try using the kafka sink instead of the rest sink for better scalability.
I'm going to close this issue for now, but feel free to ask additional questions here or on slack.

@YuriyGavrilov  reported that he is using a single GMS instance with no standalone consumers and seeing double schedules.

link for slack https://datahubspace.slack.com/archives/C029A3M079U/p1675153278034129

fresh case

There was recomendation to turn off MCE and  MAE https://app.slack.com/client/TUMKD5EGJ/C029A3M079U/thread/C029A3M079U-1675153278.034129
"
we have
- name: MCE_CONSUMER_ENABLED          value: 'true'        - name: MAE_CONSUMER_ENABLED          value: 'true'
if you have MCE and MAE running separatly, disable them on gms."
After disabling schedul starts to work properly


Remove tabIndex with a better document structure

Description
Closes #1713
Removed tabIndex from the project. To retain focusability, non-interactive elements got mostly replaced by buttons, some by other interactive elements.
Additionally some missing focus and other css styles were added.
Changelog
Use this list to see detailed information about the respective file/component. As stated above it is mostly removing tabIndex, refactoring the structure and adjusting css to the structure or adding focus styles.

BoardHeader

refactor css
remove tabIndex

Participant in ParticipantList

remove tabIndex
highlight on focus

BoardUsers

fix structure

Column

refactor and remove dead css
remove tabIndex
change structure to focus noteInput first and columnSettings afterwards
adjust test to structure

ColumnSettings

remove tabIndex

DotButton

remove tabIndex

Dropdown/*

removed due to not being used and having a overly complex structure

MenuBars

remove tabIndex

Note

use button instead of div
remove tabIndex
add some missing css
adjust test

NoteDialogNoteContent

adjust css
replace blockquote by textarea

NoteInput

refactor css
add outline on focus
add tabIndex for addButton to skip focus on tab; remove remaining tabIndex

Appearance

move code for themeSettings into own file
add useTranslation hook to update language automatically

LanguageSettingsDropdown

replace static language selection with dynamic selection and new dropdown component

SettingsDropdown

(hopefully) a generic dropdown component visually identical to the old languageSettingsDropdown

ThemeSettings

moved from appearance component to own file
removed tabIndex
add css on focus

ToggleButton

remove tabIndex
replace disabled attribute by aria-disabled to allow focus while disabled
adjust test

TooltipButton

show tooltip on focus
change css to improve visibility
remove tabIndex

AddButton / RemoveButton

remove tabIndex

Votes

remove tabIndex

style

change icon--medium size from 22px to 20px due to most use icons have a size 20px

tabIndex

removed

Board

remove tabIndex

Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] The light- and dark-theme are both supported and tested
[x] The design was implemented and is responsive for all devices and screen sizes
[x] The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

Note: Safari doesn't support border-radius on outlines with solid style, which is required for a custom color
Note: Neither does Safari support focus onClick which will then trigger a onBlur event

(Optional) Visual Changes
Old: Chrome Desktop dark:
board
https://user-images.githubusercontent.com/44020029/189072629-3d962837-51a2-420d-b544-9fcdd5d08a37.mov
noteDialog
https://user-images.githubusercontent.com/44020029/189072900-c2ca11fb-731e-4d35-b6f7-2937cc8d878e.mov
appearance
https://user-images.githubusercontent.com/44020029/189074120-fd6eec8b-083a-4b05-927e-2694dbdeb063.mov
New: Chrome Desktop dark:
board
https://user-images.githubusercontent.com/44020029/189072319-f43ab0e2-735d-4aeb-b5ad-3ad83c310e05.mov
noteDialog
https://user-images.githubusercontent.com/44020029/189072762-1dba93af-4ffb-4e32-bb40-750adb387d41.mov
appearance
https://user-images.githubusercontent.com/44020029/189074279-94060cfd-6903-472d-961e-712393d8702e.mov

Looks good and works smooth - one minor nitpick: The close button of the side menus as a wrong focus style, or?

This is due to firefox making the scrollbar accessible. When pressing space, the page is scrolling (shift+space is in reverse direction). I'll look into what's best practice about this, but will for sure change the outline.

And last but not least which is probably not directly related to your changes, but if you have time you can check this too:
Screen.Recording.2022-09-08.at.13.41.45.mov

Oh wowsie, this is great 😍 :P

@Dominik-Weinzierl the issue is linked to the confirmationDialog not having a  wrapper. Afterwards the focusLock works. Alternatively the focusLock can also be used inside the confirmationDialog component. I like the first one more because it solves problems with the confirmation of the board deletion inside the boardSettings.
Other than that, every noted issue is resolved.

mhm, i was still able to tab out of the leave board screen 🤔
In addition, i noticed another minor nitpick :)


Question - Different Encryption Algorithm

hi again @mbdavid, it's always a pleasure to talk to you.
Quick question: Is it possible to change the encryption algorithm for litedb? If the answer is yes, how? can you provide a quick example how this can be implemented?
Not the algorithm itself, just how to achieve this purpose.
thanks a lot.
regards,
[],
@rmszc81

Hi @rmszc81, it´s always good to know dev are keep using LiteDB :)
Encryption, in LiteDB are based only in this class: https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Utils/AesEncryption.cs
Works with a simple password and salt (bytearray). All pages (except HeaderPage - PageID = 0) are encrypted using this "Encrypt"/"Decrypt" methods. Its important encrypt output keep same input size (4096 bytes)
But there is not way to change because there is no interface to implement. You need change in code base.

Sorry for answering so late.
As we say in brazil "correria".
It'll be awesome if someday you expose an interface for us to implement our own cryptography algorithm in LiteDB but, for now, what you implemented is more than enough.
Thanks a lot.
Regards,
[],
@rmszc81


Fix Typos

I'm learning PyTorch and I fond those typos in your documentantion. Pretty Nice your work!

Thank you!


Improve mark widget tip style

I find the current style looking a little bit weird, so I tried to improve it a little bit, see comparison below.
Before:

After:

Thanks a lot for the effort! This does indeed look a lot better. The improvements you made should now be available in v2.14.6.


configurable private trie cache in extra ATs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How to use SSR and RSC for multiple GraphQL servers?

I have a multiple micro services that each one of them expose different graphql api, how can i use them using this package API? should I make two ApolloWrappers? If so, would it mess up with the cache system? How can I decide when using query from which server it should try to request the data from?

Hey @Tsimopak 👋
Unfortunately using multiple clients to stream data isn't a pattern that is supported in this library, nor do we have plans to support this at the moment. While you'd be able to instantiate multiple clients on the server, the streamed responses aren't guaranteed to hydrate into the right client instances in the browser, so you'd end up with a mess of data in your client instances in the browser.
One option might be to only run these queries in the browser and avoid running them in SSR to prevent streaming from kicking in.
If you're ok with data being mixed from each GraphQL API, its possible to use a single Apollo Client instance that writes into the same cache. Use context in this case so your query fetches from the right GraphQL endpoint. HttpLink has the ability to read the uri from context, so this would give you control for an individual query to specify where to fetch it from.
useSuspenseQuery(QUERY, { context: { uri: "https://endpoint-a.com/graphql" }})

I just want to highlight a danger here though in case you want to consider this route. Overlapping __typenames between the different GraphQL APIs have the potential to overwrite each other in the cache, especially if they happen to share the same ids. I'd be really cautious and check for this in case this would present a problem for you.
The best option would be to write your own GraphQL schema that is able to consolidate the multiple APIs into a single schema and query against that. I don't know if you have control over those other GraphQL APIs or not, but Apollo federation might be an option for you if you do.

@jerelmiller Thanks for your response!
Ohh that's very sad to hear that, isn't that a common use case to have multiple micro services? well, with Rest API it is.
By using federation I essentialy assume that a certain service must be alive to fetch all of my queries, which in my system is not guranteed. so I can't use that as well.
I do have overlaps in type names among different services.
If I would have used vite instead of next js, I could have used the main library which does support that?

I probably should step back a bit. I assumed you were referring to client components in your original issue description, but now I'm questioning if I read it wrong 😆. Are you running these queries in server components or client components?
If server components, multiple clients should be ok here simply because these clients are never instantiated in the browser and the cache is never shared with your client components. The caches for these clients only exist for the duration of the request.
If client components, then everything I've said still applies since we stream cache data from your client instances from the server to the browser as data is loaded.

Ohh dang it haha I really hope you guys would consider to add it as a feature

Its extremely complicated to develop a streaming solution that is able to hydrate streamed data from specific client instances on the server to specific client instances in the browser since you're passing over the network boundary.

Can you elaborate what does it mean to run the queries in browser?

I just mean that you can detect if you're running in the server/browser and only render your query components if they are rendered in the browser. One trick to get this to work is to use useSyncExternalStore to detect when you're on the server. Check out this blog post for a technique here.
The downside here is that you lose out on the benefit of loading that data on the server and have to wait for the page to be hydrated before those queries are kicked off.
That said, using multiple clients only in the browser is ok from our perspective because there is no streaming involved here.

If I'll change my the type names of my other service, and use all of my micro services under the same apollo client instance, you don't see a problem doing so with the context you suggested?

I'll be cautious in saying that I "don't see a problem" because you may very well face some interesting challenges. I'm just saying that having unique type names across your different GraphQL APIs helps alleviate a potential issue where using a single client with multiple GraphQL endpoints could end up merging data from each endpoint into a single object record in the cache. This is problematic because data could accidentally overwrite each other that should otherwise be siloed.
Again, I'd recommend taking a look at Apollo Federation as a way to create a unified supergraph out of your underlying subgraphs. GraphQL is best used as a single unified API. I obviously don't know your architecture though and am sure you have great reasons for splitting up your GraphQL APIs into several microservices. I'd just advise taking a look at tools like Federation that help with this kind of architecture across several GraphQL microservices.
Hope this helps!

Thank you so much for the detailed answer, I'll keep this thread open a bit longer for future questions i might have

@jerelmiller About your suggestion to use Federation, a fundamental draw of federation is avoiding Database per service, which means, there's dependency between services, which in my case some services may be down at any given time.
So federation is not an option for me, I could use federation just to wrap all graphql servers together, but what if the gateway will go down? i prefer that each service will be responsible for its own data, I could do it purely to work with this package, other option is to fallback to RESTful api or RPC, but I think that GraphQL is still beneficial even without federation

Just to clarify, I'm not saying you have to use federation, I'm just suggesting that it might be a nice tool for your situation in case you weren't aware of it. You're best qualified to figure out what is the optimal server architecture for what you're building, so respectfully, I'll bow out of that part of the conversation.
Let me know if you have any other questions, otherwise I'll go ahead and close this issue 🙂

Thanks jerelmiller for the help :D No issues so far i'll open a new ticket if i'll get one. thanks for the approaches u suggested


registerApolloClient should only be used in a React Server Component context error when trying to call a Server Action in a Client Component

Greetings!
I have a Server Action in a separate file that uses the getClient function described in the "In RSC" segment of the readme. As per NextJS documentation it has the 'use server' directive at the top.
I'm trying to call this action in a Client Component using the useTransition hook, but I get the "`registerApolloClient` should only be used in a React Server Component context - in Client Components, use the `ApolloNextAppProvider`!" error.
As far as I understand I definitely am in the Server Component context though. If I monkey patch out the check for React.createContext in registerApolloClient.ts my code seems to function correctly.
Is this a bug or am I doing something I'm not supposed to do?

Hi @ramivalta,
unfortunately, Server Actions are yet another environment that is different from React Server Components. (Middleware are another, and then of course, Client Components).
I would suggest that you just call the createClient function that you are passing into registerApolloClient from your server actions - as they run in a different environment, it's impossible to share a client between RSC and SA anyways.
It might be possible in the future to use getClient in Server Actions, but at this point that's not the case.

Hi @plausible-phry ,
If I want to do a query in Middleware, should I use the same approach as in Server Actions? What cache should I use, NextSSRInMemoryCache or InMemoryCache?

@tonnguyen you're not doing SSR, so you'd use a normal InMemoryCache :)
I believe by now it should also be possible to call getClient, but I'm not 100% sure on that.

I got "React.cache is not a function" error when using registerApolloClient in Middleware so I guess it is not possible.
Thanks!

@tonnguyen Good point. Yeah, then you'd just call the same createClient.


Fix monster illustration width

@keybase/react-hackers CC @keybase/design

[ ] cherry pick

Before:

After:

added some tablet-only bottom margin per Cécile:


New Apps frozen

New Apps have been added to Flathub in the last Days, but they don't appear in the new Apps list. The list hasn't been updated for Days.

Basically a duplicate of https://github.com/flathub/website/issues/1636


Store the last history action

In order to customize and trace history in app, I suggest synchronizing the location and the last history action given by the history.listen  callback.
See https://github.com/ReactTraining/history/blob/master/modules/createBrowserHistory.js#L86

What is the use case for this?

@timdorr to synchronise a data structure (typically a stack) in a reducer with the stack data structure of the history API.

Yes, but why do you need to know that? The location contains all the info you should need to render.

I need to know what direction the user navigated in (PUSH or POP) so I can push or pop stuff on or off a stack.

Why aren't you just asking history directly?
Sorry if I'm coming across as stubborn, but I worry when folks want to force a library into the semantics of Redux, which may be contradictory in places. For instance, the back button. Or you could have some sort of navigation blocker. Or an even more complex case. It gets messy really quickly, and is one of the chief challenges of rrr. So, if we can encourage folks to go directly to history and use it's semantic model, everyone will be much happier.

OK, but how would I do that with history? It's hidden away as a dependency.

In rrr, you create your own history. Our pre-configured Routers just create a history and return a <Router> with it applied. So, getting access to the history instance is easy (it's also available on context or as a prop with withRouter).
From there, you can get access to any of the properties of history, which includes the entries you're looking for.
I'm going to close this out, since this should be accessed via that path, rather than redux.

I wouldn't use history from the context. Having the history action at the time of the location change gives me confidence about when i can use it without exposing history object somewhere else. I could even enhance rrr actions or middleware but it's too overkill to get the only useful information about what's happened to the history. I wouldn't either do a lookup in the entire history since i can have a way to access the previous state.


Capture is over bright / over saturated

Capture from many laptops is over bright / over saturated.
The root cause seems to be the Byte 23 - "Display gamma, datavalue = (gamma*100)-100 (range 1.00–3.54)" (see https://en.wikipedia.org/wiki/Extended_Display_Identification_Data).

@xfxf tried to fix this problem at https://github.com/timvideos/HDMI2USB-misoc-firmware/commit/d2cbd1dd14d42fb786c8798df7deff7bbbe4eebe and https://github.com/timvideos/HDMI2USB-misoc-firmware/pull/205

This fix seems to crash gnome-shell somehow?

I found the documentation for the Generic RGB Profile that we normally use for Macs at conferences - https://developer.apple.com/library/content/qa/qa1430/_index.html
It specifies that the gamma is 1.8, which is 0x50 in EDID terms.

@xfxf  & @joeladdison - I believe this is fixed now? Reopen it if it isn't...

@mithro & @xfxf Yes, I think this has been fixed now. I changed the gamma value and it seems to have improved the capture brightness.

I've not noticed any problems, before it was super obvious, so I believe fixed, yep.


feat(injected): add avalanche core wallet

Description
Add support for https://www.core.app/
Core Wallet is detected as metamask: when it's installed, bothisMetaMask and isAvalanche are set to true (I believe it's similar to brave wallet).
Additional Information

[X] I read the contributing docs (if this is your first contribution)

Can we add a changeset for this?
pnpm changeset & make this one a patch!


Allowing search to be disabled for anonymous users. [Fixes #6473]

I may be wrong, but this looks like if it were merged as it is then AllowAnonymousSearch will default to false which will cause a breaking change to sites that already have search in place.

@JRKelso, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Following the issue.


Can't update prettify for the theme

Hi,
In the past i was using <script src="https://google-code-prettify.googlecode.com/svn/loader/run_prettify.js"></script> tag in default.hbs file to be able to highlight code syntax. Now, this file is absent from googlecode.com and i was trying to update it with <script src="https://cdn.rawgit.com/google/code-prettify/master/loader/run_prettify.js"></script> tag, but when i update my default.hbs file, posts still load old tag and code doesn't get highlighting. Any ideas on where i'm looking wrong ?

I don't know how prettify works, but basically you need

disable the uno-zen code highlight (css and js)
Link your code pretty

And how can i disable uno-zen code highlight ?

Remove:

https://github.com/Kikobeats/uno-zen/blob/master/gulpfile.coffee#L49
from the build

Remove:

https://github.com/Kikobeats/uno-zen/blob/master/assets/scss/modules/_prism.scss
https://github.com/Kikobeats/uno-zen/blob/master/gulpfile.coffee#L49

from the build

Thanks.


Upgrade Laravel version to 11.x

Laravel version
Laravel version has been upgraded to 11.x. As a prerequisite, sanctum has been updated to 4.x with other dependencies.
Remove support for PHP 8.1
Laravel 11.x now requires PHP 8.2.0 or greater. That's why support for PHP 8.1 has been removed. Also, test workflow now supports PHP 8.3.
Update actions/checkout
actions/checkout v2 uses older version of Node.js trigger this below warning.

It has been updated to v4 to remove the warning.

Ping @hasinhayder bhai.


Added GSB documentation

Adding documentation for general switch box XML files

Motivate of the pull request

[ ] To address an existing issue. If so, please provide a link to the issue:
[ ] Breaking new feature. If so, please describe details in the description part.

Describe the technical details
What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[ ] OpenFPGA libraries
[ ] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[ ] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

@ganeshgore Remember to update the doc on the new syntax in #618

@ganeshgore Can you rebase this on the current master? #747 may not be merged soon. We can merge the doc update very soon. Please check the options in #751 and update documentation accordingly.

Ok, I need to update the documentation based on your PR+ additional syntax. I will do it soon and rebase


Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision)

https://github.com/flutter/engine/compare/f77664330122...7c2a56a44b41
2024-03-10<EMAIL_ADDRESS>Roll Skia from 8b92038ff67f to e6b884229d2d (1 revision) (flutter/engine#51316)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add dev build of Package

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I tried to follow CFEP-05 - hopefully I didn't forget anything 🤞🏻

This would close https://github.com/brightway-lca/brightway-hub/issues/19

Furthermore it seems the requirements are out of date for the dev version

Hmm... I'm seeing a test failure:

TESTS FAILED: bw2data-4.0.dev21-pyh526c96b_0.conda

I just updated the requirements according to match the setup.py of the latest dev version. Let's hope this resolves the issue.

@conda-forge-admin, please rerender


lightbox: Use a friendlier format for the date, like "Yesterday at 4:47 PM"

…or "A few seconds ago", etc.
Currently it shows something like "Mar 31, 2023 15:09:51".

Sure. Do see our guide to picking an issue:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on
so in particular before claiming an issue, you should have already gotten started working on it, finding the relevant piece of code and getting an idea of how you'll approach it.
Also note this issue is in the "Post-launch" milestone, not "Launch" or earlier. That means the core team will have limited time to spend helping with this issue for the next few months. But I think the issue is simple enough that that should be fine.

@gnprice I had a shot at this issue and is the result
The device i am using is my Techno Spark 7 - Android 11
Here is the result, the time stamps were changed to a more readable date format

Before making a PR, I would like to verify if a change like this would require that tests be made or updated? since i just added a method to the widget to format the date.

Hello, I have worked on the issue, Please review the changes and let me know if anything else is required.
@chrisbobbe


Feature: cmake config

This PR adds the generation of CMake package config files to the build process, allowing proper builds within catkin workspaces and on non-linux systems.

Oops, meant this for my fork.


Use "kubernetes.io/os" in the dns/ingress node selector description

Replace "beta.kuberneta.io/os" with "kubernetes.io/os" in the dns/ingress node selector description.
follow-up to  https://github.com/openshift/api/pull/870
@Miciah  Could you please take a look? thanks.

Thanks for fixing this!
/lgtm

@deads2k @sttts Could you please take a look? thanks


Access to a browser global variable on window after each step

What are you trying to achieve?
I want to add code coverage to my codecept stack. For that, I manage to make istanbul to fill the window.__coverage__ variable with the coverage informations.
My goal is to access this variable so I can build the coverage report from it.
I made a Coverage Helper and try to access the browser's window global variable in the _after() hook:
'use strict';
class Coverage extends Helper {
  _after() {
    this.helpers['Nightmare'].browser.evaluate(function () {
      console.log("this will not show", window)
    })
  }
}
module.exports = Coverage;

How would you do to access the window variable in the _after() method ?
Details

CodeceptJS version: 1.0.3
NodeJS Version: v6.11.4
Operating System: os X Sierra
Nightmare: 2.10.0
Configuration file:

{
  "output": "./output",
  "helpers": {
    "Nightmare": {
      "show": true,
      "url": "http://localhost:8000",
      "waitTimeout": 30000
    },
    "Coverage": {
      "require": "./coverage_helper.js"
    }
  },
  "include": {
    "I": "./steps_file.js"
  },
  "mocha": {},
  "bootstrap": false,
  "teardown": null,
  "hooks": [],
  "tests": "./src/**/*.specs.js",
  "timeout": 100000,
  "name": "frontend"
}

I answer to myself: executeScript is the way to go.


gitlab CI

start to setup script for ci of the combine core.
https://gitlab.cern.ch/cms-hcg/performances
https://gitlab.cern.ch/cms-hcg/performances/ci/pipelines

@nucleosynthesis , can we merge this one, so we will try to keep track of how the other changes.


Development Environment/CONTRIBUTING

Would you post your set up development environment and/or recommendations for contribution? Coming from pure C99+Clang, having some trouble setting up a workable environment with your c(++?) files.
This is related to creating a fix for the segfault that occurs if login is called outside of the immediate directory.

All the things here are kept very simple, the source of the login app is only the login.c, I use vscode personally to do my changes and build with make

Interesting. I must be missing some libraries.
Thanks.

If you already installed hearthstone successfully with the craft script, you should actually have everything you need as it includes the building of the login app :thinking:
and regarding the path sensitive segfault you describe, I'm wondering a bit what problem you faced, actually it only creates the token file in the current working directory which is why you should actually run it inside the hearthstone directory where it is expected to be present

You are right, I do. I needed to put together a g++ configuration for the language server to be usable and g++ is a little different than my usual Clang (and it got confused by the .c, rather than .cpp extensions). Switching to .cpp and using the below c_cpp_properties.json file appears to have done the trick for now. By default, the includes are not searching/adding recursively as I didn't find I needed it in bare C.
{
    "configurations": [
        {
            "name": "Linux",
            "includePath": [
                "/usr/include/c++/12",
                "/usr/include/x86_64-linux-gnu/c++/12",
                "/usr/include/c++/12/backward",
                "/usr/lib/gcc/x86_64-linux-gnu/12/include",
                "/usr/local/include",
                "/usr/include/x86_64-linux-gnu",
                "/usr/include",
                "${workspaceFolder}/**",
                "/usr/include/gtk-3.0",
                "/usr/include/webkitgtk-4.0",
                "/usr/include/glib-2.0",
                "/usr/include/libsoup-2.4",
                "/usr/include/cairo",
                "/usr/lib/x86_64-linux-gnu/glib-2.0/include",
                "/usr/include/pango-1.0",
                "/usr/include/harfbuzz"
            ],
            "defines": [],
            "cStandard": "c17",
            "cppStandard": "c++14",
            "intelliSenseMode": "linux-clang-x64",
            "compilerArgs": []
        }
    ],
    "version": 4
}

As for the segfault, yes, the code currently works if run from the specified directory. It segfaults at the login.c:56, the fwrite I'd like to see if I can make it more flexible, but will have to come take another look after work.

Ah okay, this makes sense, if you run the app from some other directory without write permission, the fopen and fwrite will fail. Would possibly be smarter to make sure to write the file into the directory in which the app itself is located, then you can run it from everywhere, but remember this is only a one-shot app, once you have the token, you never need to run it again


[Redux] Pop current route after the store has changed ?

Hi @brianegan ! First, thanks a lot for all your work on Flutter! That's amazing and very helpful!
I am currently developing an app in Flutter for a client and I chose the redux way... I currently have a little trouble to manage the navigation.
Let's say I have a home screen with a Login button. The button simply ask the navigator to push a named route /login. The login screen has a form and a StoreConnector with a converter that returns a store.dispatch(LoginAction(formData)). The LoginAction is caught by a specific middleware that will swallow it, do the asynchronous login and finally dispatch a UserIsLoggedInAction to the store.
How can I do this in the login screen itself, since it is something totally asynchronous ?
What is then the best practice to make the login screen pop?  Should it be triggered by the middleware? If so, it means that I need to inject a GlobalKey<NavigatorState> key in all the middlewares that can potentially change the routes?
It feels a bit fragile to me. I've read on some other threads that we're better off not including the navigation in the app state and let Flutter do its thing with the Navigator, but I am confused on how to synchronize both worlds in terms of navigation, current screen, etc..
Any advice ?

Ok, I took a look at one of your example about a refresh indicator and I tried to use a Completable action.
In my screen that handles the login form submission, I have this StoreConnector:
StoreConnector<AppState, VoidCallback>(
  converter: (store) => () {
    final completer = Completer()
      ..future
        .then((_) => Navigator.of(context).pop())
        .catchError((e) => print("Error $e"));

      store.dispatch(LoginAction(completer: completer));
    },
    builder: (context, callback) {
      return RaisedButton(child: Text("Login"), onPressed: callback);
    }
)

So that works, the login screen is correctly popped when the action completes. Do you think it's a valid pattern? I've also come across the redux_future package but what I am looking for is more like an action side-effect, that is executed when an action is completed.

Hey @nashfive! Yep, that totally works. In fact, I sometimes think it's a better approach because it keeps all of the "View Logic" contained in the View Layer (e.g. the Widget Layer), and allows the Middleware to be free of any such concerns. They can just concern themselves with doing the work they need to do to talk to the backend / database / whatevs.
Another option could be to create a single NavigationMiddleware that handles listens for actions of a certain type and then performs the correct Navigation. That would prevent you from needing to spread the GlobalKey<NavigatorState> in different middleware.
Overall, this is one of those areas where Flutter requires a bit more work -- it's reactive in many places, but the Navigator is imperative. You might notice similar tricky spots when you try to use sync other imperative classes, such as TextEditingController or TabController in combination with Redux (or any stream-based / reactive architecture).

Hi @brianegan and thank you for your answer!
I tried to go the "middleware way", but I wasn't sure how I could fit this in a nice redux way. I would need to manage 4 or 5 actions (2 for push/pop, 3 for login/onSuccess/onFailure) and since my middleware would not update the state, it seems overkill and the Navigator is indeed my middleware ;-)
In the end, I agree that the Navigator could really use some more work. Until then we have to resort to that kind of tricks... Let's see how it evolves.


A fj

A fun thing to add would be elytra fly so it can deliver faster :D

Thx for the idea, we are working on this at the moment, but it's somewhat difficult because it's not "officially" supported by mineflayer. There is a pull request from a different user that we are trying to implement. We will keep you updated!
If you have any more suggestions please post them!

There is also mineflayer-elytrafly but its also easy to make it on your own just make it fly and then use phisics to push it forward and it will fly where it looks so in sky and then fly to coordinates while being in sky then land slowly i recommend elytrafly tho

it would also be nice if it kills itself using /kill or just walk into lava or something so it cant get tracked to base

There is already an implementation for a self destruct. There is also a nice pull request that adds support for elytrafly. Also we are working on adding an user interface (web) to the bot as an option to the terminal


Misleading error message on 403 for messaging.Client().Send

[READ] Step 1: Are you in the right place? yes
[REQUIRED] Step 2: Describe your environment

Operating System version: macOS 10.14.3
Firebase SDK version: 3.7.0
Library version: 3.7.0
Firebase Product: messaging

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

Make a request to send a notification that fails with a 403 error.
The error message will be "http error status: 403; reason: sender id does not match regisration token; code: mismatched-credential; details: The caller does not have permission", regardless of the cause of the error.
Other ways you can trigger this:

Try to make a request with a service account with invalid permissions

Set the project-id wrong accidentally.

The "sender id does not match regisration" confused me for a while (it's also miss-spelt luckily so I was able to figure out that this was not a real error from the server). It turned out in my case to be that the service account I was using didn't have the right scopes.
Relevant Code:
app, _ := firebase.NewApp(ctx, nil)
m, _ := client.Messaging(ctx)
_, err := client.Send(ctx, message)
fmt.Println(err)

This is the error sent by the server in this case:
{
  "error": {
    "code": 403,
    "message": "The caller does not have permission",
    "status": "PERMISSION_DENIED",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.DebugInfo",
        "detail": "..."
      }
    ]
  }
}

We map PERMISSION_DENIED to the above error message, but also include the error detail sent by the server (The caller does not have permission).
@chong-shao should we use a different error message for PERMISSION_DENIED? Note that this mapping has been adopted from the Node.js SDK, where we have been mapping PERMISSION_DENIED to MISMATCHED_CREDENTIAL for several years.

Hi @hiranya911, for this case can we forward the error details from the server without adding extra error messages in AdminSDK?

We currently add an error message for all errors using some shared code.
https://github.com/firebase/firebase-admin-go/blob/c9b5e064033ed12864bf07d9bb34249087617130/messaging/messaging.go#L837-L847
Special casing an error code is going to require some work. This will get better/fixed once the new error handling proposal (go/firebase-error-handling) gets implemented. In the meantime, I think the easiest solution would be to update the common error message to something less ambiguous.

Fixed in the v4 branch along with the error handling major refactor.


Indexing stuck at encoding passages

I have a huge collection of 116 million passages. I am trying to create a colbert index for them using the indexing code given on the README. To manage the huge size, I am indexing them in batches of 1000 passages. However, the indexing step seems to be stuck at the encoding stage:
2024-07-09 09:15:44,053 - INFO - Rank 1: Completed store-based barrier for key:store_based_barrier_key:1 with 2 nodes.
[Jul 09, 09:15:50] [1]           #> Encoding 999 passages..
[Jul 09, 09:15:50] [0]           # of sampled PIDs = 2000        sampled_pids[:3] = [853, 1500, 20]
[Jul 09, 09:15:50] [0]           #> Encoding 1001 passages..

Is this supposed to take so much time? Not sure if I am doing something wrong.

@okhat

It shouldn’t get stuck — so if it does that’s odd. But don’t index in 1000 passage batches. Index maybe 10 million at a time.

same here 2 days of  waiting

@okhat @shubham526


Paullgdc/test with latest main branch agent

Add the possibility to test against the agent built from the main branch instead of the last released version.
To achieve this:

The datadog-agent is cloned and queried for the last merged commits
The registry containing images built from the agent's CI is queried to get existing tags, that follow the following format v<pipeline number>-<12 first char of commit hash>-<agent flavor>

We pick the agent container with the highest pipeline number, and the latest commit.
The tests are probably only runnable locally, or on gitlab as it requires access to the build-stable aws account.
I only enabled it for php because it's the only language tested on gitlab. Do we want to test with all weblogs in cross-component tests?
Also currently, the main branch has a bug that make the agent ignore proxy settings, which cause system-test to fail.

🔥


Patch 1

Updating docs to use Model.find({}).select(..) rather than Model.select(...). If there is some magic that makes select work by itself let me know. :)

coooo, but it doesn't merge :(

I fixed it. thanks for reporting!


Open pdf files in new tab

Does anyone know, how to make the pdf files open in new tab ?
I cant find any methods in the Htmlresponse, which will render a new page.

Hei Emil.
Thank you very much, this is working now.

Thanks @emilkjer for explaining :) Going to close this issue, since it doesn't seem to relate to the xhtml2pdf code.
I wish we had RTD so we could collect a section with recipes. Oh well.

Thank you all of you, sorry I havent closed the question.
2016-04-19 11:44 GMT+02:00 Benjamin Bach<EMAIL_ADDRESS>
Thanks @emilkjer https://github.com/emilkjer for explaining :) Going to
close this issue, since it doesn't seem to relate to the xhtml2pdf code.
I wish we had RTD so we could collect a section with recipes. Oh well.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/xhtml2pdf/xhtml2pdf/issues/277#issuecomment-211828940

--
De bedste hilsener / Best Regards
Rasmus Friis
Ved Bellahøj Syd 23B
2700 Brønshøj
Phone: +45 31152585


feat: support task redirection

What does this PR do?
Adding the support of tasks action (navigation) in AI Lab
Screenshot / video of UI
https://github.com/user-attachments/assets/19382b58-ddad-45c6-8e27-38bf5c449ad3
What issues does this PR fix or reference?
Fixes https://github.com/containers/podman-desktop-extension-ai-lab/issues/1742
:warning: Creating an inference server do not create a task (need to create an issue)
How to test this PR?

[x] unit tests has been added :heavy_check_mark:

start AI Lab
Go to recipe
Start a recipe
Leave AI Lab
Open Task Manager
Click on View for the recipe pulling task

https://github.com/user-attachments/assets/7497c52d-3f49-445b-bcd6-061929de475d
When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

Oh, I see, we can see the task page is updated, but apparently the model in the Select is not updated.

I will take a look, nice catch

converting to draft for now, as I always see a reminder that I need to review this PR and then open it and then say "ah yes we're missing another fix first"

@gastoner the problem reported is fixed!

Yes I've run  pnpm install ; pnpm build ; cd ../podman-desktop ; pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend

Yes I've run  pnpm install ; pnpm build ; cd ../podman-desktop ; pnpm watch --extension-folder ../podman-desktop-extension-ai-lab/packages/backend

I am perplex @gastoner as I can't reproduce the problem now... 🤔 which os are you on ?
https://github.com/user-attachments/assets/1fbf79f9-2bc0-4f02-a1f7-974b89bf3dd6


unterminated string literal confusion

From @martinwicke on February 18, 2015 1:27
System.out.println("found package: );

turns into the thoroughly surprising
System.out.println("found package: ););

Copied from original issue: eddysystems/secret#128

From @martinwicke on February 18, 2015 1:31
I think we have to fix our core logic to have a few fewer bugs, but yes, in the long run we should be able to switch to Markov models and get a lot out of them.
Geoffrey Irving wrote:

Not sure what we should do now, but in the long run this seems like a
perfect case for Markov models.
—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74793664.

This is a tokenizer issue.  It's already wrong when IntelliJ produces the
input.
Geoffrey
On Tuesday, February 17, 2015, Martin Wicke<EMAIL_ADDRESS>wrote:

I think we have to fix our core logic to have a few fewer bugs, but yes,
in the long run we should be able to switch to Markov models and get a lot
out of them.
Geoffrey Irving wrote:

Not sure what we should do now, but in the long run this seems like a
perfect case for Markov models.
—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74793664.

—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74794043.

From @girving on February 18, 2015 1:28
Not sure what we should do now, but in the long run this seems like a perfect case for Markov models.

From @martinwicke on February 18, 2015 1:49
What do we get as input tokens?
Eddy Systems wrote:

This is a tokenizer issue. It's already wrong when IntelliJ produces the
input.
Geoffrey
On Tuesday, February 17, 2015, Martin Wicke<EMAIL_ADDRESS>wrote:

I think we have to fix our core logic to have a few fewer bugs, but yes,
in the long run we should be able to switch to Markov models and get
a lot
out of them.
Geoffrey Irving wrote:

Not sure what we should do now, but in the long run this seems like a
perfect case for Markov models.
—
Reply to this email directly or view it on GitHub

https://github.com/eddysystems/eddy/issues/128#issuecomment-74793664.

—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74794043.

—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74795926.

From @martinwicke on February 18, 2015 5:0
I see. An unterminated string literal extends to the end of the line. So we get
"found package: );"

as the string literal, to which we append a paren for balance and a ; as a statement.
I suppose we could notice that the string literal is open, and when appending stuff, check whether we would be adding stuff which is already present in a non-closed string literal.
Not right now though, for sure, removing from milestone.

From @girving on February 18, 2015 2:6
I don't know, I haven't investigated yet.  However, we treat strings as
atomic throughout, so it has to be weird input to produce weird output.
Geoffrey
On Tuesday, February 17, 2015, Martin Wicke<EMAIL_ADDRESS>wrote:

What do we get as input tokens?
Eddy Systems wrote:

This is a tokenizer issue. It's already wrong when IntelliJ produces the
input.
Geoffrey
On Tuesday, February 17, 2015, Martin Wicke<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
wrote:

I think we have to fix our core logic to have a few fewer bugs, but
yes,
in the long run we should be able to switch to Markov models and get
a lot
out of them.
Geoffrey Irving wrote:

Not sure what we should do now, but in the long run this seems like a
perfect case for Markov models.
—
Reply to this email directly or view it on GitHub

https://github.com/eddysystems/eddy/issues/128#issuecomment-74793664.

—
Reply to this email directly or view it on GitHub
<https://github.com/eddysystems/eddy/issues/128#issuecomment-74794043
.

—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74795926.

—
Reply to this email directly or view it on GitHub
https://github.com/eddysystems/eddy/issues/128#issuecomment-74796003.


Facility Location modeling solutions & CI

Migrated from gitter
@jGaboardi

So here are two notebooks I have been working on for benchmarking across solvers & pulp versions, one for pulp2.5.0 and one for pulp2.4:

facloc_benchmarking_pulp2-5-0
facloc_benchmarking_pulp2-4

Each tests:

1 synthetic example and 1 empirical example (@huanfachen’s dataset)
LSCP, MCLP, p-median, and p-center
COIN-CBC, Cplex , GLPK, Gurobi, Mosek, and SCIP

The long and short of it is that the difference between pulp versions seems negligible, while the difference between solvers is where solution divergence actually occurs. Two big takeways are:
Precision is extemely important in network distance (where errors can progate over repeated truncation of distance measurements along segments) vs. euclidean distance. This appears to be a key difference in the p-center results.
Location-allocation via selection sets are randonly seeded within each solver and can lead to a variety of layouts. This is simply a "fact of life” but can have real consequences on some types models, specifically ones that are more focused equity (LSCP, p-center).
So @germano, I believe we have done our due dilligence here and I am satisfied if you update the CI testing in #186 for the results we are seeing from pulp 2.5.0. Does that sounds good?

@gegen07

I feel ok to update the CI testing to pulp 2.5.0. I actually did this update in the last commit of gsoc21-facloc, but it gave an error. The macos test failed and ubuntu test, that is the same OS I use, passed. It's the same behavior that we found on Windows days ago, the array has different values compared to the expected array.
I was thinking in skip facility_client_array for macOS too and add test to the objective values for each model, since the mixins like Percentage and Mean Distance passed at the tests.
Reading the issue coin-or/Cbc#322, specifically this comment gave me an idea to use the argument gapRel=0.0001 to stop the fraction at a certain decimal point . We can so compare the objective values between OS without worries but I don't think that it would solve the problem with facility_client_array. What do you think?

Regarding the facility_client_array, this is a tricky one... I think a good compromise would be for us to use the absolute most simple synthetic dataset(s) to test, which would produce identical selection sets across OSs. Maybe something like 5 clients and 3 facilities on a small 2x2 tic-tac-toe style lattice where.

p=2 and those 2 facilities are clearly the optimal choices for
same for s service distance


add concepts for (modelling) uncertainties

Description of the issue
This is a requirement of SLE project.
The uncertainty matrix by Kwakkel, Walker and Marchau is used.

Ideas of solution
If you already have ideas for the solution describe them here
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

I made a frist draft for an ontological representation of the uncertainty matrix above.

Any comments on my proposal?
If there are no objections against the concepualisation in general, I'd start concretizing definitions etc.

I propose the following definitions for the new classes(and istances) given in the draft:
Uncertainty - Uncertainty is a qualtity of a model that represents any departure from the unachievable ideal of complete determinism.
Nature of uncertainty - Nature of uncertainty is a quality of a model that represents the core reason for uncertainty within it.
-- Ambiguity : Ambiguity is a nature of uncertainty that stems from multiple frames of reference about a phenomenon existing similtaneously.
-- Epistemology : Epistemology is a nature of uncertainty that stems from a lack of knowledge about a certain phenomenon.
-- Ontology: Ontology is a nature of uncertainty that stems from inherent variability of a phenomenon.
Level of uncertainty - Level of uncertainty is a quality of a model that represents the severity of an uncertainty.
-- Shallow uncertainty : Shallow uncertainty is a level of uncertainty at which one can enumerate multiple alternatives and provide probabilites(subjective or objective) for them.
-- Medium uncertainty : Medium uncertainty is a level of uncertainty at which one can enumerate multiple alternatives and rank them in order of perceived likelihood, without being able to discern how intensely the likelihood varies between two alternatives.
-- Deep uncertainty : Deep uncertainty is a level of uncertainty at which one can enumerate multiple alternatives, without being able to rank them in order of likelihood.
-- Recognised ignorance : Recognised ignorance is a level of uncertainty at which one isn't able to enumerate multiple alternatives, while admitting the possibility of being surprised.
Location of uncertainty - Location of uncertainty is a role of an oeo class that has the disposition to be the part of a system in which an uncertainty occurs.
These definitions are all based on the paper linked above.
I'm less sure on how to define the classes that are able to receive the 'location of uncertainty'-role.
I made these first drafts (also based on the paper) :
System boundary - A system boundary is a model component that separates aspects of the real world that are included in the model from those that are not.
Conceptual model - A conceptual model is a model that specifies variables and relationships within a system boundary.
Computer model - A computer model is a model that implements a conceptual model.
Input data - Input data is a model component  that consists of parameters inside the model aswell as inputs to the model.
Model implementation - Model implementation is a model component that consists of the computer code used to represent the model.
Processed output data - Processed output data is a model component that consits of the data that exists after propagating through the model complex.
I'm happy to change any or all of these definitions if anyone has any feedback.

Thanks for the suggestions.

Uncertainty - Uncertainty is a qualtity of a model that represents any departure from the unachievable ideal of complete determinism.
Nature of uncertainty - Nature of uncertainty is a quality of a model that represents the core reason for uncertainty within it.
-- Ambiguity : Ambiguity is a nature of uncertainty that stems from multiple frames of reference about a phenomenon existing similtaneously.
-- Epistemology : Epistemology is a nature of uncertainty that stems from a lack of knowledge about a certain phenomenon.
-- Ontology: Ontology is a nature of uncertainty that stems from inherent variability of a phenomenon.

Ok, I like the definitions. I think we should label the subclasses above uncertainty of ambiguity or ambiguous uncertainty, etc. Maybe keep the current labels as alternative labels?

Level of uncertainty - Level of uncertainty is a quality of a model that represents the severity of an uncertainty.
-- Shallow uncertainty : Shallow uncertainty is a level of uncertainty at which one can enumerate multiple alternatives and provide probabilites(subjective or objective) for them.
-- Medium uncertainty : Medium uncertainty is a level of uncertainty at which one can enumerate multiple alternatives and rank them in order of perceived likelihood, without being able to discern how intensely the likelihood varies between two alternatives.
-- Deep uncertainty : Deep uncertainty is a level of uncertainty at which one can enumerate multiple alternatives, without being able to rank them in order of likelihood.
-- Recognised ignorance : Recognised ignorance is a level of uncertainty at which one isn't able to enumerate multiple alternatives, while admitting the possibility of being surprised.

Fine.

Location of uncertainty - Location of uncertainty is a role of an oeo class that has the disposition to be the part of a system in which an uncertainty occurs.

Call it location of uncertainty role?

I'm less sure on how to define the classes that are able to receive the 'location of uncertainty'-role. I made these first drafts (also based on the paper) :
System boundary - A system boundary is a model component that separates aspects of the real world that are included in the model from those that are not.

This one is a bit tricky. We already have system and there should be a relation. The model models the system and the system has a system boundary, something like that. Could you open a separate issue for that please?

Conceptual model - A conceptual model is a model that specifies variables and relationships within a system boundary.
Computer model - A computer model is a model that implements a conceptual model.
Input data - Input data is a model component that consists of parameters inside the model aswell as inputs to the model.
Model implementation - Model implementation is a model component that consists of the computer code used to represent the model.
Processed output data - Processed output data is a model component that consits of the data that exists after propagating through the model complex.
I'm happy to change any or all of these definitions if anyone has any feedback.

Alright, i will change the labels of the instances of nature of uncertainty to ambigous uncertainty, epistomological uncertainty and ontological uncertainty.
I'll also add role to location of uncertainty.

Alright, i will change the labels of the instances of nature of uncertainty to ambigous uncertainty, epistomological uncertainty and ontological uncertainty.

Let's keep the uncertainty of ambiguity etc as alternative labels.

I also checked the oeo and did find input data and output data. I will delete my own versions.
I could not find any implementation of conceptual model or model implementation, but perhaps they exist under a different name/ with a different definition.
As for computer model: We do have numerical computer model, but I do not think that this is the same as the class that the paper describes.
It's defined as A numerical computer model is a mathematical model that is calculated by a computer.

Should I also add new issues for the terms I could not find yet?

If these terms are to be defined separately, we are mainly missing the relations between model and the aspects of uncertainty.
has quality is already pre-established. Should we use this relation as suggested in the graphic above or should we define more specific relations like has uncertainty nature for each aspect?
We could also do both if that would be beneficial in any way.

Could you please link the new issues here. With the PR, you don't have to wait for theses issues. We can integrate them later.

If these terms are to be defined separately, we are mainly missing the relations between model and the aspects of uncertainty.
has quality is already pre-established. Should we use this relation as suggested in the graphic above or should we define more specific relations like has uncertainty nature for each aspect?

I like the idea of a new relation (subproperty of has quality?!).

And with location of uncertainty, I thought about an entity with an equvalence axiom like 'has role' some 'location of uncertainty role'.

The issues for the other terms are #1951, #1952, #1953 and #1954.

I would define the relations as follows:
subclasses of has quality
has uncertainty nature - A relation between a model(x) and a nature of uncertainty(y) that indicates uncertainty within x is caused by y
has uncertainty level - A relation between a model(x) and a level of uncertainty(y) that indicates the severity of uncertainty within x being y
subclass of ObjectProperty?
has uncertainty location - A relation between a model(x) and a location of uncertainty(y) that indicates uncertainty within x is located in y
Should we also add a relation like has uncertainty(A relation between a model and an uncertainty that indicates the model departs from complete determinism)?
And I would suggest defining location of uncertainty as Location of uncertainty is an independent continuant that has the location of uncertainty role.
Perhaps it could be more specific than independent continuant, but I'm unsure, since the classes that should be able to have this role are not yet defined.

When adding the relations, should I also define the inverse of each of them?

Should uncertainty be related to location/nature/level somehow? It should currently be possible for a model to have an uncertainty level without having an uncertainty. If uncertainty was defined as an independent continuant instead, it would be possible for it itself to have qualities. This would also allow has uncertainty location to be a subclass of located in.
Then we could just add the has uncertainty relation between model and uncertainty.
Unfortunately it doesn't make a lot of sense for uncertainty to be an independant continuant. Maybe you have a better idea as to how to circumvent this issue or maybe it isn't an issue at all, but intended functionality I didn't fully understand.

Should we also add a relation like has uncertainty(A relation between a model and an uncertainty that indicates the model departs from complete determinism)?

Should uncertainty be related to location/nature/level somehow? It should currently be possible for a model to have an uncertainty level without having an uncertainty

I think it lies in the nature of models to depart from complete determinism.
I actually think, it is ok for a model to have an uncertainty level without having an uncertainty etc (asserted). Or let's say, if a model has an uncertaity level, it should follow that is has an uncertainty.
Could we express that the general concept of uncertainty comprises the three aspects level, nature and location? Something like a parthood relation, if that worked for qualities...?

A relation between a model(x) and a nature of uncertainty(y) that indicates uncertainty within x is caused by y has uncertainty level

"caused" is misleading here, its not a causal relation. What about ... within x is of kind y.?

A relation between a model(x) and a level of uncertainty(y) that indicates the severity of uncertainty within x being y

What about ... that indicates the severity of uncertainty (y) within x. ?

subclass of ObjectProperty? has uncertainty location - A relation between a model(x) and a location of uncertainty(y) that indicates uncertainty within x is located in y

Ok.

I don't think it should be possible for a model to have alevel of uncertaintybut no relation to uncertainty. I'd almost say that every model has to have an uncertainty? So maybe that could be an axiom for model?
Since the model is already related to the 3 axes of uncertainty I'm not sure if uncertainty needs to be related to them - but if so I would probably say it should be like it is done with energy and a quality should have another quality.  Even though this is not how the BFO usually does it.
Or maybe there is a way use part of? I'd imagine it like having a quality like color and the color is composed of red, blue and green parts in different quantities? But maybe I am way off here.

Alright I added the relations with the improved definitons

I think we should link uncertainty and nature/level/location.
If we don't relate them in any way it would be pretty hard to distinguish between two different kinds of uncertainty. Because a model should be able to e.g. have deep uncertainty of ambiguity in the conceptual model and shallow uncertainty of ontology in the input data at the same time. If they are not related to one another in any way, there is no way to know which of the locations contains what kind of uncertainty at what severity.
uncertainty should be a quality of model (as it is within the first model you presented graphically), since an uncertainty within a model cannot exist without a model. It is dependant, which makes modeling it's own dependants difficult. I don't think BFO really has a way of modeling dependencies of dependencies.
But similarly to how there is no uncertainty of a model without model, there is no location of uncertainty without uncertainty. I'd say the relationship between these entities should be equivalent. Therefore I would suggest to model nature/level/location as qualities of a quality like energy.
If you agree with this proposal, we'd have to reconsider the definitions of the relations once again, as they'd now hold between uncertainty and nature/level/location instead of model and nature/level/location.
The new definitions could be as follows:
has uncertainty nature - A relation between an uncertainty(x) and a nature of uncertainty(y) that indicates x is of kind y.
has uncertainty level - A relation between an uncertainty and a level of uncertainty that indicates the severity of the uncertainty.
has uncertainty location - A relation between an uncertainty(x) and a location of uncertainty(y) that indicates x is located in y.
This has the side effect, that relation between model and nature/level/location becomes much more abstract. We could instead do something like:
has uncertainty nature - A relation between an uncertainty(x) of a model(y) and a nature of uncertainty(z) that indicates x within y is of kind z.
has uncertainty level - A relation between an uncertainty(x) of a model(y) and a level of uncertainty that indicates the severity of x within y.
has uncertainty location - A relation between an uncertainty(x) of a model(y) and a location of uncertainty(z) that indicates x within y is located in y.
But I'm not sure if this congruent with the rest of the oeo, since I could not find a similarly structured definition.
I also considered the parthood relation you suggested, but has part is defined as a core relation that holds between a whole and its part and I'm not sure I'd classify uncertainty as a whole?
Technically has part does not have a range/domain so it could be possible to use it on a quality, but it feels unintuitive to me.
Feel free to disagree with me on this point, because I'm not sure I can properly articulate why this relation seems unfitting to me.

The model would look more like this, if we implemented my suggestions.
(I shortened the parts that didn't change such as the instances and the definition of location of uncertainty)

If we don't relate them in any way it would be pretty hard to distinguish between two different kinds of uncertainty. Because a model should be able to e.g. have deep uncertainty of ambiguity in the conceptual model and shallow uncertainty of ontology in the input data at the same time. If they are not related to one another in any way, there is no way to know which of the locations contains what kind of uncertainty at what severity.

I think this is a very good point.
To me a whole and its part is a very open definition that fits lots of things but I would also be fine with specific new relationships as in the graphic. It is very possible that I am looking at part of incorrectly.
I like your new graphic, even though quality of a quality is not as BFO intended. It was done before after all. And this feels like it captures the content pretty well.

Alright I've implemented all changes as discussed.
It might be time to turn the related draft pull-request into a regular pull-request, if you don't have any further requests or comments on the proposed solution.

After further discussion with @stap-m and @ColinHDev we came to the decision, that we can use e.g. nature of uncertainty as a quality of a quality, as long as we don't use the relation has quality.
This was based on the book "Building ontologies with basic formal ontology"(2015) by Robert Arp, Barry Smith, and Andrew D. Spear:

Qualities may depend also on entities of other types; thus, for example, the quality of your heart, of beating with a certain rate, is dependent not only on your heart, but also on the beating process in which the heart participates.

We also further deliberated on whether or not to make uncertainty a generically dependant continuant, but decided against it for now. This was based on the decision detailed above, since this change would mainly have solved our issue of not wanting a quality to depend on another quality

We also discussed how to procede with this issue.
To add in all terms that were suggested at the beginning of this issue we should do the following in this order:

merge the first PR relating to this issue (#1945)
come to a conclusion about the terms that were discussed in separate issues (#1951, #1952, #1953)
add/don't add them to the oeo
add another PR for this issue to add uncertainty location
add a new issue to define neccessary axioms

Steps 1-3 have now been done.
I would propose to define
uncertainty location as An uncertainty location is a continuant that has the location of uncertainty role
and will already add a draft pull request with this definition. If it needs changes I will implement them, but this way we can progress more quickly.
I will also add the issue where we can discuss necessary axioms.
Axioms that have been mentioned as necessary in this issue:

system to system boundary
give system boundary, technical model implementation, conceptual model, input data and output data the location of uncertainty role
uncertainty to uncertainty location

if there are any more, we can add them to the issue.


Community driven add-ons

An official supported add-on catalog is very nice and makes installation very easy. But there are needs to add additional add-ons to it. Someone wants rook, I vote for longhorn and the third one wants openebs. Same for networks, dashboards etc.
I think a decentralized way is more feasible. For example sudo microk8s.enable may-be-some-name https://some-site-like-github to install a not built-in add-on.
A catalog for discovery like operatorhub would be also very nice, but something static awesome-micro is also OK.

Having external repositories with recipes is a great idea. Actually there is nothing stopping you from starting one right now without permission. It would be very beneficial for MicroK8s because that would mean we could rev the kubernetes part separately from the addons.
In terms of integration hooks like the one you suggest above, I think these will grow organically so we do not need to spend time discussing it here.
Maybe @Bessonov you can discuss this with the rest of the community members (like @balchua) and go forward with this idea.

I second the idea.  A github repo containing addons where MicroK8s can pull.


Add smooth predictor and tests

Smooth predictors require knowledge of bit depth to clamp predictions, so the native function includes the bd parameter.

Now with H and V variants.


Bring back changes from release-v1.3.0 into main

Using a temp branch because of git conflict

⚠ DON'T MERGE IT, I just saw GitHub mess up with the README, I have to fix it before merging


Sceneform without camera feed

Hi google team,
I know i asked this before but it seems it was misunderstood for "Sceneform without Arcore". I defiantly like that now we can use it on none ARCore supported devices but i really wanted was a way to use Sceneform without camera session. So if possible, using Sceneform on a regular GLSurfaceView or TextureView with openGL. I love the progress this library is having and the new features included on every release but i feel forcing Sceneform to be only used for AR is a bit to limited. I not expecting that sceneform would be the next 3D game engine for android(even if that would be super cool and hopefully that is the final direction this is going to) but i would love it to be a bit more open on where we can render the 3D model on. I can see this being used for stuff like Kia showing new Shelves and inventory without needing the device to have a camera(Example for tablet uses).
Thanks and looking forward to the next update,

Your Faithful Android Developer

Thanks for your request! The use case you described is something we would like to support.
It should be possible to use Sceneform without a camera feed now. To do this, instead of using ArFragment or ArSceneView, you can use the class SceneView, which is a subclass of SurfaceView.
In your layout file, you would have this:
  <com.google.ar.sceneform.SceneView
      android:id="@+id/scene_view"
      android:layout_width="match_parent"
      android:layout_height="match_parent" />

and in your activity:
  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    setContentView(R.layout.activity_scene_view);
    sceneView = findViewById(R.id.scene_view);
  }

  @Override
  protected void onResume() {
    super.onResume();
    try {
      sceneView.resume();
    } catch (CameraNotAvailableException e) {
      throw new AssertionError("Failed to resume SceneView", e);
    }
  }

  @Override
  public void onPause() {
    super.onPause();
    sceneView.pause();
  }

  @Override
  public void onDestroy() {
    super.onDestroy();
    sceneView.destroy();
  }

You'll notice that onResume does catch a checked exception related to the camera. However, this is an API bug. SceneView does not make any calls into the camera and does not render the camera feed.
Also, Sceneform does have a maven dependency on ARCore that will still be pulled in when you use SceneView. However, no calls will be made into the ARCore SDK in this case. We are investigating removing this dependency when just using SceneView.
Does this help address what you are looking for?

@dsternfeld7 Thank you so much for that suggestion. That worked and the model looks amazing on my screen :). Now just got to wait for Skeleton Animation :)

Is it possible to switch between a Sceneform camera feed and OpenGLES camera feed? The OpenGLES camera feed is implemented in the Hello_AR example project. I'd like to render the planes read from Sceneform in the functions in HelloArActivity.java. I think the problem is the fact that ArSceneView won't go entirely away. I always get exceptions on an OpenGL thread. Is there any way to completely destroy a Sceneform session and switch to an OpenGL rendering session in the same activity?

Sceneform can't be combined with other access to OpenGLES.  There is some more discussion of this at https://github.com/google-ar/sceneform-android-sdk/issues/169

@dsternfeld7 Thank you so much for that suggestion. That worked and the model looks amazing on my screen :). Now just got to wait for Skeleton Animation :)

@marcos-dogonahorse  can you look at my question https://github.com/google-ar/sceneform-android-sdk/issues/431
I am trying to render 3d model on the view as you did here. But I am failing to do that.
Thanks.


AngularJS Commit Message Conventions examples do not follow all conventions

The linked google doc with detail for the commit message conventions (AngularJS Git Commit Message Conventions) has examples at the end, but several of the examples do not follow the convention for subject and body:

use imperative, present tense: “change” not “changed” nor “changes”

A few suggested fixes:

change "Added new event to $browser" to "Add new event to $browser"
change "Couple of typos fixed" to "Fix a couple of typos"
change "Changed the isolate scope binding options to:" to "Change the isolate scope binding options to:"

There may be a few others I did not pick up on
I can put suggested changes on the doc directly if I can get suggest permissions on it.

In my personal experience, the body has a lot more variety in phrasing and it's usually not a important as the subject. Since the docs is not in our hands, I will close this and suggest someone who can to take a look at it.


Added Approval Workflow Executor tests with new client Admin

Added the new Client Admin.
Added Approval Workflow Executor tests for checking  the process of application creation, API state change, API subscription, application key generation( Production /Sandbox ) and User Self Sign up.

You have added APIStatusMonitor.war addressing-1.6.1-wso2v41.mar with the pr. they need to be removed

@SahanHerath lets update these test to work with v1.0 (once v1.0 is finalized) and do a PR again


Add Miami, Fl

Hello,
Please add a template for Miami, Fl officials. Thanks!

Please add Miami!!

Following other blank requests, as contributors are handling a lot of requests - please include the following information with your request:

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community

See our current links for examples at https://defund12.org.
Thank you!!

Thank you, I will work on this! You're doing great work. Thank you so much.

Unfortunately this request does not meet our base criteria so we will have to close it. Please submit a new request with the following information and we will process it:

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community
See our current links for examples at https://defund12.org.

Thank you!!


I made res of self.session.post() to be a property of gqclient class.

Added a method to return the status of the response which is a private prop.

I think it's quite useful to have the response available externally.
In my particular case, I use it for the spaceM pipe step to access Metaspace and check if a user logged in or not, so a user can grab annotations for private datasetes.
So far I don't understand why returning status from login/reconnect method is more preferable.

It's not strictly required but for a good style it would make sense to handle a response in the code that initiates a request. Plus the client doesn't need to call a second method then.
Another case if you're planning to call login_status multiple times in different places. But then I'd suggest to have a method like user_authorized instead of returning status_code which is somewhat specific to requests package.

I still don't quite understand it. Could you provide me the snippet with a solution? the only changed I introduced was adding
self in front of res, otherwise it's not possible to reach it when the object of class is instantiated.


[Enhancement] Insecure display frame

Instead of causing an effect on the actionbars, I would like to have a frame visible which shows the icon of the next spell to cast. I would be able to resize and move this frame, but it would of course not be clickable. I wouldn't want it to have any effect.
Not all of my actionbar spells are visible at all times, as some only cast when a modifer key is held down. Unless I change many of my keybinds, actionbar effects will not work for me. This is why I would prefer to have a single spot on my screen that I can view for a recommendation of what spell to cast next.

I added this to 1.4.2 beta 1


Initial Run Error

Describe the bug
Error when launching the app for the first time (local Docker)
To Reproduce
Steps to reproduce the behavior:

Clone Docker
Run Docker
Open browser http://<IP_ADDRESS>:5500/
See error

From Docker Log
<IP_ADDRESS> - - [13/Apr/2022 12:05:45] "GET / HTTP/1.1" 500 450 25.340285
<IP_ADDRESS> - - [13/Apr/2022 12:05:45] "GET /favicon.ico HTTP/1.1" 200 112296 0.006404
Creating JSON store at /datastore
(1) accepted ('<IP_ADDRESS>', 59600)
(1) accepted ('<IP_ADDRESS>', 59602)
ERROR:adrfinder:Exception on / [GET]
Traceback (most recent call last):
File "/usr/local/flask_login/utils.py", line 277, in decorated_view
return current_app.ensure_sync(func)(*args, **kwargs)
File "/app/adrfinder/init.py", line 350, in index
rest_and_times = get_restaurants_and_times()
File "/app/adrfinder/init.py", line 1020, in get_restaurants_and_times
search_times = rest.get_search_times()
File "/app/adrfinder/restaurants.py", line 106, in get_search_times
for option in search_data.find_all("option"):
AttributeError: 'NoneType' object has no attribute 'find_all'

Thanks for the report.  Looks like that would indicate a (hopefully temporary) issue connecting to the Disney website.  Does it continue to fail if you bring it down and back up?

closing stale issue

Closing stale issue


Update Vercel deployment documentation

This pull request updates the Vercel deployment documentation section with the recommended deployment method from Vercel for the greatest chances of user success.

Thanks!


⚠ Bofrost.es has degraded performance

In 8895d26, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1605 ms

Resolved: Bofrost.es performance has improved in 53b1804 after 53 minutes.


How to avoid "[streams] can't get track error="RTSP GetTrack from wrong state: HANDLE"?

I can't seem to get around this error. I understand from other threads that this is a "normal" error, but is there anything I can do to avoid this?
This is all I have in my config:
streams:
    basement:
        - rtsp://USER:PASS@<IP_ADDRESS>:554/cam/realmonitor?channel=1&subtype=0
        - ffmpeg:basement#audio=opus

The stream loads fine in VLC, but doesn't load in the Frigate lovelace card, or in the go2rtc webUI.

#311


Compiling errors when using the command

HI dear author,
It's truly a honor to write a letter to you,  I'm building your project nowadays and found the error when building as following, I wonder if there is a chance that you know the reason? :)

thank you
best regards to you
William

Maybe caused by std::flush. I removed all std::flush, please pull the latest code and try again.
Contact me again if the error still occurs.


pyperclip not working

I am testing out a single program with pyperclip. I was able to get it right first time, however when I had another clipboard text copied previously my Python program does not work as expected and still shows old clipboard content.

What version of Python are you running?

I am using python3.7.4 and I am trying from Mac. Here is the command I fire from terminal
python3 <file.py> <'Parameter'>
It execute fine, however its not taking me to end result when I have previously copied content in the clipboard

What appears when you compile the program? I am also having troubled with Python3.7 anything greater than version 3.6 has been giving me problems with this


Add CI test for checking for unused dependencies

Fixes https://github.com/sigp/discv5/issues/177

so sad

Oh sorry we didn't see this before, a review request would have helped, but don't be sad! low hanging fruits pop often

@divagant-martian I don't have permissions to make a review required

oh that's unexpected, feel free to tag age or myself in any case

sounds good 👍


Add gitter notification on AppVeyor build status

This should notify in gitter the status of each build in AppVeyor. I was looking each time I had a PR merged, but this should notify in gitter.

Oh cool! :)


Welcome new maintainers 🍻

I’d like to welcome three new members to the Shields maintainer team! @platan, @PyvesB, and @chris48s, you've worked consistently, cordially and effectively over the past few months. I’ve appreciated your technical chops, collegiality, dedication, and thoughtfulness. I’d like to make sure you’re not blocked or frustrated awaiting review from me or @RedSparr0w.
I’d suggest we use these review guidelines to start:

Try to get an opinion from @espadrine or me on anything “core” related
Try to get an opinion from @RedSparr0w or @espadrine on anything badge-template related
Definitely get @espadrine’s approval on anything ops related
You may otherwise merge with two of your ✅'s.

@RedSparr0w, please continue to seek input and merge at your discretion. You have great judgement about that.
We're starting to have a lot of people, which is great! As the team grows, we may need to institute some more process like a technical advisory committee, to make sure we don’t run off the rails. Though I don’t think that’s necessary to start. Let’s see how this works out and revisit in a few months.
From a more practical standpoint, would you please join the Discord room and post your handles here? I’ll ask there for your email address. There may be other things to discuss. Let’s coordinate here.
Welcome to the team!
/cc @Daniel15

Hey there, thanks for the warm welcome to the team! Let's bring this project to the next level! 👍
Still completely new to Discord, but I believe my profile name is the following: Pyves#4777

I am chris48s#7718 :)

@paulmelnikow thank you. @PyvesB and @chris48s - well done! And my Discord username is platan#9710.

Welcome to the team!
Glad to have you all join :smile:


Add Effect only Items

Originally in GitLab by @camorri0920
It would be nice if there would be an opportunity to create Items which are only Effects, that an be added to a Actor with drag'n'drop.
Nowaday I have to create a Feature element to use as a container of the effect which will be added to an Actor.
I really want to add only the Effect to an Actor, instead of this coupling.

As kaelad points out, this would likely require Active Effects to be supported as World-level documents in the core software.


Restore event logger to payload

The Event::setLogger() and Event::getLogger() methods still exist, but it seems they no longer add the logger to the event payload. As a result, when an event is sent to Sentry, the JSON shows "logger":"" - empty string, rather than the value that was passed to Event::setLogger().
As far as how Event::setLogger() is used, it's not just me.  The Monolog handler has $event->setLogger(sprintf('monolog.%s', $record['channel']));

It looks like there was a test for this, but it was removed in 6ba2a2c228c689c7d87b4490f006c0ab05151f77
Feel free to work on this if anyone has time/interest, otherwise it's on my list.. :)

@cleptric ok, I restored the test to PayloadSerializerTest

Shipped in 4.2.0


[BUG] Update net.minidev:json-smart in com.azure.spring:azure-spring-boot to v2.4.x

Is your feature request related to a problem? Please describe.
Using a security scanner like Black Duck leads to reporting the vulnerability CVE-2021-27568 in net.minidev:json-smart v2.3, which is a dependency of com.azure.spring.azure-spring-boot. net.minidev:json-smart is mitigating this issue in version 2.4 as can be seen here.
Describe the solution you'd like
Please update the dependency net.minidev:json-smart to 2.4.x.
Describe alternatives you've considered
None
Additional context
None
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

Thank you for reporting this issue @dreadwarrior.
@stliu could you look into this? Or assign someone who should look into this.

@alzimmermsft  I will handle this.

We will do our spring release later in this month(2021-06), and the issue will be fixed.

we have just finished our spring release this month, the issue has been fixed in the released libraries.


Adds support for logical border color properties

Closes #474

Hey @sherlockdoyle! 👋
Thank you for submitting a PR with the fix, I appreciate that a lot! Looks like I overlooked the logical border color properties in https://github.com/dcastil/tailwind-merge/pull/210.
By the way ignore the codspeed perf report (the results are quite imprecise) and the broken metrics report action. Have to fix that at some point.


Warning needed on invalid Content-Length headers

Mojolicious version: 7.29
Perl version: 5.24.1
Operating system: MacOS Sierra

Steps to reproduce the behavior
As was pointed out in LWP::UserAgent Issue #86 when a server provides a Content-Length header that is greater than the actual length of the content provided by the server, Mojo::UserAgent responds with a 200 OK response.
#!/usr/bin/env perl

use strict;
use warnings;
use Data::Dumper::Concise;
use Plack::Loader;
use Test::TCP;
use v5.24;

my $server = Test::TCP->new(code => sub {
    my $port = shift;
    my $app = sub {
        my $content = "hello world\n";
        [
            200,
            ['Content-Length' => 10000], # bigger than acutual content length
            [$content],
        ];
    };
    Plack::Loader->load('Standalone', port => $port)->run($app);
});
my $url = "http://localhost:" . $server->port;

{
    use LWP::UserAgent;
    my $ua = LWP::UserAgent->new;
    my $res = $ua->get($url);
    warn "LWP::UserAgent: ", $res->status_line, "\n";
}

{
    use Mojo::UserAgent;
    my $ua = Mojo::UserAgent->new();
    my $res = $ua->get($url);
    warn "Mojo::UserAgent: ", $res->result->code, " ", $res->result->message, "\n";
}

{
    use HTTP::Tiny;
    my $ua = HTTP::Tiny->new();
    my $res = $ua->get($url);
    warn "HTTP::Tiny: ", $res->{status}, "\n";
}

Expected behavior
Through reading the RFCs HTTP/1.1 last paragraph of section 4.4 it seems as if the200 OK response is still valid, but a warn should be emitted about the content discrepancy.
Other user agents such as Curl do this. Some Perl UAs handle it slightly differently, but the RFC makes it seem like a warning should suffice.
Actual behavior
The 200 OK response is provided with no indication of the discrepancy.

Sorry, I meant to quote the pertinent part of the RFC as well:
When a Content-Length is given in a message where a message-body is
allowed, its field value MUST exactly match the number of OCTETs in
the message-body. HTTP/1.1 user agents MUST notify the user when an
invalid length is received and detected.

Quoted from #mojo IRC:
10:53 <sri> genio: warnings seem kinda pointless
10:54 <sri> you don't warn about a security issue, you throw a loud exception

This is what I would like to see for this kind of thing.

@kraih fiery death is perfectly ok with me.

How about setting $tx->res->error ?

I think @jhthorsen's error idea is more consistent with how the UA works in general.

In setting $tx->result->error, does that not imply that you should also set the return code? If so, are you suggesting using the 599 code like HTTP::Tiny?

Mojo::UserAgent has a convention where only the error message (and not code) is set for transport errors, which would IMO be appropriate for this error as well. It would also cause the new ->result method to die like transport errors do.

Ah. Thanks for the explanation.  Sounds good to me.

After several faltering attempts to address this (non-)issue, it seems to me that it would be more troublesome to work out a "fix" than to just continue on as is.  Every attempt made thus far just introduces more problems than it tries to solve.


Fix null reference exception in timer

Fixes this:
https://github.com/Mapsui/Mapsui/issues/2105

I was extra cautious.
Null checks for fixing bugs. And try catch to catch bugs in the called functions. I guess this runs on the unthread and not caching bugs will crash the application or the thread the timer runs on.


Possible Compendium automations

Blood of the Mountains: Sorcery defense needs to be applied
Blood of the Sorcerers: Sorcery point should probably be granted
Brawler II may be possible if you assume all unarmed attacks are fists, which probably isn't sane
Deft Hands may be possible
Famous needs max logic that may be possible to implement.
Fast will likely be possible once movement is implemented.

Sorcery Defense and Sorcery Points can now be automatically granted.
Brawler II and Deft Hands are not reasonable to implement in current architecture
Famous may be possible
Fast will be included in Movement pass.


Bugfix: Always send mails from the same address

If the mailaddress configured in Craft's mail settings to send mails from differs from the mailaddress notification address, this results in an error. Craft can't send mails from other mailaddresses that are not configured.

I see that PR #28 introduced this. It may be better to get the from mail from the settings directly?

I also added the option for overriding templates inside the form. It overrides the confirmation template instead of having one template for all forms. Updated Readme

Thanks!


screenshader: fix uniform variable checks

Describe your PR, what does it fix/add?
This fixes the output uniform variable added for #2485 not being set.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready for merging

Yeah that works as well. I just copied the way it was done here:
https://github.com/hyprwm/Hyprland/blob/57a8e08da20b694e343b552e47f8065b6eb7db37/src/render/OpenGL.cpp#L361 Should I change it?