Update of other packages cancelled when a package fails the validity check

Maybe it is not a bug, however I have noticed that when one package fails the validity check, then the upgrade of the other (top-level) packages is cancelled. Expected pacaur to upgrade the other packages.
$ pacaur -u
...
AUR Packages  (3): bomi-0.9.2-3  gatotray-2.3-1  google-chrome-dev-42.0.2305.3-1
...
:: Checking gatotray integrity...
==> Making package: gatotray 2.3-1 (Thu Feb 19 11:00:16 CET 2015)
==> WARNING: Skipping dependency checks.
==> Retrieving sources...
  -> Found 4218cadee76b8a9e9e01bb78de2866cdeafb7a5f.tar.gz
==> Validating source files with md5sums...
    4218cadee76b8a9e9e01bb78de2866cdeafb7a5f.tar.gz ... FAILED
==> ERROR: One or more files did not pass the validity check!
...
:: failed to verify gatotray integrity

bomi and  google-chrome-dev are not upgraded, except if you do pacaur --ignore gatotray.

This is done on purpose. Pacaur should not ignore packages of the behalf of the user.
This behavior also applies to all packages in the dependency chain. In older versions of pacaur, the build would fails in the middle of the transaction, while it now stops right before starting the build process.

Can we please have an option that says to ignore these packages? I use some AUR packages that always try to upgrade because their version is "latest", and they often fail to upgrade for some new issue that'll be figured out in a month or so, and I don't care about missing out on updates until that gets fixed. With the current setup, I have to try upgrading once, memorize which packages failed, and upgrade again with an --ignore for those packages. That is extremely cumbersome. I need an option that just says "I don't care that they failed; please install the others".

You've got the --ignore flag, just make use of it.

I just explained why having to use the --ignore flag is cumbersome and doubles the amount of time it takes me to upgrade my packages. Are you suggesting I ignore those more problematic packages all the time and never update them? Because that isn't a solution. Or that I arbitrarily stop ignoring them once in a while, hoping it'll work? Because that would be just as cumbersome and annoying, and who knows if I would ever even remember to do that. The best solution is to be able to just attempt to upgrade them every time, without having to redo the upgrade to get the others that are ready to go. I don't see a reason that that can't be a non-default option.

 This is not what pacaur is for, and I won't spent time fixing an issue that isn't one.
Your alternative is to send a patch, fork and fix by yourself, or send a significant amount of money to make me implement a workaround for you (see man page for paypal link).

I'm not bypassing it blindly. I want to bypass packages that have nothing to do with the other packages in the upgrade, besides that they were being upgraded in the same run. No dependency relationships or anything. That saves a lot of time in a lot of situations. In a Bash script, if you're doing a batch operation, the default is to ignore failures and keep going, and you have to set the e flag to change that. Why should behavior that is often that is often the default be so undesirable that it isn't even an option?
And I can't use another helper, and I'm sorry, but this is what pacaur is for. I use pacaur because it's the only AUR helper that can check your package cache for already-built AUR packages, which is a godsend for anyone who maintains more than one Arch install (as I do). Having that feature makes it, to me, the AUR helper that is best for upgrading a system with no headaches. This issue I'm complaining about massively hampers its status as that, and I already still use yaourt for everything but upgrades.
If you won't fix the issue, I will, but just because you don't personally see the point doesn't mean it isn't an issue.

And I still don't care. One design principle on which pacaur has been built since day one is the following:

By design, pacaur doesn't allow to bypass "issues" that should be fixed upstream in the AUR or in the installed software. Each user should participate to the improvement of the PKGBUILDs by reporting issues to their respective maintainer, instead of selfishly avoiding the issue just for themselves. If you need some manual tinkering, you can simply use cower and the manual way, or you can share and maintain your own modified PKGBUILD in the AUR.

Looks like pacaur is not the right tool for you. You are of course still free to adapt the code for your specific needs. If you require that I spend more of my free time on this, I can do it, but don't expect me to do it for free.

Again, what I'm asking is not bypassing an issue that should be fixed upstream. If one package fails to download, and another completely unrelated package DOES NOT fail, and they just happen to be in the same batch, there is no bypassing going on by installing the successful one. Bypassing the failure would be trying to installed that package that failed to download anyway. Disagreeing with me means you think that all batch actions on a computer should automatically give up and stop the moment a single member of the batch fails, with no option whatsoever to change that behavior, and many projects including Bash disagree with that statement.
 Especially with your refusal to even point out where in the code I'd want to start off the top of your head, without spending more than a few seconds of your free time thinking about it. You're the one who made the program and so can do that. You don't have to refuse to do that and you don't have to inexplicably think that common sense functionality goes against design principles.

If you can't refrain yourself to insult people, please avoid to comment on these tickets - I'm not your damn slave. Seriously, you didn't even try to have a look at the obvious update code and start backward from there before asking for my free time.
And yes, I absolutely can refuse to work for free.

I'm starting to see where the misunderstanding is coming from. The very moment you said you didn't want to do it for free, I said I'll do it. I've repeatedly said I'll do it, because you keep reiterating that you won't do it for free. I have not been asking you to do it for me at all since my first comment. I've been complaining about your negative and disrespectful tone that comes from being wrong about what you thought I was trying to say. The only thing I asked for since your first "won't spend time" statement was specifically any tips you might have off the top of your head, without devoting any free time.

Again insulting? Guess what, your whole rant isn't worth my limited time. Have a holiday, and a happy fork.

Wheee, came here as I was trying pacaur for the first time and it failed updating the AUR packages saying:
==> ERROR: Failure while downloading ftp://ftp.debian.org/debian/pool/main/c/console-setup/bdf2psf_1.156_all.deb
    Aborting...
:: failed to verify qtox-git integrity
:: failed to verify bdf2psf integrity

Some notes:

Saying that the bdf2psf could not be verified is --while surely true-- misleading. That thing is plain not findable where it is supposed to be anymore.
For me, there were quite some packages in that update. If there was an option to be asked to skip a failing package on the fly, that would make the task of system administration easier. That way, I can keep the workflow and update the rest of my system before trying to fix the failing ones.
I have modified the PKGBUILD of qtox-git to use my fork of that project instead of the original one. The first time using pacaur, I was given the chance to edit the PKGBUILD. Now, the second (and following) time, it does not present this option. I can use the --edit option, but then I'll have to re-read all previously approved PKGBUILDs. If pacaur gave an option to only edit the pkgbuilds of failing packages, this would be easier.

Now, all those things are minor hindrances that I could well live with, or maybe try to 'fix' and create a pull request for, if they have a chance of being accepted (Keeping non-trivial forks of software alive is often more cumbersome than living with (perceived) deficits) or consider paying money to have them 'fixed' ('fix' because they are really more of a feature request).
However, there are two questions in my head after reading this thread and the man page of pacaur:

Is this the general way of treating users of pacaur? I have seen the section in the man page[1].
Do I want to invest time (either developing or just getting used to a software) or money (and therefore become in a way dependant on it) in a product/software where this is the way users are treated?

I can totally understand if a developer says "Hey, I don't consider this an important problem. If you feel different, please fix it yourself or pay me to do it (if dev is willing to work for money)." I would appreciate it if said developer went on with something like "If I remember correctly, <file/function> would be a good starting point to work on the problem" or "But I have no idea where you could start of, though". At this point, I would have the information, that work on the problem has a chance of being merged and I would have a starting point or know at least that that information is not readily available in somebody elses head. Then, I'd look at the source and decide, if I want to work on the problem or not. These responses would take a developer around two minutes[2] and keep everybody happy.
Instead, a user asks for a feature, shows, that he/she has researched and understood the provided possibilities, provides a somewhat clear description what the requested feature should be like and why it would improve the product. And gets flamed. Why?
It is completely acceptable to not want to fix/change a program. But after reading the first 10 posts, I get the feeling, that rmarquis did not even care enough to try to understand the request. Yes, calling the option "I don't care that they failed; please install the others" may not be the best name, but still. I do not agree with insulting people over that, but the original request is in no way so abstruse as to warrant such a treatment as shown here. At least two (and counting me late-arrival, three) people do care for it. Is that developer hybris (I know what is good and right), elitism (only MY use case are valid) or some other problem?
If I start using/working-on pacaur and find a problem/bug in a year, will I receive the same treatment?
Best regards,
mox
[1]
       If you feel great pity for the present maintainer that has to constantly cope with users that don't want to
       read man pages and refuse to take responsibility for their own system, you can send me funny cat pictures.
       Alternatively, you can send a donation via PayPal to the above email address.

[2] Looking at the Issues section, there seem to be no more than around one issue every day.

.. as I was trying pacaur for the first time ..
And already complaining. Wow.

If I start using/working-on pacaur and find a problem/bug in a year, will I receive the same treatment?
Yes. Please fork, create your own helper, or use another one.

You really don't get it, do you?
I don't really know how you perceive the world and do stuff. Me, when I create something, I'm fond of perfecting it, so I like to have feedback. For you, this does not seem to be true. At least to me, it seems like you treat everything as a personal insult. I have to admit, I feel a bit sad for you, but I'll stick with your advice and not use anything you create. Have a nice day.

Glad to see you go away! Have a nice day too.

@rmarquis Came by this thread cause I am having a few validity issues on install as well. I've got nothing to report per-se (the issues are obviously package related - not pacaur), but after reading the thread I just wanna give some love and say love your work man, thanks for pacaur! - I know most don't realise the amount of work goes into making and maintaining this kind of thing, but I appreciate it. Thought you could do to hear some positive feedback ;)

@se1exin Thank you! I really, really appreciate your words. Also thanks for the donation! :)


PROPOSAL: Add startUI.appBasename option in next.config.js

This is a proposal, I'm not sure if it's clever ou stupide to use the next.config.js to store this information 😅
Fix #157
Change the app basename
Udpate the startUI.appBasename in the next.config.js to change the url where the app (folder) is serve.
ℹ Only accept first level path like ✅ admin (❌ sub/path will not work)
// next.config.js
module.exports = {
  startUI: {
    appBasename: 'app',
  },
}

We don't need this level of complexity. Will close for now.


test(examples): puppeteer GUI tests for supply chain frontend

Description
As a contributor I want to be able to change any part of the code and have at least some level of confidence that my chance will be touched upon by some tests at least partially.
Currently this is not the case. For example when dependencies were removed by an automated tool, certain errors could be introduced that would only surface if a human actually tried to run the examples that have web GUIs (the CI kept happily passing despite the issues).
Puppeteer is a great tool to run a headless chrome instance and have it scrape Angular/Ionic apps.
A case could be made to have Protractor in the loop on top as well (which is what Angular uses out of the box anyway).
Acceptance Criteria

Use either Puppeteer or Protractor to have end to end GUI tests actually verify the examples as part of the CI
Have the mentioned tests passing.
Also include at least some minimal testing the same way for the ./packages/cactus-cockpit as well.

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo

Closing this for now due to the CI resources not being enough (not enough RAM in the runners).
We can re-open it later because the original idea is still valid IMO.


adding surah name in the start of each surah

Thanks @mahmoudbahaa755 !
Your changes have been merged, you can see them live now.


Fix Ptr::__subscript to accept any integer index.

Fixes #4029.
The main change here is to make __subscript a generic on T:__BuiltinIntegerType, and allow parser to accept generic __subscript decls.

Looks good to me but wouldn't this allow little more than usual? I think __BuoltinIntegerType includes like a memory pointer type too.

I think you are referring to IntPtr type? Similar to the samely named type in .net framework, IntPtr means pointer-sized integer type, which is int64 in most cases.

Right, that's what I was thinking.
Allowing Ptr to be a type that can go to the subscribe operator feel like this in C++
int main()
{
        int var = 0;
        int *ptr = &var;
        int arr[4];
        arr[ptr] = 0; // error: invalid types ‘int [4][int*]’ for array subscript".
        return 0;
}

Correct me if I misunderstood.
But allowing a pointer as an array index should be an error if that's what this change does.

Int* is not an BuiltinIntegerType.
IntPtr is. IntPtr is not int*. It is an int whose size is the same as a pointer.
On x86, IntPtr == Int32.
On x64, IntPtr == Int64.

See https://manpages.ubuntu.com/manpages/lunar/man3/intptr_t.3type.html

Oh. I see. Thanks for clarifying it for me.


[ZEPPELIN-5497] Use AutoCloseable interface to close all IO

What is this PR for?
Should close clientPool explicitly, otherwise it won't be garbage collected.
Take over of #4208
What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5497

How should this be tested?

via CI

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I will merge this into the master on Wednesday if no other comments are received.

LGTM


[Feature] Assertions for checking that a collection contains an expected item

Hello there!
I started using Startest since I like the API decisions being made, and the error reporting is well done.
By using Startest I stumbled upon the need to assert that a string contains a substring, I've implemented a rather "abused" function since I didn't provide an alternative implementation for the raise and show_diff functions for better error reporting of this particular use case.
Are such assertions on the roadmap?
I'm unsure what approach would be the best fit here. Gleam doesn't support overloading functions so
pub fn to_contain(does haystack: String, contains needle: String) -> Nil
pub fn to_contain(does haystack: List(value), contains needle: value) -> Nil

wouldn't be possible.
Using generics exclusively would require us to check the type via the dynamic module, a valid but cumbersome approach since such a function wouldn't tell its whole story via its signature (e.g., what happens when providing an unsupported type - requiring consumers to hope for the Hex documentation to cover such questions).
As of now, I'd favor implementing different functions per supported type like
pub fn string_to_contain(does haystack: String, contains needle: String) -> Nil
pub fn list_to_contain(does haystack: List(value), contains needle: value) -> Nil

as it still results in a concise API that might look like this
some_list
|> expect.list_to_contain(some_item)

some_string
|> expect.string_to_contain(some_substring)

eventually.
If help is accepted, I'm offering myself to contribute to this project, although I cannot make guarantees about how fast I can make such contributions because ... life and stuff^^
All the best.

Are such assertions on the roadmap?

Yes, I would love to eventually have a bunch of useful assertion functions 😄

As of now, I'd favor implementing different functions per supported type like
pub fn string_to_contain(does haystack: String, contains needle: String) -> Nil
pub fn list_to_contain(does haystack: List(value), contains needle: value) -> Nil

This is in line with what I was thinking as well. It seems very Gleam-y!
I just added a few new assertion functions to main:

expect/string_to_contain
expect/string_to_start_with
expect/string_to_end_with
expect/list_to_contain

They'll be available in the next version, which should be out in the next week or so.

That's great news, thanks for implementing them!

They'll be available in the next version, which should be out in the next week or so.

Awesome, looking forward to replace my custom assertion with the new one when the next version is released.
I'll keep an eye out if I find more interesting use cases when using Startest in my projects.


Can't get tab selection to work

Given two tabs

When I select the second tab "Page Layout" I get this instead

Originally i've thought that the place of residence of this component is border layout at north. I need to figure out how to stay fit in another place. This project was made solution of quick and dirty :( You're the first one who use it besides me. So I'd like to clean it up.
First of all I'd like to correct these issues.

Originally i've thought that the place of residence of this component is border layout at north. I need to figure out how to stay fit in another place. This project was made solution of quick and dirty :( You're the first one who use it besides me. So I'd like to clean it up.
First of all I'd like to correct these issues.

@csekme I understand quick and dirty (my friends in England call such programs cheap and cheery).
My first open source project started that way and now its evolved into a nice program.
If you check out my repro you can see my current ribbon.
GUIsliceBuilder
The  current ribbon is part of a third party open source project called insubstantial subproject flamingo.  Its no longer supported and its causing my program to crash and burn on various platforms including Apple's MacOS.
The code is impossible to follow so I thought I would try and write my own.   Then I found yours and its really quite well done and simple to understand.
So good job!
It makes a good starting point for me.   Two additional items I plan on adding are Tooltips and action commands.  If you are interest in either of them I'll post a pull request when I'm finished.
Paul--

@csekme I understand quick and dirty (my friends in England call such programs cheap and cheery).
My first open source project started that way and now its evolved into a nice program.
If you check out my repro you can see my current ribbon.
GUIsliceBuilder
The  current ribbon is part of a third party open source project called insubstantial subproject flamingo.  Its no longer supported and its causing my program to crash and burn on various platforms including Apple's MacOS.
The code is impossible to follow so I thought I would try and write my own.   Then I found yours and its really quite well done and simple to understand.
So good job!
It makes a good starting point for me.   Two additional items I plan on adding are Tooltips and action commands.  If you are interest in either of them I'll post a pull request when I'm finished.
Paul--

@csekme FYI, I have isolated the problem to the toggle function. If I comment out the minimize part my pageLayout tab comes up fine.
Paul--

@csekme FYI, I have isolated the problem to the toggle function. If I comment out the minimize part my pageLayout tab comes up fine.
Paul--

Dear Paul,
I'm so glad that you find it useful. Thanks for your kind words. It's always good to get a positive feedback.
Yes of course that would be great. I am keen on waiting your additions.
I will check your project definitely.
Thanks,
Krisz

Dear Paul,
I'm so glad that you find it useful. Thanks for your kind words. It's always good to get a positive feedback.
Yes of course that would be great. I am keen on waiting your additions.
I will check your project definitely.
Thanks,
Krisz

@csekme I just issued a pull request to make the fix for this issue.
Paul--

@csekme I just issued a pull request to make the fix for this issue.
Paul--

I am new in git, I've used subversion before. I have confused a little bit with pull request, but now i think it's okay. It merged successful. :D

I am new in git, I've used subversion before. I have confused a little bit with pull request, but now i think it's okay. It merged successful. :D


Add code owners file

@FelixFaassen-TomTom, does this look good to you?

@casparvanderheiden-tomtom yes great. One little thing, make sure you do not commit CODEOWNERS to upstream PR's hahah but as I understood that will not happen ;-)
Thanks Caspar and have a lovely day!

I almost did that... 😅 With these forked repos you also have to look twice which target branch you set for a PR....


Feature Request: Allow easier editing of a Bazel external source code when used as new_local_repository

I am developing a small library that is consuming a framework that we are developing, and for ease of use, I would like to be able to edit an external while consuming it in a project.
For my first attempt, I added my external project, and tried to ensure that its files are accessible via .bazelproject. Say my projects are upstream and downstream, such that it is organized as:

downstream/

externals/

upstream/

If I navigate to upstream, open up a source file, and toggle to the header file, it opens the symlink'd version buried within Bazel's cache, which makes sense due to how the includes are structured.
However, I would like it to open up the project version of the file (which in this case is neighboring the source file), so that project-level code inspection works as expected (Find Usages, etc.).
An initial thought is to write a quick plugin that hooks into any Open Document events, and just resolves the symlink (at least on a Unix system) using something like readlink -f ${path} (or even just resolves one level of the symlink, e.g. if I've symlinked my external in for development).
EDIT: It looks like another intermediate would be to change ArtifactLocationDecoderImpl to enforce symlink resolution, possibly using the OS version if necessary (at least as a local hack for myself).

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


When browser is in spanish not work.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  vscode.dev
OS Version: vscode.dev

Steps to Reproduce:

Access to the vscode.dev
the URL change to the vscode.dev/?vscode-lang=es-419
The screen hang in black.
when i see the network they request a javascript, but the url not exists: https://www.vscode-unpkg.net/nls/e8653663e8840adaf45af01eab5c627a5af81807/1.95.2/es-419/nls.messages.js

In english not change the url and the nls.messages.js is load from other url.

There is how the browser appear.

Its with spanish (latinamerican) the problem, we can change to other spanish an work, but with the language not work.

@TylerLeonhardt for vscode.dev localization

Can confirm, can't access with language: es-419, i tryed changing the query parameter, but still can't open vscode

I repro this. The problem only exists for spanish (latinamerican) (aka es-419). Every other Spanish works fine. I wonder if we have a bad Regex somewhere that is only looking for alpha characters and not numbers.

Found the problem. Deployed a fix. This should be good now. Can you try again?

tried to access "vscode.dev/?vscode-lang=es-419" but it would re-route me to vscode.dev every time- do I need to install an extension to allow this to work?

Verification:

Open Edge and change to language to "spanish (latinamerican)"
navigate to vscode.dev

It should automatically include the language query parameter and vscode.dev should load


Error: @nestlab/google-recaptcha tried to access rxjs

Error: @nestlab/google-recaptcha tried to access rxjs, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

The problem occurs when using yarn pnp mode, since rxjs is not listed in the peerDependencies list, but is used

Hi @DiFuks, thanks for your issue, declared as peerDependency since v3.1.8

Sorry I didn't say right away - same problem with axios dependency

@DiFuks v3.1.9


enabled versioned MinGW-w64 .dlls on cmake

This enables versioned .dll shared libraries on cmake using MinGW-w64, in concurrence with autotools also producing versioned .dll shared libraries.

I performed the following steps in Win10 with cmake and MinGW:
mkdir build
cd build
cmake -G"Unix Makefiles" ..
make

But I can't find any dll file. Did I do it wrong? @Adsun701

@willson-chen The generator should be MSYS Makefiles.

Sorry...It failed again. I had tried MSYS2 with cmake -G "MSYS Makefiles" .., but still no dll was found.
And referencing #63 , I am not sure building dynamic and static libs at the same time is nessary.


Update package name and URLs to be NS-specific

I think I did this right?
@msmathers @ns-ctruong @Salt7900

Yea the URL's look good from what I remember from the lint-package.
You might want to change the author, but other then that it LGTM


Uncaught TypeError: Cannot read property 'apply' of undefined

Hi, I am trying to integrate web sockets server for PUSHER API replacement in my project. I am using Laravel 6.2 with mysql and also I have integrated CoreUI Admin panel in my project. I am following the official documentation at https://beyondco.de/docs/laravel-websockets/getting-started/introduction for the same.
I have everything working fine on public channel, but while sending the event notification to client I am facing an error at client side saying
app.js:40301 Uncaught TypeError: Cannot read property 'apply' of undefined
at Channel.Dispatcher.emit (app.js:40301)
at Channel.handleEvent (app.js:41964)
at app.js:38832
at ConnectionManager.Dispatcher.emit (app.js:40301)
at message (app.js:46906)
at Connection.Dispatcher.emit (app.js:40301)
at message (app.js:41694)
at TransportConnection.Dispatcher.emit (app.js:40301)
at TransportConnection.onMessage (app.js:40198)
at WebSocket.socket.onmessage (app.js:40215)
Dispatcher.emit @ app.js:40301
Channel.handleEvent @ app.js:41964
(anonymous) @ app.js:38832
Dispatcher.emit @ app.js:40301
message @ app.js:46906
Dispatcher.emit @ app.js:40301
message @ app.js:41694
Dispatcher.emit @ app.js:40301
TransportConnection.onMessage @ app.js:40198
socket.onmessage @ app.js:40215
It seems there is some issue in the callback method, I am struggling with this for few days now and is not able to identify the cause or fix for this. My pusher js version is 4.4.0 and laravel-echo version is 1.8.1
The event is getting notified successfully to the web sockets server and also the client is able to make successful connection with web sockets server, therefore now I have replaced the pusher service with my local server instance. Also I am using this code in blade file for event callback for the client to listen to
    Echo.channel('home')
        .listen('NewMessage'), e => {
            console.log(e.message);
        alert(JSON.stringify(e.message));
    }

Kindly suggest what configuration error I might be doing which is causing this issue.
Thanks,
Saurabh

If you pasted the exact code, to me it seems there is a syntax error, this would work:
.listen('NewMessage', e => {
            console.log(e.message);
        alert(JSON.stringify(e.message));


Use lamE instead of LamE to simplify and future-proof for GHC 9.10

I've uploaded invariant-0.6.3 to Hackage with these changes.


Workspaces not restored after VSCode update in windows displaying "Release Notes" tab

I searched open issues, didn't find anything like this.
I'm not sure how to check this on the Insiders build...

VSCode Version: 1.26.0
OS Version: macOS 10.13.6

Steps to Reproduce:

Quit VSCode while multiple windows (and therefore workspaces) are open. Each workspace has a single folder open within it, each a different folder.
This time, I rebooted my laptop. Not because I thought I needed to, but because I had other updates I needed to install. I didn't know VSCode would also be updated.
Once rebooted, start VSCode, which happened to install the latest 1.26.0 update (I had been on 1.25.x).

4 of the 7 windows/workspaces I had open were correctly restored, but did not show the "Release Notes: 1.26.0" tab. The other 3 did show the "Release Notes" tab, but did not restore my workspaces.
So for the windows that ended-up showing the "Release Notes" tab, VSCode did not restore their respective workspaces (correct folders open, but no previously-open files and tab layouts).
Does this issue occur when all extensions are disabled?: Too late to tell since VSCode has already been updated.

@stefcameron how much time ellapsed between shutdown of VSCode and restart of the OS? Maybe Code was still busy storing UI state even though no window was visible.

@bpasero Good question! I would say about a minute, not much more. What's curious to me is that only 3 of the 7 windows displayed the special Release Notes tab after OS restart and manual VSCode relaunch. Those 3 didn't restore workspaces. The other 4 restored their workspaces, but didn't show the special Release Notes tab. Why did this split happen, and what determined those 3 only and not the others? Is there a process in showing the Release Notes tab that prevents the workspace from being restored properly?

@stefcameron not sure, does this reproduce reliably even now that you updated? e.g. I would not expect the release notes tab to open each time (just once after an update).

@bpasero I hadn't upgraded at home yet (different laptop, same OS, same initial VSCode version at 1.25.x), and I had 2 workspaces/windows open. So I quit VSCode, waited about 30 seconds, checked there was no longer a black dot beneath the VSCode icon in the dock, and then relaunched VSCode. Then I got this error message:

First time. I had never seen that before.  The only thing I could do from this dialog was choose "Close" because "Reopen" wasn't doing anything. That caused VSCode to close/quit. There was no longer a black dot beneath its icon in the dock after that.
So I relaunched again. This time, VSCode came up. My large workspace was fully restored (😌), but the Release Notes tab didn't show-up in it. My other workspace was completely blank, like I had never opened that folder. I checked the VSCode version, and I was still at 1.25.x (the latest patch before 1.26.0). So I quit again, hoping to trigger the upgrade in the same way as originally.
When I relaunched again, my large workspace came back up, no Release tab. My other workspace, which was now "empty" (reset from the error that occurred) had the Release tab displayed in it. I'm now upgraded to 1.26.0.
I have screenshots of my workspaces before, in the middle, and after, if what I wrote here isn't descriptive enough. I'm not sure you'll be able to conclude anything from this, though, but I still feel like there's an issue here, possibly a couple in light of the error I experienced this time.

@bpasero I followed your instructions on both laptops and all workspaces were restored correctly. I tried this at home yesterday, at which point it seems 1.26.1 wasn't posted yet because an upgrade didn't happen. When I tried this at work just now, 1.26.1 was posted, so the upgrade took place when I relaunched VSCode. The Release tab showed-up in 2 out of 6 workspaces, but this time, all workspaces were correctly restored. ¯\_(ツ)_/¯


[RC3] [LVM]Volume creation goes in 'error' state if Profile has advanced policies set

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

What happened: Created a profile with QoS Policy, Replication Policy, Snapshot Policy enabled (with all default values). Volume creation goes into error state.
What you expected to happen: Volume creation with block profile having advanced policies set, should happen seamlessly
How to reproduce it (as minimally and precisely as possible):
a) Create a block profile wit QoS policy, Replication Policy, Snapshot Policy enabled (with all default params).
b) Create a volume [LVM]
c) Volume gets created successfully
d) Go to volume listing page and the volume is in error state
e) in the backend there is no volume created (lvs command check)
Anything else we need to know?:

E1226 15:54:10.003546  548651 filter.go:99] pool: opensds-volumes doesn't provide capability: extras.dataProtection.recoveryTimeObjective
E1226 15:54:10.004240  548651 filter.go:99] pool: opensds-nfs doesn't provide capability: extras.dataProtection.recoveryGeographicObjective
E1226 15:54:10.004252  548651 selector.go:157] Filter supported pools failed: no available pool to meet user's requirement
E1226 15:54:10.005489  548651 grpcserver.go:92] call function 'github.com/opensds/opensds/pkg/controller.(*Controller).CreateVolume-fm' failed: no available pool to meet user's requirement
Environment:

Hotpot(release/branch) version: v0.8.0
OS (e.g. from /etc/os-release): Ubuntu 16.04
Kernel (e.g. uname -a):
Install tools:
Others:

@kumarashit I looked the defect. And as per my observation, it's correct behaviour.
In log you can see,  no available pool to meet user's requirement. This message is coming because it doesnt' have any pool to support user's requirment. For ex: let's say you have created a profile of MaxBws 1000Mb/s, but your pool is only supporting MaxBws 100Mb/s. In this case if you want to create volume using this profile, it will fail.
So Very similar scenario is happening in this defect And it is failing.
So i think it's not an issue. It;s correct behaviour.

@PravinRanjan10 there is this basic issue then. Why the Volume creation went successfully then. Other thing, do we have pool creation available for lvm? We are trying to put open many loose ends here


Synchronize changes from alt-1

This is an attempt to bring in all changes that have been applied to alt-1 but not yet made it to p3.

Couldn't find a cleaner way than reverting the keystone commit


[terra-search-field] Added right border to search input

Summary
Added right border to search field input.
Closes #1730.

Now has a double border which is not ideal, so needs to overlap and swap z-index on focus. Some additional quick adds/fixes:

Add (to match terra-date-picker):

.input {
   ...

    &:focus {
        z-index: 1;
    }
}

Update:

.button {
    ...
    margin-left: var(--terra-search-field-button-margin-left, -1px);

And lets update any/all ems to px, since the borders and border-radiuses should stay fixed and not be relative:

0.25em  => 3px
0.071em => 1px

@tomleewu let's update filter view with the same functionality

Reviewed:

all changes have been applied and looks good.

Marking as Verified, ready for Release.

Pass

UX Review

@bjankord ready to merge


[Cosmos] Adds v1 partitionKey hashing

At a high level, this adds support for hashing v1 partitionKeys. We do this to support comparing partitionKey ranges to hashed partitionKeys in order to support bulk operations in this SDK.
Lower level additions:

Adds a Murmurhash implementation from murmurhash3js-revisited after having issues with typescript imports. https://github.com/cimi/murmurhash3js-revisited/blob/master/lib/murmurHash3js.js
Adds hashing support for effective partition key components String, Number, Null, Undefined ({}), and True/False
Handles conversion of JS numbers to 64 bit ints via BigInt and some clever DataView use from @southpolesteve

@bterlson This is adding some functionality that is necessary for bulk operations. We need to start hashing partition key values on the client-side. But it introduces some new challenges around version support since IE and Node 8 both won't have BigInt. We can avoid literals easy enough, but even if we polyfill I believe all our bitwise operations won't work. Thoughts?

This has been combined with #10168


FancyZones Glitching Out

Microsoft PowerToys version
0.76.2
Installation method
GitHub
Running as admin
No
Area(s) with issue?
FancyZones
Steps to reproduce

Open FancyZones in the PowerToys Settings
Try to scroll all the way to the bottom

✔ Expected Behavior
Scrolls to the end of the page
❌ Actual Behavior
Starts glitching out before the end
https://github.com/microsoft/PowerToys/assets/19395432/7954199d-6f85-48e1-91af-4e6af6a82c03
Other Software
No response

/dup https://github.com/microsoft/PowerToys/issues/25353


[Logseq] Add current time to quick note

Extension – Loseq
Author: @futantan @sxn
Describe the feature and the current behavior/state.
I would like the extension to add the current time to the note that I create.
Two approaches possible for this:

Pre-fill the current time as I start a new note
or automatically prepend the time to the note

The outcome would create a note that looks like
- 09:13 Adding a note

Who will benefit from this feature?
Anyone who does bullet journaling with Logseq
Thanks!

Will close for the time being!

@galligan Please refer to #2111

And let me know if this is the feature you want?
Since we have more people requesting this feature, it's time to ship it!

Looks great @futantan! Thanks for doing this!


TASK: Implement Connection::QueueSubscribe

Coverage decreased (-2.3%) to 78.613% when pulling 71605e6167518dea6b06788587167fed07cea2d8 on dfeyer:queuesupport into 068082e48cbae26c4a7d896693cd9fb3667188cc on repejota:develop.


Wrong place for exclamation mark

In my schema I have groups: [CustomerGroup!], but Voyager display it as "groups: [CustomerGroup ]!".
The opposite case, when I set in the schema groups: [CustomerGroup]!, the Voyager shows it as "groups: [CustomerGroup !]"
"apollo-server-express": "^1.3.0",
"babel-cli": "^6.26.0",
"babel-core": "^6.26.0",
"babel-plugin-module-resolver": "^3.0.0",
"babel-preset-es2015": "^6.24.1",
"babel-preset-stage-2": "^6.24.1",
"express": "^4.16.2",
"graphql": "^0.11.7",
"graphql-tools": "^2.13.0",
"graphql-voyager": "^1.0.0-rc.10",

app.use("/voyager", middleware({ endpointUrl: "/graphql" }));

@piotrgorecki Good catch  🐞 🔍
Fixed in 1.0.0-rc.11 and demo.

Thanks @IvanGoncharov! Now it works correctly.


Custom directory support

Hello @mohammad-fouladgar.
How can we use the package in custom directories? (not only default directory App\EloquentFilters\MODEL-NAME)

Hi @50bhan ,
You can change the default namespace with publish the config file.
Please checkout the documentation : Namespace With Config file

@mohammad-fouladgar ,
I think you misunderstood my question. Let me put it this way: what if a user wants to use the package in MULTIPLE custom directories?! Apparently now this is not possible, because default namespace in not enough for this situation.
So I might have an idea to add this feature to the package. What do you suggest? Let me know if you welcome the idea.

@50bhan ,
That is, if we have a modular system or DDD (Domain Driven-Development), we will can customize the filter namespace per domain, I'm right?

@mohammad-fouladgar ,
Sure, let me get my mind around it then I'll send a PR.

This is a great idea as long as it does not disturb the current structure.
Feel free to submit a fully tested PR.
Good luck Man


fix: make foApprox mdata-invariant

Test case by @larsk21. This came up in the context of https://github.com/larsk21/iris-lean.


packages updated without version upgrades

I am using aptly to mirror the salt repo:
http://repo.saltstack.com/apt/debian/8/amd64/2016.11

More than once I have found that packages have been rebuilt with the same version and a different checksum. This is the 3rd time I have seen this, and this time the offending package was:
bsdmainutils_9.0.6_amd64.deb

I have raised a separate bug as this package is already in jessie.
And the aptly error message was:
ERROR: unable to publish: unable to process packages: error linking file to /var/lib/aptly/repo/public/salt-main/pool/main/b/bsdmainutils/bsdmainutils_9.0.6_amd64.deb: file already exists and is different

For the command:
aptly publish switch jessie salt-main salt-main_-_2017-03-09T13:17:52Z

This is particularly bad as -

Sites using the repo directly will not match the packages you have released and it will be difficult to diagnose this.
Packages will not be upgraded when you provide an upgrade.
it first blocks mirror updates for anyone using aptly mirror functionality.

To resolve this issue I would recommend you manage your salt repositories with aptly as it is the best repository management tool I have so far used with debian and a very fine program. (far better than repropro) but a simple monitoring script could be developed by you guys too.

@osynge The issue of using reprepro is covered in https://github.com/saltstack/salt/issues/33458
where it is done for a future consideration, when time allows.
Since this is already covered by another issue, I am marking this as a duplicate.
The issue of bsdmainutils 9.0.6 was covered in issue https://github.com/saltstack/salt-pack/issues/222
and the recent release Salt 2016.3.6 was corrected.
If this satisfies your issue, can you consider closing this issue, and track  the issue of using aptly on https://github.com/saltstack/salt/issues/33458

@osynge I am closing this since it is a duplicate. If you are unsatisfied with this, please feel free to  reopen this issue or add additional comments to saltstack/salt#33458.
Thanks for bring this issue to our attention.


Expand table columns to fill available width

Done for gnomAD in fdbcebc8406f3cde2e194b35381625486354a8c1. Should be applied to the table component in general.

The Grid component has this feature and will eventually replace the current variant table.


Ethan: Watch (?-i:simileyskiy)(?# github.com)

Ethan requests the watch of the watch_keyword (?-i:simileyskiy)(?# github.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:simileyskiy)(?# github.com) has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Approved by Ollie in Charcoal HQ


Added new configuration property buildSourceDir

When you use java annotation processing like in Dagger2 you need to specify where the additional generated source is located.
Using buildSourceDir in your config lets you define it.
There one problem you might be able to solve quickly. When doing gradle j2objcTranslate the second time it only restarts the task if sources in src/mani/javahave been change. My buildSourceDir is:
buildSourceDir "${projectDir}/build/source/apt"

The translation task is not done a second time if files have changed. Could you fix that?

Okay now it should be fine.

@confile - thanks for the change, I need to get dagger working so I can
properly understand the change. I also want to make sure that it works
correctly with the gradle dependencies. I'm not sure if generated code
should be part of @InputFiles on each task - something that gradle uses to
check when files are out of date. My sense is that this shouldn't be an
issue as they're generated but that's what I'm trying to figure out.
On Wed Feb 11 2015 at 6:06:01 PM Confile<EMAIL_ADDRESS>wrote:

Okay now it should be fine.
—
Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/pull/10#issuecomment-74004939
.

Okay let me know when you get dagger2 running. From my point of view it is only a small step left. I posted you the configuration you need to get it running. Just use the atp plugin and it works and be sure to use the dagger sources with dependencies not the one without.

I'm concerned the apt plugin may be an issue.... I'm using a shared project
without any android dependencies and I believe that apt depends on that. I
will get this working ;-)
On Wed Feb 11 2015 at 6:31:30 PM Confile<EMAIL_ADDRESS>wrote:

Okay let me know when you get dagger2 running. From my point of view it is
only a small step left. I posted you the configuration you need to get it
running. Just use the atp plugin and it works and be sure to use the dagger
sources with dependencies not the one without.
—
Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/pull/10#issuecomment-74007198
.

@confile - I had one change for you on naming and then I'll merge the request.

@brunobowden Okay I did the change. Did you make any progress on Dagger2 integration?

Can you also change the comment as well - I put in a note about indicating
theat it's ONLY generated files, so people don't add other sources by
mistake.
On Sun Feb 15 2015 at 1:25:31 PM Confile<EMAIL_ADDRESS>wrote:

@brunobowden https://github.com/brunobowden Okay I did the change. Did
you make any progress on Dagger2 integration?
—
Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/pull/10#issuecomment-74437899
.

I haven't made progress on dagger. I'm being pulled away to something else
for a week or two and then I'll return. Annoying I haven't got it up and
running yet.
On Sun Feb 15 2015 at 1:28:46 PM Bruno<EMAIL_ADDRESS>wrote:

Can you also change the comment as well - I put in a note about indicating
theat it's ONLY generated files, so people don't add other sources by
mistake.
On Sun Feb 15 2015 at 1:25:31 PM Confile<EMAIL_ADDRESS>wrote:

@brunobowden https://github.com/brunobowden Okay I did the change. Did
you make any progress on Dagger2 integration?
—
Reply to this email directly or view it on GitHub
https://github.com/brunobowden/j2objc-gradle/pull/10#issuecomment-74437899
.

@brunobowden Comment changed

Thank you!


Improve gvproxy error reporting, and improve gvproxy --version in a corner case

See the git commit logs for more details about what was done.

/lgtm
/approve


full resolver for teams

maps ID to names and names to ID
as usually, the code in libkb.Resolver does not verify its replies
use team.ResolveIDToName and team.ResolveNametoID for a verified resoltion in both cases.
cleanups and code reorganization:

organization; move a lot of code out of service/identify and into teams/, where applicable
cleanup resolve+team integration in general
cleanup initial setting of the PVL and TeamLoader variables off of G; populate the real examples in service/ and not in client/

tests for the new resolver

Cc: @strib  and also @mlsteele