Injecting or passing in HttpClient

It would help testing if I could pass in HttpClient or IHttpClientFactory into DaprClientBuilder.
I can see an internal HttpClient Factory used for internal testing:
https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.Client/DaprClientBuilder.cs#L70
internal DaprClientBuilder UseHttpClientFactory(Func<HttpClient> factory)
  {
      this.HttpClientFactory = factory;
      return this;
  }

Which then is used here:
https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.Client/DaprClientBuilder.cs#L158
And that there is an extension in the ASP.NET Core project:
https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.AspNetCore/DaprServiceCollectionExtensions.cs#L39
            services.AddSingleton(_ =>
            {
                var builder = new DaprClientBuilder();
                if (configure != null)
                {
                    configure.Invoke(builder);
                }

                return builder.Build();
            });

Can there be constructor that takes in an HttpClient? Or an IHttpClientFactory?
With that I can wire up my test cases to use test handlers to ensure the responses I want out.
I know that I can wrap Dapr in an interface and inject that.

I can see the benefit of extracting an interface for the DaprClientBuilder or DaprClient so it can be injected and mocked in the classes of the application we are building. However, I dont' see why we we would need to inject an interface (hence mock) in the DaprClientBuilder itself.
Can you provide more context on how you are using this?

I think having an interface for DaprClient will fulfill the need for what I am looking for. An IDaprClient would be perfect for registering, injecting, and mocking.
I agree that HttpClient wouldn't need to be injected after thinking about the context a little more.


docs: add devenv, linkcheck, and refresh misc config etc

Docs related chore maintenance to keep up to date with JupyterHub org practices etc.

The changes to docs/Makefile and docs/make.bat adding make devenv and make linkcheck is copy pasted from other JupyterHub repo's.
I removed hard pinning in docs/requirements.txt, like we have in all(?) jupyterhub repos
I updated the readthedocs config to v2 of their API
I updated .gitignore to include the copy pasted Python.gitignore on GitHub
I refreshed docs/source/conf.py to follow modern practices etc
I added copybutton, opengraph, redireaffe sphinx plugins
I fixed warnings about links when using make html

Related

https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2909
https://github.com/jupyterhub/binderhub/pull/1565

Thanks for the review @choldgraf! I'll go for a merge here, let's iterate from this!


Map requirements from Mission requirement aggregations to ESO L3 /L4 requirements

Is this necessary?
Map mission requirements from: https://docs.google.com/spreadsheets/d/1HxT3ZMNWRlan1Mx12rzNQnn3q-lQJJNGgMD1NCrb0RA/edit#gid=0
To: https://cae-jama.jpl.nasa.gov/perspective.req#/items/2464641?projectId=88
Basically: are we looking for mapping from the use cases to the project requirements? or what project requirements are "closed" by the entire ESO architecture

let's hold off on this for now. This might be more useful during implementation, but not for the reviews.


Adding tags for documentation & Correcting the documentation link

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

 https://github.com/Azure/azure-sdk-for-python/pull/1667

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-ruby/pull/1159


SRID missing in SQL export for MySQL Spatial/Geometry columns

Description
The export features in DBeaver do not include the SRID for spatial/geometry columns if it's set for a MySQL column.
DBeaver generates SQL with its export function or with its Generate SQL function that looks like this: ST_GeomFromText('POINT (58.56054591 11.55698829)') but it should include the SRID if it's set for the column, generating the correct SQL like this: ST_GeomFromText('POINT (58.56054591 11.55698829)', 4326)
DBeaver Version
Community Version <IP_ADDRESS>308201919
Operating System
macOS Ventura 13.4.1
Database and driver
Driver: com.mysql.cj.jdbc.Driver
Database: MySQL 8.0.33
Steps to reproduce

Create a table in MySQL with the following DDL:

CREATE TABLE `geotest` (
  `id` int NOT NULL AUTO_INCREMENT,
  `geo_point` geometry NOT NULL SRID 4326,
  PRIMARY KEY (`id`),
  SPATIAL KEY `geo_point_spatial_index` (`geo_point`)
);

INSERT INTO geotest (geo_point) VALUES (ST_GeomFromText('POINT (11.55698829 58.56054591)', 4326))

Now open that table and export the one row by right clicking on the row, selecting Export Data. Follow the wizard and get the generated MySQL.
Alternatively: Right click on the row and chose Generate SQL → Insert

The generated SQL is for me INSERT INTO geotest (geo_point) VALUES(ST_GeomFromText('POINT (58.56054591 11.55698829)'));

Run this generated SQL to insert a new row in the DB. this fails for me with the message SQL Error [3643] [HY000]: The SRID of the geometry does not match the SRID of the column 'geo_point'. The SRID of the geometry is 0, but the SRID of the column is 4326. Consider changing the SRID of the geometry or the SRID property of the column.

The problem is that the DDL specifies SRID 4326 but the generated SQL above doesn't use it. The correct query to be generated should use the configured SRID like shown in step 1 above as the second parameter in the ST_GeomFromText function.
Additional context
No response

Hello. Thank you for the report.

Same here


Does lazyload.js affect indexability?

Currently the sitemaps I generate for SEO purposes only see my loader.gif. How can I get my images rendered through lazyload to get indexed by crawlers?
Thanks in advance.

If crawler parses and executes JavaScript then it can see the original image. If not then crawler sees the loader image.

Gotcha. Currently I've just added  tags for rendering an image in case Google has issues with the js. Do you think that is a sufficient solution?

Since I do not know what you actually did cannot tell for sure. But if you can see image tag by viewing the source then Google should see it too. I think Google has a tool for testing that too. In Webmaster Tools or something similar.


Own namespace for UberLogger

Please put all UberLogger classes in their own namespace.
Otherwise you will get problems with bigger unity projects.

So:

UberLogger.cs is in a namespace.
UberDebug.cs is in a static class (which acts like a namespace in this
context).
UberLoggerFile, UberLoggerEditor, UberLoggerEditorWindow and
UberLoggerAppWindow are not in a namespace, partly because UberLogger was
written when namespace support was a bit spotty in Unity, and partly
because the names themselves are very specific. Obviously they could be
moved into the UberLogger namespace and renamed, if needed.

I'm happy to take a PR to consolidate these into a namespace if people
think this is going to be problematic in the future; but is anyone actually
hitting any naming conflicts at the moment?
On 12 March 2017 at 15:21, Michael Lohr<EMAIL_ADDRESS>wrote:

Please put all UberLogger classes in their own namespace.
Otherwise you will get problems with bigger unity projects.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bbbscarter/UberLogger/issues/24, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4w-zK3jtEMSdFngfBIeY6Ir3pz1rOzks5rlA1vgaJpZM4MakZy
.


./configure fails while "checking whether mmx is supported"

Exact output was:
checking whether mmx is supported... ./configure: line 4843: 0xunknown: value too great for base (error token is "0xunknown")
I'm running this on x86_64 Arch Linux. No other previous errors/warnings were given. I've gone through this process on Ubuntu and Fedora with success, but I haven't run into this problem before. Any clues as to what's going on and what to do? Thanks in advance!
Just to clarify: this error results in no Makefile being generated, so running make returns with make: *** No targets specified and no makefile found.  Stop.

Hi @Kishaihd
I ran into this when targeting Android's x86_64 platform. I believe this fixed in that case https://github.com/jgaeddert/liquid-dsp/pull/62/files#diff-4bb328fbe3180ab54cff2f63f71c3a77
You might want to try that entire PR and see if it fixes it

Hi @brian-armstrong
I tried that entire PR, but got the same error. :/
The successes I had with Ubuntu and Fedora were on this same laptop, so the hardware is all the same too.

Just to be clear, did you invoke bootstrap.sh again after applying the patch?

I did, I completely removed the liquid-dsp folder, re-pulled that specific PR from github, and started again with ./bootstrap.sh.


Update CMakeLists.txt

added -fPIC flag to ld by added SHARED to CMakeList.txt

Referring to https://github.com/gpu/JOCL/issues/3#issuecomment-213085471 , I'll close this request for now.


Allow all users to access multipart upload metadata dir

What changes are proposed in this pull request?
Allow all users to access multipart upload metadata dir.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

why this change? doesn't this expose risk of modification for all users?

@lucyge2022 If the users do not have the same group, some users do not have write permissions to the meta directory, resulting in failure to upload files.

actually i think this is not a problem of the bits to set on this system folder, it is that when using metaFS to access this folder metaFs should be in the name of a alluxio master recognized superuser. otherwise when people wanted to use the root mount as ready only (alluxio.master.mount.table.root.readonly=true) metaFs is still unable to create this dir    ->  will take a look internally but IMHO this is not the right way to fix it once for all

@lucyge2022 Thank you! I found that the issue I was concerned about has been fixed, I will close this pr.


Set up self managed gitlab runner

As developers, we need a self hosted runner on the new gwas-gromit VM in Harlow to support GitLab jobs.
The present shared runner used by the GWAS project CI/CD has been problematic and has gone from bad to worse in the past weeks, now almost impossibile to use. The web prod has responded that the shared runners should not be relied on for production.
Useful info from previous conversation with IMPC Project team:
There are different types of runners that can be set up, the IMPC project has used a docker runner, but that may not be the best option if working with docker-compose. There are also some caching issues to consider. Any machine you put together will need some kind of task to do some house keeping as otherwise the disk can fill up very quickly. Also worhty of note is that if DinD is used at all there will be need to make the runner a privileged user which is definitely a security risk.
Confluence Guide on Installation:

TODO:

figure out and document how the gitlab logs work
determine whether the resources can support another runner or whether we should provision another VM

allocated more free space to the /var dir
increased the concurrency to 4


make conda installable

via conda-forge

conda install now works for linux!
added here: https://github.com/conda-forge/staged-recipes/pull/26567#issuecomment-2151427461
feedstock here: https://github.com/conda-forge/sourmash_plugin_directsketch-feedstock


Support images from notifications

It'd be nice to support HA notifications with images like the Android companion app, e.g. for camera snapshots from frigate and such.
It seems the underlying Js library does support sending images.

thanks for your time!
I will try and see how this can be obtained ;)

this https://github.com/baldarn/whatsapper/commit/adffb81ef5e481a0773cf6e8750a13cdd73c6834 add the function


ANNOUNCEMENT !!! UPDATE YOUR FORK

The following PR is updating the file structure in your forks.
For those comfortable with GitHub , it should not be much of a problem.

P.S I am sending a new PR to all of you.
Make sure to merge them

needed file structure update.

@prateekiiest  I merged my repo & its updated now.


[Feature request] Disallow users from changing ident

Apart from editing the add_edit_user.tmpl -file and the ident field, I cannot see a method to disallow users from changing their ident. I think editing the HTML also leaves a hole for users to modify the HTML back to "normal". Is there a method to only show the user's ident in a disabled field, while also not allowing the form to change the ident?
For the feature request; can we get a feature where only the admin can change the ident for a user?

"Another commonly used value is %user%, which is the name of the ZNC user connecting to IRC. As it may not be changed by normal ZNC users, it's often useful for BNC providers or anyone sharing the ZNC instance with others."
https://wiki.znc.in/Identfile#Commands


Add tests for type-parameterized types.

Heya, here are the tests corresponding to the type parameter support added in: https://github.com/BenHall-7/diff-derive/pull/2.
If it's good with you, please could you also publish both crates :slightly_smiling_face:, I'm kinda excited to get my pet project going with this.

@azriel91 Hey! I decided that since this didn't change any pre-existing behavior, it was suitable for a minor version bump. I've published both the derive and the main crate under diff_derive = "0.2.2" and diff_struct = "0.4.2"


Clarify the update strategy for the PowerShell global tool

Since PowerShell v7.1.0 had a few release candidates and now released as stable, it would be cool to have the global tool updated accordingly.
Additionally, is there any documentation on how and when the global tool gets updated?
I just want to ask because

the last release took some time too until it got published
no preview or rc release got published recently

Thanks for your efforts and the great work!
/cc @iSazonov, @adityapatwardhan

Just released the global tool. It might take a couple of minutes to be available.
We only release the GA versions, hence no RC and preview builds.

Thanks for the amazing fast response, I really appreciate that! 🙏👍


Relax constraint on rubocop-govuk dependency

In #261 (specifically this commit), most of the dependency constraints were relaxed to use pessimistic constraints. For some reason this gem was pinned at 4.7.0, but there's no explanation in the commit note or the PR description.
Since Rubocop seems to run OK with the latest v4 of rubocop-govuk, I think it makes sense to relax this constraint. This should mean we don't keep getting Dependabot PRs for every patch version of rubocop-govuk.

I'm a bit late to the party. I'm conscious it's introducing inconsistencies across other GOV.U's gems.
Following the RFC to Allow auto-merging of 'internal' Dependabot PRs we have the GOV.UK Dependabot Merger on it's way. This should help with keeping the version up to date.
You might want to revert this change once you opt in for the auto-merger :)

@AgaDufrat Thanks for your comment and for the documentation references. I'm sorry if we've done something that will cause problems for others - I'm happy to revert it if you prefer.
I've had a bit of a read of the docs, but I didn't see anything about pinning the version of internal gems. Did I miss that?
Also since this repo (gds-sso) is itself a (relatively) internal gem, it seems odd to pin the version of one of its dependencies - I would've thought that was more of a choice for the applications that are using it...? But it sounds as if I'm missing something!


Kubeconfig not loaded - without any response

After adding the extension to vscode and opening the Kubernetes tab, no clusters or other data is shown.
When I then select "Set Kubeconfig" from the menu and point it to my kube config file, nothing happens.
No clusters or other data is shown, the log remains empty, no error messages, nothing.
The kubeconfig should be fine, my teammates use it without problems.
How to proceed?

code --version
1.40.2
f359dd69833dd8800b54d458f6d37ab7c78df520
x64

Update: A popup plopped up from the extension, saying need to run as root or suid
I installed vscode as a snap package with classic confinement. How do I fix this?

Sorry for the slow reply - I've been on holiday.  There's definitely something fishy going on in the Snap install scenario and I'm not sure what it is.  It sounds like VS Code isn't able to run kubectl with the permissions Snap gives it, but I'm not sure what needs to be done to work around this (or who to contact for guidance).

At the very least we should provide a more informative error in this case of course!

Also now seeing the issue with the stable build on an M1 MacBook Air
code --version
1.54.3
2b9aebd5354a3629c3aba0a5f5df49f43d6689f8
arm64

Behavior still matches what was seen above


Added tex topic

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

TeX is an important program in the history of computing and typesetting but many people may not be familiar with it. A good topic description may help people find out about it.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I don't understand why the tests fail, it looks like it's running the tests on another commit. For example it says

topics::actions topic#test_0018_has at most one image with the right name, type, and dimensions > [/home/travis/build/github/explore/test/topics_test.rb:218]:
topic images should not exceed 75000 bytes, got 77468 bytes

I don't understand why the tests fail, it looks like it's running the tests on another commit.

There was a change in master that broke all builds. This was just fixed and I'll take care of rebuilding and merging this PR now that it's been approved.

I see, thanks a lot!


Install service catalog through svcat

$ svcat install catalog

This is existing functionality in the google sc tool and @n3wscott has offered to help donate that logic.

Yes, we need to do some refactoring on the sc side to support this but it is a goal.


[DatePicker] PickersDay - disableMargin doesn't affect weekday letters

disableMargins prop, as the documentation states, removes the margins from the days of the calendar.
But it doesn't remove them from the weekday letters, which results in misalignment (see Current Behavior)

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

S for sunday is not vertically aligned with 5, same goes for the rest of the letters
Expected Behavior 🤔
The letters are aligned to the numbers
(or additional prop for weekday letters is introduced like disableWeekdayMargins, which disables margins for the weekdays)
Steps to Reproduce 🕹
go to https://mui.com/components/date-picker/#customized-day-rendering
Your Environment 🌎
N/A really,  but here are the browsers:
Firefox: 93.0b9
Chrome: 96.0.4656.3

I'm going to start working on this issue :)

Sadly have the same issue :( Did you find a way to overwrite the styles?

Sadly have the same issue :( Did you find a way to overwrite the styles?
Yep;

.MuiCalendarPicker-root .MuiTypography-root.MuiTypography-caption {
    margin: 0;
}


Exports LD_LIBRARY_PATH for runtime libraries in the compiler tarball

Also, you need to change the base class to accept the compiler dictionary, as well as the Himeno model.


feat(#350): allow XmlMethod instructions mutation

I temporary allowed XmlMethod.replaceInstruction mutations. Now we can set any instructions (and xml nodes) instead of original
insturctions. This method mutates the original XML node, which is DANGAROUS. Thus I left the puzzle to fix it in the future.
Closes: #350.

History:

feat(#350): open some useful methods
feat(#350): add implementation for intructions replement
feat(#350): fix all qulice suggestions

PR-Codex overview
Detailed summary

Made the top() method in XmlProgram public.
Made the operand() method in DirectivesMethod public.
Made the properties() method in XmlClass public.
Made the constructors(), methods(), and fields() methods in XmlClass public.
Added the opcode() and operands() methods in XmlInstruction.
Added the toNode() method in XmlInstruction.
Made the child(), optchild(), firstChild(), children(), attribute(), and text() methods in XmlNode public.
Added the append() and erase() methods in XmlNode.
Added the toClass() and toCommand() methods in XmlNode.
Made the asDocument() method in XmlNode public.
Added tests for XmlMethod class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 4min)

@rultor release, tag is 0.2.6, title is 0.2.6.

@rultor release, tag is 0.2.6, title is 0.2.6.

@volodya-lombrozo OK, I will release it now. Please check the progress here

@rultor release, tag is 0.2.6, title is 0.2.6.

@volodya-lombrozo Done! FYI, the full log is here (took me 6min)


Unable to edit size of burger button on mobile

Hi,
So I'm primarily using this burger menu on a mobile device. I saw the css for the element you posted, and I decided to edit it for myself. Here is how I did it:
.bm-burger-button {
      position: relative;
      width: 30px;
      height: 24px;
      left: 36px;
      top: 36px;
      cursor: pointer;
    }

I edited the width and the height, since the button was extending out of my navbar. However, the size did not change. On desktop though, the changes are noticeable.
something is preventing the style from being changed on mobile.
Thanks,
RTK99

@RTK99
You can use media queries to see the change on your mobile device

I created the codesandbox and can see the changes perfectly - https://codesandbox.io/s/329n5lj135


Add arguments to PyWastedVisualSortTrack for python usage

Add of some getters in the source code of PyWastedVisualSortTrack to be able to access the arguments from the objects returned by VisualSort wasted_py().

@calvinbeeguard looks good, kicked tests.

@calvinbeeguard I will trigger a next similari version when it completes.

Thank you for your quick merge.
I noticed there isn't any source distibution on pypi. Therefore pip keep installing the 0.26.5 instead of the last 0.26.7. How may I get the last version installed ?


Question: Is it possible to pipe console.* messages to stdout?

I want to see the console.log messages in my terminal/test runner. Is that currently possible?

Yeah, the WCT context returned by test emits log:<level> events among others (e.g. log:info, log:error, etc)
I've got a quick reference on the docs of https://github.com/Polymer/web-component-tester/blob/master/runner/test.js - also, the

Also, if you would rather just deal with a single stream, and WCT's default formatting, you can construct one of these guys: https://github.com/Polymer/web-component-tester/blob/master/runner/clireporter.js
(Also via test({output: process.stdout})

Thanks for the quick response. I see it is possible programmatically. Is there a cli parallel to this though?

Seems like the same at #15. There should be a flag for this.


Question about native behavior on iOS

As I understand it, this is an experiment, so this is not really an issue.
It's a question for my own understanding -- why is it that when I run this on my local emulator (M1 MacBook, iPhone14 iOS 16.4), there are a few issues:

The main layout seems to be off
The Avalonia radio buttons don't seem to be responsive
There seems to be a default native style applied (the little (i) icon)

The only way I've found so far to remove the unwanted icon is to add a line to Avalonia.MAUI.Platforms.iOS.AvaloniaViewHandler.ConnectHandler
platformView.TintColor = UIColor.Clear;

But when I run it on Android, all seems well?

I don't fully understand how MAUI ViewHandlers work, so I could be missing something obvious.

There seems to be a default native style applied (the little (i) icon)

I think it was a bug in old avalonia preview version. Shouldn't be an issue anymore.


ContainerLogs with default ContainerLogsOption

I copied
func ExampleClient_ContainerLogs_withTimeout() {
    ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
    defer cancel()

    client, _ := NewEnvClient()
    reader, err := client.ContainerLogs(ctx, "container_id", types.ContainerLogsOptions{})
    if err != nil {
        log.Fatal(err)
    }

    _, err = io.Copy(os.Stdout, reader)
    if err != nil && err != io.EOF {
        log.Fatal(err)
    }
}

from the example at container_logs_test.go, but the server raised an error Error response from daemon: Bad parameters: you must choose at least one stream.
Then I changed types.ContainerLogsOptions{} with types.ContainerLogsOptions{ShowStdout: true} and everything worked well.
So I was wondering whether this example could be misleading for beginners, or is there anything that I didn't notice?

as the error said, you have to choose one stream either stdout or stderr. If you don't input any of these option to be true, it would panic.


Context getting too long

Context getting too long, can you please remove it, or make it configurable?

@jqknono
Do you mean the menu string is too long?

@jqknono
Do you mean the menu string is too long?
Your request is remove "markdown-toc-num" from menu string, right?

@takumisoft68
Yes, there are too many menu items, I've to scroll in the menu sometimes.
Anyway, thanks for make the great extension, it's the best I've used.


feat: custom http client

The journey goes on... See https://github.com/supabase-community/postgrest-dart/pull/66 for a detailed reason.
In addition, I added status code to the response and made the properties of the data classes final.

@dshukertjr May you review this?

@dshukertjr Thanks for merging! Are you going to release a new version, or should I add another pr?

@Vinzent03 Sorry for taking time one this one. Will release this one pretty soon!


chore: only fetch deposit info for deposit tx

we only have to fetch this for deposit tx
there is one more issue for https://github.com/paradigmxyz/reth/issues/11708 because currently we can't easily set the nonce field for deposit txs
should we introduce this as additional field on op-alloy's tx type @klkvr ?

should we introduce this as additional field on op-alloy's tx type @klkvr ?

yeah, this would have to be a separate field with another serde hack. would we just fetch the nonce from historical state to account for that?

ah right there's deposit_nonce in there too


Snowpack resolver

I'm using snowpack and because of the web_modules folder eslint-plugin-import is not happy.
I read about writing a resolver, but I'm a tat bit lost.
How would I write a resolver for snowpack? Any push in the right direction is much appreciated.

I’d take a look at the two resolvers in this repo for inspiration - https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers


feat(btc): support full RBF

Changes

Add sendRbf() and createSendRbfBuilder() APIs to support Full-RBF of BTC transactions
Add excludeUtxos, skipInputsValidation options in the sendUtxos() API to support the RBF feature
Add changeIndex in the return type of the BTC Builder APIs

Related issues

Resolves #82
Resolves #94

New APIs
The sendRbf() and createSendRbfBuilder() APIs are design for constructing BTC Full-RBF transactions.
interface SendRbfProps {
  from: string;
  txHex: string;
  source: DataSource;
  feeRate?: number;
  fromPubkey?: string;
  changeIndex?: number;
  changeAddress?: string;
  minUtxoSatoshi?: number;
  onlyConfirmedUtxos?: boolean;
  requireValidOutputsValue?: boolean;
  requireGreaterFeeAndRate?: boolean;

  // EXPERIMENTAL: the below props are unstable and can be altered at any time
  inputsPubkey?: Record<string, string>; // Record<address, pubkey>
}

declare function createSendRbfBuilder(props: SendRbfProps): Promise<{
  builder: TxBuilder;
  fee: number;
  feeRate: number;
  changeIndex: number;
}>;

declare function sendRbf(props: SendRbfProps): Promise<bitcoin.Psbt>;

txHex
The hex of the original transaction.
changeIndex

Optional, default to undefined.

By default, all the inputs and outputs from the original transaction remains the same in the RBF transaction, but if you wish to charge fee from or return change satoshi to the change output of the original transaction, you can specify the option.
requireValidOutputsValue

Optional, default to false.

Require the value of each output in the RBF transaction to be greater or equals to minUtxoSatoshi.
requireGreaterFeeAndRate

Optional, default to false.

Require the fee rate and the fee amount of the RBF transaction to be greater than the original transaction.
inputsPubkey

[EXPERIMENTAL] Optional, default to undefined.

A Map of addresses and public keys. It's useful when the original transaction contains multi-origin P2TR inputs. This option is currently unstable and can be updated, also note that in you won't need it most cases.
New options
skipInputsValidation
Previously, when the onlyConfirmedUtxos is true, all inputs will be validated and an error will be thrown if any input is unconfirmed. With the skipInputsValidation option, you can skip validation of the props.inputs, while still apply the onlyConfirmedUtxos rule to the satoshi collector.
Which means if onlyConfirmedUtxos = true and skipInputsValidation = true:

UTXOs passed from the props.inputs option can be unconfirmed UTXOs
Only confirmed UTXOs will be collected during the pay fee process

In the sendRbf() API, this option is always set to true, allowing transaction chains to be RBF.
excludeUtxos
This option is a list of UTXO[] to be excluded from the satoshi collection process when paying fee.
In the sendRbf() API, this option is used to exclude the outputs from the original transaction, preventing errors related to circular references (the RBF may uses outputs of the original transaction as the inputs if they're not excluded).
New return type
changeIndex
All BTC Builder APIs now return a new property changeIndex, which indicates the specific output in the generated transaction to be the change output. Note that the value of the changeIndex can be -1, meaning the transaction has no change output.

This draft PR doesn't look ready yet

This draft PR doesn't look ready yet

Yes, the PR is still in draft, and it's currently for API interface preview only.
Some props can be modified during further tests, but the shape of it is relatively clear now.

Please help review 'full RBF' test analysis.
https://www.notion.so/full-RBF-Test-Case-f198159a01f045748605b9249bc0c649
@ShookLyngs @Flouse @duanyytop

The PR is now ready for review/test, please update your status here @Dawn-githup, thanks.

todo list
Normal scenario:

[ ] No introduction of new input to increase handling fees
[ ] Add new input and increase handling fee
[ ] Specify the change output index

Abnormal scenario:

[ ] Change output cannot be changed
[ ] Rates are consistent
[ ] Unable to pay more fees
[ ] Verify that there are no redundant inputs
[ ] paymaster
[ ] Retry on failure

We may need to use this kind of API to help identify which transaction to be excluded in the RBF: https://mempool.space/docs/api/rest#get-transaction-outspends
The basic logic:

Given an original transaction, where txid=A
Search the outspent status of A, and if any results found, record the txid of the results
Get transactions based on the above results, and and then repeat step 2 for all mentioned transactions
In the end, all recorded txid should be excluded when constructing the RBF transaction, avoiding circular referencing

txHex
The hex of the original transaction.
changeIndex

Optional, default to undefined.

By default, all the inputs and outputs from the original transaction remains the same in the RBF transaction, but if you wish to charge fee from or return change satoshi to the change output of the original transaction, you can specify the option.
requireValidOutputsValue

Optional, default to false.

Require the value of each output in the RBF transaction to be greater or equals to minUtxoSatoshi.
requireGreaterFeeAndRate

Optional, default to false.

Require the fee rate and the fee amount of the RBF transaction to be greater than the original transaction.
inputsPubkey

[EXPERIMENTAL] Optional, default to undefined.

A Map of addresses and public keys. It's useful when the original transaction contains multi-origin P2TR inputs. This option is currently unstable and can be updated, also note that in you won't need it most cases.

What about putting these descriptions to the README or code comments?

New options
skipInputsValidation
Previously, when the onlyConfirmedUtxos is true, all inputs will be validated and an error will be thrown if any input is unconfirmed. With the skipInputsValidation option, you can skip validation of the props.inputs, while still apply the onlyConfirmedUtxos rule to the satoshi collector.
Which means if onlyConfirmedUtxos = true and skipInputsValidation = true:

UTXOs passed from the props.inputs option can be unconfirmed UTXOs
Only confirmed UTXOs will be collected during the pay fee process

In the sendRbf() API, this option is always set to true, allowing transaction chains to be RBF.
excludeUtxos
This option is a list of UTXO[] to be excluded from the satoshi collection process when paying fee.
In the sendRbf() API, this option is used to exclude the outputs from the original transaction, preventing errors related to circular references (the RBF may uses outputs of the original transaction as the inputs if they're not excluded).
New return type
changeIndex
All BTC Builder APIs now return a new property changeIndex, which indicates the specific output in the generated transaction to be the change output. Note that the value of the changeIndex can be -1, meaning the transaction has no change output.

Same recommendation as above

What about adding these descriptions to the README or code comments?

I was thinking of maybe creating Markdown docs for each API, like this: packages/btc/docs/send-rbf.md.
Adding comments to the props interface may also work; I'll try it in another PR.

Conflicts have been resolved, and the history commits are squashed into 8ce3593.
Additionally, all changes are documented in the changeset: https://github.com/ckb-cell/rgbpp-sdk/blob/08200c974ef336661723cc7556a003932babda9a/.changeset/spicy-cups-cheat.md


Set default MaxRetryDelay to 60s

Fixes #19384

Where is this stated in the guidelines? I'm not pushing back, I just can't find it.

Where is this stated in the guidelines? I'm not pushing back, I just can't find it.

Its in the Retry Policy section of the general guidelines.
https://azure.github.io/azure-sdk/general_azurecore.html#retry-policy


rfe: --strip-path

rfe: --strip-path
such that relative paths are used, even when full(er) path is specified on command line
rhash --strip-path -H c:/tmp/rhash/*
would return something like:
 doc.txt
 new.txt
 testdir/file3.txt
rather then
 c:/tmp/rhash/doc.txt
 c:/tmp/rhash/new.txt
 c:/tmp/testdir/file3.txt

This feature is hard to design (especially to work the same on Linux and Windows).

The usefulness of the resulting hash file is questionable in the case, when two different directories are passed by command line (and both are stripped from the resulting paths):
> rhash --strip-path -H c:/dir1/* c:/dir2/*
dir1_file1.txt
dir2_file1.txt
dir2_file2.txt

Before verifying such file, the user shall copy all files from the hashed directories into one directory.

In Linux/Unix wildcards are expanded by the shell and are passed to RHash already as separate files (not directories), so RHash can't detect from paths with wildcards which directory should be stripped from file paths.
I think the only way for RHash to work the same on all platforms is to strip only directories passed with recursive option (without wildcards support):
> rhash --recursive --strip-path -H c:/dir1/ c:/dir2/
dir1_subdirA/file1.txt
dir2_subdirA/file1.txt
dir2_subdirB/file2.txt


4.1 Elevations

Design
Add:

Screenshot
Figma link to specific element

@Chegemartinx please add design + issues, move to implementation and assign to Daniel


Improvements, and a bug

Thanks for getting it working, love it!
Using it I've come up with a couple of improvements that could enhance the experience :
1- Option to export as video with ffmpeg (with options for FPS, export location/name, format)
2- Enable moving the timeline marker by clicking on the timeline, instead of just by dragging the marker
3- Adding settings tab, for options like defaults (sampler, cfg scale, steps), local data clean-up, model weights selection (from the list that A1111's end creates)
4- Enable batch creation, to speed up generation and interpolation in higher end GPUs (have the option of the batch size also in settings)
5- Adding the option to remove generated frames in playback.
Thinking of some heavier improvements:
6- Have different keyframes interpolations (exponential, quadratic, sinusoidal)
7- Integrate frame interpolation like https://github.com/google-research/frame-interpolation - on export time
8- Integrate super-resolution - also on export time
And a little bug, when dragging keyframes to the left (frame<0) causes a crash and forces reload.
Much love!

Thanks for the feedback here's some comments:

Yes, having the video generation part of the the system would be nice. But since you can collect all the frame in one folder in the correct order you not "locked" into any particular way to generate the video. But as a first step some instructions for how I do it would be good.
Good Suggestion
Good Suggestion
Good Suggestion
Why? To not include them in "collect"?
Not very hard to implement I think, but wasn't sure it would be very useful.
Same as 1. This is the one I use to make my videos.
Same as 1.

Bug: Opps, will fix: also if you drag the line between keyframes you can move it <0 (without crashing this time...)

1- I've found https://www.npmjs.com/package/fluent-ffmpeg to be the most popular wrapper for ffmpeg in node. In this case the command for the image sequence would be like this:
var FfmpegCommand = require('fluent-ffmpeg');
var command = ffmpeg().addInput('/data/collected/frame%03d.png')
.videoCodec(CODEC)
.videoBitrate(BITRATE)
.outputFPS(FPS) ...etc
.save('/path/to/output.mp4');
5- I've found myself generating interpolated frames and then wanting to tune something and regenerate them. I'm thinking of the option to individually select the frames and having a trash bin button to erase them, because there's no other way to undo the process as of now. Maybe a checkbox that indicates the interpolator to create keyframes with the new generated frames? Maybe that's too messy.
6- Sometimes the interpolation is really abrupt while on the same timeline it gets slow. I know it's got something to do with the latent space not being smooth. Having controls for the interpolation speed would help, something like the curves that video editors have. I know implementing something like that would get a bit complicated 😅

5: even if you could regenerate them you would get the same result. Because all the inputs are the same. If the inputs are not the same it would not be there. (unless there's a bug)

Sorry, I didn't explain myself.
I was saying deleting even the old keyframe to regenerate with a new one

I'm not sure I understand. Do you mean the "frames" aka the images generated by SD or the "keyframes" aka the "diamonds that set a value for a property" ?

Sorry, I mean both. If I wanted a different output in the interpolation, I'd need to change the keyframes like you said. Also I'd need to delete the generated interpolation

You should not have to delete the generated interpolation, if you for instance change the "seed" keyframes, all generated frames should "go away".

Oh i see, didn't know that!
Then what i would suggest is to have the option to keep a generated frame (i.e. keyframe it) in case the user wants to keep any of the interpolated frames.
One more thing I just thought of, a play and pause button on the playback tab!

The are "keept" in the sense that if you retern to the old settings you don't have to regenerate them.
Play/Pause is "planned".


Estimate Hardware requirements, CPU, RAM and NVMe disks

Known questions:

[x] Main disk requirements, RAID/non-RAID options, maybe ZFS or btrfs?

[x] How much disk space gets us how many years storage?

[x] What is the hash rate needed?

[x] Can we use GPU or NPU resources?
[x] What hardware accelerators are available?

[x] What is the networking required, and what are the options?
[x] How much RAM do we require, what are the primary drivers of RAM usage?
[x] How much parallelism do we require, how many cores?
[x] Can we offload some functions to separate machines, possibly ephemeral?
[x] Can we use "typical" cost reduction approaches?

[x] Can we reduce cost with several small/cheap machines?
[x] Can we lower cost with networked storage for the large-volume historical data?
[x] Can we use separate "worker" processes (K8S containers) to handle large/long processes like reconnect or state snapshots?
[x] Should we be using ZFS, btrfs, LVM, etc...?
[x] Do we need RAID (5/6) or is multiple-machine redundancy enough/better?

[x] What uptime requirements do we have?
[ ] What is the impact of 1/3/6/12 simultaneous block node failures?
[ ] What level of "spare" capacity do we need to avoid failure amplification?
[x] What is the disk read/write rate required for "recent" blocks, live state, state snapshots, "old" blocks, etc...?
[x] What data volume is required for "fast" data versus "slow" data?
[x] Do we need/want any level of CXL 2.0 support?

Notes:

Record stream can be estimated by listing the files/folders/subfolders at https://console.cloud.google.com/storage/browser/hedera-mainnet-streams/recordstreams?project=mainnet-exports&pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))

This must be done with care, costs climb very fast in requester-pays buckets.
Command line is likely to be the most efficient option
Suggested process

First part compute existing record stream size when deduplicated and compressed.

Run some gsutil "ls -l" commands on a couple hosts that have been around a long time LG,IBM, and maybe swirlds. Pipe to text file. can do on GCP VM or laptop
Take those text files and match them up to get a size for every record file. Either in Java or SED/BASH what every is quickest
For that we should be able to compute what the record stream deduplicated up to today takes.

We need one copy of every record and sidecar file and 32 copies of signature files.
We could look at the compression ratio we get on record files and apply that ratio to all uncompress early files

Then next try and extrapolate for block streams

Look at some sample data from latest services running with record stream and block stream turned on. Alex K can get you data if you don't have any. Estimate a what % larger block streams are than record streams.
Plot a chat showing record stream growth tragectory and then multiply by % bigger block streams are.
Extrapolate out 1yr, 2yr, 5 and 10
Maybe look at 10K TPS size and see what more worst case would look like
Might be fun to add event stream + record stream size to show that block streams are larger than record streams alone but smaller than the two we have today

Some responses:

What is the hash rate, can we use GPU or NPU resources, and what accelerators are available?

GPU/NPU resources can be used, but it would require custom native code, and GPU, in
particular, requires processing data in large batches, so it's possible, but not easy.
Custom accelerators are available, but only if we specify custom servers and
the added cost is justifiable.  This does not currently appear to be the case.

It may be worthwhile to research this option for "execution" nodes in the future.

How much RAM do we require, what are the primary drivers of RAM usage?

The primary driver is the MerkleDB usage for state.
Total RAM requires is not yet determined, but we are estimating a value
similar to current consensus nodes.

How much parallelism do we require, how many cores?

We have very good parallelism opportunities, and could fully utilize
as many as 64 cores, possibly more.

Can we offload some functions to separate machines, possibly ephemeral?

TBD, this will be addressed as a future effort.

Can we use "typical" cost reduction approaches?

Can we reduce cost with several small/cheap machines?

Not for "state managing" block nodes, which require the MerkleDB, at least
not currently.

Can we lower cost with networked storage for the large-volume historical data?

Not initially, but perhaps in future work.

Can we use separate "worker" processes (K8S containers) to handle large/long
processes like reconnect or state snapshots?

Possibly, this is an item for future work.

Do we need RAID (5/6) or is multiple-machine redundancy enough/better?

RAID increases availability in a single error scenario, but we already
have much higher availability via multiple nodes. The tradeoff cost of
long rebuild times, read-only array during rebuild, and very high CPU impact
of rebuild make this unlikely to improve real-world availability.

Do we need/want any level of CXL 2.0 support?

Not at this time.

More answers:

What is the hash rate needed?

On the order of 1.5 billion/sec; dominated by live state rehash.
Without live state rehash (if that's even possible), roughly 400 million/sec.

What is the networking required, and what are the options?

We might be able to make do with 1Gb/s, but 10Gb/s (RJ45) hardware is
recommended, regardless of available ingress/egress due to obsolescence of 1Gb/s
hardware in the data center.

Can we use "typical" cost reduction approaches?

Can we use separate "worker" processes (K8S containers) to handle large/long
processes like reconnect or state snapshots?

Perhaps, but this will need to be addressed in future phases.

Should we be using ZFS, btrfs, LVM, etc...?

Yes. Btrfs or ZFS are recommended. If RAM is limited, btrfs is more memory efficient, particularly in a remote JBOD setup (disk chassis connected via high bandwidth SAS over Ethernet).

Do we need RAID (5/6) or is multiple-machine redundancy enough/better?

RAID is not recommended. It does not improve practical availability due to
performance impacts when degraded/rebuilding, and without additional hardware
support, the overall performance cost is not sustainable above 200TB/array.

What uptime requirements do we have?

5 nines or better is desired.

What data volume is required for "fast" data versus "slow" data?

A relatively small amount of "fast" data, perhaps 8-12 TB, is needed for live state and
"recent" blocks and snapshots.  The rest is archival and can be less performant.

Here is a recommended generalized (almost no specifics) hardware specification
Consolidated source-agnostic specification.  Cost estimate is total and represents retail pricing.
CPU (Est. $3,000)
  32 core, 3GHz, 280-320W Xeon 4th Gen/EPYC 9004 series or later (Intel 6430/6530, AMD 9354/9355, or better)
  Intel 6952P is the closest 6th Gen Xeon available (72 "P" cores, the smallest available all-P-core)
  Any Intel 4th Gen or later Xeon, or AMD 9004 or 9005 series with at least 32 cores should be sufficient
Core Networking (Est. $100 or $0 if included on Motherboard).
  2 X 10Gb/s Ethernet (SFP+ or RJ45) or better (25Gb/s ports may be less expensive).
     Actual connection may be slower, but hardware _should_ match the above.
O/S Storage (Est. <$200)
  2 X 1T (or larger) NVMe (M.2 interface), RAID 1, PCIe 4 x 3.0 or better, 2500 MB/s _read_
  > 100,000 IOPS write 500,000 IOPS read
   Samsung 980 PRO or better
"Fast" Storage (live state, recent blocks, temporary files) (Est. $1,800)
  2 X 3.8T NVMe, RAID 0, PCIe 4 x 3.0 or better, at least 3000 MB/s _write_ (per drive)
  > 250,000 IOPS write 800,000 IOPS read
  Minimum 0.5 TDR/day durability
Bulk Storage (Est. $11,000)
  450T (usable), 30 X 16T SAS 12Gb/s, JBOD, Minimum Internal 16 lane SAS connect, or External 4 X 25Gb/s SoE.
  We do not recommend fewer than 30 drives for throughput and IOOPS reasons when using magnetic storage.
  Use of U.2 SSD 24t or 30T drives to reach similar data volume is possible, but may be very expensive (>$110,000).
Chassis, power, motherboard, etc... (Est. $12,000)
  Any suitable datacenter class hardware with redundant power supplies.
  Any suitable datacenter class motherboard appropriate to the CPU.
  Any suitable major-vendor SAS and network hardware.

Final hardware requirements were presented privately to minimize misunderstanding.


[Query] Just Player settings

Hiya, how do I access the settings of Just Player? I have it installed in my Chromebook. When I open the app and click on settings icon in bottom right it just says speed and audio.

press and hold or click and hold

press and hold or click and hold

got it :) thanks mate, happy holidays.


Bug (?) with server side

I'm currently having a problem with the HTTP driver, but I'm not sure if it's really a bug or just a misunderstanding from me (but I'm pretty sure it's a bug).
I have a page fetching a list of items from an HTTP request, and on the same page a button to add an item to this list via HTTP request. When I add an item to the list, I then want to refresh (re-fetch) the list so it have the new item.
I have something like this in the end (overly simplified for the issue):
import { Observable } from 'rx'
import { div, button } from '@cycle/dom'

export default function main(sources) {
  const buttonClick$ = sources.DOM.select('button').events('click')
  const barLoaded$ = sources.HTTP.filter(res$ => res$.request.url === 'http://<IP_ADDRESS>:3000/bar')
    .mergeAll()

  return {
    DOM: sources.HTTP.filter(res$ => res$.request.url === 'http://<IP_ADDRESS>:3000/foo')
      .mergeAll()
      .map(res => res.body)
      .map(text => div([
        text,
        button(['click me'])
      ])),
    HTTP: Observable.merge(
      Observable.combineLatest(
        Observable.just('http://<IP_ADDRESS>:3000/foo'),
        barLoaded$.startWith(true),
        url => ({url})
      ),
      buttonClick$.map(() => ({url: 'http://<IP_ADDRESS>:3000/bar'}))
    )
  }
}

This works perfectly as long as I only run it on client-side.
However when I run it on server-side, the page is never loaded (infinite loading, as if trapped in an infinite loop).
I'm not sure if I'm perfectly clear, so I created a minimal application to see this error: https://github.com/chadrien/cycle-http-driver/tree/server-side-bug
So… bug, feature or misunderstanding of Rx/HTTP driver?

there is already one basic mistake in your server code:
https://github.com/chadrien/cycle-http-driver/blob/server-side-bug/src/server.js#L23-L25
sources.DOM.subscribe(html => res.render('layout', {
  html
}))

You would not want to subscribe to the sources.DOM returned by Cycle.run but to the sinks.DOM.
And then you might want to only take(1) element.

@laszlokorte you're goddamn right. How could I let this pass? duh! Obviously when subscribing to the right stuff, everything works okay ~~
Thanks for pointing this out! I guess sometimes you get too focus on something and can't see the obvious :smile:


AddBatch: malformed addendaXX and effectiveEntryDate records return cryptic error

What were you trying to do?
The following Batch doesn't pass JSON unmarshal and returns a cryptic error message.
{
        "batchHeader": {
            "serviceClassCode": 220,
            "companyName": "Company Name",
            "ODFIIdentification": "121042882",
            "id": "",
            "companyDiscretionaryData": "",
            "standardEntryClassCode": "PPD",
            "companyEntryDescription": "PAYROLL",
            "companyDescriptiveDate": "122018",
            "effectiveEntryDate": "",
            "originatorStatusCode": 1,
            "batchNumber": 1
        },
        "entryDetails": [{
            "id": "",
            "transactionCode": 22,
            "RDFIIdentification": "23138010",
            "checkDigit": "4",
            "DFIAccountNumber": "123456789",
            "amount": "200000",
            "individualName": "Edward James",
            "identificationNumber": "26",
            "discretionaryData": "",
            "addendaRecordIndicator": 0,
            "traceNumber": "",
            "addenda02": "",
            "addenda05": [
                {
                 "paymentRelatedInformation": "December Payroll"
                }
            ],
            "addenda98": "",
            "addenda99": "",
            "category": "Forward"
        }]
}

What did you expect to see?
Something like "error": "failed to read addenda02 as object"
What did you see?
"error": "json: Unmarshal(nil *ach.Batch)"

This is similar to https://github.com/moov-io/ach/issues/404

@bkmoovio With the following Go test I get the following errors. After each error I fix the JSON to continue on. I'm not seeing the (nil *ach.Batch) error...
func TestIssue403(t *testing.T) {
	fd, err := os.Open("issue-403.json")
	if err != nil {
		t.Fatal(err)
	}

	var batch ach.Batch
	if err := json.NewDecoder(fd).Decode(&batch); err != nil {
		t.Error(err)
	}
	t.Errorf("%#v", batch)
}

// "effectiveEntryDate": ""
$ go fmt ./... && go test ./server/test/ -run TestIssue403 -count 1
server/test/issue403_test.go
--- FAIL: TestIssue403 (0.00s)
    issue403_test.go:27: parsing time """" as ""2006-01-02T15:04:05Z07:00"": cannot parse """ as "2006"

// "amount": "20000"
$ go fmt ./... && go test ./server/test/ -run TestIssue403 -count 1
--- FAIL: TestIssue403 (0.00s)
    issue403_test.go:27: json: cannot unmarshal string into Go struct field EntryDetail.amount of type int

// "addenda02": ""
$ go fmt ./... && go test ./server/test/ -run TestIssue403 -count 1
--- FAIL: TestIssue403 (0.00s)
    issue403_test.go:27: json: cannot unmarshal string into Go struct field EntryDetail.addenda02 of type ach.Addenda02

@adamdecaf  I no longer receive the "error": "json: Unmarshal(nil *ach.Batch)" error either.  I will close!


scanner: Add basic SCANOSS integration

Resolves #2908.
Co-authored-by: Sebastian Schuberth<EMAIL_ADDRESS>Signed-off-by: Juan M Salamanca<EMAIL_ADDRESS>

FYI @eeisegn.


Fixed typos

@jurajsucik : Thanks for your contribution! The author, @rayne-wiselman, has been notified to review your proposed change.

Merging typo fix


Turn security on by default

This library is officially recommended by Twitch, and should enforce secure connections by default.

Please format your commit message to match the CONTRIBUTING.md.


[Question]: Is there an option to disable Free move?

Hey @hallysonh the library is fantastic!.
I wanted to to know if free move can be disabled? if not is there any workaround.

@hallysonh I have the same question

Hi guys. I haven't used this component for a long time and since then I haven't updated it anymore due to lack of time. However, I will need to use it in a new project that will start later this month. Therefore, I plan to improve and update it as much as possible. I will take this feature into account.

In short, it is not supported yet.


Accept a comma-separated list of ports to forward

Hi! 👋 Former Herokai, now Hubber here 😄
Instead of accepting only a single port to forward, this allows heroku ps:forward to forward multiple ports from a comma-separated list.
There is documentation in the dev center that says to use heroku ps:socks in order to forward multiple ports, but this only works with socks-aware software.
For example, it is not possible to use the amazing GUI Observer module that OTP provides for Erlang/Elixir apps unless heroku ps:forward can forward both to the epmd port on the dyno and to the port the dyno is listening on for distributed node connections. epmd is not socks-aware.
Making this change would allow for the caveat in the Phoenix documentation that says that Observer isn't supported to be removed!
Note: I have nooooo idea if this is the right format for accepting multiple port arguments as per current Heroku CLI design guidelines. I'd love some feedback on making this more idiomatic, if there's interest in supporting this feature!
Another note: I'm not really familiar with socks...I just hacked around and this appeared to work. So very likely there's a better way of implementing this, I have no idea 😄

Thanks! I'll take a look shortly. Don't worry about the CI failure (secrets are withheld from forked PRs)

Replacing with #16


langchain: add support for Google Anthropic Vertex AI model garden provider in init_chat_model

Simple modification to add support for anthropic models deployed in Google Vertex AI model garden in init_chat_model importing ChatAnthropicVertex

[v] Lint and test

will mention this to the google team - I think the right place to shim in anthropic for vertex is within ChatVertexAI because adding google_anthropic_vertex as a distinct provider is a confusing implementation for this for users
@lkuligin thoughts?

still discussing sorry. the model garden models are just a bit unintuitive in general having to call a separate api, so worst case I think this is ok

works for now - can sort this in future


Data Consumption Report

Add endpoints to support a consumption report.
Requirements:

[ ] Allow user to enter date range for results
[ ] Group by:

[ ] Project
[ ] Month

[ ] For each Project/Month:

[ ] Session count
[ ] MBs of files
[ ] Gear execution count

@ryansanford @lmperry a few questions:
Does gear execution count only include jobs marked as "complete"?
Is it alright that MBs of files by month is only referencing total MBs for sessions created in that month? I.e. if you add an analysis today to a session created last month, you would see the MB total go up for last month? Is the session creation time the root time used for calculation?

Some objects don't have their own created/modified time (files, for example). What about an acquisition added to a session from last month? Or a gear run across data from several containers?

Correction - I was incorrect about file timestamps, they do exist everywhere. No change needed there.


Update vpn-gateway-generate-export-certificates-include.md

update scripts to make this actually work (sign the client cert with the root cert)

@cherylmc
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

https://github.com/MicrosoftDocs/azure-docs/pull/113414/files#diff-a48ecf32d4cfb32db3109af4372fd2dad5f7b733d4234991035578bd451a068aR5  ms.date "ms.date: 08/04/2023" may also need to be updated? @cherylmc


Websocket

Hi, this is a really nice idea.
But websockets don't work, there is an error during handshake.
Now that CloudFlare enabled websockets with SSL there is no point not to use it, Meteor apps are very slow without websockets.

Thank you for your reply,
Any idea on how to solver this?

@lo-tp I created a pull request, the Basic works fine for me now with Websockets!
I updated the SSL version too, but I'm not sure if this is enough, maybe there are additional configurations you have to add to use WSS.
I found these related questions:
http://stackoverflow.com/questions/18003689/recommended-nginx-configuration-for-meteor
http://stackoverflow.com/questions/17014969/meteor-websocket-handshake-error-400-with-nginx
I know this project aims to be lightweight and not complex, but we should add basic NGINX configurations like gzip.

Hi @lo-tp I created a pull request, the Basic works fine for me now with Websockets!
I updated the SSL version too, but I'm not sure if this is enough, maybe there are additional configurations you have to add to use WSS.
I found these related questions:
http://stackoverflow.com/questions/18003689/recommended-nginx-configuration-for-meteor
http://stackoverflow.com/questions/17014969/meteor-websocket-handshake-error-400-with-nginx
I know this project aims to be lightweight and not complex, but we should add basic NGINX configurations like gzip.

@valentinvichnal , I'll add Gzip to Nginx soon.


Enable asserting clients for disabled/exception API's in KV

Enable asserting clients for listing and other exception API's in KV to fully onboard sync stack integration

should this go to @vcolin7


Can't view weapon data

Looks like viewing weapon data got busted, armor lists and usable lists still load but for weapons it claims no viewer is available.

Fixed in 18619ed.


General refactoring: +.editorconfig, typofixes, indentations, comment clarifications and portability

add initial .editorconfig file

Adding an .editorconfig file makes it easier to refactor.
As GitHub and lots of IDEs/Editors have native support
for https://editorconfig.org/ files (and for others there
are usually plugins) things like mixing tabs and spaces
for indentation will hopefully be less likely in the future.

typofixes in Readme.md

as other sentences in the Readme.md end with a full stop
this one should also do so
s/to be send/to be sent/ (past participle)

refactoring: razorfy.pl

use /usr/bin/env in shebang as this is more portable
update copyright date
clarify comment about $bindaddress
replace all tabs with spaces
make opening / closing braces consistent

refactoring: razorfy.conf

clarify comment about RAZORFY_BINDADDRESS in config

Thank you for the PR and sorry for the long delay.


Update 'Contacts' Feature : Search by Email

Codecov Report

Merging #137 (5e93303) into master (b0d0f1c) will increase coverage by 0.08%.
The diff coverage is 81.25%.

:exclamation: Current head 5e93303 differs from pull request most recent head af2ae46. Consider uploading reports for the commit af2ae46 to get more accurate results

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
+ Coverage     54.00%   54.09%   +0.08%
- Complexity      669      675       +6
============================================
  Files           146      147       +1
  Lines          2807     2819      +12
  Branches        276      278       +2
============================================
+ Hits           1516     1525       +9
  Misses         1191     1191
- Partials        100      103       +3

Impacted Files
Coverage Δ
Complexity Δ

.../dictionote/logic/commands/FindContactCommand.java
85.71% <75.00%> (-5.96%)
7.00 <1.00> (ø)

.../model/contact/EmailContainsKeywordsPredicate.java
77.77% <77.77%> (ø)
6.00 <6.00> (?)

...tionote/logic/parser/FindContactCommandParser.java
90.90% <100.00%> (+0.90%)
4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d0f1c...af2ae46. Read the comment docs.


Add build / nightly version to distro

Generate proper versions for nightlies
Allow to add build versions / nightly flag to distro build

WTF duplicate of #169.


" glitch

whenever i try to run a command, it just types " in chat and does nothing.

The " in chat is normal, yes it is a bug. However it should still do stuff. The problem is probably the updates this game has gotten. I have not played it and not programmed for it in quite a while. Im not sure if i will update this anytime soon, but i will look into it if its a quick fix.

for me everything seems normal, i pushed an update, maybe sth fixes this for you

is this in a online game as non host or are you host?

it sometimes happens when i am host but it always happens when i am non host

i just tested and it doesn't work

i just tested and it doesn't work

very well possible that it is an issue with other mods if you have any installed. maybe test if it works if only this one is enabled.
still please tell me what exactly the lobby is you are in, are you host?, are you playing with friends?. Please provide a screen shot of the BepInEx console.
otherwise i cant help.

ok i will try with nothing else

thanks for the help it works


Feature/improve-data-source-search

Rework data sources in terraform provider to improve scalability using newly built search query from API.
Url: api/xxx/name/{name}
Following entities are affected:

[x] alert sources
[x] escalation policies
[x] incident templates
[x] schedules
[x] service
[x] status page
[x] team
[x] uptime monitor
[x] user
[x] connectors
[x] alert actions

We should wait for the API release


Add Additional Synchronous Polling APIs

Description
Adds additional synchronous polling APIs

Additional factory method on SyncPoller.
Synchonrous APIs to compliment the asynchronous APIs on PollingStrategy

All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core

tagging @srnagar for review from Autorest side.

Closed for #31923


RASX file reader from Carsten Richter's repository

Add the RASX file reader available at https://github.com/carichte/IKZ/blob/master/IKZ/xray/io.py

Closing the issue and opening in nomad-measurement


add NULL check

@jupe
NULL check seperated as own PR

note: coverage is flipping too far down, you have to do something for it -->
 Code coverage enforcement failed for the following metrics:
17:43:28     Lines's stability is 83.33 and set mininum stability is 83.63.
17:43:28     Conditionals's stability is 63.38 and set mininum stability is 63.57.

added a unittest


JSON-RPC error: transport error: unexpected HTTP code: 404

❯ RUST_LOG=debug ./target/release/ord --chain testnet --bitcoin-rpc-user user --bitcoin-rpc-pass pass --rpc-url nd-111-222-333.p2pify.com:80 server
[2023-11-21T06:55:38Z INFO  ord::options] Connecting to Bitcoin Core at nd-111-222-333.p2pify.com:80/wallet/ord
[2023-11-21T06:55:38Z DEBUG bitcoincore_rpc] JSON-RPC request: getblockchaininfo []
[2023-11-21T06:55:38Z DEBUG bitcoincore_rpc] JSON-RPC failed parsing reply of getblockchaininfo: JsonRpc(Transport(HttpErrorCode(404)))
error: JSON-RPC error: transport error: unexpected HTTP code: 404

Whereas
❯ ./src/bitcoin-cli -rpcconnect=nd-111-222-333.p2pify.com -rpcport=80 -rpcuser=user -rpcpassword=pass getblockchaininfo
{
  "chain": "test",
  "blocks": 2539577,
  "headers": 2539577,
  ...
}

And
❯ curl --data-binary '{"jsonrpc": "1.0", "id": "1", "method": "getblockchaininfo", "params": []}' -H 'content-type: text/plain;'<EMAIL_ADDRESS>{"result":{"chain":"test","blocks":2539577,"headers":2539577, ... },"error":null,"id":"1"}

After looking into the traffic it becomes apparent that ord is resolving the hostname to IP and then querying it instead of making a query using the provided hostname

Looks like something that should be fixed

Is the issue that the IP address is changing or is the recipient (server hosting the bitcoin node) doing some dispatch using the host header?

Is the issue that the IP address is changing or is the recipient (server hosting the bitcoin node) doing some dispatch using the host header?

Both. IP can change at any time as it's dynamically provisioned, as well as routing is done via hostname instead of IP

Looked into it and the reason for this is because bitcoincore_rpc crate we are using uses a minimal dependency http transport. It does allow providing a custom transport through a public trait Transport, we plan do upgrade to reqwest soon anyways so that might help (#2716). We would have to do something like this:
struct Reqwest {
    client: reqwest::blocking::Client,
    url: String,
}

impl Transport for Reqwest {
    /// Sends an RPC request over the transport.
    fn send_request(&self, request: Request) -> Result<Response, Error> {
        let body = serde_json::to_vec(&request)?;

        let response = self.client.post(&self.url).body(body).send().unwrap();

        Ok(response.json().unwrap())
    }

    /// Sends a batch of RPC requests over the transport.
    fn send_batch(&self, _: &[Request]) -> Result<Vec<Response>, Error> {
        todo!()
    }

    /// Formats the target of this transport. I.e. the URL/socket/...
    fn fmt_target(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
        todo!()
    }
}


Redirect /versions and /info/* to index.rubygems.org

This fixes #100
This also includes #101 since it should be included for consistency and correctness.

@smellsblue this looks great! 👍


Documentation typo(?)

To add a graphic (icon) the documentation example (section4.1) shows the graphic element as a descendant of an objectDesc element, but the Appendix A.1.21 documentation shows it as an objectType. This is reflected in the functioning campus map example.
Fix is to change section 4.1 in documentation to use objectType rather than objectDesc.

Fixed in commit #12be85d.


Warning on content length always displayed on import.

I see the fix for the content length I mentioned, but there appears to be a problem with it. I’m guessing someone forgot to test this….
Case #1 - Change the simulation.json file after export and before import. Make sure the number of characters in the body DOES NOT CHANGE. For instance, I changed one ascii character in the body to a different ascii character, but the length of the body did not change.
552  hoverctl start
553  hoverctl stop
554  hoverctl start
555  hoverctl logs
556  hoverctl mode capture
557  hoverctl logs
558  hoverctl export simulation.json
559  hoverctl stop
560  hoverctl start
561  hoverctl import simulation.json (edited)
That’s my history.
between #558 and #561 I did NOT change the simulation.json file.
But I still get this warning after the cmd at line 561: “WARNING: Response contains incorrect Content-Length header on data.pairs[1].response, please correct or remove header”
If the content didn’t change, the warning should not appear.
Case #2 - Change nothing in the simulation.json file after export and before import.
Notice the warning for content length is echoed twice to the console.

Can you post the simulation.json @dpm3354 ?

Sorry, John. I can't put more time into this right now. And I already deleted the files. Did you try on your own with your own file?

Paul, we have not managed to reproduce a problem. That is, as long as we preserve the content length correctly the warning does not appear. As soon as we add or subtract characters we see the warning.
We decided that Hoverfly should not automatically adjust the Content-Length as it may be the intent to simulate an incorrect correct-length and it would be more confusing to second-guess intentions. It's also very complicated to calculate the content length when the user has used templating.
As the warning says you can adjust the content-length or remove the header, in which case Hoverfly will default to use Transfer-Encoding chunked to read the body.
Can you try again. If you see the same problem please supply us with the 'before' and 'after' JSON files.

I'm seeing this warning too, I think it might happen when the body of the response is encoded. During this check https://github.com/SpectoLabs/hoverfly/blob/master/core/import.go#L162 maybe pairView.Response.Body is still base64 encoded, and the Content-Length header is reporting the decoded size?

Thanks @john4744 - we'll have a look at that.

The problem reported by @john4744 has been fixed in v<IP_ADDRESS>
We can't tell if we have fixed the original issue but given we haven't had any further info I'm closing this issue. Feel free to reopen if there is a bug.


Multi-cursor support

At the moment when are presented with suggestions, upon selecting one, only the first selection is populated. It would be nice if all selections were populated in the cases where you are using multiple cursors.

+1


add session based authentication for rpc

used express-session middleware to handle the session(added as dependency)
used basic-auth to handle authentication(added as dependency)
modify the startclient to send cookie data
modify the startServer to accept credentials
tested both from browser and via node, works well

also add some comments for previous modifications made

Coverage decreased (-0.3%) to 45.464% when pulling b23b030098cb58b9319c27fa91dcaa8aa20242f1 on vaishnav98:master into 481525c5d472fba8355074563380c803c38c2c62 on jadonk:master.

The coverage check should be considered a requirement now. We have a lot of untested code, so it shouldn't be hard to increase the coverage %.


Include a version of the .csv file with a header row

I'm trying to plug this data in to a log-parser, but need a header row to do so.

Thanks for the feedback @rhanton, I'll include the header in the next release. Will keep you posted!

This is fixed with https://github.com/tobilg/aws-edge-locations/commit/70ded18115786b90e87be4bc5de7a526628a3fe1 A new version 0.1.1 will also be released shortly @rhanton.


add an option for specifying the property name of the object

The default property name is the file name of the html file,  it'll be very nice if the property name can be specified by an option.

Maybe it will be better to add an option for specifying  whether the templateName contains the extname of the file name, the default is false


[TimeSeries] Support timezone names as input

Currently the way to select a timezone to aggregate the data is by providing an offset, for example offset=3600 to select GMT+1.
Although this isn't incorrect, it probably isn't what you want, and it'd simpler to select the timezone as Europe/Madrid and let postgreSQL handle any timezone changes (daylight savings or some other changes).
The time zones available in PosgreSQL can be checked in the pg_timezone_names table and, once #797 lands, it should be easy to switch the timezone selection from offset to timezone in the generated query.

Stale


Plugin not working with Bucket_policy_only

Hello,
We have tested your plugin with a bucket in Bucket_policy_only mode.
The upload failed silently. The media stayed on the disk instead of going in the bucket.
Switch the Bucket_policy_only to false solved the problem.
Your competitor, WP Media Cloud, support this option.
Regards,

Bucket_policy_only has been deprecated and replaced with uniform_bucket_level_access.
Relevant issue at https://github.com/udx/wp-stateless/issues/521


Error while uploading video

on 26/8 friday is still ok can upload videos
but today 27/8 error when uploading
[14:34:29] ←[92mAuthenticating browser with cookies←[0m
[14:34:29] Create a chrome browser instance in headless mode
DevTools listening on ws://<IP_ADDRESS>:57538/devtools/browser/782c7b28-6f06-4dca-88de-f15934c5999e
[14:34:44] Authenticating browser with cookies
[14:35:04] Posting video0007.mp4
with description: this is my escaped from the worl
[14:35:04] Navigating to upload page
[14:35:08] Uploading video file
Message:
Stacktrace:
GetHandleVerifier [0x00E737C3+48947]
(No symbol) [0x00E08551]
(No symbol) [0x00D0C92D]
(No symbol) [0x00D39E38]
(No symbol) [0x00D39EFB]
(No symbol) [0x00D68EF2]
(No symbol) [0x00D550D4]
(No symbol) [0x00D675DA]
(No symbol) [0x00D54E86]
(No symbol) [0x00D316C7]
(No symbol) [0x00D3284D]
GetHandleVerifier [0x010BFDF9+2458985]
GetHandleVerifier [0x0110744F+2751423]
GetHandleVerifier [0x01101361+2726609]
GetHandleVerifier [0x00EF0680+560624]
(No symbol) [0x00E1238C]
(No symbol) [0x00E0E268]
(No symbol) [0x00E0E392]
(No symbol) [0x00E010B7]
BaseThreadInitThunk [0x760000C9+25]
RtlGetAppContainerNamedObjectPath [0x77587B1E+286]
RtlGetAppContainerNamedObjectPath [0x77587AEE+238]
Message: no such element: Unable to locate element: {"method":"xpath","selector":"//input[@type='file']"}
(Session info: chrome=116.0.5845.111); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Stacktrace:
GetHandleVerifier [0x00E737C3+48947]
(No symbol) [0x00E08551]
(No symbol) [0x00D0C92D]
(No symbol) [0x00D39E38]
(No symbol) [0x00D39EFB]
(No symbol) [0x00D68EF2]
(No symbol) [0x00D550D4]
(No symbol) [0x00D675DA]
(No symbol) [0x00D54E86]
(No symbol) [0x00D316C7]
(No symbol) [0x00D3284D]
GetHandleVerifier [0x010BFDF9+2458985]
GetHandleVerifier [0x0110744F+2751423]
GetHandleVerifier [0x01101361+2726609]
GetHandleVerifier [0x00EF0680+560624]
(No symbol) [0x00E1238C]
(No symbol) [0x00E0E268]
(No symbol) [0x00E0E392]
(No symbol) [0x00E010B7]
BaseThreadInitThunk [0x760000C9+25]
RtlGetAppContainerNamedObjectPath [0x77587B1E+286]
RtlGetAppContainerNamedObjectPath [0x77587AEE+238]
Message: no such element: Unable to locate element: {"method":"xpath","selector":"//input[@type='file']"}
(Session info: chrome=116.0.5845.111); For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Stacktrace:
GetHandleVerifier [0x00E737C3+48947]
(No symbol) [0x00E08551]
(No symbol) [0x00D0C92D]
(No symbol) [0x00D39E38]
(No symbol) [0x00D39EFB]
(No symbol) [0x00D68EF2]
(No symbol) [0x00D550D4]
(No symbol) [0x00D675DA]
(No symbol) [0x00D54E86]
(No symbol) [0x00D316C7]
(No symbol) [0x00D3284D]
GetHandleVerifier [0x010BFDF9+2458985]
GetHandleVerifier [0x0110744F+2751423]
GetHandleVerifier [0x01101361+2726609]
GetHandleVerifier [0x00EF0680+560624]
(No symbol) [0x00E1238C]
(No symbol) [0x00E0E268]
(No symbol) [0x00E0E392]
(No symbol) [0x00E010B7]
BaseThreadInitThunk [0x760000C9+25]
RtlGetAppContainerNamedObjectPath [0x77587B1E+286]
RtlGetAppContainerNamedObjectPath [0x77587AEE+238]
[14:35:45] Failed to upload E:\TikTok\tiktok-uploader4\video0007.mp4
[14:35:45]
A video failed to upload

Error while uploading video
please check kaise how to solve...many many thanks

recently they changed the interface so Try the below solution
in the config.toml file
change line  21
upload = "https://www.tiktok.com/upload?lang=en"
to
upload = "https://www.tiktok.com/creator-center/upload?lang=en"

hi @piriyaraj thanks for the solution,
but only success with command single video
when do multi upload videos have error, and only first video uploaded, the rest is failed
[18:18:48] ←[92mAuthenticating browser with cookies←[0m
[18:18:48] Uploading 10 videos
[18:18:48] Create a chrome browser instance
DevTools listening on ws://<IP_ADDRESS>:52523/devtools/browser/612ac1a2-bce4-43b3-b4d7-376ffc0fdc53
[18:19:03] Authenticating browser with cookies
[18:19:15] Posting video001.mp4
with description: Thanks-001
[18:19:15] Navigating to upload page
[18:19:22] Uploading video file
[18:20:01] Setting interactivity settings
[18:20:01] Setting description
[18:20:02] Clicking the post button
[18:20:17] Video posted successfully
[18:20:17] Posting video002.mp4
with description: Thanks-002
[18:20:17] Navigating to upload page
[18:20:17] Failed to upload E:\TikTok\tiktok-uploader4\video002.mp4
[18:20:17] Alert Text: {Alert text :
Message: unexpected alert open: {Alert text : }
(Session info: chrome=116.0.5845.111)
Stacktrace:
GetHandleVerifier [0x002437C3+48947]
(No symbol) [0x001D8551]
(No symbol) [0x000DC92D]
(No symbol) [0x00137AAD]
(No symbol) [0x00124E86]
(No symbol) [0x001016C7]
(No symbol) [0x0010284D]
GetHandleVerifier [0x0048FDF9+2458985]
GetHandleVerifier [0x004D744F+2751423]
GetHandleVerifier [0x004D1361+2726609]
GetHandleVerifier [0x002C0680+560624]
(No symbol) [0x001E238C]
(No symbol) [0x001DE268]
(No symbol) [0x001DE392]
(No symbol) [0x001D10B7]
BaseThreadInitThunk [0x760000C9+25]
RtlGetAppContainerNamedObjectPath [0x77587B1E+286]
RtlGetAppContainerNamedObjectPath [0x77587AEE+238]
(No symbol) [0x00000000]
can you check?
thanks for your help

Creator center is in beta if I am not mistaken.
Did it move in an out of beta? I really don't know, but I was not able to have access to this.


Update Babel config for modern output

Switched babelrc to use recommended settings for "modern JS", with targets: esmodules and bugfixes: true
Fixed missing .tsx extensions in build scripts
Silenced Rollup warning about missing flag

Hi，I'm confused with the code in .babelrc.js:
...
targets: {
  esmodules: true,
},
...

The code will keep let/const syntax in dist/react-redux.js/dist/react-redux.min.js/es/*.js/lib/*.js. If I want to use react-redux, I have to transform the code of react-redux by Babel again (because you already transform it by Babel)。If you want to keep import/export syntax, I think modules: false in .babelrc.js is enough.
I wonder What is the perpose of this. Hope I didn't offend you.

What is the problem with let and const? Those are part of ECMAScript2015, which is 7 years at this point. Even with other targets than esmodules we are targeting more modern browsers.

Thanks for your answer, I get it.
Because of the users of our products, I have to support iOS9. When I use react-redux, I config the webpack like this as usual:
{
  test: /\.(ts|js)x?$/,
  exclude: /node_modules/
}

This doesn't work on iOS9.
Then I find that redux's targets is browsers: ['ie >= 11'], so i am confused with the difference between redux and react-redux.
Thanks for your awesome work.

Thanks for your detailed answers! I will transpile myself. ^-^


VariantManagement - addVariantItem

OpenUI5 version:
1.108
Browser/version (+device/version):
Chrome: 114 (64-bit) on Windows10
Steps to reproduce the problem:

I created a VariantManagement control for an sap.ui.table.
I  add VariantItems from our database (customer views) to VariantManagement (VM) control
When I change the view name in Manage Views I get an duplicateVariant error
When I save a new view, I get a no connector error

What is the expected result?
There should be a public method to add VariantItems to VM control.
There should be an API documentation about the VaraintModel
What happens instead?
We use the internal method ._oVM.addItem( new sap.m.VariantItem({ 'title': 'x', 'key': 'ourKey', 'author': 'userName', 'changeble': true, 'remove': true, 'favorite': true'}))  of VM control.  This unfortunately cause some error messages when we use the Manage Views of VM:
Cannot read properties of undefined (reading 'instance')   at P._duplicateVariant (user changes the view name)
No Connector configuration could be found to write into layer: USER (user creates new view)
Any other information? (attach screenshot if possible)
We switched our framework from SAPUI5 v. 1.96 to OpenUI5 v. 1.108. With SAPUI5 v. 1.96, we were able to add VaraintItems from our database to the VariantManagement via XML view or with public method addVariantItem.
In the source code of VM control I saw that the control now uses the VariantModel, which I can assign to the VM control by setting the “modelName”. Unfortunately, there is no documentation about the VariantModel.
I also noticed, that the library sap.ui.fl does not contain variants.VariantManagement.js. (see preload screenshot)

Hi @TheNorthBridge,
I briefly had a look into the implementation of sap.ui.fl.variants.VariantManagement. The VariantItems are supposed to be managed by the model. The model needs to be created at your side and you can add data into the model after the data is loaded from your backend.  sap.ui.fl.variants.VariantManagement has a property called modelName in case the model is available under a different name than the default name undefined. The data in the model share the same property set as the sap.m.VariantItem control and you can see the binding template that is used in the aggregation binding here. Since the items should be added via binding and the model which is provided by the application, there won't be any addItem method provided. You need to switch to using the binding and model to replace the access to the private variable and the calling of addItem.
The issue that the sap/ui/fl/library-preload.js didn't include sap.ui.fl.variants.VariantManagement is an issue in 1.108 and it doesn't occur with the latest UI5 version.
Can you please check whether you can switch to the binding way for creating the items? I will then create an internal incident to follow the fix of the missing module in the library-preload.js in 1.108.
Best regards,
Jiawei
SAPUI5 Core Dispatcher

Hi @stopcoder
Thank you for your advice.
I have modified our backend service to provide a model with a list of variants.
Unfortunately, I could not get it to work! I spent some time analyzing the problem by checking your sources and tests on GitHub and the examples on sdk.openui5.org.
I came to the conclusion that switching to model binding will not work for us:

We can't provide different models for each table we have (+30) to make path binding work, see VariantManagement  line 784 to 786
It seems that VariantManagement requires a fully loaded model with variants before the control is instantiated. We are using a custom library to manage our personalization, which will load/manage/save data after the control is instantiated. As I mentioned we have more than 30 tables and some have more than 100 columns with special variants, that's why a preload will have a big impact on performance.
But the most imported feature that would not be available if we provided a working model is the SAP standard view (default variant) that is generated by VariantManagement. We need this view and persisting the data (default variant) in the backend is not an option.

It would be really nice if you guys could provide a method to add the VariantItems manually.
For now (workaround), I get the default VariantModel from the VariantManagement control and push our VariantItems into the VariantArray of and update the model. This works fine.
Unfortunately, I'm still getting an exception when I create a new variant from the standard/default SAP view:
Uncaught (in promise) Error: No Connector configuration could be found to write into layer: USER
at o (Storage-dbg.js:51:10)
In our index.html we have bootstrapped your application with data-sap-ui-flexibilityServices="[]". My understanding is that this disables the "SAPUI5 Flexibility Service" and should see this exception.
Cheers
@TheNorthBridge

Hi @TheNorthBridge,
I created an internal incident with number<PHONE_NUMBER>. Updates will be posted here.
Best regards,
Jiawei

Hi @TheNorthBridge,
I get the request from the flexibility team that they need to have an access to your application to debug the issue. Is it possible for them to debug your application to understand the usage?
Best regards,
Jiawei

Hi @stopcoder,
yes, I can give a single member of the flexibility team access to our demo application running in the cloud. Unfortunately, the application runs in a secure environment (firewall, authentication, authorization, etc.), so we need to schedule a meeting first to clarify the credentials. What is the best way for us to exchange contact information and schedule a meeting?
Thx,
@TheNorthBridge

@TheNorthBridge Sorry for no response since October. Currently, we have two options how we can proceed on this ticket:
Option 1: Open a SAP support incident on https://support.sap.com/en/index.html and provide access details there. (Only available for SAP customer)
Option 2. Provide a sample app on github with mocked backends (not ideal I know)

Hi @flovogt,
I have created an incident with the ticket number: 89384 / 2024. You will find my contact data in the ticket (main contact person).
Cheers

Thanks a a lot @TheNorthBridge for opening the customer incident. I will close the github issue here. The responsible team will git in touch with you via the customer incident.


Summary values challenges

There seems to be no end of minor issues in the main paper - I spotted some more, the first two patches.
I have shortened some of the challenges and added them back in.

So, this would be mergeable, and more changes to follow?

merging this to get the fixes in the main repo.


Shooting cannon ball into sand castle level

needs #47. also could would be nice to have cannon ball to interact with / sit on top of the sand particles


bugfix: next_pixel_in_line

should be "-" instead of "+" for correct calculation of next pixel in "else" case

Thanks @remibettan :) How do I merge this PR?

Thanks @remibettan :) How do I merge this PR?

Closed and reopened to trigger all checks.

Thanks @remibettan :) How do I merge this PR?

Hi @YoniChechik - we will merge it.


msodbcsql/mssql-tools Package is not installing correctly.

Issue Type

Bug Report / Support Request

Your Environment
Vagrant 1.9.5
VirtualBox 5.1.22r115126

Your OS

Linux (Ubuntu 16.04)

Full console output
https://gist.github.com/jonnyeom/6af122d82e4abd24d74a6589e08d674b
Summary
I ran into this error while provisioning.
I believe the problem is that the msodbcsql package and mssql-tools needs a yes confirmation when getting installed. Microsoft recommends using the ACCEPT_EULA=Y flag when installing this package, as shown here.
I may be wrong but hope this helps.

I think this is best installed as a custom post provision task.
Something similar to:
---
- apt_key:
    url: "https://packages.microsoft.com/keys/microsoft.asc"
    state: present

- apt_repository:
    repo: "deb [arch=amd64] https://packages.microsoft.com/ubuntu/16.04/prod xenial main"
    state: present
  register: odbc_repo

- apt: update_cache=yes
  when: odbc_repo.changed

- apt:
    name: "{{ item }}"
    state: present
  with_items:
    - msodbcsql
    - mssql-tools
  environment:
    ACCEPT_EULA: Y

- lineinfile:
    path: /etc/environment
    line: 'PATH="$PATH:/opt/mssql-tools/bin"'

@oxyc You are correct. This was part of a post-provision task, not part of the original drupalvm provisioning. Thanks for clearing that up, this was very helpful.


[Tensorflow C++ API]Multiple session on single GPU

We are using tensorflow 1.4 c++ for run-time prediction.  Our 4 models are loaded by 4 session instances within one project on one GPU. The project breaks down after a few predictions.
The output error message is:  [tensorflow\core\common_runtime\bfc_allocator.cc:464] Check failed: c->in_use() && (c->bin_num == kInvalidBinNum)
Is this memory problem?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@tensorflowbutler
Os: Windows 10
Have I written custom code - No
TensorFlow version -1.4.0
CUDA/cuDNN version - 8.0
GPU model and memory - 1x NVIDIA GTX1050 / 10 GB
We followed an unofficial tutorial to build tensorflow c++ API for WINDOW using. We design 2 threads, each thread has 2 instances of session which load the different model to process the different task. We found when we run 2 models in one thread and 1 model in another thread at the same time, everything is ok, but both 2 threads load 2 models simultaneously, the project would break down. We tried to set 'set_per_process_gpu_memory_fraction(0.3)' to restrict each process memory usage, but still the same issue, and memory usage seems not change. So, I wonder to know whether Tensorflow 1.4 does not support the multiple processes on single device well like this. Or we need to do the specific operation to make this happen.
By the way, 4 models are 2 deeplab V3 Xeption65 + 2 mobilenet V1_1.0_224
Thanks a lot.

Nagging Assignee @shivaniag: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 75 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 105 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @shivaniag: It has been 120 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I receive also the following message upon evaluation of Tensorpack FasterRCNN module:
1031 10:42:17 @train.py:484] Running evaluation ...
Backend TkAgg is interactive backend. Turning interactive mode on.
0%|          | 172/40504 [00:36<1:28:26,  7.60it/s]2018-10-31 10:46:31.508464: F tensorflow/core/common_runtime/bfc_allocator.cc:462] Check failed: c->in_use() && (c->bin_num == kInvalidBinNum)
anyone figured this out?
Thanks...

Nagging Assignee @shivaniag: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

It seems no one to answer. So I close it here.

What is the fix for this,I have same issue

@learnermaxRL
Well, I'm not sure why but for me downgrading tensorflow 1.11 to 1.10 fixed this issue...
I'd be happy to know it worked for you.
Good luck :-)


Webapp:Cannot add the same webapp restriction rule to scm site when rules is already in the main site

Describe the bug
When I add rule to the main site and then try to add rule to scm site with the same ip address I got this error:

IP address <IP_ADDRESS>/32 already exists.Cannot add duplicate IP address values.

However, when I first add tule to scm site and then to main site all is fine.
To Reproduce
Run command in this order:
az webapp config access-restriction add --resource-group 'TheCodeManual' --name 'angular-webapp-demo' --action Allow --priority 20 --ip-address '<IP_ADDRESS>/32' --rule-name 'Test1' --description 'Test1'

az webapp config access-restriction add --resource-group 'TheCodeManual' --name 'angular-webapp-demo' --action Allow --priority 21 --ip-address '<IP_ADDRESS>/32' --rule-name 'Test2' --description 'Test2' --scm-site $true

Expected behavior
I know I can use az webapp config access-restriction set --use-same-restrictions-for-scm-site  but this behavior is counterintuitive. I expect to be able to add rule to scm in that way.
Environment summary
I tested this on Azure Cloud shell
azure-cli                         2.11.1

core                              2.11.1
telemetry                          1.0.5 *

Extensions:
ai-examples                        0.2.3

webapp

The same Issue as #14862 But that one is not been resolve yet.

Same issue here, but figured it out by adding first scm site rules  and then the main app site.

@panchagnula I talked to @madsd and he was going to help take a first pass with all the access restrictions related items.

This is fixed by #15784


VoIP app is missing from stock Contacts app on iOS

Hi,
looks like this plugin should support this feature when voip app can be opened (called via) from ios contacts but it does not work for me...
please see how WhatsApp is added to the list on this screenshot as example

is this something that can be done by updating supportedHandleTypes with CXHandleTypePhoneNumber or I'm just missing some configuration to make it work?
thank you!

it's not exactly about making a call from Recents, the scenario is:
open Phone book on iOS, select any contact, get my voip app listed in the action sheet along with WhatsApp and other callkit enabled apps
can you please confirm if this feature is supported in this plugin?
thank you
ps: setIncludeInRecents(true) is set

Good catch! You're right about using CXHandleTypePhoneNumber. I changed CXHandleTypeGeneric to CXHandleTypePhoneNumber, and now CordovaCall supports calling from contacts in addition to recents. You can either tap and hold the phone or video, and it will force open your app and call the person using your VOIP app. I'm sure you already made the changes to your app, but we appreciate you raising the issue because it will help other app developers in the future.

thanks! it works now with version 1.1.5