Do not add new line after ->

Hi, I tested ex_format and found it breaks line between -> and following clauses. I don't see any style guide on this case, so can we leave it? Or at least leave it for single line clause.
# desired
case foo() do
  :ok -> "foo"
  _ -> "bar"
end

# ex_format output
case foo() do
  :ok ->
    "foo"
  _ ->
    "bar"
end

Hi @chulkilee! Thanks for testing ExFormat :)
Initially, I thought the same too - leaving it for single line clause. However, I think it's better to do a line break after -> for overall consistency since all the clauses can start on the nested new line.
@whatyouhide @josevalim what do you think? This is something we never really discussed as well.

In IntelliJ Elixir, I set it up so that if all the clauses work as one-liners, then one-liners is allowed, but if any clause is multi-line, then they all have to be multi-line, so in a given set of clauses the new line after -> remains consistent.

Oh hey @KronicDeth, thanks for your input. Great work on IntelliJ Elixir btw! Just curious, what do you use to format Elixir source code in IntelliJ?

JetBrains, as part of OpenAPI supplies code for defining formatters.  I used this in IntelliJ Elixir.  The part of the formatting libraries I'm using only manipulates whitespace.
There are 3 extensions I had to define https://github.com/KronicDeth/intellij-elixir/blob/70ecf4e538a30f7f851c8888cd43428be544b46a/resources/META-INF/plugin.xml#L88-L91

codeStyleSettingsProvider
lang.formatter
langCodeStyleSettingsProvider

1 and 3 are for tracking the configuration, so the part you'd be interested in is the lang.formatter, org.elixir_lang.formatting.ModelBuilder.  Rules about spacing are supplied by the SpacingBuilder from ModelBuilder.createSpacingBuilder.  It has rules for before, after, around, and inside different lexer nodes (which uses the ASTNode class in Java).
[ModelBuilder.createModel[(https://github.com/KronicDeth/intellij-elixir/blob/70ecf4e538a30f7f851c8888cd43428be544b46a/src/org/elixir_lang/formatting/ModelBuilder.java#L140-L158) creates a org.elixir_lang.formatter.Block, which is a subclass of com.intellij.psi.formatter.common.AbstractBlock.  The blocks in OpenAPI can are in charge of 3 formatting controls:

WrapType (what to do when you go past the column limit
Indent (how to indent relative to an anchor, either the last line OR the last direct parent)
Alignment (how to align Blocks that share the same Alignment, so you can do stuff like

along_variable_name_pushes_everything_over = 1
b                                          = 2

They also generate the Blocks for their children, so you can have different rules for nested stuff than if they were top-level.
So, the way I did the "one-liner if all can be one-liners" is using the  Wrap.createWrap(WrapType.CHOP_DOWN_IF_LONG, true) because when CHOP_DOWN_IF_LONG is used and all elements share the same Wrap instance they all wrap at the same time.  This is also how I make keyword list all wrap at the same time if any one keyword pair is past the column limit.
How OpenAPI uses these WrapTypes to actually formatter the code is unfortunately in some pretty gnarly code (that was already written thankfully because it was) written kinda like an event callback system to allow the user to interrupt the formatting when it takes too long like most of the stuff in IDEs.

@KronicDeth That's super cool, never knew IntelliJ has that functionality. Thanks for sharing your knowledge! :)

@chulkilee the new formatter mentioned at https://github.com/uohzxela/ex_format/issues/90#issuecomment-326715312 can preserve the desired case:
case foo() do
  :ok -> "foo"
  _ -> "bar"
end


RTL Support

is it still not supporting rtl language ?
when making "flipsHorizontallyInOppositeLayoutDirection" true
the animation is very corrupted

is it still not supporting rtl language ?
when making "flipsHorizontallyInOppositeLayoutDirection" true
the animation is very corrupted

is it still not supporting rtl language ?
when making "flipsHorizontallyInOppositeLayoutDirection" true
the animation is very corrupted

I think i figured it out,
if your project is RTL and you are using
extension UICollectionViewFlowLayout {     open override var flipsHorizontallyInOppositeLayoutDirection: Bool {         return true     } }
the solution is to simply return false, but if you still need that peace of code for something else, do this:
extension AnimatedCollectionViewLayout {     open override var flipsHorizontallyInOppositeLayoutDirection: Bool {         return false     } }
this is worked for me perfectly 😍
thank you @KelvinJin for this awesome library 🌹❤


IMS registration and network deploy

Hi @herlesupreeth , thanks for making this docker and tutorial for programming the SIM card!
I'm trying to make a VoLTE call with the dockerized setting, but I'm facing some troubles now.
Below is my Environment:
OS: Ubuntu 20.04
Device: USRP B210
eNodeB: srslte in docker
SIM: SysmoISIM-SJA2 (programmed successfully by following the nice CoIMS tutorial)
UE: Google Pixel 6 (Android 13)
I used the following command to start the open5gs and enodeB, they are on the same machine.
Terminal 1: docker compose -f 4g-volte-deploy.yaml up
Terminal 2: docker compose -f srsenb.yaml up -d && docker container attach srsenb
The UE was attached successfully (attach complete) but IMS was not registered. Also, I found UE doesn't have the internet access.
I have attached PCAP here, also all the configurations I used and UE screenshots, .env ,etc..
PCAP_and_configs.zip
Note: To make the pcap file more clear, you may use the filter:
s1ap || gtpv2 || pfcp || diameter || diameter.3gpp || sip || dns
Could you please provide some help here? Thanks!

Thanks for the detailed logs and pcap.

I see that phone has attempted to connect to IMS APN and is successful in doing so. But, it didnt send SIP REGISTER towards IMS. You could try/check the following on the phone

Restart the phone and see whether it issues SIP REGISTER or not ( ti can happen that phone gives up on sending SIP REGISTER after repeatedly failing to attach to IMS)
Check whether VoLTE is enabled in the phone settings under mobile network menu

Also, I found UE doesn't have the internet access.

Thats the default behavior of the phone when it fails to register with IMS

Hi @herlesupreeth ,
I further tried several more UEs (with the same SIM Card) listed below:
iphone 13 (ios 17.4.1)
XiaoMi Mix 2 (Android 11), it should have the same baseband chipset as the Oneplus phone you are using.
Both of the phones are attached successfully, but no SIP register was sent when I used dockerized open5gs and dockerized srslte. However, I also tried them with Amarisoft setup, and both of them sent SIP Register after attaching. So, I think the SIM card I programmed is correct, and the problem comes from my dockerized VoLTE setup deployment.
I have the following questions:

I'm running dockerized open5gs and dockerized srslte on the same machine, in the .env file, I set the DOCKER_HOST_IP=<IP_ADDRESS>, which is ip address of my wifi adapter (see my config in ifconfig_terminal.txt attached before), is it a correct setting? I also didn't change the UE_IPV4_INTERNET and UE_IPV4_IMS in .env.
I started dockerizing srslte using the command docker compose -f srsenb.yaml up -d && docker container attach srsenb directly. Is there anything I need to change in the config file to support VoLTE?
I noticed some ICMP packets in the pcap file (docker_open5gs_enb_iphone.pcapng). Based on the .env, <IP_ADDRESS> is the IP of dockerized enodeB, but it shows the destination unreachable. Is there anything wrong with my configuration file?

New pcaps are attached and my configuration files are attached before. Thanks for your time and assistance!
PCAPS2.zip

I'm running dockerized open5gs and dockerized srslte on the same machine, in the .env file, I set the DOCKER_HOST_IP=<IP_ADDRESS>, which is ip address of my wifi adapter (see my config in ifconfig_terminal.txt attached before), is it a correct setting? I also didn't change the UE_IPV4_INTERNET and UE_IPV4_IMS in .env.

This shouldnt matter if all are running in the same machine

I started dockerizing srslte using the command docker compose -f srsenb.yaml up -d && docker container attach srsenb directly. Is there anything I need to change in the config file to support VoLTE?

Nope

I see iPhone attempting to initiate a SIP REGISTER by first sending TCP SYN to port 5060 but strangely its been replied with ICMP unreachable.
Can you execute the following on the host machine and then give it a try once more please?
sudo ufw disable
if the above method also doesnt work then I would check whether P-CSCF is properly up and running when deployed.

I'm running dockerized open5gs and dockerized srslte on the same machine, in the .env file, I set the DOCKER_HOST_IP=<IP_ADDRESS>, which is ip address of my wifi adapter (see my config in ifconfig_terminal.txt attached before), is it a correct setting? I also didn't change the UE_IPV4_INTERNET and UE_IPV4_IMS in .env.

This shouldnt matter if all are running in the same machine

I started dockerizing srslte using the command docker compose -f srsenb.yaml up -d && docker container attach srsenb directly. Is there anything I need to change in the config file to support VoLTE?

Nope

I see iPhone attempting to initiate a SIP REGISTER by first sending TCP SYN to port 5060 but strangely its been replied with ICMP unreachable.
Can you execute the following on the host machine and then give it a try once more please?
sudo ufw disable
if the above method also doesnt work then I would check whether P-CSCF is properly up and running when deployed.

Hi @herlesupreeth, thanks for your assistance!
I executed  sudo ufw disable and used another command, sudo ufw status, to check the firewall status; I got "Status: inactive."
Then I tried with iPhone 13 again, pcap is attached, and I saw the problem you mentioned is still there. I also attached my terminal logs, I also saw some errors in the terminal logs.
Btw, I also tried to ping <IP_ADDRESS> from my host machine, and it looks okay.
Thanks again for your help!
PCAP3.zip

Its still the same. I would suggest to reboot the machine. Then execute sudo ufw disable. Then, bring up all services and attempt an IMS registration


USPS mail reports one item, but multiple exist

USPS informed delivery daily digest contains multiple items, but only one is reported. Images below show the mail entity, the 3 items in the email, and the generated mail image. Also attached are the email document and the integration diagnostics.

Generated image:

Your Daily Digest for Wed, Nov 30.zip
config_entry-mail_and_packages-e25c1b22d794c37199a7dbb60d9427b7.json.txt

Junk mail adverts are filtered out.

OK, thanks for that info. Closing.


Error with sign-in inside Controller

Hi,
I've been using this package to connect to Twitter's API for a variety of uses and it's been great. However I have a consistent problem when trying to sign-in via Twitter.
I started off by using the code in your example for logging in and if I keep my version of that code in routes.php then everything works as expected.
The problem I have is that if I move that code into controller (so I can access useful methods before rendering the view) then I always run into problems. The request goes to Twitter, but then Twitter keeps reloading the token request page (https://api.twitter.com/oauth/authenticate?oauth_token=[removed]) without sending anything back to my callback (I am tracking requests on the network tab in Chrome's dev tools). Eventually I hit the Twitter API rate limits.
I'm using this with Laravel 5.
Here are the relevant snippets of code:
##Route file contents
<?php
Route::get('twitter/login', ['as' => 'twitter.login', function(){
    // your SIGN IN WITH TWITTER  button should point to this route

    $sign_in_twitter = true;
    $force_login = false;

    // Make sure we make this request w/o tokens, overwrite the default values in case of login.
    Twitter::reconfig(['token' => '', 'secret' => '']);

    $token = Twitter::getRequestToken(route('twitter.callback'));

    if (isset($token['oauth_token_secret']))
    {
        $url = Twitter::getAuthorizeURL($token, $sign_in_twitter, $force_login);

        Session::put('oauth_state', 'start');
        Session::put('oauth_request_token', $token['oauth_token']);
        Session::put('oauth_request_token_secret', $token['oauth_token_secret']);

        return Redirect::to($url);
    }

    return Redirect::route('twitter.error');
}]);

Route::get('twitter/callback', ['as' => 'twitter.callback', 'uses' => 'SearchController@loginCallback']);

Route::get('twitter/signed-in', ['as' => 'twitter.signed-in', 'uses' => 'SearchController@signedIn']);

Route::get('twitter/error', ['as' => 'twitter.error', function(){
    return Redirect::to('/error')->with('flash_notice', 'Unfortunately, we couldn\'t log you in, please try again.');
}]);
?>

##Controller file contents
<?php
public function loginCallback (Request $request)
    {
        if (Session::has('oauth_request_token'))
        {
            $request_token = [
                'token'  => Session::get('oauth_request_token'),
                'secret' => Session::get('oauth_request_token_secret'),
            ];

            Twitter::reconfig($request_token);

            $oauth_verifier = false;

            if (Input::has('oauth_verifier'))
            {
                $oauth_verifier = Input::get('oauth_verifier');
            }

            // getAccessToken() will reset the token for you
            $token = Twitter::getAccessToken($oauth_verifier);

            if (!isset($token['oauth_token_secret']))
            {
                return Redirect::route('twitter.login')->with('flash_error', 'We could not log you in on Twitter.');
            }

            $credentials = Twitter::getCredentials();

            if (is_object($credentials) && !isset($credentials->error))
            {

                Session::put('access_token', $token);
                Session::put('user_id', $credentials->id);
                Session::put('user_screen_name', $credentials->screen_name);
                Session::put('user_name', $credentials->name);
                Session::put('user_profile_image', $credentials->profile_image_url);

                return Redirect::route('twitter.signed-in');
            }

            return Redirect::route('twitter.error')->with('flash_error', 'Crab! Something went wrong while signing you up!');
        }
    }

    public function signedIn ()
    {
        $tweets_json = Twitter::getHomeTimeline(['count' => '80']);

        $user_bio = array();
        $user_bio['screen_name'] = Session::get('user_screen_name');
        $user_bio['user_name'] = Session::get('user_name');
        $user_bio['user_profile_image'] = Session::get('user_profile_image');

        return view('tweets', ['tweets' => $tweets_json, 'user_bio' => $user_bio]);
    }
?>

Any help you could provide would be amazing.
Thanks

Hi,
I managed to find my issue. My controller was trying to do too much and the constructor included logic which would prevent this from working. Doh!


React step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Congratulations! 🥇 You have successfully completed part 1 of the carbon tutorial.


ReduceLROnPlateau does not work properly when choosing different monitor

Hi
I'm working from a Kaggle Notebook and I want to change the metric to monitor during ReduceLRonPlateau by another one (F1 score).
It seems the function is identifying properly the 'val_f1_metric' to monitor (look how the metric is reduced from inf to val_f1_metric after the first epoch) But, in the next epochs, the improvement of the metric is not identified:

I have the intuition taht, after the first epoch, the evaluation is being done on 'val_loss' instead of on 'val_f1_metric'.
The change of monitor is written like this:
reduce_lr = ReduceLROnPlateau(monitor='val_f1_metric', factor=0.5, patience=1, min_lr=0.0001, verbose=2)
Please let me know if there is something written wrong.
Thanks for the help

Ok, I found the problem. I had to calculate 1 -f1 instead of f1. The issue can be closed.

@danielcanueto you could also achieve the intended result of monitoring F1 (and not 1 - F1) by setting mode=max in the ReduceLROnPlateau.__init__. It's by default set to auto, which ends up acting as if mode=min since acc isn't in your metric name. Reference lines:
https://github.com/keras-team/keras/blob/master/keras/callbacks.py#L1085

Closing as this can be solved with @sallamander 's solution.


Rephrasing required on Completed order page

v. 2.2.3
After paying for a moderated order, buyer receives the following message:
"Your payment has been sent to the vendor."

But actually the payment has been sent to the moderator (escrow). In these cases the message should be:
"Your payment has been sent to the moderator." or simply "Your payment has been sent."

The payment has been sent to the vendor. It's held in escrow until the order is completed, but the moderator doesn't have the payment.
We could clarify this message to say "Your payment is being held in escrow until the order is complete."

I prefer the following message to moderated payment: "Your payment has been sent and is being held in escrow until the order is complete.". This looks more like a success message.
The current message "Your payment has been sent to the vendor." seems strange to me, because it gives the idea that the user selected direct payment instead of moderated (see below):

Current description of Direct Payment: "Send funds directly to the seller without a moderator. You should only use this option with sellers you trust."
Current description of Moderated Payment: "Your payment will be held securely in escrow. If any issues arise, you’ll have the ability to open a dispute with your chosen moderator."


⚠ Bofrost.at has degraded performance

In 942fdfe, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1310 ms

Resolved: Bofrost.at performance has improved in 7c375dd after 6 minutes.


Hardware frame timestamp reset / overflow on D435

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04 LTE

Kernel Version (Linux Only)
4.13.0-39-generic

Platform
PC

SDK Version
2.10.4

Hardware frame timestamp reset / overflow on D435
What is the exact point at which the hardware frame timestamp overflows for the D435? And is it safe to just add that overflow value to the timestamps after they reset to 0? (i.e. are there any known delays, I should be aware of?)
How are the frame numbers handled, at what point do they reset?
Is there a way to reset the counting of frames/timestamp, at each new acquisition?
Thanks!

[Realsense Customer Engineering Team Comment]
Closing ticket


Fix update item on dynamodb2

Added the possibility to call dynamodb_v2 by supplying an additional ExpressionAttributeNames and ExpressionAttributeValues dictionaries.
Also fixed some wrong tests related to the update_item functionality.

thanks


Auto logout after period of inactivity

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
I would like to add in my app auto logout after period of inactivity.
Calling function authService.logout() (authService: MsalService) showing a dialog 'Pick an account - Which account do you want to sign out of?'.
How to skip it, enforce logout?
How to logout a user without any interaction, from code?

Hmm, you could simply wipe clean your storage/session/cookies using an idle timeout function, but without an interaction, Azure AD won't know that your user is signed out, which means they might be able to re-authenticate automatically (since they'll still have a valid session/cookie for AAD).
Perhaps you should take a look at conditional access. You can configure how long they could stay signed-in with that.

@kchlapinski can you describe your scenario more?  What kind of users are we talking about?
If they user could theoretically get single sign on from another app, then would we be signing them out of those apps as well?
We have a number of scenarios where "logout" isn't that intuitive.  Therefore we highly recommend using conditional access to manage this.

Closing as this has been answered.


agent: rework clustermesh config watcher for increased robustness

The agent leverages an fsnotify watcher to detect file changes in the directory containing the etcd configurations for remote clusters (as well as the associated keys/certs), triggering a reconfiguration as appropriate.
This PR reworks the above logic to address two main issues:

Due to how Kubernetes mounts ConfigMaps and Secrets within pods, and in particular the usage of symbolic links to handle atomic updates, changes in existing files were not detected (since the watched file itself was a symbolic link, which doesn't change during such operation). Now, an explicit watch operation is started for each configuration file (i.e., watching the actual target), causing a notification to be properly emitted when that is changed.
Prevent possible spurious notifications even if the configuration is not actually modified. This is achieved through hash comparison.

Integration tests are updated to cover the above two aspects.

Fixes: #23273
agent: rework clustermesh config watcher for increased robustness

verified from our side that this fixes the issue #23273 :+1:

Rebased to retrigger the tests, as images signing previously failed.

/test

/test-1.26-net-next

/test-runtime

/test-runtime

@giorio94 Can you add the upstream commit reference to the commit message as documented in https://github.com/cilium/cilium/blob/master/Documentation/contributing/release/backports.rst?

@giorio94 Can you add the upstream commit reference to the commit message as documented in https://github.com/cilium/cilium/blob/master/Documentation/contributing/release/backports.rst?

@jrajahalme Sorry, I added the wrong label. It was intended to be needs-backport/1.13. Should be fixed now.

/test-runtime


fixed datepicker to not close on mobile

i do not know why this always get reintroduced.

the solution is to use  disableTouchKeyboard option, it would be nice to add this to documentation somewhere :) :+1:

@vavrecan good to hear the disabletouchkeyboard option fixes your issue, document can be found here

oh sorry, i totally skipped that one :/
On Fri, 5 Aug 2016 at 14:02 Jeroen Thora<EMAIL_ADDRESS>wrote:

@vavrecan https://github.com/vavrecan good to hear the
disabletouchkeyboard option fixes your issue, document can be found here
https://bootstrap-datepicker.readthedocs.io/en/latest/options.html#disabletouchkeyboard
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/eternicode/bootstrap-datepicker/pull/1970#issuecomment-237833302,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtIkW0Ej2sLEtDbarUfUTKtV8RcY4W1ks5qcyZegaJpZM4JdnJf
.


Possibility to set the language

Is it possible to add the language to the loaderConfig or better, change it at runtime?

I think the api has this feature like in the link above, but i can't find it in angular-maps.

Yes, should be easily possible. do you want to try to create a pull request? I'd suggest adding a language option field to the MapOptions.....


Error while compiling project

Describe the bug
I've tried to recompile the full project from the master.zip on linux ubuntu VM.
The mvn install command fails with the following output
[INFO] hapi-fhir-spring-boot-sample-client-okhttp ......... SKIPPED
[INFO] hapi-fhir-spring-boot-sample-server-jersey ......... SKIPPED
[INFO] hapi-fhir-spring-boot-sample-server-jpa ............ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19.447 s
[INFO] Finished at: 2019-10-16T13:26:49+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:buildnumber-maven-plugin:1.4:create-metadata (downstream) on project hapi-fhir-base: Execution downstream of goal org.codehaus.mojo:buildnumber-maven-plugin:1.4:create-metadata failed.: NullPointerException -> [Help 1]

Duplicate of #1356 - Please comment on that bug


Windows install instructions contain an error related to ~/esp

I'm following the Windows install instructions as written and see it mention that files will be written to ~/esp but nowhere does it say to create /esp anywhere.
Please update the Windows install instrucions/

This is currently mentioned in http://esp-idf.readthedocs.io/en/latest/get-started/index.html:
We are using ~/esp directory to install the prebuilt toolchain, ESP-IDF and sample applications. You can use different directory, but need to adjust respective commands.

Hi @mike-rankin , did the above suggestion help you resolve the issue?


Add Google login button

A button which enables users to sign through their google credentials

I am working on it


Mark ConfigurationCacheGradlePropertiesIntegrationTest as flaky

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you.


Customizable events

Hi! It will be great if i can flexibly customize alerts that i receiving in Slack.
What missing now:

Ability to disable event about start of upgrade.
Option to enable printing diff of prev./current values (it's about what changed, what reconciled).
Ability to send (or at least collect somewhere) helm logs to see depreciation warnings.
Final message as customized Golang template.

As i understand your architecture - HC (current project) generates *Event for NC (notification-controller), NC sends events, so:

Option in HelmRelease CRD - don't generate some event.
Option in HelmRelease CRD - apply diff as metadata of event.
Same as above.
It's for notification-controller.

I would also love to have this feature. Currently, slack notifications look like this:
helmrelease/my-service
Helm upgrade has started
revision
3.1.0
summary
Some static text
It would be great if we can insert some placeholders (such as certain helm parameter values) either to the summary or to the event message.


Mapping traffic lights to lanes: Motion Prediction dataset

How do I link the traffic light's data to a specific lane (road polyline)?
I thought that variable traffic_light_state/current/id can be mapped to roadgraph_samples/id but it does not seem to be the case. I also tried to use traffic line location (traffic_light_state/current/x and traffic_light_state/current/y) for this mapping but I noticed that traffic lights with distinct traffic_light_state/current/id sometimes have exactly the same location. Thank you in advance for helping!

Hi Dmitri,
The traffic_light_state/current/id field should correspond to the IDs in roadgraph_samples/id.  It is possible that in some cases, the lane samples with the corresponding ID do not exist due to the limit of 20000 map samples in the tensor.  If you have an example to share we can look into it (you can send the scenario ID and the traffic light state).
As for multiple light states having the same location,  this can happen when multiple lanes branch from the same point that are controlled by the same traffic light.  This happens frequently in intersections.

Hi Scott,
Thank you for a prompt reply. I found quite a few scenarios where the traffic_light_state/current/id(s) do not seem to match roadgraph_samples/id(s). Below is one example:
file: 'training_tfexample.tfrecord-00002-of-01000'
scenario_id: b'a4fa09266f0cf658'
list of distinct valid traffic_light_state/current/id: [42 45 46 47 48 49 50]
list of distinct valid roadgraph_samples/id: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18]
Yes, it seems that due to the limit of 20,000 map samples in the tensor only the first IDs in road_samples/id (1-18 in the example above) are stored while the higher IDs corresponding to the traffic_light_state/current/id(s) (42-50) are not.


replaceIds: false  processing options not working

I am sending replaceIds like below  for query.
     {         replaceIds: false,       }
always querySimple function calls  r.map(replaceId) which is same for true or false. after version 2.0.4 it's always like that.
`
var mainQueryResult = function mainQueryResult() {
  return aggregateCall(collection, [].concat(_toConsumableArray(contextOptions.preProcessingPipeline), _toConsumableArray(completeFilterPipelineDetails.pipeline), _toConsumableArray(sortPipeline), _toConsumableArray(skipTakePipeline), _toConsumableArray(selectPipeline), _toConsumableArray(removeNestedFieldsPipeline)), 'mainQueryResult').toArray().then(function (r) {
    return r.map(replaceId);
  }).then(function (r) {
    return { data: r };
  });
};

return Promise.all([mainQueryResult()].concat(_toConsumableArray(totalCount(collection, completeFilterPipelineDetails)))).then(merge).then(summary(collection, completeFilterPipelineDetails));

`

after 2.0.4 version I couldn't find any place to check replaceIds value.

Thanks for the report and the PR. I think you're right that the option is ignored for some reason. I'm looking into it.


HDFS-16316.Improve DirectoryScanner: add regular file check related block.

Description of PR
When blk_xxxx and blk_xxxx.meta are not regular files, they will have adverse effects on the cluster, such as errors in the calculation space and the possibility of failure to read data.
For this type of block, it should not be used as a normal block file.
Details:
HDFS-16316
How was this patch tested?
Need to verify whether a file is a real regular file.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  0s

trunk passed

+1 :green_heart:
compile
28m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
compile
8m 33s
/branch-compile-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
root in trunk failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-0 :warning:
checkstyle
0m 39s
/buildtool-branch-checkstyle-root.txt
The patch fails to run checkstyle in root

-1 :x:
mvnsite
0m 40s
/branch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in trunk failed.

-1 :x:
mvnsite
0m 40s
/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in trunk failed.

-1 :x:
javadoc
0m 41s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

+1 :green_heart:
javadoc
3m 38s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 54s

trunk passed

-1 :x:
shadedclient
8m 47s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 40s

the patch passed

+1 :green_heart:
compile
23m 57s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 57s

the patch passed

+1 :green_heart:
compile
19m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
19m 27s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 811 new + 995 unchanged - 0 fixed = 1806 total (was 995)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 44s
/results-checkstyle-root.txt
root: The patch generated 148 new + 0 unchanged - 0 fixed = 148 total (was 0)

+1 :green_heart:
mvnsite
3m 18s

the patch passed

-1 :x:
javadoc
1m 11s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 99 new + 0 unchanged - 0 fixed = 99 total (was 0)

-1 :x:
javadoc
1m 44s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
6m 13s

the patch passed

+1 :green_heart:
shadedclient
23m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 26s

hadoop-common in the patch passed.

-1 :x:
unit
236m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

442m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 13f1ff0d16c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 112122d3334d13f47868d036ea3fd781a2597e90

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/1/testReport/

Max. process+thread count
3637 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 56s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 41s

trunk passed

+1 :green_heart:
compile
23m 33s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
4m  3s

trunk passed

+1 :green_heart:
mvnsite
3m 25s

trunk passed

+1 :green_heart:
javadoc
2m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  6s

trunk passed

+1 :green_heart:
shadedclient
24m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s

the patch passed

+1 :green_heart:
compile
22m 24s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 24s

the patch passed

+1 :green_heart:
compile
20m 36s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
20m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 53s

the patch passed

+1 :green_heart:
mvnsite
3m 19s

the patch passed

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javadoc
1m 45s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
3m 50s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
23m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 44s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
232m 43s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 13s

The patch does not generate ASF License warnings.

464m 32s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Dead store to corruptBlock in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.checkAndUpdate(String, FsVolumeSpi$ScanInfo)  At FsDatasetImpl.java:org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.checkAndUpdate(String, FsVolumeSpi$ScanInfo)  At FsDatasetImpl.java:[line 2814]

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e7380dcf7e87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3a0edea82a15a207d2904cf2d2876dcdceeb3c7e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/2/testReport/

Max. process+thread count
3367 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 49s

trunk passed

+1 :green_heart:
compile
22m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 43s

trunk passed

+1 :green_heart:
mvnsite
3m 24s

trunk passed

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 53s

trunk passed

+1 :green_heart:
shadedclient
23m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 18s

the patch passed

+1 :green_heart:
compile
21m 39s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
21m 39s

the patch passed

+1 :green_heart:
compile
19m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 37s

the patch passed

+1 :green_heart:
mvnsite
3m 22s

the patch passed

+1 :green_heart:
javadoc
2m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 18s

the patch passed

+1 :green_heart:
shadedclient
23m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 53s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
240m 24s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  8s

The patch does not generate ASF License warnings.

464m 47s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 30c0ae66e875 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk /<PHONE_NUMBER>45309ba9a6c26396556b4c2aaf48f8

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/3/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Here are some unit tests that failed:
org.apache.hadoop.ipc.TestIPC
It seems that these failed tests have little to do with the content I submitted.
Can you help review this pr, @aajisaka  @virajjasani .
Thank you very much.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 42s

trunk passed

+1 :green_heart:
compile
25m  0s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 40s

trunk passed

+1 :green_heart:
mvnsite
3m 21s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 25s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 54s

trunk passed

+1 :green_heart:
shadedclient
22m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s

the patch passed

+1 :green_heart:
compile
24m 30s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 30s

the patch passed

+1 :green_heart:
compile
21m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 59s

the patch passed

+1 :green_heart:
mvnsite
3m 32s

the patch passed

+1 :green_heart:
javadoc
2m 23s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 17s

the patch passed

+1 :green_heart:
shadedclient
23m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  8s

hadoop-common in the patch passed.

+1 :green_heart:
unit
244m 31s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

479m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f5704bbd2c85 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 39177f5f70296fc117b6f5e5bdf01a6acf52e040

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/5/testReport/

Max. process+thread count
3458 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Here are some examples of online clusters.
We construct a block device file such as:

This file is non-standard.
This kind of file is found when DirectoryScanner is working.
log:
2022-02-15 11:24:10,286 WARN org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl: Block:1073741828 is not a regular file.
2022-02-15 11:24:10,286 WARN org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl: Reporting the block blk_1073741828_0 as corrupt due to length mismatch
Then DataNode will tell NameNode that there are some unqualified blocks through NameNodeRpcServer#reportBadBlocks(). After the NameNode gets the data, it will process it further.
After a period of time, the DataNode will automatically clean up these unqualified replica data.

Can you help review this pr again, @jojochuang .
Thank you so much.

Here are some examples of online clusters.
We construct a block device file such as:

This file is non-standard.
This kind of file is found when DirectoryScanner is working.
log:
2022-02-15 11:24:10,286 WARN org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl: Block:1073741828 is not a regular file.
2022-02-15 11:24:10,286 WARN org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl: Reporting the block blk_1073741828_0 as corrupt due to length mismatch
Then DataNode will tell NameNode that there are some unqualified blocks through NameNodeRpcServer#reportBadBlocks(). After the NameNode gets the data, it will process it further.
After a period of time, the DataNode will automatically clean up these unqualified replica data.

Can you help review this pr again, @jojochuang .
Thank you so much.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 36s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 44s

trunk passed

+1 :green_heart:
compile
24m 35s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 11s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 45s

trunk passed

+1 :green_heart:
mvnsite
3m 13s

trunk passed

+1 :green_heart:
javadoc
2m 24s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 12s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m  0s

trunk passed

+1 :green_heart:
shadedclient
23m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s

the patch passed

+1 :green_heart:
compile
24m 48s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 48s

the patch passed

+1 :green_heart:
compile
22m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 51s

the patch passed

+1 :green_heart:
mvnsite
3m 17s

the patch passed

+1 :green_heart:
javadoc
2m 21s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 36s

the patch passed

+1 :green_heart:
shadedclient
24m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 45s

hadoop-common in the patch passed.

+1 :green_heart:
unit
238m 14s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

473m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 94871cc29013 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ca61b8bee32722ede0c39562b39edeee90521ce0

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/6/testReport/

Max. process+thread count
3234 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 22s

trunk passed

+1 :green_heart:
compile
26m 32s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
23m  0s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  8s

trunk passed

+1 :green_heart:
mvnsite
3m 21s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 36s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 57s

trunk passed

+1 :green_heart:
shadedclient
24m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s

the patch passed

+1 :green_heart:
compile
23m 11s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 11s

the patch passed

+1 :green_heart:
compile
21m 53s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 33s

the patch passed

+1 :green_heart:
mvnsite
3m 22s

the patch passed

+1 :green_heart:
javadoc
2m 18s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 34s

the patch passed

+1 :green_heart:
shadedclient
24m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 55s

hadoop-common in the patch passed.

+1 :green_heart:
unit
230m 38s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

471m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3861

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux dbbf79d9ac98 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f5e27e408d9aa8f1e563d139d35a001375e19f7f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/7/testReport/

Max. process+thread count
3544 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3861/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for the suggestion, @jojochuang .
I re-updated the unit tests and also did some tests.
When I remove the fix, the newly added unit test does not succeed, which is expected and does not affect the execution of other unit tests.
Here is an example of the test when removing the fix:

Here is an example during normal testing:

Would you like to help review this PR, @ferhui  @tomscut .
Thank you very much.

Would you like to help review this PR, @ferhui @tomscut . Thank you very much.

Thanks @jianghuazhu  for reminding me.
This check makes sense to me. And what I'm curious about is what was done before the metaFile became a device file? Or what is the root cause of this problem?

@jianghuazhu Thanks for your contribution. @jojochuang @tomscut Thanks for your reviews! Merged.


Simple_Reference solving cleanly, but Simple_Speaker_Listener not being solved by MADDPG

Hello, I like this library quite a bit - it's been very useful so far. I've been aiming to produce a set of benchmark solutions to the MPE environments using it, but I've run into an issue with asymmetrical environments struggling to perform right under MPE. When testing Simple-Speaker-Listener, the listener moves to the center of the landmarks, rather than to the landmark indicated.
Compounding the strangeness is the fact that simple_reference is solved quite cleanly. I'm currently running on version 1.7, with the following training code:
import xuanpolicy as xp
import torch
# Reference, SSL, World_Comm
from pettingzoo.mpe import simple_reference_v3, simple_speaker_listener_v4, simple_world_comm_v3, simple_spread_v3, simple_push_v3
import imageio
from IPython import display
import types
import os
import numpy as np
from collections import defaultdict
device = 'cuda' if torch.cuda.is_available() else 'cpu'

env_type = simple_speaker_listener_v4
env = env_type.parallel_env(max_cycles=25, continuous_actions=True, render_mode="rgb_array")

asymmetric = True # We train one agent if symmetrical, multiple otherwise.
agent_name = 'maddpg' if not asymmetric else ['maddpg'] * len(env.observation_spaces)

env_class_name = env_type.__name__.split('.')[-1]
env_name = f"{'_'.join(env_class_name.split('_')[:-1])}"
cpath = f'/usr/local/lib/python3.10/dist-packages/xuanpolicy/configs/maddpg/mpe/{env_name}.yaml'
runner = xp.get_runner(agent_name=agent_name, env_name=f"mpe/{env_name}", is_test=False)

The configuration I'm using is as follows - it's identical to the config file used to train simple_reference successfully, save for the name of the environment.
agent: "MADDPG"  # the learning algorithms_marl
env_name: "mpe"
env_id: "simple_speaker_listener_v4"
continuous_action: True
policy: "MADDPG_policy"
representation: "Basic_Identical"
vectorize: "Dummy_MAS"
runner: "MARL"

representation_hidden_size: [32, ]  # the units for each hidden layer
actor_hidden_size: [256, ]
critic_hidden_size: [256, ]
activation: 'ReLU'
activation_action: 'sigmoid'

lr_a: 0.01  # learning rate for actor
lr_c: 0.001  # learning rate for critic
tau: 0.001  # soft update for target networks
sigma: 0.1  # random noise for continuous actions
clip_grad: 0.5

buffer_size: 200000
batch_size: 256
gamma: 0.95  # discount factor

training_steps: 30000
training_frequency: 1

n_tests: 5
test_period: 100
consider_terminal_states: False  # if consider the terminal states when calculate target Q-values.

use_obsnorm: False
use_rewnorm: False
obsnorm_range: 5
rewnorm_range: 5

logdir: "./logs/maddpg/"
modeldir: "./models/maddpg/"

Is there something that I've configured incorrectly? Similar settings seemed to work in the original MADDPG paper.

Thank you for your kind words and for providing additional information about the simple_speaker_listener scenario of MPE. The simple_speaker_listener scenario in multi-agent particle environments (MPE) involves heterogeneous cooperative agents, which is different from the other scenarios. The current version of XuanPolicy may not fully support this particular type of environment as it requires further improvements. I appreciate your acknowledgment of this limitation and the intention to address it in future updates. Continuous development and updates are essential for AI systems like XuanPolicy to adapt and improve over time.
If there's anything else I can assist you with, please let me know!

Thanks for the response. I'd be willing to take a shot at getting asymmetrical environments to work in Xuanpolicy, or at least helping develop things in that direction, if desired.
To start with, I've been trying to get my MARL training script to work in the newest version, since that seems like the best place to develop from. I've started by trying to get it to run Simple-Spread, since it already has a .yaml file for that environment. Using similar code to what's above (adapted for version <IP_ADDRESS>), I ran into an error in the memory buffer storage code, which appears to result from inconsistencies in the buffer sizes. Am I doing something wrong when initializing my environment? The memory buffers look like this:
<name>: <buffer_shape>; <to_store_shape>
actions: (16, 5000, 5); (16, 3, 5)        # populate 3 out of 5,000 rows
obs_next: (16, 5000, 18); (16, 3, 18) # Populate 3 out of 5,000 rows
rewards: (16, 5000, 3, 1); (16, 3, 1)   # Populate 1 out of 5,000 rows
terminals: (16, 5000, 3); (16, 3)        # Populate 1 out of 5,000 rows
agent_mask: (16, 5000, 3); (16, 3)    # Populate 1 out of 5,000 rows
state: (16, 5000, 54); (16, 54)            # Populate 1 out of 5,000 rows
state_next: (16, 5000, 54); (16, 54)    # Populate 1 out of 5,000 rows

At present, the code for MARL_OffPolicyBuffer.store attempts to move a shared pointer along dimension 1 of each of the arrays, stepping forward by 1 each time something is stored, which works for everything except actions and obs_next. Is this the result of my initializing something incorrectly?
For completeness, the code I used for this test is below:
import xuanpolicy as xp
import torch
# Reference, SSL, World_Comm
from pettingzoo.mpe import simple_spread_v3
import imageio
from IPython import display
import types
import os
import numpy as np
from collections import defaultdict
device = 'cuda' if torch.cuda.is_available() else 'cpu'

env_type = simple_spread_v3

env_class_name = env_type.__name__.split('.')[-1]
runner = xp.get_runner(method='maddpg', env='mpe', env_id=f"{env_class_name}", is_test=False)

runner.run()

I ran the system again, on the newest version. Might be worth noting that the new config for simple_spread takes roughly three times as long as the prior one (see attached pictures), though it still solves the task correctly. I also found an error in xuanpolicy/environment/pettingzoo/init.py: "simple_speak_listener_v4" should be "simple_speaker_listener_v4". You might also want to look at the difference between "model_dir", "modeldir", "log_dir", and "logdir" in common_tools.py, lines 124 to 163 - it's not major, but might be unintended.

Making those changes, I was able to run simple_speaker_listener with the same hyperparameters as simple_spread. Unfortunately, the model ended up in a local maxima where the speaker always output all zeros, and the listener always moved to the center of the three landmarks. Do you have any advice?

For completeness, I ran simple_reference, again with the same hyperparameters as in the default config for simple_spread. It was able to solve the environment fairly cleanly and reliably. Given that simple_reference is more complex than simple_speaker_listener, it does continue to confuse me that the former works and the latter doesn't.

Runner initialization code for symmetrical and asymmetrical environments is below, in case it is relevant. Everything else,  unless otherwise stated, is identical:
# For ss and sr
runner = xp.get_runner(method='maddpg', env='mpe', env_id=f"{env_class_name}", is_test=False)
# For ssl
#runner = xp.get_runner(method=['maddpg']*2, env='mpe', env_id=f"{env_class_name}", is_test=False)

I think I figured out what was going wrong - I looked through some benchmarking papers, and MADDPG and MATD3 struggle with the SSL environment. Since you also have implementations of MAPPO, QMIX, and MASAC, which are known to reliably solve it, I decided to try them out. Unfortunately, I wasn't able to get either of the three to cleanly solve my target environments. I found some information that might be useful to you, provided below:

MAPPO's MPE Simple_Spread example config doesn't work on the current build, because it's missing a few fields. Specifically, _use_global_state, gain, weight_decay, use_linear_lr_decay, use_huber_loss, huber_delta, use_value_norm, and end_factor_lr_decay _. With those added, it throws a size mismatch error when run - it appears to be passing a single agent's observation into the multi-agent critic, on line 138 of categorical_marl (from line 73 of mappo_learner). Debugging the issue, I found that the following lines of mappo_agents:
if self.use_global_state:
    state = torch.Tensor(state).unsqueeze(1).to(self.device)
    critic_in = state.expand(-1, self.n_agents, -1)
else:
    critic_in = torch.Tensor(obs_n).view([batch_size, 1, -1]).to(self.device)
    critic_in = critic_in.expand(-1, self.n_agents, -1)

pass the correct information to the value function. Adjusting line 73 accordingly, I am able to run simple_reference. MAPPO predicts discrete actions rather than continuous ones, so I ran tests on the discrete environment rather than continuous. Training didn't seem to succeed, though - performance was relatively low, and improved only slowly over the course of training. I have attached the config file I used for MAPPO. It's possible that this is where I went wrong, so if you could have a quick look for anything that's clearly incorrect, it might help substantially. Once I've got a working build, I'll share everything that got me there so that it can be merged into the master repo.
mappo_config.txt

MASAC's default config file for simple_spread appears to be outdated, and is likewise missing a number of required fields. The policy name, "Gaussian_MASAC_Policy" has a typo - the 'p' is lowercase, resulting in an error. Line 35 of masac_agents.py didn't match MARL_OffPolicyBuffer's initialization arguments. I replaced it with the below:

memory = MARL_OffPolicyBuffer(len(config.agent_keys),
                                      state_shape,
                                      config.obs_shape,
                                      config.act_shape,
                                      config.rew_shape,
                                      config.done_shape,
                                      envs.num_envs,
                                      config.buffer_size,
                                      config.batch_size)

From there, MASAC_Agents.act expects an 'episode' argument, but doesn't use it. I replaced line 49 with:
def act(self, obs_n, test_mode, state=None, noise=False):

MASAC's act function only returns an action, so I had to add the following at line 170 of runner_pettingzoo:
elif self.marl_names[h] in ["MASAC"]:
                a = mas_group.act(obs_n[h], test_mode)
				actions_n_onehot.append(a_onehot)

I also had to change the train function of masac_agents to:
def train(self, i_episode):
	sample = self.memory.sample()
	info_train = self.learner.update(sample)
	return info_train

There were a few other version incompatibilities that I didn't manage to identify. I can see if I can patch things more completely and get some test results - let me know if that's desired.

QMIX runs out of the box on simple_spread, but the average reward actually seems to decrease over time. Below is the average reward over one million training steps.

As far as simple_speaker_listener, simple_world, and simple_reference, what algorithm and version would you recommend?

Thank you once again for your valuable advice. We will improve the repo according to your suggestions and comments very soon.
As for your question about simple_speaker_listener, simple_world, and simple_reference, maybe the following repos can help you.

https://github.com/zoeyuchao/mappo.git
https://github.com/marlbenchmark/off-policy.git

Thanks - I took a look at the former, but the latter is new to me.
Since this repo solves simple_reference well, I think I might be able to figure out what's going wrong with simple_speaker_listener. If I do, I'll report back with what I learn.


devel_glfw3.1: Consider splitting changelog into two lists, glfw3-specific and GLFW 3.1-specific changes.

Right now the devel_glfw3.1 changelog mentions both changes relevant to glfw3 the Go package itself, as well additions that are simply wrappers around new functionality being added in GLFW 3.1.
They are intertwined and IMO it'd be better to organize them in a way that makes the distinction more clear.

Closing this in favor of #120.


Pre-release version tip.

I've added a tip on how to mark the package as pre-release right after the "Create and update the .nuspec file" section..

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Guides/Create-Cross-Platform-Packages.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks, that's a helpful addition.


3 setup pip

Amended setup.py and added pyproject.py in preparation for pip install stage

Looks good!


Test deploy.

:tada: This PR is included in version 1.0.0 :tada:
Your semantic-release bot :package::rocket:


[ODS-5372] Support PS 7.2 and Unix - Script group 3

Note that no changes were made to database-management.psm1 since SQL Server for Linux is not going to be supported; PostgreSQL is the only supported engine in Linux.
To test get-populated-from-nuget.ps1, you have to use a v2 Nuget feed (v3 isn't supported by Save-Package), use: https://pkgs.dev.azure.com/ed-fi-alliance/Ed-Fi-Alliance-OSS/_packaging/EdFi/nuget/v2/

Making a general comment here since the file was not change. The settings-teamcity.psm1 file was in the list of files to check, and on line 18 I believe we need to change $env:TEAMCITY_BUILD_PROPERTIES_FILE to [Environment]::TEAMCITY_BUILD_PROPERTIES_FILE


Display real Collection name, description and affiliation in the Collection Page

Overview of the Feature Request
Display real Collection name, description, labels and affiliation in the Collection Page. Implement the UI logic and components to show this data and connect it to the js-dataverse use case.
This issue depends on:

https://github.com/IQSS/dataverse-client-javascript/issues/131

Mock

What kind of user is the feature intended for?
This feature is intended for all users.
What inspired the request?

Suggestions from the beta proposal labeled as "nice to haves."

What existing behavior do you want changed?
None
Any brand new behavior do you want to add to Dataverse?
Add real Collection name, description, labels and affiliation in the Collection Page
Any open or closed issues related to this feature request?

https://github.com/IQSS/dataverse-client-javascript/issues/131

Removing the Waiting tag because I already reviewed the js-dataverse PR and there are some changes requested, but the use case can already be used to retrieve the collection data

https://github.com/IQSS/dataverse-client-javascript/pull/134


Radio onChange does not fire when its deselected.

Radio onChange does not fire when another radio with the same name is selected and makes the original radio deselected. Then when clicking the original Radio it will falsely show that it is not selected.

React does not fire an event for true to false events so we would have to use raw javascript and make a custom solution 1. However most if not all users will be using a radio component with at least one other radio and is only concerned with the value of the selected radio.


feat: extend developer workflow docs for new wash commands

Feature or Problem

This commit extends the developer workflow docs with the new commands that were added to wash and released in version 0.29.0:

wash app validate
wash up --manifest
wash app deploy --replace

These commands make the workflow quicker (and are the precursors to wash app dev), so having some docs around them will hopefully improve DX.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Just the nittiest of nits for stylistic consistency—looks great 🚀

Thanks @ericgregory  for making it so easy to apply the changes!


Add parameters to example 2 Get-SPOHubSite.md

In example 2 I added the parameter -Identity, because is important to add the URL of the HubSite to display the information

[x] Add content

Docs Build status updates of commit 32f906f:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 32f906f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9701a65:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 9701a65:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit edba75e:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit edba75e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 39f96aa:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 39f96aa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c3d1b25:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c3d1b25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


SP: 3 GET Customer Detail Info

Implement Customer Detail View, where all necessary info is provided. If a Customer with such PK does not exist, display a 404 error. User Story #26

Closed by #63


Double-tap on textViews shows "copy/define" menu if selectable == YES

double tap cell, show menu,choose "copy" will crash

duplicate of #591 -- please comment there.

Re-opening this issue as "an official duplicate" of #591 to track the issue here instead of on #591 .
I think we have no option but to use TTTAttributedLabel at this point.
But, this will also help with #492

Thanks @jessesquires, JSQMessagesViewController let my project more smoothly.I will use JSQMessagesViewController JSQLocationMediaItem JSQVideoMediaItem, JSQPhotoMediaItem. Perhaps can have JSQVoiceMediaItem like WeChat 's voice. ☺

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Ability to build a $ with additional properties

For example:
import { build$, CommandBuilder, RequestBuilder } from "https://deno.land/x/dax/mod.ts";

const commandBuilder = new CommandBuilder()
  .cwd("./subDir")
  .env("HTTPS_PROXY", "some_value");
const requestBuilder = new RequestBuilder()
  .header("SOME_NAME", "some value");

const $ = build$({
  commandBuilder,
  requestBuilder,
  // this part is new
  extras: {
    sayHi() {
      console.log("Hi!");
    },
  },
});

$.sayHi(); // outputs "Hi!"

const new$ = $.build$({
  // this part is new
  extras: {
    sayBye() {
      console.log("Bye!");
    },
  },
});

new$.sayHi(); // outputs "Hi!"
new$.sayBye(); // outputs "Bye!"

If this API is added, many of the use-cases I would have for functions to add via the extras (helpers? plugins? worth bikeshedding over the name? :smile: ) object would want to have access to the constructed instance of $ in the function, i.e.:
const $ = build$({
  extras: {
    ghReleaseInfo(org, repo) {
      return $.request(`https://api.github.com/repos/${org}/${repo}/releases/latest`).json()
    },
  },
});

That should work with this "add extras during $ construction" API right? I'm pretty sure it will, but just wanted to put it on the radar for this enhancement request.

@andrewbrey yeah, you can just do what you showed there. I added a test for it in the PR too.


re-pin libdeflate to 1.17

update pin for libdeflate to 1.17

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:37: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:80: http_url: http://www.simplesystems.org/libtiff/ is not https
WARNING: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:80: documentation_overspecified: Using doc_url and doc_source_url is overspecified
WARNING: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:80: license_file_overspecified: Using license_file and license_url is overspecified.
ERROR: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:80: http_url: http://www.simplesystems.org/libtiff/project/license.html is not https
ERROR: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:81: http_url: http://www.simplesystems.org/libtiff/project/license.html is not https
ERROR: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:81: http_url: http://www.simplesystems.org/libtiff/ is not https
WARNING: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:81: license_file_overspecified: Using license_file and license_url is overspecified.
WARNING: /tmp/abs_89i37ne7qh/clone/recipe/meta.yaml:81: documentation_overspecified: Using doc_url and doc_source_url is overspecified
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7f63l__ren/clone/recipe/meta.yaml:37: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_7f63l__ren/clone/recipe/meta.yaml:78: http_url: http://www.simplesystems.org/libtiff/ is not https
ERROR: /tmp/abs_7f63l__ren/clone/recipe/meta.yaml:79: http_url: http://www.simplesystems.org/libtiff/ is not https
Errors were found


The sunrise/sunset icons are very small and the LVĢMC weather icons don't line up with the sunrise and sunset

an option could be to set the background behind the hours to yellow or blue depending on if it's day or night

I could just fix the hourly forecast icons, and add an extra entry within the hourly forecast to note the sunrise and sunset


Streamer merge

Summary
In this RP, we

Merged the old and new streamer together.  NEEDS TO BE FINALIZED ASAP
add a new streamer based on the xdmaReader and xdmaWriter, with channel-mask and byte-mask flag
modify parameters format in cfg files and the snax-gen.py
add csr address map header file gen for streamer with the csr address mapping changed
relevant software test modification related to the new streamer csr map
relevant ci test modification (streamer header file generation before sw build)

Specifically, what are the major changes in the flow?
Architecturally

Architecturally, nothing changes. But according to @xiaoling-yi and @IveanEx the implementation changed.

There was just an added feature where channel and byte masking flag can be used.

Later in the CSR addressing, there are now two registers for the base pointer. The upper and lower registers.

CSR addressing

The biggest change is that the streamer addresses are automatically generated in a header file.

That means whenever a new streamer configuration is set, the header file for the addresses become generated.
Below is an example from the ALU:

// CSR Map for READER_0
#define BASE_PTR_READER_0_LOW 960
#define BASE_PTR_READER_0_HIGH 961
#define S_STRIDE_READER_0_0 962
#define T_BOUND_READER_0_0 963
#define T_STRIDE_READER_0_0 964
// CSR Map for READER_1
#define BASE_PTR_READER_1_LOW 965
#define BASE_PTR_READER_1_HIGH 966
#define S_STRIDE_READER_1_0 967
#define T_BOUND_READER_1_0 968
#define T_STRIDE_READER_1_0 969
// CSR Map for WRITER_0
#define BASE_PTR_WRITER_0_LOW 970
#define BASE_PTR_WRITER_0_HIGH 971
#define S_STRIDE_WRITER_0_0 972
#define T_BOUND_WRITER_0_0 973
#define T_STRIDE_WRITER_0_0 974
// Other resgiters
// Status register
#define STREAMER_START_CSR 975
// Read only CSRs
#define STREAMER_BUSY_CSR 976
#define STREAMER_PERFORMANCE_COUNTER_CSR 977

Streamer CSR Header Files

Note that the address changed compared to the one we currently have. This time, all registers related to a streamer are arranged consecutively. (e.g., base pointer low, base pointer high, spatial stride, temporally bound, temporal stride)

So this is a major change in the addressing scheme
Because of this, the libraries for the specific architecture and application need to ensure that the header files are generated. That means, every time we generate a new RTL (e.g., make rtl-gen) the header files need to be automatically generated.
To avoid being error-prone, several modifications to the Makefiles were made. Particularly, adding switchers for the configurations.

Changes in Configuration format

Of course, this requires new modifications to the streamer configuration. This time it's much more simplified and redundant information from the current implementation is taken away.

For example, last time you have to MANUALLY specify the number of TCDM ports and ensure that it coincides with the FIFO widths and so on. This time it's automatically calculated.
This is a benefit of simplifying the configuration file.
Of course, modifications to snaxgen too to accommodate the changes in configuration as well.

Here's a more concrete example, before the ALU example has a configuration for streamers built like this:

 snax_alu_streamer_template :{

        temporal_addrgen_unit_params: {
            loop_dim: [1],
            share_temp_addr_gen_loop_bounds: true,
        }

        fifo_reader_params: {
            fifo_width: [256, 256],
            fifo_depth: [8, 8],
        }

        fifo_writer_params: {
            fifo_width: [256],
            fifo_depth: [8],
        }

        data_reader_params:{
            tcdm_ports_num: [4, 4],
            spatial_bounds: [[4], [4]],
            spatial_dim: [1,1],
            element_width: [64,64],
        }

        data_writer_params:{
            tcdm_ports_num: [4],
            spatial_bounds: [[4]],
            spatial_dim: [1],
            element_width: [64],
        }

        stationarity: [0,0,0]
    }

In this PR it is now like this:

snax_alu_streamer_template :{

        data_reader_params: {
            spatial_bounds: [[4], [4]],
            temporal_dim: [1, 1],
            num_channel: [4, 4],
            fifo_depth: [8, 8],
        },

        data_writer_params:{
            spatial_bounds: [[4]],
            temporal_dim: [1],
            num_channel: [4],
            fifo_depth: [8],
        },

        snax_library_name: "snax-alu",
    }

So what made it difficult?

The biggest difficult change was only from setting up of the software.
Hardware wise was less of an effort, but due to the CSR addressing scheme and relying on the generated header file took long to adjust things.
The "software" change was a really necessary hence the very large commits and changes.

@IveanEx and @xiaoling-yi lemme fix @xiaoling-yi's request first haha hold on. Don't touch plez haaha

On 2nd thought I'll make PRs on top of this!

Everything should pass... I'll have to talk to mace for the DIMC as we need to change what he's using. And it will change how he places things aklsdjaklsdjalksdjaskldjaskldj
This PR is insanely tiring 😢

Wait don't push yet haha

It's so weird but why is the DIMC being checked but I cannot find its configuration file. Also it isn't part of the CI...

@xiaoling-yi and @IveanEx this branch is not rebased from the main, I fear it might be missing things even though the squash and merge says it's not conflicting things.
I cannot understand why the CI for the SNAX-DIMC is being checked even though it's not in this PR...
@IveanEx, could you rebase from the main and ensure things are not broken? I tried to rebase but I fear I might break whatever you guys built. I think it's better you do it since you know what changed. @xiaoling-yi is currently unavailable today. Thanks!

I can do the rebase!

I can do the rebase!

You sure? I mean if you're busy today let @IveanEx do it. But make sure only one of you does so none conflicts.
Sorry, to ask, I tried it myself but I couldn't tell which change you used. Even though I check the commit logs and stuff.

There are a lot of modifications and conflicts I made so it's safest that I do the rebase.

OK thanks! I hope it isn't too much huhu

I'll fix the SNAX-DIMC wait

Last commits should fix the DIMC. If there are no complaints by sometime after lunch, I guess feel free to push?
@IveanEx and @xiaoling-yi. Just triple check if there are some unnecessary comments or typos around 🛩

Wait I just realized maybe the module name override need to be modified, I forgot before

@IveanEx ok!

Ok, thanks! @rgantonio @IveanEx

This PR broke the docker builds, they have all been failing since this was merged. Can somebody look at this please?

@jorendumoulin on it! Wait


Add Dark Mode Toggle Switch

These could serve as inspiration: https://alvarotrigo.com/blog/toggle-switch-css/


fix: do not register a ts-node if an env. variable with ts_node_dev is set

Signed-off-by: Hasan Oezdemir<EMAIL_ADDRESS>
Description
Fixes an issues caused indirectly by generator library which re-register the ts-node if ts-node called by ts-node-dev.
Related issue(s)
See: https://github.com/asyncapi/generator/issues/759

/rtm


issue loading hcpcsevents with postgresql

I am getting this issue running load_gz.sql:
psql:load_gz.sql:58: ERROR:  invalid input syntax for type timestamp: "99219"
CONTEXT:  COPY hcpcsevents, line 2, column chartdate: "99219"

I think the issue might be that the script for building the hcpcsevents table seems to expect a timestamp column: https://github.com/MIT-LCP/mimic-iv/blob/da0339348c283835dd01788f6c17d1fceb99c88e/buildmimic/postgres/create.sql#L183 but the data (mimic-iv-0.4) only has these columns:
subject_id,hadm_id,hcpcs_cd,seq_num,short_description
psql version is 13.2 if relevant

Hi @corcra please update to the latest version of MIMIC-IV (v1.0): https://physionet.org/content/mimiciv/1.0/

It looks like the error is a result of hcpcs_cd being inserted into the chartdate column (see change below between 0.4 and 1.0):

If only we had a metadata file which we could check against ... wouldn't that just be swell @tompollard ? :)

I *almost* opened the PR a few days ago...will get onto it!

Using the correct version of MIMIC has solved my problem, thanks!


[FEATURE REQUEST] Add list subcommand for virtctl

Hi, guys.
when I try to operate a VMI, I need to use kubectl get vmi to get VMI's Name, It might be convenient if we add list VM subcommand for virtctl.

/kind enhancement

@DanielQujun did you have a look at the krew plugin for virtctl https://github.com/kubevirt/kubectl-virt-plugin?
After you install virtctl with it you can basically do this:
kubectl get vmi myvm
kubectl virt console myvm

Would that already be a good enough improvement for you?

yes, I'll check it.


Fix manual build of cluster images

This allows building the user image for a given cluster. Before the deploy script refactor, we could build the images for all the cluster.
Because the deploy can only happen now on a per-cluster basis, I though that the build should follow the same pattern.
@yuvipanda, what do you think? Build the image per cluster, or re-implement the old parse_clusters function and build for all clusters at once?

Yeah, this makes sense. Can you make cluster_name a required commandlien argument as well, and pass it to build?

Can you make cluster_name a required commandlien argument as well, and pass it to build?

Ups :facepalm: This is done now. Thanks @yuvipanda!


move lists of yq commands from project.Makefile target into a separate files

sorry, you can ignore commits to project/


Created a new file free-courses-te.md

After figuring out that no file enables the coders to learn to code in the Telugu language using available free resources to solve issue #7899, I created and included all the free and best courses. So please check this PR!!
What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
This file helps the students to learn coding and programming languages in the Telugu language using free resources already available.
Why is this valuable (or not)?
This helps out numerous students and learners who wish to learn essential programming languages in their mother tongue.
How do we know it's really free?
These courses are provided by the Telugu Computer World Non-profitable organization for the welfare of the student community.
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

please collaborate with #7818

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes
no shortened links.
list resources, not searches


context-configured GET requests and serialization config

This is a draft of functionality I added to make PersistedQueriesLink work in graphql_flutter v4:

Adds a HttpLinkMethod for context-based GET requests
Adds a RequestSerializationInclusions for configuring serialization

I'm pretty unsure about both APIs, but essentially PersistedQueriesLink wants to set GET in context and have a way to set includeQuery: false.

Please how do I enable persisted queries ?
There's no PersistedQueriesLink in the   graphql_flutter: ^5.0.1-beta.1.
This is a must feature for my project. How do I use it


insert document with Float32Array inside

Hello!
I have a document , one of its properties is Float32Array.
ex document before insert:
{
    name: 'Test',
    data: Float32Array [ 0.00045, -0.122, ... ]
}

After insert:
{
    name: 'Test',
    data: {
        "0": 0.00045,
        "1": -0.122,
        ...
    }
}

Is there are any way to keep the array as [0.00045, -0.122, ...] and not converting it to object with  numeric properties?
Thank you and best regards!

NeDB does not know what "Float32Array" is, which is why you're getting an error. And arrays can't be assigned that way. Basically, what you want is something like this (as a solution):
{
    name: 'Test',
    data: { Float32Array: [ 0.00045, -0.122, ... ] }
}

Data is now pointing to an object, where its first key ("Float32Array") points to an array. So then you can retrieve one of the array-values like this: data.Float32Array[ 0 ] // This would return 0.00045 and so on.


Website is not being deployed

Fix the workflow so that the website is deployed on push on master.
The issue most certainly is that the docs job depends on generate_reports, and does not run on push event.
Either remove the dependency, or make sure reports are re-generated on push on master.

@prudhomm I have two solutions in mind:

Add the condition if: github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref_name == 'master') to the generate_reports job. But it can be a bug source for unreviewed reports being deployed.
Use a workaround for conditional "needs", ensuring docs are always deployed when on master, by adding

  docs:
    runs-on: self-ubuntu-22.04
    name: Build Antora Site
    needs: generate_reports
    if: always()
    steps:
         - name: exit if 'docs skip' on commit message
            run: exit 1 ...
         - name: Deploy:
            if: ${{ github.ref_name == 'master' }}
            ...

What do you think?

@JavierCladellas I vote for the second case since


Return the correct timestamp for the right-hand table of the ASOF join

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog.
Return the correct timestamp for the right-hand table of the ASOF join
Category

Bug Fix

Short description (up to few sentences):
Previously it would copy the timestamp from the left hand side, whereas the right hand side might have had a different timestamp. This patch fixes that.

Thanks, will patch those up. Do you have any better way of checking the code style other than the included scripts in utils/check-style that would actually catch these issues (they, and by extension your CI system does not report these style issues)? Also, when I actually run the clang-format tool with the included .clang-format file it catches many other things too hence would mess up history so I'm a bit wary of doing that and prefer to stick with the pre-written format scripts that already include/exclude whatever stuff clang-format does that you care about.

Thanks, will patch those up. Do you have any better way of checking the code style other than the included scripts in utils/check-style that would actually catch these issues (they, and by extension your CI system does not report these style issues)?

We have style checker but it is not ideal yet. Maybe one day it could catch all the style mistakes.


Register medoomem.localplayer.dev

Added medoomem.localplayer.dev using the CLI.

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

Closed for prolonged inactivity/lack of response.