Always ignore _ fields

The _ field in Go is special in that it cannot be read from or written to.
Thus, skip it by default. It is pointless to require the user to use
cmpopts.IgnoreUnexported just for the _ field.

It's useful when dealing with unsafe and you want to explicitly control the memory layout of the struct.
For example:
type Foo struct {
     _ uint64
     v uint64 // lives at offset +8B
}

Neat.
I didn't know that _ field will take up space of given type (unless 0).
Good to know of another way to make a struct incomparable apart from embedding a func type.


Memory leaks

Hi,
I am looking at the current memory leaks in the client lib. I am using the http_client example and sending requests each 10 ms continuously. The memory increases pretty fast...
I think I've tracked down the major mem leak, but I would like an advice if it's the correct solution. What I did is add the destructor to CoreT class (in async.h):
~CoreT() {
    if (state == State::Fulfilled) {
        reinterpret_cast<T*>(&storage)->~T();
    }
}

The issue was that there was done a placement new on the Storage, but the destructor was never called.
From what I can tell this works fine. But there client is still leaking memory. Not as bad as it was before, but still leaking a bit.
If anyone has any ideas it would be greatly appreciated.
Thanks!

Did you use valgrind (or Dr. Memory on windows) to determine leaks?
It could help to identify exactly where are leaks though it impacts performance significantly

Here's a valgrind report (git rev b66415a, run on Ubuntu 16.04)
==9646==
==9646== HEAP SUMMARY:
==9646==     in use at exit: 73,320 bytes in 11 blocks
==9646==   total heap usage: 325 allocs, 314 frees, 141,558 bytes allocated
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 1 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B924: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 2 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B924: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 3 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44F460: Pistache::Tcp::Transport::handleNewPeer(std::shared_ptr<Pistache::Tcp::Peer> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x45542B: Pistache::Tcp::Listener::dispatchPeer(std::shared_ptr<Pistache::Tcp::Peer> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x45597B: Pistache::Tcp::Listener::handleNewConnection() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x455B4F: Pistache::Tcp::Listener::run() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x510FC7F: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21)
==9646==    by 0x4E416B9: start_thread (pthread_create.c:333)
==9646==    by 0x59FF3DC: clone (clone.S:109)
==9646==
==9646== 64 bytes in 1 blocks are definitely lost in loss record 4 of 9
==9646==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x59E3366: gaih_inet (getaddrinfo.c:1223)
==9646==    by 0x59E6D2D: getaddrinfo (getaddrinfo.c:2425)
==9646==    by 0x455ECD: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 64 bytes in 1 blocks are definitely lost in loss record 5 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B895: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 96 bytes in 1 blocks are definitely lost in loss record 6 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B82A: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 128 bytes in 2 blocks are definitely lost in loss record 7 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B895: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 192 bytes in 2 blocks are definitely lost in loss record 8 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B82A: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/media-server/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== LEAK SUMMARY:
==9646==    definitely lost: 616 bytes in 10 blocks
==9646==    indirectly lost: 0 bytes in 0 blocks
==9646==      possibly lost: 0 bytes in 0 blocks
==9646==    still reachable: 72,704 bytes in 1 blocks
==9646==         suppressed: 0 bytes in 0 blocks
==9646== Reachable blocks (those to which a pointer was found) are not shown.
==9646== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==9646==
==9646== For counts of detected and suppressed errors, rerun with: -v
==9646== ERROR SUMMARY: 8 errors from 8 contexts (suppressed: 0 from 0)

Here's a valgrind report from Ubuntu 16.04, git rev b66415a
==9646==
==9646== HEAP SUMMARY:
==9646==     in use at exit: 73,320 bytes in 11 blocks
==9646==   total heap usage: 325 allocs, 314 frees, 141,558 bytes allocated
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 1 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B924: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 2 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B924: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 24 bytes in 1 blocks are definitely lost in loss record 3 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44F460: Pistache::Tcp::Transport::handleNewPeer(std::shared_ptr<Pistache::Tcp::Peer> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x45542B: Pistache::Tcp::Listener::dispatchPeer(std::shared_ptr<Pistache::Tcp::Peer> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x45597B: Pistache::Tcp::Listener::handleNewConnection() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x455B4F: Pistache::Tcp::Listener::run() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x510FC7F: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21)
==9646==    by 0x4E416B9: start_thread (pthread_create.c:333)
==9646==    by 0x59FF3DC: clone (clone.S:109)
==9646==
==9646== 64 bytes in 1 blocks are definitely lost in loss record 4 of 9
==9646==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x59E3366: gaih_inet (getaddrinfo.c:1223)
==9646==    by 0x59E6D2D: getaddrinfo (getaddrinfo.c:2425)
==9646==    by 0x455ECD: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 64 bytes in 1 blocks are definitely lost in loss record 5 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B895: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 96 bytes in 1 blocks are definitely lost in loss record 6 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B82A: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x455F70: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 128 bytes in 2 blocks are definitely lost in loss record 7 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B895: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== 192 bytes in 2 blocks are definitely lost in loss record 8 of 9
==9646==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==9646==    by 0x44B82A: Pistache::Tcp::Transport::Transport(std::shared_ptr<Pistache::Tcp::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x44BB35: Pistache::Tcp::Transport::clone() const (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x467389: Pistache::Aio::AsyncImpl::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&, bool) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x465C19: Pistache::Aio::Reactor::addHandler(std::shared_ptr<Pistache::Aio::Handler> const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x45601D: Pistache::Tcp::Listener::bind(Pistache::Address const&) (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x453FAC: Pistache::Http::Endpoint::serveThreaded() (in /media/sf_unpause/source/build/unpause)
==9646==    by 0x427457: unpause::HttpServer::serve() (HttpServer.cpp:48)
==9646==    by 0x429958: main (unpause.cpp:115)
==9646==
==9646== LEAK SUMMARY:
==9646==    definitely lost: 616 bytes in 10 blocks
==9646==    indirectly lost: 0 bytes in 0 blocks
==9646==      possibly lost: 0 bytes in 0 blocks
==9646==    still reachable: 72,704 bytes in 1 blocks
==9646==         suppressed: 0 bytes in 0 blocks
==9646== Reachable blocks (those to which a pointer was found) are not shown.
==9646== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==9646==
==9646== For counts of detected and suppressed errors, rerun with: -v
==9646== ERROR SUMMARY: 8 errors from 8 contexts (suppressed: 0 from 0)

Alright I have some time today I think I will go through and fix these and make a PR.

Created PR #130

Hi, Thanks for your PR, I applied this to current version of pistache and I still see this memory leak with graceful shutdown of the server which users serveThreaded(). Are you using server() instead of serverThreaded(). Any ideas are welcome. Thanks

@sandakith it's been a while since I looked at this but IIRC I wasn't seeing the same memory leak that was reported in this issue, I was seeing different memory leaks that I posted in the valgrind report.

Thanks for the quick response and clarifications.
I confirm that I am seeing the memory leaks you posted on this thread on Aug 13, 2017.

We're tracking memory leak remediation in bug #399.  The long-term goal is to require all unit tests to pass AND not leak memory, descriptors or have invalid memory access problems (this includes the http client).  I'm going to close this bug to reduce the open bug count.


Refactor the readers to have a single reader class

The strategy for choosing the next leaf to read is now dictated by a
function. This allows much of the logic to be simplified and the getLeaf
function can now become an method of the reader, which avoids needing to
pass in as many parameters.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.26%. Comparing base (07aa77d) to head (70b97fb).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   55.99%   60.26%   +4.26%
==========================================
  Files           8        8
  Lines         759      609     -150
==========================================
- Hits          425      367      -58
+ Misses        265      173      -92
  Partials       69       69

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[SourceKit] Fix a build failure if SWIFT_BUILD_SWIFT_SYNTAX is not set

Fixes https://github.com/apple/swift/pull/70269#issuecomment-1844778242

Yep, this works.


[WIP] feat: secondary navigation for datasets

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #9981 into master will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9981      +/-   ##
==========================================
- Coverage   71.38%   71.18%   -0.21%
==========================================
  Files         585      184     -401
  Lines       30949    18041   -12908
  Branches     3261        0    -3261
==========================================
- Hits        22094    12842    -9252
+ Misses       8746     5199    -3547
+ Partials      109        0     -109

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
71.18% <ø> (-0.40%)
:arrow_down:

Impacted Files
Coverage Δ

superset/views/database/mixins.py
59.64% <0.00%> (-21.06%)
:arrow_down:

superset/utils/cache.py
48.00% <0.00%> (-20.00%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.26% <0.00%> (-13.05%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

superset/views/tags.py
35.13% <0.00%> (-4.11%)
:arrow_down:

superset/views/database/api.py
84.09% <0.00%> (-3.41%)
:arrow_down:

superset/views/sql_lab.py
59.06% <0.00%> (-3.29%)
:arrow_down:

superset/cli.py
36.72% <0.00%> (-3.14%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.29% <0.00%> (-2.71%)
:arrow_down:

superset/views/database/views.py
87.17% <0.00%> (-2.57%)
:arrow_down:

... and 417 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcac860...256068c. Read the comment docs.


extra blank lines in buildkite log output

using the plugin to retrieve secrets with json key:
    plugins:
      - seek-oss/aws-sm#v2.3.2:
          json-to-env:
            - json-key: .
              secret-id: prod/AppBeta/Mysql
            - json-key: .
              secret-id: prod/AppBeta/Redpanda

the buildkite log has 2 extra blank lines per secret:
  | 2024-07-02 00:46:37 CDT | 🔑 Reading secrets from AWS SM
  | 2024-07-02 00:46:37 CDT | Reading all environment variables from prod/AppBeta/Mysql in AWS SM
  | 2024-07-02 00:46:37 CDT |
  | 2024-07-02 00:46:37 CDT |
  | 2024-07-02 00:46:37 CDT | Setting environment variable MYSQL_DSN
  | 2024-07-02 00:46:37 CDT | Reading all environment variables from prod/AppBeta/Redpanda in AWS SM
  | 2024-07-02 00:46:37 CDT |
  | 2024-07-02 00:46:38 CDT |
  | 2024-07-02 00:46:38 CDT | Setting environment variable REDPANDA_USER
  | 2024-07-02 00:46:38 CDT | Setting environment variable REDPANDA_PASSWORD

removing the blank lines would make it easier for human eyes to associate aws sm secret name with env var name

PRs welcome!


Create test for plant_sizing_estimation.py

Create a test for plant_sizing_estimation.py

plant_sizing_estimation.py is functionality in GreenHEART that does not have a test.
Proposed solution
Recommend creating a test so functionality can be validated and breaking changes can be tracked.

Alternatives considered

Additional context

@kbrunik Should this issue be transferred to the GreenHEART repo?


[BUG] Can't recompile app. "Could not smali file"

Information

Apktool Version (apktool -version) - 2.6.0
Operating System (Mac, Linux, Windows) - Linux
APK From? (Playstore, ROM, Other) - https://appmaker.greatfire.org/

Error Message
$ apktool d de.fefe.blog.apk
I: Using Apktool 2.6.0 on de.fefe.blog.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/user/.local/share/apktool/framework/1.apk
I: Renamed manifest package found! Replacing de.fefe.blog with org.greatfire.freebrowser
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Baksmaling assets.dex...
I: Baksmaling classes2.dex...
I: Baksmaling assets/webapk7.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
[user@spreewald fefe_app]$ apktool b de.fefe.blog
de.fefe.blog/         de.fefe.blog.apk      de.fefe.blog.apk.zip
[user@spreewald fefe_app]$ apktool b de.fefe.blog
de.fefe.blog/         de.fefe.blog.apk      de.fefe.blog.apk.zip
[user@spreewald fefe_app]$ apktool b de.fefe.blog/
I: Using Apktool 2.6.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether sources has changed...
I: Smaling smali_classes2 folder into classes2.dex...
I: Checking whether sources has changed...
I: Smaling smali_assets folder into assets.dex...
de.fefe.blog/smali_assets/webapk7/androidx/core/graphics/drawable/IconCompatParcelizer.smali[499,9] Class Landroidx/core/graphics/drawable/IconCompatParcelizer; has already been interned
Could not smali file: webapk7/androidx/core/graphics/drawable/IconCompatParcelizer.smali

Steps to Reproduce

apktool d
apktool b

APK
https://www.file-upload.net/download-14878350/de.fefe.blog.apk.html
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? yes
If you are trying to install a modified apk, did you resign it? yes
Are you using the latest apktool version? yes

You can use --only-main-classes during disassemble as the extra smali packages in /assets are attempting to be disassmbled.
After that, you'll hit two known issues

https://github.com/iBotPeaches/Apktool/issues/2514
https://github.com/iBotPeaches/Apktool/issues/2740

Yep as I mentioned there are other issues you'll encounter and I believe they are related to the two issues I linked.


docker image broken after 0.4.0 upgrade?

Hi,
It seems the docker build does not work anymore, or at least I only see the following:
letschat_1 |
letschat_1 | ><EMAIL_ADDRESS>prestart /usr/src/app
letschat_1 | > migroose
letschat_1 |
I removed all images, containers and even the git clone and cloned a new one but I get the same behaviour.
Also, I see the options in the default.yml where we can enable passworded rooms but is there some documentation of how this has to be set and should it be set in the settings.yml ?
Cheers,
Michiel

What happens if you restart the Docker container? I'll take a look into soon too.
Also, we'll update the docs with all the new settings.

A restart after git pull seem to work but I wanted to build a clean new
image and container and restore the mongo backup.
Op 4 jun. 2015 23:14 schreef "Simon Bartlett"<EMAIL_ADDRESS>
What happens if you restart the Docker container? I'll take a look into
soon too.
Also, we'll update the docs with all the new settings.
—
Reply to this email directly or view it on GitHub
https://github.com/sdelements/lets-chat/issues/478#issuecomment-109053955
.

I'm experiencing the same issue with lets-chat in docker
lets-chat$ docker run -p 5000:5000 --link db:db lets-chat
><EMAIL_ADDRESS>prestart /usr/src/app
> migroose

I've tried restarting the container as well as removing it.and rebuilding.  Nothing seems to unjam the issue.

This should now be fixed, please pull the latest code and try again.
Seems to have been caused by a bug in the migroose library.

It works!
Stupid question: how do I enable the passworded rooms feature (is it an on/off switch or is it choosable when creating a new room?).
And the same for the 1:1 chat?
I do see it available in the default.ml, should I overwrite it in the settings.yml?
Michiel

On 05 Jun 2015, at 07:36, Simon Bartlett<EMAIL_ADDRESS>wrote:
This should now be fixed, please pull the latest code and try again.
Seems to have been caused by a bug in the migroose library.
—
Reply to this email directly or view it on GitHub https://github.com/sdelements/lets-chat/issues/478#issuecomment-109168609.

Ok, added it to the settings.yml and it works for passworded rooms nice :+1:

Will close the issue.


nn.ZeroPad2d 行为与 pytorch 不一致

问题
nn.ZeroPad2d 行为与 pytorch 不一致
报错
loaded library: /lib/x86_64-linux-gnu/libibverbs.so.1
torch.Size([2, 10, 1, 64, 58, 58])
Traceback (most recent call last):
  File "/home/ubuntu/work/oneflow/vision/flowvision/models/ttest.py", line 16, in <module>
    fOut = fPad(flowTensor)
  File "/home/ubuntu/miniconda3/envs/flow/lib/python3.8/site-packages/oneflow/nn/module.py", line 115, in __call__
    res = self.forward(*args, **kwargs)
  File "/home/ubuntu/miniconda3/envs/flow/lib/python3.8/site-packages/oneflow/nn/modules/padding.py", line 414, in forward
    return flow._C.pad(x, pad=self.padding, mode="constant", value=self.value)
RuntimeError:
  File "/home/ci-user/runners/release/_work/oneflow/oneflow/oneflow/core/functional/impl/nn_functor.cpp", line 1858, in operator()
    Check failed: (ndim) <= (5) (6 vs 5) Dimension of input tensor should less than or equal to 5

最小复现
import torch
import torch.nn as tnn
import oneflow as flow
import oneflow.nn as fnn
import numpy as np

inp = np.random.randn(2, 10, 1, 64, 56, 56).astype(np.float32)

torchTensor = torch.from_numpy(inp)
tPad = tnn.ZeroPad2d(1)
tOut = tPad(torchTensor)
print(tOut.shape)

flowTensor = flow.from_numpy(inp)
fPad = fnn.ZeroPad2d(1)
fOut = fPad(flowTensor)
print(fOut.shape)

这个问题是因为functor内部错误地check了input的dim，这个pr修复了此问题：https://github.com/Oneflow-Inc/oneflow/pull/8354


mWeb Safari - There is no date picker icon and month and year cant be edited individually - reported by @thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

In Safari browser on mobile, go to new.expensify.com
Navigate to Settings >Workspace >Add bank account
Proceed through VBA flow to Company info page
Try to click on icon to open date picker
Try to edit day and year individually

Expected Result:
There should be an icon to trigger date picker modal  and month and year should be editable individually
Actual Result:
There is no icon to open date picker modal and we can't edit month and year individually using mouse as it forces back to the day field. Also after adding the day it doesn't go to the month field ( all these functions are working on other platforms but not for safari )
Workaround:
unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/148494965-2694f0f6-6c5d-4480-8684-b3bf9990989c.mov
https://user-images.githubusercontent.com/43995119/148494968-f7cfc45c-2e00-49fe-a383-9ef45a01b854.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640964529344700
View all open jobs on GitHub

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

So, is this only broken in safari? Seems chrome is working properly?

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Updated Action Steps to specify Safari on mobile web.
Upwork job here: https://www.upwork.com/jobs/~013b9fad465b315995

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@stephanieelliott, the issue is for safari (mac). Can you please change the platform to this.

Thanks @thesahindia, updated!
As the reporter of this issue, you have first dibs on fixing it @thesahindia! Please post your proposal here if you have one. After 3 days, we'll open this up to other proposals.

Hey @thesahindia! Just a reminder that you have 3 days to submit a proposal before we open this job up to other contributors. If you'd like to submit a proposal, please do so within the next day!

@stephanieelliott, yes you can open this for other contributors.

Doubled price to $500: https://www.upwork.com/jobs/~01edb430d0041775c7

Strange. But I wonder what is the real expectations here.

Show an icon on the right.
And make it possible to edit each segment of data separately.

From the videos, it seems that it is not Safar Mweb rather Safari web.

From the videos, it seems that it is not Safar Mweb rather Safari web.

I thought so but there too I don't get the slashes in input (automatically) and format is also "YYYY-MM-DD" in placeholder.

Maybe it is recently changed. We may have to redefine the scope now. @puneetlath Could you please help? I am not sure what should be done here now. The only remaining item that I see is to add the icon to the date-picker. But $500 sound like much for that.

Ok just to step back, I want to make sure I understand the issue. Is this right?

This only affects safari on mobile (not desktop)
The only issue is that the date picker icon is not showing in the input box

Is that a correct understanding of the issue?

Ok got it. So is this the correct understanding:

This only happens on Safari desktop
The first issue is the missing date picker icon
The second issue is the inability to edit the three sections of the date individually via keyboard without using the date picker

Is that right?

@puneetlath, yep

Ok. I looked at the code and found out that we use native <input type="date">.
Which means:

format of value can be different , it depends on the OS, platform.
Icon is also part of browser spec.

We still don't have any proposals for this, and following process the price will soon double again to $1,000.
Based on the discussion, sounds like maybe the issue body and repro steps is unclear. Should we create a new, more descriptive issue? Or continue raising the bounty on this? @puneetlath what do you think?

Hm, this one has gotten a bit confusing. Maybe easiest to just start afresh.

Yeah, I agree @puneetlath! I'll test and create a new issue, will link it and close this once I am done.

@stephanieelliott bump.

Created a new issue for this, added you as the triager @puneetlath. You mind taking a look see if this new issue is a bit more clear, given the discussion? Once it is good to go I'll apply the relevant labels https://github.com/Expensify/App/issues/7637


No internet in Docker container after upgrade with Traefik router

Is there an existing issue for this?

[X] I have searched the existing issues

Output of ddev debug test
Expand `ddev debug test` diagnostic information
Running bash [-c /tmp/test_ddev.sh]
======= Existing project config =========
These config files were loaded for project stad: [/home/sven/projects/drupal_site_stadgent/.ddev/config.yaml]
name: stad
type: drupal9
docroot: web
php_version: 8.1
webserver_type: nginx-fpm
webimage: ddev/ddev-webserver:v1.22.0
router_http_port: 8080
router_https_port: 8443
additional_hostnames: []
additional_fqdns: [local.stad.gent]
database: {mysql 5.7}
performance_mode: mutagen
hooks: map[pre-start:[map[exec-host:sudo apachectl stop]]]
mailhog_port: 8025
mailhog_https_port: 8026
webimage_extra_packages: [php8.1-gmp php-imagick webp]
project_tld: ddev.site
composer_version: 2
nodejs_version: 18
default_container_timeout: 120
======= Creating dummy project named  tryddevproject-25033 in ../tryddevproject-25033 =========
OS Information: Linux CP107281 <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Jul 12 00:26:42 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
User information: uid=1000(sven) gid=1000(sven) groups=1000(sven),4(adm),20(dialout),24(cdrom),25(floppy),27(sudo),29(audio),30(dip),44(video),46(plugdev),116(netdev),999(docker)
DDEV version:  ITEM             VALUE
 DDEV version     v1.22.0
 architecture     amd64
 db               ddev/ddev-dbserver-mariadb-10.4:v1.22.0
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.22.0
 docker           24.0.5
 docker-compose   v2.20.0
 docker-platform  wsl2-docker-ce
 mutagen          0.17.2
 os               linux
 router           traefik:v2.10
 web              ddev/ddev-webserver:v1.22.0
PROXY settings: HTTP_PROXY='' HTTPS_PROXY='' http_proxy='' NO_PROXY=''
======= DDEV global info =========
Global configuration:
instrumentation-opt-in=true
omit-containers=[]
performance-mode=none
router-bind-all-interfaces=false
internet-detection-timeout-ms=3000
disable-http2=false
use-letsencrypt=false
letsencrypt-email=
table-style=default
simple-formatting=false
auto-restart-containers=false
use-hardened-images=false
fail-on-hook-fail=false
required-docker-compose-version=v2.20.0
use-docker-compose-from-path=false
project-tld=
xdebug-ide-location=
no-bind-mounts=false
router=traefik
wsl2-no-windows-hosts-mgt=false
router-http-port=80
router-https-port=443

======= DOCKER info =========
docker location: -rwxr-xr-x 1 root root 35927416 Jul 21 22:35 /usr/bin/docker
docker version:
Client: Docker Engine - Community
 Version:           24.0.5
 API version:       1.43
 Go version:        go1.20.6
 Git commit:        ced0996
 Built:             Fri Jul 21 20:35:18 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.5
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.6
  Git commit:       a61e2b4
  Built:            Fri Jul 21 20:35:18 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.21
  GitCommit:        3dce8eb055cbb6872793272b4f20ed16117344f8
 runc:
  Version:          1.1.7
  GitCommit:        v1.1.7-0-g860f061
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
DOCKER_DEFAULT_PLATFORM=notset
======= Mutagen Info =========
Mutagen is installed in ddev, version=0.17.2
--------------------------------------------------------------------------------
Name: stad
Identifier: sync_NYPDd4JdGfZDVTTNvVYMT8RjLv7yct4nFYHDQaDrWts
Labels:
        com.ddev.config-hash: c212281329fb24762a96e1b7a37a19ed84868866
        com.ddev.volume-signature: var-run-1690879010
Configuration:
        Synchronization mode: Two Way Resolved
        Hashing algorithm: Default (SHA-1)
        Maximum allowed entry count: Default (2⁶⁴−1)
        Maximum staging file size: Default (18 EB)
        Symbolic link mode: POSIX Raw
        Ignore VCS mode: Default (Propagate)
        Ignores:
                /.git
                /.tarballs
                /.ddev/db_snapshots
                /.ddev/.importdb*
                .DS_Store
                .idea
                /web/sites/default/files
        Permissions mode: Default (Portable)
Alpha:
        URL: /home/sven/projects/drupal_site_stadgent
        Configuration:
                Watch mode: Default (Portable)
                Watch polling interval: Default (10 seconds)
                Probe mode: Default (Probe)
                Scan mode: Default (Accelerated)
                Stage mode: Neighboring
                File mode: Default (0600)
                Directory mode: Default (0700)
                Default file/directory owner: Default
                Default file/directory group: Default
        Connected: Yes
        Synchronizable contents:
                17102 directories
                70670 files (492 MB)
                102 symbolic links
Beta:
        URL: docker://ddev-stad-web/var/www/html
                DOCKER_HOST=unix:///var/run/docker.sock
        Configuration:
                Watch mode: Default (Portable)
                Watch polling interval: Default (10 seconds)
                Probe mode: Default (Probe)
                Scan mode: Default (Accelerated)
                Stage mode: Neighboring
                File mode: Default (0600)
                Directory mode: Default (0700)
                Default file/directory owner: Default
                Default file/directory group: Default
                Compression: Default (DEFLATE)
        Connected: Yes
        Synchronizable contents:
                17102 directories
                70670 files (492 MB)
                102 symbolic links
Status: Watching for changes
--------------------------------------------------------------------------------
======= Docker Info =========
Docker platform: wsl2-docker-ce
Using docker context: default (unix:///var/run/docker.sock)
docker-compose: v2.20.0
Using DOCKER_HOST=unix:///var/run/docker.sock
Docker version: 24.0.5
Able to run simple container that mounts a volume.
Docker disk space:
Filesystem                Size      Used Available Use% Mounted on
overlay                1006.9G     22.4G    933.2G   2% /

unable to create project at project root '/home/sven/projects/test': project root /home/sven/projects/test does not exist
unable to create project at project root '/home/sven/projects/tester': project root /home/sven/projects/tester does not exist
 Container ddev-stad-varnish  Stopped
 Container ddev-stad-solr  Stopped
 Container ddev-stad-db  Stopped
 Container ddev-stad-web  Stopped
 Container ddev-stad-solr  Stopped
 Container ddev-stad-db  Stopped
 Container ddev-stad-varnish  Stopped
 Container ddev-stad-solr  Removed
 Container ddev-stad-db  Removed
 Container ddev-stad-varnish  Removed
 Container ddev-stad-web  Stopped
 Container ddev-stad-web  Removed
 Network ddev-stad_default  Removed
Project stad has been stopped.
Stopped mutagen daemon
The ddev-ssh-agent container has been removed. When you start it again you will have to use 'ddev auth ssh' to provide key authentication again.
Existing docker containers:
CONTAINER ID   IMAGE         COMMAND                  CREATED      STATUS                  PORTS     NAMES
34826d0e7994   nginx         "/docker-entrypoint.…"   4 days ago   Exited (0) 4 days ago             naughty_pasteur
e65d7844ff55   nginx         "/docker-entrypoint.…"   4 days ago   Created                           lucid_herschel
b1fbe80d5416   nginx         "/docker-entrypoint.…"   4 days ago   Exited (0) 4 days ago             zen_cohen
4f18907aa670   hello-world   "/hello"                 4 days ago   Exited (0) 4 days ago             laughing_volhard
afef94b967ed   busybox       "nslookup google.com"    6 days ago   Exited (1) 6 days ago             keen_bouman
2767e73cba8e   busybox       "nslookup google.com"    6 days ago   Exited (1) 6 days ago             elastic_brattain
Network ddev_default created
Starting tryddevproject-25033...
 Container ddev-ssh-agent  Created
 Container ddev-ssh-agent  Started
ssh-agent container is running: If you want to add authentication to the ssh-agent container, run 'ddev auth ssh' to enable your keys.
unable to determine WSL2 host.docker.internal because /etc/resolv.conf is not available or not auto-generated
unable to determine WSL2 host.docker.internal because /etc/resolv.conf is not available or not auto-generated
v1.22.0: Pulling from ddev/ddev-dbserver-mariadb-10.4
0fb668748fc8: Already exists
11f65aacc004: Already exists
f3ccf0f0c34f: Already exists
ab42338ab2d0: Already exists
c807600eb677: Already exists
debe5f4c6a9b: Already exists
91a3dfd98bfe: Already exists
522a2cacfb45: Already exists
a31ae496b1e5: Already exists
4f4fb700ef54: Already exists
ec28e4f24a45: Already exists
ee09bc14631b: Already exists
e25ac0367bb3: Already exists
74a6e7288747: Already exists
3d507dd19929: Already exists
17481026acee: Already exists
9d0a0d58a087: Already exists
8d27964fd3b0: Already exists
8772df3cc945: Already exists
ca95039c7315: Already exists
ac484e3d8702: Already exists
5b1edb6d2ecd: Already exists
6c0f9257cdce: Already exists
d7706094646c: Already exists
Digest: sha256:aecfb2180c10c1af0f4503904b44839cd38c8183b69d9428863ddafa14f8b2c1
Status: Downloaded newer image for ddev/ddev-dbserver-mariadb-10.4:v1.22.0
docker.io/ddev/ddev-dbserver-mariadb-10.4:v1.22.0
 Network ddev-tryddevproject-25033_default  Created
 Container ddev-tryddevproject-25033-web  Created
 Container ddev-tryddevproject-25033-db  Created
 Container ddev-tryddevproject-25033-web  Started
 Container ddev-tryddevproject-25033-db  Started
failed to solve: process "/bin/sh -c apk add bash curl htop vim" did not complete successfully: exit code: 4
Failed to start tryddevproject-25033: failed to start ddev-router: ComposeCmd failed to run 'COMPOSE_PROJECT_NAME=ddev-tryddevproject-25033 docker-compose -f /home/sven/.ddev/.router-compose-full.yaml -p ddev-router up --build -
d', action='[-p ddev-router up --build -d]', err='exit status 17', stdout='#1 [ddev-router internal] load build definition from Dockerfile
#1 transferring dockerfile: 206B done
#1 DONE 0.0s

#2 [ddev-router internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [ddev-router internal] load metadata for docker.io/library/traefik:v2.10
#3 DONE 0.0s

#4 [ddev-router 1/4] FROM docker.io/library/traefik:v2.10
#4 CACHED

#5 [ddev-router internal] load build context
#5 transferring context: 1.07kB done
#5 DONE 0.0s

#6 [ddev-router 2/4] RUN apk add bash curl htop vim
#6 0.226 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/x86_64/APKINDEX.tar.gz
#6 0.226 WARNING: updating and opening https://dl-cdn.alpinelinux.org/alpine/v3.18/main: DNS lookup error
#6 0.226 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/x86_64/APKINDEX.tar.gz
#6 0.226 WARNING: updating and opening https://dl-cdn.alpinelinux.org/alpine/v3.18/community: DNS lookup error
#6 0.226 ERROR: unable to select packages:
#6 0.226   bash (no such package):
#6 0.226     required by: world[bash]
#6 0.226   curl (no such package):
#6 0.226     required by: world[curl]
#6 0.227   htop (no such package):
#6 0.227     required by: world[htop]
#6 0.227   vim (no such package):
#6 0.227     required by: world[vim]
#6 ERROR: process "/bin/sh -c apk add bash curl htop vim" did not complete successfully: exit code: 4
------
 > [ddev-router 2/4] RUN apk add bash curl htop vim:
0.226 WARNING: updating and opening https://dl-cdn.alpinelinux.org/alpine/v3.18/community: DNS lookup error
0.226 ERROR: unable to select packages:
0.226   bash (no such package):
0.226     required by: world[bash]
0.226   curl (no such package):
0.226     required by: world[curl]
0.227   htop (no such package):
0.227     required by: world[htop]
0.227   vim (no such package):
0.227     required by: world[vim]
------
', stderr='failed to solve: process "/bin/sh -c apk add bash curl htop vim" did not complete successfully: exit code: 4'
unable to create project at project root '/home/sven/projects/test': project root /home/sven/projects/test does not exist
unable to create project at project root '/home/sven/projects/tester': project root /home/sven/projects/tester does not exist
┌──────────────────────┬─────────┬─────────────────────────────────┬────────────────────────────────────────┬─────────┐
│ NAME                 │ STATUS  │ LOCATION                        │ URL                                    │ TYPE    │
├──────────────────────┼─────────┼─────────────────────────────────┼────────────────────────────────────────┼─────────┤
│ stad                 │ stopped │ ~/projects/drupal_site_stadgent │                                        │ drupal9 │
├──────────────────────┼─────────┼─────────────────────────────────┼────────────────────────────────────────┼─────────┤
│ tryddevproject-25033 │ OK      │ ~/projects/tryddevproject-25033 │ https://tryddevproject-25033.ddev.site │ php     │
├──────────────────────┼─────────┼─────────────────────────────────┼────────────────────────────────────────┼─────────┤
│ Router               │ stopped │ ~/.ddev                         │ http://localhost:9999                  │ traefik │
└──────────────────────┴─────────┴─────────────────────────────────┴────────────────────────────────────────┴─────────┘

┌────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Project: tryddevproject-25033 ~/projects/tryddevproject-25033 https://tryddevproject-25033.ddev.site                               │
│ Docker platform: wsl2-docker-ce                                                                                │
│ Router: traefik                                                                                │
├──────────┬──────┬─────────────────────────────────────────────────────────────────────────────────────────────┬────────────────────┤
│ SERVICE  │ STAT │ URL/PORT                                                                                │ INFO               │
├──────────┼──────┼─────────────────────────────────────────────────────────────────────────────────────────────┼────────────────────┤
│ web      │ OK   │ https://tryddevproject-25033.ddev.site                                                      │ php PHP8.1         │
│          │      │ InDocker: web:80,8025,443                                                                   │ nginx-fpm          │
│          │      │ Host: <IP_ADDRESS>:32855,32856                                                                 │ docroot:'web'      │
│          │      │                                                                                │ NodeJS:18          │
├──────────┼──────┼─────────────────────────────────────────────────────────────────────────────────────────────┼────────────────────┤
│ db       │ OK   │ InDocker: db:3306                                                                           │ mariadb:10.4       │
│          │      │ Host: <IP_ADDRESS>:32857                                                                       │ User/Pass: 'db/db' │
│          │      │                                                                                │ or 'root/root'     │
├──────────┼──────┼─────────────────────────────────────────────────────────────────────────────────────────────┼────────────────────┤
│ Mailhog  │      │ MailHog: https://tryddevproject-25033.ddev.site:8026                                        │                    │
│          │      │ `ddev launch -m`                                                                            │                    │
├──────────┼──────┼─────────────────────────────────────────────────────────────────────────────────────────────┼────────────────────┤
│ All URLs │      │ https://tryddevproject-25033.ddev.site, https://<IP_ADDRESS>:32855,                            │                    │
│          │      │ http://tryddevproject-25033.ddev.site, http://<IP_ADDRESS>:32856                               │                    │
└──────────┴──────┴─────────────────────────────────────────────────────────────────────────────────────────────┴────────────────────┘

============= ddev-tryddevproject-25033-web healtcheck run =========
+ for f in /etc/bashrc/*.bashrc
+ source /etc/bashrc/commandline-addons.bashrc
++ export 'PATH=~/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/var/www/html/vendor/bin:/var/www/html/bin:/var/www/html/vendor/bin'
++ PATH='~/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/var/www/html/vendor/bin:/var/www/html/bin:/var/www/html/vendor/bin'
++ '[' -s /home/sven/.nvm/nvm.sh ']'
++ '[' -s /home/sven/.nvm/bash_completion ']'
++ '[' php = python ']'
++ '[' php = django4 ']'
++ ls '/home/sven/.bashrc.d/*'
bash: rm -f /tmp/healthy && /healthcheck.sh: No such file or directory
============= ddev logs =========
+ logpipe=/var/tmp/logpipe
+ [[ ! -p /var/tmp/logpipe ]]
+ exec /usr/bin/supervisord -n -c /etc/supervisor/supervisord-nginx-fpm.conf
2023-08-01 09:46:57,898 INFO Included extra file "/etc/supervisor/php-fpm.conf" during parsing
2023-08-01 09:46:57,898 INFO Included extra file "/etc/supervisor/conf.d/mailhog.conf" during parsing
2023-08-01 09:46:57,898 INFO Included extra file "/etc/supervisor/conf.d/supervisor.conf" during parsing
2023-08-01 09:46:57,900 INFO RPC interface 'supervisor' initialized
2023-08-01 09:46:57,900 CRIT Server 'unix_http_server' running without any HTTP authentication checking
2023-08-01 09:46:57,900 INFO supervisord started with pid 32
2023-08-01 09:46:58,908 INFO spawned: 'child_exit_monitor' with pid 1922
2023-08-01 09:46:58,909 INFO spawned: 'php-fpm' with pid 1923
2023-08-01 09:46:58,910 INFO spawned: 'nginx' with pid 1924
2023-08-01 09:46:58,911 INFO spawned: 'mailhog' with pid 1925
[01-Aug-2023 09:46:58] NOTICE: fpm is running, pid 1923
[01-Aug-2023 09:46:58] NOTICE: ready to handle connections
[01-Aug-2023 09:46:58] NOTICE: systemd monitor interval set to 10000ms
2023-08-01 09:46:59,957 INFO success: child_exit_monitor entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-08-01 09:46:59,957 INFO success: php-fpm entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-08-01 09:46:59,957 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-08-01 09:46:59,957 INFO success: mailhog entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
============= contents of /mnt/ddev_config  =========
Error response from daemon: No such container: ddev-d9-db
======== Curl of site from inside container:
HTTP/1.1 200 OK
Server: nginx
Date: Tue, 01 Aug 2023 09:47:02 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Vary: Accept-Encoding

======== curl -I of http://tryddevproject-25033.ddev.site from outside:
curl: (7) Failed to connect to tryddevproject-25033.ddev.site port 80 after 18 ms: Connection refused
Unable to curl the requested project Please provide this output in a new gist at gist.github.com.

Please delete this project after debugging with 'ddev delete -Oy tryddevproject-25033'
Failed running test_ddev.sh: exit status 1
. You can run it manually with `curl -sL -O https://raw.githubusercontent.com/ddev/ddev/master/cmd/ddev/cmd/scripts/test_ddev.sh && bash test_ddev.sh`

Expected Behavior
I expected ddev-router to start normally
Actual Behavior
It did not. Instead it does not have an internet connection
Steps To Reproduce

On Windows WSL2, behind a VPN
Upgraded to 1.22.0
/etc/resolv.conf is generated via a script that checks the vpn nameservers
I added the link of my local host to the url in Windows in my hosts file (C:\Windows\System32\drivers\etc\hosts)
If I try nginx-proxy I do get internet in the container but I don't get a connection in the browser (ERR_CONNECTION_REFUSED)
If I try Traefik I get the error you can see in the debug test, which (I think) says that I don't have internet in my Docker container

PS: I'm sorry for the n00b way of describing the problem, I'm a frontender trying to fix the issue. It already took me a day to figure out it was Traefik/router-related 😄
Anything else?
No response

Just saw that there's a duplicate in #5209

Yes, as in #5209, you'll need to talk to your IT department. I'm happy to help you sort it out, and happy to do a live debugging session with you over in discord. If your problem is the same, it's that you have an intrusive VPN that requires significant workaround to do a docker build. Happy to continue the conversation here or elsewhere, happy to do a live debugging session with you. But I think you need your IT department involved if you've described it completely.

Closed as (described) duplicate of

#5209

I note that this can also be caused by network trouble and it looks the same; may also be upstream server trouble:
#6 0.151 fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/aarch64/APKINDEX.tar.gz
  | #6 0.439 WARNING: updating and opening https://dl-cdn.alpinelinux.org/alpine/v3.18/main: IO ERROR
 ```

Here the attempt to access the alpinelinux CDN failed


raftstore: delay some events to reduce store and grpc cpu

Signed-off-by: gengliqi<EMAIL_ADDRESS>What problem does this PR solve?
Problem Summary:
After using async write io(https://github.com/tikv/tikv/pull/10289), the store loop will be very fast than before.
Thus some events may lead to high CPU cost of store and grpc thread. For example, the high frequency of calling Transport::flush in PollHandler::end will generate many send system calls.
What is changed and how it works?
What's Changed:
Add store_events_flush_interval and raft_msg_flush_interval_us to control the frequency of these events.
Related changes

No.

Check List
Tests

Manual test (add detailed scripts or steps below)

Side effects

No

Release note
None

/merge

/merge

/run-all-tests

/run-all-tests

/merge


Error writing files: io error: Failed to find module

I have two source files:
src/lib.rs
#[path = "."]
pub mod a {
    pub mod b;
}

src/b.rs
// (empty file)

cargo check seems to be fine with this layout, and the code compiles. But cargo fmt fails with:
Error writing files: io error: Failed to find module b in "." None

I've also hit this issue. It seems like rustfmt does not like path-renamed modules.

Hi, I think I'm still experiencing this issue.  I'm new to Rust...
I am using relative paths to access different modules.  My project compiles fine but "cargo fmt" does not work for me.  I'm using Windows 7 and have switched to a nightly build of rustup:
rustup 1.22.1 (b01adbbc3 2020-07-08)
nightly-i686-pc-windows-gnu
Previously when I ran the command "cargo fmt" I would get the error that is the subject of this thread.  I now when I run it I get the following error:
error: couldn't read \?\C:\projects\application\main..\common\debug.rs: The filename, directory name, or volume label syntax is incorrect. (os error 123)
Error writing files: failed to resolve mod debug: \?\C:\projects\application\main..\common\debug.rs does not exist
This does tell me more clearly the path that could not be found but the file is definately in the directory:
C:\projects\application\common\debug.rs


Issue with aqtinstall Command: Unresponsive Download Link

Describe the bug
I am encountering an issue while using the aqtinstall command as mentioned below. Specifically, the download link seems to be unresponsive or malfunctioning.
python -m aqt install-qt --outputdir C:\\test windows desktop 5.15.2 win32_msvc2019 -m qtquicktimeline

To Reproduce
Steps to reproduce the behavior:

install aqt using this command

python -m pip install aqtinstall

run aqt with this command

python -m aqt install-qt --outputdir C:\\test windows desktop 5.15.2 win32_msvc2019 -m qtquicktimeline

See error

C:\Users\leeja\Desktop\MonitorControlPortalMaster\AzurePipeline\template>python -m aqt install-qt --outputdir C:\\test windows desktop 5.15.2 win32_msvc2019 -m qtquicktimeline
INFO    : aqtinstall(aqt) v3.1.6 on Python 3.10.4 [CPython MSC v.1929 64 bit (AMD64)]
INFO    : Downloading qtconnectivity...
INFO    : Downloading qtgraphicaleffects...
INFO    : Downloading qtquicktimeline...
INFO    : Downloading qtmultimedia...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtquicktimeline: attempt #2...
INFO    : Downloading qtgraphicaleffects: attempt #2...
INFO    : Downloading qtmultimedia: attempt #2...
INFO    : Downloading qtconnectivity: attempt #2...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtquicktimeline: attempt #3...
INFO    : Downloading qtgraphicaleffects: attempt #3...
INFO    : Downloading qtmultimedia: attempt #3...
INFO    : Downloading qtconnectivity: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgraphicaleffects: attempt #4...
INFO    : Downloading qtmultimedia: attempt #4...
INFO    : Downloading qtquicktimeline: attempt #4...
INFO    : Downloading qtconnectivity: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtquicktimeline: attempt #5...
INFO    : Downloading qtmultimedia: attempt #5...
INFO    : Downloading qtgraphicaleffects: attempt #5...
INFO    : Downloading qtconnectivity: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtdeclarative...
INFO    : Downloading qtimageformats...
INFO    : Downloading qtxmlpatterns...
INFO    : Downloading qtwebsockets...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtdeclarative: attempt #2...
INFO    : Downloading qtimageformats: attempt #2...
INFO    : Downloading qtxmlpatterns: attempt #2...
INFO    : Downloading qtwebsockets: attempt #2...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtdeclarative: attempt #3...
INFO    : Downloading qtimageformats: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtwebsockets: attempt #3...
INFO    : Downloading qtxmlpatterns: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtdeclarative: attempt #4...
INFO    : Downloading qtimageformats: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtwebsockets: attempt #4...
INFO    : Downloading qtxmlpatterns: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtdeclarative: attempt #5...
INFO    : Downloading qtimageformats: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtwebsockets: attempt #5...
INFO    : Downloading qtxmlpatterns: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtlocation...
INFO    : Downloading qtquickcontrols...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qt3d...
INFO    : Downloading qtserialbus...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtquickcontrols: attempt #2...
INFO    : Downloading qt3d: attempt #2...
INFO    : Downloading qtserialbus: attempt #2...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtlocation: attempt #2...
INFO    : Downloading qtquickcontrols: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qt3d: attempt #3...
INFO    : Downloading qtserialbus: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtlocation: attempt #3...
INFO    : Downloading qtquickcontrols: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qt3d: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtserialbus: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtlocation: attempt #4...
INFO    : Downloading qtquickcontrols: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qt3d: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtserialbus: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtlocation: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgamepad...
INFO    : Downloading qtremoteobjects...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading opengl32sw...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgamepad: attempt #2...
INFO    : Downloading qtremoteobjects: attempt #2...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading opengl32sw: attempt #2...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgamepad: attempt #3...
INFO    : Downloading qtremoteobjects: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading opengl32sw: attempt #3...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgamepad: attempt #4...
INFO    : Downloading qtremoteobjects: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading opengl32sw: attempt #4...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading qtgamepad: attempt #5...
INFO    : Downloading qtremoteobjects: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Downloading opengl32sw: attempt #5...
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
INFO    : Redirected: mirrors.sjtug.sjtu.edu.cn
WARNING : Caught ArchiveChecksumError, terminating installer workers
ERROR   : Downloaded file 5.15.2-0-202011130602qtquicktimeline-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z is corrupted! Detect checksum error.
Expect 8ed23f44154c77d993ab6028edadc886563d55e8584b9dd56a249664fe10eea7: https://download.qt.io/online/qtsdkrepository/windows_x86/desktop/qt5_5152/qt.qt5.5152.qtquicktimeline.win32_msvc2019/5.15.2-0-202011130602qtquicktimeline-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z
Actual 22b3ab098e86f695980962b2c7cfd3b5ae0647568b963b8eeae235f73e9da867: qtquicktimeline-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z

C:\Users\leeja\Desktop\MonitorControlPortalMaster\AzurePipeline\template>python -m aqt version
INFO    : aqtinstall(aqt) v3.1.6 on Python 3.10.4 [CPython MSC v.1929 64 bit (AMD64)]

Expected behavior
A clear and concise description of what you expected to happen.
aqt output
Add program output to help explain your problem.

INFO    : Redirected: qt.mirror.constant.com
INFO    : Finished installation of qtserialport-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.32095600
INFO    : Finished installation of qtserialbus-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.89819610
INFO    : Downloading qtgamepad...
INFO    : Finished installation of qtquickcontrols2-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 5.15747820
INFO    : Downloading qtscxml...
INFO    : Finished installation of qt3d-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 6.59313620
INFO    : Redirected: qt.mirror.constant.com
INFO    : Downloading qtremoteobjects...
INFO    : Redirected: qt.mirror.constant.com
INFO    : Downloading qtwebview...
INFO    : Redirected: qt.mirror.constant.com
INFO    : Finished installation of qtgamepad-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.53921010
INFO    : Redirected: qt.mirror.constant.com
INFO    : Finished installation of qtscxml-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.91033420
INFO    : Downloading qtspeech...
INFO    : Finished installation of qtwebview-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.37971930
INFO    : Finished installation of qtremoteobjects-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.04766370
INFO    : Redirected: qt.mirror.constant.com
INFO    : Downloading opengl32sw...
INFO    : Downloading d3dcompiler_47...
INFO    : Finished installation of qtspeech-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.40188330
INFO    : Redirected: qt.mirror.constant.com
INFO    : Redirected: qt.mirror.constant.com
INFO    : Finished installation of d3dcompiler_47-x86.7z in 4.85896380
INFO    : Finished installation of opengl32sw-32-mesa_12_0_rc2.7z in 5.81464470
INFO    : Patching D:\a\1\b\Qt\5.15.2\msvc2019\bin\qmake.exe
INFO    : Finished installation
INFO    : Time elapsed: 44.01454690 second
Finishing: Install Qt

Desktop (please complete the following information):

OS: windows
aqt version [aqtinstall(aqt) v3.1.6 on Python 3.10.4 [CPython MSC v.1929 64 bit (AMD64)]]

Additional context
It appears that Qt is currently not providing the necessary download files on their website. Attempting to download the file resulted in an "access denied" message: https://download.qt.io/online/qtsdkrepository/windows_x86/desktop/qt5_5152/
However, I did find a successful download link:
https://download.qt.io/online/qtsdkrepository/windows_x86/desktop/qt5_5152/qt.qt5.5152.win32_msvc2019/5.15.2-0-202011130602qtmultimedia-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z.mirrorlist

This leads me to suspect that there may be an issue with the mirror file. It's possible that Qt is not aware of this issue yet.

You can use a black list feature of aqtinstall.
https://aqtinstall.readthedocs.io/en/latest/configuration.html#configuration

A mirror server mirrors.sjtug.sjtu.edu.cn  is known as troublesome and put it as black list in CI configuration.
https://github.com/miurahr/aqtinstall/blob/master/ci/settings.ini
The mirror server  seems rejecting  connections from one that they want not to connect.
You can check https://mirrors.sjtug.sjtu.edu.cn/ in browser and they show their status in Chinese.

It seems now it is progressing mirror.

thank you

I move  https://mirrors.sjtug.sjtu.edu.cn/qt/ from fallbacks: to blacklist. It works!
C:\Users\leeja>python -m aqt install-qt --outputdir C:\\test windows desktop 5.15.2 win32_msvc2019 -m qtquicktimeline
INFO    : aqtinstall(aqt) v3.1.6 on Python 3.10.4 [CPython MSC v.1929 64 bit (AMD64)]
INFO    : Downloading qtquicktimeline...
INFO    : Downloading qtconnectivity...
INFO    : Downloading qtmultimedia...
INFO    : Downloading qtgraphicaleffects...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtquicktimeline-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.86953450
INFO    : Finished installation of qtgraphicaleffects-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.92270500
INFO    : Finished installation of qtconnectivity-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.35103860
INFO    : Finished installation of qtmultimedia-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.62083300
INFO    : Downloading qtbase...
INFO    : Downloading qtsvg...
INFO    : Downloading qtactiveqt...
INFO    : Downloading qttranslations...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtsvg-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.02204210
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtactiveqt-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.61785030
INFO    : Downloading qtdeclarative...
INFO    : Finished installation of qttranslations-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.57828030
INFO    : Downloading qtimageformats...
INFO    : Downloading qtxmlpatterns...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtimageformats-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.28046930
INFO    : Finished installation of qtxmlpatterns-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.91512040
INFO    : Finished installation of qtdeclarative-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 6.36685370
INFO    : Downloading qttools...
INFO    : Downloading qtsensors...
INFO    : Downloading qtwinextras...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtwinextras-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.05280540
INFO    : Downloading qtwebsockets...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtwebsockets-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.93929930
INFO    : Downloading qtwebchannel...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtwebchannel-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.97040490
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Downloading qtlocation...
INFO    : Finished installation of qtsensors-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 13.42965780
INFO    : Downloading qtquickcontrols...
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtbase-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 26.41479820
INFO    : Redirected: ftp.jaist.ac.jp
INFO    : Finished installation of qtlocation-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.82471430
INFO    : Downloading qt3d...
INFO    : Finished installation of qtquickcontrols-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.52031000
INFO    : Downloading qtserialport...
INFO    : Downloading qtquickcontrols2...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qtserialport-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.94170630
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qt3d-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 5.66518020
INFO    : Downloading qtserialbus...
INFO    : Finished installation of qtquickcontrols2-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.82973690
INFO    : Downloading qtwebview...
INFO    : Downloading qtgamepad...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qtserialbus-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.14729550
INFO    : Finished installation of qtwebview-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 3.97142860
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Downloading qtscxml...
INFO    : Finished installation of qtgamepad-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.00340610
INFO    : Downloading qtspeech...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qtscxml-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.14996360
INFO    : Finished installation of qttools-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 31.10762790
INFO    : Downloading opengl32sw...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qtspeech-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 4.86622600
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of opengl32sw-32-mesa_12_0_rc2.7z in 4.80272420
INFO    : Downloading qtremoteobjects...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of qtremoteobjects-Windows-Windows_10-MSVC2019-Windows-Windows_10-X86.7z in 12.30800360
INFO    : Downloading d3dcompiler_47...
INFO    : Redirected: mirrors.ustc.edu.cn
INFO    : Finished installation of d3dcompiler_47-x86.7z in 4.27527510
INFO    : Patching C:\test\5.15.2\msvc2019\bin\qmake.exe
INFO    : Finished installation
INFO    : Time elapsed: 59.46083170 second

Thanks a lot!


Api generation has unnecessary documentation

With laravel 5.5.* version following step is unecessary in the API generation process
Add this line to (app/Providers/RouteServiceProvider.php) in the mapWebRoutes() method: require base_path('routes/api.php');
RouteserviceProvider allready provides method for injecting API routes:
     protected function mapApiRoutes()     {         Route::prefix('api')              ->middleware('api')              ->namespace($this->namespace)              ->group(base_path('routes/api.php'));     }

Laracogs supposedly supports earlier versions of Laravel so it's a better idea to keep the documentation backward compatible

Actually I do believe that was a Typo. I've fixed it in the command documentation. Thanks.


Add propTypes to class properties list

The list of class properties valid for a React.Component class should include propTypes.

Can we make it a local section on the page that contains a short paragraph that links to the propTypes doc?

Sure, will do.


Automated Detection Testing PR detection_testing_branch

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
DNS Query Length With High Standard Deviation :white_check_mark:

diskUsage: 200704
runDuration: 1.5150000000000001s
scanCount: 1627

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Malicious PowerShell Process With Obfuscation Techniques :white_check_mark:

diskUsage: 356352
runDuration: 18.649s
scanCount: 29687

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Malicious PowerShell Process With Obfuscation Techniques :white_check_mark:

diskUsage: 356352
runDuration: 18.649s
scanCount: 29687

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Malicious PowerShell Process - Execution Policy Bypass :white_check_mark:

diskUsage: 438272
runDuration: 1.698s
scanCount: 929

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Malicious PowerShell Process - Execution Policy Bypass :white_check_mark:

diskUsage: 438272
runDuration: 1.698s
scanCount: 929

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
First Time Seen Running Windows Service :x:

diskUsage: 102400
runDuration: 0.302s
scanCount: 649

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
First Time Seen Running Windows Service :x:

diskUsage: 102400
runDuration: 0.302s
scanCount: 649


Tank Demo - Client lags if set to Very Low

1.) Get Mirror into Unity
2.) Build the Tank demo (Movement demo if using the Asset Store version)
3.) Open the binary twice - Set the resolution on both windows to 640x480, "Very Low", Windowed
4.) Hit "Play" on both
5.) On one window, select "LAN Host", and drive around a bit
6.) On the second window, type in your local LAN IP and click "LAN Client"
7.) Try to drive around on the second window, and notice your acceleration is almost non-existant, whilst your rotation is fine.
8.) Close the second window (The laggy one), re-run the binary, and change "Very Low" to "Ultra", leaving the other settings the same
9.) Reconnect to the server as you did in Step 6
10.) Notice you can drive around fine
The acceleration of the client should not drop to near-non-existent levels in the demo if the Graphics Quality is altered.
Tested on Unity 2018.3.9f1 on Windows 10 using the latest version of Mirror on the Unity Asset Store

Can't reproduce - anyone else?

Closing - no response in 4 months.


Twitter keeps logging me out

Brilliant little app. Every few days I have to log back in to Twitter. Facebooks doesn't have this problem.
Sometimes I'll be in the middle of reading Twitter, and then suddenly I'm logged out. I'm not blocking 3rd party requests.
Any idea how I can fix it?

It happened intermittently to me. I am not sure what is causing it, could be the blocking of 3rd party cookies, not sure.

Oh well, at least it isn't just me!

That said, it has been working fine for me for several weeks, ever since I deleted my twitter app and re-added it after the new twitter UI refresh. YMMV.

Having the same issues. Also even when it's not logging me out, it doesn't remember the theming settings. I have to set twitter to use dark theme again every time I open the web app.

Please see #152


Coverity 1021694: Uninitialized pointer field

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/537/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/550/

AU check successful! https://ci.trafficserver.apache.org/job/autest-github/535/

[approve ci]

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/2127/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/664/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2231/

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/793/


My gVim hangs when attempting to get completions

Hey!
I am attempting to use gVim for some C# development (coming from VSCode). Got Omnisharp-vim installed using stdio. I can repro this issue 100%. I have a Unity project that I am loading the project for. I load a cs file and the server loads fine. I attempt to get completion using C-x C-o and Vim will hang. Sometimes it will hang on the "Searching..." message, other times it will say that Omnisharp timeout exceeded (I am paraphrasing).
How do I debug this? I looked at the log from OmniSharpOpenLog (after I restart VIM) and I don't see anything along the lines of Error (it's all LogLevel::Info).
Thoughts?
Thanks

I am paraphrasing
Please don't paraphrase, this is a bug report, details matter.

How do you know the server loads fine? Do other OmniSharp actions work, like :OmniSharpGotoDefinition, :OmniSharpFindUsages etc.?
Could you post your .vimrc? If you're not using a plugin manager that lists your plugins, then also post a list here.

First off, thanks for the quick response.
Update: I followed the instructions in this article: https://blog.bigfont.ca/vim-with-csharp-dotnet-and-omnisharp-on-windows/
and the hang is no longer happening and it seems to be OK. I will spend more time with it and re-open this issue. So far seems like a user error installing OmniSharp. Apologies, still relatively new to vim but learning quickly.

No worries.
That article is extremely out of date though, and very erroneous. You don't have to build the server yourself - once you've installed OmniSharp-vim, the plugin will download the latest OmniSharp-roslyn release from github. Second, the article suggests building the legacy server, used before it was replaced with OmniSharp-roslyn - but then spceifically telling OmniSharp-vim to use the 'roslyn' server. Those instructions were never going to work.
Stick to the README. But by all means open issues if you have trouble - or ask on slack if you prefer.


Add cache for servicespans, reduce unnecessary writes

Trying to implement cache for servicespans to reduce excessive writes ( https://github.com/openzipkin/zipkin/issues/1570 ).
Cache limited with 2 days and 1000 entries for each day (non-configurable for now).

thx for the start! I think it doesn't need to be configurable at the moment. we have many things that aren't configurable.

Sorry yep!  You got it ;)
On 2 May 2017 04:15, "Semyon Slepov"<EMAIL_ADDRESS>wrote:

@semyonslepov commented on this pull request.
In zipkin-storage/elasticsearch-http/src/main/java/zipkin/
storage/elasticsearch/http/ElasticsearchHttpSpanConsumer.java
https://github.com/openzipkin/zipkin/pull/1579#discussion_r114192185:

   if (!indexToServiceSpans.isEmpty()) {

     indexNames(indexer, indexToServiceSpans);
   }
   indexer.execute(callback);
 } catch (Throwable t) {
   propagateIfFatal(t);
   callback.onError(t);

 synchronized(indexToServiceSpansCache) {

     for (String index : indexToServiceSpans.keySet()) {

         Set<Pair<String>> serviceSpansEntry = indexToServiceSpans.get(index);

         Set<Pair<String>> serviceSpansEntryCached = indexToServiceSpansCache.get(index);

Or you are talking about moving filling cache outside of
putServiceSpans()? Messed a bit by comments (:
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/1579#discussion_r114192185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD619XOEwX3iOPGMPdTc-MgeI6fnmSiks5r1j1qgaJpZM4NMmrV
.

I rebased and squashed this for you. need to do another pass on review as not sure where we left off

I'm not sure as well, hope to find time finally and work on it

ah ok.. well anyway when you are ready for it, make github line comments or
otherwise to explain tests removed or repurposed.

test order can bite us later perhaps. maybe we should expose a way to clean
the cache (package private access) and make sure it is invoked in a Before
block?

Still don't understand why these ES integration tests are failing... Executing the same thing with the same parameters on my notebook and it passes...

Do you have docker running on your laptop? These tests conditionally run if
docker (like docker machine or such) is installed
On 12 Jul 2017 3:49 pm, "Semyon Slepov"<EMAIL_ADDRESS>wrote:

Still don't understand why these ES integration tests are failing...
Executing the same thing with the same parameters on my notebook and it
passes...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/1579#issuecomment-314684146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61zgOyRT-J4bvrRSadVb3ZPKRQ1rIks5sNHp2gaJpZM4NMmrV
.

Yeah, it was docker issue because I ran tests on my MacBook and it's a bit tricky sometimes to run Docker properly there.
Enabled Travis for my forked repo and finally fixed the cause.

Glad you got to the bottom of it and 100thx for putting in effort to fix it
on your own. Does this mean you think this is ready for a "final review"?
On 18 Jul 2017 2:52 am, "Semyon Slepov"<EMAIL_ADDRESS>wrote:

Yeah, it was docker issue because I ran tests on my MacBook and it's a bit
tricky sometimes to run Docker properly there.
Enabled Travis for my forked repo and finally fixed the cause.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/1579#issuecomment-315847285,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD617d0crUNLSK4H0IkP-cGjVrcleu_ks5sO61xgaJpZM4NMmrV
.

I'm not 100% sure about "final" (: But yes, anyway, I think now it's on some step which is ready for review.

all things in quotes aren't final :) but cool.. will do a pass in a bit

gonna close this as we should re-evaluate with the new single-type index. If needed, we can re-open


AUTOREV usage by layer

At the moment README explicitly tells us:
Package dependencies are specified in recipes.  By default,
packages use AUTOREV floating revisions, but you can lock down
specific versions using SRCREV overrides for packages you include
in your build.

But in my opinion that's questionable practice. There is an obvious positive side of AUTOREV in that you're free from manual SRCREV bumps whenever something updates, and that also matches the default behaviour of go get, but this default leads to build instability, which is very dangerous. IMO any real build will need to pick some particular SRCREVs (to be stable), and telling everyone that you need to pick one makes using this layer a bit harder (and again dangerous, as it's easy to miss some packages).
Also, this makes layer itself unstable, because packages do change and may introduce new dependencies or changes that will break the recipe, so it can compile today and break tomorrow without any change in the layer.
Had these issues been considered or are there any other reasons for AUTOREV?

Yes, the underlying philosophy behind go's handling of packages is pretty much diametrically opposed to the traditional well-defined-release approach that I was used to.  I didn't want to lock in a specific policy until I (and hopefully others) had some experience to share regarding the tradeoff between the go-style and OE-style approaches.
Also, since maintaining this layer has so far been a one-man operation conducted in my spare time and on my own dime, I haven't really had the resources at my disposal to do what I think would be needed in terms of automating the SRCREV updates and testing the various package combinations - much as I'd like to.
I do periodically run some test builds and fix up dependencies when they change, but more is certainly needed.
Certainly for releasing a product, one needs to have the SRCREVs locked down, and I have done that in my production distros.  I have experimented with different combinations of floating and locking SRCREVs for go packages during development cycles as well, so it may be time to formulate a policy for the layer and put it in place.
I think, though, that if I do end up locking most of the recipes' SRCREVs, that I'll be forced to start pruning out most of the recipes currently in the layer, getting it down to a very small core set of packages, so it's something maintainable on the small scale I can afford.
I'd welcome any suggestions on this front, particularly from folks that are actively using the layer.

Yes this was good, today golang-mqtt-paho_git.bb
gives Connection reset by peer from GO_SRCROOT = "git.eclipse.org/gitroot/paho/org.eclipse.paho.mqtt.golang.git"
on Krogoth.


Enable "code ." to be entered on the Windows 10 Windows Explorer address bar

Enable "code ." to be entered on the Windows 10 Windows Explorer address bar and have vscode open the currently displayed directory path.
For example, entering "cmd" in the Windows Explorer address bar will open the Command Prompt with its cwd set to Windows Explorer's currently displayed directory path.  Why can't vscode work the same way?
Best regards,
Michael Herman (Toronto)

Bonus request: Entering "code anysubfolder" should open the folder "anysubfolder" in Windows Explorer's currently displayed directory path (if it exists)

Alternatively, you could type code.cmd . instead to open up VS Code in that file directory.
The only backdrop is that it opens an empty cmd shell in the background.
Inferring from the behaviour, I think it is equivalent to opening a cmd in that directory and running code . in it.

For me, I can open "code ." from address bar by adding new path in system env variable C:\Program Files\Microsoft VS Code.
It will open vscode for current directory. Make sure the where command display code.exe at the top
$ where code C:\Program Files\Microsoft VS Code\Code.exe C:\Program Files\Microsoft VS Code\bin\code C:\Program Files\Microsoft VS Code\bin\code.cmd

I will be thankful if you explain why did it work

Alternatively, you could type code.cmd . instead to open up VS Code in that file directory. The only backdrop is that it opens an empty cmd shell in the background. Inferring from the behaviour, I think it is equivalent to opening a cmd in that directory and running code . in it.

add "exit" at the end of the file "code.cmd"  that will close the terminal after opening the visual studio code.. :)
@abdallahmansour6
in my win11 system "code" detected in console but from address bar its not working , rest all are working fine
i think from address bar windows is looking somewhere else instead of the env variable..


Once IDE support lands for 0.79...

We should update the description of the repo from "A Nushell grammar and theme for Visual Studio Code" to include more of the features. We may have to update the description elsewhere also.

Agreed. It would be nice to include some gifs or more screenshots in the readme.

implemented.


Remove version: taers232c.GAMADV-XTD3 version 6.71.11

This version is older than what has been set in max-versions-to-keep by the publisher.
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/taers232c/GAMADV-XTD3/releases/download/v6.71.11/gamadv-xtd3-6.71.11-windows-x86_64.msi
OK
(Automated message - build 910)


use absolute path instead of dynamic lookup

This is both more deterministic and makes shellcheck happy.

Thanks! :+1:


Can ModSecurity use the value in $proxy_protocol_addr for GeoIP Checks ?

Hello,
I have an nginx + mod_security (v3.3.2) + CRS sitting behind a L4 TCP LoadBalancer with PROXY protocol enabled ( meaning the TCP LB can send information about the original Client IP only though the PROXY protocol).
Now, nginx can indeed extract that information and does so in the $proxy_protocol_addr variable (http://nginx.org/en/docs/http/ngx_http_core_module.html):
$proxy_protocol_addr -  client address from the PROXY protocol header (1.5.12)
I can tell it's the correct value because I dumped it to access_log and it indeed shows the actual source IP.
I am trying to do GeoIP filtering using mod_security and unfortunatelly, looking at the refference manual here: https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual-(v3.x) the only relevant values are:

REMOTE_ADDR: This variable holds the IP address of the remote client. ; however, in my case because traffic is coming from a TCP LB this value is the LBs IP
REQUEST_HEADERS: Where I could place the value in a header like X-Forwarded-For; npow this would work if I had an HTTP LB in front instead of a TCP LB

So my question is : Can the same information that nginx stores in the $proxy_protocol_addr variable be accessible to be used by mod_security, to have something like:
SecRule PROXY_PROTOCOL_ADDR "@geolookup" .... ?
Thanks a lot.

Not specifically an answer to this exact feature, but I did find a way to achieve the goal by using  ngx_http_realip_module: http://nginx.org/en/docs/http/ngx_http_realip_module.html
http {
...
set_real_ip_from  <IP_ADDRESS>/24; <= which LB IP ranges I allow the overwrite to REMOTE_ADDR to happen
real_ip_header    proxy_protocol;
}
This way REMOTE_ADDR is actually overwritten by nginx before GeoIP check, and since mod_security knows how to work with REMOTE_ADDR, all is good 💯
Leaving this here in case other people try to solve the same isue.

Hello @okdn85 ,
The short answer to your question about your hypothesized rule ('SecRule PROXY_PROTOCOL_ADDR ... ') is no. ModSecurity rules do not have direct access to arbitrary nginx variables. In particular, a variable name that follows 'SecRule' must be one that is defined within ModSecurity (or set by the rule set as with collections like TX.).
Thanks for your tip, though, that may be helpful to some other users.
Another way to achieve what you want (assuming that I've understood you correctly) is to simply use the @geoLookup operator against whatever variable is appropriate -- it is not restricted to use only against REMOTE_ADDR.
If you know that the relevant remote address that you wish to test is always contained in a request header with the name 'Proxy', you can simply test that value.
If you have a priority list of where the relevant remote address is located, you can test values and populate a TX variable that you can later test with @geoLookup.


RDK-29389:API to query AudioCapabilty of the stb

Reason for change: Thunder changes for feature
Adding 2 API getSettopAudioCapabilities and
getSettopMS12Capabilities.
Test Procedure: Refer JIRA (RDK-27000)
Risks: Low
Related chage topic: RDK_27000_AudioCapability_query
Signed-off-by: Akhil Baby Sarada<EMAIL_ADDRESS>

Metrological is adding this information as well but than on the player. There is a distinction in the plugin setup where:
DisplayInfo -> Deliver all information on the properties of the display (visualisation)
PlayerInfo -> Deliver all information on the properties of a player, like audio and video capabilities.
Given this definition we are adding the MS12 proeprties (wich are Audio properties and thus related to player capabilities) to the PlayerInfo.

@pwielders  Thanks for the comment . I will check and update

@apatel859  : I have updated according to you comments
@pwielders : Currently all the audio related API's are implemented in DisplaySettings plugin, hence I followed the same here. If we move just these implementation then it will be confusing since some will be in DisplaySettings and other in player settings.
From your comment I understand all Device specific inforamtion has to be form PlayerInfo plugin. I believe this can be taken up as a separate ticket for moving implementation of all such api's.
For now can you provide +1 to merge this with Display settings ?

The cahnges has been merged to 2009 sprint branch