Get-NAVAppRuntimePackage : No published package matches the provided arguments.

Describe the bug
The Get-NAVAppRuntimePackage doesn't seem to be working.
Get-NAVAppRuntimePackage -Id 9acfa8a0-7159-4791-a575-884a741a2384 -Name 'STST_Core_Tables' -Publisher 'ESC bvba' -Version <IP_ADDRESS> -Path 'C:\temp\Prosware SmartApp_<IP_ADDRESS>0_runtime.app' -ServerInstance BC130
To Reproduce
Just create an extension in BC CU2 I guess.
get-navappinfo gives the following:

Expected behavior
A runtime app should be generated
Screenshots

Versions:

AL Language: 2.1.109895

Business Central: BE Dynamics NAV 13.2 (26556)

I have the same problem. What makes it strange, is it worked the first time. Then I updated the package and re-published it. Now it cannot make the runtime - same error.
This is for Business Central on premise 13.3 (27183) AL 2.1.79379 installed from CU3 visix

I found my answer - had published from VS Code. I unpublished it, then republished it with skip verification. Now it created the runtime package.
Is there an option in the app.json file or the launch.json to skipverification?

Hi! In the last months, we've been working hard on adding new features that increase your productivity and on improving the quality of the tools. Unfortunately, this meant that we were not able to follow up on as many GitHub issues as we have liked.
Is this issue still a problem for you? Can you provide a sample project and steps to reproduce the issue? Does it reproduce on the Wave 2 2019 release?

I am trying to make a runtime package for the Business Central OnPrem.  My app publishes fine from VS Code.  I can see it when I open the client and when I run get-navappinfo from PowerShell.  But when I run the Get-NAVAppRuntimePackage script it fails and gives me the same thing they were seeing.

I am using the onprem:13.5.29483.0-na image.  I have not attempted to move this to Wave 2 2019 release as I am trying to do an update for a client.

Hi @Srbaxter52 , extensions published from VSCode are published in the tenant scope. You need to specify the tenant ID: See https://github.com/microsoft/AL/issues/5286

This issue has been closed because it needs more information and has not had recent activity. Please open a new issue if you believe this has not been resolved and reference the current issue.


pull request for e2e test at 11/14/2016 08:56:11

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Reopening a git repo in a container results in repository being marked as unsafe

Duplicate of https://github.com/microsoft/vscode-remote-release/issues/7628.


Sierra holdings adapter doesn't keep up-to-date with embargoed resources

This is a bug discovered while working on https://github.com/wellcomecollection/platform/issues/5126
When you request holdings data from the Sierra API, it includes some information about "enumerations" – for example, the range of issues of a subscription resource that you can access. For physical holdings, this is static data – but it turns out to be dynamic for electronic holdings.
The Sierra API dynamically adjusts the end date of enumerations for electronic holdings based on embargo agreements with publishers, e.g. one record describes a range of issues (1991–2017), with a note in subfield $x:
863    …|xChronology adjusted by 1460 day embargo period

and the end date of the range varies depending on when you called the API – it will return the latest issue you can see right now. Calling the API on three different days will return three different values. Unfortunately for us, this isn't picked up by the adapter, because the modifiedDate is the same.
Our assumption that we can fetch updated records based on the modifiedDate is wrong.
Fortunately, the reporting cluster has our back – we can search for holdings records that this matches, and we see there are 230:
GET /sierra_varfields/_search
{
  "query": {
    "bool": {
      "must": [
        {
          "match": {
            "varField.subfields.content": "Chronology adjusted by"
          }
        }
      ],
      "filter": {
        "term": {
          "parent.recordType.keyword": "holdings"
        }
      }
    }
  }
}

Because it's only 230 works and isn't a massive issue on any of them, I don't think this is enormously high priority.
Rough checklist:

[ ] Add a Lambda that queries the reporting cluster for these records, and sends their IDs to the adapter
[ ] Run that Lambda on a schedule of once a day
[ ] Modify the adapter to support fetching a record by query
[ ] Remove the current short-circuit logic from the Sierra adapter

Closing as done and seen working.


Object-detection

💡 Your Question
How can I use coco in yolo-nas to detect only certain objects in the video like I only want to detect cars and person.
Versions
No response

yes I do want the steps

i did it using yolo5v cause i couldn't really find documentation for yolo-nas

same question here!

Duplicate of https://github.com/Deci-AI/super-gradients/issues/1195


Timeout

FYI: Use of OS timers to timeout syntax highlighting and searching.
Removes the need to regularly read any system timers while executing the RE engine.

getitimer and setitimer are deprecated in favor of timer_gettime and timer_settime which, in the spirit of #10494, allow the coder to select a monotonic clock source.

not on macos FYI - would require feature test probably.

@LemonBoy wrote:

getitimer and setitimer are deprecated in favor of timer_gettime and timer_settime which, in the spirit of https://github.com/vim/vim/pull/10494, allow the coder to select a monotonic clock source.

I know. And I would like use them in preference because they have other advantages as well. I already have implementation (on a separate branch on my PC); it works well and the code is a bit simpler.
I switched to setitimer on this branch for pragmatic reasons; namely the code ports to OS X and so stood a chance of actually passing macos CI checks. I am planning to revive oldish Mac laptop (dead hard drive) so I am in a position to develop an OS X specific solution.

Thanks for working on this alternative solution.  The idea looks good, we need to check that this works on all systems where SYN_TIME_LIMIT is defined.
The alarm signal is set for redrawing a window.  That matches with what 'redrawtime' is for.  The functions should be called to reflect that:  init_redraw_timeout() instead of init_regexp_timeout().
I'm not sure if it ever gets used recursively.  For a start I would produce an internal error when the alarm is tried to set when it already is.  If we find a case where this happens we'll have to see how we need to handle it.
I suspect it might happen when a timer or channel callback is invoked.  We might then have to stop the running alarm, set one for whatever happens in the callback, then restore the previous one for the remaining time.  That's a bit complicated, thus we should figure out if it is really needed.

I switched to setitimer on this branch for pragmatic reasons; namely the code ports to OS X and so stood a chance of actually passing macos CI checks. I am planning to revive oldish Mac laptop (dead hard drive) so I am in a position to develop an OS X specific solution.

On macOS you can emulate the timer_ API using the GCD, here's a small example of how to do so. According to the API docs there's a way to avoid using the wall clock timer.

One more thing to worry about is the flag atomicity given it's written from within a signal handler, check out this article for more info.

One more thing to worry about is the flag atomicity given it's written from within a signal handler, check out this article for more info.

Definitely not an issue for this code. Possibly should use one of more 'volatile' declarations though for correctness.

The alarm signal is set for redrawing a window. That matches with
what 'redrawtime' is for. The functions should be called to reflect
that: init_redraw_timeout() instead of init_regexp_timeout().

Actually the timeout logic (existing and on this branch) is also used
for the vim search() function; I added a test for it on this branch.

Ah, OK.  Also used by searchpair().
--
The question is:  What do you do with your life?
The wrong answer is: Become the richest guy in the graveyard.
(billionaire and Oracle founder Larry Ellison)
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Starting to look much better, only one relevant test failure on Windows:
Found errors in Test_search_timeout():

@brammool wrote.

Starting to look much better, only one relevant test failure on Windows:
Found errors in Test_search_timeout():

I think I may have reached a point where the tests should be stable. I now plan to switch to timer_settime for Unix and some equivalent for OS X (now I have an OS X platform).
Is there any way to manually trigger a CI run (or better still selective parts of a CI run)? It is the only way I can get some evidence of stability of the timeout tests, since I could not reproduce the occasional failures on my computers.

All tests are passing now.  CI is only triggered if you push a change.
Let me know when it's ready to include, then we can give it to a wider audience to see if there are problems on some system.

@brammool I think this is ready for a wider audience now.
Is there some definitive list of the platforms that we support?
Even better, is there some matrix or platforms and supported features?
I am now set up to test on "the big 3", but would be interested to expand to other platforms where possible.

I have included this now.  I made some cosmetic adjustments.
Please check, if someone has a problem with it we may fix that, or roll back this change.


Provide users with more insight as to why a build failed

Context:  Seth Boyles of the CAPI team contributing to CF noticed that some error messages returned during the build process could seem opaque to end users.  He particularly noted ERROR: failed to build: exit status 103.
There are a number of solutions to this problem:

The easiest stopgap would be to surface logs associated with the error to assist in debugging
@matthewmcnew  had an idea about a "summary" error that includes the build stage during which the error occured
Invest additional time to better parse errors to return a variety of errors for individual failures.

A summary error could provide the step that buildpack step that failed and the exit code.


"Run a script" support (in addition to X11 and Wayland)

Is your feature request related to a problem? Please describe.
Trying to get ~desktop~ terminal notifications from programs emitting them in a headless, no desktop (neither X nor Wayland) TTY-only environment (remote shells).
I can launch a headless DBus service for programs requiring it (ie. failing if no DBus present).
Also, this opens up a world of extensibility, where you can get creative with notification methods. :smile:
Describe the solution you'd like
Just an 'invoke a custom script' backend in addition to X11 and Wayland, which would handle all notifications. It could be 'in addition to' X11 or 'replacing' X11.
I guess that a 'script-only' backend would enable adding fancy functionality to any Desktop Environment, without requiring to drop the built-in notification manager. (e.g. send a push notification to Android/iOS).
Describe alternatives you've considered
A specific software just listening for DBus notifications, but found none.

Hey, thanks for creating this issue. I would like to hear more about your ideas, especially the part that how you think this could be implemented. As far as I understood, you simply want a command-line interface that listens D-Bus notifications and you want to utilize it in shell scripts, am I right? Can you give a concrete example of that?

Thanks for your interest, @orhun.
Invoking a script would serve almost infinite use cases, users could get creative.
Mine would be to be able to send notifications to a tmux floating popup or a tmux display message.
However, lots of use cases could be enabled.

It would also enable to have desktop notifications, on bare TTY sessions, since you can run a DBus session without X11 and sending & listening notifications just needs DBus.

Having to code a listening program would place it out of reach/convenience for the average user.
I was thinking more in an external program/script that would be invoked on each event, specified with a simple --script command line switch or config file option. I'm not sure about if it would replace or add to X11 notifications (ie. as another backend).
Looking closely to the docs, maybe my use case could be covered with a custom_command which could unconditionally send all events to tmux.
However, replacing X11 could be useful for some users. Maybe if exit codes from filters were checked for stopping/continuing processing would work for those users. Not sure, thou.

As I attempted to try custom_commands, I've filed #104.

Making the X11 dependency optional would be a good start for this. What do you think?

Not a must for my specific use case, but I guess that it won't hurt when adding Wayland support.
Having the X11/Wayland code outside the main logic as a sort of backend, would later enable to add a no-X-just-script backend as we're discussing here. Disclaimer: I'm not familiar with the codebase, neither with Rust.


Add types for TypeScript

This pulls in the type definition for @hapi/joi which simplifies things for TypeScript users, however it means non-TypeScript users are getting an extra (very small) dependency.
Feedback welcomed!
Closes #17

For me, everything's ok.
When it will be available?

Hey @ealbuquerque just out of curiosity have you tested this version of the package with your own code? The projects I have which use this are not using TypeScript so I only was able to test it via the tests I wrote.

@paulmelnikow,

In my project @hapi/joi it was in version 17.1.1, and had to adjust to 16.x.x because it didn't work with different versions.

After that, I did the joi-extension-semver local link and Joi.semver()  types worked.

When I started my project this error occurred:

TypeError: validator_1.default.semver is not a function
    at Object.<anonymous> (/my-project-path/src/routes/schemas/semver.ts:11:21)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Module._compile (/my-project-path/node_modules/source-map-support/source-map-support.js:547:25)
    at Module.m._compile (/tmp/ts-node-dev-hook-5764332526537463.js:57:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at require.extensions.<computed> (/tmp/ts-node-dev-hook-5764332526537463.js:59:14)
    at Object.nodeDevHook [as .ts] (/my-project-path/node_modules/ts-node-dev/lib/hook.js:61:7)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/my-project-path/src/routes/schemas/index.ts:6:1)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Module._compile (/my-project-path/node_modules/source-map-support/source-map-support.js:547:25)
    at Module.m._compile (/tmp/ts-node-dev-hook-5764332526537463.js:57:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at require.extensions.<computed> (/tmp/ts-node-dev-hook-5764332526537463.js:59:14)
    at Object.nodeDevHook [as .ts] (/my-project-path/node_modules/ts-node-dev/lib/hook.js:61:7)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)

I think it's don't finding the joi-extension-semver lib, just the types.

3\. When I started my project this error occurred:

TypeError: validator_1.default.semver is not a function
    at Object.<anonymous> (/my-project-path/src/routes/schemas/semver.ts:11:21)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Module._compile (/my-project-path/node_modules/source-map-support/source-map-support.js:547:25)
    at Module.m._compile (/tmp/ts-node-dev-hook-5764332526537463.js:57:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at require.extensions.<computed> (/tmp/ts-node-dev-hook-5764332526537463.js:59:14)
    at Object.nodeDevHook [as .ts] (/my-project-path/node_modules/ts-node-dev/lib/hook.js:61:7)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/my-project-path/src/routes/schemas/index.ts:6:1)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Module._compile (/my-project-path/node_modules/source-map-support/source-map-support.js:547:25)
    at Module.m._compile (/tmp/ts-node-dev-hook-5764332526537463.js:57:25)
    at Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at require.extensions.<computed> (/tmp/ts-node-dev-hook-5764332526537463.js:59:14)
    at Object.nodeDevHook [as .ts] (/my-project-path/node_modules/ts-node-dev/lib/hook.js:61:7)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)

Hmm, the types might be incorrect in some way, however they are not causing this error. Can you get your code to work correctly without the types?

In my project @hapi/joi it was in version 17.1.1, and had to adjust to 16.x.x because it didn't work with different versions.

Could you elaborate on that? What happens when you're using it with 17.1.1?

@paulmelnikow, I created a simple project to demonstrate the two errors:
https://github.com/ealbuquerque/typescript-joi-semver

@paulmelnikow, any news?
Did you clone my project to see the errors?

The problem is that the usage of Joi.extend() is incorrect:
import Joi from '@hapi/joi';
import {
  semver,
  semverRange,
} from 'joi-extension-semver';

Joi.extend(semver)
Joi.extend(semverRange)

export default Joi;

It should be:
import _Joi from '@hapi/joi';
import {
  semver,
  semverRange,
} from 'joi-extension-semver';

const Joi = _Joi.extend(semver).extend(semverRange);
export default Joi;

In light of Joi.extend() not modifying the global module, there might be a way to improve the types so this would be caught by the type-checker, though I don't think it's blocking this.

The problem is that the usage of Joi.extend() is incorrect:
import Joi from '@hapi/joi';
import {
  semver,
  semverRange,
} from 'joi-extension-semver';

Joi.extend(semver)
Joi.extend(semverRange)

export default Joi;

It should be:
import _Joi from '@hapi/joi';
import {
  semver,
  semverRange,
} from 'joi-extension-semver';

const Joi = _Joi.extend(semver).extend(semverRange);
export default Joi;

In light of Joi.extend() not modifying the global module, there might be a way to improve the types so this would be caught by the type-checker, though I don't think it's blocking this.

WOW! How come I didn't see that? haha, great.
it works too:
import Joi from '@hapi/joi';
import {
  semver,
  semverRange,
} from 'joi-extension-semver';

export default Joi
  .extend(semver)
  .extend(semverRange);

But @paulmelnikow , still giving error with @hapi/joi in version 17.1.1

What is the error?

@paulmelnikow,

What is the error?

[ERROR] 16:58:33 Error: Cannot mix different versions of joi schemas

In the joi-extension-semver package.json, you would need to upgrade to version 17.x.x, it is currently 16.x.x.

Ah, okay. I'm guessing that's not related to this PR.

Ah, okay. I'm guessing that's not related to this PR.

I'll open another task


Unnecessary / too specific util function

https://github.com/ieahleen/randomTreasure/blob/main/utils/helpers.js#L60
https://github.com/ieahleen/randomTreasure/blob/main/utils/helpers.js#L64
Probably doesn't need its own function

no, it doesn't... can just use ranArr in place


Can't see map tiles

Subject: Can't see map tiles
Description:
Click on "Map Search"
Results:
I do not see map (although I see marks on the map: clusters, users, etc.). The problem is that api.mapbox.com returns "403 Forbidden" for all requests. (XHRGEThttps://api.mapbox.com/v4/mapbox.mapbox-streets-v8,mapbox.mapbox-terrain-v2.json?secure&access_token=pk.eyJ1IjoiY291Y2hlcnMiLCJhIjoiY2tpYzVnaXA0MGdmejJ4bGFrdTdrNjA0NCJ9.1VAPRbE6a_kwGw1kucppJw
[HTTP/1.1 403 Forbidden 101ms])
Actually, that's not couchers.org bug, cause I have the same behavior on other sites/programs (e.g. TrustRoots). But it would be great if Couchers has support for another tile provider!
Backend version: develop-ea44d455
Frontend version: develop-ea44d455
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0
Page: https://app.couchers.org/search?#loc=1.78/28.5/12.8
User: owl (8903)

This is probably due to an adblocker or tracking blocker that obfuscates/removes the "Origin" or "Referer" header(s). I'll forward to support.


License?

Hello: what would be the license for this code and hmark?
Thank you!

Hi @pombredanne, both repositories are released under the MIT license.
Thanks.
-Seulbae


php artisan twill:dev not watching changes on custom components

Hi, after a bit of poking, I successfully ran php artisan twill:dev from a docker container ( issue #584 )  the odd thing now is that despite it's compiling successfully all changes, it does not 'sense' any changes and I have to run again php artisan twill:dev in order to reload changes.
My work directory is ./resources/assets/js/components
Is there anything I'm not doing right?

Same problem here, php artisan twill:dev doesnt detect files changes while running inside docker container


add tooltip for settings

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The code follows the code style and conventions of this project.
[ ] The change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

Description of the change

add tooltip for settings

Motivation for the change

fix #579

@maple10001,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Locale request: da-DK

Which locale do you wish to add?
First check if your locale has already been requested. If so, go and add an emoji to that request to show your support.
For new requests, write the locale identifier in the subject after the colon.
Example: "Locale request: nb-NO".
We use BCP-47 with region subtags, see "IETF language tag".
Maintainer
Sanity will bootstrap and keep the locale updated using AI. We would like human contributors to help maintain the locales by improving them and/or reviewing pull requests from the AI and from other contributors as they come in. Check the box below if you want to be added as a maintainer of this locale. As a maintainer you will be automatically added as reviewer to future PRs that improve it.
If you are not the author of this issue, but would still like to be added as a maintainer, please add a comment to the thread.

[x] I want to be added as maintainer

Happy to support a Danish language pack, but we'll need someone to step us as a maintainer first - let us know if you're interested by commenting here!

@rexxars Im very interested

@rexxars @Kasper-Buchholtz   I'm also very interested in a Danish language pack, would be awesome if we could make it happen.
in case you need help with translating, im ready to help.

Please have a look at #463 for the initial AI-generated translation!

<EMAIL_ADDRESS>has the first automated translations


Help research what needs to be documented for what needs to be done to support SPI in each third party

Closing out as already complete https://support.ethyca.com/docs/how-to-configure-consent-in-google-tag-manager-gtm


Operator behaving differently running in cluster compared to out of cluster

Type of question

General operator-related help

Question
I am creating an operator to work with a CI/CD system. When I run it locally, it creates pods as expected. But when I deploy it to the cluster, it fails to check if a pod has already been created and will create multiple pods of the same "task".
Pipeline Spec:

Locally using make run:

In Cluster after pushing docker image and using make deploy:

What did you do?

To run individual tasks in a pipeline, I wrote a function which uses DFS to go through a tree data structure and checks the status of child pods before generating a new pod for that
The operator then loops over the generated list of pods and creates them in the cluster.

What did you expect to see?

The correct amount of pods being created.
What did you see instead? Under which circumstances?

Multiple pods being created and the pipeline not being validated.
Environment
Operator type:

/language go

Kubernetes cluster type:

$ operator-sdk version
1.33
$ go version
1.22
$ kubectl version
1.29
Additional context

Current branch for bug: https://github.com/coillteoir/bramble/tree/develop
In the execution group of controllers.
It occurs in both Kind and MiniKube

Im unsure of where to start with this issue, in particular if it's a bug in my code or from an upstream library such as controller-runtime.

So, reconciliation loops aren't really run in a deterministic manner - multiple controllers might pick up the same event and try to reconcile it, which is why it's always a good idea to check the state of the system before trying to modify it. It looks like you're just always firing off this function that tries to create a bunch of pods.
Not sure why you're experiencing different behavior on/off cluster, though. It might just be due to the increased latency meaning you're getting less controller loops firing or something.

Just curious, is the controller runtime synchronous or does it use goroutines under the hood? And if it does, would ther be a way to force my reconcile loop to wait for the controller to finish provisioning/getting resources before continuing?

/close


Fix coalescing send data

There's an interesting tidbit of information in the documentation of dedup_by:

The elements are passed in opposite order from their order in the slice, so if same_bucket(a, b) returns true, a is removed.

So, we were adding the data to a.tracer_payloads ... and then a gets dropped. Awesome, we just successfully dropped everything but one value.
On top of that, have a size restriction for the possible payload size, to ensure we'll never exceed it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.81%. Comparing base (f63cff5) to head (43af559).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   67.76%   67.81%   +0.05%
==========================================
  Files         193      193
  Lines       24476    24512      +36
==========================================
+ Hits        16585    16623      +38
+ Misses       7891     7889       -2

Components
Coverage Δ

crashtracker
19.34% <ø> (ø)

datadog-alloc
98.76% <ø> (ø)

data-pipeline
51.45% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
85.24% <ø> (ø)

ddcommon-ffi
74.93% <ø> (ø)

ddtelemetry
56.09% <ø> (ø)

ipc
81.27% <ø> (ø)

profiling
78.09% <ø> (ø)

profiling-ffi
60.05% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
36.58% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
69.12% <ø> (ø)

trace-normalization
97.79% <ø> (ø)

trace-obfuscation
95.74% <ø> (ø)

trace-protobuf
30.76% <ø> (ø)

trace-utils
79.66% <100.00%> (+1.36%)
:arrow_up:


TreeView Control is broken after updating to v3.7.0

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
v3.7.0
Expected / Desired Behavior / Question
The tree should load
Observed Behavior
Even when using the exact code from the example (https://pnp.github.io/sp-dev-fx-controls-react/controls/TreeView), the TreeView fails to load with the following error:

Thank you @djmrky for reporting this one.
The fix has been merged. It is available in the beta and will be included in the next release.

@AJIXuMuK cool, that's great news


CORGI-527 json decode error

Fixes various JSONDecodeErrors in manifest generation:

Newline in component name
Trailing backslash in PYPI component version
Special characters in component copyright_text

Where possible I've used escapejs template tag to prevent future occurances of this issue from breaking manifest generation. However we can't keep newline characters in a component name as that field is used in the documentNamespace field which has to be on a single line.

@RedHatProductSecurity/corgi-devs please review. This also come with a couple of data migration scripts attached to CORGI-527.

I got one JSONDecodeError for a devtools stream in my dev environment after applying the changes from this PR and data migrations. See CORGI-542


[Flake] Integration tests only retry idempotent operations

The client libraries, by design, only retry idempotent operations. In the integration tests this can be a problem, as a transient failure breaks the test and the build.  I think this is what happened here:
https://source.cloud.google.com/results/invocations/39ae0dad-4bf4-4efc-aa4e-35e8930cee71/targets
FAIL: //google/cloud/bigtable/examples:table_admin_iam_policy_snippets (see /Volumes/BuildData/tmpfs/tmp/bazel/execroot/com_github_googleapis_google_cloud_cpp/bazel-out/darwin-fastbuild/testlogs/google/cloud/bigtable/examples/table_admin_iam_policy_snippets/test.log)
INFO: From Testing //google/cloud/bigtable/examples:table_admin_iam_policy_snippets:
==================== Test output for //google/cloud/bigtable/examples:table_admin_iam_policy_snippets:

Cleaning up old tables

Running GetIamPolicy() example
The IAM Policy for table-admin-snippets-1588544661-irhphmoz is
etag: "\000 \001"

Running SetIamPolicy() example
The IAM Policy for table-admin-snippets-1588544661-irhphmoz is
version: 1
etag: "\007\005\244\305\340x\227\n"
bindings {
  role: "roles/bigtable.user"
  members<EMAIL_ADDRESS>}

Running TestIamPermissions() example
The current user has the following permissions [bigtable.tables.get]

Running AsyncGetIamPolicy() example
IamPolicy details : version: 1
etag: "\007\005\244\305\340x\227\n"
bindings {
  role: "roles/bigtable.user"
  members<EMAIL_ADDRESS>}

Running AsyncSetIamPolicy() example
Waiting for IAM policy update to complete .Standard C++ exception raised: AsyncSetIamPolicynon-idempotent operation failed, last error=Error while setting IAM Policy for projects/cloud-cpp-testing-resources/instances/test-instance/tables/table-admin-snippets-1588544661-irhphmoz
================================================================================

Though the error message is not super clear.

Here is another one:
https://source.cloud.google.com/results/invocations/dac65eb9-ed4b-4575-827a-8678c2d010e4/targets

Addressed the "CreateDatabase fails with UNAVAILABLE" issue in #5395.
The "exception raised: AsyncSetIamPolicynon-idempotent operation failed, last error=Error while setting IAM Policy" flake hasn't been re-reported since May 5 (182 days), so let's consider it stale.


Platform Contrast - ERROR - Attempting to register a platform which has already been registered

Current Behavior

When i've installed a different plugin to control the aqara network but is in contrast with the old one because based on the same script and using same platform. I've already tried to uninstall the single plugin, to uninstall homebridge and delete all the folders. I can't find the folders of plugins and i suppose they remain also after the uninstallation of homebridge because runningit after a fresh installation i also have the error about platofrm
Versions

Homebridge: v0.4.43
Node:       v8.9.1
OS:     MacOs

Configuration

if needed i can add

Homebridge Log / Command Output

[2018-6-24 21:46:24] Loaded config.json with 0 accessories and 4 platforms.
[2018-6-24 21:46:24] ---
[2018-6-24 21:46:25] Loaded plugin: homebridge-broadlink-rm
[2018-6-24 21:46:25] Registering platform 'homebridge-broadlink-rm.BroadlinkRM'
[2018-6-24 21:46:25] ---
[2018-6-24 21:46:25] Loaded plugin: homebridge-config-ui-x
[2018-6-24 21:46:25] Registering platform 'homebridge-config-ui-x.config'
[2018-6-24 21:46:25] ---
[2018-6-24 21:46:25] Loaded plugin: homebridge-mi-aqara
[2018-6-24 21:46:25] Registering platform 'homebridge-mi-aqara.MiAqaraPlatform'
[2018-6-24 21:46:25] ---
[2018-6-24 21:46:25] Loaded plugin: homebridge-mi-aqara-nightly

/usr/local/lib/node_modules/homebridge/lib/api.js:138
    throw new Error("Attempting to register a platform '" + fullName + "' which has already been registered!");
          ^
Error: Attempting to register a platform 'homebridge-mi-aqara.MiAqaraPlatform' which has already been registered!
    at API.registerPlatform (/usr/local/lib/node_modules/homebridge/lib/api.js:138:11)
    at Plugin.module.exports [as initializer] (/usr/local/lib/node_modules/homebridge-mi-aqara-nightly/index.js:31:16)
    at Server.<anonymous> (/usr/local/lib/node_modules/homebridge/lib/server.js:165:14)
    at Array.forEach (<anonymous>)
    at Server._loadPlugins (/usr/local/lib/node_modules/homebridge/lib/server.js:139:22)
    at new Server (/usr/local/lib/node_modules/homebridge/lib/server.js:57:24)
    at module.exports (/usr/local/lib/node_modules/homebridge/lib/cli.js:26:16)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
    at Module._compile (module.js:635:30)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Function.Module.runMain (module.js:676:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

Each plugin installs separately from homebridge and from other plugins, to /usr/local/lib/node_modules.  Apparently both Aqara plugins use the same name to register with homebridge, causing the error.  Uninstall the plugin by sudo npm -g un homebridge-mi-aqara, or simply sudo rm -r /usr/local/lib/node_modules/homebridge-mi-aqara.  Alternatively, you can disable the plugin from loading in config.json, see #1880 (make sure to scroll down).


Set line height in Accordion header

Description

Right now, the line height is not set in the accordion header, meaning that the component might look different when in use than it does in storybook. The component shouldn't have an arbitrary look depending on some unknown value. Thus, we set the line-height in the component.
It is set to 16 because that is what the component was designed with.

Codecov Report
Base: 97.41% // Head: 97.41% // No change to project coverage :thumbsup:

Coverage data is based on head (fb125c8) compared to base (0351186).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   97.41%   97.41%
=======================================
  Files          48       48
  Lines         503      503
  Branches      130      130
=======================================
  Hits          490      490
  Misses         13       13

Impacted Files
Coverage Δ

src/components/Checkbox/Checkbox.tsx
100.00% <100.00%> (ø)

src/components/CheckboxGroup/CheckboxGroup.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Include omnipay_transaction_id in hidden fields for the DPM form.

This was missing from a previous PR. Without it, the transaction ID does not get sent to OmniPay in the DPM form, and so is not accessible in the notify handler using $request->getTransactionId() - assuming DPMResponse::getRedirectData() is used to get all the hidden fields for use on the DPM form.
The current workaround is to make the field hidden manually:
$gateway = Omnipay::create('AuthorizeNet_DPM');
$request = $gateway->purchase($details);
$response = $request->send();
$response->hideField('omnipay_transaction_id');

then all the data returned by this method should be put into the DPM form as hidden fields.
$response->getRedirectData();

In addition, the transaction ID is still being put into the invoiceNumber field - but don't rely on this long term - it ain't an invoice number.
More details and some tests to come. Just throwing this PR in as a placeholder, to come back to possibly in a few days.

Just as some background to this: DPM involves creating a form in your own site, which is then POSTed direct to Authorize.Net. The idea here is to give the OmniPay request object all the usual stuff, in the usual way, then after send() your application asks the response object, "tell me what all the hidden fields are that I need to add to my form to get this transaction request to work". The application should, in theory, not have to know what those fields are named - OmniPay knows that and just handles it for you. It would be nice to find a way to extend this idea more generically to all the drivers that involve a form on your own site and some fields that need to be named according to what the end gateway requires.

Is this still valid to merge @judgej ?

Ooh, yes. Without this the transaction ID could appear as a non-hidden field in the DPM payment POST form. I wondered why I wasn't seeing that problem on my production sites, and realised I had this to do the same thing just before rendering the payment form:
...
                    // The payment gateway driver.
                    $request = $gateway->purchase($auth_details);

                    // Send the details to OmniPay to get the next action and data for the form.
                    $response = $request->send();

                    // Set the transactino ID custom field as a hidden field in the payment form.
                    $response->hideField('omnipay_transaction_id');

                    // The initial details for the form are available from the OmniPay driver response.
                    $default_form_details = $response->getVisibleData();
...

Just as some background, the DPM message gives you all the fields that need to go into the payment form that is POSTed direct to Authorize.Net. The fields are in two groups: hidden and non-hidden. The non-hidden fields can be changed by the user.
Allowing the user to change fields in this form is optional - so any non-hidden field can be moved to the hidden list. This is what my workaround in production did, but is what adding this field to the hidden list in this PR does by default.
The rendering of the fields is up to the website, but this list of fields conveniently just gives you the list of fields that the user can be shown and must be hidden. Of course, anyone looking at the browser source can change any of these fields, whether hidden or not, so the application still needs to check all the transaction details at the end to make sure fields it chose to hide have not actually been changed by the end user with debug tools.


Move support to v2.7.x and v3.1.0

Signed-off-by: Pablo Garrido<EMAIL_ADDRESS>

@pablogs9 as I said here, to get this working we would need to update some points:

USB-Serial now used device tree to get enabled, but applying this update will break the compatibillity with previous Zephyr releases;
Wait ros2 accept the rcuitls patch, for the posix timer implementation and update the commit used by libmicroros, currently I created a diff and patching locally and wrote this instruction in the app I'm working on top of this module.

Also I'm taking some time to refactor the zephyr transports for serial to use the up to date DT macros instead of using device labels, this is compatible across zephyr releases and scalable as long Zephyr evolves, probably will push this PR today or tomorrow.

Sure, I will take some time to look into :)

@mergify backport humble galactic foxy

FYI @pablogs9 @uLipe , we need to change zephyr include paths for v.3.1.0 and beyond:
https://github.com/zephyrproject-rtos/zephyr/releases/tag/zephyr-v3.1.0:

All Zephyr public headers have been moved to include/zephyr, meaning they
need to be prefixed with <zephyr/...> when included. Because this change
can potentially break many applications or libraries,
:kconfig:option:CONFIG_LEGACY_INCLUDE_PATH is provided to allow using the
old include path. This option is now enabled by default to allow a smooth
transition. In order to facilitate the migration to the new include prefix, a
script to automate the process is also provided:
:zephyr_file:scripts/utils/migrate_includes.py.

Yes, altough this could be done in other PR, the kconfig option for legacy
includes is only disabled to run apps under twister which is used to do
unit tests for zephyr components.
Le mer. 17 août 2022 à 07:45, Antonio Cuadros @.***> a
écrit :

FYI @pablogs9 https://github.com/pablogs9 @uLipe
https://github.com/uLipe , we need to change zephyr include paths for
v.3.1.0 and beyond:
https://github.com/zephyrproject-rtos/zephyr/releases/tag/zephyr-v3.1.0:
All Zephyr public headers have been moved to include/zephyr, meaning they
need to be prefixed with <zephyr/...> when included. Because this change
can potentially break many applications or libraries,
:kconfig:option:CONFIG_LEGACY_INCLUDE_PATH is provided to allow using the
old include path. This option is now enabled by default to allow a smooth
transition. In order to facilitate the migration to the new include
prefix, a
script to automate the process is also provided:
:zephyr_file:scripts/utils/migrate_includes.py.
—
Reply to this email directly, view it on GitHub
https://github.com/micro-ROS/micro_ros_zephyr_module/pull/64#issuecomment-1217844953,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNWX5OPS7P4U4F7AZ33M3LVZS7D5ANCNFSM54367PPA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Do we have any define in the Zephyr build system indicating the version so we can conditionally include the correct header?


Fixing the DAGRUN_TIMEOUT check

This is a fix for https://github.com/airbnb/airflow/issues/990

what if you backfill or clear something in the past? timeouts are better when measured against the start time than the run time.


api-01-local-function / local api function call

[x] objective.json
[x] description.md
[x] validator.js
[x] walkthrough.md

For more details, reference the original objective planning doc.
Objective outline

This is the first step in learning how to craft the Divination spell
Spells are crafted by passing data around?
Intro APIs as a local function call of String.replaceAll()
Write a QuestIDE function that turns all instance of "word1" with "word2"

What is our divination/API themed phrase and keywords to replace?
Probably we want a few different phrases as test cases to avoid hard coding

@rmkubik @nmadadair Looks like if we want to use the String.replaceAll method, we'd need to upgrade Electron. It wasn't added until node 15, and the Electron version TQ is on uses node 12.13.0. Alternatively, we could always use another method or write our own replaceAll implementation to avoid the trouble

Writing our own replaceAll might be interesting if that import can be explicit in the QuestIDE code, as a illustration that the functions a library author exposes are also an API. To fit with the spell construction theming, maybe they're importing from spellbook, and any helper functions we write (for example, later on we may have some helpers to interact with the APIs we're creating for this) also go in spellbook.

Regarding the objective outline:

Spells are crafted by passing strings around?

What is "spell" a metaphor for in the API Academy/what concept is it abstracting? My read is that it's quite a loose metaphor for a program that interacts with an API. If that's correct, we probably shouldn't tie it too strongly to a particular type of data. For example the web APIs are going to be returning JSON, and because Javascript is ~terrible~ interesting, sometimes things are strings when you don't expect them to be or not strings when you do expect them to be and we probably shouldn't invite learners to look too closely at that in this mission.

Yeah, I think that's fine! I just wanted to see a narrative idea of like "you write magical spells by passing data around" between different APIs.
Instead of Data Plumber you get to become a Data Magician.

I think I specifically wrote "string" there since plaintext web requests are "stringified" before you send them... But I think it's a good shout that thinking about them as "strings" is a bad thing to teach. They're just a bundled of ??? data that you need to interpret into something meaningful on either end of the request (like JSON or form data or gql).

What kind of writing content do we need for the spellbook? I've been putting together some notes on divination generally that could be used in these objectives. I could put together some short sentences/paragraphs on definitions of divination / types of divination methods / history of divination methods, etc. Does that form/content work for these objectives?

@nmadadair  Ah, in this context, the "spellbook" would be a programatic API!
For the actual text content that could be useful is something like a thematic incantation line (or a few lines). We would have the players run their function with these text lines as input.
I googled "poem incantation" and copied one that seemed interesting:

 Invoke, People of the Sea, invoke the poet, that he may
   compose a spell for you.
For I, the Druid, who set out letters in Ogham, I, who part
   combatants,
I will approach the rath of the Sidhe to seek a cunning poet
   that together we may concoct incantations.
I am a wind of the sea.

I think we'd want something like this, but programming and API themed. And then it would have words like "confusion" in it and we'd want to replaced them with "communication". Or "discord" replaced with "harmony". That sort of thing. Happy to help brainstorm on this one if this is a wild ask haha

@rmkubik Ah, this is very helpful. Let me draft up some API-themed poetry and get back to you and we can iterate together from there!

@nmadadair ah, i forgot to mention we want to try and make this the incanation of the "diviniation spell". So, theming it as like seeing, experiencing, viewing, hearing, etc. would make sense. The goal is to tie "this function parses a string" to the concept of creating a divination spell.

@rmkubik that's what I understood!

Divination Spell Incantation
Oh, great creators of The Cloud, let me apply
This divination spell, newly formed through a simple phrase,
Strung together thanks to a most helpful API,
That my requests may return the knowledge I seek
To open my mind to the tower’s supply
Of resources both clear and covert.
For the final door shall stay locked until I am able to scry
The programmable answers that will remove this haze
From my querent and magical eye.
@rmkubik Here's a draft!
I used the Magic 9 poetic form: ABACADABA

Any of the adjectives here could be replaced with other words! (simple / helpful / clear / covert / querent / magical)

@rmkubik

Can you investigate what it would take to actually import a library in our example code @MarvJohnson?
The only things I know we import are full on published NPM modules and library built ins... We could certainly think about publishing a module for this. Or doing a local import, but I don't know what our options are off the top of my head. It's important to check that any import works both when running it in the QuestIDE and via Validator Hack execution.
Currently, those 2 systems evaluate in different methods! So sometimes a thing will work in one, but not the other.

The QuestIDE depends on a runner that executes user code using the vm module. The runner does so by invoking the runInThisContext method, which runs the code in the current global context (i.e. the global context where the function is written).
The Validator Hack finds the validator.js file belonging to the active objective and runs that. The Validators that execute external user code (more specifically Javascript code) also use the vm module.
In both modes of code execution we could introduce an API by setting/appending the context the vm instance uses. This approach wouldn't work for python code (?which I'm not sure we're concerned about?), since we spawn a shell and execute the user's code using their python installation, instead of using vm.
One idea I have is to create a separate .js file, one that houses all of the possible members of the API that we'd want the user to have (we could default this to none, or even come up with a set of members that should always be available), and export that as an object. Then in the objective.json file of each objective, define which of those members should be made accessible through something like an api_members property. Lastly, just before we append the API members to either vm context, we prune the members that weren't defined in the objective.json file of the current objective. This would mean the context of existing objectives would be unaffected, and objectives where the api_members property was defined would have additional functionality made available.
Let me know what we think and if there are any ideas for better ways to do this!

I think twilio/twilioquest#901 is our fix for the last comment. Is that correct @MarvJohnson?

Yep! Went ahead and updated the original comment as well

This is done as of #55. Closing!


Allow agents to be run without a --branch tag

Currently, running agents with viv requires a --branch parameter. For example:
viv run ai_rd_triton_cumsum/main@531602ae79cec6f24bcc9936e9989eb94038cb09
 --yes --low_priority --name='example-runset'  --repo 'modular-public' --branch 'main' --commit '58ad4fb08809da0c70858e84d81668c8c5eb9fac' --agent_settings_pack 't_context_and_usage_awarep_claude_legacy_1xc3ogd_always_savea'

Returns the error 'agentCommitId is set but agentBranch is not'.
Our current YAML file plan for specs does not require branch, but since it's required in viv, our options are:

Require users to specify branch on their agent implementations in the YAML file that specifies a measurement.
Remove the requirement that agentBranch must be set if agentCommitId is set. The relevant code is here

In practice, the agent is uniquely identified by the commit. So it feels pretty reasonable me to relax this requirement. Lucas in his comment here is fine with either solution, but would prefer dropping branch as a requirement.
Making the change in input validation is pretty easy (it's just deleting code), but I'm wondering if the invariant that "branch exists if commit id exists" is relied on in other parts of the codebase, for some reason. Guidance here would be helpful, or happy to dig in more and investigate this question if it's helpful.

Notes from scanning references to agentBranch in the Vivaria code:

dbRuns.getAllAgents assumes that all runs with a non-null agentRepoName have a non-null agentBranch. I don't think that should block us from dropping this criterion. We could change this function to exclude runs with a null agentBranch.
Otherwise I think agentBranch is used for

Displaying information about an agent in the UI, and
Figuring out which agent commit to use when a user branches from an existing run with the "use latest agent commit from branch" checkbox enabled

Sami added a TODO asking if we can infer the branch name from

Overall I think we could leave agentBranch null if the user doesn't specify it, with a small change to dbRuns.getAllAgents, and maybe some UI changes to handle agentBranch being null when agentRepoName is not null.
Or we could infer the branch name from the commit. That seems possible in most cases -- most non-main commits probably belong to one branch. Except if someone's created a bunch of branches/PRs stacked on top of one another.


Not working in iOS 8

FPPopover is not working in iOS 8. Please fix it for iOS 8.

Hi to everybody.
@jneiluj  your solution is perfect..!! thanks.
my problem was, when i open view controller from tabbar using segue, the popover not show.. with your solution i solve it...

Hi to everybody.
@jneiluj your solution is works for me
thanks

@jneiluj thx!

@jneiluj thank so much. I hope this issue will be updated soon!

In FPPopoverController.m
-(void)presentPopoverFromPoint:(CGPoint)fromPoint
I replaced:
_parentView = [_window.subviews objectAtIndex:0];
with
_parentView = [_window.subviews lastObject];
this is nice!!!


Bad Request Error - USDC

Got a Bad Request Error since adding USDC-Coin
Log says:
16:57:08  1> Refreshing account Coinbase Pro.
1> Web Banking Engine: Using user-supplied extension Coinbase Pro.lua version 1.00.
1> Protocol version: Web Scraping
1> Server address: https://api.pro.coinbase.com
1> Getting portfolio for Coinbase Pro...
1> Sending: GET https://api.pro.coinbase.com/accounts
1> HTTPS response: Bad Request
1> The server responded with the error message: Bad Request. Retrying...
1> Sending: GET https://api.pro.coinbase.com/accounts
1> HTTPS response: Bad Request
1> The API server of your bank responded with the error message: »Bad Request«  Please try again later or contact the support of your bank with this error message.

A new coin was added, this was causing the issues. Now that the coin is active, there is another issue:
          1> Sending: GET https://api.pro.coinbase.com/products/USDC-EUR/ticker
          1> The server responded with the error message: Not Found. Retrying...
          1> Sending: GET https://api.pro.coinbase.com/products/USDC-EUR/ticker

Apparently by default the plugin will try to fetch the EUR value of this coin. There will never be a EUR value since it's a simple exchange token for USD to USDC. It can be used to buy BAT (Basic Attention Token). There is no FIAT trade available for either BAT or USDC.

There will never be a EUR value since it's a simple exchange token for USD to USDC.
Says who? Even Coinbase itself trades USDC for EUR. Until there is an equivalent for that in Coinbase Pro (and in the ticker API) I don't think there is much I can do...

Probably true, in the meantime I have installed the BETA and disabled extension signature checks. For I am just skipping both USDC and BAT in the RefreshAccount function. Works again that way at least.

Thank you for the workaround. Unfortunately I'm not able to install the BETA app because I bought it at the MacAppStore.

@tommodore See last paragraph on this comment, worked for me too: https://github.com/leoschweizer/moneymoney-coinbase-pro/issues/4#issuecomment-411718269

I'm also wondering why you two are experiencing this issue, while I am not? USDC and BAT do not even show up in my balance, and thus this still does not crash for me.

I really can't tell. For me, the ticker request for USDC failed and trying it now it still doesn't serve any data:
https://api.pro.coinbase.com/products/USDC-EUR/ticker
Maybe it makes sense to be more specific on that request and check for anything non-200 or skip specifically any 404s? That would allow to fetch data but not any amount/value to it.
I don't really know what the best approach would be, especially since you don't even seem to be affected for some reason.

Well in theory it could be built such that if some kind of error occurs, the respective position in your balance is not returned at all. But I doubt that this does the right thing for moneymoney. Imagine that there is some kind of general API outage (and this happens quite often), then the extension would not return any balances to moneymoney - your balance would thus show up empty. Not what we want.
We could also only not return any fiat value if that part fails. But then the position in your balance shows up as 0EUR, and thus messes up your history. Also not what we want.
We could also revert back to using the Coinbase (not Pro) API to do the fiat conversion - but you probably remember that we switched from there since we had the problem the other way around ;)
So, this is not really easy to fix.

I think we should look at the response json if the response is {"message":"NotFound"} than we should ignore that fiat, cause it means it's not supported right now.

@qoomon I gave that a try but I am not too familiar with LUA. Somehow the HTTP call is simply aborted and doesn’t return anything if the status code is not 200. Maybe it’s possible to enforce returning this but I haven’t found out how yet.

@TheSerapher you can find the documentation of the Connection stuff here https://moneymoney-app.com/api/webbanking/
The request method does return a lot more (content, charset, mimeType, filename, headers) than is currently being evaluated (only content). I could imagine that an HTTP status code could be determined from the headers result.

@leoschweizer That's what I tried out before simply skipping entries. It didn't work since it throws an exception and never gets to parse the headers of the request:
          1> Sending: GET https://api.pro.coinbase.com/products/USDC-EUR/ticker
          1> The server responded with the error message: Not Found. Retrying...
          1> Sending: GET https://api.pro.coinbase.com/products/USDC-EUR/ticker
21:15:49  1> HTTPS response: Not Found
          1> The server of your bank responded with an internal error. Please try again later.

I'd think this may be an issue with the implementation in MoneyMoney. The log also records an internal error, which isn't really true since the actual response is a 404:
$ curl -I https://api.pro.coinbase.com/products/USDC-EUR/ticker
HTTP/2 404

So unless we can get this patched and check for response codes other than 200 ourselves, I don't see a clean way to catch lacking API implementations :-/

What a funny coincidence .. I was playing around with it trying to get the infos above, they just added ZCASH with code ZEC which is of course not working fully yet 😃 One more I had to add to my skip list.

I think a have an idea you can just ship your own http lib by doing the following

create a folder name it Coinbase Pro coresbonding to lua script Coinbase Pro.lua
put all dependencies in that folder
use them by require them like this

-- libPath is set to <script name>/
local libPath = debug.getinfo(1).short_src:match("(.*).lua") .. "/"
-- load arbitrary scripts from dependency folder
local mymodule = require(libPath .. "mymodule")
-- use the module
mymodule.foo()

in conclusion you could ship arbitrary dependencies for example the module "socket.http"

Closed the old PR, made a new one specifically fixing the issue for the original code. Feel free to review, merge and hopefully close this issue here!

I just got an answer from the moneymoney support how to do it the right way
you have to set the Accept header to application/json then no exception is thrown, even if the api response code is 404. e.g.
local headers = {}
headers["Accept"] = "application/json"
local content = Connection():request("GET", url, nil, nil, headers)
return JSON(content):dictionary()

The updated and signed extension is now available. Thanks @TheSerapher for the good work!


Namespaces

Hey, first for all thx for your library. Can you add namespaces to your classes? Cuz class name "Lists", for example, its very common name, which use in many legacy projects.

Thanks for the suggestion. I will look into Implementing Namespaces as soon as I get an opportunity to do so.

@damianua I'm looking at implementing an autoloading friendly version here: https://github.com/Jhut89/Mailchimp-API-3.0-PHP/tree/AutoLoading/NameSpacing

I will likely PR this against master at some point in the near future.

Addressed in 3.0.0


Unable to connect Redis with SSL over Route53  in AWS.

I have created Redis5.0.0 cluster in AWS with in-transit and auth enabled.  I also have entries in Route53 that point to Redis cluster.
When I use Route53 URL, I am unable to connect to redis cluster. When I use direct end points of Redis cluster, connection is successful.
Issue I identified: While using Route53 URL, certificated were issued by different host as compared to Route53 URL. Thus, certificate could not be validated.
How do we disable SSL certificate verification?

Team - is there an update?

Set Config.sslEnableEndpointIdentification = false


Updated metadata to support KSP 1.2

A new release which supports KSP 1.2 is available on my GitHub

@nimobeeren change find to this:
"find"       : "GameData/MusicMute",

LGTM


508 compliance - Fix the buttons and tabs in each app popup modal

Fix the top nav in each app popup modal

Should be included in 449 push.

Passed in FF and CHROME.  Create bug for IE fails.

In IE , it rambles on and on for the pop up modal navigation buttons.

ozone-development/ozp-center#471 - Says we are no longer supporting IE for 508


xlsx file corrupted after download with Angular2

Hi,
I'm working with Angular 2 on frontend and Express on backend.
I've succeeded in creating a workbook with js-xlsx on backend.
var wopts = {showGridLines: false};

XLSX.writeFile(wb, 'output.xlsx', wopts);

res.status(201).send();

With code above, I could find the created file in backend folder and successfully open it.
Now I'd like to allow client side to download this file.
I modified my backend code as following :
var wopts = {
    bookType: 'xlsx',
    bookSST: false,
    type: 'buffer',
    showGridLines: false
};

var wbout = XLSX.write(wb, wopts);

res.end(wbout);

And on Angular 2 frontend, I have following code with FileSaver.js injected :
var headers = new Headers();

headers.append('Content-Type', 'application/json');

headers.append('responseType', 'arraybuffer');

this.authHttp.post('http://localhost:3001/createExcel', body, { headers: headers })
  .subscribe(
  response => {
    saveAs(new Blob([response._body], { type: "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" }), "output.xlsx");
  },
  error => {
    alert(error.text());
    console.log(error.text());
  }
  );

Downloading is working well, but I can not manage to open it, with information :

We found a problem with some content in 'output.xlsx'. Do you want us to try to recover as much as we can? If you trust the source of this workbook, click Yes.

Then

The file is corrupt and cannot be opened.

Any help will be appreciated, thanks!

I made it working by creating xlsx file with js-xlsx on client side and then directly download it, without any interaction with the server.

Could you please share your Angular 2 code. I am getting some really weird error when i try to write something on the file.

@zajjoseph Can you share your client side code for generating a xls file? Thanks.

@junaidinam @zh-wowtv
`var wopts = { bookType: 'xlsx', bookSST: false, type: 'binary', showGridLines: false };
var wbout = XLSX.write(wb, wopts);

saveAs(new Blob([this.s2ab(wbout)], { type: '' }), 'test.xlsx');

s2ab(s: any) {
var buf = new ArrayBuffer(s.length);
var view = new Uint8Array(buf);
for (var i = 0; i !== s.length; ++i) view[i] = s.charCodeAt(i) & 0xFF;
return buf;
}`

Thanks @zajjoseph . It worked for me in angular 4.


Add option to exclude proliferator production from factory tree [DSP]

I use proliferator in all my factories, and I love how Factoriolab can do all the calculations with proliferator! But the way Factoriolab works can be confusing as it includes the cost of producing proliferator in the factory report. That means that the coal required can be much higher than what is actually required for the product I am producing. And if the product shares some ingredients like energetic graphite or diamonds with proliferator then they're brought to the top rather than being nested inside the product tree.
A simple request: add a check box to exclude proliferator production from the factory. If it's selected then act like there's an infinite supply of proliferator, so that no ingredients or power need to be consumed to produce it. If it's not selected then the coal, nanotubes etc and power for producing proliferator would continue to be calculated like at present.

If I understand your request correctly, this feature actually already exists! Try clicking on the proliferator icon in the list view, it will 'ignore' it.

Oh yeah, that works great! Thanks!


lib.lists.sortOn: init

Description of changes
A more efficient sort in some cases, and often convenient.
This exposes lib.lists.sortOn immediately on lib, because it is a sibling of sort, which is already present there.
Omitting it would lead to more confusion, and worse outcomes.
There's no confusion about the types sort or sortOn operate on.
Haskell agrees about the type for sortOn, and it is in its base.
It is not prematurely generalized to allow overriding <. This would be rare, and we basically have map << sort << map for that.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I've edited the doc quite a bit, but kept the phrase about allocation. I think it's helpful by giving a hint about what it does.
I've applied the other suggestions.


Remove ActiveSupport::Dependencies.reference

This was deleted from Rails: https://github.com/rails/rails/commit/14d4edd7c3b06e82e1fcef54fa0b4453315c35fd, which means Devise currently crashes when run against Rails main.
As far as I can tell, it was meant to add a performance boost at some point in the past but doesn't seem to do anything useful these days.
I also updated CI to run against the Rails main branch.
cc @fxn

Thanks @ghiculescu ❤.

What's the policy on merging these kinds of things? I am spinning up a new project and wanted to just start on rails 7 since the project won't launch for a bit anyway.

@mattrasband The policy is basically that I haven't been able to look into anything here recently 🙈 (personal and work stuff), but I should have some time in the coming days and will take a better look. In the meantime feel free to use this PR branch directly.
@ghiculescu appreciate the work on this one.

No worries @carlosantoniodasilva - thanks for the great work!

Hey folks, thanks for being on top of this. Just want to add a data point that I encountered the same issue today. I will keep an eye out on this thread for now but I really appreciate all of your time here.

This is now on master, thanks again.
Side note: there's one warning triggered by the tests that I have to look into, I think it's Rails related, I'll circle back on it.

With Rails 7.0.0 final out, would it be possible to get a devise release that has this in it?

v4.8.1 was released just this morning. https://github.com/heartcombo/devise/commit/43800b4b8550d1249ab049a94ee7c16e243551a1

Thanks @carlosantoniodasilva 🙏


Modrinth Support

Post this mod on modrinth kthxbye

I have no interest or desire to do this at present.

I have no interest or desire to do this at present.

Is there a particular reason for this, it just allows access to the mod outside of the Overwolf shithole

No, it doesn't. My mods are uploaded to the GitHub releases and allow third party downloads from CurseForge, uploading to modrinth is just a make work project which I have no interest in pursuing at present.


fix: enable cross-compilation to android from macos

Previously we were blocked on on lack of android SDK, but justin pointed me at:
https://github.com/tadfisher/android-nixpkgs
which should do the job.

I was successfully able to run the following from my m1 mac from the nix develop --ignore-environment .#cross shell:
cargo check -p fedimint-client-legacy --target aarch64-linux-android
cargo check -p fedimint-client-legacy --target x86_64-linux-android
cargo check -p fedimint-client-legacy --target armv7-linux-androideabi

🎉

Works for me too

To be clear, this shouldn't change anything for you unless you're compiling from MacOS targeting Android

@justinmoon We switch to new toolchain for Linux users as well, so there is a chance something would broke on Linux.


LunatriusCore Crash - 1.8, Win8, No mods

Mod version: <IP_ADDRESS>
Forge version: <IP_ADDRESS>2
Operating system: Windows 8
Crash report: http://pastebin.com/BSpCW3gK
Notes: Tried downloading from multiple sources provided on the forums, no luck with any version. Tried with a fresh Forge install with no other mods, still no success. Forge ran fine before adding the mod in.

Already fixed in f3cecbf5dff19e2dab83e245fe203650b2bb2e7e for 1.8.8. For 1.8 set B:replaceInGameConfig=false in the config file.


Add constants for demosaic pack interpolation

Fixes #44

Coverage remained the same at 100.0% when pulling 2800c8cf0c7abd9d5523834130552dec72c35394 on SamWhited:demosaic_pack into 871a9ff119ab203399075fa9f57a8ed89d519312 on photoshell:master.

Coverage remained the same at 100.0% when pulling 2800c8cf0c7abd9d5523834130552dec72c35394 on SamWhited:demosaic_pack into 871a9ff119ab203399075fa9f57a8ed89d519312 on photoshell:master.


cmd/compile, x/build/cmd/relui: update compiler's PGO profile as part of rc1 relui flow

CL https://golang.org/cl/451292 adds a default profile of the compiler, so we can build the compiler with PGO. As the compiler's source code evolves, we may want to periodically update the profile.
cc @prattmic @aclements

We discussed this in the release team meeting today. The plan is to add this as a relui step, to be performed as part of creating rc1. We can also run the step as a one-off if necessary (e.g., after any major compiler refactoring).
Ideally we can shrink the profile a little.  On the one hand it's not very necessary, but on the other it might be best to strike while the iron is hot.

Ideally we can shrink the profile a little

When I did it I put GOROOT in /tmp so the file paths are short. We could probably also trim cold nodes from the profile to reduce size.

@cherrymui With CL 587195 submitted now, do you expect we might want to do another update before RC 1? When we're confident there's nothing more to do for Go 1.23 milestone, let's move this to the next. Thanks.
At this point it might help to separate out work on making relui do this automatically into a dedicated x/build/cmd/relui issue, since that can happen independently of the Go release cycle.

Currently I'm not expecting another update, but I can doublecheck before the RC, in case there are some more changes in the compiler.


add github actions for coding standard

Thanks for participating 😄, we'll look into it and get back to you soon.

Seems not be working until now, so I also wanted to check if I have some time, but feel free to if you're able to.


FlutterView in io.flutter.view has been deprecated

:\src\flutter.pub-cache\hosted\pub.dartlang.org\flutter_inappwebview-5.4.3+7\android\src\main\java\com\pichillilorenzo\flutter_inappwebview\InAppWebViewFlutterPlugin.java:22: warning: [deprecation] FlutterView in io.flutter.view has been deprecated
import io.flutter.view.FlutterView;
^
C:\src\flutter.pub-cache\hosted\pub.dartlang.org\flutter_inappwebview-5.4.3+7\android\src\main\java\com\pichillilorenzo\flutter_inappwebview\MyCookieManager.java:5: warning: [deprecation] CookieSyncManager in android.webkit has been deprecated
import android.webkit.CookieSyncManager;
^
C:\src\flutter.pub-cache\hosted\pub.dartlang.org\flutter_inappwebview-5.4.3+7\android\src\main\java\com\pichillilorenzo\flutter_inappwebview\in_app_webview\InAppWebViewClient.java:12: warning: [deprecation] CookieSyncManager in android.webkit has been deprecated
import android.webkit.CookieSyncManager;
^

try by deleting the .gradle/caches
Also provide more info like packages you use and flutter doctor description

Hi @uemirhanselim, that message is coming from the flutter_inappwebview plugin and will need to be reported on their repo.
Closing from here as this is an issue from a third-party plugin.
Thank you


Allow multiple clients with the same CN to concurrently connect (duplicate-cn)

Allow duplicate-cn been enabled via the script

Can you elaborate on this?

If you set in the server config duplicate-cn, it's possible to connect via multiple clients with the same config. So if this configs are user-based, a user could connect via workstation and mobile at the same time. Otherwise, he need different configs or need to connect only via one client

From the man:

--duplicate-cn
Allow multiple clients with the same common name to concurrently connect. In the absence of this option, OpenVPN will disconnect a client instance upon connection of a new client having the same common name.

I agree that it would be a nice optional feature

i use -duplicate-cn on my ovpn config to multi login by using Angristan script.

Sir, Angistan. May l suggest an option to add username on your OpenVPN script.

This shouldn't be a Feature, but rather a Bug. If I generate multiple profiles, I expect them to work all at the same time, using different devices. I'd rather not have the duplicate-cn on my config to prevent multiple connections with identical profile. Would it be possible to, as @PHsXc  suggested, implement a way to differentiate the common name in newly generated profiles?
Thanks a lot

So would be fine, if everyone can decide on demand. From my point of view, profiles are used for users rather than devices, so if I have one user with multiple devices, I don't want to spread out profiles for each device as well. However, it's based on demand.

So would be fine, if everyone can decide on demand. From my point of view, profiles are used for users rather than devices, so if I have one user with multiple devices, I don't want to spread out profiles for each device as well. However, it's based on demand.

I would agree that if I give a user a profile, then it's up to the end user to install/use it on whatever device(s) they want and that all those devices can simultaneously connect.

So would be fine, if everyone can decide on demand. From my point of view, profiles are used for users rather than devices, so if I have one user with multiple devices, I don't want to spread out profiles for each device as well. However, it's based on demand.

I would agree that if I give a user a profile, then it's up to the end user to install/use it on whatever device(s) they want and that all those devices can simultaneously connect.

To me having an extra division user/device is better, in a way that you can revoke a single device certificate without bothering all the other devices too. But thats just my way of seeing it.

Please see https://serverfault.com/a/430048.
I don't agree with an option in the script but a FAQ entry.

Its common requirement. USER-A supposed to have multiple connection feature. If im a staff, I connect to my VPN for my official apps. The apps supposed to be work on my home-PC & home-Laptop even concurrently.

i use -duplicate-cn on my ovpn config to multi login by using Angristan script.

Hi, how did u achieved this. I also need USER-A should have multiple device connections concurrently.

It might be useful to ask this at initial runtime (first setup) as a Yes/No question: Would you like to allow duplicate clients to connect simultaneously (multiple connections from same configuration file)? Default will be No, selection Yes, if selected Yes append duplicate-cn to server.conf . Since it's pretty straight forward and possible for some use cases, it's trivial to add, I don't see a downside in adding it.


Server side pagination

I'm trying the same problem reported in #34. And I have the updated version of the angular

Likewise same issue here. The exporter does not seem to want to use a returned Promise, Observable, BehaviorSubject, anything that would have an async delay such as server-side delay. I have attached a minimal example here. The private getData() returning a Promise is meant to simulate the server-side paging with a 250ms response delay. The table display and paging display the 4 pages of 5 entries each fine. Exporting will only yield a CSV with the first page of 5 entries, however.
app.component.zip

I'm facing same issue, i think the exporter doesn't wait for any delay caused by subscription of server side hits

I'm slowly peeling back the onion on this one. It's multi-faceted. At the root (so far), cdk-table-exporter attempts to collect all pages of a paged datasource before exporting by subscribing to the data source's page change Observable. In mat-table-exporter, this boils down to the MatPaginator's page event. But in the typical server-side paging scenario, this page event signals the start of a page change, not the completion of it. Almost all server-side paging tutorials show how to subscribe to this page event to catch a page change request and request the appropriate page from the backend. But, like I mentioned, this is the start of a page change.
I am currently investigating possibly replacing cdk-table-exporter's subscribing to the page change observable, and to have it subscribe to the underlying Data Source's connect() Subject. This Subject is what ultimately sends data to the Table to be rendered, and thus would be a better indicator of when the data is actually received from the backend. But MatTableDataSource has its own potential issues there related to how it tries to handle paging itself. It basically causes multiple "new data" events to be emitted. Too long to explain here, but it also explains why most server-side paging examples also require you to reset the MatPaginator's length, pageIndex, and pageSize properties again in a setTimeout() /after/ you have set the MatTableDataSource's data property. It's the MatTableDataSource trying to be smarter than you.
I'll let everyone know if I figure out anything useful.

I'm having this issue too. It would be nice to have a feature to export single page even when the paginator is present

@sbalmos Did you or anyone figure it out?

Not really. Some attempts sort of worked but ultimately still broke. I have since moved on to another position and no longer maintain the app where this functionality was relevant.


Suggestion: Add enum for DOMException names, similar to HTTP_STATUS and METHOD enums

Is your feature request related to a problem? Please describe.
The poorly-named and overly-broad DOMException error subclass currently has no good way of distinguishing between its many possible causes. For example, when catching errors from the following, it would be useful to distinguish between AbortError (caused by aborting the controller manually) vs TimeoutError (caused by the timeout signal):
const controller = new AbortController();
onSomeEvent(() => controller.abort());
await fetch("...", {
  signal: AbortSignal.any([
    controller.signal,
    AbortSignal.timeout(TIMEOUT_MS),
  ]),
});

However, there's currently no ergonomic option for doing so:
err instanceof DOMException // true in both cases
err.name === 'TimeOutError' // false in both cases, because the capitalization should be "TimeoutError"

err.code === DOMException.TIMEOUT_ERR seems like it would be a great option, but maddeningly, the code property and its related static constants are deprecated.
Describe the solution you'd like
Something like this:
/**
 * `DOMException` error name values
 * @see {@link https://developer.mozilla.org/en-US/docs/Web/API/DOMException#error_names | DOMException § Error names (MDN)}
 */
export const DOM_EXCEPTION = {
  /** The operation timed out. */
  TimeoutError: "TimeoutError",
  /** The operation was aborted. */
  AbortError: "AbortError",
  // ...etc
};

Not sure which package it'd live in though.
Describe alternatives you've considered
N/A

However, there's currently no ergonomic option for doing so:
err instanceof DOMException // true in both cases
err.name === 'TimeOutError' // false in both cases, because the capitalization should be "TimeoutError"

I don't understand why someone would use err.name === "TimeOutError". They should use TimeoutError, with the correct casing. I'm not sure this is worth having an added module.

I don't understand why someone would use err.name === "TimeOutError"

Because it's an equally plausible-seeming capitalization and TS doesn't provide any hints for the possible values. You could equally use "TimeoutErr", "TIMEOUT_ERR", "TimeoutEror", etc. as examples.

I'm not sure this is worth having an added module.

Possibly not, seemed useful to me but maybe not worth the overhead. One other motivating factor that's more specific to std — with the removal of DeadlineError in https://github.com/denoland/std/commit/e561d3602644585983b5db8244e996835bc75a16, there's now no ergonomic way of discriminating on the error thrown by an expired deadline.

Possibly not, seemed useful to me but maybe not worth the overhead.

Yeah. While understand the reasoning behind the suggestion. The demand must be strong enough to justify the added overhead.

One other motivating factor that's more specific to std — with the removal of DeadlineError in e561d36, there's now no ergonomic way of discriminating on the error thrown by an expired deadline.

Well, an expired deadline() will now throw a TimeoutError DOMException, as one would expect. Previously, it didn't do that.

Published as a separate package: https://jsr.io/@li/is-dom-exception. I'll keep the issue open for a few more days but feel free to close if there's no demand for this in std.

I don't want to push the http scope towards a dom scope, but I do think it can be useful for people that works with dom libraries.
Mainly, maintainers who are writing isomorphic code that perform dom operations, and who also need to perform the testing too while verifying the type of error.
But idk, maybe @lionel-rowe and me would be the only two potential users 😆

I don't want to push the http scope towards a dom scope, but I do think it can be useful for people that works with dom libraries.
Mainly, maintainers who are writing isomorphic code that perform dom operations, and who also need to perform the testing too while verifying the type of error.

There's definitely a use case for that, and as I recall my last attempt to get any of these options working satisfactorily in Deno was a disappointing failure (hopefully things have improved now, these days I just use the excellent Cheerio). But despite the name, I don't think DOMException lives under a dom scope, because many of its use cases are nothing to do with the DOM. I guess the naming is just a weird quirk of history, like XMLHttpRequest, referer, meta charset, 401 Unauthorized, etc.


Remove autoloader bootstrap.php.cache

The file is automatically created by composer and should not be under
version control.

Add to .gitignore then?

I've now added the file to .gitignore.


Permissions: Add discrete one for service point assignment

Closing as won't do.  Doesn't seem like it would be useful.


Definition of "Afternoon" will not apply to events lasting until midnight or longer

Description of issue
Events that start before 6pm but run until midnight (or longer) will not show up in the Afternoon search according to current logic.
Expected behaviour
You should be able to find events that are on for the whole second part of the day when you search Afternoon events.
Steps to reproduce
Have event with startTime: "2018-08-02T14:00:00", and endTime: "2018-08-03T00:00:00", and see if you can find it in the afternoon events list.

Linked with #171


fix: type checking for unknown components when strictTemplates enabled

fixes #3539
vue-ignore doesn't work tho

@so1ve
Thank you for looking into this, would be great to get it working again.
I remember that strictTemplates was able to report unknown props,
but i can't remember if it reported unknown event listeners too.
Would it be possible to make it report unknown event listeners?
I can make a new issue for this ofc, just need to know if that would be a separate issue.

@IceBlizz6 Sure please open a new feature request :D

#3718

Is there anything that can be done to help this pull request along?
Would be great if this could be made available in the near future.


Exchange current density submodel

Make this a submodel like OCP

Actually, it is easier to just write your own class using BaseInterface or one of the derived classes, and then overwrite _get_exchange_current_density


Run tests with Github actions

Deployments are still handled by travis because we need to move the
secrets to github.
Likewise some examples need secrets to run. We detect this in the script
so that those are only run when available. This is useful for pull
requests from forks because those do not have access to secrets.
Also made a small code change to fix a nightly clippy warnings.

Also updated branch protection rules in the repo to use the actions.

Also updated branch protection rules in the repo to use the actions.


Feature request : group notifications

Version 1.9.0 (1513)
Device: iPhone 7 Plus (iOS 11.0)
Should it group notifications by either organization or repository? It would be more organized.

Duplicate of #61?


add license

it's a very interesting project!
Would you consider adding a license to this repository to specify under which terms this code can be used in order to implement into my project , but would you mind make it permissible (MIT, APACHE 2 , BSD-3 ) if possible ??

Hi @SkyBulk, nice to hear from you :) Please note we're still finalising the documentation/examples, and the STIX2 schema is not complete yet. This should be done this week.
And yes, we'll add an Apache 2 license tonight. Let us know how you intend to use the project, we'd love to hear from you. Have you joined our discord community server?

I've just pushed Apache license file to the repo @SkyBul :)


active menu item is missing left black border on webkitgtk

I would probably not complain if i wasn't using webkitgtk 2.8 on epiphany 3.16, which is on the left, compared to latest chromium on the right.

The active border has been removed in 2.0 as a stylistic change to make the default theme more neutral.


Missing feedback button

@Vin205 hey there, the website is missing a feedback section/ page where the visitors will give feedback to website and its services

please check it out yourself as well

@Vin205 please assign this issue to me


Update support page with image.sc forum instead of old forums and lists

As requested by @pwalczysko (#training channel 22:33) - updated the support page with the image.sc forum instead of old forums and mailing lists.
Do we want to link to archives, or will they be ported soon enough?

Do we want to link to archives, or will they be ported soon enough?

I wouldn't for today to reduce confusion. We can re-evaluate after this week.
cc: @pwalczysko

Merging and releasing so this is in place for day 2 of ELMI. Happy to iterate if there are any issues.
Note: I'm unsure if there's a color policy on the icons other than ("roughly the same number of each"). We might want to place the rule in the HTML as a comment though. I certainly would have missed to update them. (See gh-298)

@will-moore Thank you very much for this quick action


[rx-recompose] Observable is not defined when using rx-recompose 0.3.0-beta2

See https://github.com/acdlite/recompose/pull/94#issuecomment-179999362


String diff for UUIDs can use strings.Join syntax which makes it more confusing

This is a similar topic as #274 and #195, but when using cmp to diff UUIDs.
When the UUIDs are very different, the output looks like:
  	ID: strings.Join({
- 		"e93d2d8b-7d2a-4c62-967a-b189347a4fa2",
+ 		"7e93c401-4e27-3b83-7edc-2dd0803c39b3",
  	}, ""),

The strings.Join adds unnecessary noise here, ideally it would be displayed as:
-  	ID: "e93d2d8b-7d2a-4c62-967a-b189347a4fa2",
+ 		ID: "7e93c401-4e27-3b83-7edc-2dd0803c39b3",

However, if the UUIDs have common characters, the output gets really verbose, and isn't particularly useful:
  	ID: strings.Join({
- 		"217d",
  		"6",
- 		"7ef-d686-4107-ab35-347ed6c91a22",
+ 		"68416ab-a20e-48ae-afaa-8df7b91a4af3",
  	}, ""),

Is there a way to avoid this specialized string handling and have it never use the strings.Join output but show a simpler remove/add for string fields?

Thanks for filing. This is a bug. There are more differences than similarities, that it shouldn't have chosen this particular representation.

For my own benefit, here's a reproduction: https://go.dev/play/p/7u4lcejtNsf

Thanks for the additional context. Even in the case that the UUIDs have significant overlap, the strings.Join format is noisy, and causes other issues for code that tries to detect and replace UUIDs.
Ideally we could turn off this feature completely, is there existing options that can be passed to control this behaviour?


[bug] clicking coinbase wallet does nothing

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.12.4
wagmi Version
0.12.0
Current Behavior
Everything works as normal, but when I click on the button to connect a Coinbase wallet nothing happens.
Expected Behavior
I would expect to see a QR code popup for the coinbase wallet so I can connect my wallet.
Steps To Reproduce

Click "connect button"
click "coinbase wallet"
See there that nothing happens and no logs in the console.

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://stackblitz.com/edit/github-rgoxpc?file=remix.config.js
Anything else?
The stackblitz link will show a black screen for a few seconds that says "upgrade required," but if you wait a few seconds the app will start up correctly.

+1
It's functioning for me on a dev build (also using Remix), but the production build behavior follows your StackBlitz example

As I understand, same problem with vite
https://stackblitz.com/edit/vitejs-vite-ceijxz?file=src/App.tsx

I was able to reproduce this behavior in the Vite and Remix examples, but oddly cannot in CRA/Next. If you roll back to previous RainbowKit/Wagmi versions, does this issue resolve?

I was able to reproduce this behavior in the Vite and Remix examples, but oddly cannot in CRA/Next. If you roll back to previous RainbowKit/Wagmi versions, does this issue resolve?

Tried reverting RainbowKit & Wagmi every version from current to 0.8.0 with no changes.  All default wallets continued to work while clicking on coinbase wallet did nothing and resulted in no errors.

Also encountering this issue.

👋
a new version of @coinbase/wallet-sdk v3.6.6 has been just released to fix the issue.
PR is out on wagmi https://github.com/wagmi-dev/references/pull/246
in the mean time, please point to v3.6.6 of coinbase wallet sdk.

and it's applied on the latest wagmi, 0.12.12 https://github.com/wagmi-dev/wagmi/releases/tag/wagmi%400.12.12

@bangtoven Awesome, thank you!

Our dapp hasn't been updated to React 18 yet, therefore we havent been able to update to Rainbowkit v2 and we are experiencing this problem. I tried to set the coinbase wallet sdk to v3.6.6 and it does not work :/

@einaralex Which version are you using currently? I believe the latest RainbowKit v1 and Wagmi v1 versions should not bump into this issue. If possible, please send over a reproducible example (CodeSandbox) and I can have a look. It's possible there is also a bundler or dependency issue in your setup.


Move to lang packs approach

Reference: https://github.com/tastyigniter/TastyIgniter/pull/605
Let me know if I've got them all!

Yup looks like you got the local extension covered.

You missed removing the date format settings fields

In general settings in the admin panel ?

On 3 Dec 2020, at 03:40, Sam Poyigi<EMAIL_ADDRESS>wrote:

You missed removing the date format settings fields
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

In general settings in the admin panel ?

Yups ;)

YEah I mentioned that in the main PR - do you want to remove them or deprecate them?

Oh yea, I'm happy for you to remove them. I'll add a note in the changelog.

Ok, removed in the main PR. I'll work on removing the formats from other extensions over this week all going well.


[HorizontalRunnerAutoscaler] PercentageRunnersBusy is not working without organization specification

Hi! I tried to use HorizontalRunnerAutoscaler, but with type: PercentageRunnersBusy I encountered the following error below.
(With type: TotalNumberOfQueuedAndInProgressWorkflowRuns, everything works)
2021-02-05T10:22:35.606Z	ERROR	controller-runtime.controller	Reconciler error	{"controller": "horizontalrunnerautoscaler", "request": "default/example-runner-deployment-autoscaler", "error": "enterprise, organization and repository are all empty"}
github.com/go-logr/zapr.(*zapLogger).Error
	/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:258
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:232
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.4.0/pkg/internal/controller/controller.go:211
k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:152
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:153
k8s.io/apimachinery/pkg/util/wait.Until
	/go/pkg/mod/k8s.io/apimachinery@v0.0.0-20190913080033-27d36303b655/pkg/util/wait/wait.go:88

I checked the code and I think the code below looks suspicious and is not fixed yet in master branch.
(calculateReplicasByQueuedAndInProgressWorkflowRuns() is checking rd.Spec.Template.Spec.Repository, but calculateReplicasByPercentageRunnersBusy() is not)
https://github.com/summerwind/actions-runner-controller/blob/master/controllers/autoscaling.go#L206-L207
The environment I used:

k8s cluster: kind v0.10.0
OS: ubuntu 20.04
actions-runner-controller: v1.7.0

The manifests I used:

https://github.com/jetstack/cert-manager/releases/download/v1.1.0/cert-manager.yaml
https://github.com/summerwind/actions-runner-controller/releases/download/v0.17.0/actions-runner-controller.yaml
runner-deployment.yaml

apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: example-runner-deployment
spec:
  replicas: 2
  template:
    spec:
      repository: XXX/XXXX

horizontalrunnerautoscaler.yaml

apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: example-runner-deployment-autoscaler
spec:
  scaleTargetRef:
    name: example-runner-deployment
  minReplicas: 1
  maxReplicas: 3
  scaleDownDelaySecondsAfterScaleOut: 60
  metrics:
  - type: PercentageRunnersBusy
    scaleUpThreshold: '0.3'
    scaleDownThreshold: '0.1'
    scaleUpFactor: '3'
    scaleDownFactor: '0.7'
    repositoryNames:
    - XXX/XXXXX

Thank you

The PercentageRunnersBusy metric doesn't supported defining specific repositories yet, that is an enhancement to the existing metric, some dicsussion here https://github.com/summerwind/actions-runner-controller/issues/258 . For the moment you will need to use the TotalNumberOfQueuedAndInProgressWorkflowRuns metric if you want to define specific repositories for that runnerdeployment.

@callum-tait-pbx
Thank you for your comment!
As you commented, this issue is already reported in #258 , so close this.