Add new cmdlet files

Get-CsBatchTeamsDeployment
New-CsBatchTeamsDeployment

Docs Build status updates of commit 1d36bad:
:warning: Validation status: warnings

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:warning:Warning
View (teams-ps)
Details

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:warning:Warning
View (teams-ps)
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md

Line 0, Column 0: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md

Line 0, Column 0: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3bcc3db:
:warning: Validation status: warnings

File
Status
Preview URL
Details

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:warning:Warning
View (teams-ps)
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md

Line 0, Column 0: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c6975af:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ccdc51d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Will these cmdlets be available in the next GA version of the TPM?

Yes. This feature will be GA-ed on Aug 31st. Thanks.

Docs Build status updates of commit 50a22cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 50a22cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f1304af:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 72bb0f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9b8a2ab:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1f80261:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@srinidhikMS Please implement the suggested copy review.Thanks

@srinidhikMS Please implement the suggested copy review.Thanks

Fixed. Thanks.

Copy review - @srinidhikMS, kindly commit the suggested minor changes. Many thanks.

Fixed now. Thanks for the review.

Docs Build status updates of commit 851b6d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd Please merge this PR.


test: fix main branch merge issue

Signed-off-by: Florin Coras<EMAIL_ADDRESS>Risk Level: Low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a

The fix is correct. Thanks for putting it together. Not sure why format is complaining though

Interesting. Trying a force-push to see if it fixes it.


Minor tweaks to PlotMap.R

Just a few small things I noticed at the workshop today - fix typo in "Berkeley", remove unnecessary which() usage, tweak spacing a tad.

Thanks so much, Chris!
Sent from my iPad

On Nov 13, 2015, at 1:53 PM, Chris Kennedy<EMAIL_ADDRESS>wrote:
Just a few small things I noticed at the workshop today - fix typo in "Berkeley", remove unnecessary which() usage, tweak spacing a tad.
You can view, comment on, or merge this pull request online at:
https://github.com/pattyf/RGeoPlotting/pull/3
Commit Summary
Minor tweaks to PlotMap.R
File Changes
M scripts/PlotMap.R (26)
Patch Links:
https://github.com/pattyf/RGeoPlotting/pull/3.patch
https://github.com/pattyf/RGeoPlotting/pull/3.diff
―
Reply to this email directly or view it on GitHub.


net/ntopng - Improved config options for ntopng 4.2

Alignment of community plugin with a commercial plugin written by ntop:

Due to the similarity of fields, this allows a seamless transition from 3.4 Community to 4.3 Enterprise
multiple interfaces can be selected
allowed bypassing authentication
combined HTTP and https port fields (if cert is selected, https is used. without cert, HTTP is used)
(advanced) selection of local networks

I reviewed and validated this more than I am willing to admit. :-)

Just checking - is this in a queue for a code review or did I forget something in the PR?

+1 here. I would love to see this merged

no maintainer feedback, closing.


Add terraform.py as a git submodule

As of right now, the terraform.py script is copied into the mantl project, and if terraform.py is updated, we must copy the changes over manually. Adding it as a submodule makes more sense in this regard.

I'd rather not use git submodules for this, as it adds a lot of complexity for one file. Maybe we could have terraform perform a local exec where it downloads version x from github.


Setup of custom genome fails

Hi,
I want to install a custom genome into bcbio and try to set it up like this:
bcbio_setup_genome.py --cores 24 --fasta Virus.fa --gff3 Virus.gff3 --index star --name VirusA --build VirA
However, this command as well as any possible variation thereof only results in the output of the help text of the bcbio_setup_genome.py command (equivalent to bcbio_setup_genome.py -h) on the command line without any additional error messages.
Am I missing something here?
Thanks a lot!

Thanks for using bcbio and sorry about the confusing messages. I believe the issue is that --gff3 is a flag, so the Virus.gff3 argument then ends up as a bare argument. If you add -g (or --gtf) before it that should fix the problem:
bcbio_setup_genome.py --cores 24 --fasta Virus.fa --gff3 -g Virus.gff3 --index star --name VirusA --build VirA

Hope this helps.

That worked!
However, now I get the following error:
Creating the star index.
Traceback (most recent call last):
  File "/bioinformatics/tooldir/bin/bcbio_setup_genome.py", line 4, in <module>
    __import__('pkg_resources').run_script('bcbio-nextgen==1.0.2', 'bcbio_setup_genome.py')
  File "/bioinformatics/bcbio/anaconda/lib/python2.7/site-packages/setuptools-20.3-py2.7.egg/pkg_resources/__init__.py", line 726, in run_script
  File "/bioinformatics/bcbio/anaconda/lib/python2.7/site-packages/setuptools-20.3-py2.7.egg/pkg_resources/__init__.py", line 1484, in run_script
  File "/bioinformatics/bcbio/anaconda/lib/python2.7/site-packages/bcbio_nextgen-1.0.2-py2.7.egg-info/scripts/bcbio_setup_genome.py", line 279, in <module>
    indexed[index] = index_fn(fasta_file)
  File "/bioinformatics/additionaltools/cloudbiolinux/cloudbio/biodata/genomes.py", line 426, in decorator
    return func(*args, **kwargs)
  File "/bioinformatics/additionaltools/cloudbiolinux/cloudbio/biodata/genomes.py", line 689, in _index_star
    Nbases = int(round(min(14, log(GenomeLength, 2)/2 - 2), 0))
ValueError: math domain error

Hi @luckylynx
This is a problem when guessing the right value depending on genome size. How long is the that genome? Maybe you can try another aligner since it's a small genome, like bowtie2, meanwhile we try to solve this. Can you share the virus sequence or how big the file is?

Ah, I see. The genome is about 5.5 kbp, a polyomavirus, so quite small.
I will try to use another aligner.
Another solution might be to create a custom genome consisting of a fusion of e.g. hg19 and the viral genome and align my reads against this, should probably also work...?!

yes, that last option should work as well if there is human genome in your samples as well.


Focus lost on Alt+Tab for some applications

Windows build number:
22621
Your Distribution version:
NixOS 94e02f5bd2cd07e89539fa03ca62e56263ac2e40
Your WSL versions:
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.47
MSRDC version: 1.2.3575
Direct3D version: 1.606.4
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.1105
Steps to reproduce:

start kitty$ nix run nixpkgs#kitty

Alt+Tab to another window
Alt+Tab back to the kitty window

Focus has been lost, I have to click on the window.
Note that

this does not happen with other apps (e.g. gedit)
this does not happen when not using WSLg (e.g. using vcxsrv)

WSL logs:
weston.log
Date: 2023-01-19 CET
[09:31:03.908] weston 9.0.0
               https://wayland.freedesktop.org
               Bug reports to: https://gitlab.freedesktop.org/wayland/weston/issues/
               Build: 9.0.0-177-ge7e91e17
[09:31:03.909] Command line: /usr/bin/weston --backend=rdp-backend.so --modules=wslgd-notify.so --xwayland --log=/mnt/wslg/weston.log --socket=wayland-0 --shell=rdprail-shell.so --logger-scopes=log,rdp-backend,rdprail-shell
[09:31:03.909] OS: Linux, <IP_ADDRESS>-microsoft-standard-WSL2, #1 SMP Wed Nov 23 01:01:46 UTC 2022, x86_64
[09:31:03.909] Using config file '/home/wslg/.config/weston.ini'
[09:31:03.911] Output repaint window is 7 ms maximum.
[09:31:03.911] Loading module '/usr/lib/libweston-9/rdp-backend.so'
[09:31:03.921] using FreeRDP version 2.4.0
Date: 2023-01-19 CET
[09:31:03.921] RDP backend: WESTON_RDP_DEBUG_LEVEL: 3
[09:31:03.921] RDP backend: rdp_monitor_refresh_rate: 60000
[09:31:03.921] RDP backend: timer resolution tv_sec:0 tv_nsec:1
[09:31:03.921] RDP backend: Environment dump - start
[09:31:03.921]   WSL2_DEFAULT_APP_ICON=/usr/share/icons/wsl/linux.png
[09:31:03.921]   SHELL=/bin/bash
[09:31:03.921]   WESTON_RDP_HI_DPI_SCALING=true
[09:31:03.921]   WSL2_GUI_APPS_ENABLED=1
[09:31:03.921]   WSL_DISTRO_NAME=
[09:31:03.921]   WSL2_VM_ID=A6DF6403-3467-4C9A-A615-761EE2D1BF4A
[09:31:03.921]   XCURSOR_PATH=/mnt/wslg/distro/usr/share/icons:/usr/share/icons
[09:31:03.921]   XCURSOR_SIZE=16
[09:31:03.921]   WLOG_APPENDER=file
[09:31:03.921]   NAME=kaguya
[09:31:03.921]   PWD=/home/wslg
[09:31:03.921]   LOGNAME=wslg
[09:31:03.921]   WSL_FEATURE_FLAGS=8d
[09:31:03.921]   WSL2_USER_PROFILE=C:\Users\aceus
[09:31:03.921]   WSL2_DISTRO_NAME=NixOS
[09:31:03.921]   _=/usr/bin/weston
[09:31:03.921]   PULSE_AUDIO_RDP_SINK=/mnt/wslg/PulseAudioRDPSink
[09:31:03.921]   HOME=/home/wslg
[09:31:03.921]   WESTON_RDP_DEBUG_DESKTOP_SCALING_FACTOR=200
[09:31:03.921]   WAYLAND_DISPLAY=wayland-0
[09:31:03.921]   USE_VSOCK=3
[09:31:03.921]   WSL2_EXECUTION_ALIAS_PATH=C:\Users\aceus\AppData\Local\Microsoft\WindowsApps\MicrosoftCorporationII.WindowsSubsystemForLinux_8wekyb3d8bbwe
[09:31:03.921]   WSL2_DEFAULT_APP_OVERLAY_ICON=/usr/share/icons/wsl/linux.png
[09:31:03.921]   USER=wslg
[09:31:03.921]   DISPLAY=:0
[09:31:03.921]   SHLVL=0
[09:31:03.921]   WSLGD_NOTIFY_SOCKET=/mnt/wslg/weston-notify.sock
[09:31:03.921]   WLOG_FILEAPPENDER_OUTPUT_FILE_PATH=/mnt/wslg
[09:31:03.921]   XDG_RUNTIME_DIR=/mnt/wslg/runtime-dir
[09:31:03.921]   WSL2_SHARED_MEMORY_OB_DIRECTORY=WSL\A6DF6403-3467-4C9A-A615-761EE2D1BF4A\wslg
[09:31:03.921]   WESTON_RDP_FRACTIONAL_HI_DPI_SCALING=true
[09:31:03.921]   XCURSOR_THEME=whiteglass
[09:31:03.921]   PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
[09:31:03.921]   WESTON_DISABLE_ABSTRACT_FD=1
[09:31:03.921]   WLOG_FILEAPPENDER_OUTPUT_FILE_NAME=wlog.log
[09:31:03.921]   PULSE_AUDIO_RDP_SOURCE=/mnt/wslg/PulseAudioRDPSource
[09:31:03.921]   PULSE_SERVER=/mnt/wslg/PulseServer
[09:31:03.921]   WSL2_INSTALL_PATH=C:\Program Files\WindowsApps\MicrosoftCorporationII.WindowsSubsystemForLinux_<IP_ADDRESS>_x64__8wekyb3d8bbwe
[09:31:03.921]   WSL2_SHARED_MEMORY_MOUNT_POINT=/mnt/shared_memory
[09:31:03.921]   WESTON_CONFIG_FILE=/home/wslg/.config/weston.ini
[09:31:03.921] RDP backend: Environment dump - end
[09:31:03.921] RDP backend: FreeRDP version: 2.4.0
[09:31:03.921] Using external fd for incoming connections: 3
[09:31:03.921] Default head is being added
[09:31:03.921] Registered plugin API 'weston_rdprail_api_v1' of size 64
[09:31:03.921] RDPAPPLIST_MODULEDIR is set to /usr/lib/rdpapplist
[09:31:03.922] RDP backend: use_rdpapplist = 1
[09:31:03.926] RDP backend: use_gfxredir = 1
[09:31:03.926] RDP backend: enable_hi_dpi_support = 1
[09:31:03.926] RDP backend: enable_fractional_hi_dpi_support = 1
[09:31:03.926] RDP backend: enable_fractional_hi_dpi_roundup = 0
[09:31:03.926] RDP backend: debug_desktop_scaling_factor = 200
[09:31:03.926] RDP backend: enable_window_zorder_sync = 1
[09:31:03.926] RDP backend: enable_window_snap_arrange = 0
[09:31:03.926] RDP backend: enable_window_shadow_remoting = 1
[09:31:03.926] RDP backend: enable_display_power_by_screenupdate = 0
[09:31:03.926] RDP backend: enable_distro_name_title = 1
[09:31:03.926] RDP backend: enable_copy_warning_title = 1
[09:31:03.926] Using VSOCK for incoming connections: 3
[09:31:03.928] Registered plugin API 'weston_rdp_output_api_v1' of size 16
[09:31:03.928] Head attaching: rdp-0, index:0, is_primary: 1
[09:31:03.928] Client desktop upper left coordinate (0,0)
[09:31:03.928] disp_monitor_validate_and_compute_layout:---OUTPUT---
[09:31:03.928] 	rdpMonitor[0]: x:0, y:0, width:0, height:0, is_primary:1
[09:31:03.928] 	rdpMonitor[0]: weston x:0, y:0, width:0, height:0
[09:31:03.928] 	rdpMonitor[0]: physicalWidth:0, physicalHeight:0, orientation:0
[09:31:03.928] 	rdpMonitor[0]: desktopScaleFactor:0, deviceScaleFactor:0
[09:31:03.928] 	rdpMonitor[0]: scale:1, clientScale:1.00
[09:31:03.928] Head mode change:rdp-0 NEW width:0, height:0, scale:1, clientScale:1.000000
[09:31:03.928] move head/output rdp-0 (0,0) -> (0,0)
[09:31:03.928] client origin (0,0) is (0,0) in Weston space
[09:31:03.928] Output 'rdp-0' enabled with head(s) rdp-0
[09:31:03.928] Compositor capabilities:
               arbitrary surface rotation: yes
               screen capture uses y-flip: no
               presentation clock: CLOCK_MONOTONIC_RAW, id 4
               presentation clock resolution: 0.000000001 s
[09:31:03.929] Loading module '/usr/lib/weston/rdprail-shell.so'
[09:31:03.930] RDPRAIL-shell: WESTON_RDPRAIL_SHELL_DEBUG_LEVEL: 3.
Date: 2023-01-19 CET
[09:31:03.930] RDPRAIL-shell: allow-zap:0
[09:31:03.930] RDPRAIL-shell: binding-modifier:none
[09:31:03.930] RDPRAIL-shell: local-move:0
[09:31:03.930] RDPRAIL-shell: distro name:NixOS (len:5)
[09:31:03.932] RDPRAIL-shell: WSL2_DEFAULT_APP_ICON:/usr/share/icons/wsl/linux.png (loaded:yes)
[09:31:03.932] RDPRAIL-shell: WSL2_DEFAULT_APP_OVERLAY_ICON:/usr/share/icons/wsl/linux.png (loaded:yes)
[09:31:03.932] RDPRAIL-shell: WESTON_RDPRAIL_SHELL_APPEND_DISTRONAME_STARTMEN:1
[09:31:03.932] RDPRAIL-shell: WESTON_RDPRAIL_SHELL_BLEND_OVERLAY_ICON_APPLIST:1
[09:31:03.932] RDPRAIL-shell: WESTON_RDPRAIL_SHELL_BLEND_OVERLAY_ICON_TASKBAR:1
[09:31:03.932] RDPRAIL-shell: WESTON_RDPRAIL_SHELL_USE_WSLPATH:0
[09:31:03.932] rdp_rail_shell_initialize_notify: shell: distro name: NixOS
[09:31:03.933] app_list_monitor_thread: running in system-distro with user-distro: NixOS
[09:31:03.933] app_list_monitor_thread: open(/proc/self/ns/mnt)
[09:31:03.933] app_list_monitor_thread: open(/proc/2/ns/mnt)
[09:31:03.934] Loading module '/usr/lib/libweston-9/xwayland.so'
[09:31:03.936] app_list_monitor_thread: inotify_add_watch(/usr/share/applications)
[09:31:03.937] Registered plugin API 'weston_xwayland_v1' of size 32
[09:31:03.939] Registered plugin API 'weston_xwayland_surface_v1' of size 48
[09:31:03.939] Not using abstract fd for Xwayland
[09:31:03.939] xserver listening on display :0
[09:31:03.940] Loading module '/usr/lib/weston/wslgd-notify.so'
[09:31:03.940] ../compositor/wslgd-notify.c: socket connected
[09:31:03.940] launching '/usr/libexec/weston-rdprail-shell'
[09:31:03.940] app_list_monitor_thread: /usr/local/share/applications doesn't exist, skipping.
[09:31:03.941] app_list_monitor_thread: /var/lib/snapd/desktop/applications doesn't exist, skipping.
[09:31:03.941] app list folder[0]: /usr/share/applications
[09:31:03.961] find_icon_file: icon (nix-snowflake) search retry:(1) global:(1)
[09:31:03.961] desktop file: /usr/share/applications/nixos-manual.desktop
[09:31:03.961]     Name[en_US]:NixOS Manual (NixOS)
[09:31:03.961]     Exec:nixos-help
[09:31:03.961]     TryExec:(null)
[09:31:03.961]     WorkingDir:(null)
[09:31:03.961]     Icon name:nix-snowflake
[09:31:03.961]     Icon file:(null)
[09:31:03.961]     Icon image:(nil)
[09:31:03.961] app list entry updated: Key:nixos-manual, Name:NixOS Manual (NixOS)
[09:31:03.961] app list folder[1]: /usr/local/share/applications
[09:31:03.961] app list folder[2]: /var/lib/snapd/desktop/applications
[09:31:03.972] CreateWndow(): rdp_peer is not initalized
[09:31:04.009] Spawned Xwayland server, pid 23
[09:31:04.767] Client: ClientStatus:0x3f5
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_ALLOWLOCALMOVESIZE
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_ZORDER_SYNC
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_WINDOW_RESIZE_MARGIN_SUPPORTED
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_HIGH_DPI_ICONS_SUPPORTED
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_APPBAR_REMOTING_SUPPORTED
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_POWER_DISPLAY_REQUEST_SUPPORTED
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_GET_APPID_RESPONSE_EX_SUPPORTED
[09:31:04.767]      - TS_RAIL_CLIENTSTATUS_BIDIRECTIONAL_CLOAK_SUPPORTED
[09:31:04.767] Client HandShake buildNumber:22621
[09:31:04.778] Server AppList caps version:3
[09:31:04.799] Client: gfxredir_caps: length:28
[09:31:04.799] Client: GrfxCaps count:0xa
[09:31:04.799] Client: gfxredir_caps[0]: signature:0x53504143
[09:31:04.799] Client: GrfxCaps[0] version:0x80004 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_8
[09:31:04.799] Client: GrfxCaps[1] version:0x80105 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_81
[09:31:04.799] Client: GrfxCaps[2] version:0xa0002 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_10
[09:31:04.799] Client: GrfxCaps[3] version:0xa0200 length:4 flags:0x0
[09:31:04.799] Client: gfxredir_caps[0]: version:0x1
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_102
[09:31:04.799] Client: gfxredir_caps[0]: length:12
[09:31:04.799] Client: gfxredir_caps[1]: signature:0x53504143
[09:31:04.799] Client: gfxredir_caps[1]: version:0x2000
[09:31:04.799] Client: GrfxCaps[4] version:0xa0301 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_103
[09:31:04.799] Client: GrfxCaps[5] version:0xa0400 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_104
[09:31:04.799] Client: gfxredir_caps[1]: length:16
[09:31:04.799] Client: GrfxCaps[6] version:0xa0502 length:4 flags:0x0
[09:31:04.799] Client: gfxredir_caps[1]: supportedFeatures:0x0
[09:31:04.799] Client: gfxredir selected caps: version:0x2000
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_105
[09:31:04.799] Client: GrfxCaps[7] version:0xa0600 length:4 flags:0x0
[09:31:04.799] 	Version : RDPGFX_CAPVERSION_106
[09:31:04.799] Client: GrfxCaps[8] version:0xa0701 length:4 flags:0x0
[09:31:04.799] 	Version : UNKNOWN(657153)
[09:31:04.799] Client: GrfxCaps[9] version:0xb0101 length:4 flags:0x0
[09:31:04.799] 	Version : UNKNOWN(721153)
[09:31:04.809] xf_peer_adjust_monitor_layout:
[09:31:04.809]   DesktopWidth:3840, DesktopHeight:2160
[09:31:04.809]   UseMultimon:0
[09:31:04.809]   ForceMultimon:0
[09:31:04.809]   MonitorCount:0
[09:31:04.809]   HasMonitorAttributes:0
[09:31:04.809]   HiDefRemoteApp:1
[09:31:04.809] disp_monitor_sanity_check_layout:---INPUT---
[09:31:04.809] 	rdpMonitor[0]: x:0, y:0, width:3840, height:2160, is_primary:1
[09:31:04.809] 	rdpMonitor[0]: physicalWidth:600, physicalHeight:340, orientation:0
[09:31:04.809] 	rdpMonitor[0]: desktopScaleFactor:150, deviceScaleFactor:140
[09:31:04.809] 	rdpMonitor[0]: scale:2, client scale :2.00
[09:31:04.809] kbd_layout:0x40c kbd_type:0x4 kbd_subType:0x0 kbd_functionKeys:0xc
[09:31:04.809] convert_rdp_keyboard_to_xkb_rule_names: matching model=pc105 layout=fr variant=(null) options=(null)
[09:31:04.822] Client desktop upper left coordinate (0,0)
[09:31:04.822] disp_monitor_validate_and_compute_layout:---OUTPUT---
[09:31:04.822] 	rdpMonitor[0]: x:0, y:0, width:3840, height:2160, is_primary:1
[09:31:04.822] 	rdpMonitor[0]: weston x:0, y:0, width:1920, height:1080
[09:31:04.822] 	rdpMonitor[0]: physicalWidth:600, physicalHeight:340, orientation:0
[09:31:04.822] 	rdpMonitor[0]: desktopScaleFactor:150, deviceScaleFactor:140
[09:31:04.822] 	rdpMonitor[0]: scale:2, clientScale:2.00
[09:31:04.822] Head mode change:rdp-0 NEW width:3840, height:2160, scale:2, clientScale:2.000000
[09:31:04.822] Output 'rdp-0' enabled with head(s) rdp-0
[09:31:04.822] move head/output rdp-0 (0,0) -> (0,0)
[09:31:04.822] client origin (0,0) is (0,0) in Weston space
[09:31:04.822] Client ExecOrder:0x00000008, Program:dummy-entry, WorkingDir:(null), RemoteApplicationArguments:(null)
[09:31:04.822] Client ExecOrder launching dummy-entry
[09:31:04.822] launching 'dummy-entry'
[09:31:04.823] Client: ClientSysparam: filterKeys
[09:31:04.823] compositor: executing 'dummy-entry' failed: No such file or directory
[09:31:04.823] Client: ClientSysparam: toggleKeys:58
[09:31:04.823] Client: ClientSysparam: stickyKeys:506
[09:31:04.823] Client: ClientSysparam: caretWidth:1
[09:31:04.823] Client: ClientSysparam: highContrast
[09:31:04.823] Client: ClientSysparam: taskbarPos:(left:0, top:2088, right:3840, bottom:2160)
[09:31:04.823] Client: ClientSysparam: mouseButtonSwap:0
[09:31:04.823] Client: ClientSysparam: keyboardPref:0
[09:31:04.823] Client: ClientSysparam: dragFullWindows:1
[09:31:04.823] Client: ClientSysparam: keyboardCues:0
[09:31:04.823] Client: ClientSysparam: workArea:(left:0, top:0, right:3840, bottom:2088)
[09:31:04.823] Translated workarea:(0,0)-(1920,1044) at rdp-0:(0,0)-(1920,1080)
[09:31:04.823] Client AppList caps version:3
[09:31:04.823] Client AppList client language id: en_US
[09:31:04.823] Client: ClientSysparam: filterKeys
[09:31:04.823] Client: ClientSysparam: toggleKeys:58
[09:31:04.823] Client: ClientSysparam: stickyKeys:506
[09:31:04.823] app_list_monitor_thread: startRdpNotifyEvent is signalled. 0 - en_US
[09:31:04.823] Client: ClientSysparam: caretWidth:1
[09:31:04.823] rdp_rail_notify_app_list(): rdp_peer 0x55c19c7e2230
[09:31:04.823]     inSync: 1
[09:31:04.823]     syncStart: 1
[09:31:04.823]     syncEnd: 1
[09:31:04.823]     newAppId: 1
[09:31:04.823] Client: ClientSysparam: highContrast
[09:31:04.823] Client: ClientSysparam: taskbarPos:(left:0, top:2088, right:3840, bottom:2160)
[09:31:04.823]     deleteAppId: 0
[09:31:04.823]     deleteAppProvider: 0
[09:31:04.823] Client: ClientSysparam: mouseButtonSwap:0
[09:31:04.823]     appId: nixos-manual
[09:31:04.823] Client: ClientSysparam: keyboardPref:0
[09:31:04.823]     appGroup: (null)
[09:31:04.824]     appExecPath: nixos-help
[09:31:04.824]     appWorkingDir: (null)
[09:31:04.824]     appDesc: NixOS Manual (NixOS)
[09:31:04.824]     appIcon: 0x55c19c7b06d0
[09:31:04.824]     appProvider: (null)
[09:31:04.823] Client ExecOrder program terminated
[09:31:04.824] dummy-entry exited with status 255
[09:31:04.824] Client: ClientSysparam: dragFullWindows:1
[09:31:04.824] Client: ClientSysparam: keyboardCues:0
[09:31:04.824] Client: ClientSysparam: workArea:(left:0, top:0, right:3840, bottom:2088)
[09:31:04.824] Translated workarea:(0,0)-(1920,1044) at rdp-0:(0,0)-(1920,1080)
[09:31:04.886] Pulse Audio Sink listener socket on /mnt/wslg/PulseAudioRDPSink
[09:31:05.499] xfixes version: 5.0
[09:31:05.503] created wm, root 558
[09:31:05.503] xfixes selection notify event: owner 2097153
[09:31:05.503] our window, skipping
[09:31:05.510] RDP Sink version (1 - 1)
[09:31:06.826] retry_find_icon_file: icon (nix-snowflake) retry count (1)
[09:31:06.826] find_icon_file: icon (nix-snowflake) search retry:(2) global:(1)
[09:31:08.828] retry_find_icon_file: icon (nix-snowflake) retry count (2)
[09:31:08.828] find_icon_file: icon (nix-snowflake) search retry:(3) global:(1)
[09:31:10.830] retry_find_icon_file: icon (nix-snowflake) retry count (3)
[09:31:10.830] find_icon_file: icon (nix-snowflake) search retry:(4) global:(1)
[09:31:12.832] retry_find_icon_file: icon (nix-snowflake) retry count (4)
[09:31:12.832] find_icon_file: icon (nix-snowflake) search retry:(5) global:(0)
[09:31:27.940] Client: ClientGetAppidReq: pid:491 appId:kitty
[09:31:27.997] Client: ClientGetAppidReq: WindowId:0x5 does not have appId, or not top level window.
[09:31:27.997] Client: ClientGetAppidReq: WindowId:0x6 does not have appId, or not top level window.
[09:31:27.997] Client: ClientGetAppidReq: WindowId:0x7 does not have appId, or not top level window.
[09:31:27.997] Client: ClientGetAppidReq: WindowId:0x8 does not have appId, or not top level window.
[09:31:27.998] Client: LanguageImeInfo: ProfileType: 2 (TF_PROFILETYPE_KEYBOARDLAYOUT)
[09:31:27.998] Client: LanguageImeInfo: LanguageID: 0x40c
[09:31:27.998] Client: LanguageImeInfo: LanguageProfileCLSID: GUID_NULL
[09:31:27.998] Client: LanguageImeInfo: ProfileGUID: GUID_NULL
[09:31:27.998] Client: LanguageImeInfo: KeyboardLayout: 0x40c
[09:31:28.060] app_list_monitor_thread: loadIconEvent is signalled. kitty
[09:31:28.060] app_list_monitor_thread: entry (nil), image (nil)
[09:31:28.070] !!!cursor role is added after creation - WindowId:0x3

stderr.log
[09:31:03.940] <3>WSLGd: LogException:74: Exception: No such file or directory @../FontMonitor.cpp:274 (Start)

[09:31:03.940] <5>WSLGd: RemoveMonitorFolder:162: FontMonitor: removing monitoring /mnt/wslg/distro/usr/share/fonts
[09:31:03.940] <5>WSLGd: Stop:311: FontMonitor: monitoring stopped.
dbus[14]: Unknown username "systemd-oom" in message bus configuration file
dbus[14]: Unknown username "pulse" in message bus configuration file
could not load cursor 'grabbing'
could not load cursor 'dnd-move'
could not load cursor 'dnd-copy'
glamor: 'wl_drm' not supported
Missing Wayland requirements for glamor GBM backend
Failed to initialize glamor, falling back to sw
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Internal error:   Could not resolve keysym XF86FullScreen
Errors from xkbcomp are not fatal to the X server
The XKEYBOARD keymap compiler (xkbcomp) reports:
> Warning:          Unsupported maximum keycode 569, clipping.
>                   X11 cannot support keycodes above 255.
> Internal error:   Could not resolve keysym XF86FullScreen
Errors from xkbcomp are not fatal to the X server

WSL dumps:
Empty
Expected behavior:
Upon Alt+Tab back to the window rendered by WSLg, it should take focus again.
Actual behavior:
Upon Alt+Tab back to the window rendered by WSLg is not focus (need to click on it once).

I see the following message: [363 15:42:48.336980] [glfw error 65544]: Wayland: activation requests not supported by this Wayland compositor in the logs.
Interestingly, even with this limitation, it seems like AutoHotkey's WinActivate function can successfully focus kitty - not sure what it's doing differently compared to Alt-Tab, but that might be something to look into or at least help with a workaround (using AHK).

Interestingly, even with this limitation, it seems like AutoHotkey's WinActivate function can successfully focus kitty

@robbins But how can you specify the kitty's window? It seems that all WSLg windows have the same name, and the kitty's window title keeps changing. By setting an immutable name for kitty?

Yeah, I used the --title argument for that.

Has anyone come up with a workaround for this?

An interesting thing I found is that if you open kitty via root, alt+tab works fine.

Bumping on this issue, currently I'm working around by using root as @ofseed mentioned

another workaround, set hide_window_decorations yes (for kitty) to make the titlebar disappear, and it will focus when alt+tabbing. But there is no way to move the window now (alt + mouse click doesnt work like in x11/wayland)

Also bumping on this issue, currently I'm working around by using root as @ofseed mentioned :-)

Out of curiousity, has anyone managed to work out an explanation for the difference in behaviour between gedit and kitty?  I've reproduced the issue on my bundled install of wslg, but don't have nearly enough time to look at the code.  To me, the issue is currently just an annoyance, as the kitty window is at least bought to the front where it can be clicked to focus.  I am wondering about what gedit and kitty do differently to trigger the observed difference, though.

Update: So using the @ofseed workaround, I ran into the issue which is that, with kitty running as root, copy and paste outside of the kitty window no longer works. I guess it's because root has a different clipboard from the regular user? So I tried to find a workaround for this. In the end I discovered the following, that if you first run kitty as root, and then use that to run kitty again as a regular user, then the newest launched kitty -- running as non-root user -- will have its focus working after alt-tab! Here's the command I used:
$ sudo /home/$USER/.local/kitty.app/bin/kitty sh -c "runuser -u $USER -- /home/$USER/.local/kitty.app/bin/kitty"


AE49_190216_110520.551

Type: Missing
Summary:
License
Details:
Bulk curation
Resolution:
n/a
Affected definitions:

cli-box 5.0.0,- colorsublime-themes c10fdd8b144486b7a4f3cb4e2251c66df222a825,- couleurs 5.0.0,- css-loader 0.9.1,- css-select 1.2.0,- ctype 0.5.3,- date e7e1482087f58913b80a20b04d5c58d9d6d90155,- deffy 2.0.0,- dmlc-core 4d49691f1a9d944c3b0aa5e63f1db3cad1f941f8

For cli-box 5.0.0 and couleurs 5.0.0, I'm seeing the license declared as KINDLY from the source repo, the license file included in the package, and in the package README.
http://registry.npmjs.com/cli-box/5.0.0
http://registry.npmjs.com/couleurs/5.0.0
https://github.com/IonicaBizau/node-cli-box/blob/5.0.0/LICENSE
https://github.com/IonicaBizau/node-couleurs/blob/5.0.0/LICENSE

For deffy 2.0.0, I'm seeing the license declared as KINDLY from the source repo, the license file included in the package, and in the package README.
http://registry.npmjs.com/deffy/2.0.0
https://github.com/IonicaBizau/deffy/blob/2.0.0/LICENSE


A lot of entries were removed from my instance

Hi, seems like defaultCleanupArchiveUnreadDays was added ~recently and was enabled by default.
Lots of the feeds that I subscribe too are not news or something that can't be read later, so most of the time there are a lot of unread entries at all times.
Because I didn't notice the defaultCleanupArchiveUnreadDays feature and didn't disable it on time, yesterday the number of unread entries dropped from 1700 to 210.
Is there a way to get the entries back somehow or are all of those completely removed from the db?

seems like by running the following code in the database I get that 1808 were changed at 4th of April which is about 180 days from now. I am sure that I had about 1700 last week, so there must be something wrong with setting the changed_at value when running cleanup too. :
SELECT sub.year, sub.month, sub.day, COUNT(*) as count
FROM (
		SELECT
			date_part('year', changed_at) as year,
			date_part('month', changed_at) as month,
			date_part('day', changed_at) as day
		FROM entries
	 ) as sub
GROUP BY sub.year, sub.month, sub.day
ORDER BY count DESC
LIMIT 20;

First result:
year | month | day | count
------+-------+-----+-------
 2020 |     4 |   4 |  1808

The next 6 days from then also had a high number of changes.

Would using the following sql statement and setting the  defaultCleanupArchiveUnreadDays fix my issue or would it make the things worse smh.
UPDATE entries
SET status = 'unread'
WHERE changed_at >= (date '2020-04-04') AND changed_at <  (date '2020-04-05');

You can change the status from "removed" to "unread" to restore your articles (assuming they are still in in the feeds).
To disable archiving of unread entries, set CLEANUP_ARCHIVE_UNREAD_DAYS to -1 as mentioned in the docs (default is 6 months): https://miniflux.app/docs/configuration.html#cleanup-archive-unread-days

Seems like the changed_at value is not updated when archiving entries https://github.com/miniflux/miniflux/blob/c394a61a4e1fe395191262ed1ccaf70b90a71484/storage/entry.go#L268
Because of that, the archieved entries were the only ones that had the changed_at timestamp the same as published_at.
I fixed the issue by running UPDATE entries SET status='unread' WHERE changed_at=published_at; directly in the db.
Also it would be nice if such new features are disabled by default to not mess up existing users repositories.


Fix performance leak in sGetSimilarArticles

The function sGetSimilarArticles generates SQL code that does not perform well on shops with many articles (e.g. 300k), since the left joins unneccessary create multiple lines. In an example case the result with 350k articles, 500  categories (approx 3 categories for 1 article - its a book store - ) this query generates over 2,1 million lines  and runs on a quite big dedecated server for 7-15sek, since the big result tables needs to be written to disc my the database.
To group and sort 2,1 million lines for 4 random lines picket by a simple relevance is not good.
When a crawler comes by a shop and crawls many unavailable products (ignoring the sitemap) the server is flooded by long running queries and begins to lag.
The idea here is, to split those 3 relevances into independent queries und unionize the result. This yields the exact same four randomized results (in terms of relevance, whilst of course not the exact same 4, since the DB does not have to order the result).

1. Why is this change necessary?
Performance leak is severe. Brought a PX91 NVME Hetzner Server to its knees.
2. What does this change do, exactly?
The way 4 random products are picked ordered by the same relevance as before.
3. Describe each step to reproduce the issue or behaviour.
Crawl non existing products, or non-available products to call the Product-Not-Found-Error page in a "big" shop (read above).
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
None
6. Checklist

[ - ] I have written tests and verified that they fail without my change -- no its live on www.beam-shop.de and the performance impact on an up to date mariaDB is enourmous (Factor 15000)
[ x ] I have squashed any insignificant commits
[ - ] This change has comments for package types, values, functions, and non-obvious lines of code - Its "just" SQL. Not more complex than before.
[ x ] I have read the contribution requirements and fulfil them. - Think so

You have a wrong target branch. Please change it to 5.5

You have a wrong target branch. Please change it to 5.5

Tbh we would need it in 5.4 also... and I tested on 5.4 (seems totally legit for 5.5, but since we run on 5.4...)

Anddddddddddddddd squash the commits

Anddddddddddddddd squash the commits

Yep, just realisized there seems to be no option for that in github edit mode (gitlab has that tough). Did it locally now.

For the 5.5 branch, whats your preferred way? Switch this PR or open another one similar to this for 5.5.
I would love to see those changes (if accepted) in 5.4, too.

Changed to 5.5

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23172
Please use this issue to track the state of your pull request.

Hi @Ancillius, thank you very much for your contribution! 💙

The idea here is, to split those 3 relevances into independent queries und unionize the result

@Ancillius, thanks for taking it up to renovate this query, it is popular in slowlogs if RelatedArticlesOnArticleNotFound is enabled - though did you test it on a filled s_articles_similar dataset? With the shopwaredemo.de DB (_sql/demo/latest.sql) for articleid 196 ("Artikel mit ähnlichen Produkten"), the old query returns relevance 3 rows, while the UNION query will not.
I think the UNION approach with 3 relevance tiers is a good idea, but if I'm not in the wrong, some more work is neccessary to fulfil the querys original purpose.

Hey @wbob ,
I'm getting similar results, the higher relevances (> 1) seemingly aren't being
selected anymore.
I think it might be due to this inner join in both of the higher relevance
queries:
INNER JOIN s_articles_similar s
  ON s.articleID = a.id
  AND s.relatedarticle = a.id

This would lead to nothing being selected, as no product is related to itself in
s_articles_similar.
Can you confirm this? If so, we'd be glad if you could address this issue :slightly_smiling_face:

the former query did 2 things at the same time - rank by similar article and check for same category. It was a left join to o.id (others I presume). For the union approach that query can be simplified. While I thought the idea of UNIONs to be interesting, I came to the conclusion it is better to do individual querys per relevance and only check the next, less focused tier if the result comes back empty. Like: if (empty($similarArtilces)) { if (empty($sameCategories)) { return $randomArticles ]}

Hey @wbob,
would it be a solution if we would improve the SimilarProductService to be able to use inactive products instead of implementing this separate query.


Unit tests are failing

After proposing some new changes in https://github.com/ivadomed/MetricsReloaded/pull/17, I noticed that unit tests are failing.
The reason is these two commits https://github.com/ivadomed/MetricsReloaded/commit/54ead73c0bd1fa16cb68946eb288a63ee76a5ae9 and https://github.com/ivadomed/MetricsReloaded/commit/2bad1f2115687871ac8c194fb5d222ba65de1d69 from @naga-karthik pushed directly to main.  @naga-karthik, it seems these two commits are specific to your MS lesion project. Maybe you can create a new branch with these two commits, and I will revert them from main to unit tests working.

ah man, thanks for catching this! yeah I remember pushing directly to main, I am going to change it

hey Jan, I looked at these commits. I believe commit https://github.com/ivadomed/MetricsReloaded/commit/54ead73c0bd1fa16cb68946eb288a63ee76a5ae9 was a hasty fix to test something quick and I should have reverted it back. This commit skips the cases where EmptyRef and EmptyPred are true (i.e. the model has learned correctly and the Dice=1). I wanted to compare ANIMA and MetricsReloaded to ensure that the metrics are computed correctly (i.e. the results match in both ways of computing metrics).
Now, this commit can be reverted without having it another branch because this is precisely what we use MetricsReloaded for -- to not skip cases where GT is empty.

As for commit https://github.com/ivadomed/MetricsReloaded/commit/2bad1f2115687871ac8c194fb5d222ba65de1d69, I see that the condition is commented out. I believe that was also to test something quick and should have been reverted back. I confirm the correct version is indeed seen in my branch (i.e. where it is not commented).

I did git reset --hard to commit 76dbb55, please let me know if: (1) this is right thing to do? (2) should add revert commits instead?

Thanks, Naga!
Yes, I believe you can run the following two commands on your local main:
git reset --hard 76dbb55
git push --force

thanks for the git push --force, Jan! I was missing this part! I am getting this error
remote: - Cannot force-push to this branch

This says that we need to allow force pushes from the Settings on Github. Do you have access by any chance?

Merci, Jan! ❤
Sorry for the mess, I will careful with the main branch in the future. I recall the changes were quite "urgent".


":h ctrl-w_h" matches "CTRL-W_H" rather than "CTRL-W_h"

Describe the bug
SSIA. Same for ^wh, ctrl-w_j, ^wj, etc.
Expected behavior
Case sensitive match.
Environment

Vim 8.2.2150
macOS Catalina (version 10.15.7)
iTerm2

A match with the same case is better than a match with different case. However, help tags for control keys always use CTRL-A to CTRL-Z in all caps, and that counts in determining if it is "the same case". If you use :help ctrl-w_h, the ctrl-w part is in a different case, so you get the first match found, which might have H rather than h.
For a same-case match, use :h CTRL-W_h with CTRL-W in all caps, and you'll get the case-matching help tag.
Best regards,
Tony.

A match with the same case is better than a match with different case. However, help tags for control keys always use CTRL-A to CTRL-Z in all caps, and that counts in determining if it is "the same case". If you use :help ctrl-w_h, the ctrl-w part is in a different case, so you get the first match found, which might have H rather than h.
For a same-case match, use :h CTRL-W_h with CTRL-W in all caps, and you'll get the case-matching help tag.
Best regards,
Tony.

Thank you. I understood this is not a bug.
But I still think it would be more user-friendly if :h ctrl-w_h matches CTRL-W_h rather than CTRL-W_H.
Is it possible to change this behavior?

Thank you. I understood this is not a bug.
But I still think it would be more user-friendly if :h ctrl-w_h matches CTRL-W_h rather than CTRL-W_H.
Is it possible to change this behavior?

Thank you. I understood this is not a bug.
But I still think it would be more user-friendly if :h ctrl-w_h
matches CTRL-W_h rather than CTRL-W_H.
Is it possible to change this behavior?

I would argue that if five characters match when changed from lower to
upper case, a match with the same change to the sixth character is
preferred.
--
hundred-and-one symptoms of being an internet addict:
176. You lie, even to user-friends, about how long you were online yesterday.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thank you. I understood this is not a bug.
But I still think it would be more user-friendly if :h ctrl-w_h
matches CTRL-W_h rather than CTRL-W_H.
Is it possible to change this behavior?

I would argue that if five characters match when changed from lower to
upper case, a match with the same change to the sixth character is
preferred.
--
hundred-and-one symptoms of being an internet addict:
176. You lie, even to user-friends, about how long you were online yesterday.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I would argue that if five characters match when changed from lower to upper case, a match with the same change to the sixth character is preferred.

I suppose that's fair enough. However in the case of the shortcut form :h ^wh I would have hoped and expected that this would resolve to :h CTRL-W_h, not :h CTRL-W_H, as ^w can only resolve to CTRL_W. Meaning that to get to the correct help tag for CTRL-W_h you have to capitalise the W, which doesn't have anything to do with the h part of the command.

Command
Currently result
More natural result (in my opinion)

:h ^wh
:h CTRL-W_H
:h CTRL-W_h

:h ^wH
:h CTRL-W_H
:h CTRL-W_H

:h ^Wh
:h CTRL-W_h
:h CTRL-W_h

:h ^WH
:h CTRL-W_H
:h CTRL-W_H

I would argue that if five characters match when changed from lower to upper case, a match with the same change to the sixth character is preferred.

I suppose that's fair enough. However in the case of the shortcut form :h ^wh I would have hoped and expected that this would resolve to :h CTRL-W_h, not :h CTRL-W_H, as ^w can only resolve to CTRL_W. Meaning that to get to the correct help tag for CTRL-W_h you have to capitalise the W, which doesn't have anything to do with the h part of the command.

Command
Currently result
More natural result (in my opinion)

:h ^wh
:h CTRL-W_H
:h CTRL-W_h

:h ^wH
:h CTRL-W_H
:h CTRL-W_H

:h ^Wh
:h CTRL-W_h
:h CTRL-W_h

:h ^WH
:h CTRL-W_H
:h CTRL-W_H

I suppose it would be possible but would it be worth while ? IIUC it would mean going through all help files searching for help tags beginning with *CTRL- and adding a second tag with *ctrl- instead. (I don't suppose that camel-case tags such as CtRl-X would be of any use.)
AFAIK, Vim seasoned users have taught themselves to search for control keys in the help by using CTRL-@ CTRL-A etc. in all caps.
Best regards,
Tony.

I suppose it would be possible but would it be worth while ? IIUC it would mean going through all help files searching for help tags beginning with *CTRL- and adding a second tag with *ctrl- instead. (I don't suppose that camel-case tags such as CtRl-X would be of any use.)
AFAIK, Vim seasoned users have taught themselves to search for control keys in the help by using CTRL-@ CTRL-A etc. in all caps.
Best regards,
Tony.

I would argue that if five characters match when changed from lower to upper case, a match with the same change to the sixth character is preferred.

I see, that is more reasonable.

However in the case of the shortcut form :h ^wh I would have hoped and expected that this would resolve to :h CTRL-W_h, not :h CTRL-W_H, as ^w can only resolve to CTRL_W.

I also expect that.
Isn't it possible to solve this issue by changing the matching algorithm of :help {subject} command?
I think we can do it by replacing the ^[xX] in {subject} with CTRL-X.
I guess, in the current implementation, ^ is simply replaced by CTRL-.

I would argue that if five characters match when changed from lower to upper case, a match with the same change to the sixth character is preferred.

I see, that is more reasonable.

However in the case of the shortcut form :h ^wh I would have hoped and expected that this would resolve to :h CTRL-W_h, not :h CTRL-W_H, as ^w can only resolve to CTRL_W.

I also expect that.
Isn't it possible to solve this issue by changing the matching algorithm of :help {subject} command?
I think we can do it by replacing the ^[xX] in {subject} with CTRL-X.
I guess, in the current implementation, ^ is simply replaced by CTRL-.


Update NL integration test goldens

Updates our NL integration test goldens via ./run_test.sh -g.
Per our release docs, our NL tests rely on staging mixer, so the goldens need to be updated after a mixer release to staging. These updated goldens reflect the data changes from this mixer commit: https://github.com/datacommonsorg/mixer/commit/75c03483a4e843bb77ad71c3e0a6694a2ff39dd0

@chejennifer @pradh These changes just look like floating point error-esque differences. Do we need this update?

thanks! but did you mean to include the mixer submodule change?

Yup, wanted to keep the changes together with the mixer version that generated these files -- was waiting on https://github.com/datacommonsorg/website/pull/4522 to merge. The mixer change diffs have gone away after updating the branch with latest changes.


Show lint errors in the debugger

Description
We are not showing lint errors in the debugger. This MR addresses this issue
Fixes #5661
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
This has been manually tested

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/linting-errors

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
51.49 (-0.01)
33.5 (-0.01)
29.3 (0)
52.13 (0)

:red_circle:
app/client/src/components/editorComponents/Debugger/index.tsx
87.5 (-1.07)
40 (-10)
84.62 (-7.05)
89.74 (1.17)

:red_circle:
app/client/src/sagas/PostEvaluationSagas.ts
17.81 (-2.35)
0 (0)
0 (0)
22.41 (-1.66)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.83 (0.24)
40.25 (0.84)
36.21 (0)
55.04 (0.27)

There are two logs for the same error

There are two logs for the same error

Can we do something about this @vnodecg ? I think it is because one is a PARSE error and another is a LINT error

There are two logs for the same error

Can we do something about this @vnodecg ? I think it is because one is a PARSE error and another is a LINT error

We need to pick out the parse errors. We don't have an automated way right now. We can blacklist some parse errors that are duplicated

Accidentally closed it

Closing this since we are merging this with #6265


add better support for SD cards

local-music plugin:
some devices mount storage to /storage which is not listed when mounting with / which defaults to /mnt

fixed in version #52


Create React_Bootstrap_modals.md

Added a page to the wiki for the modal component of React-Bootstrap, which allows for a pop-up that can be used to notify the user or extract information. The introduction goes over the setup, how to connect the display and dismissal to a button, and how to extract information from the user.

Thanks for your feedback regarding my table of contents, phrasing, variant explanation, and typos. I have adjusted everything accordingly, please have a look.
In terms of a relevant use case, I said the modal could "notify the user or obtain user information.". I think this is a very common and useful feature that is needed for most 301 projects.


Cannot install

cd "C:\Users\users1\AppData\Roaming\Hyper\.hyper_plugins\node_modules\hypergravity"
$ yarn
yarn install v1.22.0
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
info<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...
$ yarn build
yarn run v1.22.0
$ npx webpack
npx: installed 1 in 8.876s
Path must be a string. Received undefined
C:\Users\user1\AppData\Roaming\Hyper\.hyper_plugins\node_modules\hypergravity\node_modules\webpack\bin\webpack.js
No configuration file found and no output filename configured via CLI option.
A configuration file could be named 'webpack.config.js' in the current directory.
Use --help to display the CLI options.
error Command failed with exit code<PHONE_NUMBER>.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code<PHONE_NUMBER>.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

npx is latest version

Which version of Hyper do you use? In general, I stopped supporting this plugin when I found out it would need a major rewrite to work with Hyper 2.0, see #20.


spin button enables, when item-selector closed

closing the item-selector enables the spin button, even though no playernumber is selected
-> causing an endless loop

fixed but need to be merged

fixed but not merged because of solution in #6


modcharts?

if you do add modcharts, please add kade engine modchart support thanks

if you do add modcharts, please add kade engine modchart support thanks

cant wait for him to come here and just say
no.

Why you want another Kade Engine?

we already have modcharts
they're script files

we already have modcharts
they're script files

Lol true 🟦
🟥
             Sus


Using deal for OUSD token

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (06f7c9c 2023-03-18T00:16:11.192812Z)
What command(s) is the bug in?
No response
Operating System
macOS (Apple Silicon)
Describe the bug
Calling deal when trying to mint OUSD (0x2A8e1E676Ec238d8A992307B495b45B3fEAa5e86 - mainnet) returns the following error below.
[FAIL. Reason: stdStorage find(StdStorage): Slot(s) not found. Counterexample: calldata=0x202da9aa0000000000000000000000000000000000000000000000000000000000000000, args=[0]]

The OUSD contract's balanceOf method dynamically computes the balance to return (like a rebase token), whereas the deal cheat only supports tokens that return balanceOf by reading a value directly form a storage slot, because deal works by changing the value in the balanceOf storage slot. As a result this token is not currently supported by forge-std, similar to https://github.com/foundry-rs/forge-std/issues/140
As a workaround you can find an OUSD whale from etherscan, prank as that user, and transfer tokens to any address you need
(For future reference, deal for tokens is a forge-std cheat, not a native forge cheat, so this issue should be in the forge-std repo)


[sparse] slice_axis for csr, cpu implementation

Description
slice_axis for csr, cpu implementation. This is used in cases like Wide & Deep model, e.g., slice the linear features to feed into wide model.
As a feature request in https://github.com/apache/incubator-mxnet/issues/8168.
cc @eric-haibin-lin for review
Checklist
Essentials

[x] Passed code style checking (make lint)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] For user-facing API changes, API doc string has been updated.
[x] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] slice_axis for csr, cpu implementation, add unittest

Comments

If this change is a backward incompatible change, why must this change be made.
Intersting edge cases to note here

I think slice axis is deprecated, we are using slice now

OK, I will change it to slice.


PEM/PFX instructions require windows or .NET?

Can you change the PEM/PFX instructions to be more broad to other operating systems and environments? Of does azurite only work on windows with .NET installed?

@diberry
There are quite a few ways to generate cert for Azurite.
We have documented several ways in https://github.com/Azure/Azurite#generate-pem-certificate-and-key
For the first way with tool mkcert. The tool do support mac and Linux (and windows). So this way should work mac and Linux. Would you please try it?
See more details for how to install and use mkcert on Linux and Mac in: https://github.com/FiloSottile/mkcert


Cross extension configuration

From a conversation in the meeting on 10/10/2019:
For classic server extensions loaded through load_server_extension it passed through all configuration set in traitlets down to the extensions.
The filtering of configuration based on the base application class would mean it is difficult to communicate configuration for server extension B when another server extension (A) is being used as the main ExtensionApp.
We use this in bookstore to get access to the relevant s3 configuration parameters that are set on the BookstoreSettings Configurable:
def load_jupyter_server_extension(nb_app):
    web_app = nb_app.web_app
    host_pattern = '.*$'

    base_url = web_app.settings['base_url']

    bookstore_settings = BookstoreSettings(parent=nb_app)

@Zsailer

Just to makes sure I understand this, there are three(?) cases of wanting to access config from another extension:

Extension A wanting to look at the config of extension B, where A is the ExtensionApp.
Extension A wanting to look at the config of extension B, where B is the ExtensionApp.
Extension A wanting to look at the config of extension B, where C is the ExtensionApp.

Is this what you are talking about, and if so, are any of these cases more relevant than the others?

The filtering of configuration based on the base application class would mean it is difficult to communicate configuration for server extension B when another server extension (A) is being used as the main ExtensionApp.

I'm unsure where this filtering happens (I'm not that familiar with this part of the code). Would you mind sharing where this happens / which bits break things compared to notebook?

@mpacer I don't have the answer to your question but I find it very important and we should support as much as cases as possible and should document/demo them.
I have created a simple example PR where there is 2 extensions and how a user can launch one or the other or both at the same time.
I have not focussed on the settings aspect, but if you have a look to the source code, you should be able IMHO to hack a bit and see how the settings can be accessed or not.

This is solved by #180.
Extensions are now loaded in two steps:

init_server_extensions discovers and initializes each extension app before the tornado web app is created. All config is parsed+loaded, first, by the ServerApp (replacing NotebookApp), then passed down to each extension. It doesn't matter which extension starts the ServerApp, the ServerApp is the single source of truth for config and all extensions inherit the general config object. See this comment for configuring multiple extensions from the CLI.
load_server_extensions calles the _load_jupyter_server_extensions function to append handlers to the server.

Oops, didn't mean to close this yet.
This should be closed once #180 is merged.

Solved in #180 🚀


Fix build

quay.io discovery (swagger) seems to intermittently die today

Coverage decreased (-0.2%) to 68.196% when pulling af694bed36dde9dc2b2f71fe48832ad53d45b6ba on feature/copy_of_quay_api into 649cad4bfb11b7dadb2b954d712fb9b522c2eb69 on develop.


[docs] Spelling Error: ComposedTextField.js/tsx

Suggest the initial state 'Composed TextField' be changed to 'Composed Text Field' to remove browser rendered spelling error.

[ ] I have followed (at least) the PR section of the contributing guide.

Thanks for the feedback
"TextField" refers to the component which is named TextField not to a generic "text field". Hope this clears things up.


Missing Prometheus alerts due to prometheus-config-reloader error

What did you do?
Fresh install of prometheus-operator using the contrib/kube-prometheus/hack/cluster-monitoring/deploy
What did you expect to see?
I expect to see alerts populated in Prometheus
What did you see instead? Under which circumstances?
Missing alerts and error in prometheus-config-reloader logs
Environment
CentOS
CNI = calico

Kubernetes version information:

Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Using prometheus-operator:v0.18.1

Kubernetes cluster kind:

kubeadm & above prometheus-operator installs on CentOS

Manifests:

Used all the manifests per install documentation.

Prometheus Operator Logs:

Logs from prometheus-config-reloader
ts=2018-04-30T13:59:49.058183023Z caller=main.go:217 component=volume-watcher msg="Reloading Prometheus temporarily failed." err="Post http://localhost:9090/-/reload: dial tcp <IP_ADDRESS>:9090: connect: connection refused" next-retry=566.399851ms

I confirmed the prometheus process has: --web.enable-lifecycle
I confirmed the rules are in place:
# kubectl -n monitoring exec -it prometheus-k8s-0 -c prometheus -- ls -l /etc/prometheus/rules/rules-0
total 48
-rw-r--r--    1 1000     2000          1342 Apr 30 14:15 alertmanager.rules.yaml
-rw-r--r--    1 1000     2000          5007 Apr 30 14:15 etcd3.rules.yaml
-rw-r--r--    1 1000     2000          1348 Apr 30 14:15 general.rules.yaml
-rw-r--r--    1 1000     2000           520 Apr 30 14:15 kube-controller-manager.rules.yaml
-rw-r--r--    1 1000     2000          2496 Apr 30 14:15 kube-scheduler.rules.yaml
-rw-r--r--    1 1000     2000          2294 Apr 30 14:15 kube-state-metrics.rules.yaml
-rw-r--r--    1 1000     2000          1789 Apr 30 14:15 kubelet.rules.yaml
-rw-r--r--    1 1000     2000          4456 Apr 30 14:15 kubernetes.rules.yaml
-rw-r--r--    1 1000     2000          2084 Apr 30 14:15 node.rules.yaml
-rw-r--r--    1 1000     2000          3815 Apr 30 14:15 prometheus.rules.yaml

This part seems strange: localhost seems to be resolved to <IP_ADDRESS>. That should not be the case. Any idea why this might be happening?

Could you check the content of /etc/hosts file of that container?

It looks like someone has added localhost to our internal DNS
/etc/hosts
<IP_ADDRESS>   localhost localhost.localdomain localhost4 localhost4.localdomain4
::1         localhost localhost.localdomain localhost6 localhost6.localdomain6

<local ip>  <fqdn> <hostname>

/etc/resolv.conf
search <my domains>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

#  nslookup localhost
Server:         X
Address:        X#53

Name:   localhost.<our domain>.org
Address: <some other ip>

# kubectl -n monitoring exec -it prometheus-k8s-0 -c prometheus-config-reloader -- cat /etc/hosts
# Kubernetes-managed hosts file.
<IP_ADDRESS>       localhost
::1     localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
fe00::0 ip6-mcastprefix
fe00::1 ip6-allnodes
fe00::2 ip6-allrouters
<IP_ADDRESS>  prometheus-k8s-0.prometheus-operated.monitoring.svc.cluster.local       prometheus-k8s-0

I guess I would have expected the container to use above local /etc/hosts file entry.

Once we resolved the internal localhost DNS entry the alerts appeared as expected.


Nitro fails to show version, updates – but appears to still work?

Description
I followed the installation instructions, and completely removed multipass from my Mac. I installed through homebrew, and when I checked the version number, I got:
nitro version
Error: unable to get version from the gRPC API

Naturally, I just tried to re-update, but I'm up-to-date
nitro self-update
Checking for updates
up to date!

nitro update
Error: there is no config file for the environment

I'm not sure what config file its referencing, as there isn't one mentioned in the instructions. nitro help also outputs all of the options, as expected – so some commands work.
Is this just a bug?

Steps to reproduce

Uninstall Nitro 1
Install Nitro 2

Additional info

Nitro version: 2.0.3
Docker version: 3.1.0

@OneMohrTime the version command is used to get the version of Docker, Nitro API (gRPC), and the CLI version.
From the error message above, it appears you did not run nitro init which is why it cannot talk to the API that does not exist.
To get the CLI version from Nitro, you can run nitro -v.
Perhaps we should update the version command to suggest running start or init to make it more user friendly.

Totally got it after that. I wasn't paying full attention during the switchover, I should have read more closely 🤦

@OneMohrTime the next release will check if the init command has been run and prompt the user to run init before continuing.

Great solution!

This was released with 2.0.4!

I still get this error Error: unable to get version from the gRPC API with nitro 2.0.8.


chore: Add action to warn about potentially risky PR changes

:scroll: Description

Implement a mechanism that automatically adds an "alert" comment to PRs if they include changes to files we think have higher potential to break things than others.
:bulb: Motivation and Context

same as https://github.com/getsentry/sentry-java/pull/3726
:green_heart: How did you test it?
✅ by adding the file-filter.yml introduced in this PR to the list of potentially risky changes and ensuring that an alert is shown

:pencil: Checklist

[x] I reviewed submitted code
[ ] ~I added tests to verify changes~
[ ] ~No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled~
[ ] ~I updated the docs if needed~
[ ] ~All tests passing~
[ ] ~No breaking changes~

:crystal_ball: Next steps
#skip-changelog

@buenaflor do you have more additions in mind? I wanna wrap this up soon-ish :)

No, I was about to write that this is good now :D
If I see something over the next few days that's alarming I'll add it

No, I was about to write that this is good now :D
If I see something over the next few days that's alarming I'll add it

cool 👍 this is meant to be a living list anyway, whenever something makes sense to add, we do it


Download SEAL library on MacOS Majove version (10.14.5)

Download SEAL library on MacOS Majove version (10.14.5)
I am working on MacOs Mojave version 10.14.5 (18F132). I installed SEAL library from (cmake-3.13.5-Darwin-x86_64.dmg) from the link https://cmake.org/download/. Then, I built .NET apps from the link (https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install). I wrote in the terminal (dotnet command) as instructed but it didn't work.

@Malkharji when you say "it didn't work", what was the exact problem you encountered? Please provide more details.

Closing due to inactivity. @Malkharji feel free to reopen if you have more info, we will be happy to help.


fix: error when inserting multi line string(#149)

fixes #149

@haorenW1025 Thank you for this! This has been popping up for a while on my machine.
While you're working on this, could you precise whether the completion items that this PR will "fix" are understood as snippets, or simply as text? Can snippet-like completion items return by the Language server can have different placeholders with default value can can be navigated using vim-vsnip/vim-vsnip-integ?
Currently, the completion item this PR fixes are not understood as snippets by on my machine, simply as plain code (e.g I can't use vim-snip mappings to navigate between placeholders in select mode.
I guess this discussion is also related to https://github.com/neovim/neovim/pull/12118
Any info would be appreciated :)

Hmm I think vim-vsnip works fine in this PR on my side, do you have a step to reproduce?

Sure, simply, can you give me one example of snippet that comes from, say sumneko, and that FOR SURE (e.g, it works on youre machine) be expanded using completion-nvim and vim-vsnip/vim-vsnip-integ? So I can try on my machine. I'd rather do that than give you false negatives.

Yeah I use sumneko, just try the completion for, it works fine on my side.

minimal vimrc
set completeopt=menuone,noinsert,noselect
set shortmess+=c

let g:completion_enable_snippet = 'vim-vsnip'

packadd! completion-nvim
packadd! nvim-lsp

packadd! vim-vsnip
packadd! vim-vsnip-integ

imap <expr> <Tab>   vsnip#available(1)  ? '<Plug>(vsnip-expand-or-jump)' : '<C-l>'
imap <expr> <C-j>   vsnip#available(1)  ? '<Plug>(vsnip-jump-next)'      : '<Tab>'

lua << EOF
  local nvim_lsp = require'nvim_lsp'
  local custom_attach = function()
    require'completion'.on_attach()
  end

  nvim_lsp.sumneko_lua.setup{
  on_attach= custom_attach;
  settings = {
    Lua = {
      completion = {
        keywordSnippet = "Enable";
      };
      runtime = {
        version = "LuaJIT";
        };
      diagnostics={
        enable=true,
        globals={
          "vim", "Color", "c", "Group", "g", "s", "describe", "it", "before_each", "after_each"
        },
      },
    },
  };
}
EOF

Using the for .. in snippet, I get for key, value in pairs(t) do      end, but then I cannot hit <C-j> to go navigate to key in select mode, as I would expect in a snippet. I can try to provide a screen-recording later on tonight.

Hmm I've found out that if you enter insert mode and jump it works fine...Not sure what's the cause though. @hrsh7th any thought on this?

It was miss configuration.
imap <expr> <Tab>   vsnip#available(1)  ? '<Plug>(vsnip-expand-or-jump)' : '<Tab>'
imap <expr> <C-j>   vsnip#available(1)  ? '<Plug>(vsnip-jump-next)'      : '<C-j>'

to
imap <expr> <Tab>   vsnip#available(1)  ? '<Plug>(vsnip-expand-or-jump)' : '<Tab>'
imap <expr> <C-j>   vsnip#available(1)  ? '<Plug>(vsnip-jump-next)'      : '<C-j>'
smap <expr> <C-j>   vsnip#available(1)  ? '<Plug>(vsnip-jump-next)'      : '<C-j>'

It was miss configuration.

I still cannot enter select mode with those lines @hrsh7th

Hmm I've found out that if you enter insert mode and jump it works fine...Not sure what's the cause though. @hrsh7th any thought on this?

So you're saying that with my minimal init.vim you cannot reproduce my issue?
Also, I use neovim master, maybe neovim/neovim#12118 is causing an issue. What version of neovim do you use?

My sumneko_lua settings are below.
  lua require'nvim_lsp'.sumneko_lua.setup{
  \   capabilities = {
  \     textDocument = {
  \       completion = {
  \         completionItem = {
  \           snippetSupport = true
  \         }
  \       }
  \     }
  \   },
  \ }

Could you test with it?

Thanks, do you have a minimal init.vim too?

OK, I will try with minimal init.vim. Please wait.

@pierreglaser Sorry, I couldn't work almost it with minimal init.vim...
Could you tell me the your using language server that can be easy setup.

To reproduce, I'm using sumneko with the exact same configuration as you, plus the 'compltion'.on_attach() callback.
The minimal init.vim is shared here: https://github.com/nvim-lua/completion-nvim/pull/150#issuecomment-658311834
If you have a minimal configuration that works, please share it so I can try it :)

OK, I will provide vim-language-server's minimal configuration (this language server can be easy to setup).

@hrsh7th @haorenW1025 My bad, I actually needed to press <CR> to confirm the completion suggestion, which expands the snippet. This was unintuitive to me for some reason, partly because it does not match the mapping used by vim-vsnip. I think this deserves a note in the README. Thanks for helping out.

Thank you for your investigation.
It is good to hear!

@pierreglaser Okay that's fine:) I'll add a note to README:)

This should be fixed in a new commit.


go.mod file still referencing github.com/zellyn/kooky

In go.mod file we are still referencing github.com/zellyn/kooky because of which a new go mod init followed with go mod tidy will fail when importing kooky project to the new project.
Will get error -
github.com/browserutils/kooky<EMAIL_ADDRESS>parsing go.mod:
module declares its path as: github.com/zellyn/kooky
but was required as: github.com/browserutils/kooky
This is due to in https://github.com/browserutils/kooky/blob/master/cmd/kooky/kooky.go#L11 we still refer to github.com/zellyn/kooky

fixed with https://github.com/browserutils/kooky/pull/71


Report back to user if email is invalid

fixed #660

Hi @Aslam97 I don't think we should be telling users if an email exists in the system or not. Something we could do is show the notification regardless of the email's existence.

We definitely should NOT be indicating if an email exists or not, that would be a security issue.

@markmead @glennjacobs What are the best words in your opinion to tell that the email you entered is wrong? at least there is a notification to the user. so I can update the PR

@Aslam97 I would just remove this https://github.com/lunarphp/lunar/blob/develop/packages/admin/src/Http/Livewire/Components/Authentication/PasswordReset.php#L107-L109 outside of the if statement.

@markmead i've update the PR


fix missing parenthesis

Thanks @computergeek1507 for fixing this so quickly! Just tested with V8.99 and it works perfectly 🚀


BookStore CMS

Initialise React app
Add react router

Thanks for your review bro, your feedback was clear and helpful.
On Tue, Mar 8, 2022 at 9:02 PM Michael Threels @.***>
wrote:

@.**** requested changes on this pull request.
Hi Ak,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In src/pages/bookPage.js
https://github.com/ismailakinkunmi/book-store/pull/1#discussion_r822023779
:

+const bookPage = () => (

Action

The Hunger Games

Suzanne Collins

Comments

Remove

Edit

according to the requirements:
booksPage - the default view

Should display the list of books (empty at this point but it
should be ready for the data) with the Remove button (no functionality yet)

Create a component called Book for displaying a single book
and reuse it in a component that displays a list of books.

this means that the list of books you're adding to this component right
now should be rendered separately in a book component
—
Reply to this email directly, view it on GitHub
https://github.com/ismailakinkunmi/book-store/pull/1#pullrequestreview-903517532,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI5YZRXSXHG4A5B4H5MHXO3U66W5VANCNFSM5QHKDDIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Search / feature list: download results

Version: 3.2.9 beta
URL: https://www.beta.patricbrc.org/
User ID: KPNs_4_Houston
I am trying to download a table for "PGF_00059805". I can't do it on
production or beta.

Here is some more information:
Global search: "PGF_00059805" -> go to feature list -> download all results as text/csv/excel
text and csv came up blank....excel results in crash.

I'm not seeing this problem at all.  All three work for me with this same search.  Need some more information.

patric3_genome_feature_query.txt

Attached an example of what the text download downloaded for me.

ok, this seems to be working now!
However,the order of the columns in the downloaded file seems random! We need to organize them to be more appealing to the users.
Also need to make sure that the columns are consistent in text, csv and excel files.
-Maulik


Actualisation: splitting up the results in multiple layers: automatic - To-check; not changed

When using the Actualisation-function, a resultin (group) layer is made with a extra attribute 'evaluation' where you can search for the:
*equalities
*To checks
*No changes
A user gave  as suggestion to split them up in seperate layers

At least there has to be a difference/Hierarchy when automatic results are found:
At the moment for all predictions an evaluation is made and all variants are returned, but when a fully match is found; all other variants does not have to be returned anymore


Updated Webstorm to 2019.1.4 with v0.84-2019.1 not working

plugin version:
v0.84-2019.1
Description
Updated Webstorm to 2019.1.4 & the reasonml-idea-plugin stopped working (the files are displayed as the default text styles). Currently have latest v0.84-2019.1 installed.
thanks

I've seen it recently for a mac user, don't know the root cause

can you update to 0.90 ?

I think IntelliJ is just disabling plugins after major version updates.. not sure what heuristics they are using but I am constantly facing this after updates

I can confirm that reasonml-idea-plugin 0.91-2020.1 is now working as of Webstorm 2020.1.4  so closing this issue.


Code release

Hello, may I ask what specific date will you release the codes? Thank you.

Sorry for the delay. The code has been released.


Connect streams

Suggested resolution to #44 . It makes a big difference when visualizing graphs and I'm using it now, so I thought I'd already go ahead and send it. Please let me know if there are better ways.
From issue, changing from s2.map(s1.emit) to s2.connect(s1) leads to difference of the two figures:
s2.map(s1.emit) : http://imgur.com/a/0Z0JA
s2.connect(s1) : http://imgur.com/a/rcrX0

Codecov Report

Merging #45 into master will decrease coverage by 0.12%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   97.48%   97.35%   -0.13%
==========================================
  Files           9        9
  Lines         994     1022      +28
==========================================
+ Hits          969      995      +26
- Misses         25       27       +2

Impacted Files
Coverage Δ

streams/tests/test_core.py
99.42% <100%> (+0.03%)
:arrow_up:

streams/core.py
97.8% <77.77%> (-0.59%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3611d00...a18f749. Read the comment docs.

Can anyone think of a more specific name than connect?  Arguably all operations connect two streams.

branch?

It might be useful to look at other projects to see if they have such a
construct and then see what names they use.
On Fri, Jul 28, 2017 at 12:30 PM, Julien Lhermitte<EMAIL_ADDRESS>
wrote:

branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streams/pull/45#issuecomment-318700810, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszJGVywjB1DRS4kGWOtlUx1MJNmmmks5sSgy8gaJpZM4OlsaA
.

sink_to_stream?

( @CJ-Wright agreed about examples I'll add examples later on this evening or worst case late weekend, occupied here).

I checked spark-streaming and apache flink but don't see something obvious as of now. Will check again later, I do like sink_to_stream though.
Another option is to have map and sink take a stream as an argument. (But I would vote against and rather be more explicit)

I have checked and as far as I can see, I don't see an obvious analogue to this. I am a bit surprised. I must have missed something.
The libraries I have gone through are:

spark-streaming
apache flink
apache Beam
RxPy

To be honest, I haven't been able to spend that much time, but I don't see anything.
I'd vote for sink_to_list. It could eventually be superseded by a briefer term.

I'm not sure if you guys are interested; but for the case of multiple outputs from one stream object and other stream objects wanting to take those, I was outputting a dictionary in my emit statements and taking a secondary argument in my sink to stream which was the key.

Sorry, on phone, will put this in my own pull request when I get to laptop

yeah PR would help, could you please mention us? (just in case)
Also, maybe syntax highlight the code you have using github's markdown syntax.
Please include an example or unit test in PR as well, it will save a lot of time to review/understand the code.

Was there a spec for putting out multiple streams?

Aside from some cleanup LGTM

sounds good. personally, i like subscribe better as @elementace suggested.
but connect is also fine.

(and we need @mrocklin 's opinion on this before making any merge decision of course)

One of the nice features I think that comes from this is that you can make a library(s) of streams, putting different chunks of a pipeline into modules, load them into a script, and use this PR's mechanism to plumb them all together.

FYI : it seems that subscribe is basically the same as connect in ReactiveX:
http://reactivex.io/documentation/observable.html
It may make more sense to rename to this? @mrocklin, @CJ-Wright ? Any preference?

I am not sure if we have a connect in the same way as RX does but I still don't have a preference for the name.

@ordirules I am on board with connect or subscribe can you please rebase and go with one or the other? I'll try to merge tonight.

finished a run then dinner. will get back in 2 hrs
Sent from my iPhone

On Aug 17, 2017, at 6:22 PM, Christopher J. Wright<EMAIL_ADDRESS>wrote:
@ordirules I am on board with connect or subscribe can you please rebase and go with one or the other? I'll try to merge tonight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry I didn't mean to put you under pressure. Take your time.

no worries. just trying to emphasize im def motivated to have this one in!
Sent from my iPhone

On Aug 17, 2017, at 7:40 PM, Christopher J. Wright<EMAIL_ADDRESS>wrote:
Sorry I didn't mean to put you under pressure. Take your time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

pushed but didn't have time to check the coverage

Codecov seems to be having issues as a check, here is the link
https://codecov.io/gh/mrocklin/streamz/tree/e4102be4d8ab0ccafd8360f339b4dad2c0524ee6/streamz
Coverage seems fine though, so merging


docs: Fix Input Mask Example

Changes proposed
On setValue method ref.setInputValue was setting always an empty string causing problems when we set a default value.

Hello @dayvsonsales, i merged your suggestion into Unform, i needed to merge it myself as your commit message was extrapolating the 72 column limit.
Thanks for the contribution!


typo fix - Infrastructure

Intrastructure > Infrastructure

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/guide/technology-choices/compute-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Can't get fake connection when using USE_REDIS_CACHE

Describe the bug
When using django-rq, configured using USE_REDIS_CACHE to point to a cache configuration for Redis, it's not possible to get a fake connection, as it expects either an explicitly configured HOST etc, or URL variables.
See the upstream implementation. Notably, this should probably also handle both USE_REDIS_CACHE and UNIX_SOCKET_PATH
To Reproduce
Steps to reproduce the behavior:

Configure django-rq using USE_REDIS_CACHE
Attempt to use get_fake_connection

Expected behavior
I get a fake Redis connection

Can you share a stacktrace? it is not clear the cause of the issue.
the from_url method does not require host/post. In the link you provided in django-rq, it uses from_url.
Perhaps the issue is in django_redis package, I see there is from django_redis import get_redis_connection as get_redis

Closing this. Please reopen with more details


Maint: fix comprehensive test-suite

The cache key was updated for test_pull_request, but not for test comprehensive, leading to main to fail CI for this item.

Same as #5357 that I missed earlier. Closing.


Update to Symfony 5

Fixes #26

I guess you would need to upgrade phpspec to a version that supports php7.3 or php7.4... (at least version v6.1.0 to support php 7.4)

Hi,
Travis crashes because obsolete SF version crashes....
Can we drop support of SF 4.0 to 4.3? And this PR can be merged...
Cheers,
EM

Hello,
Any update / plans with this upgrade?
Thanks, Gergo

Hello,
Any update / plans with this upgrade?
Thanks, Gergo


Updating NPM version

Hello can you update the package on npm so that we get the latest version ?
Thanks for your great work!

I'm going to work on finalizing the RN SVG integration and merging into master before bumping NPM. Afraid there might be incompatibilities as a result of my inability to maintain the lib until recently.

As a generic FYI — I am no longer able to maintain this library. I recommend checking out victory-native as it's much more maintained.


Update dependancies

Build Number: 2.1.1
Description:
As you can read here in an official RN blog from July, to publish on the android store we'll need to upgrade mSupply Mobile to run on at least RN 0.56 if we are to update the app published on the app store next month, or possibly already need to because it's currently unpublished (I think that's their terminology).
So:

[ ] Update react-native to at least 0.56 (0.57 is the latest). You'll need to follow the release notes of each release of RN to make sure any require changes (if any) are met!
[ ] Update the rest of dependancies where necessary or convenient. Some will likely have peer dependancies tied to react/RN versions.

Comments:

Probably be incremental with your commits, so you can peel back if certain sets of modules are incompatible.
ListView is deprecated, but probably still available in RN 0.56. If it's fully cut from RN API we'll need to commit to rewriting react-native-data-table with FlatList, too.

https://github.com/sussol/mobile/pull/741


How to dynamically add and remove columns

I was wondering the best approach to be able to dynamically add or remove columns. I have data objects with many more fields than I want to display and I want to let the user select the columns they want.
Right now all the column properties are defined on the TH elements in the table head. It would be nice to be able to define them on a watched object in the parent controller scope. I'm not an angular expert and would appreciate any pointers.

Can you share that with us malplayer. thanks